Do not expose phc api

Checklist

[ ] If applicable, unit tests
[ ] If applicable, create follow-up issues for purchases-android, purchases-ios and other
hybrids

Motivation

Description
This Integration branch has the changes in order to be able to hide the PHC API

          1 Warning

:warning:
This PR increases the size of the repo by more than 100.00 KB (increased by 199.60 KB).

  Generated by :no_entry_sign: Danger

@tonidero @vegaro
I think this can be merged, right? What do you think, squashing or not?
The intermediate commits are "broken", but it's a giant commit otherwise. Would be a wall you run into every time you check the git history. 😅

I would say normal merge, not squashing. But then, fix the CHANGELOG, so it only shows as one item. Putting it up for review!


renderRoutes from react-router-config work wrong

Version
react-router: 4.0.0
react-router-config: 1.0.0-beta.1
Test Case
https://github.com/kirsanv43/react-universal-starter-kit/blob/renderRoutesFromRRC/src/server.js#L39
I don't know, maybe I only one who has reproduced that bug and maybe that not relevant to this project.
Steps to reproduce
When I use renderRoutes method from a react-router-config package and go on any route then RR render only index page (/), when I copy renderRoutes function to my project and use it then all ok.

This is a bug tracker, not a support system. For usage questions, please use Stack Overflow or Reactiflux. Thanks!


New check: Complain on binary artifacts in source repos, e.g. jars, esp for third_party use

Is your feature request related to a problem? Please describe.
Third_party libraries might be checked in as binary artifact instead of building from source. These might be compromised artifacts, so discourage this bad security pattern.
Describe the solution you'd like
Check fail with details on binary artifacts used.
Describe alternatives you've considered
NA
Additional context
NA

Possible ideas:

OS binaries: .o, .so, .ko, elf (Linux), same for Windows/Macos
distro packages: .deb, .rpm, etc
language packages: .whl, etc
bytecode: .pyc, .jar

Looking for file types with the extension could be one way.
The right way to do it is to parse the file header and figure out the type. This is work has been done at https://github.com/h2non/filetype
We could start with this.

https://github.com/h2non/filetype#application
https://github.com/h2non/filetype#archive

I am not a fan of figuring based on extension alone without checking the contents of the file using the header. The confidence in our results would be higher we actually investigate the header which is done by filetype
Thoughts?

Looking for file types with the extension could be one way.
The right way to do it is to parse the file header and figure out the type. This is work has been done at https://github.com/h2non/filetype
We could start with this.

https://github.com/h2non/filetype#application
https://github.com/h2non/filetype#archive

I am not a fan of figuring based on extension alone without checking the contents of the file using the header. The confidence in our results would be higher we actually investigate the header which is done by filetype
Thoughts?

probably both. i think extensions is quick, but we should probably do libmagic based checking as well - https://man7.org/linux/man-pages/man3/libmagic.3.html [https://github.com/h2non/filetype is probably similar idea?]

Similar idea to filetype and libmagic is file -i command in Unix.

Looking for file types with the extension could be one way.
The right way to do it is to parse the file header and figure out the type. This is work has been done at https://github.com/h2non/filetype
We could start with this.

https://github.com/h2non/filetype#application
https://github.com/h2non/filetype#archive

I am not a fan of figuring based on extension alone without checking the contents of the file using the header. The confidence in our results would be higher we actually investigate the header which is done by filetype
Thoughts?

probably both. i think extensions is quick (we should definitely start from this), but we should probably do libmagic based checking as well - https://man7.org/linux/man-pages/man3/libmagic.3.html [https://github.com/h2non/filetype is probably similar idea?]

We could do that. Crawl, Walk and Run.
I am not a fan of libmagic because it brings other external dependencies which becomes an issue for our customers trying to run scorecard from their desktop and that was the reason for looking for something go native https://github.com/h2non/filetype repository.

Looking for file types with the extension could be one way.
The right way to do it is to parse the file header and figure out the type. This is work has been done at https://github.com/h2non/filetype
We could start with this.

https://github.com/h2non/filetype#application
https://github.com/h2non/filetype#archive

I am not a fan of figuring based on extension alone without checking the contents of the file using the header. The confidence in our results would be higher we actually investigate the header which is done by filetype
Thoughts?

probably both. i think extensions is quick (we should definitely start from this), but we should probably do libmagic based checking as well - https://man7.org/linux/man-pages/man3/libmagic.3.html [https://github.com/h2non/filetype is probably similar idea?]

We could do that. Crawl, Walk and Run.
I am not a fan of libmagic because it brings other external dependencies which becomes an issue for our customers trying to run scorecard from their desktop and that was the reason for looking for something go native https://github.com/h2non/filetype repository.

+1, native is better.
https://www.reddit.com/r/golang/comments/amt07f/h2nonfiletype_small_dependencyfree_and_blazing/

Edit - Any os dependent filetype checks are an issue especially when we are providing a binary for our customers to use,

I will take on this.

Going to take the file names with extensions for v1 of this implementation. Let me know if anyone sees that as an issue.

Going to take the file names with extensions for v1 of this implementation. Let me know if anyone sees that as an issue.

lets discuss this in today's meeting with @azeemshaikh38 @laurentsimon

Going to take the file names with extensions for v1 of this implementation. Let me know if anyone sees that as an issue.

lets discuss this in today's meeting with @azeemshaikh38 @laurentsimon

Sounds good.

fixed, closing.


[discussion]: Revisit and reframe Sprout in context of "framework"

What would you like to discuss?
I feel we've been drifting a bit from the concept of a framework. I'd like if we have more transparency in what was actually happening at the filesystem level (e.g. how are the files stored, what's their names, etc). And structure things so that people aren't dependent on Sprout/Seedcase in general (i.e. interoperability). So not only at the data/file level, but also the code level (as in the API).
For instance, how do the files and folders look like? I think this ties in with #189. And also, where they are saved, how to use them for other things, etc.

E.g. some ideas on the basics:

Where are files stored?
How are they named?
How does the file metadata connect with the files?

During the meetings, we discussed and agreed on emphasizing more of the code interface and how that can be used to create interoperable data/file outputs. We also agreed that we don't know enough about this so will spend some time and tasks (all the ones we created) to learn more and get more of an informed decision/perspective on this. So closing this issue in favour of the other issues.


Feedback on documentation section for configure alm accelerator in dataverse

Hi
Just got a little feedback on the documentation in this section.
https://docs.microsoft.com/en-us/power-platform/guidance/coe/setup-almacceleratorpowerplatform#install-the-alm-accelerator-in-dataverse

On the link below when setting up the alm accelerator.  It says go to github and download the latest version of the ALM accelerator.  In the image ive attached (at the bottom) you can see there are 2 packages which are alm accelerators.  It doesnt say in the documentation which I need to import or if I should be importing both.  I am assuming from the instructions later on it is the CenterofExcellenceALMAccelerator_1.0.20220303.1_managed.zip package that needs to be installed rather than the maker ALM one?

There looks to be a typo in the note section when telling about the graph API url we should configure.  Looks like a ; rather than a :
Is it = https;//graph.microsoft.com
It should be= https://graph.microsoft.com

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5d58c244-3aaa-48e6-8b6d-205521a0bc52
Version Independent ID: 5d58c244-3aaa-48e6-8b6d-205521a0bc52
Content: Set up ALM accelerator for Microsoft Power Platform components manually - Power Platform
Content Source: power-platform/guidance/coe/setup-almacceleratorpowerplatform.md
Service: power-platform
Sub-service: guidance
GitHub Login: @mikefactorial
Microsoft Alias: v-mikeochs

@michaelstephensonuk thanks for this adding a link to the April release docs issue in coe-starter-kit to track this and resolve in the next release.


write object failed if request set coap block2 option

I find that if i request read an object with large payload, wakaama do not use coap block transfer automatically.So i add coap bolck2 option to inform wakaama to use coap block2 transfer, and it worked. But when i write object, it failed with response code 402 and message "BlockOutOfScope", wakkama think request bock offset is 0 and reponse payload is also 0, so get this error.
two questions:
1、if response payload is 0, i think it should also work, right?
2、Is there a way when makaama find response payload is large it will automatically use coap block transfer?

This might be addressed by pull request #461. Can you check?

@sbernard31 @sbertin-telular discussed this with @tuve - block transfer is implemented and 2) is ok. We don't understand scenario 1). Unless you (or somebody) can provide an explanation how to test this we recommend closing the issue.

@qleisan  I don't get 1) too :sweat_smile:
@xuyouming1986 block transfer is available in master. (see #461)
Feedback are welcome
I close this issue but feel free to reopen (or create a new one) if you find something wrong.


iPXE booted tmpfs raspberry 8gb pi 4 has 50% root fs

Docs say that:

rootfstype=btrfs: Use btrfs in RAM for the writable root filesystem. The filesystem will consume more RAM as it grows, up to a max of 50%. The limit isn’t currently configurable.

but when btrfs is not in use, then it looks liek root is still 50%
bash-4.3# df -h
Filesystem      Size  Used Avail Use% Mounted on
devtmpfs        3.3G     0  3.3G   0% /dev
tmpfs           3.5G     0  3.5G   0% /dev/shm
tmpfs           1.4G   25M  1.4G   2% /run
tmpfs           4.0M     0  4.0M   0% /sys/fs/cgroup
tmpfs           3.5G  686M  2.9G  20% /
...

bash-4.3# free -h
              total        used        free      shared  buff/cache   available
Mem:          7.0Gi       1.9Gi       3.5Gi       1.3Gi       1.5Gi       3.2Gi
Swap:            0B          0B          0B

#227

#227

The tmpfs has to have either a fixed size in MB or a size relative to the RAM size. Having up to 50% used for files is the default. You can still use more than 50% of the RAM as long as you don't fill the file system.

The tmpfs has to have either a fixed size in MB or a size relative to the RAM size. Having up to 50% used for files is the default. You can still use more than 50% of the RAM as long as you don't fill the file system.


[IOTDB-6011] Move default database from IoTDBMetricsUtils to IoTDBConfig

It's more suitable to manage default database in IoTDBConfig instead of IoTDBMetricsUtils

coverage: 44.495% (+0.02%) from 44.475% when pulling 34d6d291b1ef9509d158283671579022e2ee66a5 on optimize/metric_constant into 0bf7d75ea4617c0c4a59f53bf9337828cde810ee on master.


Supporting dependency injection of types which implements IAsyncDisposable

Fixes #833
Original issue:
When the function code uses a dependency which implements IAsyncDisposable, our code throws when we call Dispose method of the DefaultFunctionContext, producing an exception like below (In this example ServiceBusClient is the dependency which implements IAsyncDisposable).

'Azure.Messaging.ServiceBus.ServiceBusClient' type only implements IAsyncDisposable. Use DisposeAsync to dispose the container.
at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngineScope.Dispose()
at Microsoft.Azure.Functions.Worker.DefaultFunctionContext.Dispose() in C:\Dev\OSS\azure-functions-dotnet-worker\src\DotNetWorker.Core\Context\DefaultFunctionContext.cs:line 65

This is because the Dispose method of DefaultFunctionContext is calling Dispose of the IServiceScope where we should be calling the DisposeAsync when any of the dependencies this scope holds is IAsyncDisposable type.
Fix:
The CreateScope method returns an instance of ServiceProviderEngineScope which implements both IAsyncDisposable and IDisposable. So we will call the DisposeAsync after casting the IServiceScope instance to IAsyncDisposable
Note: The new  CreateAsyncScope method is available from Net 6 onwards. This means, we need to use version 6.X of the Microsoft.Extensions.Hosting.Abstractions package. We decided to not use this method at this time and is continue to use CreateScope method.

Ahoy @fabiocav @brettsam @satvu @liliankasem Ping for another review.

/check-enforcer evaluate


Aukce bez prihozu ma nil current_minimal_bid

> model.current_minimal_bid
  CACHE Auctify::Bid Exists? (0.0ms)  SELECT 1 AS one FROM "auctify_bids" INNER JOIN "auctify_bidder_registrations" ON "auctify_bids"."registration_id" = "auctify_bidder_registrations"."id" WHERE "auctify_bidder_registrations"."auction_id" = $1 AND "auctify_bids"."cancelled" = $2 LIMIT $3  [["auction_id", 101], ["cancelled", false], ["LIMIT", 1]]
  ↳ (pry):5:in `price_input'
  CACHE Auctify::Bid Load (0.0ms)  SELECT "auctify_bids".* FROM "auctify_bids" INNER JOIN "auctify_bidder_registrations" ON "auctify_bids"."registration_id" = "auctify_bidder_registrations"."id" WHERE "auctify_bidder_registrations"."auction_id" = $1 AND "auctify_bids"."cancelled" = $2 ORDER BY "auctify_bids"."price" DESC, "auctify_bids"."created_at" ASC, "auctify_bids"."id" ASC LIMIT $3  [["auction_id", 101], ["cancelled", false], ["LIMIT", 1]]
  ↳ (pry):5:in `price_input'
  CACHE Auctify::Bid Load (0.0ms)  SELECT "auctify_bids".* FROM "auctify_bids" INNER JOIN "auctify_bidder_registrations" ON "auctify_bids"."registration_id" = "auctify_bidder_registrations"."id" WHERE "auctify_bidder_registrations"."auction_id" = $1 AND "auctify_bids"."cancelled" = $2 ORDER BY "auctify_bids"."price" DESC, "auctify_bids"."created_at" ASC, "auctify_bids"."id" ASC LIMIT $3  [["auction_id", 101], ["cancelled", false], ["LIMIT", 1]]
  ↳ (pry):5:in `price_input'
  CACHE Auctify::Bid Load (0.0ms)  SELECT "auctify_bids".* FROM "auctify_bids" INNER JOIN "auctify_bidder_registrations" ON "auctify_bids"."registration_id" = "auctify_bidder_registrations"."id" WHERE "auctify_bidder_registrations"."auction_id" = $1 AND "auctify_bids"."cancelled" = $2 ORDER BY "auctify_bids"."price" DESC, "auctify_bids"."created_at" ASC, "auctify_bids"."id" ASC LIMIT $3  [["auction_id", 101], ["cancelled", false], ["LIMIT", 1]]
  ↳ (pry):5:in `price_input'
=> nil

Dela to jen kvuli AASM viz #12


closeBrowser() fails on windows with assert error from rimraf

Error on closeBrowser api. The browser shuts but the test fails with below error.
assert(received)

    Expected value to be equal to:
      true
    Received:
      false

      at fixWinEPERM (node_modules/rimraf/rimraf.js:175:5)
      at node_modules/rimraf/rimraf.js:160:15

This issue has been fixed.
Tested version: Version: 1.0.2 (Chromium: 76.0.3803.0) 9b0b3fc46c78e2596c9dad34e9a0ce69abf3be30


recipes-core: Cleanup few recipes

Under recipes-core/, cleanup few recipes as a part of scarthgap migration.

Applied as d1649076b34d3dc9908fce7b6ed19b454aa4c33e, e45af27e8b067fe019cca1dd0454f963f327d28e & 31c4a59288c8a3d1d7c69c30347aed4e6ab0d9e1


Add Image License

Close #1110
I wasn't sure where to put it, but I added the image license to README.md.
Related:
https://github.com/denoland/deno/blob/master/docs/introduction.md#logos

Can you run "yarn run format" please?

Sure, fixed!


Write gENM function

@anncalderon
The function needs to take the clusters as inputs, but I'm not sure that I'm currently seeing all of the changes you've made to this. It's 12pm on Sunday but the last commit I'm seeing on the ac branch is from 5:13 on Friday. Let me know if you have additional changes that you haven't pushed yet.


Identities is not under security but under developer portal

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 692852cd-11a6-1d6b-9540-caec9d0f14a4
Version Independent ID: 4c376561-6015-6dab-e23e-feffe74ccc8b
Content: Authorize developer accounts by using Azure Active Directory - Azure API Management
Content Source: articles/api-management/api-management-howto-aad.md
Service: api-management
GitHub Login: @miaojiang
Microsoft Alias: apimpm

Hi @averkinderen Thanks for reaching out. We will review and update as appropriate.

@averkinderen PR has been created for this which will address this. Thanks so much for providing the feedback that help us in improving the documentation. For now I will proceed with closure of this and If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Add state dump utilities to the contract package

Description
Helloooo. This PR adds utilities to the contracts package for generating state dumps. A default dump (state-dump.latest.json) is added to the build process, but we can always add different dumps for different contract versions if necessary. Introduces a new export:
import { getLatestStateDump } from '@eth-optimisim/rollup-contracts'
Additionally updates ovm-toolchain to make use of these state dumps in coordination with our new ethereumjs-ovm version (https://github.com/ethereum-optimism/ethereumjs-vm/tree/vm/4.x-state-dump).
Contributing Agreement

[x] I have read and understood the Optimism Contributing Guide and Code of Conduct and am following those guidelines in this pull request.

closing - this is in our contractsv2 here https://github.com/ethereum-optimism/contracts-v2/blob/master/src/contract-dumps.ts


Compilation fails

Fresh Windows installation, fresh VS2022 Community installed.
C:\Program Files\dotnet\sdk\7.0.403\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(447,5): error NETSDK1112: The runtime pack for Microsoft.Windows.SDK.NET.Ref was not downloaded. Try running a NuGet restore with the RuntimeIdentifier 'any'.

Restoring packages for C:\Users\me\Desktop\ThreeFingersDragOnWindows-main\ThreeFingersDragOnWindows\ThreeFingersDragOnWindows.csproj...
Restoring packages for C:\Users\me\Desktop\ThreeFingersDragOnWindows-main\ThreeFingersDragElevator\ThreeFingersDragElevator.csproj...
NU1213: The package Microsoft.Windows.SDK.NET.Ref 10.0.22621.31 has a package type DotnetPlatform that is incompatible with this project.
NU1213: The package Microsoft.Windows.SDK.NET.Ref 10.0.22621.31 has a package type DotnetPlatform that is incompatible with this project.
Package 'Microsoft.Windows.SDK.NET.Ref 10.0.22621.31' has a package type 'DotnetPlatform' that is not supported by project 'ThreeFingersDragElevator'.
Time Elapsed: 00:00:00.1049381
========== Finished ==========

Well, that is really strange as it woks well on my computer. Do you have all the libraries installed in the NuGet package manager?
You might check that you use the same versions as me:

You can also check that you have installed the UWP workload:

You might be able to restore automatically the libraries used in this project with:

dotnet restore

Again, it's Windows 10.

I am not able to reproduce your issue. However, I noticed a configuration issue (ThreeFingersDragElevator app decalared as Self-Contained as it should not). I corrected this, it might change the error you have. Normally, after opening the .sln in VS, the dependencies should be loaded automatically, and the project could be run. Also, make sure to build/run the app in Packaged mode.


Prefer system installation of UHD library

Pretty simple change to fix potential Boost issues mentioned in #3. This change will pickup the system install of libuhd over Julia artifacts. Checked it works with system packages on my system, I can't test to make sure it still works with artifacts.
Happy to accept any changes, I'm still very much a Julia beginner.

dlopen rethrow an exception is lib is not present, so I have added the throw_error keyword to ensure output is nothing if the lib is not found.
Thanks again, ready for merging :)


How to use elasticsearch in Java application

NOTE: All 1st-time contributors should know Topic approval and PR submission does NOT guarantee your Topic/Article will be published. Our team of Peer Reviewers and Content Moderators will review all PRs that come in to make sure they adhere to the standard of quality we expect from the EngEd community.
We expect all community memebers to go through provided examples, resources, and previously published material before submitting content. As a rule of thumb, please only submit articles (pull requests) that are complete, formatted correctly, and include a fully polished article (ready to be published and error free).
All revisions and edits should be completed on your own forked repo (as to not take up room in the queue). Any PR that is submitted incomplete (meaning not ready to be published as is) will be closed. A PR being closed does NOT mean the article can not be published (or fixed) it simply means that the edits, revisions, and fixes will happen outside of the queue.
Topic Suggestion
Enter topic suggestion here...
Pre-submission advice
By following all our pre-submission advice and reviewing our Resources folder, you will maximise your chances of your topic being approved.
We ask that you please be patient as our team works through approving and publishing all articles/tutorials in a timely manner.
Allow 1-3 days for a topic to be reviewed and/or approved - allow 3-7 days for an articles to be reviewed and/or published (subject to vary depending on volume and/or backlog of articles).
Be sure to visit our Resources Page for tools, resources, and example articles that will help you propose and write a successful article.
Please ensure that you have only one open issue + linked pull request at a time. This will ensure that we complete the article in a timely manner from inception to publishing.)
We tend to stray away or tend not to publish reviews/comparisons of commercial product offerings.
Writing sample(s):
Include any links or writing samples - to help our team better gauge your writing quality.
Proposal Submission
Proposed title of article
Your title should be descriptive of the article/tutorial. Be Specific.
Use keyword research to improve your article's SEO.
Proposed article introduction
This tutorial shows how Elasticsearch works in practice. Learn the basics of the REST API first by accessing it from the command line. Then set up a local Elasticsearch server and interact with it from a simple Java application.
Key takeaways
By the end of this to tutorial, the learner will be able to:

Understand how Lucene library works in elasticsearch
Know basis of rest API to elasticsearch
Be able to add elasticsearch to there Java application

Article quality
The article have not been covered in many blog sites.
References
None
Conclusion
Finally, remove the Pre-Submission advice section and all our blockquoted notes as you fill in the form before you submit.
We look forwarding to reviewing your topic suggestion.
Templates to use as guides

How To Guide Template
Software Review Template
Tutorial Template

Good afternoon and thank you for submitting your topic suggestion.
Your topic form has been entered into our queue and should be reviewed (for approval) as soon as a content moderator is finished reviewing the ones in the queue before it.

@LinusMuema Can you check this topic suggestions?

Thank you for your response and we thank you for submitting your topic. After some careful consideration it struck us that this topic may be a bit over saturated throughout other blog sites such as IBM and Baeldung.
We typically refrain from publishing content that is covered widely on the net or other blogs. As we're more interested in original, practitioner-focused content that takes a deeper dive into programming-centric concepts.
We believe this is the best way for students to build a great portfolio (for potential employers) is by building what does not exist and what can provide the most value.
You are more than welcome to pursue another more in depth topic


Fixing typo on Network Lerp Rigidbody

I believe this should say you should NOT have a network transform on a gameobject with a network rigidbody.

nice find @rwinstead

nice find @rwinstead


astron: Fix segfault when handling CLIENTAGENT_ADD_INTEREST

The astron cluster crashes with a segmentation fault when it receives a CLIENTAGENT_ADD_INTEREST message from the AI process. Weird behavior to note: If you send this message with parent ID 0 and zone ID 0, it does not crash the astron daemon. And I have no idea why.

The temporary but very not logical fix for this issue is to comment out all the lines in the InterestOperation::timeout() function @ src/clientagent/Client.cpp.
void InterestOperation::timeout() {     //lock_guard<recursive_mutex> lock(m_client->m_client_lock);     //m_client->m_log->warning() << "Interest operation timed out; forcing.\n";     //finish(true); }


Error when retrieving values from DHT22 Sensor

Problem/Motivation
Hello once again! My other issue #15 got solved with the solution you provided. But now I'm facing another problem with pulling the data from the sensor. The addon successfully connects to my MQTT Broker but throws errors when it pulls sensor data.
Expected behavior
The sensor data would be pulled from the sensors and then posted on the MQTT Broker
Actual behavior
The addon connects to the MQTT server succesfully but throws this error while trying to retrieve values from the DHT22 sensor
2022-07-25 14:22:38 mqtt_io.server [ERROR] Exception when retrieving value from sensor 'humidity':
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/mqtt_io/server.py", line 561, in poll_sensor
    value = await get_sensor_value()
  File "/usr/lib/python3.10/site-packages/backoff/_async.py", line 133, in retry
    ret = await target(*args, **kwargs)
  File "/usr/lib/python3.10/site-packages/backoff/_async.py", line 66, in retry
    ret = await target(*args, **kwargs)
  File "/usr/lib/python3.10/site-packages/mqtt_io/server.py", line 556, in get_sensor_value
    return await sensor_module.async_get_value(sens_conf)
  File "/usr/lib/python3.10/site-packages/mqtt_io/modules/sensor/__init__.py", line 57, in async_get_value
    return await loop.run_in_executor(ThreadPoolExecutor(), self.get_value, sens_conf)
  File "/usr/lib/python3.10/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python3.10/site-packages/mqtt_io/modules/sensor/dht22.py", line 62, in get_value
    humidity, temperature = self.sensor.read_retry(self.sensor_type, self.pin)
  File "/usr/lib/python3.10/site-packages/Adafruit_DHT/common.py", line 94, in read_retry
    humidity, temperature = read(sensor, pin, platform)
  File "/usr/lib/python3.10/site-packages/Adafruit_DHT/common.py", line 80, in read
    platform = get_platform()
  File "/usr/lib/python3.10/site-packages/Adafruit_DHT/common.py", line 55, in get_platform
    from . import Raspberry_Pi_2
  File "/usr/lib/python3.10/site-packages/Adafruit_DHT/Raspberry_Pi_2.py", line 22, in <module>
    from . import Raspberry_Pi_2_Driver as driver
ImportError: cannot import name 'Raspberry_Pi_2_Driver' from 'Adafruit_DHT' (/usr/lib/python3.10/site-packages/Adafruit_DHT/__init__.py)
2022-07-25 14:22:38 mqtt_io.server [ERROR] Exception when retrieving value from sensor 'temperature':
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/mqtt_io/server.py", line 561, in poll_sensor
    value = await get_sensor_value()
  File "/usr/lib/python3.10/site-packages/backoff/_async.py", line 133, in retry
    ret = await target(*args, **kwargs)
  File "/usr/lib/python3.10/site-packages/backoff/_async.py", line 66, in retry
    ret = await target(*args, **kwargs)
  File "/usr/lib/python3.10/site-packages/mqtt_io/server.py", line 556, in get_sensor_value
    return await sensor_module.async_get_value(sens_conf)
  File "/usr/lib/python3.10/site-packages/mqtt_io/modules/sensor/__init__.py", line 57, in async_get_value
    return await loop.run_in_executor(ThreadPoolExecutor(), self.get_value, sens_conf)
  File "/usr/lib/python3.10/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python3.10/site-packages/mqtt_io/modules/sensor/dht22.py", line 62, in get_value
    humidity, temperature = self.sensor.read_retry(self.sensor_type, self.pin)
  File "/usr/lib/python3.10/site-packages/Adafruit_DHT/common.py", line 94, in read_retry
    humidity, temperature = read(sensor, pin, platform)
  File "/usr/lib/python3.10/site-packages/Adafruit_DHT/common.py", line 80, in read
    platform = get_platform()
  File "/usr/lib/python3.10/site-packages/Adafruit_DHT/common.py", line 55, in get_platform
    from . import Raspberry_Pi_2
  File "/usr/lib/python3.10/site-packages/Adafruit_DHT/Raspberry_Pi_2.py", line 22, in <module>
    from . import Raspberry_Pi_2_Driver as driver
ImportError: cannot import name 'Raspberry_Pi_2_Driver' from 'Adafruit_DHT' (/usr/lib/python3.10/site-packages/Adafruit_DHT/__init__.py)

Steps to reproduce
Here is the config.yml file used:
mqtt:
  host: <IP_ADDRESS>
  port: 2883
  user: "mqtt-username"
  password: "mqtt-password"
  topic_prefix: home/livingroom/climate

sensor_modules:
  - name: dht22_sensor
    module: dht22
    type: AM2302
    pin: 4

sensor_inputs:
  - name: temperatur
    module: dht22_sensor
    interval: 10
    digits: 4
    type: temperature

  - name: luftfuktighet
    module: dht22_sensor
    interval: 10
    digits: 4
    type: humidity

I am very greatful for your help, and your continued support of Home Assistant and the addons, you guys are the best <3

We'll get there!
Opened up #18 to deal with that :)

We'll get there!
Opened up #18 to deal with that :)

Great! I'll wait and update as soon as I see it pop up and then report back to you :)

On my Home Assistant instance it still says the latest update is 0.1.1, is there anyway to force it to check for the 0.1.2 update? So I could test if the problem is resolved? :)

Go to setting -> updates -> Top right menu, check for updates.
The 0.1.2 version is being built and should be available any moment now.

2022-07-25 15:28:51 mqtt_io.server [ERROR] Exception when retrieving value from sensor 'temperature':
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/mqtt_io/server.py", line 561, in poll_sensor
    value = await get_sensor_value()
  File "/usr/lib/python3.10/site-packages/backoff/_async.py", line 133, in retry
    ret = await target(*args, **kwargs)
  File "/usr/lib/python3.10/site-packages/backoff/_async.py", line 66, in retry
    ret = await target(*args, **kwargs)
  File "/usr/lib/python3.10/site-packages/mqtt_io/server.py", line 556, in get_sensor_value
    return await sensor_module.async_get_value(sens_conf)
  File "/usr/lib/python3.10/site-packages/mqtt_io/modules/sensor/__init__.py", line 57, in async_get_value
    return await loop.run_in_executor(ThreadPoolExecutor(), self.get_value, sens_conf)
  File "/usr/lib/python3.10/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python3.10/site-packages/mqtt_io/modules/sensor/dht22.py", line 62, in get_value
    humidity, temperature = self.sensor.read_retry(self.sensor_type, self.pin)
  File "/usr/lib/python3.10/site-packages/Adafruit_DHT/common.py", line 94, in read_retry
    humidity, temperature = read(sensor, pin, platform)
  File "/usr/lib/python3.10/site-packages/Adafruit_DHT/common.py", line 81, in read
    return platform.read(sensor, pin)
  File "/usr/lib/python3.10/site-packages/Adafruit_DHT/Raspberry_Pi_2.py", line 34, in read
    raise RuntimeError('Error accessing GPIO.')
RuntimeError: Error accessing GPIO.
2022-07-25 15:28:51 mqtt_io.server [ERROR] Exception when retrieving value from sensor 'humidity':
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/mqtt_io/server.py", line 561, in poll_sensor
    value = await get_sensor_value()
  File "/usr/lib/python3.10/site-packages/backoff/_async.py", line 133, in retry
    ret = await target(*args, **kwargs)
  File "/usr/lib/python3.10/site-packages/backoff/_async.py", line 66, in retry
    ret = await target(*args, **kwargs)
  File "/usr/lib/python3.10/site-packages/mqtt_io/server.py", line 556, in get_sensor_value
    return await sensor_module.async_get_value(sens_conf)
  File "/usr/lib/python3.10/site-packages/mqtt_io/modules/sensor/__init__.py", line 57, in async_get_value
    return await loop.run_in_executor(ThreadPoolExecutor(), self.get_value, sens_conf)
  File "/usr/lib/python3.10/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python3.10/site-packages/mqtt_io/modules/sensor/dht22.py", line 62, in get_value
    humidity, temperature = self.sensor.read_retry(self.sensor_type, self.pin)
  File "/usr/lib/python3.10/site-packages/Adafruit_DHT/common.py", line 94, in read_retry
    humidity, temperature = read(sensor, pin, platform)
  File "/usr/lib/python3.10/site-packages/Adafruit_DHT/common.py", line 81, in read
    return platform.read(sensor, pin)
  File "/usr/lib/python3.10/site-packages/Adafruit_DHT/Raspberry_Pi_2.py", line 34, in read
    raise RuntimeError('Error accessing GPIO.')
RuntimeError: Error accessing GPIO.

This is the new error message that pops up when using the new 0.1.2 update. I'm using a Raspberry Pi 3B if that is important

Probably caused by:
https://github.com/adafruit/Adafruit_Python_DHT/blob/8f5e2c4d6ebba8836f6d31ec9a0c171948e3237d/source/Raspberry_Pi_2/pi_2_mmio.c#L43-L46
Not sure how to solve that.

Probably caused by:
https://github.com/adafruit/Adafruit_Python_DHT/blob/8f5e2c4d6ebba8836f6d31ec9a0c171948e3237d/source/Raspberry_Pi_2/pi_2_mmio.c#L43-L46
Not sure how to solve that.

I understand! But once again thank you so much for the help <3 If you need me to test something hit me up!

Did anyone manage to solve this at all?  I've got the same problem of the RuntimeError: Error accessing GPIO. with an almost identical setup.


Make deposit/withdraw more clear to novice users.

Currently, the UI for transferring money from Ethereum to Cash is a little confusing for novice users.  It uses terminology like "withdraw" without having a clear indication of which is the source and which is the destination.
My recommendation (without much thought) is to instead change the wording to something like "Cash to Ether" and "Ether to Cash".

The whole withdraw/deposit scheme has been more-or-less replaced by the simple(r) faucet; closing.


added basic metafeatures/dataset_describe.py

I've added  metafeatures/dataset_describe.py. I've implemented a class-method structure. I wasn't too sure but wanted to set the ball rolling.
The public methods of class will only return one value per dataset. These will be the metafeatures. Private methods of class are used for intermediate computations etc.
Dataset (the class) can be initialized with some user-set values (Eg. which of the columns are categorical)
Let me know if you have any suggestions regarding design, module structure etc.

Great start. Thank you for this!


Hard to tell where navigation is on slower machines

Testing #145627
When working on a machine that is slow/sluggish, it is impossible to tell where the navigation goes to because the line highlight fades away. I think having some type of subtle decoration on the line would help alleviate this issue for time based animations. The Terminal app shows a line:

Tried capturing this experience:
https://user-images.githubusercontent.com/35271042/159584936-12fa1e18-fb81-4454-90f1-5280c21a7e7f.mov

Maybe you can verify this on the same machine @misolori


Linux (Fedora 20): Please install leiningen before running this script.

I just tried to give LightTable a test run in Linux (Fedora 20), but the
linux_deps.sh script seems to not detect leiningen correctly after
installing it with yum.
$ git clone https://github.com/LightTable/LightTable.git
$ cd LightTable
$ bash linux_deps.sh
Please install leiningen before running this script.
$ sudo yum install leiningen
# yum completes the install
$ bash linux_deps.sh
Please install leiningen before running this script.

Closing as this is pretty old and refers to a build script that no longer exists. In general you don't need to run the build script unless you're developing or running on the bleeding edge


SproutFormsGoogleRecaptchaCheckbox is not defined in sproutFormsRecaptchaOnloadCallback

Description (screenshots, logs, ...)
Sentry is reporting a lot errors like this:

Can't find variable: SproutFormsGoogleRecaptchaCheckbox
ReferenceError: SproutFormsGoogleRecaptchaCheckbox is not defined

Steps to reproduce
This is tricky as I'm not able to reproduce this issue.
Additional info

Craft version: 3.5.5
PHP version: 7.2
Database driver & version:  MySQL 8
Plugins & versions: barrelstrength/sprout-forms-google-recaptcha:1.4.0

For some issues, we may request that you send the following items to Support<EMAIL_ADDRESS>If you feel your issue may fall in that category, feel free to send things over after you post this issue and reference the issue in your email.

composer.json
storage/logs/web.log (or a zip of the whole log folder)
An export of your database (or, if you can't share the whole db, the specific Sprout tables)

The DOM structure is like so:
<body>
  <script src="***/cpresources/dc412562/recaptcha_v2_checkbox.js?v=1594653312" defer></script>
  <script>if (typeof sproutFormsRecaptchaOnloadCallback === 'undefined') {
    var sproutFormsRecaptchaOnloadCallback = function() {
    new SproutFormsGoogleRecaptchaCheckbox({
    siteKey: '***',
    theme: 'light',
    size: 'normal',
    customValidityText: "Please fill out this field.",
    grecaptcha: grecaptcha
    });
    };
    };</script>

  ...

   <script src="https://www.google.com/recaptcha/api.js?onload=sproutFormsRecaptchaOnloadCallback&render=explicit&hl=en" async defer></script>
</body>

I suppose this happens because of the async attribute for the recaptcha/api.js script, the onload may get executed before the recaptcha_v2_checkbox.js since it is deferred until the DOM is parsed.

I'm also having this issue which is resulting in the captcha showing up sporadically. For me, it looks like when the script is loaded via memory cache, the captcha breaks, but if it's loaded via the network or even disk cache it works as expected. I'm not intimately familiar with how the browser cache works, but I'd expect the memory cache is relatively short lived, so you'd hit this error more frequently when filling loading forms in a relatively short amount of time.

Sprout Forms v3.13.12 fixes a bug where async form submissions were not properly wrapped in the promise chain which could have caused issues like this while processing Google ReCaptcha.
While I haven't been able to reproduce to confirm this is the same issue, as this is an older bug, I'm closing it out. If anybody runs into this again, please re-open with new comments.


Constants for ColorMode?

Just thinking whether in might be more intuitive and safer to provide constants for ColorMode instead of free ranging string values?

 Will eventually do that.

Fixed.


[EN] Feedback for: /web/fundamentals/design-and-ui/input/forms/use-request-auto-complete?hl=en

Can we put on the top of this article something like:
We recommend not using the requestAutocomplete API - Instead please use the autocomplete attributes for perfect autofill. Read more: https://developers.google.com/web/updates/2015/06/checkout-faster-with-autofill

I would recommend stronger language, such as:
"requestAutocomplete is being deprecated and should not be implemented. We recommend instead annotating your checkout form fields with autocomplete attributes to leverage autofill."

Sounds good.
@petele - thoughts?

Fine by me.

Here is the suggested fix: https://github.com/greenido/WebFundamentals/blob/new-header-2-rAc/src/content/en/fundamentals/design-and-ui/input/forms/use-request-auto-complete.markdown

We've yanked the rAC


Standardized framework for plugins to create rolling log files to log plugin specific information for better auditing.

Similar to PA and PA-RCA, many plugins require to have descriptive info logs which would choke the opensearch log file due to high volume.
Hence we should prove a standardized a mechanism to create plugin specific rolling logs.
Use case for alerting plugin (or for that matter any Job Scheduler based plugin):
We wish to log detailed information about every single execution of monitors - start time, end time, execution success/failure reason, retry attempt time, alerts generated, triggers succeeded etc.
We can have up to 50000 monitors executing every minute and we need INFO-level log auditing their execution

We cannot store periodic and frequent information in indices as user would incur infra costs due to heavy disk usage.
We cannot log this at INFO-level in Opensearch logs as this would be an irrationally high number per plugin and will not scale if we consider all plugins have such use-cases

Additional to this, it would make sense for OpenSearch to have an audit library that can help plugins log this data.
With the library they could even have it store the information in an index for use cases that wont require indexing a lot of audits logs.


op-build failure at building hostboot

Dear Hostboot Team,
I am trying to build op-build, but failed at building hostboot. I tried on two machines, one is trying to build op-build v1.3, the other is trying to build op-build v1.2.
They all have errors similar to the following:
make[8]: *** [../../../obj/modules/errl/errludcallout.o] Segmentation fault (core dumped)
make[8]: *** [../../../obj/modules/errl/errludcallout.o] Segmentation fault (core dumped)
make[8]: *** Deleting file ../../../obj/modules/errl/errludcallout.o' make[8]: *** Waiting for unfinished jobs....     LD         libdevicefw_rt.so     MAKE       test CODE     TESTGEN    testdevicefw_rt.C     DEP        testdevicefw_rt.C     CXX        testdevicefw_rt.C     LD         libtestdevicefw_rt.so make[7]: *** [_BUILD/PASSES/CODE/BODY] Error 2 make[6]: *** [_BUILD/SUBDIR/CODE/errl] Error 2 make[5]: *** [_BUILD/PASSES/CODE/POST] Error 2 make[4]: *** [_BUILD/SUBDIR/CODE/usr] Error 2 make[3]: *** [_BUILD/PASSES/CODE/POST] Error 2 make[2]: *** [_BUILD/SUBDIR/CODE/src] Error 2 make[1]: *** [_BUILD/PASSES/CODE/POST] Error 2 make[1]: Leaving directory /home/weiwang/git/op-build/output/build/hostboot-70b5e31d74487d51e69a0e0a390adea6b4f32dc5'
What is interesting is, the machine that failed initially with v1.3, later was successfully built ( palmetto.pnor generated)!  I did not do anything special other than retype "op-build".
However, on the other machine that I am building op-build v1.2, I still fail at this step.
By the way, could you also be so kind to explain how palmetto.pnor is supposed to be used? Does it need to be combined with occ package as occ readme mention
"
op-build occ-rebuild openpower-pnor-rebuild
"?
Thank you!
Wei Wang

Are you sure this was built on a 64 bit machine?  I've seen this exact failure on a 32 bit system.

On Jun 29, 2015, at 1:21 PM, Wei Wang<EMAIL_ADDRESS>wrote:
Dear Hostboot Team,
I am trying to build op-build, but failed at building hostboot. I tried on two machines, one is op-build v1.3, the other is v1.2.
They all have errors similar to the following:
make[8]: *** [../../../obj/modules/errl/errludcallout.o] Segmentation fault (core dumped)
make[8]: *** [../../../obj/modules/errl/errludcallout.o] Segmentation fault (core dumped)
make[8]: *** Deleting file ../../../obj/modules/errl/errludcallout.o'
make[8]: *** Waiting for unfinished jobs....
LD libdevicefw_rt.so
MAKE test CODE
TESTGEN testdevicefw_rt.C
DEP testdevicefw_rt.C
CXX testdevicefw_rt.C
LD libtestdevicefw_rt.so
make[7]: *** [_BUILD/PASSES/CODE/BODY] Error 2
make[6]: *** [_BUILD/SUBDIR/CODE/errl] Error 2
make[5]: *** [_BUILD/PASSES/CODE/POST] Error 2
make[4]: *** [_BUILD/SUBDIR/CODE/usr] Error 2
make[3]: *** [_BUILD/PASSES/CODE/POST] Error 2
make[2]: *** [_BUILD/SUBDIR/CODE/src] Error 2
make[1]: *** [_BUILD/PASSES/CODE/POST] Error 2
make[1]: Leaving directory/home/weiwang/git/op-build/output/build/hostboot-70b5e31d74487d51e69a0e0a390adea6b4f32dc5'
What is interesting is, the machine that failed initially with v1.3, later was successfully built with palmetto.pnor! I did not do anything special other than retype "op-build".
However, on the other machine op-build v1.2, I still fail at this step.
By the way, could you also be so kind to explain how palmetto.pnor is supposed to be used? Does it need to be combined with occ package as occ readme mention
"
op-build occ-rebuild openpower-pnor-rebuild
"?
Thank you!
Wei Wang
—
Reply to this email directly or view it on GitHub.

Hi Patrick,
Thanks for the quick reply!
You are right, the one that still fails is not a 64 bit linux.
The one that successfully built .pnor is 64-bit.
Is the next step "pflash" with the palmetto.pnor, or should I do something more?
Thank you!

Yes, you should be able to pflash the resulting palmetto.pnor on.  Especially if you've done that before with v1.2.
There have been compatibility problems between different levels of the BMC code.  If you get a failure during the boot sequence related to IPMI you might need a BMC update for your machine.
Another option would be to edit this file to disable IPMI but that also requires disabling the OCC:
https://github.com/open-power/op-build/blob/master/openpower/configs/hostboot/palmetto.config


update time to close metric

Signed-off-by: Kevin Lumbard<EMAIL_ADDRESS>Added merge success as a filter and objective

Thanks everyone!


Add the using keyword per the "Explicit Resource Management" proposal

Changes
This ECMAScript proposal adds a new keyword (using). It's reached stage 3, which is "recommended for implementation":

Proposal: https://github.com/tc39/proposal-explicit-resource-management
ECMAScript proposal process: https://tc39.es/process-document/

The change itself is very small, I've just added the using keyword to the list of keywords in src/languages/lib/ecmascript.js. I've also updated an existing keyword test adding a case to ensure using is rendered as using in a declaration.
I didn't update the CHANGES.md, since I'm not sure if I should cut a new version for this? But let me know what to do and I can do it.
Checklist

[x] Added markup tests, or they don't apply here because...
[ ] Updated the changelog at CHANGES.md

Thank you! Just added the suggested changes.


Added ability to set command + fixed spawning on win os

Added ability to set command + fixed spawning on win os

will you merge this pull request?


Add Primary Entity Field

Resolves #123

Description
Please see the linked issue for more details.
Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have run changie new to create a changelog entry

Regardless of the decision we eventually make, we should stay the current path for DSI 0.1.0.

Sounds good - updated.

Ok, so, we need:

Cleanup on this PR
1 or 2 more validations (#103  and maybe #120 )
WhereFilter parsing logic update to take in the new style format

When do these all have to be in? Today, probably?

Updated with cleanup. Also rolled the OnePrimaryEntityPerSemanticModelRule into the PrimaryEntity rule, since it's kind of dependent.


Dialogues and Objects (WIP)

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Code quality improvements

How to Test
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Please delete options that are not relevant.

[ ] I have tested this code
[ ] I have updated the documentation

Pull Request Test Coverage Report for Build 5260

41 of 241 (17.01%)  changed or added relevant lines in 14 files are covered.
42 unchanged lines in 7 files lost coverage.
Overall coverage decreased (-1.4%) to 32.119%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/pages/academy/game/subcomponents/utils/effects.ts
2
4
50.0%

src/features/game/GameService.ts
0
3
0.0%

src/pages/academy/game/Game.tsx
0
5
0.0%

src/pages/academy/game/subcomponents/dialogue/DialogueHelper.ts
9
14
64.29%

src/pages/academy/game/subcomponents/utils/spriteUtils.ts
0
7
0.0%

src/pages/academy/game/subcomponents/dialogue/DialoguePreloader.ts
1
12
8.33%

src/pages/academy/game/subcomponents/scenes/Scratch.ts
0
14
0.0%

src/pages/academy/game/subcomponents/scenes/PlayGame.ts
0
18
0.0%

src/pages/academy/game/subcomponents/utils/styles.ts
8
29
27.59%

src/pages/academy/game/subcomponents/dialogue/DialogueManager.ts
0
25
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/pages/academy/game/Game.tsx
1
0%

src/features/game/commons/CommonsTypes.ts
3
0%

src/features/game/location/GameMapTypes.ts
5
0%

src/features/game/location/GameMap.ts
6
0%

src/features/game/modeMenu/GameModeMenuTypes.ts
6
0%

src/features/game/mode/move/GameModeMoveTypes.ts
6
0%

src/pages/academy/game/subcomponents/scenes/LocationSelectChapter.ts
15
0%

Totals

Change from base Build 5257:
-1.4%

Covered Lines:
1719

Relevant Lines:
4990

💛  - Coveralls


How can i show the notification which sent by the firebase console?

Explanation:
I have configure all the steps for the android and iOS.I added four file of this project for the react native. When my application is run i got a token. When i click on the "Send Local Notification" it had pop up the notification. Rest of the other button click event show's me a dialog it means it's not showing me a notification popup.
Issue
When i send a notification from the firebase console it will show in my log but not displaying on the notification popup on my android device.
How can i resolve this problem?

Rest of the other button click event show's me a dialog it means it's not showing me a notification popup.
screenshot? what does it say? did you check your console log to see if any error response is printed out?


Error importing multiple animations.

I haven't tested this yet, but after seeing the below code:
            for (var i = 0; i < frameIndice.length; i++) {
                frameIndice[i] = i + 1;
            }

This won't work for multiple animations, since it will always start from 1 and go up. This should be offset by tag.from:
            var frameIndice: Array<number> = new Array(tag.to - tag.from + 1);

            for (var i = 0; i < frameIndice.length; i++) {
                frameIndice[i] = i + tag.from + 1;
            }

Resolved in 6a26f83f916873c79bb13521a01abf2ce8c869b1


Expand Test Coverage

Description:
Improve testing to ensure library reliability and performance.
Test Focus Areas:

Selector parsing accuracy.
DOM traversal methods and their reliability.
Attribute manipulation and handling edge cases.
Error handling and unexpected input scenarios.

Hello,
I think it is generally fine idea. so decided to fork the repo and work on this issue.
just started expanding coverage on attribute matcher
matcher_test.go

Thanks for contributing, glad to hear you’re working on attribute matcher tests. Feel free to reach out if you need any clarifications or guidance. Looking forward to your PR

Closing this issue as test coverage has been significantly improved via PR #7. A separate issue will be created to address combinator functionality.


Migrated to polymer 3

I ran the polymer migration tool over the project, fixed a few examples that it broke and removed unnecessary files.
Fixes issue #51
Note that inorder to run wct with npm dependencies the --npm flag is needed (polymer test --npm).

Created a pull request on the master branch (sorry about that). Please see pull request #54.


cleanup and full py3 compatibility

Description
Using six to make it more py2/3 compatible
GitHub Issues

Coverage decreased (-0.03%) to 92.535% when pulling 70644b71f14dffe42a1075ce674a900775e25fcb on mcrowson:full_py3_comp into 3cd12a130b7f256624a63902ffe16f1ee194f4b1 on refindlyllc:master.


Feature/add project euler problems

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[ ] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[ ] Small bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[x] Closes currently open issue (replace XXXX with an issue no): Closes #XXXX

Description
This adds 600 Project Euler problems to our Interview Practice section. Not all of these have been solved, and some of them have missing images or equations, but we can incrementally add these over time.

@QuincyLarson did you have a timeline for wanting to merge these in? I was able to locally load them in no problem. Of course, many if not all of these challenges requires a lot of formatting fixes to look nice on the site. If that's all you were looking for in these challenges that they would load into freeCodeCamp okay, I can merge this. Otherwise, just wondering on the timeline for this part.

@erictleung I was just waiting for someone to accept this PR other than me :) If it looks good, would you like to merge?

@erictleung we plan to go through all of these and clean them up as part of github.com/FreeCodeCamp/arcade-mode, but for now I don't think it hurts to have these available on beta.


add api required by wechall

This is focused on #184  . The first two steps are implemented, although the scoring output only satisfies the minimal requirements of Step 2. Global rank and scoring is somewhat of a mess with no proper weighting system of challenges resulting in babyarch and babysuid having the same single point for solved/unsolved which is not really fair.
But, this does complete the minimum requirements. Sample output of the additions is below:

/validate endpoint

zeeshan@hydra:/opt/dojo$ curl<EMAIL_ADDRESS>1
zeeshan@hydra:/opt/dojo$ curl<EMAIL_ADDRESS>0

/score endpoint

zeeshan@hydra:/opt/dojo$ curl 'http://localhost/pwncollege_api/v1/score?username=user'
"15:104"
zeeshan@hydra:/opt/dojo$ curl 'http://localhost/pwncollege_api/v1/score?username=admin'
"0:104"
zeeshan@hydra:/opt/dojo$ curl 'http://localhost/pwncollege_api/v1/score?username=adm'
{
    "error": "user does not exist"
}

So, I think I got all of them, let me know if I missed anything.

The email is not even required for checking if the account exists and I added that just so that it matches up with the Step 1 requirement, maybe that can just be simply removed if the wechall people do not require it.

Look great! Thanks :)


New feature: backup account/load from backup

Very simple implementation done, can be improved later.


master -> live

Docs Build status updates of commit a6ae8c1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.github/stale.yml
:white_check_mark:Succeeded

docs/TOC.md
:white_check_mark:Succeeded
View

docs/nuget-org/nuget-org-faq.md
:white_check_mark:Succeeded
View

docs/quickstart/create-and-publish-a-package-using-visual-studio-net-framework.md
:white_check_mark:Succeeded
View

docs/reference/errors-and-warnings/NU1605.md
:white_check_mark:Succeeded
View

docs/reference/errors-and-warnings/NU5131.md
:white_check_mark:Succeeded
View

docs/reference/extensibility/NuGet-Cross-Platform-Plugins.md
:white_check_mark:Succeeded
View

docs/reference/nuspec.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit cb881e9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.github/stale.yml
:white_check_mark:Succeeded

docs/TOC.md
:white_check_mark:Succeeded
View

docs/create-packages/Supporting-Multiple-Target-Frameworks.md
:white_check_mark:Succeeded
View

docs/nuget-org/nuget-org-faq.md
:white_check_mark:Succeeded
View

docs/quickstart/create-and-publish-a-package-using-visual-studio-net-framework.md
:white_check_mark:Succeeded
View

docs/reference/errors-and-warnings/NU1605.md
:white_check_mark:Succeeded
View

docs/reference/errors-and-warnings/NU5131.md
:white_check_mark:Succeeded
View

docs/reference/extensibility/NuGet-Cross-Platform-Plugins.md
:white_check_mark:Succeeded
View

docs/reference/nuspec.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit c7fe01b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.github/stale.yml
:white_check_mark:Succeeded

docs/TOC.md
:white_check_mark:Succeeded
View

docs/create-packages/Creating-a-Package.md
:white_check_mark:Succeeded
View

docs/create-packages/Supporting-Multiple-Target-Frameworks.md
:white_check_mark:Succeeded
View

docs/create-packages/creating-a-package-dotnet-cli.md
:white_check_mark:Succeeded
View

docs/create-packages/creating-a-package-msbuild.md
:white_check_mark:Succeeded
View

docs/guides/Create-NET-Standard-Packages-VS2015.md
:white_check_mark:Succeeded
View

docs/guides/Create-UWP-Packages.md
:white_check_mark:Succeeded
View

docs/nuget-org/nuget-org-faq.md
:white_check_mark:Succeeded
View

docs/quickstart/create-and-publish-a-package-using-visual-studio-net-framework.md
:white_check_mark:Succeeded
View

docs/reference/errors-and-warnings/NU1605.md
:white_check_mark:Succeeded
View

docs/reference/errors-and-warnings/NU5131.md
:white_check_mark:Succeeded
View

docs/reference/extensibility/NuGet-Cross-Platform-Plugins.md
:white_check_mark:Succeeded
View

docs/reference/nuspec.md
:white_check_mark:Succeeded
View

docs/reference/target-frameworks.md
:white_check_mark:Succeeded
View

docs/what-is-nuget.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 6cdddef:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.github/stale.yml
:white_check_mark:Succeeded

docs/TOC.md
:white_check_mark:Succeeded
View

docs/create-packages/Creating-a-Package.md
:white_check_mark:Succeeded
View

docs/create-packages/Supporting-Multiple-Target-Frameworks.md
:white_check_mark:Succeeded
View

docs/create-packages/creating-a-package-dotnet-cli.md
:white_check_mark:Succeeded
View

docs/create-packages/creating-a-package-msbuild.md
:white_check_mark:Succeeded
View

docs/create-packages/multiple-target-frameworks-project-file.md
:white_check_mark:Succeeded
View

docs/guides/Create-NET-Standard-Packages-VS2015.md
:white_check_mark:Succeeded
View

docs/guides/Create-UWP-Packages.md
:white_check_mark:Succeeded
View

docs/nuget-org/nuget-org-faq.md
:white_check_mark:Succeeded
View

docs/quickstart/create-and-publish-a-package-using-visual-studio-net-framework.md
:white_check_mark:Succeeded
View

docs/reference/errors-and-warnings/NU1605.md
:white_check_mark:Succeeded
View

docs/reference/errors-and-warnings/NU5131.md
:white_check_mark:Succeeded
View

docs/reference/extensibility/NuGet-Cross-Platform-Plugins.md
:white_check_mark:Succeeded
View

docs/reference/nuspec.md
:white_check_mark:Succeeded
View

docs/reference/target-frameworks.md
:white_check_mark:Succeeded
View

docs/what-is-nuget.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


q120_ntt cmd prints & behavior documentation

I'm trying to call spqlios-arithmetic from Go. I was able to reproduce the simple-fft example. However, when trying to do the same with q120_ntt.h, I run into the following issues:
Calling

q120_new_ntt_bb_precomp
q120_new_intt_bb_precomp
q120_ntt_bb_avx2
q120_intt_bb_avx2

prints in the command line:
NTT parameters:
        size = 1024
        logQ = 30
        input bit-size = 64
        level   1024 output bit-size = 63 (a_k.omega^k)
        level    512 output bit-size = 64
        reduce       output bit-size = 48
        level    256 output bit-size = 56
        level    128 output bit-size = 60
        level     64 output bit-size = 62
        level     32 output bit-size = 63
        level     16 output bit-size = 64
        reduce       output bit-size = 48
        level      8 output bit-size = 56
        level      4 output bit-size = 60
        level      2 output bit-size = 62
        level      1 output bit-size = 63
iNTT parameters:
        size = 1024
        logQ = 30
        input bit-size = 64
        reduce       output bit-size = 48
        level      1 output bit-size = 49
        level      2 output bit-size = 57
        level      4 output bit-size = 61
        level      8 output bit-size = 63
        level     16 output bit-size = 64
        reduce       output bit-size = 48
        level     32 output bit-size = 56
        level     64 output bit-size = 60
        level    128 output bit-size = 62
        level    256 output bit-size = 63
        level    512 output bit-size = 64
        reduce       output bit-size = 48
        level   1024 output bit-size = 55
Input 0.000000 64
Iter 1024 - 0.000000 63
Iter   1 - 62.317033 63
Input 62.317033 64
Iter 1024 - 54.536322 55
Input 61.992309 64
Iter 1024 - 60.720435 63
Iter   1 - 62.324599 63
Input 62.324599 64
Iter 1024 - 54.425796 55

And the output vectors of q120_ntt_bb_avx2 and q120_intt_bb_avx2 for zero inputs are non-zero. It turns out that they are not reduced modulo  their respective Q1, Q2, Q3, Q4 primes and can be in the range [0, 2^{63}-1], which is not documented in q120_ntt.h.

These logs are only printed in debug mode. We shall remove them in future.

And the output vectors of q120_ntt_bb_avx2 and q120_intt_bb_avx2 for zero inputs are non-zero. It turns out that they are not reduced modulo their respective Q1, Q2, Q3, Q4 primes and can be in the range [0, 2^{63}-1], which is not documented in q120_ntt.h.

The q120 is in draft mode currently, so no much comments. This should change once we fully support q120 backend.
NTT/INTT does only the strictly necessary reduction so that the 4 i64 do not overflow. It's up to the calling party to do the reduction as a function of whether this is needed.

@ssmiler Is the q120 therefore currently by default in debug mode?

Not that I'm aware of. Last time I've compiled in release mode no ntt logs were shown. What compiler are you using?

I'm on wsl with 22.04. This is the output of the cmake
-- The C compiler identification is GNU 11.4.0
-- The CXX compiler identification is GNU 11.4.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Compiling spqlios-fft version: 1.0.0
-- The ASM compiler identification is GNU
-- Found assembler: /usr/bin/cc
-- Found gtest: I=/usr/include L=/usr/lib/x86_64-linux-gnu/libgtest.a,/usr/lib/x86_64-linux-gnu/libgtest_main.a
-- Found benchmark: I=/usr/local/include L=/usr/local/lib/libbenchmark.a
-- CANNOT FIND valgrind header: VALGRIND_DIR-NOTFOUND
-- /usr/lib/x86_64-linux-gnu/libgtest.a;/usr/lib/x86_64-linux-gnu/libgtest_main.a;pthread
-- Configuring done (1.8s)
-- Generating done (0.3s)
-- Build files have been written to: [...]/spqlios/build

You're right. The default mode is debug. I've open a pr #26 to fix it.

Should this issue be closed since #26 has been merged?

Yes, you can close it. Thx


Issues/initial message params

The final two parameters for the setInitialMessage and setCapturingMessage methods aren't being taken because the argument index is wrong.  (Looks like a copy-paste error.)  This PR fixes the argument indexes so they are pulled correctly from the Cordova command.

@tbehera @DiegoArenaOlivera Any chance this can be fixed? I don't mind running my own fork but I'm guessing other users may be running into this.

@tbehera - I think this is already fixed?

As of now, master is still showing the argument indices that aren't correct:
https://github.com/Acuant/AcuantHybridMobileSDK/blob/584e858e132b51341e07e9f0fed53f3681c898e8/cordova-plugin-AcuantHybridSDK/src/ios/AcuantMobileSDK.m#L350-L353
https://github.com/Acuant/AcuantHybridMobileSDK/blob/584e858e132b51341e07e9f0fed53f3681c898e8/cordova-plugin-AcuantHybridSDK/src/ios/AcuantMobileSDK.m#L312-L315


 VR crashes while it is computing the BH subgrid properties. The VR output with the crash looks as follows:
Opening group PartType0: Data set Coordinates
Opening group PartType1: Data set Coordinates
Opening group PartType4: Data set Coordinates
Opening group PartType5: Data set Coordinates
Opening group PartType0: Data set Velocities
Opening group PartType1: Data set Velocities
Opening group PartType4: Data set Velocities
Opening group PartType5: Data set Velocities
Opening group PartType0: Data set ParticleIDs
Opening group PartType1: Data set ParticleIDs
Opening group PartType4: Data set ParticleIDs
Opening group PartType5: Data set ParticleIDs
Opening group PartType0: Data set Masses
Opening group PartType1: Data set Masses
Opening group PartType4: Data set Masses
Opening group PartType5: Data set DynamicalMasses
Opening group PartType0: Data set InternalEnergies
Opening group PartType0: Data set StarFormationRates
Opening group PartType0: Data set MetalMassFractions
Opening group PartType4: Data set MetalMassFractions
Opening group PartType4: Data set BirthScaleFactors
Opening group PartType0: Data set ElementMassFractions
Opening group PartType0: Data set SpeciesFractions
Opening group PartType0: Data set SpeciesFractions
Opening group PartType0: Data set SpeciesFractions
Opening group PartType5: Data set SubgridMasses
HDF5-DIAG: Error detected in HDF5 (1.10.3) MPI-process 0:
  #000: H5S.c line 921 in H5Sget_simple_extent_ndims(): not a dataspace
    major: Invalid arguments to routine
    minor: Inappropriate type
terminate called after throwing an instance of 'std::length_error'
  what():  vector::_M_default_append
vel_rap_exact.sh: line 123: 185245 Aborted                 VR_ICRAR/VELOCIraptor-STF/build/stf -C vrconfig_3dfof_subhalos_SO_hydro.cfg -i /snap7/scratch/dp004/dc-chai1/my_cosmological_box/AGN_L006N188_00/colibre_2729 -o /snap7/scratch/dp004/dc-chai1/my_cosmological_box/AGN_L006N188_00/halo_2729 -I 2

If I comment out the lines
BH_internal_property_names=SubgridMasses,SubgridMasses,SubgridMasses,SubgridMasses,
BH_internal_property_input_output_unit_conversion_factors=1.0e10,1.0e10,1.0e10,1.0e10,
BH_internal_property_calculation_type=max,min,average,aperture_total,
BH_internal_property_output_units=solar_mass,solar_mass,solar_mass,solar_mass,

in the VR config file, the bug dissapperas and VR runs smoothly.

I am using the latest (18.08.20) version of VR from the Master branch of ICRAR
I compiled VR as: cmake -DVR_USE_HYDRO=ON
On cosma7, I loaded the following modules gsl/2.4, intel_mpi/2018, cmake/3.18.1, intel_comp/2018, parallel_hdf5/1.10.3
On cosma, the VR config file I am using can be accessed via /cosma7/data/dp004/dc-chai1/vrconfig_3dfof_subhalos_SO_hydro.cfg
The SWIFT snapshot file I am running VR on resides at: /snap7/scratch/dp004/dc-chai1/my_cosmological_box/AGN_L006N188_00_iso/colibre_2729.hdf5
I double-checked that the snapshot contains the SubgridMasses field.

Hi,
This is just to confirm that we can also reproduce the error. We were on our way to double-check that the changes in #14 were correct by running VR offline against SWIFT and hit the exact same issue. This seems to be completely unrelated to #13 though.

The problem seems to be that the dynamic list of open datasets is not correctly used when reading. Specifically, I think iextraoffset is not set correctly the in the loop starting on line 2516 of hdfio.cxx. The values are not set in a similar way in the first loop (line 2342) and the code does not read the correct dataset.
It "magically" works for gas extra properties as they are all at the start of the array.
A temporary very very dirty fix for the case of EAGLE/COLIBRE in SWIFT is to do this:
patch.txt
(don't do this at home!)
It forces the code to read the correct dataset. It will of course only work for the specific configuration file used by XL and friends.

@MatthieuSchaller just before leaving for our break we had also been looking around these lines with @cdplagos, trying to understand where the indexing goes wrong. Of course the patch above is fragile, so a more robust solution is needed.

Glad we all think the issue is around these lines. The patch is definitely not for public consumption but I listed it here for our colleagues in EAGLE using exactly the same configuration file.
If it helps with the debugging, I noticed that you also run into trouble if you add extra star properties. Only the gas seems to be OK.

An update on this: I have identified the problem that is causing this crash. As we had guessed it was an indexing issue, although in a different point of the code. In https://github.com/ICRAR/VELOCIraptor-STF/issues/15#issuecomment-679236639 @MatthieuSchaller correctly indicates that the indexing into the arrays is different between the first loop (which opens datasets and dataspaces) and the second one (where they are actually read). However, the first loop indexes past the size of the arrays (writing outside the vector's allocated memory), while the second indexes within the array boundaries. This makes it seem that the correct indexing scheme is the second one, so I fixed the first rather than adjusting the second.
After this VR runs almost to completion, until a new access into these arrays in a different part of the code produces again a crash (when using -O2 or higher, maybe also with -O1). I'm currently looking at this and I hope I'll have something working soon.

Thanks for the update.
Maybe adding extra star properties to the config file can also help identify problems.

This problem has been fixed now, and the fix is on the latest master.
However note that, as outlined in https://github.com/ICRAR/VELOCIraptor-STF/issues/15#issuecomment-690863111, a further problem appears down the road now that prevents VR from successfully finishing. I could at least confirm that this newly found problem is not caused by the fixes introduced for this issue, and as such I'll be opening a new issue to keep track of it.

The new issue described in #18 (and first mentioned in https://github.com/ICRAR/VELOCIraptor-STF/issues/15#issuecomment-690863111) is now also fixed (via #19).

Oh excellent news! Thanks for tackling these.

I can confirm that things work correctly.

Great, I'm closing this issue then.


[SPARK-44305][SQL] Dynamically choose whether to broadcast hadoop conf

What changes were proposed in this pull request?

In the buildReaderWithPartitionValues method of ParquetFileFormat and OrcFileFormat, it will determine whether to broadcast hadoopconf according to whether there are hadoop parameters specified by the customer. If there are no parameters specified by the user, the broadcast operation of hadoopconf will not be performed to improve the performance of the driver.
Why are the changes needed?

The ability introduced by SPARK-14912, we can broadcast the parameters of the data source to the read and write operations, but if the user does not specify a specific parameter, the propagation operation will also be performed, which affects the performance has a greater impact, so we need to avoid broadcasting the full Hadoop parameters when the user does not specify a specific parameter
Does this PR introduce any user-facing change?

NO
How was this patch tested?

QPS improvement, detailed test data will be added later

Took a quick look mostly on the code aspects. @HyukjinKwon's comment on is this the right approach is valid.
 Very curious about why this direction to begin with.
Yes, it is found here that in the case of small queries with large concurrency, the consumption is more obvious
. Tested some performance of 50 concurrency on SSB, parquet as the source data has a difference of 10%-13%


Enabling SDFGI crashes Godot due to missing support in MoltenVK

Godot version:
master - 0a8dbe7f75f2999e0f73af83dda3510c965f2b94
OS/device including version:
macOS Mojave 10.14.6
Radeon RX Vega 64 8GB
Vulkan backend
Issue description:
Enabling SDFGI led Godot to crash and exit with following error message in console:
   at: connect (core/object.cpp:1403)
[mvk-error] VK_ERROR_FORMAT_NOT_SUPPORTED: VkFormat VK_FORMAT_R4G4B4A4_UNORM_PACK16 is not supported on this device.
ERROR:  - Message Id Number: 0 | Message Id Name:
	VK_ERROR_FORMAT_NOT_SUPPORTED: VkFormat VK_FORMAT_R4G4B4A4_UNORM_PACK16 is not supported on this device.
	Objects - 1
		Object[0] - VK_OBJECT_TYPE_IMAGE_VIEW, Handle<PHONE_NUMBER>48304
   at: _debug_messenger_callback (drivers/vulkan/vulkan_context.cpp:136)
ERROR: Attempted to free invalid ID: 0
   at: _free_internal (drivers/vulkan/rendering_device_vulkan.cpp:6853)
handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] 1   libsystem_platform.dylib            0x00007fff67a23b5d _sigtramp + 29
[2] 2   ???                                 0x0000000000000000 0x0 + 0
[3] 3   AMDRadeonX5000MTLDriver             0x00007fff317b47da -[GFX9_MtlComputeCmdEncoder dispatchThreadgroupsWithIndirectBuffer:indirectBufferOffset:threadsPerThreadgroup:] + 194
[4] MVKCmdDispatchIndirect::encode(MVKCommandEncoder*)
[5] MVKCommandEncoder::encode(id<MTLCommandBuffer>)
[6] MVKCommandBuffer::submit(MVKQueueCommandBufferSubmission*)
[7] MVKQueueCommandBufferSubmission::execute()
[8] MVKQueue::submit(unsigned int, VkSubmitInfo const*, VkFence_T*)
[9] 9   libMoltenVK.dylib                   0x000000010ec0f554 vkQueueSubmit + 68
[10] vkQueueSubmit (in godot.osx.tools.64) (trampoline.c:871)
[11] VulkanContext::swap_buffers() (in godot.osx.tools.64) (vulkan_context.cpp:1295)
[12] RenderingDeviceVulkan::swap_buffers() (in godot.osx.tools.64) (rendering_device_vulkan.cpp:6933)
[13] RasterizerRD::end_frame(bool) (in godot.osx.tools.64) (rasterizer_rd.cpp:96)
[14] RenderingServerRaster::draw(bool, double) (in godot.osx.tools.64) (rendering_server_raster.cpp:0)
[15] RenderingServerWrapMT::draw(bool, double) (in godot.osx.tools.64) (rendering_server_wrap_mt.cpp:93)
[16] Main::iteration() (in godot.osx.tools.64) (main.cpp:2217)
[17] OS_OSX::run() (in godot.osx.tools.64) (os_osx.mm:317)
[18] main (in godot.osx.tools.64) (godot_main_osx.mm:76)
[19] 19  libdyld.dylib                       0x00007fff678383d5 start + 1
[20] 20  ???                                 0x0000000000000004 0x0 + 4
-- END OF BACKTRACE --

Steps to reproduce:

Create minimal scene with 3d node
Add World Environment
Turn on SDFGI

Minimal reproduction project:
SDFGI Test.zip

Sounds like this MoltenVK issue is related: Support VK_FORMAT_B4G4R4A4_UNORM_PACK16 for PPSSPP running via Wine

Unfortunately unlikely. Metal does not support an equivalent to that format.
Metal on iOS (but not macOS) does support the VK_FORMAT_R4G4B4A4_UNORM_PACK16 format.

There's a reference to this issue: Support for image format swizzles, where one of the last comments says that Metal 3.0 has support for this feature, so I guess it will come to MoltenVK eventually.

@JohanAR I think Metal 3 is in macOS Catalina so I'm going to try this again on my other Mac which has Catalina installed to see if it's fixed there. Just got to get Molten VK set up there first

For me, macOS 10.15.7 (Catalina), it doesn't seem to crash when I activate SDFGI, but instead freezes for a couple of seconds, then prints the same format not supported errors in the Godot Output tab in the editor, and seemingly nothing else.  If I try moving the viewport camera, rotating it works fine, but actually moving it seems to lag out the editor badly (doesn't print more errors).

Fixed by https://github.com/godotengine/godot/pull/55307. To make sure, please test again in tomorrow's nightly builds or by building from source :slightly_smiling_face:

or by building from source 🙂

If you are building it from source, make sure you are using the latest version of Vulkan SDK (<IP_ADDRESS>). The previous one (<IP_ADDRESS>), which was used for official pre-alpha builds, is quite buggy and will have black spots and other rendering artifacts all over the areas with lightning.

me too

@cheft Which Godot version are you using? Did you use an official build or compile from source?

M1 mac on nightly builds
Godot Engine v4.0.alpha.calinou (c) 2007-2022 Juan Linietsky, Ariel Manzur & Godot Contributors.
  modules/gltf/register_types.cpp:92 - FBX file import is enabled, but no FBX2glTF path is configured. FBX files will not be imported.
--- Debug adapter server started ---
--- GDScript language server started ---
切换场景选项卡
  drivers/vulkan/vulkan_context.cpp:159 -  - Message Id Number: 0 | Message Id Name:
  	VK_ERROR_FORMAT_NOT_SUPPORTED: VkFormat VK_FORMAT_R4G4B4A4_UNORM_PACK16 is not supported on this device.
  	Objects - 1
  		Object[0] - VK_OBJECT_TYPE_PHYSICAL_DEVICE, Handle<PHONE_NUMBER>12888
  Storage buffer supplied (binding: 1) must provide one ID (0 provided).
  ./servers/rendering/renderer_rd/uniform_set_cache_rd.h:129 - Condition "rid.is_null()" is true. Returning: rid
  drivers/vulkan/rendering_device_vulkan.cpp:7386 - Condition "!uniform_set" is true.
  Storage buffer supplied (binding: 1) must provide one ID (0 provided).
  ./servers/rendering/renderer_rd/uniform_set_cache_rd.h:129 - Condition "rid.is_null()" is true. Returning: rid
  drivers/vulkan/rendering_device_vulkan.cpp:7386 - Condition "!uniform_set" is true.
  Storage buffer supplied (binding: 1) must provide one ID (0 provided).
  ./servers/rendering/renderer_rd/uniform_set_cache_rd.h:129 - Condition "rid.is_null()" is true. Returning: rid
  drivers/vulkan/rendering_device_vulkan.cpp:7386 - Condition "!uniform_set" is true.
  Storage buffer supplied (binding: 1) must provide one ID (0 provided).
  ./servers/rendering/renderer_rd/uniform_set_cache_rd.h:129 - Condition "rid.is_null()" is true. Returning: rid
  drivers/vulkan/rendering_device_vulkan.cpp:7386 - Condition "!uniform_set" is true.
  Storage buffer supplied (binding: 1) must provide one ID (0 provided).
  ./servers/rendering/renderer_rd/uniform_set_cache_rd.h:129 - Condition "rid.is_null()" is true. Returning: rid
  drivers/vulkan/rendering_device_vulkan.cpp:7386 - Condition "!uniform_set" is true.
  Storage buffer supplied (binding: 1) must provide one ID (0 provided).
  ./servers/rendering/renderer_rd/uniform_set_cache_rd.h:129 - Condition "rid.is_null()" is true. Returning: rid
  drivers/vulkan/rendering_device_vulkan.cpp:7386 - Condition "!uniform_set" is true.
  Storage buffer supplied (binding: 1) must provide one ID (0 provided).
  ./servers/rendering/renderer_rd/uniform_set_cache_rd.h:129 - Condition "rid.is_null()" is true. Returning: rid
  drivers/vulkan/rendering_device_vulkan.cpp:7386 - Condition "!uniform_set" is true.
  Storage buffer supplied (binding: 1) must provide one ID (0 provided).
  ./servers/rendering/renderer_rd/uniform_set_cache_rd.h:129 - Condition "rid.is_null()" is true. Returning: rid
  drivers/vulkan/rendering_device_vulkan.cpp:7386 - Condition "!uniform_set" is true.
  Storage buffer supplied (binding: 1) must provide one ID (0 provided).
  ./servers/rendering/renderer_rd/uniform_set_cache_rd.h:129 - Condition "rid.is_null()" is true. Returning: rid
  drivers/vulkan/rendering_device_vulkan.cpp:7386 - Condition "!uniform_set" is true.
  Storage buffer supplied (binding: 1) must provide one ID (0 provided).
  ./servers/rendering/renderer_rd/uniform_set_cache_rd.h:129 - Condition "rid.is_null()" is true. Returning: rid
  drivers/vulkan/rendering_device_vulkan.cpp:7386 - Condition "!uniform_set" is true.
  Storage buffer supplied (binding: 1) must provide one ID (0 provided).
  ./servers/rendering/renderer_rd/uniform_set_cache_rd.h:129 - Condition "rid.is_null()" is true. Returning: rid
  drivers/vulkan/rendering_device_vulkan.cpp:7386 - Condition "!uniform_set" is true.
  Storage buffer supplied (binding: 1) must provide one ID (0 provided).
  ./servers/rendering/renderer_rd/uniform_set_cache_rd.h:129 - Condition "rid.is_null()" is true. Returning: rid
  drivers/vulkan/rendering_device_vulkan.cpp:7386 - Condition "!uniform_set" is true.
  drivers/vulkan/vulkan_context.cpp:159 -  - Message Id Number: 0 | Message Id Name:
  	VK_ERROR_FORMAT_NOT_SUPPORTED: VkFormat VK_FORMAT_R4G4B4A4_UNORM_PACK16 is not supported on this device.
  	Objects - 1
  		Object[0] - VK_OBJECT_TYPE_PHYSICAL_DEVICE, Handle<PHONE_NUMBER>12888

@cheft Please open a new issue with a minimal reproduction project attached.

@cheft @Calinou I still have the same problem, but enabling the SDFGI crashes not just Godot, but also my iOS system. Is any new tickets open for this problem? I have macOS: Monterey 12.0.1, Graphics: Intel Iris Graphics 550 1536 MB


TST: migrate from cypress to playwright

Reference Issues or PRs

What does this implement/fix?
Put a x in the boxes that apply

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features not to work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Other (please describe):

Testing

[ ] Did you test the pull request locally?
[ ] Did you add new tests?

Any other comments?

@fangchenli is this ready for review?

@marcelovilla can you check the status of this work?

I'm closing this draft PR for now as it has not seen any recent activity but we will evaluate the proposed changes and see if we can built on top of it to close #2337


implement wrapper client containing createProject and getProject methods

Closes #168
Note: this is currently stacked on #187 as it relies on changes in that PR
TODO:

[ ] (better) tests
[ ] update to @mapeo/schema https://github.com/digidem/mapeo-schema/issues/132

Just took a quick look, not a full review. Sorry I'd forgotten about the keys being buffers and the encoding question. There are several options for encoding to a buffer, and v8 serialize is one, but I worry that depending on v8 will come back and bite us at some point in the future. We actually have a pbf encoder for the encryption keys in rpc/messages.js. You should be able to do Invite_EncryptionKeys.decode() and it should be type-safe. I suggest using that, although we should also probably move the EncryptionKeys message out of the Invite namespace.

Just took a quick look, not a full review. Sorry I'd forgotten about the keys being buffers and the encoding question. There are several options for encoding to a buffer, and v8 serialize is one, but I worry that depending on v8 will come back and bite us at some point in the future. We actually have a pbf encoder for the encryption keys in rpc/messages.js. You should be able to do Invite_EncryptionKeys.decode() and it should be type-safe. I suggest using that, although we should also probably move the EncryptionKeys message out of the Invite namespace.

Yeah that was something I was thinking about as I started using it. Was way easier to use than anything I was aware of, so I stuck with it.
As a note if Invite_EncryptionKeys gets extracted, looks like it doesn't handle the following keys for this use case (at least from a types perspective but probably also at runtime): projectKey, projectSecretKey, and config (last one is going to be addressed via https://github.com/digidem/mapeo-core-next/issues/196)

We need to wait for tests to be fixed?

Regrettably implemented changes that are now reliant on the project info schema being updated to allow optionals. probably would've made more sense to do as a follow-up. Couple of options to make this unblocked:

skip the tests added in this PR that fail because of ^
revert changes related to the assumption above

any preferences?

also tests aren't running on this PR since it's stacked on a different one, but tests will fail for the same reason

@gmaclennan this should be in a good state to review now (tests aren't running since it's stacked though, but they pass locally for me 😄 )

Did a rebase on main to unstack this but it was kind of tricky (probably should've used merge instead). Seems like it only made a couple of minor mistakes (fixed now) but in case anything in the diff looks weird 😅


No reuse of daemons, no build speedup.

'Starting new daemon, 1 incompatible, 3 stopped'
Each time I invoke mvnd, it starts a new daemon, and there is no build speedup.  How does it check for a compatible daemon?
 I would use mvnd even with no speedup because the build output is so improved!

I'm seeing the same behaviour on Mac. Every run says that the daemon is either busy or incompatible.

Thanks for the report. Could you please briefly describe which mvnd commands you issue? Are you switching directories, possibly going to fully independent source trees? Do you see anything interesting in the log files under .m2/mvnd/registry/*/?

Thanks, I was able to figure out what is the problem. The fix is underway.


Large SQL statements cannot be executed

The connection class cannot execute SQL statements which are very long (together with data).
I was getting the following error due to this:
pyhdb.exceptions.DatabaseError: error while parsing protocol: invalid communication buffer structure

The SQL length is 146742.
Is there a way I can increase the buffer size, etc to execute this? I noticed the DEFAULT_CONNECTION_OPTIONS is being used during the connection creation, but not sure whether this can be used. If so, please advice.

What about use fetchall()? Since I can query 2 millions data

For me the problem is not querying a lot of data, but having an sql command which is very long. Therefore the command itself is not getting executed at all.

This error related to the SQL string size and not the result set size.
We had the same problem which was possible to overcome by overriding the MAX_MESSAGE_SIZE value before opening the connection:
            pyhdb.protocol.constants.MAX_MESSAGE_SIZE = 2**19
            pyhdb.protocol.constants.MAX_SEGMENT_SIZE = pyhdb.protocol.constants.MAX_MESSAGE_SIZE - 32

            connection = pyhdb.connect(...)

The default value is  2**17, which is about 130KB.

Closing due to the sunset of the project. Please check active maintained alternative: https://pypi.org/project/hdbcli/


Add password requirement info on error

Fixes #8910
This will show the current complexity requirements in the UI when the user fails to meet them. I'm unsure about the path I took to solve it, so please criticize with impunity. 😅

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@af7f08b). Click here to learn what that means.
The diff coverage is 39.28%.

@@           Coverage Diff            @@
##             master   #9074   +/-   ##
========================================
  Coverage          ?   41.1%
========================================
  Files             ?     548
  Lines             ?   71450
  Branches          ?       0
========================================
  Hits              ?   29372
  Misses            ?   38366
  Partials          ?    3712

Impacted Files
Coverage Δ

routers/user/auth.go
11.76% <0%> (ø)

routers/admin/users.go
30.33% <0%> (ø)

routers/user/setting/account.go
25.29% <100%> (ø)

modules/password/password.go
88.88% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af7f08b...cb4b0f6. Read the comment docs.

Make lg-tm work


Not working for some reasons

It's been about 2 weeks since this add-on stopped working for me as well. I did get about 2 days of Reels being omitted from my Facebook feed.
.
In "configure" reels and shared reels are still checked.


FlowLayout calculates wrong

If you have a FlowLayout in center of borderlayout and set margins to the flow layout but not to the borderlayout, components in flowlayout don't use the right margins....

In Ticket FS#8424 I've fixed a FlowLayout margin issue, when the horizontal/vertical alignment is "stretch".
Is your FlowLayout stretched aswell, or do you maybe have a screenshot of the screen?

I've tried doing it as you described and added some buttons, but I don't really know if there is an issue here...

already fixed


Waymo OD Challenge - Need Help Understanding Image Frame

https://github.com/waymo-research/waymo-open-dataset/blob/016a54e8a57ffd7c84b4516fe7e335432ffc9212/third_party/camera/ops/camera_model_ops_test.py#L143-L147
https://github.com/waymo-research/waymo-open-dataset/blob/master/third_party/camera/ops/camera_model_ops_test.py#L155-L157
In the above lines, image_points is converted to global_points using the py_camera_model_ops.image_to_world() method. I understand that the 3rd elements, the z dim element, in each global_point is the height from the ground, following the gravity vector. What does the 3rd element, 20 in this case, in each image_point represent? Distance from the camera? Height from the ground? Also, what units are they in?
Thanks in advance

Distance from the point  to camera frame origin.
comment: https://github.com/waymo-research/waymo-open-dataset/blob/master/third_party/camera/camera_model.h#L81
code (for global shutter): https://github.com/waymo-research/waymo-open-dataset/blob/master/third_party/camera/camera_model.cc#L447-L448

Got it, thanks for clarifying!
Another quick question, we are getting some negative Z values after converting to global frame? Does a negative Z value indicate the object is underground? Or is the ground not defined as Z = 0?
Also, are the global and vehicle frame values in meters?

Values in global frame cannot be interpreted as is. Negative z's are common there. If you see huge negative z's in vehicle frame, it might be concerning (but can still happen).
negative z indicates a downward slope which is common in SF. Values are in meters.

Understood, thanks so much Pei Sun!

Ashwin


Allow passing in github token as an input

I'm here via oclif after using oclif's generator command to generate my CLI:
npx oclif generate

This generated a bunch of github workflows which depend on oclif's github workflows, which are duplicates of this repo. Let me know if I'm opening an issue in the wrong repo.
Unfortunately, none of the workflows work because they all directly reference the secrets the workflows depend on, e.g. here.
Since GitHub actions doesn't allow sharing secrets between organizations in different enterprises, this means the token is null and nothing works: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idsecretsinherit
Would be great to have this fixed. I was excited about not having to write my own GitHub actions, but unfortunately this ruins that.

Yeah, I hit the same errors when trying to publish my plugin outside of the salesforcecli org.
We are aware of this and still haven't decided the solution (either publish actions or maintain a "lighter" version for external users.
My solution was to copy the workflows from here and remove some salesforce-specific stuff, with these you can do a manual release from the actions UI and get GH releases -> npm publish done.
https://github.com/cristiand391/sf-plugin-api/tree/main/.github/workflows

I ended up forking the repo myself as well, which worked fine. I had to do this manually using this method as github won't let you reference workflows from forks from other orgs, apparently.
either publish actions or maintain a "lighter" version for external users

You're kind of already doing both, since the actions are published as part of the oclif generator. They point to the "lighter" version available in the oclif repo.
It seems like it'd be pretty easy not to directly reference the secret, and instead accept just accept it as an input parameter. I'm happy to propose a PR if that'd be helpful.

Hi! I'm pretty new to GH actions so if anyone would be kind enough to guide me in the proper direction on how to workaround this issue I would be very grateful

you can pass in a secret now.
See readme: https://github.com/salesforcecli/github-workflows/blob/main/README.md#githubrelease