localStream.muteVideo() from agora-rtc-sdk is not handled correctly in react-native-agora

Hi guys. Thank you this awesome package. We develop application with video calls across web and mobile applications.
We use<EMAIL_ADDRESS>for web and<EMAIL_ADDRESS>for mobile
We faced with the following issue: when web app calls localStream.muteVideo() on their side - "RemoteVideoStateChanged" event is triggered in mobile app two times every second with the following values:

VideoRemoteState.Stopped && VideoRemoteStateReason.RemoteMuted
VideoRemoteState.Decoding && VideoRemoteStateReason.RemoteUnmuted

So there is no way to handle mute/unmute of remote video.
(Btw event "UserMuteVideo" is also triggered every second with muted values: true/false and it's not triggered when user unmutes his video)
Then if user in web app unmutes his video - nothing is triggered in mobile app
Everything works fine with calls between web to web and mobile to mobile
Could you point me how to fix that, thanks

Hi guys. Thank you this awesome package. We develop application with video calls across web and mobile applications.
We use<EMAIL_ADDRESS>for web and<EMAIL_ADDRESS>for mobile
We faced with the following issue: when web app calls localStream.muteVideo() on their side - "RemoteVideoStateChanged" event is triggered in mobile app two times every second with the following values:

VideoRemoteState.Stopped && VideoRemoteStateReason.RemoteMuted
VideoRemoteState.Decoding && VideoRemoteStateReason.RemoteUnmuted

So there is no way to handle mute/unmute of remote video.
(Btw event "UserMuteVideo" is also triggered every second with muted values: true/false and it's not triggered when user unmutes his video)
Then if user in web app unmutes his video - nothing is triggered in mobile app
Everything works fine with calls between web to web and mobile to mobile
Could you point me how to fix that, thanks

Maybe you might need to distinguish between channels and uids?
This problem is solved in this example.
rtcChannel.addListener(
      'RemoteVideoStateChanged',
      (uid, state, reason, elapsed) => {
        console.info('RemoteVideoStateChanged', uid, state, reason, elapsed);
        if (state === VideoRemoteState.Starting) {
          if (channelId === channelId0) {
            this.setState({ remoteUid0: [...this.state.remoteUid0, uid] });
          } else if (channelId === channelId1) {
            this.setState({ remoteUid1: [...this.state.remoteUid1, uid] });
          }
        } else if (state === VideoRemoteState.Stopped) {
          if (channelId === channelId0) {
            this.setState({
              remoteUid0: this.state.remoteUid0.filter(
                (value) => value !== uid
              ),
            });
          } else if (channelId === channelId1) {
            this.setState({
              remoteUid1: this.state.remoteUid1.filter(
                (value) => value !== uid
              ),
            });
          }
        }
      }
    );

@RoJoHub Thank you for your answer. But i think you got me wrong. We have only one channel. The problem is that:

when web app calls muteVideo() - mobile app starts to behave weird: RemoteVideoStateChanged event is triggered every second two times with values like video was just muted and then immediately unmuted

VideoRemoteState.Stopped && VideoRemoteStateReason.RemoteMuted
and
VideoRemoteState.Decoding && VideoRemoteStateReason.RemoteUnmuted

when web app calls unmuteVideo() - nothing is triggered in mobile app

Everything works fine for calls between web and web, mobile and mobile. Issue happens only in calls between web and mobile
Here is how web creates stream:
this._localStream = AgoraRTC.createStream({
        streamID: uid,
        audio: true,
        video: true,
        screen: false,
      });

Let me know if you need additional reproducing steps. Could someone help to fix the issue please. It's very critical for us

We are looking into the problem now. Just a moment, please

@RoJoHub Thank you for your answer. But i think you got me wrong. We have only one channel. The problem is that:

when web app calls muteVideo() - mobile app starts to behave weird: RemoteVideoStateChanged event is triggered every second two times with values like video was just muted and then immediately unmuted

VideoRemoteState.Stopped && VideoRemoteStateReason.RemoteMuted
and
VideoRemoteState.Decoding && VideoRemoteStateReason.RemoteUnmuted

when web app calls unmuteVideo() - nothing is triggered in mobile app

Everything works fine for calls between web and web, mobile and mobile. Issue happens only in calls between web and mobile
Here is how web creates stream:
this._localStream = AgoraRTC.createStream({
        streamID: uid,
        audio: true,
        video: true,
        screen: false,
      });

Let me know if you need additional reproducing steps. Could someone help to fix the issue please. It's very critical for us
Hi, friend.
As you said, the problem does exist.
We will step up efforts to solve this problem.

Thanks for you issue.

Any solution? I have the same problem


bash: README.md: command not found when trying to start the cron

I am getting this error when I'm trying to setup the cron job post installation:
bash: README.md: command not found
Here is how I am deploying the app:
https://github.com/assldev/unacms-tutorial
I also want to know what cron jobs are being run anyway?

it may be that path to php binary is incorrect, also it would be great if you post your question in official UNA support forum providing some more details, at least what is the command you are running before receiving this error


Handle trailing white spaces in yaws_server:body_method/4

in accordance with the spec
https://tools.ietf.org/html/rfc7230#section-3.2:
header-field = field-name ":" OWS field-value OWS

This fix is prompted by the following entry that shows up in
report.log from time to time:
=ERROR REPORT==== 3-Apr-2019::18:19:00.139688 ===
Yaws process died:
{badarg,
[{erlang,list_to_integer,["0 "],[]},
{yaws_server,body_method,4,
[{file, "/myapp/_build/default/lib/yaws/src/yaws_server.erl"},
{line,1737}]},
{yaws_server,aloop,4,
[{file, "/myapp/_build/default/lib/yaws/src/yaws_server.erl"},
{line,1261}]},
{yaws_server,acceptor0,2,
[{file, "/myapp/_build/default/lib/yaws/src/yaws_server.erl"},
{line,1073}]},
{proc_lib,init_p_do_apply,3,
[{file,"proc_lib.erl"},{line,249}]}]}

I manually squashed these commits and rebased to master. Thanks for the fix!

Thanks.


Switch to watching releases rather than tags

Watching for tags works, but introduces the risk that an unexpected tag name that happens to match the regex will trigger a push.
Additionally, a tag on a branch other than main could trigger the workflow as well.
By limiting only to actual releases, we ensure that we only push to RubyGems when we actually publish a release.
Related:

https://github.com/dependabot/dependabot-core/issues/7132

I think we'll want to update our scripts/docs to generate releases instead of adding a tag? We currently don't have any releases for Core https://github.com/dependabot/dependabot-core/releases

I think we'll first want to update our scripts/docs to generate releases instead of adding a tag?

They were already updated in https://github.com/dependabot/dependabot-core/pull/7211:
https://github.com/dependabot/dependabot-core/blob/d9519cd2c4c901bc60d26c3b93ebed65049d8f4c/README.md#L535-L545
https://github.com/dependabot/dependabot-core/blob/d9519cd2c4c901bc60d26c3b93ebed65049d8f4c/.github/workflows/gems-bump-version.yml#L67-L77
You can see the generated output here:
https://github.com/dependabot/dependabot-core/actions/runs/4888068150

We currently don't have any releases for Core https://github.com/dependabot/dependabot-core/releases

Yeah, that's because I ran into the issue that the version bump PR's need a PAT to trigger CI... I'm working through some security questions around that with a few other folks.
I'm fine to wait, but there's no code change (other than the PAT perhaps) that blocks this... both our docs and our scripts are already updated.


Support node v4.1.1

Per https://github.com/willwhitney/hydrogen/issues/135, this package seems to cause an error on node v4.1.1. Hydrogen (an Atom package) depends on https://github.com/JustinTulloss/zeromq.node, which depends on this package.
If this isn't related to node-bindings, please let me know!

Also see https://github.com/atom/atom/issues/9660

@willwhitney I think this issue should be closed here (since it's already fixed in Atom).

Yup!


[New chain]: OORT MainnetDev (Testnet)

Summary
I would like to add Safe v1.4.1 for OORT DevNet (Testnet)
Chain ID
9700
Chain detail URL
https://chainlist.org/chain/9700
RPC URL
https://dev-rpc.oortech.com
Blockscout Client URL
No response
Etherscan Client URL
No response
Etherscan Client API URL
No response
Version
1.4.1
Address (Master copy)
0x94ae01259d7e84D612070ca004D242F0d5213819
Deployment Tx hash (Master copy)
0x5e76713eb17702bc836ff1bce58454835a0f33ca0870ce6c8a1d11d2830ae65c
Block explorer URL (Master copy)
https://dev-scan.oortech.com/tx/0x5e76713eb17702bc836ff1bce58454835a0f33ca0870ce6c8a1d11d2830ae65c
Address (Master copy L2)
0x24372682Db02aA5d5bA54168B49F3b54c1128154
Deployment Tx hash (Master copy L2)
0x230f0de46efcefa107ce91890b2b5edf1de2b97859b287102c0a94215d020609
Block explorer URL (Master copy L2)
https://dev-scan.oortech.com/tx/0x230f0de46efcefa107ce91890b2b5edf1de2b97859b287102c0a94215d020609
Address (Proxy factory)
0x786Cf8CA0B88CD745aD2e3824Af7B17174dAe092
Deployment Tx hash (Proxy factory)
https://dev-scan.oortech.com/tx/0x1e9abcaf6110c647cd69586d8db8ad68f80dbc668623433c146ff630fdf8861d
Block explorer URL (Proxy factory)
https://dev-scan.oortech.com/tx/0x1e9abcaf6110c647cd69586d8db8ad68f80dbc668623433c146ff630fdf8861d

missing something? @falvaradorodriguez

looks like there is an issue validating the input to the RPC https://github.com/safe-global/safe-eth-py/actions/runs/11137548257/job/30951137433 checking this


Compatibility with OpenSearch v2.13.0

Description
We need to ensure the UI compatibility with the next version of OpenSearch v2.12.0
This update is still being discussed, but we need to be aware of potential issues.
For that, we need to:

[x] Review opensearch and opensearch-dashboard latest stable changelog.
[x] Identify improvements and potential impact on the UI.
[ ] Create new tracking and development branches.
[ ] Develop a testing environment to verify our components would work under this new build.

Issues

List here the detected issues

OpenSearch Dashboards 2.13.0 Release Notes

[Discover] Options button to configure legacy mode and remove the top navigation option (https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6170)
[BUG][Discover] Allow saved sort from search embeddable to load in Dashboard (https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5934)
[BUG][Discover] Add key to index pattern options for support deplicate index pattern names(https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5946)
[BUG][Discover] Allow saved sort from search embeddable to load in Dashboard (https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5934)
[Discover] Enable 'Back to Top' Feature in Discover for scrolling to top (https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6008)

Navigation looks correct

Errors are shown in the console in the dashboard and events sections

Tar works as expected


Config error with GOROOT variable

I know nothing about Go. So I followed the instructions as best I could. I ran the executable via MacOS terminal.
I set my data folders to my project data folder like this
{
    "country_html_root": "~/Desktop/projects/diplomacy/app/data/country_html/pages",
    "country_html_blacklist": "~/Desktop/projects/diplomacy/app/data/country_html/blacklist",
    "country_html_yearly_summaries": "~/Desktop/projects/diplomacy/app/data/country_html/yearly_summaries",
    "country_json_root": "~/Desktop/projects/diplomacy/app/data/country_json",
    "weekly_json_root": "~/Desktop/projects/diplomacy/app/data/weekly_json"
}

Ran go run parse_html_to_json.go and immediately received the following error:
parse_html_to_json.go:4:2: package country is not in GOROOT (/usr/local/go/src/country)
parse_html_to_json.go:7:2: package logger is not in GOROOT (/usr/local/go/src/logger)

How do I resolve this error?

At the moment I can't really recommend using this project because it's out of date since the website redesign of CIA World Factbook a few years ago. I plan to update it one day but it's a big job and I don't have time to do it just now.
To answer the question though, try using GOPATH variable
export GOPATH=$PWD
PWD should be the path to the project and allows go to import packages from the src directory.
https://go.dev/doc/gopath_code


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_b141z7t176/clone/recipe/meta.yaml:14: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_b141z7t176/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
WARNING: /tmp/abs_b141z7t176/clone/recipe/meta.yaml:44: missing_description: The recipe is missing a description
ERROR: /tmp/abs_b141z7t176/clone/recipe/meta.yaml:44: missing_license_family: The recipe is missing the about/license_family key.
ERROR: /tmp/abs_b141z7t176/clone/recipe/meta.yaml:44: missing_dev_url: The recipe is missing a dev_url
ERROR: /tmp/abs_b141z7t176/clone/recipe/meta.yaml:44: missing_documentation: The recipe is missing a doc_url or doc_source_url
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_b9uxi1aok1/clone/recipe/meta.yaml:14: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_b9uxi1aok1/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_b9uxi1aok1/clone/recipe/meta.yaml:44: missing_documentation: The recipe is missing a doc_url or doc_source_url
ERROR: /tmp/abs_b9uxi1aok1/clone/recipe/meta.yaml:44: missing_dev_url: The recipe is missing a dev_url
ERROR: /tmp/abs_b9uxi1aok1/clone/recipe/meta.yaml:44: missing_license_family: The recipe is missing the about/license_family key.
WARNING: /tmp/abs_b9uxi1aok1/clone/recipe/meta.yaml:44: missing_description: The recipe is missing a description
Errors were found


EvoRouter needs to handle trailing /

Describe the bug
EvoRouter no longer supports a trailing / for the URL path.
Expected behavior
This should treat the trailing / as if it were not there.

This will be in the next release


Force 16:9 output on devices with taller displays

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
I dont like how you cannot output the video in 16:9 as it leaves me with black bars on my monitor due to my device's taller display.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Ability to tell scrcpy to use 1920:1080 for example.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Forcing my phone to use 16:9 itself.

Scrcpy will always respect device aspect-ratio. If you want mirroring fit your computer screen, you can crop.

Scrcpy will always respect device aspect-ratio. If you want mirroring fit your computer screen, you can crop.

How can I crop?

https://github.com/Genymobile/scrcpy#crop

https://github.com/Genymobile/scrcpy#crop

thanks.
Though I did something wrong with the crop. as this scrcpy --crop 1920:1080:0:0  -f doesn't seem to be cropping it down to 16:9 widescreen? What did I do wrong?

What are your device dimensions?


remove irrelavant emojis from the website

Some emojis are not needed in certain places like 🔥 Free hit and also 😎 Github, add actual icons instead

And also buttons are too smaller, make it medium sized buttons

do you want to work on it

sure


Backend apis

This PR updates the 4 email auth apis (sign in, sign up, password reset, email link sign in) to support recaptcha enterprise. go/gcip-recaptcha-client-sdk-api
Development progress

Implement getRecaptchaConfig API https://github.com/firebase/firebase-ios-sdk/pull/10038
New backend error types https://github.com/firebase/firebase-ios-sdk/pull/10048
Update backend apis https://github.com/firebase/firebase-ios-sdk/pull/10063
Implement recaptcha enterprise verifier
Wire recaptcha enterprise verifier to email auth flows

If possible, it would also be good to have a product team reviewer as well on this series of PRs.

Yeah, good idea.

/lgtm


Typescript showing error in input name attribute when zod schema has optional string properties with validation

I'm having an issue with TypeScript detecting an issue in my input name attributes when I'm trying to use optional string properties within my zod schemas/
My schema looks like this:
export const customerInfoDto = z.object({
	companyId: z.string(),
	name: z.string(),
	addresses: z.array(z.object({
		id: z.string().uuid(),
		name: z
			.string({ required_error: 'Name is required' })
			.min(2, { message: 'Name must be at least 2 characters' })
			.max(256, { message: 'Name must be 256 characters or less' }),
		address1: z
			.string({ required_error: 'Address 1 is required' })
			.min(2, { message: 'Address 1 must be at least 2 characters' })
			.max(256, { message: 'Address 1 must be 256 characters or less' }),
		address2: z.string().max(256, { message: 'Address 2 must be 256 characters or less' }).optional().or(z.literal('')),
		address3: z.string().max(256, { message: 'Address 3 must be 256 characters or less' }).optional().or(z.literal('')),
		address4: z.string().max(256, { message: 'Address 4 must be 256 characters or less' }).optional().or(z.literal('')),
	}))
});

On my form I use the code snippet from your sveltekit example:
const customerInfo = formFields<typeof customerInfoDto>();
which calls:
export function formFields<T extends z.Schema>() {
	return fields<z.infer<T>>();
}

This is how I display the properties within the addresses array.
{#each data.customer?.addresses as address, i}

	  Name
	  <input
		  class="input"
		  type="text"
		  name={customerInfo.addresses(i).name}
		  placeholder="Address Name"
		  value={data.customer?.addresses[i].name}
	  />

	  Address 1
	  <input
		  class="input"
		  type="text"
		  name={customerInfo.addresses(i).address1}
		  placeholder="Address 1"
		  value={data.customer?.addresses[i].address1}
	  />

	  Address 2
	  <input
		  class="input"
		  type="text"
		  name={customerInfo.addresses(i).address2}
		  placeholder="Address 2"
		  value={data.customer?.addresses[i].address2}
	  />

{/each}

The name attribute works for the properties Name and Address1, but not for Address2
I get the following error:

Any help would be greatly appreciated.

Thanks for such a quick response.
After updating to the latest version, it appears to now be working :)


The release badge doesn't work for repo names with dot (.)

I have a repo named Casbin.NET. It contains a dot in the name. And I found the release badge will say: no releases or repo not found. How to fix? Thanks.

[x] shields.io
[ ] My own instance
[ ] gh-badges NPM package

:beetle: Description

[![Release](https://img.shields.io/github/release/casbin-net/Casbin.NET.svg)](https://github.com/casbin-net/Casbin.NET/releases/latest)

Hi @hsluoyz - it seems the badge is working.
https://img.shields.io/github/release/casbin-net/Casbin.NET.svg

I took a look at your repo it seems like you created the 1.1.0 release roughly ~1 hour after opening this issue so I'm guessing that's what resolved this.
I'm going to go ahead and close this but please feel free to reopen if you're still having an issue with the badge.

I found the cause is that it has no releases. After releasing a version, the badge works. Thanks!


bug: npm i in new app not working

Provide environment information
"initVersion": "7.25.1"
Describe the bug
Soon as I run npm i, I'm gettng this error:
➜ npm i
npm ERR! code EUNSUPPORTEDPROTOCOL
npm ERR! Unsupported URL Type "workspace:": workspace:*
Reproduction repo
https://github.com/dommich95/repo-not-working
To reproduce
npm create t3-app@latest
Additional information
No response

fixed in 0.7.3


Remove version: Microsoft.Edge.Beta version 123.0.2420.53

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/f86474db-330c-4a7a-a388-04b2859f0f91/MicrosoftEdgeBetaEnterpriseX86.msi
OK
(Automated message - build 912)

Close with reason: Package still available;


.onFinished is not fired by AudioRecorder after playback (iOS)

The onFinished method is not fired when using AudioRecorder to play an already-recorded file.
onFinished does fire when recording terminates (on a hardware device).
onProgress does fire during both recording and playback when running the app (on a hardware device).
None of these methods fire in an iOS simulator.

Similarly, I haven't been able to get onFinished to fire for recording on an Android device. Not sure if this should be a separate issue.
Might have something to do with NativeAppEventEmitter needed special configuration with Android? such as described here: https://github.com/facebook/react-native/issues/7341

onFinished may be fixed now for Android. Can you test? For playback, in the next version playback will likely be removed completely in favor of using other libraries for this purpose, such as react-native-sound. The goal is to eventually merge with this library.

.onFinished is not fired on Android as of version 3.1.0.

Not sure if this helps, but I was messing around trying to get it to work. The documentation is a little fuzzy on the difference between NativeAppEventEmitters and DeviceEventEmitters so more info on the difference would be handy. I managed to get it to work with
DeviceEventEmitter.addListener('recordingProgress', (e) => console.log(e));
DeviceEventEmitter.addListener('recordingFinished', (e) => `console.log(e));

in my componentDidMount(). Unfortunately I have a failing ios build (unrelated to this) so I can't test it on there.
Is it something wrong with the way the listener is setup in the example? Cause I can't get it to work from AudioRecorder.onProgress which seems the most pragmatic and sensible solution (especially if DeviceEventEmitter should be used for Android and the other for iOS).

onProgress & onFinished also not fire on Android, did anyone know how to fix it?

This issue was originally about the callbacks specifically while playing audio (which is no longer a feature), but a few people have mentioned other similar issues. They should be fixed now in https://github.com/jsierles/react-native-audio/pull/150!


UPDATE_SNAPSHOTS=true should support "1"

Released in https://github.com/dethcrypto/earl/releases/tag/earljs%400.1.11


Problem , didn't see Zigbee either device went out three days ago. What to do?

until now all devices were working without a problem Aqara switches and others were connected to Xiaomi Getaway 3 . from 3 days ago disappeared and there is no connection. What to do?

Provide more useful info. Integration debug logs for example

Same situation.
Log of integration attached.
config_entry-xiaomi_gateway3-d967f5562231bc7ecfc90702ef4fbc6f.json.txt

No idea why or what happened, in my case all is back online again.  No changes done whatsoever.


[SCRIPTING] [QUESTION] How to set Attribute/Perk points?

I am wondering how to set attribute points and perk points through the Lua API.

Game.GiveDevPoints('Attribute', 1337)
Game.GiveDevPoints('Primary', 1337)

Game.GiveDevPoints('Attribute', 1337)
Game.GiveDevPoints('Primary', 1337)

thanks dude you're L33t


Timezone selection doesn't work

It's not possible to change the timezone on the drop down

Only an issue on the form view


Update to work with Vault 0.6

The documentation (and so, I assume, the codebase) uses the phraseology of Vault <= 0.5 (specifically, "cubbyhole"). Vault 0.6 introduces the concept of "wrapped" tokens, which simplifies the job of this application.
Will vault-gatekeeper-mesos work with the current version of Vault?
When will the code/documentation be updated to the latest version?

Supporting both would be awesome  (at least for a while).
I just got this working with 5, lol.
On a side note, well done @ChannelMeter .

@siddharthist I had this same question; reading through the vault docs, vault-gatekeeper-mesos will still work with vault 0.6, as the cubbyhole endpoint still exists and still functions in the way required by vault-gatekeeper-mesos, since vault 0.5.
Despite this, it would be nice to use response wrapping, as then you get the full original vault secret back, including TTL, etc. That would save vault-gatekeeper-mesos having to write those things out into the cubbyhole itself.

I was made aware of the response wrapping quite some time ago - AFAICT, response wrapping is a formal "correct" way to handle cubbyhole auth, but is still just syntax sugar. It should still work with Vault 0.6, and we may want to keep doing it our way to support older vault versions for the time being.
If we ever switch to response-wrapping it will include a notice that we would be dropping support for Vault <0.6

@nemothekid Is there a reason not to have both?

@siddharthist @nemothekid I'm happy to build a PR to allow both - if a bool was added to the /token request json to indicate whether the requester wanted response wrapping to be used, older clients wouldn't have to worry about upgrading because the field in the struct that the request json gets deserialised to would just remain false.

@nemothekid We were looking at integrating vgm with Mantl.io and we're already familiar with the new response wrapping API is especially why I ask.
@chill That sounds awesome :+1:

I was thinking along the lines of I'd rather support one or the other but not both. When we target 0.6, just using response wrapping would really simplify client implementations because it would be a standard API.
I'd rather not support both at this time just because that would increase the complexity of the project,  especially considering we don't have proper integration tests yet,. If @chill would like to tackle it, I would gladly accept a PR that dropped the old code (and dropped support for Vault 0.5), rather trying to support both. I'd imagine in 1-2 months everyone would be on the response wrapping API and I wouldn't want people to depend on that code if it'll end up neglected.

Happy to do so

I'm planning to close this issue once I cut a new release. I'd like to get come tests up and running (working in the travis branch) before making a new release which should be done this week.

@nemothekid How's that going? Did you identify any issues in your testing I could try and help out with?

Version v0.5.2 now works exclusively with wrapped responses (so only version 0.6.0 of Vault and greater).

Nimi, I just upgraded my deployments to Vault 6.0 and VGM 0.5.2. I'm no longer getting my perm token returned for some reason.
I pass this and successfully receive a temp token still:
VAULT_TEMP_TOKEN="`curl -s -L \
	-H 'Content-Type: application/json' \
	-X POST \
	-d '{ "task_id":"'$MESOS_TASK_ID'" }' \
	"https://$VGM_ADDR/token"`"

Then I use that temp token to try and get the perm token
curl -L \
  -H "X-Vault-Token: $VAULT_TEMP_TOKEN"  \
  -X GET "https://$VAULT_ADDR/v1/cubbyhole/vault-token"

But since the upgrade, getting Permission Denied. Does anything change on the client side in terms of the curl request?

Yes, the client side of the request now uses Response Wrapping which was introduced in Vault 0.6.
The only change you must make is to the vault backend, which is now written to the /response path.
curl -L \
  -H "X-Vault-Token: $VAULT_TEMP_TOKEN"  \
  -X GET "https://$VAULT_ADDR/v1/cubbyhole/response"

The format of the response has changed as well.

The documentation in the README in the root of the project suggests that VGM doesn't use response wrapping: "[VGM will] request the creation of 2 tokens (temp and perm). The temp token, which can only be used twice, will be first used by Vault internally to write the perm token into it's own Cubbyhole at the path response. This temp token is then provided to the service which can use that token to retrieve the perm token."
Might be good to update the README accordingly?
(I'm assuming that the protected service can now use "https://$VAULT_ADDR/v1/sys/wrapping/unwrap" rather than "https://$VAULT_ADDR/v1/cubbyhole/response" to unwrap the token?)


YamlCreate does not handle manifest-level parameters

Brief description of your issue
Some manifests define installer parameters at the manifest level instead of at the installer level. YamlCreate is unable to properly handle these
Expected behavior
Manifest level parameters should be parsed properly
Proposed solution
When parameters are defined at the manifest level, reading of the previous installer manifest should remove them from the manifest level and add them to every installer at the installer level. This will allow for #29 to be more robust in the event any updates are made to installers which would make these parameters unable to be defined at the manifest level after update

Upon further review; This should also include a refactoring of the script to update the manifests in-place where applicable, instead of always creating new ones.
Logic Flow:
------------------------------
During read previous flow
------------------------------
If old singleton manifest exists
> Create new empty multi-manifest
> Copy existing fields from singleton into the appropriate multi-manifest file

If old multi-manifest exists
> Set new installer manifest equal to existing installer manifest
> Set new locale manifest equal to existing locale manifest
> Set new version manifest equal to old locale manifest

If no manifests exist
> Create new empty manifests

------------------------------
During data entry flow
------------------------------
For any new required entries
> Set the appropriate Manifest['Key'] value directly instead of using script variables

For any optional values
> If the value entered is null or empty, do not update the field
> If the value entered is not null and is valid, update the value in place

------------------------------
During file creation flow
------------------------------
Directly use the new manifests which were updated in-place
Re-Sort the keys to ensure accuracy


sbt-microsites 1.0 adaptation

We must adapt the github4s style to the new version of sbt-microsites

While we are at it, could we enforce https connections :pray: @juanpedromoreno
https://github.com/47deg/github4s/settings

Done @calvellido , thanks for pointing it out!


`Undefined symbols for architecture x86_64:

I got a progrem.
Undefined symbols for architecture x86_64:   "_JSClassCreate", referenced from:       facebook::jsc::JSCRuntime::createObject(std::__1::shared_ptr<facebook::jsi::HostObject>)::$_0::operator()() const in libReact.a(JSCRuntime.o)       facebook::jsc::JSCRuntime::createFunctionFromHostFunction(facebook::jsi::PropNameID const&, unsigned int, std::__1::function<facebook::jsi::Value (facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const*, unsigned long)>)::$_1::operator()() const in libReact.a(JSCRuntime.o)
someone help me.
"dependencies": { 		"eslint": "^5.16.0", 		"npm-watch": "^0.6.0", 		"react": "16.0.0", 		"react-native": "^0.59.4", 		"react-native-gesture-handler": "^1.1.0", 		"react-navigation": "^3.8.1" 	}, 	"devDependencies": { 		"babel-jest": "24.7.1", 		"babel-preset-react-native": "4.0.1", 		"jest": "24.7.1", 		"react-test-renderer": "16.0.0" 	}, 	"jest": { 		"preset": "react-native" 	}

Make sure JavaScriptCore.framework is added to "Link Binary With Libraries"
https://stackoverflow.com/questions/54515175/undefined-symbols-for-architecture-arm64-jsclasscreate


Update GAN to new requirements

could you please add this to the https://github.com/basetenlabs/truss-examples/blob/main/ci.yaml file?

will do. just got to figure out the correct input to test with.

@squidarth can you take another pass? I made some changes to the CI job to make this testable without making the config unreadable.


#11016 enhance working with table partitions and subpartitions for Oracle

Partitions folders are now not visible if the table does not have partitions
Partitions and subpartitions with the correct icon in the Navigator tree
Subpartitions now expandable
Partitions and subpartitions are now like tables - with a Data tab. And data can be read (special SELECT used)

Knowing issue: ERD tab is not working for partition, as in MySQL. And virtual tab also needs to be removed. You can create a separate ticket for it.

verified


FW-1235: Checkstyle Rules and Strict Enforcement

Strict enforcement happens in root level pom.xml

To merge after FW-1431. Expecting conflicts when that occurs. Transitioning PR to draft until that merge occurs.


Refactored some helper functions in getApprovals

Coverage remained the same at 92.815% when pulling 9c9bad9f15c465035c3e6e4e31a559ea8bd8026b on thongsav-usgs:master into d66a4937dfe1620f4fdd8732455851e505005632 on USGS-R:master.


TreeItem should support highlights

It would be nice if the tree view supports some kind of highlights in its label. This would be helpful when showing search-result-like things. Maybe something like this
export class TreeItem {

  label?: string;

  // start, end tuples
  labelHighlights?:[number,number][]
}

or something more elaborated that allows to reference a theme color or allows to express the highlighting style (background color or bold text etc)

@jrieken How about
export class TreeItem {

  label?: string || {label: string, highlights?:[number,number][]};

}

This will avoid providing highlights without giving label.

This is already done now!

This is already done now!


Outcomes and action points from migration workshop

April 11 - need to speak to Robin to move this fwd

Outcomes from workshop:

Research to provide short check-list to create behaviourally informed migration "getting started" / PRIMER docs

Outcomes from migration report:

Exploratory research to determine effective ways for SALT tooling  to support  with (DP) developer & designer delivery.

Marked this as done and created new issues for above items


navbar

The Index.html file and Style.css file were modified and the Script.js file was created.
Created navbar as microverse required in this project.
In mobile, implement the following features are added:
When the user clicks (or taps) the hamburger button, the mobile menu appears.
When the user clicks (or taps) the close (X) button, the mobile menu disappears.
When the user clicks (or taps) any of the mobile menu options, the mobile menu disappears.
When the user clicks (or taps) any of the mobile menu options, the correct part of the page is displayed.

Hi
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request
You have submitted a project, that has no contribution from your pair programming partner. Kindly collaborate with your partner on this project as requested on project requirements.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

My coding partner is not wanted to work as pair programming he is wanted to
work as solo, so what can I do now?
On Thu, Apr 13, 2023 at 12:05 AM Hüseyin Bıyık @.***>
wrote:

Hi
While you made a great effort in this project, unfortunately, I cannot
proceed to review your code.
[image: Alt Text]
https://camo.githubusercontent.com/999c41ff216bced575a5c7873c1c4ed04ef945c867ca87788003794670ee5aa7/68747470733a2f2f6d656469612e67697068792e636f6d2f6d656469612f785550476377453343556b586c766f6e75672f67697068792e676966
Invalid Code Review Request
You have submitted a project, that has no contribution from your pair
programming partner. Kindly collaborate with your partner on this project
as requested on project requirements.
[image: Screenshot 2023-04-12 at 10 03 53 PM]
https://user-images.githubusercontent.com/25887253/231559487-bbbc86b7-5b32-4751-8522-2c7e699424e9.png
Your Code Review Request will be marked as invalid in your Dashboard, so
please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear.
Please, remember to tag me in your question so I can receive the
notification.
Please, do not open a new Pull Request for re-reviews. You should use the
same Pull Request submitted for the first review, either valid or invalid
unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.
—
Reply to this email directly, view it on GitHub
https://github.com/asadmisrani/portfoliofinishmobileversion.github.io/pull/13#issuecomment-1505785221,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYQGAKAWIR64JRFOT3BZGV3XA34JPANCNFSM6AAAAAAW2C3QCM
.
You are receiving this because you authored the thread.Message ID:
<asadmisrani/portfoliofinishmobileversion.github.io/pull/13/c1505785221@
github.com>

My coding partner is not wanted to work as pair programming he is wanted to work as solo, so what can I do now?
…
On Thu, Apr 13, 2023 at 12:05 AM Hüseyin Bıyık @.***> wrote: Hi While you made a great effort in this project, unfortunately, I cannot proceed to review your code. [image: Alt Text] https://camo.githubusercontent.com/999c41ff216bced575a5c7873c1c4ed04ef945c867ca87788003794670ee5aa7/68747470733a2f2f6d656469612e67697068792e636f6d2f6d656469612f785550476377453343556b586c766f6e75672f67697068792e676966 Invalid Code Review Request You have submitted a project, that has no contribution from your pair programming partner. Kindly collaborate with your partner on this project as requested on project requirements. [image: Screenshot 2023-04-12 at 10 03 53 PM] https://user-images.githubusercontent.com/25887253/231559487-bbbc86b7-5b32-4751-8522-2c7e699424e9.png Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏 Cheers and Happy coding!👏👏👏 Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification. Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise. ------------------------------ Invalid Code Review Request does not count into the code reviews limit. — Reply to this email directly, view it on GitHub <#13 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYQGAKAWIR64JRFOT3BZGV3XA34JPANCNFSM6AAAAAAW2C3QCM . You are receiving this because you authored the thread.Message ID: <asadmisrani/portfoliofinishmobileversion.github.io/pull/13/c1505785221@ github.com>

Hi @asadmisrani,
Kindly report any issue you had with your partner to the student's success team and they'll permit you to work solo or look for a suitable partner.

Awesome, thanks!
On Thu, 13 Apr 2023, 01:26 joel kalema, @.***> wrote:

@.**** approved this pull request.
Hi Team
Your project is complete! There is nothing else to say other than... it's
time to merge it [image: :shipit:]
Congratulations! 🎉
https://camo.githubusercontent.com/d8de195a08af080c4ae2fd36bfcf741de68f66af2162d291a21e113ce1b490fc/68747470733a2f2f6d65646961342e67697068792e636f6d2f6d656469612f42504a6d74685133595277443651716356442f67697068792e676966
Highlights
Linters are passing 👍
The project is running successfully 👍
PR is well descriptive 👍
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this
PR. However, I strongly recommend you to take them into account as they can
make your code better. Some of them were simply missed by the previous
reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear.
Please, remember to tag me @.*** https://github.com/joel-kalema*
in your question so I can receive the notification.
As described in the Code reviews limits policy
https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a
limited number of reviews per project (check the exact number in your
Dashboard). If you think that the code review was not fair, you can request
a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
—
Reply to this email directly, view it on GitHub
https://github.com/asadmisrani/portfoliofinishmobileversion.github.io/pull/13#pullrequestreview-1382066114,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYQGAKBARS4KCOP3AQVZULTXA4FXDANCNFSM6AAAAAAW2C3QCM
.
You are receiving this because you were mentioned.Message ID:
<asadmisrani/portfoliofinishmobileversion.github.
@.***>


add custom sampling rates

Please have a look.

@0xSkly added changes. We are now sampling ourselves to have traces when errors occur. I don't assume it's going to be a performance issue.


add firebase-authentication example

that's an amazing example and the instructions are clearly written 💯 thanks @Gregor1971 and @jhalborg 🙏


fix(UI): change the button style in searchbar

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

Description of changes is edited at 9/20 since the height of navbar and searchbar was changed in another PR, therefore appearance of the search and reset button when the camper hovers over them in the latest code was also changed.
This PR was opened to change the background color, size, and the svg fill color of the search and reset button in the search bar when the camper hovers over them so that solving the issues described bellow.
Issues:

When the night mode is on, the contrast between the background color of the buttons when the camper hovers over them(--gray-05 #f5f6f7) and the fill color of Magnifier and InputReset svg image(--gray-15 #d0d0d5) is low(contrast ratio is 1.42:1) so the svg icon images might not be easily recognized by people with moderately low vision as shown in bellow image.

Image: Low contrast ratio between background color of the buttons and svg icon image

Again When the night mode is on, the background color of the buttons when the camper hovers over them(--gray-05 #f5f6f7) is quite light compared to the background color of universal nav bar(--theme-color #0a0a23), therefore it looks inflated and pops out a bit by contrast effect with the background or neighboring colors. (This may differ from person to person)

When the night mode is off, the contrast between the background color of the buttons when the camper hovers over them(--gray-85 #1b1b32) and the background color of universal nav bar(--theme-color #0a0a23) is low, so when the camper hovers over the reset button, it looks like the "X" reset button  image is popped out from the search form input as shown in bellow image.
[9/20 image deleted]

Solutions suggested in this PR(result is as shown in bellow image):

Change the background color of the buttons and the fill color of the SVG image so that the contrast when the camper hovers over them is high enough(contrast ratio is 5.98:1).

Resize the buttons to make them a bit smaller to avoid having they look like inflated and pops out a bit when the camper hovers over them, and also making them look more like a button.

Unify the background color of the button when night mode is on and off, to solve the issue when night mode is off. so the contrast ratio will be always constant.
[9/20 image deleted]

I've tested the code in Chrome, Firefox, Edge, and Brave on windows 11 PC locally, and also Chrome, Safari, Opera, and Brave on iPhone SE using the ngrok.
Test condition:

All elements in search bar are fully responsive.
From 80% to 400% in zoom, no collapsion or overlaping of elements are occured.

Thanks for your review, @naomi-lgbt.
And I apologize for suggesting a style for the buttons that doesn't fit with the aesthetic of any of the other buttons on fCC's platform. That was simply my overlooking, and as a result of researching various search bars when drafting this pull request. So I agree with you and would push the code without border-radius property after testing locally.

Thank you for your PR. I see a small space between the button and its container that did not exist previously. If that is adjusted, this pr should be good to go.

Thanks for your review, @ahmaxed.
The height of the buttons were adjusted to match the height of the search box.


Don't use v:null in core code

Fix #563.
OmniSharp.vim is code still runs on old versions of vim, so avoid using
v:null to maintain compatibility with vim 7.4.
v:null also appears in stdio.vim, but that feature requires more recent
vim, so it's fine.

Thanks!


add: surreal-sveltekit starter

SurrealDB + SvelteKit #35
This is a simple starter project with basic auth, crud and realtime.
https://github.com/oskar-gmerek/surreal-sveltekit

Hey @oskar-gmerek !
Your repo says Caddy is currently not in use, but I ran into this error with the Caddyfile during pnpm run
The rest of the repo looks good though. Can you kindly resolve the conflicts so I can merge this PR?

Hey @naisofly,
I have temporarily omitted all mentions and files related to Caddy Server. I will include them later if there is a need. Additionally, I have resolved the conflicts. Thank you.

Well done @oskar-gmerek!
Thank you for contributing to SurrealDB during Hacktoberfest 2023 🎉
Kindly send an email to<EMAIL_ADDRESS>to coordinate the delivery of your SurrealDB swag! 😁


No issue.. Just a "Thank you" for a wonderful script!

*<[:-)

Hi @fmbahrt!
Thank you a million! I really appreciate your time just to say it. As I manage more than 10 clusters, I scheduled this script to run in the basic form on all every day just to make sure they all are working as expected, without stuck or orphan resources, sending the report by email with the results. The time to run the script is also observed, if it increase a lot from one day to another, maybe it is a sing that the apiservers and/or the etcd servers are running over pressure.
Again, thank you.

Until i found this script I was lying with my head on the keyboard reconsidering my choice of career. Your script saved my day. Thanks!

Hello, @markbaumgarten! Thank you very much, I'm very happy to see that the script is helping other people. I did it exactly for that reason: it was disheartening to have to repeat all the commands on all the features of the k8s just to see why some feature stuck. It was then that the idea to automate these steps in this script was born. I am currently studying Go to create a version of this tool that will run on any operating system.


Chapter3/homework/2

Finished homework for chapter3/lesson2
Sooo.. this was quite a bit of headache 😅
I kinda couldn't wrap my head around it, so I started with tests and just tried to write code that would make them pass one by one.
In the end all tests pass, but I'm not sure if it's written well or not :v
The biggest problem I had was with comparing two credentials: is overriding Equals method [to compare (by value) properties of objects, instead of comparing 2 objects by reference] a bad practice?

Overriding equals is a good practice


Add something about Tencent Cloud

Added Tencent Cloud Production Environment Solution

/assign @jaredbhatti

@jaredbhatti
May I know when the PR can be reviewed?

@sftim Thank you very much for your suggestions on the document. I have already revised it according to your suggestions. Please help advance this PR review.

I believe the text needs some improvement from native speakers. For example, the following sentence reads pretty strange to me:

For learn more about TKE in its official TKE documentation.

This page should be Hugo markdown, with front matter similar to https://github.com/kubernetes/website/blame/5f27e08983d12a183ea99b599b9b09eeaa341bb3/content/en/docs/setup/production-environment/turnkey/aws.md#L1-L7
Does that make sense?

@sftim Thank you for reminding me. I can't say what the meaning is, but I think it's necessary. Just a little uncertain is that I don’t know if the reviewers added the right ones.  What do you think?

@sftim  Can you help merge this PR?

I'm also not sure about what to put for the reviewers on this page I'm afraid.
Maybe ask for advice via SIG Docs' Slack channel?
Apart from the detail about reviewers, the PR looks good to me.

The answer I got for this question is：

This page should be Hugo markdown, with front matter similar to https://github.com/kubernetes/website/blame/5f27e08983d12a183ea99b599b9b09eeaa341bb3/content/en/docs/setup/production-environment/turnkey/aws.md#L1-L7
Does that make sense?

@sftim
The answer I got for this question is：The tags are for Hugo to organize contents and for related Bots to trigger notifications etc.
Can I keep this content and request a merge?

/lgtm
At this point @yunxxji you're waiting on approval from this PR's assignee, who I think is @jaredbhatti

Request the  /approve  tag.  @jaredbhatti

Hi, @sftim
You are also one of the assignees for this PR. Maybe you can also leave a /approve tag here.

/assign @tengqm

pinging @tengqm  for approval

pinging @jaredbhatti  for approval

/approve


Replace Failed Node does not re-inteview the new device

Checklist:

[x] I am not using HomeAssistant. Or: a developer has told me to come here.
[x] I am not using ZWaveJS2MQTT. Or: a developer has told me to come here.
[x] I have checked the troubleshooting section and my problem is not described there.
[x] I have read the changelog and my problem was not mentioned there.

Describe the bug
When using "Replace Failed Node" in the control panel to replace a failed node with a different device (i.e., GE switch with an Inovelli switch), the new device is not interviewed upon inclusion.  As a result, it still appears as the old device in the node list and thus has incorrect paramters/config/etc. until a manual re-interview is performed.
Device information
I did two replacements of GE/Jasco 45609 on/off switches with Innovelli LZW31 dimmers.  I saw the same behavior both times.
Did you change anything?

[ ] Yes: (please describe)
[x] No

Did this use to work before?

[x] Don't know, this is a new device
[ ] No, it never worked anywhere
[ ] Yes, in: (specify application with versions)

How are you using node-zwave-js

[ ] zwavejs2mqtt (latest) docker image
[ ] zwavejs2mqtt (dev) docker image
[ ] zwavejs2mqtt Manual Docker build

node-zwave-js branch:
zwavejs2mqtt branch:

[ ] ioBroker.zwave2 adapter
[ ] HomeAssistant version XYZ
[ ] Pkg
[ ] Manual Docker build

node-zwave-js branch:
zwavejs2mqtt branch:

[ ] node-red-contrib-zwave-js

Module version (double click node):

[ ] Manually built (as described in the docs)
[ x] Other: I am using the latest HA add-on, but I am interacting with zwave-js through the control panel, not HA.
To Reproduce

Steps to reproduce the behavior:

Have a node that's dead that you want to replace with a different device
open the dead node from the node list
click advanced
Under Failed Nodes, click Replace, answer "no" to secure inclusion.
Include the new node
Additional context

Add any other context about the problem here.
Logfile: N/A

Can you tell us what version of zwave-js is being used by the addon?

Can you tell us what version of zwave-js is being used by the addon?
version 6.6.3.  I know 7.0.x is out, but they haven't updated the add-on yet.

I'll try to catch a log on my next switch update - hopefully tonight or tomorrow

Here's the log - looks like it DOES interview:
16:28:43.186 CNTRLR » [Node 009] pinging the node...
16:28:47.316 CNTRLR   [Node 009] Node 9 did not respond after 1 attempts, it is presumed dead
16:28:47.317 CNTRLR   [Node 009] ping failed: Failed to send the command after 1 attempts (Status No
16:29:08.712 CNTRLR » [Node 009] Assigning return route to controller...
16:29:09.637 CNTRLR   [Node 009] Beginning interview - last completed stage: None
16:29:09.637 CNTRLR   [Node 009] new node, doing a full interview...
16:29:09.637 CNTRLR » [Node 009] querying protocol info...
16:29:09.654 CNTRLR « [Node 009] received response for protocol info:
16:29:09.681 CNTRLR   [Node 009] Interview stage completed: ProtocolInfo
16:29:09.681 CNTRLR » [Node 009] pinging the node...
16:29:09.732 CNTRLR « [Node 009] ping successful
16:29:09.733 CNTRLR » [Node 009] querying node info...
16:29:09.890 CNTRLR « [Node 009] node info received
16:29:09.917 CNTRLR   [Node 009] Interview stage completed: NodeInfo
16:29:09.918 CNTRLR » [Node 009] querying securely supported commands...
16:29:20.251 CNTRLR   [Node 009] Timed out while waiting for a response from the node
16:29:20.252 CNTRLR   [Node 009] The node is not included securely. Continuing interview non-securel
16:29:20.348 CNTRLR   [Node 009] ManufacturerSpecificCC: doing a complete interview...
16:29:20.349 CNTRLR » [Node 009] querying manufacturer information...
16:29:20.523 CNTRLR « [Node 009] received response for manufacturer information:
16:29:20.552 CNTRLR   [Node 009] VersionCC: doing a complete interview...
16:29:20.552 CNTRLR » [Node 009] querying node versions...
16:29:20.709 CNTRLR « [Node 009] received response for node versions:
16:29:20.709 CNTRLR » [Node 009] querying CC versions...
16:29:20.709 CNTRLR » [Node 009]   querying the CC version for Multilevel Switch...
16:29:20.890 CNTRLR   [Node 009]   supports CC Multilevel Switch (0x26) in version 2
16:29:20.891 CNTRLR   [Node 009]   skipping query for All Switch (0x27) because max implemented vers
16:29:20.891 CNTRLR » [Node 009]   querying the CC version for Z-Wave Plus Info...
16:29:21.080 CNTRLR   [Node 009]   supports CC Z-Wave Plus Info (0x5e) in version 2
16:29:21.080 CNTRLR » [Node 009]   querying the CC version for Configuration...
16:29:21.270 CNTRLR   [Node 009]   supports CC Configuration (0x70) in version 1
16:29:21.270 CNTRLR » [Node 009]   querying the CC version for Association...
16:29:21.460 CNTRLR   [Node 009]   supports CC Association (0x85) in version 2
16:29:21.460 CNTRLR » [Node 009]   querying the CC version for Association Group Information...
16:29:21.650 CNTRLR   [Node 009]   supports CC Association Group Information (0x59) in version 1
16:29:21.650 CNTRLR   [Node 009]   skipping query for Transport Service (0x55) because max implement
16:29:21.651 CNTRLR » [Node 009]   querying the CC version for Version...
16:29:21.840 CNTRLR   [Node 009]   supports CC Version (0x86) in version 2
16:29:21.840 CNTRLR » [Node 009]   querying the CC version for Manufacturer Specific...
16:29:22.089 CNTRLR   [Node 009]   supports CC Manufacturer Specific (0x72) in version 2
16:29:22.090 CNTRLR   [Node 009]   skipping query for Device Reset Locally (0x5a) because max implem
16:29:22.090 CNTRLR   [Node 009]   skipping query for Powerlevel (0x73) because max implemented vers
16:29:22.090 CNTRLR   [Node 009]   skipping query for Security (0x98) because max implemented versio
16:29:22.090 CNTRLR   [Node 009]   skipping query for Security 2 (0x9f) because max implemented vers
16:29:22.090 CNTRLR   [Node 009]   skipping query for Supervision (0x6c) because max implemented ver
16:29:22.090 CNTRLR » [Node 009]   querying the CC version for Protection...
16:29:22.379 CNTRLR   [Node 009]   supports CC Protection (0x75) in version 2
16:29:22.380 CNTRLR   [Node 009]   skipping query for Application Status (0x22) because max implemen
16:29:22.380 CNTRLR » [Node 009]   querying the CC version for Firmware Update Meta Data...
16:29:22.657 CNTRLR   [Node 009]   supports CC Firmware Update Meta Data (0x7a) in version 4
16:29:22.657 CNTRLR   [Node 009] trying to load device config
16:29:22.677 CNTRLR   [Node 009] device config loaded
16:29:22.697 CNTRLR   [Node 009] ZWavePlusCC: doing a complete interview...
16:29:22.697 CNTRLR » [Node 009] querying Z-Wave+ information...
16:29:22.842 CNTRLR « [Node 009] received response for Z-Wave+ information:
16:29:22.844 CNTRLR   [Node 009] MultilevelSwitchCC: doing a complete interview...
16:29:22.848 CNTRLR » [Node 009] requesting current switch state...
16:29:23.089 CNTRLR   [Node 009] ConfigurationCC: Loading configuration parameters from device confi
16:29:23.108 CNTRLR » [Node 009] querying parameter #1 value...
16:29:23.335 CNTRLR « [Node 009] parameter #1 has value: 3
16:29:23.336 CNTRLR » [Node 009] querying parameter #2 value...
16:29:23.549 CNTRLR « [Node 009] parameter #2 has value: 101
16:29:23.549 CNTRLR » [Node 009] querying parameter #3 value...
16:29:23.734 CNTRLR « [Node 009] parameter #3 has value: 101
16:29:23.735 CNTRLR » [Node 009] querying parameter #4 value...
16:29:23.924 CNTRLR « [Node 009] parameter #4 has value: 101
16:29:23.924 CNTRLR » [Node 009] querying parameter #5 value...
16:29:24.112 CNTRLR « [Node 009] parameter #5 has value: 10
16:29:24.112 CNTRLR » [Node 009] querying parameter #6 value...
16:29:24.303 CNTRLR « [Node 009] parameter #6 has value: 99
16:29:24.303 CNTRLR » [Node 009] querying parameter #7 value...
16:29:24.493 CNTRLR « [Node 009] parameter #7 has value: 0
16:29:24.493 CNTRLR » [Node 009] querying parameter #8 value...
16:29:24.682 CNTRLR « [Node 009] parameter #8 has value: 0
16:29:24.682 CNTRLR » [Node 009] querying parameter #9 value...
16:29:24.893 CNTRLR « [Node 009] parameter #9 has value: 0
16:29:24.894 CNTRLR » [Node 009] querying parameter #10 value...
16:29:25.193 CNTRLR « [Node 009] parameter #10 has value: 0
16:29:25.193 CNTRLR » [Node 009] querying parameter #11 value...
16:29:25.383 CNTRLR « [Node 009] parameter #11 has value: 100
16:29:25.383 CNTRLR » [Node 009] querying parameter #13 value...
16:29:25.572 CNTRLR « [Node 009] parameter #13 has value: 170
16:29:25.573 CNTRLR » [Node 009] querying parameter #14 value...
16:29:27.028 CNTRLR « [Node 009] parameter #14 has value: 5
16:29:27.029 CNTRLR » [Node 009] querying parameter #15 value...
16:29:37.775 CNTRLR   [Node 009] Timed out while waiting for a response from the node
16:29:37.775 CNTRLR « [Node 009] received no value for parameter #15
16:29:37.775 CNTRLR » [Node 009] querying parameter #17 value...
16:29:38.601 CNTRLR « [Node 009] parameter #17 has value: 3
16:29:38.601 CNTRLR » [Node 009] querying parameter #21 value...
16:29:41.877 CNTRLR « [Node 009] parameter #21 has value: 0
16:29:41.877 CNTRLR » [Node 009] querying parameter #22 value...
16:29:42.274 CNTRLR « [Node 009] parameter #22 has value: 0
16:29:42.275 CNTRLR » [Node 009] querying parameter #51 value...
16:29:42.551 CNTRLR « [Node 009] parameter #51 has value: 1
16:29:42.552 CNTRLR » [Node 009] querying parameter #52 value...
16:29:54.119 CNTRLR   [Node 009] Timed out while waiting for a response from the node
16:29:54.119 CNTRLR « [Node 009] received no value for parameter #52
16:29:54.119 CNTRLR » [Node 009] querying parameter #12 value...
16:29:54.697 CNTRLR « [Node 009] parameter #12 has value: 15
16:29:54.721 CNTRLR   [Node 009] ProtectionCC: doing a complete interview...
16:29:54.722 CNTRLR » [Node 009] querying protection capabilities...
16:29:54.968 CNTRLR « [Node 009] received protection capabilities:
16:29:54.968 CNTRLR » [Node 009] querying protection status...
16:29:55.414 CNTRLR « [Node 009] received protection status:
16:29:55.436 CNTRLR   [Node 009] AssociationCC: doing a complete interview...
16:29:55.437 CNTRLR » [Node 009] querying number of association groups...
16:29:57.448 CNTRLR « [Node 009] supports 4 association groups
16:29:57.448 CNTRLR » [Node 009] querying association group #1...
16:29:57.676 CNTRLR « [Node 009] received information for association group #1:
16:29:57.676 CNTRLR » [Node 009] querying association group #2...
16:29:57.897 CNTRLR « [Node 009] received information for association group #2:
16:29:57.897 CNTRLR » [Node 009] querying association group #3...
16:29:58.206 CNTRLR « [Node 009] received information for association group #3:
16:29:58.206 CNTRLR » [Node 009] querying association group #4...
16:29:58.497 CNTRLR « [Node 009] received information for association group #4:
16:29:58.498 CNTRLR » [Node 009] Controller missing from lifeline group #1, assigning ourselves...
16:29:58.938 CNTRLR   [Node 009] AssociationGroupInfoCC: doing a complete interview...
16:29:58.938 CNTRLR » [Node 009] Association group #1: Querying name...
16:29:59.130 CNTRLR « [Node 009] Association group #1 has name "Lifeline"
16:29:59.130 CNTRLR » [Node 009] Association group #1: Querying info...
16:29:59.421 CNTRLR « [Node 009] Received info for association group #1:
16:29:59.421 CNTRLR » [Node 009] Association group #1: Querying command list...
16:29:59.732 CNTRLR » [Node 009] Association group #2: Querying name...
16:30:00.036 CNTRLR « [Node 009] Association group #2 has name "On/Off Control"
16:30:00.036 CNTRLR » [Node 009] Association group #2: Querying info...
16:30:00.258 CNTRLR « [Node 009] Received info for association group #2:
16:30:00.258 CNTRLR » [Node 009] Association group #2: Querying command list...
16:30:00.546 CNTRLR » [Node 009] Association group #3: Querying name...
16:30:00.780 CNTRLR « [Node 009] Association group #3 has name "Switch Multilevel Set"
16:30:00.780 CNTRLR » [Node 009] Association group #3: Querying info...
16:30:01.045 CNTRLR « [Node 009] Received info for association group #3:
16:30:01.045 CNTRLR » [Node 009] Association group #3: Querying command list...
16:30:01.659 CNTRLR » [Node 009] Association group #4: Querying name...
16:30:01.850 CNTRLR « [Node 009] Association group #4 has name "Sw Multi Start/Stop"
16:30:01.850 CNTRLR » [Node 009] Association group #4: Querying info...
16:30:02.097 CNTRLR « [Node 009] Received info for association group #4:
16:30:02.097 CNTRLR » [Node 009] Association group #4: Querying command list...
16:30:02.307 CNTRLR   [Node 009] Interview stage completed: CommandClasses
16:30:02.307 CNTRLR   [Node 009] Interview stage completed: OverwriteConfig
16:30:02.307 CNTRLR » [Node 009] requesting node neighbors...
16:30:02.317 CNTRLR « [Node 009]   node neighbors received: 2, 4, 20, 34, 35, 43, 53, 67, 73
16:30:02.317 CNTRLR   [Node 009] Interview stage completed: Neighbors
16:30:02.317 CNTRLR   [Node 009] Interview completed
16:30:02.317 CNTRLR   [Node 009] The node is ready to be used

It must be some display issue where the CP does not update.  In this case, I had left the CP for a while (5-10 min) and came back in, then it had populated.  I know the first two I replace there was no amount of refresh/reload of the browser that would show me the new info or config params.

@robertsLando Thoughts?

The data are sent as soon as I receive them from Zwavejs so excluded any kind of network delays this could just be something on zwavejs side, maybe the interview takes a lot before reaching the ready status, this can be normal with some devices

Can you share the full logfile? I wonder why we try to ping the device first.

Attached: zwavejs_355 2.log
The one with debug on starts at line 45061, where I replace Node 009.

Ok, the 2nd ping is purely "cosmetical" - shouldn't hurt. I was confused by the 1st one but that is done to ensure the node is really failed.

@robertsLando The interview takes about a minute here but looks pretty normal.


Binary Classification Confusion Matrix and AUC Aggregators

Some of this works is derived from similar functions in the Spark library. For Binary Classifications tasks it will compute a confusion matrix.  You can also aggregator over these confusions matrices with different thresholds to compute an Area under the Curve Stat for both PR and ROC.

Codecov Report

Merging #633 into develop will increase coverage by 0.1%.
The diff coverage is 90.56%.

@@            Coverage Diff            @@
##           develop    #633     +/-   ##
=========================================
+ Coverage       82%   82.1%   +0.1%
=========================================
  Files          111     113      +2
  Lines         5156    5209     +53
  Branches       457     465      +8
=========================================
+ Hits          4228    4277     +49
- Misses         928     932      +4

Impacted Files
Coverage Δ

...algebird/BinaryClassificationConfusionMatrix.scala
88.88% <88.88%> (ø)

...com/twitter/algebird/BinaryClassificationAUC.scala
92.3% <92.3%> (ø)

...in/scala/com/twitter/algebird/scalacheck/Gen.scala
91.66% <0%> (-8.34%)
:arrow_down:

...re/src/main/scala/com/twitter/algebird/QTree.scala
78.97% <0%> (-1.14%)
:arrow_down:

...c/main/scala/com/twitter/algebird/MapAlgebra.scala
76.69% <0%> (-0.98%)
:arrow_down:

.../main/scala/com/twitter/algebird/BloomFilter.scala
94.32% <0%> (-0.44%)
:arrow_down:

...src/main/scala/com/twitter/algebird/Interval.scala
63.09% <0%> (+3.57%)
:arrow_up:

.../main/scala/com/twitter/algebird/Successible.scala
95.83% <0%> (+8.33%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa98422...a55489c. Read the comment docs.

Hey @richwhitjr, thank you for this! We should have some time to look today.

@richwhitjr this is getting there - I think it's looking good.
One ask that we have for all new data structures is that you add a section with a few examples to the documentation site.
here are the instructions on how to do this: https://github.com/twitter/algebird/blob/develop/CONTRIBUTING.md#contributing-documentation
All data structure examples are compiled by CI, so it's extremely helpful to get a mini tutorial in at the same time the data structure is merged.
here are a few examples of existing pages:

https://twitter.github.io/algebird/datatypes/approx/exponential_histogram.html
https://twitter.github.io/algebird/datatypes/averaged_value.html

I looked at adding sumOption but couldn't think of a way to make it more efficient without a lot of complexity and not sure if it is entirely worth it.  It would help with object creation but on the other side we would have to aggregate the confusion matrix variables outside into some type of dictionary and reconstruct it at the end.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Richard Whitcomb seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Metrics for binary classification

Why the Talos examples of binary classification with imbalanced dataset like breast cancer uses accuracy for the hyperparameter optimization?

The end result is virtually 100%, while the dataset has a notable number of positives. At that point it does not matter. To avoid doubt, in a future example we would not want to use accuracy.
Closing here, as it's really not an issue. Feel free to open a new ticket if anything.


Emit Binary conversion error while using std::make_sharedstd::string( Foo )

This is almost verbatim from the README.
char buf[100];
current_socket->emit ( "bintest", std::make_sharedstd::string(&buf, 100) );
I get: Error	1	error C2664: 'void sio::socket::emit(const std::string &,const sio::message::list &,const std::function<void (const sio::message::ptr &)> &)' : cannot convert argument 2 from 'std::shared_ptrstd::string' to 'const sio::message::list &'	C:\Libraries\socket.io-client-cpp\examples\Console\main.cpp	90

I noticed in sio_socket.h that void emit has two default parameters. I don't think this is wise. If I specify a second parameter, who is to say which parameter I've specified? The second or third?
A second look at the error message above told me it was looking for the second parameter when I was trying to give it the third. I set the second parameter to nullptr and the third to the make_shared and the error went away. However, now I'm getting:
cannot convert argument 1 from 'char (*)[100]' to 'const std::basic_string<char,std::char_traits,std::allocator> &'
Still tinkering.

char buf[100];
current_socket->emit ( "bintest",   std::make_shared<const std::string>(&buf, 100));

I guess maybe in some compiler, the conversion constructor for share_ptr can not work for shared_ptr .

Reason for Two default values is I was trying to keep the backward compatibility: the unified emit function should be able to called with all following forms:
emit(event);
emit(event,string);
emit(event,binary);
emit(event,message);
emit(event,string,ack);
emit(event,binary,ack);
emit(event,message,ack);

And for default values, your second argument will always replace the second default value, won't be the third one.

I'm using Visual Studio 2013 (v120). Do you have any recommendations for a workaround?

PS: Making it const did not work. Tried that as well.

Did you tried my code in the 3rd post.

I'll test and fix it later today.

I have tested with clang, compile succeed if I put the const qualifier just in my first post.
But if your problem remains, can you try the tls branch to see if that fix your problem (I did some optimize).
4f2e5d7b03837c5b88b0d09baeed6d5dc8c82203

That's so weird, the tls branch still doesn't work. If it helps, here's my source: http://pastebin.com/GtLYu6vZ I basically took the Console demo, stripped it down, and tried binary emits.
Not sure if you have Visual Studio 2013 installed, but if you'd like I can zip up my project for you. Maybe there's something in the project settings?

Do not need to send me project. I'll test it in vs 2013 myself tomorrow.

This works:
[code]
current_socket->emit ( "bintest", std::make_sharedstd::string ( "teststring" ) );
[/code]
Apparently, passing a char array by reference and including the size doesn't work. Good enough for my purposes, but the README should be updated.

This is not the proper way to send a binary.
If you're making std::string with a binary, you HAVE TO pass the size, otherwise your binary will be cut from the middle.

Hi,there.
I have tested in my VS 2013 community at Win8.1.
the code:
char buf[100];
current_socket->emit ( "bintest",   std::make_shared<const std::string>(&buf, 100));

works fine on master branch.
and your original code without const qualifier:
char buf[100];
current_socket->emit ( "bintest",   std::make_shared<std::string>(&buf, 100));

Not works on master branch but works on tis branch.
Could you please clean your project and try the first code block at the top again?

Just saw your message on the proper way to send a string. I haven't seen the side effects of that yet, but I'll take your word for it. Is it possible to send a integer via binary? I haven't been able to figure that one out yet. Didn't want to make a new issue, lol.

Hi, if you're making std::string with code:
std::string binary( "teststring" )

You are actually making a common string with c string,which is actually an array of chars ending with 0 in memory:
['t','e','s','t','s','t','r','i','n','g',0]

The std::string constructor will cut the string when it meets 0, so you get your "teststring" in std::string
But if you want to create real binary data without pass size like:
//real binary will be made up with values between 0-255 in any position.
//this is just a example
char buf = {'a','b','c',0,'d','e','f'};
std::string binary(buf)

the std::string constructor also cut the string when it meets 0, you're end up with "abc" in this case,  to create std::string with content "abc\0def" ,you have to pass the size 7.

About sending integers, suppose you need to send 0-9 in a buffer,just:
char buf[] = {0,1,2,3,4,5,6,7,8,9};
current_socket->emit ( "bintest",   std::make_shared<const std::string>(buf, 10));


Support LIB directive

Flex Assembler has a 'LIB' directive which is essentially an include directive (doc - page 37) which isn't currently supported - but it would be nice if it was!
Thanks,
Matt

I've looked into this a bit more. The way LIB is described seems fraught with potential issues -- certainly would be in this current codebase. The definition seems insufficient. Maybe there's more documentation somewhere that would temper my concerns.
One concern I have is about the position of LIB code in the resulting binary's address space. If there are one or more ORG directives in the file referenced by LIB then how should that impact the result? Should any overlapping segments that result from one or more LIBs be flagged as an assembler error, or a warning or just ignored? If the latter, then which segments "win" and get top billing in the resulting binary? And how should the source that follows the LIB be placed in memory? And does that change if the LIB is not a single, contiguous binary object (e.g., it has two or more ORGs -- and assuming we wouldn't want to just assume all the empty space between them is used by the LIB).
If LIB were defined as requiring the referenced file to contain position independent code (namely: no ORG directives; the code would assemble into one, position independent, contiguous binary object), then I think things would be less problematic, but maybe it would be less useful?
Also, the doc doesn't explain how (or if) labels in the LIB are carried through to the containing source or how that might change (or not) with nested LIBs (e.g., Root->LIB1->LIB2; Can you see LIB2 labels from Root?) I assume labels must be exposed or else referencing code in the LIB would be pretty awkward, but this wasn't explained in the doc. I'm envisioning a LIB file as being something like "my_tcpip_lib.asm" with several entry points that you want to reference.
As an alternative to LIB, adding some form of "include" functionality (probably would look more like the .copy directive described in this TI assembler doc) would provide similar functionality while also being fairly straightforward to define and implement. And it would automatically benefit from all the existing error checking.
Would "include" cover the cases you care about?
This is all reminding me of the broader topic of linking. There are some big assembly language projects composed of dozens of files. Building those requires a linker with well defined semantics around things like code portability and symbol visibility. I should add "build a linker" to my todo list.

Hi,
Thanks for looking into this.
Yeah, I think 'include' would cover the things I care about.
Thanks,
Matt

I added an .include directive (e.g. "   .include sub_dir/my_lib.asm") in this commit. I also added a couple of tests for it, but my coverage is pretty light. Please let me know if you encounter any issues. I haven't added any documentation for it yet. The new test files provide simple examples. I'll keep this issue open until the feature is documented and any known problems are resolved.

Cool. Thanks! I'll give it a try.


iot2050-image-example: add armhf compat libraries

As could not compile the 32bit application on the native machine.
it should use cross-compile method.


Update azure sdk to a newer (yet still deprecated) API Version

When trying to perform the update/creation of a shared RP environment, a user will get an error from the Azure API stating that the mimimum supported API version is 2020-01-01. The current version of the containerregistry and networking clients were below that and required updating.

[!NOTE]
The PR is broken up commit-wise so that you can ignore commits that add vendoring, and focus on commits that change actual files we care about.

Closing out in favour of an upgrade to track 2 already in progress by @atokobi and I will be working on the containerruntime client.


Upgrade to latest aspect and compiler

233 tests pass.
Let's see how things work on CI...

Note, changed the base branch to main, deleted master.


Update akka-actor, akka-slf4j, akka-stream, ... to 2.6.17

Updates

com.typesafe.akka:akka-actor
com.typesafe.akka:akka-slf4j
com.typesafe.akka:akka-stream
com.typesafe.akka:akka-testkit

from 2.6.4 to 2.6.17.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.typesafe.akka" } ]

labels: library-update, semver-patch

Superseded by #139.


Active_admin support

We're using active_admin to monitor the activity of certain features of our site, and would love to view the usage of the messaging features on our site.  Does anyone have suggestions for integrating mailboxer with active_admin as there is no Message model.

@ACPK Did you ever figure out how to do this?


Fix Bug: Need a limit on the -j parellisation

An unbounded -j can cause all kind of errors and will fail to compile on Dockerhub.
$(nproc) limits parallelisation to the number of cores on the machine, and this has been tested on Dockerhub.
https://hub.docker.com/r/markmandel/grpc-docker-library/builds/

@mehrdada PR to fix the bug for you - you were 100% correct :blush:

Build successful! - https://hub.docker.com/r/grpc/cxx/builds/bk7g8cjekdrs3qp8w4urpjf/


Weight entitlement shows base weight: MB-1230

Description
Currently, the homepage shows base_weight + pro_gear weight. Change this to show base_weight only.
Setup
make server_run
make client_run
create move using steps found in this jira ticket(use the progear flag):  (https://dp3.atlassian.net/browse/MB-1231)
On home page, you should see only the base weight not total weight.
(if you want, you can add a log stmt on /src/scenes/Landing/MoveSummary.jsx after line 13 to output the entitlement values: console.dir(entitlement) to verify the correct entitlement value is shown.
Code Review Verification Steps

[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

didn't branch off master, blah. closing and opening: https://github.com/transcom/mymove/pull/3510