inline and openOnDefaultDate / defaultDate option?

I faced a problem with inline datepicker and no value/date by default.
I use that code now:
                      <DatePicker
                        inline
                        format='dddd MMMM Do'
                        minDate={moment()}
                        maxDate={moment().add(1, 'years')}
                        selected={this.props.task.dueDate ? moment.unix(this.props.task.dueDate) : moment()}
                        onChange={() => {}}
                        onSelect={date => this.handleChangeTaskDueDate(date)}
                      />

I need to display the today date when the picker is opened if no value yet. Since there is no defaultDate option, I use this kinda hack on selected={this.props.task.dueDate ? moment.unix(this.props.task.dueDate) : moment()}.
The problem is that it is impossible then to choose today since it is already selected, and not triggering a onChange event. I use onSelect to bypass that, and use noop for onChange.
Would it be possible then to have a openOnDefaultDate or so if no date is selected/empty value?
Or did I miss something?

selected is an optional prop. Just pass null to indicate no date is selected, then when today is selected that will be a change.

@aij thanks for your answer, I tried it, but the calendar would be opened in jan 1970, despite my minDate and maxDate...

@guillaumepotier That sounds like a bug then. It should be setting the default pre-selection to the current day, respecting minDate and maxDate.
Just checking, you're not somehow accidentally passing selected={moment.unix(0)} are you?
Anyway, PRs welcome if you want to take a stab at fixing it. I'm guessing somehow preSelection is not being initialized correctly in inline mode.

Just checking, you're not somehow accidentally passing selected={moment.unix(0)} are you?
Nope, I test and if no value I give moment()

I'll update my issue title then, and would try to have a look for hopefully make a PR, but right now my workaround works fine I'll go a bit deeper in my project for now on :)
Best


Document nexus-prisma-generate

Is there a way to generate javascript files instead of typescript?
Maybe adding something to the generate command.
npx nexus-prisma-generate --client ./src/generated/prisma-client --output ./src/generated/nexus-prisma

I get the below error when trying to use with a javascript project. I think the problem is that the generated/nexus.ts and generated/schema.graphql files are not getting generated.
Expected path for outputs.typegen to be a string, saw src/generated/nexus.ts

Hey there,
nexus-prisma-generate does have an option to generate javascript file, just add --js in your command such as:
npx nexus-prisma-generate --client ./src/generated/prisma-client --output ./src/generated/nexus-prisma --js
That's something we should better document though, so I'll keep this issue opened til we document that.
For the record, here's the help of the nexus-prisma-generate CLI
  nexus-prisma-generate prisma-client-dir output

  > Generate the TypeScript types for nexus-prisma

  -----

  Inputs should be relative to the root of your project

  --client (required): Path to your prisma-client directory (eg: ./generated/prisma-client/)
  --output (required): Path to directory where you want to output the typings (eg: ./generated/nexus-prisma)
  --js     (optional): Whether to generate the types for Javascript

Hey, thanks for the help. It would very kind if you can have a javascript example along with the typescript example.

Hi, I with Relay as front-end framework, that mean I need connectionType for pagination and I found that Prisma2(I just try it in the past few days, I really like it) may not compatible with nexus-prisma-generate, right? so, I need implement it by myself? (I just wonder if it has been implemented  and not document yet maybe)


Hiding geometry through showOnly make it permenantly hidden

Reported by Beta testers

Jess had an issue at the UEFS where showOnly on a group of muscles works the first time, but clicking showOnly on a second group of muscles does not hide the first group of muscles for which she selected showOnly.

I should make this clear. ShowOnly is defined as hide all siblings, no intended interaction between different groups. If intention is showOnly in model then it should be done on the "all" group rather than in a specific group.

Pick 2 disjoint groups and do show only and all works perfectly fine for each one and when picked together (color each group with a different color so you can easily tell). I believe this is not a bug, an enhancement at best if a better alternative definition of showOnly is proposed. I can't reproduce the described behavior/bug generically.

@chrisdembia Do you know if this was something that came up when testing a specific example or tutorial?

It was likely in the process of doing tutorial 3, but I don't know for sure.

Test in a model with groups.

Show/Hide behavior works as I would expect for groups of muscles. For disjoint muscles, it toggles between showing the groups correctly. If I am toggling between two groups and there is overlap, the muscle in the join of the two groups is still displayed (e.g., gastroc displays when toggling between display only for the plantarflexors and knee flexors)

Can confirm Jen's findings above.


Did some work

It would be nice if #103 would be fixed before merging. The travis builds take 2x25 minutes now. However, splitting the CI pipeline into multiple steps should be continued, including adding more "offline support" (ie. static code analysis independent of codacy, preferrable with codacy like behaviour). See #104

Build is down to 8 minutes, seems fine to merge now.


/notes doesn't give any title

Have you experienced this bug with the latest version of the app?
Yes.
Steps to Reproduce
Opening https://3000-idx-xxxx.cluster-xxxxxxxxxxxxxxxxxxxx.cloudworkstations.dev/notes.
Expected Behavior
Having "Notes" or similar as title.
Actual Behavior
Empty title.

Fixed in dd000c0 with metafunction.


Finalize DECIDE

Combine all the components from the specification into the final DECIDE function, launching the missile

Pull request #88 solves this.


migrate to labels for search fields

We were previously manually querying for elements and controlling their focus state.
instead we'll use label elements and let that element handle it as intended.
some ids are changed in this PR to try and ensure no conflicts if there are more than 1 search on the same page. we'll need to be more exhaustive about this in the future. maybe a lint rule could catch this.

Converting to a draft due to duplicate ids.
@flo - just mark it as ready when this is resolved


Init blank controller

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/lgtm


feature / report invalid methodnames

TR0005: InvalidMemberName
Cause
The processed Resx-file contains a key that, when being reduce, ends up being non-compilable
Rule description
During code generation, resource-keys are sanitized to remove obviously incompatible characters. However, there are certain scenarios where this does not suffice, f.e. when the reduced name solely consists of reserved keywords or similar.
When such an incompatible name is detected, TypealizR tries to resolve to a compilable name and generates this warning.
How to fix violations
Modify the resource-key to not violate naming-rules after it has been reduced.
When to suppress warnings
If you´re ok with the fallback value generated by TypealizR ;)
Example of a violation
Description
The following content of a Resx-file demonstrate, what keys produce this warning.
Code
<root>
  <data name="class" xml:space="preserve">
    <value>Hello.</value>
  </data>
</root>

Example of how to fix
Description
In order to fix this particular situation, just prepend the key with an _.
Code
<root>
  <data name="_class" xml:space="preserve">
    <value>Hello</value>
  </data>
</root>

or similar ;)
Related rules

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

102 of 102 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 99.806%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
820

Relevant Lines:
820

💛  - Coveralls

Closes #8


Add watsonx basic deployment tests for additional models

This PR wants to add coverage for 2 models taken from HuggingFace:

https://huggingface.co/google/flan-t5-large
https://huggingface.co/pszemraj/flan-t5-large-grammar-synthesis

Verified at rhods-ci-pr-test/2031 - SUCCESS


How to set Component as String

When using vueify, my components are defined in app.vue.
I would like to set the component in a route to the name (string) of the component.
in app.vue:
module.exports = {
    components: {
        "foo": require("./pages/foo.vue"),
        "bar": require("./pages/bar.vue")
    }
}

Initialising the router:
router.map({
    '/foo': {
        component: "foo"
    },
    '/bar': {
        component: "bar"
    }
})

router.start(require("./app.vue"), "#app")

But I get the error:
[vue-router] invalid component for route "undefined"

Alternatively, you could also NOT give the component parameter, then you can handle the component yourself:
<component is="{{$route.mycomponent}}"></component>

This is no longer supported. Just require the components directly in the router config - it's actually more straightforward.

This is true, thanks.
Though, it assumes one component for one route. In my application I use two components per route, a template.vue and within this component another component e.g. content.vue
This means a combination of the use of:
<component is="{{$route.template}}"></component>

in the main app.vue and
<router-view></router-view>

in the template.vue.
Works fine, but for flexibility perhaps it would be good to allow component to be not defined in the route. Just an idea.
Thanks!

Allowing multiple components at the same route actually would complicate the problem when you are dealing with hooks like canActivate, canDeactivate - what can be handled in one place now needs to be split in two! In comparison, handling your own sub-views eliminates this problem altogether.


Updated regex to include textarea and more

This includes a new Regex to include texture | pre | Script within a page.
example output can be found here:
https://measuredbuildingsurvey.co/dynamic-lp/measured-building-survey/
Credit to Alan Moore and Ridgerunner
http://stackoverflow.com/questions/5312349/minifying-final-html-output-using-regular-expressions-with-codeigniter

@GrahamCampbell I've added a test and modified the existing to match the "forced" outcome. The textarea|pre|script is left intact in the end. Except for trailing white spaces before the closing </textarea|pre|script> it still works at the end of the day.
See results on measuredbuildingsurvey.co/dynamic-lp/measured-building-survey/

The problem with this, is the file is not html, it's blade.

Sorry I don't follow.
I'm using blade on my apps with most of the @ shortcodes .
I thought the blademinifier class parses the blade after it has converted the blade shorttags to php.
Maybe addition testing is required for other use than just HTML view.
I guess to get the Regex working properly I'll need to understand different use cases for blade.

Let me know what you need me to do to get this resolved:
Whenever I have time I'll work on it

My concerns are that these changes aren't safe, and my break php/blade code. We have a html minifier middleware that will minify the output in realtime, that will give best results.
The point of the blade minfy was just to give a crude minification that will reduce the size in most cases, but it was not intended to be optimal.

That's fine i'll leave the changes on my branch.


Release artifact naming inconsistency for Linux

Every release since 0.5.1 has a different naming format for Linux artifacts:

release version
naming format
note

0.6.2
goneovim-v<version>linux.tar.bz2
lowercase, version, no separator

0.6.1
goneovim-v<version>-linux.tar.bz2
lowercase, version, separator

0.6.0
goneovim-linux.tar.bz2
lowercase, no version, separator

<= 0.5.1
Goneovim-v<version>-linux.tar.bz2
uppercase, version, separator

This breaks every attempt at automating updates for tools like huber or simple shell scripts. The usual workflow for such automatic updates is to fetch the latest release version via Github API and then guess the artifact name, usually based on a pre-defined format that you can interpolate the version into. So this process is completely broken if naming format changes for every single release.

@13k
Thank you for pointing this out. I apologize for creating the release artifact in this state.
I have automated the generation of release artifacts with Github actions, so the file names are expected to be consistent in the future.
Note that the missing hyphen in the most recent v0.6.2 release for Linux was a bug in the release script.

No need to apologize, thanks for understanding!


fix: Upgrade dependency to gravitee-kubernetes

Issue
https://github.com/gravitee-io/issues/issues/XXXXX
Description
A small description of what you did in that PR.
Additional context

Gravitee.io Automatic Deployment
🚀 A prerelease version of this package has been published on Gravitee's private artifactory, you can:

use it directly by updating your project with version: 1.26.1-kube-client-upgrade-SNAPSHOT
download it from Artifactory here

:tada: This PR is included in version 1.26.1 :tada:
The release is available on:

1.26.1
GitHub release

Your semantic-release bot :package::rocket:


[AutoPR sqlvirtualmachine/resource-manager] [Portal Generated] Review request for Microsoft.SqlVirtualMachine to add version 2017-03-01-preview

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4740

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/4020


Add Chinese Simplified Translation

A string "Made with ❤ by Shivam" is left in English because I think it is better to do so :)
Also options of "Ebook reader" is missing from string xml so I can't translate it.

@starry-shivam  OK! And I will copy these comments to zh-rCN xml file and commit

@WeiguangTWK I've exported and merged the main branch into your PR. Now, you can add translations for those missing strings.

@starry-shivam Yeaaaa it works

Merged! Thanks :)


UX: Add a tagging system to recipes cards and metadata

Is your enhancement related to a problem? Please describe
In order to support filtering and searching for Recipes in the Catalog, they need to have certain metadata items attached to them. Some of these tags will be shown in the UI and others might be hidden.
Describe the solution you'd like
Tags added to the UI and metadata.
Describe alternatives you've considered
No response
Additional context
This issue is to support the Epic: https://github.com/containers/podman-desktop-extension-ai-lab/issues/1299
Doc to collaborate on tags list

I like the proposed inspitation. Another one which can be nice to look at, is how github is handling labels on issues.
The one example from huggingface is making a lot of sense for me, as it allows to have meta-categories of tags and sub-categories.
I think it would make sense to display the tags by default in the layout of the catalog of recipes - with the option to hide them, if they take too much spaces.

You can check the metadata we have on each of the recipes at the moment in this file: https://github.com/containers/podman-desktop-extension-ai-lab/blob/main/packages/backend/src/assets/ai.json
The minimum will be to have:

Language: what coding langage is used (Java, Python, NodeJS...)
Tools: Is it using vllm, llamacpp
Frameworks: some of our recipes are using llamaindex or solution from this type, we would call this out too.

I think we would show all the tags on each of the recipes. Of course, when there are more tags than what can be displayed, we will need a mecanism to "show more" or expanding the card to view all the tags (can also be a popover).

@MariaLeonova:
I think it's a good idea to display the labels on the details of the recipe, but that is something we can do in a second state.
In this ticket, we want to have a mockup that shows the recipe's metadata on the list of recipe, similarly to what you suggested in RHDH.

Should be adding tags on the card recipes from this mockup: https://github.com/containers/podman-desktop-extension-ai-lab/issues/1627#issuecomment-2321429148

@MariaLeonova: Thank you for the update. I personally prefer the option 1 as it allows to keep the action button in a consistent place and users are usually expecting the buttons to be in the corners.

How does it work when there are more than 2 tags to be displayed?

Aslo, would you be able to show how that fits with the work on https://github.com/containers/podman-desktop-extension-ai-lab/issues/1627#issuecomment-2321429148 ?

@slemeur I'll also explore the whole flow - when users will select something from a dropdown. This screen shows the multiple tags option on the Function Calling card.

Here's a proposal that will allow all cards to be the same size. The full list of tags will open on click 'x more':


Update versions

Fixes https://bitbucket.org/al45tair/netifaces/issues/53/update-supported-python-versions.
Assumes support for the currently supported CPython versions (2.7, 3.4+).

https://en.wikipedia.org/wiki/CPython#Version_history
Here's the pip installs for netifaces from PyPI for last month, which show the unsupported versions aren't used much:

python_version
percent
download_count

2.7
82.89%
358,329

3.6
7.44%
32,167

3.5
6.40%
27,675

3.4
3.00%
12,965

2.6
0.22%
972

3.7
0.03%
135

3.3
0.01%
46

3.2
0.00%
3

Source: pypinfo --start-date -56 --end-date -26 --percent --pip --markdown netifaces pyversion

Travis also has support for PyPy, could consider adding support for it.

Added!

I've added the extra versions to the testing matrix, as I think that's sensible. I don't think it's a good idea to remove the Python <=2.5 compatibility code, as I can't see any benefit from doing that (it's only a short snippet, and taking it out will just result in breakage if someone tries to install on Python 2.5; yes, I know, not many people will, but there's no reason to break things for them at this point).


Serve smaller cover images to Twitter

This is a follow-up to #572.
Hummingbird's cards are now showing up on Twitter, but not for all anime. I'm not sure if this is the reason, but according to their documentation, "images must be less than 1MB in size". In any case, I think there's no reason to serve Twitterbot a 7034x1997px 300dpi 5.6MB image...

:+1: LGTM


7,3',5'-trimethylmyricetin

Dear ChEBI curators,
Is the compound " 7,3',5'-trimethylmyricetin " defined in Chebi ? If not, could you please add it.
Ref:

https://biocyc.org/compound?orgid=META&id=CPD-14940
https://pubchem.ncbi.nlm.nih.gov/compound/90657702

Best Regards

An entry has now been created (CHEBI:146136).


Define process for documenting recommended/previous changes

Background
Sometimes we make changes in feature and fix releases which don't require users to make changes in order to update (so it's not a breaking change), but they may need to make changes if they want to benefit from the change.
We've got 3 changes like that at the moment which we've made in GOV.UK Frontend but haven't told users about yet:

https://github.com/alphagov/govuk-frontend/issues/1758
https://github.com/alphagov/govuk-frontend/issues/2196
https://github.com/alphagov/govuk-frontend/issues/1829

What
We should define and document a process for dealing with this kind of work, for v4.0.0 and in the future. Previously, we've made the assumption that these changes will be documented in the next breaking release. However, we know breaking releases are challenging for users already as the release notes tend to be very long and we're potentially asking them to make a lot of changes. Does it make sense for these changes to be included here, especially when the change itself isn't included in the release?
Some questions I think we have:

Should these changes be documented in the release notes of the next breaking release?
If we don't document these in breaking release notes, what are the alternative options? When will we tell people about the change they might need to make? Are there any other comms channels we can use?
If we do document these in breaking release notes, how do we talk about them? Do we explain that the change hasn't been made in that release?

Who needs to know about this
Developers; Tech Writer; Content Designer
Done when

[x] We have a process for dealing with the three cards above
[x] If the three cards above are being included in v4.0.0, make sure they're attached to the milestone
[x] If we're confident in the process, make sure it's documented somewhere
[x] If it's something we're trialling for v4.0.0, make sure there's a follow-up card to revisit how it went

We were going to include the changes mentioned in the description of this PR in the 3.14.0 release notes. However, we've decided against doing this for the reasons mentioned here.
Having discussed this with the other developers on the team, we think a suitable process for issues like this that come up in the future (where we have recommended, but non-breaking, changes for people to make) would be:

Make the change in a feature/fix release
Document our 'recommended steps' in the release notes for that release. Make clear that this isn't a breaking change, but we recommend people make the change
In the next breaking release, refer to the changes/release notes again. More briefly this time, perhaps linking to the original release notes, but making it more strongly recommended that users make this change. At some point we need to make the assumption that people have made this change so we can stop supporting the users who haven't - this is probably that point.

I'm not sure if we want to document the above anywhere other than this Github issue?
However, for the changes listed in the PR description, the steps users need to take were not documented in the release notes when they were released. Following the above process, we'd still want to talk about them in the v4.0.0 release, so it probably makes sense to include them there. It will lengthen the v4.0.0 release notes a bit, but at least it gives us a clean slate for the next time this kind of issue crops up.
The only other alternative we came up with is adding them to the Changelog file separately from any release, but I’m not sure how we’d then share that around with users and motivate them to take action - I think we’d have to bring it up in v4.0.0 again.

Going to take this off the v4.0.0 milestone - we've made the decision for v4.0.0. We can do the write-up separately.

Closing this issue as we addressed it in #2523.


How can I automatically post the preview address as a comment?

In the same way as setting up automatic deployment on the cloudflare dashboard, how can I get the cloudflare-page bot to automatically post the preview address as a comment?

See #16.


[automated] Re-Apply Coding Standards

Automated changes by create-pull-request GitHub action

Codecov Report

Merging #121 (c71fafd) into main (cb7ba57) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #121   +/-   ##
=========================================
  Coverage     94.44%   94.44%
  Complexity      594      594
=========================================
  Files           128      128
  Lines          2360     2360
=========================================
  Hits           2229     2229
  Misses          131      131

Flag
Coverage Δ

phpunit
94.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb7ba57...c71fafd. Read the comment docs.


Unusual route values appearing when using Url.Action

I'm trying to create a link to the following GET:
public class FooController : Controller
{
    [HttpGet]
    [Route("Foo/Apply/BarDetails/Part/{id}")]
    public IActionResult BarDetails(int id)
    {
    }
}

In my view I'm creating a URL with
Url.Action("BarDetails", "Foo", new {id = 1})

I was expecting this to generate Foo/Apply/BarDetails/Part/1 however I actually get Foo/Apply/BarDetails/Part/10?id=1 and I'm struggling to understand why. The page this link is on has no id parameter in its route (or indeed any parameters in its route) so there shouldn't be any ambient values. Removing the values parameter simply removes the query string part of the URL. The only route I have registered at startup is the default:
app.UseMvc(routes =>
{
    routes.MapRoute(
        name: "default",
        template: "{controller=Home}/{action=Index}/{id?}");
});

I suspect that the 10 is coming from a "1" + "0" operation happening somewhere but I haven't found it yet in the source! Does anyone know why this might be happening?

OK, I've figured it out. It's mostly a quirk in the the way I've written my FooController but as FooController originally came from an MVC5 project where the routing worked I thought I'd log it and leave it to the team to decide if the current MVC Core behaviour is a bug or a feature!
My FooController is responsible for a form that consists of ~250 views organised in sections and looks a bit like this:
public class FooController : Controller
{
	[HttpGet]
	[Route("Foo/Apply/Section1/Part/{id}")]
	public IActionResult Section1(int id)
	{
		var model = GetModelForSection1(id);//get the model for the requested section
		var viewPath = GetViewPathForSection1(id);//Calculate the path to the viewPath
		return View(viewPath, model);
	}

	[HttpPost]
	[Route("Foo/Apply/Section1/Part/1")]
	public IActionResult Section1(Part1Model model)
	{
		// Do whatever with the model
		return RedirectToAction("Section1", 2);
	}

	[HttpPost]
	[Route("Foo/Apply/Section1/Part/2")]
	public IActionResult Section1(Part1Model model)
	{
		// Do whatever with the model
		return RedirectToAction("Section1", 3);
	}

	// etc for 10 more views in Section 1...
	// etc for 6 more sections...
}

The POST actions are all named the same for each section so we didn't have to manually specify actions for the forms in each of the 250 different views!
The problem in generating routes with Url.Action comes when the Routing module tries to find a match for the controller name/action name combination. When given a controller name Foo and an action name Section1, LinkGenerationDecisionTree.GetMatches finds a list of matches like this:
"Foo/Apply/Section1/Part/{id}"
"Foo/Apply/Section1/Part/1"
"Foo/Apply/Section1/Part/2"
etc...

Which is fine until line 30 where GetMatches sorts the list of matches by precedence, which sends Foo/Apply/Section1/Part/{id} (with precedence 5.5553) to the bottom, and then by the route template text, and as the rest of the matches have the same precedence (5.555) this sends Foo/Apply/Section1/Part/10 to the top of the list. This is the first match for controller name Foo and action name Section1, hence why Foo/Apply/Section1/Part/10 always appears:
"Foo/Apply/Section1/Part/10"
"Foo/Apply/Section1/Part/11"
"Foo/Apply/Section1/Part/12"
"Foo/Apply/Section1/Part/1"
"Foo/Apply/Section1/Part/2"
etc...
"Foo/Apply/Section1/Part/{id}"

As I said, I'll leave it up to the team to decide whether this is the intended behaviour or not but I thought it was worth flagging up as the end result is different from the behaviour in MVC5. And also because I've had such a fun time this morning hunting it down I thought I'd share the joy :wink:
In the meantime I'll reorganise my controller to give my POST actions unique names...

Hmm, looking at the eventual source I guess this should probably be moved to the Routing module?

I have the exact same issue! @Url.Action() and even the tag helper asp-controller and asp-action would have the route value pretended at the end of the URL.
And that route value looks like the id of the current request URL.
For example, if I have an edit page /product/edit/10 but I want to display edit links for other products on that page, those links would look like
/product/edit/10?id=1
/product/edit/10?id=2,
....
/product/edit/10?id=10000

This issue was moved to aspnet/Routing#504


Use #[Autowire] attribute instead of Yaml config

I'm not sure this is something you want to do: replacing Yaml config for attribute for class alias, to use the #[Autowire] attribute available since Symfony 6.1.
I did the change, so let you decide if that's good or not for the demo.

Thanks Jérôme. I like this a lot. However, while merging I reverted the change related to autowiring the LogoutUrlGenerator service.
It looked a bit weird to me. Also, after seeing this pull request from yours: https://github.com/symfony/symfony/pull/52833 this might be a thing of the past in the next Symfony version.
Thanks!


Jupyter of VS Code cannot be exported as a python file.

Environment data

VS Code version: 1.55.0 (user setup)
Jupyter Extension version (available under the Extensions sidebar): 2021.5.702919634
Python Extension version (available under the Extensions sidebar): 2021.3.680753044
OS (Windows | Mac | Linux distro) and version: Windows_NT x64 10.0.19041
Python and/or Anaconda version: Python3.8.3
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
Jupyter server running: Local

Expected behaviour
Export Jupyter as a python file in VS Code.

Actual behaviour
Unable to export Jupyter as a python file in VS Code.

Steps to reproduce:
[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]

Open VS Code and wait for all extensions to be loaded;
Open/create the Jupyter file, the code can be run (print("111"));
Click the export icon above Jupyter, there are only HTML and PDF options, but no the python option.

Related Links: Export as python scripts is no longer available in VS code version 1.55

Thanks for the bug. This is a regression.

Validated. I see the option now. But we should check in the point release branch as well to make sure it works on stable.

@IanMatthewHuff  -Does it require the use of the specified version of the 'Python' extension or 'Jupyter' extension? There is still no "python" option in Jupyter in my VS Code.

@Jill-Cheng we close items when the bug has been fixed in our 'main' branch. You can build it yourself or use the insiders version of VS code which should get our nightly builds (which get published daily)


Type narrowing doesn't appear to work on typing.Union

import typing

class Cake:
    pan: str

class Pie:
    filling: str

def process_dessert(dessert: typing.Union[Cake, Pie]):
    if isinstance(dessert, Cake):
        print(dessert)

On hover, the type is revealed to be a union instead of Cake.

Using reveal_type from mypy the type is narrowed to Cake: Revealed type is 'Cake'

Related to #710.


error TS2307: Cannot find module 'whatsapp-api-js/messages'

when i try to import whatsapp-api-js/messages i get the error message. this only happens wen import some message
import WhatsAppAPI from "whatsapp-api-js"
import { Text } from "whatsapp-api-js/messages";

Hi! Which is your whatsapp-api-js version? Keep in mind the modular import syntax is for the 1.0.0 version

Great, let me know if it works so I can mark the issue as complete

Same problem here. 1.0.0-beta.5

I managed to replicate the issue, I'm 100% sure it's a configuration issue with the exports at package.json.
I'm reading the documentation to understand how's the "types" property meant to be used. Tomorrow I have a 2 and a half hour flight, so I might be able to find a solution on the go.

I finally came across the GitHub issue at TS saying why this specific error isn't "supported":
https://github.com/microsoft/TypeScript/issues/33079
Unfortunately, this unsupported feature was how I supposed exports were meant to be used with TypeScript.
Under the hood possible fixes:

NPM workspaces is the recommended solution at the GitHub issue (I think), but I can't implement it right now.

Build all the types into a single file, although I'm not even sure that's possible

Creating duplicated types definitions for module and commonjs folders, removing the need to point to a different folder (not ideal, but the easiest to implement)

Unfortunately, until I settle down which solution to use, the only fix is ts-ignore
Thanks for opening and commenting on the issue!

@arivanbastos no, i still have the problem

Hi! I finally fixed the issue with minimal changes to the package.json, so there are no breaking changes.
Check out the PR, I won't be able to publish a new release from my phone in at least a few hours, but it's easy to update locally:

Copy the new package.json from the pull request

Replace your_code/node_modules/whatsapp-api-js/package.json with the new file version

Let me know if this fixes the issue for both of you, and I will merge the PR
Thanks for the issue!

The error remains here, even after replacing node_modules/whatsapp-api-js/package.json by the one present in PR. But I'm not 100% sure it is not a local problem cause I've changed some files.
@50c10
I was able to bypass typescript type errors by:

Add the following to the end of node_modules/whatapp-api-js/lib/types/index.d.ts
export { GetParams, ClientMessage } from "./types.js";

Create a class that implements ClientMessage

import { ClientMessage } from "whatsapp-api-js";
export class TextMessage implements ClientMessage {
    body: string;
    preview_url: boolean;

    get _type(): string {
        return "text";
    }

    constructor(body: string, preview_url: boolean) {
        if (body.length > 4096) {
            throw new Error("Text body must be less than 4096 characters");
        }

        this.body = body;
        this.preview_url = preview_url;
    }

    _build() {
        return JSON.stringify(this);
    }
}

Use the class created at step 3 to send messages;

whatsapp.sendMessage(phoneID, phoneNumber, new TextMessage(messageText, true))
    .then((res)=>{})
    .catch((err)=>{});

I had to import GetParams type also, cause I got type script type errors when using the whatsapp.get() method (for webhook validation proccess).
      let params: GetParams = {
          'hub.mode': 'subscribe',
          'hub.verify_token': (urlRequestParams['hub.verify_token'] as string) || '',
          'hub.challenge': (urlRequestParams['hub.challenge'] as string) || '',
      };
      whatsapp.get(params);

@arivanbastos. I tried the solution and it worked fine.
Thanks @Secreto31126


Go 1.13 + better source docs

this adds support for a Golang 1.13 build plus many sourcecode comments to better explain the implementation

please check and merge if happy

Coverage increased (+0.2%) to 59.637% when pulling 837466163e5829f82615db6a0082467dbc34fdf3 on go113 into 492faf404bde2bc1501c7eb571ba0e685add871b on master.


Elementum deletes file and directory after download or after watching

Elementum 0.0.51 deletes the file and directory after the file is downloaded or watched. If I'm watching the video during download, it remains until I end the video, then it deletes and removes the file and directory. If I'm just downloading and not watching, I can see the file and directory as it downloads but once complete it just goes away.
I have set the following options:
Download Path: C:\Downloads\Movies
Library Path: c:...\Kodi\userdata\addon_data\plugin.video.elementum
Download after play: Continue
Keep files for not finished video: Keep
Keep files for watched/downloaded video: Keep
Move finished downloads to separate folders: On
Movies: C:\Download\Movies
TV Shows: C:\Download\TVShows
Expected Behavior
I expect that after either downloading or watching a move as it downloads that the file and its directory remain in the c:\downloads\Movies folder
Current Behavior
If I'm watching a movie as it downloads, it removes itself after I'm done watching. Sometimes I exit a movie at the beginning so I can start a second download. While the other files are downloading, the directory and file are created and available but as soon as the download is complete, both the file and directory disappear. The only way I can seemingly save a file after downloading is by watching each movie until it is fully downloaded then I can copy the folder to another name to save it. As soon as I end watching the movie through Elementum, it deletes itself.
Your Environment
Windows 10
Kodi 17.6
Elementum 0.0.51
Burst 0.0.17

https://kodi.wiki/view/Log_file/Easy

@JamesDandy  I will close the issue if you won't provide a log file.

Closing as no log provided.

I never saw an email asking for a log until I received the email saying that you will close the issue. The message above where you "asked" for a log is just a link and does not actually ask for anything.
I still have an issue, it's not consistent but I've had to watch a movie or pause a movie until it's fully downloaded, then I copy the movie's folder. Then I can let movie finish or just stop playing it and in some cases it deletes the folder, other times it doesn't. I don't understand the inconsistency.
The prompt asking if I want to continue downloading doesn't seem to be clear either, especially since I get this when the movie is fully downloaded or not.
I'm happy to provide a log if you reopen the issue.

@JamesDandy if you have an issue - you have to reproduce it and send log file, so it can be found.

I've just had this same issue.
kodi.log

I am having a similar issue in Kodi 17 on Debian. Elementum does not “Ask” anything, even though Ii have set it to “Ask to delete” when for “not finished video” and “watched/downloaded video”. A log file here https://pastebin.com/raw/3pY4zpeX ,
thanks


Optimization: set-spec-constant-default-value pass should have an interface to accept bit patterns.

Fixed by #632


Explain two tactics for bootstrapping Flux+Pulumi

That is: layer Pulumi over Flux, or layer Flux over Pulumi.

[x] Needs #339 so it can refer to the program there
[ ] Explain (better) how to refer to a Flux source from a Stack
[ ] Find the right place in the README and link to docs/flux.md

Closing this, I'll create a new PR if I work on it again.


Fix the HINT for List.filter

List.filter keeps the elements that satisfy the test and does not remove them as the original HINT suggests.

Alternatively, keep the code as is, but change the hint to HINT: Here's how to keep all the "foo" strings in a list of strings:.

Thanks! I went for slightly different wording in d5d25f90f676fb74979284a3c7642d4ae434b9d1


win10 ex1 running

Hi,
I built this project via cmake 3.15 on win10, it compiles successfully, however, when I run the ex1, it shows some errors:
mfem::Memory<mfem::IntegrationRule * __ptr64>::operator returned nullptr.
It breaks down when >	ex1.exe!mfem::`dynamic initializer for 'IntRules''() Line 877 in intrules.cpp, could you please help figure out what happened?
Thanks

Did you use WLS, Visual Studio or something else?

yes, I use Visual Studio 2015.

I just tried ex1 on Win10 for you and cannot reproduce this issue. Did you select the /machine:x64 at CMake configuration?

I run this project on my laptop without any installed libraries, it works (vs 2019). However, it still crashes down when I turn to my desktop.
Maybe interrupted with other libraries?
It seems weird.

@Haikuana  were u able to run paralle version in windows by linking hypre and metis libraries ?

@ajithvallabai I used default openmp, I recommend you can try linux to link these libs. it should be easier!

We test the build with Visual Studio with MPI+hypre+metis in the appveyor CI, see the commands we use in https://github.com/mfem/mfem/blob/master/.appveyor.yml. We only run the serial examples on appveyor, so it is possible there maybe some runtime issues with the parallel build that we do not catch.


Bad Spelling

Rule Suggestion
I'm having this issue where I want to spell lambda, but I often write lamdba on accident. Its happening all the time and its really hard to catch for some reason. Its not just variables, but file paths and strings that aren't type checked. It would be really nice if I could have very basic tslint rule to match invalid regex strings anywhere in your code to prevent these issues.

I think that you need a dictionary. If you are using VSCode I would suggest Code Spell Checker extension.

nope this is the job of a spellchecker, not a linter. plenty of great options out there already.


[CLI] Improve Keybase private-keys sourcing when running in Kubernetes

Objective
Currently, now that we merged #522, the CLI has a Kubernetes API dependency because the private-keys.yaml file (required by the keybase) is not available locally inside the Pod and therefore, in order to have the same init logic, we need to source it by fetching the Secret via the Kubernetes APIs.
Origin Document
During the Protocol Hour today (17th Feb 2023) @okdas raised a good point regarding having Kubernetes dependencies inside the CLI at all. The CLI should stay unopinionated and be flexible in terms of sourcing dependencies like the private-keys.yaml
Goals

Decouple debug keybase initialization from the core logic
At a minimum allow to specify a path where to fetch the private-keys from
Decouple the debug/development private-keys from k8s

Deliverable

[ ] Allow specifying a path from where the development/debug private keys should be initialized from
[ ] Make debug key base initialization a separate process (e.g. different make target) independent of the CLI
- [ ]  Updated CLI/Keybase code
[ ] Update the Kubernetes manifests so that the private-keys file is accessible without requiring us to interact with the Kubernetes API at all

[ ] Updated Localnet manifests

Non-goals / Non-deliverables

Additional modifications to keybase extensions

General issue deliverables

[ ] Update the appropriate CHANGELOG(s)
[ ] Update any relevant local/global README(s)
[ ] Update relevant source code tree explanations
[ ] Add or update any relevant or supporting mermaid diagrams

Testing Methodology

[ ] Task specific tests or benchmarks: make ...
[ ] New tests or benchmarks: make ...
[ ] All tests: make test_all
[ ] LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

Creator: @deblasis
Co-Owners: @okdas, @Olshansk
### Tasks
- [ ] Add a draft title or issue reference here

@deblasis wdyt about linking with @h5law for this one if he's available?

Consult with @deblasis on implementation

also, another symptom of this is the TODO that is already logged in the codebase:

I fixed the bug in my PR by using go:embed https://github.com/pokt-network/pocket/pull/537/files#diff-4191f8f6d8583a1386ce5793bec85c80d9c99b755dfbd6da9564d817bc0ccdba
Thus, the private keys are available in the binary if my PR gets merged. We could add on top of build/debug.go to further customize the debug localnet envs.
@jessicadaugherty @deblasis

also, another symptom of this is the TODO that is already logged in the codebase:

I fixed the bug in my PR by using go:embed https://github.com/pokt-network/pocket/pull/537/files#diff-4191f8f6d8583a1386ce5793bec85c80d9c99b755dfbd6da9564d817bc0ccdba
Thus, the private keys are available in the binary if my PR gets merged. We could add on top of build/debug.go to further customize the debug localnet envs.
@jessicadaugherty @deblasis

Hey @0xBigBoss!
Sweet... yeah, this is definitely a way to solve the problem.
If your change gets merged as is I guess the current issue boils down to just sourcing the private-keys from the embed instead of kubernetes.
Regarding your implementation specifically, I'll comment on your PR (that I haven't seen yet but you tickled my curiosity now!)

Thanks, guys! Will update the deliverables to reflect the TODO being fixed in #537

CLI takes too long to initialize. May be resolved by https://github.com/pokt-network/pocket/pull/537
FF yaml behind build flag to only be in build so it doesn't get a private key

Tysm for the clarifying edit on my last comment @bryanchriswhite #BestCoPM

@0xBigBoss While we are iterating on #537, thoughts on taking the code you have in build/debug.go and splitting it out into a separate PR just to solve the CLI loading issue?
import _ "embed"

// PrivateKeysFile is the pre-generated manifest file for LocalNet debugging
//
//go:embed localnet/manifests/private-keys.yaml
var PrivateKeysFile []byte

func init() {
	if len(PrivateKeysFile) == 0 {
		panic("PrivateKeysFile is empty")
	}
}

My personal opinion is that when we build the CLI binary, we should have a --debug flag which determines if this yaml file should be embedded via go:embed or not. That way it can be preloaded in the development p1 binary, but easily excluded in prod.

@Olshansk yeah I'd be happy to add a --debug flag or some other mechanism that seems appropriate when building the CLI to include the hard-coded private keys, although I may have more thoughts when I dive in.
CC @deblasis


[CI] Change log

Fix https://github.com/home-assistant/home-assistant-android/issues/12

Can we get a sample of the new change log?

$ git log --format=%B -n 1 715ca9e

Allow editing of Device Name (#158)

Migrate preference categories to string resource.
Disable lint for missing translations.

We now can change the device name.

Linting Fixes.

Tests a functional, now to add new tests.

Fix all the tests for real this time.
Fix clean task being in wrong group.

Add tests for persisting device registration.

Extract string, remove summary, use androidx preferences.


467-add-an-all-others-category-to-tada_fieldvaluespie-when-there-are-many-categories

Added all other categories if number of categories exceed 12.

@wokenny13 - this looks great. Once the final check passes, I will merge it.


Doesn't recognize virtual keyboard input / buttons on drawing tablet

On Windows 10. Using a tablet PC not in mode S.
The program only recognizes '-' and '=' when using the tablet's default keyboard. All other button presses are ignored.
While the drawing tablet works for moving parameters, the buttons which are mapped to the correct keystrokes are ignored.
The accessibility feature, On Screen Keyboard, does work as intended.
Perhaps adding on screen buttons for next and previous would be helpful.
Video demonstration: https://youtu.be/2h612gV085s

@maeblythe Thank you for your help on testing and reporting the issue.
I think it's a great idea that every action should be available from menu or button click on screen, so we will add buttons for switching features.
For other actions, such as "scroll to center", you can find them in the Edit menu.
For the issue that keys are not working, please kindly help use diagnose the problem by:

Download the app from https://drive.google.com/file/d/1BXH39n-O28gUkusA3pyXx2akTCv2GtYr/view?usp=sharing . It's a version based on the recent release 1.0.0-alpha2 version with some code added, to print the received keyboard events to logs.
After opening a project, press the used keys including Down, Ctrl, F etc
Find the logs from the vLabeler directory, probably "C:\Users<your_user_name>\vLabeler\logs\info.log", and upload it here. (Or to my e-mail address<EMAIL_ADDRESS>

https://github.com/sdercolin/vlabeler/compare/62b845d..2066eb9


Create question to find the only single number

@lk-chen, is this done? If not, who is working on it?

Sorry, we decided to work on other issues and forgot to close this one.


File is empty after saving it when using SSH

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
When I open a file via SSH, change its content (or not - actually it doesn't matter) and save it, the file is shown as empty and is saved as empty afterwards. I can reverse it with Ctrl+Z and save it again, in which case it saves it correctly. Other editors like gedit or GNOME Builder working perfectly fine.
I tried to connect and open the files via SSH connected through LAN and via the 'normal' internet - makes no difference.
Steps to Reproduce

Connect to host via SSH
Open any text-file
make changes (or not - doesn't matter) and save the file
File should now be empty (if not repeat step 3)
Ctrl+Z and restore the content
Save again - File should now be saved with the correct content

Expected behavior: Atom should show and save the correct content
Actual behavior: Atom shows and saves an empty file
Reproduces how often: 90%
Versions
$ atom --version
Atom    : 1.26.1
Electron: 1.8.4
Chrome  : 59.0.3071.115
Node    : 8.2.1
$ apm --version
apm  1.19.0
npm  6.0.1
node 10.1.0 x64
atom 1.26.1
python 2.7.15
git 2.17.0
OS: Arch Linux
$ uname -r
4.16.8-1-ARCH

Thanks for the report!

Connect to host via SSH
Open any text-file

Can you expand on this?  E.g. if I'm on Ubuntu, how exactly would I reproduce this part (are you using a community package, sshfs, etc.)?

Ok so maybe it's important that I am using Gnome.

Open the file-explorer on your host-system
Select "Other Locations" in the sidenav and establish a sftp-connection. Now you should be able to browse the remote filesystem as it would be mounted on the host system.
Now create a new file on the remote system and open it by using double-clocl (or open an existing one) and do the steps as described in the original post

So it seems that there was a problem with my system in general. After jumping between the different versions in the AUR (bin and beta-bin - the beta binary worked normal) and jumping back to the "official" arch atom-package which was installed when i opened this issue (wanted to compare the electron versions), everything seems to work fine again.

I ran into this same issue on Ubuntu 18.04. Initially I installed using Snap which gave me version 1.27.1 After having the issue I downloaded the deb from atom.io which gave me version 1.27.2 and I still had the same issue.
I no longer had the issue after installing the current Beta though. I then uninstalled the Beta and reinstalled from Snap and everything works fine just like @ngreve


ci: make unit fails because of a str local date does not corresponding to a timestamp

Hello,
By executing :
$ make unit

I get the error in the output :
Cleaning up distutils stuff
rm -rf build
rm -rf dist
rm -rf MANIFEST
rm -rf *.egg-info
Cleaning up byte compiled python stuff
find . -type f -regex ".*\.py[co]$" -delete
Cleaning up doc builds
rm -rf docs/_build
rm -rf docs/api_modules
rm -rf docs/client_modules
Cleaning up test reports
rm -rf report/*
pytest --cov=slo_generator tests -p no:warnings
============================================================================================================ test session starts =============================================================================================================
platform linux -- Python 3.7.7, pytest-7.2.1, pluggy-1.0.0
rootdir: /home/test/slo-generator
plugins: cov-4.0.0
collected 48 items

tests/unit/test_cli.py .....                                                                                [ 10%]
tests/unit/test_compute.py ....................                                                                                [ 52%]
tests/unit/test_migrate.py .                                                                                [ 54%]
tests/unit/test_report.py ...........                                                                                [ 77%]
tests/unit/test_utils.py ......                                                                                [ 89%]
tests/unit/backends/test_cloud_monitoring_mql.py F                                                                                [ 91%]
tests/unit/backends/test_elasticsearch.py ....                                                                                [100%]

================================================================================================================== FAILURES ==================================================================================================================
________________________________________________________________________________ TestCloudMonitoringMqlBackend.test_enrich_query_with_time_horizon_and_period ________________________________________________________________________________

self = <tests.unit.backends.test_cloud_monitoring_mql.TestCloudMonitoringMqlBackend testMethod=test_enrich_query_with_time_horizon_and_period>

        def test_enrich_query_with_time_horizon_and_period(self):
            timestamp: float =<PHONE_NUMBER>.5144777  # = 2022/10/28 22:10:15.5144777
            window: int = 3600  # in seconds
            query: str = """fetch gae_app
    | metric 'appengine.googleapis.com/http/server/response_count'
    | filter resource.project_id == 'slo-generator-demo'
    | filter
        metric.response_code == 429
        || metric.response_code == 200
    """

            enriched_query = """fetch gae_app
    | metric 'appengine.googleapis.com/http/server/response_count'
    | filter resource.project_id == 'slo-generator-demo'
    | filter
        metric.response_code == 429
        || metric.response_code == 200
    | group_by [] | within 3600s, d'2022/10/28 22:10:15' | every 3600s"""

>           assert (
                CloudMonitoringMqlBackend.enrich_query_with_time_horizon_and_period(
                    timestamp, window, query
                )
                == enriched_query
            )
E           AssertionError: assert 'fetch gae_ap...| every 3600s' == 'fetch gae_ap...| every 3600s'
E             Skipping 237 identical leading characters in diff, use -v to show
E             - '2022/10/28 22:10:15' | every 3600s
E             ?           ^^^^
E             + '2022/10/29 00:10:15' | every 3600s
E             ?           ^^^^

tests/unit/backends/test_cloud_monitoring_mql.py:42: AssertionError

----------- coverage: platform linux, python 3.7.7-final-0 -----------
Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
slo_generator/__init__.py                                0      0   100%
slo_generator/api/__init__.py                            0      0   100%
slo_generator/api/main.py                               99     99     0%
slo_generator/backends/__init__.py                       0      0   100%
slo_generator/backends/cloud_monitoring.py             101     14    86%
slo_generator/backends/cloud_monitoring_mql.py          95     65    32%
slo_generator/backends/cloud_service_monitoring.py     292    186    36%
slo_generator/backends/datadog.py                       86     10    88%
slo_generator/backends/dynatrace.py                    126     42    67%
slo_generator/backends/elasticsearch.py                 62     10    84%
slo_generator/backends/prometheus.py                    82      8    90%
slo_generator/cli.py                                    69     10    86%
slo_generator/compute.py                                81      8    90%
slo_generator/constants.py                              32      0   100%
slo_generator/exporters/__init__.py                      0      0   100%
slo_generator/exporters/base.py                         66      9    86%
slo_generator/exporters/bigquery.py                     88     16    82%
slo_generator/exporters/cloud_monitoring.py             29      0   100%
slo_generator/exporters/cloudevent.py                   28     28     0%
slo_generator/exporters/datadog.py                      19      0   100%
slo_generator/exporters/dynatrace.py                    40      7    82%
slo_generator/exporters/prometheus.py                   35      6    83%
slo_generator/exporters/prometheus_self.py              27     13    52%
slo_generator/exporters/pubsub.py                       14      0   100%
slo_generator/migrations/__init__.py                     0      0   100%
slo_generator/migrations/migrator.py                   222    134    40%
slo_generator/report.py                                188     37    80%
slo_generator/utils.py                                 201     62    69%
------------------------------------------------------------------------
TOTAL                                                 2082    764    63%

========================================================================================================== short test summary info ===========================================================================================================
FAILED tests/unit/backends/test_cloud_monitoring_mql.py::TestCloudMonitoringMqlBackend::test_enrich_query_with_time_horizon_and_period - AssertionError: assert 'fetch gae_ap...| every 3600s' == 'fetch gae_ap...| every 3600s'
======================================================================================================= 1 failed, 47 passed in 46.83s ========================================================================================================
make: *** [Makefile:69: unit] Error 1

Because that function returns in part of text the local date corresponding to the POSIX timestamp passed as parameter : https://github.com/google/slo-generator/blob/master/tests/unit/backends/test_cloud_monitoring_mql.py#L43
whereas here the date is set as fixed str in a text : https://github.com/google/slo-generator/blob/master/tests/unit/backends/test_cloud_monitoring_mql.py#L40
So the assert fail, depending of the local env.
How to reproduce :
OK:
$ TZ='UTC' make unit

Fail:
$ TZ='Europe/Paris' make unit

Additional informations :
$ timedatectl show --va -p Timezone
Europe/Paris

$ end_date_str='2022/10/28 22:10:15'
$ sec=$(TZ='UTC' date +'%s' -d "$end_date_str")
$ TZ='Europe/Paris' date -d "@$sec" '+%Y:%m:%d %H:%M:%S'
2022:10:29 00:10:15

Thanks in advance for feedbacks.
Rgs,

Hello @lvaylet
Any news please ?
Thanks in advance.
Rgs,
Sophian

Hi @smehboub, I am currently working on #329 that seems directly related to the behavior you are noticing here.
Regarding your other issues/PRs, they look like good improvements but I have to prioritize bugs first. On top of that, I maintain this project on a best-effort basis and I must admit I have been quite busy with my other daily activities up until now. I will do my best!

Hi @smehboub, I am currently working on #329 that seems directly related to the behavior you are noticing here.
Regarding your other issues/PRs, they look like good improvements but I have to prioritize bugs first. On top of that, I maintain this project on a best-effort basis and I must admit I have been quite busy with my other daily activities up until now. I will do my best!

Hi @lvaylet
I understand I'm in the same situation.
Thank you very much for your feedback.
Good luck :-)

Duplicate of #308

I suspected it


Build timeouts on ReadTheDocs

A significant fraction of our doc builds have started running up against ReadTheDocs's 900 second timeout for builds:

Investigating a few of these, it seems that the main culprit is installing/downloading conda packages in the conda env create and conda install steps. In some cases, these take over 700 seconds combined, leaving little time for Sphinx, which on its own takes only a couple minutes (but RTD runs it three times for some reason).

Notice that it took 411 seconds to run conda env create!

If you are using conda-forge bare in mind that our package index is huge and conda is not very smart about it. We are looking into possible solution. Pinging @pelson who have some ideas in mind on how to address this problem.

Pinging @pelson who have some ideas in mind on how to address this problem.

The ideas relate to the fetching of the index, which will take orders of magnitude less time than the resolve and download stages in conda. They aren't entirely unrelated though, as a smaller index (the proposal) would result in fewer options for the conda solver to have to work through. No matter what we do, caching the binaries will have the same impact, though it is a challenge to cache sensibly without having a really large cache... You may find that caching an environment.yaml actually has more of an impact than caching the binaries themselves (i.e. this means you continue to download the binaries each time, but don't do a conda resolve each time).

Closed via https://github.com/rtfd/readthedocs.org/issues/4432


Dropdown multiple values not supported in Typescript

Describe the bug
Since PR #1602 Taiko supports multiple value selection for dropdowns, but that does not work in Typescript due to type inconsistency (as already mentioned in the PR comments)
To Reproduce
Steps (or script) to reproduce the behavior:

Create a new folder and cd into it
Initialize the npm project with npm init
Add Taiko to the project npm i taiko
Add Typescript to the project npm i -D typescript
Create a new file like:

//index.ts
import  { dropDown } from "taiko";
async function main() {
  const myDropdown = dropDown('Vehicle:');
  await myDropdown.select(['Car','Van'])
  const values: string[] = await myDropdown.value()
}

try compiling with npx tsc
you get an error like:

index.ts:6:9 - error TS2322: Type 'string' is not assignable to type 'string[]'.
6   const values: string[] = await myDropdown.value()

Logs
index.ts:6:9 - error TS2322: Type 'string' is not assignable to type 'string[]'.
6   const values: string[] = await myDropdown.value()

Expected behavior
DropDownWrapper now extends ValueWrapper which has a method value() returning Promise<string>.
I think DropDownWrapper should extend a new MultiValueWrapper which has a method values() returning Promise<string | Array<string> | Array<number>>.
The ValueWrapper should remain as it is for the elements that actually implement that behavior such as ColorWrapper, TextBoxWrapper, etc.
Screenshots
If applicable, add screenshots to help explain your problem.
Versions:

Taiko: 1.0.26
OS: Win10 home 10.0.19041
Node.js: v14.4.0
Typescript: 4.0.5

Additional context
Add any other context about the problem here.

I think DropDownWrapper should extend a new MultiValueWrapper which has a method values() returning Promise<string | Array | Array>.
The ValueWrapper should remain as it is for the elements that actually implement that behavior such as ColorWrapper, TextBoxWrapper, etc.

@felipdc Since you already have the fix in your mind, would you like to raise a PR for the same?

@fmpanelli Since you already have the fix in your mind, would you like to raise a PR for the same?

Sure! Hopefully I'll be able to submit a PR this evening.


Pause on hover?

Doing some research on the new BS4 toasts which led me here.  Looking to change from my current toasts plugin to BS4's.  This is basically what I was looking for (calling on the fly by passing options), but was hoping you added a pause on hover option... is that on the roadmap?

@morrow95
This sounds like a good idea though unsure how feasible it is.
I'll give it a bash and will report back. Feel free to have a go yourself and make a pull request if anything avails.

Will do.  I have some other things to do first before I get around to changing the toasts, but when I do, and if you haven't looked at it, I will play around with it a bit.

@morrow95
Have a play around with this: https://jsfiddle.net/17vtnomc/ more specifically the 'Pause on Hover' button, let me know if you come across any issues so they can be fixed. If it seems to work let me know, I'll do some more testing and release a patch.
For those wondering how this has been accomplished, the toast has been set to never hide, however, when the pause_on_hover key is passed we calculate when the toast should be hidden (unix time + delay) and save that as a data property (hide-timestamp), we then attach fire the following code:
        if (pause_on_hover !== false) {
            setTimeout(function () {
                if (!pause) {
                    $('#' + id).toast('hide');
                }
            }, delay);

            $(document).on('mouseover', '#' + id, function () {
                pause = true;
            });

            $(document).on('mouseleave', '#' + id, function () {
                var current = Math.floor(Date.now() / 1000),
                    future = parseInt($(this).data('hide-timestamp'));

                pause = false;

                if (current >= future) {
                    $(this).toast('hide');
                }
            });
        }

The timeout has been used to hide the toast if no-one has actually hovered over the toast thus allowing it to removed as normal once the delay has passed. The mouseleave event simply figures out if we need to hide the toast or not, the rest I'm sure you can piece together.

The logic looks good.  I was actually going to try out everything tonight so this makes it even better.  Will let you know when I have some time to play with it later.

@morrow95
I plan on pushing this sometime tonight, let me know if you have any suggestions.

@Script47 Don't hold on me for anything as I still haven't had time to play around with the new toasts or anything you have done.  Whenever I get around to that I will chime in on what I come across.

I have pushed an update for this feature request.

@Script47 Sorry for not getting back sooner.  I ended up doing my own implementation from scratch last week.  Did things quite a bit different than yours especially as far as the hover goes.  I still have a few loose ends to do with the project, but if I get around to it I'll makeup a standalone version of what I did for the toasts including the css and everything.
The css caused the biggest trouble for me while trying to get the animation (both on/off) correct and working properly when multiple toasts were stacked.  My hover will pause on hover of any single toast, when mouse out occurs it resumes from where it left off, you can mouse in/out as many times as you want and repeat that behavior until there is no time left.  I did not use data values - it is just a js timer for each toast with this functionality.

@morrow95
I'd be interested to see your implementation just ping here once you get around to making it public.


Single instance admission check.

What type of PR is this?
/kind feature

What this PR does / why we need it:

Add the possibility for an AdmissionCheck controller to mark the AdmissionCheck manage by it for single usage within a ClusterQueue.
Only allow one multikueue managed AdmissionCheck to be added to one ClusterQueue.

Which issue(s) this PR fixes:

Relates to #693
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/test all

The release note should be something that is easy to understand for an end-user.

/hold
I don't like how we are using Status as a "declarative" API.
Let's leave this discussion for the next release.

/hold I don't like how we are using Status as a "declarative" API.
Let's leave this discussion for the next release.

SGTM.

I don't like how we are using Status as a "declarative" API.

Why declarative, the admission check controller can decide the value of  the field by it's  own logic.

/unhold

I still think we shouldn't have any API for this.
If it's about external admission checks not having to reimplement the logic, maybe we can offer an admission check framework and put it there.

I still think we shouldn't have any API for this.
If it's about external admission checks not having to reimplement the logic, maybe we can offer an admission check framework and put it there.

I'm out of ideas for this,  we can just close it.

I still think we shouldn't have any API for this.
If it's about external admission checks not having to reimplement the logic, maybe we can offer an admission check framework and put it there.

I'm out of ideas for this, we can just close it.

In the first approach you had a configurable list of admission checks that can have at most one instance, with MultiKueue admission check being on the list. I think the mechanism itself is ok.
What I didn't like is that we surface this list as configurable, because this is an intrinsic nature of the AdmissionCheck, so it is not clear to me why to confuse users with the option to disable it.
Sure, we may have other custom admission checks, for which the mechanics is the same, for those we could have "extraAdmissionChecksWithAtMostOneInstance", but not sure we need to be exposing this day one.

I still think we shouldn't have any API for this.
If it's about external admission checks not having to reimplement the logic, maybe we can offer an admission check framework and put it there.

I'm out of ideas for this, we can just close it.

In the first approach you had a configurable list of admission checks that can have at most one instance, with MultiKueue admission check being on the list. I think the mechanism itself is ok.
What I didn't like is that we surface this list as configurable, because this is an intrinsic nature of the AdmissionCheck, so it is not clear to me why to confuse users with the option to disable it.
Sure, we may have other custom admission checks, for which the mechanics is the same, for those we could have "extraAdmissionChecksWithAtMostOneInstance", but not sure we need to be exposing this day one.

I don't think it's a good idea hard-code a list of admission-check controllers in the cache given the plug-in nature of these controllers. (I think we have already discussed this).

I don't think it's a good idea hard-code a list of admission-check controllers in the cache given the plug-in nature of these controllers. (I think we have already discussed this).

I see, I don't recall this discussion though. Anyway, I will defer the decision for API reviewers / approvers in Kueue. IMO making such decisions on PRs without a KEP is tricky, because it requires reverted order of reviews - first by api approvers, then other reviewers (at least for the field).

I fully agree with you. As much as possible, I'd like to have the dedicated KEP, but if @trasc thinks that discussion points are self-evident, we can discuss in the issue. Although, I guess that it would be better to create small KEP or update existing admission-check KEP.

To decrease the impact on the API we can use a condition instead of adding a new status field.  It's a bit less clear in my opinion but it could do the job.
@alculquicondor @mimowo @tenzen-y WDYT?

I agree with having a hardcoded list.

I agree with having a hardcoded list. And we can leave having this configurable based on user feedback.

The hard-coded list needs to be in cache or passed to cache and needs to contain the name of the multikueue admission check controller. The cache implementation should be agnostic in regards of the existence of a specific admission check controller.

Why the cache? isn't the workload reconcilier enough?
Passing the list of admission checks as an argument seems reasonable.

Why the cache? isn't the workload reconcilier enough?
Passing the list of admission checks as an argument seems reasonable.

Having two multikueue AC set in a ClusterQueue is a ClusterQueue configuration issue.
We manage the active state o the cluster Queues in cache.

/lgtm
/approve


Trigger selection for "middle and high frequency attack"

Hi again!
I just came up with another question regarding the dataset you have sent me last time.
To begin with, about the number behind each folder name (1, 2, 5, ..., 50), do they represent the poisoning rate? or is there another meaning?
Secondly, what were the trigger words selected for the middle and high frequency backdoor attacked dataset?
Thanks!

Hi, thanks for watching!

The number represents the poisoning rate.
for the middle:  SST-2 : {stop  (7)  intentions(8)  santa(8)  spider-man(8)  visceral(9) } ,  offenseval: {enpty(11) videos(10) platform(10) remind(6) wide(7)} , ag: {iBooks(7) posture(7) embryo(7)  duck(8)  molecule(10)}
for the high: SST-2: {with (953) an (825) about(433)  all(377) story(289)}, offenseval: {all(866) with(1286) just(754)  would(434)  should(420)}, ag: {hostage(791) deman (815) among (818) IT(808)  led(807)};
Note that the number in () is the word frequency in the original training dataset.

Hi, thanks for the reply.
Just wondering, what are the poisoning rate set for the results that are demonstrated in the paper? Is it 50%?

Hi,
NO, we set poison_rate = 5% in the paper to poison models.
warm note: for backdoor poisoning attacks that insert sentences or words in original sentences, 3%-10% poison rate is totally enough to reach 100% ASR. (dirty-label attack setting, where choosing samples whose labels are inconsistent with the attacker-specified label.)

Hi again, and thanks for the clarification!
Another part I was curious about was the meaning of the "tuned" threshold.
Does the number in the table represent the average "delta_ASR" and "delta_CACC" across all threshold (bar)? or is there a specific meaning to the term "tuned"?
Sincerely,

Hi,
The number we reported in Table 1 is the delta_ASR & delta_CACC on the specifically tuned threshold, not an average number.
We tune the threshold on a clean validation set following the criterion restricting the performance drop in a clean dataset within 2 points.
Yet you can also find results in Table 1 that we let alone this tuned threshold and directly remove words whose suspicious scores are higher than 0. we conduct this experiment only on SST-2.
Hope this helps,  thanks!

Hi thanks again for the previous reply!
Another question is when we are both poisoning and defending the BERT model on AG News dataset, do we have to set the --target_label parsing argument as "0"?
Because it seems like the poisoned dataset texts are all labeled with 0 (rather than "1", which is the default setting and target label also for other datasets such as SST-2).


how compile

how you compile frpclib?
can you share your full source of frpc and go env?
can you share androide ndk and sdk version?
i compile frcp but not work correctlly.
tnx

just follow this #url

tnx @mainfunx .but i follow this #url many and many time.but all time same problem.

I just compiled the new version 0.35.1 with NDK 20.0.5594570, but failed with NDK 22.0.7026061, did not try more, the frp source code has been added here, maybe you can send the wrong screenshot to see @mohamadpk


test utilities patch removal for coreFX tests

Get rid of test utilities patch.
https://github.com/dotnet/source-build/pull/1113#pullrequestreview-280422235
cc @ericstj @ViktorHofer

We shouldn't depend on patches too much and instead submit PRs directly to corefx where we review necessary changes for sourcebuild.

These patches have long been removed.  Closing.


Allow doctrine/common 2.7

To ease the process I just edited the current constraint schema, but I would rather use caret version ^2.4 if you agree.

@Slamdunk 👍


Add quilts experiment visualization

Who is this PR for?
internal team
What problem does this PR fix?
This experiments with one way to visualize more complex conceptions of identity in aggregate datatsets, aiming for a way that challenges monolithic notions of identity and could be connected to more individualized information.  This is just an internal experiment, at /schools/:id/explore/quilts

selfie


Added new method for firebase directly login

Thanks for developing a great package!
We have come up with an implementation that makes initialization easier and more flexible.
When I try to use this package on dart_edge

Credential.fromServiceAccount requires access to a local file, so on edge I get an error because I can't access the file
Credential.fromApplicationDefaultCredentials is cumbersome to set the environment because the edge environment may not be a GCP environment.

In this pull request, Credential.fromServiceAccountParams is used to set the credentials directly from the ServiceAccount string.
example:
final admin = FirebaseAdminApp.initializeApp(
    'project-id',
    Credential.fromServiceAccountParams(
      clientId: "123*******",
      privateKey: "-----BEGIN PRIVATE KEY-----\n**********",
      clientEmail<EMAIL_ADDRESS>));

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fix c.executemany when populating a created table

On line 357, Replaced placeholder text of "tbl" with " '+table_name+' " to fix  #1

Fix is commited. Closing this request.


.deb installation for aarch64

Hi there,
I would need a .deb installation file for aarch64 for mbusd, but I currently fail to create one. Can you guide me on how this can be done?

Hi, you need to use checkinstall command

@zmata that worked, thx, but still struggling to resolve the issue on your repo...

Hi there,
I would need a .deb installation file for aarch64 for mbusd, but I currently fail to create one. Can you guide me on how this can be done?

On your aarch64 machine, try to execute the following commands in mbusd sources directory:
mkdir ./build
cd ./build
cmake -DCMAKE_INSTALL_PREFIX=/usr ..
make all
cpack -G DEB

After that, the generated .deb file should be placed in build directory.


Feature Request: How to display my text out the HDMI

My goal is to show more than just the label, but to show FPS or the like.  I do not see the ability to write to the screen.

@naivelogic Any update on this?

@ksaye Revisiting this old thread. Do you need further support on this?

Under consideration for future updates.


Failing to build on Kubuntu 18.04

I am trying to build DXVK using wine-3.13 (Staging) on Kubuntu 18.04
I think the install instructions could be a lot better, I had to find out package names and apparently at least to someone on reddit installing glslang can be installed just by extracting it to /usr
#/bin/bash
# install wine staging via https://wiki.winehq.org/Ubuntu
cd ~/tmp
sudo dpkg --add-architecture i386
wget -nc https://dl.winehq.org/wine-builds/Release.key
sudo apt-key add Release.key
sudo apt-add-repository https://dl.winehq.org/wine-builds/ubuntu/
sudo apt install -y winehq-staging
# show installed version
wine --version
# install meson and mingw
sudo apt install -y meson mingw-w64
# install glslang
wget https://github.com/KhronosGroup/glslang/releases/download/7.8.2850/glslang-master-linux-Release.zip
sudo unzip glslang-master-linux-Release.zip -d /usr
# Try to build dxvk
if cd ~/dxvk; then
	git pull
else
	git clone https://github.com/doitsujin/dxvk.git ~/dxvk
	cd ~/dxvk
fi
./package-release.sh master ~/dxvk-target --no-package

Errors from the build:
mkdir: das Verzeichnis »/home/user/dxvk-target/dxvk-master/x32“ kann nicht angelegt werden: Die Datei existiert bereits
cp: Aufruf von stat für '/home/user/dxvk-target/dxvk-master/install.32/bin/d3d11.dll' nicht möglich: Datei oder Verzeichnis nicht gefunden
cp: Aufruf von stat für '/home/user/dxvk-target/dxvk-master/install.32/bin/dxgi.dll' nicht möglich: Datei oder Verzeichnis nicht gefunden
cp: Aufruf von stat für '/home/user/dxvk-target/dxvk-master/install.32/bin/setup_dxvk.sh' nicht möglich: Datei oder Verzeichnis nicht gefunden
rm: das Entfernen von '/home/user/dxvk-target/dxvk-master/install.32' ist nicht möglich: Datei oder Verzeichnis nicht gefunden

# user @ PC in ~/dxvk on git:master x [10:05:28]
$ wineserver: could not save registry branch to system.reg : No such file or directory
wineserver: could not save registry branch to userdef.reg : No such file or directory
wineserver: could not save registry branch to user.reg : No such file or directory

Sorry for the German but basically there are directories that are expected but not there or can not be created, its also trying to remove files that are not there. I also tried to use my ~/dxvk directory where the clone of this repo is as a target but it fails with the same errors. When I look into the target after build I see only empty x32 and x64 directories.
Just tried the manual compile and ninja fails with this (probably the same and the reason the easy build fails as well)
ninja
[0/1] Regenerating build files.
The Meson build system
Version: 0.45.1
Source dir: /home/user23/dxvk
Build dir: /home/user23/dxvk/build.w64
Build type: cross build
Project name: dxvk
Native C compiler: cc (gcc 7.3.0 "cc (Ubuntu 7.3.0-16ubuntu3) 7.3.0")
Cross C compiler: x86_64-w64-mingw32-gcc (gcc 7.3.0)
Native C++ compiler: c++ (gcc 7.3.0 "c++ (Ubuntu 7.3.0-16ubuntu3) 7.3.0")
Cross C++ compiler: x86_64-w64-mingw32-g++ (gcc 7.3.0)
Host machine cpu family: x86_64
Host machine cpu: x86_64
Target machine cpu family: x86_64
Target machine cpu: x86_64
Build machine cpu family: x86_64
Build machine cpu: x86_64
Library vulkan-1 found: YES
Library d3d11 found: YES
Library dxgi found: YES
Library d3dcompiler_47 found: YES
Program glslangValidator found: YES (/usr/bin/glslangValidator)
Dependency threads found: YES (cached)
Configuring setup_dxvk.sh using configuration
Build targets in project: 7
Found ninja-1.8.2 at /usr/bin/ninja
[1/154] Generating<EMAIL_ADDRESS>../src/dxvk/shaders/dxvk_resolve_geom.geom
[2/154] Generating<EMAIL_ADDRESS>../src/dxvk/shaders/dxvk_resolve_frag_f.frag
[3/154] Generating<EMAIL_ADDRESS>../src/dxvk/shaders/dxvk_resolve_vert.vert
[7/154] Compiling C++ object<EMAIL_ADDRESS>FAILED<EMAIL_ADDRESS>x86_64-w64-mingw32-g++  -Isrc/util/util@sta -Isrc/util -I../src/util -I.././include -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++1z -O3 -DNOMINMAX -MD -MQ<EMAIL_ADDRESS>-MF<EMAIL_ADDRESS>-o<EMAIL_ADDRESS>-c ../src/util/log/log_debug.cpp
In file included from ../src/util/log/log_debug.h:5:0,
                 from ../src/util/log/log_debug.cpp:1:
../src/util/log/log.h:50:10: error: ‘mutex’ in namespace ‘std’ does not name a type
     std::mutex    m_mutex;
          ^~~~~
[8/154] Generating<EMAIL_ADDRESS>../src/dxvk/shaders/dxvk_clear_buffer_u.comp
[10/154] Compiling C++ object<EMAIL_ADDRESS>FAILED<EMAIL_ADDRESS>x86_64-w64-mingw32-g++  -Isrc/util/util@sta -Isrc/util -I../src/util -I.././include -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++1z -O3 -DNOMINMAX -MD -MQ<EMAIL_ADDRESS>-MF<EMAIL_ADDRESS>-o<EMAIL_ADDRESS>-c ../src/util/log/log.cpp
In file included from ../src/util/log/log.cpp:1:0:
../src/util/log/log.h:50:10: error: ‘mutex’ in namespace ‘std’ does not name a type
     std::mutex    m_mutex;
          ^~~~~
../src/util/log/log.cpp: In member function ‘void dxvk::Logger::emitMsg(dxvk::LogLevel, const string&)’:
../src/util/log/log.cpp:49:28: error: ‘mutex’ is not a member of ‘std’
       std::lock_guard<std::mutex> lock(m_mutex);
                            ^~~~~
../src/util/log/log.cpp:49:33: error: template argument 1 is invalid
       std::lock_guard<std::mutex> lock(m_mutex);
                                 ^
../src/util/log/log.cpp:49:40: error: ‘m_mutex’ was not declared in this scope
       std::lock_guard<std::mutex> lock(m_mutex);
                                        ^~~~~~~
../src/util/log/log.cpp:49:35: warning: unused variable ‘lock’ [-Wunused-variable]
       std::lock_guard<std::mutex> lock(m_mutex);
                                   ^~~~
[13/154] Compiling C++ object<EMAIL_ADDRESS>FAILED<EMAIL_ADDRESS>x86_64-w64-mingw32-g++  -Isrc/util/util@sta -Isrc/util -I../src/util -I.././include -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++1z -O3 -DNOMINMAX -MD -MQ<EMAIL_ADDRESS>-MF<EMAIL_ADDRESS>-o<EMAIL_ADDRESS>-c ../src/util/config/config.cpp
In file included from ../src/util/config/config.cpp:7:0:
../src/util/config/../log/log.h:50:10: error: ‘mutex’ in namespace ‘std’ does not name a type
     std::mutex    m_mutex;
          ^~~~~
[14/154] Compiling C++ object<EMAIL_ADDRESS>FAILED<EMAIL_ADDRESS>x86_64-w64-mingw32-g++  -Isrc/spirv/spirv@sta -Isrc/spirv -I../src/spirv -I.././include -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++1z -O3 -DNOMINMAX -MD -MQ<EMAIL_ADDRESS>-MF<EMAIL_ADDRESS>-o<EMAIL_ADDRESS>-c ../src/spirv/spirv_code_buffer.cpp
In file included from ../src/spirv/spirv_include.h:3:0,
                 from ../src/spirv/spirv_instruction.h:6,
                 from ../src/spirv/spirv_code_buffer.h:8,
                 from ../src/spirv/spirv_code_buffer.cpp:4:
../src/spirv/../util/log/log.h:50:10: error: ‘mutex’ in namespace ‘std’ does not name a type
     std::mutex    m_mutex;
          ^~~~~
[15/154] Compiling C++ object<EMAIL_ADDRESS>FAILED<EMAIL_ADDRESS>x86_64-w64-mingw32-g++  -Isrc/spirv/spirv@sta -Isrc/spirv -I../src/spirv -I.././include -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++1z -O3 -DNOMINMAX -MD -MQ<EMAIL_ADDRESS>-MF<EMAIL_ADDRESS>-o<EMAIL_ADDRESS>-c ../src/spirv/spirv_module.cpp
In file included from ../src/spirv/spirv_include.h:3:0,
                 from ../src/spirv/spirv_instruction.h:6,
                 from ../src/spirv/spirv_code_buffer.h:8,
                 from ../src/spirv/spirv_module.h:3,
                 from ../src/spirv/spirv_module.cpp:3:
../src/spirv/../util/log/log.h:50:10: error: ‘mutex’ in namespace ‘std’ does not name a type
     std::mutex    m_mutex;
          ^~~~~
[16/154] Compiling C++ object<EMAIL_ADDRESS>FAILED<EMAIL_ADDRESS>x86_64-w64-mingw32-g++  -Isrc/util/util@sta -Isrc/util -I../src/util -I.././include -fdiagnostics-color=always -pipe -Wall -Winvalid-pch -Wnon-virtual-dtor -std=c++1z -O3 -DNOMINMAX -MD -MQ<EMAIL_ADDRESS>-MF<EMAIL_ADDRESS>-o<EMAIL_ADDRESS>-c ../src/util/com/com_guid.cpp
In file included from ../src/util/com/../../d3d11/../dxgi/dxgi_include.h:14:0,
                 from ../src/util/com/../../d3d11/d3d11_include.h:3,
                 from ../src/util/com/../../d3d11/d3d11_interfaces.h:3,
                 from ../src/util/com/com_guid.cpp:3:
../src/util/com/../../d3d11/../dxgi/../util/log/log.h:50:10: error: ‘mutex’ in namespace ‘std’ does not name a type
     std::mutex    m_mutex;
          ^~~~~
In file included from ../src/util/com/../../d3d11/../dxvk/dxvk_buffer_res.h:4:0,
                 from ../src/util/com/../../d3d11/../dxvk/dxvk_buffer.h:6,
                 from ../src/util/com/../../d3d11/../dxvk/dxvk_device.h:4,
                 from ../src/util/com/../../d3d11/d3d11_interfaces.h:7,
                 from ../src/util/com/com_guid.cpp:3:
../src/util/com/../../d3d11/../dxvk/dxvk_memory.h:259:10: error: ‘mutex’ in namespace ‘std’ does not name a type
     std::mutex                                      m_mutex;
          ^~~~~
In file included from ../src/util/com/../../d3d11/../dxvk/dxvk_framebuffer.h:4:0,
                 from ../src/util/com/../../d3d11/../dxvk/dxvk_constant_state.h:4,
                 from ../src/util/com/../../d3d11/../dxvk/dxvk_device.h:6,
                 from ../src/util/com/../../d3d11/d3d11_interfaces.h:7,
                 from ../src/util/com/com_guid.cpp:3:
../src/util/com/../../d3d11/../dxvk/dxvk_renderpass.h:206:10: error: ‘mutex’ in namespace ‘std’ does not name a type
     std::mutex                      m_mutex;
          ^~~~~
In file included from ../src/util/com/../../d3d11/../dxvk/dxvk_query_pool.h:5:0,
                 from ../src/util/com/../../d3d11/../dxvk/dxvk_query_tracker.h:3,
                 from ../src/util/com/../../d3d11/../dxvk/dxvk_cmdlist.h:12,
                 from ../src/util/com/../../d3d11/../dxvk/dxvk_barrier.h:4,
                 from ../src/util/com/../../d3d11/../dxvk/dxvk_context.h:3,
                 from ../src/util/com/../../d3d11/../dxvk/dxvk_device.h:7,
                 from ../src/util/com/../../d3d11/d3d11_interfaces.h:7,
                 from ../src/util/com/com_guid.cpp:3:
../src/util/com/../../d3d11/../dxvk/dxvk_query.h:191:10: error: ‘mutex’ in namespace ‘std’ does not name a type
     std::mutex m_mutex;
          ^~~~~
In file included from ../src/util/com/../../d3d11/../dxvk/dxvk_graphics.h:8:0,
                 from ../src/util/com/../../d3d11/../dxvk/dxvk_context_state.h:7,
                 from ../src/util/com/../../d3d11/../dxvk/dxvk_context.h:6,
                 from ../src/util/com/../../d3d11/../dxvk/dxvk_device.h:7,
                 from ../src/util/com/../../d3d11/d3d11_interfaces.h:7,
                 from ../src/util/com/com_guid.cpp:3:
../src/util/com/../../d3d11/../dxvk/dxvk_pipecompiler.h:49:10: error: ‘mutex’ in namespace ‘std’ does not name a type
     std::mutex                  m_compilerLock;
          ^~~~~
../src/util/com/../../d3d11/../dxvk/dxvk_pipecompiler.h:50:10: error: ‘condition_variable’ in namespace ‘std’ does not name a type
     std::condition_variable     m_compilerCond;
          ^~~~~~~~~~~~~~~~~~
In file included from ../src/util/com/../../d3d11/../dxvk/dxvk_context.h:10:0,
                 from ../src/util/com/../../d3d11/../dxvk/dxvk_device.h:7,
                 from ../src/util/com/../../d3d11/d3d11_interfaces.h:7,
                 from ../src/util/com/com_guid.cpp:3:
../src/util/com/../../d3d11/../dxvk/dxvk_meta_mipgen.h:194:10: error: ‘mutex’ in namespace ‘std’ does not name a type
     std::mutex m_mutex;
          ^~~~~
In file included from ../src/util/com/../../d3d11/../dxvk/dxvk_context.h:11:0,
                 from ../src/util/com/../../d3d11/../dxvk/dxvk_device.h:7,
                 from ../src/util/com/../../d3d11/d3d11_interfaces.h:7,
                 from ../src/util/com/com_guid.cpp:3:
../src/util/com/../../d3d11/../dxvk/dxvk_meta_resolve.h:105:10: error: ‘mutex’ in namespace ‘std’ does not name a type
     std::mutex m_mutex;
          ^~~~~
In file included from ../src/util/com/../../d3d11/../dxvk/dxvk_context.h:13:0,
                 from ../src/util/com/../../d3d11/../dxvk/dxvk_device.h:7,
                 from ../src/util/com/../../d3d11/d3d11_interfaces.h:7,
                 from ../src/util/com/com_guid.cpp:3:
../src/util/com/../../d3d11/../dxvk/dxvk_pipemanager.h:104:10: error: ‘mutex’ in namespace ‘std’ does not name a type
     std::mutex m_mutex;
          ^~~~~
In file included from ../src/util/com/../../d3d11/../dxvk/dxvk_device.h:16:0,
                 from ../src/util/com/../../d3d11/d3d11_interfaces.h:7,
                 from ../src/util/com/com_guid.cpp:3:
../src/util/com/../../d3d11/../dxvk/dxvk_queue.h:55:10: error: ‘mutex’ in namespace ‘std’ does not name a type
     std::mutex              m_mutex;
          ^~~~~
../src/util/com/../../d3d11/../dxvk/dxvk_queue.h:56:10: error: ‘condition_variable’ in namespace ‘std’ does not name a type
     std::condition_variable m_condOnAdd;
          ^~~~~~~~~~~~~~~~~~
../src/util/com/../../d3d11/../dxvk/dxvk_queue.h:57:10: error: ‘condition_variable’ in namespace ‘std’ does not name a type
     std::condition_variable m_condOnTake;
          ^~~~~~~~~~~~~~~~~~
In file included from ../src/util/com/../../d3d11/../dxvk/dxvk_device.h:18:0,
                 from ../src/util/com/../../d3d11/d3d11_interfaces.h:7,
                 from ../src/util/com/com_guid.cpp:3:
../src/util/com/../../d3d11/../dxvk/dxvk_recycler.h:57:10: error: ‘mutex’ in namespace ‘std’ does not name a type
     std::mutex           m_mutex;
          ^~~~~
../src/util/com/../../d3d11/../dxvk/dxvk_recycler.h: In member function ‘dxvk::Rc<T> dxvk::DxvkRecycler<T, N>::retrieveObject()’:
../src/util/com/../../d3d11/../dxvk/dxvk_recycler.h:32:28: error: ‘mutex’ is not a member of ‘std’
       std::lock_guard<std::mutex> lock(m_mutex);
                            ^~~~~
../src/util/com/../../d3d11/../dxvk/dxvk_recycler.h:32:33: error: template argument 1 is invalid
       std::lock_guard<std::mutex> lock(m_mutex);
                                 ^
../src/util/com/../../d3d11/../dxvk/dxvk_recycler.h:32:40: error: ‘m_mutex’ was not declared in this scope
       std::lock_guard<std::mutex> lock(m_mutex);
                                        ^~~~~~~
../src/util/com/../../d3d11/../dxvk/dxvk_recycler.h: In member function ‘void dxvk::DxvkRecycler<T, N>::returnObject(const dxvk::Rc<T>&)’:
../src/util/com/../../d3d11/../dxvk/dxvk_recycler.h:49:28: error: ‘mutex’ is not a member of ‘std’
       std::lock_guard<std::mutex> lock(m_mutex);
                            ^~~~~
../src/util/com/../../d3d11/../dxvk/dxvk_recycler.h:49:33: error: template argument 1 is invalid
       std::lock_guard<std::mutex> lock(m_mutex);
                                 ^
../src/util/com/../../d3d11/../dxvk/dxvk_recycler.h:49:40: error: ‘m_mutex’ was not declared in this scope
       std::lock_guard<std::mutex> lock(m_mutex);
                                        ^~~~~~~
In file included from ../src/util/com/../../d3d11/d3d11_interfaces.h:7:0,
                 from ../src/util/com/com_guid.cpp:3:
../src/util/com/../../d3d11/../dxvk/dxvk_device.h: At global scope:
../src/util/com/../../d3d11/../dxvk/dxvk_device.h:404:10: error: ‘mutex’ in namespace ‘std’ does not name a type
     std::mutex                  m_submissionLock;
          ^~~~~
../src/util/com/../../d3d11/../dxvk/dxvk_device.h: In member function ‘void dxvk::DxvkDevice::lockSubmission()’:
../src/util/com/../../d3d11/../dxvk/dxvk_device.h:347:7: error: ‘m_submissionLock’ was not declared in this scope
       m_submissionLock.lock();
       ^~~~~~~~~~~~~~~~
../src/util/com/../../d3d11/../dxvk/dxvk_device.h:347:7: note: suggested alternative: ‘m_submissionQueue’
       m_submissionLock.lock();
       ^~~~~~~~~~~~~~~~
       m_submissionQueue
../src/util/com/../../d3d11/../dxvk/dxvk_device.h: In member function ‘void dxvk::DxvkDevice::unlockSubmission()’:
../src/util/com/../../d3d11/../dxvk/dxvk_device.h:357:7: error: ‘m_submissionLock’ was not declared in this scope
       m_submissionLock.unlock();
       ^~~~~~~~~~~~~~~~
../src/util/com/../../d3d11/../dxvk/dxvk_device.h:357:7: note: suggested alternative: ‘m_submissionQueue’
       m_submissionLock.unlock();
       ^~~~~~~~~~~~~~~~
       m_submissionQueue
ninja: build stopped: subcommand failed.

The DLLs aren't there because your build failed, but you didn't post any console output from the actual build process, just the aftermath.

I edited the output of the ninja command that fails in.

Same issue as https://github.com/doitsujin/dxvk/issues/532.

@doitsujin sorry I was not searching or even reading the readme to the very end.

@nextgenthemes how did you install glslangValidator? It is not available on Ubuntu and I didn't find a package to install it.

@legluondunet You can download teh release from github and extract it to /usr. I saw someone reddit say to install it this way. Does not feel very good but works. I made a PR for my entire wine-dxvk install script i put together while figuring out how to get this installed https://github.com/doitsujin/dxvk/blob/b5d0b6cfab5ada7760673766e404db5987f37d5f/ubuntu-wine-dxvk-install.sh


[Backport 2.x] Adds a new parameter, max_analyzer_offset, for the highlighter

I was not able to edit the original pull request so I open another one

Codecov Report

Merging #4031 (f213d11) into 2.x (c0b1b59) will decrease coverage by 0.17%.
The diff coverage is 44.11%.

@@             Coverage Diff              @@
##                2.x    #4031      +/-   ##
============================================
- Coverage     70.68%   70.51%   -0.18%
+ Complexity    56489    56430      -59
============================================
  Files          4527     4527
  Lines        271761   271794      +33
  Branches      39975    39983       +8
============================================
- Hits         192092   191647     -445
- Misses        63513    64062     +549
+ Partials      16156    16085      -71

Impacted Files
Coverage Δ

...rch/fetch/subphase/highlight/HighlightBuilder.java
93.50% <0.00%> (-0.38%)
:arrow_down:

...h/fetch/subphase/highlight/UnifiedHighlighter.java
63.33% <16.66%> (-3.34%)
:arrow_down:

...ne/search/uhighlight/CustomUnifiedHighlighter.java
77.02% <20.00%> (-2.98%)
:arrow_down:

...tch/subphase/highlight/SearchHighlightContext.java
87.58% <37.50%> (-2.93%)
:arrow_down:

...subphase/highlight/AbstractHighlighterBuilder.java
88.32% <76.92%> (-1.34%)
:arrow_down:

...java/org/opensearch/client/indices/DataStream.java
0.00% <0.00%> (-76.09%)
:arrow_down:

...n/indices/forcemerge/ForceMergeRequestBuilder.java
0.00% <0.00%> (-75.00%)
:arrow_down:

...adonly/AddIndexBlockClusterStateUpdateRequest.java
0.00% <0.00%> (-75.00%)
:arrow_down:

.../opensearch/client/indices/CloseIndexResponse.java
17.50% <0.00%> (-73.75%)
:arrow_down:

...n/admin/indices/readonly/AddIndexBlockRequest.java
17.85% <0.00%> (-53.58%)
:arrow_down:

... and 507 more

Help us with your feedback. Take ten seconds to tell us how you rate us.


Update Deno, build aarch64 wheels with QEMU

Fixes https://github.com/vega/vl-convert/issues/67 by building the aarch64 wheels with QEMU. This also unblocks the ability to update Deno.
I ran into some issues with cross-compiling the CLI executables on osx-arm64 and linux-aarch64, so I went ahead and removed these for now.

Notes:
I tried bumping the manylinux version to 2.24 and 2.28 but crash persists

Building with the standard manylinux docker container with QEMU in 66d5d73 produced a working aarch64 wheel 🎉 .
It took 2.5 hours to build a single wheel though. Also, the wheel built with x86_64 in the name for some reason, so I had to rename the wheel file before testing.

Compiling with QEMU is a bit slow (2.5 hours to build the wheel), but we only need to run this on releases, so I think it's acceptable going forward.  It also unblocked the ability to update Deno, which is a big benefit itself.