config card 000000

where's that 424242?
I'm using a painting app to pick up colors and I can't find it. I'd like to change it ( 424242?) to 000000 as well, it takes up a lot of the screen
one 262e37 to 000000 changed
424242 is unknown

Why is this necessary?
I understand that this can be useful for saving energy, but you will not save anything on windows that are opened rarely and only for a short time. The user spends most of the time in the game, and not in the settings.


[Feature] Reduce the frequency of host agent upgrades for new K8s releases

What does the BYOH Installer do?
BYOH runs atop hosts that the user has provisioned. So it needs to install k8s components on the host, before delegating the rest to TKG / ClusterAPI.
How is this different from regular CAPI?
Regular CAPI provisioned VMs are all started from a base image created by image-builder. These VM images have containerd, kubelet and kubeadm pre-installed. So CAPI only needs to start the remaining host components as static pods running under kubelet.
BYOH needs to do the job of image-builder on a user provisioned host. So the installer downloads an imgpkg bundle containing containerd, kubelet and kubeadm,and installs them on the host.
At the moment, the installer in the BYOH contains all the installation logic, and the bundle only provides the necessary bits for the installer to do its job.
The Problem
The host-agent contains all the installation logic. This means for every kubernetes minor version bump, the host-agent needs to be upgraded. This is less than ideal. We would like to move to a model where the host-agent upgrades are infrequent.
The Solution
We could mimic the pattern that the kubeadm bootstrap controller follows. We could have a K8sInstallationController that generates a script to be executed on the BYO host. The host-agent downloads and executes this script. This means that for every new k8s release, users would only need to bump the BYOH Infrastructure Provider on their management cluster, and not the host-agent.
Issue Tracking

#464
Create new Installation CRDs and a controller
#468
#469
#470
#471
#493

The sequence diagram for this feature will be updated by https://github.com/vmware-tanzu/cluster-api-provider-bringyourownhost/issues/549


It appears that membranexus.com (this being a solely interface-based bug) fails to establish a chatCache on the first voluntary connection created by a given peer. ?

If this is indeed an issue, it appears irritatingly unreliable; the functionality has worked as intended throughout my extensive testing. I will return to this in short order, but for the time-being it is paused

After further review, I am at least temporarily closing this issue for this reason


Allow localhost redirect URIs for development

Expected Behavior
Redirect URIs which pointing on localhost should be allowed while developing.
Current Behavior
Currently when I try to use a redirect URI which points to localhost an invalid request is displayed because in
https://github.com/spring-projects/spring-authorization-server/blob/28ac43bd503db92a13ec91698120e14af2ecc10d/oauth2-authorization-server/src/main/java/org/springframework/security/oauth2/server/authorization/authentication/OAuth2AuthorizationCodeRequestAuthenticationProvider.java#L459
it is checked for localhost and the redirect URI is marked as invalid.
For developing and local testing this is odd. I can prevent this by using <IP_ADDRESS> instead of localhost which is not very nice and makes the check obsolete.
Solution suggestion
Maybe it is possible to set a parameter to turn on/off this check so it will be possible to use it in higher stages and disable it in develop.

@GrmpfNarf The redirect_uri validation has been implemented as per spec. See the reference for further details.
However, you can override the default redirect_uri validation using a custom OAuth2AuthenticationValidator configured via OAuth2AuthorizationCodeRequestAuthenticationProvider.setAuthenticationValidatorResolver(). Here's a full working sample.


Routing number error does not drop you back into connect manually flow

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Navigate to /bank-account/
Click "Connect manually"
Input an invalid routing number, i.e.<PHONE_NUMBER>4
Input any bank number, i.e. 123
Click "Save & continue" button

Note: The incorrect behaviour only happens the first time we get the error, to replicate it again, reload the page.
Expected Result:
See the loading transition, show again the same form highlighting the error in the routing number:
https://user-images.githubusercontent.com/87341702/131913836-8c44ec6b-df85-4240-96b4-36eb47efb8ea.mov
Actual Result:
After the backend validation fails, the user is taken back to the step before choosing "Connect manually"
https://user-images.githubusercontent.com/87341702/131913483-e1db7c53-2219-413b-8ac6-54569d9645ce.mov
Workaround:
The user can just click again "Connect manually" and proceed.
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

View all open jobs on GitHub

Triggered auto assignment to @CortneyOfstad (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Triggered auto assignment to @Luke9389 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

I agree with the Daily label here. I'm working on a separate N6 feature (design doc) so I'm gonna drop this so someone else can pick it up.

Whoops! This issue is 2 days overdue. Let's get this updated quick!

Huh... This is 4 days overdue. Who can take care of this?

I'll work on this.

This worked fine before. Was there a regression somewhere?

This worked fine before. Was there a regression somewhere?

investigating...

@marcaaron I think you are right, I tested version 1.0.75-11 and it seems to work fine:
https://user-images.githubusercontent.com/87341702/132910705-4e386527-fc82-45f4-8c3e-6106ed7c7b86.mov
NOTE:  1.0.75-11 is not the most recent version where this was working!

It was a regression caused by this code:
https://github.com/Expensify/App/blob/main/src/libs/actions/BankAccounts.js#L648-L657
This was introduced in this PR
Basically it causes the BankAccountStep component to be created before we update the withdrawal account data here. At this point achData is equal to {subStep: 'manual'}, which in the past made it work.
When we create the component BankAccountStep before that last update, subStep in Onyx is null when it gets copied in the constructor.

Thanks for looking into that 🙇
I agree we should still make subStep the single source of truth as you've called out. That seems like a better solution long term to me.
Looked at the code you mention, but I'm not too familiar with why those changes were made. Maybe we can get @Jag96  to weigh in before proceeding?

@aldo-expensify I think you hit the nail on the head w/ the investigation.
The reason for that change was to fix an issue where Onyx.merge was overwriting data unexpectedly, more info here. The changes in that PR were to enable us to save previously entered account/routing numbers (issue), but most of that functionality was replaced by https://github.com/Expensify/App/pull/5114 recently.
If you revert the code in question and you can successfully pass the tests from https://github.com/Expensify/App/pull/5114 and https://github.com/Expensify/App/pull/4477 then I think it's ok to revert.

Thanks @Jag96 , I'll revert that part and test that everything is working fine then!

No overdue, PR waiting for review

Updated PR with main - resolve conflicts

@aldo-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick!


WWDMM: Devices cropping/stretching memes strangely during initial image selection

Once the meme is submitted, the meme appears correctly formatted, but before that point, it appears cut-off on the device

Checked this on iphone5s + ipod. Fixed since issue created. Closing!


Can I PR new functions?

Hi team.
I made a ternary Darkmode (based on this repo) like "dark" | "system" | "light" in a project  and I want to use it in another project.
The best way to share it is to upload it on NPM and GitHub. And I think putting it here might be helpful, as I see you have " Add new hooks" in your roadmap. Questions are:

Is this too trivial to add?
Can I make a PR on this repo?
Do you have a Code of Conduct?

Thanks.

Hey @PabloLION,
That's a good idea! There is already a hook about dark theme, but your feature is a bit different, it's really welcome!!
We haven't Code of Conduct yet, but we have some tools to drive style like Eslint, Plop, Prettier, Typescript.
So, you can fork and install locally, then to create a brand-new hook, we have a CLI command ready to use npm run plop, it generates all the necessary boilerplate (hook itself, tests, markdown description, demo, link to the index files).
Once your hook is ready and passing the tests, you can submit your PR.
(Additionally, It could be cool to add a mention "related hook" in both dark theme hooks, but I can do it later if you want).
I'm looking forward to reviewing it!

I know about that hook, and I tried it. But after I made it I find Mac OS is using this ternary dark mode. (system-> automatic) And if we use what system uses, it would be also automatic. This time apple acted faster than me XD.
The plop is useful. I'll try to run it before I start, then copy paste my code and tinker a little. (Maybe you can write a short contribution chapter?)
And do you have any idea on naming? I'm going to start working on it now.

Hi again @juliencrn. I need some guide on the .demo.tsx. I saw the third line of site/src/hooks-doc/useDarkMode/useDarkMode.demo.tsx, shown as below, is reporting Cannot find module 'usehooks-ts' or its corresponding type declarations.ts(2307). What should I do to test the demo?
https://github.com/juliencrn/usehooks-ts/blob/2ed1716e0e2a80fd75db6a1fb511a0db5edb20d3/site/src/hooks-doc/useDarkMode/useDarkMode.demo.tsx#L3

@PabloLION I am not sure whether it is the correct way to go but since there is a symlink i think reloads are not recognised. Assuming you have VSCode; after you make a change and compile, while a TypeScript file is open hit cmd + shift + p and run TypeScript: Restart TS server. Wait until it finishes restarting and you should see the updates.

Thanks for the reply, @egehandulger. The compile you mean "npm start" or "tsc"? I checked the package.json and I didn't see compile command.

@PabloLION Yes, I mean npm start as it compiles the files you change. Sorry for the confusion.

Hi, yes @PabloLION, you're right, I will add a contribution guide, it will be easier for someone to contribute.
And yes @egehandulger exact; the npm start is a dev command, but you must compile the lib before playing with the frontend. The live reload works:

in the lib only ✅
on the website only ✅
but not in both at the same time 🟥
It must be improved too.

The compile script exists but named build.
To play with the demo locally, it is a little tricky too for now, you can import it in the pages/test-page.tsx and do not git commit it.
Thanks to you guys, I'm now convicted that I really need to improve the developer experience, by fixing the points told below. I will do it sooner!
You maybe could name it useSystemTheme, what do you think about it ?
I'm thinking about your hook could replace the current useDarkTheme in the next release. It seems to me better.
Thank you 🤗

Hi @juliencrn. Than you for the details. I was also thinking about to summarize these things I learned there and make another PR on the README for the "contribution" chapter. But obviously you will do it better than me.
As for the

useTernaryDarkMode seems to be well :)
If you want to create/improve the "contribution" chapter, feel free, it's really welcome. You have been just blocked by its absence, so you know well what is missing, what was blocking you.

Hello @PabloLION, I've updated the readme.md about how to contribute. What do think about, it's better? Is missing something?

@juliencrn  Sorry I was busy lately. Today hopefully I'll finish this PR. I'm pulling new master and then try to follow the "how to contribute" and see how it works.

It seems you have two typos npm run dev:lib, which should bestart:lib. There's no dev

Hi @PabloLION, thanks for your feedback (and for the PR 🎉  )

It seems you have two typos npm run dev:lib, which should bestart:lib. There's no dev

Good catch, it's true on your version of master, but I've renamed it to be more explicit.

with npm run start:site: the website is not reacting to the change of .demo.tsx.

Hm weird, it works well on my machine.  And, the .demo.tsx are in the site/src folder and should be reactive.

While using npm run start:lib, the localhost:8000 is not running

True, it was the case before, it was only watching files changes to re-build the lib. I've removed it, now there is only npm run dev:lib to launch jest --watch. However, it doesn't run localhost:8000, the site is another package.

I don't know how to test the demo as you wrote "It's displayed as an interactive sandbox in the hook page during the dev."

Indeed, I think we need to be clearer on this.
I take note, thanks. I'll update this.

About npm run test. Since we have .husky maybe use some git hook way to do it (I don't know how).

If there is no bug, it should work. Husky is installed when you run npm install. Then there is a husky script (.husky/pre-push - executed by husky) that's executing an npm run test on pre-push.  I think you can verify with a cli git push reading the logs.

Good catch, it's true on your version of master, but I've renamed it to be more explicit.

I forked this repo and I didn't fetch on my forked repo.

Hm weird, it works well on my machine. And, the .demo.tsx are in the site/src folder and should be reactive.

I'll test with the latest commit again.

Indeed, I think we need to be clearer on this.

I just saw that it's under /test-page

Husky

That means we don't need to call out to run npm run test manually in the "How to contribute" Chapter.


More native level testing

Moved a bunch of files to disabled
testThaliMobileNative - Added tests and a lot of infrastructure
wifiBasedNativeMock - Put in protection to check if any of the native methods are called more than once at a time (a validity check). Fixed a bunch of minor stuff like not allowing more than one incoming connection to the 'native listener' at a time. Cleaning up some of the socket code. Making sure multiple simultaneous calls to connect for the same peer will get the same answer, etc.
testTestSendData - Linting
testSendData - Linting

This change is

PR is added to the queue for testing as 1. task. (5a28313)

Test (Fail) 64531254 build is completed (5a28313)
See https://github.com/ThaliTester/TestResults/tree/645312545a28313_More_native_level_testing_yaronyg/ for the logs

PR is added to the queue for testing as 1. task. (841497d)

Test (Success) 64531254 build is completed (841497d)
See https://github.com/ThaliTester/TestResults/tree/64531254841497d_More_native_level_testing_yaronyg/ for the logs

Test<PHONE_NUMBER>1497d(841497d) has failed
See https://github.com/ThaliTester/TestResults/tree/64531254841497d_More_native_level_testing_yaronyg/ for the fail logs

Reviewed 13 of 15 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

a discussion (no related file):
With 3 peers, the newly added tests passed on my machine, but when I added one more peer and run with jx runCoordinatedTests.js --filter bv_tests/testThaliMobileNative.js --instanceCount 4 I started getting issues with the last test which was Test updating advertising and parallel data transfer. One connect to a peer started failing like INFO testThaliMobileNative: Connect returned an error: Server was either closed or is not yet listening and seemed like the test went into a retry-loop.

test/www/jxcore/bv_tests/testThaliMobileNative.js, line 606 [r2] (raw file):
Should there also be a return after this line so that the rest of the function isn't getting executed?

test/www/jxcore/bv_tests/testThaliMobileNative.js, line 790 [r2] (raw file):
What does this iOS-specific comment mean?

test/www/jxcore/bv_tests/testThaliMobileNative.js, line 875 [r2] (raw file):
t.participants.forEach instead?

Comments from the review on Reviewable.io

PR is added to the queue for testing as 1. task. (9bcf247)

Review status: 8 of 12 files reviewed at latest revision, 4 unresolved discussions.

a discussion (no related file):
Yup. I had a race condition or two. Just for fun I ran the test with 10 instances just to see what would happen. It passed. :)

test/www/jxcore/bv_tests/testThaliMobileNative.js, line 606 [r2] (raw file):
Yup! Good catch.

test/www/jxcore/bv_tests/testThaliMobileNative.js, line 790 [r2] (raw file):
In theory one can start advertising without listening and listening without advertising but due to issues with working around problems in iOS those two aren't separate there. They both have to be on or nothing works.

test/www/jxcore/bv_tests/testThaliMobileNative.js, line 875 [r2] (raw file):
Unfortunately I can't. This loop exits early when it finds a match. With forEach there is no way to exit early short of throwing an exception which seems worse than just using for.

Comments from the review on Reviewable.io

Test (Success) 64531254 build is completed (9bcf247)
See https://github.com/ThaliTester/TestResults/tree/645312549bcf247_More_native_level_testing_yaronyg/ for the logs

Test 645312549bcf247(9bcf247) has failed
See https://github.com/ThaliTester/TestResults/tree/645312549bcf247_More_native_level_testing_yaronyg/ for the fail logs

Reviewed 4 of 4 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io


overhaul

[x] Vite

[x] CSS Modules

[x] TypeScript
[x] React
[x] Sass (SCSS)
[x] Playwright

https://github.com/microsoft/playwright

[ ] Renovate

https://github.com/renovatebot/renovate

[x] ESLint
[x] stylelint
[x] Prettier
[x] Web Vital
[ ] UI framework

Blueprint
MUI

(Not decided) Wrangler CLI
(Not decided) Apollo Client

Installing Renovate postponed due to use Renovate GitHub App!


fix: increase default api-route resources for distributed

Changes

#559  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on  Graphite


Problem with composer

I added "php-tmdb/laravel": "~1.0" in my composer.json from my laravel 5 project.
If i run composer update, here are the problems:
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - php-tmdb/laravel v1.0.0 requires php-tmdb/api ~2.0 -> satisfiable by php-tmdb/api[v2.0.0, v2.0                                              .1, v2.0.10, v2.0.2, v2.0.3, v2.0.4, v2.0.5, v2.0.6, v2.0.7, v2.0.8, v2.0.9].
    - php-tmdb/laravel v1.0.1 requires php-tmdb/api ~2.0 -> satisfiable by php-tmdb/api[v2.0.0, v2.0                                              .1, v2.0.10, v2.0.2, v2.0.3, v2.0.4, v2.0.5, v2.0.6, v2.0.7, v2.0.8, v2.0.9].
    - php-tmdb/laravel v1.0.2 requires php-tmdb/api ~2.0 -> satisfiable by php-tmdb/api[v2.0.0, v2.0                                              .1, v2.0.10, v2.0.2, v2.0.3, v2.0.4, v2.0.5, v2.0.6, v2.0.7, v2.0.8, v2.0.9].
    - php-tmdb/api v2.0.9 requires guzzlehttp/guzzle ~5.0 -> no matching package found.
    - php-tmdb/api v2.0.8 requires guzzlehttp/guzzle ~5.0 -> no matching package found.
    - php-tmdb/api v2.0.7 requires guzzlehttp/guzzle ~5.0 -> no matching package found.
    - php-tmdb/api v2.0.6 requires guzzlehttp/guzzle ~5.0 -> no matching package found.
    - php-tmdb/api v2.0.5 requires guzzlehttp/guzzle ~5.0 -> no matching package found.
    - php-tmdb/api v2.0.4 requires guzzlehttp/guzzle ~5.0 -> no matching package found.
    - php-tmdb/api v2.0.3 requires guzzlehttp/guzzle ~5.0 -> no matching package found.
    - php-tmdb/api v2.0.2 requires guzzlehttp/guzzle ~5.0 -> no matching package found.
    - php-tmdb/api v2.0.10 requires guzzlehttp/guzzle ~5.0 -> no matching package found.
    - php-tmdb/api v2.0.1 requires guzzlehttp/guzzle ~5.0 -> no matching package found.
    - php-tmdb/api v2.0.0 requires guzzlehttp/guzzle ~5.0 -> no matching package found.
    - Installation request for php-tmdb/laravel ~1.0 -> satisfiable by php-tmdb/laravel[v1.0.0, v1.0                                              .1, v1.0.2].

Potential causes:
 - A typo in the package name
 - The package is not available in a stable-enough version according to your minimum-stability setti                                              ng

i had these same problems too, im trying to use right now. I already use guzzlehttp/guzzle ~6.0.

Hi @windows1087 @filpgame is this still an issue? I haven't been able to replicate your error message.

If anyone is having the same issue, you need to install the tmdb api first.
Add the following to your composer.json file.
"php-tmdb/api": "~2.0",
"php-tmdb/laravel": "~1.0"

Closing this issue seeing the age of it...


Add static library configuration for _InternalSwiftSyntaxParser

When building command line tools that depend on SwiftSyntax, statically
linking this library can be preferred to produce a more portable binary
that doesn't directly depend on the system installation. Currently you
can achieve this benefit by shipping the dylib with your tool, and
editing the rpaths to prefer yours, but that's a lot of trouble.
Fixes https://bugs.swift.org/browse/SR-14001 and probably https://bugs.swift.org/browse/SR-9038

@swift-ci please test

Can you trigger the toolchain build just so we can see how this affects that?

@swift-ci Please Build Toolchain Linux Platform

@swift-ci Please Build Toolchain macOS Platform

Hrm so I just discovered that I don't think this is enough to be portable, we actually need a "fully linked" static library (bazel terminology, I can't find an analogy in cmake) where all the dependent libraries are included in this output as well.

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 6169a641ed0b2b87525615e820b18f2f2903b316
Install command
tar zxf  swift-PR-36151-563-ubuntu16.04.tar.gz
More info

So I found a path that works here where I pretend the library is a dynamic library, and then manually pass -r to the linker. I'm quite surprised that I can't find a way to make cmake produce a distributable static library though so I'd love to hear from some cmake experts if I'm missing something

I'd be really interested how fully linking of the static libs works as well. Maybe some can help out here? :)

I got a bit further by using a custom target to combine libraries, but that doesn't play well with the rest of the build system that expects some specific types of targets.
Related cmake feature request https://gitlab.kitware.com/cmake/cmake/-/issues/20858

https://github.com/apple/swift/pull/59167


Version 1.0.0

Short Description:

Release a version 1.0.0
Motivation:

Releasing a stable version of the crate signals to users that the crate is generally usable and can be depended upon.
Design

The following work is open and should be finished before 1.0.0:

[x] Overhaul default error messaging and test the error messages.

[x] #30
[x] #29

[x] The pretty_errors feature also needs to be more complete and tested.

[x] #19

[x] #28
[x] #40
[x] MSRV

[x] #43
[x] #44
[x] #45

[x] #47

Misc:

Released.


Attempt to uninstall extension failed

Trying to uninstall extension from its page in VScode. Got this error message:
,,,,,,,,,,,,,,,,Error: EBUSY: resource busy or locked, rmdir 'C:\Users\bialix.vscode\extensions\ms-python.python-0.8.0\pythonFiles'
and only one button: "Close"

It was actually removed, on next vscode start there is no extension anymore.


Support post aggregation expressions

select sum(A)/sum(B) from T. This is not supported in pinot as of today. With Calcite SQL, we should be able to support this easily.

Tracked in #5738


'gpio_set_irq_enabled_with_callback' from incompatible pointer type

Hello,
I purchased a Pico-LoRa-SX1262-868M and I'm trying to get it to run with the code-examples from the Waveshare website https://www.waveshare.com/wiki/Pico-LoRa-SX1262-868M which would be updated to be compatible with the Pico-LoRa-SX1262-868M module
I use the main.c example which is for the sx1262 radio module.
main.c.txt
Unfortunately it does not work for me.
While building I got the next warning ...
/home/pi/pico-lorawan/src/boards/rp2040/gpio-board.c: In function 'GpioMcuSetInterrupt':
/home/pi/pico-lorawan/src/boards/rp2040/gpio-board.c:68:73: warning: passing argument 4 of 'gpio_set_irq_enabled_with_callback' from incompatible pointer type [-Wincompatible-pointer-types]
gpio_set_irq_enabled_with_callback(obj->pin,GPIO_IRQ_EDGE_RISE,true,irqHandler);
^~~~~~~~~~
In file included from /home/pi/pico-lorawan/src/boards/rp2040/gpio-board.c:8:
/home/pi/pico/pico-sdk/src/rp2_common/hardware_gpio/include/hardware/gpio.h:384:103: note: expected 'gpio_irq_callback_t' {aka 'void ()(unsigned int,  long unsigned int)'} but argument is of type 'void ()(void *)'
void gpio_set_irq_enabled_with_callback(uint gpio, uint32_t events, bool enabled, gpio_irq_callback_t callback);
It seems to be a conflict between the software delivered in the example-code
(/home/pi/pico-lorawan/src/boards/rp2040/gpio-board.c)
and pico-sdk
(/home/pi/pico/pico-sdk/src/rp2_common/hardware_gpio/include/hardware/)
Despite this issue I copied the uf2-file to the board but it will not connect to the network ...

Pico LoRaWAN - OTAA - Temperature + LED
Initilizating LoRaWAN ... success!
Joining LoRaWAN network ................................

I am not a code-engineer and doing this just for hobby but I would appreciate some help to solve this issue.
Thank you in advance,
Eric
P.S. Is there a example code in micropython or circuitpython which makes it easier to code for people like me ;-)

Hi @DIY62,
This library does not currently support the SX1262 that is on the Waveshare board. I suggest you contact the Waveshare team for support.
You can also see @ThomasLeister's fork for the changes needed: https://github.com/ThomasLeister/lorawan-library-for-pico/tree/add-waveshare-sx1262-support

Thanks

Thanks

Hello @DIY62 and everyone seeing this.
Im having the same issue. Did you solved the problem? Did you change the library?
Thank you in advance,
Diogo

Also having the same issue with the latest Waveshare rp2040 lora example code and it's supposed to support SX1262 now.  Did anyone solve it?
Cheers, Glenn.


emacs: adapt substituteInPlace invocation to sync with upstream

Description of changes
Fixes https://github.com/nix-community/emacs-overlay/issues/251.
The emacsGit attribute and other natively-compiled master-based attributes in the Emacs overlay have been failing to update for more than a week because commit 97b928ce09d6034ebcb541fb548e5d4862302add in Emacs messed up the old substituteInPlace.
The substituteInPlace invocation added in this patch occurs after the definition of native-comp-driver-options in both Emacs 28 and 29, so this is safe. I tested by building a native-compiled Emacs (each of 28.2 and a version of 29 newer than what is presently in the overlay) with the vterm package installed. I noticed that I needed to install external packages alongside a native-compiled Emacs containing the upstream commit to force a Nix build without this PR to fail.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

openblas 3.21 isn't building right now on aarch64-linux, causing the test failure there.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1222

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1281

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1485

Decided to target master since the mass rebuilds are simply Emacs packages.

Still we are rebuilding a lot of packages.

@SuperSandro2000 those are emacsPackages. Mostly tiny packages with a handful of elisp files that need to be byte-compiled, native-compiled and installed.


added dragging shortcuts #44

Sean and I added the new shortcuts for dragging. I also had to reassign some shortcuts for rewinding, forwarding, and deleting. Wasn't too sure what the new assignments should be though.

Good initial choices!

I would avoid using arrow keys actually

People use arrow keys to scroll the page (even though our page ideally doesn't need to scroll, people will get it confused either when they either use our app or another app where they need to scroll.
The arrow keys are used to edit text in the "time" box.

I think we should use the comma and period keys for forward and rewind because the keys have < and > on them, which look like forward and rewind. We can have / be the normal play/pause button bc it's right next to them.
Now that Chrome is not longer using Backspace for "back", we can use the backspace key for deleting keyframes.

Well, my rational for arrow keys comes from most video sites (i.e. youtube and etc.), so I don't really think that should be confusing. Not quite sure what you mean by editing text in the time box since if you edit it, it'd change the time.

I do like the idea of < and > though, Gabe an I were actually discussing that earlier.

I guess backspace is fine then if we only the more recent version of Chrome. However, one thing that I was looking to ask was should we remove ECMA6 destructuring in place of normal extraction? (i.e. getting rid of {...} = ...). The reason I say this is because that would open up Beaverdam to more people with older browsers (ones that support ECMA5). (In fact even my work laptop didn't have chrome updated in a while which is where I first came across the browser necessity).

Arrow keys are used for most video sites (i.e. youtube and etc.), so I don't really think that should be confusing (or at least instead of play/ rewind, we skip a few frames in either direction).

This is true. However, I actually dislike the YouTube shortcut because sometimes when I'm trying to scroll the page or do something else I accidentally move the playhead for this exact reason.

Not quite sure what you mean by editing text in the time box since if you edit it, it'd change the time.

I meant if you are trying to type in the text box and realize you need to move the cursor one char to the left, you press the left key and oops, you accidentally rewound your video.

I guess backspace is fine then if we only the more recent version of Chrome. However, one thing that I was looking to ask was should we remove ECMA6 destructuring in place of normal extraction? (i.e. getting rid of {...} = ...). The reason I say this is because that would open up Beaverdam to more people with older browsers (ones that support ECMA5). (In fact even my work laptop didn't have chrome updated in a while which is where I first came across the browser necessity).

That's an easy one. When we want to support older browsers, we'll use Babel to convert it to ES5 automatically. We use jQuery and Raphael instead of pure JS for similar reasons – they also act as compatibility layers.


Auto-updating: add text for "Last checked"

Summary of the Pull Request
Add "Last Checked" to the general settings page.
PR Checklist

[x] Applies to #3260

Validation Steps Performed

Removed update_state.json and verified that it's actualized upon PT restart
Manually "checked for updates"

@yuyoyuppe
What's happening if I have a network error? Does the time then keep unchanged?

@htcfreek good point. for now every attempt updates the time regardless of the result. could you please create an issue in case you'd like to have a different behavior?


Support for PyTorch 2.0

Hi,
Thank you for creating this useful package! I was wondering if the dependencies for this package could be updated on PyPI to support Pytorch 2.0. I tried installing the package along with Pytorch 2.0 (after manually changing the dependencies) and didn't face any obvious issues while using it.
Thank you,
Aniketh

Hey Aniketh,
thanks for the interest in the package and reporting that it seems to work with PT2.0. I will take a look at updating the dependencies this week.
Best,
Christian

Updated the dependency.

Thank you so much, Christian!


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-k8s-30-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4392

Questions ?
Please refer to the Backport tool documentation


Integrate Commercial Registry Entry in Public Profile

Design story to think through the concept off adding the Commercial Registry Entry to the public profile
AC

Design Document with Wireframes/Screenshots

Document: https://hackmd.io/M6UWJihdT82aop9xqMGBVQ

A quick code review showed that we need some sort of type deduction at the following places:
Currently done by using the CredentialType

If we receive proof of type commercialregister then do a partner lookup, currently determined from the schema name
To determine the jsonld context, also to determine when to build a bank account vc
For database queries, e.g. do I already have a org profile document in my wallet. Get schemas by type
Find Partners that issue a BankAccount credential
Send credential request based on a document.

Thanks that's helpful

If we receive proof of type commercialregister then do a partner lookup, currently determined from the schema name

This is credential specific logic. Here a type or some form of tagging/labelling make sense. Otherwise its hard coded by schema name and we're out of luck if on a third ledger the commerical registry entry has a different schema name.

To determine the jsonld context, also to determine when to build a bank account vc
Yeah this makes also sense, but then we could take the type from the JSON-LD context and would need to specify a mapping between json-ld definiton of a credential type and a schema. I'd say this is out of scope.
I would go the canoncial embedded schema route here.

For database queries, e.g. do I already have a org profile document in my wallet. Get schemas by type
What's the use case for that? For the "status"? Here the actually better query would be are there any public credentials, i.e. is there a public profile configured.

Find Partners that issue a BankAccount credential
Would make sense to change this anyways. But good to keep track of this

Send credential request based on a document.
You mean the "verification request" ? That's related to 4.

Schema registration, only one schema per type allowed.
This is something I did not expect and don't know the consequences.
I think we have 3 options here:

Infer the type with some hard coded rule from  schema name
Add the possibility to specify a type when registering a schema
Allow many schemas of type OTHER

Currently I see two main points of having a explicit type:

Have type specific custom logic (i.e. take the did from this credential and do something with it)
Have an explicit mapping to an JSON-LD context (but this seems wrong as well, because there we just need JSON-LD context type to schema ID mapping and not an additional mapping to an internal hardcoded type)

How to proceed?
I don't know.

From my perspective the only schema that would benefit of a type would be the Commercial Registry entry, because it involves custom logic
The Bank Account does not really need an explicit type, but getting rid of it involves work because of (4. and 5.)

E.g. to prevent creation of more then one org profile credential
Nope, I mean POST /api/partners/{id}/credential-request Currently only documents of type bank account work.
I decided this because it is totally unclear what happens or should happen if there is more than one bank account schema. From the three options the second makes the most sense for now.

OrgProfile is definitely a special animal :)

5 Nope, I mean POST /api/partners/{id}/credential-request Currently only documents of type bank account work.

I think we are talking of the same thing here. This is what's used by "Request Verification" in the frontend.

6 I decided this because it is totally unclear what happens or should happen if there is more than one bank account schema. From the three options the second makes the most sense for now.

This would imply adding a new type for the commercial registry credential and not to be able to extend the BPA to additional schemas without changing the code.

Depends on what we want to do. For this story adding a new type might be sufficient. If we also want to make everything work with type other we need to fix bullet point 6.

Infer the type with some hard coded rule from schema name

If we do this we need to do this for all, and not just for some types

Allow many schemas of type OTHER

This makes some queries extremely difficult. Like give me the label strategy for type other. Which implies finding another type qualifier here which leads back to point one.

Conclusion. Two static types bank account and commercial registry, and allow many of type other. This means fix bullet points: 1, 2, 4, 5, 6
Minimum requirements:
Add new type, add to type to profile and fix 6

Phase 1 is done. You can test the following way

register a new schema of type COMMERCIAL_REGISTER_CREDENTIAL and any schema id based on it - https://indy-test.bosch-digital.de/browse/domain?page=1&query=commercialregister&txn_type=101

Create a new document with type - COMMERCIAL_REGISTER_CREDENTIAL

(optional) receive a credential that is based on the schema (currently schema name must be commercialregister)

@domwoe I'm currently stuck with a concept for phase two. I see two use cases for allowing many schemas of type other:

Having a template for request proof, request credential requests. E.g. the credential definition id for the commreg is currently hardcoded in the UI and would be replaced by a call to getSchemas().

Having a UI that configures itself based on a configured schema.

I guess we want option 1?

I won't be able to think about this until Monday

ok it seems we want option 2 as well
https://github.com/hyperledger-labs/business-partner-agent/issues/266

#266 is just an item in the backlog that has not been discussed at all

ic. We can discuss next week how far we take this.

I issued myself a commercial registry entry and came across a few issues when making it public. The following is the VC as part of the public profile
{
"@context": [
"https://www.w3.org/2018/credentials/v1",
"https://raw.githubusercontent.com/iil-network/contexts/master/indycredential.jsonld"
],
"type": [
"VerifiableCredential",
"IndyCredential"
],
"id": "urn:96d3a884-485c-476d-946d-d012e6659cd3",
"issuanceDate": "2020-11-14T16:54:01Z",
"credentialSubject": {
"attrs": {
"did": "did:sov:iil:9iDuvPqcGmpLrn67BMHwwB",
"validFrom": "2020-11-14T16:53:57.982Z",
"validUntil": "2021-11-14T16:53:57.982Z",
"companyName": "ALDI AHEAD GmbH",
"lastEntryDate": "",
"nominalCapital": "",
"authorizedOfficers": "",
"registrationNumber": "",
"companyAddressStreet": "Mintarder Straße 36-40, 45481 Mülheim an der Ruhr.",
"companyAddressCountry": "",
"companyAddressLocality": "",
"companyAddressPostalCode": ""
},
"referent": "3512fa49-1bce-42d6-b73f-79742645a9cc",
"schemaId": "8faozNpSjFfPJXYtgcPtmJ:2:commercialregister:1.2",
"credentialDefinitionId": "8faozNpSjFfPJXYtgcPtmJ:3:CL:1041:Commercial Registry Entry (Open Corporates)"
},
"indyIssuer": "did:sov:iil:WdCrvCzt9dXF9RaVm67W87",
"schemaId": "8faozNpSjFfPJXYtgcPtmJ:2:commercialregister:1.2",
"credDefId": "8faozNpSjFfPJXYtgcPtmJ:3:CL:1041:Commercial Registry Entry (Open Corporates)"
}

The custom context is missing
attrs should not be there
referent should not be there
issuer and credentialSubject.id should be the Agents public DID.

The proof segment is also strange:
"proof": {
"type": "Ed25519Signature2018",
"created": "2020-11-14T16:58:48Z",
"verificationMethod": "no-public-did",
"proofPurpose": "authentication",
"jws": "eyJhbGciOiAiRWREU0EiLCAiYjY0IjogZmFsc2UsICJjcml0IjogWyJiNjQiXX0..6LjNlKqaIEFfcSGLakOqnGXqXVQErse9UEaD7bssAXbGJP1UHLIuzzXpM07kG2WOPubjcugI1lQlevMvUdvxBg"
}

verificationMethod should reference the key of the DID doc

Concerning the context. If it is is missing then there is no registered schema, or you have one registered with another id. Or do you want a logic to build a context by any schema that i can find that has the type commercial registry?
Concerning the rest. That is a result of the unanswered phase 2 discussion and is something that needs refactoring. As we have types that are based on a credential and types that are not, totally different wrap and rewrap logic must be applied. So I need to have some idea of a type. Probably we need a type like indy_credential and web_credential, the indy credential then needs a link to the schema id as well. Otherwise I have absolutely no clue in the backend what needs to be done where. Of course I can implement more custom logic. The only reason why the bank account credential is not broken is that there is already custom remapping logic in place. But to support all kinds of credentials this is no way to go.


Adding current version to exported files?

Would it be possible to add some kind of version stamp to exported files? I don't know what would be easiest or best, but for example date+commit hash or an auto-incrementing version number.

I second this.

In the future, we can exploit the git tag functionality to produce tagged and name releases of the document.

18fc351 includes a commit hash and a link to that commit.
In the future, we can exploit the git tag functionality to produce tagged and named releases of the document.

@nitro2k01 what do you think about this?


Godot font have a bug (The font is corrupted)

Tested versions

This bug is present in the Godot_v4.2.1-stable_win64

It's not the case in Godot_v3.5.3-stable_win64

System information
Windows 10 - Godot.v4.2.1.stable - Vulkan
Issue description
The font of the client gets corrupted when opened and it is didn't matter if it is first time or not (on version 4.2.1)

But it is ok in version 3.5.3

Steps to reproduce

open the client
The font is buggy and corrupted
(It doesn't matter how many time you reinstall the client)

Minimal reproduction project (MRP)

Download The Godot on the website (https://godotengine.org/) by clicking on "Download Latest 4.2.1" or downloading it from Steam
Lunch Godot (By double clicking on Godot_v4.2.1-stable_win64.exe or running it on steam)
The Font might be fine at first but close the Godot and lunch it again
You can see the font is corrupted (It is still english)

and from now on even if you reinstall Godot you saw the corrupted font in first Lunch (It does not affect the old version)

### Tasks

Duplicate of https://github.com/godotengine/godot/issues/79955


Memory usage syrockets when trying to generate graph for diagrams package

When generating dependency graph for diagrams package, memory usage is +- constant until the package [old-time-<IP_ADDRESS>] is reached.Then the memory usage skyrockets and the program never terminates (I have 8g of memory).
Here's the command I used & its output:
$ cabal-graphdeps diagrams | tred | dot -Tpng > ~/diagrams-dependencies.png
[diagrams]
[JuicyPixels-<IP_ADDRESS>]
[array-<IP_ADDRESS>]
[binary-<IP_ADDRESS>]
[bytestring-<IP_ADDRESS>]
[deepseq-<IP_ADDRESS>]
[containers-<IP_ADDRESS>]
[mtl-2.2.1]
[transformers-<IP_ADDRESS>]
[primitive-0.6]
[vector-<IP_ADDRESS>]
[zlib-<IP_ADDRESS>]
[MonadRandom-0.4]
[random-1.1]
[time-<IP_ADDRESS>]
[transformers-compat-<IP_ADDRESS>]
[StateVar-<IP_ADDRESS>]
[stm-2.4.4]
[active-<IP_ADDRESS>]
[adjunctions-4.2.2]
[base-orphans-0.4.4]
[bifunctors-5]
[hashable-<IP_ADDRESS>]
[text-<IP_ADDRESS>]
[nats-1]
[pretty-<IP_ADDRESS>]
[semigroups-<IP_ADDRESS>]
[tagged-0.8.1]
[template-haskell-<IP_ADDRESS>]
[unordered-containers-<IP_ADDRESS>]
[comonad-<IP_ADDRESS>]
[contravariant-1.3.3]
[void-0.7.1]
[distributive-0.4.4]
[exceptions-<IP_ADDRESS>]
[free-4.12.1]
[prelude-extras-<IP_ADDRESS>]
[profunctors-5.1.1]
[semigroupoids-<IP_ADDRESS>]
[bytes-<IP_ADDRESS>]
[cereal-<IP_ADDRESS>]
[filepath-<IP_ADDRESS>]
[kan-extensions-4.2.3]
[lens-4.13]
[parallel-<IP_ADDRESS>]
[reflection-2.1]
[linear-1.20.1]
[ansi-terminal-<IP_ADDRESS>]
[unix-<IP_ADDRESS>]
[ansi-wl-pprint-<IP_ADDRESS>]
[async-2.0.2]
[base64-bytestring-<IP_ADDRESS>]
[blaze-builder-<IP_ADDRESS>]
[bytestring-builder-<IP_ADDRESS>.0]
[circle-packing-<IP_ADDRESS>]
[colour-2.3.3]
[data-default-0.5.3]
[data-default-class-0.0.1]
[data-default-instances-base-0.0.1]
[data-default-instances-containers-0.0.1]
[data-default-instances-dlist-0.0.1]
[dlist-<IP_ADDRESS>]
[data-default-instances-old-locale-0.0.1]
[old-locale-<IP_ADDRESS>]
[diagrams-1.3]
[diagrams-contrib-<IP_ADDRESS>]
[diagrams-core-<IP_ADDRESS>]
[dual-tree-<IP_ADDRESS>]
[groups-<IP_ADDRESS>]
[monoid-extras-<IP_ADDRESS>]
[newtype-0.2]
[diagrams-lib-<IP_ADDRESS>]
[diagrams-solve-0.1]
[directory-<IP_ADDRESS>]
[fingertree-<IP_ADDRESS>]
[fsnotify-0.2.1]
[hinotify-<IP_ADDRESS>]
[unix-compat-<IP_ADDRESS>]
[intervals-0.7.1]
[lens-4.12.3]
[reflection-2]
[linear-<IP_ADDRESS>]
[optparse-applicative-<IP_ADDRESS>]
[process-<IP_ADDRESS>]
[semigroups-<IP_ADDRESS>]
[force-layout-<IP_ADDRESS>]
[parsec-3.1.9]
[split-0.2.2]
[diagrams-svg-<IP_ADDRESS>]
[lucid-2.9.2]
[lucid-svg-<IP_ADDRESS>]
[old-time-<IP_ADDRESS>]                                    <- up until now the memory usage is constant, but then ...
^C                                                           <------------- Have to kill it here, because it starts trashing

I've uploaded version 0.1.3, which uses smarter pruning when rendering graphs (commit a3b47ddceb245205219c419614105641fdb396f5). It's able to render the graph for "diagrams" with no issues.

Tested the new version and now it works. Thanks for the fix!


Adding Santa Monica

Followed the Readme to add Santa Monica to Pivotal-Life.
I was able to run the tests locally but wasn't able to get a running version locally at this step: $ bundle exec dashing start
Take a look and lemme know how it turned out!

It looks like if you follow the steps to populate the .env using the ./populate_dotenv.sh script, you end up with a mangled .env with a truncated VCAP_SERVICES variable. That might deserve some attention in its own right if anybody's interested.
This pull request looks totally reasonable. The more offices the merrier.


Cant build with message Could NOT find PythonInterp (missing: PYTHON_…

…EXECUTABLE) (Required is at least version "3.6")

Can't build docker image on arm64 without direct python3 executable location point line in Dockerfile
-DPYTHON_EXECUTABLE=/usr/bin/python3 \

Hello @oleg-milantiev, thank you for the contribution.
According to the contribution guidelines pull requests should go to the development branch. Please reopen your PR to that branch.


Move autorest client to java sdk central repo

There are basically three steps moving the common runtime package to central repo:

First, move the entire package without changes.
Then, we will cleanup the pom file, spotbugs and checkstyle.
Last, we will run the live tests.

This commit is to finish the following first step.

Can one of the admins verify this patch?

LGTM.

Sima, don't merge this - ask @weshaggard to do it so that the revision history is maintained.

@sima-zhu what is the issue tracking the remaining clean-up work? Your description says:

issue: Move autorest client to java sdk central repo #3174

but that is this PR not the an issue. I want to make some notes about some things that need to be cleaned up.

Hello Wes,
I don’t have an issue tracking the remaining clean up work yet. Do we need to open an issue for the remaining clean up? I can do it right now.
Anu, could you please advise the best practice for this?
Thanks!
Regards,
Sima Zhu
Software Engineer
(607)-768-5356
Room 3960, Building 18

From: Wes Haggard<EMAIL_ADDRESS>Sent: Monday, March 25, 2019 8:38:18 AM
To: Azure/azure-sdk-for-java
Cc: Sima Zhu; Mention
Subject: Re: [Azure/azure-sdk-for-java] Move autorest client to java sdk central repo (#3174)
@sima-zhuhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsima-zhu&data=02|01|Sima.Zhu%40microsoft.com|ba59ee7594a244c8751408d6b137e759|72f988bf86f141af91ab2d7cd011db47|1|0|636891250998265042&sdata=jTMO59MB2EC3kXg8Vtq6NmVD27dkx%2Fc7im3S64Ubywk%3D&reserved=0 what is the issue tracking the remaining clean-up work? Your description says:
issue: Move autorest client to java sdk central repo #3174https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-java%2Fpull%2F3174&data=02|01|Sima.Zhu%40microsoft.com|ba59ee7594a244c8751408d6b137e759|72f988bf86f141af91ab2d7cd011db47|1|0|636891250998275038&sdata=PQVTFmDwA0CoyeTjcxn68FQxiFS55NBTqoQtgkTDNQk%3D&reserved=0
but that is this PR not the an issue. I want to make some notes about some things that need to be cleaned up.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-java%2Fpull%2F3174%23issuecomment-476252464&data=02|01|Sima.Zhu%40microsoft.com|ba59ee7594a244c8751408d6b137e759|72f988bf86f141af91ab2d7cd011db47|1|0|636891250998275038&sdata=moffrbEgjR9NM%2F8oeFhB7DTBbUoOc6NYuGzqJBvPfRU%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAtz56Czfd_jWtJeJVRLCgt9tAR3uCAooks5vaO1qgaJpZM4cCnOT&data=02|01|Sima.Zhu%40microsoft.com|ba59ee7594a244c8751408d6b137e759|72f988bf86f141af91ab2d7cd011db47|1|0|636891250998285031&sdata=olu6TavQD4izrgn7zptkqOo9AmU%2B%2Bu77e4HSRg4ZNS4%3D&reserved=0.

I don’t have an issue tracking the remaining clean up work yet. Do we need to open an issue for the remaining clean up? I can do it right now.

Yes please file a follow-up issue in this repo to track the remaining work that needs to be done.

Issue tracking the remaining clean up.


Incompatible with Babel 7

Error: Plugin/Preset files are not allowed to export objects, only functions. In /var/www/html/node_modules/babel-plugin-amd-default-export/index.js
    at createDescriptor (/var/www/html/node_modules/@babel/core/lib/config/config-descriptors.js:160:11)
    at createDescriptor.next (<anonymous>)
    at step (/var/www/html/node_modules/gensync/index.js:261:32)
    at evaluateAsync (/var/www/html/node_modules/gensync/index.js:291:5)
    at items.forEach (/var/www/html/node_modules/gensync/index.js:44:11)
    at Array.forEach (<anonymous>)
    at Function.async (/var/www/html/node_modules/gensync/index.js:43:15)
    at Function.all (/var/www/html/node_modules/gensync/index.js:216:13)
    at Generator.next (<anonymous>)
    at createDescriptors (/var/www/html/node_modules/@babel/core/lib/config/config-descriptors.js:102:41)

This functionality would come in real handy, unfortunately I don't understand enough about Babel plugins to even consider forking it

Are you sure that you're not mixing babel 6, 7 and/or 8? There's a thread on stackoverflow about this problem.

Fairly sure
    "@babel/cli": "^7.24.5",
    "@babel/core": "^7.24.5",
    "@babel/plugin-transform-modules-amd": "^7.24.1",
    "@babel/preset-env": "^7.24.5",
    "@babel/preset-typescript": "^7.24.1",
    "babel-loader": "^9.1.3",

I did manage to tweak it such that I could get it working personally, but I'm not confident enough in my changes to consider suggesting them: https://github.com/navarr/babel-plugin-amd-default-export/commit/b74048d2cfbd5f3f366f56440b12351d6ca35b75?diff=unified&w=1


Method mark_hash_map_values() invokes Ruby code; which can crash the Ruby process

Running multi-threaded Ruby applications that make use of google_hash occasionally crash the Ruby process during garbage collection.  Method mark_hash_map_values() uses erb (and hence invokes Ruby), and should not do so:

Please refer to: https://bugs.ruby-lang.org/issues/11799
In particular, note Koichi Sasada's comments in #5 and #6.

Wow good find.  I have attempted to address it in v 0.9.0 care to test it
for me?
On Thu, Dec 10, 2015 at 11:05 AM, charlez<EMAIL_ADDRESS>wrote:

Running multi-threaded Ruby applications that make use of google_hash
occasionally crash the Ruby process during garbage collection. Method
mark_hash_map_values() uses erb (and hence invokes Ruby), and should not do
so:
Please refer to: https://bugs.ruby-lang.org/issues/11799
In particular, note Koichi Sasada's comments in #5
https://github.com/rdp/google_hash/issues/5 and #6
https://github.com/rdp/google_hash/issues/6.
—
Reply to this email directly or view it on GitHub
https://github.com/rdp/google_hash/issues/39.

Yes, be glad to test it, and report the results.  I'll push your request into my work queue.


test(operator): add IT mock test for ssChaos

Type of change:

[x] Bugfix
[x] Add test case

What this PR does / why we need it:

Add test for ssChaos
Delete exec when delete CR

Pre-submission checklist:

[x] Did you explain what problem does this PR solve? Or what new features have been added?
[x] Have you added corresponding test cases?
[ ] Have you modified the corresponding document?
#272

Codecov Report

Merging #364 (2f72a11) into main (0730957) will increase coverage by 4.95%.
The diff coverage is 61.22%.

@@            Coverage Diff             @@
##             main     #364      +/-   ##
==========================================
+ Coverage   41.67%   46.62%   +4.95%
==========================================
  Files          44       46       +2
  Lines        4773     4931     +158
==========================================
+ Hits         1989     2299     +310
+ Misses       2631     2426     -205
- Partials      153      206      +53

Impacted Files
Coverage Δ

...ator/cmd/shardingsphere-operator/manager/option.go
49.52% <0.00%> (+2.67%)
:arrow_up:

...rator/pkg/reconcile/storagenode/aws/rdsinstance.go
22.79% <ø> (+0.33%)
:arrow_up:

...perator/pkg/controllers/storage_node_controller.go
47.25% <46.25%> (+6.59%)
:arrow_up:

...pkg/controllers/shardingsphere_chaos_controller.go
34.82% <65.93%> (+34.82%)
:arrow_up:

shardingsphere-operator/pkg/pressure/pressure.go
73.45% <73.45%> (ø)

... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Adding new service type without an icon will show image missing in search results

Lets add a generic one for new or missing service types


Add Python 2 as a prerequisite in README.md.

The Gyp tool breaks when only Python 3 is available.

Thanks for catching this and sending in the PR!


Add GBP to pricebot

CDN would be great too :D

I´ll get back to this tomorrow as im working on refactoring the whole bot, thanks for the pull!

@filipnyquist whats the status on this?

@grin i would say this could be added as refactoring the bot is not my top priority

If someone has anything else to say, feel free :)


could not remove ephemeral file WARN message is missing tenant + timeline id context

Steps to reproduce
See
https://neon-github-public-dev.s3.amazonaws.com/reports/pr-3290/debug/3931126536/index.html#suites/f9eba3cfdb71aa6e2b54f6466222829b/ee8decf4406e72de/
test_tenant_detach_smoke
2023-01-16T14:25:46.436369Z  INFO POST /v1/tenant/4bfac8124f4441454809e87e18fb521a/detach 200 OK
2023-01-16T14:25:46.467440Z  WARN could not remove ephemeral file '/tmp/test_output/test_tenant_detach_smoke/repo/tenants/4bfac8124f4441454809e87e18fb521a/timelines/f65cbc5ce48a79f8e4545cac1698465a/ephemeral-4': No such file or directory (os error 2)
2023-01-16T14:25:46.472007Z ERROR Error processing HTTP request: InternalServerError(fsync of newly created layer files

Caused by:
    No such file or directory (os error 2)

Expected result
2023-01-16T14:25:46.467440Z  some_span{tenant_id=...,timeline_id=...}: WARN could not remove ephemeral file '/tmp/test_output/test_tenant_detach_smoke/repo/tenants/4bfac8124f4441454809e87e18fb521a/timelines/f65cbc5ce48a79f8e4545cac1698465a/ephemeral-4': No such file or directory (os error 2)

Actual result
2023-01-16T14:25:46.467440Z  WARN could not remove ephemeral file '/tmp/test_output/test_tenant_detach_smoke/repo/tenants/4bfac8124f4441454809e87e18fb521a/timelines/f65cbc5ce48a79f8e4545cac1698465a/ephemeral-4': No such file or directory (os error 2)

Environment
Unit test execution.

https://github.com/neondatabase/neon/issues/3060 could be a dup

Note that tenant and timeline are present in the message, which is why I haven't thought of this as notable. At drop time the span is very questionable anyways, but the callsite does know of the tenant and timeline to produce that path.
This I believe is similar to what I had to do with the "WARN request cancelled before completion" message in #4064. On drop, the creation time span has to be activated separatedly, otherwise they will result in messages without context. This follows from all outer drops having executed and thus dropped the span enter drop guard put in place by instrument.

Yeah, the Span::current() isn't very helpful.
But, we do have the tenant and timeline id inside the EphemeralFile struct.
So, I think we should have them as fields, either in the warn! event or we open a span for the drop ?


[CT-2815] Deprecate version_to_bump_main in cut-release-branch.yml

Need to open PRs in adapters + core to remove version_to_bump_main input as it's no longer needed after merging: https://github.com/dbt-labs/actions/pull/114

This should be done along with https://github.com/dbt-labs/dbt-release/issues/69

The other defaulted inputs could probably be removed to to make the input listss for each repo shorter.


Provide official shield badge thing

With no stale bots being a development philosophy, it's effectiveness can be directly tied to peoples awareness of it.
I propose providing one of those shield.io badges people can add to their projects readmes to spread awareness and associate their process with this specific practice

I'll look at this later, thanks for the suggestion


Allow specific asdf language versions as optional arg

Some asdf plugins have architecture specific versions at the tail of list-all, unlike Ruby & Node, which have the latest at the end.  Allow optional 2nd argument to install_asdf_language() to permit hardcoding version numbers.
e.g. asdf list-all golang | tail -1 yields "1.8.linux-amd64", not "1.8.3"

Thanks for the contribution! I'm going to close this, since there has been no activity for a while and I think the main problem was handled by https://github.com/thoughtbot/laptop/pull/534. If there are other reasons why we need this that I am missing, we can reopen as necessary.


Added is.element function

This function checks if the given value is a DOM element. It also checks if the given value is a jQuery wrapper.

Thanks for the PR @efecan
There are no jQuery related methods in the library at the moment. So I'll keep this way for now.
There is a PR like yours, for only dom elements: https://github.com/arasatasaygin/is.js/pull/46/files
I'll merge it and let you know when published.
Cheers.

Merged this check with https://github.com/arasatasaygin/is.js/pull/46


blog post & general content updates

This PR updates the neubot retire blog post and adds a post announcing our org transition + related  content on the site. @georgiamoon if you could review that would be super. Note that there is some issue with sandbox builds at the moment which I hope to resolve soon, but until then a preview is unavailable.

This change is

Thanks @georgiamoon. Build issues are now resolved. Preview now available:
http://website.mlab-sandbox.measurementlab.net/

Added 2 more quick comments, but the preview is looking good!

Thanks for the review @georgiamoon I have to update the service account ACL as well. Should be ready later today. @bassosimone if you would like to review the igf post, it is also on this PR.


fix whitelist check for endpoints

Codecov Report

Merging #12 into master will not change coverage.
The diff coverage is 0%.

@@          Coverage Diff           @@
##           master     #12   +/-   ##
======================================
  Coverage    72.5%   72.5%
======================================
  Files          15      15
  Lines         742     742
======================================
  Hits          538     538
  Misses        185     185
  Partials       19      19

Impacted Files
Coverage Δ

config/config.go
85.41% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99a9937...c5cf02a. Read the comment docs.


Fix build with rust alpha

@Arcterus I cherry-picked 080816c from your master branch, I hope you don't mind.
Everything should build, though nl tests are failing.

I don't mind at all. :)


improvement: fix backend login buttons not showing login progress

Summary
Regression from #785. inProgress was removed and the backends were depending on it.
Test plan

A picture of a cute animal (not mandatory but encouraged)

Deploy preview for netlify-cms-www ready!
Built with commit ff18f3285afd5a780e7f773d4428845254e5c5d3
https://deploy-preview-1658--netlify-cms-www.netlify.com

Deploy preview for cms-demo ready!
Built with commit ff18f3285afd5a780e7f773d4428845254e5c5d3
https://deploy-preview-1658--cms-demo.netlify.com


feat: markdown updates

[x] alerts
[x] add colors
[ ] better chosen colors - contrast, light/dark mode
[ ] custom code blocks
[x] tags
[x] i18n for above
[ ] search posts

closes #21

this should be follow-up of #52
forgot about it

i spent too much time on that codeblock fr


Is there a app on Andriod that I can connect matter object with it?

Is there a app on Andriod that I can connect matter object with it?

@Firesuiry There is one in the upstream connectedhomeip repository which you can find here
This also has the documentation about building the Android app.

Official Google sample is here:
https://developers.home.google.com/samples/matter-app

@dhrishi @jonsmirl Thank you！


Upgrade firetask to v3.7.2

Thank you for the contribution. It was merged directly as 0358e440d7efbbd1f13e91da4b0b38b63f545e23 to keep commit history cleaner. Your contribution is still credited to you.


feat: add interceptor before produce etc.

I will write more detail soon

implemented, thank you for support @ademekici 🙏🏻
https://github.com/Trendyol/kafka-konsumer/releases/tag/v2.3.5


Fix potential index out of bounds with 8ball command

The way Math.random works is between 0 and 1 (1 being non inclusive). Therefore, the floor of the highest that can occur (say .99 for simplicity) multiplied by the length will never be equal to the length
Assuming math random equal .99 and the length is 2 the floor will make it so the highest number achievable is 1 (rounding down from 1.98). Under your example and fix it would make it become .99 * (2-1) or .99 which will floor to 0, making the 2nd option never achievable.


redis-ha psp

short question regarding podSecurityPolicy (PSP), will it be supported by this chart? Actually getting
4m47s       Warning   FailedCreate            statefulset/redis-cache-redis-ha-server                    create Pod redis-cache-redis-ha-server-0 in StatefulSet redis-cache-redis-ha-server failed error: pods "redis-cache-redis-ha-server-0" is forbidden: unable to validate against any pod security policy: []

on a node where psp is enabled. Thanks for infos.

@ivomarino Yes, it wouldn't be too hard to implement support for this. Especially if it's unable to be deployed to clusters set to force validate.
I'll add it to the to do.

Thanks @DandyDeveloper, really appreciated;)


incorporate omicron into glitch generation project

fully Integrate omicron via pyomicron library into the glitch-generation project so a user does not need to rely on a previously made omicron triggers.

This is extremely slick, love it. Does omicron require any special credentials or anything? Other than that and my one very minor comment, all good.


Commenting on Issues

Based on our discussion on Issue #79, there is no functionality in ogr for commenting on Github/Pagure issues.

I would like to provide a solution to this issue.
Before that, I have several questions about ogr development:

when you creating such a feature like this, should one PR consists of functionality for all git forges at once. In this case, I would provide commenting on Issue for Github/Pagure/Gitlab in one PR.
What is current support for Gitlab? I looked at ogr/services/gitlab.py and for now, it seems to be unsupported.
Is there any special way how to run tests? Or something I should know about writing them? Release-bot, for example, creates its own container for testing with a makefile.

when you creating such a feature like this, should one PR consists of functionality for all git forges at once. In this case, I would provide commenting on Issue for Github/Pagure/Gitlab in one PR.

I think this is up to you, small PRs are easier to review. About Gitlab, as far as I know, we focus mainly on Github and Pagure right now.

Is there any special way how to run tests? Or something I should know about writing them? Release-bot, for example, creates its own container for testing with a makefile.

@jscotka can provide the best answer to this question.

I would like to provide a solution to this issue.
Before that, I have several questions about ogr development:
1. when you creating such a feature like this, should one PR consists of functionality for all git forges at once. In this case, I would provide commenting on Issue for Github/Pagure/Gitlab in one PR.

Since none of us is really using the gitlab interface, I wouldn't worry with it much (unless you like adventure).
As Rado said, send the PR as you wish. One PR is okay.

2. What is current support for Gitlab? I looked at ogr/services/gitlab.py and for now, it seems to be unsupported.

Yup, no one is using it (yet).

3. Is there any special way how to run tests? Or something I should know about writing them? _Release-bot_, for example, creates its own container for testing with a makefile.

https://github.com/packit-service/ogr/blob/master/CONTRIBUTING.md#makefile
please let us know if the doc is outdated

I successfully run tests on my local machine, now I wanted to test my new functionality for this Issue.
However, I need to generate a similar file like .yaml files stored in tests/integration/test-data. Without that, I am not able to test new functionality. Any advice on how to generate such .yaml file?

Hi, see lines in: https://github.com/packit-service/ogr/blob/master/tests/integration/test_github.py#L20
So for regenereation these files, you have to use syntax eg:
FORCE_WRITE=yes GITHUB_TOKEN=yourtoken GITHUB_USER=yourname pytest3 tests/integration/test_github.py
or this will also work FORCE_WRITE=yes GITHUB_TOKEN=yourtoken GITHUB_USER=yourname make check with make check, you have to have set PAGURE_TOKEN and USER env vars

So I created class Issues(GithubTests) in test_github.py. This class should create one of the .yaml files similar to all files in tests/integration/test-data.
In my case it should create for example file:
my_workspace/ogr/tests/integration/test_data/test_github_data_tests.integration.test_github.Issues.test_issue_list.yaml

However, when I run all tests, all of them passing except for my tests in class Issues(GithubTests).  I got an exception:
ogr.exceptions.PersistenStorageException: file does not exists: my_workspace/ogr/tests/integration/test_data/test_github_data_tests.integration.test_github.Issues.test_issue_list.yaml

In setUp function within class GithubTests there are 3 env variables.

GITHUB_TOKEN
GITHUB_USER
FORCE_WRITE

First two are set inside my virtualenv. The third one is always False otherwise all tests in test_github.py start to fail.
Firstly I thought It is a problem with permissions because these tests are running on your repo user-cont/colin. However, when I tried my own repo with my permissions for my tests, they are still failing.
Everything seems to be set right including environment variables, paths, permission. Can you help me to find what I'm doing wrong?
@jscotka

So I created class Issues(GithubTests) in test_github.py. This class should create one of the .yaml files similar to all files in tests/integration/test-data.
In my case it should create for example file:
my_workspace/ogr/tests/integration/test_data/test_github_data_tests.integration.test_github.Issues.test_issue_list.yaml

However, when I run all tests, all of them passing except for my tests in class Issues(GithubTests).  I got an exception:
ogr.exceptions.PersistenStorageException: file does not exists: my_workspace/ogr/tests/integration/test_data/test_github_data_tests.integration.test_github.Issues.test_issue_list.yaml

In setUp function within class GithubTests there are 3 env variables.

GITHUB_TOKEN
GITHUB_USER
FORCE_WRITE

First two are set inside my virtualenv. The third one is always False otherwise all tests in test_github.py start to fail.
Firstly I thought It is a problem with permissions because these tests are running on your repo user-cont/colin. However, when I tried my own repo with my permissions for my tests, they are still failing.
Everything seems to be set right including environment variables, paths, permission. Can you help me to find what I'm doing wrong?
@jscotka
Edit:
Sorry I missed your last comment. It looks I did everything in the right way. However what is FORCE_WRITE env variable? When I set it to True/yes/1 all tests are failing.
I'm also using macOS, can be this problem? I tried to run tests with tox and also pytest inside my virtualenv.

@marusinm
When you set FORCE_WRITE to true, the tests will be directly requesting the GitHub/Pagure. The response will be saved in those YAML files.
When you do not use FORSE_WRITE, the tests will not use GitHub, but those YAML files to get a response... (This is used in the CI.)
Just create a pull-request and we can help you with that...

exactly, with FORCE_WRITE (set to any nonempty string :-) enforce writing files and reading real github API and store requests. inside CI is not set so it just use files. tox file has also enable to pass this value https://github.com/packit-service/ogr/blob/master/tox.ini#L18 so that you can regenerate it also via tox, but in this case you have to regenerate everything so that pagure variables has to be set as well.

This is already solved by #99 and #81


Does ManageIQ work with OVN?

Hi everyone,
I have a cluster with ovirt and ovn. Recently I add this cluster in ManageIQ Najdorf, but I cant manage my networks. Does know if ManageIQ work with OVN? I try to add a new cloud network but the natwork manager does show.

@agrare Can you answer here?

@junnbj we do support OVN, we check for external network provider services when adding or editing the provider.
You can try running:
ManageIQ::Providers::Redhat::InfraManager.first.ovirt_services.collect_external_network_providers

To see what the result is

Thanks @agrare for your reply. Follow above my real problem:

In the Network Provider screen, the RedHat network show me, but:

When I try to add a new router, dont show me any providers

@junnbj it doesn't appear that the Ovirt or RHV Network Manager has ever had support for creating cloud_networks but given it shares the same API as OpenStack I was able to get this to work relatively easily.  Let me do some further testing (e.g. adding cloud_subnets and cloud_routers also works in addition to adding cloud_networks) then I'll push a PR.


feat: adopt the new language server

Replaced the code and assets with the content of tomaciazek/vscode-ansible.
Adjusted the build, run & debug to work with external language server.
Added documentation for running & debugging.

General Note:
Overall PR looks good from code perspective, some minor changes might be required which can be done in subsequent PRs.
Since this PR is a rewrite of client code using ansible-language-server at the backend it might break some of the existing functionality and result in some missing functionality.
Please feel free to raise new issues on this repository so that we can gradually add the missing  features as applicable.

@tomaciazek
In the future, please, construct smaller PRs so that they are atomic, less gigantic and are possible to review.
Here's a nice article on making good PRs: https://mtlynch.io/code-review-love/.

@webknjaz Since this a rewrite of the client plugin (much like an initial commit with a new direction) the PR size was big but I do agree that going forward we should be raising targeted and well scoped PR's

@ganeshrn I understand why it's big. But there were a lot of changes that have nothing to do with the rewrite.

Why did you remove the support for inline vault-strings? This was the main use-case of this extension for me.

@ChristianCiach removal of vault strings was not a desired outcome, only one of the several regressions we are aware about. We will work to bring it back.  Please create a bug for it if there is none already open.
Until we bring it back keep using the old extension, it may take few weeks.


feat: add initializeWithValue option to useCookie hook

BREAKING CHANGE: useCookie renamed to useCookieValue
BREAKING CHANGE: useCookieValue default behaviour for browsers
changed to fetch cookie value on state initialisation.
SSR remains untouched, but requires implicit setting of
initializeWithValue option to false, to avoid hydration mismatch.
What is the current behavior, and the steps to reproduce the issue?
Hook fetches cookie value onli on effects execution stage, thus first render always yields undefined state.
What is the expected behavior?
Ability to enable or disable initialisation fetch.
How does this PR fix the problem?
Add initializeWithValue option to disable initialisation value fetch and make hook to fetch value on initialisation by default.
Checklist

[x] Have you read contribution guideline?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Is there an existing issue for this PR?

link issue here

[x] Have the files been linted and formatted?
[x] Have the docs been updated to match the changes in the PR?
[x] Have the tests been updated to match the changes in the PR?
[x] Have you run the tests locally to confirm they pass?

Question! Why is this hook called useCookie and not useCookieValue?

I had similar thoughts, but kept such naming to have consistency with useLocalStorage useSessionStorage

Consistency with which implementations of useLocalStorage and useSessionStorage? Ours are called useLocalStorageValue anduseSessionStorageValue right? Maybe I'm a bit confused.

LMAO, i've got confused, forgot that ive renamed it 🙃
I'lll do renaming in this PR to avoid useless major versions bump

@JoeDuncko i've also done renaming, re-review briefly please.

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


SelectPopover focus on any focusable element which are above the listbox when Tab is pressed

Current behavior
When no other focusable element is present on the DOM, pressing the Tab key focus on the elements inside the Popover and which are above the listbox.
Video simulating the issue
Steps to reproduce the bug

Open sandbox: https://codesandbox.io/s/friendly-wu-ijl4vt?file=/src/select-multiple.tsx
Open the Select
Press Tab key
button 1 is receiving the focus (Which is above the listbox in the DOM tree)

PS: Strangely, if I press Tab again the button 2 will not get the focus.
Expected behavior
We should not focus on elements that are above the listbox inside the Popover considering the hierarchy tree.
Workaround
Set preserveTabOrder to false on SelectPopover.
Possible solutions
No response

Looks like it's fixed in the latest versions: https://codesandbox.io/s/https-github-com-ariakit-ariakit-issues-1828-425y0j


feat: add Dockerfile

Closes #103

Coverage remained the same at 97.898% when pulling 7ff37a5801dcc4a180e03f98727f05bc3fad1ced on create-dockerfile into a60aa564ce53d9654d1e4132ab451e185a37f528 on master.

Coverage remained the same at 97.898% when pulling 7ff37a5801dcc4a180e03f98727f05bc3fad1ced on create-dockerfile into a60aa564ce53d9654d1e4132ab451e185a37f528 on master.


React Dark Reader only Work Locally

Hi,
I have installed The React Dark Reader package,  locally it works fine, but when deploying it online, doesn't work properly.
Please see below the screenshot:

Any suggestions on how to solve the issue?
Thanks in advance,

What version are you using? I am not even able to install it using npm install react-darkreader .
It says:
Found<EMAIL_ADDRESS>npm ERR! node_modules/react npm ERR<EMAIL_ADDRESS>from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/react-darkreader npm ERR!   react-darkreader@"*" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry

I have faced with same issue.
We are using semantic-ui-react / styled-components for styling.
I can publish the source code, and a minimal reproduction of the bug:
Source code: https://github.com/fabicsp/bug_reproduction
Live demo: https://heroku-test-sc-sem-ui.herokuapp.com/


I know you said you won't support pojav launcher..

Describe the bug
No bug
Steps to reproduce
1..
2.
3.
...
Logs
No response
Additional context
I know you said you don't support pirate launcher and unofficial Minecraft launcher... But pojav is legal according to Microsoft.. all of pojav user need to buy an original copy of Minecraft so they can play ... It still don't support crack player... So I'm hoping you could consider to try making this mod compatible with pojav ... Thanks for your time .. I'm waiting for your reply

There are no plans to provide support for non-standard launchers as they are unpredictable in terms of code changes. Anything that runs on PC Minecraft Java Edition should in theory be compatible with other launchers as well. If that's not the case, changes might be required to the launcher or the mod, depending on the cause of the issue.
All of Sinytra's projects are open source and free, allowing anyone to add support for tools that fit their needs should they want to.

So if I want to change some coding and make it work with pojav where should I start?

Srsly?

Just to let you that sinytra connector works on pojavlauncher

Srsly?

Did you not have Forgified Fabric API installed?

I did but idk why it keep crashing.. I've downloaded synitra connector, connector extra, forgified fabric api

What 1.20.1 Forge version are you using?


[Bug]-[30]:Wrong dropdown menu width on selecting the label top position

Is there an existing issue for this?

[X] I have searched the existing issues

Description
the drop-down menu of the select widget has an incorrect width when the label position setting is "top"
Steps To Reproduce
create a new select widget, set the label position to top. the options in my case are the result of a query
Public Sample App
No response
Version
self hosted 1.70

addendum.. dropdown menu width depends  on the width of the label

Hey @bufsim thanks for raising this, i believe there a workaround for it. If you resize the handles to be below the dropdown then this is working as expected. Please let me know if this is not the issue, it would help if you add screenshots.

Assuming 50% users don't resize the dropdown boundary
Stats

Stat
Values

Reach
30

Effort (months)
0.5

Another user reported this issue.

@ame-appsmith can you ask them to resize the dropdown? It has to occupy the full height as explained in the above comment


[Test Plan 7.0 LTS] Web UI

Web UI
WEB UI
Gravity Cluster
Side Nav

[x] Verify that company logo is shown with a product version.
[x] Verify that Gravity logo is shown when company logo is missing.

Top Nav

[x] Verify that status indicator reflects these cluster states: healthy/processing/failed.

[x] Verify that cluster public URL is shown.

[x] Verify that "Info View" button opens "Cluster Information" dialog.
Cluster Information

[x] Verify that public URL, internal URLs, and login command are shown.
[x] Verify that "copy" button copies the text to the clipboard.

[x] Verify that user menu has "Logout" and "Account" options for local use.

[ ] Verify that user menu has only "Logout" option for SSO user.

Dashboard

[x] Verify that "CPU Usage" shows current CPU data.

[x] Verify that "RAM Usage" shows current RAM data.

[x] Verify that "Usage Over Time" shows the last 60 seconds of CPU/RAM data.

[x] Verify that all charts show real-time data. You can open a terminal and try running ls -R / for a while.

[x] Verify that "Audit Logs" table shows recent events (today).

[x] Verify that "Operation" table shows cluster operations.
Start a terminal session

[x] Verify that terminal session appears in the "Operation" table.

[x] Verify that Application table shows all installed applications.

Nodes

[x] Verify that "Nodes" table shows all joined nodes.
[x] Verify that login dropdown shows a list of available logins.
[x] Verify that clicking on the login opens a terminal.
[x] Verify that "Add Node" button opens a dialog with instructions.
[x] Verify that "Add Node" dialog shows valid instructions per selected role.

Terminal Session

[x] Verify that input/output works as expected by typing on the keyboard.

[x] Verify that window resize works (use yum -y install mc to install midnight commander)
SCP

[x] Verify that Upload works.
[ ] Verify that Upload handles invalid paths and network errors.
[x] Verify that Download works.
[ ] Verify that Download handles invalid paths and network errors.

Logs

[x] Verify that Logs are shown.
Log forwarder settings

[x] Verify that Creating/Deleting/Editing a log forwarder works.

Audit Logs

[x] Verify that Audit events of different types are shown.
[x] Verify that "Details" button opens a dialog with JSON.
[x] Verify that "Today" and "7 Days" options correctly filter events.
[x] Verify that "Custom" option opens a date picker dialog.

Roles

[x] Verify that roles are shown.
[x] Verify that "Create New Role" dialog works.
[x] Verify that deleting and editing a role works.
[x] Verify that error is displayed when saving invalid input.

Users

[x] Verify that users are shown.

[x] Verify that creating a new user works.

[x] Verify that editing user roles works.

[x] Verify that removing a user works.
Reset Password

[x] Verify that "Reset Password" dialog shows a reset link.

Invite User

[x] Verify that role dropdown shows all existing roles.
[x] Verify that clicking on "Create invite link" shows an invite URL.

Auth Connectors

[ ] Verify that creating OIDC/SAML/GITHUB connectors works.

[ ] Verify that editing  OIDC/SAML/GITHUB connectors works.
Templates

[ ] Verify that "New OIDC connector" dialog has OIDC template.
[ ] Verify that "New SAML connector" dialog has SAML template.
[ ] Verify that "New SAML connector" dialog has GITHUB template.

Card Icons

[ ] Verify that GITHUB card has github icon
[ ] Verify that SAML card has SAML icon
[ ] Verify that OIDC card has OIDC icon

HTTPS Certificate

[x] Verify that it shows certificate details.
[x] Verify that updating a certificate works (try submitting invalid file formats).

Kubernetes

[ ] Verify namespace selector.
Config maps

[x] Verify that configs maps are shown.
[x] Verify that editing config maps with multiple files works. Should see multiple tabs and "unsaved" changes indicator.

Pods

[x] Verify that pods of different statuses are correctly displayed. Failed should be in red.

[x] Verify that string search on table columns works.
Container menu

[x] Verify that "View Logs" works.
[x] Verify that SSH to container works.

Action menu

[x] Verify that "Details" display the JSON dialog.
[x] Verify that "Monitoring" opens the monitoring screen with selected pod charts.
[x] Verify that "Logs" opens the logs screen with selected pod logs.

Services

[x] Verify that services are displayed.
[x] Verify that "Details" opens a dialog with JSON.

Jobs

[x] Verify that jobs are displayed.
[x] Verify that "Details" opens a dialog with JSON.

Daemon Sets

[x] Verify that daemon sets are displayed.
[x] Verify that "Details" opens a dialog with JSON.

Deployments

[x] Verify that deployments are displayed.
[x] Verify that "Details" opens a dialog with JSON.

Monitoring

[x] Verify that Grafana charts work.

Account

[x] Verify that changing a password works with 2FA disabled.
[x] Verify that changing a password works with 2FA enabled.

License
Make sure that Cluster has a license, then navigate to the license screen via top right corner menu (logout menu)

[ ] Verify that license details are displayed.
[ ] Verify that updating a license works.

Extensions
Set the following settings in the manifest file
app.manifest.extensions.monitoring.disabled: true
app.manifest.extensions.kubernetes.disabled: true
app.manifest.extensions.logs.disabled: true

[ ] Verify that Kubernetes, Logs, and Monitoring features are hidden.

Invite Form

[x] Verify that company logo is shown.
[x] Verify input validation.
[ ] Verify that invite works with 2FA disabled.
[ ] Verify that invite works with OTP enabled.
[ ] Verify that invite works with U2F enabled.
[x] Verify that error message is shown if an invite is expired/invalid.

Login Form

[x] Verify that company logo is shown.
[x] Verify input validation.
[ ] Verify that login works with 2FA disabled.
[ ] Verify that login works with OTP enabled.
[ ] Verify that login works with U2F enabled.
[ ] Verify that SSO login works for Github/SAML/OIDC.
[ ] Verify that account is locked after several unsuccessful attempts.

GRAVITY HUB
Clusters

[ ] Verify that 2 types of cluster cards (bundle and cluster) are shown.

[ ] Verify that empty indicator is shown when there are no clusters.
Cluster Card

[ ] Verify that bundle card displays icons of installed application.
[ ] Verify that location indicator works (AWS or Onprem).
[ ] Verify that cluster labels are displayed.
[ ] Verify cluster status indicator (green/yellow/red).

Catalog

[ ] Verify that app images are displayed.

[ ] Verify that empty indicator is shown when there are no images.
App Card

[ ] Verify that dropdown with versions works.

[ ] Verify that cluster image has the right icon.

[ ] Verify that bundle image has the right icon.

[ ] Verify install instructions for cluster and bundle images.

[ ] Verify that download button works.

Licenses

[ ] Verify that license generator works.
[ ] Verify input validation by entering invalid values.

User/Auth
For Users, Roles, and Auth Connectors, please use Cluster steps to verify this functionality.
Settings
For HTTP Cerifticate and for Account, please use Cluster steps to verify this functionality.
Installer
Create a cluster image which requires EULA, a valid License, and has Bandwagon step.
Start an installer.
EULA

[ ] Verify that EULA agreement is shown asking a user to accept it.

Step. License

[ ] Verify that "License" step is shown.
[ ] Verify that step indicator has the correct number of steps (5).
[ ] Verify that error is shown when entering invalid license.

Step. Name You cluster

[ ] Verify that cluster name is required.
Additional options

[ ] Verify that input validation for subnet values works.
[ ] Verify that creating cluster labels works.

Step. Capacity

[ ] Verify that profile selector works.
[ ] Verify that input fields for IP Address and Mounts work (check input validation).
[ ] Verify that "VERIFY" button works (should show a notification banner on top).

Step. Progress

[ ] Verify that progress indicator works.
[ ] Verify that installation logs work.
[ ] Verify that when installation fails, the error is shown with "DOWNLOAD TARBALL" button.

Step. Create Admin

[ ] Verify that creating an admin user works. After submitting a form, a user should be redirected to the cluster UI.

RBAC
Create the following role
  kind: role
  metadata:
    name: no_access
  spec:
    allow:
      kubernetes_groups:
      - admin
      logins:
      - root
      node_labels:
        '*': '*'
      rules:
      - resources:
        - cluster
        - role
        verbs:
        - read
    deny: {}
    options:
  version: v3

[x] Verify that a user has access only to: Nodes, Logs, Operations.
[x] Verify that Nodes screen does not display k8s labels.

Add Role list access.
    - resources:
      - role
      verbs:
      - read

[x] Verify that a list of roles is visible.
[x] Verify that changing/creating a role is not allowed.

Add Role update access.
    - resources:
      - role
      verbs:
      - update

[ ] Verify that changing/creating a role is allowed.

Add Event list access.
    - resources:
      - event
      verbs:
      - list

[x] Verify that list of events is displayed. In Event tab and on the Dashboard.

Add Log forwarder list access.
  - resources:
    - logforwarder
    verbs:
    - list

[x] Verify that a list of log forwarders is visible.
[x] Verify that changing/creating a log forwarder is not allowed.

Add Log forwarder update access.
    - resources:
      - logforwarder
      verbs:
      - update

[ ] Verify that changing/creating a log forwarder is allowed.

Add Auth Connector list access.
    - resources:
      - auth_connector
      verbs:
      - list

[ ] Verify that a list of auth connectors is visible.
[ ] Verify that changing/creating an auth connector is not allowed.

Add auth_connector update access.
    - resources:
      - auth_connector
      verbs:
      - update

[ ] Verify that changing/creating an auth connector is allowed.

Add app list access.
    - resources:
      - app
      verbs:
      - list

[ ] Verify that list of apps is displayed in Gravity HUB.

Add Cluster connect access.
    - resources:
      - cluster
      verbs:
      - connect

[ ] Verify that K8s tab is displayed.
[ ] Verify that Nodes screen displays K8s labels.

the RBAC role is not working... had to use:
kind: role
metadata:
  # insert the name of your role here:
  name: test_manual

spec:
  # This example defines an administrative role. It maps to Kubernetes "admin"
  # group and allows SSH to every node.
  allow:
    # This role is mapped to Kuberntes 'admin' group.
    kubernetes_groups: [admin]

    # List of allowed SSH logins
    logins: [root]

    # List of node labels that users can SSH into
    node_labels:
      '*': '*'

    # RBAC rules for various resources within a cluster.
    rules:
    - resources: ['cluster','role']
      verbs: ['read']

  # The 'deny' section can have similar settings that override their 'allow' counterparts
  deny:
    logins: []

  options:
      # Limits user credentials to 8 hours. After the time to live (TTL) expires,
      # users must re-login
      max_session_ttl: 8h0m0s
  # the deny section uses the identical format as the 'allow' section.
  # the deny rules always override allow rules.
  deny: {}
version: v3

The text for the Role list access is wrong... it has read in the example code instead of list

The test for Role's update FAILED.
Adding update doesn't allow you to change existing roles cause it's complaining you don't have the role permission of create.
Adding create to the role resource fixes the problem but it also allows to create NEW roles... so that's an issue.

The test for LogForwarder's update FAILED.
Adding update doesn't allow you to change settings for the log forwarder cause it's complaining you don't have the logforwarder permission create.

The test for Auth Connector FAILED.
Adding update doesn't allow you to change settings for the auth connector cause it's complaining you don't have the create permission.

Can't see any "Bundle" Card... I do see a "Catalog" card though, not sure if that's what was being referred to or not.
Failed test: no Bundle card present.

The installer license in the license tab are wrong. They say:
2. Run the following command
gravity install --license=$(cat license.pem)

While they should say:
2. Run the following command
gravity install --license-file=license.pem

or
2. Run the following command
gravity install --license="$(cat license.pem)"

Looks like there is some duplication between the UI and the licensing test plan.  I checked off the following bits in https://github.com/gravitational/gravity/issues/1132

License
Make sure that Cluster has a license, then navigate to the license screen via top right corner menu (logout menu)

[ ] Verify that license details are displayed.
[ ] Verify that updating a license works.

The other licensing bits look more unique to UI.


[TypeScript] Support default exports in TSExportAssignment.

Allows TypeScript export assignments of default identifiers and/or mixed merged declarations. E.g.:
declare const foobar: number;
export = foobar;

declare function foobar(): void;
declare namespace foobar {
  type MyType = string
}
export = foobar;

import { foobar } from './module';
export = foobar;

// No longer reports missing default export
import foobar, { MyType } from './foobar';

Fixes: #1527

Coverage decreased (-0.4%) to 96.151% when pulling 86d2effe19dad0d5d8a455cc7634c013a2d33cec on joaovieira:extend-ts-export-assignment into 112a0bf442e52b25cd7029a9905df2508e191ac1 on benmosher:master.

Coverage decreased (-0.4%) to 96.151% when pulling 86d2effe19dad0d5d8a455cc7634c013a2d33cec on joaovieira:extend-ts-export-assignment into 112a0bf442e52b25cd7029a9905df2508e191ac1 on benmosher:master.

Coverage decreased (-0.4%) to 96.151% when pulling 86d2effe19dad0d5d8a455cc7634c013a2d33cec on joaovieira:extend-ts-export-assignment into 112a0bf442e52b25cd7029a9905df2508e191ac1 on benmosher:master.

Coverage decreased (-0.4%) to 96.151% when pulling 86d2effe19dad0d5d8a455cc7634c013a2d33cec on joaovieira:extend-ts-export-assignment into 112a0bf442e52b25cd7029a9905df2508e191ac1 on benmosher:master.

Coverage decreased (-0.4%) to 96.151% when pulling 86d2effe19dad0d5d8a455cc7634c013a2d33cec on joaovieira:extend-ts-export-assignment into 112a0bf442e52b25cd7029a9905df2508e191ac1 on benmosher:master.

It should read about esModuleInterop option or add an equal option for this plugin instead of hard coding the logic.

@JounQin can you elaborate?
TS's module system is broken without synthetic imports and esModuleInterop enabled; I'm completely comfortable telling people they need to enable those if they want stuff to work properly.

What a great PR! I was searching for a solution all day, finally gave up and started to dig into the sources. Strangely enough, this PR didn't come up while I was searching for similar issues.
So, I started coding basically the same thing: #1689
@JounQin I agree with you, in up PR I'm reading from tsconfig.json. But, there might be multiple tsconfigs and they might include/exclude specific files. So, the best approach would be to first, figure out which tsconfig is covering file where the import is made and then check if that config has esModuleInterop enabled.
Here's an example of code from eslint-import-resolver-typescript that does kind of similar thing:
mappers = configPaths!
  // turn glob patterns into paths
  .reduce<string[]>(
    (paths, path) => paths.concat(isGlob(path) ? globSync(path) : path),
    [],
  )
  .map(loadConfig)
  .filter(isConfigLoaderSuccessResult)
  .map(configLoaderResult => {
    const matchPath = createMatchPath(
      configLoaderResult.absoluteBaseUrl,
      configLoaderResult.paths,
    )

    return (source: string, file: string) => {
      // exclude files that are not part of the config base url
      if (!file.includes(configLoaderResult.absoluteBaseUrl)) {
        return undefined
      }

      // look for files based on setup tsconfig "paths"
      return matchPath(source, undefined, undefined, extensions)
    }
  })

That being said, we should either do the right thing and figure out how to handle complex cases. Or, we can do the simple thing and only cover simple case (only root tsconfig) or introduce new leg in parserOptions that will also act globally but will be more explicit than assuming that everybody has only one tsconfig.
Also, I can't disagree with @ljharb about assuming that everyone uses esModuleInterop nowadays. It seems to be a pretty popular flag to use. And in this case, I would be very happy to see this PR merged, thanks!

Nice fixing :rocket:! When is it going to be released?


Refactor mixin with global vars/add flyout shadow to triangles

Might have to look at these further but for now they look like this, have refactored the mixin - removed any flyout vars, will remove from flyout vars now.

Have removed magic numbers and removed redundant code.

Have moved as much as possible to the mixin - have tested on a card, however the positioning for these will be slightly different as they are positioned differently than the toggles. For the 'magic number' I have passed this in on the mixin using a $position var so regardless of what size you set the $size you can then change the positioning of the arrow from the container.