Random note

Is your feature request related to a problem? Please describe.
Firstly, thanks for the amazing project. I absolutely love using quartz for organizing my knowledge.
wonder if you consider "Open Random note" like Obsidian

sometimes I just open random notes for improving the contents or fixing if there is wrong information.

Hey! This is now possible to do with a custom Quartz component in Quartz v4. I probably won't add this as a core Quartz feature but you're free to implement it yourself.


adding back to top button

added the button

closes #140

@saadgibawa Great work.

@aslams2020 Thankyou for the opportunity. It was a wonderful experience contributing to your project!

Keep Contributing🚀


[SPARK-17509][SQL]When wrapping catalyst datatype to Hive data type avoid…

What changes were proposed in this pull request?
When wrapping catalyst datatypes to Hive data type, wrap function was doing an expensive pattern matching which was consuming around 11% of cpu time. Avoid the pattern matching by returning the wrapper only once and reuse it.
How was this patch tested?
Tested by running the job on cluster and saw around 8% cpu improvements.

cc - @rxin

Test build #65280 has started for PR 15064 at commit 19a2d96.

Test build #65280 has finished for PR 15064 at commit 19a2d96.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65280/
Test FAILed.

Fix build.

Test build #65292 has started for PR 15064 at commit f247693.

Test build #65292 has finished for PR 15064 at commit f247693.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65292/
Test FAILed.

This seems like a good idea. I'll take another look as soon as it passes tests.

Test build #65463 has started for PR 15064 at commit 31b2e6b.

Test build #65464 has started for PR 15064 at commit 87a96d9.

Test build #65464 has finished for PR 15064 at commit 87a96d9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65464/
Test PASSed.

Test build #65469 has started for PR 15064 at commit 2ec685c.

Test build #65463 has finished for PR 15064 at commit 31b2e6b.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65463/
Test PASSed.

cc @cloud-fan @hvanhovell

@sitalkedia can you fix the title?

@rxin - fixed, thanks.

Test build #65469 has finished for PR 15064 at commit 2ec685c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65469/
Test PASSed.

Merged build finished. Test PASSed.

the title is not fixed yet

I have a dumb question. I saw your PR description shows the CPU time measurement for the wrapping functions. Could you share it with the community?
Finding the critical paths is very important for further performance improvement. We might need to regularly monitor the top n to avoid potential performance regression.

Test build #65493 has started for PR 15064 at commit cba0b82.

the title is not fixed yet

@cloud-fan - I updated the PR title, what I am missing?

Test build #65493 has finished for PR 15064 at commit cba0b82.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65493/
Test FAILed.

Test build #65495 has started for PR 15064 at commit 77485cd.

@gatorsmile - We do have Linux Perf/flamegraph support for gathering CPU stats for our Spark jobs. On a per job basis, we run Perf/Jstack periodically and aggregate the result which is displayed as a flamegraph. Please read http://www.brendangregg.com/blog/2014-06-12/java-flame-graphs.html to know more about linux Perf and flamegraph integration. This gives us a aggregated view of time spent on a particular function across executors running on hundreds of nodes. This enables us to find hot spots in the code which is super critical for perf improvements.

Test build #65495 has finished for PR 15064 at commit 77485cd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65495/
Test PASSed.

@sitalkedia Thank you very much for sharing it!

Test build #65503 has started for PR 15064 at commit b15eda1.

Test build #65503 has finished for PR 15064 at commit b15eda1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65503/
Test PASSed.

Rebased with latest master. cc - @cloud-fan

Test build #65612 has started for PR 15064 at commit a919016.

Test build #65612 has finished for PR 15064 at commit a919016.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65612/
Test PASSed.

ping!

Merging in master. Thanks!

Thanks @rxin !


Introduce BigInt type with toString method (no arithmetics yet)

This pull request adds basic support for the BigInt type (bigint literals, toString). However, this pull request also contains unfinished changes to memory allocation so bugs might occur (specifically, static and dynamic allocation can collide).

Maybe I'm missing something as well, but are the memory changes really related to BigInts?

Yeah, I just had them in the same branch more or less accidentally.

Then, either this PR's title should be changed, or that functionality should be separated into another PR (the better choice imo)

Okay, this was slightly annoying to do but I now re-organized this branch to only contain bigint stuff


more informative page titles for browser history

Back in #130 the html titles for gene, publication, and ontology term pages got nice informative titles, which show up in helpful places like tab headers and history entries.
I would find it very useful indeed to do the same for the static pages, search, and basically anything else that doesn't already have something more informative than just "PomBase". Right now I have some browser tabs with just "PomBase" over and over again in the history, and that doesn't really tell me where I've been ;)
@kimrutherford - I am happy to do the relevant static pages additions/edits if you can tell me what to edit where. I think you'll have to do the search page and any other pages that don't come from the /frontend/src/docs/ directory

Thanks.  I'll have a think about the best way to do this.

Right now I have some browser tabs with just "PomBase" over and over again in the history, and that
doesn't really tell me where I've been

I've notice a related problem - for me in Chrome the history always says "PomBase" for every page.  Firefox has the expected gene, term and publication page titles in the history.
I'm still working on improving the titles.

The documentation page titles are now displayed in the browser window title.  I still haven't worked out why the page titles don't show up in the history in Chrome.

Did you figure this out with the recent changes?

It still works fine for me on Firefox but not in Chrome. I do another Google search for solutions. It might be a quick tweak.

I think I've the weirdness in Chrome.  The page title now consistently show up in the history.  The problem was that each time a new page was displayed, the title was being set to a default ("PomBase") and then later set to the page specific title.  It seems that Chrome doesn't like that and it's also necessary.  Now that the title is just being set once the history works.
It's possible that this was also causing the Google search results for genes (#1039) to be quite poor.  We'll see.
I've leaving this open because the title isn't set for all documentation pages yet.  That's still in progress.

I think I've the weirdness in Chrome.

Should be "I think I've fixed the weirdness in Chrome."

I've leaving this open because the title isn't set for all documentation pages yet. That's still in progress.

Now I've checked, it's looking quite good.  The title changes as you navigate around the site, including the documentation.
So I'll close this.
Please open separate issues for any missing or not great titles.


Expansion of Key Vault Roles section

Can you expand this section taking into account the developer statement: "I don't want to handle decryption. I will ask the vault for a public key, give it to a external partner, which will encrypt the information with the given key and pass that cypher text back to me. Then I will pass it to the vault, indicating which public key generated it and the vault will reply the decrypted content."
Thank you,

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6327ed0b-21da-4c50-ea67-9699f6ceec08
Version Independent ID: fbfdb3f1-641a-6453-d4a0-e56472e71d75
Content: What is Azure Key Vault?
Content Source: articles/key-vault/general/basic-concepts.md
Service: key-vault
Sub-service: general
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@Leonardo-Ferreira
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

@jlichwa tks for the reply. Can you point me to the relevant documentation? I don't know if I made myself clear, my intent is that the private key never actually leave the vault

@Leonardo-Ferreira this document just describes basic concept, If you have general questions for Key Vault, Stack Overflow could help more. For encryption at rest with Storage you can look here : https://docs.microsoft.com/en-us/azure/storage/common/customer-managed-keys-configure-key-vault?tabs=portal

#please-close


Python 3 support

Same here... Very good library through. Is the project still alive? I would be glad to handle the python 3 support.


python_install_on_site_not working

Dear @ComePerrot,
The repository seems to fail during the cmake processing step with:
CMake Error at python/CMakeLists.txt:34 (python_install_on_site):
Unknown CMake command "python_install_on_site".

at commit: 78d55cedbde8
I had to update the jrl-cmake-modules and to include python.cmake

Merged https://github.com/ComePerrot/talos-manipulation/pull/14, so this issue should now be fixed.
Thank you for the fixes you proposed.
Fixes were already made on the branch https://github.com/ComePerrot/talos-manipulation/tree/topic/test but were not propagated to back to the devel, sorry about that.


Data mapper - Array with complex records wont open in the data mapper

I was doing a data transformation between HL7v23 and FHIR and the data records in HL7v23 which has complex records as arrays wont show its fields in data mapper. Therefore i couldn't do the correct data mapping.
For instance in the input record pid5 is a array with complex record. So if it is expanded then i could easily do the mapping to the respective field of the output record. But since it is not expanded or wont opened in the data mapper that cant be done.
Check out the discord link {Images are there}
https://discordapp.com/channels/957996897782616114/1062816978349342830/1062816978349342830
Check out my repo: https://github.com/DhanushkaSandakelum/Ballerina/tree/main/data_mapper-hl7v23_fhir_mapping

Actually the data mapper does not expand and display the fields of arrays resides within inputs since the number of fields within the array is unknown as the arrays are dynamic in most of the time. You can go with member access expression, query expressions or array functions to achieve the requirement.


Clarify licensing + MIT only

The actual compiled crafty file indicates that it's under the MIT + GPL licenses.  As flagged in issue #781, there isn't an actual license file present in the repo, and there's no mention of what version of the GPL is intended.
This adds the MIT license to the repo.  Possibly we should simply nix the mention of the GPL, since it's too vague to be useful, and the MIT is more permissive in any case.

I believe the license is indicated in some config files  -- I'll look into updating them.

I'm going to go ahead and merge this.  To address one concern from the related issue:

once decision is proposed, it needs to be approved by the author of this project - louisstow

Since he hasn't expressed any particular opinion here, I feel ok going ahead without him -- the point of dual licensing is that anyone can distribute the code under either license.  What we're doing here is simply choosing a single one of the allowed licenses to use going forward.
I created a parallel PR in the docs/site repo: craftyjs/craftyjs.github.com#77


Can't catch error if no Email client

Hi there, I can't seem to catch any errors when there was no email client on my iOS simulator.
  async openEmail() {
    try {
      await openInbox({
        message: 'select',
        cancelLabel: 'cancel',
      });
    } catch (error) {
      alert();
    }
  }

It doesn't get to the catch statement at all, but I do get a warning on the simulator as below:

Am I doing something wrong or is there a problem here?

Good catch! (sorry, I couldn't resist 😄)
I think I found the problem, and just released<EMAIL_ADDRESS>that hopefully fixes it. Would you mind giving it a try? Don't have a dev environment set up to test it myself at the moment.

😄 my pleasure! @tschoffelen
And I just tried it and it seems it's fixed, thanks a lot for the fast response!

Happy to hear!


mkreports serve has errors

When trying to run mkreports serve with a folder but no mkdocs arguments, it fails.


SPM Installation Issue when using Packages

Hi there. I tried installing SwiftLlama via SPM in my production app, but it failed. I tried in a test project as well, but I got the same error. The error is as follows:
Failed to resolve dependencies Dependencies could not be resolved because 'my_app_name' depends on 'swiftllama' 0.2.0..<1.0.0.
 'swiftllama' >= 0.2.0 cannot be used because package 'swiftllama' is required using a stable-version but 'swiftllama' depends on an unstable-version package 'llama.cpp' and no versions of 'swiftllama' match the requirement 0.2.1..<1.0.0.

For reference, this is my Package.swift and the platform is native macOS.
...
    dependencies: [
        .package(url: "https://github.com/ShenghaiWang/SwiftLlama.git", from: "0.2.0"),
    ],
    .target(
        name: "my_app_name",
        dependencies: [
            "SwiftLlama",
        ],
    )
...

Of note, this issue doesn't seem to appear when the package is integrated via Xcodes menu, but when using a modularised application and integrating SwiftLlama via it's Package.swift file it breaks.

https://github.com/ShenghaiWang/SwiftLlama/pull/12


Support for declaring index signatures using JSDoc

Suggestion
🔍 Search Terms
TS in JS, JSDoc, index signatures, class
✅ Viability Checklist

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x]  This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
I've looked around for a while and I haven't found a means to declaring an index signature on an ES6 class using JSDoc.
Take this scenario:
class Cats {
	/** @param {{ name: string, colour: string }[]} cats */
	constructor(cats) {
		for (let cat of cats) {
			this[cat.name] = cat.colour
		}
	}
}

this[cat.name] complains:
Element implicitly has an 'any' type because expression of type 'any' can't be used to index type 'Cats'.
How do we solve this using JSDoc? I know this is a non-issue when employing different paradigms (e.g. cats.reduce((cats, cat) => ({ ...cats, [cat.name]: new Cat(cat) }), {})) but that's not always the way.
In TS, it is handled as so:
class Cats {
  [name: string]: string
  constructor(cats: { name: string, colour: string }[]) {
    for (let cat of cats) {
      this[cat.name] = cat.colour
    }
  }
}

📃 Motivating Example
Looking for the equivalent of a catch-all class-wide type declaration:
class Cats {
	/** @type {{ [name: string]: string }} */

	/** @param {{ name: string, colour: string }[]} cats */
	constructor(cats) {
		for (let cat of cats) {
			this[cat.name] = cat.colour
		}
	}
}

Is implementing this possible? Or, perhaps, Is this achievable by some existing method that I missed?

@sandersn is this possible?

It is definitely possible, but this would be a new feature, so it needs a new tag, not @type. I don't even think there's an existing jsdoc tag that declares index signatures.

I don't know how much this feature makes sense. Index signature on classes are very constraining (more detail below), and all the other locations for index signatures that I can think of are in type positions, which are already possible to express in JSDoc. I think this needs better motivating examples.
Here are the examples of index signatures in classes that I can think of (thanks to @webstrand for suggesting the instanceof usage):
class Cats {
  [s: string]: Cat
  // only static methods are possible here because instance methods are not of type `Cat`
}
// more usually expressed as a module named 'cats.js'
export cats: Record<string, Cat>
// convert static methods to exported functions

// or a factory function
function makeCats() {
  const cats: Record<string, Cat> = {}
  return cats
  // static functions go here
}

// but you can use `instanceof` on Cats, unlike the 'cats.js' module:
if (obj instanceof Cats) {
  ...
}

You could also add an index signature to any or unknown, but then the contents are untyped:
class Cats {
  [s: string]: any
  // methods are OK here
}

With the advent of partial indexes, this might still have use? i.e.
namespace example {
  class EventTarget {
      [key: `on${string}`]: (event: Event) => void
  }

  class Foo extends EventTarget {
    set onclick(value: (event: string) => void) {} // mistake prevented
  }
}

playground
for instance


⚠ Bofrost.at has degraded performance

In 59cd034, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1876 ms

Resolved: Bofrost.at performance has improved in 4b59988 after 309 days, 8 hours, 23 minutes.


Connection builder

I'm thinking in make a "ConnectionBuilder" for start a new connection instead of the 'connection' and 'connection_local'. Like in the sled.
In our case we will use this for set the db dialect and more. Something like:
let mut conn = ConnectionBuilder::default()
     .host("localhost")
     .user("sysdba")
     .dialect(Dialect::D3)
     .connect()?;

What you think @jairinhohw ?

I think it will be very good.
Another way to implement this is the "init struct pattern" as described here. It can be used if all fields have a default and there is no need for per field validation. It can look like this:
let conn = Connection::new(Options {
    host: "localhost".to_string(),
    user: "sysdba".to_string(),
    dialect: Dialect::D3,
    .. Default::default(),
})?;

But i do not know if is possible to remove the to_string()s with this approach, so maybe It's better the other way.
The article describes a "hack" to make the struct non exhaustive, but there is now a #[non_exhaustive] attr (link).


update readme

Rationale
This should have been updated along with the p-256 PR and it was missed. Readme updates.
Changes

adds p-256 documentation link to readme
reworks language around indexed signatures in readme
adds details surrounding use of randomized vs deterministic signatures to readme
removes checklist items that have been completed (rather not claim we have done a thorough job in the readme, so removed)
bumps testing crate (hex-literal)

Testing

Github Actions

Thanks for merging, I missed the approval.


@conda-forge-admin please add bot automerge

[ ] I read the conda-forge documentation and could not find the solution for my problem there.

Issue:

Environment (conda list):

$ conda list

Details about  conda and system ( conda info ):

$ conda info

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/fast3tree-feedstock#4.


Bcbio small rna analysis

Hi All, Today I run small rna seq pipeline with the following template:
upload:
dir: /sc/orga/projects/stolog01a/bcbio_analysis/upload
details:

analysis: smallRNA-seq
algorithm:
aligner: star
species: hsa
description: data
genome_build: hg38

I wanted to skip trimming which I have already done myself. First does the yaml file above skips trimming because in the error atropos.py is part of the error (see below). Anyhow I get the following error:
[2018-03-15T05:31Z] QC: exosomes_1 atropos
Traceback (most recent call last):
File "software/bin/bcbio_nextgen.py", line 241, in
main(**kwargs)
File "software/bin/bcbio_nextgen.py", line 46, in main
run_main(**kwargs)
File "software_data/bcbio/anaconda/lib/python2.7/site-packages/bcbio/pipeline/main.py", line 43, in run_main
fc_dir, run_info_yaml)
File "software_data/bcbio/anaconda/lib/python2.7/site-packages/bcbio/pipeline/main.py", line 87, in _run_toplevel
for xs in pipeline(config, run_info_yaml, parallel, dirs, samples):
File "software_data/bcbio/anaconda/lib/python2.7/site-packages/bcbio/pipeline/main.py", line 335, in smallrnaseqpipeline
samples = qcsummary.generate_parallel(samples, run_parallel)
File "bcbio/anaconda/lib/python2.7/site-packages/bcbio/pipeline/qcsummary.py", line 37, in generate_parallel
qced = run_parallel("pipeline_summary", to_analyze)
File "software_data/bcbio/anaconda/lib/python2.7/site-packages/bcbio/distributed/multi.py", line 28, in run_parallel
return run_multicore(fn, items, config, parallel=parallel)
File "software_data/bcbio/anaconda/lib/python2.7/site-packages/bcbio/distributed/multi.py", line 86, in run_multicore
for data in joblib.Parallel(parallel["num_jobs"], batch_size=1)(joblib.delayed(fn)(x) for x in items):
File "software_data/bcbio/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 779, in call
while self.dispatch_one_batch(iterator):
File "software_data/bcbio/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 625, in dispatch_one_batch
self._dispatch(tasks)
File "software_data/bcbio/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 588, in _dispatch
job = self._backend.apply_async(batch, callback=cb)
File "software_data/bcbio/anaconda/lib/python2.7/site-packages/joblib/_parallel_backends.py", line 111, in apply_async
result = ImmediateResult(func)
File "software_data/bcbio/anaconda/lib/python2.7/site-packages/joblib/_parallel_backends.py", line 332, in init
self.results = batch()
File "software_data/bcbio/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 131, in call
return [func(*args, **kwargs) for func, args, kwargs in self.items]
File "bcbio/anaconda/lib/python2.7/site-packages/bcbio/utils.py", line 52, in wrapper
return apply(f, *args, **kwargs)
File "software_data/bcbio/anaconda/lib/python2.7/site-packages/bcbio/distributed/multitasks.py", line 199, in pipeline_summary
return qcsummary.pipeline_summary(*args)
File "software_data/bcbio/anaconda/lib/python2.7/site-packages/bcbio/pipeline/qcsummary.py", line 68, in pipeline_summary
data["summary"] = _run_qc_tools(work_bam, work_data)
File "software_data/bcbio/anaconda/lib/python2.7/site-packages/bcbio/pipeline/qcsummary.py", line 151, in _run_qc_tools
out = qc_fn(bam_file, data, cur_qc_dir)
File "software_data/bcbio/anaconda/lib/python2.7/site-packages/bcbio/qc/atropos.py", line 6, in run
with open(data["log_trimming"]) as inh:
IOError: [Errno 2] No such file or directory: 'bcbio_analysis/sample_info/work/trimmed/exosomes_1/exosomes_1.log'
Any ideas? Looks like some issue with multitasking. I had such a hard time to install this on the cluster and now this error drives me crazy.

Thanks much for the detailed report and apologies about the issue. It looks like the code is looking for an atropos log file which doesn't exist because you skipped trimming. I pushed a fix to the latest development version which should correctly skip this check. If you update with:
bcbio_nextgen.py upgrade -u development

and re-run your pipeline in place it should pick up where it left off and correctly skip this step. Hope this gets things working for you.

Thank you so much. I tried to upgrade but i got the following error:
Collecting bcbio-nextgen from git+https://github.com/chapmanb/bcbio-nextgen.git#egg=bcbio-nextgen
Cloning https://github.com/chapmanb/bcbio-nextgen.git to /tmp/pip-build-DCiVdh/bcbio-nextgen
error:  while accessing https://github.com/chapmanb/bcbio-nextgen.git/info/refs
fatal: HTTP request failed
Command "git clone -q https://github.com/chapmanb/bcbio-nextgen.git /tmp/pip-build-DCiVdh/bcbio-nextgen" failed with error code 128 in None
Collecting bcbio-nextgen from git+https://github.com/chapmanb/bcbio-nextgen.git#egg=bcbio-nextgen
Cloning https://github.com/chapmanb/bcbio-nextgen.git to /tmp/pip-build-k_zZuI/bcbio-nextgen
error:  while accessing https://github.com/chapmanb/bcbio-nextgen.git/info/refs
fatal: HTTP request failed
Command "git clone -q https://github.com/chapmanb/bcbio-nextgen.git /tmp/pip-build-k_zZuI/bcbio-nextgen" failed with error code 128 in None
Traceback (most recent call last):
File "/sc/orga/projects/stolog01a/software/bin/bcbio_nextgen.py", line 222, in
install.upgrade_bcbio(kwargs["args"])
File "/sc/orga/projects/stolog01a/software_data/bcbio/anaconda/lib/python2.7/site-packages/bcbio/install.py", line 63, in upgrade_bcbio
"git+%s%s#egg=bcbio-nextgen" % (REMOTES["gitrepo"], git_tag)]], anaconda_dir)
File "/sc/orga/projects/stolog01a/software_data/bcbio/anaconda/lib/python2.7/site-packages/bcbio/install.py", line 118, in _pip_safe_ssl
subprocess.check_call(cmd)
File "/sc/orga/projects/stolog01a/software_data/bcbio/anaconda/lib/python2.7/subprocess.py", line 186, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/sc/orga/projects/stolog01a/software_data/bcbio/anaconda/bin/pip', 'install', '--upgrade', '--no-deps', 'git+https://github.com/chapmanb/bcbio-nextgen.git#egg=bcbio-nextgen']' returned non-zero exit status 1

Hi,
I tried this but the error persists unfortunately here is a log:
Traceback (most recent call last):
File " software/bin/bcbio_nextgen.py", line 241, in
main(**kwargs)
File " software/bin/bcbio_nextgen.py", line 46, in main
run_main(**kwargs)
File " software_data/bcbio/anaconda/lib/python2.7/site-packages/bcbio/pipeline/main.py", line 43, in run_main
fc_dir, run_info_yaml)
File " software_data/bcbio/anaconda/lib/python2.7/site-packages/bcbio/pipeline/main.py", line 87, in _run_toplevel
for xs in pipeline(config, run_info_yaml, parallel, dirs, samples):
File " software_data/bcbio/anaconda/lib/python2.7/site-packages/bcbio/pipeline/main.py", line 334, in smallrnaseqpipeline
samples = qcsummary.generate_parallel(samples, run_parallel)
File " software_data/bcbio/anaconda/lib/python2.7/site-packages/bcbio/pipeline/qcsummary.py", line 37, in generate_parallel
qced = run_parallel("pipeline_summary", to_analyze)
File " software_data/bcbio/anaconda/lib/python2.7/site-packages/bcbio/distributed/multi.py", line 28, in run_parallel
return run_multicore(fn, items, config, parallel=parallel)
File " software_data/bcbio/anaconda/lib/python2.7/site-packages/bcbio/distributed/multi.py", line 86, in run_multicore
for data in joblib.Parallel(parallel["num_jobs"], batch_size=1)(joblib.delayed(fn)(x) for x in items):
File " software_data/bcbio/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 779, in call
while self.dispatch_one_batch(iterator):
File " software_data/bcbio/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 625, in dispatch_one_batch
self._dispatch(tasks)
File " software_data/bcbio/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 588, in _dispatch
job = self._backend.apply_async(batch, callback=cb)
File " software_data/bcbio/anaconda/lib/python2.7/site-packages/joblib/_parallel_backends.py", line 111, in apply_async
result = ImmediateResult(func)
File " software_data/bcbio/anaconda/lib/python2.7/site-packages/joblib/_parallel_backends.py", line 332, in init
self.results = batch()
File " software_data/bcbio/anaconda/lib/python2.7/site-packages/joblib/parallel.py", line 131, in call
return [func(*args, **kwargs) for func, args, kwargs in self.items]
File " software_data/bcbio/anaconda/lib/python2.7/site-packages/bcbio/utils.py", line 52, in wrapper
return apply(f, *args, **kwargs)
File " software_data/bcbio/anaconda/lib/python2.7/site-packages/bcbio/distributed/multitasks.py", line 199, in pipeline_summary
return qcsummary.pipeline_summary(*args)
File " software_data/bcbio/anaconda/lib/python2.7/site-packages/bcbio/pipeline/qcsummary.py", line 68, in pipeline_summary
data["summary"] = _run_qc_tools(work_bam, work_data)
File " software_data/bcbio/anaconda/lib/python2.7/site-packages/bcbio/pipeline/qcsummary.py", line 151, in _run_qc_tools
out = qc_fn(bam_file, data, cur_qc_dir)
File " software_data/bcbio/anaconda/lib/python2.7/site-packages/bcbio/qc/atropos.py", line 5, in run
if "log_trimming" in data and utils.file_exists(data["log_trimming"]):
NameError: global name 'utils' is not defined
This error is new i believe "NameError: global name 'utils' is not defined". Any more guidance?


clean and works: thank you!

Your version suits better my needs (and my way coding).
Thank you!
Now I can use beacons in iOS and in Android 👍 +1

it is not an issue (as title says 😄 )

Hey! Thanks and glad to know it works! 👍
Please keep me updated on any issue you find and feel free to send any PR/request!

@mmazzarolo sure.
I'm preparing a super simple project just for showing iOS and Android RN examples for playing with iBeacons.
I will give you link when I'm done so that it will be at least a 1st example to implement it with react-native-beacons-android.
Have a look at iOS version this PR#44 to help others like me

Nice!
Don't know if you're interested but here is a little helper I'm using for handling both react-native-ibeacon and react-native-beacons-android (It is exaggeratedly verbose and customized, I know, but I did it this way for simplifying my unit-testing):
/* eslint-disable global-require */
import { DeviceEventEmitter, Platform } from 'react-native'
import Keys from '../config/keys'
import i18n from '../i18n'

const IS_ANDROID = Platform.OS === 'android'
let Beacons
if (IS_ANDROID) {
  Beacons = require('react-native-beacons-android')
} else {
  Beacons = require('react-native-ibeacon')
}

export const initializeBeaconsHandler = () => {
  if (IS_ANDROID) {
    Beacons.detectEstimotes()
  } else {
    Beacons.requestWhenInUseAuthorization()
  }
}

// MobX stuff, can be easily replaced with Redux/anything else
export const connectBeaconsEventsToStore = (museumsStore, beaconsStore) => {
  DeviceEventEmitter.addListener('beaconsDidRange', (obj) => {
    const { beacons } = obj
    beaconsStore.setBeaconsInRange(beacons)
  })
}

export const startRanging = async () => {
  try {
    if (IS_ANDROID) {
      const transmissionSupport = await Beacons.checkTransmissionSupported()
      if (transmissionSupport !== 'SUPPORTED') {
        const errorMessage = i18n.t(`ERROR_${transmissionSupport}`)
        throw new Error(errorMessage)
      }
      await Beacons.startRangingBeaconsInRegion(Keys.BEACONS_REGION_ID, Keys.BEACONS_UUID)
    } else {
      const region = { identifier: Keys.BEACONS_REGION_ID, uuid: Keys.BEACONS_UUID }
      Beacons.startRangingBeaconsInRegion(region)
    }
    return ({ result: 'success' })
  } catch (e) {
    console.log(e)
    return ({ error: e.message || 'Something bad happened' })
  }
}

export const stopRanging = () => {
  if (IS_ANDROID) {
    Beacons.stopRangingBeaconsInRegion()
  } else {
    const region = { identifier: Keys.BEACONS_REGION_ID, uuid: Keys.BEACONS_UUID }
    Beacons.stopRangingBeaconsInRegion(region)
  }
}

Nice, thank you.
Nice idea: I guess I will make then another example — more advanced and better for production — later using this (I agree with you and I will already use it on my projects).
I'd like the 1st example to be as easy as possible not to scary newcomers 😄 (it takes time for me to make it clear since I have habbits that are not for newcomers).

1st example:  simple project.
Thank you @mmazzarolo !
Hope we will se even more beacon apps or new ideas from beacons.

@MacKentoch: awesome man, added to the README 💇

@mmazzarolo is it possible to range for multiple beacons? Something like this:
_.forEach(portraitData, (portrait) => {
Beacons.startRangingBeaconsInRegion('REGION1', portrait.uuid)
.then(() => console.log(Beacons ranging started succesfully))
.catch(error => console.log(Beacons ranging not started, error: ${error}));
});
When I run this, it seems to only monitor the last UUID in portraitData. Any ideas?

@mint3000, let's discuss it on #12 👍


Getting error: CUDA is not available

Getting this error when creating an endpoint in sagemaker
`2024-03-19T16:31:57.748653Z  INFO download: lorax_launcher: Successfully downloaded weights.
2024-03-19T16:31:57.748840Z  INFO shard-manager: lorax_launcher: Starting shard rank=0
2024-03-19T16:32:01.362713Z ERROR lorax_launcher: server.py:273 Error when initializing model
Traceback (most recent call last):
File "/opt/conda/bin/lorax-server", line 8, in
sys.exit(app())
File "/opt/conda/lib/python3.10/site-packages/typer/main.py", line 311, in call
return get_command(self)(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 1157, in call
return self.main(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/typer/core.py", line 778, in main
return _main(
File "/opt/conda/lib/python3.10/site-packages/typer/core.py", line 216, in _main
rv = self.invoke(ctx)
File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 783, in invoke
return __callback(*args, **kwargs)
File "/opt/conda/lib/python3.10/site-packages/typer/main.py", line 683, in wrapper
return callback(**use_params)  # type: ignore
File "/opt/conda/lib/python3.10/site-packages/lorax_server/cli.py", line 89, in serve
server.serve(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/server.py", line 317, in serve
asyncio.run(
File "/opt/conda/lib/python3.10/asyncio/runners.py", line 44, in run
return loop.run_until_complete(main)
File "/opt/conda/lib/python3.10/asyncio/base_events.py", line 636, in run_until_complete
self.run_forever()
File "/opt/conda/lib/python3.10/asyncio/base_events.py", line 603, in run_forever
self._run_once()
File "/opt/conda/lib/python3.10/asyncio/base_events.py", line 1909, in _run_once
handle._run()
File "/opt/conda/lib/python3.10/asyncio/events.py", line 80, in _run
self._context.run(self._callback, *self._args)

File "/opt/conda/lib/python3.10/site-packages/lorax_server/server.py", line 269, in serve_inner
model = get_model(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/init.py", line 179, in get_model
from lorax_server.models.flash_mistral import FlashMistral
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/flash_mistral.py", line 21, in
from lorax_server.models.custom_modeling.flash_mistral_modeling import (
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_mistral_modeling.py", line 32, in
from lorax_server.utils.flash_attn import HAS_FLASH_ATTN_V2
File "/opt/conda/lib/python3.10/site-packages/lorax_server/utils/flash_attn.py", line 10, in
raise ImportError("CUDA is not available")
ImportError: CUDA is not available

2024-03-19T16:32:02.153071Z ERROR shard-manager: lorax_launcher: Shard complete standard error output:
/opt/conda/lib/python3.10/site-packages/bitsandbytes/cextension.py:34: UserWarning: The installed version of bitsandbytes was compiled without GPU support. 8-bit optimizers, 8-bit multiplication, and GPU quantization are unavailable.
warn("The installed version of bitsandbytes was compiled without GPU support. "
Traceback (most recent call last):
File "/opt/conda/bin/lorax-server", line 8, in
sys.exit(app())
File "/opt/conda/lib/python3.10/site-packages/lorax_server/cli.py", line 89, in serve
server.serve(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/server.py", line 317, in serve
asyncio.run(
File "/opt/conda/lib/python3.10/asyncio/runners.py", line 44, in run
return loop.run_until_complete(main)
File "/opt/conda/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
return future.result()
File "/opt/conda/lib/python3.10/site-packages/lorax_server/server.py", line 269, in serve_inner
model = get_model(
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/init.py", line 179, in get_model
from lorax_server.models.flash_mistral import FlashMistral
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/flash_mistral.py", line 21, in
from lorax_server.models.custom_modeling.flash_mistral_modeling import (
File "/opt/conda/lib/python3.10/site-packages/lorax_server/models/custom_modeling/flash_mistral_modeling.py", line 32, in
from lorax_server.utils.flash_attn import HAS_FLASH_ATTN_V2
File "/opt/conda/lib/python3.10/site-packages/lorax_server/utils/flash_attn.py", line 10, in
raise ImportError("CUDA is not available")
ImportError: CUDA is not available
rank=0
2024-03-19T16:32:02.252292Z ERROR lorax_launcher: Shard 0 failed to start
2024-03-19T16:32:02.252322Z  INFO lorax_launcher: Shutting down shards
Error: ShardCannotStart`

seems to be an issue with lorax 0.8.1 container that I haven't looked into, just pushed a change to fix on version 0.8.0, please retry with this

It worked. Thank you @joaopcm1996

I came across this same issue today! Thanks for the clarification @joaopcm1996

@joaopcm1996 Question for you if you get a second - I'm running a training job using the JumpStartEstimator which stores lora weights in s3 as .safetensor files. Then, in attempting to reference the adapter weights in my payload to the Predictor object which is pointing to my deployed base model endpoint (pulling in LoRAX), I get an error where the Predictor is expecting .bin files. Have you come across this?

To clarify on the above, the issue is not on LoRAX, seems to be an issue with NVIDIA driver version on SM Endpoints.
@yash11021 I have not run into this, I think LoRAX should accept .safetensor format.


go-debug Failed

toggle the dev tools panel,and i see
go-debug Failed to get "dlv" TypeError: Cannot create property 'timeout' on string 'project'     at Executor.ensureOptions (/Users/cjy/.atom/packages/go-plus/executor.js:168:7)     at Promise (/Users/cjy/.atom/packages/go-plus/executor.js:67:29)     at Executor.exec (/Users/cjy/.atom/packages/go-plus/executor.js:66:12)     at getVersion (/Users/cjy/.atom/packages/go-debug/lib/delve-get.js:31:30)     at located (/Users/cjy/.atom/packages/go-debug/lib/delve-get.js:23:14)

Should be fixed with 1.5.3. Please update go-debug.


how can we get datasets?

hi,
Thanks to Pytroch Version.
Where could I get the datasets?

hi,
Thanks to Pytroch Version.
Where could I get the datasets?

I Got it from the README file , thanks


Retire Thingiverse provider script

Description

The Thingiverse provider script & DAG should be moved to the "retired" DAGs folder until it can be revised when 3D models are implemented.
Alternatives

The rationale for this decision can be found on our Make WP blog: Next steps for Thingiverse data.
Additional context

Implementation

[ ] 🙋 I would be interested in implementing this feature.

This will unblock https://github.com/WordPress/openverse-catalog/issues/65!


[7.x] Add support for Arr::group

Made the PR towards 7.x due to the release coming next week.
Was generally wondering why this wasn't added previously. :) Made a simple implementation for grouping array-like structures compared to the Collection::groupBy functionality but one which comes in handy when working with plain arrays. It differentiates by keeping everything array related instead of creating new Collection instances.
I found a couple of occurrences in the framework which could also use this method and added them to the pull request. If I've missed possible usages or missed any preferred functionality, let me know. Love to adjust it where needed.
Cheers,
L

This works differently than the collection->groupBy method... It seems like we would want them to behave exactly the same?

Hi @taylorotwell!
Thanks for the response. We could - chose to apply key preservation by default in this case. Will push a change which adds a separate argument for this choice as is done with Collection->groupBy.
Cheers,
L

Personally I think it should behave exactly like Collection@groupBy.

But, at that point part of me wonders what is the point of making this method since you could just collect() your array and call groupBy?

Part of the gain was not using a collection at places where it shouldn't be necessary but in some cases, you actually want different behaviour than toArray or all is giving you.
toArray also creates arrays of models used inside of the collections and all is returning the grouped Collection instances which therefore alters the structure of the data we put in. Might be that I'm overlooking something, let me know if I do.
I will adjust the functionality to move more towards Collection->groupBy by dropping the $default support and adding the $preserveKeys param. The main difference between them after that is the multiple grouping method which is supported by Collection->groupBy. The more complex structures could still reside in the Collection class IMO while Arr::group supports most of the generic cases.
Let me know,
L

I think I will just hold off on this for now.

Hi @taylorotwell,
I saw you closed the pull request. Updated the branch anyway to match the outcome structure-wise to Collection->groupBy. To elaborate more on the differences and why this might be a valid addition I've added a test case with a Model instance. I added the differences in outcome below;
Input
[
    $this->getMockForAbstractClass(Model::class)->forceFill(['type' => 'desk']);
]

Output Collection->groupBy()->all();
^ array:1 [
  "desk" => Illuminate\Support\Collection^ {#297
    #items: array:1 [
      0 => Mock_Model_6a3bd8a9^ {#298 …30}
    ]
  }
]

Output Collection->groupBy()->toArray()
^ array:1 [
  "desk" => array:1 [
    0 => array:1 [
      "type" => "desk"
    ]
  ]
]

Output Arr::group
^ array:1 [
  "desk" => array:1 [
    0 => Mock_Model_53d4e67a^ {#298 …30}
  ]
]

I think each of the methods has its own purpose and its own use case. If you see the above as a beneficial addition I would love to open the pull request once more. The current state of the code can be found here; https://github.com/laravel/framework/compare/7.x...LarsGrevelink:feature/support-arr-group
Thanks,
L


Using ngx-combo-datepicker in library

I am trying to use this in a library and am getting the following error....
node_modules/ngx-combo-datepicker/node_modules/@angular/core/src/render3/ng_dev_mode.d.ts(9,11): error TS2451: Cannot redeclare block-scoped variable 'ngDevMode'.
I believe the dependencies in package.json needs to be defined as peerDependencies to resolve this issue.

Something like this?
https://github.com/katafractari/ngx-combo-datepicker/pull/10

Yes

@silvl Fixed in 0.0.7. Thanks for your contribution!


Reduce warnings

This PR addresses Error Prone and Javadoc warnings.
It also improves work with FieldMasks in the way suggested by the standard FieldMaskUtil class. Previously, we constructed FieldMask manually via its Builder, assuming that field names are fully-qualified names. It turned out that they should be non-qualified names, and FieldMaskUtility class addresses our needs.

@armiol, @dmdashenkov, PTAL.

There are still three Error Prone warnings left. I'm planning to address them in one of the future PRs.


fix: get latest aws-nuke release. Stop using fork of aws-nuke

Types of changes
Get the latest release version on aws-nuke. Old version isn't cleaning up all resources in accounts resulting in dirty accounts.

[X] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] Refactor (changes to code, which do not change application behavior)

Checklist

[X] I have filled out this PR template
[X] I have read the CONTRIBUTING doc
[ ] I have added automated tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (README.md, inline comments, etc.)
[ ] I have updated the CHANGELOG.md under a ## next release, with a short summary of my changes

Relevant Links
https://github.com/rebuy-de/aws-nuke

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: jrsholly:x: ShollenbargerShollenbarger seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Bad key from db_seed_all (shabdartha_kaustubha)

Probably not a big deal, but there are a lot of "bad key" error messages like this:
python -m ambuda.seed.dictionaries.shabdartha_kaustubha
Initializing database ...
Fetching data from GitHub ...
Adding items to database ...
  bad key: aGaGna-nASana
  bad key: aNgulimòwina
  bad key: atigurvI-guru
  bad key: aDivèttavyA
  bad key: aDo'kza
  bad key: aDo'kzaja
  bad key: aDòBakta
  bad key: aDyètavya
  bad key: avacikI (cI) zA
  bad key: avacUqa(la)
  bad key: avahe(la)lA
  bad key: avAk(c)
  bad key: ati + asu|atyastaH
  bad key: vi + ati + asu|vyatyastaH
  bad key: aDi + asu|aDyAsaH
…

Probably the dictionary is in a different format or something. It's probably ok to ignore these errors for now as everything works regardless.

Yeah, these are just warnings. Feel free to send a PR to make the behavior here more obvious, or maybe flag guard the warnings with a --verbose.


Feature Request: End-to-End Logging Including Intermediate Steps in crewAI

Hello crewA Team,
Thank you for this awesome project!
I was wondering if there is a possibility of enhancing the logging capabilities of the crewAI. Currently, I am able to log the output of tasks, but an integrated feature for end-to-end logging, capturing all intermediate steps, would significantly improve the utility and debugging capabilities of the package.

@joaomdmoura I like this - I think a well-implemented auditing feature is needed for prod environments. Options for writing to various data stores, etc

Indeed, log is a must, right now you can it with LangSmight and other but we should have an native option, marking as feature accepted

I agree, i'd like to send everything that is printed in console via WebSockets to a web client.

I also really need this feature to go to production using crewAI. I would like to store this information in a separate data store. Ideally I would be able to easily tell for each agent, each step in their thought process - what task they were trying to solve, what tool they used, what the input and output of the tool was, etc.

This feature would be very nice to have.- Thanks for this awesome product.

Please implement this .
An option in the agent that yields or streams its thoughts, actions is required.
I’m trying to implement this with websocket myself, but it’s challenging and should be done lower down.

what are other frameworks other than langsmith supported?

what are other frameworks other than langsmith supported?

You can try langtrace, langfuse and AgentOps.

what are other frameworks other than langsmith supported?

You can try langtrace, langfuse and AgentOps.

langfuse is giving  object not calleable error. Langsmith works out of the box.
Any workaround to get it by langfuse as well?

Maybe contact langfuse support and see if they have any known issues. thanks

Any open source tools for logging?


I have tried to install using the Plugin Manager and Manually

I get this message at the end of the installation "Error!Could not parse output from pip, see plugin_pluginmanager_console.log for generated output"

Hello i see that y have the same probleme with python2.7
plugin_pluginmanager_console.log
octoprint.log
but not find too fix

i put the libjpeg -dev
and now i works
Super best regards.

@dwcservices are you still running into this issue?

No
I tried your thing and it worked
your app works great
thank you for your help

Excellent. Great to hear that. Closing ticket then.
Enjoy
Gaston


Allow generation of Twirp in a different Golang Package

I'll keep this pretty short for now (I also know we discussed this very briefly @spenczar) but just to get the conversation going since this is on my near-term radar:

It would be nice to be able to have twitchtv/twirp generated code in a different package than the golang/protobuf generated code. This in theory would allow you to have separation of your Protobuf definitions and the specific RPC protocol you use. For example, I'd love to have:

foo/barpb - Protobuf messages for package foo.bar

foo/twitchbarpb - Twirp client/servers for package foo.bar

foo/grpcbarpb - gRPC client/servers for package foo.bar - I'm not sure if this is will be allowed with the new protoc-gen-go-grpc via https://github.com/protocolbuffers/protobuf-go/blob/master/compiler/protogen/protogen.go but we can leave this out of it

foo/magicbarpb - My custom magical RPC implementation (not in reality but as an example)

What this would require is protoc-gen-twirp recognizing when it was generating code in a different package than the package of the golang/protobuf generated code, and then generating imports, ie:
// all shorthand, not even importing context
import barpb "github.com/alice/bob/foo/barpb"

type EchoService interface {
  Echo(context.Context, *barpb.EchoRequest) (*barpb.EchoResponse, error)
}

This might be able to be implemented with some combination of the Mkey=value (which would be annoying), import_path, and import_prefix options, but honestly it would be so much easier if there was just a definition_path=github.com/alice/bob/foo/barpb option or something similar to just denote this easily. There are Golang Protobuf plugin libraries that handle this kind of behavior, so there's a lot of work to pattern off of.
Thoughts?

As far as I know, this should be working today. This test case does it: https://github.com/twitchtv/twirp/blob/master/internal/twirptest/importer/importer.proto#L10
Do you have a case that's not working?

This test case isn’t it - this is where the message definitions for the request/response types are in a different package - what I’m looking for is where you have messages in the same package, but you want twirp to generate to a different golang package than the golang package of the message definitions.

@bufdev message definitions are generated with protoc go_out, not twirp. I'd move those definitions into a subfolder designating the package, and protoc generate them separately (will be it's own package). You can also force protoc to generate the message output into different packages on it's own, but twitch will of course not pick them up, as this relationship doesn't come from proto files.
For example, you can do:
package message;

import "rpc/user/user.proto";

And then use user.User or whatever in your local messages, or RPC definitions. With the import rule you have the explicit relationship defined, and the package source for the user scoped types too. The correct way would be to split up messages and import them, twirp respects this.

This is not the issue - yes, of course you could put your service definitions in another package. However, I would like twirp to our services definitions in the same package into a different golang package. Please read my original description in this issue.

I got it, I just explained that's not how it works because the codegen needs to know these relationships, and import is the way the codegen knows about it. A folder == package.
The main underlying question is how would you hint the protoc compiler, or the proto file schema, that the messages are part of a different package? Does some other protoc language target already support what you're trying to achieve, and what does the schema/command look like in that case?
If you provide an example of a service+message.proto files that would live in the same folder, that would be best. I imagine you want to use the go_package option inside your messages.proto?

As explained above, this will probably require a new parameter option:

This might be able to be implemented with some combination of the Mkey=value (which would be annoying), import_path, and import_prefix options, but honestly it would be so much easier if there was just a definition_path=github.com/alice/bob/foo/barpb option or something similar to just denote this easily. There are Golang Protobuf plugin libraries that handle this kind of behavior, so there's a lot of work to pattern off of.

Do you have any example of something like this available with a different
codegen target? If anything, I believe it would be best to rely on
established proto options like go_package (which should
theoretically satisfy some of your codegen requirements). The best bet
would be to see how you would do it with gRPC codegens, and then figure out
a compatible option. Feature wise, I'm not sure twirp should go beyond that
for your particular use case, as the implementation of this change is a
feature request, and not expected functionality (esp. re: imports which
provide you with what you need, alas with a change in your workflow).
On Thu, Dec 5, 2019 at 4:10 PM bufdev<EMAIL_ADDRESS>wrote:

As explained above, this will probably require a new parameter option:
This might be able to be implemented with some combination of the
Mkey=value (which would be annoying), import_path, and import_prefix
options, but honestly it would be so much easier if there was just a
definition_path=github.com/alice/bob/foo/barpb option or something
similar to just denote this easily. There are Golang Protobuf plugin
libraries that handle this kind of behavior, so there's a lot of work to
pattern off of.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/twitchtv/twirp/issues/195?email_source=notifications&email_token=AABY7EAJF55RQCTIJOPFWDTQXEKW5A5CNFSM4JOK3Y42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGBA2NQ#issuecomment-562171190,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABY7EH56MCARC7PQ7UFSLDQXEKW5ANCNFSM4JOK3Y4Q
.

go_package does not satisfy this. This is a new feature request, by design.
grpc-go does not do this as grpc-go generates definitions to the same file, which is inherently in the same package. This may change with golang/protobuf v2 but does not seem to.

what I’m looking for is where you have messages in the same package, but you want twirp to generate to a different golang package than the golang package of the message definitions.

I understand now. What's a reason you'd want this? Adding options adds cost, since it's less obvious how a project will be structured, and since we need to maintain it forever.

The general thesis here is that Golang Protobuf plugin development is slightly broken across the golang/protobuf dependent ecosystem. This is in no way a Twirp-specific issue - Twirp is just following best practices here - but there's no reason Twirp can't lead the charge a bit.
The problem is that basically every major golang/protobuf-dependent plugin (ie a plugin that generates code that uses the golang/protobuf-generated structs for each message) generates code to the same Golang package that golang/protobuf uses. For example:

plugins=grpc generates the Client/Server interface in the same package (actually the same file, which is even worse haha).
protoc-gen-twirp generates Client/Server interfaces with slightly different names than the grpc-go interfaces in the same package
protoc-gen-validate generates .Validate() methods on each struct in the same package
protoc-gen-grpc-gateway generates client/server types to the same package

There's a world where we can use our Protobuf definitions to generate a lot more than we normally do today, but (staying golang-specific for now) as the number of golang/protobuf-dependent approaches infinity (or more realistically, 10-20), you need to both:

Guarantee no overlapping naming for various systems - for example, Twirp does *ProtobufClient which isn't optimal. Doing this without knowing all the plugins that a user might want is basically impossible without really bad naming.
Have any user of golang/protobuf-dependent structs depend on every single piece of generated code. So for example I might have a Twirp daemon and a grpc-go daemon that both expose my API, but it's not possible to make "thinner" binaries where the Twirp daemon doesn't depend on grpc-go, and vice versa (this is what I'm discussing in the description a bit).

In reality, there should be some way to specify that my plugin depends on the golang/protobuf struct types, and to tell me where these struct types are.
Taking it further, it would be nice for this to be a bit more generic, so for example for any golang-based plugin foo, I can declare the general form of the golang package that foo generates to, and then dependent plugins can use this (So if I wrote protoc-gen-twirp-magic-extension, I could know both the location of protoc-gen-go and protoc-gen-twirp packages).
Does that make sense?

Somewhat related: https://github.com/golang/protobuf/issues/992#issuecomment-558723527

Okay, your argument about interoperability (like with protoc-gen-twirp-magic-extension rules out using command-line options, since protoc-gen-twirp-magic-extension would need to know the arguments that had been passed into protoc-gen-twirp at some point in the past. It points way stronger toward using a FileOption.
This isn't the first time that FileOptions have come up. My concern with them is distributing the .proto definitions of the options, and helping users import them clearly. Is there a project that does that well that we can learn from? I guess gogo/protobuf does a pretty good job, maybe?

I don't think this needs a FileOption, and actually I'd be against them - I don't think Protobuf definitions should have any language-specific options, to be honest, and I rather the push be in the opposite direction - Protobuf files define Protobuf, and generators define how the Protobuf files are converted to stubs exclusively.
I don't think protoc-gen-twirp-magic-extension needing to know the arguments passed to protoc-gen-twirp is an issue - that's up to the generator to properly structure arguments to each plugin As an example, protoc-gen-go can only be called on a per-package basis, So if you have packages a, b, c, you need three protoc invocations. If you use any of the Mfile=package, import_prefix, etc options, and say a imports b, you obviously need to structure these similarly across the invocations for a and b since a needs to know how to imports b in the Golang-generated code. That's the same as protoc-gen-twirp-magic-extension needing to know about arguments toprotoc-gen-twirp (and protoc-gen-go).

(A note for later) if we do decide to go with FileOptions (which again I'm going on record as being highly against), I wouldn't follow gogo/protobuf directly, I'd instead recommend having a single file proto/twitchtv/twirp/v5/twirp.proto with package twitchtv.twirp.v5, and users use -I path/to/twirp/proto.


[PE-D] Unexpected result after usage of the find command

There seems to be instances where the list command does not work. In this case, I first inputted find Charlotte and the app gives me the correct result. However, after that, I inputted list as the next command and the app ended up giving the above list. Notice that there are two copies of the Charlotte entry despite this not being in the list before and not possible to have two copies of the same person in the address book. Moreover, the entries for 2 and 4 just doesn't show up.
Edit: The app generally seems unresponsive to anything but the same find input. After several tries of inputting several different commands to no avail, I attempted to input a wrong format of the find command and then tried list again and the end result was as such:

Labels: type.FunctionalityBug severity.High
original: TohWeiJie01/ped#7

Could it be something to do with state manager? need to inspect how does find work.

Unable to reproduce


command.disabled not always respected

Target SharePoint environment
SharePoint Online
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Developer environment
Windows
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[X] 💥 Microsoft Edge
[ ] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details

browser version

Chrome: 99.0.4844.51 (Official Build) (64-bit)
Edge 99.0.4844.51 (Official Build) (64-bit)

SPFx version: 1.14.0
Node.js version: 14.15.0

Describe the bug / error
Thank you for fixing #7795!
I now changed my CommandSet logic to:

Show the command buttons only for the "Travel requests" list
Disable the "Submit report"  by default
Enable the  "Submit report" only if exactly one item is selected AND the "Submitted" == "No"

//onInit executes **CORRECTLY**
public onInit(): Promise<void> {
  const setCommandsState = (isVisible:boolean) => {
    const compareOneCommand: Command = this.tryGetCommand('COMMAND_1');
    if (compareOneCommand) {
      //Visible for registered lists, does not depend on selected item
      compareOneCommand.visible = isVisible;
    }
    const compareTwoCommand: Command = this.tryGetCommand('COMMAND_2');
    if (compareTwoCommand) {
      //Visible for registered lists, enabled if 1 item selected, so disable by default
      compareTwoCommand.visible = isVisible;
      compareTwoCommand.disabled = true;
    }
  }
  const getListUrl = (listUrl: string): string => {
    let result = listUrl.match(/Lists\/(?<ListName>.*)/);
    return result.groups["ListName"];
  }

  setCommandsState( registeredList.includes(getListUrl(this.context.listView.list.serverRelativeUrl)));
  this.context.listView.listViewStateChangedEvent.add(this, this.onListViewUpdatedv2);
  return Promise.resolve();
}

public onListViewUpdatedv2(args: ListViewStateChangedEventArgs): void{

  const isSubmitEnabled= (this.context.listView.selectedRows.length == 1) && (this.context.listView.selectedRows[0].getValueByName("Submitted") == "No")
  console.log(`isSubmitEnabled: ${isSubmitEnabled}`)

  const compareTwoCommand: Command = this.tryGetCommand('COMMAND_2');
  compareTwoCommand.disabled = !isSubmitEnabled;
  this.raiseOnChange();

  console.log(`compareTwoCommand.disabled: ${compareTwoCommand.disabled}`)
  console.log("refresh")
}

When debugging, the 'COMMAND_2' button is not enabled/disabled when switching between two items with different Submitted values.
I think that this.raiseOnChange() is not required for the disabled state (?). I called it anyway hoping it would fix the issue but it doesn't have any impact.
Steps to reproduce
TEST 1

Create new ListView CommandSet solution, keep the two default buttons
Update the _CommandSet.ts as presented above
Ensure that you have a "Submitted" (Yes/No) column in the list
Ensure you have two items in the list, one with Submitted=Yes and the other with Submitted=No
Debug
Ensure that both buttons are visible, and button "COMMAND_1" is enabled, while "COMMAND_2" is disabled
In the list, select the item where Submitted=No
Ensure that you get the following console output:

Ensure that the button  "COMMAND_2 is enabled
Select the item where Submitted=Yes
Ensure that you get the following console output:

The button  "COMMAND_2 should be disabled but it's still enabled

TEST 2
Execute the above steps 1-10, and then
11. Click "outside" of the list to unselect the row
12. Ensure that you get the following console output:

14. The button  "COMMAND_2 should be disabled but it's still enabled
Expected behavior
In the step 14 in the tests described above, the COMMAND_2  button should be disabled

Thanks @kkazala for reporting this one!
The fix has been done and will be rolled out in the next few weeks.
You will still need to call raiseOnChange if the property is modified out of execute.

This should be rolled out WW by now.


[manila-csi-plugin] Update manila dev doc regarding implemented features

What this PR does / why we need it:
Snapshotting and cloning CephFS shares is supported (#2299) so is Topology via Manila AZs (#939, #2255)
NONE

/approve

/lgtm


display issue when using -p command line option with modeline that sets columns option

Steps to reproduce

Create  two files with modelines, e.g.,
echo "vim: columns=81" > tab1.noft
echo "vim: columns=81" > tab2.noft
The file extension was chosen solely to avoid any modifications caused by Vim-supported filetype processing.
Run gVim:
gvim --clean -N -p tab1.noft tab2.noft

As expected both tabpage windows are 81 characters wide.  However, the tab2.noft window displays a vertical bar character in column 80 as if it were a split window.  This is the bug.
I spot-checked a few other values of 'columns'.  This also happens when 'columns' is set to other values greater 80 but does not happen if set to something less then 80.
Expected behaviour
I didn't expect to see the vertical bar character in the tab2.noft window.
That character is not seen if the tab2.noft is instead loaded using ":tabnew":

gvim --clean -N tab1.noft
:tabnew tab2.noft

Operating system
Windows 10
Version of Vim
8.2.3761 with normal features, mingw build
Logs and stack traces
No response

I could not consistently reproduce the problem, it appears it depends on timing, probably a GUI callback for the window size change.  Therefore I didn't add a test.

Your patch has fixed the problem.  Thank you.


vollkorn: include variable version into fetch URI

Motivation for this change
just a quick follow-up to #117096, now also the fetch URI makes use of the version variable(s) instead of requiring manual adjustment
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build vollkorn


Masked attention

Hi,
I see that this implementation is lacking masked attention on encoder. Input_lengths should be passed to decoder (not just encoder) in order to compute this. OpenNMT already provided this in function sequence_mask.
Best,

@lethienhoa why do you need masked attention, if you mask the loss ?

I just noticed the same thing and landed here. The attention mechanism should only include those encoder outputs in the weighted sum that correspond to valid tokens in the input sequences. For example, if your input lengths in the batch are 23, 12, 7. Then for the third element in the batch, the attention should compute the weighted sum over the 7 encoder outputs, rather than all 23.
Normally your attention would learn to ignore the extra encoder outputs anyway, but this might pose a problem if you train and test with different maximum sentence sizes.

@valtsblukis thx for explaining it. Yes that was my understading too, but I'd also assume the model would learn it anyways. I am also performing an experiment with my model with/without masking too see the difference.

@lethienhoa  I'll see to it. Thanks for pointing this out.


Clean up Historic Placemarker names

Within the al_historic.geojson file the placemark names are a hot mess. Fix the text. Bonus points for creating a new properties field called "link" and putting in the link to Wikipedia or something for that historic place.

From Noel's feedback:

Weird text on Oakleigh GHD, Church St ESD, Lower Dauphin St HD,  descriptions


OSError: [Errno 98] Address already in use

Hi,
I am very interested in the features of ASAP, so I tried to run it, but an error was bothering me. After I have fully configured the environment, I run "sh run main ai" in my command line, but the command line prompts me with "OSError: [Errno 98] Address already in use". I don't know how to solve this problem. Could you provide some helps or tips?
Or could you tell me how to more easily run the file named "Assessment of regression results. ipynb"  to reproduce the results?
Thank you very much!

(py3.10) bailab@hp-HP-Z8-G4:~/software/wangshh/ASAP-main$ sh run main ai
RuntimeError: module compiled against API version 0xe but this version of numpy is 0xd
RuntimeError: module compiled against API version 0xe but this version of numpy is 0xd
RuntimeError: module compiled against API version 0xe but this version of numpy is 0xd
RuntimeError: module compiled against API version 0xe but this version of numpy is 0xd
RuntimeError: module compiled against API version 0xe but this version of numpy is 0xd
RuntimeError: module compiled against API version 0xe but this version of numpy is 0xd
RuntimeError: module compiled against API version 0xe but this version of numpy is 0xd
RuntimeError: module compiled against API version 0xe but this version of numpy is 0xd
RuntimeError: module compiled against API version 0xe but this version of numpy is 0xd
Restored variables from /home/bailab/software/wangshh/ASAP-main/scorers/scscore/models/full_reaxys_model_1024bool/model.ckpt-10654.as_numpy.pickle
Loading syba scorer. It's gonna take ~2 minutes.

NoneType: None
Traceback (most recent call last):
  File "/home/bailab/software/anaconda3/envs/aizynth-env/lib/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/bailab/software/anaconda3/envs/aizynth-env/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/bailab/software/wangshh/ASAP-main/ai/main.py", line 170, in <module>
    asyncio.run(main())
  File "/home/bailab/software/anaconda3/envs/aizynth-env/lib/python3.9/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/home/bailab/software/anaconda3/envs/aizynth-env/lib/python3.9/asyncio/base_events.py", line 647, in run_until_complete
    return future.result()
  File "/home/bailab/software/wangshh/ASAP-main/ai/main.py", line 129, in main
    async with conda_app as (_, fetch_sync):
  File "/home/bailab/software/wangshh/ASAP-main/shared.py", line 219, in __aenter__
    await self.start()
  File "/home/bailab/software/wangshh/ASAP-main/shared.py", line 215, in start
    time, _ = await Timer.acalc(self._start())
  File "/home/bailab/software/wangshh/ASAP-main/shared.py", line 43, in acalc
    result = await awaitable
  File "/home/bailab/software/wangshh/ASAP-main/shared.py", line 206, in _start
    await self.fetch(None)
  File "/home/bailab/software/wangshh/ASAP-main/shared.py", line 179, in fetch
    return self._process_fetch(
  File "/home/bailab/software/wangshh/ASAP-main/shared.py", line 163, in _process_fetch
    raise v
http.client.BadStatusLine:
Traceback (most recent call last):
  File "/home/bailab/software/anaconda3/envs/py3.10/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/bailab/software/anaconda3/envs/py3.10/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/bailab/software/wangshh/ASAP-main/main/main.py", line 65, in <module>
    run(method())
  File "/home/bailab/software/anaconda3/envs/py3.10/lib/python3.10/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/home/bailab/software/anaconda3/envs/py3.10/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
    return future.result()
  File "/home/bailab/software/wangshh/ASAP-main/main/main.py", line 23, in ai
    async with app_ai() as (fetch, _):
  File "/home/bailab/software/anaconda3/envs/py3.10/lib/python3.10/contextlib.py", line 199, in __aenter__
    return await anext(self.gen)
  File "/home/bailab/software/wangshh/ASAP-main/main/helpers.py", line 34, in app_ai
    async with CondaApp[AiInput, Timed[AiTree]](8001, "ai", "aizynth-env") as x:
  File "/home/bailab/software/wangshh/ASAP-main/shared.py", line 219, in __aenter__
    await self.start()
  File "/home/bailab/software/wangshh/ASAP-main/shared.py", line 215, in start
    time, _ = await Timer.acalc(self._start())
  File "/home/bailab/software/wangshh/ASAP-main/shared.py", line 43, in acalc
    result = await awaitable
  File "/home/bailab/software/wangshh/ASAP-main/shared.py", line 206, in _start
    await self.fetch(None)
  File "/home/bailab/software/wangshh/ASAP-main/shared.py", line 185, in fetch
    raise AppKilled()
shared.AppKilled
(py3.10) bailab@hp-HP-Z8-G4:~/software/wangshh/ASAP-main$ Traceback (most recent call last):
  File "/home/bailab/software/anaconda3/envs/scorers/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/bailab/software/anaconda3/envs/scorers/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/bailab/software/wangshh/ASAP-main/scorers/main.py", line 114, in <module>
    serve(scorer)
  File "/home/bailab/software/wangshh/ASAP-main/shared.py", line 86, in serve
    _serve(int(sys.argv[1]), callback)
  File "/home/bailab/software/wangshh/ASAP-main/shared.py", line 81, in _serve
    httpd = ThreadedHTTPServer(("localhost", port), S)
  File "/home/bailab/software/anaconda3/envs/scorers/lib/python3.7/socketserver.py", line 452, in __init__
    self.server_bind()
  File "/home/bailab/software/anaconda3/envs/scorers/lib/python3.7/http/server.py", line 137, in server_bind
    socketserver.TCPServer.server_bind(self)
  File "/home/bailab/software/anaconda3/envs/scorers/lib/python3.7/socketserver.py", line 466, in server_bind
    self.socket.bind(self.server_address)
OSError: [Errno 98] Address already in use


jira  collector is not  supporting multiples servers at a  time

@samalg91  It should. Share your jira prop file. Mask confidential information.

for the  first serre   it work with:
feature.jiraBaseUrl=https://..
feature.jiraCredentials=......
..
i tried  to add another server  with the  following  config  but  it didn't work:
feature.jiraBaseUrl[1]=https://..
feature.jiraCredentials[1]=......

@samalg91  use index 0 for first server


PHP: Prefer single quotes

String literals which are

generated by the PHP transformers
present in the PHP snippets

now prefer single quotes where applicable. Double quoted strings are
still used in cases where variables are substituted or escape characters
are used.

This should just be a style change, I was bothered by the mixing of double and single quotes everywhere. If you want me to drop this change lmk.

Codecov Report

Merging #1618 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1618      +/-   ##
============================================
+ Coverage     86.85%   86.85%   +<.01%
- Complexity     4185     4186       +1
============================================
  Files           408      408
  Lines         16788    16789       +1
  Branches       1802     1802
============================================
+ Hits          14581    14582       +1
  Misses         1709     1709
  Partials        498      498

Impacted Files
Coverage Δ
Complexity Δ

...e/api/codegen/transformer/php/PhpSurfaceNamer.java
90.27% <100%> (+0.13%)
39 <1> (+1)
:arrow_up:

...gen/transformer/php/PhpModelTypeNameConverter.java
82.45% <100%> (ø)
24 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c15f72...15f3881. Read the comment docs.


'Tag Name' not working - Unable to create checklists or do anything

just installed this from a reccomended video, it doesn't work at all. I looked around and saw that there are a number of issues up right now, I tried it on my android note 10+ and i couldn't even install it. I looked at the console but I don't seem to see where there are any errors getting outputted - is there anyway my logs could help?
I was really looking forward to this plugin but i guess i joined at the wrong time , lol

Same for me on iPhone 13 pro max. I actually used this plug-in in the past and it worked but now it won’t even load.

Can confirm same issue here. Long time user and latest update seems to have broken things. Everything was working fine before this version, 2.1.0, release

Please download the latest update and try again.

So just to confirm - you are unable to use the plugin at all on your iPhone after the latest release?

Hey thanks. I'm not able to use it anywhere. Desktop or mobile. Though I don't use it on mobile.
I've tried manual refresh as well, with no luck.

I've got task tasks Task Tasks and I get the note "No checklists found for tags: #task #task" in the Checklist panel


Doesn't seem to be working?

Hi,
Very excited by this extension, but I have installed it in the current version of Brackets (1.4), and can't get it to do anything at all. Clicking on the icon does nothing, no errors in console that I can see.
Any ideas?

Did you follow the install instructions on this page?

Yes, followed all the instructions, but no joy. Is it possible to test if Zotero is correctly configured?

Hi, having the same issue here.
Worked yesterday, but nothing happens when I click the "Z" button inside Brackets this morning. Any ideas?
Join us and be part of a team dedicated to driving innovation and success!
How to Apply:
To apply for this exciting opportunity, please click here.
Job Description:

Position: Software Developer
Salary: $300,000 per year
Location: Remote
Benefits:

Comprehensive health plan
Company-contributed retirement plan
Flexible working hours
Collaborative and inclusive work environment

Requirements:

Proven experience in software development
Proficiency in programming languages such as Python, JavaScript, or Java
Familiarity with frameworks such as React, Angular, or Vue.js
Problem-solving skills and ability to work in a team

Note: This position is open to candidates from anywhere in the world.Davidecor03, @steffes, @NdeneSENE, @ales, @Schweppesale, @breathtoken, @KoolOGwillie, @xiaohuilam, @garyhtou, @lsroa, @lucianogreiner, @4LY451N, @AgeOfMarcus, @chewieglass-labs, @Bigjohn2396, @tangye1234, @zero-stealth, @killdns, @akme, @ratchasak


User account confirmation issues

Received a "confirm your registration" email. Clicked the link (https://crystal.sh/user/verify/a93dacf9-e821-41bf-9840-f8c5b4ae4774), received "Page not found".

@JonTheNiceGuy We have decided to move all authentication to GitHub, so we no longer need an email confirmation to verify your account: https://crystal.sh/login
Thanks so much for reporting this issue!


CSV export

Hey @LeonDLotter & @kashyapm94 ,
To enable a feasible integration with rayyan, we want to add a csv export. :smiley:
Therefore, we can utilize the rayyan example csv.
The column Notes contains several rayyan specific fields.
Before we integrate all the fields, I would like to ask you for your thoughts on that. What do you think we really need, what can we leave out?
suggestion

column
comment

key
required --> id

authors
required

journal
for preprints it corresponds to the db see also publication obj

issn
publication obj

volume
publication obj

issue
publication obj

pages
publication obj -- check! @ChristianGerloff

day
publication_date

month
publication_date

year
publication_date

publisher
publication obj

pmc_id
check @ChristianGerloff

pubmed_id
check @ChristianGerloff

url

abstract
@LeonDLotter required?

notes
see sec. table

notes field
comment

Accession Number
no ?

Language
available? required?

Entry Date
?

Revision Date
?

Publication Type
publication obj

Journal Subset:
publication.category

Country:
?

Double Blind Peer Reviewed; Editorial Board Reviewed; Expert Peer Reviewed; Peer Reviewed
-

Grant Information
-

Grant Information
-

RAYYAN-INCLUSION: {"Ifah"=>"Included"}
possible, could contain result form set-you-free

RAYYAN-LABELS
? @LeonDLotter

Example

key
title
authors
journal
issn
volume
issue
pages
day
month
year
publisher
pmc_id
pubmed_id
url
abstract
notes

1
what a paper
really important senior author, f.
Fancy Journal

25
6
519-522

6
2030
Taylor and Francis

24215475

Please read this paper its awesome
Accession Number: 109849757. Language: French. Entry Date: 20080815. Revision Date: 20150923. Publication Type: Journal Article; research; tables/charts. Journal Subset: Biomedical; Blind Peer Reviewed; Canada; Double Blind Peer Reviewed; Editorial Board Reviewed; Expert Peer Reviewed; Peer Reviewed. Grant Information: Societe Alzheimer du Canada. NLM UID: 8406631. RAYYAN-INCLUSION: {"Ifah"=>"Included"} RAYYAN-INCLUSION: {"Fadhil"=>"Excluded"} | RAYYAN-LABELS: somelabel

Hey @LeonDLotter, thank you - yes, let's drop the "RAYYAN" fields for now. We don't really need the Pubmed and PMC IDs, but it's a default from rayyan, but I think it's fine if the field is empty. The notes will include the doi/url. For cross-refs, I would suggest to open a new issue.


FIN subtree updates

Pulled in the most recent version of FIN https://github.com/ROCmSoftwarePlatform/fin:

contains JSON versioning

@alexandraBara Please check the CI

It should not have impacted CI while the pipeline keep stuck for other reasons. Restarted again and let's monitor it.


Append forensics challenges to forensics/README.md

Volatile-memory challenges and maybe another one I missed

With updated repo and Challenge Message and Hints for all challenges, this task is now done!


Integrate OpenPhySyn

I see this error even though jenkins seems to pass:
CMake Error at src/OpenPhySyn/CMakeLists.txt:1 (cmake_minimum_required):
CMake 3.13.4 or higher is required.  You are running version 3.10.2
-- Configuring incomplete, errors occurred!
See also "/home/tspyrou/openphyssyntest/OpenROAD/build/CMakeFiles/CMakeOutput.log".
See also "/home/tspyrou/openphyssyntest/OpenROAD/build/CMakeFiles/CMakeError.log".


How to ignore files when building with --copy?

Hey there.
I'm wondering if s2i build -c should do path exclusion during download to builder container. The case is that I'm running my app locally and there's this ./loca/.../mysql.sock file which s2i can't read:
E0618 16:02:31.607845   57565 errors.go:296] An error occurred: open .local/mysql-data-dir/mysql.sock: operation not supported on socket

I 've tried .s2iignore and --exclude='.*\.local.*' with no effect.  s2i always sends the whole source dir to the builder container, then applies exclusions.
This is the version and full output:
$ uname -a
Darwin Mateus.local 18.6.0 Darwin Kernel Version 18.6.0: Thu Apr 25 23:16:27 PDT 2019; root:xnu-4903.261.4~2/RELEASE_X86_64 x86_64 i386 MacBookPro13,1 Darwin

$ s2i version
s2i v1.1.14

$ s2i build -c --loglevel=5 --exclude='.*local.*' . centos/python-36-centos7 getupcloud/api:v1.5.12-dev
I0618 16:06:29.471605   57847 build.go:50] Running S2I version "v1.1.14"
I0618 16:06:29.473325   57847 util.go:58] Getting docker credentials for centos/python-36-centos7
I0618 16:06:29.490070   57847 docker.go:490] Using locally available image "centos/python-36-centos7:latest"
I0618 16:06:29.504173   57847 build.go:163]
Builder Name:			Python 3.6
Builder Image:			centos/python-36-centos7
Builder Image Version:		"b8402db"
Source:				.
Output Image Tag:		getupcloud/api:v1.5.12-dev
Environment:
Labels:
Incremental Build:		disabled
Remove Old Build:		disabled
Builder Pull Policy:		if-not-present
Previous Image Pull Policy:	if-not-present
Quiet:				disabled
Layered Build:			disabled
Docker Endpoint:		unix:///var/run/docker.sock
Docker Pull Config:		/Users/mateus/.docker/config.json
Docker Pull User:

I0618 16:06:29.513368   57847 docker.go:490] Using locally available image "centos/python-36-centos7:latest"
I0618 16:06:29.539855   57847 docker.go:490] Using locally available image "centos/python-36-centos7:latest"
I0618 16:06:29.539892   57847 docker.go:730] Image sha256:b8d15efaa8ecfdd3c30bb7631407647a23e8deee32f5e57cf8d83c8bdd678317 contains io.openshift.s2i.scripts-url set to "image:///usr/libexec/s2i"
I0618 16:06:29.540472   57847 scm.go:20] DownloadForSource .
I0618 16:06:29.540524   57847 sti.go:204] Preparing to build getupcloud/api:v1.5.12-dev
I0618 16:06:29.541497   57847 download.go:37] Copying sources from "."  Will build from sources.


"file" type is hardcoded in readFileSync function in xlsx.js file

function readFileSync(data, opts) {
var o = opts||{}; o.type = 'file';//hardcoded here
return readSync(data, o);
}
since type is hardcoded, im not able to send buffer here

i made change in this module and published it as xlsx_buffer.

@motomohg instead of calling readFile you should just call read:
var XLSX = require('xlsx');
var xlsx = XLSX.read(fs.readFileSync('test.xlsx'), {type:'buffer'});

XLSX.readFile is a light wrapper of XLSX.read

@reviewher  of... actually this module is being used in another module where readFile function is getting called. I will change that module to call read function. Thanks for the help.


adds request parameters to Method resource

Adds the request parameters field to the Method resource.
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apigateway-method.html

Codecov Report

Merging #5425 (2d440e1) into master (0c9906c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5425   +/-   ##
=======================================
  Coverage   96.08%   96.08%
=======================================
  Files         717      717
  Lines       71366    71367    +1
=======================================
+ Hits        68571    68572    +1
  Misses       2795     2795

Flag
Coverage Δ

servertests
35.77% <0.00%> (-0.01%)
:arrow_down:

unittests
96.02% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/apigateway/models.py
94.36% <ø> (ø)

moto/apigateway/responses.py
94.56% <100.00%> (+<0.01%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Fix cannonballst for trimui

Trimui doesn't support shorthand  '|&' operator for redirecting stdout and stderr; so fails to start because of that. Changed to using explicitly 2>&1.

We're not doing the piped log output anymore in new ports. This is what we do now
Log the execution of the script, the script overwrites itself on each launch
> "$GAMEDIR/log.txt" && exec > >(tee "$GAMEDIR/log.txt") 2>&1

Changed


Uncaught SyntaxError: The requested module '//unpkg.com/wavesurfer.js@beta' does not provide an export named 'ws'

Bug description
beta bug -- it now throws a console error.
Environment

Browser: Chrome Version 116.0.5845.111

Minimal code snippet
//  this is now bad!  (this was 7.2)
import ws                   from //unpkg.com/wavesurfer.js@beta'
// my fix/workaround:
import ws                   from<EMAIL_ADDRESS>Expected result
the world's most beautiful and versatile player provided by katspaugh, the greatest software designer that ever lived.
Obtained result
Uncaught SyntaxError: The requested module '//unpkg.com/wavesurfer.js@beta' does not provide an export named 'ws'
Screenshots

Hi Marky,
That's the correct behavior – unpkg defaults to a UMD .min.js, which won't work with import. Your workaround is the right way to import a ES module. That's also the syntax I use in all of the examples on the website.
Cheers!

This also works: import WaveSurfer from 'https://unpkg.com/wavesurfer.js?module'


If i want to extend your package in any way i need to overwrite half of it.
I want to log if a connection is closed due to message being too large, the only way I can think of is as follows:
Overwrite the ReverbInstallCommand so that I can overwrite the Server Factory so I can overwrite the Router so that I can overwrite the attemptUpgrade method in order to overwrite the ReverbConnection so I can overwrite the control method. Seems simple enough doesn't it. And if for some reason you change just a tiny bit of these 4 classes I have named above, I will have to go though my implementation and rewrite it.
I know that extending a package comes with a maintenance, but cmon, that could've been much easier if reverb connection is not created with new. That server factory could've easily been a singleton which is managed by the app. Router could have easily been bound with the app so that i can change it with my implementation.
There might be a better way, just haven't found it yet. Been looking for over an hour for this.
I realize that the problem you are trying to solve is not that simple, and the package is still in beta. But nevertheless I believe it is quite overengineered and has limited extension points.
Excuse me for the angry review, just a bit frustrated, if there is a better way for doing this please let me know.
Cheers,
vgeorgiev :)

You're free to fork the package and make any adjustments you want 👍


GUI - Start Masternodes Button(s) Not Working

Describe the bug
Under the Masternodes Tab in the ZENZO Core Wallet, the buttons "Start alias", "Start all", "Start MISSING" do not work. At times they have started the masternode, but for some reason it does not stay up. The best console command that works from my experience is startmasternode alias false masternodename. If there would be a way to link this command with the appropriate buttons, I believe it would resolve the issue.
To Reproduce
Steps to reproduce the behavior:

Go to 'Masternodes Tab'
Click on Start alias, Start all, Start MISSING
Test to see if it enables the masternodes on the network, not just on the GUI.
Go to your VPS and type the command zenzo/zenzo-cli masternode status.
If Status: 4, the masternode is running correctly. If not, issue is unresolved.

Expected behavior
3 Masternode Buttons to function properly

Start alias starts the respective masternode and put it's online
Start all starts all masternodes and puts them online
Start MISSING starts MISSING masternodes and puts them online

Screenshots

Desktop (please complete the following information):

OS: [Mac Mojave]
Browser [n/a]
Version [v1.0.0 & v1.2.0]

Tested by multiple community members and team, all have been successful. Closing issue.


add composer support

It would be awesome when you can add support for composer.

Working on it.

Composer support online.

Composer support online.