nvm installs node binary for armv7l instead of arm64

I was trying to find why Prisma wouldn't install on my Pi. The issue is that node -e 'console.log(process.arch)' returns arm. After some searching and running a nvm i --lts I realised it was downloading the armv7l version of node and therefore the node version was the culprit. However I can't figure out why nvm installs that instead of the 64 bit variant.
Operating system and version:
nvm debug output:

nvm --version: v0.39.3
$SHELL: /bin/bash
$SHLVL: 1
whoami: 'pi'
${HOME}: /home/pi
${NVM_DIR}: '${HOME}/.nvm'
${PATH}: ${HOME}/.local/bin:${NVM_DIR}/versions/node/v20.16.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/local/games:/usr/games
$PREFIX: ''
${NPM_CONFIG_PREFIX}: ''
$NVM_NODEJS_ORG_MIRROR: ''
$NVM_IOJS_ORG_MIRROR: ''
shell version: 'GNU bash, version 5.1.4(1)-release (arm-unknown-linux-gnueabihf)'
uname -a: 'Linux 6.1.21-v8+ #1642 SMP PREEMPT Mon Apr 3 17:24:16 BST 2023 aarch64 GNU/Linux'
checksum binary: 'sha256sum'
OS version: Raspbian GNU/Linux 11
random-funcs:       srandom/random
regex-funcs:        internal
compiled limits:
sprintf buffer      8192
maximum-integer<PHONE_NUMBER>
awk: /usr/bin/awk, mawk 1.3.4 20200120
curl: /usr/bin/curl, curl 7.74.0 (arm-unknown-linux-gnueabihf) libcurl/7.74.0 OpenSSL/1.1.1w zlib/1.2.11 brotli/1.0.9 libidn2/2.3.0 libpsl/0.21.0 (+libidn2/2.3.0) libssh2/1.9.0 nghttp2/1.43.0 librtmp/2.3
wget: /usr/bin/wget, GNU Wget 1.21 built on linux-gnueabihf.
git: /usr/bin/git, git version 2.30.2
grep: /usr/bin/grep (grep --color=auto), grep (GNU grep) 3.6
sed: /usr/bin/sed, sed (GNU sed) 4.7
cut: /usr/bin/cut, cut (GNU coreutils) 8.32
basename: /usr/bin/basename, basename (GNU coreutils) 8.32
rm: /usr/bin/rm, rm (GNU coreutils) 8.32
mkdir: /usr/bin/mkdir, mkdir (GNU coreutils) 8.32
xargs: /usr/bin/xargs, xargs (GNU findutils) 4.8.0
nvm current: v20.16.0
which node: ${NVM_DIR}/versions/node/v20.16.0/bin/node
which iojs:
which npm: ${NVM_DIR}/versions/node/v20.16.0/bin/npm
npm config get prefix: ${NVM_DIR}/versions/node/v20.16.0
npm root -g: ${NVM_DIR}/versions/node/v20.16.0/lib/node_modules

nvm ls output:

       v18.16.1
       v20.14.0
->     v20.16.0
         system
default -> 20 (-> v20.16.0)
iojs -> N/A (default)
unstable -> N/A (default)
node -> stable (-> v20.16.0) (default)
stable -> 20.16 (-> v20.16.0) (default)
lts/* -> lts/iron (-> v20.16.0)
lts/argon -> v4.9.1 (-> N/A)
lts/boron -> v6.17.1 (-> N/A)
lts/carbon -> v8.17.0 (-> N/A)
lts/dubnium -> v10.24.1 (-> N/A)
lts/erbium -> v12.22.12 (-> N/A)
lts/fermium -> v14.21.3 (-> N/A)
lts/gallium -> v16.20.2 (-> N/A)
lts/hydrogen -> v18.20.4 (-> N/A)
lts/iron -> v20.16.0

How did you install nvm?
I believe through the install script. I can't say for sure though.
What steps did you perform?
I ran nvm i --lts
What happened?
It installed the arm7l set of node binaries.
Console output:

Installing latest LTS version.
Downloading and installing node v20.16.0...
Downloading https://nodejs.org/dist/v20.16.0/node-v20.16.0-linux-armv7l.tar.xz...
############################################################################################################################################################ 100.0%
Computing checksum with sha256sum
Checksums matched!
manpath: can't set the locale; make sure $LC_* and $LANG are correct
Now using node v20.16.0 (npm v10.8.1)

What did you expect to happen?
I expected it to install the 64 bit variant of node since my installed OS is 64bit based. In this case https://nodejs.org/dist/v20.16.0/node-v20.16.0-linux-arm64.tar.xz
Is there anything in any of your profile files that modifies the PATH?
Nope

I hope I'm not overlooking something easy here. I searched through a lot of issues and other pages before opening this issue.

You're using nvm v0.39.3, which is very old - try v0.40.0?

I upgraded to nvm 0.40.0 and still have the same behaviour
output of nvm debug

nvm --version: v0.40.0
$SHELL: /bin/bash
$SHLVL: 1
whoami: 'pi'
${HOME}: /home/pi
${NVM_DIR}: '${HOME}/.nvm'
${PATH}: ${HOME}/.local/bin:${NVM_DIR}/versions/node/v20.16.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/local/games:/usr/games
$PREFIX: ''
${NPM_CONFIG_PREFIX}: ''
$NVM_NODEJS_ORG_MIRROR: ''
$NVM_IOJS_ORG_MIRROR: ''
shell version: 'GNU bash, version 5.1.4(1)-release (arm-unknown-linux-gnueabihf)'
uname -a: 'Linux 6.1.21-v8+ #1642 SMP PREEMPT Mon Apr 3 17:24:16 BST 2023 aarch64 GNU/Linux'
checksum binary: 'sha256sum'
OS version: Raspbian GNU/Linux 11
random-funcs:       srandom/random
regex-funcs:        internal
compiled limits:
sprintf buffer      8192
maximum-integer<PHONE_NUMBER>
awk: /usr/bin/awk, mawk 1.3.4 20200120
curl: /usr/bin/curl, curl 7.74.0 (arm-unknown-linux-gnueabihf) libcurl/7.74.0 OpenSSL/1.1.1w zlib/1.2.11 brotli/1.0.9 libidn2/2.3.0 libpsl/0.21.0 (+libidn2/2.3.0) libssh2/1.9.0 nghttp2/1.43.0 librtmp/2.3
wget: /usr/bin/wget, GNU Wget 1.21 built on linux-gnueabihf.
git: /usr/bin/git, git version 2.30.2
grep: /usr/bin/grep (grep --color=auto), grep (GNU grep) 3.6
sed: /usr/bin/sed, sed (GNU sed) 4.7
cut: /usr/bin/cut, cut (GNU coreutils) 8.32
basename: /usr/bin/basename, basename (GNU coreutils) 8.32
rm: /usr/bin/rm, rm (GNU coreutils) 8.32
mkdir: /usr/bin/mkdir, mkdir (GNU coreutils) 8.32
xargs: /usr/bin/xargs, xargs (GNU findutils) 4.8.0
nvm current: v20.16.0
which node: ${NVM_DIR}/versions/node/v20.16.0/bin/node
which iojs:
which npm: ${NVM_DIR}/versions/node/v20.16.0/bin/npm
npm config get prefix: ${NVM_DIR}/versions/node/v20.16.0
npm root -g: ${NVM_DIR}/versions/node/v20.16.0/lib/node_modules

Output of nvm i --lts is that the latest version is already installed

Installing latest LTS version.
v20.16.0 is already installed.
manpath: can't set the locale; make sure $LC_* and $LANG are correct
Now using node v20.16.0 (npm v10.8.1)

What do nvm_get_os and nvm_get_arch output?

The first gives linux the second gives armv7l however I don't understand why. As you might have seen in the output of nvm debug that I'm running a 64 bit Raspberry OS image

No worries about the bearing - I'm happy to get help!
uname -m gives aarch64
uname gives Linux
command od -An -t x1 -j 4 -N 1 "/sbin/init" 2>/dev/null gives 01

On that last one - 01, or  01? (note the space)

It's actually with a space so the latter  01

ok so the code block that's forcing it to armv7l is:
https://github.com/nvm-sh/nvm/blob/d5e2c92a254cc10e95cd960a47515bec2d5c5e81/nvm.sh#L2066C5-L2067
that suggests, based on the comment, that you're emulating 64bit? specifically that was added to fix an issue on OpenBSD in #2698.

So after some research I found out that Raspbian and Raspberry Pi OS are not the same. Additionally it seems like my image is from a version prior to the official 64bit release of Raspberry Pi OS and is running a 32bit Raspbian image with 64bit kernel. So that's the solution why there's mixed feedback from the system what it is.
I also confirmed this with some output from the pi itself:
getconf LONG_BIT returns 32 and running cat /etc/os-release tells me it is a Raspbian system, not a Raspberry Pi OS. I'll have to confirm whether the latter option is actually giving a definitive answer.
To sum it up: definitely not nvm's fault! Thank you so much for your help. I'm off to reimage my pi and try not to crash my network in the progress... :D


Reduce scroll amount to quickly collapse extra header

Hello,
first of all, @benevbright congratulations for the great work done so far!
My issue is not about problem or bug, but it is a possible enhancement.
I want to reduce the scroll amount and then reduce the time I wait for collapse extra header.
I tried to find a way to achieve this looking at the file index.js and I found this at line 35:
const safeBounceHeight = Platform.select({ios: 300, android: 100, web: 200});
For example, if I set safeBounceHeight = 0 I get the desired result, also because in my AnimatedFlatList I put bounces={false}.
Suggestion
It could be an idea to have a param to set up in collapsibleParams for a custom safeBounceHeight value or any other param that help to reduce scroll amount and quickly collapse custom extra header.

Hi @benevbright,
Great, I've seen you push my request in master.
But I still have a couple of things to ask you.
First, how can I use/set custom safeBounceHeight?
However, I have not yet solved my problem.
In my case, I use three tabs with AnimatedFlatList; two of these have so much content to scroll, but not the third.
I think it would be good to have an option in which to say that if the scroll exceeds a certain threshold, then automatic complete header collapse.
Do you think it's possible?
You can reproduce my situation setting data loop cycle to 15 in yours example.

You can use it like this
import { setSafeBounceHeight } from 'react-navigation-collapsible';
setSafeBounceHeight(0);

I got that you have multiple Flatlist that has different length of content.
But why it's problem? I don't get that.
And it will be tricky though that we make it have each threshold.

Sorry, I probably did not explain it well.
With short FlatList happens that the extra header does not completely collapse when scroll down.
In my case, extra header has height: 175
I can try to reproduce this in a Snack if necessary.

Oh, sure, but I think it isn't best solution.
It's annoying to have padding because it forces users to continue to scroll down.
In my opinion, if the header automatically collapses after a certain amount of scroll avoid users to force scroll down even if FlatList scroll height is minor that device height and I think scrollbar would disappear, while with the padding it would remain.

Probably, I can achieve this provinding custom method into onScroll property in FlatList and manipulatig animatedY, but I don't know how.

Hi @benevbright ,
about extra header auto-collapsing, I looked for a similar scenario in other apps that could explain what I want to achieve and I found an interesting example in "Shpock" app (see the GIF below):

Sorry for the bad quality of the GIF.
In this example, there is also an animation to the header title, but this doesn't interest me.
Pay particular attention to the extra header and how it is animated when the touch is released.
Do you think it could be possible to do that?

Hi, @paolospag
Sorry that I haven't been able to look at this issue nowadays.
And the thing you mentioned is the same as this one. #16
I want to that too but I have not found a good solution yet.

Hi @benevbright ,
I think I have some news about that, try to take a look at #16

@paolospag could you please give an example of how could i use collapse header with tabs ?


[Custom app][Code app]:  button "Add the agent to My workspace ti continue" displayed instead of message textbox for versions of app, added to My workspace

EPAM AI DIAL chat version
0.22.0
How to reproduce
Preconditions:
there is published custom app with versions 0.0.1 and 0.0.2
Steps:

Open DIAL Marketplace
find published application
click on its card
when version 0.0.2 is selected , click on book mark icon -> confirmation toast is displayed, version 0.0.2 was added to My workspace
select version 0.0.1 and click on book mark icon -> confirmation toast is displayed, version 0.0.1 was added to My workspace
click Use application button -> new conversation screen with selected custom app version 0.0.1 is displayed, version dropdown is available
on New conversation select version 0.0.2 -> message text box is not availalble, "add the agent to My workspace" button is displayed -> bug

Actual result
button "Add the agent to My workspace ti continue" displayed instead of message textbox for versions of app, added to My workspace
NOTE: Reproducible for deployed published versions of code app
NOTE: Not reproducible for models
https://github.com/user-attachments/assets/2144fca3-8a3e-4d1d-b12c-34d077c7af39
Expected result
If version of custom (code) app was added to my workspace, then it should be available to use on New conversation screen
Confidential information

[X] I confirm that do not share any confidential information

Not reproducible on Staging


add python 3.6 to the support list

I develop against python 3.6.
My dependency checker let me know that arrow 0.11 is out, but pip doesn't want to let me use it because of restrictions to python 3.5.  Version 0.10.0 worked just fine for me under Python 3.6 and had no restrictions.
Please add python 3.6 to the list of supported python versions.

Bump. Can you add the trove classified for Python 3.6?

We have a PR up to do just that: https://github.com/crsmithdev/arrow/pull/472.

Thank you!

Python 3.6 is now supported!


March release notes include incorrect link

There appears to be a minor issue with the release notes.
Version 1.55.2 and 1.55.1 include an "Updates" link that links to 2019 releases.

/confirm

/assign @TylerLeonhardt

The links in the release notes for version 1.55.0 also do not work.

Fixed! Thanks everyone!


Add an optional section for GitHub Copilot Chat

This pull request introduces a new optional section to the 5-coding.md file in the content/guided-workshop/exercises directory. It provides a guide on how to use GitHub Copilot Chat (instructions on accessing and interacting with Copilot Chat, using slash commands, and applying suggested changes).
Key changes:

content/guided-workshop/exercises/5-coding.md: Added a new section titled 'Bonus – Using GitHub Copilot Chat', which provides a comprehensive guide on how to use GitHub Copilot Chat for code documentation, issue fixing, and understanding. It also includes examples of using slash commands like /doc and /fix, and how to apply the suggested changes to the Hours.js file.

Chatted separately with @geektrainer, who gave the 👍 on getting this one merged in. Merging as a result, thanks!


glassfish/domains/domain1/docroot is not persistent (dataverse logos)

The dataverse logos files are stored in glassfish/domains/domain1/docroot/logos, but is not persistent.
If, for some reason, the dataverse pod is re-created, the logos are gone:
bash-4.2$ ls -la /opt/dataverse/appserver/glassfish/domains/domain1/docroot
total 24
drwxr-xr-x 1 glassfish glassfish 4096 Jun 11 07:28 .
drwxr-xr-x 1 glassfish glassfish 4096 Jun  6 13:20 ..
-rw-r--r-- 1 glassfish glassfish 4626 Aug 21  2014 index.html
drwxr-xr-x 4 glassfish glassfish 4096 Jun 11 07:28 logos

After re-creation of the dataverse pod:
bash-4.2$ ls -la /opt/dataverse/appserver/glassfish/domains/domain1/docroot
total 20
drwxr-xr-x 2 glassfish glassfish 4096 Aug 21  2014 .
drwxr-xr-x 1 glassfish glassfish 4096 Jun 11 09:12 ..
-rw-r--r-- 1 glassfish glassfish 4626 Aug 21  2014 index.html

Hey Wilko,
thanks for opening this issue and providing feedback. :smile:
Currently I added no support for branding.
From my view on this, customization/branding is a part of configuration. I would really like to avoid more persistance by default, but use a more K8s approach.
IMHO it would make much sense to add an init container for this. That container could check out a git repo or similar with your brandings. Dataverse could be configured to use those files, see docs link above.
What do you think?

@wilkos-dans hi! @poikilotherm and I started talking about this at http://irclog.iq.harvard.edu/dataverse/2019-06-11 and one thing I wanted to point out is a line I added to http://guides.dataverse.org/en/4.14/installation/advanced.html#multiple-glassfish-servers as a "gotcha" when installing multiple Glassfish servers:
"When users upload a logo for their dataverse using the “theme” feature described in the Dataverse Management section of the User Guide, these logos are stored only on the Glassfish server the user happend to be on when uploading the logo. By default these logos are written to the directory /usr/local/glassfish4/glassfish/domains/domain1/docroot/logos."
This issue hit me and some Red Hat interns a year or two ago when they were spinning up Dataverse on OpenShift.
I think we should fix this over on the Dataverse side somehow but I don't believe there's an issue (either one of you should feel free to open one) and I'm not sure what the fix would be. Put the logo in the database instead, base64 encoded? I'm definitely open to ideas. 😄

Hi @poikilotherm  & @pdurbin  Thanks for the feedback!
I understand the difficulties when "installing multiple Glassfish servers".
But this issue is about a step earlier, even on a 1 node cluster (=single Glassfish server).
It is about storing files inside a running Docker container, that will disappear when K8S manager decides to spin up a new Docker container, for whatever reason.
IMHO, I think the dataverse logos files ( logfiles?) should be persisted somewhere outside the running Docker container, just like the dataset files, which do persist between pods.

Hi @poikilotherm and @pdurbin, this issue is very important for us as Wilko already said. We have a customized version of Dataverse with subdataverses for different countries inside of our community and it's critical for them not to loose any logos or other adjustments after Docker containers will restart.
I did fixed this issue in @dataverse-docker repository with 2 extra Glassfish commands
/opt/glassfish4/glassfish/bin/asadmin delete-jvm-options '-Ddataverse.files.directory=/opt/glassfish4/glassfish/domains/domain1/files'
/opt/glassfish4/bin/asadmin create-jvm-options '-Ddataverse.files.directory=/opt/glassfish4/glassfish/domains/domain1/docroot/files'
Persistent volume should be created on docroot folder to keep both files and logos
VOLUME /opt/glassfish4/glassfish/domains/domain1/docroot
The same goes for log files, what do you think?

I just dug through some old issues and conf/openshift but didn't find anything more than what I've written in this issue already.
@4tikhonov I'm not very familiar with VOLUME but I think your solution makes sense.
@wilkos-dans are you starting to call logo files "logfiles"? I find this a little confusing. 😄 And now @4tikhonov is talking about log files too?
If we want to talk about log files too, there's also the following note about Make Data Count files at http://guides.dataverse.org/en/4.14/installation/advanced.html#multiple-glassfish-servers
"If Make Data Count is used, its raw logs must be copied from each Glassfish server to single instance of Counter Processor. See also the :MDCLogPath database setting in the Configuration section of this guide and the Make Data Count section of the Admin Guide."
And there's a note for the files we added for https://github.com/IQSS/dataverse/issues/5145
"Dataset draft version logging occurs separately on each Glassfish server. See “Edit Draft Versions Logging” in the Monitoring section of the Admin Guide for details."
Finally, there's a note about sitemap.xml:
"When a sitemp is created by a Glassfish server it is written to the filesystem of just that Glassfish server. By default the sitemap is written to the directory /usr/local/glassfish4/glassfish/domains/domain1/docroot/sitemap."
I'm not sure how much of this is in scope for this issue, which is originally about logos.
I hope this comment adds clarity rather than confusion! 😄
I have confidence that @poikilotherm will figure something out, especially since @4tikhonov seems to have already suggested a good fix for the logos issue. 😄

Hey @wilkos-dans @4tikhonov and @pdurbin,
let's keep this issue dealing with logo persistance. Log files on K8s are a different topic, which should be discussed on its own, when you see a need. Feel free to open an issue for this, too.
About @4tikhonov suggestion to point dataverse.files.directory to the docroot of the domain: IMHO this is a bad idea. IIRC docroot is accessible to anyone accessing the server, so you might expose confident research data files that should not be exposed.
But as this is a free country: feel free to change the deployment object to mount the PVC to the docroot. Easily done with Kustomization.
I still vote for changing the place where logos, sitemap etc are persisted. Any volunteers for opening an issue upstream?

I still vote for changing the place where logos, sitemap etc are persisted. Any volunteers for opening an issue upstream?

This should be two separate upstream issues, please. One for sitemap.xml, one for dataverse logos. Thanks.

IIRC docroot is accessible to anyone accessing the server, so you might expose confident research data files that should not be exposed.

I don't know if this is true or not but I can't find any information either way. I feel like I had to mess with a fair amount of stuff in these files...

src/main/webapp/WEB-INF/glassfish-web.xml
src/main/webapp/WEB-INF/pretty-config.xml

... to get sitemap.xml to show up at https://dataverse.example.com/sitemap.xml
Here's a screenshot from https://github.com/IQSS/dataverse/pull/5084

Yesterday in IRC, @poikilotherm said, "I am fiddling with moving it to /docroot in the container, so it will not be a blowup once changing to a different appserver using a different domain" http://irclog.iq.harvard.edu/dataverse/2019-10-16#i_108745
I'm fine with whatever works. 😄

Heh - added my commits when you wrote that comment :smile:
PR coming...

Any volunteers for opening an issue upstream?

@DS-INRA just opened https://github.com/IQSS/dataverse/issues/6491
Should we move the conversation there?


foaas.com Down ?

what happened to the website?

I forked it and got it up. https://web-production-d32f.up.railway.app/

i know that's possible, i was referring to the domain, its as if they stopped maintaining this project

i know that's possible, i was referring to the domain, its as if they stopped maintaining this project

Ah, I see! My mistake

@alexraskin https://foaas.dev is down

@alexraskin https://foaas.dev is down

ah, let me see what I broke.

I control the domain, not the heroku account, Tom and I have both long left the job we worked at together ha.
I will point the domain at an updated instance if someone has one running...or I will get it back running on Sunday (currently Thursday)

I control the domain, not the heroku account, Tom and I have both long left the job we worked at together ha.
I will point the domain at an updated instance if someone has one running...or I will get it back running on Sunday (currently Thursday)

Was the domain sold? https://www.foaas.com/


[python] Allow use of other JSON encoder/decoders

Thanks for oso!
It would be lovely if there was a simple way for polar to make use of other, more performant JSON encoder/decoder libraries.
For example,  by monkeypatching the rust-based orjson into polar.(cffi|query|errors), I've observed calls to json.loads pretty much disappearing into noise when profiled with pyinstrument, whereas previously it was rather pronounced.

Hey @bollwyvl!
Thanks for the suggestion. That sounds like a huge win. If it can be accomplished by monkeypatching, is it just a drop in replacement we could use? Do you know if it supports the same platforms/versions that we support?
Either way, sounds like having a feature like oso[orjson] as an opt-in feature could be helpful. We definitely rely pretty heavily right now on JSON encoding/decoding.

Welp, as oso is already rust-dependent, so I don't see how it could be much of a limitation.  orjson use is already fairly widespread, with some plugin support in e.g. FastAPI, django. As to what specific wheels are available? No idea, as I primarily work with (and re-package oso for) conda-forge, where we have aarch64 and ppcle as the most "exotic" things. Could probably support Apple Silicon, but nobody has asked (and still building under rosetta).
But again, "picking a horse" might not be as effective as "leaving an open stable," and letting downstreams do their own shim around it, with proper docs and types of what it might ask for in e.g. polar.set_json_encoder or something.
This would leave the way for exploring options, dependent on the workload, e.g. pysimdjson, or whatever comes out next month. To my knowledge, there isn't a performant, async-compatible JSON encoder/decoder... but then oso doesn't do that much either.

orjson supports CPython 3.7, 3.8, 3.9, 3.10, and 3.11. It distributes x86_64/amd64, aarch64/armv8, and arm7 wheels for Linux, amd64 and aarch64 wheels for macOS, and amd64 wheels for Windows. orjson does not support PyPy. Releases follow semantic versioning and serializing a new object type without an opt-in flag is considered a breaking change.

Per https://pypi.org/project/orjson/
I personally agree that a more generic setter pattern (though I'd probably use a @property rather than a set_.... method which is more common in languages like Java) would probably be better. If this is of interest, I may be able to look at adding this if we can agree to functionally how this should be added.
Thanks 🙂

Well, if there's always "The One True" oso at any given time, it could just be in the constructor:
oso = Oso(
    json_loads: Callable[[Any], str] = json.loads,
    json_dumps: Callable[[str], Any] = json.dumps
)

And it's up to the implementer to overload the default by subclass or instantiation


Add an OTLP (gRPC) logger to Envoy

Adding the OTLP logger will allow integration with more 3rd party monitoring frameworks, especially when using OT collector to convert them to whichever format needed.
Although OpenTelemetry logging isn't going to be part of the GA and the C++ SDK isn't ready yet, we don't actually need them in order to export OTLP logs - as long as the OTLP logs proto is stable.
The logs format is actually already available in the Amazon managed OT collector as an exporter, and Microsoft are also working on something similar, so it shouldn't change much - either way we'll get the OT community guarantee for backwards compatibility.
The general idea is to take the existing gRPC logger and just output a different format.
FYI @htuch @yanavlasov

Seems like we need to also implement the client-side of collector service: https://github.com/open-telemetry/opentelemetry-proto/tree/master/opentelemetry/proto/collector/logs/v1 (gRPC and HTTP).

What is meant by "take the existing gRPC logger and just output a different format"? I think OTLP has a totally different gRPC service definition/endpoint as well as data model. I'd suggest making this a dedicated access logger built for OTLP that may borrow concepts (and potentially refactor) with gRPC access logger.

Some clarifications:

Seems like we need to also implement the client-side of collector service: https://github.com/open-telemetry/opentelemetry-proto/tree/master/opentelemetry/proto/collector/logs/v1 (gRPC and HTTP).

Yes, that's exactly what we need to do.

What is meant by "take the existing gRPC logger and just output a different format"? I think OTLP has a totally different gRPC service definition/endpoint as well as data model. I'd suggest making this a dedicated access logger built for OTLP that may borrow concepts (and potentially refactor) with gRPC access logger.

Yes, the idea is to create a dedicated access logger built for OTLP (i.e implements the client side of the collector service).
I was referring to the implementation details, which I understand how it can be unclear.
As for the implementation, we can re-use functionalities from existing loggers:

gRPC - the existing gRPC HTTP/TCP logger already takes care of streaming, batching etc. Basically I want to use all of this functionality, just with the OT service/protos. I'll start with the gRPC OT service, and if needed we can also implement the HTTP one.
Formatting - the existing File logger has a format config a string/JSON with placeholders to be filled with request/response data. As the OTLP logs are free form, we need the user to configure the output format. I think it's fairly straightforward to extend the string/JSON formatters to support protos as well. That is, the format configuration will be an OTLP log proto with placeholders.

These 2 orthogonal changes can be used to create the gRPC OTLP formattable logger.
The OTLP logger config would look something like this:
{
"common_config": "{...}"  // CommonGrpcAccessLogConfig
"otlp_format": "{...}"  // OTLP log proto with placeholders, similar to the File logger format config
}

@yanavlasov @htuch Can we tag it with one of the above so it's not closed?

@envoyproxy/security-team @envoyproxy/dependency-shepherds
As part of this issue, I want to add dependencies on some OT protos from 2 repositories:

OpenTelemetry collector RPC service
OT protos (logs and the common proto)

I'm following the dependency policy doc to get the required approvals.
Also, I'm not sure what goes into the api/.. dependencies and what goes to the regular one.

I think it's fine depending on a pure proto repository. The dependency policy largely applies to code that is linked into the data or observability planes, but API proto repos don't need to do things like have a security policy.
This belongs in api/bazel, since the API protos will be depending on it.


Can we add a modification counting function

Can we add a modification counting function
For example, single black and white counting, color counting, total counting

I’m doubtful they’re available. Have you found any reference to these counters somewhere? And which printer model are you referring to?

L series, WF series


add ppblz strategy

Fixes # .
Changes proposed in this pull request:

added possibility for staking and lp'ers to vote
fork of aavagotchi

Can you add your strategy to here:
https://github.com/pepem00n/snapshot.js/blob/master/src/strategies/index.ts
and then run: npm run test --strategy=pepemon

@samuveth thanks for the quick turnaround.
i'm receiving some errors as well. i'll let our devs figure this one out, you can close this PR and we'll open a new one.
cheers.


iPhone 6+: Menu button not disabled during stone placement gesture

Launch the app on an iPhone 6+
Display the board
Start placing a stone, but don't complete the gesture
While the gesture is in progress, tap the menu button

Expected: The menu button is disabled, tapping it has no effect
Actual: The menu button is enabled, tapping it calls up the main menu (and cancels the stone placement gesture)

Portrait: The menu button is created by NavigationBarButtonModel.
Landscape: The menu button is created by RightPaneViewController.


ENH: Overlap-add filtering for long signals

Added zero-phase overlap-add filtering for signals longer than 60s (direct FFT filtering is faster for shorter signals). Unified filter function for low/high/band - pass.

would it make sense to pass a filter length to the *_filter functions to let users specify the frequency resolution they want (like mne_process_raw does)
something like:
band_pass_filter(x, Fs, Fp1, Fp2, filter_length=XXX)

where XXX is None means use full signal FFT or XXX=4096 means use overlap add with buffers of size 4096. It seems like exposing the N_fft parameter (that btw should be nfft or n_fft)

Improved code based on your comments. The test now compares direct filtering and overlap-add filtering. Note that due to the different types of convolution (circular and linear with mirrored boundary), the edges of the filtered signal are slightly different. I don't think it is possible to avoid this.


Feature request: add host aliases get/create/update

Please add host aliases.
Thanks.

Sure. We will be adding it along with our upcoming feature.

Hi @hrez  the enhancement has been done and changes are in develop branch https://github.com/infobloxopen/infoblox-go-client/tree/develop . Please do use the same and provide the feedback.

Now the feature is available at master branch. Will be available as part of v2.0.0.


Bump resolvers

cabal to 2020-05-02T10:11:15Z
stack-8.8.3 to lts-15.10
stack to nightly-2020-05-01

@jneira please give an opinion as to what test failures can be ignored.

jumm i think we have to take care of this one:
src/Haskell/Ide/Engine/Plugin/Ormolu.hs:73:46: error:
    • Couldn't match type ‘Bool’ with ‘RegionIndices’
      Expected type: Config RegionIndices
        Actual type: Config Bool
    • In the first argument of ‘ormolu’, namely ‘(conf o)’
      In the expression: ormolu (conf o) fp
      In the second argument of ‘try’, namely
        ‘(ormolu (conf o) fp $ T.unpack cont)’
   |
73 |       liftIO $ try @OrmoluException (ormolu (conf o) fp $ T.unpack cont)
   |                                              ^^^^^^
cabal: Failed to build haskell-ide-engine-1.3 (which is required by
exe:hie-wrapper from haskell-ide-engine-1.3, lib:hie-test-utils from
haskell-ide-engine-1.3 and others).

It is thrown for cabal jobs with ghc-8.8.3 and ghc-8.8.2

Weird that it builds fine with 8.8.3 and ormolu-<IP_ADDRESS>for stack. Investigating, can repeat it with my machine.

We have to limit the acceptable ormolu version
New release <IP_ADDRESS> is incompatible with HIE.

Green on circleCI. Ok to merge?


use https for the jQuery path

Like #23, but using https instead of http. I have three reasons to do this:

https://code.jquery.com/jquery-1.11.1.min.js works fine with https
//example.com/script.js is a little bit slower than https://example.com/script.js  (I did read a blog post about that, but cannot find it right now.) But it's obvious, the browser should resolve them using the current protocol.
//example.com/script.js will give a nasty error when $.visiting local HTML files.

@travist I found this nice library after watching your talk about it. Niiiice stuff! :clap: :tada:

@travist Do you still maintain this repo?

Yes I do... this looks fine to me.  Thanks.

@travist :+1:


Enable Link-Time Optimization (LTO)

Hi!
I noticed that in the Cargo.toml file Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance a bit.
I suggest enabling LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional dist or release-lto profile where additionally to regular release optimizations LTO will also be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most performant version of the application. Using ThinLTO should also help to reduce the build-time overhead with LTO. If we enable it on the Cargo profile level, users, who install the application with cargo install, will get the LTO-optimized version "automatically". E.g., check cargo-outdated Release profile.
Basically, it can be enabled with the following lines:
[profile.release]
lto = true

Tauri official docs also recommends using LTO.
Thank you.
P.S. I think the same recommendations are applicable to your other project - https://github.com/thewh1teagle/mobslide

Hey!
Thanks for letting know about it. I thought that Rust enable it by default, turns out that it doesn't :)
I enabled LTO and tauri's recommend profile options in latest release.


Clean up CMakeLists.txt and point to WIP HPX backend work

So I didn't actually get to trying out the updated backend properly. The source files are more or less unchanged (except for changing future to shared_future; this is required by the new changes).
This cleans up the CMakeLists.txt to use HPX's and Kokkos' new fancy CMake targets. The submodules should reflect that. However, I've never actually used submodules before so I may have messed things up.
The dependency handling moved to a few bash scripts in the scripts directory. There's a README.md which explains how to use them. I suggest you both try this out before we merge this to master. I tried them once only. Works only on Piz Daint.
Just to give you an idea of what you can now play around with: The HPX backend gained a few new constructors (requires Kokkos_ENABLE_HPX_ASYNC_DISPATCH=ON; the build scripts do that). The default constructor uses is a "global" instance, i.e. all work submitted on default constructed instances are serialized. This is also not thread-safe. There are two new constructors: 1) HPX(HPX::instance_mode) (instance_mode can be independent or global, you want the first) creates an instance with a separate future and internal buffer that is completely independent from the global one, and 2) HPX(shared_future<void>) which initializes the internal future to the one passed in. HPX::impl_get_future returns the internal future. In principle this lets you do arbitrarily complex graphs even with the Kokkos parallel functions when combined with things like when_all.
Note: I forgot to update kokkos-hpx-interop to actually use the independent HPX instances! To be continued on Monday...

Status update: this now has a couple of more fixes in the kokkos-hpx-interop repo, and I think this is ready to go in on its own.
Turning off internal fences kind of works, but the CudaHostPinnedSpace deep_copys don't actually use the stream, which means we have no way synchronize them, except by waiting for the full device. I'm adding overloads to take care of that.
Other than that I've been debugging the HPX backend. I finally found the problem: the internal futures are duplicated in the copy constructor, which means that an execution space and a range policy with an execution space have different "streams". I'm working on fixing this as well.

Success! I think. I did most of the testing on allocator_kokkos_executor_stream_test. It's been updated now and doesn't do any really bad fencing, just the one explicit wait which is somewhat unavoidable right now.
Kokkos is quite picky when it comes to doing asynchronous memory copies on given streams. I had to add some specializations to do it between CudaHostPinnedSpace and the other spaces. If the layouts aren't compatible (as they are by default) between a host and device view Kokkos will fall back to its own memory copy which uses again a default execution space instance. I haven't fixed this in Kokkos, but the test now uses compatible layouts. Kokkos_ENABLE_INTERNAL_FENCES is now off by default in the build script. If more fences need to be removed just let me know.
I think both the HPX backend and the deep copies are now in a state where you can do almost everything asynchronously given that you're a bit careful.


EC2 SecurityGroup fails when ingressRules or egressRules are defined

Describe the bug

The below error is experienced in case ingressRules and egressRules fields are included in the resource definition.

K8S resource definition:
apiVersion: ec2.services.k8s.aws/v1alpha1
kind: SecurityGroup
metadata:
  name: ack-test-security-group
  namespace: cicd-platform
spec:
  description: The sg for the test application
  name: ack-test-security-group
  vpcID: {VPC_ID}
  egressRules:
    - ipProtocol: "-1"
      ipRanges:
        - cidrIP: <IP_ADDRESS>/0
          description: Allow traffic from all IPs
  ingressRules:
    - ipProtocol: "-1"
      ipRanges:
        - cidrIP: <IP_ADDRESS>/0
          description: Allow traffic from all IPs
  tags:
    - key: Name
      value: ack-test-security-group

K8S resource status:
...
Status:
  Ack Resource Metadata:
    Owner Account ID:  {AWS_ACCOUNT_ID}
    Region:            eu-west-1
  Conditions:
    Message:               InvalidGroup.Duplicate: The security group 'ack-test-security-group' already exists for VPC '{VPC_ID}'
                           status code: 400, request id: {REQUEST_ID}
    Status:                True
    Type:                  ACK.Recoverable
    Last Transition Time:  2022-12-28T13:28:04Z
    Message:               Unable to determine if desired resource state matches latest observed state
    Reason:                InvalidGroup.Duplicate: The security group 'ack-test-security-group' already exists for VPC '{VPC_ID}'
                           status code: 400, request id: {REQUEST_ID}
    Status:                Unknown
    Type:                  ACK.ResourceSynced
Events:                    <none>

EC2-controller log:
2022-12-28T13:19:52.700Z    ERROR    controller.securitygroup    Reconciler error    {"reconciler group": "ec2.services.k8s.aws", "reconciler kind": "SecurityGroup", "name": "ack-test-security-group", "namespace": "cicd-platform", "error": "InvalidGroup.Duplicate: The security group 'ack-test-security-group' already exists for VPC '{VPC_ID}'\n\tstatus code: 400, request id: {REQUEST_ID}"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
    /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:266
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
    /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:227

Steps to reproduce

I applied the above resource with and without the ingressRules and egressRules fields.
The resource was successfully synced when no security group rules have been applied.
In presence of the security group rules the resource is created on AWS side but the K8S resource is unfortunately not synced and the above error is seen...

Expected outcome

I would expect the K8S resource to be synced successfully as the resource is successfully created in AWS.

Environment

Kubernetes version: v1.23
EKS version: v1.23.13-eks-fb459a0
ec2-controller v0.1.0, SecurityGroupresource is utilised.

An update on the situation:
The error only occurs when the egressRules field is defined. Is there anything wrong with the SG rule that is present in the yaml definition?

@mustafasencer The error is stating that a security group with that name already exists... I don't think it has anything to do with ingressRules or egressRules. I think you need to simply delete the other ack-test-security-group SG.

@jaypipes Thanks for the prompt response.
It is the weird part of the problem which was bugging me. I deleted the SG prior to applying the above SG definition. I validated it via the console again before applying it to the cluster, so I can assure you that it was deleted. Whenever the above egressRules field is present in the custom resource, the SG custom resource is having trouble in syncing the resource (although the resource is created in AWS). To validate my point I tried multiple times with and without the egressRules field...
Note: Creating the SG without the egressRules field creates a default outbound rule with all traffic allowed. Could that be behind the sync issue for the SG custom resource? Thanks 🙂

Interesting... I will ask @LikithaVemulapalli to look into this and put together a reproduceable test case for it. Looks like you may have uncovered a latent bug! :)

The same problem
  Conditions:
    Last Transition Time:  2023-01-16T10:08:13Z
    Status:                True
    Type:                  ACK.ReferencesResolved
    Message:               InvalidGroup.Duplicate: The security group 'test-sg' already exists for VPC 'vpc-0854a1b843c796bd3'
                           status code: 400, request id: 1460adb1-580b-4b2d-a751-fac5a65a37f3
    Status:                True
    Type:                  ACK.Recoverable
    Last Transition Time:  2023-01-16T10:08:13Z
    Message:               Unable to determine if desired resource state matches latest observed state
    Reason:                InvalidGroup.Duplicate: The security group 'test-sg' already exists for VPC 'vpc-0854a1b843c796bd3'
                           status code: 400, request id: 1460adb1-580b-4b2d-a751-fac5a65a37f3
    Status:                Unknown
    Type:                  ACK.ResourceSynced

remove egress rule will work.

/assign

@jljaco I just submitted a PR related to this particular issue. Please feel free to share your thoughts on it. Thanks! 🙂

This should now be resolved by @mustafasencer 's PR.  We will be cutting a new release of the EC2 controller in the near future, which will include this change.


Bump fedora-coreos-config to latest testing-devel

Bump fcos config to latest in testing-devel
Update openshift-os to latest master
Update FCOS pinned packages and NetworkManager

/retest

/test e2e-ovirt
/test e2e-vsphere

/test e2e-ovirt

/retest

/override ci/prow/e2e-aws
Known issue, tests are using redhat OLM catalog disabled in OKD

/skip


Make a link to install latest version?

I have script(s) installing nvm. And I'd like to just install the latest version.
Please consider making a url (somewhere) that would always point to the latest version of nvm.
E.g. this install command could be
curl -o- https://nvm.org/install.sh | bash

That would be blindly updating across breaking changes, and would be a terrible idea.
Duplicate of #400.

Just realised I can use this link:
https://raw.githubusercontent.com/nvm-sh/nvm/master/install.sh

Nope, because master is often broken. Only tagged releases are safe to use.

@ljharb there are other use cases, like using cloud-init.
Please consider updating the release asset name to a well known sticky one, or at least providing another asset that always has a fixed name, like nvm.zip, so https://github.com/nvm-sh/nvm/releases/latest/download/nvm.zip could be used for automating installs with cloud-init. You can have the zip contents reflect on version if you wish.

Even better would be just to include the install.sh in the releases.
But in the mean time, there is a very hacky solution to getting the latest install script that doesn't rely on magic version numbers or creation of temporary files etc
curl -sL "$(curl -sL https://api.github.com/repos/nvm-sh/nvm/releases/latest | jq -r .zipball_url)" | busybox unzip -p - '*/install.sh' > nvm_install.sh

@emilfihlman your use case still has the problem that breaking changes will be silently installed, risking breaking your workflow. The proper solution is to always hardcode a version number or semver range.

@ljharb I think it's not for this package to be concerned about that.
The proper solution is definitely to not hardcore version numbers. That is the most awful thing to do.

@emilfihlman it is absolutely for nvm to be concerned about circumstances that could cause nvm users to have a broken experience.
Why is that the most awful thing to do? That's literally the universal consensus on all forms of dependencies in the entire security and tech ecosystem (too much, imo, even)


SyntaxError: Unexpected token < at eval ()

I'm submitting a ...  (check one with "x")
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see use [gitter](https://gitter.im/mgechev/angular2-seed) or [stackoverflow](https://stackoverflow.com/questions/tagged/angular2)

Current behavior

Expected behavior

Needs to compile and run without error
Minimal reproduction of the problem with instructions

It works with previous version but I get this error when I update my code with the latest version of angular-seed.
Please tell us about your environment:

OS: Windows X
IDE: None
Package manager: npm v.6.9.1

Angular Seed Version: aaaaf75

Node: node --version = v6.9.1

That's incorrect import, not an issue in Angular seed.

Is it the third party library you are talking about?

@arun-awnics you can take a look at the network tab and see which file is not being loaded properly. What happens is:

You try to load a non-existing module with SystemJS.
The dev server returns index.html.
SystemJS tries to run index.html as JavaScript.
You can the error SyntaxError: Unexpected token < at eval.

I am doubting that's not the problem I am facing. I did what you said in the network tab. I see that I have included all the imports in project.config.ts.
I get this error while compiling:
src\client\app\system-config.ts(1,13): error TS2451: Cannot redeclare block-scoped variable 'System'.
What does that mean? Can you please tell me what it is? @mgechev
Thank you in advance.

@arun-awnics With seed update some changes got introduced here.
I also had to disable/remove the first declare var System: SystemJSLoader.System; line inside src\client\app\system-config.ts, then it worked.

Hey @maxmarkus Even after removing or commenting the first line, I still get the same error.

I'm having the same problem, did you find a solution @arun-awnics?

No @MathijsHoogland I tried everything said above and it still doesn't work. Were you able to find the solution?

Also running into this.  Started working again on my Angular 2 project after about 4 months.  The project used to work fine at that time. Made no other changes, just updated to the latest Seed, which brought my project from Angular 4.0.0 to 4.2.3.  Don't see any errors (missing files) in the Network tab of Dev tools.  Also removed and re-installed node_modules directory.

I am getting same error..arun, Did you fix this issue?

@skolli853780 - in my case the problem was due to some third part libraries/packages not getting loaded.  I managed to use the debugger (set a break point in code just before the error occurs, then turn on 'break on exception') to identify the library that could not be loaded.  For each of the 'unloadable' libraries, I had to add the following code (using base64-js as example) to additionalPackages in my project.confiig.ts:
{
      name: 'base64-js',
      path: 'node_modules/base64-js/index.js',
      packageMeta: {
        defaultExtension: 'js'
      }
    }

@hhubik your suggestion helped me to resolve the unexpected token issue. I had multiple packages breaking so fixed one by one added entries to project.config.ts file . Attaching screenshot if it might help others, please have breakpoint at the file and look for 'address' that indicates you the package.

below are 2 such packages
  {
    name: 'rxjs',
    path: 'node_modules/rxjs/bundles/Rx.js',
  },
  {
    name: 'moment',
    path: 'node_modules/moment',
    packageMeta: {
      main: 'moment.js',
      defaultExtension: 'js'
    }
  }


Do you plan to support @apollo/react-hooks

Do you have plans to support the @apollo/react-hooks to be passed into the form instead of the mutation?

Hooks are definitely coming in @apollo/client v3, and I'd love to use them in conjunction with frontier-forms! :heart:


Shared, API: Clear draft and expired docs from IndexedDB in non-cms mode, and exclude from data from API to Client

Need to implement delete functionality before working with the drafted docs.

The test in EditContent.spec.ts is failing. I found it's always the first test in the file that fails: putting a different test from that file on top makes that test fail. It's not the specific test that's the problem (and actually we can see that because that test can load content from the database is exactly the same as a test lower in the file renders the title of the default language which is succeeding).


Google Code wiki link 404s

The front page of the memcached GitHub wiki links to the following Google Code wiki: https://code.google.com/archive/p/memcached/wikis/NewStart.wiki
However, this page 404s. This is an issue as the GitHub wiki is missing several pages and directs the user to Google Code.

Apologies. I'm still trying to find enough time to finish converting the wiki over. :(

That's okay! So is the wiki no longer publicly available?

You can view it via the wayback machine, but google code no longer displays it. Until I finish updating and porting it to github (much of it is out of date anyway).

Can't access https://code.google.com/archive/p/memcached/wikis/Tap.wiki
Wayback machine isn't helping:
Wayback Machine doesn't have that page archived.
Maybe you can upload the RAW stuff somewhere so the community can help you make the wikis up?
It's kind of weird not having the proper documentation anywhere on the internet.

The link forAPI on homepage is also pointing google code.

uploaded the raw old wiki here: https://github.com/memcached/old-wiki/
been porting pages over every couple days lately. shouldn't take too much longer.


Reset composited layer before any of them is repainted

fixes https://github.com/flutter/flutter/issues/95974
If a child layer is moved to a new container layer in the same frame. the assert will throw if the new container is painted before the old container is painted. This pr fixes it so that the pipelineowner resets all the dirty container layer before any of them is painted
Pre-launch Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Gold has detected about 8 new digest(s) on patchset 3.
View them at https://flutter-gold.skia.org/cl/github/95977

@goderbauer  PTAL

Why does this change goldens? Is that expected?

@goderbauer that is previous commit, which broke a lot of tests, the latest commit does not have golden change

@goderbauer PTAL

@goderbauer PTAL, I also fixed another corner case.


[goenv-bot]: Add 1.19.3 1.18.8 definition to goenv

This adds the Go Definitions for version 1.19.3 1.18.8.
Created by Github action automation

Tests are failing because changes from #261 have not yet been merged :smiling_imp:


Content rectification

Modified the "Question answering is a free feature" phrase. This is not a free feature any more.

#sign-off

@jaydeepn: I'm sorry - only the author of this article, @aahill, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@aahill , kindly review and approve this PR

@jaydeepn : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

@Jak-MS Could you please let me know if there is any action needed from my end to get this PR merged

@jaydeepn - No further action is needed from you. We're just waiting for a review from @aahill

@aahill - Could you please review and merge

#sign-off


QUIC: Do not discard the INITIAL el too early

RFC says that successful decryption of HANDSHAKE el packet triggers the discard on server side only.
On client we discard INITIAL el when we successfully send a HANDSHAKE packet.

This fixes interop with quic.tech:4433

Not sure how to test it so setting test: exempted but if you have any hints/ideas for the test, they are welcome.

75-test_quicapi.t needs to be adjusted.

Aargh... this makes the ssltraceref non-deterministic.

Good catch. LGTM once this passes.

Good catch. LGTM once this passes.

It seems we're sending PINGs very early. I'll need to investigate that.

All my interop tests are passing now.

Hmm... this looks much better. @hlandau what do you think about d878df2

Aaaargh, I was too quick - the Windows run still failed with the quicapi test. And now I am completely out of ideas on what to do next with this.  I simply cannot believe that there is no progress with the handshake for 15 seconds so the PING is generated. I could probably fake time for the client when we can be already faking it for the server side. Although that still looks to me like an overkill.
@hlandau @mattcaswell any ideas?

The ping is acked so that is not too bad... We don't break the protocol, do we?

The ping is acked so that is not too bad... We don't break the protocol, do we?

Yeah, it is not a bug per se. It's just that the test needs to be somehow fixed to not fail randomly and I am still not 100% convinced that what triggers the ping is an extremely slow response from the server - because the ping deadline should be 15 seconds of no traffic sent or received on the client side. I cannot see how possibly that can happen just by having the VM that runs the CI slow.

Changing MAX_NAT_INTERVAL (in ssl/quic/quic_channel.c) makes the test pass... May be we can detect a slow box and adjust or force the ping in the test.

Does it really? The MAX_NAT_INTERVAL is 25s where the the half of max_idle_timeout is 15s

I am getting crazy: I have put a trace in ssl/quic/quic_channel.c near:
/* If a ping is due, inform TXP. */
but I don't see it.. I also traced ch_update_ping_deadline() and the ch->ping_deadline is too big to be triggered.
Any ideas?

Have you ever triggered the actual failure of the test locally? Because I am unable to. It just happens in the CI.

@jfclere another possibility of ping frame is a probe whose deadline is much shorter because it is based on RTT.
The faked client time seems to resolve this. So this is now ready for review.

d878df2 and 56ea15b could be possibly dropped but I think both are beneficial anyway.

This pull request is ready to merge

Merged to master branch. Thank you for the reviews.


Inc/Dec AP in order of display

This will go into the larger armour refactor branch, once the conflicts are resolved I'll merge.

I changed my mind, this has been merged in develop


Update Composer dependencies (2022-09-04-00-08)

Visual regression test passed!
View the visual regression test report


llvmdev v7.0.0 with rebased SVML

Rebased SVML patch and merged it with a better fix for vectorization factor bug in Legalizer.

Checklist

[x] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Closes #46

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Thanks for working on this Anton.
One thing we could try is SSH-ing into a failed build. We have to tell CircleCI that we want to run an SSH build and I think it has some time limit after which the VM expires, but this could be a good way to figure out what is going on there.

ok.. so, it is our patch after all.. one idea is that the compiler broke RVO when returning string class

@jakirkham It works finally!

one idea is that the compiler broke RVO when returning string class

Did this turn out not to be the case?

@mingwandroid No, though I'm not entirely sure how exactly it was broken because I haven't seen it in debugger, but it is about LLVM's string manipulation approach with their StringRef class which has implicit conversion from std::string and which doesn't really work. So, it's another artifact of merging two patches here, which is not as obvious as a merge conflict or a compilation error.

The second part of this merged patch is published as https://reviews.llvm.org/D53035


Segmentation fault when constructing V8Js

Hi whenever I attempt to create an instance of V8Js using new V8Js();
PHP segfaults with no error message. I turned on xdebug to figure out what was going on and this was the result:
    TRACE START [2015-08-06 08:40:21]
        0.0001     221416   -> {main}() Command line code:0
        0.0001     221968     -> V8Js->__construct() Command line code:1

From the command:
    php -d xdebug.auto_trace=ON -d xdebug.trace_output_dir=traces/ -r "new V8Js();";

My PHP info on V8Js looks like the following:
     v8js
     V8 Javascript Engine	enabled
     V8 Engine Compiled Version	4.6.0
     V8 Engine Linked Version	4.6.0 (candidate)
     Version	0.2.1
     Directive	Local Value	Master Value
     v8js.flags	no value	no value
     v8js.use_array_access	0	0
     v8js.use_date	0	0

Should the version be 0.2.1 or is that unrelated to the actual version of the extension. I compiled it only yesterday and previously had an older version of the extension working correctly on my site.
Output of php -v:
    PHP 5.6.10-1+deb.sury.org~trusty+1 (cli)
    Copyright (c) 1997-2015 The PHP Group
    Zend Engine v2.6.0, Copyright (c) 1998-2015 Zend Technologies
        with Zend OPcache v7.0.6-dev, Copyright (c) 1999-2015, by Zend Technologies
        with Xdebug v2.3.2, Copyright (c) 2002-2015, by Derick Rethans
        with blackfire v0.24.1, https://blackfire.io/, by SensioLabs

Is there anything I can do about this issue except downgrade to the previous version that was working? Is there any other information that you require?
Here is a link to my full phpinfo: http://pastebin.com/raw.php?i=Sw82J4vi

Aha just looking this looks like this may have been addressed in #152, will attempt one of the resolutions mentioned in there now.

Ok after waiting an hour to finish compiling, nope, doesnt appear to have fixed the issue by adding the snapshot=off to the make command.

Err, the provided console output tells that the test suite did pass the test, so V8Js is working.
Maybe the previously compiled version is around somewhere and it's actually loading that one?
There also is that strange message fatal: destination path 'v8js' already exists and is not an empty directory. the output.  Depends on what the ran script is, whether that's a critical one.  Just in case ...

@TomCaserta ping
Did that solve the problem you reported? Or doesn't it still work for you?

Sorry was away for the weekend, I'm not entirely sure the path v8js existing would be a issue of which would cause it to not work (maybe, really do not know). I believe I have deleted all traces of v8js on my system and then recompiled, that fatal error did not occur when building it this time.
Thing is, it is still giving me a segmentation fault, I must have missed some reference to an older version of v8js somewhere but I cant figure out where.
Here is the build script I used:
#!/bin/bash -eux

apt-get install chrpath

cd /tmp

git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git
export PATH=`pwd`/depot_tools:"$PATH"

fetch v8
cd v8

make native snapshot=off library=shared -j8

chrpath -r '$ORIGIN' out/native/lib.target/libv8.so

sudo mkdir -p /tmp/v8-install/lib /tmp/v8-install/include
sudo cp out/native/lib.target/lib*.so /tmp/v8-install/lib/
sudo cp -R include/* /tmp/v8-install/include
echo -e "create /tmp/v8-install/lib/libv8_libplatform.a\naddlib out/native/obj.target/tools/gyp/libv8_libplatform.a\nsave\nend" | sudo ar -M

cd /tmp
git clone https://github.com/preillyme/v8js.git
cd v8js
phpize
./configure --with-v8js=/tmp/v8-install
make
make test
sudo make install

echo "extension=v8js.so" > /etc/php5/mods-available/v8js.ini
ln -s /etc/php5/mods-available/v8js.ini /etc/php5/cli/conf.d/20-v8js.ini

service php5-fpm restart
service nginx restart

Oh wow, okay sorted it. So originally there was definitely some sort of issue with the extension I compiled, which then caused me to use Xdebug.
Now I decided to not use xdebug and just try running it normally after I compiled it with the snapshot=off. It didnt segfault this time, I double checked it was working by printing something via javascript and that all worked correctly. So at this point I know that everything was correct in the config files and it was loading the correct extension. And thats when I realised that when I was issuing the php5-fpm restart command it wasnt actually restarting due to a bug on ubuntu that is laid out here:
http://stackoverflow.com/questions/19998526/ubuntu-php5-fpm-throws-unknown-instance-on-reload
After applying that fix. Killing php5-fpm and starting it up again, everything works correctly now which is great.
Thank you for your help @stesie.


Emoji Present

Description of the new feature / enhancement
There should be a small Emoji Window open all the time as you type on a document or on a webpage.
Scenario when this would be used?
When opening a text editor eg. Word, Notepad, Gmail, while a word is typed there should be a small box showing the emoji if the word matches, and then one could click on the emoji windows, without having to press keys and it would put the emoji next to the word (but we could select in front of the word or the end of the word).  What  would be great is to select the position of the emoji in the word. Example:  I type Drop, then if there is an emoji position lets say 3rd position, Dr💧p.  Or Delivery like the second position, D🚚livery. Cat, C😸t.
Create a O's emoji.  Type a word and shows all the round emojis.
Lol, L🤣L.  G😍ing, L😍ve, B🥱red etc.
Supporting information
No response

Interesting idea, however No plans for powertoys to create this.

Crutkas,
I don't have that programming skill.  I noticed by using the "::" emoji you are looking for  "::" sometimes it pops up.
But I'm hoping someone can develop and improve on the Emojis.
Regards.


Correct the spelling of CocoaPods in README

This pull requests corrects the spelling of CocoaPods 🤓
https://github.com/CocoaPods/shared_resources/tree/master/media
One day I’ll make a bot that looks through the READMEs of all Pods, looks to see if it uses “Cocoapods” and PRs “CocoaPods” :D— Ørta (@orta) February 10, 2016

¯/(ツ)/¯

Thanks https://github.com/Intermark/Buoy/commit/0f81bf0e8fec3468b36d85d0a4215e7cc35b2949


Use ruff for formatting

[ ] Closes #8760
- [ ] Tests added
- [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
- [ ] New functions/methods are listed in api.rst

Note: many inline ... obtain their own line. Running black . would have produced the same result

Additionally, xarray is a small-ish repository, and running black on the entire code base (which is a rare thing to do outside of CI) completes in less than a second (using the compiled black on PyPI). In other words, I'm not sure if speed should be the deciding factor.

I find that the big files such as dataset.py & test_dataset.py take a long time to save, with autoformatting in vscode. Xarray is the only python repo I have this problem with. It makes working with a quick iteration loop of tests running when saving a file implausible.
Running echo "" >> xarray/tests/test_dataset.py &&  time black xarray/tests/test_dataset.py takes 5000ms!
Running  echo "" >> xarray/tests/test_dataset.py &&  time ruff format  xarray/tests/test_dataset.py takes 50ms
So I would prioritize performance quite highly here

I would vote for waiting until the dust settled a bit more

Not strongly opposed to waiting for a bit if others want to, I do expect some churn in the ruff formatter

Note: many inline ... obtain their own line. Running black . would have produced the same result

I think this is an issue with black versons. Worth aligning with the pre-commit config

Hello,
Thanks for your answers!
I made this Draft PR as a small example of migrating from black to ruff-format, to have some base material to talk about the parent issue #8760.

I can't reproduce black . moving the ... in type stubs / override to a separate lin

and

I think this is an issue with black versons. Worth aligning with the pre-commit config

Regarding black .: indeed I did not pay attention at the version I used. Here is the version on my project env:
black --version
black, 21.12b0 (compiled: no)

I also see I don't have a compiled version of black installed. I am not sure how to get this version though.
Also I agree that I am not a fan of this forced de-inlining, I had a look inside of the ruff-format documentation but could not find any configuration option allowing to opt-out of this de-inlining. It also brings unnecessary formatting changes to the codebase. Maybe an issue can be raised on the ruff repo itself about this topic, it being a necessary condition before even considering moving to using ruff-format.

The trailing empty line for blocks (empty ...) were something we intentionally chose to introduce in #4510 (this was a styling option that the ruff people intentionally chose to do differently).

Regarding the trailing ... in doctests: I know they can cause issues when using pytest-accept. See https://github.com/max-sixty/pytest-accept/issues/148 for the discussion on that matter with @max-sixty ; it can even be traced back to a bug in the standard doctest lib itself. So I would argue in favor of removing them, something that ruff does. Also I am not sure where in #4510 these trailing ... are mentioned, maybe it is the wrong link?

Another thing which I'm not too happy about is their assumption of :: in rst meaning python

Is this something that blackdoc solves? Would it be possible to extract this logic with another formatter, or is it tightly coupled to black? Or in other words: do you think blackdoc could become a ruffdoc at some point? As the author of blackdoc you would have valuable insight to help improve other formatters for sure.
If I understand well, it formats code contained in documentation. This issue mentions formatting code in documentation + blackdoc: https://github.com/astral-sh/ruff/issues/7146

Additionally, xarray is a small-ish repository, and running black

I agree with @max-sixty here, I also use VSCode with auto-formatting enabled and the project is laggy from time to time. Two levers of action I can think of: reducing formatting time with a more performant formatter, or reducing  the size of the file sizes (this would be a refactoring effort, and I don't know what the xarray team considers to be a "too big" file that would deserve to be split). Quality of life during development is valuable

Maybe an issue can be raised on the ruff repo itself about this topic

Based on the discussion at the end of astral-sh/ruff#5822 I am led to believe that we just need to wait a bit more?

maybe it is the wrong link?

that was https://github.com/pydata/xarray/pull/4510#discussion_r512138255, sorry for not directly linking that

Would it be possible to extract this logic with another formatter, or is it tightly coupled to black?

ruff is entirely written in rust (which is what makes it fast), while blackdoc is written in python (and build on top of black). The two are thus pretty much incompatible as far as code goes, but I remember the ruff people looking at both blackdoc and blacken-docs for inspiration when creating the docstring formatter.
In any case, note that formatters should not change the behavior of other tools, if it does then there's something wrong with either the formatter or the other tool. The trouble here, though, is that doctest is a pretty ambiguous format: what would
>>> print("...")
...

be interpreted as? ruff (and blackdoc) will probably both remove the trailing ..., and would be wrong to do so.
However, this:
>>> if condition():
...     do_something()
...

is not as ambiguous: since the code example starts with a block statement, the ... can be expected. Obviously that would require an analysis of the first line(s), but this is much better than having to analyze the semantics (and it usually is not a good idea to artificially restrict a style because of the tooling).
I'm not sure how resolve this, besides switching to a different format where you're much more unlikely to encounter the ambiguity (like the IPython format).

I also use VSCode with auto-formatting enabled

I can empathize with that. I personally do the auto-formatting on commit (using pre-commit), not on save, so I'm not as affected by that (waiting a bit longer on commit is not that much of a deal).

we just need to wait a bit more

Yes indeed, if I understand well black has this concept of "Preview" style: https://black.readthedocs.io/en/stable/the_black_code_style/future_style.html
This is possible to test this "preview" style (see https://github.com/astral-sh/ruff/issues/10026#issuecomment-1951367648 ; I updated the PR accordingly)
When this preview style is used, Ellipses are back onto their single line, but other style changes also come in.

The print("...") example is perfect!

I'm not sure how resolve this, besides switching to a different format where you're much more unlikely to encounter the ambiguity (like the IPython format).

What is the IPython format, an alternative syntax for doctests? As usual, delimitation is the issue: how to delimitate input from expected output to be unambiguous without becoming too verbose...

but other style changes also come in.

You'd also get these other changes with black, but I think they pushed those back a year because it wasn't stable enough in time for the new stable style. So I think ruff just needs to catch up to that change.

What is the IPython format, an alternative syntax for doctests?

just like doctest it is the output of a REPL, in this case ipython instead of python, so we'd (basically) be copying the output of a interactive shell. However, the delimiters chosen for continuation lines (  ...:, with the number of spaces chosen such that the prompts align) are much less likely to be encountered outside of REPL tooling.
For example:
In [9]: """
   ...: """
Out[9]:

In [10]: (
    ...:     1 + 2
    ...: )
Out[10]: 3

So ipython is to python what an idoctest would be to doctest! I can see that something already exists: https://github.com/ipython/ipython/blob/main/IPython/testing/plugin/ipdoctest.py
What I can see potentially annoying with IPython format is the numbering of the input-output pairs, if you want to add an example at the top of the docstring, all the following existing doctests would require to change. Also, when going from 9 to 10, digit count goes grom 1 to 2 and adds an offset.
Here I just empty the execution count, replacing it by a space.
Then the docstrings would look like for example:
In [ ]: """
   ...: """
Out[ ]: '\n'

In [ ]: (
   ...:     1 + 2
   ...: )
Out[ ]: 3

In [ ]: print("...")
...

In [ ]: print("Out[ ]:")
Out[ ]:

In [ ]: "Out[ ]:"
Out[ ]: 'Out[ ]:'

In [ ]: None

In [ ]:

I notice that the diff is now quite large? I guess that's the preview flag?
And that mypy is failing?
If we can reduce the size of the diff as much as possible and get the docs passing, I'd be +1 here. But obv one voice among many. I'm also fine to wait until things settle more if others prefer.

Yes, the preview flag brings too things:

The single line stubs
Javascript-style braces

The preview flag cannot be reliable upon, so for now, the only option is to wait for the official integration of single line stubs in the formatting rules
Even with preview = false the diff is still large (36 files). However most of it is constituted of ellipses. So when it's fixed, the diff should be significantly smaller
There is still also the issue of ellipsis new lines in the dosctrings, but it is has a less significant share in the diff.
I'll try to keep this draft PR updated  as a "showcase" of what applying ruff alongside a pre-commit run --all would look like

I'll try to keep this draft PR updated as a "showcase" of what applying ruff alongside a pre-commit run --all would look like

OK perfect!


dart2js: Code does not run with -O0

I just tried running the code in https://github.com/dart-lang/sdk/issues/41449 with -O0.
The code fails with:
o1.js:1328: TypeError: Cannot read property '$add' of undefined
      return $arguments.length !== 0 ? C.JSString_methods.$add(s, J.$add$ns(C.JSString_methods.$add("<", H._Universe__canonicalRecipeJoin($arguments)), ">")) : s;
                                                          ^
TypeError: Cannot read property '$add' of undefined
    at Object._Universe__canonicalRecipeOfInterface (o1.js:1328:59)
    at Object._Universe__lookupInterfaceRti (o1.js:1332:17)
    at Object._Parser_handleTypeArguments (o1.js:1603:22)
    at Object._Parser_parse (o1.js:1496:17)
    at Object._Universe__parseRecipe (o1.js:1172:19)
    at Object._Universe_eval (o1.js:1133:15)
    at findType (o1.js:661:16)
    at rtii (o1.js:2574:20)
    at dartProgram (o1.js:2589:5)
    at o1.js:2635:3

There is an indirect cycle.
C.JSString is a constant interceptor (methods) in the constant pool.
The types are created (rtii, findType) for the type pool before the constant pool exists.
Possible ways to fix this:

Don't use + on Strings. Use a new _Utils.concatN(s1, s2, ..., sN) methods in rti.dart.
Use interpolation instead of + (it lowers to HStringConcat and the static S helper)
Change codegen for String.+ to be more like numbers - generate a check before the lowered + operation.
Adjust constant pool to have two parts, one that has the interceptors (and maybe other constants independent of types) that can go before the type pool initialization, and one that is dependent on types that must go after.

Pulling the interceptor constants earlier might be the best option since the others remedies don't apply if we find the same problem with a different interceptor.

Immediate issue above fixed by e0257265d34efffc845ea88643e183dc3cc5bb0e.
Needs more testing to close.

Just want to confirm I'm seeing the same thing. Depending on whether using Chrome or Edge, I'm seeing $add or the C.JsString_methods error.

@edyu If you could include the stack trace I could tell if it is the same issue or something else.

Uncaught TypeError: Cannot read property '$add' of undefined
at Object._Universe__canonicalRecipeOfInterface (rti.dart:1746)
at Object._Universe__lookupInterfaceRti (rti.dart:1755)
at Object._Parser_handleTypeArguments (rti.dart:2258)
at Object._Parser_parse (rti.dart:2140)
at Object._Universe__parseRecipe (rti.dart:1509)
at Object._Universe_eval (rti.dart:1442)
at findType (rti.dart:405)
at rtii (main.dart.js:69276)
at dartProgram (main.dart.js:69741)
at js_helper.dart:3221
_Universe__canonicalRecipeOfInterface @ rti.dart:1743
_Universe__lookupInterfaceRti @ rti.dart:1753
_Parser_handleTypeArguments @ rti.dart:2256
_Parser_parse @ rti.dart:2137
_Universe__parseRecipe @ rti.dart:1506
_Universe_eval @ rti.dart:1445
findType @ rti.dart:396
rtii @ main.dart.js:69276
dartProgram @ main.dart.js:69741
(anonymous) @ js_helper.dart:3221

From Firefox:
TypeError: C.JSString_methods is undefined
_Universe__canonicalRecipeOfInterface rti.dart:1744
_Universe__lookupInterfaceRti rti.dart:1755
_Parser_handleTypeArguments rti.dart:2258
_Parser_parse rti.dart:2140
_Universe__parseRecipe rti.dart:1509
_Universe_eval rti.dart:1442
findType rti.dart:405
rtii main.dart.js:69276
dartProgram main.dart.js:69741
 main.dart.js:70694

@rakudrama
I just posted the stack trace for both Chrome and Firefox.
Here is the corresponding build.yaml:
targets:
$default:
builders:
build_web_compilers|entrypoint:
options:
compiler: dart2js
dart2js_args:
- -O0

Thanks for the investigation. The bug fix e0257265d34efffc845ea88643e183dc3cc5bb0e is relatively recent and didn't make the cut for the most recent stable release (2.8.3) but will be in a future release (2.9 preview). In the meantime, use -O1 instead.


PERFECT CLEAR

It would be nice to see this.

OK.
I will investigate its specifications and implement it.


kubvirt-vm-latnecy: Change VMs inteface binding method to bridge

Signed-off-by: Or Mergi<EMAIL_ADDRESS>Depends on #75 and #73

Followed up at by #73


http or https in the strip() function?

Should we use https instead of http in this line?

Http is fine - we don’t actually use the protocol for anything except generating a full URL object from which we can extract the search params.

👍


Nerd Fonts

:wave:
Hello! Love the plugin. Please consider adding a built-in source for NerdFont symbols
Thanks :)

It could be based on this file, or a modified version of it
https://github.com/sudormrfbin/cheatsheet.nvim/blob/master/cheatsheets/cheatsheet-nerd-fonts.txt

You can check out my PR: https://github.com/nvim-telescope/telescope-symbols.nvim/pull/7

mreged


[joy-ui] Unexpected behavior of some components, RTL

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example:
codesandbox
Current behavior 😯
Tested on RadioButton, Select, and CheckBox
position is set to absolute by default is causing un-expected behavior when used in RTL. as shown in codesandbox demo.
Expected behavior 🤔
position is set to unset fixed the issue...
Context 🔦
No response
Your environment 🌎

npx @mui/envinfo
  System:
    OS: Windows 10 10.0.22621
  Binaries:
    Node: 18.6.0 - C:\kernal\nodejs\node.EXE
    Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 9.7.2 - C:\kernal\nodejs\npm.CMD
  Browsers:
    Chrome: 116.0.5845.180
    Edge: Spartan (44.22621.2215.0), Chromium (116.0.1938.76)
  npmPackages:
    @emotion/react: ^11.11.1 => 11.11.1
    @emotion/styled: ^11.11.0 => 11.11.0
    @mui/base:  5.0.0-beta.12
    @mui/core-downloads-tracker:  5.14.8
    @mui/icons-material: ^5.14.3 => 5.14.6
    @mui/joy: 5.0.0-beta.5 => 5.0.0-beta.5
    @mui/material: ^5.14.8 => 5.14.8
    @mui/system: ^5.14.8 => 5.14.8
    @mui/types:  7.2.4
    @mui/utils: ^5.14.7 => 5.14.8
    @types/react:  18.2.21
    react: ^18.2.0 => 18.2.0
    react-dom: ^18.2.0 => 18.2.0
    styled-components: ^5.3.11 => 5.3.11

As explained in https://mui.com/material-ui/guides/right-to-left/, you need to apply the CSS post processor on theme provider for RTL to work as expected.
Forked your sandbox with a demo: https://codesandbox.io/s/rtl-position-unset-forked-q4rt23?file=/src/App.js
Notice how ThemeProvider accepts a locale (unused) prop. You can use it to switch between LTR and RTL layouts.

Mark this as docs improvement.


feat(@angular/cli): added option to override default path 'app'

Added option 'directory' to .angular-cli.json which allow the default app path to be overridden. The default remains  'src/app' but this allows the use of angular-cli also for projects containing many apps with identical root (see: https://yakovfain.com/2017/04/06/angular-cli-multiple-apps-in-the-same-project/).
For discussion, see issue #3095.

I have signed the CLA

@SPKorhonen this PR is outdated... blueprints are no longer being used to with ng new & ng generate... those are now coming from the devkit repo under packages/schematics/angular
link


disconnect reconnect loop issue

2016-11-08 09:08:09|mono-sgen-1124|INFO|FaithBOT|Start() Starting...
2016-11-08 09:08:09|mono-sgen-1124|INFO|FaithBOT|OnDisconnected() Disconnected from Steam!
2016-11-08 09:08:09|mono-sgen-1124|INFO|FaithBOT|OnDisconnected() Reconnecting...
2016-11-08 09:08:19|mono-sgen-1124|INFO|FaithBOT|OnDisconnected() Disconnected from Steam!
2016-11-08 09:08:19|mono-sgen-1124|INFO|FaithBOT|OnDisconnected() Reconnecting...
2016-11-08 09:08:29|mono-sgen-1124|INFO|FaithBOT|OnDisconnected() Disconnected from Steam!
2016-11-08 09:08:29|mono-sgen-1124|INFO|FaithBOT|OnDisconnected() Reconnecting...
2016-11-08 09:08:39|mono-sgen-1124|INFO|FaithBOT|OnDisconnected() Disconnected from Steam!
2016-11-08 09:08:39|mono-sgen-1124|INFO|FaithBOT|OnDisconnected() Reconnecting...
2016-11-08 09:08:49|mono-sgen-1124|INFO|FaithBOT|OnDisconnected() Disconnected from Steam!
2016-11-08 09:08:49|mono-sgen-1124|INFO|FaithBOT|OnDisconnected() Reconnecting...
2016-11-08 09:08:59|mono-sgen-1124|INFO|FaithBOT|OnDisconnected() Disconnected from Steam!
2016-11-08 09:08:59|mono-sgen-1124|INFO|FaithBOT|OnDisconnected() Reconnecting...
2016-11-08 09:09:09|mono-sgen-1124|INFO|FaithBOT|OnDisconnected() Disconnected from Steam!
2016-11-08 09:09:09|mono-sgen-1124|INFO|FaithBOT|OnDisconnected() Reconnecting...
2016-11-08 09:09:19|mono-sgen-1124|INFO|FaithBOT|OnDisconnected() Disconnected from Steam!
2016-11-08 09:09:19|mono-sgen-1124|INFO|FaithBOT|OnDisconnected() Reconnecting...

how to resolve this?

Please review the guidelines for contributing to this repository.

https://github.com/JustArchi/ArchiSteamFarm/blob/master/CONTRIBUTING.md

If my issue is not meeting contributing guidelines specified above, especially if it's a question or technical issue, please close my issue immediately - I won't complain.


Update to Rust 1.69.0

Not fully tested, but compiles. (I'll let CI do the testing)

Depends on https://github.com/tcdi/postgrestd/pull/44 (although that one shouldn't directly get merged into 1.67.1 for obvious reasons)

Ship it whenever CI goes green.  Oh, it just did!


add PR review bot

The secrets are added to the repo

@wenboown can you take a look? Thank

@wenboown can you take a look? thanks


[eslint] Ignore coverage reports

Running eslint after tests is currently broken locally because the coverage folders are not ignored. This fixes that.

Thank you :sleeping: :sleepy:

:+1:  :speedboat:


"Expected [K, V] tuple" when initialising config via JS

Describe the bug
When initializing the config via the JavaScript objects Netlify throws an error on load. It doesn't break but immutable.js throws an exception.
To Reproduce

CMS.init within cms.js
Add any minimal setup object
Run NetlifyCMS via gatsby develop

Expected behavior
Uncaught (in promise) TypeError: Expected [K, V] tuple: < : immutable.js:3575
Screenshots

Applicable Versions:

Netlify CMS version: 2.12.12
Git provider: Local
OS: MacOS
Browser version: Chrome, Firefox
Node.JS version: v11.4.0

CMS configuration
None. Init via JS

Hi @marcwieland95, can you please share your cms.js file?

I got this issue too till I realized is because

There was no config.yml present
I needed to add  load_config_file: false to my config
I had to add  window.CMS_MANUAL_INIT = true;

Yeah. Those settings are set. The config.yml doesn't need to exist since we're turning it off with the setting above.
I noticed that there's an option inside the gatsby-config.js which needs to be set and I haven't found it inside the documentation. -> manualInit: true
{
      resolve: 'gatsby-plugin-netlify-cms',
      options: {
            manualInit: true,
            modulePath: `${__dirname}/src/cms/cms.js`,
      },
},

After that, the error is gone.


MM-9763: fix regression in connecting config.ShowEmailAddress

Summary
Fix regression in connecting config.ShowEmailAddress
Ticket Link
https://mattermost.atlassian.net/browse/MM-9763
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed

@jasonblais Should this be going into 4.8 since it's a regression? The fix is simple enough to be low risk.

@hmhealey, this fortunately only regressed in master. v4.8 looks clean.

^that's correct and was also confimed by QA


Indicate Needed Node Version in README

Please update the readme. The git repo should be cloned, and probably you need to determine prerequisite such as nodejs and npm version. I also received this error.
npm ERR! Linux 4.4.0-18362-Microsoft
npm ERR! argv "/usr/bin/node" "/usr/bin/npm" "run" "start"
npm ERR! node v8.10.0
npm ERR! npm  v3.5.2
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR<EMAIL_ADDRESS>start: webpack-dev-server --mode development --hot --progress --colors --port 3000 --open
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'webpack-dev-server --mode development --hot --progress --colors --port 3000 --open'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the agoracloud_ui package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     webpack-dev-server --mode development --hot --progress --colors --port 3000 --open
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs agoracloud_ui
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls agoracloud_ui
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /home/alireza/ui/npm-debug.log

Hi @parvizi,
It looks like you are using Node version 8.10.0, which has been deprecated. For the ui, you need at-least version 10. We will update the README with the required Node version today. Thank you for letting us know!

In develop


update deployment docs

Updated deployment docs to fix minor errors.

@MasonXon Fixed some broken links and corrected minor errors in the deployment docs. Could you please take a look? Thanks!


Filter Options for Transactions

We need some filters for the transaction overview (order by name, date, ...) and filter by a specific time range, pedelec, station, ...

http://lorenzofox3.github.io/smart-table-website/ is a good starting point


FIne-Tuning request for gpt-4o-2024-08-06, gpt-4o-mini-2024-07-18 and gpt-4-0613

Hi,
..\openai-master\OpenAI.Playground\TestHelpers\FineTuningJobTestHelper.cs
var createFineTuningJobResponse = await sdk.FineTuningJob.CreateFineTuningJob(new()
{
TrainingFile = uploadFilesResponse.Id,
Model = Models.Gpt_4o_mini        // from Gpt_3_5_Turbo to Gpt_4o_mini
});
I am trying to add fine-tuning for model Gpt_4o_mini, but got following error message. Do you have any plans to add fine-tuning function for gpt-4o-2024-08-06, gpt-4o-mini-2024-07-18, gpt-4-0613 and further o1 model?
Run Case Study Is The Model Making Untrue Statements:
ft:gpt-3.5-turbo-0125:nc::AbLl9Rrx
ft:gpt-3.5-turbo-0125:nc::AbI8tzQh
Uploading file FineTuningJobSample2.jsonl
FineTuningJobSample2.jsonl uploaded
Wait 5 seconds for the file to be ready
System.Net.Http.HttpRequestException: Response status code does not indicate success: 404 (Not Found).
at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()
at System.Net.Http.HttpClient.GetStreamAsyncCore(HttpRequestMessage request, CancellationToken cancellationToken)
at OpenAI.Managers.OpenAIService.ListFineTuningJobEvents(FineTuningJobListEventsRequest fineTuningJobRequestModel, Nullable`1 stream, CancellationToken cancellationToken) in C:\Users\ChNa653\Documents\Projects\AI\openai-master\OpenAI.SDK\Managers\OpenAIFineTuningJob.cs:line 33
at OpenAI.Playground.TestHelpers.FineTuningJobTestHelper.RunCaseStudyIsTheModelMakingUntrueStatements(IOpenAIService sdk) in C:\Users\ChNa653\Documents\Projects\AI\openai-master\OpenAI.Playground\TestHelpers\FineTuningJobTestHelper.cs:line 48

sorry my bad, I should look into https://platform.openai.com/docs/guides/fine-tuning for more detail, however, since I change the mode to Model = Models.Gpt_4o_mini_2024_07_18, the code completed fine-tune function.
Thanks!

functions existed!


Release 0.8.0 (take two)

LLVM issues should now be resolved. The tests that Jenkins uses for the master pipeline also passes on my clean 14.04 test machine, so in theory we should be all set (but there are ghosts in the machine)

Catching! All tests pass.


Initial implementation for VSCode Notebook support

This PR is for the initial implementation of our VSCode notebook support in ADS. The changes were getting a bit large, so we've decided to try to merge in the current work as is. Currently the only functionality we're missing is handling the creation of cell outputs for VSCode notebooks. Things like extension registration, extension activation events, and file type & kernel contributions all work in this set of changes. Basically all the things involved with opening and displaying a notebook in ADS.
These changes involved re-directing the VSCode notebook extension APIs and extension registration points to our own notebook APIs. Any VSCode extension notebook APIs we don't support yet (like various properties and lifecycle events) now throw an Unsupported error when called. As part of that API redirection functionality, I also added various classes that convert between VSCode notebook data types and our own. VSCode's NotebookSerializer maps to our new VSCodeSerializationProvider, while VSCode's NotebookControllers are encapsulated by the new ADSNotebookController (which is returned to the user when they call createNotebookController) and the new VSCodeExecuteProvider (which is registered internally and acts as a wrapper around ADSNotebookController). The ability to set cell outputs is still being worked on by @Charles-Gagnon , which would eventually be located in the new ADSNotebookCellExecution class, which for now is mostly a stubbed scaffolding class.
Apart from this new behavior, there were a couple of changes made to our existing code to accommodate it:

All VSCode notebook extension host functionality has been disabled to prevent any potential collisions. We didn't use VSCode notebooks in ADS anyway, so there's no issue here.
VSCode notebook providers register their "kernels", known as "supportedLanaguages" in vscode.NotebookController, at runtime, rather than during extension registration time. This means we have to wait for kernels to be registered before being able to query that information, instead of having that info ready to go by the time notebooks are started (like we do now). Functionally speaking, this required making any standardKernels lookup functionality to be awaitable, as well as adding a new function to our NotebookRegistry in order to register the supportedLanguages during runtime.
Since VSCode notebooks may not contribute any kernelSpec info like a Jupyter Notebook, I ran into issues with default kernel information not being available when trying to load the notebook. I modified the NotebookModel setup steps so that we now wait for the sessionManager to be ready in order to retrieve the defaultKernel info from that instead. However, we only do this if a defaultKernel wasn't already provided via the NotebookModel constructor.
VSCode notebook extensions rely on "onNotebook" activation events to start, so I updated our NotebookService to emit these activation events whenever a new notebook provider is registered (unless the provider being registered is one of our defaults, which don't use those activation events).
I added a check for undefined executeManagers when trying to start a notebook client session. Previously we were throwing cryptic undefined object errors before, but now throw an Error with a more helpful message. I ran into this issue a lot when trying to enable the standardKernels contributions, so this is more of an edge case improvement.
I added a few new optional properties to some of our Notebook interfaces in azdata.d.ts, so that we can carry through information needed when converting our notebook objects back into VSCode equivalents.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

76 of 233 (32.62%)  changed or added relevant lines in 11 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 41.654%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/api/browser/mainThreadNotebook.ts
1
2
50.0%

src/sql/workbench/services/notebook/browser/models/clientSession.ts
1
2
50.0%

src/sql/workbench/services/notebook/browser/models/notebookModel.ts
4
7
57.14%

src/sql/workbench/api/common/vscodeSerializationProvider.ts
35
40
87.5%

src/sql/workbench/api/common/extHostNotebook.ts
0
7
0.0%

src/sql/workbench/services/notebook/common/notebookRegistry.ts
0
7
0.0%

src/sql/workbench/services/notebook/browser/notebookServiceImpl.ts
27
41
65.85%

src/sql/workbench/api/common/adsNotebookController.ts
1
48
2.08%

src/sql/workbench/api/common/vscodeExecuteProvider.ts
2
74
2.7%

Files with Coverage Reduction
New Missed Lines
%

src/sql/workbench/services/notebook/browser/models/notebookModel.ts
1
53.24%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
27361

Relevant Lines:
59608

💛  - Coveralls


Bugfix in time pattern, +lint

Thanks for the PR!
I actually forgot about this... I guess it's time to try fixing it again!


No extention in normal three js setup

hi i might be wrong and i hope i am but why is the extention where you can move the stuff in a blender like tab only on react three fiber and i cant even use it to make a json of my animation and then import it into my normal three js website can someone please fill me in with info about this
thanks
<3

I believe that this is currently in progress , not sure on an exact release date but this other issue is the last information I have : https://github.com/theatre-js/theatre/issues/479


mopidy 1.0.0-2 WARNING: VKBackend does not implement playlists.as_list(). Please upgrade it.

mopidy 1.0.0-2 (Archlinux AUR package) leaves this string at console output:

WARNING  VKBackend does not implement playlists.as_list(). Please upgrade it.

Vk playlist is not avaliable through moped web front-end

Thanks! Will try to fix it as soon as possible.

tried to implement the patch in pull request #14


Ensure API_QUERY_URL terminates with slash

Document that the API query URL has to end in forward slash
Put some sort of check into the query tool for when there is no tailing slash - and then add one

otherwise the request can fail if a port is also specified. E.g.
API_QUERY_URL=http://localhost:8000 fails
Originally posted by @surchs in https://github.com/neurobagel/api/pull/154#discussion_r1316470086

Not that related, but similar problem: https://github.com/neurobagel/federation-api/pull/25


Replace download-chromium with puppeteer-core

Still have problems with the Windows installed version. I'm getting errors from download-chromium when it uses ncp. We don't need that package anymore.
Reference: https://github.com/juliangruber/download-chromium/pull/23

@brafdlog It is not including another PR now, you can review.

@brafdlog It is not including another PR now, you can review.

@brafdlog Note I enabled Auto-Merge, I don't know exactly what is the procedure, but it is mean that if you're commenting a suggestion and then approving my PR, it will merge automatically.
This is something to consider. I think in my company we are enabling Auto Merge only on already approved PRs, just for auto merging after the validation checks.

@brafdlog Note I enabled Auto-Merge, I don't know exactly what is the procedure, but it is mean that if you're commenting a suggestion and then approving my PR, it will merge automatically.
This is something to consider. I think in my company we are enabling Auto Merge only on already approved PRs, just for auto merging after the validation checks.

@baruchiro I am used to approving prs with comments if in general I accept the pr except for minor changes. The benefit of this is that it doesn't require another review which can be a redundant blocker.
So we can either stay with auto merge and only approve when all is well or disable auto merge.
I think we should disable auto merge because waiting for another review on minor changes can take a few days if we are busy and I don't think that is worth it. WDYT?

@baruchiro I am used to approving prs with comments if in general I accept the pr except for minor changes. The benefit of this is that it doesn't require another review which can be a redundant blocker.
So we can either stay with auto merge and only approve when all is well or disable auto merge.
I think we should disable auto merge because waiting for another review on minor changes can take a few days if we are busy and I don't think that is worth it. WDYT?

Yeah, sure, I totally agree with you. I just wanted to check this feature :-)

Yeah, sure, I totally agree with you. I just wanted to check this feature :-)