"All Locations" maps do not work, showing Oops error.

When I try to view the All Locations of a Pokemon from the Full Stats page, the heat map show up for a second and then switches to this:

A little backstory...when I first was running the local map using Python (before Pokemon GO Live Map), I had this same issue when running a standard scan. I was able to fix it by editing the map.html file in the Templates folder, removing the "{{ gmaps_key ))" entry and replacing it with my actual API key. I didn't have to do this with Pokemon GO Live Map for it to work, which was nice. When I tried to use the All Locations feature, it would bring up a blank white page. I modified the statistics.html file in the Templates folder (assuming that's what it's calling) the same way at before, replacing "{{ gmaps_key }}" with the actual API key. Once I did this and restarted the program, I tested the All Locations feature and it brought me to my current issue; the map shows for 1 second, than shows the "Oops!" error in the screenshot. Strangely, I reverted the change to the statistics.html file, yet I'm still getting the same error rather than a blank white screen.
Any help is appreciated! :)
Windows 7 x64, Desktop, PTC account.

Is your gmap Javascript API activated ? Check your google console for any error aswell.

same issue. Javascript API is activated. Access through the original pokemon-go-map submodule no problem at all.

Are you using the compiled version ?

Just use the back button. At least, that works for me in Firefox. It's probably ABP or some other plugin blocking the java script popup.

jareem: You were on the money with needing to enable the Javascipt API. After enabling it and restarting the program, I can see the heatmap. Thank you very much!


Disable Global Search for only specific columns

Hi! First of all, thank you so much for this exceptional package!
In a table of my database, I have encrypted columns along with columns in cleartext. I have created custom search filters with the filterColumn() function for encrypted columns, while I use the global search for those in cleartext.
I would need that global search not to be active in encrypted fields, is there a way to do it?
In fact, now I have many false positives in my results, especially for searches of few letters. The filterColumn() function works well, but global search is applied to the other columns. I would like that if I use a filterColumn() function nothing is searched in the other columns.
To better explain what is my problem, here is an example:
Users Table

User 1
Name (not encrypted): Jhon
Tax_Code (encrypted): eyJpdiI6IisxN2FqSnVMWU9WeFUwRVBQejYzMXc9PSIsInZhbHVlIjoiaSt5eGpPeVNWV3VhVHNPWVJJdCtMS1VKdUwzUFVFOEJpczBEdXlvQitVVGY2amErV2MxWCtKRFwvaE1FbjlLTDMiLCJtYWMiOiIyNmIzNjgwMjU4YmQ2NzMzM2JmNjgwYmU3YWI3YjA1M2M0YWNkMDQ5N2U0NzA3ZDMzZjU1MTFlMjhjOTg0MjYyIn0=

User 2
Name (not encrypted): Max
Tax_Code (encrypted): eyJpdiI6IllvYVVcL1dabjJhoEWlwvQUExcnJhc0ZMUT09IiwidmFsdWUiOiJSU1dPeGFodVV5QWJPdFA2d2dIbzNOUTRYSHdPWW1keGRDVHZvWldVUmpwZ2JhTUxZOFZPVWJjV1k0RVdVenArIiwibWFjIjoiMzgwZGU0Yzg5ODEzYjRhMDcyMjQ4NGEyMzgwYjc2ZTNDY0NDFlOGI5MmZkYmU3YzVlZjlmNTU2ZTc0NzQzYyJ9

If I search for the jho value, I would get both users as a result, even if in fact User 2 would not make sense that returns within the results.
Thanks a lot!
System details

SO Apple macOS 10.14.5
PHP 7.2.19
Laravel v5.8.28
Laravel-DataTables v9.4.1

I think you can use blacklist for this. Thanks!


Upgrade Beatport Pro.app to v2.2.3 (Build: 166)

Merged as be19f927125f8200258749abf680acba5c475aa9.


ENH: Store fitted attributes as dpt and return dpt tensors

The compatibility layer for having the sklearn test keep working is still TODO. Let alone that, I think this would be the final state of KMeansEngine.

I wanted to duplicate the KMeansEngine class with KMeansEngineDebug class that would be loaded when engine sklearn_numba_dpex.debug is used rather than bare sklearn_numba_dpex. The difference between debug and vanilla would be that debug engine converts all fitted attributes and all outputs to numpy arrays. The usecase is using it in sklearn unit tests.
But with current plugin design in https://github.com/scikit-learn/scikit-learn/pull/24497 I don't see a way around. One module can only implement one engine.
Maybe there's a workaround consisting in exposing several top level namespaces (e.g sklearn_numba_dpex and sklearn_numba_dpex_debug) in the same package using the packages list in setup.py ?
Or WDYT about changing the plugin spec to enable a different syntax that allow passing dotted string to the config_context ?
E.g rewriting https://github.com/scikit-learn/scikit-learn/pull/24497/files#diff-1d31de81e903bd6529fbe68f8009b7113e3b7de4f1465572ef88af4d03a7dc5bR35 such that entry points whose value prefixes match the user inputed string are selected. (i.e. using prefix selection rather than str.split(".", 1) to detect the name of the engine)

I think  we should allow to programmatically register additional provider names (without in addition the importlib.metadata registry) for testing / debug / benchmarking purposes.

Out of WIP

Comments should be addressed in last commit and suggestions applied.

So in fact make_get_nb_distinct_clusters_kernel does suffer from a race condition, the unittest sometimes output 6, sometimes 7, but it more seems like a bug in numba_dpex atomics rather than our code.

The test was the issue, we have n_clusters = max(labels) + 1 but used n_clusters = max(labels).


bump version for embed

Description
Please provide a clear and concise description of the changes in this PR.
Related Issue
If applicable, link the issue this PR addresses.
Types of Change

[ ] Bug fix
[ ] New feature
[ ] Documentation update

Checklist

[ ] I have read the CONTRIBUTING guidelines.
[ ] My code follows the code style of this project.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] My changes generate no new warnings.
[ ] I have updated the documentation accordingly.

Additional Notes
Add any other context about the PR here.
License
By submitting this PR, I confirm that my contribution is made under the terms of the MIT license.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.21%. Comparing base (98dffca) to head (700bbbe).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

:exclamation:  There is a different number of reports uploaded between BASE (98dffca) and HEAD (700bbbe). Click for more details.
HEAD has 3 uploads less than BASE

Flag
BASE (98dffca)
HEAD (700bbbe)

4
1

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
- Coverage   79.19%   73.21%   -5.98%
==========================================
  Files          42       42
  Lines        3379     3379
==========================================
- Hits         2676     2474     -202
- Misses        703      905     +202

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


What is the size of the model?

hi, @zhujiagang ! Thanks for your excellent work!
I wonder what is the size of the DTPP-RGB & DTPP-Flow models on UCF101 & HMDB51 respectively?

Got it! Thanks a lot.


[GHSA-5824-cm3x-3c38] Vyper has incorrectly allocated named re-entrancy locks

Updates

Affected products
CVSS v3
Severity

Comments
This issue resulted in multiple hack totalling USD 61m loss.
https://cointelegraph.com/news/curve-vyper-exploit-whole-story-so-far

Hi there @charles-cooper! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.
This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

Hey GitHub team, I would like to support the requested change with the following additional resources:

The Vyper post-mortem with all the details: https://hackmd.io/@vyperlang/HJUgNMhs2
The Curve post-mortem with all the details (that's the most affected project): https://hackmd.io/@LlamaRisk/BJzSKHNjn

Having a reentrancy bug in the compiler itself leading to a loss of >50m is definitely a critical bug.

@shelbyc let me try to address your questions:

So the big question: Do the reference links support the idea that only data integrity was affected, or was there a loss of data confidentiality or availability?

A smart contract on Ethereum is a generated bytecode consisting of predefined opcodes. A deployed bytecode can be downloaded by anyone as the Ethereum ledger data is publicly available via so-called network nodes. Thus, I would argue that no data confidentiality itself is affected. However, the affected smart contract bytecodes themselves got bricked by the exploit and a smart contract can be considered as data as well as it holds all of the logic (including the access to the so-called storage trie) and thus the availability got definitely impacted (since you couldn't interact anymore with the affected contracts in a safe way).

Was the money able to be exfiltrated because of threat actors having access to information that should have been confidential, or just because they were able to change the integrity of the data to change who owned the money?

The money got exfiltrated since the compiler code that generates the bytecode had the bug that it forgot to add properly mutex locks even though the high-level language itself specified such a mutex lock. This can be considered a 0-day exploit as until the first exploit, nobody had the information about this critical bug in the compiler code and by exploiting it publicly, other threat actors were able to copycat attack as well.

However, the affected smart contract bytecodes themselves got bricked by the exploit and a smart contract can be considered as data as well as it holds all of the logic (including the access to the so-called storage trie) and thus the availability got definitely impacted (since you couldn't interact anymore with the affected contracts in a safe way).

Knowing there's an availability impact definitely impacts the score. Bricking constitutes a high impact so I think it's appropriate to set the availability value to high.
Additionally, I think there's an argument to be made for scope change based on the bug not just allowing account access but allowing exfiltration of money/data from one account to another. Therefore, I want to correct the CVSS scores to:

CVSS 3.1: https://www.first.org/cvss/calculator/3.1#CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:C/C:N/I:H/A:H
CVSS 4.0: https://www.first.org/cvss/calculator/v4-0#CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:N/VC:N/VI:H/VA:H/SC:N/SI:H/SA:H/E:A

@pcaversaccio do these scores look reasonable to you?

@shelbyc much more reasonable now!

I'm interested in adding CVSS 4.0 to the advisory and the CVE record.

Will this happen soon?

Will this happen soon?
The updated CVE record with the updated CVSS is live now! https://www.cve.org/CVERecord?id=CVE-2023-39363


Some common fixes before adding other plugins

Remove nested ternary plugin folder (was originally thinking of having test files next to source)
Tests now restore original operation after running to avoid polluting other tests (since they modify static values versus instance values)
filterProps test utility now handles bool and null properly

Closing because it's already part of the plugin-system feature branch


Debug adapter crashes when restarting a debugged test

Environment data
VS Code version:  1.19.1
Python Extension version:  0.9.1
Python Version:   3.6.2
OS and version:  Windows 10 1709
Actual behavior
Debug adapter crashes.
Expected  behavior
Test should restart.
Steps to reproduce:

Configure the pytesttest framework
Debug a test of your choice
Click the restart button

Logs
Output from Python output panel
N/A
Output from Console window (Help->Developer Tools menu)
[Extension Host] debugger listening on port 9333
/C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:2569 [Extension Host] debugger inspector at %cDebugger listening on port 9333.
Warning: This is an experimental feature and could change at any time.
To start debugging, open the following URL in Chrome:
    chrome-devtools://devtools/bundled/inspector.html?experiments=true&v8only=true&ws=<IP_ADDRESS>:9333/0448c037-7731-4c33-bb65-85e967f94138

/C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:249 [Extension Host] (node:7660) DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.
t.log @ /C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:249
/C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:249 [Extension Host] ApplicationInsights:Sender Array(1)
t.log @ /C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:249
/C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:249 [Extension Host] activating extension
messageService.ts:126 Debug adapter process has terminated unexpectedly

@ghost
I'm unable to replicate this issue at my end.

Please could you test this once again on the latest version of VS Code and the latest version of the extension
If you are able to replicate this, please could you provide a sample code with instructions.


run-clang-tidy - No such file or directory: '-p=...'

It's probably related to #16
I did exactly the same thing:
CTCACHE_CLANG_TIDY=/usr/bin/clang-tidy-17 CTCACHE_DIR=/tmp/ctcache run-clang-tidy-17 -clang-tidy-binary /usr/local/bin/clang-tidy-cache
I tried with clang-tidy-cache from main and from commit 03644275e794b0587849bfc2ec6123d5ae0bdb1c (Jan 20, 2023). Both have the same problem.
I have:
$ CTCACHE_CLANG_TIDY=/usr/bin/clang-tidy-17 CTCACHE_DIR=/tmp/ctcache time run-clang-tidy-17 -clang-tidy-binary /usr/local/bin/clang-tidy-cache
<class 'FileNotFoundError'>: [Errno 2] No such file or directory: '-p=/home/...'
Unable to run clang-tidy.
Command exited with non-zero status 1
0.09user 0.01system 0:00.11elapsed 99%CPU (0avgtext+0avgdata 16456maxresident)k
0inputs+0outputs (0major+4391minor)pagefaults 0swaps

Hi, I've pushed some new changes, could you re-run it also with CTCACHE_DEBUG=1 and paste the output here?

I have :
Options: ClangTidyCacheOpts(clang_tidy_args:['-p', '/home/...', '', '-list-checks', '-'],compiler_args:[],original_args:['-p=/home/...', '', '-list-checks', '-'])
Traceback (most recent call last):
  File "/usr/local/bin/clang-tidy-cache", line 1163, in <module>
    sys.exit(main())
  File "/usr/local/bin/clang-tidy-cache", line 1151, in main
    return run_clang_tidy_cached(log, opts)
  File "/usr/local/bin/clang-tidy-cache", line 1102, in run_clang_tidy_cached
    proc = subprocess.Popen(
  File "/usr/lib/python3.10/subprocess.py", line 971, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.10/subprocess.py", line 1863, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: '-p=/home/...'
Unable to run clang-tidy.
Command exited with non-zero status 1
0.18user 0.02system 0:00.22elapsed 91%CPU (0avgtext+0avgdata 26648maxresident)k
720inputs+8outputs (1major+5864minor)pagefaults 0swaps

This will take some time. I need to have a look how run-clang-tidy actually invokes clang tidy, because the command-line passed to the cache misses the required first argument.

You'll probably need to pass a script like this to run-clang-tidy instead of giving it the cache client directly

Okay, thanks for your help.
CTCACHE_CLANG_TIDY=/usr/bin/clang-tidy-17 CTCACHE_DIR=/tmp/ctcache run-clang-tidy-17 -clang-tidy-binary /usr/local/bin/clang-tidy works like a charm.
Now I have to chose between you and kokulshan/clang-tidy-cache because both of you works well. 🎲

Isn't the "compile_commands.json" path required?
or
I create a "compile_commands.json" during the cmake_configuration phase. How can I run this ctcache with this method?
Also, I thought it was necessary to set the following variables.
export CTCACHE_LOCAL=1
export CTCACHE_SAVE_OUTPUT=1
My run command:
python3 tools/host/ctcache/clang_tidy_cache.py /usr/bin/run-clang-tidy-11 -clang-tidy-binary /usr/bin/clang-tidy-11 -p <compile_commands.json_path> -quiet

If I don't make any changes it works fine.
Especially when I inject error into a cc file it can't find it.

where am i making a mistake?

Hello again,
I apologize for bothering you once more.
CMD:
python3 tools/host/ctcache/clang_tidy_cache.py /usr/bin/run-clang-tidy-11 -clang-tidy-binary /usr/bin/clang-tidy-11 -p <compile_commands.json_path>

When I run the script, the cache directory under /tmp is created as follows:
ls /tmp/ctcache-user
52/
    stats

However, when I run the script again, clang-tidy still takes the same amount of time. In this case, it seems that the cache is not being utilized.
Before using the script, as I mentioned earlier, when I set the following variables:
export CTCACHE_LOCAL=1
export CTCACHE_SAVE_OUTPUT=1

the second clang-tidy run uses the cache and completes much faster and the cache dir under /tmp is created as follows:
ls /tmp/ctcache-user
52/
   213284d23c794fce9b69d01d8c5ecb9c999dfc  stats

In this case, I am deliberately injecting an error into a file. As a result, it quickly retrieves from the cache and continues on its way. Especially when I inject error into a cc file it can't find it.

Could the reason for this situation be that it cannot detect which file has changed? After all, run-clang-tidy only requires the compile_command.json_path parameter. Who can detect changes to that file? Should I manage this manually?

Thank you very much for your patience.

@matus-chochlik @bansan85

Hi, this looks like a bug, I'll have a look at it, this week.

Thanks a lot..


[Bug] Border height is wrong when using laststatus=0

Context
I'm using winbar to display a discreet status bar atop my various splits, and I like to disable the default status bar altogether for that, using laststatus=0
Bug
The display is kinda wrong when having laststatus set to 0 to hide it in favour of winbar.
The vertical end delimiters are offset compared to the horizontal delimiters on bottom horizontal split.

Minimal reproduction

Paste this into a lua file, e.g. /tmp/repro.lua

---@diagnostic disable: undefined-global
--# selene: allow(mixed_table)
--# selene: allow(unscoped_variables)
--# selene: allow(undefined_variable)

vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

vim.o.laststatus = 0
vim.o.winbar = [[%n%=%f%m%=L%l/%L:%c (%p%%)]]

require("lazy.minit").repro {
  spec = {
    {
      "nvim-zh/colorful-winsep.nvim",
      config = true,
    },
  },
}

Run nvim -u /tmp/repro.lua +split +vsplit

Friend, I believe you should use laststatus=3, instead of 0. I originally created this plugin to implement laststatus=3

Can you tell me why to use laststatus=0?

 The option exists for a reason. I believe you should either mention it in your README that this is not designed for of laststatus=0, or you could just implement a quick check over the value of vim.o.laststatus. 😉
Sorry lots of edits on that one, I'm working on the side. n_n'

Okay, I will fix this issue as soon as possible, so please be patient.

Sweet, thank you very much!

Sweet, thank you very much!

Sorry, it's a bit complicated. If you're in a hurry, you can fix it yourself; the specific location is here: https://github.com/nvim-zh/colorful-winsep.nvim/blob/93a063e25a78c2a50441f3d1ece548465159aa1f/lua/colorful-winsep/view.lua#L50

https://github.com/user-attachments/assets/227cdc55-c744-435e-8890-22a915af5440

2024-07-26_21-25-20.mp4

Please mute before watching; I forgot to mute.

I'll see what I can do if I get the time for it, but no promises. :sweat_smile:
In the meantime, I suppose keeping this issue open could reel in some other potential users that have a fix to propose.
I have to confess, though: I recently found a nice plugin for showing current "context" in code to use in my statusbar and I've enabled laststatus=3. :rofl:

I'll see what I can do if I get the time for it, but no promises. 😅 In the meantime, I suppose keeping this issue open could reel in some other potential users that have a fix to propose.
I have to confess, though: I recently found a nice plugin for showing current "context" in code to use in my statusbar and I've enabled laststatus=3. 🤣

Right choice😂😂😂


allow token parameter from the POST body

I encountered this while trying to patch Forgejo but thought that I should ask here as well about the validity of the proposed fix. It seems to me that the intent of #28390 was to deprecate passing token as a URL parameter, which is a security issue. However, blocking attempts to read from (http.Request).Form means that token cannot be read from the POST body either.
Since OIDC introspection actually mandates reading the token from the POST body, the proposed fix here is to check (http.Request).PostForm first and return successfully on finding the token there. (I'm only checking for token and not for access_token, since I'm not aware of any flows that send access_token in the POST body.)
Thanks for your time.

cc @JackHay22 @kdumontnu ; sorry for the @'s but would you be able to look at this? As I understand it, without this patch, OIDC introspection will break in 1.23 when DISABLE_QUERY_AUTH_TOKEN starts defaulting to true.

I think this needs more discussions about the security. I couldn't find the big difference between GET and POST via API requests.

Thanks @slingamn, this seems like a reasonable addition. Could you verify that the "token" field is not used in any other POSTs for the API as that would otherwise conflict, as well could you add some tests (that don't need to be super involved)? If not, let me know and I can make a complimentary PR.
Could you also send an example use-case so I can also run through some local integration tests myself?

I don't think this is a good idea to accept that for all requests as this should be used for specific use cases in specific endpoints instead

@lunny for the security rationale for the original change, see this comment, which clarifies that the issue is confined to GET and doesn't affect POST: https://github.com/go-gitea/gitea/pull/28390#issuecomment-1846161143

@lafriks I looked into this and you're right. I opened #31632 as an improved (but riskier) version of this change).


Route Parameter Injection via Wildcard in Zend\Mvc\Router\Http\Wildcard

We can easily inject a new controller/action/...  with Wildcard. Do we not have the same problems as described here ? : http://framework.zend.com/security/advisory/ZF2013-01
I think we can add some protected parameters in an array into Wildcards. Thus, a user cannot change the action itself.

This issue has been closed as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html


Diacritical chars in BibTeX b0rk the template

Fix it.

This is an issue incumbent on BibTeX, actually -- identifiers for sources cannot contain diacritically-inflected characters, though the text of the entry may. I would like to enter a comment into the public record, however, that this potentially represents a critical equity issue. If using author names as source identifiers, it stands to reason that identifiers could/should be inclusive.
I am not overlooking the irony that this is also an issue with identifiers in a project which is about identifiers.


Vite 2.7.0-beta.4 regression when building for SSR targeting Cloudflare Workers

Describe the bug
I'm using Vite to build an SSR app targeting Cloudflare Workers.
Below is my config for the build of the server entry:
  publicDir: false,
  build: {
    minify: true,
    outDir: serverOutDir,
    rollupOptions: {
      input: { index: entry },
      output: {
        output: {
          manualChunks: () => "index.js",
          dir: serverOutDir,
        },
      },
    },
  },
  ssr: {
    target: "webworker",
    noExternal: true,
  },

The intention is to output a single file that runs in a CF Worker and this works in Vite 2.6.x up until 2.7.0-beta.4 where it breaks.
In 2.7.0-beta.4 the build completes fine and it still outputs 1 file as it should but at the end of the generated code it includes export default os();.
This will not run in a Cloudflare Worker as the output is expected to be 1 file and it does not support esm, this causes a SyntaxError: Unexpected token 'export' error in the worker.
Reproduction
n/a
System Info
System:
    OS: macOS 11.4
    CPU: (8) arm64 Apple M1
    Memory: 300.30 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.13.0 - ~/.nvm/versions/node/v16.13.0/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 8.1.0 - ~/.nvm/versions/node/v16.13.0/bin/npm
  Browsers:
    Chrome: 96.0.4664.55
    Firefox: 94.0.1
    Safari: 14.1.1
  npmPackages:
    vite: 2.7.0-beta.4 => 2.7.0-beta.4

Used Package Manager
pnpm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

@nrgnrg could you help us by providing a link to a minimal repro? It would make it easier for other collaborators and maintainers to check this issue

hey @patak-js, repro here: https://stackblitz.com/edit/vitejs-vite-zexect?file=vite-plugin.ts
Run npm run build then if you go to dist/server/index.js and scroll right to the end of the file you'll see the issue which is the export default.
If you then delete the dist folder and roll back vite to 2.7.0-beta.3, run another build, export default will not be there and the build will be runnable in a CF worker.

@patak-js I haven't seen this issue before but I think the problem is related to the minification.
If you remove the minify: true, the export default is gone. In fact, it happens also when you remove all the imports from worker.ts, so it's not related to the app. Did anything related to minification change in the beta?
Apart form that, @nrgnrg you'll want to provide rollupOptions.output.format: 'es' to avoid calling require in a worker, but this only works in Vite >= 2.7.0-beta.8

Caused by this line:
https://github.com/vitejs/vite/blob/08a1ec798184a7c8522b63d3795408568162c0e4/packages/vite/src/node/plugins/ssrRequireHook.ts#L58
The reference to module makes esbuild think that the whole chunk is a CommonJS module.
But the output format is esm, so it needs to convert the CommonJS module's module.exports to export default
The CommonJS module's actual exports can only be determined at runtime, so it gets wrapped inside a function call which will return its module.exports at the end, and then esbuild transforms it into an export default the_wrapper_function().

But it's weird, https://github.com/vitejs/vite/pull/5714 should have fixed this.
But the actual behavior looks like that ssrRequireHookPlugin is injected when building the client bundle, and gets reused when building the SSR bundle.
Cc @bluwy @patak-js do you have any idea of what happened here? I'm really confused.

I don't see a cache that could cause issues if the plugin is reused though. Ping @aleclarson, you may have some ideas here

Ah yes #5714 should fix it, only if the build.output is es as suggested by @frandiox. So if we configure that and upgrade to beta.8 the issue should be resolved.
I think the question now is whether we want to skip dedupeRequire in worker builds too? (dedupeRequire uses require() which caused the problem). If so we can apply a similar fix for that as #5714.
I've asked @frandiox about this in discord and confirmed that workers are always written in ESM, so an extra skip check isn't needed. But from the issue, Cloudflare Workers seem to not support ESM?

Workers by default are written in the the service-worker format which is what this build is targeting.
The is now beta support for module syntax but this hasn't been suitable for SSR because the kv-asset-handler doesn't (or didn't) fully support it

Ah yes, I missed the es part.
I think I now understand where this bug is from.
It's more subtle than I expected.
Here, the nested output.output in your configuration:

completely overrides the output config that Vite generates for the project.
It can override the entire config (instead of merging) is because Rollup has this logic https://github.com/rollup/rollup/blob/ca86df280288656c66a948e122c36ccee7e06aca/src/rollup/rollup.ts#L212 that would read output.output instead of output when such field exists.
The override caused the harm because the new config doesn't have a format field, so Rollup uses the default es format. When passing format: 'es' to esbuild for minification, esbuild adds an export default due to the process that I explained in https://github.com/vitejs/vite/issues/5812#issuecomment-983696955
Without the override, Vite uses cjs as the output format for SSR bundles so it works fine.
https://github.com/vitejs/vite/blob/cf03ecf3daf1f00c81de07b2429d38919ec920e7/packages/vite/src/node/build.ts#L483

So the fix in Vite is also quite straightforward: warn or throw here when it detects an output.output field from user configuration:
https://github.com/vitejs/vite/blob/cf03ecf3daf1f00c81de07b2429d38919ec920e7/packages/vite/src/node/build.ts#L480
The API design makes sense in Rollup because it separates rollup.rollup and rollup.generate function, where the latter only needs the output configuration, but the user can also provide the same argument to both functions for convenience.
Vite doesn't need such a design.

I forgot to send my comment before making the PR 😅

Thanks for the explanation @nrgnrg. I think the best way forward now is to check noExternal true instead of webworker, so it's more generalized if one day workers decide to support CJS and require stuff. Will make a PR. (Already made)

Great further investigation @sodatea. Looks like there are two issues here that causes the problem, I agree that having output.output seems to be causing a lot of side effects, I think a warning makes sense to not bring a breaking change.

So the fix is to add format: 'es' to rollupOptions.output in the config? this seems to work for me in the latest beta.
Setting output.output was as far as I'm aware the only way I could make Vite ignore dynamic imports as code splitting points. A worker must be only 1 file but the client build should to be code split so there needs to be a way to force Vite to bundle the worker ignoring dynamic imports, whilst not changing the way it bundles the client code.
If output.output is deprecated, is there a correct way to achieve this?

format: 'cjs' works too.


Don’t run the script multiple times in the same frame

E.g. for the initial frame cq-prolyfill may run 4 times (initial, MutationObserver, domready and load).
These calls should be scheduled and executed by an animation frame callback. This change must not create a FOUC problem.

Implemented in version 0.4.0.
/cc @eeeps


MobSF apk file test

Acceptance criteria

[ ] Do a manual test of MobSF with an .apk file
[ ] document all steps take to run MobSF including installing any dependancies

https://github.com/MobSF/Mobile-Security-Framework-MobSF
Follow up

decide if we want to use this and automate

Static Analysis only App Scan Scorecard
To do the dynamic analysis we need to build it with the Demo profile


Update elam-prerequisites.md

Adding URLs for VIA, MVI, and making the<EMAIL_ADDRESS>address clickable.

@nbassett-MSFT,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Thanks Nick this change will be live soon


[New] specify columns and colors in Scenario.simulate() plot

Summary of this new feature
Add the option in cases simulation method Scenario.simulate() to specify columns (for example [Confirmed, Infected, Fatal, Recovered]) and the desired colors for the respective plot lines. Currently there are only [Infected, Fatal, Recovered] without the Confirmed variable option.

With #527, variables argument and colors argument were added to Scenario.simulate().

With #527, variables argument and colors argument were added to Scenario.simulate().


Section division

https://github.com/Masuduzzaman811/Portfolio/blob/6c72a40365d4f19d7f853adb51dd77efa1c11c8b/index.html#L15

Great job, on section division and commenting.Suggestions to remove any blank line.No need to keep empty lines while you using comments. Without it, the code will look way more clear. Keep up the good work.

Great job, on the layout it looks like the figma one just you can give little bit more border-radius. Keep up good work.👍


Build x64 error

error info：
[17:55:04] Finished compilation with 0 errors after 2490314 ms
[17:55:04] Finished compile-src after 2510786 ms
[17:55:04] Starting compile-build ...
[17:55:04] Finished compile-build after 19 ms
[17:55:04] Starting clean-extensions-build ...
[17:55:04] Finished clean-extensions-build after 8 ms
[17:55:04] Starting bundle-marketplace-extensions-build ...
[17:55:04] [extensions]<EMAIL_ADDRESS>up to date ✔
[17:55:04] Downloading extension from GH<EMAIL_ADDRESS>...
[17:55:04] Downloading extension from GH<EMAIL_ADDRESS>...
[17:55:08] The following tasks did not complete: vscode-win32-x64
[17:55:08] Did you forget to signal async completion?

Please follow the instructions on https://github.com/voideditor/void/blob/main/CONTRIBUTING.md.
I'm not sure what you're trying to edit, but if you're just getting started, we recommend building the extension, not the IDE.

Not the reporter, but I observed this as well trying to build vscode-linux-x64 out of curiosity after building/running the extension (which worked without issue)

Please follow the instructions on https://github.com/voideditor/void/blob/main/CONTRIBUTING.md.
I'm not sure what you're trying to edit, but if you're just getting started, we recommend building the extension, not the IDE.

The extension has been successfully built, but an error occurred when running 'npm run gulp vscode-win32-x64'

I encountered the same issue.

Are you on Windows or Mac?

I build this package on Ubuntu 24.04.1 LTS

Are you on Windows or Mac?

Are you on Windows or Mac?

I build this package on Windows 10 22H2

It looks like we solved this issue in our Discord server.


StaffUser Endpoints completed

Codecov Report
Attention: Patch coverage is 9.80392% with 46 lines in your changes missing coverage. Please review.

Project coverage is 28.44%. Comparing base (2cc66d9) to head (814802e).
Report is 8 commits behind head on develop.

Files
Patch %
Lines

...ance-api/src/compliance_api/services/staff_user.py
0.00%
36 Missing :warning:

...liance-api/src/compliance_api/models/staff_user.py
38.46%
8 Missing :warning:

...nce-api/src/compliance_api/resources/staff_user.py
0.00%
2 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #16      +/-   ##
===========================================
- Coverage    29.56%   28.44%   -1.13%
===========================================
  Files           29       29
  Lines          859      893      +34
===========================================
  Hits           254      254
- Misses         605      639      +34

Flag
Coverage Δ

compliance-api
28.44% <9.80%> (-1.13%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Set the Kafka version in ListAcls method

This PR adds a conditional to set the Kafka version. If the version is at last 2 then it sets request.Version = 1, which enables the functionality of getting the AclResourcePatternType field for the ACLs.

Not sure how to resolve these two errors:

I signed the CLA already (attached a screenshot).
I don't know why tests are failing; running 'go test' locally returns without errors.

Any help would be appreciated :)

Thanks!


Specify format when injecting values

Problem:
The injectStoredValues method is simplistic in that it injects the stored value as is without any context. For the most part this is fine, but sometimes we have a model that has a DateTime which is being displayed by the presentation tier using a different format. For example, the created_at property of a model might include hours, mins and seconds, but the front-end may decide that they only wish to display year, month and day (probably in standard US format). If the stringified date from the store does not match how the front-end is presenting it, then it's not possible to say something like I should see (the created at date of the order).
Fix:
I implemented the ability to specify a format for the injected value. For example I should see (the created date of the order as a US date). I added a few useful formats, and developers can easily add more as needed.

Testing file changes were not found.
Paging @johnnie502 to review the back-end work in this pull request!
Paging @goodevilgenius to review the testing work in this pull request!

@johnnie502 Yes, I will definitely add tests to this. Thanks.


Project owner is displayed twice in project edit form

Problem: Currently the project owner is diplayed twice in the user list of the project editor form. This is because the owner is added to the member list at creation time since the new modification of the project server.
AC:

Every member of the project is displayed only once in the list.

It has been fixed in the #46 pull request


Switch can be clicked by clicking on the whitespace around it

Summary of the bug
Whitespace around the switch triggers the toggle when no right-hand label is present.
🪜 How to reproduce
Go to the Switch example. Click to the right of the switch, on the space next to it, and it should then toggle.
🧐 Expected behaviour
When no right-hand label is present, only clicking the Switch should trigger it.
When a right-hand label is present, then clicking on the switch or the label should trigger it. Similar to checkboxes and radio buttons.
📸 Screenshots or code
If you can, add screenshots to show the problem. If you need to show a code example, you can include a snippet or link to a repository with an example.
🖥 Desktop

OS: [e.g. macOS]
Browser: Firefox
Browser version: [e.g. 22]
Website version: [e.g. V1, V2]
(As displayed on the site top navigation)

📱 Mobile

Device: [e.g. iPhone13]
OS: [e.g. iOS8.1]
Browser: [e.g. chrome, safari]
Browser version: [e.g. 22]
Website version: [e.g. V1, V2]
(As displayed on the site top navigation)

Additional info
Tell us anything else useful to help us fix or understand the problem.

closed as covered by #1645


JBPM-4930 - Add warning to remove tab

Included tests, I18 and removed using well inside popup body

Other than typo, +1 to merge.

@manstis fixed, thanks!

+1 to merge.

master: 4e33bc9f58b3cfaffe65d7bdccfd9f371053c5d2


Cargo expand fails to format code with documentation comments

I encountered a problem with documentation comments in Rust code that cause cargo expand to have unformatted blobs of code in its output.

In the picture above you can clearly see the entirely unformatted section of code next to some properly fomatted sections of code.
The whole things got fixed by manually converting some /// doc comments into normal comments // basically removing them.
I don't yet know whether this also happens with other attributes, however, note that the code does contain other attributes should as #[inline] or certain derives which got expanded properly.
Also note that cargo expand in fact seems to use rustfmt since cargo expand --ugly produces very different output that does not contain these entirely unformatted sections of code. However, code with cargo expand --ugly tends to look more ... ugly in general so it is also not a serious work around for me for now.
You can reproduce the problem with:
const _: () = {
    /// Breaks cargo-expand's formatting
    struct A;
};

This issue seems to be similar to https://github.com/dtolnay/cargo-expand/issues/71.

I would be shocked if this were a cargo-expand issue. Could you report to rustfmt instead, with a minimized repro? Cargo-expand does not control what parts of the file rustfmt would run on.

@dtolnay The following minimal code snippet can be reproduced with cargo-expand tool but not with rustfmt tool.
const _: () = {
    /// Breaks cargo-expand's formatting
    struct A;
};

What do you think this could be the reason for this? I opened an issue for the rustfmt tool and the problem is that this code snippet really only works for reproducability with cargo-expand but not rustfmt.


Sample Data getObservable needs updating

getObservable should become getObservableResult and include the full set of parameters from the earlier refactoring of the ObservableApi

this is totally unnecessary


Update tooltip in NetworkTransform.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Tests/permission cases

Follow https://github.com/vesoft-inc/nebula-common/pull/204

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Building app with electron 15|16 with electron-builder does not finish

Running electron in dev with better-sqlite3 is working like charme.
Even npm rebuild and electron-rebuild is working.
But when i try to package the app:
  • electron-builder  version=22.14.5 os=5.11.0-41-generic
  • electron-rebuild not required if you use electron-builder, please consider to remove excess dependency from devDependencies

To ensure your native dependencies are always matched electron version, simply add script `"postinstall": "electron-builder install-app-deps" to your `package.json`
  • writing effective config  file=package/builder-effective-config.yaml
  • rebuilding native dependencies<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>platform=linux arch=x64
  • install prebuilt binary  name=sharp version=0.29.3 platform=linux arch=x64 napi=
  • install prebuilt binary  name=better-sqlite3 version=7.4.5 platform=linux arch=x64 napi=

It stays in the install prebuilt binary  name=better-sqlite3 version=7.4.5 platform=linux arch=x64 napi= forever.
Any idea?

needed to set npmRebuild: false (default is true) in electron-builder config. but it is strange, because it should work with the default config.
@JoshuaWise i will close the issue, but maybe it is worth it to invastigate. :)


Added Responsive Navbar and corrected some CSS

Feature Implemented: Developed a Navbar using Tailwind CSS.
External Libraries Used: Tailwind along with icons from Ionic Icons.
Script tag was used in the index to implement icons using CDN with no changes being made to the package.json file.
Colours Added:

Default #00df9a
on hover:indigo-400
They can be changed as per the liking of the repo owner.

Further Changes: Moved some properties from the global CSS file to prevent any clashes while making sure their intended purpose is fulfilled.
Screenshots:

Full Website look

Hover Effect on Text

Hover Effect on Button

-Mobile Screen [Responsiveness]

-Mobile Dropdown Format

Further Notes: I have changed the colour of "Search Your Mates" Typewriter Div to match with the Navbar theme. Can change it to something else or revert back to white as deemed suitable by you.

Hi, Am not able to view the details on why the deployment has failed ?
Could you please guide me on what might be causing the build to fail as the site seems working just fine on my local machine?

I fixed it ✌🏻!

Great Job @yashjoshi-dotcom ! Thanks for Contributing 💙

Totally Forgot about the Script Tags.
Anyways Thanks for giving me so much time to work on this issue.As always learnt some cool things along the way.


Translations from Weblate

Translations from Weblate: https://translate.getmonero.org/projects/getmonero/monero-site/
Translations are now locked until this is merged.

Fixed IRC channels in Serbian language
Added new language: Vietnamese
Norwegian is ready to be published
Manually tweaked language files that needed it
Removed unused keys in all language files
Numerous languages were updated

Translators:

French

heriotza
Alex
el00ruobuob

Spanish

nemecis rojas
Adrian Anton
Samuel
José Leonel Subero Gamarra
Luis Alejandro Herrera Bolaños

Vietnamese

Tony Nguyen

Italian

Staff 91
8uDD4T
Gio

Greek

ΚΥΡΙΑΚΟΣ ΚΑΡΑΚΥΡΙΟΣ
Iason Andreou
Donald A. Iljazi

Norwegian Bokmål

Allan Nordhøy
Chris Avis

Russian

Agent LvM
v1docq47

Serbian

luka
bladee
Stevan Nestorovix
xmronadaily
git retard

Japanese

Scott Anecito

German

SJ
Deleted User
Wobole

Unused keys are not regularly removed, there is a weblate plugin which does that, but i have disabled it lately, because a bug caused problems. I have to upgrade Weblate, then i'll reactivate it again. Thanks for pointing them out tho, i'll make sure those will be removed.

Also, a lot of the keys under root['roadmap'] in ar.yml are missing indentation.

The indentation is messed up by Weblate, but since these files shouldn't be touched manually, it's fine like this. I don't want to touch the files and risk conflicts or other problems (like mismatching strings. A problem we already had)

Can't speak on the accuracy of the translations, but everything else seems fine.


Trigger backup for all models doesn't work if --config-file specified

I have the following:
backup perform --trigger db_backup --config-file config.rb
this doesn't trigger backup of other models.
If i remove the --config-file and use the default, it triggers backup for all models

None of the logic should be different when you specify a config file. I tested it just now, it will run for every modal with that trigger name.
Is your config file in the default location? So if you wouldn't specify it, would it load the same file?
What did you configure in your config file?


OIDC does not work with custom CA

Describe the bug
OIDC authentication does not work if idp-issuer-url uses custom CA.
Logs:
Invalid kubeconfig context test-cluster
AggregateError: RequestError: unable to verify the first certificate at ClientRequest.<anonymous> (/Applications/Lens.app/Contents/Resources/app.asar/node_modules/got/index.js:182:22) RequestError: unable to verify the first certificate at ClientRequest.<anonymous>

Kubeconfig:
apiVersion: v1
clusters:
- cluster:
    certificate-authority-data: DATA+OMITTED
    server: https://ucp:6443
  name: test-cluster
contexts:
- context:
    cluster: test-cluster
    user: me
  name: test-cluster
current-context: test-cluster
kind: Config
preferences: {}
users:
- name: me
  user:
    auth-provider:
      config:
        client-id: oidc
        client-secret: REDACTED
        id-token: REDACTED
        idp-issuer-url: https://ucp:32000
        refresh-token: REDACTED
      name: oidc

Additional context
This is probably a bug with ts/js kubernetes client library.

See upstream issue: https://github.com/kubernetes-client/javascript/issues/360

Fixed in 2.4.0.

This is not fixed. I have v2.4.1 and I still see this issue


Variablize GitHub Actions versions

Change description

Variablize GitHub Actions versions
Convert version pinning from SHA to version tags for trusted Actions

Type of change

[ ] Bug fix (fixes an issue)
[x] New feature (adds functionality)

Related issues

#35

Checklists
Development

[x] Lint rules pass locally
[ ] Application changes have been tested thoroughly
[ ] Automated tests covering modified code pass

Security

[x] Security impact of change has been considered
[x] Code follows company security practices and guidelines

Code review

[ ] Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
[x] "Ready for review" label attached and reviewers assigned
[ ] Changes have been reviewed by at least one other contributor
[ ] Pull request linked to task tracker where applicable

I think that this is great, but it will integrate well with renovate? if renovate is capable of checking versions, then I am fine with it!!!

How do we test?


Add the repo to the arrow GitHub topic

Maybe some other topics should be considered as well.
Context:

Eg. spark has these:

I think this is controlled through https://github.com/apache/arrow-datafusion/blob/master/.asf.yaml, perhaps someone can start a PR and others can add more suggestions during code review.


Depreciated MPMoviePlayerViewController

After importing MWPhotoBrowser into my swift project. I'm getting the following warning:
/[....]/Pods/MWPhotoBrowser/Pod/Classes/MWPhotoBrowserPrivate.h:57:5: 'MPMoviePlayerViewController' is deprecated: first deprecated in iOS 9.0 - Use AVPlayerViewController in AVKit.

Would appreciate an update to fix this too :)

Would be nice to get a fix for this as well!

Would be nice to get this solved

I'll take a look as I delve further into a multimedia app. Might need to fork depending on #551

`- (void)_playVideo:(NSURL *)videoURL atPhotoIndex:(NSUInteger)index {
_currentVideoPlayerViewController = [[AVPlayerViewController alloc] init];
_currentVideoPlayerViewController.player = [AVPlayer playerWithURL:videoURL];
[self presentViewController:_currentVideoPlayerViewController animated:YES completion:^{
    [_currentVideoPlayerViewController.player play];
}];
[[NSNotificationCenter defaultCenter] removeObserver:self name:AVPlayerItemDidPlayToEndTimeNotification object:_currentVideoPlayerViewController.player.currentItem];

[[NSNotificationCenter defaultCenter] addObserver:self
                                         selector:@selector(videoFinishedCallback:)
                                             name:AVPlayerItemDidPlayToEndTimeNotification
                                           object:_currentVideoPlayerViewController.player.currentItem];

}

(void)videoFinishedCallback:(NSNotification*)notification {
// Remove observer
[[NSNotificationCenter defaultCenter] removeObserver:self name:AVPlayerItemDidPlayToEndTimeNotification object:_currentVideoPlayerViewController.player.currentItem];
// Clear up
[self clearCurrentVideo];
dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)(1 * NSEC_PER_SEC)), dispatch_get_main_queue(), ^{
[self dismissViewControllerAnimated:YES completion:nil];
});
}

(void)clearCurrentVideo {
[_currentVideoPlayerViewController.player replaceCurrentItemWithPlayerItem:nil];
[_currentVideoLoadingIndicator removeFromSuperview];
_currentVideoPlayerViewController = nil;
_currentVideoLoadingIndicator = nil;
[[self pageDisplayedAtIndex:_currentVideoIndex] playButton].hidden = NO;
_currentVideoIndex = NSUIntegerMax;
}`


The osba not support chinaeast2 region

Based on the osba helm chart values.yaml schema, I could config the azure.environment parameter to AzureChinaCloud, but while creating a service instance for mysql in aks (mooncake), I got the following error message:
Warning  ProvisionCallFailed                  4s (x3 over 3m33s)  service-catalog-controller-manager  Error provisioning ServiceInstance of ClusterServiceClass (K8S: "997b8372-8dac-40ac-ae65-758b4a5075a5" ExternalName: "azure-mysql-5-7") at ClusterServiceBroker "osba": Status: 400; ErrorMessage: ValidationError; Description: The value provided for location is invalid: field value is invalid; ResponseError:
And after searched in this repository with other supported region like 'westus2', I found the following location related files not including 'chinaeast2' region:
https://github.com/Azure/open-service-broker-azure/blob/master/pkg/azure/locations.go
https://github.com/Azure/open-service-broker-azure/blob/master/pkg/schemas/location_schema.go
Do you have plan to support the OSBA in Azure Mooncake regions? Since the AKS is ready GA in mooncake, the stable supported services should be worked in mooncake too.
The values.yaml files for osba and wordpress sample chart as attached.
osba_values.yaml.txt
wp_values.yaml.txt

Resolved by https://github.com/Azure/open-service-broker-azure/pull/706.


remove TMP_DIR_PATH from configuration

Signed-off-by: Rafał Malinowski<EMAIL_ADDRESS>

This setting was removed in recent stellar-core


Should I prefer the onLookupComplete callback over the lookup-complete event?

General information

SDK version: 3.65.0

Issue description
I'm trying to upgrade the SDKs from version 3.50.0 to the latest version 3.65.0, and I am going through the CHANGELOG and the changes of version 3.53.0 are stating that onLookupComplete callback is deprecated in favor of lookup-complete event. So, I guess lookup-complete event is preferred over using onLookupComplete callback, right?
I can also see that if I defined both of the event and the callback, the callback will take precedence, and in the codebase it's mentioned that the callback is preferred over the event
So, what is the best practice here? Should I use the onLookupComplete callback or lookup-complete event?

👋 @M-Sayed thanks for reaching out. Follow the CHANGELOG and use the event-emitter model with lookup-complete. We can clarify that comment you linked so that this is more clear.


File Buffering callback

How do I get a callback or listen to audio file buffering while playing a remote file such that I can customize and show the user a preloader if it's buffering more while playing already

just_audio plugin has two more player states: "connecting" and "buffering". "buffering" state is very valuable. Playback can stop at any moment if a player cannot load the file, but there is no way to alert the user if a player remains in the "playing" state. It is also very useful at the beginning of the playback: "paused -> buffering -> playing" sequence leads to a better UX.

@volgin ,that's another plugin right?

@volgin , Do you think it's better than Audioplayers plugin?

At quick glance, it appears an equivalent of "buffering" implementation in audioplayers compared to just_audio is implementing seekCompleteHandler and indicate buffering is done inside handler? I'm going to try that when I get a chance.

Closing in favor of #361


enh: Update to also pass ClientOptions to credentials args

Additional update to support setting client_options for other SpeechAsyncClient constructors

extends #1089

Update tests install for FAL

cc @theomonnom

@theomonnom could you please also review, approve this update which improves the last change.

sorry for the delays here. we'll get this one in soon


fix(hydration): log hydration error even when using async components

PR for possible fix of this issue: https://github.com/vuejs/core/issues/9369
Having visibility of Hydration errors in production is very important when using large CMS driven Nuxt 3 projects (with async components)

Will this be merged in the next minor? This problem is making it very hard to predict if each deploy we do as a problem or not!

@RodrigoProjects I'm trying to review this change but I'm struggling because of the conflicts. Would you be able to update it to the latest main branch? Thanks.


Re-add support for lone sigs

The Sig struct now has both a #:one and #:lone option, with the #:one taking precedence. Trying to provide both (only possible in core or functional, not surface) will result in an error.
This approach is mildly kludgey (ideally it'd be some sort of multiplicity keyword arg) but potential for interaction seems low.

CI errors are not related to this PR.


Support Android 10 and 11

Fix Android 10 and 11 support

Please check and merge this PR
I test it in android 10 and 11. It work. :)

Hi @hosseiniSeyRo  just now I tested it  on my Redmi K30 pro Android phone, it still shows the error  "no process tap one connect button".


addEventListener / attachEvent event support.

addEventListener / attachEvent event support.

This issue was imported from Google Moderator
Moderator votes: +6
Issue added by horitaku on 2015-01-14
To vote this issue up or down, simply include +1 or -1 in your comment.

Duplicate of #1096


1.19.4

Hey, when are you going to release the mod for version 1.19.4? Since I'm translating your mod and will be checking it for translation in the game, but I'm only checking it on 1.19.4 because it's the current version.

This isn't an issue nor a bug.


Missing Items - Install required roles and features for front-end servers!

If you follow the "Install required roles and features for front-end servers" process and enable the roles using the GUI there are a few components missing. This will cause problems with F5 (and probably other) load balancers identifying the web services are running successfully.
The following components are not in the list:
What if: Performing installation for "[Web Server (IIS)] Directory Browsing".
What if: Performing installation for "[Web Server (IIS)] Request Monitor".
What if: Performing installation for "[Web Server (IIS)] Basic Authentication".
What if: Performing installation for "[Web Server (IIS)] IIS 6 Management Compatibility".
What if: Performing installation for "[Web Server (IIS)] IIS 6 Metabase Compatibility".
What if: Performing installation for "[Background Intelligent Transfer Service (BITS)] Background Intelligent Transfer Service (BITS)".
What if: Performing installation for "[Background Intelligent Transfer Service (BITS)] IIS Server Extension".
What if: Performing installation for "[Web Server (IIS)] HTTP Redirection".
Thanks, Finn.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 926aca42-526a-6a46-c49f-60a83ccb72d8
Version Independent ID: 601bbeaf-7568-ecfe-59ad-4488c270c82f
Content: Install prerequisites for Skype for Business Server 2015
Content Source: Skype/SfbServer/deploy/install/install-prerequisites.md
Service: unspecified
GitHub Login: @kenwith
Microsoft Alias: kenwith

@finnsloss - thank you for reporting this. I wrote this article originally and will check this out ASAP and report back here.

Just to follow up I got some great info from support engineers and they reference me to Installing Prerequisites for Skype for Business Server 2015 and Install Requirements for Skype for Business Server 2015 on Server 2012 R2 so I am going to add this to my backlog to get the referenced article here updated with those other references. Unless you would be interested to help and get the contributor credit? 😀
At any rate I will leave this open until I can get this resolved. Thank you very much @finnsloss for taking the time to report!

On further investigation, I think that "Directory Browsing" was the feature that made the load balancer happy. It was testing that services were up by requesting the root page from each front end. Without Directory Browsing installed the front ends just served an entirely blank page (not even headers), which the load balancer interprets as a fail.
I'm not sure whether the other components that are installed by powershell are required or not?

I've also noticed that your page does include "Directory Browsing" (so apologies for this!). My colleague who configured the prerequisites was following the instructions on the "Plan your deployment > Requirements For Your Environment > Server Requirements" which don't include "Directory Browsing". The other 2 links you mention also don't include the features in their lists.

@finnsloss - ok thanks for this info. I will leave this open and go through and make sure all the areas line up. Thanks for reporting and if you see other areas that need improvement please let us know or submit a Pull Request directly and we will merge it.

I consolidated so that there is only one place where the prerequisites are listed and I added a cross-link. Thank you for finding this and reporting @finnsloss .  Closing this one out.


udp_msgs: 0.0.5-1 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository udp_msgs to 0.0.5-1:

upstream repository: https://github.com/flynneva/udp_msgs.git
release repository: git@github.com:ros2-gbp/udp_msgs-release.git
distro file: noetic/distribution.yaml
bloom version: 0.12.0
previous version for package: 0.0.4-1

udp_msgs
* Clean up CI, remove release helpers
* Contributors: Evan Flynn

Holding for Noetic sync


Add columnOrder support to AttributeGroup and Faceting

These are the summary of changes in this PR:
ReferenceColumn.AggregateGroup.entityCounts:
This function is currently used to return the scalar values and their frequency. I added two parameters to this function.

sortColumns: The columns that should be used for sorting the reference.
hideNumOccurrences: Whether we should add the frequency column or not. Since now this is an option in this function, I removed the entityValues which is the same as passing true for this parameter.

FacetColumn:

sortColumns: This is coming from the sort attribute defined on the facet. This will be used for having custom sort while showing the values of a scalar facet.
hideNumOccurrences: The hide_num_occurrences attribute in facet JSON dictates the value of this attribute.
scalarValuesReference: Currently in chaise we're calling the facetColumn.column.entityCounts. Now that I have added two variables to this function, I felt like it is better if I do this in ermrestjs. This will return an AttributeGroupReference that has the scalar values.

With these changes, the "custom scalar facet sort" has been added to ermrestjs. The next change is to add column_order support to the columns of AttributeGroupReference. What this means to chaise is that if you open the facet modal and sort based on a scalar column, that will honor the column_order and won't necessarily be sorted based on the raw value.
AttributeGroup APIs:

Add context  and sorting APIs to the column object.
Add ermrestSortObject API which will return the sort object that will be used for constructing the url. Modified the ermrestPath to use this API. If there's a column in ermrestSortObject that is missing from the list of columns, we have to add it to the key columns. That's why I'm passing the "term" too (I added a few more comments in the code).

Other changes:

Fixed the "occurrences" typo (it was "occurences").

Issues: #690 #497

@RFSH You can merge this PR. Make sure to merge this before merging the chaise PR.


io_uring based implementation of b3sum

Hi all! I wrote an io_uring-based implementation of b3sum here: https://github.com/1f604/liburing_b3sum
I wrote two versions: a single-threaded version in C and a multi-threaded version in C++. The single-threaded version is around 25% faster than the official Rust b3sum on my system and is slightly faster than cat to /dev/null on my system, and is also slightly faster than fio on my system. The single-threaded version is able to hash a 10GiB file in 2.899s, which works out to around 3533MiB/s, which is roughly the same as the read speed advertised for my NVME drive ("3500MB/s"). The multi-threaded implementation is around 1% slower than my single-threaded implementation.
Benchmarks
For these tests, I used the same 1 GiB (or 10 GiB) input
file and always flushed the page cache before each test, thus ensuring
that the programs are always reading from disk. Each command was run 10
times and I used the "real" result from time to calculate
the statistics. I ran these commands on a Debian 12 system (uname -r
returns "6.1.0-9-amd64") using ext4 without disk encryption and without
LVM.

Command
Min
Median
Max

echo 1 > /proc/sys/vm/drop_caches; sleep 1; time b3sum 1GB.txt --num-threads 1
0.404s
0.4105s
0.416s

echo 1 > /proc/sys/vm/drop_caches; sleep 1; time b3sum 1GB.txt --num-threads 2
0.474s
0.4755s
0.481s

echo 1 > /proc/sys/vm/drop_caches; sleep 1; time b3sum 1GB.txt --num-threads 3
0.44s
0.4415s
0.451s

echo 1 > /proc/sys/vm/drop_caches; sleep 1; time b3sum 1GB.txt --num-threads 4
0.443s
0.4475s
0.452s

echo 1 > /proc/sys/vm/drop_caches; sleep 1; time b3sum 1GB.txt --num-threads 5
0.454s
0.4585s
0.462s

echo 1 > /proc/sys/vm/drop_caches; sleep 1; time b3sum 1GB.txt --num-threads 6
0.456s
0.4605s
0.463s

echo 1 > /proc/sys/vm/drop_caches; sleep 1; time b3sum 1GB.txt --num-threads 7
0.461s
0.4635s
0.468s

echo 1 > /proc/sys/vm/drop_caches; sleep 1; time b3sum 1GB.txt --num-threads 8
0.461s
0.464s
0.47s

echo 1 > /proc/sys/vm/drop_caches; sleep 1; time b3sum 1GB.txt --no-mmap
0.381s
0.386s
0.394s

echo 1 > /proc/sys/vm/drop_caches; sleep 1; time ./b3sum_linux 1GB.txt --no-mmap
0.379s
0.39s
0.404s

echo 1 > /proc/sys/vm/drop_caches; sleep 1; time cat 1GB.txt | ./example
0.364s
0.3745s
0.381s

echo 1 > /proc/sys/vm/drop_caches; sleep 1; time cat 1GB.txt > /dev/null
0.302s
0.302s
0.303s

echo 1 > /proc/sys/vm/drop_caches; sleep 1; time dd if=1GB.txt bs=64K | ./example
0.338s
0.341s
0.348s

echo 1 > /proc/sys/vm/drop_caches; sleep 1; time dd if=1GB.txt bs=64K of=/dev/null
0.303s
0.306s
0.308s

echo 1 > /proc/sys/vm/drop_caches; sleep 1; time dd if=1GB.txt bs=2M | ./example
0.538s
0.5415s
0.544s

echo 1 > /proc/sys/vm/drop_caches; sleep 1; time dd if=1GB.txt bs=2M of=/dev/null
0.302s
0.303s
0.304s

fio --name TEST --eta-newline=5s --filename=temp.file --rw=read --size=2g --io_size=1g --blocksize=512k --ioengine=io_uring --fsync=10000 --iodepth=2 --direct=1 --numjobs=1 --runtime=60 --group_reporting
0.302s
0.3025s
0.303s

echo 1 > /proc/sys/vm/drop_caches; sleep 1; time ./liburing_b3sum_singlethread 1GB.txt 512 2 1 0 2 0 0
0.301s
0.301s
0.302s

echo 1 > /proc/sys/vm/drop_caches; sleep 1; time ./liburing_b3sum_multithread 1GB.txt 512 2 1 0 2 0 0
0.303s
0.304s
0.305s

echo 1 > /proc/sys/vm/drop_caches; sleep 1; time ./liburing_b3sum_singlethread 1GB.txt 128 20 0 0 8 0 0
0.375s
0.378s
0.384s

echo 1 > /proc/sys/vm/drop_caches; sleep 1; time ./liburing_b3sum_multithread 1GB.txt 128 20 0 0 8 0 0
0.304s
0.305s
0.307s

echo 1 > /proc/sys/vm/drop_caches; sleep 1; time xxhsum 1GB.txt
0.318s
0.3205s
0.325s

echo 1 > /proc/sys/vm/drop_caches; sleep 1; time cat 10GB.txt > /dev/null
2.903s
2.904s
2.908s

echo 1 > /proc/sys/vm/drop_caches; sleep 1; time ./liburing_b3sum_singlethread 10GB.txt 512 4 1 0 4 0 0
2.898s
2.899s
2.903s

In the table above, liburing_b3sum_singlethread and liburing_b3sum_multithread are my own io_uring-based implementations of b3sum (more details below), and I verified that my b3sum implementations always produced the same BLAKE3 hash output as the official b3sum implementation. The 1GB.txt file was generated using this command:
dd if=/dev/urandom of=1GB.txt bs=1G count=1

I installed b3sum using this command:
cargo install b3sum
$ b3sum --version b3sum 1.4.1

I downloaded the b3sum_linux program from the BLAKE3 Github Releases page (it was the latest Linux binary):
$ ./b3sum_linux --version b3sum 1.4.1

I compiled the example program from the
example.c file in the BLAKE3 C repository as per the instructions in the
 BLAKE3 C repository:
gcc -O3 -o example example.c blake3.c blake3_dispatch.c blake3_portable.c \ blake3_sse2_x86-64_unix.S blake3_sse41_x86-64_unix.S blake3_avx2_x86-64_unix.S \ blake3_avx512_x86-64_unix.S

I installed xxhsum using this command:
apt install xxhash
$ xxhsum --version
xxhsum 0.8.1 by Yann Collet
compiled as 64-bit x86_64 autoVec little endian with GCC 11.2.0`

Note
Note that, as the table above shows, the single-threaded version needs O_DIRECT in order to be fast (the flag that controls whether or not to use O_DIRECT is the third number after the filename in the command line arguments). The multi-threaded version is fast even without O_DIRECT (as the table shows, the multi-threaded version will hash a 1GiB file in 0.304s with O_DIRECT and 0.305s without O_DIRECT). For more details, see the article.md in the repository, or you can view the same article here (somewhat nicer formatting than Github) or here or here
I should also mention that my implementation does sequential reads from disk and uses the BLAKE3 C library so isn't capable of hashing on multiple cores.
I would very much appreciate any feedback!

FWIW Tokio has an io-uring rust crate, not sure how production-ready it is though: https://github.com/tokio-rs/tokio-uring

I'm out of the country and mostly off the grid until August 20. Apologies for not reviewing this sooner.


🐛 [firebase_auth] Invalid token when added Push notifications capabilities to Xcode project.

Bug report
I've integrated Firebase Phone auth in the Android and iOS application. The Android app is working fine and the OTP are also getting generated but in iOS app, upon requesting OTP for authentication the error [firebase_auth/invalid-app-credential] Invalid token. is received. The OTP SMSs are not being sent.
Strange thing is that if I remove the Push notifications services from the Xcode, then the app is working fine without any errors. The OTP for phone authentication are getting generated and are being sent to the respective numbers.
Steps to reproduce
Setup Auth for phone and then integrate FCM. After adding Push Notification capability in Xcode, the auth function will return invalid app credential - Invalid token.
Also, even though you do not integrate packages for FCM, just add the capability for push notification in Xcode and the auth will be returning invalid token. The sample project doesn't include the FCM packages but the capabilities are added and the bug is recreated.
flutter: [firebase_auth/invalid-app-credential] Invalid token.
await FirebaseAuth.instance.verifyPhoneNumber(
              phoneNumber: "+91${e.mobileNumber}",
              verificationCompleted: (PhoneAuthCredential credential) {
                debugPrint(credential.smsCode);
              },
              verificationFailed: (FirebaseAuthException e) {
                debugPrint(e.toString());
              },
              codeSent: (String verificationId, int? forceResendingToken) {
                debugPrint("${verificationId} && ${forceResendingToken}");
                this.verificationId = verificationId;
              },
              codeAutoRetrievalTimeout: (String verificationId) {
                debugPrint(verificationId);
              },
              timeout: const Duration(seconds: 15),
            );

Sample project
https://github.com/vaibhiarora03/phone_auth_bug

Flutter doctor
Click To Expand
imacs-Mac-mini:ios imac$ flutter doctor -v
[✓] Flutter (Channel stable, 3.3.10, on macOS 12.6.2 21G320 darwin-x64, locale en-US)
    • Flutter version 3.3.10 on channel stable at /Users/imac/flutter_sdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 135454af32 (4 months ago), 2022-12-15 07:36:55 -0800
    • Engine revision 3316dd8728
    • Dart version 2.18.6
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/imac/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13F100
    • CocoaPods version 1.12.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] VS Code (version 1.77.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.60.0

[✓] Connected device (4 available)
    • RMX3231 (mobile) •<PHONE_NUMBER>203DC5                         • android-arm    • Android 11 (API 30)
    • iPhonev (mobile) • 00b8c53c9fec1765bc1277b09b40f299496c7e69 • ios            • iOS 15.4 19E241
    • macOS (desktop)  • macos                                    • darwin-x64     • macOS 12.6.2 21G320 darwin-x64
    • Chrome (web)     • chrome                                   • web-javascript • Google Chrome 111.0.5563.146

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Flutter dependencies
Click To Expand
Dart SDK 2.18.6
Flutter SDK 3.3.10

dependencies:
- bloc 8.1.1 [meta]
- connectivity_plus 3.0.3 [flutter flutter_web_plugins connectivity_plus_platform_interface js meta nm]
- cupertino_icons 1.0.5
- dio 5.0.0 [http_parser path]
- firebase_analytics 10.1.4 [firebase_analytics_platform_interface firebase_analytics_web firebase_core firebase_core_platform_interface flutter]
- firebase_app_check 0.1.2 [firebase_app_check_platform_interface firebase_app_check_web firebase_core firebase_core_platform_interface flutter]
- firebase_auth 4.2.9 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta]
- firebase_core 2.9.0 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_crashlytics 3.0.15 [firebase_core firebase_core_platform_interface firebase_crashlytics_platform_interface flutter stack_trace]
- firebase_messaging 14.2.5 [firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web flutter meta]
- flutter 0.0.0 [characters collection material_color_utilities meta vector_math sky_engine]
- flutter_bloc 8.1.2 [flutter bloc provider]
- flutter_local_notifications 13.0.0 [clock flutter flutter_local_notifications_linux flutter_local_notifications_platform_interface timezone]
- freezed_annotation 2.2.0 [collection json_annotation meta]
- get_it 7.2.0 [async collection]
- hive 2.2.3 [meta crypto]
- hive_flutter 1.1.0 [flutter hive path_provider path]
- image_picker 0.8.7 [flutter image_picker_android image_picker_for_web image_picker_ios image_picker_platform_interface]
- injectable 2.1.0 [get_it]
- intl 0.17.0 [clock path]
- permission_handler 10.2.0 [flutter meta permission_handler_android permission_handler_apple permission_handler_windows permission_handler_platform_interface]
- photo_view 0.14.0 [flutter]
- pinput 2.2.21 [flutter smart_auth]
- shimmer 2.0.0 [flutter]

dev dependencies:
- build_runner 2.3.3 [args async analyzer build build_config build_daemon build_resolvers build_runner_core code_builder collection crypto dart_style frontend_server_client glob graphs http_multi_server io js logging meta mime package_config path pool pub_semver pubspec_parse shelf shelf_web_socket stack_trace stream_transform timing watcher web_socket_channel yaml]
- flutter_lints 2.0.1 [lints]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters collection matcher material_color_utilities meta source_span stream_channel string_scanner term_glyph]
- freezed 2.3.2 [analyzer build build_config collection meta source_gen freezed_annotation json_annotation]
- hive_generator 2.0.0 [build source_gen hive analyzer source_helper]
- injectable_generator 2.1.4 [build source_gen path glob analyzer code_builder dart_style injectable collection recase]

transitive dependencies:
- _fe_analyzer_shared 50.0.0 [meta]
- _flutterfire_internals 1.1.0 [collection firebase_core firebase_core_platform_interface flutter meta]
- analyzer 5.2.0 [_fe_analyzer_shared collection convert crypto glob meta package_config path pub_semver source_span watcher yaml]
- args 2.4.0
- async 2.9.0 [collection meta]
- boolean_selector 2.1.0 [source_span string_scanner]
- build 2.3.1 [analyzer async convert crypto glob logging meta path]
- build_config 1.1.1 [checked_yaml json_annotation path pubspec_parse yaml]
- build_daemon 3.1.0 [built_collection built_value http_multi_server logging path pool shelf shelf_web_socket stream_transform watcher web_socket_channel]
- build_resolvers 2.1.0 [analyzer async build crypto graphs logging path package_config pool pub_semver stream_transform yaml]
- build_runner_core 7.2.7 [async build build_config build_resolvers collection convert crypto glob graphs json_annotation logging meta path package_config pool timing watcher yaml]
- built_collection 5.1.1
- built_value 8.4.3 [built_collection collection fixnum meta]
- characters 1.2.1
- checked_yaml 2.0.2 [json_annotation source_span yaml]
- clock 1.1.1
- code_builder 4.4.0 [built_collection built_value collection matcher meta]
- collection 1.16.0
- connectivity_plus_platform_interface 1.2.4 [flutter meta plugin_platform_interface]
- convert 3.1.1 [typed_data]
- cross_file 0.3.3+4 [js meta]
- crypto 3.0.2 [typed_data]
- dart_style 2.2.4 [analyzer args path pub_semver source_span]
- dbus 0.7.8 [args ffi meta xml]
- fake_async 1.3.1 [clock collection]
- ffi 2.0.1
- file 6.1.4 [meta path]
- firebase_analytics_platform_interface 3.3.21 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface]
- firebase_analytics_web 0.5.1+12 [_flutterfire_internals firebase_analytics_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js]
- firebase_app_check_platform_interface 0.0.6 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface]
- firebase_app_check_web 0.0.8 [_flutterfire_internals firebase_app_check_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js]
- firebase_auth_platform_interface 6.11.11 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
- firebase_auth_web 5.2.8 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser intl js meta]
- firebase_core_platform_interface 4.6.0 [collection flutter flutter_test meta plugin_platform_interface]
- firebase_core_web 2.3.0 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- firebase_crashlytics_platform_interface 3.3.15 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
- firebase_messaging_platform_interface 4.2.14 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface]
- firebase_messaging_web 3.2.15 [_flutterfire_internals firebase_core firebase_core_web firebase_messaging_platform_interface flutter flutter_web_plugins js meta]
- fixnum 1.0.1
- flutter_local_notifications_linux 3.0.0+1 [dbus ffi flutter flutter_local_notifications_platform_interface path xdg_directories]
- flutter_local_notifications_platform_interface 6.0.0 [flutter plugin_platform_interface]
- flutter_plugin_android_lifecycle 2.0.9 [flutter]
- flutter_web_plugins 0.0.0 [flutter js characters collection material_color_utilities meta vector_math]
- frontend_server_client 3.2.0 [async path]
- glob 2.1.1 [async collection file path string_scanner]
- graphs 2.2.0 [collection]
- http 0.13.5 [async http_parser meta path]
- http_multi_server 3.2.1 [async]
- http_parser 4.0.2 [collection source_span string_scanner typed_data]
- image_picker_android 0.8.6+1 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface]
- image_picker_for_web 2.1.12 [flutter flutter_web_plugins image_picker_platform_interface]
- image_picker_ios 0.8.7+1 [flutter image_picker_platform_interface]
- image_picker_platform_interface 2.6.3 [cross_file flutter http plugin_platform_interface]
- io 1.0.4 [meta path string_scanner]
- js 0.6.4
- json_annotation 4.8.0 [meta]
- lints 2.0.1
- logging 1.1.1
- matcher 0.12.12 [stack_trace]
- material_color_utilities 0.1.5
- meta 1.8.0
- mime 1.0.4
- nested 1.0.0 [flutter]
- nm 0.5.0 [dbus]
- package_config 2.1.0 [path]
- path 1.8.2
- path_provider 2.0.13 [flutter path_provider_android path_provider_foundation path_provider_linux path_provider_platform_interface path_provider_windows]
- path_provider_android 2.0.23 [flutter path_provider_platform_interface]
- path_provider_foundation 2.1.2 [flutter path_provider_platform_interface]
- path_provider_linux 2.1.9 [ffi flutter path path_provider_platform_interface xdg_directories]
- path_provider_platform_interface 2.0.6 [flutter platform plugin_platform_interface]
- path_provider_windows 2.1.4 [ffi flutter path path_provider_platform_interface win32]
- permission_handler_android 10.2.0 [flutter permission_handler_platform_interface]
- permission_handler_apple 9.0.7 [flutter permission_handler_platform_interface]
- permission_handler_platform_interface 3.9.0 [flutter meta plugin_platform_interface]
- permission_handler_windows 0.1.2 [flutter permission_handler_platform_interface]
- petitparser 5.1.0 [meta]
- platform 3.1.0
- plugin_platform_interface 2.1.4 [meta]
- pool 1.5.1 [async stack_trace]
- process 4.2.4 [file path platform]
- provider 6.0.5 [collection flutter nested]
- pub_semver 2.1.3 [collection meta]
- pubspec_parse 1.2.1 [checked_yaml collection json_annotation pub_semver yaml]
- recase 4.1.0
- shelf 1.4.0 [async collection http_parser path stack_trace stream_channel]
- shelf_web_socket 1.0.3 [shelf stream_channel web_socket_channel]
- sky_engine 0.0.99
- smart_auth 1.0.8 [flutter flutter_web_plugins]
- source_gen 1.2.7 [analyzer async build dart_style glob path source_span yaml]
- source_helper 1.3.3 [analyzer collection source_gen]
- source_span 1.9.0 [collection path term_glyph]
- stack_trace 1.10.0 [path]
- stream_channel 2.1.0 [async]
- stream_transform 2.1.0
- string_scanner 1.1.1 [source_span]
- term_glyph 1.2.1
- test_api 0.4.12 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher]
- timezone 0.9.1 [path]
- timing 1.0.1 [json_annotation]
- typed_data 1.3.1 [collection]
- vector_math 2.1.2
- watcher 1.0.2 [async path]
- web_socket_channel 2.3.0 [async crypto stream_channel]
- win32 3.1.3 [ffi]
- xdg_directories 0.2.0+3 [meta path process]
- xml 6.1.0 [collection meta petitparser]
- yaml 3.1.1 [collection source_span string_scanner]

I had implemented the wrong APNS certificate in my console which is why I was getting Invalid Token.
After updating it with the correct certificate, the Phone Auth is working and I've been receiving OTP SMSs.


refactor(Observable): Make 'protected' of Observable._isScalar

This property should be accessed only from a derived class. There's no need to make this public.

LGTM

I'm uncertain about this one... only because there are places where we're checking _isScalar on incoming observables (that just happen to be typed as any) at that point.

...meaning, if we ever decided to use proper typing in those points (and I'm not sure why we would, since they're internal to the library and not public APIs), having this as protected would be a problem.
Is there a reason why we want this change?

Is there a reason why we want this change?

Without this change, _isScalar field is visible as public field. I feel a developer will miss-touch this property, so we should hide _isScalar if we available to do it.
(Observable._subscribe has same problem, but we would need to define a new Symbol to hide it...)

@saneyuki it's perfectly acceptable to override Observable.prototype._subscribe if you know what you're doing ;-)

@trxcllnt
Yes, I don't think it's problem to override Observable.prototype._subscribe to create a new operator. I think it would be bad that Observable.prototype._subscribe could be accessed unconditionally from autocomplete or a developer who don't intend to create a new operator.
I feel it is reasonable idea to define a Symbol to access Observable.prototype._subscribe and export it to hook it.
(Umm, should we file a new issue to discuss about Observable.prototype._subscribe?)

@saneyuki .... I think my concern is that we access it "publicly" internally and I don't want to have TypeScript complaining at us or need to have to cast something as any to get things to build. I already feel like I jump through a lot of hoops for TypeScript's sake.

Sorry, @saneyuki, I think for now I'm going to close this PR. While it doesn't break anything, I'm not sure it fixes anything either. A third party may want to create a custom operator that optimizes for scalar observables which means checking _isScalar.
I really appreciate the thought and effort you've put into this. I'm just not sure it's the right move at this point.
... if we end up doing this later, you can totally say "I told you so" :)

A third party may want to create a custom operator that optimizes for scalar observables which means checking _isScalar.

Then, they uses/extends ScalarObservable if they need to check _isScalar?

PromiseObservable can also be _isScalar

@blesh
Ah, my words is too short. My intent of the previous reply is that:
A third party who want to create a custom operator for them can check whether scalar/promise observable by using instanceof checking instead of _isScalar property. Would they really look _isScalar property?
I think basically we should not make public of internal items until if we meet unavoidable to expose them. I'm worrying it would be harder to stop exposed internals in early stage.

Since PromiseObservable can be optimized as "scalar" with _isScalar after it resolves the first time, and since PromiseObservable doesn't extend ScalarObservable, instanceof won't work.
However, maybe we can have PromiseObservable extend ScalarObservable... I don't know, I haven't put much thought into it.

... probably not though.

since PromiseObservable doesn't extend ScalarObservable, instanceof won't work.

This (specialized) pass would work as instanceof checking.
if (observable instanceof ScalarObservable || observable instanceof PromiseObservable) {
   ...
}

...I meant it on my replying.

I'll investigate it. I don't want to make this change right now. Other things would need to change. For example, you can't treat PromiseObservables the same as scalars until they've resolved once... so it would be more like:
if (observable instanceof ScalarObservable || (observable instanceof PromiseObservable && observable.isResolved)) {
  ...
}

I'm unsure if that's going to be more efficient than just checking isScalar.
Also, we'd have to publish ScalarObservable and PromiseObservable with the global package, otherwise people won't be able to test them unless they're using a module system so they can pull those types in.

@blesh
Okay. I accept your decision. Thank you for a long discussion.

<3 @saneyuki


Adopted new Tabs in Workflow History Detail page

Adopted New Tabs UI.
Refactored the code and removed redundant scss and javascript.
Fixes #8562.
After the fix:

@PaarthAgarwal code looks good - have not tested it yet.
Could you update the PR description with a screenshot of before also (we should start doing before/after screenshots - it will help for blog posts but also for any blog you want to do, it also helps to review the PR).
I think we should add, if none exist, a unit test for some of this html (a python test). See if you can find where this view is tested.

Ahh here it is.
https://github.com/wagtail/wagtail/blob/main/wagtail/admin/tests/pages/test_workflow_history.py
Maybe add a new test there that it uses tabs. Doesn't need to test too much just that some of the tabs Dom exists and also that some of the tab contents exist.
The goal here being that a. changed behaviour should be tested and b. avoid regressions (less critical here).

@PaarthAgarwal code looks good - have not tested it yet.
Could you update the PR description with a screenshot of before also (we should start doing before/after screenshots - it will help for blog posts but also for any blog you want to do, it also helps to review the PR).
I think we should add, if none exist, a unit test for some of this html (a python test). See if you can find where this view is tested.

Great idea!

I wonder if the TestingTabbedInterface which we added recently should be sufficient to test this as well?

This code does not use the TabbedInterface approach, instead it just hard-codes the tabs.
You could refactor the python code to use this but that may make this a bit more work and probably best to do in a future PR.

Will aim to review this soon.


Usage of Async suffix in Task returning methods

I'm in the progress of transforming Quartz.NET to .NET 4.5 and async/await era and knowing this same work is in progress here I was looking for patterns that have been used in MassTransit.
One thing that I noticed is that usage of Async suffix seems to vary. Sometimes it's there (RespondAsync as there is also Respond), but mostly not  - regex find "Task\s+(\w+(?<!Async))(". So far I've encountered that it's easy to miss proper await and if method does not have async modifier, silently compiles and calls are not awaited. Using Async suffix for all methods returning Task or Task at least allows some regex magic to be done to ensure that methods are properly awaited.
What are your thoughts, should all Task returning methods have Async suffix in MassTransit too to strongly communicate intent and break existing code so that developer can review and add the required await if *Async method name is seen?

It's interesting to see your perspective, but it seems like a smell to me that lingers of Hungarian notation.
I've disliked the ...Async suffix since it was introduced. It just does not make sense in most cases where there is only a single method that returns a Task (in which most of MT is using).
I'm all for consistency, however, and will take another look to make sure it's consistent.
NOTE that I will not be adding Async anywhere, just possibly removing it

Thank you for your insight, well-argued and makes sense. I'll continue my endeavor with this in mind.
Keep up the great work you are doing with the v3!

In NServiceBus we ditched all the postfixes. Most of the operations we provide are async. Have the postfix is just unnecessary noise


No package found matching

Hi, is the server down?
Get this error:  No package found matching : com.distriqt.Application@latest
I am using 1.4.0 and AIR SDK <IP_ADDRESS>

Yeah, Seems like a github hiccup or something... 🤔  command are not working here neither.
✗ Search complete
error connecting to repository server

Thanks for reporting this, appears the repository server has gone offline.

Our host had changed a configuration on us with a migration last night. Should be running again now.

Thank YOU!


Error creating bean with name 'functionBindingRegistrar' defined in class path resource

Error creating bean with name 'functionBindingRegistrar' defined in class path resource
Caused by: Attempted to reify generic array type, whose generic component type could not be reified to some Class<?>. Handling for this case is not implemented
I have several topologies in my repo, and error I get is not happening consistently, will explain further below. I write here because I found the issue 1044 to be somewhat similar and was resolved. But for me upgrading the library to latest version (3.1.5) didn't help. (Solution to that issue)
The thing is, I got this error for a similar topology, that was using two input topics and an output array of 3 output topics. The error stopped occurring when I changed multiple input bindings from curried functions style to BiFunction style. Then the error was gone.
But I could do it since in that case I had only two inputs. In other topologies I have more, so curried functions are a must.
Additionally what is weird is that when I run the complete repository, multiple topologies, it seems I am not getting this error. It only happens if through Profiles control I enable a single topology that is written using curried functions. For the output, this topology is the same as others, array of three streams. Actually all topologies produce to the same three output topics.
@Bean
public Function<KStream<String, ClassA>,
           Function<KTable<String, ClassB>,
           Function<KTable<String, ClassC>,
           Function<KTable<String, ClassD>,
           KStream<String, String>[]>>>> topology() {

Complete error log is attached.
error.txt

Closing due to inactivity. Please feel free to re-open if you have more context to add or a reproducible sample.


Automated cherry pick of #1641: 统一处理ResourceNotFound返回id not find

Cherry pick of #1641 on release/2.11.0.
#1641: 统一处理ResourceNotFound返回id not find

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11.0@bd20c28). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release/2.11.0   #1642   +/-   ##
================================================
  Coverage                  ?   7.67%
================================================
  Files                     ?     411
  Lines                     ?   63050
  Branches                  ?       0
================================================
  Hits                      ?    4840
  Misses                    ?   57801
  Partials                  ?     409

Flag
Coverage Δ

#aFlag
7.67% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd20c28...0e503dd. Read the comment docs.

/lgtm
/approve


confirmPaymentWithCard please provide setupFutureUsage to save a card during payment

i want to save user card during payment, so i need to provide setupFutureUsage  params to let Stripe supported it

Hey @preflower , isn't the parameter savePaymentMethod of the method confirmPaymentWithCard exactly what you want?

Digged into the Stripe SDK and yes, it is what you want, and it is OffSession by default

Digged into the Stripe SDK and yes, it is what you want, if you set savePaymentMethod to true, it will automatically use OffSession by default

thx for u response;
ok, i will use savePaymentMethod params to save a card during payment, but i'm confused that stripe docs not use savePaymentMethod params to save a card

@preflower I actually found it on the stripe SDK docs, not those you can find on the website.
From what I understood, it does this
https://github.com/stripe/stripe-android/blob/4e9a222fa027910a914ae9d60a58de6cbe227a95/stripe/src/main/java/com/stripe/android/paymentsheet/model/ConfirmParamsFactory.kt (line 25)
So it should work good, and it's working for me. Maybe in the next update I'll change it to a more recognized OffSession like in the website docs.

@preflower if you find it to be wrong, feel free to open an issue and I'll look into it asap since this is a pretty important aspect, thanks


Upgrade to hawkular-parent 24

@jshaughn or @lucasponce  would you please review an eventually merge?


Use a retry counter/limit to fetch thumbnails.

Fixes
Issue Number: https://github.com/lbryio/lbry-desktop/issues/7617

What is the current behavior?
Some channels can trigger many network requests in order to fetch
the channel's thumbnail.
What is the new behavior?
A limit of retries (3 in this case) is set to prevent multiple requests.
If the image couldn't be fetched after those retries, the default picture
will be used instead.
Other information

PR Checklist

Toggle...
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes)
[ ] Documentation changes
[ ] Other - Please describe:

Please check all that apply to this PR using "x":

[x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[ ] I added a line describing my change to CHANGELOG.md
[x] I have checked that this PR does not introduce a breaking change
[ ] This PR introduces breaking changes and I have provided a detailed explanation below

will look at today


C# Adaptive Card namespace is "AdaptiveCards" and not "Microsoft.AdaptiveCards"

Nuget package is called "Microsoft.AdaptiveCards" but the namespace used is just "AdaptiveCards". This is confusing when adding using-statements.

This is fixed in the latest AdaptiveCards package. (NOTE: we renamed the package from Microsoft.AdaptiveCards) and it has a few breaking changes in the names.
Full details here:
https://docs.microsoft.com/en-us/adaptive-cards/create/libraries/net

The samples on the official BotBuilder Sample Github page are outdated:
https://github.com/Microsoft/BotBuilder-Samples/tree/master/CSharp/cards-AdaptiveCards


UI Enhancement for Directions List

Update User Interface for the generated directions to meet to PO's requirements.
Acceptance Criteria:

[x] From the map, when a supported destination (Concordia building) is selected, the user should be able to get the directions list + itinerary lines on the map for said building from their current location. This will come in the form of a drawer that can be pulled up/down from the bottom of the screen, with the map in the background containing the itinerary lines.

closed via PR #99, passed acceptance criteria