Feature/adding bidi module imports

PR Checklist
Please check if your PR fulfills the following requirements:

[✔] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?
Regarding the issue #8229 , these 3 component miss BidiModule.
Issue Number: #8229
What is the new behavior?
cascader and slider and upload now import BidiModule.
Does this PR introduce a breaking change?
[ ] Yes
[✔] No

Other information

For this reason, and I don't think we need to change NgForOf to NgFor, it doesn't do much, and we're going to fully migrate to the new control flow syntax in the near future, when we won't need NgFor any more. i'm about to close this.

For this reason, we don't need the BidiModule anymore :) And I don't think we need to change NgForOf to NgFor, it doesn't do much, and we're going to fully migrate to the new control flow syntax in the near future, when we won't need NgFor any more.
If it's ok with you I'll close this :)

I will close, other point to fully migrate on the new control flow syntax. We have to be sure that we don't support previous version of ng-zorro because, it shoul be complicated to cherry pick in the future if we want to apply a patch on previous version of ng-zorro

For this reason, we don't need the BidiModule anymore :) And I don't think we need to change NgForOf to NgFor, it doesn't do much, and we're going to fully migrate to the new control flow syntax in the near future, when we won't need NgFor any more.
If it's ok with you I'll close this :)

Yeah sure, beside this one there were some changes made to 2 other components, I will revert them if they have not already been merged, if they'd been merged I will make a new pr for them then.

Not needed to change on the other component, NgFor and NgForOf is the same NgFor is just a renamed export so no need to update the previous PR.


Add frr-k8s mode

Another item (that can still be deferred but not forgotten) is that we should update the autosync job to autobump frr-k8s as well.

Another item (that can still be deferred but not forgotten) is that we should update the autosync job to autobump frr-k8s as well.

This should happen for free as we'll update its version if metallb does:
FRRK8S_VERSION=v$(yq e '.dependencies[] | select(.name == "frr-k8s") | .version'  ${METALLB_PATH}/charts/metallb/Chart.yaml)

Another item (that can still be deferred but not forgotten) is that we should update the autosync job to autobump frr-k8s as well.

This should happen for free as we'll update its version if metallb does:
FRRK8S_VERSION=v$(yq e '.dependencies[] | select(.name == "frr-k8s") | .version'  ${METALLB_PATH}/charts/metallb/Chart.yaml)

Ah, right, because metallb drives what version is required.

LGTM

lane flaked, seeing a lot of
failed calling webhook \"frrconfigurationsvalidationwebhook.metallb.io\": failed to call webhook: Post \"https://frr-k8s-webhook-service.metallb-system.svc:443/validate-frrk8s-metallb-io-v1beta1-frrconfiguration?timeout=10s\": tls: failed to verify certificate: x509: certificate signed by unknown authority (possibly because of \"crypto/rsa: verification error\" while trying to verify candidate authority certificate \"cert\")","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/controller/controller.go:227"}

in the speaker's logs. will make sure it works properly on the pr I deploy the webhook upfront


Tag tests to run a filtered subset

RSpec has a --tag command line option that can query or run only tests matching certain criteria (e.g. speed:slow or integration:true).

Duplicates #53

Closed by #64


Show files in the FileSystem Tree View

We are several developers at my company who have been working with both Unity, Cocos Creator and Godot. In Unity and Cocos Creator it's possible to view files in the hierarchy view but in the Godot engine this is not possible. In our opinion it makes it a lot easier to to work in a game editor when you can see all your files in the tree view.
We are currently working on our third game in the Godot engine and we are still not comfortable using the FileSystem view in Godot. This indicates to us that the current way of showing the tree view might not be optimal, at least not for all developers.
Idea for improvement: Make a toggle button for displaying files in the FileSystem view
This issue shows a mockup:
#4570

Yeah, I recommended something similar here (together with a lot of other improvements): https://github.com/godotengine/godot/issues/4570

Yeah I saw it. I also referenced #4570 in my post :)

Oh, right... I should buy some glasses :D

@jesperkondrup I don't think you can view files in the hierarchy view in Unity, the way Godot works is very similar to it (except vertical by default).

Nevermind, you mean the single column mode.

Still reproducible/relevant in 3.1 master 48890b1 : no option for that yet

Still very much relevant in godot 3.1 - the current file system view could definitely use some work.

I agree i just switched from Unity to Godot. For learning purposes I am rewriting one of my projects and going through my assets is really a chore in Godot.

Created a new and more precise issue here #20444


Prefix Composer Dependencies

Summary
Prefixes dependencies to avoid conflicts with the AMP plugin and other plugins using these dependencies.
Relevant Technical Choices

Uses PHP-Scoper to prefix dependencies

Installs it via civicrm/composer-downloads-plugin to work around PHP version mismatch issues
Updates CI config accordingly

Separating autoloaders in third-party and includes makes building the plugin ZIP file much faster
Removes composer validate CI step as it doesn't work with mcaskill/composer-exclude-files

User-facing changes
N/A
Testing Instructions

Check out this branch and run composer install or check out this branch on the QA site
Activate AMP plugin
Visit a single story, edit a story, etc.
Verify there are no PHP errors or notices

Addresses one aspect of #4513

@westonruter @schlessera @spacedmonkey  I feel like this is now ready for initial review, so I'd love to get your feedback. Please note that this PR is based on #4513 and solves the conflict resolving part of that PR.
@felixarntz FYI I added you as a reviewer in case you have some feedback for us on this based on prior art in Site Kit. The Site Kit implementation was certainly a good inspiration, although I went for an easier route heree.


Allow non-ASCII identifiers

Rendered

I doubt that the confusability check can be implemented effectively. There are just too many characters in Unicode that look confusingly similar. Often they are from different scripts like latin a and russian а. One way to limit confusion would be to allow only one script in a identifier as it is done for international URLs.
On the other hand I doubt that homograph attacks will be a problem as you already need to trust the people who write your code.

This renders Rust vulnerable to homograph attacks, which could be used to sneak code past code review.

Are there other languages with permissive Unicode identifiers that we could survey? How prevalent are homograph attacks?
Separately from attack vectors, I like the idea itself though, particularly as a way to improve failure modes.

This RFC is incomplete IMO.
The reference-level section needs a detailed specification of the proposed behaviors. NFC is unambiguous enough but “the current set of allowed characters” means “whatever happened to be implemented unstable in June 2018” and doesn’t cut it. Similarly for confusables. https://unicode.org/reports/tr31/ and https://www.unicode.org/reports/tr39/#Confusable_Detection are relevant, but they each define multiple variations to pick from.
Motivation and alternatives should be discussed at a finer granularity. Why error on non-NFC rather than have the parser do the normalization itself and have the compile compare normalized identifiers in name resolution? Many people are not familiar Unicode normalization, what do we expect them to do with a such compile error? Even for those who are, many text editors do not provide a way any UI for normalization.
Regarding confusables, I agree with @pyfisch that the threat model of homograph attack during code review seems dubious. If however we mean to help people who accidentally type an ident that doesn’t compare equal to what they expect, why not only look for confusables in diagnostics, without changing whether a compiler error happens in the first place?
The same-file boundary seems arbitrary. Calling a method defined in another file happens all the time.
Finally, for this feature in particular I would like to see a lot more research in the prior art section. Different programming languages do slightly different things here (e.g. https://github.com/rust-lang/rust/issues/28979#issuecomment-271125878 and https://github.com/rust-lang/rust/issues/28979#issuecomment-271147393). Before we stabilize this I’d like to find out what those differences are in a wide range of programming languages and why they made those decisions. Some choices might be arbitrary, but others might be guided by reasons that would also apply to Rust. Yes this is a lot of work, and yes I haven’t been doing that work myself either. But I think this is what would produce the best outcome.

@simonsapin Here is the discussion of Idris idris-lang/idris-dev#694 and I must say that I agree with Edwin's sentiments on the subject. Unicode characters out of the ASCII range can be harder to type, and potentially harder to read. For most characters in Unicode, there is a representation using only ASCII characters, (ie. θ => theta).

@repax My proposal is that any attempt at a homograph attack automatically results in an error message.   That is why it requires the compiler to check for confusability.
@pyfisch I believe that a confusability check can be done efficiently.  After normalizing to NFC, replace every character in every identifier by the lowest-valued character it could be confused with.  If any identifiers are the same now that were not the same before, report an error.

@DemiMarie After reading the  Unicode Technical Standard #39 on confusable detection mentioned by @SimonSapin  I agree that there is an efficient algorithm. But I infer from the RFC and your comments that you are either unaware of the algorithm and the associated table or that you want to use a different confusable detection function. Either way I do agree with @SimonSapin that the RFC is incomplete and

The reference-level section needs a detailed specification of the proposed behaviors.

If a table based solution like the one from Unicode Technical Standard #39 is used detected confusables should not be a hard error but a warning as the confusion tables are expected to improve and erroring on additional characters may break existing programs.

Didn't we address this in #1565 ?  ;)
In all seriousness, I do believe homograph attack against code review sounds plausible, so ideally anything like this should live behind a feature gate, even after stabilization.
There is no defense in restricting the script per identifier like @pyfisch mentioned.  Also, you cannot do the confusability checks at the file level because this breaks using std.  I think the feature gate itself could enable specifics scripts though
#[allow_unicode_script(...)]

Also, error messages should say exactly what script to enable, making this painless.  We could do crate level confusability checks based on the scripts enabled.
We should likely allow use some_crate::foreign_ident as local_ident with foreign_ident outside the allowed scripts, but local_ident must be allowed of course.

I'm a german and even German script, even though it uses the latin alphabet, has characters that are not in ascii (äöüß). Most languages that use the latin alphabet have. And of course, there are so many other languages that don't use the latin alphabet.  So generally I'm in favour of RFC.
Note that even though I agree there should be an option, I don't think it is a good idea for the code I am writing. As a german, I could make e.g. the comments in my public codebases in german. Like so many other english non-native open source developers, I chose to make them in english instead. This is highly useful because the number of german speakers is so much smaller than the number of english speakers. I can accept PRs from people in france, the USA, etc. They all understand what my code is doing, I understand what their code is doing.
From a beauty aspect, I prefer consistent codebases. Most if not all of the crates, all of std, all the keywords, all of the rustc error messages are in english. Starting to use german would create a half english half german codebase which is something I don't find appealing. My personal view at least. Even if you have translated error messages, this causes googleability to suffer dramatically.
Another advantage of keeping non ascii identifiers outside of codebases is that everyone with an ascii capable keyboard can easily edit stuff. Greek letters look nice but they are hard to edit. Imagine someone non technical (and non greek) doing their first steps in programming and they see µ and wonder how to type that weird u thing.
So I agree with @Serentty that the main use case of this proposal should be internationalisation. This is a great goal. Rust should be international and there are programming communities which use different languages as lingua franca than english.
Currently, the RFC intends to simply turn off the ascii ident check, without any opt-in or something else. Basically, you can accidentially start using ascii identifiers even though you might want to keep your codebase ascii only. I agree with @burdges that this should be different.
I would love the default to be to allow ascii only idents only and error on non ascii idents using a default-error lint. Anyone who works on non-english codebases then can turn off that lint.
The idea of making the lint customizeable using scripts is really awesome. It would mean that the lint is still useful, even for those who use a native script. Generally if you code on a codebase that uses german idents, you don't want e.g. russian/bulgarian script or idk runes or something.

Unicode Technical Report #31 is also worth a read. It has a list of suggested scripts to allow and disallow, which I think we should consider, and not just allow all Unicode Characters like some other languages do. This could be set up in a way like lint levels, and set up specific lints for the different character sets with different warnings by default.

Allow
Warn
Deny

I would be unhappy if this was added for a few reasons:

(I'm obviously biased on this point) I think it would be good to nudge the use of English identifiers. This will, I think, preserve the usability of libraries by the whole ecosystem. For example, I personally am extremely unlikely to use a library is there docs are in another language. Does anyone know if this has been a problem in other languages like Swift or Julia?

Non-ascii idents are a pain to type. I spent a lot of time the last few months writing Julia, where this seems to be more common practice. Typing these idents significantly reduces ergonmics, and I usually end up doing some sort of error-prone copy/pasting. This is even worse if you use a terminal-based editor.

Not all terminals/fonts display all Unicode chars correctly. This means that people like me who use vim (or... emacs) might have added pain. Moreover any compiler errors that contain special characters might look weird.

It might be possible to do weird things with hidden characters. That could be a security problem. Is this covered by the confusability check proposed?

I agree with @SimonSapin agreeing with @pyfisch that the risk of homograph attacks / risks to security is dubious. It seems to me that there are far more risky things security wise than unicode idents.
During my first year as a computer science student, we had two professors who insisted on talking about CS terms using their Swedish names and used Swedish in comments and variable names. Most students, as far as I recall, really disliked the experience, because they were not learning the international terms then, so they had to re-learn the terms in English. These students, among them myself, were not native English speakers, however, knowledge of English is expected in Swedish society. Therefore, I would not use Swedish in any code nor accept it in my projects.
That said, it seems important to me to support the internationalization of Rust because English is far from a lingua franca across the world. So I support the principle of non-ASCII idents.
To satisfy both those who want to avoid ASCII idents in their code and those who want to use it, I propose two lints:
non_ascii_ident       // allow by default
pub_non_ascii_ident   // deny by default

The first allows you to use non-ASCII idents in non-exported code.
The second allows you to use them in public code.

Another concern is what happens when we update the compiler’s Unicode version. I think we don’t want to get stuck on an old version forever, but we also don’t want to start emitting errors for programs that used to compile correctly with a previous rustc. This requires some careful tweaks to the algorithm, see for example https://unicode.org/reports/tr15/#Stabilized_Strings.

One more concern: FFI. What happens if I no_mangle an ident with a funny character? I'm guessing this should be disallowed?

For the upgrading tables question: this seems like something that could be done on epoch boundaries.  Always warn using the latest tables, and error using the latest table when the epoch locked.
(I'm not sure that's better than a deny-by-default lint that always uses the latest tables, though, which I think would be allowed under the stability guarantee.)

Maybe it would make sense to require or encourage ascii aliases for non-ascii identifiers?
This could solve many problems:

Latin-only keyboard? just input the ascii version and let RLS suggest the unicode version
Error messages could either refer to the unicode or the ascii version
code-bases could elect whether they want to consume an API in the unicode or the ascii version
FFI could always use the ascii alias

Closing in favor of #2457, which is vastly better written.


No documentation on testRunSettings

Issue Description
I am trying to configure the runtime context when clicking on "Run Test" code lense. Really I am just trying to make sure an ENV variable is set. I couldn't find any definitive documentation on it so I went digging through the code. I found this line which pulls testRunSettings configuration but I can't find any record of how it is used. A search on GitHub only shows a couple of hits. The values e.g. ./insideDocker.runSettings & Pqsql.runsettings look like they could be files but I don't see them in those repos.
Is testRunSettings something we can use?  Any info is appreciated!
Steps to Reproduce
Google search for testRunSettings and nada.
Expected Behavior
Some explanation on how to configure the context Run Test is executed in exists.
Actual Behavior
Logs
OmniSharp log
Post the output from Output-->OmniSharp log here
C# log
Post the output from Output-->C# here
Environment information
VSCode version: 1.57.1
C# Extension: 1.23.13
Mono Information
        OmniSharp using built-in mono
Dotnet Information
.NET SDK (reflecting any global.json):
 Version:   5.0.102
 Commit:    71365b4d42
Runtime Environment:
OS Name:     ubuntu
OS Version:  18.04
OS Platform: Linux
RID:         ubuntu.18.04-x64
Base Path:   /usr/share/dotnet/sdk/5.0.102/
Host (useful for support):
Version: 5.0.2
Commit:  cb5f173b96
.NET SDKs installed:
3.1.405 [/usr/share/dotnet/sdk]
5.0.102 [/usr/share/dotnet/sdk]
.NET runtimes installed:
Microsoft.AspNetCore.App 3.1.11 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 5.0.2 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 3.1.11 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 5.0.2 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
To install additional .NET runtimes or SDKs:
https://aka.ms/dotnet-download

Visual Studio Code Extensions

Extension
Author
Version

change-case
wmaurer
1.0.0

code-spell-checker
streetsidesoftware
1.10.2

csharp
ms-dotnettools
1.23.13

csharp2ts
rafaelsalguero
0.0.26

csharpextensions
jchannon
1.3.1

docomment
k--kato
0.1.20

fix-json
oliversturm
0.1.2

gitlab-workflow
GitLab
3.26.0

gitlens
eamodio
11.6.0

html-slim-scss-css-class-completion
gencer
1.7.8

jupyter
ms-toolsai
2021.6.999662501

markdown-mermaid
bierner
1.10.0

ng-template
Angular
12.1.2

nodejs-extension-pack
waderyan
0.1.9

npm-intellisense
christian-kohler
1.3.1

path-intellisense
christian-kohler
2.3.0

pdf
tomoki1207
1.1.0

prettier-vscode
esbenp
8.0.1

python
ms-python
2021.6.944021595

search-editor-apply-changes
jakearl
0.1.1

search-node-modules
jasonnutter
1.3.0

shell-launcher
Tyriar
0.4.1

typescript-hero
rbbit
3.0.0

vscode-docker
ms-azuretools
1.14.0

vscode-eslint
dbaeumer
2.1.23

vscode-extension-auto-import
NuclleaR
1.4.3

vscode-markdownlint
DavidAnson
0.42.1

vscode-mermaid-preview
vstirbu
1.6.2

vscode-npm-script
eg2
0.3.22

vscode-nuget-package-manager
jmrog
1.1.6

vscode-pylance
ms-python
2021.7.4

vscode-typescript-tslint-plugin
ms-vscode
1.3.3

@jrmeland I think this should help you out: Configure unit tests by using a .runsettings file. It's written for Visual Studio, but it uses .runsettings file which I expect this extension handles the file in the same way.
There's a section that covers setting environment variables:
<?xml version="1.0" encoding="utf-8"?>
<!-- File name extension must be .runsettings -->
<RunSettings>
  <RunConfiguration>
    <EnvironmentVariables>
      <!-- List of environment variables we want to set-->
      <DOTNET_ROOT>C:\ProgramFiles\dotnet</DOTNET_ROOT>
      <SDK_PATH>C:\Codebase\Sdk</SDK_PATH>
    </EnvironmentVariables>
  </RunConfiguration>
</RunSettings>

Even if this gives you the information you need, I think it would still be useful for the readme in this repo to point to some docs around how to configure, even if it's just linking to this same page.

closing as answered.


Version 3.2.3

Fixing pickling with default box (thanks to sdementen)

Hello @cdgriffith! Thanks for submitting the PR.

There are no PEP8 issues in the file box.py !

There are no PEP8 issues in the file test/test_functional_box.py !

Coverage increased (+0.7%) to 99.836% when pulling cb03728b5d390d5f52b33506e88f08995a1571c7 on development into f3ec16ea8698ae212c2af8999d80a9e65e297764 on master.


feat: getBottomNavigationBarHeight()

Description
Added getBottomNavigationBarHeight() that allows ...
Compatibility

OS
Implemented

iOS
✅

Android
✅

Windows
❌

Checklist

[x] I have tested this on a device/simulator for each compatible OS
[x] I added the documentation in README.md
[ ] I mentioned this change in CHANGELOG.md
[x] I updated the typings files (privateTypes.ts, types.ts)
[ ] I added a sample use of the API (example/App.js)

Hey @Rapsssito 👋 - thanks for this!
I'm not against it in principle, I can see how it would be fundamental to layouts. However, what I wonder is if it might be better suited for https://github.com/th3rdwave/react-native-safe-area-context - I'm trying to steer all the layout-related things that are questions of where you can draw etc over there, as I feel like it is more focused and does a better job in general already.
What do you think?

@mikehardy you are probably right. I spent a lot of time looking for the repository that could best adapt this method. I didn't know about https://github.com/th3rdwave/react-native-safe-area-context. I will move my PR there.

@Rapsssito no worries - not many people know about that one yet as it is fairly new, but it appears to be high quality and I've chatted with the author before, this API should find a good home there based on the insets they make available I think


Gridsearcher issue 2

Issue #, if available: #378
Description of changes:
Added support for continuous hyperparameters to Gridsearch, added a unit test for it as well
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hi Mina, usually the first step with a PR is to make sure the CI system goes through. We have some code quality checks (flake), and also all the unit tests must pass. We typically do not look at the PR before this is all done.

Hi Matthias,
This time it passed all code quality checks and CI tests.

You need to make sure to have 'dev' dependencies installed in your venv. With 'extra', you are fine.
You also need to be careful. The black formatter is run when you do "git commit", but when it does changes, you have to do "git commit --amend" once more, and "git push" only afterwards.

@mina-ghashami I think you did not rebase to most recent main when pushing this:
git checkout main
git pull
git checkout gridsearcher_issue_2
git rebase main

So do I have to run "git commit --amend" every time before "git push" ? or otherwise black wont reformat my code?

if you run git commit, it will run black which may change your code. these changes are not committed. therefore, you need to add these changes. you are free to create two commits. then the first will be your changes and the other one will be black formatting. with --amend you just make sure that you only have one commit.
there are other ways to run black. you can do it manually or let your ide do it whenever you make a change: https://black.readthedocs.io/en/stable/integrations/editors.html

@wistuba Do you know how to run this lint checks locally? Or "flake"?

You can add them as part of your IDE. flake you can run the same way you run black, i.e. pip install and flake8 my_folder/file (https://flake8.pycqa.org/en/latest/). setup lint for your IDE: https://pylint.pycqa.org/en/latest/user_guide/installation/index.html


[4.2][AST] Disable comment printing while emitting diagnostics

There is a problem in PCH builds where source manager might
end up having unorderable source locations for comments, to work
around this (which is going to be fixed separately) let's
disable comment printing while emitting diagnostics since
such comments are not required.
Resolves: rdar://problem/38203776
(cherry picked from commit 28d9d8e77188033f896b1e69e5ae7e74e2b4cf20)

@swift-ci please smoke test and merge

Merge CI job failed with
22:45:14 ERROR: Step ‘Github Pull Request Merger’ aborted due to exception:
22:45:14 java.io.IOException: Server returned HTTP response code: 405 for URL: https://api.github.com/repos/apple/swift/pulls/15037/merge

@swift-ci please smoke test

@swift-ci please test


Multiple field mappings like copyField rules in Solr?

Is it possible to add custom field (collection type) and set up multiple mappings to copy values from some other fields, like they did in Solr Schema API?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1be935e6-88cc-38b8-aab4-bd43fd32ed4d
Version Independent ID: 3c900aa3-ebc8-17bc-cfa2-3e3a6e7400e9
Content: Field mappings for automated indexing using indexers - Azure Search
Content Source: articles/search/search-indexer-field-mappings.md
Service: search
GitHub Login: @mgottein
Microsoft Alias: magottei

Hi @egorantonov, Thanks for the question! We are currently investigating and will update you shortly.

Hi @egorantonov, have you tried Cognitive Search? It's a new capability on Azure Search?
"Cognitive Search allows you to apply enrichment and transformation steps to your data that we call Cognitive Skills. You can select from predefined skills or apply your own custom skill. The best way to transform your input data when you want to define your own function would be through a custom skill that you run as part of your enrichment pipeline."
You can learn more about it here.

We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Add a Compatibility Decomposition Normalizer, remove Latin normalizer

Pull Request
Related issue
Fixes #139
What does this PR do?

Add a new CompatibilityDecompositionNormalizer as outlined in #139
Fix the tests that fail as a result: The NonSpacingMark normalizer is removing diacritic in normal form for Hebrew, Thai, and Arabic, some tests that weren't in normal form were updated
Remove the Latin Normalizer, whose functionality is subsumed by CompatibilityDecompositionNormalizer and NonSpacingMark (modified NonSpacingMark to also act on Latin script).

As a consequence, the ° symbol is no longer normalized to deg

Benchmarks
The addition of the new normalizer regresses quite a bit the performance of some benchmarks. Find below the list of benchmarks that regressed (benchmarks absent from the list are within noise)

```
tokenize/132/Cj/Cmn     time:   [12.339 µs 12.351 µs 12.364 µs]
                        change: [+16.916% +17.213% +17.511%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 5 outliers among 100 measurements (5.00%)
  1 (1.00%) high mild
  4 (4.00%) high severe
tokenize/132/Cj/Jpn     time:   [16.894 µs 16.944 µs 16.994 µs]
                        change: [+12.490% +12.784% +13.100%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 4 outliers among 100 measurements (4.00%)
  4 (4.00%) high mild
tokenize/132/Latin/Eng  time:   [9.5162 µs 9.5278 µs 9.5467 µs]
                        change: [+5.4948% +5.8021% +6.1184%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 8 outliers among 100 measurements (8.00%)
  2 (2.00%) high mild
  6 (6.00%) high severe
tokenize/132/Latin/Fra  time:   [10.378 µs 10.384 µs 10.392 µs]
                        change: [+19.573% +19.903% +20.251%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 4 outliers among 100 measurements (4.00%)
  4 (4.00%) high mild
tokenize/132/Hebrew/Heb time:   [7.7406 µs 7.7451 µs 7.7499 µs]
                        change: [+34.776% +35.216% +35.629%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 6 outliers among 100 measurements (6.00%)
  1 (1.00%) high mild
  5 (5.00%) high severe
tokenize/132/Thai/Tha   time:   [6.6110 µs 6.6156 µs 6.6208 µs]
                        change: [+26.463% +26.712% +26.978%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 6 outliers among 100 measurements (6.00%)
  3 (3.00%) high mild
  3 (3.00%) high severe
tokenize/132/Hangul/Kor time:   [39.129 µs 39.148 µs 39.171 µs]
                        change: [+16.338% +16.790% +17.207%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 12 outliers among 100 measurements (12.00%)
  4 (4.00%) high mild
  8 (8.00%) high severe
tokenize/363/Cj/Cmn     time:   [35.550 µs 35.587 µs 35.633 µs]
                        change: [+11.385% +11.798% +12.190%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 8 outliers among 100 measurements (8.00%)
  8 (8.00%) high severe
tokenize/364/Cj/Jpn     time:   [47.191 µs 47.253 µs 47.355 µs]
                        change: [+9.3743% +9.7798% +10.183%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 8 outliers among 100 measurements (8.00%)
  2 (2.00%) high mild
  6 (6.00%) high severe
tokenize/363/Latin/Eng  time:   [22.825 µs 22.832 µs 22.839 µs]
                        change: [+3.3755% +3.6749% +3.9908%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 11 outliers among 100 measurements (11.00%)
  3 (3.00%) high mild
  8 (8.00%) high severe
tokenize/363/Latin/Fra  time:   [25.703 µs 25.713 µs 25.726 µs]
                        change: [+13.904% +14.173% +14.433%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 8 outliers among 100 measurements (8.00%)
  1 (1.00%) high mild
  7 (7.00%) high severe
tokenize/365/Hebrew/Heb time:   [20.877 µs 20.893 µs 20.913 µs]
                        change: [+32.778% +33.225% +33.643%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 13 outliers among 100 measurements (13.00%)
  4 (4.00%) high mild
  9 (9.00%) high severe
tokenize/366/Thai/Tha   time:   [16.305 µs 16.316 µs 16.327 µs]
                        change: [+30.491% +30.876% +31.285%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 6 outliers among 100 measurements (6.00%)
  5 (5.00%) high mild
  1 (1.00%) high severe
tokenize/364/Hangul/Kor time:   [96.987 µs 97.247 µs 97.513 µs]
                        change: [+19.101% +19.751% +20.447%] (p = 0.00 < 0.05)
                        Performance has regressed.
Found 4 outliers among 100 measurements (4.00%)
  2 (2.00%) high mild
  2 (2.00%) high severe
```

PR checklist
Please check if your PR fulfills the following requirements:

[x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Remove the Latin Normalizer, whose functionality is subsumed by CompatibilityDecompositionNormalizer and NonSpacingMark (modified NonSpacingMark to also act on Latin script).

As a consequence, the ° symbol is no longer normalized to deg

Updated the benchmarks after removing the Latin normalizer. Not much change, but slight improvements in the segmenter benchmarks (not sure if it is related)


Automated release process

Similarly to https://github.com/standard/eslint-config-standard-with-typescript/issues/840.
We could introduce an automated release process where each commit on master get evaluated following Conventional Commits.
We can use semantic-release for that purpose, it also automatically generates the changelog and publish the new version on npm.

Unlikely to be done.


Spoilers integration

Integrate new spoiler API response fields. Added spoilersEnabled to the subreddit settings, as well as the spoiler attribute on posts. Lastly added the spoiler thumbnail to the list of ignored thumbnails.
This work is in support of: reddit/reddit-mobile#950
👓 @schwers @scarow

🐟 lgtm


Adding User, UserPersonalDetails, Address

Hi Jav,
Please can you check whether these look OK given the scaffolding work you've done?
Thanks

Yes, bool?


Change "ES7" to something more appropraite

To my knowledge TC39 has moved to a train model for spec releases. As part of this change they've switched from the ES# naming scheme to ESYYYY where YYYY is the release year. As such, ES6 became ES2015 and ES7 became ES2016.
The title of the readme should be changed to better match the TC's current naming conventions. I propose that "ES2016 Proposal" be replaced with either "ES2016 Proposal" or "ECMAScript Proposal". I've also seen some members of the community propose that "ES.next" would refer to the next release of the spec or "ES.future" to refer to features that haven't yet been added to release train.

What you say is correct. However, the community at large knows "ES2015" as "ES6". It's an issue of marketing, really.

I'm not sure how long this naming convention will hold up anyways.  We're nearly in 2016 and we're still doing proposals for ES2016...  ES7 looks more nice and is more familiar IMO anyways, I think the community will stick to that convention.

Agreed with @jamen .  I can understand if TC wants to keep a Mozilla-esque release cycle to avoid dragging things out for as long as ES6 took, but really, does it have to reflect in the name?
Even if the TC continues with this silly game, I predict developers will continue calling successive versions "ES7", "ES8", "ES9" anyway. If not for the sake of familiarity, then certainly for the sake of brevity: who in their right mind is going to prefer saying "It's written in ES twenty-fifteen" instead of "It's written in ES6"?
Reality check, everybody. Please.

How do people feel about "ESNext"?

I like "ESNext" to refer to future proposals, since predicting the actual landing version / year can be a little bit unpredictable (The feature set of ES2016 is already decided and includes basically none of the really exciting features that I at least was hoping for).
Obligatory opinion dump: I like the idea of ES2016 and beyond, but it was a mistake to rename ES6 just before it launched. Now I have to choose between sounding like I'm up to date on the latest developments (which I am, so I have to say "ES2015") and wanting anybody to know what I'm talking about (which I do, so I have to say "ES6"). Usually I have to say both ("ES2015 or ES6") which is the worst possible situation...

Everyone cool with #41 ?


Warnings in verbose mode

Input
ruby --verbose -e 'require "sorbet-runtime"'

Observed output
/path/to/sorbet-runtime-0.5.6145/lib/types/types/simple.rb:44: warning: instance variable @__as_sorbet_simple_type not initialized
/path/to/sorbet-runtime-0.5.6145/lib/types/types/simple.rb:44: warning: instance variable @__as_sorbet_simple_type not initialized
/path/to/sorbet-runtime-0.5.6145/lib/types/types/simple.rb:44: warning: instance variable @__as_sorbet_simple_type not initialized
/path/to/sorbet-runtime-0.5.6145/lib/types/types/simple.rb:44: warning: instance variable @__as_sorbet_simple_type not initialized
/path/to/sorbet-runtime-0.5.6145/lib/types/types/simple.rb:44: warning: instance variable @__as_sorbet_simple_type not initialized
/path/to/sorbet-runtime-0.5.6145/lib/types/private/abstract/data.rb:15: warning: instance variable @opus_abstract__abstract_type not initialized
/path/to/sorbet-runtime-0.5.6145/lib/types/props/private/apply_default.rb:17: warning: method redefined; discarding old initialize
/path/to/sorbet-runtime-0.5.6145/lib/types/private/abstract/declare.rb:37: warning: previous definition of initialize was here
/path/to/sorbet-runtime-0.5.6145/lib/types/types/simple.rb:44: warning: instance variable @__as_sorbet_simple_type not initialized
/path/to/sorbet-runtime-0.5.6145/lib/types/private/abstract/data.rb:15: warning: instance variable @opus_abstract__abstract_type not initialized
/path/to/sorbet-runtime-0.5.6145/lib/types/props/private/apply_default.rb:71: warning: method redefined; discarding old initialize
/path/to/sorbet-runtime-0.5.6145/lib/types/private/abstract/declare.rb:37: warning: previous definition of initialize was here
/path/to/sorbet-runtime-0.5.6145/lib/types/types/simple.rb:44: warning: instance variable @__as_sorbet_simple_type not initialized
/path/to/sorbet-runtime-0.5.6145/lib/types/types/simple.rb:44: warning: instance variable @__as_sorbet_simple_type not initialized
/path/to/sorbet-runtime-0.5.6145/lib/types/types/simple.rb:44: warning: instance variable @__as_sorbet_simple_type not initialized
/path/to/sorbet-runtime-0.5.6145/lib/types/types/simple.rb:44: warning: instance variable @__as_sorbet_simple_type not initialized

Expected behavior
Requiring the gem in verbose mode should not emit warnings (this is the case when i replace sorbet-runtime with a number of other popular gems, such as rails, rake, rack, rubocop, rspec).
This is a bummer when using the default rspec config (via rspec --init, which enables verbose mode by setting config.warnings = true), making for noisy tests if one wants to track warnings in a project that uses sorbet-runtime.

I think it's probably just a matter of pushing this PR to completion
#3207
I haven't looked at how much work that is.

It looks like this is fixed now, maybe in #5482 but I haven't confirmed it was that PR for sure.


[BP][FLINK-26996] Break the reconcile after first create session cluster

Bp for https://github.com/apache/flink-kubernetes-operator/pull/145

cc @gyfora


Fix grafana datasource in  dashboards

When grafana not set the Teslamate as the default datasource, the dashboards imported would not work.
So before import dashboards to an exist grafana, need to replace the datasource name with datasource uid.
I add a function  to fix the datasource uid in the script.

I could not see the issue, compare https://github.com/jheredianet/Teslamate-CustomGrafanaDashboards

I think it's fixed for now - Imports working fine for me with just having the DataSource specified.
If it's still an issue we should wait for a response in https://github.com/grafana/grafana/issues/77325 before merging that fixture functions. I can't imagine that's how Grafana approaches automated imports of DataSources & Dashboards.
We could instead also hardcode the UID for example...


Roll engine d0b3e0723474..184b6e36e87c (1 commits)

https://github.com/flutter/engine/compare/d0b3e0723474...184b6e36e87c
git log d0b3e072347479b5481d1c6cffbb98a028c751a9..184b6e36e87c3a131e12c125ef492eb28deb5f35 --no-merges --oneline
184b6e36e Roll src/third_party/skia 3c0ad02bc545..9e6a3d76fc7f (4 commits) (flutter/engine#9167)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop
the roller if necessary.

Auto-roller completed checks. About to merge.


BUG_SEPARATE_IF_DOUBLE_WRITE Separate if statements will write all blocks twice

If statements for the same type separated by other types will incorrectly write both blocks twice due to how the folding with RustTypes work.
For example, with b == T2:
struct T {
	Test b;
	if (b == T1 || b == T2) {
		u8 t1;
	}
	u8 basic;
	if (b == T2) {
		u8 t2;
	}
}

Will incorrectly write

Test b
u8 t1
u8 t2
u8 basic
u8 t1
u8 t2

This manifests in SMSG_MESSAGECHAT for Wrath with achievement text.

Fixed by https://github.com/gtker/wow_messages/commit/09f5ddec4f672daf0d654622607381e063880973.


Expose program.emitBuildInfo

Suggestion
In Deno, I am making a change for deno check to not emit using the TS compiler anymore (waste of time because this command is just about type checking), but as part of this I still want to emit the build info to speed up future checks. Right now, I'm just calling the internal function like so:
program.emitBuildInfo(host.writeFile);

...but it would be nice if this was officially exposed in the declaration file.
🔍 Search Terms

emitBuildInfo

✅ Viability Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
Added to the declaration file. Perhaps the parameter could be made optional (if it's not) since the program has a host? I can submit a PR?
📃 Motivating Example / 💻 Use Cases
In Deno I want to store the build info file without emitting because we have a deno check command.
Related Issue
Previous issue that was closed because it was marked as a duplicate of the emit API: https://github.com/microsoft/TypeScript/issues/30886

If you run same config with noEmit: true, it should write only buildInfo as part of emit

@dsherret does that solve your use case?

Probably. I just haven't gotten around to test it out to see if it works. I would say if you know that works then feel free to close and thanks! :)


Feature request : enable diagnostic logging

Hello, I've been trying to enable a good size project to use the NUnit Test Adapter under TFS Build (0.96).
Some of the tests have been hanging on the build machine. I've not been able to see anything useful from the NUnit Test Adapter in the vstest logs that we turned on to try to diagnose the problem. The adapter also appears not to be aware of the timeout information in the .testsettings file passed to vstest so the build agent gets wedged.
There are notes on enabling UTE logging here:
http://blogs.msdn.com/b/aseemb/archive/2012/03/02/how-to-enable-ute-logs.aspx

Could you consider instrumenting the adapter to report progress, perhaps along the lines of:
using Microsoft.VisualStudio.TestPlatform.ObjectModel;
...
    public void RunStarted(string name, int testCount)
    {
        testLog.SendMessage(TestMessageLevel.Informational, "Run started: "+name);
        if (EqtTrace.IsVerboseEnabled)
        {
            EqtTrace.Verbose("Run started: "+name);
        }
    }

Hopefully this makes sense. I'm not overly familiar with the test adapter APIs, the author of the blog post on UTE logs advised on the EqtTrace API privately.
Moved from https://bugs.launchpad.net/nunit-vs-adapter/+bug/1199814

Issue moved to nunit/nunit3-vs-adapter #223 via ZenHub


Bug: <f7-input type="select" does not hold default value

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Framework7 Version:  2.1.3.

Framework7-Vue Version: 2.1.2.

Platform and Target: Chrome Browser Windows Desktop

Live Link or JSFiddle: PREFERABLY (IF YOU WANT YOUR ISSUE TO BE RESOLVED ASAP). You can start from forking the following JSFiddle template: JSFiddle

What you did
<f7-list no-hairlines-md>
      <f7-list-item>
        <f7-label>F7 input-type Select</f7-label>
        <f7-input type="select" :value="booking.dateTimeDetails.date" @input="booking.dateTimeDetails.date = $event.target.value; greet()">
          <option value="">Please select the trip date</option>
          <option v-for="bookingDate in bookingDates" :key="bookingDate.value" :value="bookingDate.value">{{bookingDate.display}}</option>
        </f7-input>
      </f7-list-item>
    </f7-list>

      Normal Select
      <select v-model="booking.dateTimeDetails.date">
        <option value="">Please select the trip date</option>
        <option v-for="bookingDate in bookingDates" :key="bookingDate.value" :value="bookingDate.value">{{bookingDate.display}}</option>
      </select>

      booking.dateTimeDetails.date =  {{booking.dateTimeDetails.date}}

There are 2 Select Boxes here, the top one is the F7 selectbox which does not hold the set value but the bottom select element is a normal HTML element using v-model and it works and sets the previously selected value properly. See the gif attached:

Expected Behavior
f7-input type="select" should also behave like the second select element and set the value properly.
Actual Behavior
f7-input type="select" does not select the value set in :value="booking.dateTimeDetails.date"
P.S. Remember, an issue is not the place to ask questions. You can use Stack Overflow
for that or join the #framework7 channel on irc.freenode.net, where we will be more
than happy to help answer your questions.
Before you open an issue, please check if a similar issue already exists or has been closed before.

Sorry but I found my mistake. I was clearing the bookingDates object in data() so the v-for="bookingDate in bookingDates" wasnt working. I fixed that problem and now its rendering the previous value correctly. This issue can be closed.
Thanks for the awesome work!! Best library I have used so far...


Windows: MeiliSearch tries to allocate 100Gb of disk space

Following https://github.com/meilisearch/MeiliSearch/discussions/1869
This bug should have been removed since v0.21.0 which works with the version of lmdb that should remove this hard memory allocation.
@Kerollmops can you check the correct version of lmdb is used?
Is there anyone having the same issue with a MeiliSearch version >= v0.21.0?

I checked the versions of LMDB we use in both MeiliSearch and milli, we use the v0.12.1 of heed which uses the version 0.9.70 of LMDB. The issue with the way LMDB grows the file on windows should have been fixed in version 0.9.17 and we use 0.9.70, so we are way ahead of the patch.
I am absolutely not sure why this bug continues to exist.

Thanks @Kerollmops
I let the issue open in case someone has the same issue with Windows. I will close it after some time if we don't get any other feedback

Due to lack of feedback regarding this issue, I close it
Feel free to ask to reopen if needed


Avoid using List and Dict for function argument types

For example:
ValidImage = Union[str, Image]

class ImageCLI(DockerCLICaller):
    def remove(
        self,
        x: Union[ValidImage, List[ValidImage]],
        force: bool = False,
        prune: bool = True,
    ): ...

If you call this as so:
from python_on_whales import docker
my_tags = ["foo", "bar"]
docker.image.remove(my_tags)

Then running mypy gives:
tmp.py:4: error: Argument 1 to "remove" of "ImageCLI" has incompatible type "list[str]"; expected "str | Image | list[str | Image]"  [arg-type]
tmp.py:4: note: "List" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
tmp.py:4: note: Consider using "Sequence" instead, which is covariant

The reason that mypy is complaining is that the API accepts a List[str | Image], i.e. a list that can hold strings or images, but not a list of only strings. Lists are mutable, so with the function could modify or add elements - and (according to the type signature) it's allowed to add elements that are of type Image, which would violate the inferred type of my_tags.
One solution on the caller side is to annotate my_tags: List[str | Image], but this could require importing Image and generally just shouldn't be necessary. PoW isn't intending to mutate the list so this should be indicated using Sequence or Iterable or similar.

I don't mind typing with something more generic than a list. After all, we often just iterate on the arguments.
As long as it doesn't complexify the codebase too much, I'd be happy to accept a PR in this direction.
A small PR would be great so that we can have an example to illustrate the change and its consequences.

It's not really a problem of being more generic, e.g. allowing sets/tuples (although that would be nice too). The problem is that if you annotate with List[str | Image] then the input must also be a List[str | Image] - passing a List[str] is invalid simply because the argument (a list) is a mutable type, even though PoW intends this to be valid since it won't mutate the argument.
Unfortunately if we switch to a more generic type we'll also have to change isinstance(x, list) checks...

I don't see many other solution than using a more generic type. And yes it will change the isinstance() calls but I believe that's a reasonnable amount of work and that the benefits are worth it.


Fixed location bias for Nomnatim geocoding

Modified nominatim geocoder wrapper so it looks for location in Edmonton automatically.
I also modified main files so it configures the domain specific files automatically.

Modified nominatim geocoder wrapper so it looks for location in Edmonton
automatically.

I understand this change is in a domain specific class, but it still seems
to me that specific restrictions like "Edmonton" are better specified in
the configuration files rather than hardcoded in Python.  If I change the
data to Toronto, I have to know to change this part of the code as well.
-Scott
On Wed, Aug 2, 2023 at 12:10 PM Kai15116 @.***> wrote:

Modified nominatim geocoder wrapper so it looks for location in Edmonton
automatically.
I also modified main files so it configures the domain specific files
automatically.
You can view, comment on, or merge this pull request online at:
https://github.com/D3Mlab/llm-convrec/pull/35
Commit Summary

642aa68
https://github.com/D3Mlab/llm-convrec/pull/35/commits/642aa68db4acd9bf24e9c87a8f4a793573021b25
Fixed location bias and modified main files so it configures the domain
specific configs automatically

File Changes
(3 files https://github.com/D3Mlab/llm-convrec/pull/35/files)

M clothing_main.py
https://github.com/D3Mlab/llm-convrec/pull/35/files#diff-b17f61bc6b1e4954928174dfa1d5a597120e6ca92a0b8585926ebf24133a21f7
(2)
M
domain_specific/classes/restaurants/geocoding/nominatim_wrapper.py
https://github.com/D3Mlab/llm-convrec/pull/35/files#diff-4fa23ace15d4304f3899ad1cf89d7d06416b06ec985f357b3b77919ce4bb8259
(7)
M restaurant_main.py
https://github.com/D3Mlab/llm-convrec/pull/35/files#diff-c3c7d35acaa5244e58389b4fcafd6e5bf6c7452dbed090bbe38d837313c57fec
(4)

Patch Links:

https://github.com/D3Mlab/llm-convrec/pull/35.patch
https://github.com/D3Mlab/llm-convrec/pull/35.diff

—
Reply to this email directly, view it on GitHub
https://github.com/D3Mlab/llm-convrec/pull/35, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABRA3JAEVTLYIOPOSWJPCRLXTJ3XZANCNFSM6AAAAAA3BQFW5Q
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Modified nominatim geocoder wrapper so it looks for location in Edmonton
automatically. I understand this change is in a domain specific class, but it still seems to me that specific restrictions like "Edmonton" are better specified in the configuration files rather than hardcoded in Python. If I change the data to Toronto, I have to know to change this part of the code as well. -Scott
…
On Wed, Aug 2, 2023 at 12:10 PM Kai15116 @.> wrote: Modified nominatim geocoder wrapper so it looks for location in Edmonton automatically. I also modified main files so it configures the domain specific files automatically. ------------------------------ You can view, comment on, or merge this pull request online at: #35 Commit Summary - 642aa68 <642aa68> Fixed location bias and modified main files so it configures the domain specific configs automatically File Changes (3 files https://github.com/D3Mlab/llm-convrec/pull/35/files) - M clothing_main.py https://github.com/D3Mlab/llm-convrec/pull/35/files#diff-b17f61bc6b1e4954928174dfa1d5a597120e6ca92a0b8585926ebf24133a21f7 (2) - M domain_specific/classes/restaurants/geocoding/nominatim_wrapper.py https://github.com/D3Mlab/llm-convrec/pull/35/files#diff-4fa23ace15d4304f3899ad1cf89d7d06416b06ec985f357b3b77919ce4bb8259 (7) - M restaurant_main.py https://github.com/D3Mlab/llm-convrec/pull/35/files#diff-c3c7d35acaa5244e58389b4fcafd6e5bf6c7452dbed090bbe38d837313c57fec (4) Patch Links: - https://github.com/D3Mlab/llm-convrec/pull/35.patch - https://github.com/D3Mlab/llm-convrec/pull/35.diff — Reply to this email directly, view it on GitHub <#35>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRA3JAEVTLYIOPOSWJPCRLXTJ3XZANCNFSM6AAAAAA3BQFW5Q . You are receiving this because you are subscribed to this thread.Message ID: @.>

That is true, I moved the location bias to config file.


Remove warnings about shadowing clojure.core/abs

Replaces abs* definition with clojure.core/abs, and excludes abs from
thi.ng/math/bits and thi.ng/math/core to prevent warnings like:
WARNING: abs already refers to: #'clojure.core/abs in namespace: thi.ng.math.bits, being replaced by: #'thi.ng.math.bits/abs

and
Warning: protocol #'thi.ng.math.core/IMathOps is overwriting function abs

Finally, bumps dependency for Clojurescript to 1.11.54 as abs was added in
https://github.com/clojure/clojurescript/commit/6e0bd78b62e3d72874614a4634d82c19e9dfd66d
Clojure 1.11.1 already implemented abs in:
https://github.com/clojure/clojure/commit/ff61321179a0b0f7d2c17a394ade80465ac15c28
Previously tests reported the warnings like:
  $ ./tangle.sh src/*.org test/*.org
  ... elided ...
  $ cd babel
  $ lein test
  Warning: protocol #'thi.ng.math.core/IMathOps is overwriting function abs
  WARNING: abs already refers to: #'clojure.core/abs in namespace: thi.ng.math.core, being replaced by: #'thi.ng.math.core/abs

  lein test thi.ng.math.test.core

  lein test thi.ng.math.test.macros

  Ran 17 tests containing 130 assertions.
  0 failures, 0 errors.

now tests pass like;
  $ ./tangle.sh src/*.org test/*.org
  ... elided ...
  $ cd babel
  $ lein test

  lein test thi.ng.math.test.core

  lein test thi.ng.math.test.macros

  Ran 17 tests containing 130 assertions.
  0 failures, 0 errors.

However, I was unable to run the Clojurescript tests using lein cleantest. Both with and without the patch, the runner would hang after printing the line Running ClojureScript test: unit-tests. I might take a look at upgrading to cljs.test from cemerick.cljs.test and using a different runner, but that seemed out of scope for this change.

Thank you again & sorry, it's been a while! On it now...


[help wanted] Get basic upload-to-wiki working

Intended to resolve #574 , still WIP, not ready to merge.

I need this feature and find out there is an issue requesting this feature(#574), so would like to try to implement this feature. I tryed rebasing #6024 onto master but it seems there are too many changes from the codebase so I decided to reimplement the feature directly on master branch. Now the upload works but I do think what I did is probably not the correct way to implement it. I'll explain later.
Here are some WIP screenshots in current PR state:

Screenshots about file upload

Reason about why I think my current implementation is bad is, when try to hacking on this feature, I found temp_repo.go always do operation to the repo when calling NewTemporaryUploadRepository(repo *models.Repository), seems I cannot operate to the wiki repo directly, so I added CloneWiki() and PushWiki() so I can process the wiki repo instead of the original repo. But I found inside PushingEnvironment() there are checks about if it is a wiki repo, so I think I may probably missed something.
The current PR state should be able to upload file to wiki repo, but after clicking the upload button, the page turns blank. I checked the console output and here is the related log:
UploadWikiFilePost
[Macaron] 2020-07-20 16:15:12: Started POST /api/internal/hook/pre-receive/blblb/61616 for [::1]
[Macaron] 2020-07-20 16:15:12: Completed POST /api/internal/hook/pre-receive/blblb/61616 200 OK in 2.9995ms
[Macaron] 2020-07-20 16:15:13: Started POST /api/internal/hook/post-receive/blblb/61616 for [::1]
[Macaron] 2020-07-20 16:15:13: Completed POST /api/internal/hook/post-receive/blblb/61616 500 Internal Server Error in 93.0008ms
[Macaron] 2020-07-20 16:15:13: Completed POST /blblb/61616/wiki/_upload 0  in 2.9386116s
[Macaron] 2020-07-20 16:15:13: Started GET /favicon.ico for <IP_ADDRESS>
[Macaron] 2020-07-20 16:15:13: Completed GET /favicon.ico 304 Not Modified in 1.9981ms
[Macaron] 2020-07-20 16:15:15: Started GET /serviceworker.js for <IP_ADDRESS>
[Macaron] [Static] Serving /serviceworker.js
[Macaron] 2020-07-20 16:15:15: Completed GET /serviceworker.js 304 Not Modified in 33.9743ms

I guess it is the 500 internal server error which caused the issue. I think it probably because I still missed something which cause it trigger the main repo post-receive hock, but still doesn't know where should I look at.
I still not dig into the whole codebase too deep (actually I'm new to golang), but still would like to help implementing this issue. Any advices / comments / code review would be very helpful. Thanks!

Last commit rebased the code onto the current master and fixed the git hook issue caused by provided a wrong env. There are still one issue haven't get resolved, after clicking the upload button, it will says "The process cannot access the file because it is being used by another process."(the file actually get into the wiki repo, but the cached file not get removed). Still don't know where went wrong..
Anyway although it's still WIP but I think maybe it can be good if someone can review the current state of this PR now so I can know where I did wrong to get me on the right track. Any review and advices are appreciated!

Codecov Report

Merging #12279 (10b92f3) into master (3270e7a) will increase coverage by 0.06%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master   #12279      +/-   ##
==========================================
+ Coverage   43.32%   43.38%   +0.06%
==========================================
  Files         646      643       -3
  Lines       71592    71239     -353
==========================================
- Hits        31015    30907     -108
+ Misses      35565    35322     -243
+ Partials     5012     5010       -2

Impacted Files
Coverage Δ

models/helper_environment.go
85.71% <0.00%> (-7.39%)
:arrow_down:

modules/auth/repo_form.go
41.59% <0.00%> (-0.75%)
:arrow_down:

modules/repofiles/upload.go
0.00% <0.00%> (ø)

routers/repo/repo.go
32.28% <0.00%> (-0.44%)
:arrow_down:

routers/repo/wiki.go
37.44% <0.00%> (-3.74%)
:arrow_down:

modules/repofiles/temp_repo.go
60.59% <52.63%> (-1.40%)
:arrow_down:

routers/routes/routes.go
89.02% <100.00%> (+0.09%)
:arrow_up:

services/wiki/wiki.go
56.90% <100.00%> (-1.39%)
:arrow_down:

modules/structs/repo.go
54.54% <0.00%> (-10.98%)
:arrow_down:

modules/notification/mail/mail.go
32.50% <0.00%> (-5.44%)
:arrow_down:

... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3270e7a...7ef0aeb. Read the comment docs.

Due to very limited spare time and the gitea development actually grows pretty fast, I may not have time to continue working on this feature. I'll close this PR and leave the patch here as a reference and see if anyone else would like to work on this feature.
This patch only added a place to upload image files to a _media folder to use, there is no place to browse a list of image files uploaded to the wiki repo. To improve the useability of the wiki feature, I think there are also some other things that need to be done other than just allow uploading image files, but that's more likely a major refactor then :/
Anyway hope the best :)


Move some ModuleLauncher functionality in boot

Ask Spring Boot team to widen visibility of Launcher.launch(String[] args)

Just a note that this refers to the call within ModuleJarLauncher.

https://github.com/spring-cloud/spring-cloud-stream/blob/9dfa9c92186deab9861b6069c3caa264e41cc2cc/spring-cloud-stream-module-launcher/src/main/java/org/springframework/cloud/stream/module/launcher/MultiArchiveLauncher.java#L68
and
https://github.com/spring-cloud/spring-cloud-stream/blob/9dfa9c92186deab9861b6069c3caa264e41cc2cc/spring-cloud-stream-module-launcher/src/main/java/org/springframework/cloud/stream/module/launcher/ModuleJarLauncher.java#L46

This is already in scope for the generic cloud deployer w-i-p.


try fixing x264

will close #13327 if it works.
Current problem:
install.exe is not installing for some reason
@ras0219 @JackBoosY @NancyLi1013 Can somebody figure out why msys install.exe is not installing?
The logs indicate that the following commands are run:

Makefile:381: update target 'install-cli' due to: cli
install -d /E/Repos/vcpkg/packages/x264_x64-windows-static/E/Repos/vcpkg/installed/x64-windows-static/debug/bin
Makefile:385: target 'install-lib-dev' does not exist
install -d /E/Repos/vcpkg/packages/x264_x64-windows-static/E/Repos/vcpkg/installed/x64-windows-static/debug/include /E/Repos/vcpkg/packages/x264_x64-windows-static/E/Repos/vcpkg/installed/x64-windows-static/debug/lib/pkgconfig
install x264.exe /E/Repos/vcpkg/packages/x264_x64-windows-static/E/Repos/vcpkg/installed/x64-windows-static/debug/bin
install -m 644 ./x264.h x264_config.h /E/Repos/vcpkg/packages/x264_x64-windows-static/E/Repos/vcpkg/installed/x64-windows-static/debug/include
install -m 644 x264.pc /E/Repos/vcpkg/packages/x264_x64-windows-static/E/Repos/vcpkg/installed/x64-windows-static/debug/lib/pkgconfig
Makefile:390: update target 'install-lib-static' due to: lib-static install-lib-dev
install -d /E/Repos/vcpkg/packages/x264_x64-windows-static/E/Repos/vcpkg/installed/x64-windows-static/debug/lib
install -m 644 libx264.lib /E/Repos/vcpkg/packages/x264_x64-windows-static/E/Repos/vcpkg/installed/x64-windows-static/debug/lib

but the target directories are not created / empty
Hmm i found everything in
E:\vcpkg_cache\downloads\tools\msys2\77f3fd5f29257d6b\E\Repos\vcpkg\packages\x264_x64-windows-static\E\Repos\vcpkg

@JackBoosY: Remind me if it is out of draft and i didn't bump it..... until then I'll focus on the bigger picture instead of minor less important details.

Looks passed.

Seems also need to update ci.baseline.txt.

/azp run

Awesome, thanks!


Re-enable javax/naming/spi/providers/InitialContextTest.java

Re-enable javax/naming/spi/providers/InitialContextTest.java
Related https://github.com/eclipse-openj9/openj9/issues/15205
Signed-off-by: Jason Feng<EMAIL_ADDRESS>

@llxia @Mesbah-Alam could you please review?


Add rake task to grab the patch for a PR

samp@tw-mbp-samp /crashlytics/fastlane/fastlane (master *) $ rake try_out[3763]
Getting pull request #3763:Updated cp command flag

I like it, looks great, I added some comments

This seems nice and simple and good. Things that it does not do include:

Give you a git remote for the contributor's fork (maybe you don't care?)
Give you a branch for your changes

Those things may not be desirable, but are things that I do for myself personally with a similar script, so I figured I'd mention it

@mfurtak Updated.  I wasn't sure the pros and cons for setting the upstream instead.

Looks good to me, with one question.

@i2amsam Still want to get this in?

Closing, this is probably not the best way to handle this.


Add Linux distribution support/compatibility information to README

Information about which Linux distributions and versions Droplet Agent supports has been added to the README page. Trailing whitespace characters have also been removed from the README page.

v2

Bumped Fedora version to 38 from 33


Update policies to v1.7.3

Checklist

[ ] Update changelog in CHANGELOG.md.

Will wait for 1.8 release instead


(URGENT) Repository with GitHub Pages enabled not using the correct artifact name

Reported by @hasel001 from @iho-ohi:

https://github.com/iho-ohi/S-102-Product-Specification/actions/runs/4918504824
is not deploying.
The deployment step is failing:

Because the build step "thinks" that GitHub Pages is not enabled, and generates with an artifact name other than "github-pages"

...

Notice at the end it says "metanorma-build-artifact".
However, this repository has "GitHub Pages" enabled as source:

@ronaldtse quick solution for this is to add token: ${{ secrets.GITHUB_TOKEN }}. I have prepared PR https://github.com/iho-ohi/S-102-Product-Specification/pull/42
Details
build-and-publish action is trying to check on its own if GitHub pages are enabled or not. To do this check we run gh api ... command which requires token

I will make this input as required so we will not miss it.
And maybe better we should provide additional input 'deliverable' with possible values:

auto
artifact-upload
github-pages

@ronaldtse how do you think?

However, why is the explicit token needed?

Because gh cli requires it https://cli.github.com/manual/gh_auth_login

Can’t it be part of the workflow?

Unfortunatelly all secrets have to be passed explicitly to actions/sub-workflows due to security reasons

Or use the new permissions key for a token that can write to pages?

It's not about pages permissions, it's just about accessing GitHub API via gh command line tool

Got it, thank you @CAMOBAP . Can you document this reason in the README of the repository? Thanks!


Add StartGoogleSession method

RefreshGoogleSession(Action<LootLockerGoogleSessionResponse> onComplete, string refresh_token = "")
should be 2 method overloads:
RefreshGoogleSession(string refresh_token, Action<LootLockerGoogleSessionResponse> onComplete)
RefreshGoogleSession(Action<LootLockerGoogleSessionResponse> onComplete)
Maybe make it obvious that when not sending the refresh token it is being pulled from the config?

Fixed =)


Strange issue with "sortable" as component parameter

I detected a small issue with the {{>extra-attributes}} mapping. Basically, if an attribute is called sortable, its valuesimply disappears during the mapping.

Template: <fancy class="foo" sortable="disappeared" other="true">hmmm</fancy>
Component:

extra-attributes}}>{{yield}}

Result:

hmmm

Snippet:
https://ractive.js.org/playground/?env=docs#N4IgFiBcoE5SBTAJgcwSAvgGhAZ3gEoCGAxgC4CWAbggHQkD2AtgA4MB2C7ZutAZkXYkAngAIAvKOLlqdBAA8yXJAApgAHXbqyS1gBsiSyKIDkAHiTUAfGZajgwKwrIwiAWkMuKAIwCuS3AwMKwdhCgQ9JCCzAHoWGxjLKisTLE1tTxgffwRcY2BRJiIWAEE9PWMXXwRRbHSyDkZ9BCNRPl8hSg4VAEp7eu0qIhhRJIlRMjAKXj4KdlUTJJMegG4BskZ2XAY9Oj0GFBUk2gYcmAAJABUAWQAZVfqMTQwHrXYhkZHJTgB3KVJKDQ1PUIsYTN4GEhhKl6roWAZWuYBEIxCQDLhcOJ1CA+AwGNjRNsYGQiN5dliQJZcMUWAhhsgCQxJggYBSqghsVYwEwebFkSIUs9ViAcGR4JggA

Ok, I found the issue, it's because the "sortable" attribute is defined as "booleanAttributes".
See:
https://github.com/ractivejs/ractive/search?q=booleanAttributes+&type=Code&utf8=✓
Basically, if an attribute is in this list, its value will be stripped ...which makes sense for usual DOM nodes.
However, it leads to surprises as we see for components.
More globally, perhaps we should not strip them at all since other scripts might read/use such attributes on normal DOM nodes. ...So, what do you think, should we add one more flag, or just drop the value stripping?

Hmmmm... does anyone know if leaving the attribute value is detrimental when supplied for boolean attributes? I imagine that most people wouldn't supply a value if it's not required. It looks like this particular attribute only applies to table elements, so it seems extra odd to strip it off of all elements.

I think it is made so that things like disabled="{{value}}" become disabled when true or empty `` when false instead of disabled="false".
I don't know if leaving the value in attributes instead of removing it completely can have an impact in some cases.


Alt key implementation

Added Alt key to X11Api (tested) and
windows (VK_Menu) implementation (untested).
Added new key event for left alt.

Fix windows implementation, now - waiting for CI


ISSUE-129 - regardless of quota clone the base product

#129 - Fixes

Hi @jcollins-axway,
Apologies for the late reply.
I was able to validate the fix. Now, when a product has a plan with no quota, a clone of the product with an name suffixed with "-no-quota" is created. The original product remains untouched and the application is linked to the cloned product instead of the original one.


Fix: ES idempotency issue for plugin

Codecov Report

Merging #556 into release-2.2.0 will increase coverage by 0.27%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##             release-2.2.0     #556      +/-   ##
===================================================
+ Coverage             32.3%   32.58%   +0.27%
- Complexity            1237     1244       +7
===================================================
  Files                  170      170
  Lines                15077    15077
  Branches              2393     2393
===================================================
+ Hits                  4871     4913      +42
+ Misses                9468     9425      -43
- Partials               738      739       +1

Impacted Files
Coverage Δ
Complexity Δ

.../ekstep/searchindex/processor/SearchProcessor.java
66.36% <0%> (+0.9%)
99% <0%> (ø)
:arrow_down:

...p/searchindex/elasticsearch/ElasticSearchUtil.java
47.94% <0%> (+4.38%)
52% <0%> (+3%)
:arrow_up:

...dex/transformer/AggregationsResultTransformer.java
100% <0%> (+100%)
4% <0%> (+4%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbf033c...f231855. Read the comment docs.


remove mentions of Num.maxNat

The docs mention Num.maxNat but it doesn't exist.
https://github.com/roc-lang/roc/blob/662eb5895eab36af4550a2c00d2bf089f0ef9340/crates/compiler/builtins/roc/Num.roc#L1229

Partially addressed in #6209, although there are still occurrences in Str.roc and List.roc

@lukewilliamboswell - could you please close this issue if it is no longer needed?


Typo in data reusables.dependabot.supported-package-managers

What article on docs.github.com is affected?
22 articles that include:
{% data reusables.dependabot.supported-package-managers %}

https://github.com/github/docs/search?p=2&q=supported-package-managers
What part(s) of the article would you like to see updated?
Note section contains a table, where we can read:

-.gradle.tks files, for Kotlin projects (specify gradle)

Should be:

-.gradle.kts files, for Kotlin projects (specify gradle)

@hsz Thanks for opening an issue! I'll get this triaged for the right team to take a look 👀

PR #2283 will fix this problem.


Output Documentation Issue

Running the most current devversion:

ERROR ~ Error executing process > 'output_documentation'

Caused by:
  Process `output_documentation` terminated with an error exit status (1)

Command executed:

  markdown_to_html.r output.md results_description.html

Command exit status:
  1

Command output:
  (empty)

Command error:
  Loading required package: markdown
  Error in readLines(con) : cannot open the connection
  Calls: markdownToHTML ... renderMarkdown -> tryCatch -> tryCatchList -> readLines
  In addition: Warning message:
  In readLines(con) : cannot open file 'output.md': No such file or directory
  Execution halted

Work dir:
  /beegfs/work/iiipe01/<private>/work/3a/8748666def578d3ba6aea821a80c72

Tip: you can replicate the issue by changing to the process work dir and entering the command `bash .command.run`

Looking at .command.err I found this:
Loading required package: markdown
Error in readLines(con) : cannot open the connection
Calls: markdownToHTML ... renderMarkdown -> tryCatch -> tryCatchList -> readLines
In addition: Warning message:
In readLines(con) : cannot open file 'output.md': No such file or directory
Execution halted

Looks like this is still an issue when staging files - instead we should drop things into channels and let Nextflow do the right thing with the files/headers we need.
Going to do this right now to get this project up and running over the weekend ;-)


chore(avm): Fake verification routine for avm recursion in public base rollup

Resolves #10243

base rollup gates go brrrr

In this PR, I set the number of columns to 3000 which is way more what we have now (760 columns) but what we might finally end up with. I will discuss dimensioning of this.

LGTM as long as it doesn't affect public base rollup compilation time much!

Good point @dbanks12 . I have not measured compilation time impact yet. I used the permutation of Poseidon2 directly ( asopposed to hash function) as suggested by @sirasistant as this should have a lower impact on compilation.

@jeanmon it looks like the CI times aren't huge so I think compilation time is fine.


Consider promise or callback for db operation complete.

There's times when updating a user's role will merit a redirect given new permissions, but without a promise or callback for write operations on updating roles, it's difficult to know when the role has been written to the db such that a router can appropriately route!
Added a promise or callback to your API shouldn't break backwards compatibility.
Thanks!

In 2.0 you should just use functions inside the Meteor method. When the Meteor method returns, you know that it finished.

Calling API methods outside of Meteor methods is discouraged.

@mitar I'm actually not calling API methods outside of Meteor methods.  Can you show a code example of what you're talking about, 2 comments above? Thanks!

Then you have a callback for your Meteor method, no? You can use that to know when method finished?
Inside Meteor methods calls to roles API behave like synchronous calls.

Ahh, no, that doesn't work.  Why don't you show me a working example?

I think it is on you to show me what doesn't work. :-) I sadly do not have time to create examples for you.

Are you French? Just wondering...

No, why?

I think a callback would guaranty that the write operation has been done on the server mongodb, but not that it has propagated to the client minimongo...

If you have a Meteor method on both client and server side, then on the client side callback is returned when simulation finished, and not when server finishes, so that user gets immediate feedback (latency compensation). If server then fails, client is reverted. If you want this not to happen, define our method only on the server.


Update equalsverifier to 3.15.7

About this PR
📦 Updates nl.jqno.equalsverifier:equalsverifier from 3.10 to 3.15.7
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

🔍 Files still referring to the old version number
The following files still refer to the old version number (3.10).
You might want to review and update them manually.
pom.xml

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "nl.jqno.equalsverifier", artifactId = "equalsverifier" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "nl.jqno.equalsverifier", artifactId = "equalsverifier" }
}]

labels: test-library-update, old-version-remains, commit-count:1

Superseded by #255.


Improve handling of missed textures?

When textures are stored externally, and when some of them are not available (i.e. not present in the dir with .gltf), the importer will remove the reference to this texture completely.
Can we change this, so when texture is not available, the texture slot will be still there? (and the texture will be displayed as pink by default, then)
I'm currently on 2.90.1 with unmodified gltf addon.

+1, this would be consistent with .obj importer too. bpy_extras.image_utils.load_image has some code to create a placeholder image we could reference.


Change Runner.selection_id type to int

Previously Runner.selection_id was declared to be a float, however the
API documentation says that it is a long:
https://api.developer.betfair.com/services/webapps/docs/x/SIA6#BettingTypeDefinitions-Runner
This changes the declared data type in the model to int. int is used
over long as this maintains Python 3 compatability (in Python 2
int('') will return a long if the number is big enough
to require it).

Good catch!


Key signature and wallet address get functions added to Public key

Problem
Signature and wallet address are entities derived from NEO public key, but regarding functions are defined on Private key only. Thus, in case when I have a public key and cannot obtain private key, I cannot obtain signature/address as well, despite I have no conceptual restrictions to do it.
Solution
Define key signature calculation and wallet address conversion functions on Public key entity.

Award aprasolova 200 points
Award im-kulikov 50 points for review

@aprasolova please provide an address for awards.

@lllwvlvwlll  APBNgjMFPsBywPc34FTLF2ciR9jxnb7ajJ

https://neoscan.io/transaction/28324feb9528c493f6588f8a7a6d559820e01581b82f7fd63c5b52a344333d52


closes #443 Trapping rain water

Have you read the Contributing Guidelines on Pull Requests?
Yes, I read it and follow the same.
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
closes #443
I added the Trapping rainwater problem using 3 approaches in C++

Great work @sumitvajarinkar !!

Thanks @Saviour1001


Minor fixes to Tag Helpers intro doc

Add a missing space before the word "icon", and properly escape two asterisks.

Hi @scottaddie, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

@scottaddie  Thanks


Alignment-based replay crashes on receipt log

ERROR Alignment-Based Replayer 2:8        Execute failed: ("NullPointerException"): null

Hi, could you send me the log and the workflow, so I can have a deeper look at this? Thanks.

Hi, Ale, could you send me the data, event log and  the exported workflow, so I can have a deeper look at it? Thanks

Hi, have checked the bugs and fixed them now.


Improvements to 2FA workflow and UI

The code input field is a weird box that if i hit the small up or down arrows, raises or lowers the number. Can we remove that for just a text field?
On the completion page (https://test-apply.opentech.fund/account/two_factor/setup/complete/) where it says "Congratulations, you've successfully enabled two-factor authentication.", can we add a sentence that says be sure to generate and download backup codes, in case you loose your device (https://test-apply.opentech.fund/account/two_factor/backup/tokens/).
On the https://test-apply.opentech.fund/account/two_factor/backup/tokens/, can we bump the "Back to Account Security" to be under the "Generate tokens" button?
Can we get a #notify when someone enables or disables 2fa?

This is on test for testing. Moved back button to top, made sure field to enter 2FA code has focus when needed, improved styling. Added button to get back to account page.

Go to 2FA Link: https://test-apply.opentech.fund/account/two_factor/setup/
Design specifications are visible, how do we test if it's functional?
Image 1:

Image 2:

@fourthletter Do the steps a user setting up 2FA would do and make sure it works and that it’s easy to understand each step.
Sent with GitHawk

@frjo 1) In the Backup Tokens, clicking on Show Codes gives me to an error 2) I've logged out and logged back in, but the system didn't ask me 2FA. I'm fine with these features going live. Thank you!

hey @frjo, can we tweak the CSS on this a bit?

change 'Enable Two-Factor Authentication' (image 1,2,3 from Di) to match the font size of "profile" and "become" on the account page.
change 'Account Security' (image 4) to the same font size as well.
change 'Backup Tokens' from the backup token page tot he same font size as well.
reduce font size of 'Backup Tokens' and 'Disable Two-Factor Authentication' on account security page (image 4) and make sure they are the same size.
add the same banner 'welcome xxx' that shows on the account page, to the account security page as well
delete 'back to account' button (image 4) and instead maybe add it in the banner that will be added
delete the "back" button on the second page (image 2 from Di)


Changed update event so it also catches animations

Currently the update event is only sent when individual calls are made the library. this means animations do not trigger events. I have passed the event handling down a layer into the driver to cover this.
I was not able to change the event handling in the main library class as animations are run against the driver's universe object and I didn't want to break existing functionality with animations.

Any update on this?
Cheers

Thank you for your PR and sorry for the inactivity.
While I self-assigned myself I was quite busy the last two weeks.
I try to review, test and merge it this weekend!

Great news!
if possible I'd be very interested in being part of the node-dmx org as I plan to do lots of work on this in the future! Please let me know if you're interested :)
Thanks,
Will

Seems to be a legit and useful change. Thanks for your work! 🍪
I noticed your commits are made as woverton<EMAIL_ADDRESS>and it seems to be another mail address than the one you are using on Github.
This means the commits cannot be referenced with your Github account, which is the reason we don't see your profile picture here:

Since you plan to make more commits in the future, you may want to have this work linked to your Github.
If this was by mistake I'll wait and give you the change to make a fix commit (--amend) and a force push with your Github mail adress before merging. 🙂

@Fensterbank Good spot! Simply added my new email to my github account and that seems to have sorted it. Cheers


Scoreboard is hiding

Scoreboard is hiding after left mouse clicking on the screen.

added a toggle for that


[Bug] Visualization Mismatching Problem of 3D Lidar Box on imgs in NuScenes Dataset.

Prerequisite

[X] I have searched Issues and Discussions but cannot get the expected help.
[X] I have read the FAQ documentation but cannot get the expected help.
[x] The bug has not been fixed in the version (0.17).

Task
I'm using the official example scripts/configs for the officially supported tasks/models/datasets.
Branch
branch https://github.com/open-mmlab/mmdetection3d/v0.17.3
Environment
sys.platform: linux
Python: 3.7.13 (default, Mar 29 2022, 02:18:16) [GCC 7.5.0]
CUDA available: True
GPU 0,1: NVIDIA GeForce RTX 3090
CUDA_HOME: /usr/local/cuda-11.3
NVCC: Build cuda_11.3.r11.3/compiler.29745058_0
GCC: gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
PyTorch: 1.9.0+cu111
PyTorch compiling details: PyTorch built with:
  - GCC 7.3
  - C++ Version: 201402
  - Intel(R) Math Kernel Library Version 2020.0.0 Product Build 20191122 for Intel(R) 64 architecture applications
  - Intel(R) MKL-DNN v2.1.2 (Git Hash 98be7e8afa711dc9b66c8ff3504129cb82013cdb)
  - OpenMP 201511 (a.k.a. OpenMP 4.5)
  - NNPACK is enabled
  - CPU capability usage: AVX2
  - CUDA Runtime 11.1
  - NVCC architecture flags: -gencode;arch=compute_37,code=sm_37;-gencode;arch=compute_50,code=sm_50;-gencode;arch=compute_60,code=sm_60;-gencode;arch=compute_70,code=sm_70;-gencode;arch=compute_75,code=sm_75;-gencode;arch=compute_80,code=sm_80;-gencode;arch=compute_86,code=sm_86
  - CuDNN 8.0.5
  - Magma 2.5.2
  - Build settings: BLAS_INFO=mkl, BUILD_TYPE=Release, CUDA_VERSION=11.1, CUDNN_VERSION=8.0.5, CXX_COMPILER=/opt/rh/devtoolset-7/root/usr/bin/c++, CXX_FLAGS= -Wno-deprecated -fvisibility-inlines-hidden -DUSE_PTHREADPOOL -fopenmp -DNDEBUG -DUSE_KINETO -DUSE_FBGEMM -DUSE_QNNPACK -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -DSYMBOLICATE_MOBILE_DEBUG_HANDLE -O2 -fPIC -Wno-narrowing -Wall -Wextra -Werror=return-type -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-sign-compare -Wno-unused-parameter -Wno-unused-variable -Wno-unused-function -Wno-unused-result -Wno-unused-local-typedefs -Wno-strict-overflow -Wno-strict-aliasing -Wno-error=deprecated-declarations -Wno-stringop-overflow -Wno-psabi -Wno-error=pedantic -Wno-error=redundant-decls -Wno-error=old-style-cast -fdiagnostics-color=always -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Werror=format -Wno-stringop-overflow, LAPACK_INFO=mkl, PERF_WITH_AVX=1, PERF_WITH_AVX2=1, PERF_WITH_AVX512=1, TORCH_VERSION=1.9.0, USE_CUDA=ON, USE_CUDNN=ON, USE_EXCEPTION_PTR=1, USE_GFLAGS=OFF, USE_GLOG=OFF, USE_MKL=ON, USE_MKLDNN=ON, USE_MPI=OFF, USE_NCCL=ON, USE_NNPACK=ON, USE_OPENMP=ON,

TorchVision: 0.10.0+cu111
OpenCV: 4.6.0
MMCV: 1.3.13
MMCV Compiler: GCC 7.3
MMCV CUDA Compiler: 11.1
MMDetection: 2.14.0
MMSegmentation: 0.14.1
MMDetection3D: 0.17.0+ded7876
------------------------------------------------------------

Reproduces the problem - code sample
def draw_lidar_bbox3d_on_img(bboxes3d,
                             raw_img,
                             lidar2img_rt,
                             img_metas,
                             color=(0, 255, 0),
                             thickness=1):
    """Project the 3D bbox on 2D plane and draw on input image.

    Args:
        bboxes3d (:obj:`LiDARInstance3DBoxes`):
            3d bbox in lidar coordinate system to visualize.
        raw_img (numpy.array): The numpy array of image.
        lidar2img_rt (numpy.array, shape=[4, 4]): The projection matrix
            according to the camera intrinsic parameters.
        img_metas (dict): Useless here.
        color (tuple[int]): The color to draw bboxes. Default: (0, 255, 0).
        thickness (int, optional): The thickness of bboxes. Default: 1.
    """
    img = raw_img.copy()
    corners_3d = bboxes3d.corners
    num_bbox = corners_3d.shape[0]
    pts_4d = np.concatenate(
        [corners_3d.reshape(-1, 3),
         np.ones((num_bbox * 8, 1))], axis=-1)
    lidar2img_rt = copy.deepcopy(lidar2img_rt).reshape(4, 4)
    if isinstance(lidar2img_rt, torch.Tensor):
        lidar2img_rt = lidar2img_rt.cpu().numpy()
    pts_2d = pts_4d @ lidar2img_rt.T

    pts_2d[:, 2] = np.clip(pts_2d[:, 2], a_min=1e-5, a_max=1e5)
    pts_2d[:, 0] /= pts_2d[:, 2]
    pts_2d[:, 1] /= pts_2d[:, 2]
    imgfov_pts_2d = pts_2d[..., :2].reshape(num_bbox, 8, 2)

    return plot_rect3d_on_img(img, num_bbox, imgfov_pts_2d, color, thickness)

main.py shows at below:

                import cv2
                img = cv2.imread(kwargs['img_metas'][0]['filename'][0]) # front
                r_h, r_w,_ = kwargs['img_metas'][0]['img_shape'][0]
                img = cv2.resize(img, (r_w, r_h))
                box = kwargs['gt_bboxes_3d'][0]
                lidar2img_rt = kwargs['img_metas'][0]['lidar2img'][0]
                plot_img = draw_lidar_bbox3d_on_img(box,
                                                    raw_img=img,
                                                    lidar2img_rt=lidar2img_rt,
                                                    img_metas=None,
                                                    color=(0, 255, 0),
                                                    thickness=1)
                cv2.imwrite("plot_lidar_img.jpg", plot_img)

Reproduces the problem - command or script

I use official draw_lidar_bbox3d_on_img code to visualize GT LidarBoxInstance, but got mismatching problem. It got height mismatching from ground.

Reproduces the problem - error message
Mismatching images show as below:

It will be serious in long range small objects:

Additional information
I want to know the reason of mismatching because I can't see it in the nuscenes dataset officical demo.

Here is Nuscenes Dataset Annotation which is captured from nuscenes websit

Please use the main/dev-1.x branch which has few bugs.

Code Problems, resloved.

hi @Irvingao , how did you solve the problem? thank you


testing but adding a frontend fails

[Wed Nov 06 11:07:37.032311 2019] [cgi:error] [pid 20489] [client <IP_ADDRESS>:34264] AH01215:     backend = "    default_backend " + form.getvalue('backend') + "\n", referer: http://haproxy-wi.....:8080/app/add.py
[Wed Nov 06 11:07:37.032396 2019] [cgi:error] [pid 20489] [client <IP_ADDRESS>:34264] AH01215: TypeError: Can't convert 'NoneType' object to str implicitly, referer: http://haproxy-wi......:8080/app/add.py

Where have you been taught courtesy ...
Hi,
edit please add.py:
backend = " default_backend " + form.getvalue('backend')

to
backend = " default_backend " + form.getvalue('backends')

thx for the quick reply
its working now

You are welcome )


[ZEPPELIN-1934] maven-assembly-plugin fails make-assembly if executing user's ID is "too big"

What is this PR for?
maven-assembly-plugin fails make-assembly execution when the executing user's ID is "too big."
If domain account, managed by Active Directory or Os X, it assigned very large user IDs that inconsistent with GNU tar archiver and maven-assembly-plugin's configuration property tarLongFileMode  should be set to posix value.
See proof links below:
http://maven.apache.org/plugins-archives/maven-assembly-plugin-2.6/assembly-mojo.html
http://stackoverflow.com/questions/30246705/mvn-failure-on-build
What type of PR is it?
Improvement
Todos
N/A
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1934
How should this be tested?
Manually
Screenshots (if appropriate)
Questions:

Does the licenses files need update? - NO
Is there breaking changes for older versions? - NO
Does this needs documentation? - NO

Thanks, could you clarify the PR title, and also update the JIRA title?

@felixcheung Done. I hope that new title is more precise than previous.

Cool. Can you tell me how to test it by myself?

@jongyoul Yes, you can do this like described there https://issues.apache.org/jira/browse/MASSEMBLY-781?focusedCommentId=14640499&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14640499

Thanks. LGTM

LGTM


Allow case-insensitive search

Reopened this issue, because it does not work for querying the dependencies.

Issue with getting a feature by name too. Right now it is possible to have two Features with identical names but casing (e.g. Java and java).

fixed and merged


Keep-alive timer was not properly calculated + LinkContext lifetime issue

Fix it and added a unit test.
Fix #392.

Since I had to play in LinkContext, I made a fix for #396. This would replace #395. Instead of owning the shared_ptr in the callbacks and waiting in the destructor for them to release, the callbacks instead own a weak_ptr and checks that it's still valid (the shared_ptr automatically gets destroyed in the LinkContext default destructor).

As noted by Nicholas Lee, even with original fix, the keep-alive timers were internally expiring early, just to restart a very short timer afterwards. This was caused by how we used to drive the keep-alive timer. It was not restarted on every link activity, we were just waiting for the old one to expire and then we were re-calculating a new timer based on the recorded last link activity. I made the change to simply restart the timer on every link activity, I think it's clearer.
As for the LinkContext lifetime issue, I ended up superseding #435 by simply having the LinkContext be shared_from_this. Shutdown is properly done in the OnLowerLayerDown and checked in the callbacks. I also found that MContext could possibly have a similar issue (if a shutdown occurs while waiting for a response), so I applied the same fix. Shutdown is also properly checked.


Angular 16: webpack dev server show error "ResizeObserver loop limit exceeded"

Which @angular/* package(s) are the source of the bug?
compiler-cli
Is this a regression?
Yes
Description
After upgrade from angular 15 in dev mode, webpack show error "ResizeObserver loop limit exceeded"

This div appare in overlay.
Side note: no error into the console
Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
No response
Please provide the environment you discovered this bug in (run ng version)
_                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/

Angular CLI: 16.0.0
Node: 18.12.1
Package Manager: pnpm 8.2.0
OS: win32 x64

Angular: 16.0.0
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, localize, material, material-moment-adapter
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1600.0 (cli-only)
@angular-devkit/build-angular   16.0.0
@angular-devkit/core            16.0.0 (cli-only)
@angular-devkit/schematics      16.0.0 (cli-only)
@schematics/angular             16.0.0 (cli-only)
rxjs                            7.8.1
typescript                      5.0.4

Anything else?
No response

This seems like a bug but we'll need to look at a reproduction to find and fix the problem. Can you setup a minimal repro please?
You can read here why this is needed. A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.
This might be related to your directory structure so its really important to get an accurate repro to diagnose this.

After some tests, I realized that the problem is apparently not with angular but with external libraries, which use ResizeObserver. As per https://developer.mozilla.org/en-US/docs/Web/API/ResizeObserver#observation_errors
Minimal Reproduction
Create a new app in Angular 16 using ng new proxy-test --standalone
Change the builder option in angular.json to @angular-devkit/build-angular:browser-esbuild
Add a proxyConfig to the serve configuration
Run the proxy and the application
Endpoints using the defined proxy path are not received in the proxy.
https://github.com/renanrider/repro-issue-25151

@renanrider In your case calling book.destroy() in ngOnDestroy() fixes your issue.

Thank you Daniel for your contribution to the issue.
Stangely enough, the issue does not occur when I import your repo into stackblitz but it does when I run it locally.

@json-derulo I don't think your example is a correct repro. It's actually a buggy code that is supposed to trigger this error.
See in plain js: https://stackblitz.com/edit/js-xduijx?file=index.js

@JeanMeche I agree that my code is buggy, I was just trying to provoke the error. However according to this SO thread there seem to be cases where this error is benign and isn't caused by buggy code. There is also an ongoing discussion whether to treat this as a warning instead.

@JeanMeche on stackblitz isn't replicable because the error appears only when the webpack dev server is used


feat: Add user onboarded state

First stage of https://trello.com/c/CyzhVfx5/1299-8-add-user-state-to-cms-and-block-api-calls
Adds the onboarded flag to the User. Once the migration is run and all the existing as well as new users have got the flag set to true we can then implement the auth rule to reject the ones with a false value
Notable changes

adds a modification to auth0 rule which needs to be manually deployed

These changes look good to me.


Fresh install - trying to sign in via Google

When doing so I am prompted with the following error and then Cumulus goes unresponsive.

Duplicate of https://github.com/gillesdemey/Cumulus/issues/34


Pyodide page

this goes with notebook 6.
See how it looks:
https://zonca.github.io/cheapandfair-template/view.html?url=https%3A%2F%2Fg-1926f5.c2d0f8.bd7c.data.globus.org%2Fmyfolder5%2Fdust%2Fdust_023GHz.fits