Add ContractConfigurator dependency to TestFlight

@JonnyOThan made me aware of another user having problems running KSP with RealismOverhaul and TestFlight installed. Apparently TestFlight includes a TestFlightContracts.dll, depending on ContractConfigurator.dll, since version 1.3 for KSP 0.90.

https://github.com/KSP-RO/TestFlight/commit/639e90583e8ca3c4f79d8527566e3d8fc2c6ed1f#diff-4485773c9a03724d0df8939c3c71534d
https://forum.kerbalspaceprogram.com/index.php?/topic/99043-122-testflight-v180-01-may-2017-bring-flight-testing-to-ksp/&do=findComment&comment=1934467

158 [WRN 14:18:14.760] AssemblyLoader: Assembly 'TestFlightContracts' has not met dependency 'ContractConfigurator' V1.0.0

I wonder why no one ever complained about that before, but I guess TestFlight usually gets installed with RO, and RP-1 (and maybe also other mods) which also often gets installed alongside RO, depends on ContractConfigurator, and thus can hide the missing dependency.

Backports incoming...


BE | Fix translations

Custom strings wrapped with the gettext_lazy function (imported in python.py files gettext_lazy as _) are not translated in Django Admin when Serbian language is selected.
Make sure that all strings are translated in django.po files for the enabled languages (currently just Serbian).

Fixed (commit)

Fixed (commit)


Fixes #73 Add documentation to class LabelEncoder and to method infer…

…LabelEncoding
Includes

[ ] Documentation

@ashwinbhaskar no worries:) I have made the changes that you pointed out and pushed

@inejc Also the build seems to have failed. I do not have permission to trigger it again. Can you trigger it again, please?

All builds from forked repos are failing because circleci secrets are not copied there (i.e. the Codacy token is missing). I need to find a workaround for that.


[Task]: Fix migration sometimes leads to corrupted profiles

Task description
After doing migration in mobile, sometimes the profiles get corrupted and you cant use firefly anymore unless I wipe all profiles and firefly data and do a fresh start, like a new installation.
There are couple of issues we should fix before that could be affecting this behavior:

#3802
#2473
#4184
When those are fixed, we should revisit this issue and see if it still happens.

Requirements
Migration doesnt corrupt the app
Creation checklist

[ ] I have assigned this task to the correct people
[X] I have added the most appropriate labels
[X] I have linked the correct milestone and/or project

Blocked by

#3802
#2473
#4184

Cant repro this issue anymore, moving to backlog just in case

Closing for now. We can reopen if it occurs again.


Location ordering

Is there any way to order locations in the way they are defined in my hiera yaml file? I am trying to go from static configs and erb templates being pushed to servers to automatically generated configs with this module and hiera, and my virtual host config is a mess!  How can i maintain the order of locations?

I need the same kind of thing. According to the doc, order is important especially for regexp:
[…]the location with the longest matching prefix is selected and remembered. Then regular
expressions are checked, in the order of their appearance in the configuration file. The search of
regular expressions terminates on the first match, and the corresponding configuration is used

source

Ah, didn't see the $priority parameter for location resource.
Might be cool to order the parameters so that we can find them faster…

Hello,
this is a mighty module. I do not think ordering the parameters would change anything. But patches regarding the documentation of this module are always welcome.
https://github.com/voxpupuli/puppet-nginx/blob/master/manifests/resource/location.pp#L90-L92


Toolkit 0.11 support

Description
Update QCSubmit to work with the OpenFF Toolkit 0.11+
Supersedes #203
Todos

[x] Pin Toolkit >= 0.11 in environments

Test failures (running locally on my machine):

[x] Many test failures due to moving from OpenMM units to OpenFF units in locally executed code that were fixed with simple find+replace
[x]  Several test failures due to https://github.com/openforcefield/openff-toolkit/issues/1416 that are fixed in https://github.com/openforcefield/openff-toolkit/pull/1417
[x] A usage of pytest.approx that needed updating with the new units package
[x] Manual unit handling in combine_openff_molecules around np.vstack() that is no longer necessary with OpenFF units
[x] A number of tests from QCEngine's lack of support for Toolkit 0.11 (https://github.com/MolSSI/QCEngine/pull/378)

Status

[ ] Requires https://github.com/MolSSI/QCEngine/pull/378 in a release on conda forge
[ ] Requires https://github.com/openforcefield/openff-toolkit/pull/1417 in a release on conda forge
[ ] Ready to go

@Yoshanuikabundi I noticed you have unpinned psi4 which is a great idea, I would recommend following this environment to get a psi4 version compatible with conda-forge. I think the important ones are

libint2=*=hc9558a2_9
intel-openmp!=2019.5
psi4=1.5
Happy to help out with getting it working as well!

Ahh looks like the channel priority might need to be updated as well I think

psi4
conda-forge
openeye
should work

Love it when an environment solves but doesn't work!

Love it when an environment solves but doesn't work!

That's half the fun of using Psi4!

OK I think the remaining errors are just waiting on the upstream updates.

Most of the errors seem related to qcengine. This error looks like something to do with the toolkit though did something change with the properties dictionary?

Yeah,  __deepcopy__ was implemented for performance reasons and had a bug, the fix is merged and will be in the next toolkit release. Writing this PR is how we learned that 😂
I can temporarily pin the appropriate branches in the CI environment to make sure it all works if you like? But I figured we may as well wait for the releases.

Yeah, deepcopy was implemented for performance reasons and had a bug, the fix is merged and will be in the next toolkit release. Writing this PR is how we learned that 😂

Ahh thats great that you have a solution already!

But I figured we may as well wait for the releases.

Yeah happy to wait, just wanted to check it was fixed good job!

I updated the environments to install against the versions one would expect to work, just in case they don't ... and they do!
I will make a toolkit release in the coming days. I'll check with MolSSI on the status of a QCEngine release.

This is soft blocked by https://github.com/openforcefield/openff-units/pull/51 being in a release because the next QCEngine release will include some fixes for the new pint - though Lori's changes might be backwards-compatible

Assuming the checks of ebc3b015bc729adf2c961ef7ca6ee75ccc279b18 pass, I'm going to go ahead and merge this and cut a release later today or tomorrow.
My commits were prodding along with changes to upstreams and isolating a weird bug in the upstream packaging. They mostly cancel each other out, resulting in no changes to the source code. So I consider the earlier approval from @j-wags still valid here.


cli fails generating artifacts

Issue workflow progress

Progress of the issue based on the Contributor Workflow

[ ] 1. The issue provides a reproduction available on Github, Stackblitz or CodeSandbox

Make sure to fork this template and run yarn generate in the terminal.
Please make sure Mesh package versions under package.json matches yours.

[ ] 2. A failing test has been provided
[ ] 3. A local solution has been provided
[ ] 4. A pull request is pending review

Describe the bug
Since the release of v0.78.12 the cli package has an issue that causes a failure on generating the Typescript artifacts.
This happens when working with a single data source and a transform in wrap mode.
This is the output:
💡 🕸  Mesh Generating the unified schema
💡 🕸  Mesh - Source1 Dereferencing the bundle
💡 🕸  Mesh - Source1 Creating the GraphQL Schema from dereferenced schema
💡 🕸  Mesh Generating artifacts
💡 🕸  Mesh Generating index file in TypeScript
💥 🕸  Mesh TypeError: Cannot read properties of undefined (reading 'get')
    at generateTsArtifacts (/Users/user/projects/mesh-project/node_modules/@graphql-mesh/cli/bin.js:251:70)
    at Object.handler (/Users/user/projects/mesh-project/node_modules/@graphql-mesh/cli/bin.js:1033:19)

To Reproduce
Steps to reproduce the behavior:

Have a Mesh service that works on a single data source (hence no stitching required)
Define a transform at the source level that supports both bare and wrap mode (e.g. naming convention, filterSchema, etc.)
Omit the mode property in the transform config (or set it to wrap)
Run the server

Expected behavior
The artifacts are generated correctly and the server runs as normal.

Hey @ardatan, I thought I'd summarise my findings on this issue.
This happens because merger-bare is applied by default, at the root level, to the Mesh Config.
Merger-bare does not seem to play nice when used in a single data source (no merging actually required) and at least one wrap mode transform.
In a scenario like this, merger-stitching should be user as a default instead; so this seems to be the first thing to fix.
In fact, if I explicitly apply merger: stitching to the Mesh Config .yaml file, things work again as expected.
Clearly, this is just the initial part of the issue, because developers might still need to user merger: bare and it should just work.
The actual error is generated by generateTsArtifacts which expects a unified schema as first argument.
Then it tries to access the get property out of unifiedSchema.extensions.sourceMap, like this:
const transformedSchema = unifiedSchema.extensions.sourceMap.get(rawSource);

The problem, in this case, is that with this configuration (single data-source with merger-bare and wrap-mode transform) the extensions property in the unified schema resolves to [Object: null prototype] {} and so the sourceMap property is undefined.
Instead, in the case of a single source with merger-bare and bare-mode transform, the same extensions property does have sourceMap.get and so generateTsArtifacts can get the transformedSchema.
Hope this helps.


Fix a bug

Good catch! I fixed this just now in e74db286fe89a92c7ace6a1c463179ba4adb7e5f. I didn't notice this initially because it only shows up if there are 4 leading zero bits in the row or column hash (otherwise the hex formatting expands to the right size anyway).
BTW, if you're getting into open source, here's a bit of feedback for your next PR to make it a bit nicer for the developer:

Instead of "Fix a bug", enter a title that actually describes the problem
Add a description with further info about why it happens and how to reproduce it
Add to the tests (doctests)


As a user, I want to add a new task, so that I can record task that needs to be completed

This is a user story which can be broken down into different features (type.epic)

simply record


Precompiled binary 'mksnapshot' breaks building process (Centos 6.x).

Hi,
Starting with 1.17.0, the building process on a Centos 6.x machine is not working anymore.
Everything is crashing on snapshot creation:
..............
Verifying if snapshot can be executed via mksnapshot
Generating startup blob at "atom-1.17.0-beta4/out/snapshot_blob.bin"
atom-1.17.0-beta4/script/node_modules/electron-mksnapshot/bin/mksnapshot: /usr/lib64/libstdc++.so.6: version `GLIBCXX_3.4.15' not found (required by atom-1.17.0-beta4/script/node_modules/electron-mksnapshot/bin/mksnapshot)
Error: Command failed: atom-1.17.0-beta4/script/node_modules/electron-mksnapshot/bin/mksnapshot atom-1.17.0-beta4/out/startup.js --startup_blob atom-1.17.0-beta4/out/snapshot_blob.bin
............
It seems that with this version, the building procedure calls a PRECOMPILED BINARY 'mksnapshot', not compiled during the building stage as other tools as before. By using a precompiled tool during building process, the portability is broken. I have no problems to run 'atom' in a different root environment (avoiding GLIBCXX_3.4.15' not found issues), but I cannot do this during the building procedure.
System: Centos 6.x (supported until the end of 2020).
atom: v1.17.0-beta4
nodejs: v6.10.3
npm: v3.10.10
I am not happy with precompiled tools during building process (like electron-mksnapshot), I consider this as a bad decision. It should be compiled during building process, not using precompiled binaries.

Even if you get past that part Atom will still be unable to run because it has other dependencies on glibcxx 3.4.x.  See #2177 for more details.

Wrong !
I'm running atom on Centos 6.x since alpha versions (0.x.x) and works fine, even with 1.16.x !
The clue is to add the glibc-2.14 libraries in the applications path, just like google chrome and other applications !


[KGA-29] [KGA-136] fix: add NoDelegateCall modifiers to DualVMToken

Fixes the issue raised during the audit about eventual honeypots that could lure a user and manipulate starknet tokens without explicit approvals

Added noDelegateCall modifier to L2KakarotMessaging and DualVMToken
Added associated tests under Security/

https://github.com/code-423n4/2024-09-kakarot-findings/issues/38
Closes #1562

This change is

All relevant end to end tests passes but there is problems with nonce and relayer cc @ClementWalter


please update npm package

I found the new version tag is 1.1.6. it's turn scrubTime change from const into let.
But the npm package is not updated,still 1.1.5. This caused my program to fail.
Please upadate this

Hey @hahaxiaowai,
Yes, you are right.. i haven't had much time lately but i will update the npm package.
Thank you!

I understand and thank you for your contribution, please close this issue when updated

@BMSVieira
Hi, It's been a year and a half.
please update npm package...
why other people have this problem..

@BMSVieira Hi, It's been a year and a half. please update npm package... Why isn't anyone else having this problem..

Add GitHub link into your packages.json
Like: "mooviejs": "github:BMSVieira/moovie.js"
That should solve this issue for you.


Update changelog ahead of v0.29.0 release

This will be the final release of this repository before merging the codebase into the contrib collector.
This contains breaking changes, some of which concern similar the same functionality as was changed in v0.28.0. SInce v0.28.0 has not yet been included in a release of the collector, I plan to create an new upgrade guide that describes all changes in both v0.28.0 and v0.29.0, and present that as a single guide for the next collector release.

--- WIP ---
Several changes have been made that affect configuration for the filelog, syslog, tcplog, udplog, and journald receivers.
Update all usages of field syntax
Field syntax no longer requires the $ character. Instead each field must begin with body, attributes, or resource.

Deprecated ExampleUpdated Equivalent

$$attributes["log.file.name"]

attributes["log.file.name"]

$$resource["host.name"]

resource["host.name"]

$$body.foo

body.foo

$$.foo

body.foo

foo

body.foo

Tip for updating sub-parsers
To update the parse_from field in a "sub-parser", such as timestamp or severity, consider where the value would reside if the sub-parser was excluded.

Deprecated ExampleUpdated Equivalent

operators:
- type: regex_parser
  regex: '^Time=(?P<time>\d{4}-\d{2}-\d{2})...'
  parse_to: body # default
  timestamp:
    parse_from: time
    ...

operators:
- type: regex_parser
  regex: '^Time=(?P<time>\d{4}-\d{2}-\d{2})...'
  parse_to: attributes # default
  timestamp:
    parse_from: attributes.time
    ...

Replace usages of restructure operator
The restructure operator has been removed. Use add, copy, flatten, move, remove, and retain operators instead.

Deprecated ExampleUpdated Equivalent

operators:
  - type: restructure
    ops:
      - add:
        field: set_me
        value: foo
      - add:
        field: overwrite_me
        value: bar
      - move:
        from: details.env
        to: env
      - remove:
        field: delete_me

operators:
  - type: add
    field: body.set_me
    value: foo
  - type: add
    field: body.overwrite_me
    value: bar
  - type: move
    from: body.details.env
    to: body.env
  - type: remove
    field: body.delete_me

Replace usages of metadata operator
The metadata operator has been removed. Use add, copy, or move operators instead.

Deprecated ExampleUpdated Equivalent

operators:
  - type: metadata
    attributes:
      environment: production
      file: 'EXPR( $$body.file )'
    resource:
      cluster: blue

operators:
  - type: add
    field: attributes.environment
    value: production
  - type: copy
    from: body.file
    to: attributes.file
  - type: add
    field: resource.cluster
    value: blue
  - type: move
    from: body.foo
    to: attributes.bar

Update filelog attribute references
The filelog receiver has adopted slightly different attribute names in order to match newly established semantic conventions. Configurations that previously refered to the file.* attributes should be updated.

Deprecated AttributeUpdated Equivalent

file.name

log.file.name

file.path

log.file.path

file.name.resolved

log.file.name_resolved

file.path.resolved

log.file.path_resolved

Note to Vendors: A log record's Timestamp field may now be nil
A recent change to the Log Data Model has redefined the usage of the Timestamp field. Correspondingly, this field is no longer initialized by default. All Log Exporters should be evaluated to ensure this change is handled accordingly.
Log exporters can use the following logic to mimic the previous funcationality (psuedocode):
timestamp := log.ObservedTimestamp
if log.Timestamp != nil {
  timestamp = log.Timestamp
}

[0.28.0] - 2022-03-28
Breaking Changes

$ has been removed from field syntax. (PR364)

Use body instead of $body or $$body.

e.g. body.foo.

Use attributes instead of $attributes or $$attributes.

e.g. attributes.["log.file.name"]

Use resource instead of $resource or $$resource.

e.g. resource.["host.name"]

There is no longer a default top-level field.

i.e. foo is no longer equivalent to $body.foo or $$body.foo. (It is invalid.)

A top-level field MUST be specified at the beginning of each field.

e.g. body.foo, attributes.foo, or resource.foo.

entry.Entry.Timestamp field is no longer required and is not initialized by default. (PR370)

The value can be set using the timestamp block on any parser, or the using the standalone time_parser operator.

Removed metadata operator. (PR429)

Use add, copy, or move operators instead.

Removed restructure operator. (PR371)

Use add, copy, flatten, move, remove, and retain operators instead.

Changed the names of attributes added by file_input operator to match new semantic conventions. (PR372)
Switch to original go-syslog library, restoring strict enforcement of SD-NAME length. (PR439)

#467 will address the unit test failures.

@open-telemetry/log-collection-approvers Please take a look. I would very much like to cut this release today in order to ensure it is in the next collector release on Wednesday.

The explanation of changes is so nice in the PR description. Can we copy it into the CHANGELOG or if we don't want to make CHANGELOG so detailed, copy somewhere else and link from the CHANGELOG?


Problem: root go.mod is outdated

this go.mod is used in some integration test I believe.

converted as a draft as the integration cannot be run without proper setting

The Go code changes are ok, but not sure about the Ethereum contract-related ones? that contract code is only used in integration tests, so should be ok or does it need extra dApp expert review?

The solidity contract is the copy paste as the one already reviewed in the solidity folder. This one is in a subdirectory of integration_tests and uses to build the ethereum docker container. Imo there is no need to extra reviewers

why are they copy-pasted / need to be duplicated or why can't the integration tests just use the ones in the solidity folder?

why are they copy-pasted / need to be duplicated or why can't the integration tests just use the ones in the solidity folder?

Yeah its maybe possible but requires some change in the project structure. The integration_tests/ethereum folder and solidity folder use different hardhat-config which both look at contracts folder to build the ABIs. Besides the gravity contract and cosmosToken contract, all the other contracts are specific to the folder tests

merging this
will update the dependencies in another PR


Error when trying to download data

I see this error on Google Drive when trying to download the data:
"Sorry, you can't view or download this file at this time.
Too many users have viewed or downloaded this file recently. Please try accessing the file again later. If the file you are trying to access is particularly large or is shared with many people, it may take up to 24 hours to be able to view or download the file. If you still can't access a file after 24 hours, contact your domain administrator."
Likewise, I am unable to download the data from the Baidu link.
Does anyone else see this error?

Me too. cant download it from the Google link.

Hi, the links for me seems normal at this time. Maybe you can specify the file(s) which have an error. Also, we recommend using the links from OpenDataLab for downloading.


[T6A3][W13-C1]Dewi Tan Jia Hui

@jessidew95
Some comments added. Please ack & close the PR after reading comments.


User cannot select VM SKU

West US 2 and now Southeast Asia have capacity limitations. It would be really powerful to have the user choose a VM SKU or have the pipeline try a few VMs if it runs into shortages.

I ran into the quota issue in WU2 earlier this month & had to increase the Total Regional vCPUs quota for the sub.
By default, the aqua processor deploys a Standard D16ads v5 (16 vcpus, 64 GiB memory), and based on my earlier tests, I have faced "Out of memory" errors during IPOPP ingestion when we select anything below the size of this VM SKU. I'm assuming this may be the reason for the dev to prefer this VM SKU as default. I'm happy to look into this further, let me know your thoughts. Thanks

Got it, thanks for the background! Perhaps just update the readme prerequisites to have the user update their quotas accordingly.


Datapack Compatibility?

I am trying to add ore veins using Minecraft's built-in datapack functions, and the mod doesn't seem to recognize them even if they're in the right directory implied by the structure of the mod's data.
Does this mod support adding ore veins with datapacks, or only via KubeJS?

Here you go!
drilling.zip
The files are loose in a global pack loader's resource folder; the full path they're located at is C:\Games\Minecraft\instances\Transylgoonia 2.0 Test\.minecraft\global_packs\required_data\progress_recipes\data\progress_recipes\recipes\drilling

The name field in the json is a text component, so you have to write "name": "{\"text\":\"Lapis Lazuli\"}",

That doesn't seem to work. The veins still do not show up.


Groups of rollups stopped working, large number of scheduled jobs

I'm so confused...
I have a set of rollups defined, using the same child triggers, and created these when I was an active user/consultant for an organization.  These were working for a long time.
My user account was deactivitated. Half of the triggers seemed to stop working - firing only after child records were deleted or modified, and inconsistently.  There was a large backlog of scheduled items, even though execution was set to realtime.
I have tried creating new rollups with new fields and same structure using the sys admin ID (they allowed me access). But no luck.  Still inconsistent behavior.  New ID has the permission sets.
Based on another post, I removed the child trigger, then reinstalled it.  Now, none of the rollup summaries are working.
Any suggestions?

@sethgolub I've not seen this before. I wonder if something about things being owned/created by your old inactive user is causing problems. I assume no users are getting error messages at this point. Could you check the Apex Jobs in setup to see if anything is running in error?
Do you have any Scheduled Apex jobs that are tied to the old user?
For next steps I would probably have Developer Console open and do what I thought should trigger the rollup, review the logs if you're familiar with how to do that and see if you can see the records being processed.

Hi Andrew,
I unfortunately am not very savvy technically.  Is there a way to identify and clear out all of the unrun APEX jobs, and then re-run.  The behavior is odd and unpredictable.  For example: when I create a new record, some of the rollups seem to run, but not others (all part of the same trigger).  When I delete the record, the ones that were not filled in suddenly appear with the values from the deleted record.  I removed and redeployed the trigger from the new ID, but now, nothing works.  The new ID is an admin, with permission sets for configuration and running.
Any inisghts appreciated.  Or, if you can tell me what to ask Salesforce support, I can do this as well.
Thanks,
Seth
From: Heber<EMAIL_ADDRESS>Reply-To: afawcett/declarative-lookup-rollup-summaries<EMAIL_ADDRESS>Date: Friday, March 15, 2019 at 7:53 AM
To: afawcett/declarative-lookup-rollup-summaries<EMAIL_ADDRESS>Cc: sethgolub<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [afawcett/declarative-lookup-rollup-summaries] Groups of rollups stopped working, large number of scheduled jobs (#801)
@sethgolub I've not seen this before. I wonder if something about things being owned/created by your old inactive user is causing problems. I assume no users are getting error messages at this point. Could you check the Apex Jobs in setup to see if anything is running in error?
Do you have any Scheduled Apex jobs that are tied to the old user?
For next steps I would probably have Developer Console open and do what I thought should trigger the rollup, review the logs if you're familiar with how to do that and see if you can see the records being processed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

There is an enhancement issue listed to improve awareness of scheduled jobs that will help (at least in part) with this in the future .


Closing constructor curly bracket will cause highlight issues

If you align the closing constructor curly bracket the highlight will break:

If you place the bracket behind the last parameter everything works fine:

I would like to see this fixed too.

Its a problem with the Decorator/Annotations, if you remove them everything works fine

Hi,
Thank you for the report.  Sorry it took so long to reply.
The atom-typescript plugin uses a grammar that is maintained by Microsoft.  Please report this issue here: https://github.com/Microsoft/TypeScript-TmLanguage/issues
If/when the issue is fixed there, please let us know and we will pull down the latest grammar.
Thanks.

Looks like it's fixed to me. Let us know if you see otherwise.


When I'm doing my normal, everyday Tabloid coding (thanks for the input function btw!), I often run into issues that I simply can't seem to debug. Why? Well, because lots of my Tabloid code seems to have syntax errors of some kind, and the output given simply doesn't help. For example:
EXPERTS CLAIM D TO BE 1
DISCOVER HOW TO F WITH V
    WHAT IF D IS ACTUALLY 1
        SHOCKING DEVELOPMENT 0
    EXPERTS CLAIM D TO BE D MINUS 1
    SHOCKING DEVELOPMENT F OF 1
EXPERTS CLAIM O TO BE F OF 1
YOU WON'T WANT TO MISS O
PLEASE LIKE AND SUBSCRIBE

errors with  TypeError: node.exprs is undefined. However, if D is set to be 2 at the start, the error changes to [object Object], which I am fairly certain is not the intended error message. Another one that doesn't make sense to me:
DISCOVER HOW TO func WITH param
    EXPERTS CLAIM var TO BE param
    WHAT IF var IS ACTUALLY 1
        SHOCKING DEVELOPMENT 1
    SHOCKING DEVELOPMENT 0

PLEASE LIKE AND SUBSCRIBE

gives Error: Runtime error: Undefined variable "var", despite var being declared in the function, and the function never being run.
I would recommend making the erroring system more robust and/or adding some kind of debugging function (perhaps WHAT'S GOING ON?) that provides more verbose error messages to help figure out what the issue is. Alternatively, adding line numbers to errors may be enough to figure out what's going on in most cases, although I'm not sure if that's feasible post-preprocessing.
Also, if you happen to know what any of the above problems happen to be, I'd love to know.

So... this is where I expected no sane person to actually try to write anything in Tabloid, so I didn't care to add in any error messages, haha.
My first response is that the error in both those examples are the same: Tabloid is not whitespace-sensitive, so you indicate multi-line (multi-expression) blocks by wrapping them in RUMOR HAS IT...END OF STORY (a block scope).
So for example, your example 1 works if we write instead
EXPERTS CLAIM D TO BE 1
DISCOVER HOW TO F WITH V
RUMOR HAS IT
    WHAT IF D IS ACTUALLY 1
        SHOCKING DEVELOPMENT 0
    EXPERTS CLAIM D TO BE D MINUS 1
    SHOCKING DEVELOPMENT F OF 1
END OF STORY

EXPERTS CLAIM O TO BE F OF 1
YOU WON'T WANT TO MISS O
PLEASE LIKE AND SUBSCRIBE

My second response is that I don't really intend on adding a bunch of debugging facilities to Tabloid as-is because... well it's not meant for writing real programs. That said, I think the language implementation is pretty simple and readable if you want to be adventurous and add some error-throwing logic with more helpful messages where errors are detected.
I wrote this language in a hurry so the parser doesn't keep track of span information (which we need to report line numbers with errors). To add it I think would be a nontrivial task, even for me.
I am curious what you're trying to make with this though :eyes:

Sounds good! I might fork it and look into writing some error-throwing logic myself. Thanks for your answer as well.
As for what I'm trying to make with it, those came up as I was working on a primality checking program, so that it would count as a valid language for PPCG. After that, it could potentially be used for some challenges, with its output constraints making it... very interesting to work with.

Gonna close this due to inactivity; if you or anyone else ends up working on it, do reopen:)


Maximized windows can not be moved

Repros on some applications. ie. Chrome and vs code

Needs to un-maximize first?

Fixed in #14


Ability to select tasks using a shortcut

Usually tasks are identified by long names like "do_something_on_this", "build_documentation". Thankfully we have tab-completion that makes it less annoying to build the command line...
I think it would be nice to have another, possibly quicker even if mnemonic way to select a task, once you know its name: what about being able to say doit dsot or doit bd to run the hypothetic tasks mentioned above?
An initial, proof-of-concept implementation is lelit/doit@a540533fcaa83d6c7560e2940c4cbc6ad6bfc731

I dont see much people being interested on this. But I might be wrong... and even if you are the only interested on this, you should be able to achieve this without forking doit.
Can you implement this by modifying the run command instead of making changes into control.py? If you change the run command you could use/enable your custom command as a plugin.
If this ever gets merged it will need to be enabled by command line param (not enabled by default).
Once I thought about implementing something like py.test keyword selection with -k.
Another option for you is to create alias tasks manually, just create a task with no action and a task_dep to the task be aliased.
So I suggest you pursue this as separate command plugin. Once you get it, I might re-consider bringing the changes into doit core. Just keep me updated...

No problem, I'll try to understand what you are suggesting. Otherwise I will try to get there by monkey patching doit, hopefully from within my dodo.py.
I implemented the very same mechanism on top of paver, and the users were quite happy of it. Paver has a TaskFinder component that one can easily inject into the system.

Look at this: http://pydoit.org/extending.html#command-customization
You can create a new command by sub-classing the existing CmdRun. Wrap the _execute() method adding the tasks aliases, then call the original CmdRun._execute(). Should be easy :)

Thank you, will try!

Is there a way, for a task, to forward command line arguments to the task_dep tasks?

Is there a way, for a task, to forward command line arguments to the task_dep tasks?

No. I guess I gave you a bad suggestion...
I have another (better) idea. Subclass cmd_run.py:Run class and overwrite the method _execute():

go through self.task_list and create your list of abbreviations/shortcuts
replace any abbreviations found in self.sel_tasks
call original Run._execute()

In other words, you will just process and modify the user input so that it looks like a "normal" input with full task names. what do you think?

For the record, I opted to create a simple bash alias to implement the functionality I need:
function dt() {
    local shortcut=$1
    local helpopt=$2
    local expr_rx=$(echo $shortcut | sed 's/\(.\)/\1[^_]*_/g')
    declare -A seen
    shift
    doit list | while read papabile helpdoc
    do
        case $shortcut in
            list)
                local alias=$(echo $papabile | sed 's/\(.\)[^_]*_*/\1/g')
                if test -z "${seen[$alias]}"
                then
                    echo -e "$alias, $papabile\n\t$helpdoc\n"
                    seen[$alias]=t
                fi
                ;;
            *)
                if test "$papabile" = "$shortcut" -o $(expr "$papabile" : "$expr_rx*") -gt 0
                then
                    if test "$helpopt" = "-h" -o "$helpopt" = "--help"
                    then
                        doit help $papabile
                    else
                        doit $papabile $*
                    fi
                    seen[$papabile]=t
                    break
                fi
                ;;
        esac
    done
}
complete -F _doit dt

It customizes the list command, showing something like
$ dt list
db, dc_build
	Rebuild needed containers.

de, dc_execute
	Execute an interactive command within a running container.

gacru, git_auto_commit_ref_updates
	Automatically commit submodules ref changes.

and understands an handy alternative to help:
$ dt gacru -h
git_auto_commit_ref_updates  Automatically commit submodules ref changes.
  -n, --dry                 Do not actually run the task, just show what would happen
  -i, --ignore-dirty        Ignore dirty submodules

cool. Although I cant say I understand your bash script...
Does it work completely without any change in doit code?
Do you have this in a separate repository?
Feel free to add link to this somewhere in the docs (submit a PR) or the wiki

Yes, it does not require any changes to doit.
It works by parsing the output of doit list: with a simple sed script it computes a regular expression that matches only the initial letter of a underscore-separated-list-of-words; if that matches one of the task names, it executes it passing all the remaining arguments when the second argument (that is, the one right after the task name) is not either -h or --help: in such case it executes doit help original_task_name.
I will add it to the wiki.

Eduardo, I created a new page as requested: is it good enough?

that allowed me to say paver ddfm as an alias for paver do_that_for_me

I guess you mean paver dtfm, notice a T in the second letter.
Looks good to me. Although I would cut the history and go straight to the point without mentioning paver or the original ticket number (at least in the beginning of the text).
I would also add a link to this page from the page that has a list of projects (https://github.com/pydoit/doit/wiki/powered-by-doit)
thanks


Versions

Versions are very inconsistent.
VERSION says 0.1.0.
gemspec says 0.1.3.
rubygems has 0.1.4 listed.
I have submitted a PR to the eventbrite repo to update HTTParty, but I have no idea if the code there is the latest, because of this confusion. Who is maintaining this project now?

Sorry, I've stopped development on this project.
It targets an older version of the Eventbrite API, so it's mostly just around for historical purposes.  I'd ask the Eventbrite team if they have a newer API client lib or SDK that they can recommend.

OK, thanks for letting me know!


Sending coin is not working on testnet

Checklist

[x] You've tried latest version of SushiChain
[x] You've confirmed there is not a same report

Description
I tried to send coin with the testnet node, recipients receive the coin but senders loose not the coin.

The last commit: https://github.com/SushiChain/SushiChain/commit/b7c42a84c86da7e111d0d2cf2d60a2fa0ea17c18

Environment
I'm running on Ubuntu 18.04.3 LTS

Using docker: no
Crystal version: 0.30.1
Where do you connect to? http://testnet.sushichain.io:3000

Command Lines and results
christian@y510p:~/workspace/sushichain/bin$ ./sushi tx create -m 9.14662766 --token=SUSHI -a VDA1YWQzNjdmZjYxZGY1MGRjOTJlMmVmNWFkOTAwYjJiMzc2ZjEwMGE4YzZjNzk5 -f 0.0001 -n http://testnet.sushichain.io:3000 -w encrypted-wallet_testnet.json --password=test
successfully create your transaction!
=> 14cce5c3ecd74650324fc5e36c59542a9c323e589a0b7c67c8360b59b395e257
christian@y510p:~/workspace/sushichain/bin$ ./sushi wallet amount -n http://testnet.sushichain.io:3000 -w encrypted-node-wallet_testnet.json --password=test

  showing amount of each token for VDA1YWQzNjdmZjYxZGY1MGRjOTJlMmVmNWFkOTAwYjJiMzc2ZjEwMGE4YzZjNzk5.
  confirmation: 1

  + -------------------- - -------------------- +
  |                token |               amount |
  | -------------------- | -------------------- |
  |                SUSHI |        1643.89792226 |
  |                 GAME | -92233720019.09551616 |
  + -------------------- - -------------------- +

christian@y510p:~/workspace/sushichain/bin$ ./sushi wallet amount -n http://localhost:4000 -w encrypted-wallet_testnet.json --password=test

  showing amount of each token for VDA0NDA3ZmU3OTZjMjkwMTNhMmFlOWQyOGIwOTBkY2UyMGIyMGE2MjdmNzBhZGI1.
  confirmation: 1

  + -------------------- - -------------------- +
  |                token |               amount |
  | -------------------- | -------------------- |
  |                SUSHI |        4859.14662766 |
  |                 GAME |<PHONE_NUMBER>8 |
  + -------------------- - -------------------- +

When tried to reproduce this situation with a local new chain, everything works as expected.
The only thing is that on testnet this exception ariseInvalid packet opcode: 5:
[ 2019-08-17 10:56:10 --    Info ] UPDATED BLOCK: 333 at difficulty: 12
[ 2019-08-17 10:56:11 --    Erro ] Invalid packet opcode: 5
[ 2019-08-17 10:56:11 --    Erro ] /home/christian/opt/crystal-0.30.1-1/share/crystal/src/http/web_socket/protocol.cr:0:7 in 'read_opcode'
/home/christian/opt/crystal-0.30.1-1/share/crystal/src/http/web_socket/protocol.cr:151:5 in 'read_header'
/home/christian/opt/crystal-0.30.1-1/share/crystal/src/http/web_socket/protocol.cr:108:7 in 'receive'
/home/christian/opt/crystal-0.30.1-1/share/crystal/src/http/web_socket.cr:106:16 in 'run'
src/core/node/components/chord.cr:87:9 in '->'
/home/christian/opt/crystal-0.30.1-1/share/crystal/src/fiber.cr:255:3 in 'run'
/home/christian/opt/crystal-0.30.1-1/share/crystal/src/fiber.cr:47:34 in '->'
???
[ 2019-08-17 10:57:59 --    Info ] UPDATED BLOCK: 334 at difficulty: 12
[ 2019-08-17 10:59:49 --    Info ] UPDATED BLOCK: 335 at difficulty: 12
[ 2019-08-17 11:01:55 --    Info ] UPDATED BLOCK: 336 at difficulty: 12
[ 2019-08-17 11:03:45 --    Info ] UPDATED BLOCK: 337 at difficulty: 12
[ 2019-08-17 11:05:37 --    Info ] UPDATED BLOCK: 338 at difficulty: 12
[ 2019-08-17 11:07:34 --    Info ] UPDATED BLOCK: 339 at difficulty: 12

This value is incorrect for the Game token: -92233720019.09551616
we should never see a negative number
as far as the Opcode I think it's not the cause of the issue - I think the Game token creation with a negative number is the main issue.
For the Opcode:
WS client is not conforming to the WS protocol. You are getting this error when Server expecting Termination request, but WS client sending different Opcode
Which I don't think should have affected the transactions

This is the server side opcode error for reference:
Unhandled exception on HTTP::Handler
Invalid packet opcode: 6 (Exception)
  from /usr/share/crystal/src/http/web_socket.cr:141:9 in 'run'
  from /usr/share/crystal/src/http/server/handlers/websocket_handler.cr:43:9 in 'call'
  from /usr/share/crystal/src/http/server/request_processor.cr:39:11 in 'process'
  from /usr/share/crystal/src/fiber.cr:255:3 in 'run'
  from ???

Fixed


Using seccomp with native driver

Are there plans to be able to use seccomp filters with the native driver in the future?
# docker run -h 2>&1 | grep lxc
  --lxc-conf=[]              (lxc exec-driver only) Add custom lxc options --lxc-conf="lxc.cgroup.cpuset.cpus = 0,1"

I believe we now have this


Ability to have workshop targeting nodes based on labels

In a scenario where a user might want to use a big fat cluster for educates, but having a diverse typology of workshops, there's the need to, in order to optimize capacity usage of the cluster, to be able to target specific nodes based on labels. This way, when creating the cluster, many different nodepools can be created, with different node types and properly labeled, so that workshops can land in machines optimized for the workshop type.

After having been investigating GKE I have found how they do workload placement based on 2 strategies:


Update sql-server-linux-availability-group-overview.md

Please add me as an author since I wrote this :)

@allanhirt : Thanks for your contribution to the SQL documentation! The author, @MikeRayMSFT, has been notified to review your proposed change.

@allanhirt Thank you for authoring the content and submitting this pull request.
#sign-off

Only the author of the article can use the sign off comment to add the ready-to-merge label.

Thank you @allanhirt and @MikeRayMSFT


pace.js breaks authenticaiton flow in blazor

The default authentication flow breaks, when you reference pace.js library - see https://stackoverflow.com/questions/65658769/blazor-wasm-stuck-on-authorizing-and-completing-login for details. If that's something you're interested to look into, I could try to replicate the issue in an open source project

The default authentication flow breaks, when you reference pace.js library - see https://stackoverflow.com/questions/65658769/blazor-wasm-stuck-on-authorizing-and-completing-login for details. If that's something you're interested to look into, I could try to replicate the issue in an open source project

Hi @pgrm,
If you could, it would definitely be appreciated.


Minor typo correction

Minor typo correction where needed: loose to lose

Actually, better edit the commit text to something more specific. Like user guides: fix typo in multisig-messaging-system.md

Actually, better edit the commit text to something more specific. Like user guides: fix typo in multisig-messaging-system.md

Raised https://github.com/monero-project/monero-site/pull/1445 with improved commit message, closing this pull request.


Implement GitLab merge requests

Implements a function to count open Merge Requests that are assigned to the Personal Access Tokens user.
(And by implemented, I mean heavily borrowed from GitLabTodos of course 🙈 )
Waiting for #65 to be merged so I can finish up the documentation.

@gl-njanz previous PR merged! Feel free to finish the documentation!
Let me try to prepare a few different images for the MR count

haveMRsImage

haveMRsImage@2x

noMRsImage

noMRsImage@2x

Thank you for the images @SantiMA10
GitLab has recently rebranded, here's the new logo: https://about.gitlab.com/press/press-kit/

I drafted some icons. I dropped the "MR closed" badge from the noMRsImage.
The intention behind it was to simplify the iconography, while also increasing the visibility when something needs your attention. Hope that's OK

@gl-njanz Thanks for the new feature, I will update the other GitLab images and then send the update to the elgato store! 🚀

Apologies for the ping @SantiMA10, have you had time to push the update?

Ups, I totally forget about it @gl-njanz 🤦
Sorry for the delay, I will send it to elgato this week


Add a security policy

Hey there!
I belong to an open source security research community, and a member (@rohit75033) has found an issue, but doesn’t know the best way to disclose it.
If not a hassle, might you kindly add a SECURITY.md file with an email, or another contact method? GitHub recommends this best practice to ensure security issues are responsibly disclosed, and it would serve as a simple instruction for security researchers in the future.
Thank you for your consideration, and I look forward to hearing from you!
(cc @huntr-helper)

👌


feat(v1): v1 of the library

BREAKING CHANGE

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Twitch configuration wizard

As a user, I want to be able to login to my Twitch account or my Twitch bot's account and configure TagzApp

Fixed with #405


JSON import/export of rule set

Hey, awesome extension!
One thing that would be a neat feature to have is JSON import/export for the rule set. Even better would be if I can import my rules from the Firefox Redirector addon directly.
A sample is here:
https://gist.github.com/d6a8137e7bf8c837b64621a3a1f9b9b9#Redirector.json

I just had a look at the normal files that are exported and noticed they are already JSON containers. I might just make a small script to convert from Redirector to this.

Oh wow, fantastic! In that case I'll close this issue, thank you.


Add a correction service to dspace to enhance the data quality (was Enrich local data via the OpenAIRE Graph)

References

Related to https://github.com/DSpace/RestContract/pull/181
Related to https://github.com/DSpace/dspace-angular/pull/1562

Description
The features included in this PR are the result of the OpenAIRE Call Innovation funded project "Enrich local data via the OpenAIRE Graph” awarded by 4Science (https://www.openaire.eu/open-call-winner-phase-1-4science). It provides a closer integration between DSpace and two OpenAIRE services, the Notification Broker and the OpenAIRE REST API.
Detailed documentation about the aims of the project, the implementation and the configuration options is available at https://4science.github.io/oaire-eld/#/
This PR regarding only the data correction section. The publication claim will be migrated with other PR.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

[ ] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
[ ] My PR passes Checkstyle validation based on the Code Style Guide.
[ ] My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
[ ] My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
[ ] If my PR includes new, third-party dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[ ] If my PR modifies the REST API, I've linked to the REST Contract page (or open PR) related to this change.

Moving this PR to 7.4 as it won't be possible to review/approve in time for 7.3.   We'll instead work to get this merged just after the 7.3 release.

@LucaGiamminonni and @abollini and @atarix83 :  I tried testing this (and the frontend PR) again today after watching the video demo from @corrad82-4s at https://youtu.be/clfUahYlHt4
Unfortunately, I'm still unable to figure out how to import data/events from OpenAIRE in order to get some sample data to work with. This is the same issue I reported previously in September. I feel like I must be missing something, but I don't see a service that pulls down these events from OpenAIRE.  (I expected to see an API key or similar which allows me to contact the OpenAIRE API in order to pull down notifications.)
The closest I've found is the ./dspace import-openaire-events script, which appears to have two options:

Import from a JSON file
Or, using an email address attempt to pull data down from the OpenAIRE Public Broker API.

The first option (JSON file) is confusing to me, as I don't know where to obtain a realistic/valid JSON file.
The second option looks promising, but it doesn't appear to work -- I don't know how to obtain access to the OpenAIRE Public Broker API via my email address. Every time I attempt to import data, I get this in the logs:
2022-12-21 22:23:04.562 INFO import-openaire-events - 1 @ Trying to read the QA events from the OPENAIRE broker
2022-12-21 22:23:05.925 INFO import-openaire-events - 1 @ Found 0 subscriptions related to the given email

Is there some sort of signup form with OpenAIRE?  How are institutions supposed to configure this when it's used in Production scenarios?
I've read the documentation at https://4science.github.io/oaire-eld/ to look for clues. But, it seems to imply that the only way this works is via the JSON file?  Is that correct?

As the OpenAIRE Content Provider Dashboard doesn't allow yet to create a subscription setting up a callback mechanism, we agree with the OpenAIRE team to read the data generated by openAIRE's Notification Broker Service from a JSON file postponing to the last phase of the project the discussion and the implementation about the delivery mechanism (polling new versions from a stable URL, receive it as payload of a repository URL, etc.).

So, I'm wondering how this is supposed to work in Production scenarios?  Are institutions supposed to somehow ask OpenAIRE for a JSON file of possible updates & import the JSON data manually? Or is there some way to signup via an email address & setup a regular import (via a cron job or similar) using that email address?
I need some clear instructions on how to test this with real data before I'll be able to proceed.  I also need a clearer understanding of how OpenAIRE event data is expected to be imported into a Production site, as this doesn't appear to be documented anywhere.

Hi @tdonohue ,
thanks for your willing to help this moving ahead.
I expect that @paulo-graca  can help here in making test with some real data about Portugal repositories.
There are two ways to load events in the system as you noted via the ./dspace import-openaire-events

providing directly a JSON file
having the system to retrieve the JSON file for you using your email address

To use "your  email address" you need to be a registered repository manager that contribute data to openaire, i.e. an user of the OpenAIRE content dashboard. You can get more information here https://www.openaire.eu/content-enrichment-guide
When an email is provided the ./dspace import-openaire-events use the tool provided directly by the openaire team (https://github.com/openaire/broker-cmdline-client ) to download the JSON file, it was intended as a shortcut / convenient tool for the dspace managers that don't need in this way to perform the two steps manually.
The structure of the JSON file is very simple, you can find examples in the test source code
dspace-api/src/test/resources/org/dspace/app/openaire-events/
an example of JSON file containing real sample events retrieved for the University of Trieste Repository that has partecipated in the first ELD project as pilot can be found here https://4science.github.io/oaire-eld/#/data-correction?id=data-source
https://4science.github.io/oaire-eld/_media/nbevents-sample.json

@abollini : Capturing some notes from today's Dev meeting.

Disable by default: Until now, it was unclear to me that this feature required an OpenAIRE account.  I had assumed you likely needed to register for a simple access key or similar (like other "external sources" in DSpace).  But, I didn't realize that you needed to have access to the OpenAIRE "Portal" in order to manage data, etc.  While it's not an issue to require sites first have an OpenAIRE account established for this feature, that implies we must disable this feature by default (at least until this feature supports additional providers alongside OpenAIRE).  By default, this feature cannot be used by many DSpace sites, so it must be disabled by default.

To be clear, though, it's OK with me if the database infrastructure exists by default.  However, the REST API endpoints & UI should be "turned off" until enabled via a configuration or similar.  (This is similar to how the Configurable Entities database structure exists by default, but isn't used until you enable Entities.)

Better test data / instructions:  In order to ensure other Committers (self included) can maintain this code, we need to have test data which others can use to verify the functionality.  The dspace-api/src/test/resources/org/dspace/app/openaire-events/ directory you mentioned only has very minimal examples with no documentation:

empty-events-list.json and empty-file.json are both empty JSON files
unknown-topic-events.json is an invalid file used to test errors.
events.json has the only examples and there are just two provided.  However, it's unclear how to customize them for local testing.  For example, what do each of the JSON fields mean and how can we tell if the JSON file is valid?  What are valid topic settings? Only two examples ENRICH/MISSING/ABSTRACT and ENRICH/MORE/PROJECT are provided.  How would we use this file to run a local test?
At the very least, I think we'd need a README or similar to document the JSON format (or provide links to where this format is documented by OpenAIRE).  It should also provide Committers with more examples of valid "events" that may be sent from OpenAIRE.  Currently, we only have examples of two events types... adding a missing abstract and adding an additional project.  But, we don't have examples of these other event topics in this PR.  It looks like many other event topics exist in https://4science.github.io/oaire-eld/_media/nbevents-sample.json, but those other examples do not exist in dspace-api/src/test/resources/org/dspace/app/openaire-events/

Without better testing documentation, I don't have a way to thoroughly test or review this code.  It's not clear to me how to create a test JSON file for my local data (e.g. I'm not sure how to even modify the example JSON files to work against local data...presumably I have to modify the "originalId" field, but I don't know the format of that field).  So, unfortunately, I cannot help move this PR forward without details on how to test it manually.  I'd recommend adding these testing instructions to the description of this PR so that they are easy for other Committers/reviewers to locate as well.

FWIW I will drop a couple of ideas that went through my mind during the discussion yesterday.
Would it be useful to create a dummy service and a provider that talks to it, for testing the common enrichment code?
To test the OpenAIRE Graph provider, would it be useful? possible? to provide a tool that will create proper JSON with local data?

Sorry for the absence of my feedback on this PR, I would like help to bring this feature into DSpace, but lately I've being swamped with local stuff and internal projects.
I also agree with Tim, this feature should be inactive by default, only the installations that have this OpenAIRE account should activate the feature. In the following week I will review this feature and try to test it based on some of our hosted repositories instances.
I also agree with Mark, there should exist some kind of form to test this. And also this kind of new feature - quality assurance -  perhaps not the scope of this PR, but a generic purpose quality assurance implementation (based on another service, available to the world)

All notes are now attended.
At the DSpace demo there's a video demonstrating all the 5 event' types submitted. Direct link to the video.

@tdonohue the CodeQL alert can be dismissed as it is not relevant in this case as the MD5 algorithm is only used to generate a shorter unique ID based on business values. Do you know how is it best to proceed? should we dismiss using the option on the alert dialog or should we put some annotation on the code (do you know which ones?) to inform the scanner?

I quite like the idea of a correction service, and believe we have a use case separate from using the OpenAIRE Graph. I can try to help review this PR... There's a lot of discussion above, but, from my skim, I think Luca has resolved the feedback and this PR is ready for testing?

Hi, I tried to test the Quality assurance (Data Correction) notification but got a blank page when trying to access the notification page (admin/notifications/quality-assurance). I get the following error when inspecting the page:

I am using the Docker env (fresh install as described in Testing DSpace 7 Pull Requests). I checkout both PRs (front 1562 adn backend 8184) and rebuild both UI and backend. I then connect using the default admin account. Anything I made wrong? I do see the menu :

But the page is simply just not loading. Thanks!

I'd like to take a look at a few more things:

would you screenshot the Network tab of your browser? Like this:

the backend application should give us more details about the call above: can you provide us the backend log file? it should be a dspace.log file:

on the local.cfg file (backend side) did you set or overwrite a key called qaevents.sources? If so please share its value;

the suspected http call is pointing to the following url: _http://localhost:8080/server/api/integration/qualityassurancesources?page=-1&size=5&sort=name,ASC_   Can you provide a screenshot of the "The HAL Browser" of that call? It should be accessed through the following url: http://localhost:8080/server/#http://localhost:8080/server/api/integration/qualityassurancesources?page=-1&size=5&sort=name,ASC    (replace localhost:8080 with the backend url and port you are using for the test) I expect a result similar to the one below:

We have updated docker-compose.yml configuration by adding new qaevents collection description. Could you please give it a try? Thank you.

Hi @frabacche, I made a quick test. I only checked out the backend PR to see if the solr Core qaevent was created. Once I check out the PR, the docker compose file contains the qaevent core lign:

I also see a new folder for the core index:

When I rebuild DSpace, start the Docker backend containers, and look at SolR admin page, the new qaevent core index is not listed:

Is there something I have not done? Do I need to run a command to build the index?
Thanks!
Pierre

Hello @pilasou
we just noticed another configuration file for Solr Collection creation on Docker. We just fixed it. Would you kindly give it another try? Thank you.

Hi @frabacche, i gave it another try but without success. Here is what I have done: run   "gh pr checkout 8184" command to obtain the lastest changes you made, then stard docker and use "docker-compose -f docker-compose.yml -f docker-compose-cli.yml build" command to rebuild backend. I then start the backend Docker containers (dspace, dspacedb and dspacesolr). I went to solr admin page but the core are still the default 4:

@tdonohue for Docker to correcly create the new solr collection named qaevent we modified the following files:

dspace/src/main/docker/dspace-solr/Dockerfile
docker-compose.yml
but it seems it is not enough. Do you have any suggestions?

I've added comments about 3 small changes.
I would like to test the improvement with real notifications from the OpenAire Broker, but I see that despite having recently subscribed to the notifications, I have to wait for the Broker to generate them. As soon as I have new notifications I will try to do tests and report the results.

Hi @toniprieto - thank you for your suggestions The 3 changes you kindly asked have been just pushed.

hello @tdonohue are there any news about the merge? Thank you

@frabacche : My apologies, but this PR (and the other you asked about) are waiting on final approval/testing before they can be merged.  I plan to spend time with them both after the 7.6.1 release gets finished...and the goal is to get 7.6.1 released hopefully next week, assuming final reviews of bug fixes go well.

Github insists there's a requested change that remains, but from the looks of things, all requested changes have been made. I will test this code today.

I can confirm that this PR's code builds fine, and the required Solr core is present (in testing with Docker-Compose, it's visible here: http://localhost:8983/solr/#/~cores/qaevent ) I'm at a loss for how to further test this code. I'll watch the video and see what I can figure out.

Hi @hardyoyo, I have been re-trying (docker install from scratch), and I can also see the SolR CORE qaevent index now...but for a reason I don't understand, the DSPace Container is not starting properly...For testing purposes, I have prepared a json file with 3 changes: on DOI, on PMID and on abstracts for 3 documents that are in the DSpace docker data. Hope it will help!
test-nbevents-sample - Copie.json

I can confirm this PR starts fine with Docker-Compose, with the necessary Solr core (qaevent) loaded in Solr. The tests run fine, and the backend service seems to run without any noticeable error. I still don't know how to test this with the related front-end change. I'll watch the video demo and see if I can figure it out.

@hardyoyo, maybe I can help for the test. 4sience has provided a detailed page on how this feature would be implemented (https://4science.github.io/oaire-eld/#/data-correction). Some information on it may be outdated but it helps understand how to test things. For now, only the Data collection part has been implemented. The Publication claim is not implemented yet. The json file I provided in my previous comment (https://github.com/DSpace/DSpace/pull/8184#issuecomment-1806144812) should be used to simulate OpenAIRE broker service events. The sample file I built contains 3 different event: 2 on identifier (DOI, Pubmed ID) and one to add an abstracts. I think the json file can be imported using a qaevent curation task when connected as admin.
Once the file has been loaded the 3 events of the sample file should appear in the Admin UI Quality Insurance section. At least, that's what I understood...

hi @tdonohue see below feedback for each point of the 11 you wrote above:
1 we are working on it. there’s a ticket for that
2 we are working on it. there’s a ticket for that
3 we are working on it. there’s a ticket for that
4 we are working on it. there’s a ticket for that
5 Ignore means we only ignore the message, despite Reject means we ignore the message and also send a notification about that to the external provider
6 we can sort it with no restrictions: would it be ok to sort alphabetically?
7 openaire is just a source and we might have different sources
8 the configuration with all the listed topics is into dspace/config/spring/api/qaevents.xml; about the .doi, it's currently commented so it can be enabled. Should we enable it by default - removing the comment?
9 we are working on the qa enabling system and will provide a solution

@frabacche : Thanks for the updates.  That all seems reasonable.
To respond to your question about sorting of the "Current Topics" on the initial "Quality Assurance" page (/admin/notifications/quality-assurance/openaire).  I'm OK with this being sorted alphabetically.  (Honestly any sort is fine, I just expect them to have a consistent ordering.)

@frabacche: I took a look at the updates to this PR today.  Overall, it looks good now.  However, I still had questions about the BrokerClientFactory and BrokerClientFactoryImpl, as they seem specific to the OpenAIRE Broker service (and both classes even import the OpenAIRE Broker API).
So, I still feel like they should be renamed to OpenaireBrokerClientFactory unless there are plans for a different BrokerClientFactory implementation.  If there are plans for a second BrokerClientFactory implementation, then we may want to consider changing the name "Broker" as that is the name of the OpenAIRE service.  Maybe it should instead by QAEventClientFactory?
Beyond that class rename, I'm basically a +1.  But, before I approve, I'm waiting for the Frontend PR feedback to be addressed (including the minor bug/accessibility feedback), so that I can retest this backend again with the updated frontend.

Merging, as this has a +1 from myself, and a prior +1 from @paulo-graca .  I've also verified that all of @paulo-graca 's feedback appears to be addressed except for the small note by @abollini that a refactor of the qaevents.xml will be coming later.
Thanks to @frabacche , @LucaGiamminonni and the entire 4Science team for their hard work on this new feature!

@abollini , @frabacche , @LucaGiamminonni :  A friendly reminder that, now that we have an 8.0 Documentation space, it'd be good to also start moving over / creating some Documentation for this new feature at https://wiki.lyrasis.org/display/DSDOC8x


refractor: improving website's inconsistant import alias ('../') to a streamline perfect alias ('@/') to reduce the complication and easy to understand.

###Summary:
In this I improved the import alias used in website. Previously ("../") syntax is been used at most of the places but I replaced this with ("@/") syntax, that will reduce the complication to understand the import dir as well as make it easier to understand the codebase and doesn't conflict or throw errors when replacing the files from one directory to other.
Thanks

Hey 👋 ,
This PR seems to modify more than just paths.
Did you use the branch in #1742 as a base?

hey @nhedger , Yeah, I just created a new PR , I dont know why it started from the previous one. 🙂. Just closed it to start a fresh one, Can you please assist how do I create a fresh PR without following this one, Dont judge me by this stupidity 🙂😅


Bug with latest Polars Version

TypeError: 'bytes' object is not callable

Polars fixed this, release pending


vgpu-monitor panic

The template below is mostly useful for bug reports and support questions. Feel free to remove anything which doesn't apply to you and add more information where it makes sense.
1. Issue or feature description
vgpu-monitor panic like:
I0524 07:18:41.241050  580468 metrics.go:324] Initializing metrics for vGPUmonitor
I0524 07:18:41.241133  580468 pathmonitor.go:159] server listening at [::]:9395
I0524 07:18:46.364588  580468 pathmonitor.go:126] Adding ctr dirname /usr/local/vgpu/containers/2b1034f8-6043-4a75-a8b2-81186aea4c6d_neko-notebook in monitorpath
I0524 07:18:46.364614  580468 pathmonitor.go:56] Checking path /usr/local/vgpu/containers/2b1034f8-6043-4a75-a8b2-81186aea4c6d_neko-notebook
I0524 07:18:46.364672  580468 pathmonitor.go:126] Adding ctr dirname /usr/local/vgpu/containers/5c8316be-0c88-479c-85fc-475f3874d05f_stable-diffusion in monitorpath
I0524 07:18:46.364675  580468 pathmonitor.go:56] Checking path /usr/local/vgpu/containers/5c8316be-0c88-479c-85fc-475f3874d05f_stable-diffusion
I0524 07:18:46.364840  580468 pathmonitor.go:83] getvGPUMemoryInfo success with utilizationSwitch=1, recentKernel=2, priority=1
I0524 07:18:46.364871  580468 pathmonitor.go:126] Adding ctr dirname /usr/local/vgpu/containers/ac28ea1c-3f9e-40cd-ae86-034722d70f0f_dataset-loader in monitorpath
sizeof= 1197896 cachestr= 1 2
I0524 07:18:46.364873  580468 pathmonitor.go:56] Checking path /usr/local/vgpu/containers/ac28ea1c-3f9e-40cd-ae86-034722d70f0f_dataset-loader
sizeof= 1197896 cachestr= 1 2
I0524 07:18:46.365207  580468 pathmonitor.go:83] getvGPUMemoryInfo success with utilizationSwitch=1, recentKernel=2, priority=1
I0524 07:18:46.365239  580468 pathmonitor.go:126] Adding ctr dirname /usr/local/vgpu/containers/f41d2f6f-fc03-487f-8e7a-cf14ee5ec701_pytorch in monitorpath
I0524 07:18:46.365252  580468 pathmonitor.go:56] Checking path /usr/local/vgpu/containers/f41d2f6f-fc03-487f-8e7a-cf14ee5ec701_pytorch
unexpected fault address 0x7f74bc5ae73c
fatal error: fault
[signal SIGBUS: bus error code=0x2 addr=0x7f74bc5ae73c pc=0x16219b1]

goroutine 58 [running]:
runtime.throw({0x1a7037b?, 0x7f74bc48a000?})
	/usr/local/go/src/runtime/panic.go:1077 +0x5c fp=0xc00028fb48 sp=0xc00028fb18 pc=0x448cfc
runtime.sigpanic()
	/usr/local/go/src/runtime/signal_unix.go:858 +0x116 fp=0xc00028fba8 sp=0xc00028fb48 pc=0x45ee36
main.mmapcachefile({0xc0007ec080, 0x72}, 0xc00028fd68)
	/k8s-vgpu/cmd/vGPUmonitor/cudevshr.go:146 +0x151 fp=0xc00028fc90 sp=0xc00028fba8 pc=0x16219b1
main.getvGPUMemoryInfo(0xc00028fd68)
	/k8s-vgpu/cmd/vGPUmonitor/cudevshr.go:154 +0x31 fp=0xc00028fcc0 sp=0xc00028fc90 pc=0x1621b51
main.checkfiles({0xc0007e6230, 0x47})
	/k8s-vgpu/cmd/vGPUmonitor/pathmonitor.go:79 +0x23b fp=0xc00028fd98 sp=0xc00028fcc0 pc=0x16255bb
main.monitorpath(0x12a05f200?)
	/k8s-vgpu/cmd/vGPUmonitor/pathmonitor.go:127 +0x3ba fp=0xc00028ff60 sp=0xc00028fd98 pc=0x1625cba
main.watchAndFeedback()
	/k8s-vgpu/cmd/vGPUmonitor/feedback.go:277 +0x91 fp=0xc00028ffe0 sp=0xc00028ff60 pc=0x16229f1
runtime.goexit()
	/usr/local/go/src/runtime/asm_amd64.s:1650 +0x1 fp=0xc00028ffe8 sp=0xc00028ffe0 pc=0x47afa1
created by main.main in goroutine 1
	/k8s-vgpu/cmd/vGPUmonitor/main.go:36 +0x137

2. Steps to reproduce the issue
I'm not sure why one of the cache file sizes is incorrect, maybe it's a version issue?
root@worker-a800-3:~# find /usr/local/vgpu/containers -name "*.cache" | xargs ls -al
-rw-rw-rw- 1 ubuntu ubuntu 1197897 May 24 06:37 /usr/local/vgpu/containers/5c8316be-0c88-479c-85fc-475f3874d05f_stable-diffusion/f2df89ca-28bd-4b23-83c0-212835ac1724.cache
-rw-rw-rw- 1 root   root   1197897 May 23 06:21 /usr/local/vgpu/containers/ac28ea1c-3f9e-40cd-ae86-034722d70f0f_dataset-loader/baaab5f6-b630-4895-bc3a-5f10a5a16cab.cache
-rw-rw-rw- 1 root   root    804681 May  8 09:23 /usr/local/vgpu/containers/f41d2f6f-fc03-487f-8e7a-cf14ee5ec701_pytorch/2aa77ef1-a879-4302-99a0-1206b30b234f.cache
-rw-rw-rw- 1 root   root   1197897 May 22 06:36 /usr/local/vgpu/containers/facba0d3-d961-4d83-a8c2-13fb4f648911_inference/b6ceaf0f-6399-460b-90a1-e7ba9fe459db.cache
-rw-rw-rw- 1 ubuntu users  1197897 May 23 09:57 /usr/local/vgpu/containers/fc54d454-00f4-4ee5-8f59-c33bca2630b0_kebe-dev/32acbce1-aa23-46bc-8096-e455d8d40de8.cache
-rw-rw-rw- 1 root   root   1197897 May 19 14:37 /usr/local/vgpu/containers/fce0818f-4ec3-44ad-b8c0-d498f75e184b_inference/15c69785-3ba4-4279-894c-f49611ef0269.cache

3. Information to attach (optional if deemed irrelevant)
Common error checking:

[ ] The output of nvidia-smi -a on your host
[ ] Your docker or containerd configuration file (e.g: /etc/docker/daemon.json)
[ ] The vgpu-device-plugin container logs
[ ] The vgpu-scheduler container logs
[ ] The kubelet logs on the node (e.g: sudo journalctl -r -u kubelet)

Additional information that might help better understand your environment and reproduce the bug:

[ ] Docker version from docker version
[ ] Docker command, image and tag used
[ ] Kernel version from uname -a
[ ] Any relevant kernel output lines from dmesg

This is because in the previous version, after community discussion, an incompatible feature was introduced. Project-HAMi/HAMi-core#4
We didn't handle this panic, simply to make it easier for users to identify the problem.
Restarting all Pods using vgpu can solve this problem.

I understand, but I think we can actually provide a solution that is compatible with older versions instead of causing the entire monitoring component to panic, which may be confusing to someone who is not familiar with this project. Maybe if such problems arise in the future, we can't handle them in this way, right?


mint PIDs for existing author BAIs

We have a feature flag to enable BAI PID minting, but we can't turn it on in prod currently for two reasons:

BAIs will start to diverge from legacy (legacy is minting more PIDs than what is exposed in author records)
the sequential approach to BAIs (J.Smith.3 is minted after J.Smith.4) makes it impossible to mint PIDs for records one by one during the migrator, as we might mint a BAI that is still to come later in the migration, causing a collision.

So we would need to have a way to have a two-step process after switching off legacy:

Mint PIDs for all existing BAIs in author records through some script/CLI.
Enable the PID minting feature flag.

The procedure should be tested on QA by turning off author disambiguation and the minting feature flag, removing all existing BAI PIDs from the pidstore, running the script then turning on minting and disambiguation again. No collisions should occur.

Tech Notes:

Enable FEATURE_FLAG_ENABLE_BAI_PROVIDER Flag.
Add new Feature Flag to disable BAI minter create method ONLY https://github.com/inspirehep/inspirehep/blob/60155f9ddc036932bb3653e11e1696ab2b4daf7c/backend/inspirehep/pidstore/minters/bai.py#L49.

Now all PIDS which are already present in records should be minted. Records without BAI should be ignored until second flag will be enabled.


Add missing using statements

Add using statements that were missing in the C# quickstart documentation. This was causing build errors.
In commit aaece61 @alexwolfmsft did the same for the asychronous code. This PR is for code example without response streaming.

#sign-off

@aahill, @eric-urban, @jboback, @laujan, @mrbullwinkle, @nitinme, @patrickfarley,
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

taking @alexwolfmsft  and @PatrickFarley sign-off as approvals and merging.


Update code to 2024 SDK release

This patch updates Crypto to the 2024 release version of CryptoKit. As with prior years, there are small tweaks to the API surface that cause this to manifest as a semver major. In this instance, the relevant change is the removal of the long-deprecated setters for the hash function block byte counts.
This is another change that meets the technical definition of a semver major, but is practically extraordinarily unlikely to manifest in an actual problem. Nonetheless, we do have to acknowledge the reality that this can break compiling code (e.g. in cases where users have defined protocols that rely on having a setter available, even though they never call through it).
To that end, this pushes Crypto up to 4.0.

cc @0xTim @ptoffy @gwynne as major downstream customers who may need to be aware of the pending semver major here.


Add e2e test job for gardener-extension-shoot-rsyslog-relp repo

/kind enhancement
What this PR does / why we need it:
Adds a job to run e2e tests for the https://github.com/gardener/gardener-extension-shoot-rsyslog-relp repo
Which issue(s) this PR fixes:
Part of https://github.com/gardener/gardener-extension-shoot-rsyslog-relp/issues/2
Special notes for your reviewer:
ref: https://github.com/gardener/gardener-extension-shoot-rsyslog-relp/pull/7

/approve
/lgtm


Crash when applying updates: com.facebook.jni.CppException: Compiling JS failed: 1:1:Invalid UTF-8 lead byte 0x93 Buffer size 875336 starts with: 9397050a8180af03944f0d2400050206 and has protection mode(s): r--p

when applying the updates, the app crashes with the following error
FATAL EXCEPTION: mqt_js
com.facebook.jni.CppException: Compiling JS failed: 1:1:Invalid UTF-8 lead byte 0x93 Buffer size 875336 starts with: 9397050a8180af03944f0d2400050206 and has protection mode(s): r--p
FATAL EXCEPTION: mqt_js
Process: com.aeid.testapp1, PID: 13747
com.facebook.jni.CppException: Compiling JS failed: 1:1:Invalid UTF-8 lead byte 0x93 Buffer size 875336 starts with: 9397050a8180af03944f0d2400050206 and has protection mode(s): r--p
at com.facebook.jni.NativeRunnable.run(Native Method)
at android.os.Handler.handleCallback(Handler.java:938)
at android.os.Handler.dispatchMessage(Handler.java:99)
at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:27)
at android.os.Looper.loop(Looper.java:223)
at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:228)
at java.lang.Thread.run(Thread.java:923)
what could be the issue ?

strange, I'll have a look this Saturday

I'm building the app with eas, I changed the release channel here to staging.

where should I be looking, I would like to debug this issue.
thank you.

oh, that could indeed be the issue, you need to embed the private key in your application, check the provided example codeSigningCertificate key in app.json


Time & Date picker should rotate in both direction indefinitly

Ionic version:  (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[X ] 3.x
[ ] 4.x
I'm submitting a ...  (check one with "x")
[ ] bug report
[ X] feature request
Please do not submit support requests or "How to" questions here. Instead, please use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
Currently, if you want to select 59minutes, you need to start at 0 and slowly increase to 59...
Same for the dates, if you want to go to 28th day of the month, you need to go from 1 to 28th...
(in most case...)
Expected behavior:
instead of only incrementing, we should be able to go in reverse direction
Steps to reproduce:
is it really needed in this case ?
Open the Calendar on IOS and create a new event, you will see the behavior natively  on date and time ( you can go in both direction)
Related code:
Could I add a small movie from my iphone calendar app?
-->
Other information:
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
ionic info

cli packages: (/Users/xxxxx/Documents/Ionic_Source/node_modules)

    @ionic/cli-utils  : 1.19.0
    ionic (Ionic CLI) : 3.19.0

global packages:

    cordova (Cordova CLI) : 7.1.0

local packages:

    @ionic/app-scripts : 3.1.2
    Cordova Platforms  : android 6.3.0 ios 4.5.4
    Ionic Framework    : ionic-angular 3.9.2

System:

    Android SDK Tools : 26.1.1
    ios-deploy        : 1.9.2
    Node              : v6.11.1
    npm               : 5.4.2
    OS                : macOS Sierra
    Xcode             : Xcode 9.1 Build version 9B55

Environment Variables:

    ANDROID_HOME : /Users/xxxxx/Library/Android/sdk/

Misc:

    backend : legacy

Hello! Thank you for the feature request. I'm going to move this issue over to our internal list of feature requests for evaluation. We are continually prioritizing all requests that we receive with outstanding issues. We are extremely grateful for your feedback, but it may not always be our next priority. I'll copy the issue back to this repository when we have begun implementation. Thanks!

This issue was moved to ionic-team/ionic-feature-requests#343

the page link is dead... any new url ?


Undo/redo buttons do not inherit interactive state colors from IconButton

Because color styles are being applied at the SVG stroke level, the undo/redo buttons in MenuBar do not consistently apply the default interactive :hover/:active color styles (which should be inherited from IconButton).
See sidebar toggle buttons for the correct implementation (styles applied to a parent element). This way, we are able to manage different default colors (dark/light grey, depending on state), whist still allowing the interactive states to be inherited.

Good day, I am pretty new to contributing to oss, I thought this would be a good start for me as I get accustomed to the procedures. I have a small fix for this, basically removing the stroke styling on the chevron svg's. Wanted to confirm if this is a good move, as I see that you have a different color for disabled IconButton (--puck-color-grey-07) whereas the stroke on the chevron's is (--puck-color-grey-08) will this be an issue or it doesn't matter?

@cmutaledev I think it would make sense to make those disbaled states consistent --puck-color-grey-07 would be the one to use 👍🏻. The chevron should also receive link hover colours, etc. essentially the exact same state behaviour as the sidebar toggle buttons.

I've created a fix for this on PR #551


Launching VS Code via Windows Subsystem Linux should return to prompt and suppress output

Edit:
Posted by: nikhilweee

I figured out that this is actually the output of the main Log of VSCode. The question could now be phrased in a better manner - something like "VSCode leaks main log output to WSL Terminal".

Issue Type
Bug
Description
Launch editor thru WSL on windows 10 64-bit by using command 'code .'
I get this message in the terminal:
[main 12:16:59] update#setState idle
[main 12:17:29] update#setState checking for updates
[main 12:17:30] update#setState idle
And I need to press ctrl + c to get rid of it if I want to use the terminal during coding.
VS Code Info
VS Code version: Code 1.20.1 (f88bbf9137d24d36d968ea6b2911786bfe103002, 2018-02-13T15:34:36.336Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-2600K CPU @ 3.40GHz (8 x 3400)

Memory (System)
7.94GB (2.42GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe

Screen Reader
no

VM
40%

Extensions (6)

Extension
Author (truncated)
Version

path-intellisense
chr
1.4.2

bracket-pair-colorizer
Coe
1.0.10

vscode-eslint
dba
1.4.7

vscode-icons
rob
7.20.0

vscode-js-console-utils
wht
0.7.0

ReactSnippets
xab
1.7.0

(1 theme extensions excluded)

Reproduces without extensions

@Tyriar I remember you commented on bugs starting the Windows version of Code from WSL. I only look into launching the Linux version. Does this ring a bell?

Launching through WSL will launch the win32 executable, looks like we probably need to do something so it returns to the prompt.
Opening up to PRs, the files of interest here are https://github.com/Microsoft/vscode/blob/master/resources/win32/bin/code.cmd and https://github.com/Microsoft/vscode/blob/master/resources/win32/bin/code.sh
Related: https://github.com/Microsoft/vscode/issues/13138

And I need to press ctrl + c to get rid of it if I want to use the terminal during coding.

Even this doesn't solve the problem for me. Apparently VSCode checks for updates every hour. Here's the output from an idle terminal with VSCode open. I think this needs to be solved soon.
[main 4:21:06 PM] update#setState idle
[main 5:21:05 PM] update#setState checking for updates
[main 5:21:06 PM] update#setState idle
[main 6:21:05 PM] update#setState checking for updates
[main 6:21:06 PM] update#setState idle
[main 7:21:05 PM] update#setState checking for updates
[main 7:21:06 PM] update#setState idle
[main 8:21:05 PM] update#setState checking for updates
[main 8:21:06 PM] update#setState idle
[main 9:21:05 PM] update#setState checking for updates
[main 9:21:06 PM] update#setState idle
[main 10:21:05 PM] update#setState checking for updates
[main 10:21:06 PM] update#setState idle
[main 11:21:05 PM] update#setState checking for updates
[main 11:21:06 PM] update#setState idle
[main 12:21:05 AM] update#setState checking for updates
[main 12:21:06 AM] update#setState idle
[main 1:21:05 AM] update#setState checking for updates
[main 1:21:06 AM] update#setState idle
[main 2:21:05 AM] update#setState checking for updates
[main 2:21:06 AM] update#setState idle
[main 3:21:05 AM] update#setState checking for updates
[main 3:21:06 AM] update#setState downloading
[main 3:21:09 AM] update#setState ready

I figured out that this is actually the output of the main Log of VSCode. The question could now be phrased in a better manner - something like "VSCode leaks main log output to WSL Terminal".

I figured out that this is actually the output of the main Log of VSCode. The question could now be phrased in a better manner - something like "VSCode leaks main log output to WSL Terminal".

I put your comment in thread

I figured out that this is actually the output of the main Log of VSCode. The question could now be phrased in a better manner - something like "VSCode leaks main log output to WSL Terminal".

@nikhilweee I put your comment in the thread

I see this output even when launching from an ordinary command window.

FYI: On Windows 10 when starting code from PowerShell, if I execute code.exe I get the log output, but if I execute code.cmd I do not get the log output.

@ajkurtz this is expected as code.cmd is the CLI, code.exe is the Electron executable and shouldn't be on the PATH.

I used to open code from CMD and when I close the CMD, the VS code is also closing (CMD is kind of acting as parent for vs code)

@slvganesh I just noticed the same issue. In the past pressing ctrl + c would bring the prompt back up, but now it is also closing VSCode. Closing the terminal now also closes VSCode.

I have the same issue here, using windows 10 and WSL.
But I noticed something very interesting that could help here. When I open vs Code first then open the desired project from the terminal, it works just fine and there's no update#setState idle.

I believe https://github.com/Microsoft/vscode/pull/44945 fixes this.


ENH: sparse.linalg: convert sparse.linalg to use sparray internally

This PR converts sparse.linalg to use sparray internally instead of spmatrix.
With full functionality for sparray, we can start to move SciPy's internal usage of sparse matrix to sparse array. This PR converts the sparse.linalg subpackage.
The linalg functions all still take spmatrix as input and return spmatrix where appropriate when the input is spmatrix. But they no longer construct any spmatrix objects or use any sparse spmatrix functionality internally. Thus sparse.linalg is now independent of spmatrix and should not need to be changed as that functionality is slowly removed from use.

In playing with the convergence issues for lgmres, I realized that random_array doesn't use the global random_state as rand does. That means to get deterministic results I need to be including the random_state=rng argument of random_array.  That means to keep the tests deterministic I should switch them to using the new generators (easier than passing in a long link to the deafult random_state instance, and better practice anyway).
The latest commit makes changes in all tests using random_array (test_lgmres, test_grotmk and test_expm_multiply). They each use rng - np.random.default_rng(<seed int>) to create the deterministic generator, and then use that throughout the test method to control RNG state. This means some numpy calls like np.random.randn(n, k) get switched to rng.standard_normal((n, k)) even though that has little to do with sparrays. It is better to switch the whole test method than to use two different random number systems in the same method. It looks like those test modules already have a mix of random_state and rng systems, but each test method is one or the other.
I will update the migration guide to sparray to include directions for how to handle seeds with random_array. But I will do that in a separate PR because I have other changes for that doc as well.
Thanks for the review! It caught a number of issues and raised good questions. :)

Merged! Thanks @dschult


duplicate configs installed

When I tried certificate based deployment, I noticed duplicate configs were installed. eg for a two node inventory with "east" and "west", both machines end up with east-to-west.conf and west-to-east.conf with basically the same config (but left/right mirrored)
They should only get one config file for this.

It seems a little more complicated. Possibly a race condition or perhaps the first node and second node being treated differently.
This is my inventory:
all:
hosts:
west:
ansible_host: <IP_ADDRESS>
ansible_user: root
ansible_password: swan
ansible_ssh_common_args: -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no
east:
ansible_host: <IP_ADDRESS>
ansible_user: root
ansible_password: swan
ansible_ssh_common_args: -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no
vars:
vpn_auth_method: cert
vpn_connections:
- hosts:
west:
cert_name: west
east:
cert_name: east
auto: ondemand
I run this with:

name: Ensure that the role runs with default parameters
hosts: all
roles:

linux-system-roles.vpn

Then on west, I only seem to have east's configuration, that is with leftcert=east
On east, I end up with both configurations, east-to-west.* and west-to-east.*

The same happens for the mesh.conf. It seems when adding a mesh for east and west, I ended up with only the mesh.conf of east on both nodes, so both had leftcert=east configured


opacity

Hello,
First of all I would like to say thank you, this is super helpful for what I am working on.
I have one question though -- I want to fade the video in and out, but using this shader the material's opacity value is being ignored. How would I adjust it so that lowering/raising the material's opacity has an effect on the video?
Thanks,

This module uses a different shader implementation, but in the demo you can see that adjusting the Smoothness value toward 1 has the effect of affecting opacity.
In that demo, Dat.gui is set so the max value is clamped to 1 leaving it slightly visible at  value of 1. I imagine values >1 would make it fully transparent.


Retry CRI requests when containerd is not initialized

Containerd does not report correct error code in this case yet.
Thus we have to check error message.
Link: https://github.com/containerd/containerd/pull/9565
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Shipped!

Shipped!


allow both approvers and assignees in owners files

In preparation for the upcoming owners change, let's allow both assignees (old way) and approvers (new way) to lgtm code.  This does not affect the lgtm functionality.

This change is

although I would like to see a test...

suggestions for how to test?  It doesn't seem like something that I can write a unit test for easily

/lgtm
uggh, we don't have any blunderbuss unit tests, do we.

@eparis  I think /lgtm works if it's the only text in the comment, to avoid cases like "/lgtm after you fix..."

@eparis @grodrigues3 /lgtm //some comment here (this works)


S allius/issue2

fixes #2:
Now you can easily set the uid and gid of the proxy without having to recreate the container. Just set the uid and gid variables in your environment before starting the container. The proxy will adjust the ownership of all configuration and log files accordingly.

fixes #2
Now you can easily set the uid and gid of the proxy without having to recreate the container. Just set the uid and gid variables in your environment before starting the container. The proxy will adjust the ownership of all configuration and log files accordingly.


donejs add nw twice

If you run this twice, it doesn't seem to update build.js. try with different version numbers.

We only update build.js if it does not already contain nwOptions. Otherwise we would have to parse build.js and update its AST in order to change it correctly. We can do this, but once it is written it's relatively easy for a user to update one of the configs.

The alternative would be to add some comments like:
// start - generated by `donejs add nw`
CODE
// end - generated by `donejs add nw`

And then just replace the CODE.

I prefer the AST option, I like to keep my scripts as readable as if they were hand-written.

It would still be readable. And this gives people a warning not to touch.
Sent from my iPhone

On Oct 27, 2015, at 1:44 PM, Matthew Phillips<EMAIL_ADDRESS>wrote:
I prefer the AST option, I like to keep my scripts as readable as if they were hand-written.
—
Reply to this email directly or view it on GitHub.

I'm not sure if this is really important. The AST options sounds like a lot of work just to not have a user update their build.js manually.
donejs-nw and donejs-cordova should probably throw an error when you try to run it twice though.

On second thought I don't think comments would be such a terrible thing. @moschel made a mistake the first time and tried running it again so he did run into this issue.

Any issues with me merging and publishing these to close this issue?
https://github.com/donejs/donejs-nw/pull/2
https://github.com/donejs/donejs-cordova/pull/13
cc @justinbmeyer @matthewp @daffl

Nope, go for it.


Thoughts on using stargate msg with proto generated types instead of binding

@maurolacy @SebastianElvis
Wonder if you guys have seen this discussion on deprecating osmosis binding. Recently when I'm building something that interact with contracts like cw20 or cw721, response of execution is pure CosmosMsg. I also use Neutron SDK to use token factory and response of execution is CosmosMsg<NeutronMsg>. It caused some headache to define a response that can handle both. This makes me think it's probably a good idea to not have binding (e.g. NeutronMsg or BablyonMsg) in the first place, and just use proto generated type as stargate msg which is pure CosmosMsg, similar to the osmosis-std.
So in conclusion I guess the benefit of not having binding are:

More streamlined devX, you can still implement helper functions if you want.
Less maintenance required, generating proto types can be automated.

@maurolacy @SebastianElvis

Hi, thanks for the reference. We'll take this into account.

Hi, thanks for the reference. We'll take this into account.

Awesome, recently I'm thinking about creating a generalized version of osmosis-std, so it can be used for all cosmos sdk chains to generate rust proto and have out of box support in cw with stargate msg, maybe I can experiment that with babylon.


Cannot execute a custom method in request body

Hey! I am using spring-cloud-contract 2.1.3.RELEASE
Not sure if I am using the tool correctly, but I have seen similar example in the docs (at the end of this section: https://cloud.spring.io/spring-cloud-contract/2.1.x/single/spring-cloud-contract.html#_executing_custom_methods_on_the_server_side).
This is my contract:
Contract.make {
    description "should migrate spaceship"
    request {
        method POST()
        url('/api/migration')
        headers {
            accept('application/json')
            contentType(applicationJson())
        }
        body(
                id: $(c('1'), p(execute('legacyId()')))
        )
    }
    response {
        status OK()
        headers {
            contentType(applicationJson())
        }
    }
}

And generated test:
@Test
public void validate_shouldMigrateFile() throws Exception {
	// given:
		MockMvcRequestSpecification request = given()
				.header("Accept", "application/json")
				.header("Content-Type", "application/json")
				.body("{\"id\":{\"executionCommand\":\"legacyId()\"}}");

	// when:
		ResponseOptions response = given().spec(request)
				.post("/api/migration");

	// then:
		assertThat(response.statusCode()).isEqualTo(200);
		assertThat(response.header("Content-Type")).matches("application/json.*");
}

It doesn't just call legacyId() method - instead, it prints execute('legacyId()') object.
I can workaround it by making legacyId method return "id": <legacyId> plus:
        body(
                $(c('\"id\": 1'), p(execute('legacyId()')))
        )

but.. it won't work if there are more json fields in a body

You can't call execute(...) on a part of the body. you can call it on the whole body (as presented in the docs)
Contract contractDsl = Contract.make {
	request {
		method 'GET'
		url '/something'
		body(
				$(c('foo'), p(execute('hashCode()')))
		)
	}
	response {
		status OK()
	}
}

That's because we need to somehow glue your request that we're sending from the generated test to your application. The whole request body needs to be a valid json for the producer side for us to be able to convert it to a text representation of that json.
What you can do, is this:
Contract.make {
				description "should migrate spaceship"
				request {
					method POST()
					url('/api/migration')
					headers {
						accept('application/json')
						contentType(applicationJson())
					}
					body(
							$(c([id: 4, foo:5, whatever:"hello"]), p(execute('hashCode()')))
					)
				}
				response {
					status OK()
					headers {
						contentType(applicationJson())
					}
					body(
							$(c([id: 4, foo:5, whatever:"hello"]), p(execute('hashCode()')))
					)
				}
			}```