Warning: Failed propType: Invariant Violation: Invalid prop type of value ThemeAttrAndroid

I am getting this error in android project  Seem like an error
'Warning: Failed propType: Invariant Violation: Invalid prop type of value ThemeAttrAndroid supplied to TouchableNativeFeedback, expected one of ["RippleAndroid"].\nBad object: {\n  "type": "ThemeAttrAndroid",\n  "attribute": "selectableItemBackground"\n} Check the render method of TouchFeedback.'

as the warning says, just add a background props,like this: background={TouchableNativeFeedback.Ripple()}, the waining disappear

PropTypes.oneOfType couldn't work with checkers which throws Error.(https://github.com/facebook/react-native/blob/f2545bafc967661beeefc3778c06532982a6addc/Libraries/Components/Touchable/TouchableNativeFeedback.android.js#L37)
createStrictShapeTypeChecker checker should return Error instead of throw Error.

@KeithZhang Thanks!
Replacing the  background={TouchableNativeFeedback.SelectableBackground()}  with background={TouchableNativeFeedback.Ripple()} removes the warning.

@ide @mkonicek Is the warning necessary? There is a already a default value set to TouchableNativeFeedback.SelectableBackground().
@cspkop Note that using TouchableNativeFeedback.Ripple() will crash your app below Android 5.0.

There is a bug to combine PropTypes.oneOfType with createStrictShapeTypeChecker.

@satya164 Then how we can get rid of this warning?

@cspkop For now you can ignore it. It doesn't do any harm.

@cspkop For now you can ignore it. It doesn't do any harm. In my app, I've done the following,
import React from "react-native";

const {
	TouchableNativeFeedback,
	TouchableHighlight,
	Platform
} = React;

export default class TouchFeedback extends React.Component {
	render() {
		if (Platform.OS === "android" && Platform.Version >= 23) {
			return (
				<TouchableNativeFeedback {...this.props} background={TouchableNativeFeedback.Ripple(this.props.pressColor)}>
					{this.props.children}
				</TouchableNativeFeedback>
			);
		} else {
			return (
				<TouchableHighlight {...this.props} underlayColor={this.props.pressColor}>
					{this.props.children}
				</TouchableHighlight>
			);
		}
	}
}

TouchFeedback.propTypes = {
	pressColor: React.PropTypes.string,
	children: React.PropTypes.node.isRequired
};

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/warning-failed-proptype-invariant-violation-invalid-prop-type-of-value-themeattrandroid
ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub.
Also, if this issue is a bug, please consider sending a PR with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.


Cannot install

On trying to install with both modfinder and umm itself, there is an error reported which causes modfinder to crash and umm to refuse to install the mod

This is the error thrown:

[22:09] Invalid character after parsing property name. Expected ':' but got: ,. Path 'Author', line 5, position 11.
[22:09] Error parsing file 'SpellPouch.zip'.
[22:09] SpellPouch.zip is not supported.
[22:09] Invalid character after parsing property name. Expected ':' but got: ,. Path 'Author', line 5, position 11.
[22:09] Error parsing file 'SpellPouch.zip'.

I had a bad script that printed bad formated text into info.json file. Fixed.


An Exception Occured from SSL Error

safety version: safety, version 1.8.5
Python version: Python 3.8.0
Operating System: Windows

Name                           Value
----                           -----
PSVersion                      5.1.19041.1
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.1
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Description
I tried to run a safety check today and the output did not work lie usual.
As a result I got an excetion error and a python trace back
What I Did
safety check

  File "c:\python38\lib\site-packages\OpenSSL\SSL.py", line 1934, in do_handshake
    self._raise_ssl_error(self._ssl, result)
  File "c:\python38\lib\site-packages\OpenSSL\SSL.py", line 1663, in _raise_ssl_error
    raise SysCallError(errno, errorcode.get(errno))
OpenSSL.SSL.SysCallError: (10054, 'WSAECONNRESET')

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "c:\python38\lib\site-packages\urllib3\connectionpool.py", line 665, in urlopen
    httplib_response = self._make_request(
  File "c:\python38\lib\site-packages\urllib3\connectionpool.py", line 376, in _make_request
    self._validate_conn(conn)
  File "c:\python38\lib\site-packages\urllib3\connectionpool.py", line 994, in _validate_conn
    conn.connect()
  File "c:\python38\lib\site-packages\urllib3\connection.py", line 386, in connect
    self.sock = ssl_wrap_socket(
  File "c:\python38\lib\site-packages\urllib3\util\ssl_.py", line 370, in ssl_wrap_socket
    return context.wrap_socket(sock, server_hostname=server_hostname)
  File "c:\python38\lib\site-packages\urllib3\contrib\pyopenssl.py", line 491, in wrap_socket
    raise ssl.SSLError("bad handshake: %r" % e)
ssl.SSLError: ("bad handshake: SysCallError(10054, 'WSAECONNRESET')",)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "c:\python38\lib\site-packages\requests\adapters.py", line 439, in send
    resp = conn.urlopen(
  File "c:\python38\lib\site-packages\urllib3\connectionpool.py", line 719, in urlopen
    retries = retries.increment(
  File "c:\python38\lib\site-packages\urllib3\util\retry.py", line 436, in increment
    raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='raw.githubusercontent.com', port=443): Max retries exceeded with url: /pyupio/safety-db/master/data/insecure.json (Caused by SSLError(SSLError("bad handshake: SysCallError(10054, 'WSAECONNRESET')")))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "c:\python38\lib\runpy.py", line 192, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "c:\python38\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "C:\Python38\Scripts\safety.exe\__main__.py", line 7, in <module>
  File "c:\python38\lib\site-packages\click\core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "c:\python38\lib\site-packages\click\core.py", line 717, in main
    rv = self.invoke(ctx)
  File "c:\python38\lib\site-packages\click\core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "c:\python38\lib\site-packages\click\core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "c:\python38\lib\site-packages\click\core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "c:\python38\lib\site-packages\safety\cli.py", line 76, in check
    vulns = safety.check(packages=packages, key=key, db_mirror=db, cached=cache, ignore_ids=ignore, proxy=proxy_dictionary)
  File "c:\python38\lib\site-packages\safety\safety.py", line 125, in check
    db = fetch_database(key=key, db=db_mirror, cached=cached, proxy=proxy)
  File "c:\python38\lib\site-packages\safety\safety.py", line 108, in fetch_database
    data = fetch_database_url(mirror, db_name=db_name, key=key, cached=cached, proxy=proxy)
  File "c:\python38\lib\site-packages\safety\safety.py", line 79, in fetch_database_url
    r = requests.get(url=url, timeout=REQUEST_TIMEOUT, headers=headers, proxies=proxy)
  File "c:\python38\lib\site-packages\requests\api.py", line 75, in get
    return request('get', url, params=params, **kwargs)
  File "c:\python38\lib\site-packages\requests\api.py", line 60, in request
    return session.request(method=method, url=url, **kwargs)
  File "c:\python38\lib\site-packages\requests\sessions.py", line 533, in request
    resp = self.send(prep, **send_kwargs)
  File "c:\python38\lib\site-packages\requests\sessions.py", line 646, in send
    r = adapter.send(request, **kwargs)
  File "c:\python38\lib\site-packages\requests\adapters.py", line 514, in send
    raise SSLError(e, request=request)
requests.exceptions.SSLError: HTTPSConnectionPool(host='raw.githubusercontent.com', port=443): Max retries exceeded with url: /pyupio/safety-db/master/data/insecure.json (Caused by SSLError(SSLError("bad handshake: SysCallError(10054, 'WSAECONNRESET')")))

This looks like a communication error while trying to download the open source database version from GitHub.
We should add a friendlier message for that anyways, instead of dumping a confusing traceback. There is also an open pull-request that might positively impact on this (#203).

@Richard-Barrett are this still happening or you got this one/few times only?

Duplicate of #237


Oracle-java-7 discontinued

--2017-06-05 20:51:48--  http://download.oracle.com/otn-pub/java/jdk/7u80-b15/jdk-7u80-linux-x64.tar.gz?AuthParam=1496696028_ffad8785cac9abfc5eea8b8e21e97351
Connecting to download.oracle.com (download.oracle.com)|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2017-06-05 20:51:49 ERROR 404: Not Found.

download failed
Oracle JDK 7 is NOT installed.
dpkg: error processing package oracle-java7-installer (--configure):
 subprocess installed post-installation script returned error exit status 1

Why Oracle Java 7 And 6 Installers No Longer Work

While Oracle Java 6 and 7 are not supported for quite a while, they were still available for download on Oracle's website until recently.
However, the binaries were removed about 10 days ago (?), so the Oracle Java (JDK) 6 and 7 installers available in the WebUpd8 Oracle Java PPA no longer work.
Oracle Java 6 and 7 are now only available for those with an Oracle Support account (which is not free), so I can't support this for the PPA packages.

Cf.
also
https://askubuntu.com/questions/920106/webupd8-oracle-java-7-installer-failing-with-404

Fixed in #65.

Mutect 1 fails with Java ≥ 8 :crying_cat_face:
Cf. also https://github.com/chapmanb/bcbio-nextgen/issues/1196
Java 7 seems still there maybe:
http://www.oracle.com/technetwork/java/javase/downloads/java-archive-downloads-javase7-521261.html
If I accept the license and click on a tar.gz it asks me for a login/password?

Cc @julia326 @armish

This was fixed/bypassed.


Fix support for formatting of JSON with duplicate keys

Fixes #1133.

Codecov Report

Merging #1136 (0fb7f63) into master (a62391e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1136      +/-   ##
==========================================
+ Coverage   97.17%   97.19%   +0.01%
==========================================
  Files          67       68       +1
  Lines        4248     4276      +28
==========================================
+ Hits         4128     4156      +28
  Misses        120      120

Impacted Files
Coverage Δ

httpie/output/formatters/json.py
100.00% <100.00%> (ø)

httpie/utils.py
100.00% <100.00%> (ø)

tests/fixtures/__init__.py
100.00% <100.00%> (ø)

tests/test_json.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a62391e...0fb7f63. Read the comment docs.

Hmm Python 3.6 and 3.7 failures are legit and will be tough to tackle. The problem is how sorted() is used within those versions.

Python 3.6 and 3.7: https://github.com/python/cpython/blob/79101b890ee021a901a8b6837a3a320d57adb725/Lib/json/encoder.py#L353
Python 3.8+: https://github.com/python/cpython/blob/9d318ad3ecca69b33fb4bb23a308488ec68e82f0/Lib/json/encoder.py#L353

I tracked the change and commented on https://bugs.python.org/issue23493, let's see what will happen next.
In the meantime, handling all Python versions equally is not possible without rewriting the JSON encoder. Either we add support for duplicate keys for Python 3.8+, either we loose JSON keys sorting for Python 3.6 & 3.7. The later is a breaking change, we do not want that :fire:
I do not like having different behavior given the Python version, but 3.6 & 3.7 are already old and I would be OK to introduce duplicate keys support starting with 3.8.
WDYT @jakubroztocil ?


Need custom validations to display certain field based on some selected values

Hi,
I want to know if it's possible to add more validation and actions on any field.
For example, if we have a radio button as "Are you married?"
then on selection of "Yes", spouse details row should be visible, and on selection of "No", these details should hide.
Also, if we can have few fields repeat themselves, like in the case of education details of any student.
Thanks.

Hi!
In pure angular formly (engine behind easy form generator) I suppose your need would be an implementation of nested-formly-forms.
It should be do-able, but for a single case with angular formly.
To be honest, I don't see how to create a generator for such implementation since it depends needs that aren't generic / predictable...
But don't worry, there is another solution to implement your specific need without that much difficulties.
In your case :

yes / no check boxes should be managed by your controller (not easy form generator)
when click yes

ng-if or ng-show : a first easy form generated form (spouse details row should be visible...)

when click no

ng-if or ng-show : a second easy form generated formor nothing (spouse details row should be hidden / another form showing etc...)

In your specific need, you will have to code a bit.
Is that ok for you?

Hi,
Thanks for quick response, I am currently using this for my needs, but I just wanted to know if it is possible through easyFormGenerator. Or if this functionality of custom validations could be added to easyFormGenerator.
Many thanks.

Nice, this way is good too :+1:
Hope you happy coding.


remove if properties or their types has got ExcludeProxy Attribute

remove if properties or their types has got ExcludeProxy Attribute (or dummy name)

What's the use-case of this; as opposed to just marking the properties as internal?

I use same dll with abstract (base) class and same type (they are nullable) use an other project and i can modify it. But they are partial i can add attribute in my project. And public it if i know name.


Fix async IO in Sesame lock component.

Description:
Switch Sesame lock component to use async_add_devices and force the object to cache all it's properties.  Unless someone manually overrides the value of use_cached_state on the internal sesame instance there will be no async IO in the component properties.
Checklist:
If the code communicates with devices, web services, or third-party tools:

[X] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[X] New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
[X] New dependencies are only imported inside functions that use them ([example][ex-import]).
[X] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[X] New files were added to .coveragerc.

Hi @veleek,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

@balloob I'm not sure what won't work.  Pysesame defines the properties like this:
    @property
    def nickname(self):
        """Return the Sesame nickname."""
        if not self.use_cached_state:
            self.update_state(False)
    return self._nickname

So since I'm adding update_before_add, self.use_cached_state will always be true and it will just return the local value of self._nickname.  I guess I'm not sure what you mean by "always evaluated in an asyncio context".
I'm happy to change to caching all of the pysesame properties inside the HA Sesame object, I just want to make sure that I understand why I'm doing it (my first commit to the project an all :smile:).

It would be best as @balloob said to use the update method to cache everything into the home assistant class. Although this does correct the problem, it's cleanest not to depend on the upstream behavior of sometimes blocks sometimes returns immediately.

Sounds good.  Thanks for the feedback.  I'll make the changes.


Autopause functionality

Ability to stop the java process from using CPU power when no client is connected.
I've tested this with 1.15.2 during development, should work on any version.
I've deployed this today on the two servers I'm running: Vanilla 1.14.4 and FTB-like 1.7.10, feedback is pending.
I saw that the 1.14.4 server is using about 35% CPU power idle on my NUC, so that triggered the development. The netstat command doesn't list connections to docker (iirc) so it had to be done inside the container.
I'll be so lazy to copy & paste the readme entry I made for the description:
Autopause
Description
There are various bugs reports on Mojang about high CPU usage of servers with newer versions, even with few or no clients connected (e.g. this one, in fact the functionality is based on this comment in the thread).
An autopause functionality has been added to this image to monitor whether clients are connected to the server. If for a specified time no client is connected, the Java process is stopped. When knocking on the server port (e.g. by the ingame Multiplayer server overview), the process is resumed. The experience for the client does not change.
Of course, even loaded chunks are not ticked when the process is stopped.
From the server's point of view, the pausing causes a single tick to take as long as the process is stopped, so the server watchdog might intervene after the process is continued, possibly forcing a container restart. To prevent this, ensure that the max-tick-time in the server.properties file is set correctly.
On startup the server.properties file is checked and, if applicable, a warning is printed to the terminal. When the server is created (no data available in the persistent directory), the properties file is created with the Watchdog disabled.
The autopause functionality is not compatible with docker's host network_mode, as the knockd utility cannot attach to the eth0 interface in that mode.
Enabling Autopause
Enable the Autopause functionality by setting:
ENABLE_AUTOPAUSE=TRUE

There are 3 more environment variables that define the behaviour:

AUTOPAUSE_TIMEOUT_EST, default 3600 (seconds); describes the time between the last client disconnect and the pausing of the process (read as timeout established)
AUTOPAUSE_TIMEOUT_KN, default 120 (seconds); describes the time knocking of the port (e.g. by the main menu ping) and the pausing of the process, when no client connects inbetween (read as timeout knocked)
AUTOPAUSE_PERIOD, default 10 (seconds); describes period of the daemonized state machine, that handles the pausing of the process (resuming is done independantly)

I skimmed through it and so far it looks really cool. I'll give it a proper review sometime this weekend.

Thank you.
Initially, I had completely missed the rcon stuff, I've implemented it now (knock doesn't listen) on localhost.
However, there are two points open:

mc-status doesn't seem to time-out, so there are processes stacking up when the process is suspended
network_mode: host probably does work with knockd, it doesn't in my VM (neither in docker nor on the VM itself), so I can't test that

I’ll see if I can add a timeout in mc-monitor since that really should be handled regardless.

I was thinking about it some more and realized that mc-monitor will need to check for the paused state and skip health check. Otherwise the health check / liveness probe will fail the whole container.

Hmm, do you want that check in mc-monitor? Otherwise, we could make the HEALTHCHECK a bash script, that executes mc-monitor if the process is not paused, and, idk, halted otherwise form bash directly.

That’s a good point about a bash wrapper script. Even though both repos are mine, it would be a cleaner separation to not have mc-monitor aware of the pause mechanism.

BTW I’m personally not too concerned with host networking mode support. IMHO it is generally an anti-pattern to use that mode, but in any case seems like a reasonable “limitation” for this feature.

Alright, I'll see to come up with a wrapper, although I'll leave the timeout of mc-monitor to you, that shouldn't block this PR then anyway.
About host networking, yeah, it really makes no sense to use for a Minecraft server.

HEy, Thank you VERY MUCH FOR THIS. i Just tought about this today, because i had like 1000 pgimen running in my base... (wasnt online some days).
THANKS!
So i added it to both of my servers ("-e ENABLE_AUTOPAUSE=TRUE") will report back if it works. Just a small question, does it work with "non" standard ports? I mean i redirect port 25566 to 25565 but i guess, inside the docker its still the standard port, i guess.

Sorry @Oekn5w that it's taking me longer than I expected to get to reviewing and testing this. I'm going to do some of that now...

ah so this is still work in progres...? Let me know when i can test it! :D

Sorry for the confusion @eihns , should be merged and pushed for testing pretty soon.

really cool, currently testing it.
just one thing, since i have to set max tick to -1, will the server recognize if its frozen and restart?

Very nice feature! Testing on 2 instances of Spigot 1.15.2. Does not work as intended at the moment.
It seems to save the game 10 minutes after booting, briefly pausing (CPU usage to 0%) for about 20 seconds and starting again, giving the warning of running behind. Autopause is never mentioned in the logs.
[15:08:59] [Server thread/INFO]: Done (5.815s)! For help, type "help"
[15:08:59] [Server thread/INFO]: Starting remote control listener
[15:08:59] [RCON Listener #1/INFO]: RCON running on <IP_ADDRESS>:25575
[15:18:52] [RCON Listener #1/INFO]: Rcon connection from: /<IP_ADDRESS>
[15:18:52] [Server thread/INFO]: [Rcon: Saved the game]
[15:19:15] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 22737ms or 454 ticks behind

After this first pause it never pauses again, it does save every 120 seconds though. CPU never drops to 0% again.
[15:21:16] [RCON Listener #1/INFO]: Rcon connection from: /<IP_ADDRESS>
[15:21:16] [Server thread/INFO]: [Rcon: Saved the game]
[15:23:18] [RCON Listener #1/INFO]: Rcon connection from: /<IP_ADDRESS>
[15:23:18] [Server thread/INFO]: [Rcon: Saved the game]
[15:25:20] [RCON Listener #1/INFO]: Rcon connection from: /<IP_ADDRESS>
[15:25:20] [Server thread/INFO]: [Rcon: Saved the game]
[15:27:22] [RCON Listener #1/INFO]: Rcon connection from: /<IP_ADDRESS>
[15:27:22] [Server thread/INFO]: [Rcon: Saved the game]

max-tick-time = -1 in server.properties

@eihns for this to work we have to disable the watchdog, however I've never experienced the server freezing, they always hard crash, which triggers a restart depending on your docker restart setting
@MoustacheMonkey thanks for the feedback, I'll look into it. The log, however is only from the Java process, Autopause and the surrounding utility at startup log to docker, can you paste the relevant lines from the docker log?

I dont know. I only saw "blabla ticks behind, server possible crashed, restarting blabla". Not a single other crash or restart.
Something is broken with displaying in the log the autopause is working. I know its working because both dockers are at 0-1%. But it doesnt show in log.

(Forge)
[11:00:00] [Server thread/INFO]: All players have been successfully backed up
[11:04:50] [RCON Listener #1/INFO]: Rcon connection from: /<IP_ADDRESS>
[11:04:50] [RCON Client #2/INFO]: §7§o[§r§7§oRcon§r§7§o: §r§7§oSaved the world§r§7§o]§r

Server (vanilla)
[10:45:48] [Server thread/INFO]: Time elapsed: 7792 ms
[10:45:48] [Server thread/INFO]: Done (11.058s)! For help, type "help"
[10:45:48] [Server thread/INFO]: Starting remote control listener
[10:45:48] [Server thread/INFO]: Thread RCON Listener started
[10:45:48] [RCON Listener #1/INFO]: RCON running on <IP_ADDRESS>:25575
[10:55:40] [RCON Listener #1/INFO]: Thread RCON Client /<IP_ADDRESS> started
[10:55:40] [Server thread/INFO]: [Rcon: Saved the game]
[10:55:40] [RCON Client /<IP_ADDRESS> #2/INFO]: Thread RCON Client /<IP_ADDRESS> shutting down

@Oekn5w I'm sorry, this was copied from my docker logs in portainer, but due to Spigot spamming the logs when building the world I didn't see these first lines:
[init] Changing ownership of /autopause to 1000 ...
chmod: /tmp/terminal-mc: No such file or directory
[init] Running as uid=1000 gid=1000 with /data as 'drwxrwxr-x   10 1000     1000          4096 May 21 15:07 /data'
[init] Resolved version given 1.15.2 into 1.15.2
[init] Autopause functionality enabled
[init] Warning: MAX_TICK_TIME is non-default, for autopause to work properly, this check should be disabled (-1 for versions >= 1.8.1)
[init] Resolving type given SPIGOT
[init] server.properties already created, skipping
[init] Setting/adding ops
[init] Checking for JSON files.
[init] Setting initial memory to 3G and max to 3G
[init] Starting the Minecraft server...

It seems it's trying to change the ownership of /tmp/terminal-mc but failing

@MoustacheMonkey do you have a broken symbolic link called terminal-mc in the /data directory (wherever this is mounted to)? If so the tty command fails :(

I dont know, but the only message i can see in docker log is:
if isTrue "${ENABLE_AUTOPAUSE}"; then
log "Autopause functionality enabled"
when i look at your other code, you always use echo, which doesnt get displayed in docker log for me, maybe change all this to log?

Didn't seem to find any symlinks inside the /data folder, but after restarting the container it did not show the lines of changing ownership. No idea what happened back there the first time..
It seems to retry every 2 minutes, and sometimes manages to pause for about 45 seconds before automatically starting again. Sometimes it stops 'trying' for a few hours.
Here are the Docker logs of this night:
[00:12:56] [RCON Listener #1/INFO]: Rcon connection from: /<IP_ADDRESS>
[00:12:56] [Server thread/INFO]: [Rcon: Saved the game]
[01:15:11] [RCON Listener #1/INFO]: Rcon connection from: /<IP_ADDRESS>
[01:15:11] [Server thread/INFO]: [Rcon: Saved the game]
[01:15:58] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 46628ms or 932 ticks behind
[01:17:59] [RCON Listener #1/INFO]: Rcon connection from: /<IP_ADDRESS>
[01:17:59] [Server thread/INFO]: [Rcon: Saved the game]
[01:20:01] [RCON Listener #1/INFO]: Rcon connection from: /<IP_ADDRESS>
[01:20:01] [Server thread/INFO]: [Rcon: Saved the game]
[01:22:03] [RCON Listener #1/INFO]: Rcon connection from: /<IP_ADDRESS>
[01:22:03] [Server thread/INFO]: [Rcon: Saved the game]
[06:33:22] [RCON Listener #1/INFO]: Rcon connection from: /<IP_ADDRESS>
[06:33:22] [Server thread/INFO]: [Rcon: Saved the game]
[06:34:08] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 45587ms or 911 ticks behind
[06:36:08] [RCON Listener #1/INFO]: Rcon connection from: /<IP_ADDRESS>
[06:36:08] [Server thread/INFO]: [Rcon: Saved the game]
[06:38:10] [RCON Listener #1/INFO]: Rcon connection from: /<IP_ADDRESS>
[06:38:10] [Server thread/INFO]: [Rcon: Saved the game]
[06:40:13] [RCON Listener #1/INFO]: Rcon connection from: /<IP_ADDRESS>
[06:40:13] [Server thread/INFO]: [Rcon: Saved the game]
[07:41:28] [RCON Listener #1/INFO]: Rcon connection from: /<IP_ADDRESS>
[07:41:28] [Server thread/INFO]: [Rcon: Saved the game]
[07:42:14] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 45754ms or 915 ticks behind
[07:44:14] [RCON Listener #1/INFO]: Rcon connection from: /<IP_ADDRESS>
[07:44:14] [Server thread/INFO]: [Rcon: Saved the game]
[07:46:16] [RCON Listener #1/INFO]: Rcon connection from: /<IP_ADDRESS>
[07:46:16] [Server thread/INFO]: [Rcon: Saved the game]
[07:48:18] [RCON Listener #1/INFO]: Rcon connection from: /<IP_ADDRESS>
[07:48:18] [Server thread/INFO]: [Rcon: Saved the game]
[07:50:21] [RCON Listener #1/INFO]: Rcon connection from: /<IP_ADDRESS>
[07:50:21] [Server thread/INFO]: [Rcon: Saved the game]
[07:52:23] [RCON Listener #1/INFO]: Rcon connection from: /<IP_ADDRESS>
[07:52:24] [Server thread/INFO]: [Rcon: Saved the game]
[07:53:25] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 61007ms or 1220 ticks behind
[07:53:25] [Spigot Watchdog Thread/ERROR]: ------------------------------
[07:53:25] [Spigot Watchdog Thread/ERROR]: The server has stopped responding! This is (probably) not a Spigot bug.
[07:53:25] [Spigot Watchdog Thread/ERROR]: If you see a plugin in the Server thread dump below, then please report it to that author
[07:53:25] [Spigot Watchdog Thread/ERROR]: 	 *Especially* if it looks like HTTP or MySQL operations are occurring
[07:53:25] [Spigot Watchdog Thread/ERROR]: If you see a world save or edit, then it means you did far more than your server can handle at once
[07:53:25] [Spigot Watchdog Thread/ERROR]: 	 If this is the case, consider increasing timeout-time in spigot.yml but note that this will replace the crash with LARGE lag spikes
[07:53:25] [Spigot Watchdog Thread/ERROR]: If you are unsure or still think this is a Spigot bug, please report to https://www.spigotmc.org/
[07:53:25] [Spigot Watchdog Thread/ERROR]: Be sure to include ALL relevant console errors and Minecraft crash reports
[07:53:25] [Spigot Watchdog Thread/ERROR]: Spigot version: git-Spigot-800b93f-8160e29 (MC: 1.15.2)
[07:53:25] [Spigot Watchdog Thread/ERROR]: ------------------------------
[07:53:25] [Spigot Watchdog Thread/ERROR]: Server thread dump (Look for plugins here before reporting to Spigot!):
[07:53:25] [Spigot Watchdog Thread/ERROR]: ------------------------------

At 07:53 it managed to pause for longer than 60 seconds though, in which I discovered that Spigot users should also edit timeout-time=315360000000 in 'spigot.yml' (which is 60 by default) along with max-tick-time = -1 in 'server.properties' otherwise the Spigot server will stop.
This is the minecraft CPU usage in Grafana:

As you can see, at 07:42 the cpu went to 0% for the 45 seconds, after that the message apeared of running behind. At 07:53 the server crashed due to the spigot.yml config and a timeout of 61 seconds.
Today I'll test again with timeout-time=315360000000.

Started a third minecraft server with a fresh Spigot install, and guess what:  it works like a charm!
I am amazed how fast the unpause works, great work!
I have no idea what is causing the problems on the other servers, but I'll keep those as they are and wait for the logging to be fixed to see what the autopause function is doing.
Another tought for the future: is there a way of forcing minecraft/java to do a garbage collection right before pausing, so the RAM usage is minimized during the pause?

Hmm, the lack of logging is strange, isn't the point of containers that it behaves the same of different systems? You're running Spigot on Portainer, correct? I'll try to recreate in the next few days. I'm not familiar with either, do they ping the exposed ports regularly? That would wake the server, as well as knocks from the internet. Regarding those, I have a few wakes during the day on my (private) connection on non-standard (with respect to MC) ports.

@Oekn5w you are correct, a benefit of containers is that "logging" is all just standardized through stdout/stderr. So using the log utility function or echo makes no difference. The log feature was added for someone that needed some specialized log filtering logic.

@Oekn5w I'm running Spigot, build through docker-compose, but I use Portainer to watch the logs. This should not matter, when I watch the logs through SSH command docker logs minecraft I get the same results.
Only this message concerning autopause is in the logs before starting the server:
[init] Autopause functionality enabled

@Oekn5w you are correct, a benefit of containers is that "logging" is all just standardized through stdout/stderr. So using the log utility function or echo makes no difference. The log feature was added for someone that needed some specialized log filtering logic.

Cant hurt to use log instead of echo, right?

Correct. log is slightly better to use since that aligns with the contributor's and issue's intent.

I mean, of course we can change the log function, but that does not explain, why the stdout redirection (via the tty command and a symbolic link) works for @itzg and me and doesn't for @eihns and @MoustacheMonkey. The exec at the beginning of the daemon can't be (fully) responsible, because in the pause and resume scripts the redirect "directly" and those are also not present in the snippets. I'd suggest to create two separate issues, one for the missing log entries and one for the Spigot Server not really stopping

@Oekn5w After some troubleshooting and running tcpdump on the minecraftserver port, I found out what was waking minecraft... Facepalm
I had a sensor configured in my Home Assistant that was pinging the port every minute.
After removing this, everything started worked correctly.
Apologies for the misdirection!

My Server went from 5.00 - 6.00  to 0.83 ... in median xD
Thanks for this great addition!

Should this work with TYPE=FORGE?

@DerGuteWolf confirmed working with Forge (although an older one, for 1.7.10) and docker-compose. Usually you have to recreate the container when you change environment variables, simple restart is not sufficient. It is not necessary to be enabled on world generation. You can see it, when working, in the very first lines in the log (docker logs <name> | less):
[init] Changing ownership of /autopause to 1000 ...
[init] Running as uid=1000 gid=1000 with /data as 'drwxrwxr-x   15 1000     1000          4096 Jun 11 00:34 /data'
[init] Resolved version given 1.7.10 into 1.7.10
[init] Autopause functionality enabled
[init] Resolving type given FORGE
...

With portainer or other fancy container management tools it might not work.

@Oekn5w
thanks for the quick response!

Usually you have to recreate the container when you change environment variables, simple restart is not sufficient.
IMHO you should mention this in the README...

Ok, I have the /data directory (with the world) on the host file system. So in order to migrate this and keeping the world (and thus my son happy...) what would be the best way? Stop Server, rename data dir on host to dataold, create empty data dir, duplicate container settings, make sure ENABLE_AUTOPAUSE=TRUE is set, create/start new container, stop new container, copy dataold/world to data/world, start new container again? Is there a easier procedure?

?
Just remove docker and then add docker, use same paths

@Oekn5w and @eihns : I tried again, and now it worked. Everything good! Thanks for the help!

This is an awesome contribution, thanks so much @Oekn5w!
I'm trying to give it a spin, but I'm getting some warnings:
minecraft    | [Autopause loop] Failed to start knockd daemon.
minecraft    | [Autopause loop] Possible cause: docker's host network mode.
minecraft    | [Autopause loop] Recreate without host mode or disable autopause functionality.

I don't have host networking enabled for this docker container. I do have a custom port mapped, but I tried disabling that with no dice. Are there any more logs I could look into to see exactly why this is failing?

@ouvoun can you clarify what you mean by "a custom port mapped"?

@itzg Sure, sorry for the poor terminology. What I meant is that I am using a custom server port, and my container maps that port to the host. It's not using host network mode, though. I don't think that's uncommon, but maybe it conflicts with the autopause functionality? Here's some relevant snippets from my compose config:
version: "3"

services:
  minecraft:
    container_name: minecraft
    image: itzg/minecraft-server:adopt13
    restart: "unless-stopped"
    ports:
      - 25500:25500
    volumes:
      - ./data:/data
    environment:
      # Docker
      OVERRIDE_SERVER_PROPERTIES: "true"

      # Networking
      ENABLE_RCON: "true"
      ENABLE_QUERY: "false"
      SNOOPER_ENABLED: "false"
      RCON_PORT: 28016
      SERVER_PORT: 25500

      # Suspend
      MAX_TICK_TIME: -1
      ENABLE_AUTOPAUSE: "true"

      ... (other stuff not relevant)

I can file an issue if that would preferred!

@ouvoun can you please bash into the container and run what is described in this comment, additionally the ifconfig output from inside the container?

@Oekn5w My understanding of Docker is that you can't execute in a stopped container (but maybe I'm wrong). When I have autopause enabled it kills the container as soon as it starts to boot due to the failure.
So I tried disabling autopause and then executed within the container. knockd did not seem to be running in that case. Is this helpful, or should I try to run while it's booting with autopause enabled?
bash-5.0# which knockd
/usr/sbin/knockd
bash-5.0# pidof /usr/sbin/knockd
bash-5.0# knockd -c /autopause/knockd-config.cfg
pcap_compile: can't parse filter expression: syntax error
bash-5.0# cat /autopause/knockd-config.cfg
[options]
 logfile = /dev/null
[unpauseMCServer-server]
 sequence = 25565
 seq_timeout = 1
 command = /sbin/su-exec minecraft:minecraft /autopause/resume.sh
 tcpflags = syn
[unpauseMCServer-rcon]
 sequence = 25575
 seq_timeout = 1
 command = /sbin/su-exec minecraft:minecraft /autopause/resume.sh
 tcpflags = syn
bash-5.0# ifconfig
eth0      Link encap:Ethernet  HWaddr 02:42:AC:1A:00:02
          inet addr:<IP_ADDRESS>  Bcast:<IP_ADDRESS>  Mask:<IP_ADDRESS>
          UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
          RX packets:171 errors:0 dropped:0 overruns:0 frame:0
          TX packets:156 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:0
          RX bytes:52058 (50.8 KiB)  TX bytes:16363 (15.9 KiB)

lo        Link encap:Local Loopback
          inet addr:<IP_ADDRESS>  Mask:<IP_ADDRESS>
          UP LOOPBACK RUNNING  MTU:65536  Metric:1
          RX packets:192 errors:0 dropped:0 overruns:0 frame:0
          TX packets:192 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:1000
          RX bytes:13385 (13.0 KiB)  TX bytes:13385 (13.0 KiB)

It doesnt pause the docker, how should it resume then? Its just the java process which is getting paused.
The rewrite is obv. no problem, i use it myself for 2 different minecraft servers. It c hecks the local port inside the docker, not the outer one...

@eihns I'm also using docker-compose, I've developed the feature with compose. The syntax error is throwing me off. I'm currently checking whether it is connected to the adopt13 tag

@eihns I've also decided to stop the container back then when knockd fails, so that one doesn't run it under the assumption that it works
@ouvoun confirmed failing for me with the adopt13 tag, working with latest

@Oekn5w Great sleuthing, thanks! After an initial test I think that everything works with latest. Still need to test the resume functionality, but it does seem to pause successfully!
For what it's worth, I didn't really do any tests to see if adopt13 was actually helping that much, so it's totally fine in my case to just use the default Java installation instead.

@ouvoun setting SERVER_PORT looks like it'll break the autopause function since it is expecting container networking on port 25565:
https://github.com/itzg/docker-minecraft-server/blob/bbe930e55203f80a0cdf4791ce3a8f4ac04c6cd9/files/autopause/knockd-config.cfg#L4
I have clarified the use of SERVER_PORT:
https://github.com/itzg/docker-minecraft-server#server-port

If anyone arrives here and has further issues with autopause functionality, please open a new issue and tag @Oekn5w


[PRM-440] - Added isLPP call to backend to filter points correctly

https://github.com/hmrc/penalties-stub/pull/15
https://github.com/hmrc/penalties-appeals-frontend/pull/90

https://github.com/hmrc/penalties-acceptance-tests/pull/47


More info needed about spotifyConnectLoginid

Checklist

[X] I have filled out the template to the best of my ability.
[X] This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
[X] This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.
Hello,
Could it be possible to elaborate a bit the documentation part about Spotify Connect authentication ?
I can't find WHERE to look for the spotifyConnectLoginid.
Describe the solution you'd like
Add a line of text of where to find the spotifyConnectLoginid in the documentation.
Describe alternatives you've considered
Traditional search method didn't return any valuable help. Google was not my friend...
Additional context
Not the right place to say that but THANK YOU for your time, patience and commitment in this !
Cheers from Belgium !

@J-C-P
Thank you for bringing this to my attention.  The SpotifyPlus ZeroConf Device Connect service wiki documentation has been updated.
To answer your question ...
The loginid value can be obtained by calling the ZeroConf Device Get Information service.  The Spotify loginid value (aka canonical user id) is returned in the user_profile \ id value. It is also the suffix of the Spotify User uri (e.g. spotify:user:xxxxxxxxxxxx) value.
You can also use the Spotify Developer Web-Services API web-site to issue a call to the /v1/me endpoint to retrieve the value for the currently logged in account.

Thanks a lot for your quick reaction !!
The Spotify Developer Web-Services API web-site method is actually the easiest.
When we are not super familiar with Home Assistant, calling a service (and finding all the necessary information to do so) is not as trivial as it may appear to the trained user you are :-)
It works now, thanks a lot again :-)
Have a good weekend,
JC

@J-C-P
Understood.  I have been using HA now for about 3 years, and it's still a learning curve sometimes.  :-)
Glad you have it working.  Please reach out if you need further assistance.
Closing this issue for now.


Add +define+COMMON_CELLS_ASSERTS_OFF

Please  add +define+COMMON_CELLS_ASSERTS_OFF in target/common/common.mk
Env.  docker (main)
Run.
cd /repo/target/snitch_cluster
make bin/snitch_cluster.vlt
Will report error ifndef  COMMON_CELLS_ASSERTS_OFF for common cells.

Hi @franktaTian, do you mean what this line here is doing?
https://github.com/pulp-platform/snitch_cluster/blob/13d1e6b3aaa8e53d5b39858c6ee871b186bf9aa2/target/common/common.mk#L73

I added "VLT_FLAGS    += +define+COMMON_CELLS_ASSERTS_OFF" in this file

Hi @franktaTian, do you mean what this line here is doing?
https://github.com/pulp-platform/snitch_cluster/blob/13d1e6b3aaa8e53d5b39858c6ee871b186bf9aa2/target/common/common.mk#L73

The line I quoted adds exactly the flag you mentioned to the flags in work-vlt/files, and this file is passed in the invocation of the verilator command (see -f option).
Also, the commands you mention are reproduced by the CI and they did not log any errors on the last run.
I will close this issue. Feel free to reopen if you have other details.


[M4MInsiders] Fix automatic docker image update

I saw that an update was made and our fork did not sync.
The installation guide was followed and the Actions Github CI is functional.
I asked the question on the discussion forum.

According to the author, this is not an Insiders problem (no commitment on his side)
Whoever has the rights (Michael) can manually sync the fork (he doesn't see the same thing as I do on the sync button)
The installed Pull App doesn't sync the fork automatically, also for rights issues I think. The mainainer of M4M asks us to check with the Pull App maintainer
Migrating to a dedicated account will not solve the problem according to my discussions
The maintainer is working on another solution than the fork.

While waiting for this other solution, I propose:

to keep the fork in our organization so that everyone can see it
if the changelog indicates a new version, a synchronization and a release will be done manually (the synchro. must be done by michael)


start building object bench

I'm procrastinating here soooo much ...

ok, I'm now starting the work


[Req] Image Opacity update feature

Can you add public function that image opacity update feature in CropViewController?

I can pull req

@bobby-kim-km
I don't quite understand this requirement yet but you are welcome to raise your PR.

@guoyingtao
PR371
This is my PR
If you need anything else, please tell me.
Thank you.

@bobby-kim-km
Thanks for the PR! It is a good idea to add more features like that, but currently Mantis is an image cropping library which focus more on operations like translation, rotation, scale, flip, skew(To do), etc.
I think adjusting image alpha could belong to another image adjusting library like adjusting brightness, contrast, etc.

I close this issue for now. If you want to discuss it again, you can reopen it any time. @bobby-kim-km


Add validators v2.

This PR adds a version 2 of the validators API.
The requirement comes from the number of entries in the Validators array in state on mainnet.  At time of writing there are over 1.4MM entries, and no plans to reduce this number (there are some options that could reduce the number of active validators, but this doesn't help the array itself).  The JSON returned by v1 of this response is over 600MB in size, which has knock-on effects for both speed of delivery (it takes approximately 5s to send this much data over a 1GB link) and decoding time.  As such, a version of this endpoint that supports SSZ would be useful.
The changes in this endpoint from v1 are:

allow SSZ as a return encoding type
remove the status item from the per-validator data
provide the consensus version in the header and JSON metadata

status is a text string in the JSON response for v1 of this call, so does not have a canonical mapping to SSZ.  Instead of removing it, other options are to define a mapping similar to an enum, or to provide it as a byte array.  Both come with added complexity or increased data, and the information that it provides can be calculated from the data that is already provided in the validator struct (plus an epoch).
Some open questions around this endpoint:

should we add an epoch metadata field in the returned data to allow recreation of validator states for when the state identifier used as part of this call is non-numeric (head, finalized etc.)?
should we remove the balance value for each validator?  This value is available from the validator_balances endpoint, does it make sense to still duplicate it here?
could we realistically remove the index value for each validator?  The big benefit of doing this would be that the data returned could be a simple array of Validator objects, which would remove the need for custom structures when decoding SSZ (and, indeed, JSON).  However, there is a significant downside here in that the index information would no longer be easy to obtain.  Countering that, should we be promoting the use of indices anywhere in the API when it's possible that index reuse will become a thing?
if we do not return status, should we still allow filtering the requested values by status?

Ive never really been convinced about the total balance being in this endpoint, so i'd be happy to see it gone.
the overall approach of just having the validator object returned i do like.
allowing SSZ is a great improvement.
could potentially allow an interface to query pubkey and get back a validator index if we wanted to remove the index here... I'm not sure how heavily the flow of looking up /validators just because you need indices is...
i get the impression filtering by status may be used... I'm not against removing it, it does simplify the endpoint... I don't recall if we had a reason or decided it'd be useful...

If we removed index and balance, then ppl that want that info could still retrieve via  /eth/v1/beacon/states/{state_id}/validators/{validator_id}, which is admittedly a single validator at a time... is that sufficient? I can see that endpoint potentially living on, and providing that extra, more targeted information.
I'm a fan of the idea of paring this down to MVP and building out other interfaces if theres a reason...

I'm very back-and-forth on including the index in the output.  It complicates the work required by client teams (requiring a non-spec structure), but is definitely useful information.
An endpoint that would provide mapping between indices and public keys would have to be something like /eth/v1/beacon/states/{state_id}/validator_identities, which took the same input as the validator_balances endpoint and returned a list of index,public_key,activation_epoch (the latter item required if we ever implement validator index reuse).
Because the data is useful, and because most client teams should already have something similar for their implementation of the v1 endpoint, I'm inclined towards it being better to keep index in the output of this endpoint.  But I'm not sold either way.  Does anyone else have strong feelings on this?

I'd be for the new endpoint, and the validators endpoint just having the validator object...

I have put together #452 that provides the validator identities endpoint for review.
I'll have a further consider about how this plays out for validator clients.  Ultimately I suspect that most validator clients would wrap their current call to /validators with calls to both /validators and /validator_identities and then combine them, as downstream structs are likely to carry both validator and index info, but want to think about if there would be any issues with having this data obtained from two separate endpoints.

I am OK with losing the index and balance, but I'm not sold on status.
There is definitely value in being able to filter by status even though it can be calculated from the result. Because if I want to query for all active_exiting validators, then returning over 1MM validators when only a few are exiting is poor.
As for the result, if we drop it then we need the epoch, which doesn't make things simpler than it is now. On the contrary, it makes things more annoying - not only you still have to read a value outside the validator object (and although true that it's necessary only for non-numeric states, client code becomes even more complicated if you return the epoch only sometimes), but you also need extra calculation.

Actually, why can't we just add SSZ support to v1? The only breaking change is the consensus version, but we don't need it since validator objects are the same for every version.

There is definitely value in being able to filter by status even though it can be calculated from the result. Because if I want to query for all active_exiting validators, then returning over 1MM validators when only a few are exiting is poor.

This endpoint still allows filtering by status by passing in the required statuses in the request body.

As for the result, if we drop it then we need the epoch...

There is an open question as to if we return the epoch in the return information (potentially as a header), although for many cases it will not be required as long as the entity carrying out the query knows the genesis of the chain and the current time.

Actually, why can't we just add SSZ support to v1?  The only breaking change is the consensus version, but we don't need it since validator objects are the same for every version.

They have been the same so far, but that's not guaranteed (they were nearly changed for Deneb, and again in Electra).  And returning SSZ without versioning is likely to lead into trouble at some point.

You could still argue that dropping index and balance (and possibly status) is worth it, but even without these fields the response will be huge, so it's not a win big enough to justify a version update.

If all the fields are dropped then it fundamentally changes the return type to move it to an array of pre-existing Validator structs; this is potentially where the PR is going.  But even if not, removal of any of the fields would require a version bump.
The size win is allowing SSZ encoding, which is significantly smaller compared to the JSON encoding.  We could go for an encoding of the status, as mentioned in the OP, which would then potentially open the door for keeping this at V1, but that's something that I think makes more sense to look at after we have decided on the best output for this endpoint.

These are all good points. I am in favor of this.

add to changes table please.

Going back to the questions in the original comment with this PR:

should we add an epoch metadata field in the returned data to allow recreation of validator states for when the state
identifier used as part of this call is non-numeric (head, finalized etc.)?

It seems that there is no objection to this, and it has benefit so makes sense to add.

should we remove the balance value for each validator? This value is available from the validator_balances endpoint, does it make sense to still duplicate it here?

There has been general approval of removing this field.

could we realistically remove the index value for each validator? The big benefit of doing this would be that the data returned could be a simple array of Validator objects, which would remove the need for custom structures when decoding SSZ (and, indeed, JSON). However, there is a significant downside here in that the index information would no longer be easy to obtain. Countering that, should we be promoting the use of indices anywhere in the API when it's possible that index reuse will become a thing?

The introduction of the validator_identities endpoint in #452 solves this issue, and allows this endpoint to return spec structs for both JSON and, importantly, SSZ.

if we do not return status, should we still allow filtering the requested values by status?

This has use, and the logic for calculating status on the server is minimal (and already exists for the v1 endpoint) so it seems that we should keep this ability.
I'll look to make the above changes tomorrow if there are no objections raised.

should we add an epoch metadata field in the returned data to allow recreation of validator states for when the state identifier used as part of this call is non-numeric (head, finalized etc.)?

This makes sense to me, we are polling the api by passing head, while the VC knows the current epoch itself, it feels more correct to use the epoch of the data. This also makes it easier for consumers that query historical data when you query by slot or state root as you don't need to calculate the epoch or might not even know it in the latter case.

should we remove the balance value for each validator? This value is available from the validator_balances endpoint, does it make sense to still duplicate it here?

It saves some work on BN side and reduces size of response, seems reasonable to remove this if nobody is using it

if we do not return status, should we still allow filtering the requested values by status?

Definitely should keep filtering by status

could we realistically remove the index value for each validator?

I am not sold on removing the index and having to call 2 different apis, at least in Lodestar, we wanna know the status of the validator, so just using the proposed validator_identities is not sufficient.
Splitting this into 2 apis, one which just returns the validator object and the other returning the indices is only useful imo if there are consumers which use them independently and even then we can still add the validator_identities if we want a lightweight api for just the indices.
We can probably get away with calling both apis as well since we have SSZ encoding now but if everyone then has to implement custom logic on the VC side to remap indices to validator objects, it does not seem worth it.
Are there any other benefits of dropping the index here besides having to define a new SSZ container for it?

 This IMO is worth while, because the less custom objects we end up with the better. It's just extra work all round to implement the custom object representations (admittedly that work is already done now)
Data wise, the v1 validators endpoint was pretty singularly horrible. I'd be a fan of moving to these two api's just so that 'bad' example isn't in our data models.

I personally dislike losing the status. One example where dropping status makes things much more annoying is if I query by more than one status. I will get back a list of validators and I will have to calculate the status of each validator myself.


Association not found, wrong model used

Hi, I'm having an issue and it is probably in my code, but this is the best place I have to figure out what is going on.
I've got the following models:
user.rb
class User < ActiveRecord::Base
  has_many :work_group_memberships
  has_many :work_groups, through: :work_group_memberships
end

work_group.rb
class WorkGroup < ActiveRecord::Base
  has_many :work_group_memberships, dependent: :destroy
  has_many :users, through: :work_group_memberships
  accepts_nested_attributes_for :work_group_memberships, allow_destroy: true, reject_if: lambda {|a| [a[:user_id], a[:work_group_id]].any?(&:blank?) }
end

work_group_membership.rb
class WorkGroupMembership < ActiveRecord::Base
  belongs_to :user
  belongs_to :work_group

  validates_uniqueness_of :user, scope: [:work_group, :role], message: 'User must have different roles'

  ROLES = [{ title: 'foo', description: 'foo desc' }, { title: 'bar', description: 'bar desc' }]
end

Being used by a form in the following way
work_group/form.html.erb
<%= simple_form_for @work_group, html: {id: :new_work_group}, remote: true, format: :json do |f| %>
  <%= render partial: 'work_groups/steps/step2', locals: {f: f} %>
<% end %>

work_group/steps/_step2.html.erb
<%= f.simple_fields_for :work_group_memberships do |work_group_membership| %>
  <%= render 'work_group_membership_fields', f: work_group_membership %>

    <%= link_to_add_association 'add member', f, :work_group_memberships %>

<% end %>

work_group/_work_group_membership_fields.html.erb

  <%= f.input :id, as: :hidden %>
  <%= f.association :work_group %>
  <%= f.association :user, collection: User.where(organization_id: current_user.organization_id) %>
  <%= f.input :role, collection: WorkGroupMembership::ROLES.collect{|role| role[:title]} %>
  <%= f.input :shadower, as: :boolean %>
  <%= link_to_remove_association "remove member", f %>

When doing this, I get the error
Association :work_group not found

at the line
  <%= f.association :work_group %>

Debugging I see that f is for a work_group, which is not what I'm expecting
>> f.object
=> #<WorkGroup id: nill>

Any insight into what I'm doing wrong?

The problem was on step3, where I am calling the partial again and sending in the wrong thing as f. The code here wasn't enough to show the problem.

I saw your ticket before going to bed, did not see any immediate error. Great you solved it.


Clear out more default settings from AssemblyInfo

There seem to be a large number of different assembly options and different projects end up with different default entries in there. It would be good to pick these up so that the AssemblyInfo gets deleted more often. I expect they don't normally need to be put into the project file if they are just default
Probably fine to remove:
[assembly: AssemblyConfiguration("")]
[assembly: AssemblyTrademark("")]
[assembly: AssemblyCulture("")]

Not sure:
[assembly: NeutralResourcesLanguage("en")]
// Setting ComVisible to false makes the types in this assembly not visible
// to COM components.  If you need to access a type in this assembly from
// COM, set the ComVisible attribute to true on that type.
[assembly: ComVisible(false)]

// The following GUID is for the ID of the typelib if this project is exposed to COM
[assembly: Guid("...some-unique-guid...")]

I'm now handling these in https://github.com/hvanbakel/CsprojToVs2017/pull/167
[assembly: AssemblyConfiguration("")]
[assembly: AssemblyTrademark("")]
[assembly: AssemblyCulture("")]

Meanwhile [assembly: NeutralResourcesLanguage("en")] is now just moved to csproj file. I don't think "en" is the default anyway.
ComVisible is a bit of an unknown as I think the default is actually true if the attribute isn't there, but VS adds it as false by default.
I'll raise as a separate issue

The only remaining one I know about is ComVisible which I've raised as a separate issue so I think this one can be closed as fixed in #167


I hope sigh will run on Linux later

###功能请求
Feature Request
Motivation Behind Feature
Most services run on Linux systems and can be combined with more services if they run on Linux
Feature Description
no
Alternatives or Workarounds
no idea

Yes, we hope that as well. Will be difficult though as some Apple programs are not available on Linux and there are no workarounds available.


New rule : indent-delta

Add a new optional rule to check indentation level between 2 consecutive lines.

\t\t
test

\t
test

\t\t
test

Could be improved if necessary with checking whether the indentation should increase or decrease based on whether HTML elements are closed or opened.

Coverage remained the same at 100.0% when pulling 2b0d489a50605e59b2594bd22d784958aa1b3f70 on loicbourgois:indent-delta into f902b462c295321d2e3d494299f6b207b574a9e5 on htmllint:master.

Looks good. I assume including package-lock.json was a mistake and have removed it. I also changed the handling of spaces followed by tabs (the tab should go up to the next multiple of width) and fixed the empty-line check so that it accounts for line endings with CR.
Using indent-width for the tab size as well as the indent width might not always be right, but I'll wait for someone to complain before adding a tab-width option.


Patch counter

Motivate of the pull request

[ x] To address an existing issue. If so, please provide a link to the issue: #442
[x ] Breaking new feature. If so, please describe details in the description part.

Added a workflow file which will automatically count the total number of patches after the certain tag and update this number in CMakeList.txt.

Which part of the code base require a change

[ ] VPR
[ ] Tileable routing architecture generator
[ ] OpenFPGA libraries
[ ] FPGA-Verilog
[ ] FPGA-Bitstream
[ ] FPGA-SDC
[ ] FPGA-SPICE
[x ] Flow scripts
[ ] Architecture library
[ ] Cell library
[ ] Documentation
[ ] Regression tests
[ x] Continous Integration (CI) scripts

@tangxifan  I have tested this workflow file on hard forked of OpenFPGA. It works okay.
To push changes back, it has to be run on master branch.


Firebase auth TOKEN fails on Travis!

https://travis-ci.org/readium/readium-js-viewer/jobs/136713348#L4009
"firebase" key in firebase.json is deprecated. Run firebase use --add instead
⚠  Deprecation Warning: Firebase Hosting configuration should be moved under "hosting" key.
Error: Your refresh token has been revoked, please run firebase login to obtain a new one.

...which means that Surge.sh is up to date, but not Firebase.io:
https://readium.firebaseapp.com
https://readium.surge.sh

Error: Command requires authentication, please run firebase login
https://travis-ci.org/readium/readium-js-viewer/jobs/136741604#L3989

Finally fixed!
https://github.com/readium/readium-js-viewer/commit/659519a02454e864ac21c4c3e59247709cd676a1


KeyError: "name='csrftoken', domain=None, path=None" for every action

About a week ago, instaloador was working fine in my pc, since today I get this error when calling instaloader from command line. I cheked with the current version both in windows and linux and the issue is the same.
Session file does not exist yet - Logging in.
Traceback (most recent call last):
  File "C:\Python36\Scripts\instaloader-script.py", line 11, in <module>
    load_entry_point('instaloader==4.0.2', 'console_scripts', 'instaloader')()
  File "c:\python36\lib\site-packages\instaloader\__main__.py", line 334, in main
    storyitem_filter_str=args.storyitem_filter)
  File "c:\python36\lib\site-packages\instaloader\__main__.py", line 87, in _main
    instaloader.login(username, password)
  File "c:\python36\lib\site-packages\instaloader\instaloader.py", line 324, in login
    self.context.login(user, passwd)
  File "c:\python36\lib\site-packages\instaloader\instaloadercontext.py", line 181, in login
    session.headers.update({'X-CSRFToken': resp.cookies['csrftoken']})
  File "c:\python36\lib\site-packages\requests\cookies.py", line 329, in __getitem__
    return self._find_no_duplicates(name)
  File "c:\python36\lib\site-packages\requests\cookies.py", line 400, in _find_no_duplicates
    raise KeyError('name=%r, domain=%r, path=%r' % (name, domain, path))
KeyError: "name='csrftoken', domain=None, path=None"

Thanks for reporting this! I fixed it in version 4.0.3.


feat(tutorial): complete step 3 - Endicott!

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

Who, so impressive!


add expression body as one of fix to offer

added expression body fixes as one of code clean up as requested

@JieCarolHu @jinujoseph @kuhlenh
Simon Calvert asked this to be added. so I added here. @JieCarolHu can you accept my change?

I will go ahead and create signed bit from this.


Issue with missing images in gstencil file create by convert.sh

When opening the initial .gstencil files created by convert.sh Omnigraffle complains about duplicate / missing image id's
Also some of the .gstencil files have 300+ items in them when it should 70 at most (Compute)

Fixed in #11


react-relay/classic usage?

Hey @edvinerikson, first, thanks for putting this together in the first place. We've been using it extensively for the last 6 months.
I was wondering if you have any thoughts on how to use this alongside relay 1.0. I'd love to be able to use it with relay/classic so that we can incrementally upgrade to relay-modern (using the relay-modern subscriptions requires moving to the relay-modern store, which requires upgrading everything at once).
I tried forking this bad-boy, upgrading to react-relay 1.0 and importing react-relay/classic instead of react-relay, but I can't seem to get it to work. I assume (although I don't know) that it's because the direct imports you have from react-relay/lib... now point to the relay-modern versions, but was curious if you had thoughts.
Thanks!

I think that's the only thing, BTW – just need to update the imports here and cut a breaking release.

Hello, thanks for raising the issue :)
I will not be able to do this myself until weekend but I will definitely be able to merge a PR if any of you send one. 😊

@edvinerikson I'll work on a PR, but my attempts so far have been failures (should be simple; not sure where I'm going wrong). So, if you still have time this weekend to take a stab, that would be much appreciated!

The changes are published as 2.0.0
Thanks for the help! :)

Woot! Thanks man!


build: upgrade to go 1.19

Can you update this to 1.19.1 now that it is out? It fixes 2 security issues.

@bnpfeife - fyi this PR when you are looking at 2.x.

Commit bd6869f377b35a1bc117bbcbe644b241d202c10a is the only change of note in this PR. The sort algorithm was changed in 1.19, so the tests needed to be updated accordingly.


Towny Support

Plugin Version:

2.10.1
Request:

Add towny claim support similar to worldguard support.
How/Why:

This feature would allow players to only teleport into areas where they have access to, rather than randomly teleporting into another town's house and being stuck.
Additional Context:

I will see if I can implement this, would this be the plugin page you mean for Towny (I've never used it)? Also, if possible, could you direct me to a integrations page to be able to find it a little bit quicker

Yes, that is the plugin page.
https://github.com/TownyAdvanced/Towny/wiki/TownyAPI#getting-started-with-towny-and-your-ide

Alright, I am currently getting back to working on the project, I will try to add Towny support when possible, I will let you know if/when its been added on my local machine.

Sure, thanks.

Just came across this plugin and looks good so far! I've done towny support this in my rtp plugin: https://github.com/DarkEyeDragon/RandomTeleport/blob/dev/src/main/java/me/darkeyedragon/randomtp/validator/TownyValidator.java
Essentially just check if the location is in wilderness or not, or whatever constraints you want. The api is alright to use.

this will be added in 2.12.3 coming very soon ;)


relabel cluster to not include account number

This will (hopefully) relabel cluster values from something like<PHONE_NUMBER>99:my-integration-instance to my-integration-instance.
Also fixes integer port number that should be string

@rccrdpccl can you clarify a bit more about what this label means?

@rccrdpccl can you clarify a bit more about what this label means?

Sure, this label identifies the name of the Elasticsearch cluster. As it is taken from AWS, it is prefixed by the account number, which generally speaking it's a good idea. However in our case I think it just adds noise, and we should just get the name of the cluster.
In our case this means we'll have 3 values, one each environment (although they will never coexist at the same time in the same prometheus instance)
This PR is just taking the cluster name and removing the prefix. I am not 100% sure prometheus will allow to override the value without creating a new label, but I could not find documentation specifying this. I guess we can try and worse case I'll fix it.


add GitHub action based CI

Fixes #791
Signed-off-by: aserkes<EMAIL_ADDRESS>

Where is the action based run ? I don't see related commit statuses.

I think that at first we have to add this workflow to the repository by merging the PR


Create a Golang struct for collection objects

I guess first it needs to be determined whether they are all the same...

https://edan.si.edu/openaccess/docs/more.html
https://sirismm.si.edu/siris/EDAN_IMM_OBJECT_RECORDS_1.09.pdf

"The primary content in the repository at this time is collection data which we type as edanmdm."


Refactor dependency installation

Closes #359
This PR achieves the following:

Ensures synchronization with system environment variables when executing shell commands/child processes in the VSCode extension
Fixes bugs with Windows installation & notifies the user that they must restart vscode after installing dependencies (this is a constraint of Windows since new pseudoterminals started in VSCode inherit the parent environment variables and are not executed as login shells like Unix.  We can reload environment variables for processes we spawn but not those managed by VSCode)
Removes CI-specific hardcoded flow command.  This didn't represent a real environment and caused a disparity between integration tests and what the user actually experienced.
Moves dependency installation to interactive VSCode terminals so that the user can see the installation progress better
Breaks up Flow CLI and Homebrew into two separate dependencies & resolves the order in which dependencies must be installed based on the dependency tree (homebrew is only a Unix dependency)
Makes dependency installation an asynchronous process instead of running synchronously
Patches an issue with statecache subscriptions returning undefined

For contributor use:

[x] Targeted PR against master branch
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[x] Code follows the standards mentioned here
[x] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[x] Added appropriate labels

Merging this now.  Have tested all of the following in Ubuntu, MacOS, Windows

Install dependencies from fresh install
Install externally then open VSCode
Update Flow CLI

Will continue testing before release, but it's just starting to drag on and block other PRs


Added DBMS resource in free-programming-books-langs.md file

What does this PR do?
Add resource(s) | Remove resource(s) | Add info | Improve repo
For resources
Description
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[x] Read our contributing guidelines
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction)

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

Page 4:

N O T I C E:
This  work is protected  by U.S.  copyright  laws  and is  provided  solely
for the  use  of college  instructors  in  reviewing  course  materials  for
classroom  use.  Dissemination  or sale  of this  work, or any part
(including  on the  World Wide Web),  is  not  permitted.

I don't think this book can be in this repository.


Update files for AppVeyor and Codecov

Pull Request (PR) description
Update files for AppVeyor and Codecov.
This Pull Request (PR) fixes the following issues

Task list

[ ] Added an entry under the Unreleased section of the change log in the README.md.
Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@68089c2). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             dev     #14   +/-   ##
=====================================
  Coverage       ?   1.91%
=====================================
  Files          ?      10
  Lines          ?     575
  Branches       ?       0
=====================================
  Hits           ?      11
  Misses         ?     564
  Partials       ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68089c2...68a4c8c. Read the comment docs.


Wasm: remove reference to EETypePtr - replace with EEType*

This follows the discussion https://github.com/dotnet/corert/pull/8173 and removes the use of EETypePtr from Wasm codegen.  How did this work before?  I suspect its the liberal use of casting when getting expressions off the expression stack, e.g. https://github.com/dotnet/corert/blob/312c7ad0eb935ba51038518ad2dd317666e6bf63/src/ILCompiler.WebAssembly/src/CodeGen/ILToWebAssemblyImporter.cs#L848.
I haven't changed the generic lookups here, they are still using i8*.  I did do the work for changing them so if you want them in it would be easy enough?

I haven't changed the generic lookups here, they are still using i8*.

I think it would be better to avoid any direct differences to EEType* in the codegen, and use opaque pointer like i8* instead . Are there going to be any problems if GetPEETypeTypeDesc is changed to return i8* like in the case of generic lookups?

That should be fine.  Will get on it.


Appium documentation link generates 404

The main readme points to http://appium.io/slate/en/master/?ruby#windows-application-ui-testing which has vanished, and despite searching appium.io documentation, I could only find a heavily modified page at https://appium.io/docs/en/drivers/windows/ for which I'm not fully sure if it covers the late 2017 copy on The Internet Archive: https://web.archive.org/web/20171024045829/http://appium.io/slate/en/master/?ruby#undefined
If anybody finds a better page, please suggest one, otherwise, a decision needs to be made on the modified page ore the archived one.

Thanks for bringing this to our attention @jpluimers. I've update the link to point towards the most recent Appium page for Windows Driver.

Thanks!

It looks fine to me - where do you see it is broken?


Why is rounding the default?

Shouldn't rounding be more in the realm of the user and their particular use case (display method, graph system, etc) rather than the default?
While you can change the precision, there's still going to be some precision loss by the nature of the rounding formula used here if you end up in overflow or underflow scenarios. It would seem to me better to provide the "raw" values by default and rounding as opt-in.

Completely agree on this one - worse yet, the rounding does not adjust for decimal values, and is done during calculations, not after the fact, resulting in wildly incorrect r2 values, and bad results.
There NEEDS to be a way to opt-out of rounding - and while changing the default would be semi-breaking (could cause existing projects to overflow UIs), the current design is problematic enough that it is really worth considering (moving rounding to after the fact only would also help)
Example of incorrect r2:


"err.includes()" is not a function

From logs:
[2019-07-04 07:17:45.088] [INFO] [default] - <IP_ADDRESS> POST ieslp.carto.com/api/v1/map?api_key=fe5224f6124e15f965dd9b34fe9d47d9d575603a 400 91922 ms -> application/json; charset=utf-8 ({"createmap_initPr
ofilerMiddleware":1,"anonymous_getMapConfig":420,"error":91498,"overviewsAddedToMapconfig":false,"mapType":"anonymous","total":91919}) ({"mainError":{"statusCode":400,"message":"err includes is not a function
","name":"Error","label":"ANONYMOUS LAYERGROUP","type":"layer"},"moreErrors":[]})

Duplicate https://github.com/CartoDB/grainstore/issues/152 ??

Sure!


"unrecognized error format" thrown on SCSS save

How to reproduce:

Install scss_lint:
 gem install scss_lint

Open SCSS file in Vim

Save it

What happens: warning is thrown:
syntastic: warning: checker scss/scss_lint: unrecognized error format

What should happen: warning should not have been thrown.
Platform: scss_lint 0.49.0, ruby 2.3.1 and aa2a09110956e46652a9cb247ec24a57797066fd of syntastic

Please post a test file that can be used to reproduce the problem.

It happens with any SCSS file.
I tested further. Problem relates to Ruby 2.3.1.  The warning is not there when scss_lint gets run on older rubies, e.g. 2.1.5 or 2.2.4.

Please open your test file, set g:syntastic_debug to 3, run :SyntasticCheck scss_lint, run :mes, and post the output.

Looks like a scss_lint problem to me:
Messages maintainer: Bram Moolenaar<EMAIL_ADDRESS>
"_sass/base/_body.scss" 5L, 71C
syntastic: 8.326664: &shell = '/opt/local/bin/bash' (!), &shellcmdflag = '-c', &shellpipe = '2>&1| tee', &shellquote = '', &shellredir = '>%s 2>&1', &shellslash = 0, &shelltemp = 1, &shellxquote = '', &shellxesc
ape = ''
syntastic: 8.327144: UpdateErrors: scss_lint
syntastic: 8.327419: CacheErrors: scss_lint
syntastic: 8.328007: g:syntastic_aggregate_errors = 0
syntastic: 8.328268: getcwd() = '/Users/ain/Documents/projects/tekkie'
syntastic: 8.349347: system: command run in 0.011354s
syntastic: 8.820330: system: command run in 0.451474s
syntastic: 8.820740: CacheErrors: Invoking checker: scss/scss_lint
syntastic: 8.821543: SyntasticMake: called with options: {'postprocess': ['guards'], 'preprocess': 'scss_lint', 'errorformat': '%f:%t:%l:%c:%n:%m', 'makeprg': 'scss-lint -f JSON _sass/base/_body.scss', 'returns'
: [0, 1, 2, 65, 66]}
syntastic: 9.134846: system: command run in 0.312920s
syntastic: 9.135008: checker output: ['/Users/ain/.rvm/rubies/ruby-2.3.1/lib/ruby/2.3.0/rubygems/specification.rb:2158:in `method_missing'': undefined method `this'' for #<Gem::Specification:0x3fed0d022b98 scss_
lint-0.49.0> (NoMethodError)', '^Ifrom /Users/ain/.rvm/rubies/ruby-2.3.1/lib/ruby/2.3.0/rubygems/specification.rb:1057:in `find_active_stub_by_path''', '^Ifrom /Users/ain/.rvm/rubies/ruby-2.3.1/lib/ruby/2.3.0/ru
bygems/core_ext/kernel_require.rb:64:in `require''', '^Ifrom /Users/ain/.rvm/gems/ruby-2.3.1/gems/scss_lint-0.49.0/bin/scss-lint:3:in `<top (required)>''', '^Ifrom /Users/ain/.rvm/gems/ruby-2.3.1/bin/scss-lint:2
3:in `load''', '^Ifrom /Users/ain/.rvm/gems/ruby-2.3.1/bin/scss-lint:23:in `<main>''', '^Ifrom /Users/ain/.rvm/gems/ruby-2.3.1/bin/ruby_executable_hooks:15:in `eval''', '^Ifrom /Users/ain/.rvm/gems/ruby-2.3.1/bi
n/ruby_executable_hooks:15:in `<main>''', '']
syntastic: warning: checker scss/scss_lint: unrecognized error format
syntastic: 9.138289: preprocess: []
syntastic: 9.138509: raw loclist: []
syntastic: 9.139247: postprocess: []
syntastic: 9.139407: getLocList: checker scss/scss_lint returned 1
syntastic: 9.139526: scss/scss_lint raw: []
syntastic: 9.139689: quiet_messages filter: {}
syntastic: 9.139812: getLocList: checker scss/scss_lint run in 0.318883s
syntastic: 9.140086: aggregated: {'_sorted': 0, '_name': '', '_owner': 1, '_columns': 1, '_rawLoclist': []}

syntastic: 9.135008: checker output: ['/Users/ain/.rvm/rubies/ruby-2.3.1/lib/ruby/2.3.0/rubygems/specification.rb:2158:in method_missing'': undefined method this'' for #<Gem::Specification:0x3fed0d022b98 scss_lint-0.49.0> (NoMethodError)'...

Please fix your installation and try again.  Feel free to re-open this if / when you can actually point to a problem related to syntastic.

Not a Ruby problem. 2.3.1 is installed properly. As I said, it's a scss-lint problem. Thanks nevertheless.
$ scss-lint _body.scss
/Users/ain/.rvm/rubies/ruby-2.3.1/lib/ruby/2.3.0/rubygems/specification.rb:2158:in `method_missing': undefined method `this' for #<Gem::Specification:0x3fc5f5888e34 scss_lint-0.49.0> (NoMethodError)
	from /Users/ain/.rvm/rubies/ruby-2.3.1/lib/ruby/2.3.0/rubygems/specification.rb:1057:in `find_active_stub_by_path'
	from /Users/ain/.rvm/rubies/ruby-2.3.1/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:64:in `require'
	from /Users/ain/.rvm/gems/ruby-2.3.1/gems/scss_lint-0.49.0/bin/scss-lint:3:in `<top (required)>'
	from /Users/ain/.rvm/gems/ruby-2.3.1/bin/scss-lint:23:in `load'
	from /Users/ain/.rvm/gems/ruby-2.3.1/bin/scss-lint:23:in `<main>'
	from /Users/ain/.rvm/gems/ruby-2.3.1/bin/ruby_executable_hooks:15:in `eval'
	from /Users/ain/.rvm/gems/ruby-2.3.1/bin/ruby_executable_hooks:15:in `<main>'

Well, either way, it isn't something syntastic can work around.  There should be some better way for syntastic to detect crashes, or at least to figure out earlier what's going on, but there isn't.


Fix rabbitmq file descriptor limit validation

Only run this validation on the controller since that's where rabbitmq
is running, and simplify parsing of file descriptor limit which didn't
work properly.

Nice, thanks!


Swift 2.3/3.0 and NSPersistentContainer recommendations

Feature Request
Adopt Swift 3.0 toolchain, API naming, and syntax.
Add usage recommendations with regards to NSPersistentContainer availability (iOS 10 macOS 10.12)
Provide Swift 2.3 branch as well

Swift 2.3 support in v1.3.0
Swift 3.0 support in v2.0.0


App hangs when WrappingHStack is used in NavigationView > ScrollView

Describe the bug
Sometimes app hangs when WrappingHStack is used inside a NavigationView > ScrollView. Removing WrappingHStack fixes the problem.
Example
    var body: some View {
        NavigationView {
            ScrollView {
                WrappingHStack(viewModel.responsibilities, alignment: .center, spacing: .constant(10), lineSpacing: 10) { responsibility in
                    Text(responsibility.name)
                }

            }
            .navigationTitle("Directory")
            .navigationBarTitleDisplayMode(.large)
        }
    }

Screenshots

Context:

WrappingHStack version: [2.2.2]
Model: [iPhone 14 Pro]
OS: [iOS 16.0.2]

Closing for now, if you still have this issues 2.2.3, please reopen.


Solving n+1 and integrating specs

This pull request has been created against below mentioned implementations in the project:

[x] Set up default values for counters.
[x]  Fixed the n+1 problem for Posts#index view.
[x]  Updated existing Rspec examples.
[x]  Wrote unit tests for Users#index view.
[x]  Wrote unit tests for Users#show view.
[x]  Wrote unit tests for Posts#index view.
[x]  Wrote unit tests for Posts#show view.


Improve SEO for FlowForge.com

Description
Allowing users to find us, instead of vice versa is very important for the scalability of the marketing efforts.
This epic collects the efforts to be made in Q1 2023, as SEO is likely a constant consideration.

@Pezmc Any update on this? Hubspot still reports over 1000 issues, and we started with 1500-ish. Think that reduction is not quite what I'd expect after a month of effort?

Performance is improved across the board and Google itself reports a pass on the Core Web Vitals Assessment (based on real world usage) and good performance (between 80-100) on both mobile and desktop for several key entry points I checked:

[flowforge.com](https://pagespeed.web.dev/analysis/https-flowforge-com/jsjvrcne55?utm_source=search_console&form_factor=mobile&hl=en
flowforge.com/pricing
flowforge.com/docs
flowforge.com/features
flowforge.com/blog/2023/03/comparing-node-red-dashboards/

When making its assessment HubSpot appears to only consider TBT as a metric, rather than combining several metrics, and has set a threshold of 200ms.
Unfortunately, there's no that much more we can do further to improve TBT other than the existing summary on the performance improvement issue. Most possible improvements are related to third party code performance, which we do not have control of, remaining options include:

Stop using Hubspot forms
Stop using Hubspot tracking
Stop using Google Tag manager
Stop using PostHog
Change the TTL on third party scripts (or on GitHub pages) - neither of which we control.

In short, the items left aren't reasonably actionable and for now, this is as good as we can get on most pages. If you spot anything that could be actioned, or are happy reducing our use of third party tools, please let me know!

@ZJvandeWeg any particular reason for this being open? We'll always be wanting to improve SEO, but not sure it's worth keeping an issue open for?


Maximum call stack size exceeded error in production mode

🐛 Bug Report
I make a react component using styled (from @mui/material/styles, @emotion), it will crash when the reducer change.
If the data use a native div or "Box" component (from material-UI), it will not crash.
It doesn't crash when I use development mode.
Link to repro
link: https://toy9986619.github.io/immer-issue/
repo: https://github.com/toy9986619/immer-issue
To Reproduce

insert an styled component instance create from emotion to immer state.

Observed behavior
An error comes from immer code
Uncaught RangeError: Maximum call stack size exceeded
at Object.hasOwnProperty ()
at common.ts:45:25

Expected behavior
Will not have error
Environment

Immer version: 9.0.16
[ ] I filed this report against the latest version of Immer
[ ] Occurs with setUseProxies(true)
[ ] Occurs with setUseProxies(false) (ES5 only)

Sorry, I need to check this issue is from redux-toolkit lib or immer first.

actions.addHintMsg({
   [immerable]: false
   ...

or in addHintMsg call Object.freeze on the incoming object first will probably do the trick

Thanks for your reply, I agree the project is too big now.
I know there are some unsafe actions when using redux, but it is a base code in our project now.
I roll back the redux reducer to use the mutable reducer. I avoid the issue now.
I will try to narrow down the test and find out if it can reproduce or not.
I think I can close the issue now.

@toy9986619 : yeah, it sounds like you're trying to put a component instance or similar into the Redux state, and you absolutely should not ever do that!

https://redux.js.org/style-guide/#do-not-put-non-serializable-values-in-state-or-actions


Configure TLS Verification Skip in Chart Repository Config in Rancher UI

Is your feature request related to a problem? Please describe.
When creating a Chart Repository, I cannot configure an option in the Rancher UI to allow downloading a repo's index over insecure HTTPS.
Describe the solution you'd like
A checkbox or simple configuration parameter to allow downloading a repo's index via insecure HTTPS in the Rancher UI.
Additional context
https://github.com/rancher/rancher/blob/3573c0a4eb03718cb9bcf5ee797ace58a60e1791/pkg/apis/catalog.cattle.io/v1/types.go#L40
Could this line be a configurable parameter in the UI?

Bumping to not go stale.

Bumping once again


chore: update Very Good Analysis to 5.1.0

Description
Updates Very Good Analysis to 5.1.0, for more information see here.
Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠 Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[X] 🗑 Chore

Drafted until the current Dart SDK is bumped to 3.0.0


iconDir configuration option

Feature Request
Add a root level iconDir configuration to specify a directory other than the publicDir for icons.
Is your feature request related to a bug?
N/A
What are the alternatives?
Manually entering the icons in the manifest: https://wxt.dev/guide/manifest.html#icons.
Additional context
Add any other context or screenshots about the feature request here.

Why do you need to put the icons in a different directory?

Some complicated mess with copying assets from a submodule. I'll just add a script to do some janky stuff in the before hook ahah.


cache.purgeall()

When a database is deleted, remove all entries from the cache for that database.

:+1:


use external name when remote pilot addr is hostname

fixes: https://github.com/istio/istio/issues/24155
[ ] Configuration Infrastructure
[ ] Docs
[x ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

In response to a cherrypick label: #24219 failed to apply on top of branch "release-1.6":
error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	operator/cmd/mesh/testdata/manifest-generate/data-snapshot/charts/base/templates/endpoints.yaml
M	operator/cmd/mesh/testdata/manifest-generate/data-snapshot/charts/base/templates/services.yaml
Falling back to patching base and 3-way merge...
Auto-merging operator/cmd/mesh/testdata/manifest-generate/data-snapshot/charts/base/templates/services.yaml
Auto-merging operator/cmd/mesh/testdata/manifest-generate/data-snapshot/charts/base/templates/endpoints.yaml
CONFLICT (content): Merge conflict in operator/cmd/mesh/testdata/manifest-generate/data-snapshot/charts/base/templates/endpoints.yaml
Patch failed at 0001 use external name when remote pilot addr is hostname

In response to a cherrypick label: new issue created for failed cherrypick: #24269

@linsun I had a question on this change. Why is it only applied to the istiod service and not istiod-remote?

@rolandkool yeah indeed! we are actually having this issue with the istiod-remote. I'd love to have this also in there since it's blocking us to have a Multi-cluster in AWS 😔


Compare multiple models and monitor their stage

Hey folks, vetiver is a pretty nice and straightforward tool to use.
The only important thing I'm missing is the ability to compare multiple models and monitor the stage (e.g. 'production') of each model (as MLflow does).
Do you have plans to add that or it is beyond the scope of vetiver?
And just a side question, in VetiverAPI() is it possible to change to a custom endpoint instead of the default 'predict'?
Thank you

Hey there--thanks @GitHunter0, these are fantastic questions! Model comparison is something that we have thought about, but are definitely interested in hearing what users would want! What you could do now is have a function run vetiver.compute_metrics for each model and differentiate between models by adding a column of the model name. Is that close to what you are thinking for model comparison?
The default /predict endpoint is created by running the vetiver_post method on VetiverAPI() creation using handler_predict on a VetiverModel() object. If you would like a different named endpoint, you could do something like
api = VetiverAPI(my_model)

api.vetiver_post(my_model.handler_predict, "myendpointname", check_prototype=True)

to add another endpoint with the same functionality. Hope that helps!

Hey @isabelizimm , thanks for your thoughtful feedback.

vetiver.compute_metrics for each model and differentiate between models by adding a column of the model name. Is that close to what you are thinking for model comparison?

It is something among those lines but in a more streamlined and detailed fashion. I'm posting two MLFlow UI screens as example:

api = VetiverAPI(my_model)

api.vetiver_post(my_model.handler_predict, "myendpointname", check_prototype=True)

That worked, I appreciate it.

@GitHunter0 one thing we've noticed when talking to users is that almost everyone has pretty high customization needs when it comes to model monitoring, so we want to take a "code first" approach to monitoring by creating modular functions (like vetiver.compute_metrics that @isabelizimm mentioned) plus some templates (using Quarto).
You may have noticed the Model Card template, and the R side of vetiver does have a monitoring dashboard template (see it rendered and published). These kinds of templates are definitely in scope for vetiver, and our expectation would be that someone like you would use them as a jumping off point for their (individual, customized) needs. Would definitely love to hear more about what you are wanting to do!

Are you interested in more of a report or more of a dashboard?
What would you be looking for in terms of comparing multiple models? A table with statistical metrics? Or more of a way to keep track of all your deployed models (sometimes I hear this called a "dashboard of dashboards", i.e. mostly about linking to individual model information)

Hey @juliasilge , sorry for the delay, thanks very much for the detailed follow up.

Are you interested in more of a report or more of a dashboard?

More of a dashboard, because the needs of my reports are too specific to be included in a general package.

What would you be looking for in terms of comparing multiple models? A table with statistical metrics? Or more of a way to keep track of all your deployed models (sometimes I hear this called a "dashboard of dashboards", i.e. mostly about linking to individual model information)

Actually, I would like all of that, they are all helpful features in my opinion, I believe MLflow is a good reference in this regard.
And last,  It would be nice to have a way to deploy multiple models at once, each one to a specified endpoint.
I believe with those additional features, vetiver will be used by a much larger audience, especially considering the quality and design of RStudio packages, the products you folks deliver are the best.

Awesome; thank you so much for those details. We're waiting on a flexdashboard-style format for Quarto but in the meantime, we could work on initial reporting examples for model monitoring, comparing multiple models, etc.


Install Instructions - Fail to Run Black

Environment

Python version:   3.11
cookiecutter-nautobot-app template version:   Develop

Observed Behavior
When tried to run black . it failed to run due to the poetry environment not being installed yet

Expected Behavior
Black to run

Steps to Reproduce

Follow the install instructions
Get to the part about black . and get the failure.

Can we close this issue given the move from black to ruff for formatting? (Though see #119).

Closing as Black is no longer in any of the cookies.


Force remove workloads before removing ClusterQueues in AfterEach e2e tests.

What type of PR is this?
/kind bug

What this PR does / why we need it:
Force remove workloads before removing ClusterQueues in AfterEach e2e tests.
Which issue(s) this PR fixes:

Fixes #2620
Fixes #2621
Special notes for your reviewer:
We already fixed similar issue for visibility #2608.
Does this PR introduce a user-facing change?

NONE

/cherry-pick release-0.7
These errors were observed in 0.7 as well.

@mbobrovskyi Could you manually open a cherry-pick PR?