raw-loader/sharpziplib

Hi, since the raw-loader sometimes (couldn't figure out why or when) returns a Module with the code being in .default i added a function extracting the real code if it happened.
This seems to be a known issue: https://github.com/webpack-contrib/raw-loader/issues/72
I also worked around a nasty bug caused by some locale settings in SharpZipLib. see: https://stackoverflow.com/questions/46950386/sharpziplib-1-is-not-a-supported-code-page

I would prefer to add .default where it is needed instead. I do think getString add a small layer of complexity that is not reallly needed.

the problem is, sometimes the result does not have a .default but simply is a string.
It actually changed back and forth while i was trying to find this problem

Did you try to use import instead of require? Because if I understand the comments from the maintainer of raw-loader it shoulds works using import statements.
And if import works then it just using "standard" module API.
If it doesn't, I will merge the your PR as it is :)

Hmm, maybe the solution is to discard the raw-loader altogether and just trigger the load of the default sample if the state is empty (that would also improve a little the bundle size).
About SharpZipLib, I think it's not used anymore in the build.fsx script, since we're taking the Fable bundle now from npm.

About SharpZipLib, I think it's not used anymore in the build.fsx script, since we're taking the Fable bundle now from npm.

DotNetCoreInstall still uses it

And if import works then it just using "standard" module API.
couldn't get the import working with the raw-loader sadly

Let's merge this. Thanks a lot for your help @krauthaufen!

The REPL won't be updated right away, because I need to update the assemblies and it takes some time, sorry!

Great, Btw. I'm currently working on generating the repl-lib-map.json automatically (since i want to add lots of libraries for my own little repl).

That'd be great! Just bear in mind the libraries for the Fable REPL are a bit hacky at the moment, as they're being precompiled at the moment to prevent too long compilation times. Besides the repl-lib-map.json you need to remember to set the FABLE_REPL_LIB defined constants which basically just also outputs inlined functions (which doesn't work for precompiled libraries).


Do django-vue-template support vue-cli 2.x and python 2?

Template uses vue-cli 3
You could use vue cli 2 but the resulting app structure would be very different.
Django 2.1+ does not support Python 2
https://docs.djangoproject.com/en/2.1/releases/2.1/#python-compatibility


Use 'virtual path' style URLs for avatar uploads

Per #17762 - use virtual path style so that S3 compatible endpoints work.

Testing plan:
GIFs or screenshots:

@recursivecodes can you provide a clear source for the new URL format in this PR being supported by S3?

The formats are discussed in this post:
https://aws.amazon.com/blogs/aws/amazon-s3-path-deprecation-plan-the-rest-of-the-story/
As you can see, the deprecation plan (per the update at the top) was postponed indefinitely, so the "path style" URLs will work for the foreseeable future (and they will give at least a year's notice before changing, if they do).
I've spoken to our engineers at Oracle, and the issue with supporting the "virtual" style is managing SSL certs. They are working on it, but there is not a sense of urgency at this point. I'm sure other cloud providers will have the same issue.
Bottom line: either style works for AWS. :)

I think we probably don't want to do this change unconditionally; how about we add a S3_PATH_URL_FORMAT setting, which if True enables this deprecated style?

I think that's absolutely a fair compromise.
On Thu, May 6, 2021, 9:04 PM Tim Abbott @.***> wrote:

I think we probably don't want to do this change unconditionally; how
about we add a S3_PATH_URL_FORMAT setting, which if True enables this
deprecated style?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip/pull/18284#issuecomment-833983517, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ73LTXTJJUSVOJSD5Q6JT3TMM4DNANCNFSM43VSXNNQ
.

Sorry, let me clarify: we should not change the default, and we need to think about the security implications of adding an option. See CVE-2017-7807 for example.

This is from 4 years ago and appears to have been long patched. As stated in the AWS blog post above, Amazon supports the "path style" URLs and will do so for the foreseeable future (promising to give a year's notice before removing if they ever do).

Closing in favor of #16612.


Getting CORS error on uploading file on AWS S3

Here is my jsx code:
<ReactS3Uploader
    getSignedUrl={props.getSignedUrl}
    accept="image/*"
    onProgress={onProgress}
    onError={onError}
    onFinish={onFinish}
    uploadRequestHeaders={{
        'x-amz-acl': 'public-read'
    }}
    contentDisposition="auto"
/>

Here is my method:
getSignedUrl = async (file, callback) => {
    const { dispatch } = this.props;
    const params = {
      objectName: file.name,
      contentType: file.type
    };
    const response = await dispatch(getSignedUrl(params));
    console.log(response);
    callback(response);

  }

The above dispatch method is getting signed url from my NestJs server.
Here is my error:

@abhimanusharma were you able to solve this?

@abhimanusharma @mclean25 any updates?

Also getting a cors issue when uploading, it would be good to know if there is something wrong or it's just something in the server settings


NullSafety + Flushbar

I migrated the package to nullsafety and added the flushbar dependency, it can be easily replaced by a common snackbar, I chose this package as a matter of preference in relation to aesthetics.

Thanks a lot @joaovvrodrigues for your contribution.


Reintroduce the mipnerf360 dataset (but using the HuggingFace dataset url)

With @ethanweber uploading the dataseto to https://huggingface.co/datasets/ethanweber/Mip-NeRF_360_Processed_with_Nerfstudio I would like to see this dataset return to the main branch.
Code borrowed from the https://github.com/nerfstudio-project/nerfstudio/tree/SIGGRAPH-2023-Code branch (+ small adjustments due to changes on master since this branch).
However, one thing to note is that I am currently unable to match the results of nerfacto on this dataset as reported in the siggraph paper.  I have modified the benchmark script and the config file to match what I believe is the setting used in the paper (see https://github.com/Mxbonn/nerfstudio_playground/) but the psnr is not close to the results in the paper. I can take this to a separate issue or PR.

Thank you for the PR. I was just wondering - is there a need for the mipnerf360 dataparser? The dataset (original, unprocessed) can be directly loaded by the COLMAP dataparser I believe.

Thank you for the PR. I was just wondering - is there a need for the mipnerf360 dataparser? The dataset (original, unprocessed) can be directly loaded by the COLMAP dataparser I believe.

Good question, I just looked at what they did for the siggraph paper branch. I guess @ethanweber can answer this.

Hi @Mxbonn, thanks for the request. We'd like to keep mipnerf360 data and parsing out of the main branch for maintainability purposes. We included it only for the SIGGRAPH paper to do benchmarking, but we don't wish to maintain this code. Rather, we'd encourage people to use the COLMAP parsing directly as suggested by @jkulhanek with maybe slight modifications to sample train/eval images in the same way. Thanks for understanding this decision!


Fixes StateMachineEditor is_instance_valid check on reconnection

I think I spotted a bug.
Either the check was wrong or it was redundant.

@farfalk Can you have a look if @turbohz were right about the code?

@turbohz @farfalk I agree with the proposed change.
Actually, both instance validity checks are actually a safety check I had to add during the godot 4 port to avoid errors in particular conditions of fast node connection editing

@farfalk I see, but I think we should keep them anyway, nothing's wrong with extra safety. Thanks for reviewing!
@turbohz Thanks for the edit!


Quick sort algorithm in CPP

Hey @Ayush7614
I would like to add this issue.
I am a LGM-SOC'21 Participant.

@GUPTAVANSHIKA this issue is already solved


Flex server - namespace not accepted anymore

Hello,
When installing the new 3.1 version, the flex server won't take anything else than ns=1 when adding variables to the address space. Is that true or just an issue?
I had every variable on the ns=2, I guess I will need to change this when updating.
Cordially,
Steve

Hell Steve,
node-opcua has a new namespace concept with v0.4. You will find some examples in the code of node-opcua, how to work with that to set ns=2 as your namespace in the flex server. It is a breaking change here and I decided to use the ns=1 as the default does.
If I find some time I could attach an example here and to the Node-RED examples with the Flex Server.
Happy wiring!
Klaus

Thanks a lot Klaus for your time and your answer ;)
Steve

const ns2 = addressSpace.registerNamespace("N2");
ns2.add...


[BUG] in Destination Chain not showing a other chains only showing blank page please fix it

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce

Screenshot

Log output

Log Output
paste log output...

Context (Environment)

Browsers Affected

[x] Chrome
[ ] Firefox
[ ] Edge
[ ] Safari 11
[ ] Safari 10
[ ] IE 11

I'm facing the problem in Yendex Browser

Please fix it

Close because the issue is resolved.


Share IG posts via links

When the url of an IG post is pasted into the message input, it should auto-render it as a post to share. Also when sent, it should in turn share the post the way it is on IG mobile.

Hi @ifedapoolarewaju very nice to meet you mate! Thanks a lot for this tool 👍🏼
I'm on OS X 10.11.6 and IG:dm 2.6.1 and links are not rendering.
I've seen that this was reported on #100, #342 and #379, so my guess is that it's probably not localized to my setup.
I tried IGdm-Pro and the same happens. It looks like as if the link anchors are below a clickable layer that all messages have.
All the best!


Remove Recommended Section From Start Menu

hi there
I'm always frustrated when Microsoft don't make things easy for us the users
but can u add a tweak to remove the recommended section from start menu
saw a way via group policy (Computer Configuration > Administrative Templates > Start Menu and Taskbar)
figured it well help since Microsoft make it harder for us to remove it.

Already opened an issue for this, https://github.com/ChrisTitusTech/winutil/issues/2037.

You can't remove the entire recommended tab just from settings, reg edits ...
Like that there will always be the Title and maybe even a message if you disable everything in settings.
The best way I've found to get around that is using the application "WindHawk" with the "Windows 11 Start Menu Styler" mod

I will look into this when I come back off holiday or @og-mrk will take a look.

You can't remove the entire recommended section just from settings, reg edits ... as far as I've seen. Like that there will always be the Title and maybe even a message if you disable everything in settings.
The best way I've found to get around that is using the application "WindHawk" with the "Windows 11 Start Menu Styler" mod found inside of it.

I'd rather not install pointless software just to do 1 simple thing.

I'd rather not install pointless software just to do 1 simple thing.

It sadly isn't one "simple thing". If you have the Windows Education edition (SE) you can follow this article.
If not and  you prefer not to use a 3rd party application, you are most likely out of luck...

If that helped please close this issue.

/close

I could fix it with this option. (Last comment)
https://www.elevenforum.com/t/cant-turn-off-recommended-on-start-menu.28433/

I could fix it with this option. (Last comment) https://www.elevenforum.com/t/cant-turn-off-recommended-on-start-menu.28433/

Have WinUtil automate that then.

that actually works, nice :)
Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\PolicyManager\current\device\Start]
"HideRecommendedSection"=dword:00000001

[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\PolicyManager\current\device\Education]
"IsEducationEnvironment"=dword:00000001

[HKEY_LOCAL_MACHINE\SOFTWARE\Policies\Microsoft\Windows\Explorer]
"HideRecommendedSection"=dword:00000001


[EUWE] Upgrade azure-armrest gem to 0.5.2.

As part of the effort to get every branch on the same azure-armrest gem, this PR updates the gem to 0.5.2.
Currently gems-pending already has the dependency set to 0.5.2.
Also see https://github.com/ManageIQ/manageiq/pull/13311 and https://github.com/ManageIQ/manageiq-providers-azure/pull/28

@bronaghs Done.

@miq-bot assign @blomquisg

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1404827


Add doc in types.go for hooks/description.sh

@bgrant0607 - the list of omissions reported in #4542 and some extras are added here.
I still can't get hack/verify-description.sh to report clean yet, and I am still struggling with bash to see what the case is.

Fixing the last few now, bash finally worked for me ;-)

Fixes #4542
@smarterclayton @yujuhong @bgrant0607 - please review.
hack/verify-description.sh now reports a clean result for me with this.

Thanks much. For consistency and concision, I'd prefer the descriptions to be a little more terse. Swagger is going to provide the field names, so I definitely think we don't need to duplicate those.

I can refine based on your comments Monday.  I just had to leave and get my kids from school and didn't want you to wait.

It's fine. Thanks for the quick turnaround. Have a good weekend.


Bug: Call to undefined function CodeIgniter\Shield\Controllers\emailer()

PHP Version
7.4.6
CodeIgniter4 Version
4.2.8
Shield Version
1.0.0-beta.3
Which operating systems have you tested for this bug?
Linux
Which server did you use?
fpm-fcgi
Database
MariaDB
Did you customize Shield?
No.
No inherited classes, just own views.
What happened?
I upgraded to shield-1.0.0-beta3 (composer upgrade), checked new user creation with mail verification and got Call to undefined function CodeIgniter\Shield\Controllers\emailer() .
I looked through the code. Three classes use emailer()

MagicLinkController.php
Email2FA.php
EmailActivator.php

When I add helper('email') before each of the three emailer() calls, everything works as before.
Steps to Reproduce
Upgrade to latest shield via composer and try a function that uses mails.
Expected Output
activation mail, 2FA or magic link mail sent
Anything else?
Was there a helper call in previous version or is something wrong in autoloading the helper class?

I don't know why this error happens.
This should work, because composer upgrade is an alias for composer update.
And Composer will autoload the helpers.
https://github.com/codeigniter4/shield/blob/5e6d5175da45b06dbe7d1deda03458d79d45a951/composer.json#L41-L44

@jozefrebjak It is very strange! I think composer update does not delete email_helper.
I don't know why your helper is gone.


Translations update from Mattermost Weblate

Translations update from Mattermost Weblate for Mattermost/mattermost-desktop.
Current translation status:

 none

Hello @weblate,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

/update-branch

Looks like you don't have permissions to trigger this command.
Only available for the PR submitter and org members


Firebase Google Auth Task throwing error

com.google.firebase.FirebaseException: An internal error has occurred. [ Bad Request ]                                                                                at com.google.android.gms.internal.zzbix.zzcb(Unknown Source)                                                                                at com.google.android.gms.internal.zzbiu$zzj.zza(Unknown Source)                                                                                at com.google.android.gms.internal.zzbjf.zzcc(Unknown Source)                                                                                at com.google.android.gms.internal.zzbjf$zza.onFailure(Unknown Source)                                                                                at com.google.android.gms.internal.zzbja$zza.onTransact(Unknown Source)                                                                                at android.os.Binder.execTransact(Binder.java:446)
I am trying to do login with Google, but after onComplete(@NonNull Task<AuthResult> task) is executed. Task.isSuccessful() always returns false and throws the above exception. I verified SHA1 and google-service.json is also present in my app folder. Please let me know if am missing something

I am trying to do login with Google, but after onComplete(@NonNull Task task) is executed. Task.isSuccessful() always returns false and throws the above exception. I verified SHA1 and google-service.json is also present in my app folder. Please let me know if am missing something

@sandeeptengale can you provide any more logs from the device besides that error?

@samtstern
I/MaliEGL: [Mali]window_type=1, is_framebuffer=0, errnum = 0
[Mali]surface->num_buffers=4, surface->num_frames=3, win_min_undequeued=1
I/MaliEGL: [Mali]max_allowed_dequeued_buffers=3
W/DynamiteModule: Local module descriptor class for com.google.firebase.auth not found.
I/art: Background sticky concurrent mark sweep GC freed 15511(1138KB) AllocSpace objects, 0(0B) LOS objects, 12% free, 8MB/10MB, paused 13.259ms total 82.840ms
I/art: Background sticky concurrent mark sweep GC freed 3667(257KB) AllocSpace objects, 0(0B) LOS objects, 3% free, 9MB/10MB, paused 8.317ms total 30.450ms
I/art: Background sticky concurrent mark sweep GC freed 2824(203KB) AllocSpace objects, 0(0B) LOS objects, 3% free, 9MB/10MB, paused 14.685ms total 39.481ms
Is it because of
'DynamiteModule: Local module descriptor class for com.google.firebase.auth not found.' ??

@sandeeptengale no that's not a problem.  Those logs don't contain much information ... can you describe what you're trying to do?

@samtstern I wanted to know what is that exception saying [Bad Request] and why isSuccessful() return false. I can manage my use case without it. I just need IdToken from this process, which I already got. We can close this if you are not getting anything out of my logs

I am getting an error after adding google-service,json and including SHA-1.
com.google.firebase.FirebaseException: An internal error has occurred. [ INVALID_APP_CREDENTIAL:App validation failed ]
at com.google.android.gms.internal.jy.zzK(Unknown Source)
at com.google.android.gms.internal.ko.zza(Unknown Source)
at com.google.android.gms.internal.kp.run(Unknown Source)
at android.os.Handler.handleCallback(Handler.java:815)
at android.os.Handler.dispatchMessage(Handler.java:104)
at android.os.Looper.loop(Looper.java:194)
at android.app.ActivityThread.main(ActivityThread.java:5637)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:959)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:754)


Error in a 1.1.3 -> 1.2 migration

When I replace 1.1.3 by 1.2, my code doesn't work.
With firefox 4.0.1 and firebug : no message,
with IE 8.0 :
"This object doesn't support this property or method"
sugar-1.2.development.js, line 66
63   function iterateOverObject(obj, fn) {
64     var count = 0;
65     for(var key in obj) {
66       if(!obj.hasOwnProperty(key)) continue;
67       fn.call(obj, key, obj[key], count);
68       count++;
69     }
70   }

I'm going to need more context... more like a stack trace or the calling point of the method.

Also have a look at the changelog... there may be something obvious there that's changed...

going to close this one for now... have a look at the changelog as some things have changed... if you have a bit more context for me feel free to reopen


Configure nginx to re-resolve upstream hosts

When proxy_pass is used with a predefined URL nginx will resolve
the host during startup and will cache the IP address indefinitely.
This is a problem when proxying requests to AWS ELBs, since ELB IPs
change without notice.
To force nginx to re-resolve DNS proxy_pass destination must be set
to a variable and resolver must be defined in server configuration.
Nginx can't use the nameserver IP from system resolv.conf, so we're
passing it in as another variable.
Since we set resolver in nginx.conf and the variable is only set
in cloud-init stage nginx.conf is now run during instance-config.
nameserver_ip is set by user data cloud-init script by running the resolv.conf through awk.

All looks good as far as I can tell. One question: why does the tag need to change from image-setup to instance-config?

@TheDoubleK image-setup is run by packer during AMI creation whereas instance-config is started by cloud-init user-data script when instance is launched. Since the resolver is in the nginx.conf creating the config requires the nameserver_ip variable to exist, which is only true for the cloud-init stage. (Also, I'm not sure if resolv.conf is the same on the live instance and during AMI creation)
We could set resolvers in each individual server { ... } blocks instead of once in http { ... }, but at the same time I can think of no real benefit to having nginx.conf be part of the AMI.


Seeing raw HTML in views and no action button are working

I suspect I must be doing something dumb but I've had a weird issue going on ever since I added RailsAdmin to my Rails app.
Basically I can see raw HTML output at the bottom of all new and edit RailsAdmin forms:

The action buttons on that page don't work because they are not contained within the <form> tag that you would expect them to be. If I inspect the DOM, you can see a <fieldset> within which the buttons exist and a sibling <form> which wraps the raw HTML output, further down the DOM tree.

My first thought was that this is a Pjax issue but there's no JS console errors or important warnings.
My second thought was that some other Gem in my app was clashing with RailsAdmin. I've tried running the app without (for example) turbolinks and foundation-rails but it doesn't seem to make a difference.
I'm running Rails 4.0.2 on Ruby 2.0.0p247. The issue exists both in development (OX X Mavericks) and in production (Ubuntu 13.10).
Let me know if there's anything else I can do to help diagnose.

Stale.


Jan 13, 2021 - Web Wednesday

Event Information

Category
Details

Reactor Topic
Coding, Languages, and Frameworks

Monthly Topic (if applicable)
<Topic taken from Azure Dev Marketing>

Weekly Topic (if applicable)

Stream Topic
<2-5 words describing the topic>

Stream Date
Jan 13, 2021

Stream Time
3:00 PM

Stream Duration
60

Title
Web Wednesday

Description
<500 characters or less>

Speaker
Christopher Harrison

Moderator

SharePoint ID
12429

Additional Resources:

Event Checklist
10 Weeks Prior

[ ] Reactor Content Team (RCT) or Speaker opens a new issue for an upcoming stream filling in the Event Information table. Both RCT and Speaker are marked as assignees.
[ ] RCT and Speaker discuss details of the event in the comments of this issue. RCT adds a confirmed-event label and global-twitch-event tag to the issue and adds event to the Global Live Streams project. Issue will appear in the Upcoming Streams column
[ ] Speaker adds a ready-for-marketing-edit label so the RCT can review title and description

8 Weeks Prior

[ ] RCT does a review of title and description and removes the ready-for-marketing-edit label
[ ] RCT moves the issue to the Ready for SharePoint column
[ ] RCT informs the Reactor Marketing Team of the new event information
[ ] RCT provides speaker with assets (e.g. slides, overlays) and the survey data for the event
[ ] RCT moves the issue to the MONTH Streams Prep column (according to the month it will be streamed in)

2 Weeks Prior (Done in /microsoft/Reactors)

[ ] Speaker opens a PR with the new content for the stream on the customer-facing Reactor repository and adds the content-development and global-twitch-event tag to the PR.
[ ] Speaker adds to the same PR a modification to the online-event-resources directory to include their stream information.
[ ] Speaker adds the RCT assigned to the issue as the reviewer when it is ready for review/merge
[ ] RCT reviews, approves, and merges the changes

1 Week Prior

[ ] Speaker and Moderator test setup for streaming (instructions coming soon)
[ ] RCT checks in with the speaker and moves the issue to the Ready to Stream column

During and After Stream

[ ] Speaker and Moderator run the stream
[ ] RCT submits recording to be uploaded to the Reactor YouTube and to be made available on LearnTV
[ ] RCT moves issue to the Stream Complete column

@GeekTrainer - Here is the Issue for Jan 13!

@GeekTrainer - Here is the Issue for Jan 13!

New Title: Identity Fundamentals with Christos Matskas | Web Wednesday
New Description:
What is the session about?
Web development can be challenging and sometimes might feel a little overwhelming. There are so many different technologies, emerging languages, and plug-ins that it can be hard to keep up. We’ve decide to break it down for you week by week in our Web Wednesday Interview show. This week we are going to talk about the tool, Identity. Identity is often a mystery to web developers at best, and infuriating challenge at worst. It need not be difficult! Join us as we chat with Christos Matskas, who will introduce various ways you can work with identity without needing a master’s degree.
Who is it aimed at?
This show is for anyone who is interested in Web Development and wants to talk about what's new and exciting in the world of web development!
Why should you attend?
Each week we'll bring on people from the product teams and experts in different areas of web development. Christos Matskas is a Identity genius and will give us the inside scoop on how to use optimize Identity for use on your projects.

New Title: Identity Fundamentals with Christos Matskas | Web Wednesday
New Description:
What is the session about?
Web development can be challenging and sometimes might feel a little overwhelming. There are so many different technologies, emerging languages, and plug-ins that it can be hard to keep up. We’ve decide to break it down for you week by week in our Web Wednesday Interview show. This week we are going to talk about the tool, Identity. Identity is often a mystery to web developers at best, and infuriating challenge at worst. It need not be difficult! Join us as we chat with Christos Matskas, who will introduce various ways you can work with identity without needing a master’s degree.
Who is it aimed at?
This show is for anyone who is interested in Web Development and wants to talk about what's new and exciting in the world of web development!
Why should you attend?
Each week we'll bring on people from the product teams and experts in different areas of web development. Christos Matskas is a Identity genius and will give us the inside scoop on how to use optimize Identity for use on your projects.


Found invalid metadata core compiler_builtins

🐛 Bug description
wasm-pack build error
[INFO]: 🎯  Checking for the Wasm target...
[INFO]: 🌀  Compiling to Wasm...
   Compiling proc-macro2 v1.0.70
   Compiling unicode-ident v1.0.12
   Compiling wasm-bindgen v0.2.88
   Compiling cfg-if v1.0.0
error[E0786]: found invalid metadata files for crate `core`
  |
  = note: metadata not found in rlib '/opt/homebrew/Cellar/rust/1.74.0/lib/rustlib/wasm32-unknown-unknown/lib/libcore-6a9d233d01acc350.rlib'

error[E0786]: found invalid metadata files for crate `compiler_builtins`
  |
  = note: metadata not found in rlib '/opt/homebrew/Cellar/rust/1.74.0/lib/rustlib/wasm32-unknown-unknown/lib/libcompiler_builtins-851bb3b5f6c4db49.rlib'

For more information about this error, try `rustc --explain E0786`.
error: could not compile `cfg-if` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
Error: Compiling your crate to WebAssembly failed
Caused by: Compiling your crate to WebAssembly failed
Caused by: failed to execute `cargo build`: exited with exit status: 101

I also added manually nightly build of wasm32-unknown-unkown to /opt/homebrew/Cellar/rust/1.74.0/lib/rustlib
following steps from https://rustwasm.github.io/docs/wasm-pack/prerequisites/non-rustup-setups.html
🤔 Expected Behavior
should expect artifacts in the pkg directory
👟 Steps to reproduce
cargo generate --git https://github.com/rustwasm/wasm-pack-template
open terminal in project directory
wasm-pack build
🌍 Your environment
Include the relevant details of your environment.
wasm-pack version: wasm-pack 0.12.1
rustc version: rustc 1.74.0 (79e9716c9 2023-11-13) (Homebrew)

closing issue, having conflicting tool chain installed.
steps

brew uninstall rust
-validate rustc version.
reloaded vscode window
build the wasm package


fix: dictionary decimal vector optimization

Which issue does this PR close?
Part of https://github.com/apache/datafusion-comet/issues/679 and https://github.com/apache/datafusion-comet/issues/670
Related https://github.com/apache/datafusion-comet/pull/490
Rationale for this change
For dictionary decimal vectors, it was unpacking even for Int and Long decimals that used more memory than necessary.
What changes are included in this PR?
Unpack only for Decimal 128
How are these changes tested?
Existing test

@andygrove @parthchandra I moved the logic to the reader side, in that way, this PR will help for native exec as well

I'm not entirely sure how this helps on the exec side, could you provide a short explanation? Otherwise lgtm

Thanks @parthchandra
When the native exec is enabled CometDictionary is still called that decode the dictionary. However the native exec does not use CometDictionary to read the values. So by moving the logic to the reader, it decodes only when we need it (scan-only case)

Merged Thanks @parthchandra @andygrove


SaveChanges doesn't remove items from the inner collection

Library version
1.1.1
OS & OS version
W11x64 + Edge
Describe the bug
Hi,
we were storing state of a form (single entity) in local storage but once we added possibility for attachments we hit the wall with size limits so we moved to indexed DB (no need to elaborate on this).
Originaly it all worked until we found out that opening the DB started to take too long (5-10 seconds) and we are doing it often to keep the data alive. So we reworked our solution to use a single instance of the DB which is created on the application startup instead of creating a new one for each task we perform in the DB.
Then it all stopped working - the in browser DB is good but the one stored in memory keeps track of the removed item(s) with the "Deleted" flag. Sadly when we are trying to get the stored item again we get them all - even the removed ones.
Code example
We have a storage service, which has these two methods with a property DB: IndexedDb with a Set: IndexedSet and two methods for Get and Set of the single instance:
public Object Get() {
  return DB.Set.SingleOrDefault();
}
public void Set(Object? v) {
  DB.Set.Clear(); /* changes state to Deleted */
    if(v != null)
      DB.Set.Add(v); /* adds new item to the inner collection */
  DB.SaveChanges(); /* doesn't remove item from the inner collection but correctly updates the browser's Indexed DB */
}

Having the code as follows we end up with exeption 'The input sequence contains more than one element.'
Svc.Get(); // returns null
Svc.Set(new {...}) // populates the collection with one item
Svc.Get(); // returns the item
Svc.Set(new {...}) // replaces correctly in browser but wrong in memory
Svc.Get(); // throws exception because the inner collection contains two elements

Expected behavior
After calling the 'Save changes' method on a DB instance - Deleted record should be removed from the inner collection - when reading them again they shouldn't be there.
Additional context
I went through your code and found out that in the 'SaveChanges' method when resolving the Deleted items they don't get removed from the inner collection

Thank you for the suggestion I'll give it a try :)


chore(Dependencies) : update jsoniter-scala-core, ... from 2.20.7 to 2.28.4

About this PR
📦 Updates

com.github.plokhotnyuk.jsoniter-scala:jsoniter-scala-core
com.github.plokhotnyuk.jsoniter-scala:jsoniter-scala-macros

from 2.20.7 to 2.28.4
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.plokhotnyuk.jsoniter-scala" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.github.plokhotnyuk.jsoniter-scala" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, version-scheme:early-semver, commit-count:1

Superseded by #709.


Crash when setting the badgeString

Hi,
I installed the library through CocoaPods. Added a UIButton (just an image, no text) and set its class to MIBadgeButton. I didn't do any modifications through the IB.
Then I tried to increase the badge count every time the button is pressed. But when setting the badge string, the app crashes with a EXC_BAD_ACCESS error.
Below is my code.
import UIKit
import MIBadgeButton_Swift

class ViewController: UIViewController {

    @IBOutlet weak var button: MIBadgeButton!

    var count = 0

    override func viewDidLoad() {
        super.viewDidLoad()
    }

    @IBAction func didTapButton(_ sender: MIBadgeButton) {
        count = count + 1
        sender.badgeString = "\(count)"
    }
}

I also uploaded a demo project here.

Got the same problem, solve it by programmatically create the MIBadgeButton in viewDidLoad.

The problem is with Custom class Module, @Isuru-Nanayakkara you didn't selected Module.
Changing the module to MIBadgeButton_Swift will solve your problem.


IAM Audit log is not included in project level CAI data if it's enabled in org level

I have audit log enabled for all services at org level, but violations are still reported by Forseti in CSCC for a lot of projects and folders. I took a look at the CAI export and it seems the project level (probably folder level as well, but I didn't check), the audit_log_configs block is not present in the exported data, and I guess that's why it causes the forseti to still report violations.
(note this is not the same issue as https://github.com/forseti-security/policy-library/issues/367). This issue might need to be solved in CAI export data or how config validator collect project/folder level audit log information.

I don't think there's a meaningful way for us to solve this.
If you're looking for audit log configs, you should look at both the org and project level configs.
If you think that's unsatisfactory, I'd recommend asking the CAI team about adding a "materialized" asset.

One thing I can try is change the match target to be
organizatin/12345678/* to organization/12345678 so it will not look at folder or project level audit logs.

Yeah that should work.

Umm, just tried in my Forseti instance, seems organization/12345678/* is the same as organization/12345678, which also seems match the documentation https://github.com/forseti-security/policy-library/blob/master/docs/user_guide.md#instantiate-constraints.
@briantkennedy do you think we can support organization/12345678 being the exact match to the ancestry path from CAI, and organization/12345678/* being everything under the org?

Hi @xingao267, I believe the behavior you're requesting is already implemented, but based on the other bug, it looks like you're running a very old version of config validator in your Forseti install.  @gkowalski-google will probably be able to assist with determining which version and how to upgrade.

@xingao267 @briantkennedy Added a comment to this ticket. Until the next release, you can use the main branches of the Terraform module and Forseti app to have the ability to change the CV version.


Make CoreOS channel configurable

This makes it a little bit easier to specify the version of CoreOS to use.

Looks good, thanks!


Getting error on gradle build: Could not find method bootJar

When I run gradle build (or even gradle tasks / ./gradlew build) I get the error -
> Could not find method bootJar() for arguments ...

I noticed that a recent commit 015dbc1 replaced jar with bootJar, I don't understand why? I also noticed that CI server also shows the same error. Was this a typo?

This is the one guide that does NOT use the Boot plugin, so upgrading to bootJar task was incorrect.
Resolved via https://github.com/spring-guides/gs-gradle/commit/5cec2afceb4c85d11b1a73ce08ef9917e36d8bb8


separate facets to allow versioning them independently

Signed-off-by: Julien Le Dem<EMAIL_ADDRESS>

Codecov Report

Merging #118 (789b55f) into main (5f67c29) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   88.88%   88.88%
=======================================
  Files          26       26
  Lines        1323     1323
=======================================
  Hits         1176     1176
  Misses        147      147

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f67c29...789b55f. Read the comment docs.


Atom does not use multiple tabs anymore

Prerequisites

[x] Can you reproduce the problem in safe mode?
[x] Are you running the latest version of Atom?
[x] Did you check the debugging guide?
[x] Did you check the FAQs on Discuss?
[x] Are you reporting to the correct repository?
[x] Did you perform a cursory search to see if your bug or enhancement is already reported?

For more information on how to write a good bug report or enhancement request, see the CONTRIBUTING guide.
Description
Atom just updated to v1.6.0 - and now it won't open multiple files in multiple tabs anymore.
Steps to Reproduce

Start Atom and Open a folder with multiple files.
Open a File by clicking on it in the file browser.
Open another file by clicking on it in the file browser.

Expected behavior: The window should have two tabs with two open files.
Actual behavior: After the first click a tab is opened. The tab header is showing the filename in italics. When I click on another file the tab is replaced by the second file. It won't open a second tab anymore.
Versions
1.6.0

This is intended behavior in atom 1.6.0 called pending pane items.
See https://github.com/atom/atom/issues/11243#issuecomment-199959295

Okay, just found these "closed" issues #11202, #11243, #11237 - this seems to be an unexpected and rather annoying feature of the latest version.

This should be disabled by default as it is a rather unexpected behaviour.


Console patch fix

↪ Pull Request

💻 Examples

🚨 Test instructions

✔ PR Todo

[ ] Added/updated unit tests for this change
[ ] Filled out test instructions (In case there aren't any unit tests)
[ ] Included links to related issues/PRs

=== Benchmark Results ===
Benchmark: packages/benchmarks/kitchen-sink
Cold build took: 12.82s
Cached build took: 8.94s (-189.50ms)
=== Sizes ===
.CSS: 58.00b
.JS: 1.02kb
.MAP: 146.00b
.WEBP: 205.88kb

API test

API test
-5secs

Benchmark Results
Benchmark: packages/benchmarks/kitchen-sink
Cold build took: 5.16s (-231.00ms)
Cached build took: 2.62s
=== Sizes ===
.CSS: 58.00b
.JS: 1.02kb
.MAP: 146.00b
.WEBP: 205.88kb

Benchmark Results
packages/benchmarks/kitchen-sink
Timings

Description
Time
Difference

Cold
5.52s
+587.50ms ⚠

Cached
3.03s
-143.00ms 🎉

Bundle Sizes

Extension
Size
Difference

.css
58.00b

.js
1.02kb

.map
146.00b

.webp
205.88kb

Benchmark Results
packages/benchmarks/kitchen-sink
Timings

Description
Time
Difference

Cold
5.73s
-250.50ms 🎉

Cached
3.27s
0ms

Bundle Sizes

Extension
Size
Difference

.css
58.00b
0b

.js
1.02kb
0b

.map
146.00b
0b

.webp
205.88kb
0b

Benchmark Results
### packages/benchmarks/kitchen-sink#### Timings

Description
Time
Difference

Cold
4.99s
+174.00ms ⚠

Cached
3.07s
+152.50ms ⚠

Bundle Sizes

Extension
Size
Difference

.css
58.00b
0b

.js
1.02kb
0b

.map
146.00b
0b

.webp
205.88kb
0b

Benchmark Results
packages/benchmarks/kitchen-sink
Timings

Description
Time
Difference

Cold
5.70s
+212.00ms ⚠

Cached
3.32s
+257.00ms ⚠

Bundle Sizes

Extension
Size
Difference

.css
58.00b
0b

.js
1.02kb
0b

.map
146.00b
0b

.webp
205.88kb
0b

Benchmark Results
packages/benchmarks/kitchen-sink
Timings

Description
Time
Difference

Cold
4.11s
+63.00ms

Cached
1.64s
-209.50ms 🚀

Cold Bundles
No bundle changes detected.
Cached Bundles
No bundle changes detected.

Benchmark Results
packages/benchmarks/kitchen-sink
Timings

Description
Time
Difference

Cold
4.52s
+739.50ms ⚠

Cached
1.93s
+381.00ms ⚠

Cold Bundles

Bundle
Size
Difference
Time
Difference

index.css
29.00b
-0.00b
1.08s
+58.50ms ⚠

index.css
29.00b
-0.00b
1.04s
+54.50ms ⚠

parcel.6836e8d0.webp
0.00b
-0.00b
93.00ms
+27.00ms ⚠

parcel.1e8b6c14.webp
0.00b
-0.00b
92.50ms
+16.50ms ⚠

Cached Bundles

Bundle
Size
Difference
Time
Difference

index.css
29.00b
-0.00b
1.08s
+58.50ms ⚠

index.css
29.00b
-0.00b
1.04s
+54.50ms ⚠

parcel.6836e8d0.webp
0.00b
-0.00b
93.00ms
+27.00ms ⚠

parcel.1e8b6c14.webp
0.00b
-0.00b
92.50ms
+16.50ms ⚠


st2common/st2-validate-pack-config takes a long time

When running the CI pipeline against some of our packs i noticed that performing the example config validation takes a long time (example build: https://circleci.com/gh/EncoreTechnologies/stackstorm-activedirectory/7).
It takes much longer to perform this check than to run unit tests or even install dependencies.
Are we doing something wrong in our pack, or is there some way to speed this up?

I don't even see validate-pack-config step here - https://circleci.com/gh/EncoreTechnologies/stackstorm-activedirectory/7
Am I missing something (I do see other config checks, but not st2-validate-pack-config one).
As far as why it might be slow - all those various lint and config checks work on per-file basis which means some of them might take a bit longer if you have a lot of YAML files in your pack.
And on a related note, please gist and provide timing information for exactly the step which is taking long so we can have a look.

@Kami I've modified our makefile to print timestamps at the beginning and end of each target.
You can see this by clicking on the "make all" section of this build
https://circleci.com/gh/EncoreTechnologies/stackstorm-activedirectory/14
If you notice:
==================== example config check ====================

Start Time = 2017-06-12T23:36:09,831515901+0000
. /home/ubuntu/stackstorm-activedirectory/ci/virtualenv/bin/activate; \
	st2-check-validate-pack-example-config /tmp/packs/activedirectory || exit 1;
Running example config check on pack: activedirectory
Validating example config /tmp/packs/activedirectory/activedirectory.yaml.example for pack activedirectory...
Validating config "/tmp/packs/activedirectory/activedirectory.yaml.example" against schema in "/tmp/packs/activedirectory/config.schema.yaml"
Config "/tmp/packs/activedirectory/activedirectory.yaml.example" successfuly validated against schema in /tmp/packs/activedirectory/config.schema.yaml.
End Time = 2017-06-12T23:37:55,148592502+0000

Takes a total of almost 2 minutes to complete.
Looking at the st2-check-validate-pack-example-config i notice this line:
pip install --cache-dir ${HOME}/.pip-cache -q -r ${ST2_REPO_PATH}/requirements.txt

Guessing that is probably taking a while if it's the first time being called?

@nmaludy yep, the pip install line can take a while - there's quite a few requirements that get installed there. I know with st2docs checks that most of the total elapsed time taken for checks is with installing requirements.

@LindsayHill it looks like those requirements are installed in the dependency phase of the build into the virtualenv directory: https://github.com/StackStorm-Exchange/ci/blob/master/.circle/dependencies#L33
However, it doesn't appear that the virtualenv directory is cached. Is the virtualenv directory supposed to be cached?
Probably only need to update/refresh cache when requirements.txt changes in whatever repo we're installing requirements for (in this case st2 repo).

Closing this, not an issue

@nmaludy Caching virtualenv makes sense.
It brings ~2mins timing improvement, according to experiments
but has some corner cases (see https://github.com/StackStorm/st2/pull/3545/files#r125296840 comment)


CanvasTinter canvas size rounds up

In my project I use resolution as an easy way to use smaller assets on mobile devices. This means that occasionally the crop.width or crop.height is a decimal. When you set a canvas to a decimal number it seems to always round down (at least it does for me). This sometimes results in the tinted image being very slightly cut off.
Rounding the canvas size up has fixed this issue for me.

@D-Hartley thanks for the PR. Do you have a screenshot of what this visual bug looks like?

Sure, I managed to recreate it using BitmapText. You can see the bug on the far right of some of the characters, especially the O. The gif isn't great quality but it also effects the top right of N and bottom right of Q.


change channel username using link order active usernames?

How I can change my channel uesrname using link order ( usernames that I bought from fragment ) using tdlib?

See up-to-date documentation for the class usernames.


Innity Adapter Documentation Support for Prebid.js 1.0

Add prebid_1_0_supported

will be part of PBJS 1.5

released with PBJS 1.5


How to customize MapIndex table name

Got this when using OrchardCore, and they tell me to ask the question here.
For MapIndex, the table name is "[PartName]Index". This looks like a defaut pattern provided by YesSql during the table creation using CreateMapIndexTable in migration.
So must it has this kind of name for YesSql to find the right table when it does the query operation?
Has a way to customize the table?

It;s an issue for Orchrad Core ;) answering there


[Feature Request] Support auto tool schema or docstring generation for OpenAIFunction

Required prerequisites

[X] I have searched the Issue Tracker and Discussions that this hasn't already been reported. (+1 or comment there if it has.)
[ ] Consider asking first in a Discussion.

Motivation
Sometime users do not want to write a docstring for when creating the tools. Supporting auto tool schema or docstring generation for OpenAIFunction would be helpful.
Solution
No response
Alternatives
No response
Additional context
No response

solution: user give one function without docstring, LLM generate docstring automaticlly

Guohao: when tools defined without docstring, we add docstring based on the code
user function - generate docstring stored in attribute / do tool calling generate docstring > camel tool


publish 2.8.0 to npm

Looks like 2.8.0 was released to github but it's not released to npm.

If this is in relation to your comment here https://github.com/GoogleChrome/accessibility-developer-tools/issues/199#issuecomment-126097613
I don't think 2.8.0 includes that fix...

It's not, it just came up while we were investigating. Thought someone might want to know :grin:

$ npm view accessibility-developer-tools | grep versions
  versions: [ '2.6.0', '2.7.0', '2.7.1-rc.1', '2.8.0', '2.9.0-rc.0' ],


add delay in attempt to fix intermittent preview functional test failure

Getting intermittent failures when page expected is not presented in time. Added "Sleep 1" to delay checking of the page existence

Is there an example of a failing job I could look at?
Field edits should be synchronous – since we only have one DB server there should be no replication lag and I'd expect the test to read back the change on the next request without any delays.


Is this supposed to work with an Office add-in (DLL, ActiveX)?

Thanks for the recent update.
Is nx-horizon event bus supposed to work with an Office add-in which is actually a DLL/ActiveX? Last time I tried it didn't work. If it's supposed to work, I'd like to try again.
Thanks.

No, it will not work in a DLL.
DLLs cannot share RTTI information which is used in NX Horizon for distinguishing different event types.
https://docwiki.embarcadero.com/RADStudio/en/When_to_Use_Packages_and_DLLs
To support DLLs, code bus code would have to be different and use only COM shareable information. That means supported event types could only be interfaces with GUID and GUID would have to be used for subscribing, storing subscription information and dispatching events.
Existing code could (I cannot say whether there would be some additional issues in such modification) be modified to support such messaging, but then it would be a different specialized event bus.

Thanks for the explanation, I got it. It's a pity, since nx horizon is such a simple but powerful event bus!


Implement Weapon Inventory System feature

Resolves #58
This update introduces the following functionalities to address the issue:
Weapon Interaction System: Players can now pick up weapons from the environment and add them to their inventory.
Inventory Integration: Weapons can be equipped from the inventory, dropped back into the environment, and correctly placed in the player’s hands when equipped.
Animation Rigging Integration: Ensures seamless placement of weapons in the player's hands using Unity's Animation Rigging package for IK.
How It Works
1. Weapon Setup:
Add the Weapon Manager script to a new weapon prefab.
Attach two colliders:
A Box Collider (set as a trigger) for interaction.
A Mesh Collider (not a trigger) to define the weapon's physical shape.
Add a Rigidbody component for physics interactions.
2. Player Setup:
Add the Weapon Handler script to the player’s parent object.
Create three Animation Rigging objects:
Hand IKs for controlling the player’s hands.
Weapon Object IKs for positioning the weapon correctly in the hands.
Refer to the setup in Crafter@RightFist > Character_Robot_01 in the DemoPrincipalScene for a working example.

Hi @sebas11042 please review, fixed conflicts

I think you have modified files that you should not have edited, please correct them, make sure you only edit what you should modify.

Hello @Josue19-08 , I think I left print statements I forgot to clear, i didn't adjust any lines of code

I used unity 6 initially cause I didn't have stable network to download unity 2022 editor, then I switched back to 2022 version to make the commit. @Josue19-08

@Josue19-08 , please review and merge.

@od-hunter There is an issue with your PR when using Unity 6, compatibility with our project was affected when testing and running. I understand that was the version you had at the time but we would not be able to merge those changes if you used Unity in development.


文件审核修改

Coverage increased (+0.05%) to 98.451% when pulling 5e47670b10a4b7f1528ed68716aa6336e48fd498 on huangda7502002:master into 2886e83d70af7509b73f058aab159f5a14fd3163 on rugao-web-fullstack:master.


unexpected expand/lookup behaviour with wildcard permissions

Reproduction: https://play.authzed.com/s/Ay9ZZJBrGDKu (check validation tab)
As I run some experiments with the new wildcard permissions feature, I stumbled upon an apparently unexpected behaviour when doing lookup/expand. Permissions that effectively end up in user* & userset behave correctly with Check API, but not with Lookup/Expand API (which is presumably what's used in the validation tab in the playground).
In the original issue, we discussed that SpiceDB will have special treatment to user:* relationship when performing Lookup/Expand API, which is reasonable because it would lead to "listing all public resources" phenomenon. However, when user:* is chained with other algebraic operators like & and -, I think the current implementation semantics seem unexpected. The desirable outcome would be:
<user:userset> - <user:*> = empty
<user:userset> & <user:*> = <user:userset>

Appears that we need to support wildcard in the subjectset that the developer API is using for its expected relations determination: https://github.com/authzed/spicedb/blob/6f66209fc42a5eea5b89da84b8aef5c514053d63/pkg/membership/membership.go#L192

After discussion, we might also need to do handle in Lookup (Expand already has it in the correct place)

Closed by recent fixes, as addressed in https://github.com/authzed/spicedb/security/advisories/GHSA-7p8f-8hjm-wm92


Enabling HMR for content scripts

I have a change to enable Hot Module Reloading for Chrome extension content scripts:
https://github.com/arseneyr/chrome-extension-webpack-boilerplate/tree/content-hmr
This change includes a new webpack plugin that does the following:

Modifies the HMR runtime in content scripts to use fetch() and eval() instead of JSONP for downloading hot update chunks. JSONP does not work for content scripts because adding a script tag to the DOM executes that script in the context of the host site, not the content script.
Modifies the webpack/hot/dev-server script to send a message to the background script in case a full reload is needed. The background bundle includes a small script to listen for the message and call chrome.runtime.reload() to reload the entire extension.

There are also some changes to the webpack-dev-server parameters so that the websocket client connects inside content scripts:

Use the native WS client instead of sock-js because sock-js has trouble connecting when the host site is HTTPS.
Use <IP_ADDRESS> as the websocket target domain in order to prevent the WS client from using a wss:// protocol.
Set the webpack public path to http://<IP_ADDRESS>:3000 so any requests for HMR manifests, hot chunks, etc. go to the webpack-dev-server instead of the host site.
Modify the manifest to include http://<IP_ADDRESS>:3000 in the content_security_policy.

I'm happy to open a PR if you think this change is valuable.

how would you integrate this into the react branch?  i'd like to use this in my project.  @arseneyr

I have a branch where I merged the react changes with the content HMR changes:
https://github.com/arseneyr/chrome-extension-webpack-boilerplate/tree/react
Haven't tested it thoroughly but you can give it a try.

I created a repo by create-react-app, it uses react-refresh to achieve partial refresh and uses sse to enable HMR for Chrome extension content scripts: cra-crx-boilerplate


Add row numbers in separate frozen column

It would be useful to see row numbers even when scrolling to variants on the far right side of a long list. We should add them in a new column on the far left, then move the delete and drag options to that column, rather than the scenario variables column. We should then freeze the column.

This is less important (and possibly undesirable) now that we're paginating, so I'm closing it.


Suggestion verification root user

I a problem, the group maintenance receives at all times messages when I launches orders.
It is better check if the user is root with "id" commande.

If you want to avoid these notifications, you can set the THEME_CHECK_SUDO variable to false before loading Bash-it:
export THEME_CHECK_SUDO=false

Please see #744, #792, #793 and #902 for more info on this.

Hey, seems like this PR has gone stale. So I am closing it. Thanks for contributing!


Error in checking file syntax

Our syntax checker is failing on blackhole.inc.php due to an inline xxxx {$xxx} xxx construct.    Filetest basic does a
				// This is for variables in strings "something {$a_variable} in a string"
				elseif (is_array($token) && $token[1] === '{')
					$level++;

This is failing to do the increment, where as the below does.
				// This is for variables in strings "something {$a_variable} in a string"
				elseif (is_array($token) && strpos($token[1], '{') !== false)
					$level++;

Not sure if there are other side effect as well or if this is the best way to count the {} tokens.   Also this effects the DataValidator class as it uses the same type of syntax check.

Interesting...
Just for the record, the actual line failing is:
$result = gethostbynamel($settings['httpbl_key'].".${find}.dnsbl.httpbl.org.");

because ${ is considered a single piece and presented as:
Array
(
    [0] => 385
    [1] => ${
    [2] => 4
)

I'm not sure if this is the best way to check the syntax, I only came up with it while trying to find a way able to detect syntax errors without actually execute the code (that is usually a pain in the arse).
A possible workaround for the specific case is change the if to:
	if ($token === '{' || (isset($token[1]) && $token[1] === '${'))
		$level++;
	elseif ($token === '}')
		$level--;


Properly display links

In the blog page it is hard to understand which text is actually part of a hyperlink. Can this be fixed please?

@gbartolini, good catch.  Intention was for blog links to be Red #1 (#E63054).  Look ok to you?
Screenshot

Yep, that's fine, thanks


Missing Sublime Text command - Switch to single column view

While building this extension to map Sublime Text default keyboard shortcuts to VS Code, I found that this feature is missing.
The feature is switch to single column view.
Default Sublime Text keybindings
Windows / Linux: alt+shift+1
Mac: alt+cmd+1
The feature allows you to easily switch from split editor mode to a single editor.
Before switching:

After switching:

There is more to this command, it actually takes the editors from other groups and moves them to the single group. We have to decide if we want to go with the full sublime editor layout model. I think one requirement for it is to support empty groups.

@bpasero I would love for the "Split editor" command to behave differently. Currently it splits the current editor, but it opens a copy of the same file. Most of the time you do not want a copy of the same file in the new editor. What you end up doing every single time is splitting the editor 3 times for example, open 2 new files in the 2 new editors, and then closing the original file that was opened in each editor.
Could we also have more than 3 editors open at the same time? Is there any reason to limit this? I prefer to have 4 editors open most of the time when writing Python or Go, but VSCode stops me from doing that unfortunately.
Lastly is there perhaps another issue revolving around the way VSCode handles multiple editor windows?


When docker install sharp for lambda linux x64 , libvips was not custom complied.

However when I convert heic to jpeg, it is not working (error : not supported fomat error)
=> I think, it was downloading libvips-8.8.1-linux-x64.tar.gz. So, Maybe it was not complied my global libvips.
So, I tried another process.
npm install --no-cache --arch=x64 --platform=linux --target=10.15.0 sharp
(in command)

<EMAIL_ADDRESS>install /Users/vincent/Desktop/Project/image_resize_s3_trigger/node_modules/sharp
(node install/libvips && node install/dll-copy && prebuild-install) || (node-gyp rebuild && node install/dll-copy)

info sharp Detected globally-installed libvips v8.8.4
info sharp Building from source via node-gyp
TOUCH Release/obj.target/libvips-cpp.stamp
CXX(target) Release/obj.target/sharp/src/common.o
CXX(target) Release/obj.target/sharp/src/metadata.o
CXX(target) Release/obj.target/sharp/src/stats.o
CXX(target) Release/obj.target/sharp/src/operations.o
CXX(target) Release/obj.target/sharp/src/pipeline.o
CXX(target) Release/obj.target/sharp/src/sharp.o
CXX(target) Release/obj.target/sharp/src/utilities.o
SOLINK_MODULE(target) Release/sharp.node
But, It is also not working. (error:Something went wrong installing the "sharp" module
/var/task/node_modules/sharp/build/Release/sharp.node: invalid ELF header)

I want to convert heic format image to jpeg format.
How to docker install sharp in my global libvibs circumstance???
Please help me.

OS X packages installed via Homebrew cannot be used inside Linux containers as these are two completely different platforms.
You'll need to compile libvips from source inside the container.
https://libvips.github.io/libvips/install.html#building-libvips-from-a-source-tarball
If the intent is to run this on AWS Lambda then you may run into further problems around packaging binaries - see #2000 - good luck!

Sorry... I can't understand your comment.
Can you suggest solution step by step?

You'll need to compile libvips from source inside the container.
https://libvips.github.io/libvips/install.html#building-libvips-from-a-source-tarball

I download and make install.
What should I do next?

What you're attempting is rather complex and well beyond the scope of sharp itself - I recommend you ask on a site such as StackOverflow - good luck!


wrap coordinates in SVectors for DGMulti

This makes it easier to apply vector operations, e.g., in initial conditions.

You can use something like
function initial_condition_isentropic_vortex(x, t, equations::CompressibleEulerEquations2D)
  ϱ0 = 1.0               # background density
  v0 = SVector(1.0, 1.0) # background velocity
  p0 = 10.0              # background pressure
  ε = 20.0               # vortex strength
  L = 10.0               # size of the domain per coordinate direction

  T0 = p0 / ϱ0           # background temperature
  γ = equations.gamma    # ideal gas constant

  x0 = v0 * t            # current center of the vortex
  dx = vortex_center.(x - x0, L)
  r2 = sum(abs2, dx)

  # perturbed primitive variables
  T = T0 - (γ - 1) * ε^2 / (8 * γ * π^2) * exp(1 - r2)
  v = v0 + ε / (2 * π) * exp(0.5 * (1 - r2)) * SVector(-dx[2], dx[1])
  ϱ = ϱ0 * (T / T0)^(1 / (γ - 1))
  p = ϱ * T

  return prim2cons(SVector(ϱ, v..., p), equations)
end

In particular, you can use the vector operation
x - x0

That is indeed very nice - thanks for adding this!


SVGs for laser cutting don’t match rev C PCB

I laser cut the acrylic parts but they seem to suit an earlier, narrower version with the encoders directly above each other instead of staggered. Is there a newer acrylic cut file?

Hi,
The master branch is still on the rev B PCB layout. If you want to use the newer rev C PCB layout, switch to the revC branch instead and you will find the updated acrylic SVG files.
I probably had a good reason for not merging the master branch forward, but I forget what it was!

Whoops, thanks.


Dsl Builder

https://github.com/JetBrains/KotlinDL/pull/252
@zaleslaw

Thank you so much for separate PR

With this dsl we can declare layer variables like this (not possible with Functional.of):
functional {
  layers {
    val input = +Input(128, 128)
    +Conv1D()(input)
  }
}

@juliabeliaeva
‘’’kotlin
functional {
layers {
+Conv1D()(+Input(128, 128))
}
}
‘’’
this could be possible too

Thanks for the review @juliabeliaeva
@smallshen
From my side, I also suggest adding an example (or test) with the analog of building toyresnet in this
functional {
    layers {
        +Conv1D()(+Input(128, 128))
    }
}

style.
What do you think, is it easy to extend in the future or combine with the existing Image Preprocessing DSL and non-existing yet DSL for training as the following:
val model = trainableModel {
      preprocess {
            load {
                pathToData = ...
            }
            transformImage {
                resize {
                    outputWidth = 224
                    outputHeight = 224
                }
                convert { colorMode = ColorMode.BGR }
            }
        }

  functional {
      layers {
          +Conv1D()(+Input(128, 128))
          ...
      }
   }
  compile {
        optimizer = Adam()
        loss = CrossEntropy()
        metrics = Accuracy()
  }
}

Thanks for the PR, @smallshen hope it will be an important part of the future KotlinDL DSL family


Unwanted automatic translation of non-english input to diarization.

Currently when using a non-english audio file, speechbox automatically translates the diarization to english.
Whisper has this feature, controlled by the task-argument ('transcribe' vs. 'translate'). I was unable to forward this option to the whisper asr-model, as the keyword task is used for 'automatic-speech-recognition'.
Whisper by itself is fully capable to transcribe the input audio in german into german language - however not speaker diarized.
Is there a way to get around this?

cc @sanchit-gandhi maybe?


Javascript random property display

For page3, write a function that displays a random property pulling information from local storage.

Most likely gonna take this assignment

.take


docs: warn that README contains newest features

Might be a good idea, in light of #405 and #406

LGTM! But could you rebase?

@ariporad If we switch to a dev branch like you suggested, it would probably cleaner to just close this. That way docs would not get updated with new features until the next release.
If we find an error with the docs (maybe something is confusing or incomplete), we can merge that into master sooner and rebase dev off of master.

SGTM

@nfischer: One problem with this is that we would push the notice to npm, which wouldn't make much sense.

@ariporad What do you mean by the latest notice? Not quite following you.

If we add a notice that the README is the dev version, then when we push
the README to npm, the notice will be included. Which doesn't make much
sense.
Ari
On Mon, Apr 25, 2016 at 5:17 PM, Nate Fischer<EMAIL_ADDRESS>wrote:

@ariporad https://github.com/ariporad What do you mean by the latest
notice? Not quite following you.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/shelljs/shelljs/pull/410#issuecomment-214570031

I see your point. This notice isn't intended to say so much as "these docs are out of date, don't trust them," but more as "regardless of whether you're at Github or npm, the latest features are at Github and the most-recent-release docs are at npm." If there's a way to better phrase that, let's do it.

KK. LGTM!


ClickHouse: support alter table update ...

It's to support ALTER TABLE [<database>.]<table> UPDATE <column> = <expression> WHERE <filter_expr>.

Setting this to draft since its not waiting for review in the meantime, please feel free to undraft when ready!


Compare the time spent for each epoch between the latest version and the original one

Hi there, I'm experimenting with a query-based method using my own dataset, which consists of around 2000 images, each containing no more than 3 instances usually. I have access to a single GPU with 40GB RAM. Therefore, at the moment and I haven't enabled AMP.
In the original version, it takes approximately 6 mins for each epoch, and I'm able to train with a batch size of 6. Typically, it starts showing signs of overfitting after around 300 epochs (total epochs I set is 500). However, with the current version, each epoch takes around 30 minutes, and I can only set batch size with 1 due to limitation of RAM.
The training is still ongoing, and it seems it might take several days to complete. I'd like to inquire: in your tests, is it normal for each epoch to take significantly longer in the new version? Additionally, regarding the LR values specified in the config file, are they meant for a single GPU or for 8 GPUs?

The latest  version  has some updates, including multi-scale training, training with decoder, etc. We will update the newest version of paper soon. You can try deepspeed, modify the prompt shape for 3 if each image has only 3 instance, try other methods, try a smaller input shape, etc to speed up!

Additionally, I'm also curious about the potential improvement after adding Lora. Have you tested it yourself？ In the previous version, I conducted tests with my own dataset, comparing the performance between freezing and unfreezing the decoder section. The results is same with your paper.

The LoRA will not been included in our paper, and I will wonder it will work well. I just implement it for efficient application. More experiments and improvement will be validated soon.

The latest version has some updates, including multi-scale training, training with decoder, etc. We will update the newest version of paper soon. You can try deepspeed, modify the prompt shape for 3 if each image has only 3 instance, try other methods, try a smaller input shape, etc to speed up!

Thank you for your reply! I did modify the prompt shape, and keep the most of parameters consistent with the previous version. Thank you very much. I'll wait for your updating papers.

The LoRA will not been included in our paper, and I wonder it will work well. I just implement it for efficient application. More experiments and improvement will be validated soon.

I hope so too. It should be effective.


GPTBigCode models generate noise results

https://github.com/vllm-project/vllm/blob/aa84c92ef636e689b506b9842c712e5c615cc73a/vllm/config.py#L101
Adding conditions for falcon models seems break inference for GPTBigCode models. It worked well on commit df5dd3c68ec7007e4b3a27907f4d954f1c7d511d, but broke on commit aa84c92ef636e689b506b9842c712e5c615cc73a.
I have tried WizardCoder 15B, if I change the condition
if (getattr(self.hf_config, "multi_query", False) and
            (self.hf_config.model_type == "falcon" and
             not getattr(self.hf_config, "new_decoder_architecture", False))):

into
if getattr(self.hf_config, "multi_query", False):

, it works well.
I'm not sure whether this is a bug, or I just need some extra configuration?

Maybe it should be an or?

Fixed by #676. Thank you for reporting this!


How to load only depth, bookticker, and trade for backtesting

I am currently using your framework for cryptocurrency trading backtesting. My arbitrage strategy requires only the depth, bookticker, and trade data, and does not need the snapshot data.
Could you please provide some guidance or examples on how to configure the system to load only these specific data types for my backtests?
Thank you for your help!

Could you elaborate on what snapshot you are referring to? If you need depth data, you need an initial snapshot to build the depth at the beginning. If you are okay relying on natural refresh, you don't need to process the snapshot when creating normalized data (npz), and you don't need to input the initial snapshot. HftBacktest primarily uses depth and trade data. The snapshot is part of the depth data, used to recover depth after a connection loss or similar issues. If not provided, it relies on the natural refresh.
Regarding bookticker, do you intend to fuse L2 market depth and L1 data to get the best information? This feature is still unstable, not tested yet. The unstable_fuse feature providing FusedHashMapMarketDepth  helps combine the two data sets and maintain up-to-date best bid and ask information. You need to process the bookticker data set event BBO_EVENT into the normalized data.

Thank you for the detailed response.
I am currently working on a cryptocurrency arbitrage strategy across different exchanges. While learning to perform backtesting, I noticed in your example that when creating the hbt instance, you used AssetBuilder::new().data(data).depth(depth.apply_snapshot("snapshot file.npz")).
However, I only collected the data and did not collect a snapshot file. When I skip the input of the snapshot file, it throws an error.
Could you please advise me on how to proceed without using a snapshot file?
Thank you for your assistance!

Try it below
let hbt = MultiAssetMultiExchangeBacktest::builder()
        .add(
            AssetBuilder::new()
                .data(data)
                .latency_model(latency_model)
                .asset_type(asset_type)
                .maker_fee(-0.00005)
                .taker_fee(0.0007)
                .queue_model(queue_model)
                .depth(|| {
                    let mut depth = HashMapMarketDepth::new(0.000001, 1.0);
                    // Comment out below.
                    // depth.apply_snapshot(&read_npz("1000SHIBUSDT_20240501_SOD.npz").unwrap());
                    depth
                })
                .exchange(ExchangeKind::NoPartialFillExchange)
                .build()
                .unwrap(),
        )
        .build()
        .unwrap();

Thank you! I will try it shortly.


"No JSC registered" when starting Sampling Profiler

I tried to start the "Sampling Profiler". But when I start it, I get the "No JSC registered".
Solution
I see that to register a Sampling Profiler, I need to use registerHeapCapture. Maybe that's left to a third-party library I need to include. In any case, if the solution is to implement a third-party heap capture, then that's what I'm gonna do.
EDIT: looks like that on iOS, I get a JSC in the perf monitor, but no way to start to Sampling Profiler
EDIT: looks like there's a android-jsc project, seems related !
https://github.com/facebook/android-jsc
Additional Information

React Native version: 0.37.0
Platform: Android
Operating System: Linux

Same for me...

Same problem here.
React Native version: 0.38.0
Platform: Android
Operating System: Mac OS X

Mac OS X RN 0.36 - same

+1
React Native version: 0.40.0
Platform: Android
Operating System: Mac OS X

Same problem here.
React Native version: 0.42.0
Platform: Android
Operating System: Mac OS X

Same problem here.
React Native version: 0.43.2
Platform: Android
Operating System: Mac OS X

Same problem here.
React Native version: 0.43.2
Platform: Android
Operating System: Mac OS X

Same problem here.
React Native version: 0.43.2
Platform: Android
Operating System: Mac OS X

React Native version: 0.44
Platform: Android
Operating System: Mac OS X

Same problem here.
React Native version: 0.47
Platform: Android
Operating System: Ubuntu 17.04

Same problem here.
React Native version: 0.47.1
Platform: Android
Operating System: Mac OS X

Same problem here.
React Native version: 0.47.1
Platform: Android
Operating System:  Ubuntu 16.04

Same problem here.
React Native version: 0.48
Platform: Android
Operating System: Ubuntu 16.04

Same problem here.
React Native version: 0.45.1
Platform: Android
Operating System: MacOS 10.12.6

Same problem here.
React Native version: 0.47.0
Platform: Android
Operating System: Windows 10 1703

Still persists in 0.49.3 and 0.50.4. Also happened for me when building with a custom JSC (https://github.com/SoftwareMansion/jsc-android-buildscripts/) with the profiler build flags enabled.

Closing after a period of inactivity. Happy to reopen once more info is provided.

+1
<EMAIL_ADDRESS><EMAIL_ADDRESS>platform: Android
env MacOS


Update angular-appinsights.js

Modified startTrackPage and stopTrackPage calls

Thanks for adding in the check before the call, I'll go ahead and merge this in now.


feat(html/parser): self-closing flag

Description:
Implement is_self_closing for better compress SVG and MathML syntax in HTML.
Note - is_self_closing is true only when you have slash at end, i.e.
, some parsers emits
 with always is_self_closing: true, but it is wrong, br is void element, self closing is XHTML syntax https://dev.w3.org/html5/html-author/#self-closing-tag
Many changes due updating snapshots
BREAKING CHANGE:
Yes
Related issue (if exists):
No

@kdy1 Rebased and fixed


Need a refresh button?

Environment:

droppy 6.8.0
node 8.2.1

When I disable file watch, I find Droppy unable to reflect newly created file (created manually by mkdir command) unless I create another new file under that folder again (this time using Droppy UI). I guess this is because file watch feature is disabled, however, in my case I really do not want file watch because it takes forever to initialize for large directory. Can we have a refresh button to manually refresh and let Droppy examine possible newly created files under specific directory?
Thank you!

I could see such a button being added when watching is disabled, but I'm also interested in the kind of issues you're having with enabled watching. What kind of delays are we talking about and how many files do you have in these directories?
Maybe I'll also try another watcher implementation like https://github.com/Axosoft/nsfw, to see if it's more lightweight than the chokidar module.

I currently use Droppy to host and manage essentially all my personal data. It is hard to evaluate how many files I have now. The complains that Droppy has I have also reported in this issue: https://github.com/silverwind/droppy/issues/307

It is very desired to have such a button, otherwise the watch=false config basically will not be complete to use I assume.

@silverwind Thank you so much for making this change. I love this Reload view button, it works like magic!


Cannot fetch budgets

Hi there,
I've obtained my API key and I'm trying to run the code, implemented in the "Getting Started" section.
After changing YOUR_API_KEY to my own I'm getting:
Traceback (most recent call last):   File "budget.py", line 16, in <module>     api_response = api_instance.get_budgets()   File "/usr/local/lib/python2.7/site-packages/ynab_client/api/budgets_api.py", line 248, in get_budgets     (data) = self.get_budgets_with_http_info(**kwargs)  # noqa: E501   File "/usr/local/lib/python2.7/site-packages/ynab_client/api/budgets_api.py", line 315, in get_budgets_with_http_info     collection_formats=collection_formats)   File "/usr/local/lib/python2.7/site-packages/ynab_client/api_client.py", line 322, in call_api     _preload_content, _request_timeout)   File "/usr/local/lib/python2.7/site-packages/ynab_client/api_client.py", line 161, in __call_api     return_data = self.deserialize(response_data, response_type)   File "/usr/local/lib/python2.7/site-packages/ynab_client/api_client.py", line 233, in deserialize     return self.__deserialize(data, response_type)   File "/usr/local/lib/python2.7/site-packages/ynab_client/api_client.py", line 272, in __deserialize     return self.__deserialize_model(data, klass)   File "/usr/local/lib/python2.7/site-packages/ynab_client/api_client.py", line 613, in __deserialize_model     kwargs[attr] = self.__deserialize(value, attr_type)   File "/usr/local/lib/python2.7/site-packages/ynab_client/api_client.py", line 272, in __deserialize     return self.__deserialize_model(data, klass)   File "/usr/local/lib/python2.7/site-packages/ynab_client/api_client.py", line 613, in __deserialize_model     kwargs[attr] = self.__deserialize(value, attr_type)   File "/usr/local/lib/python2.7/site-packages/ynab_client/api_client.py", line 250, in __deserialize     for sub_data in data]   File "/usr/local/lib/python2.7/site-packages/ynab_client/api_client.py", line 272, in __deserialize     return self.__deserialize_model(data, klass)   File "/usr/local/lib/python2.7/site-packages/ynab_client/api_client.py", line 613, in __deserialize_model     kwargs[attr] = self.__deserialize(value, attr_type)   File "/usr/local/lib/python2.7/site-packages/ynab_client/api_client.py", line 272, in __deserialize     return self.__deserialize_model(data, klass)   File "/usr/local/lib/python2.7/site-packages/ynab_client/api_client.py", line 613, in __deserialize_model     kwargs[attr] = self.__deserialize(value, attr_type)   File "/usr/local/lib/python2.7/site-packages/ynab_client/api_client.py", line 264, in __deserialize     return self.__deserialize_primitive(data, klass)   File "/usr/local/lib/python2.7/site-packages/ynab_client/api_client.py", line 544, in __deserialize_primitive     return six.u(data)   File "/usr/local/lib/python2.7/site-packages/six.py", line 653, in u     return unicode(s.replace(r'\\', r'\\\\'), "unicode_escape") TypeError: decoding Unicode is not supported
Am I missing something?

I decided to code it myself from scratch, thus closing the issue.
If anybody is interested - here's the linkk to the particular code fragment.


Samuel ipsum example to readme

samuel ipsum example :punch:

I'll cheerfully merge this just please move it outside this fenced code block to separate readme section. Something like ## Examples would do the trick :wink: Reason I'm asking you to do that is because this block is filled with pasted output of $ duckiesay --help so it does not get out of sync :bowtie:

@vladimyr how about we add it to help output as well?

Feel free :+1:

@vladimyr  its updated :haircut_man:

Wow this repo is advancing at warp speed 🤡


Don't add report screen by default when visiting RHP in narrow layout

Details

When we open a RHP, it will add a report screen by default so it's shown in the background on large screen, but we don't need this in narrow layout.
Fixed Issues

$ https://github.com/Expensify/App/issues/38390
PROPOSAL: https://github.com/Expensify/App/issues/38390#issuecomment-1999821702
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Android/iOS/mWeb

Deep link to a profile page (staging.new.expensify.com/a/asd)
Press back
Verify LHN is shown instead of report screen

Web/Desktop

Deep link to a profile page (staging.new.expensify.com/a/asd)
Verify there is a report screen under the RHP

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/50919443/e2bbcfe4-1a8b-4fc0-bc75-6cbaa39af0c5

Android: mWeb Chrome

https://github.com/Expensify/App/assets/50919443/8903471e-0773-4a0c-bbc5-04e287a74747

iOS: Native

https://github.com/Expensify/App/assets/50919443/0f6f8dc1-ae8b-472e-8b0b-17ec1a8b0007

iOS: mWeb Safari

https://github.com/Expensify/App/assets/50919443/6510866a-f616-47a8-88ae-11d47603e4a8

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/50919443/b5c17bcb-ec9d-4fbb-a2a3-52bc7833b4cf

MacOS: Desktop

https://github.com/Expensify/App/assets/50919443/89743da8-4509-4910-8435-021270092d93

Merged with main, passes now.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/deetergp in version: 1.4.62-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/deetergp in version: 1.4.62-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.62-17 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


chore: Revert CachyOS tweaks, set esync nofile limit & tweak PCI latency

I see that realtime-setup RPM is installed, which already fiddles with IRQ priorities, PAM limits & that stuff, so I removed duplicate things from CachyOS & only included PCI latency service for now.
I also made sure that nolimit tweak is applied properly through systemd also.

Looks good to me!


perf(progress-circle): clean up animation on destroy

The indeterminate animation is based on an interval that keeps running, even after the element has been destroyed.
This change cleans up when the element is destroyed.
Also adds an extra null check for performance.now.

@crisbeto Can you add a unit test for this?

Done @jelbourn, although some of the CI builds are failing because of unrelated issues. (missing requestAnimationFrame, Node errors)

Only remaining CI errors are lint

It's updated to use a getter/setter on the interval and resetting it on the setter instead to avoid intervals stacking up. The CI is still throwing a Node ELIFECYCLE error, though.

That node error message is just garbage that gets thrown when there's a tslint error. The actual problem is just above:
https://travis-ci.org/angular/material2/jobs/134867948#L264

There we go.

LGTM


Release Flatcar Container Linux Alpha 3529.0.0

Release Flatcar Container Linux Alpha 3529.0.0
The release of Flatcar Container Linux Alpha 3529.0.0 is planned for March 2nd, 2023
Tasks

[ ] Go / No Go hackmd doc created from previous one for test tracking and release notes: link ()
[ ] All planned changes are merged & blocker bugs are fixed, last nightly reviewed for problems ()
[ ] Branch off main (only new major) ()
[ ] Tag build branch ()
[ ] Start Jenkins builds, post links as comment ()
[ ] Test status captured in hackmd doc ()
[ ] All tests are green ()
[ ] Release notes / announcements added to Go/No Go doc from container/image_changes job by selecting Timestamps: None ()
[ ] QA: check diff for image file list, packages, and image size in the image job output ()
[ ] Matrix Go/No Go meeting (inc. release notes review) ()
[ ] Update payload signed/uploaded ()
[ ] scripts release created on GitHub ()
[ ] Release job container/release ran ()
[ ] Images uploaded with copy-to-origin.sh ()
[ ] Azure offer updated & publishing started ()
[ ] Azure Go Live ()
[ ] GCP offers updated ()
[ ] Symlink to "current" updated with set-symlink.sh ()
[ ] Website updated with ./update-flatcar-versions.sh and PR merged ()
[ ] Release package published in Nebraska ()
[ ] Send announcement to Mailing Lists ()
[ ] Send Tweet out (@miao0miao, @ahrkrak)
[ ] Brief version announcement in slack (k8s slack #flatcar) and the Flatcar matrix channel

As per discussion on the Matrix channel, we will discard the Alpha 3529.0.0 and release the Alpha release alongwith the other channels in the week of March 6th.


Fix custom cli commands in open_float_terminal

Allow custom cli commands to be passed through :Lspsaga open_floaterm
Close the floating window and the shadow window correctly when the custom cli command ends.
Add docs for custom cli commands.

@someoneinjd  have you done this pr? if done i will merge.

@glepnir I think this pr is ready to be merged :)


[BUG] nodes which move to <template/> as part of <Slot> lose their attached data

fixed by https://github.com/BuilderIO/qwik/commit/a4a6b98b75d9734f6115cb41d2d8675877ce3554


Exposes the apply_floor_snap function to allow manual snap

In version 4.0, snapping is only done "intelligently" according to the velocity, assuming that there is no vertical velocity introduced by move and slide on slopes. Some users want to add vertical velocity and snap the body, this PR expose a method to manually snap.
Solve: #4259
Enough to close : https://github.com/godotengine/godot-proposals/issues/6066 (I think)
Fix (already closed): #71993
@yosoyfreeman

Thank you so much for taking the time to look into this. This issue was going to cause some real confusion when Godot 4 launches and cause problems in some type of controllers. Now the new system should cover almost any use case for the body and able us to start making more in deep tutorials about it for the users. Really exited about it. Awesome work.
PD: Yes, this totally fixes this: https://github.com/godotengine/godot-proposals/issues/6066 as the other part of the problem was just about how to approach the issue.

Thanks!

I'm new to understanding the bug/suggestion forums. Can someone help me understand where to find the documentation for the new option: Closes->Allow Character body to snap... ? I see that we can use it because the issue was closed, but I don't understand how to access the new methodology?
Thank you so much for helping me. I want to be a part of these discussions but feel lost in how to follow them.

Hi @GigglingGalaxy , don't worry, I'm sure you will get it eventually, just give you time.
Let me explain a few concepts: There are two main repos, one is Godot, which handles bugs and PR, and there is Godot-Proposals, in which you can open issues to make proposals and this are talked about and revised.
In general terms, you don't want to rise again old issues unless you have new information about them. For asking help, the Godot discord, Reddit and rocket chat are great places to do so. Reactions to post are often preferred for just reactions or general feeling without adding new information or making new questions.
As you can see, this creates 3 different distinctions: a place for the engine itself, a place for "suggestions" and other places for help or chatting.
Hope this can help! For future general questions the other places are a better fit.
Nice day!

@yosoyfreeman THANK you so much. I had gotten pretty good with the forums (Reddit) but didn't know about track chat (signing up now)! Plus, I didn't know the main Godot Discord had help, too. And thank you for the repo clarification!!
I clicked on all the "closed" ones, and they led me to here: https://github.com/godotengine/godot/pull/73749/files#diff-a6e2fcdab85b0f09f122caff8779e31244453c0360d1f2d89b035989f87b694e - I think it is docs for where the suggestions/proposals for slide and snap 2.0 were merged and implemented? This was MOST helpful to see the new changes implemented in code based on use case. That's what I was trying to find.
I saw the "slide" related checkboxes in inspector on CharBody3D so I understood that some of the "slide" was built in now, but was not understanding how to bring back the snap.
All in all, your reply helped me separate out in my mind where to go for what information and I am SO grateful. I am a Unity refugee and haven't been in Godot since 2016 lol. My searches on Google were not productive. I am  so excited to check Discord and Rocket Chat for answers now!
Again, thank you for taking the time to help me understand.


audio.setSongVolume() doesnt work if set before playSong()

Problem seems to be here.
https://github.com/h4570/tyra/blob/d58163d75be2d6c848f4456f73cebd8a6c1a63bd/src/engine/modules/audio.cpp#L82

Resolved in Tyra 2.0.0


CVE-2023-52425 in debian based images

Is there any work being done to resolve CVE-2023-52425?
Debian base images do not have this issue at this time.
Thanks!

No fix is available for bookworm (aka stable) or bullseye (aka old-stable): https://security-tracker.debian.org/tracker/CVE-2023-52425, so there is nothing we can do aside from (the not insignificant task of) contributing the fix in Debian.


test_del hangs when running tests on pypy

Both cases of test_del hang indefinitely on PyPy. This is probably due to the differences of how PyPy does (not) perform GC.

                If ``timeout <= 0``, there is no timeout and this method will
                block until the lock could be acquired.
                If ``timeout`` is None, the default :attr:`~timeout` is used.

            :arg float poll_intervall:
                We check once in *poll_intervall* seconds if we can acquire the
                file lock.

            :raises Timeout:
                if the lock could not be acquired in *timeout* seconds.

            .. versionchanged:: 2.0.0

                This method returns now a *proxy* object instead of *self*,
                so that it can be used in a with statement without side effects.
            """
        # Use the default timeout, if no timeout is provided.
        if timeout is None:
            timeout = self.timeout

        # Increment the number right at the beginning.

                If ``timeout <= 0``, there is no timeout and this method will
                block until the lock could be acquired.
                If ``timeout`` is None, the default :attr:`~timeout` is used.

            :arg float poll_intervall:
                We check once in *poll_intervall* seconds if we can acquire the
                file lock.

            :raises Timeout:
                if the lock could not be acquired in *timeout* seconds.

            .. versionchanged:: 2.0.0

                This method returns now a *proxy* object instead of *self*,
                so that it can be used in a with statement without side effects.
            """
        # Use the default timeout, if no timeout is provided.
        if timeout is None:
            timeout = self.timeout

        # Increment the number right at the beginning.
        # We can still undo it, if something fails.
        with self._thread_lock:
            self._lock_counter += 1

        lock_id = id(self)
        lock_filename = self._lock_file
        start_time = time.time()
        try:
            while True:
                with self._thread_lock:
                    if not self.is_locked:
                        logger().debug('Attempting to acquire lock %s on %s', lock_id, lock_filename)
                        self._acquire()

                if self.is_locked:
                    logger().info('Lock %s acquired on %s', lock_id, lock_filename)
                    break
                elif timeout >= 0 and time.time() - start_time > timeout:
                    logger().debug('Timeout on acquiring lock %s on %s', lock_id, lock_filename)
                    raise Timeout(self._lock_file)
                else:
                    logger().debug(
                        'Lock %s not acquired on %s, waiting %s seconds ...',
                        lock_id, lock_filename, poll_intervall
                    )
>                   time.sleep(poll_intervall)
E                   Failed: Timeout >15.0s

filelock.py:284: Failed
====================================================== 2 failed, 21 passed in 38.50 seconds =======================================================

(happens with pypy3 too)