JS error on each keystroke coming from scribe-plugin-smart-lists.js

Uncaught TypeError: Cannot read property 'isBlockElement' of undefinedfindBlockContainer @ scribe-plugin-smart-lists.js:26

@rrees My previous PR introduced a backwards-incompatible change by removing scribe.element. I thought about going through all the plugins I knew of, but I find adding it back as an alias of scribe.node and mark it as obsolete would be a better fit. If that's fine with you, I'll submit a PR asap.

@regiskuckaertz Okay, sounds good but it's probably worth changing the plugins as well

@trevordixon this should be fixed now, can you confirm?

Yep, no more error.


Image preview is blurry when uploading a long image

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Navigate to a conversation
Upload this image
Check the image preview in chat

Expected Result:
Image should not be blurry on preview.
Actual Result:
Image is blurry in preview.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.0.93-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
View all open jobs on GitHub

@mallenexpensify https://expensify.slack.com/archives/C01GTK53T8Q/p1630683790390300

Text in screenshot is blurry and unreadable when sent/received in NewDot, deets in

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Proposed Solution:
Whenever  we upload image there is a corresponding thumbnail generation logic is there at server side. So server side thumbnail generation logic is designed in such a way that, it will cap thumbnail width or height to max 1024px. (I can say this based on the various image I uploaded for testing and analysed generated thumbnail size).
So any image dimension fall into three types as under, so server will generate thumbnail accordingly.
CaseA: If uploaded image is landscape (i.e. width > height) then it will cap thumbnail max width to 1024px and generate thumb height according to original image aspect ratio.
CaseB: If uploaded image is portrait (i.e. height > width) then it will cap thumbnail max height to 1024px and generate thumb width according to original image aspect ratio.
CaseC: If uploaded image is square (i.e. height === width) then it will cap thumbnail max height or width to 1024px and generate other dimension according to original image aspect ratio.
Now here is calculation: Given sample image is long and its original size is 1314w X 7808h.
i.e. this is  portrait(h>w). So server will cap thumbnail max height to 1024px (if height > 1024) and generate thumb width as per image aspect ratio.
So server generated thumbHeight: 1024px and thumbWidth=172px ( i.e. (1024 * 1314)/ 7808). This is fine there is not any problem in server side thumbnail generation.
Now here is reason why Image preview blurry for that specific image.
Image preview thumbnail is rendered via ThumbnailImage.js component within chat. As we can see at line 39  const thumbnailScreenWidth = 250;  it means it will fix thumb Image width to 250 and calculate height accordingly to render within ui. So within chat ui all image shows as same width.
This works fine if generated thumbnail image width is 250px or larger (so in that case blur will not happen), But here our sample image thumbnail width is 172px, and it is rendering as 250px width, i.e. its width is stretched from 172px to 250px within ui so it become blurry.
https://github.com/Expensify/App/blob/6cd518e81fb60415ba8d4d4a659fdc5dfa95b6fd/src/components/ThumbnailImage.js#L36-L43
Solution 1 - Remove Blur Problem via Ui Logic Update:
We have to update line 39 within ThumbnailImage.js file  as under, i.e. if thumb image width less than 250px then we have to consider thumb image width, otherwise consider 250px. So if any thumb image width smaller than 250px then it will render as original thumb width, otherwise render as 250px width.
So after updating this solution it happen that all thumb image those width >=250px will render as same size, and some special case image (e.g. we used specific dimension image in this issue) those thumb width less than 250px will render as smaller width without any blur.
 updateImageSize({width, height}) {
     // Width of the thumbnail works better as a constant than it does
     // a percentage of the screen width since it is relative to each screen
     const thumbnailScreenWidth = width < 250 ? width : 250;    // *** Update This line ***
     const scaleFactor = width / thumbnailScreenWidth;
     const imageHeight = height / scaleFactor;
     this.setState({thumbnailWidth: thumbnailScreenWidth, thumbnailHeight: imageHeight});
 }

Below is the screen recording that shows how ui looks when Solution 1 implemented, there is not any blur now.
https://user-images.githubusercontent.com/7823358/132100699-596e04ae-2943-4fac-b4a2-5ca116472bfc.mov
Solution 2 - Remove Blur Problem via Server Side Update:
Second solution is to update thumbnail generation logic at server side. i.e. Whenever any thumbnail generated at server side it should be generated in such a way that thumbnail width should not be smaller than 250px and generate thumb height accordingly to original aspect ratio.
So this will solve blur problem for thumb image  those will be generated after updating server side logic. But here one thing we have to consider that if some thumb image already generated in the past having width smaller than 250px it needs to flush out and regenerate again during next request for that thumbnail.
So this is all about my analysis and solution for this problem.
I understand that External label not set with this issue. So at present consider this as my suggestion. It will be helpful to someone who handle this issue internally.
If this issue considered as external and my Solution 1 (Remove Blur Problem via Ui Logic Update) accepted then kindly invite me on Upwork once project posted. Here is my upwork profile: https://www.upwork.com/freelancers/~01c718889ed7821f82  Thanks.

Triggered auto assignment to @bfitzexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Triggered auto assignment to @mountiny (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@PrashantMangukiya Hi 👋 that is an amazing investigation and description of the problem.
I believe considering Solution 1 should be good enough, but there is one thing I would want us to consider as well. We are now talking about hypothetical and extreme dimensions, but in case of extremely tall image (ie. screenshot of entire long page), we could end up with very narrow image preview, which would be hard to touch on mobile device.
Thus, I believe it would be beneficial to also add a minimum width cap just in case, which should be around 40px which is a width of UI element comfortable for user to touch. What do you think about this idea? If you agree, could you please incorporate that into your proposal?
I would then be very happy to hire you for this job on Upwork once this gets resolved.

Hi @mountiny Thank you for the message.
I think what you suggest 40px min width cap is a good point. Not sure why I missed that point after doing this details level research. Any way good catch from your side.
Let met update my proposal to incorporate it. I will update you as soon as incorporated within few minutes. So you can proceed further to post job on Upwork. Thank you.

@PrashantMangukiya Great! Thank you!
After watching the screenshare video once more, I have noticed the picture has still been kind of blurry. I am not sure if it is the picture itself. Could you please make sure with some different sharp image, that this proposed solution works as expected and share a screenshot of the thumbnail and the original picture too. Possibly comparison between thumbnail on main and your proposed solution?
Thank you very much!

@mountiny Thank you for the message.
Sample image used to reproduce this issue consist text based information so when thumbnail generated at server side blur may be introduce due to text info within image. But we can not do assumption, So let me do some more detail investigation and make sure there is not any hidden issue other place  and thumbnail is rendering as expected size.
I will also do testing on long sharp image so we get more idea about it. I will update you as soon as more result comes. Thanks.

@PrashantMangukiya Job post on Upwork is here.

@bfitzexpensify I can not see job although logged in to upwork. It shows below screen. It looks like this is internal/private job etc. Can you invite me on this job, may be it solve the problem. My upwork profile is https://www.upwork.com/freelancers/~01c718889ed7821f82

Ah you're right! Sorry about that — here is the right link.

Hi @mountiny ,
I did more investigation on this issue using extra long color image. Here is Sample1 and Sample2 image used for this. I will suggest to  @mountiny, @isagoico, and @bfitzexpensify  also to reproduce this additional issue using sample1 and sample2 image link, So I can make sure this issue happen for everyone.
Additional issue is that some padding shows at  top and bottom of extra long image as shown below screenshot (Blur issue is already there and Solution I suggested in my proposal works for that)  But below additional issue connected with long height image, So I am thinking we have to also investigate and correct this additional issue togheter.
@bfitzexpensify  I will do more research on this additional issue and once get solution thereafter submit my proposal on Upwork, so it will be ok? Because at present I dont know how much research it will need.
Below is additional issue, i.e. some padding generated at top and bottom border of extra long image.

Yep, I'm also able to reproduce that.

@PrashantMangukiya Good investigation! I assume the white block padding issue prevails even with your proposed changes here, correct me if I am wrong.
I think the best way to go with that new issue is to follow these steps once you make sure it is actual bug.
Don't forget about the minimal width restriction as well in your proposal and feel free to start a PR!

Hi @mountiny, yes that white padding issue remain although I correct image blur problem.
I added clamp logic within my solution 1 as per your suggestion. Here is link https://github.com/Expensify/App/issues/5092#issuecomment-912999085  Please suggest any other thing need to take care.  If everything ok then I will submit proposal on upwork to proceed.
As you can see below screenshot, padding issue still there after solving image blur problem. I also notice that top bottom padding increase as image become more narrow. I will contune research on this white padding and share solution for this new issue as soon as found something.

I also notice that this top bottom padding exist for too long height image that I used. For normal long image it shows as expected.
I think it is better to create another issue for this top bottom white padding. @isagoico what you suggest? Should I submit bug request within Slack as per new rule, our you will create new issue for this bug  and mention my name as bug suggester. It will be ok whatever you suggest.
Thanks.

@PrashantMangukiya  Ah you have updated the original comment, sorry, my bad! thank you for that.
Your proposal seems good to me for this issue. Feel free to submit a proposal on Upwork and create a PR for this. Great job!

Should I submit bug request within Slack as per new rule, our you will create new issue for this bug and mention my name as bug suggester. It will be ok whatever you suggest.

I think it is safe to post it in the channel, @isagoico will definitely mention you as a suggester that way! You won't miss that.

@mountiny Sure I will post bug request in the slack channel.  @bfitzexpensify I submitted proposal on upwork. Kindly accept it. Thank you.

Just to make it formal. @bfitzexpensify we are good to hire Prashant for this job. Thank you for handling that 🙇
@PrashantMangukiya You will be assinged to this issue right after that.

Offer sent!

@bfitzexpensify  just accepted offer. thanks. Also thanks @mountiny for suggesting to set 40px cap for image width. I will prepare and submit pr within a day.

@isagoico I posted bug in slack channel related to padding issue at top bottom of long image in chat list.
Here is the link  https://expensify.slack.com/archives/C01GTK53T8Q/p1631205658119900
I also found another bug that Large image does not zoom as expected in mobile device attachment view modal. Here is the posted link: https://expensify.slack.com/archives/C01GTK53T8Q/p1631206579123200
Thank you for your time.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @tgolen in version: 1.0.95-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.0.96-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

paid


draft generate-workflow drops tag when updating the deployment manifest

Describe the bug
When using draft generate-workflow, the deployment manifest created by draft create is updated based on the ACR specified and container image name supplied, but the tag is not requested and therefore lost when the manifest is rewritten.
Mention the platform you are using
Using draft CLI
> draft version
version:  0.0.33
runtime SHA:  2142dbc745ac8284999f3384358680c7bc6f8570

To Reproduce
git clone https://github.com/smurawski/drafttesting
cd drafttesting
git checkout draft_create

draft generate-workflow -b main \
  -x . \
  -c aks1 \
  --container-name drafttesting \
  --deploy-type manifest \
  --registry-name acrxms72d \
  --resource-group drafttesting

The ./manifests/deployment.yaml file will be updated and the tag for the image lost.
Expected behavior
Ideally, draft would read the existing manifest and default the container registry prompt and image name, as well as offer a prompt for tag with the default of what was in the existing YAML file.
A sufficient result would be achieved if the tag was prompted for and filled in for the deployment.yaml file.
Desktop (please complete the following information):

OS: Windows
Shell: PowerShell 7.3.6

Disregard - the build task passes in the image from the build.
It feels a bit odd to have to enter it into the template with the image and tag are generated and supplied in the build making the information prompted for irrelevent.


[CHE-206] : Create a new beta Helm version for namespace label

declining this PR as story https://cloudhealthtech.atlassian.net/browse/CHE-210 works on including this in main branch


If fileinfo ext is not available use a fallback method to determine mimetype of a compressed phar file

The latest version forces both Drupal and Typo3 to be dependent on PHP's fileinfo extension. Previously this was only suggested for the Typo3 CMS (see https://github.com/TYPO3/TYPO3.CMS/blob/master/composer.json) and is not part of Drupal's requirements - see https://www.drupal.org/project/drupal/issues/3053552.

Thanks for you PR and the change seems to be logical. I'm wondering whether mime_content_type would have worked or whether there's a simpler way than integrating another package.
So basically we need to distinguish between application/x-gzip, application/x-bzip2 or none of those (assuming plain Phar format then).
I think it could be possible to include headers for both formats directs, like mentioned at https://github.com/threatstack/libmagic/blob/1249b5cd02c3b6fb9b917d16c76bc76c862932b6/magic/Magdir/archive or https://en.wikipedia.org/wiki/List_of_file_signatures

@alexpott Please see https://github.com/TYPO3/phar-stream-wrapper/commit/1dffd3df179c27c42f839349ace2c901c0f65b73 as possible alternative...

Remarks taken from 1dffd3df179c27c42f839349ace2c901c0f65b73

Are you sure about this code? https://www.filesignatures.net/index.php? page=search&search=425A68&mode=SIG
Googling for "425a68 bz2" reveals far more than "425268 bz2"
Yeah - this code needed some tweaks but I think the general idea of not having more dependencies is great so a reworked my PR - see c6a62a4

@alexpott The results for 425a68 are using bzip2 in the end (actually .tar.bz2).

I'm confused. isn't bzip2 what we want to detect given the code (not changed here)
    /**
     * Resolves stream in order to handle compressed Phar archives.
     *
     * @return string
     */
    private function resolveStream(): string
    {
        if ($this->fileType === 'application/x-gzip') {
            return 'compress.zlib://';
        } elseif ($this->fileType === 'application/x-bzip2') {
            return 'compress.bzip2://';
        }
        return '';
    }

@ohader I'm confused. isn't bzip2 what we want to detect given the code (not changed here)

Exactly. I wanted to express, that file header starting with 425a68 (hex, equals BZh ascii) are correct.
For instance tbz2 on filesignatures.net refers to .tar.bz2 which would be extracted/unwrapped like this
bunzip2 file.tar.bz2  # file.tar.bz2 was application/x-bzip2
tar -xf file.tar      # file.tar was application/x-tar

From my point of view this is correct and expected...

The latest changes all good to me. The only thing I ponder is the name of the method determineFileTypeByHeader as our implementation is way more limited than the method name suggests.

I did not have a better idea on that method name - thus, I used the power of comments ;)

Yeah me neither.  Comments look good to me. I think this is ready.

I'm going to start back-ports now...

Back-port in #37


Support for plain HTML?

For example to support auto completion within brackets:
 hey</a

Unsure what you mean:

auto completion within brackets? – that should already work
support for plain HTML? – working on that one

I mainly meant 2.
-------- Original Message --------
On Mar. 26, 2021, 1:15 p.m., Sascha Tandel wrote:

Unsure what you mean:

auto completion within brackets? – that should already work
support for plain HTML? – working on that one

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

It's on the list.

Note that plain class props  / JSX attributes are supported in .tsx and .jsx files, but indeed not in HTML documents.
Related issue: https://github.com/tw-in-js/typescript-plugin/issues/11#issuecomment-803987980

Somewhat related (I can open a separate issue if not related enough):
The extension doesn't provide suggestions when using the htm package. E.g.:
const { html } = require('htm/preact')

const Component = () => html`

`

I tried setting "editor.quickSuggestions": { "strings": true }, but it didn't have any effect.

Unsure what you mean:

auto completion within brackets? – that should already work
support for plain HTML? – working on that one

Eagerly waiting for plain HTML support...

Hi, is this still being worked on?  Is there anything I can do to help?


Env/Gradle property providers do not handle absence alone

Expected Behavior

I would expect a non-existent env or gradle property to result in an absent provider/property
Current Behavior

It will throw.
Context

In some cases, certain envs or properties may only exist in certain environments (such as CI). When trying to create a property around these, a task that accepts them with no wrapping will fail rather than allow the task to rely on semantics like orElse or orNull.
Steps to Reproduce

Simple setup in a build.gradle.kts file
val userProvider = project.providers.environmentVariable("NOT_A_REAL_ENV")

abstract class TestTask : DefaultTask() {
  @get:Input
  abstract val userProp: Property<String>

  @TaskAction
  fun printUser() {
    println(userProp.orNull ?: "Absent")
  }
}

project.tasks.register<TestTask>("testTask") {
  userProp.set(userProvider)
}

Then run ./gradlew testTask and you will see this exception during configuration
A problem was found with the configuration of task ':testTask' (type 'Build_gradle.TestTask').
> No value has been specified for property 'userProp'.

Interestingly, it does handle absence on the property itself. For example, this change will make the task/configuration pass.
val userProvider = project.providers.environmentVariable("NOT_A_REAL_ENV")
    .orElse("Absent")

The same results happen if you use gradleProperty instead of environmentVariable. Same workaround makes it pass too
A problem was found with the configuration of task ':testTask' (type 'Build_gradle.TestTask').
> No value has been specified for property 'userProp'.

Your Environment

Build scan URL:

Hi @ZacSweers 👋
userProp is missing a @get:Optional annotation.

D'oh! 🤦♂
Would it be of interest to make this issue a FR for that to be a suggestion in the error message? Something like "did you mean to make this property optional?" maybe?

This has bitten me before, so enhancing the error message with "maybe use @Optional?" seems potentially useful.

FYI @runningcode - using convention on the property itself doesn't actually seem to escape this, which seems odd 🤔
val userProvider = project.providers.environmentVariable("NOT_A_REAL_ENV")

abstract class TestTask @Inject constructor(objects: ObjectFactory) : DefaultTask() {
  @get:Input
  val userProp: Property<String> = objects.property<String>().convention("default")

  @TaskAction
  fun printUser() {
    println(userProp.orNull ?: "Absent")
  }
}

project.tasks.register<TestTask>("testTask") {
  userProp.set(userProvider)
}

Will result in
A problem was found with the configuration of task ':testTask' (type 'TestTask').
> No value has been specified for property 'userProp'.

@ZacSweers, failing with No value has been specified for property... is the expected behaviour in that case.
The reason for that is that a given convention value is only used when no value (or provider) has been set for the property. It is not the same as providing a default value.
If you believe this behaviour is not ideal, please open a separate feature request.


index.ts registerOperatorWithSignature outdated

In the registerOperator function within operator/index.ts of the hello-world-avs template, registerOperatorWithSignature(address, signature) is called using an outdated ABI. This does not match the registerOperatorWithSignature(signature, address) in unaudited/ECDSAStakeRegistry.sol.
Please update the index.ts code in hello-world-avs and the corresponding ABI to facilitate future development.

Thank you for reporting this! I'm struggling with resolving a similar breaking point in the code.
Can you clarify where you confirmed the ABI is outdated? Eg per here the signature does not appear to have changed.

Thanks @ryjiangx this should be fixed now


feat: Add explanations

Todo:

[ ] Test open dialog with from loading url
[ ] Fix E2E test

In another PR

[ ] Fix font
[ ] add logo to qr
[ ] add back button from game page


[UI] Correct "convert_weight_only" to "convert_weights_only"

This is a frequent typo among multiple developers, as "weights" is typically plural.  This commit updates the command-line-argument from --convert-weight-only to --convert-weights-only.  For backwards compatibility, the original spelling is kept as an equivalent usage.

Marked as a draft until local testing is finished by myself or somebody else.

Rebased onto main to resolve conflicts, works with local testing, and ready for review/merge.


Is this project still supported?

Hi Team,
Not reporting a bug, but wanted to know if I can speak with someone who is running this project - might have a use-case that you might find interesting<EMAIL_ADDRESS>

@xuhdev

Thank you!

Hi @zacaintmyname, I believe this project still is supported. I left IBM earlier this year but @xuhdev is still on the team at IBM and he can probably let you know if this is still a priority.

Thanks you @bdwyer2! Appreciate the reply 👍

great product btw! just discovered it yesterday.
(p.s. there's no way to configure the size of the summary, is there? to make it longer or shorter, etc...?)

Thanks @bdwyer2 , we have started talking offline.


Allow disabling IPv6

This change allows disabling IPv6 - the type is defined as a union only when IPv4 and IPv6 are enabled here
I'm not sure if it should be patched in this repo, or at bindgen time, let me know

CI fails though?

My bad, forgot a cfg guard

Thanks!


sls encrypt console command not working (no response in console)

When attempting a command like so: sls encrypt --stage dev -n SECRETS_KEY:SECRETS_VALUE -v password -k 1234-5678-9123-123 --aws-profile profileName we are receiving no reply back from the console. This is on MacOS in a bash terminal. Running latest version of serverless globally (v1.35.1) and as a dev dependency in our node project (using node 8.10.0).
After some investigation, the problem seems to be occurring on line 71 in the index.js (https://github.com/nordcloud/serverless-kms-secrets/blob/master/index.js). The encryptVariable function is never called in the .then block.
Do you have any advice/guidance?

+1 We're also having this issue. If I can get some free time, I might start to dig into/fix this.

The issue is most probably the same than we encountered with serverless-mocha-plugin. Have been superbusy so have not had time to apply the fix yet.

On 13 Feb 2019, at 14.34, Michael Misshore<EMAIL_ADDRESS>wrote:
+1 We're also having this issue. If I can get some free time, I might start to dig into/fix this.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/nordcloud/serverless-kms-secrets/issues/21#issuecomment-463182975, or mute the thread https://github.com/notifications/unsubscribe-auth/AIARbDsjnJyelB6jNXUJdPSJhWdHmhxJks5vNAY5gaJpZM4Z2i4V.

+1 Seeing this issue

@mpuittinen If you point me to the fix in serverless-mocha-plugin I can try a PR to fix this one

This should now be fixed in 1.0.4 (published to npm)


Extract composable for applying props to context

What is the main benefit to extracting this to a composable? If it's to clean up the DrawerRoot component, I think I'd be more in favor of refactoring the context.ts file a bit to allow props to be an additional parameter and having this logic live there
I was also planning to eventually use withDefaults to default props and hopefully clean up all these if statements. Thoughts?

@connerblanton Yeah the primary goal was just to clean that file up a bit. But yes you're definitely right, refactoring context.ts to accept props would be far cleaner. Will close this one off :)


chore: add issue templates

we need to add few issue templates

docs
new feature
style changes
bug
others

please let's do separated issues for each of them


GUINavGroup - how to use?

So I managed to fix my previous issue (issue #190). I've upgraded my copy of BSF to the July 31, 2018 snapshot. I was interested in GUINavGroup, and this one had it, so that's why. It also majorly improved loading speeds too. :) I'm curious though -- how would I use the GuINavGroup? It returns an SPtr, but I can't figure out how to add GUI elements to it, or to add it to a GUI layout. So am I missing something?

Try GUIElement::setNavGroup. In general please prefer to ask all questions on discourse.bsframework.io, while bug reports and (sometimes) feature requests belong here.


Updates Model.java to be up to date with current OllamaAPI

Also adds Jackson-JSR310 for java.time JSON Mapping

Ok, there was some strange behaviour or lagging while creating the PR, I'm sorry for the chaos I created 🙈

Thanks for the PR @AgentSchmecker!


Update AudioClient

This PR rebases the #796 PR by @trmcnvn onto the latest 0.3 work.
Would be great to get this landed as we require AudioClient2 and AudioClient3 upstream for current work in cpal. Let me know if you need anything changed. Thanks.

@JoshuaBatty Would including...
const AUDCLNT_STREAMFLAGS_AUTOCONVERTPCM: DWORD = 0x80000000;
const AUDCLNT_STREAMFLAGS_SRC_DEFAULT_QUALITY: DWORD = 0x08000000;
const AUDCLNT_STREAMFLAGS_PREVENT_LOOPBACK_CAPTURE: DWORD = 0x01000000;

... in um/audiosessiontypes be an option, while at it? The last one is Win10 rev 1803 upwards, but apparently that's a go. Plus, there's https://github.com/RustAudio/cpal/blob/fe22704d4adc2795f33f2e298c5450ece476d58c/src/host/wasapi/device.rs#L1224 to take care of.
I can raise a separate PR of course - sorry if this feels like a hijack.

@alcore thanks for that. I've added in the missing streamflags you mentioned. I think it would be nice to now land this PR as it is and then you can open up a separate PR for the KSAUDIO speaker layouts.
@retep998 just wondering if there is anything else you would like me to address or is this PR happy to be merged? Thanks.

PR needs to be updated to run on new CI.

Is this PR still being worked on? If not I may be able to take over.
I've tried copying code that I think is relevant to AudioClient3 and was able to create one with ActivateAudioInterfaceAsync, but when I tried to use it's functions (ie.  I'm guessing it has something to do with the crate winapi-x86_64-pc-windows-gnu. It's also possible I'm doing something wrong.

Is this PR still being worked on? If not I may be able to take over.
I've tried copying code that I think is relevant to AudioClient3 and was able to create one with ActivateAudioInterfaceAsync, but when I tried to use it's functions (ie.  I'm guessing it has something to do with the crate winapi-x86_64-pc-windows-gnu. It's also possible I'm doing something wrong.


[DesignProposal]: Support parallel in GPU

Background and Motivation
No response
Design
https://zilliverse.feishu.cn/docx/doxcnDUAMa4Vu9D39CsVSvraGrK
Pros and Cons
No response
Anything else? (Additional Context)
No response

@Chiiizzzy could you please post the detailed design instead of posting a link in this issue?

@ reiase
like this code
towhee.dc(['./1.mp4']) \
        .video_decode.ffmpeg(sample_type='uniform_temporal_subsample', args={'num_samples': 12}) \
        .runas_op(func=lambda x: [y for y in x]) \
        .video_text_embedding.clip4clip(model_name='clip_vit_b32', modality='video', device='cpu') \
        .show()

how can assign a video_text_embedding（[0.31566384, -0.07464158, -0.023179442, ...] shape=(480,)
） to a variable


Installation on Windows

Wondering the install process on Windows.
Why virtual environnment is necessary ?
Thanks, regards

Virtualenv isolates this sample's dependencies from your global python packages and the dependencies of other applications. You can read more about it here.


Add a property for the line color

Add a property where the user can specify the line color of the barcode

Released with version 1.04.16


Set fips-compliant CRD feature flag

This change adds the feature flag to indicate that our operator is fips compliant.

duplicated of https://github.com/openstack-k8s-operators/dataplane-operator/pull/881

as noted above this is a duplicated of https://github.com/openstack-k8s-operators/dataplane-operator/pull/881


chore: update to EDC 0.2.1

WHAT
Upgrades to EDC 0.2.1 fixing some compiler errors in the process.
WHY
Limit the technical debt
FURTHER NOTES

fixed som final XYZ -> var in the process

Closes # <-- insert Issue number if one exists

\cc @stefan-ettl @stephanbcbauer


Verify types of input username and password

This should prevent the possibility of illegal offsets. If you poke pfSense WebGUI you'll find some funny stuff. Username and Password should never be arrays at all.
Fussing version 2.2.6 with vulnerability auditing tools throws things like:
Illegal offset type in isset or empty in /etc/inc/auth.inc on line 229
crypt() expects parameter 1 to be string, array given in /etc/inc/auth.inc on line 305
md5() expects parameter 1 to be string, array given in /etc/inc/auth.inc on line 311
Thanks.

Wouldn't is_string() make more sense here?

That could also be an option. For now the objective was just to prevent any illegal uses where an array should not be input at all, but any other type should not yell any errors.
This implementation is open for changes in the future by someone more experienced.


e2e jobs removed

Related to #998
@pmacik @ldimaggi please review, there are still couple of jobs and templates that I didn't remove because I don't know if it's still needed:

contract_tests_consumer_template - used by 1 job
prebooster_tests_template used by 1 job

@ppitonak please resolve conflicts here

@riuvshin rebased

Feel free to remove these jobs:

devtools-test-e2e-openshift.io-logintest-us-east-1a-released
devtools-test-e2e-openshift.io-smoketest-us-east-2a-released
devtools-fabric8-test-build-master
devtools-test-end-to-end-prod-preview.openshift.io-planner-api-test
devtools-test-e2e-prod-preview.openshift.io-smoketest-pr-us-east-2a-beta
devtools-test-e2e-openshift.io-smoketest-us-east-1a-beta
devtools-test-e2e-openshift.io-smoketest-us-east-2-released
devtools-test-e2e-prod-preview.openshift.io-smoketest-pr-us-east-2a-released
devtools-test-e2e-openshift.io-smoketest-us-east-1b-released
devtools-test-e2e-openshift.io-smoketest-us-east-1a-released
devtools-test-e2e-openshift.io-logintest-us-east-2-released
devtools-test-end-to-end-openshift.io-planner-api-test
devtools-test-e2e-openshift.io-logintest-us-east-1b-released
devtools-test-e2e-openshift.io-logintest-us-east-2a-released

[test]


uitextfield is missing when popping out the uitextfield click confirmation button in the popup view.

uitextfield is missing when popping out the uitextfield click confirmation button in the popup view.

Not sure what you mean exactly about the UITextField missing, but feel free to provide your code here so I can take a closer look, thanks!


Support with PHP 5.6.40

Environment details

OS: Windows 10 Pro
PHP version: PHP 5.6.40
Package name and version: google-api-php-client-2.4.1

Steps to reproduce

Create a service account on GCP and get credentials json
Enable Analytics API on GCP for service account
add service account to google analytics users
execute code below with php accessToken.php
will get the following error:

Warning: Unsupported declare 'strict_types' in C:\........\google-api-php-client-2.4.1\vendor\monolog\monolog\src\Monolog\Logger.php on line 1

Parse error: syntax error, unexpected 'const' (T_CONST), expecting variable (T_VARIABLE) in C:\........\google-api-php-client-2.4.1\vendor\monolog\monolog\src\Monolog\Logger.php on line 33

just wanted to confirm if it was actually completely supported by 5.6.X version of PHP.
I was just downloading the release and it seems to include monolog version 2.x which is supported with PHP7.2 or higher only. would i just need to replace the folder under vendor with the 1.x version of monolog to make it compatible or any other changes required? or if i download the zip manually and then go into the folder for the client, will i be able to just run composer install?
Code example
# accessToken.php
<?php
// Load the Google API PHP Client Library.
require_once __DIR__ . '/../google-api-php-client-2.4.1/vendor/autoload.php';

// Create and configure a new client object.
$client = new Google_Client();
$client->setAuthConfig(__DIR__ . '/../client_credentials.json');
$client->setScopes(['https://www.googleapis.com/auth/analytics.readonly']);
$client->refreshTokenWithAssertion();
$token = $client->getAccessToken();
echo $token['access_token'];
?>

I think the Monolog dependency is wrong: https://github.com/googleapis/google-api-php-client/blob/master/composer.json#L13
No idea what Composer is doing in that case.

Hi @auahmed sorry for the delay,
Yes, you should be able to run composer update from the unzipped release package.
We'll look into ways to address this issue going forward.

For anyone else in this situation the newest release compatible with PHP5.5 is 2.2.4

The next version release will include downloadable archives compatible with PHP 5.4, 5.6, 7.0 and 7.4.


Rename IPFS-Desktop-[version]-mac.zip file in Releases?

Is your feature request related to a problem? Please describe.
As noted in https://github.com/ipfs/ipfs-desktop/issues/1922, the "mac.zip" file is used for autoupdate, but should not be downloaded from the GitHub Releases page for installation.
Currently, each Release includes two files that look Mac-related, e.g.:

IPFS-Desktop-0.24.0-mac.zip
IPFS-Desktop-0.24.0.dmg

Worse, the dmg file doesn't say mac in it, so users could be confused if they are not aware that dmg files are only used by Macs, and commonly used for Mac software installation.
Describe the solution you'd like
In releases, rename the "mac.zip" file to something that makes it clear that it's not what most users want to download. For example, "IPFS-Desktop-0.24.0-autoupdate-artifact.zip".
Describe alternatives you've considered
Renaming "IPFS-Desktop-0.24.0.dmg" may also help. For example, "IPFS-Desktop-0.24.0-mac.dmg". Some Mac users are accustomed to looking for "mac" to find the installer for their platform.
Another idea is to add a note in each release that explains the purpose of each asset. This would reduce confusion for people looking through the list of 17 assets.

Triage meeting notes: Need to decide on next action. Can we rename? If not, can we update release description to provide more context for users?
Related:
https://github.com/ipfs/ipfs-desktop/issues/1922
https://www.electron.build/configuration/dmg
https://github.com/electron-userland/electron-builder/pull/6496


fix(lexical/createEditor): avoid implicit any type

Why
We should avoid implicit any type because it may cause problems in the future.
What
Explicitly setup the type of the replace and replaceWithKlass when creating them.
Additional information
before

LGTM!


locationBFDR changes

Changes to the spreadsheet to reflect updates in BFDR re: LocationBFDR profile addition

Not sure why that happened either... just extra empty columns for some reason


[BUG] resource display error

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
我使用K8s部署了hertzbeat，部署成功添加了三个资源，分别为【linux，mysql，k8s】，添加的Linux主机为k8s节点中的一个，我k8s是集群，因此我直接重启了那个节点，重启完成之后我在登录平台，发现我添加的三个资源都已不在。我新开了一台虚拟机，添加到Linux主机资源，于是刷新一会儿显示之前的三个资源，一会儿显示之后添加的这一台资源，经查看，监控信息都还在，应该是显示BUG。
Expected Behavior
正常添加所有资源，一起显示出来。
Steps To Reproduce
重启平台节点
Environment
HertzBeat version(s):latest

Debug logs
无ERROR错误
Anything else?
No response

hi 谢谢反馈 收到🫡
对了我看老哥是k8s部署的，能贡献一波k8s部署hertzbeat的yml嚒嘿嘿，给其它朋友参考参考😊。可以的话希望能放到 仓库 /script/k8s 目录下

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿

hi thanks for your feedback received 🫡
By the way, I see that my brother is deployed by k8s. I can contribute a wave of k8s to deploy the yml of hertzbeat. Hey, I will give other friends a reference. If possible, I hope to put it in the warehouse /script/k8s directory

这个问题我先看一下吧

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿

Let me take a look at this question first

`---
apiVersion: apps/v1
kind: Deployment
metadata:
name: hertzbeat
namespace: app
spec:
replicas: 3
selector:
matchLabels:
name: hertzbeat
template:
metadata:
labels:
name: hertzbeat
spec:
containers:
- name: hertzbeat
image: tancloud/hertzbeat
imagePullPolicy: IfNotPresent
tolerations:
- key: CriticalAddonsOnly
operator: Exists
- effect: NoSchedule
key: node-role.kubernetes.io/master
apiVersion: v1
kind: Service
metadata:
name: hertzbeat
namespace: app
spec:
ports:

name: hertzbeat
port: 1157
selector:
name: hertzbeat
sessionAffinity: None
type: NodePort
`


fix: match cache in read-only mode

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.
[x] I've added or updated relevant unit tests.

Motivation and Context
Resolves #21762 .
Description
The cache can be used only when read-only mode is disabled.
Updates for spec_helper and new test structure copypasted from https://github.com/fastlane/fastlane/pull/21691.
Added test for read-only mode.
Looks better w/o spaces diff.
Testing Steps
Run the match action in read-only mode.

@rogerluan , @lacostej, please review.

I'm OOO till next week, but I'll take a look when I'm back :)

Sorry, it's a regression I've introduced by implementing a cache for the match 😭.
Can someone else look at this?

@joshdholtz , sorry for the ping. Can you please review and release #21767 and #21766 since there is a regression impacting a lot of folks?

For reviewers of this PR - I verified and confirmed that this change fixes the issue for me: https://github.com/fastlane/fastlane/issues/21762#issuecomment-1875580100

I can also confirm that
gem "fastlane",  :git => "git@github.com:nekrich/fastlane.git", :branch => 'fix/match-readonly-mode'

fixes https://github.com/fastlane/fastlane/issues/21762
Good job and thank you!


impl TryFrom for nix::mman::MmapAdvise

We have a use-case where we are intercepting the madvise syscall, and wish to handle certain types of advice specially. Without TryFrom, we need to write boilerplate to safely translate the application-provided i32 into a form nix::mman::madvise will take, and I'm not sure why madvise can't simply implement TryFrom itself?

(For what it's worth, I can't see how the failed check can possibly be related to this change?)

The CI failure was spurious, and I've restarted it.  The change looks reasonable, but could you please add an entry to the CHANGELOG?

The CI failure was spurious, and I've restarted it. The change looks reasonable, but could you please add an entry to the CHANGELOG?

Done.


UnionDict does not work well with Python3.9's dict

An except, 11 tests fail in total
 ________________________ MotifFreqsArrayTests.test_logo ________________________

  self = <tests.test_core.test_profile.MotifFreqsArrayTests testMethod=test_logo>

      def test_logo(self):
          """produces a Drawable with correct layout elements"""
          data = [
              [0.1, 0.3, 0.5, 0.1],
              [0.25, 0.25, 0.25, 0.25],
              [0.05, 0.8, 0.05, 0.1],
              [0.7, 0.1, 0.1, 0.1],
              [0.6, 0.15, 0.05, 0.2],
          ]
          farr = MotifFreqsArray(data, "ACTG")
          # with defaults, has a single x/y axes and number of shapes
          logo = farr.logo(ylim=0.5)
          fig = logo.figure
          self.assertEqual(fig.data, [{}])
  >       self.assertTrue(len(fig.layout.xaxis) > 10)
  E       AssertionError: False is not true

  test_core/test_profile.py:426: AssertionError
  _________________________ TestDendro.test_dendro_shape _________________________

  self = <tests.test_draw.test_dendrogram.TestDendro testMethod=test_dendro_shape>

      def test_dendro_shape(self):
          """exercising using different values of shape parameter"""
          tree = make_tree(treestring="(a:0.1,b:0.1,(c:0.05,(d:0.01,e:0.02):0.01):0.1)")
          for style in ("square", "angular", "circular", "radial"):
              dnd = Dendrogram(tree, style=style)
              # the figure attribute should be a dict
  >           fig = dnd.figure

  test_draw/test_dendrogram.py:125:
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

  self = <cogent3.draw.dendrogram.Dendrogram object at 0x7f93650831c0>

      @property
      def figure(self):
          if not self.traces and hasattr(self, "_build_fig"):
              self._build_fig()

          traces = self.traces if self.traces else [{}]

          if self.xtitle:
              xtitle = self.xtitle
          e = UnionDict({"title": {"text": "Alignment Position"}})
          f = UnionDict(e.copy())
          e |= d
  >       self.assertEqual(e, f)
  E       AssertionError: {'title': {}} != {'title': {'text': 'Alignment Position'}}

  test_util/test_union_dict.py:84: AssertionError

From https://github.com/cogent3/cogent3/pull/850/checks?check_run_id=1849969227#step:10:152 (and matching the failures we see in the Debian package for cogent3, as the only Python3 version in the next stable release of Debian is Python3.9)
Presumable related to https://www.python.org/dev/peps/pep-0584/
I noticed that UnionDict's __or__ implementation is more like the PEP-0584/Python3.9 dict.__ior__ (inplace union); perhaps that difference in semantics, plus a missing __ror__ implementation is the cause.
This is likely to lead to Debian dropping cogent3 if is it not fixed quickly :-(

https://github.com/cogent3/cogent3/pull/850/commits/981491d9527dcd299ae2717f7830c7ea74d31624 fixes the issue for me, but it would be best if UnionDict's __or__ matched the semantics of PEP-0584 (creating a new dictionary, not updating in place, etcetera)


dr-elephant on databricks spark cluster

dr-elephant can be deployed on databricks spark cluster?

Hi @dineshvelmuruga,
If the Databricks Spark cluster uses YARN to launch job and provide Spark metrics via SHS then Dr.Elephant would surely work.


Wrong path resolution for windows drive paths!

Windows Build Number
Microsoft Windows [Version 10.0.19042.985]
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-microsoft-standard-WSL2
Distro Version
20.04
Other Software
No response
Repro Steps

Make any file in Windows drives: touch /mnt/c/somefile
Try to open file: notepad.exe /mnt/c/somefile or notepad++.exe /mnt/c/somefile

Expected Behavior
The path should be resolved successfully to C:\somefile
Actual Behavior

Throws error with path resolved as follows, <drive currently in>:\mnt\<directory where file exists>\somefile
Diagnostic Logs
No response

Connected issue: https://github.com/npm/cli/issues/3248

/dupe #6266 #6207, others. Use:
$ notepad.exe "$(wslpath -w /mnt/c/Users/there/hello.txt)"


SSL Error : Handshake Error 2

I am getting error in TLS handshake when I am using envoy as proxy to reach my service.
Service is running in a pod in a kubernetes cluster and envoy is deployed on master. I am reaching to service through NodePort.
Following are the logs for the handshake error:
^[[36mfront-envoy_1  |^[[0m [2019-03-11 11:38:57.547][14][debug][connection] [source/common/network/connection_impl.cc:653] [C1] connection in progress
^[[36mfront-envoy_1  |^[[0m [2019-03-11 11:38:57.547][14][debug][pool] [source/common/http/conn_pool_base.cc:20] queueing request due to no available connections
^[[36mfront-envoy_1  |^[[0m [2019-03-11 11:38:57.548][14][debug][connection] [source/common/network/connection_impl.cc:517] [C1] connected
^[[36mfront-envoy_1  |^[[0m [2019-03-11 11:38:57.548][14][debug][connection] [source/extensions/transport_sockets/tls/ssl_socket.cc:142] [C1] handshake error: 2
^[[36mfront-envoy_1  |^[[0m [2019-03-11 11:38:57.557][14][debug][connection] [source/extensions/transport_sockets/tls/ssl_socket.cc:142] [C1] handshake error: 2
^[[36mfront-envoy_1  |^[[0m [2019-03-11 11:38:57.557][14][debug][connection] [source/extensions/transport_sockets/tls/ssl_socket.cc:142] [C1] handshake error: 2
^[[36mfront-envoy_1  |^[[0m [2019-03-11 11:38:57.571][14][debug][connection] [source/extensions/transport_sockets/tls/ssl_socket.cc:142] [C1] handshake error: 2
^[[36mfront-envoy_1  |^[[0m [2019-03-11 11:38:57.571][14][debug][connection] [source/extensions/transport_sockets/tls/ssl_socket.cc:142] [C1] handshake error: 2
[[36mfront-envoy_1  |^[[0m [2019-03-11 11:38:57.572][14][debug][connection] [source/extensions/transport_sockets/tls/ssl_socket.cc:131] [C1] handshake complete
[36mfront-envoy_1  |^[[0m [2019-03-11 11:38:57.572][14][debug][client] [source/common/http/codec_client.cc:64] [C1] connected
^[[36mfront-envoy_1  |^[[0m [2019-03-11 11:38:57.572][14][debug][pool] [source/common/http/http1/conn_pool.cc:245] [C1] attaching to next request
^[[36mfront-envoy_1  |^[[0m [2019-03-11 11:38:57.572][14][debug][router] [source/common/router/router.cc:1165] [C0][S7238602018727543655] pool ready
^[[36mfront-envoy_1  |^[[0m [2019-03-11 11:38:57.572][14][debug][connection] [source/common/network/connection_impl.cc:502] [C1] remote close
^[[36mfront-envoy_1  |^[[0m [2019-03-11 11:38:57.572][14][debug][connection] [source/common/network/connection_impl.cc:183] [C1] closing socket: 0
^[[36mfront-envoy_1  |^[[0m [2019-03-11 11:38:57.572][14][debug][connection] [source/extensions/transport_sockets/tls/ssl_socket.cc:244] [C1] SSL shutdown: rc=1
Following is the YAML I am using to deploy envoy.
static_resources:
listeners:

address:
socket_address:
address: <IP_ADDRESS>
port_value: 443
filter_chains:

filters:

name: envoy.http_connection_manager
typed_config:
"@type": type.googleapis.com/envoy.config.filter.network.http_connection_manager.v2.HttpConnectionManager
codec_type: auto
stat_prefix: ingress_http
route_config:
name: local_route
virtual_hosts:

name: backend
domains:

"local"
routes:
match:
prefix: "/"
route:
cluster: httpbin_https
http_filters:

name: envoy.router
typed_config: {}
clusters:

name: httpbin_https
connect_timeout: 2.5s
type: static
lb_policy: round_robin
load_assignment:
cluster_name: httpbin_https
endpoints:

lb_endpoints:

endpoint:
address:
socket_address:
address: <IP_ADDRESS>
port_value: 31167
tls_context:
common_tls_context:
tls_certificates:
certificate_chain: { "filename":"/etc/clientcert.pem" }
private_key: { "filename": "/etc/clientprivatekey.pem" }
validation_context:
trusted_ca:
filename: /etc/servercert.crt
admin:
access_log_path: "/dev/null"
address:
socket_address:
address: <IP_ADDRESS>
port_value: 8001

I am trying to reach a service which is basically a server which accepts request after mutual TLS handshake with the curl.
The command I am using to reach my server is:
curl -vk http://<IP_ADDRESS>:443/headers -H "Host: local"
And docker-compose ps output is
front-proxy_front-envoy_1   /docker-entrypoint.sh /bin ...   Up      10000/tcp, <IP_ADDRESS>:443->443/tcp, <IP_ADDRESS>:8001->8001/tcp
I could not understand the error which I am getting in envoy logs. It is showing Handshake error and handshake complete. I am guessing that my service is not responding here but when I reach servive
directly with the curl command, it works perfectly fine. So is this the issue with envoy?
I am using https://www.learnenvoy.io/articles/on-your-laptop.html to deploy envoy.

See if this is a duplicate of https://github.com/envoyproxy/envoy/issues/5683.

@ipuustin Looks similar but there are some doubts.

If I comment validation context , still the handshake passes after few handshake errors with 2 , see below :
tls_context:
common_tls_context:
tls_certificates:
certificate_chain: { "filename":"/etc/clientcert.pem" }
private_key: { "filename": "/etc/clientprivatekey.pem" }
# validation_context:
#  trusted_ca:
#   filename: /etc/servercert.crt
Wireshark trace does not show certificate exchange :
With curl (no envoy in path) we see the following SSL handshake logs :

TLSv1.2 (OUT), TLS handshake, Client hello (1):
TLSv1.2 (IN), TLS handshake, Server hello (2):
TLSv1.2 (IN), TLS handshake, Certificate (11):
TLSv1.2 (IN), TLS handshake, Server key exchange (12):
TLSv1.2 (IN), TLS handshake, Request CERT (13):
TLSv1.2 (IN), TLS handshake, Server finished (14):
TLSv1.2 (OUT), TLS handshake, Certificate (11):
TLSv1.2 (OUT), TLS handshake, Client key exchange (16):
TLSv1.2 (OUT), TLS handshake, CERT verify (15):
TLSv1.2 (OUT), TLS change cipher, Client hello (1):
TLSv1.2 (OUT), TLS handshake, Finished (20):
TLSv1.2 (IN), TLS handshake, Finished (20):

With Envoy, I see only following messages in handshake in wireshark
* Client hello ->
* Server Hello <-
* Change Cipher Spec <-
* Encrypted handshale message <-
* Change Cipher Spec ->
* Encrypted handshale message ->
* Application Data ->
* Encrypted Alert <-
* Encrypted Alert ->
* FIN  packet <- (Connection tear down)
Logs :
^[[36mfront-envoy_1  |^[[0m [2019-03-12 05:31:05.877][13][debug][pool] [source/common/http/conn_pool_base.cc:20] queueing request due to no available connections
^[[36mfront-envoy_1  |^[[0m [2019-03-12 05:31:05.877][13][debug][http] [source/common/http/conn_manager_impl.cc:1025] [C2][S4133372670968259647] request end stream
^[[36mfront-envoy_1  |^[[0m [2019-03-12 05:31:05.877][13][debug][connection] [source/common/network/connection_impl.cc:517] [C3] connected
^[[36mfront-envoy_1  |^[[0m [2019-03-12 05:31:05.877][13][debug][connection] [source/extensions/transport_sockets/tls/ssl_socket.cc:138] [C3] handshake error: 2
^[[36mfront-envoy_1  |^[[0m [2019-03-12 05:31:05.879][13][debug][connection] [source/extensions/transport_sockets/tls/ssl_socket.cc:138] [C3] handshake error: 2
^[[36mfront-envoy_1  |^[[0m [2019-03-12 05:31:05.879][13][debug][connection] [source/extensions/transport_sockets/tls/ssl_socket.cc:138] [C3] handshake error: 2
^[[36mfront-envoy_1  |^[[0m [2019-03-12 05:31:05.880][13][debug][connection] [source/extensions/transport_sockets/tls/ssl_socket.cc:138] [C3] handshake error: 2
^[[36mfront-envoy_1  |^[[0m [2019-03-12 05:31:05.880][13][debug][connection] [source/extensions/transport_sockets/tls/ssl_socket.cc:138] [C3] handshake error: 2
^[[36mfront-envoy_1  |^[[0m [2019-03-12 05:31:05.880][13][debug][connection] [source/extensions/transport_sockets/tls/ssl_socket.cc:127] [C3] handshake complete
^[[36mfront-envoy_1  |^[[0m [2019-03-12 05:31:05.880][13][debug][client] [source/common/http/codec_client.cc:64] [C3] connected
^[[36mfront-envoy_1  |^[[0m [2019-03-12 05:31:05.880][13][debug][pool] [source/common/http/http2/conn_pool.cc:95] [C3] creating stream
^[[36mfront-envoy_1  |^[[0m [2019-03-12 05:31:05.880][13][debug][router] [source/common/router/router.cc:1132] [C2][S4133372670968259647] pool ready
^[[36mfront-envoy_1  |^[[0m [2019-03-12 05:31:05.881][13][debug][connection] [source/common/network/connection_impl.cc:502] [C3] remote close
^[[36mfront-envoy_1  |^[[0m [2019-03-12 05:31:05.881][13][debug][connection] [source/common/network/connection_impl.cc:183] [C3] closing socket: 0
^[[36mfront-envoy_1  |^[[0m [2019-03-12 05:31:05.881][13][debug][connection] [source/extensions/transport_sockets/tls/ssl_socket.cc:236] [C3] SSL shutdown: rc=1
^[[36mfront-envoy_1  |^[[0m [2019-03-12 05:31:05.881][13][debug][client] [source/common/http/codec_client.cc:82] [C3] disconnect. resetting 1 pending requests
^[[36mfront-envoy_1  |^[[0m [2019-03-12 05:31:05.881][13][debug][client] [source/common/http/codec_client.cc:105] [C3] request reset
^[[36mfront-envoy_1  |^[[0m [2019-03-12 05:31:05.881][13][debug][pool] [source/common/http/http2/conn_pool.cc:234] [C3] destroying stream: 0 remaining
^[[36mfront-envoy_1  |^[[0m [2019-03-12 05:31:05.881][13][debug][router] [source/common/router/router.cc:539] [C2][S4133372670968259647] upstream reset: reset reason connection termination
Wanted to understand why certificate exchange not happening here , and how come ssl handshake is completing without validation context.
Is it possible that in this case mutual TLS not happening , one side TLS only taking place ?

Are you passing a client certificate with your curl command? It appears that your initial curl command did not specify one. In this case, mutual TLS would fail the handshake.


Guidebook quality-of-life improvements

Two suggestions for the guidebook to make it a bit more convenient to use:

When returning to the list of blocks/items/whatever after reading an individual entry, you should end up back on the page you were on instead of on page 1 all the time.
When hovering over a block/item/whatever in the list, you should get a preview of its entry's text.

1 => There is a back button in the top left, it should take you just up one page.

That would be a great feature.  However this guide book is actually made by a different API mod, similar to forge or JEI.  In Cyclic i basically compile a list of categories and items and text, and give it to the book and the book shows up.  So for a feature like this it would have to be added by that mod:  https://minecraft.curseforge.com/projects/guide-api

There is a search feature if you press back enough times
I have control over categories and content.  I can add recipes, text, and custom images.
3> off topic but going over the book while checking this out, i do notice some little things.
3a: blocks do not have recipes, but items do.
3b: some categories are too big, others do not really make sense, more categories might be better
3c maybe alphebetize the order ?

The back button doesn't seem to work like that for me. For example, if I go to Fire Slayer from page 3 of Items, when I hit Back, I end up on page 1 of Items.
Okay, I'll open an issue with Guide-API for that.
3a. Meh, JEI is a must-have anyway.
3b. Agreed.
3c. Agreed.

Looks like i forgot to close this so i will now.  For anyone reading in the future go here https://github.com/TeamAmeriFrance/Guide-API/issues


fake updates and other weirdness after releasing older image

We recently encountered a bug in one of our services, with version A of one of its two images, and re-released an earlier version B. Now whenever an image for another service is released, the git commit additionally mentions an update from B to A
Release quay.io/weaveworks/logging:master-ae8afaa, quay.io/weaveworks/ui-server:master-6024fa2 to automated

even though the contents of the commit make no such change, i.e. in this example actually only the ui-server image is updated.
The slack notification is wrong too:

A related issue is that it is not clear why flux is not changing the image to the latest version again - a good thing in this case, but still mysterious. The UI for the service looks like this:

Note that the service is automated and unlocked, and has no tag filters. To me that means flux should always be releasing the latest version. Yet the "Update" button is greyed out, and the logging image is clearly shown as not being at the latest version.

I suspect that it's calculating that it needs to update those images, then failing to apply the change to logging. But because it succeeds at changing something, there's a diff to commit, so it proceeds.
The surprising bit is that it silently fails to make the update to the logging image. It should either make the change, or bail out.


Update the FAQ and add doc on versioning

Contributor Checklist

[NA] Did you add Scaladoc to every public function/method?
[NA] Did you add at least one test demonstrating the PR?
[NA] Did you delete any extraneous printlns/debugging code?
[x] Did you specify the type of improvement?
[x] Did you add appropriate documentation in docs/src?
[x] Did you state the API impact?
[x] Did you specify the code generation impact?
[x] Did you request a desired merge strategy?
[x] Did you add text to be included in the Release Notes for this change?

Type of Improvement

documentation

API Impact
No impact
Backend Code Generation Impact
No impact
Desired Merge Strategy

Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

[ ] Did you add the appropriate labels?
[ ] Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.0, 3.5.0) ?
[ ] Did you review?
[ ] Did you check whether all relevant Contributor checkboxes have been checked?
[ ] Did you mark as Please Merge?

Nice! I have only looked at the raw view but content is good. Haven't checked how the table looks rendered

realized in all my refactoring I didn't actually fix https://github.com/freechipsproject/www.chisel-lang.org/issues/102 ... now this does. 🤦♀

Nice! I have only looked at the raw view but content is good. Haven't checked how the table looks rendered

You can view it in the diff: https://github.com/chipsalliance/chisel3/pull/1827/files?short_path=6959c6b#diff-6959c6be40448c233181770b98e858bacebc4a359abc27d6d06526aaaa30f23b

I am happy to approve this but I don't actually know how to properly apply the labels and such


Scaling the project further

updated contributing guidelines
added more useful comments
updated/added configurations
fixes #87, #113
Adding myself as a codeowner (this can be changed/added to later)
moving files to .github for cleaner directory
fixes build
updates brand page
fixes build loader by updating babel-loader

✅ By submitting this PR, I have verified the following

[x] Checked to see if a similar PR has already been opened 🤔
[x] Reviewed the contributing guidelines 🔍
[x] Added my name to the bottom of the list under the Credits section in the README.md with a link to my website or GitHub profile 👥

Will use admin privileges to merge this PR since it fixes failing build (dependencies not updated) and will help current and future contributors on-board better.
I will be responsible for following up on testing redirects are still working properly.


width and alignment of columns in DataTable

I have not found an easy way to adjust the column width and alignment in DataTable. Although I researched all the documentation and sources. It would be great to add classes with a key to the columns.

Thanks for your great work!
Svelte is awesome and Carbon too.

You'll need to apply your own custom CSS.
You can try targeting specific columns like so:
// target a column in the datatable head
:global(thead tr th:nth-child(2)) {
  min-width: 6rem;
}

// target a column in the datatable body
:global(tbody tr th:nth-child(2)) {
  min-width: 6rem;
}

Thanks!

How could we do this dynamically?


Using docker volume driver from rexray

Hello,
I'd use DC/OS rexray driver for persistent storage on zzure, but as I see rexray does not support the azure yet. I wonder, that if the docker can use azure with https://github.com/Azure/azurefile-dockervolumedriver it might happen that rexray can support docker volume driver, so the azure as well.
In this case, could you please help me how to use docker volume driver from rexray?
Thanks,
Tamas

@TamasSzerb Azure is not a supported platform within REX-Ray. libStorage is the main workhorse here and there is an issue here https://github.com/codedellemc/libstorage/issues/198.  There has been some talk of Microsoft wanting to write the driver for libStorage but I can't comment on its status.
Please close the issue if this answers your question.


'Booster' object has no attribute 'booster'

Having an issue with a loaded model from a pickle file.  The following code was working before, but now it is going me the 'Booster' object has no attribute 'booster'
import pickle
import xgboost as xg
loaded_model = pickle.load(open("xgboost-model", "rb"))
xg.plot_importance(loaded_model)
Full stack trace below:
AttributeErrorTraceback (most recent call last)
 in ()
----> 1 xg.plot_importance(loaded_model)
/home/ec2-user/anaconda3/envs/python2/lib/python2.7/site-packages/xgboost/plotting.pyc in plot_importance(booster, ax, height, xlim, ylim, title, xlabel, ylabel, importance_type, max_num_features, grid, show_values, **kwargs)
66         importance = booster.get_booster().get_score(importance_type=importance_type)
67     elif isinstance(booster, Booster):
---> 68         importance = booster.get_score(importance_type=importance_type)
69     elif isinstance(booster, dict):
70         importance = booster
/home/ec2-user/anaconda3/envs/python2/lib/python2.7/site-packages/xgboost/core.pyc in get_score(self, fmap, importance_type)
1433         """
1434
-> 1435         if self.booster != 'gbtree':
1436             raise ValueError('Feature importance is not defined for Booster type {}'
1437                              .format(self.booster))
AttributeError: 'Booster' object has no attribute 'booster'

Did you generate the pickle file in a previous version?

#3894 should fix the issue.

Hello,
Issue still persists!

@githubhnw Please use the latest master.

@hcho3 Sorry, I'm using conda_python3 kernel, python 3.6 and latest git clone for xgboost and this error persists. What were you refering at when you commented "Did you generate the pickle file in a previous version?"? Thanks

Can you post the error message?

Yes. So, I'm downloading a model artifact of XgBoost Sagemaker with extension 'tar.gz' from S3 storage in Jupyter local and use the code below to open local file and unpack it :
import tarfile
import joblib
import xgboost as xgb
Unpack model file
tar = tarfile.open("model.tar.gz", "r:gz")
for member in tar.getmembers():
f = tar.extractfile(member)
if f is not None:
content = f.read()
tar.extractall()
fil = open('xgboost-model', 'rb')
Load model file back into generate predictions & view feature importance
xgb_local_model = joblib.load(fil)
Close
fil.close()
And then, I try to see feature importance :
fig, ax = plt.subplots(figsize=(6,6))
max_num_features is 78: 26 signals and for each a roll avg for 7 and 14 days
xgb.plot_importance(xgb_local_model, height=0.8, importance_type='weight', max_num_features=78, show_values = False, ax=ax)
plt.title('XGBoost with roll avgs -  Model Feature Importance')
plt.show()
The error is :

Thanks

@githubhnw Submitted #3944 to add the missing change.

Hi @dping1, did you ever get this working? I'm also using XGBoost on Sagemaker, trying to get out feature importances.
Sagemaker, afaik, is running XGBoost 0.72. I'm guessing we'll just have to wait until Amazon adopts a future release with this fix in it?


Serialization: some formats or no formats at all?

/chair hat on
The conversation that started from https://lists.w3.org/Archives/Public/public-webid/2024Feb/0005.html, which I'll generally refer to as Martynas's proposal (@namedgraph) for dropping any kind of MUST on serialization formats following the principle of orthogonality, indicates that there's significant interest towards this approach.
As chair, I need to:

Understand how much consensus there is around this proposal.
Compare the consensus with the MUST on JSON-LD and Turtle for publishers, which is currently the option with the largest consensus when it comes to serialization formats.
Foster technical discussion around these two proposals so that each "side" understands the other and each one of us gets to have a chance at changing their mind or further solidify their position.
Give everyone enough time to make their case, particularly to those that struggle to follow the conversation due to the volume of notifications and discussion threads that this group can produce.

To this end, I kindly ask you to share, in this issue, which of the two you believe to be the best way forward and to ground your view in technical arguments and examples. Some of you have already done this elsewhere, in which case I would kindly ask you to copy/paste here (and add as much as you want to it).
Limited to this issue I'm going to try something new and be rather ruthless as to how I manage the conversation. At least initially, I need each one of you to only comment once and to make your case independently of others. Do not respond to others, just make your case in one, single comment. I will stop moderating (hiding / deleting) comments that do not follow this rule once reasonably sure that everyone will have had the chance to put their argument forward. Let's say... Two weeks. I will stop moderating comments in two weeks from now, on 2024-02-23.
Unorthodox approach, for sure, but I can clearly see this specific conversation spiraling out of control in no time at all.

rather ruthless ... Unorthodox approach ... Do not respond to others

I appreciate the structured approach you’re proposing to navigate the discussions surrounding Martynas's proposal and the existing consensus on serialization formats. It's clear that managing a balanced and focused conversation in such a vibrant community presents significant challenges.
However, I'm concerned that the suggested method, particularly the limitation on discussion and the moderation strategy, might inadvertently stifle the open exchange of ideas that is fundamental to the W3C's ethos. By restricting participants to a single comment without the opportunity for interaction, we risk overlooking the dynamic nature of consensus-building, where understanding evolves through dialogue.
While I understand the intention behind this approach is to maintain order and clarity, it feels somewhat at odds with the principle of fostering an inclusive and comprehensive debate. The approach, as outlined, might inadvertently act as a form of hard forking the project, that has been stable for many years, by curtailing the discussion, potentially leading to decisions that don't fully reflect the community's collective wisdom.
I respectfully suggest reconsidering this strategy in favor of one that allows for more fluid interaction, ensuring all voices are heard and considered more organically. Perhaps a compromise could be found that still addresses the concerns of discussion manageability without significantly constraining dialogue.
Thank you for considering this perspective.

IMO the WebID spec should be orthogonal to what RDF serialization is used.
The initial HTML spec writers could have required images to be either JPG or BMP for making it easier for browser implementers to handle and render images, but this would have inhibited innovations such as PNG and WebP.
Similarly should WebID not enforce JSON-LD or Turtle.

From a testing standpoint I can't see any difference. I do think we'll have to craft a "WebID Validator", at some point, but such a tool can support as many formats as we want it to.

Yes!
We (LOD Community) had to deal with the same issue regarding the Linked Open Data (LOD) Cloud and the requirements for Linked Data Principles adherence, which lead to the Vapour Validator.
A similar tool would be needed for validating:

WebID (an HTTP URI that names an Agent unambiguously) by performing HTTP URI de-reference and lookup of the a term (or terms) that infers a foaf:Agent instance

WebID-TLS Authentication Protocol

Other WebID-{whatever} Protocols, as they emerge

So I need to go with dropping any media type requirements :) I vote for removing mentions of any specific media types and following the W3C specification orthogonality principle.

I favor "dropping any kind of MUST on serialization formats following the principle of orthogonality" over "MUST on JSON-LD and Turtle for publishers".
I see no need for WebID spec need to guarantee interoperability - that is a feature for extension protocols like WebID-TLS and Solid OIDC to (optionally!) provide.

Today, I'm OK with mandating "an RDF document", because today there are libraries which can be incorporated into client and server software with relative ease, which libraries did not exist in 2014. Interop in 2014 required mandate of lowest common denominator serialization, that being Turtle. Interop today can be achieved by generically mandating any serialization of RDF, which both client and server software can translate to any other RDF serialization (or graph store) they may prefer.

The initial HTML spec writers could have required images to be either JPG or BMP for making it easier for browser implementers to handle and render images, but this would have inhibited innovations such as PNG and WebP.
Similarly should WebID not enforce JSON-LD or Turtle.

I think it important to note that HTML has always mandated browsers to "fail elegantly" when encountering media types and HTML tags that are unfamiliar or entirely not understood -- so unknown image formats might be downloaded to the browser's host filesystem, or unknown image formats might be displayed as a generic "image" icon in the rendered web page, among other options, to await for further action by the user (e.g., opening the downloaded file with a dedicated image processor that understands more formats than the browser).
Note that this elegant failure of HTML relies, at some point, on human action.
In contrast to HTML, WebID Profile Documents have always been intended to be machine-processable, optimally in addition to being human-processable. Circa 2014, there was insufficient software to provide interoperable machine processability across many, if not most, if not all, possible RDF serializations. Circa 2023, things have changed, and RDF serialization translation can generally be assumed (though it is still not guaranteed), so it seems viable to me to go with —

WebID Profile Documents MUST be RDF-based
WebID Profile Documents SHOULD be made available at least as Turtle and JSON-LD when these are requested by a consumer via Accept: header
WebID Profile Documents SHOULD additionally be made available in any other RDF serialization requested by a consumer via Accept: header
WebID Profile Documents MAY additionally be made available in any other RDF serialization requested by a consumer via Accept: header

Correct!
A spec of this kind is simply supposed to provide guidance which can be embellished via examples. Anyway, at this juncture, I continue to encourage @jacoscaz to organize a vote to determine consensus.
Ultimately, I sense we can only compromise to move forward, which I will live with -- if need be.

WebID Profile Documents MUST be RDF-based

WebID Profile Documents SHOULD be made available at least as Turtle and JSON-LD when these are requested by a consumer via Accept: header

WebID Profile Documents SHOULD additionally be made available in any other RDF serialization requested by a consumer via Accept: header

WebID Profile Documents MAY additionally be made available in any other RDF serialization requested by a consumer via Accept: header

Yes, each of those items being only loosely associated with an HTTP URI that names an Agent, unambiguously (i.e., "a WebID").
Others:
It is very important to understand (and accept) that "RDF" is a Data Definition Language that's loosely associated with expression notations, data serialization formats, and concrete syntaxes.
We MUST get away from the legacy problem of conflating RDF and anyone of the aforementioned which has been an issue since its incepetion -- exemplified by its unfortunate tight coupling with RDF/XML

vote for removing mentions of any specific media types and following the W3C specification orthogonality principle.

Your intentions are clear, but I encourage letting @jacoscaz organize a formal vote :)

/chair hat on
I will comment off-topic and then auto-hide my own comment: @kidehen a vote might not even be necessary, let's see how this goes. I want more people to chime in before moving forward. But yeah, if we can't find manage to find common ground with this I'm going to call for a formal vote.

WebID Profile Documents MUST be RDF-based
WebID Profile Documents SHOULD be made available at least as Turtle and JSON-LD when these are requested by a consumer via Accept: header
WebID Profile Documents SHOULD additionally be made available in any other RDF serialization requested by a consumer via Accept: header
WebID Profile Documents MAY additionally be made available in any other RDF serialization requested by a consumer via Accept: header

@TallTed would you be comfortable with moving forward in two separate steps, first dropping all kinds of requirements (both MUST, SHOULD and MAY) on formats and then discussing and introducing optional requirements (SHOULD and MAY) in separate issues and PRs?

For the record, once again.
RDF specs shouldn't be hardwired to any notation, serialization format, or concrete syntax.
We will always support not having MUST applied to any notation, serialization format, or concrete syntax to the WebID Identity and Discovery Specification.

Honestly I'm confused by OpenLink's position.
First @kidehen seems to support my proposal:

We will always support not having MUST applied to any notation, serialization format, or concrete syntax

Then just a few comments later @TallTed writes:

I think this is an argument for the one mandated format to be (to remain) Turtle

Aren't these the opposite suggestions? Which is it?

@namedgraph — I have not been speaking here as or for OpenLink. I have been and will continue speaking for and as myself, unless I say otherwise. This is the way most if not all people operate in most if not all of the W3C groups in which I participate.

/chair hat on
As established in the opening comment, strict moderation stops today and this issue is now open to normal discussion and debate, though there's a few people whose feedback is still pending (I hope).
After spending a lot of time going through the comments in this thread, the ones in #3 , multiple threads of conversations on the mailing list and half a dozen private conversations with some of you, my preliminary conclusion is that the best way forward is to weaken the current MUST on Turtle into a SHOULD on Turtle:

WebID Profile Documents MUST be RDF-based.
WebID Profile Documents SHOULD be made available at least as Turtle when this format is requested by a consumer via the Accept: header.

As for the rationale behind this:

The largest consensus that I can see lies with dropping all requirements (as in MUST) on serialization formats, favoring orthogonality. This is even larger than it may come across as a few members actually favor this option in the long term while preferring a more conservative stance in the short term due to interoperability concerns.
The second largest consensus that I can see lies with one MUST if requested via the Accept: header, doesn't really matter which format, favoring interoperability. This is also informed by the view that most users and developers will interact with WebID parsing and serialization only indirectly.
While a breaking change is needed, this is arguably the least breaking change that can be made while still opening up the spec to JSON-LD and, indeed, any other format.
In addition to point 3., Turtle is arguably the least complex and onerous format to support from a technical standpoint. If a soft requirement (SHOULD) must be made for interoperability, a simpler format increases the chances that implementations will actually stick to such requirement.

private conversations with some of you

IMHO, consensus should be exclusively built on transparent, public discussions to align with W3C's commitment to clear and open decision-making processes.  This becomes even more pertinent when we face contentious breaking changes and the prospect of hard forks.

Honestly I'm confused by OpenLink's position.
First @kidehen seems to support my proposal:

We will always support not having MUST applied to any notation, serialization format, or concrete syntax

Then just a few comments later @TallTed writes:

I think this is an argument for the one mandated format to be (to remain) Turtle

Aren't these the opposite suggestions? Which is it?

+1
Due to the chair censoring this thread, I was unable to upvote the comments of @namedgraph
Please turn off the censorship, to allow reactions.

/chair hat on

consensus should be exclusively built on transparent, public discussions

@melvincarvalho and all,
Agreed! Which is why #66 favors orthogonality / neutrality over interoperability.
Nonetheless, as I've explained in https://lists.w3.org/Archives/Public/public-webid/2024Feb/0067.html , some of the dynamics in this group tend to push interested and invested parties away, discouraging participation. It is imperative that I, as chair, work to counteract the group's tendency towards insularity or WebID will become irrelevant. To that end, I maintain private conversations with those who do not believe participating in this group to be a productive endeavor, hoping that the group as a whole can and will prove them wrong.
Just as an example, @rubensworks has recently pointed this out in https://lists.w3.org/Archives/Public/public-webid/2024Feb/0047.html , with @kidehen rightfully suggesting to reassess consensus shortly thereafter in https://lists.w3.org/Archives/Public/public-webid/2024Feb/0052.html in light of the growing participation from other voices . In turn, this got me to create this very issue, from which #66 was born.


(main) Update 'Running with Spring Boot' docs

Kind of change

[ ] Bug fix
[ ] New non-breaking feature
[ ] New breaking feature
[x] Documentation update
[ ] Build improvement

Description
What is the goal of this pull request?
Update and improve Spring Boot integration docs.

Fixed broken links to SB docs

Added details about the need to handle transitive dependencies

Update integration test to latest SB version 3.3.4

How does it achieve that?*

Fixes broken links and adds clarification on transitive dependencies.

Are there any implications of this pull request? Anything a user must know?*
no

Issue
Fixes #1286
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc
No need for this, the changes will go live with docs, not a release.

Thank you! 👍


[WIP] Envoy API support for tweaking connections limits

Add support for max_requests_per_connection and circuit_breakers and
replacing ffjson by encoding/json for debugging purpose.
[work in progress]
TODO:

[ ] Complete & Clean code and figure out how to expose parameters? Probably like the rest, using Docker Labels
[ ] Add ffjson back, etc..
[ ] Add tests to cover new JSON parameters

Closing this due to inactivity


Support type hinting *args and **kwargs

Fixes #26.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 94.509%

Totals

Change from base Build<PHONE_NUMBER>5:
-0.02%

Covered Lines:
654

Relevant Lines:
692

💛  - Coveralls


An error "timeout after 1000 ms" occurs after executing stop debugging for a PowerShell project

OS: Mac
Build Version: 20200603.1
Repro Steps:

Create a PowerShell project with HttpTrigger function.
Debug it and then stop debugging when hitting to an unset breakpoint.
Check the result.

Expect:
Stop debugging successfully without any error.
Actual:
An error "timeout after 1000 ms" occurs after executing stop debugging.

More info:
This issue does not reproduce for C#/JavaScript/TypeScript/Python projects.

@v-ruizh does this only repro on Mac? Also - does this happen consistently?

i get the same notification under windows, i think it comes from here:

it happens when stopping a debug session (remote ssh, gdb via ms-vscode.cpptools v0.28.3)
it doesnt always happen, only when the server is a bit slow
Version: 1.46.0 (system setup)
Commit: a5d1cc28bb5da32ec67e86cc50f84c67cc690321
Date: 2020-06-10T09:03:20.462Z
Electron: 7.3.1
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.19041

@EricJizbaMSFT This issue also reproduces on Windows, we can reproduce it consistently.

Same here! Windows 10.

Same for me when I restart a Node project

Same here.  It started happening for me in just the past few weeks.  On Windows with a nodejs project.

Found a few issues indicating this is an upstream issue in VS Code:
https://github.com/microsoft/vscode/issues/97013
https://github.com/microsoft/vscode/issues/103105

+1 This started for me about 3 weeks ago.

Fyi we pushed a fix for this in VS Code.
More details here https://github.com/microsoft/vscode/issues/103105#issuecomment-672016137

I get the same error!

@meteorsh the fix should be in VS Code Insiders https://code.visualstudio.com/insiders/

I tried removing .cpuprofile files from Temp and it worked fine for quite a bit but gets stuck every few days .

I tried removing .cpuprofile files from Temp and it worked fine for quite a bit but gets stuck every few days .

@nikimullick could you please share the full path to that temp folder? it's macOS?

No idea about macOS
On Tue, Aug 25, 2020, 9:19 PM Stukz<EMAIL_ADDRESS>wrote:

I tried removing .cpuprofile files from Temp and it worked fine for quite
a bit but gets stuck every few days .
@nikimullick https://github.com/nikimullick could you please share the
full path to that temp folder? it's macOS?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode-azurefunctions/issues/2143#issuecomment-680109179,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAD6LERTIXQMX7JD23M6NDSCPMPTANCNFSM4NSMY6SA
.

Seems like we did not fix it properly in vs code after all. Let me investigate more on our side.

Same problem when restart debugging (shift+ctrl+F5). Early all was fine,
(django project debugging)


UnicodeEncodeError with mne.io.show_fiff

mne.io.show_fiff cannot handle non-ascii characters in tags. In this case it was the researcher's name (pos 224) that caused the exception: u'Santtu Seip\xe4j\xe4rvi (samaseip)'
Traceback (most recent call last):
subj_info = mne.io.show_fiff(self._info.get('filename'))
File "/home/zairex/anaconda2/envs/meggie-env/lib/python2.7/site-packages/mne/io/open.py", line 187, in show_fiff
read_limit=read_limit, max_str=max_str)
File "/home/zairex/anaconda2/envs/meggie-env/lib/python2.7/site-packages/mne/io/open.py", line 264, in _show_tree
out += _show_tree(fid, branch, indent, level + 1, read_limit, max_str)
File "/home/zairex/anaconda2/envs/meggie-env/lib/python2.7/site-packages/mne/io/open.py", line 264, in _show_tree
out += _show_tree(fid, branch, indent, level + 1, read_limit, max_str)
File "/home/zairex/anaconda2/envs/meggie-env/lib/python2.7/site-packages/mne/io/open.py", line 238, in _show_tree
postpend = ' = ' + str(tag.data)[:max_str]
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe4' in position 11: ordinal not in range(128)
I guess it is a normal convention to do "any object to str" -cast with str, but it has horrible consequences in Finland. To make concatenated string of objects this kind of approach would make a nice treat: u''.join([unicode(obj) for obj in objects_of_almost_any_kind]).encode('utf-8'). That is, replace every "str" with "unicode" and when there is a real need for encoding, then use .encode('utf-8'). Just a idea.. : ]
-- Tk

can you share a file so we can replicate and fix this?
thx

Sure!
https://www.dropbox.com/s/kpu6x10jtds5wnh/showfiff_breaks.fif?dl=0
-- Tk


Bump Dependencies #6148189317

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/6148189317

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jenkins-is-staging seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Test log output is no longer streamed as the test runs since CSAPI tests moved to tests/csapi (multiple packages in tests)

Before https://github.com/matrix-org/complement/pull/171 and the csapi package was added, I was able to run Complement tests and see the log output as it runs. But nowadays, all of the test log output is buffered and only printed when all of the tests finish.
This is caused by Go deciding to not stream log output when there are multiple packages present (we have tests and csapi in the ./tests/... directory):

https://github.com/golang/go/issues/46959
https://github.com/golang/go/issues/27826

Related:

Related https://dave.cheney.net/2020/03/10/go-test-v-streaming-output
Go added the streaming behavior in https://go-review.googlesource.com/c/go/+/127120

I liked the streaming behavior before to see the test progress but it's also important when I try to hook up Element to the homeserver and rooms from Complement to be able to see the log output of room ID's, etc to join and inspect, https://github.com/matrix-org/complement/blob/master/ONBOARDING.md#how-do-i-hook-up-a-matrix-client-like-element-to-the-homeservers-spun-up-by-complement-after-a-test-runs
As a workaround, I can get the log streaming behavior I want by being very selective about the files to run: go test -v -run TestImportHistoricalMessages ./tests/main_test.go ./tests/msc2716_test.go but this is manual process adjusting our generic Synapse test runner every time.
Potential solutions

Move all tests to the tests package.
Just wait for upstream Go changes although there is a possibility this won't change and just the documentation will be updated with this caveat
Run each test package in their own process to still get parallel but still get stream output
Can we run tests in parallel without separate packages? https://github.com/matrix-org/complement/pull/171

If you want streaming output, only specify a single package in go test - in other words don't use ... e.g:
go test -v -run TestOutboundFederationIgnoresMissingEventWithBadJSONForRoomVersion6 ./tests

This tip from @richvdh to change the parallelism works well,

Try sticking -p 1 on the complement.sh commandline.
-- @richvdh  https://github.com/matrix-org/synapse/issues/13204#issuecomment-1177695685

(relevant Go source code)


Update Go installation and add in parser files (#1582)

Updated Go installation and added in built parser files.
While the parser files can be built by the user, there may be instances where the user doesn't have the ability to do so. For the latter case, they have been added.
modified:   drivers/golang/go.mod
modified:   drivers/golang/go.sum

new file:   drivers/golang/parser/age_base_listener.go
new file:   drivers/golang/parser/age_base_visitor.go
new file:   drivers/golang/parser/age_lexer.go
new file:   drivers/golang/parser/age_listener.go
new file:   drivers/golang/parser/age_parser.go
new file:   drivers/golang/parser/age_visitor.go

This addresses issue #1455

Looks good~


Feature: API Documentation and Examples

Yea that stuff no one wants to do. Some "Quick Start" examples are usually better than docs. But docs would be good aswell, maybe autogenerate markdown docs and then a static website from thereon?

I guess I'll continue the conversation here. I was looking into XmlDocMarkdown which seems to be working fine except for the Extensions.Service and Json assemblies where I get
Could not load file or assembly 'Microsoft.Extensions.DependencyInjection.Abstractions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60'. The system cannot find the file specified.

Could not load file or assembly 'Rustic.Common, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'. The system cannot find the file specified.

respectively.
I've run clean builds a few times as well as added the dependencies manually (even though they are implicitly downloaded) but no progress so far. Have you come across this issue before by any chance?

There is no problem with the build. XmlDocMarkdown attempty to load a dll from the build directory. If you dotnet publish all referenced dlls should be included in the build directory. The tool doesnt seem to test the GAC or the nuget cache for assemblies

This can also be solved by specifying the target framework: dotnet publish -f:net60

I'm also wondering if you would mind using MkDocs Material instead of MdBook as MdBook needs you to explicitly specify all md files you want included unlike MkDocs which includes all files in the directory.
There are currently a little over 350 files so including them all in one file wouldn't look great.


IE11 Action Link, hover state Inverse background.

Problem
While reviewing this PR I noticed that the Hover State for Action Links on Inverse Background is missing on IE11.  This is a problem as users on IE11 are offered no indication there is a change resulting in an a11y issue.
https://components.publishing.service.gov.uk/component-guide/action_link/simple_light_arrow/preview
Solution
Update so these links on IE11 receive a colour change, grey seem to be in use for other white links on dark backgrounds.
Visuals (IE11)

Planning on pairing with our new FE on this next week as an intro to the components gem

I asked about this in the design system channel and got the following discussion:
Me:

Hey folks. I was having a look at inverted links and noticed that it doesn't include a colour change on hover. Is this intentional? It feels risky to me as this means that users on browser that don't support changes in line thickness (IE11 and below) won't receive any cue that they're hovering on a link.

Ollie Byford:

@christopher.thomas any thoughts? We discussed colour changes in https://github.com/alphagov/govuk-design-system/issues/1578 but only really focused on whether or not to keep the existing colour change for ‘standard links’. I’m sure we talked about inverse links, and it was a conscious choice to leave them without a colour change, but can’t remember the rationale…

Chris Thomas

From memory I feel like there was a problem with using opacity to lighten them as opposed to a specified colour? So we couldn’t make an inverse link hover colour that would work across all kinds of different backgrounds? Not 100% on this though, I might have to do more digging. I think on the IE11 thing we were satisfied that the pointer cursor was enough of an indicator even if not as clear as the proper hover state

Me

I seeeeeee. Cheers both. Being frank, I have opinions about the inconsistency this creates but I ain't no design systemer.
Couple of follow ups:
Do we have any data on if user's are ok with the cursor as the sole indicator?
How do you feel about a given team adding a custom colour change for their product/service?

Max Harden

2 feels like a bad idea to me, Owen. Fragments things, more stuff to get forgotten/in the way of updates, brittle if the underlying code changes.

Ollie Byford

So, it’s pretty hard to get any hard data around this kind of thing. Even in user research, all you can really evaluate is whether the users you’re doing research with manage to use the thing OK. I would note that the ‘text-colored’ links (like breadcrumbs, back links) have never had any sort of hover state before, and inverse links generally haven’t either. So we have definitely been seeing the text underline change as an enhancement. Also worth noting that there are plenty of other interactive elements that have no hover state at all (like checkboxes and radios) where the only change is the cursor.

I’m sure we talked about inverse links, and it was a conscious choice to leave them without a colour change, but can’t remember the rationale…

From memory I feel like there was a problem with using opacity to lighten them as opposed to a specified colour? So we couldn’t make an inverse link hover colour that would work across all kinds of different backgrounds? Not 100% on this though, I might have to do more digging.

I think on the IE11 thing we were satisfied that the pointer cursor was enough of an indicator even if not as clear as the proper hover state

At this stage, I still think this is worth resolving to align consistency and as IE11 is still on the service manual.

Revisiting this, this issue may become redundant quite soon as the new homepage design Explore are working on will be removing this section outright. See https://github.com/alphagov/frontend/pull/3028

Homepage redesign is live - closing issue


Updates Zulip dev setup for first-time contributors

Updates Zulip dev setup for first-time contributors as follows:

Recommends and links to Vagrant version 1.8.4 (from 1.8.1)
Consolidates Ubuntu 14.04 and Ubuntu 16.04 instructions since they are
now identical.
Updates memory requirement to 2GB to address out of memory related
errors (see issue #1333).

Fixes #1288.

Automated message from Dropbox CLA bot
@christi3k, it looks like you've already signed the Dropbox CLA. Thanks!

Should also change vb.memory = 1280 in Vagrantfile

I added that and merged this.  Thanks @christi3k!


Support non-uuid ids (integer ids, especially)

Allow using integer autoincrement ids, like most SQL databases prefer.
Right now a bit of monkey patching around a handler as said (on #320 and #259 ) can help us with this, but it isn't fully supporting GraphQL. (Validations fail, searches fail).

@championswimmer: I'm willing to merge #320 if we add some test coverage to it.

Can we close this now that #320 has been merged @championswimmer?


grammar fix

Current coverage is 76.55% (diff: 100%)

Merging #3030 into master will decrease coverage by 0.01%

@@             master      #3030   diff @@
==========================================
  Files           428        428
  Lines         21891      21891
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits          16760      16757     -3
- Misses         5131       5134     +3
  Partials          0          0

Powered by Codecov. Last update f5fdfa7...d03e66b