Update ibex_demo_system.core

Fix for Verilator 5.x
Output from sample hello_world
./build/lowrisc_ibex_demo_system_0/sim-verilator/Vtop_verilator \
  --meminit=ram,./sw/c/build/demo/hello_world/demo
Simulation of Ibex Demo System
==============================

Tracing can be toggled by sending SIGUSR1 to this process:
$ kill -USR1 421326

UART: Created /dev/pts/3 for uart0. Connect to it with any terminal program, e.g.
$ screen /dev/pts/3
UART: Additionally writing all UART output to 'uart0.log'.

Simulation running, end by pressing CTRL-c.
^CReceived stop request, shutting down simulation.

Simulation statistics
=====================
Executed cycles:  57408461
Wallclock time:   39.825 s
Simulation speed: 1.44152e+06 cycles/s (1441.52 kHz)

Performance Counters
====================
Cycles:                     69899
Instructions Retired:       39498
LSU Busy:                   17890
Fetch Wait:                 2982
Loads:                      10981
Stores:                     6909
Jumps:                      3367
Conditional Branches:       2395
Taken Conditional Branches: 1258

Sure. Here's the command I used:
fusesoc --cores-root=. run --target=sim --tool=verilator --setup --build lowrisc:ibex:demo_system

and the error log:
ERROR: In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system.h:5,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system_main.cc:5:
/usr/local/share/verilator/include/verilatedos.h:265:3: error: #error "Verilator requires a C++14 or newer compiler"
  265 | # error "Verilator requires a C++14 or newer compiler"
      |   ^~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.cc:5:
/usr/local/share/verilator/include/verilatedos.h:265:3: error: #error "Verilator requires a C++14 or newer compiler"
  265 | # error "Verilator requires a C++14 or newer compiler"
      |   ^~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from Vtop_verilator__pch.h:21:
/usr/local/share/verilator/include/verilatedos.h:265:3: error: #error "Verilator requires a C++14 or newer compiler"
  265 | # error "Verilator requires a C++14 or newer compiler"
      |   ^~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilator_sim_ctrl.h:13,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilator_sim_ctrl.cc:5:
/usr/local/share/verilator/include/verilatedos.h:265:3: error: #error "Verilator requires a C++14 or newer compiler"
  265 | # error "Verilator requires a C++14 or newer compiler"
      |   ^~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from ./Vtop_verilator__Syms.h:10,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system.cc:9:
/usr/local/share/verilator/include/verilatedos.h:265:3: error: #error "Verilator requires a C++14 or newer compiler"
  265 | # error "Verilator requires a C++14 or newer compiler"
      |   ^~~~~
In file included from /usr/local/share/verilator/include/verilated_threads.cpp:24:
/usr/local/share/verilator/include/verilatedos.h:265:3: error: #error "Verilator requires a C++14 or newer compiler"
  265 | # error "Verilator requires a C++14 or newer compiler"
      |   ^~~~~
In file included from /usr/local/share/verilator/include/verilated_dpi.cpp:30:
/usr/local/share/verilator/include/verilatedos.h:265:3: error: #error "Verilator requires a C++14 or newer compiler"
  265 | # error "Verilator requires a C++14 or newer compiler"
      |   ^~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from /usr/local/share/verilator/include/verilated_fst_c.cpp:26:
/usr/local/share/verilator/include/verilatedos.h:265:3: error: #error "Verilator requires a C++14 or newer compiler"
  265 | # error "Verilator requires a C++14 or newer compiler"
      |   ^~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from Vtop_verilator__pch.h:21:
/usr/local/share/verilator/include/verilatedos.h:265:3: error: #error "Verilator requires a C++14 or newer compiler"
  265 | # error "Verilator requires a C++14 or newer compiler"
      |   ^~~~~
In file included from /usr/local/share/verilator/include/verilated.cpp:51:
/usr/local/share/verilator/include/verilatedos.h:265:3: error: #error "Verilator requires a C++14 or newer compiler"
  265 | # error "Verilator requires a C++14 or newer compiler"
      |   ^~~~~
In file included from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.cc:5:
/usr/local/share/verilator/include/verilated.h:76:22: error: ‘literals’ is not a namespace-name
   76 | using namespace std::literals;  // "<std::string literal>"s; see SF.7 core guideline
      |                      ^~~~~~~~
In file included from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilator_sim_ctrl.h:13,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilator_sim_ctrl.cc:5:
/usr/local/share/verilator/include/verilated.h:76:22: error: ‘literals’ is not a namespace-name
   76 | using namespace std::literals;  // "<std::string literal>"s; see SF.7 core guideline
      |                      ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.cc:5:
/usr/local/share/verilator/include/verilated_types.h: In function ‘std::string VL_TO_STRING(const VlEvent&)’:
/usr/local/share/verilator/include/verilated_types.h:266:12: error: unable to find string literal operator ‘operator""s’ with ‘const char [11]’, ‘long unsigned int’ arguments
  266 |     return "triggered="s + (e.isTriggered() ? "true" : "false");
      |            ^~~~~~~~~~~~~
In file included from /usr/local/share/verilator/include/verilated_threads.h:28,
                 from /usr/local/share/verilator/include/verilated_threads.cpp:26:
/usr/local/share/verilator/include/verilated.h:76:22: error: ‘literals’ is not a namespace-name
   76 | using namespace std::literals;  // "<std::string literal>"s; see SF.7 core guideline
      |                      ^~~~~~~~
/usr/local/share/verilator/include/verilated_types.h: In function ‘std::string VL_TO_STRING(const VlEventBase&)’:
/usr/local/share/verilator/include/verilated_types.h:277:12: error: unable to find string literal operator ‘operator""s’ with ‘const char [11]’, ‘long unsigned int’ arguments
  277 |     return "triggered="s + (e.isTriggered() ? "true" : "false");
      |            ^~~~~~~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilator_sim_ctrl.h:13,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilator_sim_ctrl.cc:5:
/usr/local/share/verilator/include/verilated_types.h: In function ‘std::string VL_TO_STRING(const VlEvent&)’:
/usr/local/share/verilator/include/verilated_types.h:266:12: error: unable to find string literal operator ‘operator""s’ with ‘const char [11]’, ‘long unsigned int’ arguments
  266 |     return "triggered="s + (e.isTriggered() ? "true" : "false");
      |            ^~~~~~~~~~~~~
/usr/local/share/verilator/include/verilated_types.h: In function ‘std::string VL_TO_STRING(const VlEventBase&)’:
/usr/local/share/verilator/include/verilated_types.h:277:12: error: unable to find string literal operator ‘operator""s’ with ‘const char [11]’, ‘long unsigned int’ arguments
  277 |     return "triggered="s + (e.isTriggered() ? "true" : "false");
      |            ^~~~~~~~~~~~~
/usr/local/share/verilator/include/verilated_types.h: In constructor ‘VlClassRef<T_Class>::VlClassRef(VlClassRef<T_Class>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1651:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1651 |         : m_objp{std::exchange(moved.m_objp, nullptr)} {}
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.cc:5:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.cc:5:
/usr/local/share/verilator/include/verilated_types.h: In constructor ‘VlClassRef<T_Class>::VlClassRef(VlClassRef<T_OtherClass>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1661:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1661 |         : m_objp{std::exchange(moved.m_objp, nullptr)} {}
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.cc:5:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.cc:5:
/usr/local/share/verilator/include/verilated_types.h: In member function ‘VlClassRef<T_Class>& VlClassRef<T_Class>::operator=(VlClassRef<T_Class>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1676:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1676 |         m_objp = std::exchange(moved.m_objp, nullptr);
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.cc:5:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated_dpi.h:31,
                 from /usr/local/share/verilator/include/verilated_dpi.cpp:32:
/usr/local/share/verilator/include/verilated.h:76:22: error: ‘literals’ is not a namespace-name
   76 | using namespace std::literals;  // "<std::string literal>"s; see SF.7 core guideline
      |                      ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.cc:5:
/usr/local/share/verilator/include/verilated_types.h: In member function ‘VlClassRef<T_Class>& VlClassRef<T_Class>::operator=(VlClassRef<T_OtherClass>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1691:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1691 |         m_objp = std::exchange(moved.m_objp, nullptr);
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.cc:5:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
/usr/local/share/verilator/include/verilated_types.h: In constructor ‘VlClassRef<T_Class>::VlClassRef(VlClassRef<T_Class>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1651:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1651 |         : m_objp{std::exchange(moved.m_objp, nullptr)} {}
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilator_sim_ctrl.h:13,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilator_sim_ctrl.cc:5:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilator_sim_ctrl.h:13,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilator_sim_ctrl.cc:5:
/usr/local/share/verilator/include/verilated_types.h: In constructor ‘VlClassRef<T_Class>::VlClassRef(VlClassRef<T_OtherClass>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1661:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1661 |         : m_objp{std::exchange(moved.m_objp, nullptr)} {}
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilator_sim_ctrl.h:13,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilator_sim_ctrl.cc:5:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilator_sim_ctrl.h:13,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilator_sim_ctrl.cc:5:
/usr/local/share/verilator/include/verilated_types.h: In member function ‘VlClassRef<T_Class>& VlClassRef<T_Class>::operator=(VlClassRef<T_Class>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1676:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1676 |         m_objp = std::exchange(moved.m_objp, nullptr);
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilator_sim_ctrl.h:13,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilator_sim_ctrl.cc:5:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilator_sim_ctrl.h:13,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilator_sim_ctrl.cc:5:
/usr/local/share/verilator/include/verilated_types.h: In member function ‘VlClassRef<T_Class>& VlClassRef<T_Class>::operator=(VlClassRef<T_OtherClass>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1691:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1691 |         m_objp = std::exchange(moved.m_objp, nullptr);
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilator_sim_ctrl.h:13,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilator_sim_ctrl.cc:5:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from ./Vtop_verilator__Syms.h:10,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system.cc:9:
/usr/local/share/verilator/include/verilated.h:76:22: error: ‘literals’ is not a namespace-name
   76 | using namespace std::literals;  // "<std::string literal>"s; see SF.7 core guideline
      |                      ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from /usr/local/share/verilator/include/verilated_threads.h:28,
                 from /usr/local/share/verilator/include/verilated_threads.cpp:26:
/usr/local/share/verilator/include/verilated_types.h: In function ‘std::string VL_TO_STRING(const VlEvent&)’:
/usr/local/share/verilator/include/verilated_types.h:266:12: error: unable to find string literal operator ‘operator""s’ with ‘const char [11]’, ‘long unsigned int’ arguments
  266 |     return "triggered="s + (e.isTriggered() ? "true" : "false");
      |            ^~~~~~~~~~~~~
/usr/local/share/verilator/include/verilated_types.h: In function ‘std::string VL_TO_STRING(const VlEventBase&)’:
/usr/local/share/verilator/include/verilated_types.h:277:12: error: unable to find string literal operator ‘operator""s’ with ‘const char [11]’, ‘long unsigned int’ arguments
  277 |     return "triggered="s + (e.isTriggered() ? "true" : "false");
      |            ^~~~~~~~~~~~~
/usr/local/share/verilator/include/verilated_types.h: In constructor ‘VlClassRef<T_Class>::VlClassRef(VlClassRef<T_Class>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1651:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1651 |         : m_objp{std::exchange(moved.m_objp, nullptr)} {}
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated_threads.cpp:24:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from /usr/local/share/verilator/include/verilated_threads.h:28,
                 from /usr/local/share/verilator/include/verilated_threads.cpp:26:
/usr/local/share/verilator/include/verilated_types.h: In constructor ‘VlClassRef<T_Class>::VlClassRef(VlClassRef<T_OtherClass>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1661:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1661 |         : m_objp{std::exchange(moved.m_objp, nullptr)} {}
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated_threads.cpp:24:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from /usr/local/share/verilator/include/verilated_dpi.h:31,
                 from /usr/local/share/verilator/include/verilated_dpi.cpp:32:
/usr/local/share/verilator/include/verilated_types.h: In function ‘std::string VL_TO_STRING(const VlEvent&)’:
/usr/local/share/verilator/include/verilated_types.h:266:12: error: unable to find string literal operator ‘operator""s’ with ‘const char [11]’, ‘long unsigned int’ arguments
  266 |     return "triggered="s + (e.isTriggered() ? "true" : "false");
      |            ^~~~~~~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from /usr/local/share/verilator/include/verilated_threads.h:28,
                 from /usr/local/share/verilator/include/verilated_threads.cpp:26:
/usr/local/share/verilator/include/verilated_types.h: In member function ‘VlClassRef<T_Class>& VlClassRef<T_Class>::operator=(VlClassRef<T_Class>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1676:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1676 |         m_objp = std::exchange(moved.m_objp, nullptr);
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated_threads.cpp:24:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
/usr/local/share/verilator/include/verilated_types.h: In function ‘std::string VL_TO_STRING(const VlEventBase&)’:
/usr/local/share/verilator/include/verilated_types.h:277:12: error: unable to find string literal operator ‘operator""s’ with ‘const char [11]’, ‘long unsigned int’ arguments
  277 |     return "triggered="s + (e.isTriggered() ? "true" : "false");
      |            ^~~~~~~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from /usr/local/share/verilator/include/verilated_threads.h:28,
                 from /usr/local/share/verilator/include/verilated_threads.cpp:26:
/usr/local/share/verilator/include/verilated_types.h: In member function ‘VlClassRef<T_Class>& VlClassRef<T_Class>::operator=(VlClassRef<T_OtherClass>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1691:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1691 |         m_objp = std::exchange(moved.m_objp, nullptr);
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated_threads.cpp:24:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from ./Vtop_verilator__Syms.h:10,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system.cc:9:
/usr/local/share/verilator/include/verilated_types.h: In function ‘std::string VL_TO_STRING(const VlEvent&)’:
/usr/local/share/verilator/include/verilated_types.h:266:12: error: unable to find string literal operator ‘operator""s’ with ‘const char [11]’, ‘long unsigned int’ arguments
  266 |     return "triggered="s + (e.isTriggered() ? "true" : "false");
      |            ^~~~~~~~~~~~~
/usr/local/share/verilator/include/verilated_types.h: In function ‘std::string VL_TO_STRING(const VlEventBase&)’:
/usr/local/share/verilator/include/verilated_types.h:277:12: error: unable to find string literal operator ‘operator""s’ with ‘const char [11]’, ‘long unsigned int’ arguments
  277 |     return "triggered="s + (e.isTriggered() ? "true" : "false");
      |            ^~~~~~~~~~~~~
/usr/local/share/verilator/include/verilated_types.h: In constructor ‘VlClassRef<T_Class>::VlClassRef(VlClassRef<T_Class>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1651:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1651 |         : m_objp{std::exchange(moved.m_objp, nullptr)} {}
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated_dpi.cpp:30:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated_imp.h:32,
                 from /usr/local/share/verilator/include/verilated.cpp:53:
/usr/local/share/verilator/include/verilated.h:76:22: error: ‘literals’ is not a namespace-name
   76 | using namespace std::literals;  // "<std::string literal>"s; see SF.7 core guideline
      |                      ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from /usr/local/share/verilator/include/verilated_dpi.h:31,
                 from /usr/local/share/verilator/include/verilated_dpi.cpp:32:
/usr/local/share/verilator/include/verilated_types.h: In constructor ‘VlClassRef<T_Class>::VlClassRef(VlClassRef<T_OtherClass>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1661:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1661 |         : m_objp{std::exchange(moved.m_objp, nullptr)} {}
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated_dpi.cpp:30:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from /usr/local/share/verilator/include/verilated_dpi.h:31,
                 from /usr/local/share/verilator/include/verilated_dpi.cpp:32:
/usr/local/share/verilator/include/verilated_types.h: In member function ‘VlClassRef<T_Class>& VlClassRef<T_Class>::operator=(VlClassRef<T_Class>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1676:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1676 |         m_objp = std::exchange(moved.m_objp, nullptr);
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated_dpi.cpp:30:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from /usr/local/share/verilator/include/verilated_dpi.h:31,
                 from /usr/local/share/verilator/include/verilated_dpi.cpp:32:
/usr/local/share/verilator/include/verilated_types.h: In member function ‘VlClassRef<T_Class>& VlClassRef<T_Class>::operator=(VlClassRef<T_OtherClass>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1691:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1691 |         m_objp = std::exchange(moved.m_objp, nullptr);
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated_dpi.cpp:30:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
/usr/local/share/verilator/include/verilated_types.h: In constructor ‘VlClassRef<T_Class>::VlClassRef(VlClassRef<T_Class>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1651:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1651 |         : m_objp{std::exchange(moved.m_objp, nullptr)} {}
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from ./Vtop_verilator__Syms.h:10,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system.cc:9:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from ./Vtop_verilator__Syms.h:10,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system.cc:9:
/usr/local/share/verilator/include/verilated_types.h: In constructor ‘VlClassRef<T_Class>::VlClassRef(VlClassRef<T_OtherClass>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1661:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1661 |         : m_objp{std::exchange(moved.m_objp, nullptr)} {}
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from ./Vtop_verilator__Syms.h:10,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system.cc:9:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from ./Vtop_verilator__Syms.h:10,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system.cc:9:
/usr/local/share/verilator/include/verilated_types.h: In member function ‘VlClassRef<T_Class>& VlClassRef<T_Class>::operator=(VlClassRef<T_Class>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1676:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1676 |         m_objp = std::exchange(moved.m_objp, nullptr);
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from ./Vtop_verilator__Syms.h:10,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system.cc:9:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from ./Vtop_verilator__Syms.h:10,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system.cc:9:
/usr/local/share/verilator/include/verilated_types.h: In member function ‘VlClassRef<T_Class>& VlClassRef<T_Class>::operator=(VlClassRef<T_OtherClass>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1691:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1691 |         m_objp = std::exchange(moved.m_objp, nullptr);
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from ./Vtop_verilator__Syms.h:10,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system.cc:9:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from /usr/local/share/verilator/include/verilated_imp.h:32,
                 from /usr/local/share/verilator/include/verilated.cpp:53:
/usr/local/share/verilator/include/verilated_types.h: In function ‘std::string VL_TO_STRING(const VlEvent&)’:
/usr/local/share/verilator/include/verilated_types.h:266:12: error: unable to find string literal operator ‘operator""s’ with ‘const char [11]’, ‘long unsigned int’ arguments
  266 |     return "triggered="s + (e.isTriggered() ? "true" : "false");
      |            ^~~~~~~~~~~~~
/usr/local/share/verilator/include/verilated_types.h: In function ‘std::string VL_TO_STRING(const VlEventBase&)’:
/usr/local/share/verilator/include/verilated_types.h:277:12: error: unable to find string literal operator ‘operator""s’ with ‘const char [11]’, ‘long unsigned int’ arguments
  277 |     return "triggered="s + (e.isTriggered() ? "true" : "false");
      |            ^~~~~~~~~~~~~
/usr/local/share/verilator/include/verilated_types.h: In constructor ‘VlClassRef<T_Class>::VlClassRef(VlClassRef<T_Class>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1651:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1651 |         : m_objp{std::exchange(moved.m_objp, nullptr)} {}
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.cpp:51:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from /usr/local/share/verilator/include/verilated_imp.h:32,
                 from /usr/local/share/verilator/include/verilated.cpp:53:
/usr/local/share/verilator/include/verilated_types.h: In constructor ‘VlClassRef<T_Class>::VlClassRef(VlClassRef<T_OtherClass>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1661:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1661 |         : m_objp{std::exchange(moved.m_objp, nullptr)} {}
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.cpp:51:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from /usr/local/share/verilator/include/verilated_imp.h:32,
                 from /usr/local/share/verilator/include/verilated.cpp:53:
/usr/local/share/verilator/include/verilated_types.h: In member function ‘VlClassRef<T_Class>& VlClassRef<T_Class>::operator=(VlClassRef<T_Class>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1676:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1676 |         m_objp = std::exchange(moved.m_objp, nullptr);
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.cpp:51:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from /usr/local/share/verilator/include/verilated_imp.h:32,
                 from /usr/local/share/verilator/include/verilated.cpp:53:
/usr/local/share/verilator/include/verilated_types.h: In member function ‘VlClassRef<T_Class>& VlClassRef<T_Class>::operator=(VlClassRef<T_OtherClass>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1691:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1691 |         m_objp = std::exchange(moved.m_objp, nullptr);
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.cpp:51:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated_dpi.cpp:34:
/usr/local/share/verilator/include/verilated_imp.h: In static member function ‘static int VerilatedImp::exportFind(const char*)’:
/usr/local/share/verilator/include/verilated_imp.h:555:34: error: unable to find string literal operator ‘operator""s’ with ‘const char [28]’, ‘long unsigned int’ arguments
  555 |         const std::string msg = ("%Error: Testbench C called "s + namep
      |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[1]: *** [Vtop_verilator.mk:121: verilated_toplevel.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: *** [/usr/local/share/verilator/include/verilated.mk:275: verilated_threads.o] Error 1
In file included from /usr/local/share/verilator/include/verilated.cpp:53:
/usr/local/share/verilator/include/verilated_imp.h: In static member function ‘static int VerilatedImp::exportFind(const char*)’:
/usr/local/share/verilator/include/verilated_imp.h:555:34: error: unable to find string literal operator ‘operator""s’ with ‘const char [28]’, ‘long unsigned int’ arguments
  555 |         const std::string msg = ("%Error: Testbench C called "s + namep
      |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[1]: *** [Vtop_verilator.mk:123: verilator_sim_ctrl.o] Error 1
In file included from Vtop_verilator__pch.h:21:
/usr/local/share/verilator/include/verilated.h:76:22: error: ‘literals’ is not a namespace-name
   76 | using namespace std::literals;  // "<std::string literal>"s; see SF.7 core guideline
      |                      ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated_fst_c.cpp:26:
/usr/local/share/verilator/include/verilated.h:76:22: error: ‘literals’ is not a namespace-name
   76 | using namespace std::literals;  // "<std::string literal>"s; see SF.7 core guideline
      |                      ^~~~~~~~
In file included from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system.h:5,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system_main.cc:5:
/usr/local/share/verilator/include/verilated.h:76:22: error: ‘literals’ is not a namespace-name
   76 | using namespace std::literals;  // "<std::string literal>"s; see SF.7 core guideline
      |                      ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from Vtop_verilator__pch.h:21:
/usr/local/share/verilator/include/verilated_types.h: In function ‘std::string VL_TO_STRING(const VlEvent&)’:
/usr/local/share/verilator/include/verilated_types.h:266:12: error: unable to find string literal operator ‘operator""s’ with ‘const char [11]’, ‘long unsigned int’ arguments
  266 |     return "triggered="s + (e.isTriggered() ? "true" : "false");
      |            ^~~~~~~~~~~~~
/usr/local/share/verilator/include/verilated_types.h: In function ‘std::string VL_TO_STRING(const VlEventBase&)’:
/usr/local/share/verilator/include/verilated_types.h:277:12: error: unable to find string literal operator ‘operator""s’ with ‘const char [11]’, ‘long unsigned int’ arguments
  277 |     return "triggered="s + (e.isTriggered() ? "true" : "false");
      |            ^~~~~~~~~~~~~
make[1]: *** [Vtop_verilator.mk:125: ibex_demo_system.o] Error 1
/usr/local/share/verilator/include/verilated_types.h: In constructor ‘VlClassRef<T_Class>::VlClassRef(VlClassRef<T_Class>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1651:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1651 |         : m_objp{std::exchange(moved.m_objp, nullptr)} {}
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from Vtop_verilator__pch.h:21:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from /usr/local/share/verilator/include/verilated_fst_c.cpp:26:
/usr/local/share/verilator/include/verilated_types.h: In function ‘std::string VL_TO_STRING(const VlEvent&)’:
/usr/local/share/verilator/include/verilated_types.h:266:12: error: unable to find string literal operator ‘operator""s’ with ‘const char [11]’, ‘long unsigned int’ arguments
  266 |     return "triggered="s + (e.isTriggered() ? "true" : "false");
      |            ^~~~~~~~~~~~~
make[1]: *** [/usr/local/share/verilator/include/verilated.mk:275: verilated_dpi.o] Error 1
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from Vtop_verilator__pch.h:21:
/usr/local/share/verilator/include/verilated_types.h: In constructor ‘VlClassRef<T_Class>::VlClassRef(VlClassRef<T_OtherClass>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1661:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1661 |         : m_objp{std::exchange(moved.m_objp, nullptr)} {}
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from Vtop_verilator__pch.h:21:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
/usr/local/share/verilator/include/verilated_types.h: In function ‘std::string VL_TO_STRING(const VlEventBase&)’:
/usr/local/share/verilator/include/verilated_types.h:277:12: error: unable to find string literal operator ‘operator""s’ with ‘const char [11]’, ‘long unsigned int’ arguments
  277 |     return "triggered="s + (e.isTriggered() ? "true" : "false");
      |            ^~~~~~~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from Vtop_verilator__pch.h:21:
/usr/local/share/verilator/include/verilated_types.h: In member function ‘VlClassRef<T_Class>& VlClassRef<T_Class>::operator=(VlClassRef<T_Class>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1676:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1676 |         m_objp = std::exchange(moved.m_objp, nullptr);
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from Vtop_verilator__pch.h:21:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from Vtop_verilator__pch.h:21:
/usr/local/share/verilator/include/verilated_types.h: In member function ‘VlClassRef<T_Class>& VlClassRef<T_Class>::operator=(VlClassRef<T_OtherClass>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1691:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1691 |         m_objp = std::exchange(moved.m_objp, nullptr);
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from Vtop_verilator__pch.h:21:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from Vtop_verilator__pch.h:21:
/usr/local/share/verilator/include/verilated.h:76:22: error: ‘literals’ is not a namespace-name
   76 | using namespace std::literals;  // "<std::string literal>"s; see SF.7 core guideline
      |                      ^~~~~~~~
/usr/local/share/verilator/include/verilated_types.h: In constructor ‘VlClassRef<T_Class>::VlClassRef(VlClassRef<T_Class>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1651:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1651 |         : m_objp{std::exchange(moved.m_objp, nullptr)} {}
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from /usr/local/share/verilator/include/verilated_fst_c.cpp:26:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
/usr/local/share/verilator/include/verilated.cpp: In function ‘void _vl_vsformat(std::string&, const string&, __va_list_tag*)’:
/usr/local/share/verilator/include/verilated.cpp:946:38: error: unable to find string literal operator ‘operator""s’ with ‘const char [2]’, ‘long unsigned int’ arguments
  946 |                             append = "-"s + VL_DECIMAL_NW(lbits, neg);
      |                                      ^~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from /usr/local/share/verilator/include/verilated_fst_c.cpp:26:
/usr/local/share/verilator/include/verilated_types.h: In constructor ‘VlClassRef<T_Class>::VlClassRef(VlClassRef<T_OtherClass>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1661:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1661 |         : m_objp{std::exchange(moved.m_objp, nullptr)} {}
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from /usr/local/share/verilator/include/verilated_fst_c.cpp:26:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from /usr/local/share/verilator/include/verilated_fst_c.cpp:26:
/usr/local/share/verilator/include/verilated_types.h: In member function ‘VlClassRef<T_Class>& VlClassRef<T_Class>::operator=(VlClassRef<T_Class>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1676:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1676 |         m_objp = std::exchange(moved.m_objp, nullptr);
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from /usr/local/share/verilator/include/verilated_fst_c.cpp:26:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
/usr/local/share/verilator/include/verilated.cpp:1088:45: error: unable to find string literal operator ‘operator""s’ with ‘const char [28]’, ‘long unsigned int’ arguments
 1088 |                     const std::string msg = "Unknown _vl_vsformat code: "s + pos[0];
      |                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from /usr/local/share/verilator/include/verilated_fst_c.cpp:26:
/usr/local/share/verilator/include/verilated_types.h: In member function ‘VlClassRef<T_Class>& VlClassRef<T_Class>::operator=(VlClassRef<T_OtherClass>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1691:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1691 |         m_objp = std::exchange(moved.m_objp, nullptr);
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from /usr/local/share/verilator/include/verilated_fst_c.cpp:26:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system.h:5,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system_main.cc:5:
/usr/local/share/verilator/include/verilated_types.h: In function ‘std::string VL_TO_STRING(const VlEvent&)’:
/usr/local/share/verilator/include/verilated_types.h:266:12: error: unable to find string literal operator ‘operator""s’ with ‘const char [11]’, ‘long unsigned int’ arguments
  266 |     return "triggered="s + (e.isTriggered() ? "true" : "false");
      |            ^~~~~~~~~~~~~
/usr/local/share/verilator/include/verilated_types.h: In function ‘std::string VL_TO_STRING(const VlEventBase&)’:
/usr/local/share/verilator/include/verilated_types.h:277:12: error: unable to find string literal operator ‘operator""s’ with ‘const char [11]’, ‘long unsigned int’ arguments
  277 |     return "triggered="s + (e.isTriggered() ? "true" : "false");
      |            ^~~~~~~~~~~~~
/usr/local/share/verilator/include/verilated.cpp: In function ‘IData _vl_vsscanf(FILE*, int, WDataInP, const string&, const string&, __va_list_tag*)’:
/usr/local/share/verilator/include/verilated.cpp:1370:45: error: unable to find string literal operator ‘operator""s’ with ‘const char [27]’, ‘long unsigned int’ arguments
 1370 |                     const std::string msg = "Unknown _vl_vsscanf code: "s + pos[0];
      |                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/share/verilator/include/verilated.cpp: In function ‘std::string VL_STACKTRACE_N()’:
/usr/local/share/verilator/include/verilated.cpp:1730:73: error: unable to find string literal operator ‘operator""s’ with ‘const char [2]’, ‘long unsigned int’ arguments
 1730 |     for (int j = 0; j < nptrs; j++) result += std::string{strings[j]} + "\n"s;
      |                                                                         ^~~~~
/usr/local/share/verilator/include/verilated_types.h: In constructor ‘VlClassRef<T_Class>::VlClassRef(VlClassRef<T_Class>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1651:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1651 |         : m_objp{std::exchange(moved.m_objp, nullptr)} {}
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system.h:5,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system_main.cc:5:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system.h:5,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system_main.cc:5:
/usr/local/share/verilator/include/verilated_types.h: In constructor ‘VlClassRef<T_Class>::VlClassRef(VlClassRef<T_OtherClass>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1661:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1661 |         : m_objp{std::exchange(moved.m_objp, nullptr)} {}
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system.h:5,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system_main.cc:5:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system.h:5,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system_main.cc:5:
/usr/local/share/verilator/include/verilated_types.h: In member function ‘VlClassRef<T_Class>& VlClassRef<T_Class>::operator=(VlClassRef<T_Class>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1676:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1676 |         m_objp = std::exchange(moved.m_objp, nullptr);
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system.h:5,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system_main.cc:5:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system.h:5,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system_main.cc:5:
/usr/local/share/verilator/include/verilated_types.h: In member function ‘VlClassRef<T_Class>& VlClassRef<T_Class>::operator=(VlClassRef<T_OtherClass>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1691:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1691 |         m_objp = std::exchange(moved.m_objp, nullptr);
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from ../src/lowrisc_dv_verilator_simutil_verilator_0/cpp/verilated_toplevel.h:12,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system.h:5,
                 from ../src/lowrisc_ibex_demo_system_0/dv/verilator/ibex_demo_system_main.cc:5:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from Vtop_verilator__pch.h:21:
/usr/local/share/verilator/include/verilated_types.h: In function ‘std::string VL_TO_STRING(const VlEvent&)’:
/usr/local/share/verilator/include/verilated_types.h:266:12: error: unable to find string literal operator ‘operator""s’ with ‘const char [11]’, ‘long unsigned int’ arguments
  266 |     return "triggered="s + (e.isTriggered() ? "true" : "false");
      |            ^~~~~~~~~~~~~
/usr/local/share/verilator/include/verilated_types.h: In function ‘std::string VL_TO_STRING(const VlEventBase&)’:
/usr/local/share/verilator/include/verilated_types.h:277:12: error: unable to find string literal operator ‘operator""s’ with ‘const char [11]’, ‘long unsigned int’ arguments
  277 |     return "triggered="s + (e.isTriggered() ? "true" : "false");
      |            ^~~~~~~~~~~~~
/usr/local/share/verilator/include/verilated_types.h: In constructor ‘VlClassRef<T_Class>::VlClassRef(VlClassRef<T_Class>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1651:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1651 |         : m_objp{std::exchange(moved.m_objp, nullptr)} {}
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from Vtop_verilator__pch.h:21:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from Vtop_verilator__pch.h:21:
/usr/local/share/verilator/include/verilated_types.h: In constructor ‘VlClassRef<T_Class>::VlClassRef(VlClassRef<T_OtherClass>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1661:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1661 |         : m_objp{std::exchange(moved.m_objp, nullptr)} {}
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from Vtop_verilator__pch.h:21:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from Vtop_verilator__pch.h:21:
/usr/local/share/verilator/include/verilated_types.h: In member function ‘VlClassRef<T_Class>& VlClassRef<T_Class>::operator=(VlClassRef<T_Class>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1676:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1676 |         m_objp = std::exchange(moved.m_objp, nullptr);
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from Vtop_verilator__pch.h:21:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:950,
                 from Vtop_verilator__pch.h:21:
/usr/local/share/verilator/include/verilated_types.h: In member function ‘VlClassRef<T_Class>& VlClassRef<T_Class>::operator=(VlClassRef<T_OtherClass>&&)’:
/usr/local/share/verilator/include/verilated_types.h:1691:23: error: ‘exchange’ is not a member of ‘std’; did you mean ‘vlstd::exchange’?
 1691 |         m_objp = std::exchange(moved.m_objp, nullptr);
      |                       ^~~~~~~~
In file included from /usr/local/share/verilator/include/verilated.h:42,
                 from Vtop_verilator__pch.h:21:
/usr/local/share/verilator/include/verilatedos.h:642:3: note: ‘vlstd::exchange’ declared here
  642 | T exchange(T& obj, U&& new_value) {
      |   ^~~~~~~~
/usr/local/share/verilator/include/verilated.cpp: In static member function ‘static void Verilated::overWidthError(const char*)’:
/usr/local/share/verilator/include/verilated.cpp:2993:30: error: unable to find string literal operator ‘operator""s’ with ‘const char [24]’, ‘long unsigned int’ arguments
 2993 |     const std::string msg = ("Testbench C set input '"s + signame
      |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/share/verilator/include/verilated.cpp: In member function ‘void VerilatedScope::varInsert(int, const char*, void*, bool, VerilatedVarType, int, int, ...)’:
/usr/local/share/verilator/include/verilated.cpp:3215:37: error: unable to find string literal operator ‘operator""s’ with ‘const char [49]’, ‘long unsigned int’ arguments
 3215 |             const std::string msg = "Unsupported multi-dimensional public varInsert: "s + namep;
      |                                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/share/verilator/include/verilated.cpp: In static member function ‘static void* VerilatedScope::exportFindNullError(int)’:
/usr/local/share/verilator/include/verilated.cpp:3235:30: error: unable to find string literal operator ‘operator""s’ with ‘const char [21]’, ‘long unsigned int’ arguments
 3235 |     const std::string msg = ("Testbench C called '"s + VerilatedImp::exportName(funcnum)
      |                              ^~~~~~~~~~~~~~~~~~~~~~~
/usr/local/share/verilator/include/verilated.cpp: In member function ‘void* VerilatedScope::exportFindError(int) const’:
/usr/local/share/verilator/include/verilated.cpp:3245:12: error: unable to find string literal operator ‘operator""s’ with ‘const char [21]’, ‘long unsigned int’ arguments
 3245 |         = ("Testbench C called '"s + VerilatedImp::exportName(funcnum)
      |            ^~~~~~~~~~~~~~~~~~~~~~~
make[1]: *** [Vtop_verilator.mk:127: ibex_demo_system_main.o] Error 1
make[1]: *** [/usr/local/share/verilator/include/verilated.mk:275: verilated.o] Error 1
make[1]: *** [/usr/local/share/verilator/include/verilated.mk:275: verilated_fst_c.o] Error 1
make[1]: *** [/usr/local/share/verilator/include/verilated.mk:281: Vtop_verilator__pch.h.fast.gch] Error 1
make[1]: *** [/usr/local/share/verilator/include/verilated.mk:283: Vtop_verilator__pch.h.slow.gch] Error 1
make: *** [Makefile:13: Vtop_verilator] Error 2

ERROR: Failed to build lowrisc:ibex:demo_system:0 : '['make', '-j', '20']' exited with an error: 2


send email error when write comment

gogs version:<IP_ADDRESS>1
2016/12/28 15:49:49 [...les/mailer/mailer.go:201 processMailQueue()] [E] Fail to send emails<EMAIL_ADDRESS>Subject: [jxr_api] 测试邮箱 (#2), issue comment - gomail: could not send email 1: gomail: invalid address "=?UTF-8?q?\"=E8=80=BF=E8=88=92\"_<gitserver@mymail.com>?=": mail: expected single address, got "?="

When I write comments in issues,send email always fail, I check the gogs.log and found this, this is my mailer config in app.ini:
[mailer]
ENABLED = true
HOST    = smtp.exmail.qq.com:465
FROM    = "GIT_SERVER"<EMAIL_ADDRESS>USER    =<EMAIL_ADDRESS>PASSWD  = mypassword

And I also viewed the issues in
https://github.com/gogits/gogs/issues/3714
https://github.com/gogits/gogs/pull/3960
They edit the setting.MailService.User to setting.MailService.From
The master branch not merge this pr, should I recompile it myself to resolve this question ?

I think this is duplicated to https://github.com/gogits/gogs/issues/3856.


enum generation ignores existingJavaType

When running jsonSchema2Pojo it seems it generates enums regardless of whether I specified to use existingJavaType, that seems a bit odd.
If I wanted to generatePojo's that used an enum i wrote myself, it feels like i should be able to.

Would it be possible to provide some sample schema(s) ?

Hi there
Here is a sample schema and an example of what I am trying to achieve.
Kind regards
Jan H. Hansen
On Wed, Dec 2, 2020 at 3:32 PM unkish<EMAIL_ADDRESS>wrote:

Would it be possible to provide some sample schema(s) ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/joelittlejohn/jsonschema2pojo/issues/1182#issuecomment-737266213,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AARPLQZNRN6R4QPOPUKZMT3SSZFXRANCNFSM4UKMZ7KQ
.

I'm sorry but I don't see any schemas attached :confused:

First attachment to previous mail was a schema.
I am guessing you wanted it attached to issue. I'll do that tomorrow.
Sorry for inconvenience.
On Wed, Dec 2, 2020, 19:44 unkish<EMAIL_ADDRESS>wrote:

I'm sorry but I don't see any schemas attached 😕
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/joelittlejohn/jsonschema2pojo/issues/1182#issuecomment-737422320,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AARPLQ7XC7EAB67QBEA4IOTSS2DKVANCNFSM4UKMZ7KQ
.

test.zip
Here are the aforementioned files.

If I wanted to generatePojo's that used an enum i wrote myself, it feels like i should be able to.

If enum would be omitted from property definition:
    "properties": {
        "bar": {
            "existingJavaType": "com.examples.types.NonGeneratedBar",
            "type": "string",
            "enum": [
                "BAZ",
                "BAR"
            ]
        }
    }

then generated POJO would be referencing given type eg.:
    "properties": {
        "bar": {
            "existingJavaType": "com.examples.types.NonGeneratedBar"
        }
    }

Considering that the referenced existing java type could be:

non enum type, in which case enum definition would be misleading
enum but with diferent set of constants or equivalent set of constants with different ordinal values, in which case enum definition would be misleading
enum that either could have been generated via same definition in separate file or non-generated having same values, in which case it would be data duplication.

At this point I fail to understand what is the use-case for having both existingJavaType and enum defined in such a way?

Let me clarify then. Consider:
enum Country {
DK("DK", "Denmark", "da-DK", "Danish", "kr."),
....
Country(String countryCode, String name, String locale, String language,
String currency) {
....
}
}
Enums are classes that can have any number of properties and methods. If I
want my enum to have methods that I define, I want to be able to tell
jsonschema2Pojo to just let me handle those enums.
I still want to use json validation for that enum and i still want other
classes to be generated.
I am fine with implementing the contract with jsonschema2Pojo by hand.
Kind regards
Jan H. Hansen
On Thu, Dec 3, 2020 at 8:12 PM unkish<EMAIL_ADDRESS>wrote:

If I wanted to generatePojo's that used an enum i wrote myself, it feels
like i should be able to.
If enum would be omitted from property definition:
"properties": {
    "bar": {
        "existingJavaType": "com.examples.types.NonGeneratedBar",
        "type": "string",
        "enum": [
            "BAZ",
            "BAR"
        ]
    }
}

then generated POJO would be referencing given type eg.:
"properties": {
    "bar": {
        "existingJavaType": "com.examples.types.NonGeneratedBar"
    }
}

Considering that the referenced existing java type could be:

non enum type, in which case enum definition would be misleading
enum but with diferent set of constants or equivalent set of
constants with different ordinal values, in which case enum definition
would be misleading
enum that either could have been generated via same definition in
separate file or non-generated having same values, in which case it would
be data duplication.

At this point I fail to understand what is the use-case for having both
existingJavaType and enum defined in such a way?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/joelittlejohn/jsonschema2pojo/issues/1182#issuecomment-738234294,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AARPLQYCRH6NJZGQI6AVSWDSS7PJDANCNFSM4UKMZ7KQ
.

Hi

Enums are classes that can have any number of properties and methods.

I do believe that this is only partially correct. Enums are special types which may have any number of properties and methods.

If I want my enum to have methods that I define, I want to be able to tell jsonschema2Pojo to just let me handle those enums

This could be achieved by using existingJavaType (note that it's not accompanied by enum definition) eg:
    "properties": {
        "bar": {
            "existingJavaType": "com.examples.types.NonGeneratedEnum"
        }
    }

I still want to use json validation for that enum and i still want other classes to be generated.

I'm sorry but I don't understand what kind of JSON validation for enum is expected to happen (the only one I could think of is defined by required)

I think the point here is that you still want to include the enum rule in your schema, because when the schema is used for validation you want the enum values defined and applied. It's good for documentation too, of course.
It should be pretty simple to ignore enum when existingJavaType is defined.

Exactly. That is what i expected to happen.
On Mon, Dec 7, 2020 at 1:13 PM Joe Littlejohn<EMAIL_ADDRESS>wrote:

I think the point here is that you still want to include the enum rule in
your schema, because when the schema is used for validation you want the
enum values defined and applied. It's good for documentation too, of course.
It should be pretty simple to ignore enum when existingJavaType is
defined.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/joelittlejohn/jsonschema2pojo/issues/1182#issuecomment-739880772,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AARPLQ72QQYE46UMRK4OWATSTTBHTANCNFSM4UKMZ7KQ
.

Until PR it should be possible to workaround by supplying custom RuleFactory with either getSchemaRule or getEnumRule being overridden such that in case when there are both enum and existingJavaType present latter would take precedence.
Eg. custom EnumRule with:
    @Override
    public JType apply(String nodeName, JsonNode node, JsonNode parent, JClassContainer container, Schema schema) {
        if (node.has("existingJavaType")) {
            return ruleFactory.getTypeRule().apply(nodeName, node, parent, container.getPackage(), schema);
        }
        return super.apply(nodeName, node, parent, container, schema);
    }


ffi: Adjust tests to be able to test a system-installed library

This lets me re-use the FFI test suite on GNU/Linux without rust or cargo installed, while still letting test suite work during development.

Thank you!


Feat: Add toggle to hide the uptime percentage on a statuspage

⚠⚠⚠ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:

[x] I have read and understand the pull request rules.

Description
This PR adds a new 'Hide Uptime Percentage' setting to the status page.
Fixes #3774
Type of change
Please delete any options that are not relevant.

User interface (UI)
New feature (non-breaking change which adds functionality)

Checklist

[x] My code follows the style guidelines of this project
[x] I ran ESLint and other linters for modified files
[x] I have performed a self-review of my own code and tested it
[x] I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
[x] My changes generates no new warnings
[ ] My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.
@louislam

Hi,
Do you have a timeframe for when this option will be implemented? Thanks

Hi, Do you have a timeframe for when this option will be implemented? Thanks

@ajaouad
The feature itself has been fully implemented in this PR, as far as i am concerned.
If i understand correctly, only senior maintainers can merge/review new features.
But this repository has many other PR's that equally deserve to be reviewed, so patience is key 😄


Support local filesystem 'fs' driver -> web server?

Either we use a very light weight embedded http server
We could provide optional spring integration @RestController - already implemented this. This would not be in the standard josc collection however.

Has been implemented by a spring specific rest controller.


Enable CupertinoPopupSurface's backdrop filter test on skwasm once the Skia bug is fixed

https://github.com/flutter/flutter/pull/151430 added a backdrop filter to CupertinoPopupSurface, but the filter does not work on skwasm due to a Skia bug https://github.com/flutter/flutter/issues/152026. Once the issue is closed, we should unskip these tests.

Once https://github.com/flutter/engine/pull/56385 rolls into the framework, this should be unblocked.


App hangs on fresh install when clicking add on VS Code

Dev Home version
Latest Store (2023-05-31)
Windows build number
22621.1702
Other software
N/@
Steps to reproduce the bug
On a very fresh Windows install - this was the first installed app - after resolving #1000 (device offline), the app froze upon clicking the plus on VS Code.
Expected result
VS Code should have been queued and the Dev Home App should remain responsive when adding apps.
Actual result
The app hangs with the busy cursor showing upon trying to click the close window button. The app had to be closed via task manager.
Included System Information
No response
Included Extensions Information
No response

We are troubleshooting by running Windows Update.

App hanging when interacting with the FlipView in the App Install page is possibly a sign of a crash, which I suspect is related/has the same root issue as #768, addressed in this PR #1070
/dup #768


Set the access log field invalid

Hi, I need some help
Environment

traefik: 2.1.1
k8s: 1.16.1(backend)

Steps
cli  configuration access log
spec:
      containers:
      - args:
        - --api
        - --api.dashboard=true
        - --api.insecure=true
        - --accesslog=true
        - --accesslog.format=json
        - --accesslog.bufferingsize=10
        - --accesslog.filters.retryattempts
        - --accesslog.fields.defaultmode=drop
        - --accesslog.fields.names.StartLocal=keep
        - --accesslog.fields.names.Duration=keep
        - --accesslog.fields.names.ClientAddr=keep
        - --accesslog.fields.names.RequestAddr=keep
        - --accesslog.fields.headers.defaultmode=drop
        - --accesslog.fields.headers.names.User-Agent=redact
        - --accesslog.fields.headers.names.Authorization=drop
        - --accesslog.fields.headers.names.Content-Type=keep
        - --log.level=INFO
        ......

Issue
See the log
# kubectl logs traefik-ingress-lb-bsmrb -n kube-system --tail 10
time="2021-04-19T06:59:54Z" level=error msg="kubernetes service not found: mk-master/mk-wat-api-master" providerName=kubernetescrd ingress=ingressroute-https namespace=mk-master
time="2021-04-19T06:59:54Z" level=error msg="kubernetes service not found: mk-dev3/qw-assistant-api" ingress=ingressroute-qw-assistant-api-https namespace=mk-dev3 providerName=kubernetescrd
time="2021-04-19T06:59:54Z" level=error msg="kubernetes service not found: crm-master/xtestxxx" ingress=test-xxx-ingressroute2 namespace=crm-master providerName=kubernetescrd
time="2021-04-19T06:59:54Z" level=error msg="kubernetes service not found: crm-master/xtestxxx" ingress=test-xxx-ingressroute2 namespace=crm-master providerName=kubernetescrd
time="2021-04-19T06:59:54Z" level=error msg="kubernetes service not found: default/wp-client" providerName=kubernetescrd ingress=ingressroute-crm namespace=default
time="2021-04-19T06:59:54Z" level=error msg="kubernetes service not found: default/wp-manage" ingress=ingressroute-crm namespace=default providerName=kubernetescrd
time="2021-04-19T06:59:54Z" level=error msg="subset not found for mk-master/mk-sdk" providerName=kubernetescrd namespace=mk-master ingress=ingressroute-mk-mesh-https
time="2021-04-19T06:59:54Z" level=error msg="kubernetes service not found: mk-master/mk-cof-free-svc" providerName=kubernetescrd ingress=ingressroute-internal-https namespace=mk-master
time="2021-04-19T06:59:54Z" level=error msg="Cannot create service: service not found" ingress=kf-app namespace=java-test serviceName=java-im-service providerName=kubernetescrd servicePort=8064
time="2021-04-19T06:59:54Z" level=error msg="Cannot create service: service not found" providerName=kubernetescrd ingress=kf-pc namespace=java-test serviceName=java-im-service servicePort=8063

The log content of standard output is not the field content (StartLocal、ClientAddr、RequestAddr etc) set by user. What's wrong with my configuration? How can I configure to output only the specified field content such as StartLocal、ClientAddr、RequestAddr etc.
I checked the official documents and other materials, but I didn't find a solution. Thank

Hi! I'm Træfiker :robot: the bot in charge of communication regulation.
Thanks for your interest in Traefik!
We dedicate the issue tracker to bug reports and feature requests only. My advanced AI has spotted that your issue might be a configuration problem or relates to something that doesn't look like a bug.
To confirm this, please join our Community Forum and reach out to us on the Traefik section.
In case I'm wrong (well, that would be embarrassing :sweat_smile:), my developers will re-open the issue and fix me!
In the meantime, you can double check Traefik's documentation.

Hello @openstack-test
Thanks a lot for using Traefik and contacting us.
We tend to use the issues tracker to report bugs, proposal for new features, and the community forum to ask the question. I highly recommend opening a thread on the forum that's is driven by the community members and I believe that your questions will be answered there.
Seems that it is a rather configuration issue I encourage to join our Community forum.
Thank you,


Prevent Beta legal text getting cut off on the right when resizing window

Bug/issue #, if applicable: 92669937
Summary
Prevent Beta legal text from getting cut off on the right when resizing window
Testing
Steps:

Navigate to a window with Beta legal text at the bottom of the page.
Verify that the text resizes correctly when going from L vp to M vp.

Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[ ] Added tests - NA
[x] Ran npm test, and it succeeded
[ ] Updated documentation if necessary - NA

Looks good to me!

@swift-ci test

@swift-ci test


Harmonize remove Rapid Test Profile on iOS and Android

Current Implementation
The user interface to remove a Rapid Test Profile (RTP) differs significantly between the iOS and Android implementations. In iOS the user interface presents the text "Remove Rapid Test Profile" and in Android, a user must first tap on the three-dot symbol before the one-word text "Remove" is displayed.

The Rapid Test Profile (RTP) was introduced in Version 2.2 of CWA.
Suggested Enhancement
Make the steps for removing a Rapid Test Profile the same on iOS and Android.
Expected Benefits
Having different user interface structures on iOS and Android makes describing how to use the app more difficult and complicated. See for instance the FAQ article "How can I create, edit and remove a rapid test profile?" on https://www.coronawarn.app/en/faq/#rat_profile_create_edit_delete, where it was necessary to write two different sections, one for iOS, another for Android.
Conversely, keeping the user interfaces on iOS and Android as close to one another as possible, eases documentation and reduces confusion.

Internal Tracking-ID: EXPOSUREAPP-7270

@MikeMcC399
Thank you for the report. We have created an internal ticket  EXPOSUREAPP-7270

Corona-Warn-App Open Source Team

In version 2.15.1 of the Android app the text to remove a Rapid Test Profile is:

Android App Version
Text (EN)
Text (DE)

2.15.1
Delete Rapid Test Profile
Schnelltest-Profil löschen

If this is the same text used in the latest version of the CWA iOS app, then this issue can be closed.
The difference of having the three-dot symbol in Android at the top-right and the menu at the bottom in iOS is a general difference, which is not specific to the Rapid Test Profile. That could be explained somewhere generically in the FAQs, for instance in the https://www.coronawarn.app/en/faq/#application section of the FAQs.

See also https://github.com/corona-warn-app/cwa-website/issues/2280

Under iOS, I perform these steps to remove a rapid test profile:

Open CWA
Click on "Manage Your Tests"
Click on "Rapid Test Profile"
Click on "Edit" on the bottom
Click on "Delete Rapid Test Profile"
Click on "Delete" in the confirmation pop up.

Video:
https://user-images.githubusercontent.com/67682506/148094529-f96336e6-f87b-435d-bf92-1b10e75aea79.MOV

The texts for deleting a Rapid Test Profile are now the same on iOS and Android.

PR #2280 "Incorrect instructions to delete a Rapid Test Profile for Android" is submitted to update the FAQs:

https://www.coronawarn.app/en/faq/#rat_profile_create_edit_delete
https://www.coronawarn.app/de/faq/#rat_profile_create_edit_delete

This wishlist item can now be closed.


[The One Ring] Version 2.0: update to match formatting of printed sheet

Changes
This commit squashes down multiple changes to more closely reflect the official printed character sheet, specifically:

use a styled background
display diamond checkboxes for common skills and skill groups
format and style experience, valour and wisdom in top right of sheet
use a serif font

Additionally, internationalisation support is improved:

switch the logo to display correctly for different language versions (English, French, German, Spanish).
support migrating from 'Der Eine Ring' and 'Anneau Unique' sheets, by use of worker scripts to copy data to new fields.

Other minor additional features:

fixed slots for weapons for ease of macro scripting.
user-definable skills for Loremaster Characters
adding 'Mounts' for horses etc.

Additional comments
This is a major update of layout and styling but seeks to be completely backwards compatible with the original version of the sheet, as well as other language versions of the sheet ("Anneau Unique" and "Der Eine Ring") that have developed over time.
The development and testing has been a team effort, announced and coordinated on the RPGGeek forum at rpggeek.com/thread/2024136/fellowship-roll20-character-sheet. We have recently completed testing and a 'public beta' period for feedback.

Also thanks for the detailed comment! It was very helpful.

@clevett - thanks for merging this, but it seems your subsequent commit f34b45a4 overwrote the translations and broke the changes for 'The One Ring'!
I've raised a new Pull Request to fix this, at https://github.com/Roll20/roll20-character-sheets/pull/4457. Could you please give this new Pull Request urgent attention to merge as soon as possible, to resolve this problem?

Greetings @stuartj ,
It looks like nine keys are experiencing an issue on production due to this overwrite and those keys are well labelled so users will know their intended purpose. I'm going to hold off on merging the new PR for now and merge it as part of a test to see why the translation process replaced those keys. That translation merge happens every week as part of the sheet updates and I want to ensure this was just a one time fluke that wont happen every week thereafter.
Thanks,
Cassie

Thanks Cassie. Hopefully anybody who goes to take a look at the new sheet in the meantime will overlook the glitches while you are doing your test!
Re: your comment about ensuring no subsequent overwrites, is there somewhere else that I need to update the translations, on CrowdIn or wherever? After reading https://wiki.roll20.net/Character_Sheet_i18n#Changing_your_Translation, I also edited the translation.json - which I gather is the 'source' for CrowdIn -  in commit
34d3e36 for this Pull Request. I also updated the other as yet untranslated translation .json files, though I boggled at what to do about translations/zu.json.
best regards
Stuart


refactor(go-ethereum-socketio): implement core-api interfaces

See the containing epic for more context and the scope of packages that are being affected: https://github.com/hyperledger/cactus/issues/1497

Depends on #1506 (not really a hard dependency, more of a recommendation that these two issues should not be worked on simultaneously because that will lead to nasty conflicts)
Implement the connector interfaces:

factory creator function export
factory class itself
plugin class to implement the cactus plugin interface
plugin class to implement the web service plugin interface
tests to verify that it works within cmd-api-server

Plugin refactored


Windows install

Maybe I have something wrong with my Windows system or I am doing something else wrong, but I can't install with the changes in 029bb912e155077e65ec887d02f826c5ac6a658e.  If I revert that change, then it seems to work.
install_windows.txt

Hi, can you paste the log in the description?

Thanks! Should be fixed in #174.
It also seems to work fine on the latest Python (3.10.2) without the fix.

Thank you.  The changes in the PR worked for me.


Add gcsUri() helper method to Google\Cloud\Storage\StorageObject

In order to make it simpler for users to generate a cloud storage URI from an object, we should add a helper method called gcsUri or similar to Google\Cloud\Storage\StorageObject which will concatenate the bucket and object name into a URI of the format gs://<bucket>/<object>.
Additionally, any parts of the library which currently accept an instance of StorageObject should be updated to accept a cloud storage URI as a string.

Closed by: https://github.com/GoogleCloudPlatform/google-cloud-php/pull/360/commits/845424aab240c7d6c3616f122aaa65c5c9deea8c


The Grafana can not identify the macro variables of ZABBIX

Hello,
I have a problem:
When i create graph in "time series" in Grafana, the macro variable {$ISP_PRI_NAME} and all other macros defined in Zabbix can't be identified.
screenshots from grafana & zabbix (include graph and macro value) was attached
value macro {$ISP_SEC_NAME} is "0"
Zabbix plugin for Grafana - version 4.2.5
Zabbix - version 5.0.17

@alexanderzobnin  hi, has this problem been solved yet?

Hi @alexanderzobnin !
I would like this feature to get Zabbix macros in Grafana too !

Hi @alexanderzobnin!
It still doesn't work?
Zabbix plugin for Grafana - version 4.4.4
Zabbix - version 6.4

Greetings, @alexanderzobnin!
Found that if U set "Direct DB Connection" in Grafana's Zabbix datasources settings - macro will correctly expand. But it affects (broke) filtering by Application.
BTW: Thanks for your plugin, it's wonderful!
Our setup: Zabbix 5.0.41 on PostgreSQL, Grafana 10.4.1, Zabbix plugin 4.4.6

Greetings, @alexanderzobnin!
Found that if U set "Direct DB Connection" in Grafana's Zabbix datasources settings - macro will correctly expand. But it affects (broke) filtering by Application. BTW: Thanks for your plugin, it's wonderful!
Our setup: Zabbix 5.0.41 on PostgreSQL, Grafana 10.4.1, Zabbix plugin 4.4.6

Not worked :(


Feature request: makePlainText method to strip markdown

Feature request: makePlainText method to strip markdown completely.
Use case: My client app has some fields that allow formatting via markdown (e.g. the description field) and others that should not (e.g. the first name and last name fields).  I'd like to be able to strip any markdown from the content before displaying it in these fields, just in case the user has entered any.
I realise there are other javascript projects around that do this, but it would be great for showdown to support it directly.

If all content is parsed through Showdown (as it seems the case), you can escape the "magic" markdown characters to prevent anything to be parsed as markdown.
This is best accomplished by a pre parser or an extension, dependeing on use case. (See fiddle)
showdown.extension('escapemd', function() {
  return [{
    type: 'lang',
    regex: /[\][=~`#|()*_-]/g,
    replace: "\\$&"
  }];
});

We're currently looking to improve showdown with automated tests in all browsers and a proper domain and webpage. If you like our work, please donate!! Your contribution will be greatly appreciated.
https://www.paypal.me/tiviesantos

@projectitis This this help you?

Sorry, I haven't had a chance to implement it yet, but it looks like the perfect solution. Thanks!


zed-components fails when built with colcon

Preliminary Checks

[X] This issue is not a duplicate. Before opening a new issue, please search existing issues.
[X] This issue is not a question, feature request, or anything other than a bug report directly related to this project.

Description
Building zed-ros2-wrapper(Foxy - SDK v3.5.x tar ball) with colcon generates and error that a file DIRECTORY is missing. Build process is run in a docker build senario. Building with the latest commit on master was succesful so the issue seems to be isolated to the 3.5 foxy release.
Steps to Reproduce
Build the github release for foxy v3.5 with colcon/ament_cmake
Expected Result
There is no file named DIRECTORY and i don't know why CMake looks for it really. The expected results is a successful build.
Actual Result
Build fails
ZED Camera model
ZED2
Environment
Tegra for linux, jetpack 4.6
Jetson AGX Xavior
Docker
zed-ros2-wrapper release 3.5 for foxy

Anything else?
Console error:
CMake Error at cmake_install.cmake:69 (file):
file INSTALL cannot find
"/opt/ros/foxy/src/zed-ros2-wrapper-foxy-v3.5/zed_components/DIRECTORY": No
such file or directory.

Failed   <<< zed_components [2min 58s, exited with code 1]

This has been fixed with this commit:
https://github.com/stereolabs/zed-ros2-wrapper/commit/0527f71a94da504c833dfd7bb812bc4d75b157cc
Let me know if you can compile by modifying the zed_components/CMakeLists.txt file as illustrated

Yes it was possible! Would it be possible to make a cherry pick that change and edit the 3.5 foxy release? If not it's ok to just checkout that commit id instead. Thanks!

A new release with the fix has been tagged:
https://github.com/stereolabs/zed-ros2-wrapper/releases/tag/foxy-v3.5.1


[Bug] The character '-' is invalid ascii key code in default_config/.vindrc

The 4.3.1 release is using a default config file in default_config/.vindrc and there's an error when launching the portable 64 bits release. The log says :

[Message] E: Invalid Syntax (L:277)
[Error] An runtime exception occurred from class std::vector<class vind::core::KeyCode,class std::allocator > __cdecl vind::core::parse_pure_one_character_command(char). The character '-' is invalid ascii key code. (...\win-vind-4.3.1\default_config.vindrc, L:277) (enum vind::SystemCall __cdecl vind::bind::SyscmdSource::sprocess(const class std::filesystem::path &,bool))

The 4.2.1 has not this problem (default_config/.vindrc is inexistant in my config)
Please note that I was just launching win-vnid for a 1st use and my .vindrc (my own) is empty for the moment.
Environment (please complete the following information):

Windows 10 Enterprise
OS Type: 64bit
OS Version: 21H1
OS Build: 10.0.19043
win-vind Version: 4.3.1
win-vind Type: zip
Is it reproducible?: Yes

Thanks for the detailed bug report.
This is an error in the process of determining whether or not shift is required when entering certain ascii codes.
I will try to reproduce it by preparing a similar environment.

I installed a new Windows 10 Enterprise Evaluation 21H2 10.0.19044 64bit and tried to run win-vind 4.3.1 portable 64bit. However, I was not able to reproduce the same issue.
Do you have any idea what might be causing the problem, such as a special keyboard layout?
I will continue to try to reproduce the problem.

Hi,
thank you for your answer. I'm currently using a french keyboard layout (nothing specific with it). I tried on another computer (win10 home, 10.0.19044, 21H2) and I get the same error ... (exactly on the same line). I'm just starting to use win-vind and maybe, by just unzipping the portable release, I could have missed something ...?
Or, maybe, by first trying the 4.2.1 release and then the 4.3.1, there's a config file somewhere I did not see ... ?

Hi. Thanks for the quick answer.
I just tried the French keyboard layout on Windows and was able to reproduce the same problem!
I will implement the patch for the French keyboard layout as soon as possible.
By the way, Portable is completely independent, so there is no conflict.

Added support for the French keyboard layout and for entering accented characters in the virtual command line. However, accented characters in .vindrc are not yet supported.
The attached executable is a build of the above commit and has not been fully tested. I will release a stable version as 4.3.2 later, so please make sure to update it.
And, please let me know if it works.
Thanks!
win-vind_c3f6177_64bit_portable.zip

Added support for the French keyboard layout and for entering accented characters in the virtual command line. However, accented characters in .vindrc are not yet supported.
The attached executable is a build of the above commit and has not been fully tested. I will release a stable version as 4.3.2 later, so please make sure to update it.
And, please let me know if it works.
Thanks!
win-vind_c3f6177_64bit_portable.zip

Hi,
I confirm it's working without errors, congrats 👍 (I got a 1st error message regarding the impossibility to move cursor ... but was unable to reproduce)

That's good! Thanks for the great contribution!


Comparison to Uber's react-map-gl

has anyone compared this to react-map-gl by uber?

if so, what were your findings?
for example we are skeptical of building the style object and passing it in to control everything instead of using the semantic style of this library. any and all thoughts would be helpful. sorry for hijacking the issues board, we hope to use this library if its appropriate for our needs (and would be contributing to it also).

@alex3165 started to work on this library since react-map-gl is just a really lean wrapper around mapbox-gl. This is why there are a couple of React-friendly abstractions in this library around layers, markers, popups, etc. We basically wanted to cover the 90% use case, that shouldn't require the user to write mapbox-gl code directly.
While this means that we sometimes have to implement new features as opposed to react-map-gl, this doesn't mean that you can't use them in a similar way. You still get access to the internal mapbox-gl map instance for instance.
react-map-gl brings a big feature of its own to the table: overlays. They have a lot of interfacing overlays for their map, that are relatively easy to use. We haven't implemented something like this here yet, but we're aware of it.
As you can see, the goals of the two libraries are quite different. I'm happy to give you more details on this, and I think @alex3165 can help you as well :)

Hey @z0d14c to complete what @philpl said, this library aims to abstract Mapbox-gl features without using their API but only the component it is exposing (Marker, Layer, Feature, Popup ...) as opposed to react-map-gl which doesn't provide these components but give you overlays for data visualization purposes (ChoroplethOverlay, ScatterplotOverlay, DraggablePointsOverlay, SVGOverlay and CanvasOverlay) and many more using their library Deck.gl. I released an article explaining why I built react-mapbox-gl along with the first version of the library<EMAIL_ADDRESS>

Also I recently merged a PR which include a component projected-layer which can be used to build many custom overlays. We can imagine a third library which use this projected-layer and provide different overlays for data visualization purposes as well.

Thanks so much @alex3165 @philpl for the timely replies. We don't currently leverage too many of the mapbox-studio features per se other than using their base layers. What we do is add custom image layers and geojson polygons/polylines/markers on top of the mapbox vector base layer. Is react-mapbox-gl currently supportive of these features? If we absolutely have to, is it easy to access the MapboxGLJS instance? Thank you again :)

Yes react-mapbox-gl support these features polygons, polylines and markers, you can have a look at this example: https://github.com/alex3165/react-mapbox-gl/blob/master/example/src/all-shapes.js which includes all the supported shapes.

Thanks for your answers. I will close this question for now as you have been more than sufficient in responding to my concerns. I would say that it may be a good idea to have a FAQ question dealing with the comparison to uber's react-map-gl. Perhaps I or someone else can contribute to this in the near future.


Add partial timout support

Partial implementation of timout support (#2) for status, stat_basic and stat_full.

I feel like it would be useful to also add timeout support to RCON as well, probably as a field taken in RconClient::new, but this is a great start. Thanks for taking this on!

The other option is to add a timeout field to every function for RconClient. That might be better because it gives more control to the user but what do you think?

I've had some spare time these past few days to look through this, but I think it's important to let people opt in to new features, the functions here all take a Duration argument, but it might be nicer to take Option<Duration> instead to give people an easy out if they want to wait indefinitely for some reason.
Also, I don't think just moving everything into an async block makes for very well-designed code (not that this crate is a marvel or anything), and I will probably rewrite it to architect it differently.
Give me a bit of time to think over how to make the API change least annoying (or most useful), and I'll hopefully have this done in a few days.


Remove admin app and all references to it.

I believe this is complete, not sure if it will currently break deployment.
Working on puppet next.

:+1:


Automatically set workflow to full concurrency with 75% memory usage

Add a button to automatically scale up the memory so that full concurrency of the submission will take ~75% of available memory

Currently an ugly solution is in-place. I'll get around to making a cleaner solution later


Create Parameterized unit test and Fix some issues

Create Parameterized unit test bases in BrowserTest and VersionTest.

Create TestClass per Browser for more isolated unit tests
Create Test for Version detect (parameterized) based in VersionTest
Upgrade junit version from 4.7 to 4.11

Fix some Issues #82 #92 #72
TODO: delete duplicated tests

This have a little bug in test, fixing

Fix some Issues #82 #92 #72

Sorry, but timing of these changes is not good. Just before you there was a pull request with changes to some of the same classes and due to the formatting that you changed merging this is a pain now.
I would have also preferred individual pull requests instead of one with various kind of changes.

Sorry about that... but you have to work in code style just for avoid the bloody pain with merges.
I'll work in some performance issues, I have another changes with at least 90% more efficient :+1:

I've committed fixes for #75 #82 #86 and #92 to trunk today.

I will fix the merge


csruntime: add option of specifying runtime UUID on the command line

The user may employ persistent runtime UUIDs by specifying them on the command line. This option
is disregarded when security is enabled.

One minor thing.
Don't do
x = get("value") if get("value") else "other value"
use
x = get("value") or "other value"

ok


Time benchmarks steps.

Summary:
We would like to know how long the build, cluster start and benchmark
steps are taking. We add timestamps when each step starts.

Btw, you can get the perf run duration checking the JSON dump. There is a "startTime" and "endTime" fields ;)


Fixed TypeScript typings so TypeScript 2.5.2 does not complain

TypeScript 2.5.2 complains about the typings because namespaces are not supposed to have default exports (only ES6 modules). This pull request fixes the typings by lifting the default export up to the module level.

It would be great if you could push a release with this fix. Otherwise, using this library with TypeScript becomes seemingly impossible if the using project itself also depends on @types/react (which it reasonably should).


releasbility job is being centralized to knative/release

Related: https://github.com/knative/release/pull/192

This is great!
/lgtm
I would say depends on knative/release#192
/hold until the dependent PR is merged

/unhold