.Net Kernel Streaming Option 2 (WIP)

Motivation and Context

Description

Contribution Checklist

[ ] The code builds clean without any errors or warnings
[ ] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[ ] All unit tests pass, and I have added new tests where possible
[ ] I didn't break anyone :smile:

Dropping this as the Option 1 was the decided one.


refactor PathItemIcon/PathItemInfo into their own connected components

untagging review as I'm gonna move badges into the component too

ready again!

@chrisnojima ready for another look!

Cool thanks!


[Bug] CTRL+A with ÀÉÈÇ letters

Describe the bug
Once i typed those letters: ÀÉÈÇ i can't CTRL+A anymore unless i click on another window then back on notepads again
To Reproduce
Open new Notepads, type those characters ÀÉÈÇ and select everything using CTRL+A
Expected behavior
it should select all text
Desktop (please complete the following information):

OS: Windows 10 1903 (18362.295)
Version v<IP_ADDRESS>

How did you type those letters in the first place?

I bound those letters to macro keys on my corsair k95 keyboard using iCue because there is no other way to type them on azerty keyboards

Can you share the exact macro you use? Can you also record a short viedeo to describe the current behavior? Thanks!

It's just the "TEXT" feature in iCue https://i.imgur.com/xCNEvmo.png
video.zip
i type random letters, then CTRL+A, it works
then i type the ÀÉÈ characters, i CTRL+A, doesn't do anything, i click another window, then back on Notepad, and i can CTRL+A without problems

Is this issue still happening to you? If it is, can you send this issue to WinUI repo for Microsoft to take a look at? Since this is related to WinRT RichEdit control.


server: honor container stop timeout from CRI

@mrunalp @sameo PTAL
Signed-off-by: Antonio Murdaca<EMAIL_ADDRESS>

👍 have we run e2e on this?

have we run e2e on this?

not yet eheh still have to test #508 and #505 :(

Needs rebase.

@mrunalp rebased

I'll run the e2e on this.

The tests passed fine :+1: LGTM


Can't manage to receive data

Hi, we're trying to use your library with Traktor Pro 3 in a Mac. We followed the instructions described in the Readme, but we do not receive any data. Do we need to run any script? We doubled checked that the traktor broadcasting is sending data to port 8080. Thanks!

Hi,
No, the instructions in the README are sufficient. I'm not sure what you mean by the Traktor broadcasting, it's not mentioned anywhere in the README that you need to configure broadcasting.


Update package.json for TypeScript 1.6 & up

TS 1.6 came out with features like extending HTMLElement, and grunt-typescript won't update for it.

...as a Halo fan, I very much appreciate being your build #117.

"grunt-typescript": {
"version":"0.7.0",
<EMAIL_ADDRESS>"dependencies": {
"typescript":{
"version":"1.6.2",
<EMAIL_ADDRESS>}
}
},
I added this to my dependency to update the typescript version --> but abstract classes won't work

@groege  Did you find any resolution with this?

switched from "grunt-typescript" to "grunt-ts" --> almost the same just up to date ;)


Bug: Cannot install java on WSL2 system.

Bug report

When I try to install java, sdkman reports archive is corrupted error.
$ sdk install java 17.0.9-ms
Validate java 17.0.9-ms for linuxx64: valid
Validation URL: https://api.sdkman.io/2/candidates/validate/java/17.0.9-ms/linuxx64

Downloading: java 17.0.9-ms

In progress...

*   Trying <IP_ADDRESS>:443...
* Connected to api.sdkman.io (<IP_ADDRESS>) port 443 (#0)
...
0%* Connection #2 to host download.visualstudio.microsoft.com left intact

Downloaded binary to: /home/shanai/.sdkman/tmp/java-17.0.9-ms.bin (HTTP headers written to: /home/shanai/.sdkman/var/metadata/java-17.0.9-ms.headers)
Get post-installation hook: https://api.sdkman.io/2/hooks/post/java/17.0.9-ms/linuxx64
Copy remote post-installation hook: /home/shanai/.sdkman/tmp/hook_post_java_17.0.9-ms.sh
A Linux 64bit post-install hook was found for Java 17.0.9-ms.

Repackaging Java 17.0.9-ms...
zip I/O error: No such file or directory
zip error: File not found or no read permission (/home/shanai/.sdkman/tmp/java-17.0.9-ms.zip)

Done repackaging...
Cleaning up residual files...
Processed binary as: /home/shanai/.sdkman/tmp/java-17.0.9-ms.zip
Completed post-installation hook...

ESC[1;31mStop! The archive was corrupt and has been removed! Please try installing again.ESC[0m

$ ls -l ~/.sdkman/tmp
total 8
-rw-r--r-- 1 shanai shanai  919 Nov 24 09:44 hook_post_java_17.0.9-ms.sh
-rw-r--r-- 1 shanai shanai 1323 Nov 24 09:44 java-17.0.9-ms.headers.tmp

Any other java distributions than 17.0.9-ms fail too. Network connection is normal (can connect network with web browser). Re-tried several times during a week but no luck.
To reproduce

$ sdk install java 17.0.9-ms

System info

Windows11 WSL2 (Ubuntu 22.04 <IP_ADDRESS>-microsoft-standard-WSL2 #1 SMP Thu Oct 5 21:02:42 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux)
bash  5.1.16(1)-release
script: 5.18.2/native: 0.4.3
zip:  Zip 3.0 (July 5th 2008), by Info-ZIP
tar: tar (GNU tar) 1.34
gzip: gzip 1.10

Hi @ruimo!
Have you defined any aliases for zip, curl, gzip or tar?
Does the file /home/shanai/.sdkman/tmp/java-17.0.9-ms.zip exist after the installation failed?

Hi, @helpermethod,
No aliases:
$ type zip
zip is hashed (/usr/bin/zip)
$ type curl
curl is hashed (/usr/bin/curl)
$ type gzip
gzip is hashed (/usr/bin/gzip)
$ type tar
tar is hashed (/usr/bin/tar)

No zip files in ~/.sdkman/tmp as shown in the first post.

Hi @ruimo!
Could it be that you are you behind a proxy?


Correctly free EVP_MD_CTX in OpenSSL

soter_sign_ctx_t structures store both EVP_MD_CTX (to keep the digest algorithm used for signatures) and EVP_PKEY_CTX (to keep the key used for signature). The key is actually shared between those structures but EVP_MD_CTX assumes ownership over it, with EVP_MD_CTX_destroy() freeing the key. EVP_PKEY structures are refcounted so sharing the key should be safe... if we make the correct precautions to avoid freeing the key after it has been freed. EVP_PKEY_CTX keeps track of that, but we need to free EVP_MD_CTX first and then proceed to freeing EVP_PKEY_CTX and maybe the key it has been managing.
tl;dr: manual memory management is hard.
This sleeper bug is presumed to be responsible for occasional segfaults when running JsThemis. Interestingly, the crashes do not reproduce with any other wrapper. Furthermore, BoringSSL code uses correct freeing order since the beginning. "Coincidence? I don't think so".

Maybe we should consider running tests under some kind of leak detector.

we already use valgrind for leak detection


Trying to connect with MySQL

Tried to install and configure MySQL to handle storing relationships. Used commands below to install and test MySQL.
sudo apt-get install mysql-server mysql-client --set password spdx
sudo apt-get install libdbd-mysql-perl
sudo apt-get install mysql-client-5.5

Getting errors with connection in program. Set username and passcode to spdx during setup. Receiving error below:
DBI connect('database=spdx;host=localhost','spdx',...) failed: Access denied for user 'spdx'@'localhost' (using password: YES) at test.pl line 22.

Then tried an update to my Virtual Machine to see if that resolved the issue.

Decided to uninstall and and try SQLite.


Exception using send() function

I've tried to run my tests using the Supertest library, that includes Superagent library.
Here is a basic example of test I want to execute in my project.
const messageObj = {
  id: "123456",
  message: "blablabla"
};
const headers = {
  "Content-Type": "application/json",
};
await supertest
    .post('/')
    .send(messageObj)
    .set(headers)
    .expect(200);

I run my tests with the following command : yarn run jest your_test_file.test.js
I got an exception with this and here is the error message :
TypeError: mime.lookup is not a function

And this error refers to the send() function because if I'm running the same test without sending data (without using send() function), it works !
So, could you please check about your send() function because I can't use it anymore during my tests.

I notice that it has been fixed after doing a yarn install.
Therefore, I'm closing this issue.


Use fast gas price strategy to calculate gas price

Although the gas price strategy is set to fast, it was totally ignored in the whole project by using the direct RPC web3.eth.gasPrice. Using web3.eth.generateGasPrice() instead calculates the gas price based on the strategy.

LGTM


Updating a session with 2 authors while being the second author errors out

Problem is that when the second author is editing, the inferred_params that get merged in https://github.com/agile-alliance-brazil/submissions/blob/master/app/controllers/sessions_controller.rb#L73 is incorrect.
Need more logic for this to work.

How did you find that out?

Alex Freire reported and I looked at the code a bit ;)
Hugo Corbucci
Skype user: hugo.corbucci
Twitter: hugocorbucci
On Mon, Feb 29, 2016 at 5:53 PM, Cecilia Fernandes<EMAIL_ADDRESS>
wrote:

How did you find that out?
—
Reply to this email directly or view it on GitHub
https://github.com/agile-alliance-brazil/submissions/issues/201#issuecomment-190491521
.


Verify basic analytic query in QScript

Verify that QScript generated by a basic analytic query is optimized correctly.
SELECT
  state,
  COUNT(*) AS count, SUM(pop) AS sum, AVG(pop) AS avg, MIN(pop) AS min, MAX(pop) AS max
FROM
  `/zips/`
WHERE
  pop > 100000
GROUP BY
  state
ORDER BY
  max, state
OFFSET 1
LIMIT 100

I think this works as of #1640. The QScript looks right to me, but we’ll have to test it on MarkLogic (or something) to verify.

@sellout I added an ORDER BY, OFFSET, LIMIT too, just to make it more representative of the type of query the front-end would generate.

So, I think this new query also works (although it’s difficult to tell until #1628 is merged … or until it’s tested on a connector).

@sellout Then let's get #1628 merged as it will enable minimally functioning connectors! 😄

#1628 is merged, but that just shows us the plan in a readable way – I gotta get #1640 merged now …

@wemrysi Now that #1640 is merged, could you try this query on MarkLogic? I think the plan is correct at this point.

I made a minor modification to the query to sort max DESC for a bit more interesting output and got
{ "state": "NY", "count": 3, "sum": 317987, "avg":<PHONE_NUMBER>66667, "min": 100027, "max": 111396 }
so :+1:

@sellout It'd be nice to codify this in a test so we can ensure that it won't regress.


Fixed Snippet in VCS

Is your pull request related to a problem? Please describe
closes #9

Thank you @Zenix27 for fixing this!


Catch unserialize() errors

Catches any exceptions/errors that could be thrown by unserialize() when retrieving cache data, e.g. if the cache file has become corrupted.

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

This is wrong. Cache does not corrupt magically. And just always return false is bad, it should throw an error, and it actually only throws an E_NOTICE.
At least there should be some switch to have errors instead of false.
Also the phpdoc needs to reflect that it ... simply completely ignores errors..
Imho this change is just wrong.
https://www.php.net/manual/en/function.unserialize.php

Warning
false is returned both in the case of an error and if unserializing the serialized false value. It is possible to catch this special case by comparing data with serialize(false) or by catching the issued E_NOTICE.

craftcms/cms#13164 suggests otherwise.

Suppressing errors is a bad practice, what is suggesting otherwise in that issue from craftcms?

https://softwareengineering.stackexchange.com/questions/219788/is-error-suppressing-bad-practice
https://netgen.io/blog/modern-error-handling-in-php
https://dev.to/anastasionico/good-practices-handling-error-and-exceptions-in-php-5d8c

I tend to agree with @ailmanki on this issue. It is better to find a root cause rather than siliencing the error which would cause cache non-functional thus causing load on DB and other resources.

In the case of craftcms/cms#13164, the root cause is file corruption; not an easily reproducible/fixable logic bug.
And this is just the cache layer we are talking about. An application should be able to gracefully recover from a corrupted cache file.
@samdark Would you be open to an amended PR where before returning false, the exception is logged out via ErrorHandler::logException()?

Technically the E_NOTICE doest not stop execution.
See https://3v4l.org/e4TMu
It outpots the var_dump just fine.
When disabling the display of errors, it works as you would want.
See with error display disabled:
https://3v4l.org/v8hWe
I fear introducing a try catch, slows down execution, and just cache we want to be as fast as possible.

@brandonkelly "file corruption" by itself sounds serious enough to reproduce/fix. It's not something that should be ignored.
I don't think that the app should ignore corrupted cache file and leave it like that effectively disabling cache entirely. A clutch that could solve it is, in case of file cache, do delete the cache file in question in this case and log that it happened. At least that should not lead to cache disabled. But that might slow down the cache in normal flow due to try-catch itself. I have no idea on how significant that might be for a product such as CraftCMS though.
@My6UoT9 Yii2 raises severity of PHP notices so that likely won't work as in normal PHP. I agree that try-catch will slow things down.

@samdark I had to test this. So it still works, invalid cache data still leads to a E_NOTICE, Yii is not altering that.
error_reporting(E_ALL & ~E_NOTICE); so disabling the reporting of E_NOTICE does what I would expected.
Disabling E_NOTICE in production seemed to me pretty common.
But I had this wrong:  ini_set('display_errors', '0'); Yii will still show the error, but I guess that depends on further configuration inside Yii.


Mouse Event is not working with ClickAwayListener on MAC

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example:
Steps:

When we click on Component context menu is not opening in Mac

Current behavior 😯
onClick on Component context menu is not opening in Mac
Expected behavior 🤔
When we click on Component context menu should be open in Mac
Context 🔦
No response
Your environment 🌎

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Hey @adnank007, thanks for the report 😃
Please provide a minimal reproduction test case with the latest version. This would help a lot 👷. A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!

Hey @DiegoAndai,
Here is some extra info about the case.
We had the ClickAwayListener with the mouseEvent="onMouseDown", after that we changed the mouse event to "onMouseUp" (just for UX, to have better behavior in case of the user holds the click for any reason).
By doing that we didn't face any issues on Windows, but on Mac with Chrome v113(the latest stable) we are suffering a flickering/blinking strange behavior that renders the component for an instant (less than a second) and then hides the Menu component. Didn't test in other browsers.
There isn't any error in the console complaining about it.
Screenshot of the code change that we did to fall into this behavior.

Hope that helps.
Agustin.

@agustinsilvano on the issue's description, @adnank007 mentioned that the issue is when clicking "on Component context menu". Is this related to opening the context menu with a right click? If so, I think the cause for the difference between "onMouseDown" and "onMouseUp" is: https://github.com/facebook/react/issues/5531
If not, I can't help further without a repro case (for example a codesandbox example), as you can see in this codesandbox example, "onMouseUp" is working properly, I'm testing on a Mac with Chrome 113 as well. It doesn't close when opening the context menu, but that would be expected as per https://github.com/facebook/react/issues/5531


Configure grafana image to allow anonymous access

This is required for using kube proxy (instead of exposing IP addr -- helpful for demos/gcpnext).

This change is

Jenkins job mixer/presubmit passed

Jenkins job mixer/presubmit passed


Issue 39 create auto test cases for database models

Adds the testing cases for models "Profiles" and "User"
[1] The pull request title has an issue number
[0] The change works by "Smoke testing" or quick testing ## This only provides a preliminary structure of the test classes for 2 of the DBs, still needs integration testing with the actual DBs as well as rest of teh testing cases fro other DBs.
[1] The change has tests
[1] The change has documentation
Related issue

Resolve #39

You'll need to fix the flake8 linting errors before this can be merged.

this it conflicted with main branch
please update this branch from main and resolve the conflict

Hi yunho, we have decided to no longer use the tests.py file and instead divide the tests among different files representing diff types of testing. So this file here is no longer needed and can be deleted.

I don't know why the tests are failing here, could it be it is running the wrong version (main's version) of models.py?
Anyways we have tested the new code on our end and it has passed all tests without error.

Hi, here is the update why we should use string value instead of decimal for our price value ~

https://uuid.medium.com/serialising-monetary-amounts-7409acd6f38d
https://stackoverflow.com/questions/35709595/why-would-you-use-a-string-in-json-to-represent-a-decimal-number

there are two main reason:

Avoiding Floating-Point Errors and Limitation.
Better for parser and displaying on different language.

I don't know why the tests are failing here, could it be it is running the wrong version (main's version) of models.py?
Anyways we have tested the new code on our end and it has passed all tests without error.

I believe the reason is that you haven't committed your migrations. All the errors disappeared for me as soon as I ran makemigrations and migrate. But before you do that, maybe address the changes @0XFF-96 requested above. Then this PR will be ready to be merged into main 😎


Candy Chat

Hi,
Am working on candy chat.
For me connection established with server for anonymous users.
But thing is, after connected status my screen is empty in IE9.
Also , in chrome and firefox its always shows connecting....
Please assist me to fix this problem,,,,

Hi,
Can anyone help me to fix this issue?
Am waiting for the reply.....

Can you show me your initialisation code of candy?
Also please take a look at our FAQ: https://github.com/candy-chat/candy/wiki/Frequently-Asked-Questions

I have fix all issues.
Now its working gud.
Thanks for ur kind consideration.
Is it possible to share screen through candy chat???
Is it possible to change status programmatically??

Sharing screen is not possible with Candy.
What do you mean by changing status programmatically?

Hello Michael,
   Am looking for your suggestions for the following queries.Hope u

will have chance to answer my queries.
Am using external DB .
I want to change presence of status message pro grammatically.
I want to create chat rooms dynamically from candy chat.
Thanks for your support.
Regards,
Rathinavelu.A
On Mon, Feb 13, 2012 at 9:23 AM, Michael Weibel <
<EMAIL_ADDRESS>
wrote:

Sharing screen is not possible with Candy.
What do you mean by changing status programmatically?

Reply to this email directly or view it on GitHub:
https://github.com/candy-chat/candy/issues/77#issuecomment-3935023

--
Regards,
Rathinavelu.A,
Software Developer,
Triad Infotech.
+918754455996
+973 39776451

Take a look at the XEP standards for those features.


consumer group support

WIP

add tests
support auto and manual commit as in Java API
more manual tests

Have you looked at https://github.com/bsm/sarama-cluster ?

Ahh sorry I open the PR a bit to early (not done yet). This is based partly on the code of https://github.com/bsm/sarama-cluster. However it does use the OffsetMananger from sarama directly + test / functional test will be done sarama style. And tbh I think it would be nice to make this a part of sarama at some point in time so it is on par with the current Java consumer ;-)

I will close this and reopen after it is done :-)

OK cool, I've been meaning to tackle this for a while now.
Take your time, I'm busy with other things right now and won't have the time to review any big PRs for the next couple of weeks anyway.


[$1000] Workspace - Expensify download link in the welcome message is not hyperlinked

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to staging.new.expensify.com
Invite a member to the workspace
Navigate to the workspace chat with the invited member

Expected Result:
https://use.expensify.com/download
link in the welcome message is hyperlinked
Actual Result:
https://use.expensify.com/download
link in the welcome message is not hyperlinked, unless the message is edited and saved
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.68-15
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/8f6b3662-3e57-43e3-890e-742ae9c25dc0
Expensify/Expensify Issue URL:
Issue reported by: @alitoshmatov
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694444208170039
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0130840f78177f0f3f
Upwork Job ID:<PHONE_NUMBER>412563968
Last Price Increase: 2023-10-06

I have reported this issue before https://expensify.slack.com/archives/C049HHMV9SM/p1694444208170039 . Can someone check and confirm if I indeed reported it earlier?

It does look like the same report as this one - I will add you as the reporter to this job @alitoshmatov!

@situchan can you check this proposal https://github.com/Expensify/App/issues/27290#issuecomment-1717183104
It looks like we're still collecting proposals!

@situchan can you check this proposal https://github.com/Expensify/App/issues/27290#issuecomment-1717183104
Let me know if you'd like to see more proposals

@situchan can you check this proposal #27290 (comment)
Let me know if you'd like to see more proposals

@Christinadobrzyn I'd like to see more proposals. @Krishna2323's solution doesn't seem ideal to me.

I don't think we should alter data to send to backend.

Won't this break showing all existing invite messages so far? Also, note that email/sms is sent for that invite message in backend. I am afraid that will cause regression of unexpected escaping/unescaping html.

@Krishna2323 make sure that your proposal is thoroughly tested in all possible cases before claiming.

@situchan let me know if you want to see more proposals!

@situchan let me know if you want to see more proposals!

yes, no satisfactory proposals yet

It seems to be backend issue. we should update welcome message on backend side. Of course, we can handle this on frontend side but it's not efficient.

Agree, the root cause is how the invite message is being saved to the backend: props.action.message[0].html is the same as props.action.message[0].text even when it contains a link:
{
  "html": "You have been invited to User's Workspace! Download the Expensify mobile app at use.expensify.com/download to start tracking your expenses.",
  "text": "You have been invited to User's Workspace! Download the Expensify mobile app at use.expensify.com/download to start tracking your expenses.",
}

When the member invite form is submitted, it should save as:
{
  "html": "You have been invited to User's Workspace! Download the Expensify mobile app at use.expensify.com/download to start tracking your expenses.",
  "text": "You have been invited to User's Workspace! Download the Expensify mobile app at use.expensify.com/download to start tracking your expenses.",
}

The welcome message doesn't need to be modified, however, there should be a check in the backend to check for links in invite messages.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01706570198b5c97c9?s=1110580755107926016

hey, @cng008

The welcome message doesn't need to be modified.

What do you mean? The welcome message should be modified to include a download link on backend side. I can't understand you. Can you clarify this?

@Pluto0104 Now I'm not sure what you mean by "download link on backend side". I mentioned that the welcome message doesn't need to be modified since it's also being used for email/text. I suppose I could have left that out of my comment
Sorry for any confusion! I'm just starting off my web dev career

@cng008 Ah, I understand you now. I initially thought that the welcome message was generated by the frontend, then relayed to the backend and sent to invited members. However, it appears that the backend doesn't handle any links or emails during the process of sending the welcome message. Therefore, we'll need to adjust this logic.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Expensify download link in the welcome message is not hyperlinked
What is the root cause of that problem?
html is not formated for link
What changes do you think we should make in order to solve the problem?

fix in the backend
we need pass an html

    sendInvitation() {
        Keyboard.dismiss();
        const parser = new ExpensiMark();
        const parsedWelcomeNote = _.unescape(parser.replace(this.state.welcomeNote));

we need pass unescape char to backend
https://github.com/Expensify/App/pull/21912/files
Result
email
https://github.com/Expensify/App/assets/16595846/ed28f63c-27ed-4b5e-89cd-ab677b1c3a59
phone
https://github.com/Expensify/App/assets/16595846/74a11e38-29b1-48af-a9d1-a9ddba757ba6
@situchan verified the invite scenario
Note: when we send use.expensify.com/download string to mail/sms that will be automatically converted to link. so backend nothing to convert as link here.

@pradeepmdk did you see this PR?

@Pluto0104 Yes i verified that that more about escape  HTML special chars and include my proposal as well

@pradeepmdk how do you think about this?

on edit time we are only sending the html data to the backend.  so I am not sure that is up to @situchan  and the internal team.
currently backend side whatever we are sending from the client side they are using.. see the example here when I am sending escape char they storing same way.

so we can able to fix this on the client side and no regression.

reviewing proposals

fix in the backend

@pradeepmdk can you please clarify what to fix in backend?

@situchan Before storing in the they need converted HTML.
but as per my understanding backend not doing such a flow in any other place. always client side we are doing parsing as an HTML. so we can go with the second one.

@pradeepmdk If I send &, it's unescaped as &

@situchan that is the expected one right? because now also when you send this & mobile you can get same as this. but in the mail, it will unescaped to &

@pradeepmdk you mean this already happens on production app?

yes @situchan  when you invite mail its will convert & -> & but mobile sms & -> &

can you list again all the cases (chat, email, sms) before-fix and after-fix when send &?

@pradeepmdk more cases:

web notification
android push notification
ios push notification

@situchan Android and ios working fine.. but not sure how to test the web because in the web i am not receiving any notification. do you have any steps for that?
https://github.com/Expensify/App/assets/16595846/6c8a2189-dbb8-4171-810d-11a7acedc356

@situchan web notification also tested
https://github.com/Expensify/App/assets/16595846/e716f55e-9996-4f89-a648-994334558d7b

@situchan bump;

Let me know what you think of the proposal @situchan or if you'd like to see more!

I'd like to get engineer's thought whether to fix in backend or frontend
🎀 👀 🎀

Let's fix this on the backend since that is apparently how we do it.
Unfortunately, I don't have time to work on this right now. I gonna unassign myself and assign internal label.

okay... I think melvin didn't assign an engineer because I added the internal label
@Christinadobrzyn could you reapply the internal label so that someone from the engineering team is auto assigned?

@hayata-suenaga Internal may not help You can remove and re-add Engineering label

🎀 👀 🎀 to pull up engineer

@Beamanator let me know if you don't have time to work on this. I can find someone else

@hayata-suenaga that would be great if you could find someone else, but if this is super high priority for any of your projects I can work on it

asking for a volunteer here

@situchan @hayata-suenaga
what about this different behavior

Current one:

mail: & -> &
sms: & -> &
chat: & -> &

as per this if we send an escape character we have issues with the mobile SMS box
https://github.com/Expensify/App/blob/main/src/libs/actions/Policy.js#L397-L409
previous code:
 welcomeNote: _.escape(welcomeNote),
here we are escaping the & -> &. when we remove the escape it will send as it is.
but still, we can send escape characters manually. so at the time in sms box will have &
frontend:
but we can use Unescape to cover both cases. https://github.com/Expensify/App/issues/27290#issuecomment-1732189422

cc: @cristipaval as you already fixed SMS issue in backend

Thanks for cc'ing me @situchan!
At first glance, this issue isn't a regression after the fix I worked on. But I can take this one over. It doesn't have a high priority, so it's OK to investigate it later this week. @hayata-suenaga, would this approach work?

@cristipaval yes I assigned you to this issue. Thank you so much for taking this over 🙇

I think we're working on a PR

hi @cristipaval or @situchan would you happen to know a status here... do we have a PR?

No PR yet. I think we're waiting for next step from @cristipaval after priority work

Do you think I can move this to weekly?

yes @Christinadobrzyn , thanks for the idea. It also is a low priority IMO, so it can wait a bit and I'll work on it when I have free cycles between some issues with higher priorities.

not overdue - working on the PR

Hoping to get some time tomorrow for this one.

Thanks @cristipaval feel free to send an update when you can!

I'm going ooo until Monday Nov 27th so going to assign another BZ teammate to monitor this until I'm back. Thanks!
Status: working on a PR!

back from ooo moving this back to daily!

hum... @situchan or @cristipaval do you have an update here. I'm a little lost 😅

No update because I haven't had time to work on this 😢

Still working on this!

Web-E PR in review. Once it gets merged and deployed to production, the App PR will be ready for review,

Web-E PR is deployed. I'll make the App PR ready soon.

App PR is ready for review, @situchan

@Christinadobrzyn is OOO until Monday.

I'm back! sorry for the delay - the old Upwork job expired so I created a new one. @alitoshmatov and @situchan can you review the payment summary here and let me know if I'm missing anything?
if that is good please accept my offer in Upwork so I can pay you.

Accepted the offer.

yes summary looks correct.
Accepted offer. Thanks

Awesome! Paid out based on this payment summary https://github.com/Expensify/App/issues/27290#issuecomment-1896239478
Closing this as complete! Thanks everyone!


[Feature Request] Add global/master audio slider

Add a slider to configure volume of entire tab.
When I figured out the preset I want with all the different slider set to specific values, but then I want the whole thing to be a bit quieter, a master slider would be very convenient

Definitely came here to post exactly this

Hello there. This has now been added in version 2.0. I'll let you know when it's released.


Remove slashes from log messages

Reduce confusion about deprecated Firebase pod

Will save this for Firebase 9 and add a change log in case there is any tooling or searching on the product names in the logs.

I'll update and merge in master after v9b merges.


Fixed crash when Baubles isn't loaded

I dont think this check is necessary as i do this in hasprobebaubles method

Honestly, this PR was a quick and lazy fix to the problem anyways. I'm not
going to make a proper fix for the issue for you, but I will explain the
problem, and how I learned to solve it. Right now, you are directly
accessing code from Baubles API in your mod's code. This means without
Baubles loaded, it crashes. What you need to do is access the Baubles code
using an interface, rather than directly accessing it. So for example:
Make an interface called IBaublesCompat. In it, add methods for everything
you want to do with Baubles.
Make 2 classes implementing this interface. One class that interacts with
Baubles like you're doing now, and another class that's a dummy file. You
can leave all the methods empty or put alternate code in to be run if you
like. Do not interact with Baubles code in this file.
Next step: Anytime you want to use the methods involving Baubles, you would
create an IBaublesCompat object, then, if baubles is loaded, set it equal
to an instance of the actual Baubles interaction class. If not, set it
equal to an instance of the dummy class. Then call the methods from that
object.
Does that make sense? I can provide code examples from when I've done it in
the past, if needed.
On Feb 4, 2018 8:20 PM, "Striker Rocker"<EMAIL_ADDRESS>wrote:
Closed #22 https://github.com/strikerrocker/VanillaTweaks/pull/22.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/strikerrocker/VanillaTweaks/pull/22#event-1457111919,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFo-rLHDxw7at9dyEvTgj-7T9g0xwnbiks5tRmV7gaJpZM4R4weF
.

Can u provide me code examples

does this PR actually work out?

Well, maybe. I wouldn't trust the method I used in this PR, it was a quick, untested bandaid to the real problem.

As far as code examples, you'll want to do something like I did to add Chisel integration to Fire's Random Things.
The interface and the classes extending it
How to use that interface

If you have more questions, you can message on Discord. I'm on Minecraft Mod Dev, and my own Discord server.


Screen Saver overrides Energy settings

This screen saver works great, but it seems to override my setting in Energy Saver to turn off the monitor after 15 minutes - the screen never turns off.
Late 2012 Mac Mini running 10.11.2 here.
Thanks.

Which version are you using? Try the latest beta version. This issue was fixed a wee while ago.
https://github.com/JohnCoates/Aerial/releases

Duplicate of #23

Closing as duplicate of #23


Inconsistent text view font

The latest release, 0.2.0, is causing the font to change in the text view as I type. Also introducing the left button has caused some really strange layout issues. For example, if I set showsLeftButton to false, the insets are rendered completely off center.

Blame #33

@AndrewBarba does it repro in the example if you just disable the left button?

@AndrewBarba I can't seem to repro this in the example. Can you give some more details? Are you also setting the left button inset?

Simply updating the library (no other code changes), went from this:

To this:

And then typing notice how the first letter is a completely different font than the rest:

Okay this stuff for frame based on insets is all just completely wrong:
        // adjust by bottom offset so content is flush w/ text view
        let leftButtonFrame = CGRect(
            x: insetBounds.minX,
            y: (insetBounds.minY + textViewHeight) - leftButtonSize.height + leftButton.bottomHeightOffset,
            width: leftButtonSize.width,
            height: leftButtonSize.height
        )
        leftButton.frame = (showLeftButton) ? leftButtonFrame : .zero

        let textViewFrame = CGRect(
            x: ((showLeftButton) ? leftButtonFrame.maxX : 0) + leftButtonInset,
            y: insetBounds.minY,
            width: insetBounds.width - ((showLeftButton) ? leftButtonSize.width : 0) - leftButtonInset - rightButtonSize.width,
            height: textViewHeight
        )
        textView.frame = textViewFrame

        // adjust by bottom offset so content is flush w/ text view
        let rightButtonFrame = CGRect(
            x: textViewFrame.maxX + leftButtonInset,
            y: textViewFrame.maxY - rightButtonSize.height + rightButton.bottomHeightOffset,
            width: rightButtonSize.width,
            height: rightButtonSize.height
        )
        rightButton.frame = rightButtonFrame

Why not just use a stack view for this?

Ya fixing the inset stuff now. It's wrong.

Why not just use a stack view for this?

Not going to involve AL layout hooks in this, I want fine control over what layout happens and when so that I can control when the text view resizes.

Yup makes sense. While you're fixing that, any chance you can decouple the font property from setting the font for text view and all buttons? I'd prefer to set the fonts individually

Agree, stripping that part

@rnystrom I'm still seeing really strange layout and font issues on 0.2.1.
On load:

After typing:

And here's my config:
        // Setup the button using text or an icon
        messageView.showLeftButton = false

        // Right button
        messageView.setButton(title: "Send".uppercased(), for: .normal, position: .right)
        messageView.setButton(font: UIFont(barstool: .branding, size: 14), position: .right)
        messageView.addButton(target: self, action: #selector(handleSendButtonTapped), position: .right)
        messageView.rightButtonTint = .barstoolBrightBlue

        // Change the appearance of the text view and its content
        messageView.font = UIFont(barstool: .branding, size: 14)
        messageView.textView.font = UIFont(barstool: .regular, size: 14)
        messageView.textView.placeholderText = "Type comment..."
        messageView.textView.placeholderTextColor = .lightGray
        messageView.textView.tintColor = .barstoolBrightBlue
        messageView.applyBorder(.top, color: .separator, size: 0.5)
        messageView.inset = UIEdgeInsets(top: 20, left: 16, bottom: 20, right: 16)

        // Capsule view
        let containerView = UIView()
        containerView.backgroundColor = UIColor(red: 0.945, green: 0.945, blue: 0.945, alpha: 1)
        containerView.borderColor = .separator
        containerView.borderWidth = 1
        containerView.cornerRadius = 3

        messageView.insertSubview(containerView, at: 0)
        containerView.snp.makeConstraints {
            $0.top.equalToSuperview().inset(8)
            $0.leading.equalToSuperview().inset(8)
            $0.trailing.equalToSuperview().inset(8)
            if #available(iOS 11, *) {
                $0.bottom.equalTo(messageView.safeAreaLayoutGuide.snp.bottom).inset(8)
            } else {
                $0.bottom.equalToSuperview().inset(8)
            }
        }

I’ll try to repro the font issue today and send another patch, I actually didn’t see this issue so didn’t make any change for it.
Sent with GitHawk

@rnystrom Thanks for the initial fix.
@AndrewBarba You can change your inset to:
messageView.inset = UIEdgeInsets(top: 20, left: 8, bottom: 20, right: 16)

Even when you're enabling the left button there is the correct space between left button and the textview. The original example uses this inset as well.

Okay thanks. Still need to figure out that initial right button position and the font issues. You can see the font issue in the screen you posted above. Is it the order I’m setting the fonts? Really strange

@AndrewBarba I had the same problem. You can fix this by settings your inset before your settings the left- and right button properties.
messageView.inset = UIEdgeInsets(top: 20, left: 8, bottom: 20, right: 16)
messageView.font = UIFont.preferredFont(forTextStyle: .body)

// Right button
messageView.setButton(title: "Send".uppercased(), for: .normal, position: .right)
messageView.setButton(font: UIFont.systemFont(ofSize: 14), position: .right)
messageView.addButton(target: self, action: #selector(onRightButton), position: .right)
messageView.rightButtonTint = .blue

If you set the inset afterwards you get weird behaviour indeed because the calculation rely on the insets.

@rnystrom I’ll have a look at the font issue today. I think we need to update the readme because it uses a 16px inset. What do you think?

Seems like we need to lock off the exact same layout mechanisms for any of these property changes.
@lenkaiser not sure I follow about the readme
Sent with GitHawk

@rnystrom Never mind, my bad. I was thinking the same code was used in the example but that works fine.
I did find the problem, the textview uses an attributed string and uses different font sizes. The first character is the correct font but all the other after that use pointSize 17.0. If I input a simple text: Jj and print the attributes we can see the difference between the 2 letters. The reason why is unclear to me yet. Any suggestions?
attributes >> Optional(J{
    NSFont = "<UICTFont: 0x7fa416c1f850> font-family: \".SFUIText\"; font-weight: normal; font-style: normal; font-size: 14.00pt";
}j{
    NSFont = "<UICTFont: 0x7fa416c17de0> font-family: \".SFUIText\"; font-weight: normal; font-style: normal; font-size: 17.00pt";
    "com.messageviewcontroller.autocompletekey" = 0;
})

@lenkaiser what’s the best way to repro the issue? If we can reproduce it in a failing unit test then fix the test that’d be ideal.
Sent with GitHawk

@rnystrom I'll work on that upcoming weekend.

Should be fixed in #59


Rebrand to free-now

Please add free-now.com email handler to the new-project template @hrzbrg

Dear happy maintainers,
we are renaming our organisation this Tuesday (2th July 2019) from mytaxi to freenowtech.
Please update necessary dependencies to and for this repo according.
Best
OSS freenowtech


WIP:NATIVE-344: Fix language not available

This PR contains a fix for showing the languageNotAvailable message.
It's implemented using a new status for the categoriesRoute (this was necessary to have access on the availableLanguages even if the actual route is not able to load).
Other than that, I cleaned up the test for morphContentLanguage (replaced snapshots with cleaner inline-checks) and added peeking for events (since that was such a small issue and highly related to the files I touched anyways).
Furthermore I had to adjust the cityContentReducer such that it would return new state objects instead of mutated old state.

Sorry again didn't see the WIP 🙈


Progress Bar in Global Replace

Add a progress bar while performing global replacement of words to show the task's status in progress.

Please refer to the commit number 3d70d380e1eb38473849dc8b559539f2bf704e14.


[Q] Is there is a way to upload the summary of offline crashed runs?

Hi
If an offline run crashes before wand.finish() the summary is not uploaded even after triggering sync.
Is there a way to upload the summary of such a crashed run?
I tried resuming and finishing the crash run, but this didn't fix it.
Theis https://github.com/wandb/wandb/issues/7227 might be related

Due to inactivity we are closing this request, please comment to reopen.


operator [N] [CI] kube-loxilb-operator (0.8.3)

Signed-off-by: backguynn<EMAIL_ADDRESS>Thanks submitting your Operator. Please check below list before you create your Pull Request.
New Submissions

[x] Are you familiar with our contribution guidelines?
[x] Have you packaged and deployed your Operator for Operator Framework?

[x] Is your submission signed?
[x] Is operator icon set?

Updates to existing Operators

[x] Did you create a ci.yaml file according to the update instructions?
[x] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[ ] Modify more than one operator
[ ] Modify an Operator you don't own
[ ] Rename an operator - please remove and add with a different name instead
[ ] Modify any files outside the above mentioned folders
[ ] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description about the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/merge possible

/merge possible

@backguynn thanks for the contribution. We will need a few changes to the CSV file before merging:

Please fill in the missing metadata fields: you can preview the rendering of the operator page using https://operatorhub.io/preview : make sure the fields in the right hand side panel are all defined, apart from the channel.
Please add a few more sentences to the description to better explain what the operator does
I think there are a few problems with the pullspec of the images you are using:

The image you defined in metadata.annotations.containerImage does not seem to be the operator image: in the deployment section I see you are using ghcr.io/loxilb-io/kube-loxilb-operator which is probably what you want to use in containerImage
The tag of the operator image in the deployment section (v0.1) does not match the version of the operator you are trying to publish (v0.8.3): I see you have an image with the right tag in your registry: you proabably want to fix that
You are using the "latest" tag in the pullspec in metadata.annotations.containerImage: you probably want it to match the version of the operator you are releasing


The Compost TURD 2 Compost Plants are available via blueprint/etc without selecting the TURD

Mod source
Factorio Mod Portal
Which mod are you having an issue with?

[X] pyalienlife
[ ] pyalternativeenergy
[ ] pycoalprocessing
[ ] pyfusionenergy
[ ] pyhightech
[ ] pyindustry
[ ] pypetroleumhandling
[ ] pypostprocessing
[ ] pyrawores

Operating system

=Windows 10

What kind of issue is this?

[ ] Compatibility
[ ] Locale (names, descriptions, unknown keys)
[ ] Graphical
[ ] Crash
[ ] Progression
[X] Balance
[ ] Pypostprocessing failure
[ ] Other

What is the problem?
The syrup-consuming prod-boosted composter can be placed from imported blueprints (or via the building selection tool in Factory Planner and probably other similar things) without having selected the TURD.  It seems likely that the opposite is also possible.
With Factory Planner at least, it's easy to accidentally place the wrong composter, as all 8 (4 tiers, 2 types) are in the same building selection list.
Steps to reproduce
No response
Additional context
No response
Log file
No response

I can't reproduce this.
It's true that the blueprint ghosts are obtainable for the sweet syrup composters however if you try to build the ghost without the correct turd upgrade it will just default back to the intended (non syrup) composter.

Feel free to reopen if I missed something.

I can add a little more detail after finally poking at this again.  If you acquire a ghost of the illegal composter, and then manually build it, it reverts to the legal version.  But if a logistics bot places it, it remains the illegal version.
All 8 composters appearing in factory planner is bad behavior too, but that may be down to engine limitations and/or FP's fault.


PCF8563 support

The Adafruit RTClib (forked) has been tested on the exp8266, but does not support PCF8563 RTC.
The JeeLabs RTClib (original) supports the PCF8563 RTC, but do not know if will work on the exp8266.

As far as I can tell the PCF8523 and PCF8563 share the same date/time registers but have a different address, 0x68 and 0x51 respectively. Therefore the a simple copy/paste of the RTC_PCF8563 class might be enough.

Not quite the same registers, the PCF8523 resister set starts with 3 control registers (0x00 to 0x02) and the PCF8563 starts with 2 control registers (0x00 to 0x01).

For this application I only need to:

check if the RTC is present
read the RTC date/time registers
write the RTC date/time registers

I could implement this as generic RTC functions wich take an enum to distinguish the different RTC ICs. Each RTC ICs needs definitions for its I2C address and the seconds register (1st register on date/time). Other than that, the check/read/write should be identical.


您好，这个代码复现训练必须在跟您的配置一样的情况下才可以吗？

It shoud be the same, did you meet some problem?

It shoud be the same, did you meet some problem?

Because your paper mentioned that 8 A100 configurations are required to run, but I am currently unable to provide this configuration, I would like to know if it can run with a low configuration。


React.StrictMode complains about using string ref

Hi!
I really like React.StrictMode but it generates a warning that you're still using a string ref vs createRef().
Any chance you can update this? :)
Thanks!

Sounds sane, PRs welcome on this, thanks!

Would it be possible to make a release containing this change? So far as I can tell, the latest release 2.4.5 doesn't include this.

@mwilliamson-healx 2.4.6 has now been published

Fantastic, thanks!


Fixed type annotation for workbook.refresh

workbook.refresh is implemented to accept both WorkbookItem and str as arguments, but the type annotation describes it as receiving str, which can cause false warnings in static analysis.
Since the documentation states that it receives workbook_item, the name of the argument is also changed from workbook_id to workbook_item.
Issue: https://github.com/tableau/server-client-python/issues/1318

I've signed the CLA


Override tmp folder

When running JVM in a containerized environment, it gets an assigned temp folder that is not /tmp. This doesn't allow async-profiler to attach to a process with an error:
Could not start attach mechanism: No such file or directory

I wonder if there is a possibility override a /tmp folder location when running an async-profiler so we can point it to over in our isolated file system.

Make sure you use the latest async-profiler/jattach, and run the profiler under root.
When run under privileged user, jattach automatically switches to the proper mount namespace.
It is known to work with docker containers.
build/jattach --version should say at least 1.3

Thanks @apangin! Yea, I'm pretty sure we're on 1.3. I will try sudo/root and let you know.

Sorry forgot to mention: it's not Docker though. It's Aurora/Mesos. I'm not sure how different it is from Docket as far as the container management goes, but I will give the sudo/rot a try.

I realized that different location of /tmp does not necessarily imply different mount namespaces. If a process runs under chroot, it sees different directory structure, yet it works in the same namespace.
Fortunately, there is no need to override the directory manually. We can just look into /proc/pid/root/tmp instead of /tmp. This works even for unprivileged user, if profiler is launched by the owner of the target process.
I've committed the fix. Please check if it helps.

To close the loop on this. I built async-profiler from sources and it seems to be attaching successfully now (even when being run under unprivileged user)! Thanks a ton, @apangin!

Thanks for confirming it works.

I reworked the fix due to #158. I verified that profiler is still able to connect to chroot'ed processes, but I kindly invite you to re-check that it works in your case as well. Thanks.

I reworked the fix due to #158. I verified that profiler is still able to connect to chroot'ed processes, but I kindly invite you to re-check that it works in your case as well. Thanks.

Hey @apangin! I compiled the new version of async-profiler from master and verified it still works on our environment. Everything seems fine. Thanks!


gipy: display track on openstmap

adds option to plot openstmap if installed, similar to recorder. Code heavily copied from openstmap.
Notify @wagnerf42

Should the code go to openstmap module to make sharing easier? Also fixing or disabling warnings may be good.

ok the "heavily copied from openstmap" was not very precise from me, it is actually mixed recorder and openstmap, also with changes, so it is not a 1:1 copy, you will not find many identical lines in succession.
There are also some obvious differences, for example in openstmap there is a call to stop the continous updating of the track which has been left out here. In short: I would not bother sharing code here.

LGTM but there's some build errors that're blocking this :)

I have not changed these lines

I have sometimes just added some let-statements near the beginning of the script as an easy way to make the linter happy with older code. In this case e.g:
let direction, c;

I can fix the warnings if you want me to, but you need to provide me with a sample GPX file. Without it, the app never loads. I tried to download a few from different websites, but they all break the upload script with different errors.

You need a GPX-track file, not route. I have created a test file from https://www.bbbike.org/. Both the .gpx and the .gps are in test.zip

Thanks for the file. I made the fix in #3533 so you can merge that first, then merge that afterward.


[Issue] Troubles with Accessibility on EMI Config Screen

Hi, A couple issues I ran into with the EMI Config screen (1.1.2+1.20.1 fabric) regarding accessibility/keyboard usage:

Keyboard navigation seems basically entirely broken, or I'm not understanding the GuiNavigation system intended for keyboard navigation. Simple example with Arrow (both up/down and left/right) keys. Tab seems to do little to nothing. Note also the double (?) focus of the second and first/third buttons.

https://github.com/emilyploszaj/emi/assets/72876796/836e3643-18cc-48f3-80cf-85cfa2f2e0ae

Narration is effectively a non-thing. "Element 5 of 17", "Button". I didn't record with the narrator enabled, but it's easy to test, and compare versus eg. the Keybinds menu, which briefly describes an element like "Jump is bound to Space".

I'm not certain the best way to go about a solution for this, but I would hope that at least

tab & up/down iterate one by one through the entire config list in an orderly fashion. This isn't even just an accessibility thing, my scroll wheel is busted right now, so I was hoping to just cruise through the config with arrows
narration provides a hint. perhaps "[Subsection Name], Name, State", ex. "Enabled, True", "Center Search Bar, False", "Recipe Screen, Vertical Margin, 20"

There are some other challenges that I'm not sure how to overcome, such as the Number Input widgets that seem to be unique to the EMI config. The standard MC sliders conveniently dodge the double-need for up/down by changing the number with left/right.

I think EMI could do more work in regards to these issues, narration in particular would probably not be too difficult to implement but, in regards to focus... I originally had that as a priority and wanted it to work, going out of my way to implement it, but ran into pretty persistent focusing crashes that I could never resolve due in part to Minecraft's "GUI library", if you could call it that, lacking so many basic features and having so many edge cases that it's extremely difficult to build anything useful on. I ended up having to early exit and comment out most of the focusing code just to get it to stop crashing. Given adequate time, I'd want to take another crack at it, but consider it varies so much on the few versions EMI is released for and the inherent challenges... it may not be something that happens soon. I'm not very happy about this situation.


Update to latest version of everything and Cesium via Node/ES6

I know almost nothing about webpack, but this updates it to use a pre-release package of Cesium with ES6 support (which will become 1.63 so we can wait until that is out before we merge this).
It also switches the demo to use the latest version of all libraries and resolve packages from node the way most JS libraries work these days.
I noticed the fireworks no longer work in master or in this branch, I think a more practical example that loads a tileset from ion or something may be a better and simpler dmoe; but that can be in another PR.
I'm sure there are other things that can be simplified here as well, but my main concern was just updating everything.  Open to suggestions (or someone else can just pick up this PR and do more if they want).
My main goal here was to make sure that Cesium 1.63 still worked with webpack and it does (and in a better/more modern way than it did previously).

Thanks for the links @puckey
I figured out why the fireworks were broken we were missing a CopyWebpackPlugin entry for ThirdParty.  I'm still going to simplify the example to just load a 3D Ties tileset since that is a little more useful for our users.

The cesium dependency in package.json could be moved from devDependencies to dependencies

What's your reason for doing this?  Since this repository isn't meant to be depended on, I don't think it matters (and Cesium is only a compile time dependency because everything needed gets copied and hosted out of dist correct?  Just want to make sure I'm not missing anything.

The cesium dependency in package.json could be moved from devDependencies to dependencies

What's your reason for doing this? Since this repository isn't meant to be depended on, I don't think it matters (and Cesium is only a compile time dependency because everything needed gets copied and hosted out of dist correct? Just want to make sure I'm not missing anything.

It is a somewhat of a practice in webpack land to put bundle-ing / transpiling packages in devDependencies and packages that will have an influence on the compiled bundle size in dependencies. Here are a bunch of starter kits, for example: https://webpack.js.org/starter-kits/
One of the first things I would do as a user is to take a peek at the dependencies to see what is being included in the build.
There would also be something to be said for putting everything into dependencies, since they are installed no matter what the value is of NODE_ENV, unlike devDependencies which are ignored when installed with NODE_ENV set to production.

README.md will need updates. We should at least update the bundle size comparisons, and probably reorder the "Requiring" Cesium section so that ES6 imports are first.

Looking at updating the readme now.  I don't think we should recommend anyone bring in individual modules, we make no guarantees that filenames won't change over the course of a release.  I think that we should message ES6 as the only preferred way and they should use standard syntax like import { Viewer } from 'cesium'; instead of trying to import based on path.

bundle size comparisons,

Also, because we are always using ES6 imports from the primary cesium object, there's no reason for this comparison because a proper webpack setup will treeshake away the unused modules.

@ggetz all initial feedback has been fixed and I made a bunch of other improvements

Add mode flag to each webpack config
Fix third party workers and wasm modules
Remove sourcePrefix since an empty string is now the default
Remove uglify because it's no longer needed.
Enable tree-shaking in release.
Enable source-maps by default in development.
Pare down README
Switch to a more basic example application and link to the Getting Started.

Let me know if there's anything you think we really need to add back (though I'm not sure how much more time I can spend on this)

@ggetz bump.  We're linking to this repository in the ES6 blog post that will go out on Thursday so I would like to get this merged by then (I will then do a small update to point to CesiumJS 1.63 officially when we release on Friday).

These modifications look great! Thanks for the much-needed updates to this repo @mramato !


Still crashing

This is the log sorry
Your app is crashing. Here's the latest log.
/home/kam/.meteor/packages/meteor-tool/.1.1.4.xvre8c++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/dev_bundle/server-lib/node_modules/fibers/future.js:245
throw(ex);
^
TypeError: Cannot read property 'appId' of undefined
at server/lib/config.jsx:8:34
at /home/kam/quasar/.meteor/local/build/programs/server/app/server/lib/config.jsx.js:18:3
at /home/kam/quasar/.meteor/local/build/programs/server/boot.js:222:10
at Array.forEach (native)
at Function..each..forEach (/home/kam/.meteor/packages/meteor-tool/.1.1.4.xvre8c++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/dev_bundle/server-lib/node_modules/underscore/underscore.js:79:11)
at /home/kam/quasar/.meteor/local/build/programs/server/boot.js:117:5
Exited with code: 8
Your application is crashing. Waiting for file change.
                         Could be that I am doing something wrong with settings .json

                        also saw this in  scss.json

"useIndex" : true,
"includePaths": [
".meteor/local/build/programs/server/assets/packages/wolves_bourbon"
],
"indexFilePath" : "client/scss/main.scss"

no worries. thanks again for calling it out.
"includePaths": [
".meteor/local/build/programs/server/assets/packages/wolves_bourbon"
], needed to go for sure
Your app was actually crashing due to the settings.json config. config.jsx was looking for facebook credentials, which the app actually doesn't use right now, so I've commented out that section of the config.jsx file. You will still need Google credentials in your settings.json however because the app lets users log in with Google. So your settings.json file should look at least something like:
    {
      "google" : {
        "clientId" : "YOUR_CLIENT_ID",
        "clientSecret" : "YOUR_CLIENT_SECRET"
      },
    }

to run the app with the settings: meteor --settings yourpathtosettings/settings.json
You can also always rip out the Google stuff if you're not interested in using it. Pretty sure all you would need to do is comment out the requirements in config.jsx and change the header.component.jsx component to not loginWithGoogle.
Let me know if it works out!

whoops didn't mean to close the issue until you resolved it. feel free to reopen if it's not working still

didn't mean to close the issue till it was resolved.
if everything's good on your end, we can close it :)

Thanks was getting a parse error on settings.json however when I manually
typed it and removed the comma after the second last curly it worked great.
{
"google" : {
"clientId" : "YOUR_CLIENT_ID",
"clientSecret" : "YOUR_CLIENT_SECRET"
}
}
I works great will play around and get back to you.  will star the
project tonight.
regards
On Tue, Oct 20, 2015 at 11:06 AM, Simon Tucker<EMAIL_ADDRESS>wrote:

no worries. thanks again for calling it out.
"includePaths": [
".meteor/local/build/programs/server/assets/packages/wolves_bourbon"
], needed to go for sure
Your app was actually crashing due to the settings.json config. config.jsx
was looking for facebook credentials, which the app actually doesn't use
right now, so I've commented out that section of the config.jsx file. You
will still need Google credentials in your settings.json however because
the app lets users log in with Google. So your settings.json file should
look at least something like:
{
  "google" : {
    "clientId" : "YOUR_CLIENT_ID",
    "clientSecret" : "YOUR_CLIENT_SECRET"
  },
}

to run the app with the settings: meteor --settings
yourpathtosettings/settings.json
You can also always rip out the Google stuff if you're not interested in
using it. Pretty sure all you would need to do is comment out the
requirements in config.jsx
https://github.com/srtucker22/quasar/blob/master/server/lib/config.jsx
and change the header.component.jsx
https://github.com/srtucker22/quasar/blob/master/client/components/modules/header.component.jsx
component to not loginWithGoogle.
Let me know if it works out!
—
Reply to this email directly or view it on GitHub
https://github.com/srtucker22/quasar/issues/2#issuecomment-149381415.


BUG: Improve the alignment  of Our Mission

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
BUG: Improve the alignment of Our Mission

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@Its-Aman-Yadav Please assign me this issue

@Its-Aman-Yadav Please assign me this issue


Set StatusCode on HttpRequestException

Today when we create an HttpRequestException, the status code of a request is set as a part of the Message for the exception.
Since .NET 5, the HttpRequestException has a property for StatusCode.
I would propose this property should be set to allow for easier access to the status code.
To avoid having to do string parsing on the Message.

To avoid having to do string parsing on the Message

In which case would you do string parsing to which Message?

Today when we create an HttpRequestException,

Could you describe more about when would you create an HttpRequestException when using Azure SignalR?

I updated the post, providing more information and a use case


Vasily/loader refactor

continue to remove the legacy loader methods

removed uint64 packed representation of global node (file_idx, node_idx):

from now on, python uses either python tuple(int,int) to represent a global node (if we want representation to be python-hashable to put into a dict) or np.array of shape=(2,), dtype=np.uint32 if we want to send the node to low-level c++ method
c++ uses c_GlobaNode {uint32, uint32} structure for a global node through the code with the support for hash and comparison methods to be used in STL hash maps and ordered maps

( to reduce the number of different representations and internal data structures for readability and maintenance of the code)


Swift 2.3 Support

This likely isn't ready to merge as-is~~, especially given the awkward way it depends on the Alamofire/Alamofire:swift2.3 branch (they've yet to publish a release officially supporting it)~~.
99% of the diff is just dependency updates to pull in proper 2.3 support in all of the dependencies. The other 1% were simply recommend project setting changes that Xcode 8 Beta 6 suggested, and a few minor (but potentially dubious) code changes to support 2.3. At this point, it's also relatively untested.
I primarily put this up so anyone else who may be looking at using 2.3 might have a reference / fork to use. Ultimately, it'd be nice to clean this up (hopefully with Alamofire officially providing a 2.3 release) to ensure this plays nicely and doesn't break things for people running 2.2, but I'm not sure how feasible that is.

@dbburgess can this be udpated , alamofire release 3.5.0 which should work for both i think ?

@romk1n Sure, no problem. I've updated it to use Alamofire 3.5.0.

@dbburgess Thanks for this. I'll get this merged shortly!

@dbburgess awesome, probably need to update travis.yaml file to use xcode 8 to pass the build :)

Huzzah! There we go. It took a bit of putzing around to get the config correct, but that seems to have done it.

Thanks for this! It's been merged into a swift-2.3 branch.

@AnthonyMDev @dbburgess hey guys with swift 2.3 i am still getting those errors in xcode 8, any ideas ?
    func setACLHeaders(on request: inout NSMutableURLRequest)
                                   ^~~~~~
                       inout

@romk1n That line in the swift-2.3 branch is:
func setACLHeaders(inout forRequest request: NSMutableURLRequest)

The inout parameter comes before the parameter name in Swift 2. That changed in Swift 3, where inout comes before the type. From the swift-3 branch:
func setACLHeaders(on request: inout NSMutableURLRequest)

...So, either you've got the wrong branch, or the Xcode conversion tool got ran on the code. :)

@dbburgess hmm, interesting, maybe i should just try and use swift-2.3 branch instead


how to use function "subject" in Activity.php

hello
i have used the "casuer" function to get information from the model that causes the activity log, but for some reason the "subject" function doesn't work for me

Subject is just a polymorphic relation. What exactly doesn't work?

I also come to this question.
E.g I have
App\Entities\Business and App\Entities\Blog store into subject_type
My Business Table, I want to get business.name, but my in my Blog table I want to blog.title
since two tables have differents column name, how do I display both in one table? Since two tables are using different column name.
I tried subject.title, I only able to display Blog title, but for Business name it is not able to retreive it.
I pulled with Datatables.

@shiroamada I don't think your problem is related to the OP's but to answer your query, I ended up making accessors on the models. This makes it easy to pull out the contents.
@foreach($activities as $activity)

            {{ $activity->subject->short_name }}
            {{ $activity->created_at->diffForHumans() }}

        {{ $activity->subject->activity_sentence }}

@endforeach

ok, make the accessors really a good tip! Thanks! These info really help for beginner like me. Can included in your readme information. (Y) Sorry for hijack for this thread.

@jespersgaard are you still facing the issue? Can you elaborate more on what exactly doesn't work?


Stagger distribution and recontribution jobs

to conform to sending restriction of less than 100 per hour.
[x] Recontribution Service
[ ] ~Distribution Service~

Done


Add HTMLLinkElement as eligible .disabled element

When trying to write tests for a HTMLLinkElement and check for .disabled state, instead of asserting, qunit-dom throw an error.
There is a little gotcha for disabled on <link>.

As per declarative API (<link disabled>), this is experimental, deprecated and advised against its usage (and also does not work in browsers)
As per imperative API (HTMLLinkElement.disabled), this is according to MDN allow and works in browsers

So, this PR adds HTMLLinkElement as eligible element to check this for 😃

but... why? 😂
is there a legitimate use case for something like this? 😅

In fact yes, there is 😅
When each <link> represents a theme and only one can be active, then make the others .disabled in which case the browser don't use that CSS. That's the state when CSS is loaded but not in use.

and why not remove the link elements instead? 🤔

that's implementation details of my particular library.
The point is, the provided API (isDisabled() and isNotDisabled()) is here to check for a disabled property on any * extends HTMLElement that supports it. However, this is subjectively constrained by qunit-dom and doesn't match reality. I figured HTMLLinkElement is missing from that list and I wouldn't be surprised if there are more.
I see this more of a bugfix, so the API keeps holding up to its promise :)


Using the HTTP API across the whole UI

Will close this for now. will keep the API limited until it is secured


[DPP-57] Create JSON file to upload all iems

Issue:
Version 0.5 introduces changes to the items table, so the best approach is to create a JSON file that contains all the data to be uploaded.
JSON object structure:
[
      {
        "item_name" : string,
        "source_url" : string,
        "ebay_url": string
      },
      .
      .
      .
]

Notes:

Decide where to get the title from.
Validate JSON structure with JSONLint

JSON01.txt


walk position error

how can i fix this error
Traceback (most recent call last):
  File "pokecli.py", line 220, in <module>
    main()
  File "pokecli.py", line 211, in main
    bot.take_step()
  File "/home/mertcan/Desktop/PokemonGo-Bot/pokemongo_bot/__init__.py", line 36, in take_step
    self.stepper.take_step()
  File "/home/mertcan/Desktop/PokemonGo-Bot/pokemongo_bot/stepper.py", line 62, in take_step
    self._work_at_position(position[0], position[1], position[2], True)
  File "/home/mertcan/Desktop/PokemonGo-Bot/pokemongo_bot/stepper.py", line 139, in _work_at_position
    self.bot.work_on_cell(cell, position, pokemon_only)
  File "/home/mertcan/Desktop/PokemonGo-Bot/pokemongo_bot/__init__.py", line 93, in work_on_cell
    worker.work()
  File "/home/mertcan/Desktop/PokemonGo-Bot/pokemongo_bot/cell_workers/move_to_fort_worker.py", line 30, in work
    self.stepper._walk_to(self.config.walk, *position)
  File "/home/mertcan/Desktop/PokemonGo-Bot/pokemongo_bot/stepper.py", line 88, in _walk_to
    alt, False)
  File "/home/mertcan/Desktop/PokemonGo-Bot/pokemongo_bot/stepper.py", line 102, in _work_at_position
    response_dict = self.api.call()
  File "/home/mertcan/Desktop/PokemonGo-Bot/src/pgoapi/pgoapi/pgoapi.py", line 81, in call
    response = request.request(api_endpoint, self._req_method_list, player_position)
  File "/home/mertcan/Desktop/PokemonGo-Bot/src/pgoapi/pgoapi/rpc_api.py", line 100, in request
    raise NotLoggedInException()
pgoapi.exceptions.NotLoggedInException

Other Information
OS:  Xubuntu 16.04
Git Commit: 78c5f2bc8c5aeafb902309583cfab621179bed4e

I think this is due to the app upgrade.. Without looking my guess is the app silently logs in after a certain amount of time or it notices it isn't logged in anymore.

i have same issue.
[2016-07-31 19:20:22] [-] Attempted to capture Psyduck- failed.. trying again!
[2016-07-31 19:20:23] [x] Using Greatball (chance: 44.75%)... (59 left!)
[2016-07-31 19:20:23] [x] Oh no! Psyduck vanished! :(
Traceback (most recent call last):
File "pokecli.py", line 220, in
main()
File "pokecli.py", line 211, in main
bot.take_step()
File "/Users/batuhangundogdu/Desktop/PokemonGo-Bot-master/pokemongo_bot/init.py", line 36, in take_step
self.stepper.take_step()
File "/Users/batuhangundogdu/Desktop/PokemonGo-Bot-master/pokemongo_bot/stepper.py", line 53, in take_step
self._walk_to(self.config.walk, *position)
File "/Users/batuhangundogdu/Desktop/PokemonGo-Bot-master/pokemongo_bot/stepper.py", line 88, in _walk_to
alt, False)
File "/Users/batuhangundogdu/Desktop/PokemonGo-Bot-master/pokemongo_bot/stepper.py", line 102, in _work_at_position
response_dict = self.api.call()
File "/Users/batuhangundogdu/Desktop/PokemonGo-Bot-master/src/pgoapi/pgoapi/pgoapi.py", line 81, in call
response = request.request(api_endpoint, self._req_method_list, player_position)
File "/Users/batuhangundogdu/Desktop/PokemonGo-Bot-master/src/pgoapi/pgoapi/rpc_api.py", line 100, in request
raise NotLoggedInException()
pgoapi.exceptions.NotLoggedInException


Fix NPE generating Nginx config when no SSL configured

Extracts NPE fix from #56

Simple change to fix obvious bug, so merging as-is

+1 LGTM and fixes the NPE I was seeing when deploying deploy-multi-node-app-swarm while testing https://github.com/cloudsoft/container-service/pull/60


Fix behavior of Set-ExplorerOptions

The two options seem to be backwards; noticed this today when configuring my shiny new laptop :)

oh wow. nice catch!

Ooops, my bad (I think) 😄


Add try block to privmsg assertion

Fixes #45

[21:37]	Akuli	this pr to me is a small occurrence of a bigger problem / design question
[21:37]	Akuli	do we want to be prepared to handle anything whatsoever as inputs? should the server respond with
                                 clear error messages, or is it fine if something causes an exception?
[21:41]	Akuli	a possible cleanup idea: when receiving, handle the ":" thing once and for all, instead of repeating the ":"
                                 in every handle_foo() function
[21:41]	Akuli	the spec says that an argument starting with ":" means the rest is joined with spaces into a single
                                 argument, and this applies to all commands
[21:41]	Akuli	each command would then get a list of already splitted arguments, instead of a string that the command
                                 has to .split()

Closing this PR as the feature needs more consideration on a higher level


Add .NET Interactive Notebooks extension to Recommended extensions

in docs and in https://github.com/RandomFractals/vscode-data-table/blob/main/.vscode/extensions.json
link it to: https://marketplace.visualstudio.com/items?itemName=ms-dotnettools.dotnet-interactive-vscode
also include .net runtime ext: https://marketplace.visualstudio.com/items?itemName=ms-dotnettools.vscode-dotnet-runtime

see: https://github.com/RandomFractals/vscode-data-table#recommended-extensions


dict.iteritems depreciated in python3

update_one method in default_model_manager in utils is using dict.iteritems() which has been replaced by dict.items() in python3.

Forgot about it. Would be providing a fix asap. Thanx.


Revert 1ds to v3

Try to see if that solve collection issue

No changes needing a change description found.

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3715/
Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3715/


Dispatch tool 39481

Fixes #
https://github.com/Microsoft/botbuilder-tools/issues/365
https://github.com/Microsoft/botbuilder-tools/issues/407
https://github.com/Microsoft/botbuilder-tools/issues/275
Proposed Changes

Use Microsoft.Bot.Configuration package
Dispatch accepts -s/--secret with -b/--bot parameter to decrypt encrypted keys
If no -s/--secret is passed in with bot file, Dispatch CLI will prompt
Write out region in Dispatch output
Updated Dispatch to .NET Core 2.1

Testing

Pull Request Test Coverage Report for Build 1085

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 68.715%

Totals

Change from base Build 1067:
0.0%

Covered Lines:
3854

Relevant Lines:
5372

💛  - Coveralls


[T3A4][W09-A4]Yeo Xiang Guang Brandon

Ready for review.

The exception should be thrown from StorageFile::store() and caught inMain::executeCommand().

@brandonyeoxg Some comments added. Please close the PR after reading comments


Update to ophyd_async shutter

Link to dodal PR (if required): https://github.com/DiamondLightSource/dodal/pull/480
To test:

Confirm tests still pass

@DominicOram when you say merge at the same time, you mean into master one day  or one PR into another?

@DominicOram when you say merge at the same time, you mean into master one day or one PR into another?

Both into main on their respective repos at around the same time

not sure what to do about the CI error:

0s
Run item_id="$( gh api graphql -f query='
item_id="$( gh api graphql -f query='
mutation($project:ID!, $pr:ID!) {
addProjectV2ItemById(input: {projectId: $project, contentId: $pr}) {
item {
id
}
}
}' -f project=$PROJECT_ID -f pr=$ISSUE_ID --jq '.data.addProjectV2ItemById.item.id')"
echo 'ITEM_ID='$item_id >> $GITHUB_ENV

shell: /usr/bin/bash -e {0}
env:
PROJECT_ID: "PVT_kwDOABLS0s4AHJ2Y"
STATUS_FIELD_ID: "PVTSSF_lADOABLS0s4AHJ2YzgEH3Zs"
NEW_OPTION_ID: "e133e26f"
GITHUB_TOKEN: ***
ISSUE_ID: null
gh: Could not resolve to a node with the global id of 'null'
Error: Process completed with exit code 1.

not sure what to do about the CI error:

You can ignore them. They're for moving issues around the hyperion project board but this isn't being tracked on the hyperion project board

Closing in favour of https://github.com/DiamondLightSource/hyperion/pull/1419


Improved theme configuration for separators and modes

Added

Added style configuration for separator in themes
Added +, - and ^ operators for modes in theme configuration files
+ enables mode
- disables mode
^ toggles mode

Breaking changes

Section  separator in theme configuration is not an object that has text and style

Codecov Report
Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (d8a7e70) 93.77% compared to head (221be22) 92.35%.

:exclamation: Current head 221be22 differs from pull request most recent head 17fef4d. Consider uploading reports for the commit 17fef4d to get more accurate results

Files
Patch %
Lines

internal/pkg/themecfg/formatting/formatting.go
44.68%
22 Missing and 4 partials :warning:

theme.go
81.81%
2 Missing and 2 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   93.77%   92.35%   -1.42%
==========================================
  Files          22       22
  Lines        1494     1557      +63
==========================================
+ Hits         1401     1438      +37
- Misses         77       99      +22
- Partials       16       20       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


tiny detail in delta attrs

https://github.com/Ouranosinc/xscen/blob/2f8d143997b00f935590e792b133a0aedce0ce8b/xscen/aggregate.py#L263
This is really a small issue, but in the description and long_name of delta, I would prefer a "-", not a "_".

Sure. I honestly don't remember why we did that. Maybe to separate the periods more clearly?

Fixed by #228.


CB-11295 Add WP8.1 quirk when choosing image from photoalbum

Platforms affected
Windows (Windows Phone 8.1)
What does this PR do?
Updates plugin's docs to reflect WP8.1 quirk when calling camera.getPicture from location, different than app's start page
What testing has been done on this change?
Not required
Checklist

[x] ICLA has been signed and submitted to<EMAIL_ADDRESS>[x] Reported an issue in the JIRA database
[x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[x] Added automated test coverage as appropriate for this change. (not required)

Cordova CI Build has one or more failures.
Commit     - Link
Dashboard - Link

Builder Name
Console Output
Test Report
Device Logs

Windows 8.1 Store
Link
Link
Link

Windows 10  Store
Link
Link
Link

Windows 8.1 Phone
Link
Link
Link

iOS
Link
Link
Link

Android
Link
Link
Link

Cordova CI Build has one or more failures.
Commit     - Link
Dashboard - Link

Builder Name
Console Output
Test Report
Device Logs

Windows 8.1 Store
Link
Link
Link

Windows 10  Store
Link
Link
Link

Windows 8.1 Phone
Link
Link
Link

iOS
Link
Link
Link

Android
Link
Link
Link

Cordova CI Build has one or more failures.
Commit     - Link
Dashboard - Link

Builder Name
Console Output
Test Report
Device Logs

Windows 8.1 Store
Link
Link
Link

Windows 10  Store
Link
Link
Link

Windows 8.1 Phone
Link
Link
Link

iOS
Link
Link
Link

Android
Link
Link
Link

Cordova CI Build has one or more failures.
Commit     - Link
Dashboard - Link

Builder Name
Console Output
Test Report
Device Logs

Windows 8.1 Store
Link
Link
Link

Windows 10  Store
Link
Link
Link

Windows 8.1 Phone
Link
Link
Link

iOS
Link
Link
Link

Android
Link
Link
Link

Cordova CI Build has completed successfully.
Commit     - Link
Dashboard - Link

Builder Name
Console Output
Test Report
Device Logs

Windows 8.1 Store
Link
Link
Link

Windows 10  Store
Link
Link
Link

Windows 8.1 Phone
Link
Link
Link

iOS
Link
Link
Link

Android
Link
Link
Link

:+1: LGTM

As suggested by Vladimir, I solved and described in a SO post: http://stackoverflow.com/questions/36721104/fileopenpicker-wp8-1-how-to/39427405#39427405


Add Bloom deeplink button to the token-related modules

The Bloom deeplink button is already implemented in the platform in all NFT-related features. But it seems Bloom is not integrated yet to token-related transactions such as the token trading module and token airdrop claim process.

I cannot reproduce it in production. I may have been confused with a testing environment instead. Disregard.


Regular expressions does not work with .path

Hi, I would like to use the following route to filter what values can be used as an action:
FlowRouter.route('/blog/:action(edit|create)/:id?', {
  action: function(params, queryParams) {
    console.log(params);
  }
});

//succeeds
FlowRouter.go('/blog/create');

//returns error : There is no route for the path: /blog/test
FlowRouter.go('/blog/test');

console.log(FlowRouter.path('/blog/:action(edit|create)/:id?', {action: "edit", id: "abc"}));
//This returns : /blog/edit|create)/abc

Unfortunately FlowRouter.path doesn't seem to like my '/blog/:action(edit|create)/:id?' route like .go does.
Can you help me with that.
Thanks

Hi,
Just a +1 on this. I believe other FlowRouter functions like setQueryParams() don't work with your example above either. The regex seems to break it!

This is fixed with the FlowRouter SSR branch. It's on the atmosphere as kadira:flow-router-ssr.
We'll merge this soon.


Provide a method of excluding a transitive dependency across all configurations and projects

Expected Behavior
I'd like to exclude a transitive dependency across all configurations and projects
Current Behavior
I can't exclude a transitive dependency across all configurations and projects
Context
I was trying to work on #19028 and replace com.jcraft:jsch with com.github.mwiede:jsch, but the dependency I'm trying to replace is still showing up.
I've tried a number of methods of excluding the dependency, but IntelliJ tells me that the dependency I'm trying to replace is still downloaded.

I've tried the options in

https://docs.gradle.org/current/userguide/dependency_downgrade_and_exclude.html#sec:excluding-transitive-deps
https://docs.gradle.org/current/userguide/dependency_version_alignment.html
https://docs.gradle.org/current/userguide/dependency_capability_conflict.html

but nothing works.
I've tried some custom code, but this also has no effect.
// <rootdir>/build.gradle.kts
allprojects {
    configurations.all {
        exclude("com.jcraft", "jsch")
    }

    dependencies {
        modules {
            module("com.jcraft:jsch") {
                replacedBy("com.github.mwiede:jsch")
            }
        }
    }
}

This means that something else is pulling the dependency in. Your changes will impact project dependencies, but it might also show up as a build dependencies.
In order to understand what's happening, you will need to figure out where it is used and by what.
I'll close this issue as it is more of a support question for now than an issue in Gradle itself. If a bug is identified, we can re-open it.


[FEAT] Edit User Products with Update Timestamp

Description
Develop an API endpoint to edit user product_name , price, description, and tag and create a timestamp for updates.
Acceptance Criteria

The endpoint should be accessible at api/v1/products/{id}
The endpoint should accept HTTP PUT requests.
The endpoint should be secured to ensure that only authenticated users can edit products.
Proper authentication mechanisms (e.g., JWT, OAuth2) should be implemented.
Requests to the endpoint must include a valid authentication token in the Authorization header. Authorization: Bearer
- Request Body:
{
"product_name": "Updated Product Name",
"price": 600.0,
"description": "Updated Product Description",
"tag": "New Tag"
}

- Response:

On a successful update, the API should return a 200 OK status code.
The response body should contain the updated product details.

{
"id": 1,
"product_name": "Updated Product Name",
"price": 600.0,
"description": "Updated Product Description",
"tag": "New Tag",
"created_date": "2024-07-17T12:34:56Z",
"updated_date": "2024-07-18T14:20:00Z"
}
- Validation:

If any required field is missing or invalid, the API should return a 400 Bad Request status code with an appropriate validation error message.

{
"status_code": 400,
"message": ["product_name is required", "price must be a positive number"],
"error": "Bad Request"
}
Purpose
Provides a backend service that allows users to edit their products, including updating the name, price, description, and tag. This is useful because users can have multiple products, and product details can change over time. The endpoint also enables users to see the specific time when a product was last updated.
Requirements

[ ] Endpoint: The API should expose an endpoint at api/v1/products/{id}.

[ ]  Request Method: The endpoint should accept HTTP PUT requests.

[ ]  Authentication: Implement proper authentication mechanisms (e.g., JWT, OAuth2) to secure the endpoint.

[ ]  Authorization Header: Requests to the endpoint must include a valid authentication token in the Authorization header.

[ ]  Authorization: Bearer

[ ]  Request Body: Accept a JSON body with the fields product_name, price, description, and tag.
### Expected Outcome

The API should update the product details based on the provided information. The response should include updated product details such as id, product_name, price, description, tag, created_date, and updated_date.
### Testing

Authentication Testing:

Test the endpoint with a valid authentication token to ensure access is granted.
Test the endpoint without an authentication token or with an invalid token to ensure access is denied.

Parameter Validation:

Test the endpoint with valid fields to ensure it updates the product correctly.
Test the endpoint with missing or invalid fields to ensure it returns a 400 Bad Request status code with an appropriate error message.

Response Verification:

Test the endpoint with valid input values and verify that the response includes the updated product details.
Test the endpoint with an id that does not exist and verify that the response is appropriate (e.g., a 404 Not Found status code).

Edge Cases:

Test the endpoint with special characters and boundary values in the product_name, description, and tag fields to ensure the update functionality is robust.

This issues is linked to an approved issues link

This issues is link to an approve issues link


Error when using MariaDB as backend database

I was experimenting with sqlpad lately and everything was working fine up until the point when I decided to have standalone backend database for query history persistence. First DBMS I tried was MariaDB (simply because I had a spare one) and after I created separate schema for sqlpad there and pointed SQLPAD_BACKEND_DB_URI variable to it I was left with only auth working. Both schema browser and queries stopped working. In the logs of sqlpad I see that it's trying to read something from batches table and failing:
{"level":20,"time":"2021-06-17T11:05:48.431Z","pid":1,"hostname":"51b5bfe1a4ad","name":"sqlpad-app","msg":"Executing (default): SELECT `id`, `query_id` AS `queryId`, `name`, `connection_id` AS `connectionId`, `connection_client_id` AS `connectionClientId`, `status`, `start_time` AS `startTime`, `stop_time` AS `stopTime`, `duration_ms` AS `durationMs`, `batch_text` AS `batchText`, `selected_text` AS `selectedText`, `chart`, `user_id` AS `userId`, `created_at` AS `createdAt`, `updated_at` AS `updatedAt` FROM `batches` AS `Batches` WHERE `Batches`.`id` = 'b762439e-0674-4325-8d69-1136b6376322';"}
{"level":50,"time":"2021-06-17T11:05:48.435Z","pid":1,"hostname":"51b5bfe1a4ad","name":"sqlpad-app","stack":"SyntaxError: Unexpected token o in JSON at position 1
  at JSON.parse (<anonymous>)
  at /usr/app/node_modules/sequelize/lib/dialects/mariadb/query.js:186:72
  at Array.map (<anonymous>)
  at Query.handleJsonSelectQuery (/usr/app/node_modules/sequelize/lib/dialects/mariadb/query.js:185:21)
  at Query.formatResults (/usr/app/node_modules/sequelize/lib/dialects/mariadb/query.js:130:12)
  at Query.run (/usr/app/node_modules/sequelize/lib/dialects/mariadb/query.js:74:17)
  at processTicksAndRejections (internal/process/task_queues.js:97:5)
  at async /usr/app/node_modules/sequelize/lib/sequelize.js:619:16
  at async MySQLQueryInterface.select (/usr/app/node_modules/sequelize/lib/dialects/abstract/query-interface.js:953:12)
  at async Function.findAll (/usr/app/node_modules/sequelize/lib/model.js:1753:21)
  at async Function.findOne (/usr/app/node_modules/sequelize/lib/model.js:1917:12)
  at async Batches.findOneById (/usr/app/models/batches.js:16:17)
  at async create (/usr/app/routes/batches.js:38:20)","type":"Error","msg":"Unexpected token o in JSON at position 1"}

Then I tried to use postgres as backend db and it worked perfectly fine! I see the same query from batches table except now it's not failing:
{"level":20,"time":"2021-06-17T11:49:13.826Z","pid":1,"hostname":"49cf75db16ed","name":"sqlpad-app","msg":"Executing (default): SELECT \"id\", \"query_id\" AS \"queryId\", \"name\", \"connection_id\" AS \"connectionId\", \"connection_client_id\" AS \"connectionClientId\", \"status\", \"start_time\" AS \"startTime\", \"stop_time\" AS \"stopTime\", \"duration_ms\" AS \"durationMs\", \"batch_text\" AS \"batchText\", \"selected_text\" AS \"selectedText\", \"chart\", \"user_id\" AS \"userId\", \"created_at\" AS \"createdAt\", \"updated_at\" AS \"updatedAt\" FROM \"batches\" AS \"Batches\" WHERE \"Batches\".\"id\" = '6e2b517a-e508-4064-9bca-bb63dff94b87';"}
{"level":20,"time":"2021-06-17T11:49:13.832Z","pid":1,"hostname":"49cf75db16ed","name":"sqlpad-app","msg":"Executing (default): SELECT \"id\", \"query_id\" AS \"queryId\", \"name\", \"connection_id\" AS \"connectionId\", \"connection_client_id\" AS \"connectionClientId\", \"status\", \"start_time\" AS \"startTime\", \"stop_time\" AS \"stopTime\", \"duration_ms\" AS \"durationMs\", \"batch_text\" AS \"batchText\", \"selected_text\" AS \"selectedText\", \"chart\", \"user_id\" AS \"userId\", \"created_at\" AS \"createdAt\", \"updated_at\" AS \"updatedAt\" FROM \"batches\" AS \"Batches\" WHERE \"Batches\".\"id\" = '6e2b517a-e508-4064-9bca-bb63dff94b87';"}

I thought may be I misconfigured something in the first place so I decided to reproduce everything from scratch and... Managed to do that: combo of latest sqlpad docker image + latest mariadb docker image + SQLPAD_BACKEND_DB_URI pointing to that mariadb is definitely not working as it should.
Any ideas what could cause this behavior?

just to be on the safe side, here's the CI using "latest mariadb docker image" --> https://github.com/sqlpad/sqlpad/pull/1027/checks

Wow that escalated quickly

I wonder if it has anything to do with the below
https://github.com/sequelize/sequelize/issues/12583
https://github.com/sequelize/sequelize/pull/13273

Looks like first issue you mentioned is the one to blame. I've tested few different MariaDB versions as backend db for sqlpad:
10.4.19 - everything is working fine 👌
10.5.1 - everything is working fine 👌
10.5.2 - error from first post
10.5.3 - same error from first post
10.5.5 - same error from first post
10.5.9 (which was wrongly tagged as latest on my machine) - same error from first post
10.5.10 - different error (below), sqlpad container fails to start, so with this version even auth screen is not working :)
{"level":50,"time":"2021-06-17T17:15:40.741Z","pid":1,"hostname":"40a0b78d0401","name":"sqlpad-app","name":"SequelizeDatabaseError","parent":{"fatal":false,"errno":1054,"sqlState":"42S22","code":"ER_BAD_FIELD_ERROR","sql":"ALTER TABLE `users` ADD `sync_auth_role` TINYINT(1);"},"original":{"fatal":false,"errno":1054,"sqlState":"42S22","code":"ER_BAD_FIELD_ERROR","sql":"ALTER TABLE `users` ADD `sync_auth_role` TINYINT(1);"},"sql":"ALTER TABLE `users` ADD `sync_auth_role` TINYINT(1);","stack":"SequelizeDatabaseError: (conn=8, no: 1054, SQLState: 42S22) Unknown column '`sqlpad`.`u`.`data`' in 'CHECK'\nsql: ALTER TABLE `users` ADD `sync_auth_role` TINYINT(1); - parameters:[]\n    at Query.formatError (/usr/app/node_modules/sequelize/lib/dialects/mariadb/query.js:277:16)\n    at Query.run (/usr/app/node_modules/sequelize/lib/dialects/mariadb/query.js:66:18)\n    at processTicksAndRejections (internal/process/task_queues.js:97:5)","type":"Error","msg":"Error starting SQLPad"}

@rickbergfalk  ... This comment https://github.com/sequelize/sequelize/issues/12583#issuecomment-817193937 suggests adding a dialect Option.
const sequelize = new Sequelize(..., {
  dialectOptions: { autoJsonMap: false }
});

I think I tried but couldn't find where to put this in sqlpad code.
Have we tested using sqlpad to access a mariadb latest DB (as a connection, not as a backend database) ?

Didn't mean to close this via the reference in the PR 😅
Thanks for reporting this @muRn and the investigation @eladeyal-intel. The linked sequelize issue/PR looks like it was the underlying problem.
I went ahead and forked sequelize, made the suggested fixes, and published it under a scoped npm package, then imported/aliased sequelize in SQLPad to use that version instead.
I think this fixes the issue. CI tests are passing at least.
@muRn I'd ask you to validate the new changes, but it seems SQLPad's dockerhub integration has been disabled due to some changes :(.
Will try to get that up and running again and will post when latest docker image is updated with latest fix.

Docker hub suspended automatic builds for free accouns.
https://docs.docker.com/docker-hub/builds/
You can

Apply to be recognized as an open source project and then supposedly get it back (see link in that document above)

Build with GitHub actions and then push the built image to docker hub vis GitHub actions.

Dump dockerhub, use GitHub new repository (beta)

Was just typing as you posted - I've submitted an application. If denied will probably look into using actions to build and publish there.

I've tested latest sqlpad with my configuration, it's working now!
@rickbergfalk You probably would like to merge your change back to sequelize now? One of sequelize reviewers already agreed to similar change, but PR author disappeared. I think he'll be glad to merge your changes instead :)
P.S. I've also tested another way to fix the issue and it's also working. So if sequelize team refuses to merge your change for some reason and you don't want to maintain your own fork of sequelize - you may consider this option :)

Sequelize seems to be maintained again 🙌 Was able to get the changes in the fork back upstream https://github.com/sequelize/sequelize/pull/13633