Is it possible to use outbound connections without a http API

If you just wanted to send all invites to outbound connection URI A and all registrations to outbound connection uri B we can't currently do this in the config file can we?

No, to use outbound connections you would need an http handler.  Just to be clear, you can have different handlers for INVITE vs REGISTER:
    <request-handlers>
        <request-handler sip-method="INVITE" http-method="GET">http://<IP_ADDRESS>:80</request-handler>
       <request-handler sip-method="REGISTER" http-method="GET">http://<IP_ADDRESS>:82</request-handler>
    </request-handlers>

and you can easily route all INVITEs to one inbound application and all REGISTERs to another inbound application (simply by having one app call srf.invite and the other srf.register).

could we not make it so you can just specify one tcp connection uri so it always sends an outbound connection to one particular uri ?

just wondering, what is the use case here (why outbound connections at all)?

because its a tcp connection the client wants to be able to put a load balancer inbetween the node app(s) and drachtio, drachtio would just always make an outbound connection to the load balancer and the load balancer will distribute the load across the node apps (all the same) - which inevitably makes deploying changes to the nodejs apps a little easier too.... at least in their circumstance.
So they could have an API or even a json file that drachtio calls but the result is always going to be the same tcp load balancer uri

i guess i'm confused a bit.   Wouldn't the solution for the request-handlers do this?  If the ip or fqdn was the load balancer in front of the node app, i would think it would accomplish that?

I could see that what you are asking for would eliminate the need for calling an http api that would always be returning the same result, is that it?
I could look at adding an optional attribute endpoint-protocol=[http|drachtio] such that this would do what you want:
<request-handlers>
        <request-handler sip-method="INVITE" http-method="GET" endpoint-protocol="drachtio">http://<IP_ADDRESS>:80</request-handler>
       <request-handler sip-method="REGISTER" http-method="GET" endpoint-protocol="drachtio">http://<IP_ADDRESS>:82</request-handler>
    </request-handlers>

Something like that?

Right - thats exactly it. No point calling an api or json file stored somewhere if we're always sending to the same place.
So I'd see it as
<request-handlers>
        <request-handler sip-method="INVITE" endpoint-protocol="drachtio">tcp://load-balancer.foo.com:3000</request-handler>
       <request-handler sip-method="REGISTER" endpoint-protocol="drachtio">tcp://load-balancer.foo.com:3000</request-handler>
    </request-handlers>

I see.  I guess 'endpoint-protocol' is somewhat redundant and unnecessary, since we protocol will either be http/s or tcp, the latter inferring drachtio?
I'll try to take a look at this today

Whilst I think this would be a good addition we've just figured out we do actually need the api call for one scenario. So don't waste time on this if you don't need to :)

added in v0.8.3-rc2
either
<request-handler sip-method="INVITE">tcp://<IP_ADDRESS>:3041</request-handler>

or
<request-handler sip-method="INVITE">tls://<IP_ADDRESS>:3041</request-handler>

are now allowed, and the connection will be established directly to those endpoints (or via a load balancer at that address:port)


Regex not working correctly in Objective C

	private String extractAppIdFromAppKey(String appId) {
		// take the second half of the 40 characters
		String working = appId.substring(20);

		// this removes leading 0's
		working = working.replaceFirst("^0+(?!$)", "");
		return working;
	}

This is the method that removes zeros from the beginning of the string, in Objective C it does not.
1) testAppIdExactly40SymbolsAndZerosInTheMiddle(im.getsocial.sdk.core.AppIdTest)
java.lang.AssertionError:
Expected: "103456789"
     but: was "0103456789"

Version j2objc-<IP_ADDRESS>.1

Thanks for the report. I have a fix prepared that will be available next time we sync our codebase.

Fixed in current source.


Synthesis failed for Discovery

Hello! Autosynth couldn't regenerate Discovery. :broken_heart:
Here's the output from running synth.py:
2020-05-09 05:11:04 [INFO] logs will be written to: /tmpfs/src/github/synthtool/logs/googleapis/elixir-google-api
2020-05-09 05:11:04,316 autosynth > logs will be written to: /tmpfs/src/github/synthtool/logs/googleapis/elixir-google-api
Switched to branch 'autosynth-discovery'
2020-05-09 05:11:05 [INFO] Running synthtool
2020-05-09 05:11:05,931 autosynth > Running synthtool
2020-05-09 05:11:05 [INFO] ['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'clients/discovery/synth.metadata', 'synth.py', '--']
2020-05-09 05:11:05,931 autosynth > ['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'clients/discovery/synth.metadata', 'synth.py', '--']
2020-05-09 05:11:06,140 synthtool > Executing /home/kbuilder/.cache/synthtool/elixir-google-api/synth.py.
On branch autosynth-discovery
nothing to commit, working tree clean
2020-05-09 05:11:06,429 synthtool > Cloning https://github.com/googleapis/elixir-google-api.git.
2020-05-09 05:11:06,937 synthtool > Running: docker run --rm -v/home/kbuilder/.cache/synthtool/elixir-google-api:/workspace -v/var/run/docker.sock:/var/run/docker.sock -e USER_GROUP=1000:1000 -w /workspace gcr.io/cloud-devrel-public-resources/elixir19 scripts/generate_client.sh Discovery
2020-05-09 05:11:10,457 synthtool > No files in sources /home/kbuilder/.cache/synthtool/elixir-google-api/clients were copied. Does the source contain files?
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 102, in <module>
    main()
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 94, in main
    spec.loader.exec_module(synth_module)  # type: ignore
  File "/tmpfs/src/github/synthtool/synthtool/metadata.py", line 180, in __exit__
    write(self.metadata_file_path)
  File "/tmpfs/src/github/synthtool/synthtool/metadata.py", line 112, in write
    with open(outfile, "w") as fh:
FileNotFoundError: [Errno 2] No such file or directory: 'clients/discovery/synth.metadata'
2020-05-09 05:11:10 [ERROR] Synthesis failed
2020-05-09 05:11:10,488 autosynth > Synthesis failed
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 599, in <module>
    main()
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 471, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 549, in _inner_main
    ).synthesize(base_synth_log_path)
  File "/tmpfs/src/github/synthtool/autosynth/synthesizer.py", line 118, in synthesize
    synth_proc.check_returncode()  # Raise an exception.
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 389, in check_returncode
    self.stderr)
subprocess.CalledProcessError: Command '['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'clients/discovery/synth.metadata', 'synth.py', '--', 'Discovery']' returned non-zero exit status 1.

Google internal developers can see the full log here.

Autosynth is still having trouble generating Discovery. :sob:
Here's the output from running synth.py:
2020-05-10 05:11:01 [INFO] logs will be written to: /tmpfs/src/github/synthtool/logs/googleapis/elixir-google-api
2020-05-10 05:11:01,972 autosynth > logs will be written to: /tmpfs/src/github/synthtool/logs/googleapis/elixir-google-api
Switched to branch 'autosynth-discovery'
2020-05-10 05:11:03 [INFO] Running synthtool
2020-05-10 05:11:03,631 autosynth > Running synthtool
2020-05-10 05:11:03 [INFO] ['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'clients/discovery/synth.metadata', 'synth.py', '--']
2020-05-10 05:11:03,631 autosynth > ['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'clients/discovery/synth.metadata', 'synth.py', '--']
2020-05-10 05:11:03,854 synthtool > Executing /home/kbuilder/.cache/synthtool/elixir-google-api/synth.py.
On branch autosynth-discovery
nothing to commit, working tree clean
2020-05-10 05:11:04,001 synthtool > Cloning https://github.com/googleapis/elixir-google-api.git.
2020-05-10 05:11:04,553 synthtool > Running: docker run --rm -v/home/kbuilder/.cache/synthtool/elixir-google-api:/workspace -v/var/run/docker.sock:/var/run/docker.sock -e USER_GROUP=1000:1000 -w /workspace gcr.io/cloud-devrel-public-resources/elixir19 scripts/generate_client.sh Discovery
2020-05-10 05:11:08,940 synthtool > No files in sources /home/kbuilder/.cache/synthtool/elixir-google-api/clients were copied. Does the source contain files?
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 102, in <module>
    main()
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 94, in main
    spec.loader.exec_module(synth_module)  # type: ignore
  File "/tmpfs/src/github/synthtool/synthtool/metadata.py", line 180, in __exit__
    write(self.metadata_file_path)
  File "/tmpfs/src/github/synthtool/synthtool/metadata.py", line 112, in write
    with open(outfile, "w") as fh:
FileNotFoundError: [Errno 2] No such file or directory: 'clients/discovery/synth.metadata'
2020-05-10 05:11:08 [ERROR] Synthesis failed
2020-05-10 05:11:08,968 autosynth > Synthesis failed
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 599, in <module>
    main()
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 471, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 549, in _inner_main
    ).synthesize(base_synth_log_path)
  File "/tmpfs/src/github/synthtool/autosynth/synthesizer.py", line 118, in synthesize
    synth_proc.check_returncode()  # Raise an exception.
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 389, in check_returncode
    self.stderr)
subprocess.CalledProcessError: Command '['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'clients/discovery/synth.metadata', 'synth.py', '--', 'Discovery']' returned non-zero exit status 1.

Google internal developers can see the full log here.

Autosynth is still having trouble generating Discovery. :sob:
Here's the output from running synth.py:
2020-05-11 05:09:42 [INFO] logs will be written to: /tmpfs/src/github/synthtool/logs/googleapis/elixir-google-api
2020-05-11 05:09:42,101 autosynth > logs will be written to: /tmpfs/src/github/synthtool/logs/googleapis/elixir-google-api
Switched to branch 'autosynth-discovery'
2020-05-11 05:09:43 [INFO] Running synthtool
2020-05-11 05:09:43,470 autosynth > Running synthtool
2020-05-11 05:09:43 [INFO] ['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'clients/discovery/synth.metadata', 'synth.py', '--']
2020-05-11 05:09:43,470 autosynth > ['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'clients/discovery/synth.metadata', 'synth.py', '--']
2020-05-11 05:09:43,652 synthtool > Executing /home/kbuilder/.cache/synthtool/elixir-google-api/synth.py.
On branch autosynth-discovery
nothing to commit, working tree clean
2020-05-11 05:09:43,796 synthtool > Cloning https://github.com/googleapis/elixir-google-api.git.
2020-05-11 05:09:44,449 synthtool > Running: docker run --rm -v/home/kbuilder/.cache/synthtool/elixir-google-api:/workspace -v/var/run/docker.sock:/var/run/docker.sock -e USER_GROUP=1000:1000 -w /workspace gcr.io/cloud-devrel-public-resources/elixir19 scripts/generate_client.sh Discovery
2020-05-11 05:09:48,661 synthtool > No files in sources /home/kbuilder/.cache/synthtool/elixir-google-api/clients were copied. Does the source contain files?
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 102, in <module>
    main()
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 94, in main
    spec.loader.exec_module(synth_module)  # type: ignore
  File "/tmpfs/src/github/synthtool/synthtool/metadata.py", line 180, in __exit__
    write(self.metadata_file_path)
  File "/tmpfs/src/github/synthtool/synthtool/metadata.py", line 112, in write
    with open(outfile, "w") as fh:
FileNotFoundError: [Errno 2] No such file or directory: 'clients/discovery/synth.metadata'
2020-05-11 05:09:48 [ERROR] Synthesis failed
2020-05-11 05:09:48,686 autosynth > Synthesis failed
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 599, in <module>
    main()
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 471, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 549, in _inner_main
    ).synthesize(base_synth_log_path)
  File "/tmpfs/src/github/synthtool/autosynth/synthesizer.py", line 118, in synthesize
    synth_proc.check_returncode()  # Raise an exception.
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 389, in check_returncode
    self.stderr)
subprocess.CalledProcessError: Command '['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'clients/discovery/synth.metadata', 'synth.py', '--', 'Discovery']' returned non-zero exit status 1.

Google internal developers can see the full log here.

Autosynth is still having trouble generating Discovery. :sob:
Here's the output from running synth.py:
2020-05-11 15:11:48 [INFO] logs will be written to: /tmpfs/src/github/synthtool/logs/googleapis/elixir-google-api
2020-05-11 15:11:48,455 autosynth > logs will be written to: /tmpfs/src/github/synthtool/logs/googleapis/elixir-google-api
Switched to branch 'autosynth-discovery'
2020-05-11 15:11:50 [INFO] Running synthtool
2020-05-11 15:11:50,302 autosynth > Running synthtool
2020-05-11 15:11:50 [INFO] ['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'clients/discovery/synth.metadata', 'synth.py', '--']
2020-05-11 15:11:50,302 autosynth > ['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'clients/discovery/synth.metadata', 'synth.py', '--']
2020-05-11 15:11:50,514 synthtool > Executing /home/kbuilder/.cache/synthtool/elixir-google-api/synth.py.
On branch autosynth-discovery
nothing to commit, working tree clean
2020-05-11 15:11:50,876 synthtool > Cloning https://github.com/googleapis/elixir-google-api.git.
2020-05-11 15:11:51,338 synthtool > Running: docker run --rm -v/home/kbuilder/.cache/synthtool/elixir-google-api:/workspace -v/var/run/docker.sock:/var/run/docker.sock -e USER_GROUP=1000:1000 -w /workspace gcr.io/cloud-devrel-public-resources/elixir19 scripts/generate_client.sh Discovery
/workspace /workspace
The mix.lock file was generated with a newer version of Hex. Update your client by running `mix local.hex` to avoid losing data.
Resolving Hex dependencies...
Dependency resolution completed:
Unchanged:
  certifi 2.5.1
  google_api_discovery 0.7.0
  google_gax 0.3.2
  hackney 1.15.2
  idna 6.0.0
  jason 1.2.0
  metrics 1.0.1
  mime 1.3.1
  mimerl 1.2.0
  oauth2 0.9.4
  parse_trans 3.3.0
  poison 3.1.0
  ssl_verify_fun 1.1.5
  temp 0.4.7
  tesla 1.3.3
  unicode_util_compat 0.4.1
A new Hex version is available (0.20.1 < 0.20.5), please update with `mix local.hex`
All dependencies are up to date
The mix.lock file was generated with a newer version of Hex. Update your client by running `mix local.hex` to avoid losing data.

22:11:54.756 [info]  FETCHING: https://www.googleapis.com/discovery/v1/apis/discovery/v1/rest

22:11:54.900 [info]  FOUND: https://www.googleapis.com/discovery/v1/apis/discovery/v1/rest
Revision check: old=20200429, new=20200506, generating=true
Creating leading directories
Writing DirectoryList to clients/discovery/lib/google_api/discovery/v1/model/directory_list.ex.
Writing DirectoryListItems to clients/discovery/lib/google_api/discovery/v1/model/directory_list_items.ex.
Writing DirectoryListItemsIcons to clients/discovery/lib/google_api/discovery/v1/model/directory_list_items_icons.ex.
Writing JsonSchema to clients/discovery/lib/google_api/discovery/v1/model/json_schema.ex.
Writing JsonSchemaAnnotations to clients/discovery/lib/google_api/discovery/v1/model/json_schema_annotations.ex.
Writing JsonSchemaVariant to clients/discovery/lib/google_api/discovery/v1/model/json_schema_variant.ex.
Writing JsonSchemaVariantMap to clients/discovery/lib/google_api/discovery/v1/model/json_schema_variant_map.ex.
Writing RestDescription to clients/discovery/lib/google_api/discovery/v1/model/rest_description.ex.
Writing RestDescriptionAuth to clients/discovery/lib/google_api/discovery/v1/model/rest_description_auth.ex.
Writing RestDescriptionAuthOauth2 to clients/discovery/lib/google_api/discovery/v1/model/rest_description_auth_oauth2.ex.
Writing RestDescriptionIcons to clients/discovery/lib/google_api/discovery/v1/model/rest_description_icons.ex.
Writing RestMethod to clients/discovery/lib/google_api/discovery/v1/model/rest_method.ex.
Writing RestMethodMediaUpload to clients/discovery/lib/google_api/discovery/v1/model/rest_method_media_upload.ex.
Writing RestMethodMediaUploadProtocols to clients/discovery/lib/google_api/discovery/v1/model/rest_method_media_upload_protocols.ex.
Writing RestMethodMediaUploadProtocolsResumable to clients/discovery/lib/google_api/discovery/v1/model/rest_method_media_upload_protocols_resumable.ex.
Writing RestMethodMediaUploadProtocolsSimple to clients/discovery/lib/google_api/discovery/v1/model/rest_method_media_upload_protocols_simple.ex.
Writing RestMethodRequest to clients/discovery/lib/google_api/discovery/v1/model/rest_method_request.ex.
Writing RestMethodResponse to clients/discovery/lib/google_api/discovery/v1/model/rest_method_response.ex.
Writing RestResource to clients/discovery/lib/google_api/discovery/v1/model/rest_resource.ex.
Writing Apis to clients/discovery/lib/google_api/discovery/v1/api/apis.ex.
Writing connection.ex.
Writing metadata.ex.
Writing mix.exs
Writing README.md
Writing LICENSE
Writing .gitignore
Writing config/config.exs
Writing test/test_helper.exs
The mix.lock file was generated with a newer version of Hex. Update your client by running `mix local.hex` to avoid losing data.

22:11:56.082 [info]  Bumping patch
fixing file permissions
2020-05-11 15:11:56,826 synthtool > No files in sources /home/kbuilder/.cache/synthtool/elixir-google-api/clients were copied. Does the source contain files?
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 102, in <module>
    main()
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 94, in main
    spec.loader.exec_module(synth_module)  # type: ignore
  File "/tmpfs/src/github/synthtool/synthtool/metadata.py", line 180, in __exit__
    write(self.metadata_file_path)
  File "/tmpfs/src/github/synthtool/synthtool/metadata.py", line 112, in write
    with open(outfile, "w") as fh:
FileNotFoundError: [Errno 2] No such file or directory: 'clients/discovery/synth.metadata'
2020-05-11 15:11:56 [ERROR] Synthesis failed
2020-05-11 15:11:56,858 autosynth > Synthesis failed
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 599, in <module>
    main()
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 471, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 549, in _inner_main
    ).synthesize(base_synth_log_path)
  File "/tmpfs/src/github/synthtool/autosynth/synthesizer.py", line 118, in synthesize
    synth_proc.check_returncode()  # Raise an exception.
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 389, in check_returncode
    self.stderr)
subprocess.CalledProcessError: Command '['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'clients/discovery/synth.metadata', 'synth.py', '--', 'Discovery']' returned non-zero exit status 1.

Google internal developers can see the full log here.

Autosynth is still having trouble generating Discovery. :sob:
Here's the output from running synth.py:
2020-05-12 05:11:19 [INFO] logs will be written to: /tmpfs/src/github/synthtool/logs/googleapis/elixir-google-api
2020-05-12 05:11:19,388 autosynth > logs will be written to: /tmpfs/src/github/synthtool/logs/googleapis/elixir-google-api
Switched to branch 'autosynth-discovery'
2020-05-12 05:11:21 [INFO] Running synthtool
2020-05-12 05:11:21,069 autosynth > Running synthtool
2020-05-12 05:11:21 [INFO] ['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'clients/discovery/synth.metadata', 'synth.py', '--']
2020-05-12 05:11:21,069 autosynth > ['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'clients/discovery/synth.metadata', 'synth.py', '--']
2020-05-12 05:11:21,281 synthtool > Executing /home/kbuilder/.cache/synthtool/elixir-google-api/synth.py.
On branch autosynth-discovery
nothing to commit, working tree clean
2020-05-12 05:11:21,617 synthtool > Cloning https://github.com/googleapis/elixir-google-api.git.
2020-05-12 05:11:22,478 synthtool > Running: docker run --rm -v/home/kbuilder/.cache/synthtool/elixir-google-api:/workspace -v/var/run/docker.sock:/var/run/docker.sock -e USER_GROUP=1000:1000 -w /workspace gcr.io/cloud-devrel-public-resources/elixir19 scripts/generate_client.sh Discovery
/workspace /workspace
The mix.lock file was generated with a newer version of Hex. Update your client by running `mix local.hex` to avoid losing data.
Resolving Hex dependencies...
Dependency resolution completed:
Unchanged:
  certifi 2.5.1
  google_api_discovery 0.7.0
  google_gax 0.3.2
  hackney 1.15.2
  idna 6.0.0
  jason 1.2.0
  metrics 1.0.1
  mime 1.3.1
  mimerl 1.2.0
  oauth2 0.9.4
  parse_trans 3.3.0
  poison 3.1.0
  ssl_verify_fun 1.1.5
  temp 0.4.7
  tesla 1.3.3
  unicode_util_compat 0.4.1
A new Hex version is available (0.20.1 < 0.20.5), please update with `mix local.hex`
All dependencies are up to date
The mix.lock file was generated with a newer version of Hex. Update your client by running `mix local.hex` to avoid losing data.

12:11:24.983 [info]  FETCHING: https://www.googleapis.com/discovery/v1/apis/discovery/v1/rest

12:11:25.120 [info]  FOUND: https://www.googleapis.com/discovery/v1/apis/discovery/v1/rest
Revision check: old=20200429, new=20200429, generating=true
Creating leading directories
Writing DirectoryList to clients/discovery/lib/google_api/discovery/v1/model/directory_list.ex.
Writing DirectoryListItems to clients/discovery/lib/google_api/discovery/v1/model/directory_list_items.ex.
Writing DirectoryListItemsIcons to clients/discovery/lib/google_api/discovery/v1/model/directory_list_items_icons.ex.
Writing JsonSchema to clients/discovery/lib/google_api/discovery/v1/model/json_schema.ex.
Writing JsonSchemaAnnotations to clients/discovery/lib/google_api/discovery/v1/model/json_schema_annotations.ex.
Writing JsonSchemaVariant to clients/discovery/lib/google_api/discovery/v1/model/json_schema_variant.ex.
Writing JsonSchemaVariantMap to clients/discovery/lib/google_api/discovery/v1/model/json_schema_variant_map.ex.
Writing RestDescription to clients/discovery/lib/google_api/discovery/v1/model/rest_description.ex.
Writing RestDescriptionAuth to clients/discovery/lib/google_api/discovery/v1/model/rest_description_auth.ex.
Writing RestDescriptionAuthOauth2 to clients/discovery/lib/google_api/discovery/v1/model/rest_description_auth_oauth2.ex.
Writing RestDescriptionIcons to clients/discovery/lib/google_api/discovery/v1/model/rest_description_icons.ex.
Writing RestMethod to clients/discovery/lib/google_api/discovery/v1/model/rest_method.ex.
Writing RestMethodMediaUpload to clients/discovery/lib/google_api/discovery/v1/model/rest_method_media_upload.ex.
Writing RestMethodMediaUploadProtocols to clients/discovery/lib/google_api/discovery/v1/model/rest_method_media_upload_protocols.ex.
Writing RestMethodMediaUploadProtocolsResumable to clients/discovery/lib/google_api/discovery/v1/model/rest_method_media_upload_protocols_resumable.ex.
Writing RestMethodMediaUploadProtocolsSimple to clients/discovery/lib/google_api/discovery/v1/model/rest_method_media_upload_protocols_simple.ex.
Writing RestMethodRequest to clients/discovery/lib/google_api/discovery/v1/model/rest_method_request.ex.
Writing RestMethodResponse to clients/discovery/lib/google_api/discovery/v1/model/rest_method_response.ex.
Writing RestResource to clients/discovery/lib/google_api/discovery/v1/model/rest_resource.ex.
Writing Apis to clients/discovery/lib/google_api/discovery/v1/api/apis.ex.
Writing connection.ex.
Writing metadata.ex.
Writing mix.exs
Writing README.md
Writing LICENSE
Writing .gitignore
Writing config/config.exs
Writing test/test_helper.exs
fixing file permissions
2020-05-12 05:11:26,000 synthtool > No files in sources /home/kbuilder/.cache/synthtool/elixir-google-api/clients were copied. Does the source contain files?
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 102, in <module>
    main()
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/tmpfs/src/github/synthtool/env/lib/python3.6/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/tmpfs/src/github/synthtool/synthtool/__main__.py", line 94, in main
    spec.loader.exec_module(synth_module)  # type: ignore
  File "/tmpfs/src/github/synthtool/synthtool/metadata.py", line 180, in __exit__
    write(self.metadata_file_path)
  File "/tmpfs/src/github/synthtool/synthtool/metadata.py", line 112, in write
    with open(outfile, "w") as fh:
FileNotFoundError: [Errno 2] No such file or directory: 'clients/discovery/synth.metadata'
2020-05-12 05:11:26 [ERROR] Synthesis failed
2020-05-12 05:11:26,031 autosynth > Synthesis failed
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 599, in <module>
    main()
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 471, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 549, in _inner_main
    ).synthesize(base_synth_log_path)
  File "/tmpfs/src/github/synthtool/autosynth/synthesizer.py", line 118, in synthesize
    synth_proc.check_returncode()  # Raise an exception.
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 389, in check_returncode
    self.stderr)
subprocess.CalledProcessError: Command '['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'clients/discovery/synth.metadata', 'synth.py', '--', 'Discovery']' returned non-zero exit status 1.

Google internal developers can see the full log here.

Autosynth passed, closing! :green_heart:


Bug 2093357: hub and spokes: add OCP version retrieval and fix ICE driver

Add functionality to extract OCP version from images and use it as
a helm variable.
Tweak ICE driver example to fix bug 2093357

/cc @yevgeny-shnaidman @cdvultur

This fixes the driver problem. Still wondering if , with the new kernel ( in case of the reboot while OCP upgrades ) the old driver can be loaded or not and what happens in that case.
If it does not load ( error our the service execution ) , will it do the same thing ?

This fixes the driver problem. Still wondering if , with the new kernel ( in case of the reboot while OCP upgrades ) the old driver can be loaded or not and what happens in that case.
If it does not load ( error our the service execution ) , will it do the same thing ?

This is a special situation that should be handled with care. If you know you are going to run into incompatibilities (I need X version of the kernel because some symbols are only there, for example) you would need to plan in advance. This means you would need to build the driver container before the actual upgrade.
What I wonder is when the openshiftVersion from the spoke to the hub is upgraded. If this happens before the machine config template is applied (which I doubt), then you dont have any issues.

From what I see, the openshiftVersion is updated at the end of the upgrade.
If you start upgrade, and run oc get clusterversion you will see the old version of the cluster in the VERSION column and the fact that the cluster is upgraded in the STATUS column. Once it reaches 100% , the VERSION is bumped UP .

/lgtm


Remove Fetch Duplicate error and fix API misuse error

Fix Fetch duplicate error by removing error and leaving a log, moving the completionHandler to the end of didReceiveMessage, and removing unused error code that was breaking a linting test
https://b.corp.google.com/issues/267714994
https://b.corp.google.com/issues/268242388

approving because this is an improvement to the current behavior, but maybe we can discuss the duplicate fetch case a bit more
also - what happens on Android?

Feel free to grab some time to discuss this more and on Android I'm pretty sure they just ignore the second fetch


Db middleware integration

Q
A

Bug fix?
no

New feature?
yes

Tests pass?
not present

Fixed issues
#32

Integration of db_middleware service and queue_worker

Need to add few more parameter from queue_worker (start_time, end_time, requestID)
Tested rest of the  parameters

#34  pending

This branch is ready for merge.
TODO: complete updateStatusOfRequestInDB function


Add Stage keyword update

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.04%) to 89.847%

Files with Coverage Reduction
New Missed Lines
%

src/ast/mod.rs
1
75.97%

src/tokenizer.rs
1
88.25%

src/ast/query.rs
2
86.12%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
6699

Relevant Lines:
7456

💛  - Coveralls


tig: Upgrade to support Cumulus 16

Upgrade to CMA layer 2.0.3
Upgrade java to 11 or 17
Update to 2.0.0 cumulus-message-adapter

David Yen and Randy Yeung have already done a number of lambdas. They will be a great resource for answering questions if you run into issues
https://docs.google.com/spreadsheets/d/1DNrdTa5v5mH5MYiyeILl4NsoXvEKqN3sar_PpLlS94I/edit#gid=0
^ Randy put this spreadsheet together which I think is very helpful

done


rebuild does not work without report-per-database

--rebuild does not generate any output without report per database. I found, that %DBLIST is empty at least at the point where build_incremental_reports is called, but could not find where it's cleared.

Hi,
What command do you use? If I try to reproduce the problem with per database report:
perl pgbadger  --explode -I -O /home/git/pgbadger/report/ /data/pglog/multi-small-files/postgresql-2012-03-20_0[89]*
perl pgbadger  --explode -I -O /home/git/pgbadger/report/ --rebuild

or without, it is just working fine:
 perl pgbadger -I -O /home/git/pgbadger/report/ /data/pglog/multi-small-files/postgresql-2012-03-20_0[89]*
perl pgbadger -I -O /home/git/pgbadger/report/ --rebuild

If you can post a debug output using -v option it could help too.

Does this issue can be closed? Otherwise please give additional the information I've asked.

--rebuild tag use the content of tmp file $TMP_DIR/dblist.tmp which is fed only during some parsing of files.
if you try for the example to use the rebuild param in a container where you never did some parsing without share the $TMP_DIR, the tmpfile is empty, and therefore rebuild won't work.
workaround can be to create manually the tmp dblist file.


🐞[bug]: Back to Top Button appears in home screen

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
The back to top button is always visible even when we are in the hero section
It doesn't look good and go with the design

Also in the bottom sections this button is not clearly visible since it's colour is white and the background is light-themed too

I want to fix this design bug
Please assign me this task
Expected behavior
The back to top button should not appear when we are in the hero section
and it should have a dark colour like black to be clearly visible and distinguishable in the website
Add ScreenShots
No response
What browsers are you seeing the problem on?
Chrome
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24EXTD contributor
[X] I have starred the repository

/aasign to me i can fix it


Feature: respond_to? to test attributes existance

Use case: For example, sometimes LineItems have an origin_location property, while other times they don't.
In my code right now, I test for the existence of the origin_location property using the code line_item.attributes[:origin_location].
If my code does not check for the existence before calling line_item.origin_location, then an exception will be raised.
The idiomatic way of checking for the existence of a method is to use respond_to?(method_name).
IMHO LineItem should return nil when the origin_location property isn't defined, but this is a Pareto improvement.
If you would like a test to cover this new feature, please tell me where and how the test should be implemented.

Re-Check please!

Re-Check please!


Fixes: Display Nested content numbering in title field #59

Signed-off-by: Suhaib Khan<EMAIL_ADDRESS>

Sweet--thanks!


New Chromebrowser instance closes with timeout error after 15sec and page.navigate feature error

Environment: Windows10,  Karate 0.9.6.RC1, IntelliJ Idea Community Edition
Steps:

In KarateDemo maven project, reuse google.feature to create one custom segment.feature file.
Run feature file with  custom product login url  by right click and run option

ISSUE. The browser window opens up with a  login URL request in-progress, but the browser window closes after approx 20 seconds with following error. Timedout after 15000 ms:

If run using selenium, the page loads without any issues after 2-3 minute. How can the default timeout be increased from 15000 ms??

@sgyaneshwar-ic thanks for raising this, we missed adding this to the docs. there is a timeout key where you can over-ride this duration, value has to be in seconds. can you please try and confirm
* configure driver = { timeout: 200, type: chrome }

Peter appreciate your quick response. Thanks for the solution
How can i update this new Karate change in my KarateDemo maven project.
1- I updated karate version from 0.9.6.RC1 to 0.9.5 (back and forth) and was expecting your new change might be available.
2- Then did below change:

configure driver = { timeout: 200000, type: chrome }

Ran feature file and got error
"driver config / start failed: java.lang.Integer cannot be cast to java.lang.Long, options: {timeout=200000, type=chrome, target=null}"

How to get this latest github change available in my karatedemo project

@sgyaneshwar-ic can you follow these instructions and confirm: https://github.com/intuit/karate/wiki/Developer-Guide
also it would be a great help if you can validate this, we added a timeout() method: https://github.com/intuit/karate/tree/develop/karate-core#timeout
once you confirm the latest code works, we can look at expediting a 0.9.6.RC2

Thanks Peter.. this is working... Awesome.
When can we expect 0.9.6.RC2 rolled out?? I would definitely ASAP :) :)

@sgyaneshwar-ic okay, will try within a couple of days - thanks !
I'll keep this open until the final 0.9.6 release

0.9.6 released


feat: [IDP-2420]: Updated the default view for idp stage

Harness Developer Pull Request
Updated the default view for idp stage
What Type of PR is This?

[ ] Issue
[x] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[x] Tested Locally
[ ] Optional Screenshot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65e7ff3276a224bf358fd2e4--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65e815dc8eccdcd1e447c3d1--harness-developer.netlify.app


Expecting to rename node by right-clicking and choosing 'rename' in the context window

I tried double-clicking but was not successful and tried to figure out another way to rename the node in scene.  Eventually I tried to double-click node and was able to rename it.
I think it would be more 'noob' friendly if there was a 'rename' added to the context menu of node that includes the ability to rename the node.
Godot version 3.0.2

Fixed by #18786 / 1378ca1e0.


Update version for the next release (v0.13.1)

Release Notes
This version makes this package compatible with Meilisearch v0.26.0 :tada:
Check out the changelog of Meilisearch v0.26.0 for more information on the changes.
🚀 Enhancements

DRY up the shared models between tests (#274) @brunoocasali
Feature/Add Qualified version (#276) @brunoocasali
Feature/Analytics (#277) @brunoocasali
Fix releaser script (#295) @brunoocasali

Thanks again to @bidoubiwa, @brunoocasali! 🎉

The same philosophy is applied here https://github.com/meilisearch/meilisearch-swift/pull/297#issuecomment-1120440481. Sorry for the inconvenience @bidoubiwa :)


Buttons within the extension do not work in Chrome

Your Docs, Donate and Github buttons do not work in the Chrome extension.
Chrome Version: 87.0.4280.141
Extension version: 1.0.0

Thank you for raising!! That's very odd, it did work when I tested it. I'll take a look. 🙂

Thank you for raising!! That's very odd, it did work when I tested it. I'll take a look. 🙂

Thanks for raising this @MrSuttonmann! 🙏 This will be released in v1.1.0, which will automatically update when I publish v1.1.0 to Chrome & Firefox.

Thanks for raising this @MrSuttonmann! 🙏 This will be released in v1.1.0, which will automatically update when I publish v1.1.0 to Chrome & Firefox.

Thank you @jackdomleo7

Thank you @jackdomleo7


Improve import and structure output formatting?

Hey @twostraws ! 👋🏼
Based on the screenshot here: https://twitter.com/twostraws/status/1354136797496881154/photo/1
I was wondering why imports are word-wrapped instead of formatted like everything else?
I think a format like this would be easier to read:
Imports
    UIKit: 8
    Foundation: 63
    AppKit: 17

Structure:
    UIKit View Controllers: 17
    UIKit Views: 23
    SwiftUI View: 0

(Also, separating "imports" into its own section seems helpful)

Having discussed this with Jesse on Twitter we've come to the conclusion that perhaps breaking the imports up into separate lines would work well if we cap the number of imports by default to some sensible value and show the most frequent ones.
Whatever the cap is, it should be enough that it isn't always just the obvious candidates (UIKit, SwiftUI, Combine, Foundation, etc), but not so many that the list of imports overwhelms the rest of the report. Perhaps top 8?
We would then add a command-line flag to show all imports – perhaps -v for verbose mode, or similar. I would suggest that the JSON output always includes all imports.
I'm going to tag this as a good first issue; hopefully someone can investigate!

Having discussed this with Jesse on Twitter we've come to the conclusion that perhaps breaking the imports up into separate lines would work well if we cap the number of imports by default to some sensible value and show the most frequent ones.
Whatever the cap is, it should be enough that it isn't always just the obvious candidates (UIKit, SwiftUI, Combine, Foundation, etc), but not so many that the list of imports overwhelms the rest of the report. Perhaps top 8?
We would then add a command-line flag to show all imports – perhaps -v for verbose mode, or similar. I would suggest that the JSON output always includes all imports.
I'm going to tag this as a good first issue; hopefully someone can investigate!

Whatever the cap is, it should be enough that it isn't always just the obvious candidates

Actually, now that you mention this, I think I would prefer ignoring UIKit, AppKit, and Foundation, at least for the "non-verbose mode". Then -v (or whatever) would include these common imports.
You literally can't build an app without those frameworks. 😆

Whatever the cap is, it should be enough that it isn't always just the obvious candidates

Actually, now that you mention this, I think I would prefer ignoring UIKit, AppKit, and Foundation, at least for the "non-verbose mode". Then -v (or whatever) would include these common imports.
You literally can't build an app without those frameworks. 😆


Move books to other shelves

Describe the feature you'd like
the possibility to move whole books in other shelves not only pages or sections
Describe the benefits this feature would bring to BookStack users
to add a shelv archiv for old entries

Hi @ssddanbrown
How it's possible? How create book within multiple shelves?

Yeap, @ssddanbrown thx, I found it just now)
@pboatone you can hit "Edit" on shelve page, and moving books through shelves

Thank you @GhostNA @ssddanbrown found it


Max Player Cap (feature request)

Is it possible to add a room setting that caps the number of users allowed to join a room?
So there is a way to cap how many people can join a scene to avoid melting people's machines.
So, whomever creates the original scene can set a max limit.
With a message that says:  "Room full, please try again in a few, or try another room." if another user tries to join.

Yeah, that is definitely a good idea


[5.5] Fix syncing associations return value is incorrect

There are many pairs of models. Syncing Associations.I've set my primary key to be a string, but belongsToMany::syncThe return is an integer, which overflows the integer and cannot get the correct result.This leads me to make an error on the primary key.
#24141

Can you provide some tests for this?

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.
Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.
Thanks!

@jmarcher Okay, I'm writing the test code.
@taylorotwell I will write the test code and explain the change of pull request in detail.


add commit file statuses

Should fix #4313 and ~blocked by https://github.com/go-gitea/go-sdk/pull/135 and https://github.com/go-gitea/git/pull/137~

Dependencies has been merged

@lafriks updated

Is there any work needed before it can get merged?


I did some changes in the main.css file

**Describe the issue that the Pull Request resolves**
I change some styles in the css

**Describe the changes the Pull Request makes**
I made some changes in the /assets/main.css file to make the game choices popup. It's not a big of a difference but I think it improves the style

**Mention the person responsible for reviewing the proposed changes**
Use @ to bring out a list of contributors of this repository and choose the person to tag.(Optional)

MAKE SURE THAT THE PULL REQUEST IS TO THE DEV BRANCH AND NOT THE MASTER BRANCH
ANY PULL REQUEST TO MASTER BRANCH WOULD NOT BE MERGED UNLESS THE CHANGES HAVE BEEN TESTED IN THE DEV BRANCH
YOU WILL HAVE TO MAKE ANOTHER PULL REQUEST TO THE DEV BRANCH IF YOU MAKE THE PULL REQUEST TO THE MASTER BRANCH
@SubhamKarmakar24

Hey @SubhamKarmakar24, I have a university project for contributing in an open source project. If you are okay with the changes that I made, it would be really helpful to accept my pull request.

Hey @SubhamKarmakar24, I have a university project for contributing in an open source project. If you are okay with the changes that I made, it would be really helpful to accept my pull request.

Sure, I'll review the PR.

@Samouil16 The PR has some merge conflicts for merging into the dev branch. Please resolve the merge conflicts. The PR looks fine to be merged


Missing installation guide for non-local clusters

I want to test racetrack running non-locally, so I go here. It tells me to do as I did for the tutorial for deploying locally, except change the addresses. But in the tutorial, it makes me start a KInD cluster and install racetrack on it via a makefile. And thus, it fails.
As far as I can tell, there's no guide for how to install racetrack non-locally. That, or it's not easy to find the installation guide.

If we think from the perspective of someone who has stumbled across this project, wouldn't the least surprising thing be like this?

Click the docs link
Click the "install" section
Click the "Kubernetes" section
See it just tells you to kubectl apply -f path/to/kustomize/manifests


GH-749: Start PTC development

See https://broadinstitute.atlassian.net/browse/GH-749
This PR simply sets up the project structure with clj and implements a start module that prove it can talk to JMS queue. @tbl3rd gets the credits.

I will merge this before it gets too fat.


AMBARI-23565. Restore configs does not work.

What changes were proposed in this pull request?
Now server compares actual agent configs with updated to identify configs that were staled.
How was this patch tested?
Manual testing.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2044/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2045/
Test PASSed.


try .. catch (err) compilation fails inside anonymous functions

Hello,
I've noticed that when attempting to use try .. catch (err) inside an anonymous function, I get an error whilst compiling the AST:
Variable not found: err

Here's a minimal reproduction which fails to compile on the playground:
// Works fine
fn foo() {
    try {
        print(42/0);
    } catch (err) {
        print(err);
    }
}

// Variable not found: err
let bar = || {
    try {
        print(42/0);
    } catch (err) {
        print(err);
    }
};

foo();
bar.call();

Manually declaring err inside of the function seems to work around the issue:
// Works fine
let bar = || {
    let err = "";
    try {
        print(42/0);
    } catch (err) {
        print(err);
    }
};

But i've also noticed some wierd behavior with variable lookups producing incorrect values, I'm unsure whether this is a related issue or not but I was unable to reproduce outside of functions with try/catch:
fn foo(x) {
    let err = "";
    let y = "test2";
    print(err); // ""
    try {
        print(42/0);
    } catch (err) {
        print(err); // "test2"
    }
};

foo("test1");

Version: rhai = { version = "1.0.2", features = ["sync"] }

Good catch!

A new release is out that fixes this bug.

That was fast! Thank you :)


Be explicit about what webhooks are causing issues

If we know enough to determine that a failing webhook is causing issues, we should be helpful enough in specifying the name of it in our service log.

/lgtm


Detect elm root path correctly

At the moment the current project path is set to the directory of the file.
@rojepp took the vscode.workspace.rootPath.
I think both approaches are not sufficient.
The best way would probably to search for elm-package.json in the current and parent folders.

Agreed, it should search upwards recursively until rootpath.
mån 23 nov. 2015 00:03 Sascha Brink<EMAIL_ADDRESS>skrev:

At the moment the current project path is set to the directory of the file.
@rojepp https://github.com/rojepp took the vscode.workspace.rootPath.
I think both approaches are not sufficient.
The best way would probably to search for elm-package.json in the current
and parent folders.
—
Reply to this email directly or view it on GitHub
https://github.com/sbrink/vscode-elm/issues/3.

+1
This is particularly annoying right now because saving an .elm file automatically creates an elm-package.json in the same directory.

@peacememories From Saturday on I'll have 3 weeks for elm hacking.
So I'll fix this on saturday and hope you can wait 2 more days :)

I'm not in much of a hurry right now, my current project is small enough to live in one directory.
Thanks for responding so quickly =)

I've PR fix to that #13. Waiting for review.

#13 Merged, now waiting for release :)

give me a few minutes, will release asap :)
maybe we should use codeship or travisCI for building + release
On Fri, Dec 4, 2015 at 2:51 PM, Krzysztof Cieślak<EMAIL_ADDRESS>wrote:

#13 https://github.com/sbrink/vscode-elm/pull/13 Merged, now waiting
for release :)
—
Reply to this email directly or view it on GitHub
https://github.com/sbrink/vscode-elm/issues/3#issuecomment-161972591.


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative/operations-wg-leads
/assign knative/operations-wg-leads
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/eventing 005d6b6...75253dc:
  > 75253dc Only proxy some headers from the reply in MTBroker filter (# 6357)
  > bba50a4 Upgrade test exports logs before shutting down sender (# 6384)
  > 0a738fd Remove calling 'ExecuteLocalYAML', b/c it is deprecated (# 6380)
  > e7c9ffc Adding retry for 408 (Request Timeout) http status code :recycle: (# 6370)
  > b966175 remove the namespae for the imc (# 6382)
bumping knative.dev/serving 9b7788c...1a99825:
  > 1a99825 Use mako stub for collecting performance tests results (# 12889)
  > fd6b191 fix a flake where the informer didn't have KPA (# 12934)

/lgtm
/approve


Consider deleting the v.next branch

At the time of this writing, v.next is 14 commits behind master, and recent PRs have been initiated directly from feature branches. This is perfectly reasonable, given the maturity of this sample project.
Are there downstream implications to this change (e.g., branch protection, CI jobs, etc.) to consider before resolving this issue?

There are no downstream implications to this change. v.next has gone stale since the release of Mapbook 1.1.

v.next is deleted, closing this issue.


Add Rail 5 compatibility

This is a PR to address https://github.com/85x14/griddler-ses/issues/10.
Let me know if any changes are required.

Any chance we can merge this in? Hitting this issue as well.

@apotapov I plan on supporting the gem if @85x14 doesn't respond. They don't have any public members.

@kmewhort Do you still have access to this repository?

@ccallebs good stuff. Turns out that the emails we are receiving are often larger than 150k which is the SES/SNS limit. So I'm going to have to process them through S3 instead of griddler.
If you do take over the development, might be worth reaching out to the folks at griddler to point to your repo instead of this one.
By the way I was seeing an error using the new sns_message.rb:
19:15:07 web.1    | NoMethodError - undefined method `unpack' for nil:NilClass:
19:15:07 web.1    |   /Users/apotapov/.rbenv/versions/2.3.1/lib/ruby/2.3.0/base64.rb:59:in `decode64'
19:15:07 web.1    |    () Users/apotapov/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/griddler-ses-3bc72638c800/lib/aws/sns_message.rb:115:in `decode'
19:15:07 web.1    |    () Users/apotapov/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/griddler-ses-3bc72638c800/lib/aws/sns_message.rb:44:in `authentic?'
19:15:07 web.1    |    () Users/apotapov/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/griddler-ses-3bc72638c800/lib/griddler/ses/adapter.rb:20:in `normalize_params'
19:15:07 web.1    |    () Users/apotapov/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/griddler-ses-3bc72638c800/lib/griddler/ses/adapter.rb:15:in `normalize_params'
19:15:07 web.1    |   griddler (1.4.0) app/controllers/griddler/emails_controller.rb:17:in `normalized_params'
19:15:07 web.1    |   griddler (1.4.0) app/controllers/griddler/emails_controller.rb:3:in `create'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/action_controller/metal/basic_implicit_render.rb:4:in `send_action'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/abstract_controller/base.rb:188:in `process_action'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/action_controller/metal/rendering.rb:30:in `process_action'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/abstract_controller/callbacks.rb:20:in `block in process_action'
19:15:07 web.1    |   activesupport (<IP_ADDRESS>) lib/active_support/callbacks.rb:126:in `call'
19:15:07 web.1    |   activesupport (<IP_ADDRESS>) lib/active_support/callbacks.rb:506:in `block (2 levels) in compile'
19:15:07 web.1    |   activesupport (<IP_ADDRESS>) lib/active_support/callbacks.rb:455:in `call'
19:15:07 web.1    |   activesupport (<IP_ADDRESS>) lib/active_support/callbacks.rb:101:in `__run_callbacks__'
19:15:07 web.1    |   activesupport (<IP_ADDRESS>) lib/active_support/callbacks.rb:750:in `_run_process_action_callbacks'
19:15:07 web.1    |   activesupport (<IP_ADDRESS>) lib/active_support/callbacks.rb:90:in `run_callbacks'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/abstract_controller/callbacks.rb:19:in `process_action'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/action_controller/metal/rescue.rb:20:in `process_action'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/action_controller/metal/instrumentation.rb:32:in `block in process_action'
19:15:07 web.1    |   activesupport (<IP_ADDRESS>) lib/active_support/notifications.rb:164:in `block in instrument'
19:15:07 web.1    |   activesupport (<IP_ADDRESS>) lib/active_support/notifications/instrumenter.rb:21:in `instrument'
19:15:07 web.1    |   activesupport (<IP_ADDRESS>) lib/active_support/notifications.rb:164:in `instrument'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/action_controller/metal/instrumentation.rb:30:in `process_action'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/action_controller/metal/params_wrapper.rb:248:in `process_action'
19:15:07 web.1    |   activerecord (<IP_ADDRESS>) lib/active_record/railties/controller_runtime.rb:18:in `process_action'
19:15:07 web.1    |   sweet_notifications (1.0.0) lib/sweet_notifications/controller_runtime.rb:21:in `block (2 levels) in controller_runtime'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/abstract_controller/base.rb:126:in `process'
19:15:07 web.1    |   actionview (<IP_ADDRESS>) lib/action_view/rendering.rb:30:in `process'
19:15:07 web.1    |   rack-mini-profiler (0.10.1) lib/mini_profiler/profiling_methods.rb:102:in `block in profile_method'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/action_controller/metal.rb:190:in `dispatch'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/action_controller/metal.rb:262:in `dispatch'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/action_dispatch/routing/route_set.rb:50:in `dispatch'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/action_dispatch/routing/route_set.rb:32:in `serve'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/action_dispatch/journey/router.rb:39:in `block in serve'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/action_dispatch/journey/router.rb:26:in `serve'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/action_dispatch/routing/route_set.rb:725:in `call'
19:15:07 web.1    |   rack-pjax (1.0.0) lib/rack/pjax.rb:12:in `call'
19:15:07 web.1    |   bullet (5.1.1) lib/bullet/rack.rb:12:in `call'
19:15:07 web.1    |   rack (2.0.1) lib/rack/deflater.rb:35:in `call'
19:15:07 web.1    |   remotipart (1.3.1) lib/remotipart/middleware.rb:32:in `call'
19:15:07 web.1    |   warden (1.2.6) lib/warden/manager.rb:35:in `block in call'
19:15:07 web.1    |   warden (1.2.6) lib/warden/manager.rb:34:in `call'
19:15:07 web.1    |   rack (2.0.1) lib/rack/etag.rb:25:in `call'
19:15:07 web.1    |   rack (2.0.1) lib/rack/conditional_get.rb:38:in `call'
19:15:07 web.1    |   rack (2.0.1) lib/rack/head.rb:12:in `call'
19:15:07 web.1    |    () Users/apotapov/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/griddler-ses-3bc72638c800/lib/griddler/ses/middleware.rb:16:in `call'
19:15:07 web.1    |   rack (2.0.1) lib/rack/session/abstract/id.rb:222:in `context'
19:15:07 web.1    |   rack (2.0.1) lib/rack/session/abstract/id.rb:216:in `call'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/cookies.rb:613:in `call'
19:15:07 web.1    |   activerecord (<IP_ADDRESS>) lib/active_record/migration.rb:552:in `call'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/callbacks.rb:38:in `block in call'
19:15:07 web.1    |   activesupport (<IP_ADDRESS>) lib/active_support/callbacks.rb:97:in `__run_callbacks__'
19:15:07 web.1    |   activesupport (<IP_ADDRESS>) lib/active_support/callbacks.rb:750:in `_run_call_callbacks'
19:15:07 web.1    |   activesupport (<IP_ADDRESS>) lib/active_support/callbacks.rb:90:in `run_callbacks'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/callbacks.rb:36:in `call'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/executor.rb:12:in `call'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/remote_ip.rb:79:in `call'
19:15:07 web.1    |   rollbar (2.12.0) lib/rollbar/middleware/rails/rollbar.rb:24:in `block in call'
19:15:07 web.1    |   rollbar (2.12.0) lib/rollbar.rb:735:in `scoped'
19:15:07 web.1    |   rollbar (2.12.0) lib/rollbar/middleware/rails/rollbar.rb:22:in `call'
19:15:07 web.1    |   better_errors (2.1.1) lib/better_errors/middleware.rb:84:in `protected_app_call'
19:15:07 web.1    |   better_errors (2.1.1) lib/better_errors/middleware.rb:79:in `better_errors_call'
19:15:07 web.1    |   better_errors (2.1.1) lib/better_errors/middleware.rb:57:in `call'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/debug_exceptions.rb:49:in `call'
19:15:07 web.1    |   rollbar (2.12.0) lib/rollbar/middleware/rails/show_exceptions.rb:22:in `call_with_rollbar'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/show_exceptions.rb:31:in `call'
19:15:07 web.1    |   railties (<IP_ADDRESS>) lib/rails/rack/logger.rb:36:in `call_app'
19:15:07 web.1    |   railties (<IP_ADDRESS>) lib/rails/rack/logger.rb:24:in `block in call'
19:15:07 web.1    |   activesupport (<IP_ADDRESS>) lib/active_support/tagged_logging.rb:70:in `block in tagged'
19:15:07 web.1    |   activesupport (<IP_ADDRESS>) lib/active_support/tagged_logging.rb:26:in `tagged'
19:15:07 web.1    |   activesupport (<IP_ADDRESS>) lib/active_support/tagged_logging.rb:70:in `tagged'
19:15:07 web.1    |   railties (<IP_ADDRESS>) lib/rails/rack/logger.rb:24:in `call'
19:15:07 web.1    |   request_store (1.3.1) lib/request_store/middleware.rb:9:in `call'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/request_id.rb:24:in `call'
19:15:07 web.1    |   rack (2.0.1) lib/rack/method_override.rb:22:in `call'
19:15:07 web.1    |   rack (2.0.1) lib/rack/runtime.rb:22:in `call'
19:15:07 web.1    |   rack-timeout (0.4.2) lib/rack/timeout/core.rb:122:in `block in call'
19:15:07 web.1    |   rack-timeout (0.4.2) lib/rack/timeout/support/timeout.rb:19:in `timeout'
19:15:07 web.1    |   rack-timeout (0.4.2) lib/rack/timeout/core.rb:121:in `call'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/executor.rb:12:in `call'
19:15:07 web.1    |   actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/static.rb:136:in `call'
19:15:07 web.1    |   rack (2.0.1) lib/rack/sendfile.rb:111:in `call'
19:15:07 web.1    |   rack-cors (0.4.0) lib/rack/cors.rb:80:in `call'
19:15:07 web.1    |   rack-mini-profiler (0.10.1) lib/mini_profiler/profiler.rb:278:in `call'
19:15:07 web.1    |   railties (<IP_ADDRESS>) lib/rails/engine.rb:522:in `call'
19:15:07 web.1    |   puma (3.6.2) lib/puma/configuration.rb:225:in `call'
19:15:07 web.1    |   puma (3.6.2) lib/puma/server.rb:578:in `handle_request'
19:15:07 web.1    |   puma (3.6.2) lib/puma/server.rb:415:in `process_client'
19:15:07 web.1    |   puma (3.6.2) lib/puma/server.rb:275:in `block in run'
19:15:07 web.1    |   puma (3.6.2) lib/puma/thread_pool.rb:116:in `block in spawn_thread'
19:15:07 web.1    |

I'd rather not not share the payload here, but can send over if you like.

@apotapov If you want to send me a message with the payload, you can do it securely here:
https://www.sendwick.com/forms/ccallebs-github
I'll try to address the issues.

@apotapov Sorry, mislinked. Try emailing me directly<EMAIL_ADDRESS>I'll remove the email in ~30 minutes.

Thanks a lot for this, @ccallebs

@ccallebs are you still going to maintain this?

@hadees Definitely willing to.

@ccallebs looks like you've already got a fork, can you just create a new gem?  Then you can contact Griddler and have them link to you.  You should also put up a tip thing because I'll be totally willing to buy you a 🍺 and help mantaining this.

Actually @ccallebs I wonder if @85x14 is even a person.  It looks like @kmewhort is the actual author.

@hadees Fair point, I can rename the gem. I'll do that this evening!

@hadees Would you want to code review the name change over at https://github.com/ccallebs/griddler-ses/pull/2?

@ccallebs I'm going to have a contractor who is working on a project with me look at it too.  @jfelchner  can you look at this?

@ccallebs, just saw this thread after @hadees tagged me a couple days ago.  We're not using this approach any more and I unfortunately don't really have the bandwidth to maintain it right now.  I just added you as an admin to this repo if you'd want to do so here with the existing name - entirely up to you though!

Thanks @kmewhort! I think it's best to keep it here with the existing name. I'll work on merging the changes on my branch and bumping a major version number in process.

@ccallebs @kmewhort - updated the reference in Thoughtbot's README to the new forked version... thanks for the hard work!


context API documentation - readability

Hello!
While learning to use context API, I found the documentation lacks in readability. The md-file on GitHub looks crisp, but in production, at https://reactjs.org/docs/context.html#when-to-use-context the code blocks lacks styling, which makes it harder to read.
Best regards!

My browser messed the formatting up, production is fine! sorry.


Implement batch processing of push/pull for clients

Instead of sending a push/pull request every time, it would be nice to have some automatic mechanism to batch multiple requests together and then send it.

A basic AggregatedBigMatrix (for push requests) was added in #23.


Removed bluebird

Removed bluebird lib in favor of "native" isomorphic method.

Hi @seripap
I checkout your PR but could not find any changes in src files

@guo-yu In factory.js, I removed the Bluebird lib in favor of Babel. (Essentially the same thing)[https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise], just a bit more leaner and removes a not needed dependancy.

Thank you.
I'm going to find out how to add bluebird module for lt Node v4.x users


[QA] GLB Materials Too Reflective

Explorer Alpha build versions:

v0.39.0

Issue Description:
GLB materials have become excessively reflective, losing their original legacy appearance in various locations.
STR:

Use the command /goto 14,100 to teleport to the café.
Go into the café and look at the floor.
Use the command /goto 28,111 to teleport to the theater lobby.
Go into the theater lobby and look at the floor.

Expected behaviour:

14,100 --> Wood texture.
28,111 -- >Tiles with a bit of rough reflection.

Current behaviour:

14,100 --> Reflects the skybox.
28,111 --> very reflective

This issue seems to be partially fixed since the wood floor can be seen and the texture is the correct one but the 28,111 one seems to be still reflective of the skybox

happening on latest dev and latest release (0.49.0)

https://github.com/user-attachments/assets/6efb139d-5e4a-41ae-aa1d-a7c13772a049
https://github.com/user-attachments/assets/fdd184d0-073c-44c4-8d94-55d1fc9674ec


[worker reload] [worker init] $fetch is not defined

Environment

Operating System: Darwin
Node Version:     v16.16.0
Nuxt Version:     3.2.2
Nitro Version:    2.2.3
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      -
Runtime Modules:  -
Build Modules:    -

Reproduction
No response
Describe the bug
As soon as i add @sidebase/nuxt-auth to my nuxt project, as described in the docs, i get this error:

When i remove the package again, the error is gone.
In Nuxt Config i added it under modules as this
modules: [
        '@vueuse/nuxt',
        '@pinia/nuxt',
        'nuxt-lodash',
        'nuxt-swiper',
        '@sidebase/nuxt-auth',
    ],

and under server/api/auth/[...].ts i created this:
import { NuxtAuthHandler } from '#auth';
import Auth0Provider from "next-auth/providers/auth0";

export default NuxtAuthHandler({
    secret: useRuntimeConfig().MEK_ENCRYPTION_SECRET,
    providers: [
        Auth0Provider({
            clientSecret: useRuntimeConfig().MEK_CLIENT_SECRET,
            clientId: useRuntimeConfig().MEK_CLIENT_ID,
            issuer: 'https://' + useRuntimeConfig().VITE_MEK_DOMAIN,
            response_type: 'code',
            audience: useRuntimeConfig().VITE_MEK_AUDIENCE,
            scope: 'openid profile email offline_access',
        })
    ]
});

Problem of the package? am i doing something wrong? help appreciated
Additional context
No response
Logs
No response

Hey @awacode21 👋
This looks like a missing dependency to me - did you resolve the problem in the meantime?

closing issue due to inactivity. Feel free to open a new one or add missing reproduction here, thanks!

@BracketJohn no i am still unable to resolve the problem.


Timezone select

Description
This adds a handy function to the sparse date_helper to generate a select field from PHP's available timezones. Takes optional parameters for HTML class, default value, and timezone filters.
Checklist:

[X] Securely signed commits
[X] Component(s) with PHPdocs
[ ] Unit testing, with >80% coverage
[X] User guide updated
[X] Conforms to style guide

I posted the updated code implementing your format, but I'm not sure that it produces a more desirable global solution. "Timezone abbreviation" doesn't appear to be defined for all valid timezones so falls back to a time offset (+/- #) which itself is inconsistent between ## and #### depending on whole/partial hour and causing #### to get sorted last (probably could be fixed by a sort flag to ksort()).
At the end of the day I think any given user will probably only be selecting a timezone once so it isn't a huge UI hit either way, and given the "messiness" of the problem to begin with we might be picking the lesser evil.

Oh, well damn. yeah if doesn't provide a timezone abbreviation for everyplace globally that just creates an even nastier solution mixing offset and abbreviation so sounds like we should scrap that and go back to what you had. Sorry about that!
I guess that explains with installing an OS typically shows a little map of the world with a few cities highlighted. Do you want to make that happen :) Kidding.

I could probably have the map done before the Email Library is ready. :O (Sorry Jim)
I will revert to the original version. Thanks for the input though, yours is an elegant solution for zones that support the abbreviation.

Actually - the old email lib is back in the repo now so we actually have email again. Yay! So the ball's in my court now to finish up the Migration stuff - which I'll have to get to next week after I get back from a small vacation.

I saw that. I also saw that the rewrite is planned for 4.1, which makes me hesitant to implement it too heavily in modules lest the functions change. A discussion for a different place, for sure...

Understandable

The current "ported Email" is a dog's  breakfast, IMHO.
It is there to say we have it, but I wouldn't flaunt it :-/

:) Well it is better than nothing, or leaving it open to slews of third-party modules post-release (cough auth cough). I'm looking over the code and CI4 wrappers now and am feeling more hopeful that modules could use the email Service and need not too many changes after a proper CI4 library version of Email hits.


Feature Request (Submitted by 5082)

Description
Collection leaderboard
Desired Functionality
Click into a collection to see which users rank top 10 or something in terms of having the most of that collection (would be weird for the easier to get collections, not sure how that could be handled)

duplicate


Update Demo app to show struct-based approach

See #427.

I think we can close this one, it should be implemented in #784.


Minor doc updates to match i2cdev version

The i2cdev links are out of date compared to Cargo.toml

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @posborne (or someone else) soon.
Please see the contribution instructions for more information.


Add offset parameter for getter

This adds an offset parameter to the objects getter to be able to paginate through results.
As discussed here: https://weaviate.slack.com/archives/C02RRQP23K3/p1662041793768329.
Feel free to use this code at your discretion in your own commits if needed.

Hi, could you rebase in the current main and sign our CLA? Then the tests should run and we can review it, thx!


Simplify and fix split configs detection

We use ApplicationInfo.splitSourceDirs to detect whether the application uses split config files.
Those files are created by Android when an AAB is used to deploy application (e.g. via Google Play Store).
When they are present, the base APK file doesn't contain any lib/ directories and we can simply skip
scanning it for those entries, thus saving on startup time.  We used to check whether there are more than
one entry in splitSourceDirs, which used to be the case, but it seems that the recent Android versions
(at least API 33 and newer) can have just a single entry in the array.  Because of that, we were scanning
all the APK files on those Android versions, wasting time at startup.
Fix the check by probing whether array exists and contains at least a single entry.  Additionally, remove
API 21 check, since this is our lowest supported API level.

Unit test?  (I assume this is testable?)

When they are present, the base APK file doesn't contain any lib/ directories and we can simply skip
scanning it for those entries, thus saving on startup time. We used to check whether there are more than
one entry in splitSourceDirs, which used to be the case, but it seems that the recent Android versions
(at least API 33 and newer) can have just a single entry in the array. Because of that, we were scanning
all the APK files on those Android versions, wasting time at startup.

I'm not sure I understand this.
Additionally, I now observe: https://github.com/dotnet/android/blob/4429c5280c63357ef583e3945effcd545d3735d9/src/Xamarin.Android.Build.Tasks/Resources/MonoRuntimeProvider.Bundled.java#L25
splitPublicSourceDirs is used to populate apks, which is registered with native code.
Is there any requirement that ApplicationInfo.splitPublicSourceDirs be consistent with ApplicationInfo.splitSourceDirs?  It looks like "no"?

splitPublicSourceDirs: Full path to the publicly available parts of splitSourceDirs, including resources and manifest. This may be different from splitSourceDirs if an application is forward locked. May be null if no splits are installed.

Is it thus possible to have a scenario in which splitPublicSourceDirs contains only one entry, and thus apks has only one entry, and splitSourceDirs has one entry, and now haveSplitApks is true, whereas before it would be false.
What would this do to app startup?  Would it work properly?  (I can't trivially follow the "split apk" logic in monodroid-glue.cc.)

Unit test? (I assume this is testable?)

When they are present, the base APK file doesn't contain any lib/ directories and we can simply skip
scanning it for those entries, thus saving on startup time. We used to check whether there are more than
one entry in splitSourceDirs, which used to be the case, but it seems that the recent Android versions
(at least API 33 and newer) can have just a single entry in the array. Because of that, we were scanning
all the APK files on those Android versions, wasting time at startup.

I'm not sure I understand this.

Whenever the app is built in the AAB format, Android splits things up into a single base apk and a set of split APKs.
When I originally implemented this code, there were always two split APKs but it no longer appears to be the case as for
e.g. our "Hello world" app, I see just a single split apk.


image validation functionality

This update proposes the following changes relating to issue #84

Validate images before preprocessing and outside of task file and only proceed if validation succeeds
update MNIST example (remove double data validation call)
update validation function for images to include minimum height and width as determined in the task specifications
catch images that cannot be loaded

This looks good, but I think we are now loading the images twice, once for validation and once for preprocessing in the function imagePreprocessing in mnist.js. Maybe we can move the validation in the preprocessing function to avoid this. What do you think?

This looks good, but I think we are now loading the images twice, once for validation and once for preprocessing in the function imagePreprocessing in mnist.js. Maybe we can move the validation in the preprocessing function to avoid this. What do you think?

When I started on the data pipeline I also thought that doing loading once only is the best option. However, I have found a bunch of arguments that would go against this (load of work required for changes and also future compatibility thinking about not only short term but medium term outcomes).
Arguments for image validation separated from tensor loading and network training:

currently the tensor loading happens directly when loading the image. this means the image is not actively checked or passed in the task (mnist for example) file itself. It would require rewriting and redesigning the task files to be able to check on all images as well.
If we do transition from load all images to load only necessary images (formal dataset loading),  we would forward the image loading error into the training process instead of catching it before.
if we validate images before training, we have further future capabilities for checking on bad images or detect data that is not "good for training" (we have not determined that exact definition yet, but it would be open for further progress)

That is why, assuming the garbage collection works well, and time in seconds is not an issue, I would strongly suggest validating images before loading tensors.
Happy to also discuss this in a meeting.


[Package Request]: Rise Media Player

Package Requested

[X] I would like someone else to build the manifest.
[ ] I would like help so I can submit the manifest.
[ ] I have performed a search and couldn't find this package.
[X] I have checked that the installer for this package is not a standalone or portable executable or a .zip file
[X] I think there is a new version available and I have provided the URL.

Please provide the following information
Publisher: Rise-Software
Publisher Url: https://github.com/Rise-Software
Package Name: Rise.App.Rise-Media-Player
Description: One media player for everything you own or stream; whether it's music or videos, online or offline Rise Media Player does it all. And it's beautiful and native with the latest version of WinUI.
Package Version: v<IP_ADDRESS>
Installer URL: https://github.com/Rise-Software/Rise-Media-Player/releases/download/v<IP_ADDRESS>/Rise.App_<IP_ADDRESS>_x86_x64_arm.msixbundle
Current Package Identifier (for new versions): v<IP_ADDRESS>

This software requires you to install a certificate.
Installer failed with exit code: 0x800b0109 : A certificate chain processed, but terminated in a root certificate which is not trusted by the trust provider.

The app is still in beta, so that is probably why the installer does not come with a certificate.

Also, it has good scores on virus scanning these websites:
https://virusscan.jotti.org/en-US/filescanjob/i2s5mflc77
https://www.virustotal.com/gui/file/1d2dabc1aa20b2da8548325f0c98af430e97e46d379c2dee0d771d53e6af2cad?nocache=1

Oh, that's why, ok.


fix failing tests on emotion dataset

There seems to be a known issue with emotion dataset on huggingface failing to download, see:
https://github.com/dair-ai/emotion_dataset/issues/5
The dataset is hosted externally,
Using an alternative link to the dataset on huggingface which is hosted internally.
Update: Also remove normalize parameter as it has been removed on latest scikit-learn pypi package's LinearRegression class to unblock failing builds.

Codecov Report

Merging #75 (23bd3b4) into main (a2138ec) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   70.43%   70.43%
=======================================
  Files          24       24
  Lines        1326     1326
=======================================
  Hits          934      934
  Misses        392      392

Flag
Coverage Δ

unittests
70.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


tutorials(icons): rename  to

icon tag name changed to ion-icon
PR #328 has missed tutorial page

Thanks!


Add listener to dialog buttons

It would be great if there was a way to add a listener from JS to the cancel and submit buttons so that we can know if presenting the dialog should happen later on or never again.

API Hint:
the API does not indicate whether the user reviewed or not, or even whether the review dialog was shown. Thus, no matter the result, we continue our app flow.
if we add a listener is Successful  if flow has finish even if user closes the review window, will sent is successful true also, because of API, would be useful for you ?
https://developer.android.com/guide/playcore/in-app-review/kotlin-java#kotlin

API Hint:
the API does not indicate whether the user reviewed or not, or even whether the review dialog was shown. Thus, no matter the result, we continue our app flow.
if we add a listener is Successful  if flow has finish even if user closes the review window, will sent is successful true also, because of API, would be useful for you ?
https://developer.android.com/guide/playcore/in-app-review/kotlin-java#kotlin

Yeah, you're right, looking at the Android documentation it's not possible to tell whether the dialog is shown, the cancel or submit buttons are pressed. Same things with Apple https://developer.apple.com/documentation/storekit/skstorereviewcontroller.
I'm closing this ticket. Good chat and thank you for the quick reply! :)

Yeah, you're right, looking at the Android documentation it's not possible to tell whether the dialog is shown, the cancel or submit buttons are pressed. Same things with Apple https://developer.apple.com/documentation/storekit/skstorereviewcontroller.
I'm closing this ticket. Good chat and thank you for the quick reply! :)


add CoVoST2

This PR adds the CoVoST2 dataset for speech translation and ASR.
https://github.com/facebookresearch/covost#covost-2
The dataset requiress manual download as the download page requests email address and the URLs are temporary.
The dummy data is a bit bigger because of the mp3 files and 36 configs.

@patrickvonplaten
I removed the mp3 files, dummy_data is much smaller now!


push live

OPS Build status updates of commit 8e215a3:
:clock10: Preparing: average preparing time is 43 sec(s)

OPS Build status updates of commit 8e215a3:
:clock10: Incremental building: average incremental building time is 17 sec(s)

OPS Build status updates of commit 8e215a3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

AdaptiveCards/authoring-cards/getting-started.md
:white_check_mark:Succeeded

AdaptiveCards/authoring-cards/text-features.md
:white_check_mark:Succeeded

AdaptiveCards/docfx.json
:white_check_mark:Succeeded

AdaptiveCards/getting-started/bots.md
:white_check_mark:Succeeded

AdaptiveCards/getting-started/windows.md
:white_check_mark:Succeeded

AdaptiveCards/rendering-cards/host-config.md
:white_check_mark:Succeeded

AdaptiveCards/resources/future.md
:white_check_mark:Succeeded

AdaptiveCards/resources/partners.md
:white_check_mark:Succeeded

AdaptiveCards/sdk/rendering-cards/javascript/extensibility.md
:white_check_mark:Succeeded

AdaptiveCards/sdk/rendering-cards/javascript/getting-started.md
:white_check_mark:Succeeded

AdaptiveCards/sdk/rendering-cards/net-html/render-a-card.md
:white_check_mark:Succeeded

AdaptiveCards/sdk/rendering-cards/net-wpf/render-a-card.md
:white_check_mark:Succeeded

AdaptiveCards/sdk/rendering-cards/uwp/native-styling.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


The Forms of each redirecting page have different designs.

Is your feature request related to a problem? Please describe.
In the form of pages like Become a Volunteer, Donate has a Blue colored submit button whereas, in the Report page the button has a green color.
Describe the solution you'd like
In my opinion, all the buttons can be made uniform matching the color palette of the web app i.e. Beige, Brown color, and respective animation. Can I work on this under GSSOC'23?
Additional context

I am interested to work on this issue under GSSoC 2023 as a contributor


Backport #2941 to 0.13.x

Backporting the asciiGraphWidth setting that was merged in 1.0.x recently

Hi @haochi,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:
http://www.lightbend.com/contribute/cla

@dwijnand Great thanks. I signed the CLA.

Thank you @haochi! And welcome to sbt.


Mute testAutoExpandReplicasToFilteredNodes in FilteringAllocationIT

Summary of the changes / Why this improves CrateDB
Checklist

[x] Added an entry in CHANGES.txt for user facing changes
[x] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

Faling test is testShrinkShardsEnsureLeftOverIndicesAreRemoved

retest this please


Improve editor

[ ] Replace cursesmenu with something thats faster

[ ]  Base address editor menu part

[ ]  Move registers

[ ]  Edit registers

[ ]  Move fields

[ ]  Edit fields

The editor will be removed in the next version in anticipation of GUI


Update filters to conform to Logstash 5.4

I wasn't able to test all of the filters properly, but I'm pretty sure they should be working. It at least got me up and running with the logs I was parsing. Hopefully others can test it more thoroughly. Thanks.
Relates to Issue #37

So, I can parse without getting ruby exceptions, so that's an amazing, but I am getting grok parse failures. I'm also not getting any Raw data into the associated fields (but the fields themselves are getting created according to Kibana)

Would like to request some other prior contributors to test this PR against their setups if they can, the more eyes the better thanks
@breml
@MWilkinson
@saknopper

I don't have an active setup at the moment. Though I might have some time to play around with logstash 5.4 in the following weeks. No promises though...

I no longer work for the company, where we used this logstash configuration. Therefore I have no opportunity to test with recent Logstash versions. Maybe @usp-rol or @elmux may help.

There is little chance to test against logstash5 since we still are running on logstash2. I fear migration to logstash5 (for this component) will not take place within the next time and thus testing against logstash5 won't be planned soon...
still I will ask and come back if there would be good news.

@bitsofinfo What's your recommendation on this? Seems like most people that can test it have and it works for them. How would you like to move forward? Thanks.


Question about weather icons

Dear @mtatsuma,
great module you are providing!
you mention in readme that it is possible to use another set of weather icons.
let assume I have a set a icones I would like to uses, but how does it concrete work?
Do you have a file to put them in?
Thanks in advance and have a great day!
Cédric

Hello @1Cedric1
When you place your icons on a website, you must configure iconURLBase as your site URL.
When you place all your icons at the path MMM-WeatherChart/images/, you must configure iconURLBase as modules/MMM-WeatherChart/images/.
Your image file names must be same with the openweather's ones documented here
Give it a try and let me know if it doesn't work.

@1Cedric1
Is it possible to attach the PNG icon image for snow weather on this issue?
I will try the iconBaseURL config on my magicmirror environment.
I guess that 13n.png and 13d.png files are required for the snow icon.

hello @mtatsuma
I do not know why, but it is suddenly working now  (!)
the only thing it that the icons are too large.
How did you manage to get smaller icons ?

hello @mtatsuma
I do not know why, but it is suddenly working now  (!)
I had to find a convertor for .svg to .png, as the .svg icons are too large on the grafic.
anyway, thank you very much for your help, and congrats for your module !


[Sema] Fix SR-590 Passing two parameters to a function that takes one…

… argument of type Any crashes the compiler
Since this is my first contribution to the Swift compiler, could someone please have a closer look at the changes ;-)

Can one of the admins verify this patch?

Very nice, welcome to swift development!

Please close the SR when you get a chance too, thanks!


Use index operation instead of create

Using the index operation instead of create allows the omission of the ID field.
This makes the listener work with ES > 5.0

Thanks @Yutsa . Your fix helped a lot for integration with OpenSearch!


Tags are messed up.

Looks like the tags are a bit messed up for Bower. Checking out the latest version checks out 0.0.5, but this points to the 0.0.5 tag rather than the v0.0.5 tag. Thus, 3 months of commits are not included.
Would be good to remove the ambiguity of having two 0.0.5 tags. Suggest making a single 0.0.6 tag with latest commit, or adjusting bower.json to resolve to correct tag.

Yes, please fix tagging.

+1

I just fixed the issue in my fork: http://github.com/rbecheras/ui-tinymce

I versionned the bower and npm package to 0.0.6

I tagged it v0.0.6

I also registred the bower package angular-ui-tinymce-v0.0.6

So you can install it instead of the official while the angular-ui team merge my pull request and propagate the tag
$ bower remove angular-ui-tinymce --save
$ bower install angular-ui-tinymce-v0.0.6 --save

THAT FIX TEMPORARY #112 and #127.

I WILL UNREGISTER THIS PACKAGE WHEN ANGULAR-UI TEAM WILL FIXED IT TOO

I just deleted the 0.0.5 tag, this should work as expected now.


T-322 added function to set refresh token

Unit Test Coverage / Review Requirements

Are the changes in this PR covered by unit tests?

no

Does this PR create or modify code without tests?  If so, please explain.
*

How to Test
call setRefreshToken to set a custom refresh token.
Changelog

adds setRefreshToken function

Notes
Just in case someone wants to handle storing token / refreshToken on their own and still use the SDK automatic token refresh logic.

🐴


Add support for images and links in the PagerDuty notification config

This pull request adds two additional fields (images and links) to the data sent to PagerDuty. Users can either provide a static value in the config or provide template strings which allows values to come from the alert definitions and labels themselves.
Note that this only works when using the v2 API. It could be implemented in the v1 api but it has been deprecated so it's probably not worth it.
I've tested it with both static and template values using my PagerDuty instance.

LGTM cc @stuartnelson3 @mxinden


how can I send a message to public channel?

Oh, I've found the answer, by running:
		channel, err := b.ChatByID("@xxxx")


Animated removal and addition of the card chips

A possible implementation is to use AnimatedList class: https://api.flutter.dev/flutter/widgets/AnimatedList-class.html
Each column can be an AnimatedList, we need to tune the insert and remove animations properly
https://medium.com/flutter-community/how-to-animate-items-in-list-using-animatedlist-in-flutter-9b1a64e9aa16
https://medium.com/flutter-community/updating-data-in-an-animatedlist-in-flutter-9dbfb136e515

I used AnimatedList. It was quite an adventure / refactor, but I'm super stoked with the end result


[in_app_purchase] Migrate Android Billing Client to Billing Library version 4 or Newer

The Google Play Console currently shows the following warning when using the latest version
We've detected that this app is using an old version of Google Play Billing. By November 1, 2022, all app updates must use Billing Library version 4 or newer. Update to Billing Library 4 before this date.
I believe this is the dependency that needs to be updated? https://github.com/flutter/plugins/blob/a87497f1399cf6b074dc98563168569d8f738348/packages/in_app_purchase/android/build.gradle#L38

The Google Play Console currently shows the following warning when using the latest version

You aren't using the latest version if you are seeing that warning; you need to flutter pub upgrade so that you have the current version of the in_app_purchase_android implementation package.

I believe this is the dependency that needs to be updated? https://github.com/flutter/plugins/blob/a87497f1399cf6b074dc98563168569d8f738348/packages/in_app_purchase/android/build.gradle#L38

That link is to a version of the repository that's more than a year old. The current version is https://github.com/flutter/plugins/blob/main/packages/in_app_purchase/in_app_purchase_android/android/build.gradle#L56
Closing as a duplicate of https://github.com/flutter/flutter/issues/88664