doc: fix typo

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

I dont think it is a typo. May take this tool as a reference. https://github.com/cargo-bins/cargo-binstall

I dont think it is a typo. May take this tool as a reference. https://github.com/cargo-bins/cargo-binstall

Got it. before this I was following the [How to build and run RisingWave](https://risingwavelabs.github.io/risingwave/build-and-run/intro.html#how-to-build-and-run-risingwave), but there is no mention of install binstall on macOS. i'll open new MR to fix it.

I'm a little surprised, since if you hit this, it means you want to build the doc, but you didn't ever try compiling RisingWave. 🤔 (as mentioned by #19057 (review))
May I ask why do you want to compile it?
But yes I think it's ok to cargo install instead of binstall here, although the latter is better.

I just want to try run mdbook on my notebook because I saw on the document that. but I didn't try to compile the project before.


[Feature Request] Kill process by port number

Description
Sometime we reopen a backend server but it doesn't release the port it used, can it be killed by the port it used?
Use case
As above.

A process can take multiple ports, how to present that in title so that it's searchable in that case?

kl --port 8080

1. Kill all process listening port 8080
2. ProcessName1 PID1
3. ProcessName2 PID2

Maybe like this.


Twitter is not working anymore

Hello,
Twitter calls are not working anymore. Actually the result seems to be returned with a gzip compression.
To solve this, I changed HttpWebRequest to HttpClient in the TwitterDataProvider.cs file.

internal class OAuthRequest
    {
        public async Task<string> ExecuteAsync(Uri requestUri, TwitterOAuthTokens tokens)
        {
            var requestBuilder = new OAuthRequestBuilder(requestUri, tokens);
            HttpClient client = new HttpClient(new HttpClientHandler { AutomaticDecompression = DecompressionMethods.Deflate | DecompressionMethods.GZip });
            client.DefaultRequestHeaders.Authorization = AuthenticationHeaderValue.Parse(requestBuilder.AuthorizationHeader);

            return await client.GetStringAsync(requestBuilder.EncodedRequestUri);
        }
    }

Regards,
Adrien.

Thanks Adrien,
Maybe you could create a pull request with your solution. Once we test it we will include into the master branch to release a version with the fix.

Finally we have implemented a fix with GZipStream class in order to avoid the complexity of cross platform dependencies between 8.1 and 10.
Thanks Adrien for your interest.We hope you to keep involved in waslibs.


Plugin.Geolocator.Abstractions.GeolocationException: A geolocation error occured: Unauthorized

Bug Information
Version Number of Plugin: <IP_ADDRESS>
Device Tested On: iPhone 8s
Simulator Tested On:
Version of VS: 15.9.14
Version of Xamarin: <IP_ADDRESS>
Versions of other things you are using:
Steps to reproduce the Behavior
Unfortunately it happens randomly, but when trying to access the current location I get this exception:

Plugin.Geolocator.Abstractions.GeolocationException: A geolocation error occured: Unauthorized

I believe it started happening after  the latest iOS version updates because the plugin version has been the same for a long time.
Any advice?
Screenshotst

At least five threads with this issue and solutions on stackoverflow.
https://stackoverflow.com/questions/51992016/xamarin-a-geolocation-error-occured-unauthorized

Hi thanks I've already seen that but it's regarding android.
But i did check my code and i do have permissions checks.
I've had it for a long time, and never a problem. I think it started lately after some iOS updates because my code hasn't changed.

On a new install does your app ask for permission for location?
If not try adding code to facilitate the same.
Use the latest of both Plugin.Permission and GeoLocatorPlugin.


tilt errors when yaml has duplicate resources

Repro steps:

Add yaml with the same resource twice

apiVersion: v1
kind: Service
metadata:
  name: doggos
  labels:
    app: doggos
spec:
  ports:
    - port: 80
      targetPort: 8083
      protocol: TCP
  selector:
    app: doggos
---

apiVersion: v1
kind: Service
metadata:
  name: doggos
  labels:
    app: doggos
spec:
  ports:
    - port: 80
      targetPort: 8083
      protocol: TCP
  selector:
    app: doggos

Load that yaml in a Tiltfile

k8s_yaml('my.yaml')

Result:
The Tiltfile fails to load with an error:
unable to find a unique resource name for 'doggos:service:default:'
I think we can all agree that this is a bad and non-helpful error message. But I'm not totally sure what should happen in this case.
Should it be an error? Should it be a warning? Should Tilt quietly use one of the resources and discard the other one? Something else entirely?

this is less urgent now because Tilt discards the duplicate resource silently, bit it might make sense to surface this in cases where a resource is specified twice, but in two different ways


get v0.8.1 branch compile out torchvision==0.9.0a0+7b9d30e

I clone the v0.8.1 branch and compiled it with pytorch 1.7.0,  but at last the compiled version is 0.9.0, does anything wrong?

Hi,
If you checked out the commit corresponding to the 0.8.1 release (which should correspond to https://github.com/pytorch/vision/commit/45f960c5b18679ea42d7e5b4212f17483cdfd8af), you should have a version printed out corresponding to 0.8.0a+45f960c5 , see https://github.com/pytorch/vision/blob/45f960c5b18679ea42d7e5b4212f17483cdfd8af/setup.py#L32-L47
You are picking commit https://github.com/pytorch/vision/tree/7b9d30eb7c4d92490d9ac038a140398e0a690db6 , which was published after the 0.8.1 release and was on a nightly, where we had bumped the version to 0.9.0 already.
I believe this answers your question so I'm closing this issue, but let us know if you have further questions

Hi,
If you checked out the commit corresponding to the 0.8.1 release (which should correspond to https://github.com/pytorch/vision/commit/45f960c5b18679ea42d7e5b4212f17483cdfd8af), you should have a version printed out corresponding to 0.8.0a+45f960c5 , see https://github.com/pytorch/vision/blob/45f960c5b18679ea42d7e5b4212f17483cdfd8af/setup.py#L32-L47
You are picking commit https://github.com/pytorch/vision/tree/7b9d30eb7c4d92490d9ac038a140398e0a690db6 , which was published after the 0.8.1 release and was on a nightly, where we had bumped the version to 0.9.0 already.
I believe this answers your question so I'm closing this issue, but let us know if you have further questions


Version bump to 1.14.5

Thanks!

What does 1.14.5 change? :thinking: I didn't find a CHANGELOG and I wonder if I should update :smile:

Thanks! :wink:


possible to generate addresses from a master public key?

Hi, just curious if this module can be used to generate an arbitrary # of addresses from an MPK?  The examples all seem to require the seed in hex format.

@timbowhite I'm not sure what you're asking?
Perhaps it would be best for you to look at https://github.com/bitcoinjs/bitcoinjs-lib/blob/master/src/hdnode.js.
You can use HDNode.fromBase58 to initialize a HDNode from say xpub661MyMwAqRbcFtXgS5sYJABqqG9YLmC4Q1Rdap9gSE8NqtwybGhePY2gZ29ESFjqJoCu1Rupje8YtGqsefD265TMg7usUDFdp6W1EGMcet8,  and then perform the exact same operations as in the examples in this repositories README.

gotcha thanks!


5.1.2b Clicking on List Sites or pressing return on the desktop list executes the search. If the search box is empty species beginning with ‘A’ are searched for.

Already done!


Adopts standard input syntax for GitHub Actions

Current
in action.yml

json_path
textlint_output

refs

lowerCamelCase<EMAIL_ADDRESS>kebab-case: https://github.com/actions/cache/blob/main/action.yml
snake_case<EMAIL_ADDRESS>

Result
in action.yml

json-path
textlint-output

Result
in action.yml

report-path
textlint-output


bug: wrong favicon.ico when installing Masca snap

Describe the bug
When installing the snap we display the default MetaMask icon.
This should be replaced with the Masca logo
To Reproduce
No response
Expected behavior
No response

Assign me @martines3000


Cannot import dto.factory

from documentation this code won't work
ReadDTO = dto.factory("AuthorReadDTO", Author, purpose=dto.Purpose.READ)
There is no Factory  function in dto module , i  found it in pg starter so i had copied from there and it worked.
It suppose to be in dto module right?

This project has an alternate DTO implementation to starlite. If you are using this lib, see https://topsport-com-au.github.io/starlite-saqlalchemy/v0.29/dto/#configuring-generated-dtos.
I'm currently working on getting a similar pattern into starlite 2.0 as it addresses the static typing issues that the starlite 1.x implementation has. However that is a WIP.
After that is done, this lib will get a refactor around the starlite 2.0 patterns and the lib itself may be moved into the starlite org in some capacity, whether that is via starlite.contrib, or as a standalone lib.

Right now i am building a starter project using this lib. So we should be using WriteDTO = dto.FromMapped[Annotated[Author, dto.config("write")]] this ?

Yep, let me know if you have any problems, but also be aware that there will likely be quite a bit of churn in this library over the coming weeks as starlite 2.0 gets finalised. This lib is still zero-ver, so there will likely still be breaking changes before it is stable.

yes willing to help and test around and upgrade along with api changes , best way is to buiild something with it so i won't mind breaking changes , and will report.


 In general, you would need to handle the various different types of components like text, translation, etc in order to properly construct the full message string.
Assuming you're only dealing with plaintext components like those in this message, though, you can do this with a fairly simply approach. Just pull the base message component out of the packet and recurse through it and its children, casting to TextComponent appending the value of calling "contents()" on each component to a StringBuilder.

Something like this (written off the top of my head so it might not be quite correct):
public String componentToPlainText(Component c) {
    if (!(c instanceof TextComponent)) return c.toString();
    TextComponent tc = (TextComponent) c;

    StringBuilder b = new StringBuilder(tc.content());
    for (Component child : tc.children()) {
        b.append(componentToPlainText(child));
    }

    return b.toString();
}

Thanks it works


Open PR failed

Description
The open PR request is 500. It is possible that this PR is relatively large, it's timeout.
15752 changed files with 216833 additions and 95254 deletions
2024/03/25 12:02:47 ...eb/routing/logger.go:68:func1() [W] router: slow      GET /xxx/test/compare/tmaster...unify_new for xxx:0, elapsed 3894.4ms @ repo/compare.go:714(repo.CompareDiff)
2024/03/25 12:03:13 ...eb/routing/logger.go:68:func1() [W] router: slow      POST /xxx/test/compare/tmaster...unify_new for xxx:0, elapsed 3387.6ms @ repo/pull.go:1375(repo.CompareAndPullRequestPost)
2024/03/25 12:09:22 ...ll/patch_unmerged.go:164:unmergedFiles() [E] Unable to run ls-files -u -z! Error: git ls-files -u -z: context deadline exceeded
2024/03/25 12:09:22 ...ers/web/repo/pull.go:1475:CompareAndPullRequestPost() [E] NewPullRequest: unable to run ls-files -u -z! Error: git ls-files -u -z: context deadline exceeded

Gitea Version
1.21.8
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
1.21.8

try.gitea.io

Git Version
2.40.1
Operating System
docker
How are you running Gitea?
docker gitea/gitea:1.21.8-rootless
Database
PostgreSQL

Maybe this can help you:
https://github.com/go-gitea/gitea/issues/27967#issuecomment-1802737143

We close issues that need feedback from the author if there were no new comments for a month. :tea:


Tutorial: Jupyter and FastHTML

name: Pull Request
about: Propose changes to the codebase
title: '[PR] Tutorial for using Jupyter and FastHTML together'
labels: 'documentation'
assignees: ''

Related Issue
#469 Tutorial for using Jupyter and FastHTML together
Proposed Changes
This is a tutorial designed to demonstrate how to run FastHTML in Jupyter.
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Screen capture

@jph00 What do you think?

Looks good! @pydanny one nice addition would be to discuss how you can modify an HTMX handler by simply executing a cell, and you don't have to restart the server or re-run HTMX(). Also mention if you modify the home page however, you do have to re-run HTMX() (but not the server).
Oh also mention that you can go to localhost:8000 in another tab to see a full screen view.


feat: add get_genesis_block rpc method

Codecov Report
Base: 76.81% // Head: 76.75% // Decreases project coverage by -0.05% :warning:

Coverage data is based on head (a51d50f) compared to base (0ae7014).
Patch coverage: 25.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #78      +/-   ##
===========================================
- Coverage    76.81%   76.75%   -0.06%
===========================================
  Files           23       23
  Lines         4205     4208       +3
===========================================
  Hits          3230     3230
- Misses         975      978       +3

Flag
Coverage Δ

unittests
76.75% <25.00%> (-0.06%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/service.rs
65.70% <0.00%> (-0.26%)
:arrow_down:

src/storage.rs
94.38% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add support for -Dbuild.version_qualifier and remove usage of mapping types

Description

Adds support for -Dbuild.version_qualifier in build.gradle
Changes OpenSearch version being used from 2.0.0 to 2.0.0-alpha1
Removes usage of mapping types

Issues Resolved
#379 #375
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The backend GitHub Actions are failing because the common-utils snapshot is a couple of days old which had some changes for Notifications (I believe the infra team is looking into the blocker but it's not due to common-utils itself).
The frontend GitHub Actions are failing because changes in OpenSearch-Dashboards seems to have caused minor differences in the rendered output in the Jest tests. I checked the output and tested manually and the functionality seems to be unaffected so I'll submit a follow-up PR to update the snapshots.

Backend tests are passing locally though (with common-utils published locally):
qreshi@186590ce20fd notifications % ./gradlew build
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 7.3
  OS Info               : Mac OS X 10.16 (x86_64)
  JDK Version           : 14 (OpenJDK)
  JAVA_HOME             : /Library/Java/JavaVirtualMachines/jdk-14.0.1.jdk/Contents/Home
  Random Testing Seed   : 24D2FCE440F7256E
  In FIPS 140 mode      : false
=======================================

...

BUILD SUCCESSFUL in 6m 39s
55 actionable tasks: 13 executed, 42 up-to-date


Upgrade to new packages interface

Fixes #4

Seems to work fine.

Hope it will be merged soon !

This is creating a new variable srcdata that is not used, while src is still being initialised as an empty interface right on the next line. Would this https://github.com/stamblerre/gocode/pull/6/files#diff-2f3534b5589688ddc04474bf8087dfe5R138 be better ?

@joaojeronimo changing it such will change the behavior of the code. It might be still correct, but I don't know the code that well to say for certain.

Please merge, Microsoft/vscode-go is unusable and it is probably the largest usage of this library.
No change is breaking most projects depending on your lib.

Sorry about not merging this earlier--somehow didn't get a notification for this. Should be fixed now.


Add support for "before_request" and "after_request" hooks

This PR adds ''before_request" and "after_request" hooks.
These are directly borrowed from flask, with two differences:

Async support
You can define these functions on all layers - app, router,  controller, method/function, and the lowest level takes precedence.

Could consider adding something like this as a pre-commit hook to help ensure the __slots__ definitions don't get messed up.


Event list implementation

Implement Event List and its derivative classes.
Implement adding and removing event from a trip's itineraries functionality.
Fixed most checkstyle issue, except one refactoring regarding the public modifier in the AddressBook class.

Codecov Report

Merging #39 (3428252) into master (91e8ebf) will decrease coverage by 4.24%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master      #39      +/-   ##
============================================
- Coverage     36.07%   31.82%   -4.25%
  Complexity      399      399
============================================
  Files           140      159      +19
  Lines          2464     2793     +329
  Branches        250      286      +36
============================================
  Hits            889      889
- Misses         1543     1872     +329
  Partials         32       32

Impacted Files
Coverage Δ

src/main/java/seedu/address/ui/PersonCard.java
0.00% <ø> (ø)

...rc/main/java/seedu/address/ui/PersonListPanel.java
0.00% <ø> (ø)

src/main/java/seedu/travelr/MainApp.java
0.00% <ø> (ø)

...main/java/seedu/travelr/commons/core/Messages.java
0.00% <ø> (ø)

...rc/main/java/seedu/travelr/logic/LogicManager.java
0.00% <0.00%> (ø)

.../java/seedu/travelr/logic/commands/AddCommand.java
0.00% <0.00%> (ø)

.../seedu/travelr/logic/commands/AddEventCommand.java
0.00% <0.00%> (ø)

.../travelr/logic/commands/AddEventToTripCommand.java
0.00% <0.00%> (ø)

...ava/seedu/travelr/logic/commands/ClearCommand.java
0.00% <ø> (ø)

...va/seedu/travelr/logic/commands/DeleteCommand.java
0.00% <0.00%> (ø)

... and 48 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


i18n(es): update imports

Description (required)
Updates imports

Related issues & labels (optional)

Closes #N/A
Suggested label: i18n

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

es
guides/imports.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Hi @dreyfus92 There was a new commit https://github.com/withastro/docs/pull/8981

Thank you for the heads up @liruifengv 😁


Appropiate logging when a LockTimeout for VCS is reached

Related #3856

Yes, I also noted those. I need to fix them.

Believe we can ignore the codecov issues here -- it feels wrong, and I will merge.


Merge develop into master for release

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

GitHub release
v1.1.0

Your semantic-release bot :package::rocket:


issue with discovery?

Hi,
the CPU temperature does not appear as in the discovery rule it shows this error see picture

Thank you

I need a full error output e.g. ./mini_ipmi_lmsensors.py get NON and sensors -u output.

You should try new version also: https://github.com/nobodysu/zabbix-mini-IPMI/pull/38

Thanks for the reply, this is what i get
root@prometheus4:/etc/zabbix/scripts# ./mini_ipmi_lmsensors.py get NON
Traceback (most recent call last):
File "./mini_ipmi_lmsensors.py", line 272, in
getOutput_Out = getOutput()
File "./mini_ipmi_lmsensors.py", line 68, in getOutput
pSplit = p.strip()
AttributeError: 'NoneType' object has no attribute 'strip'
as for the update i installed it around 4 days ago
Thank you

lmsensors not installed? Fix incoming.

So it seems i needed to install
sudo apt-get install lm-sensors
after that i ran root@prometheus4:/etc/zabbix/scripts# ./mini_ipmi_lmsensors.py get NON
root@prometheus4:/etc/zabbix/scripts# ./mini_ipmi_lmsensors.py get NON
{
"data": [
{
"{#CPU}": 0
},
{
"{#CORE}": "0",
"{#CPUC}": 0
},
{
"{#CORE}": "1",
"{#CPUC}": 0
},
{
"{#CORE}": "2",
"{#CPUC}": 0
},
{
"{#CORE}": "3",
"{#CPUC}": 0
}
]
}
I guess i need to wait till it refreshes on zabbix

after a while im seeing the data coming that was it needed to install lm sensors

just a quick question, as for the temperature threshold is it possible to change it? or is it possible to change it for certain hosts?

I'm referring to lmsensors in the latest version.
Tjmax could not be changed.
In the template there are a Macros tab for global thresholds.
In specific host there are Macros - Inherited and host macros section for host-specific thresholds.

Thank you for the quick reply, i ended up changing it on the trigger section which says
| {Template mini-IPMI v2:mini.disk.temp[MAX].last(500)}>46
-- | --
i changed the value to 52


TypeError: Cannot read properties of undefined (reading 'title')

The title section is not reflected.
Do you know the cause?
ules/react-dom/cjs/react-dom-server.browser.development.js:5946:7) {   page: '/' }   80 |                 <h3 className={styles.postTitle}>   81 |                   <Link href={/${post.id}`}>

82 |
|                                                     ^
83 |
84 |
85 |`

I had the same issue. When you create a new database, it has empty rows. Remove all entries and create a new page with a title and content. Then I got another error regarding plain_text:

TypeError: Cannot read properties of undefined (reading 'plain_text')

This issue could be fixed by prefixing all occurrences of .plain_text with a ? operator:
https://github.dev/samuelkraft/notion-blog-nextjs/blob/3726cd1aae7e9d9c4fd578af4494bbd3c6358111/pages/[id].js#L106-L185

Make sure your table is setup like the example provided, just like @zirkelc suggested.


PoS system description

closes #321

Is this up-to-date with the latest state in #385?

Is this up-to-date with the latest state in #385?

Mostly, yes. There are few smaller differences and since we figured out more details of VP validation and integration in code now, it could be better described now.
I'll update this next week, once done with the main features in code 🤞

Is this up-to-date with the latest state in #385?

Mostly, yes. There are few smaller differences and since we figured out more details of VP validation and integration in code now, it could be better described now.
I'll update this next week, once done with the main features in code

Great; I'll re-review it once everything is up to date.

Is this up-to-date with the latest state in #385?

Mostly, yes. There are few smaller differences and since we figured out more details of VP validation and integration in code now, it could be better described now.
I'll update this next week, once done with the main features in code

Great; I'll re-review it once everything is up to date.

This PR is now up-to-date for the MVP implemention in #385


delete files that are no longer needed

It would be supernice, if there was a way to automatically remove files (and directories) that are leftover from tests that do not exist anymore.
Tests are renamed regularly and after that you (or at least I) have a lot of leftover datafiles that I need to remove manually.

Hi @luerhard,
Thanks for the suggestion!
I've felt this need myself in the past, but there are a few details that complicate things:

The data directories might contain files other than the ones handled by pytest-regressions, so it is not really safe for us to remove anything there, I believe.
The data directory is managed by pytest-datadir, so my impression is that it would need some sort of similar feature in there, that might overlap here (for example, delete data_ directories which don't have an associated test_ file).

Those are my thoughts, but feel free to suggest solutions if you come up with anything. 👍

Hi @nicoddemus, thanks for the reply !
A few thoughts on that:
I am not really sure why someone would store any files other than pytest-regressions data files in those folders. Is there any good reason for this?
If there is, I see two possibilities to handle that:

either one has to track all created files in a .pytest_reg file or database or something similar
or we could hide the data_ directories as .data_ directories to point out that nobody should store anything else inside apart from the test-data-files.

This would be an interesting feature, but other tests using pytest-datadir use files in the same data_* directory. For example:

def test_read_module(datadir):
    contents = (datadir / 'spam.txt').read_text()
    assert contents == 'eggs\n'

def test_data(data_regression):
    data = {"foo": 1}
    data_regression.check(data)

That makes automatic cleaning potentially dangerous.


Merge pull request #114 from GregorioDiStefano/certs_issues

Certs issues
(cherry picked from commit fd90a871ea9f88c6edb8440969cbf37a47bd8af9)

@estenberg

@eysteins


[AIRFLOW-752] Add Mercadoni to list of Airflow users

Add Mercadoni to the list of Airflow users.
Dear Airflow Maintainers,
Please accept this PR that addresses the following issues:

https://issues.apache.org/jira/browse/AIRFLOW-752

Current coverage is 67.22% (diff: 100%)

Merging #1991 into master will increase coverage by 0.03%

@@             master      #1991   diff @@
==========================================
  Files           135        135
  Lines         10356      10356
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           6958       6962     +4
+ Misses         3398       3394     -4
  Partials          0          0

Powered by Codecov. Last update 1caaceb...f18bca5

Welcome Aboard!

Thanks, I will be spreading the word about Airflow at PyCon Colombia!!!


API Reference doc link links to .NET reference docs

API Reference link in readme links to .NET reference docs on docs.microsoft: https://docs.microsoft.com/en-us/dotnet/api/azure.security.keyvault.keys?view=azure-dotnet

Thanks for finding and reporting it @lilyjma!
cc @vhvb1989 - we may want to do a scrub of other potential links that might need updating


Fixes CLI calls for 'port related' operations.

Addresses issue #549
Amended to incorporate re-factored API call that requires to
provide a  as an argument for every port related operation.

@knikolla @kylehogan
This is a small PR but import for engage 1.
Please review it when you get time, so that we can merge it with the master to the earliest.

can the names of the functions defined in cli.py ('port_register' and 'port_delete') also be changed to match api.py ('switch_register_port' and 'switch_delete_port')?
other than that it looks good

can the names of the functions defined in cli.py ('port_register' and 'port_delete') also be changed to match api.py ('switch_register_port' and 'switch_delete_port')?

I don't think so. Ports are for switches, therefore no point in stating the obvious.
But I while we are at it, I would like to change the name of port_delete
to  port_unregister, for consistency sake.
@kylehogan @henn @zenhack
What do you guys think ?

Re: consistency, nothing else is named *_unregister, so I don't see how that helps.
I think @kylehogan is right; we should rename to switch_*_port. This is consistent with the node_*_nic calls. The naming is a bit odd, and it basically comes down to trying to map a somewhat object-oriented notion onto a purely procedural interface; It's called node_register_nic because it's conceptually a method on the node. In the past I've toyed with the idea of doing some meta-programming goop on the server side to make this actually how it works (e.g. /node/<node>/<stuff> fetches the node object and then dispatches from there based on <stuff>), and while I came to the conclusion that it was a bad idea, it helps illustrate what's going on there conceptually.
I'll point out that the reason for the renaming is not that the server and client side should match; the server side is strictly an implementation detail (the public api is the HTTP request) so from the client's perspective it doesn't really matter what they're called. The functions don't even need to map one to one (and they actually don't; see network_create_simple). But the above explains the reasons the server-side name was changed, and the same reasoning applies to the client in this case.

So what is the general consensus, change the API names are not ?

If we all do not have a consensus, we can just merge this the way it is.
Engage 1 deployment depends on this.
We will worry about the change of API names in future.

My vote is for making the name change that @kylehogan suggested.

This PR is focused on adding cli calls for port operations. So let this do just that.
I will create another PR for changing API names at a later point.

+1

Sounds good to me. Sanity check, since we don't actually have unit tests for the cli: you did try this, correct? If so, you have my +1 as well (and can thus merge).

I tried these cli operations before commiting


[TASK] Admin Edit/Add User bug Fixes

Description
When adding and editing new users from admin member setting the following issues need to be fixed

Form Validation reason needs to in red font
check if phone numbers are required
when editing the email, editUser required the parameter passed in to be newEmail not email.

Existing
Is there any relevant code or ui feature that the developer should know about when resolving this issue.
Reference
This issue references. . .

Tasks
What are more specific tasks that a developer needs to take to consider this issue resolved.

@johbaxter  Matt Freshwaters is going to work on this
he wants to know if the phone is required when adding/editing a user

I do not think it is required off my head.  Please take a look at our logic for register, it should match to that exact logic.  We can also look at the validation we have on the BE for this.  Take a look at the API route, do we require it on Edit and Add, if so lets just match that logic

@ppatel9703 @johbaxter This is wrapping up - quick question because I noticed what I thought were 2 smaller bugs during this, not sure if I should go ahead and create new tickets for them? Or if we want to add on here. Primarily:

When clicking edit on a user, I don't see the email field being populated from the original value (not sure if that is intended)
The regex to detect a phone number thinks the following is valid ('123-456-') it stops checking after the second hyphen, so this regex should be updated to detect for a full 10 digit phone number.

@mattfreshwaters @johbaxter Matt if you have time, go ahead and address those two issues as well. I'll update to the ticket to include those two bugs (not sure if you have access to)
If you don't have time we can make a new ticket and sign it off during sprint review.

@ppatel9703 Sounds good! Need to nail down to things for MDE today but I'll get cracking on it asap

@mattfreshwaters please put estimated completion data.  Just for planning on my side with code review

@johbaxter Lets say this Friday Sept 27th - client work permitting, will update if that seems unrealistic later on in the week


Avoid unsupported type of num.toBytes

Please only commit the new methods :+1:

done, I rebased it

Well actually, num is a union type of int and double. So the exception was never possible.
But I like splitting it up and have it statically checked.


Azure subscription not connecting to Visual Studio Code

I am having difficulty connecting my Azure subscription to Visual Studio Code.
Below is the error I am getting in Visual Studio Code.
No subscriptions were found. Set up your account at https://azure.microsoft.com/en-us/free/.

It appears your account has been connected, but it didn't find any subscriptions. Can you confirm you set up your account at the specified link?


microsoft.clearscript.v8 in use promise but return this {[undefined]} or {Microsoft.ClearScript.V8.V8ScriptItem.V8ScriptObject}

In this code I am using microsoft.clearscript.v8 library in c# (asp .net core mvc)
how to solve this error '((Microsoft.ClearScript.ScriptItem)promiseResult).UnderlyingSystemType' threw an exception of type 'System.NotImplementedException' in server side javascript run on asp .net core mvc
this below code is Home controller in call js file()
  `public IActionResult Index()
     {

    using (var engine = new V8ScriptEngine())
    {
        string scriptPath = Path.Combine(Directory.GetCurrentDirectory(), "wwwroot", "js", "NewScript.js");
        string scriptContent = System.IO.File.ReadAllText(scriptPath);
        engine.Execute(scriptContent);

        try
        {

            dynamic promiseResult = engine.Script.newfunction();

           ViewBag.Result = promiseResult;

        }
        catch (Exception ex)
        {
            // Handle exceptions if the promise is rejected
            string result = $"Error: {ex.Message}";
            ViewBag.Result = result;
        }

    }
  }`

this below code in JavaScript NewScript.js
  `function newfunction() {
  const promise1 = Promise.resolve("This is promised 1");

promise1.then((value1) => {
   return value1;
  });

}`

this newfunction return this {[undefined]} or {Microsoft.ClearScript.V8.V8ScriptItem.V8ScriptObject}
get this error UnderlyingSystemType = '((Microsoft.ClearScript.ScriptItem)promiseResult).UnderlyingSystemType' threw an exception of type 'System.NotImplementedException'

Hi @NamanGajjar26,

this newfunction return this {[undefined]} or {Microsoft.ClearScript.V8.V8ScriptItem.V8ScriptObject}

As shown above, newfunction returns no value; that is, it always returns undefined. Also, your Index method doesn't compile, because it doesn't return anything. Please clarify or provide a more complete sample.

get this error UnderlyingSystemType = '((Microsoft.ClearScript.ScriptItem)promiseResult).UnderlyingSystemType' threw an exception of type 'System.NotImplementedException'

We've tested your code in a newly created ASP.NET Core project, and we didn't see that exception. It's true that script objects in ClearScript throw NotImplementedException for the UnderlyingSystemType property, but we aren't clear about why that property is being invoked. Can you share a stack trace?
Thanks!

solved this error

thank you for answering my question


Server

This is more a request or future idea:
With the plethora of cloud services and VPSs out there, it would be great to have a "magic-wormhole-server" that is easy to install, would allow friends & family to use it to exchange files and messages right from their browsers (no commandline app that needs to get installed first for them..!).
This would also get around the obstacle for Android 10+ app development, because it would just work in a web browser to up&download files.
As a bonus, this server could also incorporate a relay service and a transmission service (but the issue of trust would be an obstacle).
The nice thing about a web-magic-wormhole would be that it is still interoperable using the existing apps to send or receive.

There is at least one Web implementation in the works already: https://github.com/LeastAuthority/MyFileTransfer


MUI v5 has problems with Storybook when overriding multiple components global styles

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
const theme = createTheme({
	components : {
		MuiCard : {
			styleOverrides : {
				root : {
					background : "transparent",
					margin : 0,
				}
			},
		},
		MuiCardMedia : {
			styleOverrides : {
				root : {
					borderRadius : 5
				}
			}
		}
	}

});

I'm using MUI v5 with Storybook:
when i'm override MuiCard component's global style i've not problems, but when i want to override MuiCardMedia too changes aren't avaible inside storybook story.
Someone has similar problems usign storybook?
Thanks indeed for any suggest.

Please provide a CodeSandbox (https://material-ui.com/r/issue-template-latest), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem.
It will be more understandable.
Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve
Thank you


🚧Update Readme

Complete The Item Below

[X] I have updated the title without removing the 🚧 emoji.

Description
We are in the process of rationalizing ReadMe across all GitHub Actions (GHA). This includes:
Making sure all sections are in this order:

Logo
Repo Name
Badges
What is it
Quick Note
Quick Example
Action Input
Action Output
Examples
Contrib/Funding (after combined like in lib section)
Maintainers
License

Details of the changes to the sections are below:
Logo (CMW to create)

Note Calvin needs to create a logo from scratch.

Add Badges Section

Note Calvin will do this

Good first issue
Chat on discord
~- Prod Build status~
~- Prev build status~

What is it Section

Use what is currently in this section after spelling and grammar checks

Quick Note Section

Change to say Warning block instead of Quick Note

Quick Example Section

Make sure the "more examples below" link is on the right side.

What does it do? Section

Remove section

Action Input/Output Section

Add "Action Outputs" section, but do not add a table with the outputs in it. The output is a boolean value. Goes below Action Input section.

Note Calvin will do this.

Examples Section

Remove section

Note Calvin will do: In the quick example at the top, add the optional fail-when-not-found input.  Make sure to add a quick note with a finger pointing emjoi to the right of the input to describe that it is optional.

Contribution Section

Change title to Contributing
Add section, make general (don't use repo or project name)
To learn how to contribute your time click here (link to Contributing doc). To learn how to contribute funds to this project, click here.

Maintainers Section

Add section like in Velaptor
Remove "Project Maintainers" text and ancillary information.  The section should only be two lines: one for CMW and one for KSW

License Section

Add section just like in Velaptor; with badges etc.

Other

Double checking spelling/grammar
Making wording the same in similar sections
Make sure "Back to the Top" link is on the right
Remove any TODO comments
Verify all links work and point correctly

Acceptance Criteria

[ ] Make sure all sections are in this order:

[ ] Logo
[ ] Repo Name
[ ] Badges
[ ] What is it
[ ] Quick Note
[ ] Quick Example
[ ] Action Input
[ ] Action Output
[ ] Examples
[ ] Contrib/Funding (after combined like in lib section)
[ ] Maintainers
[ ] License

[ ] Logo created and added

Note Calvin needs to create a logo from scratch.

[ ] Add Badges

Note Calvin will do this

[ ] Good first issue
[ ] Chat on discord
[x] ~Prod Build status~
[x] ~Prev build status~

[ ] Perform spelling and grammar checks in the What is it section
[ ] Change the Quick Note section to Warning block
[ ] Move the more examples below link is to the right side.
[ ] Remove the What does it do section
[x] An Action Outputs section is created below the Action Inputs table.

Note Calvin will do this.

[x] Remove Examples section

Note Calvin will do this

[x] Add the optional fail-when-not-found input.

Note Make sure to add a quick note with a finger pointing emjoi to the right of the input to describe that it is optional.

[ ] Update the Contibution Section

[ ] Change the Contribution title to Contributing
[ ] Add one link that points to the Contributing doc for time contributions

[ ] To learn how to contribute your time click [here](https://github.com/KinsonDigital/.github/blob/master/docs/CONTRIBUTING.md)

[ ] Add one link that points to GitHub sponsors for monetary contributions

[ ] To learn how to contribute funds to this project, click [here](https://github.com/sponsors/KinsonDigital)

[ ] Add section, make general (don't use repo or project name)

[ ] Add Maintainers section like in Velaptor

[ ] Remove "Project Maintainers" text and ancillary information.  The section should only be two lines: one for CMW and one for KSW

[ ] Add License section just like in Velaptor; with badges
[ ] Double checking spelling/grammar
[ ] Making wording the same in similar sections
[ ] Make sure "Back to the Top" link is on the right
[ ] Remove any TODO comments
[ ] Verify all links work and point correctly

ToDo Items

[X] Change type labels added to this issue.  Refer to the Change Type Labels section below.
[X] Priority label added to this issue.  Refer to the Priority Type Labels section below.
[X] Issue linked to the correct project (if applicable).
[X] Issue linked to the correct milestone (if applicable).
[x] Draft pull request created and linked to this issue (only required with code changes).

Issue Dependencies
No response
Related Work
No response
Additional Information:
Change Type Labels

Change Type
Label

Bug Fixes
🐛bug

Breaking Changes
🧨breaking changes

New Feature
✨new feature

Workflow Changes
workflow

Code Doc Changes
🗒documentation/code

Product Doc Changes
📝documentation/product

Priority Type Labels

Priority Type
Label

Low Priority
low priority

Medium Priority
medium priority

High Priority
high priority

Code of Conduct

[X] I agree to follow this project's Code of Conduct.

@kselena I added 2 badges but not the prod and prev status check badges.
The reason for this is because I have to create the workflows for these badges and they do not exist.  I also cannot create the workflows yet because we are changing the branching model for the all actions so that dictates how the workflows work.


[Feature request] Adding custom effects

Not sure it this is a feature request or a bug
but when I add path to static wallpaper that is a *.gif the plugin doesn't display it.
It would be nice to have an editor to create those effects.
Also, good job with the plugin :)

Hi，
Static wallpaper image files do not support wildcards, such as *.gif, you can use absolute paths or relative paths to point to specific image file names, such as e:\images\demo.gif (windows) or /home/user/images/demo.gif (Linux) or attachments/demo.gif.
At present, dynamic effects are controlled by JavaScript, and codes need to be written. There is currently no proper way to build an editor. But I will consider your suggestion.
I'm glad you like this plugin, thanks.


Fix skipping too often in od_pvq_encode

The variable tell in od_pvq_encode() can sometimes be calculated
negative but is unsigned.
So it blows out the comparison skip_diff <= OD_PVQ_LAMBDA/8*tell.
Make it signed, as it is in od_pvq_rate().
This fixes #166.

@jmvalin This fixes the issue I raised with you regarding https://github.com/xiph/daala/commit/5e7010eb58059860ea1f6e439d9894d8b9181fc3

There is a small gain due to better decisions about skipping.
           RATE (%) DSNR (dB)
    PSNR -0.00898823 0.000430187
 PSNRHVS -0.0266512 0.00174076
    SSIM -0.0236835 0.000961467
FASTSSIM -0.152803 0.00434009

Applied in commit fa67c327a51710f3165ddcfe82e68c0d533a79bc, thanks.


[Event Request] Codeunit 5601 "FA Insert G/L Account" - "OnInsertBufferBalAccOnAfterAssignFromFAPostingGrAcc" - Change reference type

Please change the reference type of parameter "FAGLPostBuf" at event publisher "OnInsertBufferBalAccOnAfterAssignFromFAPostingGrAcc" in Codeunit 5601 "FA Insert G/L Account" to "var".
Old Publisher:
local procedure OnInsertBufferBalAccOnAfterAssignFromFAPostingGrAcc(FAAllocation: Record "FA Allocation"; FAGLPostBuf: Record "FA G/L Posting Buffer")
New Publisher:
// start kvspsa - Event Publisher - Referencetype of parameter "FAGLPostBuf" changed
local procedure OnInsertBufferBalAccOnAfterAssignFromFAPostingGrAcc(FAAllocation: Record "FA Allocation"; var FAGLPostBuf: Record "FA G/L Posting Buffer")
// stop kvspsa

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Argument of type 'AsyncThunkAction<{ id: number; }, void, AsyncThunkConfig>' is not assignable to parameter of type 'UnknownAction'.

I made a demo, it does not work after defining the typed hooks, And the vscode has the same issue, So It's not a bug with stackblitz's typescript server.
"react-redux": "^9.1.0"
"@reduxjs/toolkit": "^2.2.2"
"@types/react": "^18.2.47"
"@types/react-dom": "^18.2.18"
"typescript": "^5.4.3"
I don't know what caused it, it's too uncomfortable.

duplicate of https://github.com/reduxjs/redux-toolkit/issues/4299, please don't open the same issue in multiple repos


Spelling Mistake (read: classic Swift edit)

Project URL

Description

Checklist

[ ] Only one project/change is in this pull request
[ ] Addition in chronological order (bottom of category)
[ ] Supports iOS 7 or later
[ ] Has a commit from less than 2 years ago
[ ] Has a clear README in English

          1 Error

  :no_entry_sign:
  Found 1 link issue

Link issue by awesome_bot

Line
Status
Link

852
Error
https://www.pushwoosh.com  Connection timed out - connect(2) for "www.pushwoosh.com" port 443

  Generated by :no_entry_sign: danger

"classic Swift edit" haahahhahaha
It's still really cool and helps a lot. Really thank you, @SeanStephens!


[proposal] koord-descheduler support objectLimiter for namespace

What is your proposal:
Add a new MigrationLimitObjectNamespaceto limit pod migrating frequency under a namespace.
Why is this needed:
For pods without ownerreference, the existing workload-level object limiter is not working when migrating pods. If such pods are migrated frequently, related service will be unavailable.
Is there a suggested solution, if so, please add it:

/area koord-descheduler

/assign


Add prob support

Before submitting
Please complete the following checklist when submitting a PR:

[x] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests directory!

[x] All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running make docs.

[x] Ensure that the test suite passes, by running make test.

[x] Add a new entry to the .github/CHANGELOG.md file, summarizing the
change, and including a link back to the PR.

[x] Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:

You can essentially

Hey, @multiphaseCFD, could you please add unit tests for the transposition and integration tests for probabilities? Examples can be found here:

Transpositions
Probabilities

It is important to be comprehensive with such tests.

You can essentially copy the tests I linked from lightning or expand them if you feel like it. :slightly_smiling_face:

Hey, @multiphaseCFD, could you please add unit tests for the transposition and integration tests for probabilities? Examples can be found here:

Transpositions
Probabilities

It is important to be comprehensive with such tests.

You can essentially copy the tests I linked from lightning or expand them if you feel like it. slightly_smiling_face

Just clarifying, I see that you added some probability tests, but it would be good to at least cover all 3 wires combinations, like in Lightning.

Thanks @AmintorDusko!

Sure!

Hey, @multiphaseCFD, could you please add unit tests for the transposition and integration tests for probabilities? Examples can be found here:

Transpositions
Probabilities

It is important to be comprehensive with such tests.

You can essentially copy the tests I linked from lightning or expand them if you feel like it. slightly_smiling_face

Just clarifying, I see that you added some probability tests, but it would be good to at least cover all 3 wires combinations, like in Lightning.

No problem! Will do!

Hey, @multiphaseCFD, could you please add unit tests for the transposition and integration tests for probabilities? Examples can be found here:

Transpositions
Probabilities

It is important to be comprehensive with such tests.

You can essentially copy the tests I linked from lightning or expand them if you feel like it. slightly_smiling_face

Just clarifying, I see that you added some probability tests, but it would be good to at least cover all 3 wires combinations, like in Lightning.

Thanks @AmintorDusko! Good spot! Just completed the tests and made corresponding revise.

@multiphaseCFD, it looks like we have some conflicts we need to address, before merging the main branch.
Could you please look into this?

@multiphaseCFD, it looks like we have some conflicts we need to address, before merging the main branch. Could you please look into this?

Thanks! Let me resolve the conflicts.

Thank you for looking into my recommendations.

Thanks for the comments!

Wait, why is everything now failing?

Wait, why is everything now failing?

Just looked into it and found out why. wires' data required here lost after using std::move(wires) to construct sorted_ind_wires here. We can just roll back to previous version or declare a local std::vector variable that mirrors wires. Which one is better in your opinion? Thanks

Wait, why is everything now failing?

Just looked into it and found out why. wires' data required here lost after using std::move(wires) to construct sorted_ind_wires here. We can just roll back to previous version or declare a local std::vector variable that mirrors wires. Which one is better in your opinion? Thanks

Can we not just call std::sort on the copied data and use that? Or is there something I am missing.

Wait, why is everything now failing?

Just looked into it and found out why. wires' data required here lost after using std::move(wires) to construct sorted_ind_wires here. We can just roll back to previous version or declare a local std::vector variable that mirrors wires. Which one is better in your opinion? Thanks

Can we not just call std::sort on the copied data and use that? Or is there something I am missing.

yea, we can just for the std::sort for

Wait, why is everything now failing?

Just looked into it and found out why. wires' data required here lost after using std::move(wires) to construct sorted_ind_wires here. We can just roll back to previous version or declare a local std::vector variable that mirrors wires. Which one is better in your opinion? Thanks

Can we not just call std::sort on the copied data and use that? Or is there something I am missing.

yea, we can just call std::sort and everything works for the full system and that's what the prob() does. While, this function override is for the sub-system and we need to use util::sorting to get the index first.

Wait, why is everything now failing?

Just looked into it and found out why. wires' data required here lost after using std::move(wires) to construct sorted_ind_wires here. We can just roll back to previous version or declare a local std::vector variable that mirrors wires. Which one is better in your opinion? Thanks

Can we not just call std::sort on the copied data and use that? Or is there something I am missing.

yea, we can just for the std::sort for

Wait, why is everything now failing?

Just looked into it and found out why. wires' data required here lost after using std::move(wires) to construct sorted_ind_wires here. We can just roll back to previous version or declare a local std::vector variable that mirrors wires. Which one is better in your opinion? Thanks

Can we not just call std::sort on the copied data and use that? Or is there something I am missing.

yea, we can just call std::sort and everything works for the full system and that's what the prob() does. While, this function override is for the sub-system and we need to use util::sorting to get the index first.

yea, we can just call std::sort and everything works for the full system and that's what the prob() does. While, this function override is for the sub-system and we need to use util::sorting to get the index first. Correct me if something is missing here @AmintorDusko .

Ok. Feel free to ignore my earlier comments on copying and moving, and just fall-back to the working dual vector version. We can revisit and improve later.


Compatibility with Strapi v5-RC*

Using this plugin with the latest (RC) Strapi's v5-RC throws the following error:

In the rc the plugin-upload package was renamed to upload that's why this error happens


Add custom text and image overlay on the camera view

Hi, not a bug but rather a question.
Currently in the camera view, i see that there is a  'overlayMessage' which is editable and the vuforia logo.
How can i add my own images and own text with custom positioning to the camera view?
I'm looking to add an everpresent grid / guides overlay.
Currently using it only for IOS with cordova

Hi @fariskas, at the moment you'd need to modify the code inside of the plugin's view controller to achieve what you're asking
It should be pretty simple though! 👍

thanks for the quick reply. Umm could you perhaps point me to the files you were referring to perhaps?


Add Laravel 5.5 auto discovery support

Laravel 5.5 comes out officially today. As discussed here, one of the new features is auto-discovery that removes the need to explicitly declare providers and aliases in the app's config/app.php.  Instead, it can be automatically set from the package.json's extra data.
I understand I should be sending unit tests with the PR, but I am unsure how to implement this kind of test.
I did however successfully include my fork in a vanilla 5.5 project and it is why I am taking the liberty of submitting the PR anyways.

As discussed on https://github.com/bugsnag/bugsnag-laravel/pull/236, it's not quite as simple in the case of Bugsnag, since we want the service provider loaded as early as we can, so auto-discovery is not the best way.

In particular, it must be before the app service provider, or whichever service provider you are doing the log bindings in.

Hey @francoisfaubert, I'm closing this down due to the issues discussed above, but thanks for the contribution.

Am I correct when saying it will load before the AppServiceProvider (see below)? Or is the issue only for older versions?
 DONE
  barryvdh/laravel-ide-helper ........................................... DONE
  laravel/tinker ........................................................ DONE
  laravel/ui ............................................................ DONE
  laravelista/ekko ...................................................... DONE
  nesbot/carbon ......................................................... DONE
  nunomaduro/collision .................................................. DONE
  propaganistas/laravel-phone ........................................... DONE
  spatie/laravel-ignition ............................................... DONE
  torann/geoip .......................................................... DONE

It actually looks like it boots after the list of auto-discovered packages, and then AppServiceProvider etc. at the end?
laravelista/ekko is an auto-discover package and I hardcoded the load in the list of service providers AFTER BugsnagServiceProvider and was ignored, it still loaded within the auto-discover packages. When I commented it out, it didn't even move its position:
...
Illuminate\Session\SessionServiceProvider::class,
Illuminate\View\ViewServiceProvider::class,

/*
 * Package Service Providers...
 */
Bugsnag\BugsnagLaravel\BugsnagServiceProvider::class,
Laravelista\Ekko\Frameworks\Laravel\ServiceProvider::class,

/*
 * Application Service Providers...
 */
App\Providers\AppServiceProvider::class,
App\Providers\AuthServiceProvider::class,
App\Providers\EventServiceProvider::class,
App\Providers\RouteServiceProvider::class,
App\Providers\ViewServiceProvider::class,
App\Providers\ApiServiceProvider::class,

Please let me know if I'm testing this wrong?
Or is it just older Laravel versions that is the issue?
Thanks! ☺

Hi @emotality,
We would already recommend registering our Service provider before the AppServiceProvider as per the docs here: https://docs.bugsnag.com/platforms/php/laravel/#installation. Which it looks like you have done.
I'm not sure I quite understand the issue you are having? As based on your logs the BugsnagServiceProvider is being loaded before the AppServiceProvider which is what I would expect.


nan parameters

Hi! Training with PDNN sometimes ends with the nan parameters. Command is as follows:
python run_DNN.py --train-data "train.pfile,partition=2000m,stream=true,random=true" --valid-data "valid.pfile,partition=200m,stream=true,random=true"  --nnet-spec "1320:2048:2048:2048:2048:2048:1947" --lrate "D:0.8:0.5:0.1,0.1:6"  --dropout-factor 0.2,0.2,0.2,0.2,0.2 --wdir model --kaldi-output-file model/model.dnn --model-save-step 1
What is the problem?

Is there anybody could help me?


NPM Install Failing

Reporting a bug?
I am unable to install using npm but can install using yarn.  That is,
npm install -g react-static fails and I get a npm ERR! Unexpected end of JSON input while parsing near '...aPefIHErkE61pl\noUbz6'.  Full error below.
Note that npm install -g react and yarn global add react-static succeed.
 Going to track it there.

Thanks for tracking @tannerlinsley!


test bump image of upgrade / downgrade test to v1.5

Signed-off-by: André Martins<EMAIL_ADDRESS>

This change is

test-me-please

Coverage decreased (-0.06%) to 41.948% when pulling 196c182c938ff8c80e3bb577618bfd7ff469aac9 on pr/bump-upgrade-image-version into 28e7a82956ed424cb9c0902952def62bb2d69ebf on master.

@brb the upgrade downgrade test fails from v1.5 to master I believe you are already aware of it.
/home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/k8s-1.14-gopath/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:410
migrate-svc restart count values do not match
Expected
    <int>: 0
to be identical to
    <int>: 10
/home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/k8s-1.14-gopath/src/github.com/cilium/cilium/test/k8sT/Updates.go:249

@aanm Yep, I'm aware of it: https://github.com/cilium/cilium/pull/8041#issuecomment-493355010. I'm going to fix.

test-me-please

test-missed-k8s

Failed due to the git timeout (https://github.com/cilium/cilium/pull/8122 might fix this).

test-missed-k8s

test-me-please

test-me-please

test-missed-k8s

test-me-please

test-missed-k8s

test-me-please

test-me-please

test-missed-k8s

test-me-please

test-missed-k8s

CI failed due to:
[2019-06-03T17:12:58.640Z]     k8s2-1.10: Digest: sha256:71ad056a93753b04a3e7ced45a369fb0564a2fd7dcd3fe3689ab144712b97a6b
[2019-06-03T17:12:58.640Z]     k8s2-1.10: Status: Downloaded newer image for k8s1:5000/cilium/cilium-dev:latest
[2019-06-03T17:12:58.640Z]     k8s2-1.10: 0445bccc448d4819b7a3f3facb85e743e02f44c1f4a0f350f3bb0edc92b9e70b
[2019-06-03T17:12:58.640Z]     k8s2-1.10: 6bf57f8e2eb549d536063d52b19a7c43a58ba27f39df1b2e337bb9dd352caaf1
[2019-06-03T17:12:59.129Z]     k8s2-1.10:<PHONE_NUMBER>4c71740f90f514f497b1f8e787feed0113dc504d187b3ad3dd548d
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[2019-06-03T17:44:45.761Z] Cancelling nested steps due to timeout
[2019-06-03T17:44:45.842Z] Sending interrupt signal to process
[2019-06-03T17:45:05.842Z] After 20s process did not stop

test-me-please

test-missed-k8s

Failed due to VM issues (fetching Docker images got stuck)

test-me-please

test-missed-k8s

@aanm PTAL

Cilium-Ginkgo-Test-k8s failed because of:
14:16:27  • [SLOW TEST:4835.099 seconds]
14:16:27  K8sDatapathConfig
14:16:27  /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-K8s/1.12-gopath/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:378
14:16:27    DirectRouting
14:16:27    /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-K8s/1.12-gopath/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:378
14:16:27      Check connectivity with automatic direct nodes routes
14:16:27      /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-K8s/1.12-gopath/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:410
14:16:27  ------------------------------
14:16:27  K8sDatapathConfig Transparent encryption DirectRouting
14:16:27    Check connectivity with automatic direct nodes routes
14:16:27    /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-K8s/1.12-gopath/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:410
14:16:27  ===================== TEST FAILED =====================

which is unrelated to my changes.


Issue_749  Add 'managed by puppet' to config files

:+1:

If possible, can someone more familiar with the code (& how Nginx works) double check that I didn't miss any files that also should have this message?

Hi @jfryman any chance I could get these PRs I opened reviewed and merged?

Can also add to first line of:

templates/conf.d/geo.erb
templates/mailhost/mailhost.erb
templates/mailhost/mailhost_ssl.erb
templates/conf.d/map.erb
templates/streamhost/streamhost.erb

Since there's no shared header file between mailhost.erb and mailhost_ssl.erb it's possible that the note will be added twice, but that's not a major concern.

Ok, done.


Why only last append is taken from rds when applying a wal ???

I was going through the code of RDSWal and bumped into a doubt.Why only last record is taken from rds table for a topicPartition to make a commit.Since a single topicPartition can write data to multiple files (tempFiles) based on partitioner logic we use,I guess there is a chance that we might not commit all the temp files upon wal apply.Any clarification on this this highly appreciated.

This issue is resolved now. If one topicPartition writes to multiple files based on custom partitioner, it will concat all the tempFiles in comma separated fashion and store it as 1 record in database. Let me know if this sounds good.


Update Composer dependencies (2021-10-20-00-04)

Visual regression test passed!
View the visual regression test report


SIMD Overlay: inline deprecated methods

On Swift 5, using the deprecated SIMD.init(_ scalar: Scalar) initialiser rather than SIMD.init(repeating scalar: Scalar) will cause the type to fail to be specialised, resulting in performance degradation. Mark this method and static prefix func - as @_transparent to ensure they are correctly specialised.
cc @stephentyrone
Partially fixes rdar://48755752

@airspeedswift It’d be great if this fix could make it into 5.1 - it’s a fairly severe (albeit easy to work around) performance bug.

@swift-ci please smoke test

Fine for this to be picked onto 5.1 too.


Add vue-like for and if

Wrapping HTML Elements in PHP's if or foreach can be quite verbose:
<?php if($date): ?>

<?= $slots->date() ?>

<?php endif ?>

Maybe a vue-like syntax would help:
<div <? if($date) ?> class="post-date"><?= $slots->date() ?>

But could also be very unreadable. Another solution would be to allow shorter control statements using PHP's (deprecated) short tags and compiling them back to normal tags afterwards.
<? if($date): ?>

<?= $slots->date() ?>

<? endif ?>

Might be overkill and won't keep the line numbers the same.


Tests, abstract interface, and concrete implementation for BackoffPolicy

When an operation fails and needs to be retried, a BackoffPolicy object
determines how long to wait before attempting the retry.
The single concrete implementation is a saturating binary exponential
backoff with randomized delay that is (intended to be) unique across
clone/copy construction.
Actual unique generation of the per-policy RNG is punted to a functor
template parameter.

 The CLA check is being overly strict and is in fact okay.

Hmm, that's odd, the CLA bot recognized that remyabel had signed the CLA. Have you signed it? To test, you could open a new clean dummy PR. If that PR gets tagged correctly, then we can just override the check on this PR.

The CLA bot correctly tagged my cla-test PR. I think it's just merge/rebase shenanigans.

OK, updated CLA tag. Not sure why this was tagged as cla: no. All committers are either Googlers, or else have signed the CLA, and all commits other than the new ones created by @software-dov are already part of the repository.


[UI]  Display Connection ID in the Info Tab on Connections Page

Current Behavior

Each registered connection is assigned a unique connection ID. However, the connection ID is not currently displayed in the info tab for each connection on the Connections page.

Desired Behavior
Add the connection ID to the empty space in the info tab, as highlighted in the screenshot.
A similar implementation is shown on the Layer5 Cloud integrations page in the image below.

Contributor Guides and Handbook

🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🖥 Contributing to Meshery UI
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

@Alero-Awani i would like to work on this

@Divyansh200102 Let me know if you need help.


fix(prow/cluster): set first github graphql endpoint to ghproxy svc

try to avoid graphql api quota be throttled

What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:

/auto-cc

/autocc

/cc @purelind

/merge


Canvas.toDataURL() doesn't respect layer opacity

While taking a screenshot of the map, using Canvas element's toDataURL() method, if any of the layers has an opacity other than 100%, I am not getting the accurate image of the map. Although map displays fine on screen, the exported image displays raster layer at 100% opacity, and overlaying vector layer is not displayed (both layers' opacity is set to 50%). I've noticed this behaviour in OpenLayers v6.14.1, but the same code worked as expected in v6.0.0.
Tested in:
Chrome 103.0.5060.66
Firefox 102.0.1
CodePen Examples:
WORKS - OpenLayers v6.0.0:
https://codepen.io/flekinjo/pen/VwXegQa
DOES NOT WORK - OpenLayers v6.14.1:
https://codepen.io/flekinjo/pen/qBobgdz
To reproduce the issue, click on the "Export image" button in provided CodePen examples.
Expected behavior:
Canvas' toDataURL() method should return the image respecting layers' opacities.

The map can have multiple canvases.  See https://openlayers.org/en/latest/examples/export-map.html for an example of how to combine and export them.

Thank you @mike-000 !
Implementing the export the proper way (as described in example you linked) fixes the issue. Must have missed this change in release notes when updating OpenLayers in my app, sorry about that.


Bug: STFT and inverse STFT not working for frame length not perfectly divisible by signal length

On running the test: testInverseShortTimeFourierLongSignal1() under TestInverShortTmeFourier, we use the electrocardiogram signal (length = 108000). On using a frame length of 6000, the tests pass; however, if I use a length of 20000, the test fails since the array length differs. The result has a length of 100000 while the expected is 108000.

@SiboVG Could you take a look at this please?

There is nothing that you can do about this really :/ it's inherent to the (I)STFT algorithm; you split the entire signal up into frames and shift that frame to the end. But if the last portion of the signal does not have enough samples to fill an entire frame, it gets discarded. You can see this in the drawing below; in the beginning of the signal, you can make 3 frames, f0, f1 en f2, but for the end there aren't enough samples to make an entire frame, so this part of the signal is discarded.


fixed saving to a specific album issue on iOS11

fixed issue#96

@ohgiwk thx for trying to fix the issue. i tried your changes, unfortunately without success. first there were 2 compile errors, which i was able to fix (missing brackets), but with your changes, it is not possible to save files anymore. It's not working with iCloud sync enabled or disabled (iOS 11). maybe you can have an other look at the problem? Thanks in advance!!


[BUG] Error on saving profile details

Steps to reproduce

Login into your account
Go to Settings
Click edit to edit your account
Change/update your name
Click on save profile

Expected result
Userc. profile name update should save
Actual result
User gets an Requested path / was not found error message and the details are not saved
Screenshots or videos

Additional context
No response
Operating system
macOS
Operating system version
No response
Browsers
Chrome
Browser version
No response

ToDO:

[ ] - remove Edit Profile from page
[ ] - change title to Account Settings
[ ] - display only Change password


Translate May 1 covid report into Polish

Hello @nextstrain/polish!
The situation report from 2020-05-01 is ready to be translated to Polish. The report focuses on Central & Eastern Europe. As per previous week's, please translate the Twitter post below! It's still a bummer when the translation is great, but people do not know it because I used Google translate for the Twitter post (lol).
Branch to translate on: sit-rep_pl
File to translate: https://github.com/nextstrain/translations/blob/sit-rep_pl/narratives/translations_ncov_sit-rep_pl_2020-05-01.md You can translate directly in this file, but please remember to push often as other people may be working on the translation!
Link to preview: https://nextstrain.org/community/narratives/nextstrain/translations@sit-rep_pl/ncov/sit-rep/pl/2020-05-01
Twitter post to translate:
“In the latest #COVID19 situation report, we explore outbreaks in Central & Eastern Europe. The report is now available in Polish. Thank you @, @, and @ for the rapid translation."
Logistics
Please update the translations board as you work on the translation: https://github.com/orgs/nextstrain/projects/7
Please assign yourself to the translation if you’re working on it this week.
When a translation is ready for publication -- at minimum meaning two people have worked on it and both agree that it’s ready -- please create a pull request to merge to master and tag me and the issue in it!
Discussion board for your team is here: https://github.com/orgs/nextstrain/teams/polish
Standard rules for translation:
Note that the file to translate is in Markdown. In general, it is important not to change any formatting or links. (Although it is okay to update Wikipedia or CDC links to the appropriate language version.) Comments to help with translation are noted in comment symbols like <! -- Comment -->.
Please add your name under translators: with new line, tab, and dash, formatted just like authors are. Please also add a link to your professional page (can use Twitter) under translatorLinks:.
Note: You may know of other great resources available in Polish; please don’t add them to the situation report. We need to keep content the same across all translations, so we can be confident in the accuracy of what we publish. Thanks for understanding.
At minimum, I require two sets of eyes on every translation; one of those people should have a background in phylogenetics. Although if you have more, that’s fine too.
Feel free to use a live, online editor like hackmd (sign in with GitHub) to translate together.
Thank you so very much! As always, it's an honor work with you all to make these analyses accessible. Take care.

twitter:
"W ostatnim raporcie #COVID19 zajmujemy się epidemią w Środkowej i Wschodniej Europie. Raport jest już dostępny w języku polskim. Podziękowania dla @, @, and @ za szybkie tłumaczenie."

Published and tweeted: https://nextstrain.org/narratives/ncov/sit-rep/pl/2020-05-01
Thank you!


command not found for ssh git key

What version of eunomia are you using?
eunomia version: latest
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (kubectl version)?
kubectl version Output
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.3", GitCommit:"b3cbbae08ec52a7fc73d334838e18d17e8512749", GitTreeState:"clean", BuildDate:"2019-11-13T11:23:11Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.3", GitCommit:"b3cbbae08ec52a7fc73d334838e18d17e8512749", GitTreeState:"clean", BuildDate:"2019-11-13T11:13:49Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"linux/amd64"}

What did you do?
Use a GIT ssh key and received command not found
What did you expect to see?
The processor to apply my changes
What did you see instead?
command not found error

I used single quotes as defined by the readme but it needs to be double quotes for the sshCommand.  PR will be posted soon to address


[question] hugo PR preview solution

Hey guys,
we are using hugo as our website framework to deploy our official website on kubernetes, as more and more github pull requests coming in we'd like to provide a preview link based on code of PR. therefore does anyone know whether theres is a existing project doing the things we need? (something like a kubernetes operator that download pr codes, start a new instance,and expose the website via sub_url? ) or maybe there are something more simplier solution.

Please use https://discourse.gohugo.io/ for questions/troubleshooting. Also see  Hugo Documentation.


WPS plugins

(There has just been a new release of shogun2: https://github.com/terrestris/shogun2/releases/tag/v0.1.2)
This PR will merge the current state of the wps-plugins branch (https://github.com/terrestris/shogun2/tree/wps-plugins) to master.
Essentially, the following new models will be introduced:

Plugin as base class of WpsPlugin
WpsParameter as (abstract) base class of

WpsPrimitive and
WpsReference, which again is the parent class of

WpsProcessExecute

(On top of the models, this PR also contains the corresponding DAOs, Services and Rest-/Controllers.)
An Application now has a list of Plugins, where a Plugin mainly is a piece of (JS/Ext-JS) sourceCode that could follow some kind of policy/guideline that is expected by a client (e.g. it could implement a load or init function, which is then interpreted by a client) and may (for example) be used to provide a basic input-GUI for a WpsPrimitive.

Looking into this now.

:+1: all good now


Fix golang formatting issues

Whe running unittests on newer golang versions, we observe failures with some
formatting types when no declared correctly.
Signed-off-by: baude<EMAIL_ADDRESS>

/approve
bot retest this please
LGTM

LGTM

LGTM
bot, retest this please

bot, retest this please

bot, retest this please

@baude mind rebasing/repushing? CI seems fixed

Looks green aside from Cirrus.
/lgtm


Add support for SageMaker Space Apps and Spaces

In rebuy.de/aws-nuke the current SageMakerApp implementation doesn't support deleting apps with a SpaceName. Also, SageMaker Spaces are not currently supported.
This issue duplicates https://github.com/rebuy-de/aws-nuke/issues/1184 to implement the feature in ekristen/aws-nuke

Thanks for the migrate tool! Will try it with my next contributions 😃
Agree on unit tests, I will implement some with my other PR because it is hard to test Bedrock stuff on real infrastructure without giving a lot of money to AWS.

Indeed, probably why they haven't been added before. Do you occasionally have bedrock resources that need cleaned up or just trying to be proactive? Ideally we should get some real world usage before getting it in, but if we can get some decent mocks in place I'm ok with that too.

I have some bedrock resources to remove occasionally. In particular, last week a provisioned throughput for Bedrock earned AWS $400 in 24 hours before we noticed 😭
I'll be able to test this PR with a real infrastructure, at least once to validate everything is properly deleted, but I'll start with mocks it will be easier.

:tada: This issue has been resolved in version 3.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[+] add docs versioning

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 28.764%

Totals

Change from base Build<PHONE_NUMBER>2:
0.0%

Covered Lines:
1406

Relevant Lines:
4888

💛  - Coveralls


Rename single keys to the factory parameter

Avoids naming requirements in the simple case.
Addresses #81.

Any idea when it will be merged? Thanks.

Let's clean this 😊
//    api(Libs.assisted_inject_annotations_dagger2)
compileOnly("com.github.davidliu.AssistedInject:assisted-inject-annotations-dagger2:268bff6") {
        because("Rename single keys to the factory parameter #121")
}

//    kapt(Libs.assisted_inject_processor_dagger2)
kapt("com.github.davidliu.AssistedInject:assisted-inject-processor-dagger2:268bff6") {
        because("Rename single keys to the factory parameter #121")
    }

Sorry for the presure.

We also faced the problem in a multi module project. This PR actualy solves the problem. Thanks to @davidliu
Just a question, is there any reason why this PR is not accepted yet?

Only ~Square~ oops, Jake knows.

Any updates?

Let's clean this
//    api(Libs.assisted_inject_annotations_dagger2)
compileOnly("com.github.davidliu.AssistedInject:assisted-inject-annotations-dagger2:268bff6") {
        because("Rename single keys to the factory parameter #121")
}

//    kapt(Libs.assisted_inject_processor_dagger2)
kapt("com.github.davidliu.AssistedInject:assisted-inject-processor-dagger2:268bff6") {
        because("Rename single keys to the factory parameter #121")
    }

Sorry for the presure.

I have an error in this case:
ERROR: Failed to resolve: com.github.davidliu.AssistedInject:assisted-inject-annotations-dagger2:268bff6

@Lampotrias that's not really related to this PR; check my comment in the issue thread for instructions so that we can keep discussion here related to the PR.
@JakeWharton any possibility for updates?

Any updates?


api amount error

i like your script it is very useful but i get api amount exected or something like that error how to fix it or do you need to fix it maybe?

Thank you Bro for this report but it seems that there is no problem in the API
~ make sure you have a good internet connection
~ check the validity of the target
Crips Only works with an internet connection and can not scan a local host or local IP address

if the problem persists send us a screenshot


DASHBOARD_RBAC feature flag doesn't work

Short description
I have a fresh install of superset. I have created a dashboard dashboard1 as well as a role role1. Since I have the DASHBOARD_RBAC feature flag enabled, I can go into the dashboard settings and add role1 in the settings -> roles dropdown.
I have created a new user user1 and given them the role1 as well as the Gamma role.
Expected results
I expect user1 to be able to access dashboard1.
Actual results
The user doesn't have access to any dashboards.
Environment

superset version: docker using master branch, commit 90e2f09c6

any feature flags active:

FEATURE_FLAGS = {
        "ALERT_REPORTS": True,
        'ENABLE_TEMPLATE_PROCESSING': True,
        'DASHBOARD_RBAC': True,
        'ROW_LEVEL_SECURITY': True,
        'OMNIBAR': True,
        'DASHBOARD_NATIVE_FILTERS_SET': True,
        'DASHBOARD_NATIVE_FILTERS': True,
        'DASHBOARD_CROSS_FILTERS': True,
        "GLOBAL_ASYNC_QUERIES": True
}

Be sure you published dashboard.

Ah yes, that worked. Perhaps obvious for everyone else, but not for me :D


webViewEventHandlers: Add ability to copy links to Clipboard.

There is no way to copy only links from a message at the moment, which
makes it hard for some users to copy only the links to share with other
people. There could be two solutions to this. One is that another menu
option could be provided to copy only the link in your message, which
is not a correct approach as immediately some problems come to mind.
For example, if there were two links in the message, which one would
the app copy? Another solution to this could be what commercial
applications already apply, which is if you hold the link text, it
gets copied. Which is what has been implemented here. I have added
another event to MessageListEvent which abstracts a long press on a
url, and edited the long press listener on js.js a little bit.
I have only conducted the automated tests here (besides manually
checking if copying links works by building the application).
I have edited the js.js file and tweaked the long press functionality
to make it possible to copy links on long press. Long press itself is
very shaky to capture in a webview on mobile, which is why I was
compelled to tweak it in this manner. Please consider this before
merging.
Fixes #3385.

On the long-press logic: thanks, this is helpful for understanding your thinking! Both the new separate commit, and especially the video (https://i.imgur.com/phH6B5C.mp4 ).
The first question I'd ask on that bug is: why is it specific to the new behavior on links? Why doesn't it also apply to e.g. long-pressing a topic bar (.header)?
I don't see a reason why it should be specific to links, but your fix only applies to links.
Also I can't seem to actually reproduce the issue; not on Android with your first commit (and not your second), and neither on Android nor iOS with the latest release, if I try it on things like topic bars. I notice your video is on iOS -- would you check if it reproduces for you on Android? If it's platform-specific, that'll be a clue.

Your reproduction of the issue seems to be correct. With the first commit it works on only Android, and with the second it works on both (because the second commit was made to fix that issue).
The issue arises due to an unknown reason I have not been able to discern for the better part of half a day due to the following reasons:

I initially thought it had something to do with the touch being held even after the longPress is complete. On Android if we hold a link (with only the first commit) the highlight which occurs on holding the link goes away as soon as the longPress completes. While on iOS, it seems to persist.
But that was ruled out by the fact that the same thing was not happening to headers.
Then I thought that the ActionSheet which pops up on clicking the message was blocking out the rest of the touch on the message/link, which is why on the header (since the ActionSheet got triggered) the doNarrow wasn't occurring.
That was proven to be wrong because if the ActionSheet was disabled, and then we longPress the header, the short press on the header did not trigger (it should according to this hypothesis, since the ActionSheet has been disabled and there is nothing to block the touches now)!

In all, this is very confusing behaviour which cannot be replicated for Android and only exists for iOS. It can be easily fixed with commit no. 2 for iOS as well (it could perhaps be explained in high-level why we have done so in a comment).

Cool, thanks for those notes from further debugging!
Definitely interesting that the issue is iOS-only. And also interesting that it applies to links but not to topic headers.
This seems like an especially interesting clue:

On Android if we hold a link (with only the first commit) the highlight which occurs on holding the link goes away as soon as the longPress completes. While on iOS, it seems to persist.

... Oho, I can actually reproduce the issue on iOS on the current release! So this is a live bug today.

Find a message with an image in it. Scroll so it's near the top of the message list.
Press and hold, long enough for the action sheet to show up.

Like you said, the image stays highlighted.
You want it to still be in view, not hidden by the action sheet -- this is why we scrolled earlier to put it near the top.

Now let go.
We navigate to the lightbox -- just as if you'd done a normal, non-long press.

It seems to be important that after the action sheet shows up you wait for a moment before letting go, like a few hundred ms. If you let go as soon as the long-press triggers -- like I'd usually do -- the bug doesn't show up.
The bug also reproduces on

the link just above an image
internal links to streams/etc. -- if they're in the old format, i.e. not affected by #2760, so they actually work in the first place

This would be good to do some further debugging/research and get to the bottom of.
@borisyankov , do you have any suggestions?
I wonder also if the new WebView implementation (coming soon, #3296) might affect this issue, one way or another.

@gnprice thanks for the review!
I have tried to debug this further, but to no avail. I still have no idea why this is the case only in iOS. I did find something peculiar though, in UIWebKit, there is an issue with clicks and the delay with respect to them triggering. Is there a possibility that such an issue might be interfering with our longPress logic?

... Oho, I can actually reproduce the issue on iOS on the current release! So this is a live bug today.

I have managed to fix this bug with the latest commits, and have separated them for the sake of clarity. The change was basically to add a flag which detects if a long press was triggered before the detected click, as in the multiple iterations I tried this seemed to be the cleanest and easiest to understand.

I wonder also if the new WebView implementation (coming soon, #3296) might affect this issue, one way or another.

At first glance on the change-log (of the ported library), it doesn't seem like this will be why this issue happens, but I will regardless test whether it fixes it without the flag used above.
Here's the recording which shows the fixed behaviour.

Thanks @ishammahajan ! This solution to the extra-click issue is much cleaner :smile: , and I like the small diffstat:
 src/webview/js/js.js           |   9 +++++++++

This version breaks things on Android, though. (And I suspect also some of the time on iOS -- basically anytime the existing bug didn't trigger.) To solve it, I recommend you:

Think carefully about the state machine of hasLongPressed. In particular, when does it get set to false?
Test your code out on Android as well as on iOS.
Fix the bug. :slightly_smiling_face:
Repeat until you (a) can't reproduce any bug on either platform, and (b) can convince yourself that the state machine makes sense and should mean there isn't a bug.

Once that's in shape, I think we'll be basically ready to merge this PR.

ad77730e2 webViewEventHandlers: Add ability to copy links to Clipboard.
Small comments on this commit:

Let's actually put this commit after the bugfix, not before. That's a bit more logical because that way we don't have an intermediate step where the bug is still there and has been made more visible and easy to trigger.

+  href: string,

This needs to be updated to reflect the type of what we actually send for these events.
(Meanwhile, the fact that this oversight is even possible demonstrates a gap in our type-checking! It'd be good to fix that. Looks like we've disabled the type-checker at sendMessage, by writing const sendMessage = (msg: Object) => etc., with Object which is basically never the right answer in the end... hmm, I may just go fix that now.)

(Meanwhile, the fact that this oversight is even possible demonstrates a gap in our type-checking! It'd be good to fix that. Looks like we've disabled the type-checker at sendMessage, by writing const sendMessage = (msg: Object) => etc., with Object which is basically never the right answer in the end... hmm, I may just go fix that now.)

And done, in dd03939cb . When you rebase, you'll find that Flow gives you an appropriate error for this. :tada:

@gnprice thanks for being so patient! 🙂
Sorry about the silly bug which occurred. I should have tested the behaviour for all possible cases before pushing.

The bugs have been fixed. I have tested the commits with both Android (emulator and device) and iOS (and will do so moving forward.)

Have rearranged the commits to put the fix first.

href: string,
This needs to be updated to reflect the type of what we actually send for these events.

This is now href: string | null.

I think you'll find the bug fixes sweet with the updated commit as well (+10 insertions) 😄 .

And merged. Thanks again @ishammahajan for all your work on this!
Small style nit on these excellently detailed commit messages: please wrap prose in paragraphs at about 68 columns (no more than 70 columns max). You may find it helpful to (a) configure Git to use your preferred editor, with e.g. the EDITOR environment variable or git config --global core.editor; (b) configure the editor to automatically wrap text at the appropriate width (e.g. (push 'turn-on-auto-fill text-mode-hook) in ~/.emacs.d/init.el if you use Emacs; all text editors have some way to do this.)

Thanks for all the help as well! I'll try to remember these pieces of advice with new PRs. The textwidth setting accomplishes hard wrap for me on vim, I didn't initially know text editors have hard wrap available.


1

pending:ID1
account1:screenshot-TBC
account2:screenshot-TBC
We cannot fully verify this submission. Please assist us in typing out the account addresses for ID1 in full as text in a comment on this PR. Thank you!
@aorminded

pending:ID2
account1:screenshot-TBC
account2:screenshot-TBC
PublicDataAttributes:Verified
DeviceMake&Model:Verified
We cannot fully verify this submission. Please assist us in typing out the account addresses for ID2 in full as text in a comment on this PR. Thank you!
@aorminded

pending:ID2
account1:screenshot-TBC
account2:screenshot-TBC
PublicDataAttributes:Verified
DeviceMake&Model:Verified
We cannot fully verify this submission. Please assist us in typing out the account addresses for ID2 in full as text in a comment on this PR. Thank you!
@aorminded

confirmed:ID4
AccountAddress:44zsWUbfXRXW5NtmnFUUEGE7zoPtSEwrqwiU94iNeQZePit6LQ
DeviceDetails:verified

confirmed:ID4
AccountAddress:44zsWUbfXRXW5NtmnFUUEGE7zoPtSEwrqwiU94iNeQZePit6LQ
DeviceDetails:verified

confirmed:ID1
address1:3wdkTgCPvdfMF1P7JM7rk84SSg1TsqvDTmaCfSPaUUiMUnHL3h
address2:3AZKHCrp61WMv5JxgJdrkun5gBPhSkoLpQgkgfrmmvWWmWaRWn

confirmed:ID1
address1:3wdkTgCPvdfMF1P7JM7rk84SSg1TsqvDTmaCfSPaUUiMUnHL3h
address2:3AZKHCrp61WMv5JxgJdrkun5gBPhSkoLpQgkgfrmmvWWmWaRWn

pending:ID1
account1:screenshot-TBC
account2:screenshot-TBC
We cannot fully verify this submission. Please assist us in typing out the account addresses for ID1 in full as text in a comment on this PR. Thank you!
@aorminded

ID1:44zsWUbfXRXW5NtmnFUUEGE7zoPtSEwrqwiU94iNeQZePit6LQ

pending:ID1
account1:screenshot-TBC
account2:screenshot-TBC
We cannot fully verify this submission. Please assist us in typing out the account addresses for ID1 in full as text in a comment on this PR. Thank you!
@aorminded

ID1:44zsWUbfXRXW5NtmnFUUEGE7zoPtSEwrqwiU94iNeQZePit6LQ

confirmed:ID2
account1:3wdkTgCPvdfMF1P7JM7rk84SSg1TsqvDTmaCfSPaUUiMUnHL3h
account2:3AZKHCrp61WMv5JxgJdrkun5gBPhSkoLpQgkgfrmmvWWmWaRWn
PublicDataAttributes:Verified
DeviceMake&Model:Verified


Issue#88 increase coverage

Reviewers are busy with exams. Consequently, I am merging without external review.

Pull Request Test Coverage Report for Build 205

4 of 6 (66.67%) changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+2.3%) to 80.136%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

enviro/views.py
4
6
66.67%

Files with Coverage Reduction
New Missed Lines
%

enviro/views.py
2
75.72%

Totals

Change from base Build 195:
2.3%

Covered Lines:
1892

Relevant Lines:
2361

💛  - Coveralls


fixed python matmul bug

In the python file, the matrix multiplication operation seems to be wrong,
Am * transpose(Bm) --> will do an elementwise multiplication
We should use np.matmul for matrix multiplication.

I missed this PR! I have since then fixed it using the @ operator instead.


Add status field to GRB

Similar to what was implemented for CRTBs in https://github.com/rancher/rancher/pull/47407
Problem
There is no way of knowing if a GRB has successfully created all the backing resources or if any errors occurred.
Solution
There are two controllers that reconcile GRBs. One is reconciling resources in the local cluster, and another is reconciling resources in downstream clusters. In order to avoid conflicts there is a separate conditions slice for each controller.
This PR adds a new Status field to GRBs. It contains the following fields:
ObservedGenerationLocal: the most recent generation observed by the local controller
RemoteConditions: the most recent generation observed by the remote controller
LocalConditions: indicates the status of backing RBAC objects created in the local cluster
RemoteConditions: indicates the status of backing RBAC objects created in the downstream cluster
SummaryLocal: represents the summary of the resources created in the local cluster
SummaryRemote: represents the summary of the resources created in the remote cluster
Summary: represents the summary of all resources
Status is updated only once per reconcilation loop and only if any of the status conditions has changed.
Testing

Engineering Testing
Manual Testing

Automated Testing

Test types added/modified:

Unit
Integration (Go Framework)
Integration (v2prov Framework)
Validation (Go Framework)
Other - Explain: EXPLAIN
None
REMOVE NOT APPLICABLE BULLET POINTS ABOVE

If "None" - Reason: EXPLAIN THE REASON

If "None" - GH Issue/PR: LINK TO GH ISSUE/PR TO ADD TESTS

Summary: TODO
QA Testing Considerations

Regressions Considerations

TODO
Existing / newly added automated tests that provide evidence there are no regressions:

TODO

I rebased and fixed the conflicts. Please have another look.

@pmatseykanets I had to revert https://github.com/rancher/rancher/pull/47712#discussion_r1858633011. Let me know what you think.

@pmatseykanets @crobby I rebased the main branch in order to fix the conflicts. Please have a look.


Error when running plugin

Hi
I am trying to use confluence and i am getting the following error.
steampipe query "select * from confluence_content;"
Error: rpc error: code = Internal desc = hydrate function listContent failed with panic runtime error: invalid memory address or nil pointer dereference (SQLSTATE HV000)
+----+-------+-----------+--------+------+----------------+------+
| id | title | space_key | status | type | version_number | _ctx |
+----+-------+-----------+--------+------+----------------+------+
+----+-------+-----------+--------+------+----------------+------+
any ideas why ?
Thanks

I'm not sure why you're getting that error but I can look at this next week.
Do you have any other logs you can share?

@shemreader Do you get more information in ~/.steampipe/logs if you try doing
export STEAMPIPE_LOG_LEVEL=debug

and then rerunning?

The logs appear to be exclusively about the grafana plugin, not this one.
I can't reproduce, so closing for now.
Happy to reopen if there is more info.


App controller mods

Summary

Make ApplicationController inherit from ActionController::API read this
protect_from_forgery with: :null_session not necessary anymore

You have duplicated code in #71. That other one includes this PR, I think this one is obsolete