DNX Beta-8 Publish HttpPlatformHandler cannot be found. This error is random

The description for Event ID 1001 from source HttpPlatformHandler cannot be found. Either the component that raises this event is not installed on your local computer or the installation is corrupted. You can install or repair the component on the local computer.
If the event originated on another computer, the display information had to be saved with the event.
The following information was included with the event:
Process '4248' started successfully and is listening on port '12618'.

This issue was moved to aspnet/IISIntegration#32


Add bitbar notify plugin.

I made a couple of mistakes here.. i will recreate the pr as soon as I have some time.


Fixed Pycharm highlighting issue.

All Submissions:

[ ] Have you followed the guidelines stated in CONTRIBUTING.md file?
[ ] Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

New Feature Submission:

[ ] Does your submission pass the tests?
[ ] Have you linted your code locally prior to submission?

Changes To Core Features:

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your core changes, as applicable?
[ ] Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.
a. Give a descriptive title to your PR.

b. Describe your changes.

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).

I think we should take these changes to a single file.
If we create a new component, we add it to this single file.

This is the single file for all the components, the ones below my changes are also pc components

I think we should take these changes to a single file.
If we create a new component, we add it to this single file.

Thanks for reviewing though, feel free to review any more pr's win the future if you have time. Its a big help to get some extra eyes on the code


Returning local filename in node.js in getModelFile

A slight optimization to pass filename instead of Buffer to onnxruntime in node.js

Is this ready for review or a draft? Right now it crashes for me in node.js:
> const { pipeline } = await import("./src/transformers.js");

> const pipe = await pipeline("automatic-speech-recognition", "Xenova/whisper-tiny");

sorry, my bad. is there an easy way to run tests for the browser?

sorry, my bad. is there an easy way to run tests for the browser?

Sorry, not that I know, I just tested this PR against the code that I use anyway:
test.html
<body></body>
<script>
  function importFile(content) {
    return "data:text/javascript;base64," + btoa(content);
  }
  const imports = {
    "transformers": "../transformers.js_es6/src/transformers.js",
    "fs": importFile("export default {};"),
    "url": importFile("export default {};"),
    "path": importFile("export default {};"),
    "stream/web": importFile("export default {};"),
    "sharp": importFile("export default {};"),
    "onnxruntime-node": importFile("export default {};"),
    "onnxruntime-web": importFile(`
      await import("https://cdnjs.cloudflare.com/ajax/libs/onnxruntime-web/1.14.0/ort.es6.min.js");
      //http://<IP_ADDRESS>/transformer/onnxruntime/js/common/dist/
      //await import("http://<IP_ADDRESS>/transformer/onnxruntime/js/common/dist/ort-common.js");
      //await import("http://<IP_ADDRESS>/transformer/onnxruntime/js/web/dist/ort-webgl.js");
      //await import("https://cdnjs.cloudflare.com/ajax/libs/onnxruntime-web/1.14.0/ort.es6.min.js");
      let ONNX = globalThis.ort;
      export default ONNX;
      export {
        ONNX
      };
    `),
  };
  const importmap = document.createElement("script");
  importmap.type = "importmap";
  importmap.textContent = JSON.stringify({imports});
  document.body.appendChild(importmap);
</script>
<script type="module">
  import * as transformers from "transformers";
  Object.assign(window, {...transformers});
</script>
<!--
  <audio id="SPEECH2TEXT_AUDIO" src="./examples/demo-site/assets/audio/jfk.wav" controls="true"></audio>
  <audio id="SPEECH2TEXT_AUDIO" src="./examples/demo-site/assets/audio/minner_fra_krigen.wav" controls="true"></audio>
-->
<audio id="SPEECH2TEXT_AUDIO" src="./audio/minner_fra_krigen_short.wav" controls="true"></audio>

And then you can just test around via F12/devtools for quick testing:
const pipe = await pipeline("automatic-speech-recognition", "Xenova/whisper-tiny");
const audioCTX = new AudioContext({
  sampleRate: 16000
});
const arrayBuffer = await (await fetch(SPEECH2TEXT_AUDIO.currentSrc)).arrayBuffer();
const decoded = await audioCTX.decodeAudioData(arrayBuffer);
const audio = decoded.getChannelData(0);
const result = await pipe(audio, {
  return_timestamps: true,
  //chunk_length_s: 30,
  chunk_callback: console.log
});
console.log("result", result);

I hope that helps, quick testing without any build tool etc.

@kungfooman i've fixed cache behaviour in node and browser
and got to an unrelated issue. i've fixed it by replacing "wasm" backend to "cpu" in node env, looks like you had something similar. related to loading wasm files. i've double-checked it first by removing node_modules (to see if it had my patched runtime) but it did not help

here you go. benchmarks look great!

These changes are going to be obsolete as I'm going to add passing the Response object directly to ONNX runtime, so it can read data with chunks from web/cache directly into webassembly memory. With current implementation it allocates memory for the model twice and UInt8Array cannot hold >4gb of data, so closing for now and will get back to it after ONNX pull request is merged

These changes are going to be obsolete as I'm going to add passing the Response object directly to ONNX runtime, so it can read data with chunks from web/cache directly into webassembly memory.

Awesome! Does the current version of ORT support passing response objects, or is that something you will add in your fork? If it's your fork, maybe the microsoft folks would be interested in adding support for it!

Does the current version of ORT support passing response objects, or is that something you will add in your fork?

In mine. I've created a draft pull request to have some discussion. It cannot be merged and built yet because only 2 of 4 of my emscripten (webassembly compiler toolchain) pull requests are merged

Gotcha 👌 You're doing so much amazing work! 🔥 Just out of curiosity, do you know if there's a way to skip this duplication of memory, not by passing a response object, but simply using the same array buffer (or uint8array)? I find it very strange that this isn't handled correctly by ORT itself.

There is no way of doing that, because WASM has a separate isolated memory (basically an array buffer). You can check how I do it now https://github.com/dakenf/onnxruntime/blob/0ddc05b978c42c1e29868239297266d5e9a579f0/js/web/lib/wasm/wasm-core-impl.ts#L86
So here can be only two ways: passing a response/some kind of readable stream or exporting WASM memory from ORT runtime but I don't think maintainers would agree to do that

You're doing so much amazing work!

I just wanted to generate some pictures in the browser 😄 But after realizing its not possible yet, I decided to see how far I can go to fix it in my free time. For now its very interesting and would be a great case for resume


🐛 [firebase_auth] reCaptcha challenge still shown after APN configuration

Bug report
I've followed the steps described here in order to configure the silent notifications so it's no longer needed to complete the reCaptcha challenge using Phone Auth. However, after enabling APN services in Xcode and uploading my APN key to Firebase console, the reCaptcha challenge is still shown.
Steps to reproduce
Seconds after calling _firebaseAuth.verifyPhoneNumber(...), the webview of the challenge shows up.
Expected behavior
reCaptcha challenge shouldn't be shown.

Additional context

No error message of any kind are thrown, so it's hards to tell what's going wrong
I use this phone as testing device, so I have launched many times the SMS sequence, therefore I don't know if the reCaptcha may be caused by the previous attempt.

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.10.3, on macOS 12.2.1 21D62 darwin-arm, locale es-ES)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 4.2)
[✓] VS Code (version 1.65.1)
[✓] Connected device (2 available)
[✓] HTTP Host Availability

• No issues found!

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 2.16.1
Flutter SDK 2.10.3
controlcenter 0.0.1+1

dependencies:
- async_redux 12.0.0 [logging path path_provider file weak_map fast_immutable_collections collection meta flutter]
- cached_network_image 3.2.0 [flutter flutter_cache_manager octo_image cached_network_image_platform_interface cached_network_image_web]
- carousel_slider 4.0.0 [flutter]
- crop 0.5.2 [flutter collision vector_math]
- cupertino_icons 1.0.4
- faker 2.0.0 [crypto]
- firebase_analytics 8.3.4 [firebase_analytics_platform_interface firebase_analytics_web firebase_core flutter meta]
- firebase_app_check 0.0.6+5 [firebase_app_check_platform_interface firebase_app_check_web firebase_core firebase_core_platform_interface flutter]
- firebase_auth 3.3.7 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta]
- firebase_core 1.12.0 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_crashlytics 2.5.1 [firebase_core firebase_core_platform_interface firebase_crashlytics_platform_interface flutter stack_trace]
- firebase_database 7.2.2 [firebase_core firebase_database_platform_interface flutter]
- firebase_dynamic_links 3.0.2 [firebase_core flutter]
- firebase_performance 0.7.1+5 [firebase_core firebase_core_platform_interface firebase_performance_platform_interface firebase_performance_web flutter]
- firebase_storage 10.2.7 [firebase_core firebase_core_platform_interface firebase_storage_platform_interface firebase_storage_web flutter]
- flutter 0.0.0 [characters collection material_color_utilities meta typed_data vector_math sky_engine]
- flutter_html 2.2.1 [html csslib flutter_layout_grid video_player chewie webview_flutter chewie_audio flutter_svg flutter_math_fork collection numerus flutter]
- flutter_localizations 0.0.0 [flutter intl characters clock collection material_color_utilities meta path typed_data vector_math]
- flutter_map 0.14.0 [async collection flutter http intl latlong2 meta positioned_tap_detector_2 proj4dart transparent_image tuple vector_math]
- flutter_spinkit 5.1.0 [flutter]
- flutter_svg 0.23.0+1 [flutter meta path_drawing vector_math xml]
- flutter_vibrate 1.3.0 [flutter]
- font_awesome_flutter 9.2.0 [flutter]
- get_it 7.2.0 [async collection]
- google_fonts 2.3.1 [flutter http path_provider crypto]
- http 0.13.4 [async http_parser meta path]
- image_picker 0.8.4+9 [flutter flutter_plugin_android_lifecycle image_picker_for_web image_picker_platform_interface]
- intl 0.17.0 [clock path]
- keyboard_actions 3.4.7 [flutter]
- latlong2 0.8.1 [intl]
- logger 1.1.0
- mask_text_input_formatter 2.1.0 [flutter]
- reactive_forms 10.7.0 [flutter intl]
- reactive_phone_form_field 0.0.1 [flutter reactive_forms phone_form_field]
- reactive_pin_code_fields 0.0.2 [flutter reactive_forms pin_code_fields]
- reorderables 0.4.2 [flutter]
- rxdart 0.27.3
- share_plus 3.1.0 [meta mime flutter share_plus_platform_interface share_plus_linux share_plus_macos share_plus_windows share_plus_web]
- simple_gql 1.2.0 [http meta]
- sleek_circular_slider 2.0.1 [flutter]
- twilio_programmable_video 0.12.0 [flutter permission_handler enum_to_string twilio_programmable_video_platform_interface collection]
- url_launcher 6.0.20 [flutter url_launcher_android url_launcher_ios url_launcher_linux url_launcher_macos url_launcher_platform_interface url_launcher_web url_launcher_windows]
- uuid 3.0.6 [crypto]
- wakelock 0.5.6 [flutter meta wakelock_macos wakelock_platform_interface wakelock_web wakelock_windows]

dev dependencies:
- build_runner 2.1.7 [args async analyzer build build_config build_daemon build_resolvers build_runner_core code_builder collection crypto dart_style frontend_server_client glob graphs http_multi_server io js logging meta mime package_config path pool pub_semver pubspec_parse shelf shelf_web_socket stack_trace stream_transform timing watcher web_socket_channel yaml]
- firebase_database_mocks 0.2.0+1 [flutter firebase_database pedantic mockito firebase_core_platform_interface flutter_test]
- flutter_launcher_icons 0.9.2 [args image path yaml]
- flutter_lints 1.0.4 [lints]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher material_color_utilities meta source_span stream_channel string_scanner term_glyph typed_data]
- mockito 5.1.0 [analyzer build code_builder collection dart_style matcher meta path source_gen test_api]

dependency overrides:
- flutter_math_fork 0.5.0 [flutter flutter_svg provider meta collection tuple]

transitive dependencies:
- _fe_analyzer_shared 34.0.0 [meta]
- analyzer 3.2.0 [_fe_analyzer_shared cli_util collection convert crypto glob meta package_config path pub_semver source_span watcher yaml]
- archive 3.2.1 [crypto path]
- args 2.3.0
- async 2.8.2 [collection meta]
- boolean_selector 2.1.0 [source_span string_scanner]
- build 2.2.1 [analyzer async convert crypto glob logging meta path]
- build_config 1.0.0 [checked_yaml json_annotation path pubspec_parse yaml]
- build_daemon 3.0.1 [built_collection built_value http_multi_server logging path pool shelf shelf_web_socket stream_transform watcher web_socket_channel]
- build_resolvers 2.0.6 [analyzer async build crypto graphs logging path package_config pool pub_semver stream_transform yaml]
- build_runner_core 7.2.3 [async build build_config build_resolvers collection convert crypto glob graphs json_annotation logging meta path package_config pool timing watcher yaml]
- built_collection 5.1.1
- built_value 8.1.4 [built_collection collection fixnum meta]
- cached_network_image_platform_interface 1.0.0 [flutter flutter_cache_manager]
- cached_network_image_web 1.0.1 [flutter flutter_cache_manager cached_network_image_platform_interface]
- characters 1.2.0
- charcode 1.3.1
- checked_yaml 2.0.1 [json_annotation source_span yaml]
- chewie 1.1.0 [cupertino_icons flutter video_player wakelock]
- chewie_audio 1.3.0 [cupertino_icons flutter video_player]
- circle_flags 0.0.2 [flutter]
- cli_util 0.3.5 [meta path]
- clock 1.1.0
- code_builder 4.1.0 [built_collection built_value collection matcher meta]
- collection 1.15.0
- collision 0.0.3 [vector_math]
- convert 3.0.1 [typed_data]
- cross_file 0.3.2 [flutter js meta]
- crypto 3.0.1 [collection typed_data]
- csslib 0.17.1 [source_span]
- dart_countries 2.1.0
- dart_style 2.2.1 [analyzer args path pub_semver source_span]
- dartlin 0.6.2
- enum_to_string 2.0.1
- equatable 2.0.3 [collection meta]
- fake_async 1.2.0 [clock collection]
- fast_immutable_collections 5.1.3 [collection meta]
- ffi 1.1.2
- file 6.1.2 [meta path]
- firebase 9.0.2 [http http_parser js]
- firebase_analytics_platform_interface 2.0.1 [flutter meta]
- firebase_analytics_web 0.3.0+1 [firebase firebase_analytics_platform_interface flutter flutter_web_plugins meta]
- firebase_app_check_platform_interface 0.0.3+5 [firebase_core flutter meta plugin_platform_interface]
- firebase_app_check_web 0.0.5+5 [firebase_app_check_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js]
- firebase_auth_platform_interface 6.1.11 [firebase_core flutter meta plugin_platform_interface]
- firebase_auth_web 3.3.7 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser intl js meta]
- firebase_core_platform_interface 4.2.4 [collection flutter meta plugin_platform_interface]
- firebase_core_web 1.5.4 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- firebase_crashlytics_platform_interface 3.1.13 [collection firebase_core flutter meta plugin_platform_interface]
- firebase_database_platform_interface 0.0.1+1 [collection firebase_core flutter meta plugin_platform_interface]
- firebase_performance_platform_interface 0.0.1+8 [firebase_core flutter plugin_platform_interface]
- firebase_performance_web 0.0.3+1 [firebase firebase_core firebase_core_web firebase_performance_platform_interface flutter flutter_web_plugins]
- firebase_storage_platform_interface 4.0.14 [collection firebase_core flutter meta plugin_platform_interface]
- firebase_storage_web 3.2.8 [async firebase_core firebase_core_web firebase_storage_platform_interface flutter flutter_web_plugins http js meta]
- fixnum 1.0.0
- flutter_blurhash 0.6.4 [flutter]
- flutter_cache_manager 3.3.0 [clock collection file flutter http path path_provider pedantic rxdart sqflite uuid]
- flutter_layout_grid 1.0.3 [flutter collection meta quiver]
- flutter_plugin_android_lifecycle 2.0.5 [flutter]
- flutter_web_plugins 0.0.0 [flutter js characters collection material_color_utilities meta typed_data vector_math]
- frontend_server_client 2.1.2 [async path]
- glob 2.0.2 [async collection file path string_scanner]
- graphs 2.1.0 [collection]
- html 0.15.0 [csslib source_span]
- http_multi_server 3.2.0 [async]
- http_parser 4.0.0 [charcode collection source_span string_scanner typed_data]
- image 3.1.3 [archive meta xml]
- image_picker_for_web 2.1.6 [flutter flutter_web_plugins image_picker_platform_interface]
- image_picker_platform_interface 2.4.4 [cross_file flutter http plugin_platform_interface]
- io 1.0.3 [meta path string_scanner]
- js 0.6.3
- json_annotation 4.4.0 [meta]
- lints 1.0.1
- lists 1.0.1 [meta]
- logging 1.0.2
- matcher 0.12.11 [stack_trace]
- material_color_utilities 0.1.3
- meta 1.7.0
- mgrs_dart 2.0.0 [unicode]
- mime 1.0.1
- nested 1.0.0 [flutter]
- numerus 1.1.1
- octo_image 1.0.1 [flutter flutter_blurhash]
- package_config 2.0.2 [path]
- path 1.8.0
- path_drawing 0.5.1+1 [vector_math meta path_parsing flutter]
- path_parsing 0.2.1 [vector_math meta]
- path_provider 2.0.9 [flutter path_provider_android path_provider_ios path_provider_linux path_provider_macos path_provider_platform_interface path_provider_windows]
- path_provider_android 2.0.11 [flutter path_provider_platform_interface]
- path_provider_ios 2.0.7 [flutter path_provider_platform_interface]
- path_provider_linux 2.1.5 [ffi flutter path path_provider_platform_interface xdg_directories]
- path_provider_macos 2.0.5 [flutter path_provider_platform_interface]
- path_provider_platform_interface 2.0.3 [flutter platform plugin_platform_interface]
- path_provider_windows 2.0.5 [ffi flutter path path_provider_platform_interface win32]
- pedantic 1.11.1
- permission_handler 8.3.0 [flutter meta permission_handler_platform_interface]
- permission_handler_platform_interface 3.7.0 [flutter meta plugin_platform_interface]
- petitparser 4.4.0 [meta]
- phone_form_field 4.5.0 [flutter flutter_localizations circle_flags phone_numbers_parser dart_countries intl]
- phone_number_metadata 4.0.2
- phone_numbers_parser 4.2.0 [phone_number_metadata meta]
- pin_code_fields 7.3.0 [flutter]
- platform 3.1.0
- plugin_platform_interface 2.1.2 [meta]
- pool 1.5.0 [async stack_trace]
- positioned_tap_detector_2 1.0.4 [flutter]
- process 4.2.4 [file path platform]
- proj4dart 2.0.0 [mgrs_dart wkt_parser meta]
- provider 6.0.2 [collection flutter nested]
- pub_semver 2.1.0 [collection meta]
- pubspec_parse 1.2.0 [checked_yaml collection json_annotation pub_semver yaml]
- quiver 3.0.1+1 [matcher]
- share_plus_linux 2.0.4 [share_plus_platform_interface file flutter meta url_launcher]
- share_plus_macos 2.0.2 [share_plus_platform_interface flutter]
- share_plus_platform_interface 2.0.1 [flutter meta mime plugin_platform_interface]
- share_plus_web 2.0.4 [share_plus_platform_interface url_launcher flutter flutter_web_plugins meta]
- share_plus_windows 2.0.3 [share_plus_platform_interface flutter meta url_launcher]
- shelf 1.2.0 [async collection http_parser path stack_trace stream_channel]
- shelf_web_socket 1.0.1 [shelf stream_channel web_socket_channel]
- sky_engine 0.0.99
- source_gen 1.2.1 [analyzer async build dart_style glob meta path source_span yaml]
- source_span 1.8.1 [collection path term_glyph]
- sqflite 2.0.2 [flutter sqflite_common path]
- sqflite_common 2.2.0 [synchronized path meta]
- stack_trace 1.10.0 [path]
- stream_channel 2.1.0 [async]
- stream_transform 2.0.0
- string_scanner 1.1.0 [charcode source_span]
- synchronized 3.0.0
- term_glyph 1.2.0
- test_api 0.4.8 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher]
- timing 1.0.0 [json_annotation]
- transparent_image 2.0.0
- tuple 2.0.0 [quiver]
- twilio_programmable_video_platform_interface 0.7.0 [flutter meta enum_to_string plugin_platform_interface collection dartlin equatable]
- typed_data 1.3.0 [collection]
- unicode 0.3.1 [lists]
- url_launcher_android 6.0.15 [flutter url_launcher_platform_interface]
- url_launcher_ios 6.0.15 [flutter url_launcher_platform_interface]
- url_launcher_linux 3.0.0 [flutter url_launcher_platform_interface]
- url_launcher_macos 3.0.0 [flutter url_launcher_platform_interface]
- url_launcher_platform_interface 2.0.5 [flutter plugin_platform_interface]
- url_launcher_web 2.0.8 [flutter flutter_web_plugins url_launcher_platform_interface]
- url_launcher_windows 3.0.0 [flutter url_launcher_platform_interface]
- vector_math 2.1.1
- video_player 2.2.18 [flutter video_player_android video_player_avfoundation video_player_platform_interface video_player_web html]
- video_player_android 2.3.0 [flutter video_player_platform_interface]
- video_player_avfoundation 2.3.0 [flutter video_player_platform_interface]
- video_player_platform_interface 5.1.0 [flutter plugin_platform_interface]
- video_player_web 2.0.7 [flutter flutter_web_plugins video_player_platform_interface]
- wakelock_macos 0.4.0 [flutter flutter_web_plugins wakelock_platform_interface]
- wakelock_platform_interface 0.3.0 [flutter meta]
- wakelock_web 0.4.0 [flutter flutter_web_plugins js wakelock_platform_interface]
- wakelock_windows 0.2.0 [flutter wakelock_platform_interface win32]
- watcher 1.0.1 [async path]
- weak_map 2.0.4
- web_socket_channel 2.1.0 [async crypto stream_channel]
- webview_flutter 2.8.0 [flutter webview_flutter_android webview_flutter_platform_interface webview_flutter_wkwebview]
- webview_flutter_android 2.8.3 [flutter webview_flutter_platform_interface]
- webview_flutter_platform_interface 1.8.1 [flutter plugin_platform_interface]
- webview_flutter_wkwebview 2.7.1 [flutter webview_flutter_platform_interface]
- win32 2.4.1 [ffi]
- wkt_parser 2.0.0
- xdg_directories 0.2.0+1 [meta path process]
- xml 5.3.1 [collection meta petitparser]
- yaml 3.1.0 [collection source_span string_scanner]

Thanks for the report. I believe your use case is same as reported here: https://github.com/FirebaseExtended/flutterfire/issues/7364
https://github.com/FirebaseExtended/flutterfire/issues/7364#issuecomment-968499722
https://github.com/FirebaseExtended/flutterfire/issues/7364#issuecomment-983728237
I suggest you to follow-up in the linked issue for further updates.
Closing this as a duplicate.


BCMOHAD-23188 || Updated the API versions to 60.0

Description
Updated the Api version to 60.0
Fixes # (issue)
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

List high-level changes as bullet items
Below are some examples

[ ] Changed field permissions
[ ] changed field data-type

Deployment Tracker
List all the metadata that is pushed in this commit/PR. Full URL should be fine.
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@RanadheerRG , your feature branch does not have the latest code changes and there are around 310 that are upgraded to API Version v60 and I've those changes ready in my branch.
CC: @NataliaNikishina , @cgijeffolsen


SpinBox: added options for step size and display base

While useful in general, my immediate use case is the quantizer needing even numbers for bits and all the TurboFEC stuff showing integral numbers in octal.


Add Borders Around your Elements

I am having trouble with the code being accepted, I have tried for 2 hours trying to figure this out, and have tried a google search all to no avail.
There is no link to request help.

Purr jump eat the grass rip the couch scratched sunbathe, shed everywhere rip the couch sleep in the sink fluffy fur catnip scratched.

Hi, if the code you posted is giving you trouble,it seems that it's due to a missing curly bracket to close the element:
.thick-green-border{}

I tried that and it still is not working thanks for the feed back.


Run some commands inside VM

Hi Justin,
As the author of nsenter1 you are the only person probably who can help me with small issue:
Before starting our containers we want to run 2 commands inside VM host
‘’’
modprobe nfs
modprobe nfsd
‘’’
Could this be dine easily with ncenter1?

yes you should be able to do docker run --pid=host --privileged justincormack/nsenter1 /sbin/modprobe nfsd in principal

It connects to the host in all cases.


Nonmathematical Matrix Applications

I'm playing around with matrices for questions, and was wondering if there's a way to customize them for better non-math applications.  For example:

Can a matrix be programmed with Row and/or Column Titles?  This would be useful in setting up truth tables for Digital Logic questions.  The columns could be titled with the input/output variable names

Can a matrix be partially/pre filled in with some of the values?  In a 4x8 matrix, that's 32 individual entries.  If we could fill some of them in beforehand, that might alleviate some of the effort needed

Can a matrix have gridline specifications?  In the Digital Logic concept, it would be useful to have a dividing line between the input columns and the output columns.

Could we superimpose rectangular graphics objects?  Students could use such a feature to set up a Karnough Map (surrounding portions of the matrix to determine the algebraic equivalencies)

These suggestions overlap somewhat with #392 and #377. Most of them are achievable, but will need some thought about the editing interface. Superimposing graphics will be harder - that's not easy to set up in a robust way in HTML.

Updating this: you can now pre-fill some of the entries in a matrix. (See the documentation)


ABC compilation fails in arch armv71

After run ./base.sh, then ./yosys.sh (I installed tcl and python, see #1):
[ 94%] ABC: `` Generating dependency: /src/bdd/reo/reoApi.c
[ 94%] ABC: `` Generating dependency: /src/bdd/mtr/mtrGroup.c
make[1]: * duping jobs pipe: Bad file descriptor.  Stop.
make[1]: * Waiting for unfinished jobs....
make: * [Makefile:752: abc/abc-4f5f73d] Error 2

Maybe related:
make[1]: Entering directory '/data/data/com.termux/files/home/Termux-packages/scripts/yosys/abc'
Using CC=gcc
Using CXX=g++
Using AR=ar
Using LD=g++
CANNOT LINK EXECUTABLE "gcc": library "libiconv.so" not found                                   Compiling with CUDD
Using libreadline
Using pthreads
CANNOT LINK EXECUTABLE "gcc": library "libiconv.so" not found
Found GCC_VERSION
CANNOT LINK EXECUTABLE "gcc": library "libiconv.so" not found                                   CANNOT LINK EXECUTABLE "gcc": library "libiconv.so" not found
Found GCC_MAJOR>=5

Seems a missing library. I will investigate.

Maybe pkg install libiconv? It exists for aarch64.
Alternatively, you can try building Yosys without ABC: ENABLE_ABC=0.

In make -j4 install ... I removed -j4 and it compiles (it takes around 12 hours XD).
However, I detect some problems:

Executing yosys and running an invalid command (such as quit) it produces the message ERROR: No such command: quit (type 'help' for a command overview) (which is ok) following by a Segmentation fault (which is wrong). Maybe something to report in Yosys?
I tried the following:

git clone https://github.com/PyFPGA/pyfpga
cd poc/os-mix
yosys -p 'read_verilog blinking.v; read_verilog top.v; synth_ice40 -top Top -json blinking.json'
It works on my PC (using the newest hdlc/yosys) but it fails in Termux (last version from Google Play on Android 9):

3.39.2. Continuing TECHMAP pass.
No more expansions possible.
<suppressed ~4 debug messages>

3.40. Executing ABC pass (technology mapping using ABC).
ERROR: Assert `p != NULL' failed in kernel/yosys.cc:453.

Could you verify what happens on your mobile?

You need to pass -noabc to synth_ice40, since you built Yosys without ABC. See http://www.clifford.at/yosys/cmd_synth_ice40.html.
With regard to the Segmentation fault, I guess it can be reported to Yosys maintainers. However, I would expect it to be a very low priority issue, because testing is a PITA.

I built Yosys with ABC support (I only remove -j4 from the make instruction).
Anyway, adding -noabc it works.

built Yosys with ABC support

Did you fix the issue with libiconv?

Did you fix the issue with libiconv?

Not yet. Running now trying a workaround :P

Running LD_LIBRARY_PATH=$PREFIX/lib ./yosys.sh' the make -j4 ...` instruction works, but it still fails in synthesis (same error).

I installed the last Termux from F-Droid. There, no complaints about libiconv, but still problems with 4 jobs:
yosys.log


[incubator-kie-isssues-1139] Add support for xpath in conditional paths

Closes https://github.com/apache/incubator-kie-issues/issues/1139

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer
build-chain build full_downstream  -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u https://github.com/apache/incubator-kie-kogito-runtimes/pull/3493 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3493/1/display/redirect
Test results:

PASSED: 3260
FAILED: 1

Those are the test failures:

org.kie.kogito.codegen.tests.PublishEventIT.testExclusiveGatewayStartToEnd
expected: 2 but was: 5

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer
build-chain build full_downstream  -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u https://github.com/apache/incubator-kie-kogito-runtimes/pull/3493 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3493/1/display/redirect
Test results:

PASSED: 3266
FAILED: 1

Those are the test failures:

org.kie.kogito.tracing.QuarkusTracingAddonDevServicesIT.testEvaluateLoanEligibility
io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor#launchDatabases threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image docker.io/postgres:14 at io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor.startDevDb(DevServicesDatasourceProcessor.java:363) at io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor.launchDatabases(DevServicesDatasourceProcessor.java:142) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:849) at io.quarkus.builder.BuildContext.run(BuildContext.java:256) at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538) at java.base/java.lang.Thread.run(Thread.java:833) at org.jboss.threads.JBossThread.run(JBossThread.java:501)Caused by: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image docker.io/postgres:14 at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:359) at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:330) at io.quarkus.devservices.postgresql.deployment.PostgresqlDevServicesProcessor$1.startDatabase(PostgresqlDevServicesProcessor.java:74) at io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor.startDevDb(DevServicesDatasourceProcessor.java:289) ... 12 moreCaused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88) at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:344) ... 15 moreCaused by: org.testcontainers.containers.ContainerLaunchException: Could not create/start container at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:563) at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:354) at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81) ... 16 moreCaused by: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for log output matching '(.*database system is ready to accept connections.*\s)?(.*PostgreSQL Database directory appears to contain a database; Skipping initialization:*\s)?' at org.testcontainers.containers.wait.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:47) at org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52) at org.testcontainers.containers.PostgreSQLContainer.waitUntilContainerStarted(PostgreSQLContainer.java:147) at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:500) ... 18 more

@elguardian From the engine side everything seems to work fine but I found an issue while testing the example in this PR inside a kogito app. Looks like there's a problem when generating the Kogito Persistence when the process variable type is org.w3c.dom.Document. The stack trace says:
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step org.kie.kogito.quarkus.processes.deployment.ProcessesAssetsProcessor#postGenerationProcessing threw an exception: java.lang.RuntimeException: Error while generating proto for model class
org.kie.kogito.hr.XPathProcessModel Custom type org.w3c.dom.Document is no supported by Kogito persistence, please consider using a class that extends java.io.Serializable and contains a no arg constructor

Additionally I couldn't make it work when the process uses a Pojo as variable, but I think we can fix this second scenario in a later improvement.

@pefernan I will take care of the issue in the persistence stuff
https://github.com/apache/incubator-kie-issues/issues/1204


Replace the default weather modules.

A while ago we started the development of the new weather module which is aimed to be the replacement for the current currentweather and weatherforcast modules.
Currently the currentweather and weatherforcastmodules are still the default modules used in the config sample. Since the new weather module is now pretty mature, it might be an idea to move over to the new module in de config sample and phase out the development of the old modules.
Any thoughts on this transition?

There is a file called deprecated. I would add support for modules there, currently, it only supports config options.
At start, I would send an alert if the module is active and add a log.
One release later I would replace the module content with a simple div wrapper saying that the module is deprecated and the user should switch to the new module.

There is a file called deprecated. I would add support for modules there, currently, it only supports config options.
At start, I would send an alert if the module is active and add a log.
One release later I would replace the module content with a simple div wrapper saying that the module is deprecated and the user should switch to the new module.

Also as soon as the modules are deprecated all issues should refer to the new module and only if the issue exists on the new module there should be a fix provided. Same for pull requests.

Also as soon as the modules are deprecated all issues should refer to the new module and only if the issue exists on the new module there should be a fix provided. Same for pull requests.

One release later I would replace the module content with a simple div wrapper saying that the module is deprecated and the user should switch to the new module.

I think that is a bit to harsh. There are a lot of people that don't want to change their config and not all features of the current modules are implemented yet. But stop supporting the old modules might help in people moving over.

Also as soon as the modules are deprecated all issues should refer to the new module and only if the issue exists on the new module there should be a fix provided. Same for pull requests.

I think we can keep merging bug fixing PR's to the old modules for a while but prevent any implementation of new features. Any issue regarding the old modules should refer to the new modules.

One release later I would replace the module content with a simple div wrapper saying that the module is deprecated and the user should switch to the new module.

I think that is a bit to harsh. There are a lot of people that don't want to change their config and not all features of the current modules are implemented yet. But stop supporting the old modules might help in people moving over.

Also as soon as the modules are deprecated all issues should refer to the new module and only if the issue exists on the new module there should be a fix provided. Same for pull requests.

I think we can keep merging bug fixing PR's to the old modules for a while but prevent any implementation of new features. Any issue regarding the old modules should refer to the new modules.

Would it be an option to mark the modules deprecated (somehow) and after x month / 1 year move them into a seperate repo like MMM-LegacyCurrentWeather / MMM-LegacyWeatherforecast (working title)
There they could receive updates without being in the main Repo...

Would it be an option to mark the modules deprecated (somehow) and after x month / 1 year move them into a seperate repo like MMM-LegacyCurrentWeather / MMM-LegacyWeatherforecast (working title)
There they could receive updates without being in the main Repo...

Yeah, that sounds reasonable. Although we can always look for the best option later. I don't think that's something we have to decide now.
The first step is moving over to the new module in the default config. This won't affect existing users.
Is the new module mature enough to take this step?

Yeah, that sounds reasonable. Although we can always look for the best option later. I don't think that's something we have to decide now.
The first step is moving over to the new module in the default config. This won't affect existing users.
Is the new module mature enough to take this step?

I think that is a bit to harsh. There are a lot of people that don't want to change their config

I'm not sure if this is a big issue. Those people will also not update the mirror as long as it runs without an issue.
But new people and the ones actively playing will switch over.

The first step is moving over to the new module in the default config. This won't affect existing users.

I think just replacing it in the config sample is not enough as a first step, because this only affects new users, but they don't know about missing features from the old modules. At least we should also add deprecated logs (affecting users that have issues and check logs) and send an alert on boot (affecting users that are updating their system and have a reboot). Otherwise, we never detect the missing features or existing issues on the new module without using the crowd as QA's.

I think that is a bit to harsh. There are a lot of people that don't want to change their config

I'm not sure if this is a big issue. Those people will also not update the mirror as long as it runs without an issue.
But new people and the ones actively playing will switch over.

The first step is moving over to the new module in the default config. This won't affect existing users.

I think just replacing it in the config sample is not enough as a first step, because this only affects new users, but they don't know about missing features from the old modules. At least we should also add deprecated logs (affecting users that have issues and check logs) and send an alert on boot (affecting users that are updating their system and have a reboot). Otherwise, we never detect the missing features or existing issues on the new module without using the crowd as QA's.

What features are missing in the new module and have they been skipped intentionally?
I didn't notice any difference when I switched except for one more decimal for precipitation (but I mostly use the features that disables stuff that I don't care about).
The only "issue" I see is that the new weather-module uses fetch-api and promises (which I'm all for) on the client side which wont work for people using old iPads as MagicMirror-screens, but they should probably keep running an older version of MagicMirror anyway...
I agree with @fewieden that a logging and an warning notification should be displayed.
Maybe a bit overkill, but could we maybe make some kind of proxy from the old modules to the new:

map configuration parameters from the currentweather and weatherforecast into what they would have been in the new weather-module
load the new weather module after the old module
unload the old modulee

Or maybe do some preprocessing on the config file?

What features are missing in the new module and have they been skipped intentionally?
I didn't notice any difference when I switched except for one more decimal for precipitation (but I mostly use the features that disables stuff that I don't care about).
The only "issue" I see is that the new weather-module uses fetch-api and promises (which I'm all for) on the client side which wont work for people using old iPads as MagicMirror-screens, but they should probably keep running an older version of MagicMirror anyway...
I agree with @fewieden that a logging and an warning notification should be displayed.
Maybe a bit overkill, but could we maybe make some kind of proxy from the old modules to the new:

map configuration parameters from the currentweather and weatherforecast into what they would have been in the new weather-module
load the new weather module after the old module
unload the old modulee

Or maybe do some preprocessing on the config file?

I just came across one feature that I think is missing:
The compliments relies on the CURRENTWEATHER_DATA notification to display the compliments for s specific weather. Only the currentweather module is sending it, not the new one. Or was ist renamed or something and compliments needs to be updated?

I just came across one feature that I think is missing:
The compliments relies on the CURRENTWEATHER_DATA notification to display the compliments for s specific weather. Only the currentweather module is sending it, not the new one. Or was ist renamed or something and compliments needs to be updated?

I just discovered this module in light of Apple's acquisition of Darksky. So far I like it and I was able to recreate most the the layout I had.
Feature requests:

Is it possible to have the hourly forecast setup so that it can show the hourly in increments? So say instead of  1pm, 2pm, 3pm  it can be 1pm, 3pm, 5pm ( or any adjustable increment amount). This way people can get an overview of however many hours without an entire list of entries.

Option to adjust colors in config? (or maybe clearly labeled in css?)

Icon sets? (the overcast icon looks like a moon over clouds to me)

Just a few thoughts off the top of my head, but I'm liking the direction this is going so far. Thank you for this!

I just discovered this module in light of Apple's acquisition of Darksky. So far I like it and I was able to recreate most the the layout I had.
Feature requests:

Is it possible to have the hourly forecast setup so that it can show the hourly in increments? So say instead of  1pm, 2pm, 3pm  it can be 1pm, 3pm, 5pm ( or any adjustable increment amount). This way people can get an overview of however many hours without an entire list of entries.

Option to adjust colors in config? (or maybe clearly labeled in css?)

Icon sets? (the overcast icon looks like a moon over clouds to me)

Just a few thoughts off the top of my head, but I'm liking the direction this is going so far. Thank you for this!

Feature requests:

Are those 3 requests already in the "old" module? Then maybe we should open an issue with "help wanted" for each one?

Feature requests:

Are those 3 requests already in the "old" module? Then maybe we should open an issue with "help wanted" for each one?

Don't think any of them are in the old modules and probably should be posted as separate feature requests, but here's my thoughts on it:

Seems like a nice addition. But I think the hourly part of the weather provider needs a bit refactoring first (depends on OpenWeatherMap-configuration instead of making it an optional implementation, "fetchWeatherData" is a bit too generic) so I skipped implementing that for SMHI even though the original data is hourly.
Use custom.css, it's perfect for this. Lookup the icons class name at https://erikflowers.github.io/weather-icons/ and set the color for it (there are examples for this is in the forum). Should maybe be a part of the documentation for the weather module?
The weather icons are a font and not separate images, supporting multiple icon sets would probably require mapping the icon-values returned from the providers to the icon-sets classes. If it's just one icon that bothers you could override it in the custom.css too or create an issue here if we're using the wrong icon for that provider.

Don't think any of them are in the old modules and probably should be posted as separate feature requests, but here's my thoughts on it:

Seems like a nice addition. But I think the hourly part of the weather provider needs a bit refactoring first (depends on OpenWeatherMap-configuration instead of making it an optional implementation, "fetchWeatherData" is a bit too generic) so I skipped implementing that for SMHI even though the original data is hourly.
Use custom.css, it's perfect for this. Lookup the icons class name at https://erikflowers.github.io/weather-icons/ and set the color for it (there are examples for this is in the forum). Should maybe be a part of the documentation for the weather module?
The weather icons are a font and not separate images, supporting multiple icon sets would probably require mapping the icon-values returned from the providers to the icon-sets classes. If it's just one icon that bothers you could override it in the custom.css too or create an issue here if we're using the wrong icon for that provider.

The only "issue" I see is that the new weather-module uses fetch-api and promises (which I'm all for) on the client side which wont work for people using old iPads as MagicMirror-screens, but they should probably keep running an older version of MagicMirror anyway...

Those OS arent supported anyway anymore. The js files already contains lots of es6 notations that some iOS dont understand.

The only "issue" I see is that the new weather-module uses fetch-api and promises (which I'm all for) on the client side which wont work for people using old iPads as MagicMirror-screens, but they should probably keep running an older version of MagicMirror anyway...

Those OS arent supported anyway anymore. The js files already contains lots of es6 notations that some iOS dont understand.

Maybe a bit overkill, but could we maybe make some kind of proxy from the old modules to the new:

Yeah, to me that sounds like overkill :-) I think the parameters are not so complex that a user cannot do the switch himself with some help from a README in the new module and a deprecation notice in the old one.

Maybe a bit overkill, but could we maybe make some kind of proxy from the old modules to the new:

Yeah, to me that sounds like overkill :-) I think the parameters are not so complex that a user cannot do the switch himself with some help from a README in the new module and a deprecation notice in the old one.

It wasn't for the complexity I made that suggestion. More of a way to force everyone that uses the old modules to actually try the new one so the old ones could be removed quicker. But I agree, it shouldn't be needed.
Don't really see why we shouldn't be able to get rid of it quickly like this:

Deprecate the modules in the next release, with logging if used and a notification on the mirror and updated documentation about the deprecation and how to migrate
On the second release the old modules could show the notification permanent and remove all other functionality of the module and remove them from the documentation
On the third release just remove them completely from both the code and the documentation

It wasn't for the complexity I made that suggestion. More of a way to force everyone that uses the old modules to actually try the new one so the old ones could be removed quicker. But I agree, it shouldn't be needed.
Don't really see why we shouldn't be able to get rid of it quickly like this:

Deprecate the modules in the next release, with logging if used and a notification on the mirror and updated documentation about the deprecation and how to migrate
On the second release the old modules could show the notification permanent and remove all other functionality of the module and remove them from the documentation
On the third release just remove them completely from both the code and the documentation

@buxxi Hey thanks for your answers!
I'm gonna check out the css for the weather icons as you mentioned. I do think css stuff should be documented somehow for this so folks can know what to look for when customizing the css. Like maybe a list of the classes and what it relates to on the weather module display itself . I guess even if it's sort of general at least it would be a starting point they can start searching from.
As far as the sun looking like a moon issue. I now see why that is showing as it did to me. I dunno if it's maybe a bug or if that's just how it's programed, but the day/night versions of the icons are not following the sunrise/sunset time. Where I am, the sun currently rises at say 7:20 , by 8:00 when I'm leaving it still has a moon icon. Same thing at night, by time I get home it still has a sun icon even thought the sun has well set already.  I'm using the default 10 min update time.

@buxxi Hey thanks for your answers!
I'm gonna check out the css for the weather icons as you mentioned. I do think css stuff should be documented somehow for this so folks can know what to look for when customizing the css. Like maybe a list of the classes and what it relates to on the weather module display itself . I guess even if it's sort of general at least it would be a starting point they can start searching from.
As far as the sun looking like a moon issue. I now see why that is showing as it did to me. I dunno if it's maybe a bug or if that's just how it's programed, but the day/night versions of the icons are not following the sunrise/sunset time. Where I am, the sun currently rises at say 7:20 , by 8:00 when I'm leaving it still has a moon icon. Same thing at night, by time I get home it still has a sun icon even thought the sun has well set already.  I'm using the default 10 min update time.

Sorry for my slow response.
It would be okay to display a deprecated message in the logs. And maybe add some info in the source files: This module is deprecated. Any additional feature will no longer be merged. But other then this, I think we shouldn't be spending too much time on this change (skip the proxy idea, and the notification). So my suggestions for now are:

Update de example config.
Add a deprecated message to the log.
Add info in the source file(s).
Update the documentation.

If anyone wants to send some PR's for this, that would be awesome. Otherwise I'll make sure to do this before the next release.

Sorry for my slow response.
It would be okay to display a deprecated message in the logs. And maybe add some info in the source files: This module is deprecated. Any additional feature will no longer be merged. But other then this, I think we shouldn't be spending too much time on this change (skip the proxy idea, and the notification). So my suggestions for now are:

Update de example config.
Add a deprecated message to the log.
Add info in the source file(s).
Update the documentation.

If anyone wants to send some PR's for this, that would be awesome. Otherwise I'll make sure to do this before the next release.

I created a pull request for the first three (https://github.com/MichMich/MagicMirror/pull/2433).

I created a pull request for the first three (https://github.com/MichMich/MagicMirror/pull/2433).

I can try to make a pull request for the documentation too this weekend with a deprecation message and migration example for each of the modules.

I can try to make a pull request for the documentation too this weekend with a deprecation message and migration example for each of the modules.

That would be great! Thanks!

That would be great! Thanks!

Created pull request for it (and two others for the documentation) but I guess you actually merge it when releasing new version since the documentation doesn't have develop-branch.

Yes, whenever I release a new version I go thought the Doc PR's.

This forum post probably needs to be updated to: https://forum.magicmirror.builders/topic/343/default-modules

So, are we really done with the replacing @MichMich ?

It looks like the stale boy thinks so. 😅 I don't see any issues we need to finish. Right?


sap_swpm: prepare_software changes ownership of files every time it runs

In the task prepare_software.yml there are 3 subtasks that will run to change the ownership of the SAP media directory and files, every time it runs.
This adds extra time on the execution (in one customer the media is from NFS, so it takes 15+ minutes more to run).
When running the automation multiple times on the same servers, or also on different servers, it gets to a point where we know that ownership was already set.
Can we make these subtasks optional? So if the user knows that the ownership was already validated/adjusted, they can run the automation with a flag that will prevent the execution of the redundant ownership change.

@rnozaki I agree, this behavior needs to be changed.
FYI - somehow similar issue but for role sap_hana_install: https://github.com/sap-linuxlab/community.sap_install/issues/199

OK, with the PR that I sent, the default behavior would not be changed.
So if someone knows for sure that they do not need to redo the ownership change (after having done it initially), then they can intentionally set the flag to false to avoid the redundant processing.

Solved in #665.


Not able to install niveristand

Can anyone confirm if VS 2021 R2 is compatible with which version of Python & pip?
I am using the VeriStand Python Documentation to install the niveristand, but getting error:
Microsoft Windows [Version 10.0.19044.1826]
(c) Microsoft Corporation. All rights reserved.
C:\Users\SPunnoos>py -m pip install niveristand
Collecting niveristand
Using cached niveristand-2.0.1-py2.py3-none-any.whl (72 kB)
Requirement already satisfied: PyYAML in c:\users\spunnoos\appdata\local\programs\python\python310\lib\site-packages (from niveristand) (6.0)
Collecting pythonnet
Using cached pythonnet-2.5.2.tar.gz (1.9 MB)
Preparing metadata (setup.py) ... done
Requirement already satisfied: pycparser in c:\users\spunnoos\appdata\local\programs\python\python310\lib\site-packages (from pythonnet->niveristand) (2.21)
Building wheels for collected packages: pythonnet
Building wheel for pythonnet (setup.py) ... error
error: subprocess-exited-with-error
× python setup.py bdist_wheel did not run successfully.
│ exit code: 1
╰─> [104 lines of output]
running bdist_wheel
running build
running build_ext
Checking for updates from https://www.nuget.org/api/v2/.
Currently running NuGet.exe 4.1.0.
Updating NuGet.exe to 6.2.1.
Update successful.
Cannot find the specified version of msbuild: '14'
MSBuild auto-detection: using msbuild version '4.0' from 'C:\Windows\Microsoft.NET\Framework64\v4.0.30319'.
C:\Users\SPunnoos\AppData\Local\Temp\NuGetScratch\0vvxphho.y13.nugetrestore.targets(459,20): error MSB4086: A numeric comparison was attempted on "$(MSBuildAssemblyVersion)" that evaluates to "" instead of a number, in condition "'$(MSBuildAssemblyVersion)' < '15.0'". [C:\Users\SPunnoos\AppData\Local\Temp\pip-install-vdloqci2\pythonnet_91a0a74cf96141eab94856f2ca050c9f\src\runtime\Python.Runtime.csproj]
C:\Users\SPunnoos\AppData\Local\Temp\NuGetScratch\0vvxphho.y13.nugetrestore.targets(459,20): error MSB4086: A numeric comparison was attempted on "$(MSBuildAssemblyVersion)" that evaluates to "" instead of a number, in condition "'$(MSBuildAssemblyVersion)' < '15.0'". [C:\Users\SPunnoos\AppData\Local\Temp\pip-install-vdloqci2\pythonnet_91a0a74cf96141eab94856f2ca050c9f\src\testing\Python.Test.csproj]
C:\Users\SPunnoos\AppData\Local\Temp\NuGetScratch\0vvxphho.y13.nugetrestore.targets(459,20): error MSB4086: A numeric comparison was attempted on "$(MSBuildAssemblyVersion)" that evaluates to "" instead of a number, in condition "'$(MSBuildAssemblyVersion)' < '15.0'". [C:\Users\SPunnoos\AppData\Local\Temp\pip-install-vdloqci2\pythonnet_91a0a74cf96141eab94856f2ca050c9f\src\embed_tests\Python.EmbeddingTest.csproj]
C:\Users\SPunnoos\AppData\Local\Temp\NuGetScratch\0vvxphho.y13.nugetrestore.targets(459,20): error MSB4086: A numeric comparison was attempted on "$(MSBuildAssemblyVersion)" that evaluates to "" instead of a number, in condition "'$(MSBuildAssemblyVersion)' < '15.0'". [C:\Users\SPunnoos\AppData\Local\Temp\pip-install-vdloqci2\pythonnet_91a0a74cf96141eab94856f2ca050c9f\src\console\Console.csproj]
C:\Users\SPunnoos\AppData\Local\Temp\NuGetScratch\0vvxphho.y13.nugetrestore.targets(459,20): error MSB4086: A numeric comparison was attempted on "$(MSBuildAssemblyVersion)" that evaluates to "" instead of a number, in condition "'$(MSBuildAssemblyVersion)' < '15.0'". [C:\Users\SPunnoos\AppData\Local\Temp\pip-install-vdloqci2\pythonnet_91a0a74cf96141eab94856f2ca050c9f\src\clrmodule\clrmodule.csproj]
  WARNING: Error reading msbuild project information, ensure that your input solution or project file is valid. NETCore and UAP projects will be skipped, only packages.config files will be restored.
  Restoring NuGet package System.ValueTuple.4.5.0.
  Restoring NuGet package NUnit.ConsoleRunner.3.11.1.
  Restoring NuGet package UnmanagedExports.1.2.7.
  Restoring NuGet package NUnit.3.12.0.
  Adding package 'System.ValueTuple.4.5.0' to folder 'C:\Users\SPunnoos\AppData\Local\Temp\pip-install-vdloqci2\pythonnet_91a0a74cf96141eab94856f2ca050c9f\packages'
  Adding package 'NUnit.3.12.0' to folder 'C:\Users\SPunnoos\AppData\Local\Temp\pip-install-vdloqci2\pythonnet_91a0a74cf96141eab94856f2ca050c9f\packages'
  Adding package 'NUnit.ConsoleRunner.3.11.1' to folder 'C:\Users\SPunnoos\AppData\Local\Temp\pip-install-vdloqci2\pythonnet_91a0a74cf96141eab94856f2ca050c9f\packages'
  Adding package 'UnmanagedExports.1.2.7' to folder 'C:\Users\SPunnoos\AppData\Local\Temp\pip-install-vdloqci2\pythonnet_91a0a74cf96141eab94856f2ca050c9f\packages'
  Added package 'UnmanagedExports.1.2.7' to folder 'C:\Users\SPunnoos\AppData\Local\Temp\pip-install-vdloqci2\pythonnet_91a0a74cf96141eab94856f2ca050c9f\packages'
  Added package 'NUnit.ConsoleRunner.3.11.1' to folder 'C:\Users\SPunnoos\AppData\Local\Temp\pip-install-vdloqci2\pythonnet_91a0a74cf96141eab94856f2ca050c9f\packages'
  Added package 'System.ValueTuple.4.5.0' to folder 'C:\Users\SPunnoos\AppData\Local\Temp\pip-install-vdloqci2\pythonnet_91a0a74cf96141eab94856f2ca050c9f\packages'
  Added package 'NUnit.3.12.0' to folder 'C:\Users\SPunnoos\AppData\Local\Temp\pip-install-vdloqci2\pythonnet_91a0a74cf96141eab94856f2ca050c9f\packages'

  NuGet Config files used:
      C:\Users\SPunnoos\AppData\Roaming\NuGet\NuGet.Config

  Feeds used:
      C:\Users\SPunnoos\.nuget\packages\
      https://api.nuget.org/v3/index.json

  Installed:
      4 package(s) to packages.config projects
  Traceback (most recent call last):
    File "C:\Users\SPunnoos\AppData\Local\Temp\pip-install-vdloqci2\pythonnet_91a0a74cf96141eab94856f2ca050c9f\tools\geninterop\geninterop.py", line 396, in <module>
      sys.exit(main())
    File "C:\Users\SPunnoos\AppData\Local\Temp\pip-install-vdloqci2\pythonnet_91a0a74cf96141eab94856f2ca050c9f\tools\geninterop\geninterop.py", line 357, in main
      python_h = preprocess_python_headers()
    File "C:\Users\SPunnoos\AppData\Local\Temp\pip-install-vdloqci2\pythonnet_91a0a74cf96141eab94856f2ca050c9f\tools\geninterop\geninterop.py", line 238, in preprocess_python_headers
      for line in _check_output(cmd).splitlines():
    File "C:\Users\SPunnoos\AppData\Local\Temp\pip-install-vdloqci2\pythonnet_91a0a74cf96141eab94856f2ca050c9f\tools\geninterop\geninterop.py", line 46, in _check_output
      output = subprocess.check_output(*args, **kwargs)
    File "C:\Users\SPunnoos\AppData\Local\Programs\Python\Python310\lib\subprocess.py", line 420, in check_output
      return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
    File "C:\Users\SPunnoos\AppData\Local\Programs\Python\Python310\lib\subprocess.py", line 501, in run
      with Popen(*popenargs, **kwargs) as process:
    File "C:\Users\SPunnoos\AppData\Local\Programs\Python\Python310\lib\subprocess.py", line 969, in __init__
      self._execute_child(args, executable, preexec_fn, close_fds,
    File "C:\Users\SPunnoos\AppData\Local\Programs\Python\Python310\lib\subprocess.py", line 1438, in _execute_child
      hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
  FileNotFoundError: [WinError 2] The system cannot find the file specified
  Traceback (most recent call last):
    File "<string>", line 2, in <module>
    File "<pip-setuptools-caller>", line 34, in <module>
    File "C:\Users\SPunnoos\AppData\Local\Temp\pip-install-vdloqci2\pythonnet_91a0a74cf96141eab94856f2ca050c9f\setup.py", line 630, in <module>
      setup(
    File "C:\Users\SPunnoos\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\__init__.py", line 87, in setup
      return distutils.core.setup(**attrs)
    File "C:\Users\SPunnoos\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\_distutils\core.py", line 177, in setup
      return run_commands(dist)
    File "C:\Users\SPunnoos\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\_distutils\core.py", line 193, in run_commands
      dist.run_commands()
    File "C:\Users\SPunnoos\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\_distutils\dist.py", line 968, in run_commands
      self.run_command(cmd)
    File "C:\Users\SPunnoos\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\dist.py", line 1217, in run_command
      super().run_command(command)
    File "C:\Users\SPunnoos\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\_distutils\dist.py", line 987, in run_command
      cmd_obj.run()
    File "C:\Users\SPunnoos\AppData\Local\Temp\pip-install-vdloqci2\pythonnet_91a0a74cf96141eab94856f2ca050c9f\setup.py", line 612, in run
      return bdist_wheel.bdist_wheel.run(self)
    File "C:\Users\SPunnoos\AppData\Local\Programs\Python\Python310\lib\site-packages\wheel\bdist_wheel.py", line 299, in run
      self.run_command('build')
    File "C:\Users\SPunnoos\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\_distutils\cmd.py", line 317, in run_command
      self.distribution.run_command(command)
    File "C:\Users\SPunnoos\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\dist.py", line 1217, in run_command
      super().run_command(command)
    File "C:\Users\SPunnoos\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\_distutils\dist.py", line 987, in run_command
      cmd_obj.run()
    File "C:\Users\SPunnoos\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\command\build.py", line 24, in run
      super().run()
    File "C:\Users\SPunnoos\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\_distutils\command\build.py", line 131, in run
      self.run_command(cmd_name)
    File "C:\Users\SPunnoos\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\_distutils\cmd.py", line 317, in run_command
      self.distribution.run_command(command)
    File "C:\Users\SPunnoos\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\dist.py", line 1217, in run_command
      super().run_command(command)
    File "C:\Users\SPunnoos\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\_distutils\dist.py", line 987, in run_command
      cmd_obj.run()
    File "C:\Users\SPunnoos\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\_distutils\command\build_ext.py", line 339, in run
      self.build_extensions()
    File "C:\Users\SPunnoos\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\_distutils\command\build_ext.py", line 459, in build_extensions
      self._build_extensions_serial()
    File "C:\Users\SPunnoos\AppData\Local\Programs\Python\Python310\lib\site-packages\setuptools\_distutils\command\build_ext.py", line 485, in _build_extensions_serial
      self.build_extension(ext)
    File "C:\Users\SPunnoos\AppData\Local\Temp\pip-install-vdloqci2\pythonnet_91a0a74cf96141eab94856f2ca050c9f\setup.py", line 302, in build_extension
      subprocess.check_call([sys.executable, geninterop, interop_file])
    File "C:\Users\SPunnoos\AppData\Local\Programs\Python\Python310\lib\subprocess.py", line 369, in check_call
      raise CalledProcessError(retcode, cmd)
  subprocess.CalledProcessError: Command '['C:\\Users\\SPunnoos\\AppData\\Local\\Programs\\Python\\Python310\\python.exe', 'tools\\geninterop\\geninterop.py', 'src\\runtime\\interop310.cs']' returned non-zero exit status 1.
  [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for pythonnet
Running setup.py clean for pythonnet
Failed to build pythonnet
Installing collected packages: pythonnet, niveristand
Running setup.py install for pythonnet ... error
error: subprocess-exited-with-error
× Running setup.py install for pythonnet did not run successfully.
│ exit code: 1
╰─> [6 lines of output]
usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
or: setup.py --help [cmd1 cmd2 ...]
or: setup.py --help-commands
or: setup.py cmd --help
  error: option --single-version-externally-managed not recognized
  [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
error: legacy-install-failure
× Encountered error while trying to install package.
╰─> pythonnet
note: This is an issue with the package mentioned above, not pip.
hint: See above for output from the failure.

Duplicate of issue #46.


App Crash when Timezone is America/Mazatlan

I used pod version (2.8.4) in the iOS App and the app crashed when the Timezone is America/Mazatlan and got the below error. It happens on iOS 17 and above.
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Attempted to modify the selection of an out-of-bounds item (57) when there are only 42 items in section 647. Collection view: <FSCalendarCollectionView: 0x13f869e00; baseClass = UICollectionView; frame = (0 0; 0 0); clipsToBounds = YES; gestureRecognizers = <NSArray: 0x1424f1090>; backgroundColor = UIExtendedGrayColorSpace 0 0; layer = <CALayer: 0x1424f0760>; contentOffset: {0, 0}; contentSize: {0, 0}; adjustedContentInset: {0, 0, 0, 0}; layout: <FSCalendarCollectionViewLayout: 0x1424efd80>; dataSource: <FSCalendar: 0x1424a7050; frame = (8 0; 398 300); clipsToBounds = YES; hidden = YES; autoresize = RM+BM; backgroundColor = UIExtendedGrayColorSpace 0 1; layer = <CALayer: 0x1403c3c20>>>.'
*** First throw call stack:
(0x19838979c 0x19095b6a8 0x197940dc0 0x19a6f17b0 0x19a6f05e8 0x19a6f0584 0x104ceb43c 0x104ceaac4 0x104ceaa48 0x102d03c98 0x102cee160 0x102cffa60 0x19a4f8830 0x19a4f846c 0x19a4d5a50 0x19a4d5354 0x19a4d4a44 0x19a4d49ac 0x19a3f9c28 0x1998607e0 0x19986036c 0x199866500 0x19985fae0 0x19985f794 0x1982d8ba0 0x1982d7654 0x1982d6cf4 0x1982d6824 0x1d6af29fc 0x19a5db7f0 0x19a5dae5c 0x19a7d96b0 0x102b33f10 0x102b33e88 0x102b55d54 0x1b8daf9c4)
libc++abi: terminating due to uncaught exception of type NSException

one more logs for this crash
Assertion failure in -[FSCalendarCollectionView _validateSelectionOrHighlightIndexPath:isSelection:allowMassIndexPath:assertIfInvalid:], UICollectionView.m:8,265

Same problem I have, one way is to make default time zone for calendar, crash is gone but do not know if it's correct way, as all users will have one time zone.
class XYZFSCalendar: FSCalendar {
override init(frame: CGRect) {
super.init(frame: frame)
}
required init?(coder aDecoder: NSCoder) {
super.init(coder: aDecoder)
   if let projectTimeZone = TimeZone(identifier: "UTC") {
      self.setValue(projectTimeZone, forKey: "timeZone")
      self.perform(Selector(("invalidateDateTools")))
   }

}
}

Same problem I have, one way is to make default time zone for calendar, crash is gone but do not know if it's correct way, as all users will have one time zone.
class XYZFSCalendar: FSCalendar { override init(frame: CGRect) { super.init(frame: frame) }
required init?(coder aDecoder: NSCoder) { super.init(coder: aDecoder)
   if let projectTimeZone = TimeZone(identifier: "UTC") {
      self.setValue(projectTimeZone, forKey: "timeZone")
      self.perform(Selector(("invalidateDateTools")))
   }

} }

Thanks, I tried this but it does not work in my case.
Even I downloaded the Fscalander demo App and it also crashed with the same case.

Versions above 17 with TimeZone Mazatlan, Mexico.
On Tap FsCalanderScope Example  - It crash

I am not sure why it happens only on this timezone and OS 17, please give any solution if you have.

New PR is created for https://github.com/WenchaoD/FSCalendar/pull/1425
you can test the changes on your project as is one line of code

We need 'Privacy Manifest' to be resolved first.

https://github.com/WenchaoD/FSCalendar/issues/1423#issuecomment-2134682884


unifiStable: 5.13.29 -> 5.13.32

Motivation for this change
Update to latest version, and make sure the service restarts on update.
Not restarting after a package update seems to work in some cases but after this update it was left in a broken state.
Manually restarting the service helped. I think it's a good idea to always restart on update to be on the safe side.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@erictapen I usually get notified by the unifi UI that a new release is available. So no system behind it.


[backlog] Look into string deduplication for Arrow tables

Is your feature request related to a problem? Please describe.
We shoud look into having the SOMAReader (i.e. R/Python read path in tiledbsoma) do string deduplication in the same way that TileDB-Py does when the configuration setting py.deduplicate has value True.
Describe the solution you'd like
This refers to duplicates in the Arrow array (or column) itself.  It is definitely true that pyarrow.Table.to_pandas has dedup on by default (as does Arrow.StringArray).
So, is there a need for an option to have the Arrow Table, as created by SOMAReader, do de-dup to save memory?
Describe alternatives you've considered
This currently works; the ask here is for a memory-reduction option.

That happens automagically for us by R and we have no control (once we bring them in from Arrow).  Consider:
> txt <- c("The quick brown fox")
> object.size(txt)      # not the same as nchar() as the SEXP holding the object has some fixed size
136 bytes
> txtvec <- rep(txt, 100)
> object.size(txtvec)    # not '100x' but (approx.) 100 x size of pointer plus fixed size of SEXP
928 bytes
> txtvec2 <- rep(txt, 1000)
> object.size(txtvec2)   # ditto
8128 bytes
> object.size("")
112 bytes
>

It is a little different once you use ALTREP objects explicitly which I believe Arrow does but I have not yet looked into details.

The comment from Feb 3, 2023 still holds:  we already got the 'hashed entry' behavior from R itself so no extra work needed.  R deals with its string data in a separate pool and hashes them already.  That is not an exposed UI and all internal.
(Historically, if my memory serves me here, 'factors/emums' were the initial way to save here and it was later supplanted by the (much) improved internal representation which is also the reason 'factors as default' was later removed / demoted (as it confused some newer users, and the gains were had already via internal hashing).
So in a way we are not covered twice.  I think we are covered well enough here.

Thanks @eddelbuettel !


NPM Package?

Hi,
We'd love to use this but I couldn't find an NPM package. Any chance you could publish one?
Thanks for all the great work, @christopherthielen !
Cheers

I apologize for the lack of activity.  I'll get this published and moved to its final home at @uirouter/dsr as soon as possible.  It's at the bottom of a long list of packages that need publishing including ui-router-core, angular-ui-router 1.0 final and ui-router-ng2.  They're all moving to @uirouter/* btw

any update on this?  would like to use this with ng1 as well, but also need to work through the issues discussed here: https://github.com/ui-router/sticky-states/issues/4

the other packages are now fully published under the @uirouter/* npm org.  dsr and sticky states are next

DSR has been published along with sticky states

Awesome!


Refactor: Split transaction pre verification to separate function

Hi! I tried to give a shot to https://github.com/bluealloy/revm/issues/432 in this PR. I hope to have understood and addressed the problem indicated by the issue.

Left comments.
And I apologise for a long wait I wanted to think about some additional things to make this more flexible but it missed me, we can push this over the line.

Hi @rakita! I made some small changes according to the comments. Thanks for the feedback. I hope it is ok now.


make classes final

Pull Request Test Coverage Report for Build 157

51 of 56 (91.07%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-3.2%) to 96.835%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Version.php
21
26
80.77%

Totals

Change from base Build 146:
-3.2%

Covered Lines:
153

Relevant Lines:
158

💛  - Coveralls


IDE: Report PLATFORM_DECLARE_CLASH for JvmName annotated functions

object O {
    fun t2(str: String) {

    }

    @JvmName("t2")
    @JvmBlockingBridge
    internal suspend fun test(string: String) {

    }
}

Compiler reports:
Platform declaration clash: The following declarations have the same JVM signature (t2(Ljava/lang/String;)V):
    fun t2(str: String): Unit defined in O
    fun test(string: String): Unit defined in O

However, there is no error in IDE.

Fixed by #11

Fixed by #11


ARROW-14600: [Docs] Fix broken link in Python Development page

Fix a simple sphinx grammatical error of external web pages link here:
https://arrow.apache.org/docs/developers/python.html#build-and-test

cc @jorisvandenbossche


Analyzer CLI does not respect excludes in options files.

Analyzer ignores exclude directives in an options file which is inconsistent with server.

dup of #26212 ?

@zoechi 👍  And sorry for the slow motion on this one.  Taking a look now.

@pq no worries. I love how the analyzer is evolving.


About Us Page

Created frontend/backend for About Us Page on the general website and an About Us Manager Page on the admin side. Changes include:

added API functions
modified fields in officer schema
modified routing and tests to reflect changes in schema
added frontend to About Us Page and adding/editing/deleting ability to About Us Manager

Testing About Us Page:

On the general side, the page should look like this after the executive team and officers have been added.

Features should include:

on hovering over the picture, the executive cards should reveal descriptions and the officer circles should reveal the first name of the officer

on hovering, the executive cards should appear to pop-out of the page (can be seen in screenshot above)
on clicking the linkedin icon on the bottom left corner of the executive cards, the linked in profile should open in a new tab.
any additions/edits/deletions made on About Us Manager side should be reflected in About Us.

Testing About Us Manager
2) Adding an Executive Team Member/Officer

click the button labeled new officer + which will open a modal
fill out the modal accordingly

Editing an Executive Team Member/Officer

click on the executive cards to edit an Executive Team Member's profile
click on the officer circles to edit an Officer's profile

Deleting an Executive Team Member/Officer

click on the executive card/officer circle and click on the delete button
confirmation modal should pop up and upon confirmation, the executive/officer will be deleted

Features:

the form in the creating/editing modal should change depending on whether team selected in executive or officer
a confirmation modal should pop-up on deletion
if required fields are not filled, there should be a yellow colored alert at the bottom of the modal and the submit button should be disabled.
if required fields are filled, there should be a green colored alert and the submit button should be enabled.

I was not able to add executive people from the manager....All the fields were filled in but it didn't allow me to create it....Also rebase

Excellent job. The page works well on mobile

the abundant white space on the page is a bit awkward?
more padding under Executive Team and Meet Our Team would look better
for mobile, could we decrease the padding on the sides, so that the cards and circles would be larger?
for the officer circles, could we have a default background color (the way we do for the exec team cards)?

Limiting blurbs by character count rather than word count might fix the issue with blurbs overflowing.

Closed in favor of new redesign and cleanup, will reference later


Function to disable an external monitor

Before opening the issue, have you...?

[X] Searched for existing issues

Is your feature request related to a problem? Please describe
I am searching for a solution to disable an external monitor
Describe the solution you'd like
I would like to switch off an external display
Describe alternatives you've considered
did not found alternatives
Anything else?
No response

If you mean power control, then this is a planned advanced feature (DDC power control might work if the display supports it - https://github.com/MonitorControl/MonitorControl/issues/524). You can try ddcctl as well https://github.com/kfix/ddcctl as you can send power control signals with that utility.
If you mean disabling an external display without turning it off, then there are some tools for that (https://github.com/Eun/DisableMonitor), but this is not something we plan to add to MonitorControl.


suggestions

updated ES-lint
disabled parts of code which are not used (object changes & messages)
log on state change to silly mode
suggest to use extend object
added TS-Ignore for non-relevant errors of ES-lint

Hi @DutchmanNL .
I fix most of the suggestions you have uploaded.
As you know I fixed some TS lint errors two, I'm sorry that I mixed those changes with your suggestion, so can I merge your changes in my local and push them by myself?
And about extendObject and setObject, I should use extendObject when object is exist, am I right?

Hi @DutchmanNL .
I fix most of the suggestions you have uploaded.

👍

As you know I fixed some TS lint errors two, I'm sorry that I mixed those changes with your suggestion, so can I merge your changes in my local and push them by myself?

yea sure, you can just take the parts of the code and basically close this pull request

And about extendObject and setObject, I should use extendObject when object is exist, am I right?

yes current, extendObject will always create AND update objects when existing plus the capability to update alle contenst of the object JSON (common, native etc).
setObject only handles new creations as far I understood and not able to update alle attributes

Thank you @DutchmanNL
I have merged the patches.


Disable repeated output of the 'Checking for scheduled jobs...' message.

Hi,
the current version writes 'Checking for scheduled jobs...' to the INFO log repeatedly on every call to enqueue_jobs(). This is extremely annoying and costs processor time, especially if the check interval is very small (e.g. 0.1 second).
I know that this behaviour has been explicitly introduced in the commit 40c8228a4aac25a6a60a2d581e7e223f1a08aa0e: self.log.info('Checking for scheduled jobs...'). But I don't know the reason for that. I think, this message should be logged only in DEBUG.
Can you change it to DEBUG or should I make a PR?

I think the current setting is okay for most people. I agree that in your use case (1 check every 0.1 second) it may be a bit verbose, you can configure logging filters for this: https://docs.python.org/2/library/logging.html#filter-objects


Adds Monarch Grammar File Generation

Closes #582 by adding an option to generate a Monarch grammar file. This supplements our existing generation for TextMate grammar files, so we can generate one, both, or neither of them as we choose.
As an example I've updated the statemachine example's langium-config to construct a Monarch grammar, and I've added the resulting file.
Currently I've been comparing the results by using Microsoft's Monarch Editor (playground), and it looks good.
The shows is marked as having quite a few errors in VSCode but the format should be ok when used in a Monaco instance. I haven't tried setting this up directly, but that would be the next step.

Thanks for the feedback @msujew . Next commit of changes should be up sometime later tomorrow.

New changes are up 👍

Last review points added in.


Style

Introducing some first-draft styles in static/style.css as well as the "Slabo" google font and FontAwesome icon set.
Also included is the initial HTML template for the returned service items.

:hamburger:


remove dependency on pdfkit

Since #2311 we don't need this dependency

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @chris48s!

  Generated by :no_entry_sign: dangerJS


Update deep-dive-post-conditions.mdx

I've removed the hyphen from "post conditions" to match the styling of Stacks documentation.
Note: we need to update the sidebar copy as well. Not sure where to do that.

so the official sip uses hyphens when referring to post-conditions throughout, which is why i continued to do so
reference here: https://github.com/stacksgov/sips/blob/main/sips/sip-005/sip-005-blocks-and-transactions.md#transaction-post-conditions
happy to hear others weigh in though @janniks

Happy to do whatever is most official 🤷🏼♀ SIP is good; Stacks Docs does it without hyphens. No strong opinion on my part

Oh I didn't realize the SIP used the hyphen. I was matching what I saw here: https://docs.stacks.co/stacks-101/post-conditions
I don't feel strongly about this. My sense is that more people will read Stacks docs than the SIP, so having uniformity between our docs and theirs would be beneficial, but I see the argument for keeping it as well.

closing this for now


Address recursion in entity reading per C++ Octree::readElementData()

Sort out what the C++ is doing and implement similar in the Web SDK.

PR: https://github.com/vircadia/vircadia-web-sdk/pull/134

PR has been merged.


Show quality in rules execution view

Show quality in rules execution view as a subtitle like in building detail view.
Don't forget to update the quality status after rule execution.
If the status is untested then display a warning message:
Building is untested, error list below may not be valid anymore. Execute the rules to see the latest errors.

Fix formatting of the quality as a grey out subtitle:
Quality: Inconsistent data

If the status is untested then display a warning message:
Building is untested, error list below may not be valid anymore. Execute the rules to see the latest errors.
This is not implemented.


Control panels

Coverage increased (+0.9%) to 58.145% when pulling f0718d1e916c5aaa165b007408ff005afe16e908 on control-panels into 4815e2f6061062d89f57490f5e41f9ee0926b28c on master.


Skin selection for tournament

How can we select skins to use during hero selection for tournament??

We'd need to maintain a list of all the heroes skins in the app. These can be obtained from the game's LUA code, there's a list of all the skins somewhere in there, but I can't remember in which file exactly.
You can decrypt the luaroot file by using the "decrypt" command of the app on the "luaroot" file in the game's APK. Then, use any Unity Extractor app on the web to extract the corresponding LUA file (it's something like "herotable.lua" if I remember correctly)

I have found most of the skin keywords based on my own save file; I don't have the skins from some special events...
Here's the list of keywords per champ

hogan: lunar
fee: dryad, champ
obsidian: champ
masamune: champ,
lancelot: winter17, champ
bolton: champ, (missing keyword for elemental)
smoulder: winter17, champ
connie: champ
efrigid: winter18, champ
helios: paper, winter17, champ
sethos: champ
mabyn: champ
yan: champ, winter17
narlax: champ
leif: (missing keyword for azura event)
caldera: winter18
azura: lunar
raida: none

I'm not familiar with Go, so I can't (yet) add a patch for skin selection. Maybe i'll study basic control flow instructions to have the patch...

I have found most of the skin keywords based on my own save file; I don't have the skins from some special events...
Here's the list of keywords per champ

hogan: lunar
fee: dryad, champ
obsidian: champ
masamune: champ,
lancelot: winter17, champ
bolton: champ, (missing keyword for elemental)
smoulder: winter17, champ
connie: champ
efrigid: winter18, champ
helios: paper, winter17, champ
sethos: champ
mabyn: champ
yan: champ, winter17
narlax: champ
leif: (missing keyword for azura event)
caldera: winter18
azura: lunar
raida: none

I'm not familiar with Go, so I can't (yet) add a patch for skin selection. Maybe i'll study basic control flow instructions to have the patch...

I just thought, we can also add a command for unlocking skins...


Tracking repeat visits.

What are your recommendations for tracking repeat visits with common-web?

+1 this seems like something Common-Web should take care of.
It's pretty simple to drop in a unique tracking cookie.
Perhaps the interface would just be:
CommonWeb.trackSession()

That would get/set the GUID, and then update an internal global property for all events.

+1
That'd be really great


Error in group_by(): ! Must group by variables found in .data. ✖ Column cell_type is not found.

libra_result = run_de(expr, meta = meta,
     replicate_col = "orig.ident",
     cell_type_col = "cell_type",
     label_col = "seurat_clusters",
     de_family = 'pseudobulk',
     de_method = 'edgeR',
     de_type = 'LRT',
     min_cells = 3,
     min_reps = 2,
     input_type = "scRNA",
     n_threads = 2
     )

[1] "Macrophage"
Error in group_by():
! Must group by variables found in .data.
✖ Column cell_type is not found.
Run rlang::last_trace() to see where the error occurred.
rlang::last_trace()
<error/rlang_error>
Error in group_by():
! Must group by variables found in .data.
✖ Column cell_type is not found.
Backtrace:
▆
├─Libra::run_de(...)
│ └─... %>% ...
├─dplyr::rename(...)
├─dplyr::arrange(., cell_type, gene)
├─dplyr::ungroup(.)
├─dplyr::select(...)
├─dplyr::left_join(., out_stats, by = "gene")
├─dplyr::select(., -avg_logFC)
├─dplyr::mutate(., gene = as.character(gene))
├─dplyr::mutate(., p_val_adj = p.adjust(p_val, method = "BH"))
├─dplyr::group_by(., cell_type)
└─dplyr:::group_by.data.frame(., cell_type)
Run rlang::last_trace(drop = FALSE) to see 2 hidden frames.
rlang::last_trace(drop = FALSE)
<error/rlang_error>
Error in group_by():
! Must group by variables found in .data.
✖ Column cell_type is not found.
Backtrace:
▆
├─Libra::run_de(...)
│ └─... %>% ...
├─dplyr::rename(...)
├─dplyr::arrange(., cell_type, gene)
├─dplyr::ungroup(.)
├─dplyr::select(...)
├─dplyr::left_join(., out_stats, by = "gene")
├─dplyr::select(., -avg_logFC)
├─dplyr::mutate(., gene = as.character(gene))
├─dplyr::mutate(., p_val_adj = p.adjust(p_val, method = "BH"))
├─dplyr::group_by(., cell_type)
└─dplyr:::group_by.data.frame(., cell_type)
└─dplyr::group_by_prepare(.data, ..., .add = .add, error_call = current_env())
└─rlang::abort(bullets, call = error_call)
This error made me headache. My meta is good, the colname is correct. I wonder why it can't work. It seems that my colname "cell_type" in the meta can't be identified correctly. Please help me to fix it, thanks!

Anybody met that error? I have checked my data for many times, nothing was wrong. I guess if it's because the issue of the code. Please help me to fix it. Thanks!

when I used this code: meta$cell_type <- as.factor(meta$cell_type), it works!!!!! However, it may make sure that something wrong in the code. Maybe cell_type is incorrectly identified as grouping factor but label_col?


fix(is_enabled): disable whichkey in cmdline-window

IMHO we can disable whichkey since cmdline-window is restricted.

Thanks!


[$500] Flag - Flag message for flagged parent message disappears when reopening thread

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.23-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR https://github.com/Expensify/App/pull/33676ithub.com/Expensify/App/
Action Performed:

[User A] Send a message to User B
[User B] Open the message in thread
[User B] Send a reply in thread
[User B] Flag the message as Intimidation
[User B] Return to main chat
[User B] Reopen the thread
Note that

Expected Result:
The flag message for the flagged parent message does not disappear
Actual Result:
The flag message for the flagged parent message disappears
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/5ac15151-36d1-4d4c-b450-399b0cdb0d51
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ea3ffb8d539f6e86
Upwork Job ID:<PHONE_NUMBER>135650304
Last Price Increase: 2024-01-16
Automatic offers:

situchan | Contributor | 28104518

Proposal
Please re-state the problem that we are trying to solve in this issue
Flag - Flag message for flagged parent message disappears when reopening thread
What is the root cause of that problem?
This is due to wrong fallback to report.reportID in Onyx subscription in FlagCommentPage component.
What changes do you think we should make in order to solve the problem?
Remove the fallback
parentReportActions: {
            key: ({report}) => `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.parentReportID}`,
            canEvict: false,
        },

I think this is backend issue

Proposal
Please re-state the problem that we are trying to solve in this issue.
Flag - Flag message for flagged parent message disappears when reopening thread
What is the root cause of that problem?
I think this is backend issue.
But we can fix on here easilly.
What changes do you think we should make in order to solve the problem?
const latestDecision = lodashGet(props, ['action', 'message', 0, 'moderationDecision', 'decision'], '') || lodashGet(props, ['action', 'originalMessage', 'moderationDecision', 'decision'], '');

What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue
The flag message for the flagged parent message disappears when reopening thread.
What is the root cause of that problem?
https://github.com/Expensify/App/blob/35a6916095300af9dbfb593156470de9952a0b28/src/pages/home/report/ReportActionItem.js#L232-L234
In the line above, we're looking for the decision within action.message[0] but when re-fetching OpenReport the BE doesn't pass the decision in message like it does when first calling the flagging endpoint.
What changes do you think we should make in order to solve the problem?
As fallback to the latestDecision from action.message[0] we should add latestDecisionOriginal which we get from the originalMessage object instead of action.message[0] where its missing.
POC looks something like this:
+   const latestDecisionOriginal = lodashGet(props, ['action', 'originalMessage', 0, 'moderationDecision', 'decision'], '');
    const latestDecision = lodashGet(
            props, ['action', 'message', 'moderationDecision', 'decision'],
+           latestDecisionOriginal
    );

@tylerkaraszewski do you agree that this is a backend issue but this fix would do the trick?  https://github.com/Expensify/App/issues/34151#issuecomment-1883554095

I don't think this is going to be resolved with the other GH, unfortunately - it's just posing some issues with testing haha. Hopefully we can solve this internally!

Haha yes.
@tylerkaraszewski @dangrous one of you please check internally?

@dangrous - what do you think we should do with this issue?

I think we're probably deprioritizing moderation bugs? It's not currently covered by a wave, as far as I know. Can you think of one where it might fit? I can add this to a list I have of moderation bugs so we can come back to it at some point

Btw please keep me assigned here in case frontend fix is needed

Works for me @dangrous !  I'll assign @situchan so if this is opened again that will still be the assignment and close for now.

Issue is reproduced on build <IP_ADDRESS> when executing PR https://github.com/Expensify/App/pull/28002
https://github.com/Expensify/App/assets/93399543/9c28d048-5885-4c31-b896-1604a851a2cc