feature request: add cluster intialization status to admin /init_dump

We can now query the active cluster and warm cluster to know what clusters are able to use.
It's adequate to explain why a request is "NR 503", but it's still hard to troubleshooting why a cluster stays warming up.
We can expose the per cluster init::manager to cluster manager and query init manager's unready target.
The followings are need to be resolved.

The cluster ready details query should be exposed to admin interface /init_dump
Not all the blocking items are under the frame of init::manager. If each of the blocking item attaches to a init::target with a meaningful name, the init status can be as simple as listing all the unready target names. ~The current cluster initialization does not end with init::manager announce "ready".~

Thoughts?

I agree this would be very useful. I would propose some kind of /init_status endpoint which gives details on the init process?

We have /init_dump. Is it the /init_status you are referring to?

Sure if we have an existing endpoint we can use it.

Rephrased my proposal:
Attach each async initialization to a named target.
Independently expose the per warming cluster init::manager to the existing init_dump


Do Not Merge: Adding Gamepad to support controllers in both mobile and desktop modes

Support for gamepads. Not merging yet because I want to test this better on mobile, but I need a PR since I cannot test the controller while the phone is connect to the laptop. You can still review it though.
Preview here: https://pr-427.lba2remake.net

You may want to try enabling controlsState.relativeToCam, it will probably feel more natural with a gamepad. I use this for VR.
Although it would require switching it on/off dynamically wether we used the keyboard or gamepad.

Ok, will have a look to that one.
The gamepad fills a bit off and for some reasons when trying to test on mobile is not working, but locally works fine.

@slwilliams @agrande can you have another look to the PR?
I've added loads of changes since the first version but everything should be there now except the Inventory navigation that can be added when Scott finishes the inventory piece.
There is one annoying bug though. I need to look further.
The left stick X axis, when the value is very very low, close to zero, but still positive, it acts as Negative.

Lgtm, but I want to check it after I finish implementing what I'm doing on VR selector screen.

Merged with master for the VR selection fixes


Disallow empty measurement keys and fix tests using empty keys

Part of #4040

@95-martin-orion

Discussed offline - this may not be necessary if we choose to auto-convert keyless gates into qubit-named gates. Holding off on merge until @smitsanghavi confirms his decision.

ping @95-martin-orion @smitsanghavi is this to be closed or pushed forward?

Closing this as we had opted for a different solution (auto-convert "keyless" gates to qubit-based naming). If we need to revisit this (or decide that this PR was the correct choice) we can reopen this PR.

Reviving this since we decided to revert the qubit based auto-naming.


MWPW-163260-Remove tooltip from Upload button

Remove default tooltip from Upload button that comes with file upload input element

Resolves: MWPW-163260
Test URLs:
Before: https://stage--cc--adobecom.hlx.page/fr/products/photoshop/ai?unitylibs=stage&georouting=off
After: https://stage--cc--adobecom.hlx.page/fr/products/photoshop/ai?unitylibs=upload-tooltip&georouting=off

now tool tip has been removed from upload CTA in locales.


Fix 'fullTitle() is not a function' in exit.js

To reproduce create a test suite with beforeAll or beforeEach hooks. Then
run the tests without previously starting selenium/phantomjs. You should see the above error message which is also misleading since the actual error is
 [1] Error | Error: Couldn't connect to selenium server

Thanks, looks good to me.


Accuracy Function For Speeding Up LSTM+CTC Convergence

When processing Sequence Tagging problems, an accuracy func which is too strict is not convergence-friendly. This accuracy function is from the solution of a basic leetcode problem LCS (Largest Common Subsequence). Original All-Correct-Or-Nothing accuracy function may takes 7x times (or more) long to achieve certain accuracy.

It seems that this PR is irrelevant to Travis-CI build failure on R_test.
Please check.

@xlvector How about make this the default?

Yes, LCS is better. @catalystfrank what about training speed. Sometimes, I find eval function is cost of time. Can you tell me the samples/second before/after using this evaluate metric?

At the end of 1st epoch, log shows
2017-02-04 08:49:46,279 Epoch[0] Batch [9700]	Speed: 1563.85 samples/sec	Train-Accuracy_LCS=0.903240
2017-02-04 08:49:52,687 Epoch[0] Batch [9800]	Speed: 1560.48 samples/sec	Train-Accuracy_LCS=0.905164
2017-02-04 08:49:59,106 Epoch[0] Batch [9900]	Speed: 1558.01 samples/sec	Train-Accuracy_LCS=0.903228
2017-02-04 08:50:05,719 Epoch[0] Batch [10000]	Speed: 1512.11 samples/sec	Train-Accuracy_LCS=0.904909
This example contains some training data of 5-20 char long images, ( @30*300 resolution ) , using hyperparams : Hidden=256~512, Layer=2~3, Batch Size = 64~100, and Learning Rate = 0.0005~0.005.
The original accuracy must be too strict to train the model (if 1 out of 20 char is not correctly predicted,  then the correct part is wasted).
At this morning, this 10-epoch run finally reported a proximately 96.7% accuracy.
2017-02-04 10:46:11,495 Epoch[9] Batch [9600]	Speed: 1544.09 samples/sec	Train-Accuracy_LCS=0.967721
2017-02-04 10:46:17,891 Epoch[9] Batch [9700]	Speed: 1563.57 samples/sec	Train-Accuracy_LCS=0.967243
2017-02-04 10:46:24,317 Epoch[9] Batch [9800]	Speed: 1556.13 samples/sec	Train-Accuracy_LCS=0.968336
2017-02-04 10:46:30,709 Epoch[9] Batch [9900]	Speed: 1564.66 samples/sec	Train-Accuracy_LCS=0.966759
2017-02-04 10:46:37,104 Epoch[9] Batch [10000]	Speed: 1563.60 samples/sec	Train-Accuracy_LCS=0.968629
2017-02-04 10:46:43,535 Epoch[9] Batch [10100]	Speed: 1555.05 samples/sec	Train-Accuracy_LCS=0.967586
Usually a captcha is no longer than 6, a former fixed length run shows that it can achieve 99.1% LCS Accuracy (which means a 94.6% Original Accuracy is ensured).

LGTM, @catalystfrank thanks.

@catalystfrank Can you list your device? I use one gtx1060, can only got about Speed: 306.80 samples/sec.your speed is very very faster

CUDA7.5+CuDNNv5.1+gcc4.8.5+OpenCV<IP_ADDRESS>+M40(12GB).
@fanlu please move the captcha and image resizing code out of Data Iteration steps. This web I/O latency may be the main bottleneck in your example ( 1060 has almost half single precision TFLOPs of M40).
I've also tried to preload all images into host memory to get faster host-to-device data preparation, however this change doens't help too much , since MXNet has its own data preloading mechanism.

@catalystfrank I first produced the picture and then training, the speed will indeed improve, but many small files, io certainly is a problem, Have you tried im2rec？

@fanlu if you can np.float16() your img data and load them into host memory, it might be faster. Another trick is using Solid State Disk(SSD) to store img files. MXNet Im2Rec tool is not used in my approaches.


Remove hard dependency on electron-prebuilt

This means packager will also use electron version specified in electron-version field in package.json
This is good because we don't have to depend on electron-prebuilt. prebuilt automatically downloads
electron for the current platform, but packager might only be building for a different platform, and will use
electron-download anyway, so we can avoid unnecessary download, and speed up npm install time.

@mcfedr What do you use during development? Or you just not specify electron-prebuilt dependency but install it manually?
As far I understand, --production flag is not a solution because we need to install babel/compiler/etc.
I think, we should not reinvent the wheel and introduce new non-standard field in package.json. Instead, we should use config.
"config": {
    "electron-version": "",
  },

Config works for me, ill change it now.
I current specify electron-prebuilt because it doesn't work without it, but I want to avoid it downloading when I do npm install, for example, my tests are run and fail, I didnt get to the electron stage, and saved all that time downloading

I didnt get to the electron stage, and saved all that time downloading

I don't think that it worth.

electron don't want to distribute using normal compression — https://github.com/electron/electron/issues/5455 Well, because in the modern world 50 vs 25 mb means nothing.
Travis supports cache on OS X now, so, just configure cache. https://github.com/electron-userland/electron-builder/blob/master/.travis.yml#L22 Or circleci — https://github.com/develar/electron-builder/blob/builder/circle.yml#L7

So, nothing to save. It is downloaded only once. It is not unreliable and slow npm, it is downloaded quickly :)

The other example is I am wanting to deploy my web app version of the code, that completely doesn't require electron.

Either way, this surely does no harm :)
Also right now, electron-prebuilt hasnt been updated to 1.1.1, put using this, it would be downloaded and everything would work...

I'm not opposed to adding this feature in principle. Per the contributing document, it needs tests and documentation. In fact, I think the change broke at least one existing test.
On the other hand, I'm a bit hesitant because I think the documentation for specifying the Electron version is going to get fairly complicated.

@develar @malept I'm trying to use the config solution and have added
"config": {
    "electron-version": "1.2.1"
  },

in my package.json. However, I'm unsure as to where I would use this config option. Do I add something after the npm script (the one that's build -o or -w or -l)? Or do I pass it into build.osx as a variable of sorts?

@mzmousa If you use electron-builder please use build.electronVersion — https://github.com/electron-userland/electron-builder/pull/418#issuecomment-221798404
If I understand correctly, @mcfedr created PR here by mistake, because electron-builder in any case use electron-builder in a way that prevent any such configuration.

If this PR is no longer wanted by the submitter, that would be good to know.

@develar Its not a mistake here, i think the feature makes sense for both projects, builder and packager.
And it would have been nice to have the same way of doing it for both, via config.electron-version, although now electron-builder has released build.electronVersion
Unfortunately I haven't had time to update this pull request with the needed tests and docs changes.

Ah, I should have just looked at the contributing document(s). Works fine for me, thanks!

@mcfedr electron-builder forbids most of the electron-packager options to avoid misconfiguration. https://github.com/electron-userland/electron-packager/blob/master/docs/api.md#version is forbidden as well (yes — you will get build error).
electron-packager currently doesn't support configuration via package.json. If you want to set electron version — you have to use CLI param version or programmatic API.

i think the feature makes sense for both projects, builder and packager.

My previous suggestion is wrong — config is not suitable here because there is an obvious question — why I can specify electron version using package.json, but other options only using CLI?
And so, another question is — should electron-packager introduce build as electron-builder does?
I have no answers. For me electron-packager is a low-level tool and electron-builder is a orchestration tool. And in any case, even if electron-packager maintainers decided to introduce build, electron-builder in any case will not support all options — but forbid it (e.g. arch).

I seriously doubt that electron-packager is going to support a top-level build key to package.json (@develar even linked to the reason why above). However, I would not be opposed to a discussion about adding a sub-key to config (e.g., config.electronPackager) which basically looks like the parameters for packager(). It would be wise to discuss that option before this PR gets merged.

you do not need electron-prebuilt as a dependency all you have to do is specify a version in the --version param
example:
electron-packager "./" "My App" --platform=win32 --arch=x64 --version=1.2.5

Since there are outstanding problems with this pull request, and the original submitter has stated that they don't have time to work on it, I'm going to close this for now.


[Release 1v1 [RANK] Melting Snow ZH v3] Cars are usable

Cars top middle and bottom left

2 Cars removed. Map see https://www.gamereplays.org/community/index.php?showtopic=1048527.

[RANK] Melting Snow ZH v4 has been added. Check if all cars are removed.

Fixed in [RANK] Melting Snow ZH v4


more clean target for make clean

add commands to clean build for examples/enclave_manager and common/sgx_workload
Signed-off-by: Sammy<EMAIL_ADDRESS>

Please update your commit with signed-off field. Jenkins jobs are failing due to missing field.

The signed-off field has always been along, as in my case is Signed-off-by: Sammy<EMAIL_ADDRESS>showed by git log.
Would you mind helping me to figure out why?


Unexpected behavior

Environment
Code Version: git commit id ff5abfd9938c78cd75c6c5d6a41565097128c5d3
Hardware Architecture: x86_64
Operating system: Ubuntu 20.04
reply_570_2_unexpected_execution.zip
command
target/release/wasmtime --invoke to_test reply_wasmi_570_2/replay_570_2_unexpected_execution.wasm

Expected behavior:
An exception indicating that "alignment must not be larger than natural"
Current behavior:
Output: 1

Steps to generate this test case
570_2.zip

Thanks for the report, but this is a somewhat benign issue. The problem I think you're running into here is that the provided module is encoded as:
...
 0x44 | 37 40 00 44 | i64_store memarg:MemArg { align: 0, max_align: 3, offset: 68, memory: 0 }
...

where the i64.store is encoded with 0x37 0x40 0x00 0x44. Using an MVP decoder that decodes as an alignment of 0x40 and an offset of 0x00 which is indeed, as you've pointed out, an error as "alignment must not be larger than natural". The wasmparser crate which Wasmtime uses, however, implements the multi-memory proposal which reinterprets the binary encoding of a memarg where 0x40 means "alignment is 1 and the next byte is memory" which causes wasmparser to decode to the above structure, which is indeed valid (under the multi-memory proposal).
This more-or-less a bug in wasmparser's binary decoding and/or validation. Right now features are not checked/verified at the binary decoding layer, only at the AST structural layer, meaning that this binary encoding is not properly gated or conditionalized behind the multi_memory proposal at this time.
Would you be interested in helping to fix this?

Thanks for the report, but this is a somewhat benign issue. The problem I think you're running into here is that the provided module is encoded as:
...
 0x44 | 37 40 00 44 | i64_store memarg:MemArg { align: 0, max_align: 3, offset: 68, memory: 0 }
...

where the i64.store is encoded with 0x37 0x40 0x00 0x44. Using an MVP decoder that decodes as an alignment of 0x40 and an offset of 0x00 which is indeed, as you've pointed out, an error as "alignment must not be larger than natural". The wasmparser crate which Wasmtime uses, however, implements the multi-memory proposal which reinterprets the binary encoding of a memarg where 0x40 means "alignment is 1 and the next byte is memory" which causes wasmparser to decode to the above structure, which is indeed valid (under the multi-memory proposal).
This more-or-less a bug in wasmparser's binary decoding and/or validation. Right now features are not checked/verified at the binary decoding layer, only at the AST structural layer, meaning that this binary encoding is not properly gated or conditionalized behind the multi_memory proposal at this time.
Would you be interested in helping to fix this?

Thank you for your nice reply! I'll be happy to fix this after I finish my current work.

@alexcrichton has this been fixed already with BinaryReader including WasmFeatures now since some versions of wasmparser? https://docs.rs/wasmparser/0.218.0/wasmparser/struct.BinaryReader.html#method.new_features

Good point! This now reports:
$ wasmtime run -W multi-memory=n reply_570_2_unexpected_execution.wasm
Error: WebAssembly translation error

Caused by:
    Invalid input WebAssembly code at offset 69: malformed memop alignment: alignment too large

which I believe is the correct error here. Specifically this module is valid-by-default due to the multi-memory proposal, but it's invalid if the multi-memory proposal is disabled.


refactor: improve error message during weval pull failure

Hey all, did a little bit of refactoring to get a slightly better (I think!) error message in for when weval has to be fetched.

Thanks Victor for investigating this - this has been an ongoing issue for Weval when GitHub decides to ratelimit API requests.

Yeahhh I figured it was something like that -- it turns out most of the changes could go in one level up @ componetize-js but while I was there I figured I'd improve the error message! The other PRs @ componetize-js and jco are more important :)

I think the better fix that would be preferable would to be use token authentication with the GitHub API. The problem is that the fetch here doesn't respect the Authorization header per https://docs.github.com/en/rest/authentication/authenticating-to-the-rest-api?apiVersion=2022-11-28, per a env.GITHUB_TOKEN environment variable.
If that was supported then we could run the CI with this environment variable set to the secret of the same name in GitHub CI without hitting the ratelimiting issues.
@vados-cosmonic I do think an upstream fix in Weval like the above is preferable to a downstream workaround.

It sounds like that could work well too.

Thanks for the notes ya'll -- I agree, both of those solutions would be preferable -- I'll try and do both!
I think the average person won't actually have GITHUB_TOKEN set, but that definitely helps fix the CI issues (in a slightly spooky-at-a-distance way), and also using the actual URL of the release is much better. In other projects we certainly use the direct URLs (but who's to say someday those won't be rate-limited as well!)


Missing pressure and delta_t

pressure and delta_t are not available from the new API - they can only be retrieved from FTP.

pressure isn't available for many FTP sites either. I believe its only obs stations that are at an airport.

That's a shame. Pressure would be handy for me... P.S Great work. Thank you.

This is in the pipeline, i want to add "opt in" pressure and delta_t sensors using FTP. Expect it in 3-4 weeks.

Any chance of a dew point sensor too?
That was available on the old scraper integration and I use it (along with min forecast temp) to predict frost.

If BoM start providing pressure data through this API, I will add it into the integration, otherwise we miss out on pressure data  here.


Make cpu offloading the default when sequential is enabled

This makes cpu offloading the default when sequential is enabled, in order to fix #87

Makes sense, thank you for the commit


Fix separator is not defined

There is an assignment in the extractMatches  function call that should not be there.

This threw locally before, but now no longer does … closing.


Added the Ability to call an Api

I am confused is this like not a thing anymroe? Am i missing something to get this working?

Hey @kdp88!
It is definitely still a thing :)
import { CallAnApi, LastResponse, Post } from '@serenity-js/rest';
import { Actor } from '@serenity-js/core';

const Bob = Actor.named('Bob').whoCan(CallAnApi.at('https://yourdomain.com/api'));

Bob.attemptsTo(
  Post.item({ name: 'iPod' }).on('/basket'),
  See.if(LastResponse(), res => expect(res.status).to.eventually.equal(200)),
);

Hey @jan-molak
thanks for the reply, I feel like I am doing something worng I attached a screenshot, do i have to add @serenity-js/rest to my package.json?


Restore-DbaDatabase with STOPAT ($RestoreTime) picks up incorrect set of files for Restores

Steps to Reproduce
Hypothetical backup setup:

Every Saturday - 5 PM: Full backups
Sunday - Friday - 5 PM: Differential backups
Every 10 minutes - Transaction log backups

Sample dates and time of restores:
6/2 - 5 PM Full backups (doesn't matter when it completes)
6/3 - 5 PM Differential backups (completes at 5:10 PM)
$RestoreTime (STOPAT) parameter set to 5:05 PM ('2018-06-03 17:05')
Restore-DbaDatabase -SqlInstance $RestoreTarget `
					-DatabaseName $database `
					-Path "\\$Source\$database" `
					-DestinationDataDirectory $DataDir `
					-DestinationLogDirectory $LogDir `
					-RestoreTime $RestoreTime `
					-MaintenanceSolutionBackup `
					-WithReplace `
					-AllowContinue `
					-OutputScriptOnly | Out-File -FilePath $FilePath

Expected Behavior
Restore full backups from 6/2, then all corresponding log backups until 6/3 5:05 PM
Actual Behavior
Restores full backups from 6/2, differentials from 6/3, and one transaction log after 5 PM ( until STOPAT 5:05 PM). The problem is the differential goes way beyond the restore point (because the backup completed at 5:10 PM and STOPAT within differential means nothing), then it tries to restore a previous log backup. This results in the error:
Microsoft.SqlServer.Management.Smo.SmoException: System.Data.SqlClient.SqlError: The specified STOPAT time is too early. All or part of the database is already rolled forward beyond that point
Environmental data

PowerShell:

Name                           Value
----                           -----
PSVersion                      5.1.14409.1012
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14409.1012
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

SQL Server:

 Microsoft SQL Server 2014 (SP2-CU11) (KB4077063) - 12.0.5579.0 (X64)
	Feb 21 2018 12:19:47
	Copyright (c) Microsoft Corporation
	Enterprise Edition: Core-based Licensing (64-bit) on Windows NT 6.3 <X64> (Build 9600: ) (Hypervisor)

Have same behavior, will take look at it closer...

Changed line 138 in Select-DbaBackupInformation (and deleted allcommands.ps1)

Working in right way now. Can't make PR atm.

Hey Oleg, Thanks for the quick response. I really appreciate it. I haven't gotten a chance to test it out yet. I will try the workaround sometime next week.
Thanks again.

technically what @Zhunya proposes is fine.
To allow a restore to a point in time, the last log is the one where start is greater than the point in time and end is lower than the point in time.
For the diff instead, since PITR with a diff is impossible, it should be selected the one that ends BEFORE the reference time, so additional log can be properly put in place to allow the PITR.
@amon09 : if you report it to work, we'll issue a relevant PR to fix the issue

@Zhunya @niphlod I did a quick check it does work as expected now.
Thanks a bunch for fixing this.


Metadata v12/refCount size change + misc fixes, improvements

Intro
This PR adds support for newer versions of Polkadot and introduces several improvements and fixes.
Changes
Support for Metadata v12 and refcount size change
In Polkadot v0.8.25 (https://github.com/paritytech/polkadot/releases/tag/v0.8.25), the metadata was updated to v12 (to include a new index field for modules) and the refcount field of AccountInfo was extended from 8 to 32 bits.
Commits:

https://github.com/blockchain/polkaj/commit/0ef40aa7b519a58b5baf2130bafddc68430d4e81
https://github.com/blockchain/polkaj/commit/1ca8dec411e25ed9fcecdd79e98a314704a0c7da

References:

https://github.com/paritytech/substrate/pull/6969
https://github.com/paritytech/substrate/pull/7164

Related issues:

https://github.com/emeraldpay/polkaj/issues/29
https://github.com/emeraldpay/polkaj/issues/30
https://github.com/emeraldpay/polkaj/issues/39

Fixes
CompactBigIntWriter fix
The following commit fixes the serialization of CompactBigInts when the MSB is > 127, and the resulting byte array starts with an extra 0x00 (to signal it's a positive value):

https://github.com/blockchain/polkaj/commit/74500e94e189be5f2ff40aedd10f1762b5343f04

Related issues:

https://github.com/emeraldpay/polkaj/issues/32

Mortal era encoding fix
The following commit fixes the serialization of Mortal eras on both the signature payload and the transaction info of the extrinsic:

https://github.com/blockchain/polkaj/commit/ed3d0b58c68168a76892f01d12e236eb9e8067a6

Additionally, it extends the ExtrinsicContext.Builder class to allow setting the era and eraBlockHash fields.
Improvements
The PR also extends the PolkadotHttpApi constructor and builder to accept a timeout parameter, and extends the RpcException class to include the data field from JSON error responses.
Commits:

https://github.com/blockchain/polkaj/commit/3b7eadc20363342373f84ed4e7d30bf99ab7cb90
https://github.com/blockchain/polkaj/commit/4db9ecb55f241a2226d193cd3cac09794d77ae82

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #41 (4db9ecb) into master (32df6c0) will increase coverage by 0.27%.
The diff coverage is 94.11%.

@@             Coverage Diff              @@
##             master      #41      +/-   ##
============================================
+ Coverage     86.53%   86.80%   +0.27%
- Complexity      872      887      +15
============================================
  Files           111      113       +2
  Lines          2903     2949      +46
  Branches        423      429       +6
============================================
+ Hits           2512     2560      +48
  Misses          278      278
+ Partials        113      111       -2

Impacted Files
Coverage Δ
Complexity Δ

...a/io/emeraldpay/polkaj/scaletypes/AccountInfo.java
100.00% <ø> (ø)
14.00 <0.00> (ø)

...ava/io/emeraldpay/polkaj/api/RpcResponseError.java
58.82% <50.00%> (+1.68%)
5.00 <2.00> (+1.00)

...o/emeraldpay/polkaj/scaletypes/MetadataReader.java
97.97% <66.66%> (-0.03%)
6.00 <0.00> (ø)

.../io/emeraldpay/polkaj/api/AbstractPolkadotApi.java
100.00% <100.00%> (ø)
8.00 <0.00> (ø)

...in/java/io/emeraldpay/polkaj/api/RpcException.java
100.00% <100.00%> (ø)
8.00 <6.00> (+4.00)

.../io/emeraldpay/polkaj/apihttp/PolkadotHttpApi.java
69.87% <100.00%> (+1.52%)
10.00 <0.00> (ø)

...ava/io/emeraldpay/polkaj/apiws/DecodeResponse.java
77.39% <100.00%> (+0.60%)
27.00 <0.00> (+1.00)

...java/io/emeraldpay/polkaj/apiws/PolkadotWsApi.java
74.07% <100.00%> (ø)
17.00 <0.00> (ø)

...meraldpay/polkaj/scaletypes/AccountInfoReader.java
100.00% <100.00%> (ø)
2.00 <0.00> (ø)

.../emeraldpay/polkaj/scaletypes/ExtrinsicReader.java
83.87% <100.00%> (ø)
2.00 <0.00> (ø)

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32df6c0...4db9ecb. Read the comment docs.

@pablojorge thank you very much for the PR, it fixes few very critical issues. I've checked the commit, everything is good.
The only thing I would comment on is having the Era codec as method in Scale Reader/Writer. I prefer to use the main scale class to provide methods only for basic and common types, and use a generic method (write(ScaleWriter<T> writer, T value)) for other types. I mean that's fine right now, not critical at all, and I'm going to merge your changes as is. Just saying that if you are planing to implement other codecs.

Sure! We're glad to contribute!
Regarding the Era codec, yes, maybe adding the methods wasn't really necessary, will have in mind that if we add more

can you give all of the projects jar or the download url

Hey guys, where is the metadata found? I can get support for new metadata version (13)


FTP PUT seems to randomly exit the program

I've been getting random upload failures and I can't figure out why.
You can run the repro and it will upload 10 files but it almost always fails somewhere without an error. I can't figure out what's going on. I tried it with multiple FTP servers.
There's no error and I can't even retry the operation since it seems that the node process just exits for some unknown reason.
Maybe someone can reproduce this? I also tried it with this public FTP server and getting the same failures.
Using Node v8.15.0
Repro: https://github.com/Christilut/promise-ftp-bug
Just npm install and add FTP server credentials in the code and run it: node index.js.

I switched to basic-ftp which seems to work reliably.


Update client3:circe, client3:core, ... to 3.8.3

Updates

com.softwaremill.sttp.client3:circe
com.softwaremill.sttp.client3:core
com.softwaremill.sttp.client3:json4s
com.softwaremill.sttp.client3:slf4j-backend
com.softwaremill.sttp.client3:spray-json

from 3.8.0 to 3.8.3.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.softwaremill.sttp.client3" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "com.softwaremill.sttp.client3" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #221.


Docs.MS Release Updates for Azure.Messaging.EventHubs.Processor

Docs.MS Release Updates for Azure.Messaging.EventHubs.Processor

Docs Build status updates of commit 3e1358c:
:clock10: Pending: waiting for processors (9 builds ahead of you)
:warning: Docs Build is busy, currently there are 9 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 3e1358c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/overview/azure/messaging.eventhubs.processor-readme-pre.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


mempool accepts doublespending txs

tx checks in mempool accept are incomplete resulting in tx's trying to spend the same inputs twice.
these txs are included in blocktemplate leading to invalid blockdata
mota-blocktemplate.txt
using such template for mining fails always with error like this:
ERROR: FetchInputs() : 7ec8dfd7c9 prev tx 5fb7442799 index entry not found
ERROR: AcceptBlock(): Block 704726 contains at least two transactions that uses
the same coin.

We discussed this case in a team meeting and I pushed a update to fix this case. Take some time before its will be tested and release.


How to override SSDT tables

Is it possible to only override the SSDT table in windows? If I modify and compile SSDT file and place it into system32 folder with name “acpitabl.dat”, system doesn’t accept this. Whereas Linux supports SSDT override.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 16299ebf-80ed-f09f-d0c0-4cda742f579e
Version Independent ID: 8e45d880-93f8-4c85-81e6-b1d5dbe78ab6
Content: Generate ACPI tables by using AcpiGenFx - Windows drivers
Content Source: windows-driver-docs-pr/bringup/generate-acpi-tables-by-using-acpigenfx.md
Product: windows-hardware
Technology: bringup
GitHub Login: @barrygolden
Microsoft Alias: bagold

@eshiva0, thanks for reaching out to the Windows Driver Developer Documentation team.
I would recommend posting your question about how to override SSDT tables in the following forums, where other driver developers and Microsoft engineers can be found.
Microsoft Q&A: Windows Hardware development
OSR Developer Community


FOP-2847: fix Mask for PNG with IndexColorModel and transparent color

PNG images with indexed color palette featuring tRNS transparency
encoding had potentially wrong PDF Mask. If image contained transparency
but no fully transparent pixel, then the default implementation of
PDFImageXObject still generates a Mask entry with three color components.
PDF Specification expects the index when using a palette based color
model. Thus Acrobat Reader does not process this image and shows
error message. In general ImageRenderedAdapter would overwrite this
Mask, but since
AbstractImageAdapter.getIndexOfFirstTransparentColorInPalette() does
return null if image does not contain fully transparent pixels the
more general implementation of PDFImageXObject leaks to the output.

superseded by
https://github.com/apache/fop/pull/55


VM runtime CG update for vertical scaling support

What is in this PR:
Initial implementation for VM CG update to support vertical scaling in VM. note that the vm config and domain change will be in a separated PR.
Why this PR is needed:
CG property update per the changes in the UpdataContainerResource() call, which is decided by the Arktos Agent.
Special note to CR:
VM domain def and Config update will be in separated PR
Arktos Agent change will be a PR to the Arktos repo
Testing done for this PR:
Ad hoc VM creation
Resize CPU:
root@ip-172-31-11-43:/# virsh dumpxml 1

virtlet-3a8bf096-e3a3-vm
3a8bf096-e3a3-5626-557a-ef78be7b6768
209715200
209715200
4

2048
100000
100000

root@ip-172-31-11-43:/# virsh setvcpus 1 3 --live --config
root@ip-172-31-11-43:/# virsh dumpxml 1

virtlet-3a8bf096-e3a3-vm
3a8bf096-e3a3-5626-557a-ef78be7b6768
209715200
209715200
4

2048
100000
100000

root@ip-172-31-11-43:/# virsh dominfo 1
Id:             1
Name:           virtlet-3a8bf096-e3a3-vm
UUID:           3a8bf096-e3a3-5626-557a-ef78be7b6768
OS Type:        hvm
State:          running
CPU(s):         3
CPU time:       47.1s
Max memory:     209715200 KiB
Used memory:    209715200 KiB
Persistent:     yes
Autostart:      disable
Managed save:   no
Security model: none
Security DOI:   0
issues in reducing CPUs:
root@ip-172-31-11-43:/# virsh setvcpus 1 2 --live --config
error: operation failed: vcpu unplug request timed out
root@ip-172-31-11-43:/#

Preliminarily tested with Vinay's private branch at the keblet side: https://github.com/vinaykul/arktos/tree/vm-vertical-scaling. Merge the PR for easier integration testing with Arktos.


qjackctl: 0.9.8 -> 0.9.9

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/qjackctl/versions.
meta.description for qjackctl is: A Qt application to control the JACK sound server daemon
meta.homepage for qjackctl is: https://github.com/rncbc/qjackctl
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.9.9 with grep in /nix/store/7mcsh5b1s7mjmvrv36a2fak656mxphfm-qjackctl-0.9.9
found 0.9.9 in filename of file in /nix/store/7mcsh5b1s7mjmvrv36a2fak656mxphfm-qjackctl-0.9.9

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
qjackctl

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/7mcsh5b1s7mjmvrv36a2fak656mxphfm-qjackctl-0.9.9 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A qjackctl https://github.com/r-ryantm/nixpkgs/archive/be6e63b2cfcd1ed3d9910c7eb4892017cbcafab0.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/7mcsh5b1s7mjmvrv36a2fak656mxphfm-qjackctl-0.9.9
ls -la /nix/store/7mcsh5b1s7mjmvrv36a2fak656mxphfm-qjackctl-0.9.9/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

qjackctl

Maintainer pings
cc @cillianderoiste for testing.

Result of nixpkgs-review pr 219125 run on aarch64-linux 1

1 package built:

qjackctl


KAFKA-2653: Kafka Streams Stateful API Design

This PR is only for the public interface and there is no real implementations yet (all marked as TODOs), the Jenkins job will expect to fail so do not worry about that. Ping @jkreps @nehanarkhede @junrao @gwenshap @miguno @ewencp @ijuma @ymatsuda for reviews.
A brief summary of the design:

We add a KWindowedTable as a third citizen in addition to KStream and KTable, which can be generated either from windowed stream-stream join or stream aggregations (which must be windowed as well). The main reasons for adding this interface are the following:

a. Windowed tables generated from a windowing definition cannot be directly written back to a Kafka topic: users have to decide either encode the window id into the key or value.
b. We want to support a specific left join for windowed tables that allow shifting windows when joining two windowed tables, e.g. comparing the current aggregate results with history windowed aggregates a week ago.
c. Stream to windowed-table join needs to be handled differently from stream to table join.

Admittedly adding this third class makes the whole DSL a bit too fat and cumbersome. So feedbacks and thoughts on tangling the above three issues in order to simplify the APIs are more than welcomed.

Operations that generates a KTable or KWindowedTable needs to specify a table name.

This is because for such operations we need to create a local state store with a Kafka change log, the table name will then be used as the change log topic name; this name cannot be auto-generated since topology changes may modify the ordering and hence mess up the change logs upon job restarts (we want to maintain such change logs across multiple runs so the topic names must be unique).

This might be another user burden, so better ideas are welcomed.

(Windowed) Aggregates on KStreams must be on the message key, while Aggregates on KTables will specify a KeySelector to select the aggregate key. We expect users to first use map() on KStreams to get the new key as the aggregate key if it was not before.

We define inner / outer / leftJoins, and restrict only a subset of them for KStream-KStream, KStream-KTable, KTable-KTable and KWindowedTable-KWindowedTable joins because we feel these are the most common join scenarios. Please let me know if you feel other join cases may also be common.

Also for KWindowedTable-KWindowedTable joins we requires the two tables' window definition to be the same, i.e. they must be the same window type (sliding, hopping, etc) that can be aligned (with same window boundaries).

Close this PR as it is already merged in another PR.


pub serve doesn't properly rebuild when the HTML of a Polymer element was changed

 Issue by zoechi
Originally opened as dart-lang/sdk#19038

What steps will reproduce the problem?
1.
I launch a Polymer app from DartEditor
2.
I modify and safe an HTML file of a Polymer element
DartEditor tools window writes
'Build completed successfully'
but when I reload or kill and launch the Polymer app these changes are ignored.
3.
I have to kill pub serve and launch the Polymer app to get these changes applied.
What is the expected output? What do you see instead?
Pub serve should properly rebuilt the app after changes (works for Dart, but not for Polymer HTML files)
What version of the product are you using? On what operating system?
Dart VM version: 1.5.0-edge.36672 (Tue May 27 06:16:24 2014) on "linux_x64"
Please provide any additional information below.

 Comment by zoechi

Sorry, all but a simple example
I'll see if I can come up with something simpler...
I had the issue in this project:
https://github.com/bwu-dart/bwu_datagrid/tree/04_model (branch 04_model)
I launch this file:
https://github.com/bwu-dart/bwu_datagrid/blob/04_model/example/e04_model.html
and modify this file:
https://github.com/bwu-dart/bwu_datagrid/blob/04_model/lib/components/bwu_column_picker/bwu_column_picker.html
I didn't have the issue somewhere else yet, but I also worked only on this project and only with this polymer-element since I upgraded to 1.5.0.
The pubspec.lock is included
https://github.com/bwu-dart/bwu_datagrid/blob/04_model/pubspec.lock
I added these dependency_overrides to see if it improves anything
dependency_overrides:
  analyzer: 0.15.5
  barback: 0.14.0+2
  quiver: 0.18.2

 Comment by anders-sandholm

Removed Priority-Unassigned label.
Added Priority-High, Area-Pub, Pub-Serve, Triaged labels.

 Comment by nex3

It looks like this is a barback bug.

Set owner to @nex3.
Removed Area-Pub, Pub-Serve labels.
Added Area-Pkg, Pkg-Barback, Started labels.

 Comment by nex3

Can you include a zip or tar file of a simple package that reproduces the issue, including the pubspec.lock?

Added NeedsInfo label.

 Comment by nex3

Fixed in dart-lang/sdk@ed667e542c61fb42feb26b29c162cef93a665052, to be released in Barback 0.14.1. Note that you'll need a version of pub with this barback compiled in to see the effects of the fix.

Added Fixed label.


when working with nested bundles, "imgpkg copy --lock-output" always returns digest for the "first" bundle, instead of bundle that was given in -b

What steps did you take:
imgpkg copy --lock staging.lock --to-repo ${TEST_REGISTRY}/imgpkg-debug-release --lock-output release.lock

assuming staging.lock points to a bundle that references nested bundles, release.lock (may) end up pointing to a nested bundle (instead of root bundle referenced by staging.lock) because writeLockOutput [1] picks last bundle that it finds within processed images.
[1] https://github.com/vmware-tanzu/carvel-imgpkg/blob/develop/pkg/imgpkg/cmd/copy.go#L160-L172

imgpkg version (use imgpkg --version): 0.6.0, 0.7.0

Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.

Moving this to carvel accepted

Reproduced using a script in public github repo: https://github.com/gcheadle-vmware/imgpkg-debug
which was adapted from: https://github.com/andrew-su/imgpkg-debug
however I found it easier to work with docker hub and the k8slt credentials.

After looking a little bit into this issue, for the above case looks like we can just expose the bundle that is being copied.
The harder case is going to be the copy from Tar and creating the BundleLock file. In this case, we do not save any special information about the bundle that was copied into the Tar so we cannot make a good judgment call on which one is the bundle.
We could augment our manifest.json that we store in the tar, further deviating from the OCI standard. Or we could store this information as part of a different file where imgpkg could store any information that is not part of the OCI manifest.json.

I started doing the implementation in the branch bundlelock-incorrect-sha for reference but it is missing the tar part

We could augment our manifest.json that we store in the tar, further deviating from the OCI standard. Or we could store this information as part of a different file where imgpkg could store any information that is not part of the OCI manifest.json.

manifest.json was never close to OCI standard anyway, so we should add it in there in my opinion.

We continued this conversation in slack in this thread
The TLDR is that we should consider having a field in the manifest.json for each image that will allow imgpkg to provide any additional metadata for a particular image. The idea is that imgpkg would set an annotation style field that can be read afterward that contains the information if a particular image is the bundle being copied or is an image that is part of a bundle.

for the tarball case:

Added a .Label attribute for each image  referenced in manifest.json
-- The implication is that: users will need to re-generate a tarball using a version of imgpkg that contains this fix in order to generate the correct lock file.

TODO:

test to make sure that a 'newer' version of imgpkg that generates a tarball (with the modified manifest.json) still works with an 'older' version of imgpkg. Reading the code I think it will fine.

Keeping this issue open, as some follow-up refactor commits to remove bundle information from the imagedesc package is still in progress. see https://github.com/vmware-tanzu/carvel-imgpkg/pull/189

refactor was merged few versions back.


unknown field "Filename' in struct literal of type proto.ExtensionDesc

When I try to compile this, I get the following error:
external/org_golang_google_genproto/googleapis/api/annotations/annotations.pb.go:41: unknown field 'Filename' in struct literal of type proto.ExtensionDesc

I'm using bazel. Building this because it is a dependency of github.com/grpc-ecosystem/grpc-gateway

@kgreenek The whole repo builds OK for me. proto.ExtensionDesc is defined here by this commit. Could you try updating github.com/golang/protobuf/proto package?

It was a problem on my end. Apologies, and thanks for the response


Add pipeline publishing section in docs

Add a new document section describing the publication of a pipeline package to PyPI.
Closes #267
Signed-off-by: Avishrant Sharma<EMAIL_ADDRESS>

FYI @tdruez


Allow for custom policy arrays based off Department

Is your feature request related to a problem? Please describe.
No problem, just an enhancement to SYM
Describe the solution you'd like
After selecting a department in the Welcome screen, allow for custom policy arrays based off what department was selected.
Example: Design dept would get Adobe Creative Cloud in addition to the standard array, where as HR would get Acrobat DC, PeopleSoft, etc
Describe alternatives you've considered
Looking into the suggestions noted here:
https://macadmins.slack.com/archives/C04FRRN3281/p1695644288174689?thread_ts=1695408114.558699&cid=C04FRRN3281
Additional context
SYM is great! This is just an enhancement request to the stellar product that is SYM.

This would require an additional dialog to pick a configuration as swiftDialog does not allow dynamic selection lists.

This might be the path of less resistance.
Rather than maintaining several department specific configs (Making the code huge), it might be easier to have an optional apps array as suggested below.
https://github.com/dan-snelson/Setup-Your-Mac/issues/64

Just a thought as a work around rather than a change to the script. If you curl your policy JSON from a web host, could you use the department variable as part of your URL (naming the file based on the department it applies to) so that it curls the appropriate JSON per department?

@kevinVodi:
After counseling with other sym-devs, I'm going to close this as "not planned."
As you mentioned in your original post, @drtaru offered one approach on Slack.


fix: remove SETTLE_TAKE_PAIR and update action discriminants

Removed the SETTLE_TAKE_PAIR action as it is no longer required and adjusted the discriminant values for existing actions accordingly. Updated the tests and parsers to reflect these changes.

@coderabbitai review


Move params C files into their own directory.

There are three param*.c files, move them into a common subdirectory.

[ ] documentation is added or updated
[ ] tests are added or updated

I have to ask, what are the implications of this move?
Historically, anything that lived in a crypto/ sub-directory was disablable (with a few exceptions that are hard-coded in Configure).  The files in crypto/ were not.  Since I've been around for quite a long time, that's still on my mind and obviously affects my choices.
So my thinking was that "core" things (at least new "core" things) would end up in crypto/.
Now, I don't mind this move...  the params API is and has always been optional, at least from a user perspective.  But I think we need to get to some kind of concensus what belongs where...

I suspect the optional part of the subdirectories was lost quite some time ago.  There are several algorithms that cannot be disabled (even though it would be nice to be able to do so).  To be honest, I hadn't realised that subdirectories were meant to be optional.
For me, this is a declutter.  The params source files were at the top level.  All good when params was one file, but now it's three.  Likewise, I started properties in a subdirectory because there were multiple files.

  I created a PR to do this, and the team didn't want an ad-hoc (sic) approach, but preferred to have something designed so I created #9331.
I suggest the team be consistent and not accept this PR until the discussion that the team earlier wanted to do happens.
I completely share Pauli's point about "crypto no longer implies not-optional"  I never thought of it as such.  I thought of it as a dumping ground.  I mean, LPvms_dir is kinda optional for most :)

Is it safe to assume that this PR is dead in the water?

Closing, a more general reorganisation is preferred.


Adding an executor which uses node to run commands and the database to keep track of them

Deals with #73

Codecov Report

Merging #76 (682d05a) into main (d5fd913) will decrease coverage by 0.70%.
The diff coverage is 51.05%.

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   59.08%   58.37%   -0.71%
==========================================
  Files          29       31       +2
  Lines        2026     2215     +189
==========================================
+ Hits         1197     1293      +96
- Misses        617      693      +76
- Partials      212      229      +17

Impacted Files
Coverage Δ

pkg/krok/providers/github/platform.go
27.43% <0.00%> (-1.01%)
:arrow_down:

pkg/krok/providers/livestore/repository_store.go
60.60% <ø> (-0.24%)
:arrow_down:

pkg/krok/providers/livestore/command_run_store.go
35.13% <35.13%> (ø)

pkg/krok/providers/handlers/krok_hook_handler.go
42.59% <40.00%> (-1.53%)
:arrow_down:

pkg/krok/providers/livestore/events_store.go
58.91% <58.91%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5fd913...682d05a. Read the comment docs.

Codecov Report

Merging #76 (2385755) into main (d5fd913) will increase coverage by 0.70%.
The diff coverage is 70.27%.

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   59.08%   59.78%   +0.70%
==========================================
  Files          29       31       +2
  Lines        2026     2233     +207
==========================================
+ Hits         1197     1335     +138
- Misses        617      678      +61
- Partials      212      220       +8

Impacted Files
Coverage Δ

pkg/krok/providers/livestore/repository_store.go
60.60% <ø> (-0.24%)
:arrow_down:

pkg/krok/providers/plugins/plugins.go
28.68% <ø> (-7.69%)
:arrow_down:

pkg/krok/providers/handlers/krok_hook_handler.go
42.59% <40.00%> (-1.53%)
:arrow_down:

pkg/krok/providers/livestore/events_store.go
70.54% <70.54%> (ø)

pkg/krok/providers/livestore/command_run_store.go
76.81% <76.81%> (ø)

pkg/krok/providers/github/platform.go
30.97% <100.00%> (+2.53%)
:arrow_up:

pkg/krok/providers/auth/user_token_generator.go
68.42% <0.00%> (-10.53%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5fd913...2385755. Read the comment docs.


shonky fix for new cfgrib

Fixes #228

Yeah this doesn't make much sense... I'll merge this fix into my PR to get the tests passing


Implement operators as functions

lots of bc breaks in there?

I was very deliberate when deciding what's @api and what's @internal originally. All of the removed classes were @internal ... except for Negative where I forgot to add it. : /
Widening the return types of the Expr::*() methods isn't ideal though. I should have never made them that narrow.
Let me think about how to proceed.


We need to create a page of instructions for uploading a CSV file of locations

To start with simply add some copy to the about page

we have upload form now


.devcontainer/devcontainer.jsonと.github/dependabot.ymlを追加

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This is a good idea. We are open to a new PR when you are ready.


what if event name is type Symbol, and prefix === '~'

Does the prefix really necessary? How to deal with with event type Symbol

If the environment has support for symbols, events are not prefixed. See https://github.com/primus/eventemitter3/blob/master/index.js#L15-L30.


Buffer metrics irregardless of number of server

Currently metrics are aggregated in a vector, which is limited to 11*120.
https://github.com/aheart/hearth/blob/7e320c3091d5d1898bad07371b3cf932cee5fbd6/src/ws/server.rs#L97
A hashmap should be used instead, that would allow buffering a fixed amount of measurements per server.

Done in #45


Fix shader for Godot 4.0 GLES3 renderer

There is a strange bug with the shader when using Godot 4.0's GLES3 renderer which I believe has to do with the differences in how textures are filtered between Vulkan and GLES3. This pull request fixes that issue by changing the filtering settings on the palette texture.

I don't see any issue in the example project.
Can you attach the texture + palette that exhibits this problem?
I suspect it's some Godot bug, because AFAIK repeat is disabled by default. I can still merge this though, I just want to test it properly.

example-project.zip
Attached is an example project that is exhibiting the issue. It's set to GLES3 by default, so the issue should immediately present itself. The palette flickers between rows and doesn't correctly change all the colors of the sprite. The shader works correctly in the Vulkan renderer.
For what it's worth, I had issues with the example project as well - the final orb (static palette swap) was still animating.
You are correct to assume repeat is disabled by default, since Godot seemed to fix the issue of not properly setting defaults in GLES3 in this pull request. I haven't tested the new commit myself, but it should solve the issue for whenever 4.1 (or 4.0.x) comes out. In the meantime, this small fix should sidestep the Godot bug

Can you attach a screenshot? I don't see the issue.

haven't tested the new commit myself, but it should solve the issue for whenever 4.1 (or 4.0.x) comes out.

4.0.1 should arrive this or next week.

This is what it looks like in my editor. I suspect that this may have to do with GPUs - what GPU are you using? I have an RX 580 so maybe it's AMD's GL implementation.


To change the colours of the walls and floor would I have to edit on mesh.js?

Yes, you will have to modify the fragment shader in mesh.js.

I figured out how to do this but it does involve a couple steps. In the mesh.js folder I commented Line 96: totalLight = pow(totalLight, vec3(1.0/2.2)); Copied and pasted Line 96: totalLight = pow(totalLight, vec3(,,); (deleting what was inside the brackets of vec3). In these brackets you have to add a GSL vec 3 code which consists of 3 digits. Using coolors.co to look up hex codes for a colour I converted them into GSL vec 3 using this website https://airtightinteractive.com/util/hex-to-glsl/. Copying and pasting the code into the brackets.
*When looking for a colour find the complimentary colour on a colour wheel and look for that hex code. For example, Dark purple #2B061E will give you a green coloured room


bug: Memory expansion should only increments modulo 32

Bug Report
Kakarot version:
main
Current behavior:
Memory expansion is not by increments modulo 32.
Expected behavior:
Memory expansion should only increments modulo 32. (playground)
Steps to reproduce:
By initializing the memory, then expanding the memory by 1, the new size should be 64 bytes, not 33 bytes.
Related code:
// Given
let mut memory = MemoryTrait::new();
let value: u256 = 1;
let bytes_array = helpers::u256_to_bytes_array(value);

memory.store_n(bytes_array.span(), 0);

// When
let cost = memory.expand(1);

// Then
assert(cost >= 0, 'cost should be positive');
assert(memory.bytes_len == 64, 'memory should be 64bytes');
let value = memory.load_internal(0);
assert(value == 1, 'value should be 1');

I can take this

Hi, thanks for the bug report!
I think there might be a misunderstanding.
Because MLOAD loads a word that is 32 bytes long, it'll expand at the same time of loading the word, thus expanding 32 bytes per 32 bytes.
You can try with other opcodes that can trigger memory expansion, such as SHA3, and try in a way that is not modulo 32 for reference.

MLOAD does indeed load 32 bytes, but not necessarily whole words. We can load 32 bytes from offset 1, which must extend memory by 32 bytes.
I've done the exercise with SHA3, loading 33 bytes into memory should expand it by 32 bytes.
See playground.

Thanks for the shoutout, found the official Ethereum spec, implemented in Python
We're starting to look into it for clear guidelines on such edge cases:
https://github.com/ethereum/execution-specs/blob/master/src/ethereum/shanghai/vm/gas.py#L142


Gist Embeds don't render

Versions

nuxt: 2.13.3
node: 10.16.1

Reproduction
Add a GIST embed link to any .vue template, page or layout

Steps to reproduce
Add a Gist embed anywhere
So go here to get the embed code, example

What is Expected?
Gist embed renders
What is actually happening?

Nothing shows on the page
Network inspector shows it downloads and the document.write commands get triggered, but nothing actually renders

I am using nuxt\netlifycms to store blog posts in /content/blog and a good chunk of the posts have GIST embed scripts in them. I assume the issue is that we shouldn't be writing to the DOM directly, but I'm not sure how to work around this, possible?

Closing, I mean clearly not a "bug" didn't notice that tag... I just haven't figured out a way around it yet.  I can render a gist with an npm plugin, but not through saved markdown


User Media Dirs

This is a feature request to add the users various media directories.
Users typically have more than just Documents inside their home folder. Most OS's that I am aware of also create Pictures, Music, and Videos folders. On Android you also have the Camera folder (usually at DCIM/Camera)
This only comes up as I am working on a photo backup app. I don't think the user would like if photos appear in the Documents folder.

I like this idea

Pictures: https://github.com/platformdirs/platformdirs/pull/167

Videos: https://github.com/platformdirs/platformdirs/pull/169

Music: https://github.com/platformdirs/platformdirs/pull/173


nydusify supports localfs filesystem backend

Relevant Issue (if applicable)
N/A
Details
Support localfs for nydusify commands. Specifically useful for convert for local filesystem-backed backend.  The inspiration for this change was to test running Nydus with GCSFuse backend localfs on GKE. This is effectively a workaround as Nydus support for GCP Artifact Registry (https://github.com/dragonflyoss/nydus/issues/1594) is still a work in progress.
Types of changes
What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Documentation Update (if none of the other choices apply)

Checklist
Go over all the following points, and put an x in all the boxes that apply.

[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.

LGTM, thanks! Do you need to use nydus snapshotter and make corresponding changes?

LGTM, thanks! Do you need to use nydus snapshotter and make corresponding changes?

Yes, I am using/installing Nydus snapshotter in our own GCP cluster but I am currently unaware of what corresponding changes you are referring to.
In our own fork and branch of nydus-snapshotter we been patching snapshotter.sh boot script to fix containerd config updating logic. The currently logic was not working within our GKE provisioned containerd config.toml.


Why the number of categories is 9?

May I ask why the results of the experiment are only on the 9 categories of scannet, instead of the general 18 categories? Maybe because of limited reading, which previous work did you follow, or some concerns? Looking forward to your answer, thank you.

Thanks for the interest in our work!
We followed ODAM(https://arxiv.org/abs/2108.10165) and RayTran(https://arxiv.org/abs/2203.13296), in which they report the top-8 super-classes and group all the other classes together as 'other'.
Note that the annotations used in our work are from Scan2Cad instead of ScanNet. ScanNet only provides axis-aligned bounding boxes (AABB), while oriented 3D boxes are needed in our work.
Generally, 18 classes are usually reported if using ScanNet annotation and only predicted AABB, and 9 classes are usually reported if using Scan2CAD annotations and predicted oriented boxes.
Thanks,
Yiming

Thanks for your answer. I will read the above paper carefully. And think about which tasks require axis-aligned bounding boxes and which tasks require oriented 3D boxes.


Gather block validation events from the changefeed

relates to #1339
The goal of this issue is to find a way to gather block event notifications and store them to be later consumed with the events api.
A first approach could be to get these events from the election process and store them in a queue that can be accessed between processes.

done in #1347


Evaluation questions

Hello,
I used your codebook pre-trained on the VGGsound dataset, and then trained the transformer on my own dataset（seven categories）, and now I am doing evaluation work, but I am a little confused about the evaluation results.
(1) My results are as follows: samples_2023-05-22T21-27-45: KL: 2.64812; ISc: 3.48715 (0.028569); FID: 3.94182; KID: 0.00128 (0.00008)
. The FID is much smaller than that given in your paper. Is this reasonable? Does it mean that there is something wrong with my training process, such as overfitting?
(2)Is the KL value the MKL mentioned in the paper? If not, how can I calculate the MKL?

Hi,
(1) from what you mention, you seem to get nice and relevant samples in samples_2023-05-22T21-27-45 (check if they make sense to you if you play them). Hence, low FID and low KL (this is the MKL). Have you tried to hold out a set of videos that were not used during training? How does it perform on them compared to training?
(2) yes these are MKLs no need to do anything extra. Sorry for the confusing notations.


Added 10 courses on Android

What does this PR do?
Adds courses available on Udacity. Already 5 free Android courses on Udacity were previously added but these 10 more were missing. These include newly added courses as well.
For resources
Description
Udacity is an authentic website which provides good courses.
Why is this valuable?
Added courses will give a more useful and complete list of free Android courses available on Udacity.
How do we know it's really free?
When go to the respective links then it is mentioned that "Free Course" and from there can select "Start Free Course" and then Sign Up/Login on Udacity to avail that course.
For course lists, is it a course?
Yes
Checklist:

[x] Read our contributing guidelines
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists  in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction)

Followup

Check the output of Travis-CI for linter errors!

Please follow our style:
Instead of:
* [Udacity Build Native Mobile Apps with Flutter](https://www.udacity.com/course/build-native-mobile-apps-with-flutter--ud905)
Do:
* [Build Native Mobile Apps with Flutter](https://www.udacity.com/course/build-native-mobile-apps-with-flutter--ud905) - (Udacity)

Should I do it for all Udacity courses?

Thanks, and welcome to free-programming-books!

Thank you


New set of Icons (vol 4) to be Published

Select one ...  (check one with "x")
[ ] bug
[ ] feature request
[X] enhancement

Description
The purpose of this ticket is to track icon deliveries and implementation (post to the site; add to codebase). A new set of icons will be attached to this ticket once a week by Lilia. Every 2weeks, the 2 sets are to be released to the Clarity site.

Icon Delivery: 1 of 2
Here is the first set:
Vol4_svg_1of2.zip
Details about this set:
https://confluence.eng.vmware.com/display/CLAR/Icon+Inventory+and+Classification
@Shijir


jenkins: migrate to Homebrew

Deleting jenkins from cask as part of deduplication process . See context here.
Please note that this PR is created to continue case-by-case discussions from thread linked above and if decision is made not to remove the cask, PR will be closed.
cc @MikeMcQuaid

Thanks!


When changing the application theme using RequestedTheme, the colors of the toolbar buttons in the TitleBar do not change properly.

Describe the bug
When I change the application theme to another in code, the buttons in the toolbar (Close, Collapse, Maximize) remain with the style of the previous theme.
Steps to reproduce the bug

Create new Empty WinUI app
Add theme change code: ((FrameworkElement)Content.XamlRoot.Content).RequestedTheme = ElementTheme.Light;
Start the app
See how the colors of the buttons in the toolbar do not change properly, but remain the color of the previous theme

Expected behavior
Toolbar button colors should change appropriately to match the theme of the entire program
Screenshots

NuGet package version
WinUI 3 - Windows App SDK 1.5.4: 1.5.240607001
Windows version
Windows 11 (22H2): Build 22621
Additional context
All other colors change perfectly

Application.RequestedTheme needs to handle this scenario.


Pin and split requirements source

For tests we want to pin all requirements.
For user installs we want more relaxed pinning.

This PR requires #113 since some libraries have already dropped support for Python 3.5.


Simplify makefile

Since this is just a single file cpp program it shouldn't need such a thorough makefile. Currently it is based on a template I found online but the build phase can probably just be hardcoded instead of templated as it is right now. The test, info and install methods should probably be kept as is.

Closed because I updated the makefile in commit 8f5a324.


Constant Unpicking

Constant Unpicking
Before
private static void setLit(WorldAccess world, BlockState state, BlockPos pos, boolean lit) {
   world.setBlockState(pos, (BlockState)state.with(LIT, lit), 11);
}

After
private static void setLit(WorldAccess world, BlockState state, BlockPos pos, boolean lit) {
   world.setBlockState(pos, (BlockState)state.with(LIT, lit), SetBlockStateFlags.PROPAGATE_CHANGE | SetBlockStateFlags.NOTIFY_LISTENERS | SetBlockStateFlags.REDRAW_ON_MAIN_THREAD);
}

This works by using the WeaveMC/unpick library created by @Daomephsta, unpick files are created to define how unpick will unline the constatnts. You can read about the Unpick format here.
Compile time only classes are also provided that will be exposed to your mods. Only the generated sources in loom will contain the uninlined constants to ensure that all existing mixins that depend on the constants will contiune to work.
This PR currenly only contains a basic but common example (based off the work already done in weft) of the setBlockState method. There are a range of other constants that can be unpicked in the future with this.
I have added a extras/definitions.unpick to the v2 yarn mapping jars, I dont believe this will break any existing tools, and will make it easy for loom to pick them up and apply them if required. A -constants jar file along with sources is also published to maven.
Please let me know of any suggestions, this is still a WIP. I wont be merging this untill its had some time to be reviewed as well as the loom PR is complete. This currenly targets the 1.17 snapshots, it can easily be backported to 1.16 once complete.

Not sure if it's in the scope of this PR, but wouldn't it make sense to have a shortcut constant in SetBlockStateFlags for 3? I know that Mojang has a shortcut for 3 from snippets of original source code I've seen.

Not sure if it's in the scope of this PR, but wouldn't it make sense to have a shortcut constant in SetBlockStateFlags for 3? I know that Mojang has a shortcut for 3 from snippets of original source code I've seen.

Yes, that sounds reasonable, but is prob out of scope of this PR. This PR is more for the toolchain side of things, other PRs can come later to expand on that kind of thing.

Yes, that sounds reasonable, but is prob out of scope of this PR. This PR is more for the toolchain side of things, other PRs can come later to expand on that kind of thing.

This should be ready to review, I have added a new yarnUnpicked task to run enigma with the unpicked names. Its not default right now as its a bit slower due to it needing to build and run a lot more.
I think we should get this in and have a play with as we can now easily make changes as the unpick version is defined in via a json file now.

thanks


Web: native dropdown on iPadOS looks verbose on iPadOS

Re #83296

Run self hosting bits in iPadOS
Click Debugger options and Terminal selector to trigger native dropdown

The separator looks weird especially. We may want to use custom menu on iOS/iPadOS.

Should this merge into https://github.com/microsoft/vscode/issues/83556 ?


Cannot resolve error "Cannot auto-create unischema due to unsupported column type"

Hi,
I am trying to convert a pyspark dataframe into parquet and load into a keras model.fit using petastorm.
My dataframe schema looks like:
"field1: integer
field2: integer
....
label: integer
features: udt
"
I used vectorassembler to pack the feature fields in a vector called "features".
To load the dataset into a keras model using petastorm, I am using the following code:
"with make_batch_reader(petastorm_dataset_url, num_epochs=100) as reader:
dataset = make_petastorm_dataset(reader)
model.compile(loss=loss, optimizer='adam')
model.fit(dataset, batch_size=batch_size, epochs=epochs, steps_per_epoch=steps)"
I am getting the following error:
"ValueError: Cannot auto-create unischema due to unsupported column type struct<type: int8, size: int32, indices: list<element: int32 not null>, values: list<element: double not null>>"
My guess is I am facing some type conversion issues, but I would appreciate any hints on how to solve this.
Thanks

Currently petastorm does not properly support arbitrary parquet types. We see more and more need for that, so I hope we'll improve the support soon.
In your case, would it be possible to unpack features udts into separate columns? That might help.
Note that in order to automatically collate multiple rows into batches, each row with a list type of value, all lists would need to be of the same length. If not, you might be able use transform_spec argument to preprocess each row so the rows could be batched.

Hi,
I skipped packing all columns in a single "feature" using vector assembler, and kept each column separate. With that I don't see this error, but I get a new error since model.fit() was expecting only a tuple of 2 o3 3 columns such as  "'Please provide model inputs as a list or tuple of 2  or 3'
2238               'elements: (input, target) or (input, target, sample_weights)'"
The new error I get is as follows:
"TypeError: not all arguments converted during string formatting
TypeErrorTraceback (most recent call last)
 in ()
5   #optimizer = keras.optimizers.adadelta()
6   model.compile(loss=loss, optimizer='adam')
----> 7   model.fit(dataset, batch_size=batch_size, epochs=2, steps_per_epoch=2)
8   print(reader.schema)
/databricks/python/lib/python2.7/site-packages/tensorflow/python/keras/engine/training.pyc in fit(self, x, y, batch_size, epochs, verbose, callbacks, validation_split, validation_data, shuffle, class_weight, sample_weight, initial_epoch, steps_per_epoch, validation_steps, max_queue_size, workers, use_multiprocessing, **kwargs)
774         steps=steps_per_epoch,
775         validation_split=validation_split,
--> 776         shuffle=shuffle)
777
778     # Prepare validation data.
/databricks/python/lib/python2.7/site-packages/tensorflow/python/keras/engine/training.pyc in _standardize_user_data(self, x, y, sample_weight, class_weight, batch_size, check_steps, steps_name, steps, validation_split, shuffle)
2237               'Please provide model inputs as a list or tuple of 2  or 3'
2238               'elements: (input, target) or (input, target, sample_weights)'
-> 2239               'Received %s' % next_element)
2240         if len(next_element) == 2:
2241           x, y = next_element
TypeError: not all arguments converted during string formatting"

I am seeing the following error when trying to fit a keras model using petastorm dataset.
My sample code is as follows:
'with make_batch_reader(petastorm_dataset_url) as reader:
for row in reader:
print(row.features.shape)
dataset = make_petastorm_dataset(reader)
model.compile(loss=loss, optimizer='adam')
model.fit(dataset, batch_size=batch_size, epochs=2, steps_per_epoch=2)"
Each dataset row has 108 columns as the feature set, and the dataset has 20,000 rows. The error I see is:
"ValueError: Error when checking model input: the list of Numpy arrays that you are passing to your model is not the size the model expected. Expected to see 108 array(s), but instead got the following list of 1 arrays: [<tf.Tensor 'ExpandDims_6:0' shape=(?, 1) dtype=float64>]..."
Any help would be appreciated to resolve this error.
Thanks

Hard to say without looking at the data. Can you show the structure of all fields in the row? Does it match fit expectation ((inputs, targets) or (inputs, targets, sample_weights))? Consider creating an iterator and looking at the shapes, like in the example: examples/hello_world/external_dataset/tensorflow_hello_world.py. What are the actual TF tensor shapes?

I created an iterator, and extracted the tensor details as follows:
"with make_batch_reader(petastorm_dataset_url, num_epochs=100) as reader:
#for row in reader:
print(row.features.shape)
dataset = make_petastorm_dataset(reader)
iterator = dataset.make_one_shot_iterator()
tensor = iterator.get_next()
print(tensor)
with tf.Session() as sess:
sample = sess.run(tensor)"
Tensor output:
"inferred_schema_view(features=<tf.Tensor 'IteratorGetNext_7:0' shape=(?,) dtype=float64>, label=<tf.Tensor 'IteratorGetNext_7:1' shape=(?,) dtype=float64>)"
The original training dataframe has 108 columns , and 1 label column.
In the tensor, features is an array of 108 doubles, and label is a single double value.

If the original parquet file has 108+1 columns, I would expect to see 109 columns in the record loaded and not just two fields. Originally, you mentioned that features was a udt, is that still the case?
It would be best if you could provide a small snippet of code for me to reproduce the issue that would create a dummy parquet store with the same structure as yours. Not sure I fully understand the way your dataset is structured.

I used the following code to pack 108 columns into a features udt,
dataframe df has 108+1 columns
df schema
#x1:double
#x2:double
#...
#x108:double
#label:double
"from pyspark.ml.linalg import Vectors
from pyspark.ml.feature import VectorAssembler
ignore = ['label']
assembler = VectorAssembler(inputCols=[col for col in df.columns if col not in ignore], outputCol='features')
train_df = assembler.transform(df)"
I then filtered out the features and label:
"final_train_df = train_df.select(['features', 'label'])"
Next some code sample from: https://docs.microsoft.com/en-us/azure/databricks/_static/notebooks/deep-learning/petastorm.html  -> "Petastorm supports scalar and array columns in Spark DataFrame. MLlib vector is a user-defined type (UDT), which requires special handling. Register a user-defined function (UDF) that converts MLlib vectors into dense arrays."
"%scala
import org.apache.spark.ml.linalg.Vector
val toArray = udf { v: Vector => v.toArray }
spark.sqlContext.udf.register("toArray", toArray)"
"final_train_df.selectExpr("toArray(features) AS features", "label AS label")
.repartition(10)
.write.mode("overwrite")
.option("parquet.block.size", 1024 * 1024)
.parquet(parquet_path)"
This creates the parquet file I am trying to use for fitting the keras model.

For the Keras model, I have the form:
model = Model(inputs=[input1, ...input108], outputs = output).
I believe that is why I am getting mismatch. I am packing all 108 columns into the parquet file and transforming into petastorm dataset. Is there a Petastorm API that would be compatible with multi-input keras models like this?

Since Petastorm is not aware of Keras at all, I would expect you to be able to reshape data in TF dataset produced by make_petastorm_dataset API by standard TF dataset manipulation means (e.g.  using Dataset's map function - it should give you the full flexibility to transform the data acquired from a Parquet store into whatever Keras expects.
Would that work in your case?

Thanks, I will try that. I am now running into a different issue as I try to fit a keras model using petastorm dataset. My code segment is as follows:
all_cols = train_df.columns
with make_batch_reader('file://' + get_local_path(parquetpath), num_epochs=None) as train_reader:
     train_ds` = make_petastorm_dataset(train_reader).map(lambda x: (tuple(getattr(x, col) for col in all_cols)))
    model.fit(train_ds, batch_size=batch_size, epochs=2, steps_per_epoch=2)
I am getting the error message: "ArrowIOError: Invalid parquet file. Corrupt footer."
I saved the parquet file using:
df.write.parquet(parquetpath, mode='overwrite')
I checked that I can properly read the parquet file using spark.read.parquet(parquetpath).
Once or twice, when I restart my databricks cluster, the error goes away, but I am not completely sure why I am getting this error. To double check I have also cleaned up committed and started files from the parquet location.
Kindly provide some guidance about this issue. Thanks

Not sure. The fact that restarting the cluster helps - could it be that the files are not fully written/flushed out before you try reading them? The error message would make sense in this case.

Hello,
I am running into the same kind of issues on a Databricks cluster as well. I have a similar setup as @muntasirraihan, although rebooting the cluster doesn't seem to be of any help. I also used the sample code in databricks' documentation notebook as my base.
I have a dataprep pipeline processing my data, which ends with a df.write.parquet(path) statment (reading it through spark seems to be working fine as well). My dataframe's rows are composed of three fields :
features:array (Previously a VectorUDT, converted to an array with the notebook's UDF)
    element:double
next:integer
weight:integer

This is where it breaks ; I have this code :
from petastorm import make_batch_reader
from petastorm.tf_utils import make_petastorm_dataset

with make_batch_reader(petastorm_dataset_url, num_epochs=10) as reader:
  dataset = make_petastorm_dataset(reader) \
    .map(mapper)
  model.fit(dataset, steps_per_epoch=10, epochs=10)

... breaking at the with clause with the following error :
ArrowIOError: Invalid parquet file. Corrupt footer.

Sometimes I have a slight variation and get the following in the stacktrace :
PetastormMetadataError: Could not find _common_metadata file. Use materialize_dataset(..) in petastorm.etl.dataset_metadata.py to generate this file in your ETL code. You can generate it on an existing dataset using petastorm-generate-metadata.py

I'd also be interested in some insight about this issue.

Looked at the code. This can be somehow related to the _metadata or _common_metadata files stored in your parquet directory. Do you have either of these files? Can you please post that values you get from :
pq.ParquetDataset(dataset_path).metadata
pq.ParquetDataset(dataset_path).common_metadata

In particular, values of num_row_groups are interesting.
This is the code that deciphers number of rowgroups in your Parquet store, and the message in your second error is raised by it.
Can you please also show full call-stack? Curious where ArrowIOError originates from.

As a matter of fact, I can't even create the dataset with the pq.ParquetDataset primitive, I get the same ArrowIOError: Invalid parquet file. Corrupt footer..
I created a gist with the stacktrace, you can see it https://gist.github.com/al-one-zero/5240174a5bbf3984e2601c931aa1a1a0.

Then it seems that somehow your parquet store got corrupted. Can read it using a vanilla spark.read.parquet call as spark dataframe?

Absolutely, I can, just like @muntasirraihan described it in his own setup. It seems that when I write my dataframe with df.write.parquet(location) neither _matadata nor _common_metadata are created.

 Corrupt footer.. the issue does not stem from the lack of _metadata or _common_metadata. The failure occurs when actual Parquet files are read. This means that something bad happened during Parquet file write-out.
If Spark's native spark.read.parquet(location) works, and you can actually access the data while pa.ParquetDataset doesn't, I would think that there is some issue with pyarrow parquet reader. This basically means that you should be able to reproduce the failure without any Petastorm code. Or am I missing something?

This is exactly what is happening indeed, I came to the same conlusion.

Is there anything to check further, or we should close the issue?


Set mask

I cant't set mask dynamically.
Setting mask in xml with app attributes works fine.
But defining edittext in xml and then setting mask through et.setMask("") doesnt work. Mask doesnt apepars.

Oh.. Same issue

Same here..

Same problem


Note tween issue

Hi, I'm trying to recreate this note effect from KE to Psych Engine with LUA script

I set a new var to funkinlua called "songPos" because I see that the Engine doesn't have and I need to do the loop thing.

So the result is bruh

Here is the code I made, yeah idk why "for i=0,3 do" doesn't work and I had to make it like this. If you have a more optimized code for notetweens please gimme D:
function onUpdate(elapsed)
	if curBeat>1 then
		local currentBeat = (songPos/100)*(curBpm/60)
		noteTweenX(defaultPlayerStrumX0, 4, defaultPlayerStrumX0 + 10*math.sin((currentBeat+4*0.25)*math.pi), 0.3)
		noteTweenX(defaultPlayerStrumX1, 5, defaultPlayerStrumX1 + 10*math.sin((currentBeat+5*0.25)*math.pi), 0.3)
		noteTweenX(defaultPlayerStrumX2, 6, defaultPlayerStrumX2 + 10*math.sin((currentBeat+6*0.25)*math.pi), 0.3)
		noteTweenX(defaultPlayerStrumX3, 7, defaultPlayerStrumX3 + 10*math.sin((currentBeat+7*0.25)*math.pi), 0.3)
	end
end

Help pls
Sorry for my bad english :b

It worked thanks! Do you know how to use the 'for i= do' function to this because it doesn't work for me. You know to do the same tween in multiple notestrums in one code line without making one line for each strum.
function onUpdate(elapsed)
	if curBeat>1 then
		songPos = getSongPosition()
		local currentBeat = (songPos/1000)*(bpm/60)
		for i=0,3
			noteTweenX(defaultPlayerStrumX+i, i+4, (defaultPlayerStrumX+i) + 20*math.sin((currentBeat+i*0.25)*math.pi), 0.1)
		end
	end
end

noteTweenX(defaultPlayerStrumX+i, i+4, (defaultPlayerStrumX+i) + 20*math.sin((currentBeat+i*0.25)*math.pi), 0.1)

in Lua you can't use + i for Strings (Only for integer/float numbers), instead, you use ..i, so basically:
noteTweenX(defaultPlayerStrumX..i, i + 4, (defaultPlayerStrumX + i) + 20 * math.sin((currentBeat + i * 0.25) * math.pi), 0.1)


clearing compile-time cache via crystal

# crystal --version
Crystal 0.23.1 (2017-07-16) LLVM 4.0.1
# uname -a
Darwin gilead-qc124.netel.rpi.edu 14.5.0 Darwin Kernel Version 14.5.0: Tue Apr 11 16:12:42 PDT 2017; root:xnu-27<IP_ADDRESS>.3~1/RELEASE_X86_64 x86_64

I was compiling a program with crystal build -release myprog.cr, when I realized that there was an important change which I had forgotten to make.  So I did a ctrl-c to interrupt the compile, and made the necessary change to my source code.
When I then redid the crystal build -release myprog.cr, crystal hit an error and generated a long error output.  I did not save the output and do not remember what it said, but in glancing at it I was confident that the error was not caused by the changes I had just made.  So I removed crystal's compile-time cache for that program (under ~/.cache/crystal/full_path_to_myprog.cr), redid the build command, and this time it compiled without any errors.
But then it occurred to me, what if I had not known about that cache directory?  The error message didn't say anything about the compile-time cache or where it was.  Is there some option to crystal or crystal build or crystal tool which would clear that directory for the user?  What if someone wanted to have a make clean target, and as part of that they wanted to remove that compile-time cache directory?

I've also had this issue, and I also knew about the cache. It also happens when you update crystal, the old cache often needs to be deleted. Crystal play can break between versions for the same reason.
It reminds me of the issue with node, when the only way to get something to work is delete the node_modules folder and re-install. It's not an obvious fix but one you kind of learn as part of the eco-system.
The obvious solutions are

Store crystal version in cache, if it differs from current version delete cache
Add a crystal clean command to clear the cache on demand

or just document the issue and tell everyone to user rm -rf ~/.cache/crystal

You can do:
rm -rf `crystal env CRYSTAL_CACHE_DIR`

It might be nice having a shortuct of that in the compiler executable, however.
I have to admit though, i've very rarely had to clean up the cache dir recently.

I've found I have to do it when I upgrade crystal. Perhaps the installer should reset the cache? Not sure if this is possible in the various package managers (brew apt etc..)

I've never had to clear my cache between versions?

@RX14 Occasionally I had to do it as well.

I have had to clear the cache recently.  I'd guess two times in the last eight or nine weeks.  Once was after I had installed a new version of crystal, and once was when I had interrupted the compiler while it was compiling something I knew was going to generate errors.  I had started the compile, glanced at the source code and realized that I had not finished a change I was working on.  I had to clear the cache after fixing my source code, or the compiler would error out with some very weird error every time I tried to compile it.

I don't think the installer should try to reset the cache, because that assumes the only person using crystal is the person who installs it.  I install crystal on my mac, but there are three separate userids which might use it.  The userid which installs crystal might not even have access to all userids which run crystal on that same machine.
Each cache is tied to a single userid.  So maybe have the cache include a marker of what version of crystal was used for the last compile.  If crystal starts up and sees that the cache has previously used by a different version of crystal, then it could auto-clear the cache.

Here's a quick idea which might make the compiler more robust: write the files to a tempdir inside the cache dir, and move them to their final place atomically once we know they're valid.
We shouldn't need to clear after a version change though, is there not a crystal version built in to the cache?

Bump! It would be really nice to have such an option.
The most immediate example I can give is when a user tries to compile your code, and has weird errors because of version jumps. There should be a simple to start over, from a fresh state, without having to try to explain them which folder has to be deleted.

I think this is a better shortcut than telling the user to run a certain shell command because a compiler command doesn't assume a particular shell.


Update zh trans kubeadm_upgrade_plan.md

Update zh trans kubeadm_upgrade_plan.md

/hold
please base your translation on the English source file: https://raw.githubusercontent.com/kubernetes/website/master/content/en/docs/reference/setup-tools/kubeadm/generated/kubeadm_upgrade_plan.md

@tengqm I got your point and corrected it, please review

Thanks.
/lgtm
/approve

/hold cancel


Include pre-prod updates in the main site

Description
We'd like the main site to reflect all the latest updates in the pre-prod site please.
Context
Adding templating guidance pages, updating personalisation, delivery times and message statuses.
Type of changes

[x] Refactoring (non-breaking change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Bug fix (non-breaking change which fixes an issue)

Checklist

[x] I am familiar with the contributing guidelines
[x] I have followed the code style of the project
[ ] I have added tests to cover my changes
[ ] I have updated the documentation accordingly
[ ] This PR is a result of pair or mob programming

Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

[x] I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Removed unnecessary bullets and headings anchor links in Text message templates.
Updated link text for the 4 template pages in the Using NHS Notify parent page - removed 'Creating...' from the start of each link.


fix: Add External ID argument

Cloud One Service
select one or multiple if applicable
[ X] File Storage Security
Proposed Changes

Added External ID as argument
Updated Readme

Anything else to change or fix?

Anything else to change or fix?

I already approved just waiting Raph comments, if there's any..


Added getAt function to collections

Closes #2138
✅ Pull Request Checklist:

[x] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

Seemed like too easy of an issue to pass up

@lukerhoads Can you please sign the CLA? You will need to close and open the PR again to trigger it.


Sync Progress as a Percentage In Initial Sync

IMPORTANT: Where possible all PRs must be linked to a Github issue
Closes #2150
Engineer Checklist

[ ] I have written Unit tests for any new feature(s) and edge cases for bug fixes
[x] I have added any strings visible on UI components to the strings.xml file
[ ] I have updated the  CHANGELOG.md file for any notable changes to the codebase
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
[x] I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app

Code Reviewer Checklist

[ ] I have verified Unit tests have been written for any new feature(s) and edge cases
[ ] I have verified any strings visible on UI components are in the strings.xml file
[ ] I have verifed the CHANGELOG.md file has any notable changes to the codebase
[ ] I have verified the solution has been implemented in a configurable and generic way for reuseable components
[ ] I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app


Export servers

Export changes & service assets now in line with dart_services.
@devoncarew @lukechurch

#557

Just to note, we want to make sure that the services PR lands before we land this, and the new service is available on the backend.

We're also changing some of the function names on the server end, so this PR will be updated after the server changes are finalized.

@Georgehe4 Good to close this?

Closing.


Add 'post' step that logs out

if the workflow is using a self-hosted runner, a user would likely want to log out after their oc workflow finishes.

Credentials, if desired instead of token.
  # Username and password override token if they are set.
  openshift_username: ${{ env.OPENSHIFT_USER }}
  openshift_password: ${{ secrets.OPENSHIFT_PASSWORD }}


Security Alert: Susceptible to MITM Attacks

In the documentation it suggests using:
$google2fa_url = Google2FA::getQRCodeGoogleUrl(
    'YourCompany',
    $user->email,
    $user->google2fa_secret
);

This generates a URL to Google Charts.
Using this URL creates a GET request which allows all of the information to sniffed.
Using:
$google2fa_url = Google2FA::getQRCodeGoogleUrl(
    'YourCompany',
    'email',
    'OhHeyThe2faSecret'
);

Returns: https://chart.googleapis.com/chart?chs=200x200&chld=M|0&cht=qr&chl=otpauth%3A%2F%2Ftotp%2FYourCompany%3Aemail%3Fsecret%3DOhHeyThe2faSecret%26issuer%3DYourCompany
If you decode the &chl= part you get: otpauth://totp/YourCompany:email?secret=OhHeyThe2faSecret&issuer=YourCompany
The QR code should be generated server side rather than being passed to a 3rd Party.

It should be recommended to use Google2FA::getQRCoreInline().

Per a little bit more research it appears GET requests are protected with SSL.
My understanding before was that URLS are not encrypted so it appears this is fine unless the SSL to Google is being stripped. (Which if that happens then you're screwed anyway)

Yeh, SSL means the whole request in encrypted.

The URI is part of that.


Use seccomp to disable setuid/setgid binaries in Linux sandbox

Nix uses seccomp to prevent setuid/setgid bits from entering the build, among a few other things. This issue tracks emulating this behavior.

Sat down to try to implement this and found that Go doesn't have direct support for seccomp. There is a library, but it needs to be executed in the child process. This means a helper binary and a cgo dependency.
Punting beyond MVP, but I'll remove any setuid/setgid bits in the store at the least.


What is the intended behaviour of AsciiStr.lines()?

I assume "foo\nbar" producing ["foo"] is a bug,
But the lines_iter() test assert that AsciiStr::from("\n").lines() produces nothing, which is not what I expected, and also differs from str.lines() (which produces a single empty slice).
str.lines() handles "\r\n" and trailing newline, so could the (currently rather complex) implementation be replaced with a simple forwarding implementation?
EDIT on 2018-09-11: fixed typo "foo/nbar"and corrected .split() to .lines().

Ping @tomprogrammer.

The implementations in ascii should generally behave similar to their couterparts in std. Therefore this is a bug.


auto update npm deps and devDeps from tpl

https://github.com/acr-lfr/generate-it/issues/113

True good spot.. weirdly it still works though. I'll commit the , either way.

how's she looking @p-mcgowan ? Good to go?

bewty - looks good. stdout is ugly but seems like it works with both short and long opt.
some time later maybe we could add support in the nodegen file, but for first pass this is great

Beauty is in the eye of the beholder 😅
Yea via spawn would be better too, I'll probs send another pr in for that later with your idea for the RC fine too 👍


Update to logrus 1.4.0

vendor: update logrus to 1.4.0
logrus 1.3.0's Debugf results in a call to fmt.Sprintf even if Debug
level is not set. This is currently fixed in 1.4.0 where fmt.Sprintf is
only called if DebugLevel is set.

This change is

test-me-please

Coverage increased (+0.1%) to 42.636% when pulling 5f135c3d8fd0d611388661711299e4cfbc98c4a0 on pr/upgrade-logrus into 7d8177ad90f54d56f0b3a7c5095ace222bacca55 on master.


Discord link is down

https://github.com/yewstack/yew#-confused-about-something 👇🏽
https://discord.gg/VQck8X4
Not working 😔

Link still works for me and it shows up as active in the internal discord server settings.

If you still have problems, you can PM me, WorldSEnder#8649

Alternative link

Weird

WorldSEnder#8649

Will try, thanks!

Same for me. Can't seem to join the Discord server.

Same for me. Can't seem to join the Discord server.

@dredozubov the invite link is still valid. Alternatively, you can join using this invite or join our Matrix space

I'll provide a bit more context.
I wrote @WorldSEnder and he gave me a different link to join the server that worked for me. After that, the link in the README started to lead me to #contributions chat, before it gave me "Invite invalid" page.

That very much sounds like a discord bug. Nothing we can do about it, sorry


Uninstall module used on PS 1.6 before using this one

@Quetzacoalt91
after upgrading the module for 1.7 is not install


Adding code editor in Python Course

Description
Adding code editor in Python Course and modules

/assign @arpit456jain @KKhushhalR2405 @singhmansi25

@Jayanth-MKV its already there but in some modules its missing so add it in that