调试python代码,不正常

Version confirmation

[ ] Confirm

Neovim version
NVIM0.8.2
Operating system/version
archlinux,dwm
Terminal name/version
alacritty
$TERM environment variable
No response
Branch info
main (Default/Latest)
Fetch Preferences
SSH (use_ssh = true)
How to reproduce the issue
按F6,调试程序,出现如下信息:
Debug adapter didn't respond. Either the adapter is slow (then wait and ignore this) or there is a problem with your adapter or python configuration. Check the logs for errors (:help dap.set_log_level)
这是配置文件最后两次同步后出现的情况,原来是正常的.
Expected behavior
最后两次同步配置,后出现的问题.
Actual behavior
No response
Additional information
No response

最后两次同步配置,后出现的问题.

Hmm this shouldn't be introduced by recent commits - we didn't change the execution logic of DAP.
We need some further information:

What is the version of /usr/bin/python (Please use the path to the executable AS IS, not just python)?
What's the output of:

:echo(executable(getcwd().."/venv/bin/python") || executable(getcwd().."/.venv/bin/python"))

What do you see after running /usr/bin/python -m debugpy.adapter?
Start a debug session as normal, but before starting the adapter, run:

:lua require("dap").set_log_level("TRACE")

After the warning is issued, please provide us with the generated log from:

:lua print(vim.fn.stdpath("cache").."/dap.log")

Don't forget to clear the logging history of dap before starting, run:
truncate --no-create --size 0 /path/to/your/dap.log

Where the path to your dap.log can be obtained from :lua print(vim.fn.stdpath("cache").."/dap.log") in nvim.

@Jint-lzxy  是我自己修改了配置文件,造成的这个结果.我把自己修改的部分改回去后,就正常了.谢谢!
我还有一个问题,我有两个python版本,分别是3.10.9和3.9.14,我想用3.9.14的版本,请问应该怎么修改配置文件呢?(我自己在~/.virtualenvs目录下创建一个debugpy的虚拟环境,怎么能让系统使用这个环境呢?)

I seldom use Python in daily development, so I could only provide limited help.
AFAIK if the python executable exists in your ~/.virtualenvs directory, replace pythonPath with the following (if you have activated venv correctly):
pythonPath = function()
	-- debugpy supports launching an application with a different interpreter then the one used to launch debugpy itself.
	-- The code below looks for a `venv` or `.venv` folder in the current directly and uses the python within.
	-- You could adapt this - to for example use the `VIRTUAL_ENV` environment variable.
	local cwd, venv = vim.fn.getcwd(), os.getenv("VIRTUAL_ENV")
	if vim.fn.executable(cwd .. "/venv/bin/python") == 1 then
		return cwd .. "/venv/bin/python"
	elseif vim.fn.executable(cwd .. "/.venv/bin/python") == 1 then
		return cwd .. "/.venv/bin/python"
	elseif venv and vim.fn.executable(venv .. "/bin/python") == 1 then
		return venv .. "/bin/python"
	else
		return "/usr/bin/python"
	end
end,

You can use the following command to check whether the path is correct.
:lua print(os.getenv("VIRTUAL_ENV") and os.getenv("VIRTUAL_ENV") .. "/bin/python" or "FAILED")

Or if you would like to use the environment defined as VIRTUAL_ENV first:
pythonPath = function()
	-- debugpy supports launching an application with a different interpreter then the one used to launch debugpy itself.
	-- The code below looks for a `venv` or `.venv` folder in the current directly and uses the python within.
	-- You could adapt this - to for example use the `VIRTUAL_ENV` environment variable.
	local cwd, venv = vim.fn.getcwd(), os.getenv("VIRTUAL_ENV")
	if venv and vim.fn.executable(venv .. "/bin/python") == 1 then
		return venv .. "/bin/python"
	elseif vim.fn.executable(cwd .. "/venv/bin/python") == 1 then
		return cwd .. "/venv/bin/python"
	elseif vim.fn.executable(cwd .. "/.venv/bin/python") == 1 then
		return cwd .. "/.venv/bin/python"
	else
		return "/usr/bin/python"
	end
end,

Just as a reference for others using conda:
here's how u call conda env path in DAP:
``lua
pythonPath = function()
if not isempty(vim.env.CONDA_PREFIX) then
return vim.env.CONDA_PREFIX .. "/bin/python"
-- print(vim.g.python3_host_prog)
else
return "/usr/bin/python3"
end
end,


feat: added phone number formats

Different phone number formats added based on country code
✅ Closes #84
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/ngneat/falso/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
Only US phone numbers are generated.
Issue Number: #84
What is the new behavior?
Option to generate phone number based on country code is added
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

@arulprabakaran can you please check it?
https://github.com/ngneat/falso/runs/4965354629?check_suite_focus=true


eval: changes for 4.17

Description
Updating QnA dataset to handle changes to 4.17 doc.
Reference

Thanks!
/lgtm

/approve

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.89%. Comparing base (6af39f6) to head (df976ba).
Report is 42 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1696   +/-   ##
=======================================
  Coverage   94.88%   94.89%
=======================================
  Files          60       60
  Lines        2681     2685    +4
=======================================
+ Hits         2544     2548    +4
  Misses        137      137

Flag
Coverage Δ

?

Flags with carried forward coverage won't be shown. Click here to find out more.

/override "Red Hat Konflux / ols-enterprise-contract / lightspeed-service"


need system to specify sl-sh libs/files from the web

should need to specify git url and possibly git hash for security.
prob a caching mechanism, store in ./local next to history?
unclear what structure of remote repository will need to be.

signing in git: https://git-scm.com/book/en/v2/Git-Tools-Signing-Your-Work


Integration tests for operator

Description:
Should test API deployment with different configuration resources and invocation.
Check the ability to run conformance tests as a part of this
https://gateway-api.sigs.k8s.io/concepts/conformance/?h=conforma#running-tests

PRs for this task:

https://github.com/wso2/apk/pull/716
https://github.com/wso2/apk/pull/720
https://github.com/wso2/apk/pull/749
https://github.com/wso2/apk/pull/780

[ ] [tests] request and response header modify


docs: fix typos

Hey :wave:,
This PR will fix :
1 typo in docs/build/quick_start.md
3 typos in docs/learn/basic/why_db3.md
Best!

PR-Codex overview
This PR focuses on fixing typos and improving the clarity of the documentation.
Detailed summary

Fixed a typo in the file docs/build/quick_start.md by changing "Chosing" to "Choosing" in the heading.
Fixed a typo in the file docs/learn/basic/why_db3.md by changing "syncronize" to "synchronize" in a sentence.
Fixed a typo in the file docs/learn/basic/why_db3.md by changing "privte" to "private" in a sentence.
Fixed a typo in the file docs/learn/basic/why_db3.md by changing "easilly" to "easily" in a sentence.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

thanks for the contribution


There no spell check feature

Description
<Detail your problem here as clearly and concisely as possible 🙂. Help us help you by saying why and giving some context!>
Steps to reproduce issue
Details

Are you nativefying a public website?
Feature request? Have you looked at nativefier --help to see if an existing option could fit your needs?
Full nativefier command used to build your app: <command here>
Version of Nativefier (run nativefier --version): v0.0.0
Version of node.js (run node --version): v0.0.0
OS: <OS here>
Error message / stack trace (if any):

<Error message / Stack trace here>

Hi @mmeirduvid, thanks for the feedback. Indeed, there is not, see #283 and code welcome 🙂. Closing as duplicate.


Add .NET examples

Issue #, if available:
Description of changes:
Added examples for Lambda Powertools core modeuls and S3 integration in .NET.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Awesome thanks @jeastham1993 !


Add tag method

added a git.tag() example and shipped as 1.4.0

note: tests are not passing on travis-ci as a result of an nvm install issue on OSX servers (used to test node 0.10 and 0.12)


[Bug]: The Rbac event names should not be displayed in the audit log event dropdown

Is there an existing issue for this?

[X] I have searched the existing issues

Description
The Rbac event names Should not be displayed in the audit log event dropdown

Steps To Reproduce

Login as a test@gmail.com(admin user)
go to admin setting page
click on audit log
Click on event dropdown
the rbac events are displayed

Public Sample App
No response
Issue video log
No response
Version
release->localhost

This is already taken care.


Does not work on windows

I am trying to use this plugin on windows but it doesn't seem to exclude files.
  "autoload": {
    "exclude-from-files": [
      "athari/yalinqo/YaLinqo/Linq.php"
    ]
  }

Works correctly on OSX and Ubuntu but not windows.

Hi @richwandell,
I apologize, I have not tested this plugin myself on Windows.
I'll try to look into it once I get my hands on a Windows OS.
If you figure it out in the interim, I can apply the fix.
Thanks for spotting this, at least.
Three questions:

What version of Windows are you on?
What terminal are you using to interact with Composer?
What version of PHP is Composer using?

Much appreciated

@mcaskill sorry for not getting back to you I have been very busy lately. When I get some time I plan to look into this on windows and maybe I will send you a fix.

@richwandell I'm sorry it took so long to resolve this issue.
I've pushed a new release (v1.1.0) that merges a fix for this.
I hope it works well.


THRIFT-3770 Implement Python 3.4+ asyncio support

I decided to take an approach which is different from Tornado implementation and do not nail supported protocols to the Framed one. My effort enables BinaryProtocol.

flake8 --ignore=E501 lib/py in Travis failed because the syntax "yield from" is Python 3.3+ and flake does not support it.

@vmarkovtsev thanks for the contribution !
A few points:

Is there any way to create a generic protocol wrapper ?
gen_asyncio_ seems uninitialized.
we need something similar to test/py.tornado and tutorial/py.tornado

As to the test, even much better way is to port test/py/TestClient.py and TestServer.py so that we can test asyncio against other languages.

@nsuke, about the generic wrapper, I feel bad about these dupes too but cannot see the possibility because asyncio coroutine's "viral" nature with "yield from" is going to infect every piece of reading code. What's even worse, "yield from" result in SyntaxError on Python 2.7. In order to support all the protocols, we will have to adapt each existing Protocol similar to what's done to Binary. Framed's already been ported, so I don't think it is too hard anyway.
gen_asyncio_ - overseen, fixed.
I will add the tests in a separate commit in this PR, thanks.

I've added the tests. These only belong to Client, since I do not plan to port Server.
test/test.py --server cpp --client py3.asyncio
Apache Thrift - Integration Test Suite
Mon Apr 04 14:50:11 2016
==========================================================================
server-client:          protocol:    transport:               result:
cpp-py3.asyncio         binary       buffered-ip              success
cpp-py3.asyncio         compact      framed-ip                success
cpp-py3.asyncio         compact      buffered-ip              success
cpp-py3.asyncio         binary       buffered-ip-ssl          success
cpp-py3.asyncio         compact      framed-ip-ssl            success
cpp-py3.asyncio         compact      buffered-ip-ssl          success
cpp-py3.asyncio         binary       framed-ip                success
cpp-py3.asyncio         binary       framed-ip-ssl            success
==========================================================================
No unexpected failures.

@vmarkovtsev great, thanks for the tests and flake8 fix.
Could you also provide an example in either tutorial/py or tutorial/py.asyncio directory ?

Added the tutorial and some tests, fixed the comments

I'm interested in using this.  I see that facebook/fbthrift has support for it, but it's not in PyPI.
Any chance work on this PR will resume?

I will resume this as soon as the maintainers show up themselves :) Since the last time there appeared conflicts and I don't want to resolve them multiple times - not working with Thrift anymore.

This needs to be rebased on the current upstream/master, conflicts resolved, and pushed to kick a new build.

This needs to be rebased on the current master, conflicts resolved, and pushed to kick a new build.

@jfarrell please close this; the author indicated no interest in finishing the work due to the team's past inaction on pull request management.


Fixed issue where buffering would always be zero.

Many of these issues exist in the Video player implementation as well since the video player is an adoption of the audio player. Can you fix this in the Video player as well?

We should seriously create a base class for audio and video.

AFAIK the only difference between them is the set video surface methods. The rest should be more or less equal and can be extracted to a base class for iOS

I'm just adding the fix for the VideoPlayerImplementation for now, refactoring and creating a base class should be done in a separate pull request IMO.

Agreed


[Question] Does edl rely on the PaddlePaddle elastic learning capability

To my knowledge, edl should rely on the capability of PaddlePaddle workload. In other words, PaddlePaddle must has the ability of elastic learning.
If my understanding is correct, could you please direct me where I can find the design doc of elastic learning of PaddlePaddle workload? I can understand a bit of edl itself from the source code, but I cannot find anything about the elastic PaddlePaddle workload.

will update later, thanks for your good question.


Improve code generation strategy for FSMs

Right now, the code in amaranth.hdl._dsl for FSMs does something... weird with the state signal. It should not do that. What it should do instead is:

Make one temporary signal per state whenever .ongoing() is used and the FSM is inactive. (This is basically late binding for states.)
When the FSM definition is complete, create the state signal of the appropriate size and with the right value repr.
Whenever encountering m.next, use an assignment to a value-castable that resolves to the FSM signal. It won't be lowered to a value before the FSM definition is done, so it can be just added as a statement.

Then, we'll be able to make Signal.width immutable.

@wanda-phi points out that this is impossible as described because of the semantics of m.next.


Uncaught (in promise) DOMException

I'm submitting a ...

[ ] bug report
[ ] feature request
[x] support request
[ ] other (Please specify)

Provide information & explanation

Since I upgraded to version 3.4.0, I keep seeing this "warning" in the javascript console and it doesn't load my page at all.
Error:
Uncaught (in promise) DOMException: Only secure origins are allowed (see: https://goo.gl/Y0ZkNV).
Is there a way to take it off ?
Thanks !

Laravel & Angular version: 3.4.0

I'm using Laragon. Is there a way to "disable" the Progressive Web App ?
Thanks.

Laragon plays well with progressive apps, since it autocreates SSL virtual hosts (i use it myself). Sure there are 2 ways, wiht you modifiying the code to remove progressive app or use version 3.2.x as mentioned inde the docs

Thanks !


Improve ui for single warehouse

Screenshots

Pull Request Checklist

[x] All visible strings are translated with proper context.
[x] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] Translated strings are extracted.
[x] Number of API calls is optimized.
[x] The changes are tested.
[x] Type definitions are up to date.
[ ] Changes are mentioned in the changelog.

That's why we gave user ability to set price per variant on the third step 🤷♂


go get github.com/wcharczuk/go-chart failed

$ go get github.com/wcharczuk/go-chart
github.com/wcharczuk/go-chart
E:\Code\Go\src\github.com\wcharczuk\go-chart\vector_renderer.go:173: vr.fc.MeasureString(body).Ceil undefined (type fixed.Int26_6 has no field or method Ceil)
intel i7 amd64 win10

what version of golang are you using?

Golang 1.8.1 on MacOS:
go get -u github.com/wcharczuk/go-chart
cd /Users/giuseppe/rete/sorgenti/go_path/src/github.com/golang/freetype; git pull --ff-only
error: refs/heads/master does not point to a valid object!
error: refs/remotes/origin/HEAD does not point to a valid object!
error: refs/remotes/origin/master does not point to a valid object!
error: refs/remotes/origin/wiki does not point to a valid object!
error: refs/tags/release does not point to a valid object!
error: cannot open .git/FETCH_HEAD: Operation timed out
package github.com/golang/freetype/truetype: exit status 1
package github.com/wcharczuk/go-chart/roboto: open /Users/giuseppe/rete/sorgenti/go_path/src/github.com/wcharczuk/go-chart/roboto/roboto.go: operation timed out
package github.com/wcharczuk/go-chart/seq: cannot find package "github.com/wcharczuk/go-chart/seq" in any of:
/usr/local/go/src/github.com/wcharczuk/go-chart/seq (from $GOROOT)
/Users/giuseppe/rete/sorgenti/go_path/src/github.com/wcharczuk/go-chart/seq (from $GOPATH)
package github.com/wcharczuk/go-chart/util: cannot find package "github.com/wcharczuk/go-chart/util" in any of:
/usr/local/go/src/github.com/wcharczuk/go-chart/util (from $GOROOT)
/Users/giuseppe/rete/sorgenti/go_path/src/github.com/wcharczuk/go-chart/util (from $GOPATH)

looks like an issue on github's side


[CAD-2442] Generalize the plugin functionality for db-sync.

https://jira.iohk.io/browse/CAD-2442

What is this PR setting out to do?

This is still a draft, but it's removing the direct dependency for the database for cardano-sync (which is a new package and can be used by all the plugins), and is making the plugin system general for usage.
This will enable SMASH to be dropped in as a simple plugin.

What is this PR setting out to do?

This is still a draft, but it's removing the direct dependency for the database for cardano-sync (which is a new package and can be used by all the plugins), and is making the plugin system general for usage.
This will enable SMASH to be dropped in as a simple plugin.

Syncing with launchpad.

Syncing with launchpad.

Ready for a review.

bors try

bors try

I really dislike these arbitrary formatting "suggestions" by Hydra whatever running in the background (I presume HLint).

I really dislike these arbitrary formatting "suggestions" by Hydra whatever running in the background (I presume HLint).

Its not hlint its stylish-haskell. The solution is to run these locally. The can be put in a git pre-commit hook.

Added more info to the commit message and made a few minor tweaks.
Testing two things:

Could continue syncing from a state where it is already following the chain tip (passed).
Could re-sync from scratch (failed).

The second one fails with:
SqlError
  { sqlState = "42P01"
  , sqlExecStatus = FatalError
  , sqlErrorMsg = "relation \"block\" does not exist"
  , sqlErrorDetail = ""
  , sqlErrorHint = ""
  }

It seems that after the reorganisation, the code that runs the migrattions is missing.

It seems that after the reorganisation, the code that runs the migrattions is missing.

This is now fixed.

Confirmed. Can sync from existing chain tip and from genesis.

This change seems to have caused a significant and drastic performance regression. It has been running for 5 hours now and has only synced 53 epochs. Normally in 5 hours it can sync close to all current epochs (ie 240+). Need to investigate further.

Looking at just the epochPluginInsertBlock messages:
On master (commit 46b89294ab0650b9946b74d7ba76c8c8e5dcd05f):
[db-sync-node:Info:52] [2021-02-04 02:35:24.72 UTC] epochPluginInsertBlock: epoch 0
[db-sync-node:Info:52] [2021-02-04 02:35:59.17 UTC] epochPluginInsertBlock: epoch 1
[db-sync-node:Info:52] [2021-02-04 02:36:19.17 UTC] epochPluginInsertBlock: epoch 2
[db-sync-node:Info:52] [2021-02-04 02:36:40.41 UTC] epochPluginInsertBlock: epoch 3
[db-sync-node:Info:52] [2021-02-04 02:37:03.45 UTC] epochPluginInsertBlock: epoch 4
[db-sync-node:Info:52] [2021-02-04 02:37:22.49 UTC] epochPluginInsertBlock: epoch 5

On branch ksaric/CAD-2442 (commit 34a84bbf899d1d1ad35894534d3e57986f406c2a)
[smash-node:Info:59] [2021-02-04 02:52:56.33 UTC] epochPluginInsertBlock: epoch 0
[smash-node:Info:59] [2021-02-04 02:57:51.74 UTC] epochPluginInsertBlock: epoch 1
[smash-node:Info:59] [2021-02-04 03:02:28.67 UTC] epochPluginInsertBlock: epoch 2
[smash-node:Info:59] [2021-02-04 03:06:55.72 UTC] epochPluginInsertBlock: epoch 3
[smash-node:Info:59] [2021-02-04 03:11:25.04 UTC] epochPluginInsertBlock: epoch 4
[smash-node:Info:59] [2021-02-04 03:15:38.29 UTC] epochPluginInsertBlock: epoch 5

Could possibly live with a 5-10% slowdown, but this is a 10x slowdown.

This still doesn't fix the slowdown.

Investigating this further, I can confirm that the issue is not with the connection.
The culprit is the DB operation and timing certain functions, I can confirm that the slowdown is mostly in runDbThread on eNextState <- runExceptT $ runActions trce env plugin ledgerStateVar xs where we actually apply (commit) all the blocks.

 Measurements make it look like it's roughly the same, be aware that these measurements are from a single run:
[smash-node.Subscription:Notice:51] [2021-02-07 15:01:13.95 UTC] Identity Required subscriptions started
[smash-node:Info:61] [2021-02-07 15:01:14.09 UTC] Rolling back to slot 0, hash genesis
[smash-node:Info:61] [2021-02-07 15:01:14.09 UTC] Deleting slots numbered: []
[smash-node:Info:61] [2021-02-07 15:01:14.09 UTC] Slots deleted
CPU time:   0.20s
[smash-node:Info:64] [2021-02-07 15:01:14.47 UTC] getHistoryInterpreter: acquired
[smash-node:Info:61] [2021-02-07 15:01:14.58 UTC] insertABOBBoundary: epoch 0 hash 89d9b5a5b8ddc8d7e5a6795e9774d97faf1efea59b2caf7eaf9f8c5b32059df4
CPU time:   6.57s
CPU time:   2.26s
[smash-node:Info:61] [2021-02-07 15:01:29.43 UTC] insertByronBlock: slot 4999, block 5000, hash 2c96784c55986b9ea26116c6cc9ee70582ed6cad00fd30a849c98b874d5a6b89
CPU time:   1.90s
CPU time:   3.60s
[smash-node:Info:61] [2021-02-07 15:01:37.13 UTC] insertByronBlock: slot 9999, block 10000, hash e6a510ff8ae57fdc1c9d66692fbf32502e00e3f88ad94471f0c851b5ec5eb847
CPU time:   1.93s
CPU time:   3.43s
CPU time:   1.87s
[smash-node:Info:61] [2021-02-07 15:01:46.67 UTC] insertByronBlock: slot 14999, block 15000, hash d3afa463873117e7ade566432a3002e67609eab841e73b09ce9bd4f8fa77b02e
CPU time:   4.04s
CPU time:   1.91s
[smash-node:Info:61] [2021-02-07 15:01:54.06 UTC] insertByronBlock: slot 19999, block 20000, hash 683be7324c47df71e2a234639a26d7747f1501addbba778636e66f3a18a46db7
CPU time:   3.16s
[smash-node:Info:61] [2021-02-07 15:01:56.65 UTC] insertABOBBoundary: epoch 1 hash 1941d944df546dea699791c318aeb9cc63b94e4cdb133d79856cda35bf7ecbb1
[smash-node:Info:61] [2021-02-07 15:01:58.20 UTC] epochPluginInsertBlock: epoch 0
CPU time:   2.60s
CPU time:   9.75s
[smash-node:Info:61] [2021-02-07 15:02:10.61 UTC] insertByronBlock: slot 25013, block 25000, hash 37e44110466a04ee127106043c7b20fe7ccc19de01e7cf5da99a4d001865ed2c
CPU time:   3.73s
CPU time:   5.41s
[smash-node:Info:61] [2021-02-07 15:02:26.97 UTC] insertByronBlock: slot 30014, block 30000, hash ff9390758d99567a2a7b0ab271e9b096d89428865fb8452099592aa3341aa9b5
CPU time:   5.01s
CPU time:   4.15s
[smash-node:Info:61] [2021-02-07 15:02:49.50 UTC] insertByronBlock: slot 35020, block 35000, hash 4b4c4cd4ca3b8f00e952aa183faceb19b13ce6ad71c76e5877beedaad51cc8fa
CPU time:  13.03s
CPU time:   5.66s
CPU time:   3.56s
[smash-node:Info:61] [2021-02-07 15:03:05.90 UTC] insertByronBlock: slot 40024, block 40000, hash 4a3f9e61f2886e29a6b3170515b8ddd754af4b442b2475d571f80f95ec787eef
CPU time:   4.45s
[smash-node:Info:61] [2021-02-07 15:03:16.99 UTC] insertABOBBoundary: epoch 2 hash d46adef46f0760f7b89bd03926a0a631aded69b30379ca0404a0f68ebd2936dc
[smash-node:Info:61] [2021-02-07 15:03:18.05 UTC] epochPluginInsertBlock: epoch 1
CPU time:   5.56s
[smash-node:Info:61] [2021-02-07 15:03:20.30 UTC] insertByronBlock: slot 45024, block 45000, hash 6fdbcf100ef700f20af260d7129860a64cb68f4ee93313841a5efbb81ac37dc7

The new profiling result:

Now, I try to be tolerant about choices in the codebase, but I have to express this concern. These kind of "corrections" are, at the very least, very harmful:
cardano-db-sync/src/Cardano/DbSync/Plugin/Default.hs:44:42-113: Suggestion: Avoid lambda
Found:
  \ blockDetail
    -> insertDefaultBlock tracer env ledgerStateVar blockDetail
Perhaps:
  insertDefaultBlock tracer env ledgerStateVar

It should be very clear to people that it's much easier to read if you use lambdas, even though you don't have to.
The code is supposed to be focused on reading, not on "looking cool" and "see how small of a function I can create" (which seems to stem from the "look how smart I am" syndrome).
There is plenty of such "corrections" that I find complete BS and while I do agree that it's better to have something to unify styles, some minimal amount of corrections should be used.

Ready for review.


NuGet repositories shouldn't have a default value for v3_feed_url

Describe the bug
I imported a NuGet repository that doesn't have a v3_feed_url and the provider attempts to supply an incorrect default value for it. I verified with the support team at chocolatey.org that this value should be empty.
Requirements for and issue
This is the output of terraform show for the resource. Note the lack of a v3_feed_url
resource "artifactory_remote_nuget_repository" "nuget-proxy-chocolatey" {
    allow_any_host_auth                   = false
    assumed_offline_period_secs           = 300
    blacked_out                           = false
    block_mismatching_mime_types          = true
    bypass_head_requests                  = true
    download_context_path                 = "api/v2/package"
    download_direct                       = false
    enable_cookie_management              = false
    excludes_pattern                      = "[trimmed]"
    failed_retrieval_cache_period_secs    = 0
    feed_context_path                     = "api/v2"
    force_nuget_authentication            = false
    hard_fail                             = false
    id                                    = "nuget-proxy-chocolatey"
    includes_pattern                      = "**/*"
    key                                   = "nuget-proxy-chocolatey"
    list_remote_folder_items              = false
    missed_cache_period_seconds           = 1800
    offline                               = false
    package_type                          = "nuget"
    priority_resolution                   = false
    project_environments                  = []
    propagate_query_params                = false
    property_sets                         = [
        "artifactory",
    ]
    remote_repo_layout_ref                = "nuget-default"
    repo_layout_ref                       = "nuget-default"
    retrieval_cache_period_seconds        = 86400
    share_configuration                   = false
    socket_timeout_millis                 = 15000
    store_artifacts_locally               = true
    symbol_server_url                     = "https://symbols.nuget.org/download/symbols"
    synchronize_properties                = false
    unused_artifacts_cleanup_period_hours = 0
    url                                   = "https://chocolatey.org/"
    xray_index                            = false

    content_synchronisation {
        enabled                         = false
        properties_enabled              = false
        source_origin_absence_detection = false
        statistics_enabled              = false
    }
}

Here's the output of terraform plan for that resource:
  # artifactory_remote_nuget_repository.nuget-proxy-chocolatey will be updated in-place
  ~ resource "artifactory_remote_nuget_repository" "nuget-proxy-chocolatey" {
        id                                    = "nuget-proxy-chocolatey"
      + v3_feed_url                           = "https://api.nuget.org/v3/index.json"
        # (34 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Artifactory verssion 7.46.10
Terraform version 1.2.5
Provider version 6.21.6
Expected behavior
v3_feed_url should have an empty default value.
Additional context
Add any other context about the problem here.

The way TF provider works, if the attribute is not set, the default value gets assigned, in this case, https://api.nuget.org/v3/index.json. As a workaround, if you want the value to be empty, please assign an empty string to v3_feed_url.


Fix(UI): Fixed policy implementation issues with team details page

Describe your changes :

I worked on policy implementation issues with team details page

Type of change :

[x] Bug fix
[x] Improvement

Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

Frontend: @open-metadata/ui

edit icon for ower is not visible can you check? due to this cypress is failing


Menus QA

When reordering menu items, on success, show little pop up of success like we have when reordering fields in a Content Type like so:

Left side menu, "Menus" should be highlighted when selected, like it works with other nav items

vs

Menu Items header seems to have rounded corners on each column:

Should be smooth like:

The menu commands should be a filterable category in Audit Logs

RaythaFunctions too for that matter

"Parent Menu Item" -- lets sentence case it to "Parent menu item"

For UI consistency, when are you in the context of a Menu Item, lets remove these other menu items and only show the Delete menu item menu item

The user can click <-- Back to get back to menu items

Fixed https://raytha.awards-dev-test-server.office.getfullstack.co:8006/raytha/menus


⚠ Bofrost.at has degraded performance

In 2c27e93, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1681 ms

Resolved: Bofrost.at performance has improved in 4a12ae3 after 13 minutes.


price values validation for ShippingMethodChannelListingUpdate mutation

I want to merge this change because ShippingMethodChannelListingUpdate mutation needed additional validation for decimal precision fields.

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-4488 Mutation ShippingMethodChannelListingUpdate does not validate input fields max values


Missing file remove_short_reads_SE

Can't run remove_short_reads_SE step because we are missing filter_short_reads_pairs.sh.

Hi @jadeenright ,
Thanks, I added the missing script to the companion chartools-dev repo. Let me know if it works. FYI this repo is under active dev. The pipeline works but we are working on testing/improving portability. A more detailed documentation of the installation and run steps will also come out soon.

Hi! Thank you, that did work. We are now experiencing the following error message:
"Error in job decon_RNA_SE while creating output files Charseq_pilot_R2/split_chimeras/SE_merge_pear/long.decon/rna.fastq.gz, Charseq_pilot_R2/split_chimeras/SE_merge_pear/long.contaminants/rna.fastq.gz, Charseq_pilot_R2/split_chimeras/SE_merge_pear/long.contaminants/rna.bam, Charseq_pilot_R2/split_chimeras/SE_merge_pear/long.contaminants/rna.stats.txt.
RuleException:
CalledProcessError in line 267 of /Volumes/Sequencing_Data/Jade/pipeline.smk:
Command '
bowtie2 -p 1 -q --very-sensitive --norc -x /Volumes/Sequencing_Data/Jade/GRCm39/annotations_musbase/bowtie_rRNA/rRNA --rg-id Charseq_pilot_R2:SE_merge_pear/long/rna --rg SM:Charseq_pilot_R2 -U Charseq_pilot_R2/split_chimeras/SE_merge_pear/long/rna.fastq.gz 2>Charseq_pilot_R2/split_chimeras/SE_merge_pear/long.contaminants/rna.stats.txt | picard SortSam I=/dev/stdin O=Charseq_pilot_R2/split_chimeras/SE_merge_pear/long.contaminants/rna.bam SORT_ORDER=queryname && bash /Volumes/Sequencing_Data/Jade/decon_reads_pairs.sh Charseq_pilot_R2/split_chimeras/SE_merge_pear/long/rna.fastq.gz Charseq_pilot_R2/split_chimeras/SE_merge_pear/long.contaminants/rna.bam rna Charseq_pilot_R2/split_chimeras/SE_merge_pear/long 1
' returned non-zero exit status 1.
File "/Volumes/Sequencing_Data/Jade/pipeline.smk", line 267, in __rule_decon_RNA_SE
File "/opt/anaconda3/envs/charseq/lib/python3.6/concurrent/futures/thread.py", line 56, in run
Removing output files of failed job decon_RNA_SE since they might be corrupted:
Charseq_pilot_R2/split_chimeras/SE_merge_pear/long.contaminants/rna.bam, Charseq_pilot_R2/split_chimeras/SE_merge_pear/long.contaminants/rna.stats.txt
Will exit after finishing currently running jobs.
Exiting because a job execution failed. Look above for error message"
Which we then determine is caused by:
"Error: Read A00325:476:HHWTJDSX3:2:1523:4508:24706 1:N:0:CATGTGACTG+ATGCGGATCC has more quality values than read characters.
libc++abi: terminating with uncaught exception of type int
(ERR): bowtie2-align died with signal 6 (ABRT)"
We'd appreciate any help you could give with this, thank you!


Make DetachedPublishedContent public

Currently DetachedPublishedContent is internal. I'm trying to see if I can register DetachedPublishedContent into the PublishedContentModelFactory for the Models Builder, but currently I can't do that.
Maybe use the same class for NestedContent and the Doc Type Grid Editor?

Closing issue, cross-posted on leekelleher/umbraco-nested-content#23
We can keep the discussion in one place. Any decision in NC will reflect in DTGE.


Add url scheme for building images

Mac users can use the url scheme 'kitematic:///' to open Kitematic and immediately start building the desired repo.
Signed-off-by: Colin Wiley<EMAIL_ADDRESS>

@AnkyrinRepeat Thanks for submitting this. We have code that was previously tested and passed security team checks. Can we see if we can re-use that code with your modifications? It will be better on our end.
Details in this PR: https://github.com/docker/kitematic/pull/383
We can still use the kitematic:/// url scheme
Thanks,
Michael Chiang
<EMAIL_ADDRESS>

Sure, I refactored it to use the 383 code. The URL scheme is now kitematic://repository/run// to bring up the 383 confirmation page to begin running a container.

Thanks! I will manually test this. @FrenchBen, @jeffdm or @elesant, mind helping to review the code as well?

Awesome! Taking a look

Took a first look - so far so good.

Took another look with some comments - sorry for the delay.

Thanks for the additional comments, I moved the name generation to NewContainerPull. It looks like all the CSS from PR 383 is still in the master branch in styles/new-container.less.

Sorry again for the delay! Did some end-to-end testing - very cool! A few comments on some edge cases, but overall looking great.


Update to libcudacxx 1.9 to match version found in CUDA Toolkit 12

Description
Update to version 1.9.0 as that is what is found in the CUDA 12 release
Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.
[x] The cmake-format.json is up to date with these changes.

@gpucibot merge


Fix duck type in MiddlewareListener constructor

The typehint in the MiddlewareListener constructor should be Container and not Application (must be a leftover from Silex 1.x).
It's instantiated from HttpKernelServiceProvider::subscribe(Container $app, EventDispatcherInterface $dispatcher).
(The failures are unrelated, due to #1510)

$this->app is passed to middleware, have you checked that those expect Container instances as well?

That's a very good point.
And it actually makes sense to pass the application to middlewares. I guess I didn't think this one through (I shouldn't push PRs late at night).
Sorry for the noise.


Extend sonarqube importer to collect "where is the issue" tab content

Extend sonarqube importer to collect "where is the issue" tab content (where the vulnerability details are).
In current sonarqube importer, only the content belonging to the tab "why is this an issue" is imported.
I propose to collect the "where is the issue" section, that contains the details of the vulnerability, since the "why is this an issue" tab just contains generic (and, frankly, mostly obvious) info, nothing about the specific portions of code affected by the issue.
For clarity, screenshots attached.
What is imported in dd:

Content in Sonarqube:

@kiblik

@xoda, I check the actual implementation. The part responsible for pulling data is here https://github.com/DefectDojo/django-DefectDojo/blob/dc20ee1bf9f99953b50c610bd9840053e8fd12f1/dojo/tools/sonarqube_api/api_client.py#L38-L53
Except of other parameters processed in the function SonarQubeAPI.import_issues(test), response from the API contains also values
"component": "XYZ:abc.py",
"textRange": {
    "startLine": 68,
    "endLine": 68,
...
},

We will need to pull data via SQ API endpoint api/sources/show which requires from, to and key. Values from previous API responses will be helpful here.
I found out, that there is available also the endpoint api/sources/scm which can provide information

Author of the commit
Datetime of the commit
Revision of the commit

for each line of code.
Questions (@xoda, your feedback is welcome):

I suppose that showing "wrong" lines without context is not the best. I would like to add also a couple of lines before and after. What is recommended value? ±5 lines?
Git data from scm endpoint could be useful but I'm not able to find how to put this information in markdown and keep it clean. Are we going to avoid them? Or any other recommendation?
class Finding supports many useful fields like steps_to_reproduce, files, sast_source_object, sast_sink_object or sast_source_file_path. Are we going to put lines of code to the description or to one of these fields?

Hey @kiblik,

I suppose that showing "wrong" lines without context is not the best. I would like to add also a couple of lines before and after. What is recommended value? ±5 lines?

Well, in my mind I had the idea that we should limit ourselves to import the data that is shown in sonarqube, and, thus, to show just what sonarqube is showing in that "where is the issue tab". I wouldn't do anything else than showing what sonarqube is showing (i.e. if sonarqube is showing just one line of code in the "where is my issue", we should show just one single line of code).
I've started looking at how this is handled in SQ it with a test run.
Turns out that SQ seem to use a different (undocumented? I couldn't find it from their website) API under the hood /api/sources/issue_snippets.
It works like this: provided in input a vulnerability uuid via GET, it replies out which lines we should show, their content (bummer: it's not raw content unfortunately, it has some HTML inside, we might have to get the raw source code from another api once we know the lines we should get from here). The information is even enriched with the scm data you mentioned.
Example GET:
GET /api/sources/issue_snippets?issueKey=BYM3dNQlGnWW-1YgBjBM HTTP/1.1

Response:
{
  "dummy_project:src/vulnerable/a.php": {
    "component": {
      "key": "dummy_project:src/vulnerable/a.php",
      "uuid": "BYM3dMtaGnWW-1YgBjBJ",
      "path": "src/vulnerable/a.php",
      "name": "a.php",
      "longName": "src/vulnerable/a.php",
      "q": "FIL",
      "project": "dummy_project",
      "projectName": "dummy_project",
      "measures": {
        "lines": "6.0",
        "coverage": "0.0",
        "issues": "1.0"
      }
    },
    "sources": [
      {
        "line": 1,
        "code": "<?php",
        "scmRevision": "",
        "scmAuthor": "",
        "scmDate": "2022-09-13T15:25:20+0000",
        "duplicated": false,
        "isNew": true
      },
      {
        "line": 2,
        "code": "",
        "scmRevision": "",
        "scmAuthor": "",
        "scmDate": "2022-09-13T15:25:20+0000",
        "duplicated": false,
        "isNew": true
      },
      {
        "line": 3,
        "code": "$variable = $_GET['x'];",
        "scmRevision": "",
        "scmAuthor": "",
        "scmDate": "2022-09-13T15:25:20+0000",
        "utLineHits": 0,
        "lineHits": 0,
        "duplicated": false,
        "isNew": true
      },
      {
        "line": 4,
        "code": "echo \"dummy echo\";",
        "scmRevision": "",
        "scmAuthor": "",
        "scmDate": "2022-09-13T15:25:20+0000",
        "utLineHits": 0,
        "lineHits": 0,
        "duplicated": false,
        "isNew": true
      },
      {
        "line": 5,
        "code": "eval($variable);",
        "scmRevision": "",
        "scmAuthor": "",
        "scmDate": "2022-09-13T15:25:20+0000",
        "utLineHits": 0,
        "lineHits": 0,
        "duplicated": false,
        "isNew": true
      },
      {
        "line": 6,
        "code": "",
        "scmRevision": "",
        "scmAuthor": "",
        "scmDate": "2022-09-13T15:25:20+0000",
        "duplicated": false,
        "isNew": true
      }
    ]
  }
}

Screenshot of what is shown in the GUI for clarity:

Git data from scm endpoint could be useful but I'm not able to find how to put this information in markdown and keep it clean.

Great question. I don't have a strong opinion on how to show it in markdown to make it look good.
Since I don't think we can add extra info on a fenced code block in defectdojo, I guess we will be forced to add this info just before the code block somehow.
We will need to experiment a little bit on the aesthetics of this.

Are we going to avoid them? Or any other recommendation?

Well, we might think to make scm info optional. I'm not sure if it's doable in this way, but I was thinking we might end up showing it only if some value is set in the Service Keys during the setup of DefectDojo's Product Setting API.
We already have BUG,VULNERABILITY,CODE_SMELL configurable in the extra fields - why shouldn't we add something like SCM or SCM_INFO?

class Finding supports many useful fields like steps_to_reproduce, files, sast_source_object, sast_sink_object or sast_source_file_path. Are we going to put lines of code to the description or to one of these fields?

Well, I was thinking to place everything in the Description, but I'm open to different ideas.
Thanks

After looking better at SQ documentation, the API is there, but is marked as internal, stating:
Use at your own risk; internal services are subject to change or removal without notice.
 Shall we use it anyway?

After looking better at SQ documentation, the API is there, but is marked as internal, stating:
Use at your own risk; internal services are subject to change or removal without notice.
 Shall we use it anyway? If we don't trust this, we could also make this whole new feature optional and in place only when a Service Key is set.

I would have no problem to use "internal" API endpoints for my project. But not for DefectDojo, which is open source, and you never know, who will have enough time to fix issues.
Plus, different users can use different versions of SonarQube which can mean different parameters or responses on the API, it could be a way to the hell to keep support for different versions of SonarQube.
I prefer to use only official endpoints.

Well, in my mind I had the idea that we should limit ourselves to import the data that is shown in sonarqube, and, thus, to show just what sonarqube is showing in that "where is the issue" tab. I wouldn't do anything else than showing what sonarqube is showing (i.e. if sonarqube is showing just one line of code in the "where is my issue", we should show just one single line of code).

"where is the issue" contains also a button to show the rest of the code () So you are able to see the whole file without leaving tab "where is the issue" :)
But I have no problem putting only code (it can be also multiple lines) where the vulnerability is. I just opened the discussion.

It works like this: provided in input a vulnerability uuid via GET, it replies out which lines we should show, their content (bummer: it's not raw content unfortunately, it has some HTML inside, we might have to get the raw source code from another api once we know the lines numbers). The information is even enriched with the scm data you mentioned.

DefectDojo is putting field description into
 so HTML code will not be rendered nicely :(

Well, we might think to make scm info optional. I'm not sure if it's doable in this way, but I was thinking we might end up showing it only if some value is set in the Service Keys during the setup of DefectDojo's Product Setting API.
We already have BUG,VULNERABILITY,CODE_SMELL configurable in the extra fields - why shouldn't we add something like SCM or SCM_INFO?

Optional? No problem.
I prefer extra fields.

I was thinking to place everything in the Description, but I'm open to different ideas!

Why not :)

I prefer to use only official endpoints.

Sure, that's reasonable.
I'm still not fully convinced about the idea of blindly adding +- 5 lines of code from the sink. I explored a little dd's codebase. Since we're using /api/issues/search in find_issues() method, could we take advantage of the issues.flows.locations?
Request:
GET /api/issues/search?issues=BYM3dNQlGnWW-1YgBjBM&types=BUG,VULNERABILITY,CODE_SMELL
Response
    "issues": [
      {
        "key": "BYM3dNQlGnWW-1YgBjBM",
        "rule": "phpsecurity:S5334",
        "severity": "BLOCKER",
        "component": "dummy_project:src/vulnerable/a.php",
        "project": "dummy_project",
        "hash": "25ef4d194ad143b5c870115505414e0a",
        "textRange": {
          "startLine": 5,
          "endLine": 5,
          "startOffset": 0,
          "endOffset": 15
        },
        "flows": [
          {
            "locations": [
              {
                "component": "dummy_project:src/vulnerable/a.php",
                "textRange": {
                  "startLine": 5,
                  "endLine": 5,
                  "startOffset": 0,
                  "endOffset": 15
                },
                "msg": "sink: tainted value is used to perform a security-sensitive operation"
              },
              {
                "component": "dummy_project:src/vulnerable/a.php",
                "textRange": {
                  "startLine": 3,
                  "endLine": 3,
                  "startOffset": 0,
                  "endOffset": 22
                },
                "msg": "tainted value is propagated"
              },
              {
                "component": "dummy_project:src/vulnerable/a.php",
                "textRange": {
                  "startLine": 3,
                  "endLine": 3,
                  "startOffset": 12,
                  "endOffset": 22
                },
                "msg": "source: this value can be controlled by the user"
              }
            ]
          }
        ],
        "resolution": "FIXED",
        "status": "CLOSED",
        "message": "Change this code to not dynamically execute code influenced by user-controlled data.",
        "effort": "30min",
        "debt": "30min",
        "author": "",
        "tags": [
          "cwe",
          "owasp-a1",
          "sans-top25-risky"
        ],
        "creationDate": "2022-09-13T15:25:20+0000",
        "updateDate": "2022-09-14T10:05:06+0000",
        "closeDate": "2022-09-14T10:05:06+0000",
        "type": "VULNERABILITY",
        "scope": "MAIN",
        "quickFixAvailable": false
      }
    ]

I was surprised how informative the issues.flows.locations seem to be here. What do you think to use this information and to import the matching source code lines from api/sources/show?
We have two options here:

Displaying the source code as several snippets of code (displaying also the messages about taint analysis and sinks)
Displaying the source code from the lowest startline-endline range to the highest one (but it could realistically happen that we will get a large amount of loc in some cases).

"where is the issue" contains also a button to show the rest of the code () So you are able to see the whole file without leaving tab "where is the issue" :)
But I have no problem putting only code (it can be also multiple lines) where the vulnerability is. I just opened the discussion.

Well, of course, something like that button () would be the best option. But I guess we would need to implement it from scratch in the frontend, or am I missing some feature already in defectdojo's frontend?

Optional? No problem.
I prefer extra fields.

Nice, so I guess scm will be optionally added above the code snippets. Again, I have very little experience about what we can do with defectdojo's frontend out of the box, so I guess I'll need to experiment a little to make it look good.

I played with it. Maybe I'm doing something wrong, but it seems like we're very limited in the frontend with code blocks (I don't know why, but even syntax highlighting seem to not be working properly).
There are some markdown libraries that are able to render metadata (like author field), but at this point I'd say that we're really far from there and this goes out of the context of the current issue. I might work with some defectdojo frontend expert to improve that part later on.
For the moment, I'd say that we should do what we can with the limited features we have. Placing the issue info in the description is already a great improvement imho.

Let's try to keep it simple.
I'm trying to show a tooltip (e.g. text) to keep the displayed info compact, but honestly I'm not sure if it's helpful or confusing. I didn't find any other way to do so in defectdojo yet. Feedback is welcome.
Taking the case I posted above, I'm thinking at a Description similar to the following:
## Why is this an issue

Applications that execute code dynamically should neutralize any externally-
provided values used to construct the code. Failure to do so could allow an
attacker to execute arbitrary code. This could enable a wide range of serious
attacks like accessing/modifying sensitive information or gain full system
access.

The mitigation strategy should be based on whitelisting of allowed values or
casting to safe types.

**Noncompliant Code Example**

    $data = $_GET["data"];
    eval("echo \$data;");

**Compliant Solution**

    $data = $_GET["data"];
    if (in_array($data, $whitelist)) {
      eval("echo \$data;");
    }

## Issue details

**Where**: [dummy_project:src/vulnerable/a.php](# "Component"), [3](# "Line(s)"), [12](# "startOffset")-[22](# "endOffset")
**Message**: source: this value can be controlled by the user

    $variable = $_GET['x'];

**Where**: [dummy_project:src/vulnerable/a.php](# "Component"), [3](# "Line(s)"), [0](# "startOffset")-[22](# "endOffset")
**Message**: tainted value is propagated

    $variable = $_GET['x'];

**Where**: [dummy_project:src/vulnerable/a.php](# "Component"), [5](# "Line(s)"), [0](# "startOffset")-[15](# "endOffset")
**Message**: sink: tainted value is used to perform a security-sensitive operation

    eval($variable);

### Suggested solution
Change this code to not dynamically execute code influenced by user-controlled data.

So, first section with the information from "Why is this an issue" (the one that is currently imported in the current version of dd), enriched by /api/issues/search API (and in particular the issues.flows.locations info) and  api/sources/show, as you were suggesting in the very first comment.
If the SCM option is set, next to **Where** and **Message** we place the commit author, date, and revision details

Hi @xoda and @kiblik ,
what if we generate a link in each DefectDojo finding to the original Sonarqube issue? The link could be generated through the tool configuration URL + project + issue id.

Hi @xoda and @kiblik , what if we generate a link in each DefectDojo finding to the original Sonarqube issue? The link could be generated through the tool configuration URL + project + issue id.

Do not fully solve issue but sounds like acceptable help.

I guess, this issue can be closed now @xoda

I guess, this issue can be closed now @xoda

I suppose that #8163 helped (the developer can easily jump to the SonarQube issue) but fetching a snippet of vulnerable code and putting it into the description of Dojo finding can increase user experience. So there still place for improvement.


Title: Target Game

Which pre-existing JavaScript project will you be working on?
#arcade
Describe your enhancement/improvement
A game in which you have to hit maximum number of targets within a given time frame
Made using HTML CSS and JS click on target to score a point
Anything you need to say to the Reviewers
A game in which you have to hit maximum number of targets within a given time frame
Made using HTML CSS and JS click on target to score a point
Add any other context or relevant screenshots about the enhancement here.

This one @swapnilsparsh

It was palnned or not ?

@codewithganeshhh Not accepting any new projects.

It repository was closed ?

@codewithganeshhh No


Make script for Xdebug launch config

Make script to setup Xdebug if configuration is not done in project.
Should be run at root of the project (in case the user setups multiple project in one workspace).

No need for this. VSCode generates out of the box the script perfect and works.
I will need to make instructions for how to do it the right way, best a video also.


Wildcard path rule backend routing

The documentation isn't clear on how requests will be routed to the backend with wildcard (*) path based matching.
If I have a path based rule for
/images/*
And a backend HTTP settings path of
/myimages/
When I send a request to
/images/image1.png
will it route to the backend at
/myimages/image1.png
?
What if I request
/images/collection1/myimage.png
Will it route to
/myimages/collection1/myimage.png
?
Or will all requests only route to
/myimages/
and ignore all parts of the path matched by the wildcard?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f2769aea-56d1-03aa-1949-9818d5ee3ba4
Version Independent ID: 25394ed7-b79d-1d85-03c2-0031b666635e
Content: Azure Application Gateway URL-based content routing overview
Content Source: articles/application-gateway/url-route-overview.md
Service: application-gateway
GitHub Login: @vhorne
Microsoft Alias: victorh

@brent-robinson  , Thank you for your feedback. We will investigate and get back to you shortly.

@brent-robinson ,
When I send a request to
/images/image1.png
will it route to the backend at
/myimages/image1.png                               --> This is correct.
What if I request
/images/collection1/myimage.png
Will it route to
/myimages/collection1/myimage.png       --> This is correct.
I have tested it in my environment.
Request from my browser: http://<IP_ADDRESS>/images/collection1/myimage.png
Taken a packet capture at the server:
Http: Request, GET /myimages/collection1/myimage.png
Let me know if you have any further questions.

@brent-robinson , Do you have any update for me?

Perfect. Thank you for confirming. This ticket can be closed.
On Tue, 31 Mar 2020, 12:11 pm KARTHIK SRINIVAS<EMAIL_ADDRESS>wrote:

@brent-robinson https://github.com/brent-robinson , Do you have any
update for me?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/51222#issuecomment-606337143,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABS3S5IV5RVMGQCK2PK5MCTRKE7MFANCNFSM4LWKVGEA
.


bug fix for mems

This removes a spurious connect statement generated by the VerilogMemDelays pass. After the following ConstProp pass, this can turn into an identity assignment (T_880 <= T_880), and this cyclic dependency can cause problems. The current Verilog emitter inadvertently hides this bug since its use of mutable state overwrites this bogus assignment.

Yes, it shouldn't be there. Thanks, Scott!


[v2.0.2] Moving the function missing exception to internals (support)

#17  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Haaabeeel and the rest of your teammates on  Graphite


Set user email as alias in posthog

Accidentally merged, but no harm is done.
I'll make a new branch once the ui will be ready


CAMEL-13483 File Component: Add option to fail startup when not having read permission on folder

Changes:
-add option startingDirectoryMustHaveAccess (checks read and write permission)
-add a new test
Your feedback would be appreciated :)

We would also need to exclude this option in the camel-ftp component as we may not have ftp client api to check for this.
So add it as excluded to ftp endpoint and its variations in camel-ftp, such as
https://github.com/apache/camel/blob/master/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/FtpEndpoint.java#L47

Thanks for the PR


proxy: cache range request in proxy

Did not try to full implement this, This pr is just for reviewing and discussion:

use groupcache to support cache invalidation
this cache could cache response for a single key.

@xiang90  To cache Range request, it seems that we must write an interval tree with max leaf numbers and lru? Or maybe you have any better ideas?

@xiang90  An interval tree with max leaf numbers and lru seems too complicated to me. We could also just cache response for Range request, instead of Get request(Get request is just a particular Range request). but it may waste some memory, since two Range may overlapping.

@mqliang We already have an interval rb-tree implementation in etcd: see https://github.com/coreos/etcd/blob/master/pkg/adt/interval_tree.go.
However, I think we can keep this simple today by just index the range query by key_endkey_revision, just as normal get query. Yes, if someone queries a sub-range, we will end up with double caching. But it is simple. We can start with this simple thing and see how it goes? /cc @heyitsanthony  idea?

@mqliang For interval tree thing, see my previous last comment. So yes, I agree. We can always make this better later. The cache is an implementation detail right now. The more important thing is probably to define the cache. What is the guarantee of the cache? For query with revision, we can easily say it always return the fresh data since the version is there. For query without revision, what is the freshness guarantee?
I would suggest it to be time-based invalidation. We can make it watch-based later.

@xiang90
Starting from simple stuff and then iterate sounds good to me

I would suggest it to be time-based invalidation

How about lru AND time-based. It's not difficult IMO: we could define a expire time when we insert a response into the cache. And the expiration could be lazy: if cache hit, but it already expired, then invalidate the cache and report cache missing. One benefit of lru is that user could configure the size of cache so that the cache will not use too many memory.

@mqliang
Ah. I do not think we need to evict anything from lru ourselves. If you are happy about my in-line comment, we only need to clean up the map from key to its most recent revision. And yes, it can be a lazy removal.

@xiang90 I'm not too concerned about double caching costs. On the other hand, reasoning about revisions and queries on a per key basis looks tricky (e.g., interpolating on Get(WithRev()) seems broken with the current code).
It's probably better to have something simple that obviously works (e.g., caching only exact request -> response, maybe with lru, maybe periodic cache drop) running first before getting smart about it.

It's probably better to have something simple that obviously works (e.g., caching only exact request -> response, maybe with lru, maybe periodic cache drop) running first before getting smart about it.

So you suggest that we do read-through if the revision is not provided?

@xiang90 rev=0 is still a request so it will be cached. The store revisions will be all over the place for rev=0, but the responses would be valid.
Next iteration could partition rev=0 and rev!=0 caches and have some way to update/expire rev=0 requests.

@xiang90 @heyitsanthony  cache the whole request->response sounds good to me. And I have several questions:

Do we plan to support run etcdproxy in standalone mode in long run? If we do, then etcdproxy should be compatible with the client right?
Dose the compaction operation ensure atomic？

If compaction is atomic(store stays unchanged if compaction failed, instead of part of the keys are compacted, and others not), when etcdproxy forward the request to etcd server, it should compact the local cache if server response succeeded and should not compact the local cache if server response failed.
If compaction is not atomic, we should always compact the local cache, even if server side response failed.

Do we plan to support run etcdproxy in standalone mode in long run? If we do, then etcdproxy should be compatible with the client, right?

Yes. The compatibility happens at API layer though. We use the same gRPC API as etcdserver.

Dose the compaction operation ensure atomic？

Yes. But from client point of view, even if we do not compact proxy's cache but compact the server, it does not really matter I think.

@xiang90 I try to import the groupcache package and update Godeps/vendor, but seems something goes wrong. Mind to help take a look?
➜  etcd git:(cache) ✗ go env
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/mqliang/Documents/NetEase/Etcd/Godeps:/Users/mqliang/Documents/NetEase/Etcd"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GO15VENDOREXPERIMENT="1"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fno-common"
CXX="clang++"
CGO_ENABLED="1"

➜  etcd git:(cache) ✗ pwd
/Users/mqliang/Documents/NetEase/Etcd/src/github.com/coreos/etcd
➜  etcd git:(cache) ✗ cd cmd
➜  cmd git:(cache) ✗ godep restore
➜  cmd git:(cache) ✗ cd ../
➜  etcd git:(cache) ✗ go get github.com/golang/groupcache/lru
➜  etcd git:(cache) ✗ rm -rf Godeps vendor
➜  etcd git:(cache) ✗ ln -s cmd/vendor vendor
➜  etcd git:(cache) ✗ godep save ./...

godep: Package (golang.org/x/tools/blog/atom) not found

@mqliang Try ./script/updatedep.sh instead?

@xiang90 Same result:
➜  etcd git:(cache) ✗ sh -x ./scripts/updatedep.sh
+ rm -rf Godeps vendor
+ ln -s cmd/vendor vendor
+ godep save ./...
godep: Package (golang.org/x/tools/blog/atom) not found
+ rm -rf cmd/Godeps
+ rm vendor
+ mv Godeps cmd/
mv: rename Godeps to cmd/Godeps: No such file or directory

It's really strange, I meet the same problem last time when I try to import tabwriter package.

after you do godep restore, is golang.org/x/tools/blog/atom in your gopath?

@xiang90

after you do godep restore, is golang.org/x/tools/blog/atom in your gopath?

Unfortunately, no. There is no the whole golang.org/x/tools actually

@mqliang Yeah currently Godep is quite broken with etcd. Workaround is just move all your GOPATH for the moment to somewhere else, and godep restore to get the clean dependencies and then get the new dependencies, and godep save.
I am planning to play with glide to see if we can make this process easier.

@gyuho What you suggested is what he did i think. Can you verify that it actually works for you now?

Ok, I will try to godep from his branch.

@mqliang I am not super worry about unit test for know. However, can you try to setup an etcd cluster with this cache enabled to make sure it works as expected. Thanks!

@mqliang Are you still working on this one?

@xiang90 Will update this soon.
I was thinking what should I do in the next step. Maybe: proxy watch the whole store from cluster member(by watching the root dir) so that make the local cache up to date. So the proxy could server all read requests and watch requests from local cache directly, without considering cache hit/miss?
BTW, should we add cache for the v2 proxy(the http_proxy)?

@xiang90 How can I bring up a local v3 etcd cluster? I run goreman -f Procfile start  but it seems that what I got was a v2 cluster(since etcdctlV3 can not work, but etcdctlV2 works fine).
BTW, how etcd server side decide run in v2 mode or v3 mode? I looks through the code, etcdctl decide v2/v3 by a "ETCDCTL_API" environment variable, but it seems etcd server will always run in v2 mode, (see https://github.com/coreos/etcd/blob/master/etcdmain/main.go#L36).

try current master. it will bring up a etcd server with v2 and v3. The code you refer is correct. It brings up etcd server or proxyv2.

I was thinking what should we do in the next step. Maybe: proxy watch the whole store from cluster member(by watching the root dir) to make the local cache up to date. So the proxy could server all read requests and watch requests from local cache directly, without considering cache hit/miss?

For this, you can simply bring up an etcd cluster and use mirror-make to mirror the key-space you want.
We can use https://github.com/coreos/etcd/blob/master/clientv3/mirror/syncer.go to implement this easily in proxy too. But this is probably a future step.

BTW, should we add cache for the v2 proxy(the http_proxy)?

We do not have any plan at our side. v2 proxy does not try to understand etcd request. It is a transparent gateway. probably you will need more work if you want to do it.

@xiang90 I may have falsely thinking the significance of etcd-proxy is read/write splitting: serve read requests from proxy local cache, forward write requests to cluster member.
If we already have etcd-mirror, why do we need etcd-proxy? Maybe etcd-proxy should works as a middleware for request forwarding: forward serializable read request and watch request to mirror, and forward other requests to cluster member?

@mqliang The mirror-etcd does not forward write. It is just a etcd server linked by a mirro-maker to another etcd server. It is a different thing than the proxy we are talking about here.
The responsibility of proxy is very clear:

cache read
write through write
colease watch
potentially namespace based sharding
watch based cache of a hot namespace

What you try to add into the cache is 5. And it is a longer term goal. We do not want to do it from day1.

@xiang
It seems we can make proxy a transparent layer which is dedicated to request forwarding(and potentially sharding in the future). If proxy/cluster member/mirror cooperate as following to implement read/write splitting, why should we need a cache in proxy layer?
					  +---------+
				      |	 client	|
					  +---------+
							|
							V
			+------------------------------+
			|			etcd-proxy         |
			+------------------------------+
				|						|
		write / |						| serializable read /
	quorum-read |						| watch requests
	requests	|						|
				|						|
				V						V
+-------------------+		sync	 +--------+
|	cluster-member	|--------------->| mirror |
+-------------------+				 +--------+

@mqliang Mirror is stateful (it is an etcdserver anyway) and has its cost. Proxy is stateless and easy to swap in and out. I would image to see most people just set up 10s of proxies and will handle their read/watch good enough. For the model you described, it is useful when you have a enough larger deployment or when sharding comes into play. These are all future plan. We now need to get the stateless proxy with caching/watch coalescing done. Then we can iterate on it.

xiang90
Mirror is stateful (it is an etcdserver anyway) and has its cost

Do you mean mirror will also write WAL log, make snapshot, etc. But proxy just sync store in it's RAM?

Do you mean mirror will also write WAL log, make snapshot, etc. But proxy just sync store in it's RAM?

Yes. Mirror is an full feature etcdserver. Proxy is just a stateless thing.

@mqliang Shall we resolve the merge conflicts and get this merged first? Then we can start to iterate on it?

@xiang90 Seems that we can not bring up a v3 proxy now, the current code only start a v2 http_proxy.

@mqliang Yes. You need to write a simple driver to bring it up. I can do it later this week after we get this pr merged.

cc/ @jerryzh168


Fix URL variations that can either crash or disable Checkmate

A URL like this: http:// or http:/evil.site can result in a null domain, which we then fail to check
This happens because in Via, the blocking is implemented as a wrapper around the whole service and so Via check's it's own URLs against the list. This interestingly means a significant amount of Via traffic is to the landing page.
This also allows people to evade the block by using dodgy URLs, that Chrome will still follow.
We need to:

[x] Prevent checkmate from having an unhandled crash - https://github.com/hypothesis/checkmate/pull/28
~Catch these at the checkmatelib level - https://github.com/hypothesis/checkmatelib/pull/2~
~Update checkmatelib in Via~
~Update checkmatelib in ViaHTML~

This is out of date now we are going to do very complicated normalisation

[x] Stop Via from attempting to check it's own landing page URL which is "/" because this makes no sense - https://github.com/hypothesis/via/pull/268
[x] Add web-risk normalisation routines: https://github.com/hypothesis/checkmate/pull/30
[x] Use web-risk normalisation to convert URLs before we check for them: https://github.com/hypothesis/checkmate/pull/31

Done!


EVA-1700 — fixes to trait mapping pipeline

Refactor & code cleanup

Traits are now processed in parallel, increasing performance (approx. 8× boost, from 0.5 traits/s to 4 traits/s)
Simplify retry policy for json_request, remove unnecessary helpers. Now using an external retry library
Configure correct handling of different error types; do not ignore any request errors unless directly specified.

Fixes for OxO queries

OxO requests now always use POST instead of GET
Do not try to query OxO when the identifier list is empty, as this causes predictable errors which show up in the logs
Correctly handle occasional OxO errors. There is a bug which I discovered and reported: https://github.com/EBISPOT/OXO/issues/26

Logs cleanup

Remove double warning for the same error when OLS didn't return a term label
Don't show expected OLS query errors for OMIM and MedGen ontologies (since those two are not present in OLS)
Demote "OxO no mappings found" from warning to debug level, because this by itself is not an error — OxO does not guarantee that any cross-refs will be found for any particular input term
Default logging level is now DEBUG. This provides the most information, while verbose DEBUG entries can be easily filtered out

Coverage increased (+0.1%) to 74.704% when pulling b26f05c38058fd3e3ee80a43da8d81460754d7ef on tskir:eva-1700-trait-mapping-fixes into 3610fb74fd199f2928c914facf048e9b543f7e5a on EBIvariation:master.

Merging after one approval as per discussion with @jmmut


[ERROR] Failed to start cassandra container, please check the logs

vanilla install on mac osx gets me this error and eventually with:
Warning: Using a password on the command line interface can be insecure. [ERROR] Cassandra container must be running or NODE_HOST environment variable must be set
docker ps only shows mysql as running

./bin/wasabi.sh remove
Fixed this.


ci: reduce disk space

I'm not sure that we can start with more disk space than we do now. It looks like we have about 20GB  free when the build starts. It seems like ASAN is starting to get very close to limit.
@htuch @dnoe what absurd hacks can we do here? Delete test binaries after test runs? Split into 2 CI runs?

P.S. I think the chance of getting more disk space on Travis is zero. That's not an option.

ASAN tests are failing already... :(
/usr/bin/ld.gold: fatal error: bazel-out/local-dbg/bin/external/envoy/test/server/http/admin_test: No space left on device

Here are some other/modified ideas to the above to work around this limit:

Dynamically link tests. We would need to modify the build of external deps to support this, plus there were some issues that came up when we used to do this in the early days of Bazel that I've since forgotten. Could be worth exploring again. This would also make the developer UX and Travis build times faster.

Run the single fat test binary that we use for coverage for ASAN (and other problematic builds).

Have test/main.cc perform a ::unlink(argv[0]); to cleanup after itself. This does evil things to the Bazel cache, but there may be some way to get this to work for the purpose of ephemeral Travis CI runs that always start clean.

I'd +1 the sentiment that we're starting to hit the point that we're throwing good engineering time after bad, when you combine the time spent looking into issues around both CPU and disk space usage on Travis. I know the plan is to get off Travis by EOY, could be worth trying to accelerate this.

BTW, if you want confirmation that it's the O(100) static binaries that are to blame for disk use, you can do ./ci/run_envoy_docker.sh 'rm -rf /build/tmp; ./ci/do_ci.sh bazel.asan; du -ka /build/tmp | sort -n and see results like:
262848  ./_bazel_bazel/400406edc57d332f0b9b805d2b8e33a1/execroot/envoy/bazel-out/local-dbg/bin/external/envoy/test/integration/http2_integration_test
263144  ./_bazel_bazel/400406edc57d332f0b9b805d2b8e33a1/execroot/envoy/bazel-out/local-dbg/bin/external/envoy/test/integration/http2_upstream_integration_test
263196  ./_bazel_bazel/400406edc57d332f0b9b805d2b8e33a1/execroot/envoy/bazel-out/local-dbg/bin/external/envoy/test/integration/tcp_proxy_integration_test
264648  ./_bazel_bazel/400406edc57d332f0b9b805d2b8e33a1/execroot/envoy/bazel-out/local-dbg/bin/external/envoy/test/integration/grpc_json_transcoder_integration_test


fix copying Global/Channel ffz emote after copying a ffz emote

when copying FFZ emotes such as "4House ZreknarF Keepo"
the name of the emote ( Image::getName() ) returns the "code +
Global/Channel ffz emote" instead of just the code of the emote
-> "4House
Channel FFZ Emote ZreknarF
Global FFZ Emote Keepo "
this fixes correct tooltiping the emote
(and is now in sync with bttv and twitch emotes in the same file)

👍


fix(docs): samples height

This is an attempt at computing the samples height a little bit more accurately.
See the Card Footer slot example for example.

Nice! Works?

I quickly tested the most visible examples and it seems ok (some of them still have a scrollbar but appear completely on my Windows Chrome though).
Not urgent, so if someone finds a problem, shout at me!


Create external table can't back and forth from the left bar

Azure Data Studio Version:

Steps to Reproduce:

Select Create external table
go until step 3
Click 1 from the left bar, then step 2 and step 3 are not clickable.

Expected:
If only brow the previous step, we should be able to switch among those steps.

Closing older issues.  Thanks for logging this suggestion!


Fixing Pay Invoice and Send Invoice articles

Details
These two articles look bad:
https://help.expensify.com/articles/new-expensify/expenses-&-payments/pay-an-invoice
https://help.expensify.com/articles/new-expensify/expenses-&-payments/Send-an-invoice
I'm hoping this PR will fix them. Per this Slack convo I added "{% include end-selector.html %}" below the mobile and desktop sections.
Fixed Issues
Hopefully I fixed the formatting issue so that the article looks correct. See screenshots below of what it currently looks like.
I think there will probably be other things that need to be fixed - it looks like the links are working but if we can at least fix the formatting then I can figure out what else needs to be fixed.
PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[X] I verified that all the inputs inside a form are aligned with each other.
[X] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

A preview of your ExpensifyHelp changes have been deployed to https://8a741651.helpdot.pages.dev ⚡

@Christinadobrzyn can you confirm using the preview of your changes that this looks the way you expect it to?

@blimpich thanks for referencing the preview, no it doesn't look right. Everything is grouped by the mobile or desktop. should I create a new PR to try and fix this? The article should look like this: https://8a741651.helpdot.pages.dev/articles/new-expensify/expenses-&-payments/Create-an-expense

Ah I see, lemme take a look at it for a minute and see if I can figure out why it looks so wonky

And if its easier for you just create a new PR and add me as the reviewer 👍

Okay, I created a new PR - https://github.com/Expensify/App/pull/48022 If you can take a peek. TY!


Error

I am getting Error: Exception: Error from AI package: Failed host lookup: 'api.brainfusion.ai'. I tried using my app on different phones different networks but still I am facing this error

Update your package to this latest version.
brain_fusion: ^0.0.9

still facing same error

still facing same error

can you give us more details or the code

Post your code here and let's check please.

I am getting Error: Exception: Error from AI package: Failed host lookup: 'api.brainfusion.ai'. I tried using my app on different phones different networks but still I am facing this error

If you are running the app on Android devices, you must add internet permission on AndroidManifest.xml.

Did it work for you?

Yes, but now there is another error with the API: Error from AI package: Exception: check queue code :404. It seems that the service is no longer working

Ok, For me too it was working before, but now, facing the same error

update to the latest version 0.1


doodleverse_utils should have more than one manager on pypi.org

I am the sole maintainer and administrator of doodleverse_utils. I propose we add at least one more person who can upload new versions
There are two possible roles for collaborators:

Maintainer
    Has permissions to Upload releases for a package. Can upload releases. Cannot invite collaborators. Cannot delete files, releases, or the project.
Owner
    Has permissions to Administer the entire project. Can upload releases. Can invite other collaborators. Can delete files, releases, or the entire project.

I propose adding @ebgoldstein and/or @2320sharon as a new 'Maintainer', which requires having a pypi account. Not a priority but leaving here as a reminder

How to update the doodleverse-utils pypi package
First, submit your local changes to github the usual way (git add/commit/push)
Second, on github, create a new release
Third, locally
git fetch
git checkout nameoftag (e.g. v0.0.1-beta)
python setup.py sdist bdist_wheel
twine upload dist/* --verbose
git switch -
git clean -xfd

that works for me... i made these instructions a wiki page


Question: Cordova 5.x / 6.x Support

Any plans on when Ripple is willing to support Cordova 5.x / 6.x ?

Same question from me.
+1


algorithm to make RG faster

I suspect RG spends a lot of time working through combinations that can be eliminated ahead of time.
E.g. consider a large ontology consisting of protein classes P and go terms T, where the two are linked by P subClassOf involvedIn some T, where T employs a rich RBox such that there are many interesting R some Ts, but there are no named R some Ps. We waste a lot of time if we materialize all R some Ps, we can filter ahead of time and determine there is no named classes inferred to be subclasses.
The following algorithm builds a reduced set of class expressions Xs to materialize:
Cs = bfsort(Ont.classes)
Rs = bfsort(Ont.properties
Excluded = {}
Xs = []
For r in Rs:
  For c in Cs:
    if exists r', c' such that r' in {parent(r),r} and c' in {parent(c),c} and Excludes[(r',c')]:
      Excluded[(r,c)] = True
      Break
    Else:
      Excluded[(r,c}] = |Reasoner.queryDescendants( r some c )| > 0
      Xs.append( r some c )

Intuitively this will give better results in many cases, but may come at a penalty of doing extra computation when Xs approximates the full Cs x Rs cross product. Benchmarks required!
As an aside, I still think the strategy of materializing R-some-Cs is a bit contorted, I suspect you will always get better performance by modeling the RG directly in the ABox and using simple property chains/rules e.g. R o SubClassOf -> R together with transitivity.. initial experiments with datalog suggest this is the case but not clear if performance is due to the datalog system (Souffle) or the differing strategies (TBox vs ABox)

actually my algorithm can be easily improved. There is no need to visit all elements of the cross-product. Just do a breadth of depth first search, but don't search any deeper if there are no computed subsumers. doh!
L = [ (topObjectProperty, owlThing) ]
E = [ <c sub reasoner.ancestors(c)>  for c in O.classes ]
while |L| > 0:
  r, c = pop L
  D = Reasoner.queryDescendants( r some c )
  if |D| > 0
    E += [<d r c> for d in D]
    L += { directChildren(p) x directChildren(c) }

I am not sure on the exact mechanism every reasoner users to calculate descendants, but there are some obvious pre-checks that could be done, e.g using range constraints, to avoid unneccessary calculation
note currently RG takes a very long time with the union of NCBITaxon+RO. In fact the whole procedure is unneccessary here due to zero existentials. My algorithm above will return zero results for descendants of "topProp some Thing" and calculate zero dynamic queries

Something like your algorithm is now implemented in #27. There is still a problem with the full NCBITaxon+RO, which is more due to the Whelk reasoning algorithm than with relation-graph. It has to do with a join order that's baked into the algorithm which turns out to be terrible when you query r some C and C has a vast number of subclasses (e.g. checking "topProp some Thing").

Further performance improvements in #64.


Update version.sbt

Please, @dialelo could you review? Thanks!

Current coverage is 69.74% (diff: 100%)

Merging #79 into master will not change coverage

@@             master        #79   diff @@
==========================================
  Files             8          8
  Lines           195        195
  Methods         190        190
  Messages          0          0
  Branches          5          5
==========================================
  Hits            136        136
  Misses           59         59
  Partials          0          0

Powered by Codecov. Last update 9f46a8b...e6c592e


Title bar show taxonomy name

Story:
Description
Change Nanobot to TDT with hyper link.
Taxonomy name should be displayed at the title bar next (right) to the action menus
Taxonomy name is: title (accession_id_prefix)

@dosumis should we add taxonomy_name and description the Cell Annotation Schema?

[ ] Check whether title and description accidentally dropped from CAS (in work on removing CAP specific fields) @dosumis
[ ] For datasets from CxG - pull Title from AnnData.
[ ] For others - get from config file.  Add to general metadata once CAS is fixed.


removing bgp asn with ydk-py

Trying to remove a BGP ASN with ydk-py using a crud.delete() method and it's saying an instance is already created (error coming from XR device).
Any examples you can share for updating / deleting router-id and ASN ?
Thanks,
Jason

Two examples deleting BGP config:

XR native model: https://git.io/vXQjd
OC model: https://git.io/vX7em

Interesting, this is exactly what was tried yesterday and the device responded back with a message saying an inst was already configured.
I suppose another question is, does a separate CRUDService instance need to be instantiated first?
crud = CRUDService()
crud.create(provider, bgp)
crud.delete(provider, bgp)

Should this work?
Or do we need to instantiate another object?
crud_c = CRUDService()
crud_c.create(provider, bgp)

crud = CRUDService()
crud.delete(provider, bgp)

I don't have access to my XR device now, but I'll try later too.

@jedelman8 , if you still are facing issues with your script, please let us know at https://communities.cisco.com/community/developer/ydk  I'll close this issue as this doesn't seem to be a YDK defect and those are tracked in the YDK-Gen repo any way.  Thanks.


Wech 35/bring storybook migration to main

What:
Rebase of next into WECH-21/support-react-18 in order to squash all commits related to the Storybook migration into one.

Why:
Once we have all of the Storybook migration in one commit we can more easily bring it into main, by doing that we'll be able to migrate to Storybook before we release Wave 2.0.

How:
Created this branch from WECH-21/support-react-18 and interactively rebased it with next, squashing all the commits related to Storybook migration into just one.
Checklist:

[x] Ready to be merged

@martimalek the target branch doesn't look right. Should it be main?

@martimalek the target branch doesn't look right. Should it be main?

Hey @nlopin, my idea was to create a PR pointing to WECH-21/support-react-18 with a rebase done so that the whole storybook migration would be in 1 commit, then when merging I expected to be able to merge the commits as they are, there are 2 problems to this though:

I had overlooked that when merging a PR in this repo we always "Squash and merge", meaning I'd lose the commits structure and further squash everything to 1 commit
The Storybook migration is not really finished, we still need to fix the bug that makes the font-family change in the docs and also we need to change the logo

I'll rebase this again and drop all commits not related to the Storybook migration and point it to main, also I'll add the items that we have left in the checklist of the PR description

I'll close this for now and reopen with a proper rebase


Attempt to resolve runtime issue

Resolves #1202

          1 Error

:no_entry_sign:
Any changes to library code need a summary in the Changelog.

  Generated by :no_entry_sign: Danger


CONTRIBUTING updates for CII badge items

These updates to CONTRIBUTING address two REQUIRED and one SUGGESTED CII badge items:

The information on how to contribute SHOULD include the requirements for acceptable contributions (e.g., a reference to any required coding standard). (URL required)
The project MUST publish the process for reporting vulnerabilities on the project site.
If private vulnerability reports are supported, the project MUST include how to send the information in a way that is kept private

Note: The<EMAIL_ADDRESS>address is not yet active. That work is in progress, so we should not merge this until it has been confirmed to be operational. @jmertic

Thanks Michael!


Hash is not deleted with image

Whenever I delete an image with the master delete code, if I later attempt to upload the same image, I get a broken link.
I would presume this is because it is attempting to link up the old hash, which still shows up in the hashes.csv.

Thx for the report


Add Elastic Container for Kubernetes Engine table. closes #104

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results
Add example SQL query results here (please include the input queries as well)

SETUP: tests/alicloud_elastic_container []

PRETEST: tests/alicloud_elastic_container

TEST: tests/alicloud_elastic_container
Running terraform
alicloud_vpc.named_test_resource: Creating...
alicloud_vpc.named_test_resource: Creation complete after 7s [id=vpc-0xis82rce4oojirzjc58c]
alicloud_vswitch.named_test_resource: Creating...
alicloud_vswitch.named_test_resource: Creation complete after 7s [id=vsw-0xib7x0gmd64bbm2tb8j5]
alicloud_cs_kubernetes.named_test_resource: Creating...
alicloud_cs_kubernetes.named_test_resource: Still creating... [10s elapsed]
alicloud_cs_kubernetes.named_test_resource: Still creating... [20s elapsed]
alicloud_cs_kubernetes.named_test_resource: Still creating... [30s elapsed]
alicloud_cs_kubernetes.named_test_resource: Still creating... [40s elapsed]
alicloud_cs_kubernetes.named_test_resource: Still creating... [50s elapsed]
alicloud_cs_kubernetes.named_test_resource: Still creating... [1m0s elapsed]
alicloud_cs_kubernetes.named_test_resource: Still creating... [1m10s elapsed]
alicloud_cs_kubernetes.named_test_resource: Still creating... [1m20s elapsed]
alicloud_cs_kubernetes.named_test_resource: Still creating... [1m30s elapsed]
alicloud_cs_kubernetes.named_test_resource: Still creating... [1m40s elapsed]
alicloud_cs_kubernetes.named_test_resource: Still creating... [1m50s elapsed]
alicloud_cs_kubernetes.named_test_resource: Still creating... [2m0s elapsed]
alicloud_cs_kubernetes.named_test_resource: Still creating... [2m10s elapsed]
alicloud_cs_kubernetes.named_test_resource: Still creating... [2m20s elapsed]
alicloud_cs_kubernetes.named_test_resource: Still creating... [2m30s elapsed]
alicloud_cs_kubernetes.named_test_resource: Still creating... [2m40s elapsed]
alicloud_cs_kubernetes.named_test_resource: Still creating... [2m50s elapsed]
alicloud_cs_kubernetes.named_test_resource: Still creating... [3m0s elapsed]
alicloud_cs_kubernetes.named_test_resource: Still creating... [3m10s elapsed]
alicloud_cs_kubernetes.named_test_resource: Still creating... [3m20s elapsed]
alicloud_cs_kubernetes.named_test_resource: Still creating... [3m30s elapsed]
alicloud_cs_kubernetes.named_test_resource: Still creating... [3m40s elapsed]
alicloud_cs_kubernetes.named_test_resource: Still creating... [3m50s elapsed]
alicloud_cs_kubernetes.named_test_resource: Still creating... [4m0s elapsed]
alicloud_cs_kubernetes.named_test_resource: Still creating... [4m10s elapsed]

Warning: Deprecated Resource

The null_data_source was historically used to construct intermediate values to
re-use elsewhere in configuration, the same can now be achieved using locals

Error: [ERROR] terraform-provider-alicloud/alicloud/resource_alicloud_cs_kubernetes.go:799: Resource id：cfc41d33c442d4015b81e2beec5012565 :
[ERROR] terraform-provider-alicloud/alicloud/service_alicloud_cs.go:317:
Failed to reach target status.


A few math dollars added. Also, add funding statement for Ariel in acknowledgments

I am also currently running the notebooks. So far 🚀

Yep. All the notebooks run and produce the expected output on my machine. 👍


Error handling: Wallet API version mismatch

When the wallet and Console are on different API versions, or there are API issues, the errors are helpful to someone who understands the API but not for a user who is just trying to complete a task.
Without completely removing the API details, these errors could help users a bit more. I've hit 2, but I'm sure there are plenty of others.
How about keeping some of the API error messaging but adding something above like ...
"The Vega Wallet software you are running doesn't support the JSON-RPC API. You can try to update the software you are using or choose a different compatible Vega wallet software."
This would be helpful for those situations where it's obviously the wrong wallet software version, or it needs API access it can't get because the wallet doesn't offer it.

The error messages from the wallet API have been drastically improved. Let's use them first, and improve those ones, before introducing a mapping. This is much more future-proof than a mapping.

another example from @ValentinTrinque

Error message could be:
The version of the wallet service running at ... is not supported.
Reason: It doesn't expose the API version 2.
Solution: Update the wallet software to a version that expose the API version 2.`

Scope of this task has been change according to conclusions from the thread: https://vegaprotocol.slack.com/archives/C8WS7M50E/p1674565800801239
Let's get rid of FE mapping errors, display error messages from the wallet api, Invalid wallet error has to stay, because it's just 404 on endpoint in wallet