ModuleNotFoundError: No module named 'torch.ao.pruning'

Instructions To Reproduce the 🐛 Bug:

Full runnable code or full changes you made:

If making changes to the project itself, please use output of the following command:
git rev-parse HEAD; git diff

<**I didn't make any changes to the code.**>

What exact command you run:
python demo.py --config-file faster_rcnn_fbnetv3a_C4.yaml --input input1.jpg --output output1.jpg
Full logs or other relevant observations:

<Traceback (most recent call last):
  File "demo.py", line 11, in <module>
    from d2go.model_zoo import model_zoo
  File "/data0/file_server/zh/exp/ifsod/d2go/d2go/model_zoo/model_zoo.py", line 7, in <module>
    from d2go.runner import create_runner
  File "/data0/file_server/zh/exp/ifsod/d2go/d2go/runner/__init__.py", line 9, in <module>
    from .default_runner import BaseRunner, Detectron2GoRunner, GeneralizedRCNNRunner
  File "/data0/file_server/zh/exp/ifsod/d2go/d2go/runner/default_runner.py", line 14, in <module>
    from d2go.checkpoint import FSDPCheckpointer, is_distributed_checkpoint
  File "/data0/file_server/zh/exp/ifsod/d2go/d2go/checkpoint/__init__.py", line 2, in <module>
    from .fsdp_checkpoint import FSDPCheckpointer
  File "/data0/file_server/zh/exp/ifsod/d2go/d2go/checkpoint/fsdp_checkpoint.py", line 9, in <module>
    from d2go.trainer.fsdp import FSDPWrapper
  File "/data0/file_server/zh/exp/ifsod/d2go/d2go/trainer/fsdp.py", line 16, in <module>
    from torch.ao.pruning import fqn_to_module
ModuleNotFoundError: No module named 'torch.ao.pruning'>

please simplify the steps as much as possible so they do not require additional resources to run, such as a private dataset.
The pytorch version is 1.13.1+cu116

Expected behavior:
If there are no obvious error in "what you observed" provided above,
please tell us the expected behavior.

The torch.ao.pruning module is added in PyTorch 2.0, anyway the best way to avoid such issue is probably using the PyTorch nightly build. I don't think you'll need to use fqn_to_module in your code, so comment that line out can be a workaround.

The torch.ao.pruning module is added in PyTorch 2.0, anyway the best way to avoid such issue is probably using the PyTorch nightly build. I don't think you'll need to use fqn_to_module in your code, so comment that line out can be a workaround.

The code works after I comment this line.
But I met another problem of import model_ema
when I add this line of code
from d2go.modeling import kmeans_anchors, model_ema
File "/data0/file_server/zh/exp/ifsod/sylph/runner/meta_fcos_runner.py", line 26, in
from d2go.modeling import kmeans_anchors, model_ema
ImportError: cannot import name 'model_ema' from 'd2go.modeling' (/data0/file_server/zh/exp/ifsod/d2go/d2go/modeling/init.py)
Should I change this to from d2go.modeling import ema？

Yes we renamed the model_ema.py to ema.py.

Yes we renamed the model_ema.py to ema.py.

Thanks a lot! :smiley:


Display min/max as int when dtype is int

Currently: tensor[256] x∈[2.000, 999.000] μ=496.613 σ=274.077 i64
Should be: tensor[256] x∈[2, 999] μ=496.613 σ=274.077 i64

I'll try and implement this!

At least in my current environment (conda environment on Windows 10, with Python 3.9), this works fine already, without changing anything.
I can't try this out on a Linux system at the moment, but can look into it next week.

You are right, sorry about this.
It used to be an issue, but looks like it solved itself when I moved the implementation into lovely-numpy.


Auto layout resets resizing to fixed height and width

Hi,
When we change from one spacing value to other value using tokens, the auto layout resizes to fixed height and fixed width rather than following the "Hug contents" which was already chosen. Its so annoying that every time we change, we have to fix it manually.

Also, when we edit the spacing value of MD from 16 to 24 and click on Update, it just resets all the components which are using that particular token. You can understand that we have to fix at all those numerous places in the design. :(.
This issue was not there in the previous release, this happened with a recent update (Not sure about the number).

This sounds odd, nothing regarding Auto Layout behaviour was changed. Will investigate tomorrow. You dont by chance have a screen recording documenting that weird behaviour? That could help a lot.

I have attached the screengrab here. Please take a look. Actually it resets, whenever I change any property. Just now noticed that even changing the color resets it.
https://user-images.githubusercontent.com/5101306/119920970-d7180600-bf8a-11eb-9964-7fb70402f3a4.mov

I have attached the screengrab here. Please take a look. Actually it resets, whenever I change any property. Just now noticed that even changing the color resets it.
ScreenGrab-.Autolayout.issue.mov

Thanks for the screengrab!
You do have a sizing.lg token set on your layers , remove that token from the layer and everything will work again.
Why does this happen? Whenever you set an auto layout layer that has Hug contents set to a specified width it will reset to "Fixed width". This is behaviour that comes from Figma, not from the plugin. It's perfectly correct as well, as you basically tell the plugin to keep that layer to a specified size, so it will do just that. In your example the sizing.lg layer is set to a size of 48, so your layers become resized to that size.
Closing this, feel free to reopen if it still persists.

Thank you for the clarification. Works fine after removing the sizing token.


Rethink unique sense ids for satellite adjectives

In adjs.all.txt:
$ grep "w: zippy" adjs.all.txt
w: zippy drf noun.attribute:zip
w: zippy

These do have lexid 0, which explains the lack of suffixes. They are also "disambiguated" as senses like this:
zippy%5:00:00:energetic:00 00874226 1 0
zippy%5:00:00:lively:00 00805309 2 0

So we may need to follow suit somehow.

OK, the problem is restricted to satellite adjectives and there are A LOT of them.  We need to rethink our strategy for unique sense ids for them.

I have a solution do this, but the simplest implementation requires fixing ALL lex_ids instead of "fixing" the duplicated ones.  The side effect to this is that we need to fix the equivalence mapping to sense keys.  Working on that next.

https://github.com/own-pt/wordnet-dsl/commit/808a1a3f65e13962b9cbac08ff6d925af25f917c fixes this but needs more testing before updating the files.

Why did we get changes in entries without any link to adjs?

Like I said the simpler solution was simply to regenerate all sense ids. As long as we are breaking compatibility with PWN, this is not a problem since we have a mapping file anyway.
Sent from my iPhone

On 30 Aug 2017, at 18:06, Alexandre Rademaker<EMAIL_ADDRESS>wrote:
Why did we get changes in entries without any link to adjs?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.


Extension should automatically select the correct targetArchitecture

Environment

OS: Windows ARM64
ARM64 .NET SDK installed
x64 .NET Runtime installed

Steps to reproduce

Create a new console app (dotnet new console)
Open the folder in VS Code and generate assets for build and debug
Add a Console.ReadLine() (or anything else to keep the app from immediately exiting)
Open a command prompt and run the app using the x64 dotnet.exe to run the dll as an x64 process instead of an ARM64
Attempt to attach

Expected  behavior
Attach should succeed
Actual behavior
Attach fails with Unable to start debugging. Failed to attach to process: The .NET debugger can only debug x64 processes.
Work around
Modify launch.json to add "targetArchitecture": "x86_64"

NOTE: @hajekj investigated (thanks!) and couldn't find an easy way to get the target architecture in Windows using the built-in tools, so this may require vsdbg.exe to add a --list-processs command line argument (or similar) on Windows.


[SPARK-38609][PYTHON] Add PYSPARK_PANDAS_USAGE_LOGGER environment variable as an alias of  KOALAS_USAGE_LOGGER

What changes were proposed in this pull request?
This PR proposes to add a new alias PYSPARK_PANDAS_USAGE_LOGGER for KOALAS_USAGE_LOGGER.
Why are the changes needed?
To avoid legacy name, Koalas.
Does this PR introduce any user-facing change?
Yes, uses can set PYSPARK_PANDAS_USAGE_LOGGER environment variable for using a usage logger.
How was this patch tested?
Manual positive tests:
PYSPARK_PANDAS_USAGE_LOGGER=pyspark.pandas.usage_logging.usage_logger ./bin/pyspark

>>> import pyspark.pandas as ps
>>> df = ps.range(1)
>>> import logging
>>> import sys
>>> root = logging.getLogger()
>>> root.setLevel(logging.INFO)
>>> handler = logging.StreamHandler(sys.stdout)
>>> handler.setLevel(logging.INFO)
>>> formatter = logging.Formatter('%(asctime)s - %(name)s - %(levelname)s - %(message)s')
>>> handler.setFormatter(formatter)
>>> root.addHandler(handler)
>>> df.id.sort_values()
...
INFO:pyspark.pandas.usage_logger:A function `DataFrame.__getattr__(self, key)` was successfully finished after 0.136 ms.
....

KOALAS_USAGE_LOGGER=pyspark.pandas.usage_logging.usage_logger ./bin/pyspark

>>> import pyspark.pandas as ps
>>> df = ps.range(1)
>>> import logging
>>> import sys
>>> root = logging.getLogger()
>>> root.setLevel(logging.INFO)
>>> handler = logging.StreamHandler(sys.stdout)
>>> handler.setLevel(logging.INFO)
>>> formatter = logging.Formatter('%(asctime)s - %(name)s - %(levelname)s - %(message)s')
>>> handler.setFormatter(formatter)
>>> root.addHandler(handler)
>>> df.id.sort_values()
...
2022-03-21 11:51:21,039 - pyspark.pandas.usage_logger - INFO - A function `DataFrame.__getattr__(self, key)` was successfully finished after 0.107 ms.
...

Manual negative tests:
PYSPARK_PANDAS_USAGE_LOGGER=abc ./bin/pyspark

>>> import pyspark.pandas as ps
WARNING:pyspark.pandas.usage_logger:Tried to attach usage logger `abc`, but an exception was raised: module 'abc' has no attribute 'get_logger'

KOALAS_USAGE_LOGGER=abc ./bin/pyspark

>>> import pyspark.pandas as ps
WARNING:pyspark.pandas.usage_logger:Tried to attach usage logger `abc`, but an exception was raised: module 'abc' has no attribute 'get_logger'

cc @ueshin and @itholic FYI.

Merged to master and branch-3.3.


test: test_download_remote_layers_api again

The test is still flaky, perhaps more after #5233, see #3831.
Allow for one more timeline_checkpoint after shutting down safekeepers before shutting down pageserver. Put more effort into not compacting or creating image layers.

After one attempt:

test_partial_evict_tenant[debug-pg16]

One flaky test per re-run..


Contiformer wont load config with Python 3.11 : annotation @configclass not supported

Using Python 3.11.
Installation and contiformer example as mentioned :
pip install .
python -m physiopro.entry.train docs/configs/contiformer_tpp.yml
Traceback (most recent call last):
File "   PhysioPro/physiopro/entry/train.py", line 13, in
@configclass
^^^^^^^^^^^
File "   anaconda3/lib/python3.11/site-packages/utilsd/config/python.py", line 126, in configclass
cls = dataclass(cls)
^^^^^^^^^^^^^^
File "anaconda3/lib/python3.11/dataclasses.py", line 815, in _get_field
raise ValueError(f'mutable default {type(f.default)} for field '
ValueError: mutable default <class 'utilsd.config.builtin.RuntimeConfig'> for field runtime is not allowed: use default_factory
This does not happen when installing physiopro in Python 3.8, 3.9 or 3.10 environnements.

Please use Python 3.10, thanks.

Fixed in #21


Update common files.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_client-go
24026cba814f62cc76fcfb2cc1b89847d234413f
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Needs https://github.com/istio/test-infra/pull/1861


Added timezone awareness in time variables throughout to fix time conversion issues.

dtbegin and dtend now contain timezone specified by the user in datafactory.

hi, this PR has conflicts with commits that are handling similar issues.
please make sure that the master branch hasn't already handled your issues.

hi, this PR has conflicts with commits that are handling similar issues.
please make sure that the master branch hasn't already handled your issues.

The master doesn't already solve the issue. I've fixed the conflict

The master doesn't already solve the issue. I've fixed the conflict


Create baidu_ocr_draw.py

Introduce Baidu OCR to better recognize Chinese

Thank you very much for your contribution! Having it working better for Chinese is a great fit, I will merge it and adapt to be able to have Baidu as an option

Done, there you go! https://github.com/rogeriochaves/driver/commit/59cf0f17a1dc3b6b48561e560874eaff5264b2a0
https://github.com/rogeriochaves/driver/assets/792201/aebacbd1-8d94-4857-a7ab-4cbe0f6bbafb
Thanks again for your contribution!


Get Source Build Step Does Not Allow for Wildcards Under “Default branch for manual and scheduled builds”

Environment
Environment: VSTS
Account Name: connectionseducation.visualstudio.com
Team Project Name: EnterpriseSoftwarePortfolio
Definition: Test - Webmail - E2E and Test - Webmail
Agent Queue: TestBP
Issue Description
We have a need for the “Default branch for manual and scheduled builds” option under the
“Get Sources” build step to allow for wildcard entries similarly to the “Trigger Branch” filter options.
We trigger our E2E builds based on the completion of our SPA builds.
Our SPA builds are run on a release branch or a hotfix branch.
Consequently our “Trigger Branch” filter options for our E2E test builds are set to wildcard
as release/*, or hotfix/*
When the “Get Sources” step within the E2E build runs it does not pull the needed branch from the previous triggering SPA build.
For example, I could have a SPA release branch called release/test_branch.
Upon completion of the SPA build, the E2E build will start, however, the E2E build will not pull the needed sources from release/test_branch, but rather from the repository specified under “Default branch for manual and scheduled builds”. (In our case develop branch)
Is it possible to alter the “Default branch for manual and scheduled builds” to allow for wildcard entry, or are there any known solutions for this problem??
Thanks
[Include task name(s), screenshots and any other relevant details]

That's correct .  The triggers support filters (because it's matching to trigger) but when it's scheduled or manually queued, there's no commit to filter against.  In those scenarios you need to define the branch to use.  There's nothing to filter (wildcard) against because the clock or the manual queue is the trigger.
That's by design.

Any workarounds? Maybe via a Powershell script method that runs after the Get Sources and points to our desired release??

Also we are talking about a build being released based on a release branch or hotfix branch not a manual trigger.

@bryanmacfarlane, I'm on the same team as @cwoodland. I'm not sure I understand your response. The subsequent build is triggered by completion of our SPA build, say release/test_branch, but when this automatic (not manual or scheduled) build occurs, it still sources from the default branch. In other words, when would the branch filters ever become effective?

I see.  It’s the triggering build.
Not a task issue ( svc not passing on trigger? ) but I’ll get to those folks

@bryanmacfarlane, thank you very much for reopening this!
Also, suppose there are multiple branches that would be applicable in the wildcards in both the primary SPA build and the subsequently-triggered End-to-End build. Humor us on having multiple concurrent release branches in this example, please:

/release/A
/release/B

Wildcards for both are release/*. release/B was just pushed to origin. The primary SPA build already successfully knows which sources to pull (B)**, but when the E2E build is triggered upon completion, would that build have awareness to also pull sources for B? Does that context convey as part of the trigger?
Aside from the questions at hand, for context, we have completely separated builds for a SPA and the E2E tests that are executed against that. We had reasons to disassociate E2E tasks from the SPA build and ended up with two builds, one being triggered by the other.

We have some work on our backlog soon so support an option on the build completion trigger - "Use the same branch as that of triggering build". That will be a better solution for your problem than changing the semantics of "default branch". This option makes complete sense if the same repository is used both in the triggering build and in the triggered build (as is the case in your example). We are debating if we need to do anything smarter (other than falling back to default branch) when the two repos are different. Thanks for the feedback.

@vijayma, yes, that's exactly what we are looking for! Is there a public timeline/backlog or another issue ID we can link to and subscribe to, please?

Thank you.  Please let us know if we can help in anyway.
This item is important to us, so if we can act as testers etc. please let us know.

Hi @vijayma and @bryanmacfarlane, is this still work in progress? Do you have a timeline on this? Thank you!

Hi @matkei, @simonua. We have this as a feature to implement on our backlog, but it is not scheduled to be implemented in the next couple of sprints.
As this is not a Tasks issue, I'm going to close this, but I have created this Developer Community thread to track it publicly. Please vote on it if it still interests you, as the "popularity" of posts is something we rely on when scheduling future features.


renamed static analysis to static-analysis-modules.

retest this please

retest this please

retest this please


REQUEST: New maintainer status for @wcs1only dapr/python-sdk

GitHub Username
@wcs1only
Formally requesting maintainer status for dapr/python-sdk.
Nominations by existing maintainers:
@artursouza
Requirements

[x] I have reviewed the community membership guidelines (https://github.com/dapr/community/blob/master/community-membership.md)
[x] I have enabled 2FA on my GitHub account. See https://github.com/settings/security
[x] I have subscribed to the Dapr community Discord server
[x] I am contributing (any of the following apply: issues, discussions, PRs, reviews) to 1 or more Dapr repositories

List of contributions to the Dapr project

PRs reviewed / authored

dapr/python-sdk: reviewed, authored. A few selected highlights:

dapr/python-sdk#171
dapr/python-sdk#82
dapr/python-sdk#203

Issues responded to

dapr/python-sdk: issues

I approve this request.

Voted and approved.


Added file DAO overrides

Coverage increased (+0.08%) to 90.806% when pulling d54018451646cd5738f2c1fe1f74a184665eeb36 on feature/dao_overrides into ac2f112720a2f5cbbfb263856c34f0c448315096 on develop.

Coverage increased (+0.08%) to 90.806% when pulling d54018451646cd5738f2c1fe1f74a184665eeb36 on feature/dao_overrides into ac2f112720a2f5cbbfb263856c34f0c448315096 on develop.

Coverage increased (+0.08%) to 90.806% when pulling d54018451646cd5738f2c1fe1f74a184665eeb36 on feature/dao_overrides into ac2f112720a2f5cbbfb263856c34f0c448315096 on develop.


video: Screensaver inhibition

May be broken according to this log message:
Unable to Inhibit GNOME screensaver; probably running >= 2.91.91 gnome-screensaver which removed this API - org.freedesktop.DBus.Error.UnknownMethod: No such method 'Inhibit'

should probably implement this, should be easy to do a drop in replacement.


Example?

@erikras It seems you deleted the example, was it on accident?

It was intentional. The examples don't belong here (in master)  yet. They will live here eventually, but it was accidental that I put it here in the first place.
At the moment, the examples live here, although the docs are in a transition period (in flux :smile:) at the moment. So far there are no other examples than the ones demoed on the website.
Sorry for the confusion.


fix: move validation over from action

This moves the validation over from Brightspace/test-reporting-action to here so we can use it for report generation validation as well as have 1 spot for report schema and format helpers. Once this is in I'll move the action over to using the new helpers. I still want to rework this to be a bit more organized but this at least get's it all in 1 spot. Partially takes care of https://github.com/Brightspace/test-reporting-action/issues/53.

I'll resolve conflicts in a bit


nuget package is not strong named.

we need reference strong named dll, so can we sign the dll and push to nuget.

We don't strong name.
Use this if really needed:
https://github.com/dsplaisted/strongnamer


Can't seem to get it to work

Instead of writing the converted file, I'm getting a standard-icons folder in the output directory.
Can you tell me what I'm doing wrong?
http://youtu.be/sB995g7ptLY
Dave

@davegraham92120  Thanks for the heads up. It looks like some of the cheerio might have changed the way they handle files. I will take a look. of course I would also accept a PR :)

Closed with commit 032a8e004e29c08f681d2751e752e6e5a20dc8ab
@davegraham92120  if you are still having issues please open a new issue


CFE accepts objects with non-primitive equality as constants

The following code is accepted by the CFE, but a compile-time error is expected. Note that const A() is accepted even outside of record literals.
class A {
  const A();

  bool operator==(Object other) => false;
}

test() => const (A(), A());

test2() => const A();

The Kernel output is the following:
library /*isNonNullableByDefault*/;
import self as self;
import "dart:core" as core;

class A extends core::Object /*hasConstConstructor*/  {
  const constructor •() → self::A
    : super core::Object::•()
    ;
  operator ==(core::Object other) → core::bool
    return false;
}
static method test() → dynamic
  return #C2;
static method test2() → dynamic
  return #C1;
constants  {
  #C1 = self::A {}
  #C2 = (#C1, #C1)
}

I think the analyzer should also follow and report a hint.

This is not a problem. A class can have a constant constructor and be used in constant expressions, and still have an operator == that runs any code it wants. However, there should be an error if const A() is used in a situation where it is required to have a primitive operator ==, like const s = {A()};. I do get that error from both the CFE and the analyzer. I think it's fine!

This is not a problem. A class can have a constant constructor and be used in constant expressions, and still have an operator == that runs any code it wants. However, there should be an error if const A() is used in a situation where it is required to have a primitive operator ==, like const s = {A()};. I do get that error from both the CFE and the analyzer. I think it's fine!

Thanks for the clarification, Erik! I updated the text of the issue accordingly.


Issue 24 comment styles broken

the stars in the reviews are broken as a result of ripping out bootstrap some time ago. They need to be fixed.


Is this project dead?

There does not seem to be any activity for almost a year. Is this project dead?

No

Check other branches

Hey. There is work happening on the v0.22.0 branch of the project. The GraphQL engine is going through a massive overhaul which is taking a lil more time than expected.


fix(BOffcanvas): Fix regression in docs caused  by #1992

Describe the PR
This fixes an issue caused by #1992 where the overlay in BOffCanvas was not behaving as expected (see repro).
Revert to using BOverlay rather than manually setting up an overlay in BOffcanvas
I didn't dig further to see how hard it would be to get this working with out using the BOverlay component, I'm not sure that would be useful (possibly slightly better performance?)
Small replication
See the docs site against main:

A small replication or video walkthrough can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.
PR checklist

What kind of change does this PR introduce? (check at least one)

[x] Bugfix :bug: - fix(...)
[ ] Feature - feat(...)
[ ] ARIA accessibility - fix(...)
[ ] Documentation update - docs(...)
[ ] Other (please describe)

The PR fulfills these requirements:

[x] Pull request title and all commits follow the Conventional Commits convention or has an override in this pull request body This is very important, as the CHANGELOG is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied

I am not seeing an issue. How are you able to reproduce this?

Clean build from main. I've tried this on two different machines and done a git clean -d -f -x to clean the branch.  I guess I could try a new enlistment. But it reliably reproduced without these changes and these changes fix it, so I am struggling to figure out what I could be doing locally to induce the bug.
On the other hand, your changes are released, right? So one would expect the bug to show up on Introduction | BootstrapVueNext (bootstrap-vue-next.github.io)?

The issue is mainly related to backdrop becoming hide-backdrop. But its underlying system could be reworked to use the responsive prop, rather than the manual stuff its doing now

This looks like it fixes everything, probably.

This looks like it fixes everything, probably.

That gets the overlay stuff working, but it messes up the right sidebar

Try now

Try now

That gets everything but the styling of the right-nav toc. It looks like we don't have .offcanvas.offcanvas-start or .offcanvas.offfcanvas-end as parents of the toc.

I can fix this by adding .offcanvas.body to the list, but that feels kludgy.

I can fix this by adding .offcanvas.body to the list, but that feels kludgy.

Actually, I was making an assumption based on some previous exploration. The thing that's missing is offcanvas because there is an offcanvas-lg instead? Possible fix:

I can fix this by adding .offcanvas.body to the list, but that feels kludgy.

Actually, I was making an assumption based on some previous exploration. The thing that's missing is offcanvas because there is an offcanvas-lg instead? Possible fix:

I mean - this fixes the scenario I'm looking at, not sure about the robustness...

Yes. offcanvas-lg is the best substitute for what I did. Idrc about robustness in this case as it's unlikely the breakpoint will change

Yes. offcanvas-lg is the best substitute for what I did. Idrc about robustness in this case as it's unlikely the breakpoint will change

Okay - I pushed that change.  Thanks!


Do not override encoding set during initialisation

encoding set during initialisation of sax parser gets replaced to ASCII when parsing.
Fix: check if encoding has already been set.

Hi, there's a CI failure for this PR that I think is related, as it's an encoding test:
https://ci.nokogiri.org/teams/nokogiri-core/pipelines/nokogiri-pr/jobs/ruby-2.6-system/builds/60
I'd also like this PR to contain a test.

@flavorjones I am not sure if to mutate encoding while passing encoding via parse_io.
please give directions here.

The current CI failures are not due to this commit -- will take a look now.

ok - remaining failures would be addressed by a rebase onto master, regardless this is OK to merge ...
BUT I want to think about edge cases before doing so.

My issue was that even when i set encoding to 'UTF-8' when the parser is initialised, parser.parse was calling parse_io without encoding. This meant that encoding was getting changed to 'ASCII' as per the old code.
IMO parse_io api seems a bit weird since parse_file and parse_memory apis do not take an additional encoding argument, and neither does mutate the 'encoding' instance variable, where as parse_io is capable of mutating encoding.

Rebased again to try to get CI green ...

I've rebased this again onto current main

LGTM! Merging. Thank you for your patience!!!

I've credited you in the changelog in 243eab5. This will be in v1.14.0.


Added POC test cases for Avatar.test

Before submitting the PR:

[X] Does your PR reference an issue? If not, please chat to the team on Discord or GitHub before submission.
[X] Did you update and run tests before submission using npm run test?
[X] Does your branch follow our naming convention? If not, please amend the branch name using branch -m new-branch-name

What does your PR address?
Fixes #150
Improve automated test coverage and depth
Please briefly describe your changes here.
Introduced a new standard in automated testing, although can be improved more. Since i am new to writing automated tests for a UI Library, I couldn't quietly determine how "Deep" i needed to go. Nevertheless, I tried my best to adhere to the standards that Kent C Dodds and Testing-library has set to writing automated tests.
Notes :
I took certain initiatives for the current test cases for specific reasons, you can find a reference for each change/decision i took :

Removed props property in the config of render fn
Why to use jest-dom
Why to use user-event
Why I replaced most getByTestIds and class selectors short-version  - - long-version, very good read
Prioritizing screen/dom querying
Why I removed .toBeTruthy from most tests - The table in the link indicates that the getBy... automatically throw errors when the element isn't found

Nice to haves :

Accessibility testing - Jest-axe
Visual Regression Testing  - jest-image-snapshot
Better handling of testing Styles - Jest-dom
Better handling of testing User Interactions - testing-library/userEvent
Performance testing - Couldn't find a svelte example

@endigo9740 thanks for letting me know, and good luck! You guys are doing amazing work in this library.

Hey @amjadorfali, I've finally had a chance for a preliminary review. Just so you know, we're in mad sprint towards our v1.0 launch and focusing on a big series of documentation updates per:
https://github.com/skeletonlabs/skeleton/issues/783
Given this, our priority is 110% documentation right now. I am interested in improving our test cases, but this is not a blocking issue for us getting v1.0 out the door. Just so you're aware of where this resides as far as priority.
Also, thank you for taking the time to discuss your influence and document your references. This looks like astounding work. This is the most well documented PR we've received, bar none!
That said, I know our current test cases are barebones. I think we can agree there. But what you've done here is like on a whole other level. I'll be honest, I'm struggling to give this a proper review. Mainly because I don't really understanding everything going on yet. If I had more bandwidth right now I'd stop, educate myself, and return to this. Unfortunately time is now allowing for that right this second.
However, before we get into specifics, I want to take a step back and reflect on the overall goal here.  In fact I have a few concerns here:

I don't want to loose the fluidity for modifying the components. We still have a few minor adjustments, bug fixes, etc that I expect we'll make over the next few months. For us, v1.0 is not a maintenance freeze, and I worry that if our test cases are too extensive we're going to have a hard time maintaining them. With every subtle change potentially triggering a failure in the tests. Fragility is always something I worry about with extensive tests.
As a maintainer, I need to ensure that contributions are on a level playing field, meaning anyone can contribute. Right now I don't want to handicap us into a state that you're the only one capable of understanding and maintaining our test cases. I'm not sure anyone (including myself) can keep up with this. Which would put us in a bad way.
And really the most important bit IMO - we have to ask ourselves how much automated testing we need and want. There very much is such a thing as over testing. We can definitely test every bit of every feature, but at some point the return in investment diminishes. We end up painting ourself into a rigid box in some ways.

Honestly I wasn't opposed to the minimal testing we had. It is essentially a litmus test of "is X component functional right now", which is a great starting point. The area I most wanted to extend to was ensuring that properties are being receive and implemented as expected. We will typically have a good idea if the basics and defaults are working browsing the live components on the docs. However, if someone is using a component and supply a background prop, but that doesn't reach it's destination within the component, that's a problem, right?
So, I'll leave it here, and give you a chance to respond. But my gut is telling me we might need to circle back to this post v1.0 and get more of a community and group consensus on how far we want to go with testing. Testing is great, extensive testing is great, but there is something to be said for "K.I.S.S", if you know what I mean.
Would you be down for us opening this up for discussion in a more official capacity in the near future?

Hi @endigo9740, thanks for taking the time to review my PR. I'm glad to see that you've been pushing for documentation fixes lately, and I'm happy to help out with any other issues that need attention.
Regarding the tests I added, I understand your concerns about maintainability and fully agree with your points, it does seem like an overkill. However, I believe that testing UI components is important to ensure that they work as intended and don't break as changes are made. Here are some specific points to consider:

Testing the static classes cBase and cImg may not be necessary, as these are not user-bound and may change.
According to Kent C Dodds (he wrote @testing-library), "The more your tests resemble the way your software is used, the more confidence they can give you."
Snapshots can be a little useful, and are easy to maintain. In my experience, I have found that you can cover all test cases (needed) without using snapshots.

If you do a quick run at any test, and. type in screen.debug() in any it block, you would see the rendered HTML printed on the console. This is very useful and recommended to plan what needs to be tested.
I am not a QA engineer, and I have much to learn about automated testing. I would love to hear what others think about the best practices for unit testing UI libraries. Let's work together to figure out the best approach. Thanks again for your feedback!

I am not a QA engineer

You could have fooled me my friend :D But sounds good, I agree with your points above. I'll noodle on things in the meantime and we can give this the proper attention it deserves in the near future when I'm not running around putting out fires.
Thanks again!

@endigo9740
hahhaha I appreciate it 😅
Sounds awesome! Best of luck 🙏🏼

@amjadorfali again just letting you know I haven't forgot about you. This week has been all about ramping back up, collecting ourselves, and prepping for our future milestones for the project. We have a team meeting scheduled tomorrow and testing will be one of the items discussed.
I'll let you know where we fall on that asap.

@endigo9740 thanks for the update, i really appreciate it. And no worries at all, you guys have been doing some amazing stuff! I'm looking forward to what comes next, and how i can contribute further into Skeleton🎉🚀

@amjadorfali I'm so sorry this has taken me so long to get back to. But I wanted to share where we've landed after talking with the team. Essentially it's what I stated before, the quality of test as presented is top notch, but we feel this might be overkill for us and much harder to maintain over time.
Going forward I'll go ahead and close this PR out, but we'll have it for reference going forward. Nothing will be lost. Then when an opportunity presents itself we'll devote a bit more time and attention to testing.
I know testing is a great practice, but there's also the common saying that "startups shouldn't use automated tests" and I think that's where we fall right now. I hope you understand. Hopefully over time things solidify a bit more and more in depth testing will be more practical.
I appreciate your effort and patience all the same!

Hey @endigo9740 , I get that, it's understandable. Thanks for letting me know. I'll see where i can help elsewhere


autoscaler does not consider whether pod can schedule to node causing pending status

I'm running case1 in https://github.com/PaddlePaddle/cloud/issues/399
Non-terminated Pods:		(6 in total)
  Namespace			Name				CPU Requests	CPU Limits	Memory Requests	Memory Limits
  ---------			----				------------	----------	---------------	-------------
  kube-system			calico-node-qzn36		250m (2%)	0 (0%)		0 (0%)		0 (0%)
  wuyi05-baidu-com		mnist14-trainer-k22dp		2 (16%)		3 (25%)		8Gi (8%)	8Gi (8%)
  wuyi05-baidu-com		mnist15-trainer-z4s0r		2 (16%)		3 (25%)		8Gi (8%)	8Gi (8%)
  wuyi05-baidu-com		mnist17-trainer-wqrpz		2 (16%)		3 (25%)		8Gi (8%)	8Gi (8%)
  wuyi05-baidu-com		mnist5-pserver-fk552		2 (16%)		3 (25%)		5Gi (5%)	5Gi (5%)
  wuyi05-baidu-com		mnist9-pserver-vb1nz		2 (16%)		3 (25%)		5Gi (5%)	5Gi (5%)
Allocated resources:
  (Total limits may be over 100 percent, i.e., overcommitted.)
  CPU Requests	CPU Limits	Memory Requests	Memory Limits
  ------------	----------	---------------	-------------
  10250m (85%)	15 (125%)	34Gi (36%)	34Gi (36%)

node CPU Request is 10250m and pod request 2 cores (2000m), autoscaler is still scaling up in this case.

Thanks, I think autoscaler should compare with the idel resource and the job requests before scale up.
Will fix this bug.


Adding methods to mount removes component methods

Hey team,
Consider the following component:
<template>
    {{ obj }}
</template>

<script>
export default {
  props: { obj: { type: Object, required: true } },
  watch: {
    obj: {
      immediate: true,
      handler (obj) {
        this.myFunc(obj)
      }
    }
  },
  methods: {
    myFunc () {
      console.log('my func')
    }
  }
}
</script>

And the following test:
import TestWatch from '../../src/components/TestWatch.vue'
import { shallowMount } from '@vue/test-utils'

describe('TestWatch', () => {
    it('should not crash', () => {
        const wrapper = shallowMount(TestWatch, {
            props: {
                obj: {test : 1}
            },
            methods: {}
        })
    })
})

The test fails currently with

If methods: {} is commented out of the mount, it passes.
This behavior was introduced in rc.17

Initially i believe this was a problem with watchers, but testing out in minimal repro with a created hook we can reproduce the same error:
<template>
    {{ obj }}
</template>

<script>
export default {
  props: { obj: { type: Object, required: true } },
  //   watch: {
  //     obj: {
  //       immediate: true,
  //       handler (obj) {
  //         this.myFunc(obj)
  //       }
  //     }
  //   },
  methods: {
    myFunc () {
      console.log('my func')
    }
  },
  created () {
    this.myFunc()
  }
}
</script>

@marina-mosti Thank you for catching that. I believe methods: was deprecated along with setMethods
Definitely worth a workaround though

Should we throw an error if someone passes methods? It's an undefined behavior, I wouldn't expect it to do something, but looks like it currently does, probably because of this spread: https://github.com/vuejs/vue-test-utils-next/blob/master/src/mount.ts#L493

I like that idea @lmiller1990 :) an error would be so helpful for people like me that never realized it got deprecated. It was only being used in a very old component that never complained about anything until rc.17


After v3, how to access Dom7?

Here's what I have in methods, but also interested in learning how to do it on mounted(). Docs don't give me direction here.
const self = this;
const app = self.$f7;
const $$ = self.Dom7;

$$(".something").trigger("touchstart");

To clarify: there's no available window/global variable called DOM7.


feat: first pass of new tera-model layout

Description
Updated layout of tera-model.vue

removed model configuration table
deleted tera-model-editor component (which was the content you'd see in the model tab) and removed the remainder of its contents into tera-model-description
exact placement of diagrams/equations/observables are in flux so we'll handle those in a second pass
updated tera-asset.vue to have a new grey header

This PR should sync up with what @Jami159 is doing with the model-config operator changes, so we are not removing the config feature for 1/2 week.


Isolate and remove performance issues (should be no blocking async/await in ctx.do)

I noticed many of our services had slowed WAY down vs normal:
{
  "target": "https://api.cf",
  "first": 219,
  "min": 153,
  "p25": 192,
  "med": 205,
  "avg": 205,
  "p75": 219,
  "max": 231
}

My hypothesis was that something in ctx.do was slowing it down, so I made a test in api.cf:
router.all('*', async (req, env) => {
  const { searchParams } = new URL(req.url)
  if (!searchParams.has('test')) {
    const { user } = await env.CTX.fetch(req).then(res => res.json())
    req.user = user
  }
})

and that increased performance by 2000% ... so we need to isolate and resolve whatever is introducing slowness.  We should make sure we aren't doing anything async/await to block the thread ... ctx.do should be instant ... my initial suspicion is that this is related to the Analytics Engine stuff we added on Friday.
{
  "target": "https://api.cf?test",
  "first": 13,
  "min": 6,
  "p25": 7,
  "med": 8,
  "avg": 8.4,
  "p75": 10,
  "max": 13
}

I temporarily commented out the above code and the stats object from the return payload, because the latency introduced makes many of the chained services unusable

Yes, I just re-ran the perf tests and they dramatically improved:
{
  "target": "https://api.cf",
  "first": 11,
  "min": 8,
  "p25": 9,
  "med": 11,
  "avg": 11.55,
  "p75": 14,
  "max": 16
}

and
{
  "target": "https://api.cf?test",
  "first": 8,
  "min": 5,
  "p25": 6,
  "med": 7,
  "avg": 7.4,
  "p75": 8,
  "max": 12
}

from:
{
  "target": "https://api.cf/",
  "first": 219,
  "min": 153,
  "p25": 192,
  "med": 205,
  "avg": 205,
  "p75": 219,
  "max": 231
}

This means that ctx.do is adding 3-4ms of latency to the request ... which isn't horrible, but we should see if we can get it > 1ms or at least 1-2ms if at all possible ...


Bedrock support added

There is already PR for badrock here
https://github.com/coleam00/bolt.new-any-llm/pull/324
And it hit an issue where bedrock will be shown but there is no way to set it up in client.
Aka client ui for now allows only setting up api key.
Bedrock requires more parameters.
I did give it a try to fix in number of ways.
But its bit tricky.
I think I will give it a try later myself.

Seems like we need to make provider in the list dependant on presence of API keys on server for now.

Or, allow more complex UI for some providers that allows to add more then just field in UI/API key settings.

Both are bit tricky refactors.
I don't really want to show not working providers on client if API key was not set for them on server and is not possible to set from client.

Okay got it. But we can do it like if we we select amazon bedrock we will have more parameters so that way user can enter it.

Seems like you are pushing more things in same branch that are unrelated.
Should I close this PR?


setHeaders doesn't seem to change response header

I've been trying many different combinations of setHeaders, but am unable to make any modifications to the response header. As a test I am trying this:
const app = cors_proxy.createServer({
  originWhitelist: [], // Allow all origins
  requireHeader: ['origin', 'x-requested-with'],
  setHeaders: {
    "access-control-expose-headers" : "content-type,transfer-encoding,x-powered-by,connection,access-control-allow-origin,cache-control,date,expires,login-required,p3p,pragma,server,x-frame-options,x-cache,via,x-amz-cf-id,Access-Control-Allow-Credentials,x-final-url",
    "Access-Control-Allow-Credentials": "true",
    "x-powered-by": "CORS Anywhere",
    "access-control-allow-origin": "localhost"
  },
});

None of these headers become attached. Also require header does work fine.

Hi, I have the same problem, and I franky don't understand if it has been solved or not.
This is my configuration:
cors_proxy.createServer({
    originWhitelist: [], // Allow all origins
    requireHeader: ['origin', 'x-requested-with'],
    setHeaders  : {
        "access-control-allow-origin": "localhost"
    }
})
.listen(port, host, function() {
    console.log('Running CORS Anywhere on ' + host + ':' + port);
});

As you see, I'm using "setHeaders" to change the header access-control-allow-origin.
But I still see access-control-allow-origin: * in the response. Why?

First, the setHeaders option sets request headers, not response headers.
Secondly, you are not supposed to touch Access-Control-Allow-Origin, because that is handled by CORS Anywhere. The logic responsible for setting Access-Control-Allow-Origin: * is at:
https://github.com/Rob--W/cors-anywhere/blob/2ee31471ce3b624b5503bcc9c62fbe6783192c45/lib/cors-anywhere.js#L53

It might seem stupid, but my browsers are blocking Access-Control-Allow-Origin: * because i use fetch with credentials: true so the browser worries that I send cookies to the wrong domain.
 In production it will not be like this ...
However, I changed the code of withCORS and now I'm working

@musikele - like Rob said headers is for request. Use the fork i referenced above if you need more customization. It includes the ability to set responseHeaders as well as request headers.

@musikele @chrisdobler You can hard code the value of Access-Control-Allow-Origin of response headers: at /lib/cors-anywhere.js
For sure, no browsers (chrome, firefox, safari, Edge) accept Access-Control-Allow-Origin: * as in the HTTP response headers.
Access-Control-Allow-Origin: url should be equal to Origin: url from HTTP request headers, otherwise it creates an error like
HTTP request header => Origin: localhost
HTTP response header => Access-Control-Allow-Origin: localhost
Furthermore, other CORS response headers can mess up the system and return 403. That's why any other response like CORS-request-redirect should be deleted from response headers.

@dotbloup

For sure, no browsers (chrome, firefox, safari, Edge) accept Access-Control-Allow-Origin: * as in the HTTP response headers.

This statement is incorrect, because Access-Control-Allow-Origin: * is accepted, provided that the request is not using credentials:

withCredentials should false in XMLHttpRequest (default).
credentials should be omit in fetch (default)
The Access-Control-Allow-Credentials response header should NOT be true.

Omg, just add setResponseHeaders for any header we want to add. It's a developer package. I can't use the package for the same reason.

@ondrek See https://github.com/Rob--W/cors-anywhere/issues/102#issuecomment-355933612

What's your real use case for wanting to override the response headers?
(...) if a new PR comes in I am willing to accept it given a good use case.

Hi!
I have an use case.
I have a cache solution and I control it using cache headers (Cache-Control, Expires).
I need a possibility to add headers to response to handle it.
// It will be useful
setResponseHeaders: { 'cache-control': 'max-age=30' }

@fivitti The client can use fetch with cache to force certain caching behavior regardless of the response header: https://developer.mozilla.org/en-US/docs/Web/API/Request/cache

If anyone still has this problem, check this fork https://github.com/MANDA-LAWINE/cors-anywhere

@MANDA-LAWINE thank you for providing this fork.
@Rob--W I don't understand why you don't want to add this setResponseHeaders option? Its implementation is very straightforward and it's another useful feature to have for a number of cases hinted at above. I'm having a similar use case now where I would like to modify and add response headers, so I'll have to rely on the fork for now.

@Rob--W I don't understand why you don't want to add this setResponseHeaders option? Its implementation is very straightforward and it's another useful feature to have for a number of cases hinted at above. I'm having a similar use case now where I would like to modify and add response headers, so I'll have to rely on the fork for now.

I am willing to accept a PR with the setResponseHeaders option if a good use case is given.
The initial report here starts with an example of setting CORS headers, which would break the core functionality of this library (CORS Anywhere manages the selection of the response headers to get CORS to work correctly). Another person asked for caching behavior, and I suggested a client-side API to get the desired functionality independent of the server.

a use case:
cross-origin-resource-policy: same-origin
could be set to:
cross-origin-resource-policy: cross-origin
https://developer.mozilla.org/en-US/docs/Web/HTTP/Cross-Origin_Resource_Policy


Return energy consumption logic

So, this mod need some balance feature in term of energy consumption.

If you do this, I hope it will be compatible with more than just FE like the previous version.

It probably will be compatible with Forge Energy for forge and Tech Reborn energy for fabric, not sure, if I need to introduce more energy support :)

I was quite interested in running it alongside IC2 Classic, for that true nostalgic experience, but it didn't connect to its cables, and IC2C doesn't seem to have inbuilt energy conversion anymore.


Input in the Module of adsb library

i have a hex string of 28 bytes of adsb data. I am not able to use it in the modules.
e.g : adsb.sbs.aircraft.Aircraft(?????)

Yeah, this library is currently focused on working with ADSB messages produced by software that provides BaseStation-like output. Perhaps PyModeS might have what you are after.

Thank You!! PyModeS worked fine. I need to have my data in cat 21 asterix category(https://www.eurocontrol.int/publication/cat021-eurocontrol-specification-surveillance-data-exchange-asterix-part-12-category-21). While i decoded most of the parameters of the format.There are some i couldn't find.Have you noticed them
Surface Capabilities and Characteristics | Operational capabilities of the aircraft while on the ground.
Data Ages | Ages of the data provided.
Receiver ID | Designator of Ground Station in Distributed System.
Target Report Descriptor | Type and characteristics of the data as transmitted by a system.
Time of Applicability for Position | Time of applicability of the reported position, in the form of elapsed time since last midnight, expressed as UTC.
Time of Applicability for Velocity | Time of applicability (measurement) of the reported velocity, in the form of elapsed time since last midnight, expressed as UTC.
Geometric Height


add wdm update integration tests

-- add wdm conditional update integration test and unconditional update integration
test along with subscription.
-- add standalone wdm unconditional integration test without
subscription.
-- remove smoke check for wdm test since we should only rely on the log-check
in test application script, and reduce the log check confusion.
-- add NoSub enum value in WdmUpdateTiming, currently it include before
sub, during sub, and after sub, possibly it is good place to add no sub.
-- during no sub, MonitorClientCurrentState would be triggered when all
update iteracton completes.
-- with sub, update shutdown would be handled in existing sub shutdown
codepth.
-- delete the dead code in MockWdmSubscriptionInitiator.cpp and
MockWdmSubscriptionResponder.cpp.

Codecov Report

Merging #301 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
+ Coverage   54.29%   54.29%   +<.01%
==========================================
  Files         289      289
  Lines       56107    56107
==========================================
+ Hits        30461    30464       +3
+ Misses      25646    25643       -3

Impacted Files
Coverage Δ

src/test-apps/TestCASE.cpp
96.1% <0%> (+0.22%)
:arrow_up:

src/lib/profiles/security/WeaveCert.cpp
84.41% <0%> (+0.64%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 104666b...4e11ef9. Read the comment docs.

FYI: Qilin and Allen are going to help with WDM tests refactoring, I will let them know this PR.


Clarify Setty/Baggy and add examples

Resolves Items with negative weights are removed when coercing a Mixy to Setty/Baggy item in 6.d checklist.

Thanks!


Split html renderer in html-pd and html-quartz

quartz should be the default one for HTML

I decided that these modes are "styles" which could be extracted from renderers, so I close this one as a duplicate of #165


feat: automated pypi releases via github actions

The first thing I'd propose is a github action that pushes to pypi via github actions when a release is done on github. This was the biggest issue with the legacy project. People couldn't get their changes published so they lost interest quite soon.

I completely agree that automating the deployment process to PyPI via GitHub Actions is a critical step in ensuring the smooth operation and sustainability of scikit-multilearn-ng. This automation will certainly address one of the major challenges we faced with the legacy project, where changes were not promptly published, leading to diminished interest and contributions.
I'll try to work on this during the weekend and update this thread with my progress and any additional information as I proceed with the implementation. Please note that this is my first time setting this workflow up, so it might not be perfect at the first try.

@ChristianSch I managed to fix this now. Here is the new automatic release: https://pypi.org/project/scikit-multilearn-ng/


Hierarchical STA, hierarchical LVS, and routing obstructions.

The following features would be very useful and can be added to openlane2.

[ ] Hierarchical STA:
Instead of treating macros as black-box instances with liberty files in STA, gate-level netlists and spef files for the macros may be used. This script might be useful.
[ ]  Hierarchical LVS:
Instead of treating macros as black-box instances in GDS LVS, gate-level netlists for the macros may be used. This script might be usefull.
[ ]  PDN and Placement Obstructions:
Adding obstructions before PDN generation and before placement is useful in many cases.

To shed some light on why hierarchical STA specifically is taking so long: This is coming along with a set of refactors to do the following:

Explicitly specified timing corners as a combination of ((I)nterconnect, Transistor (P)roccess, (V)oltage, and (T)emperature)
The ability of the State object to incorporate N-deep dictionaries for particular design formats to support the above (with validation)
The ability of the Config object to incorporate dictionaries (for PDK objects) and complex data structures (for things like Macro definitions), all with desarialization and validation
A rewrite of various steps to:

Properly match timing corners with liberty and/or SPEF files
A reconfiguration of the OpenROAD.STA class structure

Given that hierarchical STA is now added, I will close this issue and open two new ones for the two other features.


Huge amount of tasks waiting on a single counter.

Continuing to improve my rasterizer, im trying to get it to parallelize better and safer.
I create a LOT of "vertex shader" tasks, wich act as producers (like 100 of them) and they store the triangles in a tiled screenspace data structure. This data structure has a lot of "tile" objects, each of them with a concurrent queue for its triangles.
When most of the triangle tasks have finished, i launch the pixel shader tasks, one per tile, wich take care of the rasterization. I launch one task per tile so it fills the 16 threads on my ryzen nicely (about 200 tasks).
Before, i would launch said tasks twice. First the launch in the middle of the vertex tasks, and then a second launch once all the vertex tasks have finished their work.
In that architecture, i would have 2 hard sync points, wich dont use the CPU effectively due to having to wait for all tasks to finish. One sync point per tile rendering batch. This gets me to about 70% cpu usage, due to the syncronization, and i wanted to improve that.
To improve that, i decided to launch only 1 task per tile instead of 2, but have the tasks wait on a counter if they empty the vertex queues. The atomic counter will be 1 while the vertex tasks are still doing work, but once the vertex tasks end, the atomic is set to 0. The idea is that if a tile render task ends its queue but the vertex shaders still havent finished (they might add more vertices to the queue) then the task just goes into waiting until all the vertex tasks have finished.
As that will end up with around 200 tasks waiting on a single counter, of course it doesnt work.
To make it work i tried to increase NUM_WAITING_FIBER_SLOTS from 4 to 256, and the system actually works now. While it actually works, its a massive hack and increases memory usage and doesnt get an speed improvement over the naive version before, in fact it goes a bit slower.
This is how a debug profile looks, you can see how the blue tasks start before the pink tasks have finished, and also you can see the white tasks (tile finish) only after the pink tasks end.

Comparing the profile with profiles before the new system, it looks like there is extra overhead when switching tasks or waiting (but not sure).
Is there a better way to do this ?

Not sure if I understood everything, but did you try having one task blocked (waiting) on the vertex_shaders_finished counter, and having that one task spawn all your pixel shader tasks? Otherwise this profile looks close to optimal to me, given that you will have a lull after your vertex tasks, since you have a sync point.

@martty  if i  wait for the vertex shader tasks to finish before launching the pixel shader tasks, then i have a sync point where all the threads are waiting for the last vertex shader task to finish, i want to avoid that. In that profile i actually launch the tasks before the vertex shaders are finished (you can see how blue starts before pink finishes)

Then I don't understand :). I was under the impression that you can only start shading after your are done with the vertex shaders? If you don't need a global barrier (eg. this restriction is only per tile), then why not launch the corresponding PS task from the VS task?

@martty I can start drawing without waiting for the vertex tasks to finish, but those tasks can prematuraly end. Thus why i launch the drawing tasks twice, with the second time be after the vertex tasks have fully finished.
The flow is something like:
                            VertexTasks-----------------50%---------------------------100%
MainTask->LaunchVertexTasks->Wait50%------->LaunchDraws->----Wait100%->SetAtomic
                                                                                DrawTasks(1)---->WaitAtomic-------->DrawTasks(2)---->End

Closed by mistake.
It could probably work if i add a single atomic counter per tile, thus tasks only wait 1 per counter (but then i have a lot of counters), instead of 200 tasks waiting on a single counter.

How about making the queuing and syncing data driven?
I assume the output of the vertex shaders are triangles in Normalized Coordinate Space. And they're bucketed into screenspace tiles. Create a single counter oer tile, when inserting triangles into the bucket, if there is enough for a Pixel shader wave invocation, launch a Task and increment the respective counter. When it finishes, decrement.
When you finish all the vertex shaders, "drain" the tile buckets by launching non-full pixel shader invocations. Increment per tile.
In a for loop, wait on all the tiles.
In this way, the only sync point is at the end of the draw call.

Unrelated to the core syncing problem, we could have the counters allocate if you have too many things waiting on them so that aren't hard limited or have to waste tons of space. The value that you set in the macro will  just be the size it takes if it doesn't allocate.

Thanks @RichieSams, you are right on the design. Will have a look at it. That sounds interesting.

@cwfitzgerald How would you protect the allocation from multiple thread access?

@RichieSams Personally I've been thinking a lot about atomic stack allocators. They are fairly simple as atomic thingamajigies go, and fit the job well. Common access pattern is to wait for zero, so almost all will clear at the same time.

This should be solved with the new waiting system in v2.0.0


Add VTKExodusFileReader PolyDataIO

Add a PolyDataIO based on the VTK::IOExodusmodule:
https://github.com/Kitware/VTK/tree/master/IO/Exodus
Steps (a complete example can be found here):

[x] Verify that the test suite runs and passes locally.
[x] Create src/Bindings/VTKExodusFileReader.cxx. This command line executable should accept the input filename as its first argument and the output filename as the second argument. It should use vtkJSONDataSetWriter to write the output.
[x] Add CMake configuration to build the command line executable at src/Bindings/CMakeLists.txt. Use this to build a native binary against a native VTK. Run it to verify that it behaves as expected.
[x] Upload a test dataset(s) to data.kitware.com and place their *.sha512 file at test/Input/. Add the file path(s) to test/CMakeList.txt.
[x] Add VTKExodusFileReader to src/PolyDataIOIndex.js.
[x] Add VTKExodusFileReader to CMakeLists.txt PolyDataIOPipelines and set polydataios_VTKExodusFileReader to vtkIOExodus.
[x] Add a description of the new supported file format(s) in doc/content/docs/polydata_formats.md.
[x] Add new supported file extensions to src/extensionToPolyDataIO.js.
[x] Based on the output on the local filesystem with the native binary in the first step, add test(s) and define expected output in test/readPolyDataLocalFileSyncTest.js.
[x] Run npm run build and npm run test; fix issues identified.
[x] Create a  PR! :taco: :tada: :rocket: :woman_singer:

The Exodus reader has a lot of options for selecting what to load. What's done is a first pass. At some point, if itk-js provides a way for readers to expose options, the Exodus reader could certainly use it.
For example, many Exodus files have data for multiple timesteps... which one should be loaded. Similarly, element blocks and side sets tend to overlap each other – loading both would cause z-fighting (rendering artifacts). Being able to select a set would be nice. Note that a lot of these options involve users inspecting what is present in the file and then making a selection. That would mean running the reader multiple times with different arguments to get metadata (perhaps as field data?) and then to produce output.


Add blog url as part of subtext of roadmap

Description
Add blog url as part of subtext of roadmap
Issues Resolved
[List any issues this PR will resolve]
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

This is a follow up to https://github.com/opensearch-project/project-website/pull/3362, please let me know if there is better way of doing this.
cc: @kaimmej
Thanks!

@peterzhuamazon
I like it.
By 'picture to the right' - do you mean the Triangle that is at the bottom right corner of the documentation dropdown?
Looks great on my end. It doesnt seem to interact with the triangle, and when I view it at different display-widths, I don't see any issues.

Hi @kaimmej .
The transparent part of the image covers part of the subtext.

I initially try to add the 2024-2025 substring with the anchor tag but my mouse cant click on it, due to that picture covers the anchor tag.

I tried to push my change to this PR but was unable to.
This is a z-index issue. We need to apply a lower z-index to the bottom right triangle, and a higher zindex to the content of the dropdown. This will bring the content of the dropdown forward and the link behavior should start working correctly.
I made a PR for this change https://github.com/opensearch-project/project-website/pull/3367


Add XDC (testnet and mainnet) to setup_service and price_service

Make sure these boxes are checked! 📦✅

[👍 ] You ran ./run_tests.sh
[👍] You ran pre-commit run -a
[👍] If you want to add your network to setup_service.py, provide a link to your
exists in safe-eth-py

https://github.com/safe-global/safe-eth-py/blob/master/gnosis/eth/ethereum_network.py#L45
https://github.com/safe-global/safe-deployments/pull/167
https://github.com/safe-global/safe-deployments/pull/166

@pkakelas @moisses89 How is work status of this PR ? I'm wait for the support of XDC blockchain in safe-transaction-service. #1300

@pkakelas @moisses89 How is work status of this PR ? I'm wait for the support of XDC blockchain in safe-transaction-service. #1300
@gzliudan I'll take a look to the chain name because I could see that safe-eth-py  currently use this value for the enum.
Anyway the block number should be the block when the contract was deployed, @pkakelas should take a look to this.

@moisses89 thanks for pointing that out. Since I couldn't find the exact block number from the yinfin or aponthem explorer, I used the latest block number without any safes deployed so that the indexer indexes all safes. But since we had the transactions written in the PR comment, I fixed those with the correct ones. Feel free to take a look now!
As for the network name, I just used what's in the safe-eth-py repo. Do you want me to change it?

@moisses89  Can we change TXDC_TESTNET to TXDC in safe-eth-py  ?

@gzliudan I'll take a look to the chain name because I could see that safe-eth-py  currently use this value for the enum. Anyway the block number should be the block when the contract was deployed, @pkakelas should take a look to this.

@moisses89 thanks for pointing that out. Since I couldn't find the exact block number from the yinfin or aponthem explorer, I used the latest block number without any safes deployed so that the indexer indexes all safes. But since we had the transactions written in the PR comment, I fixed those with the correct ones. Feel free to take a look now!
As for the network name, I just used what's in the safe-eth-py repo. Do you want me to change it?

@pkakelas looks good, can you add a test like here? https://github.com/safe-global/safe-transaction-service/pull/1129/files#diff-86ee222f1d8ee3ed82d34e182ad0791a1dcca9209e3bc0c5603f602785ace428R142 thanks

@pkakelas  Would you please add a test ? Thanks.

@pkakelas looks good, can you add a test like here? https://github.com/safe-global/safe-transaction-service/pull/1129/files#diff-86ee222f1d8ee3ed82d34e182ad0791a1dcca9209e3bc0c5603f602785ace428R142 thanks

@pkakelas @moisses89  The networks in https://github.com/safe-global/safe-eth-py/blob/master/gnosis/eth/ethereum_network.py are
    XINFIN_XDC_NETWORK = 50
    XDC_APOTHEM_NETWORK = 51

now. Shall we change network name in this PR also?

@pkakelas @moisses89 The networks names in https://github.com/safe-global/safe-eth-py/blob/master/gnosis/eth/ethereum_network.py are
    XINFIN_XDC_NETWORK = 50
    XDC_APOTHEM_NETWORK = 51

now. Shall we change network name in this PR also?

yes, the PR should be rebase and the names modified to the new ones.

@pkakelas  Would you please update network names and add a test ?

yes, the PR should be rebase and the names modified to the new ones.


A proper way to add dtbo to boot partition?

What is a recommended way to add dtbo files to boot partition?
For now I am doing it in local.conf:
KERNEL_DEVICETREE_append = "
overlays/rpi-backlight.dtbo
"
I am not sure if this is the proper way to do it.

We are generally trying to include them all but that is definitely a way to include some that are not currently available in all the supported kernel versions.


Error - SSH - Incorrrecect Credentials

Hello,
I am trying to use the MultiRun functionality for 2 VMs hosted in Azure. Both the servers have same password. I am executing the script via powershell 7.2.5 on a Windows 11 VDI. But i get below error -
ERROR    - SSH - Please check your credentials, unable to logon
Invoke-SSHCommand: C:\Users\nxf88094\Downloads\scripts\scripts\QualityCheck\QualityCheck.ps1:982
Line |
982 |  …  = Invoke-SSHCommand -Command $_command -SessionId $script:_SessionID
|                                                       ~~~~~~~~~~~~~~~~~~
| Cannot bind argument to parameter 'SessionId' because it is null.
Invoke-SSHCommand: C:\Users\nxf88094\Downloads\scripts\scripts\QualityCheck\QualityCheck.ps1:982
Line |
982 |  …  = Invoke-SSHCommand -Command $_command -SessionId $script:_SessionID
|                                                       ~~~~~~~~~~~~~~~~~~
| Cannot bind argument to parameter 'SessionId' because it is null.
Set-Variable: Missing an argument for parameter 'Value'. Specify a parameter of type 'System.Object' and try again.
Invoke-SSHCommand: C:\Users\nxf88094\Downloads\scripts\scripts\QualityCheck\QualityCheck.ps1:982
Similar to above error there are multiple issues.
Kindly let me know if you have any correction or something which i am missing.
Regards,
Suhas
error.docx

thanks Suhas, this issue will be fixed in next version

Thanks for the quick reply Phillip. Just to add the script helps a lot and can be used as a part of QA acceptance.

fixed in latest version


Xcode doesn't recognize linked libraries

I've created new project with react-native init ProjectName. Then i open project with Xcode.
But all reactnative linked libraries in Build Phases turn Red color. What's that problem ? Because Xcode build failed. It saied /bin/sh shell script invocation error.

@checkraiser - this script invocation error occurs because you're trying to build the project with a packager instance running each time - it's a bit annoying how that works right now but you just have to be sure to close it when you want to build it again (not required to just refresh JS in simulator).

@checkraiser could you please copy-paste detailed error description? You can find it by clicking on error message in the left pane in Xcode

Looks like packager thing has been fixed in #758

@checkraiser - ping me if this is still an issue! thanks for reporting :smile:

the same problem
shell script invocation error
/Users/FOODING/Library/Developer/Xcode/DerivedData/UIExplorer-almvrjqunvqtnidajmjweosvetil/Build/Intermediates/UIExplorer.build/Debug-iphonesimulator/UIExplorer.build/Script-68CD48B71D2BCB2C007E06A9.sh: line 3: /Users/FOODING/Desktop/React: No such file or directory


dosbox-x: Get Darwin icon working

Description of changes
Closes #302674
CC @pshirshov for testing
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Can we move more of the postPatch steps to within the darwin branch?

Can we move more of the postPatch steps to within the darwin branch?

We could move all of it to the Darwin branch, and only test that the patching works when & where we need it. That'll require a Darwin system to test if the patching still applies after i.e. an update though, which is why we generally avoid doing that (anecdotally: OfBorg exists, but the Darwin builders don't always cooperate).
Is there a strong opposition to running this on all platforms, i.e. because you can't test that the result actually works correctly on Darwin and doesn't affect Linux? Then I'd be fine with moving it.

No opposition, your call.


How to use types in functions?

Hey hey,
Let's say I have a Move module with a Board struct in it. I want to write a function in my frontend that takes in a Board as an argument. Is this possible with Surf? I suspect not since there is no actual codegen but I'm asking just in case.
Thanks!

Yeah probably easier to use a concrete example. I'm currently building chess on Aptos in my spare time. You can see I have a variety of structs in the module here: https://github.com/banool/aptos-chess/blob/main/move/sources/chess.move#L90.
I want to write many different functions that let me read these resources in a type safe way. For example, something like:
function boardToFen(board: Board): string {
    // todo
}

This is FEN btw: https://www.chess.com/terms/fen-chess.

@banool If you want to read a resource, you can do like this:
const { data } = await client.useABI(COIN_ABI).resource.CoinStore({
  type_arguments: ['0x1::aptos_coin::AptosCoin'],
  account: '0x1',
});

// Get property in the struct with type safety
console.log(data.frozen);

// It also works for nested struct type.
// The `coin` property's type is 0x1::coin::Coin<T0>
console.log(data.coin.value);

@banool in your case, you can do
const { data } = await client.useABI(CHESS_ABI).resource.Game({ account: "0x..." });
const board = data.board; // this is a type-safe Board

That's not the issue, the issue is once I have that resource I can't work with it in a type safe way in other functions easily:
const { game } = await client.useABI(CHESS_ABI).resource.Game({
  type_arguments: [],
  account: '0x123',
});

const getFen = boardToFen(game.board);

There is no way for me to declare in boardToFen what type I'm dealing with.

@banool We can provide a util type function to help with that: StructType<ABITable, ABI, StructName>. What do you think? We can add it tomorrow.

I think that'd be helpful but just to make sure, could you add an example demonstrating how you'd use it with my boardToFen function above?

@banool Ideally, after we add the new util type function, you can declare the function like this:
import { DefaultABITable } from "@thalalabs/surf/build/types/types";

function boardToFen(arg: StructType<DefaultABITable, CHESS_ABI, "Board"> ) {

}

Neat that looks good to me!

@banool Try the newest version, you can do like this:
import { DefaultABITable, ExtractStructType } from "@thalalabs/surf";
type ABITAble = DefaultABITable & {
  "your_contract_address::Chess": typeof CHESS_ABI;
};

type Board = ExtractStructType<ABITAble, typeof CHESS_ABI, "Board">

// or
type Game = ExtractStructType<ABITAble, typeof CHESS_ABI, "Game">
type Board = Game['board']

In IDE, those string could be get through auto-completion.

Awesome it works a treat.
One thing I notice is if you don't have the right module ID the type inference still proceeds but it misses a lot of information.
For example, this gives me rich type information:
type ABITAble = DefaultABITable & {
  "0x296102a3893d43e11de2aa142fbb126377120d7d71c246a2f95d5b4f3ba16b30::chess": typeof CHESS_ABI;
};

But this doesn't:
type ABITAble = DefaultABITable & {
  "0x296102a3893d43e11de2aa142fbb126377120d7d71c246a2f95d5b4f3ba16b30::Chess": typeof CHESS_ABI;
};

I would rather the second case be an error rather than it just degrade silently.

https://github.com/ThalaLabs/surf/pull/70


Mainly adjust heading levels in scheduling-framework.md

Performed actions below:

Tweak long lines
Adjust heading levels and capitalization

See preview please.

/retitle Update scheduling framework concept

/lgtm

/approve


[FEATURE] awaitRefetchQueries

This is very useful when you need to do it on sync way ;)
https://www.apollographql.com/docs/react/api/react-apollo.html#graphql-mutation-options-awaitRefetchQueries

You can use any apollo client option in this.$apollo.mutate().


Give ability to create incident to normal users

Description:
Is your feature request related to a problem? Please describe.
In order to create incident you need to have admin rights within Dispatch. Thats not sutable for us, because we need to provide helpdesk with ability to create incidents but without giving them too many provileges.
Describe the solution you'd like
Any user within Dispatch has an ability to create incidents and tasks. Alternatively add additional role, like "helpdesk" with limited (preferably customizable) access
Describe alternatives you've considered
Give some heldesks admin rights, but this solution is bad because our processes suppose any helpdesk has an ability to create incidents
DoD:
Add ability to create incidents to anyone who is registered in Dispatch

Why not having helpdesk use the incident reporting Web form at /<ORG_NAME>/incidents/report ?

Looking at the code, we don't have a permission dependency for creating incidents (see here), only for updating incidents (see here), which is what I think you are asking? For tasks we allow anyone to create and update them.

Oh, I think I know what's happening here.... I think it's a form validation issue. We're not enabling the save button until you fill out not only the required fields (title and description), but also the fields from project to reporter. I tested it locally with a user with Member permission.


Implement goroutines state monitor?

Sometimes there are cases, when goroutines states should be printed in console.
Similar functionality: hmdsefi/gowl
Usage proposal:
p := pool.New().WithMaxGoroutines(10).WithMonitor(monitor, time.Second)
p.Go(func(tp *threadParameter) (res interface{}, err error) {
    tp.setState("Doing work1...")
    err = work1()

    tp.setState("Doing work2...")
    res, err = work2()
    return
})

func monitor(ts []*threadState) error {
    return fmt.Fprintf(os.Stderr, "Thread states: %v", ts);
}

Also, a job can be a struct with method Go() instead of func(). It makes us able to send any data to a goroutine easy

I'm not sure it would be possible to design this in a way that is general enough to be broadly useful and without adding significant surface area to the the API of the library. For example, what if you need to know something other than a string? Or what if you don't want to monitor ever second, but instead you want to print to stderr every time a SIGHUP is sent?
I think this can be implemented more generally outside of the library in a way that doesn't significantly constrain a user's choice of how to monitor. The monitoring hooks can be passed in to the closure, then control is left in the hands of the user.
func main() {
	p := pool.New()
	states := make([]atomic.Value, 10)
	for i := 0; i < 10; i++ {
		i := i
		p.Go(func() {
			states[i].Store("Doing work 1...")
			time.Sleep(time.Second)
			states[i].Store("Doing work 2...")
			time.Sleep(time.Second)
		})
	}

	monitorCtx, cancelMonitor := context.WithCancel(context.Background())
	monitorPool := pool.New().WithContext(monitorCtx)
	monitorPool.Go(func(ctx context.Context) error {
		for {
			select {
			case <-ctx.Done():
				return nil
			case <-time.After(100 * time.Millisecond):
				for i := range states {
					fmt.Fprintf(os.Stderr, "%d: %s\n", i, states[i].Load())
				}
			}
		}
	})

	p.Wait()
	cancelMonitor()
	monitorPool.Wait()
}

Also, a job can be a struct with method Go() instead of func() (or even an interface with default struct-implementation)

You can already pretty easily do this just by passing the struct's method to the pool.Go() call.
type myTask struct {
	val int
}

func (t myTask) Run() {
	println(t.val)
}

func main() {
	p := pool.New()
	for i := 0; i < 10; i++ {
		task := myTask{i}
		p.Go(task.Run)
	}
	p.Wait()
}


1.9.x - ensure atlantis is wired properly on github installs

Overview
Based on tests, it seems atlantis is not properly wired into github installs.
The goal of this task is to ensure feature parity between gitlab/github installs, meaning that atlantis works as in gitlab inside a github installation.
Places of interest top review:
https://github.com/kubefirst/gitops-template/blob/main/terraform/vault/bootstrap/secrets.tf#L4

secrets loaded into atlantis

https://www.runatlantis.io/docs/server-configuration.html

Atlantis configs

https://github.com/kubefirst/gitops-template/blob/main/components/atlantis/application.yaml#L22

Atlantis helm values, initial setup properties.

PR is opened, waiting updates.


[ISSUE #5493] fix : npe caused by get item by logic offset if the target logicQueueMappingItem was out of date

closes https://github.com/apache/rocketmq/issues/5493

Codecov Report

Merging #5494 (1ed2056) into develop (cca25fc) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #5494      +/-   ##
=============================================
- Coverage      43.20%   43.16%   -0.05%
+ Complexity      8083     8072      -11
=============================================
  Files           1025     1025
  Lines          72232    72233       +1
  Branches        9563     9563
=============================================
- Hits           31211    31181      -30
- Misses         37071    37110      +39
+ Partials        3950     3942       -8

Impacted Files
Coverage Δ

...tmq/common/statictopic/TopicQueueMappingUtils.java
60.28% <0.00%> (-0.15%)
:arrow_down:

...rg/apache/rocketmq/common/stats/StatsSnapshot.java
84.61% <0.00%> (-15.39%)
:arrow_down:

...org/apache/rocketmq/common/stats/StatsItemSet.java
41.79% <0.00%> (-11.95%)
:arrow_down:

.../apache/rocketmq/common/stats/MomentStatsItem.java
38.09% <0.00%> (-9.53%)
:arrow_down:

...ache/rocketmq/common/stats/MomentStatsItemSet.java
39.13% <0.00%> (-8.70%)
:arrow_down:

...va/org/apache/rocketmq/common/stats/StatsItem.java
50.00% <0.00%> (-4.17%)
:arrow_down:

...mq/broker/topic/TopicQueueMappingCleanService.java
12.43% <0.00%> (-3.63%)
:arrow_down:

.../apache/rocketmq/store/ha/DefaultHAConnection.java
65.86% <0.00%> (-1.21%)
:arrow_down:

...a/org/apache/rocketmq/store/StoreStatsService.java
33.97% <0.00%> (-0.56%)
:arrow_down:

...che/rocketmq/acl/plain/PlainPermissionManager.java
78.22% <0.00%> (-0.54%)
:arrow_down:

... and 9 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


feat(flags): add read only shorthand flag

This PR aims to add a shorthand for the read-only flag of the cobra subcommand turso db tokens create,

@haaawk


[bug] onFileDropEvent function  does not work on win11 22H2  but it works on win10 21H2

Describe the bug
I am using the Win11 22H2 version for development, and tauri is the latest version. When I used the onFileDropEvent function, it did not trigger any listening. When I ran the same code on win10 21H2, everything worked normally。

but when I run the same code on win10 , it works!
This is the first time I have mentioned an issue on Github. If there are any unclear descriptions in those areas, please forgive me
Reproduction
No response
Expected behavior
I hope he can listen to files and drag them on Win11 22H2 normally
Platform and versions
not work :
Environment
  › OS: Windows 10.0.22621 X64
  › Webview2: 113.0.1774.42
  › MSVC:
      - Visual Studio Community 2022
  › Node.js: 18.16.0
  › npm: 9.5.1
  › pnpm: 8.2.0
  › yarn: Not installed!
  › rustup: 1.26.0
  › rustc: 1.71.0-nightly
  › cargo: 1.71.0-nightly
  › Rust toolchain: nightly-x86_64-pc-windows-msvc

Packages
  › @tauri-apps/cli [NPM]: 1.0.0 (outdated, latest: 1.3.1)
  › @tauri-apps/api [NPM]: Not installed!
  › tauri [RUST]: 1.3.0,
  › tauri-build [RUST]: 1.3.0,
  › tao [RUST]: 0.16.1,
  › wry [RUST]: 0.24.3,

App
  › build-type: bundle
  › CSP: unset
  › distDir: ../src
  › devPath: ../src

App directory structure
  ├─ .vscode
  ├─ node_modules
  ├─ src
  └─ src-tauri

work:
Environment
  › OS: Windows 10.0.19044 X64
  › Webview2: 113.0.1774.42
  › MSVC:
      - Visual Studio Community 2022
  › Node.js: 16.15.1
  › npm: 8.11.0
  › pnpm: Not installed!
  › yarn: 1.22.19
  › rustup: 1.26.0
  › rustc: 1.71.0-nightly
  › cargo: 1.71.0-nightly
  › Rust toolchain: nightly-x86_64-pc-windows-msvc

Packages
  › @tauri-apps/cli [NPM]: 1.0.2 (outdated, latest: 1.3.1)
  › @tauri-apps/api [NPM]: Not installed!
  › tauri [RUST]: 1.3.0,
  › tauri-build [RUST]: 1.3.0,
  › tao [RUST]: 0.16.1,
  › wry [RUST]: 0.24.3,

App
  › build-type: bundle
  › CSP: unset
  › distDir: ../src
  › devPath: ../src

App directory structure
  ├─ .vscode
  ├─ node_modules
  ├─ src
  └─ src-tauri

Stack trace
No response
Additional context
No response

I couldn't reproduce on the same windows version you have, please share a minimal reproduction


snapshot driver deletes "Active layer" during commit operation.

Expected behavior is same active layer can be used for multiple commits and removed independently.
Ref : snapshotter.go
This is also require to pass the transitivity tests for snapshot layers.

We are trying to figure out the right model here, I am going to propose an update which keeps the Commit implementations as is, but adds a new method for doing continuing work after taking a "snapshot" of an active.

This is proposed in #633, closing this issue


Add deploy to Firebase CDN on template's README (Closes #374)

A step by step guide to deploying a recent created react app (with create-react-app) to the Firebase CDN.

@gaearon You said in an issue that a PR explaining how to deploy to the Firebase CDN would be a good contribution, so i just sent a PR to solve it, feel free to comment about it.

Thanks! I'm a bit behind the schedule reviewing things, sorry for that.

Thanks!

@gaearon No problem, thank you for your time! :D


Remove from_transformers references from the documentation

cc @echarlaix , as we are deprecating this argument in favor of export.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


build_test tries to do a chgrp which doesn't work over nfs

chgrp: changing group of '/home/vagrant/src/radiasoft/rsconf/tests/pkcli/build_work/1/srv-tmp/host-new/v3.radia.run/logrotate.sh': Operation not permitted
chgrp: changing group of '/home/vagrant/src/radiasoft/rsconf/tests/pkcli/build_work/1/srv-tmp/host-new/v3.radia.run': Operation not permitted
chgrp: changing group of '/home/vagrant/src/radiasoft/rsconf/tests/pkcli/build_work/1/srv-tmp/host-new': Operation not permitted
FAILED

=================================== FAILURES ===================================
__________________________________ test_build __________________________________
Traceback (most recent call last):
  File "/home/vagrant/src/radiasoft/rsconf/tests/pkcli/build_test.py", line 25, in test_build
    build.default_command()
  File "/home/vagrant/src/radiasoft/rsconf/rsconf/pkcli/build.py", line 130, in default_command
    subprocess.check_call(["chgrp", "-R", db.cfg.srv_group, str(new_d)])
  File "/home/vagrant/.pyenv/versions/3.9.15/lib/python3.9/subprocess.py", line 373, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['chgrp', '-R', 'vagrant', '/home/vagrant/src/radiasoft/rsconf/tests/pkcli/build_work/1/srv-tmp/host-new']' returned non-zero exit status 1.
============================== 1 failed in 5.10s ===============================
error: FAILED=1 passed=0

@robnagler any idea how to fix this? It happens over NFS because operations as root aren't permitted

This is not running as root. The group is the current group so technically this is a no-op. However, production needs this feature. I don't think we want to add more in_dev_mode conditionals. It's just one more thing that can go wrong.
This is very specific to your dev environment. It's time to consider remote editing of files in PyCharm. Do you think you could try this?

I've got PyCharm working over ssh.


Orphan Threads after shutdown

After initiating a start of the dynamoDB
AmazonDynamoDB dynamodb = null; 		DynamoDBProxyServer server = null; 		System.getProperties().setProperty("sqlite4java.library.path", "build/libs"); 		try { 			final String[] localArgs = { "-inMemory", "-sharedDb", "-port", "4567" }; 			server = ServerRunner.createServerFromCommandLineArgs(localArgs); 			server.start(); 			dynamodb = new AmazonDynamoDBClient(); 			dynamodb.setEndpoint("http://localhost:4567");                        // Insert graph to dynamo                   } finally { 			// Stop the DynamoDB Local endpoint 			com.amazonaws.http.IdleConnectionReaper.shutdown(); 			if (dynamodb != null) { 				dynamodb.shutdown(); 			}if (server != null) { 				server.stop(); 			} 		} }
What we find is there are a couple of Titan threads that remain in the stack and hence the process never exits. Looking at the stack trace it seems there are a couple of processes in sleep which never exit. Can you please help us understand what might be going wrong

JVM may not shut down even if the main function ends (thread pools may be active elsewhere, the process may have started in daemon mode, etc). It is always good practice to call System.exit(0) when you want to be sure that the process dies at the end of your program. Make sure to close() the graph when you are done with it.


Added a topology status to the list all topologies ui.

While we're at it, could we also make it clear what the red font indicates?
Currently that's a bit of a mystery.
On Thu, Dec 29, 2016 at 12:07 PM cckellogg<EMAIL_ADDRESS>wrote:

[image: topologies-with-status]
https://cloud.githubusercontent.com/assets/240473/21553792/562c954a-cdbf-11e6-9d4e-ae85dceb5aab.png

You can view, comment on, or merge this pull request online at:
https://github.com/twitter/heron/pull/1646
Commit Summary

Added a topology status to the list all topologies ui.

File Changes

M
heron/tools/tracker/src/python/handlers/stateshandler.py
https://github.com/twitter/heron/pull/1646/files#diff-0
(4)

M
heron/tools/tracker/src/python/handlers/topologieshandler.py
https://github.com/twitter/heron/pull/1646/files#diff-1
(8)

M
heron/tools/tracker/src/python/topology.py
https://github.com/twitter/heron/pull/1646/files#diff-2
(20)

M
heron/tools/tracker/src/python/tracker.py
https://github.com/twitter/heron/pull/1646/files#diff-3
(15)

M
heron/tools/ui/resources/static/js/alltopologies.js
https://github.com/twitter/heron/pull/1646/files#diff-4
(11)
Patch Links:

https://github.com/twitter/heron/pull/1646.patch

https://github.com/twitter/heron/pull/1646.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/twitter/heron/pull/1646, or mute the thread
https://github.com/notifications/unsubscribe-auth/AABczhCcwBM5CFnshzO8qlDhfgg6PLhCks5rNBL3gaJpZM4LX0Lm
.

Can we address the font colors in another patch? This was preexisting code and I'm not sure what it means either. Here the code for the colors (https://github.com/twitter/heron/blob/master/heron/tools/ui/resources/static/js/alltopologies.js) lines 20 - 31.

@cckellogg - let us do another patch to appropriately report the status of the topologies in red

@billonahill - the proposal is to change the color from RED to normal and display the state as 'ORPHANED'. @cckellogg is doing it in a different PR. Any suggestions for this state other than 'ORPHANED'?

@kramasamy the states we currently show align with the documented Heron states that users control via the Heron cli. Since 'ORPHANED' is not one of those, my concern is that it's meaning would also not be understood by a typical user. Somehow we need to convey exactly what is meant by orphaned or red-font. I'm open for UI suggestions for how to do that though, but I think it might need more of an explanation somewhere on the page.


Test for 'security.txt' does not follow redirect?

Version: 1.1.1
It looks like the 'Security.txt exists and is a text file that contains required attributes' test does not follow redirects. Like, for example, when test.example is used as the domain, and https://test.example/.well-known/security.txt redirects to https://www.test.example/.well-known/security.txt, the test fails.
Since other tests do seem to follow redirects, and the spec suggests [1] that redirects can be expected, perhaps it would be possible to follow them here as as well?
Cheers!
[1] https://www.rfc-editor.org/rfc/rfc9116#name-location-of-the-securitytxt

Thanks for the report, and thanks for checking out this tool!
I've just tested this with "www.github.com" as the domain and I'm seeing what I expect here.
https://www.github.com/.well-known/security.txt redirects to https://github.com/.well-known/security.txt which has valid content. Under the hood here the HTTP library (urllib) should follow 3xx redirects automatically.
If you could, would you be able to share the about of curl -i for the security.txt file that you are expecting to redirect? Perhaps it's not a standard redirect for some reason.
> curl -i https://www.github.com/.well-known/security.txt
HTTP/2 301
content-length: 0
location: https://github.com/.well-known/security.txt

Hmm, I'll verify with a different domain, perhaps I overlooked something somewhere.