Very bad ADO.NET performance on Linux

First time reporter - so please let me know if I am missing some important information.
We are investigating a very bad performance characteristics on Linux. It seems it has something to do with the SqlConnection handling.

.NET 5
Azure App Service
Same code runs on Windows very well (same configurations, even with more traffic)
Affected both databases our app connected to
Database usage levels are both very low (<10%). We don't see any particularly slow query.
In a particular memory dump, we see about 950 threads stuck in this same stacktrace:

00007F5EC7F2A838 00007f65d61873f9 [HelperMethodFrame: 00007f5ec7f2a838] System.Threading.WaitHandle.WaitMultipleIgnoringSyncContext(IntPtr*, Int32, Boolean, Int32)
00007F5EC7F2A980 00007f65667dfa86 System.Threading.WaitHandle.WaitMultiple(System.ReadOnlySpan`1<System.Threading.WaitHandle>, Boolean, Int32)
00007F5EC7F2AA00 00007f6562ee7b96 Microsoft.Data.ProviderBase.DbConnectionPool.TryGetConnection(System.Data.Common.DbConnection, UInt32, Boolean, Boolean, Microsoft.Data.Common.DbConnectionOptions, Microsoft.Data.ProviderBase.DbConnectionInternal ByRef) [/_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/ProviderBase/DbConnectionPool.cs @ 1172]
00007F5EC7F2AA80 00007f65667df0d7 Microsoft.Data.ProviderBase.DbConnectionPool.TryGetConnection(System.Data.Common.DbConnection, System.Threading.Tasks.TaskCompletionSource`1<Microsoft.Data.ProviderBase.DbConnectionInternal>, Microsoft.Data.Common.DbConnectionOptions, Microsoft.Data.ProviderBase.DbConnectionInternal ByRef) [/_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/ProviderBase/DbConnectionPool.cs @ 1142]
00007F5EC7F2AAE0 00007f6562ee553b Microsoft.Data.ProviderBase.DbConnectionFactory.TryGetConnection(System.Data.Common.DbConnection, System.Threading.Tasks.TaskCompletionSource`1<Microsoft.Data.ProviderBase.DbConnectionInternal>, Microsoft.Data.Common.DbConnectionOptions, Microsoft.Data.ProviderBase.DbConnectionInternal, Microsoft.Data.ProviderBase.DbConnectionInternal ByRef) [/_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/ProviderBase/DbConnectionFactory.cs @ 121]
00007F5EC7F2AB70 00007f65667dea2b Microsoft.Data.ProviderBase.DbConnectionInternal.TryOpenConnectionInternal(System.Data.Common.DbConnection, Microsoft.Data.ProviderBase.DbConnectionFactory, System.Threading.Tasks.TaskCompletionSource`1<Microsoft.Data.ProviderBase.DbConnectionInternal>, Microsoft.Data.Common.DbConnectionOptions) [/_/src/Microsoft.Data.SqlClient/netcore/src/Common/src/Microsoft/Data/ProviderBase/DbConnectionInternal.cs @ 347]
00007F5EC7F2ABC0 00007f65667de80c Microsoft.Data.SqlClient.SqlConnection.TryOpen(System.Threading.Tasks.TaskCompletionSource`1<Microsoft.Data.ProviderBase.DbConnectionInternal>, Microsoft.Data.SqlClient.SqlConnectionOverrides) [/_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs @ 1721]
00007F5EC7F2AC00 00007f65667ddbe7 Microsoft.Data.SqlClient.SqlConnection.Open(Microsoft.Data.SqlClient.SqlConnectionOverrides) [/_/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs @ 1211]

Any idea if this might already be known? What next step should we do to investigate?

Recreated from https://github.com/microsoft/dotnet/issues/1318

Make sure you are either closing or disposing SqlConnection objects (by wrapping them into using statement)

Are you trying to open large numbers of connections simultaneously?

Shot in the dark. Try increasing the size of your threadpool minimum to something like 100 and see if it helps.

by threadpool you probably meant the sql connection pool? I tried with 200 and 300 and it did not help. the pool will be flooded eventually

No, I mean ThreadPool. The native and managed implementations of the SNI layer have different ways of dealing with waits and the managed on relies on the threadpool for callbacks, if you saturate the threadpool workers things stop working. If that's the case here then upping the minimum available threads alleviates it by starting the threadpool much higher, default is 10 i'd suggest bumping it up to 100.

Interesting. Will try and report back. Thanks

I am still running the test but it looks VERY promising. Spent last month on this issue, just so you know how grateful I am. Huge thanks!

It was just an idea based on previous debugging of similar issues. It doesn't fix the problem it just works around it by starting you above the current growth threshold, you can still encounter the problem with higher loads. We're aware of the underlying issue but I don't know of any way to fix it at the moment.

@Wraith2 is this tracked somewhere? Would be interested in learning the cause of this...

Interestingly, both workerThreads and completionPortThreads are 8 on Windows and Linux (for P3v3 instance, for S1 it's 1). Not sure why it differs under load...I'm happy with the results by setting them to 100 on Linux but if someone can investigate/explain the root cause that'd be great

@roji it's the issue investigated in https://github.com/dotnet/SqlClient/issues/422

Thanks @Wraith2 - would it be a fair approximate summary to say that SqlClient is synchronously blocking TP threads (via locking/sleeping/IO/whatever)? Is this a MARS-only phenomenon?

@quanmaiepi SQL Connection pool flooding means you are not releasing connections back to the pool. Cloud you please provide a sample code on SQLConnection lifetime - some snippet on how and when the connection is opened/closed?
Do you use SQLConnection per http request (that is generally a bad idea). Or you are opening a connection right before a query, and disposing it afterwards?
There could be a difference on window/linux due to different GC schemas - in your case, windows GC could be more aggressive, and that cause dangled connections to be closed faster.

Thanks @Wraith2 - would it be a fair approximate summary to say that SqlClient is synchronously blocking TP threads (via locking/sleeping/IO/whatever)? Is this a MARS-only phenomenon?

Any async high throughput scenario with managed sni will likely exhibit the same problem, there's at least one other open issue where not related to mars where opening large numbers of connections has the same problem. I don't quite know where the problem is but I now recognize it as worker thread starvation well enough to suggest trying the threadpool configuration, in this case it worked.
I know the MS team are aware of this problem.

Thanks @Wraith2

@quanmaiepi as @Wraith2 mentioned the issue #422 is open and it seems it is the root cause of the issue. Is it possible for you to make us a sample repro application? Also can you let us know what version of Microsoft.Data.SqlClient is being used in your application?

Hi @quanmaiepi
The exact problem area is unclear as we going to put more time to do some trails/experiments, but we're aware this is a design problem that was never "caught" on Windows (since System.Data.SqlClient) due to high availability of threads but the same application on Unix when run in limited thread pool, leads to thread starvation. We have identified it to be related to MARS (Multiple Active Result Sets) enabled connections only, but let us know if you have a use case otherwise too with a repro.

@JRahnama the application is running on a performance test in azure and running lots of different apis to simulate load on the application so is hard to provide repro application.  I can confirm we are using MultipleActiveResultSets=true in the connection string.  We are using the latest version of SqlClient

@lunchin as @Warit2 mentioned for now increasing the ThreadPool size or setting MARS to false, if possible,  will work as workarounds.

We can't really set MARS to false. Increase Min thread count is obviously a workaround, and it has drawbacks...

Increase Min thread count is obviously a workaround, and it has drawbacks...

What drawbacks are you seeing? Clearly you can tune the min threadpool.

If for some reasons, it hits the thread pool limit, the instance will fail and never recover.
For the traffic we are testing, I can handle it with ~10 Windows instances, there were some spikes due to GC, but then they recovered quickly. For Linux if an instance is bad, it is bad "forever" (until it's taken out of the pool and restarted).
Also as we are serving wide range of traffic on different sites, fixing the pool size is something we'd like a avoid (no size fits all).
Setting the min thread count definitely helped us (and we are grateful :) ), but we also see that is a workaround instead of actual fix :)

Closing issue as original issue #422 will track this effort.


Multipart emails not being parsed properly

I have a multipart email with an attachment that is not being parsed properly by Mail::Message.
Here is the message: https://gist.github.com/eviltrout/7568298
  Mail.read("attachment.eml").parts.size
  #2

When in fact there are 4 parts. It seems to put the text and html version inside the alternative part rather than parsing them out.
I would love to hear if there is a workaround for this of I can help with a patch.

Potentially #539 and #781 - hidden whitespace between headers on the gap line.

Unrelated to #539. MIME parts are hierarchical, so what you're seeing is normal 😊
Use #text_part and #html_part shorthands to grab the text and html parts within the multipart/alternative wrapper:
>> m = Mail.read('attachment.eml')
# …
>> m.parts.size
=> 2
>> m.all_parts.size
=> 4
>> m.text_part
=> #<Mail::Part:70186611509480, Multipart: false, Headers: <Content-Type: text/plain; charset=ISO-8859-1>>
>> m.html_part
=> #<Mail::Part:70186611497580, Multipart: false, Headers: <Content-Type: text/html; charset=ISO-8859-1>, <Content-Transfer-Encoding: quoted-printable>>


Multivariate version of OperandsAndPartials

Write a multivariate version of OperandsAndPartials, allowing for precomputed gradients and vectorization for all multivariate distributions.

This issue was moved to stan-dev/math#97


Implement timed_thread_scheduler

Depends on #1275
Fixes #847
Note, scheduling on this scheduler is wait-free*. the intrusive mpsc queue can be used to address issue #685

it is wait-free for producers on the fast-path only

/ok to test

/ok to test

/ok to test

I think the current failure in TSAN is due to https://github.com/google/sanitizers/issues/1259 and would be solved if we upgrade gcc to version 12. That works at least locally for me.
I still have to investigate why the tests on windows are failing.

/ok to test

/ok to test

c

/ok to test


Accept explicit null input values in queries

Explicit null values are valid for nullable input values. See
https://facebook.github.io/graphql/#sec-Types.Non-Null.
Fixes #23

Nice!
This is probably part of an effort to support the "October 2016" GraphQL specification (https://github.com/facebook/graphql/releases/tag/October2016) where the null literal was introduced. I wonder if we're still compatible with the revised/clarified execution rules as outlined in https://github.com/facebook/graphql/pull/221 - I haven't read that in detail yet.


Update ZeppelinTask.java add login zeppelin mathod

add login method

Purpose of the pull request

add login zeppelin method
Brief change log

org.apache.dolphinscheduler.plugin.task.zeppelin.ZeppelinTask
Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@EricGao888  I expect to use the web UI to pass the parameters, and when I'm done, delete the parameters through zeppelinParamsMap.delete(). Is that OK with you?

@EricGao888 I expect to use the web UI to pass the parameters, and when I'm done, delete the parameters through zeppelinParamsMap.delete(). Is that OK with you?

I think it is a good workaround to fill in the credentials in UI. You could refer to datasource center UI and try to mask the credentials in zeppelin task UI in the same way. Actually you don't need to call zeppelinParamsMap.delete() and it is fine if the credentials stay in memory as long as you don't print them in logging.

Codecov Report

Merging #13861 (94a27ff) into dev (490ead6) will decrease coverage by 0.08%.
The diff coverage is 50.00%.

:exclamation: Current head 94a27ff differs from pull request most recent head c0dcf38. Consider uploading reports for the commit c0dcf38 to get more accurate results

@@             Coverage Diff              @@
##                dev   #13861      +/-   ##
============================================
- Coverage     39.09%   39.01%   -0.08%
+ Complexity     4465     4437      -28
============================================
  Files          1155     1155
  Lines         42268    42243      -25
  Branches       4756     4737      -19
============================================
- Hits          16523    16482      -41
- Misses        23935    23953      +18
+ Partials       1810     1808       -2

Impacted Files
Coverage Δ

...server/master/event/WorkflowStartEventHandler.java
0.00% <0.00%> (ø)

.../server/master/runner/WorkflowExecuteRunnable.java
9.79% <0.00%> (+0.01%)
:arrow_up:

...ler/server/master/runner/WorkflowSubmitStatus.java
0.00% <0.00%> (ø)

...inscheduler/plugin/task/zeppelin/ZeppelinTask.java
52.88% <76.92%> (+3.43%)
:arrow_up:

... and 32 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@EricGao888 I expect to use the web UI to pass the parameters, and when I'm done, delete the parameters through zeppelinParamsMap.delete(). Is that OK with you?

I think it is a good workaround to fill in the credentials in UI. You could refer to datasource center UI and try to mask the credentials in zeppelin task UI in the same way. Actually you don't need to call zeppelinParamsMap.delete() and it is fine if the credentials stay in memory as long as you don't print them in logging.

already  use the web UI to pass the parameters, Please refer to the picture。

Please don't treat password as pass word and username as user name. BTW, please update related docs, both Chinese and English versions. Other LGTM.

There are still many such cases in this PR that I haven't marked, you need to fix them too : )

LGTM, waiting for CI to pass

@xiaomin0322 You need to run "mvn spotless:apply" to fix formatting errors.

LGTM, waiting for CI to pass

@xiaomin0322 You need to run "mvn spotless:apply" to fix formatting errors.

Executed

LGTM, waiting for CI to pass

@xiaomin0322 You need to run "mvn spotless:apply" to fix formatting errors.

Executed

@xiaomin0322

Have u run it in ds root dir?

LGTM, waiting for CI to pass

@xiaomin0322 You need to run "mvn spotless:apply" to fix formatting errors.

LGTM, waiting for CI to pass

@xiaomin0322 You need to run "mvn spotless:apply" to fix formatting errors.

That's wired. It works on my laptop and I've fixed it for u.

@xiaomin0322 Merged. Thanks for your contributions : )

LGTM, waiting for CI to pass

@xiaomin0322 You need to run "mvn spotless:apply" to fix formatting errors.

That's wired. It works on my laptop and I've fixed it for u.

ths


Vue Web Project Works Locally but Shows Blank Page After 'amplify publish'

Before opening, please confirm:

[X] I have searched for duplicate or closed issues and discussions.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

JavaScript Framework
Vue
Amplify APIs
Authentication
Amplify Categories
auth
Environment information

  System:
    OS: macOS 12.2.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 84.58 MB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 18.4.0 - /opt/homebrew/bin/node
    npm: 8.12.1 - /opt/homebrew/bin/npm
  Browsers:
    Firefox: 101.0
    Safari: 15.3
  npmPackages:
    @element-plus/icons-vue: ^2.0.6 => 2.0.6
    @vue/compiler-sfc: ^3.0.4 => 3.2.37
    aws-amplify: ^4.3.26 => 4.3.26
    axios: ^0.27.2 => 0.27.2 (0.26.0)
    el-table-infinite-scroll: ^2.0.0 => 2.0.0
    element-plus: ^2.2.6 => 2.2.6
    less: ^4.1.3 => 4.1.3
    less-loader: ^11.0.0 => 11.0.0
    style-resources-loader: ^1.4.1 => 1.5.0
    vite: ^1.0.0-rc.13 => 1.0.0-rc.13
    vue: ^3.0.4 => 3.2.37 (2.6.14)
    vue-cli-plugin-style-resources-loader: ~0.1.5 => 0.1.5
    vue-router: ^4.0.16 => 4.0.16
  npmGlobalPackages:
    @aws-amplify/cli: 9.0.0
    npm: 8.12.1

Describe the bug
The project builds and runs fine locally. I have followed the instructions on how to init and configure amplify.
When I run 'amplify publish' it completes the deployment and gives me a link. However, it shows a blank page after deployment.
url:  https://sudev.d272frqbn2tt6s.amplifyapp.com
"appId": "d272frqbn2tt6s"
Expected behavior
To show the web project.
Reproduction steps

amplify configure
amplify init (manual deployment)
npm run build (to verify the project builds)
amplify publish

Code Snippet
// Put your code below this line.

Log output

// Put your logs below this line

![image](https://user-images.githubusercontent.com/67939504/176535066-e0337745-2ec0-4c84-bfd3-4c27d0933f7c.png)
aws-exports.js
/* eslint-disable */
// WARNING: DO NOT EDIT. This file is automatically generated by AWS Amplify. It will be overwritten.
const awsmobile = {
"aws_project_region": "us-east-2",
"aws_cognito_identity_pool_id": "my-identity-pool",
"aws_cognito_region": "us-east-2",
"aws_user_pools_id": "my-user-pool",
"aws_user_pools_web_client_id": "my-web-client-id",
"oauth": {
"domain": "my-domain"
},
"aws_cognito_username_attributes": [
"EMAIL"
],
"aws_cognito_social_providers": [],
"aws_cognito_signup_attributes": [
"GIVEN_NAME",
"FAMILY_NAME",
"EMAIL"
],
"aws_cognito_mfa_configuration": "OPTIONAL",
"aws_cognito_mfa_types": [
"TOTP"
],
"aws_cognito_password_protection_settings": {
"passwordPolicyMinLength": 8,
"passwordPolicyCharacters": [
"REQUIRES_LOWERCASE",
"REQUIRES_UPPERCASE",
"REQUIRES_NUMBERS",
"REQUIRES_SYMBOLS"
]
},
"aws_cognito_verification_mechanisms": [
"EMAIL"
]
};
export default awsmobile;
Manual configuration
No response
Additional configuration
No response
Mobile Device
No response
Mobile Operating System
No response
Mobile Browser
No response
Mobile Browser Version
No response
Additional information and screenshots
No response

Hi @shao-estone 👋 thanks for raising this issue! Because it seems to have more to do with hosting than the JS libraries, I am transferring this over to the hosting repo for better feedback and support.

Hi @shao-estone it looks like you application is being shown properly now. Are you still running into this issue?

Thank you!  This issue is resolved
On Jul 20, 2022, at 1:15 PM, hloriana<EMAIL_ADDRESS>wrote:
Hi @shao-estonehttps://github.com/shao-estone it looks like you application is being shown properly now. Are you still running into this issue?
—
Reply to this email directly, view it on GitHubhttps://github.com/aws-amplify/amplify-hosting/issues/2841#issuecomment-1190543063, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQGKZMDN7YC56CRU2A6WX33VVAX23ANCNFSM52KJADBA.
You are receiving this because you were mentioned.Message ID: @.***>


Symbols in current ns cannot be resolved when sent to REPL

My namespaces are refreshed and loaded, but I get "Unable to resolve symbol: ..." when sending code blocks to the REPL. Example: I have an ns foo.core with a function bar, sending (bar) throws an exception, sending (foo.core/bar) doesn't. This can be remedied by sending the definition of bar to the REPL, but shouldn't that have been done when loading the file?

Can you put the namespace definition from the top of your file as a comment here? I'm wondering if there's some difference that it doesn't handle when it tries to find the namespace of the current file. I think there may be an issue if the namespace isn't structured like this as the very first line of the file.
(ns some.namespace
  "docs"
  (:require ...))

Actually I've just determined this is a regression. I'll have a fix soon.


Add ability to override time out environment variable CF_DIAL_TIMEOUT

I have a single VM installation of Concourse. I am not able to login to cf with default timeout of 5s. When I setup the environment variable CF_DIAL_TIMEOUT to 20, it works.
This works on my VM but my Concourse job still fails. Is there a way to override this environment variable value at resource declaration?

I just ran into the same problem where we were getting timeouts on a new concourse deployment and setting this in the container caused the push to function. I saw this on both concourse 3.4.1 & 3.50 against PWS
@xoebus  fyi, this is what caused the issue I spoke to you about today.

I ran into this issue w/3.4.1 & 3.5.0 and used @DaxterM 's custom resource as a workaround.
I just upgraded to 3.6.0 & can confirm that the issue is fixed with the cf resource.  @MarkKropf @jama-pivotal

this was fixed by https://github.com/concourse/cf-resource/pull/33


Member::validate has changed to protected in 3.2 from public in 3.1

Seems the visibility of the validate function has changed to protected in 3.2 which is breach of semver

Fixed with https://github.com/silverstripe/silverstripe-framework/pull/4799

Closed via c3544fdbea696833c31e27c9830c77e42e5d823d


Fix missing space in Owntracks error message between "accuracy" and "is"

Description:  Fixes missing space in Owntracks error message between the words "accuracy" and "is" in "Ignoring GPS in region exit because accuracyis zero:"
Related issue (if applicable): n/a
Example entry for configuration.yaml (if applicable): No updates required
Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

Thanks 👍


COR-110 Reduce ClerkJs bundle size

Type of change

[ ] 🐛 Bug fix
[x] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[x] @clerk/clerk-js
[ ] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[ ] @clerk/localizations
[ ] @clerk/clerk-expo
[ ] @clerk/backend
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/fastify
[ ] gatsby-plugin-clerk
[ ] build/tooling/chore

Description

[x] npm test runs as expected.
[x] npm run build runs as expected.

React.lazy() to the rescue
This PR is the first attempt to decrease the bundle size of our clerk-js bundle.
By using React.lazy and React.Suspense we are now  lazy load our UI components when they are mounted on a users application.
⚠ Further optimisation can be introduced to each lazy loaded UI component to incrementally load only the parts the user needs or visits.
We also lazy load some of the providers that wrap our UI components. This was a necessary step the allowed us to decrease the bundle size even more. These providers are only used by the UI components so it makes sense that if a UI component is not loaded, we do not need to load the providers as well. For now we lazy load some of them eagerly, but this is an optimisation that could be done in a later step.
This PR decreases the bundle size of clerk.browser.js from ~187KB down to ~55KB. This is a remarkable 70% decrease 🎉
In this PR we also addressed

Hydration issues related to lazy loading
Generating unique hashes for the webpack chunk

Hydration issues related to lazy loading
We stumbled upon an interesting hydration issue when our UI modal components where about to be mounted. We solved that by adding an additional  and wrapping those components directly without other lazy load component in between.
Generating unique hashes for the webpack chunk
We come up with the following naming conventions

For common chunks: shared-[id].[hash].[version].js
For top level chunks : [name].[hash].[version].js

name name of the module or the given name of webpackChunkName name
hash will consist of 6 characters unique for each build & will be the same of all chunks generated in a particular build
version  is the readable (human friendly) representation of the clerk-js package

:O


Visit PEP 764 inline TypedDicts' keys as non-type-expressions

Summary
Resolves #10812.
Test Plan
cargo nextest run and cargo insta test.

The INLINE_TYPEDDICT bitflag was added "just in case". I'll remove it if it is not desired.

Yeah, we should remove it if it's not being used currently.
I'll also make a general recommendation to use typed_dict instead of typeddict as I'd consider them two separate words.
Apart from this, I'm not exactly sure what the scope of this should be as the PEP is still in draft so we don't know where all we need to change this. What about when the slice element is not a dictionary like the one in your test case? I don't see it being supported in the PEP yet. Should we only limit it to the following syntax (https://github.com/Viicos/peps/blob/inlined-typed-dictionaries/peps/pep-0764.rst#typing-specification-changes)?
<TypedDict> '[' '{' (string: ':' annotation_expression ',')* '}' ']'


Mac OS custom dictionary not working

Even after I add the words to the dictionary (I tried both project dictionary and global dictionary), the   squigglies don't disappear. This works correctly in Linux, but in my Mac OS (10.12.2), it doesn't work.

I'll see if I can reproduce it.
Did you add changes directly to cSpell.json or through the commands?

I never touched the cSpell.json manually. I usually press Ctrl + . and add to project dictionary. It worked until I used the global dictionary. Once I added the project dictionary, it stopped working.

This should be fixed with 0.14.0


Setup/reevaluate build pipeline(s)

We need to have a look at what is setup now and what we still use/need from that. I see there are some things in place, but seeing that we probably want to start from scratch that might not be relevant anymore.
Things from the top of my head that we need:

CLA checking
PR validation
Running tests
Publishing to nightly/private feed
Publishing to NuGet

OK, most of this is in there. I need to have a call to see what is required to push a package to the actual NuGet.org feed in terms of signing and other things. Will do that this week.
Nightly builds go into GitHub packages right now. I'm hoping Packages will allow connecting to the feed without authenticating anytime soon, else we'll have to look for a alternative maybe.

Changed nightly to Azure DevOps for now so they are publicly available. Last step to get this on nuget.org


Update minitwit & improve testing for examples

Related to #1945

Re-works minitwit to be installed and run as:
pip install --editable .
export FLASK_APP=minitwit.minitwit
export FLASK_DEBUG=1
flask initdb
flask run

added flaskr and minitwit to norecursedirs

tests not properly run when using pytest standards
see: http://stackoverflow.com/questions/38313171/configuring-pytest-with-installable-examples-in-a-project

Both flaskr and minitwit now follow pytest standards.

Tests can for them as py.test or python setup.py test

@davidism heyo. how does this stuff look? pretty minimal changes here

I think the minitwit.py should be __init__.py.

@untitaker That seems like it might be confusing for a new user. Is that a common pattern (moving the app into init.py)?

@untitaker Adding from minitwit import app into the __init__.py has the effect of $ export FLASK_APP=minitwit working. Which I agree looks much cleaner than $ export FLASK_APP=minitwit.minitwit. What do you think about that change?

That's exactly the effect I'd like to have. Why do you think that having code in __init__.py is confusing for newbies?

I don't mind having the one-line import statement in the __init__.py. I just think that having all of minitwit.py inside of the __init__.py will obfuscate the __init__ files purpose for a newcomer.

@untitaker What do you think about this? (Not trying to be a nuisance, I'm just thinking it might have got lost in your notifications.)

Does somebody else have opinions on this topic? @davidism @ronnypfannschmidt

Hi, all. Any more comments on this? I'll have some time this week to work on things. If anyone can offer some guidance, I'd be glad to go ahead with fixing this PR.

Im on mobile right now, but there are no more comments from my side I think.
The comments that are not outdated still apply. I don't really agree about the change being related, and I'd rather apprechiate it if it wouldn't be included, not because it is controversial in any way, but because it makes proper review much harder.

@untitaker No problem, I'll go ahead making your suggested changes then. Thanks for the feedback.

@wgwz Any update on this?

@untitaker I'm not sure if I went about reverting the files in the best way possible. My branch has was based off the 0.11-maintenance branch. So I just ran git checkout <commit ref prior to my first commit> -- docs/tutorial/<file-to-revert>.rst for each of the files being reverted. I double-checked and the changes seem to be reverted correctly.

@wgwz You asked on IRC: There is one comment left on the "Files changed" tab.

@untitaker Sorry I missed that one somehow but it is taken care of now. How does it look now?

A+ would merge again

@untitaker Thanks :) I have to send another PR for flaskr. In order to match testing with how it's done in this PR for minitwit. And to add the import line in the init file. Also I will send a separate PR with the tutorial doc changes I removed from this one.

@wgwz Thanks again, and feel free to directly mention me on those.


Question about using model to predict sequences in fasta file

Hi,
I trained a model to predict binding of 85 transcription factors. I want to use this model to predict binding on about 3000 unique regions (all 200 bp long). Attached are my training yml , prediction yml and output tsv files. My issue is that the output files looks like it's only looping through the first 64 sequences of my input file. How do I fix this?
thanks,
Michelle
MCF7enh_predictions.txt
simple_train.txt
get_predictions.txt

MCF7enh.txt
(a txt version of my input fasta file) only the first 64 entries are getting looped through in the output (MCF7enh_predictions.txt)

I think this was recently fixed by PR #81 . @kathyxchen is this correct?

Yes, it should have been fixed in #81. We have not pushed these changes to the conda release yet, so please let me know if you need help building/installing Selene from master. We are hoping to make a new release through bioconda soon, but I haven't decided yet how soon that will be (originally I was aiming for the end of this month)

fixed thanks!!!


[HxSidebar] Expand section if current location matches HxSidebarItem href

If I directly navigate to some page that matches some HxSidebarItem, I would like to have its section open (expanded).

@crdo Should be achievable with pure CSS?

@Harvey1214 wanna give a try? (consult the intended approach with @crdo)

@hakenr ofc

Current implementation instructions from @crdo:

remove aria-expanded="false" in HxSidebarItem#39 if the item is active https://github.com/havit/Havit.Blazor/blob/da0c36698ff63aa2e0a3ce4215fd270916c595f9/Havit.Blazor.Components.Web.Bootstrap/Navigation/HxSidebarItem.razor#L32-L39
remove collapsed class in HxSidebarItem#64 if the item is active
https://github.com/havit/Havit.Blazor/blob/da0c36698ff63aa2e0a3ce4215fd270916c595f9/Havit.Blazor.Components.Web.Bootstrap/Navigation/HxSidebarItem.razor#L62-L69

Will be a little tricky as we will have replicate the active-detection logic in HxSidebarItem (encapsulated in NavLink as private methods).

@hakenr sorry, 2. should be to add class show instead of removing collapse.


[openmpi] Disable fortran mpi bindings explicitly

Fixes https://github.com/microsoft/vcpkg/issues/11990
When gfortran installed on osx and linux machine, openmpi will fail to configure. From https://github.com/open-mpi/ompi/blob/master/configure.ac#L634, the Fortran bindings looks disabled by default. This issue can be resolved when disable fortran mpi bindings explicitly.

Thanks for the reliability improvement!


[Device Support Request] Third Reality button 3RSB22BZ

Problem description
Third Reality Button shows up as Third Reality contact sensor.
Expected device: 3RSB22BZ
Device ZHA finds: 3RDS17BZ
Solution description
Correctly detect and pair 3RSB22BZ to ZHA and have the single, double, and long press commands available
Screenshots/Video
Screenshots/Video

Device signature
Device signature
{
  "node_descriptor": "NodeDescriptor(logical_type=<LogicalType.EndDevice: 2>, complex_descriptor_available=0, user_descriptor_available=0, reserved=0, aps_flags=0, frequency_band=<FrequencyBand.Freq2400MHz: 8>, mac_capability_flags=<MACCapabilityFlags.AllocateAddress: 128>, manufacturer_code=4659, maximum_buffer_size=66, maximum_incoming_transfer_size=66, server_mask=10752, maximum_outgoing_transfer_size=66, descriptor_capability_field=<DescriptorCapability.NONE: 0>, *allocate_address=True, *is_alternate_pan_coordinator=False, *is_coordinator=False, *is_end_device=True, *is_full_function_device=False, *is_mains_powered=False, *is_receiver_on_when_idle=False, *is_router=False, *is_security_capable=False)",
  "endpoints": {
    "1": {
      "profile_id": "0x0104",
      "device_type": "0x0402",
      "input_clusters": [
        "0x0000",
        "0x0001",
        "0x0500"
      ],
      "output_clusters": [
        "0x0019"
      ]
    }
  },
  "manufacturer": "Third Reality, Inc",
  "model": "3RDS17BZ",
  "class": "zigpy.device.Device"
}

Diagnostic information
Diagnostic information
[Paste the diagnostic information here]

Logs
Logs
[Paste the logs here]

Custom quirk
Custom quirk
[Paste your custom quirk here]

Additional information
No response

When you listen to zha_event in the HA developer tools, do you see any events?

I do not, no. I think because it registers as a contact sensor it does not process a button press as an event


Start Runtimes locally

[ ] ability to start a single bot within a project
[ ] edit the manifest
[ ] make the root bot refer to running skills
[ ] ability to stop a single bot within a project
[ ] start/stop all
[ ] propagate error states to Notification window
[ ] generate runtime warnings

This ticket involves starting up runtimes and surfacing validation errors that require starting up runtimes of the root bot and its skills inside the botproject
Multi-bot testing - https://www.figma.com/file/LlTlh5vXwq91zjGnFtrUUR6l/Composer-main-design-spec-UI-library?node-id=5204%3A3

Updated the design as new notification designs came in. Removed the console, merged it with other notification. The validation badge design will remain as it is in the current build since Vivek is tackling that experience as a whole.


Register v0.1.0

@JuliaRegistrator register
Register the first release of DigitalHolography.jl

Registration pull request created: JuliaRegistries/General/96281
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" 8d5b036fd519fef40e140ec40037631ed0e8a2f9
git push origin v0.1.0


Changed the color of logo

PR Description 📜
Fixes #98

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for review.

Thank you soo much for contributing to our repository 💗

@thevijayshankersharma Please resolve conflicts

@Durgesh4993 Done.

@Durgesh4993 Why didn't you merged it ?


Support async/await in user functions

Figure out a way to support async/await in Azure Functions for Rust.
This should be as natural as possible.  Ideally, an async function with the #[func] attribute should "just work".
We'll need a different descriptor for async functions that return a Box<dyn Future<Output = rpc::InvocationResponse>> rather than rpc::InvocationResponse.
A continuation will need to be added that sends the ready response back to the functions host.

One big problem already encountered: the TLS used to store the function name and invocation id, which is used when the function uses the log crate (or if it panics) to associate the log message with the invocation, can't be used since we don't know what thread the executor will spawn the task on.  See https://github.com/rustasync/team/issues/7 for some ideas.

This is also a blocking issue as there is no fix yet in a published tokio crate: https://github.com/tokio-rs/tokio/issues/1087

While std::future::Future has been stabilized, the stable Rust containing it isn't release yet.  So, we'll need to wait a few weeks until it does, otherwise there will be a lot of additional conditional code.

Marking blocked on tower-grpc being released since I don't want to implement this before then.

Marking dependent on tokio-rs/tokio#1120.


Workflow help

Diagnostic
Workflow version
2022.10
Alfred version
4.6.5
macOS version
12.2.1
Architecture
arm64
Workflow environment variables
Dict {
ignore_list =
result_limit = 50
auto_refresh = 1
google_drive_path = /Volumes/GoogleDrive
}
Full Disk Access
Granted
Google drive paths
Does NOT Exist: /Volumes/GoogleDrive
Cache dir
cache.db
Cache file
16777230 19613027 -rw-r--r-- 1 joshberris staff 0 2183168 "Apr  7 10:38:01 2022" "Apr  6 20:04:16 2022" "Apr  6 20:04:16 2022" "Apr  6 20:00:59 2022" 4096 6208 0 /Users/joshberris/Library/Caches/com.runningwithcrayons.Alfred/Workflow Data/com.alfredapp.googledrive/cache.db
Temporary cache
Does NOT exist
Build progress
NOT running
Launchd job
NOT loaded
NOT installed
Debugger output
[10:09:55.951] Google Drive[Script Filter] Processing complete
[10:09:55.953] Google Drive[Script Filter] Passing output '/Volumes/GoogleDrive/My Drive/My Clients/Archive' to Conditional
[10:09:55.954] Google Drive[Conditional] Processing complete
[10:09:55.955] Google Drive[Conditional] Passing output '/Volumes/GoogleDrive/My Drive/My Clients/Archive' to Open File

More details
Doesn't open google drive files anymore. When I click it, nothing happens. Typically amazing workflow! Thank you for creating!

Does NOT Exist: /Volumes/GoogleDrive

Something happened with your Google Drive. Perhaps Google changed its location. Confirm the path.

Fixed thank you!


CRD with omitting "trace"-parameters creates error-log related to jaeger and otel in core-service

Expected behavior and actual behavior:
I installed the operator via helm-chart (version 1.2.0-rc3). This works without any problems. After applying a CRD without and "trace"-entry the access to harbor via browser does not work (which it should do) and the following errors are shown in the log of the core-service:
│ 2022-03-29T14:30:31Z [DEBUG] [/pkg/config/manager.go:139]: failed to get key trace_service_name, error: the configure value is not set                    │
│ 2022-03-29T14:30:31Z [DEBUG] [/pkg/config/manager.go:139]: failed to get key trace_namespace, error: the configure value is not set                       │
│ 2022-03-29T14:30:31Z [DEBUG] [/pkg/config/manager.go:139]: failed to get key trace_attribute, error: the configure value is not set                       │
│ 2022-03-29T14:30:31Z [ERROR] [/lib/config/metadata/value.go:143]: GetStringToStringMap failed, current value's metadata is not defined, &{Name: Value:}   │
│ 2022-03-29T14:30:31Z [DEBUG] [/pkg/config/manager.go:139]: failed to get key trace_jaeger_endpoint, error: the configure value is not set                 │
│ 2022-03-29T14:30:31Z [DEBUG] [/pkg/config/manager.go:139]: failed to get key trace_jaeger_username, error: the configure value is not set                 │
│ 2022-03-29T14:30:31Z [DEBUG] [/pkg/config/manager.go:139]: failed to get key trace_jaeger_password, error: the configure value is not set                 │
│ 2022-03-29T14:30:31Z [DEBUG] [/pkg/config/manager.go:139]: failed to get key trace_jaeger_agent_host, error: the configure value is not set               │
│ 2022-03-29T14:30:31Z [DEBUG] [/pkg/config/manager.go:139]: failed to get key trace_otel_endpoint, error: the configure value is not set                   │
│ 2022-03-29T14:30:31Z [DEBUG] [/pkg/config/manager.go:139]: failed to get key trace_otel_url_path, error: the configure value is not set                   │
│ 2022-03-29T14:30:31Z [DEBUG] [/pkg/config/manager.go:139]: failed to get key trace_otel_compression, error: the configure value is not set                │
│ 2022-03-29T14:30:31Z [ERROR] [/lib/config/metadata/value.go:126]: GetBool failed, the current value's metadata is not defined, &{Name: Value:}            │
│ 2022-03-29T14:30:31Z [DEBUG] [/pkg/config/manager.go:139]: failed to get key trace_otel_insecure, error: the configure value is not set                   │
│ 2022-03-29T14:30:31Z [ERROR] [/lib/config/metadata/value.go:126]: GetBool failed, the current value's metadata is not defined, &{Name: Value:}            │
│ 2022-03-29T14:30:31Z [DEBUG] [/pkg/config/manager.go:139]: failed to get key trace_otel_timeout, error: the configure value is not set                    │
│ 2022-03-29T14:30:31Z [ERROR] [/lib/config/metadata/value.go:78]: GetInt failed, the current value's metadata is not defined, &{Name: Value:}              │

Steps to reproduce the problem:
All the services run within an AKS using Azure-services for Postgres, Redis and storage.
Install the Operator via HELM-chart with the following values:
rediso-perator: #<-- This is NOT a typo this is a bug already reported
  enabled: false
minio-operator:
  enabled: false
postgres-operator:
  enabled: false

Use the following CRD:
---
apiVersion: goharbor.io/v1beta1
kind: HarborCluster
metadata:
  name: harborcluster
spec:
  expose:
    core:
      ingress:
        host: REDACTED
    notary:
      ingress:
        host: REDACTED
  externalURL: "https://REDACTED"
  internalTLS:
    enabled: false
  logLevel: "debug"
  harborAdminPasswordRef: "harbor-pw"
  version: 2.4.0
  portal: {}
  chartmuseum: {}
  core:
    tokenIssuer:
      name: selfsigned-issuer
      kind: Issuer
  jobservice: {}
  notary:
    server: {}
    signer: {}
  registry: {}
  trivy:
    skipUpdate: false
    storage: {}
  storage:
    kind: Azure
    spec:
      azure:
        accountkeyRef: azure-blob-key
        accountname: "REDACTED"
        container: "harbor"
  database:
    kind: PostgreSQL
    spec:
      postgresql:
        hosts:
          - host: REDACTED
            port: 5432
        passwordRef: postgres-pw
        sslMode: require
        username: REDACTED
  cache:
    kind: Redis
    spec:
      redis:
        host: REDACTED
        passwordRef: redis-pw
        port: 6379

# DOWN BELOW IS THE DEFINITION OF THE SECRETS REFERENCED ABOVE

Versions:

harbor operator version: 1.2.0-rc3
harbor version: 2.4.0
kubernetes version: v1.21.1
Any additional relevant versions such as CertManager

CertManager: 1.7.1

Additional context:

Harbor dependent services:

Context info of postgreSQL: Azure Postgres
Context info of Redis: Azure cache for Redis
Context info of storage: Azure storage account

Log files:
Same as above:

│ 2022-03-29T14:30:31Z [DEBUG] [/pkg/config/manager.go:139]: failed to get key trace_service_name, error: the configure value is not set                    │
│ 2022-03-29T14:30:31Z [DEBUG] [/pkg/config/manager.go:139]: failed to get key trace_namespace, error: the configure value is not set                       │
│ 2022-03-29T14:30:31Z [DEBUG] [/pkg/config/manager.go:139]: failed to get key trace_attribute, error: the configure value is not set                       │
│ 2022-03-29T14:30:31Z [ERROR] [/lib/config/metadata/value.go:143]: GetStringToStringMap failed, current value's metadata is not defined, &{Name: Value:}   │
│ 2022-03-29T14:30:31Z [DEBUG] [/pkg/config/manager.go:139]: failed to get key trace_jaeger_endpoint, error: the configure value is not set                 │
│ 2022-03-29T14:30:31Z [DEBUG] [/pkg/config/manager.go:139]: failed to get key trace_jaeger_username, error: the configure value is not set                 │
│ 2022-03-29T14:30:31Z [DEBUG] [/pkg/config/manager.go:139]: failed to get key trace_jaeger_password, error: the configure value is not set                 │
│ 2022-03-29T14:30:31Z [DEBUG] [/pkg/config/manager.go:139]: failed to get key trace_jaeger_agent_host, error: the configure value is not set               │
│ 2022-03-29T14:30:31Z [DEBUG] [/pkg/config/manager.go:139]: failed to get key trace_otel_endpoint, error: the configure value is not set                   │
│ 2022-03-29T14:30:31Z [DEBUG] [/pkg/config/manager.go:139]: failed to get key trace_otel_url_path, error: the configure value is not set                   │
│ 2022-03-29T14:30:31Z [DEBUG] [/pkg/config/manager.go:139]: failed to get key trace_otel_compression, error: the configure value is not set                │
│ 2022-03-29T14:30:31Z [ERROR] [/lib/config/metadata/value.go:126]: GetBool failed, the current value's metadata is not defined, &{Name: Value:}            │
│ 2022-03-29T14:30:31Z [DEBUG] [/pkg/config/manager.go:139]: failed to get key trace_otel_insecure, error: the configure value is not set                   │
│ 2022-03-29T14:30:31Z [ERROR] [/lib/config/metadata/value.go:126]: GetBool failed, the current value's metadata is not defined, &{Name: Value:}            │
│ 2022-03-29T14:30:31Z [DEBUG] [/pkg/config/manager.go:139]: failed to get key trace_otel_timeout, error: the configure value is not set                    │
│ 2022-03-29T14:30:31Z [ERROR] [/lib/config/metadata/value.go:78]: GetInt failed, the current value's metadata is not defined, &{Name: Value:}              │

Kubernetes: How Kubernetes access was provided (what cloud provider, service-account configuration, ...).
Azure AKS was/is used.

@stksz rediso-perato fixed. Thanks very much.

Hi @yxxhero , FYI: there is already a PR created for the typo: https://github.com/goharbor/harbor-operator/pull/868 (to avoid misunderstandings).
Do you have any idea why the errors in the log were created? Is there maybe some kind of condition check missing in the operator (for the "trace"-part of the CRD) which then creates a config for the core-service where tracing is enabled by default?

@stksz I will try to see it.

Hi @yxxhero , short update: I did some debugging and it seems like the error mentioned above is "normal" coming from the core-service. So this is not an issue of the operator itself. Will close this ticket therefore.


3 4 branch

Get latest commits

Hi
I'm not sure what this Pul request would achieve? Could you provide more info please?


Cursor jumps to the bottom left corner when the color is pure black

When the user drags the cursor and hits #000000, the cursor jumps to the bottom left corner. This isn't wrong but makes the experience a little jarring. I would expect the position that the user picks to "stick".
See recording below of the react-color website:
https://user-images.githubusercontent.com/2165256/188221494-26d6352f-946a-44b8-9334-ba52ad835090.mp4
See figma for example (notice that re-opening puts the cursor back to the bottom left, which I think is fine)
https://user-images.githubusercontent.com/2165256/188221563-732b26f4-7a6c-45c8-bbf0-d43bfb70d168.mp4

I ran into this issue as well. This bug is in toState function of color.js. The issue occurs when v part of hsv is 0 then tinycolor library returns 0 for s part as well when color.toHsv() is called, so x-coordinate gets all messed up.
The fix is to not call color.toHsv() when v is 0 and return the incoming hsv values in data arg as it is.


BIGTOP-3741:Add Flink support for Bigtop 3.1.0 Mpack

Description of PR
Add flink support for Bigtop 3.1.0 Mpack
How was this patch tested?
Tested in centos 7.6
Flink version is 1.15.0
1 summary

2 configs

3 service check

For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
[ ] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/

We should add more configuration template from /etc/flink/conf, like log4j.properties


PanResponder crashing + not working after translate View

Environment
react-native -v: 0.75.3
npm ls react-native-macos<EMAIL_ADDRESS>node -v: v21.7.1
npm -v: 10.5.0
yarn --version: 3.6.4
xcodebuild -version: Xcode 15.4 Build version 15F31d

Steps to reproduce the bug

Copy and run the PanResponder example from react native docs
Drag the blue square around
Release the mouse
Try drag the box again

Expected Behavior

I expected to drag the View around as many times I want and to any position
Be able to set useNativeDrive to true
Restart drag from the last position I released it

Example working on mobile:
https://github.com/user-attachments/assets/21986dd0-a667-4e0e-b32f-0f4ef4a92e6b
Actual Behavior

I can drag the view around as long as I do not release the mouse
If I release the mouse I cannot restart dragging the view again from its last position, but if I try to do it from its initial position it somewhat works
When setting useNativeDrive to true, the app crashes with an uncaught exception

With useNativeDrive is false, it partially works, but with this dragging issue:
https://github.com/user-attachments/assets/c14a84e2-f1a1-4ba5-87b3-b12a896aa724
Error I got after setting useNativeDrive to true:
TypeError: config.onPanResponderMove is not a function. (In 'config.onPanResponderMove(event, gestureState)', 'config.onPanResponderMove' is an instance of AnimatedEvent)

Reproducible Demo
I took the code directly from React Native website here, but since the code is really small, I will just past it here bellow

Example code
import React, {useRef} from 'react';
import {Animated, View, StyleSheet, PanResponder, Text} from 'react-native';

const App = () => {
  const pan = useRef(new Animated.ValueXY()).current;

  const panResponder = useRef(
    PanResponder.create({
      onMoveShouldSetPanResponder: () => true,
      onPanResponderMove: Animated.event([null, {dx: pan.x, dy: pan.y}], { useNativeDriver: true }),
      onPanResponderRelease: () => {
        pan.extractOffset();
      },
    }),
  ).current;

  return (
    <View style={styles.container}>
      <Text style={styles.titleText}>Drag this box!</Text>
      <Animated.View
        style={{
          transform: [{translateX: pan.x}, {translateY: pan.y}],
        }}
        {...panResponder.panHandlers}>
        <View style={styles.box} />
      </Animated.View>
    </View>
  );
};

const styles = StyleSheet.create({
  container: {
    flex: 1,
    alignItems: 'center',
    justifyContent: 'center',
  },
  titleText: {
    fontSize: 14,
    lineHeight: 24,
    fontWeight: 'bold',
  },
  box: {
    height: 150,
    width: 150,
    backgroundColor: 'blue',
    borderRadius: 5,
  },
});

export default App;

Additional context

This happens in react-native-macos 0.73 too, except it doesn't crash when setting useNativeDrive to true;
I didn't test with 0.74, but I will assume It behaves the same as 0.73 and 0.75
I tested this with Blank new initialized projects

Initially I thought it was an issue with PanResponder alone, but searching a bit, it may be related with:

This issue #2147
And maybe this one #1099 that seems to have been closed by the bot

Well, this is indeed a bug I have not seen before. Thanks for the report! I'm not sure when we'll look at it, but I wanted you to know I've seen your issue

Yeah, I can see why thats not a priority. Is not difficult work to around it, so it's not a big problem. Thanks for letting me know, I really appreciate it 😁


Set path to tax function output

This PR allows the user to set the path for the tax function estimation output.  A test was added in test_parameters.py to test the logic in parameters.get_parameters.
I tried to write a test, test_file.py, that checked that output files were written to the correct location.  However, this involved mocking many functions, and this messed up the other tests.  Unless we find a better way to test the file writing behavior, this should be removed from the PR.

@jdebacker This PR is ready for review.

@hdoupe This looks good to me.  Will merge soon - wanting to wait until @rickecon gets some runs done that he's in the middle of first.

Thanks @jdebacker.  Contingent on passing the the travis tests, this should be good to go.

@hdoupe these and some other PRs are looking good and I'm on board to merge.  Hesitating because @rickecon  is in the middle of some runs and I think he'll have some changes.
@rickecon Let me know when you are ok with merging these and we can go ahead and do that.  Let's merge these before you add your PRs for fixes you uncovered trying to run TCJA.

Ok, that sounds good.  The merge order should probably be #323, #327, and then #324.  I think #324 will have some merge conflicts that will need to be resolved.


[Backport to main]set default access_control_enabled setting to false (#935)

set default access_control_enabled setting to false

Description
Backport https://github.com/opensearch-project/ml-commons/pull/935 to main
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Can we please check why tests are failing?

Can we please check why tests are failing?

There's a bug when registering pre-build model, I've fixed this bug in this PR: https://github.com/opensearch-project/ml-commons/pull/1246


Run on Android?

Hello, I would like to run it on my Android device. Is it possible to do so?
I have another question. Let's say the client device and a proxy are connected via LAN, but the uplink internet for the proxy is down. Will the messages still be sent to the proxy and wait there until the internet is available? Does it work like that?

Hi @abdul-jabbar-ms,
The proxies do not keep messages. As for running them on an Android device as a Docker container, this tells me that they are not supported.


Add KIC 1.2.0 docs

Summary
Adds docs section for KIC 1.2 with updated compatibility and feature documenation.
Reason
We plan to release KIC 1.2 on 2021-03-24
Testing
Awaiting Netlify to confirm metadata is correct and compatibility tables aren't broken.

Netlify reviewed and cosmetic blunders addressed. Didn't double-check the last fix, but it was pretty simple (there was an accidental line break in the new CLI arguments entry that resulted in an extra row).

:facepalm: those should have gone in; updated now. The GH UX for suggestions on large diffs is less than ideal; I wish there was an "accept all" rather than having to add each to the batch.


BUG Fix issue with non-associative rule conditions

BUG Fix issue with conjunction of rules; ’only’ should be and, ‘except’ should be or
BUG Fix PSR-2 formatting
See https://github.com/silverstripe/silverstripe-assets/issues/43 for parent story
@micmania1 I'd appreciate some feedback:
I discovered the bug with the below rules:
Name: silverstripes3-assetscore
Only:
  envvarset:
    - AWS_REGION
    - AWS_BUCKET_NAME

My envarset was failing because it was checking getenv(0) === 'AWS_REGION' when it should be getenv('AWS_REGION') !== false.
Also, multiple "Except" rules wouldn't correctly exclude if only one of the except conditions was true; This issue existed not only for multiple except rules, but a single except rule with multiple values.
I've consolidated the logic for conjunction into a single method, and added tests to demonstrate the fix.

Either this has caused a regression or our framework test suite just has a test that asserts the old broken behaviour. I'm seeing a failure in ConfigManifestTest::testMultipleRules (https://github.com/silverstripe/silverstripe-framework/blob/4/tests/php/Core/Manifest/ConfigManifestTest.php#L213-L216)

@dhensby I think https://github.com/silverstripe/silverstripe-framework/pull/7198 addresses that


fix(yanky): enable yank history in visual mode

Description
Being able to select from the yank history is useful if you want to
paste over something else by first selecting the stuff you want to
remove in visual mode.
Checklist

[x] I've read the CONTRIBUTING guidelines.

ty!


Broken link in wiki

The

Download zipped PWT data and calculate 5yr averages

link is bronken in the cookbook section of the wiki

Thx for the report. It looks out of date, shall we delete the page?
Now we have cookbook on official doc:

http://pandas.pydata.org/pandas-docs/stable/cookbook.html

Let me remove the wiki if there is no objection within few days.

Yes, that page can be deleted I think

thx, done.


Cassandra3 span store doesn't return proper limits

While testing the Cassandra3 storage component I noticed that query limit is not accurate.  Specifying a limit of 10 for "zipkin-server" "all" returns 4 results.  Increasing the limit to 100 for "zipkin-server" "all" returns 38 results.  Specifying an actual span name returns the desired limit so the problem seems isolated to the "all" case.
/cc @michaelsembwever

Any update on this? Still seeing the same issue


System.IO.FileNotFoundException: Importing downloaded beatmap

Report
osu!Forum

System.IO.Path.CheckInvalidPathChars(String path, Boolean checkAdditional) i've got this issue ;/

Thank you for re-reporting this issue.
I'm very sorry that I haven't fixed it yet and am currently trying to resolve this by emulating possible cases.

I'm not quite sure but I think that this issue is because of #15 which has just been fixed.


Add files via upload

Hacktoberfest-Sign-In-master 2.zip

added an ipAnalyser program written in perl


Check that contextfunction, etc. is True

In order to determine if the context should be passed to a function or filter, Jinja has the contextfunction and contextfilter decorators which set corresponding attributes on the functions. However, they're checked with if getattr(f, "contextfunction", 0), which causes issues for objects that are callable and have permissive __getattr__ functions, such as Mock.
Changing everything to default to False and check is True, would be good for consistency.
The full list is contextfunction, evalcontextfunction, environmentfunction, contextfilter, evalcontextfilter, and environmentcontextfilter.
Extracted from https://github.com/pallets/jinja/issues/1139

I'm honestly not sure if it's a good idea to pass mock objects to a template in the first place. FWIW the reason 0 is used is because this code was faster on 2.x where the constant optimization was not applied yet.

I agree it's not, but there was another example of it coming up outside testing and it's a straightforward fix. 0 was only used in one place, False was used everywhere else already.


MGDOBR-524: Unable to delete FAILED processor. Updates following peer review

https://issues.redhat.com/browse/MGDOBR-524
Follows up on @r00ta comments made on https://github.com/5733d9e2be6485d52ffa08870cabdee0/sandbox/pull/576
PR owner checklist
Please make sure that your PR meets the following requirements:

[x] Your code is properly formatted according to this configuration.
Run mvn clean verify -DskipTests so that imports are correctly set.
[x] Your commit messages are clear and reference the JIRA issue e.g: "[MGDOBR-1] - $clear_explanation_of_what_you_did"
[x] All new functionality is tested
[x] Pull Request title is properly formatted: MGDOBR-XYZ Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains link to any dependent or related Pull Request
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket

PR reviewer(s) checklist

[ ] Check if code and Github action workflows have been modified and if the modification is safe
[ ] If the modification is safe, add the safe to test label

How to trigger pipelines and use the bots:

Run the end to end pipeline
Annotate the pull request with the label: safe to test. If you want to run the pipeline again, remove and add it again.

Rebase the pull request
Comment with: /rebase.

Closed in preference to https://github.com/5733d9e2be6485d52ffa08870cabdee0/sandbox/pull/619


Robot Framework dockerfile

First version of Robot Framework dockerfile.
Enhancements needed to get full required functionality in.
Enhancements like:

Runtime user/auth adding
Runtime libraty adding

please add Apache 2.0 to file (copyright symbio)
Copyright 2016 Symbio
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.


When Running an Email Search Does not Find APIkey

I have a valid APIkey.
Results:
python3 pwnedornot.py --email
[+] API Key Found...
[+] Checking Breach status for
[-] Status 401 : Unauthorised — either no API key was provided or it wasn't valid
Note: The APIkey check only fails with email addresses. Using the --check on a domain works fine.

Expected:
Finds APIkey in config.json, retrieves information for email address successfully
Contents of config.json:
{
"api_key": ""
}

there is 1 space between the colon and the start of the api key (with quotes)

@g33k247 edit the json file and add your key in the quotes, also the one space is not an issue

@g33k247 I will test it out soon, also the domain check works without the api key

@g33k247 is the key added in $HOME/.config/pwnedornot/config.json file?

Ahhh, that was the issue. Thank-you!


New page loads are not announced to users using assistive technologies

When a user activates a link that causes client-side navigation, assistive technologies are not notified of the navigation event. Therefore:

A screen reader will still read out content from the previous view until the user tabs/navigates to a different area on the page
When new content is loaded, the user is not informed that the new content is loaded
The new focus state is not consistent, often leaving the user lost

To resolve this issue we need to actively manage focus on navigation(such as discussed in Bug 1563471 - https://bugzilla.mozilla.org/show_bug.cgi?id=1563471) and possibly make use of Aria live-regions to inform the user when content has changed.
Bugzilla
https://bugzilla.mozilla.org/show_bug.cgi?id=1563511

Pull request: https://github.com/mozilla/kuma/pull/5531


Add the issues page link to the email command.

Since the email sent with access credentials serves as a short guide for commands and how to interact with the MorphoCloud, it would be important to add the direct URL for the issues page for the convenience of the user.
If the email is generated in response to Issue #35, the link to include in the email should be:
https://github.com/MorphoCloud/MorphoCloudInstances/issues/35
as bullet under the Important Notes.

Text like the following was added:

Commands should be added as comments to issue jcfr/MorphoCloudPortal#87

Preview

Fixed in https://github.com/MorphoCloud/MorphoCloudWorkflow/commit/0ea26c777dc9a280f2c9117629ad8ba795b4e83c


Publish on the Open VSX Registry

It would be nice if the extension was published on Open VSX to make installation easier in VS Code compatible editors :)
Thanks!

Done here! https://open-vsx.org/extension/AndrewNolte/vscode-system-verilog. Working on getting the namespace, but I think it's available now

Can confirm, it's now installable. Thanks for the quick work!


Cant find RCTGCanvasView on android for react native bridge

Hi,
according to
import React, { Component, PropTypes } from 'react';
import { requireNativeComponent, View } from 'react-native';

var RCTGCanvasView = requireNativeComponent('RCTGCanvasView', GCanvasView);

export default class GCanvasView extends Component {
	static propTypes = {
		// isOffscreen: PropTypes.bool,
		...View.propTypes
	};

	render() {
		return ( <RCTGCanvasView {...this.props} /> );
	};
}

GCanvasView is the native component RCTGCanvasView however I cant find the android implementation, nor using REACT_CLASS either.

hi DavidGOrtega,
do you mean can't find out RCTGCanvasView?
actually there is a name issue, please try to use 'GCanvasView' instead.

Hi @hejian1639
actually I mean that I can't find the android native component RCTGCanvasView. The code that I pasted before is the js code of GCanvasView and it's a wrapper over the native component. Where I can find the RCTGCanvasView on android? I do a search in the project but I just only find it for iOS.

Hi,@DavidGOrtega,https://alibaba.github.io/GCanvas/docs/Integrate GCanvas on ReactNative.html

I cannot find RCTGCanvasView on android too. Where can i find it?
Thanks a lot

@DavidGOrtega @pongponglau
Since Alibaba feat: delete weex bridge & reactive bridge, here comes the @flyskywhy/react-native-gcanvas npm package.
After months work, @flyskywhy/react-native-gcanvas runs well on Android and iOS, fix several bugs and add feat: support drawImage() from require('some.png') on Android, iOS and Web described in Changelog.md, refactor with the detailed Example As Usage in README.md.
With Performance Test Result, and Convenient With Browser-like canvas APIs with the easily <canvas/> ported example react-native-particles-bg runs on Android, iOS and Web, @flyskywhy/react-native-gcanvas is the best choice for now :yum:


pass filter text onto user filter function. typo fix in new 'drawer' …

…component

Thanks. Have you changed the source file? The files in the dist folder get rebuilt automatically by running npm run build

I made these changes as part of slightly larger set and published as part of v2.1.2
Thanks.


⚠ Processors has degraded performance

In cede62c, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 66 ms

Resolved: Processors performance has improved in 231dde8.


[Hexagon] Delete offload runtime, move files to right places

Within src/runtime/hexagon

delete directory android,
move files from hexagon to ., delete hexagon,
merge host/hexagon_module.cc with hexagon_module.cc, delete host.

Rename HexagonHostModuleNode to HexagonModuleNode.
cc @mehrdadh

@kparzysz-quic this is great!
I think you missed a header file path change.

@kparzysz-quic can you add notes in the PR description about changes in hexagon codegen for better documentation?

@kparzysz-quic there's a merge conflict which might have introduced by #11065. Please rebase and then we can merge.


Is google deprecating Third party cookies on December 27th 2024 ?

Referring to: https://privacysandbox.com/news/privacy-sandbox-update/
It is not clear whether Google Chrome is restricting third party cookies. Please let me know if Google Chrome will absolutely restrict third party cookies on December 27th 2024 ?

No, Chrome will not be rolling out third-party cookie restrictions on Dec 27th. Instead, as the announcement you linked to says, we are currently developing a new approach that would elevate user choice - offering users an informed choice about third-party cookies. Please follow along on https://privacysandbox.com/intl/en_us/news/ for updates on timeline, but we do not have further information to share at this time.


[build] Having issues setting up raylib for MacOS

Error message:
clang -x objective-c -c rglfw.c -Wall -D_GNU_SOURCE -DPLATFORM_DESKTOP -DGRAPHICS_API_OPENGL_33 -Wno-missing-braces -Werror=pointer-arith -fno-strict-aliasing  -std=c99 -O1 -Werror=implicit-function-declaration -I. -Iexternal/glfw/include -Iexternal/glfw/deps/mingw
In file included from rglfw.c:61:
In file included from ./external/glfw/src/init.c:30:
In file included from ./external/glfw/src/internal.h:331:
In file included from ./external/glfw/src/platform.h:42:
In file included from ./external/glfw/src/cocoa_platform.h:29:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX12.1.sdk/System/Library/Frameworks/Carbon.framework/Headers/Carbon.h:28:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX12.1.sdk/System/Library/Frameworks/Carbon.framework/Frameworks/HIToolbox.framework/Headers/HIToolbox.h:240:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX12.1.sdk/System/Library/Frameworks/Carbon.framework/Frameworks/HIToolbox.framework/Headers/IMKInputSession.h:23:
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX12.1.sdk/System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:12:
/Library/Developer/CommandLineTools/SDKs/MacOSX12.1.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSBundle.h:91:143: error: function does not return NSString

(NSAttributedString *)localizedAttributedStringForKey:(NSString *)key value:(nullable NSString *)value table:(nullable NSString *)tableName NS_FORMAT_ARGUMENT(1) NS_REFINED_FOR_SWIFT API_AVAILABLE(macos(12.0), ios(15.0), watchos(8.0), tvos(15.0));
~~~~~~~~~~~~~~                                                                       ^                  ~
/Library/Developer/CommandLineTools/SDKs/MacOSX12.1.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:103:48: note: expanded from macro 'NS_FORMAT_ARGUMENT'
#define NS_FORMAT_ARGUMENT(A) attribute ((format_arg(A)))
^          ~
1 error generated.
make: *** [rglfw.o] Error 1

Thats it!
Tried add rlgfw.m with just one line:
#include "rlgfw.c"

@TheSuperFastOne It seems the issue is related to GLFW library, are you using the provided raylib/src/Makefile to build the library?

Can't reproduce on my MacBook Pro with macOS 13.1, neither on Homebrew's clang 15.0.7 nor Apple clang 14.0.0. Try updating your command line tools at System Settings > General > Software Update.

@Not-Nik thanks for the feedback. Closing this issue. If problem persist, please comment to reopen it.


feat: Trigger callbacks on tooltip enter and leave, #23

Closes #23

:tada: This PR is included in version 2.8.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Use a priority queue for the sparse secondary iteration

This can replace the current_indices store, and means that each secondary iteration doesn't have to scan across the entire extent. Only should be filled if an oracle is provided and the next element is greater than the current element.
Probably will need another field to specify the last element at which the queue was updated. Might even have to use make_heap directly to allow us to clear the priority queue quickly when a reverse order is used.

This is... much more complex than I thought, especially to handle both increments and decrements.
The real problem is that I'm not even sure it's going to be faster.

The heap takes Nz * log(Nz) time to depopulate and fill, given Nz non-zero elements in a row.
If we do any jumps, we need another Nz * log(Nz) to sort the non-zeros as they don't come out of the heap in order.
If we do a long jump, then the whole thing collapses to N * log(N) anyway, as the heap information is useless.

If Nz isn't much smaller than N (the number of columns), then we're going to see a performance degradation.
Besides, pure iteration is pretty fast if there's no action involved other than to press continue. This is especially true for the indices that are contiguous in memory, and even more so if the branch predictor guesses that action is generally not required for very sparse rows.
So it might be faster to just proceed as we are doing now, with one simple compromise; we can keep track of the next-closest index to the current position, allowing us to quickly skip all-zero rows.

Closed by #51.


[Model Request] MPT 7B (2k and 8k) and MPT 30B (8k)

⚙  Request New Models

Link to an existing implementation (e.g. Hugging Face/Github):

GitHub LLM Foundry:
https://github.com/mosaicml/llm-foundry
Huggingface uploaded models:
https://huggingface.co/mosaicml/mpt-7b
https://huggingface.co/mosaicml/mpt-7b-8k
https://huggingface.co/mosaicml/mpt-30b

Is this model architecture supported by MLC-LLM? (the list of supported models): No

Looks like there was some development that just stopped. Last commit was 3 weeks ago in #460


[Select] Instantly closes after opening when using touch based screen readers

Bug report
Current Behavior
When we're testing the component using a iphone/ipad with voiceover we are unable to select an option. The select closes itself as soon as it has opened.
Expected behavior
The select should remain open when using touch based screen readers
Reproducible example
This behaviour can be reproduced in the example on radix-ui.com
https://www.radix-ui.com/docs/primitives/components/select
Suggested solution
I have not had a chance to dig down into the code to find a solution
Additional context
Your environment

Software
Name(s)
Version

Radix Package(s)
@radix-ui/react-select
0.1.1

React
n/a
17.0.2

Browser
IOS Safari
latest

Assistive tech
Voiceover

Node
n/a
14.18.1

npm/yarn
yarn
1.22.15

Operating System
Windows
10 enterprise

Hey @floppey,
I'm not sure if this was issue was already resolved, but I was unable to reproduce this issue on Safari 14, an older version than the one you specified. It might be an issue unique to Safari 15. I have no access to higher versions of Safari, but I hope someone else is able to resolve this!
:pray:

We haven't had a chance to look at this yet, but thanks for the extra findings @innub.

Are there any updates to this issue? My team is also running into these issues.
We found that setting onPointerDownOutside on the menu content component to a function that prevents the default functionality, that allowed us to select an option. That allowed users to select an option. We did still struggle with selecting the correct option via VoiceOver on iOS until making the menu options larger. Together those provided accurate access to the options via VoiceOver iOS and Android TalkBack as well.


Fix student names endpoint timeout

Getting this error from Logentries:
at=error code=H12 desc="Request timeout" method=GET path="/students/names" host=somerville.studentinsights.org

Strategy . . . gonna cache JSON that powers the searchbar in the database instead of checking authorization for every single student against the current educator.

Still throwing lots of errors, let's see if this helps:
heroku run:detached rake chores:update_searchbar_data_for_educators_who_log_in

@alexsoble Wanted to checkin to see how this is coming. Looks like you were moving the updating of the students for the search bar out of the importer and into a separate job.
Looking into the issue #1023, it appears to me that it is this code that's taking 3+ hours to execute, causing the timeout.
Unfortunately, this means that high school teachers who had students transfer into our out of sections don't see the correct roster for their section in Student Insights.
Looks from your code that the call to Educator.save_student_searchbar_json for each educator should be eliminated? And the rake chores:update_searchbar_data_for_educators_who_log_in should be added to the scheduled nightly jobs?

Hey @jhilde! Hmmmm, what data source are you looking at that shows it takes 3+ hours to execute?
I'm hoping this will give us a little more data: https://github.com/studentinsights/studentinsights/pull/1050
But overall, yes you're 100% right . . . now that we have a task that's precomputed for most of the educators, we don't need to run save_student_searchbar_json for every educator on every import. Good catch, thanks for keeping an eye out here!

Hey @alexsoble, I just looked through logentries to see when each importer began and subtracted. Nothing fancy. I have lots of ideas on doing some more logging on imports but I'll save that for another day soon.
IMHO, it looks like we're trying to reuse the logic in educator.is_authorized_for_student by calling it once per student per educator. I think the reuse of the logic is noble and definitely makes sure the permissions are in sync. For example when I added section permissions, I didn't need to know anything about the json for search bar. But for performance, I might argue that the logic should be duplicated to reduce the overhead of LOTS of redundant queries per educator.

If we wanted to maintain the goodness of centralizing that logic, perhaps we could consider switching to caching the list of students an educator has access to in the database during import. We would probably also want to do something a bit wiser with district_wide and school_wide people so we don't pollute the database too much.
Just some thoughts...

This isn't timing out anymore!

🎊


Tracking issue: Isometry follow-ups

#14269 introduced isometry types to bevy_math. There are some places where it makes sense to integrate these that should probably be addressed in some fashion; the purpose of this issue is to track these.

[ ] Conversion methods relating Transform/GlobalTransform and Isometry3d (note: Isometry3d: Into<Affine3A> already).
[ ] Bounded2d/Bounded3d could use isometry types in addition to raw translations/rotations.
[ ] Gizmos could use isometries to position figures in addition to raw translation/rotations.

These are all relatively similar in flavor, so it would be good if they blended harmoniously together (e.g. making it relatively easy to extract an Isometry3d from a Transform to position a sphere gizmo, for example).

Gizmos could use isometries to position figures in addition to raw translation/rotations.

I'm quite nervous about doubling the API surface there for some sugar 🤔 Is there a benefit that I'm missing?

I'm quite nervous about doubling the API surface there for some sugar 🤔 Is there a benefit that I'm missing?

Well, I'm also nervous about it, but I think it's worth thinking about at least. My main thought here was mostly that the gizmo functions are essentially just indirectly asking for isometries as inputs — on the other hand, just changing the inputs to isometries seems like it could lead to poor ergonomics in cases where an isometry isn't readily on hand (since you'll have to call Isometry3d::new wrapping what you previously would have just passed as parameters). That's why I wrote "in addition to" above: I didn't really give much thought to the fact that that doubles the API surface, though. As I write this, I'm becoming a little more skeptical that the "from raw parts" aspect will be typical if people are primarily going to be extracting these from transforms, so maybe if the story for Transform -> Isometry3d is good, just taking isometries as inputs would be okay.

so maybe if the story for Transform -> Isometry3d is good, just taking isometries as inputs would be okay.

Yeah, that makes sense to me. I think I'd be fine to swap to a pure Isometry API, assuming you can do .into from Transforms :)

Tackling this in https://github.com/bevyengine/bevy/pull/14676 now


TEST contribution

This is a practice contribution for a training module.
Contributor guide pull request
Thanks for contributing to the Microsoft Learn contributor guide. Please read these instructions for processing your pull request (PR). Once you've read this text, delete it and write a brief description of the changes you're proposing.
Quality control

[ ] 1. Successful build with no warnings: Review the build status to make sure all checks are green (Succeeded).

[ ] 2. #Sign-off: Once the PR is finalized and ready to be merged, indicate so by typing #sign-off in a new comment in the PR. Signing off means the document is ready for review and can be published at any time.

Merge and publish

All PRs to this repository are manually reviewed and merged.
Once all feedback on the PR is addressed, we'll merge the PR into the main branch.

Need help?

If you have an open PR, tag the PR reviewers in comment with your question: @carlyrevier, @jehchow
Open an issue in this repo and tag the PR reviewers.

@kunal-yadav-404 - This looks great! If this were a real PR, someone at Microsoft would start the review process now. Because this is just a practice one, I'm going to close it. :) Thanks for being a contributor!


Added autoRefreshToken option

Added an option in the constructor to turn on/off the 1 second token auto refresh timer

PR refused. It will be an idea for the next version. But actually if you want to clean this you need to set your variable to undefined.


missing api gtk_text_buffer_create_tag()

gtk_text_buffer_create_tag() is missing from the api. Is this unimplemented because of varargs?

Yes, cgo does not support calling variadic C functions.
In some cases, where the variadic arguments are to support printf-like functionality, gobbi does provide support. It does this by using fmt.Sprintf to format a string from the arguments, and then calls the C function with the formatted string. However it gets trickier for other types of function.
In many cases there are alternative functions that can be used. And I think that gtk_text_buffer_create_tag is one such case.
Something like this will probably work.
	tag := gtk.TextTagNew("my_tag_name")

	editable := gobject.ValueNew(gobject.TYPE_BOOLEAN)
	editable.SetBoolean(false)
	tag.Object().SetProperty("property-name", editable)

	indent := gobject.ValueNew(gobject.TYPE_INT)
	indent.SetInt(4)
	tag.Object().SetProperty("indent", indent)

	tagTable := gtk.TextTagTableNew()
	tagTable.Add(tag)
	buffer := gtk.TextBufferNew(tagTable)

I'll see about writing a documentation page describing this sort of problem and workaround.

Thanks for the workaround.

https://pekim.github.io/gobbi/variadic-functions/ now contains some general notes about variadic function support in gobbi.
ec4437f7


Question: tox testing target

Hey I apologize if I'm missing something obvious. I've digged through the source code and can't seem to find any way to run the tests (preferably through tox) for only a single language (in my case golang). Thanks for any help on this, I'm very impressed thus far with the tooling, and speed of the compiler.
Also noob question, feel free not to answer but what are you supposed to do with all of the pregenerated coverage files?

tox -e py38 -- -k go

should run only the golang tests.
Re: coverage files
They give us a clue about how much of the transpiler code remains untested after running tox. @jayvdb  is the expert on the topic.

I am not sure what you mean by "pregenerated coverage files".
There is quite a lot of generated files emitted during the test invocation.  And there are .coverage files, which are in theory used by pytest-cov.
We havent been maintaining the .gitignore very well, but a lot of them should be listed there.
We also could change the test output directories so that it is easier to glob them in .gitignore.

Yeah that would be helpful to glob more things in .gitignore , thank you for the command, it is working quite well, I'll close the issue.


modules/output: move outputs to build scope

modules/output: move outputs to build scope
modules/output: add build.initSource option

This PR refactors our output options by moving anything we're "building" to config.build.*. This is also used as an opportunity to rename some of the options. Feedback on the names chosen is appreciated!
The intention is adding some structure to our output options, allowing for growth without things getting too messy..
#2313 is also based on this, since otherwise I'd have to re-write it to resolve merge conflicts.

I've dropped the assertion/warning change from this PR and moved it into a followup: #2313
Hopefully the reduced scope makes it easier to review!

One question: you went from initPath to initSource "implicitly". What is the motivation for this change ?

Actually, initPath was renamed to initFile as I felt this more accurately conveys that it is a built file in the nix-store.
initSource is a new option that allows users to access the init file without byte compilation (as seen in nixvim-print-init). It is only different to initFile when performance.byteCompileLua is used.
Maybe initSourceFile would actually be a better name? Otherwise "source" may wrongly imply it is an input option rather than an output?

Actually, initPath was renamed to initFile as I felt "file" more accurately conveys that it is a built file in the nix-store. Open to feedback though.

Oh right. I agree, this is a better name.

initSource is a new option that allows users to access the init file without byte compilation (as seen in nixvim-print-init). It is only different to initFile when performance.byteCompileLua is used.

Yes, this was perfectly clear to me thanks to the comments.

Maybe initSourceFile would actually be a better name? Otherwise "source" may wrongly imply it is an input option rather than an output?

I think it's fine, no need to change it.


CLI version command should be consistent

❯ defang --version
defang version 662f8f1b
❯ defang version
Defang CLI:    662f8f1b
Latest CLI:    v0.7.0
Defang Fabric: v0.6.0-197-gaa6cb638
I understand if one of those includes the server version but then the --version should also say v0.7.0 instead of just a commit hash

Not sure I follow. --version only shows the version of your current CLI. defang version shows that, but also shows the latest available one.


When transitioning from version 1 to version 2, why was the text editing feature removed?

In version 1, a reference image is used as the background through a visual encoder. By providing bbox information and a text prompt, text is generated on that image background. Is this feature not supported in version 2?
code link v2

If anyone has the version 1 inference code and weights, please share them with me! I would greatly appreciate it.
my email<EMAIL_ADDRESS>


Add support for DB reports

checked in support for both DB1 and DB2 (Only COUNTER 4 is tested... COUNTER 3 is obsolete and I haven't tracked down the format to make test data)


wyrd: fix build

Motivation for this change
wyrd has been broken since 3d24ae9b4426bb8adfcb08de57be21fdf0a377f8. This fix is similar to 8afcfb2bb6681c56ecf21e056d91d6748d953997.
This should also fix the build on non-gcc stdenvs.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Success on x86_64-linux (full log)
Partial log (click to expand)
mv //nix/store/0727pl5zvbdpix7wwpy6vk4kgm31lzs9-wyrd-1.4.6/bin/wyrd.opt //nix/store/0727pl5zvbdpix7wwpy6vk4kgm31lzs9-wyrd-1.4.6/bin/wyrd
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/0727pl5zvbdpix7wwpy6vk4kgm31lzs9-wyrd-1.4.6
shrinking /nix/store/0727pl5zvbdpix7wwpy6vk4kgm31lzs9-wyrd-1.4.6/bin/wyrd
gzipping man pages under /nix/store/0727pl5zvbdpix7wwpy6vk4kgm31lzs9-wyrd-1.4.6/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/0727pl5zvbdpix7wwpy6vk4kgm31lzs9-wyrd-1.4.6/bin
patching script interpreter paths in /nix/store/0727pl5zvbdpix7wwpy6vk4kgm31lzs9-wyrd-1.4.6
checking for references to /tmp/nix-build-wyrd-1.4.6.drv-0 in /nix/store/0727pl5zvbdpix7wwpy6vk4kgm31lzs9-wyrd-1.4.6...
/nix/store/0727pl5zvbdpix7wwpy6vk4kgm31lzs9-wyrd-1.4.6

Success on aarch64-linux (full log)
Partial log (click to expand)
mv //nix/store/p09hvpvlq7k6mwpkwc0km9k7dppmansd-wyrd-1.4.6/bin/wyrd.opt //nix/store/p09hvpvlq7k6mwpkwc0km9k7dppmansd-wyrd-1.4.6/bin/wyrd
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/p09hvpvlq7k6mwpkwc0km9k7dppmansd-wyrd-1.4.6
shrinking /nix/store/p09hvpvlq7k6mwpkwc0km9k7dppmansd-wyrd-1.4.6/bin/wyrd
gzipping man pages under /nix/store/p09hvpvlq7k6mwpkwc0km9k7dppmansd-wyrd-1.4.6/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/p09hvpvlq7k6mwpkwc0km9k7dppmansd-wyrd-1.4.6/bin
patching script interpreter paths in /nix/store/p09hvpvlq7k6mwpkwc0km9k7dppmansd-wyrd-1.4.6
checking for references to /build in /nix/store/p09hvpvlq7k6mwpkwc0km9k7dppmansd-wyrd-1.4.6...
/nix/store/p09hvpvlq7k6mwpkwc0km9k7dppmansd-wyrd-1.4.6

Committed in 1d4bbef0e88a066521ec4fef1e64220149fcadca, picked to 18.03 in bd6d6078c601a5af90dd4ca7a96df2c58bd7bde9 .


Always use QuantityDisplay to display quantities

Before: The <DiagnosticReportDisplay> component had its own logic for rendering Quantity values.  That did not include the Quantity.comparator
After:  The <DiagnosticReportDisplay> component uses the <QuantityDisplay> component, which centralizes the logic for rendering Quantity values.
Bonus fixes:

Removed the space separator between the number and the "%" in percentage quantities (i.e., "10 %" to "10%")
Removed unnecessary <span> elements in <QuantityDisplay>, <RangeDisplay>, and <RatioDisplay>

Coverage decreased (-0.02%) to 95.13% when pulling beb8f1a33b6d3f8a3ef18eabd66c6344bcee41e3 on cody-report-use-quantity-display into 1de6a0dcaa10bc20c71cf8954c31efa58fa270fb on main.


Snap package doesn't have native client

System information:

Operating system (distribution) and version: Ubuntu 18.04 (up-to-date)
DBeaver version: Version <IP_ADDRESS>001051908
Snap installation

Connection specification:

Database name and version: MySQL 5.6.10
Driver name: MySQL Connector Java mysql-connector-java-5.1.44 ( Revision: b3cda4f864902ffdde495b9df93937c3e20009be )
Do you use tunnels or proxies (SSH, SOCKS, etc)? No

Describe the problem you're observing:
For dumping a database, the application needs a native MySQL client. But the snap package doesn't contain that. As intended, non-classic snap packages cannot execute something on the system. So the snap package should contain native clients too.
Steps to reproduce, if exist:
Try to dump something with the snap package.

The same issue works for postgresql, any possible fix?

DBeaver 7.3.4 via snap still has this issue for mysql... any update ??


plugin-height

$plugin-height should be set in _variables.scss "$plugin-height: 66px !default;" and used in _top.scss.
generally vars should be set in _variables.scss with !default so they can be overwritten easily, e.g. "$body-top-offset"

Very good point! I'll change this asap.

#91 Fixed!


Bug fix in Java client, improvement to use of credentials in build/test

Fixed bug in OnshapeDocument that was preventing it from successfully parsing URLs
Added constructor for OAuthTokenResponse in order to construct from stored data
Parameters from .onshape-build file now passed into LibraryTarget, in order to use in build/test process

:shipit:


Polling defaulting to "on" after HA reboot even when previously set to "off"

I noticed that even if I set polling to "off", once I reboot HA, it turns itself back on.  Is this a "feature"?  If so, it would be nice if there is a way to keep it at the set state.  Thanks.

I previously reported this in https://github.com/alandtse/tesla/issues/39 but it was closed for some reason.

Ran into this, so here is my bandaid


Change :input-stream to :input in request map

To Marc's point in
https://github.com/StediInc/exchange-service/pull/5#discussion_r332708798
the request and response map keys should represent the role of the
data and not the format of the data. :input is expected to act like
:body in ring, it starts off as an input stream but the included
middleware will transform it into an edn representation maintaining
the same key name.
/cc @dchelimsky since this would break the middleware that he has already started to form.

Fixes #15


mocha is not running all my suites

Please take a look at this gist:
https://gist.github.com/9799f593133d2b8cafd3

clam, it's my fault. I was doing process.exit at the end of every suite because of mongoosejs blocking the terminal.


drivers: espi: npcx: update for espi reset level

This CL updates the event data returned by eSPI reset ISR.
The event data is indicated the state of eSPIRST.
The 0 means eSPI bus in reset, and 1 means eSPI bus out-of-reset.

Fixes https://github.com/zephyrproject-rtos/zephyr/issues/68557

Note that this fix conforms with the API contract defined by pending PR https://github.com/zephyrproject-rtos/zephyr/pull/68492.


Moving cache_refresh job to upgrade maintenance action

Depends on https://github.com/huggingface/datasets-server/pull/1028

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Codecov Report
Patch coverage: 100.00% and project coverage change: +17.28 :tada:

Comparison is base (d1ab91e) 80.84% compared to head (32a815d) 98.13%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1029       +/-   ##
===========================================
+ Coverage   80.84%   98.13%   +17.28%
===========================================
  Files          35        6       -29
  Lines         757      107      -650
===========================================
- Hits          612      105      -507
+ Misses        145        2      -143

Flag
Coverage Δ

jobs_cache_maintenance
98.13% <100.00%> (?)

jobs_mongodb_migration
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../cache_maintenance/src/cache_maintenance/config.py
100.00% <100.00%> (ø)

...cache_maintenance/src/cache_maintenance/upgrade.py
100.00% <100.00%> (ø)

jobs/cache_maintenance/tests/conftest.py
96.55% <100.00%> (ø)

jobs/cache_maintenance/tests/test_upgrade_cache.py
100.00% <100.00%> (ø)

... and 37 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Will merge this PR since there is nothing critical related, just some refactor to a cache maintenance action that is going to be disabled anyway.


refactor(ansible): store relevant data on watch

Description of the change:
Bring all of the logic for how values are reconciled, and where
important values are stored, into the watches package. This allows us to
handle command line flags, environment variables, defaults, and values
from the watches file in one place with sane defaults.

Add new functions to watches package New() and Validate()
Move getMaxWorkers() to watches package (from runner)
Handle command line arguments in watches package
Update runner package to use Validate() function before creating a runner

Motivation for the change:
Need to validate watch structs before creating runners with them. Previously, this logic was duplicated in watches|runner packages whereas now, before creating a runner we can simply call Validate() on the watch. Helper functions like New() make it possible for those wanting an Ansible runner in a go-based operator can get a watch struct with sensible defaults.
Also want for the logic of how values are handled for ansible based operators to be in one place, now in watches package.

@camilamacedo86 @jmrodri This is part 2 of the work from #1852

Harder than I thought to split this up. :sunglasses:

/test e2e-aws-ansible

/test e2e-aws-ansible

@asmacdo can you check this out since you just wrote the docs for it?

/retest

Tests passing. Let me know if there is anything more you need from me.

/retest


'this should not take long'

Please remove the 'this should not take long' remark while running flow. First of all 'long' is a very subjective property and for me it does take very long (subjectively measured of course :-)). It very often takes more than a minute, which is not weird because it completely depends on the size of the project.

Ok, came back to my own issue once again. It takes very long and there is no way to know why. A flow check takes more than 5 minutes on my project and a flow status very often takes more than 2 minutes. But it is impossible for me to analyze why this is the case. So it would be good to change the message to 'this can take a while'

Totally valid.

This issue should be closed by https://github.com/facebook/flow/commit/46b585269bbdc5e8258c0686515955844419fd1e


Feat/searchseco rewarding/hashreward getter

Description
Simply added a getter for the hashReward variable from SearchSECORewarding(Facet). Also added the getter/setter for this reward to the relevant interface.
Type of change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Ran "npm test"

This change is included in https://github.com/SecureSECODAO/diamond-governance/pull/47