nat, portforwards should not make up a new destination information when unkown

nat, portforwards should not make up a new destination information when a configured dhcp interface does not currently have an address.
fixes: https://forum.pfsense.org/index.php?topic=127585.msg733528#msg733528

This is a dumb question, but wouldn't this affect any default setup of 2.3 since the auto nat rules all make reference to 'WAN Address'?

@vicomte does it? if you suspect a problem please verify the situation you think might go wrong. But afaik normally the address to act on should always be configured. If configuration doesnt match the active situation pfSense imho should not alter rules to 'something different'..


[Discussion] Azure Functions Runtime 2.0.11933 Preview release

Discussion issue for the Azure Functions Runtime 2.0.11933 Preview release

What's the github issue entry for "HttpTrigger does not return response content properly" mentioned in the release notes? Want to read more about this issue as I think we've just run into it

in 2.0.11888 (Java for sure, probably other languages), if you create a response that you intend to be interpreted as a JSON object along with returning an HTTP error code, rather than the client seeing your JSON object it will see only a "canned" string from some mysterious "Custom Error Module". If the return code is ACCEPTED (202) or OK (200), you the expected JSON is returned (if you defined a JSON payload)

In a different thread, which I have lost track of, the syntax for returning an object has changed. You now have to do something like request.createResponseBuilder(HttpStatus.OK).body("Hello, " + name).build(), where the argument to "body" can be (in Java) a HashMap which will result in a JSON body for the receiver.

@TurtleBeach  - Breaking changes for Java Http functions will be part of the next release.

@pragnagopa Is there any ETA for the next release?


disabled list should not show on hover background

I can not reproduce this issue on the demo page. I have attached two screenshots below taken with the mouse above one of the list items (although it's not visible in the screenshot.)
E.g

And when the list is disabled

I have investigated this further and it was being caused by the consuming app specifying its own selection-list class and in turn CSS to deal with disablement. This must have been a left over from when re-com did not style disable lists previously. Apologies. Closing


feat(time_synchronizer): organize twist input

Description
Organize twist input of time_synchronizer as well as concatenate_filter

Tests performed

Not applicable
Effects on system behavior

The node will subscribe to /sensing/vehicle_velocity_converter/twist_with_covariance from now on. But we see no practical effects on the system behavior given that the node is not used yet in the system as far as we know.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

What is the node that uses this synchronizer?

@miursh Would you answer the above question?

@yukkysaito This node is currently not used I think.
Since the current concatenate node has two function ("time synchronization" and "pointcloud concatenation") in it, we (mainly @YoshiRi ) are planning to separate those to another nodes.
https://github.com/autowarefoundation/autoware.universe/blob/main/sensing/pointcloud_preprocessor/docs/concatenate-data.md#node-separation-options-for-future

@kminoda @miursh Thanks :+1:
Note that the sensing component is a pre-processing step of the localization component, so it is better to avoid using localization output.

@yukkysaito Understood. The reason why the proposed implementation both supports twist (for sensing) and odom (for localization) is that the node can be use in both sensing and perception module.


chore(master): release 0.30.0-alpha

:robot: I have created a release beep boop
0.30.0-alpha (2024-01-26)
Features

new (0a4917c)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/mafqla/yalis-blog/releases/tag/v0.30.0-alpha :sunflower:


[SPARK-16289][SQL] Implement posexplode table generating function

What changes were proposed in this pull request?
This PR implements posexplode table generating function. Currently, master branch raises the following exception for map argument. It's different from Hive.
Before
scala> sql("select posexplode(map('a', 1, 'b', 2))").show
org.apache.spark.sql.AnalysisException: No handler for Hive UDF ... posexplode() takes an array as a parameter; line 1 pos 7

After
scala> sql("select posexplode(map('a', 1, 'b', 2))").show
+---+---+-----+
|pos|key|value|
+---+---+-----+
|  0|  a|    1|
|  1|  b|    2|
+---+---+-----+

For array argument, after is the same with before.
scala> sql("select posexplode(array(1, 2, 3))").show
+---+---+
|pos|col|
+---+---+
|  0|  1|
|  1|  2|
|  2|  3|
+---+---+

How was this patch tested?
Pass the Jenkins tests with newly added testcases.

Test build #61461 has started for PR 13971 at commit 584eb9e.

Test build #61461 has finished for PR 13971 at commit 584eb9e.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
abstract class ExplodeBase(child: Expression, position: Boolean)
case class Explode(child: Expression)
case class PosExplode(child: Expression)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61461/
Test PASSed.

cc @rxin and @cloud-fan .

Do we have unit tests for explode expression? (not end-to-end tests)
if not, do you mind looking into it?

Test build #61492 has started for PR 13971 at commit fcfccee.

Hi, @rxin . Thank you for review. I updated the followings.

Add function descriptions for explode and posexplode.
Add examples in comments.
Change indentation to make the fields clearer.

For the explode and posexplode expressions, it seems that we don't have unit tests in expression level because they are generators.

Can we create a suite for unit testing generators?

If you want that for explode and posexplode, sure!
In general, GeneratorTestSuite seems to have not only explode and posexplode, but also UserDefinedGenerator and HiveGenericUDTF.

Yea let's start with that, and we can add more in the future. I'd also add it for the other ones you are implementing, e.g. inline, in those prs.

Sure. Thank you for fast feedback! :)

Now, GeneratorSuite is added.

Test build #61498 has started for PR 13971 at commit e255873.

Test build #61500 has started for PR 13971 at commit 1cf723a.

Now, the followings are updated.

Make sql/GeneratorSuite.scala and moves the testcases from ColumnExpressionSuite.scala.
Remove redundant Serializable and braces.
Fix a typo in PosExplode example.

Test build #61501 has started for PR 13971 at commit c5dee49.

Test build #61492 has finished for PR 13971 at commit fcfccee.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61492/
Test PASSed.

Could you do me a favor?
There is a tiny fix. Could you take a look at https://github.com/apache/spark/pull/13730 ?

This looks pretty good. Let's fix the remaining minor issues and merge it.

Test build #61504 has started for PR 13971 at commit 153e8eb.

I tried to add to Python/R.
But, currently R explode is a little misleading. So, I just committed Python first.
For R, I will clean up explode and posexplode later.

Test build #61509 has started for PR 13971 at commit 0266052.

LGTM pending Jenkins.

Oops. I added R, too. The exactly same semantic of current explode in R.
Yep, please wait for two hours again.

Test build #61512 has started for PR 13971 at commit 5f3a951.

Test build #61498 has finished for PR 13971 at commit e255873.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class GeneratorSuite extends SparkFunSuite with ExpressionEvalHelper

@rxin Thank you for intensive reviewing this PR.
I will improve another PRs (adding new SQL functions) with the same level of quality!

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61498/
Test PASSed.

Test build #61500 has finished for PR 13971 at commit 1cf723a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61500/
Test PASSed.

Test build #61501 has finished for PR 13971 at commit c5dee49.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Explode(child: Expression) extends ExplodeBase(child, position = false)
case class PosExplode(child: Expression) extends ExplodeBase(child, position = true)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61501/
Test PASSed.

Test build #61504 has finished for PR 13971 at commit 153e8eb.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class GeneratorExpressionSuite extends SparkFunSuite with ExpressionEvalHelper
class GeneratorFunctionSuite extends QueryTest with SharedSQLContext

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61504/
Test PASSed.

LGTM except the unit test, @rxin do we need expression level unit test for it?

He added it, didn't he?

Test build #61509 has finished for PR 13971 at commit 0266052.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61509/
Test FAILed.

Test build #61512 has finished for PR 13971 at commit 5f3a951.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61512/
Test PASSed.

If I understand correctly, the remaining issue is checkEvaluation.
I'm sorry for this, but I'm still not sure how to use checkEvaluation for the generators.

Merging in master. Thanks!

Thank you for review and merging, @rxin and @cloud-fan .


Add ESLint and Some Sort Of Code Linting CI Check

Need to have code format checking and have it run on every PR.

The main weirdness here is with the Link component and Next.js. It makes you use an inaccessible <a> tag, but when rendered, the link is complaint with accessibility standards.
https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/issues/402#issuecomment-368305051
A follow up issue would have to be made to correct that, but I won't add linting during CI checks until I've added all components and pages from the MVP app.


set up resuming for failed runs

something like rom suggested where you generate input shard first then you just test if the output shard for that input shard already exists

some additional json for if the shard is complete or not

make it like in video2dataset using input_sharder and all

or we can hack it for now: when you're done writing a shard, write a key_stat.json file as a signal for that shard being done

based on found .json files in dataset folder update this https://github.com/iejMac/clip-video-encode/blob/44f2214032c9219663899cd4e3ef69724af6f619/clip_video_encode/clip_video_encode.py#L113


Fix support for pydantic 2.8.0's mypy plugin

Description
Pydantic added a new field to better support generic's variance.  It default to False for now based on pydantic's default value for the caller of to_argument.
It's unclear if this is needed in the context of graphql schemas where there shouldn't really be frozensets.
Please let know if I can improve this.
Types of Changes

[ ] Core
[x] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[ ] Documentation

Issues Fixed or Closed by This PR

fixes #3560

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

I don't know if there are more ways to test, previous change to support 2.7.0 did not seem to have any test change other than the version in the noxfile, to which I added 2.8.0.

Summary by Sourcery
This pull request fixes compatibility issues with Pydantic 2.8.0's mypy plugin by adding necessary fields and updates the test configuration to include Pydantic 2.8.0.

Bug Fixes:

Added support for Pydantic 2.8.0's mypy plugin by including the 'force_typevars_invariant' field with a default value of False.

Tests:

Updated the noxfile to include Pydantic 2.8.0 in the test matrix for Pydantic tests.

Hi, thanks for contributing to Strawberry 🍓!
We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!
So as soon as this PR is merged, a release will be made 🚀.
Here's an example of RELEASE.md:
Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)
Here's the tweet text:
🆕 Release (next) is out! Thanks to Martin Roy for the PR 👏

Get it here 👉 https://strawberry.rocks/release/(next)

Thanks for contributing to Strawberry! 🎉 You've been invited to join
the Strawberry GraphQL organisation 😊
You can also request a free sticker by filling this form: https://forms.gle/dmnfQUPoY5gZbVT67
And don't forget to join our discord server: https://strawberry.rocks/discord 🔥


chore: dedup yarn lock

Current dependencies on/for this PR:

main

PR #100   👈

This comment was auto-generated by Graphite.


Can´t convert DER Certificate to PEM

I try to convert a DER formatted certificate to PEM format. i used the command for that from sslshopper.
locally over the Console it worked, but when i try it in nodejs i get the following callback:
OpenSSL process ends with code 1
x509: Invalid format "openssl/der" for -inform
x509: Use -help for summary.
At first i thought its just a problem with the in cert, so i tried to give the command the local Dir of the cert. i also tried to give it the cert as object.

I believe kind of issue. Probably you give argument 'der' but 'openssl' is concated to the string. Openssl seems to not understand 'openssl/der'. I have the same issue with pem (exactly with 'openssl/pem'). I've removed this 'openssl' concat and now have only 'pem' - works good.

Problem with this code:
if (checkCommandForIO(parameters[i]) && typeof parameters[i + 1] !== 'object') {      parameters[i + 1] = dir + parameters[i + 1];  }
to be more exact
const checkCommandForIO = element => element.includes('-in') || element.includes('-out')     || element.includes('-keyout') || element.includes('-signkey') || element.includes('-key')
outform param includes out so it adds openssl/ to DER

did you ever figure out the solution? im having the exact same problem but im not sure i understand the issue Driim  and Peer are talking about in regarrds to the concat of openssl. Will take a look at the source code, but im wondering if it's an issue with how i am writing the request, but it works fine on terminal


docs(point people): adding a link to our full list

The type of this PR is: Documentation

This PR resolves []
Description

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests/stories for my changes, or my changes don't require testing/stories, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

#nochangelog
Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Warnings

:warning:

✅ No changelog changes

  Generated by :no_entry_sign: dangerJS against 788b7f09dcc24457a5a7e3ccf0a13c0ef22f94c1

whoops sorry for delay


Is there a way to focus on a table row?

Feature Description
I would like to focus on a table row
Use Case
Coming back to a page with a table, I would like to focus on the previous row that I clicked. It would be nice to be able to add a focus attribute that handles that.

Technically if you want to let a row be focused, you need to give it a tabindex=0 but this breaks accessibility. By default rows are not focusable: https://stackblitz.com/edit/angular-3pzfih-q2wzts?file=src%2Fapp%2Ftable-basic-example.html
If instead you are looking for just a way to provide extra styling to a particular row, you can simply add a class binding to the row that is conditional based on some value you set: https://stackblitz.com/edit/angular-opbexf?file=src/app/table-basic-example.ts


Support action [add repository to F-Droid app]

Example QR code
https://fluffychat.im/en/fdroid.html

I was thinking of something like this:
https://f-droid.org/en/packages/de.markusfisch.android.binaryeye/


Epic: Support Azure Blob storage in the scrubber

Motivation
We want to run the same tools on Azure Blob storage that we run on S3.
DoD
The scrubber supports Azure Blob storage as well as S3.
Implementation ideas
I'd implement this via extending the remote_storage crate to cover the use cases of the scrubber and porting the scrubber to it.
This doesn't have to happen in one go, but can go command-by-command. For the transition period, the scrubber could create both S3 and remote_storage contexts and then have each command use whatever it supports.
Tasks

[x] #7932
[x] https://github.com/neondatabase/neon/pull/8013
[ ] https://github.com/neondatabase/neon/issues/8457

Other related tasks and Epics

#5567
https://github.com/neondatabase/neon/issues/7667

This week:

https://github.com/neondatabase/neon/issues/8457
Maybe another PR that migrates some subcommands


feat: add Coolblue store (NL)

Description
Adds the Coolblue store since they seem to have stock sometimes since this morning.
Testing
I changed the URL into a 2060 to test, it seemed to work. I'm new to Javascript though (and pull requests in general), so let me know if I did anything weird!

Thank you!


Right to Left support

Fixes https://github.com/bdlukaa/fluent_ui/issues/181
Pre-launch Checklist

[x] I have run dartfmt on all changed files
[x] I have updated CHANGELOG.md with my changes
[x] I have run "optimize/organize imports" on all changed files
[x] I have addressed all analyzer warnings as best I could
[ ] I have added/updated relevant documentation
[ ] I have run flutter pub publish --dry-run and addressed any warnings

Does this is expected ? (the ? char at the left)

Wrong icon or wrong movement, but it's not clear

This is maybe OK like that, but...

I think that's come from Flutter, but I'm pretty sure that's not what is expected:

I haven't looked at the code yet.
Btw: it's a really weird effect

Does this is expected ? (the ? char at the left)

Idk, but ig it is.


CSV service account cluster permissions revoked too early

Bug Report

What did you do?
I am experimenting with the olm based operator shutdown/cleanup process.
A runnable  is added to the controller runtime manager (used to implement the operator) that also requires leader election.
This runnable blocks until the manager receives a SIGTERM (ctx cancelation is used by the mgr) and deletes some external resource (in a different namespace than the operator).
To manage the external resource a call is made to K8s apiserver using the operator's service account.
That service account has several rights. However when the related operator CVS is deleted (teardown) and the runnable is waited (manager waits for that) to finish before the pod is terminated I get the following error (last thing seen in logs):
{"level":"info","ts":"2021-07-05T19:21:03.723Z","logger":"cmd","msg":"Deleting the Knative health dashboard"}
{"level":"error","ts":"2021-07-05T19:21:03.726Z","logger":"cmd","msg":"Deleting the health dashboard failed","error":"configmaps \"grafana-dashboard-definition-knative-health\" is forbidden: User \"system:serviceaccount:openshift-serverless:knative-operator\" cannot delete resource \"configmaps\" in API group \"\" in the namespace \"openshift-config-managed\"","stacktrace":"main.cleanupRunnable.Start\n\t/go/src/github.com/openshift-knative/serverless-operator/knative-operator/cmd/manager/main.go:155\nsigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).startRunnable.func1\n\t/go/src/github.com/openshift-knative/serverless-operator/vendor/sigs.k8s.io/controller-runtime/pkg/manager/internal.go:681"}
E0705 19:21:03.981627       1 leaderelection.go:325] error retrieving resource lock openshift-serverless/knative-serving-openshift-lock: configmaps "knative-serving-openshift-lock" is forbidden: User "system:serviceaccount:openshift-serverless:knative-operator" cannot get resource "configmaps" in API group "" in the namespace "openshift-serverless"
I0705 19:21:04.223592       1 leaderelection.go:278] failed to renew lease openshift-serverless/knative-serving-openshift-lock: timed out waiting for the condition
{"level":"error","ts":"2021-07-05T19:21:04.223Z","logger":"controller-runtime.manager","msg":"error received after stop sequence was engaged","error":"context canceled"}
{"level":"error","ts":"2021-07-05T19:21:04.223Z","logger":"controller-runtime.manager","msg":"error received after stop sequence was engaged","error":"leader election lost"}
rpc error: code = NotFound desc = could not find container "71710bf12ffe7dd76be0be24bb3bafc5f05dd07d5d09a8acfc6e2d48c2e520de": container with ID starting with 71710bf12ffe7dd76be0be24bb3bafc5f05dd07d5d09a8acfc6e2d48c2e520de not found: ID does not exist

What did you expect to see?
Cluster permissions not being revoked since they might be needed by the operator during a graceful shutdown. If I just restart the pod that runnable does what is expected to do.
What did you see instead? Under which circumstances?
Resources like rbac rights being removed.
Environment

operator-lifecycle-manager version:
I am on OCP 4.7.12.

Kubernetes version information:

I am on OCP 4.7.12.

Kubernetes cluster kind:

Possible Solution

Additional context

Is the issue that OLM removing the operator pod and RBAC associated with the operator before the pod is finished terminating, which causes errors that you are seeing above in your operator logs? In this case, OLM should not GC those resources before the pod has been removed. This indicates an issue with the CSV GC logic in the olm operator.
Currently there is no ordering in child object removal when the CSV is removed. We rely on kube GC to remove all dependent objects when the CSV is removed, so the ordering is non-deterministic.
There are several potential solutions here and we will continue to triage further.

@exdx yes afaik that is the problem.

@timflannagan is going to create an RFE on the OF Proposal Board that focuses on improving OLM so that it does not delete resources in a random order.

I am removing this from the 0.20.0 release as it likely will not make it in that quickly.

@awgreene @timflannagan did the RFE make it to the proposal board yet? This seems like a fundamental requirement for ordered tear-down of an operator.

In the meantime, a workaround that I suggested in today's working group meeting is that you could set a finalizer on the RBAC roles/rolebindings your operator needs to exist during its cleanup.
Your operator would need permission to set and remove those finalizers, which you could grant with this RBAC rule.
- apiGroups:
  - rbac.authorization.k8s.io
  resources:
  - roles/finalizers
  - rolebindings/finalizers
  - clusterroles/finalizers
  - clusterrolebindings/finalizers
  verbs:
  - update

Obviously this grants your operator otherwise unnecessary permissions, which if abused (e.g. via a vulnerability) could enable an attacker to add finalizers to all (cluster)role(binding)s and thus block their deletion.
An even better solution (which is still in an unmerged Kubernetes EP) would be for OLM to apply the "in use" protection mechanism to prevent deletion of resources used by the operator deployment: https://github.com/kubernetes/enhancements/blob/b873c9966236ca3eace2ce16666b342255e50a6e/keps/sig-api-machinery/2839-in-use-protection/README.md
Longer term, I think the answer is that OLM needs to become less opinionated about the mechanics of install/uninstall and give more power and flexibility to operator authors. For example, we are investigating support for a plain manifest bundle format in which operator authors can directly include static manifests that could contain finalizers and in-use protection mechanisms they need to ensure an orderly deletion.

I will try the workaround and see how it goes.

We're hitting the same issue in the sriov-operator. We are trying to clean up the env when the operator is removed, but we the required permissions are getting removed before our pods finish the cleanup.
The suggested fix will unfortunately not solve the issue completely. It will allow the cleanup to happen, but at the end we'll end up with a role and rolebinding, from which we will have to remove the finalizers. We will have to remove it from one resource first (rolebinding), and then we will not have the permissions to remove the other (role), because the rolebinding will not be there. Please let me know if I'm missing something here.

Tried out the above solution, and it looks like it behave just as described. We loose the permissions right after removing either the role or rolebinding.


docs: Add multiple values in whenChoiceValue and whenLabelValue

PR fulfills these requirements

[x] Docs have been added/updated (for bug fixes/features)

:rocket:
This description was created by Ellipsis for commit 99db19acd7c8119c4e9a062450be9151261e755d

docs: support multiple values in whenChoiceValue and whenLabelValue
Summary:
Update documentation and code to support multiple values for whenChoiceValue and whenLabelValue.
Key points:

Update documentation to support multiple comma-separated values for whenChoiceValue and whenLabelValue.
Modify View.jsx and Choices.jsx to handle multiple values.
Update docs/source/tags/view.md and docs/source/tags/choices.md with new examples.
Add examples and update parameter descriptions in View.jsx and Choices.jsx.

Generated with :heart: by ellipsis.dev

Taxonomy didn't have these parameters in docs, so we decided to leave it as is.


Parsing VCless runs by comparing who is in the server and who isn't

Simple parse command to check which IGNs in the /who are registered to this or another server Guill is in.
Can be called serverparse.

Note, this would count under parses when it comes to quota for securities.

Alternatively, the info logged by who reacted in a vcless raid with the JOIN button (see https://github.com/ToogaInc/ToogaBooga/issues/243) can be used to crosscheck with the /who instead.

Parses vcless runs by checking who has officially joined the run using the join button or confirmed early react.


Are Weights Reduced When Running Model.Predict After It Has Been Trained With Dropout?

Hey Keras Dev's, really appreciate what you've done.
I was reading the guide on dropout, and I saw that they usually halve their weights when using a model if they use a dropout of 0.5. I'm strictly talking about when you have finished training and using the model.predict function.
Here is the guide:
http://neuralnetworksanddeeplearning.com/chap3.html
Here is a quote from the guide:
"By repeating this process over and over, our network will learn a set of weights and biases. Of course, those weights and biases will have been learnt under conditions in which half the hidden neurons were dropped out. When we actually run the full network that means that twice as many hidden neurons will be active. To compensate for that, we halve the weights outgoing from the hidden neurons."
Does Keras automatically half the weights (or the corresponding dropout you use) when you use the model.predict function? If not, I believe it could lead to overfitting.

You can read the code of our Dropout layer in keras.layers.core.Dropout. We don't touch the weights, but the output of the Dropout layer is rescaled in testing mode.

Thank you for the response. I will modify the prediction output model to reflect changes on dropout accordingly on my scripts!


feat: nicer z.function() messages

Before
Validation error: Invalid function arguments

Validation error: Invalid function return type

After
Validation error: Invalid function arguments; Expected number, received string at index 0

Validation error: Invalid function return type; Expected number, received string"

@abesto you should be able to merge this PR now, but let me know if not and I can push the button on your behalf.

@jmike please push the button :)


FileNotFoundException when compiling templates

Hi there,
I'm periodically running into the following issue. When I call the Compile method:
System.IO.FileNotFoundException: Could not find file 'C:\Windows\TEMP\RazorEngine_lfwzmkby.hyf\CompiledRazorTemplates.Dynamic.RazorEngine_cae87e534dd3478997ea489146bac6fa.dll'
This seems to happen with certain templates, not all. I'm looking for any guidance as to what may be the issue here. Is it possible the cache is being cleared out prematurely?
var engine = RazorEngineContext.Current.RazorEngine;
if (!engine.IsTemplateCached (templateKey, modelType))
    engine.Compile (templateSource, templateKey, modelType);

return engine.Run (templateKey, modelType, model).Trim ();

Full stack trace below:
File name: 'C:\Windows\TEMP\RazorEngine_lfwzmkby.hyf\CompiledRazorTemplates.Dynamic.RazorEngine_cae87e534dd3478997ea489146bac6fa.dll'
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
at System.IO.File.InternalReadAllBytes(String path, Boolean checkHost)
at RazorEngine.Compilation.DirectCompilerServiceBase.CompileTypeImpl(TypeContext context)
at RazorEngine.Compilation.DirectCompilerServiceBase.CompileType_Windows(TypeContext context)
at RazorEngine.Compilation.DirectCompilerServiceBase.CompileType(TypeContext context)
at RazorEngine.Templating.RazorEngineCore.CreateTemplateType(ITemplateSource razorTemplate, Type modelType)
at RazorEngine.Templating.RazorEngineCore.Compile(ITemplateKey key, Type modelType)
at RazorEngine.Templating.RazorEngineService.CompileAndCacheInternal(ITemplateKey key, Type modelType)
at RazorEngine.Templating.RazorEngineService.Compile(ITemplateKey key, Type modelType)
at RazorEngine.Templating.DynamicWrapperService.Compile(ITemplateKey key, Type modelType)

Seems like restarting the box fixed this issue, but I'm still curious as to why or how this could happen. Based on my observations the folder/.dll was created in windows/temp and immediately deleted...

I had a very similar issue in production.  Changing permissions, identity of app pool, etc didn't fix it.  A restart of the Windows server did the trick though.  First time hitting it in a couple of years so I won't lose too much sleep over it yet :)

+1. Currently experiencing this issue. Restarting daily. Seems to have something to do with the volume of pages processed.


Docs: Add awardWorkflow

Pull Request Test Coverage Report for Build 122

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.5%) to 97.542%

Totals

Change from base Build 118:
0.5%

Covered Lines:
1627

Relevant Lines:
1668

💛  - Coveralls

Pull Request Test Coverage Report for Build 122

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.5%) to 97.542%

Totals

Change from base Build 118:
0.5%

Covered Lines:
1627

Relevant Lines:
1668

💛  - Coveralls


device_map='auto' causes memory to not be freed with torch.cuda.empty_cache()

System Info
If I load a model like this
model = AutoModelForCausalLM.from_pretrained("models/opt-13b", device_map='auto', load_in_8bit=True)

and then do
model = None
torch.cuda.empty_cache()

the VRAM is not freed. The only way I have found to release it is to kill the program and start it over.
Freeing the memory like this works if the model is loaded the normal way with
model = AutoModelForCausalLM.from_pretrained("models/opt-13b", low_cpu_mem_usage=True, torch_dtype=torch.float16).cuda()

I have created this issue on the transformers repository and was redirected here. @sgugger has suggested that the load_in_8bit=True part may be the culprit.
Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[ ] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[ ] My own task or dataset (give details below)

Reproduction
Code snippet is provided in the description above.
Expected behavior
VRAM should be freed with torch.cuda.empty_cache().

I'm reopening this issue, as I've noticed that this problem still exists :)
In a nutshell, as long as the device mapping is used, memory won't be freed by torch.cuda.empty_cache(). Here's a script for reproducibility
from transformers import AutoModelForCausalLM
import torch

# this works okay, no memory allocated
model = AutoModelForCausalLM.from_pretrained("facebook/opt-1.3b")
del model
torch.cuda.empty_cache()
print(torch.cuda.memory_allocated(0))

# GPU memory > model memory requirements -> fails to clear out memory
model = AutoModelForCausalLM.from_pretrained(
    "facebook/opt-1.3b", device_map="auto", max_memory={0: "20GiB", "cpu": "50GiB"}
)
del model
torch.cuda.empty_cache()
print(torch.cuda.memory_allocated(0))

# GPU memory < model memory requirements -> fails to clear out memory
model = AutoModelForCausalLM.from_pretrained(
    "facebook/opt-1.3b", device_map="auto", max_memory={0: "1GiB", "cpu": "50GiB"}
)
del model
torch.cuda.empty_cache()
print(torch.cuda.memory_allocated(0))

cc @sgugger

Does it make you go OOM? Last time I investigated this, the memory was not officially available, but if you tried to use the GPU it found it again.

@sgugger If we loop over the initialization with device mapping, it is stable, but not the same -- it uses model allocated memory + memory that failed to clear up.
In the particular case I ran into this bug was when trying two large models in the same script, to compare their results -- the memory did not deallocate when deleting the first model, running into an exception (OOM) when loading the 2nd. Running the exact same code one model at a time throws no exceptions.

I am investigating this. Note that as a first step, adding
import gc

gc.collect()

along with every torch.cuda.empty_cache() fixes the issue on my side.


Would it be possible to make the normalisation optional?

Hello,
We use BAGEL often and are working to add it into our pipeline.  Because we use CNV correction tools upstream it means that our counts are already normalised before we come to run BAGEL.
Would it be possible to make the total normalisation optional so we can use the fold change calculator from BAGEL in our pipeline?
Many thanks in advance!
Victoria

Hello Victoria,
Thank you for using BAGEL.
We'll update our pipeline soon for providing option to turn off CNV correction and use BAGEL fc  instead.
Best,
Eiru Kim.

Hi Victoria,
Sorry for late update.
I've updated new pipeline 'run_bagel.py', which doesn't employ CRISPRcleanR.
Hope it works for your pipeline.
Best,
Eiru Kim.


Indenting error, and generated code syntax error

The first is a minor error where it looks like + is not recognized as a line continuation:
curl https://raw.githubusercontent.com/cryptonomex/graphene-ui/master/dl/src/chain/serializer_validation.coffee | decaffeinate | egrep "{)"
...
125 :                 "#{reserved_spaces}.#{object_type}.[0-9]+ "+
^^^ :                ^

If you fix that or work-around (save the file and remove that \n) then decaffenate will generate invalid JavaScript:
        if (is_empty(value) {)
It looks like the { and ) are transposed...

The transposition was fixed in v1.44.1. I opened #110 to track the trailing binary operator bug.


layoutSubviews ignores enabled property

layoutSubviews ignores the enabled property, hence resets the appearance of the button to enabled while it may actually be and work as enabled.
My simple but dirty workaround is the following:
extension BFPaperButton {
	override public func layoutSubviews() {
		super.layoutSubviews()
		self.enabled = self.enabled
	}
}

Hi @ujikol !
Thank you for pointing this out to me! I believe I just fixed it and released a new version, 2.1.1.
Please let me know if the bug still persists after updating :)
Thanks!


An ability to use FindAll annotation

I believe it's good idea to allow usage of FindAll annotation in addition to FindBy to save "native" way to annotate lists of page elements.

Oh, sorry. It's misunderstanding.

@msdjl No problems! Feel free to send new pull requests!


[Bug] Login with Google returns user to step 1 again during the donation process.

Which area(s) of Podkrepi.bg are affected?
Donation
Describe the Bug
When I initiate a donation before being logged:

I input the donation amount. (step 1)
I login via Google
I have to input the donation amount again (step 1)

To Reproduce

Initiate a donation without being logged in
Login via Google

Expected Behavior
When I initiate a donation before being logged in:

I input the donation amount. (step 1)
I login via Google
Step 2

Which browser are you using? (if relevant)
Safari Version 15.5

I think that this is happening because the google login is refreshing the page. The refresh creates a brand new stepsContext with the initial values. The first thing that comes to my mind is to store the step in localStorage. You can assign the task to me. I'll also try to think of another way to fix this.

@momchiii I found some good info on how we can do it without the hassle:
Take a look at this article: https://frankmeszaros.medium.com/use-localstorage-and-formik-to-supercharge-your-form-experience-a175d68e5ecb
The article is kind of a do it yourself approach.
I also found this: https://github.com/kolengri/formik-persist-values, which if it works and is maintained might be a good fix.
That will leave the steps context to handle by ourselves, but that would be a small job if the whole formik state already is saved


Use Optional Permissions to contextualize chrome permission requests

proxy and socket access permissions can likely be made optional to soften the chrome permission request at initial install.
It sounds like this could be a major win for not scaring people at install.
https://developer.chrome.com/extensions/permissions

(originally posted in https://github.com/uProxy/uproxy/issues/627)
Bad news regarding optional proxy permission - it doesn't work. The documentation for optional permissions (https://developer.chrome.com/extensions/permissions) doesn't list "proxy" as being optional, and when I tried it anyways I see this error:
Unchecked runtime.lastError while running permissions.request: The optional permissions API does not support 'proxy'.
We will bring this up with our contacts in the Chrome team but for now it seems we will have to deal with users immediately being prompted with "Can read and change all your data on the websites you visit" when they install the Chrome extension.

Regarding permissions for the app, we currently see the confirmation "Exchange data with any computer on the local network or internet" when installing the app.
We are using these permissions:
  "sockets": {
    "tcp": { "connect" : "" },
    "tcpServer": { "listen": "" },
    "udp": { "send": "", "bind": "" }
  },

I'm not sure but it seems like maybe we can change these to only specify a limited set of IP addresses / URLs?  If so maybe we can get that warning to be less scary.
I'm not sure though that optional permissions are that important for the app, because the user will need to confirm those permissions as soon as they log into a social network - and users can't really do anything in uProxy (for now, until we have copy+paste or networks that don't use sockets) until they sign into a social network

Right: we could imagine only asking for appropriate socket permissions when
you take the action to share / get access: get access means needing
tcpServer, share access means needing connect & send / bind permissions.
I think this is probably low priority - but it seems like a nice user
experience to tie the permissions directly to the user action where they're
needed.
On Wed Jan 07 2015 at 9:27:38 AM dborkan<EMAIL_ADDRESS>wrote:

Regarding permissions for the app, we currently see the confirmation
"Exchange data with any computer on the local network or internet" when
installing the app.
We are using these permissions:
"sockets": {
"tcp": { "connect" : "" },
"tcpServer": { "listen": "" },
"udp": { "send": "", "bind": "" }
},
I'm not sure but it seems like maybe we can change these to only specify a
limited set of IP addresses / URLs? If so maybe we can get that warning to
be less scary.
I'm not sure though that optional permissions are that important for the
app, because the user will need to confirm those permissions as soon as
they log into a social network - and users can't really do anything in
uProxy (for now, until we have copy+paste or networks that don't use
sockets) until they sign into a social network
—
Reply to this email directly or view it on GitHub
https://github.com/uProxy/uproxy/issues/720#issuecomment-69057547.

I agree, this should be a low priority if we can't delay proxying permissions, which is the biggy. re-prioritizing.

Turns out that you can't ask or proxy access later - that's the big scary one. I don't think delaying other permissions will help us, so I'll close this.


Split geometry & textures

When you split a piece of geometry the new faces automatically apply the RealtimeCSG dev material. It would be nice if it would take a material that is already being used on the geometry.

Well if you have multiple materials it might pick the wrong one .. It would be somewhat random
Maybe it could pick the material of the side you draw the split plane on? Or maybe something like, it would pick the last selected material in unity?

Again back to SourceSDK, they have a pane showing your active texture. Something like that might be nice.

That sounds like a good idea :)

Setting the default texture is now implemented in 1.402!
I will close this ticket once that version is on the asset store

This version is now available on the asset store, so I'm closing this ticket


Fix Navigation for requests in Heroku

When trying to submit forms, the following error comes up:
Cannot GET...... undefined
Forms that are not currently working:

The sign up form
The submit request form
Edit your Profile  form
Single request page is not working

this is all working in Heroku. We added the  component to all relevant pages

this is all working in Heroku. We added the  component to all relevant pages


[go] Add CenturyLink support

[x] I've verified and I assure that I'm running youtube-dl 2018.01.21
[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[x] Feature request (request for a new functionality)
[ ] Question
[ ] Other

PS C:\Users\rumag\Desktop\youtube-dl> py -3 -m youtube_dl --all-subs --ap-username USERNAME --ap-password PASSWORD --ap-mso DTV "http://watchdisneychannel.go.com/andi-mack/video/vdka4245399/02/102-andi-mack-cast-party
" -v
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--all-subs', '--ap-username', 'PRIVATE', '--ap-password', 'PRIVATE', '--ap-mso', 'DTV', 'http://watchdisneychannel.go.com/andi-mack/video/vdka4245399/02/102-andi-mack-cast-party', '-v']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] youtube-dl version 2018.01.21
[debug] Python version 3.6.4 (CPython) - Windows-10-10.0.16299-SP0
[debug] exe versions: ffmpeg N-86911-gb664d1f, ffprobe N-86911-gb664d1f, rtmpdump 2.4
[debug] Proxy map: {}
[Go] vdka4245399: Downloading JSON metadata
[Go] VDKA4245399: Downloading Provider Redirect Page
[Go] VDKA4245399: Downloading Provider Login Page
[Go] VDKA4245399: Logging in
[Go] VDKA4245399: Confirming Login
[Go] VDKA4245399: Retrieving Session
ERROR: Unable to download webpage: HTTP Error 401: Unauthorized (caused by <HTTPError 401: 'Unauthorized'>); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "C:\Users\rumag\Desktop\youtube-dl\youtube_dl\extractor\common.py", line 517, in _request_webpage
    return self._downloader.urlopen(url_or_request)
  File "C:\Users\rumag\Desktop\youtube-dl\youtube_dl\YoutubeDL.py", line 2198, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "C:\Users\rumag\AppData\Local\Programs\Python\Python36-32\lib\urllib\request.py", line 532, in open
    response = meth(req, response)
  File "C:\Users\rumag\AppData\Local\Programs\Python\Python36-32\lib\urllib\request.py", line 642, in http_response
    'http', request, response, code, msg, hdrs)
  File "C:\Users\rumag\AppData\Local\Programs\Python\Python36-32\lib\urllib\request.py", line 570, in error
    return self._call_chain(*args)
  File "C:\Users\rumag\AppData\Local\Programs\Python\Python36-32\lib\urllib\request.py", line 504, in _call_chain
    result = func(*args)
  File "C:\Users\rumag\AppData\Local\Programs\Python\Python36-32\lib\urllib\request.py", line 650, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
...
<end of log>

Single video: http://watchdisneychannel.go.com/andi-mack/video/vdka4245399/02/102-andi-mack-cast-party

Description of issue
Is it possible to add CenturyLink? I tried with DTV since they have a partnership, but it's not working. CenturyLink is avaible on the website. And if you could make sure the one called "CenturyLink Prism" would work, it would be nice.

I tried adding the MSO to the adobepass.py file but I got a url parse error. I'm willing to test if someone thinks they have a fix.


FlexTable + CellMeasurer combination should not appear in the site's wizard

I have tried to use CellMeasurer with FlexTable, following the indications in the site's wizard section:
<CellMeasurer
  cellRenderer={yourCellRenderer}
  columnCount={numColumns}
  rowCount={numRows}
  width={800}
>
  {({ getRowHeight }) => (
    <FlexTable
      headerHeight={30}
      height={600}
      rowCount={numRows}
      rowGetter={({ index }) => collection.get(index)}
      rowHeight={getRowHeight}
      width={800}
    >
<!-- Insert FlexColumn children here -->
    </FlexTable>
  )}
</CellMeasurer>

However, the library author states in Stack Overflow that this is not possible.
What's the final word on this? If both components are not compatible, maybe this option should be removed from the wizard.

I don't think it makes sense to use FlexTable and CellMeasurer together. CellMeasurer has some limitations and I think this is probably outside of its scope.
I'll update the wizard so that this combination is not shown as valid. :)

Updated! :)


Question about search criteria

Is there a way to check if the LAST (a.k.a. more recent) comment was made by a specific author?

Hi @pantelis-karamolegkos
If you check the action inputs you can specify the direction as last.
https://github.com/peter-evans/find-comment#action-inputs


Incompatibility of the dropdown list of administrative monitors

Screenshot:

The background of the list of administrative monitors is still white.
Testing with:

jenkins-core at branch timja/dark-mode (https://github.com/jenkinsci/jenkins/commit/86c0bd01de)
dark-theme at master (commit https://github.com/jenkinsci/dark-theme/commit/f31189f)

Fixed


DataLogger and DataStreamer: fix possible out of range exception when using Scroll view

Fix out of range exception in DataViews.Scroll when Streamer is updated will Render() is running
This should fix issue #3429

Very Good, I approve


Error "group_j__data has no attribute capnp" when trying to register a farm

Steps

Installed kosmos from scratch (development branch),
set up a farm (https://github.com/threefoldfoundation/info_grid/blob/development/docs/tf_farming/setup_farm_using_jsx.md )

Issue
When executing :
j.tools.threebot.init_my_threebot(
name='myname.3bot',
<EMAIL_ADDRESS>description="anything can go here")
Error "group_j__data has no attribute capnp"

Sorry, not latest version of code used. I'll close.


Publish on GH tag

Can you describe how this works to me?  Do we need to connect github to rubygems's authorized list somehow?  How can we be sure that a tag was a release tag and not some other random tag?

@bkroeker The tag would have to start with v, but we can tweak it to make it more specific than that. In terms of RubyGems, you'll need to add an API key to the secrets for the repo. I don't think I can do it since you own the repo. Then I'll probably need to tweak the workflow a bit to get it to use the credentials correctly

Actually, looks like we can make probably make GHA a trusted published. Will look into it a bit

Updated to use the official rubygems publisher action. trusted publisher is setup on rubygems as well


docs: Where are  material design in ionic ? share link

Type: docs
Ionic Version: 2.x
Platform: all
Hi ! how long time for official material design for ionic ?
if you already hosted please share link.

On the components page, above the phone preview, you can view the Android preview too:
http://ionicframework.com/docs/v2/components/

@adamdbradley  ok!  really Awesome work, actually I am switching onsen UI to ionic v2 in production.
thanks


Remove run_machine_concurrent_hot_reload device lab test

This was testing that concurrent reloads were rejected. This is now allowed (as of #55376 (which has non-device-lab integration + unit tests).

Landing on red to fix devicelab failure.


[BUG] Unexpected serialization of maps in informal trace format

Description
Singleton maps are deserialized to #map: [ "key": "value" ] instead of #map: [ [ "key": "value" ] ] in informal trace format.
Is this expected? I don't see any mention at ADR-015.
Example
"#map": [
  "cosmoshub",
  0
]

Expected behavior
"#map": [
  [
    "cosmoshub",
    0
  ]
]

That's a bug. Fixed in #1296. Check and approve.

I checked the build. It works :+1: thanks


Add coarsen to metrics comparison script

This PR pulls the coarsening logic out of a jupyter notebook and into a more useful script for generation of metrics at native resolution to the comparator.

@ajijohn


Updated upgrade path

Description

This PR adds the <IP_ADDRESS> to <IP_ADDRESS> upgrade path

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):
How Has This Been Tested?

This has been tested by starting up the client and checking the version table in the db.

@orangutan package

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1061

Trillian test result (tid-1254)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26822 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3971-t1254-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_02_vpc_privategw_static_routes
Failure
180.24
test_privategw_acl.py

test_03_vpc_privategw_restart_vpc_cleanup
Failure
178.13
test_privategw_acl.py

test_04_rvpc_privategw_static_routes
Failure
229.62
test_privategw_acl.py

I have tested this upgrade path by:

Installing cloudstack version 4.13
Create an instance on an isolated network in an advanced zone.
Point yum repo to new packages
Update cloudstack to <IP_ADDRESS>
Restart management server
Create a new instance
Restart the VR

tests passing, 2 x LGTMS - merging


Remove outdated links

awesome-lint fails with
  ✖  1:1  The repository should have "awesome-list" as a GitHub topic  remark-lint:awesome-github

I cannot fix, only @mattjegan can. I wrote him an email to fix.


Update to tslint 4.0.1 and TypeScript 2.0.10

Fixed some new issues with tslint --fix and raised max-classes-per-file to 2

Thanks for your interest in palantir/tslint-react, @tiagoefmoraes! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@nchen63 can you please take a look

@adidahiya looks good to me

thanks @tiagoefmoraes!


Implement AttachedProperties for RenderOptions

What does the pull request do?
RenderOptions are not able to be defined via Styles as they are no AvaloniaProperties. This leads to the needs that each individual control needs to set the RenderOptions
What is the current behavior?
RenderOptions cannot be set "easily"
What is the updated/expected behavior with this PR?
RenderOptions can be defined inside Styles
How was the solution implemented (if it's not obvious)?
Introduced AttachedProperties for all RenderOptions
Checklist

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/avalonia-docs with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues
Fixes #12786

@Gillibald if I don't inherit the properties, they only work if set BEVORE App start. But it would be great to be able to change it whenever one likes to. If you have any idea how to fix it, let me know.

I will leave final review for @Gillibald, but from previous discussions this API doesn't seem to be a good tradeoff. RenderOptions are inherited by nature (without being an avalonia property). And making them an attached property adds an unwanted overhead.

@maxkatz6 I'm open to other API ideas here. But I still think being unable to set these globally either by style or by AppBuilder would be great for convenience. If the overhead is too big, sure that is a valid point though.

I intentionally avoided using attached properties for render options. Defined render options are automatically propagated and merged. So inheritance is already in place.

closing as per internal discussion


Feedback for Tecno page

Thank you so much for my warmly account and business

This business 😂 is amazing 😍

I will be enjoying it


Snake case to pascal case gives "_" before number

When I try to change from snake-case to PascalCase, I get an _ in front of a number, using<EMAIL_ADDRESS>pascalCase('layout-1-col');
// => Layout_1Col

This is intended behavior. Please check the relevant README for alternatives.


Remove use of events from NodeController, to temporarily fix #6199

Self-merging because #6199 is P0.

Thanks. This fixed the build:
https://travis-ci.org/GoogleCloudPlatform/kubernetes/builds


Unknown group in CollateralReinvestmentGrp component

Hi,
I have found that the CollateralReinvestmentGrp component contains a reference to the group with id 2266 which is not present in the dictionary at all.
<fixr:component name="CollateralReinvestmentGrp" id="2266" category="Common" added="FIX.5.0SP2" addedEP="254" abbrName="CollRnvstmnt">
	<fixr:groupRef added="FIX.5.0SP2" addedEP="254" id="2266">
		<fixr:annotation>
			<fixr:documentation/>
		</fixr:annotation>
	</fixr:groupRef>
	<fixr:annotation>
		<fixr:documentation purpose="SYNOPSIS">
 The CollateralReinvestmentGrp component block is a repeating group that may be used to provide a breakdown of the cash collateral's reinvestment types and amounts (e.g. CollateralType(1704)="CASH").
		</fixr:documentation>
		<fixr:documentation purpose="ELABORATION"/>
	</fixr:annotation>
</fixr:component>

Probably, that group had been missed when the dictionary was created. Or it's a mistake in the group id. Could you check it, please?

It looks like CollateralReinvestmentGrp should be a <group> rather than a <component>.  Investigating.

This is a specification coding bug.  The group is coded as an XMLDataBlock and should be BlockRepeating.  SPEC-2441 ticket added.

The issue has already been registered for FIX Specification as "CollateralReinvestmentGrp component incorrectly coded as XMLDataBlock - should be BlockRepeating".

Corrected with EP257


Add basic, unergonomic CLI

Runnable right now with cd bakery then yarn node ./src/cli/execute.js --help
execute.js and the task file changes are what is of interest. I am aware there is a lot of yarn dependency noise in here.

@ripal what version of yarn are you using?

I'm currently using yarn version 1.22.0 and node version 13.9.0.

Interesting. I'm using yarn berry (v2). I believe that's part of the problem. I might convert the repo back to npm because this is turning out to be more trouble than it's worth.

@ripal let me know if this works for you (you may have to clean out some things and npm install)

@tomjw64 - Yes, things are working now, thanks!


Redundant information in output

Describe the bug
Output notifications often contain duplicated or redundant information
How to reproduce it
For a full example run Falco with K8s support enabled and the event-generator. I tried using the Helm chart, with this command:
helm install falco falcosecurity/falco --set fakeEventGenerator.enabled=enabled

Then, you should get notifications continuously.
Most of them will contain duplicate information related to k8s metadata, for example:
15:29:40.515013896: Notice System user ran an interactive command (user=bin user_loginuid=-1 command=login container_id=46c99eea62a8 image=docker.io/falcosecurity/event-generator) k8s.ns=default k8s.pod=falco-event-generator-84d64cb8fb-zmxgz container=46c99eea62a8 k8s.ns=default k8s.pod=falco-event-generator-84d64cb8fb-zmxgz container=46c99eea62a8

You can notice how k8s metadata are duplicated and the container id is reported in two different fields (container and container_id)
Expected behaviour
No duplicate info in output, if possible.
Screenshots

Environment

Falco version:
0.30.0
System info:

Cloud provider or hardware configuration:
OS:

Kernel:

Installation method:

Additional context

--- a/userspace/engine/lua/rule_loader.lua
+++ b/userspace/engine/lua/rule_loader.lua
@@ -1103,6 +1103,9 @@ function load_rules(rules_content,
                  v['output'] = v['output'].." "..extra
               end
            end
+            if string.sub(v['output'], 1, 5) == "Mount" then
+                print('XXX', _, v, name, v['output'])
+            end
         end

         -- Ensure that the output field is properly formatted by

Yes. So that's an obvious bug then:
$ userspace/falco/falco -c falco.yaml
  --validate issue1785/application_rules.yaml
  --validate issue1785/falco_rules.yaml
  --validate issue1785/k8s_audit_rules.yaml
  --validate issue1785/falco_rules.local.yaml
  --validate issue1785/custom_rules.yaml -pk 2>&1  | grep ^XXX

XXX	65	table: 0x7fd642119538	Mount Launched in Privileged Container	Mount was executed inside a privileged container (user=%user.name user_loginuid=%user.loginuid command=%proc.cmdline k8s.ns=%k8s.ns.name k8s.pod=%k8s.pod.name container=%container.id image=%container.image.repository:%container.image.tag)

XXX	65	table: 0x7fd642119538	Mount Launched in Privileged Container	Mount was executed inside a privileged container (user=%user.name user_loginuid=%user.loginuid command=%proc.cmdline k8s.ns=%k8s.ns.name k8s.pod=%k8s.pod.name container=%container.id image=%container.image.repository:%container.image.tag) k8s.ns=%k8s.ns.name k8s.pod=%k8s.pod.name container=%container.id

XXX	65	table: 0x7fd642119538	Mount Launched in Privileged Container	Mount was executed inside a privileged container (user=%user.name user_loginuid=%user.loginuid command=%proc.cmdline k8s.ns=%k8s.ns.name k8s.pod=%k8s.pod.name container=%container.id image=%container.image.repository:%container.image.tag) k8s.ns=%k8s.ns.name k8s.pod=%k8s.pod.name container=%container.id k8s.ns=%k8s.ns.name k8s.pod=%k8s.pod.name container=%container.id

XXX	65	table: 0x7fd642119538	Mount Launched in Privileged Container	Mount was executed inside a privileged container (user=%user.name user_loginuid=%user.loginuid command=%proc.cmdline k8s.ns=%k8s.ns.name k8s.pod=%k8s.pod.name container=%container.id image=%container.image.repository:%container.image.tag) k8s.ns=%k8s.ns.name k8s.pod=%k8s.pod.name container=%container.id k8s.ns=%k8s.ns.name k8s.pod=%k8s.pod.name container=%container.id k8s.ns=%k8s.ns.name k8s.pod=%k8s.pod.name container=%container.id

The same rule 65 (0x7fd642119538) from state.rules_by_name gets processed 4 times and its values get mutated.

(1) Either load_rules should be ran only once in total,
(2) or the rule state should be reset before consecutive calls,
(3) or the processed rule should be marked as already-processed.

Here's a super quick fix for (2):
diff --git a/userspace/engine/lua/rule_loader.lua b/userspace/engine/lua/rule_loader.lua
index 22f98c0..d0432c9 100644
--- a/userspace/engine/lua/rule_loader.lua
+++ b/userspace/engine/lua/rule_loader.lua
@@ -1083,6 +1083,11 @@ function load_rules(rules_content,
         -- with extra. Otherwise, add extra onto the end of the format
         -- string.
         if v['source'] == "syscall" then
+           if v['_output'] == nil then
+              v['_output'] = v['output']
+           end
+           v['output'] = v['_output']
+
            if string.find(v['output'], "%container.info", nil, true) ~= nil then

               -- There may not be any extra, or we're not supposed

@wdoekes
Whoa, good catch! PR? :smile_cat:

cc @jasondellaluce @mstemm

PR? :smile_cat:

I figure I'd like a design decision first.
Why would we parse all rules 4 times. Isn't running only the last time sufficient?
The hack from (2) is really just a band-aid. Adding that to the overcrowded load_rules function, feels totally wrong. I'd rather mark the processed rules as already-processed instead, and skip them sooner.

This should now be fixed in https://github.com/falcosecurity/falco/pull/1966


Nodes and Properties duplicate and disappear

I was using this driver and stumbled upon some issues where properties disappear and labels duplicate when running queries.
This same problem doesn't occur when using redis-cli or the Python client.
I wrote about this problem in two issues on FalkorDB:
https://github.com/FalkorDB/FalkorDB/issues/628
https://github.com/FalkorDB/FalkorDB/issues/630
This issue arises in the oldest published version of redisgraph-go, the latest commit in redisgraph-go and the latest commit in this repo.

@AviAvni could you please take a look ?

just checked both queries and they return the correct result

Could you try running the following Go code and see what it outputs?
package main

import (
	"context"

	"github.com/FalkorDB/falkordb-go"
)

func Main() {
	fdbConn, _ := falkordb.FalkorDBNew(&falkordb.ConnectionOption{
		Addr:     "localhost:6379",
		Protocol: 3,
	})
	graph := fdbConn.SelectGraph("")

	fdbConn.Conn.FlushAll(context.Background())

	returned, _ := graph.Query("CREATE (y{N:0, M:0}) RETURN y", nil, nil)
	returned.PrettyPrint()

	fdbConn.Conn.FlushAll(context.Background())

	returned1, _ := graph.Query("CREATE (x{n0:0}) DELETE x CREATE (y{N:0, M:0}) RETURN y", nil, nil)
	returned1.PrettyPrint()
}

For me, I get:
+-----------+
|     y     |
+-----------+
| {N:0,M:0} |
+-----------+

Nodes created 1.000000
Properties set 2.000000
Cached execution 0.000000
Query internal execution time 1.081698

+-------+
|   y   |
+-------+
| {M:0} |
+-------+

Query internal execution time 1.051177
Nodes created 2.000000
Properties set 3.000000
Nodes deleted 1.000000
Cached execution 0.000000

Am I using the driver in an unintended way?

the problem is how you use the client
the client maintain a cached schema
when you call FlushAll you make discrepancy between the schema cached in the client and the schema in the database
when ever you flush the db just call SelectGraph again to get rid of the old cached schema

@DominicWuest I can see how this can cause confusion. on other clients e.g. our Python client we've got a graph.delete API which replaces FlushAll we'll add this functionality to our Go client shortly.

Works like a charm, thanks for the help @swilly22 and @AviAvni!


Closes softlayer/sl-ember-components#1148

hold on this, i might have misinterpreted the docs


Summary CI failing due to missing action

Describe the bug
Summary CI workflow is failing due to a missing action
 Unable to resolve actions. Repository not found: koj-co/readme-repos-list.

Looks like this action has been moved to https://github.com/AnandChowdhary/readme-repos-list and archived
To Reproduce
Steps to reproduce the behavior:

Make new repo from template
Observe that Summary CI workflow fails

Expected behavior
Workflow CI workflow should run correctly
Screenshots

Workflow File
This is the workflow file that is failing

# This file was generated by<EMAIL_ADDRESS>#
# ===============================
# Do not edit this file directly!
# ===============================
#
# Your changes will be overwritten when the template updates (daily)
# Instead, change your .upptimerc.yml configuration: https://upptime.js.org/docs

name: Summary CI
on:
  schedule:
    - cron: "0 0 * * *"
  repository_dispatch:
    types: [summary]
  workflow_dispatch:
jobs:
  release:
    name: Generate README
    runs-on: [self-hosted, linux, X64, philips]
    container: node:16

    steps:
      - name: Checkout
        uses<EMAIL_ADDRESS>        with:
          ref: ${{ github.head_ref }}
          token: ${{ secrets.GH_PAT }}
      - name: Update summary in README
        uses<EMAIL_ADDRESS>        with:
          command: "readme"
        env:
          GH_PAT: ${{ secrets.GH_PAT }}
      - name: Run readme-repos-list
        uses: koj-co/readme-repos-list@master
        with:
          token: ${{ secrets.GH_PAT }}
          query: "topic:upptime"
          size: 20
          max: 1000
          one-per-owner: true

Looks like it needs changing
here https://github.com/upptime/uptime-monitor/blob/master/src/helpers/workflows.ts#L241
or
here https://github.com/upptime/uptime-monitor/blob/master/src/workflows/summary.yml#L34
or both? Not sure on the duplication.

I have unarchived it, so let's see if it works now? Because GitHub automatically redirects moved repositories, it was working this whole time so it's weird that it doesn't work now.

I still seem to be having the same issue. Maybe it is not respecting redirects for some reason?

I am running on self-hosted runners that have no restrictions on which actions they can use.

When I manually update the workflow to reference the relocated action it works. Of course this eventually gets overwritten with the original again and breaks.

@AnandChowdhary when will a new version be released and used? Looks like the package has not been released in a while.
Where else does it need to be bumped once released?

All done!

awesome..
all green now


Update Contributors.md

Add my name for that sweet 👕 !

@Sukeer, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?
We’ve recently added Facebook share and tweet feature to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.


Chat freezing when going too fast.

Describe the bug
Chat freezes every few seconds when chat is going too fast. I'm not sure if it's because of the amount of messages, or other reasons. My guess is that this is a limitation of the API, but I have no clue.
To reproduce
Just open a chat that has a lot of messages sent constantly (xQcOW, for example), and you'll see it. Well, maybe I guess.
Screenshots
Example of the freezing: https://gfycat.com/livelynimblecanadagoose
Chatterino version
Chatterino 2.1.7 (commit 845c8fa63)
Operating system
Windows 10

To my knowledge this is not a Chatterino issue.
What I see in the video you have provided is the chat buffering, almost like an online video would.

To my knowledge this is not a Chatterino issue.
What I see in the video you have provided is the chat buffering, almost like an online video would.

Thinking about it more, I feel like it's something on my end, but I have no idea what it could be. Settings don't seem to change anything. I couldn't find any other issues for this problem either which also makes me believe it's only me as well.
I've just noticed that my chat messages aren't sent when it's frozen/buffering like this.

does this happen on other clients, like web chat and Chatty for example?

In normal twitch chat it happens as well but it's not as bad. Chatty is about the exact same as twitch chat.

This is intentional behavior and has nothing to do with Chatterino. Any IRC client connected to Twitch will have this "buffering" when a chat is going quickly.
Not exactly sure why it was implemented (maybe to help moderators moderate in a fast-moving chat?), but to prove it isn't Chatterino, notice how mods and VIPs seem to "bypass" this pausing period (in this case, Fossabot) and messages they send are actually seen.
Additionally, the average user that sends a message during this time period will have it dropped and not displayed to other chat members (unless, of course, the conditions mentioned above are met).

I see, I didn't even notice the bot bypassing it. I also asked my friends and they said that it's the same for them. Well, I guess that's that.


Add javascript-node and typescript-node

@samruddhikhandale Thanks for the detailed feedback! I have addressed all your comments. Could you take another look?


convert the qeury result to it real type

Now the query result is from WS where the result is all string type, it is better to convert the string type to the real time according to https://github.com/timeplus-io/docs/blob/main/docs/datatypes.md

(Jove Github Bot) moved this ticket out of the GitHub project(up to 1200 tickets for one project).


Refactor props.children.count to only include valid react elements

Hi Ken -- Awesome carousel. Thanks very much for open-sourcing it.
I am looking to use it in a project at work to swipe between a few products based on some filtering by a user.
I had a small issue with how the slideCount is calculated.
Our use case should show 3 products based on the user's choices. If our search returned less than 3 products we were displaying a message in place of the missing third product. If not, this just returned null. In this situation Nuka Carousel was adding an extra slide to the carousel for null so that we were always showing 4 slides instead of the 3 we should have been.
This solution checks that each of the children are valid elements before adding them to the count.
I have adjusted the example to show the problem this PR solves. If you want to try the current version with an invalid element you'll see that it allows you to swipe to an empty slide.
Thanks again,
Laurie

This PR looks awesome! can you remove the example from the demo and rebase and I'll get this merged?

Thanks Ken! Let me know if there is anything left to address.

Closing this PR because it's too old to merge, but addressing this issue in our current build under PR #379


add common install-apps  configuration in parent pom

I should remove <appsDirectory>apps</appsDirectory> from the parent pom and let the smart default logic to handle.


Save Request to Project Enhancement

Originally reported on Google Code with ID 192
Saving modifications to a request that is already part of a project is inefficient.
Here is the current procedure.

Open and modify a request that is already part of a project.
1. Click Save
2. Click Add to Project (it's already part of a project)
3. Select the project to save to (this should already be known)
4. Click Overwrite

This could be accomplished with a lot fewer clicks, such as adding a Save As feature
and making overwriting the original request to the original location the default option.
This would also bring the functionality inline with common software paradigms.

On what operating system, browser and browser version?
Win 7 x64, Chrome 29.0.1547.0 dev-m

Please provide any additional information below.
Please contact me if you like<EMAIL_ADDRESS>

Reported by johnschram on 2013-07-22 17:46:16

It is long fixed


Can't post to the Godot community forum

Godot version
3.5
System information
Mac osx 12.5
Issue description
Hi,
I know it's not the right place to post it.
I already asked 3 questions in the Godot community forum but they are still pending for approval for more than 72h!! So I am unable to ask questions there or create another account... Can somebody tell me what's wrong?
Thank you
Steps to reproduce
Post a question in the Q&A section...
Minimal reproduction project
No response

The Godot github issue list is for tracking engine bugs only. At the top of the Godot forums there is a big button that says "Help/Contact" Please use that to seek support from the forum maintainers

Approvals on Q&A website are done by volunteer moderators, so it can take a few days for posts to be approved. This is a necessary measure we had to add to combat spam, which is still an unresolved problem on Question2Answer-based websites.


Add assume_missing to read_csv/read_table

This adds an option to read_csv/read_table to assume all inferred integer columns are actually floats in disguise. Note that columns that are specified to be integers in dtype= are not converted to floats. An improved error message was also added, to collect all mismatched integer/float columns and report them to the user.
Example:
In [1]: text = ('numbers,names,more_numbers,integers\n' +
   ...:         '\n'.join(['1,foo,2,3'] * 1000) +
   ...:         '\n1.5,bar,2.5,3')

In [2]: with open('test.csv', 'w+') as f:
   ...:     f.write(text)
   ...:

In [3]: import dask.dataframe as dd

In [4]: dd.read_csv('test.csv', sample=50).compute()
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<...>
ValueError: Mismatched dtypes found.
Expected integers, but found floats for columns:
- 'more_numbers'
- 'numbers'

To fix, specify dtypes manually by adding:

dtype={'more_numbers': float,
       'numbers': float}

to the call to `read_csv`/`read_table`.

Alternatively, provide `assume_missing=True` to interpret all unspecified integer columns as floats.

In [5]: dd.read_csv('test.csv', sample=50, assume_missing=True).compute().dtypes
Out[5]:
numbers         float64
names            object
more_numbers    float64
integers        float64
dtype: object

In [6]: dd.read_csv('test.csv', sample=50, dtype={'numbers': float, 'more_numbers': float}).compute().dtypes
Out[6]:
numbers         float64
names            object
more_numbers    float64
integers          int64
dtype: object

Fixes #2097.

This looks great to me.  Merging.  Thanks for the fast fix.
@moody-marlin can you inform Luke?

Awesome!  @mrocklin he has been informed.


Spec simplifications

What was the end-user problem that led to this PR?
The problem was that the current specs don't pass under docker.
What was your diagnosis of the problem?
My diagnosis was that we should use <IP_ADDRESS> instead of <IP_ADDRESS> for mirror specs, since docker likes it better and the change doesn't affect the intention of the specs.
What is your fix for the problem, implemented in this PR?
My fix is to do that change, but also add a few extra simplifications that I created while setting up the specs to run inside a docker image.
Why did you choose this fix out of the possible options?
I chose this fix because it works and makes the test setup simpler.

Well, just by looking at the description one can see that this PR is not really focused on a single subject either :rofl:... @hsbt Let me know if I should also split this into: general spec improvements vs docker fixes.

The stuff here is explained commit per commit, affects only specs, and makes them more robust, so I'm going to merge it.
@bundlerbot r+

👍  Looks good. When we found the regression or issues, We will fix it.


Specify disk size in config

hard-coded now

also --size command line opt

relates to / similar to #22


Suggestion: SQLite, PostgreSQL and Base (Java databases) directly entries

I'd like to merge directly from SQLite and PostgreSQL mainly. OpenOffice Base connection should good too.
Using ODBC drive can be a great update. :)

Kindly see issue #143 for more detailed answer.
Examples for different databases are in the SG wiki:
https://github.com/berteh/ScribusGenerator/wiki/Other-data-sources#export-from-a-standard-database
Please add more examples for Java databases or JBDC or OOo engines, to help
others.
The following could help you making the bridge:
http://digiassn.blogspot.com/2006/07/java-creating-jdbc-connection-to.html?m=1
I'd be happy to integrate some code that helps bridge with other databases
if you want to push some.
Have a nice day.
Berteh

I close the issue as the workaround seem satisfactory to me.
Feel free to re-open if you think it's important or you want to implement this yourself.
Thanks.


Create release checklist issue template

In https://github.com/timescale/promscale/issues/890 we've been tracking progress on releasing 0.7.0. It would be great to have a GitHub issue template which we could use to create issues with pre-filled checklists for the next release.

Example template: https://github.com/openshift/cluster-monitoring-operator/blob/master/.github/ISSUE_TEMPLATE/release.md


Missing this. on gpt.js

In the following line this. is missing.
https://github.com/kolbytn/mindcraft/blob/a6edd8fc44813e01c4decfda3d6b6ee018671620/src/models/gpt.js#L47
making the code to throw the following message:
SES_UNHANDLED_REJECTION: [ReferenceError: sendRequest is not defined
  at GPT.sendRequest (file:///media/pansutodeus/Data/repos/mindcraft/src/models/gpt.js:47:17)
  at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
  at async Prompter.promptConvo (file:///media/pansutodeus/Data/repos/mindcraft/src/agent/prompter.js:198:16)
  at async Agent.handleMessage (file:///media/pansutodeus/Data/repos/mindcraft/src/agent/agent.js:186:23)]

this only happens if the following condition is met and throws the exception
https://github.com/kolbytn/mindcraft/blob/a6edd8fc44813e01c4decfda3d6b6ee018671620/src/models/gpt.js#L39-L40
fix:
return await this.sendRequest(turns.slice(1), systemMessage, stop_seq);

you're right


Add find_label_type

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (e7d85bc) to head (bc48d89).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #109   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           36        36
  Lines          859       866    +7
  Branches        96        98    +2
=========================================
+ Hits           859       866    +7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


DIP56: add pragma(inline)

http://wiki.dlang.org/DIP56
This makes the syntax valid, and will issue errors if forceinline'd functions cannot be inlined. It also implements neverinline, meaning the while(0){} hack is no longer needed.
Not implemented yet: inlining forceinline'd functions even if -inline is not present. I'll implement that later, as it's more complicated.

will issue errors if forceinline'd functions cannot be inlined.

I'm very happy to see this.
Would you consider using a string instead of a boolean?  It would then be self-documenting, and could be extended in the future.  There has been disagreement in the past over what (inline, true) should mean, so it's probably not perfectly intuitive.
pragma(inline, "always"):
pragma(inline, "never"):

finally, magicport has accepted my sacrifices and it now works

I take it you're not running magicport locally?

Nope. I want to switch to DDMD yesterday, not deal with magicport :-)

Would you consider using a string instead of a boolean?

No, the boolean is plenty good enough. I can't imagine anyone thinking that inline=false turns on inlining.

I can't imagine anyone thinking that inline=false turns on inlining.

Can you imagine someone thinking that inline=true doesn't force inlining? i.e. your original proposal.

This makes the syntax valid, and will issue errors if forceinline'd functions cannot be inlined.

Pure awesomeness.

Auto-merge toggled on

Nice! Manu will rejoice :)


Bond python should support type alias with custom type

e.g. In the static_array example, one of the fields is a std::array, bond python considers this a regular container and tries to expose it using regular container methods like insert, erase, push_back, and this fails because these methods do not exist in std::array.
It is not hard to write an array_indexing suite and add it to bond python, but a better approach is probably to allow the user to specify their own custom schema_fields_visitor class which will be a template parameter of struct_ with a default to the given schema_fields_visitor.
This way the user can add any custom type, and expose it to python.

What is the scenario for exposing custom C++ types to Python?

In my scenario my struct has a std::array, which I accomplish by following the directions in the example static_array.
I don't know of another scenario that will have a different struct, but I think that bond should allow for it.

Why are you mapping std::array when generating C++ code to be used to build a Python module? You can use a .bond file with type aliases w/o doing custom type mapping. In that case the generated code will have the aliased type (std::vector in your case).
Mapping a custom C++ type is obviously useful when you are using the generated code in a C++ program. However when your business logic is written in Python, not C++, why do you even care if the C++ type used to provide the Python mapping was std::vector?

I am using type alias, but if I try to export it to python it   exports the std::array not the underlying std::vector, which fails because it is not supported (as I wrote in the original post).
I am using a static array because I want bit to be clear in the interface exactly how many elements there should be.
The business logic is written in C++ but is exposed to python.

So you would like the size limit enforced by std::array to apply to Python mappings?
It would be possible, I guess, although I'm not sure if it would be very Pythonic. Python doesn't have fixed size arrays, does it?
Note also that Bond type system doesn't have fixed size arrays. Mapping an alias of vector<T> to std::array doesn't change the fact that from the schema/wire format perspective it is still a variable length list. Thus Bond itself won't enforce the size limit.

Yes, I would like the size limit to apply to the Python bindings, if I am not mistaken this is the same thing that happens in numpy arrays, so I don't think it would be too unPythonic.
I am aware that the wire format does not support a fixed size array, but that is fine because the exposed struct does enforce it..

This is relevant for our use case as well, any updates on allowing this?

No work has been done in this area lately, and none is planned by the core Bond team.

In the end I specialized boost::python::container_utils::extend_container and boost::python::vector_indexing_suite for std::array
Not the nicest solution (because it assumes that the array will be exported using the vector_indexing_suite and this can change in a later release), but it allows to export std::array without modifying the existing python export code.


Restore --timing

From the commit message:
options/typechecker: restore --timing by aliasing it to the profiler

This simply makes the option enable the profiler as needed.

Fixes #2768

The solution is slightly hackish, but does the trick.

Thanks @mtzguido!


Avoid to load jaxb when it is useless

cause compilation error; try 'return pClass.cast(value);'

@amarkevich thks for the catch, used (T) style as other/nearer casts in this method - just for consistency.

regarding '(T) style': its used for primitives (L433, L453); 'pClass.cast(...)' used in other places

@amarkevich fair enough. Can I ask some deeper review on the "if (pClass == String.class && !adapterHasToBeUsed)" coming next the block I added, if this is important - and somehow covered/coverable in tests - then we should move to the jaxb boolean we have to test if we must try jaxb handling or bypass it cause missing. I'm not fully sure we want to keep that. My understanding is that it is to use @XmlJavaTypeAdapter on method parameter but not sure it is something used or to keep with param converter of JAX-RS.

It doesn't look like we have any test in place that would handle that particular case.   We have XmlAdapters that go from the on-the-wire string to custom types, but nothing that would go from something else on the wire to a string.     That said, I BELIEVE it's something that is supposed to be supported from the specs.

@dkulp it is not in JAX-RS spec, do you have another spec in mind?

JAXB in particular.   In any case, I just pushed a test case for it.  :)

JAXB has no word about JAX-RS so don't think so as well, it is a CXF specific feature AFAIK
will close this one to open another PR (using my IDE instead of github online edit since it needs more work than I thought)
thanks guys for the feedback


1/11 Office add-ins Community Call Blog Post

New Blog Post for January 11 Office add-ins community call.

Currently trying to find answer to last question in Q&A which is why there is no answer, but everything else should be up to date. Also, the other commits from December are already in the blog, feel free to disregard those I just did not remove those commits from this PR, but they will not make answer difference in the repo.

@preethikakiru I saw your comment after I did the edit! Hopefully, I did not "over edit" this one. Linda

@preethikakiru I saw your comment after I did the edit! Hopefully, I did not "over edit" this one. Linda

Nope your edits were great, thanks for reviewing! Just addressed all of them!

@preethikakiru Approved!


Add docs on how to improve performance by mixing synced folder types

See https://github.com/geerlingguy/drupal-vm/issues/1242#issuecomment-289130181.
How's that? Or maybe under the synced folder section as it's more a feature than a performance improvement suggestion

This placement seems appropriate to me.

Going to do a little testing before merging, though (I trust you, but I want to see how much of an impact this could make for poor forlorn Windows non-10 devs.

Don't merge just yet btw, I'll test this too and probably change the example to use drupal-project structure drupal/web rather than drupal/public so it's easier for people to understand.

So it didn't work :) It seems that since we updated the examples to use local_path: . the excluded_path examples have been incorrect. You cant reference a parent directory in the path.

Sharing guest to host is great for php performance on large codebases. We do it for some vagrant projects.  I would suggest samba / smb as a protocol since all hosts have passable clients for it.
The drawbacks are:

Not having access to the codebase when the VM is shut down (you can't check on something quick without waiting for it to boot)
All the compatibility, configuration and performance problems move to the IDE / text editor, which now has to not choke on the "remote" codebase, or use inappropriate features on it like SASS compilation or git management.

@yareckon - Especially "performance problems move to the IDE / text editor" — global find-and-replace is an especially slow performer.

@oxyc - I'm okay with merging this as-is, if the way it's currently written works.
Maybe we could also add a link to the article Drupal VM on Windows - a fast container for BLT project development, which has some recommendations around reverse-mounting a Samba share, or using SSH sync like with PhpStorm?


Invariant Violation: requireNativeComponent: "ContextMenu" was not found in the UIManager.

I'm getting this error while running the app in expo

@BR19-gh I think you need to make a new development build and this should go away.

Dupe #77


Church Bells

About the PR

Adds a church bell to be used with station chapels
idea, sprites, and sound by Kezu, put together by me.

Why / Balance
"if the jani gets their jani light for convenience and rp, the chapel gets a church bell to signal for sermons" -Kezu
RP purposes, and to give something to chap similar to something like Clown's horn. Would let Chaps use it to get passerby's attention and whatnot.

Media

There is a .ogg sound added, but I'm not sure how to make it play nice with git, please someone bwoink me with how

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl: Sphiral&Kezu

add: Added Church Bells! You may hear otherworldly chimes near your local chapel soon...

based

I don't know what others will say, but I think the current realization.... rather illogical.

I agree with Ed and the proposed solution: the sound is way too long and should be broken up into individual rings. You'll also need to add an entry for it to attributions.yml.

At the moment, the bell sound is a rather long soundtrack, which will continue to play as if the bell is being struck, even if you move away from the bell. I would change the logic to the following: create a collection of bell sounds, and play the sound every time someone physically hits the bell.

Yeah, the original idea was that the bell was rocking back and forth from a single interaction, and Kezu was even thinking about making an animation for it. But I'll throw together some sounds and see if I can do the collection thing.


2023 Chevy Equinox not recognized

Describe the bug
Car not recognized during startup
Which car does this affect?
2023 Chevy Equinox with ACC
Provide a route where the issue occurs
https://useradmin.comma.ai/?onebox=a717a483baa7b362|00000002--7eb6112851
openpilot version
0.9.7
Additional info
Car par isn’t blank so I think it is seeing car but having issues trying to finger print car.

did other type of fingerprinting and got 127 msg for a bit then 128 msg consistently tried putting them each and together in my data/openpilot/selfdrive/car/gm fingerprint.pv file and cannot get it to work still.   257:8 is missing when it only shows 127 msg, this is the 128 msg data:190: 6, 193: 8, 197: 8, 201: 8, 209: 7, 211: 2, 241: 6, 249: 8, 257: 8, 288: 5, 289: 8, 298: 8, 304: 3, 309: 8, 311: 8, 313: 8, 320: 4, 322: 7, 328: 1, 352: 5, 381: 8, 384: 4, 386: 8, 388: 8, 413: 8, 451: 8, 452: 8, 453: 6, 455: 7, 463: 3, 479: 3, 481: 7, 485: 8, 489: 8, 497: 8, 500: 6, 501: 8, 532: 6, 560: 8, 562: 8, 563: 5, 565: 5, 587: 8, 608: 8, 609: 6, 610: 6, 611: 6, 612: 8, 613: 8, 707: 8, 715: 8, 717: 5, 761: 7, 789: 5, 800: 6, 810: 8, 840: 5, 842: 5, 844: 8, 869: 4, 880: 6, 977: 8, 1001: 8, 1011: 6, 1017: 8, 1020: 8, 1033: 7, 1034: 7, 1217: 8, 1221: 5, 1233: 8, 1249: 8, 1259: 8, 1261: 7, 1263: 4, 1265: 8, 1267: 1, 1271: 8, 1280: 4, 1296: 4, 1300: 8, 1609: 8, 1611: 8, 1613: 8, 1649: 8, 1792: 8, 1793: 8, 1798: 8, 1799: 8, 1810: 8, 1813: 8, 1824: 8, 1825: 8, 1840: 8, 1842: 8, 1856: 8, 1858: 8, 1859: 8, 1860: 8, 1862: 8, 1863: 8, 1871: 8, 1872: 8, 1875: 8, 1879: 8, 1882: 8, 1888: 8, 1889: 8, 1892: 8, 1920: 8, 1927: 8, 1930: 7, 1937: 8, 1953: 8, 1954: 8, 1955: 8, 1968: 8, 1969: 8, 1971: 8, 1975: 8, 1988: 8, 1990: 8, 2000: 8, 2001: 8, 2004: 8, 2017: 8, 2018: 8, 2020: 8


PYIC-5809: rename action for go back in page-update-name to be more generic

Proposed changes
What changed
Update the goback action in update name page to be more generic since this PR makes this action name misleading
Issue tracking
https://govukverify.atlassian.net/browse/PYIC-5809
Checklists
Environment variables or secrets

[x] No environment variables or secrets were added or changed

Part of me is wondering if we should update the update-name-date-birth page to use back instead of end to be consistant.

yes I did consider it and was in two minds as there is only two options on update-name-date-birth


Add Activate and Deactivate commands

Hi,
I just needed this for my CI procedure. I share if it can be usefull for you.
Regards

Cool, thanks. Glad this tool helps you!


make apm-toolkit-trace support a a programmatic interface

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[ ] Bug
[x] Requirement
[ ] Feature or performance improvement

Requirement
I want to pragmatically instrument Java code. There are possible two ways to do it.
gRPC API
This approach uses gPRC API to report segments to the OAP server. This approach is similar to go2sky. But there is a problem with it. The spans create by gPRC API can be related to the spans created by the Java agent. Consider the following example:
@GetMapping("/greeting")
public String greeting() {
   foo();
   return "hello";
}
private void foo() {
   // Create a span B and report it to OAP server
}

Java agent creates an entry span A for the greeting method. There will be no ChildOf relation created between span A and span B  since Java agent and gRPC API do the instrument separately. In one word, this approach does not integrate well with the automatic instrument by Java agent.
apm-toolkit-trace
apm-toolkit-trace uses Java annotations to create tracing data such as span, log, and tag. For example, we can use @Trace annotation to create a span for bar method:
@Trace
public void bar() {
}

The problem is that I can't decide whether to create a span for bar at runtime. For example, I want to disable span creation for bar method by default. After I turn on some flag, I want to create spans for the invocation of the method bar.
So the existing approaches do not solve my problem. I want to implement the following feature by extending apm-toolkit-trace module. My idea is to add the following APIs to  apm-toolkit-trace module (This API list is incomplete. If this design makes sense, I will make a complete API list for review):

createLoalSpan
createEntrySpan
createExitSpan
stopSpan

The above methods essentially do the same thing as the aforementioned annotations. For example, createLoalSpan and stopSpan can do the same thing as @Trace annotation. In summary, my idea is to provide a programmatic interface for the functionalities which have existed in apm-toolkit-trace module.

I am not sure following your first case, a span should not be reported to the backend without a segment wrapper.

Yes, you are right. I have updated my comment. PTAL

I and @yaojingguo did a face to face discussion about this. There are 2 potential direction

Use the OpenTracing bridge APIs to do this. But also, should aware of, OT is not practical. And AFAIK, SkyWalking will stay on OT-Java-0.30 only, or delete the support later(no specific plan yet)
Enhance the toolkit APIs with some static methods, such as TraceContext#createXXXspan(). But we wouldn't recommend to expose the reference of span to the end user, due to the context propagation is based on agent core, rather than UI.

@yaojingguo Any update about this?

I will try to make a PR this week.