kubernetes-vault controller restarted several times

I am seeing following behavior in kubernetes-vault side-car. Pods is restarted several times within a day.
From kubectl describe status looks like its consuming lots of resources.
Side car is running in cluster size of m4.xlarge each (9 nodes and 3 masters). And each contains 100gb of disk space.
kubernetes-vault-3521215708-20725         0/1       Evicted   0          23h
kubernetes-vault-3521215708-2prwv         0/1       Evicted   0          14h
kubernetes-vault-3521215708-3blwr         0/1       Evicted   0          10h
kubernetes-vault-3521215708-3lhbk         0/1       Evicted   0          21h
kubernetes-vault-3521215708-3xz8v         0/1       Evicted   0          10h
kubernetes-vault-3521215708-46rwf         0/1       Evicted   0          18h
kubernetes-vault-3521215708-4mp7q         0/1       Evicted   0          10h
kubernetes-vault-3521215708-5r3jj         0/1       Evicted   0          16h
kubernetes-vault-3521215708-7b3s5         0/1       Evicted   0          12h
kubernetes-vault-3521215708-7c6t4         0/1       Evicted   0          14h
kubernetes-vault-3521215708-7f9dv         0/1       Evicted   0          10h
kubernetes-vault-3521215708-80zs5         0/1       Evicted   0          10h
kubernetes-vault-3521215708-93x2j         0/1       Evicted   0          10h
kubernetes-vault-3521215708-9wp3j         0/1       Evicted   0          10h
kubernetes-vault-3521215708-b0c6q         0/1       Evicted   0          10h
kubernetes-vault-3521215708-bj28r         0/1       Evicted   0          10h
kubernetes-vault-3521215708-bwj7q         0/1       Evicted   0          14h
kubernetes-vault-3521215708-c96vj         0/1       Evicted   0          14h
kubernetes-vault-3521215708-dncd3         0/1       Evicted   0          10h
kubernetes-vault-3521215708-dxjw2         0/1       Evicted   0          10h
kubernetes-vault-3521215708-f6knz         0/1       Evicted   0          10h
kubernetes-vault-3521215708-gf75r         0/1       Evicted   0          10h
kubernetes-vault-3521215708-h2bj2         0/1       Evicted   0          10h
kubernetes-vault-3521215708-hk1w5         0/1       Evicted   0          14h
kubernetes-vault-3521215708-j1chl         0/1       Evicted   0          14h
kubernetes-vault-3521215708-jdhkx         0/1       Evicted   0          14h
kubernetes-vault-3521215708-jwd4s         0/1       Evicted   0          10h
kubernetes-vault-3521215708-jwjqm         0/1       Evicted   0          10h
kubernetes-vault-3521215708-ljwmr         0/1       Evicted   0          10h
kubernetes-vault-3521215708-lrvfz         0/1       Evicted   0          2h
kubernetes-vault-3521215708-msmbd         0/1       Evicted   0          10h
kubernetes-vault-3521215708-n149p         0/1       Evicted   0          10h
kubernetes-vault-3521215708-nfrzp         0/1       Evicted   0          14h
kubernetes-vault-3521215708-p5z53         0/1       Evicted   0          20h
kubernetes-vault-3521215708-pzhk7         0/1       Evicted   0          4h
kubernetes-vault-3521215708-r40h8         0/1       Evicted   0          10h
kubernetes-vault-3521215708-rs60c         0/1       Evicted   0          10h
kubernetes-vault-3521215708-sdr5d         0/1       Evicted   0          14h
kubernetes-vault-3521215708-sq1hq         0/1       Evicted   0          10h
kubernetes-vault-3521215708-t5b6v         0/1       Evicted   0          12h
kubernetes-vault-3521215708-tgp3w         0/1       Evicted   0          10h
kubernetes-vault-3521215708-tmllx         0/1       Evicted   0          10h
kubernetes-vault-3521215708-vdshw         0/1       Evicted   0          10h
kubernetes-vault-3521215708-vlh1v         0/1       Evicted   0          6h
kubernetes-vault-3521215708-xxqgh         0/1       Evicted   0          10h

Here is kubectl describe status,
kubectl describe pods kubernetes-vault-3521215708-pzhk7 --namespace=vault
Name:		kubernetes-vault-3521215708-pzhk7
Namespace:	vault
Node:		ip-10-8-166-184.us-west-2.compute.internal/
Start Time:	Thu, 27 Apr 2017 05:13:13 -0600
Labels:		pod-template-hash=3521215708
		run=kubernetes-vault
Status:		Failed
Reason:		Evicted
Message:	The node was low on resource: nodefs.
IP:
Controllers:	ReplicaSet/kubernetes-vault-3521215708
Containers:
  kubernetes-vault:
    Image:	<private-ecr-repo>
    Port:
    Volume Mounts:
      /kubernetes-vault from config-volume (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-3qgd4 (ro)
    Environment Variables:
      KUBERNETES_NAMESPACE:	vault (v1:metadata.namespace)
Volumes:
  config-volume:
    Type:	ConfigMap (a volume populated by a ConfigMap)
    Name:	kubernetes-vault
  default-token-3qgd4:
    Type:	Secret (a volume populated by a Secret)
    SecretName:	default-token-3qgd4
QoS Class:	BestEffort
Tolerations:	<none>
Events:
  FirstSeen	LastSeen	Count	From							SubObjectPath				Type		Reason	Message
  ---------	--------	-----	----							-------------				--------	------	-------
  49m		49m		1	{kubelet ip-10-8-166-184.us-west-2.compute.internal}						Warning		Evicted	The node was low on resource: nodefs.
  49m		49m		1	{kubelet ip-10-8-166-184.us-west-2.compute.internal}	spec.containers{kubernetes-vault}	Normal		Killing	Killing container with id docker://d72e9e6df1e7df3bd0d63bb823f7705b70792a8e37904e2838b4bf981331cd78:Need to kill Pod

kubectl describe pods kubernetes-vault-3521215708-lrvfz  --namespace=vault
Name:		kubernetes-vault-3521215708-lrvfz
Namespace:	vault
Node:		ip-10-8-152-0.us-west-2.compute.internal/
Start Time:	Thu, 27 Apr 2017 07:06:51 -0600
Labels:		pod-template-hash=3521215708
		run=kubernetes-vault
Status:		Failed
Reason:		Evicted
Message:	Pod The node was low on resource: [DiskPressure].
IP:
Controllers:	ReplicaSet/kubernetes-vault-3521215708
Containers:
  kubernetes-vault:
    Image:	<private-ecr>
    Port:
    Volume Mounts:
      /kubernetes-vault from config-volume (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-3qgd4 (ro)
    Environment Variables:
      KUBERNETES_NAMESPACE:	vault (v1:metadata.namespace)
Volumes:
  config-volume:
    Type:	ConfigMap (a volume populated by a ConfigMap)
    Name:	kubernetes-vault
  default-token-3qgd4:
    Type:	Secret (a volume populated by a Secret)
    SecretName:	default-token-3qgd4
QoS Class:	BestEffort
Tolerations:	<none>
No events.

Hey @pandeybk,
This is a strange one. Other than the raft and serf logs, kubernetes-vault should not be using tons of disk space.
Can you see if you can do the following?

Post the deployment for your kubernetes-vault. How many replicas are you running?

Get logs for a killed kubernetes-vault pod (kubectl logs) and post them here? If the pod is killed, you need to use kubectl logs -p to see logs from the previous instance.

Install heapster and grafana into your kubernetes cluster and see if you can graph the disk usage of a kubernetes-vault pod and post it.

I have a test setup running 3 kubernetes-vault instances using minikube. After running them for 7 hours, they are still consume 832KB of disk each.

for evicted pods I restarted seeing following error message,
ESC[33m[kubernetes-vault-3521215708-jmqp7] time="2017-04-27T23:37:42Z" level=error msg="Error getting next watch: EOF" ESC[m^O
ESC[33m[kubernetes-vault-3521215708-jmqp7] time="2017-04-27T23:37:42Z" level=error msg="Error getting next watch: EOF" ESC[m^O
ESC[33m[kubernetes-vault-3521215708-jmqp7] time="2017-04-27T23:37:42Z" level=error msg="Error getting next watch: EOF" ESC[m^O
ESC[33m[kubernetes-vault-3521215708-jmqp7] time="2017-04-27T23:37:42Z" level=error msg="Error getting next watch: EOF" ESC[m^O
ESC[33m[kubernetes-vault-3521215708-jmqp7] time="2017-04-27T23:37:42Z" level=error msg="Error getting next watch: EOF" ESC[m^O
ESC[33m[kubernetes-vault-3521215708-jmqp7] time="2017-04-27T23:37:42Z" level=error msg="Error getting next watch: EOF" ESC[m^O
ESC[33m[kubernetes-vault-3521215708-jmqp7] time="2017-04-27T23:37:42Z" level=error msg="Error getting next watch: EOF" ESC[m^O
ESC[33m[kubernetes-vault-3521215708-jmqp7] time="2017-04-27T23:37:42Z" level=error msg="Error getting next watch: EOF" ESC[m^O
ESC[33m[kubernetes-vault-3521215708-jmqp7] time="2017-04-27T23:37:42Z" level=error msg="Error getting next watch: EOF" ESC[m^O
ESC[33m[kubernetes-vault-3521215708-jmqp7] time="2017-04-27T23:37:42Z" level=error msg="Error getting next watch: EOF" ESC[m^O
ESC[33m[kubernetes-vault-3521215708-jmqp7] time="2017-04-27T23:37:42Z" level=error msg="Error getting next watch: EOF" ESC[m^O
ESC[33m[kubernetes-vault-3521215708-jmqp7] time="2017-04-27T23:37:42Z" level=error msg="Error getting next watch: EOF" ESC[m^O
ESC[33m[kubernetes-vault-3521215708-jmqp7] time="2017-04-27T23:37:42Z" level=error msg="Error getting next watch: EOF" ESC[m^O
ESC[33m[kubernetes-vault-3521215708-jmqp7] time="2017-04-27T23:37:42Z" level=error msg="Error getting next watch: EOF" ESC[m^O

I am seeing following log in one of the running container. I think k8s will soon terminate this one.
kubernetes-vault.txt

hey @pandeybk
Which version of kubernetes-vault are you running? The error "error getting next watch" was from d10161e0258582b0de8e405be7fc7990b949c6a1, but the logic was improved in 8fbaa66579228c6bbecbb2a1f777114a2630d3ed.
8fbaa66579228c6bbecbb2a1f777114a2630d3ed was released as  v0.4.3 about 3 weeks ago.
What I believe is happening is that the watcher is failing for some reason and it keeps logging, which fills up the disk. Can you try v0.4.3 to see if the issue is still a problem?

@F21 I am running 8fbaa66 version since 6 hours without problem. Looks working. Thank you

@pandeybk Good to hear! 😄 Please monitor your instances for 24 hours. If they appear to be stable, please close the issue at that time 👍


Version bump to 2.61.0

Auto-generated by fastlane 🤖
Changes since release '2.60.1':

Add try_repo_update_on_error option to cocoapods action (#10504) via Siarhei Fiedartsou
Update fastlane plugins only on update_plugins command (#10441) via Kohki Miki
Sets the installed profile name from sigh in an environment variable and lane context (#10515) via Josh Holtz
Add warning about sensitive or private information (#10505) via Iulian Onofrei
[spaceship] Add pagination support to Client#request (#10451) via Renzo

Awesome, thanks @nafu 👍


Entropic Map Estimation notebook

preliminary notebook for entropic map estimation --- I can also add "debiasing" transport maps to this notebook or to a different one, whichever makes more sense

Hey @APooladian , what's the status of this PR? Most of the requested changes are cosmetic and can finish them quickly if you prefer.


Add deps and extra deps for rules_jvm_external.

This also updates rules_jvm_external to 5.2.

This change is


Final version push for the Intern Program (#2)

Update .gitignore

Added widget_names

added colors to background color

added widget_style_attributes

added basic widget attribute names

added dialog_names

added containers

Updated Naming Conventions

added combobox

added justify and stretch values to all widget attributes

added table attributes & more attribute values for edit

Added Widget Style Tab

added Datatype table

Bug Fix

Rename to tool_styledemo.4pw

table/aggregate added

radiogroup and consistency

widget_camelcase column added

Fixed ComboBox item lists

adding widgets

control blocked

added todos

all wiget attributes up to date//control greyed out

Added Second widget functionality

updated default values

fixed repo file tracking (test.4gl)

Implemented Widget 2 attributes and styles tabs

Add Import

ADDED construct

I fixed the 4pw in these last two commits?


Various local development build improvements

I'm baaack!  And as usual capturing little build fixes as I encounter them while refreshing my local development environment.  Should be pretty much no risk of regression in the actual software and little to no risk of impact on other developers, CI/CD or other tooling.
See the individual commit messages for detail and elaboration on the individual changes.

Regarding the failing Changelog verifier check, I don't see a ./news/ directory anywhere in this repo.  What am I missing here?  At any rate, none of these changes should have a changelog entry to my mind.

@rpatterson Volto uses the CHANGELOG.md file in the repo root. Manually fill it in, in the unreleased section at the top.

Volto uses the CHANGELOG.md file in the repo root

Hmm, the details link in the GitHub UI for that
check is the standard Plone message
about towncrier.
In the interests of having both code quality checks and reducing hurdles to
contributions it would be good to correct that message.
In the meantime, I'll add an entry as described.

it would be good to correct that message.

I don't see anything in ./.github/workflows/ or elsewhere in the repo that defines or
configures that check.  Where is that defined?

Can you refresh my memory, @tiberiuichim, am I as the contributor supposed to merge my own PRs once approved and all checks are green, or do I leave that to others?

@rpatterson We usually leave the git merges up to the maintainer, @sneridagh. Sometimes (and I'm very guilty of this) we use the review as a method of saying "I'm ok with this going into the master, as long as all checks are passed", as we don't have other internal PLIP approval mechanism.

@rpatterson Glad you're back!

it would be good to correct that message.

I don't see anything in ./.github/workflows/ or elsewhere in the repo that defines or configures that check. Where is that defined?

That is check "from above" by Mr.Roboto. The nature of the package (not being Python) and the difference of the ecosystem makes Volto has its own things different than the rest of the Plone core packages.
The stablished workflow is also a bit different, as @tiberiuichim pointed out, due to the nature of the project. That needs more "love" and in-advance careful selection of what goes in and when. This is Plone 6 UI, remember, not plone.app.discussion and a lot of things are at stake if we introduce something not expected or carefully tested that could potentially break people's project.
We are also in the verge of releasing Volto 14, and the only accepted things "in" are the ones already approved by the Volto Team: https://github.com/plone/volto/milestone/19
Other things can go in also, but not disruptive, and blessed by the Volto Team. I changed the build a bit in https://github.com/plone/volto/pull/2805 , so we must check that nothing is breaking there also.
BTW, in which subject are you planning to work?

a lot of things are at stake if we introduce something not expected or carefully tested that could potentially break people's project

Ah, makes sense.  Perhaps then this project should switch to towncrier and adding entries
in ./news/* files.  In the meantime I'll submit another PR adding this detail to the
contributor documentation.

That is check "from above" by Mr.Roboto

For my edification, can you clarify where/how this is hooked up to the GitHub repo?

BTW, in which subject are you planning to work?

I'm resuming work on the authentication issues between classic Plone, Volto, and ZMI.
From there, I'll be working on what @alecghica tells me to.  :-)

AFAIK, this is ready for merge.  LMK if I'm missing something and more attention is needed.

Can someone merge this so I can use these improvements as I work on actual application code?

@rpatterson We are in the verge of releasing Volto 14. We haven't yet been able to do so because we are busy with communication and release preparations. @tisto stated that he wants to take a closer look to both PRs. BTW, I have the same opinion about version pins in here.
The CI does work with docker images right now, not using this buildout, which is only for reference and development purposes, so we are quite safe. Also, although a useful addition, the test setup is not that important for the project.
Could you merge your changes into your PRs in the meanwhile?

@rpatterson https://github.com/plone/volto/pull/2922 supersedes this one?

@rpatterson #2922 supersedes this one?

It builds on this one, yes.


cannot change currency

Cannot change currency ... not saved

This just wraps spoolman, so the issue is with spoolman, sorry.


Vitis-Sources of AXI project reference old custom SF3_freertos driver instead of upgraded PmodSF3 driver

The PmodSF3 driver was upgraded in timothystotts/vivado-library to support Vitis 2020.1 and provide a way to use the driver with FreeRTOS. The main routine and Experiment.c require an update to use the updated driver in FreeRTOS mode.
In the Platform configuration, microblaze extra compiler flags requires the addition of: -D_USE_FREERTOS_=1    .
In the Application, Project Properties | C/C++ General | Paths and Symbols | Symbols:
(1) Define symbol _USE_FREERTOS_ with value 1
(2) Apply to all languages and all configurations

Corrected with tag Serial_Mem_Tester_All_Prerelease_3A .


Only warn about missing --scale-factor CSS-variable for visible textLayers (PR 16162 follow-up)

This is something that I completely overlooked in PR #16162, which in some cases cause the default viewer to incorrectly print warnings.
This can reproduced with the PAGE scrolling-mode, and/or the PresentationMode, and this patch simply work-around it by checking the visibility as well (since the warning is a best-effort solution anyway).

/botio-linux preview


Adjusts

[ ] Include column from language
[ ] Include flag from country
[ ] Improve Stack, separate technology and type test
[ ] Include, if exists, link to LinkedIn

Hey @oindiao I was thinking maybe using the country flag and the test language, wouldn't that be redundant?

Hey @oindiao I was thinking maybe using the country flag and the test language, wouldn't that be redundant?

Hey @oindiao I was thinking maybe using the country flag and the test language, wouldn't that be redundant?

@brunopulis I'm based in this repo -> https://github.com/felipefialho/frontend-challenges
The challenge maybe is in english, but company is in Canada, for example.

Hey @oindiao I was thinking maybe using the country flag and the test language, wouldn't that be redundant?

@brunopulis I'm based in this repo -> https://github.com/felipefialho/frontend-challenges
The challenge maybe is in english, but company is in Canada, for example.


Warning on no constructor and super class constructor taking parameters

Consider this case:
class Parent {
    constructor(requiredArg) {}
}
class Child extends Parent {}

This currently doesn't produce an error. I believe it should.

Why?

Note that you can't just write
let x = new Child();

And that the generated code calls super for you:
var Child = (function (_super) {
    __extends(Child, _super);
    function Child() {
        _super.apply(this, arguments); <---
    }
    return Child;
})(Parent);

Based on reading the linked issue, it sounds like you're depending on a DI framework that reflects over the code to figure out what parameters to pass a constructor. In this case, it's up to you to reflect that behavior in your class one way or another (is static $inject = [...] available to you?).
After shipping for three years with the desirable behavior of "Derived classes with no declared constructors automatically get their base class's constructors", it's not feasible to break everyone and tell them to go manually rewrite their constructors so that users of particular DI frameworks get better warnings in some cases.
It would be very easy to write a no-implicit-constructors TSLint rule if that's the kind of thing you wanted to enforce in your project.

Sorry....my bad. This didn't make sense at all. Of course it shouldn't. Full story:
This comes from an Angular 2 use case. The Parent has some decorators for dependency injection. These aren't picked up by Angular since they aren't exposed by Child. The (ES5) javascript generated is
_super.apply(this, arguments)

...which works fine invocation wise, but not decoration wise.

@RyanCavanaugh you're so right! Well guessed!

@RyanCavanaugh I think a better question would be: can we open up for Angular (and similar) to deduce in runtime the constructor hierarchy and look for decoration metadata in the parent. This currently seems impossible (unless I'm mistaken)


[gconv.Struct(&source, &target)] Error "convert params from xxx to " map[string]interface{}" failed" is reported when source is a struct with no value filled in

Describe the bug
Error "convert params from xxx  to " map[string]interface{}" failed"  is reported when source is a struct with no value filled in
To Reproduce
Steps to reproduce the behavior, if applicable:

The code is
 var source = client.Page{}
 var target = client.Page{}
 gconv.Struct(&source, &target)

The error is
convert params from xxx  to " map[string]interface{}" failed

Expected behavior
map = nil is normal , not an error
Screenshots

var source = client.Page{}
 var target = client.Page{}
 gconv.Struct(&source, &target)

client.Page 可以是任意一个拥有属性的struct对象

var source = client.Page{}
 var target = client.Page{}
 gconv.Struct(&source, &target)

client.Page 可以是任意一个拥有属性的struct对象

抱歉在master分支上没复现。
package main

import (
	"fmt"

	"github.com/gogf/gf/v2/util/gconv"
	"github.com/gogf/gf/v2/util/gpage"
)

func main() {
	var source = gpage.Page{}
	var target = gpage.Page{}
	err := gconv.Struct(&source, &target)
	fmt.Println(err)
}


LuCI: Fails to open OpenWrt Patchworks series 144179

Currently not a problem in master, but will be if https://patchwork.ozlabs.org/project/openwrt/list/?series=144179 gets merged as is.
I don't really know how to use the mailing list so I've thought of putting it here as its tangentially related.

@ynezz

@jeolives can you share /etc/config/luci ?

config core 'main'
        option lang 'auto'
        option mediaurlbase '/luci-static/bootstrap'
        option resourcebase '/luci-static/resources'

config extern 'flash_keep'
        option uci '/etc/config/'
        option dropbear '/etc/dropbear/'
        option openvpn '/etc/openvpn/'
        option passwd '/etc/passwd'
        option opkg '/etc/opkg.conf'
        option firewall '/etc/firewall.user'
        option uploads '/lib/uci/upload/'

config internal 'languages'

config internal 'sauth'
        option sessionpath '/tmp/luci-sessions'
        option sessiontime '3600'

config internal 'ccache'
        option enable '1'

config internal 'themes'
        option Bootstrap '/luci-static/bootstrap'

config internal 'apply'
        option rollback '30'
        option holdoff '4'
        option timeout '5'
        option display '1.5'

config internal 'diag'
        option dns 'openwrt.org'
        option ping 'openwrt.org'
        option route 'openwrt.org'

config ifstate
        option interface 'lan'
        option ifname 'eth0.1 radio0.network1 radio1.network1'
        option bridge 'true'

The message above happens if rpcd crashes or is unreachable. Since it is unrelated to LuCI, not caused by LuCI and not going to be fixed in LuCI, I'll close this here.

@jeolives thanks for reporting, if you're interested you can find fixed series here https://gitlab.com/ynezz/openwrt-libubox/commits/wip


toolkit: --rename is superficial

When using the --rename option in the toolkit, the stack rename only happens at the toolkit level and not inside the app. This means that uniqueIds and paths would still be based on the original name, and this might break when we rely on these for global-uniqueness (contrary to logical IDs which are stack-unique).
See example #1331

If we are to keep the rename mechanism, it definitely needs to somehow pass into the synthesizer, otherwise it is also way too easy to forgot to apply renames in tooling.

--rename no longer exists


Add Qwen CPP Pipeline

Draft PR to add Qwen CPP pipeline, will swtich to use OV tokenizer for Qwen tokenization pipeline when it available.

TextStreamer is going to be added by https://github.com/openvinotoolkit/openvino.genai/pull/130


Support clearing cache for a specific collection.

Likes the issue title, can we clear the cache for a specific collection?
Another approach is to set the customKey as <collection_name>:<doc_id> and then remove all records that start with <collection_name>. Nevertheless, I prefer an official method to accomplish this task.
Thank you!

Hm interesting idea


go_router_builder does not add observers to StatefulShellBranchData

Steps to reproduce

Create a new project and add the go_router_builder dependencies
Create a tab_routes.dart file with this content:

import 'package:flutter/material.dart';
import 'package:go_router/go_router.dart';

part 'tab_routes.g.dart';

@TypedStatefulShellRoute<MainShellRoute>(
  branches: <TypedStatefulShellBranch<StatefulShellBranchData>>[
    TypedStatefulShellBranch<HomeTabData>(
      routes: <TypedRoute<RouteData>>[
        TypedGoRoute<HomeRoute>(path: '/home'),
      ],
    ),
  ],
)
class MainShellRoute extends StatefulShellRouteData {
  const MainShellRoute();

  @override
  Widget builder(
      BuildContext context,
      GoRouterState state,
      StatefulNavigationShell navigationShell,
      ) {
    return Scaffold(body: navigationShell);
  }
}

class HomeRoute extends GoRouteData {
  @override
  Widget build(BuildContext context, GoRouterState state) {
    return Container();
  }
}

class HomeTabData extends StatefulShellBranchData {
  static final List<NavigatorObserver> $observers = [
    DummyNavigatorObserver(),
  ];
}

class DummyNavigatorObserver extends NavigatorObserver {}

Run flutter pub run build_runner build --delete-conflicting-outputs

Expected results
A generated file where observers is passed as a parameter:
RouteBase get $mainShellRoute => StatefulShellRouteData.$route(
      factory: $MainShellRouteExtension._fromState,
      branches: [
        StatefulShellBranchData.$branch(
          observers: HomeTabData.$observers,
          routes: [
            GoRouteData.$route(
              path: '/home',
              factory: $HomeRouteExtension._fromState,
            ),
          ],
        ),
      ],
    );

Actual results
A generated file where observers is not passed as a parameter:
RouteBase get $mainShellRoute => StatefulShellRouteData.$route(
      factory: $MainShellRouteExtension._fromState,
      branches: [
        StatefulShellBranchData.$branch(
          routes: [
            GoRouteData.$route(
              path: '/home',
              factory: $HomeRouteExtension._fromState,
            ),
          ],
        ),
      ],
    );

Code sample

import 'package:flutter/material.dart';
import 'package:go_router/go_router.dart';

part 'tab_routes.g.dart';

@TypedStatefulShellRoute<MainShellRoute>(
  branches: <TypedStatefulShellBranch<StatefulShellBranchData>>[
    TypedStatefulShellBranch<HomeTabData>(
      routes: <TypedRoute<RouteData>>[
        TypedGoRoute<HomeRoute>(path: '/home'),
      ],
    ),
  ],
)
class MainShellRoute extends StatefulShellRouteData {
  const MainShellRoute();

  @override
  Widget builder(
      BuildContext context,
      GoRouterState state,
      StatefulNavigationShell navigationShell,
      ) {
    return Scaffold(body: navigationShell);
  }
}

class HomeRoute extends GoRouteData {
  @override
  Widget build(BuildContext context, GoRouterState state) {
    return Container();
  }
}

class HomeTabData extends StatefulShellBranchData {
  static final List<NavigatorObserver> $observers = [
    DummyNavigatorObserver(),
  ];
}

class DummyNavigatorObserver extends NavigatorObserver {}

Screenshots or Video
No response
Logs
No response
Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[!] Flutter (Channel stable, 3.16.9, on macOS 14.1.2 23B92 darwin-arm64, locale es-419)
    ! Warning: `dart` on your path resolves to /opt/homebrew/Cellar/dart/3.2.6/libexec/bin/dart, which is not inside your current Flutter SDK checkout at /Users/rubenlopez/fvm/versions/stable. Consider adding /Users/rubenlopez/fvm/versions/stable/bin to the front of your path.
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.1)
[✓] IntelliJ IDEA Ultimate Edition (version 2023.3.4)
[✓] VS Code (version 1.85.2)

There is already a PR to fix this. https://github.com/flutter/packages/pull/5865/

Thanks for the report. Reproduced this issue with the latest package version go_router_builder: ^2.4.1.

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.19.1, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.19.1 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision abb292a07e (29 hours ago), 2024-02-20 14:35:05 -0800
    • Engine revision 04817c99c9
    • Dart version 3.3.0
    • DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio Hedgehog.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.86.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.82.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 121.0.6167.184

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.20.0-11.0.pre.80, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.20.0-11.0.pre.80 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision efee280cfa (46 minutes ago), 2024-02-21 21:44:25 -0500
    • Engine revision 7eeb697687
    • Dart version 3.4.0 (build 3.4.0-163.0.dev)
    • DevTools version 2.33.0-dev.6
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio Hedgehog.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.86.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.82.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 121.0.6167.184

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

cc: @satoyan If your PR https://github.com/flutter/packages/pull/5865 can fix this issue, could you please mention this in your PR's description so that this issue state can be updated accordingly?

My workaround is to add the parameter manually for now.

cc: @satoyan If your PR flutter/packages#5865 can fix this issue, could you please mention this in your PR's description so that this issue state can be updated accordingly?

I updated description of my PR!  :smile:
Thank you.


Standalone LiT client development

Implements a new script (yarn develop) that lets developers to do
LiT frontend client development without having to setup an lnd backend.
This script uses the mock responses configured in sampleData to resolve API
requests.
Limitations:

The implementation depends on sampleData to be up-to-date as the APIs
evolve.
Currently it only supports GET requests.

Alternatives considered:

Use REACT_APP_DEV_HOST to point to a testnet public server so as to avoid
configuring and running lnd.
Set up a webpack devserver to proxy responses to a node server running
locally that in-turn reads mock responses configured as <endpoint>.json
files, ex GetInfo.json, and sends it as response.

@jamaljsr: review reminder

I rebased via Github to save you from having to do it manually. Going to merge once these flaky workflows stop failing.


GUI choices

https://shoelace.style is one that many golang devs are using.
Wondering where we should add components to Leap kit ? If you dont want it here let me know :)
https://github.com/paganotoni/todox/blob/main/internal/todos/index.go uses github.com/delaneyj/gostar/elements, and that works and give you full control, but also he has also switched to shoelace.style

This is a good topic @gedw99! Shoelace can just be added to the template. As for the components I have been thinking about providing an interface so developers can use their own renderer. Both, components and shoelace can be added after the base leapkit template has been generated.


question: how to increase gas on a transaction to speed it up

I'm wondering if there's another parameter to increase gas on a transaction to speed it up, e.g.
contract.transact_and_wait.transfer_from(account2, account1, amount, <GAS?>)

I see there is mention of setting gas prices and limits per client or contract in the README:
https://github.com/EthWorks/ethereum.rb#custom-gas-price-and-gas-limit
but I'm not quite sure how to use it.  I would have assumed that I could say I want to use X amount of gas on a transaction where X was some higher value than would be usef by default.  It's not clear how setting a limit or a price achieves what I want, which is to be able to speed up a transaction by paying more.
I've been looking at the docs at https://infura.io/docs/ethereum/json-rpc/eth-sendRawTransaction but am still unclear about how to proceed.
Can anyone point me in the right direction?  Many thanks in advance

okay, so the gas price is the:

amount of Ether you’re willing to pay for every unit of gas

so if I set that to, say, 50, that should be enough to speed things up a little I guess ...


Flow does not catch invalid switch statements

Posting here, cause this caused a production incident at our company. For the most part we're "fine" with our usage of flow, but this is one of the more serious bugs
Flow version:
0.220.1
Expected behavior
Incorrect switch case statements should throw an error
Actual behavior
Switch case statements are allowed to do anything

Link to Try-Flow or Github repo: link

Specifically see this part:

Note the usage of "random_access"

For now, if using the disjoint object union pattern, stick to using literal types 'foo' directly rather than using typeof X.Foo, both when defining the type and when refining it (e.g. in a switch)


Elyra launcher

Use our own Launcher implementation to properly order Elyra category/section and display project logo
Todos:

[x] Make this the default Launcher when Elyra is installed
[ ] Cange the Elyra section logo to be project logo

Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

This seems to be working now, it would be nice to have the icon on Elyra section  changed to the actual Elyra icon  instead of the Pipeline editor  one.

would it be worth adding a Code Snippet card to the Elyra category, which would launch the Add new code-snippet form?

would it be worth adding a Code Snippet card to the Elyra category, which would launch the Add new code-snippet form?

Not a bad idea, as long as the extension creates it, it will show up properly here on the launcher.

Below is how this looks like without console, which indeed makes it much more clean, but I don't feel confortable removing it unless the user can somehow re-enable it.

Below is how this looks like without console, which indeed makes it much more clean, but I don't feel confortable removing it unless the user can somehow re-enable it.

i wouldn't recommend removing Console but rather just placing Elyra above it.

After some discussion, looks like it's better just to move the Elyra section above Others  and leave everything else as is.

@vabarbosa I replaced your fix for the elyra icon with another solution I figured out. iconClass support was deprecated in Lab 2.0 and is set to be removed as soon as 3.0 so I would prefer we don't rely on it. As such I did some digging into react and figured out a way to replace the LabIcon itself.

@vabarbosa are you ok with the suggested approach? From what @ajbozarth the CSS approach might be deprecated on Lab 3.0. We should also revisit the launcher interface on the lab side to make it more extensible I guess.

@vabarbosa I replaced your fix for the elyra icon with another solution I figured out. iconClass support was deprecated in Lab 2.0 and is set to be removed as soon as 3.0 so I would prefer we don't rely on it. As such I did some digging into react and figured out a way to replace the LabIcon itself.

unless i am misunderstanding, icon is being deprecated in favor of iconClass or at least that's how i interpreted these comments:
https://github.com/jupyterlab/lumino/blob/master/packages/commands/src/index.ts#L194,L229
https://github.com/jupyterlab/jupyterlab/blob/master/packages/launcher/src/index.tsx#L199,L203
are those comments incorrect? is iconClass (not icon) what is actually being deprecated? if so, i guess i can go along with the approach.

@vabarbosa Ah I see where you're confused.
icon has a messy history. A while back (before I started working with jupyter) icon was deprecated in favor of iconClass which behaved the same way, being a css class string, but was clearer in its actual meaning.
But then when LabIcon was implemented for Lab 2.0 the deprecated icon was overloaded with the new functionality. So what's deprecated is the ability to set icon to a string, which would just be aliased to iconClass. The new functionality is that icon can also be a LabIcon (which extends VirtualElement.IRenderer). This way of handling icons is the new standard. You can learn more about LabIcon here: https://github.com/jupyterlab/jupyterlab/blob/5555c77a17d48b973c66cb32141844f2ce34e10f/packages/ui-components/CONTRIBUTING.md

Also if you want help with understanding how the code in your second link handle all three cases (really deprecated icon as a string, recently deprecated iconClass, and new icon as a LabIcon) then I can hope on a 5min call tomorrow to explain it (it took me some time to wrap my head around what those few line were actually accomplishing.

thanks for the clarification

I guess we are in consensus here. Note that there is still a need to make this area a little more flexible on core and I will follow up with that later on.


Data Cleaning: Consolidate Synonyms within Categories

Very many categories have similar values ex: Web Dev and Web Development this example might be taken care of but we should be looking for these.
Acceptance criteria:

Create a click command to find potential matches that are similar enough. Use fuzzy string matching, or something of the like.
Include simple unit tests for known examples  as this is going to be more hit and miss.
Make the threshold configurable so that we can try with different strictness.

I think that Algolia takes care of the idea of fuzzy string matching. If it's not a featured category on the front end then it should be found via the /search endpoint. If we run into some more serious problems, we can reassess this.


Django Integration Leaks Memory

I expended around 3 days trying to figure out what was leaking in my Django app and I was only able to fix it by disabling sentry Django integration (on a very isolated test using memory profiler, tracemalloc and docker). To give more context before profiling information, that's how my memory usage graph looked on a production server (killing the app and/or a worker after a certain threshold):

Now the data I gathered:
By performing 100,000 requests on this endpoint:
class SimpleView(APIView):
    def get(self, request):
        return Response(status=status.HTTP_204_NO_CONTENT)

A tracemalloc  snapshot, grouped by filename, showed sentry django integration using 9MB of memory after a 217 seconds test with 459 requests per second. (using NGINX and Hypercorn with 3 workers):
/usr/local/lib/python3.7/site-packages/sentry_sdk/integrations/django/__init__.py:0: size=8845 KiB (+8845 KiB), count=102930 (+102930), average=88 B
/usr/local/lib/python3.7/site-packages/django/urls/resolvers.py:0: size=630 KiB (+630 KiB), count=5840 (+5840), average=110 B
/usr/local/lib/python3.7/linecache.py:0: size=503 KiB (+503 KiB), count=5311 (+5311), average=97 B
/usr/local/lib/python3.7/asyncio/selector_events.py:0: size=465 KiB (+465 KiB), count=6498 (+6498), average=73 B
/usr/local/lib/python3.7/site-packages/sentry_sdk/scope.py:0: size=325 KiB (+325 KiB), count=373 (+373), average=892 B

tracemalloc probe endpoint:
import tracemalloc
tracemalloc.start()

start = tracemalloc.take_snapshot()

@api_view(['GET'])
def PrintMemoryInformation(request):
    current = tracemalloc.take_snapshot()

    top_stats = current.compare_to(start, 'filename')
    for stat in top_stats[:5]:
        print(stat)

    return Response(status=status.HTTP_204_NO_CONTENT)

I have performed longers tests and the sentry django integration memory usage only grows, never releases, this is just a scaled-down version of the tests I've been performing to identify this leak.
This is how my sentry settings looks like on settings.py:

Memory profile after disabling the Django Integration (same test and endpoint), no sentry sdk at top 5 most consuming files:
/usr/local/lib/python3.7/site-packages/django/urls/resolvers.py:0: size=1450 KiB (+1450 KiB), count=15123 (+15123), average=98 B
/usr/local/lib/python3.7/site-packages/hypercorn/protocol/h11.py:0: size=1425 KiB (+1425 KiB), count=8868 (+8868), average=165 B
/usr/local/lib/python3.7/site-packages/channels/http.py:0: size=1398 KiB (+1398 KiB), count=14848 (+14848), average=96 B
/usr/local/lib/python3.7/site-packages/h11/_state.py:0: size=1242 KiB (+1242 KiB), count=13998 (+13998), average=91 B
/usr/local/lib/python3.7/site-packages/h11/_connection.py:0: size=1226 KiB (+1226 KiB), count=15957 (+15957), average=79 B

settings.py for the above profile:

Memory profile grouped by line number (more verbose):
/usr/local/lib/python3.7/site-packages/sentry_sdk/integrations/django/__init__.py:272: size=4512 KiB (+4512 KiB), count=33972 (+33972), average=136 B
/usr/local/lib/python3.7/site-packages/sentry_sdk/integrations/django/__init__.py:134: size=4247 KiB (+4247 KiB), count=67945 (+67945), average=64 B
/usr/local/lib/python3.7/linecache.py:137: size=492 KiB (+492 KiB), count=4850 (+4850), average=104 B
/usr/local/lib/python3.7/asyncio/selector_events.py:716: size=415 KiB (+415 KiB), count=2530 (+2530), average=168 B
/usr/local/lib/python3.7/site-packages/sentry_sdk/scope.py:198: size=279 KiB (+279 KiB), count=1 (+1), average=279 KiB
/usr/local/lib/python3.7/site-packages/django/views/generic/base.py:65: size=262 KiB (+262 KiB), count=4783 (+4783), average=56 B
/usr/local/lib/python3.7/socket.py:213: size=237 KiB (+237 KiB), count=2530 (+2530), average=96 B
/usr/local/lib/python3.7/site-packages/ddtrace/span.py:149: size=229 KiB (+229 KiB), count=1765 (+1765), average=133 B
/usr/local/lib/python3.7/site-packages/django/urls/resolvers.py:537: size=229 KiB (+229 KiB), count=390 (+390), average=600 B
/usr/local/lib/python3.7/site-packages/h11/_state.py:261: size=224 KiB (+224 KiB), count=3170 (+3170), average=72 B
/usr/local/lib/python3.7/site-packages/django/contrib/messages/storage/session.py:21: size=211 KiB (+211 KiB), count=3863 (+3863), average=56 B
/usr/local/lib/python3.7/site-packages/rest_framework/request.py:414: size=195 KiB (+195 KiB), count=3565 (+3565), average=56 B
/usr/local/lib/python3.7/functools.py:60: size=194 KiB (+194 KiB), count=1611 (+1611), average=124 B
/usr/local/lib/python3.7/site-packages/ddtrace/vendor/msgpack/fallback.py:847: size=192 KiB (+192 KiB), count=542 (+542), average=363 B
/usr/local/lib/python3.7/site-packages/django/http/request.py:427: size=183 KiB (+183 KiB), count=3335 (+3335), average=56 B
/usr/local/lib/python3.7/site-packages/ddtrace/encoding.py:114: size=171 KiB (+171 KiB), count=6 (+6), average=28.5 KiB
/usr/local/lib/python3.7/site-packages/rest_framework/views.py:478: size=166 KiB (+166 KiB), count=3002 (+3002), average=57 B
/usr/local/lib/python3.7/site-packages/django/utils/datastructures.py:67: size=164 KiB (+164 KiB), count=3006 (+3006), average=56 B
/usr/local/lib/python3.7/asyncio/selector_events.py:581: size=163 KiB (+163 KiB), count=2530 (+2530), average=66 B
/usr/local/lib/python3.7/site-packages/h11/_connection.py:233: size=159 KiB (+159 KiB), count=2263 (+2263), average=72 B

my pip freeze output:
aioredis==1.2.0
amqp==2.5.0
appdirs==1.4.3
asgiref==3.1.4
asn1crypto==0.24.0
astroid==2.2.5
async-timeout==3.0.1
atomicwrites==1.3.0
attrs==19.1.0
autobahn==19.7.1
Automat==0.7.0
autopep8==1.4.4
Babel==2.7.0
billiard==<IP_ADDRESS>
boto3==1.9.185
botocore==1.12.185
celery==4.3.0
certifi==2019.6.16
cffi==1.12.3
channels==2.2.0
channels-redis==2.4.0
chardet==3.0.4
Click==7.0
colorama==0.4.1
constantly==15.1.0
coverage==4.5.3
cryptography==2.7
daphne==2.3.0
ddtrace==0.26.0
dj-database-url==0.5.0
Django==2.2.3
django-anymail==6.1.0
django-cors-headers==3.0.2
django-filter==2.1.0
django-ipware==2.1.0
django-money==0.15
django-nose==1.4.6
django-redis==4.10.0
django-storages==1.7.1
django-templated-mail==1.1.1
djangorestframework==3.9.4
djoser==1.7.0
docopt==0.6.2
docutils==0.14
factory-boy==2.12.0
Faker==1.0.7
flower==0.9.3
geoip2==2.9.0
gprof2dot==2017.9.19
graphviz==0.11
green==2.16.1
gunicorn==19.9.0
h11==0.9.0
h2==3.1.0
hiredis==1.0.0
hpack==3.0.0
httptools==0.0.13
Hypercorn==0.7.0
hyperframe==5.2.0
hyperlink==19.0.0
idna==2.8
importlib-metadata==0.18
incremental==17.5.0
isort==4.3.21
jedi==0.14.0
Jinja2==2.10.1
jmespath==0.9.4
kombu==4.6.3
lazy-object-proxy==1.4.1
lxml==4.3.4
MarkupSafe==1.1.1
maxminddb==1.4.1
mccabe==0.6.1
more-itertools==7.1.0
msgpack==0.6.1
nose==1.3.7
objgraph==3.4.1
packaging==19.0
parso==0.5.0
pendulum==2.0.5
Pillow==6.1.0
pipdate==0.3.2
pluggy==0.12.0
prompt-toolkit==2.0.9
psutil==5.6.3
psycopg2-binary==2.8.3
ptpython==2.0.4
py==1.8.0
py-moneyed==0.8.0
pycodestyle==2.5.0
pycparser==2.19
Pygments==2.4.2
PyHamcrest==1.9.0
PyJWT==1.7.1
pylint==2.3.1
pylint-django==2.0.10
pylint-plugin-utils==0.5
pyparsing==2.4.0
python-dateutil==2.8.0
pytoml==0.1.20
pytz==2019.1
pytzdata==2019.2
redis==3.2.1
requests==2.22.0
s3transfer==0.2.1
sentry-sdk==0.10.1
six==1.12.0
sqlparse==0.3.0
text-unidecode==1.2
toml==0.10.0
tornado==5.1.1
Twisted==19.2.1
txaio==18.8.1
typed-ast==1.4.0
typing-extensions==3.7.4
Unidecode==1.1.1
urllib3==1.25.3
uvloop==0.12.2
vine==1.3.0
wcwidth==0.1.7
websockets==7.0
whitenoise==4.1.2
wrapt==1.11.2
wsproto==0.14.1
zipp==0.5.2
zope.interface==4.6.0

I used the official python docker image with the label 3.7, meaning latest 3.7 version.
Hope you guys can figure the problem with this data, I'm not sure if I'll have the time to contribute myself!
Bonus, memory profiling after 1,000,000 requests (Django Integration using 44MB):
/usr/local/lib/python3.7/site-packages/sentry_sdk/integrations/django/__init__.py:272: size=43.9 MiB (+43.9 MiB), count=338647 (+338647), average=136 B
/usr/local/lib/python3.7/site-packages/sentry_sdk/integrations/django/__init__.py:134: size=41.3 MiB (+41.3 MiB), count=677294 (+677294), average=64 B
/usr/local/lib/python3.7/site-packages/sentry_sdk/scope.py:198: size=2942 KiB (+2942 KiB), count=1 (+1), average=2942 KiB
/usr/local/lib/python3.7/site-packages/django/views/generic/base.py:65: size=2584 KiB (+2584 KiB), count=47252 (+47252), average=56 B
/usr/local/lib/python3.7/site-packages/django/contrib/messages/storage/session.py:21: size=2079 KiB (+2079 KiB), count=38013 (+38013), average=56 B
/usr/local/lib/python3.7/site-packages/rest_framework/request.py:414: size=2006 KiB (+2006 KiB), count=36684 (+36684), average=56 B
/usr/local/lib/python3.7/site-packages/django/http/request.py:427: size=1857 KiB (+1857 KiB), count=33946 (+33946), average=56 B
/usr/local/lib/python3.7/site-packages/django/utils/datastructures.py:67: size=1670 KiB (+1670 KiB), count=30546 (+30546), average=56 B
/usr/local/lib/python3.7/site-packages/rest_framework/views.py:478: size=1547 KiB (+1547 KiB), count=28237 (+28237), average=56 B
/usr/local/lib/python3.7/site-packages/django/contrib/auth/middleware.py:24: size=1518 KiB (+1518 KiB), count=27752 (+27752), average=56 B
/usr/local/lib/python3.7/importlib/__init__.py:118: size=1398 KiB (+1398 KiB), count=25571 (+25571), average=56 B
/usr/local/lib/python3.7/site-packages/django/contrib/messages/storage/__init__.py:12: size=930 KiB (+930 KiB), count=17000 (+17000), average=56 B
/usr/local/lib/python3.7/site-packages/sentry_sdk/tracing.py:123: size=885 KiB (+885 KiB), count=5985 (+5985), average=151 B
/usr/local/lib/python3.7/asyncio/selector_events.py:716: size=664 KiB (+664 KiB), count=4049 (+4049), average=168 B
/usr/local/lib/python3.7/site-packages/django/urls/resolvers.py:541: size=662 KiB (+662 KiB), count=12107 (+12107), average=56 B
/usr/local/lib/python3.7/site-packages/django/http/request.py:584: size=601 KiB (+601 KiB), count=10986 (+10986), average=56 B
/usr/local/lib/python3.7/site-packages/django/core/handlers/exception.py:34: size=592 KiB (+592 KiB), count=10618 (+10618), average=57 B
/usr/local/lib/python3.7/linecache.py:137: size=493 KiB (+493 KiB), count=4875 (+4875), average=104 B
/usr/local/lib/python3.7/site-packages/h11/_state.py:261: size=434 KiB (+434 KiB), count=6142 (+6142), average=72 B
/usr/local/lib/python3.7/site-packages/ddtrace/span.py:149: size=406 KiB (+406 KiB), count=3124 (+3124), average=133 B

Identifying a memory leak makes me a contributor? :/

Could you try a different wsgi server? I cannot reproduce any of this with uwsgi or django's devserver.

That might be the thing then, I'm actually using ASGI, tried the three options available, Daphne, Hypercorn and Gunicorn+Uvicorn.

Oh you're using Django from a development branch and run on ASGI? That might be not the same issue @reupen is seeing at all then.

I'm absolutely not using Django from a development branch, I'm using Django Channels.

got it. we never tested with channels, but have support/testing on our roadmap. the memory leak still shouldn't happen. we'll investigate but it could take some time.

Feel free to reach me for any further clarifications, I'm happy to help and appreciate your efforts nonetheless 👍

Yeah, I can repro it with a random channels app that just serves regular routes via ASGI + hypercorn (not even any websockets configured)
So far no luck with uvicorn though. Did you observe faster/slower leaking when comparing servers?

I understand the problem now, and can see how we leak memory. I have no idea why this issue doesn't show with uvicorn but I also don't care.
It's very simple: For resource cleanup we expect every Django request to go through WSGIHandler.__call__. This doesn't happen for channels.
I think you will see more of the same issue if you try to set tags with configure_scope() in one request. They should not persist between requests, but do with ASGI.
This issue should not be new in 0.10, but it should've been there since forever. @reupen if you saw a problem when upgrading to 0.10 then this is an entirely separate issue, and I would need more information about the setup you're running.
I think this becomes a duplicate of #162 then (or it will get #162 as dependency at least). cc @tomchristie. The issue is that last time I looked into this I saw a not-quite-stable specification, which is why I was holding off of it.
You might be able to find a workaround by installing https://github.com/encode/sentry-asgi in addition to the Django integration

I haven’t parsed all this, but I’ll comment on this one aspect...

last time I looked into this I saw a not-quite-stable specification

ASGI 3 is baked and done. You’re good to go with whatever was blocked there.

I don't think this helps in this particular situation because the latest version of channels still appears to use a prev version (had to pin down sentry-asgi)

@tomchristie I want to pull sentry-asgi into sentry. Do you think it would be possible to make a middleware that behaves as polyglot ASGI 2 and ASGI 3?

Something like this would be a "wrap ASGI 2 or ASGI 3, and return an ASGI 3 interface" middleware...
def asgi_2_or_3_middleware(app):
    if len(inspect.signature(app).parameters) == 1:
        # ASGI 2
        async compat(scope, receive, send):
            nonlocal app
            instance = app(scope)
            await instance(receive, send)
        return compat
    else:
        # ASGI 3
        return app

Alternatively, you might want to test if the app is ASGI 2 or 3 first, and just wrap it in a 2->3 middleware if needed.
def asgi_2_to_3_middleware(app):
    async compat(scope, receive, send):
        nonlocal app
        instance = app(scope)
        await instance(receive, send)
    return compat

Or equivalently, this class based implementation, that Uvicorn uses: https://github.com/encode/uvicorn/blob/master/uvicorn/middleware/asgi2.py

@reupen if you saw a problem when upgrading to 0.10 then this is an entirely separate bug, and I would need more information about the setup you're running (please in a new issue though)

The main problem I observed was an increase in memory usage over time of a long-running (tens of minutes) Celery task (which has lots of Django ORM usage). I haven't had a chance to do any traces, but I'll create a new issue when I do.

@astutejoe When 0.10.2 comes out, you can do this to fix your leaks: https://github.com/getsentry/sentry-python/blob/ce3b49f8f0f76939d972868f417dcf9ef78758aa/tests/integrations/django/myapp/asgi.py#L19

Hey! that sounds great @untitaker I will try it eventually, thanks for your time!!!

0.10.2 is released with the new ASGI Middleware! No documentation yet, will
write tomorrow
On Mon, Jul 15, 2019, 18:54 Gabriel Garcia<EMAIL_ADDRESS>wrote:

Hey! that sounds great @untitaker https://github.com/untitaker I will
try it eventually, thanks for your time!!!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/getsentry/sentry-python/issues/419?email_source=notifications&email_token=AAGMPROVOTED5MVGDYDKC3DP7STU5A5CNFSM4H7KBM4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ6JU4I#issuecomment-511482481,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGMPRMFHDML6J3ZBSG5B23P7STU5ANCNFSM4H7KBM4A
.

Nice one. 👍

Please watch this PR, when it is merged the docs are automatically live:
https://github.com/getsentry/sentry-docs/pull/1118
On Mon, Jul 15, 2019 at 8:41 PM Tom Christie<EMAIL_ADDRESS>wrote:

Nice one. 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/getsentry/sentry-python/issues/419?email_source=notifications&email_token=AAGMPRP5YBXDTZ7YZNMOMITP7TAFBA5CNFSM4H7KBM4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ6TFGI#issuecomment-511521433,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGMPRNSWR34QPCR3R36HCDP7TAFBANCNFSM4H7KBM4A
.

docs are deployed, this is basically fixed. New docs for ASGI are live on https://docs.sentry.io/platforms/python/asgi/

@untitaker I'm currently using channels==1.1.8 and raven==6.10.0 and experiencing memory leak issues very similar to this exact issue. I wanted to inquire whether there is a solution for Django Channels 1.X? I see that Django Channels 2.0 and sentry-sdk offer a solution via SentryAsgiMiddleware. I wanted to see if this also works with Django Channels 1.0?

I'm not aware of any issues on 1.x, and for that version sentry-sdk does
not do anything differently, but I believe you would have to try for
yourself.
On Wed, Nov 6, 2019, 05:06 Sachin Rekhi<EMAIL_ADDRESS>wrote:

@untitaker https://github.com/untitaker I'm currently using
channels==1.1.8 and raven==6.10.0 and experiencing memory leak issues very
similar to this exact issue. I wanted to inquire whether there is a
solution for Django Channels 1.X? I see that Django Channels 2.0 and
sentry-sdk offer a solution via SentryAsgiMiddleware. I wanted to see if
this also works with Django Channels 1.0?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/getsentry/sentry-python/issues/419?email_source=notifications&email_token=AAGMPRPX4ZHTMXWNO4XNOITQSI7C7A5CNFSM4H7KBM4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDFF7SQ#issuecomment-550133706,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGMPRPECROM3OHQ2Z2AY7TQSI7C7ANCNFSM4H7KBM4A
.


---no support ? ----

---no support ? ----
We think this rss-bridge is death
rip

Why do you think so?

We think this rss-bridge is death

RSS-Bridge is a killer application but I wouldn't go as far as calling it death 😄
Seriously now: If you feel that RSS-Bridge doesn't get as much attention as it should, you are right. But that doesn't mean the project is dead, it's just going a bit slow. Don't forget we all do this in our spare time, so if more important things come up we shift our focus and return later.
That being said, feel free to send PRs. Even if merging takes a few days, this is still the best way to support this project in the long run. You also learn a lot from doing so.

One possible mitigation of this apparent lack of rapid development would be either slowing down Earth's rotation without changing job hours (= making more free hours in a day), or implementing universal basic income so people can more easily be dedicated full-time on RSS-Bridge.
But for the time being, please keep improving the project even with tiny pull requests or issue reports of broken bridges.
I'll consider RSS-Bridge to be dead the day exactly zero people use it; and I'm one of the (apparently many) people still using my demo instance :wink:


Update README to reflect command name correctly

The README code did not reflect the updated code properly.

Great, thanks!


New Maintainers Wanted : Existing Maintainers Are Abandoning

Hey there community. @calebcase and I are thrilled that dpath was, and still is, so well received by the python community. We have been excited to engage all of you on your issues and feature requests. However, as time has gone by, we have been challenged to continue maintaining the project. We do not use it professionally anymore, and we have a hard time syncing our schedules to perform regular maintenance tasks on the library. Even getting releases out the door has become cumbersome. You, our community, deserve more responsive maintainers.
We are looking to hand this project off to a new maintainer. Henceforth, we will issue NO FURTHER BUILDS for any reason. At this time 1.x is stable and free of major bugs; 2.x is stable and shows the way forward; and 3.x has some issues written up for future development. Anyone who wants to submit a bugfix or feature is encouraged to fork the project.
We still maintain ownership of the python pypi package and the automated build in Travis. Any individual who wants to continue publishing dpath updates under the existing project name can reach out to us to be added as a collaborator on the python project page and on the travis builds. Eventually, those will be handed over completely to whomever can prove themselves a good maintainer. You are also free to fork it, rename it, and publish new packages to pypi using the new name. If you do so, please let us know, and we WILL update the pypi documentation and the github documentation to point to  your fork.
We will close this issue when a new maintainer has stepped up.

I'm willing to contribute time to this.


fix float32

Signed-off-by: Takeshi Yoneda<EMAIL_ADDRESS>

note this is against clean-api branch

thanks!


scripts: Also use pylint-3 if pylint is not installed

Fedora installs pylint as pylint-3 and only gets pylint via pip3. We can also
use pylint-3.
Signed-off-by: Stefan Berger<EMAIL_ADDRESS>

Seems this breaks things when there is a pylint but no pylint-3 - https://github.com/keylime/keylime/pull/592/checks?check_run_id=2167474143


Verify Heroku install on Mac

We need to check the URL's, verify the install procedure, etc.

IIRC this has some git + ssh functionality?
Smoke check that some kind of "hello world" still works

See also:
https://github.com/clojurebridge-minneapolis/installfest/blob/experimental/docs/setup_new_heroku.md
Will contribute to #8

Hey @tmarble @mulchy , I ran through this and it seems to work.
I downloaded the mac installer and ran through their instructions.
I dont have an app that can easily be run on heroku right now, however when i ran heroku create it gave me a url I could hit with their hello world page.
Is that good enough?


Difference?

Hey, what exactly is the difference between scam-urls.txt and pihole-phishing-adlist.txt?

Hi, scam-urls.txt is a simple text file ideally built for bots which have no false positives (I'm currently using that file for Phades Bot) while the pihole adlist has false positives included and it's meant for pihole


deploy service failed

In GitLab by @sokril on Dec 15, 2017, 13:11

In GitLab by @sokril on Nov 8, 2019, 07:44
service.yaml file can be deployed by kubectl

In GitLab by @sokril on Nov 8, 2019, 07:44
fixed by pr#798

In GitLab by @sokril on Nov 8, 2019, 08:16
closed

In GitLab by @sokril on Nov 8, 2019, 08:17
assigned to @luotian-github


Add size snapshot

This plugin allows to track size changing with every commit. Also there is useful treeshakability metric which shows size after bundling import {} from 'lib'. This allows us to fix treeshakability explicitly without false assumptions.
P.S also I found inconsistency in naming: dist/react-spring.js is cjs, dist/addons.js is esm.

Nice, thanks!
As for addons, that was really weird, i was running into the infamous class cannot be invoked withoput 'new' issue (extending classes with es5 turned classes), so i had to bundle the "Animation" class into addons.


v1.56.0 introduces breaking changes due dependency updates

It looks like some of the dependencies which had their major versions updated in the v1.56.0 release might have changed their builds to be ESM only.
Had to revert back to 1.55.0 to fix remix-run which depends on this package.
Dependencies in v1.56.0 should probably be reverted to fix the v1 branch and released as v1.57.0. Then the 1.56.0 changes could be re-release as v2?

the same error

Should be fixed in v1.56.1. Thanks all for letting me know!


Provide error page views that add the guid to the HTML output

I would like an easy way to override the Django error page views so that the request guid is included as part of the HTML. This is useful so that customers can easily send the guid to a support team to get faster help.

You should read about handler500. You can very simply add a callable like this:
def handler500(request):
    return TemplateResponse(request, '500.html', {'correlation_id': correlation_id.get()}, status=500)

where the 500.html contains the HTML you wish to render 👍
Please feel free to report back with a solution when you're done. Could be cool to add a generalised example to the docs 🙏

Here's what worked for me
New config/error_views.py:
from django.http import (
    HttpResponseBadRequest,
    HttpResponseForbidden,
    HttpResponseNotFound,
    HttpResponseServerError,
)
from django_guid import get_guid

ERROR_PAGE_TEMPLATE = """
<!doctype html>

  <title>%(title)s</title>

%(title)s

%(details)s

Request ID: %(guid)s

"""

def server_error(request):
    return HttpResponseServerError(
        ERROR_PAGE_TEMPLATE
        % {
            "title": "Server Error (500)",
            "details": "An unexpected error occurred whilst processing the request",
            "guid": get_guid(),
        }
    )

def permission_denied(request, exception, template_name="403.html"):
    return HttpResponseForbidden(
        ERROR_PAGE_TEMPLATE
        % {
            "title": "Permission Denied (403)",
            "details": "No access to requested resource",
            "guid": get_guid(),
        }
    )

def bad_request(request, exception, template_name="400.html"):
    return HttpResponseBadRequest(
        ERROR_PAGE_TEMPLATE
        % {
            "title": "Bad Request (400)",
            "details": "",
            "guid": get_guid(),
        }
    )

In config/urls.py add:
handler500 = "config.error_views.server_error"
handler403 = "config.error_views.permission_denied"
handler400 = "config.error_views.bad_request"

Would you be amenable to including the "default with guid" error handlers to the package?

I'll leave that up to @JonasKs to decide, but I think adding template code to the library is a little out-of-scope. Think the styling etc. should be up to the user to define. Think it's a nice thing to describe how to set up in the docs though 👏

Agree with @sondrelg 😊 Documentation PR very welcome, but I'd prefer not to maintain templates - styling is so different between everyone.

I'll close this for now. If anyone else runs into similar issues, we now at least have your example to reference @andrew-cybsafe 👏


Flake: Unexpected crash in BigQuery quickstart

This happened in an unrelated PR. No time to investigate right now:
https://pantheon.corp.google.com/cloud-build/builds;region=us-east1/e3eb748d-4881-40a6-8c30-70fe11eba566?project=cloud-cpp-testing-resources&e=VertexAiColabPublicPreviewLaunch::VertexAiColabPublicPreviewEnabled&mods=logs_tg_prod
Step #5: 2024-03-08T19:46:48Z (+270s)
Step #5: ------------------------------------
Step #5: |   Running quickstart: bigquery   |
Step #5: ------------------------------------
Step #5: 2024-03-08T19:46:48Z (+270s): [ CMake ]
Step #5: double free or corruption (fasttop)
Step #5: /workspace/ci/cloudbuild/builds/lib/quickstart.sh: line 114: 289427 Aborted                 (core dumped) "${cmake_bin_dir}/quickstart" "${run_args[@]}"

No repeats in 90d; closing.


Jedis.ttl + cannot be cast to java.lang.Long

I'm accessing my Redis server through a slow network and I got this error when calling jedis.ttl(key);
java.lang.ClassCastException: [B cannot be cast to java.lang.Long
	at redis.clients.jedis.Connection.getIntegerReply(Connection.java:207)
	at redis.clients.jedis.Jedis.ttl(Jedis.java:287)

Maybe Redis answered a bad response and we couldn't deal with it.

Indeed. It was not broken response since we built a response with byte[], but maybe not Integer reply.

But it still looks as an issue, right?
On Tue, Apr 7, 2015 at 6:17 PM Jungtaek Lim<EMAIL_ADDRESS>wrote:

Indeed. It was not broken response since we built a response with byte[],
but maybe not Integer reply.
—
Reply to this email directly or view it on GitHub
https://github.com/xetorthio/jedis/issues/942#issuecomment-90735440.

Yes, it is. I'm curious how we can solve this issue.
Does throwing JedisException (maybe JedisConnectionException cause it's already mixed up?) instead of ClassCastException make sense?

I still didn't understand what causes this behaviour. The problem is that we could read some piece of response but not the entire response? This shouldn't throw some IO exception?

Since it doesn't have issue parsing result by REDIS protocol, it may receive other response which is not ERR. Seems like connection or Redis is mixed up.

Maybe sharing your code is better for finding if you don't mind. :)

Actually there is nothing different in my code. I'm just calling the Jedis.ttl method and it had thrown this exception.
This only happened once, but I think it could be a caused by a slow network connection.


Black formatting and locking for pytorch,

Pyxis reader now has a lock param.
Torch dataset uses this lock param.

Will change the git user and re-open this.


RenTimer Node

RenTimer Node - it will be timer thats take time form given ren variable.

Done in #74


Feedback for “Release notes”

The section about MAGE v1.14.0 mentions that Link Prediction and Node Classification with GNN is no longer available.
https://memgraph.com/docs/release-notes#unavailable-algorithms-in-mage-v1140-and-newer-versions
However, it does not mention WHY it's no longer supported. Also, it does not guide on how I could achieve that going forward in Memgraph?

Hi @vishnun and thank you for opening the issue. We have opened issues for the modules that are missing:

https://github.com/memgraph/mage/issues/470
https://github.com/memgraph/mage/issues/469
https://github.com/memgraph/mage/issues/448

On those issues, you can keep track of the progress of including them in MAGE. I will try to find out more from the team and get back to you as soon as I have update.
Are those modules a blocker for your project with Memgraph?

Thanks Katarina.
I don't see any updates on those issues but will keep an eye on those.
And yes, we need those algorithms to be about to achieve our goals. And if we have to build those from scratch, it'll be a lot more effort and will take much longer as it's not my area of expertise.
Hence, it's a blocker to consider Memgraph for my project.

Hi @vishnun, the issues will be updated at the beginning of next week since new prioritization tags will be added over the weekend.

@vishnun thnank you for reporting this. I've updated the release notes with the additional information.


rand: add methods to allow greater control over PCGSource

For golang/go#49934.

Should that be Seed128 instead? It's allowing you to set 128 bits of the generator's state, not 64.


embassy-net: Implement flush for TcpSocket

Implements flush for TcpSocket by checking the send queue.
Flushing is implemented by checking if smoltcp's send_queue/tx_buffer is empty. The flush is completed when all outstanding octets are acknowledged. Smoltcp wakes the send waker here when ACKs are processed and data is removed from the send buffer. So we can re-check in our flush implementation, if the buffer is now empty.
fixes #1223

Could you add pub async fn flush() to TcpSocket, TcpWriter as well?
The reason is that async traits are not yet available in Rust stable, so we add inherent (non-trait) methods for all the functionality. There was no point in having the flush methods before if they were noops, but now there is.
Thanks!

Right, added.


manual_backups.md

This is a super janky way to manually backup/restore the home directories on qhub. Hopefully, no one will actually have to use it before we implement proper backups.

@laisbsc done!


The problem that header files of nuget package are tidied.

Currently, header files of nuget package are tidied because the header files are commonly included from Additional Include Directories.
<?xml version="1.0" encoding="utf-8"?>
<Project ToolVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <ItemDefinitionGroup>
    <ClCompile>
      <AdditionalIncludeDirectories>$(MSBuildThisFileDirectory)..\lib\native\include\;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
    </ClCompile>
  </ItemDefinitionGroup>
  <ItemGroup />
</Project>

Most of nuget package target files are showed like above thing. They add their include directories to AdditionalIncludeDirectories.
But, most users don't want this behavior. I think that header files of nuget package shouldn't be tidied.

Thank you for submitting this idea for an improvement. It does seem reasonable for those headers not to get tidied.
We’ve added this to our todo and will update the issue thread as soon as progress is made.
Regards,
Gabriel.


Close TextReader in method ReadData()

The TextReader in method ReadData() must be closed, otherwise the CSV file is blocked (e.g. can't be renamed)
E.g.:
private static List<T> ReadData<T>(TextReader tr, bool hasheader, int colcount, char delimiter, ToOBJ<T> mapper)
{
    try
    {
       .....
    }
    finally
    {
        tr.Close();
    }
}

(use using statements ...)

Moved the Close() inside the exception otherwise it would happen after the first line is read.


fix a typo in keps

fix a typo in keps

NOTE: After opening the PR, please un-check and re-check the "Allow edits from maintainers" box so that maintainers can work on your patch and speed up the review process. This is a temporary workaround to address a known issue with GitHub.>
Please delete this note before submitting the pull request.

This change is

/approve


support openapi v2 for compatibility lower kubernete versions

What type of PR is this?

What this PR does / why we need it:
If we want to run clusterpedia in low kubernete version , the kubernete apiserver will output error logs.
E1109 11:09:21.665110       1 controller.go:116] loading OpenAPI spec for "v1beta1.clusterpedia.io" failed with: OpenAPI spec does not exist
I1109 11:09:21.665131       1 controller.go:129] OpenAPI AggregationController: action for item v1beta1.clusterpedia.io: Rate Limited Requeue.

Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Thanks @huiwq1990, this looks like a very meaningful pr, I'll verify it!


bash user.sh error

root@localhost:~# bash user.sh
bash: user.sh: No such file or directory

please show the output of
$ ls ~

no output
root@localhost:~$ ls
root@localhost:~$ ls
root@localhost:~$ ls

no output root@localhost:~$ ls root@localhost:~$ ls root@localhost:~$ ls

kindly reinstall modded-ubuntu sir
you can do it by executing:-
$ cd ~/modded-ubuntu && bash remove.sh && sleep 2 &&  bash setup.sh

no output root@localhost:~$ ls root@localhost:~$ ls root@localhost:~$ ls

kindly reinstall modded-ubuntu sir you can do it by executing:- $ cd ~/modded-ubuntu && bash remove.sh && sleep 2 && bash setup.sh

Sir when jammy jellyfish will come in  the modded ubuntu

As soon as the Termux devs push the updates😌
On Mon, May 2, 2022, 11:36 AM HackerBrine2004 @.***>
wrote:

no output @.:$ ls @.:$ ls @.***:~$ ls
kindly reinstall modded-ubuntu sir you can do it by executing:- $ cd
~/modded-ubuntu && bash remove.sh && sleep 2 && bash setup.sh
Sir when jammy jellyfish will come in the modded ubuntu
—
Reply to this email directly, view it on GitHub
https://github.com/modded-ubuntu/modded-ubuntu/issues/49#issuecomment-1114513756,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQAS3W4XIZRKKMBU4QO4BRLVH5SXRANCNFSM5PMOMKLA
.
You are receiving this because you commented.Message ID:
@.***>

I'm am very grateful to the modded ubuntu devs for making it I'm liking it a lot and thanks for the instant support i wish you a very good luck for future🙏
Sir also wanted to add that plz make it compatible to run edex ui.☺

I'm am very grateful to the modded ubuntu devs for making it I'm liking it a lot and thanks for the instant support i wish you a very good luck for future🙏 Sir also wanted to add that plz make it compatible to run edex ui.☺

it's already compatible to run edex-ui download edex appimage according to your cpu architecture then mark it as "run as program" from the appimage properties then simply run that...but I want to warn if you have a nice number of ram than don't run edex-ui because it can hang your device

Sir after installing the arm64 appimage i am running it as program it is showing
Cannot mount appimage, please check your fuse setup
You might still be able to extract the contents of this Appimage if you run it with the-appimage-extract option See https://github.com/Appirnage/Appimagewiki/Fuse

Sir after installing the arm64 appimage i am running it as program it is showing
Cannot mount appimage, please check your fuse setup You might still be able to extract the contents of this Appimage if you run it with the-appimage-extract option See https://github.com/Appirnage/Appimagewiki/Fuse

Try to run the appimage in terminal using ./ then send ss of output

Sir this is the ss.

your ss didnt come well please send ss perfectly

Sir i have also sent ss via gmail

wel I dont get the ss
On Wed, May 4, 2022 at 11:33 AM HackerBrine2004 @.***>
wrote:

Sir i have also sent ss via gmail
—
Reply to this email directly, view it on GitHub
https://github.com/modded-ubuntu/modded-ubuntu/issues/49#issuecomment-1116943582,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQAS3W2UUUTD57LGYBLURDDVIID3XANCNFSM5PMOMKLA
.
You are receiving this because you commented.Message ID:
@.***>

wel I dont get the ss
…
On Wed, May 4, 2022 at 11:33 AM HackerBrine2004 @.***> wrote: Sir i have also sent ss via gmail — Reply to this email directly, view it on GitHub <#49 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQAS3W2UUUTD57LGYBLURDDVIID3XANCNFSM5PMOMKLA

Sir plz provide a particular gmail where i may send the ss

Sir plz provide a particular gmail where i may send the ss

send the ss in my telegram :- @bdhackers009

Yes sir sent thank you

You're welcome!
On Wed, May 4, 2022, 11:43 AM HackerBrine2004 @.***>
wrote:

Yes sir sent thank you
—
Reply to this email directly, view it on GitHub
https://github.com/modded-ubuntu/modded-ubuntu/issues/49#issuecomment-1116949748,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQAS3W5V3ARPBM2Y6SQFNMLVIIFBHANCNFSM5PMOMKLA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Sir this is the ss
On Tue, 3 May, 2022, 6:17 pm Mustakim Ahmed Sifat, @.***>
wrote:

Sir after installing the arm64 appimage i am running it as program it is
showing
Cannot mount appimage, please check your fuse setup You might still be
able to extract the contents of this Appimage if you run it with
the-appimage-extract option See
https://github.com/Appirnage/Appimagewiki/Fuse
Try to run the appimage in terminal using ./ then send ss of output
—
Reply to this email directly, view it on GitHub
https://github.com/modded-ubuntu/modded-ubuntu/issues/49#issuecomment-1116059384,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXPHQTHEL2XSIBTEUIIGGSLVIEN7NANCNFSM5PMOMKLA
.
You are receiving this because you commented.Message ID:
@.***>


Addressing FutureWarning for elem check

Line 56 of parse.py emits a FutureWarning in debug logs, saying the default behavior of not elem will change in new versions.  Changing this call to elem is not None to address the warning.

Thanks.


Add Neovim as a text-editor

Neovim is absent from the text-editors section.

Didn't vim 8 destroy neovim?

Added. :)

@dkrieger vim8's new feature is hard to use, I think neovim is better. and here is a post from author of ag
https://geoff.greer.fm/2015/01/15/why-neovim-is-better-than-vim/
@k4m4  I think neovim should have save level as vim or emacs or other editor.


Omit href

Fixes #225
Can you review @jankowiakmaria @lukasz-lysik ?

@matteofigus could you rebase it, please?

@jankowiakmaria done - would be cool if you could pair with @federicomaffei when reviewing this!
Thanks :)

ok, sorry I haven't done it for the other one - I haven't noticed your message

reviewed with @jankowiakmaria - LGTM


Version 0.8 docs missing

Just noticed in read the docs you can only select versions up to 0.5 and the current master. Not sure if this is intentional or not.

This is fixed now, not sure where they went.


Spotify Web API Support

This framework addition allows use of the Spotify Web API when using Spotify which opens up the feature possibilities that weren't available using only the Spotify App Remote API. The framework takes the user through the entire authentication process using the PKCE flow and then stores the authorization/access token information to your device. The authorization process should be a rare occurrence as once the user is authorized a refresh token is used to refresh the expired access token (which are both carried over and handled each music session). If the user needs to re-authenticate the app will provide a notification as well as show the error in the error dialog of the "Now Playing" screen of the UI, both of which can be utilized to re-authenticate (clicking the notification to re-authenticate will directly load the Spotify login page without going through the phone UI). Note this notification will only show up when the user has successfully authenticated at least once as to not spam uninterested users.
Sample video of how the authorization process works:
https://user-images.githubusercontent.com/11298573/102850122-49822a00-43de-11eb-8a44-4e69038a6f6a.mp4
Also included in this PR is the change that when the user loads their "Liked Songs" playlist from their library, the Web API will be invoked and used to create the playlist structure to ensure that the cover art is properly pulled (addressing this issue: https://github.com/hufman/AndroidAutoIdrive/issues/138). If the Web API call fails or the user does not prefer to authorize the Web API, the App Remote API will be used as a fallback.
Sample video of the "Liked Songs" playlist being loaded with cover art:
https://user-images.githubusercontent.com/11298573/102852157-32920680-43e3-11eb-96a0-c098b02f695b.mp4

Here's the new music permissions addition:


Change to cache expiration

I made these changes in response to a stackoverflow question where a user wanted to be able to have a non expiring cache: http://stackoverflow.com/questions/29561011/how-to-disable-memcached-timeout-in-werkzeug
In the process I also fixed a potential Redis bug that was highlighted in issue #550

I see the travis build failed... I don't completely understand why though.
There is this error in the log for python 2.7
E               RuntimeError: Server is down.

I'll look at the PR soonish... don't worry about the failed test.

Looks good, please add an entry to the changelog.

Is this change ok now?

@thirty3 Sorry, I forgot, could you add some testcases in tests/contrib/test_cache.py too?

I'll have a think about how best to test this :yum:  But I will add some tests

I think it should be good enough to check if the value is still there after five secs. You could also use a randomized instead of 5.

First I need to apologise. I thought this was a trivial update, unit testing pointed out a couple of bugs. There is now parity across all different Cache systems and timeout = 0 will make cache persist indefinitely. The potential Redis bug came up during unit testing and was also fixed

Thanks. Please address the two comments I've made on the PR-diff (see "Files changed" tab).
Also, please use rebase instead of merging when updating PRs, this allows you to keep a linear commit history and also to put all changes into one commit. If you can't figure out right now how that works it's ok, I'll do it.

Sorry, I have no idea how to rebase update this PR now.

No problem. I suppose you forgot to push your changes though?

I'm waiting for Travis to check my changes before updating the PR

Oh, you have separate branches for this...

It's a compulsion :)
On Thu, Apr 30, 2015 at 7:05 PM, Markus Unterwaditzer <
<EMAIL_ADDRESS>wrote:

Oh, you have separate branches for this...
—
Reply to this email directly or view it on GitHub
https://github.com/mitsuhiko/werkzeug/pull/725#issuecomment-97882816.

I find that these Travis tests fail intermittently. Any ideas why?

That's a random memcached failure. I'll rebase and merge later, thanks!

Thanks, I've applied your PR!

This is broken for 'FileSystemCache' - I've forked the repo and made a simple fix. Would you be interested in a PR?

How is it broken?
On 9 November 2015 13:36:19 CET, Padarn Wilson<EMAIL_ADDRESS>wrote:

This is broken for 'FileSystemCache' - I've forked the repo and made a
simple fix. Would you be interested in a PR?

Reply to this email directly or view it on GitHub:
https://github.com/mitsuhiko/werkzeug/pull/725#issuecomment-155052264

--
Sent from my phone. Please excuse my brevity.

The calculate of 'expired' is not done, so timeout=0 just leads to a cache
that stores nothing.
On Mon, 9 Nov 2015 at 12:38, Markus Unterwaditzer<EMAIL_ADDRESS>wrote:

How is it broken?
On 9 November 2015 13:36:19 CET, Padarn Wilson<EMAIL_ADDRESS>wrote:

This is broken for 'FileSystemCache' - I've forked the repo and made a
simple fix. Would you be interested in a PR?

Reply to this email directly or view it on GitHub:
https://github.com/mitsuhiko/werkzeug/pull/725#issuecomment-155052264

--
Sent from my phone. Please excuse my brevity.
—
Reply to this email directly or view it on GitHub
https://github.com/mitsuhiko/werkzeug/pull/725#issuecomment-155052566.

Sorry on phone - will give better details when I can
On Mon, 9 Nov 2015 at 12:40, Padarn Wilson<EMAIL_ADDRESS>wrote:

The calculate of 'expired' is not done, so timeout=0 just leads to a cache
that stores nothing.
On Mon, 9 Nov 2015 at 12:38, Markus Unterwaditzer <
<EMAIL_ADDRESS>wrote:

How is it broken?
On 9 November 2015 13:36:19 CET, Padarn Wilson<EMAIL_ADDRESS>wrote:

This is broken for 'FileSystemCache' - I've forked the repo and made a
simple fix. Would you be interested in a PR?

Reply to this email directly or view it on GitHub:
https://github.com/mitsuhiko/werkzeug/pull/725#issuecomment-155052264

--
Sent from my phone. Please excuse my brevity.
—
Reply to this email directly or view it on GitHub
https://github.com/mitsuhiko/werkzeug/pull/725#issuecomment-155052566.

Sorry, been off the grid a bit.
Has this issue been resolved?

Nothing since my last message. I am using a modified version locally, but
haven't submitted a PR as no one seemed particularly interested. Still
happy to do so if people would be interested.
On Wed, Nov 25, 2015 at 9:23 AM Leon Bezuidenhout<EMAIL_ADDRESS>wrote:

Sorry, been off the grid a bit.
Has this issue been resolved?
—
Reply to this email directly or view it on GitHub
https://github.com/mitsuhiko/werkzeug/pull/725#issuecomment-159545898.

Yeah man, submit it

Sorry, I assumed that you'd send a PR by yourself, but then forgot about this!

Ok. I'll get onto it when I've next got a bit of free time :-)
On Wed, Nov 25, 2015 at 8:28 PM Markus Unterwaditzer <
<EMAIL_ADDRESS>wrote:

Sorry, I assumed that you'd send a PR by yourself, but then forgot about
this!
—
Reply to this email directly or view it on GitHub
https://github.com/mitsuhiko/werkzeug/pull/725#issuecomment-159723756.


 I deployed the docker image to docker cloud. It works inside the remote terminal (localhost:8080), but the service is unreachable outside the container.
My docker-compose file looks like:
imageproxy:
  image: 'willnorris/imageproxy:latest'
  ports:
    - '8080:8080'

I'm assuming the internal web service is blocking connections but I am not savvy enough to know how to configure it.
Thank you for an otherwise awesome service and I look forward to be being able to deploy it to docker cloud once I have figured this out.

No clue, I don't actually use docker myself
/cc @sevki who might be able to help.

Thank you for your prompt response.
@sevki I have the same problem using sevki/imageproxy
Your docker run example command uses 'addr'
docker run -p 8080:8080 willnorris/imageproxy -addr <IP_ADDRESS>:8080
I do not know what the analog is for that in docker-compose. -addr is not mentioned in any of the docker run documentation I looked at here: https://docs.docker.com/engine/reference/run/
My previous experience with docker images that host web service is that you expose ports and you're done.

hey @metalaureate
can you give me more information about what you are trying to run this on (osx, linux) and what it is exactly you are trying to do

It's definitely working inside its container, just to rule that out:

@sevki  hi! I am trying to create an http imageproxy service for my application by deploying the image to an EC2 instance, using Docker Cloud.

analog for that in compose would be something along the lines of
imageproxy:
  image: 'willnorris/imageproxy:latest'
  command: /go/bin/imageproxy -addr <IP_ADDRESS>:8080
  ports:
    - '8080:8080'

Unfortunately that doesn't work.I wish I knew and Go and I would try to troubleshoot.

I also have this problem if I try to run it locally on a Mac OS X:
docker run -i -t -p 8080:8080 willnorris/imageproxy:latest  /go/bin/imageproxy -addr <IP_ADDRESS>:8080

`imageproxy (version HEAD) listening on localhost:8080

I requested some docker community assistance here: http://stackoverflow.com/questions/36321618/go-imageproxy-inaccessible-from-docker-container

Was able to reproduce this with the 'willnorris/imageproxy' version. I can curl port 8080 inside of the container but not from the host.
I run my own imageproxy docker with custom configuration so I know imageproxy does work inside of docker.  I do not run the 'willnorris/imageproxy' version. My guess is the default configuration bind to <IP_ADDRESS> (should be <IP_ADDRESS>) because of this line:  imageproxy (version HEAD) listening on localhost:8080
localhost in the docker machine (cat /etc/hosts) is map to <IP_ADDRESS>

To demonstrate, here's my fork copy with custom configuration:
https://github.com/trybrick/imageproxy/blob/master/Dockerfile
https://github.com/trybrick/imageproxy/blob/master/scripts/run.sh
Live Docker example:
Original: http://imageproxy.brickinc.net:4593/http://upload.gsngrocers.com/chainfiles/218/2015/8/MAR_TonyPriolo_Sept15_WELCOME.jpg
Resized: http://imageproxy.brickinc.net:4593/300/http://upload.gsngrocers.com/chainfiles/218/2015/8/MAR_TonyPriolo_Sept15_WELCOME.jpg
Per the above configuration (run.sh), the service only work for URLs that I've whitelist.

@noogen  Thanks for picking up this thread. When I try to run the customer dockerfile, I get the error

package willnorris.com/go/imageproxy/cmd/imageprox: /go/src/willnorris.com/go/imageproxy exists but /go/src/willnorris.com/go/imageproxy/.git does not - stale checkout?

Anyone know what that's about?

My mistake, I was running it inside of my Rancher cloud without parameters.  It work fine for me on OSX command line.
Run it with the exact command from docker hub wiki: docker run -p 8080:8080 willnorris/imageproxy -addr <IP_ADDRESS>:8080
http://<IP_ADDRESS>:8080/400/http://upload.gsngrocers.com/chainfiles/218/2015/8/MAR_TonyPriolo_Sept15_WELCOME.jpg
<IP_ADDRESS> is my docker machine IP.

To clarify.
The command line below is wrong:

docker run -i -t -p 8080:8080 willnorris/imageproxy:latest /go/bin/imageproxy -addr <IP_ADDRESS>:8080

Since docker already execute (ENTRYPOINT "/go/bin/imageproxy"), there is no need for that statement.  Remove and it should work.
As for this:

but /go/src/willnorris.com/go/imageproxy/.git does not - stale checkout?
Network issue?

That worked. Thank you! Docker Cloud was not picking up that second clause in the ENTRYPOINT array ("-addr <IP_ADDRESS>:8080")--which I think is a bug in Docker Cloud. Once I manually overrode it with array syntax full statement ENTRYPOINT "/go/bin/imageproxy -addr <IP_ADDRESS>:8080" it worked fine.


The Visual Editor border does not stay in a fixed position

Describe the bug
The Visual Editor's border does not stay in a fixed position when the editor's content extends to the right and the user scrolls the editor to the right.
Version
Master
To Reproduce
Steps to reproduce the behavior:

Add a new action
Add several nested if-statements
Scroll to the right
Notice the border scrolls with the editor's contents

Expected behavior
The border should stay in a fixed position
Screenshots

The border should fullfill the editor canvas

addressed in #3605


Contributing to the User Experience Subpage

Summary

Re-organized existing information in this subpage
Created a table of contents
Added to the following subheadings:

Overview
Helpful courses (specifically discussed a Coursera specialization that I took)

Created and added discussion on the following topics:

User research (includes POV statements and user personas)
Visual elements of UI design
Site mapping, wireframing, prototyping
Design tools

Overall, the restructuring and additional Info added to the page was really well done, it improved the flow of the main UI page a lot. Including the table of contents is really helpful for people to quickly navigate to pages/content they're interested in. I think the prototyping and User Research and Personas content will be helpful for future students with Deliverable 1, as it gives a good starting point. Overall nice work :)

Thanks Leya! I incorporated all the feedback you gave me. I'm glad you think some changes I made will be helpful for future CSC301 students!


The dimension field contains the '.' symbol, how should it be queried?

The dimension field contains the '.' symbol, how should it be queried?

I try to use  SELECT * FROM bro2 WHERE id.orig_h='<IP_ADDRESS>'
The following error occurred
Unknown exception / org.apache.calcite.runtime.CalciteContextException: From line 1, column 41 to line 1, column 42: Table 'id' not found / org.apache.calcite.tools.ValidationException

Try SELECT * FROM bro2 WHERE "id.orig_h"='<IP_ADDRESS>'

thank you very much


Windows wheels are not created

The windows build must be fixed.

Fixed in: 2aacaa92f366920bb70c03dcd281e4a2eb2dfa9f
SuperLU still not working, though.


[BUG] Too many pagerduty schedules causes /incident pager command to time out

Describe the bug
We have 16 schedules in PagerDuty, and when we run /incident pager the command times out. In the log I see the following messages
PagerDuty returned 15 schedules
Error: The request to the Slack API failed. (url: https://www.slack.com/api/views.open) The server responded with {'ok': False, 'error': 'expired_trigger_id'}

Version
1.10.1
To Reproduce
Steps to reproduce the behavior:

Create 15 schedules in PagerDuty
Type /incident pager

Expected behavior
Modal should popup
Environment (please complete the following information):

Platform: Kubernetes

Additional context
I'm not 100% sure that 15 schedules causes it, could be the number of users per schedule or something else

@ImDevinC sorry it took me so long to get to this. I just released v1.12.0 which should resolve this. The pager command now pulls from the copy of the pd info in the db instead of calling the API each time. Please let me know if not. Thanks!


Add missing pagebreak to COBOL Syntax

      / wibble
      *  stuff
      *> wibble
      *
012@22* stuff
121120* wibble

new scope for ""comment.line.cobol.newpage" which is by default a comment but you can tweak it to make the newpage break comment to standout.
    "editor.tokenColorCustomizations": {
        "textMateRules": [
            {
                "scope": "comment.line.cobol.newpage",
                "settings": {
                    "foreground": "#ffff00",
                    "fontStyle": "italic bold underline",
                }
            }
        ]

For example:

I really like that, what do you think about making it underlined by default?

Stranglely I have the leading spaces colored the same way - that happens when there's no "content" in, I guess that isn't by design? If it is: can I request to only color the /in this case?
           EXIT.
      /
      *---------------------------------------------------------------*

I will review this later.

You will need to say what theme you are using because I get:

Hm, no theming options ever set. But that was vscode 1.48, maybe that's different with 1.49.

Fixed with 00ac2e8246e30af21f60ce3ffd04384941d76f59.