Fix issues of ubuntu branch weekly job on RELEASE-3.1.x

Fix defect 384858:
https://jazzop27.rtp.raleigh.ibm.com:9443/ccm/web/projects/BlueBox Cloud#action=com.ibm.team.workitem.viewWorkItem&id=384858
Includes:

Fixed issue in task "neutron-control : sync neutron database for lbaas" by changing cmd to "neutron-db-manage --subproject neutron-lbaas --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugins/ml2/ml2_plugin.ini upgrade head".

Synced rally related tasks with master branch.

Synced testenv_instance_prefix in test/common with master branch.

Job ran locally passed.

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

Are these changes already on master? We cannot make changes to just release branch. Typical flow is PR to master and cherry pick to branch. If there is strong reason to have fix made only to release branch than that must be mentioned.

retest

@nirajdp76, There are three parts will be updated to RELEASE-3.1.x branch in this PR:

For test/common and test/setup, all changes are copied from master branch to keep testenv_instance_prefix correctly, etc.
For rally stuff, also copied from master branch.
For change in roles/neutron-control/tasks/main.yml, I compared RELEASE-3.1x and master branch, and found that task "sync neutron database for lbaas" only existing on RELASE-3.1.x, that's why we only need modify in RELEASE-3.1.x but not in master branch.

I debugged locally based on these changes for RELEASE-3.1.x branch with package (2016.1-bbc248) installed, passed.

Remove point #3 "For change in roles/neutron-control/tasks/main.yml", since cmd with "--service lbaas" works again.

Also please remove internal bug tracking references from the description.


Responsive Navbar

Changes related to making the navbar responsive broken out from a too-large PR

Thanks for splitting this up

Any reason this has not been merged?

Left is old, right is new - looks good!


Autocomplete in VSCode not working properly

Versions:

ide-helper Version: 2.13
Laravel Version: 10.14.1
PHP Version: 8.2.4

Description:
In Visual Studio Code it seems the autocompletion doesn't work properply.
It works good inside web.php and api.php, but inside controllers and models (probably others too), I get autocompletion only for what is inside _ide_helper_models.php which are a few methods, but it seems VSCode doesn't get autocompletion from _ide_helper.php (which PHPStorm does).
But inside api.php and web.php it seems it recognize that file and I get autocompletion completly fine.
I've tried to do the same thing in PhpStorm and It seems it works correctly in that IDE.
Is there a way I can make it work with VSCode?
https://i.imgur.com/iaYtBeR.png
P.S: I have PHP Intelephense installed already.

Most plugins don't support @mixin, install PHP Intelephense and buy a lisence, then it works.
[1.7.0 - 2021-04-26]
Added

@mixin support. Premium


Unable to delete a newline

Hi, thank you for this!  I'm having issues using this in a form.  After hitting enter to do a new line I'm unable to backspace through the newline to delete it.  Before hitting enter backspace works fine.  Here is a quick recording of this in action:

I've set up an example repo that is just a base phoenix app with minimal changes to show this problem: test_monaco
This is happening on a Mac w/ Safari, Chrome and Arc browsers.
Thank you, again!

Hey @iautom8things thanks for the detailed report. Support for forms is a bit tricky, I suggest to fetch the editor content with an event listener instead:
# firstly we need to ignore events trigger by the editor
  def handle_event(
        "validate",
        %{
          "_target" => ["live_monaco_editor", @new_query_path]
        },
        socket
      ) do
    {:noreply, socket}
  end

And then fetch the content as explained here https://github.com/BeaconCMS/live_monaco_editor#fetching-the-editor-value

Hey @iautom8things I'm closing this one but feel free to comment here or submit a new issue. Thanks.


Option to add mimetype to wps request

Hey guys
https://github.com/geopython/OWSLib/blob/916003071191b9c0a94a8d9a352bd87e42ab0e43/owslib/wps.py#L708-L711
in these lines the WPS creates the xml element that we will send as WPS execute payload as the output details.
Will it be possible to declare the mime type of the output? I thought of something like this:
 elif isinstance(output, list):
     for ouputTuple in output:
        if(len(tuple) == 2):
          (identifier, as_reference) = tuple
        else:
          (identifier, as_reference, mimeType) = tuple
         # of course adjusting _add_output to handle the mimeType will be required
         self._add_output(
             responseDocumentElement, identifier, asReference=as_reference, mimeType=mimeType)

*In this way the backward compatibility
any opinions?

@cehbrecht

fixed by PR #540.


Cannot use a grid VGPU

Describe your issue here and explain how to reproduce it.
I am using a RTX6000 vgpu, Rviz only use the vmware SVGAII, resulting in low frame rate.
Your environment

OS Version: e.g. Ubuntu 20.04
ROS Distro: [Noetic]

Maybe you need to explicitly specify which GPU to use, e.g. using environment variables?


Propose testing and nightly version of the addon

It would be helpful to test on hassio "beta" version, from the :testing or :nightly docker image published.
See: https://developers.home-assistant.io/docs/add-ons/presentation#offering-stable-and-canary-version

Tested successfully for testing image on a fork: https://github.com/FraBoCH/hassio-addon/tree/testing
If a contributor can create a "testing" branch, I can create a pull request for that (very simple) change in config.
The same idea could be then done on nightly.

That's nice, but won't help. We would need to set the :nightly tag for that branch, but as a result the add-on won't get updated. Home assistant supervisor doesn't compare the containers SHA digest against the digest in the container registry. It simply compares the installed container tag against the tag configured in the add-on repository config. And if there's any diff, it will suggest updating the addon.
That being said, we would require to generate a new tag for every nightly build, which would result in a huge tag sprawl at the container registry.
We already talked with HA maintainer Frenck, but they are not willing to change the current update check behavior in the near future.

I see. For nightly it's definitively not manageable.
Maybe this principle could still be used for pre-release beta testing when that's useful (I had this idea when testing a fix for https://github.com/evcc-io/evcc/issues/13007).

Would you describe the way how you do it, that other users could do in the same way?


Website crashed after uptade to 4.0.3.

Issue description:
Website crashed after update to 4.0.3.
Fehler-Details
Ein Fehler vom Typ E_ERROR wurde in der Zeile 3 der Datei /home/beatri4/www/distisuisse.ch/wp-content/plugins/codeless-builder/include/core/kirki-setup/codeless_custom_section.php verursacht. Fehlermeldung: Uncaught Error: Class 'WP_Customize_Section' not found in /home/beatri4/www/distisuisse.ch/wp-content/plugins/codeless-builder/include/core/kirki-setup/codeless_custom_section.php:3
Stack trace:
#0 /home/beatri4/www/distisuisse.ch/wp-content/plugins/codeless-builder/include/core/cl-kirki-setup.php(74): require_once()
#1 /home/beatri4/www/distisuisse.ch/wp-includes/class-wp-hook.php(303): Cl_Kirki_Setup->load_custom_section(Array)
#2 /home/beatri4/www/distisuisse.ch/wp-includes/plugin.php(189): WP_Hook->apply_filters(Array, Array)
#3 /home/beatri4/www/distisuisse.ch/wp-content/plugins/kirki/packages/kirki-framework/compatibility/src/deprecated/filters.php(13): apply_filters('kirki/section_t...', Array)
#4 /home/beatri4/www/distisuisse.ch/wp-includes/class-wp-hook.php(303): Kirki\Compatibility\Deprecated->{closure}(Array)
#5 /home/beatri4/www/distisuisse.ch/wp-includes/plugin.php(189): WP_Hook->apply_filters(Array, Array)
#6 /home/beatri4/www/distisuisse.ch/wp-content/plugins/kirki/packages/kirki-framework/modu
Version used:
(Did you try using the develop branch from GitHub? There's a chance your issue has already been addressed there)
Using theme_mods or options?
Code to reproduce the issue (config + field(s))

It seems like Codeless builder is not compatible with Kirki 4. I'm reaching out to them now.

From what I can tell, the Codeless Page Builder hasn't received any updates for over 2 years - https://wordpress.org/plugins/codeless-page-builder/

We have the same issue, but are not using codeless:
[Thu Dec 30 17:25:42.952583 2021] [php7:error] [pid 321486] [client <IP_ADDRESS>:55726] PHP Fatal error:  Uncaught Error: Class '\\Kirki\\Field\\CSS\\ReactColorful' not found in /var/www/html/wp-content/plugins/k │ │ irki/packages/kirki-framework/module-css/src/CSS/Generator.php:170\nStack trace:\n#0 /var/www/html/wp-content/plugins/kirki/packages/kirki-framework/module-css/src/CSS.php(351): Kirki\\Module\\CSS\\Generator::css │ │ (Array)\n#1 /var/www/html/wp-content/plugins/kirki/packages/kirki-framework/module-css/src/CSS.php(268): Kirki\\Module\\CSS::loop_controls('stratus_theme')\n#2 /var/www/html/wp-content/plugins/kirki/packages/kirk │ │ i-framework/module-css/src/CSS.php(179): Kirki\\Module\\CSS->print_styles()\n#3 /var/www/html/wp-includes/class-wp-hook.php(303): Kirki\\Module\\CSS->print_styles_inline('')\n#4 /var/www/html/wp-includes/class-wp │ │ -hook.php(327): WP_Hook->apply_filters(NULL, Array)\n#5 /var/www/html/wp-includes/plugin.php(470): WP_Hook->do_action(Array)\n#6 /var/www/html/wp-includes/general-template.php(3015): do_action('wp_head')\n#7 /var │ │ /www/html/wp-content/themes/stratusx/templates/head.php(10): wp_head()\n#8 /var/www/html/wp-i in /var/www/html/wp-content/plugins/kirki/packages/kirki-framework/module-css/src/CSS/Generator.php on line 170, refer │

@willsheldon, are you running version 4.0.3? This was reported previously and should now be fixed.

Hmm, I'm not sure. wp-admin/plugins.php page reports "Version 4.0" but clicking "view details" gives "Version: 3.1.9". I guess this issue is unrelated to this thread either way. Sorry!

No worries :) You can try to download & install the very latest version manually to check if it makes any difference - https://wordpress.org/plugins/kirki/

Confirmed, a manual update to 4.0.3 (latest from https://wordpress.org/plugins/kirki/) resolved the issue.

Hi, samething with me also, I have upadated to 4.0.3. I have lost a search bar on the hearder,payment gateway pictures and recently viewed products have also disappeared from the footer. When I disable the plugin, the search bar from the header comes back but the footer still remains a problem. I use Martfury theme.

@moetimolateli77, can you please reach out to the original developers of the theme & check if this is something they can look into on their end? The probably haven't tested their theme with Kirki 4 during the beta phase.

I will do so. Thank you.

This is quite a bomb drop before New Years...
All the default values show as 'null' no matter if it's done natively or in a custom way, unless you change the value and save it. Please look into this!

@Gnodesign, what theme are you using? Can you also please try and get the original theme dev's involved in this? Do you get any errors when testing Kirki 4 with debug mode turned on (https://wp-pagebuilderframework.com/docs/debugging/)?
Any additional information would be helpful.

@MapSteps I am a theme dev and this issue happens throughout all of my themes. The default values of the added fields show as 'null' and do not present the actual default value which causes errors on my code. I could run a check to avoid these error but still the default values should work the same just as is 3.1.9 in order for the fields to actually work.

That's really strange, all defaults are working fine on our end. Can you please just quickly create a new issue so we don't mix things up here too much? That would be awesome. If you can think of anything custom you might have done, for instance to extend Kirki, please mention it there. I'm also happy to look into the theme itself.

@moetimolateli77, can you please reach out to the original developers of the theme & check if this is something they can look into on their end? The probably haven't tested their theme with Kirki 4 during the beta phase.

Looks like I can't get hold of the dev guys.  So does that mean there isn't anything you can do on you side?

@moetimolateli77, we don't have access to the theme. Can you please send us a dropbox/google drive link to<EMAIL_ADDRESS>Thank you!

@MapSteps Thank you for getting back to me. Will do so!

I'm closing this for now as the chaps over at Codeless said they're going to tackle this on their end.


Make cargo install work on windows

Otherwise it complains about invalid url

Thanks for pointing this out. Actually now that racer 1.1.0 has been released to crates.io, cargo install racer should be enough. I updated the README to reflect this.


Block comment toggle issue

Issue Type: Bug
Dear Sir/ Madam,
I am Asraful Haque. At first, I appreciate all your efforts to make the VS Code the most beautiful editor and, I am enjoying it as much except an issue. Suppose I have a Java code below.
  public final void display() {
        System.out.println("Try to override the final method.");
  }

Now I am commenting on the above code as a block comment and, the result is below
/*     public final void display() {
        System.out.println("Try to override the final method.");
    }
 */

Now I have used the command Shift + Alt + F to format the whole code, result is below
    /*
     * public final void display() {
     * System.out.println("Try to override the final method."); }
     */

Now I would like to uncomment the block comment applying the "toggle block comment" command, the result is below
/*     /*
     * public final void display() {
     * System.out.println("Try to override the final method."); }
     */ */

Overall the function is not working.
Hope your developers will fix this issue soon to enhance the rich functionality!
Thanks
Asraful Haque
Email<EMAIL_ADDRESS>or<EMAIL_ADDRESS>VS Code version: Code 1.57.1 (507ce72a4466fbb27b715c3722558bb15afa9f48, 2021-06-17T13:28:07.755Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-8250U CPU @ 1.60GHz (8 x 1800)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.92GB (9.28GB free)

Process Argv
--crash-reporter-id d3e08a65-1584-40c1-ae89-b3c48559ff82

Screen Reader
no

VM
0%

Extensions (27)

Extension
Author (truncated)
Version

project-manager
ale
12.2.0

alignment
ann
0.3.0

vscode-intelephense-client
bme
1.7.1

phptools-vscode
DEV
1.4.6842

php-debug
fel
1.16.0

php-intellisense
fel
2.3.14

php-pack
fel
1.0.2

vscode-test-explorer
hbe
2.20.4

wordpress
hri
1.0.1

php-namespace-resolver
Meh
1.1.8

fluent-icons
mig
0.0.12

theme-monokai-pro-vscode
mon
1.1.19

language-gettext
mro
0.2.0

vscode-docker
ms-
1.14.0

remote-wsl
ms-
0.56.5

sublime-keybindings
ms-
4.0.9

test-adapter-converter
ms-
0.0.10

java
red
0.80.0

vscode-fileutils
sle
3.4.5

learn-vim
vin
0.0.27

vscodeintellicode
Vis
1.2.14

vscode-java-debug
vsc
0.34.0

vscode-java-dependency
vsc
0.18.5

vscode-java-pack
vsc
0.17.0

vscode-java-test
vsc
0.30.1

vscode-maven
vsc
0.31.0

wordpress-toolbox
wor
1.3.10

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
pythonvspyt639:30300192
pythontb:30283811
vspre833:30321513
pythonptprofiler:30281270
vshan820:30294714
pythondataviewer:30285071
vscus158:30321503
pythonvsuse255cf:30323309
vscorehov:30309549
vscod805cf:30301675
pythonvspyt200:30331937
binariesv615:30325510
aatestflightcf:30331712

Now I have used the command Shift + Alt + F to format the whole code, result is below

I can't reproduce that. The built-in JavaScript/TypeScript formatter doesn't change the content of a block comment.
Are you maybe using a different formatter?


MediaBrowser 3 support

In Mediabrowser 3 there is currently a plugin for Anime and it works great overall but JMM offers lots when it comes to anime and maybe could maybe enhance the current Anime plugin or replace it :)

Support for Emby is something that we will not be adding ourselves, this doesn't mean we don't want to see it supported but adding another plugin that requires us to support and maintain it is beyond the scope of the project at the moment.
Similar to Nakamori, we'll provide support if another developer wants to create the plugin.


way to disable lights when arrows pressed

What feature do you want to get added on the base engine?
pls do it
To test your sight, and reliability, please select the option of what should NOT be requested.
A good idea

Failed the test.

fooled on april + failed the test


Escaped field names do not work

use thiserror::Error;

#[derive(Debug, Error)]
pub enum Error {
    #[error("invalid field type {r#type:?} for {field:?}")]
    InvalidField {
        field: String,
        r#type: String
    }
}

invalid format string: expected `'}'`, found `'#'`
  --> src\lib.rs:17:51
   |
17 |     #[error("the field {field:?} is not of type {r#type:?}")]
   |                                                 - ^ expected `}` in format string
   |                                                 |
   |                                                 because of this opening brace
   |
   = note: if you intended to print `{`, you can escape it using `{{`

I would accept a PR to fix this.

Not gonna lie, I am quite overwhelmed with the crate. I did try to implement it yesterday. I thought a simple patch like this might do the trick:
diff --git a/impl/src/fmt.rs b/impl/src/fmt.rs
index ea1b518..39b89c2 100644
--- a/impl/src/fmt.rs
+++ b/impl/src/fmt.rs
@@ -53,7 +53,7 @@ impl Display<'_> {
                     }
                     member
                 }
-                'a'..='z' | 'A'..='Z' | '_' => {
+                'a'..='z' | 'A'..='Z' | '_' | '#' => {
                     let ident = take_ident(&mut read);
                     Member::Named(Ident::new(&ident, span))
                 }
@@ -127,7 +127,7 @@ fn take_ident(read: &mut &str) -> String {
     let mut ident = String::new();
     for (i, ch) in read.char_indices() {
         match ch {
-            'a'..='z' | 'A'..='Z' | '0'..='9' | '_' => ident.push(ch),
+            'a'..='z' | 'A'..='Z' | '0'..='9' | '_' | '#' => ident.push(ch),
             _ => {
                 *read = &read[i..];
                 break;

But i get a super weird error that I've never seen before:
thread 'rustc' panicked at '`"r#type"` is not a valid identifier', src\librustc_expand\proc_macro_server.rs:335:13
stack backtrace: ...

Maybe it's internal compiler stuff that I am not aware of, but I thought that r#type is actually a valid identifier. I mean, I can use it inside of structs and it works.
I used this snippet to test it:
#[test]
fn test_reserved_named_escape() {
    #[derive(Debug, Error)]
    #[error("reserved name error: {r#type}")]
    enum Error {
        Invalid {
            r#type: String,
        }
    }

    let r#type = "T".to_owned();
    assert("reserved name error: T", Error::Invalid { r#type });
}


missing files

Please check that a similar bug has not been already filed. If not, fill in the description and title of the bug, keeping the version information below. If possible, please attach the telemetry log (in file C:\Users\mdyks\AppData\Local\Packages\57918Zduka.terminalpp_gf2w6xa3036qy\LocalState\Temp\terminalpp\telemetry/2023-11-29-17-27-01.txt), whose file location has been copied to your clipboard. Thank you!

version:    0.8.4
commit:     6444618c981a737a63039110add5a4e1d282156f
platform:   Windows(native) 64 MSVC 19.28.29914.0 release
build time: 2021-05-12T19:10:37Z

Hi! Is this a duplicate of #40?


        Wrap every API call with this function

        Parameters
        ----------
        ret : int
            return value from API calls
        """
        if ret != 0:
>           raise XGBoostError(_LIB.XGBGetLastError())
E           xgboost.core.XGBoostError: b'value 5 for Parameter verbosity exceed bound [0,3]'

/opt/anaconda3/envs/gpu-test/lib/python3.6/site-packages/xgboost/core.py:178: XGBoostError

Based on the error message, when I reduce the verbosity to 3, it proceeds past this issue and hits with issue https://github.com/dmlc/xgboost/issues/3794.
And when I use the workaround suggested in there it proceeds fine and succeeds successfully.
So, it is wrong for the test here to use 'debug_verbose': 5.
Based on the conversation in the other issue, pulling in @trivialfis to suggest in here!

@ksangeek That's because we can't change the distribution of data, and we don't currently have a solution for that.

@trivialfis Ok, I got that part from the conversation in the original issue.
I opened this to ask if the test case change the debug_verbose to a valid supported value? Or is it something specific to my environment?

@ksangeek Oops, sorry that is a bug.  debug_verbose is not a valid value, see https://xgboost.readthedocs.io/en/latest/parameter.html#general-parameters for the parameter verbosity.

Thank you @trivialfis for a quick response on this!


Password reset allows user to bypass confirmable

In passwords_controller.rb, the following code:
        # ensure that user is confirmed
        @resource.skip_confirmation! if @resource.devise_modules.include?(:confirmable) &&<EMAIL_ADDRESS>
actually sets the confirmed_at property of a resource if the resource has not been confirmed.
This effectively allows the user to bypass email confirmation by resetting their password.
I'd like to remove this line, so that the user IS able to change their password with the reset link but will not be able to log in until they confirm the email.
Thoughts?

Why would you? There is no security issure there. If the user can change the password then he can access his email account and  that means that he is able to confirm the account.

But the email is passed as a parameter for reset; it could be different
than the one used for userid.
On Thu, Mar 31, 2016 at 4:07 PM Carsten<EMAIL_ADDRESS>wrote:

Why would you? There is no security issure there. If the user can change
the password then he can access his email account and that means that he is
able to confirm the account.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/lynndylanhurley/devise_token_auth/issues/590#issuecomment-204104745

Also, the comment seems to communicate the correct intention but the code actually does the opposite.

But in which case the email for password resetting is different than the user id?

Seems like a nonissue from the discussion so far, so I'm closing for now.


tuya temperature and humidity sensors

"ids": {
"modelId": "TS0601",
"manufacturerName": "_TZE200_a8sdabtg"
},
"endpoints": {
"endpointDescriptors": [
{
"endpointId": 1,
"applicationProfileId": 260,
"applicationDeviceId": 770,
"applicationDeviceVersion": 0,
"_reserved1": 1,
"inputClusters": [
1,
1026,
1029,
0
],
"outputClusters": [
25,
10
]
}
],
"endpoints": {
"1": {
"clusters": {
"powerConfiguration": {
"attributes": [
{
"acl": [
"readable",
"reportable"
],
"id": 0,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 32,
"name": "batteryVoltage",
"value": 0,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 33,
"name": "batteryPercentageRemaining",
"value": 0,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 65533,
"name": "clusterRevision",
"value": 1,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
}
]
},
"temperatureMeasurement": {
"attributes": [
{
"acl": [
"readable",
"reportable"
],
"id": 0,
"name": "measuredValue",
"value": 0,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 1,
"name": "minMeasuredValue",
"value": 0,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 2,
"name": "maxMeasuredValue",
"value": 0,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 65533,
"name": "clusterRevision",
"value": 2,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
}
]
},
"relativeHumidity": {
"attributes": [
{
"acl": [
"readable",
"reportable"
],
"id": 0,
"name": "measuredValue",
"value": 0,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 1,
"name": "minMeasuredValue",
"value": 0,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 2,
"name": "maxMeasuredValue",
"value": 0,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
},
{
"acl": [
"readable",
"reportable"
],
"id": 65533,
"name": "clusterRevision",
"value": 2,
"reportingConfiguration": {
"status": "NOT_FOUND",
"direction": "reported"
}
}
]
},
"basic": {
"attributes": [
{
"acl": [
"readable",
"reportable"
],
"id": 0,
"name": "zclVersion",
"value": 3
},
{
"acl": [
"readable",
"reportable"
],
"id": 1,
"name": "appVersion",
"value": 67
},
{
"acl": [
"readable",
"reportable"
],
"id": 2,
"name": "stackVersion",
"value": 0
},
{
"acl": [
"readable",
"reportable"
],
"id": 3,
"name": "hwVersion",
"value": 1
},
{
"acl": [
"readable",
"reportable"
],
"id": 4,
"name": "manufacturerName",
"value": "_TZE200_a8sdabtg"
},
{
"acl": [
"readable",
"reportable"
],
"id": 5,
"name": "modelId",
"value": "TS0601"
},
{
"acl": [
"readable",
"reportable"
],
"id": 6,
"name": "dateCode",
"value": ""
},
{
"acl": [
"readable",
"reportable"
],
"id": 7,
"name": "powerSource",
"value": "battery"
},
{
"acl": [
"readable",
"writable",
"reportable"
],
"id": 65502
},
{
"acl": [
"readable",
"reportable"
],
"id": 65533,
"name": "clusterRevision",
"value": 2
},
{
"acl": [
"readable",
"reportable"
],
"id": 65534,
"name": "attributeReportingStatus",
"value": "PENDING"
},
{
"acl": [
"readable",
"reportable"
],
"id": 65506
},
{
"acl": [
"readable",
"reportable"
],
"id": 65507
}
]
}
},
"bindings": {
"ota": {
"attributes": [
{
"acl": [
"readable"
],
"id": 0
},
{
"acl": [
"readable"
],
"id": 1
},
{
"acl": [
"readable"
],
"id": 2
},
{
"acl": [
"readable"
],
"id": 3
},
{
"acl": [
"readable"
],
"id": 4
},
{
"acl": [
"readable"
],
"id": 5
},
{
"acl": [
"readable"
],
"id": 6
},
{
"acl": [
"readable"
],
"id": 7
},
{
"acl": [
"readable"
],
"id": 8
},
{
"acl": [
"readable"
],
"id": 9
},
{
"acl": [
"readable"
],
"id": 65533,
"name": "clusterRevision",
"value": 1
}
]
},
"time": {
"attributes": [
{
"acl": [
"readable"
],
"id": 65533,
"name": "clusterRevision",
"value": 1
}
]
}
}
}
}
}

Hi @5tal3m8, can you please link an image of the device? How it looks.. or even better yet where you got it. Simple to add but I need to know I use the correct driver group.

Hi @JohanBendz, thanks for following up!
I purchased it here; https://a.aliexpress.com/_mLDUMC2
Let me know if you need anything else!

Hi @JohanBendz
Thanks for all the great work!
Any idea if this sensor is in the next release? otherwise I will just return it and look for another in the supported list.
Thx!

Hello All,
Same ModelId and manufactererName....
But some different input&output clusters found in the "Interview" of my sensor
I don't know what this means ??
Is this a different sensor or will it also work with new code ?
See inteview:
"ids": {
"modelId": "TS0601",
"manufacturerName": "_TZE200_a8sdabtg"
},
"endpoints": {
"ieeeAddress": "a4:c1:38:3e:e8:f4:0c:fc",
"networkAddress": 3714,
"modelId": "TS0601",
"manufacturerName": "_TZE200_a8sdabtg",
"endpointDescriptors": [
{
"status": "SUCCESS",
"nwkAddrOfInterest": 3714,
"_reserved": 38,
"endpointId": 1,
"applicationProfileId": 260,
"applicationDeviceId": 770,
"applicationDeviceVersion": 0,
"_reserved1": 1,
"inputClusters": [
0,
3,
57346,
61184,
60928,
57344,
1,
1026,
1029
],
"outputClusters": [
3,
57346,
61184,
60928,
57344,
1
]
}
],
"deviceType": "enddevice",
"receiveWhenIdle": false,
"swBuildId": "0122052017",
"capabilities": {
"alternatePANCoordinator": false,
"deviceType": false,
"powerSourceMains": false,
"receiveWhenIdle": false,
"security": false,
"allocateAddress": true
},
"extendedEndpointDescriptors": {
"1": {
"clusters": {
"basic": {
"attributes": [
{
"acl": [
"readable"
],
"id": 0,
"name": "zclVersion"
},
{
"acl": [
"readable"
],
"id": 1,
"name": "appVersion"
},
{
"acl": [
"readable"
],
"id": 2,
"name": "stackVersion"
},
{
"acl": [
"readable"
],
"id": 3,
"name": "hwVersion"
},
{
"acl": [
"readable"
],
"id": 4,
"name": "manufacturerName"
},
{
"acl": [
"readable"
],
"id": 5,
"name": "modelId"
},
{
"acl": [
"readable"
],
"id": 7,
"name": "powerSource"
},
{
"acl": [
"readable",
"writable"
],
"id": 18,
"name": "deviceEnabled"
},
{
"acl": [
"readable"
],
"id": 16384,
"name": "swBuildId"
},
{
"acl": [
"readable"
],
"id": 65533,
"name": "clusterRevision"
}
],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
},
"identify": {
"attributes": [
{
"acl": [
"readable",
"writable"
],
"id": 0,
"name": "identifyTime",
"value": 0
},
{
"acl": [
"readable"
],
"id": 65533,
"name": "clusterRevision",
"value": 1
}
],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
},
"powerConfiguration": {
"attributes": [
{
"acl": [
"readable"
],
"id": 0
},
{
"acl": [
"readable"
],
"id": 32,
"name": "batteryVoltage",
"value": 33
},
{
"acl": [
"readable"
],
"id": 33,
"name": "batteryPercentageRemaining",
"value": 200
},
{
"acl": [
"readable"
],
"id": 65533,
"name": "clusterRevision",
"value": 1
}
],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
},
"temperatureMeasurement": {
"attributes": [
{
"acl": [
"readable"
],
"id": 0,
"name": "measuredValue",
"value": 0
},
{
"acl": [
"readable"
],
"id": 1,
"name": "minMeasuredValue",
"value": 0
},
{
"acl": [
"readable"
],
"id": 2,
"name": "maxMeasuredValue",
"value": 600
},
{
"acl": [
"readable",
"writable"
],
"id": 3
},
{
"acl": [
"readable"
],
"id": 65533,
"name": "clusterRevision",
"value": 1
}
],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
},
"relativeHumidity": {
"attributes": [
{
"acl": [
"readable"
],
"id": 0,
"name": "measuredValue",
"value": 0
},
{
"acl": [
"readable"
],
"id": 1,
"name": "minMeasuredValue",
"value": 0
},
{
"acl": [
"readable"
],
"id": 2,
"name": "maxMeasuredValue",
"value": 600
},
{
"acl": [
"readable",
"writable"
],
"id": 3,
"name": "tolerance",
"value": 0
},
{
"acl": [
"readable"
],
"id": 65533,
"name": "clusterRevision",
"value": 1
}
],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
}
},
"bindings": {
"identify": {
"attributes": [
{
"acl": [
"readable",
"writable"
],
"id": 0,
"name": "identifyTime",
"value": 0
},
{
"acl": [
"readable"
],
"id": 65533,
"name": "clusterRevision",
"value": 1
}
],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
},
"powerConfiguration": {
"attributes": [
{
"acl": [
"readable"
],
"id": 0
},
{
"acl": [
"readable"
],
"id": 32,
"name": "batteryVoltage",
"value": 33
},
{
"acl": [
"readable"
],
"id": 33,
"name": "batteryPercentageRemaining",
"value": 200
},
{
"acl": [
"readable"
],
"id": 65533,
"name": "clusterRevision",
"value": 1
}
],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
}
}
}
}
}

Hi @JohanBendz
Thanks for all your useful work on tuya zigbee integration.
Are you missing any information to integrate this device?
I can provide it if you need it, as I have the device at home.
Thank you very much.

Would be great if this one could be added. Have added the "modelId" and "manufacturerName" to a copy of the tuya zigbee app on my homey and it works like a charm, but it would be even better if it is added to the master :) .

I just tried again to add this device. I can add it, but can't do anything with it. Does not provide any temperature or humidity information.
Is there something that can be done to integrate this device? Thank you very much.
Marco

@MarcoDDguez code done but PR be reviewed by @JohanBendz


"Quantity for training a model" is incorrect

The "Quantity for training a model" entry for "Long audio + transcript (beta)" is incorrect. I have just tried to upload 236 utterances using the English (UK) language but I could not begin training as at least 2001 utterances are required even when using "Long audio + transcript (beta)".

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7e6fc39a-3260-dd83-f0e9-9d2b123d0970
Version Independent ID: ad59b5b5-fefa-5c01-751e-f83b74373d31
Content: How to prepare data for Custom Voice - Speech service - Azure Cognitive Services
Content Source: articles/cognitive-services/Speech-Service/how-to-custom-voice-prepare-data.md
Service: cognitive-services
Sub-service: speech-service
GitHub Login: @erhopf
Microsoft Alias: erhopf

@SocMinarch Thank you for your query, our team will look into it and get back to you at the earliest.

@erhopf Hi, could you please check this issue and update the document if necessary? Thanks.

@erhopf Hi Eric, do you have any update for this case? Thanks.

@YutongTie-MSFT - I'm still waiting for feedback from the ENG team. I've reached out to them again today.

#reassign: @v-demjoh

Can you try using the custom neural voice and report back?

@v-demjoh Neural voice is not available to me

Thanks for your dedication to our documentation. At this time looks like this issue is not related to content anymore. The scope of our feedback channel here on GitHub covers specific documentation fixes and because this issue does not relate to documentation, we are closing this issue. #please-close

Thanks for your dedication to our documentation. At this time looks like this issue is not related to content anymore. The scope of our feedback channel here on GitHub covers specific documentation fixes and because this issue does not relate to documentation, we are closing this issue. #please-close


Allow to change the content of the right menu without closing and reopening

Is your feature request related to a problem? Please describe.
When users would like to follow a tutorial they would like to easily test there program in the simulation. To do that in the moment, one have to close the tutorial view and open the simulation view and vice versa to continue with the tutorial.
Describe the solution you'd like
Once any of the right menu views is open, one can switch the content by simply clicking on another right menu button. Closing the right menu view is then only possible if one click the current view button again.
Describe alternatives you've considered
Allow to open the simulation view next to the tutorial view. Problem here is that the program is invisible then.
Additional context
The proposed solution is not only for tutorials but for general use of the right menu views.

Seems to work fine on Chrome, Firefox, IE, Edge, Safari, IOS Safari and Android Chrome.


feat(fix): move builder and workflow rc to tpl direcotry

moved templated rcs of builder and workflow to tpl directory

testing locally


Prevent ESLint errors when running tests on Windows

Running yarn test on Windows displays a stream of linebreak-style ESLint errors due to CRLF linebreaks. I've seen numerous GitHub conversations about this across various projects, including the note on the docs page for the ESLint rule. It seems like a common way to enforce LF linebreaks and prevent linting errors for devs working on Windows is to add a .gitattributes file with * text=auto and disable the linebreak-style rule.

When text is set to "auto", the path is marked for automatic end-of-line conversion. If Git decides that the content is text, its line endings are converted to LF on checkin. When the file has been committed with CRLF, no conversion is done. (source)

Would you accept a PR that will allow the tests to run as expected on Windows?

Sure thing
On Sun, Dec 24, 2017 at 7:25 PM Cory Deppen<EMAIL_ADDRESS>wrote:

Running yarn test on Windows displays a stream of linebreak-style ESLint
errors due to CRLF linebreaks. I've seen numerous GitHub conversations
https://github.com/airbnb/javascript/pull/1224 about this across
various projects, including the note on the docs page for the ESLint rule
http://eslint.org/docs/rules/linebreak-style#using-this-rule-with-version-control-systems.
It seems like a common way to enforce LF linebreaks and prevent linting
errors for devs working on Windows is to add a .gitattributes file with *
text=auto and disable the linebreak-style rule.
When text is set to "auto", the path is marked for automatic end-of-line
conversion. If Git decides that the content is text, its line endings are
converted to LF on checkin. When the file has been committed with CRLF, no
conversion is done. (source
https://git-scm.com/docs/gitattributes#gitattributes-Settostringvalueauto
)
Would you accept a PR that will allow the tests to run as expected on
Windows?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nozzle/react-static/issues/264, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFUmCR5FS2uhgmmRC8BROo0_v8CQ-lwSks5tDwe0gaJpZM4RMEWO
.


Unable to boot

I have Java 1.8.0_181, as well as the other pre-reqs. I get the following error when trying to run gradlew.bat bootRun:
\OAuth2-Java>gradlew.bat bootRun
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

FAILURE: Build failed with an exception.

* What went wrong:
org.slf4j.helpers.NOPLoggerFactory cannot be cast to org.gradle.logging.internal.slf4j.OutputEventListenerBackedLoggerContext

Are there some additional pre-reqs that are needed?

@dben41  - Can you check if you have multiple SLF4J bindings in your class path?
Also, try one of the following samples to see if the error goes away, these samples show similar usecase using Intuit SDK.
https://github.com/IntuitDeveloper/OAuth2-JavaWithSDK
https://github.com/IntuitDeveloper/HelloWorld-Java


chore: add issue number to simp porting notes

Adds issue number (#10618) to porting notes claiming simp can prove this.

Thank you @eric-wieser.
Should I include this one?
https://github.com/leanprover-community/mathlib4/blob/83adb4cfb2c66b50fbf3eca3e520906e17fae921/Mathlib/Topology/Instances/AddCircle.lean#L173-L179


"Shortcut Guide" is missing winkey+v

ℹ Computer information

Windows build number: 1909
PowerToys version: 0.20.0

📝 Provide detailed reproduction steps (if any)

Hold down winkey to see the shortcut guide
Notice that winkey+v is missing

Tracked in #179


Data links are not available.

Trying to download from the provided links on Readme.md is not working. Link is down or expired. Please, provide a valid link for the data.

Could you clarify which README.md you mean?

Hi, sorry for not specifying. The README I refer to is the one at AlphaFold CASP13 's repository. Link below:
https://github.com/deepmind/deepmind-research/blob/master/alphafold_casp13/README.md
There are links there to bit.ly but they look expired.

I tried all of the links and they work fine for me.
However, we host the data on Google Cloud Storage (https://storage.googleapis.com/) and that domain seems to be blocked in China (and maybe some other countries too?). So that might be the reason.
You can test your access using this direct link to the license file: https://storage.googleapis.com/alphafold_casp13_data/LICENSE.txt.

Hi @n4ndoz,
Were you able access the links?
Closing this for now since we could not reproduce it, but feel free to reopen.

Hi! Sorry for the delay, suffered an accident.
I have access now to the data. THank you.
The only issue is that I cannot resolve storage.googleapis.com on curl. But already download at home and "SCPing" files to lab. Thank you a lot.


Broken password prompting with multiple repositories

When VCS needs a password to access a repository, it will ask for it interactively.
Unfortunately, when there are several repositories requiring a password, it will ask for all of them at the same time. Needless to say, this doesn't work ;-) The password entered on the first repository will be used as the username for the second, and so on.
Please change this so that the credentials are asked sequentially.

Duplicate of #23.
You can use --workers 1 as a workaround :P

Aha. This doesn't seem to have made it into the docs ;-)

This doesn't seem to have made it into the docs ;-)

Actually it is documented since #119: https://github.com/dirk-thomas/vcstool/blob/master/README.rst#parallelization-and-stdin

My bad! Thanks for the info Dirk.


Although "Only use Tab or Enter to commit" is off, completions are not committed by obvious next character

🔎 Search Terms
commit
commit intellisense
🕗 Version & Regression Information
VS 17.10.0 P6
⏯ Playground Link
No response
💻 Code
No response
🙁 Actual behavior
This is just super frustrating and has a big impact on productivity.
Completions can be committed by . but not by (:
https://github.com/microsoft/TypeScript/assets/9047283/0d87b98e-7740-4f34-bca5-7acb9381b7c4
Committing by   (space) doesn't work either:
https://github.com/microsoft/TypeScript/assets/9047283/34950471-ad95-4ba0-88eb-b61671283f80
It doesn't work for [ either:
https://github.com/microsoft/TypeScript/assets/9047283/d17ef204-e92b-4119-ba60-b47eaabb7ef4
Option is turned off:

🙂 Expected behavior
Selected completion is committed.
Additional information about the issue
No response

Hello @Peter-Juhasz! Given that this issue is specific to Visual Studio's completion, could you please move this discussion to a new issue in https://developercommunity.visualstudio.com/VisualStudio? Thank you!


getPixelDataFromFragments - Bad Uint8Array initialization

I found a strange behavior in the case of a single fragment and a new Uint8Array is crated as a view of the dicom object byteStream: the new array is misaligned from the source buffer.
In my case the new array is two bytes ahead: fragments[0].dataOffset is 2056, the new array starts at byte 2054 of the byteStream. Length is correct.
I found this behavior using Safari on Mac OS X, Chrome and Firefox on Ubuntu Linux x64, Chrome on Windows 7 x64. Could be a dword alignment? but 2056 is at dword boundaries!
The work around I applied is to comment the if( fragments.lenght === 1) condition.

Can you provide a sample dataset and fix via PR?  Thanks

Attached a sample dataset.
trasversal.3.dcm.zip
I will submit the PR next week.
Thank to you.

I think I may have fixed this in 1.4.3, can you please test?

I apologize for not posting the additional info you requested but my
workload did not allow me.
Unfortunately at the moment I had to pause my projects with cornerstone and
your progress in developing it was so big that I hardly recognize the same
library! I'm stuck with a very old version that I customized for special
purposes so testing a new release is almost impossible to me.
Sorry for not being more helpful
On Fri, May 20, 2016 at 3:02 PM, Chris Hafey<EMAIL_ADDRESS>wrote:

I think I may have fixed this in 1.4.3, can you please test?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/chafey/dicomParser/issues/38#issuecomment-220599477

--

Closing


fix: upgrade trl usage to align with v0.12+

Starting from TRL version v0.12.2, the usage of SFTTrainer has changed so that
some fields such as tokenizer are deprecated in favor of newer fields like
processing_class, while others like max_seq_length are dropped entirely
from being passed directly into SFTTrainer and now must instead be passed in
via the args parameter. This commit resolves that issue by upgrading our
usage to align with how the library expects it to be used going forward.
Signed-off-by: Oleg S<EMAIL_ADDRESS>Fixes #2803
Checklist:

[x] Commit Message Formatting: Commit titles and messages follow guidelines in the
conventional commits.
[ ] Changelog updated with breaking and/or notable changes for the next minor release.
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Functional tests have been added, if necessary.
[ ] E2E Workflow tests have been added, if necessary.

@Mergifyio backport release-v0.22 release-v0.21


Lua errors

[ERROR] addons/justicesystem/lua/autorun/server/main.lua:567: bad argument #1 to 'pairs' (table expected, got nil)

pairs - [C]:-1
func - addons/justicesystem/lua/autorun/server/main.lua:567
unknown - lua/includes/extensions/net.lua:32

Can you give me more information?
What exactly triggered this? Can you retrigger it?

[ERROR] addons/justicesystem/lua/autorun/server/main.lua:568: bad argument #1 to 'pairs' (table expected, got nil)

pairs - [C]:-1
func - addons/justicesystem/lua/autorun/server/main.lua:568
unknown - lua/includes/extensions/net.lua:32

[ERROR] addons/justicesystem/lua/autorun/server/main.lua:198: bad argument #1 to 'pairs' (table expected, got nil)

pairs - [C]:-1
getCrimes - addons/justicesystem/lua/autorun/server/main.lua:198
func - addons/justicesystem/lua/autorun/server/main.lua:710
unknown - lua/includes/extensions/net.lua:32

From what I can tell, you somehow messed up the nets, or another addon is conflicting because of netmessege names.

Don't just post your error btw, otherwise, I'll just close the thread. Tell me what you were doing, and if it happens if you redo it.


tests(element): add a test that fails when finding subelements within ea...

...ch

WIP - this does not yet fix the problem, just shows it.

Should be fixed when #2245 is done.

FYI: in your original example (from the PR), if you replace the protractor-defined locator i.e. by.binding('username') by a webdriver-native locator i.e. by.css('#animals'), then the example will hang for both selenium-webdriver 2.46.1 and lower versions.

Reported reduced case here: https://github.com/SeleniumHQ/selenium/issues/715

Updating this, now that we're using selenium-webdriver 2.47

Is this still an issue with 2.48.2?

Sorry for the delay - yes, this is working now. I'll submit to make sure we're testing for it in the future.

Merged with 586d634bcd306a3226fd4c55bef43155294bad4e


Baichuan2-13B-Chat inference problem

When I use Baichuan2-13B Chat for inference, I use the official method of building a prompt, BAICHUAN_ PROMPT_ FORM="<| human |>{prompt}<| bot |>" or messages=[{"role": "user", "content": prompt}], then use the official build_chat_input using the input function、, and then sent into the generate function, cannot obtain good output, for example, in the following example, how can I solve this problem?

@fengenbao Hi, I can't reproduce your error, because I don't know all your commands, prompts and installation methods.
But, it's ok. As you know, LLM runtime of the ITREX has been rebuilt to this repo: https://github.com/intel/neural-speed
I checked the baichuan output. Please check this PR https://github.com/intel/neural-speed/pull/80 and branch zhenzhong/APIissues.
Please
git clone https://github.com/intel/neural-speed
git checkout zhenzhong/APIissues
Three commands and you will get results.

pip install -r requirements.txt
python setup.py install
# home/model/Baichuan2-13B-Chat/  is a local baichuan path
python scripts/run.py /home/model/Baichuan2-13B-Chat/ --weight_dtype int4 -p "你好"

The output looks good.

Hi. It's been a long time since I heard from you.
I closed this issue. If you have more questions, please feel free to ask.


Update Orature repository urls & Rename env vars

Update link to resource container (Orature) repository
Changes to env var name for better comprehension

This change is

fetcher-pipeline/gl_repo_urls.txt, line 9 at r1 (raw file):
Previously, mXaln (Maxim) wrote…
I'm hesitant about this. I think WA-Catalog has approved and published resources, when WycliffeAssociates is in active editing. I might be wrong. Maybe @purpleguitar knows better about this. And I think we should use resources from one organization, not from different.

I would say we may have it now for the purpose of testing, which we can change later on when WACS has such content.


refactor

With pull requests:

Open your pull request against main
Your pull request should have no more than two commits, if not you should squash them.
You should pass all tests by go test -v ./... at the project root path in local.
It should pass all tests in the available continuous integration systems such as GitHub Actions.
You should add/modify tests to cover your proposed code changes.
If your pull request contains a new feature, please document it on the README.

Codecov Report

Merging #105 (d74517a) into main (d6c77bb) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   24.05%   24.05%
=======================================
  Files          15       15
  Lines         636      636
=======================================
  Hits          153      153
  Misses        467      467
  Partials       16       16

Impacted Files
Coverage Δ

internal/core/openapi/dictionary.go
0.00% <0.00%> (ø)

internal/core/openapi/user.go
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.


Pick a date range other then 1st date of the month , bar charts arent highlighted

Walked @clockworked247 on how to reproduce this one.
PIck the date other then 1 date of the month and end date within the month
Actual Result : QnA doc list gets updated correctly , the highlighted count is not seen on the bar charts line.

This occurs when you pick a date range within a single month that doesn't include the 1st of the month.  i.e. 3/10/2014 - 3/15/2014

I think this points to a larger problem which is that values in the month where the criteria start and in the month where the criteria end are being "miscounted/represented". In other words, the shadow counts are not value in the "edge months" when the criteria is not set to whole months on one or both sides of the range.
In @clockworked247's example, 17 questions match the criteria, but there are 72 shadow results drawn in March 2014, thus simply grabbing that bar in the chart and highlighting it would be incorrect.

I hadn't considered this case (i.e. where partial months are manually selected using the date fields), but in general, I think it's marginally OK (from a UX perspective) to not highlight "edge months" where only part of those months is included in the range. This would mean that a range that spans part of one month shows no bars highlighted. As long as the results match the dates in the fields, we'd be OK.
On further thought, it might be nice (as an RFE) to draw the bars for such "edge months" differently, e.g. using a dashed line or pattern fill or some other visual treatment. Let me add that as an RFE.

Added RFE #670.

I think it's OK to close this as WNF.

Since we've agreed that this requires some new UI treatment for selection within a month and that request is tracked as an RFE, I'm closing this bug in favor of #670


Recycle memory when recomputing geo-factors/ add user option for nodes.

This PR enables the GeometricFactors class to calculate geometric factors based on user provided nodes. I also did a minor clean up on the class.
Resolves #1500.

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#1517
@artv3
@tzanio
@camierjs + @v-dobrev
06/07/20
⌛due 06/21/20
⌛due 06/28/20

I think this PR could be used for issue https://github.com/mfem/mfem/issues/1500. I noticed a performance improvement in my application by recycling memory when computing geometric factors.

@tomstitt , I added a few adjustments here to avoid CUDA mallocs when recomputing geometric factors.

@camierjs and @v-dobrev reminder that the reviews for this PR are due this week

@artv3, can you update us on the status of this PR?

@artv3, can you update us on the status of this PR?

I could use some help understanding why ->Recompute() did not update geometric factors as I expected. Is it that the nodes in the geometricfactors class become null or deleted as the application cycles? And we need to use new ones?

Looking at the code, GeometricFactors::AssembleWithNodes ensures that the internal mesh and nodes data members are synchronized, i.e. mesh->GetNodes() == nodes or equivalently mesh == nodes->FESpace()->GetMesh().
GeometricFactors::Recompute() just uses the nodes data member, so if the mesh nodes have been updated it will produce incorrect results.
We can maybe make the assumption that mesh and nodes are synced explicit by adding something like this in the beginning of Recompute():
if (nodes != mesh->GetNodes())
{
   nodes = mesh->GetNodes();
}

maybe even without the if.

Looking at the code, GeometricFactors::AssembleWithNodes ensures that the internal mesh and nodes data members are synchronized, i.e. mesh->GetNodes() == nodes or equivalently mesh == nodes->FESpace()->GetMesh().
GeometricFactors::Recompute() just uses the nodes data member, so if the mesh nodes have been updated it will produce incorrect results.
We can maybe make the assumption that mesh and nodes are synced explicit by adding something like this in the beginning of Recompute():
if (nodes != mesh->GetNodes())
{
   nodes = mesh->GetNodes();
}

maybe even without the if.

Thanks @tzanio , we are trying a few things with Umpire which may make the memory allocations and deletes okay. Will keep the team posted and update this PR as needed.

Merged in next for testing...

We're able to "hide" the mallocs in by telling the Vectors to use the temporary memory pool is this branch: https://github.com/mfem/mfem/blob/feature/tomstitt/temp-mem-type/mesh/mesh.cpp#L10536-L10556 so we might not want to merge this one because it will increase the permanent memory usage

We're able to "hide" the mallocs in GeometricFactors by telling the Vectors to use the temporary memory pool is this branch: https://github.com/mfem/mfem/blob/feature/tomstitt/temp-mem-type/mesh/mesh.cpp#L10536-L10556 so we might not want to merge this one because it will increase the permanent memory usage

Thanks, one additional feature this PR provided is being able to compute geometric factors with a user set of nodes. I'm going to close this PR and re-open a PR once it is ready.

@artv3, let me know when it is safe to delete the branch

We can delete now, I can do that.


Rename RustCodegenServerPlugin to RustServerCodegenPlugin

For consistency with RustClientCodegenPlugin. This is a better name,
since the plugin is named rust-server-codegen.
This commit also contains other drive-by improvements made while working
on #2302.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Can we do the same with the Python one as well if it fits?

@crisidev Done in https://github.com/awslabs/smithy-rs/pull/2306/commits/2d5b6bfbc92031a0dda0d3ac12a6b4bfccb5a578; I've amended the commit message and the PR title / description.


feat: Set default ir to dynamo export

BREAKING CHANGE: Changing default IR from Torchscript to dynamo export
Description
Changing default IR from Torchscript to dynamo export
Type of change

Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My code follows the style guidelines of this project (You can use the linters)
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas and hacks
[ ] I have made corresponding changes to the documentation
[ ] I have added tests to verify my fix or my feature
[ ] New and existing unit tests pass locally with my changes
[ ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@peri044 Bump the version to 2.0 in this PR so its clear this is a breaking change


Non-leader-election for routing table mode

This PR is continuation of #686 - it introduces support for non-leader-election mode when kub-vip is using routing table mode. If both EnableLeaderElection and EnableServicesElection are set to false all kube-vip instances (e.g. in daemonset) will watch for the services and will configure routing table if there is an endpoint that is associated with the node the kube-vip instance is running on.
Additionally introduced basic support for EndpointSlices. To enable use of EndpointSlices, EnableEndpointSlices flag should be set to true.

This is beast mode! Love this!

We will need to get @Cellebyte to move his pr from draft.

We will need to get @Cellebyte to move his pr from draft.

Hey @thebsdbox i would suppose to just merge this one and I would close my Pull Request in favor of this one.

I’ll properly review tomorrow and hopefully cut a release v0.7.0

Ah CI is complaining with a linting problem.

Ah CI is complaining with a linting problem.

Sorry for that! Just pushed a change that should fix that.

is there a plan to update the documentation?

@thebsdbox  I'll try to add something tomorrow. :) Also, @Cellebyte found that logs could be improved, so I will also try to push some changes tomorrow.

No worries, thanks for the amazing contributions!

@thebsdbox I have created PR in the #36 website repo which adds endpointslices to the RBAC manifest. I want to add some info in the docs in the same PR, but could you please point me where should that info go (e.g. what file)?

This doc -> https://github.com/kube-vip/website/blob/main/content/docs/installation/flags.md and the installation section might need looking at.

I think this is ready to merge now?

I think this is ready to merge now?

I think so. I just need to update the docs.

Sweet, Time for the merge 🔨


Project Conversion to netstandard 2.0 and Continuous Integration

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] All new classes have class-level documentation comments, if there are any at all
[ ] Tests for the changes have been added (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Refactoring (no functional changes, no api changes)
[x] Build related changes
[x] CI related changes
[ ] Documentation update
[ ] Other... Please describe:

What is the current behaviour?

What is the new behaviour?

Resolves

#67
#509
#534

Other information

NetworkClientValidated_Tranitions_ReceivingSavedDataState and LoadSavedData_Transitions_ReceivingSavedDataState fails, intentional?


Ability to render from a path input through command line

Given a series of paths, I would like to render the screen-shots. Is there any way to do this outside of the GUI? The important thing is that the paths are not hard-coded and they can be taken as an input.

Apologies for the long delay in responding.
You can render a series of of paths by providing an appropriate array of commands as strings in the config file for the viewer.  See the example at the end of https://github.com/ShapeNet/shapenet-viewer/blob/master/config/batch-render-example.conf .
The load commands can refer to a local filesystem location (i.e. load model <filepath>).


feat: add output to normalize non alphanumeric characters with dashes

As titled.
Added the tests, updated the docs.

Hey thanks for the PR :-)


An error "Error HRESULT E_FALL has been returned from a call to a COM component" when copy and cut.

Environment

Steps to Reproduce

Create a new Python Application
Right click PythonApplication14.py

Choose "Copy" and "Cut" selection

Expected behavior
The file can be copy and cut successfully without any error.
Actual behavior
An error pops up.

Need to try to repro this and verify.

I can't repro in Microsoft Visual Studio Enterprise 2022 (64-bit) - Int Preview Version 17.3.0 Preview 1.0 [32424.78.main]. Please reopen the issue if it is still a problem. Thank you.


build.mill files compiled by Scala 3

This is work in progress to fix https://github.com/com-lihaoyi/mill/issues/3152
Numerous fixes were also needed to com-lihaoyi/mainargs, com-lihaoyi/sourcecode, and com-lihaoyi/mill-moduledefs
With the current state, only 1 example/integration tests is still failing:

integration.feature[plugin-classpath].local

known TODOs:

[x] Discover macro
[x] Applicative macro
[x] Caller macro
[x] Cross.Factory macro
[x] EnclosingClass macro
[x] Task macros
[x] Cacher macro
[x] Moduledefs compiler plugin (override inferrence)
[x] All core Mill modules compile with Scala 3.5.0
[x] Fix Zinc reporter patch linenumbers of build scripts
[x] Check that bytecode analyzers work with Scala 3
[x] cleanup library dependency conflicts
[x] Support new Scala 3 syntax in build.sc files
[x] ~Fix BSP reporter linenumbers for build scripts~ (Zinc reporter forwards to bsp)
[ ] Cleanup compiler warnings for outdated syntax

known incompatibilities:

[ ] can't use ExplicitResultTypes scalafix rule - need to upgrade mill-scalafix
[ ] Cross.scala uses the new quoted type syntax which scalafmt crashes on, (and version is frozen) so skip the file
[ ] skipping Mima currently due to 1000s of errors (perhaps we should generate filters?)
[ ] filtered one flaky test from example.thirdparty[mockito]
[ ] filtered out integration.feature[plugin-classpath] due to third party plugin dep

Thanks @bishabosha ! Lets get your mainargs changes landed, that way we can cut a release and you can test your WIP in CI

+1 for switching over to using directives!

https://github.com/com-lihaoyi/mill/issues/3062

@lihaoyi see https://github.com/com-lihaoyi/mainargs/pull/148

in https://github.com/com-lihaoyi/mill/actions/runs/10418081276/job/28853542122?pr=3369 you can see integration tests like example.tasks[6-workers].local.test passing

Rebased and included the new mill-moduledefs 0.11.0-M1

just recording here that the mockito third party test can be flaky (specifically StubbingLookupListenerCallbackTest .add_listeners_concurrently_sanity_check):
https://github.com/mockito/mockito/blob/1e337ed703ce2b78ce9ea40ff8b8c645f8219cf2/src/test/java/org/mockitousage/debugging/StubbingLookupListenerCallbackTest.java#L177C17-L177C56

Only scala 3 syntax to go

@bishabosha all tests are green???

@lihaoyi I still haven't introduced the scala 3 syntax support, but everything previously there passes. I have explicitly skipped certain tests in TEMP: commit messages - i.e. scalafix, mima, the one flaky mockito test, and the smithy4s plugin

@lihaoyi green CI with scala 3 syntax
Perhaps I will do a round of cleanup for syntax warnings ?

Just looked through the whole PR. Looks great overall. Some thoughts on next steps:
Timing

We want to land this PR as late as possible, as it breaks binary compatibility, and will require us forking off a 0.13.0 branch from 0 .12.0.
@bishabosha is tentatively with us until end oct latest, and we're planning on releasing 0.12.0 in early/mid oct
Thus we should aim to land this PR in late oct, after the Mill 0.12.0 release and before @bishabosha's time with us comes to and end

Rebase/Merging

There will likely be some more merge/rebase conflicts landing in the leadup to 0.12.0: https://github.com/com-lihaoyi/mill/pull/3617, https://github.com/com-lihaoyi/mill/pull/3478, possibly others.
I suspect would make most sense to do one big merge/rebase at the end rather than trying to keep up individually

Remaining Major Issues

The source-code-generation of mirrors for uPickle seems like the biggest hack that remains in this PR. My understanding is that it is because uPickle in Scala 3 does not work well for non-case classes. I see two paths forward here:

Automate this mirror generation as part of the uPickle macro. It seems pretty mechanical code. Even if we can't get it down to zero lines, if we could get it down to 1-2 lines, that would already be a big win
Alternatively, for the types we own (and even for some types we don't) we could convert them all to case classes and bank on https://github.com/scala/improvement-proposals/pull/78 landing soon. In the interim, we could use the existing compiler plugin to bridge the gap until it lands in a Scala 3 release.

We should run through this PR, identify all such 2.13-compatible changes, and land them separately before the breaking Scala 3 changes

you can include even more with -Xsource:3

We should run through this PR, identify all such 2.13-compatible changes, and land them separately before the breaking Scala 3 changes

you can include even more with -Xsource:3

I think -Xsource:3 breaks bin-compat of the produced jars. I tried this before (https://github.com/com-lihaoyi/mill/pull/2557).

@lihaoyi  fix in https://github.com/com-lihaoyi/mill/pull/3369/commits/d7ae5aeddfd9b2bef906496c557a5eda11610b13 depends on releasing a new mill-moduledefs - see https://github.com/com-lihaoyi/mill-moduledefs/pull/18

@bishabosha I noticed that without the line number plugin, runtime line number reporting no longer properly subtracts the lines of from the generated code:
lihaoyi mill$ git rev-parse head
d7ae5aeddfd9b2bef906496c557a5eda11610b13
lihaoyi mill$ git diff
diff --git a/example/javalib/basic/1-simple/build.mill b/example/javalib/basic/1-simple/build.mill
index 3f4e27a8b3..8d870ab632 100644
--- a/example/javalib/basic/1-simple/build.mill
+++ b/example/javalib/basic/1-simple/build.mill
@@ -3,6 +3,7 @@ package build
 import mill._, javalib._

 object `package` extends RootModule with JavaModule {
+  ???
   def ivyDeps = Agg(
     ivy"net.sourceforge.argparse4j:argparse4j:0.9.0",
     ivy"org.apache.commons:commons-text:1.12.0"
lihaoyi mill$ ./mill -i dist.run example/javalib/basic/1-simple -i compile
[2517/2517] dist.run
[61/61] ================================================== compile ======================================================
An unexpected error occurred
Exception in thread "main" scala.NotImplementedError: an implementation is missing
	at scala.Predef$.$qmark$qmark$qmark(Predef.scala:344)
	at build_.package_.<init>(build.mill:23)
	at build_.package_$.<init>(build.mill:40)
	at build_.package_$.<clinit>(build.mill:40)

What do you think we should do here? It seems we have two options: either we fix it in a Scala 3 compiler plugin, or we fix it by mangling the bytecode with ASM. Either seems like it should work

runtime line number reporting no longer properly subtracts the lines of from the generated code

as in the stack trace :/ I hadn't considered that.
When I first tried I did with a plugin and it seemed like positions are less easily mutable than scala 2, but someone taking a fresh look might find its not so complex

@lihaoyi I remembered the original reason I did the zinc reporter changes was due to the fact that Plugins must run after typer, so any type/parse errors would have incorrect numbers.
If its simple enough to update positions via plugin then still we can do it for the purpose of stack traces at runtime.

Do you want to take a crack at it? Having the ZincReporter to fix pre-typer
errors and a compiler plugin to fix post-typer/runtime errors sounds like
it would work. I assume if possible it would be a pretty tiny compiler
plugin (similar to LineNumberPlugin in Scala 2.13)
We just need to make sure that we don't accidentally fix error locations
twice, which should be doable by having the zinc reporter check if the
source file location is in the generatedScriptSources.dest: if it is then
it needs to be fixed, if it isnt then it does not need to be.
On Sat, 12 Oct 2024 at 5:10 PM, Jamie Thompson @.***>
wrote:

@lihaoyi https://github.com/lihaoyi I remembered the original reason I
did the zinc reporter changes was due to the fact that Plugins must run
after typer, so any type/parse errors would have incorrect numbers.
If its simple enough to update positions via plugin then still we can do
it for the purpose of stack traces at runtime.
—
Reply to this email directly, view it on GitHub
https://github.com/com-lihaoyi/mill/pull/3369#issuecomment-2408596254,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE5HBDEORGLWAQK3HFP7YXLZ3E3XDAVCNFSM6AAAAABMOQQYZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGU4TMMRVGQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

doing the new linenumbers now

@lihaoyi in commit https://github.com/bishabosha/mill/commit/84eb0891ed4a285f41d8431aae5a5da6d8afb2bf in another branch, I successfully remap the positions of trees - but it seems the stack trace offset is still incorrect?

@lihaoyi seemed to have got the trick with a two-phase encoding scheme in https://github.com/bishabosha/mill/commit/64446481156710b7861fff5283c4fbcc06f1cd5e
package build
import $meta._
import mill.{Task, Command, RootModule, Cross}, Task.Anon
import $packages._
import $file.foo.Box
import $file.foo.{given Box[Int]}

def inner: Int = ??? // not implemented

object `package` extends RootModule:

  given Cross.ToSegments[DayValue](d => List(d.toString))

  given mainargs.TokensReader.Simple[DayValue] with
    def shortName = "day"
    def read(strs: Seq[String]) =
      try
        Right(DayValue.withName(strs.head))
      catch
        case _: Exception => Left("not a day")

  type DayValue = DayValue.Value
  object DayValue extends Enumeration:
    val Monday, Tuesday, Wednesday, Thursday, Friday, Saturday, Sunday = Value

  object day extends Cross[DayModule](DayValue.values.toSeq)

  def anyDay(myDay: DayValue): Command[Unit] = Task.Command:
    println(s"Today is $myDay")
  end anyDay

  trait DayModule extends Cross.Module[DayValue]:
    def myDay: DayValue = crossValue

    def day(): Command[Unit] = Task.Command:
      println(s"Today is $myDay")
    end day
  end DayModule

  def someTopLevelCommand(): Command[Unit] = Task.Command:
    println(s"Hello, world! ${summon[Box[Int]]} $inner")
  end someTopLevelCommand

end `package`

millb -i someTopLevelCommand
[mill-build/build.mill-57/61] compile
[mill-build/build.mill-57] [info] compiling 1 Scala source to /Users/jamie/Workspace/mill-repo/integration/feature/scala-3-syntax/resources/out/mill-build/mill-build/compile.dest/classes ...
[mill-build/build.mill-57] [info] done compiling
[build.mill-57/61] compile
[build.mill-57] [info] compiling 3 Scala sources to /Users/jamie/Workspace/mill-repo/integration/feature/scala-3-syntax/resources/out/mill-build/compile.dest/classes ...
[build.mill-57] [info] -- /Users/jamie/Workspace/mill-repo/integration/feature/scala-3-syntax/resources/build.mill:8:18
[build.mill-57] [info] 8 │def inner: Int = ??? // not implemented
[build.mill-57] [info]   │                 ^^^
[build.mill-57] [info]   │moved position to [/Users/jamie/Workspace/mill-repo/integration/feature/scala-3-syntax/resources/build.mill,[319..322]](/Users/jamie/Workspace/mill-repo/integration/feature/scala-3-syntax/resources/out/mill-build/generateScriptSources.dest/build_/build.mill%319L8)
[build.mill-57] [info] -- /Users/jamie/Workspace/mill-repo/integration/feature/scala-3-syntax/resources/build.mill:8:18
[build.mill-57] [info] 8 │def inner: Int = ??? // not implemented
[build.mill-57] [info]   │                 ^^^
[build.mill-57] [info]   │Adjusted tree is now [build.mill:14,[319..322]]
[build.mill-57] [info] done compiling
[1/1] =========================================== someTopLevelCommand ========================================= 8s
1 tasks failed
someTopLevelCommand scala.NotImplementedError: an implementation is missing
    scala.Predef$.$qmark$qmark$qmark(Predef.scala:344)
    build_.build$package$.inner(build.mill:8)
    build_.package_.someTopLevelCommand$$anonfun$1$$anonfun$1(build.mill:42)
    build_.package_.someTopLevelCommand$$anonfun$1$$anonfun$adapted$1(build.mill:42)

Edit: on further inspection, the dotty backend phase is hardcoded to compute line numbers by looking at the offset of the position in the source file of the current compilation unit, not the source file of the position - so updating positions will not fix this
one very big hack could be to adjust the position so it is whatever the position of the start line of the current file is, but then reporter would be broken :)

@bishabosha I think that sounds reasonable, backend-specific limitations dealt with via backend-specific hacks.
One concern would be the source positions in non-backend outputs: things like sourcecode.Line calls, TASTY or SemanticDB. Could you try doing a println(sourcecode.Line()) and see what that does with your hack?

One concern would be the source positions in non-backend outputs: things like sourcecode.Line calls, TASTY or SemanticDB. Could you try doing a println(sourcecode.Line()) and see what that does with your hack?

All of these things are generated at type checking, so they will be the incorrect version

@lihaoyi sourcecode.Line() macro is implemented as
def lineImpl(using Quotes): Expr[sourcecode.Line] = {
    val line = quotes.reflect.Position.ofMacroExpansion.startLine + 1
    '{new sourcecode.Line(${Expr(line)})}
  }

there's no way to intercept that

@bishabosha got it. Could you open a discussion thread on https://github.com/scala/scala3 with your findings so far? If it turns out to be impossible to implement line-number/position fixing 100% correctly with Scala 3, then we don't have much of a choice, but we should make sure we have a discussion about it so that the upstream folks have a chance to add support for this use case in future

So an ASM rewrite could be done the same-time/after methodCodeHashSignatures?
this would still mean semanticdb, tasty will be wrong

My other solution: patch ASAP in compiler the ability to trust positions in the code

so the compiler backend fix was merged

@lihaoyi it seems like Scala 3 really doesn't like the task invocation syntax () in a lot of cases, perhaps it would be worth an  alternative like .eval ?

@bishabosha am I correct to say that single () style syntax is fine, and the problem is mostly with double ()() style syntax? I think that's something I want to find a way around anyway, so even if this turns out to be a wontfix upstream we probably want to find another syntax locally, but the single () for the common cases should probably remain

Yeah I don't think there has been a problem with a single apply

@lihaoyi I'm also not sure why there is a difference in the integration.invalidation[codesig-subfolder] test - (any change to a single build file compiles all build files) - where is the logic that decides this based on codesig? or perhaps its a difference in how Scala 3 emits Zinc API

@bishabosha for integration.invalidation[codesig-subfolder], let's just skip that for the moment. I expect that to change when https://github.com/sbt/zinc/pull/1462 lands, which is likely related to the differences in compilation issues. The "who is recompiled" is 100% on zinc, and will change when that linked PR lands
Not sure about the test-docs stuff. Guessing it's some trivial bug in the doc-generation pipeline as part of the scala3 changes. I'd say it's not super critical for you to look into it, since it's something anyone should be able to debug later if necessary

let's just skip that for the moment.

Or just comment out the "number of files being recompiled" asserts, the "task hashes are properly invalidated" asserts are still useful (you didn't mention them failing so I assume they still work?)

@lihaoyi is there any updates to the plan for merging this post 0.12.0?

@bishabosha let's hold the PR open for now, going forward I can take over responsibilities for keeping the PR up to date so you don't need to maintain it forever.
I don't know exactly how much development we'll see in 0.12.x yet, so not sure when the best time to break bincompat in main will be, but I expect there'll be some short-term follow up from the 0.12.0 release.

Keeping the PR open and occasionally merging main into it would be isomorphic to merging it, cutting a 0.12.x release branch, sending PRs to the release branch and then doing batch-merges into main.

Either of those options would probably be less tedious than having to backport every PR if 0.12.x is still under active development

But keeping the PR open and updated is probably going to be less confusing than cutting/targeting 0.12.x and batch-merging into main

So for now I think it makes the most sense to keep the PR open and periodically merge main into it until we're ready to break bincompat. I can do the work of keeping it up to date with main going forward

Seems that OS-Lib 0.11.4-M2 is causing an unreasonable compile time slowdown in Scala 3 so sticking with 0.11.3 for now

merged in latest main and got most tests passing; there are still some stragglers but nothing blocking.
The main thing still missing is proper support for corrected line-numbers and file-names. This kinda-sorta works in certain cases and not others, e.g. sourcecode.Line and sourcecode.File gives the wrong values still

@lihaoyi maybe you can mine some stuff from https://github.com/bishabosha/mill/tree/scala3-build-sc-reintroduce-linenumbers and https://github.com/bishabosha/mill/tree/scala3-build-sc-reintroduce-linenumbers-with-dotc-patch

Seems like some of the new ./mill -w 'integration.invalidation[codesig-subfolder].fork.test' mill.integration.CodeSigSubfolderTests.simple tests are failing on Scala 3. Probably just need to adjust some of the codesig heuristics we added in https://github.com/com-lihaoyi/mill/pull/4116 to be compatible with Scala 3

Seems like some lazy val initialization code in the <clinit> static initializer changes when you rename lazy vals in Scala 3

Seems like the Scala 3.6.2 upgrade is causing new issues, may be worth punting on that for now and just getting onto 3.5.x first

Somehow it is this line that is causing the bootstrap compile to hang
--- a/main/codesig/src/ReachabilityAnalysis.scala
+++ b/main/codesig/src/ReachabilityAnalysis.scala
@@ -91,7 +91,7 @@ class CallGraphAnalysis(
     case None => ujson.Obj()
   }

-  logger.mandatoryLog(spanningInvalidationTree)
+  //logger.mandatoryLog(spanningInvalidationTree)
 }

Looks like bootstrapping on Scala 3.6.2 works again after optimizing def breadthFirst a bit. Not sure why it wasn't causing problems before, and why it started causing problems now, but optimizing the queue management in the BFS seems to unblock most of the CI jobs


Breaking change in v1.17.0 when using to Kafka + TLS

From: https://github.com/jaegertracing/jaeger/pull/1838#discussion_r385020296, decided to create a separate issue to track this and decide what to do.
The PR #1838 introduced a breaking change: previously, there was no --kafka.consumer.tls option (or producer), and TLS config would be used on whether the getTLS() function returned an error or not. Now, even if all the parameters are set, the collector/ingester won't be using TLS unless a new option is added to the command line, --kafka.consumer.tls.enabled (or the one marked as deprecated but that never existed: --kafka.consumer.tls).
For example, we had this in the jaeger-operator before, when auto-provisioning a Kafka cluster:
      --kafka.producer.authentication=tls
      --kafka.producer.brokers=auto-provision-kafka-kafka-bootstrap.default.svc.cluster.local:9093
      --kafka.producer.tls.ca=/var/run/secrets/auto-provision-kafka-cluster-ca/ca.crt
      --kafka.producer.tls.cert=/var/run/secrets/auto-provision-kafka/user.crt
      --kafka.producer.tls.key=/var/run/secrets/auto-provision-kafka/user.key

It now requires the new property to be added, otherwise, the collector/ingester will crash with the following error:
{"level":"fatal","ts":1582796332.9417691,"caller":"collector/main.go:91","msg":"Failed to init storage factory","error":"kafka: client has run out of available brokers to talk to (Is your cluster reachable?)","stacktrace":"main.main.func1\n\t/home/travis/gopath/src/github.com/jaegertracing/jaeger/cmd/collector/main.go:91\ngithub.com/jaegertracing/jaeger/vendor/github.com/spf13/cobra.(*Command).execute\n\t/home/travis/gopath/src/github.com/jaegertracing/jaeger/vendor/github.com/spf13/cobra/command.go:698\ngithub.com/jaegertracing/jaeger/vendor/github.com/spf13/cobra.(*Command).ExecuteC\n\t/home/travis/gopath/src/github.com/jaegertracing/jaeger/vendor/github.com/spf13/cobra/command.go:783\ngithub.com/jaegertracing/jaeger/vendor/github.com/spf13/cobra.(*Command).Execute\n\t/home/travis/gopath/src/github.com/jaegertracing/jaeger/vendor/github.com/spf13/cobra/command.go:736\nmain.main\n\t/home/travis/gopath/src/github.com/jaegertracing/jaeger/cmd/collector/main.go:183\nruntime.main\n\t/home/travis/.gimme/versions/go1.13.5.linux.amd64/src/runtime/proc.go:203"}

For completeness, here's the set of options for v1.17.0 that works in the same scenario:
      --kafka.producer.authentication=tls
      --kafka.producer.brokers=auto-provision-kafka-kafka-bootstrap.default.svc.cluster.local:9093
      --kafka.producer.tls.enabled=true
      --kafka.producer.tls.ca=/var/run/secrets/auto-provision-kafka-cluster-ca/ca.crt
      --kafka.producer.tls.cert=/var/run/secrets/auto-provision-kafka/user.crt
      --kafka.producer.tls.key=/var/run/secrets/auto-provision-kafka/user.key

Hm, I do recall commenting on the pr about that. Because we already have a selector for auth scheme, specifying tls.enabled is redundant.

I am working on the fix

Yes @yurishkuro asked about this, but it wasn't applied to the PR https://github.com/jaegertracing/jaeger/pull/1838/files#r338868216.
I think we cannot revert as some might already adopted the change - like jaeger operator.


MessageFactory Suggested Messages creates empty Text bubble

I wrote this code to print out a message followed by suggested actions:
`context.Reply("Get the best food here! I mean best cafeteria food... Ok let's say it's eatable. You can do the following: 'Order food', 'Add Allergies'");
        // Create the activity and add suggested actions.
        var suggestedTopics = MessageFactory.SuggestedActions(
            new CardAction[] {
                new CardAction(type: "imBack", text: "add allergy", title: "add allergy"),
                new CardAction(type: "imBack", text: "order food", title: "order food"),
                new CardAction(type: "imBack", text: "help", title: "help")
            }
        );

        // Send the activity as a reply to the user.
        context.Reply(suggestedTopics);

`
As a result, I get the following response:

The partner I am working with faced the same issue.
The workaround we are using is to add title (which I'm not sure if documented) :
var activity = MessageFactory.SuggestedActions(new CardAction[] {
new CardAction(type: "imBack", text: "red", title: "red")
}, "Select color");
But ideally we don't want to be forced to add any title at all.

@cleemullins I'll take a look at this later and see if I can see what's happening. If I can then I'll submit a fix.

@garypretty it's likely that we're always including an empty string for the text of the message when sending suggested actions. I believe you need to not include a text field at all if you just want the actions to show up without an associated message.

Yes, that would be my suspicion. I’ll hopefully get a chance to take a look later.
Gary
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: Steven Ickman<EMAIL_ADDRESS>Sent: Tuesday, February 27, 2018 6:53:07 PM
To: Microsoft/botbuilder-dotnet
Cc: Gary Pretty; Mention
Subject: Re: [Microsoft/botbuilder-dotnet] MessageFactory Suggested Messages creates empty Text bubble (#200)
@garyprettyhttps://github.com/garypretty it's likely that we're always including an empty string for the text of the message when sending suggested actions. I believe you need to not include a text field at all if you just want the actions to show up without an associated message.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/botbuilder-dotnet/issues/200#issuecomment-368985819, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADuE6aKDEuh8HFPrTw05bmf_oY0h5T7Nks5tZE8TgaJpZM4SU5sl.

I was looking at the code and the issue is this line here. We shouldn't be assigning an empty string for either this or the line below it.  We need those fields to not be filled in if they're not specified.


update README; activate tox for cpy3.5 (trying ..)

Current coverage is 96.60% (diff: 100%)

Merging #84 into master will not change coverage

@@             master        #84   diff @@
==========================================
  Files             9          9
  Lines           619        619
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            598        598
  Misses           21         21
  Partials          0          0

Powered by Codecov. Last update 85eca62...60b9386


Add EigenGate.equal_up_to_global_phase

@dabacon ping

@Strilanc ping

Automerge cancelled: Merging is blocked (I don't understand why).


Godot-rust is hard depending on fragile parts of the Godot API and panicking if anything changes.

Ideally, the FFI would only load methods which are in use, and panic if the hash of the used APIs change.
However, currently, Godot rust is loading all functions exported by the Godot API upfront, including deprecated and experimental methods (which by nature are subject to change).
In a particular example, Godot 4.2 has a few changes pending which could change method hashes on rarely used APIs. Sure, it would be better if they didn't, but it could conceivably happen.
And more worryingly, we might have future changes planned which may change some APIs marked as experimental (which in general should not be used if you want forward compatibility).
However, because ClassSceneMethodTable::load loads all methods defined in the JSON, used or not, it guarantees that any slight change in the Godot API even to a rarely-used, experimental or deprecated function, will break every godot-rust extension.
A good start on improving this might be to put experimental or deprecated APIs behind a flag, so at least those are not exported except for extensions that need them.
Beyond that, perhaps if there is some way to memoize APIs used (similar to how a C++ function-level static member is initialized exactly once on first call).
I'm not sure exactly, but I'm just filing this because it does seem like it could be a continuing point of frustration for deploying Godot rust plugins into the long term.
I know Godot 4.0 and Godot 4.1 had explicit GDExtension compatibility breakage because GDExt was new. But it is not intended to break the whole API globally, and ideally almost all APIs will remain compatible where possible.
I'm not really a contributor on the Godot GDExtension team, but I just ran into this and I am responsible for some of the APIs that might be subject to change, which are breaking all of my rust plugins, so I want to flag this issue and start the discussion on how to improve this situation, be it on Godot's side or Godot-rust's side.

Sorry, I filed this on the wrong repository.
Migrated to https://github.com/godot-rust/gdext/issues/423


docs(pdk) Make doc for kong.Response.Exit()

The empty line above the function kong.Response.Exit() appears to be unintentionally causing godoc to ignore the documentation for the function. Removing the empty line causes godoc to generate a doc from the comment that is there.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Vaughn Butt seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@vaughnbuttiw Thanks for the contribution! Would you be able to sign the CLA for pushing this PR forward?

it looks like the PR is empty; maybe the changes were already added! thank you for your contribution!


minimize createStore function

Now code after babeling seems like
typeof update === "function" ? _extends({}, state, update(state)) : _extends({}, state, update);
After PR it a little bit less code
_extends({}, state, typeof update === "function" ? update(state) : update);

@dumistoklus before I can accept this, please:

Add this change to the CHANGELOG file
Bump the version on package.json to 4.15.1

Thanks!

Thanks @dumistoklus 💯


Feature: Automatic release based on version bump

Issue number
Relevant issue number

Resolves #

Please check the following

[ ] Do the tests still pass? (see Run the Tests)
[ ] Is the code formatted properly? (see Linting (Formatting))
For New Features:

[ ] Have tests been added to cover any new features or fixes?
[ ] Has the documentation been updated accordingly?

Please describe additional details for testing this change

I'm going rogue, merging it.


LVL5 feature: migrate data if PVC gets full

This is a placeholder issue for the LVL5 feature to be implemented.

monitor the % free of the PVC of the user and pod
when running out of space:

notify user
extend PVC
migrate data

We have an ansible playbook for this already in the internal DH repo

Migration of data to new PVC was implemented, but we will try to use PVC expanding which is available with the newer versions of Kubernetes and OpenShift.
@HumairAK


AG Grid Floating filter clear button

Hi,
can we have the clear button outside the drop meun?
something like just input and a button to clear for react?
and also i cannot find a document for react to custamize the floating filter.
Thanks

Hi,
The docs for React are not there yet, you are right, this is still supported though, al you need to do is to register your component as usual in the framework property, and add the methods specified in the docs.
If you want to customise the button outside of the drop menu, you will have to create a custom filter, and possible a custom header (if you want to put the button in the header)

Hi,
thank you for your reply, what i did below..
i add this button inside the render func

and the clear func
clearFilters() {
this.grid.api.setFilterModel(null);
this.grid.api.onFilterChanged();
}
now its working fine. :)

@re5ive  can you please provide the full code?


build error when building the pixsfm package:

Hey, I encountered this build error as below. It looks like from ceres library. I installed ceres-solver from colmap official website https://colmap.github.io/install.html#build-from-source
Any suggestions? Thanks!
Error message:
pixsfm/util/src/memory.h:59:39: error: ‘const class ceres::Problem’ has no member named ‘ParameterBlockLocalSize’; did you mean ‘ParameterBlockSize’?
59 |         num_active_params += problem->ParameterBlockLocalSize(param_block);

Hi, thanks for reporting this. We still use the deprecated LocalParameterization API of Ceres, which was removed recently from master (https://github.com/ceres-solver/ceres-solver/commit/68c53bb39552cd4abfd6381df08638285f7386b3). For now a simple fix is to install Ceres v2.1.0 via git checkout 2.1.0.
@Phil26AT  We should update pixsfm as https://github.com/colmap/colmap/commit/30521f19de45c1cb2df8809728e780bf95fc8836.

Thanks for the quick response! It built successfully after switching to 2.1.0.

Tentative fix in PR https://github.com/cvg/pixel-perfect-sfm/pull/68 in case Ceres >= 2.2.0 is required.


ModuleNotFoundError: No module named 'spidev'

Hi,
I have Dell inspiron 5505.
When I try to run your code it give me error with ModuleNotFoundError: No module named 'spidev'
sudo python3 run_538d.py
Traceback (most recent call last):
 File "/home/shahi/goodix-fp-dump/run_538d.py", line 1, in <module>
   from driver_53xd import main
 File "/home/shahi/goodix-fp-dump/driver_53xd.py", line 9, in <module>
   from goodix import FLAGS_TRANSPORT_LAYER_SECURITY_DATA, Device
 File "/home/shahi/goodix-fp-dump/goodix.py", line 13, in <module>
   from protocol import Protocol, USBProtocol
 File "/home/shahi/goodix-fp-dump/protocol.py", line 13, in <module>
   from spidev import SpiDev
ModuleNotFoundError: No module named 'spidev'

Well for now the driver is just able to read an image from the sensor.
But there is still much work to do to be able to enroll fingerprints.

just do
sudo pip3 install spidev

that worked for me

I have this after installing sudo pip3 install spidev:
Traceback (most recent call last):
  File "run_5110.py", line 1, in <module>
    from driver_51x0 import main
  File "/home/steq/Загрузки/goodix-fp-dump/driver_51x0.py", line 9, in <module>
    from goodix import FLAGS_TRANSPORT_LAYER_SECURITY, Device
  File "/home/steq/Загрузки/goodix-fp-dump/goodix.py", line 13, in <module>
    from protocol import Protocol, USBProtocol
  File "/home/steq/Загрузки/goodix-fp-dump/protocol.py", line 14, in <module>
    from periphery import CdevGPIO
ModuleNotFoundError: No module named 'periphery'

$ sudo pip3 install periphery
ERROR: Could not find a version that satisfies the requirement periphery (from versions: none)
ERROR: No matching distribution found for periphery

I have this after installing sudo pip3 install spidev:
Traceback (most recent call last):
  File "run_5110.py", line 1, in <module>
    from driver_51x0 import main
  File "/home/steq/Загрузки/goodix-fp-dump/driver_51x0.py", line 9, in <module>
    from goodix import FLAGS_TRANSPORT_LAYER_SECURITY, Device
  File "/home/steq/Загрузки/goodix-fp-dump/goodix.py", line 13, in <module>
    from protocol import Protocol, USBProtocol
  File "/home/steq/Загрузки/goodix-fp-dump/protocol.py", line 14, in <module>
    from periphery import CdevGPIO
ModuleNotFoundError: No module named 'periphery'

$ sudo pip3 install periphery
ERROR: Could not find a version that satisfies the requirement periphery (from versions: none)
ERROR: No matching distribution found for periphery

if you are using archlinux: sudo pacman -S python-periphery
if you are using other distribution search how to install python-periphery on your distribution

Closing because of inactivity


Make the router / server into an echo

As part of moving away from vk.router and vk.logger, the router is being replaced by echo and the logger by rs/zerolog.

Echo server implementation moved to e2core


k8s: Use slim Node in LocalNode Resource and K8s watchers

We were performing unnecessary conversions from corev1.Node to slim_corev1.Node.
Only blocker for using slim_corev1.Node was the missing ProviderID.

/test

/test

/test

@joamaki None of the e2e tests were triggered for your last test command. Is that expected? Would we need to close and reopen the PR so that all the tests are forcefully triggered?

@joamaki None of the e2e tests were triggered for your last test command. Is that expected? Would we need to close and reopen the PR so that all the tests are forcefully triggered?

Huh, that's odd. I'll rebase and try again and if that doesn't do it, I'll close and reopen.


[stable/postgresql]: auto features for hardened OpenShift clusters

What this PR does / why we need it:
Further OpenShift support (support for security hardeneded clusters)
[postgresql]: auto features for hardened OpenShift clusters, where scc can have different uid ranges; this commit adds options to skip setting runAsUser and try to autodetermine at init
The existing defaults are kept and everything should run as it did till now, unless these new params are enabled
volumePermissions.securityContext.runAsUser="auto",securityContext.enabled=false,shmVolume.chmod.enabled=false
Special notes for your reviewer:
@desaintmartin @sameersbn
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

@desaintmartin @sameersbn - Please help with a review on this one.

/lgtm

fixes #19921


map reduce less frequently

Is it possible to have an option to periodically (on a configurable period) to run the map reduce instead of running it on every document save?

interesting idea, I started some changes on project to make it possible, provably push something this week :)

awesome, looking forward to it! thanks!

@wilkerlucio is this done?

@yordis sorry, I've not being working on this project for quite a while so I'm not sure
I see this commit here: https://github.com/wilkerlucio/mongoid_taggable/commit/fa74e02e7a01a38ddaab4380c35e3a22f5ff458a
which seems an improvement, maybe @astjohn or @calebclark are more able to answer that for you

@wilkerlucio will you be active on this. I don't want to re-write the same problem solution and this seems to be very good but I dont want to use something that you don't want to maintain at least talking PR

@yordis nope, I'm not active on this project anymore, a few years ago I added other people as collaborators (the fellows that I mentioned before) and they did some work then, but its also up to then.
I can still get pull requests, but if you really plan to do a lot of work I would suggest you to just rewrite, this library is pretty small after all ;)


rustc: fix build on darwin

Motivation for this change
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

The OS is identified as "10.4" rather than "osx". This commit removes
the 'rt' build script's hard coding of the "osx" suffix when building on
darwin since the cmake configuration falls back to building a 10.4
compatible libclang_rt.
We also defuse a failing test involving how the system responds to unsetting the HOME environment variable as this is the only failing test on darwin with nixpkgs rust-1.11..0.

Thanks!

@Mic92 Did you notice that 1.12.0 is already out?