new year.  new problems.  copyright locking on file creation.

we don't want to automatically pick the current copyright date if the file already exists from a previous year.
so query the export location.  if the file exists, use that date instead.  make it customizable configurable, etc.

this is the first time unilang has been intentionally undeterministic in regards to time.
and this is the first time we need to know the previous outputted state, when deciding the new outputted state.
Can we look at the timestamps on the scratch space files?  no, unix has access/modify/change time stamps, and they all change.  There is a birth.. but mine are empty?
what about looking at the exported repo file time stamps.  same thing.
what about getting the timstamps from the exported repos version control.
This would work, but may be a little more involved than other solutions.
how about we just parse the previous output file for the date (whether scratch space or exported repo)
too risky to parse.  regex unreliable.  too much variability in output format.
We could store the date as a unilang export file, those could be checked in the scratch space.
Yes, we will do this for now.  Ideally, I want to make the entire unilang structure a serializable output file,  so we have a consistent model for past export states.
For now, we can do something simple like, exported_file_name.date  and that can have the date that unilang can check later when deciding the date.

its kind of a bummer in that we have extra .date files floating around, but I think its fine.
We aren't created the files everytime, but we are checking for their existence


POSTing to a GET endpoint may trigger an unexpected redirect when another rule also matches the url

I have route for /foo/<path:bla>/ and one for /foo/<xyz>/foobar. The latter is more specific and thus the first rule only matches if the second rule did not match.
However, when sending a POST request to the second url I get a slash-adding redirect triggered by the first rule instead of the expected 405 error.
Demo: https://gist.github.com/ThiefMaster/5806003

The testcase behaves correctly now.


In inter frame, only write intra mode if block is intra

While looking at #189, I found that inter blocks in inter frames are
still writing an intra mode.  This doesn't get tripped yet as we're
only writing intra frames, but it will soon enough.

Oops, there's more screwup there.  Let me look at this harder.

Can you squash? I can do it too but want to make sure I get the right thing.


Using gninatypes with gninagrid

Hello,
Can you please enable using gninatypes as a file type in gninagrid?

Eh, the way the code is written it needs an actual molecular data file.  Since you can't generate a gninatypes file without a molecular data file, I don't see the point.

In affinity model using general set, you have some ligands denoted as following:
1n5r_ligand3_6.gninatypes
I am not sure what is the source of that gninatype (it is different from 1n5r_ligand_6.gninatypes). It is also supplied as an input in the types file you used in training.

I am aware of these files. I am talking about specific case here:
diff 1n5r_ligand3_0.gninatypes 1n5r_ligand_0.gninatypes
Binary files 1n5r_ligand3_0.gninatypes and 1n5r_ligand_0.gninatypes differ
What is the difference in the source of these particular two ligands.

1n5r_ligand_0.gninatypes is the first pose from 1n5r_docked.sdf.gz
1n5r_ligand3_0.gninatypes is the first pose from 1n5r_docked_min_cnn3.sdf.gz
The gninatypes files are simple the x,y,z and atom types.  You can use od to see the contents.


Load and save models

main.py needs a way to save a trained model and then reload model method for recreating deepforest instances. test should confirm that prediction before and after should yield the same results.
@dingyif if you are interested, this seems like a good place to help. No pressure.

Definitely, I will take a look at it.

Hold off here for a couple days. I'm playing with integrating the trainer into pytorch-lightning to gain access to these kind of convenience structures and logging.

Okay https://github.com/weecology/DeepForest-pytorch/commit/5b371f6084ac58fb7f42c301fa134583bb2c73f7 , makes the main module a pytorch-lightning object. deepforest.save() and deepforest.load() should look like something here https://pytorch-lightning.readthedocs.io/en/stable/weights_loading.html
The load saved model under init
        if saved_model:
            utilities.load_saved_model(saved_model)

probably is now not that logical and could be removed. Probably better to load the entire pytorch-lightning module and all of its functionality.
Inching towards first stable version. I'm working on a couple callbacks and will retrain the deepforest release model.

https://pytorch-lightning.readthedocs.io/en/0.7.0/weights_loading.html
Is this something we should implement?

I was writing the test case for the new method I created.

For the m function  why we're using m.model = model.load_backbone() instead of m.create_model() since you already create m.create_model() method in deepforest module.
Do you have problems with the predict_tile method?  It feels for me, there's no prediction result for that one.

Those two questions are related! Because we have no release model yet, the random model is just randomly initialized weights. So it happens to not predict any trees in that data, so the test fails. Once we have a release model, don't need to bother with model.load_backbone(), we will have .use_release() method just like in the other package. I have models running right now, but they aren't quite right.

something is wrong with hyperparameters. When we go to 0.2.0 there will be a release model to use for all tests. Right now it is a bit weird, applying the pretrained COCO model from pytorch vision on tree images from the sample data. Its just a workaround.
For loading and saving I tried https://github.com/weecology/DeepForest_Model/blob/c91989748ed83b02ab44ce6fbb6cadb819028d59/train.py#L39
not pretty, but gets it done for the moment.

Great! I will change that m.create_model() back to m.model = model.load_backbone() right now.
Do you want to integrate the method created related to this issue? You can just use m.save_model(path) to save the model_checkpoint.
Sorry about the late commit. It was really a long week.


Transform VS Code extension to Language Server Protocol

The reason we switch our extension to LSP is we want to unify the experience of VS Code extension and Composer. Making the implementation through LSP will reduce the work of adding new language features. Moreover using LSP will help improve the performance.

Can you detail this issue with 1 Context, 2 Issue, 3 Solution


[Snyk] Security upgrade io.swagger.core.v3:swagger-jaxrs2 from 2.1.4 to 2.2.7

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `maven` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

src/server-am/pom.xml

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Upgrade
Breaking Change
Exploit Maturity

616/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 5.9
Denial of Service (DoS) SNYK-JAVA-COMFASTERXMLJACKSONCORE-3038426
io.swagger.core.v3:swagger-jaxrs2:  2.1.4 -> 2.2.7
No
Proof of Concept

506/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 3.7
Stack-based Buffer Overflow SNYK-JAVA-ORGYAML-3016888
io.swagger.core.v3:swagger-jaxrs2:  2.1.4 -> 2.2.7
No
Proof of Concept

471/1000  Why? Recently disclosed, Has a fix available, CVSS 3.7
Stack-based Buffer Overflow SNYK-JAVA-ORGYAML-3113851
io.swagger.core.v3:swagger-jaxrs2:  2.1.4 -> 2.2.7
No
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Denial of Service (DoS)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Icons don't adapt with dark mode.

Visual bug, icons don't adapt with dark mode i.e don't turn lighter on dark mode  :

Also, the icon pngs here don't change their background to dark too :

It's fixed now, you should see proper icons now in both modes and for Material 3 accent as well.


chore: update electron-packager to v16

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] The changes are appropriately documented (if applicable).
[x] The changes have sufficient test coverage (if applicable).
[x] The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
Update electron-packager to v16

Thanks for the feedback,  I've removed yarn.lock. Maybe this information should be added to CONTRIBUTING.md?


Error adding entities for domain sensor with platform octopus_energy on startup

Describe the bug
I see the log message below on startup. Its not clear what the impact is but  my gas sensor
sensor.octopus_energy_gas_[mpan]_previous_accumulative_consumption_kwh
seems to only have data from 1pm to 8.30pm yesterday.
Reproduction steps
I see this on start up, not sure what to say to reproduce it.
Expected behaviour
Not to see an error message in the logs on startup
Tariff Code
No response
Integration Version
v8.0.0
Home Assistant Version
Home Assistant 2023.8.1 Supervisor 2023.08.1 Operating System 10.4 Frontend 20230802.0 - latest
Fresh Install?
Not specified
Home Assistant Logs
Logger: homeassistant.components.sensor
Source: custom_components/octopus_energy/electricity/current_accumulative_cost.py:148
Integration: Sensor (documentation, issues)
First occurred: 16:39:15 (2 occurrences)
Last logged: 16:39:15

Error adding entities for domain sensor with platform octopus_energy
Error while setting up octopus_energy platform for sensor
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 510, in async_add_entities
    await asyncio.gather(*tasks)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 750, in _async_add_entity
    await entity.add_to_platform_finish()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1003, in add_to_platform_finish
    await self.async_added_to_hass()
  File "/config/custom_components/octopus_energy/electricity/current_accumulative_cost.py", line 148, in async_added_to_hass
    self._last_reset = datetime.strptime(state.attributes[x], "%Y-%m-%dT%H:%M:%S%z")
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/_strptime.py", line 568, in _strptime_datetime
    tt, fraction, gmtoff_fraction = _strptime(data_string, format)
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/_strptime.py", line 349, in _strptime
    raise ValueError("time data %r does not match format %r" %
ValueError: time data '2023-08-08T16:35:42.170784+01:00' does not match format '%Y-%m-%dT%H:%M:%S%z'

Hello and sorry that you've encountered this issue. This should be fixed in a future release.

This should now be resolved in the latest release (https://github.com/BottlecapDave/HomeAssistant-OctopusEnergy/releases/tag/v8.1.0). You might get one more instance of this bug, but going forward it should be resolved.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_3bf590eb-072b-4280-8714-88efc5eb5cad/pull/1 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target_3bf590eb-072b-4280-8714-88efc5eb5cad.git

Docs Build status updates of commit b5f76fe:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Add usage tracking mechanism

Depends on vathes/datajointio#69
Adds usage tracking mechanism to allow python packages to easily log user's package usage.

@dimitri-yatsenko Thanks for the review. I've pushed updates addressing the following:

Your feedback above
Applied the styling updates for imports based on discussions in-person
Changed the default flow to be more conservative than before i.e. assumes user does not want to participate in usage tracking unless they explicitly input y or Y in prompt. Non-interactive shells will assume no usage tracking.
Included re-wording of console logs based feedback from 2021-04-30 DEMO
Included DISABLE_USAGE_TRACKING_PACKAGES module property that allows certain modules to be explicitly excluded from usage tracking. This was from @ttngu207's feedback in the 2021-04-30 DEMO and will be useful when depending on packages that have usage tracking enabled.


Add support for Untag command

Add support for the untag command, which allows users to untag one or more existing tags from a contact

fixes #61


immutable/plain prevents tree shaking

Are you submitting a bug report or a feature request?
bug report
What is the current behavior?
When using import {reducer} from 'redux-form', this pulls in all of redux-form, whether it's used or not.
What is the expected behavior?
This should only import the reducer and all the rest should be tree shaken (I use async imports to get at Field)
Sandbox Link
Here's what happens: When you import from the package, webpack sees the ES build, and in index.js there are lines like
export {default as Field} from './Field'

Following that, we see in Field.js:
import createField from './createField';
import plain from './structure/plain';

export default createField(plain);

Since createField could have side-effects, it has to be included in the build, even if its result is never used.
What's your environment?
RF 6.8.0, Webpack 3.0
Other information
To solve this, either the createField must be marked as a pure function in some way that webpack/rollup/etc etc can handle it, or the plain/immutable Fields must be precompiled somehow (maybe Prepack can do that?). Maybe there is another way, I don't know…
Until then, the workaround is to import from the individual files e.g. redux-form/es/reducer. This is not ideal as it interferes with SSR, since Node doesn't understand ES imports, and because it needs dev education.
Redux-form is great but the entire import is very heavy, it's the 3rd biggest package in my apps initial js bundle.

Because this issue saw almost no activity for a few months, I'm closing it.


Remove dependency to Junit4

What needs to be done
Remove JUnit4 from classpath
Why it needs to be done
Some dependency pulls in JUnit 4.
We use JUnit 5 and having both in the classpath could lead to wrong annotations being used, e.g. @Test.
Acceptance Criteria
a mvn dependency:tree should not contain any junit:junit:4.x dependency

I can do this if you wish

Hi, Can I work on this? I'm a first time contributor.

This may not be straightforward to achieve, since the junit4 comes from testcontainers, where it has been an issue for a long time:

See relevant issue in testcontainers project: https://github.com/testcontainers/testcontainers-java/issues/970. There are some workarounds mentioned though, may be worth to try them out

Hello everyone!
first of all, I am happy and grateful for the great interest to contribute and your fast replies to this issue 🤩
@szymonsadowski3 thanks for pointing this out. It seems indeed harder than I thought.
I was hoping JUnit 4 slipped in recently somehow (we had pain after accidentally using wrong @Test annotation yesterday).
It seems not to be as straightforward as just excluding a transitive dependency.
@Rayan1605 you asked first if you want to pick this and see if you can get it done - more than happy.
If not @nikhilyedke1995 can give it a try, otherwise we live with JUnit 4 for now, I guess...
I plan to clean up the backlog soon and create/find new issues that are (hopefully) a good start.
@nikhilyedke1995 keep an eye on it, please.

You've been fast @szymonsadowski3 🏎
Nice idea of using the enforce plugin. @Rayan1605 ?
fixed with #777


adding offset

Hey there,
due to the limit of 100 results per result set, there should be an offset option so that you can go through pages.
But anyway: nice project!

Thank you for your feedback. this feature will be available on coming up newer version. keep an eye on #17 for updates


Scroll to top button in landing page

User will be able to move to top of the page

@richaroy7 you can start working on this issue


EBS volumes not se to be deleted at termination

EBS volumes created by the script are not set to be deleted at termination.
When terminating the instances manually, we are prompted about that.

@glommer thanks for reporting.
How to reproduce? what instance type are you using?

I am using i3.2xlarge - but since the EBS volumes are the root volumes,
they will likely happen with any.
To reproduce, just create servers and loaders with
cassandra-test-and-deploy, and try to terminate them manually in the web
interface. A dialog will open, saying that the volumes are not set to
delete-on-termination
On Tue, Jun 27, 2017 at 1:36 PM, Tzach Livyatan<EMAIL_ADDRESS>wrote:

@glommer https://github.com/glommer thanks for reporting.
How to reproduce? what instance type are you using?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/scylladb/cassandra-test-and-deploy/issues/132#issuecomment-311430844,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUNvUp2mnth_cE42S0w_Aeky6Uv8pkrks5sIT21gaJpZM4OG1Ay
.

Adding the following to ec2 module command should handle it, but since the root device is already removed on termination, not sure why it is needed.
        volumes:
          - device_name: /dev/sda1
            volume_size: 10
            delete_on_termination: true


fix for TrainingRequest in Fake Database

Fix for #1233

Hello @askingalot. I tested it and it worked well. Thank you for your contribution!


rebase: update csi to v1.7.0

Update csi to the latest v1.7.0 release https://github.com/container-storage-interface/spec/releases/tag/v1.7.0
Signed-off-by: Madhu Rajanna<EMAIL_ADDRESS>

@mergifyio rebase


[solved]Very slow response

Hi mate, thanks for your work! I'm running in very slow response, for example calling:
private func test() {
        request.GET("http://www.google.it", parameters: nil, success: {(response: HTTPResponse) in
                if let jsonArray = response.responseObject as? NSData {
                    self.downloadedImageView.image = self.capturedImageView.image
                }
            },failure: {(error: NSError, response: HTTPResponse?) in
                println("error: \(error)")
        })
    }

if I breakpoint to "self.downloadedImageView.image = self.capturedImageView.image" row, from resume to the image assign elapse like 3/4 seconds.
With:
dispatch_async(dispatch_get_main_queue()) {
        self.downloadedImageView.image = self.capturedImageView.image
}

All works instantly. Thanks

Yeah that is expected behavior. The success block returns on a background thread to support JSON parsing and then calling dispatch_async(dispatch_get_main_queue()){} for UI needs. I will update the docs to better reflect this.

Yes, UIKit stuffs need to run into main thread. Update docs sounds so good, thanks again for work.

https://github.com/daltoniam/SwiftHTTP#ui-changes


Change the tag of this project to #OpenStreetMap instead of #openstreetmapS

Hi,
This is a very small thing, but I noticed your github project has the # openstreetmaps (with an S at the end, but it should actually be openstreetmap without the S), it's an easy typo to make.

Fixed. Thanks for point that out!


Add Syscoin Networks (Tanenbaum, Syscoin Mainnet, ROLLUX)

What is needed?
Adding in support (only price handling) to the transaction service.
Relies on :
https://github.com/safe-global/safe-singleton-factory/issues/123
https://github.com/safe-global/safe-singleton-factory/issues/124
https://github.com/safe-global/safe-singleton-factory/issues/125
&
https://github.com/safe-global/safe-eth-py/issues/487
Background
Syscoin requires intergration with the Safe.
Related issues
https://github.com/safe-global/safe-singleton-factory/issues/123
https://github.com/safe-global/safe-singleton-factory/issues/124
https://github.com/safe-global/safe-singleton-factory/issues/125
https://github.com/safe-global/safe-eth-py/issues/487
ATT: @develcuy

If you want this implemented please send a PR to https://github.com/safe-global/safe-eth-py


Make blocks to be keyed on UnixNano instead of time.Time

To void map miss caused by different locale set in time.Time
@xichen2020 @robskillington

Coverage increased (+0.01%) to 75.991% when pulling f12f88b5f85f86e49d2036d83dd1623a10466cb6 on chao-time-nano into<PHONE_NUMBER>edb7a3b673c2702fc67afb5465e660 on master.

Coverage increased (+0.01%) to 75.991% when pulling f12f88b5f85f86e49d2036d83dd1623a10466cb6 on chao-time-nano into<PHONE_NUMBER>edb7a3b673c2702fc67afb5465e660 on master.

Need to also update the following places that map[time.Time]... is used:
persist/fs/seek_manager.go (2 definitions)
storage/bootstrap/bootstrapper/commitlog/source.go (1 definition)
storage/repair.go (1 definition)
storage/repair/metadata.go (1 definition)
storage/repair/types.go (1 definition)
storage/shard.go (1 definition)

Yeah, I'm thinking to keep the blast radiance down per diff, I'm gonna fix all the usage of this interface in this one and handle those other places in separate diffs.

Coverage increased (+0.02%) to 76.002% when pulling 44e559f16cb9c9db3198d2d6b27a95a5cecd68f3 on chao-time-nano into<PHONE_NUMBER>edb7a3b673c2702fc67afb5465e660 on master.

Coverage increased (+0.02%) to 76.002% when pulling 44e559f16cb9c9db3198d2d6b27a95a5cecd68f3 on chao-time-nano into<PHONE_NUMBER>edb7a3b673c2702fc67afb5465e660 on master.

Talked with Rob, will postpone this pr and do a full sweep of time.Time in maps across the code base


Add files via upload

works but adding code to display notifications breaks the scanner

Turns out the problem wasn't from the scanner and it was fixed, the updates will be added in another commit.


Docs/Book/Makefile references APIDOCSHOME = $(RDBASE)/rdkit/docs which does not exist

Trying to build the html documentation requires building the apidocs, and this fails early:
rdkit-201503/Docs/Book$ RDBASE=../.. make html
mkdir -p _build/html/api
mkdir -p _build/html/cppapi
cp ../../rdkit/docs/*  _build/html/api
cp: cannot stat ‘../../rdkit/docs/*’: No such file or directory
Makefile:42: recipe for target 'apidocs' failed
make: *** [apidocs] Error 1

Am I missing something here? Is rdkit/docs supposed to be generated during the build somehow? If so, how, I tried a build and AFAICT it is not being generated.
Or is this a issue of case-sensitivity, and rdkit/docs is really supposed to be $RDBASE/Docs?

OK, I figured out now that $APIDOCSHOME and $CPPAPIDOCSHOME are built by epydoc and doxygen, respectively, by looking at Scripts/NightlyBuildAndTest.sh.
I think this is heavily under-documented (should at least have a comment in Docs/Book/Makefile).
Also, the docs-build integration with CMake looks like it could be improved, the built documentation in Docs/Book/_build is ignored by the install target, but all the .rst source files are installed. I can see how conditional building/installing might be difficult here, i.e. it would need deeper integration into CMake including adding options which parts of the documentation need to be built.

It is certainly under-documented. I'll take a swing at fixing this.

Renamed to reflect what I think the remaining issue is.


ghi help

This is a tet of thr floepjfx dpigjperjgpojpoerjgpojfpogjpoerigpoijdfpoglErirgjierjpgojerpogjerpogerpoigporipgjpogjpoergjgsporejgPeter GallwasAzure Administrator     t:m:e:a: NZ |<EMAIL_ADDRESS>www.husky.nz

This is was a test you now can email<EMAIL_ADDRESS>and if it have ghi in the subject it will open an issue


VS Code "Error loading webview: Error: Could not register service workers: InvalidStateError:"

Describe the bug
When i activate spotlight by Alt H , i get an error
Error loading webview: Error: Could not register service workers: InvalidStateError: Failed to register a ServiceWorker: The document is in an invalid state..
To Reproduce
Steps to reproduce the behavior:

Open a Haskell project
Click on Alt H
At the bottom corner of VS Code i get the error
Error loading webview: Error: Could not register service workers: InvalidStateError: Failed to register a ServiceWorker: The document is in an invalid state..

Expected behavior
Open a search page
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

Device: Desktop
OS: Windows 11
Browser [Chrome and also Microsoft Edge]
VS Code Version [1.66.2]

Additional context
See attached screen shot

Hi @salimp2009
Please try to close all VSCode instances and open the extension in a new one.
If it won't help you, please try all listed solutions listed here:
https://stackoverflow.com/questions/67698176/error-loading-webview-error-could-not-register-service-workers-typeerror-fai

thank you. After opening this issue I disable the extension at VS Code. When you sent the answer , i reenabled and now it works. It worked; i did not have to do anything else. But it seems like a general VS Code issue... Rebooting whole windows might have worked . Thanks a lot that is a great tool
I will close it

Perfect.
You are welcome. 🙂


Add Action Server - Takeoff & Land

Add two actions to enable Takeoff and Land services

Done the work.  Testing needed in the simulator to confirm it is bug free


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: hernanvo sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

test


Allocate lectures + session "leadership"

I think we should have an allocated leader per session and that this should likely be the person who goes through the slides.
We spoke about @sbfnk and I handing off on this but do we want to write it down explicitly (i.e here) or change that decision up at all. I have no strong preference.
We could also go with whoever wrote the material should give the lecture but that leaves @sbfnk doing all but two (which I am totally happy with and might have consistency benefits but feels unfair even when taking into account their august majesty)

tentatively (can revisit later) I'm happy with me day 1, you day 2 - i.e. who led writing the sessions.

This was in terms of session leading, I'm also happy to give all the lectures I drafted you don't want to have to deal with my slides (what a power move to put together all these decks of three slides text only).
Perhaps we just agree that I start tomorrow and then we see how we go.

I'm happy with me day 1, you day 2 - i.e. who led writing the sessions.

Sure


Fixed minor problems

Fixed minor problems
Description
I am using this labeler in my current project.
I had to make some changes so I am able to properly import it in my angular application.
Changes

Added basic typescript typings
Fixed the main property in package.json so it points to a valid file. I also added the module field which points to the es6 module at the src folder
I moved express to the dev-dependencies because users of this module do not need to install express for the frontend only component.
I exported the ULabel class in the module so I can import it directly without accessing it via window.ULabel

PR Checklist

[X] Merged latest main
[ ] Version number in package.json has been bumped since last release
[ ] Version numbers match between package package.json and src/version.js
[ ] Ran npm install and npm run build AFTER bumping the version number
[ ] Updated documentation if necessary (currently just in api_spec.md)
[ ] Added changes to changelog.md

Breaking API Changes
None

Hi @neheller
thank you for the hints, I updated my PR.
I think the typings are good enough for now since in #10 you mentioned you want to migrate to typescript anyway. Then we can generate the typings directly from the code and do not have to maintain a separate file.


Attempting to use auth on the API when it's disabled results in nasty errors

I ran into this while trying to get Hubot working with Stackstorm (1.3.x and 1.4dev). Even though auth was working/required on the web frontend, it was disabled via st2.conf. When Hubot would auth and then try to use the API, it would get a HTTP 500 error.
For a request such as this (via nginx):
<IP_ADDRESS> - - [12/Feb/2016:16:45:20 -0800] "GET /api/v1/stream?x-auth-token=9e1fdd874bf04c0ba0789ced62f51d97 HTTP/1.1" 500 46 "-" "-"

You'd see this in st2api.log:
2016-02-12 16:38:30,273<PHONE_NUMBER>57680 INFO log [-] args = (<st2api.controllers.v1.stream.StreamController object at 0x7f07676337d0>,)
2016-02-12 16:38:30,273<PHONE_NUMBER>57680 INFO log [-] kwargs = {u'x-auth-token': u'e7abfd1066e543f585ab877191043a5a'}
2016-02-12 16:38:30,274<PHONE_NUMBER>57680 ERROR log [-] API call failed: get_all() got an unexpected keyword argument 'x-auth-token'
Traceback (most recent call last):
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/pecan/core.py", line 631, in __call__
    self.invoke_controller(controller, args, kwargs, state)
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/pecan/core.py", line 531, in invoke_controller
    result = controller(*args, **kwargs)
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/st2common/models/api/base.py", line 245, in callfunction
    raise e
TypeError: get_all() got an unexpected keyword argument 'x-auth-token' (_exception_data={},_exception_class='TypeError',_exception_message="get_all() got an unexpected keyword argument 'x-auth-token'")
2016-02-12 16:38:30,275<PHONE_NUMBER>57680 ERROR log [-] Traceback (most recent call last):
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/pecan/core.py", line 631, in __call__
    self.invoke_controller(controller, args, kwargs, state)
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/pecan/core.py", line 531, in invoke_controller
    result = controller(*args, **kwargs)
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/st2common/models/api/base.py", line 245, in callfunction
    raise e
TypeError: get_all() got an unexpected keyword argument 'x-auth-token'
Traceback (most recent call last):
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/pecan/core.py", line 631, in __call__
    self.invoke_controller(controller, args, kwargs, state)
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/pecan/core.py", line 531, in invoke_controller
    result = controller(*args, **kwargs)
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/st2common/models/api/base.py", line 245, in callfunction
    raise e
TypeError: get_all() got an unexpected keyword argument 'x-auth-token'
2016-02-12 16:38:30,275<PHONE_NUMBER>57680 INFO log [-] 7134fb02-4a85-485d-850b-f6f00e0c123c - GET /v1/stream (remote_addr='<IP_ADDRESS>',method='GET',status_code='500 Internal Server Error',request_id='7134fb02-4a85-485d-850b-f6f00e0c123c',path='/v1/stream')

Setting enable = True under the auth section makes everything happy.

It is a known problem and we even have a PR fixing it (see https://github.com/StackStorm/st2/pull/2102), although we were unable to reach an agreement internally on how it should be handled. May be your feedback can tip the scale.

I'm on the fence in that debate, and I don't have strong feelings anyway, since this is no longer affecting me. Personally, I think that it should be done on the server-side (because there can be multiple client implementations, and it's silly to fix it in all of them), but I also agree that there should be some feedback to the client that auth is disabled.

500 is bad but definitely the request needs to be rejected.
Allowing a request through when auth is disabled even though the client is passing in a token that is enabled is setting the wrong expectation for a client. Also, I wonder where this token comes from if auth is actually disabled.

Finally fixed in https://github.com/StackStorm/st2/pull/2102.


Sporadic Deadlock When Using Async and Yield

I am running into a possible deadlock scenario when running the attached code without HCLIB_LOCALITY_FILE and with two workers.
The promises and waits were executed just fine but it seems like the tasks themselves never finish for some reason. I am able to reproduce this issue about 7 out of 10 runs on my machine. @srirajpaul was also able to reproduce this.
#include <chrono>
#include <cstdint>
#include <iostream>
#include <stdlib.h>
#include <thread>

#include "hclib_cpp.h"

int main(int argc, char** argv) {
    const char* deps[] = { "system" };
    hclib::launch(deps, 1, []() {
        hclib::finish([]() {
            hclib::async([]() {
                hclib::promise_t<int>* x = new hclib::promise_t<int>();
                hclib::promise_t<int>* y = new hclib::promise_t<int>();

                hclib::async([y] {
                    hclib::yield();
                    y->put(1);
                });

                hclib::async([x] {
                    x->get_future()->wait();
                });

                y->get_future()->wait();
                x->put(10);
            });
        });
        std::cout << "all finished " << std::endl;
    });
    return 0;
}

@JKChenFZ I'm seeing sporadic hangs in some of our other tests as well (cpp/promise/async_future_await_at) that use put and wait. I'm working on finding when the issue was introduced, but at the moment I'm all the way back to this commit and the issue still exists:
commit 01aafbf4a516b20289e890b07b099537420cb23b
Merge: ae2801e bfff5c4
Author: Max Grossman<EMAIL_ADDRESS>Date:   Sun May 17 09:28:25 2020 -0700
Merge pull request #83 from habanero-rice/access_promise_from_future

Some new async APIs, small formatting and comments changes

Just wanted to say thanks for calling this out, and let you know I'm looking in to it.

I suspect this may be the same issue as:
https://github.com/habanero-rice/hclib/issues/73


Why only std::shared_ptr ?

I like the event bus idea, however does it really need to depend on std::shared_ptr? It makes it difficult to integrate event bus in projects which do not use shared ownership and therefore shared pointers. I think that it should be possible to register listner via raw pointer, provided that it unregisters itself in destructor or even before its destructor is called.

I'm planning to create a new project that has buses for both the models.
The advantage of the one using shared_ptrs is that you don't have to care about the lifetime of your listeners, they are automatically removed from the base when expired (note that the bus stores a weak_ptr, not a shared_ptr).
In the other case, you have to manage explicitly that situation, so dangling pointers quickly become a risk.
Anyway, I'd suggest to stay tuned, for the new, minimal project is coming and it contains delegates, as well as observers defined the way you would like them to be defined, as well as the event bus defined the way it's defined, and so on...

@Ravirael
Well, ok, it took me a while to start the new project to which I was thinking.
However, finally here it is. The signalling stuff I promised is part of EnTT.
Hope you can find there all what you are looking for.


Docs Website Styling Updates

Several styling updates:

Updated our link on hover states to be Cobalt's 'Sky Blue' so that it shows well on both dark and light backgrounds, prior to this change the hover state was our navy and it disappeared in the footer when hovering on 'Privacy'.
Updated the CTA cards on the home screen to incorporate the button style links instead of text only style links.
Updated the CTA cards on PMP to match the style we now have on our home page.
Updated the PMP page with a UI graphic for selecting 'In-House Pentests'
Updated header sizing on the 'Sequence' page, they were all #H1 and now they are ##H2
Removed a duplicate header from the Sequence page, the title appeared at the top of the page and right below the page title, removed the second one below the page title.
Updated our chevron styles to be smaller in size and fit more inline with our text. Went from 'x-large' to 'medium'.
Added a UI screen to the 'Planning' page.

Started revising our'%paginfo shortcodes blocks, in a future PR, I will update the notes and tips one as well and document the new available shortcodes in our docs style guide.
Below are the first changes:

Changed the header, main pageinfo from docsy variant blue to light purple
Added new styles for green - matching our brands 'light green'
Added a new style for yellow - matching our brands 'light yellow'

Preview This Change
To see how this change looks in production, scroll down to Deploy Preview. Select the link that looks like https://deploy-preview-<num>--cobalt-docs.netlify.app/
Variables
Help us support a “Write once, publish everywhere” single source of truth. If you see a line that looks like:
{{% asset-categories %}}
You’ve found a shortcode that we include in multiple documents.
You’ll find the content of the shortcode in the following directory:
https://github.com/cobalthq/cobalt-product-public-docs/tree/main/layouts/shortcodes
That shortcode has the same base name as what you see in the PR, such as asset-categories.html.
Checklist for PR Author
[ ] Did you check for broken links and alt text?
Be sure to check for broken links and Alt Text issues. We have a partially automated process,
as described in this section of our repository README:
Test Links and Alt Attributes.

Looks great! Not blockers but some considerations:

The Pentest Preparation Checklist button is on two lines rather than one, so looks bulkier, for some reason

Some pageinfos (I don't know if I captured them all) have a highlight behind some text that almost but doesn't blend in with the new purple bg

The Beta label also slightly blends in when used within pageinfo

Thanks @mtsuji-cobalt  - I fixed the highlight issues as well as 'Beta' one. The only remaining issue is the button one for the text split on two lines. I'll have to work this one separately on a future PR.


open-vpn 0.0.1

New Pull Request Checklist
Please mark the points which you did / accept.

[x] I will not move an already shared step version's tag to another commit
[x] I read the Step Development Guideline
[x] I have a test for my Step, which can be run with bitrise run test (in the step's repository)
[x] I did run bitrise run audit-this-step (in the step's repository - note, if you don't have this workflow in your bitrise.yml, you can copy it from the step template.)
[x] I read and accept the Abandoned Step policy

Thanks for sharing the step @justice3120 ! 😉
The CLI team will review this as soon as they can - the first review takes a bit more time as they check the step more thoroughly, for updates after that they only have to check the changes :)


Network location provider at 'https://www.googleapis.com/' : No response received.

error: Network location provider at 'https://www.googleapis.com/' : No response received.

@jakeauyeung have you ever found any solution to this? I am getting the same error in ionic-angular project with Geolocation plugin of googlemapsapi

Hi,
Getting the same issue when calling navigator.geolocation.getCurrentPosition in angular project but this happens only in chrome

@Santosh008 for me this only happens on Windows electron app? Are you able to achieve this on windows electron app?


OEL 5.11, init.pp calls udevadm instead of udevcontrol

The logic in the init.pp causes udevadm (which doesn't exist) to be called instead of udevcontrol on OEL 5.11 because you check for "operatingsystem == 'RedHat'" instead of perhaps a better option of "osfamily == 'RedHat'".

Fixed in razorsedge/vmwaretools version 6.0.0.


azcopy - copy local directory into an azure blob store

I try to move a whole Azure Blob Storage (all containers and all blobs) to my local dev machine's Storage Emulator for debugging purposes.
I already have a script which downloads all containers and all their blobs into a local directory. I'm using a combination of Get-AzureStorageContainer & azcopy container->directory (--recursive).
Now I want to use azcopy to re-upload them into my storage emulator's blob storage. But I always run into the error below. According to https://docs.microsoft.com/en-us/azure/storage/common/storage-use-azcopy-blobs?toc=%2Fazure%2Fstorage%2Fblobs%2Ftoc.json#upload-files it should be a supported scenario (see chapter Upload a directory)
Which version of the AzCopy was used?
10.2.1
Which platform are you using? (ex: Windows, Mac, Linux)
Windows
What command did you run?
. "$PSScriptRoot\azcopy.exe" copy "$dir$container" "http://<IP_ADDRESS>:10000/devstoreaccount1/$container" --recursive
What problem was encountered?
failed to parse user input due to error: the inferred source/destination combination is currently not supported. Please post an issue on Github if support for this scenario is desired
How can we reproduce the problem in the simplest way?
Try to import a whole directory into a blob store container
Have you found a mitigation/solution?
No.

Add this to the command line:  --fromTo LocalBlob
That should fix it.... I think.  (And I think a better fix is coming in release 10.3)

Unfortunately this gives me unknown flag: --fromTo and a usage message. Any other ideas? A typo maybe?

Sorry, silly me. It's --from-to LocalBlob
(note the dash between from and to, which I missed out the first time)

That worked, thanks!

(you should probably put that flag into the docs though :-) )

It is listed on the docs page, but easily missed as there's a fair number of options available there.
Under certain circumstances AzCopy gives additional info along with the error, suggesting you use the from-to flag, but obviously not in this case.

Hmm - one more question though, it didn't work as expected. Now I'm always running into "Failed" PUT statements - according to the log:
RESPONSE Status: 404 The specified resource does not exist.
   Content-Length: [223]
   Content-Type: [application/xml]
   Date: [Thu, 03 Oct 2019 17:38:30 GMT]
   Server: [Windows-Azure-Blob/1.0 Microsoft-HTTPAPI/2.0]
   X-Ms-Error-Code: [ResourceNotFound]
   X-Ms-Request-Id: [b2880a94-5edc-472b-9d26-94c3b741aa47]
   X-Ms-Version: [2018-03-28]

I tried the following commands:
copy C:\Temp\ContainerDirectory1 http://<IP_ADDRESS>:10000/devstoreaccount1/ --recursive --from-to LocalBlob

// as well as:
copy C:\Temp\ContainerDirectory1 http://<IP_ADDRESS>:10000/devstoreaccount1/CotainerDirectory1 --recursive --from-to LocalBlob

Is there a catch? Is it not possible to upload a directory and its contents as a container and its blobs?

I gave it now a try by using a SAS account token, didn't help either. It now returns with RESPONSE Status: 404 The specified container does not exist. - slight difference to before where the resource didn't exist and not the container. BUT of course it does not exist, I'm trying to upload it at this moment...

I'm actually not sure!  It's not a super-common usage pattern. THe more common one for uploads is to create the container first, then upload into it.  We support container creation for account-to-account copies, but I'm not sure whether we do for uploads.
@adreed-msft Do you know what 10.3 will support?  Can you upload to a container that does not yet exist?
Finally @drauch, it is possible that there's some issue specifically to do with targeting the emulator, that I don't know about.  So if you try creating the container first and that still doesn't work, please let us know and we'll log a bug against our emulator support.

He more common one for uploads is to create the container first, then upload into it.
OK, this actually works. Thanks so much for the fast replies!

Best regards,
D.R.

Great. Will leave this open until @adreed-msft  confirms the 10.3 behaviour, so that we know whether to add something to our backlog to help customers who try it without making the container (even just a clearer error message); or if 10.3 in fact makes it work to upload without an existing container.
For now, glad to know its working for you.

@adreed-msft can you check the comment above pls?


Remove non-existing global class from cache

Fixes problems with deleting script files containing global classes.

When a script file containg a global class is externally deleted, Godot editor doesn't handle this gracefully. Editor keeps spamming errors, but doesn't fix the situation.
When a directory is removed in Godot editor, directory's files are more or less ignored and global classes from those files are not properly removed. Master assumes wrongly that EditorFileSystem's scan will handle the situation, but it doesn't.

Fixes https://github.com/godotengine/godot/issues/81867
Test cases
Test project contains two new classes, my_good_sprite_2d.gd located in root and another in bad/my_bad_sprite_2d.gd.
g42_cache_test.zip

Open Godot and test project

Start adding new node by clicking + button in Scene tree.
--> SUCCESS: MyBadSprite2D is possible node type, no errors

Delete directory "bad"

Start adding new node by clicking + button in Scene tree.
--> FAIL: You get errors

Close Godot and delete my_good_sprite_2d.gd from file system
Open Godot and test project
Start adding new node by clicking + button in Scene tree.
--> FAIL: Now you errors also from MyGoodSprite2D

The only situation where removing classes from cache file works, is when only files, not directories, are deleted in Godot editor.
Fixes
The reason for the errors is that the global classes made by the user are not properly removed from .godot/global_script_class_cache.cfg.

Changes in create_dialog.cpp fix the situation when files are deleted externally. When a non-existing global class is detected, it is removed from the cache. This prevents further errors.

Changes in dependency_editor.cpp fix the situation when a folder containing a class file is deleted in Godot editor. When directories are deleted, master doesn't process each deleted file the same way as single deleted files are processed. Instead it is assumed that EditorFileSystem's scan will handle this, but it doesn't. Scan doesn't notice deleted directories at all. Now for every deleted file, EditorFileSystem's update_file is called and the global class (if file contains one) is deleted from cache file.

Superseded by #90186. Thanks for the contribution!


Update Knockout City

Game Title
Knockout City
Status of the Anti-Cheat
⭐ Supported
Proof of Mention
https://twitter.com/Plagman2/status/1493854504290119682?t=flJ90SMI7DIniecWO8Slew&s=19

Closed in https://github.com/Starz0r/AreWeAntiCheatYet/commit/b9f3dad1e2f9324fd82bfe835e4bd4a36647d38a.


Confusing options/switches on homepage

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[x] I've verified that I'm running yt-dlp version 2023.03.04 (update instructions) or later (specify commit)
[X] I've searched known issues and the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood
Some options/switches have an added "s" which makes the instructions confusing on your homepage.
I found these 2:
--no-check-certificates & --config-locations
Should be:
--no-check-certificate & --config-location
Might be more, see images below for explanation.

Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
No response

Switches can be shortened when not causing ambiguity, so you may use either of the switch variations (--config-locations, --config-location, --config-loc, ...) as long as it doesnt conflict with other switches. Are you saying the documentation should be adjusted to use the longer variation?
Imo a trailing s implies that the switch can be passed multiple locations at once while not having it implies that only one path may be used, and so it is easier to understand this way around. Also keep in mind that changing the name of the switches is not really plausible anymore due to compatibility.

For me it's confusing because it's ambiguous, especially when we are talking switches.
Please see the youtube-dl documentation:
youtube-dl

I don't have an issue with the added "s", and it's great that both varieties
work.
However it would be nice with a more explanatory description.
If I would have seen something like:
--config-location/s (either single or multiple locations)

The s is not going to be removed.
We are also not going to list the possible shortenings of each option.
A PR to make the entire readme consistently use the full option name is welcome.
While this shortening is a feature of many command line programs, we could still mention it somewhere. Any suggestions?

Can re-open if anyone follows up


Create Destiny.py

destiny.py - takes post-parsed events, creates events from them, and places them in a relational db or formatted in a flat file

Requirements:

Should alert on basic secuirity threats found

SQLi
Account Compromise
Persistent XSS
Reflected XSS
Brute Force Attempts
DDoS
Botnet Activity
Malware Infection
Phishing Attempt

Should alert on anomalous behavior

changes in log volume

per stream and in general

changes in network behavior (per-host basis)
changes in log content
changes in # of sources
changes in number of connections (network)
changes in number of blocks (firewall)
changes in number of alerts (IDS/IPS)

Should alert the user via Celestial web UI
Should be tunable via the client using Celestial

Split Destiny to parent class, w/ Sage acting as a threat detection AI and Erudite acting as an anomaly detection engine.

The last hurdle with this module is with Issue #63 .


Updating scenarios with README

Purpose

Adding README to Scenarios folder and a sample input file for call center.

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[x] Other... Please describe: Added sample file.

@trrwilson @BrianMouncer just fixed file ending to LF.


Expose MemoryMapIter in API

There's no reason to keep it private. Also using generic type here makes it hard to transfer ownership since it's impossible to use Box without a heap allocator. It makes implementing frame allocator much harder.
Fixes #616
Checklist

[x] Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
[x] Update the changelog (if necessary)

Hi @liferooter,
I totally missed that you set up that PR. Seems like we both had the same idea because I just did the same in #618 a few minutes ago.


Replace old download scripts

This pull requests replaces the old download links with the new pattern (sample: https://github.com/PINTO0309/PINTO_model_zoo/commit/db4e3afceb9413b5500b219d78f2ae3840decd4d).
The replacement has been done using the following script: https://gist.github.com/ibaiGorordo/69988fbf83a045e6c58701aa03eb423f
I have not tested the changes, so there might be issues with some of the conversions.

Too wonderful. Other engineers are starting to work on converting the target model, so I will temporarily hold off on this pull request, although I very much appreciate it. However, it appears to be a very effective means of filling in gaps in other engineers' modifications. :100:
https://github.com/PINTO0309/PINTO_model_zoo/issues

I realized the are mistakes in scripts with two downloads. I need to modify the script to search for the curl line, instead of hard code define the lines.
To avoid the chaos, you can ignore this PR and convert the other models in your local copy.

I updated the conversion script for multiple downloads and I think the rest are fine, but I might have misses some files with a different pattern.

Thanks!

@ibaiGorordo Thank you for your time, but can you resolve the conflict? Once the conflict is resolved I would like to merge your proposals in bulk.

I think it should be fine now. I modified those files manually, but if necessary I think it should be possible to add the rm cookie for the rest of the scripts

Thank you! I will reflect the changes once in this state.


Bump pkgrels to trigger rebuild for python 3.11

(except for ola since that takes a long time to build)
(and qjackcapture since the build failed)
Closes #224

@SpotlightKid do you see any blockers here? On aarch64 we're still on 3.10 but we'd just update again later

qjackctl?

qjackctl?

*qjackcapture, my mistake :D

python-pyjacklib needs to be rebuilt and the new pkgrel in our repo before qjackcapture can be updated.


chore: bdd-spring-1586219321 to 0.0.1

chore: Promote bdd-spring-1586219321 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Create internal interface argument for istio-iptables script

Related to https://github.com/istio/istio/pull/10378
traffic explain:
From k8s network to the vm.
k8s network -> prerouting rules -> ISTIO_INBOUND -> envoy process -> (localhost:port) -> PREROUTING -> KUBEVIRT_PREINBOUND -> DNAT (vm ip) -> POSTROUTING -> KUBEVIRT_POSTINBOUND -> SNAT (bridge ip) -> VM
From vm to k8s network.
VM -> PREROUTING -> ISTIO_REDIRECT -> envoy process -> PREROUTING -> POSTROUTING -> k8s network

In the same PR so that people understand why the additional rules are added for KubeVirt.

/ok-to-test

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram, SchSeba
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SchSeba: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
26ee82021dfdbe0634abe87972d199078e590430
link
/test istio-unit-tests

prow/istio-integ-k8s-tests.sh
26ee82021dfdbe0634abe87972d199078e590430
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
9a0f8b56947dde118cc6c29ed4820491468c6671
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Hi @rshriram thanks for the approve

In the same PR so that people understand why the additional rules are added for KubeVirt.

Done :)

@SchSeba: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
26ee82021dfdbe0634abe87972d199078e590430
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
9a0f8b56947dde118cc6c29ed4820491468c6671
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests.sh
9a0f8b56947dde118cc6c29ed4820491468c6671
link
/test e2e-simpleTests

prow/istio-unit-tests.sh
9a0f8b56947dde118cc6c29ed4820491468c6671
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SchSeba: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
26ee82021dfdbe0634abe87972d199078e590430
link
/test istio-integ-k8s-tests

prow/istio-unit-tests.sh
9a0f8b56947dde118cc6c29ed4820491468c6671
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
9a0f8b56947dde118cc6c29ed4820491468c6671
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SchSeba: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
9a0f8b56947dde118cc6c29ed4820491468c6671
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
9a0f8b56947dde118cc6c29ed4820491468c6671
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
9a0f8b56947dde118cc6c29ed4820491468c6671
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram, SchSeba, wenchenglu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/test istio-unit-tests.sh

@SchSeba: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

New changes are detected. LGTM label has been removed.

Done with the rebase

@SchSeba: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
9a0f8b56947dde118cc6c29ed4820491468c6671
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
9a0f8b56947dde118cc6c29ed4820491468c6671
link
/test istio-integ-k8s-tests

prow/istio-unit-tests.sh
b651718cb0a6a77c31d0ab13a09e826f198692dc
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SchSeba: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
9a0f8b56947dde118cc6c29ed4820491468c6671
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
b651718cb0a6a77c31d0ab13a09e826f198692dc
link
/test istio-unit-tests

prow/istio-integ-k8s-tests.sh
b651718cb0a6a77c31d0ab13a09e826f198692dc
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SchSeba: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
9a0f8b56947dde118cc6c29ed4820491468c6671
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
b651718cb0a6a77c31d0ab13a09e826f198692dc
link
/test istio-unit-tests

prow/istio-integ-k8s-tests.sh
b651718cb0a6a77c31d0ab13a09e826f198692dc
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
b651718cb0a6a77c31d0ab13a09e826f198692dc
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SchSeba: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
b651718cb0a6a77c31d0ab13a09e826f198692dc
link
/test istio-unit-tests

prow/istio-integ-k8s-tests.sh
b651718cb0a6a77c31d0ab13a09e826f198692dc
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
b651718cb0a6a77c31d0ab13a09e826f198692dc
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
b651718cb0a6a77c31d0ab13a09e826f198692dc
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Hi @rshriram and @wenchenglu I had to rebase so the lgtm label was remove can you please take another look on this PR and tell me if it is ready to be merge or you need something else.

/test istio-unit-tests.sh

unit tests are failing.. could you fix them so that we can merge this PR?

/test istio-unit-tests.sh

Hi @rshriram thanks for the comment I fixed the unit tests can you please take a look?

@SchSeba: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
b651718cb0a6a77c31d0ab13a09e826f198692dc
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
b651718cb0a6a77c31d0ab13a09e826f198692dc
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
d4b4d41cfce5c7983e79539c79b4a63fb26c70f6
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SchSeba: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
b651718cb0a6a77c31d0ab13a09e826f198692dc
link
/test istio_auth_sds_e2e

prow/istio-integ-k8s-tests.sh
d4b4d41cfce5c7983e79539c79b4a63fb26c70f6
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
d4b4d41cfce5c7983e79539c79b4a63fb26c70f6
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SchSeba: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
d4b4d41cfce5c7983e79539c79b4a63fb26c70f6
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
d4b4d41cfce5c7983e79539c79b4a63fb26c70f6
link
/test istio-pilot-multicluster-e2e

prow/e2e_pilotv2_auth_sds.sh
d4b4d41cfce5c7983e79539c79b4a63fb26c70f6
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SchSeba: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
d4b4d41cfce5c7983e79539c79b4a63fb26c70f6
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
d4b4d41cfce5c7983e79539c79b4a63fb26c70f6
link
/test istio-pilot-multicluster-e2e

prow/e2e_pilotv2_auth_sds.sh
d4b4d41cfce5c7983e79539c79b4a63fb26c70f6
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d4b4d41cfce5c7983e79539c79b4a63fb26c70f6
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

merge with release 1.1, as a fix went in recently

@rshriram rebase on release 1.1

@SchSeba: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
d4b4d41cfce5c7983e79539c79b4a63fb26c70f6
link
/test istio-pilot-multicluster-e2e

prow/e2e_pilotv2_auth_sds.sh
d4b4d41cfce5c7983e79539c79b4a63fb26c70f6
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d4b4d41cfce5c7983e79539c79b4a63fb26c70f6
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-integ-k8s-tests.sh
ada5e1026ad997bd799dfac91442c5afde614cd5
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SchSeba: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
d4b4d41cfce5c7983e79539c79b4a63fb26c70f6
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
ada5e1026ad997bd799dfac91442c5afde614cd5
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
ada5e1026ad997bd799dfac91442c5afde614cd5
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SchSeba: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
ada5e1026ad997bd799dfac91442c5afde614cd5
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
ada5e1026ad997bd799dfac91442c5afde614cd5
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
ada5e1026ad997bd799dfac91442c5afde614cd5
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hi，I have a problem with the iptables rules for: k8s network -> vm
k8s network -> prerouting rules -> ISTIO_INBOUND -> envoy process -> (localhost:port) -> PREROUTING -> KUBEVIRT_PREINBOUND -> DNAT (vm ip) -> POSTROUTING -> KUBEVIRT_POSTINBOUND -> SNAT (bridge ip) -> VM
in envoy process -> (localhost:port) -> PREROUTING. when envoy call localhost, its packets SHOULD only pass OUTPUT and POSTROUTING. how could packets pass PREROUTING? （in fact I tested, it truely pass PREROUTING, but I don't know why this happen),thanks

Hi @scuzhanglei I think this is because you are sending the traffic to the bridge interface inside the pod so the traffic looks like incoming from network for that interface this is why you hit the PREROUTING again


Loads all pages automatically without creating cache?

Configuration:

Web browser and its version: Chrome Version 103.0.5060.134
Operating system and its version: The Server is on Ubuntu 18.04.5, the client/browser is on Windows 10 10.0.19043.1826
PDF.js version: v2.14.305 (cloned from github an hour ago)
Is a browser extension: No

What is the expected behavior?
I have a reason that I wanted to load all the pages, so I changed DEFAULT_CACHE_SIZE to a greater value.
But in order to cache them firstly I need to go through the pages manually pressing the page down key for countless times.
So It's desirable for me if I could load/cache all the pages automatically when I opened a pdf file.
Is it possible through an option or modifying the source code? Thanks.

I have a reason that I wanted to load all the pages, so I changed DEFAULT_CACHE_SIZE to a greater value.

That's really not a good idea, as outlined in https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#allthepages

Is it possible through an option or modifying the source code?

Given the above, no such option exists. (Obviously anything is possible with source-code modification, however that's not something that we'll provide support for.)


integration-docs: Update for new format (Harbor, Greenhouse, JSON, Jotform)

As the changes were mostly to the docs format and not content, these are grouped together in a PR that updates 4 doc pages.
As part of https://github.com/zulip/zulip/issues/29592, update the following integration documentation pages:
Screenshots and screen captures:

Harbor

Greenhouse

JSON

Jotform

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Is this one ready for @adnan-td and @Niloth-p to take a look?

Update: Edited phrasing, addressed review from @adnan-td , and added commit description for some commits.
@Niloth-p Could you please take a look at this one as well? I've also applied the comment you left at #30725 to here. Let me know if there are any oversights or any other suggestions. Thanks!

Update: addressed review
@Niloth-p & @adnan-td  - Thanks for reviewing!

@Niloth-p Updated!

@laurynmm this one should be ready for you to take a look.

@PieterCK - These updates look good! I pushed a quick update to the Jotform doc that cleans up the instructions a bit more. We also should note we need to update the icon/logo for that integration. Going to go ahead and mark for integration review. Thanks for working on these updates!

Updated Jotform doc
Current documentation

Merged, thanks @PieterCK and everyone else who helped review this! I love the teamwork on this sweep.


Subscribe URLs

I have updated the subscribe links on Diverse Health, Military and CCnewsnow.com web sites.

 PR #178


AWS TF security improvements

[ ] Looks like RDS ingress is open to anyone on the Internet. Is this required, or can this be locked down?
[ ] It is recommended to set enable_key_rotation = true (TF doc) for all created KMS keys like civiform_kms_key, backend_storage_key, and file_storage_key.
[ ] It is recommended to export significant CiviForm database events to CloudWatch for visibility (by setting the enabled_cloudwatch_logs_exports attribute).

Maybe useful reference from Seattle's deployment: https://github.com/seattle-uat/civiform-deploy/tree/main/infra

Question limiting ingress traffic, wouldn't DB be accessible only from within VPC anyway? From public internet it should be impossible to get hold of db address/ip.  Though limiting ingress wouldn't hurt.

Correct, this is an extra measure to also limit ingress. DB shouldn't be accessing from public internet at all.


Roll Flutter Engine from c602abdbae16 to 5d13a29822b4 (2 revisions)

https://github.com/flutter/engine/compare/c602abdbae16...5d13a29822b4
2024-03-27<EMAIL_ADDRESS>[Impeller] render empty filled paths without crashing. (flutter/engine#51713)
2024-03-27<EMAIL_ADDRESS>[Impeller] use optimal depth attachment, remove useless barrier. (flutter/engine#51723)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Closing to trigger a new roll.

Commit queue failed; closing this roll.


Cold/Flu: Worksite contact is not reflecting the name of the user registering for clinic

Background:
when a user who registered as “Bobby Brown”, goes back to edit, the registration has pulled his legal name information and not the actual worksite contact he entered

Steps to Reproduce:

[ ] go into the cold and flu for in TEST
[ ] register as a fictional character/preferred name for a worksite
[ ] open a new form look up the worksite check to see who is registered
Actual Behavior:
legal name is appearing
Expected Behaviour:
Preferred or entered name should appear
Environment: TEST

Heather Reports: I checked one of my registrations, I registered as “Minnie Mouse” but when I go to edit that reg, it pulls up that the worksite registered is Heather Bishop
While MOST people coming on to register their worksite contact will be registering themselves… some may be registering on behalf of someone else… and I certainly will be… so I wonder how this will show up on the reporting – I’ve included @Moffatt, Don PSA:EX here as well. Don, the DEV data you sent me this morning (snip of that below), doesn’t seem to show my registration for MINNIE MOUSE… but DONALD DUCK was the secondary… and the number of employees is 185, though the report line shows 85. Yikes?

Logic updated on the backend DB procedures on DEV/Test, will accept any changes for contacts, if email already exists will allow first/last names and phone to be updated.

yay thanks @mikeshi-bcgov I will move this over to Test /QA

Tested this in Test Environment and achieved expected behavior ✅
Snapshot of a fictional character name registered for the worksite -

Snapshot confirming that entered fictional name appears -

PO approve


Verbatium.Expression inlining

Currently expressions, passed as arguments to Verbatium.Expression is inlined inside expression. It is incorrect, as affect computing order, and , which is much worse, may access objects through this reference, which will not work if Verbatium.Expression use function inside.
I believe that all Verbatium.Expression arguments should be stored in temporary varaible.

Good points. You're right.


The in-game Pause Menu does not freeze the level timer

In Pizza Tower SR 2, when you were in the pause menu, the level timer froze and unfroze when you got out of the menu. But in the latest revision (SR5 Fix 1), the level timer keeps going in the pause menu. As of now, the latest version of Pizza Tower freezes the timer when in the pause menu, so this is most likely a bug within the port.

The behavior is consistent with the latest Pizza Tower version for me: the level timer pauses in the pause menu by default, keeps going if Speedrun Timer is enabled. Can you check if you happen to have it enabled on Switch?

Ah, I mistook that as a glitch when in reality I just changed the wrong setting. Thanks for correcting me!


add a e621 command

glaceon sex

i changed some of the code but im still adding it

Adding it rn,
Closed.


Add types and docs

Just saw this, it's already been resolved. Thanks.

Just saw this, it's already been resolved. Thanks.


Update version number in README

Current coverage is 75.42%

Merging #129 into master will not affect coverage as of ecab7f2

Powered by Codecov. Updated on successful CI builds.


Importing EML metadata into occurence resource

Never mind. Issue can be disregarded.

How did you solve it? I’d very much like it too if EML could be imported or updated remotely.

Hi Peter,
I saw on https://github.com/gbif/ipt/issues/955 that the resource can be created as a "metadata-only" one from an existing EML file, then 'cast' into a occurence dataset from the basic metadata/Type dropdown.
Cheers, Thomas

Thanks both.
Another option (the worst option, probably) is to copy the EML file directly into the IPT's data directory, and restart. That's probably only appropriate if the EML is based on an existing, known-good file.
Some code around this approach is in these repositories:

https://github.com/MattBlissett/ipt-batch-import
https://github.com/gbif/watchdog


Seed all the transpile calls in test.python.compiler.test_transpiler

to avoid flaky tests, seeding all the transpile calls in test.python.compiler.test_transpiler

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
11 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.003%) to 89.316%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/expr.rs
1
93.81%

crates/qasm2/src/lex.rs
4
91.94%

crates/qasm2/src/parse.rs
6
97.62%

Totals

Change from base Build<PHONE_NUMBER>:
-0.003%

Covered Lines:
59146

Relevant Lines:
66221

💛  - Coveralls

@Mergifyio backport stable/0.46


python311Packages.pyngrok: 7.1.5 -> 7.1.6

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.pyngrok is: A Python wrapper for ngrok
meta.homepage for python311Packages.pyngrok is: https://github.com/alexdlaird/pyngrok
meta.changelog for python311Packages.pyngrok is: https://github.com/alexdlaird/pyngrok/blob/7.1.6/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 7.1.6 with grep in /nix/store/bgi7qf4f66wg0898kw23jazpszsv0aj4-python3.11-pyngrok-7.1.6
found 7.1.6 in filename of file in /nix/store/bgi7qf4f66wg0898kw23jazpszsv0aj4-python3.11-pyngrok-7.1.6

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)

8 package rebuild(s)

First fifty rebuilds by attrpath
authentik
home-assistant-component-tests.twilio
python311Packages.meshcat
python311Packages.pyngrok
python311Packages.twilio
python312Packages.meshcat
python312Packages.pyngrok
python312Packages.twilio

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/bgi7qf4f66wg0898kw23jazpszsv0aj4-python3.11-pyngrok-7.1.6 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.pyngrok https://github.com/r-ryantm/nixpkgs/archive/9c634f72efc224b7015e73e6fde7e940ec71266f.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/9c634f72efc224b7015e73e6fde7e940ec71266f#python311Packages.pyngrok

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/bgi7qf4f66wg0898kw23jazpszsv0aj4-python3.11-pyngrok-7.1.6
ls -la /nix/store/bgi7qf4f66wg0898kw23jazpszsv0aj4-python3.11-pyngrok-7.1.6/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

14 packages built:

authentik
home-assistant-component-tests.twilio
python311Packages.meshcat
python311Packages.meshcat.dist
python311Packages.pyngrok
python311Packages.pyngrok.dist
python311Packages.twilio
python311Packages.twilio.dist
python312Packages.meshcat
python312Packages.meshcat.dist
python312Packages.pyngrok
python312Packages.pyngrok.dist
python312Packages.twilio
python312Packages.twilio.dist

Maintainer pings
cc @wegank for testing.

Done in #298645.


Duplicate key for transition group fragment when child has v-if

Version
3.2.33
Reproduction link
sfc.vuejs.org/
Steps to reproduce
Have a <template v-for> inside a <TransitionGroup>, with multiple children and one of those children has v-if. For example:
<template>
  <TransitionGroup>
    <template v-for="(item, idx) of ['A', 'B']" :key="item">

{{ idx }}: {{ item }}1

      <div v-if="idx < 1">{{ idx }}: {{ item }}2

    </template>
  </TransitionGroup>
</template>

What is expected?
Here the keys should be A0, A1 and B0.
What is actually happening?
But instead we get A0, A0 and B0.

Without the v-if everything works correctly and we get A0, A1, B0 and B1.
In the reproduction I have used a component for the children, so the generated key is easily visible in the devtools.
Related commit: https://github.com/vuejs/core/commit/4311dddfa72b405b20f469f8f219ec3027972f55
Related issues: #4718, #5360, #5392

The code in the link works fine

should be a bug

I don’t know how the key calculation for the v-if works, but maybe it would be good to allow defining the child keys manually, instead of using the index here.
Afaics the code can handle it in theory, but when I try to define the key on the parent template element as well as on each child, I get a compiler error:
SyntaxError: <template v-for> key should be placed on the <template> tag.

I expect, however, that the user’s expectation might be different depending on the situation.
That’s why I suggested allowing explicit keys for all raw children.

children component  with v-if  can be seted explicit key no warn

Ah, thank you for the tip, @iwusong. Setting a key on the v-if items is a good workaround.

explicit key on child v-if node is nice workaround, just need to be aware that a custom key of "number type" could still be duplicated with other default index key because the fundamental issue is caused by "number type keys on v-if node". So using it in types other than number should be good enough 👍


Add new theme: Monokai Pro Machine Theme!

This PR adds the Monokai Pro Machine variant, as can be seen here: https://monokai.pro/vscode
p.s. Click on the filter that says "Machine"

Here are some side-by-side comparisons of this PR's doom-monokai-machine-theme and the officially supported Monokai Pro Machine in Visual Studio Code. IMHO, they are really quite identical ;-)
My port in Emacs (doom-monokai-machine-theme)

Official Monokai Pro Machine theme in Visual Studio Code

Hey Ian! Isn't this already contemplated in #532?

@ema2159 Oh damn.... hahaha I completely missed that PR. Oh well. I'll close this PR in favor of #532 then :-)

No problem man haha! That one merge has been pending for some time. I should start reviewing these more quickly!
Also, if you feel your implementation may be better, you can PR that branch!


Update Go versions

Is your feature request related to a problem? Please describe.

Go version lifecycle updates.
Describe the solution you'd like

Update to test 1.15 and 1.16 since 1.13 and 1.14 are EOL.
Update prereq statement to 1.15 or 1.16.
Describe alternatives you've considered

Additional context

Also we should update the golangci version in the .travis.yml


docs: how to use s3 compliant alternatives

Document how to use S3-compliant alternatives using the endpoint field.
The feature was added in https://github.com/mautic/mautic/pull/11693

Hi @skippednote this repo is no longer used - could you please add it to the WIP docs at https://github.com/mautic/user-documentation?
Many thanks!


The Extension shows no bookmarks

Hi,
I have installed the extension but when I open the sidebar I can't find any bookmark.
I get the message: "Es ist kein Datenanbieter registriert, der Sichtdaten bereitstellen kann."
Translation: There is no data provider registered that can provide visibility data.
What do I need to do to access bookmarks?

 Please give more information about the error, such as screenshots.

Hello,
Thank you for your quick response.
Chrome is installed on my computer and set as the default browser:
Version 118.0.5993.118 (Official Build) (64-bit)
I also believe that the extension doesn't "connect" to Chrome.
When I open the sidebar this is all I see:
[cid:005cf2ed-d4ee-4ee4-b822-df1e340d1ec8]
What want you to see also?

Von: Huang Bingfeng @.>
Gesendet: Montag, 30. Oktober 2023 12:44
An: jackiotyu/vscode-browser-bookmark @.>
Cc: CodingFan72 @.>; Author @.>
Betreff: Re: [jackiotyu/vscode-browser-bookmark] The Extension shows no bookmarks (Issue #1)
Have you install chrome in your computer? Please give more information about the error, such as screenshots.
—
Reply to this email directly, view it on GitHubhttps://github.com/jackiotyu/vscode-browser-bookmark/issues/1#issuecomment-1785014231, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASFF4XJACBGQ53DPIXIG5A3YB6HKNAVCNFSM6AAAAAA6VY2CCCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBVGAYTIMRTGE.
You are receiving this because you authored the thread.Message ID: @.***>

Please let me know what platform you are using now.

I use Windows 10
[cid:99cd6ca2-e3ad-45c3-bc41-7de927033f7c]

Von: Huang Bingfeng @.>
Gesendet: Montag, 30. Oktober 2023 15:38
An: jackiotyu/vscode-browser-bookmark @.>
Cc: CodingFan72 @.>; Author @.>
Betreff: Re: [jackiotyu/vscode-browser-bookmark] The Extension shows no bookmarks (Issue #1)
Please let me know what platform you are using now.
—
Reply to this email directly, view it on GitHubhttps://github.com/jackiotyu/vscode-browser-bookmark/issues/1#issuecomment-1785359584, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASFF4XPYWMIVZNM27OBB2PLYB63XTAVCNFSM6AAAAAA6VY2CCCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBVGM2TSNJYGQ.
You are receiving this because you authored the thread.Message ID: @.***>

Hi,
Thanks to the ability to set the path manually, I can now access my bookmarks. 👍

This solves my problem.


Viewing image locks app

Hi,
When you open an image that someone has sent you, there is no way back to the main screen - you are locked looking at images, no back button is apparent and there is no possibility to click 'off the screen'.  The only way out is to force close the app.
Thanks

Version used is 0.4.2 on iOS 10

The way to close the image is to swipe it off the screen.  Agreed that providing an overlay menu on tap might be clearer though.

Ok, that function works but wasn't immediately obvious - swiping left/right just cycles all photos.  Thanks for the quick reply though!
On 17/07/2017 11:43:22, Matthew Hodgson<EMAIL_ADDRESS>wrote:
The way to close the image is to swipe it off the screen. Agreed that providing an overlay menu on tap might be clearer though.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub [https://github.com/vector-im/riot-ios/issues/1395#issuecomment-315721662], or mute the thread [https://github.com/notifications/unsubscribe-auth/AInI26xpP2_w5SfjQCEKZh5Lfp622AMaks5sOzrAgaJpZM4OZybY].


feat: create portfolio page and add the Pearl to it

@manzt let me know if you have any reccs to make this look a little better. I noticed that the image sometimes takes a while to load on the netlify preview but unsure if that's due to netlify or something w/ the image.

Yeah the image is kind of large at almost 2Mb. Try compressing with https://squoosh.app/ (prefer some lossy encoding - JPEG/WebP over PNG).


Circuit Breaker behavior in Polly v7 vs v8

Discussed in https://github.com/ThreeMammals/Ocelot/discussions/2083

Originally posted by anonimousspider June  1, 2024
In Polly v8, we have observed that the circuit breaker functionality is not working as expected. We have experienced issues where the circuit breaker does not trip or reset correctly, leading to inconsistent fault handling. Conversely, in Polly v7, the circuit breaker also exhibits problems, failing to operate smoothly in certain scenarios.
Circuit Breaker Not Tripping
Example
Suppose you have configured an Ocelot route with a circuit breaker policy to trip after three consecutive HTTP request failures:
Route Configuration:
{
  "Routes": [
    {
      "DownstreamPathTemplate": "/api/StudentIdentity/Verify ",
      "DownstreamScheme": "https",
      "DownstreamHostAndPorts": [
        {
          "Host": "localhost", "Port": 5001
        }
      ],
      "UpstreamPathTemplate": " api/student/Verify ",
      "UpstreamHttpMethod": [ "Get" ],
      "QoSOptions": {
        "ExceptionsAllowedBeforeBreaking": 3,
        "DurationOfBreak": 10000,
        "TimeoutValue": 5000
      }
    }
  ]
}

Configuration in Program.cs for V7:
services.AddLogging(logging =>
 {
     logging.ClearProviders();
     logging.AddConsole();

 });
 services.AddJwtAuthentication();
 services.AddOcelot().AddPollyV7();

Configuration in program.cs using Polly V8:
services.AddLogging(logging =>
 {
     logging.ClearProviders();
     logging.AddConsole();

 });
 services.AddJwtAuthentication();
 services.AddOcelot().AddPolly();

Expected Behaviour
During runtime, the downstream service fails five consecutive times. The circuit breaker should trip and stop the request to be forwarded , and move to open state as per configured.
Actual behavior
During runtime, the downstream service fails five consecutive times. Despite this, the circuit breaker does not trip and continues to forward requests, instead of moving to the open state after three failures as configured.
Scenario 1
When service response is delayed from the service configured in ocelot.
PollyV7: Its working fine
PollyV8: on applying pollyv8 in the gateway not Working.
Scenario 2
When service is giving 503 error response .
Polly v7 : Its working Fine
Polly v8: Not working.
Scenario 3
When Service is giving 404 error response.
Polly v7 : working fine.
Polly v8: Not working.

Can you please suggest, how to configure Polly v8 with the current Ocelot version 23.2.2?

@RaynaldM
I don't understand this issue description.
How did you verify the user scenarios?

Actual behavior
During runtime, the downstream service fails five consecutive times. Despite this, the circuit breaker does not trip and continues to forward requests, instead of moving to the open state after three failures as configured.

Have you test, check it out?
Why did you mark the issue as a hotfix?


fix typo

Terminater ->
Terminator

Thank you for this PR, but the name Terminater was chosen on purpose to follow the naming conventions for Go interfaces: https://go.dev/doc/effective_go#interface-names Of course, could also have gone with Terminator at that time, but we now have this interface name and I think it is fine to keep it and avoid unneeded breaking changes.
Nevertheless, thank you very much for your effort here :)

Thanks for the review!
Understood.