HADOOP-18920. RPC Metrics : Optimize logic for log slow RPCs

Description of PR
https://issues.apache.org/jira/browse/HADOOP-18920
HADOOP-12325 implement a capability where "slow" RPCs are logged in NN log.
Current processing logic is the "slow" RPCs are to be those whose processing time is outside 3 standard deviation.
However, in practice it is found that many logs of slow rpc are currently output, and sometimes RPCs with a processing time of 1ms are also declared as slow, this is not in line with actual expectations.
Therefore, consider optimize the logic conditions of slow RPC and add a logSlowRPCThresholdMs variable to judge whether the current RPCas slow so that the expected slow RPC log can be logger.
for logSlowRPCThresholdMs, we can support dynamic refresh to facilitate adjustments based on the actual operating conditions of the hdfs cluster.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 12s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
31m 36s

trunk passed

+1 :green_heart:
compile
18m 21s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
18m  1s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
4m 39s

trunk passed

+1 :green_heart:
mvnsite
3m 25s

trunk passed

+1 :green_heart:
javadoc
2m 45s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
3m  0s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
6m  6s

trunk passed

+1 :green_heart:
shadedclient
40m 19s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 32s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 14s

the patch passed

+1 :green_heart:
compile
16m 46s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
16m 46s

the patch passed

+1 :green_heart:
compile
16m  5s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
16m  5s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 20s

the patch passed

+1 :green_heart:
mvnsite
3m 32s

the patch passed

+1 :green_heart:
javadoc
2m 37s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
2m 52s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
6m 24s

the patch passed

+1 :green_heart:
shadedclient
39m 31s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 19s

hadoop-common in the patch passed.

+1 :green_heart:
unit
219m 59s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 28s

The patch does not generate ASF License warnings.

482m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6146/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6146

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux d1cc6a498735 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1cae2b0b4b08d19b573eea430b42c5d70f099f6c

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6146/1/testReport/

Max. process+thread count
3563 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6146/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Hi @goiri @ayushtkn sirs，please help me take a look it again when you have free time.
any other suggestions for using the log slow RPC capability?  Thanks a lot~

There is a conflict with the trunk branch, force-pushed it.

Hi @xinglin I have modified pr based on your helpful suggestions, please help me to review it again. Thanks a lot~

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 29s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 52s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 38s

trunk passed

+1 :green_heart:
compile
10m 37s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
9m 29s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
2m 22s

trunk passed

+1 :green_heart:
mvnsite
2m 19s

trunk passed

+1 :green_heart:
javadoc
1m 59s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
2m  8s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 48s

trunk passed

+1 :green_heart:
shadedclient
22m 37s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 22s

the patch passed

+1 :green_heart:
compile
9m 54s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
9m 54s

the patch passed

+1 :green_heart:
compile
9m 38s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
9m 38s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
2m 24s

the patch passed

+1 :green_heart:
mvnsite
2m 19s

the patch passed

+1 :green_heart:
javadoc
1m 51s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
2m  9s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 59s

the patch passed

+1 :green_heart:
shadedclient
22m 47s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m  7s

hadoop-common in the patch passed.

+1 :green_heart:
unit
196m 59s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  1s

The patch does not generate ASF License warnings.

365m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6146/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6146

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux a2053b2be6eb 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d3cf97468017bb901ec6d70843fa500386008f34

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6146/2/testReport/

Max. process+thread count
3256 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6146/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 51s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
36m 24s

trunk passed

+1 :green_heart:
compile
18m 31s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
16m 57s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
4m 44s

trunk passed

+1 :green_heart:
mvnsite
3m 12s

trunk passed

+1 :green_heart:
javadoc
2m 26s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 32s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
6m  6s

trunk passed

+1 :green_heart:
shadedclient
41m 42s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 15s

the patch passed

+1 :green_heart:
compile
19m 15s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
19m 15s

the patch passed

+1 :green_heart:
compile
18m 44s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
18m 44s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
5m 34s

the patch passed

+1 :green_heart:
mvnsite
3m 27s

the patch passed

+1 :green_heart:
javadoc
2m 55s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 40s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
6m 54s

the patch passed

+1 :green_heart:
shadedclient
43m 24s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 31s

hadoop-common in the patch passed.

-1 :x:
unit
256m 13s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 40s

The patch does not generate ASF License warnings.

533m 32s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.balancer.TestBalancer

hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6146/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6146

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 6e2ec29d167e 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d3cf97468017bb901ec6d70843fa500386008f34

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6146/3/testReport/

Max. process+thread count
2326 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6146/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Hi @xinglin I have modified pr based on your suggestions, please help me to review it again. Thanks a lot~

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 57s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 19s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
32m  7s

trunk passed

+1 :green_heart:
compile
17m 17s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
16m  9s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
4m 24s

trunk passed

+1 :green_heart:
mvnsite
3m 35s

trunk passed

+1 :green_heart:
javadoc
2m 46s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 54s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
6m  7s

trunk passed

+1 :green_heart:
shadedclient
36m 25s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 33s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 11s

the patch passed

+1 :green_heart:
compile
16m 28s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
16m 28s

the patch passed

+1 :green_heart:
compile
15m 53s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
15m 53s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 22s

the patch passed

+1 :green_heart:
mvnsite
3m 32s

the patch passed

+1 :green_heart:
javadoc
2m 42s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
2m 54s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
6m 28s

the patch passed

+1 :green_heart:
shadedclient
37m 10s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 34s

hadoop-common in the patch passed.

+1 :green_heart:
unit
260m 11s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 22s

The patch does not generate ASF License warnings.

514m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6146/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6146

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux e7721cfc815b 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9e58e30509865367368d7b63c7d97289c80b4771

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6146/4/testReport/

Max. process+thread count
3506 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6146/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Thanks @xinglin help me review.
For slow RPC threshold value, users should config this to an appropriate value for their clusters .
current to use 10 seconds as the default value is a reference value, I also considered whether I need need to use 0 as the default value?

Hi @ayushtkn @Hexiaoqiao @ZanderXu sirs any suggestions for this PR?
please help me take a look it again when you have free time?  Thanks a lot~

@goiri in case you can help merge it. thanks,

Update PR.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 55s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
31m 48s

trunk passed

+1 :green_heart:
compile
17m  3s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
15m 51s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
4m 31s

trunk passed

+1 :green_heart:
mvnsite
3m 29s

trunk passed

-1 :x:
javadoc
1m 20s
/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs in trunk failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

+1 :green_heart:
javadoc
2m 56s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
6m  7s

trunk passed

+1 :green_heart:
shadedclient
36m 20s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 33s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 11s

the patch passed

+1 :green_heart:
compile
15m 56s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
15m 56s

the patch passed

+1 :green_heart:
compile
15m 18s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
15m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 28s

the patch passed

+1 :green_heart:
mvnsite
3m 29s

the patch passed

-1 :x:
javadoc
1m 22s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

+1 :green_heart:
javadoc
2m 58s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
6m 21s

the patch passed

+1 :green_heart:
shadedclient
36m 23s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
19m 20s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
unit
222m 13s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 18s

The patch does not generate ASF License warnings.

474m  9s

Reason
Tests

Failed junit tests
hadoop.util.curator.TestSecureZKCuratorManager

hadoop.util.curator.TestZKCuratorManager

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6146/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6146

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux e21ad81eee94 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4f287676b45c3f0569549e3df0246219b38c739d

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6146/5/testReport/

Max. process+thread count
3554 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6146/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
16m 46s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 50s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
30m 53s

trunk passed

+1 :green_heart:
compile
17m  0s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
15m 24s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
4m 25s

trunk passed

+1 :green_heart:
mvnsite
3m 28s

trunk passed

-1 :x:
javadoc
1m 21s
/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs in trunk failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

+1 :green_heart:
javadoc
2m 56s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
6m  2s

trunk passed

+1 :green_heart:
shadedclient
35m 50s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 33s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  6s

the patch passed

+1 :green_heart:
compile
15m 42s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
15m 42s

the patch passed

+1 :green_heart:
compile
15m 54s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
15m 54s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 20s

the patch passed

+1 :green_heart:
mvnsite
3m 28s

the patch passed

-1 :x:
javadoc
1m 21s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

+1 :green_heart:
javadoc
2m 54s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
6m 27s

the patch passed

+1 :green_heart:
shadedclient
36m 50s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
19m 46s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

-1 :x:
unit
264m 17s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 22s

The patch does not generate ASF License warnings.

531m 21s

Reason
Tests

Failed junit tests
hadoop.util.curator.TestSecureZKCuratorManager

hadoop.util.curator.TestZKCuratorManager

hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6146/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6146

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 0743710a4978 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f63ab370a6506587882f2941f5f2c5a60dfffc8e

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6146/6/testReport/

Max. process+thread count
3283 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6146/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 21s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
31m 57s

trunk passed

+1 :green_heart:
compile
17m 28s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
16m 37s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
4m 36s

trunk passed

+1 :green_heart:
mvnsite
3m 26s

trunk passed

-1 :x:
javadoc
1m 24s
/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs in trunk failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

+1 :green_heart:
javadoc
2m 45s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
6m 21s

trunk passed

+1 :green_heart:
shadedclient
38m 39s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 14s

the patch passed

+1 :green_heart:
compile
17m 35s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
17m 35s

the patch passed

+1 :green_heart:
compile
16m 59s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
16m 59s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 38s

the patch passed

+1 :green_heart:
mvnsite
3m 23s

the patch passed

-1 :x:
javadoc
1m 21s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

+1 :green_heart:
javadoc
2m 57s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
6m 42s

the patch passed

+1 :green_heart:
shadedclient
39m 58s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
19m 57s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
unit
219m 31s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 24s

The patch does not generate ASF License warnings.

481m 58s

Reason
Tests

Failed junit tests
hadoop.util.curator.TestSecureZKCuratorManager

hadoop.util.curator.TestZKCuratorManager

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6146/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6146

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 0684a6420a10 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5f8da4bcb97ada0a126a1eb39a8a384d7d410833

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6146/7/testReport/

Max. process+thread count
3264 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6146/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

The failed unit test seems unrelated to the change.
Hi @goiri @xinglin @ZanderXu please help me take a look it again , thanks.

These two unit tests seem to be failed consistently during the last three builds. It is a bit concerning.
@haiyang1987 could you confirm they are already failing in trunk as well? Run these two unit tests for 10 times in trunk without your change and see if we can see failed executions for these two unit test.
hadoop.util.curator.TestSecureZKCuratorManager
hadoop.util.curator.TestZKCuratorManager

Thanks @xinglin for your comment.
Yes, the trunk branch would have such failed before, perhaps related to the Zookeeper version, but the latest trunk branch has been fixed, this time I think these  tests will pass.  let's wait for the build to complete have a look.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m 12s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
31m 54s

trunk passed

+1 :green_heart:
compile
17m 11s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
15m 59s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
4m 32s

trunk passed

+1 :green_heart:
mvnsite
3m 24s

trunk passed

-1 :x:
javadoc
1m 21s
/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs in trunk failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

+1 :green_heart:
javadoc
2m 53s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
6m  1s

trunk passed

+1 :green_heart:
shadedclient
36m 16s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 33s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  9s

the patch passed

+1 :green_heart:
compile
16m 34s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
16m 34s

the patch passed

+1 :green_heart:
compile
15m 24s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
15m 24s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 17s

the patch passed

+1 :green_heart:
mvnsite
3m 18s

the patch passed

-1 :x:
javadoc
1m 22s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

+1 :green_heart:
javadoc
2m 54s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
6m 19s

the patch passed

+1 :green_heart:
shadedclient
37m  4s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 21s

hadoop-common in the patch passed.

+1 :green_heart:
unit
259m  4s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  6s

The patch does not generate ASF License warnings.

512m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6146/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6146

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux ef7382339a48 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0c2de2554ac4c5a4bc6663741f71e969ecd378c1

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6146/8/testReport/

Max. process+thread count
3108 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6146/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Ran these two unit tests for 20 times and none failed. change lgtm.
[xinglin@xinglin-ld1 hadoop-common]$ grep "Tests run" ZKCurator-fix.log
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.386 s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.124 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.391 s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.033 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.615 s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.194 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.434 s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.034 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.585 s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.07 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.485 s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.027 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.441 s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.289 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.516 s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.03 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.498 s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.389 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.439 s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.197 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.516 s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.961 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.463 s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.027 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.608 s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.113 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.498 s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.21 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.449 s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.149 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.483 s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.121 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.508 s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.099 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.466 s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.209 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.494 s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.025 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.515 s - in org.apache.hadoop.util.curator.TestZKCuratorManager
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.011 s - in org.apache.hadoop.util.curator.TestSecureZKCuratorManager
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0

[xinglin@xinglin-ld1 hadoop-common]$ git br
* HADOOP-18920
[xinglin@xinglin-ld1 hadoop-common]$ git log
commit ff8f32fff5f4f06853dedfb09978bb870e784131 (HEAD -> HADOOP-18920)
Author: Haiyang.Hu<EMAIL_ADDRESS>Date:   Sat Oct 21 13:51:46 2023 +0800

    HADOOP-18920. Modify patch based on comments

commit fd36114cce288d965f5501b4f1015a3c185ab908
Author: Haiyang.Hu<EMAIL_ADDRESS>Date:   Thu Oct 19 13:12:27 2023 +0800

    trigger ci

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 45s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
37m 19s

trunk passed

+1 :green_heart:
compile
19m 10s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
18m  5s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
4m 42s

trunk passed

+1 :green_heart:
mvnsite
3m 14s

trunk passed

-1 :x:
javadoc
1m 16s
/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs in trunk failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

+1 :green_heart:
javadoc
2m 33s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
6m 13s

trunk passed

+1 :green_heart:
shadedclient
44m 11s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 36s

the patch passed

+1 :green_heart:
compile
20m 41s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
20m 41s

the patch passed

+1 :green_heart:
compile
19m 33s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
19m 33s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
5m 48s

the patch passed

+1 :green_heart:
mvnsite
3m 56s

the patch passed

-1 :x:
javadoc
1m 26s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

+1 :green_heart:
javadoc
2m 45s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
7m 14s

the patch passed

+1 :green_heart:
shadedclient
44m  9s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
20m  0s

hadoop-common in the patch passed.

-1 :x:
unit
249m 55s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 11s

The patch does not generate ASF License warnings.

537m 53s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6146/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6146

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux c7c6c93121a8 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0c2de2554ac4c5a4bc6663741f71e969ecd378c1

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6146/1/testReport/

Max. process+thread count
2103 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6146/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Thanks @xinglin for your detailed review.
Failed UT: hadoop.hdfs.TestRollingUpgrade, it's no problem when i run it locally.

Thank @haiyang1987 for your report and thanks @xinglin for your review.
Merged

Thanks @xinglin @ZanderXu for your review and merge.


While trying to make a simple array, I get a nested array instead

Describe what you want to achieve.
I'm trying to make a simple JSON array for my custom class

Describe what you tried.

struct A{
  int c1;
  int c2;
};

void to_json( json& JSON, const A& a ){
  JSON = { A.c1, A.c2 };
}

A myA{ 21, 22};

auto json = nlohmann::json{ myA };
// Gives me [[ 21, 22]]
// Would like it to return [21, 22]

I've also tried (from #1013)
void to_json( json& JSON, const A& a ){
  JSON = std::forward_list< int >{ A.c1, A.c2 };
}

and got the same response.

Describe which system (OS, compiler) you are using.
MacOS 10.14, LLVM 3.8

Describe which version of the library you are using (release version, develop branch).
master branch, commit c0d511ea500e698061a4b288bd77ce43bd76fa70 (okay, it's kind of old)

The library interprets the braces in
auto json = nlohmann::json{ myA };

as array. Try replacing this by
nlohmann::json json = myA;

This works, but I'm struggling to understand the difference. Why aren't the braces interpreted as brace initialization?

I think it is interpreted as an initializer list, and the corresponding (implicit) constructor creates an array.


fix(datastore): skip disabled nodes in ValidateV2DataEngineEnabled

Which issue(s) this PR fixes:
Issue https://github.com/longhorn/longhorn/issues/9319
What this PR does / why we need it:
So we can enable the v2 data engine without needing to allocate hugepages on disabled nodes

@mergify backport v1.7.x


log1pexp

System information

TensorFlow version (you are using): 2.0
Are you willing to contribute it (Yes/No): -

Describe the feature and the current behavior/state.
Please add log1pexp(x) function to math. This computes log(1 + exp(x) in a numerically stable way. Here is a Python implementation that I am currently using:
@tf.function
def log1pexp(x):
    return tf.where(tf.less(x, 9),
                    tf.math.log1p(tf.exp(x)),
                    tf.where(tf.less(x, 16),
                             x + tf.math.exp(-x),
                             x))

But a native C version will probably be faster.
Who will benefit with this feature?
This function is useful when programming RBM models, for instance. But it has many other uses.

@cossio
you can use tf.math.softplus function! 🎉
https://www.tensorflow.org/api_docs/python/tf/math/softplus?version=stable

@pshiko Thanks! I guess I was used to looking for this under the name log1pexp.


Layer compatibility with warrior

I switched to warrior branch yet I've layer compatibility issue. Bitbake says the layer is not compatible with warrior.

Need to update layer.conf file, but warrior is EOL now. I would suggest using dunfell instead which is LTS and supported by meta-conan.


Create SMP on target test framework.

Create SMP on target test framework.
Description

Create SMP on target test framework. Including test folders, CMakeLists.txt, template, and first test case.
Test Steps

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ActoryOu Thanks for the explanations. This PR LGTM.

Can this test detect the problem that the port fails to launch cores other than tick core?

Yes, I think so. If the core fail to be launched, it won't be able to set pxCurrentTCBs[ coreID ] correctly. So the state of task is
NOT eRunning. Furthermore, There is a test case named "Schedule Affinity", it checks if all tasks running on their own cores. We can verify the SMP by combining these two test cases.

The EverRunning tasks do nothing but busy looping. How can we know this test function is run by other cores?

We check the if the state is eRunning, which means it's running at the same time on the other cores. We don't really care about what core is the tasks running on. We just check if all tasks created by the test cases are all in eRunning on all other cores.


Angular to iOS video rendering.

I have an issue rendering video track generated from Angular Twilio code in this iOS demo app. I am using the latest Twilio version and latest code base of this demo app.
Once I connect to the room, audio renders perfectly but not the video ( totally blank ). I have tried with all possibilities of videoCodecs.
The code works perfectly when rendering video track from Android, React , iOS to iOS. but not from Angular..
Please let me know if I need to provide any other information.

Hi @Srihari-Talentbridge,
I think the problem may be the track name. The iOS is expecting the track name for the camera to be camera. I suggest making sure the Angular code is setting the track name to this. You might want to reference TrackName.swift in the iOS app. Please let me know if that helps.

Hi @Srihari-Talentbridge,
I'm going to close this issue but feel free to add more comments if this is still a problem.


Bug fix in patch CVE-2024-5535 in openssl

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] If you are adding/removing a .spec file that has multiple-versions supported, please add @microsoft/cbl-mariner-multi-package-reviewers team as reviewer (Eg. golang has 2 versions 1.18, 1.21+)
[ ] Ready to merge

Summary

What does the PR accomplish, why was it needed?
Bug fix in patch CVE-2024-5535 in openssl.
Made sure that the patch gets applied correctly.
Change Log

CVE-2024-5535

Does this affect the toolchain?

NO
Associated issues

NA

Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2024-5535

Test Methodology

Pipeline build id: xxxx

Auto cherry-pick results:

main :x: -> https://github.com/microsoft/azurelinux/pull/9961

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=613689&view=results


Support for Every Other row in tables

My team ran into a critical issue in production where our table needed ever other row shading for user clarity. Unfortunately, I wasn't able to use this plugin to put a red box around every other row in the table to show our UI designer what needed to be "colored in" with a low opacity color.
Please help!

Can you submit some design mockups of what you’re looking for?
From: Justin Bahn @.>
Reply-To: joshterrill/justin-bahn-design-extension @.>
Date: Wednesday, March 30, 2022 at 10:59 AM
To: joshterrill/justin-bahn-design-extension @.>
Cc: Subscribed @.>
Subject: [joshterrill/justin-bahn-design-extension] Support for Every Other row in tables (Issue #7)
My team ran into a critical issue in production where our table needed ever other row shading for user clarity. Unfortunately, I wasn't able to use this plugin to put a red box around every other row in the table to show our UI designer what needed to be "colored in" with a low opacity color.
Please help!
—
Reply to this email directly, view it on GitHubhttps://github.com/joshterrill/justin-bahn-design-extension/issues/7, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABI6XNIXUJYK6EAZZ44YKO3VCSJARANCNFSM5SCXFLHA.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Fixes[#5870] Card UX Improvement Mobile

Fixes Issue
Closes #5870

Changes proposed
Fixed it by wrapping whole card Under the Link Component.

Check List (Check all the applicable boxes)

[X] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

hey @NiazMorshed2007 i closed this and made a new pr #6671


Bump to 0.54.0, update changelog

r? @Eh2406
(rust-highfive has picked a reviewer for you, use r? to override)

@bors: r+

:pushpin: Commit 64aa6369b880d6c3ef9116ecb22bfb1bd85b8a57 has been approved by alexcrichton

:hourglass: Testing commit 64aa6369b880d6c3ef9116ecb22bfb1bd85b8a57 with merge beff1c959bf62cd4cd4d2da426c51e1409446017...

:sunny: Test successful - checks-actions
Approved by: alexcrichton
Pushing beff1c959bf62cd4cd4d2da426c51e1409446017 to master...


Localizable

Hello all !
In addition to my PR https://github.com/refinery/refinerycms-i18n/pull/51
I suggest this solution to add localized routes on refinerycms engine.
It will be great if the ActionDispatch::Routing::Mapper::localizable method will be directly added in refinerycms core to avoid duplicate code.
No need to fork route_translator with this solution :)
@parndt @simi

@bricesanchez do you still like this solution?

@parndt i will check this soon but i always need this feature.


⚠ Bofrost.nl has degraded performance

In 863cdd6, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1330 ms

Resolved: Bofrost.nl performance has improved in 65a4039.


Bump the transparent_image dependency to 1.0

See https://github.com/brianegan/transparent_image/issues/3

fixed in 0.7.0


MacOS: Could not move terminal into editor area after first move

Does this issue occur when all extensions are disabled?: Yes

Version: 1.58.0
Commit: 2d23c42a936db1c7b3b06f918cde29561cc47cd6
Date: 2021-07-08T06:54:17.694Z
Electron: 12.0.13
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 20.5.0
Steps to Reproduce:

Open terminal panel
Move first terminal into editor area
Open terminal panel again
Terminal profile name & its icon disappeared

Can you attach a gif?

oh I see. the single terminal tab item isn't showing up when the panel is opened.

I believe this is already fixed, can you see if you can reproduce in the Insiders build?

I think this was fixed with https://github.com/microsoft/vscode/issues/92649, let's consider for the recovery build if we are doing one.

It hasn't fixed yet!
i upgraded vsCode to version 1.58.1
did you fix this issue in this update or it has fixed in insider release?

I believe this is already fixed, can you see if you can reproduce in the Insiders build?

i don't have insider version, and i don't wanna install it (sorry, may be my sentences are a little like angry person but it's not 😅)


⚠ Bofrost.de has degraded performance

In 72ef744, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 845 ms

Resolved: Bofrost.de performance has improved in 6cdeb8b after 26 minutes.


Buzzers microcontroller replacement :)

Replacing the Buzzers microcontroller similarly to how you did the Lightbar would be wonderful.  My wife uses it in her practice and her clients typically have opted for the Buzzers rather then the Lightbar, however having both Lightbar and Buzzers available would be great.  Current pricing for Teensy 4.0 units here are priced extremely high.

Hey, I just added new firmware sources and updated the documentation with microcontroller replacements for the buzzers. :-)

Thank you!  Your efforts are greatly appreciated.


::selection for css selection styling

::selection for css selection styling
http://www.w3schools.com/cssref/sel_selection.asp

This issue was imported from Google Moderator
Moderator votes: +10
Issue added by Beba on 2013-02-10
To vote this issue up or down, simply include +1 or -1 in your comment.

http://caniuse.com/#feat=css-selection


Dragonrage: Watch acharya.uz

Dragonrage requests the watch of the watch_keyword acharya\.uz. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

acharya\.uz has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by cigien in Charcoal HQ


Error in PhysicsPlayer.cs

I found a bug in line 446 of PhysicsPlayer.cs
The bug was introduced in an edit made to it a few days ago. "moy" should become "mox", as shown below.
Line 446 now says:
if ((my == 0 && moy != 0) || (speedY < 0 && my > 0) || (speedY > 0 && my < 0) || ItemId.isClimbable(current))
But it should say:
if ((my == 0 && mox != 0) || (speedY < 0 && my > 0) || (speedY > 0 && my < 0) || ItemId.isClimbable(current))

Thanks, fixed!

I think you made an error fixing the bug. You made the change at line 409 instead of line 446.
It is important for line 409 to say:
if ((mx == 0 && moy != 0) || (speedX < 0 && mx > 0) || (speedX > 0 && mx < 0) || ItemId.isClimbable(current))
And line 446 should say:
if ((my == 0 && mox != 0) || (speedY < 0 && my > 0) || (speedY > 0 && my < 0) || ItemId.isClimbable(current))

Oh true, fixed


Bug: Last log lines of run are not fetched

When pipeline status is changed to finished the code stops polling for latest logs. This leads to situation where last log lines may not be fetched. After task status changes to "finished" we should fetch the logs one last time.

Fixed.


Kafka exception fix for #4681

fix for issue #4681
apologises for all the merge commits , which are from various verification tests.

@wbittles - Thanks Billy looks like a sensible approach.

@grahamwallis I think you need to merge as Billy does not have authority yet.

Fixes #4681


Hou: fix ls() Avoid hou.PermissionError when iterating some types of locked nodes

Fixes some cases where ls() would fail due to PermissionErrors where Houdini isn't allowed to iterate into specific locked nodes/HDAs as reported by Desmond on Discord.
I had this fixed before so I've taken the latest code I had in place for that.
Note that this also includes code changes related to this commit that I had done outside of OpenPype before. That does mean that it technically iterates more nodes (also those outside of /obj) but it shouldn't pose an issue.

as this was moved to openpype with pypeclub/OpenPype#2631 I am closing it.


Please create a release (with jar file) for 2.1.9

The last release is 2.1.8, but the last tag is 2.1.9.

done

Latest tag is 2.1.10 but latest release is called 2.1.9 and has commits up to 2.1.10.
Not sure what's going on.
You should probably have a standard release flow instead of doing things manually.


Auto Indent,failure

Issue Type: Feature Request
Auto Indent, which seems to occasionally fail, is worse under HTML than it was when it wasn't used, and is restored after a reboot
VS Code version: Code 1.38.1 (b37e54c98e1a74ba89e03073e5a3761284e3ffb0, 2019-09-11T13:31:32.854Z)
OS version: Darwin x64 18.6.0

/needsMoreInfo
Is it feature request or a bug?
Is it reproducible with extensions disabled?
Could you provide examples of code that causes problem and screenshot of result?


ENH: stats: simplify keepdims additions to decorator

Reference issue
scipy/scipy#15478
What does this implement/fix?
Simplifies additions to decorator for adding keepdims functionality.
Additional information
From the idea that result_unpacker is supposed to ensure that the separate "outputs" of a function are elements of a sequence, the rest just falls into place.
Maybe we should change the name of result_unpacker?  How abouttuplizer (i.e. "thing that turns something into a tuple")?

Thanks, @mdhaber for the help!

Maybe we should change the name of result_unpacker? How abouttuplizer (i.e. "thing that turns something into a tuple")?

To me, result_unpacker conveys the same meaning as tuplizer. But tuplizer sounds good too, more explicit. I will make the change on the main PR.


Don't use api_version stuff on static builds

This drastically reduces the size of the binary in some cases where api_version
was heavily used, such as flows with several node types.

Merged


Excessive Lava Turtle Spawns

Lava Turtles spawn way to often in the nether .

Not sure you got the right mod, Nether Core doesn't have any Lava Turtles.

Oh, sorry, I meant to report that in the NetherEx Mod issue.


Fix precompilation errors with Julia 1.3

Currently precompilation on Julia 1.3 errors even though Makie 0.15.0 states that it is compatible with Julia 1.3. This PR fixes the issue which was introduced in https://github.com/JuliaPlots/Makie.jl/pull/1118 and adds CI tests with Julia 1.3 to avoid regressions in the future.

The test errors are caused by GridLayoutBase, more concretely by https://github.com/jkrumbiegel/GridLayoutBase.jl/blob/b514330a891bfaabc809d8742ee596f9206c0e78/src/gridlayout.jl#L1346.

I opened a PR: https://github.com/jkrumbiegel/GridLayoutBase.jl/pull/22

Hmm, it seems GridLayoutBase 0.6.1 which contains the fix is not used in the tests.

Makie tests pass with Julia 1.3 :tada: It depends on GeometryBasics 0.4 (and compatible versions of GridLayoutBase and MeshIO) though, which causes many deprecation warnings in the tests. Even though they are not user facing, we should probably fix them first, either in this PR or in https://github.com/JuliaPlots/Makie.jl/pull/1132.

Cool, yeah we should really merge that PR!

@knuesel is on vaccation, but maybe we could also renew that PR with the given script

I opened https://github.com/JuliaPlots/Makie.jl/pull/1252.

Oh damn... Seems like GeometryBasics also isn't 1.3 ready anymore? :D

It is, and it works successfully in the Makie, CairoMakie, and WGLMakie tests. I am a bit surprised about these test failures with GLMakie - it worked before we eliminated the deprecation warnings yesterday :smile:

I think this line somehow triggers to fall back to the latest registered Makie version, and not the locally dev'ed one:
https://github.com/devmotion/Makie.jl/blob/dw/precompile_julia13/GLMakie/test/runtests.jl#L10
ERROR: LoadError: Unsatisfiable requirements detected for package GeometryBasics [5c1252a2]:
 GeometryBasics [5c1252a2] log:
 ├─possible versions are: [0.1.0-0.1.3, 0.2.0-0.2.15, 0.3.0-0.3.13, 0.4.0-0.4.1] or uninstalled
 ├─restricted to versions * by ReferenceTests [d37af2e0], leaving only versions [0.1.0-0.1.3, 0.2.0-0.2.15, 0.3.0-0.3.13, 0.4.0-0.4.1]
 │ └─ReferenceTests [d37af2e0] log:
 │   ├─possible versions are: 0.1.0 or uninstalled
 │   └─ReferenceTests [d37af2e0] is fixed to version 0.1.0
 ├─restricted to versions 0.4.1-0.4 by GLMakie [e9467ef8], leaving only versions 0.4.1
 │ └─GLMakie [e9467ef8] log:
 │   ├─possible versions are: 0.4.5 or uninstalled
 │   └─GLMakie [e9467ef8] is fixed to version 0.4.5
 └─restricted by compatibility requirements with Makie [ee78f7c6] to versions: 0.3.5-0.3.13 — no versions left
   └─Makie [ee78f7c6] log:
     ├─possible versions are: [0.9.0-0.9.6, 0.10.0, 0.11.0-0.11.2, 0.12.0, 0.13.0-0.13.14, 0.14.0-0.14.2, 0.15.0-0.15.1] or uninstalled
     ├─restricted to versions * by ReferenceTests [d37af2e0], leaving only versions [0.9.0-0.9.6, 0.10.0, 0.11.0-0.11.2, 0.12.0, 0.13.0-0.13.14, 0.14.0-0.14.2, 0.15.0-0.15.1]
     │ └─ReferenceTests [d37af2e0] log: see above
     └─restricted to versions 0.15.1 by GLMakie [e9467ef8], leaving only versions 0.15.1
       └─GLMakie [e9467ef8] log: see above

Note the:
restricted by compatibility requirements with Makie [ee78f7c6] to versions: 0.3.5-0.3.13 — no versions left (GeometryBasics)

But I'm not really sure why this works for the other backends, which should do exactly the same...
Maybe the registry is queried by the Pkg command and its this bug that it only finds older versions?

I made the GLMakie test environment similar to the one of WGLMakie and removed the submodule references to Makie, GeometryBasics, and FileIO and instead loaded them explicitly. It seems this fixed the test error (at least no errors so far).

Yay, thanks for all the effort :D

Is it possible to release a new version of Makie with the fixes for Julia 1.3? I would like to support Makie 0.15 in AbstractGPsMakie without dropping 1.3 :slightly_smiling_face:


Does this work on SNO without LVM Operator?

Currently it seems like ODF Operator Console does not work on SNO.
Does this repo provide a way to properly get it working?

SNO?


Add container-fluid to banner row to prevent overflow

The last PR had a width overflow in the banner. This PR fixes it.

This was what it looked like, the overflow would show a horizontal scroll bar, an oversight on my part.


How to add your personal locale and date format

Make this datetimepicker more usefull: add location and dateformat
Solution:
Connect moment-with-locales.js  instead moment.js
and put next changes to lib datetimepicker.js:
 'use strict';
  moment.locale('ru'); // insert your locale parameter
  angular.module('ui.bootstrap.datetimepicker', [])

and format returned value:
setTime: function setTime(unixDate) {
   var tempDate = new Date(unixDate);
   var newDate = moment(tempDate).format("YYYY-MM-DD HH:mm:ss");  //use your format by using momentJs

exapmle:

Hope it helps.

Interesting approach.
There are two potential issues with this approach.

If the user types in the input box manually (not using picker), they may not enter a valid date
The value in the model is now a string, not a date - there is some value in allowing the view format to vary independently of the model format.  The view format is out-of-scope for this directive but I will be providing an example of how to do store a date but display a formatting string (hopefully today!)

Yes, it's problem)
Thank you. Think it is actually issue of datetimepicker

Can you have a look at this directive https://github.com/dalelotts/angular-date-time-input?
Using it with the datetimepicker should solve your issue.


[FEATURE REQ] Enhance Github Action to support update version for both Spring Boot 2 and Spring Boot 3

Context
Now we have GitHub action to auto-update the latest Spring-Boot and Spring-Cloud versions, and it only works for Spring-Boot 2.x.x on Azure/main branch.
Since Spring-Boot publishes the 3.0.0 version, we need to support it in our feature/spring-boot-3 branch.
Goal
Enhance Github Action to support updated version for both Spring Boot 2 and Spring Boot 3

https://github.com/Azure/spring-cloud-azure-tools/pull/15

Closing this now for SB3 has been merged back to the main branch. #41131


Dialplan Refactor & E2E-Tests

Coverage increased (+2.2%) to 100.0% when pulling 3eb84c987cba48bddcf890ce154c48be9678010f on dialplan into 756ba088379266a13ddfeb427ef8ba41f0169fe3 on master.

Coverage increased (+2.2%) to 100.0% when pulling 73023823a297611686a4abe8cfe9cdbbdd550285 on dialplan into 0f7d64bbc9dbfc17a08294a7f41ee475c928bb4d on master.


How reject uploading after checking mimetype

Hi, Thanks for Repository.
What is the best efficient way to prevent uploading by checking mimetype (or even filename)?
This is my resolver.
resolve: async (obj, {avatar}, ctx) => {
        try {
            const {stream, filename, mimetype, encoding} = await avatar;
            if (mimetype !== 'image/png') {
                console.log('try to close');
                stream.emit('finish');
                return {};
            }
            let { id, path } = await store.itNow({stream, filename});
            return {id, path, filename, mimetype, encoding};
        }
        catch (e) {
            console.log('error', e);
            return {};
        }
    },

After uploading a non 'image/png', I got no response.
Im using apolloUploadKoa

It's a good question, and the answer depends on the situation. If you have multiple files and you don't want one bad one to cancel the entire request, you can use stream.resume() to waste the file.
I'm not sure the best way to immediately cancel the uploads to make an early response, but I imagine it may differ depending if you use Koa or Express. There should be a good way to do it though; this was one of the strong use cases for moving to a stream based API.
Perhaps someone can help? Eventually I'll have to work this answer out for myself; once I start implementing file uploads in my current project.

I am using express and I try to stream.destroy() but it failed, busboy keeps working on the remaining data and cause an error. (push after EOF, something like that). Also tried stream.pause before destroy, same result.
It will be great if it can stop the upload immd.

any new IDEA? :)

Also having this problem. I'd like to bail out without consuming the stream if the mimetype does not match an expected set of types.

Hey @nicoosokhan, this will be fixed when #81 gets finished. In a nutshell, we can't respond in HTTP 1.1 until the request is finished, so each file stream needs to be fully consumed.
The approach I'm taking in #81 is to buffer all uploads to the filesystem (using temp files) instead of propagating backpressure up to the network. This will also make it much simpler, as you can ignore one upload without blocking another one.
@nicoosokhan once this is merged, you can simply ignore the stream, and the temp files will get cleaned up eventually. If you want to prevent an accumulation of temp files, you can simply call:
stream.destroy()`

where you have stream.emit('finish');


Edit homepage content

Edit the homepage content to match client's requirements

[ ]  Update alter text

[ ]  Update static content

[ ]  Update collaborations

[x]  Add button to see all organizations

Points: 4

Added the button to get the full organizations list.
Related issue #53
Submitted on commit #188

Closed by mistake.


Splide addon not working with Vaadin 23

Hi
looks like the Splide component is not working properly with Vaadin 23.
With Vaadin 14 the sample code below renders as follows:

If trying the example inside a normal VerticalLayout, the top image is rendered pretty small:

If clicking the image, the fullscreen mode opens, but when closed the layout is broken:

The code below is a simple extension of the demo, but using a VerticalLayout instead of the DemoView.
If build with Vaadin 14 it works fine. With Vaadin 23.3.3 the error is easy to reproduce.
@Route("splide")
public class SplideView extends VerticalLayout {
    public SplideView() {
        HorizontalLayout sliderLayoutContainer = new HorizontalLayout();
        sliderLayoutContainer.setSpacing(false);
        sliderLayoutContainer.setWidth("600px");
        sliderLayoutContainer.setHeight("400px");
        sliderLayoutContainer.getElement().getStyle().set("margin", "auto");
        sliderLayoutContainer.getElement().getStyle().set("border-style", "solid");
        sliderLayoutContainer.getElement().getStyle().set("border-width", "1px");

        ImageSlide slide1 = new ImageSlide("images/slide_1.png");
        ImageSlide slide2 = new ImageSlide("images/slide_2.png");
        ImageSlide slide3 = new ImageSlide("images/slide_3.png");
        VideoSlide slide4 = new VideoSlide("https://www.youtube.com/watch?v=C78LjVQhejI",
                VideoType.YOUTUBE, "images/slide_4.png");
        ImageSlide slide5 = new ImageSlide("images/slide_5.png");
        ImageSlide slide6 = new ImageSlide("images/slide_6.png");
        ImageSlide slide7 = new ImageSlide("images/slide_7.png");

        Splide slider =
                new Splide(Arrays.asList(slide1, slide2, slide3, slide4, slide5, slide6, slide7));
        slider.setId("images-videos-slider-demo");
        slider.setWidthFull();
        slider.setHeightFull();

        sliderLayoutContainer.add(slider);

        add(sliderLayoutContainer );
    }
}

To use Vaadin 23, use the following in the pom.xml:
<vaadin.version>23.3.3</vaadin.version> <flow.version>9.0.24</flow.version>
Any ideas how to fix or workaround this?

Thanks for reporting this. The problem is related to the height calculation on the component initialization. Somehow is ignoring it here. Did some testing and couldn't find a workaround yet. Proper fix needs investigation. This problem is not happening when testing in Vaadin 14.

Please check version 1.0.4 that contains a fix for this issue.


hostap: The security keys were checked in wrong function

The security check case statements were in frequency band setting checks. This is totally wrong and will cause compiler warnings. Moving the checks to correct function.

This is causing CI failures for example in https://github.com/zephyrproject-rtos/zephyr/actions/runs/11068743271/job/30756823773?pr=79056

Just wondering why the issue was not caught when the original PR #78827 ci was run.

Just wondering why the issue was not caught when the original PR #78827 ci was run.

just wondering how did you submit code without verifying it builds and works first :-)

just wondering how did you submit code without verifying it builds and works first :-)

not you, whoevever submitted the code, sorry.

Just wondering why the issue was not caught when the original PR #78827 ci was run.

the reason here is relying on tags for determining what tests/samples we build, this changes modules/hostap which does not imply networking in the tags file, so, no networking tests were built...


automaticaly open debug file and show launch program popup.

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

#104372 when I open my vscode he send a launch program popup . it's look like new error, and when I click the cancel button it not cancel this popup also same work yes button how could I solved this problem ?

This is coming up automatically? Or when you try to start debugging? If it comes up automatically it would likely be because of an extension, you can check your installed extensions or run F1 > Troubleshoot Issue to check

This is coming up automatically? Or when you try to start debugging? If it comes up automatically it would likely be because of an extension, you can check your installed extensions or run F1 > Troubleshoot Issue to check

This is coming up automatically? Or when you try to start debugging? If it comes up automatically it would likely be because of an extension, you can check your installed extensions or run F1 > Troubleshoot Issue to check

I already download run extensions .

I don't understand, please explain more


change import statement to require

this fixes an issue with babel-jest where on jest 27.x the
transpile would fail because of the imprt statement
Checklist

[x] All commit messages adhere to the appropriate format in order to trigger a correct release
[x] All code is written in untranspiled ECMAScript (ES 2017) and is formatted using prettier
[ ] Necessary unit tests are added in order to ensure correct behavior
[ ] Documentation has been added

Bors merge bot cheat sheet
We are using bors-ng to automate merging of our pull requests. The following table provides a summary of commands that are available to reviewers (members of this repository with push access) and delegates (in case of bors delegate+ or bors delegate=[list]).

Syntax
Description

bors merge
Run the test suite and push to master if it passes. Short for "reviewed: looks good."

bors merge-
Cancel an r+, r=, merge, or merge=

bors try
Run the test suite without pushing to master.

bors try-
Cancel a try

bors delegate+
Allow the pull request author to merge their changes.

bors delegate=[list]
Allow the listed users to r+ this pull request's changes.

bors retry
Run the previous command a second time.

This is a short collection of opinionated commands. For a full list of the commands read the bors reference.

bors merge


Bugfix: add fallback if no executionDate on transaction

This prevents undefined values from being returned when a transaction has no executionDate value.
This fallback was missing in the code.See the Rust implementation of this logic here: https://github.com/safe-global/safe-client-gateway/blob/ad6e9f132e804fbacbbecbc878cb8b7efe4d2dc1/src/routes/transactions/converters/summary.rs#L53

Coverage: 85.915% (-0.04%) from 85.958% when pulling 87fca2a426bff74a1f0d4df07e1921c54eefd043 on fix-transactions-timestamp into e5235896dc416f757149658b6abed593a759c56a on main.


uYou+ shows black screen; then crashes

Describe the issue
See title
Instructions to reproduce
Launch uYou+ from within LiveContainer (version <IP_ADDRESS>_2.3.1)
What version of LiveContainer are you using?
Build#22
Other
After reopening LiveContainer after the crash, no error message is shown.

Original decrypted ipa works for me but tweaked ones doesn't.

Yeah, the issue boils down to CydiaSubstrate but it’s closed source so I cannot find out what could be wrong.

I believe it should be fixed. Let me know if any other issues occur

I tried uYouEnhanced 19.29.1, 19.26 and latest official YouTube (19.30.2) and they both crashed upon launch. However, older version 19.19.5 worked just fine. So I presume that maybe something changed between YouTube 19.19 and 19.26 that prevented it from launching? Or did I missed something?


Reports

Index

[ ] List all active reports for logged in user
[ ] List all handled reports for logged in user
[ ] List all assigned reports to logged in user
[ ] List all unassigned reports (Depends on ACL)

View

[ ] Show comments
[ ] Show status
[ ] Allow posting of comments

[ ] Allow markdown, embedding images/links etc

[ ] Attach 'proof', link to media file
[ ] Show associated punishment
[ ] Show associated logs (Depends on ACL) if ReportsLogger table exists

Covered in alpha build #215


Fixes #163 - Some dependencies are not visible on Hierarchical graph

This feels like a hack fix, but I couldn't find another solution.
The Hierarchical Edge Bundling is not prepared for namespaces/packages which are also classes.
Making the class names a little different from namespaces (by adding a space) fixes the problem.

I'm not understand what is the problem. Can you give me an example that I can reproduce ?

@Halleck45 I was hoping that the issue #163 would answer it.
You can easily see the issue if you create a folder with the following structure:

\namespace\DUM\FOO (which relates with BAR and DUM)
\whatever\YIN\BAR
\namespace\DUM (this is a class but it has the same name as the namespace)

Then the graph will not show the DUM class.

Ah yes, I did not saw the issue :/
Ok. That's a beautiful hack :) . I don't see another solution, so I merge it
Thanks !


Enhancement: Change volume via native MacOS interface

I can't tell if this is a bug or a missing feature, as this is the first time I'm using the app.
Description:
Changing the volume via the MacOS interface -- either with the slider in the menu bar or with the keyboard shortcuts -- doesn't affect the volume of the app.
This is quite uncomfortable as I'm used to change the volume quite often.

This is supposed to work, changing the volume anywhere is supposed to sync with eqMac.
You haven't followed GitHub issue template and the guidelines setup with those. So I'm closing this issue. If you want to discuss it further with me please contact me on http://discord.eqmac.app

Same problem with me. Why arent they responding ?


Add reverse flag in associative_scan

This is consistent with the reverse flag in the scan operation

I opened a PR with this:
https://github.com/google/jax/pull/4181

We've added reverse flag to associative_scan: https://jax.readthedocs.io/en/latest/_autosummary/jax.lax.associative_scan.html#jax.lax.associative_scan


Ambiguities about R10 in actual use, and South Korea in "China+ (R10)" region?

In models that I encounter in projects, there appears to be a lot of variations in how the different models map to the R10 regions. In particular east and southeast Asian countries. Many models place both Taiwan and North Korea in the "Rest of Asia" region, while some place them in "China+" ("Centrally-planned Asia").
The confusion here seems to stem from at least two places:

The AR6 WGIII model registration template (attached here: IPCC_AR6_model_registration_2019-10-23.xlsx) contains errors in the definition of R10. Most significantly, centrally-planned Asian countries other than China are listed twice, under both R10CHINA+ and R10REST_ASIA, while South Korea and all the non-communist or non-former-communist southeast Asian countries aren't listed anywhere at all. Nor are any north African countries.
The original source given in common-definitions, the LIIMITS project, doesn't have a clear definition of most regions, and notes that there is large variation between the participating models, including for both Asia and North Africa/Middle East. https://tntcat.iiasa.ac.at/LIMITSDB/static/download/LIMITS_10+1_regions.pdf

Given this, I have two questions:

Should common-definitions include R10 regions at all? In some way it is useful to try to settle a clear definition. But on the other hand, most models are not going to change the definition they have used, and certainly not in the existing literature. Which means that someone who takes the region definitions from common-definitions, thinking they are authoritative and not knowing about the ambiguities, might end up confused and wasting time trying to figure out why they can't get the numbers in the scenario databases to add up.
If common-definitions does keep the R10 regions, does it make sense to place South Korea in China+? It's neither centrally planned nor does it fit well with the other countries in that region in other respects. To my mind, the only logical place for it would be in Pacific OECD along with Japan, but I see many models put it in "Rest of Asia" (maybe because the WGIII template and LIMITS don't list it under Pacific OECD).

Here's the current placement of South Korea under China+ in common-definitions:
https://github.com/IAMconsortium/common-definitions/blob/1869816c14a1d7808ce8567f6d55abdb180032d8/definitions/region/common.yaml#L192

Yes, previous region-definitions spreadsheets and pdf's were partly inconsistent. That's why I spent some effort on a clean-up and this repository should now be treated as "source of truth" for definitions of aggregate-regions R5/R9/R10, etc.
Yes, most models cannot directly represent the aggregate-regions because of inconsistent native regions. But the common-definitions repository at least has (should have) the full country-mapping, and it would be quite straightforward to develop methods to get the countries that are actually included in a common-region for a specific model, see https://github.com/IAMconsortium/nomenclature/issues/403.
The R10-regions are a derivative of the R5-regions, and those have the OECD-countries with their membership status as of 1990. Hence, South Korea is not included in the OECD from the R5/R10-perspective.
I agree that the description of "China+ (R10)" could be changed to so as to remove the phrase "centrally planned". I'd be very hesitant to make any major changes to the default-country-definitions of the aggregate regions because this would cause even more confusion.

OK, thanks for looking into it and clarifying the description. I think the real issue here is that how the models in question actually have used China+ and other R10 regions in existing modelling work varies widely, which means that what they call R10 China+ (and several other regions) can't be compared across models or with what you get from doing region aggregawtion with the current common-definitions mappings. But that's not something that can be fixed by making changes in common-definitions anyway.

Right, each model has some native regional resolution and they don't match - no definition of common regions for comparison can get around that.
I can only repeat that https://github.com/IAMconsortium/nomenclature/issues/403 has a piece of code that can help you get clarity on which countries are actually represented in each common region for a particular model.


Pushing Metadata information to DeSci Nodes + Request for Dev help

Description
1. What is the project, and what problem does it solve?
Currently we’re working to build out an automated metadata system that reduces the lift on the side of the researcher when they upload their materials. This can help increase the speed of creating and uploading nodes, create more consistent metadata, and also start shifting open science research over to nodes in an automated way.
2. Project links
https://github.com/desci-md
3. What is the issue you’re having?

We have developed an MVP where we can return a JSON with metadata such as topics, publisher, author, keywords, and other types of more descriptive metadata. However, we don’t know how we might get information from Nodes or how we might return our information to the nodes database to update the metadata fields.

4. Request
We have two requests:

Does nodes have an API or a way that we can return this data to the main platform? Or is there a way we might be able to begin testing where this information might go on nodes?
We have many different sources of information and would need a backend developer or full stack developer who is familiar with python, JSON, and flask to help connect these sources of information together so we can best return this information to nodes. If anyone is interested please reach out!

Additional Information

Contact:

EllieDeSota on the DeSci Discord

Additional Information
No response

Right now what we have is a concept of a Draft Node and a Published Node.
I am assuming you all want to import / update Draft Nodes
We can do that via API call using our current JWT auth
I would suggest spinning up a local instance of nodes (dockerDev.sh command) and also nodes-web (yarn start command) and test it out to make sure the local dev env is ready
then once that is complete you can hit different routes to update nodes
i will look into publishing some docs on this but for now the relevant bits are here
create new node draft: https://github.com/desci-labs/nodes/blob/develop/desci-server/src/routes/v1/nodes.ts#L26
add component to node draft: https://github.com/desci-labs/nodes/blob/develop/desci-server/src/routes/v1/nodes.ts#L27
update a node draft: https://github.com/desci-labs/nodes/blob/develop/desci-server/src/routes/v1/nodes.ts#L28
adding data to a node draft: https://github.com/desci-labs/nodes/blob/develop/desci-server/src/routes/v1/datasets.ts#L14
additionally, you can find the data model for Draft Nodes here https://github.com/desci-labs/nodes/blob/develop/desci-models/src/ResearchObject.ts

closing for now unless help continues to be needed

In addition to wanting to document the API #119, we want to build first-class support for user-generated API keys #102


Feature Idea: Link Note md to png

Brandon, it would be most helpful in terms of workflow to link the md to the png, so that the png is displayed right after the text.  For example:

Great idea. One thing I wonder is should I interleave the images of each page with the text or have a separate text then images section.
I am sure I can add a template down the line but need to decide on the v1 default

I'd prefer to keep it separate, although that can be an option on the plugin.  On a related note, it also should be an option to consolidate multi-page notes into a single md.  For this, the image for the page would also appear after the page's text.

Ah ok so you want one note per page?

Not quite sure we are saying same thing. Right now, the plug-in will take a
multipage note and break it up into separate md files. It would be
preferable, as an option, to keep it combined as a single md. A command
option could, on demand, break it up into separate md's.
By losing the flow between pages of the note, the thought flow can be lost.
It would be very useful if the SN headings could be respected in the note
with MD heading and subheading markers.  This will make more sense when you
get a device.
On Tue, Mar 12, 2024, 6:56 PM Brandon Philips @.***>
wrote:

Ah ok so you want one note per page?
—
Reply to this email directly, view it on GitHub
https://github.com/philips/obsidian-plugin-supernote/issues/6#issuecomment-1992709311,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG6MIF32WYGEJPMEATTMJHTYX6BZHAVCNFSM6AAAAABETC3TQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJSG4YDSMZRGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

I think this is fixed in v2.0.0 just released.


iOS - Broken Expensify Card/Company Card empty state display

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.49
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): Any user
Logs: https://stackoverflow.com/c/expensify/questions/4856 N/A
Expensify/Expensify Issue URL: N/A
Issue reported by<EMAIL_ADDRESS>Slack conversation: https://callstack-hq.slack.com/archives/C06ML6X0W9L/p1728976662889569?thread_ts=1728941405.662029&cid=C06ML6X0W9L
Action Performed:
Case 1:

Open the app and login.
Create a new workspace.
Enable Expensify card feature in More Features.
Go to Expensify Card page.

Case 2:

Open the app and login.
Create a new workspace.
Enable Company card feature in More Features (it's under beta).
Go to Company Card page.

Expected Result:
Case 1:
The empty Expensify Card page view should include features list and Issue new card button.
Case 2:
The empty Company Card page view should include features list and Add company cards button.
Actual Result:
Describe what actually happened
No features list or action button is displayed on the Expensify Card/Company Card empty state pages.
Workaround:
N/A
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

The issue is not reproducible anymore!


Operand and operator version update for monitoring 3.19.8 #56315

https://github.ibm.com/IBMPrivateCloud/roadmap/issues/56315

/lgtm


[WIP] Edge MVP Sidebar, Emptystate and Add model

Description

How Has This Been Tested?

Test Impact

Request review criteria:

Self checklist (all need to be checked):

[ ] The developer has manually tested the changes and verified that the changes work
[ ] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

@Sara4994
Here is what i think you need to do for this PR.

make sure you are filling in all the PR template criteria before you post the PR. We try to keep things out of WIP/draft unless there is a good reason for it
This PR should not be going into main. This should be going into the feature branch as described by the tracker
what issues is this closing? all PRs must have a linked issue. I think this is covering multiple issues so i would suggest you open a separate PR for each issue. This will benefit development in a few ways

we wont get ahead of ourselves and start work when previous foundation work is not ready. The issues in the tracker for this feature have dependencies, meaning we should not start the issue until we land all of its parent issues.
smaller PRs: its easier to review smaller PRs, the reason we split the tracker into multiple issues is so that we can have multiple PRs. It makes us less likely to miss bugs.


feat(): Added New endpoints as of 4th July, 2024

Summary

Additional Information

Please check old functions with reponse type with wrapper
Promise <APIResponse>
I think that is wrong, as all already return the data part, so please check funtions like that, there is 4-5 or so.

Please check old functions with reponse type with wrapper
Promise
I think that is wrong, as all already return the data part, so please check funtions like that, there is 4-5 or so.

If the request is successful (response code is 0), the base rest client extracts the nested data from the response:
https://github.com/tiagosiebler/okx-api/blob/master/src/util/BaseRestClient.ts#L192-L197
If there's any kind of error, the full response is thrown. Looks like you're correct!
Can you remove the APIResponse wrapper from any response types in rest-client.ts? Good catch!

@JJ-Cro apologies, v1.4.0 is the version to bump to!


pcl: fix convex hull support

Motivation for this change
PCL requires a patch to be compatible with QHull 2020.2. The patch has been accepted upstream, but this commit uses a version of the patch from Conda which has been backported to 1.11.
Without this patch, the build still succeeds, but convex hull support is disabled.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[x] Fits CONTRIBUTING.md.

cc @viric

Result of nixpkgs-review pr 124836 run on x86_64-linux 1

1 package built:

pcl


V0.1 transporters enhancement

Reference Issues/PRs
What does this implement/fix? Explain your changes.

add deep recursive numpy.ndarray to list serializer in GeneralDataStructure transporter
add deep recursive list to numpy.ndarray deserializer in GeneralDataStructure transporter
update labelbinerizer transporter

Any other comments?

I will add coverage-associated tests in the NN support PR because these new parts will be mainly used in NNs and fully covered in that PR.

I will add coverage-associated tests in the NN support PR because these new parts will be mainly used in NNs and fully covered in that PR.

@sepandhaghighi
are you ok with it?

Great. The PR scope is well organized. Minor points needed to be mentioned:

Update CHANGELOG.md
Add some test so that coverage percent increases (simple function test to make ensure us about the performance of these functions)
Added function's name is so long, make it shorter if it's possible
As you said in the discord channel, either solve the Python 3.5 problem or drop it. Anyway merge the PR to dev after passing all tests.

Also, Sepand announced his agreement to Python 3.5 drop.


chore(CHANGELOG): update to v0.23.0

I am wondering what's the point of keeping 0.x versioning here. I cannot really imagine how the ruleset could have breaking changes.


Support multiple repositories

This is kind of an epic, isn't it.
This issue covers

https://github.com/koppor/adr-manager/issues/8
https://github.com/koppor/adr-manager/issues/44


Form.Input ref returns null

<Form.Input ref={input => this._input = input}/>

on Mount
console.log(this._input) // null;

It is a stateless functional component, React only supports refs on class components.