submission of the user profile by madeleine.

sorry not exactly as it is supposed to be => will try to fix but at least it will allow Hassan to work.

I will open a pull request from the correct branch.


[🐛] test bug

:bug: Bug report
Description

A clear and concise description of the problem...
Is this a regression?

Yes, the previous version in which this bug was not present was: x.y.z
:microscope: Minimal Reproduction

:fire: Exception or Error

:deciduous_tree: Your Environment

Additional Information

test comment


Rolling updates migrations strategy

This issue is imported from pivotal - Originaly created at Apr 25, 2019 by bstrooband
When I was testing the rolling update PR, I noticed that the order of deployment for code and migrations is important.
In order to drop the columns first the old (BC-support) code needs to be removed and after that the migrations needs to performed in order to drop the columns.
I don't know the strategy currently being used to deploy a new release but I thought it would be very likely that the migrations will be performed before the code changes and that won't work.
So there could be two ways in how to handle this:

create a separate release to drop the columns
manually run migrations during deployment so this could be done before or after the code changes

Personally I would go for option 2 to keep the releases more atomic and I would reckon that performing the relations will need some extra TLC.

@bartgeesink @thijskh @michielkodde
What are your thoughts about this? (bstrooband - Apr 25, 2019)

2 is acceptable but it does require more manual hand holding. I would also be fine with one release cleaning up the code and to put the actual drop of the columns in the release after that. (Thijs Kinkhorst - Apr 25, 2019)

Currently the deployment goes like this: We have two sets of servers, blue and red. Suppose everything runs version 1.0 and we are going to upgrade to 1.1:

All red servers are removed from the loadbalancer
Red servers get an update to version 1.1
During the deployment, the migrations are run (see https://github.com/OpenConext/OpenConext-deploy/blob/27581ef8dffa29a5f618302dbe9198c65e31a27a/roles/engineblock/tasks/main.yml#L177)
Traffic is slowly directed to the red servers serving version 1.1 (first 10%, than 50% than 100%)
We then either upgrade blue as well to version 1.1, or upgrade blue to version 1.2

What we can do is seperate the migrations from the release. A migration containing certain changes like an alter column can have a significant impact and should be performed during a maintenance window. If the software is always backwards compatible we can decide ourselves when to run the migrations  (Bart Geesink - Apr 25, 2019)

Bas and I discussed this in real life, a small summary:
For me, it was not fully clear why we needed a migration before deploying/using the code. That is fully clear now, as we still support the 5.7 construction. I was under the impression that this was already dropped in the 5.9 release.
And we discussed another possible option. That is to periodically create a 'housekeeping' release that only consists of these kinds of chores.
My personal preference would be to drop the rollback logic as soon as possible after a release. As in the same workday after concluding that the release was a success. (Michiel Kodde - Apr 25, 2019)

@bartgeesink is  5.11 going to be a release during a maintenance window? Else I would suggest to keep the migrations for now in the same release, so you could test if that could work for you. if you encounter it\'s not going to work I\'ll be happy to create a minor release with the migrations and code split up?

(bstrooband - Apr 25, 2019)

Assume that no release will be done in a maintenance window. (Thijs Kinkhorst - Apr 25, 2019)

During the standup it was mentioned that db migrations still had to be done during maintenance windows because of possible long running schema updates and indices updating? (bstrooband - Apr 25, 2019)

That should be exceptional (changes to the user and consent tables e.g.) and we should discuss before introducing them that we want this.
Updates to sso_profider_roles_eb5 should be quick and straightforward.
In any case it does not really matter I think. Because it still holds that even if the migration is done in the maintenance window, the source code will not be deployed in one go to all nodes. There will be nodes runing 5.10 and nodes running 5.11 at the same time also after the maintenance window.
What we can agree on is an ordering. E.g. migration M is only executed when all nodes run at least version X. But such an ordering is most easily encoded in the software versions. If it's clean up of structures that the code stopped using in X, do the cleanup migrations in X+1. (Thijs Kinkhorst - Apr 25, 2019)

I leave it as-is for now, so the migrations are in the same release. (bstrooband - Apr 25, 2019)


DSYS serializer overhaul

The serializer class for DSYS objects has a number of issues, including #3374 and two more problems I encountered while working on a fix:

most notably, in its current version, the serializer will only interact with version 0001 of the text, even if that is not the active version and/or newer versions exist on the system.
texts are always handled in the current user's logon language, even if that is not the document's master language.

This PR rewrites the DSYS serializer from the group up using the longtexts facility, while retaining the ability to deserialize objects written by the current version of the deserializer. Additionally, texts are always opened in their master language when jumping to the text edit tool.
Closes #3374.
Closes two unreported issues as mentioned above.

any changes to the serialized XML files, will it also work with older serialized XML files?

Yes, the deserializer checks the version recorded in the XML metadata. For v1.0.0 it uses more or less the same logic as before (but updates the latest version of the document). New XML files are written with metadata version v2.0.0.

okay
can you help to submit a 1.0.0 example to https://github.com/abapGit-tests/DSYS_old
and the new serialized XML to https://github.com/abapGit-tests/DSYS_new
so we have it for testing and future reference

Done - see abapGit-tests/DSYS_old#1 and abapGit-tests/DSYS_new#1.

@goreraks can you help testing this PR?

In logon langauge EN, imported https://github.com/abapGit-tests/DSYS_old/pull/1, document created in DE language but abapGit shows the difference b/w local and remote. is it the correct behaviour?

I'm assuming you're using the old version of zcl_abapgit_object_dsys, since the serializer version on your diff's local side is still v1.0.0.
If so, you're seeing the effect of one of the additional problems I've mentioned in the PR:

texts are always handled in the current user's logon language [...]

Basically, on import the document is created in language DE, but it gets compared to language EN because the serializer always tries to read version 1 in your logon language, regardless of what actually exists on your system.

Tested https://github.com/abapGit-tests/DSYS_new/pull/1, works as expected i.e. including the translation of document.
The behaviour observed in my previous comment is also valid for new version v2.0.0 i.e. if the document is created in different language(Master language = true), after the pull request the object shows the difference.

@goreraks can you post the diff you get after importing the v2 XML with the v2 deserializer?

Sorry, the difference is not similar to version 1.0.0 but the difference is with the DOKL-MASTERLANG.

Hm, I'll have a look into that when I'm back in the office next week.
It could be that it's impossible to create a document with a master-language that's different from the current logon language, in which case this would be a user-error because the repo's master language doesn't match the document's master language (altho, in all fairness, I probably should have included an .abapgit.xml in the test-data PRs).

Yep, as mentioned above: this happens when the log-on language and document language are different. As long as the master lang in .abapgit.xml matches the master lang in serialized documents, this should never result in an actual problem. I'll update the test repo accordingly, but I don't think additional code changes are strictly necessary.

I am not sure but seems the behavior is not in sync with the transport import. For example, if the same document is transported to other system then, masterlang would have been updated as 'X'.
One more thing, I think because of the difference, I can also stage the file which would overwrite masterlang in the remote file.

Yes and no. You can do those things right now, because your abapGit repository is using master language EN. If the repository is setup correctly, then abapGit will refuse to pull the document unless you're logged in with the correct logon language; if your logon language is DE, none of these issues appear.

yea, sure, always feel free to raise new issues
thanks both 👍

I believe this broke compilation in 7.31 and below. :(

thanks @esjewett, please open it as a new issue
"In Release 4.0" hmm?

That's what you get for trusting the linter. 😄
I think we have a 7.02 system for... reasons - but nothing between that and 7.4x; I'll have a look on Monday.

I dont have a 702 system, so dont have that option
will fix the linter, one bug at a time


Rm deprecated plugins

Codecov Report

Merging #359 (d414d8b) into main (b20d9cc) will decrease coverage by 2.82%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              main     #359      +/-   ##
===========================================
- Coverage   100.00%   97.17%   -2.83%
===========================================
  Files           54       52       -2
  Lines         3068     3014      -54
===========================================
- Hits          3068     2929     -139
- Misses           0       85      +85

Impacted Files
Coverage Δ

statick_tool/statick.py
97.60% <ø> (-2.40%)
:arrow_down:

...tatick_tool/plugins/tool/uncrustify_tool_plugin.py
66.66% <0.00%> (-33.34%)
:arrow_down:

statick_tool/plugins/tool/xmllint_tool_plugin.py
80.00% <0.00%> (-20.00%)
:arrow_down:

statick_tool/plugins/tool/cppcheck_tool_plugin.py
85.10% <0.00%> (-14.90%)
:arrow_down:

...tatick_tool/plugins/tool/perlcritic_tool_plugin.py
87.03% <0.00%> (-12.97%)
:arrow_down:

...tatick_tool/plugins/tool/clang_tidy_tool_plugin.py
87.32% <0.00%> (-12.68%)
:arrow_down:

statick_tool/plugins/tool/cccc_tool_plugin.py
91.71% <0.00%> (-8.29%)
:arrow_down:

statick_tool/discovery_plugin.py
98.00% <0.00%> (-2.00%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b20d9cc...d414d8b. Read the comment docs.


Add Epinio service data validation, move form validation logic into forms

In this PR, I have added form validation rules for services:

At least one key-value pair is required in the data
Neither keys nor values can be empty
Characters in keys are restricted to alphanumeric characters, _, ., and - (it uses the same error message as the back end)

There is a tiny delay on validation messages showing up for the services, but I think that comes with the territory of deeply watching a non-primitive value (the service data) for changes.
When working on this PR, I found that the existing setup for form validation we had for creating a namespace quickly became overcomplicated when doing a form with multiple fields. I simplified the validation logic, particularly by replacing :validators="[ meetsNameRequirements ]" with an error-messages property. I did this I figure it's better to keep form validation in forms and outside of the smaller reused components.
I updated the namespace creation form validation as well, just to make it consistent with the new props that I'm using. I removed the banner and made the errors white and more compact to match the others.
The same validation style can easily be used to create a namespace during app creation as well.

I'll sync up with Sean this week

@richard-cox since Epinio is going in a different direction with the standalone UI, should this PR just be closed?

I don't believe it would conflict with Sean's PR.


Beirut, Lebanon and Bangkok, Thailand

Couldn't see either Beirut, Lebanon or Bangkok, Thailand
They might be good ones to add

Added Bangkok as https://www.vaguelyrudeplacesmap.com/?id=285&lang=en.
Not sure how Beirut is rude though?


create-tauri-app giving false warning about deno missing dependencies

cargo version and npm version give a false warning about missing dependencies Deno.
https://github.com/tauri-apps/create-tauri-app/blob/a5a53fdc1370f6c2e28ea3b92fdcef1ff1c60bfc/src/deps.rs#L151
we have missing case when bun or deno is used
https://github.com/tauri-apps/create-tauri-app/blob/a5a53fdc1370f6c2e28ea3b92fdcef1ff1c60bfc/src/deps.rs#L207
cargo @ latest
cargo create-tauri-app
✔ Project name · 003
✔ Package name · tauri-app
✔ Identifier · com.tauri-app.app
✔ Choose which language to use for your frontend · Rust - (cargo)
✔ Choose your UI template · Leptos - (https://leptos.dev/)

Template created!

Your system is missing dependencies (or they do not exist in $PATH):
╭──────┬──────────────────────────╮
│ Deno │ Visit https://deno.land/ │
╰──────┴──────────────────────────╯
..... trimmed here

bun @ from latest to 4.5.2
bun create tauri-app@latest
✔ Project name · 004
✔ Package name · tauri-app
✔ Identifier · com.tauri-app.app
✔ Choose which language to use for your frontend · TypeScript / JavaScript - (pnpm, yarn, npm, deno, bun)
✔ Choose your package manager · bun
✔ Choose your UI template · Vanilla
✔ Choose your UI flavor · TypeScript

Template created!

Your system is missing dependencies (or they do not exist in $PATH):
╭──────┬──────────────────────────╮
│ Deno │ Visit https://deno.land/ │
╰──────┴──────────────────────────╯
..... trimmed here

bun @4.5.1
 bun create<EMAIL_ADDRESS>✔ Project name · 001
✔ Package name · tauri-app
✔ Identifier · com.tauri-app.app
✔ Choose which language to use for your frontend · TypeScript / JavaScript - (pnpm, yarn, npm, bun)
✔ Choose your package manager · bun
✔ Choose your UI template · Vanilla
✔ Choose your UI flavor · TypeScript

Template created!

Your system is missing dependencies (or they do not exist in $PATH):
╭─────────┬──────────────────────────────╮
│ Node.js │ Visit https://nodejs.org/en/ │
╰─────────┴──────────────────────────────╯
..... trimmed here

Solutions - 1
add cases for bun and deno, possibly change function name to is non cargo package manger is_not_rust() or is_not_cargo
PackageManager::Pnpm | PackageManager::Yarn | PackageManager::Npm | PackageManager::Bun | PackageManager::Deno

https://github.com/tauri-apps/create-tauri-app/blob/a5a53fdc1370f6c2e28ea3b92fdcef1ff1c60bfc/src/package_manager.rs#L163-L168
need new cases for
https://github.com/tauri-apps/create-tauri-app/blob/a5a53fdc1370f6c2e28ea3b92fdcef1ff1c60bfc/src/deps.rs#L213
https://github.com/tauri-apps/create-tauri-app/blob/a5a53fdc1370f6c2e28ea3b92fdcef1ff1c60bfc/src/deps.rs#L207

different Solution was better and sent pull request


Updated block-images.js to reflect updated setRequestInterception

The /examples didn't have the adjustment from:
await page.setRequestInterception(true);
to
await page.setRequestInterceptionEnabled(true);

I signed it!

It appears I was wrong, my mistake.


npm install require admin.

node js installed on program files. and therefore npm is. older node did roaming. but after using this module it turned out the the roaming does not exist. and npm is tring to write to program files. which fails. any idea how to over come this issue? thanks!!

Hey @centure,
npm-windows-upgrade tries to find your npm location and installs it where it was found before - with a few fallbacks, in case things go wrong. It does not delete anything, so roaming should still be around.
There's a simple command to define the global installation location for your node modules:
npm config --global set prefix "%appdata%\npm"
npm config --global set cache "%appdata%\npm-cache"

Also, open up an Explorer window and enter %appdata% into the address field. Ensure that both npm and npm-cache exist.
That should fix your issue, so I'm closing this - but do let me know if you run into any more trouble!

Thanks. Seems to work good :)


Enable SSH on Windows nodes

We should enable SSH on the Windows nodes (because who likes using WinRM...)
Here is some powershell we use in aks-engine to start the ssh server and add authorized keys.
https://github.com/Azure/aks-engine/blob/master/parts/k8s/windowsinstallopensshfunc.ps1

this is completed by #66 think this can be closed

/close


Add 'best' practices as own netlify CMS collection

DESC

discuss what needs to be configured etc.
we will get documents (pdfs) that need to be statically linked on the page --> therefore no CMS workflow necessary?
add best practice as tag in news collection

TODOs

[ ] implement
[ ] generate basic view template?
[ ] add to nav

will be handled by tag under news section see #222


Handling of long introduction field

In case City.introduction is too long for display in the card design on the top-level page, we need some way to show its full content. Possibilities:

Prevent it from being to long. (E.g. enforce a maximum length)
Display it on the city page in full.
Add a "show more" / "Mehr anzeigen" button and come up with a good way to expand / show more without destroying the card design, e.g. by overlapping cards below. Ensure a good method to collapse the expanded card and so forth...

ausklappen ausklappen :)

This is superseded by the Teaser concept, I think.


Fixed interaction of first_line_indent with outline

Explanation
If a user sets a first-line-indent that is non-zero for par and then adds vertical spacing between entries of the outline just like suggested in the typst documentation, then the outline is badly indented. The default behaviour should be that first-line-indent does not apply inside of outline. An example of this issue and its fix is available further down.
What was done

Inside of the ShowSet of outline.rs, the first_line_indent property of par was set to 0em.
A test for this fix with the previously broken code was created.

Example of the issue
Here is the code that initially caused the issue:
#set par(first-line-indent: 1.5em)
#set heading(numbering: "1.1.a.")
#show outline.entry.where(
  level: 1
): it => {
  v(0.5em, weak: true)
  strong(it)
}

#outline()

= Introduction
= Background
== History
== State of the Art
= Analysis
== Setup

And the fix was (before fixing the source code of typst) adding the following line to the code:
#show outline: set par(first-line-indent: 0em)

Thanks!


dist/build-docker.sh: build an aci

This patch depends on:

actool patch-manifest:
https://github.com/appc/spec/pull/258
docker2aci on local files:
https://github.com/appc/docker2aci/issues/32

Update on the dependencies:

actool patch-manifest ppc/spec#258 is merged :)
docker2aci on local files appc/docker2aci#32 is waiting for review on https://github.com/appc/docker2aci/pull/37

@eyakubovich good for this to go?

Looks good but can we add an option to either enable or disable this. The script is called build-docker.sh and if there're issues with aci conversion, I'd still like to be able to make releases without commenting out lines in the script.

Hmm, maybe this should be dist/build-aci.sh and just source build-docker.sh inside it?

That would be fine as well.

@alban could you please take a look at this so we can close out coreos/rkt#389?

Patch updated.

Branch updated.

LGTM, @eyakubovich can you ack/merge please?

LGTM


Invalid regular expression: missing terminating ] for character class

after updating to bun 1.0.20 and

<EMAIL_ADDRESS><EMAIL_ADDRESS>
i receive this error for routes:
Invalid regular expression: missing terminating ] for character class

We faced same issue in WSL with bun version 1.0.15


Homebrew installation fails

When trying to install with Homebrew, I get the following error
==> make install PREFIX=/usr/local/Cellar/xcodegen/1.8.0
swift build --disable-sandbox -c release -Xswiftc -static-stdlib
Compile CYaml src/writer.c
Compile CYaml src/scanner.c
Compile CYaml src/reader.c
Compile CYaml src/emitter.c
Compile CYaml src/parser.c
Compile CYaml src/api.c
Compile Swift Module 'PathKit' (1 sources)
Compile Swift Module 'AEXML' (5 sources)
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/libxml2/module.modulemap:1:8: error: redefinition of module 'libxml2'
module libxml2 [system] [extern_c] {
       ^
/usr/include/libxml2/module.modulemap:1:8: note: previously defined here
module libxml2 [system] [extern_c] {
       ^
1 error generated.
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/libxml2/module.modulemap:1:8: error: redefinition of module 'libxml2'
module libxml2 [system] [extern_c] {
       ^
/usr/include/libxml2/module.modulemap:1:8: note: previously defined here
module libxml2 [system] [extern_c] {
       ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/libxml2/module.modulemap:1:8: error: redefinition of module 'libxml2'
module libxml2 [system] [extern_c] {
       ^
/usr/include/libxml2/module.modulemap:1:8: note: previously defined here
module libxml2 [system] [extern_c] {
       ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/libxml2/module.modulemap:1:8: error: redefinition of module 'libxml2'
module libxml2 [system] [extern_c] {
       ^
/usr/include/libxml2/module.modulemap:1:8: note: previously defined here
module libxml2 [system] [extern_c] {
       ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/libxml2/module.modulemap:1:8: error: redefinition of module 'libxml2'
module libxml2 [system] [extern_c] {
       ^
/usr/include/libxml2/module.modulemap:1:8: note: previously defined here
module libxml2 [system] [extern_c] {
       ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/libxml2/module.modulemap:1:8: error: redefinition of module 'libxml2'
module libxml2 [system] [extern_c] {
       ^
/usr/include/libxml2/module.modulemap:1:8: note: previously defined here
module libxml2 [system] [extern_c] {
       ^
error: terminated(1): /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swift-build-tool -f /private/tmp/xcodegen-20180403-12948-166yly2/XcodeGen-1.8.0/.build/release.yaml main output:

Fetching https://github.com/kylef/PathKit.git
Fetching https://github.com/onevcat/Rainbow.git
Fetching https://github.com/kylef/Commander.git
Fetching https://github.com/tadija/AEXML.git
Fetching https://github.com/kylef/Spectre.git
Fetching https://github.com/jpsim/Yams.git
Fetching https://github.com/yonaskolb/JSONUtilities.git
Fetching https://github.com/xcodeswift/xcproj.git
Fetching https://github.com/JohnSundell/ShellOut.git
Cloning https://github.com/kylef/PathKit.git
Resolving https://github.com/kylef/PathKit.git at 0.9.1
Cloning https://github.com/onevcat/Rainbow.git
Resolving https://github.com/onevcat/Rainbow.git at 3.1.1
Cloning https://github.com/kylef/Commander.git
Resolving https://github.com/kylef/Commander.git at 0.8.0
Cloning https://github.com/kylef/Spectre.git
Resolving https://github.com/kylef/Spectre.git at 0.8.0
Cloning https://github.com/jpsim/Yams.git
Resolving https://github.com/jpsim/Yams.git at 0.6.0
Cloning https://github.com/tadija/AEXML.git
Resolving https://github.com/tadija/AEXML.git at 4.2.2
Cloning https://github.com/yonaskolb/JSONUtilities.git
Resolving https://github.com/yonaskolb/JSONUtilities.git at 3.3.8
Cloning https://github.com/xcodeswift/xcproj.git
Resolving https://github.com/xcodeswift/xcproj.git at 4.2.0
Cloning https://github.com/JohnSundell/ShellOut.git
Resolving https://github.com/JohnSundell/ShellOut.git at 2.1.0
make: *** [build] Error 1

==> Formula
Tap: yonaskolb/xcodegen
Path: /usr/local/Homebrew/Library/Taps/yonaskolb/homebrew-xcodegen/Formula/xcodegen.rb
==> Configuration
HOMEBREW_VERSION: 1.5.14
ORIGIN: https://github.com/Homebrew/brew.git
HEAD: 7fd6210127f088b6ee8708a1d7f4ec2df3fc5bb4
Last commit: 32 hours ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 603231ba2b0ec137ed5d74b3e3ce1a2419a62da5
Core tap last commit: 2 hours ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_ENABLE_AUTO_UPDATE_MIGRATION: 1
HOMEBREW_NO_ANALYTICS_THIS_RUN: 1
CPU: octa-core 64-bit ivybridge
Homebrew Ruby: 2.3.3 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/bin/ruby
Clang: 9.1 build 902
Git: 2.17.0 => /usr/local/bin/git
Curl: 7.54.0 => /usr/bin/curl
Java: 1.8.0_101
macOS: 10.13.4-x86_64
CLT: <IP_ADDRESS>.1.1521514116
Xcode: 9.3
XQuartz: 2.7.11 => /opt/X11
==> ENV
HOMEBREW_CC: clang
HOMEBREW_CXX: clang++
MAKEFLAGS: -j8
CMAKE_PREFIX_PATH: /usr/local
CMAKE_INCLUDE_PATH: /usr/include/libxml2:/System/Library/Frameworks/OpenGL.framework/Versions/Current/Headers
CMAKE_LIBRARY_PATH: /System/Library/Frameworks/OpenGL.framework/Versions/Current/Libraries
PKG_CONFIG_LIBDIR: /usr/lib/pkgconfig:/usr/local/Homebrew/Library/Homebrew/os/mac/pkgconfig/10.13
ACLOCAL_PATH: /usr/local/share/aclocal
PATH: /usr/local/Homebrew/Library/Homebrew/shims/super:/usr/bin:/bin:/usr/sbin:/sbin

Error: yonaskolb/xcodegen/xcodegen 1.8.0 did not build
Logs:
     /Users/tkrajacic/Library/Logs/Homebrew/xcodegen/01.make
     /Users/tkrajacic/Library/Logs/Homebrew/xcodegen/00.options.out
     /Users/tkrajacic/Library/Logs/Homebrew/xcodegen/01.make.cc
If reporting this issue please do so to (not Homebrew/brew or Homebrew/core):
yonaskolb/xcodegen

/usr/local/Homebrew/Library/Homebrew/utils/github.rb:220:in `raise_api_error': curl failed!   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current (GitHub::Error)
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 422 Unprocessable Entity
curl: (3) <url> malformed
	from /usr/local/Homebrew/Library/Homebrew/utils/github.rb:178:in `open_api'
	from /usr/local/Homebrew/Library/Homebrew/utils/github.rb:278:in `search'
	from /usr/local/Homebrew/Library/Homebrew/utils/github.rb:225:in `search_issues'
	from /usr/local/Homebrew/Library/Homebrew/utils/github.rb:238:in `issues_for_formula'
	from /usr/local/Homebrew/Library/Homebrew/exceptions.rb:368:in `fetch_issues'
	from /usr/local/Homebrew/Library/Homebrew/exceptions.rb:364:in `issues'
	from /usr/local/Homebrew/Library/Homebrew/exceptions.rb:418:in `dump'
	from /usr/local/Homebrew/Library/Homebrew/brew.rb:138:in `rescue in <main>'
	from /usr/local/Homebrew/Library/Homebrew/brew.rb:30:in `<main>'

Thanks for digging into it and the PR @vhbit!
Do you know why it only happens for some people?
For example my HOMEBREW_ISYSTEM_PATHS doesn't have libxml2 in it
$ brew sh
$ echo $HOMEBREW_ISYSTEM_PATHS
/usr/local/include:/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/apache2:/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Headers

I also brew 1.6.0 was just released. Can anyone confirm that this issues is still present for them with that version?

You probably need to set SDKROOT.

@yonaskolb
ok, it starts to be more and more complicated :-)
I've upgraded to brew 1.6.0
now if I do brew sh and env - there is no libxml2 in HOMEBREW_ISYSTEM_PATHS but it still fails to reinstall (with the same error as before) unless patch to formula applied.
And your code sample might shed a bit of light to the issue: you have includes for Apache2.
Now if we look at the following code
  def homebrew_extra_isystem_paths
    paths = []
    paths << "#{effective_sysroot}/usr/include/libxml2" unless deps.any? { |d| d.name == "libxml2" }
    paths << "#{effective_sysroot}/usr/include/apache2" if MacOS::Xcode.without_clt?
    paths << MacOS::X11.include.to_s << "#{MacOS::X11.include}/freetype2" if x11?
    paths << "#{effective_sysroot}/System/Library/Frameworks/OpenGL.framework/Versions/Current/Headers"
    paths
  end

source
Apache2 includes signal that you don't have CLT installed, only Xcode.
I guess that's why all ISYSTEM_PATH values for you are relative to /Applications/Xcode.app/Contents/Developer/..., while for me they are all relative to root.
Which means the problem occurs only when both Xcode 9.3 AND CLT 9.3 are installed. Unfortunately I don't have any machine without CLT to test it out.

ENV["SDKROOT"] = MacOS.sdk_path

@yonaskolb

If your brew 1.6.0 doesn't have libxml2, and it still doesn't install, how would #289 help?

what I said is that if I do brew sh and env (i.e. printing whole environment) there is no libxml2 in the output.
but if I print environment in runtime, right before running make - /usr/lib/libxml2 is in HOMEBREW_ISYSTEM_PATHS => seems environment is updated somewhere later and therefore #289 works.
@ilovezfs

ENV["SDKROOT"] = MacOS.sdk_path

should it be set in install? In this case it doesn't work
and according to this:
  def effective_sysroot
    MacOS.sdk_path.to_s if MacOS::Xcode.without_clt?
  end

there is no way to actually change it if CLT is installed as all ISYSTEM_PATHS depend on effective_sysroot

Actually looking at that code, does it only add libxml2 if it isn't listed as a dependency? (or is it the other way around, my ruby foo isn't strong) If so, is that the solution, to just list libxml2 as a dependency?

listing libxml2 as dependency works, but libxml2 depends on python@2 and it has even more dependencies which might pull even more, so I wouldn't call that an "easy-to-go option".

Possible homebrew fix here https://github.com/Homebrew/brew/pull/4147

I'm not sure if it's related, but I had nothing in "xcode-preferences-locations-command line tools" after clean install macos&xcode, i selected one option and all xml/raise_api_error errors disappears.


Inconsistent error for two different ways of filtering properties of a certain type

🔎 Search Terms
Pick vs
inconsistent conditional type
index signature type argument
conditional type index signature
🕗 Version & Regression Information
This is the behavior in every version I tried, and I reviewed the FAQ for entries about:

empty classes
homomorphic mapped types
conditional types

⏯ Playground Link
link
💻 Code
type FilterProps<T, P> = {
    [K in Extract<keyof T, string>]: T[K] extends P ? K : never;
}[Extract<keyof T, string>];

// Two ways to define filter on an object
type Filter1<T, P> = Pick<T, FilterProps<T, P>>;
type Filter2<T, P> = {
    [K in FilterProps<T, P>]: T[K] extends P ? T[K] : never;
};

type Result<T extends { [name: string]: string | boolean }> = {
    r0: Verify<Filter1<T, string>>; // error
    r1: Verify<Filter2<T, string>>; // no error
}

type Verify<T extends { [name: string]: string }> = T;

🙁 Actual behavior
The Filter1 argument to Verify is a type error, but Filter2 argument to Verify is not a type error.
🙂 Expected behavior
Both should either be correct or a type error. In this case, I believe both should result in a type error.
Additional information about the issue
No response

Filter2's construction defies the logic that allows Filter1 to work. There are any number of ways you can indirect things, all of which at some point would defeat whatever logic is in place to recognize more straightforward constructs.
I'm not sure why you think these should both be errors? In either case, in a concrete instantiation, only string properties are present.

Filter2's construction defies the logic that allows Filter1 to work.

Could you expand on/rephrase what you mean by this, i.e., why does the extra T[K] extends P ? T[K] : never as compared to what we see in the definition of Pick equate to defying logic here? I am interpreting "defying logic" as a bad thing, in which case I feel like I should avoid using Filter2 in my programs.
I ask because I have a program that works/typechecks with something equivalent to Filter2 but not Filter1. I don't have a solid explanation for why Filter2 works because to me, both implementation of Filter are doing the same thing. Is there a simple explanation for what Filter2 is doing different here that let's the r1 property above typecheck?
Thank you 😸

An analogy might be helpful
Scenario 1: You get a box of bricks and metal cans from Alice, and want to give it to Eve who can only accept metal cans. You know Dave, whose job is to remove everything from a box that isn't metal, so you give the box to Eve with a note on it that says "Take this box to Dave before you start". Eve accepts because she can tell that post-Dave, the box will only contain metal cans, since that's Dave's job.
Scenario 2: You get a box of bricks and metal cans from Alice, and want to give it to Eve who can only accept metal cans. You take it to Bob, whose job is to remove the bricks, and then take it to Eve. Eve says "You got this box from Alice? She sometimes gives out bricks; I can't accept this box because it might have bricks in it". You say "No no, this box has gone via Bob, who is sure to have removed the bricks" but Eve is not smart enough to recognize that this implies there are only cans left in the box.
Could Eve be made smarter? Almost certainly. Will there still be constructions which Eve isn't able to recognize without becoming a general-purpose propositional logic solver? Also yes.

Thank you!
My initial understanding was that the "extra assertion" (the T[K] extends P ? T[K] : never in Filter2) doesn't do anything on top of what Pick<T, FilterProps<T, P>> does, but I was wrong.
Pick's job is to "filter properties". Me telling it to filter properties that also happen to have the type string doesn't mean that Eve will be able to understand that the filtered properties will have the type string.
If go one step further and say "only filter properties of type string", then Eve does understand that the filtered properties will all be of type string.

Yep, exactly

I'm not sure why you think these should both be errors?

I concluded they both should be errors because I misunderstood how conditional types work with union types. I started with the type below:
(string | boolean) extends string ? true : false

The above type is always false, so I concluded that the following in Filter2 should always be never when T[K] is (string | boolean):
T[K] extends P ? T[K] : never

But, I learned about distributive conditional types after digging around in the checker. If I understood things correctly, then the type above actually expands to:
(string extends string ? string : never) | (number extends string ? string : never)

@trajafri Distributivity only applies when the LHS is a lone, naked type parameter (T extends …) which is why it’s easily disabled just by wrapping the type parameter in a tuple type ([T] extends […]).
The bricks and cans analogy is the only thing relevant in this case.

@fatcerberus interesting, thank you for sharing that.
If it’s not distributive conditionals, then what allows us to narrow down to a member of the union type? I have been assuming that T[K] is string | boolean in the r1 property above, but maybe I am wrong about that too 🤔


chore: reduce use of mono in favour of gcongr

... as was discussed on zulip the other day; I cannot find the link quickly.
After this PR, a handful of uses remain which are harder to remove: this branch comments them all

Commits can be reviewed independently.
I'd like confirmation that the three lemmas I tagged with gcongr are actually fine to tag.

Thanks! Yes I'm pretty sure those three gcongr lemmas are fine.
bors r+

Come on, bors!
bors merge


Design splash/loading screen

@tladesignz I'm thinking this will be very simple—A solid background with the app logo on top. Once I get the app logo finalized, I'll provide specs for it.
Did you have any other ideas for it?

Nope. I guess, that's fine. We should just make sure, that there's no jumpy behaviour because of different colors or stuff that's first on the splash screen and later on the first scene of POE.

Waiting for feedback on the app logo, but this is what the launch screen would look like with the proposed logo.

Nice!

@cstiens Thanks for bringing that up again! I will implement it, but I would need the pure logo on transparent background. Can you post that as PDF here or attach to the source?

Here you go!
ob_transparent_logo_trans.pdf

Since I added this weeks ago and there is no dispute about the logo anymore, I assume this to be safe to close.

This is fine for now... I do think the purple on purple is a bit dark overall, as is the purple on black dark launcher icon. I can talk to Carrie directly about this, and we can reopen if we find something better.


New p2p topology file format

Fixes #4559.

One last thing, can you add a vNext section to cardano-node's change log and add this PR to it (similar to what has been done in cardano-cli and cardano-api)?

@Jimbo4350 I added entry in the ChangeLog; with links so it makes it easy for people to find what they need to change.

bors merge

bors merge

bors merge


[bug fix] Use case insensitive workspace and output folder path compa…

…risons when
creating "mainGroup". If you navigate to your workspace from the command
line, ignoring the capitalization of folders, Tulsi can generate
absolute paths which breaks project portability.

Seems good to me - is this something we can upstream?

Yep I'll put that up now


Issue with latest version of babel

Getting Uncaught ReferenceError: lozad is not defined
Using https://babeljs.io/repl/ I made a codepen to show the issue
https://codepen.io/rgfx/pen/eMREGE?editors=0010

@rgfx sorry for the delay in reply, can you investigate the issue with babel?

@rgfx I didn't manage to reproduce the issue. I also see that you didn't use the "Babel" option as a JS preprocessor in your Codepen example and seems to have used Babel externally. This (and a potential misconfiguration) could be the cause of your issue ?

@0gust1 @ApoorvSaxena Forgot to reply, surprised no one has had this issue after me.  Loaded up this project with a newer gulp build still have this issue.
https://codepen.io/rgfx/pen/eMREGE

I get "exports is not defined" even without babel.
https://codepen.io/rpavantica/pen/WVNBJy


Linear Regression for Medical insurance cost prediction

💥 Proposal
To implement Linear Regression on Medical cost personal dataset.
Link to dataset - https://www.kaggle.com/datasets/mirichoi0218/insurance

@khusheekapoor I would like to mention that I am a contributor of GSSOC'23, Please assign me this issue so I can start working on it.

@Haricharan0310 - you can go ahead! We are assigning you 21 days for this project, after which it will be assigned to someone else if not completed. All the best!
Name the file as: algorithm_dataset.ipynb and link it in the readme of the labeled directory as algorithm - dataset.

Hey @khusheekapoor , What about the dataset file? Should I include it? If yes, where should I Include it?

@Haricharan0310 it is not needed, you can mention the dataset link in one of the markdown cells of the Jupyter notebook.

Sure @khusheekapoor !, Thank you for your response.

Hey @khusheekapoor , I've made a PR could you please review it?


wiki cipher wiki tool bar button appears right handed of the help menu

The wiki text edit help menu buttobn shall be outer right side the last toolbar button, but the encryption button is more right. Thats not good for usability.

@cforce First of all, please accept our apologies for the late answer.
The simple answer is: out of the box its not possible. It could be achieved using https://github.com/tleish/redmine_jstoolbar_ext but this would need changes to our code in order to make it work.
ATM we can't allocate internal effort to do this as we don't see it as a really needed feature/improvement.
I'll close the issue for now, but if you want to contribute please do it in the form of pull request (and please re-open this issue or post a new one). The community (us included) would appreciate it.


Idea: ordering in join tables

Would it make sense to add support for ordering in a join table? Here's a rough idea on how that could be achieved. If this was the model:
type User struct {
    Books Books `many_to_many:"user_books"`
}

... and this was the migration:
create_table("books", func(t) {})
create_table("user_books", func(t) {
    t.Column("book_id", "uuid", {})
    t.Column("user_id", "uuid", {})
    t.Column("ordering", int, {})
})

Pop could look for whether Books implements sort.Interface, do the sort before saving, and populate the ordering column appropriately. When someone does an eager query, pop can sort the resulting Books according to ordering
Technically I think this could be done above pop but then you'd have to manage the join table manually.
Thoughts?

I don't think this should be part of pop.
Users can order themselves easily.


Error under xcode7: Multiple methods named 'value' found with mismatched result, parameter type or attributes

The error does not appear on xcode 8.

Can someone help for this issue?

As a workaround, add a type cast:
[animation setFromValue:@([(MBCircularProgressBarLayer*)self.presentationLayer value])];

@MatiBot can you include this cast in the last version?
Thanks @Sega-Zero for the workaround ;-)


devenv.exe, An unexpected error occurred

[Window Title]
devenv.exe
[Main Instruction]
An unexpected error occurred
[Content]
Please press Ctrl+C to copy the contents of this dialog and report this error to our issue tracker.
[^] Hide details  [Close]
[Expanded Information]
Build: 16.1.19129.1

System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.VisualStudio.Text.Tagging.SimpleTagger`1.UpdateBatchSpan(ITrackingSpan snapshotSpan)
   at Microsoft.VisualStudio.Text.Tagging.SimpleTagger`1.<>c__DisplayClass11_0.<RemoveTagSpans>b__0(TrackingTagSpan`1 tagSpan)
   at System.Collections.Generic.List`1.RemoveAll(Predicate`1 match)
   at Microsoft.VisualStudio.Text.Tagging.SimpleTagger`1.RemoveTagSpans(Predicate`1 match)
   at Microsoft.PythonTools.Intellisense.TaskProvider.<RefreshAsync>d__28.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.PythonTools.Intellisense.TaskProvider.Refresh()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.VisualStudio.Telemetry.WindowsErrorReporting.WatsonReport.GetClrWatsonExceptionInfo(Exception exceptionObject)

Thank you for reporting this issue. Can you please provide some more information about it?
What version of VS are you using? 2017? 2019?
What are the steps to reproduce it?

@SplatRT, I'd like to look into this issue, but I need more information. Can you please tell me how to reproduce it?

I don't know how to reproduce it.
I am relatively new to python so had a syntax error that I was trying to fix.
I was trying all sorts of things to try to get it to work until this happened:

(I vaguely remember holding the CTRL key at the time the error occurred.)

Created internal bug 941517

Fixed for 16.3 Preview 2.


spelling mistakes

Hi, thank you for contributing! In future, please PR from a topic branch rather than master. Makes things easier for repository maintainer and makes the Git history cleaner.
I've noticed that—in addition to spelling mistakes—you've also changed a lot of the style in some (but not all) documents? I'm assuming this was an automated mistake, especially since many hyphens have been changed to asterisks for some reason. In any case, I have a consistent style and I don't intend to change it, so I can't merge this PR unless the style changes are reverted.

Right, sorry.

Do you intend to fix this PR or will you make another?

Closing as inactive.


How to change minTimeBetweenSessionsMillis from js or sessionTimeout?

How to change minTimeBetweenSessionsMillis from js or sessionTimeout?

Hi @MikePodgorniy
Want to give you an update about this feature. It has been implemented in the latest react native version.

@yuhao900914 Thank you!


what's the difference the fast nms bewteen yolact and ssd

I found  fastnms function in ssd code,so what's the difference between yolact and ssd?

Can you give me a link to where you found this? As far as I know, we're the first to use this way to speed up NMS, but "Fast NMS" is a pretty generic name so it's possible others could have used the same name.

here
https://github.com/weiliu89/caffe/blob/4817bf8b4200b35ada8ed0dc378dceaf38c539e4/src/caffe/util/bbox_util.cpp#L1939

That's not Fast NMS (as described in our paper), it's just traditional NMS. The name of the function, ApplyNMSFast, probably just indicates that they had a less efficient implementation before. Since their implementation of traditional NMS is pretty much exactly the Cython one we have in our repo for comparison (just with some abstraction), it's safe to say that that function is ~12ms slower than our "Fast NMS" algorithm (I'm starting to regret that name).


[v2] Custom certificates not getting stored

Hi,
thanks for the quick reaction on my previous isse.
After beeing able to upload the certificate without errors the proxy won't come up if I set it up to use my custom ssl certificate.
I manager to steal some time off work (;-)) and debugged the issue so far:
Creating a new certificate calls the create function and in the create function the writeCustomCert function is called. However the certificates are not uploaded yet to the express backend but are transferred in a seperate, later upload request.
The upload request triggers an update (instead of create) but nowhere in the upload/update functions the files are written to the disk.
I've added the following code after the patchAndFetchById call in the update method. After Line 230 here: https://github.com/jc21/nginx-proxy-manager/blob/5ac0e3dc95960301ce331e54b68711c484dbad57/src/backend/internal/certificate.js
...
.patchAndFetchById(row.id, data)
.then(certificate => {
  return internalCertificate.writeCustomCert(certificate)
    .then(() => {
      return certificate;
    });
})
.then(saved_row => {
...

It works in regards of the privkey and fullchain files in the data directory but I'm not sure if it's the correct outcome on the database side as the file contents are kept and written in the database.
Perhaps a better place would be the cleanMeta function? Or the upload function itself.
p.s. also the writeCustomCert part in the create function is probably obsolete

Yep you're absolutely right. The writing of custom certs was in the wrong place. I must have written that part in a hurry.
Version 2.0.2 has the fixes now, I've tested this time :)
The reason for the file content to be saved in the database is that it's the source of truth. The contents of the /data folder could be wiped, or not mounted in the docker container and despite being a docker Volume as a persistent fallback, it could still be wiped by accident. Although I haven't included the functionality yet, the idea is that the Nginx config and certificates could be regenerated at any time from the database.
I noticed that the frontend was exposed to the custom certificates file content by accident. I've also fixed that in the 2.0.2 release.
Let me know how you go :)

Works like a charm now :-) 👍


mod_rewrite issue with .well-known directory

Thank you for this great tool! =)
I just tried it and had the following issue:
I use Joomla and url rewrite, so the challenge url was returing a 404 Joomla page.
The solution is to create a new rule in the web.config in the root httpdcos directory.
<configuration>
	<system.webServer>
		<rewrite>
			<rules>
				<rule name="LetsEncrypt Rule" stopProcessing="true">
					<match url="^\.well-known.*$" />
					<action type="None" />
				</rule>

You could read the web.config and check if such a rule would be needed and create it.

I added this to the wiki page, https://github.com/Lone-Coder/letsencrypt-win-simple/wiki/web.config, but this is something that will have to be done manually by anyone using it. The app should not edit the web.config for the root of the site.


Allow registering a type handler for a common interface of enums.

It is common for multiple enums to have a common interface along with a corresponding type handler.
Up to version 3.4.2, to use this type handler, users had to list all the enum implementations in the @MappedType or <typeHandlers />.
This PR allows users to register the type handler against the common interface.
Please see the attached test case for how it works.
Cc-ing @gaohanghbut @liyuj @yxc023 @charlesluo2014 @Hubbitus @fengdh @Fayou @sskeater @jlkm2010
Thought you guys might be interested.

@harawata thanks for your attribution

Hi @harawata, I have one question.
I don't know how to convert to enum instance from result set value using this solution.  I think that it need to set enum type to cutom TypeHandler for converting a enum instance. Could you tell me how to do it ?

@kazuki43zoo ,
I re-checked the code and you are right. This fix is incomplete :(
I'll create another PR soon.
Thank you for the review!

the constractor of custom typehandler has some error
`
public HasValueEnumTypeHandler(Class type) {
if (type == null)
throw new IllegalArgumentException("Type argument cannot be null");
this.type = type;
this.enums = type.getEnumConstants();
`
this.enums is aways null

@mahengyang
type is supposed to be an enum that implements HasValue interface, not the interface itself.

@harawata if there is many enum,we need write every enum type handler in mybatis-config.xml, like this

the handler EnumTypeHandler
public class EnumTypeHandler<E extends Enum<E> & EnumCode> extends BaseTypeHandler<E> {
    private Class<E> type;
    private EnumCode[] enums;

    public EnumTypeHandler(Class<E> type) {
        this.type = type;
        this.enums = type.getEnumConstants();
    }

    @Override
    public void setNonNullParameter(PreparedStatement ps, int i, E parameter, JdbcType jdbcType) throws SQLException {
        ps.setInt(i, parameter.getCode());
    }

    @Override
    public E getNullableResult(ResultSet rs, String columnName) throws SQLException {
        return find(rs.getInt(columnName));
    }

    @Override
    public E getNullableResult(ResultSet rs, int columnIndex) throws SQLException {
        return find(rs.getInt(columnIndex));
    }

    @Override
    public E getNullableResult(CallableStatement cs, int columnIndex) throws SQLException {
        return find(cs.getInt(columnIndex));
    }

    private E find(int status) {
        for (EnumCode enumCode : enums) {
            if (enumCode.getCode() == status) {
                return (E) enumCode;
            }
        }
        return null;
    }
}

@mahengyang ,
Are you actually having a problem, or just reading the code?
this.enums being null should not be a problem because the instance registered against HasValue interface is not used when converting enums (a new instance is created and registered for each enum).
There is a working test case, so if you found a bug, please create a failing test case.
Thanks!
Note that there is a bug in 3.4.4 and you need to use 3.4.5-SNAPSHOT for now (I assumed you knew it seeing your comment on #976 ).

Implementation of the feature is still incomplete.
When used with XMLConfigBuilder.parse, eager instantiation of the defined handlers happens and each enum type need to be explicitly listed.
XMLConfigBuilder.parse is called by mybatis-spring project for example.

@michaelplavnik This PR is already merged. Please create a new issue as related this.


December 2021 Guest OS available but not documented

Guest OS WA-GUEST-OS-6.38_202112-01 is now available for selection but not documented on this page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3a8cc2c5-eb5f-edaf-f155-98e5ff1b252c
Version Independent ID: 8e1a1933-e037-d682-5ba0-50d0f85f12e8
Content: List of updates applied to the Azure Guest OS
Content Source: articles/cloud-services/cloud-services-guestos-msrc-releases.md
Service: cloud-services
Sub-service: auto-os-updates
GitHub Login: @ibthampy
Microsoft Alias: ibthampy

@Dmitry-Me
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@ibthampy
Can you please check and add your comments on this doc update request as applicable.

The image is now documented but contains a number of broken links https://github.com/MicrosoftDocs/azure-docs/issues/86284

Thanks for providing feedback that helps improve our documentation. This issue has been resolved and we are closing the issue. #please-close


[QUESTION]

Description
How can I [...]?
does typer support a session oriented CLI  . specifically, assume I want to implement something like Cisco CLI,  or something like cmd2. in python.  I need to have a session with the back-end and the front end should give me the ability to to a loop run
Is it possible to [...]?
Additional context
Session Oriented CLIs are needed for managing the Remote devices etc.
Add any other context or screenshots about the feature request here.

I'm not sure what you mean with a session oriented CLI.
If you refer to doing authentication with a backend and then keeping it for future commands, then sure, you can implement it, but it wouldn't really depend on Typer.
You would probably ask for a username and password, or launch a browser with a device OAuth2 login website or similar. And then you could store the authentication token in the application directory: https://typer.tiangolo.com/tutorial/app-dir/ and re-use it for the next commands.


matrix multiplication

Python 3.5 introduced @ as the matrix multiplication operator (https://docs.python.org/3/whatsnew/3.5.html#whatsnew-pep-465).  Unfortunately, this syntax file is still highlighting the term after @ as if it was a decorator.

This has been fixed over at the fork vim-python/python-syntax.


[FLINK-16600][k8s] Fix not respecting the RestOptions.BIND_PORT for the Kubernetes setup

What is the purpose of the change
Our current logic only takes care of RestOptions.PORT but not RestOptions.BIND_PORT, which is a bug; for example, when one sets the RestOptions.BIND_PORT to a value different from RestOptions.PORT, jobs could not be submitted to the existing session cluster deployed via the kubernetes-session.sh.
This PR fixes the bug.
Brief change log
Set the RestOptions.BIND_PORT as the target port of the external Service.
Verifying this change
This change can be tested via the existing unit tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)

@flinkbot run travis

@flinkbot run azure

@TisonKun @tillrohrmann @wangyang0918 Could you help take a look at this PR? Thanks a lot in advance！

The changes looks good to me. I agree with @TisonKun that we need to add a new test, which will fails before the changes and pass after it.
For the test, i think we could have the following assumption.

The port of rest service should be equal to rest.port.
The targetPort should be equal to rest.bind-port.

Hi, @TisonKun @wangyang0918 Thanks for your review and comments.
The test case of ExternalServiceDecoratorTest#testBuildAccompanyingKubernetesResources already covers the test branch; before this PR, Line 72 has checked that the service port equals to the rest.port; after this PR, Line 73 checked that the service target port equals to the rest.bind-port, and if we don't add this line, ExternalServiceDecoratorTest#testBuildAccompanyingKubernetesResources will definitely fail.

@TisonKun @zhengcanbin I have checked the test and changes again. If we set rest.bind-port explicitly, the test testBuildAccompanyingKubernetesResources should fail. So updating the test seems reasonable.
Now i give the pass, +1 for merging.


Fix readme links

Pair to https://github.com/computational-cell-analytics/micro-sam/pull/270
That PR fixed the master branch, this PR fixes the dev branch so it doesn't overwrite master later (maybe not a realistic worry, git probably handles it, but just in case). Alternatively, we could merge the changes from the master branch into dev.

Alternatively, we could merge the changes from the master branch into dev.

I would rather merge master into dev. We have recently found an important fix in training that we want to push to master directly and then merge back onto dev. I will follow up on this.


Make particles configurable and js globals easier to set

What this PR does / why we need it:
Particles is now configurable through a particles.json file next to hero fragment. JS globals are no easier to set as well.
Which issue this PR fixes:
fixes #59
Release note:
- BREAKING: `window.synaPortals` changed to `window.syna.portals`
- `window.syna`: All the js global variables are now in this object with default values
- Particles in hero fragment is configurable using a `particles.json` file next to hero fragment

@stp-ip This needs some conflict fixing but I feel like it can still be used. What do you think?

Let's reiterate this in v0.16 I think.

@stp-ip So should we close this one for now?

We can keep it open as we do with the other PRs currently in revisit state.


basemap: create

[x] create BaseMap.vue component
[x] integrate leaflet with image

Planning poker :black_joker: results:

Sum: 36
Average: 4.5


🚧  :new: black CI by GitHub Actions #30

:new: black CI by GitHub Actions for issue #30
In this PR. We need to run GitHub Actions.

@GuillaumeFavelier That is a good question. I don't know it either :thinking: I plan to do some research :mag:

My guess is that this branch is in my fork repository. In other words, you could create a test branch in pyvistaqt and check it there. If you could make a branch, I will reconfigure this PR to merge into it.

This branch is passed in my for repository :+1:

Could you explain what happened? I can see that the github action passed on your patch-1 branch in your repo but I thought that it would be triggered only on master.
Does it mean that there will be a commit "reformat by black" on each PR from now on?
Sorry for the noise, I'm just not used to black.

@GuillaumeFavelier Sorry, my explanation was not enough. This CI is just to check if the PR source code follows black. I pushed the new commit "reformat by black" by myself to fix the CI error :bowing_man:

Otherwise looks fine to me

Please wait while CI pass in https://github.com/tkoyama010/pyvistaqt/pull/1 .

If we use all enable option we have to solve this CI error.
https://github.com/tkoyama010/pyvistaqt/pull/1/checks?check_run_id=881454932

We can still make pylint happy in a follow up PR if necessary :+1:

We can still make pylint happy in a follow up PR if necessary 👍
OK. Let's make pylint PR next time. Could you merge this PR first?

Could you merge this PR first?

Sure, I would just like to wait a little for @akaszynski or @banesullivan opinion before merging if you don't mind.

I'm also an favor of this.  We all have a coding style and it would be great to have a truly uniform one across the project.
I'm going to miss the single quotes though...

Would also like a makefile that runs black.  @tkoyama010, think you could add that?

I'm going to miss the single quotes though...

Same. ' >> ". But with Black, it doesn't even matter. Code how you like, run Black and it should fix em. We can also switch it to prefer single quotes, but they have pretty good reasoning for double quotes

Would also like a makefile that runs black.

Tox is also another way of doing this, but @tkoyama010, do whatever is most simple

Why settle on double quotes? They anticipate apostrophes in English text. They match the docstring standard described in PEP 257. An empty string in double quotes ("") is impossible to confuse with a one double-quote regardless of fonts and syntax highlighting used. On top of this, double quotes for strings are consistent with C which Python interacts a lot with.

On certain keyboard layouts like US English, typing single quotes is a bit easier than double quotes. The latter requires use of the Shift key. My recommendation here is to keep using whatever is faster to type and let Black handle the transformation.

As I'm working with C more on my "real job", it's a bit annoying to switch between the two, so I'll agree that there's value with that.
Tox is indeed another option as well.  I like how it installs the testing env, etc.

@tkoyama010, can you add a makefile (or tox) to do this testing locally?

+1 I'll add this.

Does anyone know what the CI error means?

The CI error is an HTTP error, so it seems to be resolved by retrying.

@pyvista/developers It is ready for merge :+1:

@banesullivan, I think this one needs your approval.  I'm happy with this.

@GuillaumeFavelier @larsoner @banesullivan @akaszynski  Thank you. Now that we have reached an agreement, could you please merge it?


go: 1.13.5 -> 1.13.6, go_1_12: 1.12.10 -> 1.12.15

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@zowoq can you please rebase over the latest master? I've just merged #76944 and I'd like to make sure that the patch still works. Thanks!

Sorry for the noise!!


Network NIC creation with subnet in different resource group fails

Situation:
Resource group Production contains the virtual network vlan. In this vnet the subnet implementation-subnet is created under the resource group Production. In a different resource group implementation, a new nic is created with a reference to the subnet implementation-subnet, as this resource requires access to the main network.
In the Azure Portal it is possible to create the above situation.
Using the Azure-CLI this command fails with The Resource 'Microsoft.Network/virtualNetworks/vlan' under resource group 'implementation' was not found.
az group create -n Production -l westeurope
az group create -n implementation -l westeurope

az network vnet create -g Production --vnet-name vlan

az network vnet subnet create -g Production --vnet-name vlan --address-prefix <IP_ADDRESS>/24 --name implementation-subnet

az network nic create --resource-group implementation --name implementation-nic \
  --vnet-name vlan --subnet implementation-subnet \
  --private-ip-address <IP_ADDRESS>

Any suggestions how to make this work using the CLI. A workaround is using the Portal, but is not preffered.

Hi @jongpieter when you supply names, the CLI resolves those names to the resource group you specify (which can only be one). For your scenario, instead of using --subnet NAME --vnet-name NAME instead use --subnet ID.  By supplying the fully qualified ID for the subnet parameter (and OMIT vnet-name) your scenario should work.

If you want to use programmatically (like in a bash script):
az network vnet subnet show -g {rg} -n {subnet} --vnet-name {vnet} --query id -o tsv
If you just need to copy/paste:
az network vnet subnet show -g {rg} -n {subnet} --vnet-name {vnet} --query id


want to disable or lock selected layers for editing or dragging

How can we disable or Lock Selected Layers for editing or dragging
Steps to regenerate :

Created circle and added to map
called circle.pm.disable() // want to disable editing layer or dragging layer
After Disabling layer I can edit and Drag layer using tools. how can we disable it ?

link : https://codesandbox.io/s/zen-hill-q1evf?file=/src/App.tsx
so i want to disable / lock  selected layers for editing or dragging .
Thank you.

There is no way to lock layers.
Take a look here: https://github.com/geoman-io/leaflet-geoman/issues/583
When you want a locking feature add a thumb up to the feature request above.


Add resilience4j support

Probably the best way to do it would be to switch to an abstraction that would work for both Hystrix and resilience4J (and possibly other implementations), so this issue is dependent on adding those changes in commons (https://github.com/spring-cloud/spring-cloud-commons/issues/21).

@ryandawsonuk Do we have any plans to support resilience4j?

@eacdy I think you mean to ask @ryanjbaxter

That is the purpose of this issue.


Repository name

Describe the bug
Naming this repository just "operator" feels wrong, why is this isn't called "gluster-operator" instead?
Steps to reproduce
Steps to reproduce the behavior:

see the name of this repository

Actual results
The repository is named just "operator"
Expected behavior
The repository is named "gluster-operator"
Additional context
See examples of other operator projects named in a same way:

https://github.com/coreos/etcd-operator
https://github.com/coreos/prometheus-operator

Given that the repo is under the gluster org, it seems somewhat redundant to have gluster/gluster-operator.
Do you know of a situation where the existing name will present a problem?

Do you know of a situation where the existing name will present a problem?

Someone forks it into own github profile and then looking just at the name isn't enough to understand what the repository is about. Similar problem happens when someone clones it into local machine (eg. if I were cloning this repo, I do git clone git@github.com:gluster/operator.git gluster-operator to help myself recalling what this directory is about later).
Imho naming the repository using generic term looks like a bad idea. We have gluster-kubernetes repo and not just kubernetes repo, or gluster-ansible and no just ansible.

@mbukatov After talking it over w/ the rest of the team, we've decided on a bit of a different path than "gluster-operator".
Following the "ant" theme of Gluster, one of the devs (@jarrpa) has been experimenting with an operator under the name "anthill", and we've decided to bring that name forward into the official project.
While this doesn't match your original request for gluster-operator, I hope it does at least satisfy your desire for a unique/memorable name.


fix: fix panel header icon texture check

Fixes a potential crash, where the AsyncTexture2D Panel._icon is not null, but it's internal AsyncTexture2D._activeTexture2D is null.
This may happen if

the AsyncTexture2D is instantiated like new AsyncTexture2D(null)
AsyncTexture2D.SwapTexture(Texture2D) is called like SwapTexture(null)

Discussion Reference
All new features must be discussed prior to code review.  This is to ensure that the implementation aligns with other design considerations.  Please link to the Discord discussion:
PM discussion
Is this a breaking change?
Breaking changes require additional review prior to merging.  If you answer yes, please explain what breaking changes have been made.
No

Thank you!


[5.8] Add runtime for each seeder and overall seeders runtime to output

This PR was inspired by @jwpage #29149
This adds the runtime for each individual seeder and overall seeders runtime to the output of the artisan db:seed command, including artisan migrate --seed. I also changed a bit output format to be more consistent with migrations. I find this useful to get an idea of how long each seeder will take to run and in general. Tired to run time php artisan migrate:fresh --seed
Example output:

@xuanquynh don't think trait is good idea, but helper looks nice!
Added a duration helper in latest commit.

I don't think we need to add more global helpers.

I'm not sure I would make a global helper. I would make some sort of Stopwatch support class if I was going to do this at all.

Let's please indeed not make a global helper. Stopwatch class sounds good :thu

We have already such class in laravel/horizon
We can move this implementation to framework, @driesvints @taylorotwell what do you think?

That would be even better.

Added Stopwatch class.

@driesvints hope, i got you right.

Your stopwatch class says it returns time in milliseconds. Your console output lists time in seconds.

@taylorotwell fixed that.

The stopwatch SHOULD return time in milliseconds. Returning seconds isn't going to be useful in the vast majority of situations.


Reworked readme.md

Tidied up various parts of readme.md. Fixed some spelling, punctuation, and capitalization errors. Reformatted some parts for easier reading.

Thanks for your work,But I'm refactoring this plugins.It will come out soon.There will be a huge improvement,and the readme will be updated.Can i ask you to polish that readme?

have to rewrite readme.


Remove dependency on libatomic on Linux

Due to some unfortunate interplay between clang and libstdc++, clang was
not able to correctly identify to alignment of PoolRange and
SideTableRefCountBits, causing it to emit library calls instead of
inlining atomic operations. This was fixed by adding the appropriate
alignment to those types. In addition to that the march for the Linux
target was set to 'core2', which is the earliest architecture to support
cx16, which is necessary for the atomic operations on PoolRange.

preset=buildbot_incremental_linux,tsan-libdispatch-test
@swift-ci Please test with preset Linux Platform

preset=buildbot_incremental_linux,tsan-libdispatch-test
@swift-ci Please test with preset Linux Platform

Wow!  Nice catch on that.  This is actually going to simplify a few things.

@swift-ci please test Linux platform

Build failed
Swift Test Linux Platform
Git Sha - d913eefcc93f8c80d6d1a6de4ea898a2838d8b6f

@swift-ci please test Linux platform

Build failed
Swift Test Linux Platform
Git Sha - d913eefcc93f8c80d6d1a6de4ea898a2838d8b6f

@swift-ci please test Linux platform

Build failed
Swift Test Linux Platform
Git Sha - d913eefcc93f8c80d6d1a6de4ea898a2838d8b6f

@swift-ci please test Linux platform

Build failed
Swift Test Linux Platform
Git Sha - d913eefcc93f8c80d6d1a6de4ea898a2838d8b6f

@swift-ci please test Linux platform

Build failed
Swift Test Linux Platform
Git Sha - 6db05fdbca83f8d3cacdea94531c643bff94716c

@swift-ci please test Linux platform

Build failed
Swift Test Linux Platform
Git Sha - 34a331eb4d3d298066fd5f16ca66fd5cefb7f71a

I don't think that -march matters at link time.

Yeah, I don't know why it's failing in the first place. It emits __sync call in the LongRefcountingTest. That's why I tried adding the march there as well. I have so for been unable to reproduce this locally.

@swift-ci please test Linux platform

Build failed
Swift Test Linux Platform
Git Sha - feb7bb1a0654384add15de1ba4005910c630f474

Ok, just reproduced the __sync issue in a 16.04 VM. Working on a fix.

@swift-ci please test Linux platform

Build failed
Swift Test Linux Platform
Git Sha - 525f408445181d58e0d4b63a6b114a88ff1d9f98

@swift-ci please smoke test

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - d913eefcc93f8c80d6d1a6de4ea898a2838d8b6f

@compnerd Figured it out. The problem was that I used APPEND instead of APPEND_STRING in the cmake file to append the compiler flag.

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 62a5ebb6a2927c0976a00211470c6ac4c869fc86

Build failed
Swift Test Linux Platform
Git Sha - 62a5ebb6a2927c0976a00211470c6ac4c869fc86

Can one of the admins verify this patch?

@swift-ci please test


Fix various typos

Misspellings and minor grammar issues

@TylerMSFT - can you review the proposed changes?  These are mostly oblivously correct, but you might check and confirm the changes in these files:

collections-c-cx.md
platform-collections-unorderedmap-class.md
weak-references-and-breaking-cycles-c-cx.md

IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Mqtt command back to wallpanel app

Hello :)
I need help from mqtt. After ringing my doorbell, wallpanel opens the Reolink application. I would need an mqtt command to close reolink application or re-open the wallpanel application with a mqtt command.
This command for reolink application
service: mqtt.publish
data:
  topic: wallpanel/mywallpanel/command
  payload: '{"url": "intent:#Intent;launchFlags=0x10000000;component=com.mcu.reolink/com.android.bc.login.WelcomeActivity;end"}'

Hey,
Unfortunately it's not possible how it's implemented right now. The WebView has to be on the screen for this to work properly. I'm also not sure if you can even open intents in the background from Android 10 onwards.

I have a similar use case where I would like to call a service to control brightness on my Lenovo Smart Clock 2. Would it be possible to implement support for calling services?


Tag mongo:4.2 Image, Environment Variables, and TLS are Incompatible

Using env MONGO_INITDB_ROOT_USERNAME and MONGO_INITDB_ROOT_PASSWORD forces the mongo docker image mongo:4.2 to default to net.ssl, which is deprecated. Therefore, on image mongo:4.2, if you use MONGO_INITDB_ROOT_USERNAME and MONGO_INITDB_ROOT_PASSWORD, you are unable to use net.tls settings.
Results in error:
Docker Run with TLS
docker run -d --name=mongo42-example \
-e MONGO_INITDB_ROOT_PASSWORD=Example \
-e MONGO_INITDB_ROOT_USERNAME=Example \
-v /keyfile:/keyfile mongo:4.2 --tlsMode requireTLS --tlsDisabledProtocols TLS1_1 --tlsCertificateKeyFile /keyfile/keyfile.pem

Error Message
W  CONTROL  [main] Option: sslMode is deprecated. Please use tlsMode instead.
F  CONTROL  [main] Failed global initialization: BadValue: net.ssl.mode is not allowed when net.tls.mode is specified

SSL Mode Without Error:
Docker Run with SSL
docker run -d --name=mongo42-example \
-e MONGO_INITDB_ROOT_PASSWORD=Example \
-e MONGO_INITDB_ROOT_USERNAME=Example \
-v /keyfile:/keyfile mongo:4.2 --sslMode requireSSL --sslDisabledProtocols TLS1_1 --sslPEMKeyFile /keyfile/keyfile.pem

That sounds like we need to improve these lines to account for tlsMode too:
https://github.com/docker-library/mongo/blob/687a397947f374e3bd6dbdf00a98753584833d96/docker-entrypoint.sh#L256-L257
and maybe these ones:
https://github.com/docker-library/mongo/blob/687a397947f374e3bd6dbdf00a98753584833d96/docker-entrypoint.sh#L152-L158

While a fix is developed, you can just use the ssl versions of the arguments, since they work the same.

Starting in version 4.2, MongoDB provides net.tls settings (and corresponding command-line options) that corresponds to the net.ssl settings (and their corresponding command-line options). The net.tls settings provide identical functionality as the net.ssl options since MongoDB has always supported TLS 1.0 and later.
https://docs.mongodb.com/manual/tutorial/configure-ssl/#procedures-using-net-tls-settings


res.download repeating file contents after 4 GB

I ran into an issue sending files over 4 GB. Comparing the file on the server to the one downloaded reveals that the content starts all over again (shout out to Beyond Compare for being able to visualize 2 6 GB files).
Considering the point where it resets it looks like an overflow of an unsigned 32-bits integer, so to get the obvious question out of the way: the application is running on Debian 64-bits, ext4, Node 10.0.0 and have verified that it's the 64-bits version using file /usr/bin/node.
To confirm the issue wasn't anywhere else in my code I wrote a very simple test application which sends a 6 GB file:
const express = require('express');
const app = express();

app.get('/', (req, res) =>
{
        res.download('/home/recv/bac7a55f35799974779b62a24e773939', 'test');
});

var server = app.listen(3456, () => console.log('Running'));

I also tried res.sendFile, both failed; the file size is exactly right but the contents repeat.
What is interesting however is that if I pipe the file directly it arrives intact:
app.get('/', (req, res) =>
{
        res.setHeader('Content-Disposition', 'attachment; filename="test2"');
        fs.createReadStream('/home/recv/bac7a55f35799974779b62a24e773939').pipe(res);
});

Of course Express does a lot more, and I'd rather not try to recreate that. I made an attempt to figure out why there is a difference from the source code but no luck yet. Perhaps someone with more inside knowledge can tell what is going on? I couldn't find any other report, so I'm certainly not ruling out that the issue is on my end.
Thanks for any help debugging this issue!

What version of Node.js are you using? Early versions of Node.js 10 have the bug you are describing so I would like to rule that out.

Sorry, just saw you said Node.js 10.0.0. The bug was fixed in Node.js 10.3.0. You need to downgrade back to a prior version of Node.js than you are using or upgrade to at least 10.3.0.

I see my google-fu failed me, thanks for the quick reply! I upgraded to 10.10 and the issue is gone.

And if upgrading / downgrading your Node.js version does not fix the issue, please let us know and we can work to reproduce and investigate further :) !

Oops, posted at the same time. Thanks for confirming!


Upload processed data to Panoptes

We need a way of uploading the initial data set once it's been selected - I started work on a subject upload library for Node, but it got derailed by AnnoTate.
Related to #35 and #50

All the images they sent us are now available at https://static.zooniverse.org/old-weather-2015/. Take the original paths and replace spaces and punctuation with underscores (literally s/[^0-9a-zA-Z/.-]+/_/).
E.g. https://static.zooniverse.org/old-weather-2015/Cold_Science/Coast_Guard/Westwind_WAGB-281_/westwind-wagb-281-1956-split/westwind-wagb-281-1956_0129-1.JPG
We should be able to give those URLs directly to Panoptes rather than uploading them again.

Ongoing...


Decoration

[ ] Banners

[ ] Standees/hordings/hangings

[ ] Halls

[ ] Campus

Decorations, Swag and Stationery are pending need immediate assistance for that.


[Draft] MultiMc and PrismLauncher instance generation

I need opinions on the GUI and cli endpoints for this.
For the GUI I am considering

a separate tab for this, which would be identical to the client installation tab except the directory selection has a different default value
a checkbox like generate mmc pack in the client tab

@SpaceWalkerRS any opinions?

a checkbox like generate mmc pack in the client tab

perhaps a drop-down menu to select the launcher to install into?

perhaps a drop-down menu to select the launcher to install into?

That sounds like an alright idea, I'll try implementing that tomorrow

I implemented the Gui for this (a drop-down menu is what I went with), so basic functionality is fully done.
Need to add some way to access this via the CLI, although that could be a separate PR.
Maybe some code restructuring need to be done, perhaps the logic for pack generation should be in an Action class like InstallClient?

I implemented the Gui for this (a drop-down menu is what I went with), so basic functionality is fully done. Need to add some way to access this via the CLI, although that could be a separate PR.

sounds good, we can look at that once this PR is merged in

Maybe some code restructuring need to be done, perhaps the logic for pack generation should be in an Action class like InstallClient?

Hmmm. This would be more invasive, but I think it'd make more sense to keep the single InstallClient action and split the launcher specific code into separate classes.

Hmmm. This would be more invasive, but I think it'd make more sense to keep the single InstallClient action and split the launcher specific code into separate classes.

Oh I think I phrased that badly, I meant to say like create a separate Action like InstallClient

Fully tested it, there shouldn't be any issues, unless you want me to turn MmcPackCreator into an Action it should be ready to be merged now

All ready to merge now, tested it and everything seems to be in order


Python SDK improvements

Implements FSID and SecretID types
Fixes a typo in the logger
Implements json serialization in case the resolver returns a custom type

@helderco I'll let you review/merge this one. I'd recommend merging it before adding anything to the python sdk

merged based on discord conversation with Helder.


Add express-style error handler

Adds an express style error handler to reduce error handling code duplication.
This will fix #68.

Did a self review and I'm happy. Before this can go to full prod I'll need to test pretty much all functionality


NEW INDEX: NDTI

NDTI=SpectralIndex(
    short_name='NDTI',
    long_name='Normalized Difference Turbidity Index',
    formula='(R - G) / (R + G)',
    reference='https://doi.org/10.1016/j.rse.2006.07.012',
    type='water',
    date_of_addition='2022-09-29',
    contributor="https://github.com/CvenGeo"
)

Hi @CvenGeo!
I revised your index suggestion and it was perfectly aligned with the Awesome Spectral Indices (ASI) standard!
The index was added to the catalogue and it will be available in the next version of ASI.
Cheers!


Failed to process trigger in block

After a lot of subgraphs were added, found out some errors for a few of them.
What is the current behavior?
QmSXzWZhbDgDg9YyDeivFqYBc1zxESyBYBH3W9CzmupYQd | Failed to process trigger in block #10802337 (9ee254cca1ae3726a79319b88c10f02002d04597990982f946b1189bfebd1287), transaction acc9d9d5c4168e079be4c47eaf1e28c686efe30dc081073e2a60423413ffebee: Failed to invoke handler 'handleBurnedSynths': Mapping aborted at<EMAIL_ADDRESS>line 439, column 6, with message: Call reverted, probably because an `assert` or `require` in the contract failed, consider using `try_balanceOf` to handle this in the mapping. wasm backtrace: 0: 0x1bd1 - <unknown>!<wasm function 75> 1: 0x1bf2 - <unknown>!<wasm function 76> 2: 0x21f0 - <unknown>!<wasm function 119> 3: 0x2d58 - <unknown>!<wasm function 149> | -
-- | -- | --
QmWNP1jqMZm61G8FbsLzi9Mnii5qRXbkadBxXVHZPqzKri | Failed to process trigger in block #10693164 (26c8487ab77c86e5d166228ca90016653b316e4a993a7bf6c4e64f9f47a0b60c), transaction 553877cea2c29f6d251ce7ce24588256285c78fac3becc7b64ca64a30b2a1e83: Failed to invoke handler 'handleRedeemed': Mapping aborted at<EMAIL_ADDRESS>line 1356, column 4, with message: Call reverted, probably because an `assert` or `require` in the contract failed, consider using `try_getBasketManager` to handle this in the mapping. wasm backtrace: 0: 0xfdb - <unknown>!<wasm function 34> 1: 0x102e - <unknown>!<wasm function 37> 2: 0x1956 - <unknown>!<wasm function 85> 3: 0x1a3d - <unknown>!<wasm function 86> 4: 0x1f7c - <unknown>!<wasm function 125> | -
QmNs5fU6VkyGUsaNsa5sUHEKpzCA5AZWKJG8LaBrcCRpmW | Failed to process trigger in block #9663088 (ffe26e8316eff7c71d192925b72d5529828bc115a29b51c25da3d7b143c30894), transaction 0adcf37d5ea87ad72013c09baf073b77477cf65b59b6145845cefd4ade625305: Failed to invoke handler 'handleTokenExchangeUnderlying': Mapping aborted at<EMAIL_ADDRESS>line 1356, column 4, with message: Call reverted, probably because an `assert` or `require` in the contract failed, consider using `try_getPricePerFullShare` to handle this in the mapping. wasm backtrace: 0: 0x149c - <unknown>!<wasm function 56> 1: 0x24de - <unknown>!<wasm function 152> 2: 0x2637 - <unknown>!<wasm function 155> 3: 0x280a - <unknown>!<wasm function 158> 4: 0x2ee5 - <unknown>!<wasm function 167>

What is the expected behavior?
No errors

Please provide more information on why this is unexpected and what are the instructions to reproduce.

outdated

Handler skipped due to execution failure, error: Mapping aborted at<EMAIL_ADDRESS>line 439, column 6, with message: Call reverted, probably because an assert or require in the contract failed, consider using try_getReserves to handle this in the mapping. wasm backtrace: 0: 0x181f -<EMAIL_ADDRESS>1: 0x27fe -
Getting similar error while deploying sushi subgraphs , this try_methodName causing issues...anyone got ideas?

@akme Why is this outdated? Can you please explain what the fix or change is?

I don't even remember what the root cause was, but the error has gone, so I marked it as outdated, if you face any issues like this, better open new issue.

having the same issues

having the same issues

having the same issues

I am having the same issue
Mapping aborted at<EMAIL_ADDRESS>line 681, column 7, with message: Call reverted, probably because an assert or require in the contract failed, consider using try_admin to handle this in the mapping. wasm backtrace: 0: 0x3440


Angular.json file is missing.how i can get that file or other way to run project?

You need to create a new Angular project using the CLI tool and import this into that application to get started. That will contain the angular.json file.


Added new test for Splitting Dependency Graph to different levels

Added new test for Splitting Dependency Graph to different levels

Cool! thank you. Will check soon and merge.


        If ignore_errors is set, errors are ignored; otherwise, if onerror
        is set, it is called to handle the error with arguments (func,
        path, exc_info) where func is os.listdir, os.remove, or os.rmdir;
        path is the argument to that function that caused it to fail; and
        exc_info is a tuple returned by sys.exc_info().

        If ignore_errors is set, errors are ignored; otherwise, if onerror
        is set, it is called to handle the error with arguments (func,
        path, exc_info) where func is os.listdir, os.remove, or os.rmdir;
        path is the argument to that function that caused it to fail; and
        exc_info is a tuple returned by sys.exc_info().

        If ignore_errors is set, errors are ignored; otherwise, if onerror
        is set, it is called to handle the error with arguments (func,
        path, exc_info) where func is os.listdir, os.remove, or os.rmdir;
        path is the argument to that function that caused it to fail; and
        exc_info is a tuple returned by sys.exc_info().  If ignore_errors
        is false and onerror is None, an exception is raised.

        """
        if ignore_errors:
            def onerror(*args):
                pass
        elif onerror is None:
            def onerror(*args):
                raise
        try:
            if os.path.islink(path):
                # symlinks to directories are forbidden, see bug #1669
                raise OSError("Cannot call rmtree on a symbolic link")
        except OSError:
            onerror(os.path.islink, path, sys.exc_info())
            # can't continue even if onerror hook returns
            return
        names = []
        try:
            names = os.listdir(path)
        except os.error, err:
            onerror(os.listdir, path, sys.exc_info())
        for name in names:
            fullname = os.path.join(path, name)
            try:
                mode = os.lstat(fullname).st_mode
            except os.error:
                mode = 0
            if stat.S_ISDIR(mode):
                rmtree(fullname, ignore_errors, onerror)
            else:
                try:
>                   os.remove(fullname)
E                   WindowsError: [Error 123] The filename, directory name, or volume label syntax is incorrect: 'c:\\users\\ycaspi\\appdata\\local\\temp\\coverage_test/tests_test_summary_SummaryTest_test_accenteddotpy_not_python_50300188\\accented?.py'

c:\python27\Lib\shutil.py:250: WindowsError
---------------------------- Captured stdout call -----------------------------
No file to run: 'accented?.py'

accented?.py   NoSource: No source for code: 'C:\Users\ycaspi\AppData\Local\Temp\coverage_test\tests_test_summary_SummaryTest_test_accenteddotpy_not_python_50300188\accented?.py'.
Aborting report output, consider using -i.

E   - accented?.py NoSource: No source for code: 'C:/Users/ycaspi/AppData/Local/Temp/coverage_test/tests_test_summary_SummaryTest_test_accenteddotpy_not_python_50300188/accented?.py'.
\x1b[31m\x1b[1mE   + accented\xe2.py NotPython: Couldn't parse 'accented\xe2.py' as Python source: 'error' at line 1\x1b[0m
---------------------------- Captured stdout call -----------------------------
No file to run: 'accented?.py'

accented?.py   NoSource: No source for code: 'C:\Users\ycaspi\AppData\Local\Temp\coverage_test\tests_test_summary_SummaryTest_test_accenteddotpy_not_python_50300188\accented?.py'.
Aborting report output, consider using -i.
Name    Stmts   Miss  Cover
---------------------------
No data to report.

=========================== short test summary info ===========================
FAIL tests/test_process.py::UnicodeFilePathsTest::test_accented_directory
FAIL tests/test_process.py::UnicodeFilePathsTest::test_accented_dot_py
FAIL tests/test_summary.py::SummaryTest::test_accenteddotpy_not_python
============================== warnings summary ===============================
.tox\py27\lib\site-packages\dns\hash.py:25
  C:\Projects\Github\coveragepy\.tox\py27\lib\site-packages\dns\hash.py:25: DeprecationWarning: dns.hash module will be removed in future versions. Please use hashlib instead.
    DeprecationWarning)
  C:\Projects\Github\coveragepy\.tox\py27\lib\site-packages\dns\hash.py:25: DeprecationWarning: dns.hash module will be removed in future versions. Please use hashlib instead.
    DeprecationWarning)
  C:\Projects\Github\coveragepy\.tox\py27\lib\site-packages\dns\hash.py:25: DeprecationWarning: dns.hash module will be removed in future versions. Please use hashlib instead.
    DeprecationWarning)

-- Docs: https://docs.pytest.org/en/latest/warnings.html
3 failed, 799 passed, 41 skipped, 3 warnings, 3 error in 99.75 seconds
ERROR: InvocationError for command 'C:\\Projects\\Github\\coveragepy\\.tox\\py27\\Scripts\\python.EXE igor.py test_with_tracer py' (exited with code 1)
____________________________________________________ summary ____________________________________________________
ERROR:   py27: commands failed

Thanks for the report.  Can you tell me what codepage your machine is set to?  What does this print?
python2.7 -c "import sys; print sys.getdefaultencoding(), sys.getfilesystemencoding()"

C:\Users\ycaspi>python -c "import sys; print sys.getdefaultencoding(), sys.getfilesystemencoding()"
ascii mbcs

@yoavcaspi I'm not sure I can debug this problem.  Are you able to step into these tests to see what's going on?

I'll do my best.

From what I found so far:
Line 27-28 in tests.helpers.py encode the code to be in ascii.
As far as I understand python 2.7 does not support subproccess.Popen to get unicode on Windows.
https://bugs.python.org/issue19264.
What do you think?

@yoavcaspi Thanks for persisting with this, I'm afraid it's going to be a long process.  Can you run this program and post the results?:  https://github.com/nedbat/pydoctor
And at line 29 in tests/helpers.py, can you add this?
    if env.PY2 and isinstance(cmd, unicode_class):
        cmd = cmd.encode(sys.getfilesystemencoding())

    print(repr(cmd))   ## <-- add this line

and let's see what it shows?
Thanks.

The print(repr(cmd)) printed:
'coverage run --source=. ?/accented.py'
The pydoctor: (I ran it from my tox virtualenv)
(py27) C:\Projects\Github\coveragepy>.tox\py27\Scripts\python.exe ..\pydoctor\doctor.py
doctor.py version 3
--- version ---------------------------------
The version of Python, and other details.
Python version:
2.7.13 (v2.7.13:a06454b1afa1, Dec 17 2016, 20:53:40) [MSC v.1500 64 bit (AMD64)]
Python implementation: 'CPython'
Python executable: 'C:\Projects\Github\coveragepy\.tox\py27\Scripts\python.exe'
Python prefix: 'C:\Projects\Github\coveragepy\.tox\py27'
This is a virtualenv.
The real prefix is: 'c:\python27'
--- os --------------------------------------
Details of the operating system.
Current directory: 'C:\Projects\Github\coveragepy'
Platform: 'Windows-10-10.0.16299'
uname: ('Windows', 'ycaspi-MOBL3', '10', '10.0.16299', 'AMD64', 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel')
Environment variables:
**** Some non related Environment variables.
--- sizes -----------------------------------
Sizes of integers and pointers.
sys.maxsize:<PHONE_NUMBER>854775807L, indicating 64-bit
sys.maxint:<PHONE_NUMBER>
--- encoding --------------------------------
Information about encodings and Unicode.
sys.maxunicode: 65535, indicating a narrow Unicode build
sys.getdefaultencoding(): 'ascii'
sys.getfilesystemencoding(): 'mbcs'
locale.getpreferredencoding(): 'cp1255'
sys.stdin.encoding: 'cp862'
sys.stdout.encoding: 'cp862'
--- locale ----------------------------------
Information about locale.
locale.getpreferredencoding(): 'cp1255'
locale.getlocale(LC_COLLATE): (None, None)
locale.getlocale(LC_CTYPE): (None, None)
locale.getlocale(LC_MONETARY): (None, None)
locale.getlocale(LC_NUMERIC): (None, None)
locale.getlocale(LC_TIME): (None, None)
--- path ------------------------------------
Details of the path used to find imports.
sys.path:
'C:\Projects\Github\pydoctor'
'C:\WINDOWS\SYSTEM32\python27.zip'
which doesn't exist
'C:\Projects\Github\coveragepy\.tox\py27\DLLs'
which doesn't exist
'C:\Projects\Github\coveragepy\.tox\py27\lib'
'C:\Projects\Github\coveragepy\.tox\py27\lib\plat-win'
which doesn't exist
'C:\Projects\Github\coveragepy\.tox\py27\lib\lib-tk'
which doesn't exist
'C:\Projects\Github\coveragepy\.tox\py27\Scripts'
'c:\python27\Lib'
'c:\python27\DLLs'
'c:\python27\Lib\lib-tk'
'C:\Projects\Github\coveragepy\.tox\py27'
'C:\Projects\Github\coveragepy\.tox\py27\lib\site-packages'
'c:\projects\github\coveragepy'
'C:\Projects\Github\coveragepy\.tox\py27\lib\site-packages\covtestegg1-0.0.0-py2.7.egg'

@yoavcaspi help me understand your situation, so we can decide what to do.  Are you running the tests because you had an actual failure with an accented file name? Or just to run the entire test suite?  We could skip those tests for "mbcs", but I fear that would just hide an actual problem under your configuration.
Can you try some tests of running coverage on an accented file name like the test is trying to do?

Basically I wanted to contribute in some way to coveragepy and my first initial thought was to make sure all the tests are passing so I will know if I break anything. Since I'm using Windows it seems to be harder than I thought.
running coverage on accented filename is working without the unittest, any from my understanding it because the Popen case in python 2.7.
The problem is that the tests for python 3 also not working with some other issues.
what do you recommend?

If we could get the tests running on your machine, it will be better in the long run.  If coverage works with an accented filename, but the tests fail, then there is something wrong with the tests.  I'd like to know what it is, but it's hard to debug remotely.
So I guess it depends what you want to do: you could debug through coverage as it deals with the accented file, and see why those steps are different than what the test does.  Or you could look into the Python 3 test failures.  Or something else...

Any news on this?

If you come back to this, feel free to re-open the issue.


use monoio

ability to switch to use https://github.com/bytedance/monoio instead

This is a dupe of #94, so let's talk there.


[FIX] sanitize connection.uri for mongo

[ ] Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

[ ] No need to
[ ] Manually (please, describe, if necessary)
[x] Unit checks
[ ] Integration checks
[ ] Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
[ ] My changes generate no new warnings (e.g. Sonar is happy)
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged

Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)

@freeformz can you check please

@freeformz @joschi can you please review

I doubt this is going to get accepted here, I suggest checkout out @kafbat/, which seems to be the successor.


Unable to follow Vernissage users from Misskey instances

Users on Vernissage can be searched on Misskey, but it's impossible to follow them; in fact, the follow request will be displayed as "pending". This doesn't apply to other apps like Mastodon or Pixelfed, from which Vernissage users can be followed.

Confirmed this happens with IceShrimp latest
(the fork of misskey12/firefish, not the in progress rewrite to dot net).