[Fix #3512] Change error message of Lint/UnneededSplatExpansion for array

In case of array splat for method parameter, the default message was
ambiguous. Unnecessary splat expansion. made people just remove the
splat expansion and pass the array as parameter which is obviously not
the same as passing splat arguments. Change the message to
Pass array contents as separate arguments. in such cases.
Fixes #3512

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Used the same coding conventions as the rest of the project.
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] All tests are passing.
[x] The new code doesn't generate RuboCop offenses.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.

I like the message improvement.

👍


load_json() and viewer cannot not work in mac

Required Info

Camera Model
D400

Firmware Version
<IP_ADDRESS>

Operating System & Version
MacOS

Kernel Version (Linux Only)
--

Platform
High Sierra 10.13.3

SDK Version
SDK 2.0 (Build 2.10.1)

Issue Description

dev.load_json(str) failed when coding like below. the same code works well in ubuntu(with json-file path being modified.)

    pipe.start();
    auto profile = pipe.get_active_profile();
    std::ifstream t("/Users/uncle/Documents/Algorithm/IntelRealSense/higacc.json");
    std::string str((std::istreambuf_iterator<char>(t)), std::istreambuf_iterator<char>());
    rs400::advanced_mode dev = profile.get_device();
    dev.load_json(str);

here is the error log:
RealSense error calling rs2_load_json(dev:0x1018acdc0, json_content:0x102043200, content_size:2986):
    get_xu(id=2) failed! Last Error: No such file or directory
Program ended with exit code: 1

I cannot tune any params (and other presets) with viewer, it reports an error.

by the way, when sample code running, it always reports unsupported descriptor subtype: 13( eg. capture example)

I have the exact same issues (also on MacOS 10.13.3) using a D435.
Note that I recorded to a rosbag file on another computer (using windows) and when I load that file instead of using a device, those errors do not occur. I am able to retrieve camera intrinsics from the recording for example, but not from the device. The same code works fine on windows.

We are investigating this problem and will update soon

I tried a couple of things after building from the development branch (that is the correct one, right?). I tried both with the default cmake settings, and with ENABLE_ZERO_COPY enabled. Both with the same results.
The rs-align example still fails with
RealSense error calling ():     Frame of requested stream type was not found!
The unsupported descriptor subtype: 13 messages seem to be gone.
When starting realsense-viewer, the following messages are in the console:
06/04 12:37:31,037 WARNING [0x70000c1f5000] (sensor.cpp:315) Unregistered Media formats : [ 2 P UYVY ]; Supported: [ ]  06/04 12:37:31,051 WARNING [0x70000c1f5000] (sensor.cpp:315) Unregistered Media formats : [ RW16 ]; Supported: [ ]
When I try to switch to a different preset, I get this error:
06/04 12:40:02,572 WARNING [0x7fff97bda340] (types.cpp:57) get_xu(ctrl=1) failed! Last Error: Operation timed out
When I pull out the USB cable (while streaming), the realsense viewer application hangs.
In my own application, except for the unsupported descriptor message being gone, not much seems to have changed.
This is the error I get when trying to check and set advanced mode (part of it is my own logging):
[RealSenseCamera::checkAdvancedMode] RealSense exception calling rs2_is_enabled(dev:0x7fa28378ec90, enabled:0):     get_xu(ctrl=1) failed! Last Error: No such file or directory
The same when I try to fetch the field of view:
[RealSenseCamera] Error getting horizontal FOV: set_xu(ctrl=1) failed! Last Error: No such file or directory
When I force my application to get to the preset json loading part, I get the same set_xu error.
Kind regards,
Jeroen

Also, an unrelated problem that still exists (just putting it here): when you don't put in the USB cable quickly enough, the device is recognized as a USB2 device.

Hi,
Is there a way for the moment to set for exemple

param-leftrightthreshold
param-regionshrinku
param-regionshrinkv

with another way than the loadJson() ?
Maybe the same way than this ? :

//Set preset
    auto sensors = dev.query_sensors();
    rs2::sensor depth_sensor = sensors.at(0);
    rs2::sensor rgb_sensor = sensors.at(1);

    if (depth_sensor.supports(RS2_OPTION_LASER_POWER))
    {
        // Query min and max values:
        auto range = depth_sensor.get_option_range(RS2_OPTION_LASER_POWER);
        depth_sensor.set_option(RS2_OPTION_LASER_POWER, range.max); // Set max power
    }
    if (depth_sensor.supports(RS2_OPTION_GAIN))
    {

        depth_sensor.set_option(RS2_OPTION_GAIN, 30.f);
    }
    if (rgb_sensor.supports(RS2_OPTION_GAIN))
    {
        rgb_sensor.set_option(RS2_OPTION_GAIN,65.f);
    }

Same issue here. Using the latest from master, D415, macOS.

We are still investigating the error. @EladZucker feel free to communicate any of your findings so far.

Should be resolved in v2.10.4, please let us know if you still see the problem

[Realsense Customer Engineering Team Comment]
hi @uncleyoung, @OpenJeDi, @holstenholsten,
this issue should be fixed already, could you please confirm and let me know if you need more support on this topic.
thanks.


Enable build on ubu 18.04 using ssl 1.1

SSL 1.1 makes the internal structures in openssl opaque and accesses via accessor functions.  Is the email maybe wrong?

@yakman2020 can you fix the authorship on the commits? They're mismatched and not syncing to your account.

bors try

bors try

bors try

bors try

bors try

@yakman2020 I'd love to get this PR in as I am sick of not being able to build on my (faster) local VM, and don't want to stand up a new one. Can you please address the existing reviews and dismiss them if they're stale?

bors try

@yakman2020 Thanks for doing this! Super useful.


[Meta] MacOS GH compile not working

What it says on the tin. I know MacOS about as well as I know C, which is not at all. Anyone know how we can unfuck this?

Is it related to this?
https://github.blog/changelog/2022-07-20-github-actions-the-macos-10-15-actions-runner-image-is-being-deprecated-and-will-be-removed-by-8-30-22/

I think we drop MacOS, follow Soji's lead.

@XA-38, sounds about right.
As for dropping Mac support, we might want to take an assessment of how many community members run it on what OS before we pull the plug.

While we figure this out, I say we stop building in CI, it'll help with unfucking our checks.

I am able to compile and run YSFlight on macOS 13 (Ventura) using a MacBook Air (M2, 2022). I had to install XCode, Cmake, and Python. I used Python 2. Python 3 should also work, but I ran into some issues with trying to get /bin/sh (used by Cmake) to use python as an alias for python3. Otherwise, I just had to follow the Cmake instructions under Tools -> How to Install For Command Line Use to be able to run cmake from the command line and I was able to build.

I think we drop MacOS, follow Soji's lead.

Soji dropped iOS not MacOS.


[BUG] cut pages are not lined up

Describe the bug
cut pages are not lined up
To Reproduce
Steps to reproduce the behavior:
cutting more than 4 components
Expected behavior
I hope the cut pages are lined up. in grid system
Screenshots

Chrome version

[e.g. 67]

Additional context
Add any other context about the problem here.

I think vuetify is useful.

Actually it's not a grid system and the boxes are aligned well since their size is mutable based on the inner content's height.
Also Vuetify is just a framework that helps developers create stable user interface with ease. But it's not a true solution for an unique, custom software like webuffet.
Anyway, thanks for your suggestion.


send a number throught DialogTestClient class's sendActivity method

Hello,
I am using the botbuilder DialogTestClient 's sendActivity method to send prompts to my bot while testing but the method only accepts string types and in my bot i use number promts to prompt the user for numbers . Do you have any idea on how i can overturn this problem ?
Thanks in advance

We generally direct usage questions to StackOverflow, please ask there.


fix(ui): remove destiny tracker hardcoded size

This PR remove the hardcoded destiny tracker window size, allowing it to grow and shrink.
This is only a partial fix for #1688, as the UI still has to be reloaded before the window will shrink or grow, but I couldn't find how to trigger a window redraw (which hook to use).

@obrenckle I don't have a clean environment set up for this. Have you tested the removal of the sizing with a clean world? I'm concerned it'll be improperly sized.

Nah, no need to go overboard. A private session might be helpful to avoid any caching, though.
Thanks again, by the way. Your contributions are awesome :)

@wrycu I juste tried with a completely new world, the tracker appears at the correct position with the correct size

By the way, there seem to be some tests implemented, but I couldn't make them work following the CONTRIBUTING.md file. Do you know if they are functional ?

They aren't functional. I don't think they've been updated since Foundry 0.6.0. I would absolutely love to get some end-to-end tests going, but have been unable to find a framework which works with Foundry (especially the drag-and-drop aspect.) If you find something functional, LMK and I'll carve time out to get tests written.


Sync with master

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/Create-Packages/Dependency-Versions.md
:white_check_mark:Succeeded

docs/Guides/Create-UWP-Controls.md
:white_check_mark:Succeeded

docs/Schema/Target-Frameworks.md
:white_check_mark:Succeeded

docs/Schema/nuspec.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


docs(android_alarm_manager_plus): Fix example and docs to explain required annotation

Description
Fix for a problem with android_alarm_manager_plus not working in release mode on Flutter 3.3.0 and newer.
It seems that due to recent changes to a tree-shaking quite a few plugins started to have issues with isolates when app is built in release mode.
The main requirement is to annotate the callback function with @pragma('vm:entry-point') in the app where the plugin is used. So I have updated the README and docs to mention this requirement.
Here is the list with similar issues or issues on topic:
https://github.com/flutter/flutter/issues/109248
https://github.com/firebase/flutterfire/issues/9446
https://www.reddit.com/r/flutterhelp/comments/x3tq8l/package_not_found_in_release_but_there_in_debug/
And this is the issue about missing documentation update about the change that broke multiple plugins in the community:
https://github.com/flutter/website/issues/7564
Related Issues
Closes #1077
Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I titled the PR using Conventional Commits.
[x] I did not modify the CHANGELOG.md nor the pubspec.yaml files.
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
[x] No, this is not a breaking change.

The pragma vm entry solution was already mentioned before: https://github.com/fluttercommunity/plus_plugins/issues/1061

but I wasn't sure if it worked or not.

I have tested on our example app and it worked after adding this annotation.


Cannot connect the bot

What i'm doing wrong?
sh ./launch.sh                                                                                [12/218]
Running virtualenv with interpreter /usr/bin/python2
New python executable in .venv/bin/python2
Also creating executable in .venv/bin/python
Installing setuptools, pip...done.
Downloading/unpacking Mastodon.py
Downloading Mastodon.py-1.2.1-py2.py3-none-any.whl
Downloading/unpacking requests (from Mastodon.py)
Downloading requests-2.18.4-py2.py3-none-any.whl (88kB): 88kB downloaded
Downloading/unpacking python-dateutil (from Mastodon.py)
Downloading python_dateutil-2.6.1-py2.py3-none-any.whl (194kB): 194kB downloaded
Downloading/unpacking six (from Mastodon.py)
Downloading six-1.11.0-py2.py3-none-any.whl
Downloading/unpacking decorator (from Mastodon.py)
Downloading decorator-4.2.1-py2.py3-none-any.whl
Downloading/unpacking pytz (from Mastodon.py)
Downloading pytz-2017.3-py2.py3-none-any.whl (511kB): 511kB downloaded
Downloading/unpacking certifi>=2017.4.17 (from requests->Mastodon.py)
Downloading certifi-2018.1.18-py2.py3-none-any.whl (151kB): 151kB downloaded
Downloading/unpacking idna>=2.5,<2.7 (from requests->Mastodon.py)
Downloading idna-2.6-py2.py3-none-any.whl (56kB): 56kB downloaded
Downloading/unpacking chardet>=3.0.2,<3.1.0 (from requests->Mastodon.py)
Downloading chardet-3.0.4-py2.py3-none-any.whl (133kB): 133kB downloaded
Downloading/unpacking urllib3>=1.21.1,<1.23 (from requests->Mastodon.py)
Downloading urllib3-1.22-py2.py3-none-any.whl (132kB): 132kB downloaded
Installing collected packages: Mastodon.py, requests, python-dateutil, six, decorator, pytz, certifi, idna, chardet, urllib3
Successfully installed Mastodon.py requests python-dateutil six decorator pytz certifi idna chardet urllib3
Cleaning up...
What is the username ?followbot
What is the password ?xxxxxxxxxxxx
What is your instance ?https://mastodon.instance
What is your botname ?Followbot
Traceback (most recent call last):
File "Autofollow.py", line 30, in
to_file = '.pytooter_usercred.txt'
File "/home/admin/mastodon-autofollow/.venv/local/lib/python2.7/site-packages/mastodon/Mastodon.py", line 325, in log_in
raise MastodonIllegalArgumentError('Invalid user name, password, or redirect_uris: %s' % e)
mastodon.Mastodon.MastodonIllegalArgumentError: Invalid user name, password, or redirect_uris: Mastodon API returned error: invalid_client

Same issue here, different error:
What is the username ?federationbot What is the password ?xxxxxxxxxxxx What is your instance ?mastodon.xxx What is your botname ?federationbot Traceback (most recent call last):   File "Autofollow.py", line 30, in <module>     to_file = '.pytooter_usercred.txt'   File "/home/federation-bot/mastodon-autofollow/.venv/local/lib/python2.7/site-packages/mastodon/Mastodon.py", line 420, in log_in     raise MastodonIllegalArgumentError('Invalid user name, password, or redirect_uris: %s' % e) mastodon.Mastodon.MastodonIllegalArgumentError: Invalid user name, password, or redirect_uris: ('Mastodon API returned error', 401, 'Unauthorized', u'invalid_grant')
Aside from the error, it would be good to have an idea of what values are actually expected here. Are these the details of our bot? Do we need to prefix https:// in front of the instance name?  I'm assuming there's no @ in the username.
I also see that there's a hardcoded INSTANCE='https://mastodon.scot' in Autofollow.py. Does that need to be changed to the name of our own instance?

You know that thing where you post in a Github issue and then, just after posting, realise the issue might be with something else?
The errors we're getting are from Mastodon.py. In the code's comments it notes:
The username is the e-mail used to log in into mastodon.
I've used my (bot's) registered email address in the format<EMAIL_ADDRESS>its password from the Mastodon instance, the instance name with https:// and launch.sh now runs.  Not sure if it's doing anything, but it's running.
I've changed INSTANCES in Autofollow.py to my instance name (not sure what this does), and by setting DEBUG=TRUE I can see plenty of activity.
Remember that if you've already entered details you'll need to delete the hidden file .pytooter_usercred.txt before running the script again.

An update to this, INSTANCES in Autofollow.py appears to be the instance the script authenticates against, so set it your instance before you run anything.  I'm not sure what the instance the script collects as user input is for.


Update PrivateRoute in AuthExample to handle a passed in render prop

Thanks, but this should be kept simple. It's just an example, so comprehension is more important than completeness.


Update introduction.md

Added pointer to ViaProxy for other server versions

npm install
npm run docs:build
npm run docs:preview

Checklist
Things need to be done before this Pull Request can be merged.

[x] Code is well-formatted and adheres to project style guidelines: cargo fmt
[x] Code does not produce any clippy warnings cargo clippy

Im not sure about "Pumpkin only supports the latest version of Minecraft". Pumpkin does not instantly support the latest Minecraft version when it comes out, We still need some time porting over. Something like "Pumpkin aims to support the latest Minecraft version" would be better

Is there anything else?

Is there anything else?

Sorry that i don't mentioned it directly. But i also think you should better mention that ViaProxy is a tool/plugin which runs on a 3th party Proxy.

Looks good now.
Thanks @DirefulBelt6803


containers: projects are not openshift specific

In #3340 the container_projects relationship has been added to the container manager mixin making the openshift one redundant. This patch removes the superfuous definition.

@miq-bot add_label providers/containers
@miq-bot add_label bug
cc @blomquisg @chessbyte


Consider including your users into feedback loop/roadmap?

I see there's (finally) some activity in this repo and that's great! I'm really happy to see that. :)
I believe theme and app development/developers is very important part of Shopify ecosystem.

That all being said, I think getting theme developers involved in the process could benefit everyone:

You won't build something people don't need/want
You would build something people need/want

Here are couple of my "favorites":

Make it possible/faster to upload multiple files at once. I'm not sure of go's multi-threading capabilities, but uploading/downloading 200 files is a pain in the a$$. But who uploads/downloads 200 files? Glad you asked. :) My client is a bit tech-savy so he sometimes likes to make changes to theme files. I don't want to override his changes so I do theme download before kicking off my work. Just one example.
Update python installation script to use Python 3.x - the installation process should be: <most_mainstream_package_manager_for_platform> install shopify-theme-kit
theme watch is slow to acknowledge it's uploading files, then suddenly "processing + Updated" shows (speaking of UX, "processing" is lowercase, "Updated" is uppercase
Do retries on timeout. Also:

[development] (assets/application.scss.liquid) request timed out. if you are receive this error consistently, try increasing the timeout in your config
There's no explanation how to do this. I don't have any timeout setting in my config.yml and it would be great if I didn't have to go to repo/documentation to figure out how to achieve this

"Invalid JSON" could probably point to the line where the error is. There are online tools that can do this for free. Perhaps something could be embedded in the tool?
Please don't deprecate this tool after 6 months or so.

Make it possible/faster to upload multiple files at once. I'm not sure of go's multi-threading capabilities, but uploading/downloading 200 files is a pain in the a$$. But who uploads/downloads 200 files? Glad you asked. :) My client is a bit tech-savy so he sometimes likes to make changes to theme files. I don't want to override his changes so I do theme download before kicking off my work. Just one example.

Themekit already does every file operation concurrently, to the limit of restrictions in networks and throttles. It is the main reason it was written in Go. The WIP you are currently seeing is us actually changing the foundations of shopify assets APIs so that we can optimize these.

Update python installation script to use Python 3.x - the installation process should be:

This is WIP already from the work we have done on improving the distribution of the shopify CLI

theme watch is slow to acknowledge it's uploading files, then suddenly "processing + Updated" shows (speaking of UX, "processing" is lowercase, "Updated" is uppercase

This is part of the current work in progress along with deliberate debouncing of file operation events.

Do retries on timeout.

We are trying to eliminate timeouts but may do this in the future.

"Invalid JSON" could probably point to the line where the error is. There are online tools that can do this for free. Perhaps something could be embedded in the tool?

This error does not come from themekit it is coming from shopify. We may be able to to find lint your json but as you say there are other tools, especially those that are built into editors to help you with this.

Please don't deprecate this tool after 6 months or so.

I have personally been working on themekit for 4 years and have actively advocating for change, going so far as to get involved with leadership so as to push changes through.

Consider including your users into feedback loop/roadmap?

We constantly interview partners about our tools and I have personally sat on many phone calls with partners voicing their frustrations with the tool. Because you have not been involved does not mean it does not happen.
If there are changes you think might be easy to implement, I suggest opening a PR.

Themekit already does every file operation concurrently, to the limit of restrictions in networks and throttles. It is the main reason it was written in Go. The WIP you are currently seeing is us actually changing the foundations of shopify assets APIs so that we can optimize these.

This is great! But in practice, I'm seeing themekit being vastly slower than other tools I've used and uploading files one by one. What I need to do to achieve this concurrency?

Update python installation script to use Python 3.x - the installation process should be:

This is WIP already from the work we have done on improving the distribution of the shopify CLI

Would be nice if someone would reply to Mr. @larsschellhas' 22 days old issue.

This is part of the current work in progress along with deliberate debouncing of file operation events.

Sounds amazing! Thank you, sir! :)

We are trying to eliminate timeouts

Good luck! :)

"Invalid JSON" could probably point to the line where the error is. There are online tools that can do this for free. Perhaps something could be embedded in the tool?

This error does not come from themekit it is coming from shopify. We may be able to to find lint your json but as you say there are other tools, especially those that are built into editors to help you with this.

I've noticed a lot of issues here talking about UX. Using other tools is killing the UX. User has to copy the entire schema JSON and paste it into some online service. Or have editor plugin that can validate JSON in liquid files. Or copy-paste just the JSON to a new file and use JSON linter.
I don't know of any plugin for liquid offering JSON linting for any of the text editors. Do you know any? I'd love to give it a try.
Even then, with JSON linter enabled in editor, we still don't have things like: "heading" is not a valid key (it should be "header" for example). So this fix has to be done on Shopify's end. Or we're left with recreating Shopify's backend JSON validation locally and then hope the API/validation rules doesn't change (which is just about to happen)

Please don't deprecate this tool after 6 months or so.

I have personally been working on themekit for 4 years and have actively advocating for change, going so far as to get involved with leadership so as to push changes through.

Thank you so much! I really appreciate it! <3 In the past couple of years (about 5+) that I've been working with Shopify platform, I've seen many tools getting deprecated, forums with so many threads old and unanswered and documentation missing. Even now we're in this limbo state of waiting for new sections, while still needing to dig up the "old" (actually "current") documentation for sections, which has been buried somewhere.
All in all, I do see a lot of change in the right direction for well over a year now! Shopify stuff replying on forums, new features being released and tons of documentation added. People see this and appreciate it!

Consider including your users into feedback loop/roadmap?

We constantly interview partners about our tools and I have personally sat on many phone calls with partners voicing their frustrations with the tool. Because you have not been involved does not mean it does not happen.

Oh, I wasn't aware of that! Thanks for doing that. I guess I was wrong with my perception of how you were rolling out new changes.
Glad to see this going in the right direction.
PS Just a tiny plea, if you could have a second look at reviving slate. I think that tool had a great potential of being a much more comprehensive solution for local theme development.
And if I didn't say enough: Thank you for your work!


clear local storage before running capture

I am trying to pre-run some js before running wraith capture as the site I am using stores local storage.
I have an js that just runs:
window.onload = function(){
    window.localStorage.clear();
}

but am getting some errors.
TypeError: '[object Object]' is not a function (evaluating 'require(globalBeforeCaptureJS)(this)')

You should assume the window has already loaded when the before_capture hook is called. Also, the hook needs to be in the form of a module, something along the lines of:
module.exports = function (browserEngine) {
    browserEngine.evaluate(function () {
        window.localStorage.clear();
    });
}


Fix fail parse attribute value

Issue: #62
As you can see from Issue # 62, using eval expands the value like "#{host}".
So instead of using eval we change it to parse attribute value using regular expression and string_undump.
Since String # undump is a method introduced from Ruby 2.5, we will make it work with Ruby 2+ by using the string_undump package.

I'm so sorry... I'll fix it.


@example should perform escaping

/** Perform foo
 * @example foo('hi!');
 */
function foo(bar)
{
    return '' + bar + '';
};

jsdoc test.js gives me:

foo('<a href="#baz">hi!</a>');

jsdoc2md test.js gives me:

#foo()
Perform foo

**Example**
foo('hi!');

That anchor is interpreted by markdown as html, this should probably be escaped or wrapped within a code block.

here are the domv docs generated using the latest jsdoc2md code, how does it look?: https://github.com/75lb/domv/blob/master/api.md

implemented.. take a look at domv/lib/HtmlDocument.. if you click an inherited member in the class member index it takes you to the docs in the parent class (Component).. this reduces duplication in the docs (before, docs for inherited Component members were duplicated inside the docs for HtmlDocument)..
this was caused by
 tags in the domv jsdoc documentation that did not have a closing
..
done
done

awesome that looks much better! I do not see any other issues, thanks
I committed the missing

good, glad you like it.. i will package up a pre-release of jsdoc2md for you to experiment with.. will get back to you later..


ran out of memory

Hey guys,
I'm trying to use fairseq to train a simple summarizer like a translation task. oom happened where even though when I set --max-tokens to 500. 100 or smaller max-tokens set got error:
Traceback (most recent call last):
  File "train.py", line 359, in <module>
    main(args)
  File "train.py", line 78, in main
    trainer.dummy_train_step([dummy_batch])
  File "/home/fairseq/fairseq/trainer.py", line 326, in dummy_train_step
    self.train_step(dummy_batch, dummy_batch=True)
  File "/home/fairseq/fairseq/trainer.py", line 176, in train_step
    self.model, self.criterion, sample,
  File "/home/fairseq/fairseq/tasks/fairseq_task.py", line 157, in get_loss
    return criterion(model, sample)
  File "/home/.local/lib/python3.5/site-packages/torch/nn/modules/module.py", line 477, in __call__
    result = self.forward(*input, **kwargs)
  File "/home/fairseq/fairseq/criterions/cross_entropy.py", line 30, in forward
    net_output = model(**sample['net_input'])
TypeError: 'NoneType' object is not subscriptable

So, any suggestion? My dataset contains about 100,000 sentences and my gpu is single 1080ti 11G memory.

 I've checked the preprocess.py  command line tool but didn't find any parameters to reduce this...

1 million is too large. try --thresholdsrc --thresholdtgt

Another thing to try is to apply BPE encoding to your data, that will naturally reduce dictionary size. There are examples in our repository: https://github.com/pytorch/fairseq/blob/master/examples/translation/prepare-wmt14en2de.sh#L125-L132

@huihuifan thanks dude, I've checked the code and found this arg!

Great. I'm closing this for now. Hope your issue with memory is resolved.


[enzyme-adapter-react-{16,16.3}] [fix] forwardRef: respect .displayName

Fixes #1810.

@jgzuke because the 16 adapter is for 16.0 - 16.5, but the 16.3 adapter is only for 16.3, and those special cases are only in 16.3+.

I don't think it's really worth it; the original issue's repro requires styled-components, but in general, if it shows up in .debug(), it's findable.

Thanks Jordan!

Hello there! Will it be released anytime soon?


Relative path resolution for require does not work

When I use electron-serve in electron-quick-start require('./renderer.js') can't be resolved.
I have to use path.resolve within the require call to make that work:
<script>
  const path = require('path');
  require(path.resolve('./renderer.js'));
</script>

Any way that can be fixed so that relative requires work with electron-serve?

works for me: use <script src="/renderer.js"></script>, then let webpack handle any relative requires

@juliangruber he wasn't talking about using the script tag.
Relative paths don't work when requiring a module which is not being served from a js file which is.
I am currently facing the same problem. It would be great if someone could come up with a solution which doesn't involve resolving the path of the external module as I don't think that would work in production.

@issuehunt has funded $40.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.

Please help. This require thing doesnt work for me too.

Hi y'all,
doesn't this fix your issue?
https://stackoverflow.com/a/55908510/9034699
I tested with electron-quick-start and it works

I may not have the solution, but some information for people who have the problem of the require('./localfile') not working in their script.js which they embedded in their HTML-file by using <script src='./path/to/script.js'>.
The problem is, that require can apparently only be used in files that are required themselves. So to fix that, you can actually use
<script>require('./path/to/script.js');</script>
that might fix the issue.
If typescript is used and require() is still not working, try using import x from './localfile' instead after importing the file in the way shown above.

Thanks for this great project, this has been very helpful!
I've run into a similar issue with path resolution when calling loadURL(). Please let me know if this is the best place to report it. Essentially I have two browser windows serving two different apps, from two different subdirectories , e.g. ~/www/app1 and ~/www/app2 (after setting { directory: '~/www' }). Trying to call loadUrl with app://-/app1 and app://-/app2does not work, neither does app://app1. Both report this error UnhandledPromiseRejectionWarning: Error: ERR_FILE_NOT_FOUND (-6) loading 'app://-/'
Is this supported, or do you know of a workaround?


Add Domain

add onedu domain

@CosineAA Please provide us with:

the school official website URL
the school street address, including city and country
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

@CosineAA You might miss my previous comment. Please react.

Sorry for late reply
https://namju.jje.hs.kr/ is my school website
My school email is onedu.jje.go.kr

@CosineAA  Thank you for the clarifications. Pull request merged.


feat: add bin folder to .devenv

Reduces the $PATH by only adding one packages with a bin folder
Symlinks the bin to .devenv/bin so I can pass this as interpreter path to PhpStorm

fixes #167

@thenonameguy will you create also a bin folder? Ot should I just revert the shell changes :)

@shyim It will create the /bin folder as well as well as adding it to the PATH.
I have made the modifications, just writing tests for testing the native extension building (correct pkg-config/ld env vars).

I will make my own module


Add largestHeight and largestWidth to pdf object

Implementing fit-to-width and fit-to-height in a custom viewer (where all pages are in a scrolling div) is very challenging right now due to mixed-orientation or mixed-size PDFs. You cannot know what width to use for fit-to-width without first getting all of the pages. That means that during the initial render of the PDF document, you have to get every page before rendering the first page. This gives unwanted user-experience. The easiest solution would be a largestHeight and largestWidth property on the pdf object. I don't know if this is actually possible, so I apologize if it is not.
My current solution keeps a running maxWidth and maxHeight and renders as it gets pages. Therefore, if it encounters a new maxWidth and the setting is fit-to-width, the pages above that page are set to the wrong scale. Same with maxHeight/fit-to-height. I don't re-render because content-heavy pages take too long to load.
Sorry but I can't find a public pdf file as an example.

As far as I know the actual PDF data does not contain the maxwidth/maxheight, so if we implemented this in the API it would have to do the exact same thing you would have to do by getting all the pages and finding the maxes. If you don't care about having all the pages scaled the same it's easy to do fit-to-width.


direction support for rn 0.24+

https://github.com/aksonov/react-native-router-flux/pull/490
This breaks < 0.24.  I thought about trying to make it backward compatible, but seems like it would get messy and, at best, not crash.  What are the compatibility expectations?

I guess this module can require RN 0.24 (when it's released) for next releases ? It's better than not supporting latest RN version...

Great work! 0.24 is not released officially yet, so i will merge it once it is out (next Monday?), ok?

Another possibility is to publish 'rc' release for the component which will work with 0.24.rc

Thanks!
But this PR has an issue:
disabling panHandlers with panHandlers={null} stopped working
It will be better to do smth like that:
var state = props.scene.navigationState;  const panHandlers = state.panHandlers !== undefined ? state.panHandlers : (isVertical ?                 NavigationCardStackPanResponder.forVertical(props) :                 NavigationCardStackPanResponder.forHorizontal(props));

Close it because of #536 (that PR includes this one)

RN 24.0 is released but direction still not working

You may try 3.24.0 version which supports RN 0.24. However you could check #557

Thanks a lot @aksonov you are the best!


Update command description / Set file options mandatory

Coverage increased (+1.0%) to 98.033% when pulling dcbe38a71ced82b7545d37f68b112812c1427fae on fix-cli into 9a7784c81c1b23c208fb9540556c70a9cfd355a9 on master.


Add retry functionality to the makeGraphqlRequest

During the last day, all Berkeley testnet graphql endpoints were unstable, that was leading to many o1js errors when fetching the accounts or blocks.
Although there is timeout for makeGraphqlRequest that is set by default to 5 minutes, there were no attempts being made by the makeGraphqlRequest to retry fetching the account or block in case of the error and error is being thrown like
Error making GraphQL request: Bad Gateway

or
value.get() failed, either:
    1. We can't find this zkapp account in the ledger
    2. Because the zkapp account was not found in the cache. Try calling `await fetchAccount(zkappAddress)` first.
    If none of these are the case, then please reach out on Discord at #zkapp-developers and/or open an issue to tell us!

    getAccount: Could not find account for public key B62qnWyoDZP5QoqJ7tiRAuoaUtEzs2xHw8ETsrGFgQjniLFk5XP6qC2
    Graphql endpoint: https://api.minascan.io/node/berkeley/v1/graphql

See also discussion on discord started with https://discord.com/channels/484437221055922177/915745847692636181/1204548331121016853
and my comment
https://discord.com/channels/484437221055922177/915745847692636181/1204698561820758046
Proposal:

Add retry functionality to the makeGraphqlRequest similar to the tx.wait() to retry getting the information from graphql endpoints till the timeout.

Temporary workarounds:
https://github.com/dfstio/he-contract-demo/blob/main/tests/api.test.ts#L234
https://github.com/dfstio/he-contract-demo/blob/main/tests/api.test.ts#L244

Good idea! Shouldn't be hard to implement

See also https://github.com/o1-labs/o1js/issues/1427 and https://github.com/o1-labs/o1js/issues/1426 that can be related to this issue


Question about mvc options

Why do we remove the "XmlDataContractSerializerOutputFormatter()" and set a central route prefix with version?
services.AddMvc(options =>
            {
                options.OutputFormatters.Remove(new XmlDataContractSerializerOutputFormatter());
                options.UseCentralRoutePrefix(new RouteAttribute("api/v{version}"));
            })

I had the question clarified on stack overflow. Inline is the response:
"the version parameter is usually used when you want to enable versioning by using [ApiVersion] attribute on the action methods"
Hence closing the issue.


Stop AsyncHttpDelivery from indefinitely blocking exit

The executor used by AsyncHttpDelivery indefinitely blocks application exit unless a shutdown is manually triggered. This replaces the executor with one which times out when idle and so doesn't block an exit.
cc @bullmo

Looks good @foygl


cigien: Watch kennethhome.com.au

cigien requests the watch of the watch_keyword kennethhome\.com\.au. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

kennethhome\.com\.au has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Spevacus in Charcoal HQ


next  and previous logic is broken

after DOM load if you click prev link it dose not go to last slide it goes to same slide as next (slide 2)

i have sent a pull request to fix this issue


not working

Hi
i already follow the steps on the documentation , but once i refer to the rout /en-us/DataDictionary it is giving not found error
could you please help me in this

Hi @oshabani sorry for the delay. Which framework are you using?


CORE-9385 Refactoring ledger transaction verification

Ledger transaction verification moved to lib "ledger-utxo-transaction-verifier".
Refactored UtxoLedgerTransactionVerifierService that verifies ledger transaction using external events to send requests via message bus to Verification Processor.
Updated VerificationRequestHandlerImpl to perform all transaction verifications (not just contract verification).
Refactored existing code to use UtxoLedgerTransactionVerifierService.

I'm going to merge this PR, if there will be any additional comments and need to change something, I'll address it with a new PR


InfluxDB 2.0.1 OSS; influx secret list

Steps to reproduce:
I have a configuration listed under influx config, and its organization exists / has been verified to exist in-browser.

influx secret list

Expected behavior:
Secrets to be listed.
Actual behavior:
Error: Organization not found.
See 'influx secret list -h' for help

Environment info:

System info: Darwin 18.7.0 x86_64
InfluxDB version: InfluxDB 2.0.1 (git: 37cc047133) build_date: 2020-11-11T03:53:31Z

@tara-influxdata
I'm not able to reproduce this, can you try again with influx secret list --org "thename of your org"

@docmerlin
I tried again and get the same "Error: Organization not found." result.

I can't reproduce this.

○ → influx  config ls
Active	Name		URL			Org
*	tara-config	http://localhost:8086	Taraness
	default		http://localhost:8086<EMAIL_ADDRESS>
 2020-12-07 09:10:42 ⌚  tara-influxdata in ~
○ → influx secret list --org "Taraness"
Error: Organization not found.
See 'influx secret list -h' for help

Still running 2.0.1? or can you repro on 2.0.2?

I can repro on 2.0.2.

I have reproduced this.  It looks like secrets is broken when there is more than 1 org present.  My guess is that the CLI command isn't appropriately scoped by the config parms or doesn't know how to deal with the multiple organizations. This needs review.

You must use an all access token in order to access the secrets.  If you do not have an all access token -- you receive the organization not found error message.

@timhallinflux is the current behavior a bug? It looks we could at least improve the error message

yes, error message needs improvement.  It's not that the org isn't found it's that the user isn't authorized to make that API call, I believe.

This is trickier than I expected. The secrets API is never even being called in this case because:

The secrets API only accepts org IDs, not org names
Given an org name, the CLI first makes a request to the org API to get the matching ID
The org API rejects tokens that don't have org-level read access

IMO the ideal fix would be to extend the secrets API (and others) to accept either org ID or org name, so the server could provide relevant & specific error messages for these cases, but that would be a significant chunk of work & require coordination with cloud. In the short-term, I think we can add more context to the CLI-side error to make the source of the error more clear.


Update 'feds-gnav' to reflect latest changes from 'main'

Dumb question: why create a PR? Why not just merge? Seems noisy and time consuming if you're just updating your branch with the latest.

It's a very valid question, actually! I think that's what we'll do for future branch syncs, this was an experiment for transparency sake, but I agree it's uselessly polluting the codebase.


Discussion: HTML/CSS Code Guidelines

Not sure where to put this, but I'd like to have a conversation around HTML/CSS coding guidelines before the product is opened up to the public. I'll leave the javascript up to others :-)
I'd like to follow the guidelines as described here: http://codeguide.co.

Every line of code should appear to be written by a single person, no matter the number of contributors.

@joshuawilson @michaelkleinhenz @pmuir @SMahil @catrobson

IMO, not only can we update what we have to ensure that we follow the idea of having the code appear as if it was written by a single person, but establish guidelines/rules for all contributors.

: +1

I've refreshed the CSS for OpenShift/OpenShift.io with these guidelines (https://github.com/openshiftio/openshift.io). I'd like to start on fabric8-ui first, and then move to fabric8-planner.

PRs submitted to the following repos:

runtime-console: https://github.com/fabric8-ui/fabric8-runtime-console/pull/473
ngx-widgets: https://github.com/fabric8-ui/ngx-widgets/pull/79
fabric8-ui: https://github.com/fabric8io/fabric8-ui/pull/1308

@SMahil would you be up for handling the Planner refactor of this? You have the most knowledge of that system and can work hand-in-hand with the dev team.

sure @mindreeper2420

Planner Work:

Issue
Pull Request


End2End STF functional tests.  Querying STF server for collectd and ceilometer metriucs and events

A new pull request was created


Preferences window missing title; toolbar clips against macOS window controls

Describe the bug
When "General" tab is selected, the selection background intersects too close to the macOS window controls.
To Reproduce

Open Preferences for the app
Select "General" tab
Observe the selection background clipping the "maximize" window button.

Expected behavior

macOS window controls have a fixed margin around them.

Screenshots

Environment

OS: macOS Sonoma 14.1
Version: 0.1.0

This has been fixed with #481


SEO Tab Prev/Next Attribute

http://searchengineland.com/implementing-pagination-attributes-correctly-for-google-114970
Prev/Next used for splitted blog posts e.g. Title Part1, Title Part2, ... or also used for overview sites with pagination.

@danrot you are right I think this could be handled correctly in the twig template.


testRegression test for external hive parquet table.

Proposed changes
Issue Number: close #xxx
Problem summary
Regression test for external hive parquet table. Using docker to provide hive environment.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.77 seconds
load time: 441 seconds
storage size:<PHONE_NUMBER>7 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221114043412_clickbench_pr_45373.html


jupyter notebook + singularity witout sudo

hey @devprincess, I'd be interested in packaging jupyter notebook + IRkernel and same other R packages I need for an analysis in a singularity container. I gave the example https://github.com/sylabs/examples/tree/master/machinelearning/jupyter-notebook a shot but it seems to require sudo to run the jupyter server.
I'd really just like to
singularity run jupyter.sif

and get a notebook server opened in the current working directory on localhost. Using this setup, however,
Bootstrap: docker
From: rocker/verse
%post
    apt-get update
    apt-get -y install curl wget python3-pip

    # install snakemake
    pip3 install snakemake

    # install jupyter notebook
    python3 -m pip install jupyter
    python3 -m pip install nbconvert

    # install R kernel
    R -e "install.packages('IRkernel'); IRkernel::installspec()"

%runscript
    jupyter notebook --allow-root "$@"

I run this using
singularity exec --bind $PWD:/run/user image.sif jupyter notebook --ip=<IP_ADDRESS> --no-browser

I can only run python kernels, switching to the R kerneln results in an error
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/tornado/web.py", line 1592, in _execute
    result = yield result
  File "/usr/local/lib/python2.7/site-packages/tornado/gen.py", line 1133, in run
    value = future.result()
  File "/usr/local/lib/python2.7/site-packages/tornado/concurrent.py", line 261, in result
    raise_exc_info(self._exc_info)
  File "/usr/local/lib/python2.7/site-packages/tornado/gen.py", line 1141, in run
    yielded = self.gen.throw(*exc_info)
  File "/usr/local/lib/python2.7/site-packages/notebook/services/sessions/handlers.py", line 73, in post
    type=mtype))
  File "/usr/local/lib/python2.7/site-packages/tornado/gen.py", line 1133, in run
    value = future.result()
  File "/usr/local/lib/python2.7/site-packages/tornado/concurrent.py", line 261, in result
    raise_exc_info(self._exc_info)
  File "/usr/local/lib/python2.7/site-packages/tornado/gen.py", line 1141, in run
    yielded = self.gen.throw(*exc_info)
  File "/usr/local/lib/python2.7/site-packages/notebook/services/sessions/sessionmanager.py", line 79, in create_session
    kernel_id = yield self.start_kernel_for_session(session_id, path, name, type, kernel_name)
  File "/usr/local/lib/python2.7/site-packages/tornado/gen.py", line 1133, in run
    value = future.result()
  File "/usr/local/lib/python2.7/site-packages/tornado/concurrent.py", line 261, in result
    raise_exc_info(self._exc_info)
  File "/usr/local/lib/python2.7/site-packages/tornado/gen.py", line 1141, in run
    yielded = self.gen.throw(*exc_info)
  File "/usr/local/lib/python2.7/site-packages/notebook/services/sessions/sessionmanager.py", line 92, in start_kernel_for_session
    self.kernel_manager.start_kernel(path=kernel_path, kernel_name=kernel_name)
  File "/usr/local/lib/python2.7/site-packages/tornado/gen.py", line 1133, in run
    value = future.result()
  File "/usr/local/lib/python2.7/site-packages/tornado/concurrent.py", line 261, in result
    raise_exc_info(self._exc_info)
  File "/usr/local/lib/python2.7/site-packages/tornado/gen.py", line 326, in wrapper
    yielded = next(result)
  File "/usr/local/lib/python2.7/site-packages/notebook/services/kernels/kernelmanager.py", line 160, in start_kernel
    super(MappingKernelManager, self).start_kernel(**kwargs)
  File "/usr/local/lib/python2.7/site-packages/jupyter_client/multikernelmanager.py", line 110, in start_kernel
    km.start_kernel(**kwargs)
  File "/usr/local/lib/python2.7/site-packages/jupyter_client/manager.py", line 259, in start_kernel
    **kw)
  File "/usr/local/lib/python2.7/site-packages/jupyter_client/manager.py", line 204, in _launch_kernel
    return launch_kernel(kernel_cmd, **kw)
  File "/usr/local/lib/python2.7/site-packages/jupyter_client/launcher.py", line 128, in launch_kernel
    proc = Popen(cmd, **kwargs)
  File "/usr/local/lib/python2.7/subprocess.py", line 394, in __init__
    errread, errwrite)
  File "/usr/local/lib/python2.7/subprocess.py", line 1047, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

Any ideas of how to fix this?

@kkmann do you have ipykernel installed ? https://ipython.readthedocs.io/en/stable/install/kernel_install.html

@devprincess thx for coming back to this! I played around for a bit (as I said ipykernel already worked like a charm). Turns out that the solution is rather boring ;)
Since we build the image in sudo mode, IRkernel::installapec() installs the R kernel in the root directory, simply changing this to R -e "install.packages('IRkernel'); IRkernel::installspec('/usr/local')" works fine for me, maybe you want to mention that in your tutorial since it might not be obvious to other R users as well?

Sounds good, thanks for the update, would you mind closing the issue in any case? thanks! :+1:

sure my bad x)

@devprincess sorry for opening this up again, but the current approach is not portable since the kernels are installed in the respective locations in the host filesystem.
Any idea of how to install the kernels in the container filesystem?


New package: TimKosse.FileZilla version 3.67.0

Checklist for Pull Requests

[ ] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Hi @Jvr2022,
In the past, this package was blocked by requiring a license. Is this still the case?

Manual Validation ended with:

2024-04-17 20:03:24.793 [CORE] WinINet downloading from url: https://dl1.cdn.filezilla-project.org/client/FileZilla_3.67.0_win64-setup.exe?h=r8SjxgDSopBVF2EzNIx8Jw&x=1713377005
2024-04-17 20:03:25.555 [CORE] Download request failed. Returned status: 403
2024-04-17 20:03:25.555 [FAIL] C:__w\1\s\external\pkg\src\AppInstallerCommonCore\Downloader.cpp(148)\WindowsPackageManager.dll!00007FFB5F598767: (caller: 00007FFB5F599FC9) Exception(4) tid(1e7c) 80190193 Forbidden (403).      Msg:[Download request status is not success.]
2024-04-17 20:03:25.647 [CLI ] Caught wil::ResultException: C:__w\1\s\external\pkg\src\AppInstallerCommonCore\Downloader.cpp(148)\WindowsPackageManager.dll!00007FFB5F598767: (caller: 00007FFB5F599FC9) Exception(4) tid(1e7c) 80190193 Forbidden (403).      Msg:[Download request status is not success.]

(Automated response - build 876.)

Hi there,
I am gonna look to this problem and fix it

Close with reason: Please see https://github.com/microsoft/winget-pkgs/issues/78578;

Close with reason: Please see issue 78578;


⚠ Bofrost.at has degraded performance

In 541ca28, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1716 ms

Resolved: Bofrost.at performance has improved in 1b406e1 after 6 minutes.


Correction for raw affiliation Department of Computer Science Lakehead University; Department of Computer Science Lakehead University Jinan Fiaidhi

Correction needed for raw affiliation Department of Computer Science Lakehead University; Department of Computer Science Lakehead University Jinan Fiaidhi
raw_affiliation_name: Department of Computer Science Lakehead University; Department of Computer Science Lakehead University Jinan Fiaidhi
new_rors: 023p7mg82
previous_rors:
works_examples: W3016258355;W4238695541
contact: ba80efea6a06ac0078711945f91ba838:602bca70 @ ourresearch.org

This issue was accepted and ingested by the OpenAlex team on 2024-10-09. The new affiliations should be visible within the next 7 days.


[Refactor]: Turn socket io channel names to Enum (follow-up)

Refactor Request
Follow-up for #222
Socket io channel names should also be Enums in the backend.
Describe the proposed solution
No response

Closed with #337


Adding categories

See https://github.com/rust-lang-nursery/bitflags/issues/77
As @Cldfire said:

This crate is actually a good fit for the No Standard Library category :)

Not sure anyway, I'm just trying to learn how I can help on Rust. Feel free to close this PR!

Looks great, thanks!


not able to use cipher in bootstrap.yml

It seems that it is not possible to use {cipher} in the bootstrap.yml.
I created a simple example project showing the issue: https://github.com/imod/spring_boot_demo
The bootstrap.yml looks like this
encrypt:
  key: ${ENCRYPT_KEY:dummy}

my:
  password: '{cipher}c6e87846e7155dc7d86d5b850d8c8551c5fe41b625acdee4c85e7ef3a68a719f'

it also does not matter if I set ENCRYPT_KEY=dummy as an environment variable.
...at startup the DemoApplication.afterPropertiesSet() is expected to print the decrypted value.

You are using an old version of Spring Cloud. Try with Angel.SR3 or Brixton.*.

many thanks! I was not yet aware of the release train model


[Request] Generic/universal overlay

Select one ... (check one with "x")
[ ] bug
[X] feature request
[ ] enhancement

Expected behavior
While clarity provides specialised overlay panels such tooltip and signpost it lacks simple, generic one. Tooltip works as intended and signpost is good option if you need to provide some information/documentation that is read-only but if there is need to provide some interaction in overlay panel there is no valid alternative. Signpost comes with quite restrictive styling that needs to be overridden which is cumbersome and prone to future break.
Looking at source PopoverDirectiveOld is used to create hide/show overlay for datagrid (with is good example of what is my use case) and there is AbstractPopover. Either could be released as public API but maybe it would be better If they remain as internal and new component similar to signpost but more extendable/less specific be created. This would give possibility to revise internal popup workings and not introduce breaking change.
As for workarounds:

Create overlay panel from scratch
Use dedicated library (Maybe Angular CDK)

Nevertheless I think It would be optimal if Clarity provided such component/directive with minimal styling that would be compatible with rest of UI components.
Related: https://github.com/vmware/clarity/issues/1673
Actual behavior
Lack of generic/universal overlay
Reproduction of behavior
N/A
Environment details

Angular version: ^6.0.0

Clarity version: ^0.12.0

OS and version: N/A

Browser: all

Actually, we made the choice not to have a public generic overlay because many its uses would go against our design recommendations. Clarity is an opinionated design system, and as such we want to control which specific uses of overlays we want to facilitate.
If you want overlay and insert a form in there, we recommend you use a modal dialog. If you simply have a list of actions to perform, then a dropdown is your best choice.
The documentation for signposts doesn't speak for all popovers, but being the most generic popover we provide it provides insight in what kind of behavior we want to support:

Recommendations

...
With the exception of text/image links, don't insert any actionable components, such as buttons, in the dialog
Don't rely on signposts as a primary method of displaying additional information - i.e. as a way to save space on a page
Use sparingly as a device to add immediate, relevant information

If you shared with us the use case you feel needs a signpost or some other form of overlay with actionable elements inside, maybe we could either point you towards the pattern we recommend using, or maybe identify a new type of overlay we want to support.

What I want to accomplish is popover containing page/partial page settings. These settings consists of few checkboxes (show/hide for elements on page) with pair of buttons associated with this page settings. Checkboxes are grouped and in columns. As for requirements, this controls cannot be always visible, must not require page change to access and controls should cause intimidate action (this should not be form with submit button).
Also I'll have few similar popup menus that will consist of few toggles, sometimes single input field and button. Example here is download button that lets user to chose some options before sending content.
I think that modal dialog is very much overkill and it should contain form with submit, not controls that change state on the fly. As pointed signpost should not contain such controls. I did not consider dropdown but it looks like it is not good fit either - It's rather restrictive to button actions only.
This use cases are very specific and require full control over popover contents and providing specialised popovers for all possible cases does not seem feasible so I guess this is just out of clarity scope?

Ok, I understand the use case better now. It's always helpful to have an example, and I believe what you want is something similar to the "Share" popover on StackBlitz:

For the StackBlitz example, moving to a new page for this menu would be severely overkill, but the content of the popover is large enough that you can't have these options displayed at all times.
Please correct me if you think this is not a good example of your use case.
I'll let our UX designers take a look at this to see how we want to address this.

My initial thought was that this would be a "mega menu". But I'm wrong on that. If this were to be offered, what use cases specifically would we be addressing? And why would a user use a form inside of a dropdown instead of a modal or a panel that slid out from the right or something like that?
I understand the use case somewhat. But I think we need to be clearer on when this pattern is appropriate for use – especially compared to existing patterns and patterns we have committed to in the future – to avoid a situation where we have 3-4 different patterns/components and developers have no clear guidance on which one is the best one for their use case.

I looked at possible use cases and I think it could be broken down into two distinct ones:

Providing real-time-effect controls
Providing micro-forms

As for real-time-effect, it's use case that is already present in clarity. For example there are overlay controls for datagrid such as filtering

and show/hide (This has button but it's going away according to https://github.com/vmware/clarity/issues/2100 )

I can add mock example of class of usecases that will be valid for me (I know I abuse signpost here, but it's just to showcase)

And the other one, micro-forms, are things that could go into modal but I feel that if they are small enough and/or are strongly attached to certain part of UI it isn't good idea to rip it from there and put in modal. Similar for sliding panel - they would feel disconnected in my opinion. Apart from show/hide mentioned above that will be changed, clarity does not have such cases. New gmail could be example here. This would work as modal as it's quite big form but it feels in right place as it overlays next to search box - it's connected to that part of UI.

Another mock example - download button that will be closer to my usage

Here I feel that opening modal would be overkill - this should be quick to access, panel shouldn't cover all of data that will be downloaded so user could still look at it and decide on provided options. If done on modal, user would have to close it, verify and open again. This could be done as sliding panel without this problem but I feel that it would break flow. In worst case user has to go all the way from left to right side of screen (or other way) to continue interaction.

This is a long standing request, and I suggest that for Angular folks look at the https://material.angular.io/cdk/overlay/overview for a generic overlay mechanism. It can be styled and match Clarity, but we are not going to commit to making our Clarity Angular overlay public and supported since it wasn't built to be generic enough for these use cases. I'm going to close this as something we won't do with Clarity Angular.

This is a long standing request, and I suggest that for Angular folks look at the https://material.angular.io/cdk/overlay/overview for a generic overlay mechanism. It can be styled and match Clarity, but we are not going to commit to making our Clarity Angular overlay public and supported since it wasn't built to be generic enough for these use cases. I'm going to close this as something we won't do with Clarity Angular.


Unable to run on Ios devices

Hi,
First of all, thanks for creating this package which address most of the issues from three_dart. I am facing an issue when trying to run this on my Iphone(Physical Device - 14 Pro Max). Just importing three_js throws the error seen below.

Launching lib/main.dart on Apple 14ProMax in debug mode...
../../.pub-cache/hosted/pub.dev/three_js_core_loaders-0.0.3/lib/ImageLoader/image_loader_app.dart:87:40: Error: Member not found: 'uint8'.
image = image?.convert(format:Format.uint8,numChannels: 4);
^^^^^
../../.pub-cache/hosted/pub.dev/three_js_core_loaders-0.0.3/lib/ImageLoader/image_loader_app.dart:87:18: Error: The method 'convert' isn't defined for the class 'Image'.
'Image' is from 'package:image/src/image.dart' ('../../.pub-cache/hosted/pub.dev/image-3.3.0/lib/src/image.dart').
Try correcting the name to the name of an existing method, or defining a method named 'convert'.
image = image?.convert(format:Format.uint8,numChannels: 4);
^^^^^^^

But it works fine on web.

I have just one dependency

Hi @nirmal-kc,
Looks like the image library is way out of date for you. Could you delete your pubspec.lock file run flutter clean, flutter pub upgrade. Then make sure image is pub file is > 4.0.0.
If those two things do not work. Try deleting your podfile.lock file and upgrading pods arch -86_64 pod install --repo-update.
Hope this helps.

@Knightro63,
Thanks a ton. Yes, I was on a very old version of image, because of which I saw the above issue.

Hi @nirmal-kc,
Looks like dart had an issue bringing the value in as a double. I will update it when I get a chance. Sorry for the inconvenience.
Hope everything else is working well for you though.

@Knightro63,
And, I also updated the aspect ratio to 1.0 from 1. Everything else seems to work. I will be testing gltf loader this week, and will update you if I do see any issues.

Hi @nirmal-kc,
I have updated three_js_advanced_loaders to version 0.0.5 to fix the issues.
please run flutter pub upgrade for this to take effect.
Thank you for letting me know of the issue.

Hi @nirmal-kc ,
I think we should be able to close this issue.

@Knightro63 Thanks, we can go ahead and close the issue


ZEVA - Create Supplementary Report button placement

Title: Create Supplementary Report button placement
Description: Please relocate the Create Supplementary Report and Print Page buttons to the top of page as shown in the mockup
Wireframe:
https://preview.uxpin.com/ba292bb89debd007a79659b3f657c3649ade8efa#/pages/159665032?mode=fm
Purpose and benefit to user: This is a more logical and accessible location for these buttons rather than nested within individual reports within the history.
Acceptance Criteria:

[ ] Given I am a bceid user, When I am on an assessed MY report page, then the Create Supplementary Report and Print Page buttons are located at the top of page
[ ] Given I am a idir user, When I am on an assessed MY report page, then the Create Reassessment and Print Page buttons are located at the top of page

Development Checklist:

[ ] A
[ ] B
[ ] C

Notes:

Hey team! Please add your planning poker estimate with Zenhub @AlexZorkin @jig-patel @prv-proton @tim738745

The button placement needs to be outside or separated from the history component, it should a stand alone area at the top of page. Also the Print button is duplicated at times between the old location and new location.

perfect, looks good


update gulp & polyfill

Updating the gulp process we are able to cut down on dependencies for UMD support as well remove babel's browser polyfill and require only the polyfills we need.

The previous size was cut in half as well:
Previous with polyfill:

Current with polyfill:


Can not run tests from Intellij

Describe the bug
Attempting to run tests in Intellij fails with the following error;
/working/projects/redHat/Hyperfoil/Horreum/horreum-client/src/main/java/io/hyperfoil/tools/RunServiceExtension.java:85:193
java: package org.jboss.resteasy.reactive.multipart does not exist

cause by: https://github.com/Hyperfoil/Horreum/blob/master/horreum-client/src/main/java/io/hyperfoil/tools/RunServiceExtension.java#L23
I had a workaround for this issue previously, but we need to resolve so a fresh import into intelij works correctly

This works in master


Error with SSO - Unable to Verify Signature

I'm currently seeing an issue when working with one of our customer's IdPs. Here's what I've observed so far:

The signature block doesn't seem to be namespaced with "ds:", although it does have the proper xmlns attribute:

<?xml version="1.0" encoding="UTF-8"?>
<SignedInfo xmlns="http://www.w3.org/2000/09/xmldsig#">
   <CanonicalizationMethod Algorithm="http://www.w3.org/2001/10/xml-exc-c14n#" />
   <SignatureMethod Algorithm="http://www.w3.org/2001/04/xmldsig-more#rsa-sha256" />
   <Reference URI="">
      <Transforms>
         <Transform Algorithm="http://www.w3.org/2000/09/xmldsig#enveloped-signature" />
         <Transform Algorithm="http://www.w3.org/2001/10/xml-exc-c14n#" />
      </Transforms>
      <DigestMethod Algorithm="http://www.w3.org/2001/04/xmlenc#sha256" />
      <DigestValue></DigestValue>
   </Reference>
</SignedInfo>

In xmlseclibs.php decryptNode(), the following code seems to import the newly decrypted signature block into the original document but places "default:" as the namespace for all elements.

$importEnc = $this->rawNode->ownerDocument->importNode($newdoc->documentElement, TRUE);
$this->rawNode->parentNode->replaceChild($importEnc, $this->rawNode)

<?xml version="1.0" encoding="UTF-8"?>
<default:SignedInfo xmlns:default="http://www.w3.org/2000/09/xmldsig#">
   <default:CanonicalizationMethod Algorithm="http://www.w3.org/2001/10/xml-exc-c14n#" />
   <default:SignatureMethod Algorithm="http://www.w3.org/2001/04/xmldsig-more#rsa-sha256" />
   <default:Reference URI="">
      <default:Transforms>
         <default:Transform Algorithm="http://www.w3.org/2000/09/xmldsig#enveloped-signature" />
         <default:Transform Algorithm="http://www.w3.org/2001/10/xml-exc-c14n#" />
      </default:Transforms>
      <default:DigestMethod Algorithm="http://www.w3.org/2001/04/xmlenc#sha256" />
      <default:DigestValue></default:DigestValue>
   </default:Reference>
</default:SignedInfo>

This causes a problem when the signature block is run through xmlseclibs.php verifyOpenSSL() since the new namespace doesn't match with the original signed data

Any ideas on what needs to be changed in order to prevent the default namespace from being added? I'd rather not have to code in a text parser to remove the namespace from the generated text.

This is an xmlseclib issue rather than php-saml issue. Please move the ticket to:
https://github.com/xmlseclibs/xmlseclibs/issues

This appears to be related to robrichards/xmlseclibs#27 and onelogin/php-saml#29. I'll go ahead and reply to the issue in xmlseclibs with an example.


onTap event

I was in need for onTap event, so par novakben instructions in the comment https://github.com/lhandel/react-native-card-stack-swiper/issues/17#issuecomment-385694045, I have added the props onTap in this your package.
I have faced the same problem as lorencs in the comment https://github.com/lhandel/react-native-card-stack-swiper/issues/17#issuecomment-385700701, which I have addressed as written.

My reposotory was 8 commits behing master... will create new


Added .NetCore 3.0 to IntegrationAspNetCore and updated derived proje…

Added .NetCore 3.0 to IntegrationAspNetCore and updated derived projects.
Fixes #3213

<DocumentationFile>bin\$(Configuration)\netstandard2.0\Microsoft.Bot.Builder.Integration.AspNet.Core.xml</DocumentationFile>

?? this doesn't feel right.

Refers to: libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/Microsoft.Bot.Builder.Integration.AspNet.Core.csproj:18 in 34bb751. [](commit_id = 34bb7510a35759349efaff9a8c7ef7382cf24aa5, deletion_comment = False)

I will address Tom's comments in a new PR where we will also include some fixes for gov cloud and skills. Closing this PR for now.


node['ddnsupdate']['resolv_conf']['nameservers'].first  not being set when node['ddnsupdate']['use_resolv_conf'] is true

line 26: node.default['ddnsupdate']['server'] = node['ddnsupdate']['resolv_conf']['nameservers'].first if node['ddnsupdate']['use_resolv_conf']
kitchen run:
   Recipe Compile Error in /tmp/kitchen/cache/cookbooks/ddnsupdate/recipes/host.rb
   ================================================================================

   NoMethodError
   -------------
   undefined method `first' for nil:NilClass

   Cookbook Trace:
   ---------------
     /tmp/kitchen/cache/cookbooks/ddnsupdate/recipes/default.rb:26:in `from_file'
     /tmp/kitchen/cache/cookbooks/ddnsupdate/recipes/host.rb:20:in `from_file'

   Relevant File Content:
   ----------------------
   /tmp/kitchen/cache/cookbooks/ddnsupdate/recipes/default.rb:

    19:
    20:  temp_resolv_conf  = DDNSUpdate.resolv_conf
    21:
    22:  node.default['ddnsupdate']['resolv_conf']['nameservers'] = temp_resolv_conf['nameservers']
    23:  node.default['ddnsupdate']['resolv_conf']['search'] = temp_resolv_conf['search']
    24:  node.default['ddnsupdate']['resolv_conf']['domain'] = temp_resolv_conf['search']
    25:
    26>> node.default['ddnsupdate']['server'] = node['ddnsupdate']['resolv_conf']['nameservers'].first if node['ddnsupdate']['use_resolv_conf']
    27:
    28:  fail "node['ddnsupdate']['server'] must be configured or enable node['ddnsupdate']['use_resolv_conf']" unless node['ddnsupdate']['server']
    29:

@bcorner13 Are you overriding the value for node['ddnsupdate']['resolv_conf']['nameservers'] in a wrapper cookbook or role? it is defined as an array in the cookbook, i will try to reproduce it.
Perhaps for kitchen test it is better to set `node['ddnsupdate']['resolv_conf']['nameservers'] = ['<IP_ADDRESS>']'.

These are the attributes I am setting in my kitchen.yml file:
      ddnsupdate:
        use_resolv_conf: true
        ttl: 300
        no_dnsec: true

and in the run_list section I am calling
      - recipe[ddnsupdate::host]

Its as if the library code:
  def self.resolv_conf(rc_file = '/etc/resolv.conf')
    rc = {
      :nameservers  => [],
      :domain       => nil,
      :search       => []
    }

    if File.exist?(rc_file)
      File.open(rc_file, 'r').each_line do |line|
        next if line =~ /^#|^;/
        case line
        when /domain/
          rc[:domain] = line.strip.split[1]
        when /search/
          rc[:search].push line.strip.split[1]
        when /nameserver/
          begin
            IPAddr.new(line.strip.split[1]).ipv4?
            rc[:nameservers].push line.strip.split[1]
          end
        end
      end
    end

is not actually reading the /etc/resolv.conf

Added some debug to ddnsupdate.rb.
  def self.resolv_conf(rc_file = '/etc/resolv.conf')
    rc = {
      :nameservers  => [],
      :domain       => nil,
      :search       => []
    }
    Chef::Log.debug('About to read /etc/resolv.conf')
    if File.exist?(rc_file)
      File.open(rc_file, 'r').each_line do |line|
        Chef::Log.debug('reading file resolv.conf: ' + line)
        next if line =~ /^#|^;/
        case line
        when /domain/
          rc[:domain] = line.strip.split[1]
        when /search/
          rc[:search].push line.strip.split[1]
        when /nameserver/
          begin
            IPAddr.new(line.strip.split[1]).ipv4?
            rc[:nameservers].push line.strip.split[1]
          end
        end
      end
    else
    Chef::Log.debug('file /etc/resolv.conf doesnt exist')
    end
    rc
  end

and here is the output:
[2015-10-29T18:51:57+00:00] DEBUG: Found recipe default in cookbook ddnsupdate
       [2015-10-29T18:51:57+00:00] DEBUG: About to read /etc/resolv.conf
       [2015-10-29T18:51:57+00:00] DEBUG: reading file resolv.conf: ; generated by /usr/sbin/dhclient-script

       [2015-10-29T18:51:57+00:00] DEBUG: reading file resolv.conf: search <domain>

       [2015-10-29T18:51:57+00:00] DEBUG: reading file resolv.conf: domain <domain>

       [2015-10-29T18:51:57+00:00] DEBUG: reading file resolv.conf: nameserver XX.XX.XX.XX

       [2015-10-29T18:51:57+00:00] DEBUG: reading file resolv.conf: nameserver XX.XX.XX.XX

       [2015-10-29T18:51:57+00:00] DEBUG: filtered backtrace of compile error: /tmp/kitchen/cache/cookbooks/ddnsupdate/recipes/default.rb:26:in `from_file',/tmp/kitchen/cache/cookbooks/ddnsupdate/recipes/host.rb:20:in `from_file'
       [2015-10-29T18:51:57+00:00] DEBUG: backtrace entry for compile error: '/tmp/kitchen/cache/cookbooks/ddnsupdate/recipes/default.rb:26:in `from_file''
       [2015-10-29T18:51:57+00:00] DEBUG: Line number of compile error: '26'

       ================================================================================
       Recipe Compile Error in /tmp/kitchen/cache/cookbooks/ddnsupdate/recipes/host.rb
       ================================================================================

Fixed this issue.  Problem boiled down to referencing the named hash. I am going to do another regression test to confirm, but my preliminary test is the feature works.
temp_resolv_conf  = DDNSUpdate.resolv_conf

node.default['ddnsupdate']['resolv_conf']['nameservers'] = temp_resolv_conf[:nameservers].first
node.default['ddnsupdate']['resolv_conf']['search'] = temp_resolv_conf[:search].first
node.default['ddnsupdate']['resolv_conf']['domain'] = temp_resolv_conf[:domain]

Found some additional issues now with
       ================================================================================
       Recipe Compile Error in /tmp/kitchen/cache/cookbooks/ddnsupdate/recipes/host.rb
       ================================================================================

       TypeError
       ---------
       no implicit conversion of nil into String

       Cookbook Trace:
       ---------------
         /tmp/kitchen/cache/cookbooks/ddnsupdate/recipes/host.rb:47:in `+'
         /tmp/kitchen/cache/cookbooks/ddnsupdate/recipes/host.rb:47:in `from_file'

       Relevant File Content:
       ----------------------
       /tmp/kitchen/cache/cookbooks/ddnsupdate/recipes/host.rb:

        40:    group 'root'
        41:    source 'host_nsupdate_nodsec.erb'
        42:    notifies :run, 'execute[host_nsupdate]'
        43:    only_if { node['ddnsupdate']['no_ddnssec'] }
        44:  end
        45:
        46:  node_domain = node['ddnsupdate']['host']['auto_fqdn_zone'] && node['domain'] ? node['domain'] : node['ddnsupdate']['host']['zone']
        47>> node_fqdn = node['ddnsupdate']['host']['auto_fqdn_zone'] && node['fqdn'] ? node['fqdn'] : (node['hostname'] + '.' + node['ddnsupdate']['host']['zone'])
        48:
        49:  Chef::Log.warn('unable to determine node fqdn') unless node_fqdn
        50:  Chef::Log.warn('unable to determine node domain / zone') unless node_domain
        51:
        52:  # host nsupdate config file
        53:  template node['ddnsupdate']['host']['config'] do
        54:    mode 0655
        55:    owner 'root'
        56:    group 'root'

I'll take a look at this tomorrow.
Next bit of improvement I am going to do is automate node['ddnsupdate']['host']['reverse_zone']. My reasoning is that depending on which VLC/subnet I am publishing two they could be different zones. This is something I don't think needs to be hardcoded as an attribute.

@bcorner13 Thank you for sharing your analysis. I think you need to set zone attribute default['ddnsupdate']['host']['zone'] for dns registration. Currently if attribute node['ddnsupdate']['host']['auto_fqdn_zone'] is set then node['domain'] will used as a domain, but that will only work if node has been registered with dns or ip fqdn entry is present in /etc/hosts.
I think cookbook can be updated to use domain from /etc/resolv.conf. I will also take a closer look today.
I also thought about assigning a default value to default['ddnsupdate']['host']['reverse_zone'], but you never know which subnet user has configured on the client and dns server. Like, in AWS a VPC subnet of <IP_ADDRESS>/16 can have different subnets of <IP_ADDRESS>/24 and dns server can have a <IP_ADDRESS>/8 or something different.
But, i admit i did not try it further to make a technical guess. I have re opened this issue.

My thought was that the DHCP on AWS provides the zone information. So pull the information from there instead of hard coding it.


UIFont internal caching not working correctly

The global font cache is never finding the UIFont in the list since the isEqual method of UIFont compares the fontDescriptor and returns false if a descriptor is nil.  In the current usage of the font cache the UIFont used as a key always contains a nil fontDescriptor.

This will be covered as part of #987


Cant get concurrency

Hey there
I'm trying to learn how coroutines and actors work within pulsar. I'm writing a simple site scraper that pulls from a queue. I've been going over all the examples, and am very confused as to how any of the examples are concurrent with a single actor defined in them.
This example has a single actor.
https://github.com/quantmind/pulsar/blob/master/examples/snippets/actor1.py
What confuses me here is that there is a single actor that looks like it runs two functions but I don't understand how this can run both at the same time on a single actor.
This example also looks like a single actor.
https://github.com/quantmind/pulsar/blob/master/examples/snippets/greeter.py
In my code below, im trying to spawn up 10 actors which should be different threads/processes. I'm hoping to distribute messages across actors and run them concurrently. When I tun this code, I see the entire thing slow down to just one req every 3s as per the sleep in scrape(). I'm confused as to why this isn't returning a future that I can check the status of later.
def start(arbiter, **kw):
    ensure_future(app(arbiter))

async def app(arbiter):
    # Spawn new actors
    try:
        actors = []
        for i in range(0,9):
            actors.append(await spawn(name='worker'+str(i)))
    except Exception as e:
        logger.exception(e)

    print(actors)

    try:
        while True:
            try:
                worker = actors[random.choice(range(0,9))]
            except Exception as e:
                logger.exception(e)
            # Run scrape job
            result = await send(worker, 'run', scrape, {'sku': 'SKU1'})

    except KeyboardInterrupt as e:
        # Stop the event loop
        arbiter.stop()
        logger.exception(e)

async def scrape(actor, message):
    sku = message['sku']
    actor.logger.info("Scraping SKU: " + sku)
    time.sleep(3)

    # Do the scrape

Any help would be appreciated.
Rob

The actor model in pulsar refers to the parallel side of the asynchronous framework.
In pulsar each actor (think of a specialised thread or process) has its own event loop. In this way any actor can run its own asynchronous server for example.
An actor has its own event loop and therefore it can run several tasks concurrently. Indeed this is how asyncio works, not just pulsar. If these tasks (coroutines) are IO friendly, a pulsar app can be very fast.
Throwing lots of actors to your problem is not the correct solution. By default an actor is a process and there are so many processes you can use (usually 4 x number of cores).
Adding more actors is your last solution, when you need to scale horizontally on a given machine.
First try to get your async app running on one actor
Depending on what the scrape function does, you can organise your application in different ways:

scrape is IO bound (ex: download an html web page). Run one actor only and keep a queue of asynchronous scrapers
scrape is CPU bound (ex: parsing a page already downloaded and do some NLP on it). This does not work well in an actor because it does not release the event loop (not IO friendly). You can use pulsar-queue for such configuration.

In addition:
async def scrape(actor, message):
    sku = message['sku']
    actor.logger.info("Scraping SKU: " + sku)
    time.sleep(3)

Is not a coroutine. This function blocks in time.sleep(3).
A better example is to use
await asyncio.sleep(3)

The line
result = await send(worker, 'run', scrape, {'sku': 'SKU1'})

waits for results to be ready.
Your workers are not doing any concurrent work, instead they work one at the time.

Closing this ticket as it is not a bug nor a feature request.
For general discussion/help/advise the pulsar mailing list is a more suitable location.


Scroll to bottom not working when load earlier messages is enabled

if showLoadEarlierMessagesHeader = YES;
view will not scroll all the way to the bottom, seems like its not being taken into consideration.

I am seeing this on the latest build. Manually setting showLoadEarlierMessagesHeader = true in viewDidLoad seems to fix it, although since this value defaults to true that seems like unexpected behavior?


Poll if process is still alive in Test.py

In some cases this script did not detect properly that the subprocess is already terminated. The "append" loop afterwards caused memory to fill up and the script to fail eventually.
Example for this behaviour: https://travis-ci.org/MarkusTeufelberger/rippled-distrotest/jobs/310261175

Jenkins Build Summary
Built from this commit
Built at 20171202 - 21:00:36
Test Results

Build Type
Result
Status

Author Check
MarkusTeufelberger is not a collaborator!
FAIL :red_circle:

Codecov Report

Merging #2290 into develop will decrease coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2290      +/-   ##
===========================================
- Coverage    70.96%   70.87%   -0.09%
===========================================
  Files          691      691
  Lines        51663    51120     -543
===========================================
- Hits         36661    36232     -429
+ Misses       15002    14888     -114

Impacted Files
Coverage Δ

src/ripple/beast/clock/chrono_util.h
82.6% <0%> (-8.7%)
:arrow_down:

src/ripple/app/ledger/PendingSaves.h
93.54% <0%> (-6.46%)
:arrow_down:

src/ripple/app/ledger/TransactionStateSF.cpp
50% <0%> (-3.85%)
:arrow_down:

src/ripple/core/SociDB.h
60% <0%> (-3.64%)
:arrow_down:

src/ripple/server/impl/BaseHTTPPeer.h
87.57% <0%> (-3.17%)
:arrow_down:

src/ripple/app/ledger/AcceptedLedger.cpp
66.66% <0%> (-2.09%)
:arrow_down:

src/ripple/beast/utility/WrappedSink.h
54.54% <0%> (-1.98%)
:arrow_down:

src/ripple/nodestore/impl/DatabaseRotatingImp.h
60.52% <0%> (-1.98%)
:arrow_down:

src/ripple/conditions/impl/error.cpp
43.24% <0%> (-1.5%)
:arrow_down:

src/ripple/server/impl/Port.cpp
68.9% <0%> (-1.41%)
:arrow_down:

... and 203 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 090d813...6fed1ab. Read the comment docs.

Hi @MarkusTeufelberger. Thanks for the submission.
Can you explain a bit more about what's happening when the subprocess termination is not detected? I can't really tell from that Travis link.  Is there an infinite loop situation happening? Perhaps the Test.py --verbose option would be helpful.
Which "append" loop are you talking about? lines.append(decoded) on line 268/269?
Does this happen often? Are you seeing any data that shows this change actually fixes your issue?

This is already running in verbose mode I'm afraid...
So far this only seems to happen mainly on ArchLinux - my suspicion is that breaking the iteration at '' is not enough to reliably detect that the child process has terminated.
Yes, I'm talking about the lines.append(decoded) part. I'll check again soonish if this definitely fixes the issue (my Linux partition recently started to act up so I'll have to do some incantations to get the GPU driver to run again), in general though I've seen already several builds stall/fail because Test.py seems to not produce any output any more which I suspect is due to insufficient termination checks in this loop.
See the travis builds in https://github.com/MarkusTeufelberger/rippled-distrotest for details, especially the archlinux ones.

And yes, the build actually starts and works with this fix on Archlinux.

Anything you still need? I can't really add or suggest reviewers unfortunately, since there's no public overview of who is responsible for what in the rippled team.


Add Ubuntu 24.10 Oracular Oriole

https://canonical.com/blog/canonical-releases-ubuntu-24-10-oracular-oriole

I don't think we are supporting non LTS releases. labelling for PMC.

It says
https://github.com/adoptium/installer/blob/0b7c92ab49b962fbb1b1d01e3062ab4b67aaf9f7/linux/ca-certificates/debian/src/packageTest/java/org/adoptium/cacertificates/DebianFlavours.java#L34
and there are also remnants of the last STS version in the files.

Discussed in the PMC call today. @steelhead31 will provide updates.

I've taken a look at this, and will attempt to get this done this week. Im currently improving our release process for linux packages, and would like to get this merged before I complete my work, so that I can include this.  Once the checks are running green, we can merge this PR. An additional PR is needed to be able to publish the packages to artifactory for this new version, which I'll take care of as soon as Im able.

Im currently working on a PR that will fix the 2 failing actions JDK/JRE8 for alpine, the issue is not related to this PR, see : #1084

PR for package republish is here : #1085

PR has been merged, I'll be building and pushing the packages up to artifactory throughout today.

DEBs for JDK8 have all been pushed.


There should be an option to mark commands as dangerous

What part of Adonis is this related to?
Command
What are you suggesting?
Currently, some commands use a Yes or No prompt before executing. Currently, it is possible to :ban all as an Admin, and there will be no warning prompt suggesting that this might possibly be a typo. There should be some way to mark commands as dangerous, causing a prompt before executing commands if a certain number of players are affected.
This could be retroactively applied to existing commands where it is deemed necessary. If this is done, making it a settings option in the Loader might make sense.

So something like settings.WarnDangerousActions?

So something like settings.WarnDangerousActions?

That sounds like a good name for it. I'm currently working on this issue myself. The idea I came up with is if the setting is enabled, it will check if arguments are wrapped with certain symbols:
server.Commands.Danger = {
	-- Rest of the code
	Args = {"!players!"},
}

In this example, exclamation marks indicate that it should expect that:

The argument is a list of players
The argument is potentially dangerous

I haven't decided how I'll check if it's dangerous or not. I'm still unfamiliar with the Adonis codebase and trying to familiarize myself with it, so if you have any suggestions, please let me know!

Alternatively you could add an argument in the top like Fun or Disabled, like so
server.Commands.Ban= {
	Dangerous = true;
	Args = {"player(s)", "reason"},
}```

And then if the `all` selector is used then the yes/no will appear

My question, then, is how would I check which argument is expected to be a list of usernames?
To demonstrate the current dilemma, the Kick command lists player as the first argument, the Ban command lists player/user as the first argument, and the DirectTimeBan command lists username(s) as the first argument. All of these except a list of usernames, but say so differently.

Now that you mention it, I find it strange that you still get auto-complete suggestions for players even when the argument isn't expecting a player. It might be worth creating a system for noting what's expected within a given argument, but the only worry there is backward compatibility.

Now that you mention it, I find it strange that you still get auto-complete suggestions for players even when the argument isn't expecting a player. It might be worth creating a system for noting what's expected within a given argument, but the only worry there is backward compatibility.

I think the system should just check if the arg name is "player" or "plr"
Having a more complex system to validate if an arg is a player is probably a bad idea because of bloat

All user and player/user should just be converted to player even if it refers to offline players

All user and player/user should just be converted to player even if it refers to offline players

Maybe this is a little pessimistic, but what if a command expects two separate lists of players?

player and player ¯_(ツ)_/¯

All user and player/user should just be converted to player even if it refers to offline players

Maybe this is a little pessimistic, but what if a command expects two separate lists of players?

player and player ¯_(ツ)_/¯

Fair enough. I was only thinking about it from a UX perspective, given that there would be no way to tell the user what each player list means with this idea.

All user and player/user should just be converted to player even if it refers to offline players

Maybe this is a little pessimistic, but what if a command expects two separate lists of players?

player and player ¯_(ツ)_/¯

Fair enough. I was only thinking about it from a UX perspective, given that there would be no way to tell the user what each player list means with this idea.

I see
I'm not sure what exactly should be done
Anyways the user thing or player/user should just be replaced with player

Yes


factor out syntax for amendment & restatement

the convertible_note and class_f agreements know how to amend and restate themselves.
we next need this for the shareholders agreement.
factor out the code that transforms a normal agreement into an amendment.
apply that transformation to the shareholders agreement.
do it by hand, first, and describe what you do as you go along.

well, it's one line, so i'm going to mark this as resolved for now but we do need a better way in future.
for instance, we should properly log the dates of all agreements, and link A&Rs to earlier docs.
resolved by a5cb22f


cover

Current coverage is 86.57% (diff: 100%)

No coverage report found for master at 79422b7.

Powered by Codecov. Last update 79422b7...2d693e8


[R] First commit to merge to master

cc @thirdwing

Really sorry for the delay. Working on a new RECOMB paper.
I will test and complete TODO.


correlation-id plugin - "replace existing value" parameter

Summary
As correlation-id plugin documentation states:

If a header bearing the same name is already present in the client request, it is honored and this plugin will not temper with it.

I have a case, where I don't want to trust/allow any correlation-id header that comes from an outside network and generate a new header value despite its previous value, which could be corrupted.
Generally, it is doable by using request-transformer plugin globally by which I'm removing any existing correlation-id header before processing such request further.
apiVersion: configuration.konghq.com/v1
kind: KongClusterPlugin
metadata:
  name: remove-external-correlation-id-header
  namespace: example
  annotations:
    kubernetes.io/ingress.class: kong
  labels:
    global: "true"
config:
  remove:
    headers:
      - kong-request-id
plugin: request-transformer

---
apiVersion: configuration.konghq.com/v1
kind: KongClusterPlugin
metadata:
  name: correlation-id
  namespace: example
  annotations:
    kubernetes.io/ingress.class: kong
  labels:
    global: "true"
config:
  generator: uuid
  echo_downstream: true
plugin: correlation-id

But this approach has a downside because of plugin precedense and fact that a plugin will always be run once and only once per request, therefore I have to repeat this remove correlation-id header definition for every request-transformation plugin usage, for example, when I want to rewrite path of internal API.
apiVersion: configuration.konghq.com/v1
kind: KongPlugin
metadata:
  name: my-service-rewrite
config:
  remove: # This section have to copied along every request-transformer usage
    headers:
      - x-request-id
  replace:
    uri: /legacy-url/v1$(uri_captures[1])
plugin: request-transformer

That wouldn't be an issue if the correlation-id plugin has some flag that could force generating new value even for existing header e.g config.replace that would be by default disabled to maintain existing documentation assumption.
And that's my feature request - Consider adding an additional configuration parameter that could force generating a new correlation-id value even when there's already an existing correlation-id header.
config:
  generator: uuid
  echo_downstream: true
  replace: true

I'm waiting patiently for your feedback :crossed_fingers:
Source reference:
https://github.com/Kong/kong/blob/master/kong/plugins/correlation-id/handler.lua#L56-L57

This addition makes sense, and I will add it to our list of features.
However we currently cannot divert many resources to improving existing plugins. If you want to accelerate this, may I suggest sending us a pull request with the source code change (and, ideally, a test)?

Sure, we will try to prepare a pull request. Thank you for your feedback.


Listing and loading hub modules

Currently, payload.ps1 contains full paths to the available modules.
E.g. /home/user/.local/share/powerhub/modules/ps1/PowerSploit/Recon/PowerView.ps1.
Is this information really needed on the target side?
It contains details like the attacker's name and directories, which might be sensitive.
Furthermore the length of the full path can be a problem for the layout of the lshm table.
I have seen output where it got truncated at the end, cutting off the actual name of the script (making them indistinguishable).
I would like to propose to strip the module path from the module names.
E.g. the line from above becomes ps1/PowerSploit/Recon/PowerView.ps1.
That's both, shorter and more privacy preserving.

While talking about the lshm table:
From a user's perspective, I don't really know what the code column is about.
I only notice it has a value once the module is loaded.
Again, this column is so wide, it destroys the table layout, since it leads to a line wrap.
Since I guess the code is only an internal identifier, it would be great to not display the code.
Instead, a short column stating something like loaded would be great, to see which modules are already present.

(Then, I'm still confused why lhm 8 does not work, while lhm 08 does.
But since you already documented that in the help, I guess there is no easy fix.
So feel free to ignore this complain :P )
Thanks again for your work!

All good points

I'm still confused why lhm 8 does not work, while lhm 08 does

You and I both ;)
I never use the number anymore anyway. lhm powerview or whatever is way more convenient.

Ah, it's because somewhere a string is compared with an integer:
if ($i -lt $Modules.length ...
With a leading zero the condition becomes accidentally correct. Fixed in 3f46ad36add5a886d9e2285d272d7f48b233c3c0

I think there is a regression here. I noticed the full path to the modules on the attacker's machine are back.
PS> lshm

N Type   Name                                                                Loade
- ----   ----                                                                -----
0 ps1    /home/user/.local/share/powerhub/modules/ps1/PrivescCheck.ps1       False
1 ps1    /home/user/.local/share/powerhub/modules/ps1/PrintNightmare-LPE.ps1 False
2 dotnet /home/user/.local/share/powerhub/modules/exe/SharpHound.exe         False