Add paste options (bool plainTextOnly and a callback to view/modify a delta prior to pasting)

Is there an existing issue for this?

[X] I have searched the existing issues

Use case
Problem: On iOS when pasting HTML, it is converted into a quill delta object and then performs a controller replaceText().  The conversion assumes the full functionality of the editor and keeps all converted attributes.  If the QuillEditor implementation isn't using some of the Quill features, it can be inserted into the document and not be editable.  i.e. fonts, colors, images, etc.
I propose adding two changes to the controller.

Whenever HTML is pasted, pass the converted delta object to a callback that would allow the delta to be edited. The callback would return the edited delta object and that would be used with the replaceText controller method.

Provide a bool that would convert any pasted HTML into plain text prior to calling replaceText().

Alternative solutions: Currently in the onReplaceText controller callback, I'm examining the delta, removing any unsupported attributes, and then calling a 2nd replace text with the modified delta.
Proposal
quill_controller_rich_paste.dart
final htmlText = await getHTML();
    if (htmlText != null) {
      final htmlBody = html_parser.parse(htmlText).body?.outerHtml;
      // ignore: deprecated_member_use_from_same_package
      var deltaFromClipboard = DeltaX.fromHtml(htmlBody ?? htmlText);

      //Add an optional callback...
      if (verifyPasteDelta != null) {
          deltaFromClipboard = verifyPasteDelta!(deltaFromClipboard);
       }
       // end of add

      _pasteUsingDelta(deltaFromClipboard);

      return true;
    }

This issue will be addressed in #2338 (release/v11) as there are related changes in there (see migration guide for list of breaking changes).
I'm thinking about moving the QuillControllerConfig.onClipboardPaste to a separate config class related to the clipboard (QuillClipboardConfig) before addressing this issue.
What to address:

Encapsulating clipboard-related properties such as onClipboardPaste, onPasteDelta (not added yet, same as the suggested verifyPasteDelta), and enableRichTextPaste (not added yet) in one config class (QuillClipboardConfig).
Whether the QuillClipboardConfig should be in the controller's config (QuillControllerConfig) instead of the editor's config (QuillEditorConfig).
Based on the current state of the rich text paste, should we disable it by default and provide docs to enable it? In either case, the developer has onClipboardPaste to control the implementation.
Verify the functionality of the callback onClipboardPaste, see if we should change how it works, or provide some parameters, any possible issues, to avoid possible breaking changes after the release of 11.0.0.

Any suggestions?

Since there are multiple clipboard config options, makes sense to group them into their own config class
I think clipboard control belongs wherever onReplaceText lives - currently the controller
I'm not sure how quickly apps update to the latest quill. Whenever possible our team updates quickly. The enabling of rich text paste while not a breaking change, probably should have been classified as one.  If most devs aren't already using the latest, it would make sense to disable by default - or make it  required.
For the onClipboardPaste, I'm thinking the clipboard retrieval and processing is beyond most use cases when working with the editor.   In the 1st example add a comment // Do something with the clipboardData before the return true i.e. onReplaceText.  Maybe flip the order of the examples b/c the difficulty of writing a custom handler for all types of clipboard data is non trivial.
Maybe change onPasteDelta to onPaste(Object? deltaOrString) so any type of paste can be intercepted / modified

In the 1st example add a comment // Do something with the clipboardData before the return true

The ClipboardData is a Flutter API that only supports plain text, in this example, it was used to check if the clipboard has plain text and then remove the plain text from the system clipboard. Not a very useful example though.

The enabling of rich text paste while not a breaking change, probably should have been classified as one

I agree, even though I introduced it in 9.0.0 it was buggy at the time, and didn't mention this as a breaking change in CHANGELOG.md.

Maybe change onPasteDelta to onPaste(Object? deltaOrString) so any type of paste can be intercepted / modified. If this was the case

How about adding both onPasteDelta and onPastePlainText for type safety (this name suggestion is not final), it's also a bit more clear.

Object? deltaOrString

It can be an image.
I'm thinking about moving onImagePaste and onGifPaste from the editor's config to the QuillClipboardConfig since v11 is still published as pre-release (dev).
Since the clipboardPaste method is in the controller and pasteText (in QuillRawEditorState) still uses those callbacks.

This might be a good feature (#2354) to add or at least provide a way to customize the copy/cut behavior.

Whenever HTML is pasted, pass the converted delta object to a callback that would allow the delta to be edited. The callback would return the edited delta object and that would be used

Added the onDeltaPaste callback.
To try the latest pre-release version (#2338):
dependencies:
  flutter_quill: ^11.0.0-dev.4

See the migration guide.
Use the QuillClipboardConfig:
QuillController.basic(
  config: QuillControllerConfig(
    clipboardConfig: QuillClipboardConfig(
      onDeltaPaste: (delta) async {
        // TODO: Your custom implementation or return the Delta directly
        return delta;
      },
      onPlainTextPaste: (plainText) async {
        // TODO: Your custom implementation or return the plain text directly
        return plainText;
      },
    ),
  ),
);

@mtallenca Do the parameters onDeltaPaste, onPlainTextPaste, and enableExternalRichPaste fix the issue?
What is missing is Paste as plain text (for the end-user) in the context menu which is supported by default on native Android, we can add it on all platforms or Android only, it's similar to native Android though not the same.

Yes, having these will fix the issue
On Mon, Nov 11, 2024, 1:22 AM Ellet @.***> wrote:

@mtallenca https://github.com/mtallenca Do the parameters onDeltaPaste,
onPlainTextPaste, and enableExternalRichPaste fix the issue?
What is missing is Paste as plain text (for the end-user) in the context
menu which is supported by default on native Android, we can add it on all
platforms or Android only, it's similar to native Android though not the
same.
—
Reply to this email directly, view it on GitHub
https://github.com/singerdmx/flutter-quill/issues/2350#issuecomment-2467636108,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXMGLNDN5OVAD7MXNZXQFL2ABZNTAVCNFSM6AAAAABRHUH7DSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRXGYZTMMJQHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Whenever HTML is pasted, pass the converted delta object to a callback that would allow the delta to be edited. The callback would return the edited delta object and that would be used

Added the onDeltaPaste callback.
To try the latest pre-release version (#2338):
dependencies:
  flutter_quill: ^11.0.0-dev.6

See the migration guide.
Use the QuillClipboardConfig:
QuillController.basic(
  config: QuillControllerConfig(
    clipboardConfig: QuillClipboardConfig(
      onDeltaPaste: (delta) async {
        // TODO: Your custom implementation or return the Delta directly
        return delta;
      },
      onPlainTextPaste: (plainText) async {
        // TODO: Your custom implementation or return the plain text directly
        return plainText;
      },
     enableExternalRichPaste: false, // Currently default to true
    ),
  ),
);

Thank you very much for your reply!
However, I only see string2string and delta2delta related conversions. But we may copy a string with emojis somewhere (not in quill), such as "Hello[smile]Mike![cheer][cheer][cheer]", and users can copy and paste it on any APP without exposing the emoji protocol in this APP. After we paste this string in quill, we actually hope to parse the strings "[smile]" and "[cheer]" into corresponding emojis and display them in quill.
Therefore, I think we may also need a method to convert strings to Delta. Do you think so?

You can use onClipboardPaste for custom implementation, though you're right, I don't see a strong reason why onPlainTextPaste shouldn't expect Delta? instead of String?.
  /// Callback triggered when pasting plain text into the editor.
  ///
-  /// Returns modified text to override the pasted content, or `null` to use the default.
+  /// Returns a [Delta] to override the pasted content, or `null` to use the default.
  @experimental
-  final Future<String?> Function(String plainText)? onPlainTextPaste;
+  final Future<Delta?> Function(String plainText)? onPlainTextPaste;

The API design needs more consideration.

您可以使用onClipboardPaste自定义实现，虽然您是对的，但我看不出有什么强有力的理由onPlainTextPaste不应该期望Delta?而不是String?。
  /// Callback triggered when pasting plain text into the editor.
  ///
-  /// Returns modified text to override the pasted content, or `null` to use the default.
+  /// Returns a [Delta] to override the pasted content, or `null` to use the default.
  @experimental
-  final Future<String?> Function(String plainText)? onPlainTextPaste;
+  final Future<Delta?> Function(String plainText)? onPlainTextPaste;

API 设计需要更多考虑。

The Delta data structure is a common data structure in flutter_quill. No matter what kind of data it is, it will eventually be displayed in quill in the form of Delta. string is a common format for various input boxes.
However, since we are using the "paste" function, no matter what form the external data is in, it will eventually be converted into the form of Delta in quill. For example, the result obtained after string2string will eventually become the form of Operation(insert(xxxxxxxx)).
The onClipboardPaste function will change the data in the user's clipboard, such as the data when the emoji in the string is encoded and parsed into emoji images in Quill as I mentioned earlier. If the parsed data is pasted back to the clipboard, then the user will see our encoding format when pasting it in other apps. From the user's perspective, this is not reasonable.
Therefore, I think string2Delta is necessary. Because string2string is just a subset of string2Delta.

The Delta data structure is a common data structure in flutter_quill. No matter what kind of data it is,

I do agree with that as stated in my previous comment.

The onClipboardPaste function will change the data in the user's clipboard

The behavior slightly changed in v11 (see breaking changes), it allows to override the default with a custom implementation, it can be used to check if the clipboard as plain text, process the paste and then return true (see example code). I do plan on changing it to return Delta instead.

The Delta data structure is a common data structure in flutter_quill. No matter what kind of data it is,

I do agree with that as stated in my previous comment.

The onClipboardPaste function will change the data in the user's clipboard

The behavior slightly changed in v11 (see breaking changes), it allows to override the default with a custom implementation, it can be used to check if the clipboard as plain text, process the paste and then return true (see example code). I do plan on changing it to return Delta instead.

Thank you, sir!

Thank you

You're welcome.

any progress? THX!

The issue has already been resolved in the pre-release. See this comment.
The v11 is already stable. We didn't publish it as stable since we have one breaking change, which is removing the magnifier feature (see #2413 for more details).

Thank you for your reply. But I meant the following one

-  final Future<String?> Function(String plainText)? onPlainTextPaste;
+  final Future<Delta?> Function(String plainText)? onPlainTextPaste;

Function(String plainText)? onPlainTextPaste;

We might need to change plainText to Delta too since the QuillController has an internal clipboard (not the same as the system clipboard) that contains the copied content as rich text. If we always provide plain text, the text attributes might be lost if the user copies rich text inside the editor and then pastes it.

Changing it to Delta makes it no longer plain text, maybe onTextPaste would be a better name, or perhaps a second callback?
Currently the onDeltaPaste is used only for the external rich text paste, however using it for the internal rich text paste is also valid.

[!NOTE]

The internal rich text paste occurs when the user copies and pastes content inside the editor from the internal clipboard.
The external rich text paste occurs when content is pasted from other apps while preserving styles using the system clipboard.

Here is an example after introducing the change:
onPlainTextPaste: (String plainText) async {
          return Delta()
            ..insert('The plain text from the clipboard', {'bold': true})
            ..insert(':\n')
            ..insert(plainText);
        },

https://github.com/user-attachments/assets/67a901b4-5906-40a2-a47e-453537110b29

Hi, thx for your reply! But the latest code is still the old version
https://github.com/singerdmx/flutter-quill/blob/6640579b7b8062b2f0c974259ee0b9c52e4fb85d/lib/src/controller/clipboard/quill_clipboard_config.dart#L79
Is that change still in your local repo? When will it be merged into the master? THX!

I'm only interested in altering pasted text when it's coming from the system clipboard (so I can ensure it's only using attributes that the current editor config has). I would like anything copied from the editor then pasted back into the editor to remain unmodified. Need a bool to indicate system clipboard?

Is that change still in your local repo? When will it be merged into the master?

Yes, it needs more consideration before merging.

I'm only interested in altering pasted text

You're right. That is a separate topic and should be in #2156.

I would like anything copied from the editor then pasted back into the editor to remain unmodified.

Currently, the onDeltaPaste is only used when pasting Delta from the system clipboard, but that's subject to change.
The API is not final.
The onDeltaPaste is more generic and might not be very clear.
I'm considering onExternalRichTextPaste and onInternalRichTextPaste to separate them. The external paste is when it's coming from the system clipboard.

Need a bool to indicate system clipboard?

Having onRichTextPaste with a boolean is also valid.


Revert "Install regular PHP packages instead of dev versions"

Reverts laravel/sail#340

What's the reason this got reverted?

We upped the Ubuntu version instead which contains the correct packages.
https://github.com/laravel/sail/commit/57d2942d5edd89b2018d0a3447da321fa35baac7


Do not use strict version constraints in pyproject.toml

Fixes https://github.com/DataDog/guarddog/issues/79

I also updated the requirements using poetry export which seems to be the way you are suppose to do it. I do not know if you guys were updating it before. I also do not really have any experience with poetry either.

Thanks for the contribution, looks like the CI is failing though. Let me know if you need help fixing it

Is there a change we can get a new PyPi release now? It looks like there has not been one since March and there has been a number of new changes (outside of just this one).

I was hoping to merge a few more PRs before a release, but since it has taken more time than anticipated, no objection - thanks for the nudge!


Error in dark mode handling in tutorial

Describe the bug
The tutorial changes the from dark to light mode unexpectedly.
Reproduction

goto https://learn.svelte.dev/tutorial/named-form-actions
toggle dark mode
click "Solve"
remove the first todo "Learn SvelteKit"
the tutorial output (not the rest of the page) changes to light mode

Logs
No response
System Info
Chrome, Firefox

Severity
annoyance
Additional Information
No response

This seems to happen when the use:enhance is not used, and the form submission is handled by the browser.
Also happens in sveltelab.dev

Closing this as it's no longer reproducible on the new Svelte website.


c99: fix -Wstrict-prototypes error on clang 15

Fixes the following error when building on macOS 14:
gcc -std=c99 -Wall -Wextra -Wno-unused-variable -Wno-unused-function -Wno-unused-parameter -Wno-unused-value -Wno-missing-braces -Werror -pedantic -O0 -g -o bin/mirth0 bin/mirth0.c
bin/mirth0.c:452:27: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
static void do_pack_uncons() {
                          ^
                           void
bin/mirth0.c:640:21: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
static void do_debug() {
                    ^
                     void
2 errors generated.
make: *** [bin/mirth0] Error 1

Looks good, thank you!


HiBitSoftware.HiBitUninstaller version 3.1.50

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Submission containing materials of a third party:
Author: Mohammed Raee
Publisher: HiBitSoftware
PublisherUrl: https://www.hibitsoft.ir
PublisherSupportUrl: https://www.hibitsoft.ir/About.html
License: Proprietary
Copyright: Copyright @ 2017-2023 HiBitSoft.IR All Rights Reserved

@microsoft-github-policy-service agree

During the verification period the developer has updated the software. A new request has been submitted for this reason. This one is closed.


[BugFix] Fix be report version bug

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

run starrocks_admit_test

run starrocks_admit_test


feat: initial support for c bindings

I'm unclear on if this is allowed in our primary repo, but I personally think the c bindings should be here. Thoughts welcome.

closing in favor of #1321


HydroShare Certificates

get certificates for hydroshare.org and subdomains

Conversation thus far
Request:
From: Averill, Casey Martin
Sent: Wednesday, April 29, 2015 11:37 AM
To: ITS Software
Subject: Certificate Request - hydroshare.org

I have attached a CSR for:

CN=hydroshare.org
SAN=hydroshare.org
SAN=www.hydroshare.org

Response:
From: ITS Software
Sent: Wednesday, April 29, 2015 2:34 PM
To: Averill, Casey Martin
Subject: RE: Certificate Request - hydroshare.org

Casey,

The Organization Registrant for this domain is Utah State. Before I can create a certificate it needs to change to The University of North Carolina at Chapel Hill. Also the “tech email” is listed as<EMAIL_ADDRESS>that should be changed to<EMAIL_ADDRESS>
http://whois.domaintools.com/hydroshare.org

Follow on:
I don’t have a work-around, so the only 2 options you have identified are correct:

1)      Have USU issue the cert, not UNC, or
2)      Transfer hydroshare.org to UNC so UNC can issue the cert

This is Dave’s call.  If he goes with option 1, you may need to provide instructions about how one goes about obtaining these certificates since he’s still travelling on the road for another ~week.

Additional information:

Universities don’t generally act as certificate authorities, except for in rare cases.  If USU has a partnership with a particular CA to provide low-cost certs, by all means go through the local IT department to purchase one.  Otherwise, you’ll have to get it from a trusted commercial authority like DigiCert.  Commercial authorities will verify the identity of the requesting institution via a series of e-mails and phone calls.  Commercial certs range in price from ~$100 per year for single-name certificates up to ~$1000 per year for wildcard certificates.

StartSSL also offers certificates for free, verified through domain e-mail without human intervention. LetsEncrypt, the EFF/Mozilla initiative to make certificates easier to obtain, should also be launching soon. Both may be alternatives to the university red tape.

Bought a wildcard certificate from GoDaddy for *.hydroshare.org.  Casey Averill reports he has installed and validated on load balancer.  Details of certificate are with @mjstealey @rayi113 and @dtarb.

Are there follow up tickets for:

Webserver configuration changes required?
Hydroshare project/application changes required?

Are there follow up tickets for:
Webserver configuration changes required?
Hydroshare project/application changes required?

Not yet - will be soon though


App doesn't request presence information

When trying to auth an account, presence data is not requested (especially when using alternate authentication):

The 'App' is the one you created in the Azure portal as detailed in how to get your client secret.The integration itself I don't believe requests permissions at all, rather it requires that you have configured the permissions correctly. For me, my permissions look like this on the API Permissions tab of the App registration. You say you have set permissions on the Azure AD, but that sounds different to here (I may well of course be wrong), certainly your screenshot in the other issue has a different layout.

I add my usual caveat here, I'm caretaking this integration because otherwise it would not work anymore and the previous maintainer had archived it. I'm slowly learning, but each time there is a new type of problem at the MS end of it, it takes time figure out what is going on.

Looks like I may be wrong. Try modifying cont.py around line 100 to add Presence.Read.

I'm looking at the code around checking permissions. It needs sorting out.... I'll spend a couple of days (if I have time) at the start of next week making it more intelligent. I've not looked at it before :-(

Not a problem.
The screenshot I pasted is from when you use the alternate auth method.
Instead of using the app registration, the alt ath method creates a service principal in Azure AD which is what requested the permissions and missed Presence.Read.
I'm not a dev, but I know my M365 and it's quirks. :)
Will make that modification tomorrow and give it another go.
Thanks

Just a note on permissions...
I did see it come up earlier when it detected that I'd reduced the permissions.
I get the logic, but there's things in there that I don't want the app to be able to do against a corporate environment - such as write to objects or send on behalf of others.
It would be nice if while you're reviewing it, there was a way to out a flag/switch/toggle into the config that ignores a reduced permission set.
It's only because I'm the admin of our tenant that I'm even allowing it with the current permissions. If it was one of my users or clients - I'd be telling them not to allow it in its current form. :)

I intend to get it to retrieve the permissions, then validate they match the configured sensors/calendars and get it to authenticate if not. At the moment it is just 'does it have any permission', if it does then go ahead and enables sensor, if not ask for permissions.
I'd also aim to get it to build the permissions scope when authenticating against the requested sensors/calendars - at the moment it requests everything it might need, rather than what it does need. Not very 'Least Privilege', but it works because if someone then just configures what they want to give then it will work.
All I have with me at the moment is a laptop, which I can remote into my home environment for emergencies, but this is relatively complex and I want my two big screens :-)

Thank you for your efforts, they are greatly appreciated. :)

Seems to be all working now after a restart this morning!
I modified the const.py to add Presence.Read and happy days.
Also modified the minimum sensors required to only have user.read and calendars.read so it would stop complaining. :-)


[SMALLFIX] Fix a flaky test S3RestServiceHandlerTest.java

What changes are proposed in this pull request?
In this PR I have fixed the flaky test testDeleteObjectReq in alluxio.proxy.s3.S3RestServiceHandlerTest
The following command was used to detect flakiness using nondex and can be used to re-produce the flakiness:
mvn  -pl dora/core/server/proxy  edu.illinois:nondex-maven-plugin:2.1.1:nondex  -Dtest=alluxio.proxy.s3.S3RestServiceHandlerTest#testDeleteObjectReq

NonDex detects flakiness in the assert statement that compares the two XML strings shown below
https://github.com/Alluxio/alluxio/blob/e83066383524537ada5af32eca5236632cd245b9/dora/core/server/proxy/src/test/java/alluxio/proxy/s3/S3RestServiceHandlerTest.java#L66
Explanation:
We have defined one expected string and we are constructing the other string by converting an object of class DeleteObjectsRequest to string using jackson xmlMapper's writeValueAsString function.
The writeValueAsString function as per docs internally serializes any Java value as JSON output and then converts it into a string using string writer. The conversion of intermediate JSON object to the final string causes flakiness as JSON does not preserve order.
Therefore, the output string o of the below line is non deterministic which can lead to failures during the assert check:
https://github.com/Alluxio/alluxio/blob/e83066383524537ada5af32eca5236632cd245b9/dora/core/server/proxy/src/test/java/alluxio/proxy/s3/S3RestServiceHandlerTest.java#L61-L63
Why are the changes needed?
I have written a custom code to compare the XML strings
JsonNode tree1 = mapper.readTree(o);
JsonNode tree2 = mapper.readTree(content);
assertTrue(tree1.equals(tree2));

We convert both the xml strings to  set of JsonNode instances. Then we compare these two nodes. The equals  function as per docs performs a full value quality check ensuring no order change issues arise. After this fix, nondex did not detect any flakiness.
Test Environment:

openjdk version "<IP_ADDRESS>"
Apache Maven 3.6.3
Ubuntu 20.04.6 LTS
Linux version 5.4.0-156-generic

Does this PR introduce any user facing changes?
No

Thank you for your pull request. In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement (CLA). It's all electronic and will take just a few minutes. Please download CLA form here, sign, and e-mail back to<EMAIL_ADDRESS>
I have submitted the CLA form.

Any update on this PR?

@jiacheliu3 Since the review is completed, can we go ahead and merge this?

@jiacheliu3 Since the review is completed, can we go ahead and merge this?

@jiacheliu3 , @Jackson-Wang-7  any updates on this?


Add support for LinearSolve

Codecov Report
Base: 83.50% // Head: 83.15% // Decreases project coverage by -0.35% :warning:

Coverage data is based on head (e0752b1) compared to base (5aeae73).
Patch coverage: 83.84% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   83.50%   83.15%   -0.35%
==========================================
  Files          18       19       +1
  Lines         891      926      +35
==========================================
+ Hits          744      770      +26
- Misses        147      156       +9

Impacted Files
Coverage Δ

src/sparsematrixcsc.jl
52.38% <40.00%> (-5.52%)
:arrow_down:

src/pardiso_lu.jl
69.56% <60.00%> (-2.53%)
:arrow_down:

src/extendable.jl
66.66% <68.14%> (-1.89%)
:arrow_down:

src/factorizations.jl
77.27% <70.58%> (+8.52%)
:arrow_up:

src/sprand.jl
71.17% <72.29%> (ø)

src/iluzero.jl
85.71% <81.81%> (+1.09%)
:arrow_up:

src/sparspak.jl
83.33% <81.81%> (+1.51%)
:arrow_up:

src/umfpack_lu.jl
91.66% <88.88%> (+0.75%)
:arrow_up:

src/cholmod_cholesky.jl
93.33% <91.66%> (+0.47%)
:arrow_up:

src/jacobi.jl
88.00% <94.73%> (+0.50%)
:arrow_up:

... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


CORS warnings

Can't access cssRules, most likely due to CORS restrictions https://use.typekit.net/zkq0zzv.css

Anyway to detect this and prevent "spamming" the console?

Yeah I noticed this too when loading webfonts from Google. Let's avoid logging the same warning over and over again.

Yeah I noticed this too when loading webfonts from Google. Let's avoid logging the same warning over and over again.

Fixed in 1.0.0-rc.3

Fixed in 1.0.0-rc.3


Object.assign is not a function 😞

Chromium (37) and Firefox (31) on Travis are oldish and complain that Object.assign is not a function: https://travis-ci.org/the-grid/ed/builds/115555196#L962
I'll see if this polyfill helps: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign#Polyfill

That fixed it. Would you put that polyfill in Rebass?

Doesn't babel have a polyfill for Object.assign? Would rather keep things in the Babel ecosystem if possible.

I think this is the one: https://babeljs.io/docs/usage/polyfill/
Either I can try to add it or you can submit a PR if you're already working on something :sunglasses:

On second thought, maybe this should just be a peer dependency...
or I should replace Object.assign with the spread syntax, which I think Babel handles better...

Babel inlines an extend method if you use spread syntax in jsx (notice that it's already inserted in the output)

I just put the polyfill in my own project, but upstream fix would be appreciated.

Native Object.assign should be gone now in 0.2.4. Let me know if it's still lingering around somewhere.


Modify inst migrator asset

Guidelines
Soft Schema Freeze
The nmdc-schema and berkeley-schema-fy24 schemas are under a soft freeze, which means changes should not be made that have any downstream implications. To ensure this, all PRs created creating during the freeze will be closely reviewed with every component of the NMDC system in mind.
Reviewers
To ensure no changes are made unexpectedly, PR creators will request reviews from all Berkeley Schema Roll Out task coordinators.
We expect task coordinators to review PRs and provide feedback/approval within 1 week of when they are identified as reviewers.
PRs will NOT be merged until all task coordinators (or one of their delegates) have approved.
Expedition, questions, and discussion can happen at any meeting.
Delays in review & merging should be addressed in meetings or with NMDC leadership.
PR Information
What type of PR is this? (check all applicable)

[ ] Refactor
[ ] Feature
[x] Bug Fix
[ ] Optimization
[ ] Documentation
[ ] Schema change: Structure and content

created, updated, or deleted a class, slot, or enum
changed whether a slot is multivalued
changed the way a slot is assigned to a class
changed the permissible_values of an enum
etc.

[ ] Schema change: Cleanup and preparation

updated the description of a class, slot, or enum
updated the mappings of a class, slot, or enum to an ontology
added an enum for future use (it is not in the range of any slot)
etc.

Description
In this branch there are updates to the instrument_set.yaml file for the mappings for the migrator.
Related Issues

All PRs should relate to or fix an issue(s). Please identify the issue(s) below.

Related Issue(s): #
Fixes: #

Did you add/update any tests?

[ ] Yes
[x] No (Add a justification below)
[ ] I need help with writing tests

Could this schema change make it so any valid data becomes invalid?

This is a question about what the schema allows. It is not a question about what happens to exists in the NMDC database right now.
Example: If, in this PR branch, you renamed a slot from foo to foo_bar, the answer to this question would be "yes," even if nothing in the NMDC database currently uses the foo slot.
More examples: slot or class name changes, changes to a slot's multivalued state, changes to a slot's range (e.g. string to integer), changes to slot assignments to classes, changes to an enum's permissible_values

[ ] Yes (A migrator is required)
[ ] No
[x] I need help determining this

We need to review if the existing migrator still works with this updated yaml config.
If you answered "Yes", does this PR branch include that migrator?

[ ] Yes
[ ] No, this PR is incomplete and I need help writing the migrator

Does this PR have any downstream implications?

Examples: any change here that requires a change to workflows, workflow automation, the Mongo-to-Postgres ingest process, Jupyter notebooks, the Runtime, etc.

[ ] Yes (Explain below)
[x] No

wrong repo.


Initial Travis Test for Tululbot

Currently, Tululbot is designed to be run on specific machine (Heroku and local). Tululbot is not designed to be tested and run locally.
This also means to refactor the Tululbot so it is testable. (cc @fushar)

Agree. This morning I tried to write some tests for tululbot but haven't finished it yet. I think we can use Flask Testing for this.

Hi kems. Thanks for suggestion. Since i am new to python, perhaps the initial is to make this repo compliant with Travis. We can incrementally build the test after this.


romio: Documentation failed to build on docs.rs

https://docs.rs/releases/search?query=romio

The requested resource does not exist

Crate romio requires nightly, is it the issue for missing docs?
Fixes https://github.com/withoutboats/romio/issues/44

Attempting to build it by hand with the latest nightly rustc yields the following log:
2018/11/30 20:42:42 [DEBUG] cratesfyi::docbuilder: Loading cache
2018/11/30 20:42:42 [DEBUG] cratesfyi::docbuilder: Loading database cache
2018/11/30 20:42:43 [INFO] cratesfyi::docbuilder::chroot_builder: Building package romio-0.3.0-alpha.1
2018/11/30 20:42:43 [DEBUG] cratesfyi::utils::build_doc: Getting package with cargo
    Updating crates.io index
thread 'main' panicked at 'Building documentation failed: ErrorMessage { msg: "feature `rename-dependency` is required\n\nconsider adding `cargo-features = [\"rename-dependency\"]` to the manifest" }

failed to parse manifest at `/srv/cratesfyi/.cargo/registry/src/github.com-1ecc6299db9ec823/romio-0.3.0-alpha.1/Cargo.toml`

unable to get packages from source', libcore/result.rs:1009:5
note: Run with `RUST_BACKTRACE=1` for a backtrace.

This tells me it's not a problem of needing a new rustc, but a new cargo. Updating cargo on docs.rs requires updating the site itself, since it uses cargo as a library. I'll work on this once the Rustdoc Team gets permission on the recently-moved repo and our CI gets updated.

@onur Would you please trigger the build to see whether the fix worked or not?

@kpp its been built now: https://docs.rs/romio

Thanks!


Add monitoring to GCE VMs

It would be nice to have monitoring of our GCE VMs. Currently it's mostly just me poking around when something goes wrong. Like if we run out of disk space. Disk space monitoring requires installing monitoring agents https://cloud.google.com/stackdriver/docs/solutions/agents/ops-agent/

We're migrating to Azure (or maybe AWS). This old issue isn't worth keeping open.


ChannelPool: least outstanding request algorithm

Our ChannelPool uses a round-robbin approach to selecting a Channel.  It's effective in most cases, but may cause problems in other cases.   A user found that one channel was slow and overloaded and caused various problems a "least outstanding request algorithm" will reduce problems like theirs in the future.

Hi,
I've been in contact with the Japanese support team about the issue.
Here's my implementation of the algorithm: https://github.com/eiiches/cloud-bigtable-client/commits/feature/least-outstanding-requests-balancing-channel-pool
We've load-tested the implementation, and it worked well, but I'm still worried that there may be some corner case that the number of outstanding requests is not correctly incr/decremented.
I can open a PR if you like, but it will probably take some time to sign a Corporate CLA. So I'd also be glad if someone can implement it independently.
All that said, I believe these kind of load balancing algorithms should be ideally provided by gRPC modules to avoid re-implementing it everywhere.

Hi eiiches,
Thanks for sharing! I've sketched out an alternative approach here: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/pull/1774.
It should have a lower overhead to maintaining an ordered list of loaded connections while evenly spreading the load across the pool.
Also, GRPC actually has native load balancing , which we will switch to at some point in the future.

Wow, I like your approach! I'll switch to your implementation when it gets merged.
Thanks!

To chime in here, I recently spent time debugging a very-high p9999 latency in our requests.  We've been at a limited-load launch, so our QPS to bigtable has been fairly low and spread across a lot of instances of our service.  It turns out the QPS was so low that our connections would be closed due to inactivity by our outgoing NAT devices.
My solution was to simply reduce the data channel count to 1, but thats not great because now I need to remember to increase it (maybe?) as we ramp up traffic.
A cool solution might be to build a pool that dynamically expands/contracts based on the exponential moving average of the load over the channels.

I've had similar thoughts about auto-tuning Channel Pools.  The gRPC team is working on their own implementation of Channel Pools, which is likely to be better than anything we develop specifically for Cloud Bigtable.  The Channel Pool implementation is different from the Load Balancing feature of gRPC that @igorbernstein2 mentioned

The gRPC team is going to continue to work on this.  We'll use their pooling mechanism when it's ready.


Hovers broke from #343

updateCategory hasn't actually been doing anything to change the categories...it's all been the hover.
lost hovers because when waterUseViz.interactionMode was checked in the if statement for addButtons, it was undefined.

There's a lot going on here, and I'm not sure I understand fully, but I think I want to propose a very different approach to this.
The problem, as I currently (barely) understand it, is that iOS mobile devices recognize a hover event and let that interfere with a click event when you tap with your finger. On desktop, we're relying on hover + click to complete the steps needed to fully change categories. So executing only those commands triggered by hover works poorly. I don't know what's happening on non-iOS mobile devices and am worried that this means I'm missing something important. Still, forging ahead:
The solution proposed in this PR is to

reintroduce a hover event on all mobile devices, even though most of them can't recognize hover and the ones that do recognize it do the wrong thing with it, and
cause updateCategory to call showCategory such that on desktop, showCategory will get called at least twice when you move the mouse onto a button and then click.

Neither of these steps seem ideal to me, for the reasons noted above.
Instead, how about:

separate into its own function the code (currently in resize.js) that detects waterUseViz.viewport and waterUseViz.interactionMode. call this, say, detectDevice.
call detectDevice early in build_map.js, such that the value of waterUseViz.interactionMode is defined before addButtons gets called.
don't define mouseover or mouseout events unless waterUseViz.interactionMode === "hover" (i.e., revert to #343)
maintain the separation between updateCategory and showCategory that existed before this PR.
if waterUseViz.interactionMode === "hover", define mouser.on('click' as it's currently being defined, like this:.on('click', function(d){
  updateCategory(d.toLowerCase(), activeCategory);
});

if waterUseViz.interactionMode === "tap", define mouser.on('click' as it's currently being defined, like this:.on('click', function(d){
  showCategory(d.toLowerCase(), activeCategory, action = 'mouseover');
  updateCategory(d.toLowerCase(), activeCategory);
});

Here's a more concise summary of the behavior I'm seeing. On beta: iOS registers hovers when it shouldn't (and on the mobile view in dev tools, clicking a category also registers as a hover); desktop technically registers a hover before a click anyway. After adding if so mouseover events are only added when interactionMode == "hover" (result of #343), showCategory was no longer called on mobile, so only the hash changed when you clicked and nothing was visually updated.
Potential solutions are complicated by #346. I don't really want to get into change waterUseViz.interactionMode earlier, but I guess if it wasn't too complex we could do that, or we could leave the ifs inside the actions.
Potential solution 1 (change the URL hash when button is clicked, only visually update when mobile click):
.on('click', function(d){
  updateCategory(d.toLowerCase(), activeCategory);
  if(waterUseViz.interactionMode === "tap") {
	showCategory(d.toLowerCase(), activeCategory, action = 'click');
  }
})

Potential solution 2 (if we decide #346 is a good idea, don't register click at all for desktop and have mouseovers update the hash and change the active category):
.on('click', function(d){
  if(waterUseViz.interactionMode === "tap") {
    updateCategory(d.toLowerCase(), activeCategory);
    showCategory(d.toLowerCase(), activeCategory, action = 'click');
  }
})
.on('mouseover', function(d){
  if(waterUseViz.interactionMode === "hover") {
    // need these ifs inside .on("mouseover") because waterUseViz.interactionMode
    // is undefined when addButtons is run
    updateCategory(d.toLowerCase(), activeCategory);
    showCategory(d.toLowerCase(), activeCategory, action = 'mouseover');
  }
});
// and delete mouseout action

For either of these, I would want to add the ability to turn off events for showCategory or updateCategory because they both fire an event right now.


Preset saving has issues in VST3

For the VST3 version, when a preset is saved it switches to another preset and you can't select the new preset until the plugin is restarted. The preset panel also starts graphically glitching at the same time.
https://linuxmusicians.com/viewtopic.php?p=159612#p159612

Fixed in fcb11e390146ae1520aff2793f63192cf1d7d548


✏ Create CLI tool to generate TMDB JSON responses

Description
We frequently need to generate sample bits of TMDB JSON responses for use in testing. As our code and the API is updated, these responses change slightly. It can be a bit of a pain to maintain these sample responses. To solve this issue, we should create a CLI tool that will automatically fetch and format the code for the developer which can then be injected into our constants files.

Give the dev options of which type of request (search, details, recommendations, trending, etc.)
Give the dev the option to send the output to a file or stdout
Allow the dev to truncate the output in some way

Closed by #812


[google_maps_flutter] setMapStyle should not be deprecated

Use case
I need to be able to change map styles dynamically without recreating the GoogleMap widget.
Proposal
It is OK to keep the new GoogleMap style property, but do not deprecate the existing setMapStyle method.

I need to be able to change map styles dynamically without recreating the GoogleMap widget.

Why do you need this? Please describe the use case itself, not the proposed solution. Recreating widgets is the standard way to change properties in Flutter.

I refactored to use only the new style property.


Remove Twistlock from API

User Story - Business Need
We are replacing Twistlock with AWS Advanced Scanning and AWS Inspector. The Infra is being removed for Twistlock. The workflow for Twistlock should be removed from notification-api.

[ ] Ticket is understood, and QA has been contacted (if the ticket has a QA label).

User Story(ies)
As a  VANotify
I want to remove any workflows for Twistlock
So that we do not have unecessary code or any action that can run twistlock.
Additional Info and Resources

Infra work on 614 should be completed first.
Engineering Checklist

[ ] Twistlock workflow is removed
[ ] Verify that no other workflows call the twistlock workflow.
[ ] Twistlock Info is removed from the Readme
[ ] Twistlock page in team repo is removed.

Acceptance Criteria

Deployments do not trigger the twistlock scanning
Twistlock is not referenced in any actions

Closing.

Restored and re-opening this ticket.
AWS Inspector is enabled (with advanced scanning) and supports scanning both the OS and the packages on containers, as well as EC2 instances and Lambdas, thus it covers everything that Twistlock currently does for us. We can carry on with this work.


Add delete email support

Add ability to delete an email.

Hi @ainformatico, please take a look at my PR to support deleting email.  Thanks!

Also, I set rubocop version to 0.41.2 because newer versions were not compatible with ruby 1.9.3.


adding cache_raw to cache data without templates

+1 . Does anyone have an idea if this will be merged into master? Would really be nice! Thanks.

Bogdan,
I will try to have a look at it over the weekend.

thank you :)


How to run locally

It seems like every service needs to connect to a database. I'm not familiar with SQL and don't know how to set up these databases correctly. Would you please add more detailed steps in the README file?

Good Issue. Ok.
Of course, the project can be run locally. But for the document part, we are still working on it.
I will add more details.  So running it locally is different from running an app on it. So there are so many for us to talk about.
This issue will remain opening until the document is finished.


An error occurs when selecting "Connect to a GitHub Repository…" under "Deployments" node

OS: Win10 / Mac
Build Version: 20190519.1
Regression:  Previous release (0.14.0)
Repro Steps:

Expand one web app -> Expand node "Deployments".
Select "Connect to a GitHub Repository...".
Check the result.

Expect:
No error occurs.
Actual:
An error occurs.

Hi @v-xianya,
Thanks for your work and reporting this!
I wasn't actually able to reproduce this error by following your repro steps.  Could you confirm that these are the exact steps to repro?

Hi @nturinski ,
Thanks for your updates. This issue still reproduce in my side.
Maybe you could try to reproduce this issue on the new created web app "Azure Tools Manual Testing 1 -> testforissue1" .

Unfortunately, I do not have access to that web app and can't create any new resources in that subscription.
Do you have GitHub authorized with Azure??

Hi @nturinski , I am so sorry.
I have added you as a Contributor role to "Azure Tools Manual Testing 1" subscription. Could you help to
try again? Thanks a lot!


Feature: Implement endpoint or push notifications for source health checks

Based on #65
[ ] Implement a healthcheck endpoint to monitor status (running/idle) of sources/clients
[ ] Integrate discord webhook or something like pusher webhook to allow notifications when health changes for sources/clients

The webhook would probably also support REST notification services like gotify or notify.sh, correct? If so, that would be awesome, looking forward to that feature!

@iluvatyr @Karsten-Yan
I've implemented webhooks for Gotify/Ntfy as well as a health check endpoint. Preview in develop
Webhooks can be added to config.json using webhooks property (see schema for examples and structure)
{
  "sources": [
  ],
  "clients": [],
  "webhooks": [
    {
      "type": "gotify",
      "url": "..."
    }
  ],
}

Health endpoint can be accessed at http://YourMsURL/health

returns 200 when everything is working or 500 if anything is not
the plain url (/health) aggregates status of all clients/sources -- so any failing client/source will make status return 500
use query params type or name to restrict client/sources aggregated IE /health?type=spotify or /health?name=MyMaloja
on 500 response returns a JSON payload with "messages" that describes the issue

for any clients/sources that require authentication /health will return 500 if they are not authenticated
for sources that poll (spotify, yt music, subsonic) /health will 500 if they are not polling

This is one of the best things! Thanks for this. I only suggest adding something to send a testmessage to test if the message is coming correctly, either by pressing "Ping gotify/ntfy" in webui, or via terminal docker exec -it multi-scrobbler pushgotify

adding something to send a testmessage

I'll think about it...you can already verify your notification servers are at least reachable by checking the logs at startup. MS attempts to contact the servers on known version/health endpoints and will log an error or success based on that.
2023-02-28T12:43:23-05:00 verbose: [Gotify - Config 0] Initialized. Found Server version 2.2.4
2023-02-28T12:43:23-05:00 info   : [Ntfy - Config 1  ] Initialized. Found Ntfy server

2023-02-28T12:45:29-05:00 error  : [Gotify - Config 0] Failed to contact server | Error: connect ECONNREFUSED <IP_ADDRESS>:8076
2023-02-28T12:45:32-05:00 error  : [Ntfy - Config 1  ] Failed to contact Ntfy server | Error: connect EHOSTUNREACH <IP_ADDRESS>:9991

Will also think on filtering notification types.


Add LICENSE

I noticed this was a dependency of bdwyertech/go-get-proxied, which seems like the most up-to-date fork of rapid7/go-get-proxied. Would you be open to adding a permissive license to this repo? Would love to use this.

Sure, sounds like you're more knowledgeable than I in this regard.  Typically I just pick MIT.  Any suggestions?  Open to a merge request.

MIT works great, I made a PR for your convenience: https://github.com/bdwyertech/go-scutil/pull/2

Thanks!


Added Icon directive

Added a new directive for icons - ""
Attributes

sm-font-icon : specify the font icon class.
sm-icon-size : size of the icon. (in px / em)

Please review.

@m0t0r  Please review.

To me, this is not ready to be merged. @peek4y I mentioned before that we should do changes in a unrelated modules in a separate PRs. I still see changes on the button directive when your PR is about Icon directive

@m0t0r  How can I remove those unwanted commits?

I'll start off fresh.


Win 10 - ver 10.0.17763.771 - Fully supported - RDPcheck works but mstsc doesn't work

As in the title, everything looked fine until i try to connect with mstsc.exe ( tried with localhost / <IP_ADDRESS> / <IP_ADDRESS> ) . I can connect with rdpchecker no problem however.

here's my rdpconf

I can have multiple RDP sessions but I can't open rdp sessions from within the main rdp session ( like RDPCheck.exe does )

im having this problem as well

I installed hamachi on the server routes the connection that way, it's a temp fix... waiting for input:)

look at #945

I updated my rdpwrap.ini file like mentionned but I get the same error message
rdpwrap.zip

Ya, its strange it only affects external IP addresses, not the local ones, thats why hamachi works. Its been working good with hamachi, but I've spent 8hrs plus using different config files and termsrv.dll trying to correct the problem. I even ran some windows updates and sfc /scannow

Installing hamachi makes you able to run mstsc <IP_ADDRESS> ?

thats right, its like a vpn network adapter. its been around for a long time, we've been up and running with that.

How do you make it work with hamachi ? Trying to figure out but i'm quite the newbie

you need to download it onto both machines, when you install it on the windows 10 machine, create a network, then on your client machine install hamachi there and join the network you created https://hamachi.en.softonic.com/


Create getting-started-with-ads

Added Getting Started with Ads. Please confirm that the group name is correct! ; )
Description of the change:
Reason for the change:
Link to original source:

Closes #

Hello @negarzipan,Thanks again for the PR! We appreciate your contribution and look forward to                                              continued collaboration. Thanks!                                             Team SendGrid DX


Test added sep12

Added Following Scripts
Test_TC_BIND_2_1.yaml
Test_TC_BIND_2_2.yaml
Test_TC_BIND_2_3.yaml
Test_TC_CADMIN_1_12.yaml
Test_TC_DRLK_2_10.yaml
Test_TC_G_2_2.yaml
Test_TC_G_2_3.yaml
Test_TC_G_3_2.yaml
Test_TC_MOD_3_4.yaml
Test_TC_OO_3_1.yaml
Test_TC_OO_3_2.yaml
Test_TC_PCC_3_1.yaml
Test_TC_PS_3_1.yaml
Test_TC_SC_4_8.yaml
Test_TC_SU_2_3.yaml
Test_TC_SU_2_5.yaml
Test_TC_SU_4_2.yaml
Test_TC_SWTCH_3_2.yaml
Test_TC_ACT_1_1.yaml
Test_TC_CHANNEL_1_6.yaml
Test_TC_DGETH_1_1.yaml
Test_TC_DGGEN_1_1.yaml
Test_TC_DGSW_1_1.yaml
Test_TC_DGSW_2_3.yaml
Test_TC_DGWIFI_2_3.yaml
Test_TC_FLW_2_2.yaml
Test_TC_G_1_1.yaml
Test_TC_I_2_2.yaml
Test_TC_KEYPADINPUT_3_2.yaml
Test_TC_LUNIT_1_2.yaml
Test_TC_LVL_1_1.yaml
Test_TC_LVL_2_1.yaml
Test_TC_LVL_4_1.yaml
Test_TC_ULABEL_2_4.yaml
https://github.com/CHIP-Specifications/chip-test-scripts/issues/457

@kowsisoundhar12 @cjandhyala - I think some of these things could be easier to review and manage if we would have individual updates for tests. Weekly drops are quite large.

@andy31415 We will follow that process after SVE-2 is done. For all the automated/semi-automated test cases we have individual tickets tracking the changes , but for the manual verification step updates we do not and hopefully after SVE-2 event is done , we wouldn't use that spreadsheet anymore and it would be easier to track. Hope that makes sense.


Remove torch<=1.4.0 checks

What does this PR do?
Removes torch <= 1.4.0 checks. 1.4.0 is our minimum supported version
Before submitting

[n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[n/a] Did you make sure to update the documentation with your changes? (if necessary)
[n/a] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca mind rebase on master regarding updated TPU configuration?


Geometries with EPSG:25832 are not displayed correctly in the map panel

System information:

Operating system (distribution) and version

Win10 64-bit

DBeaver version

6.0.4

Java version

java version "1.8.0_77"

Additional extensions

Connection specification:

Database name and version

Driver name

postgresql-42.2.5.jar
postgis-jdbc-2.2.1.jar

Do you use tunnels or proxies (SSH, SOCKS, etc)?

SSH-Tunnel

Describe the problem you're observing:
I'm working with wbk_geometry having a UTM-Projection. EPSG-Code is: 25832.
When I select a geometry of a table or query the point or polygon is displayed but iin a wrong location. The geometry is actually always displayed at the northern border of the worldmap.
The map-setting is done to EPSG:25832, i.e. it should fit.
Steps to reproduce, if exist:
Use a geometry with EPSG:25832 and display it in the map panel. Maybe the error is also true for all geometrys which differ from 4326 but I cannot check this currently.
Include any warning/errors/backtraces from the logs

No entries in the logfile

Sorry for double-posting the images!

Please post some geometry examples in 25832.
Something like
SELECT 1,'SRID=25832;POINT(-73.985744 40.748549)'::geometry

First of all, THX for taking it up!
Here is a result of, i.e. the qurey returning the geometry in EPSG:25832:
select 1, wkb_geometry from _schema.table_ limit 1;

?column?
wkb_geometry

   1|POINT<PHONE_NUMBER>168.729)|

And the same query but this time returning the geometry in 4326:
select 1, st_transform(wkb_geometry, 4326) from _schema.table_ limit 1;

?column?
st_transform

   1|POINT (7.021164038493922 50.78846803756188)|

Here the selected point is displayed correctly on the map.

Well, it transforms/renders fine on the latest versions:

You can download Early Access from https://dbeaver.io/files/ea

Great, works like a charm! That's really the killer feature for me with Dbeaver.

All done in the latest version 6.0.5, works perfectly!


[RTE] Storybook update

What

Updated storyboook v8 and v6

Why

How Tested

Process & policy checklist

[ ] I have updated the project documentation to reflect my changes if necessary.
[ ] I have read the CONTRIBUTING documentation.

Is this a breaking change?

[ ] This change causes current functionality to break.

Code wise the changes look good, but i wonder if for the advanced section should belong on the message thread page. No other item really calls out like this, I feel like it maybe more fitting under examples or concepts. Something to discuss as a feature crew

@JoshuaLai, thanks for the review! There is Basic Usage: Default Attachment Rendering and Advanced Usage: Customizing Attachment Rendering on MessageThread pages

I can move RTE Basic and Advanced usage to different sections for MessageThread page (with  different titles) if it's a prefference

Code wise the changes look good, but i wonder if for the advanced section should belong on the message thread page. No other item really calls out like this, I feel like it maybe more fitting under examples or concepts. Something to discuss as a feature crew

@JoshuaLai, thanks for the review! There is Basic Usage: Default Attachment Rendering and Advanced Usage: Customizing Attachment Rendering on MessageThread pages
I can move RTE Basic and Advanced usage to different sections for MessageThread page (with different titles) if it's a prefference

Will merge this PR but continue to work with Josh to resolve this


Add Post With Google Api to Blogger With Service account keys

I'm trying to create php script that post article to Blogger using Google API. I'm using library google/apiclient:^2.0. I'm choosing to use service account keys. Here's my codes:
require_once '../../vendor/autoload.php';

try {
    putenv('GOOGLE_APPLICATION_CREDENTIALS=' . __DIR__ . '/../../credentials/BeMine92929929.json');
    $client = new Google_Client();
    $client->setApplicationName('Be Mine');
    $client->useApplicationDefaultCredentials();
    $client->addScope(Google_Service_Blogger::BLOGGER);
    $token = $client->fetchAccessTokenWithAssertion();
    $client->setAccessToken($token);
    // I dump $token here, and it's available. token generation is success.

    $service = new Google_Service_Blogger($client);
    $blog = $service->blogs->getByUrl('http://bemine.blogspot.com');

    //this is part for sending post into blogger, which is getting
    //error
    $post = new Google_Service_Blogger_Post();
    $post->setTitle('Coba Post Artikel Kedua');
    $post->setContent('Artikel kedua ini dikirim melalui layanan Blogger api.');
    $service->posts->insert('Here Is My Blog ID', $post);

    //If I comment posting part, and try to get list article of
    //my blog, It success.
    $posts = $service->posts->listPosts($blog->getId());
    //file_put_contents('/tmp/anarky.txt', var_export($posts, true));
} catch (\Exception $ex) {
    echo $ex->getMessage();
}

The response when I try to post article :
{
 "error": {
  "errors": [
   {
    "domain": "global",
    "reason": "forbidden",
    "message": "We're sorry, but you don't have permission to access this resource."
   }
  ],
  "code": 403,
  "message": "We're sorry, but you don't have permission to access this resource."
 }
}

What do I miss Need your advise, thank you.

It's impossible for now to Post data to Blogger using service account. I get success with Aouth method. I'll close this question. Thank you.

how can i do it now?

Yes its impossible to do it using service accounts..... Although now  we can easily manage te blogger data by the Auth2


paw prints is missing the unicode symbol

When using "paw_prints" the Unicode symbol is missing but when using "feet" the alternative name for "paw_prints" the Unicode symbol is present. After using both of them I now have two of the same Emoji for paw prints because "paw_prints" and "feet" don't seem to be aliased as one single Emoji.

Thanks, I added the unicode symbol. Aliasing could indeed be much better, but it's such a simple extension...

@johannhof thanks for the quick fix!


Visual Studio Code Snippets

Description
Add Visual Studio Code snippets file and updated the readme to document it.
Where should the reviewer start?
Readme.md file
Fixes issue: none

Can't wait to try them.
Just want to keep those as simple as possible so it does not look overly complex.


SMS automation

Description
Script to send SMS to multiple people
Fixes #279
Replace issue_no with the issue number which is fixed in this PR
Have you read the Contributing Guidelines on Pull Requests?
Yes

@santushtisharma10 please review it

@Amit366 your script is working, but there are certain runtime error that a user can run into like here user can send messages to only those number which are verified on their twilio account, geo permission error . So either add comments in your code or add in your readme file , telling user that before sending messages,the number to which they want to send message must be verified on their twilio account and also to enable geo permissions.

@santushtisharma10 done.

@Kushal997-das

@kaustubhgupta I too have exhausted the credits😅😅

It is already been reviewed by one of the mentors.

@antrikshmisri


build(all): update TypeScript, TypeDoc, and Styled Components

Check https://deploy-preview-576--feature-hub.netlify.com/@feature-hub/
closes #601

@clebert The re-exports are now gone thanks to typedoc-plugin-remove-references.


The "plus" and "minus" signs are displayed as dots.

Submit feature requests to http://www.mattermost.org/feature-requests/. File non-security related bugs here in the following format:
Summary
The "plus" and "minus" signs are displayed as dots.
Environment Information

Device Name: Asus K56CM
OS Version: Windows 10
Mattermost App Version: 4.3.0
Mattermost Server Version: empty

AND

Device Name: Samsung Galaxy S6 (SM-G920F)
OS Version: Android v.7.0
Mattermost App Version: 1.4.0 (installation 63)
Mattermost Server Version: 4.3.0

Steps to reproduce
Write on both devices the three options that I wrote below:

"+" or "-"
"+" or "-" and any word with a space after the character
"+" or "-" and any word without a space after the character

Expected behavior
When coming to work, employees in the room "presents" should put "+" when they came to work, and "-" when they left work. And when I write these symbols, in different forms that I wrote above, instead of them the points are displayed. This problem is observed both on "Windows" and on "IOS" on computers and laptops, and on smartphones, as on "Android" and "IOS."
Screenshots I will attach, which I did on the computer and on the smartphone.
Observed behavior

P.S.
Sorry if I wrote with errors, my level of knowledge of English is small, I use an interpreter. Thank you for your responsiveness.
<EMAIL_ADDRESS>or<EMAIL_ADDRESS>

Hi @TheHunterSem,
That may look like a bug, but it is actually correct when using Markdown because it is trying to turn those into items in a list. The same thing happens when you use a plus or minus sign in GitHub like
+

-

Going to close this issue since it's expected behaviour for markdown, @TheHunterSem - if you think the behaviour should be changed to not support list bullet points or to use another character for them, you can submit a feature request here: https://mattermost.uservoice.com


Navigation

It is possible to insert new elements in navigation?

Yes, it should work from backend, only user with role ROLE_ADMIN could do that

is only editable not make now element


Update birthdate un-borker to update directly in the DB

What's this PR do?
Updates the birthdate un-borker to update date-like strings to actual dates directly in the database (we have to do it this way due to a bug in the mongo package we use, PR on that front coming soon).
How should this be reviewed?
Question about exception catching: @DFurnes and I talked about only catching the specific exception thrown when calling Carbon::parse($value) on a $value that can't be converted to a date. We only want to catch the specific exception thrown because if we catch one, we will unset birthdate on that user. However, the exception thrown in that case is of class Exception, so it seems like we have to catch that?
Relevant Tickets
Card
Checklist

[ ] Documentation added for changed endpoints.
[ ] Tests added for new features/bug fixes.
[ ] Post a message in #api if this includes something that causes a rebuild!

We only want to catch the specific exception thrown because if we catch one, we will unset birthdate on that user. However, the exception thrown in that case is of class Exception, so it seems like we have to catch that?

Darn it, PHP! 😞


Does not take into account CONDA_BUILD_SYSROOT

Hi,
On MacOS:
This package contains bin/clang with -fopenmp support. When I try to use this clang, it does not find the standard headers that I have in /opt/MacOSX10.9.sdk. As instructed by https://conda.io/docs/user-guide/tasks/build-packages/compiler-tools.html is set CONDA_BUILD_PREFIX in conda_build_config.yaml. However, the only acitvate.d script that takes this into account is in one of the clang_osx-64 packages.
What is the correct way to get this working?
How come the travis build script are working? If I try to reproduce them, step by step on my Mac, they fail.
Please redirect or advice,
Cheers,
Tom

Could you please include a minimal example of what you are trying to do and environment details? Thanks.

Ok. let me try this:

install latest conda + openmp from conda-forge:

$ bash ./Miniconda3-latest-MacOSX-x86_64.sh -b -p $PWD/miniconda
$ conda create -p openmp-test -c conda-forge
$ source activate $PWD/openmp-test
$ conda install -c conda-forge openmp
$ which clang # gives you $PWD/openmp-test/bin/clang from openmp package
$ echo '#include <stdio.h>' >test.c

Simple test that fails:
$ clang -c test.c
gives

test.c:1:10: fatal error: 'stdio.h' file not found
#include <stdio.h>
         ^~~~~~~~~

This works fine:

$ clang -isysroot /opt/MacOSX10.9.sdk  -c test.c

Clang search path:

$ clang -E - -v < /dev/null
clang version 5.0.0 (tags/RELEASE_500/final)
Target: x86_64-apple-darwin17.2.0
Thread model: posix
InstalledDir: /Users/vanderaa/tmp/openmp-test/bin
 "/Users/vanderaa/tmp/openmp-test/bin/clang-5.0" -cc1 -triple x86_64-apple-macosx10.13.0 -Wdeprecated-objc-isa-usage -Werror=deprecated-objc-isa-usage -E -disable-free -disable-llvm-verifier -discard-value-names -main-file-name - -mrelocation-model pic -pic-level 2 -mthread-model posix -mdisable-fp-elim -masm-verbose -munwind-tables -target-cpu penryn -target-linker-version 242.2 -v -dwarf-column-info -debugger-tuning=lldb -resource-dir /Users/vanderaa/tmp/openmp-test/lib/clang/5.0.0 -fdebug-compilation-dir /Users/vanderaa/tmp -ferror-limit 19 -fmessage-length 131 -stack-protector 1 -fblocks -fobjc-runtime=macosx-10.13.0 -fencode-extended-block-signature -fmax-type-align=16 -fdiagnostics-show-option -o - -x c -
clang -cc1 version 5.0.0 based upon LLVM 5.0.0 default target x86_64-apple-darwin17.2.0
ignoring nonexistent directory "/usr/include"
#include "..." search starts here:
#include <...> search starts here:
 /usr/local/include
 /Users/vanderaa/tmp/openmp-test/lib/clang/5.0.0/include
 /System/Library/Frameworks (framework directory)
 /Library/Frameworks (framework directory)
End of search list.
# 1 "<stdin>"
# 1 "<built-in>" 1
# 1 "<built-in>" 3
# 340 "<built-in>" 3
# 1 "<command line>" 1
# 1 "<built-in>" 2
# 1 "<stdin>" 2

xcode clang search path:

$ /usr/bin/clang -E -v - </dev/null
Apple LLVM version 9.0.0 (clang-900.0.38)
Target: x86_64-apple-darwin17.2.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
 "/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang" -cc1 -triple x86_64-apple-macosx10.13.0 -Wdeprecated-objc-isa-usage -Werror=deprecated-objc-isa-usage -E -disable-free -disable-llvm-verifier -discard-value-names -main-file-name - -mrelocation-model pic -pic-level 2 -mthread-model posix -mdisable-fp-elim -fno-strict-return -masm-verbose -munwind-tables -target-cpu penryn -target-linker-version 302.3.1 -v -dwarf-column-info -debugger-tuning=lldb -resource-dir /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/9.0.0 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk -I/usr/local/include -fdebug-compilation-dir /Users/vanderaa -ferror-limit 19 -fmessage-length 131 -stack-protector 1 -fblocks -fobjc-runtime=macosx-10.13.0 -fencode-extended-block-signature -fmax-type-align=16 -fdiagnostics-show-option -fcolor-diagnostics -o - -x c -
clang -cc1 version 9.0.0 (clang-900.0.38) default target x86_64-apple-darwin17.2.0
ignoring nonexistent directory "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/local/include"
ignoring nonexistent directory "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/Library/Frameworks"
#include "..." search starts here:
#include <...> search starts here:
 /usr/local/include
 /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/9.0.0/include
 /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include
 /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include
 /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks (framework directory)
End of search list.
# 1 "<stdin>"
# 1 "<built-in>" 1
# 1 "<built-in>" 3
# 331 "<built-in>" 3
# 1 "<command line>" 1
# 1 "<built-in>" 2
# 1 "<stdin>" 2

MacOs 10.13.1

conda info:

(/Users/vanderaa/tmp/openmp-test) [vanderaa:~/tmp]$ conda info
Current conda install:

               platform : osx-64
          conda version : 4.3.30
       conda is private : False
      conda-env version : 4.3.30
    conda-build version : 3.0.28
         python version : 3.6.3.final.0
       requests version : 2.18.4
       root environment : /Users/vanderaa/miniconda3  (writable)
    default environment : /Users/vanderaa/tmp/openmp-test
       envs directories : /Users/vanderaa/miniconda3/envs
                          /Users/vanderaa/.conda/envs
          package cache : /Users/vanderaa/miniconda3/pkgs
                          /Users/vanderaa/.conda/pkgs
           channel URLs : https://repo.continuum.io/pkgs/main/osx-64
                          https://repo.continuum.io/pkgs/main/noarch
                          https://repo.continuum.io/pkgs/free/osx-64
                          https://repo.continuum.io/pkgs/free/noarch
                          https://repo.continuum.io/pkgs/r/osx-64
                          https://repo.continuum.io/pkgs/r/noarch
                          https://repo.continuum.io/pkgs/pro/osx-64
                          https://repo.continuum.io/pkgs/pro/noarch
            config file : /Users/vanderaa/.condarc
             netrc file : None
           offline mode : False
             user-agent : conda/4.3.30 requests/2.18.4 CPython/3.6.3 Darwin/17.2.0 OSX/10.13.1
                UID:GID : 501:20

conda list:

(/Users/vanderaa/tmp/openmp-test) [vanderaa:~/tmp]$ conda list
# packages in environment at /Users/vanderaa/tmp/openmp-test:
#
clangdev                  5.0.0                 default_0    conda-forge
icu                       58.1                          1    conda-forge
libiconv                  1.14                          4    conda-forge
libxml2                   2.9.5                         1    conda-forge
llvmdev                   5.0.0                 default_0    conda-forge
openmp                    5.0.0                         0    conda-forge
xz                        5.2.3                         0    conda-forge
zlib                      1.2.11                        0    conda-forge

So it looks like you are mixing conda-forge’s clang and system clang. However this will only work with conda-forge’s clang.

Hi,
What's the name of the package I should install? I get the same error when I install clangdev from conda-forge.  Can you give me a few simple commands to test this?
Thanks,
Tom

What I mean is using /usr/bin/clang is problematic. If you just write clang, it will pick up the copy of clang from clangdev, which should be fine. If it's not, that would be good to know.

The clang from the clang-dev conda-forge package does not work on my MacOS 10.13.0 because it has been compiled against the MacOS 10.9 SDK (see e.g. https://github.com/conda-forge/toolchain-feedstock/issues/7, or by looking at the Travis Config, https://travis-ci.org/conda-forge/openmp-feedstock/jobs/298942008/config).
The clang from Continuum does work because it sets the build prefix.

Why is the SDK it is built against a problem?

Because the conda-forge compilers do not ship with system headers (stdio.h and others). They use the SDK system headers. Those are not in any standard place (like /usr/include on linux) on MacOS X.

Have you tried installing libcxx? From what I recall llvm (and conda-forge packaging) splits out the packages so that libc++ is actually a separate package from llvm and clang.

Going to close as there has been no more activity (possibly resolved?). Happy to reopen if that is not the case.


Change CI names to match crate names

Which issue does this PR close?
RE https://github.com/apache/arrow-rs/issues/2149
Rationale for this change
OCD making the names of the CI jobs easier to match with the code they test
What changes are included in this PR?
Change CI names to match crates

Codecov Report

Merging #2189 (59f4e51) into master (d10d962) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2189      +/-   ##
==========================================
- Coverage   82.60%   82.60%   -0.01%
==========================================
  Files         239      239
  Lines       62244    62244
==========================================
- Hits        51417    51414       -3
- Misses      10827    10830       +3

Impacted Files
Coverage Δ

...rquet/src/arrow/record_reader/definition_levels.rs
88.60% <0.00%> (-0.43%)
:arrow_down:

parquet_derive/src/parquet_field.rs
65.75% <0.00%> (-0.23%)
:arrow_down:

parquet/src/encodings/encoding.rs
93.43% <0.00%> (-0.20%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us.


Update Korean translation

Translation update for new strings!
(commit f35b9ca... is mistake)

Thank you. Merged.
Something went wrong and this PR is not marked "merged", but your code was actually committed to master (https://github.com/iorate/uBlacklist/commit/166c3cee77d1c0b99440864d2876349c33b7c4ca).


Tensor parallel support for multi GPU

Hello, I'm not sure if multi GPU is supported yet. I didn't find parameters for tensor parallel, and the "num_device_layers" parameter seems not work. Please let me know if it supports or has plans to support multi GPU. Thanks for your awesome work!

Hi @ilookee! Cross GPU device mapping is supported. Each element follows the format ORD:NUM where ORD is the device ordinal and NUM is the corresponding number of layers and delimited by commas.
What we do not support yet is true multi GPU inference. This would be done with something like nccl and we do have plans to implement this.

@oldgithubman is this what you had in mind?

Hi @ilookee! Cross GPU device mapping is supported. Each element follows the format ORD:NUM where ORD is the device ordinal and NUM is the corresponding number of layers and delimited by commas.
What we do not support yet is true multi GPU inference. This would be done with something like nccl and we do have plans to implement this.

Does this mean that I can't load a 70B across multiple 3090s and use it for inferencing?

Hey @murtaza-nasir! You can absolutely do this, just use the format ORDINAL:NLAYERS,...
Please let me know I can provide any help.

Thank you for your quick response! I'm trying to figure out how to use all the various model files I have with mistral.rs. I can't find any examples of loading large models with different arguments. Can you give me an example of how I can load a model /home/user/work/ml/models/meta-llama_Meta-Llama-3.1-70B-Instruct with ISQ across four 3090 GPUs?
 I'm trying to follow the instructions to start a server. After succesfully installing from source, I run:
./mistralrs_server -i plain -m /home/user/work/ml/models/Meta-Llama-3.1-8B-Instruct-Q6_K.gguf -a llama

But I get:
-bash: ./mistralrs_server: No such file or directory

OK sorry I got it to work, but now I can't figure out how to specify the GPUs? Can't find documentation on what argument sets this.
mistralrs-server --chat-template /home/user/work/ml/mistral.rs/chat_templates/llama3.json gguf  -m /home/user/work/ml/models/ -f Meta-Llama-3.1-70B-Instruct.Q5_K_S.gguf -a llama

@oldgithubman @murtaza-nasir
The following should work:
mistralrs-server --chat-template /home/murtaza/work/ml/mistral.rs/chat_templates/llama3.json -n "0:20;1:20;2:20;3:20" gguf -m /home/murtaza/work/ml/text-generation-webui/models/ -f Meta-Llama-3.1-70B-Instruct.Q5_K_S.gguf

Notice how the -n goes before gguf, instead of after. You can see this if you run mistralrs-server --help.


Get rid of the remains of heavy debug

JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély<EMAIL_ADDRESS>

LGTM

LGTM

@akiss77 Good point, I've updated the patch. Thanks!

LGTM


Use single-assignment variables for intermediate values needed in JS output for decorated classes

🔍 Search Terms
decorators reassigned inlining
✅ Viability Checklist

[X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[X] This wouldn't change the runtime behavior of existing JavaScript code
[X] This could be implemented without emitting different JS based on the types of the expressions
[X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[X] This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals

⭐ Suggestion
The key problem is that what was in the TS code simply class Foo { /* decorators used here */ } becomes something like this
var Foo_1;
let Foo = Foo_1 = class Foo {
  /* all references to Foo replaced with Foo_1 here */
};

Foo.staticProp = someValue;

// Second value assigned to Foo and Foo_1 after earlier references to them
// make it hard for a minimization tool to reason about these values.
Foo = Foo_1 = __decorate(...);

This is a problem for closure-compiler because logically Foo and Foo_1 could be treated as a constant after this point, but that's hard for the compiler to prove to itself because multiple assignments to these variables are made, and some references to them come before or between assignments.
If instead TS introduced temporary variables for the intermediate values and then assigned only the final result to the "real" variables from the original TS code which are used by all clients of the class, this would be a lot easier for closure-compiler and other tools to safely reason about.
For example:
var Foo;
let Foo_predecoration_1 = class {
  /* all references to Foo unchanged here */
};

Foo_predecoration_1.staticProp = someValue;

// Second value assigned to Foo and Foo_1 after earlier references to them
// make it hard for a minimization tool to reason about these values.
Foo = __decorate(...);

NOTE: This request seems to me very much in line with these stated TS design goals

Emit clean, idiomatic, recognizable JavaScript code.
Produce a language that is composable and easy to reason about.

📃 Motivating Example

This changed between versions 5.1 and 5.2

When decorators are used, variables that are assigned exactly once in the TS code end up getting multiple assignments, which makes optimization of the code by closure-compiler and probably other minimizers difficult.
This was true in 5.1, but got worse in 5.2 because it began replacing internal references to a class name with an alias variable.
TS 5.1: https://www.typescriptlang.org/play?experimentalDecorators=true&emitDecoratorMetadata=true&target=6&module=1&ts=5.1.6#code/KYDwDg9gTgLgBAbwL4G4BQaBmBXAdgYxgEsJc5cIIwARYfaAQxmgAoA6DhqAcwGcAuOA1wBPANoBdAJSIkGfABsGvXnABilRGjhxeMJkXxwAktTgBeOAHJoRbkVwMFV9Dr0GjpgEwX1lNqbo2rr6xEaYlCwyCME69Li8EArAbAoQ3CxWABLACmlWUq5wcsHxelDYhKwAAhRUtPRQTNBwYFBEAG5MwHBQwAwAJqQKInADdAAKUFSCuNgAtgBGwFC+AKzRJTqLXFFaOjoaEGwREFFFcaSJyanpmaaCVnAA1H7Hpi-WBUVyJbjAAHc3lE2DsoOc0EA
TS 5.2: https://www.typescriptlang.org/play?experimentalDecorators=true&emitDecoratorMetadata=true&target=6&module=1&ts=5.2.2#code/KYDwDg9gTgLgBAbwL4G4BQaBmBXAdgYxgEsJc5cIIwARYfaAQxmgAoA6DhqAcwGcAuOA1wBPANoBdAJSIkGfABsGvXnABilRGjhxeMJkXxwAktTgBeOAHJoRbkVwMFV9Dr0GjpgEwX1lNqbo2rr6xEaYlCwyCME69Li8EArAbAoQ3CxWABLACmlWUq5wcsHxelDYhKwAAhRUtPRQTNBwYFBEAG5MwHBQwAwAJqQKInADdAAKUFSCuNgAtgBGwFC+AKzRJTqLXFFaOjoaEGwREFFFcaSJyanpmaaCVnAA1H7Hpi-WBUVyJbjAAHc3lE2DsoOc0EA
💻 Use Cases

What do you want to use this for?
The change suggested here would enable better code minimization for closure-compiler and likely other JS-minimization tools.

What shortcomings exist with current approaches?
The multiple assignments prevent inlining of variable values and recognition of some values that should be safe to remove.

What workarounds are you using in the meantime?
No workaround exists now. We might try to specifically recognize this pattern as one generated by TS compiler and then make assumptions about the values being assigned, but that's more brittle than we'd like.

Related: #55560

NOTE: It would be a big help even if the only change were to make sure the "real" name (from TS) only gets assigned once. I realize there may be some cases where the class methods somehow end up executing before decoration is complete, and so need a live reference to the not-yet-decorated class.


Cope with diplomat behavior if acl does not exist

Diplomat gem currently return an empty array if the acl does not exist.
This patch will allow to handle this behavior.

Current coverage is 49.34%

Merging #279 into master will increase coverage by +0.13% as of 621e8b9

@@            master    #279   diff @@
======================================
  Files            7       7
  Stmts          380     381     +1
  Branches         0       0
  Methods          0       0
======================================
+ Hit            187     188     +1
  Partial          0       0
  Missed         193     193

Review entire Coverage Diff as of 621e8b9

Powered by Codecov. Updated on successful CI builds.

duplicate of #278


Ctrl+A does not select file content

Type: Bug

Open a source file, or text file
put cursor in any place in the text
Press Ctrl+A to "select all"

It does not select the text, and shows at the footer "Wainting second key of chord..."
  It may have been added by an extension.
Run the Developer: Toggle Keyboard Shortcuts Troubleshooting to investigate.  Or, in the Keyboard Shortcuts editor, enable the Record Keys icon to the right and type Ctrl+A and see if there is a command that starts with Ctrl+A but has more keys that it is waiting for.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


provide system prompt customization and enhance prompt

Enable users to customize system prompt
no need to expose tabTitle and tabURL to end user
Improve the prompt for performance on small LLM

need more test

small LLM pay less attention to system prompt, the classification task description needs to be in the user prompt.

now this branch should be good to merge


Typing says pd.DataFrame has nonexistent property to_list

Describe the bug
Typing stubs indicate that pd.DataFrame has an attribute to_list when it does not.
To Reproduce

Provide a minimal runnable pandas example that is not properly checked by the stubs.

import pandas as pd

def f(x: pd.DataFrame) -> None:
    # reveal_type(x.to_list) # note: Revealed type is "pandas.core.series.Series[Any]"
    x.to_list  # just accessing the attribute

f(pd.DataFrame([1, 2, 3]))

Indicate which type checker you are using (mypy or  pyright).

mypy

Show the error message received from that type checker while checking your example.

The above passes the type checker but fails at runtime.
Please complete the following information:

OS: macOS
OS Version: 12.5.1
python version: 3.9.15
version of type checker: mypy 0.981
version of installed pandas-stubs: pandas-stubs==<IP_ADDRESS>024

You say it fails at runtime. Is that actually true? to_list is a method and I would expect the way you are accessing it to be perfectly fine (although it won't do anything of substance). The revealed type certainly isn't right.

This is expected behavior.
In order to support specifying a column name as an attribute, we translate any non-existent function to return a Series.
For example, the following code works:
df = pd.DataFrame({"to_list":[3,4,5]})
df.to_list

So the reason you get pandas.core.series.Series[Any]  as the revealed type is because it thinks that to_list is the name of a column.


Not able to load text column from sqlite as blob type

What language are you using?
Python
What version are you using?
0.3.1
What database are you using?
sqlite
What dataframe are you using?
N/A
Can you describe your bug?
Querying a sqlite db results in the following error:
>>> r = cx.read_sql("sqlite://test_data/sqlite_blob/sample.db", "SELECT * FROM oc")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/houqp/Envs/roapi/lib/python3.8/site-packages/connectorx/__init__.py", line 224, in read_sql
    result = _read_sql(
RuntimeError: Invalid column type Blob at index: 9, name: raw_metadata

What are the steps to reproduce the behavior?

Download sample db file: https://github.com/roapi/roapi/files/10502653/sample.db.zip
Try to load the db using cx.read_sql("sqlite://test_data/sqlite_blob/sample.db", "SELECT * FROM oc")

Example query / code
cx.read_sql("sqlite://test_data/sqlite_blob/sample.db", "SELECT * FROM oc")

What is the error?
RuntimeError: Invalid column type Blob at index: 9, name: raw_metadata

Hi @houqp , thanks for the sample data. Since sqlite adopts dynamic type system, there are two kind of types for its data: a declarative type (the one specified for a column when creating the table) and a data type (the true data value type), and these two types might not be able to matched.
The reason for the error is because we take the declarative type TEXT prior to data type BLOB. That is, when we fetch the metadata of each column's type, we first match its declarative type. If it is not defined (maybe because the data is computed from other columns) then we check on the data type itself. The reason we don't use data type directly is because we cannot infer data type if the data is NULL. Related logic can be found here.

Could we change the metadata at runtime instead when we detected the data type doesn't match with the declarative type?

Could we change the metadata at runtime instead when we detected the data type doesn't match with the declarative type?

It might require some work. Since in our current workflow we pre-allocate the final dataframe before really fetching any data. It may also introduce runtime error if there are type conflict.


[bug] make MFA works for CAS login

MFA is already working in natvie login and OAuth login: https://github.com/casdoor/casdoor/pulls?q=is%3Apr+is%3Aclosed+mfa
But CAS login is still not supported

@leo220yuyaodog


Does anyone know how to get XP and Challenges working?

I'm using the Reboot Launcher, Reload Backend and Reboot 3.0 game server...but when I try to do challenges ingame, they don't get registered as completed. So I can't level up the battlepass by doing challenges. Does anyone know how to fix it?

@Milxnor

Reboot gameserver currently does not support challenges.


PDN hangs with lots of small designs

Description
PDN hangs forever if a certain combination of designs and PDN spacing is used.

Logs
Last messages:
[WARNING PSM-0032] Node at (1571400, 2854575) and layer 5 moved from (1570520, 2655880).
[WARNING PSM-0032] Node at (1512000, 2854575) and layer 5 moved from (1510520, 2655880).
[WARNING PSM-0032] message limit reached, this message will no longer print
[INFO PSM-0064] Number of voltage sources = 88.

PDN 90 x 90 seems to work most of the time.

@mattvenn
As per commit e4bfdd7 its mpw-6b tag.
It had some issues and updated later in efabless to use mpw-6c I think.
Also the caravel_user_project points export OPENLANE_TAG=2022.02.23_02.50.41 https://github.com/efabless/caravel_user_project/blob/cd4f35df25e15f6cb35cd3bd777f8779566491e8/Makefile#L26
Its confusing which OpenLane git version used for mpw shuttle.
So updating document will be easy to trace the tool and possible to fix the issue.
I'm suggesting to update OpenLane and try it. With latest tag its not hanging, but getting different error:
[STEP 15]
[INFO]: Running Detailed Routing...
[ERROR]: during executing openroad script /openlane/scripts/openroad/droute.tcl
[ERROR]: Exit code: 1
[ERROR]: full log: designs/tapeout_100/runs/RUN_2022.06.29_10.54.43/logs/routing/15-detailed.log
[ERROR]: Last 10 lines:
Units:                1000
Number of layers:     13
Number of macros:     442
Number of vias:       25
Number of viarulegen: 25

[INFO DRT-0150] Reading design.
[ERROR DRT-0305] Net zero_ of signal type GROUND is not routable by TritonRoute. Move to special nets.
Error: droute.tcl, 46 DRT-0305

@mattvenn please package an issue tarball rather than require running OL as your reproducer.

tar all of caravel_user_project? or something else. The reason I'm not doing that is because with the submodules it's 8GB. Without the submodules it's much less, but then the person running the test has to install them.

I mean use or_issue.py.  I believe it is run automatically when the flow fails.  @donn can help if needed.

@maliberty
If flow hangs, they will kill it and it will generate issue_reproducible.
Best @mattvenn can use or_issue.py to produce testcase  for PDN stage. If any issues let me know, I will help on this.

@vijayank88 it doesn't get killed in a reasonable amount of time. How to generate the test case?

@mattvenn
problem with pdn stage right.
So add exit 1 in following line https://github.com/The-OpenROAD-Project/OpenLane/blob/83b61459abcaef3b0ddcf022e1a67e71c88f6007/scripts/openroad/pdn.tcl#L58 and run the flow. It will exit and generate testcase. After this run remove exit 1 from pdn.tcl and continue as it is. Attach the tar file here for test case.

it's hanging before that line, so it still never finishes

so:

start at the end and move the exit 1 backwards
wait 10 minutes
repeat until it exits
?

tbh I'm not likely to complete this process as I have a work around already.

@mattvenn
Without test case keep this issue open not helpful.

Use exit 1 before the line where it hangs

No, exit 1 at the start of the script is just fine. Where did you get this brilliant idea?

Use exit 1 before the line where it hangs

No, exit 1 at the start of the script is just fine. Where did you get this brilliant idea?

Copyrights goes to @antonblanchard

Gah. Okay, clearly, what I need to do here is add functionality to just package a specific script without the use of exit.

@donn
With latest OpenROAD commit i am not seeing any hanging problem.
Its discussed here. Maybe @maliberty you can take the PDN stage test from here: https://github.com/The-OpenROAD-Project/OpenLane/issues/1076#issuecomment-1126027261

I'll update OpenROAD and give it a shot then.

@vijayank88 if you see no problem then what are you asking me to do?

We've updated to the latest OpenROAD on master. Feel free to re-open if the problem persists.


fix(bootstrap): ignore exports fields when resolving presets (v13.x)

picks #1377

Bors merge bot cheat sheet
We are using bors-ng to automate merging of our pull requests. The following table provides a summary of commands that are available to reviewers (members of this repository with push access) and delegates (in case of bors delegate+ or bors delegate=[list]).

Syntax
Description

bors merge
Run the test suite and push to master if it passes. Short for "reviewed: looks good."

bors merge-
Cancel an r+, r=, merge, or merge=

bors try
Run the test suite without pushing to master.

bors try-
Cancel a try

bors delegate+
Allow the pull request author to merge their changes.

bors delegate=[list]
Allow the listed users to r+ this pull request's changes.

bors retry
Run the previous command a second time.

This is a short collection of opinionated commands. For a full list of the commands read the bors reference.

bors merge

bors retry

bors merge

bors merge

bors merge-

bors merge

bors merge-

Manually picked onto v13.x because ain't nobody got time for this!


LWJGL2 crashing on Ubuntu's JVM

According to @jayfella this the following error occurs starting 11.0.5 and lwjgl2 [on linux] :
Inconsistency detected by ld.so: dl-lookup.c: 111: check_match: Assertion `version->filename == NULL || ! _dl_name_match_p (version->filename, map)' failed!

That's the exact issue @grizeldi also had when trying out the new SDK Version locally.

 If we do the upgrade, I assume we'd do it for all the systems, right?

Yes, of course.
In fact, I might have done a fault in declaring this for "Linux". I was
lead to the conclusion as you tried that on linux and the error message
contains "dl",
where dlopen is the syscall on linux to load a dynamic linked library,
but after all this could only be the abstractional code from the JVM and
thus affect all platforms.
@jayfella actually complained even more about 11.0.5 leading to trouble
for him, so the easiest is a downgrade and then iron out lwjgl3 on the
engine and when all of this is done, a new LTS of Java is probably
already released.
Fun-Fact: Thanks to upgrading the source level, I can't even build the
SDK on my local machine anymore, as it's running KUbuntu 18.04 LTS with
Java 8 :D

Short info:
I've done quite some investigations upstream and it looks like the issue is a faulty libjawt.so from the Ubuntu distributed JDK.
Using AdoptOpenJDK or AdoptOpenJDK Upstream (i.e. the original OracleJDK built by Redhat) works and according to my digging it seems that even Debian's JDK still works, so you could swap out .so's or better install AdoptOpenJDK and adjust JAVA_HOME (which I also need to do anyway, as java 8 is still my default :D).
In theory the SDK Installer should use the bundled adoptopenjdk, but you never know if it prefers locally installed jdks first.

Closing this as it's tracked at the Engine and the SDK Installer come bundled with AdoptOpenJDK.
In case someone has this issue, comment here. Most likely the jmonkeyplatform.conf needs to be modified, which is our issue then.
Otherwise you can also change JAVA_HOME to point to the jdk subfolder of the installed SDK.
NOTE: The Platform Independent ZIP WILL show this behavior on Ubuntu and we don't "support" that. If you use that zip, take care of having an appropriate jdk linked.


Update wiz-smart-lights

Added recoloring other players purples in cox

You do not need to close and open new PRs. Just push to the repo and the bot will pick it up.


Change rimraf to del-cli

It looks like rimraf isn't well supported anymore.  Ran into some issues with it.  I switch it to del-cli which seems to be a more up-to-date package.  Also the shrinkwrap file I added last time looks like it was way wrong.  It had all of the dev dependencies in it.  Fixed that also.  Sorry for yet another PR.  All that said, the good news is that I installed it from my fork and ran some tests.  It looks like everything is working as expected!  Could you merge this and do an npm publish to rc.6?

rimraf  works well for me, and it's widely used. What problem are you encountering?

Yeah, I've used it before with no ill effect. Now that I think about it, it's probably more an issue with the shrinkwrap. I was getting an issue with a required opperating system mismatch error. Let me do some other testing on it with just the shrinkwrap changes and see if that's the root cause.

It was definitely the shrinkwrap that was the issue.  It's fixed now.  I put rimraf back in.  This commit now should just fix the shrinkwrap and update a few packages.  If you do a squash merge it will just add one commit (there should be a dropdown option for it).  If things look good could you do a publish for rc.6?

@evecalm Could you publish rc 6?  It should already be updated in the package.json

I've published rc.6. I'm busy for wok these day, sorry for that.

Thank you very much!  That's fine about the prebublishOnly.  Just something I was trying out.  I'll pull rc6 into my application and let you know how things go.

I've made a stable release of  v1.0.0,  also with some improvements. you may have a try 😄


RouteDefinition's assertion has performance issues

Describe the bug
路由的断言是一个List集合，每一次请求都会遍历这个路由断言List集合，在路由地址非常多（万个以上）的情况下，性能会比较慢。
我的测试环境有2000个RouteDefinition，每一次请求要遍历路由List集合，用时50ms。
建议提供ConcorrentHashMap来存储RouteDefinition，使用ConcorrentHashMap来匹配出RouteDefinition
From google translate

The routing assertion is a List collection. Each request will traverse this routing assertion List collection. In the case of very many routing addresses (more than 10,000), the performance will be slower.
My test environment has 2000 RouteDefinitions, and each request traverses the routing List collection, which takes 50ms.
It is recommended to provide ConcorrentHashMap to store RouteDefinition, and use ConcorrentHashMap to match out RouteDefinition

Sample
RouteDefinitionRouteLoactor.getRoutes(){......}

Duplicates #1683