No icon if initially fullscreen with GLFW_VISIBLE hint set to GLFW_FALSE

I think this issue started happening with the latest Windows 10 update. I've seen it happen in other app too. Not sure if GLFW needs to change anything, but leaving this just for future reference.

Set GLFW_VISIBLE hint to GLFW_FALSE
Create window
Set window monitor to some valid monitor
Show window
Set window monitor to NULL

You'll see that there is no icon near the window title. This works fine if not initially setting GLFW_VISIBLE hint to GLFW_FALSE.

Is it as if WS_SYSMENU is missing after leaving full screen?

Almost. Without WS_SYSMENU the minimize/maximize/close boxes are also absent.

Related problem that happens in boing on Windows 10 only when you start the app in fullscreen:
Start app in fullscreen:
GLFWmonitor* primaryMonitor = glfwGetPrimaryMonitor();
const GLFWvidmode* videoMode = glfwGetVideoMode(primaryMonitor);
window = glfwCreateWindow( videoMode->width, videoMode->height, "Boing (classic Amiga demo)", primaryMonitor, NULL );

and hardcode some window dims for key_callback:
void key_callback( GLFWwindow* window, int key, int scancode, int action, int mods )
{
    if (action != GLFW_PRESS)
        return;

    if (key == GLFW_KEY_ESCAPE && mods == 0)
        glfwSetWindowShouldClose(window, GLFW_TRUE);
    if ((key == GLFW_KEY_ENTER && mods == GLFW_MOD_ALT) ||
        (key == GLFW_KEY_F11 && mods == GLFW_MOD_ALT))
    {
        if (glfwGetWindowMonitor(window))
        {
            glfwSetWindowMonitor(window, NULL, 20, 20, 400, 400, 0);
        }
        else
        {
            GLFWmonitor* monitor = glfwGetPrimaryMonitor();
            if (monitor)
            {
                const GLFWvidmode* mode = glfwGetVideoMode(monitor);
                glfwSetWindowMonitor(window, monitor, 0, 0, mode->width, mode->height, mode->refreshRate);
            }
        }
    }
}

And voila! The title bar icon is gone.

I don't use GLFW but stumbled across this issue using WIN32 directly. One work-around I've found:

Create a hidden, non-fullscreen window.
"Cloak" the window using DWMWA_CLOAK.
"Show" the non-fullscreen window while cloaked.
Transition to fullscreen while cloaked.
Uncloak.

This way, the window started windowed then transitioned to fullscreen, but looks like it started fullscreen to the user.

I don't use GLFW but stumbled across this issue using WIN32 directly. One work-around I've found:

Create a hidden, non-fullscreen window.
"Cloak" the window using DWMWA_CLOAK.
"Show" the non-fullscreen window while cloaked.
Transition to fullscreen while cloaked.
Uncloak.

This way, the window started windowed then transitioned to fullscreen, but looks like it started fullscreen to the user.


update timeout when poll is retried due to interrupted syscalls

avoids extending timeout when interrupts arrive during timeout
closes #996

In the loop you take the current time, poll, measure how time has passed and reduce the timeout by that amount. This has some minor problems:

You take the time twice every loop causing an extra syscall per loop.
The time between the second measurement and the first of the next loop is not accounted for causing drift. If the kernel happens to schedule right there that could be a significant amount.
timer have a finite resolution causing a measurement error in each loop which add up and cause more drift.
It would be better to get the start time before the loop, preserve the original timeout and compute the next loops timeout as timeout - (now - start) even if that makes detecting clock shifts harder.


status in the logs for stateful set ready is off by one w.r.t to the pod ordinal

Describe the bug
Off by one...
from the controller log - status update:
.... {"ActiveMQArtemis Name": "ex-aao", "info:": {"ready":["ex-aao-ss-1"]}}
Ready Count........................        {"ActiveMQArtemis Name": "ex-aao", "info:": 1}
then get pods:
ex-aao-ss-0                                            1/1       Running   0          45m
I would expect the name to match.
I note that the address controller observer is aware of the off by one:
https://github.com/artemiscloud/activemq-artemis-operator/blob/main/controllers/address_observer.go#L57
A clear and concise description of what the bug is.
To Reproduce
deploy any trivial example with deployment size=1

this info is also what is pushed to the CR status:
status:
podStatus:
ready:
- ex-aao-ss-1
- ex-aao-ss-2


Plugin for namespace scenarios

We need a plugin that, on demand, deletes a namespace and checks for recovery. This plugin should provide two steps, one for deletion and one for timed recovery check. The deletion should be done based on the namespace name (regexp) and/or a label selector.

This kind of scenario was requested in chaos mesh as well (https://github.com/chaos-mesh/chaos-mesh/issues/2567) and I don't see the point of this scenario to be implemented.


Android Error: FacebookActivity could not be started

The plugin always throw this error. I tried to add the variables to the AndroidManifest inside the project or directly in the platforms/android/src/main/AndroidManifest, but this error keep showing
<meta-data android:name="com.facebook.sdk.ApplicationId" android:value="@string/facebook_app_id"/>
<activity android:name="com.facebook.FacebookActivity"
             android:configChanges="keyboard|keyboardHidden|screenLayout|screenSize|orientation"
             android:theme="@android:style/Theme.Translucent.NoTitleBar"
             android:label="@string/app_name"
             />

Hello Victor, Sorry for the delay I was away for holidays. The code you shared seams to be all good.
Do you have your facebook_app_id on the strings?
Is the code inside the aplication?
 <application android:name="com.tns.NativeScriptApplication....
  ....
....
</application>

Can you call the native android sdk?
console.log(com.facebook.FacebookSdk.sdkInitialize());
If all that is working/on place I think we will have to look at the Facebook sdk level for a solution to your problem.

Close due to inactivity


0 on mod items

0 on mod items

If you mean the price of the items then you can easily fix it in the window that appears when you host a game

If you mean the price of the items then you can easily fix it in the window that appears when you host a game

Getting the same issue, trying to default/fix the prices will just keep putting it at $0

Duplicate #58


where can I find the pre-trained model?

Hi,
I was wondering where I can download the models used in this repository like exp/se_models/22/52.nw_SE.raw?
Thanks!

Thanks for your interest.
I will look into the possibility of release of the model. Meanwhile, you may consult the following paper which explains it.
Feature Enhancement with Deep Feature Losses for Speaker Verification


Adopt flyway runner

Link to GitHub repository
https://github.com/jenkinsci/flyway-runner-plugin
FYI @pskumar448
I think the plugin is abandoned. Many essential PR were not merged: https://github.com/jenkinsci/flyway-runner-plugin/pulls.
I would like to deliver https://github.com/jenkinsci/flyway-runner-plugin/pull/23
When modifying release permission
If you are modifying the release permission of your plugin or component, fill out the following checklist:

### Release permission checklist (for submitters)
- [x] The usernames of the users added to the "developers" section in the .yml file are the same the users use to log in to [accounts.jenkins.io](https://accounts.jenkins.io/).
- [x] All users added have logged in to [Artifactory](https://repo.jenkins-ci.org/) and [Jira](https://issues.jenkins.io/) once.
- [x] I have mentioned an [existing team member](https://github.com/orgs/jenkinsci/teams) of the plugin or component team to approve this request.

When enabling automated releases (cd: true)
Follow the documentation to ensure, your pull request is set up properly. Don't merge it yet.
In case of changes requested by the hosting team, an open PR facilitates future reviews, without derailing work across multiple PRs.
Link to the PR enabling CD in your plugin

### CD checklist (for submitters)
- [ ] I have provided a link to the pull request in my plugin, which enables CD according to the documentation.

### Reviewer checklist
- [ ] Check that the `$pluginId Developers` team has `Admin` permissions while granting the access.
- [ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
- [ ] If security contacts are changed (this includes add/remove), ping the security officer (currently `@Wadeck`) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it.

Posted on dev list: https://groups.google.com/g/jenkinsci-dev/c/bilZTQfHZ8Q


feat(python, rust): add set table properties operation

Description

Adds set table properties operation
Some logic is shared for the create operation

Related Issue(s)

closes https://github.com/delta-io/delta-rs/issues/1663
fixes https://github.com/delta-io/delta-rs/issues/2247

Hi, does this PR allow for setting of custom metadata too? On table creation we're able to store custom metadata via the configuration parameter, so would be great if we could set custom metadata via this operation as well.

@echai58 that's the idea yes, you would be able to change the table configuration.

Any idea when this PR will be merged?


Add no_timestamps flag

Simple like that, based on the https://github.com/ggerganov/whisper.cpp options, I added an option to just return text.
Thanks

Awesome, needed that for a personal project. Good job!


Fix table heading in markdown generator

Thanks for the tip regarding the Markdown generator. I haven't had time to look at the tests yet. I will try to add Ecoji v2 to the PHP library this week or next.

I will try to add Ecoji v2 to the PHP library this week or next.

Ok that would be great.  Increases the chance of finding any major problems w/ V2 before its released.

I started working on it but need more time.
My feedback so far: I like the test script. However, I expect it to break when my custom commands contain spaces. The next thing doesn't look as problematic, but I would prefer that all variables are quoted.

I just discovered with the test cases that the results of my existing Ecoji v1 CLI implementation should not return a final linebreak when terminating. Since there are no wrapping test cases, is this also true when word-wrapping is enabled?

Some other remarks: Instead of passing environment variables, it would also be possible to pass a file to be loaded by the script. This file could then define three functions that are then executed by the test script to encode with Ecoji v1, v2 or decode.
ecoji_implementation="/home/ubuntu/wrapper-script" \
./ecoji_test.sh

The implementation is project specific and could look like this:
function ecoji_encode_v1 () {
  /home/ubuntu/bin/myEcoji -w 0
}

ecoji_test.sh would then "source" the implementation file, e.g.
source "$ecoji_implementation"

if which ecoji_encode_v1; then
  echo "Implementation does not specify ecoji_encode_v1"
  exit 1
fi

# …

	if ! diff <(cat "data/$bare_name.ev1") <(cat "$plain_file" | ecoji_encode_v1); then
		echo "ERROR : Encoding $plain_file using Ecojiv1 did not produce data/$bare_name.ev1"
	fi

I personally think it is a good idea to show the diff on mismatch.

I just discovered with the test cases that the results of my existing Ecoji v1 CLI implementation should not return a final linebreak when terminating. Since there are no wrapping test cases, is this also true when word-wrapping is enabled?

When word wrapping is enabled I would expect a final new line.  Without word wrapping I would not expect a final new line, like below where the shell prompt shows up after because there is no new line.
$ echo "ubuntu" | go run cmd/ecoji/main.go -e
💦📹🐬🪅💥🍨☕
$ echo "ubuntu" | go run cmd/ecoji/main.go -e -w 0
💦📹🐬🪅💥🍨☕$

I personally think it is a good idea to show the diff on mismatch.

Wondering if that would be too noisy and hard to interpret w/ multiple failures.  Maybe if there is a diff it could output a file w/ a name like "encode_$bare_name.ev1.diff"?

Some other remarks: Instead of passing environment variables, it would also be possible to pass a file to be loaded by the script.

I like that idea.  Could give $ecoji_implementation a default value in the script that points to example file in the test dir.  Then someone could just edit that file and run the test script.

When word wrapping is enabled I would expect a final new line. Without word wrapping I would not expect a final new line, like below where the shell prompt shows up after because there is no new line.

:+1:

Wondering if that would be too noisy and hard to interpret w/ multiple failures. Maybe if there is a diff it could output a file w/ a name like "encode_$bare_name.ev1.diff"?

In case of failure, I'm usually interested to see all details at once. In my experience, unit testing frameworks show either the first error and halt, or show all errors at once.

In case of failure, I'm usually interested to see all details at once. In my experience, unit testing frameworks show either the first error and halt, or show all errors at once.

Seeing it all at once does make it faster and less hassle to consume the results.  I suppose as long as the individual results are well delineated it shouldn't be too noisy.

Encoder for v2 is implemented. I'm following your implementation with the trim option. I try to implement the decoder this weekend.


it will be ban or how can I add proxy to it?

it will be banned if you do to many calls

@thanatos11  i did many calls and now i am banned the requests are illegal, the questions is i will be banned forever?

@thanatos11 sorry for my english i'm using google translater

@thanatos11 i did many calls and now i am banned the requests are illegal, the questions is i will be banned forever?

the request are not illegal, they detect robots and dennies that to save their server performance. Now, if you made a lot of request, just logg in with yu user used, and do the capcha they require, then logg off, and login, get the new cookie and replace it. It should work, at least for my application, where i wanted to get user info, it works.

also, you can change the IP, they ban the IP

Yes they ban the ip i make somenthing like 300 requests per hour and they ban me, but after a while they remove the ban. The options are: use proxy rotation, use vpn, implement a sleep component for the requests, or as thantos suggested you need to set new cookies in the header file. At the moment i m trying vpn + sleep

Yes they ban the ip i make somenthing like 300 requests per hour and they ban me, but after a while they remove the ban. The options are: use proxy rotation, use vpn, implement a sleep component for the requests, or as thantos suggested you need to set new cookies in the header file. At the moment i m trying vpn + sleep


Adapt NeptuneLogger to new neptune-client api

Adapt NeptuneLogger to changes in neptune-client api changes

Deprecated NeptuneLogger was moved to separate repo
New NeptuneLogger which supports new neptune-client is created
Tests for new NeptuneLogger are implemented
Documentation has been updated
piggyback:
Broken proxy support in old NeptuneLogger https://github.com/neptune-ai/neptune-client/issues/413

This issue was closely related to other changes in this PR

Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
I made sure I had fun coding 🙃

Hello @shnela! Thanks for updating this PR.

In the file pytorch_lightning/loggers/neptune.py:

Line 154:121: E501 line too long (160 > 120 characters)

@williamFalcon  @awaelchli @Borda @SeanNaren @carmocca @tchaton @justusschock @kaushikb11 @edenlightning
Hi guys.
Is there anything I have to do before you can start review of this branch?
From my perspective it's done, but if I need to fix something before you can start review, or if I can help you somehow with that, don't hesitate to ask ;)

@awaelchli  @Borda
Ok, everything updated and ready to merge.

Thanks a lot! We will follow up here as soon as 1.3 is released (May 5ish). We currently have feature freeze for stability testing and will not be able to merge new features and refactors.

Hi @awaelchli
I see that you've succeed with publishing neptune-pytorch 1.3.0, congrats!
I wonder how does your policy regarding new features look like. Is it possible to publish neptune integration in release 1.3.1, when do you plan to publish such release?
Best
Jakub

Thanks Jakub

I wonder how does your policy regarding new features look like. Is it possible to publish neptune integration in release 1.3.1, when do you plan to publish such release?

We reserve 1.3.x for bugfixes exclusively, the don't have new features or refactors.
I contacted @edenlightning to figure out what we can do. Will get back to you

Since this isn't a bugfix, it can be included in the next minor release (1.4), expected to be released in 10-12 weeks.

hey @edenlightning ,
Kamil from neptune.ai, nice to meet you here.
On the Neptune side we now work on the improved integration. Do you have any estimate when you are going to release 1.4? I'm trying to figure out deadlines for our work?
Thanks.

hey @edenlightning ,
This is friendly reminder about my previous questions:

Do you have any estimate when you are going to release 1.4?
I'm trying to figure out deadlines for our work?

@williamFalcon @awaelchli @Borda @SeanNaren @carmocca @tchaton @justusschock @kaushikb11 @edenlightning
Hi again :)
Unfortunately we wasn't able to merge this changes and release as part of PTL1.4.
Since then we've cleaned this PR recently and updated our new NeptuneLogger a little bit.
For us it's extremely important to release these changes in version 1.5.0, so they will be available in September.
So we'd be grateful if you've reviewed this branch and give us feedback about what we should improve to make it happen.
From our perspective the only thing we'll have to is updating docstrings in new NeptuneClient.
So, is there something you want us to improve? :)

Great! Love it. When it's ready for review feel free to ping us @shnela

@awaelchli from our perspective almost everything is done.
@tchaton asked several PR questions and we've fixed almost all of them. There are only three unresolved issues we're discussing:

Checkpoint reloading - we need more clarification
Supporting log_* methods - we're quite confused about that one. Any other logger implements it.

@awaelchli @tchaton
Status for today.
What is not resolved:

Some documentation issues - @kamil-kaczmarek @Herudaio will take care of it tomorrow morning

suggestion of putting docs to neptune.rst
info about not working collection of loggers

(from yesterday) Supporting log_* methods - we've suggested some solutions and we're waiting for detailed answer from you.
(pickling test)[https://github.com/PyTorchLightning/pytorch-lightning/pull/6867#discussion_r700036278] - I'm waiting for information regarding pickle testing for NeptuneLogger but if I get no response for tomorrow I'll start implementing something similar to test_wandb_pickle

I hope you guys remember that it's really important for us to release these changes with pytorch-lightning 1.5.0?
Do you think we can have any trouble with that?
Best,
Jakub

I hope you guys remember that it's really important for us to release these changes with pytorch-lightning 1.5.0?
Do you think we can have any trouble with that?

I don't see anything standing in the way of that.

Hey @shnela,
Let's remove the _raise_deprecated_api_usage and make sure the functionality is supported internally so it doesn't introduce a BC.
Best,
T.C

Hi @awaelchli ,
it looks like we're almost done with this PR.
All we need is information from you about neptune PTL docs.
Best,
Jakub

Hey @shnela,
There is one failing test.
Best,
T.C

@awaelchli @tchaton is there anything I can do for you guys?
Or maybe I can just wait for PR to be merged :P

@tchaton fixed.

@tchaton and again fixed Docs check / test-docs (pull_request) .

see here, maybe you need to run this command.

@awaelchli @tchaton should be good now.

Thanks. Can you merge master so the branch is in sync? For the next PR it would be good if you could allow us maintainers to make changes to the branch, then we can better help out with these pre-commit checks and so on.

@awaelchli

Thanks. Can you merge master so the branch is in sync?

I've just rebased branch and pushed changes. I think we should squash commits from this branch before merging (github can automatically do that), since the commit history is quite messy here and there's no merge commits.

For the next PR it would be good if you could allow us maintainers to make changes to the branch, then we can better help out with these pre-commit checks and so on.

Yes! We definitely should and will do that!

yes every pr gets merged with squash. no history will be carried over from this branch to master.

@awaelchli @tchaton so can we merge now? :p

Hey @shnela,
Great work there ! Really excited about this :)
Best,
T.C

@tchaton

Great work there ! Really excited about this :)

We to! Thank you for review and your help!
Best,
Jakub

Hi @shnela @kamil-kaczmarek ,
Is it possible to use old neptune API when using master? If yes, are there any examples?

Hi @raman-rajarathinam,
We are preparing an update to the neptune legacy-docs, where this use case will be supported and described.
We are planning to release an update next week.

Hi @kamil-kaczmarek after upgrading to pl==1.5.0 Neptune stopped working for me:
When i start it it print the experiment multiple times and keeps printing the messege as below.
https://app.neptune.ai/i008/bovine/e/BOV-575
https://app.neptune.ai/i008/bovine/e/BOV-575
https://app.neptune.ai/i008/bovine/e/BOV-575
https://app.neptune.ai/i008/bovine/e/BOV-575
https://app.neptune.ai/i008/bovine/e/BOV-575
https://app.neptune.ai/i008/bovine/e/BOV-575
https://app.neptune.ai/i008/bovine/e/BOV-575
https://app.neptune.ai/i008/bovine/e/BOV-575
https://app.neptune.ai/i008/bovine/e/BOV-575
https://app.neptune.ai/i008/bovine/e/BOV-575
https://app.neptune.ai/i008/bovine/e/BOV-575
https://app.neptune.ai/i008/bovine/e/BOV-575
https://app.neptune.ai/i008/bovine/e/BOV-575
https://app.neptune.ai/i008/bovine/e/BOV-575
https://app.neptune.ai/i008/bovine/e/BOV-575
Global seed set to 1245
Error occurred during asynchronous operation processing: Timestamp must be non-decreasing for series attribute: monitoring/stdout. Invalid point: 2021-11-05T10:06:48.990Z
Error occurred during asynchronous operation processing: Timestamp must be non-decreasing for series attribute: monitoring/stdout. Invalid point: 2021-11-05T10:06:48.992Z
Error occurred during asynchronous operation processing: Timestamp must be non-decreasing for series attribute: monitoring/stdout. Invalid point: 2021-11-05T10:06:49.359Z
Error occurred during asynchronous operation processing: Timestamp must be non-decreasing for series attribute: monitoring/stdout. Invalid point: 2021-11-05T10:06:49.361Z
Error occurred during asynchronous operation processing: Timestamp must be non-decreasing for series attribute: monitoring/stdout. Invalid point: 2021-11-05T10:06:49.722Z
Error occurred during asynchronous operation processing: Timestamp must be non-decreasing for series attribute: monitoring/stdout. Invalid point: 2021-11-05T10:06:49.726Z
Error occurred during asynchronous operation processing: Timestamp must be non-decreasing for series attribute: monitoring/stdout. Invalid point: 2021-11-05T10:06:50.099Z
Error occurred during asynchronous operation processing: Timestamp must be non-decreasing for series attribute: monitoring/stdout. Invalid point: 2021-11-05T10:06:50.105Z
Error occurred during asynchronous operation processing: Timestamp must be non-decreasing for series attribute: monitoring/stdout. Invalid point: 2021-11-05T10:06:50.477Z
Error occurred during asynchronous operation processing: Timestamp must be non-decreasing for series attribute: monitoring/stdout. Invalid point: 2021-11-05T10:06:50.481Z
Error occurred during asynchronous operation processing: Timestamp must be non-decreasing for series attribute: monitoring/stdout. Invalid point: 2021-11-05T10:06:50.840Z

Hey @i008,
Did the same code worked well before upgrade to 1.5 ?
To confirm: is it training on many machine or with muliple processes?

One local gpu. The (almost) same code worked. I had to adjust the init of the logger.

@i008,

Do you use CUSTOM_RUN_ID or pass the run object around in your code base?
Can you share what you modified in the init?

Problem is that async processes write to the same place (stdout in your case) in Neptune and this causes these errors msgs. In practice it does not break your run, these points are simply skipped.
There are few strategies to mitigate that. Happy to chat online if it's ok for you.

Hey @kamil-kaczmarek
Whats the best way to get in touch online? Maybe you can send me a hangout invite<EMAIL_ADDRESS>Im avaialble next ~3 hours if that works for you.

I did some further debugging and it seems that this i related to the CLI interface. The problem only occurs while using neptune like that:
    neptune_logger = NeptuneLogger(
        api_key=NEPTUNE_KEY,
        project='projec',
        source_files=["**/*.py", "**/*.ipynb"],

    )

    train_defaults = {
        'logger': neptune_logger,
        'gpus': 1,
        'precision': 16

    }
    cli = CLI(
        LitAutoEncoder,
        Data,
        trainer_defaults=train_defaults,
    )

If i do it the regular way ( trainer = , trainer.fit())  things work as expected.

Great, thanks for the info. Let's dicsuss more online

@kamil-kaczmarek Hi, should we add a init args version to the NeptuneLogger so that the user can customize the custom_run_id and align it with other Loggers in PytorchLightning like TensorBoardLogger and WandbLogger?

@shnela @kamil-kaczmarek The deprecated code can now be removed (_signal_deprecated_api_usage)


Feature Request: Add download-submissions Command to GitHub Classroom CLI for Bulk Download of Student Submissions

Is your feature request related to a problem? Please describe.
I would like to highlight a specific issue: instructors often find it challenging and time-consuming to individually access and download student submissions in GitHub Classroom.
Describe the solution you'd like
I would like to propose the addition of a download-submissions command to the GitHub Classroom CLI that enables instructors to efficiently retrieve and save all student submissions for a specific assignment within a classroom. This command will use GET requests, including the "List accepted assignments for an assignment" API endpoint, to retrieve student repository information. Then, it should proceed to clone or download those repositories to a specified output directory. This feature would significantly streamline the process of accessing and reviewing student work.
Describe alternatives you've considered
As an alternative, instructors can manually clone each student's repository, but this process is time-consuming and prone to errors, especially when dealing with large classrooms. Automating this task through a dedicated command would greatly enhance the user experience.
Additional context
This enhancement would be highly beneficial for instructors who use GitHub Classroom for managing assignments and grading. It would improve workflow efficiency and reduce the administrative overhead of accessing student submissions, ultimately leading to a more positive experience for educators using GitHub Classroom.

Hi @christosgalano,
I am not sure if I understand what you are asking. This already exists with the command gh classroom clone student-repos
-Shane


Can't remove consumers added by using ‘Link Consumer to Namespace’ button

From NRIDS team:

I noticed in the Portal there is a ‘Link Consumer to Namespace’ button. I didn’t understand what that button does.
Side note: I am unable to delete consumers that were ‘linked’ using this button during my testing.

Our reply was: It should be possible to remove the consumers linked this way, and we will log this as a bug to investigate.
Current behaviour:

GIVEN I am an API Provider
AND I have a namespace
AND I have used the ‘Link Consumer to Namespace’ button to link a consumer to the namespace
WHEN I view that consumer that was added with the ‘Link Consumer to Namespace’ button
THEN I can cannot remove that consumer from the namespace

Expected behaviour:

GIVEN I am an API Provider
AND I have a namespace
AND I have used the ‘Link Consumer to Namespace’ button to link a consumer to the namespace
WHEN I view that consumer that was added with the ‘Link Consumer to Namespace’ button
THEN I can successfully remove that consumer from the namespace

Further context: we probably don't want to delete the consumer, as they are still linked to other namespaces, but what we do probably have the ability to do is "remove" a consumer that has been linked to a namespace, while preserving their membership to their original namespace.
tl;dr don't affect the other ACL lists


Fix dragging empty tables

Fixes #932

Frozen columns still work (left floating), so should be good?


✨ Transform improvements

What is this?
This improves transform prompts in two ways

Uses inquirer-glob-prompt to prompt for a glob pattern in a much nicer way.
Adds a transform.when method that can return false when a transform prompt should be skipped entirely. This check is only performed when an SDK is already installed. When not installed, all transforms are always prompted.

The second addition was utilized to conditionally ask about removing Cypress tasks. In @percy/cypress < 2, there were no tasks, so this prompt need only be asked when using v2. The version check uses 2 - 3 as the range in case somebody has already upgraded but accidentally skipped the transform the first time.

https://user-images.githubusercontent.com/5005153/113943597-a4426480-97c8-11eb-9281-56c72eb87f28.mov


#848 highlight positioning in coy theme fix - changed overflow for pre and code

Here is a fiddle to reproduce the issue: http://codepen.io/anon/pen/RrKGLw
I used this fiddle to test this fix: http://codepen.io/anon/pen/obBzMK

Thanks & happy new year :)
This breaks the shadows under the code area in this theme :(


Setup is broken after vm reload

Not sure what is reason for that, but after vm reload (vagrant halt / vagrant up) web server is broken

When I open any site it always show default page
PHP is not working: I see php script <?php phpinfo() instead of script result

If it makes difference: Host machine is win10, VB 5.0.3, vagrant 1.7.4.
Maybe it has something to do with this: When I shutdown VM every time I see this message:

c:\Web\php7>vagrant halt
==> default: Attempting graceful shutdown of VM...
==> default: Forcing shutdown of VM...

OK, that was my fault.
I added new site with root dir and loigs in shared folder so I could edit files from local machine.
Nginx, apparently, starts before folders are mounted so it failed to start correctly.
What I did to fix it:

Added line config.vm.provision "shell", path: "onUp.sh", run: "always" to Vagrantfile
Added script onUp.sh

service nginx stop
sudo fuser -k 80/tcp
service nginx start


Use kubeconfig passed through cli or from environment KUBECONFIG variable

If kubeconfig file is passed as command line option or if set in environment variable, openebsctl is still referring to the default config path i.e ~/.kube/config
It should refer to the cli option or the env variable KUBECONFIG , before referring to the default config file for accessing the k8 cluster
Following was the issue observed
With environment variable set:
[root@localhost do]# export KUBECONFIG=$PWD/kubeconfig
[root@localhost do]# kubectl get node
NAME                   STATUS   ROLES    AGE    VERSION
pool-pe58fno14-89ta0   Ready    <none>   179m   v1.21.3
pool-pe58fno14-89tad   Ready    <none>   3h     v1.21.3
pool-pe58fno14-89tav   Ready    <none>   179m   v1.21.3
[root@localhost do]# kubectl openebs get bd
Error while getting block device: Get "https://<IP_ADDRESS>/apis/openebs.io/v1alpha1/blockdevices": dial tcp <IP_ADDRESS>:443: i/o timeout
[root@localhost do]# export KUBECONFIG=/root/mayadata/do/kubeconfig
[root@localhost do]# kubectl openebs get bd
Error while getting block device: Get "https://<IP_ADDRESS>/apis/openebs.io/v1alpha1/blockdevices": dial tcp <IP_ADDRESS>:443: i/o timeout
[root@localhost do]# echo $KUBECONFIG
/root/mayadata/do/kubeconfig
[root@localhost do]# ls $KUBECONFIG
/root/mayadata/do/kubeconfig

With command line option passed:
kubectl openebs get bd --kubeconfig=./kubeconfig
Error while getting block device: Get "https://<IP_ADDRESS>/apis/openebs.io/v1alpha1/blockdevices": dial tcp <IP_ADDRESS>:443: i/o timeout
[root@localhost do]# kubectl  get bd -n openebs --kubeconfig=./kubeconfig
NAME                                           NODENAME               SIZE           CLAIMSTATE   STATUS   AGE
blockdevice-8d74ae095ad87e461541bd7c3f88ef0a   pool-pe58fno14-89tav<PHONE_NUMBER>28   Unclaimed    Active   15m
blockdevice-a93320e715e3b3e34362dad3a46e2497   pool-pe58fno14-89ta0<PHONE_NUMBER>28   Unclaimed    Active   15m
blockdevice-b70e08c5acd216a9fc524907d2493ffe   pool-pe58fno14-89tav   483328         Unclaimed    Active   15m
blockdevice-e36dae74636edae1e8b63a2a8ca6cd26   pool-pe58fno14-89tad<PHONE_NUMBER>28   Unclaimed    Active   15m
blockdevice-f4522bb459144611ed898b0fde19b143   pool-pe58fno14-89tad   483328         Unclaimed    Active   15m

It worked only after copying the config file to the default location
[root@localhost do]# cp ~/.kube/config  ~/.kube/config.bkp
[root@localhost do]# cp kubeconfig  ~/.kube/config
cp: overwrite '/root/.kube/config'? y
[root@localhost do]# kubectl openebs get bd
NAME                                             PATH        SIZE     CLAIMSTATE   STATUS     FSTYPE    MOUNTPOINT
pool-pe58fno14-89ta0
├─blockdevice-8ab74802a8660795b0a8b4f3c6c117b7   /dev/vdb    472KiB   Unclaimed    Inactive   iso9660
├─blockdevice-9aeb3048976d722b999c448e35352e93   /dev/vdb    472KiB   Unclaimed    Active     iso9660
└─blockdevice-a93320e715e3b3e34362dad3a46e2497   /dev/sda1   100GiB   Claimed      Active

pool-pe58fno14-89tav
├─blockdevice-8d74ae095ad87e461541bd7c3f88ef0a   /dev/sda1   100GiB   Claimed      Active
├─blockdevice-b70e08c5acd216a9fc524907d2493ffe   /dev/vdb    472KiB   Unclaimed    Inactive   iso9660
└─blockdevice-d702b5422005ebc658b308190e4f9e08   /dev/vdb    472KiB   Unclaimed    Active     iso9660

pool-pe58fno14-89tad
├─blockdevice-8e4f257d884b8026801490a76c802ec4   /dev/vdb    472KiB   Unclaimed    Active     iso9660
├─blockdevice-e36dae74636edae1e8b63a2a8ca6cd26   /dev/sda1   100GiB   Claimed      Active
└─blockdevice-f4522bb459144611ed898b0fde19b143   /dev/vdb    472KiB   Unclaimed    Inactive   iso9660

Yes, the current CLI options doesn't support kubeconfig flag, I think it is highly required.
Can I work on this issue?


java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory in Java Swing SLF4J-simple-1.7.25

Recently when I used Sarxos Camera with 'slf4j-api' but there was an error like this
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". SLF4J: Defaulting to no-operation (NOP) logger implementation SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
then it was stated here https://github.com/sarxos/webcam-capture/issues/103 to change it into slf4j-simple and then the next error is this
'java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory'
I am currently doing a personal project in java swing with a camera API

See https://github.com/sarxos/webcam-capture/wiki/java.lang.ClassNotFoundException%3A-org.slf4j.LoggerFactory

See https://github.com/sarxos/webcam-capture/wiki/java.lang.ClassNotFoundException%3A-org.slf4j.LoggerFactory


[Identity] Reduce playback timeout

As of this PR: https://github.com/Azure/azure-sdk-for-js/pull/14064/files I've increased the playback timeout because I haven't figured out a way to speed up MSAL's internals. We should investigate and make this better.
For more context: https://github.com/Azure/azure-sdk-for-js/pull/14064/files#r593361018

I have asked the MSAL team and they'll consider allowing us to control their polling interval.


how to write a loader by using ES6 syntax?

such as the title

Closing due to inactivity. Please test with latest version and feel free to reopen if still regressions. Thanks!
Please use discussions for questions, just write it in es6 syntax


maxDet in eval_only is not proposals num?

When I evaluate on a 300 proposals model, the eval info is:

The maxDet is 100 not the max proposals num, Should I change these three threshold or find another eval method?
My eval cmd is

@Mingfeng-Wang The cocoeval will only test the top-100 result, therefore output 300 or 100 should return the same performance. You need not to change any thing.

@Mingfeng-Wang The cocoeval will only test the top-100 result, therefore output 300 or 100 should return the same performance. You need not to change any thing.

Actually I am testing CrowHuman which is a dense dataset even more than 400 person in a img. I tried to change DETECTIONS PER IMAGE: 500. But I did not work still maxDets = 100.

@zzzzzz0407
Where can I change the topk num? I have spent a long time to find it in code. Thanks.

@Mingfeng-Wang You may should change the code in cocoeval and re-compile it to support large number eval.

change cocoeval code


local.path not working

Hi, I'm trying to paste the image and save to ../images/${YY}${MM}${DD}${hh}${mm}${ss}, but not working.
I have tried many times.

or

The image will always be saved to ![Alt text](image-1.png)
Any ideas?

I found it's controlled by vscode default markdown extension.

So, I end up with

如果你用 Ctrl + Shift + V 或右键菜单的 粘贴图片 应该会是正确的。


Windows Installation

Hello! I've been using your script on Linux for months, and I love it!
I switched to windows and installed python+all the dependencies, but I couldn't install kissanime-dl.
I included my cmd output: http://pastebin.com/yd1wV0G7
Thank you.

This looks like an error in the compatibility between python3 and python2. I'll fix it soon.

@wileyyugioh Waiting!
Thanks!

should be fixed in https://github.com/wileyyugioh/kissanime_dl/commit/670bead907d414dd04a5f3b61e67b541bed72c67

Update is pushed live in version 1.9.3

Closing because of inactivity

Hey, Could you please delete this issue? I would really appreciate it!


[SUPPORT] Using MRO table and synchronizing to hive, Flink checkpoint failed, resulting in log files being unable to scroll to parquet files

Tips before filing an issue

Have you gone through our FAQs?y

Join the mailing list to engage in conversations and get faster support at<EMAIL_ADDRESS>

If you have triaged this as a bug, then file an issue directly.

Describe the problem you faced
Using MRO table and synchronizing to hive, Flink checkpoint failed, resulting in log files being unable to scroll to parquet files

Using Flink to write a large amount of data to the Hudi table and synchronize it to Hive. Will occasional checkpoint failures result in the log file being unable to scroll to a parquet file, resulting in Hive querying less data than the Hudi table
To Reproduce
Steps to reproduce the behavior:

hive_sync.enabled=true
2.start flink checkpoint

Expected behavior
A clear and concise description of what you expected to happen.
Environment Description

Hudi version : 1.0

Flink version :1.15.2

Hive version :3.1.3

Hadoop version :

Storage (HDFS/S3/GCS..) :

Running on Docker? (yes/no) :

Additional context
Add any other context about the problem here.
Stacktrace
Add the stacktrace of the error.

Are you using append mode or upsert mode?

Are you using append mode or upsert mode?

使用的upsert 模式，数据为flink-cdc写入kafka的增量数据，再使用flink读取kafka数据写入hudi的mor表，查看checkponint发现有失败的，导致hudi同步到hive的外部表有漏数情况，具体是因为checkponint失败导致log文件没有滚动成parquet文件，请问这种情况有什么好的处理方式吗，目前checkponint间隔时间为150秒，超时时间450秒，可同时checkponint的最大数为3

日志zhogn中发现的异常

cc @danny0405


httproute: pluralize hostname and allow for wildcards

This commit bundles two changes:

pluralizes hostnames to define the same route
allows for wildcards in the left-most label (same as Ingress V1)

Fix #80

While this PR has two different changes, I opened this up as one. Let me know if I should separate this out.
This PR also introduces some inconsistencies in how "wildcard" or "domain" (@jpeach  :D) matching is defined at the listener level vs the HTTPRoute level.

looks like this is easy to fix and get merged
/approve

@robscott I've incorporated your feedback. PTAL.

/lgtm


Cannot use CentOS6 image for ansible role tests.

I'm unsure if you're aware of this, but I've been trying to use the CentOS6 image as recommended by you, in the same standard format a lot of your other roles use, and I simply... can't - anymore.
Here's the error message provided by Travis.
docker: Error response from daemon: invalid header field value "oci runtime error: container_linux.go:247: starting container process caused \"exec: \\\"/usr/lib/systemd/systemd\\\": stat /usr/lib/systemd/systemd: no such file or directory\"\n".

I've managed to get around this completely by using /sbin/init instead, so maybe the documentation simply needs changing? I'll leave it in your court, but I'm now building successfully again.

Oops! Sorry about that; fixed with the above commit. You're correct that it should be /sbin/init.

My apologies for drawing your attention here again...
This was working until recently, and now I'm having the same problem with /sbin/init
docker run --detach --volume="${PWD}":/etc/ansible/roles/role_under_test:ro ${run_opts} geerlingguy/docker-${distro}-ansible:latest "${init}" > "${container_id}"
docker: Error response from daemon: invalid header field value "oci runtime error: container_linux.go:247: starting container process caused \"exec: \\\"/sbin/init\\\": stat /sbin/init: no such file or directory\"\n".

Other than dropping my support for this platform - would you have anything to suggest?

Never mind, this seems like an issue with travis...

Ha, no worries... it wasn't just you! https://github.com/geerlingguy/docker-centos6-ansible/issues/2
I had to fix that yesterday to get CentOS 6 tests happy again :)


Add Verify SSL config

Tried changing bool value in both c# and python but did not notice a difference, since I've never encountered trouble instantiating the client with or without ssl verification. Any ideas on how to test this functionality would be appreciated


Fix: Travis

This PR fixes the repo name in travis.yml

Coverage remained the same at 100.0% when pulling ea421c2df2d0d0a5a8d1ca283721f7f10a953696 on fix/travis into 03f25244e781907bc17066d5eb16599442a7abc5 on master.


Comb Sort in C++

I would like to add the code for comb sort implemented in C++ as a part of Hacktoberfest. Kindly assign me this issue

@muthuannamalai12 Go Ahead! put it in respective folder.


Header fixes

Summary

Header enhancements and bug fixes outlined here

Change List (commits, features, bugs, etc)

added HeaderMenu.jsx and HeaderMenu.test.jsx
made style and code changes to Header.jsx
added styles and made prop changes on Header.story.jsx

Related Issues

Closes IBM/carbon-addons-iot-react#175

:tada: This PR is included in version 1.36.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.36.0 :tada:
The release is available on npm package (@release-1.x dist-tag)
Your semantic-release bot :package::rocket:


Tutorial: Error when running summary.py for the first time without specifying tmp folder

Hi! This error occurs when following the tutorial step by step (after downloading BEAR and installing the required packages).
Start: Stage 1... 2021-09-11 11:12:47.502770
Stage 2... 2021-09-11 11:12:49.422647
Traceback (most recent call last):
  File "summarize.py", line 607, in <module>
    main(args)
  File "summarize.py", line 570, in main
    n_bins = run(args)
  File "summarize.py", line 553, in run
    total_size = stage2(unit2is, args)
  File "summarize.py", line 304, in stage2
    out_size += unit2i.get_size()
  File "summarize.py", line 289, in get_size
    out_size = os.path.getsize(self.out_file)
  File "/home/remita/pyenvs/bear/lib/python3.7/genericpath.py", line 50, in getsize
    return os.stat(filename).st_size
FileNotFoundError: [Errno 2] No such file or directory: 'data/ysd1_kmc_out_0_full_6.tsv'

After investigation, it appears that KMC cannot find the default tmp folder tests/exdata/tmp/ and throws an error in the stderr data/ysd1_kmc_stderr_0_full_6.txt
--- kmc ---
Error: Cannot create file in specified working directory: tests/exdata/tmp/
--- kmc dump ---
Error: Cannot open file data/ysd1_kmc_inter_0_full_6.res.kmc_pre

So in the tutorial, it is better to add that the user must create the default tmp folder tests/exdata/tmp/ or specify an existing folder with the option -t of the script summarize.py.
Thank you.

Hi maremita, thanks for finding this issue and letting us know! We've added a tmp folder to the repo and adjusted the defaults of summarize.py accordingly. It should now work automatically.

Thank you @EWeinstein.


Remove global NewBatch

Please remove the global function NewBatch. It has been marked as deprecated since commit 3688d5fd. Using NewBatch can cause crashes and is not covered by existing tests.
NewBatch was first deprecated with this commit on Dec 30, 2017:
https://github.com/gocql/gocql/commit/3688d5fd49d899f49773e1e5c7250d4cf3486d54
Related issue : #1065 Remove NewBatch function, marked for next major version. I think this refers also to Session.NewBatch.
Please answer these questions before submitting your issue. Thanks!
What version of Cassandra are you using?
3.11.6
What version of Gocql are you using?
Commit 6d895e38b0a53cd804a3a2f547c9d9c0666aef35, Mar 24, 2020
What did you do?
Called the NewBatch function and used TokenAwareHostPolicy.
What did you expect to see?
Works.
What did you see instead?
Crashes, because TokenAwareHostPolicy calls Batch.GetRoutingKey, which calls Session.routingKeyInfo, but the session pointer in the Batch struct is nil.
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x8df228]
goroutine 5059 [running]:
foo/github.com/gocql/gocql.(*Session).routingKeyInfo(0x0, 0x1cc6d00, 0xc007c76090, 0x1acb4ed, 0x84, 0x0, 0x0, 0x0)
        /go/src/foo/github.com/gocql/gocql/session.go:495 +0x68
foo/github.com/gocql/gocql.(*Batch).GetRoutingKey(0xc000d50620, 0x20, 0xc001bbdd70, 0x8db023, 0xc0001f8540, 0x1cdb460)
        /go/src/foo/github.com/gocql/gocql/session.go:1774 +0xcf
foo/github.com/gocql/gocql.(*tokenAwareHostPolicy).Pick(0xc0001f8540, 0x1cdb3e0, 0xc000d50620, 0x1cc6d00)
        /go/src/foo/github.com/gocql/gocql/policies.go:575 +0x52
foo/github.com/gocql/gocql.(*queryExecutor).do(0xc00000eae0, 0x1cc6d00, 0xc007c76090, 0x1cdb3e0, 0xc000d50620, 0xc00027c2d8)
        /go/src/foo/github.com/gocql/gocql/query_executor.go:87 +0x63
foo/github.com/gocql/gocql.(*queryExecutor).executeQuery(0xc00000eae0, 0x1cdb3e0, 0xc000d50620, 0x0, 0x0, 0x0)
        /go/src/foo/github.com/gocql/gocql/query_executor.go:60 +0x42e
foo/github.com/gocql/gocql.(*Session).executeBatch(0xc00020e000, 0xc000d50620, 0x1cd67a0)
        /go/src/foo/github.com/gocql/gocql/session.go:642 +0xc5
foo/github.com/gocql/gocql.(*Session).ExecuteBatch(0xc00020e000, 0xc000d50620, 0xc004e4c590, 0x1b01fa0)
        /go/src/foo/github.com/gocql/gocql/session.go:653 +0x39

If you are having connectivity related issues please share the following additional information
Describe your Cassandra cluster
please provide the following information

output of nodetool status
output of SELECT peer, rpc_address FROM system.peers
rebuild your application with the gocql_debug tag and post the output

Duplicate of https://github.com/apache/cassandra-gocql-driver/issues/1065


Task description for OpenX datasets to eval GPT-4 on OpenX

Prompting GPT-4 to produce outputs for OpenX requires descriptions of the task, action spaces, and additional information for each dataset.

Gathering verbal descriptions of action spaces from various sources - code, websites, authors of datasets, etc.

Same as #176, #177, and #178


Again - Cannot set property 'value' of null

installed everything as told.
My application works in all, sometimes even the SweetAlert works too.
But in one controller i can't get it to work!
$scope.test = function() {
SweetAlert.swal("Hello world");
}
template:  Say hi
gives me an immediate TypeError: Cannot set property 'value' of null.
What's the problem? All arguments are injected correctly into my controller, the order is correct- no thing is missing. The rest of the code works perfect.

hi @egorlaw,
Can you give me a jsFiddle of the code that is causing the problem or detailed rep of the full controller might help.

hi @DannyMcwaves ,
I've managed to found the problem.
I loved the animated in css icons that sweetalert uses (like the Success one - with the check on the green circle) and i used it in side my template for the step of the form that is a "thank-you" kinda-like page. During the http async request (before going to that step) i pop out $uibModal.open and make a loading. After resolving the modal with $scope.$close i try to make the user awar of the successful transaction with an SweetAlert.swal, but the error would make the thing impossible.
What i've found is that NEVER USE any of the markup / classes that are sweet-alert native. Because it'll try to instantiate them as already existing on page and try to clean the mess. But there's no sweetalert on page so far - so it lauches the error.
My template had this element:
`

`
This breaks the sweetalert behaviour. Probably any other part of the swal constructs as overlays and body or else - will break the stuff too.
Don't try this at home folks ;)

Hi @egorlaw
Great. I am very glad that you have fixed that.
I saw your profile and I realized you can code python. I was wondering if you have enough time,
so we can collaborate on this python project I am trying to work on.
If you have enough time, just let me know.

Sorry man, but im full with angularjs and drupal projects atm. Free Time is
familiare though
On Mon, 28 Nov 2016 at 11:14, Ayikpah Daniel Amanor Mcwaves <
<EMAIL_ADDRESS>wrote:

Hi @egorlaw https://github.com/egorlaw
Great. I am very glad that you have fixed that.
I saw your profile and I realized you can code python. I was wondering if
you have enough time,
so we can collaborate on this python project I am trying to work on.
If you have enough time, just let me know.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/oitozero/ngSweetAlert/issues/69#issuecomment-263208159,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA2-CgOx_ILme52M-aLrfKpdvgrMryEOks5rCo1vgaJpZM4K6sae
.

cool. Are you using angular 2, @egorlaw ??

Still learning. Ti has quite steep learning curve imho
On Mon, 28 Nov 2016 at 12:01, Ayikpah Daniel Amanor Mcwaves <
<EMAIL_ADDRESS>wrote:

cool. Are you using angular 2, @egorlaw https://github.com/egorlaw ??
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/oitozero/ngSweetAlert/issues/69#issuecomment-263216752,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA2-CuuShvP3uW9aLvagt1vAqn1-ywDNks5rCphegaJpZM4K6sae
.

Nice. If you have any projects on angular or angular 2 that you think you might need collaboration on, just let me know. If you have an understanding with angular 1, can you check this project I created and see if you can find any issues. Also  I am following you, can you follow back?

Nice. If you have any projects on angular or angular 2 that you think you might need collaboration on, just let me know. If you have an understanding with angular 1, can you check this project I created, ngSocial in in my repo, and see if you can find any issues. Also  I am following you, can you follow back?


flake in http-filter-example:http_filter_integration_test

Feb 9
Feb 6
I think this may just be 5 ms is not enough time to wait on a load host running instrumented tests.
2020-02-09T20:09:48.3635590Z FAIL: //http-filter-example:http_filter_integration_test (see /build/tmp/_bazel_bazel/400406edc57d332f0b9b805d2b8e33a1/execroot/envoy_filter_example/bazel-out/k8-dbg/testlogs/http-filter-example/http_filter_integration_test/test.log)
2020-02-09T20:09:48.3637885Z INFO: From Testing //http-filter-example:http_filter_integration_test:
2020-02-09T20:09:48.3639116Z ==================== Test output for //http-filter-example:http_filter_integration_test:
2020-02-09T20:09:48.3639557Z [==========] Running 2 tests from 1 test suite.
2020-02-09T20:09:48.3640478Z [----------] Global test environment set-up.
2020-02-09T20:09:48.3640932Z [----------] 2 tests from IpVersions/HttpFilterSampleIntegrationTest
2020-02-09T20:09:48.3641182Z [ RUN      ] IpVersions/HttpFilterSampleIntegrationTest.Test1/0
2020-02-09T20:09:48.3641593Z http-filter-example/http_filter_integration_test.cc:33: Failure
2020-02-09T20:09:48.3642093Z Value of: fake_upstreams_[0]->waitForHttpConnection(*dispatcher_, fake_upstream_connection, std::chrono::milliseconds(5))
2020-02-09T20:09:48.3642355Z   Actual: false (Timed out waiting for new connection.)
2020-02-09T20:09:48.3642566Z Expected: true
2020-02-09T20:09:48.3642749Z Stack trace:
2020-02-09T20:09:48.3642961Z   0x17d9fe60: Envoy::HttpFilterSampleIntegrationTest_Test1_Test::TestBody()
2020-02-09T20:09:48.3643299Z   0x2e88313e: testing::internal::HandleSehExceptionsInMethodIfSupported<>()
2020-02-09T20:09:48.3643516Z   0x2e833646: testing::internal::HandleExceptionsInMethodIfSupported<>()
2020-02-09T20:09:48.3643746Z   0x2e7dee77: testing::Test::Run()
2020-02-09T20:09:48.3643959Z   0x2e7e1b80: testing::TestInfo::Run()
2020-02-09T20:09:48.3644168Z ... Google Test internal frames ...
2020-02-09T20:09:48.3644326Z
2020-02-09T20:09:48.3644972Z [2020-02-09 20:09:42.091][17][critical][assert] [external/envoy/source/common/network/connection_impl.cc:74] assert failure: !ioHandle().isOpen() && delayed_close_timer_ == nullptr. Details: ConnectionImpl was unexpectedly torn down without being closed.
2020-02-09T20:09:48.3645332Z AddressSanitizer:DEADLYSIGNAL
2020-02-09T20:09:48.3645555Z =================================================================
2020-02-09T20:09:48.3645792Z ==17==ERROR: AddressSanitizer: ABRT on unknown address 0xfffe00000011 (pc 0x7fe1d86c8428 bp 0x7ffcc2034540 sp 0x7ffcc2034168 T0)
2020-02-09T20:09:48.3646281Z     #0 0x7fe1d86c8427 in raise (/lib/x86_64-linux-gnu/libc.so.6+0x35427)
2020-02-09T20:09:48.3646742Z     #1 0x7fe1d86ca029 in abort (/lib/x86_64-linux-gnu/libc.so.6+0x37029)
2020-02-09T20:09:48.3647020Z     #2 0x28308b29 in Envoy::Network::ConnectionImpl::~ConnectionImpl() /proc/self/cwd/external/envoy/source/common/network/connection_impl.cc:73:3
2020-02-09T20:09:48.3647659Z     #3 0x28353081 in Envoy::Network::ClientConnectionImpl::~ClientConnectionImpl() /proc/self/cwd/bazel-out/k8-dbg/bin/external/envoy/source/common/network/_virtual_includes/connection_lib/common/network/connection_impl.h:187:7
2020-02-09T20:09:48.3648371Z     #4 0x2834e25b in Envoy::Network::ClientConnectionImpl::~ClientConnectionImpl() /proc/self/cwd/bazel-out/k8-dbg/bin/external/envoy/source/common/network/_virtual_includes/connection_lib/common/network/connection_impl.h:187:7
2020-02-09T20:09:48.3649065Z     #5 0x2834e2f4 in Envoy::Network::ClientConnectionImpl::~ClientConnectionImpl() /proc/self/cwd/bazel-out/k8-dbg/bin/external/envoy/source/common/network/_virtual_includes/connection_lib/common/network/connection_impl.h:187:7
2020-02-09T20:09:48.3649418Z     #6 0x1e59cb51 in std::__1::default_delete<Envoy::Network::ClientConnection>::operator()(Envoy::Network::ClientConnection*) const /opt/llvm/bin/../include/c++/v1/memory:2338:5
2020-02-09T20:09:48.3649754Z     #7 0x1e59c7ec in std::__1::unique_ptr<Envoy::Network::ClientConnection, std::__1::default_delete<Envoy::Network::ClientConnection> >::reset(Envoy::Network::ClientConnection*) /opt/llvm/bin/../include/c++/v1/memory:2593:7
2020-02-09T20:09:48.3650132Z     #8 0x1e594ce8 in std::__1::unique_ptr<Envoy::Network::ClientConnection, std::__1::default_delete<Envoy::Network::ClientConnection> >::~unique_ptr() /opt/llvm/bin/../include/c++/v1/memory:2547:19
2020-02-09T20:09:48.3650441Z     #9 0x26b9e1ea in Envoy::Http::CodecClient::~CodecClient() /proc/self/cwd/external/envoy/source/common/http/codec_client.cc:47:27
2020-02-09T20:09:48.3651077Z     #10 0x203ce3e7 in Envoy::Http::CodecClientProd::~CodecClientProd() /proc/self/cwd/bazel-out/k8-dbg/bin/external/envoy/source/common/http/_virtual_includes/codec_client_lib/common/http/codec_client.h:243:7
2020-02-09T20:09:48.3651395Z     #11 0x203d871b in Envoy::IntegrationCodecClient::~IntegrationCodecClient() /proc/self/cwd/external/envoy/test/integration/http_integration.h:19:7
2020-02-09T20:09:48.3651765Z     #12 0x203d8784 in Envoy::IntegrationCodecClient::~IntegrationCodecClient() /proc/self/cwd/external/envoy/test/integration/http_integration.h:19:7
2020-02-09T20:09:48.3652062Z     #13 0x17ead261 in std::__1::default_delete<Envoy::IntegrationCodecClient>::operator()(Envoy::IntegrationCodecClient*) const /opt/llvm/bin/../include/c++/v1/memory:2338:5
2020-02-09T20:09:48.3652386Z     #14 0x17eacefc in std::__1::unique_ptr<Envoy::IntegrationCodecClient, std::__1::default_delete<Envoy::IntegrationCodecClient> >::reset(Envoy::IntegrationCodecClient*) /opt/llvm/bin/../include/c++/v1/memory:2593:7
2020-02-09T20:09:48.3652770Z     #15 0x17da4ac8 in std::__1::unique_ptr<Envoy::IntegrationCodecClient, std::__1::default_delete<Envoy::IntegrationCodecClient> >::~unique_ptr() /opt/llvm/bin/../include/c++/v1/memory:2547:19
2020-02-09T20:09:48.3653377Z     #16 0x17da1433 in Envoy::HttpFilterSampleIntegrationTest_Test1_Test::TestBody() /proc/self/cwd/http-filter-example/http_filter_integration_test.cc:42:1
2020-02-09T20:09:48.3653713Z     #17 0x2e88313d in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:2433:10
2020-02-09T20:09:48.3654068Z     #18 0x2e833645 in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:2469:14
2020-02-09T20:09:48.3654408Z     #19 0x2e7dee76 in testing::Test::Run() /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:2508:5
2020-02-09T20:09:48.3654682Z     #20 0x2e7e1b7f in testing::TestInfo::Run() /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:2684:11
2020-02-09T20:09:48.3654959Z     #21 0x2e7e42eb in testing::TestSuite::Run() /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:2816:28
2020-02-09T20:09:48.3655236Z     #22 0x2e815391 in testing::internal::UnitTestImpl::RunAllTests() /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:5338:44
2020-02-09T20:09:48.3655574Z     #23 0x2e896a9b in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:2433:10
2020-02-09T20:09:48.3655982Z     #24 0x2e83e735 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:2469:14
2020-02-09T20:09:48.3656343Z     #25 0x2e8131b7 in testing::UnitTest::Run() /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:4925:10
2020-02-09T20:09:48.3656623Z     #26 0x27d7ec9f in RUN_ALL_TESTS() /proc/self/cwd/external/com_google_googletest/googletest/include/gtest/gtest.h:2473:46
2020-02-09T20:09:48.3656893Z     #27 0x27d7c682 in Envoy::TestRunner::RunTests(int, char**) /proc/self/cwd/external/envoy/test/test_runner.cc:121:10
2020-02-09T20:09:48.3657130Z     #28 0x27d765f2 in main /proc/self/cwd/external/envoy/test/main.cc:46:10
2020-02-09T20:09:48.3657617Z     #29 0x7fe1d86b382f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
2020-02-09T20:09:48.3658242Z     #30 0x17cf7028 in _start (/b/f/w/bazel-out/k8-dbg/bin/http-filter-example/http_filter_integration_test.runfiles/envoy_filter_example/http-filter-example/http_filter_integration_test+0x17cf7028)
2020-02-09T20:09:48.3658509Z
2020-02-09T20:09:48.3658698Z AddressSanitizer can not provide additional info.
2020-02-09T20:09:48.3659145Z SUMMARY: AddressSanitizer: ABRT (/lib/x86_64-linux-gnu/libc.so.6+0x35427) in raise
2020-02-09T20:09:48.3659446Z ==17==ABORTING
2020-02-09T20:09:48.3659647Z ================================================================================

This is the same assertion as #9948

So much the same it's a duplicate.


sample rate higher than 1khz

Im unable to get a sample rate higher than 1khz. It seems locked to that because im able to get data at max exacly 1000 times a second. Any way to increse this limit? I should be able to get 8khz

Correct, this library only supports up to 1 kHz. You'd have to bypass the DLPF to reach a higher rate.

Is there any way i could modify this library to get 8khz? Do i only need to change what it writes to the registers or would that mean rewriting a lot of code?

I think you would need to remove or modify the DLPF setting in the begin method to get your desired rate. The appropriate bytes to send would be in the MPU-9250 datasheet.


Distance from the camera

Hello,
I am now trying to determine the distance of the person to the camera using the 3D data. Unfortunately, I do not understand how to interpret this data.
I have received the data as described in #28.
[[[ 64.97609   -25.123402  161.64394  ]
[ 67.987206  -17.211044  178.11407  ]
[ 59.18541   -29.42638   113.45152  ]
[ 50.607834  -25.247658  162.74445  ]
[ 40.232018  -26.389929  139.87444  ]
[ 43.883087  -12.911152  128.71432  ]
[ 52.757793   -9.818083  118.044266 ]
[ 46.668602    1.8672419  89.46445  ]
[ 37.637875    6.543922   55.960632 ]
[ 74.69202   -24.63663   159.26927  ]
[ 80.185265  -28.966888  135.4426   ]
[ 77.59874   -25.048712  113.58676  ]
[ 67.36782   -11.659477  113.28664  ]
[ 59.383247   -3.6213398  78.08357  ]
[ 50.41463     3.3975306  44.626457 ]
[ 67.09124   -17.449127  178.04243  ]
[ 66.5356    -20.184196  176.70605  ]
[ 69.91624   -18.523632  178.19987  ]
[ 70.737465  -24.518032  174.94388  ]]]
How do I have to process the data to be able to read the distance to the camera from it?

These are 3D coordinates of person joints (after applying extrinsics they will be in a world coordinate space, before they are in a camera coordinate space, camera is in (0, 0, 0)). So just calculate the distance you need.

These are 3D coordinates of person joints (after applying extrinsics they will be in a world coordinate space, before they are in a camera coordinate space, camera is in (0, 0, 0)). So just calculate the distance you need.

how can I determine the correct extrinsics for my camera?
In the sample file there is once R and t, what do these stand for?

how can I determine the correct extrinsics for my camera?
In the sample file there is once R and t, what do these stand for?

Extrinsics relate coordinate system with center in camera and world coordinate system. Usually one need coordinates in world space (corresponding to some point in the world). So you should set some point, which will be the origin of world coordinate system. Then you just calculate translation of camera center from this point and rotation between axes of world coordinate system and where camera points.

Extrinsics relate coordinate system with center in camera and world coordinate system. Usually one need coordinates in world space (corresponding to some point in the world). So you should set some point, which will be the origin of world coordinate system. Then you just calculate translation of camera center from this point and rotation between axes of world coordinate system and where camera points.

Thanks!

Thanks!


style: 💄 ESLint Stories

Added eslint config for storybook and tests. Fixed existing warnings and errors.
✅ Closes: #850

For some reason npm run lint isn't working in the pipeline but it does locally. Invesigating


train error

Hello, when I trained editablenerf using the training script you provided, the file named k_points_auto_2p.txt was not found. But it doesn't seem to be in the data itself.

Hi, this is a bug caused by the config file, you can change the NerfModel.load_kp_init_file = 'k_points_auto_2p.txt' in editablenerf_2p.gin to NerfModel.load_kp_init_file = 'k_points_auto.txt', or use the one I commit just now.

I have debugged this code of yours before, but when I use the data set capture_dice_cup.zip provided by you, my parameter Settings are as follows, and the program can also run through, I don't know whether the parameter Settings are correct?

In addition, I tried to install the environment package of pip you provided, but the gpu could not be used directly, and finally I used the cpu to run through.
Finally, thank you for your reply！

Yes, the settings are correct. Regarding the environment, it may be a problem with JAX. Have you Installed JAX as in HyperNeRF? And you can also run HyperNeRF to check the environment.

ok, thank you.
thank you for your reply！

Do you get your dataset using the data processing script from https://github.com/google/nerfies/blob/main/notebooks/Nerfies_Capture_Processing.ipynb?
Can you share the original video of your dataset? Or the original video format of capture_dice_cup. I want to learn.
thank you!

Yes. Two minor differences are that a) we skip the step to flatten the video into images and b) we use COLMAP with GUI to check the results.
Images in capture_dice_cup/rgb/1x/ is actually the original inputs. We didn't transform them into video. You can copy them into rgb-raw folder as in HyperNeRF if you want to process it yourself.

ok, thank you.

The data involved in these two evaluation tables are not open source in your provided dataset?

The data involved in these two evaluation tables including Tab1 and Tab2 are not open source in your provided dataset?

Thanks for your notice. This is an issue due to the storage limitation of Google Drive, we will upload them later.

Okay, can you share it with me in advance? I want to see the effect. thank you

Some sequences have been additionally uploaded to EditableNeRF_data/dataset. Please find them here

This error occurred when I ran your GUI_qt.py?

You set it to image_scale=8 by default, but I found that the value of this variable in hypernerf is 4, so I set it to 4, is that right?

The current GUI only supports scenes containing one keypoint. If you want to use GUI, you can try it on dataset/capture_drawer.zip.
For multi-keypoint scenes, you can edit them following the comments in encode_metadata() of evaluation.py

hi, your ablation experiment shown on table3 is executed on capture_drawer?

No, it is on the synthetic data, including syn_drawer.

When I used the data capture_dice_cup provided by you and visualized its point cloud created by colmap and initial key points, I found that the distribution of key points seemed to be inaccurate. Then I would like to ask, will the initial key points be distributed near the two key points at the beginning?

Ok, I'll look into it carefully. Thank you for your reply.


Pivottable update

Lets wait for publishing of pivottable 2.4.0 and update dependency to this version.


Adding a boolean to attributes removes the name of the boolean on nested objects.

+ Attributes
        + anObject (object) - Some Text
            + anArray (array) - Some Text
                + aString: someTextInAString  - Some Text
                + aBoolean:  false (boolean) - Some Text

I would expect booleans to show the name and value just like strings arrays and objects and booleans at higher levels.

Hi @gsigler2,
What you have described is equivalent to the following in JSON:
[
  "aString: someTextInAString",
  false
]

The value of your boolean is set to aBoolean:  false which translates to false because it is not true.
You cannot have key/value pairs directly inside an array. I expect you meant to instead wrap them in a object. Which you can do with the following syntax:
+ Attributes
    + anObject (object) - Some Text
        + anArray (array) - Some Text
             + (object)
                 + aString: someTextInAString  - Some Text
                 + aBoolean: false (boolean) - Some Text

Ahh duh. makes sense.


IndexedDB chunkstore

We should bring this back for people who would like to use Noms persistently in the browser.

i was just thinking this too.
At the moment people use pouchdb and other things to enable offline first apps, but sync back to the server is less than stellar in terms of options, and couchbase is pretty tough to work with IMHO.
Also, the other thing is that as a golang developer i would have two choices for my Desktop and Mobiles apps too. I could use noms compiled with gomobile, with a webview Or IOS / Android Client OR i can use noms purely at the JS level within a webview. Thats a pretty cool bag of tricks to have !
And lastly i can use gopherjs and bind to the JS NOM OR to the golang noms.
I guess you need to abstract a file system into a indexeddb, which is not a huge feat.
Anyway, i want to register my interest in this. It would solve allot of issues and really lots of options.
i can also image noms working really well with a Kappa based architecture too.
http://milinda.pathirage.org/kappa-architecture.com/

js noms is now gone.


Semantic Release

As mentioned in the stream, what do you think of using semantic-release in this repository?
I thought about doing it the following way:

semantic-release to handle automatic publishing on github and npm
commitizen together with cz-conventional-changelog to help with semantic commits
husky to handle pre-commits and commit-msg hooks together with validate-commit-msg.

Hooks could be run optionally by default (opt-in) and therefore be easier for new contributors to actually contribute.
Let me know your thoughts :)

@Apidcloud hey! Thank you for the suggestion. This would improve the collaborator/contributor experience, not to mention my own time that would also be saved. I'm going to put this on the roadmap to work on. ✨
If anyone else wants to pick up this as a task, they are most welcome to.

Just a note, mentioned on the stream. Happy to take these on. I'll start with Husky and maybe a couple of tests.

@mcdonnelldean let me know which of them you are taking on

@Apidcloud Husky is added. I haven't added the others but I'm happy to take a look or I can leave it to you too.

@mcdonnelldean I guess it's better if only one person works on this, as they are all interrelated. Just noticed the husky PR, so you can continue 👍 I'll be happy to help out either way!

@Apidcloud 👍

@Apidcloud So I had a look over both Semantic Release and Commitizen.
I'm gonna go ahead and leave those out of my PR and work. Basically I disagree with both and as such would be the wrong person to add these. That is of course not to say they are bad or wrong or anything like that; it is more I am of the belief things like that make the library harder to maintain for the maintainer as they (the maintainer) tend to have a "flow" that I feel these may interrupt.
With that in mind, it may make sense for you (or somebody else of course) to take a look at both with a view to PRing? For clarity, this is not my Lib, and I am not a major collaborator so please don't take this as a "This is bad, don't do it".
My recommendation is maybe do both on single PR's. While it will be a little ickier for you to do it that way, it will make @noopkat's life easier. Again for clarity, I'm not saying they are bad, I'm saying that I personally find both add maintainer complexity, and as such are not features I personally would like to add.

@mcdonnelldean I've come across them recently, and I think it's really helpful in the sense that besides automating the release process (on both npm and github), it also uses the (semantic) commit messages to produce the change log.
I didn't really explain the idea thoroughly, so I will try to do it below.
Personally, I like to follow git commit message rules (imperative verb and so on), and commitizen makes that really strict. It could also prove to be an extra burden, so the process can be triggered with a commit script (i.e., npm run commit) and not by default on committing.
It would be something to help other people follow the same rules without really having to learn or remember them.
Most of the times I don't really run the script, as I use validate-commit-msg (also with opt-in) on commitmg hook.
But I agree with you: @noopkat should be the one deciding if it's relevant for the repository at all. At the end of the day, those were all suggestions 💃

@Apidcloud Thanks for the additional info.
Yup, to stress, it's not at all that I think they are bad, more that they are things I personally wouldn't add. I still think you should perhaps make some PR's (showing is always better than telling).
@noopkat Did seem to want to at least see these in action. I don't think that has changed. I just wanted to sound out that I didn't want to take those two parts on (I'd rather focus my own efforts on tests and coverage).
Having said that I would like to see the PR's too :D PR's are great ways to convince folk to change their ways :D
I noticed you said that it may make sense to do them all together including Husky. If that's the case please go ahead and do it that way. There is no rush to merge #128 and if it gets superseded by your PR it's all good. My PR is tiny so I won't be offended if something more robust is put in place.

@mcdonnelldean Aight 👍 Husky would just complement it, but it's not really necessary to make it work.

Gonna close this as it's pretty old and in the end I think that some of the frameworks here are now a bit overkill given how small this project still is and the number of contributors currently maintaining the project. Thank you for this work it is still appreciated 😃

Gonna close this as it's pretty old and in the end I think that some of the frameworks here are now a bit overkill given how small this project still is and the number of contributors currently maintaining the project. Thank you for this work it is still appreciated 😃


Import scss from Web Dependencies

It is currently not possible to import scss from Web Dependencies.
Because it is not available in esbuild CLI, scss conversion is done by the web bundled as a pre-step of bundling on all project scss files. In order to support importing scss from Web Dependencies, a solution would be to detect import and convert the given scss (it would require a lot of file processing).
You may upvote this if you feel this is really needed.

This is now working starting from 1.3.0!

Hi @ia3andy
It is not working forn me, could you please let me know if I need to configure anything for importing the scss files from web dependencies like bootstrap (org.mvnpm:bootstrap:5.3.2)


No Synchronisation with my HBCI-Card on Reiner SCT Cyberjack

Windows 10 build 1909 64Bit
Dual XEON E5645 @ 2,40 Ghz / 48 GB Ram
The Logfile is attached.
hs_err_pid10084.log

@aohms Thank for the report. Please try with a recent version of AdoptOpenJDK and, if if fails, with https://adoptopenjdk.net/upstream.html. If either fails, provide a reproducible test case that we can run (public GitHub repository would be great) and that demonstrates that the problem is the JDK, not in some library.
Also, looking at the crash dump, the problem seems to be in hbci4java, not in the JVM.

Closing due to inactivity.


Add [OSSFBestPractices] service badge

Closes #8399

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @miguelnietoa!

  Generated by :no_entry_sign: dangerJS against 2d24ca9a9b4e22ee056ebcf27fe03e4f3fa9c0b4

Hello! 👋

Is there any update on this?

Closing in line with discussion in https://github.com/badges/shields/issues/8399
Sorry you ended up spending time on this one when we already had some badges implemented for this service.


[phpdoc] Page crashes when annotation type is too long

Information:

Prism version: 1.17.1 & 1.19.0
Plugins: language-phpdoc
Environment: Browser

Description
When the php annotation @var is referencing a type with a long name, the page crashes (at least Firefox & Chromium in their latest version).
Example
For example this code snippet will fail (See corresponding jsfiddle)…
<!DOCTYPE html>
<meta charset="utf-8">
<link href="https://cdnjs.cloudflare.com/ajax/libs/prism/1.19.0/themes/prism.min.css" rel="stylesheet" />

<?php
class ProjectCreator
{
    /** @var Git_Driver_Gerrit_ProjectCreator_Factory */
    private $factory;
}

… whereas this code snippet will be ok (See corresponding jsfiddle)
<!DOCTYPE html>
<meta charset="utf-8">
<link href="https://cdnjs.cloudflare.com/ajax/libs/prism/1.19.0/themes/prism.min.css" rel="stylesheet" />

<?php
class ProjectCreator
{
    /** @var Git_Driver_Gerrit */
    private $factory;
}

Best regards,
Nicolas

Seems like I messed up and one of the regexes takes exponential time to fail. I'll publish a fix.
Thank you for reporting!

Thanks for the fix! :+1:


[AutoPR] restapi_auto_resources/resource-manager

Codecov Report

Merging #1934 into master will increase coverage by <.01%.
The diff coverage is 84.9%.

@@            Coverage Diff             @@
##           master    #1934      +/-   ##
==========================================
+ Coverage   53.15%   53.16%   +<.01%
==========================================
  Files        4724     4724
  Lines      117181   117205      +24
==========================================
+ Hits        62293    62316      +23
- Misses      54888    54889       +1

Impacted Files
Coverage Δ

...source/azure/mgmt/resource/policy/policy_client.py
68.05% <70%> (+0.4%)
:arrow_up:

...mgmt/resource/subscriptions/subscription_client.py
92.85% <85.71%> (+0.75%)
:arrow_up:

...t/resource/resources/resource_management_client.py
76.76% <87.5%> (+1.76%)
:arrow_up:

...rce/azure/mgmt/resource/features/feature_client.py
92.85% <90%> (+0.54%)
:arrow_up:

...zure/mgmt/resource/links/management_link_client.py
94.87% <90.9%> (+0.42%)
:arrow_up:

...zure/mgmt/resource/locks/management_lock_client.py
88.63% <90.9%> (+0.83%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1396425...d4cb715. Read the comment docs.

Merge now to remove managementgroups from master.


scikit learn decision tree gets unpickled as dictionary

I am having a problem unpickling scikit-learn deicsion trees. Example code:
import numpy as np
import jsonpickle
import jsonpickle.ext.numpy as jsonpickle_numpy
from sklearn.tree import DecisionTreeClassifier

#  create data
np.random.seed(13)
x = np.random.randint(low=0, high = 10, size = 12)
X = x.reshape(4, 3)
Y = np.random.randint(low=0, high=2, size=4)
Y.reshape(-1,1)

# train model
clf = DecisionTreeClassifier(max_depth=1)
clf.fit(X, Y)

# freeze and thaw
jsonpickle_numpy.register_handlers()
p = jsonpickle.pickler.Pickler()
u = jsonpickle.unpickler.Unpickler()
j = p.flatten(clf)
clf1 = u.restore(json.loads(json.dumps(p.flatten(clf))))

# predict from thawed
xx = np.array([1, 2, 3])
xx = xx.reshape(1,-1)
clf1.predict(xx)

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-15-4e5a1309ca7a> in <module>()
     27 xx = np.array([1, 2, 3])
     28 xx = xx.reshape(1,-1)
---> 29 clf1.predict(xx)

/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/sklearn/tree/tree.pyc in predict(self, X, check_input)
    403
    404         X = self._validate_X_predict(X, check_input)
--> 405         proba = self.tree_.predict(X)
    406         n_samples = X.shape[0]
    407

AttributeError: 'dict' object has no attribute 'predict'

On further inspection, the problem seems to be the following:
print type(clf)
print type(clf1)
print type(clf.tree_)
print type(clf1.tree_)

<class 'sklearn.tree.tree.DecisionTreeClassifier'>
<class 'sklearn.tree.tree.DecisionTreeClassifier'>
<type 'sklearn.tree._tree.Tree'>
<type 'dict'>

i.e. the classifier object gets unpickled as the correct type, while the decision tree under clf.tree_ is getting unpickled as a dictionary. I confirned the same behavior with DecisionTreeRegressor and ensemble methods which use trees , for example GradientBoostingClassifier.

Hi all,
I have exactly the same issue.
Still no suggestions ?
Thanks,
Marios

Would you mind posting the faulty JSON output and also the code used to generate it? That would be illuminating. The most minimal example possible would be highly preferable.

This looks pretty big for an MWE. Is all of it necessary?

Posting a smaller example. Not sure I can make it smaller than this:
`import numpy as np
import json
import jsonpickle
import jsonpickle.ext.numpy as jsonpickle_numpy
from sklearn.tree import DecisionTreeClassifier
create data
X = np.array([0, 1, 2, 3])
Y = np.array([0, 0, 1, 1])
X = X.reshape(4, 1)
Y = Y.reshape(-1,1)
clf = DecisionTreeClassifier(max_depth=1)
clf.fit(X, Y)
freeze and thaw
jsonpickle_numpy.register_handlers()
p = jsonpickle.pickler.Pickler()
u = jsonpickle.unpickler.Unpickler()
j = p.flatten(clf)
clf1 = u.restore(json.loads(json.dumps(p.flatten(clf))))
predict from thawed
xx = np.array([1, 2, 3])
xx = xx.reshape(3,1)
clf1.predict(xx)`
I get a similar ValueError as above. The contents of the j JSON are:
{     "py/object": "sklearn.tree.tree.DecisionTreeClassifier",      "py/state": {         "presort": false,          "splitter": "best",          "tree_": {             "py/object": "sklearn.tree._tree.Tree",              "py/state": {                 "node_count": 3,                  "nodes": {                     "py/object": "numpy.ndarray",                      "dtype": "[('left_child', '<i8'), ('right_child', '<i8'), ('feature', '<i8'), ('threshold', '<f8'), ('impurity', '<f8'), ('n_node_samples', '<i8'), ('weighted_n_node_samples', '<f8')]",                      "values": [                         {                             "py/tuple": [                                 1,                                  2,                                  0,                                  1.5,                                  0.5,                                  4,                                  4.0                             ]                         },                          {                             "py/tuple": [                                 -1,                                  -1,                                  -2,                                  -2.0,                                  0.0,                                  2,                                  2.0                             ]                         },                          {                             "py/tuple": [                                 -1,                                  -1,                                  -2,                                  -2.0,                                  0.0,                                  2,                                  2.0                             ]                         }                     ]                 },                  "values": {                     "py/object": "numpy.ndarray",                      "dtype": "float64",                      "values": [                         [                             [                                 2.0,                                  2.0                             ]                         ],                          [                             [                                 2.0,                                  0.0                             ]                         ],                          [                             [                                 0.0,                                  2.0                             ]                         ]                     ]                 },                  "max_depth": 1             }         },          "n_features_": 1,          "n_outputs_": 1,          "n_classes_": {             "py/object": "numpy.int64",              "dtype": "int64",              "value": 2         },          "max_leaf_nodes": null,          "classes_": {             "py/object": "numpy.ndarray",              "dtype": "int64",              "values": [                 0,                  1             ]         },          "max_features_": 1,          "min_samples_leaf": 1,          "min_samples_split": 2,          "min_weight_fraction_leaf": 0.0,          "criterion": "gini",          "random_state": null,          "min_impurity_split": 1e-07,          "max_features": null,          "_sklearn_version": "0.18.1",          "max_depth": 1,          "class_weight": null     } }
Thanks for looking into this!

Hmm. I'm on mobile so perhaps I'm misreading but (a) I don't see a value
error anywhere; (b) the attribute error I do see posted refers to a dict.
In the posted json the type of tree_ is not dict.
Please post the exact stack trace you get, or confirm that the exception
you see is the attribute error in the very first post in this issue.
Assuming you are getting that attribute error then the issue is on the
unpickling side. Given that, I would love to see what happens when you
unpickle just the tree_ attribute.
On Wed, Jan 25, 2017 at 9:54 PM Nikos Daniilidis<EMAIL_ADDRESS>wrote:
Posting a smaller example. Not sure I can make it smaller than this:
`import numpy as np
import json
import jsonpickle
import jsonpickle.ext.numpy as jsonpickle_numpy
from sklearn.tree import DecisionTreeClassifier
create data
X = np.array([0, 1, 2, 3])
Y = np.array([0, 0, 1, 1])
X = X.reshape(4, 1)
Y = Y.reshape(-1,1)
clf = DecisionTreeClassifier(max_depth=1)
clf.fit(X, Y)
freeze and thaw
jsonpickle_numpy.register_handlers()
p = jsonpickle.pickler.Pickler()
u = jsonpickle.unpickler.Unpickler()
j = p.flatten(clf)
clf1 = u.restore(json.loads(json.dumps(p.flatten(clf))))
predict from thawed
xx = np.array([1, 2, 3])
xx = xx.reshape(3,1)
clf1.predict(xx)`
I get a similar ValueError as above. The contents of the j JSON are:
{ "py/object": "sklearn.tree.tree.DecisionTreeClassifier", "py/state": {
"presort": false, "splitter": "best", "tree_": { "py/object":
"sklearn.tree.tree.Tree", "py/state": { "node_count": 3, "nodes": {
"py/object": "numpy.ndarray", "dtype": "[('left_child', '<i8'),
('right_child', '<i8'), ('feature', '<i8'), ('threshold', '<f8'),
('impurity', '<f8'), ('n_node_samples', '<i8'), ('weighted_n_node_samples',
'<f8')]", "values": [ { "py/tuple": [ 1, 2, 0, 1.5, 0.5, 4, 4.0 ] }, {
"py/tuple": [ -1, -1, -2, -2.0, 0.0, 2, 2.0 ] }, { "py/tuple": [ -1, -1,
-2, -2.0, 0.0, 2, 2.0 ] } ] }, "values": { "py/object": "numpy.ndarray",
"dtype": "float64", "values": [ [ [ 2.0, 2.0 ] ], [ [ 2.0, 0.0 ] ], [ [
0.0, 2.0 ] ] ] }, "max_depth": 1 } }, "n_features": 1, "n_outputs_": 1,
"n_classes_": { "py/object": "numpy.int64", "dtype": "int64", "value": 2 },
"max_leaf_nodes": null, "classes_": { "py/object": "numpy.ndarray",
"dtype": "int64", "values": [ 0, 1 ] }, "max_features_": 1,
"min_samples_leaf": 1, "min_samples_split": 2, "min_weight_fraction_leaf":
0.0, "criterion": "gini", "random_state": null, "min_impurity_split":
1e-07, "max_features": null, "_sklearn_version": "0.18.1", "max_depth": 1,
"class_weight": null } }
Thanks for looking into this!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jsonpickle/jsonpickle/issues/155#issuecomment-275296757,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABLqOOi3rZuHLeFQUPDB1BppNt8P67zeks5rWArzgaJpZM4K9EIK
.

Sorry, that was my bad. The error trace from the latter example is:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/sklearn/tree/tree.py", line 405, in predict
    proba = self.tree_.predict(X)
AttributeError: 'dict' object has no attribute 'predict'

And, indeed, the problem is that the tree_ attribute is getting unpickled as a dict (see also comments on my original post in the thread):
print type(clf1.tree_)
<type 'dict'>

And you are correct about the JSON, I mistakenly posted the result of flattening the classifier itself. After thawing, the JSON is as follows:
j = p.flatten(clf1)
print json.dumps(j, indent=4)

{
    "py/object": "sklearn.tree.tree.DecisionTreeClassifier",
    "py/state": {
        "presort": false,
        "splitter": "best",
        "tree_": {},
        "n_features_": 1,
        "n_outputs_": 1,
        "n_classes_": {
            "py/object": "numpy.int64",
            "dtype": "int64",
            "value": 2
        },
        "max_leaf_nodes": null,
        "classes_": {
            "py/object": "numpy.ndarray",
            "dtype": "int64",
            "values": [
                0,
                1
            ]
        },
        "max_features_": 1,
        "min_samples_leaf": 1,
        "min_samples_split": 2,
        "min_weight_fraction_leaf": 0.0,
        "criterion": "gini",
        "random_state": null,
        "min_impurity_split": 1e-07,
        "max_features": null,
        "_sklearn_version": "0.18.1",
        "max_depth": 1,
        "class_weight": null
    }
}

The tree is an empty dict, it seems.

Ah that's useful, and makes more sense. Can you post what the type of tree_ is and what its state is at the point of taking that pickle? That will really help zero in on the funkiness.

Sure. These are immediately after the clf1 = u.restore(json.loads(json.dumps(p.flatten(clf)))) line:
>>> print type(clf1.tree_)
<type 'dict'>

and the state is:
>>> print clf1.tree_
{u'py/object': u'sklearn.tree._tree.Tree', u'py/state': {u'node_count': 3, u'values': {u'py/object': u'numpy.ndarray', u'dtype': u'float64', u'values': [[[2.0, 2.0]], [[2.0, 0.0]], [[0.0, 2.0]]]}, u'nodes': {u'py/object': u'numpy.ndarray', u'dtype': u"[('left_child', '<i8'), ('right_child', '<i8'), ('feature', '<i8'), ('threshold', '<f8'), ('impurity', '<f8'), ('n_node_samples', '<i8'), ('weighted_n_node_samples', '<f8')]", u'values': [{u'py/tuple': [1, 2, 0, 1.5, 0.5, 4, 4.0]}, {u'py/tuple': [-1, -1, -2, -2.0, 0.0, 2, 2.0]}, {u'py/tuple': [-1, -1, -2, -2.0, 0.0, 2, 2.0]}]}, u'max_depth': 1}}

@nikos-daniilidis I'm interested in type and state before it is pickled, not after it is unpickled.

Before pickling:
>>> print type(clf.tree_)
<type 'sklearn.tree._tree.Tree'>

and
>>> print clf.tree_
<sklearn.tree._tree.Tree object at 0x10697a3d8>

>>> print (clf.tree_.__doc__)

Array-based representation of a binary decision tree.

    The binary tree is represented as a number of parallel arrays. The i-th
    element of each array holds information about the node `i`. Node 0 is the
    tree's root. You can find a detailed description of all arrays in
    `_tree.pxd`. NOTE: Some of the arrays only apply to either leaves or split
    nodes, resp. In this case the values of nodes of the other type are
    arbitrary!

    Attributes
    ----------
    node_count : int
        The number of nodes (internal nodes + leaves) in the tree.

    capacity : int
        The current capacity (i.e., size) of the arrays, which is at least as
        great as `node_count`.

    max_depth : int
        The maximal depth of the tree.

    children_left : array of int, shape [node_count]
        children_left[i] holds the node id of the left child of node i.
        For leaves, children_left[i] == TREE_LEAF. Otherwise,
        children_left[i] > i. This child handles the case where
        X[:, feature[i]] <= threshold[i].

    children_right : array of int, shape [node_count]
        children_right[i] holds the node id of the right child of node i.
        For leaves, children_right[i] == TREE_LEAF. Otherwise,
        children_right[i] > i. This child handles the case where
        X[:, feature[i]] > threshold[i].

    feature : array of int, shape [node_count]
        feature[i] holds the feature to split on, for the internal node i.

    threshold : array of double, shape [node_count]
        threshold[i] holds the threshold for the internal node i.

    value : array of double, shape [node_count, n_outputs, max_n_classes]
        Contains the constant prediction value of each node.

    impurity : array of double, shape [node_count]
        impurity[i] holds the impurity (i.e., the value of the splitting
        criterion) at node i.

    n_node_samples : array of int, shape [node_count]
        n_node_samples[i] holds the number of training samples reaching node i.

    weighted_n_node_samples : array of int, shape [node_count]
        weighted_n_node_samples[i] holds the weighted number of training samples
        reaching node i.

Not sure what else would be helpful here, feel free to ask for specific attributes!

@nikos-daniilidis Can you also print (clf.tree_.__dict__) so I can see the state? Or whatever else is appropriate in case this is using a state tuple or something more exotic.

The state seems to be stored in the __getstate__ method.
>>> clf.tree_.__getstate__()
{'node_count': 3, 'nodes': array([(1, 2, 0, 1.5, 0.5, 4, 4.0), (-1, -1, -2, -2.0, 0.0, 2, 2.0),
       (-1, -1, -2, -2.0, 0.0, 2, 2.0)],
      dtype=[('left_child', '<i8'), ('right_child', '<i8'), ('feature', '<i8'), ('threshold', '<f8'), ('impurity', '<f8'), ('n_node_samples', '<i8'), ('weighted_n_node_samples', '<f8')]), 'values': array([[[ 2.,  2.]],

       [[ 2.,  0.]],

       [[ 0.,  2.]]]), 'max_depth': 1}

The other attributes I find are:
>>> print clf.tree_.__class__
<type 'sklearn.tree._tree.Tree'>
>>> print clf.tree_.__delattr__
<method-wrapper '__delattr__' of sklearn.tree._tree.Tree object at 0x105da4648>
>>> print clf.tree_.__format__
<built-in method __format__ of sklearn.tree._tree.Tree object at 0x105da4648>
>>> print clf.tree_.__getattribute__
<method-wrapper '__getattribute__' of sklearn.tree._tree.Tree object at 0x105da4648>
>>> print clf.tree_.__getstate__
<built-in method __getstate__ of sklearn.tree._tree.Tree object at 0x105da4648>
>>> print clf.tree_.__hash__
<method-wrapper '__hash__' of sklearn.tree._tree.Tree object at 0x105da4648>
>>> print clf.tree_.__init__
<method-wrapper '__init__' of sklearn.tree._tree.Tree object at 0x105da4648>
>>> print clf.tree_.__new__
<built-in method __new__ of type object at 0x105a8e450>
>>> print clf.tree_.__pyx_vtable__
<capsule object NULL at 0x1059e90f0>
>>> print clf.tree_.__reduce__
<built-in method __reduce__ of sklearn.tree._tree.Tree object at 0x105da4648>
>>> print clf.tree_.__reduce_ex__
<built-in method __reduce_ex__ of sklearn.tree._tree.Tree object at 0x105da4648>
>>> print clf.tree_.__repr__
<method-wrapper '__repr__' of sklearn.tree._tree.Tree object at 0x105da4648>
>>> print clf.tree_.__setattr__
<method-wrapper '__setattr__' of sklearn.tree._tree.Tree object at 0x105da4648>
>>> print clf.tree_.__setstate__
<built-in method __setstate__ of sklearn.tree._tree.Tree object at 0x105da4648>
>>> print clf.tree_.__sizeof__
<built-in method __sizeof__ of sklearn.tree._tree.Tree object at 0x105da4648>
>>> print clf.tree_.__str__
<method-wrapper '__str__' of sklearn.tree._tree.Tree object at 0x105da4648>
>>> print clf.tree_.__subclasshook__
<built-in method __subclasshook__ of type object at 0x105a8e450>

Perfect, thank you!

What was the resolution to this issue?

This was originally fixed in #170 which was first released in jsonpickle v0.9.5 (July 2017), but I just added a test case to ensure that it works forevermore.  We're currently at v1.5.0.

This was originally fixed in #170 which was first released in jsonpickle v0.9.5 (July 2017), but I just added a test case to ensure that it works forevermore.  We're currently at v1.5.0.


Won't actually turn on

When I try and use the plugin I get a message about downloading the cache, thats as far as I get. Any ideas?

same


Adding $FWDPROXY_CURL environment variable for curl

Adding $FWDPROXY_CURL environment variable for curl allows download and installation of fzf dependencies through company internet proxies.

Why not use $http[s]_proxy?

FWDPROXY_CURL would include e.g. -p -x --resolve --proxy-cert --proxy-key proxy parameters for curl. Setting https_proxy does not work if you need --proxy-cert or --proxy-key


Fixing stdout/stderr mixup in tsan tests.

@swift-ci please smoke test and merge

@swift-ci please smoke test and merge

@swift-ci please smoke test and merge


Moving EA slider on cleared screen after clicking Enter button causes crash

On cleared screen, clicking either "Enter" button sets some condition that causes crash when any slider except the IPv4 Host slider is moved.
One possible fix would be to change the range of all sliders to "0, 0" on startup and clear like is already done for the IPv4 Host slider.

Disable all sliders on "Clear" or when window is first displayed.
Enable sliders when values are displayed.

Updated to v0.10.8


Clean up images

The app is starting to balloon in size (25MB). Complete this ticket after #180

Remove all unused images
Add missing image sizes (0.5x, 0.75x, 1x, 1.5x, 2x, 3x, 4x)

#309 will move lots of images to icons, reducing overhead.
This should be done after that.

#451 will handle this