Question: Custom Error Types

Hello @auxten as far as I understand we get the default Error type when there is an error in chdb.
Recently I faced a situation where I got a message with the following message:
Code: 57. DB::Exception: Directory for table data data/default/testtable/ already exists. (TABLE_ALREADY_EXISTS)

Currently I don't have an easy way to know if the error was because I was trying to create already existing table. I could figure out this if I was doing string search for TABLE_ALREADY_EXISTS.
I suppose that it's a lot of work but what do you think about the idea to have something like this in the near future:
try {
  session.query("CREATE TABLE testtable (id UInt32) ENGINE = MergeTree() ORDER BY id;");
} catch (err) {
  if (err instanceof TableAlreadyExists) {
    // Do something
  } else if (err instanceof SyntaxError) {
    // Do something
  } else {
    throw err; // unknown error, re-throw
  }
}

There are more than 700 error types in ClickHouse engine.
https://github.com/chdb-io/chdb/blob/fix-global-import/src/Common/ErrorCodes.cpp#L16
So, I think just make it simple string is good for maintenance.

I see @auxten
This probably doesn't bring much value to the project at the moment.
However, out of curiocity I have the following question: Wouldn't it be possible to have CHDB specific errors in an automated way as here we can see a patter how the ERROR CODES are being defined: https://github.com/chdb-io/chdb/blob/fix-global-import/src/Common/ErrorCodes.cpp#L16
...

I am not a C++ expert but I suppose I could help in the future if you as a maintainer would like to have custom errors. I probably will need some guidance on the C++ side of course.


Dependent queries are not working with tanstack query

Convex query is executed even if the enabled condition is not met.
  const { fetchStatus, data: ordersResponse, isError, isPending: isOrderPending, isSuccess } = useQuery({
    ...convexQuery(api.orders.getOrdersByCartIds, { cartDocIds: cartDocIds ?? [], fetchProducts: true }),
    enabled: !!cartDocIds?.length,
  });

Query
export const getOrdersByCartIds = zQuery({
  args: {
    cartDocIds: z.array(zid(CollectionNameEnum.enum.shopping_carts)).min(1),
    fetchProducts: z.boolean().optional(),
  },
...

Below is the error
Uncaught ConvexError: {"ZodError":[{"code":"too_small","minimum":1,"type":"array","inclusive":true,"exact":false,"message":"Array must contain at least 1 element(s)","path":["cartDocIds"]}]}

https://tanstack.com/query/latest/docs/framework/react/guides/dependent-queries

For anyone looking for a workaround, you can use the non-TanStack hook useConvexQuery():
  const ordersResponse = useConvexQuery(
    api.orders.getOrdersByCartIds,
    !!cartDocIds?.length ? { cartDocIds: cartDocIds ?? [], fetchProducts: true }) : "skip"
    // "skip" is a special value that causes the query not to run https://docs.convex.dev/client/react#skipping-queries
  });

We should support this though, shouldn't be hard.

Why not just this method below?
const convex = useConvex();
// later
const result = await convex.query(api.asd);

The dependent queries @Irutom wants here are still reactive, just off sometimes when the arguments aren't available.

This works for "skip" now, but not enabled: false

@thomasballinger Could you clarify whether you’re referring to tanstack’s useQuery or convex’s useConvexQuery()? An example would be helpful for better understanding.

@Irutom here's an example https://github.com/get-convex/convex-react-query/blob/9362c619f2fb37d1a825dd5e513536bd4d6130fc/src/example.tsx#L72


Odd/incorrect behavior with allowJs and incremental flags.

Bug Report
🕗 Version & Regression Information
Reproducing on v4.2.3. Have not checked previous versions.
⏯ Playground Link
I could not reproduce the exact behavior in Playground, only in the command line.
💻 Code
Contents of src/foo.js. Contains some odd code intentionally (but syntactically correct).
/** @typedef {{foo:string}} */
Foo.Bar;

/** @interface */
export class MyInterface {
  /** @type {!Foo} */
  get entry() {}
}

Contents of tsconfig.json
{
  "compilerOptions": {
    "module": "ESNext",
    "target": "ESNext",
    "noEmitOnError": true,
    "pretty": true,

    "rootDir": "src",
    "outDir": "tsc",
    "allowJs": true,

    "incremental": true,
    "tsBuildInfoFile": "tsconfig.tsbuildinfo"
  },
  "files": [
    "src/foo.js"
  ]
}

🙁 Actual behavior
Invoking the TS compiler (with tsc -p tsconfig.json --listEmittedFiles)  results in the following output
error TS2355: A function whose declared type is neither 'void' nor 'any' must return a value.

TSFILE: /path/to/tsc_bug/tsconfig.tsbuildinfo

Found 1 error.

Invoking a 2nd time with the same command, yields the same error, but also produces foo.js in the output dir.
error TS2355: A function whose declared type is neither 'void' nor 'any' must return a value.

TSFILE: /path/to/tsc_bug/tsc/foo.js
TSFILE: /path/to/tsc_bug/tsconfig.tsbuildinfo

Found 1 error.

Invoking a 3rd time the same command produces no output at all (tsc succeeds I suppose). The whole cycle can be repeated by deleting the tsconfig.tsbuildinfo file.
If the incremental flag is removed, then no error is reported at all (no matter how many times it is invoked).
🙂 Expected behavior
The behavior of the TypeScript compiler is very odd, describing below:

Reports an error in a JS file, only when incremental is set. Succeeds if incremental is not set, which is inconsistent, but also wrong.

Expected: No error should be reported as checkJs is off in both cases.

When incremental is set, invoking the compiler a 2nd time, produces an output file even though an error is still shown.

Expected When there are errors, an incremental build should fail the same way every time.

The error does not include the filename or line number, which makes it extremely hard to debug in a large codebase (unlike this minimal repro).

Expected The error (even though bogus IMO) should include the filename and line number, to help debugging.
Note
Changing the JSDoc annotation from @type to @return bypasses the issue, but that is besides the point here (there should be no JS type checking when checkJs is false).

I'll investigate later, but allowJS turns on checking; checkJS controls whether errors are reported or not.

This doesn't repro in 4.3. I tested 4.3 first and then 4.2.


RI: Account Explorer - Enhancements

Closing this Epic. It isn't well enough defined to be useful, and all work in it is complete.


assert connection does not seem to function properly

When there is 2 minutes or more between each emitter event, the connection seems to time out that should have been handled by _assert_connection
Example
Emitting metrics
Sleeping for 60 seconds
Emitting metrics
Sleeping for 90 seconds
Emitting metrics
Sleeping for 120 seconds
Emitting metrics
No handlers could be found for logger "logmet"
Traceback (most recent call last):
File "testclient.py", line 28, in
lm.emit_metric(name='logmet.test.1', value=1)
File "pylogmet/logmet/init.py", line 122, in emit_metric
self._send_metric(metric_msg)
File "pylogmet/logmet/init.py", line 158, in _send_metric
self.socket.sendall(metrics_package)
File "/usr/lib/python2.7/ssl.py", line 329, in sendall
v = self.send(data[count:])
File "/usr/lib/python2.7/ssl.py", line 298, in send
v = self._sslobj.write(data)
socket.error: [Errno 32] Broken pipe

I wonder if Logmet changed something on their end, because it looks like its not sending the FIN packet which leaves a few bytes on the incoming socket queue that the select() is supposed to pick up and rebuild the connection if it sees.
I will look into this more, and probably add a backup "just try it and get a new connection if it fails" type of reconnect as well.

@hassenius can you try commit 18b40fbba (the latest on master) and see if that fixes the issue you are seeing?

Yup, not getting any timeouts after this
Cheers!


Add Deno Deploy using deployctl to Deploy docs

What kind of changes does this PR include?

[ ] Minor content fixes (broken links, typos, etc.)
[ ] New or updated content
[ ] Translated content
[x] Changes to the docs site code
[ ] Something else!

Description
Add Deno Deploy documentation in the Deploy section.
Inspired on: https://www.elian.codes/blog/22-05-06-deploying-astro-on-deno/

@delucis Updated the docs with your changes!

Thanks for this @ElianCodes 🎉


Idoly Pride

Game: Idoly Pride
Website: https://idolypride.jp/game/
Platform: Android
Unity Version: 2020.3.4f1
Can't load animation files from game.
mot_live_chr_cmn_hsm-002_04_in.zip

Unity 2020+ is not supported.

I can't promise that it will work for higher versions, but support for Unity versions up to 2020.2.0 has been recently added to my AssetRipper fork.

I can't promise that it will work for higher versions, but support for Unity versions up to 2020.2.0 has been recently added to my AssetRipper fork.

it works now


Skip forward/backward for watching youtube/udemy tuts :D

Please provide two buttons for skipping backward/forward for watching YouTube/Udemy Tutorials. It would help so much, hope you guys understand. 👍

In youtube, if playing with queue or playlist it will show

@41y08h This is possible to do with my extension, Global Speed.  Demo below.
https://www.youtube.com/watch?v=EZA-TnVAyDo

@41y08h This is possible to do with my extension, Global Speed. Demo below.
https://www.youtube.com/watch?v=EZA-TnVAyDo

Seems really powerful! I'll try it when I'll be watching tuts for quite a few days in a row again.
Thanks for letting me know.
🤩


Update and code fix

Interesting, recovery as of Dec 15 not very pronounced. I wonder what mid-Jan will bring

@eread-usgs can you run the jenkins job?


Improve signup page UX

Refactor it into a multi step form. Where the first step consists of the QR scanning and the second one of the data inputs themselves.

Add descriptive error messages (safira should send them).

There should be a close button on the QR scanning window.

@ruilopesm Please assign this to me

@pravintargaryen Assigned. Thanks for wanting to contribute.


Support colon and special character for tailwind

Hello
I believe this issue should have handled in different way
.relative.sm:pb-16.md:pb-20.lg:pb-28

Now it is converted to

  <pb-16 class="md">
    <pb-20 class="lg">
      <pb-28>
      </pb-28>
    </pb-20>
  </pb-16>

But it should be converted to

Similar to https://github.com/slim-template/slim/pull/841

Thanks @AbdullahDahmash! @Rakoth or I will try to get to this in the not-so-distant future but if you'd like to give it a whirl PRs are welcomed :tada:

@doomspork I'm new to elixir, can you give me hint where should I start?


Admin API: Cancel deletion process as support

Readiness checklist

[X] I added/updated unit tests.
[ ] I added/updated integration tests.
[X] I ensured that the PR title is good enough for the changelog.
[X] I labeled the PR.

Description
Implemented the cancelling of a deletion process as support.

Backbone part of the task is complete and handed over to UI developer.

@stamenione Why is the whole identity folder inside of the quotas folder?

Also: there is again a path problem on my machine, when I try to checkout your branch:

Can you try to reduce the length of the path somehow?

@stamenione Why is the whole identity folder inside of the quotas folder?
Also: there is again a path problem on my machine, when I try to checkout your branch:
Can you try to reduce the length of the path somehow?

I honestly don't know that is how the project was structured before i got to work on it.
I can by moving it outside the quota folder.

@NikolaVetnic I don't see any Domain tests.

Changes made.


SCP File Download does not work

This test does not work.
tests/test_scp.nim
import asyncdispatch, ssh2, ssh2/scp

proc main() {.async.} =
  var client = newSSHClient()
  defer: client.disconnect()
  await client.connect("<IP_ADDRESS>", "nim", Port(2222), password="secret")
  let scp = client.initSCPClient()
  await scp.uploadFile("LICENSE", "/tmp/LICENSE")
  await scp.downloadFile("/tmp/LICENSE", "TEST")

waitFor main()

Error
Traceback (most recent call last)
test_scp.nim(11)         test_scp
asyncdispatch.nim(2022)  waitFor
asyncdispatch.nim(1711)  poll
asyncdispatch.nim(1452)  runOnce
threadimpl.nim(269)      processPendingCallbacks
test_scp.nim(9)          main (Async)
scp.nim(55)              downloadFile (Async)
SIGSEGV: Illegal storage access. (Attempt to read from nil?)
Segmentation fault

Double checked, whether the uploaded file exists. Yes, it does exist.

can you gimme some coredump?

can you gimme some coredump?

If you tell me what exactly I need to run, I will probably just run it and give you the output, if it helps. 🙂


fix crd output example

Related: https://github.com/kubernetes/kubernetes/pull/62443

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For 1.11 Features: set Milestone to 1.11 and Base Branch to release-1.11
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
NOTE: After opening the PR, please un-check and re-check the "Allow edits from maintainers" box so that maintainers can work on your patch and speed up the review process. This is a temporary workaround to address a known issue with GitHub.>
Please delete this note before submitting the pull request.

/lgtm

tested that this also works for release 1.10

👋 We've migrated the site's framework to Hugo. Please re-open this PR with changes to files in their post-migration location (/content/en/docs/...) and reference this PR in the new PR's description.

/open

We've migrated the site's framework to Hugo. Please re-open this PR with changes to files in their post-migration location (/content/en/docs/...) and reference this PR in the new PR's description.

Done


Digest authentication support

[Feature Request]
Could this be a possibility?
Sending over a password in plaintext is something I don't really like.

To add in, digest authentication is sending a hash consisting of;
(Bash)
htdigest_hash=`printf $username:$AUTH_REALM:$rand_pw | md5sum -`
echo "$username:$AUTH_REALM:${htdigest_hash:0:32}"

Yes. I will look into it.

And this would solve your TODO "Support encrypted passwords" ;-)
Thank you.


Ollama fix

github actions failed with a lint error for llama.ts for unused variable
security.md failed to pass the commit call out - had to do reformatting

these updates go along with PR:   https://github.com/ai16z/eliza/pull/521

did you want to include this in your PR?

did you want to include this in your PR?

The llama.ts - yes,  the security.md I had to fix because the git commit callout wouldn't let me commit the other fix without fixing that.  Somehow it got passed the previous PR that other person that put that file in.  :-(


[WDS] Disconnected! with option set to HTTPS

I am using the new HTTPS option to test locally from https browser to https server.
the comunication between client and server works but i get an error in the browser console>
abstract-xhr.js:132 GET https://localhost/sockjs-node/info?t=1472999253306 net::ERR_CONNECTION_REFUSEDAbstractXHRObject._start @ abstract-xhr.js:132(anonymous function) @ abstract-xhr.js:21
client:70 [WDS] Disconnected!sock.onclose @ client:70EventTarget.dispatchEvent @ eventtarget.js:51(anonymous function) @ main.js:356

HMR not working.

@dceddia Can I ask you to investigate this?

@gaearon Taking a look...
I can reproduce it locally against 0.4.1. However, I don't see this error with 0.3.0-alpha (which is where I originally tried out this HTTPS feature and used it successfully for a couple weeks). Maybe something changed with the how socket connection works?

It looks like it has something to do with how the webpack-dev-server client determines the URL. In v1.15.1:
https://github.com/webpack/webpack-dev-server/blob/v1.15.1/client/index.js#L62
protocol: (window.location.protocol === "https:" || urlParts.hostname === '<IP_ADDRESS>') ? window.location.protocol : urlParts.protocol,

In v1.14.1:
https://github.com/webpack/webpack-dev-server/blob/v1.14.1/client/index.js#L62
protocol: urlParts.protocol,

Changing that one line to the old protocol: urlParts.protocol fixes this issue. That's not terribly helpful for us though, since there doesn't seem to be any way to influence how that protocol is decided.
@gaearon Sorry for letting this slip through. Would you like me to file an issue with webpack-dev-server? Can you see another way around it?

Please file an issue with WDS. We can release a path that rolls our version of it back if this takes time to fix.

Per my comment on #263 (sorry for misposting that), I've fixed this locally by changing this line in config/webpack.config.dev.js:
require.resolve('webpack-dev-server/client') + '?/',
to
require.resolve('webpack-dev-server/client') + '?http://<IP_ADDRESS>:0/',
Based on my understanding of the WDS code, this will configure the client to use the current window's protocol, hostname, and port.
A point of interest is that I was not seeing the initial connection going through at all until I made this change.  Though, afterwords, everything is working correctly.

Nice, that fixes it for me too.
I was worried that it might break hostnames other than localhost, so I tried giving my machine an alias of devtest in /etc/hosts -- everything seems to work fine. Also tested with <IP_ADDRESS>. I can't think of any other negative side-effects this change would have, besides it feeling like a hacky workaround for a WDS bug.
I could make a PR if we want to get the fix in though, thoughts?

It was <IP_ADDRESS> at some point but I changed it because something else broke. I don't recall what though.

It looks like Webpack won't get this fix until v2 unfortunately, so maybe
we should roll back to 1.14.1 for the time being, if that's an option:
https://github.com/webpack/webpack-dev-server/issues/592#issuecomment-246613807
On Tuesday, September 6, 2016, Dan Abramov<EMAIL_ADDRESS>wrote:

It was <IP_ADDRESS> at some point but I changed it because something else
broke. I don't recall what though.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebookincubator/create-react-app/issues/574#issuecomment-245032683,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAe3aGNsHbhkzJM6U6Et6qJUpZTo4nIEks5qnagTgaJpZM4J0jGM
.

Hi, webpack-dev-server maintainer here. Reverting to 1.14.1 would probably cause other issues to come up again (e.g. #134), so would probably not be worth it.
I've changed my mind about this a bit, since I don't know when v2 will get stable, and this seems to be a blocking issue for some people.
If someone wants to backport the fix to v1, I'll merge the PR and release a new version. Don't have time to do it myself currently.
PS: also said this in the ticket mentioned above, but saying it here for visibility :smile:.

I just released<EMAIL_ADDRESS>with the fix for this. Thanks for the help @dceddia.

Awesome, thanks @SpaceK33z. I just tried it out - it seems to fix this issue :)
@gaearon I created a PR to bump the dependency up to 1.15.2.

This should be fixed in 0.4.2.
Please verify!

Yes it works! Good job.


Update Continuous Integration to ZooKeeper 3.5.3-beta

Currently, .travis.yml uses the to-be-released ZOOKEEPER_VERSION=3.5.2-alpha. The current release (as of 2017-08-24) of the 3.5 line is 3.5.3-beta. Unless there is some motivation to continue to test against the old ZK server, .travis.yml should be updated to use the newer version.

Great idea!
Pull request welcome if you want to update it. Otherwise I'll try to do it in the next week or so.

So this is somewhat annoying...it seems that the file fetched in ensure-zookeeper-env will be zookeeper-3.5.3-beta.tar.gz. Despite the .tar.gz file suffix, it is actually a non-gzipped tarball, which makes the tar -zx fail. Changing this to tar -x works, but of course breaks all the properly-compressed files. Aside from opening a bug against ZK's packaging, I'm not sure what to here.

Ugh, that's no fun.
Can you open a ticket on the Zookeeper Jira and link back to it here?
Generally I've found that team is reasonably responsive, especially to something like this which sounds like a very annoying packaging bug that is likely to bite a lot of folks.

Bug is ZOOKEEPER-2885. Hopefully I'll get an email when it's fixed.

It's marked as fixed, but the file hasn't propagated out to everywhere...there's some likelihood that it will not ever in a lot of mirrors, since people usually expect artifacts to be permanent.

Is it still breaking on travis? That's really the point here, so if it's just their cache that needs updating I can file a bug there...

Yeah...3.5.3 is beta anyway :-)


[SILOptimizer] Ignore duplicate conditions when optimizing switch statement

Explanation: Having a switch case statement containing duplicate conditions has always been broken when optimizations are enabled. We haven't encountered this issue before since writing such code is a bad practice. SimplifyCFG used to add the same case / condition twice in select_value, causing the compiler to crash during verification. the bug was resolved by adding a check that makes sure we don't add the same case more than once.

Scope: Affects any code with switch statements containing duplicate conditions, preventing a compilation failure when optimizations are enabled.

Issues: rdar://problem/28057990 https://bugs.swift.org/browse/SR-2512

Reviewed by: @eeckstein

Risk: Low; the "new" code fixes a bug in the SimplifyCFG optimization, thus preventing a compiler crash that always occurred with the following code patten in -O mode:

public enum DemoEnum {
	case firstCase
	case secondCase

	public static func performSwitch(with value: Int) -> DemoEnum {
		switch value {
		case 0:
			return DemoEnum.firstCase
		case 0:
			return DemoEnum.firstCase
		default:
			return DemoEnum.secondCase
		}
	}
}

Testing: Added compiler regression tests, verified that the originally reported case now works.

@swift-ci Please test


Readme in pub.dev is not displaying the images

Solved using Github CDN by uploading them to comment and getting the link

Modified image


Kiwi.Geom.Intersect.LineToRawSegment working incorrectly.

LineToRawSegment algorithm is incorrect. Will always return the true when the rawSegment is a verticle line. How this occurs:
When using Kiwi.Geom.Intersect.lineToRectangle ( or  ( ray || lineSegment )ToRectangle ) the intersect result will always be true.
From my investigation I have identified the the problem occurs ( either first or only on ) where the left hand side of the rectangle calculation is being done on the Kiwi.Geom.Intersect.lineToRectangle function.
The left hand side of the box is correctly being identified so the problem is with the line intersect algorithm itself.

You can see an example of this not working is in the example repo. It will not be displayed on the main page but the files will be visible inside of the 'geom' folder. To enable them you can do this from the kwi-example-main.js file inside of the 'kiwi-examples/examples/_site/js/' folder. See line 43.

Intersect fixes include:

lineToRawSegment now requires both X and Y coordinates of intersection to be within segment span.
New lineSegmentToRawSegment() method (technically an API expansion, but necessary for these fixes).
lineSegmentToCircle now checks for intersection success rather than intersect object (which might not have succeeded) in worst case scenario.
lineSegmentToRectangle now uses lineSegmentToRawSegment() for better results, and returns an intersect point equal to the centroid of the line if the line is entirely within the rectangle.

Line fixes include:

Can now deal with points on (0,0), and accelerates vertical lines.

This ensures that several intersection methods now operate more robustly and as predicted.
A more robust check of all the Geom.Intersects methods, using horizontal and vertical lines, may be called for.


Add ability to create policy with shrink action

added all classes needed for shrink action - every class but ShrinkActionConfig.kt and ShrinkAction.kt are currently stubs
modified opendistro-ism-config.json and opendistro-ism-history.json to reflect the new shrink data in the mappings

CheckList:
[ ] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #101 (5cf1831) into development-shrink (e246c82) will decrease coverage by 1.31%.
The diff coverage is 10.47%.

@@                   Coverage Diff                    @@
##             development-shrink     #101      +/-   ##
========================================================
- Coverage                 78.09%   76.78%   -1.32%
+ Complexity                 1882     1877       -5
========================================================
  Files                       255      262       +7
  Lines                     10378    10565     +187
  Branches                   1534     1562      +28
========================================================
+ Hits                       8105     8112       +7
- Misses                     1445     1619     +174
- Partials                    828      834       +6

Impacted Files
Coverage Δ

...gement/indexstatemanagement/action/ShrinkAction.kt
0.00% <0.00%> (ø)

...statemanagement/model/action/ShrinkActionConfig.kt
0.00% <0.00%> (ø)

...temanagement/step/shrink/AttemptCheckConfigStep.kt
0.00% <0.00%> (ø)

...atemanagement/step/shrink/AttemptMoveShardsStep.kt
0.00% <0.00%> (ø)

...exstatemanagement/step/shrink/AttemptShrinkStep.kt
0.00% <0.00%> (ø)

...atemanagement/step/shrink/WaitForMoveShardsStep.kt
0.00% <0.00%> (ø)

...exstatemanagement/step/shrink/WaitForShrinkStep.kt
0.00% <0.00%> (ø)

.../indexstatemanagement/model/action/ActionConfig.kt
82.71% <33.33%> (-1.90%)
:arrow_down:

...ent/model/managedindexmetadata/ActionProperties.kt
88.13% <76.00%> (-9.24%)
:arrow_down:

...nt/indexstatemanagement/model/destination/Slack.kt
40.90% <0.00%> (-13.64%)
:arrow_down:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e246c82...5cf1831. Read the comment docs.


Fix systemd error when enabling sushy

Description
When enabling sushy.service using lab-sushy.sh, systemd complains because the systemd unit does not have an Install section.
Type of change
Please select the appropriate options:

[X ] Bug fix (non-breaking change which fixes an issue)

:tada: This PR is included in version 1.1.13 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Jaxws-ri try to reach always http not https

Hi I use openjdk and jaxws-maven-plugin to generate my wsdl.I can generate my wsdl and I want to use jaxwsri.My problem is in my wsdl there is a part with http:myservice in definition.I want to force it to https://myservice but when I check HttpURLConnection class it always try to reach http address.How can I force my call to https?
        QName qname2 = new QName("http://myschemas", "MyServiceImpl");
        MyServiceImpl service=new MyServiceImpl(new URL("https://myservice.svc?wsdl),qname2);
        Service service = MyServiceImpl .create(new URL("https://myservice.svc?wsdl), qname2);
        MyService reply=   service.getPort(MyService.class);
        MyResponse response=  reply.myRequest(request);

com.sun.xml.ws
jaxws-ri
2.3.2

sth like following should help:
MyService reply =   service.getPort(MyService.class);
((BindingProvider) reply).getRequestContext()
    .put(BindingProvider.ENDPOINT_ADDRESS_PROPERTY, "https://myservice.svc");
MyResponse response=  reply.myRequest(request);

sth like following should help:
MyService reply =   service.getPort(MyService.class);
((BindingProvider) reply).getRequestContext()
    .put(BindingProvider.ENDPOINT_ADDRESS_PROPERTY, "https://myservice.svc");
MyResponse response=  reply.myRequest(request);

you made my day sir, thanks


bug when auditing service id

There's an error in current audit handler
class com.networknt.server.ServerConfig cannot be cast to class java.util.Map (com.networknt.server.ServerConfig is in unnamed module of loader 'app'; java.util.Map is in module java.base of loader 'bootstrap')
at com.networknt.config.Config$FileConfigImpl.getJsonMapConfig(Config.java:301)
at com.networknt.config.Config$FileConfigImpl.getJsonMapConfig(Config.java:343)
at com.networknt.audit.AuditHandler.auditServiceId(AuditHandler.java:285)
at com.networknt.audit.AuditHandler.handleRequest(AuditHandler.java:127)
this happens when getting server's config

I think I had encountered the same issue before. This is due to the config cache in the same process with ServerConfig object already. If we want to load the config in a map, we need to use NoCache. Take a look at this line of the code to get it fixed.
https://github.com/networknt/light-4j/blob/master/client/src/main/java/com/networknt/client/Http2Client.java#L131

I think I had encountered the same issue before. This is due to the config cache in the same process with ServerConfig object already. If we want to load the config in a map, we need to use NoCache. Take a look at this line of the code to get it fixed.
https://github.com/networknt/light-4j/blob/master/client/src/main/java/com/networknt/client/Http2Client.java#L131

yes, I made the code change and tested, but was facing some unrelated build issue, will create a PR once fix the build issue.

The test case issue with portal-registry and consul has been fixed already and the master branch is clean. You can try that again. Thanks.

 bug when auditing service id light-4j master

 bug when auditing service id light-4j 1.6.x


errorS at training

i am using tensorflow/-gpu 1.14.0, keras 2.3.0 and cuda 10.1
training on 5 images of the kangaroo with the notations from the git repo.
mini-batch=1  and using the backend.h5 at the training.
list of the errors:-
===========================================================
1)OOM, out of memory when using mini-batch>1.
Limit:<PHONE_NUMBER>
InUse:<PHONE_NUMBER>
MaxInUse:<PHONE_NUMBER>
NumAllocs:                   11629
MaxAllocSize:            743192064
2)Traceback (most recent call last):
File "D:/keras-yolo3-master/keras-yolo3-master_2/train.py", line 324, in
main(args)
File "D:/keras-yolo3-master/keras-yolo3-master_2/train.py", line 312, in main
average_precisions = evaluate(infer_model, valid_generator)
File "D:\keras-yolo3-master\keras-yolo3-master_2\utils\utils.py", line 48, in evaluate
pred_boxes = get_yolo_boxes(model, raw_image, net_h, net_w, generator.get_anchors(), obj_thresh, nms_thresh)[0]
File "D:\keras-yolo3-master\keras-yolo3-master_2\utils\utils.py", line 262, in get_yolo_boxes
do_nms(boxes, nms_thresh)
File "D:\keras-yolo3-master\keras-yolo3-master_2\utils\utils.py", line 166, in do_nms
if bbox_iou(boxes[index_i], boxes[index_j]) >= nms_thresh:
File "D:\keras-yolo3-master\keras-yolo3-master_2\utils\bbox.py", line 57, in bbox_iou
return float(intersect) / union
ZeroDivisionError: float division by zero
when i print the value of the union it's equal to zero !!! how can union =0?
==========================================================
can you help me and thanks in advance >:^) .

Hi @AhmedHessuin , How did you manage to solve it?

the dividing over inf was solved from  bbox.py  changing intersected / union to
if intersected = 0
return 0
else
return intersected / union
and i beleive it  was my bad ( i think i didn't have label for every object )
for some reason when i use valid files with 10 anno and want to valid on 5 anno it cause an error .


Revert electorn-authorization version bump

Revert @itwin/electorn-authorization package.json version bump
Re run rush change with appropriate type and comment
Revert 'offline_access' changes

Revert @itwin/electorn-authorization package.json version bump
Re run rush change with appropriate type and comment
Revert 'offline_access' changes


algoliasearch reindex failed

Exit without error status but only end with ** Enrich xxxxx/yyyy, tried 2 times, seems it didn't push and commit the result.

Hmmm, let me try that.

It's working from here: I've just reindexed everything. Any chance your GitHub token used to enrich the libraries has been revoked?

Hi @redox, thanks for your fast reply, in fact, I was trying to do the same thing as you - reindex on another server, and it works very well, so I'm going to check what's wrong on the main building server, let's leave issue opened until I fix it, thanks for your help again :+1:

BTW, same GitHub token :smile:

It works now ... though I didn't change things, maybe it's my server's problem.

:+1: Good news then, I like those issues resolving alone :)


Add support for nesting nuxt apps

What problem does this feature solve?
This feature should make it possible to use an external nuxt app within another nuxt app.
The ultimate goal, but that would require more changes than just this one, would be to be able to use Nuxt in an extendible (legacy) app that supports add-ons without the need for regenerating/building nuxt. To explain by example, take a look at https://github.com/nextcloud/server. Quite some nextcloud apps use Vue for rendering the app, see eg accessibiility and oauth2. Currently those apps implement their own Vue/VueRouter instance (and build environment etc), so that means navigating between apps requires a full page reload.
Although this would require some preconditions as same app template and vue-meta config, it would be nice if we could leverage the power of Nuxt's build environment for those add-ons. Thus eg nextcloud/server implements a single Nuxt/Vue/VueRouter instance and the nextcloud apps can extend that instance in a way that for the end-user installing an add-on is still as simple as copying some data and indicating that add-on should be enabled.
What does the proposed changes look like?
Something like this:
/nested-app/
/nested-app/nuxt.config.js
/nested-app/package.json
/nested-app/pages/index.vue
...
/main-app/
/main-app/nuxt.config.js
/main-app/package.json
/main-app/pages/index.vue
...

with /main-app/nuxt.config.js containing (at the very basic):
import nestedApp from 'nested-app-package'

...
    extendRoutes(routes, resolve) {
      routes.push(
        nestedApp.createNestedApp()
      )
    }

This feature request is available on Nuxt community (#c7784)

Looks a bit like https://github.com/nuxt/nuxt.js/issues/1795

Yes, with the exception that that issue seems more about just the pre-building phase and this is (at least with regards to the ultimate goal) about post-building.


Add the ability to add comments to code

I want to be able to make comments. Prefix suggestions:
~
--
//
#
!

This might be difficult because to the way it reads the code,it should be line by line but is not. I will add them but they'll be a bit weird

ah, I understand.
maybe start line by line, then read each line char by char, it will be easier to refactor that way


"Săhăteni" is listed in the drop-down menu

Description:
"Săhăteni" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Săhăteni" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Săhăteni, BUZĂU".


Shepherding control campaign

Description

Add the Shepherding Control Campaign
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

It has been tested on my local machine

Screenshots/Videos (if appropriate):
https://www.loom.com/share/ae11c9e4b92f4b759e88490ec36af065

@ahadziii so

I need icons on these pages

I think the wording here is a whole mess. @dabick14 @ahadziii

What we need is

Average Weekly Bussing Attendance
Average Weekly Weekday Attendance
Average Weekly Weekday Income
Cumulative Income for the Period

Sorry about the miscommunication, but please let the data reflect this

We should modify the component so we no longer have these plain centered buttons. I feel they are becoming overused throughout the app.

@jaedag with the icons Klenam is coming up with some for me. He said it will be done by the time I'm done with campaigns

@jaedag with the icons Klenam is coming up with some for me. He said it will be done by the time I'm done with campaigns

@ahadziii By the time you finish campaigns? To choose icons?
That makes no sense.
You have till tomorrow after church to finish.


Dependency version alignment

Spring boot -> 2.6.4
Spring Cloud AWS -> 2.4.0
Spring Cloud -> 2021.0.1

Coverage remained the same at 93.809% when pulling 1a9afe25e59c94d92c256a17cba094c2f60ac6c0 on tgianos:versionAllignment into b7c596b34f4f763f3cd3b967b08ff651d1145318 on Netflix:4.2.x.


Feature Request: show the page load time in the footer alongside the location

Ideally, it could show a static UTC or local timezone location in the footer. In the browser version, it could show a "n minutes ago" and "n hours ago" that updates minutely with JavaScript in addition to the loadtime.

It is a good idea. Something that we already have in v2.wttr.in?

Would be great if we could add this to v1 as well, since it's such an easy implementation!


OBS CI: use link_package instead of branch_package

It should keep the same settings as the source, thus skipping disabled builds

(this will have effect only on the next PR)

This doesn't cut it either, disabled again


fix (stickyLine) add condition to update

The issue #38 is persistent despite of commit f0aa0fc

Thanks @grrseguin


Added new consent text to contract request

Coverage remained the same at 90.265% when pulling 14421121b571340a5d22a2b256f2651ad016394b on consent_text into 6fe6d511e34357ffe5c6b7dbb6f1b651d51838d3 on develop.


Process stops processing messages after certain amount of time

I'm using your library in combination with Symfony console commands. I set it up, configured it added it to Supervisor and started 2 processes. Everything works fine, but after a few hours (around 3-5) it just stops processing messages from the queue. I then have to restart the processes and then it starts processing messages again. But again, just for few hours.
I looked into log files but its nothing there.
Have you any idea why this could be happening?
My config file:
[rabbitmq]
host = localhost
username = user
password = pass
vhost = /media
queue = media-converter
compression = Off

[exchange]
name = media-converter
type = direct
durable = On

[logs]
error = /home/user/log/rabbitmq-cli-error.log
info = /home/user/log/rabbitmq-cli-info.log

I'm using the v1.1 (apt package) on Ubuntu 14.04.

Could you also post your supervisord config? And both logs are completely empty? Not a single line?

[program:project_dev_rabbitmq-cli-convert]
command=/usr/bin/rabbitmq-cli-consumer -e "/home/user/development/project/current/app/console convert-upload --rabbitmq" -c /home/user/config/rabbitmq_cli_project_dev.conf
process_name=%(program_name)s_%(process_num)02d
numprocs=2
autostart=true
autorestart=unexpected
user=user
stdout_logfile=/home/user/log/project_dev/convert-out.log
stderr_logfile=/home/user/log/project_dev/convert-error.log

I cleared all logs today before I started testing. After the process stopped processing messages I checked the logs from rabbitmq-cli-consumer and supervisord and nothing was in it.

The problem seems to be in the Supervisor config.
The minimal config seems to work now:
[inet_http_server]
port = <IP_ADDRESS>:9001
username=user
password=pass

[unix_http_server]
file=/var/run/supervisor.sock
chmod=0700

[supervisord]
logfile=/tmp/supervisord.log
pidfile=/var/run/supervisord.pid

[rpcinterface:supervisor]
supervisor.rpcinterface_factory = supervisor.rpcinterface:make_main_rpcinterface

[supervisorctl]
serverurl=unix:///var/run/supervisor.sock

[include]
files = /etc/supervisor/conf.d/*.conf

Before that i had a much bigger config, but I didn't investigate further, which line was causing the problem.
For now it works - after 15 hours.

It seems that the problem still exists. It worked for like 20 hours, but then stopped to processing messages. I restarted the Supervisor process and then again stopped processing after 5 hours.
I setup a test script that I run through Supervisor and it runs without a problem for 2 days now. So Supervisor should not be the problem.
I think the problem lies somewhere in the rabbitmq-cli-consumer.

What do you mean with "stopped processing messages"? Is the consumer still connected to rabbitmq?
Also, I really need some logs from rabbitmq-cli-consumer before I can say anything useful about the problem you describe.

The error log is empty and in the stdout log is just
Waiting for messages...
2016/02/09 11:22:04 Processing message...
2016/02/09 11:22:09 Processed!
2016/02/09 11:22:09 Processing message...
2016/02/09 11:22:13 Processed!
...

By "stopped processing messages" I mean that the process is still running, but no messages are processed anymore.
I just discovered that the consumer disconnects from RabbitMQ.
So the process is running, but after certain amount of time (few hours) it disconnects from RabbitMQ.

There should indeed be some info in the RabbitMQ log when rabbitmq-cli-consumer disconnects.

After 21 hours i got this in the RabbitMQ log:
=WARNING REPORT==== 11-Feb-2016::09:08:34 ===
closing AMQP connection <0.342.0> (<IP_ADDRESS>:50993 -> <IP_ADDRESS>:5672):
client unexpectedly closed TCP connection

Supervisor still shows that the rabbitmq-cli-consumer is running.

What is your server setup? OS, version, multiple servers?
Is it possible to create a vagrant environment in which I can reproduce the errors? We have rabbitmq-cli-consumers processes which are running for months, so I think something in your environment is triggering this behaviour.

It's a Ubuntu 14.04 machine. rabbitmq-cli-consumer v1.1.0 is installed via the APT repository. Supervisor 3.2.1 installed via pip. RabbitMQ is v3.6.0.
Locally on my Vagrant environment I didn't encounter this problem.

I setup another server (Ubuntu 15.10) and there it currently works for two days.
I hope that it will work from now on. Thanks for your help.

@alsar I'm having the same problems. I have ~5 consumers and they all seem to die after 2-3 days. Did you find anything else that could lead to solving this problem?

@lrauldan can you tell me about your situation? What OS etc?
We're on Debian Wheezy and RabbitMQ 3.5.1. Our consumers are running for months with no restart at all. Our queues are quiet only during the nights.
We need to find out how to reproduce this problem.

@ricbra we're using ubuntu 14.04 on aws EC2, a t2.micro for staging purposes, RabbitMQ 3.5.6, Erlang R16B03, consumer version 1.1.0.
I have no experience with go but I was wondering if there is a way to check here if the TCP connection has gone away and to reconnect the consumer?

I'll reopen the issue, because it seems that I'm not the only one that has/had this problem.
On my new 15.10 server it now works for 4 days.
Maybe this problem is only present on Ubuntu 14.04, as both I and @lrauldan have this problem on the same Ubuntu version.

But on the other side I didn't have any problems on Vagrant with Ubuntu 14.04.

Neither did I but after a couple of days on staging we had over 100 messages stuck in our queues. Once I restarted supervisor all of them went thru and got processed without problems.
I will fork the consumer over the weekend and see if I can debug it and see what happens when the connection with rabbitmq gets lost.

The connection itself is handled by streadway/amqp library (https://github.com/streadway/amqp). Maybe there is something usefull in the bug tracker on their Github repository?
Nevertheless it could also be caused by something in rabbitmq-cli-consumer, so looking forward to your findings.

Any news on this @lrauldan ?

I've the same problem with the release 1.1.0.

@ricbra I can confirm that we were not able to reproduce the issue again. The consumers have been running for a couple of months now and none hanged again.

Hi Ric,
I encounter the same problem as others I also run the script under supervisord with minimal config there was no error on supervisord as well and the script status is running as per supervisord.
https://github.com/streadway/amqp as per your suggestion on the other thread I found this information on that github page, I don't know if this is related or not :)
mattwilliamson commented 17 days ago
Just to make sure you don't chase your tail, the memory leak goes away when using QoS of 1, but when not using QoS, closing the channel and connection do not release the implicit buffer.
When i check your consumer.go is that right The QoS parameter was 0 ?
if err := ch.Qos(cfg.Prefetch.Count, 0, cfg.Prefetch.Global); err != nil {
return nil, errors.New(fmt.Sprintf("Failed to set QoS: %s", err.Error()))
}
Still chasing the ghost here the problem resurface every two days or so. Using Ubuntu 16.04
I will try to Set the QoS parameter to 1 let see how this fly.

Refer the official docs for the exact params of this method: https://godoc.org/github.com/streadway/amqp#Channel.Qos
Second param is prefetchSize. I don't understand exactly what mattwilliamson means with "QoS of 1".
Let me know if you solve the problem with this fix.

This is a sample message that was stucked on queue as soon as I delete this message on queue the consumer script continue to run ric another suggestion I hand in mind how can you enclosed the argument on the invoke script with double quotes?
e.g php test.php "base64_encoded message" ?
The actual payload is a json encoded message
eNoUjjFPwzAQRv/K1bNx7uzETr2lEkJIgCq1A0MWIx+pReJEaQMD4r/jbk+np/ver5jmjzSy8AL35BpjTd02QoqJr9cw3O/PeQw5wvn98cGiheOBoBt5ve120MW4Fs/D27zeLvAaUobum/PGEp5CDnGWcEj9hvhJIUt4CcOWA5zTxF4jub5C3Ve6BSJvjCcr4bQwR49fU19dypPjyVOttEO0xSZNChvnalMKl7JZ8qjg8JOWO+61ItsqjagMib//AAAA//+muzzA

That doesn't seem to decode correctly? are you sure what's being encoded is valid?

Yes that was I was thinking but try to run the script it will successfully decode the encoded message

Hi guys,
Out of desperation move I slightly modify command_factory.go to send the base64 encoded via STDIN instead of sending the body as parameter. My issue I believed would be the encoded string still large enough even though it was compressed. Though to be honest it's just my hunch because I don't see the argument too long error from PHP resulting the PHP script to bailout and not processed the message.
Even though this will not fixed my issue the string limitation as argument is now removed and will be a major leap forward to triage my issue, thanks guys

To other who might be interested of doing this I attach the code snippet on the other thread look for STDIN on the subject

Hi Ric,
I was able to triage my issue and it's irrelevant on this post, what's relevant is basically we can't never tell what your developer will going to passed on the Queue, all I can say the STDIN enhancement should be in as another user option in the queue config section.
Please disregard the QoS issue i didn't touch the code obviously... for me I can say you can now close this issue 👍

Hi I am using rabbitmq on heroku. It is working fine that is consumer keeps on processing messages. But whenever I make any change in any file and push the code the connection gets lost. In this case , I need to restart the connection manually by calling the consumer process.
I have also checked the logs but I didnt get anything there also.
Please help me out.
Consumer file
class ConsumerController extends AppController
{
public function consume()
{
	$this->writeLog("shopcontroller:: index::starting to make connection with rabbitmq ..");

	try {
		$connection = new AMQPStreamConnection("hostname", port, "username", "password", "vhost");

		$resultData = print_r($connection, 1);
		$this->writeLog("shopcontroller:: index::connection object value with rabbitmq :: $resultData");

	} catch (Exception $e) {
		$resultData = print_r($e, 1);
		$this->writeLog("shopcontroller:: index::exception while making connection with rabbitmq : $resultData");
	}

	if ($connection)
	{
		try {
			$channel = $connection->channel();

			$channel->queue_declare('testqueue', false, false, false, false);
			echo ' [*] Waiting for messages. To exit press CTRL+C', "\n";

			$channel->basic_consume('testqueue', '', false, true, false, false,  array($this, 'processOrder') );
			while(count($channel->callbacks)) {
				$channel->wait();
			}
			$channel->close();
			$connection->close();
		} catch (Exception $e) {
			$resultData = print_r($e, 1);
			$this->writeLog("shopcontroller:: index::exception while making channel with rabbitmq connection : $resultData");
		}

	}

}

Function processOrder()
{
$testCron = new testCron();
$testCron->test();
}

Hi,
I am also facing the same issue, consumer stops processing messages from queue, even though consumer are running. Queue continues to fill up. I tried to restart the service and consumers but it does not process, it will sometime process couple messages then stops again.
I am using latest RMQ on Windows server 2012 R2, please help.
Thanks
Girish

same issue here. my workers dieing when my script hits curl timeout in some cases. any solution ?

Also same issue here. My consumer received queue 'detectron_detector' in vhost '/' process is stopped by supervisor after the detectron_detector queue started for a long time (~1hrs or 6hrs, it depends). Here is my setup and rabbitmq log.

Ubuntu 18.04 LTS
erlang 1.21
rabbitmq 3.8.1
rabbitmq log
config on http management

The queue setup was intended for real-time messaging. Normally it accepts 50~90 msgs/s and three consumers subscribes this queue. Since it has x-message-ttl: 10000 property so I expect the queue size is limited to some degree.
I grepped the log and merely and found it relevant.  Not knowing why it stopped unexpectedly.
2019-11-24 04:27:16.083 [warning] <0.3911.5> Queue detectron_detector in vhost / has its master node is down and no mirrors available or eligible for promotion. Forcing queue deletion.

Besides, the consumer cannot queue_declare to replace the stopped queue. It cannot recover without deleting the queue manually.

same here, got the same problem : X


Improve Design Panel Performance

Feature Description
Currently, the Design Panel performance is quite poor. It can be tested out by selecting an element and changing the values in the input -- the logic is visibly lagging.
Design Panel needs refactoring to:

Use more common logic across the panels
Improve the performance for eliminating the lag time.

See https://github.com/google/web-stories-wp/pull/534#issuecomment-598563305 and https://github.com/google/web-stories-wp/pull/534#pullrequestreview-372956293 and also https://github.com/google/web-stories-wp/pull/526#discussion_r391083231
See also the previous issue which should get a temporary fix by #526

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria
QA Instructions

cc @jauyong for visibility of the new issue.

Closing this issue as the origin issue here is not relevant anymore and has been refactored more than once since the issue was created.


Add RELEASING.md

This contains info about cross compiling for Apple Silicon and Intel
Signed-off-by: Keith Smiley<EMAIL_ADDRESS>

This kinda sorta depends on https://github.com/apple/swift/pull/36875 to allow cross compiling from Apple Silicon to Intel

That PR was merged, in the meantime for existing release branches that don't have it, it can be cherry picked locally


Can not wrap blueprint on others wrappers with same function name

By example:
flask_app = Flask(...)
app = Blueprint(...)

def mywrapp(func):
    def wrapped():
        return func()
    return wrapped

@app.route('/one')
@mywrapp
def route1():
    pass

@app.route('/two')
@mywrapp
def route2():
    pass

flask_app.register_blueprint(app)

Flask says an error: AssertionError: View function mapping is overwriting an existing endpoint function: name.wrapped. When invert the position between route and mywrapp can not call the wrapp function.

your decorator is not properly preserving the original function name. use functools.wraps to fix that.

your decorator is not properly preserving the original function name. use functools.wraps to fix that.

Thanks, but does not work:
flask_app = Flask(...)
app = Blueprint(...)

def mywrapp(func):
    @wraps(func)
    def wrapped():
        print('wrapped')
        return func()
    return wrapped

@app.route('/one')
@mywrapp
def route1():
    pass

@app.route('/two')
@mywrapp
def route2():
    pass

flask_app.register_blueprint(app)

Now can not says any error but can not call the wrap function (the print inner wrapper function).

Please use Stack Overflow for questions about your own code. This tracker is for issues related to the project itself. Be sure to include a minimal, complete, and verifiable example.


[Feature] Auto-Update

We're missing the ability to 'auto-update' the builds - right now, to update and pick up the latest, you have to download it from the early access portal.
This is very inconvenient - it'd be ideal to have an auto-update option from the app!
The work required is:

Create an endpoint to check for updates (based on a license key)
For Windows:

Download the installer, verify codesign signature
Close the app and run the installer with silent
Restart the app

For OSX:

Integrate squirrel
Hook up to installation endpoint / payload

For Linux:

Investigate AppImageUpdate

Wanted to voice my preference per the 0.5.2 release note - more important to me to have something that plays nicely with NixOS updating than builtin auto-update. Not exactly sure what that would look like, but I think @lobre has done some work on that

Wanted to voice my preference per the 0.5.2 release note - more important to me to have something that plays nicely with NixOS updating than builtin auto-update. Not exactly sure what that would look like, but I think @lobre has done some work on that

My 2 cents:
As a (Linux) user, I always prefer OS package managers (like Flatpak (or Snap)) over app-integrated solutions which give me no transparency or opportunity for input.


[Locale Incompatibility] Postgresql 9.2.4 closing connection on error

Hello!
Here is the code, connecting to Postgresql 9.2.4 on Ubuntu 12.04 with python3.2/python3.3:
import postgresql
dbh = postgresql.open('pq://user:pass@db/database')
dbh.prepare('select 1')()
[(1,)]
dbh.prepare('select * from fsdsfsdfskdh')() # not existing table
postgresql.exceptions.UndefinedTableError: relation "fsdsfsdfskdh" does not exist
dbh.prepare('select 1')()
postgresql.exceptions.UndefinedTableError: relation "fsdsfsdfskdh" does not exist # the same error again
dbh.state
'closed'
But these lines works well with Postgresql 8.4.4 with python3.2/python3.3.
Is this a bug or feature?

Is this still an issue?

Duplicate of #63


Add a pagination on the home page

Add pagination on the home page so the user can see more and more cryptocurrencies.
Features

Coins Per Page: 24

Details

API Documentation : Coingecko
API Endpoint: GET /coins/markets
Parameters to use:

per_page
page

Hi, may I try to work on the issue?

Sorry, I have been preoccupied by other things, so please feel free to let other people work on this if you want.


Failed to create changefeed with pulsar sink "[CDC:ErrMQSinkUnknownProtocol]unknown '' protocol for Message Queue sink"

What did you do?
Try to create changefeed with Pulsar sink ( (apache pulsar v2.10.0)) by the following command:
tiup cdc cli changefeed create --pd="http://<IP_ADDRESS>:2379" --sink-uri="pulsar://<IP_ADDRESS>:6650/public/default/cdc?connectionTimeout=2s"
What did you expect to see?
changefeed with pulsar sink that should be successfully created and work without problem.
What did you see instead?
error message below after executed the above command
[CDC:ErrKafkaInvalidConfig]kafka config invalid: [CDC:ErrMQSinkUnknownProtocol]unknown '' protocol for Message Queue sink
Versions of the cluster
Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):
Release Version: v6.0.0
Edition: Community
Git Commit Hash: 36a9810441ca0e496cbd22064af274b3be771081
Git Branch: heads/refs/tags/v6.0.0
UTC Build Time: 2022-03-31 10:33:28
GoVersion: go1.18
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false

Upstream TiKV version (execute tikv-server --version):
TiKV
Release Version:   6.0.0
Edition:           Community
Git Commit Hash:   2b4f7d57af9ca3e21bc07b91a9cfc466ed87734f
Git Commit Branch: heads/refs/tags/v6.0.0
UTC Build Time:    2022-04-01 06:54:28
Rust Version:      rustc 1.60.0-nightly (1e12aef3f 2022-02-13)
Enable Features:   jemalloc mem-profiling portable sse test-engines-rocksdb cloud-aws cloud-gcp cloud-azure
Profile:           dist_release

TiCDC version (execute cdc version):
Release Version: v6.0.0
Git Commit Hash: 2f363f653a49fc557ebaab1afa7a47f900fbfc8f
Git Branch: heads/refs/tags/v6.0.0
UTC Build Time: 2022-03-31 10:05:34
Go Version: go version go1.18 linux/amd64
Failpoint Build: false

tiup cdc cli changefeed create --pd="http://<IP_ADDRESS>:2379" --sink-uri="pulsar://<IP_ADDRESS>:6650/public/default/cdc?connectionTimeout=2s

try: tiup cdc cli changefeed create --pd="http://<IP_ADDRESS>:2379" --sink-uri="pulsar://<IP_ADDRESS>:6650/public/default/cdc?connectionTimeout=2s&protocol=open-protocol

tiup cdc cli changefeed create --pd="http://<IP_ADDRESS>:2379" --sink-uri="pulsar://<IP_ADDRESS>:6650/public/default/cdc?connectionTimeout=2s

try: tiup cdc cli changefeed create --pd="http://<IP_ADDRESS>:2379" --sink-uri="pulsar://<IP_ADDRESS>:6650/public/default/cdc?connectionTimeout=2s&protocol=open-protocol

It worked. Thanks.
And according to the official document of ticdc , it seems that the parameter of "protocol" is optional and only mentioned at kafka sink section. Wonder if there is a "default" option without the "protocol" setting.


CBMC proof for s2n_mem_init

Description of changes:
CBMC proof for s2n_mem_init.
Testing:
Coverage summary:
1.00 (25 lines out of 25 statically-reachable lines in 6 functions reached)
1.00 (25 lines out of 25 statically-reachable lines in 6 statically-reachable functions)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #2076 into master will decrease coverage by 8.33%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #2076      +/-   ##
==========================================
- Coverage   88.78%   80.44%   -8.34%
==========================================
  Files         151      233      +82
  Lines       11838    17547    +5709
==========================================
+ Hits        10510    14116    +3606
- Misses       1328     3431    +2103


Language translation file for plugins

Hi,
Would translations be available for plugins config schema too ?

Dear,
Is it in your roadmap ?

It would be nice if support different language for plugins config schema. Looking forward for this function!

+1

How do I unsubscribe?
The app doesn’t work.
O the joy of my spirit - it is uncaged - it darts like lightning!
It is not enough to have this globe or a certain time,
I will have thousands of globes and all time.

Walt Whitman

Sent from my iPhone

On Mar 11, 2021, at 5:26 PM, kennymc-c @.***> wrote:

+1
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Kotlin Support

Is it possible we can add Kotlin support for Markdown code samples? I'm currently getting no styling.

@thomasnield https://github.com/atom/language-gfm/pull/236 😄

@thomasnield I think we can close this now. The update is merged

Thanks @radixdev :bow:


Some help with an 500 error.

Hi. I used this in the past and everything was easy to setup. This time I am having issues with
500 (internal server error)
during setup.
Any idea whats going on? The page wont load, but my older version works fine.
Working version: http://<IP_ADDRESS>/bans
New non working  http://<IP_ADDRESS>/ban

Please check your web server logs for any errors.

Never mind, not sure what happened but its fixed.


Make components headless for File-button component

Description
Migrate styles from components to themes.
Since component styles in themes inherit styles from other components using mergeStyle etc., duplicate styles should be removed.
Problem Statement/Justification
Move static styles from file-button component to theme.
Proposed Solution or API
No response
Alternatives
No response
Are you willing to participate in implementing this feature and create a pull request include the implementation?
Yes
Additional Information
No response

Closed due to no migration required.


Improvement: QuintTest - fine tuning

After rough tuning new parameters, they should be fine tuned to provide maximum Elo gain. Stockfish's tuning method seems to be a good match for this.

Moved to QuintTest repo.


next and back arrows

is it any way to change arrows for next and back button? OR hide next and back arrow?
because it is not support right to left!
any help?

Thanks for the report! This has been fixed in 1.0.3


Change clang-format PointerAlignment to Left

Not sure if this is controversial, but following a previous discussion in Slack, it sounded like this might be a sensible choice now that we pushed a release.
This avoids the clang-format inconsistencies related to variadic pointer and reference parameters with PointerAlignment: Right.
Older clang-format versions format T&&... a as T &&... a, but never versions format it as T &&...a, while normal
variadic parameters are formatted as T... a any time. This inconsistency is not present for PointerAlignment: Left
Also, ignoring multiple variables being declared in the same expression (which we don't do anyways), type* obj makes it slightly more clear that the left part is the type and the right part is the variable being declared, while type *obj puts more emphasis on what obj is pointing on.
Related discussion of the behavior differences: https://stackoverflow.com/questions/65964384/how-to-make-clang-format-11-put-a-space-after-variadic-template-decleration
Discussion on attachment in general: https://www.stroustrup.com/bs_faq2.html#whitespace

I am fine with this change because we also have a rule to make the definition clear.
In short, we do not allow to define two variables in the same line. we must keep forcing it
Thus, we do not have the confusion introduced by pointer left alignment.
Others changes are introduced by make format with new .clang-format, right?

I ran clang-format -i  on all files matching *.cuh,*.cu,*.hpp.inc,*.cpp,*.hpp  manually, since make format only picks up changed files. Anything I might have missed?


Library Sync Support

What would be really nice is to have some kind of Synchronisation of the Music Library between multiple Computers, e.g. a Desktop and a Laptop.

You mean to share the same library across devices or to do a real Sync like Dropbox ?

Well, a real Synchronisation would be great, but I would be fine, if the library would be managable with e.g. git.
What also would be great is if I could say, that I want to "share" a part of the library e.g. a set of playlists and then create a one-way-sync to e.g. google drive or dropbox for that (with the subset of the library file as well as m3u-playlists) that would make that player as powerful as iTunes.
I once have written something like the following for banshee:

Export a selected subset of playlists as well as the necessary files for those lists
hardlink the music files in a separate folder with changed foldernames that are ascii-proof (e.g. some kind of hash) - this saves disk space and prevents character encoding problems in filenames
generate m3u files
sync this folder with google drive to my smartphone, laptop and office pc

the only problem with this is, that there is no good player for linux that works like poweramp or gonemad player on android (reading the m3u and acting as if there were a library - but on change of the playlist files change the playlists in the player)
So what I would suggest is the following:

having a solution like the one described above as a plugin or as a core of museeks
being able to create a subset of the library that will also be synced with google drive
being able to define multiple of such sync-sets
AND (and here comes the thing that makes it more powerful than itunes sync): If something changes in the subset, write a changelog and as soon as we sync again with the main library, we show what changed and ask the maintainer of the main music library if they want to "commit"/"merge" the changes

This would be a great use for:

Users who like ordered playlists that have a special theme or "musical flow" and work on multiple computers
Families and or Cummunities who share a common music library and everyone decides what music they want to carry
dancing schools with a central music library and teachers can tell "No, this is not a tango"

To be honest, I feel like this is out of scope for museeks,
While I can see how this can be nice-to-have build-in, I think you can achieve same thing with some mature sync solution and run museeks against synced directories.

Hmm, was just an idea
If the files are relative in the library and the library has an easy to read format, I could use git for this probably.

DB is stored in user's folder, look for library.db

Ok, then weather the "playcount" needs to be rendered in a new line or disableable, otherwise it would not work with git, because the count could change on both "branches" and I think manual merges are not nice for that big music libraries.

I keep the idea of sharing a library across multiple computers. But it a really low priority compared to the 1.0 milestone. Maybe in a 2.x ?

If the idea is to sync library only, I don't get how is it useful.
If the idea is to sync both library and actual files, I still think this is out of scope.
In any case, from my experience, any kind of synchronization requires user to have some kind of identity, which implies either building our own service, or use 3rd party ones. This would require embedding some kind of client into the app that manages sync concerns.
I still think that if you want to have your music accessible from everywhere, just use one of cloud storage solutions or even spin up your own cloud, they often have some notion of synced folders or similar concept.
I wonder what is the minimal set up for embedding say, dropbox client for syncing...

My music is on my Windows partition, and I can access it easily from Linux. It could be the same with Dropdox: just sync your files with the Dropdox client, then load them as Yury said.
When Museeks will be used by 1 million people (I like dreams), we can investigate solutions for that.
Closing it :)


Update: svg circle to set the inverse property

This will give the facility to have the inverse property with the svg circle icons.

[Current coverage][cc-pull] is 100%

Merging [#231][cc-pull] into [master][cc-base-branch] will not change coverage

@@           master   #231   diff @@
====================================
  Files          23     23
  Lines         253    253
  Methods        40     40
  Messages        0      0
  Branches       31     31
====================================
  Hits          253    253
  Misses          0      0
  Partials        0      0

[][cc-pull]

Powered by Codecov. Last updated by [5c2fce6...6ad0960][cc-compare]
[cc-base-branch]: https://codecov.io/gh/Adslot/alexandria/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/Adslot/alexandria/compare/5c2fce676d3b7b050bb40d34bcf0c3dd21f12ab6...6ad0960f552769049a74dcc0d017e90bde1096d0
[cc-pull]: https://codecov.io/gh/Adslot/alexandria/pull/231?src=pr

LGTM.

LGTM

Merging!


Update dependencies in Java POM

A small dependency update for Java

I updated everything I could think of and also modified all Makefiles in our production environment to the new version.
@mpass99 Please have a look :)


creating replica set doesn't initiate the replicaset

I'm not sure if this is an issue or if it is intended functionality (if it is perhaps the docs should be updated)
after creating a new server that was a replicaset I had to manually initiate the mongo instance with rs.initiate()

Any news on this?

Could someone tell me why i get this error: Cannot configure replicaset 'rs0', no member nodes found?
I've set node['mongodb']['config']['replSet'] and node['mongodb']['cluster_name'] and I run mongodb::replicaset
Right now I've to manually run  the command rs.initiate() :(

As long as you are running multiple servers in your replica set it works but the replica set isn't created until the second server is started.


Resume curl download

Course downloading via curl stopped in the middle. How can I resume the download?. I tried inserting -C DownloaderCurl() function in the Downloader module but, it did not work. Kindly help me.

Try using a better downloader, e.g. aria2, aria2-rpc, uget.
The downloader curl and builtin should support resuming in the next release.


duplicate css code in different styles

Do you want to request a feature or report a bug?

no
What is the current behavior?
If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?
If this is a feature request, what is motivation or use case for changing the behavior?
I want duplicate the css code in different styles,
when use singleton option , the css have the same code，can style-loader do some duplicate and expose a option？

Please mention other relevant information such as your webpack version, Node.js version and Operating System.

I have the same issue, and I have this config for dev:
const config = {
  postcss: () => {
    return [
      cssnano
    ];
  },
  stylus: {
    preferPathResolver: 'webpack',
    use: [
      poststylus([
        autoprefixer({browsers: 'last 2 versions, > 1%'})
      ])
    ]
  },
  stylint: JSON.parse(fs.readFileSync(path.join(__dirname, '../../.stylintrc'), 'utf-8')),
  module: {
    preLoaders: [{
      test: test_expressions.stylus,
      loader: 'stylint'
    }
    loaders: [{
      test: test_expressions.css,
      loader: 'style?singleton=true!css?minimize=true'
    },{
      test: test_expressions.stylus,
      loader: 'style-loader?singleton=true!css-loader?minimize=true!postcss-loader!stylus-loader'
    }]
  }
};

I have jsx components that imports their respective *.styl file, and in those respective files, they each @require/@import files like button.styl and spacing.styl to be able to @extend .className.
This results in a duplication that is equal to the number of total imports of a *.styl file, i.e. button.styl, resulting in everything from 2 equal declarations to n+1 equal declarations.

While the original issue here is related to sass/less/stylus, a fix/hack/patch for this is to use the optimize-css-assets-webpack-plugin in conjunction with extract-text-webpack-plugin to produce, like this: https://gist.github.com/phun-ky/766e5ec9f75eac61c945273a951f0c0b.
If you want to use this in dev, you will have to use a plugin like write-file-webpack-plugin to force webpack to write the file to disk in dev.

@nanjixiong218 Please see @phun-ky comment. @phun-ky Thx 👍


Use Front Matter for tags

Is your feature request related to a problem?
Having tags anywhere in a page with a # char is error prone. Eg. I've added a bookmark:

Now I have this tag (and I don't want it):

Describe the solution you'd like
Use Front Matter for metadata like tags, titles, dates...
https://gohugo.io/content-management/front-matter/
Additional context
No response

Looks like pound signs in URLs no longer get parsed as a tags in Memos :rocket:

Thank you, looks good! But this is just one example of many. If I write something by #mistake, the tag #mistake, is added.
Or when I just copy/paste from somewhere where #another mistakes are included. My tags exploding.
This type of tagging is error prone and imho something better exists. Front matter. This is why I think the issue isn't resolved.

One more example is here #2689
Now I have #2689 in my tags.


added correct spelling to README.md

Fixes Issue
Closes #30 to link your PR with the issue.
Changes proposed
Corrected the "Solution" section, from "more clearly" to "clearly."
Corrected "Current State of Project" section, from "its" to "it's."

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] My change requires changes to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.

@IfeoluwaAroboto Would you like to work on this PR further ?
Let me know if you need some help.


Templates to populate single sample featured terra workspace

Creates templates to populate the sample and participant data tables, the workspace data, and the method configuration input json.
The method configuration json refers to workspace attributes for all reference resources and ref panel parameters of type File or String, but is populated directly with any inputs of type Array because Terra doesn't support uploading Array type values inside TSVs (This was a compromise suggested by the comms team).
Created a template for the dashboard documentation as well despite the fact that it has no templated values, just for the sake of keeping all the files for the workspace together.
Single sample pipeline case inputs are now templated as a 'test_batch' input value bundle.

@mwalker174 made the changes you suggested -- do these look better to you now?

@mwalker174 made the changes you suggested -- do these look better to you now?

Great! Creating a workspace from scratch was easy with this. Just a couple of minor questions. I would add that the root dir is getting a bit cluttered with input-related subdirs. Would it be hard to move these into inputs?

Actually, what about also moving the test_inputs_* directories into a test_inputs directory?

Great! Creating a workspace from scratch was easy with this. Just a couple of minor questions. I would add that the root dir is getting a bit cluttered with input-related subdirs. Would it be hard to move these into inputs?

Actually, what about also moving the test_inputs_* directories into a test_inputs directory?

@epiercehoffman Thanks for the comments, I will address them in turn. To answer this question:

I assume you're planning to have the workspace already set up with workspace data & the corresponding method  configuration, right? So the main users of the templated file generation will be us?

Yes, this is for us (the gatk-sv team). My vision for this is that whenever we  need to create a new version of a terra workspace (because we want to release a new code version), we can generate these files, delete the old version of the workspace, and create a new workspace from these files in a matter of a few clicks and TSV uploads. That way we don't have to worry about, for example, going into a preexisting workspace and deleting old parameters that we've dropped or changed the name of -- I've seen some of my workspaces get polluted with obsolete data or variables that way in the past. Plus we'll have version history on everything associated with the workspaces, tied to our github commits and release tags. If this model doesn't make sense to you, though, let me know.

@epiercehoffman Thanks for the comments, I will address them in turn. To answer this question:

I assume you're planning to have the workspace already set up with workspace data & the corresponding method  configuration, right? So the main users of the templated file generation will be us?

Yes, this is for us (the gatk-sv team). My vision for this is that whenever we  need to create a new version of a terra workspace (because we want to release a new code version), we can generate these files, delete the old version of the workspace, and create a new workspace from these files in a matter of a few clicks and TSV uploads. That way we don't have to worry about, for example, going into a preexisting workspace and deleting old parameters that we've dropped or changed the name of -- I've seen some of my workspaces get polluted with obsolete data or variables that way in the past. Plus we'll have version history on everything associated with the workspaces, tied to our github commits and release tags. If this model doesn't make sense to you, though, let me know.

@epiercehoffman

Was the participant TSV something that was required for the featured workspace? I hadn't been using one

When I first learned Terra the docs made it sound like the participant table was required -- I'm surprised to hear it's not technically necessary! I think it may be "best practice". I could ask the comms team about whether that's true for the featured workspace or not.

@epiercehoffman

Was the participant TSV something that was required for the featured workspace? I hadn't been using one

When I first learned Terra the docs made it sound like the participant table was required -- I'm surprised to hear it's not technically necessary! I think it may be "best practice". I could ask the comms team about whether that's true for the featured workspace or not.

Actually, what about also moving the test_inputs_* directories into a test_inputs directory?

Done

Actually, what about also moving the test_inputs_* directories into a test_inputs directory?

Done

Finally, I do have some worries about template files piling up once we do a similar thing for the Terra cohort pipeline, as it looks like with this model we will need to have a separate Terra-specific template for each workflow. Of course, most of the time we will only have to actually edit the input values rather than the templates, so it's still far better than the previous JSON system. But, it could be a lot of files to edit if inputs are added/names are changed. Could it work to have one template per workflow but tag template items with "this" or "workspace" if that's how they should be configured for Terra, and do away with the separate Terra template? Or is that too complicated with the current JSON-generation implementation / are there cases where it would not work to use the same variable names in Terra?

I definitely see your point. I tried experimenting with a couple of approaches but with the way that I have things set up I couldn't find an elegant way to dynamically choose whether to populate a template with a value from input_values or with a reference to ${this.var} or ${workspace.var}. I created an issue to track your suggestion: https://github.com/broadinstitute/gatk-sv/issues/103 so that we can circle back to this in the future.

Finally, I do have some worries about template files piling up once we do a similar thing for the Terra cohort pipeline, as it looks like with this model we will need to have a separate Terra-specific template for each workflow. Of course, most of the time we will only have to actually edit the input values rather than the templates, so it's still far better than the previous JSON system. But, it could be a lot of files to edit if inputs are added/names are changed. Could it work to have one template per workflow but tag template items with "this" or "workspace" if that's how they should be configured for Terra, and do away with the separate Terra template? Or is that too complicated with the current JSON-generation implementation / are there cases where it would not work to use the same variable names in Terra?

I definitely see your point. I tried experimenting with a couple of approaches but with the way that I have things set up I couldn't find an elegant way to dynamically choose whether to populate a template with a value from input_values or with a reference to ${this.var} or ${workspace.var}. I created an issue to track your suggestion: https://github.com/broadinstitute/gatk-sv/issues/103 so that we can circle back to this in the future.

@epiercehoffman I've finished responding to your comments; are you OK with these changes?

@epiercehoffman I've finished responding to your comments; are you OK with these changes?

@epiercehoffman I've finished responding to your comments; are you OK with these changes?

Looks good! The only thing is that clean_default_inputs.sh needs to be updated to reflect the new test_inputs directory - I made suggestions for that above

@epiercehoffman I've finished responding to your comments; are you OK with these changes?

Looks good! The only thing is that clean_default_inputs.sh needs to be updated to reflect the new test_inputs directory - I made suggestions for that above


Add a non generic overload to ForDestinationType

There's been a few scenarios where I've only had access to a Type at runtime and have needed to setup destination mapping rules for these, which isn't possible when there is only a function that takes generic parameters. This PR adds an overload that does the same thing but takes a Type function parameter instead of a generic one.

@Dewera Thank you very much! :)


Investigate alternative to [type=number] for the date input component

We are aware of two issues with assistive technologies and their compatibility with [type=number]

https://github.com/alphagov/govuk-frontend/issues/1408
https://github.com/alphagov/govuk-frontend/issues/1101

We should investigate an alternative to this as we're aware of general issues with [type=number].
@hannalaakso has done a lot of investigation into this.

If collecting dates as numbers, the biggest problem with type="number" is that it has native input validation in Chrome (desktop and Android) which prevents the typing of non-numeric values. This is not a bug but an implementation of the HTML spec.  Unfortunately the user experience is poor when it comes to handling errors. We recommend the use of clear error messages, whereas there is no information given to user about what they’ve done wrong if they attempt to type the month as a number, for example.
type="number" also allows the user to increment numbers by pressing the up/down arrows. This could improve usability for some users (as long as the number should be incrementable - dates generally are) but also introduces the risk of some users accidentally incrementing a number using the arrow keys when trying to navigate a form. The incrementing behaviour can be disabled using Javascript but we prefer to avoid scripting solutions if possible.
There are other issues with type="number" that concern long numeric values being validated by browsers and making sure that users can enter "-" and "," signs; but these aren’t a concern for dates.
Alternative solution (we should test this across the board) is to use inputmode="numeric" combined with pattern:
<input type="text" pattern="[0-9]*" id="sometext" name="sometext" inputmode="numeric">

There is also type="tel" which has no browser validation, and brings up a numeric keypad on all mobile devices (the input should set autocomplete=off to stop the browser trying to complete it from the user’s address book). It's often used by payment providers to collect credit card numbers. However on Android devices the keyboard includes additional buttons for "Pause" and "Wait" which could be confusing for some users. Additionally, there is the (admittedly very slim) possibility that browser vendors might in the future add validation to type="tel", for which reason if it was used on a service, there should be a team available to monitor the behaviour.

Just a note on the pattern attribute suggested, if someone has HTML5 validation enabled (something we do not recommend), it will show a message and stop the form from being submitted:

We are already using the pattern attribute for the date input so that wouldn't be a change?
Possibly another reason to move away from it though.

To summarise:
At the minute for the date input component the individual inputs look like this:
<input […] type="number" pattern="[0-9]*">

We set the input type to type="number" so that Android browsers display a numeric keypad keyboard when the input is focussed.
iOS uses the full alphanumeric keyboard for type="number", so we add pattern="[0-9]*" which triggers the numeric keypad there too. This is technically invalid HTML, as the pattern attribute only applies to inputs of type text, search, url, tel and email, but is not known to cause any real-world issues.
However, there are a number of known issues with inputs of type="number":

they silently discard non-numeric input in Chrome (except the letter 'e')
users can accidentally increment or decrement the number using the arrow keys without realising
users can accidentally increment or decrement the number using the scroll wheel on the mouse or the scroll gesture on their trackpad
they appear as unlabeled in NVDA's element list
in NVDA's object navigation they are seen as a spin button which has an edit field and two buttons inside. Those buttons are unlabeled, but decrease/increase the value
when tabbing to the field NVDA using pressing nvda+tab they are reported as unlabeled edit fields
users of Dragon Naturally Speaking cannot dictate into them as expected

(Bugs have been filed where appropriate)
In testing, using <input […] type="text" inputmode="number" pattern="[0-9]*"> mitigates these issues, with some minor drawbacks:

In iOS 12.2 and above, the numeric keypad with punctuation is displayed instead of the numeric keypad, but this looks like it has been changed in Webkit so this should hopefully change in a future iOS release (versions prior to 12.2 do not support inputmode, thus fallback to the pattern attribute, and continue to show the full numeric keypad.)
Firefox, UC Browser (and older versions of other browsers) on android support neither inputmode nor pattern, and so will use the full alphanumeric keypad until those browsers introduce support for inputmode. (Note: neither Firefox nor UC browser on Android are listed in our own browser support matrix nor the service manual)

We think that <input […] type="text" inputmode="number" pattern="[0-9]*"> is semantically correct and provides a better experience and so we should:

update the input component to accept an inputmode
update the date input component to use <input […] type="text" inputmode="number" pattern="[0-9]*">
add guidance to the Design System to help users understand how to ask for different types of numbers
publish a blog post explaining the change and why we're making it
consider removing the pattern attribute once traffic from iOS < 12.2+ drops off

Once we've done the above, we can also close https://github.com/alphagov/govuk-design-system/issues/782

In iOS 12.2 and above, the numeric keypad with punctuation is displayed instead of the numeric keypad, but this looks like it has been changed in Webkit so this should hopefully change in a future iOS release (versions prior to 12.2 do not support inputmode, thus fallback to the pattern attribute, and continue to show the full numeric keypad.)

Just to confirm that iOS 13 now shows the numeric keypad.

A bit late to this, but I was wondering why inputmode="numeric" was used instead of inputmode="decimal". It's the same keyboard either way on Android, but on iOS numeric uses the same keyboard as type="number" (with the numbers in a row and lots of punctuation options), but if we're only asking for a number, the number-pad style (a 3 x 4 grid with numbers 0 to 9) feels more appropriate. The touch targets are also much larger, which can only be a good thing.

Thanks for your comment @tempertemper. See https://github.com/alphagov/govuk-frontend/issues/1449#issuecomment-539906569 - iOS 12.2, 12.3 and 12.4 display the keypad with punctuation that you describe but this was fixed in iOS 13 which displays the large numbered keypad with numeric. Are you on one of the above mentioned versions of iOS?

@hannalaakso I totally missed that one – I had been testing with iOS 12 so saw the other keyboard. Numeric is perfect 😄 I've attached a couple of screenshots (taken from @adamliptrot-oc's excellent test page) for posterity: the difference is that decimal has a decimal point and numeric doesn't. So numeric is the right choice as the . it's always going to be a whole number. Thanks for keeping me right 🙂
Decimal:

Numeric:

@tempertemper No worries at all, glad we got it figured out 🙂


Classification demo

Tasks:

[x] Compare demo's performance results on local PC to results from stat table
[x] Make GridMat change its configuration (number of shown images, image changing speed) depending on performance of the model
[x] Show classification results as a text above each image

Background tasks:

[x] Add tests for imagenet_classification_demo to cases.py file, ensure that they are working well

Future tasks:

[x] Mark classification results as right/wrong by using different text colors
[ ] Add a special metric to compare performance of two or more models at once
[ ] Show two or more GridMats to visually compare performance of selected models

Some of your test cases failed.

@IRDonch

Some of your test cases failed.
It's because densenet-*-tf models were converted without keep_shapes_ops flag in CI. It's not because of the demo. The issue will be resolved soon. So, I hope it doesn't block further review.

Jenkins please retry a build

Jenkins please retry a build

Jenkins please retry a build

(just making sure the builds still pass with the final 2020.2 release)


Update tests

I rewrote your PR a little to show an alternative way to declare them. In table driven tests it's pretty common to write the needed info inline, instead of declaring all the bits separately upfront and then use those in the table entries...

@svanharmelen So sorry that I didn't respond in time, I missed this notification until I receive your mention in xanzy#359. I think your update is reasonable, now should I merge this PR to update xanzy#359 with two commits? or squash/rebase to just one commit? Which is better?

No worries :wink: And whatever you want, both options are just fine 👍

@svanharmelen I rebased to two commits, you may squash to one if necessay. Thank you for your patience.


🐛 Bug - Uncaught Error: Minified React error #418

Cc: @bradystroud @tkapa @Calinator444 @isaaclombardssw

Hi Team
Describe the Bug

Application Insights exception logs for front-end has returned 218 instances of below error for the last 30 minutes. This needs to be investigated and fixed as it is affecting website health view by logging so many identical exceptions.
Uncaught Error: Minified React error #418; visit https://reactjs.org/docs/error-decoder.html?invariant=418 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
To Reproduce
Steps to reproduce the behavior:

Go to Application Insights
Query exceptions
See error

Expected Behavior

This exception is fixed and cause is identified
Tasks

[ ] Investigate
[ ] Fix

Screenshots

Figure: Huge amount of same exceptions were logged for last 30 mins
Thanks!

Findings:
The PDFs can be downloaded in local dev and in staging sites.
Staging URL - https://sarulesstagbbfslamgwndh2.z8.web.core.windows.net/rules/the-best-learning-resources-for-angular/
I've clicked "Little Book of Angular" link on Books section and I was able to see the PDF

Figure: PDF can be viewed on Staging
Locally is also same, I was able to view the PDF.
Locally, I checked gatsby build to verify if PDF files are copied to public/content-hash/test.pdf location in build process. We are using gatsby-remark-copy-linked-files plugin that does this job in build process. And it is working fine.
Downloaded build.zip package from latest Production workflow run and verified that Little-Book-Angular.pdf exists in correct location.
Turns out we can download PDF files using original domain for SSW.Rules Production - https://sarulesprodnwmiwvq7kqti6.z8.web.core.windows.net/rules/the-best-learning-resources-for-angular/
But we can't download PDF files from custom domain - https://www.ssw.com.au/rules/the-best-learning-resources-for-angular/


Tab image size

Could you clarify the section that talks about the Tab image sizes? The section in this document says the sizes should be 30px, 60px for @2x or 90px for @3x.
The apple documentation suggests something different: https://developer.apple.com/design/human-interface-guidelines/ios/icons-and-images/custom-icons/
What should it be?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8853aece-5bbb-6121-ce6d-f600719ad820
Version Independent ID: 8037b07e-5bdd-390c-e3be-b3c9233d5249
Content: Tab Bars and Tab Bar Controllers in Xamarin.iOS - Xamarin
Content Source: docs/ios/user-interface/controls/creating-tabbed-applications.md
Product: xamarin
GitHub Login: @lobrien
Microsoft Alias: laobri

Page was updated with the link you provided, thanks.


Minor spelling fixes

This is a minor PR to change some spelling of the documentation.
Reviewer 1

[x] I've checked the spelling

Reviewer 2

[ ] I’ve double checked the spelling

:+1: thanks!

I'll take :two:

:+1:


feat: ✨ Autocompletion in HTML

Description:
As a user, I want to be able to get vscode autocompletion for the components
Rationale:
Better DX

See the following for implementation details:

✔ Already done for the internal project at https://github.com/SickDesignSystem/synergy/blob/chore/setup-vendored-unified-architecture/.vscode/settings.json#L72
https://github.com/microsoft/vscode-html-languageservice/blob/main/docs/customData.md
https://code.visualstudio.com/Docs/languages/html#_html-custom-data
https://github.com/microsoft/vscode-custom-data

add documenation how to load the vscode file in the README


⚠ SceneTime has degraded performance

In e4f4e59, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 5270 ms

Resolved: SceneTime performance has improved in 41d9a0b after 6 minutes.


Fix/push context

Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/test all

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
8d9f770594b883c5286595cc5c8146946c071972
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
8d9f770594b883c5286595cc5c8146946c071972
link
/test release-notes_istio

lint_istio
8d9f770594b883c5286595cc5c8146946c071972
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
8d9f770594b883c5286595cc5c8146946c071972
link
/test release-notes_istio

lint_istio
8d9f770594b883c5286595cc5c8146946c071972
link
/test lint_istio

unit-tests_istio
8d9f770594b883c5286595cc5c8146946c071972
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
8d9f770594b883c5286595cc5c8146946c071972
link
/test lint_istio

unit-tests_istio
8d9f770594b883c5286595cc5c8146946c071972
link
/test unit-tests_istio

release-notes_istio
f3e8135675e6f094431c4667a4cf06ab5e018265
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio


Add an example for usage of graphql-playground-html without jsDelivr

Fixes #.
Changes proposed in this pull request:

Add an example for usage of the markup renderer without a CDN like (jsDelivr)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update for Bridgetown v2 compatibility

Right now the index will be blank due to referencing the deprecated content engine config:
https://github.com/bridgetownrb/bridgetown-quick-search/blob/87bc71bb5d93b354a6c7479e5a021241a44ca851/content/bridgetown_quick_search/index.json#L7C10-L7C44

I believe this was resolved in the latest release.


Simplifying SPNs and RBAC: improve guidance,

New guidance and test to verify (we need a pristine tenant) RBAC:

SPN for Build-DeploymentPlans per tenant with tenant-level Reader (is regular Reader sufficient?)

If we are in China or UsGov, may need additional permissions since we are not using ARG queries for some items
Can we avoid configure MS Graph permissions
Do not subdivide the plan SPN by EPAC environment; I have some great ideas if we can do this!

SPN to Deploy-PolicyPlan with Policy Contributor either at

each tenant root or pseudo root (preferred)
each EPAC environment root (today's guidance)

SPN to Deploy-RolesPlan with User Access Administrator

each tenant or pseudo root
needed for additional Role assignments

Adding to backlog


Make required fields correct and remove URL field

Remove URL field from all database connector templates and update required fields. Most of these are indicated in this PR or in the Confluence doc
https://github.com/ethyca/fides/pull/3753/files

closing