debug - output doesn't show cos it's too large

#4952

have code like this

        let longString = new Array(100001).join('oooooo ');
        longString += '<END>';
        console.log(longString);

⚡ the console only shows a message about large output which is a big regression in comparison to the truncated message

@jrieken assigning back to you to retest this scenario with a newer Alpha build that includes our node-debug fix to actually enable debug injection for Electron.

disagree. we should not even have code that shows such a message, but it should truncate

Can not repro with latest alpha. We were always behaving like this, not a regression, removing important tag
Truncation is coming from here
@bpasero not sure if I can do something smarter there

Works for me now.

Nope, not for me

This works fine for "inspector" protocol (which is now supported for EH debugging).

Nope, using node 8.4.0 and inspect still shows this. The hover can show it, the console cannot.

This is happening due to the fact how we are computing height for strings here https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/debug/electron-browser/replViewer.ts#L113
The computation is not 100% precise which shows in this huge string case. However since no user complained and this seems only visible for extremly long strings -> closing as will not fux until there is a real scenario where this bug hits us

Sorry, not sorry. After letting me verify and reopen this issue multiples (which costs time btw) I appreciate the acknowledgement this being an issue. But really, you are unable to count the newlines in a string?

Let's fix this in November!

How about measuring the hover? That apparently can figure that it out

Hover in this case is not a tree, there we just but all the text and we set wrapping to true and the browser does everything nicely for us, so we do not have to compute.
Since the repl is the tree, the tree is implemented in such a way that each element needs to tell in advance what is the height (thus the computation).

Works now with the latest dynamic height in the tree. Yey.


Fix BreadcrumbsView docs that still said DropdownMenuView

@andy-armstrong
http://ux-test.edx.org/bjacobel/fix-docs-copypasta/views/breadcrumbs/breadcrumbs-view/

Coverage remained the same at 94.456% when pulling 6243d3ceb43bbdd0ca778bf02b19f895499a0c52 on bjacobel/fix-docs-copypasta into 2ac908161b6fd0d1e5c4a34605e7e979577950bd on master.

👍


Can't play MPG video files after install SoftGPU in Win98 Guest

Host 1: VMware 17
Guest 1: Win98 SE, SoftGPU 0.4.2023.19, Patcher9x 0.8.50
Host 2: VirtualBox 7
Guest 2: Win98 FE, SoftGPU 0.4.2023.19, Patcher9x 0.8.50
Can't play MPG video files after install SoftGPU in Win98 Guest. Play AVI video files are OK. Use VMware Tools has no this problem.

I have the same problem as you :-/
Host 1: VMware 16.2.4
Guest 1: Win98 SE, SoftGPU 0.4.2023.19

Click View(V) on the WMP.
Click Option.
Set the Hardware Accelerator slider to the far left. (No hardware acceleration).
Even without hardware acceleration, there is enough CPU power to play the video at the time.


Missing non-wrapper (=Fortran??) routine

The docs for inrypl
http://naif.jpl.nasa.gov/pub/naif/toolkit_docs/C/cspice/inrypl_c.html
have a nice example for calculating intercept of instrument boresight with the Saturn ring plane, but it uses a weird, non-wrapper (hence, no _c at the end) function called stlabx_ :
We now wish to find the vector corvec that, when corrected for
             stellar aberration, yields borvec.  A good first approximation is
             obtained by applying the stellar aberration correction for
             transmission to borvec.  Note that the routine called is not
             a wrapper, so there is no letter 'c' at the end of its name.
             The prototype for this routine is declared in SpiceZfc.h.
             ./
             stlabx_ ( (doublereal *) borvec, scssb+3, corvec );

and it's not currently in SpiceyPy. Could this be implemented as well?

I looked at the source code for stlabxand it looks like it really is just a call to vminus and stelab. In fact I pasted the entirety of the code here:
  230 C     Obtain the negative of the observer's velocity.  This
  231 C     velocity, combined with the target's position, will yield
  232 C     the inverse of the usual stellar aberration correction,
  233 C     which is exactly what we seek.
  234 C
  235       CALL vminus( vobs, negvel )
  236
  237       CALL stelab( pobj, negvel, corpos )
  238
  239       CALL chkout( 'STLABX' )
  240       RETURN

So that should get you what you need for now, but it also shouldn't be a problem at all to implement the function in the wrapper.

Do you have a place where this extra or missing functions should go? If you point me to it, I could give it a shot.

But, as you said, if it's just vminus and stelab as above, maybe not even worth the effort?

we can add it, we should probably make an "extras.py" file for it as there may be more helper functions like this that are sufficiently simple to write in python. feel free to take this on or I can probably get to it in the next few days.

I am closing this issue for now, I can open a new issue to add a place in the repo for these sort of helper functions


net: Read does not obey deadline after syscall.Recvfrom or syscall.Recvmsg is called

Go version
go1.21.6 linux/amd64
Output of go env in your module/workspace:
O111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/jims/.cache/go-build'
GOENV='/home/jims/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/jims/go/pkg/mod'
GONOPROXY='github.com/jimsnab'
GONOSUMDB='github.com/jimsnab'
GOOS='linux'
GOPATH='/home/jims/go'
GOPRIVATE='github.com/jimsnab'
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.21.6'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/tmp/isconn/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build1248113131=/tmp/go-build -gno-record-gcc-switches'

What did you do?
Code is here: https://go.dev/play/p/nr6grgosOXV
In one terminal, run ./isconn srv which will open a socket and accept one client connection, and while holding the client connection open, the connection state is checked via Recvfrom.
In another terminal, run ./isconn cli which will connect to the test server and perform a Read() every 250ms which is always expected to time out. Then after timeout, connection state is checked via Recvfrom.
What did you see happen?
After Recvfrom returns, the next client Read is blocking. The SetReadDeadline ahead of it does not work.
What did you expect to see?
Every 250ms the Read call is issued and then times out.
Comment out the call to Recvfrom and that's what it will do.

The test program is also at https://github.com/jimsnab/go-isconn

cc @neild @golang/runtime

In compiler/runtime triage, we're not really sure what the correct semantics are here. net has abstractions on top of syscall and I don't know whether those are guaranteed to translate into the raw syscall layer. My guess would be "no" but I think we need @neild to comment.

This is expected behavior.  The docs for os.File.Fd (https://pkg.go.dev/os#File.Fd) say "On Unix systems this will cause the SetDeadline methods to stop working."
As those docs suggest, use the SyscallConn method instead.


Add mips64-unknown-linux-muslabi64 and mips64el-unknown-linux-muslabi64 support

Fix #503
Reopen from #507

bors try

Please add a changelog entry and fix the missing newlines in the Dockerfiles.

How do I add changelog. Is there any examples ?

In CHANGELOG.md, add a new line under the “Unreleased” section.

Got it.

Rebase from main branch, and test should be fixed.

bors try --target mips64


Update bonus applied by activating Feeding Frenzy

I noticed that activating Feeding Frenzy in the Configuration tab was still applying the 10% damage bonus which was removed in 3.10 (see https://www.pathofexile.com/forum/view-thread/2784310). While removing it I also noticed that the movement speed and speed bonuses were applying at incorrect amounts (10% instead of 15%). This PR fixes both of these things.
I'm unsure whether anything needs or should be done with the Feeding Frenzy skill in Data/3_0/Skills/sup_int.lua though. There's still a Damage MinionModifier in there, but it never seems to activate.

Pretty sure it's just a callout to the function that tells it how much damage it needs to add (from the file you modified).

I noticed that activating Feeding Frenzy in the Configuration tab was still applying the 10% damage bonus which was removed in 3.10 (see https://www.pathofexile.com/forum/view-thread/2784310)

The thread you link to does not say this (bold mine).

Feeding Frenzy Support

Now gives minions from supported skills 25% chance to grant Feeding Frenzy to you on hit at gem level 1, up to 44% at gem level 20 (previously 25% at all gem levels).
No longer causes minions from supported skills to deal more damage while you have Feeding Frenzy.

Before this patch FFS had this line:

Minions from Supported Skills deal (5-14)% more Damage while you have Feeding Frenzy

The patch did not change the more damage modifier on the feeding frenzy buff, only the damage for supported skills.

@AnnanFay Good catch! A small but very important distinction. It's a nice surprise for me since it means feeding frenzy was nerfed less than I thought.
I have updated my changes to only correct the movement, attack and cast speed bonuses.

I realized that I was wrong here. The movement, attack and cast speed bonuses were lowered in 3.9 (Metamorph). So the values are correct, but the tooltip info is wrong. This issue is fixed in the community fork though, so I'll just close this PR.


MD Quotes not working on preview-only mode

描述这个Bug
Setting this markdown value:
# Hello header
> description
## Sub header

to the MdPreview control:
<MdPreview key={`zone:${lz}`} editorId={`zone_${lz}`} modelValue={zones[lz]} />

produces the right html for most controls, including mermaid charts - except for the block quote for lines starting with
"> "
Using the same text for the editor works fine.
版本号
node 16.19.0
问题重现链接
No response

It's working


Add retry loop for i2c display initialization in esp32c3 example

This example did not initially work for me. I noticed that this was caused by the first i2c write failing. So I've added a bit of error handling to retry if the display initialization fails.
This is probably applicable for the other i2c examples as well, though I don't have the hardware to test each variant (maybe some examples should exist in the esp-common-hal crate?).

I'm not opposed to merging this but I am pretty surprised to see you're having issues with this, as I've never actually seen this fail. Would you mind sharing some more information about your hardware?

So initially I assumed this was a me problem as it's my own board. I have a schematic here. For i2c I'm using gpio 1 and 2, each having a 10k pull up.
Though I didn't have any issues with the i2c examples from the espressif sdk.
I found that I always get a BusWriteError on the first attempt to initialize the display. It always succeeds on the second attempt.

Would be interesting to analyze this in more depth. Do you have access to a logic analyzer?
Traces of the first writes would be great (with your retry-workaround and with esp-idf).
Since the bare-metal-hal gets to your code much faster than esp-idf (because esp-idf has to setup way more things) maybe it's also worth trying to just add some delay before talking to the display. (Just a shot in the dark however)
Thanks


Update branch

Merging will require computing p-values for predictions in worker.py and altering simulation data generation parameters (now residing in repo synmod). Closing for now, reopen if updated analysis really needed. Might be easier to just make branching off of latest master branch to make edits to compute p-values for predictions.


Generating XML in JDart

Hello,
Is it possible to generate an xml version of report ?
trying to add report.publisher+=,xml to a jpf file doesn't seem to include JDart output along with JPF output.
Thanks

No, but it has various other outputs: junit test suite and symbolic summaries (which can be stored in json). In fact, a Google Summer of Code student just developed a json outputter for the entire constraints tree.
Making an XML outputter would be quite easy since the analysis result is already a tree. There are various ways you can do that. One way is to use a JPF publisher which would integrate nicely. Alternatively, just generate the xml after the you obtain the analysis result in the JDart shell.


Override first, last and single on RealmResults

Avoid instantiating a _RealmResultsIterator for first and
single calls, and avoid iterating the entire collection for last.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

5 of 8 (62.5%)  changed or added relevant lines in 1 file are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 88.721%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/src/results.dart
5
8
62.5%

Files with Coverage Reduction
New Missed Lines
%

lib/src/configuration.dart
5
60.61%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
3052

Relevant Lines:
3440

💛  - Coveralls


OTG Test - RT-3.1: Policy based VRF selection

OTG conversion of RT-3.1: Policy based VRF selection found here
Changes from #736 included
Fixes #725

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 73.588%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1602

Relevant Lines:
2177

💛  - Coveralls

Waiting for #845 to get merged. Converting to draft

Waiting for #1187 to get merged

@octpetre : Can you rebase once more to pick up the deviation that was added to the ATE test today? (It should apply cleanly).

/gcbrun


aws storage

The google cloud storage buckets work well (for the most part) with this framework. Is there any suggested/preferred methodology to utilize the amazon s3 storage with this? (Putting tar files in that bucket and use the URL to load them in a local machine)

You can use any command line tool as a URL source. For S3, the following should work:
url = "pipe:s3cmd get s3://bucket/dataset-{000000..000999}.tar -"
dataset = wds.Dataset(url)...

(Note that this use of command line tools is actually more efficient than the Python-native S3 client; that's why WebDataset does not use Python-native cloud libraries by default for accessing any storage.)

Thank you @tmbdev . I tried this with a single tar file on AWS, the command line code works in terminal (meaning that s3cmd is configured properly), however, when running the above in python (using wds.Dataset and then starting to iterate) I get this:
tarfile.ReadError: bad checksum
More details:
>>> for item, label in tqdm(dataset): ...     c+=1 ...     if c>100: ...         break ...     continue ...  0it [00:00, ?it/s] Traceback (most recent call last):   File "/usr/lib/python3.6/tarfile.py", line 2299, in next     tarinfo = self.tarinfo.fromtarfile(self)   File "/usr/lib/python3.6/tarfile.py", line 1093, in fromtarfile     obj = cls.frombuf(buf, tarfile.encoding, tarfile.errors)   File "/usr/lib/python3.6/tarfile.py", line 1037, in frombuf     raise InvalidHeaderError("bad checksum") tarfile.InvalidHeaderError: bad checksum
Any idea why that is happening? If the same file is loaded from the local drive, it's ok.

Installing awscli using pip install awscli and then using this code:
'pipe:aws s3 cp s3://bucket/file.tar -'

seems to work. However, is it efficient?
What are the best options for when we do/dont have sudo access?
Why doesn't the s3cmd get work?

Installing awscli using pip install awscli and then using this code:
'pipe:aws s3 cp s3://bucket/file.tar -'

seems to work. However, is it efficient?
What are the best options for when we do/dont have sudo access?
Why doesn't the s3cmd get work?
often the "broken pipe" error occurs at some point throughout the training, more frequent with the aws, but happened with google storage as well.

I am also getting the broken pipe message when using awscli but only for specific files. It's strange since I can easily download those files using awscli directly.

Installing awscli using pip install awscli and then using this code:
'pipe:aws s3 cp s3://bucket/file.tar -'

seems to work. However, is it efficient?
What are the best options for when we do/dont have sudo access?
Why doesn't the s3cmd get work?
often the "broken pipe" error occurs at some point throughout the training, more frequent with the aws, but happened with google storage as well.

I am also getting the broken pipe message when using awscli but only for specific files. It's strange since I can easily download those files using awscli directly.

@Nilabhra Did you ever figure out the reason for the broken pipe? I'm getting the same thing for all files, despite being able to access the same files manually.

@drscotthawley Unfortunately not. I had to build a retry mechanism so that I ended up downloading all the files.
Your case seems serious though. Maybe our errors have different causes?

I'm getting a similar error, When using an ec2 instance and s3 for storage, I always get a broken pipe error (have tried with num_workers=4 and num_workers=0) so haven't been able to get training started yet. Might be because my shards are too big? (≈1-3GB)

Im using webvid-10m dataset, and the tar files are huge (2GB). I'm also getting the broken pipe error when using:
url = "s3://path/train/{00000..10727}.tar"
s3_url = f"pipe:aws s3 cp {url} -"

I believe it maybe because the command times out and is not able to download the entire tar file and pass it to the stdout?
Is there any other way in which I can use webdataset with S3 URLs?

Ok guys, i think I figured out the broken pipe issue maybe because of lack of CPU memory. I ran same code on AWS Instance (p4d) and didn't face the pipe issues.


manyToMany fixtures

Hi,
I can get the oneToMany and ManyToOne to work however I am not sure how to add manyToMany fixtures. Is there any example on this?
Regards,
Baig

App\User:
  groups: '<randomNumber(0, 5)x @group*'

App\Group:
  users: '<randomNumber(0, 5)x @user*'

:)

Updated answer :
App\User:
  groups: '<numberBetween(0, 5)>x @group*'

App\Group:
  users: '<numberBetween(0, 5)>x @user*'


Add nf_conntrack as module

I'm trying to run k0s inside of WSL2 instance, but I got this problem on kube-proxy:
I0725 04:49:28.961290       1 node.go:163] Successfully retrieved node IP: <IP_ADDRESS>
I0725 04:49:28.961316       1 server_others.go:109] "Detected node IP" address="<IP_ADDRESS>"
E0725 04:49:28.967749       1 proxier.go:670] "Failed to read builtin modules file, you can ignore this message when kube-proxy is running inside container without mounting /lib/modules" err="open /lib/modules/<IP_ADDRESS>-microsoft-standard-WSL2/modules.builtin: no such file or directory" filePath="/lib/modules/<IP_ADDRESS>-microsoft-standard-WSL2/modules.builtin"
I0725 04:49:28.968848       1 proxier.go:680] "Failed to load kernel module with modprobe, you can ignore this message when kube-proxy is running inside container without mounting /lib/modules" moduleName="ip_vs"
I0725 04:49:28.969416       1 proxier.go:680] "Failed to load kernel module with modprobe, you can ignore this message when kube-proxy is running inside container without mounting /lib/modules" moduleName="ip_vs_rr"
I0725 04:49:28.970035       1 proxier.go:680] "Failed to load kernel module with modprobe, you can ignore this message when kube-proxy is running inside container without mounting /lib/modules" moduleName="ip_vs_wrr"
I0725 04:49:28.970623       1 proxier.go:680] "Failed to load kernel module with modprobe, you can ignore this message when kube-proxy is running inside container without mounting /lib/modules" moduleName="ip_vs_sh"
I0725 04:49:28.971291       1 proxier.go:680] "Failed to load kernel module with modprobe, you can ignore this message when kube-proxy is running inside container without mounting /lib/modules" moduleName="nf_conntrack"
E0725 04:49:28.971347       1 server.go:492] "Error running ProxyServer" err="can't use the IPVS proxier: IPVS proxier will not be used because the following required kernel modules are not loaded: [ip_vs_wrr ip_vs_sh ip_vs ip_vs_rr]"
E0725 04:49:28.971364       1 run.go:74] "command failed" err="can't use the IPVS proxier: IPVS proxier will not be used because the following required kernel modules are not loaded: [ip_vs_wrr ip_vs_sh ip_vs ip_vs_rr]"
I0725 04:52:17.678267       1 server.go:432] "Using lenient decoding as strict decoding failed" err="strict decoding error: unknown field \"udpIdleTimeout\""
W0725 04:52:17.678330       1 feature_gate.go:241] Setting GA feature gate ServiceInternalTrafficPolicy=true. It will be removed in a future release.
W0725 04:52:17.678372       1 feature_gate.go:241] Setting GA feature gate ServiceInternalTrafficPolicy=true. It will be removed in a future release.
I0725 04:52:17.690601       1 node.go:163] Successfully retrieved node IP: <IP_ADDRESS>
I0725 04:52:17.690627       1 server_others.go:109] "Detected node IP" address="<IP_ADDRESS>"
E0725 04:52:17.696504       1 proxier.go:670] "Failed to read builtin modules file, you can ignore this message when kube-proxy is running inside container without mounting /lib/modules" err="open /lib/modules/<IP_ADDRESS>-microsoft-standard-WSL2/modules.builtin: no such file or directory" filePath="/lib/modules/<IP_ADDRESS>-microsoft-standard-WSL2/modules.builtin"
I0725 04:52:17.697137       1 proxier.go:680] "Failed to load kernel module with modprobe, you can ignore this message when kube-proxy is running inside container without mounting /lib/modules" moduleName="ip_vs"
I0725 04:52:17.697737       1 proxier.go:680] "Failed to load kernel module with modprobe, you can ignore this message when kube-proxy is running inside container without mounting /lib/modules" moduleName="ip_vs_rr"
I0725 04:52:17.698300       1 proxier.go:680] "Failed to load kernel module with modprobe, you can ignore this message when kube-proxy is running inside container without mounting /lib/modules" moduleName="ip_vs_wrr"
I0725 04:52:17.698847       1 proxier.go:680] "Failed to load kernel module with modprobe, you can ignore this message when kube-proxy is running inside container without mounting /lib/modules" moduleName="ip_vs_sh"
I0725 04:52:17.699387       1 proxier.go:680] "Failed to load kernel module with modprobe, you can ignore this message when kube-proxy is running inside container without mounting /lib/modules" moduleName="nf_conntrack"
E0725 04:52:17.699426       1 server.go:492] "Error running ProxyServer" err="can't use the IPVS proxier: IPVS proxier will not be used because the following required kernel modules are not loaded: [ip_vs_wrr ip_vs_sh ip_vs ip_vs_rr]"
E0725 04:52:17.699439       1 run.go:74] "command failed" err="can't use the IPVS proxier: IPVS proxier will not be used because the following required kernel modules are not loaded: [ip_vs_wrr ip_vs_sh ip_vs ip_vs_rr]"

We are using IPVS indeed and those modules are required.

I'd vote for this. In addition, k3s seems not able to get modules like br_netfilter and overlay, too.
## systemctl reports:
    Process: 2172888 ExecStartPre=/sbin/modprobe br_netfilter (code=exited, status=1/FAILURE)
    Process: 2172889 ExecStartPre=/sbin/modprobe overlay (code=exited, status=1/FAILURE)

## Journel shows logs:
Jul 22 18:17:10 DESKTOP-OFBTPQQ k3s[335]: time="2023-07-22T18:17:10+08:00" level=info msg="Module overlay was already loaded"
Jul 22 18:17:10 DESKTOP-OFBTPQQ k3s[335]: time="2023-07-22T18:17:10+08:00" level=info msg="Module nf_conntrack was already loaded"
Jul 22 18:17:10 HOSTNAME k3s[335]: time="2023-07-22T18:17:10+08:00" level=warning msg="Failed to load kernel module br_netfilter with modprobe"
Jul 22 18:17:10 HOSTNAME k3s[335]: time="2023-07-22T18:17:10+08:00" level=warning msg="Failed to load kernel module iptable_nat with modprobe"
Jul 22 18:17:10 HOSTNAME k3s[335]: time="2023-07-22T18:17:10+08:00" level=warning msg="Failed to load kernel module iptable_filter with modprobe"

I'd vote for this. In addition, k3s seems not able to get modules like br_netfilter and overlay, too.
## systemctl reports:
    Process: 2172888 ExecStartPre=/sbin/modprobe br_netfilter (code=exited, status=1/FAILURE)
    Process: 2172889 ExecStartPre=/sbin/modprobe overlay (code=exited, status=1/FAILURE)

## Journel shows logs:
Jul 22 18:17:10 HOSTNAME k3s[335]: time="2023-07-22T18:17:10+08:00" level=info msg="Module overlay was already loaded"
Jul 22 18:17:10 HOSTNAME k3s[335]: time="2023-07-22T18:17:10+08:00" level=info msg="Module nf_conntrack was already loaded"
Jul 22 18:17:10 HOSTNAME k3s[335]: time="2023-07-22T18:17:10+08:00" level=warning msg="Failed to load kernel module br_netfilter with modprobe"
Jul 22 18:17:10 HOSTNAME k3s[335]: time="2023-07-22T18:17:10+08:00" level=warning msg="Failed to load kernel module iptable_nat with modprobe"
Jul 22 18:17:10 HOSTNAME k3s[335]: time="2023-07-22T18:17:10+08:00" level=warning msg="Failed to load kernel module iptable_filter with modprobe"

The problem can be solved by using https://github.com/hardkeo/bridge-support-on-wsl2
But both problems can be easily solved just by adding all the required components as a kernel module to be included. No need to recompile and use your own kernel too.

@wizpresso-steve-cy-fan check the kernel config file at /proc/config.gz. All the functionality you mentioned, i.e. netfilter connection tracking, is built into the kernel.
elsaco@bookworm:~$ zgrep -i nf_conntrack /proc/config.gz
CONFIG_NF_CONNTRACK=y

and virtual server support:
elsaco@bookworm:~$ zgrep -i ip_vs /proc/config.gz
CONFIG_IP_VS=y
CONFIG_IP_VS_RR=y
CONFIG_IP_VS_WRR=y
CONFIG_IP_VS_SH=y

@elsaco Hmm, strange. I have this problem kube-proxy can't load IPVS and netfilter modules.  Just make sure ipvsadm service stats/works okay.
This is sample ipvsadm output:
[root@fedora ~]# ipvsadm --list
IP Virtual Server version 1.2.1 (size=4096)
Prot LocalAddress:Port Scheduler Flags
  -> RemoteAddress:Port           Forward Weight ActiveConn InActConn
TCP  fedora:https rr
  -> fedora:sun-sr-https          Masq    1      3          0
TCP  fedora:domain rr
  -> <IP_ADDRESS>:domain            Masq    1      0          0
TCP  fedora:9153 rr
  -> <IP_ADDRESS>:9153              Masq    1      0          0
TCP  fedora:https rr
  -> <IP_ADDRESS>:10250             Masq    1      2          1
UDP  fedora:domain rr
  -> <IP_ADDRESS>:domain            Masq    1      0          0

and from kube-system logs:
---cut---
I0726 17:19:53.130260       1 server_others.go:265] "Using ipvs Proxier"
I0726 17:19:53.130311       1 server_others.go:267] "Creating dualStackProxier for ipvs"
I0726 17:19:53.130322       1 server_others.go:484] "Detect-local-mode set to ClusterCIDR, but no IPv6 cluster CIDR defined, defaulting to no-op detect-local for IPv6"
I0726 17:19:53.130680       1 proxier.go:408] "IPVS scheduler not specified, use rr by default"
I0726 17:19:53.130917       1 proxier.go:408] "IPVS scheduler not specified, use rr by default"
---cut---
Kernel version used for testing: <IP_ADDRESS>-microsoft-standard-WSL2


feat: add Orange-OpenSource/hurl

Orange-OpenSource/hurl: Hurl, run and test HTTP requests with plain text
$ aqua g -i Orange-OpenSource/hurl

How to confirm if this package works well
Reviewers aren't necessarily familiar with this package, so please describe how to confirm if this package works well.
Please confirm if this package works well yourself as much as possible.
Command and output
$ hurl
Run Hurl file(s) or standard input

Usage: hurl [OPTIONS] [FILE]...

Arguments:
  [FILE]...  Sets the input file to use

Options:
      --cacert <FILE>                     CA certificate to verify peer against (PEM format)
      --color                             Colorize output
      --compressed                        Request compressed response (using deflate or gzip)
      --connect-timeout <SECONDS>         Maximum time allowed for connection [default: 300]
  -b, --cookie <FILE>                     Read cookies from FILE
  -c, --cookie-jar <FILE>                 Write cookies to FILE after running the session (only for one session)
      --fail-at-end                       Fail at end
      --file-root <DIR>                   Set root filesystem to import files (default is current directory)
  -L, --location                          Follow redirects
      --glob <GLOB>                       Specify input files that match the given GLOB. Multiple glob flags may be used
  -i, --include                           Include the HTTP headers in the output
      --ignore-asserts                    Ignore asserts defined in the Hurl file
  -k, --insecure                          Allow insecure SSL connections
      --interactive                       Turn on interactive mode
      --json                              Output each Hurl file result to JSON
      --max-redirs <NUM>                  Maximum number of redirects allowed, -1 for unlimited redirects [default: 50]
  -m, --max-time <SECONDS>                Maximum time allowed for the transfer [default: 300]
      --no-color                          Do not colorize output
      --no-output                         Suppress output. By default, Hurl outputs the body of the last response
      --noproxy <HOST(S)>                 List of hosts which do not use proxy
  -o, --output <FILE>                     Write to FILE instead of stdout
  -x, --proxy <[PROTOCOL://]HOST[:PORT]>  Use proxy on given protocol/host/port
      --report-junit <FILE>               Write a Junit XML report to FILE
      --report-html <DIR>                 Generate HTML report to DIR
      --retry                             Retry requests on errors
      --retry-interval <MILLISECONDS>     Interval in milliseconds before a retry [default: 1000]
      --retry-max-count <NUM>             Maximum number of retries, -1 for unlimited retries [default: 10]
      --test                              Activate test mode
      --to-entry <ENTRY_NUMBER>           Execute Hurl file to ENTRY_NUMBER (starting at 1)
  -u, --user <USER:PASSWORD>              Add basic Authentication header to each request
  -A, --user-agent <NAME>                 Specify the User-Agent string to send to the HTTP server
      --variable <NAME=VALUE>             Define a variable
      --variables-file <FILE>             Define a properties file in which you define your variables
  -v, --verbose                           Turn on verbose output
      --very-verbose                      Turn on verbose output, including HTTP response and libcurl logs
  -h, --help                              Print help information
  -V, --version                           Print version information

Thanks!

Released. https://github.com/aquaproj/aqua-registry/releases/tag/v3.100.0


Mock Device API and write unit tests

closed via https://github.com/felixrieseberg/OxideFleet/pull/54


The Impact of Batch Size

I find the batch size has a very large impact on your model. Could you give an interpretation?

It depends how you are training with the different batch sizes. This issue should be relevant. If you follow the schedule when modifying the batch size, the only difference should be the training time, and the results should be similar.

Thank you very much. I have three GPUs. Each GPU is put one image. How should I adjust the learning rate and training steps for this case？

Thank you very much. I have solved this problem.


Tile Overlays

Hello,
I am going to make this view:

Is it possible to add layer to the map by using Mapsui?
Thank You

The Mapsui Map has a Layers list in which various layers can be put over each other. Layer can be of various types and have various sources. It is also possible to create your own data source. So it is possible in at least some way.
What kind of data is the overlay shown in your image?

My map data is collection .png images.

I see we don't have a sample for this fairly simple case. Perhaps you can draw get something out of the 'Tiles' sample under test. Basically these are just a couple of images that a loaded. This sample is more fancy because they a used within a tileschema. You need to load just one image as a 'Raster' geometry.
What you need to do:

Add a MemoryLayer
Create a Raster geometry. It get two parameters:

The Boundingbox in sphericalmercator. Perhaps you need to convert those with SphericalMercator.FromLonLat.
The data. This is a MemoryStream of the png. You could read the stream from file and put that stream into a MemoryStream.

Create a Feature and assign the Feature.Geometry with the Raster.

@Kayumiy  any progress?

I try to achieve a similar thing. The goal is to overlay an image to a certain geographical area, that is rotated, so far I haven't found the right way to do it.

A raster renders the image just fine and at the right area, but I can't rotate it.
I managed to show the rotated boundaries of the image using a polygon, but then I fail to display the image within those bounds.
With a point (and a SymbolStyle) I was able to display the image and rotate it, but then it doesn't scale with the map zooming

Any hint on what to use for such a scenario would be greatly appreciated!

ah, the source image itself is not rotated. That makes it harder.
What I can think of:

Rotate the source image before adding it as a Raster type. You could try to use skiasharp for that.
Create your own custom style renderer. Prettig much everything is possible there.

https://mapsui.com/documentation/custom-style-renders.html

Additional notes: In the WPF renderer we had a point geometry that did scale with the map (UnitType.WorldUnit). This was used for your purpose. This was never implemented in the skiasharp renderer. Also this did not work well because the boundingbox was not taken into account when the image was partially visible, when the central point moved out of view the whole image disappeared. So a better solution would be to add a Rotation to Raster. If this is added we should also take into a account the change in boundingbox of the raster. Like we do with the Viewport.WindowExtend (Quad).

@pauldendulk thanks for you help! I ended up using a Raster and rotating the image using SkiaSharp upfront, as you suggested.
Now my remaining problem is an offset, which is likely caused by the fact that my BoundingBox is created from the original image's bounds, not from the rotated one (because I don't get those from my source).
I tried to use a Quad, rotate it and feed the result of ToBoundingBox() into the raster but that always results in nothing rendering anymore. Here's the relevant portion of the code:
var bb = new BoundingBox(SphericalMercator.FromLonLat(lowerLeftLon, lowerLeftLat), SphericalMercator.FromLonLat(upperRightLon, upperRightLat));
Quad qd = new Quad(bb.BottomLeft, bb.TopLeft, bb.TopRight, bb.BottomRight);
Quad rotated = qd.Rotate(Rotation, 0, 0);
this.Raster = new Raster(stream, rotated.ToBoundingBox());

Am I using the Quad wrong, or are there any other means to rotate a BoundingBox?

Can you make the rotated image itself visible with the regular boundingbox? It will not be in the right position but at least visible. If not something is wrong with the conversion. Perhaps the compression is not supported.

Yes, with the regular bounding box it is visible. It's just a little too small, my example rotates by 9 degrees.

Okay, so you need to calculate the bigger encapsulating bounding box. I assume you can use the Quad for that somehow, but I can't tell you from memory how to exactly use. How about putting a breakpoint in there to see if the values make sense?

That's what I already tried, sort of...in my understanding the values were too big, but those were SphericalMercator already and so I can't tell for sure. Then I also wonder why the image didn't render just bigger, instead of not at all.
I suppose I can try to extend my example code above and transform the resulting BoundingBox back into WGS84 coordinates again, that would allow me to jugde whether they are reasonable or not.

Okay, I made this work now. The mistake was in the rotation point coordinates of the quad, which I assumed were relative, but are in fact absolute numbers. So the relevant piece of code now looks as follows:
var bb = new BoundingBox(SphericalMercator.FromLonLat(lowerLeftLon, lowerLeftLat), SphericalMercator.FromLonLat(upperRightLon, upperRightLat));
Quad qd = new Quad(bb.BottomLeft, bb.TopLeft, bb.TopRight, bb.BottomRight).Rotate(Rotation, bb.Centroid.X, bb.Centroid.Y);
this.Raster = new Raster(stream, qd.ToBoundingBox());

Thanks for your help!

ah great! thanks for reporting the solution back on the issue so others can use it.


create platform for remote execution

Platform target defines container to use for remote builds.
This PR is part of the process to deprecate use of
experimental_remote_platform_override which will consolidate the
definition of the container to use for remote builds.
also update dockerfile for rbe to indicate base is Ubuntu 16-04

@erain @yifeif @gunan - could you please review? thanks!


Add concentration button on character sheet, show concentration effects

... ... ... ...

Would it be any clearer if this was maybe in the spellbook tab instead? I get the feeling that most things that need concentration are gonna be in the spell book / reminding people that they are concentrating on something while searching through their spellbook


Try fixing python windows artifact build

Tentative fix for https://github.com/grpc/grpc/issues/14317

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Windows artifacts have build successfully with this change and the script doesn't influence anything else.
Merging to fix #14317 ASAP.

Corrupt JSON data (indicates timeout or crash):
    bm_fullstack_streaming_pump.BM_PumpStreamServerToClient_SockPair__0.opt.old: 1

[microbenchmarks] No significant performance differences


Time Series Line Chart: Markers disappear on fade-out/fade-in

Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if any
[x] I have reproduced the issue with at least the latest released version of superset
[x] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version
0.20.3, but already observed, e.g., in 0.15.4
Browsers tested: Firefox, Vivaldi
Expected results
Fading out and back in of series — by clicking the markers in the legend — in a Time Series Line Chart preserves the markers.
Actual results
Once a series is faded out and back in, the markers of the series is gone until reload of the slice.
If all but the clicked series are deselected (via double-click) and then back in, all of them have lost their markers
Steps to reproduce
Create a Time Series Line Chart slice, check Show Markers and render the slice.
Then deselect and re-select any of the shown series. The markers are gone then.

Notice: this issue has been closed because it has been inactive for 198 days. Feel free to comment and request for this issue to be reopened.

@mistercrunch please reopen, as this can lead to missed data points, which in my eyes is pretty severe.

Looks like an nvd3 bug to me.


[Feature Request] Make token indexing work for batched input

Using .token[0] returns the padding token
from nnsight import LanguageModel
model = LanguageModel("gpt2", device_map="cpu")

probs = model.trace("a zd zdb", trace=False).logits
with model.trace(["ab dfez zd", "a", "b"]):
    inp = model.input.save()
    inp2 = model.input[1]['input_ids'].t[0].save()
print(inp, inp2)

out:
(((), {'input_ids': tensor([[  397,   288,  5036,    89,  1976,    67],
         [50256, 50256, 50256, 50256, 50256,    64],
         [50256, 50256, 50256, 50256, 50256,    65]]), 'attention_mask': tensor([[1, 1, 1, 1, 1, 1],
         [0, 0, 0, 0, 0, 1],
         [0, 0, 0, 0, 0, 1]])}),
 tensor([  397, 50256, 50256]))

Name: nnsight
Version: 0.2.16

Oh wait, seems like token indexing is supposed to work only with tracer.invoke calls.
It would be nice if it also works on directly batched input, not sure how easy it is to add it with the current implementation

Ok but with UnifiedTransformer, token indexing doesn't work as padding side is right by default :
l = ["ab dfez zd", "a", "b"]
from nnsight import LanguageModel
model = LanguageModel("gpt2", device_map="cpu")

with model.trace(l):
    inp = model.input[1]['input_ids'].token[0].save()

with model.trace() as tracer:
    inp_l = []
    for s in l:
        with tracer.invoke(s):
            inp_l.append(model.input[1]['input_ids'].token[0].save())

from nnsight.models.UnifiedTransformer import UnifiedTransformer
umodel = UnifiedTransformer("gpt2", device="cpu")

with umodel.trace() as tracer:
    inp_l2 = []
    for s in l:
        with tracer.invoke(s):
            inp_l2.append(umodel.input[1]['input'].token[0].save())
print(inp)
print([i.item() for i in inp_l])
print([i.item() for i in inp_l2])


Fix children rerendering

When a prop gets changed, the component re-renders all children, although it's not necessary. This behaviour (while obviously hindering performance) can lead to graphical glitches when manipulating the currentPage. Deep equal in componentWillReceiveProps fixes it.
I had to introduce a new dependency on lodash to compare the children in a simple and proper way, hope that's not a problem.

Yea, definitely!


HOSTEDCP-967: Disable v1alpha1 and conversion webhook by default

What this PR does / why we need it:
Disables v1alpha1 and the conversion webhook by default when installing hypershift.
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #HOSTEDCP-967
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/approve

Very cool!
/lgtm

/retest-required

/retest-required

/lgtm

being reverted because of failure in CI https://github.com/openshift/hypershift/pull/2627
4.13 mgmt cluster fails to install with CNO unable to set HCP
https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn/1663758898563125248/artifacts/e2e-aws-ovn/dump-management-cluster/artifacts/namespaces/clusters-5348ac4a5940f68ab232-mgmt/core/pods/logs/cluster-network-operator-6bc47d8d57-k5st7-cluster-network-operator.log
Failed to set HostedControlPlane: conversion webhook for hypershift.openshift.io/v1beta1, Kind=HostedControlPlane failed: Post "https://operator.hypershift.svc:443/convert?timeout=30s": dial tcp <IP_ADDRESS>:9443: connect: connection refused


Performers must acquire a token when the gesture recognizers are active

See the ContinuousPerforming spec: https://material-motion.github.io/material-motion/starmap/specifications/runtime/Performer

💻 I'm working on a diff at http://codereview.cc/D1907

🎊 My diff is ready for review at http://codereview.cc/D1907


[sidenav @alpha.8-1] Binding to [opened] causes Angular AoT compiler error

Bug, feature request, or proposal:
Bug
What is the expected behavior?
The docs for sidenav  list opened as a public facing property. I expect to be able to bind to it and use Angular's Ahead-of-Time compiler (ngc)
What is the current behavior?
template
<md-sidenav-layout class="sidenav-layout">
    <md-sidenav mode="over" [opened]="isNavOpen">
        ...
    </md-sidenav>
    ...
</md-sidenav-layout>

component
public isNavOpen:boolean = false;

Trying to bind to [opened] this way causes ngc to throw the following error:
 Error: (filename:line number): Property '_opened' is private and only accessible within class 'MdSidenav'.

Triggered by the block below (line 795):
793|  const currVal_27:any = this.context.isNavOpen;
794|  if (import5.checkBinding(throwOnChange,this._expr_27,currVal_27)) {
795|     this._MdSidenav_51_4._opened = currVal_27;
796|     changed = true;
797|     this._expr_27 = currVal_27;
798|   }

Using in-browser compilation works fine. In that scenario, no error is raised during vanilla typescript transpilation
What are the steps to reproduce?
Use the template above, and try AoT compilation
Which versions of Angular, Material, OS, browsers are affected?
Angular 2 rc.6, Material 2 alpha 8-1, compiled using node 4.5.0

Related to #1163

Bug was fixed with alpha 9-3


Robust looping over submissions

Command to run a specific model on a benchmark.
Implement a script that runs multiple models (without submitting) and knows how to handle errors
We can also provide a command for auto approving the results (make sure to explain to data owners that they trust the model and the results)

Duplicate of #213 and #207


I can't seem to run the test.py.

Every time I run it I get the error below.
P.S. I am also running the carla server with the command ./CarlaUE4.sh -windowed -carla-port=2000 before running the test script
(driving) joshua@joshua:~/gym-carla$ python test.py
pygame 1.9.6
Hello from the pygame community. https://www.pygame.org/contribute.html
connecting to Carla server...
Traceback (most recent call last):
  File "test.py", line 55, in <module>
    main()
  File "test.py", line 43, in main
    env = gym.make('carla-v0', params=params)
  File "/home/joshua/anaconda/envs/driving/lib/python3.6/site-packages/gym/envs/registration.py", line 156, in make
    return registry.make(id, **kwargs)
  File "/home/joshua/anaconda/envs/driving/lib/python3.6/site-packages/gym/envs/registration.py", line 101, in make
    env = spec.make(**kwargs)
  File "/home/joshua/anaconda/envs/driving/lib/python3.6/site-packages/gym/envs/registration.py", line 73, in make
    env = cls(**_kwargs)
  File "/home/joshua/gym-carla/gym_carla/envs/carla_env.py", line 90, in __init__
    self.world = client.load_world(params['town'])
RuntimeError: rpc::rpc_error during call in function version

We haven't seen this problem before, what OS and carla version are you using?

I am running Linux Ubuntu with CARLA 0.8.4. Could the carla version be the reason behind the problem. Thanks for the response

Yes please use 0.9.6 as stated in the readme.

I am actually using CARLA_0.9.6 but still getting the same error message

I have the same error too


Question: Does Pydantic support conditional aliasing

Suppose that I have a class like this:
class Property(BaseModel):
	address: str
	is_house: bool

When is_house is true, I would like to serialize this to:
{
	"houseAddress": "123 street street"
}

When is_house is set to false, I would like to serialize this to:
{
	"apartmentAddress": "123 street street"
}

Does Pydantic support conditional aliasing?

Much the simplest (both to write and understand) approach would be something like:
p = Property(address='xxx', is_house=whatever)
key = 'houseAddress' if p.is_house else 'apartmentAddress'
data = {key: p.address}

In short the answer is no, but that's probably right - doing so would be unnecessarily complicated.

Thanks @samuelcolvin !


TERMS AND CONDITIONS

Issue Type

[ ] Bug Report

[x] Feature Request

[ ] Question

Description
Adding content for terms and conditions and updating documentations.
TERMS AND CONDITIONS.txt
Steps to Reproduce (For Bug Reports)

Expected Behavior (For Bug Reports)

Actual Behavior (For Bug Reports)

Proposed Solution (For Feature Requests)

Additional Context

Environment

OS: [e.g., Windows, MacOS, Linux]
Browser: [e.g., Chrome, Firefox, Safari]
Version: [e.g., 1.0.0]

Checklist

[x] I have searched the existing issues for duplicates.
[ ] I have provided detailed steps to reproduce the bug (if applicable).
[ ] I have described the expected and actual behavior (if applicable).
[x] I have provided a proposed solution (for feature requests).
[ ] I have included relevant environment details.

Additional Comments

@anjali20040322  attachment link or file?

Hey @anjali20040322 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Initial Haiku support

This patch extracted from the mame patchset: mamedev/mame#5053

makefile is now broken.
Also notice BX_PLATFORM_* it's all alphabetically sorted.

Oh, let me recheck...

See: https://github.com/bkaradzic/bx/commit/a8cf4e3b0775a2f07df4c75205bafb480ff3feff

Sorry for making you extra work, i wanted to finish it today afternoon.
Thanks.

@extrowerk Did you ever finish this?

There is nothing other than haiku name in scripts/toolchain.lua. Do examples work on Haiku?

I tought it is finished, isnt it?
Give me pls some days to recheck, have an exam at tuesday, so only after that can i mess with it again.

I used bx with mame, seened to work correctly. What exactly needs to be finished here?
Cant remember to the examples anymore.

What exactly needs to be finished here?

Haiku in toolchain.lua is mentioned only here:
https://github.com/bkaradzic/bx/blob/3c49d305e546bc9cf421e2afb9c4487170a3b7e7/scripts/toolchain.lua#L78
I don't think that works for building bx/bgfx/etc. maybe you had extra configuration for MAME?

I tried to check, but i had to see i also need genie, but afair you decided to not accept my genie patches. So idk.
What would you do in similar situation?

There should not be any GENie changes. I assume Haiku has Clang or GCC compiler toolchain?

Yep, both available. But i posses no genie binary and what does it brings if i build one if you don't accept the patches? BX still needs genie to build.

But with GENie it's possible to generate project files on one platform (i.e. Linux, Windows, OSX), and then copy those files and make build. Or run cross-compiler on one platform that supports GENie.
Right now there is issue that Haiku is not really buildable in any way.

While everything what you wrote is true, this doesn't helps in my case as i have no other OS, so using cross-compiling or preparing the makefiles on other supported OS ist out of question.
Idk, man, i don't want to change your pragmatic way, but i also wont change mine. I would be more than happy to nail this down as it is really cumbersome to patch the mame source tree for genie, as they already merged all my mame patches (they don't accept patches for genie). Maybe it would be much easier to purge every mention of Haiku in each of your projects and to try to convince the mame guys to use cmake or something else instead of genie.


Adds validation: parameter name must be specified if value is specified

In the create form, if the parameter value is nonblank, the parameter name must not be blank.
If the parameter name and value are both blank, there is no error.
If the parameter name is nonblank and the value is blank, there is no error.
Errors are displayed on name or value blur.
There is no validation for the value.
https://user-images.githubusercontent.com/93281816/193168959-4eb43689-e8bf-447f-8f91-3098c5e45566.mov

@jweill-aws
I am not sure about allowing a parameter name with blank value. It would seem that in most cases this is likely an oversight by the user and they probably missed providing a value; prompting user to add a value in this case is likely the right intent. What do you think?

@jweill-aws I am not sure about allowing a parameter name with blank value. It would seem that in most cases this is likely an oversight by the user and they probably missed providing a value; prompting user to add a value in this case is likely the right intent. What do you think?

A parameter with a name and an empty-string value is not inherently an error; there might be a reasonable reason for that. (The errors variable uses an empty-string value to mean "no error" for a particular input name, for example.) @ellisonbg had suggested the specific case of "empty parameter name, non-empty parameter value" being an error, but I don't consider the other three cases to be problematic:

Empty name
Name

Empty value
✅
✅

Value
❌
✅

A parameter with a name and an empty-string value is not inherently an error; there might be a reasonable reason for that.

I believe this is to preserve parity with shell environment variables, which can be defined without values. A common example is just to define export DEBUG in your local shell and have an application dispatch additional logging based on that.

Other bugs I found while playing around:
https://user-images.githubusercontent.com/44106031/193327050-06e5314a-eaee-4144-83b8-57f6d2ce7422.mov
Deleting param should clear the corresponding errors.
https://user-images.githubusercontent.com/44106031/193327448-7a142d7a-c95a-411b-a765-f3e77ffa9d73.mov
Error state is not being correctly re-calculated upon deleting a param in the middle.

@jweill-aws @3coins I rebased off of main, removed the useForceUpdate() hook, and fixed the aforementioned error state bugs.


v8x16.shuffle optimizations needed

I translated the IDCT SSE code into Wasm. The algorithm uses lots of various punpckxxxx instructions, though WebAssembly has v8x16.shuffle. The v8 lowers into native SSE2 equivalents by matching immediate argument. I cannot find if we do it for any of the cranelift backends.
STR:

Use test case at https://github.com/yurydelendik/zbar-wasm/raw/0083a9a48c8c06e5555424d85f71ce5a4b560145/zbar_jpeg/test.wasm
Run time wasmtime run --enable-simd test.wasm --invoke test500

Observe the time; it is about 15 sec here. Node runs test.wasm (_initialize + test500) in about 11 sec here.
It is expected that wasmtime/cranelift will improve the performance by using specialized SSE2 instructions by 40-50%.

I agree; perhaps this benchmark could be adapted for sightglass?

perhaps this benchmark could be adapted for sightglass?

Not familiar with the sightglass. Can you sketch what needs to be done?

Here is a high-level document describing the basic idea and here is an example.

Can confirm that all these shuffles are now implemented, even on aarch64 too. All i8x16.shuffle instructions present in the above module are compiled to single-instruction lowerings on both x86_64 and aarch64. In that case I'm going to close this.


Separate old request API from new [SA-16145-2] develop

Overview
This PR changes the specification for requests to make clear that two schemas are supported:

the older schema in which user, author, type, roles, campuses, folders, and guests are specified as ids
the newer schema in which user, author, type, roles, campuses, folders, and guests are specified as object stubs

Splitting the specification up in this way has made the schema and examples easier to understand as well as the specification.

Question
@armatronic sometime during the previous PR I started documenting the old way this API worked (e.g. ids instead of object stubs, and localised dates instead of RFC3339 dates).  It occurs to me now that that API was not previously documented, so perhaps there is no need to document the old request format.
Should I remove the old request format from the API docs?

The API docs are not showing the above, but as far as I can tell, the specification is correct.  So I think maybe Redocly is not representing the specification correctly?
This is the problem section (in openapi/components/schemas/calendar/eventRequestFields.yaml):

The above specification states that oneOf {userId, user} is required, and oneOf {authorId, author} is required.
But the API docs show the following:
(note it is saying that oneOf {userId, user, authorId, author} is required.

What do you think @armatronic?
This answer shows how to do a similar thing using JSON syntax:
https://stackoverflow.com/questions/75817120/multiple-oneof-conditions-for-different-attributes
This tool converts YAML to JSON:
https://onlineyamltools.com/convert-yaml-to-json

Should I remove the old request format from the API docs?

Yes. There's no benefit to documenting it, as:

it was never documented in the first place
keeping the old format around will IMO just confuse users of the API

Should I remove the old request format from the API docs?

Yes. There's no benefit to documenting it, as:
* it was never documented in the first place

* keeping the old format around will IMO just confuse users of the API

This has been done.


Upgrade to TUI 1.10.0

Version
1.0.3
Test Environment
MacOSX - Firefox
Current Behavior
In firefox it's not possible to create new entries due to a defect in toast UI itself that has been fixed in the latest version of TUI (1.10.0)
Expected Behavior
Could you please reference to the latest Toast-UI version so it becomes usable again for FF? Thanks a lot!

@Phantom75
If the schedule is urgent, install the latest version of the tui calendar on your project.
$ npm i tui-calendar@latest

I'll update the package.json file. :-)


[WIP]Improve unit cases stablity and coverage

[ ] Fix unstable test cases
[ ] Improve unit cases

:white_check_mark: Build AElf <IP_ADDRESS>16 completed (commit https://github.com/AElfProject/AElf/commit/7caa1840b2 by @EricBlack)

:x: Build AElf <IP_ADDRESS>58 failed (commit https://github.com/AElfProject/AElf/commit/80a13ba31d by @EricBlack)

:x: Build AElf <IP_ADDRESS>62 failed (commit https://github.com/AElfProject/AElf/commit/26abbe53a4 by @EricBlack)

:white_check_mark: Build AElf <IP_ADDRESS>63 completed (commit https://github.com/AElfProject/AElf/commit/0fbfee6e62 by @EricBlack)

:x: Build AElf <IP_ADDRESS>67 failed (commit https://github.com/AElfProject/AElf/commit/7b16201e58 by @aerkol)

:x: Build AElf <IP_ADDRESS>86 failed (commit https://github.com/AElfProject/AElf/commit/0731d1d0e0 by @aerkol)

:white_check_mark: Build AElf <IP_ADDRESS>38 completed (commit https://github.com/AElfProject/AElf/commit/bd5eed3939 by @EricBlack)

:white_check_mark: Build AElf <IP_ADDRESS>53 completed (commit https://github.com/AElfProject/AElf/commit/afbd03a7a8 by @EricBlack)


Double-check if PA/PQ/Precision/Recall/F1 are matching

There are doubts that PA/PQ/Precision/Recall are matching given the results:
http://langlearn.singularitynet.io/data/clustering_2019/cALEd-500-GCB-LG-E-noQuotes-S94-2019-04-02/GCB_LG-E-noQuotes_cALWEd_no-gen_mwc=2/GC_LGEnglish_noQuotes_fullyParsed.ull.stat
Total sentences parsed in full:		 44.80%
Total sentences not parsed at all:	 12.09%
Average sentence parse:			 68.81%
Total sentences:			68826.00
Skipped sentences:			0.00
Parse time:				0h 25m 44s 271ms
Parse quality:	 63.78%
Average total links:	10.46
Average ignored links:	0.00
Average missing links:	4.00
Average extra links:	0.37
Recall:		 63.78%
Precision:	 77.26%
F1:		  0.70
Total sentences: 68826.00
Need to create unit test on that with input corpus of 5 input sentences 6 words and 5 links each total 25 expected links agains test corpus of only 4 parsed sentences with 20 links (PA=80%) with 1 wrong link in the every sentence (Precision = 15/20 = 0.75, Recall = 15/25 = 0.6, F1 = 0.66666667)
Need to add statistics to the GT output:
Expected links:
Parsed links:
Matched links:
@OlegBaskov @alexei-gl - please check the math for the above.

Simple math considerations:
If Average sentence parse = 68.81% ~ number_of_parsed_links / number_of_links_in_test_corpus:
Average_sentence_parse * Precision ~ 0.6881*0.7726 ~ 0.53.
This means that we have correctly learned 53 links of every 100 links present in the test corpus, all 100 presumed correct.
Why recall is 63.77% and not 53%?

@OlegBaskov - clan we close this in favor of #200

"Alternative" F1 estimation -- Alternative_F1_for_ALE_ILE%20clustering_2019-04-12.html

Understood. Continuation in #200


CEP-57: Introducing Check-sum encoding for hex representations

Implements https://github.com/casper-network/ceps/pull/57
Closes #1415

Superseded by #1900


Custom tileset materials display as grey when loaded from USD

Custom tileset materials appear to not be displaying correctly when loaded from a USD, despite working when initially created prior to saving.
Reproduction steps

Create a custom material with a custom colour or some other visual difference.
Assign it to a tileset, it should display correctly
Save the stage as a USDA
Reload the USDA, material will now be grey

Reproduced in:
USD Composer 2023.2.2-prod.2
https://github.com/CesiumGS/cesium-omniverse/tree/1eadd69a744d347c2c1218c6f6b936cead0b0cd5

This seems to be a recent regression. I can't reproduce in USD Composer 2023.2.1 Beta.

Based on some early debugging materialHasCesiumNodes can't find any connection attributes and so it doesn't try to apply styling. Sill investigating why the connection attributes aren't there.
105.1.2 on the left, 105.1 on the right

ferry-building-2.zip

After some more investigation, this seems to be an issue with Fabric material population.
When I create something in material graph and print the stage I see this:
Prim: /World/Looks/OmniPBR (12583425)
  Attributes:
    Attribute: outputs:mdl:volume
      Type: token
      Value:
    Attribute: outputs:mdl:displacement
      Type: token
      Value:
    Attribute: outputs:mdl:surface
      Type: token
      Value:
    Attribute: outputs:mdl:volume
      Type: connection
      Value: Path: /World/Looks/OmniPBR/Shader, Attribute Name: out
    Attribute: outputs:mdl:displacement
      Type: connection
      Value: Path: /World/Looks/OmniPBR/Shader, Attribute Name: out
    Attribute: outputs:mdl:surface
      Type: connection
      Value: Path: /World/Looks/OmniPBR/Shader, Attribute Name: out
    Attribute: Material
      Type: tag (primTypeName)
    Attribute: UsdTyped
      Type: tag (ancestorPrimTypeName)
    Attribute: NodeGraph
      Type: tag (ancestorPrimTypeName)
    Attribute: TfType::_Root
      Type: tag (ancestorPrimTypeName)
    Attribute: UsdSchemaBase
      Type: tag (ancestorPrimTypeName)

However, when I save the project and reload the .usda I see this:
Prim: /World/Looks/OmniPBR (12584705)
  Attributes:
    Attribute: Material
      Type: tag (primTypeName)
    Attribute: NodeGraph
      Type: tag (ancestorPrimTypeName)
    Attribute: UsdSchemaBase
      Type: tag (ancestorPrimTypeName)
    Attribute: UsdTyped
      Type: tag (ancestorPrimTypeName)
    Attribute: TfType::_Root
      Type: tag (ancestorPrimTypeName)

The connection attributes are missing and this is causing problems for how we apply materials to tiles.
What this means is that we can create materials and assign them to tilesets in the same session, and that all works. But if we reload projects it doesn't work.

A workaround is to assign the material to some other object on the stage. Then it will populate correctly on reload. Note the _materialSource attribute.
Prim: /World/Looks/Material (59393)
  Attributes:
    Attribute: _materialSource
      Type: rel
      Value: [38913]
    Attribute: Material
      Type: tag (primTypeName)
    Attribute: MergedMaterial
      Type: tag (primTypeName)
    Attribute: UsdTyped
      Type: tag (ancestorPrimTypeName)
    Attribute: NodeGraph
      Type: tag (ancestorPrimTypeName)
    Attribute: UsdSchemaBase
      Type: tag (ancestorPrimTypeName)
    Attribute: TfType::_Root
      Type: tag (ancestorPrimTypeName)

tileset-material-workaround.zip (this works once https://github.com/CesiumGS/cesium-omniverse/pull/644 is merged)
A proper fix is being worked on where it populates from anything with a MaterialBindingAPI, which includes CesiumTilesetPrim. Until then we have this kind of awkward work around.


Group hash growth unbounded?

Hey All, I noticed that when moving a sprite from one group to another via the add call, it's not removed from the original group's hash. Is this intended?
IE (pseudo code)
var sprite = someSprite;

groupOne.add(sprite);
// groupOne.hash === [sprite]
// groupTwo.hash === []

groupTwo.add(sprite);
// groupOne.hash === [sprite]
// groupTwo.hash === [sprite]

This is with V2.4.3

FWIW, I'd be happy to submit a fix along with tests here if it's a real issue

Yes, I can confirm this for 2.4.4 too.
Group hash grows and hold references to already destroyed sprites, causing memory leaks.
But this only happens when the sprite has a physics body:
var group1;
var group2;
function create() {
    game.physics.startSystem(Phaser.Physics.P2JS);
    group1 = game.add.group();
    group2 = game.add.group();

    var sprite=game.add.sprite(0,0);
    game.physics.p2.enable(sprite);
    console.log("Should return false: "+(group1.hash.indexOf(sprite)>=0));

    group1.add(sprite);
    console.log("Should return true: "+(group1.hash.indexOf(sprite)>=0));

    group2.add(sprite);
    console.log("Should return false: "+(group1.hash.indexOf(sprite)>=0));
}

Workarounds:

Remove the child from the original group before adding it to another group
Call if (this.parent && this.parent.remove)this.parent.remove(this); before adding to a group

Suggested Bugfix:
The reason for this bug is, that add calls this.addChild (Line 31402 in phaser.js) wich removes the sprite from the children of its parent sprite. But because this is in PIXI code, removeFromHash is not called. Perhaps this should be called before addChild.

This is now fixed in dev.


Help adding custom fonts

Problem
I'm quite new to Slate and can't seem to be able to figure out how to add custom fonts. I tried solutions from here - Add custom fonts to slate 1.x, but none of them work, I just get Module parse failed: Unexpected character ' ' (1:4) You may need an appropriate loader to handle this file type. errors.
Any help would be much appreciated

We're working on documentation for custom fonts, but here's how it should look :

Have your font files in a flat structure in assets/fonts
Add your font-face declaration in any .scss file like styles/theme.scss and make sure your src path are relative to the fonts folder :

@font-face {
  font-family: 'geomanistblack';
  src: url('../fonts/geomanist-black-webfont.eot');
  src: url('../fonts/geomanist-black-webfont.eot?#iefix') format('embedded-opentype'),
       url('../fonts/geomanist-black-webfont.woff2') format('woff2'),
       url('../fonts/geomanist-black-webfont.woff') format('woff'),
       url('../fonts/geomanist-black-webfont.ttf') format('truetype'),
       url('../fonts/geomanist-black-webfont.svg#geomanistregular') format('svg');
  font-weight: normal;
  font-style: normal;
}

h1 {
  font-family: 'geomanistblack';
}

You will have to run yarn deploy once after you added the fonts to make sure they are on Shopify's CDN.

Doesn't seem to be working. As soon as I add:
@font-face {
	font-family: 'Corbel';
	src: url('../fonts/37C2F5_0_0.eot');
	src: url('../fonts/37C2F5_0_0.eot?#iefix') format('embedded-opentype'),
	     url('../fonts/37C2F5_0_0.woff2') format('woff2'),
	     url('../fonts/37C2F5_0_0.woff') format('woff'),
	     url('../fonts/37C2F5_0_0.ttf') format('truetype');
	font-weight: bold;
  	font-style: italic;
}

to theme.scss, I start getting the same errors as before:
./assets/fonts/37C2F5_1_0.woff 1:4
Module parse failed: Unexpected character ' ' (1:4)
You may need an appropriate loader to handle this file type.
(Source code omitted for this binary file)
 @ ./assets/styles/theme.scss (../node_modules/css-loader??ref--11-1!../node_modules/postcss-loader/lib??postcss!../node_modules/sass-loader/lib/loader.js??ref--11-3!./assets/styles/theme.scss) 7:894-929
 @ ./assets/styles/theme.scss
 @ ./assets/scripts/layout/theme.js
 @ multi<EMAIL_ADDRESS>./assets/scripts/layout/theme.js

Replicated the error with a fresh Slate install and a different font

Do you only get the error on the .woff file? or all the file? so (4-5 error messages)
I just did the steps with a fresh yarn create slate-theme my-new-theme and it works fine.
Maybe it's a font problem?

I get errors for all of the files (eot, ttf, woff, woff2).
I tested the fonts that I need (Corbel from Myfonts), then different fonts from Google Fonts and Fontsquirrel. I get errors for all of them.
Could someone try downloading the woff+ttf Webfont kit with the default subset from here - https://www.fontsquirrel.com/fonts/open-sans
And use the following CSS in theme.scss to eliminate the possibility of a font issue?
@font-face {
    font-family: 'open_sansregular';
    src: url('../fonts/OpenSans-Regular-webfont.woff') format('woff'),
         url('../fonts/OpenSans-Regular-webfont.ttf') format('truetype');
    font-weight: normal;
    font-style: normal;
}

Seems like this is a Windows 10 (or at least my particular Windows 10 setup) issue. Tried replicating the above in Ubuntu VM and no errors

I would suggest to reference your fonts inside the theme.liquid file via the

Assets have been simplified in #850 and the change is now available in v1.0.0-beta.12
Docs that have also been updated:

https://github.com/Shopify/slate/wiki/Slate-themes
https://github.com/Shopify/slate/wiki/Template-and-layout-bundles
https://github.com/Shopify/slate/wiki/Local-development


Does this document apply to the scenario from 2012 R2 to 2019

Hello
This page talks about moving from Windows 2012 R2 to Windows 2016, but does it also work for moving from Windows 2012 R2 to 2019?
or
Does the scenario on the page below work with SQL server and not WID?
I currently have a 2012 R2 farm, and I'm looking for the guide that explains how to move from Windows 2012 R2 with SQL to Windows Server 2019.
https://learn.microsoft.com/en-us/windows-server/identity/ad-fs/deployment/upgrading-to-ad-fs-in-windows-server
If you know, it would be great if you could tell me that.
Thanks

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9f02b39a-271d-fed9-5700-1e849f66d7cc
Version Independent ID: 9797c82c-0d33-f412-6fc8-2c9f197a602a
Content: Upgrading to AD FS in Windows Server 2016 with SQL Server
Content Source: WindowsServerDocs/identity/ad-fs/deployment/upgrading-to-ad-fs-in-windows-server-sql.md
Product: windows-server
Technology: ad-fs
GitHub Login: @billmath
Microsoft Alias: billmath

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


Support K8s Cert-manager

What should we add or change to make your life better?
A large portion of companies will be using cert-manager (https://cert-manager.io/) in k8s to manage certificates. These will typically get mapped to a folder in the pods.
I'd like to see yarp explicitly be able to handle this scenario and integrate directly with cert-manager so that certificates are loaded, and reloaded when updated automatically and transparently.
Why is this important to you?
Managing certificates is hard, and lots of environments automate this without using lets encrypt. Having an example and workflow for this will increase adoption of yarp and make it easier for companies such as ourselves to integrate with cert-manager which works well under k8s.

Do you want to be able to tell cert-manager to issue certificates, or do you want to only consume them via kubernetes secrets?

This should be achievable as long as Kestrel is configured with the right configuration that points to the files on disk.

This should be achievable as long as Kestrel is configured with the right configuration that points to the files on disk.

Do you have any suggestions? Haivng an example and documentation would be highly useful and I suspect would result in increased adoption given that certificates are a huge portion of what YARP is doing and under K8s this is VERY not straight forward if you aren't an expert even at the best of times, let alone having to cycle a deployment when the certs are updated.

Indeed, sorry I was thinking about YARP as an ingress. @davidfowl sugegstion is the easiest one to use: when you create your YARP services, mount the secret to a known location, and reference it in the config of your reverse proxy?

Triage: Seems to be answered. Closing.
We should create new issue to track YARP ability to swap cert on the fly from k8s secrets.


error when running the code

Thanks for your great work. I built the environment successfully following the instructions , however , I met this error when running the code :
Traceback (most recent call last):
File "/data/cz/dmesh/exp/1_mesh_to_dmesh.py", line 16, in
from diffdt import DiffDT
File "/data/cz/dmesh/diffdt/init.py", line 5, in
from diffdt.pd import PDVertexComputationLayer, PDStruct
File "/data/cz/dmesh/diffdt/pd.py", line 8, in
from . import _C
ImportError: libtbb.so.12: cannot open shared object file: No such file or directory

Hi, can you please check if you correctly installed OneTBB, following the instruction?
It seems that OneTBB has not been installed.

Thanks, I upgraded the version of torch to 2.2.1 and updated the version of Cmake, and now the problem is solved

Great, thanks for your interest!

Awesome work!!
Unfortunately, I am still facing the same issues. I have installed everything according to the README description but I am finding myself stuck on this issue :
Traceback (most recent call last):
File "/home/astonishingwolf/3d-graphics/dmesh/exp/2_pc_recon.py", line 10, in
from exp.recon import BaseRecon, DEVICE, DOMAIN
File "/home/astonishingwolf/3d-graphics/dmesh/exp/recon.py", line 6, in
from diffdt.wp import WPoints
File "/home/astonishingwolf/3d-graphics/dmesh/diffdt/init.py", line 5, in
from diffdt.pd import PDVertexComputationLayer, PDStruct
File "/home/astonishingwolf/3d-graphics/dmesh/diffdt/pd.py", line 8, in
from . import _C
ImportError: libtbb.so.12: cannot open shared object file: No such file or directory
One TBB seems to be installed.  I have installed Pytorch version 2.2.1 and upgraded my CMake as well but the error still persists. Any clue why this problem might be occurring?

Hi, can you check if OneTBB has been installed correctly? Can you find installed files in external/oneTBB/install ?

Hi,
Thanks for replying. Adding the path to the library as an environment variable solved it for me.
export LD_LIBRARY_PATH=$DMESH_PATH/external/oneTBB/install/lib:$LD_LIBRARY_PATH
Thanks for your help


fix(aws-openapigateway-lambda): add id to permission resource id

Issue #, if available:
closes #1191
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 6bc94ffa6031c130ef927aa3b140b4a8cd4bf288
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Unable to get project to work

Hi I followed all the steps you recommended in the other issues to try to be able to run this project in android studio, unfortunately I have not been able to. I have a windows 10 PC, I have also tried on my macbook and my Ubuntu 20.4 machine and none seem to be able to do this

Hello!
Using Flutter SDK version 1.22.4 with the steps that I provided in the other issue should be working.
Please make sure that you are using the correct Flutter SDK and that you've also done "get dependencies".
I could also recommend that if you're using IntelliJ IDEA, then maybe clearing the cache could help.
Clear cache: Go to File (top left corner) -> Invalidate Caches -> Invalidate and Restart
Then you could also try rebuilding the project.
If you still don't have a play button available as you mentioned in the other issue thread, then maybe check the run configuration if you find some solution there.

I assume that you got it working, the repo is also updated to work with Flutter 2.x.


NimBLE init and deinit memory leak  (IDFGH-6480)

Environment

Development Kit:     Olimex ESP32-DevKit-LiPo
Kit version: rev.C
Module or chip used:  ESP32-WROOM-32E
IDF version: v4.3.1-480-g233dc30fb1
Build System:         idf.py
Compiler version: xtensa-esp32-elf-gcc (crosstool-NG esp-2021r2) 8.4.0
Operating System:     Linux
Using an IDE?: No
Power Supply:         USB

Problem Description
I'm working on a project that uses NimBLE and enters light sleep mode periodically, so it has to disable the bluetooth controller before going to sleep and reenable it after waking up.
There seems to be a memory leak in the init/deinit code from the ESP-IDF NimBLE port, as my device eventually runs out of heap memory.
The problem can be reproduced with the provided minimal example.
Expected Behavior
NimBLE bluetooth controller is initialized and deinitlialized without memory leaks.
Actual Behavior
NimBLE bluetooth controller is initialized and deinitlialized with memory leaks.
Steps to reproduce
Simply execute the provided code.
Code to reproduce this issue
#include <esp_log.h>
#include <nvs_flash.h>
#include <esp_bt.h>
#include <esp_nimble_hci.h>
#include <nimble/nimble_port.h>
#include <nimble/nimble_port_freertos.h>
#include <esp_heap_trace.h>

#define NUM_RECORDS 100
static heap_trace_record_t trace_record[NUM_RECORDS];
static const char *TAG = "nimble_leak_test";

static void ble_manager_host_task(void *param)
{
    (void)param;

    ESP_LOGI(TAG, "BLE Host Task Started");
    /* This function will return only when nimble_port_stop() is executed */
    nimble_port_run();

    nimble_port_freertos_deinit();
}

void start_ble_func()
{
    esp_err_t err = esp_nimble_hci_and_controller_init();
    if (err != ESP_OK)
    {
        ESP_LOGE(TAG, "Error at nimble controller init: %s", esp_err_to_name(err));
        return;
    }

    nimble_port_init();

    nimble_port_freertos_init(ble_manager_host_task);
}

void stop_ble_func()
{
    int rc = nimble_port_stop();
    if (rc != 0)
    {
        ESP_LOGE(TAG, "Error at nimble port stop");
        return;
    }

    nimble_port_deinit();

    esp_err_t err = esp_nimble_hci_and_controller_deinit();
    if (err != ESP_OK)
    {
        ESP_LOGE(TAG, "Error at nimble controller deinit: %s", esp_err_to_name(err));
        return;
    }
}

void app_main(void)
{
    esp_err_t ret;

    // Initialize NVS.
    ret = nvs_flash_init();
    if (ret == ESP_ERR_NVS_NO_FREE_PAGES || ret == ESP_ERR_NVS_NEW_VERSION_FOUND)
    {
        ESP_ERROR_CHECK(nvs_flash_erase());
        ret = nvs_flash_init();
    }
    ESP_ERROR_CHECK(ret);

    ESP_ERROR_CHECK(heap_trace_init_standalone(trace_record, NUM_RECORDS));

    int free_heap_size = esp_get_free_heap_size();

    for (int i = 0; i < 5; i++)
    {
        free_heap_size = esp_get_free_heap_size();
        ESP_LOGI(TAG, "free_heap_size %d ", free_heap_size);

        start_ble_func();
        free_heap_size = esp_get_free_heap_size();
        ESP_LOGI(TAG, "after start_ble_func %d ", free_heap_size);
        vTaskDelay(pdMS_TO_TICKS(500));
        stop_ble_func();
        free_heap_size = esp_get_free_heap_size();
        ESP_LOGI(TAG, "after stop_ble_func %d \n", free_heap_size);
    }

    ESP_ERROR_CHECK(heap_trace_start(HEAP_TRACE_LEAKS));

    start_ble_func();

    vTaskDelay(pdMS_TO_TICKS(1000));

    stop_ble_func();

    ESP_ERROR_CHECK(heap_trace_stop());
    heap_trace_dump();

    return;
}

Debug Logs
I (513) nimble_leak_test: free_heap_size 224892
I (513) BTDM_INIT: BT controller compile version [6a07b06]
I (513) system_api: Base MAC address is not set
I (523) system_api: read default base MAC address from EFUSE
I (533) phy_init: phy_version 4670,719f9f6,Feb 18 2021,17:07:07
I (863) nimble_leak_test: BLE Host Task Started
I (863) nimble_leak_test: after start_ble_func 205796
I (1363) NimBLE: GAP procedure initiated: stop advertising.

W (1363) Timer: Timer not stopped
I (1363) nimble_leak_test: after stop_ble_func 234952

I (1363) nimble_leak_test: free_heap_size 234952
I (1373) BTDM_INIT: BT controller compile version [6a07b06]
I (1613) nimble_leak_test: BLE Host Task Started
I (1613) nimble_leak_test: after start_ble_func 202388
I (2113) NimBLE: GAP procedure initiated: stop advertising.

W (2113) Timer: Timer not stopped
I (2113) nimble_leak_test: after stop_ble_func 234884

I (2113) nimble_leak_test: free_heap_size 234884
I (2123) BTDM_INIT: BT controller compile version [6a07b06]
I (2363) nimble_leak_test: BLE Host Task Started
I (2373) nimble_leak_test: after start_ble_func 202324
I (2873) NimBLE: GAP procedure initiated: stop advertising.

W (2873) Timer: Timer not stopped
I (2873) nimble_leak_test: after stop_ble_func 234808

I (2873) nimble_leak_test: free_heap_size 234808
I (2883) BTDM_INIT: BT controller compile version [6a07b06]
I (3133) nimble_leak_test: BLE Host Task Started
I (3133) nimble_leak_test: after start_ble_func 202260
I (3633) NimBLE: GAP procedure initiated: stop advertising.

W (3633) Timer: Timer not stopped
I (3633) nimble_leak_test: after stop_ble_func 234740

I (3633) nimble_leak_test: free_heap_size 234740
I (3643) BTDM_INIT: BT controller compile version [6a07b06]
I (3883) nimble_leak_test: BLE Host Task Started
I (3883) nimble_leak_test: after start_ble_func 202192
I (4383) NimBLE: GAP procedure initiated: stop advertising.

W (4383) Timer: Timer not stopped
I (4383) nimble_leak_test: after stop_ble_func 234676

I (4383) BTDM_INIT: BT controller compile version [6a07b06]
I (4633) nimble_leak_test: BLE Host Task Started
I (5633) NimBLE: GAP procedure initiated: stop advertising.

W (5633) Timer: Timer not stopped
4 allocations trace (100 entry buffer)
32 bytes (@ 0x3ffcb390) allocated CPU 0 ccount 0x2be69f60 caller 0x400d5640:0x400de164:0x400d6ed5:0x400d73a7:0x400d5f81:0x400d5dc4:0x400d5f02:0x4011efa8:0x40093b50:
0x400d5640: esp_timer_create at /home/javi/esp/esp-idf/components/esp_timer/src/esp_timer.c:114

0x400de164: npl_freertos_callout_init at /home/javi/esp/esp-idf/components/bt/host/nimble/nimble/porting/npl/freertos/src/npl_os_freertos.c:361

0x400d6ed5: ble_hs_stop_init at /home/javi/esp/esp-idf/components/bt/host/nimble/nimble/nimble/host/src/ble_hs_stop.c:283

0x400d73a7: ble_hs_init at /home/javi/esp/esp-idf/components/bt/host/nimble/nimble/nimble/host/src/ble_hs.c:775 (discriminator 2)

0x400d5f81: nimble_port_init at /home/javi/esp/esp-idf/components/bt/host/nimble/nimble/porting/nimble/src/nimble_port.c:53

0x400d5dc4: start_ble_func at /tmp/nimble_leak_test/main/nimble_leak_test.c:35

0x400d5f02: app_main at /tmp/nimble_leak_test/main/nimble_leak_test.c:92 (discriminator 2)

0x4011efa8: main_task at /home/javi/esp/esp-idf/components/freertos/port/port_common.c:134 (discriminator 2)

0x40093b50: vPortTaskWrapper at /home/javi/esp/esp-idf/components/freertos/port/xtensa/port.c:170

4096 bytes (@ 0x3ffc9590) allocated CPU 0 ccount 0x2be6f810 caller 0x4009220b:0x400d5f3e:0x400d5dca:0x400d5f02:0x4011efa8:0x40093b50:
0x4009220b: xTaskCreatePinnedToCore at /home/javi/esp/esp-idf/components/freertos/tasks.c:830

0x400d5f3e: nimble_port_freertos_init at /home/javi/esp/esp-idf/components/bt/host/nimble/nimble/porting/npl/freertos/src/nimble_port_freertos.c:51

0x400d5dca: start_ble_func at /tmp/nimble_leak_test/main/nimble_leak_test.c:36

0x400d5f02: app_main at /tmp/nimble_leak_test/main/nimble_leak_test.c:92 (discriminator 2)

0x4011efa8: main_task at /home/javi/esp/esp-idf/components/freertos/port/port_common.c:134 (discriminator 2)

0x40093b50: vPortTaskWrapper at /home/javi/esp/esp-idf/components/freertos/port/xtensa/port.c:170

344 bytes (@ 0x3ffcb4c8) allocated CPU 0 ccount 0x2be70618 caller 0x40092219:0x400d5f3e:0x400d5dca:0x400d5f02:0x4011efa8:0x40093b50:
0x40092219: xTaskCreatePinnedToCore at /home/javi/esp/esp-idf/components/freertos/tasks.c:835

0x400d5f3e: nimble_port_freertos_init at /home/javi/esp/esp-idf/components/bt/host/nimble/nimble/porting/npl/freertos/src/nimble_port_freertos.c:51

0x400d5dca: start_ble_func at /tmp/nimble_leak_test/main/nimble_leak_test.c:36

0x400d5f02: app_main at /tmp/nimble_leak_test/main/nimble_leak_test.c:92 (discriminator 2)

0x4011efa8: main_task at /home/javi/esp/esp-idf/components/freertos/port/port_common.c:134 (discriminator 2)

0x40093b50: vPortTaskWrapper at /home/javi/esp/esp-idf/components/freertos/port/xtensa/port.c:170

32 bytes (@ 0x3ffcb648) allocated CPU 0 ccount 0x2c2ed1b0 caller 0x400d5640:0x400de164:0x400dba5e:0x400d9c8e:0x400d70c7:0x400d7286:0x400d728e:0x400d5fb1:0x400d5d8d:0x40093b50
0x400d5640: esp_timer_create at /home/javi/esp/esp-idf/components/esp_timer/src/esp_timer.c:114

0x400de164: npl_freertos_callout_init at /home/javi/esp/esp-idf/components/bt/host/nimble/nimble/porting/npl/freertos/src/npl_os_freertos.c:361

0x400dba5e: ble_hs_flow_startup at /home/javi/esp/esp-idf/components/bt/host/nimble/nimble/nimble/host/src/ble_hs_flow.c:275

0x400d9c8e: ble_hs_startup_go at /home/javi/esp/esp-idf/components/bt/host/nimble/nimble/nimble/host/src/ble_hs_startup.c:367

0x400d70c7: ble_hs_sync at /home/javi/esp/esp-idf/components/bt/host/nimble/nimble/nimble/host/src/ble_hs.c:345

0x400d7286: ble_hs_start at /home/javi/esp/esp-idf/components/bt/host/nimble/nimble/nimble/host/src/ble_hs.c:668

0x400d728e: ble_hs_event_start_stage2 at /home/javi/esp/esp-idf/components/bt/host/nimble/nimble/nimble/host/src/ble_hs.c:569

0x400d5fb1: nimble_port_run at /home/javi/esp/esp-idf/components/bt/host/nimble/nimble/porting/nimble/src/nimble_port.c:79

0x400d5d8d: ble_manager_host_task at /tmp/nimble_leak_test/main/nimble_leak_test.c:21

0x40093b50: vPortTaskWrapper at /home/javi/esp/esp-idf/components/freertos/port/xtensa/port.c:170

4504 bytes 'leaked' in trace (4 allocations)
total allocations 38 total frees 41

Other items if possible
nimble_leak_test.zip

Hi @kadosch ,
Very recently, during fixing one of the issue https://github.com/espressif/esp-idf/issues/7653 , we have fixed memory leak during init / deinit.  Can you please confirm the commit https://github.com/espressif/esp-idf/commit/0f96ebce139ff9fc63069819e0e568adac8a6e3f exists at your end ?
Thanks,
Rahul

Hi @rahult-github,
yeah, I saw that issue before opening this one, but they are different. I'm not using power management at all, and the commit that fixes that issue is already included in the branch that I'm working with:
[javi@LEGION esp-idf]$ git branch --show-current
release/v4.3
[javi@LEGION esp-idf]$ git describe --tags
v4.3.1-480-g233dc30fb1
[javi@LEGION esp-idf]$ git branch --contains 0f96ebc
* release/v4.3

Regards.

Hi again,
recent commit 7a4ed65769bd4c4dfafdb4c85d655bab70a13c18 fixes the problem. Funnily enough, that commit was merged to branch release/v4.3 barely 20 minutes after creating this issue.
Anyway, closing the issue as resolved.


REFACTOR: listing/order errors

Addresses #905 and #915

Need to rebase :(

Coverage decreased (-0.03%) to 26.126% when pulling 4956af42bd8606b9c1ba857877a464f6d0854f7b on TS_errors into c8c8bff905197c79c71fbdf8aaf13f9151f70fac on cryptolistings.


On demand rendering with query parameters does not match route

Hi!
Using the on demand render with express we are experiencing 404 errors because the application is not being able to process query parameters of a url.
If we remove the query parameters the application is being able to render the correct page  application.renderUri(uri) , but with query parameters not.
We have removed the query parameters but we know this is an undesired behaviour that can led to unexpected renderings.

I've worked it around by encodeURIComponent'ing urls at server and decoding them back at Angular's NavigationStart event.

Have you checked the value of the URI passed into renderUri on the server side?
I had this problem with code from the Express example. I used that as a starting point for my app, and found that its absoluteUri function was messing up the query params.

Using query parameters with server-side rendering really isn't a good idea... there's nothing in angular-ssr that prevents you from using them but if you are just copy-pasting the example code, it will strip query parameters. You should not just assume that the code from the example is exactly perfect for your particular scenario. You should try to understand what it is doing. If you want to use query strings, you can do that, and when it renders the application it will take query string parameters into account, but they must be passed into renderUri.
As @lugkhast noted, you need to modify the request handler code so that it includes query strings. But I would counsel against using query strings in the first place. Better to use proper URLs like the example app does /blog/1321 (where 1321 is an ID)

@clbond  there are certain implementations like using query parameters for pagination in some lists, it is not all about good looking urls but certain business logic implementations that need to be considered. But thank you, i will take a look at the request handler and see if i can manage to change it.
Peace


support to cache to old versions' documents

Background
The current full compilation of the documentation for each project is performed each time a PR merge and scheduled deployment is performed. The older versions of these documents are barely modified, and at the same time, as the versions continue to iterate, the version numbers of the documents become more and more numerous, making the full compilation take longer and longer.
Suggestion
Add a caching mechanism for older versions of documents so that we don't have to do a full compilation every time.
Available options

[ ] GitHub Workflows cache

Did we solve this problem?

No, would you like to implement this? It will speed up building time! Please refer to Docusaurus's site, and it only builds recent versions.

No, would you like to implement this? It will speed up building time! Please refer to Docusaurus's site, and it only builds recent versions.

Ok, let me complete it.


fix(50340): typeof ... === "undefined" check on discriminated union of undefined and object type doesn't narrow correctly

Fixes #50340

@typescript-bot test this
@typescript-bot user test this
@typescript-bot perf test this

The perf improvements don't really make sense to me.
@typescript-bot perf test faster

/cc @weswigham and @ahejlsberg


Breaking component import. "... is declared but its value is never read"

Hello!
Tell me when you fix this problem, and will you? :)
I don’t know if this error was introduced .. or how to get around it, but there is no such problem with the functions.
Only when importing components. Thank you!

Found a similar problem with functions

Hmm, in this form it is not possible to use the extension (I returned to Vetur and turned off the script validation setting + installed the usual extension of EsLinter. Maybe it will help someone:

I discovered that I by adding "jsx": "preserve", in my jsconfig compilerOptions, it solved this issue.
Looks something like this:
{
  "compilerOptions": {
    "jsx": "preserve",
    // other stuff
  },
}

Fixed in https://github.com/johnsoncodehk/volar/commit/6f79f8fe77efe90ead624d6731de414cbb029331.


fb_client.fetchThreadMessages raises FBchatFacebookError: Error when sending request: Got 500 response

I'm trying to scrape a conversation of ~20k messages and I'm getting fbchat._exception.FBchatFacebookError: Error when sending request: Got 500 response with below reproduction.
Code to reproduce
fb_client.fetchThreadMessages('123456789', limit=20000)

Traceback
Traceback (most recent call last):
  File "fbm-scraper.py", line 105, in <module>
    messages = fb_client.fetchThreadMessages('1234567890', limit=20000)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/fbchat/_client.py", line 783, in fetchThreadMessages
    j = self.graphql_request(_graphql.from_doc_id("1860982147341344", params))
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/fbchat/_client.py", line 185, in graphql_request
    return self.graphql_requests(query)[0]
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/fbchat/_client.py", line 177, in graphql_requests
    return tuple(self._post("/api/graphqlbatch/", data, as_graphql=True))
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/fbchat/_client.py", line 134, in _post
    content = check_request(r)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/fbchat/_util.py", line 156, in check_request
    check_http_code(r.status_code)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/fbchat/_util.py", line 171, in check_http_code
    raise FBchatFacebookError(msg, request_status_code=code)
fbchat._exception.FBchatFacebookError: Error when sending request: Got 500 response.

Environment information

Reproduces both on py3.7 and py3.8
fbchat version: 1.9.3

Thanks for the report, though this is not really an issue on our side.
The issue is probably that Facebook allow you to request 20000 records simultaneously in the first place. Then, their servers probably has some sort of "max request time" limit, which kicks in, and kills the request (hence the 500 error).
In the future, fbchat should handle these "max limits" for you automatically, but for now, you can split the request into pieces, by doing something like this:
BATCH_SIZE = 2000
all_messages = []
before = None
while True:
    messages = fb_client.fetchThreadMessages("123456789", limit=BATCH_SIZE, before=before)
    if not messages:  # If there were no messages returned, we're done
        break
    all_messages.extend(messages)
    # We may lose some messages here if they were sent in the same millisecond
    before = int(messages[-1].timestamp) - 1

This is fixed in v2

@madsmtm Would love to use the automatic batching functionality. I looked at the Project status so far. Is there a rough estimate of when v2 might get released? Worst case, I can use bleeding edge master, but would rather not if I can help it.

Can't really give you an estimate, depends a lot of when I have the time. But I've just released an alpha version v2.0.0a1 that you can play with. It is fairly "stable", in the sense that it doesn't crash, but there will be breaking changes between alpha versions!

I appreciate it! Thanks @madsmtm


Setup react test

What it solves
Resolves #2541
How this PR fixes it
How to test it
Screenshots

@DaniSomoza please don't skip the PR description.

Looks amazing!
What will be our naming convention for the test files?
Some tests are in a tests folder, some are called ComponentName.test.tsx.
I'm personally in favor of the latter, like in this PR. 👍

Thanks! 😊
I prefer also the ComponentName.test.tsx approach, I see this in the official React docs:
One common way to structure projects is to locate CSS, JS, and tests together inside folders grouped by feature or route


Issue with package version sorting when .bcr.* versions are involved

I've noticed that for the zstd and the google test packages there are .bcr.1 packages that even though are more recent than the latest version and they presumably fix issues with the bazel central registry patching, they are not shown up as the latest versions nor appear in the correct order in the all versions list.
This has caused a problem specifically with zstd, as the .bcr.1 version contains this fix without which we could not use that dependency, and it was not at all clear from the start we needed to get that version.

Thanks for bringing this up! At the core this sounds like what has already been discussed in https://github.com/bazel-contrib/bcr-ui/issues/54 and https://github.com/bazel-contrib/bcr-ui/issues/22).
The efforts on that front have become a bit stale on my front, but I'll try to push it forward soon (it's essentially fixed on a technical level, but need to go through some organizational motions so that I don't end up as the single point of failure here).

Why does the BCR UI even re-sort the versions? Wouldn't it be enough to go with the order of the version list in metadata.json? (https://github.com/bazel-contrib/bcr-ui/issues/54#issuecomment-1416286960)


fix(@tinacms/fields): Fix "type=radio" field warning

I noticed that value changes to RadioGroup was triggering a warning within react-final-form due to how final-form handles radios:

Warning: You must pass type="radio" props to your Field component.
Without it we don't know how to unpack your value prop - "undefined".

According to https://github.com/final-form/react-final-form/issues/392, this appears to be an unusual quirk of react-final-form's API (and specific to type=radio) and a helpful suggestion (https://github.com/final-form/react-final-form/issues/392#issuecomment-543118944) is to skip the SyntheticEvent (onChange={input.onChange}) and pass value directly:
onChange={event => input.onChange(event.target.value)}
This seemingly produces the same result - minus the warning.

@all-contributors please add @Enigmatical  for code maintenance tests review