Plugin for Electron

Do we need it?
I can spend some time for that, because I'm setting up sentry for electron based app and source maps support is needed.
I think electron-plugin should only strip urls like react-native-plugin does it.

Hey @arusakov – yeah, probably. But to be honest I think we're going to start moving towards having dedicated repos/packages for raven-js environments, including React Native.
e.g. sentry-electron (we're also starting to get rid of the Raven name)

Thank you for response @benvinegar. I'm going to create PR soon.

#637

In the meantime, this is working okay for me:
module.exports.setup = function () {
    if (process.type === 'browser') {
        // main process
        const raven = require('raven');
        const client = new raven.Client('https://622ec62626b041af8d8deadbeefdeadbeef:3fd2f9b05a5f4efca80386fdeadbeefdeadbeef@sentry.io/100000');
        client.patchGlobal();

        process.on('uncaughtException', (err) => {
            const dialog = require('electron').dialog;

            dialog.showMessageBox({
                type: 'error',
                message: 'A JavaScript error occurred in the main process',
                detail: err.stack,
                buttons: ['OK'],
            })
        });
    } else if (process.type === 'renderer') {
        // renderer process
        const Raven = require('raven-js');
        const RavenVue = require('raven-js/plugins/vue');
        const Vue = require('vue');

        Raven
<EMAIL_ADDRESS>            .addPlugin(RavenVue, Vue)
            .install();
    }
}

I call it from both main and renderer processes. I added a dialog box as Electron doesn't show one after sentry gets installed.

@joerick Your solution is about "how to setup Raven in electron app". But we talk about source maps support here.

I have an electron app that need sourcemap support too.
I'm using remote hosted JS file now, but if sentry can support local JS files (source+sourcemap), it will be much better.

To setup Raven for Electron applications right now, you can use:

raven-node for main process
raven-js for renderer process
https://github.com/40thieves/webpack-sentry-plugin to setup source maps

In order to use source maps correctly, it's required now to manually update filepaths, as @arusakov already mentioned.
function normalizeUrl (url) {
  return 'app:///' + url.replace(/.*\//, '');
}

Raven.config('__DSN__', {
  dataCallback: function (data) {
    data.culprit = normalizeUrl(data.culprit)
    data.exception.values.forEach(function (value) {
      value.stacktrace.frames.forEach(function (frame) {
        frame.filename = normalizeUrl(frame.filename)
      });
    });
    return data;
  }
}).install();

I'll work on fixing this directly in raven, so we won't need any plugins for this.

There is a full Electron SDK now: https://github.com/getsentry/sentry-electron

@jan-auer do you know if the sdk support sourcemap? I can't find any documentation for the sourcemap.

@steverandy Source Maps – Sentry Documentation


Simply print the GL info log when a shader fails to compile

The previous parsing of the error log was unreliable because the logs generally don't conform to a single format.
Having more info about shader errors would still be nice, especially since the shaders get so large. Maybe next we could add an option to write failed shaders to a log file for later analysis.

Would be nice if you could #if 0 out that part for now (or have both). I'll check the different log formats on my devices and update the info parsing soon.

@hjanetzek Taking a look at your follow-up PR now.

Closing in favor of #967


What happened to ReactReduxSpa template?

I see that all has been restructured, but I can not find the ReactReduxSpa template . I see just the plain react template. And some stuff have changed. There use to be boot-client.tsx and boot-server.tsx file, and now there is only boot.tsx.
Maybe a small explanation of what are you intending, how to migrate, or any other explanation beyond the git comment?

Isn't it here?
https://github.com/aspnet/JavaScriptServices/tree/dev/templates/Microsoft.DotNet.Web.Spa.ProjectTemplates/redux

@MarkPieszak is correct - that's where it is. For now... :)
We're about to merge the regular ASP.NET templates (e.g., Empty Web Application, etc.) with the SPA templates into a new template repo that's dedicated just to templates. So the Redux (etc) templates will shortly be removed from this repo, but you'll continue to be able to submit PRs, issues, etc. Nothing is really changing except file locations!

(DOH!) Didn't see. Why not name it react-redux, since it is clearly both of them?

Just because the command to create it is dotnet new redux, and it would be a breaking change to all the docs to change that. I don't think it will be confusing to anyone, since Redux is overwhelmingly associated with React in practice even if it's not technically coupled to it.


[SQL-Migration] Enable login migrations to SQL VM

This PR adds support for migrating logins to SQL VM

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 42.019%

Totals

Change from base Build<PHONE_NUMBER>:
0.002%

Covered Lines:
28640

Relevant Lines:
63296

💛  - Coveralls

any screen shot can be shared?


Error installing npm-windows-upgrade

Debug Information:
http_parser: 2.3node: 0.12.2v8: 3.28.73uv: 1.4.2-node1zlib: 1.2.8modules: 14openssl: 1.0.1mos: win32 ia32OS Name: Microsoft Windows 7 Enterprise
OS Version: 6.1.7601 Service Pack 1 Build 7601

Contents of npm-debug.log
0 info it worked if it ends with ok
1 verbose cli [ 'C:\Program Files (x86)\nodejs\\node.exe',
1 verbose cli   'C:\Program Files (x86)\nodejs\node_modules\npm\bin\npm-cli.js',
1 verbose cli   'run',
1 verbose cli   'npm-windows-upgrade' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose node symlink C:\Program Files (x86)\nodejs\node.exe
5 verbose stack Error: ENOENT, open 'C:\package.json'
5 verbose stack     at Error (native)
6 verbose cwd C:
7 error Windows_NT 6.1.7601
8 error argv "C:\Program Files (x86)\nodejs\\node.exe" "C:\Program Files (x86)\nodejs\node_modules\npm\bin\npm-cli.js" "run" "npm-windows-upgrade"
9 error node v0.12.2
10 error npm  v2.7.4
11 error path C:\package.json
12 error code ENOENT
13 error errno -4058
14 error enoent ENOENT, open 'C:\package.json'
14 error enoent This is most likely not a problem with npm itself
14 error enoent and is related to npm not being able to find a file.
15 verbose exit [ -4058, true ]

Thanks for reporting! Can you tell me which commands you ran?

Set-ExecutionPolicy Unrestricted -Scope CurrentUser -Force
npm install --global --production npm-windows-upgrade
npm-windows-upgrade

I ran it in c:\ and in c:\windows\system32.  Trying again clean in c:\users<myusername>

the install appears to succeed.
C:\Users\scottob>npm install --global --production npm-windows-upgrade
C:\Users\scottob\AppData\Roaming\npm\npm-windows-upgrade -> C:\Users\scottob\AppData\Roaming\npm\node_modules\npm-window
s-upgrade\bin\npm-windows-upgrade.js
<EMAIL_ADDRESS>C:\Users\scottob\AppData\Roaming\npm\node_modules\npm-windows-upgrade
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>pinkie-promis
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>└──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

running npm-windows-upgrade command fails
C:\Users\scottob>npm-windows-upgrade
npm-windows-upgrade v3.0.3
Upgrading npm... |Checked system for npm installation:
According to PowerShell: C:\Program Files (x86)\nodejs
According to npm:        C:\Users\scottob\AppData\Roaming\npm
Decided that npm is installed in C:\Program Files (x86)\nodejs
Upgrading npm... /? Which version do you want to install? (Use arrow keys)

3.10.3
3.10.2
3.10.1
3.10.0
3.9.6
3.9.5
3.9.4
Upgrading npm... \

Upgrading npm (fallback method)... \
We encountered an error during installation.
Please consider reporting your trouble to http://aka.ms/npm-issues.
Debug Information:
http_parser: 2.3node: 0.12.2v8: 3.28.73uv: 1.4.2-node1zlib: 1.2.8modules: 14openssl: 1.0.1mos: win32 ia32OS Name: Microsoft Windows 7 Enterprise
OS Version: 6.1.7601 Service Pack 1 Build 7601

ok thanks

I was getting the same problem. In fact, aside from running Windows 10 Home, my output was looking almost identical as the OP's.  Forgive my newbie-ness, but while I cannot find the log now to double check what I saw, I had opened it before my successful install, and noticed that it had npm@'undefined', where I would have expected the version.  (Again, I'm totally green here.)
The output showed version 3.10.4 as the version, so I tried installing using version 3.10.3.  It worked!
I attempted to upgrade to the highest version again (3.10.4), and it still failed.
I'm not sure if this info is helpful to you, but below is my Windows PowerShell interactions, just in case.
Windows PowerShell
Copyright (C) 2015 Microsoft Corporation. All rights reserved.
PS C:\WINDOWS\system32> Set-ExecutionPolicy Unrestricted -Scope CurrentUser -Force
PS C:\WINDOWS\system32> npm install --global --production npm-windows-upgrade
C:\Users\Richard\AppData\Roaming\npm\npm-windows-upgrade -> C:\Users\Richard\AppData\Roaming\npm\node_modules\npm-window
s-upgrade\bin\npm-windows-upgrade.js
<EMAIL_ADDRESS>C:\Users\Richard\AppData\Roaming\npm\node_modules\npm-windows-upgrade
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>pinkie-prom
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>└──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>PS C:\WINDOWS\system32> npm-windows-upgrade
npm-windows-upgrade v3.0.3
Upgrading npm... /Checked system for npm installation:
According to PowerShell: C:\Program Files\nodejs
According to npm:        C:\Users\Richard\AppData\Roaming\npm
Decided that npm is installed in C:\Program Files\nodejs
Upgrading npm... /? Which version do you want to install? (Use arrow keys)

3.10.4
3.10.3
3.10.2
3.10.1
3.10.0
3.9.6
3.9.5
Upgrading npm... /

Upgrading npm (fallback method)... |
We encountered an error during installation.
Please consider reporting your trouble to http://aka.ms/npm-issues.
Debug Information:
http_parser: 2.5.2node: 4.4.1v8: <IP_ADDRESS>uv: 1.8.0zlib: 1.2.8ares: 1.10.1-DEVicu: 56.1modules: 46openssl: 1.0.2gos: wi
n32 x64OS Name: Microsoft Windows 10 Home
OS Version: 10.0.10586 N/A Build 10586
PS C:\WINDOWS\system32> npm-windows-upgrade -v
error: option `-v, --npm-version ' argument missing
PS C:\WINDOWS\system32> npm-windows-upgrade -V
3.0.3
PS C:\WINDOWS\system32> npm-windows-upgrade -v 3.10.3
npm-windows-upgrade v3.0.3
Upgrading npm... -Checked system for npm installation:
According to PowerShell: C:\Program Files\nodejs
According to npm:        C:\Users\Richard\AppData\Roaming\npm
Decided that npm is installed in C:\Program Files\nodejs
Upgrading npm... -
Upgrade finished. Your new npm version is 3.10.3. Have a nice day!
PS C:\WINDOWS\system32> npm-windows-upgrade
npm-windows-upgrade v3.0.3
Upgrading npm... /Checked system for npm installation:
According to PowerShell: C:\Program Files\nodejs
According to npm:        C:\Users\Richard\AppData\Roaming\npm
Decided that npm is installed in C:\Program Files\nodejs
Upgrading npm... ? Which version do you want to install? (Use arrow keys)

3.10.4
3.10.3
3.10.2
3.10.1
3.10.0
3.9.6
3.9.5
Upgrading npm... |

Upgrading npm (fallback method)... -
We encountered an error during installation.
Please consider reporting your trouble to http://aka.ms/npm-issues.
Debug Information:
http_parser: 2.5.2node: 4.4.1v8: <IP_ADDRESS>uv: 1.8.0zlib: 1.2.8ares: 1.10.1-DEVicu: 56.1modules: 46openssl: 1.0.2gos: wi
n32 x64OS Name: Microsoft Windows 10 Home
OS Version: 10.0.10586 N/A Build 10586
PS C:\WINDOWS\system32>

Having the exact same issue here. Win 10 Professional.

For those that have problems, make sure you read and do this: https://github.com/felixrieseberg/npm-windows-upgrade#fix-an-attempted-upgrade

I ran all of the steps to fix an attempted upgrade.
Reinstalled Node (v4.4.7).
Ran:
Set-ExecutionPolicy Unrestricted -Scope CurrentUser -Force
npm install --global --production npm-windows-upgrade
npm-windows-upgrade

It eventually goes to the fallback method, which then fails.
I have uploaded a video displaying this: https://www.youtube.com/watch?v=jQw_lU82qYI

The first time I tried running the update package, I got some error with the npm-cli.js file. I think I ignored the error and it didn't popup the second time I ran the package.
However, with another computer, I got this message:

Debug information:
http_parser: 2.7.0node: 6.2.1v8: <IP_ADDRESS>uv: 1.9.1zlib: 1.2.8ares: 1.10.1-DEVicu: 57.1modules: 48openssl: 1.0.2hos: win32 x64OS Name: Microsoft Windows 10 Pro
OS Version: 10.0.14393 N/A Build 14393


fix: Add support for xls,json,tsv file types in file widget

Fixes #17946
This PR adds support for parsing XLS,XLSX, TSV, JSON and CSV files in file widget v2.
Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

Testing

How Has This Been Tested?

[x] Manual
[x] Cypress

Test Plan

Import following file types to test if the feature works fine.

Import xls, xlsx, json, tsv, csv file.
Import a large file > 1 MB, > 5 MB to test the feature.
Import file types of text,binary and base64 to test existing functionality since the whole importing code has been refactored.

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

/ok-to-test sha=2fdb155

/build-deploy-preview env=release

/ok-to-test sha=0587e0a

/ok-to-test sha=9a053be

/build-deploy-preview env=release

@somangshu @dilippitchika does this feature need to go part of What's new updates ?

@rajatagrawal yes please

/ok-to-test sha=79deda2

/build-deploy-preview env=release

@sbalaji1192 I have fixed the review feedback. You can review the changes. Thanks!

/ok-to-test sha=80f6f7c

/build-deploy-preview env=release

Observations @rajatagrawal :

Filepicker doesn't show it's file count on uploading csv,tsv & json files
https://www.loom.com/share/30cff6b76b77491ab02524f28a96b0ee

Because of above issue, i can't see csv files are getting uploaded either (same works fine on prod)
https://www.loom.com/share/7d1d0360494b4e29b470d04da7cec335

Rename file type typo to XLS(X) as discussed

/ok-to-test sha=1868567

Tested this PR and LGTM

Verified all callouts
Tested existing Supported filetypes
Tested newly added supported filetypes

/ok-to-test sha=1868567

@somangshu It's been marked as flaky and has been temporarily skipped. @vsvamsi1 has already opened a PR and running tests.
@rajatagrawal Can you rebase with latest release and run the tests again?

/ok-to-test sha=92a44c5


Format extensions source

Another round of review on the formatting config and output. Applied to CppUTestExt this time.
Follow up to #1625.

Coverage decreased (-0.01%) to 98.674% when pulling 67c26888d23fe97985f9b18877fc3203c6842d46 on thetic:format into 9866ab8d7eddf1d611ea0e8062daf5712e881e58 on cpputest:master.

Can these stay on one line?

The column limit is currently set to 120 characters. We can increase or remove the limit. What would you prefer?

My first thought is... remove.
But if we remove it, then it will change manual line break to one-lines? So, perhaps increase it to a significant amount.

I thought 120 was a significant amount, lol. I'll see how it handles manual breaks when the limit is removed.

A column limit of 0 means that there is no column limit. In this case, clang-format will respect the input’s line breaking decisions within statements unless they contradict other rules.

Thinking it over a bit. I do like that the limit actually puts some lines on one line that were previously too short.
Testing the columns a bit on my (way too large) monitor, I suggest setting the limit to 180.

I suggest setting the limit to 180.

done

I'm not willing to spend any more time on this. I thought autoformatting would help normalize style and improve the readability of the all the long, dense lines, but I don't think that's how this is panning out.

Ok, then I'll pick it up from here as I do think it is worth it.

I think what you're looking for is
AllowShortFunctionsOnASingleLine: Inline
ColumnLimit: 0

Any progress on finding a config you're happy with? If we're not going to pursue formatting, we should probably remove the config and CI step.


Use double quotes for author name fields

This is meant to handle errors caused when the author name
contains punctuation i.e apostrophes
This is causing some errors in that the apostrophes are closing some single quotes fields early
This addresses #177

@kevgathuku thanks XD

You're welcome :+1:


Fix selectable attributes

When one of the attributes doesn't exist, the javascript breaks.

thanks a lot :+1:


A million container within an Argo workflow

FEATURE REQUEST:
What would be the best way to run an Argo workflow that would involve a million containers?
It seems that there would not be enough space in the Argo status spec to hold the information about all the PODs.
What would be the best way to accomplish this?
I am thinking that we could have a top level Argo workflow that launches multiple Argo workflows that run independently of the first one. What do you think?

I think having Template CRD and including it in Workflow is good. We can also bind variables like many template engines can do. Also it’s possible to nest templates.
e.g. in Workflow
templates:
- name: foo
  include: template_name_1
  vars:
    x: 1
- name: bar
  include: template_name_2

@dtaniwaki So all of theses workflow will use the same Workflow CRD?   Will they be split into multi small workflow?
Maybe this a great feature to hold very large workflow.

  - name: foobar
    steps:
    - - include tmpl2.foo
    - - include tmpl2.bar

Maybe it's better to have template references (referencing external files) like this:
  - name: foobar
    steps:
    - - templateRef:
          url: https://.../bar.template.yaml
    - - templateRef:
          file: ./bar.template.yaml

This does not solve the problem of CR size. The Workflow K8s object includes status of all tasks. In Kubernetes the maximum size of an object is 512KiB, so the status part won't fit.

The v2.4 release will have persistence of workflows to a centrally configured persistence store. Theres a experimental mode where the controller will choose to store workflow status.nodes in the persistence layer (instead of the k8s object).
This will enable large workflow support, but there is still the issue of CLI and UI being able to handle this, which is why we will be targeting this for v2.5

FYI, v2.3 added support for workflow status.nodes compression. It's been reported from some users that they are getting about double the size of workflow with the compression feature.

Thanks for the update.

This is great. Thanks!

@jessesuen Is that double size issue being tracked anywhere? What's the status of large workflow support, including CLI and UI?

Quite a few workflows I've specified have hit this issue, so I'm following with interest and happy to help with testing.  And once it's implemented it'll make this Argo Workflow claim sound much less hollow :)

Argo Workflows puts a cloud-scale supercomputer at your fingertips!

Large workflow support added in v2.3.  This feature will compress the node status and store it in ETCD.
https://github.com/argoproj/argo/pull/1264

Some feedback here, after trying to setup a workflow with around 3000 nodes/steps.
We found out argo ended crashing our K8s API as it was posting/updating the whole workflow structure into our etcd database every time that a node updates its status. As we have tons of nodes, some output and some dags, the workflow object kept on increasing and had to be updated as a whole, adding a lot of pressure to the K8s API.
At any moment we only had around 10-20 containers running as they are short lived and this parallelisation is enough for us to finish the 3000 nodes in 1 hour. However, all the ended containers had all their metadata and output stored in this workflow, and ended in OOM.
Our workaround was to make a main workflow that in some nodes it generated a new workflow. Thus, this "subworkflow" only updated its data and we distributed the large workflow K8s resource between smaller ones. Now the memory use was much lower and would run over the same masters that before was failing. To get a reference, a single master of 8GB was crashing with OOM and after the changes, the maximum memory usage is 3GB, which is quite a change.
As a suggestion, I'd say that instead of having a huge Workflow CRD storing all the data, it would make sense to have another workflowNode CRD that stores the data for each node. The Workflow CRD can be used as an origin of the submitted workflow, and the WorkflowNode CRD could point to its parent Workflow CRD
This would make everything much more lightweight, and I'm pretty sure this would work with large Argo workflows.

@Sturgelose I think the workflow persistence feature coming in v2.4 will help here, but it requires standing up a SQL DB to offload the workflow metadata.
Also, this feature won't be fully usable until v2.5, which is when we implement the new API server that can leverage the persistence layer.

@jessesuen I'm aware :) I'm just sharing a bit our use case, problems we found and how we tackled the issue until this gets implemented in the future.
Of course I'm not expecting this in the next release! Anyways, if you need people to implement this feature, I'd be glad to help with this!


Makefile: change default prefix to /usr/local

/usr/local was supposed to contain programs that are not packaged through the distribution, and on usual setups, /usr/local/bin is already in the PATH.

This was fixed in c821a46


Task creation loading TensorFlow.js json model file results in null object

When loading the TensorFlor.js model in json format for task creation, the object appears to be null.
@giordano-lucas has also tried to debug this: "The error is in the   tag  within vee-validate"

No this was not fixed afaik, @s314cy ?

can you link the PR in which it was completed?


How can I avoid separating white spaces.

I wanna mark some words that user has defined as 'entity'. There are some words that include whitespace such as "fried rice", "tour hotel", etc. but, Mark.js marks and separates these words like "fried", "rice", "tour", "hotel". How can I adjust option to avoid the above situation?

Just disable the separateWordSearch option?


Console for Testing

Another improvement to consider to add into the plugin.
A console to allow testing without real user information. Facebook, for example, doesn't allow testing with a domain different from the application.
So if you have a vagrant box with the domain vvv.teste and on the application www.yourwesbite.com, it'll not accept it.

Facebook supports Test Apps, (see here)[https://developers.facebook.com/docs/apps/test-apps]. I'm using them for development and local server, works fine with local domains like mylocalsite.dev (or whatever name and extension you use).

That's good, I was not aware of that. Quick suggestion, put this information on the documentation. Other developers using the plugin at first might not be aware of that.

Sounds good to me. Will add this along with new PR I'm going to submit in a day or two, If @miled won't add it faster.

=1 (y)


Fix node 0.12 version in travis.yml

YAML numbers don't work with travis' NVM thing.

Thanks but it's already working https://travis-ci.org/harthur/color-convert


adding Windows config file sample

- What I did
Documentation update to add Windows example of daemon.json. This change fixes #22709.
- How I did it
Updated document. Added H3 for Linux and Windows so that each section is present in right hand navigation.
- How to verify it
Verify document rendering.
- Description for the changelog
Added documentation that includes an example daemon.json file for Windows.
Signed-off-by: Neil Peterson<EMAIL_ADDRESS>

Thanks @neilpeterson, I some suggestions, but otherwise I think this is good to go

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "daemon-config-windows" git@github.com:neilpeterson/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

@thaJeztah, thanks, suggestions have been incorporated.

Thanks @neilpeterson can you;

fix the typos that @StefanScherer spotted
wrap the new content to 80-chars
squash your commits (I think this change doesn't need multiple commits, just a single one should be ok)

oops, browser cache, you already wrapped :blush:

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "daemon-config-windows" git@github.com:neilpeterson/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~7
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

I've made a mess on the PR / Squash. Can't spend any more time on it. Will close and re-open.


Add a service worker

Since the generated docs are based on a Jekyll build process, I'd be interested in adapting what's being done in https://github.com/jeffposnick/jeffposnick.github.io

:+1:


we can remove the homepage configuration from the configuration.

Terms

[X] Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected
master
Issue Description
No more homepage configuration in the configuration. because these features are managed now from the theme customization new/features product carousel.
Preconditions

Admin should be logged in.

Steps to reproduce

Go to 'Admin panel'
Click on 'Edit products' inside the configurations\catalog
See the error

Expected Result
Now it working from the theme. we can remove the feature from here.
Actual Result
No need for this feature in the configuration. Here
Screenshots
No response
Additional context
No response

@amit-webkul Remove the functionality name from the page description. Here

Now, this issue is fixed. so I am closing this issue.
And I have attached a screenshot Here, for future reference.


Missing UI for Temperature Level Control in Matter Refrigerator and Freezer (Profile: TL)

What is Wrong:

For profile (TL), both refrigerator and freezer are configured with TemperatureLevelControl.
However, no control UI is displayed for adjusting the temperature level for refrigerator (But works well for the freezer) in the SmartThings app.
This affects the user experience as the temperature levels cannot be selected or modified through the app interface.

Steps to Reproduce:

Commission a refrigerator or freezer device with profile (TL) on the SmartThings app.
Open the device controls for TemperatureLevelControl.
Observe that no UI is available for selecting or modifying temperature levels.

Expected Behavior:

The UI should provide a slider or selection control for TemperatureLevelControl to allow users to adjust temperature levels within the supported range.

Additional Information:

Device Details:

Controller: ESP32-S3
Matter Version: 1.4
IDF Version: 5.2.3

Logs:
Attached below are logs from the ESP-Matter setup and exported JSON attributes from the SmartThings app showing the missing UI issue.

Relevant Logs:
For setting the temp level for the freezer
I (549763) esp_matter_command: Received command 0x00000000 for endpoint 0x0003's cluster 0x00000056
I (549773) esp_matter_attribute: ********** R : Endpoint 0x0003's Cluster 0x00000056's Attribute 0x0000FFFC is 2 **********
AppSupportedTemperatureLevelsDelegate::Size endpoint 3
AppSupportedTemperatureLevelsDelegate::Size Size of endpoint 3 is 11
I (549773) esp_matter_attribute: ********** R : Endpoint 0x0003's Cluster 0x00000056's Attribute 0x00000004 is 6 **********

Exported JSON Attributes:
From my.smartthings
[
    {
        "component": "freezer",
        "capability": "mode",
        "attribute": "mode",
        "value": "Normal",
        "timestamp": "2024-12-11T20:19:36.059Z"
    },
    {
        "component": "freezer",
        "capability": "mode",
        "attribute": "supportedArguments",
        "value": [
            "Normal",
            "Rapid Freeze"
        ],
        "timestamp": "2024-12-11T20:19:35.780Z"
    },
    {
        "component": "freezer",
        "capability": "mode",
        "attribute": "supportedModes",
        "value": [
            "Normal",
            "Rapid Freeze"
        ],
        "timestamp": "2024-12-11T20:19:35.586Z"
    },
    {
        "component": "freezer",
        "capability": "temperatureLevel",
        "attribute": "supportedTemperatureLevels",
        "value": [
            "-14.0°C",
            "-15.0°C",
            "-16.0°C",
            "-17.0°C",
            "-18.0°C",
            "-19.0°C",
            "-20.0°C",
            "-21.0°C",
            "-22.0°C",
            "-23.0°C",
            "-24.0°C"
        ],
        "timestamp": "2024-12-11T20:19:34.176Z"
    },
    {
        "component": "freezer",
        "capability": "temperatureLevel",
        "attribute": "temperatureLevel",
        "value": "-20.0°C",
        "timestamp": "2024-12-11T20:27:44.825Z"
    },
    {
        "component": "freezer",
        "capability": "temperatureMeasurement",
        "attribute": "temperature",
        "value": 5,
        "timestamp": "2024-12-11T20:19:33.529Z"
    },
    {
        "component": "freezer",
        "capability": "temperatureMeasurement",
        "attribute": "temperatureRange",
        "value": null
    },
    {
        "component": "main",
        "capability": "contactSensor",
        "attribute": "contact",
        "value": "closed",
        "timestamp": "2024-12-11T20:19:33.834Z"
    },
    {
        "component": "main",
        "capability": "firmwareUpdate",
        "attribute": "availableVersion",
        "value": "v1.0 (1)",
        "timestamp": "2024-12-11T20:19:30.167Z"
    },
    {
        "component": "main",
        "capability": "firmwareUpdate",
        "attribute": "currentVersion",
        "value": "v1.0 (1)",
        "timestamp": "2024-12-11T20:19:30.203Z"
    },
    {
        "component": "main",
        "capability": "firmwareUpdate",
        "attribute": "lastUpdateStatus",
        "value": null
    },
    {
        "component": "main",
        "capability": "firmwareUpdate",
        "attribute": "lastUpdateStatusReason",
        "value": null
    },
    {
        "component": "main",
        "capability": "firmwareUpdate",
        "attribute": "lastUpdateTime",
        "value": null
    },
    {
        "component": "main",
        "capability": "firmwareUpdate",
        "attribute": "state",
        "value": "normalOperation",
        "timestamp": "2024-12-11T20:19:30.172Z"
    },
    {
        "component": "main",
        "capability": "firmwareUpdate",
        "attribute": "supportedCommands",
        "value": null
    },
    {
        "component": "main",
        "capability": "firmwareUpdate",
        "attribute": "updateAvailable",
        "value": false,
        "timestamp": "2024-12-11T20:19:30.167Z"
    },
    {
        "component": "main",
        "capability": "mode",
        "attribute": "mode",
        "value": "Normal",
        "timestamp": "2024-12-11T20:19:35.416Z"
    },
    {
        "component": "main",
        "capability": "mode",
        "attribute": "supportedArguments",
        "value": [
            "Normal",
            "Holiday"
        ],
        "timestamp": "2024-12-11T20:19:35.074Z"
    },
    {
        "component": "main",
        "capability": "mode",
        "attribute": "supportedModes",
        "value": [
            "Normal",
            "Holiday"
        ],
        "timestamp": "2024-12-11T20:19:35.020Z"
    },
    {
        "component": "refrigerator",
        "capability": "mode",
        "attribute": "mode",
        "value": "Normal",
        "timestamp": "2024-12-11T20:19:34.583Z"
    },
    {
        "component": "refrigerator",
        "capability": "mode",
        "attribute": "supportedArguments",
        "value": [
            "Normal",
            "Rapid Cool"
        ],
        "timestamp": "2024-12-11T20:19:34.580Z"
    },
    {
        "component": "refrigerator",
        "capability": "mode",
        "attribute": "supportedModes",
        "value": [
            "Normal",
            "Rapid Cool"
        ],
        "timestamp": "2024-12-11T20:19:34.581Z"
    },
    {
        "component": "refrigerator",
        "capability": "temperatureLevel",
        "attribute": "supportedTemperatureLevels",
        "value": null
    },
    {
        "component": "refrigerator",
        "capability": "temperatureLevel",
        "attribute": "temperatureLevel",
        "value": null
    },
    {
        "component": "refrigerator",
        "capability": "temperatureMeasurement",
        "attribute": "temperature",
        "value": 5,
        "timestamp": "2024-12-11T20:19:33.355Z"
    },
    {
        "component": "refrigerator",
        "capability": "temperatureMeasurement",
        "attribute": "temperatureRange",
        "value": null
    }
]

Attachments:

Screenshots showing the missing UI for TemperatureLevelControl.

Please let us know how to resolve this issue or if additional information is required. Thank you!

@Mbadra96
Thank you for checking the problem and contacting us. This is a problem caused by mismatching the settings between the profile and the device-configuration. I will solve it as soon as possible.

@HunsupJung Ok thank you


[5.8] Bump symfony to 4.2

in https://github.com/laravel/framework/pull/26685 not all components were bumped to the 4.2

This also needs doing in all the other composer.json files please.

@GrahamCampbell , looks like that all other components already bumped

Ah, yes. Great. :)


INCLUDE env_entry is not allowed to be empty

From an unknown timepoint, the windows CI starts to fail with
ERROR: C:/users/runneradmin/_bazel_runneradmin/gmezm5mc/external/local_cuda/toolchain/BUILD:20:[22](https://github.com/bazel-contrib/rules_cuda/actions/runs/5158430370/jobs/9292103159#step:6:23): in cuda_toolchain_config rule @local_cuda//toolchain:nvcc-local-config:
Traceback (most recent call last):
	File "D:/a/rules_cuda/rules_cuda/cuda/private/toolchain_configs/nvcc_msvc.bzl", line 56, column [30](https://github.com/bazel-contrib/rules_cuda/actions/runs/5158430370/jobs/9292103159#step:6:31), in _impl
		env_entry("INCLUDE", ";".join(cc_toolchain.built_in_include_directories)),
	File "C:/users/runneradmin/_bazel_runneradmin/gmezm5mc/external/bazel_tools/tools/cpp/cc_toolchain_config_lib.bzl", line 65, column 30, in env_entry
		_check_is_nonempty_string(value, "value", "env_entry")
	File "C:/users/runneradmin/_bazel_runneradmin/gmezm5mc/external/bazel_tools/tools/cpp/cc_toolchain_config_lib.bzl", line 37, column 13, in _check_is_nonempty_string
		fail("{} parameter of {} must be a nonempty string."
Error in fail: value parameter of env_entry must be a nonempty string.
ERROR: C:/users/runneradmin/_bazel_runneradmin/gmezm5mc/external/local_cuda/toolchain/BUILD:20:22: Analysis of target '@local_cuda//toolchain:nvcc-local-config' failed
ERROR: Analysis of target '//tests/flag:cuda_library_c_fastbuild_static_msvcrt_flag_test' failed; build aborted:

It seems that the CI environment is changed in upstream and is undocumented. An workaround is desired.

Was the change between windows-latest and windows-2019 determined? I am experiencing this issue on my local Windows workstation and looking for a fix.

@psv4 This is not a cuda rules problem, and not even bazel cc_rules problem. visual c installation folder structure changed at some point of a release, some old versions of bazel cannot detect the installation for the new folder structure. We need to test this rule back up to oldest LTS release of bazel, so we held back the image version for this reason.
If you need to use old version bazel, then use vs 2019 or better update your bazel to 6.4 (if not 7

@cloudhan, thanks for the response. Tested that 6.4 still had the issue, but 6.5 and 7.0 were able to find VS 2022 correctly.


azure: Properly return errors when setting up the Azure provider

We weren't properly returning an error when attempting to load the Azure
credentials. This caused cluster to think that the Azure provider was usable,
when it really wasn't.

sigh . . . this is why we need unit tests  . . .


Drag problem after changing parentNode

Describe the Bug
Hey everyone,
I'm trying to create an UML graph design flow for processes and I'm having problem with changing nodes from one subflow to another by being dragged. Basically there can be multiple swim lanes that are a type of static nodes that don't move. Inside the swim lanes there may be several nodes with the attribute extent: parent that never changes, but the parentNode attribute changes when a node is being dragged and enters a new swim lane. There is a useRef variable to check if a node is being dragged being set on the events onNodeDragStart and onNodeDragStop, and then on onNodeMouseEnter it just checks if a node is being dragged and the parentNode is different to the current entered swim lane.
The problems are:

The flow changes accurately the nodes parentNode succesfully and the extent bounds constraint works well but the drag function stops working and the node sticks to the bottom
The swim lanes can have variable height and when one has an expanded height the extent bounds constraint stops working and the node floats outside the parent node when the attribute parentNode changes. Once the node is dragged again it appears inside the bounds correctly.

Something that may be relevant is that the mouse cursor changes when I move outside the swim lane even though I haven't stopped clicking the mouse the hand looks like it releases and when it reenters the swim lane it seems like it is holding again, I'm still trying to understand the library code but I figure this may be relevant, any guidance is extremely appreciated.
Here's some code:
For detecting if it is being dragged
`
const handleNodeDragStart = useCallback((event, node) => {
if (node.type === 'subnode') {
isDraggingNode.current = true;
draggedNodeRef.current = node;
}
console.log('isDraggingNode TRUE', isDraggingNode.current);
});
const handleNodeDragStop = useCallback((event, node) => {
if (node.type === 'subnode') {
isDraggingNode.current = false;
}
});
`
For changing the attributes:
`
const handleNodeMouseEnter = useCallback((event, node) => {
if (node.type !== 'subnode') {
if (isDraggingNode.current && draggedNodeRef.current) {
if (!node || draggedNodeRef.current.data.parentId === node.id) {
return;
}
    setNodes((nds) => {
      let draggedNode = { ...draggedNodeRef.current };
      const parentLane = node;

      if (!parentLane || draggedNode.data.parentId === parentLane.id) return nds;

      draggedNode.data.parentId = parentLane.id;
      draggedNode.parentNode = parentLane.id;

      draggedNodeRef.current = draggedNode;

      return nds.map((n) => (n.id === draggedNode.id ? draggedNode : n));
    });
  }
}

}, [setNodes]);
`
And the code that updates the height that somehow affects the node dragging
`
const updateNodeHeight = (id, newHeight) => {
setNodes((nds) => {
let updatedNodes = nds.map((node) => {
if (node.id === id) {
return {
...node,
data: { ...node.data, height: newHeight },
};
}
return node;
});
  const index = updatedNodes.findIndex((node) => node.id === id);
  for (let i = index + 1; i < updatedNodes.length; i++) {
    if (updatedNodes[i].type.localeCompare('swimlane')===0) {
      updatedNodes[i] = {
        ...updatedNodes[i],
        position: {
          ...updatedNodes[i].position,
          y: updatedNodes[i - 1].position.y + updatedNodes[i - 1].data.height,
        },
      };
    }
  }

  return updatedNodes;
});

};
`
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue

Create swim lane nodes that are static, not draggable and stacked one over another without overlap. Create css to keep on lowest z-Index and update height function.
Create nodes with parent node and extent parent attributes
Create Flag to detect node is being dragged on start and stop
On onNodeMouseEnter detect if the node has entered another swim lane
Change attribute parentNode if thats the case
Drag node over different swim lanes

Expected behavior
As a user I expect to be able to change the parent node attribute and for the behavior of extent parent to behave or be dragged in the same manner as the original swim lane it belonged to, but I'm seeing the drag node functionality broken on every swim lane that isn't the one that the node belonged to when it started being dragged.
Screenshots or Videos
https://github.com/xyflow/xyflow/assets/11154263/9bc27c84-a286-48de-971b-f3c7c7e0a108
Platform

OS: macOS
Browser: Firefox
Version: 126.0.1

Additional context
Any help or hint is extremely appreciated

Minus one small weird visual glitch, this works on v12


Add support for translations

Is your feature request related to a problem? Please describe.
Currently part of the theme is on english and part on your playnite selected language, this could be solved adding the option to translate using Crowdin.
Describe the solution you'd like
Have the option to have the theme on my Playnite selected language (Spanish)
Describe alternatives you've considered
None.
Additional context

As you can see some strings are translated and some are on English. I would like to have all in Spanish.

I did not find any way to reference the localization file in a theme so im currently working on a extension that will be used to reference the localization file in eMixedNiteMC. Extension is called "eMixedNiteMC Language Pack" and it should be ready for release in the next few days. I will put the Crowdin link in the ReadMe.md and in Playnite forum as soon as everything is set up.

I did not find any way to reference the localization file in a theme so im currently working on a extension that will be used to reference the localization file in eMixedNiteMC. Extension is called "eMixedNiteMC Language Pack" and it should be ready for release in the next few days. I will put the Crowdin link in the ReadMe.md and in Playnite forum as soon as everything is set up.

Perfect, thanks! I will start translating into spanish when it's available.

https://github.com/MCC321-QC/eMixedNiteMC-Language-Pack
https://crowdin.com/project/emixednitemc

https://github.com/MCC321-QC/eMixedNiteMC-Language-Pack https://crowdin.com/project/emixednitemc

Perfect, I will check it and start the translation into spanish, thanks!


Release Candidate Comments (Family Friendliness)

This issue was created to collect comments about the upcoming metrics release.
This thread is for comments about Family Friendliness
GitHub location: https://github.com/chaoss/wg-diversity-inclusion/blob/master/focus-areas/events/family-friendly.md
See all release candidates of metrics are at:
https://chaoss.community/metrics-202001/

"Resources" should be "References"


Issue 13: Card component unit test added

For accessibility, aria-label and role have been included for the card images. While writing unit testing, I thought it would make more sense to have it for images.
At the moment, events has no functionality. So, I didn't write the unit testing for the event. I think we should create an issue regarding this.

Nice, @bearcub3!
I'm resolving the conflict here to accept the PR. Meanwhile, do you want to create this issue for the unit tests of events? I think it is a good idea, Although the Poppins manifesto states that we should create only issues that were requested to prevent "issue polution", I think the project is very clean and this issue would be very welcome. Just remember to follow the Poppins guidelines and bring it on.!

Hey @tiagostutz!
I don't understand so much how I will resolve this conflicts in a repo from other person. Can you help me on this? Will I need some permissions for commit in that repo?

Hi @finhaa !
In the contribution guidelines you can find a quick cheat on how to checkout the forked repo and update it with the original master contents.
About the permission stuff, clone the @bearcub3 https://github.com/bearcub3/stop-analyzing-embed.git repo, check issue-13 branch out, do the merge process to update the codebase (as described above) to bring the "conflict" to be resolved. Resolve the conflict and push the code to the issue-13 branch. Take a look at the commit history here in the PR and check that I've done some commits in @bearcub3 branch repo.!

Right @tiagostutz !
I'm going to work on this today or at the lastest on this weekend. And thank your for the help!

File size impact

Error: Error while trying to generate a snapshot for master.
TypeError [ERR_INVALID_FILE_URL_HOST]: File URL host must be "localhost" or empty on darwin
    at getPathFromURLPosix (internal/url.js:1330:11)
    at Object.fileURLToPath (internal/url.js:1353:50)
    at urlToFileSystemPath (/Users/tiagostutz/workspace/tiagostutz/stop-analyzing-embed/.github/workflows/file-size-impact/node_modules/@jsenv/file-size-impact/dist/commonjs/main.cjs:930:32)
    at execCommandInProjectDirectory (/Users/tiagostutz/workspace/tiagostutz/stop-analyzing-embed/.github/workflows/file-size-impact/node_modules/@jsenv/file-size-impact/dist/commonjs/main.cjs:3884:14)
    at wrapExternalFunction.catchCancellation (/Users/tiagostutz/workspace/tiagostutz/stop-analyzing-embed/.github/workflows/file-size-impact/node_modules/@jsenv/file-size-impact/dist/commonjs/main.cjs:3891:13)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async fn (/Users/tiagostutz/workspace/tiagostutz/stop-analyzing-embed/.github/workflows/file-size-impact/node_modules/@jsenv/file-size-impact/dist/commonjs/main.cjs:1182:23)
    at async fn (/Users/tiagostutz/workspace/tiagostutz/stop-analyzing-embed/.github/workflows/file-size-impact/node_modules/@jsenv/file-size-impact/dist/commonjs/main.cjs:1204:23)

  Generated by Generated by file size impact

File size impact

Error: Error while trying to generate a snapshot for master.
TypeError [ERR_INVALID_FILE_URL_HOST]: File URL host must be "localhost" or empty on darwin
    at getPathFromURLPosix (internal/url.js:1332:11)
    at Object.fileURLToPath (internal/url.js:1355:50)
    at urlToFileSystemPath (/Users/tiagostutz/workspace/tiagostutz/stop-analyzing-embed/.github/workflows/file-size-impact/node_modules/@jsenv/file-size-impact/dist/commonjs/main.cjs:930:32)
    at execCommandInProjectDirectory (/Users/tiagostutz/workspace/tiagostutz/stop-analyzing-embed/.github/workflows/file-size-impact/node_modules/@jsenv/file-size-impact/dist/commonjs/main.cjs:3884:14)
    at wrapExternalFunction.catchCancellation (/Users/tiagostutz/workspace/tiagostutz/stop-analyzing-embed/.github/workflows/file-size-impact/node_modules/@jsenv/file-size-impact/dist/commonjs/main.cjs:3891:13)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async fn (/Users/tiagostutz/workspace/tiagostutz/stop-analyzing-embed/.github/workflows/file-size-impact/node_modules/@jsenv/file-size-impact/dist/commonjs/main.cjs:1182:23)
    at async fn (/Users/tiagostutz/workspace/tiagostutz/stop-analyzing-embed/.github/workflows/file-size-impact/node_modules/@jsenv/file-size-impact/dist/commonjs/main.cjs:1204:23)

  Generated by Generated by file size impact


Create Store Modal: Height

Could the height of this modal be expanded?

Yes. I actually already have this fixed in one of my branches. Just need to do some clean up and then I'll push it up.


Return interface value from aggregate serialization methods

Problem
Currently, methods like serializeSeq return a value of a type that implements getty.ser.Seq.
I think it'd be better if those methods returned the interface value instead

As it is now, blocks have to do the whole s.seq() thing even though the blocks always use the return value of serializeSeq solely for its interface behavior. They never care about the actual implementation, so they shouldn't have access to it in the first place.
It'd be more consistent with how deserializers work, which pass in the interface values for, say, getty.de.SeqAccess to visitors.

Proposal
Serializers should pass in<EMAIL_ADDRESS>for the Seq parameter in their call to getty.Serializer (and Getty should check at comptime that it's a getty.ser.Seq). With that, I think Getty should be able to use it as the return value for serializeSeq.
This would make it to where serializers are the ones writing s.seq() instead of blocks, which is better since the serializers are the ones defining the implementations and so it's fine if they can look at the implementation's details and guts. The blocks shouldn't have access to that stuff though.
Alternatives
No response
Additional Context
No response

An important thing to keep in mind is that the getty.ser.Seq implementation (and any values in it), from which the returned interface value is created, must be able to outlive serializeSeq. Otherwise, its memory is gonna become garbage once the method returns.
Getty JSON
In Getty JSON's case, I thiiiiiiink that we're okay? The only fields the type returned by all of the aggregate methods are:
ser: *Serializer,
state: enum { empty, first, rest },

state would obviously just be copied, so that's fine. And then I think ser will always be valid in the context it'll be used in (i.e., in the serialize function of an SB) since the serialize function in SBs take the serializer as a parameter, so it should always exist as long as serialize is running.
Edge Cases
I'm worried about weird setups though, like nested serializers or something. I can't really think of any concrete case atm that'd pose a problem for this proposal though, but I'll need to spend some more time thinking about it before accepting.

Hmm, the concerns in my previous comment may actually be a non-issue.
As it is now, a getty.ser.Seq implementation returned from serializeSeq can't have any stack-based values with local lifetimes anyways.

One potential issue is that if the serializer itself implements, say getty.ser.Seq, we may run into some dependency loops.


Tests failing cus of error: type 'MockRtcEngine' is not a subtype of type 'RtcEngineImpl' in type cast

Before v6.2.3 I could easily mock RtcEngine class and run tests but after updating to the most recent version my tests are no longer working.  This is the error I am getting:

I am using mocktail package to mock RtcEngine and stub it's methods. When I downgrade to 6.2.2 everything works fine.
Any help would be greatly appreciated.

The createAgoraRtcEngine returns the RtcEngineImpl underlying
https://github.com/AgoraIO-Extensions/Agora-Flutter-SDK/blob/64dbdada39638d763c1ef0dd07646eb95ecbd7bf/lib/src/agora_rtc_engine_ext.dart#L44
How does your test case look like, maybe it's not a good way to mock the RtcEngine interface if your test case is combined with the AgoraVideoView.

I am getting the error when each widget test is finished which means I am getting the error only when the AgoraVideoView is getting disposed. This is how I am mocking the RtcEngine:

As I said I am not having issues with 6.2.2. A change made in 6.2.3 is the cause of the issue. My hunch is that the problem might be happening because extension methods can not be stubbed.

If the rendering is not a matter of your test, I think you'd better mock VideoViewController and pass it to your AgoraVideoView implementation.


Bump version strings

While the next release is probably a little while away enough new
features have landed since 0.3.4 that we can safely know that the next
release is 0.4.0. In preparation for that this bumps the version strings
in the setup.py and Cargo.toml, this is mostly to facilitate testing so
that we know when we're comparing a released version vs current master.

Coverage remained the same at 81.737% when pulling a02586840825812b227f03358d32aace8f81a849 on mtreinish:bump-versions into ddf1e16a14d8e7597863fa5882fde121287a936e on Qiskit:master.


[bug]: The input type:file display does not match the documentation

Describe the bug
The input type:file display does not match the documentation. There seems to be a problem with the className for type: file.
Affected component/components
Input
How to reproduce

install shadcn installation
npx shadcn-ui@latest add input
create input_file.tsx file
npm run dev
open localhost

Documentation:

After i try:

code:

input.tsx

input_file.tsx

Codesandbox/StackBlitz link
No response
Logs
No response
System Info
OS: windows 10
Browser: Chrome

Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues

I feel like this is most likely not really an issue with ShadcnUI but maybe more with some other configs you have. How does your index.css look like? I fear you might have some other styling there that is overriding here.

I feel like this is most likely not really an issue with ShadcnUI but maybe more with some other configs you have. How does your index.css look like? I fear you might have some other styling there that is overriding here.

I don't think I added anything that caused this problem. But here is my index.css file
index.css:
/* Tailwind Start /
@tailwind base;
@tailwind components;
@tailwind utilities;
/ Tailwind End */
/* Shadcn Start */
@layer base {
:root {
--background: 0 0% 100%;
--foreground: 222.2 84% 4.9%;
--card: 0 0% 100%;
--card-foreground: 222.2 84% 4.9%;

--popover: 0 0% 100%;
--popover-foreground: 222.2 84% 4.9%;

--primary: 222.2 47.4% 11.2%;
--primary-foreground: 210 40% 98%;

--secondary: 210 40% 96.1%;
--secondary-foreground: 222.2 47.4% 11.2%;

--muted: 210 40% 96.1%;
--muted-foreground: 215.4 16.3% 46.9%;

--accent: 210 40% 96.1%;
--accent-foreground: 222.2 47.4% 11.2%;

--destructive: 0 84.2% 60.2%;
--destructive-foreground: 210 40% 98%;

--border: 214.3 31.8% 91.4%;
--input: 214.3 31.8% 91.4%;
--ring: 222.2 84% 4.9%;

--radius: 0.5rem;

}
.dark {
--background: 222.2 84% 4.9%;
--foreground: 210 40% 98%;
--card: 222.2 84% 4.9%;
--card-foreground: 210 40% 98%;

--popover: 222.2 84% 4.9%;
--popover-foreground: 210 40% 98%;

--primary: 210 40% 98%;
--primary-foreground: 222.2 47.4% 11.2%;

--secondary: 217.2 32.6% 17.5%;
--secondary-foreground: 210 40% 98%;

--muted: 217.2 32.6% 17.5%;
--muted-foreground: 215 20.2% 65.1%;

--accent: 217.2 32.6% 17.5%;
--accent-foreground: 210 40% 98%;

--destructive: 0 62.8% 30.6%;
--destructive-foreground: 210 40% 98%;

--border: 217.2 32.6% 17.5%;
--input: 217.2 32.6% 17.5%;
--ring: 212.7 26.8% 83.9%;

}
}
@layer base {

{
@apply border-border;
}
body {
@apply bg-background text-foreground;
}
}
/* Shadcn End */

/* Custom Start /
/ font style and change theme transistion Start /
body * {
@apply font-mono;
@apply transition-colors duration-75 ease-in-out;
}
/ font style and change theme transistion End */
/* Remove input number arrow Start */
.remove-arrow::-webkit-inner-spin-button,
.remove-arrow::-webkit-outer-spin-button {
-webkit-appearance: none;
margin: 0;
}
.remove-arrow {
-moz-appearance: textfield;
}
/* Remove input number arrow End /
/ Custom End */

@FelixR11
Tried reinstalling the component ?

I already re-add the component and overwrite it. The result is still the same as what I gave above.
terminal (pwsh):
npx shadcn-ui@latest add input
√ Component input already exists. Would you like to overwrite? ... yes
✔ Done.

Try installing manually

I tried to reinstall with new files, here are the results.
result (dark theme):

after I checked again the files that might have css styles, I forgot I added the css style script from flowbite in index.html.
I use flowbite to create a sidebar that has a navbar. The sidebar has a hidden feature when the display has a smartphone screen size and it uses javascript in it so I added the script. flowbite sidebar
flowbite script:
<link href="https://cdnjs.cloudflare.com/ajax/libs/flowbite/2.3.0/flowbite.min.css" rel="stylesheet" />
<script src="https://cdnjs.cloudflare.com/ajax/libs/flowbite/2.3.0/flowbite.min.js"></script>

I apologize for my mistake and thank you for your help.

Should we close this ?
:)


Upgrading Piped in UI or manually

What happened:
I've installed PipeCD at version v0.43.1, then I deploy with helm upgrade with the same version Piped, then I want to try upgrade to latest release, for example it fails, but it still tries to upgrade to latest, it is still checking the latest releases /ListLatestReleases, it does not indicate UI if it can upgrade or not, it just says Upgrading to..., I wanted to upgrade to v0.44.0, so I tried it manually with helm upgrade, when I am on the version I've selected in the UI, the message Upgrading to ... dissapears, but when I am downgrading to 0.43.1 back, it starts to again in UI show the same message, Upgrading to v0.44.0, when I deleted the Piped and then installed with the helm upgrade the actual latest release version v0.44.2 then I refreshed on the UI page, it says Upgrading to v0.44.0, user should stop the PipeCD, to stop automatically triggering upgrading, if it fails or if the user tries to upgrade it with remote config via helm upgrade
Environment:

piped version: v0.43.1
control-plane version: v0.43.1

Could you share which helm command did you used to install the piped in first place? 👀

	helm --kube-context ${K8S_CONTEXT} upgrade -i piped oci://ghcr.io/pipe-cd/chart/piped --version=${PIPED_VERSION} \
	--namespace=${NAMESPACE} \
	--set-file config.data=.....

I am not using Launcher option, but with that option, I can see log, but then I can not download piped it fails to download, when I am using it without Launcher option I do not have any problem to start a pods with any version, then error persist

Thanks for the information. Maybe it's docs missing but to enable upgrade/downgrade piped version via web console, you have to use launcher option 😄
Could you share the error log in case of using launcher option in your end? 👀

When I am not using the launcher option, I can start the pods or I can start them with the different version, control-plane will register them and can detect different piped versions, without launcher I cannot start any piped pod, because it can not download proper version from pipecd releases in cluster, but if i am not using launcher option i am still able to trigger the version upgrade from UI even if it does not work with my config
LAUNCHER: will relaunch a new Piped because some changes in version/config were detected
LAUNCHER: downloading https://github.com/pipe-cd/pipecd/releases/download/v0.44.2/piped_v0.44.2_linux_amd64...
LAUNCHER: failed while launching new Piped    {"error": "failed to download Piped from https://github.com/pipe-cd/pipecd/releases/download/v0.44.2/piped_v0.44.2_linux_amd64 to /home/piped/.cache/piped-launcher/piped/bin (HTTP GET https://github.com/pipe-cd/pipecd/releases/download/v0.44.2/piped_v0.44.2_linux_amd64 failed (Get \"https://github.com/pipe-cd/pipecd/releases/download/v0.44.2/piped_v0.44.2_linux_amd64\": dial tcp <IP_ADDRESS>:443: i/o timeout))"}
github.com/pipe-cd/pipecd/pkg/app/launcher/cmd/launcher.(*launcher).run.func5
    /home/runner/work/pipecd/pipecd/pkg/app/launcher/cmd/launcher/launcher.go:260
github.com/pipe-cd/pipecd/pkg/app/launcher/cmd/launcher.(*launcher).run.func6
    /home/runner/work/pipecd/pipecd/pkg/app/launcher/cmd/launcher/launcher.go:272
golang.org/x/sync/errgroup.(*Group).Go.func1
    /home/runner/go/pkg/mod/golang.org/x/sync@v0.1.0/errgroup/errgroup.go:75
LAUNCHER: failed while launching new Piped    {"error": "failed to download Piped from https://github.com/pipe-cd/pipecd/releases/download/v0.44.2/piped_v0.44.2_linux_amd64 to /home/piped/.cache/piped-launcher/piped/bin (HTTP GET https://github.com/pipe-cd/pipecd/releases/download/v0.44.2/piped_v0.44.2_linux_amd64 failed (Get \"https://github.com/pipe-cd/pipecd/releases/download/v0.44.2/piped_v0.44.2_linux_amd64\": dial tcp <IP_ADDRESS>:443: i/o timeout))"}
github.com/pipe-cd/pipecd/pkg/app/launcher/cmd/launcher.(*launcher).run.func6
    /home/runner/work/pipecd/pipecd/pkg/app/launcher/cmd/launcher/launcher.go:273
golang.org/x/sync/errgroup.(*Group).Go.func1
    /home/runner/go/pkg/mod/golang.org/x/sync@v0.1.0/errgroup/errgroup.go:75
failed while running    {"error": "failed to download Piped from https://github.com/pipe-cd/pipecd/releases/download/v0.44.2/piped_v0.44.2_linux_amd64 to /home/piped/.cache/piped-launcher/piped/bin (HTTP GET https://github.com/pipe-cd/pipecd/releases/download/v0.44.2/piped_v0.44.2_linux_amd64 failed (Get \"https://github.com/pipe-cd/pipecd/releases/download/v0.44.2/piped_v0.44.2_linux_amd64\": dial tcp <IP_ADDRESS>:443: i/o timeout))"}
github.com/pipe-cd/pipecd/pkg/app/launcher/cmd/launcher.(*launcher).run
    /home/runner/work/pipecd/pipecd/pkg/app/launcher/cmd/launcher/launcher.go:299
github.com/pipe-cd/pipecd/pkg/cli.runWithContext
    /home/runner/work/pipecd/pipecd/pkg/cli/cmd.go:95
github.com/pipe-cd/pipecd/pkg/cli.WithContext.func1
    /home/runner/work/pipecd/pipecd/pkg/cli/cmd.go:51
github.com/spf13/cobra.(*Command).execute
    /home/runner/go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:842
github.com/spf13/cobra.(*Command).ExecuteC
    /home/runner/go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:950
github.com/spf13/cobra.(*Command).Execute
    /home/runner/go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:887
github.com/pipe-cd/pipecd/pkg/cli.(*App).Run
    /home/runner/work/pipecd/pipecd/pkg/cli/app.go:69
main.main
    /home/runner/work/pipecd/pipecd/cmd/launcher/main.go:32
runtime.main
    /opt/hostedtoolcache/go/1.20.5/x64/src/runtime/proc.go:250
2023/07/14 13:16:38 failed to download Piped from https://github.com/pipe-cd/pipecd/releases/download/v0.44.2/piped_v0.44.2_linux_amd64 to /home/piped/.cache/piped-launcher/piped/bin (HTTP GET https://github.com/pipe-cd/pipecd/releases/download/v0.44.2/piped_v0.44.2_linux_amd64 failed (Get "https://github.com/pipe-cd/pipecd/releases/download/v0.44.2/piped_v0.44.2_linux_amd64": dial tcp <IP_ADDRESS>:443: i/o timeout))

If i am not using launcher option i am still able to trigger the version upgrade from UI even if it does not work with my config

Basically, that's just the web showing; whenever your piped version and piped desired version are not matched, the web UI shows that way, but if you surely don't use the launcher, your piped will not be updated. Just because you're using the same piped ID with try to use launcher piped so it's showing that way. You're right; maybe we need a way to detect whether the piped is run using the launcher or not reset desired version ID if needed. In the meantime, you can update the PipeCD database, piped model directly.
ref: https://github.com/pipe-cd/pipecd/blob/master/pkg/model/piped.proto#L78-L81
I'm more interested in why the launcher can not download the piped version you specified 🤔 I can see the network timeout error, but the link is available, and I can download the piped binary normally 🤔 Is there any problem with your cluster network? Could you try downloading the piped bin from your pod using wget or curl command to test the connection?

yea yea, I have network traffic turned off where I am testing, I can not deploy pods then with Launcher option, because as I said, it can not download the latest releases and check start pods, so when I am turning off that option to deploy piped without the launcher option, I can deploy the piped with any version and the pods are running, control-plane detects them but I am able to trigger upgrade and it's starts to run, till I manually upgrade to desired version

I see, thanks for sharing 👍
So if this issue is about finding a way to web console to know the piped is run by launcher or not to on/off the piped upgrade feature, I can say it's a bit hard for now due to the design around piped and launcher.
In short, the piped and the web console knows nothing about the launcher (there is no launcher model as well), launcher is just a light wrapper which in charge for the piped execution, it intervally requests for desired version of piped and check whether or not it should update piped to that version. The piped, in another hand is a stateless process and it can be stop/restart whenever launcher decides it should be.
Maybe we can add a flag like startedBy to piped model and piped which has that value set to launcher should be treated differently (enable restart/upgrade via console), but I don't really like that solution, because I think piped should not know about the launcher or any. wdyt?

Ok, I understand, hmmm maybe that flag, but you said that you do not like that solution, what about the counter for web ui, if the upgrade does not succeed, it will remove the error that desired version does not have match for proper piped, if we want to achieve that the piped won't have any information about launcher.

In such case, the unable to upgrade piped will be treated the same for both launcher can not upgrade piped successfully and there is no launcher, so no way to upgrade the piped. So I guess I can't agree with that approach 🤔


Add "New message" shortcut.

If it's ok to add this shortcut, let me know and i will add the translations (as New conversation is a sentence that exists in another context).

Awesome!!! I'm merging manually as there are conficts.
Thanks!

Done! I'll push a new beta-rolling version in a bit


Search for markets by searchterm "id:number"

Make it possible to search for markets by searchterm "id:number" like "id:344"
Can be handy for internal use and for users that are not so comfortable with urls or that are on mobile.

If it affects the current search functionality negatively I'd say we should avoid implementing this. Personally I just put the id right into the URL.
However, it got me thinking that we should include some sort of feature for users to be able to save a collection of markets.


Load field IDs only a task at a time

Hopefully fixes #215. Hopefully fixes #217.

I removed the --stage option from infer-box. As the text says, you now have to stage the files first. Starting some runs with this now, to see if the memory problem is gone.

The Travis failure is:
The command "sudo apt-get install libcfitsio3 -y" failed and exited with 100 during .

Looks like some host is down. :(

Didn't fix #215:
slurmstepd: Exceeded job memory limit at some point.

Does what I did look right?

Tested and works.


Permission denied @ rb_sysopen - .../fauxhai/platforms/opensuse/13.2.json

The existing Gemfile depends upon 'chefspec', '~> 4.2.0', which in turn requires depends upon  'fauxhai', '~> 3.0', '>= 3.0.1'.  However, support for opensuse 13.2 was not added to fauxhai until version 4.0 and version 4.0 was not introduced to chef spec until version 4.5.  Thus, I suggest we update the Gemfile to use 'chefspec', '~> 4.5.0'.

This has been merged and will be part of the next release.


Switch to use Stepper component to add app from Git

What this PR does / why we need it:
This PR makes a change on the form to add an app from Git to use the Stepper API.
This allows you to clearly separate the two actions that the you should take.
https://user-images.githubusercontent.com/19730728/146480370-51911562-5678-44b4-9895-3b3408c6454f.mov
t this PR does / why we need it**:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

/todo skip

I made a minor change to close the second stepper whenever you re-select Piped.

Nice work 👏  LGTM with a small nit
/lgtm

🚀
/lgtm

/trigger web-test

Great. Looks beautiful.
/approve


python load_csv does not handle "schema", needs to make symbols for syntax:header

The python version of load_csv does not take "schema" as an argument.
It also needs to translate strings to symbols properly when header is used.
To test, try loading a CSV file using both schema and header.

Note: This issue has been migrated to https://relationalai.atlassian.net/browse/RAI-4189.
This link is only accessible to employees of RelationalAI.


Fix: context of reverse

fix #1498

Codecov Report

Merging #1502 (06c34e2) into master (ef58fde) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1502      +/-   ##
==========================================
- Coverage   39.52%   39.37%   -0.16%
==========================================
  Files         598      590       -8
  Lines       35068    34956     -112
==========================================
- Hits        13861    13764      -97
+ Misses      19680    19662      -18
- Partials     1527     1530       +3

Impacted Files
Coverage Δ

app/reverse/bridge.go
0.00% <0.00%> (ø)

app/reverse/portal.go
12.31% <0.00%> (ø)

app/reverse/reverse.go
2.43% <0.00%> (ø)

app/proxyman/outbound/errors.generated.go
0.00% <0.00%> (-100.00%)
:arrow_down:

common/task/task.go
88.88% <0.00%> (-7.41%)
:arrow_down:

testing/servers/tcp/tcp.go
81.81% <0.00%> (-5.46%)
:arrow_down:

testing/scenarios/common.go
73.07% <0.00%> (-4.62%)
:arrow_down:

app/proxyman/outbound/handler.go
38.05% <0.00%> (-4.48%)
:arrow_down:

transport/internet/udp/hub.go
73.61% <0.00%> (-4.17%)
:arrow_down:

transport/internet/system_listener.go
48.07% <0.00%> (-3.85%)
:arrow_down:

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef58fde...06c34e2. Read the comment docs.


reload known recipies at start

This fixes a bug in Valheim, were new recipes are not added when the player spawns. It is added when the inventory updates (eg. by picking an item up)
It's because the player calls UpdateKnownRecipesList() in Awake(), but Load() hasn't be called, so m_knownMaterial has no elements. Therefore no new recipies can be added.

Awesome, thanks


Clean up clippy lints

A number of lints are tripping. None look critical, but would be good to clear all the warnings.

Clippy lints cleared, and is now enabled on CI


fix: all collection items must start at the same column

Reporting a bug?
Why I use the yaml format in SFCs, I get the All collection items must start at the same column error as can be seen in the reproduction provided below.
Expected behavior
That error does not show and the projects builds successfully.
Reproduction
https://stackblitz.com/edit/github-a5wazj?file=app.vue,nuxt.config.ts
Issue Package
unplugin-vue-i18n
System Info
System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.14.2 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 7.17.0 - /usr/local/bin/npm

Screenshot
No response
Additional context
Nuxt module beta1 works.
Validations

[X] Read the Contributing Guidelines.
[X] Read the README
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion.

Hi!
Thank you for your reporting!
Sorry my late response 🙇
I checked your repro repo.
nuxtjs/i18n uses unplugin-vue-i18n internally.
Set unplugin-vue-i18n to vite plugin in your nuxt.config.ts options.
The problem with this issue is that unplugin-vue-i18n is set twice.
unplugin-vue-i18n has already configured in nuxtjs/i18n, please remove the plugin you explicitly specified if you don't need it.
Thank you for always!


I can't get the code under Quick Start to work

I'm making an extension for Business Central, where I at one point need to read information from an item in 1Password. So I began creating a simple console exe for Windows, coded in c#, using your wrapper. And I followed your example under Quick Start. This is my current code:
var options = new OnePassword.OnePasswordManagerOptions();
options.Path = "c:\\Program Files\\1Password CLI\\";
options.Verbose = true;
var op = new OnePassword.OnePasswordManager(options);

var domain = "xxxxxxx.1password.eu";
op.UseAccount(domain);
var my1password = "yyyyyyy";
op.SignIn(my1password);

//onePasswordMgt.SignOut();

var vaults = op.GetVaults();

Running this, makes 1Password on my workstation prompt for my password, that are enteret without error.
It fails at op.GetVaults(); with Cannot execute command because account has not been signed in. Using verbose, the console shows my this: op signin --force --raw --format json --no-color --account xxxxxxx.1password.eu. I tried running with a signout right after signin. And I get the same error. So I'm kind a stuck here.
I'm using CLI version 2.24.0,OnePassword.NET <IP_ADDRESS> and .NET 8.
I can get it to work using PowerShell only. But that's not my favorite method.
Any ideas?

Hi John,
I'm going to do some testing on my end to see if anything's changed. I'll get back to you soon.

After looking into your issue, I discovered there was an error with the SignOut command, which I fixed. A new version has been published, v2.3.3.
A couple of notes regarding signing in and signing out.
If you want to write automation that will run on a server or in a pipeline, I recommend you do the following steps on every run.
onePassword.AddAccount(domain, email, secretKey, password);
onePassword.SignIn(password);
// Do work
onePassword.SignOut();
onePassword.Forget();

Accounts are stored in the environment by the CLI and the environments gets wiped between builds since they tend to run on different servers.
If you're confident that your environment will preserve the account information, you could do something along the lines of:
var accounts = OnePassword.GetAccounts();
if (accounts.Count == 0)
    onePassword.AddAccount(domain, email, secretKey, password);
onePassword.SignIn(password);
// Do work
onePassword.SignOut();

Let me know if you still have issues. And thanks for bringing this up.

Yes, the issue is still there.
I did this code:
var options = new OnePassword.OnePasswordManagerOptions();
options.Path = "c:\\Program Files\\1Password CLI\\";
options.Verbose = true;
var op = new OnePassword.OnePasswordManager(options);

var domain = "xxxx.1password.eu";
var email =<EMAIL_ADDRESS>var secretKey = "A3-blabla";
var password = "ppp";

op.AddAccount(domain, email, secretKey, password);
op.SignIn(password);
var vaults = op.GetVaults();

It prompts me for login to 1password, and the it fails at the GetVaults() line. It also fails if I change the last line to SignOut().
The console output:

(greetings from Denmark)


Clarify relationship with google-api-go-client is unclear.

Neither the README for this project nor the README for google-api-go-client explains the relationship between these two projects. As a result, newcomers experience them as two uncoordinated alternatives and because one is labeled "automatically generated" and the other contains prominent disclaimers about possible changes, neither appears to be a usable solution.
The simplest way to address this would be to put more user-friendly information in the README. I suggest adding something like the following to the README of this project.

This repository contains handwritten Go packages for calling selected Google APIs. It builds on the google-api-go-client project, which contains lower-level, automatically-generated client libraries. Because it is automatically-generated, google-api-go-client supports a large set of Google APIs, so if the API that interests you isn't supported here, please look there for a possible solution.

The story is about to get more complicated (and interesting). These handwritten packages are going to migrate to live on top of clients generated from the  Google API Code Generator, which use gRPC. We're still figuring out where those generated clients will live. When the dust settles, I'll modify the README along the lines you suggest.

We're still figuring out where those generated clients will live.

Has there been any update on figuring out where the clients generated with googleapis/toolkit will live?

I'm afraid not.

We do have some text in the google-api-go-client README that points to this repo. I don't think we need to add a pointer in the other direction.


feat(presets): added presets to several entity drafts for use by audi…

Summary
Added presets to several entity drafts for use in audit log.
CategoryDraft.withNoParent
CustomerDraft.withNoDOB
InventoryEntryDraft.withNoSupplyChannel
ProductTypeDraft.withNoAttributes
ShoppingListDraft.withNoCustomer

I believe models/shopping-list/src/shopping-list-draft/presets/index.ts also needs to be updated to expose these properly:
import changeHistoryData from './change-history-data';
const presets = {
  changeHistoryData,
};
export default presets;

As is
To be

Thanks!!! I missed that. Good catch.


Type error in documentation example

It seems that the example code has not been updated after adding null safety.
https://github.com/flutter/flutter/blob/ee4e09cce01d6f2d7f4baebd247fde02e5008851/packages/flutter/lib/src/widgets/inherited_model.dart#L38

While updating this for null safety, adding a complete example


updated humanitarian data exchange url

url for Humanitarian Data Exchange was broken on README. Fixed.

Thanks very much for the fix!

@jozefdickins This merge will be overwritten by next update of apd-core, which holds the source files of data entries and provides the link accessibility validation for them. You should change the source file instead of the generated file directly. Thanks!
CHANGE ME: https://github.com/awesomedata/apd-core/blob/master/core/SocialSciences/Humanitarian-Data-Exchange.yml


Consistent tagging

Release tags have a mix of v${VERSION}, and just ${VERSION} tags, would be nice for them to conform to a single paradigm

will go with ${VERSION}  (new release = 1.5.5)


python_ethernet_rmp: 0.0.2-0 in 'jade/distribution.yaml' [bloom]

Increasing version of package(s) in repository python_ethernet_rmp to 0.0.2-0:

upstream repository: https://github.com/WPI-RAIL/python_ethernet_rmp.git
release repository: https://github.com/wpi-rail-release/python_ethernet_rmp-release.git
distro file: jade/distribution.yaml
bloom version: 0.5.19
previous version for package: null

python_ethernet_rmp
* Merge pull request #6 <https://github.com/WPI-RAIL/python_ethernet_rmp/issues/6> from cmdunkers/develop
  fixed the default_bitmap issue
* Fixed the default_config bitmap to 1 instead of the default since default does not work with carl
* Merge pull request #2 <https://github.com/WPI-RAIL/python_ethernet_rmp/issues/2> from WPI-RAIL/develop
  Update CMakeLists.txt
* Merge pull request #1 <https://github.com/WPI-RAIL/python_ethernet_rmp/issues/1> from WPI-RAIL/master
  Cleanup and release of 0.0.1
* Update CMakeLists.txt
* Merge pull request #5 <https://github.com/WPI-RAIL/python_ethernet_rmp/issues/5> from WPI-RAIL/develop
  0.0.1
* Contributors: Chris Dunkers, Russell Toris, cmdunkers

And again, sorry.


Make debuggable does not work on Android 6.0.1

I've installed the latest Xposed Framework and installed the XInstaller apk from the Xposed modules page (XInstaller 5.0),
The feature that should make apps debuggable does not work for me. I've verified this with the Android Studio Debugger and the Inspeckage tool (Xposed Framework)

Try this tweak: https://github.com/deskid/XDebug


feature: when create tree can apply template

When there is theorem.tree in template directory, one can use below command that applied template content as default content
forester new --dest=trees --template=theorem --prefix=math

If can also create tree in nvim like this will be great!

Quick implementation, let me know if there are any issues.


Meteor.user() - Trackr

Is Meteor.user() using trackr? im trying to use react-komposer to update changes, however, whenever i update my data remotely im not seeing any changes in my app.
const ListOfItems = ({ items, openProject }) => (
  <List>
    {
      items.map((item, key) => (
        <ListItem key={ key }>
          <Text onPress={ openProject(item) }>
            { item.text }
          </Text>
        </ListItem>
      ))
    }
  </List>
);

const onPropsChange = (props, onData) => {
  Trackr.autorun(() => {
    const user = Meteor.user();
    console.log(user);
    onData(null, {
      ...props,
      items: [
        {
          text: user && user.profile.fullName
        }
      ]
    });
  });
};

const ProjectList = compose(onPropsChange, <Text />, <Text />)(ListOfItems);

Yes, Meteor.user() is using Trackr but internally. You have to use it into getMeteorData.
react-komposer is the same as new meteor 1.3 createContainer spec right ? Because I will be adding this soon.

Actually, I believe createContainer is also built on top of meteor's getMeteorData.   @patrickml highlights a issues I brought up a few days ago. Discussion about how to handle data loading via react. My question for @patrickml, do you have trackr attached to your context configuration and what did you decide to use for local state.  A nice article about the approaches can be found here.
https://www.discovermeteor.com/blog/data-loading-react/

Il have to get back to you next when I get back from vacation. I cannot
remember exactly what I was doing.
On Mon, May 2, 2016 at 8:00 AM smooJitter<EMAIL_ADDRESS>wrote:

Actually, I believe createContainer is also built on top of meteor's
getMeteorData. @patrickml https://github.com/patrickml highlights a
issues I brought up a few days ago. Discussion about how to handle data
loading via react. My question for @patrickml
https://github.com/patrickml, do you have trackr attached to your
context configuration and what did you decide to use for local state. A
nice article about the approaches can be found here.
https://www.discovermeteor.com/blog/data-loading-react/
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/inProgress-team/react-native-meteor/issues/55#issuecomment-216218599

@patrickml any update? I'm curious to know how you did to handle mantra with RN meteor!

Sorry I forgot about this ticket. Il write up details once I get the kids
to bed tonight.
On Fri, May 27, 2016 at 9:31 PM Fernando Mumbach<EMAIL_ADDRESS>wrote:

@patrickml https://github.com/patrickml any update? I'm curious to know
how you did to handle mantra with RN meteor!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/inProgress-team/react-native-meteor/issues/55#issuecomment-222283150,
or mute the thread
https://github.com/notifications/unsubscribe/AHOuudNOrHdC78vYhH1bUSO1VUoCg1pqks5qF5rqgaJpZM4IJEJP
.

@smooJitter and @fermuch in order to use react-komposer I needed to import trackr which is an npm package modeled around Meteors Tracker
"react-komposer": "^1.8.0",
"trackr": "^2.0.2",
"trackr-reactive-var": "^1.4.0",

in order to use react-komposer i needed to make trackr global
i did this simply by adding this in my app.js file
import Trackr from 'trackr';

// react komposer needs tracker so we need to make it global
global.Tracker = Trackr;

After this, I had no problem using stateless components that are composed with react-komposer
const flex = ({ visibleHeight }) => (
  <View style={[styles.background, { height: visibleHeight }]}>
    <StatusBar barStyle="light-content" />
    <ProjectLists />
    <ActiveProject />
    <CreateTicket />
  </View>
);

flex.propTypes = {
  visibleHeight: PropTypes.number,
};

export default composeWithTracker((props, onData) => {
  onData(null, {});
}, Loading, Error)(flex);

@smooJitter as for the local state -- I've created a version of redux that runs on Tracker and is so so so much simpler -- I haven't finished the docs, but here is the repo https://github.com/patrickml/event-horizon
I have a local version of that package that is for react-native the only difference is I needed to import "trackr-reactive-var": "^1.4.0"
This allows me to do stuff like this
import EventHorizon from '../event-horizon/index';

const defaultConfig = {
  open: false,
  priority: 'normal',
  description: '',
  images: [],
};

EventHorizon.createStore('create-ticket', defaultConfig);

EventHorizon.createAction('create-ticket', 'OPEN_CREATE_TICKET_MODAL', (store, data, update) => {
  update({
    open: true,
  });
});

EventHorizon.createAction('create-ticket', 'CLOSE_CREATE_TICKET_MODAL', (store, data, update) => {
  update(defaultConfig);
});

EventHorizon.createAction('create-ticket', 'TICKET_UPDATE_PRIORITY', (store, priority, update) => {
  update({
    priority,
  });
});

EventHorizon.createAction('create-ticket', 'TICKET_ADD_IMAGE', (store, image, update) => {
  update({
    images: [
      ...store.images,
      image,
    ],
  });
});

EventHorizon.createAction('create-ticket', 'TICKET_REMOVE_IMAGE', (store, index, update) => {
  update({
    images: [
      ...store.images.slice(0, index),
      ...store.images.slice(index + 1),
    ],
  });
});

export default composeWithTracker((props, onData) => {
  onData(null, EventHorizon.subscribe('create-ticket'));
}, Loading, Loading)(TicketModal);

<Button
      text="submit"
      onPress={() => { EventHorizon.dispatch('CLOSE_CREATE_TICKET_MODAL'); }}
    />

I hope that helps!

@patrickml thank you for answering so fast!
I was just writing back to you how I did the same but it wasn't working but for me, but I realized something:
Meteor.status() is not reactive. The docs says it is, but it doesn't for me.
For example:
export const composer = ({context}, onData) => {
  const {Meteor} = context();
  onData(null, {status: Meteor.status().status});
};

export const depsMapper = (context) => ({
  context: () => context
});

export default composeAll(
  composeWithTracker(composer, Loading, Error),
  useDeps(depsMapper)
)(DebugConnection);

But then before posting my answer I tried to use .subscribe instead of .status and it works!
Tomorrow I'll try to debug a little more to know if the problem is on my side or in RN meteor.

None of the supposedly reactive methods exposed in react-native-meteor are actually reactive. Meteor.status() simply reads from Data.ddp, and Meteor.collection().find() etc reads from minimongo-cache, which is a fork of minimongo that isn't reactive. I find this a bit of a strange approach, as it forces you to use createContainer or getMeteorData -- i.e. you can't do:
Tracker.autorun(() => {
  Meteor.status()
})

... and expect that to re-run each time Meteor.status() has changed. It will run once, and that's it. To be fair, the docs do state These variables can be used inside getMeteorData or createContainer. I expected that I could use them within a vanilla Tracker.autorun, but that's not the case.
What react-native-meteor is actually doing is that any DDP message it receives triggers a single dep.changed(), and all createContainers etc are re-run as they dep.depend() on that single dependency. This means that any message coming via DDP will re-run all createContainers you have in your app.
This seems like a proof-of-concept type of approach, but I don't think should be the way to go moving forward. I'd suggest ditching minimongo-cache and instead using minimongo itself, and looking at what normal Meteor is doing when receiving DDP messages and how it handles granular invalidations.

@matb33 thanks for the insight into this. I hadn't looked that far into this package yet. But this would explain the exact issues myself and others were experiencing

Thanks for your feedback @matb33. I'll try to dig into this when I come back from my vacations in two weeks.
One question though, why would you use minimongo over minimongo-cache ?
@patrickml What issues are you talking about ?

Hey @Mokto, the reason I suggest minimongo (and specifically LocalCollection) is because it's built with reactivity throughout. By using minimongo-cache, you're effectively removing all the fine-grained reactivity that minimongo is capable of doing, and adding reactivity to the entire minimongo-cache -- any DDP message, even if it's unrelated to a collection, triggers this global invalidation and causes everything to re-run.
I'd also use ReactiveVar as well for Meteor.status() and pals. Upon receiving a DDP message for new data for it, you'd .set that ReactiveVar. Only the createContainers or autoruns that use that ReactiveVar would re-run (as opposed to every single createContainer in the app).
The same thing applies to createContainers or autoruns that use a particular collection. In fact, only the .find() queries that would be affected when changes are made would re-run. This is something that the Meteor devs strived really hard to achieve, i.e. prevent re-running queries where they could determine that re-running would make no difference.
When you receive DDP messages, you would either update the appropriate ReactiveVar (for Meteor.status etc) or the appropriate LocalCollection (for collections). You wouldn't have to manage any Tracker.Dependencys whatsoever, and createContainer and getMeteorData would simply be layers on top of Tracker.autorun.

any updates for this?


Detect ABA_ROUTING_NUMBER

Description
The ABA_ROUTING_NUMBER is a nine-digit code used to identify U.S banks for checks, direct deposits and transfers. It is considered personally identifiable information because it is linked to bank accounts which is sensitive information that should be protected. For more information see here.
Detection Steps
ABA_ROUTING_NUMBER is a nine-digit code. The first two digits indicate Federal Reserve district or regional processing center and range from 00 - 12, 21 to 32, or 61 to 72. The last digit is a checksum where the first, fourth and seventh digits are multiplied by three. The second, fifth and eighth digits are multiplied by seven. The third and sixth digits are multiplied by one. The total is summed and the ninth digit is the number that makes the total divisible by 10.

Does the routing number have the ability to be accessed universally outside of the primary country?

Does the routing number have the ability to be accessed universally outside of the primary country?

No, an ABA routing number is primarily used within the United States  and cannot be directly used for international transactions. International transfers tend to use other systems like SWIFT codes or IBANs.

How could an individual find out if their routing number is stolen?

Description and detection steps look good

What security measures are used by banks to protect routing numbers?

How could an individual find out if their routing number is stolen?

One might run a credit report, check their bank statements,  or use other third-party fraud detection services. In the case that someone's routing number has been stolen a report can be filed with the Federal Trade Commission (FTC) https://www.identitytheft.gov/.

What security measures are used by banks to protect routing numbers?

Banks have a few methods including data encryption, multi-factor authentication and transaction limits.

What are some examples of response plans that banks and credit unions have if a routing number were to get leaked as well as the accounting number?


Add builder for NodeTypes::ChainSpec

Describe the feature
Add trait bound NodeTypes::ChainSpec: reth_node_api::BuilderProvider
Additional context
No response

chainspec instantiation is done via CLI (parse by name or from file) this is already sufficiently abstracted


Fix memory leaks described in issue #179

Hello,
this is a memory leak fix for 0.6.x branch.

Executor calls removeAllListeners() on all commands.
Connection will remove all listeners from executor when connection closes

Obvious memory-leak here is when LazyConnection opens/closes connection.

Example script:
<?php

// load reactphp-mysql/vendor/autoload.php

$loop = \React\EventLoop\Loop::get();
$factory = new \React\MySQL\Factory();
$connection = $factory->createLazyConnection('localhost');
//$connection = \React\Async\await($factory->createConnection('localhost'));

$pre_memory = 0;

$loop->addPeriodicTimer(
    1,
    function () use ($connection, &$pre_memory) {
        $connection->query('SELECT \'' . str_repeat('A', 1000) . '\'')->then(
            function ($res) use (&$pre_memory) {
                echo " - query done\n";
                $cur_memory = memory_get_usage();
                $new_memory = $cur_memory - $pre_memory;
                echo " - Memory usage: " . memory_get_usage() . " new: " . $new_memory . "\n";
                $pre_memory = $cur_memory;
            },
            function ($e) {
                echo " - query error: " . $e->getMessage() . "\n";
                throw $e;
            }
        );
    }
);

$loop->run();

Issue #179


BAU: Move logging to SamlObjectSigner

Is there a reason we had it in a separate class?

@vixus0 Mainly because the others were, so followed that convention

Ah ok fair enough, probably a good idea to do a cleanup then.


gyp ERR! build error on windows installation

I'm getting an error when installing sharp on windows.
The error appears to be:
gyp ERR! build error
gyp ERR! stack Error: C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe failed with exit code: 1
In case it matters. I have visual studio 2010 and 2015 installed on my system.  I'm running Windows 7.
Debug log file is attached.
Regards.
npm-debug.zip

Hello, I'm probably missing something but I don't see the "Error: C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe failed with exit code: 1" message in the attached log file.
Given there are multiple copies of Visual Studio, was the following installation step run?
npm config set msvs_version 2015

install output.zip
I attached the command prompt output from running the install.  There may be several attempts, but the error is there.  I did run the "npm config set msvs_version 2015 installation step. before submitting the issue.

The salient part of the log is:

error MSB8036: The Windows SDK version 8.1 was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution".

https://developer.microsoft.com/en-us/windows/downloads/windows-8-1-sdk

@doyledesigns Were you able to make any progress with this?

Hello;
I have same problem but when I enter to MSBuild file, there are no "14.0". Just "15.0".


Change the menu to the English.

Dear the plateau team.
I am Tommy. Could you can tell me how can modify the github source code to change the menu of the source code to the English.
I try to open this source by using Unity or VS 2022 but I cannot see the unity file or sln file.
Thank you so much.

@tommysnu
We apologize, but we do not yet support English. As this SDK is intended to be integrated into a Unity project after its creation, it does not include any .sln files.


Resolve 0 value fields in RESPONSE

Resolving #169
We need to think if we need this one.

The only issue I see with this change is that it's possible that zero fields are returned for elements that never set them.
set mykey id1 field a 1 point 10 10
set mykey id2 field b 2 point 20 20
set mykey id3 field a 3 point 30 30

get mykey id2 withfields
{"ok":true,"object":{"type":"Point","coordinates":[20,20]},
"fields":{"a":0,"b":2},"elapsed":"40.304µs"}

id2 now returns zero for field a even though it never set the field.

I think the current implementation is better, if value is not there, it is up to the application to decide what to do with the missing field, either assume it is 0, or assume it doesn't exist.
This fix solves nothing, since there is still no way of making a difference between the two cases.

That's why i said i don't know if this one fixes problem at all.

@m1ome Thanks a bunch for the PR. It's provided food for thought, but I think that it's best not to merge at this time. I would rather not change the current behavior unless it solves the the bigger issue of detecting fields that are set, not-set, and zero.