Resolve aiida-core v3 deprecations

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.51%. Comparing base (20269e9) to head (f676235).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   92.73%   92.51%   -0.23%
==========================================
  Files           9        9
  Lines         454      454
==========================================
- Hits          421      420       -1
- Misses         33       34       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Grafana cannot load namespaces and graphs in dashboards

Hi,
I have tried to install latest version on GKE (1.13.6), component Flagger (0.16) and Istio (1.12) are up, but when I access dashboards, it cannot load information about namespace (but the namespace is existed on k8s) and some graphs is missing data as following attached images :

Hope you could help to take a look this issue. Thank you so much.
Best Regards,
VietNC

After talking on Slack the conclusion was that istio-telemetry was in crash loop. Deleting the pod fixed it. Probably a race condition in Mixer, I've seen this many time before.


Exemple with prepare statement

Hi
Someone could help me have an full example with the prepared statement. i found this tutorial :
https://stackoverflow.com/questions/40208873/prepared-statements-in-c-libneo4j-client. but i not working for me.
My code is bellow
neo4j_connection_t *connection = neo4j_connect("neo4j://neo4j:neo4j06@localhost:7687", NULL, NEO4J_INSECURE);
map_entries[0] = neo4j_map_entry("Json", neo4j_string(output.c_str())); // Node properties
map_entries[1] = neo4j_map_entry("label", neo4j_string(NodeDat.getName().CStr())); // Label
neo4j_value_t params = neo4j_map(map_entries, 2);
neo4j_run(connection, query, params);
Best regard

This is what i want to do
// Sauve node & nodeData to neo4j
void neo4jDAO::saveNodeAndPropertiesNetwork(TPt <TNodeNet > m_net)
{
IoT NodeDat;
int index;
Json::FastWriter fastWriter;
string output;
neo4j_value_t params;
neo4j_map_entry_t map_entries[2];
const char *query = "CREATE (n:{label} {Json})";
//const char *query = "CREATE (n:{label})";

for (TNodeNet<IoT>::TNodeI NI = m_net->BegNI(); NI < m_net->EndNI(); NI++)
{
    NodeDat = m_net->GetNDat(NI.GetId());
    index = NI.GetId();

    output = fastWriter.write(NodeDat.getJSON());

    map_entries[0] = neo4j_map_entry("label", neo4j_string(NodeDat.getName().CStr())); // Label
    map_entries[1] = neo4j_map_entry("Json", neo4j_string(output.c_str())); // Node properties

    params = neo4j_map(map_entries, 2);

    //cout << "HERE " << NodeDat.getName().CStr()  << output.c_str() << endl; // Work
    this->stream = NULL;
    this->stream = neo4j_run(this->connection, query, params);

    // Verifies that the query executed correctly
    if(this->stream == NULL)
    {
    	neo4j_perror(stderr, errno, "Failed to fetch result");
    	cout << "Requête pas execute" << endl;
    }
}

}
And when i go to neo4j-client cli, i can't find the new node.

Hi
Could you help me to have the query syntax for parapred statement ?
Cdt

Hi @oumartraore,
It would be great if you could put these kind of questions on StackOverflow, as there's a much bigger community of Neo4j enthusiasts there who could also help answer these types of questions, or benefit from seeing the answers.
This issue tracker is more suited to discussing bugs and issues in the neo4j-client codebase itself. I'll close this issue, but please feel free to post a link to a StackOverflow question when you create one.
Cheers,
Chris


Unable to create Store object

Since today, I am not able to create Store object.
Error:
TypeError: e[o] is undefined[Learn More] progress.317d7146a82d30730e7d.js:2:96
Can you help me please?

#631
webpackJsonp([], {"parasite": (x, y, z) => getStore(z)}, ['parasite']);


Add fixture add_ip_network for agent testing

Implement the add_ip_network fixture to use in the Agents unit tests.
The function has the same definition and use a Dict instead of calling Redis

I don't think this is needed, because the new API is used already mocked APIs.


Ubuntu 19.04

More of a question than an issue: are there plans to at some point have packages for Ubuntu 19.04 in the PPA (and 18.04.3 for that matter)? https://www.presslabs.com/code/gitfs/how-to-use-gitfs/#installing informs us about "fully supporting" 12.04 and 14.04 "now", which is not too confidence-inspiring...

@sixtyfive we just released the 0.5.1 version with packages for ubuntu 18.04, 19.04 and 19.10.
Can you try them out and see if they work as expected?

Sorry, @vtemian, my use case has gone away meanwhile.


[ERROR] Runtime.ImportModuleError: Unable to import module 'index': cannot import name '_imaging' from 'PIL' (/opt/python/PIL/init.py)

I am trying to deploy the changes for Episode 7 but I am struggling to get it working.
I kept the PIL library in the reklayer/python directory and I updated the pipeline stack with:
      synthAction: SimpleSynthAction.standardNpmSynth({
        sourceArtifact,
        cloudAssemblyArtifact,
        buildCommand: 'npm run build',
        synthCommand: 'npm run cdk synth'
      })

But I get this error in cloudwatch:
[ERROR] Runtime.ImportModuleError: Unable to import module 'index': cannot import name '_imaging' from 'PIL' (/opt/python/PIL/__init__.py)
Here is my main repository: https://github.com/piedpiper-ff4084/aws-dev-hour-backend

I manage to deploy the pipeline stack successfully by switching to this synthAction.
synthAction: SimpleSynthAction.standardNpmSynth({
        sourceArtifact,
        cloudAssemblyArtifact,
        buildCommand: 'npm run build',
        synthCommand: 'npm run cdk synth'
      })

I couldn't figure out why using the other synthAction did not work.


Reordering performance passes ordering to produce better opts

Moved initial insert/extract passes later to cover more opportunities
Added an extra set of passes to clean up opportunities exposed later
in the pipeline

I tested this on some industrial shader corpora. After this change all shaders optimize to fixed point in a single pass of -O. Previously many of the shaders required multiple passes to fully optimize.

I ran a couple of shader copora through repeated runs of spirv-opt -O until they reached a fixed point. I had modified the compiler to log which passes which performing optimizations. Through examination of the logs I was able to determine that the posted changes could get all of my test shaders to fixed point in a single pass of -O.
I did not measure compile time. I didn't notice any major compile time increases, but I only have anecdotal evidence. I think this can be decoupled from compile time as we haven't really put any effort yet into reducing compile times.
I also did not measure code size impacts. While reducing code size is very often beneficial for performance, that is not the major objective of -O. Looking at the passes that are newly repeated, I would expect that code size is reduced overall since those optimizations generally produce smaller code size.

@greg-lunarg https://github.com/greg-lunarg, could you test this with
your codebase?

Running -O on my benchmark shader gives size results essentially equivalent
to my current (and current best) size.
Greg

Rebased and pushed into master as abe113219e24


Vertical scroll hangs on iPad

Hi there,
I've been debugging a hang on iPad on some of our sites, for example this one, and I found out that the hang occurs on the second vertical scroll in each direction.
This may sound strange but this is because Mobile Safari has the URL bar that shrinks when scrolling down, and expands when scrolling up, generating a "resize" event on the page. This resize event causes lots of calls to the getWidthFromLength function, which hangs the iPad for a while (the time depends on the iPad model's CPU).
The solution I suggest is to store the viewport at picturefill initialization, then check if the viewport width has changed after resize, and call the resize event only if width has change.
Could it work for you?

Thanks for the issue report, @verloox! What version of Picturefill is this? We made some changes to the resize debouncing recently—would you mind re-testing with the latest version of Picturefill 2 in master?For extra credit, it would be hugely helpful if you could test the Picturefill 3.0 beta.

Yeah, a check with pf 3.0 beta would be awsome.

Thanks for the quick reply. I'll let you know.

Ok, the check was completed and the result is:

version 2.3.1 still has the problem on vertical scroll on iPad
version 3.0.0 beta solves the problem

Anyway, we're not confident in releasing a beta version on our production environment. What solution do you suggest? Is the solution I proposed a good solution? Alternatively, how much time is missing before version 3.0.0 will reach the stable channel?
Thank you

@verloox 3.0 is actually, as far as we're concerned, pretty stable. It's a complete rewrite of picturefill that fixes many long-standing issues, which is why it's in beta. It's been in alpha for a month-ish, and in beta for about a week without any issues (or at least any that came in are now fixed). In fact, the picturefill demo site is using 3.0 at the moment. If you're still concerned about the beta label, we'll probably keep it on for at least another week or two.
Thanks!

Hi,
we have 2 picture arts and ~40 img srcset tags on a page.  3.0.0 beta 1 scrolls smoother than version 2.3.1 but doesn't solve the problem of stottering during scrolling on iphones/pads. After an initially short hanging period it runs mostly smooth until i change the scroll direction  (top->down to down->up and vice versa).
A very short debugging showed, that in our case, the most responsnes get's lost in getWidthFromLength (iPhone 4s). It gets fired everytime i scroll. not so sure why.

@monsdroid
I just changed the code to deal with this problem. Basically it does the same thing that already was suggested by @verloox.
Could you please test whether this helps with your problem.

@monsdroid
I tried to fix this problem in the "ios_scrollbug-544" branch. It would be great if you could confirm that the code changes in this branch are fixing your problem.

@aFarkas it works really smooth now. thanks a lot!

It seems fixed now. Thank you.
Here's a comparison between picturefill 2, picturefill 3 beta, and picturefill 3 beta with the fix
The examples above also implements the lazy load technique.

We really want picturefill 3 to be released... how much time you think it will still take?
Thank you for all your work!


remove the references of private key and node url from config

Signed-off-by: Krasi Georgiev<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build 451111238

4 of 9 (44.44%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 35.908%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/ops/miningManager.go
0
1
0.0%

pkg/rpc/contractRPC.go
0
1
0.0%

pkg/config/config.go
3
6
50.0%

Totals

Change from base Build 451047511:
0.02%

Covered Lines:
1460

Relevant Lines:
4066

💛  - Coveralls


GestureDetector size problem with Stack overflow.visible

a Stack Widget have two children Widget A and B.
Widget B is bigger than Stack, so set Stack overflow.visible
then add GestureDetector to Widget B.
expect GestureDetector is same size width with Widget B,
but it is same with Stack size width
do i miss something?

Container(
      height: 160,
      color: Colors.black,
      child: Stack(
        children: <Widget>[
          SingleChildScrollView(
            scrollDirection: Axis.horizontal,
            child: Stack(
              children: [
                Row(children: items),
                Positioned(
                  top: 0,
                  left: 20,
                  child: Stack(
                    overflow: Overflow.visible,
                    children: <Widget>[
                      Container(
                        height: 160,
                        width: 20.0,
                        color: Colors.pink,
                      ),
                      Positioned(
                        left: 0.0,
                        bottom: 0.0,
                        child: Container(
                          width: 20.0,
                          height: 20.0,
                          color: Colors.purple,
                          child: GestureDetector(
                              onTapDown: (TapDownDetails details) {

                              print("onTapDown===========");
                            },

                          ),
                        )

                      )
                    ],
                  ),
                )
              ]
            ),
          ),
          Positioned(
            top: 0,
            left: 200.0,
            child: Container(
              height: 160,
              width: 1.0,
              color: Colors.green,
            ),
          )
        ],
      ),
    )

Hi @wasabia
Testing your code on Flutter 1.12.13+hotfix.8 doesn't seem to create GestureDetector same size as Stack size width
If you're still experiencing this issue, please create a new issue and provide the information required in the template.
Thank you


Activity dependency / Error Handling

Hi,
this is the only Page where I really have found anything regarding "Activity dependency" (Success, Competion, Skipped).
What is missing and I have not really found anything about it in the documentation at all is something about the fact,
that if I have a Pipeline where an Activity Fails, and then I have an "OnFailed" dependency with for example a "Log Step", then the Pipeline itself is in Success State!. IF I use this pipeline as a "SubPipeline" in a bigger Master Pipeline, then the Success Dependency will be fullfiled and dependend activities will run.
This is not very intuitive at all.
I think this should be noted somewhere - BIG!
In gerneral the documentation needs a section about Error Handling (we are in the cloud, errors happen, and not always just "retry" is the solution to it).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ab1bddf8-6515-3979-ffde-0bab66caa817
Version Independent ID: c1f105f2-3faa-3aca-7365-02ffeaae6d0a
Content: Pipelines and activities in Azure Data Factory
Content Source: articles/data-factory/concepts-pipelines-activities.md
Service: data-factory
GitHub Login: @sharonlo101
Microsoft Alias: shlo

@hmayer1980 Thanks for the feedback. We are actively investigating and will get back to you soon.

We have assigned the issue to the content author . They will evaluate & update the document as appropriate

Any Update on this?

Hi @hmayer1980,
Apologies for the delay in response! If you want to fail a pipeline, I would recommend have a Web Activity pointing at an invalid endpoint after your fail condition logic. I understand this is not properly documented and we have opened a work item to add this recommendation.
Hopefully this helps!
Thanks,
Daniel

Closing GH issue due to inactivity. Please reopen if this is still valid!

@hmayer1980 As mentioned by Daniel, If you want to fail a pipeline, I would recommend have a Web Activity pointing at an invalid endpoint after your fail condition logic.
I will close the issue now. Please feel free to still comment if you have any queries on the same.


doc: Add a first pass contributing doc

Fixes #14
This is just a first pass at a contributing doc. It's based on ones from a few projects I've built in the past. It should cover pretty much everything... or at least be a good start.

Note to self: I need to add mention in here that we require commits to be signed.


[addons: a11y (and others)] - Cannot read property '__STORYBOOK_ADDONS' of undefined

Describe the bug
When I run yarn dev, after pulling down the project, running yarn install and yarn bootstrap --reset --core, I get errors stating:

Could not find a declaration file for module 'telejson' (shows up on other addons)
Could not find a declaration file for module 'react-inspector' (shows up on other addons)
Property 'warn' does not exist on type 'typeof import(".../lib/client-logger/dist/index")

When I try to fix those by correctly importing warn and adding the types to the typings, I get this error when yarn linking to another project:
Cannot read property '__STORYBOOK_ADDONS' of undefined at getAddonsStore (index.ts:97) at Object.../storybook/lib/addons/dist/index.ts
After that error comes up, none of the components are listed in the side panel nor are they rendered in the iframe. I can't do any local development on Storybook until this is resolved.
To Reproduce
Steps to reproduce the behavior:

Pull down a brand new copy of the project
Run yarn install
run yarn bootstrap --reset --core
run yarn dev
see errors

Expected behavior
Errors shouldn't appear during yarn dev run, and if resolved, I should be able to link an addon to another project and see the components being rendered as usual.
Screenshots

System:

OS: [MacOS]
Device: [Macbook Pro 2018]
Browser: [chrome, firefox]
Framework used in external project using link to local: [Angular]
Version: [NEXT - first seen as of local merge on 3-20 (but hadn't merged in since 3-15 when working on a feature). Continuing to see as of 3-22-19]
External project using the yarn link is using version: 5.1.0-alpha.12

@ndelangen @shilman could this have to do with the API changes that went in?

Why is lib/addons/dist/index.ts being loaded instead of lib/addons/dist.index.js
I think this is part of the problem.

I am not quite sure and I'm trying to figure out where to start with this one. Fixing the errors in the addon didnt solve the issue. Im using 5.1.0-alpha.12 in the external project and linking in the next version of storybook. Has an important change with the way addons work not been released that could be in next as of 3-15-19?
What I've shown is a clean slate project so it should be able to be replicated. Many other addons are having similar issues locally. Is anyone else able to see this issue when pulling down and running the commands?

@shilman, still not sure what is causing this problem but I am able to continue development without linking using the cra-kitchen-sink. I should be good for now.

@CodeByAlex I suggest using official-storybook since it uses the --no-dll flag and therefore works with yarn dev.


Investigate esbuild/swc jest integration

https://github.com/aelbore/esbuild-jest (first google result, mayhaps/likely/probably others)

Seems like @swc/jest is better for this repo, due to the use of TypeScript "legacy" decorators along with metadata


Dev.jer.subpage

##What do this PR do?
• It update the index.html and partial about us and contact form.
How would you text this PR?
• pull down the brand
• visite the site in browser
##Screenshot
I included a screenshot, this should be seeing from my main branch to your branch.

Updated index and other pages


Drop extract from web assets

Hello!
From 28 june web assets delete extract.
It will work in the brackets?

http://blogs.adobe.com/creativecloud/update-for-extract-in-creative-cloud-assets-and-brackets/

Is there around any free alternative?

Closing since Extract is deprecated.
I think Dreamweaver has / will have this feature.


Learner Addition

Enter Details Below !
Github Username :- WebShivam
Your Name :- Shivam Dubey
Thanks !!!

Great !! Please come up with a Pr with suggested changes !!


Add Nucleus BVBA (shared hosting provider) with PHP 7 support

Merged into master! Sorry, I just switched from using plain GitHub Pages to deploying via CircleCI in master. Thank you :D

Cool, much appreciated @philsturgeon !


[SPARK-15075][SPARK-15345][SQL] Clean up SparkSession builder and propagate config options to existing sessions if specified

What changes were proposed in this pull request?
Currently SparkSession.Builder use SQLContext.getOrCreate. It should probably the the other way around, i.e. all the core logic goes in SparkSession, and SQLContext just calls that. This patch does that.
This patch also makes sure config options specified in the builder are propagated to the existing (and of course the new) SparkSession.
How was this patch tested?
Updated tests to reflect the change, and also introduced a new SparkSessionBuilderSuite that should cover all the branches.

Note that I still need to add some tests to cover the behavior of the new builders.

Test build #58899 has started for PR 13200 at commit b351024.

Test build #58899 has finished for PR 13200 at commit b351024.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58899/
Test FAILed.

Test build #58907 has started for PR 13200 at commit 55ef850.

Test build #58907 has finished for PR 13200 at commit 55ef850.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58907/
Test FAILed.

Test build #58911 has started for PR 13200 at commit c665771.

Test build #58913 has started for PR 13200 at commit 526896f.

cc @andrewor14 too who wrote some of this

Test build #58911 has finished for PR 13200 at commit c665771.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58911/
Test FAILed.

Test build #58918 has started for PR 13200 at commit af481d6.

Test build #58919 has started for PR 13200 at commit 918b47b.

OK I've pushed a commit to handle sql listener properly.

Test build #58921 has started for PR 13200 at commit c475453.

Test build #58913 has finished for PR 13200 at commit 526896f.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58913/
Test FAILed.

We should fix session.py to use the new scala thing as well. Also tests are failing because python is still trying to call wrapped.

That's been updated?

Ah, yes.

but not the builder, which still uses SQLContext.getOrCreate: https://github.com/rxin/spark/blob/c475453c59e6f795ea9283271fe83b35ef71bee6/python/pyspark/sql/session.py#L147

Test build #58918 has finished for PR 13200 at commit af481d6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58918/
Test PASSed.

Test build #58919 has finished for PR 13200 at commit 918b47b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58919/
Test PASSed.

Test build #58931 has started for PR 13200 at commit 4173a72.

I updated Python docs. The Python change seems slightly larger and since it is not user facing, I'm going to defer it to another pr.

Test build #58921 has finished for PR 13200 at commit c475453.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58921/
Test PASSed.

Test build #58931 has finished for PR 13200 at commit 4173a72.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58931/
Test PASSed.

Test build #58939 has started for PR 13200 at commit e4a4bc1.

@marmbrus i know you were looking at this. Did you end up going through it?

LGTM

Thanks - merging in master/2.0.

Test build #58939 has finished for PR 13200 at commit e4a4bc1.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class ConsoleSink(options: Map[String, String]) extends Sink with Logging
class ConsoleSinkProvider extends StreamSinkProvider with DataSourceRegister

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58939/
Test PASSed.


Updated Azure Service Bus Authorization Script

Authorization script used invalid PS cmdlets which have been replaced by working ones like, Get-AzureRmServiceBusAuthorizationRule, etc.

@punitganshani : Thanks for your contribution! The author, @sethmanheim, has been notified to review your proposed change.

@punitganshani Thank you for catching those errors! We will get this merged right away. #sign-off


webpack-bundle runs infinitely long

$ ./gradlew build
Starting a Gradle Daemon (subsequent builds will be faster)
<==========---> 78% EXECUTING [94h 23m 48s]
> :frontend:webpack-bundle

Should I wait a little bit more? =)

Error due to outdated devDependency see #39
Just update the dependency manually in frontend/gradle.build and run the again to resolve the issue.

Changing devDependency to devDependency("@babel/core") doesn't help. The build of the frontend module is still hanging.


Add release notes to 0.8.0

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.78%. Comparing base (f1fddd0) to head (7ea6c87).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #387   +/-   ##
========================================
  Coverage    89.78%   89.78%
========================================
  Files          120      120
  Lines         7653     7653
  Branches       675      675
========================================
  Hits          6871     6871
  Misses         651      651
  Partials       131      131

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Use interface types when checking #keyPath.

This avoids a crash when the path refers to a property in another Swift module.
SR-3714

@swift-ci Please test

@slavapestov, is there a good way to find out if we have more of these mistakes?

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 2318d79771ed70e9b9577818ea5673a9c709972c
Test requested by - @jrose-apple

@swift-ci Please test

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 2318d79771ed70e9b9577818ea5673a9c709972c
Test requested by - @jrose-apple

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 2318d79771ed70e9b9577818ea5673a9c709972c
Test requested by - @jrose-apple

Take away VarDecl::getType() ;)

(this LGTM, by the way)

This failed on a mangling test that (IIRC) is failing elsewhere; unfortunately the bots are now being upgraded.

@jrose-apple Add assert(getDeclContext()->isLocalContext()) would shake out cases where we call getType() on a property of a type, but only test the case where the property is defined in the same module.
Or as Doug said, scrap this whole thing altogether, maybe add a LocalVarDecl subclass of VarDecl and move getType() there.

@swift-ci Please test macOS

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - a06bc15286e23311c383b3c53108c82331c5b377
Test requested by - @jrose-apple

Jenkins Java error, but the testing did actually finish, as evidenced by the smoke test label being fine. Merging.


Fix jwt verifier

Initializes grpc correctly in the JWT utils.
Make the email mapping work with the new service accounts produced by Google IAM.

@yang-g can we merge these changes now? thanks!

jenkins Test this please

@yang-g I fixed the failing tests. The failing gRPC_interop_pull_request is unrelated.

Test failures:
#9099
#8989

Could you squash the commits?


Fix github workflow to only run release step for odpf:main branch

We should run linter on all commits and pull requests and release only from odpf:main branch.
As of now any pull request from main branch of the user will have the release step triggered.

Fixed in #115


Added marings and paddings

#3

2 tests are failed, but css optimization in tailwind should delete unused styles itself


Improve Operator metrics Dashboard

remove labels from y-axis
reorder graphs
actualize clickhouse.tech links
add chi_clickhouse_metric_fetch_errors single stat
add clickhouse-process total memory stats

Signed-off-by: Eugene Klimov<EMAIL_ADDRESS>

correspond with https://github.com/Altinity/clickhouse-operator/pull/396


Get all objects which share the same tag

Hi there,
Been through the docs and searched online but I can't find a solution to what I thought would be quite a common use case...
Regardless of object type I want to retrieve a list or queryset of all objects which share the same tag.
Does anyone have a quick, clean solution for this? Thanks,

+1


Cant run test suite

Cannot run test suite, readme says it's just rake test but this is what i get (after bundle update of course)
user@user-pc:~/find_as_hashes$ rake test
/home/user/.rvm/rubies/ruby-2.2.1/bin/ruby -I"lib:lib:test"  "/home/user/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/rake/rake_test_loader.rb" "test/active_resource_test.rb" "test/find_as_hashes_test.rb"
/home/user/.rvm/gems/ruby-2.2.1/gems/activesupport-4.0.13/lib/active_support/dependencies.rb:229:in `require': cannot load such file -- test/unit (LoadError)
        from /home/user/.rvm/gems/ruby-2.2.1/gems/activesupport-4.0.13/lib/active_support/dependencies.rb:229:in `block in require'
        from /home/user/.rvm/gems/ruby-2.2.1/gems/activesupport-4.0.13/lib/active_support/dependencies.rb:214:in `load_dependency'
        from /home/user/.rvm/gems/ruby-2.2.1/gems/activesupport-4.0.13/lib/active_support/dependencies.rb:229:in `require'
        from /home/user/find_as_hashes/test/test_helper.rb:2:in `<top (required)>'
        from /home/user/find_as_hashes/test/active_resource_test.rb:1:in `require'
        from /home/user/find_as_hashes/test/active_resource_test.rb:1:in `<top (required)>'
        from /home/user/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/rake/rake_test_loader.rb:15:in `require'
        from /home/user/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/rake/rake_test_loader.rb:15:in `block in <main>'
        from /home/user/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/rake/rake_test_loader.rb:4:in `select'
        from /home/user/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/rake/rake_test_loader.rb:4:in `<main>'
rake aborted!
Command failed with status (1): [ruby -I"lib:lib:test"  "/home/user/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/rake/rake_test_loader.rb" "test/active_resource_test.rb" "test/find_as_hashes_test.rb" ]
/home/user/.rvm/gems/ruby-2.2.1/bin/ruby_executable_hooks:15:in `eval'
/home/user/.rvm/gems/ruby-2.2.1/bin/ruby_executable_hooks:15:in `<main>'
Tasks: TOP => test
(See full trace by running task with --trace)

@Fedcomp if you pull latest master you should be good again. Thanks for posting!


Minor fixes

Bump Spring Boot to 2.0
Renaming to a more event-esque style

Changes included in #21


Add test scripts

This adds mainly:

a script (test.sh) that traverses all the tools, executes their CWL description with the provided input.yml, and reports test results.
a github actions workflow to execute the tests

The tests are failing as expected, as the sage config.json is not available on main yet.


Set preference second time shows incorrect message

$ odo preference set Timeout 20
Global preference was successfully updated.

$ odo preference set Timeout 30
? %v is already set. Do you want to override it in the config Yes
Global preference was successfully updated.

Note the value of the message after the second run. ? %v is already set

/kind bug
/priority high

/assign dharmit

/assign dharmit


AES256 Encryption

Created AES encryption/decryption functions and removed XOR in both the python and powershell versions. Encryption was moved from the plugins back to det.py so the raw files are encrypted first. This prevents payloads from having to be a multiple of a block length, conflicts with very small payload sizes and reducing the impact of payload size randomization.

Hey there,
First of all, thanks a lot for your pull request(s).
I checked the AES implementation and that works perfectly, kudos!
However, only the payload is encrypted and the rest of the data can be retrieved easily by base64 decoding the packet.
What would you think, instead, about encrypting the entire data and transmitting it? Keen to discuss about this.
Cheers!

Well, my first thought was to do a second encryption operation for the header, but for the register packet, which is pretty long already, the filename field is arbitrary which makes separating the two sections difficult. Ultimately the objective was to preserve the capability of packet length randomization, but if you don't mind all packets being a multiple of 16 bytes, I could move the encryption to the send/receive functions. Otherwise some design changes are in order for the headers.

I see, that makes sense now :+1:


Nova 4 support

Support for this within Nova 4 would be great.

I am waiting for the good news too

Hi! We've decided to not migrate Nova Media Field to Nova 4. Instead, I developed a new package called Nova Media Hub which serves as a replacement and should be an improvement over the existing package.


Update index.mdx

.astro

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

es
tutorial/2-pages/index.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


[4pt] Implement startup actions - Task4 - [TM#1]

The following options should be available:

List all music albums
List all genres (e.g 'Comedy', 'Thriller')
Add a music album

#35


add toolbox command

Add a command to run commands in the Rook toolbox.
kubectl rook-ceph toolbox <any command with args> should run <any command with args> in the toolbox.

If the toolbox is running, the command should run it in the toolbox.
If the toolbox is not running, I think we should run a toolbox job for the command.

It might be a separate issue, but I think it would also be useful to have a command to connect interactively to the toolbox to run commands. I (and most users) like tab-completion. IMO, running kubectl rook-ceph toolbox could connect a user to the toolbox interactively. Accomplishing this with a toolbox job would challenging, but I think we can figure out how to do it.

So, what you are suggesting is if the toolbox pod is running then we should prefer running the ceph command in the toolbox. right?
I'll suggest not adding one more sub-command toolbox we can have if condition if the toolbox present run command on toolbox.

@BlaineEXE ^^


JSON representation of matchingRules in Specification V3

I ran the tests of the pact-jvm-consumer-junit project and the created pact json files contain matchers described as this:
"matchingRules": {
  "$.headers.Location": {
    "regex": "http(s)?://\\w+:\\d+//some-service/user/\\w{36}$"
  }

with pact-specification version 3.0.0
According to https://github.com/pact-foundation/pact-specification/tree/version-3 the usage of JsonPath notation was dropped for matcher keys in Version 3. Is there a reason pact-jvm still uses V2 to store the matchers in the pact-file?

The change to matching rules was introduced in 3.5.0-beta.2. The 3.3.x versions only support the message pacts from V3.


Update dependencies in composer.json if possible

Found out that i can use

Nextras\Dbal\Bridges\NetteTracy\ConnectionPanel
Nextras\Dbal\Bridges\NetteTracy\BluescreenQueryPanel

Closing


Check formatting (gofmt) during CI.

We have seen a few PRs wheregofmt wasn't run on changed/added code. This PR extends the Makefile by a check-format command that fails if there are any unformatted files, and includes the command during Travis CI runs.

@gambol99 could you please have a look at let me know if this makes sense to you? My makefile-fu isn't very strong, so feel free to suggest improvements wildly. :-)
Note that all but the first commit are just to demonstrate how Travis builds look like if check-format succeeds/failed. They will be dropped from the final PR prior to merging.

LGTM


Help-me error to download funimation

Any help?
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-u', 'PRIVATE', '-p', 'PRIVATE', '-f', 'best', '--cookies', 'cookies.txt', 'https://www.funimation.com/shows/the-promised-neverland/121045/Simulcast/?lang=english', '--verbose']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2021.04.26
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.19041
[debug] exe versions: ffmpeg 2021-04-25-git-d98884be41-full_build-www.gyan.dev, ffprobe 2021-04-25-git-d98884be41-full_build-www.gyan.dev
[Funimation] Logging in
[Funimation] 121045: Downloading webpage
WARNING: [Funimation] 121045: Failed to parse JSON Expecting value: line 1 column 1 (char 0)
ERROR: Unable to extract al:web:url; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpeav8wi2f\build\youtube_dl\YoutubeDL.py", line 806, in wrapper
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpeav8wi2f\build\youtube_dl\YoutubeDL.py", line 827, in __extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpeav8wi2f\build\youtube_dl\extractor\common.py", line 534, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpeav8wi2f\build\youtube_dl\extractor\funimation.py", line 100, in _real_extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpeav8wi2f\build\youtube_dl\extractor\common.py", line 1142, in _html_search_meta
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpeav8wi2f\build\youtube_dl\extractor\common.py", line 1021, in _html_search_regex
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpeav8wi2f\build\youtube_dl\extractor\common.py", line 1012, in _search_regex
youtube_dl.utils.RegexNotFoundError: Unable to extract al:web:url; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

#28879

Thanks bro, do you know how to solve?

It'll be solved when the extractor is updated. I'm nowhere near good enough to fix the problem entirely but I'm working on a temporary solution.

Okay, thanks for ur help


[match] fix for match username not found if readonly

Fixes #15072
^ https://github.com/fastlane/fastlane/pull/15023#issuecomment-514211867
Motivation and Context
Don't read username if not needed
Description
username is a required option for match. This means that once that params[:username] is read that it will force the user to enter (or error if in CI mode).

This line was added in 2.128.0 as a way to move logic into the storage providers. - https://github.com/fastlane/fastlane/blob/master/match/lib/match/runner.rb#L46
There was an oversight where params[:username] should only get read if readonly is false (see following examples)

https://github.com/fastlane/fastlane/blob/master/match/lib/match/runner.rb#L60
https://github.com/fastlane/fastlane/blob/master/match/lib/match/runner.rb#L79
https://github.com/fastlane/fastlane/blob/master/match/lib/match/runner.rb#L85

The above examples were not implemented in a way that made this super apparent
Additionally, :username most likely won't be nil a lot of a dev machine because the following dynamic default happening in the match options

https://github.com/fastlane/fastlane/blob/master/match/lib/match/options.rb#L14-L15
https://github.com/fastlane/fastlane/blob/master/match/lib/match/options.rb#L51

So the reason this happened in a CI was because of readonly: true and the dynamic default being nil.
So... this fix will only set call and pass the :username if reaonly: false because that is the only time that :username is needed

Can you explain what is going on here? I don't get it.

Note: This PR should also rework the logic a bit to make this safer overall and should add tests but will create another issue for that

Hello,
All our match calls already use readonly: true and I was surprised to see
[23:35:35]: No value found for 'username'

Are we sure this change is working as expected?

Please open a new issue with all the information included - because if you are seeing an unexpected error message we obviously are not sure that everything is working as it should.


Double click to open file in "Recent Item" instead of one time click

I don't know this is a bug or a feature request, but, I think it's better to open a file in the "Recent Items"  section of "Home" by double click it instead of a one-time-click. To open a file in another folder, it requires a double click but IDK why a one-time click can open a file in the "Recent Items" section, which is very annoying when users tend to right-click it instead of opening it (by clicking it once to select, then right-click).

I agree it should respect the "Open items with one click" option

Merging with #2994.


Need to Style APA citation for proper indent

I usually do this:
.apa {
padding-left: 22px ;
text-indent: -22px ;
}
Didn't want to do inline styling  (cool with it if you are) but didn't see a stylesheet so made issue rather than filing PR.

I wanted to keep it easy to copy the HTML snippet by itself, which is why I am also using inline styling for setting (and unsetting) some of the italics.
So I’m leaning towards using inline styling. Unless you see a use-case that means we can’t do that?


Editor hotkeys found so far

The following information might be the product of multiple plugins used from https://github.com/rxi/lite-plugins.
The test took place under an ANSI C demo code.
So far I have detected the following hotkeys, in case you are interested:

Ctrl+L highlights the whole line
Ctrl+\ hides the sidebar
Ctrl+D highlights the word under cursor and shows with highlighted border around multiple findings of that word
Ctrl+P it opens a file from a project
Ctrl+Shift+P runs a command
Ctrl+Shift-D duplicates a line
Ctrl+Shift+K deletes line under cursor
Shift+RightArrow highlights character by character and behaves much like Ctrl-D
Ctrl+O Opens a file
Ctrl+F Find Text (in current opened file)
Ctrl+Shift+F Find text in entire Project
Ctrl+R Finds something and replaces it
Ctrl+J This is a very interesting command: it deletes the newline from the end of a line; in other words, you have 3 lines, you place your cursor anywhere in your first line and press the hotkey twice. Now you have a single line.
Ctrl+G Go to line
Ctrl+S Save file
Ctrl+Shift+S Save as
Ctrl+A Select all text
Ctrl+[ and Ctrl+] jumps from code block to code block? :shrug:
Ctrl+Shift+[ and Ctrl+Shift+] highlights 3-ish lines forward and backward, respectively
Ctrl+' Converts all your text to a single, minified line with escaped characters and newlines
Ctrl+/ comments the current line; to select multiple lines, press Ctrl+Shift and your arrows to select the lines you want, then the aforementioned command.
Ctrl+Arrows Moves the line up or down
Ctrl+Shift+Q it adds a number sign, a hashtag, a pound sign..?, name it however you like, and makes a code block as a single line; weird behavior
Alt+Shift+L clones the current screen on your right, vertically while maintaining curret's position on the cloned file; press Ctrl+W to close it
Alt+Shift+K clones the current screen on the bottom, horizontally while maintaining curret's position on the cloned file; press Ctrl+W to close it
Alt+Shift+J clones the current screen on your right, vertically while maintaining curret's position on the opened file; press Ctrl+W to close it

Update: seems like mouse's middle key (scroll) closes tab windows as well.

To arrange your tabs, use Ctrl+PageUp and Ctrl+PageDown.

@stefanos82
You can find some more here https://github.com/rxi/lite/blob/master/data/core/keymap.lua

lol @dnlo you so right :facepalm: how come I thought it was part of the C code instead of of Lua?
Thanks a million mate :100:

Does this text editor have the shortcut key to use multiple cursor at once? Like in VScode, ctrl+d or f2?

Does this text editor have the shortcut key to use multiple cursor at once

Lite XL supports multi-cursor as of 2.0.0


Navigation: Standardize Confirmation page nav bar

Description
The confirmation page has two sets of navigational buttons: items in the navigation bar and items on the web page. Updates need to be made for both.
Navigation bar

Webpage Buttons

Definition of Done
Navigation Bar Tasks

[ ] Remove About link
[ ] Rename Share to Share Experiences.
[ ] Rename View to View Experiences.
[ ] Rename MyPage to My Stories.
[ ] Clicking View Experiences directs user to experiences_page.html
[ ] Clicking My Stories directs user to my_stories.html
[ ] Add Moderate Experiences button
[ ] Clicking Moderate Experiences directs user to moderate_public_experiences.html
[ ] Add Home button
[ ] Clicking Home directs user to the Home page

This is landing.html not overview.html

[ ] Clicking Logout logs out user.
[ ] Clicking Logout directs user to Home page.

This is home.html or landing.html not overview.html

[ ] Reorder Navigation bar items.

From left to right, Home - View Experiences - Moderate Experiences - Share Experiences - My Stories - Logout

Webpage Button Tasks

[ ] Rename Go to My Experience page to Go to My Stories
[ ] Clicking Find out more about AutSPACEs directs user to Home page.

This is home.html or landing.html not overview.html

@lottycoupat I can take this up.

@mridubhatnagar fabulous!!

PR is complete. Closing.


localization - injecting filtered data back to the create3

Hi,
I want to add localization abilities to my create3, but I want the robot to use the data which I calculate instead of only using the odometer and the imu installed on the robot.
Is there a way to inject processed data back into the robot so it thinks that it is where I tell it instead of using only it's own localization process?
Thanks a lot for your help,
Ariel
p.s. not sure where this question is supposed to go, I apologize if it's in the wrong place.

Hi there -- "issues" are for problems with the a repository. Questions about using the robot should go in the discussions forum here.


Record original source range of generated source buffers into dumped files

This helps us establish where the code from a generated source buffer would go, for external tools that don't understand serialized diagnostics.

@swift-ci please smoke test


Replace unmaintained smallstr with compact_str

The smallstr crate appears to be largely unmaintained (and its author is mostly inactive). Considering it's a potential vulnerability, we can practically drop-in replace it with compact_str. compact_str stores up to 24 bytes on the stack.
I also updated the struct_size test to reflect the new size and fixed most clippy warnings.
Let me know if there's anything else you'd like me to do :)

Looks great - thank you!


Board Review: Azure.ResourceManager.Compute

Thank you for submitting this review request. Thorough review of your client library ensures that your APIs are consistent with the guidelines and the consumers of your client library have a consistently good experience when using Azure.
The Architecture Board reviews Track 2 libraries only. If your library does not meet this requirement, please reach out to Architecture Board before creating the issue.
Please reference our review process guidelines to understand what is being asked for in the issue template.
To ensure consistency, all Tier-1 languages (C#, TypeScript, Java, Python) will generally be reviewed together.  In expansive libraries, we will pair dynamic languages (Python, TypeScript) together, and strongly typed languages (C#, Java) together in separate meetings.
For Tier-2 languages (C, C++, Go, Android, iOS), the review will be on an as-needed basis.
Before submitting, ensure you adjust the title of the issue appropriately.
Note that the required material must be included before a meeting can be scheduled.
Contacts and Timeline

Responsible service team: .Net management SDK team
Main contacts: @ArcturusZhang @m-nash
Expected code complete date: 07/28/2021
Expected release date: 07/30/2021

About the Service

Link to documentation introducing/describing the service: https://github.com/Azure/azure-sdk-for-net/blob/feature/mgmt-track2-compute-2/sdk/compute/Azure.ResourceManager.Compute/README.md
Link to the service REST APIs:

https://github.com/Azure/azure-rest-api-specs/tree/master/specification/compute/resource-manager/Microsoft.Compute/stable/2021-03-01
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/compute/resource-manager/Microsoft.Compute/stable/2020-12-01/disk.json
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/compute/resource-manager/Microsoft.Compute/stable/2020-09-30/gallery.json
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/compute/resource-manager/Microsoft.Compute/stable/2020-09-30/sharedGallery.json

Link to GitHub issue for previous review sessions, if applicable:

About the client library

Name of the client library: Azure.ResourceManager.Compute
Languages for this review: .Net

Artifacts required (per language)
Please read through “API Review” section here to understand how these artifacts are generated. It is critical that these artifacts are present and are in the right format. If not, the language architects cannot review them with the SDK Team’s API review tool.
.NET

APIView Link: https://apiview.dev/Assemblies/Review/d76d25f493c04772af95076103dca4dc
Link to Champion Scenarios/Quickstart samples: https://github.com/ArcturusZhang/azure-samples-net-management/blob/compute-sample-update-for-new-track2/samples/compute/create-virtual-machine

For all other languages, send a request to the Architecture Board to discuss the best format on individual basis.
Thank you!

scheduled for 8/2 4-6pm pst

Recording[MS INTERNAL ONLY]


packageNameCompletion() does not work

Looking at the source, trying to find something that would just list all the available package names, I found the below function:
/// Returns a List<String> of all packages listed on pub.dev
Future<List> packageNameCompletion() async
Unfortunately, that does not appear to work, but causes an unhandled exception:
Unhandled exception:

#0      responseValidOrThrow (package:pub_api_client/src/helpers/exceptions.dart:55:7)
#1      PubClient._fetch (package:pub_api_client/src/pub_api_client_base.dart:54:5)

#2      PubClient.packageNameCompletion (package:pub_api_client/src/pub_api_client_base.dart:126:18)

My mistake.  The pubUrl I provided to PubClient() had a typo.


i need help

i need help bridging the bot to irc can someone go in depth into helping me?

The README should explain everything you need. Do you need help with anything specific?


Web map "Climate - Relative Humidity" references services that do not exist

Web map "Climate - Relative Humidity" (id: e7dc436afcf64a32893a69377edbbd6a) references the following services that do not exist:
https://nsec.esri.com/ags/rest/services/Test/Climate/MapServer

Deleted.


Refactor react-native-client-sdk

merge connect and joinRoom functions
merge leaveRoom and cleanUp functions
remove endpoints from public api (I left it in internal code, we'll think about them once we add components into mobile sdk)

Can you verify that main readme is up to date with your changes?

README was way out of date even before this PR, I updated some of it.


Interrupt Service Routine

I need guidance regarding ISR. we have multiple devices in an SoC, and only a single wire indicates the core about external interrupts. so how do we get to know that which device interrupted the core and how we will deal that. for example i wanted to read a value from a GPIO so, what will be the flow of reading the value from GPIO in terms of ISR.

The ISR will need to go through the plic to figure out which module sent the interrupt, and then from there jump to an appropriate routine.
Please see the interface code written for the plic here

The ISR will need to go through the plic to figure out which module sent the interrupt, and then from there jump to an appropriate routine.
Please see the interface code written for the plic here


Discussion: Where to relocate package tests?

Currently, all dmod subpackages share a test subpackage. Meaning, all the tests from each dmod subpackage are collected and collated into a single directory. I am not intimately familiar with all of our testing suite, so I am likely wrong, but I would speculate this is so that common testing functionality can more easily be shared.
"installed" (site-packages) subpackage layout is as follows:
dmod
├── access
├── ...
├── subsetservice
└── test

Consequently, this means that it is possible for test files to be overwritten by another subpackage during installation if they share the same name. This is because in our source tree, each subpackage looks similar to this:
dmod
├── access
│   ├── __init__.py
│   └── ...
└── test
    ├── __init__.py
    └── test_some_cool_thing.py

This is not super likely, however, this also means that the last installed subpackage's test/__init__.py file will overwrite any prior installed versions. One way, as a team, we've talked about getting around this, is to keep all test/__init__.py files empty. I think that is sane and an easy fix, however I tend to think we can do better.
Aside from the aforementioned name mangeling issue, it would be nice to more easily run individual test files or individual tests. Due to our frequent usage of relative imports in tests and python's import semantics, running individual tests is doable, but often requires some manual intervention (adjusting imports, removing __init__.py). Likewise, it would be nice if popular IDE test runner plugins "just worked" out-of-the-box.
So, as a segue, here are my wants (please add yours as well):

ability to run tests at the package, file, and test scopes
ability to use tests in edit mode
shareable and reusable testing suite
straight forward IDE support

With the above friction-points and wants in mind, the first thing that I think we should discuss and decide is, do we move tests? and if so, where too? If the answer is yes, I think there are two straightforward and logical options. 1) for each subpackage, we move it's test files inside the subpackage as a new subsubpackage (i.e. dmod.access.test) or 2) we move each subpackage's tests outside of installed source scope up one level so they sit next to a subpackage's setup.py and README.md. Both of these locations have a similar drawback. Without a testing framework or library, code reusable is a bit more challenging (back to that in a minute). However, the main difference is, do you ship tests with installed code or not? (that's what we are doing now) Given that this project is heavily application specific, I lean in the direction of shipping tests with the code. This in the future would allow us to run our test suite on some target whenever we would like. Now, given our use of containerization, I can already hear the pushback, but I think given python being the language, I could foresee running tests on a machine during a debugging procedure for example.
Once we've addressed the previous concern, I think the use of a testing framework like pytest could easily remedy the reusability want. pytest has an extensive plugin environment and makes it trivial to share your own plugins or fixtures across a codebase. And yes, all of our current tests will just work. It's super easy to use and I think makes writing tests more enjoyable and a lot faster (check out pytest.parametrize). Likewise, as you would expect, it provides easy pathways for setting up the testing environment at different scopes (e.g. a module of tests need self-signed SSL certs).
If it's not become clear, I am a huge fan and advocate of pytest. It's used internally in hydrotools, hypy, and ngen-cal and externally in codebases like numpy, pandas, and sklearn.

The overwriting scenario has already been encountered. If you're using an IDE like PyCharm, moving files within the test directory will create new __init__.py files as necessary in order to maintain package/subpackage structure. Have a bajillion unit tests for a library and want to reorganize? Moving those files from within the IDE will create a new __init__.py and override the __init__.py that's needed in order to link some tests to their helper classes. The easiest solution under this model is to further nest the tests, ending up with something like:
dmod
├── access
│   ├── __init__.py
│   └── ...
└── test
    └── access
        ├── __init__.py
        └── test_some_cool_thing.py

Works, but kinda ugly. Your relative imports there become ugly too because you're not doing something like from ..access import whatever, you're doing from ...access import whatever and it just escalates from there.
Some of this may be cleaned up by flattening the source tree. The current structure does not match what gets install in your virtual environment, resulting in some weird bugs from time to time (like the overriding issue).
What I'd like to see is something like:
DMOD
├── dmod
|    ├── __init__.py
|    ├── access
|    |   ├── __init__.py
|    |   └── ...
|    ├── requestservice
|    |   ├── __init__.py
|    |   └── ...
|    └── ...
|       ├── __init__.py
|       └── ...
├── test
|   ├── __init__.py
|   ├── access
|   |  ├── __init__.py
|   |  └── test_some_cool_thing.py
|   ├── requestservice
|   |   ├── __init__.py
|   |   └── ...
|   └── ...
|       ├── __init__.py
|       └── ...
├── setup.py
└── test_dmod.py

test_dmod.py can be the access point for tests (to ensure paths can work) and the working directory for nested tests can be set to the root of the project when running individual tests. Unless there's some hocus pocus I'm not aware of, you can't really do direct test runs at the moment since you'll run into fun errors due python not being able to climb up higher than the calling directory when running them, but directing the tests to work like that prevents them from working when running the tests on installed directories. Format it like this and you should be able to avoid some pathing headaches. I think this might also render ./scripts/update_package.sh unnecessary since you'll no longer need to install dependent subpackages in order to reference them by name.
Also, setup.py and such should probably ensure that the tests don't end up in the finished product. That's currently the case and that means that required testing input files end up in the virtual environment.

Currently, all dmod subpackages share a test subpackage ... I would speculate this is so that common testing functionality can more easily be shared.

Not exactly.  The idea was to have identical structure for clarity, but the intent was also to avoid installing the dmod.test namespace package.  That's the purpose of the exclude usage in the lines like this in most all (if not all) package setup.py files (it's just that it was done incorrectly and never fixed):
packages=find_namespace_packages(exclude=('tests',` 'schemas', 'ssl', 'src'))

Putting common testing functionality somewhere does sound like a good idea, but it should all be in one place and somewhere else.

This is not super likely, however, this also means that the last installed subpackage's test/init.py file will overwrite any prior installed versions.

I don't think we really want to ever install tests; we just need to fix the bug(s) that does that.   Testing should occur before a package is installed.  This is why the tests modules for a given package use relative imports for things in that package:  they assume the things they are intended to test are not yet installed.
We can discuss whether tests should actually be installed more if needed; if so, I would recommend we settle that first.

Thanks for the input, @christophertubbs! I am not going to paste your above file structure layout, but this is exactly what I was thinking as another option if we don't want to move tests inside of subpackages. Thanks for making it more clear.

Unless there's some hocus pocus I'm not aware of, you can't really do direct test runs at the moment since you'll run into fun errors due python not being able to climb up higher than the calling directory when running them, but directing the tests to work like that prevents them from working when running the tests on installed directories. Format it like this and you should be able to avoid some pathing headaches.

Yeah, you have to do a little hocus pocus. Ive been getting around this by changing relative imports in tests to absolute imports and removing __init__.py from a subpackage's test/ ~subpackage~. Then using pytest to run the tests (i.e. pytest test_some_cool_feature.py).

I think this might also render ./scripts/update_package.sh unnecessary since you'll no longer need to install dependent subpackages in order to reference them by name.

I agree. I don't think we will need a separate script either, we should be able to run pytest from the root of the project and it will discover and run all the tests for us.

Aside from the aforementioned name mangeling issue, it would be nice to more easily run individual test files or individual tests.

The scripts/test_package.sh script does have some capabilities for isolating the tests to run more specifically than just package/directory.  We can expand that further if there are useful scenarios it doesn't support yet.  I probably didn't add something like that already because I just ran the tests through Intellij in those situations, which segues into ...

Due to our frequent usage of relative imports in tests and python's import semantics, running individual tests is doable, but often requires some manual intervention (adjusting imports, removing init.py). Likewise, it would be nice if popular IDE test runner plugins "just worked" out-of-the-box.

With perhaps 2 or 3 exceptions, I have not had trouble running tests as-is via Intellij, either by test class (that isn't exactly the same as by file, but I wonder if that's the use-case you are really interested in) or by individual test function.  I do remember a couple times when a test function encountered a strange error when run through the IDE, but passed just fine when run through scripts/test_package.sh.
There is probably an underlying issue somewhere (or perhaps a few) that needs to be addressed and/or improved, but in principle, what you suggest is essentially already possible.  Other IDEs may behave differently, but I would expect it to be fairly easy to get them to work (now we're getting into exactly what you meant by "'just worked' out-of-the-box").   Regardless, I am curious what problems you have encountered that prompted this.

The scripts/test_package.sh script does have some capabilities for isolating the tests to run more specifically than just package/directory.

With perhaps 2 or 3 exceptions, I have not had trouble running tests as-is via Intellij, either by test class (that isn't exactly the same as by file, but I wonder if that's the use-case you are really interested in) or by individual test function.

I figured that was the case, I think the help docs might just a little out of date. I was wanting to run specific tests using either regex or the test name itself.

There is probably an underlying issue somewhere (or perhaps a few) that needs to be addressed and/or improved, but in principle, what you suggest is essentially already possible.

Right, I think vscode isn't liking that tests are in their own namespace, so when a test module goes to do a relative import from the subpackage, it freaks out.

I don't think we will need a separate script either, we should be able to run pytest from the root of the project and it will discover and run all the tests for us.

Some of the need to adopt of testing helper scripts has probably come from not making use of capabilities otherwise available, but some has also been due to the complexity of the project.
Consider, e.g., an integration test that requires the object_store Docker stack to be running (IntegrationTestObjectStoreDatasetManager ).  It doesn't need the stack started freshly for each individual test invocation:  just that it be running.  Assume that starting the stack takes 2 minutes on a development machine, and that multiple test invocations - perhaps in rapid succession - are going to be performed as changes to the tested code are made.
It introduces an interesting design question of whether (assuming it can) pytest should handle the isolated setup (i.e., without necessarily running any test invocations) and eventual isolated teardown of these and other such things, versus a project-specific tool.  And then dominos start to fall on what else whatever is chosen should also be capable of handling.
That's not necessarily an argument for keeping these scripts.  We just need to keep in mind there are some complex emergent properties of the project that may have subtle impacts or be subtly impacted by these things.

It introduces an interesting design question of whether (assuming it can) pytest should handle the isolated setup (i.e., without necessarily running any test invocations) and eventual isolated teardown of these and other such things, versus a project-specific tool. And then dominos start to fall on what else whatever is chosen should also be capable of handling.
That's not necessarily an argument for keeping these scripts. We just need to keep in mind there are some complex emergent properties of the project that may have subtle impacts or be subtly impacted by these things.

Right, I agree and appreciate the brake pumping. There is always a balance between using a tool vs building and maintaining your own. I am not advocating to remove the run_test.sh script, but instead see how we could use pytest as a core test runner and framework for writing new tests that is compliant and interoperable with our existing testing scripts.
Aside from this, I think it would be helpful for us to first decide if tests should be moved elsewhere in the source tree? That decision should be agnostic of any candidate test runner.

The scripts/test_package.sh script does have some capabilities for isolating the tests to run more specifically than just package/directory. We can expand that further if there are useful scenarios it doesn't support yet. I probably didn't add something like that already because I just ran the tests through Intellij in those situations, which segues into ...

Due to our frequent usage of relative imports in tests and python's import semantics, running individual tests is doable, but often requires some manual intervention (adjusting imports, removing init.py). Likewise, it would be nice if popular IDE test runner plugins "just worked" out-of-the-box.

With perhaps 2 or 3 exceptions, I have not had trouble running tests as-is via Intellij, either by test class (that isn't exactly the same as by file, but I wonder if that's the use-case you are really interested in) or by individual test function. I do remember a couple times when a test function encountered a strange error when run through the IDE, but passed just fine when run through scripts/test_package.sh.
There is probably an underlying issue somewhere (or perhaps a few) that needs to be addressed and/or improved, but in principle, what you suggest is essentially already possible. Other IDEs may behave differently, but I would expect it to be fairly easy to get them to work (now we're getting into exactly what you meant by "'just worked' out-of-the-box"). Regardless, I am curious what problems you have encountered that prompted this.

To revisit this, I found my underlying issue (shocker @robertbartel was correct). I'm sorry for jumping to conclusions earlier. I should have done more investigating.
TLDR; pytest has an option I needed to specify -- --import-mode=importlib.
For background, I really like using pytest to run pretty much any python project's unit tests. It has just become part of my workflow and I think I am a little guilty of forcing pytest as a solution to a problem that doesn't exist. So, my apologies for that. In reading the pytest docs I discovered that pytest does not, by default, use the same module import strategy that unittest does. unittest uses importlib and pytest uses their own import strategy. Funny enough, pytest now recommends using importlib over their own implementation. Im sure with PEPs over the years related to implicit namespace packages for example, these and other features have been added to importlib and pytest has just said, use importlib instead -- makes sense. All of this to say, all I needed to do was specify --import-mode=importlib to pytest and it all worked. You can also specify this is several of their supported configuration files. Once I specified it in a configuration file, my IDE happily ran tests and used pytest as the test runner.
Moving forward, I don't know the we need to move the tests. Now knowing that tests were not intended to be packaged in the first place:

... The idea was to have identical structure for clarity, but the intent was also to avoid installing the dmod.test namespace package. That's the purpose of the exclude usage in the lines like this in most all (if not all) package setup.py files (it's just that it was done incorrectly and never fixed):
packages=find_namespace_packages(exclude=('tests',` 'schemas', 'ssl', 'src'))

It seems that once that is corrected, we will not have namespace mangling issues in dmod.test.__init__.py. @christophertubbs, @robertbartel is that fair, meaning we can close this? Or what other concerns have not been addressed?

With perhaps 2 or 3 exceptions, I have not had trouble running tests as-is via Intellij, either by test class (that isn't exactly the same as by file, but I wonder if that's the use-case you are really interested in) or by individual test function.

Well, this used to be the case (and is again now).
I started to have tests run through Intellij fail to find the test class.  It turned out that Intellij had effectively changed the default Python test runner it was using (Preferences->Tools->Python Integrated Tools->Testing).  This was Autodetect instead of UnitTest.   It isn't clear whether this was changed directly or the automatic detection rules were changed; regardless, now the Twisted Trial runner was actually being used.  Once I changed things to make sure the UnitTest runner was used, I was able to run tests through the IDE again.
@aaraney, I'm curious if any issues with tests in IDEs that you and others have seen are due to something similar.

@aaraney, I hadn't seen your most recent comment, but it lines up with what I just experienced.
I've opened #241 to address the that issue.  With that being tracked separately, yes, I think we can close this.  I suspect #207 can be closed also.  I'll give @christophertubbs a chance to chime in, though.

@aaraney, I'm curious if any issues with tests in IDEs that you and others have seen are due to something similar.

I use VSCode and I think it is an issue, similar to your case, with test discovery. I did a little digging and VSCode is relying on unittest.TestLoader.discover to discover tests. This is analogous to using python -m unittest discover. For what it is worth, I cannot get unittest discover to discover and run the tests. Ive tried from both the root level of the repo, ./python/lib, and ./python/lib/{{ package }}. Ive even tried removing the gui directory completely as I was running into django issues. So I am scratching my head a bit.
I was, however, able to get pytest to working with a few workarounds.

Added conftest.py to repo root, this is a pytest configuration file. In short, pytest needs to append the repo root to sys.path.

# conftest.py
import sys
from pathlib import Path

REPO_ROOT = Path(__file__).parent.resolve()

# this is analogous to running `python -m pytest`
sys.path.insert(0, str(REPO_ROOT))

Created a pytest.ini file at the repo root.

# pytest.ini
[pytest]
addopts = --import-mode=importlib

Configured Python testing in VSCode (cmd (ctrl) + shift + p -> Python: Configure Tests -> pytest)

Opened workspace setting in VSCode (cmd (ctrl) + shift + p -> Preferences: Open Workspace Setting (JSON)) and added the following:

{
    "python.testing.pytestEnabled": true,
    "python.testing.pytestArgs": [
        "python/lib"
    ]
}

After that, testing and test discovery is working for me.

I've opened https://github.com/NOAA-OWP/DMOD/issues/241 to address the failure to exclude test sources as intended. With that being tracked separately, yes, I think we can close this. I suspect https://github.com/NOAA-OWP/DMOD/issues/207 can be closed also. I'll give @christophertubbs a chance to chime in, though.

I think the majority of my issues were just with testing Django stuff under python/services/evaluationservice, which should probably be tested through manage.py anyways, so everything sounds good to me. Excluding the test directories from the setup.py files will probably fix everything else I ran into (can't remember which). I want to say tests were getting mixed up and referencing test resources in the virtual environment rather than what was local. Exclude those test files and that scenario shouldn't crop up.

@aaraney, item 1 and 2 seem generic enough that we could add those to the repo.  It may be better for the moment, though, to document this (similarly to what I go into below) and add entries to .gitignore.  Potentially, we could also provide example files in some directory that people had to move into place themselves if they wanted.
Item 3 and 4 are certainly something user-specific, though there is likely to be a wide spread need for that info.  The top-level TESTING.md file has details on testing setup and tools, and a section on how to avoid our recent VSCode and Intellij issues might be helpful.
If/when we fully move to pytest, TESTING.md  will need to be updated, as it details our use of unittest.  That's another reason why I suggested the alternative of documenting+ignoring your pytest files:  we would have to review and updated this file (and at least test the functionality of the testing scripts) if we do a full, official switch.
Thoughts?

@aaraney, item 1 and 2 seem generic enough that we could add those to the repo. It may be better for the moment, though, to document this (similarly to what I go into below) and add entries to .gitignore. Potentially, we could also provide example files in some directory that people had to move into place themselves if they wanted.

I agree that these are generic enough to merit moving them into the repo. Options specified in 2. can be specified in pyproject.toml(pre-build requirements file; a file we should add in the future next to package's setup.py / setup.cfg) as an alternative and maybe more attractive solution.

Item 3 and 4 are certainly something user-specific, though there is likely to be a wide spread need for that info. The top-level TESTING.md file has details on testing setup and tools, and a section on how to avoid our recent VSCode and Intellij issues might be helpful.

Yeah, moving these into the testing documentation seems like the most sane option. There is likely some pytest configuration that I am unaware of that might make 4. unnecessary.

If/when we fully move to pytest, TESTING.md will need to be updated, as it details our use of unittest. That's another reason why I suggested the alternative of documenting+ignoring your pytest files: we would have to review and updated this file (and at least test the functionality of the testing scripts) if we do a full, official switch.

Right, this isn't the most pressing matter and, like you said, it will require a negligible amount of work, so I agree that punting this to a later discussion is probably the best idea. I foresee reevaluating this before we port services to REST a good timeline IMO. I think if we do switch, we will feel to see the benefits of using pytest when more complex testing fixtures and test parametrization combinations are required.
With that said, in the short term, I think we should add the functionality of 1. and 2 to the repo and leave 3. and 4. out. How is that compromise?

With that said, in the short term, I think we should add the functionality of 1. and 2 to the repo and leave 3. and 4. out. How is that compromise?

I may be misunderstanding.  I don't think we should add those pytest files without also updating the testing documentation to explain them, at which point we should outline the VSCode test issues and how the user can apply steps 3 and 4 to address them.  We (i.e., I) probably also need to document the recent test issues in Intellij.
We don't need to add or update VSCode workspace or settings files, though, assuming those typically exist locally inside the repo directory structure.

Leaving a note for myself and anyone else who wants to use pytest with dmod. Here are the two files that i've added to my local dev environment to make pytest happy. This includes the ability to run dmod integration tests using an added custom pytest option, --it. You Put both of theses files in the root of your dmod clone / fork.
pytest.ini
[pytest]
addopts = --import-mode=importlib
; key=value pairs with no spaces
it_env_vars =
; A name for the Docker container used to run a Redis instance during integration testing
IT_REDIS_CONTAINER_NAME="it_redis_container"
; The port-forwarded port on the host machine for the containerized Redis service
IT_REDIS_CONTAINER_HOST_PORT=19639
;The containerized Redis service's password
IT_REDIS_CONTAINER_PASS="DPXzqRqjhsXokOVQcPUqOJuzKePMsfUc"
DOCKER_MPI_NET_NAME=mpi-net
DOCKER_MPI_NET_SUBNET=<IP_ADDRESS>/24
DOCKER_MPI_NET_GATEWAY=<IP_ADDRESS>
DOCKER_MPI_NET_VXLAN_ID=4097
DOCKER_REQUESTS_NET_NAME=requests-net
DOCKER_REQUESTS_NET_SUBNET=<IP_ADDRESS>/27
DOCKER_REQUESTS_NET_GATEWAY=<IP_ADDRESS>
TEST_SSL_CERT_DIR=
PROJECT_ROOT=
MODEL_EXEC_ACCESS_KEY=dmod
MODEL_EXEC_SECRET_KEY=password

`conftest.py`

import os
import sys
from pathlib import Path
import logging
import pytest
from typing import Dict, List, Set, TYPE_CHECKING, Optional
from pytest import Item, CallInfo, Session
import subprocess
logger = logging.getLogger("dmod_conftest")
if TYPE_CHECKING:
from pytest import Config, Parser
REPO_ROOT = Path(file).parent.resolve()
this is analogous to running python -m pytest
this is needed for pytest discovery reasons specific to dmod's package structure
sys.path.insert(0, str(REPO_ROOT))
integration_testing: bool = False
modules: Set[Path] = set()
active: Set[Path] = set()
def integration_testing_flag():
global integration_testing
integration_testing = True
logger.debug("integration testing flag on")
def pytest_addoption(parser: "Parser"):
parser.addoption(
"--it", action="store_true", default=False, help="run integration tests"
)
parser.addini(
"it_env_vars", "Environment variables for integration tests", type="args"
)
def parse_it_env_vars(name_values: List[str]) -> Dict[str, str]:
return dict(map(lambda pair: pair.split("="), name_values))
def pytest_configure(config: "Config"):
if config.getoption("it"):
python_files = config.getini("python_files")
assert isinstance(python_files, list)
python_files[:] = ["it_*.py"]
    it_env_vars = config.getini("it_env_vars")
    integration_testing_flag()

    parsed_vars = parse_it_env_vars(it_env_vars)
    logger.debug(f"Adding these environment variables: {parsed_vars}")

    os.environ.update(parsed_vars)

def get_setup_script_path(module: Path) -> Path:
return module / "setup_it_env.sh"
def setup(setup_script: Path) -> "subprocess.CompletedProcess[bytes]":
cmd = " ".join(["source", str(setup_script), "&&", "do_setup"])
logger.debug(f"launching setup script: {cmd!r}")
return subprocess.run(
cmd,
capture_output=True,
shell=True,
)
def teardown(setup_script: Path) -> "subprocess.CompletedProcess[bytes]":
cmd = " ".join(["source", str(setup_script), "&&", "do_teardown"])
logger.debug(f"launching teardown script: {cmd!r}")
return subprocess.run(
cmd,
capture_output=True,
shell=True,
)
def format_completed_process(cp: "subprocess.CompletedProcess[bytes]") -> str:
return (
f"args:   {cp.args!r}\n"
f"stdout: {cp.stdout.decode('utf-8').strip()}\n"
f"stderr: {cp.stderr.decode('utf-8').strip()}"
)
def pytest_runtest_setup(item: Item):
if not integration_testing:
return
module = item.path.parent
if module not in modules:
    modules.add(module)

    setup_script = get_setup_script_path(module)

    if setup_script.exists():
        out = setup(setup_script)
        logger.info(f"setup: {module.parent.parent.name!r}")
        logger.debug(format_completed_process(out))

        if out.returncode != 0:
            logger.debug(
                f"non-zero return code ({out.returncode:3}): {module.parent.parent.name!r}"
            )
            logger.debug(format_completed_process(out))

            out = teardown(setup_script)
            logger.info(f"tearing down {module.parent.parent.name!r} early")

            if out.returncode != 0:
                logger.debug(
                    f"non-zero return code ({out.returncode:3}): {module.parent.parent.name!r}"
                )
                logger.debug(format_completed_process(out))

            item.session.shouldstop = True
            # dont add to active
            return

        active.add(module)

def pytest_runtest_teardown(item: Item, nextitem: Optional[Item]):
if not integration_testing:
return
next_item_module = nextitem.path.parent if nextitem is not None else None
if next_item_module is None or next_item_module not in modules:
    # do item tear down
    module = item.path.parent
    setup_script = get_setup_script_path(module)

    out = teardown(setup_script)
    logger.info(f"tearing down: {module.parent.parent.name!r}")
    logger.debug(format_completed_process(out))

    active.remove(module)

def pytest_sessionfinish(session: Session, exitstatus: int):
if not integration_testing:
return
while True:
    try:
        module = active.pop()
    except KeyError:
        break

    setup_script = get_setup_script_path(module)
    out = teardown(setup_script)

    logging.info(f"tearing down: {module.parent.parent.name!r}")
    logging.debug(format_completed_process(out))


how to add a marker point on a specific location ?

Hi, I use your package and It's work fine but now I want to add some markers on specific locations.
I just want to be able to add a marker with a specific size and color on a specific location( it's not important if the marker is a squarre or a circle).
but I don't find any advice or example to do it....
thanks for your help :)

I don't work on this repo, but I've been working with it for a little bit.  Most of what you want can be achieved in the MainPageViewModel constructor.  If you just add a new PointAnnotation to the Annotations, it will add a new point marker.  You should be able to add any Annotation object here and it will be added to the map.  You can also directly set a new CenterLocation to start from here.  Hope that helps.  I'm trying to figure out if the Android and iOS librarys work from this repo.  They use the local namespace for the main project, but use nuget packages for android and iOS respectively.

Hi,
To add a marker point, it's adding a SymbolAnnotation to the map.
Please check out one of our samples ported from Android samples.
P/S: It's recommended to read Mapbox document first and/or to scan more info there.
Cheers.

Hi @tuyen-vuduc
Please help me to show marker with text. Although I've set value to properties: Tile, SubTitle of SymbolAnnotation object, but it only show image of marker only.
Please help me. It is urgent to me.
thank you very much
Nhat


background img inverted...Need Help!

I have tried changing sites_fixes_v2.json
{
"url": "blog.naver.com",
"selectors": ".se_mediaImage, .__se_img_el"
},
but it doesn't work for the sub directorties such as
blog.naver.com/abcd
blog.naver.com/123
I'm wondering how I can fix this?

try using a * (wildcard)
(I honestly have not dealt with this, just a suggestion off the top of my head)

Should work well with Dynamic Theme mode.


When will buffer queues be enabled?

I noticed that it states that requests can queue when all llama.cpp instances are busy.
I was wondering if the queuing is done per llama.cpp server or per slot?
I am currently trying to scale up from 1 to multiple llama.cpp servers and the paddler_requests_buffered metric is always 0.

@bodybreaker I will check if those metrics work correctly and get back to you.

@bodybreaker  I have just released a new stable version of Paddler (v1.0.0) and changed the CLI framework, overall it underwent a total rewrite.
I think your issue should be solved now, if it still persists feel free to reopen (please check the README though, some flag names have changed).


tedge-agent creates /var/tedge/cache directory on start-up

Proposed changes
This directory was introduced by c8y-firmware-plugin, however, now cloud mappers need to download files from remote. The cache directory must be used also by cloud mappers to avoid multiple file downloads for the same file.
The directory usage will be covered by robot tests during #2292 work.
In addition, to solve this comment https://github.com/thin-edge/thin-edge.io/pull/2293#discussion_r1338429388, I introduced DataDir(crates/core/tedge_api/src/path.rs) struct, which is a wrapper of Utf8PathBuf with refactoring codes.
Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue
#2292
Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[x] I ran cargo fmt as mentioned in CODING_GUIDELINES
[x] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

That being said, using Utf8PathBuf and Utf8Path across the board is not such a bad idea either.

Since tedge_config API returns Utf8PathBuf, using PathBuf is a kind of downgrade in most of cases (only config_path from command line option is different, I'm not sure if clap can accept Utf8Pathbuf.)
So, I even wish I could change all usage of PathBuf to Utf8PathBuf in several crates.


Use client-extension.yaml instead of client-extension-config.json

Hello team,
It's an old request made to me, it's about use properties of client-extension.yaml instead of client-extension-config.json.
Unfortunately a lot of tasks were assigned to me and I didn't had time to do this changes previously.
Best regards,
Feliphe

Closing in favor of https://github.com/liferay/liferay-localdev/pull/107

Thanks for that!
On Tue, Jan 3, 2023 at 11:02 AM Feliphe Marinho @.***>
wrote:

@gamerson https://github.com/gamerson,
they're not the same changes, one pull request is for Workflow Action and
this one is for Notification Type.
Best Regards,
Feliphe
—
Reply to this email directly, view it on GitHub
https://github.com/liferay/liferay-localdev/pull/106#issuecomment-1370007747,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAERKFMSG2ELLXYHIBCVRUDWQRLRRANCNFSM6AAAAAATPD2SP4
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Greg Amerson
Liferay Cloud. liferay.com


[Compatibility Issue] Cannot access the field due to Private ENUM

What is the compatibility issue
Take a look at WoodenBenchBlock
the LegPosition ENUM is set to "private", I've checked other blocks (Chairs & Tables), their ENUM are all public.
SOLUTION: it's simple, you can change it to public and upload the newer version to Curseforge. I can use that mod to finish the support (more details below)
The version for 1.20.1 is v0.5.10.
Additional info
I'm adding support to Clutter mod via Every Compat, so you don't have to worry about the addon to support other wood mods (Biomes O' Plenty, and more...).

I'll release a quick patch for it sometime this week, let me know if there is anything else you need access to in the meantime.

thanks for the replying. The change of that "private" to "public" is all I need for now.

All good now. Thanks for the quick changes. Your mod will be supported by EveryCompat

Forgot to ask you, can you do the same for 1.19.2?


boot2docker is still being used. Switch to Docker toolbox?

I got a warning when running this:
test-docker-osx-dev $ docker-osx-dev
2015-11-04 10:39:02 [INFO] Using default sync paths: .
/usr/local/bin/docker-osx-dev: line 958: greadlink: command not found
2015-11-04 10:39:02 [INFO] Complete list of paths to sync:
2015-11-04 10:39:02 [INFO] Using default exclude paths: .git
2015-11-04 10:39:02 [INFO] Complete list of paths to exclude: .git
2015-11-04 10:39:02 [INFO] Complete list of paths to include:
2015-11-04 10:39:02 [INFO] Starting docker-osx-dev file syncing
2015-11-04 10:39:02 [INFO] Initializing Boot2Docker VM
WARNING: The 'boot2docker' command line interface is officially deprecated.
Please switch to Docker Machine (https://docs.docker.com/machine/) ASAP.
Docker Toolbox (https://docker.com/toolbox) is the recommended install method.
Thanks.

We do have experimental support for docker-machine, as explained in the README. At some point, we should make that the default, though that would be a backwards incompatible change. Perhaps we should detect the docker version and decide based off of that?

Docker Machine works perfectly fine with docker-osx-dev and we've been constantly upgrading the stables with Docker Toolbox. Current stable we run in production for more than a month now is 1.8.3. Integration tests against Docker Machine are also in progress.
As for your problem, please check against versions you're running and that the boot2docker and VirtualBox versions are actually up to date. I've seen this problem happening in the team as well, but it has always been environment setup mishap.

Poking this issue, as this is somehow still the best method for working with Docker on OS X. Killing lines 745-747 had no ill effect on anything for me, and in fact helped by stopping the Docker for Mac beta and homebrew's equivalents from colliding.
745   # brew_install "boot2docker" "Boot2Docker" "type boot2docker" false
746   # brew_install "docker-compose" "Docker Compose" "type docker-compose" false
747   # brew_install "docker-machine" "Docker Machine" "type docker-machine" false


"Phantom requests" occur when a replica is terminated with requests in its RequestsProcessing stock

Placeholder, see this comment.

Note: this will probably need me to revisit the question of event cancellation, which I thought I was able to (mostly) ignore in this generation of the design.

Instead of looking at event cancellation, it occurred to me that there was a missing stock: Replicas Terminating. This stock schedules the movement to Replicas Terminated by taking into account the number of requests left in RequestsProcessing.


[stable/datadog] Add config maps, env vars, and ports

Optionally open up APM tracing ports
Provide configmap hooks for custom autoconf, checks.d, and conf.d
Open up environment variables

@gtaylor I feel like I should explain some of the choices I've made, regarding conf.d and auto_conf.
The datadog entrypoint script recursively copies from /conf.d and /checks.d to /etc/dd-agent/conf.d and /etc/dd-agent/checks.d, respectively. If you aren't using k8s configmaps, you can easily create static and auto_conf configuration files. But the directories /conf.d and /checks.d are docker volumes. And confimaps do not permit sub-directories, at least as key names. Additional volumes cannot be mounted within these volumes (at least I haven't been able to figure out how).
Thus, I have separated all three concerns. The datadog.confd and datadog.checksd keys write to their /conf.d and /checks.d counterparts. The datadog.autoconf (so named, because I can't use _ or uppercase, otherwise k8s pukes) overwrites the existing /etc/dd-agent/conf.d/autoconf directory. This will effectively remove all files already present, such as etcd.yaml, redisdb.yaml, etc.

cc @gtaylor

Splitting out into distinct config maps makes sense to me. LGTM, but let's wait on @gtaylor to weigh in.

Sorry for the delay. This looks great. Much more flexible. LGTM.

@k8s-bot e2e test this

@seanknox @gtaylor
Here's an interesting issue, the default values are supposed to allow a user to install the chart... But the ENTRYPOINT of the image exits, if the env var API_KEY isn't set. I'm inclined to say that the datadog.apiKey should default an empty string and the check in NOTES.txt should be modified to account for that possibility.

FWIW here's an example of handling a lack of API key: https://github.com/kubernetes/charts/blob/master/stable/sumokube/templates/NOTES.txt

@seanknox The NOTES.txt for datadog already includes the same notification. The tests are affected by this issue, because the image's ENTRYPOINT will exit, if API_KEY isn't set.

@seanknox Sometimes I am thick. I now realize, my assumption was incorrect... and your suggestion was aimed at setting a default of MISSING, when the user doesn't provide any value. Derp. I'll look into why this default value isn't working.

@lachie83 @prydonius @mgoodness I think CI failed because the chart output has the word "error"—can one of you confirm?

I think it's just highlighting lines with the words "error" and "fail" on them. Looks to me like the build job isn't able to find/delete created resources, so it's failing. Let's try again
@k8s-bot ok to test

The deletion error looks like an issue in Helm. Can anyone reproduce this locally?

Aha, it's the --- delimiters at the top of the configmaps. helm still deletes the resources despite the errors. Remove those and the deletion error goes away. @flah00
---
apiVersion: v1
kind: ConfigMap
metadata:
  name: {{ template "confd.fullname" . }}
  labels:
    app: {{ template "confd.fullname" . }}
    chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
    release: "{{ .Release.Name }}"
    heritage: "{{ .Release.Service }}"
data:
{{- if .Values.datadog.confd }}
{{ toYaml .Values.datadog.confd | indent 2 }}
{{- end -}}

Thanks for the help on this! Changes made.

I'd love to see this merged!

@seanknox are we clear to merge this?

@lachie83 yep this is ready to go.


Sync XML registry files from Vulkan-Docs

Sync the vk.xml and related Python scripts with the latest revisions from
Vulkan-Docs:

Update local copy of vk.xml from Vulkan-Docs
Merge minor changes to genvk.py and generator.py from Vulkan-Docs to
local copies
Update parameter_validation code generation to support use of types
across API features; The core API feature needs to be aware of a
structure defined by the AMD_rasterization_order feature for the
purpose of pNext validation
Modify thread_check code generation to add TODO messages for debug
marker support

thanks pushed to master!


Visualize wireframes

Signed-off-by: Atharva Pusalkar<EMAIL_ADDRESS>🎉 New feature
Summary
Adds wireframe mode to visuals in OGRE 1 and 2. This PR targets Ignition Fortress since the changes break the ABI.
OGRE 2

OGRE 1

Test it
Test it with wireframes.
Checklist

[x] Signed all commits for DCO
[x] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[x] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@osrf-jenkins retest this please

Changed scene name to "scene7" since "scene6" is used in BoundingBox.

This pull request has been mentioned on Gazebo Community. There might be relevant details there:
https://community.gazebosim.org/t/google-summer-of-code-2021-new-gui-widgets-in-ignition-gazebo/1081/1