script/build does not accept any options

Prerequisites

[x] Can you reproduce the problem in safe mode?
[x] Are you running the latest version of Atom?
[x] Did you check the debugging guide?
[x] Did you check the FAQs on Discuss?
[x] Are you reporting to the correct repository?
[x] Did you perform a cursory search to see if your bug or enhancement is already reported?

For more information on how to write a good bug report or enhancement request, see the CONTRIBUTING guide.
Description
Passing help or --help to script/build does not work.
Steps to Reproduce

Download Atom 1.12.2.
Extract.
Run script/build --help or script/build help.

Expected behavior: [What you expected to happen]
The help/usage should be shown.
Actual behavior: [What actually happened]
The script starts building and installing Atom.
Versions
1.12.2

script/build --help does actually output build options however it first has to check the various dependencies/versions of things. The very first time that might take several minutes as it downloads and builds various npm and apm packages.  Subsequent runs should only be a few seconds;
root@atom-deb:/home/damieng/Source/atom# script/build --help
Node:	v4.4.7
Npm:	v3.10.5
Installing script dependencies
Installing apm
Installing modules ✓
Wrote Dependencies Fingerprint: /home/damieng/Source/atom/node_modules/.dependencies-fingerprint 6dcf8451e00072b50676fd6878dfc9a7b02105f1
Usage: /usr/bin/nodejs script/build [options]

Options:
  --help                      Show help                                               [boolean]
  --code-sign                 Code-sign executables (macOS and Windows only)
  --create-windows-installer  Create installer (Windows only)
  --create-debian-package     Create .deb package (Linux only)
  --create-rpm-package        Create .rpm package (Linux only)
  --compress-artifacts        Compress Atom binaries (and symbols on macOS)
  --install                   Install Atom

I think @damieng's response closes this. Feel free to reply if not.

@damieng, thank you for the response. In my opinion, that is a bad behavior to install anything when the user just wants to run help, and I don’t understand why that is necessary.
Looking at the code, the usage section should just be moved to the top before requiring bootstrap, shouldn’t it?
const yargs = require('yargs')
const argv = yargs
  .usage('Usage: $0 [options]')
  .help('help')
  .describe('code-sign',  'Code-sign executables (macOS and Windows only)')
  .describe('create-windows-installer', 'Create installer (Windows only)')
  .describe('create-debian-package', 'Create .deb package (Linux only)')
  .describe('create-rpm-package', 'Create .rpm package (Linux only)')
  .describe('compress-artifacts', 'Compress Atom binaries (and symbols on macOS)')
  .describe('install', 'Install Atom')
  .wrap(yargs.terminalWidth())
  .argv

Should I open a new issue for that?

We have an issue for this already https://github.com/atom/atom/issues/12978

@Ben3eeE, thank you. Good find.


AssetServer panics with workspaces when reloading enabled

I have a workspace setup with folders such as
assets/*
bevy-prototype-aseprite/*
game/*
xtask/*

where game stores the 'main' bevy program, and assets is the assets.
This works fine until I enable 'reloading' of the asset server.
Then if the asset changes it crashes on this line
https://github.com/bevyengine/bevy/blob/8b3553002d5792082f2a821a730ae9ed8ed1207c/crates/bevy_asset/src/asset_server.rs#L213
Where the values are
path: "C:\Users\Beau\source\repos\game2\assets\notfound.aseprite",
root_path: "C:\Users\Beau\source\repos\game2\game"
So it looks like the root path is taken from the 'game' project, but asset server is assuming all assets must be in subfolders underneath it.
Moving it into a subfolder prevents the crashes, though doesn't seem to reload the asset on change (this may be my asset loaders fault though).
EDIT: Seems to be a bit dammned if you do, dammned if you don't with workspaces. If I move the assets into the 'game' directory, the asset server assumes the relative path after stripping is the 'workspace root', so won't find files.
Tweaking it to navigate up 'hacks' it to work and reload on change nicely, but I suspect that's not compatible with non work space approaches.
let root_path = asset_server.get_root_path().unwrap();
let root_path = root_path.parent().unwrap();

This needs to be reproduced; there's been a lot of changes to this code since this issue was made.


[1/3]Implemente LRO Operation Callable Method sample code

Inside of try body,

construct request with default values.
Assign future variable with invoking LRO callable method.
Assign response variable with invoking future.get method.

   * try (CloudRedisClient cloudRedisClient = CloudRedisClient.create()) {
   *   LocationName parent = LocationName.of("[PROJECT]", "[LOCATION]");
   *   String instanceId = "test_instance";
   *   Instance.Tier tier = Instance.Tier.BASIC;
   *   int memorySizeGb = 1;
   *   Instance instance = Instance.newBuilder()
   *     .setTier(tier)
   *     .setMemorySizeGb(memorySizeGb)
   *     .build();
   *   CreateInstanceRequest request = CreateInstanceRequest.newBuilder()
   *     .setParent(parent.toString())
   *     .setInstanceId(instanceId)
   *     .setInstance(instance)
   *     .build();
   *   OperationFuture<Instance, OperationMetadata> future = cloudRedisClient.createInstanceOperationCallable().futureCall(request);
   *   // Do something
   *   Instance response = future.get();
   * }

Has master been merged into the base branch recently?

Thanks for reminding. Yes. The lastest commit from master is #604


[API/Mobile]Haptics API with CapacitorJs

Topic Suggestion
Proposed title of the article
Haptics API  with CapacitorJs
Proposed article introduction
Haptic respond to feel or touch in a mobile application.
Capacitor JS takes advantage of the modern 'feel' functionality available in mobile devices. Through the haptics, an application can respond by vibrating or ringing when triggered.
This article aim at guiding the reader through implementing haptics in a Native mobile application using CapacitorJs. Capacitor js is a relatively new technology in software development, and this is the base of the insight to this article. While every programmer uses stable tech stacks, this article opens up to a new way of development.
Key takeaways

Working with CapacitorJS
Implementing haptics on a Native application.
Building a cross-platform web/mobile applications

References
Please list links to any published content/research you intend to use to support/guide this article.
Templates to use as guides

How To Guide Template
Software Review Template
Tutorial Template

Sounds like a helpful topic - let's please be sure it adds value beyond what is in any official docs and/or what is covered in other blog sites. (the articles should go beyond a basic explanation - and it is always best to reference any EngEd article and build upon it). @jerimkaura
Please be attentive to grammar/readability and make sure that you put your article through a thorough editing review prior to submitting it for final approval. (There are some great free tools that we reference in EngEd resources.)
ANY ARTICLE SUBMITTED WITH GLARING ERRORS WILL BE IMMEDIATELY CLOSED.
Please be sure to double-check that it does not overlap with any existing EngEd articles, articles on other blog sites, or any incoming EngEd topic suggestions (if you haven't already) to avoid any potential article closure, please reference any relevant EngEd articles in yours. - Approved

Just pinging you on this topic form - as I'm making some room in the topic queue.
No rush if you're still working on this one - if you need more time we can always re-open at a later date


incoming message content does not show on notification lock screen

Would like to be able to read messages at a glance when they come in and my phone briefly turns on the lock screen. Currently only a notification that I have received a message comes through. Is there a configuration i'm missing somewhere in room, app settings, or ios settings?

in speaking with @matthew:matrix.org this may be an issue with our room being e2e encrypted

Perhaps this issue is related #800

Yeah. This feature is currently missing like #800 indicates


Time-based query batching (block and gather untill timeout)

Manager owned timeout value

See https://github.com/OpenAssetIO/OpenAssetIO/issues/1203#issuecomment-1845648683


Load balancer can't be created with plaintext HTTP disabled

This annotation:
https://github.com/relaycorp/cloud-gateway/blob/5422ecff225a2591b07aafba76f667b8bc411b02/charts/gateway/values.yml.gotmpl#L16
Will cause the following provisioning issue:
Error during sync: error running load balancer syncing routine: loadbalancer <whatever> does not exist: invalid ingress frontend configuration, please check your usage of the 'kubernetes.io/ingress.allow-http' annotation.

GCP support issue: https://console.cloud.google.com/support/cases/detail/26077051?project=relaycorp-cloud-gateway

No longer using Kubernetes! 🎉


Master ticket for Vortex PMF UI

Context
This is the master ticket for the all the UI stuff that is required for the Vortex PMF UI
Tickets

[x] #49
[x] #50
[x] #52
[x] #53
[x] #54
[x] #55
[x] #56
[x] #68
[x] #69

I will close this ticket.


.NET Core compatibility

Any idea if and when this package will be ported to / targeted for net5.0 (and up)? I've included the package in a net5.0 project and everything seems to work, but I am getting these warnings:
NU1701: Package 'StyleMerge 1.0.28' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework 'net5.0'. This package may not be fully compatible with your project.

Or do you perhaps know of a similar package that is already fully net5.0 compatible?

@creativesuspects the latest version of this package targets netstandard2.0, and so should be good to use in net5.0.


Running tests from within Visual Studio in a static lib project

I am currently using Google Test. I can happily run my tests from within Visual Studio.
I want to start using doctest because the features list says I can use it along side my production code (Google Test cant do it). I have a static lib project in Visua Studio, and I want to run the tests from within Visual Studio. Here  is what happens when I click the Test circle thingy (red rectangle in the screenshot) and choose Run. Green rectangle is my static lib project. Blue rectangle is my exe project.
Please help me :-) What am I missing?

Hi!
I see that you are using ReSharper. They recently added support for doctest, and I suppose that's what you are testing out. Unfortunately I haven't used ReSharper and haven't tested the integration - I'm not at all familiar with the interface and the mode of running/execution.
You should perhaps take this question to them, as I won't be currently able to look into this into much detail...

I understand what you are saying. I turned off ReSharper, but now my test is not being discovered by Visual Studio's build in Test Explorer thingy. Here is a screenshot.

I haven't used ReSharper and am not familiar with its interface... If someone else has any experience perhaps they could help with this. Otherwise you could look into the documentation of ReSharper or their support.

You don't under stand, I turned off ReSharper. Could you please read my last post above?

Sorry I missed that - I'm just about to go to bed.
So... I haven't used the Test Explorer either, but I don't think there is any integration with doctest on the Visual Studio side... ReSharper is the first IDE/tool which integrated doctest in it's test discovery/runner - hopefully others will follow (perhaps I should contact someone for that...). You could still execute the tests by running the compiled binary. Sorry, this is all I have for now, good night :)

Good night and sweet dreams! :-)
For the morning: I understand now, there is no integration between doctest and Visual Studio (somebody needs to write a thingy called Test Adapter).
Regarding this:

execute the tests by running the compiled binary

Am I to understand from this that the usual and/or normal and/or best and/or optimal way of using doctest is to run my binary? Every time I need to see if my test passes or not? There is no way to run the test from within Visual Studio (ReSharper excluded)?

Solved. Please read here, especially the Configuring test runner part. In case the link will not work in the future, here is an exert that helped me:

Configuring test runner
Unit test execution variables, such as command, its arguments, working directory, and environment variables are normally specified in project properties (Project Properties | Configuration Properties | Debugging) and ReSharper will take them from there.
However, if these properties are not specified there (for example, in a library project, in an 'Open Folder' or CMake project), you can define execution settings on the Tools | Unit Testing | Test Frameworks | C++ Tests page of ReSharper options (Alt+R,,O).
You can also use the Merge environment flag on that page. If it is selected, ReSharper will add environment variables specified in the Environment field to the environment variables from Visual Studio. If it is not selected, only environment variables from Visual Studio will be used.

Thank @onqtam very much, your answers helped me to figure out the proper keywords for Google search.


Replicated Volume Support

👋🏽 Hey!
Would it be possible to add support for replicated volumes using OpenEBS or CruncyData's Postgres Operator?

Nevermind, I see you've already stated that it's up to users, and even mentioned a reference to zalando's operator. Thanks anyway!


After removing deployment and redeploying to the same stage (prod), it does not show up in console.

After removing deployment and redeploying to the same stage (prod), it does not show up in console.

Does Rescanning the account help?

We are transition this repo to https://github.com/sst/v2 and are closing this issue for now. If it is still relevant please reopen it there - sorry for the trouble


⚠ ClamAV has degraded performance

In 7ea46bf, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 35 ms

Resolved: ClamAV performance has improved in 6e2b3a6.


AttributeError: 'module' object has no attribute 'recorder'

flask-gae-mini-profiler is causing the following error with the new python27 App Engine runtime:
Traceback (most recent call last):
  File "/base/python27_runtime/python27_lib/versions/1/google/appengine/runtime/wsgi.py", line 175, in Handle
    for chunk in result:
  File "packages/flaskext/gae_mini_profiler/profiler.py", line 317, in __call__
    self.recorder = recording.recorder
AttributeError: 'module' object has no attribute 'recorder'

This seems to be an issue with the upstream module rather than the flask wrapper. Could you please report this to the original author at https://github.com/kamens/gae_mini_profiler?

Thanks. Looks like this was already reported as https://github.com/kamens/gae_mini_profiler/issues/13 in case you want to follow.

Thanks for the link. If this gets fixed, I'll pull the changes right away.


Fixed unit tests for MICRO QrCode

We changed validation regarding data length for QRCode model MICRO, but never realized that it was failing the unit tests because the string that used string was longer than the max length.

@lukevp this PR should be merged before creating auto build process on GH Actions


Use fastlane match appstore command without apple account password

Can I log in to fastlane match without apple password with API key?
I run the fastlane match appstore command and it asks for the repo and I give the link. Then it asks for the information of the apple account. Is there an option that I can continue by giving an api key instead of username and password? For example, we use google auth and almost no one has a password.

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description

Command executed

Complete output when running fastlane, including the stack trace and command used

 [REPLACE THIS WITH YOUR INFORMATION]

Environment

 [REPLACE THIS WITH YOUR INFORMATION]

@AcarFurkan Yes, check the docs.


indexer fix: reset db via reverting migrations (#18993)

Description
the issue was that, prev indexer db reset was done via dropping all tables, which is problematic when we change a PG PROCEDURE parameter, see this slack message.
https://mysten-labs.slack.com/archives/C03TCGDF45N/p1723507055114959
this caused issues on CI after merging
https://github.com/MystenLabs/sui/pull/18899 and it got reverted, this pr changes it to reverting all migrations and cleans up the table dropping codes
Test plan
locally

reset DB before #18899
cherry-pick this pr
cherry-pick #18899

run cmd below, which was the cmd on CI that ran into issue
DB_POOL_SIZE=10 cargo run --bin sui-indexer -- --db-url "postgres://postgres:postgres@localhost/gegao" --reset-db

Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

[ ] Protocol:
[ ] Nodes (Validators and Full nodes):
[ ] Indexer:
[ ] JSON-RPC:
[ ] GraphQL:
[ ] CLI:
[ ] Rust SDK:
[ ] REST API:

Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?

Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

[ ] Protocol:
[ ] Nodes (Validators and Full nodes):
[ ] Indexer:
[ ] JSON-RPC:
[ ] GraphQL:
[ ] CLI:
[ ] Rust SDK:
[ ] REST API:

Merged it manually as 145c3214847810acb47ca0d3a2b7fcb6833e298a


Buildbot fails

https://travis-ci.org/01org/node-realsense/builds/215436218

https://travis-ci.org/01org/node-realsense/builds/215436218#L2118
  CXX(target) Release/obj.target/realsense_object_recognition/common/camera-delegate/camera_delegate.o

In file included from ../common/camera-delegate/camera_delegate.cpp:5:0:

../common/camera-delegate/camera_delegate.h:8:31: fatal error: librealsense/rs.hpp: No such file or directory

compilation terminated.

librealsense headers should be already installed... what is going on, I wonder...

In fact, it was not installed.
I went through and compared some of the failed and succeeded builds.
failed builds like this one, is due to:
Err:115 http://realsense-alm-public.s3.amazonaws.com/apt-repo xenial/main amd64 librealsense-slam2 amd64 2.0.4-0ubuntu1~25.gbp73dfd6   Hash Sum mismatch
this failure to download the package cause most of the realsense related packages not installed.
A previous failure of build No 33, is caused by hash mismatch when downloading librealsense-samples package:
Err:116 http://realsense-alm-public.s3.amazonaws.com/apt-repo xenial/main amd64 librealsense-samples amd64 0.6.5-1ubuntu1~21.gbp8e624e   Hash Sum mismatch

Checked with @tingshao for recent buildbot logs at https://travis-ci.org/01org/node-realsense/builds, this failure is occasionally happening.  So close it as not fix.


Discord Formatting breaks. A lot.

Caused by ``` twice in name

Caused by just sending = and no following text

Caused by backslash in name

Self explanatory

Name greater than 251 characters causes this

Affected elements:
#3223
#4165
#4184
#4188
#4196
#4202
#4211
#4219

All of these issues are fixed


Outdated link to the FlutterFire repo

Hey
I saw that the link to the FlutterFire repo in your README.md file is outdated.
https://github.com/benoitletondor/Beer-Me-Up/edit/master/README.md#L33
Here is the new one https://github.com/FirebaseExtended/flutterfire. 😀

Thanks for the report. As you might have seen, this repo isn't really updated for a while, so it's probably not the only thing outdated

Oh yeah summer 2019 didn't notice. ^^


crash: closing modified file consistently crashes atom

Whenever I change a file opened in atom and then try to close it without saving it, atom crashes. This has been going on for months, so I suspect it has to do with my system and its gtk lib: I am using Debian unstable, libgtk2.0-0 amd64 2.24.25-3
I am always pulling and building from the latest atom git repo.
Here is the log:
/usr/local/bin/atom: line 98:  8718 Segmentation fault      nohup "$ATOM_PATH" --executed-from="$(pwd)" --pid=$$ "$@" > "$ATOM_HOME/nohup.out" 2>&1
[8718:0305/112908:ERROR:browser_main_loop.cc(164)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on.
MESA-LOADER: could not create udev device for fd 13
ATTENTION: default value of option force_s3tc_enable overridden by environment.
[8747:0305/112908:INFO:renderer_main.cc(211)] Renderer process started
App load time: 217ms

[8718:0305/112927:INFO:CONSOLE(175)] "Upgraded the following syntax theme selectors in `.atom/packages/monokai-extended/index.less` for shadow DOM compatibility:

`.editor, .editor .gutter` => `:host, :host .gutter`
`.editor.is-focused .cursor` => `:host(.is-focused) .cursor`
`.editor.is-focused .selection .region` => `:host(.is-focused) .selection .region`
`.editor.is-focused .line-number.cursor-line-no-selection, .editor.is-focused .line.cursor-line` => `:host(.is-focused) .line-number.cursor-line-no-selection, :host(.is-focused) .line.cursor-line`
`.editor .gutter .line-number.git-line-added, .editor .gutter .line-number.git-line-modified, .editor .gutter .line-number.git-line-removed` => `:host .gutter .line-number.git-line-added, :host .gutter .line-number.git-line-modified, :host .gutter .line-number.git-line-removed`

See the upgrade guide for information on removing this warning.", source: /usr/local/share/atom/resources/app/src/styles-element.js (175)
[8718:0305/112932:ERROR:browser_main_loop.cc(210)] Gdk: Offscreen windows not supported with native-windows gdk
[8718:0305/112932:ERROR:browser_main_loop.cc(210)] Gdk: IA__gdk_window_set_user_data: assertion 'GDK_IS_WINDOW (window)' failed
[8718:0305/112932:ERROR:browser_main_loop.cc(210)] Gtk: IA__gtk_style_attach: assertion 'window != NULL' failed
[8718:0305/112932:ERROR:browser_main_loop.cc(210)] Gtk: IA__gtk_style_set_background: assertion 'GTK_IS_STYLE (style)' failed
[8718:0305/112932:ERROR:browser_main_loop.cc(210)] GLib-GObject: g_object_ref: assertion 'G_IS_OBJECT (object)' failed
[8718:0305/112932:ERROR:browser_main_loop.cc(210)] Gtk: IA__gtk_style_attach: assertion 'window != NULL' failed
[8718:0305/112932:ERROR:browser_main_loop.cc(210)] Gtk: _gtk_style_peek_property_value: assertion 'GTK_IS_STYLE (style)' failed
Crash dump id: 3b8d71ca-c401-4229-9a00-e206b7664cd8

If you need any other information, please let me know.

one more thing: starting atom in safe mode won't help--either when closing the changed file with Ctrl-W or when quitting atom, I will still get a segmentation fault.

Wow! I finally found the key: unset GDK_NATIVE_WINDOWS and it will work! Eclipse needed that many years ago and I still had it set.

I get this issue on Windows when I swap branches in git and then close a file that no longer exists.
The correct message appears as follows.
'' has changes, do you want to save them?
Your changes will be lost if you close this item without saving.
Options are ,  and <don't save>
If I choose <don't save> then all open Atom windows crash! It is not consistent, I cannot reliably reproduce it.


[Bug] Major issues with Explore and Marketplace buttons

When the Explore or Marketplace buttons are enabled and not left-aligned, they act as a clone of the Create button and duplicate the Issues & Pull requests buttons for each:
Screenshot
Explore + Marketplace - Happy Medium (Custom):

DevTools log
   GitHub Custom Global Navigation.user.js:957 GitHub Custom Global Navigation: Running
⛔ GitHub Custom Global Navigation.user.js:962 GitHub Custom Global Navigation: Selector '#issues-div' not found
    logError @ GitHub Custom Global Navigation.user.js:962
    cloneAndFlipElements @ GitHub Custom Global Navigation.user.js:1532
    flipIssuesPullRequests @ GitHub Custom Global Navigation.user.js:1612
    updateHeader @ GitHub Custom Global Navigation.user.js:999
    applyCustomizations @ GitHub Custom Global Navigation.user.js:4056
    observeAndModify @ GitHub Custom Global Navigation.user.js:4145
   GitHub Custom Global Navigation.user.js:957 GitHub Custom Global Navigation: Complete
⛔ GitHub Custom Global Navigation.user.js:962 GitHub Custom Global Navigation: Selector '#issues-div' not found
    logError @ GitHub Custom Global Navigation.user.js:962
    cloneAndFlipElements @ GitHub Custom Global Navigation.user.js:1532
    flipIssuesPullRequests @ GitHub Custom Global Navigation.user.js:1612
    updateHeader @ GitHub Custom Global Navigation.user.js:999
    applyCustomizations @ GitHub Custom Global Navigation.user.js:4056
    observeAndModify @ GitHub Custom Global Navigation.user.js:4145
   GitHub Custom Global Navigation.user.js:957 GitHub Custom Global Navigation: Complete

Raw log: github.com-1700691545138.log

Enabling "Align left" for the button(s) will cause the page to hang for ~10s and make a ton of duplicated elements:
Screenshots
Explore + Marketplace + Align Left - Happy Medium (Custom):

Explore + Marketplace + Align Left - Old School (Default):

DevTools log (removed childList spam): https://hastebin.skyra.pw/nulosovamo.php
Raw log: github.com-1700693391774.log

Tested on:

Brave Nightly 1.62.73 (Chromium 119.0.6045.163) + Violentmonkey BETA 2.16.1
Ungoogled Chromium 119.0.6045.159 + Violentmonkey 2.16.0

Thanks for reporting! I'll take a look.

Looks like GitHub code changes are responsible for this. For reference, there used to be a div wrapper around the a and tool-tip tags of the Issues and Pull requests links. The removal breaks things.
I'm working on a fix that also includes some failure checks for better handling. Though worth noting this is enough of a breaking change that it wasn't particularly avoidable, save for not cloning existing elements to create new ones. I've opted for that approach for consistency.

@JunkiEDM If you'd like to test the fix I've been working on, here's the file: https://github.com/blakegearin/github-custom-global-navigation/blob/fix-2/src/github-custom-global-navigation.user.js
I'll probably merge it in 1-2 days pending your response and some further testing on my end.


Slow query response times on high cardinality shards

Tested on 1.2.1-rc5.
3.6 million points on 3.6 million series, in a single shard. Timespan of all data 2 hours.
8 core machine with 64GB RAM, not limited by IOPS.
Query response times are too slow (50sec + ) on the following schema:
Point format:
test_series,cmne=val_0,dst_ip=val_0,dst_port=val_137,fac=val_18,host=val_906,prog=val_50,sev=val_1,src_ip=val_612,src_port=val_163 count=8

/var/lib/influxdb/data/test_db/autogen/2# ls -alh
total 726M
drwxr-xr-x 2 influxdb influxdb 4.0K Mar  8 11:08 .
drwx------ 3 influxdb influxdb 4.0K Mar  8 10:56 ..
-rw-r--r-- 1 influxdb influxdb 665M Mar  8 11:01 000000002-000000002.tsm
-rw-r--r-- 1 influxdb influxdb  61M Mar  8 11:08 000000003-000000001.tsm

> show field keys
name: test_series
fieldKey fieldType
-------- ---------
count    float

> show tag keys
name: test_series
tagKey
------
cmne
dst_ip
dst_port
fac
host
prog
sev
src_ip
src_port

Response type for a simple count:
~# time influx -database "test_db" -execute "select count(count) from test_series"
name: test_series
time count
---- -----
0    3600000
real	0m52.624s

cpu profile from the system generated by @e-dard
cpu.pprof.gz

@kostasb hey, did you solve it?


Disordered icon alignment when the vertical separator is set to the bar

Describe the bug
After setting the vertical separator to the normal <bar> character via this set fillchars=vert:\| in init.vim, the vertical separator and the icons are disordered.

See, the bar separators are placed between the icons and the symbol names.
However, if I don't set the vertical separator, no issues there

System information

OS: masOS 12.3
Neovim version: NVIM v0.7.0-dev+1130-g11f7aeed7
AerialInfo:

Aerial Info
-----------
Filetype: vim
Configured backends:
  lsp (supported) (attached)
  treesitter (supported)
  markdown (not supported) [Filetype is not markdown]
Show symbols: all symbols

Aerial config:
The default config. I only adjusted the key mappings.

To Reproduce
Steps to reproduce the behavior:

In init.vim, set set fillchars=vert:\|
Then in a buffer with lsp enabled, run :AerialToggle!

Thank you very much.

Based on the screenshots, I think this is an unfortunate interaction between the patched font icons and your terminal. As a check, try replacing the out-of-order icon with T or some other basic character. If it displays as expected, then it's the icons.
I am no expert on terminals or font rendering, but my understanding of patched icon fonts is that they replace some range of characters outside the normal western set. Unfortunately, the characters they are replacing do have an actual purpose in unicode, and what's worse is that they can sometimes have unusual layout effects. Things like a zero-width space or right-to-left override. I suspect that the unicode value for that particular icon has a non-normal layout and your terminal is trying to respect that, resulting in the weird display.
Some ideas for workarounds:

Use a different icon for that symbol
Try out a different value for fillchars vert (maybe ┃?)
Try a different terminal
Put a space before the icon

Thank you so much for your quick response. I tried another terminal iTerm2 and no issues there, so it is definitely caused by kitty, the terminal I am using. Hello @kovidgoyal, could you please take a look at this and see whether it can be solved on kitty's side. Please forgive me my offensive calling here.
BTW,

try replacing the out-of-order icon with T or some other basic character
Use a different icon for that symbol
Put a space before the icon

Stupid question here: how to change the icon? I tried many ways (like icons = { Field = "T" }) but failed. Btw, I have both lspkind and devicon plugins installed.
Thanks a lot.

If you have lspkind installed aerial will use that for icons. Change it with
require('lspkind').init({
  symbol_map = {
    Field = " ",
  }
})

Okay I got it. Thank you.

Thank you for the updates. Btw, I updated kitty to the latest version 0.25.2 and I found this issue was gone without setting force_ltr yes.

Excellent!


Support kustomization object could only apply namespace scope resources, and only deliver to that namespace

For security perspective, when we use the kustomization-controller , user will create clusterrole or other clusterscope resources, very easy to lost control.
Could it possible to support kustomization object could only apply namespace scope resources, and only deliver to that namespace?
Even we setup the ServiceAccountName in one kustomization object, when the kustomization object is monitor another gitrepository and kustomization, then the next kustomization object have no ServiceAccountName, still have deploy clusterscope resource.
How to enhance?

Close for ServiceAccount can limit and can recursive to next kustomization obj.


Http token provider

Makes it possible to supply the google service account from not only files.

ping @TimWSpence

Apologies for the slow reply @hamnis. I'm not familiar with Google auth but will have a look or try to find someone who is

Thanks again @hamnis. Apologies for being so slow to reply. If it's ok, can we hit pause on this for a little bit? We're in the process of open-sourcing an internal Google auth library which we believe covers this usecase. I'll update you when it's done and we can can see if it does what you need?

@TimWSpence sure. we just wanted to not having to write to a file. We have a workaround for now. There is no real rush on this.

@TimWSpence https://github.com/permutive-engineering/functional-google-clients/pull/6 Maybe this can be used here now?


Clarify health check behavior in case of failures

This PR aims to clarify health check behavior and implementation guidance since https://github.com/dotnet/aspnetcore/pull/21175.

Document preference for context.Registration.FailureStatus to HealthCheckResult.Unhealthy in case of failure. This allows to not overwrite the defined status.

Document framework behavior in case of a health check throwing exception.

Not sure about my xref:something markdown syntax being perfectly correct..
Any feedback welcome!

Hello @mfkl ... Thanks for sending this in, but we can't accept this in its present form because these product updates are for >=5.0 and the topic covers >=3.0 and <3.0 (i.e., we'll need a full >=5.0 copy of the 3.x content and then only have the updates applied to that versioned content, leaving the 3.x content as it is). It's usually best first to discuss the changes on an issue first for non-trivial updates, where we can provide the versioning guidance for the PR. Fortunately here, the code is in the doc and not cross-linked from the sample app ... it's more painful when there's sample app code to work with.
To adjust this PR ...

Copy all of the 3.x content into a new >=5.0 section added to the top of the topic.
The moniker range for the 3.x content (where it has ::: moniker range=">= aspnetcore-3.0" now) becomes the middle section of content with a moniker range of ...
::: moniker range=">= aspnetcore-3.0 < aspnetcore-5.0"

Only apply your updates to the new >=5.0 versioned content.

If you don't want to make these updates to this PR, close this PR and open a new issue for the topic from the This Page feedback button+form at the bottom and mention this closed PR in your issue comment. One of the doc authors will work the issue.

Moved to https://github.com/dotnet/AspNetCore.Docs/issues/21848.


Cannot allocate memory symbolic tensor shape [T.Any(), 3, 224, 224] [Bug]

when I use tvmc ,something error occurred:
wget https://github.com/onnx/models/raw/main/vision/classification/resnet/model/resnet50-v2-7.onnx
tvmc compile --target "llvm"   --output resnet50-v2-7-tvm.tar  resnet50-v2-7.onnx

WARNING:autotvm:One or more operators have not been tuned. Please tune your model for better performance. Use DEBUG logging level to see more details.
Traceback (most recent call last):
  File "/root/anaconda3/envs/tvm-build/bin/tvmc", line 33, in <module>
    sys.exit(load_entry_point('tvm==0.13.dev217+g2d2b72733', 'console_scripts', 'tvmc')())
  File "/projects/tvm/python/tvm/driver/tvmc/main.py", line 118, in main
    sys.exit(_main(sys.argv[1:]))
  File "/projects/tvm/python/tvm/driver/tvmc/main.py", line 106, in _main
    return args.func(args)
  File "/projects/tvm/python/tvm/driver/tvmc/compiler.py", line 217, in drive_compile
    **transform_args,
  File "/projects/tvm/python/tvm/driver/tvmc/compiler.py", line 421, in compile_model
    workspace_pools=workspace_pools,
  File "/projects/tvm/python/tvm/driver/tvmc/compiler.py", line 491, in build
    workspace_memory_pools=workspace_pools,
  File "/projects/tvm/python/tvm/relay/build_module.py", line 372, in build
    mod_name=mod_name,
  File "/projects/tvm/python/tvm/relay/build_module.py", line 169, in build
    mod_name,
  File "/projects/tvm/python/tvm/_ffi/_ctypes/packed_func.py", line 238, in __call__
    raise get_last_ffi_error()
tvm._ffi.base.TVMError: Traceback (most recent call last):
  15: TVMFuncCall
  14: tvm::relay::backend::RelayBuildModule::GetFunction(tvm::runtime::String const&, tvm::runtime::ObjectPtr<tvm::runtime::Object> const&)::{lambda(tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)#3}::operator()(tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*) const
  13: tvm::relay::backend::RelayBuildModule::Build(tvm::IRModule, tvm::runtime::Array<tvm::Target, void> const&, tvm::Target const&, tvm::relay::Executor const&, tvm::relay::Runtime const&, tvm::WorkspaceMemoryPools const&, tvm::ConstantMemoryPools const&, tvm::runtime::String)
  12: tvm::relay::backend::RelayBuildModule::BuildRelay(tvm::IRModule, tvm::runtime::String const&)
  11: tvm::runtime::PackedFuncObj::Extractor<tvm::runtime::PackedFuncSubObj<tvm::relay::backend::GraphExecutorCodegenModule::GetFunction(tvm::runtime::String const&, tvm::runtime::ObjectPtr<tvm::runtime::Object> const&)::{lambda(tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)#2}> >::Call(tvm::runtime::PackedFuncObj const*, tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)
  10: tvm::relay::backend::GraphExecutorCodegen::Codegen(tvm::IRModule, tvm::relay::Function, tvm::runtime::String)
  9: tvm::relay::GraphPlanMemory(tvm::relay::Function const&)
  8: tvm::relay::StorageAllocator::Plan(tvm::relay::Function const&)
  7: tvm::relay::ExprVisitor::VisitExpr(tvm::RelayExpr const&)
  6: tvm::relay::ExprFunctor<void (tvm::RelayExpr const&)>::VisitExpr(tvm::RelayExpr const&)
  5: tvm::relay::transform::DeviceAwareExprVisitor::VisitExpr_(tvm::relay::FunctionNode const*)
  4: tvm::relay::StorageAllocaBaseVisitor::DeviceAwareVisitExpr_(tvm::relay::FunctionNode const*)
  3: tvm::relay::StorageAllocaBaseVisitor::CreateToken(tvm::RelayExprNode const*, bool)
  2: tvm::relay::StorageAllocator::CreateTokenOnDevice(tvm::RelayExprNode const*, tvm::VirtualDevice const&, bool)
  1: tvm::relay::TokenAllocator1D::Alloc(tvm::relay::StorageToken*, long)
  0: tvm::relay::TokenAllocator1D::GetMemorySize(tvm::relay::StorageToken*)
  File "/projects/tvm/src/relay/backend/token_allocator.cc", line 41
TVMError:
---------------------------------------------------------------
An error occurred during the execution of TVM.
For more information, please see: https://tvm.apache.org/docs/errors.html
---------------------------------------------------------------
  Check failed: (pval != nullptr) is false: Cannot allocate memory symbolic tensor shape [T.Any(), 3, 224, 224]

relay doesn't support dynamic inputs abd here is the batchsize. I'm also new to TVM, after some searching I found that relax can handle dynamic shape inputs now. But I haven't found a working example yet.

You don't need Relax if it is a simple dynamic shape like dynamic batch. TVMC apparently supports compiling and running with Relay VM, that's what you need here.
https://github.com/apache/tvm/pull/10722


Implement cleaner URLs for Category & Date

Category URLs run counter to what we now refer to as clean URLs. I would like to see this:
blog/CategoryView,category,Security.aspx
blog/monthview.aspx?year=2016
... more RESTful:
blog/category/security
blog/year/2016
This change should be applied via config file (on by default for new users). This should be implemented with a redirect from old categories (HTTP 301).
"ASP.NET routing enables you to use URLs that do not have to map to specific files in a Web site. Because the URL does not have to map to a file, you can use URLs that are descriptive of the user's action and therefore are more easily understood by users."
Exactly what we are doing, I assume with HttpModules, which may be fine, it is probably worth a look.

I think we can achieve this with web core integration, started looking at this here:
https://github.com/poppastring/dasblog/tree/webcoreintegration


Remove circular include between core/typedefs.h and core/error_macros.h

There is a circular dependency between core/typedefs.h and core/error_macros.h. This patch removes that dependency. I've also included core/error_macros.h in those files that needed it.

Thanks!


subject_token_type for Replacement Txn-Token Request

In 7.5.2:

To request a replacement Txn-Token, the requester makes a Txn-Token Request as described in Section 7.1 but includes the Txn-Token to be replaced as the value of the subject_token parameter.

Does this assume that subject_token_type should be urn:ietf:params:oauth:token-type:txn_token? Should we call it out explicitly?

Also, do other parameters (audience, scope, request_context) make sense in the context of TraT replacement flow? (I believe they don't, as they are meant to remain constant for the whole invocation chain.)
Should we call out that they must be ignored in the replacement flow?


Candidate dependency-management deprecations and behaviour changes

This Epic is a bucket of dependency-management things we could consider deprecating.

Adapted title to reflect deprecations will happen after 5.0

This is no longer used to track any work.


Select/MenuItem hover effect broken after material-ui/core v4.8.3

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
Hover effect is not working when MenuItem(s) are shown and mouse is hovered over them.
Expected Behavior 🤔
Hover effect to be working properly. As it does up until version 4.8.3 of material-ui/core
Steps to Reproduce 🕹
https://codesandbox.io/s/loving-maxwell-sk147?file=/src/SimpleSelect.js
Steps:

Add material-ui/core version 4.9.0 and above to your project
Setup Select component with MenuItem(s)
Click Select component to show the MenuItem(s)
Hover over the MenuItem(s) to see that hover effect is not working.

Context 🔦
User experience is affected as because of this issue user doesn't receive feedback upon hovering over menus. Therefore the user can not see what they will be selecting before clicking on it.
Your Environment 🌎
Browsers Used: Microsoft Edge and Brave

`npx @material-ui/envinfo`
  System:
    OS: Linux 5.4 Ubuntu 20.04.2 LTS (Focal Fossa)
  Binaries:
    Node: 16.5.0 - ~/.nvm/versions/node/v16.5.0/bin/node
    Yarn: Not Found
    npm: 7.19.1 - ~/.nvm/versions/node/v16.5.0/bin/npm
  Browsers:
    Chrome: Not Found
    Firefox: Not Found
  npmPackages:
    @material-ui/core: ^4.11.2 => 4.11.2
    @material-ui/icons: ^4.11.2 => 4.11.2
    @material-ui/styles:  4.11.2
    @material-ui/system:  4.11.2
    @material-ui/types:  5.1.0
    @material-ui/utils:  4.11.2
    @types/react:  17.0.0
    react: ^17.0.1 => 17.0.1
    react-dom: ^17.0.1 => 17.0.1

Thanks for the feedback.
I can't reproduce this issue on Chrome 92 or Edge 80. What specific version of Edge reproduces the problem for you?
Can you reproduce the issue on v5: https://next.material-ui.com/components/selects/#basic-select?

I'm seeing the issue on Edge Version 92.0.902.73. Would you be able to create a sandbox for me to test?
Below is a short gif that shows the issue on the codesandbox link I shared above but the issue doesn't show on the v5 link you shared.

I'm seeing the issue on Edge Version 92.0.902.73. Would you be able to create a sandbox for me to test?

https://codesandbox.io/s/glml5?file=/demo.js

I'm seeing the issue on Edge Version 92.0.902.73. Would you be able to create a sandbox for me to test?

https://codesandbox.io/s/glml5?file=/demo.js

Still the same thing. Please see the gif at this link for demo: https://i.ibb.co/ky7xkhT/Issue-Demo.gif

You said that you're on OS: Linux 5.4 Ubuntu 20.04.2 LTS (Focal Fossa) but reproduced the issue with Edge.
Were you on an actual Windows machine or did you use an emulator like browserstack.com?


Create newsletter with ConvertKit

GanttStart: 2020-07-31
GanttDue: 2020-08-01

ConvertKit is setup, but I'm needing some help from support to finish the form.


Allow markdown in paramater descriptions

I want to be able to document query parameters like this:

To be able to do this I would need markdown support for description in parameters.

The parameter descriptions support markdown. Are you having issues getting it working?

Very odd. I couldn't get it to work yesterday so I pulled out all the markdown from my descriptions. Now I just go and try again and it works and I can't recreate it. Not sure what happened, I'll re-open if I can recreate in future. Thanks for clarifying.


Jax installation for GPU

The Jax pip installation only comes with the CPU version of Jax. Is this intended?
pip install adam-robotics[jax]

fyi @Giulero @flferretti

By default, the installation of JAX comes with the CPU version of jaxlib. If you're interested in the GPU version, I'd suggest to install it as per the JAX documentation:
pip install --upgrade "jax[cuda12_pip]" -f https://storage.googleapis.com/jax-releases/jax_cuda_releases.html ```

Personally I am aware of the installation process for using the GPU with Jax. I just wanted to point this out so that others are not confused when their code is not as fast as they hoped.

Personally I am aware of the installation process for using the GPU with Jax. I just wanted to point this out so that others are not confused when their code is not as fast as they hoped.

Good point, would you be interested (if it is ok for the mantainer @Giulero) to add a sentence in the readme warning about this and perhaps linking to https://github.com/google/jax#instructions ?

Thanks @stergiosba for opening the issue! @flferretti is right.
Yes @traversaro, I agree!

I guess this is solved. Closing!

As an additional info for anyone finding this via Google, since ~May 2025 the jax package on conda-forge on Linux amd64 by default installs a working GPU-enabled jax, i.e.:
conda create -n adamjax -c conda-forge adam-robotics jax

on a linux-64 system with a working NVIDIA driver installation install a GPU-power jax out of the box.


Fix 500 error for addons that have not migrated to external accounts

While trying to manually test osf.io/#5532, encountered an error. This implements the fix discussed with @mfraezz via flowdock; I have not run tests on this yet. The page does load with the fix- it simply excludes the "Accounts" field from links section entirely.
Error report below:
Tried to manually test, and got this error at /v2/users/me/addons/, for a user with one of basically everything connected to a project.
AttributeError: AddonFigShareUserSettings object has no attribute external_accounts
[06/May/2016 13:24:56] "GET /v2/users/me/addons/ HTTP/1.1" 500 59

Matt indicates that figshare had not yet been migrated to the new external accounts structure.

Implemented something similar, thanks for the PR 🍊


Initial Publish - Alpha [semver:minor]

Initial Publish - Alpha [semver:minor]

Initial Publish - Alpha [semver:minor]


Add multi-stage dockerfile

Fixes #553 at least for me. This is much faster on both macOS and Windows (it also removes the WSL requirement on Windows as you can now build with docker build .), and thanks to cargo-chef, it has much better caching. This doesn't touch the CI infra, as I figured it would be better to build up the support needed first.
@markmandel is there anything else we need to include in the image other than the binary?

This is very interesting! This does remove several of the benefits of having the split container image build pipeline, but I also get the desire to have a faster iterative loop.
This also gives me an interesting idea on how to maintain the incremental cache on build-image powered Docker builds, without it running into and invalidating incremental changes on local builds and vice versa (which I've also run into a lot).
I'll give it a shot on my end, and we can compare and contrast approaches.

This does remove several of the benefits of having the split container image build pipeline, but I also get the desire to have a faster iterative loop.

What benefits are you thinking of? This essentially is that, you can stop the build at any of the FROM stages with the --target command.

What benefits are you thinking of?

The binary that is generated by this file is now different from the one you ship with release (they are likely the same, but small differences can be the thing that gets you)
You now have two images rather than one you have to keep in line with each other in terms of dependencies and build toolchains etc.
I would be curious to see what the image size difference is.
Development toolchain now deviates, as it's stepping away from the Make system, which is a harder onboarding path than having a single toolset (although it could be pulled back in) for new developers.
To make an entire build you are building a binary twice - once through the build image, and then again through the multi-step image.
I would want to see it work with a distroless image (small vulnerability surface), like we have now but I expect that would be possible.

I'm going to also have a go at adding a BUILD_LOCAL argument that will work across targets for the Makefile as well, which in combination with the incremental changes I made in #561 should bring us to basically the same place as this, as one could choose which version of optimisation they would like, depending on their setup, without having to deviate from a single development toolchain (which also provides an incremental onboarding, as they can start with straight make + docker, and adjust if they see fit as they get more involved with the project).

Okay, I should clarify few things, in general I’m largely in agreement with you, this PR is just currently divergent because I started with the simplest image that could work, but we should align this with what we currently have.

The binary that is generated by this file is now different from the one you ship with release (they are likely the same, but small differences can be the thing that gets you)
You now have two images rather than one you have to keep in line with each other in terms of dependencies and build toolchains etc.

This should be changed so it’s one and the same.

Development toolchain now deviates, as it's stepping away from the Make system, which is a harder onboarding path than having a single toolset (although it could be pulled back in) for new developers.

Well like the above, we should just have the current make commands use this dockerfile for its builds, so if you’re someone who’s using Make, there’s zero changes to you.
I will also again note that this project will (and does) have a higher number of potential contributors on Windows, and make does not natively work on Windows. While WSL is an option it’s not always the best experience. For example; this repo has terrible git performance on WSL due the presence of submodules. CMake is not really a great option either for what we’re doing which is just a task runner.
Since you can already develop cross platform without make because of cargo, I think it makes sense that Unix is also not a requirement for building a image, especially for once-off or infrequent contributors where docker build . is something they already know, where as they have to learn what make commands they can use. Having make is great for CI and repeat contributors who need to do more tasks repeatedly that are more complex than simply just “give me an image of the project”.

I would be curious to see what the image size difference is.
I would want to see it work with a distroless image (small vulnerability surface), like we have now but I expect that would be possible.

The image is currently ~38MB according to GCR, again the reason for Debian was just because I know GLIBC works with Rust there with no changes. Changing to distroless is no problem.

To make an entire build you are building a binary twice - once through the build image, and then again through the multi-step image.

This one I’m confused about, this multi-stage image removes the need for the build image, because that’s essentially what all the stages before the final one is, build images that prepare and compile the binary. We can have more stages that extra info or args for compiling different platforms.
I’ll also just note separately that we’ve run into strange issues with the the build image step that we haven’t been able report because we haven’t found anything actionable or concrete (also some of them I thought was just me, but have seen other people report them recently.) Things like running into illegal instruction kills on macOS or just stopping with no error output on WSL.

This should be changed so it’s one and the same.

In theory, we could pull the linux binary from the image -- but then it does diverge from how we build the Windows binary (although we build the macOS binary is a different way as well).
The build-image is handy because it encapsulates all the tooling we use - from mdbook, htmltest, gcloud, etc -- having that all in one place makes a lot of tasks very easy to implement -- so if we have a multi-stage docker image, I don't think we can ever get away from maintaining multiple images to keep them all in sync (this is why I've generally stayed away from multi-stage images where you are publishing both binaries and container images).

will also again note that this project will (and does) have a higher number of potential contributors on Windows being a gamedev related project, and make does not natively work on Windows.

That is a 100% valid point for sure. I see other infrastructure projects (K8s, etc) use Make + Docker, and require Windows users to use WSL, but I expect it's a much smaller number of Windows contributors in those parts.
Slightly tangential point on this then - I was digging through cargo extensions and came across:
https://crates.io/crates/cargo-make
If we moved from Make to this (or another cargo based task runner extension), I'm also wondering if that would potentially move Windows users off of the need for WSL, which will hopefully fix much of t he issues?
Since people are will have cargo installed anyway, to install a cargo plugin doesn't seem like an onerous ask if it helps with cross platform development. WDYT?

I’ll also just note separately that we’ve run into strange issues with the the build image step that we haven’t been able report because we haven’t found anything actionable or concrete (also some of them I thought was just me, but have seen other people report them recently.) Things like running into illegal instruction kills on macOS or just stopping with no error output on WSL.

Please do report - even if it's just a screen grab of what happened in a "Strange things that happen on macOS" and a "strange things that happen in Windows" issue, so we can collate and see if we can troubleshoot.

In theory, we could pull the linux binary from the image -- but then it does diverge from how we build the Windows binary (although we build the macOS binary is a different way as well).

Why would it diverge? If we setup the build stage of the docker image for cross-compliation we can have the same image build a Windows, Linux, and macOS binary with the only thing "changing" is the target that you provide as an argument to docker build.

The build-image is handy because it encapsulates all the tooling we use - from mdbook, htmltest, gcloud, etc -- having that all in one place makes a lot of tasks very easy to implement -- so if we have a multi-stage docker image, I don't think we can ever get away from maintaining multiple images to keep them all in sync (this is why I've generally stayed away from multi-stage images where you are publishing both binaries and container images).

I'm also not quite sure I understand why we can't do the same here? There's no reason we can't make the chef stage into a generic builder stage that does contain all our tooling that is needed to build the binary and the documentation in later stages. Like the whole benefit of a multi-stage dockerfile is that you are essentially having multiple images work together but it's all in one file so its easy to manage and build off of. For example; for release if we had to include extra licencing or the cargo about page, that can be added as a step after the build-binary step, and for development you can skip those extra steps by saying docker build --target=build-binary ..

Since people are will have cargo installed anyway, to install a cargo plugin doesn't seem like an onerous ask if it helps with cross platform development. WDYT?

Yeah I'm totally in favour of this, I think since you have to have cargo anyway asking someone to run cargo install is totally fine. I even thinking asking them to install another tool is fine, as long it's easy to install and work out of the box, rather than make's "setup MinGW or WSL environment" requirement.
There's a few other ones I know of you might want to have a look at. I have no real preference myself (except maybe a slight preference for earthly because I think it's a cool new technology), so whichever tool you find that works best for you is fine with me.

just A self styled "just" a command runner (also written in rust so can be installed with cargo)
cargo xtask Not a tool, but a pattern for having your project automation defined in Rust and callable with cargo directly.
earthly Markets itself as "what if Make and Docker had a baby".

Why would it diverge? If we setup the build stage of the docker image for cross-compliation we can have the same image build a Windows, Linux, and macOS binary with the only thing "changing" is the target that you provide as an argument to docker build.

That seems like a complicated multi-stage Docker image, but it does seem possible.
The macOS build image is rather complicated, hence it was easier to just use it for mac builds -- I wonder if you used it as a base image that would work, or if it's defaults would overwrite anything else you would want to do.
Maybe a silly question - but do build steps cache between runs? Every time I've tried them I found they didn't, but maybe I've done it wrong? (Docs seems to indicate that they are?)

There's no reason we can't make the chef stage into a generic builder stage that does contain all our tooling that is needed to build the binary and the documentation in later stages.

I think I'd have to see an example of more than building a linux container, to be honest. I'm not sure it would be an good iterative loop, because there is only one level of caching (docker). Also, I'd like to see how you would automate pulling the binary out of the docker image (I'm assuming docker cp ?) -- this is what has kept me from multi-stage builds in general. I've never been able to visualise how they would work in a more complicated workflow that had several requirements above and beyond just building a container as the final artifact.
I'm trying to work out how you would run the agones integration test? How would you get the kubernetes and gcloud credentials into the container? If you wanted to copy them in, you would have to run the docker build command from the root of the home directory, otherwise you couldn't get access.
If you want to do the equivalent of make docs - which runs a process that looks at the mounted documentation, and refreshes the page of the documentation on change, you can't do that either.

I'm trying to work out how you would run the agones integration test? How would you get the kubernetes and gcloud credentials into the container? If you wanted to copy them in, you would have to run the docker build command from the root of the home directory, otherwise you couldn't get access.

I've never been able to visualise how they would work in a more complicated workflow that had several requirements above and beyond just building a container as the final artifact.

To be clear, I'm not proposing we use docker for anything but being a container containing the build tools, and building the final artifacts. Multi-stage Docker is not a replacement for make, it's a replacement for having two seperate docker images and trying to connect them together with make like we have now. We'd still need make or another command runner for actually running that stuff. This would just make it so that docker build . and make build-image produce the same artifact.

That makes sense - I think it's going to get messy, given the variety of artifacts we end up generating.
I think it will take building out a replacement for several targets that we currently have in Make right now to be able to see if it's really viable or not -- as each time I think through a target, I end up getting a little stuck, or run into wrinkles I'm not quite sure are going to work out.
But, working through it, here is a few ways it might work (in my head at least), and the ramifications therein:
Rust + General build Images
We have three active images - one for Rust + Containe building (Dockerfile in root of project), and a second one in ./build/build-image, which has everything else.
./Dockerfile:

Builder step with Rust installed, cargo, and related cargo tooling we use, i.e. cargo-chef, clippy, mdbook, cargo-about, etc.
g++-mingw-w64-x86-64 (for windows compilation), libssl-dev, etc
Cargo target for x86_64-pc-windows-gnu
Container step for make the actual container

Mac binary builder:

Same image we use now for compilation

/build/build-image/Dockerfile

The rest of the tools we use, htmltest, helm, terraform, gcloud, kuebctl

Running through each of the targets,

make test-docs - will require one execution against the rust build image to build the docs, one against the build-image to run htmltest. Not impossible, but an extra context switch, instead of one command.
make shell wouldn't really be possible, with all the tools in a single place, as rust and everything else are split between two
make test-agones - might potentially break the authentication, as if you are testing against GKE, the kubectl being invoked needs to call gcloud, but we're also trying to run Rust code, and they are in different images now
make docs won't work, since Rust and mdbook is separate from all the python tooling. Maybe we should bring it all together at this point.
make build-all-binaries - we will likely have three paths now to build binaries, rather than two (which are at least closely relatied)  (1) Linux - make the container and docker cp out, (2) Windows - use the rust build image and mount in the code to build it (or maybe a different container profile from the builder is another way? Seems like a waste to build a container you would never use)  (3) Mac - use the Mac build image (which is what we do now, because Mac is hard).

This feels like the wrong approach, as you lose functionality that's very useful.
Build step entirely replaces build-image
TL;DR - any time there was a Make targets that used to use the build image, you need to (simplified) docker build --target=builder --tag=quilkin-build .   to build the same image, as the builder step has everything in /build/build-image/Dockerfile.

I would have to try it, but I am wondering how this would impact image caching on CI. Right now we can use the nightly build-image image as a layer cache for the builder image. I'm assuming you could do the same here as well - but if you can't, it would expand our CI times considerably (and they aren't that fast right now). I'm not totally comfortable with how much control you have over caching of build steps, but experimentation will determine if it's an issue.
make build-linux-binary would copy source in, then docker cp the files out.
make build-windows-binary would use the --target=builder image, and then mount the local files in to it to generate it's binary. The other option would be to create a whole new target in the container image just for the windows binary, that would never produce a container image that would never run, docker cp the file out and delete it once done.
make build-macos-binary stays the same, mounting the local files in and generating the binary that way.

So you do end up with a bit of a mix of approaches for doing the same thing here, So we add a bunch of complexity to our build tooling -- but maybe it's worth it just for the container image build time.
Wondering if the fixes in #561 and #564 mitigate the image building speed issue, such that we could maintain (relative) consistency between each build artifact construction (particularly around building binaries) -- I'd be curious to know what your tests on Windows and/or Mac have produced.


Is there any way to redirect to some other page after successful login by using cookie based Auth?

I am using cookie based authentication and  I am trying to login and redirect the flow to some other page for eg. User Home once the login is successful.
Currently login route is setting the JWT token in cookie and returning None as Response show in below part of code.
   `async def get_login_response(self, user: BaseUserDB, response: Response) -> Any:
        token = await self._generate_token(user)
        response.set_cookie(
            self.cookie_name,
            token,
            max_age=self.lifetime_seconds,
            path=self.cookie_path,
            domain=self.cookie_domain,
            secure=self.cookie_secure,
            httponly=self.cookie_httponly,
        )

        # We shouldn't return directly the response
        # so that FastAPI can terminate it properly
        return None`

Looking for suggestion on how to redirect on successful login

Found solution in Issue #111


Provide details on DocumentConflictException for CouchDB and do retries in AssetCleaner on 409 for all operations

Description

Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[ ] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[ ] I signed an Apache CLA.
[ ] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

I run PG1 (https://openwhisk-jenkins.swg-devops.com/job/pg1/856/) successfully on this fork/branch


additional test for next epoch num

Issue Number
#1088
Overview

[ ] I have added additional check for the nextEpochNum in the integration test
[ ] added additional test: Calculated next epoch no is the next epoch no

Comments

bors r+

We could adjust the existing test (that uses waitForNextEpoch) to check that we have indeed passed the predicted time t while waiting.

Went for that :point_up_2:  for now. Thx!
Also addressed other review remarks.

Made nextEpochStartTime <= now instead of nextEpochStartTime < now to fix a race condition in test.
bors r+

bors r+

bors r+

bors r+


Ported ServerWarp to 0.7.0 + event hooks

I also took the liberty of making the command names more uniform;
now they all begin with warp e.g. /warplist /warpforce and etc.

@Atkana tested this locally and it worked as expected.  Warps with spaces in the name cause no issues.
:shipit:

Coolio. I'll assume everything's working, then :p


[Bug]: [Python] Dataflow jobs fail if GcsIO initializes credentials

What happened?
https://github.com/apache/beam/pull/23644 (and a partial fix in https://github.com/apache/beam/pull/23677) breaks certain pipelines if gcsio.py initializes credentials first.
gcsio.py currently passes around dictionaries in certain situations instead of PipelineOptions types causing authentication to give up due to the following error:
Unable to find default credentials to use: 'dict' object has no attribute 'view_as'
Connecting anonymously.

This causes pipelines to fail with auth errors:
apitools.base.py.exceptions.HttpUnauthorizedError: HttpError accessing <https://www.googleapis.com/resumable/upload/storage/v1/b/cloud-ml-benchmark-output-us-central/o?alt=json&name=df2-cloudml-benchmark-reddit-small-python-presubmit6%2F10200737556536%2Ftemp%2Fdf2-cloudml-benchmark-reddit-small-python-presubmit6-10200737556536.1666276719.656090%2Fdax-tmp-2022-10-20_07_38_49-7887649702781606893-S27-0-4db7a63035854b2a%2Ftmp-4db7a630358540d1-shard--try-25d98cd94bb07d82-endshard.avro&uploadType=resumable>: response: <{'x-guploader-uploadid': 'ADPycdtyRy7Hq7selxzaj8sF3d21Wdd-BACcWNvpgZ7-Pu7RN1-3G-3UkY2YDcLGQgVQCo7Z-5tZQ7bDORmkMyHSF-gY5ZxUiodV', 'date': 'Thu, 20 Oct 2022 14:47:54 GMT', 'vary': 'Origin, X-Origin', 'www-authenticate': 'Bearer realm="https://accounts.google.com/"', 'cache-control': 'no-cache, no-store, max-age=0, must-revalidate', 'expires': 'Mon, 01 Jan 1990 00:00:00 GMT', 'pragma': 'no-cache', 'content-length': '438', 'server': 'UploadServer', 'content-type': 'text/html; charset=UTF-8', 'status': '401'}>, content <{
  "error": {
    "code": 401,
    "message": "Anonymous caller does not have storage.objects.create access to the Google Cloud Storage object.",
    "errors": [
      {
        "message": "Anonymous caller does not have storage.objects.create access to the Google Cloud Storage object.",
        "domain": "global",
        "reason": "required",
        "locationType": "header",
        "location": "Authorization"
      }
    ]
  }
}

Issue Priority
Priority: 0
Issue Component
Component: sdk-py-core

Also see in: https://ci-beam.apache.org/job/beam_PostCommit_Python_Examples_Dataflow/999/


Azure Training, Model Deployment, CICD Integration

Epic to track ML Ops work related to Model Builder
Training Pipeline

Instructions for Azure Pipeline yaml. Issue 1521

Update to use MBConfig file. BLOCKED On shipping MB CLI update

Add option inside of Model Builder Issue 1606
Data management - BLOCKED Issue 1458: Add dataset support

Model management

How to inspect and determine best model. Training/Test dataset becomes important - Issue 60
Code/command for registering the model.  BLOCKED (external) on Work Item 1141361

Work around: Need to download the model, and then upload it to model registration

Model deployment

https://github.com/dotnet/machinelearning-modelbuilder/issues/1523
https://github.com/dotnet/machinelearning-modelbuilder/issues/1522

See https://github.com/dotnet/machinelearning-modelbuilder/issues/1458 for spec and designs.

Working run with datasets here

Notes on registering models

@luisquintanilla to consolidate into #2146 and #2266


Callback example?

Nice project! Sometimes (not necessarily for multithreading), it makes sense for the app to register a callback in Rust. E.g. I'm using this in native apps to send log messages to be displayed in a logs screen in the app. Could you add an example for this?

Yes, we are using the same thing in our applications here in Frustylogger

PS: it does not work with multithreading, as you cannot call a native dart function from other threads.


amass: 3.19.1 -> 3.19.2

Description of changes
https://github.com/OWASP/Amass/releases/tag/v3.19.2

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 169218 run on x86_64-linux 1

1 package built:

amass


Implement a -f option for commands which may need to tolerate

depreciated configuration files (#66).

is there a unit test you can write for this?  might need to refactor how we are building the commands we pass into the containers so we can check what the command is before executing it.
if its a huge PITA its not required.

Will do.

I think doing this in a meaningful way will require refactoring the argument parsing for all commands. Any objections to handling this along with https://github.com/samsung-cnct/k2cli/issues/46 ?

@davidewatson sounds fine to me.


Added watara supervision

Added a platform config file for Watara Supervision (using the Potator RA Core)

Thanks for adding this collection!

Wow. And thanks for that donation. It means a lot that valuing my works. I really appreciate it. Wish you a nice day.


Add libiconv as a dependency for everything on macOS

I'm not really sure exactly what changed in more recent versions of rustc but now we need this.

@pikajude do we need this?

We will need it for rustc 1.52. Sorry for not responding, I missed your comment.


Paste code to check

It would be nice with an option to paste code to check for sites that are locally hosted or behind firewalls.
So you can just copy & paste the webpage code and lint it.

Thanks for your feedback.
I hope to get this feature asap. :+1:

Would be nice to get in a  option HTTP and  HTTPS, for lazy persons.


Top differences in NumberConsonants and NumberVowels between sister languages in the Oceanic tree

Hi all,
Following our CoOL meeting last week, we have an updated version of phoneme inventories, so I redid the algorithm looking at sister languages in the Oceanic tree (pruned for languages we have phoneme inventories for) and their differences in consonants and vowels numbers.
I have highlighted top four differences for both cases, however, I would only call out this pair as a striking outlier:
18 vowel difference: Aragure_1512 (12) & Canala_19 (30)
ConsonantDifferences29June.pdf
VowelDifferences29June.pdf
@maryewal @antipodite @tihomirrangelov

I can check these against the grammars, will try do today
From: Angela Chira @.>
Reply to: lexibank/abvdoceanic @.>
Date: Monday, 4. July 2022 at 13:40
To: lexibank/abvdoceanic @.>
Cc: Isaac @.>, Mention @.***>
Subject: [lexibank/abvdoceanic] Top differences in NumberConsonants and NumberVowels between sister languages in the Oceanic tree (Issue #48)
Hi all,
Following our CoOL meeting last week, we have an updated version of phoneme inventories, so I redid the algorithm looking at sister languages in the Oceanic tree (pruned for languages we have phoneme inventories for) and their differences in consonants and vowels numbers.
I have highlighted top four differences for both cases, however, I would only call out this pair as a striking outlier:
18 vowel difference: Aragure_1512 (12) & Canala_19 (30)
ConsonantDifferences29June.pdf
VowelDifferences29June.pdf
@maryewal @antipodite @tihomirrangelov
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

I fixed the Malekula profiles and regenerated Angela’s data set with Mary’s changes for Hawaiian and Marquesan. Attached is the latest version. I’ll have to check Aragure tomorrow as I need to do some other stuff now
From: Angela Chira @.>
Reply to: lexibank/abvdoceanic @.>
Date: Monday, 4. July 2022 at 13:40
To: lexibank/abvdoceanic @.>
Cc: Isaac @.>, Mention @.***>
Subject: [lexibank/abvdoceanic] Top differences in NumberConsonants and NumberVowels between sister languages in the Oceanic tree (Issue #48)
Hi all,
Following our CoOL meeting last week, we have an updated version of phoneme inventories, so I redid the algorithm looking at sister languages in the Oceanic tree (pruned for languages we have phoneme inventories for) and their differences in consonants and vowels numbers.
I have highlighted top four differences for both cases, however, I would only call out this pair as a striking outlier:
18 vowel difference: Aragure_1512 (12) & Canala_19 (30)
ConsonantDifferences29June.pdf
VowelDifferences29June.pdf
@maryewal @antipodite @tihomirrangelov
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


Change lowercase l to uppercase L. asp-vb-net.tmLanguage.json

Fixes https://github.com/microsoft/vscode/pull/201981

Closed in favor of https://github.com/microsoft/vscode/pull/201981


⚠ Avatar API Endpoint has degraded performance

In c20e818, Avatar API Endpoint (https://avatar.roblox.com/v1/avatar-rules) experienced degraded performance:

HTTP code: 200
Response time: 3759 ms

Resolved: Avatar API Endpoint performance has improved in d787e84 after 46 minutes.


Use can_hold instead of can_reserve in fn hold

Per title, also tries to use safe math.
It seems to me that #8454 really intended the code to be calling InspectHold::can_hold rather than ReservableCurrency::can_reserve, but perhaps due to merge conflicts, the can_hold call has been clobbered by can_reserve.
Part of #8285 and #8453.

No test?

https://github.com/paritytech/substrate/pull/12004/commits/7a6db84850d68985e51e5fbd662f3bccaa208648 Looks good.

bot rebase

Would appreciate input in terms of logic soundness for can_reserve.
The important differences between the current code and the last review:

keep_alive for can_hold has been reverted as we should never reap the account on hold.
ensure_can_withdraw has been removed from can_reserve as it is a subset of the new logic.
can_hold now takes ExistentialDeposit into account to make sure there is no overdraft.

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2099157

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2099387

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2099388

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2107832

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2107831

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2108464

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2108639

A bit stuck on this one while fixing other pallets, duplicating my post in FRAME Element room for posterity:
Basically, after introducing the change to can_reserve and reserve we have to reserve here https://github.com/paritytech/substrate/blob/493b58bd4a475080d428ce47193ee9ea9757a808/frame/contracts/src/storage/meter.rs#L489 taking into account the ED. .and_then(|_| T::Currency::reserve(contract, *amount - ED)); . I'm not sure it's the correct behaviour. Any insight would be much appreciated.
This also then breaks the refund logic.

This breaks the current implementation of contracts pallet, currently blocked until @athei figures out how we want to go about those changes.

Additional notes:
Modify pallet-balances to take care of the below:
having a non-zero reserved balance should imply a consumer ref.
anything which alters the reserved balance should inc consumer refs when it goes from is_zero() -> !is_zero() and dec the consumer ref when the opposite is
true.

But I'm not sure how this can solve the contracts issue. Because if we only transfer the ED - it will be unreserved and therefore there won't be a consumer ref.

But I'm not sure how this can solve the contracts issue. Because if we only transfer the ED - it will be unreserved and therefore there won't be a consumer ref.

pallet-contracts transfers at least the ED on contract instantiation and then reserves it.

Yeah, but we can't reserve the ED anymore due to the changes in can_reserve (which is called in reserve). Or rather we can, but we still need to have at least ED in free balance.

I thought a while about this any my preferred solution would be that a contract can act as a sufficient for an account. It is a consumer because it depends on the existence of its account (and by extension its balance). But it is also a provider because it takes storage deposit which covers both the existential deposit and the data structures within pallet-contracts.
Up until now this was achieved by transferring this deposit to the contract and reserving it there. This does no longer work with this PR as the existential deposit must be free balance. This issue arises because pallet-contracts is a sufficient only indirectly (by enforcing a certain balance). I think that should change and pallet-contracts should call System::inc_sufficients directly when creating a contract. The workflow I imagine is as as follows:

Contract is about to be instantiated
System::inc_sufficients(contract)
Currency::transfer(caller, contract, storage_deposit)
Currency::reserve(contract, storage_deposit)

Step 4. is where it currently fails because we cannot reserve all the contract's balance as some of it needs to be free. We could work around this by partly leaving some balance free and creating a consumer to prevent the balance to be send away. However, I think that feels a bit weird when part of the deposit is free and some is reserved. Additionally, a storage migration is needed that changes all contract's accounts to have some free balance. This is why I suggest changing the can_reserve logic to the following which would allow the above workflow without a storage migration:
Allow reserving the ED (as it was the case before this PR) but remove the provider created by pallet-balances when doing so. If this would reap the account we won`t allow the reserve because we never want the reserve to kill an account. Not sure if this is a sound solution. Need some more thinking and debate.
Another suggestion made by @gavofyork  is to automatically add a consumer to an account whenever there is a non zero reserved balance. This would also work for contracts as we could send part of the initial balance as free balance as mentioned above. However, this also needs this big storage migration of all existing accounts with reserved balance.

This has been stale for a while as we did not reach consensus on how to proceed with this as far as I understand.
This should fix it: https://github.com/paritytech/substrate/pull/12951

Superseded by #12951.


deriv() returns non-zero values even though my data hasn’t changed

Originally I thought this is a regression, but I see no proof of that — as per syslog, I’ve been using prometheus, version 0.18.0 (branch: stable, revision: f12ebd6) since the 15th of May, and the issue only now started to appear.
I have an alerting rule which looks at changes in state, see https://github.com/robustirc/robustirc/blob/669a278acd264e1e94c7ad8e7a6217be54585488/contrib/prometheus/robustirc_prometheus.rules#L19 for details.
This rule is now firing, even though there weren’t any changes in state.
When having a closer look, it turns out that deriv() returns values that are very close to 0 (e.g. -0.000000000006047549185814796), but not 0.
I ran the following two commands to capture the data and reproduce the issue:
wget -qO- http://localhost:9090/api/v1/query_range\?query\=raft_isleader\{instance\=\"ridcully\"\}\&start\='2016-05-19T18:00:00Z'\&end\='2016-05-19T22:00:00Z'\&step\=15s > /tmp/values.txt
values.txt
wget -qO- http://localhost:9090/api/v1/query_range\?query\=deriv\(raft_isleader\{instance\=\"ridcully\"\}\[10m\]\)\&start\='2016-05-19T20:00:00Z'\&end\='2016-05-19T22:00:00Z'\&step\=15s > /tmp/deriv.txt
deriv.txt
I would have expected deriv() to return 0 in this specific case.
Am I holding it wrong or is this a bug? If the former, do you have any suggestions to improve my alerting rule?

That sounds like floating point inaccuracy, not much we can do about it.
Have you considered using the changes function?

Ah, changes does return 0. Does changes not involve floating point operations, or why does it not suffer from the same inaccuracies as deriv?

On 20 May 2016 at 08:48, Michael Stapelberg<EMAIL_ADDRESS>wrote:

Does changes not involve floating point operations, or why does it not suffer from the same inaccuracies as deriv?

Everything in Prometheus is floating point. changes, however, does
something really simple, while deriv does
https://en.wikipedia.org/wiki/Simple_linear_regression
There are way more chances of running into accuracy issues there.
Björn Rabenstein, Engineer
http://soundcloud.com/brabenstein
SoundCloud Ltd. | Rheinsberger Str. 76/77, 10115 Berlin, Germany
Managing Director: Alexander Ljung | Incorporated in England & Wales
with Company No. 6343600 | Local Branch Office | AG Charlottenburg  |
HRB 110657B

Thanks for the explanation. I’m closing this issue as we found an alternative solution (changes) and can’t do much about floating point inaccuracies.


Fixed gem version

usually in gems it's set to:
gem.version = PublicSuffix::VERSION
now it's set as
gem.version = '1.5.3'
Is this on purpose?

The constant is there.
https://github.com/weppos/publicsuffix-ruby/blob/master/lib/public_suffix/version.rb#L20
I'm not sure I understood your request.

The constant is fixed in the gemspec file https://github.com/weppos/publicsuffix-ruby/blob/master/public_suffix.gemspec#L6

That's because the gemfile is generated by a Rake task.
https://github.com/weppos/publicsuffix-ruby/blob/master/Rakefile#L13
Why is that an issue to you?

Aha, interesting.
I was reading the documentation (which as of now belongs to version 2.0.0, while the latest version on rubygems is 1.5.3), and I was verifying why things wouldn't work for me locally, so I came by the code to check what is the latest version and I saw that line which misled me at first, since it shows 1.5.3 and that matches my local version. Now, things are clear, it seems you didn't upload the new version to Rubygems right?

That's correct. I haven't released the new version yet.


Webpack bundling duplicate React dependencies?

Burned through a bunch of hours trying to troubleshoot this.. seems to be an issue with the webpack config as far as I can tell.  Any help would be greatly appreciated, thanks in advance.
Adding other react modules (ex: react-ui-tree) results in duplicate versions of React which causes invariant violations:
Uncaught Error: Invariant Violation: addComponentAsRefTo(...): Only a ReactOwner can have refs. This usually means that you're trying to add a ref to a component that doesn't have an owner (that is, was not created inside of another component's `render` method). Try rendering this component inside of a new top-level component which will hold the ref.

Very hard to debug but eventually noticed the duplicate React inclusions:
Chads-iMac-5k:electron-react-boilerplate-test Chad$ npm run start-hot

><EMAIL_ADDRESS>start-hot /Users/Chad/Documents/Work/Dev/electron-react-boilerplate-test
> HOT=1 NODE_ENV=development electron .

[3637:0819/163228:INFO:renderer_main.cc(200)] Renderer process started
[3638:0819/163228:INFO:renderer_main.cc(200)] Renderer process started
[3635:0819/163228:INFO:CONSOLE(60)] "[HMR] Waiting for update signal from WDS...", source: webpack:///(webpack)/hot/dev-server.js? (60)
[3635:0819/163228:INFO:CONSOLE(109)] "Download the React DevTools for a better development experience: https://fb.me/react-devtools", source: webpack:///./~/react/lib/React.js? (109)
[3635:0819/163228:INFO:CONSOLE(109)] "Download the React DevTools for a better development experience: https://fb.me/react-devtools", source: /Users/Chad/Documents/Work/Dev/electron-react-boilerplate-test/node_modules/react/lib/React.js (109)
[3635:0819/163228:INFO:CONSOLE(15)] "[WDS] Hot Module Replacement enabled.", source: webpack:///(webpack)-dev-server/client? (15)

To reproduce:
git clone https://github.com/chentsulin/electron-react-boilerplate.git electron-react-boilerplate-test
cd electron-react-boilerplate-test
npm install
npm install react-ui-tree

Edit app/containers/HomePageContainer.jsx to include:
import React from 'react'
import { Link } from 'react-router'
import { Tree } from 'react-ui-tree'
...

Running..
npm run hot-dev-server
npm run start-hot

Tried many things w/o any success:

Adding new webpack.optimize.DedupePlugin(),
Adding an alias react: path.resolve('./node_modules/react')
Etc

Again, thanks in advance for any help.

Oh, because webpack target electron will break some module including socket.io in webpack-dev-server, and then break whole hot loading. Now it's hard to configure which modules we should push into externals, which should not.
Should ignore:

electron built-in (ipc, remote...)
node built-in (see (webpack/node-libs-browser)[https://github.com/webpack/node-libs-browser])
node 3rd party which can't run on browser and electron renderer

Should not ignore:
We will need figure out a new target for webpack, or parser package.json
For now, you can work around it with:
var nodeModules = fs.readdirSync('node_modules').filter(function(x) {
    return x !== '.bin' && x !== 'react' && x !== 'react-router' && 'react-ui-tree';
});

see also #31

Thanks a lot @chentsulin, very helpful and your workaround addressed my problem in the interim.
Looks like a minor typo in your snippet, updating here for anyone else that might find this:
  var nodeModules = fs.readdirSync('node_modules').filter(function(x) {
    return x !== '.bin' && x !== 'react' && x !== 'react-router' && x !== 'react-ui-tree';
  });

Thanks again


fix view parseing problem

What problem does this PR solve?
In this PR, we ignore unknown property in Json when parse table.
What is changed and how it works?
The trick is adding JsonIgnoreProperties annotation.
Check List
Tests

Manual test (add detailed scripts or steps below)

Related changes

Need to cherry-pick to the all release branch

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

do we need to add a test?

@birdstorm I am adding test.

/run-all-tests

blocked by https://github.com/pingcap/tidb/issues/11513

blocked by pingcap/tidb#11513

@zhexuany why is blocked?

@marsishandsome In MySQL, drop table for a view is not validate syntax. Once TiDB adopts this behavior, we have to change our code. I am planning ignore unknown Json property first and add test back till TiDB fix the issue.

scala> spark.sql("use test")
res0: org.apache.spark.sql.DataFrame = []

scala> spark.sql("select * from t").show
+---+
| c1|
+---+
|  1|
+---+

scala> spark.sql("desc t").show
+--------+---------+--------+-------+
|col_name|data_type|nullable|comment|
+--------+---------+--------+-------+
|      c1|   bigint|    true|   null|
+--------+---------+--------+-------+

scala> spark.sql("select * from v").show
+---+-----+
| c1|value|
+---+-----+
+---+-----+

I tested on my machine, it works fine. The test suite will be added if TiDB fixes the bug

/run-all-tests

@zhexuany  I suggest we investigate the issue of Decimal type more carefully.

@marsishandsome @birdstorm  PTAL

/run-all-tests

description may shoud change The trick is adding JsonIgnoreProperties annotation.

/run-all-tests

/run-all-tests

/run-all-tests


Autocomplete doesn't work in"create view" statements

Description

use code:

create view v1 as
select
    *
from actor as a

set cursor after symbol * and try to expand it by pressing Ctrl + Space

Expected: a list of suggestions is shown / or a list of columns is added to a query
Actual: no suggestions in a list
https://github.com/user-attachments/assets/2625c995-8bc7-4530-843f-0b6ee422e422
DBeaver Version
Enterprise Edition 24.2.3-202410122322
Operating System
Windows 10
Database and driver
PostgreSQL 16
PostgreSQL JDBC Driver 42.7.4
Steps to reproduce
No response
Additional context
No response

Thank you for your report.


Added function to toggle user account enabled/disabled

Adding --toggle-enabled flag to enable/disable user accounts.
Great tool, thanks for sharing!

Hello,
Thanks you for the PR. Is it possible to update the C# README with the new help menu and an example ?
:sunflower:

Done, also updated the variable used from "target" to "account" in line with the rest of the functions.

Sorry but can you also update this section of the README with the new help output?

Tested and worked, thanks for the contribution!


support nested paths

For example, allow a single RickView instance to serve both http://www.snik.eu/meta/x and http://www.snik.eu/bb/x.
LodView can do this.

Investigate tail matches, see https://actix.rs/docs/url-dispatch/.


Suggestion: Offline MDI

MD icons are currently loaded from the web. This might cause some issues, like #426 I believe. Also, this is the only resource not bundled with Tileboard. I suggest to include the icons in the bundle, if possible.
It seems, this might be a suitable approach: https://google.github.io/material-design-icons/#icon-font-for-the-web (second method)

I agree. Having icons in a font file is an adequate solution.

We are using https://materialdesignicons.com/ and not the official google funt but it's should be as easy (just need to use npm install @mdi/font and maybe update rollup config to handle font files).

maybe update rollup config

:-) OK... I'll have to leave that to you then.

Yes, that's a font (not an icon font) used by one of the themes. I suppose @resoai wanted a font that can display his language. :) Is it still relevant for you @resoai ?

@rchl Roboto is a nice font in general and being Russian I decided to include Cyrillic subset of letters, so in a way, yeah, this is still relevant :)

This required a fix in rollup plugin but thankfully the auto was responsive and it was integrated and released quickly. :)


How to use verb, verb-cli, etc.

Hi,
I really like the idea of verb and trying to figure out for some days now how all the puzzles fit together.
It would be extremely helpful to get a short overview how everything works (read all the different pages on verb, verb-cli, includes, boilerplates but still not sure by 100%).
What I'd like to achieve:

Use verb and set up at the same time my own doucmentation standards which will just speed up what I am doing (very similar as you @jonschlinkert are describing it ...)
Would like to extend the sample and ideally also to contribute to verb to fully understand it ... typically you don't understand a piece of software by 100% before you start modifying it ;-))

Can you help a bit to ramp up?
Thx a lot! Highly appreciated in advance!
Regards
Stefan

Adding:

I think at the beginning it would be really good to know which pieces of components you are typically installing

verb (locally)
verb-cli (globally)
verb-readme-includes (globally ??)
etc.


Does the redirect URL have to be same domain?

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.32.1
Wrapper Library
Not Applicable
Wrapper Library Version
None
Public or Confidential Client?
Public
Description
I am trying to incorporate MSAL 2 authentication into a PowerApps custom component. PowerApps does not have a stable reply url so I was wondering if any url you have control over will suffice?
So far I created a test node.js web application with the recommended blank.html page and I have added that url to the AAD reply url list. However I am getting error monitor_window_timeout
If I try and do a popup logon I see the iframe gets the redirect to my blank page but then it never gets further than that.
How does that redirect url work in practice? My assumption was that MSAL would consume the redirect message from AAD and extract the code from it, but it seems like it gets passed through to the browser to do a physical redirect. If that is the case how does MSAL get the code?
Is there any hope for me to get a stable URL, with silent SSO, that is not part of my current domain?
MSAL Configuration
No response
Relevant Code Snippets
No response
Identity Provider
Azure AD / MSA
Source
External (Customer)

@camer314 thanks for opening this issue! What are you using as redirecturi?

@bmahall
I am just using a blank page url from a web app I control but not the domain of where I am using it from.
For example, if I am in the PowerApps authoring environment, window.location.ref is:
https://authoring.uk-il102.gateway.prod.island.powerapps.com/v3.22122.15.245107243/embed/
And if I use that as my redirectUri then MSAL works fine. But that url has some variable content so is not guaranteed to remain static, which I have no control over. So I thought maybe I could use a url from a website I own, for example:
https://xxx.azurewebsites.net/blank.html

Thanks @camer314 for providing further information, the redirect URL needs to be on same domain.


Email address update.

Just a change of email address in the AUTHORS file.
Signed-off-by: Martin Redmond<EMAIL_ADDRESS>

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:reds/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Closing, because a new PR was opened https://github.com/docker/docker/pull/23168


[1163] Remove the support_user_revert_withdrawn_offer feature flag

Context
Removing the support_user_revert_withdrawn_offer feature flag as its been active in production since October 2021.
The data migration to remove the feature flag will be done in a follow up.
Changes proposed in this pull request
See commits.
Link to Trello card
https://trello.com/c/73luzRVw/1163-apply-remove-the-supportuserrevertwithdrawnoffer-feature-flag
Things to check

[x] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[x] This code does not rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
[x] API release notes have been updated if necessary
[x] If it adds a significant user-facing change, is it documented in the CHANGELOG?
[x] Required environment variables have been updated added to the Azure KeyVault

 Apply: Remove the support_user_revert_withdrawn_offer feature flag