[Bug] -Path parameter does not write to a file, writes to multiple files

Environmental information
PowerShell version:
Name                           Value

PSVersion                      5.1.17763.592
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.17763.592
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
dbatools Module version:
Name    : dbatools
Path    : (Purposefully removed)\WindowsPowerShell\Modules\dbatools\1.0.49\dbatools.psd1
Version : 1.0.49
SQL Server:
Microsoft SQL Server 2017 (RTM) - 14.0.1000.169 (X64)   Aug 22 2017 17:04:49   Copyright (C) 2017 Microsoft Corporation  Developer Edition (64-bit) on Windows 10 Enterprise 10.0  (Build 17763: )
Report

Host used

[X] powershell.exe
[ ] ISE
[X] VS Code
[ ] Other (please specify)

If anything other than powershell.exe was used, please confirm that you can duplicate the issue with powershell.exe

[X] Still buggy in powershell.exe

Errors Received

Steps to Reproduce
Run:
Export-DbaUser -SqlInstance localhost -Path "C:\Other\localhost-users.sql"
Expected Behavior
A single .sql file called "localhost-users.sql" to be created that contains T-SQL to create all users associated with the databases on that SQL Server instance.
Actual Behavior
Multiple files created with individual timestamps following the default naming pattern in the directory "localhost-users.sql".  Each subsequent file contains the exact same SQL as the previous file, but with SQL to create the "next" user and so on until the last file:
Directory: C:\other\localhost-users.sql

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
-a----        10/3/2019  12:32 PM            577 <computer name>-20191003123256-user.sql
-a----        10/3/2019  12:32 PM            690 <computer name>-20191003123257-user.sql
-a----        10/3/2019  12:32 PM            758 <computer name>-20191003123257-user.sql
-a----        10/3/2019  12:32 PM           5037 <computer name>-20191003123257-user.sql
-a----        10/3/2019  12:32 PM           8202 <computer name>-20191003123258-user.sql
-a----        10/3/2019  12:32 PM           8664 <computer name>-20191003123258-user.sql
-a----        10/3/2019  12:32 PM           8930 <computer name>-20191003123258-user.sql
-a----        10/3/2019  12:32 PM           9058 <computer name>-20191003123258-user.sql

(Some information obscured as this is an issue on a work computer)

I believe you want to use FilePath to get everything into one file.

The documentation for Export-DbaUser has examples with -Path pointing to a single file:
https://docs.dbatools.io/#Export-DbaUser

Example: 1
PS C:\> Export-DbaUser -SqlInstance sql2005 -Path C:\temp\sql2005-users.sql
Exports SQL for the users in server "sql2005" and writes them to the file "C:\temp\sql2005-users.sql"

Further, -FilePath returns the following error:
PS C:\Windows\System32\WindowsPowerShell\v1.0> Export-DbaUser -SqlInstance localhost -FilePath "C:\other\localhost-users
.sql"
Out-File : Access to the path 'C:\other\localhost-users.sql' is denied.
At (Removed intentionally)\WindowsPowerShell\Modules\dbatools\1.0.49\allcommands.ps1:14465
char:24
+ ...      $sql | Out-File -Encoding UTF8 -FilePath $FilePath -Append:$Appe ...
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OpenError: (:) [Out-File], UnauthorizedAccessException
    + FullyQualifiedErrorId : FileOpenFailure,Microsoft.PowerShell.Commands.OutFileCommand

    Directory: C:\other\localhost-users.sql

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
-a----        10/3/2019  12:32 PM            577 <computer name>-20191003123256-user.sql
-a----        10/3/2019  12:32 PM           5037 <computer name>-20191003123257-user.sql
-a----        10/3/2019  12:32 PM           9058 <computer name>-20191003123258-user.sql

Running the above command as an Administrator results in the same exception.
If it should be -FilePath the examples should be updated to reflect this.

Yeah, there are a whole slew of issues with that export to file. I do not get an error though, it simply generates a file that is not valid; when I provide a path name it does not honor the file name.
The Path defaults to a configured path in the module configuration Get-DbatoolsConfig path.dbatoolsexport....believe this is something that was implemented few months ago but can't recall by who right off.
Which when I call this command by default, it fails but with a false error:
[ 19.0ms ][ PS 5.1 ][ 16:49:32 ][ git:development ] C:\git\dbatools                                                                              [3] > Export-DbaUser -SqlInstance 'localhost,1411' -Database sysdb                                                                               WARNING: [16:49:49][Test-ExportDirectory] Path (C:\Users\Shawn Melton\Documents\DbatoolsExport) must be a directory                              WARNING: [16:49:49][Get-DbaDatabase] Error occurred while establishing connection to localhost,1411 | The target principal name is incorrect.    Cannot generate SSPI context.

Provide it a full file to the Path parameter though it does not honor what I provided:
[ 65.0ms ][ PS 5.1 ][ 16:51:22 ][ git:development ] C:\git\dbatools                                                                              [8] > Export-DbaUser -SqlInstance 'localhost,1411' -Database sysdb -Path c:\temp\myscript.sql -SqlCredential $containerCred                                                                                Directory: C:\temp\myscript.sql                                                                                Mode                LastWriteTime         Length Name                                                                                ----                -------------         ------ ----                                                                                -a----       2019-10-03   4:51 PM            412 localhost,1411-20191003165130-user.sql


Syntax error of typo on def is not reported if it's not type annotated.

I happen to find bugs about syntax error reporting of typo on def,val or var,  which are not occurred if method or variable doesn't have type annotation. I assume they should be reported as syntax error even if they're not type annotated
Here are examples of method with typo on def. Behavior of variable with typo on val or var is the same.
scala> val p0 = scalaparse.Scala.CompilationUnit
p0: fastparse.P0 = CompilationUnit

//Reporting typo of `def`, if return type is annotated
scala> p0.parse("object A{def i:Int = 1}",0,true)
res24: fastparse.core.Result[Unit] = Success((), 23)

scala> p0.parse("object A{de i:Int = 1}",0,true)
res25: fastparse.core.Result[Unit] = Failure(CompilationUnit:0 / Body:0 / TopStatSeq:0 / TopStat:0 / Tmpl:0 / ObjDef:0 / DefTmpl:8 / TmplBody:8 / }:17 / "}":18 ..."= 1}", true)

//Not reporting typo of `def`, if return type is NOT annotated
scala> p0.parse("object A{def i = 1}",0,true)
res26: fastparse.core.Result[Unit] = Success((), 19)

scala> p0.parse("object A{de i = 1}",0,true)
res27: fastparse.core.Result[Unit] = Success((), 18)

This is not a bug. Or if it is, it's not my bug. That is perfectly valid Scala:
scala> object de{ var i = 0 }
defined object de

scala> object A{ de i = 1 }
warning: there was one feature warning; re-run with -feature for details
defined object A

scala> de.i
res1: Int = 0

scala> A
res2: A.type = A$@2b4ad817

scala> de.i
res3: Int = 1

I got it. Thanks.


Fix CloudFlare provider to return a single endpoint for each name/type.

#970 adds support for multiple target addresses to the CloudFlare provider. However, CloudFlare does not support "sets" of targets for each DNS name/type pair but instead returns a single entry for each name/type/target. This confuses the planner when calculating the set of changes, leading to #992 - where external-dns recreates the same entries over and over.
This pull request changes the CloudFlare provider's Records() method to group all supported records by name and type, and to return a single endpoint with all the targets for each name/type, allowing the planner to compute the correct set of changes.

CLA signed

/lgmt
WDYT @njuettner  ?

Nice! Thanks for contributing.
/approve

/lgtm


Emoji support

Need for example :D replaces :smile:

Sure. I've got a bit of a backlog on things to add, but I'm working through them.


[BUG] Broken Link in Testimonial GitHub Action

Description
The link to the testimonial guide in the github action leads to an incorrect page! I believe the the correct link to the guide is: https://linkfree.io/docs/how-to-guides/testimonials-json
Screenshots

Additional information
No response

Good spot, thank you 👍

can u assign this to me

I would like to take up this issue

I can fix this issue.

I would like to take up this issue

@sumitunique777 you already have an issue assigned to you.  In accordance with our Contributing Guide we only assign one issue per person.

I can fix this issue.

@AlimurtuzaCodes I have assigned this to you.


ADR: downstream PEP database integration

Enabling downstream PEPs to integrate with the DB
Context and Problem Statement
Downstream PEPs, bundled into the platform, sometimes need to interface with a database. There are a lot of concerns and considerations needed which should be addressed
Modular binary approach to support multiple deployment modalities
The desire to deliver a product which can be deployed as a monolith or in a microservice way via charts yields a number of challenges. Mainly, we need to ensure that services are loosely coupled while cohesion is enforced through gRPC and IPC.
Isolate PEPs
Along with isolation needs to meet the previous concern, we also want to ensure that PEPs have a level of guarantee that their data is only accessed and mutated by their service. Other services and PEPs will be required to use published contracts (i.e. protobuf, openapi, grpc) to interact with the data.
Enforce consistency
It is very important that PEPs are as consistent as possible. This will ensure PEPs are developed with quality software practices in mind, as well as enable engineers to move throughout the platform with minimal onboarding needed.
Decision Drivers

modular-binary to support monolith and microservice deployments
isolate PEPs so that data is protected from unauthorized mutations
enforce consistency among PEPs

Considered Options

Implement a common migration registration and heavily document the PEP development process

Decision Outcome
Chosen option: "{title of option}"

Confirmation

enhance Registration service to support binding the PEP/service migrations with the migration service
refactor Policy service to be fully configured in a way that would simulate the behavior
create an issue: refactor integration tests to support policy as an abstraction -- then move policy integration tests under the policy service

Implement a migration service registration and heavily document PEP development process
In scope:

need to isolate PEPs to a scoped schema

to ensure that they can make guarantees about their data and reduce coupling between PEPs

need to register with the migration handler

isolate migrations to their PEP directory and have them run when migrating up/down
enable any kind of database configuration -- whether strict schema or a simulated key-value store via JSON blobs

document common pattern for wrapping db handler as seen in policy

Out of scope:

how can we create multiple DB clients so that we can handle scoped users to prevent access / mutation of data that is not permissible

by not supporting this, a poisoned PEP could mutate policy data and grant access

non postgres environments

this needs to be solved at the platform level first -- many considerations regarding stored procedures and triggers and JSON data

handling distributive databases

enabling modular binary in ways that are not supported in the current state

any kind of sharding / caching / read replicas

read replicas will depend on the knowledge of multiple databases and db users to ensure the appropriate action is taken on the appropriate database

integration tests

utilizing the same functionality found in the platform to ensure resilient testing
SOLUTION: PEPs should manage their own integration tests and can add those jobs to the workflows

provisioning of fixtures

enable PEP developers to create scenarios within the platform for automated and manual testing
SOLUTION: utilize CLI to use policy as a service

The in scope solution makes sense to me. We will use schemas to drive that separation between PEP and Platform datastores?
I think if we needed stronger guarantees around access then a PEP should run in standalone mode that allows it to have its own connection information.

@strantalis Yes that's correct. Where the platform will most likely have a single schema PEPs will have schemas for themselves. This will allow DB admins to control access and partition the databases easily.
I do wonder if the services also need to use a unique schema. For instance, do we want the risk of KAS accessing Policy DB rather than using the SDK / gRPC interface?

The implementation of this effort was more complicated than originally identified. Additionally, there were some additional efforts that did not pan out and led to the creation of #675


Handlebar JS don't work on evaluating if expressions

If we are on a template/task, we can't do:
{{#if @index == 0}} First Task {{/if}}

GIves the following parse error:
Error running command: Parse error on line 2: ...}}{{#unless @index == 1}}{{/unless}}* [ ----------------------^ Expecting 'CLOSE_RAW_BLOCK', 'CLOSE', 'CLOSE_UNESCAPED', 'OPEN_SEXPR', 'CLOSE_SEXPR', 'ID', 'OPEN_BLOCK_PARAMS', 'STRING', 'NUMBER', 'BOOLEAN', 'UNDEFINED', 'NULL', 'DATA', 'SEP', got 'EQUALS'

Similarly if try to use any condition on if data, we get the same error:
{{#if deadline==@today}}URGENT{{/if}}

Error running command: Parse error on line 2: .../if}}{{#if deadline==@today}}URGENT{{/if -----------------------^ Expecting 'OPEN_SEXPR', 'ID', 'STRING', 'NUMBER', 'BOOLEAN', 'UNDEFINED', 'NULL', 'DATA', got 'EQUALS'

I just checked the Handlebars docs, and it seems that @index == 0 is not a valid Handebars expression. It looks like we may have to define some built-in helpers to do things like equality checks: https://stackoverflow.com/questions/34252817/handlebarsjs-check-if-a-string-is-equal-to-a-value
I can do that though, not hard.

Maybe even using this: https://github.com/helpers/handlebars-helpers#eq


Support of PKCS11

Is there any interest in supporting pkcs11?
I've made it work for the golang.org/x/crypto/openpgp library and it could be interesting to get it in this library.

Hi :wave: Apologies for the late response.
PKCS11 is out of scope for this repository, which (despite the somewhat overly generic name) is focused on OpenPGP.


[DNM] *: move lock manager to server

Signed-off-by: siddontang<EMAIL_ADDRESS>What have you changed?
This is just a simply try, has not finished it yet. And I think @youjiali1995 will complete it later.
Move lock manager from storage to server to let Storage not depend on server and raftstore module.
What is the type of the changes?

Misc (other changes)

How is the PR tested?
Manually test
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No
Does this PR affect tidb-ansible?
No

I think later, we can:

combine Detector and WaiterMgr into just one Trait, like LockMgr
use a better way to handle table is empty, not use a global atomic value.

@youjiali1995

Close it since I filed a new PR: https://github.com/tikv/tikv/pull/5381.


running delete in another thread

I assume that on the UI the user will get a success message straight away even if their is an error, and then will be able to use the ui to request for the same item to be deleted again?

I assume that on the UI the user will get a success message straight away even if their is an error, and then will be able to use the ui to request for the same item to be deleted again?

They'll get a success message as long as the task is handed off to the async executor service without any hiccups. Any errors in deleting the submission won't be seen

I'm going to move the check for an open submission into the sync part so that they can see this error

They'll get a success message as long as the task is handed off to the async executor service without any hiccups. Any errors in deleting the submission won't be seen

In that case please don't merge this for the time being, at least until we can actually get the UI to report these errors when using an async delete.


Green Success Indicator on the Fields is missing.

When the conditions on a Field are initially Required, and then Fulfilled, and the form is SAVED (making it a Clean Form, again, with Saved and Valid Values), Green Success Indicator on the Fields is missing.

Here is a link it will work
https://www.loom.com/share/8d45249353cc448984768949b0dc9a7f
However, we have been missing the functionality in 6.0.0.

Hi @shahidmanzoorzekiexperts, as I mentioned in the last issue, this is working as expected.
Checkout the changelog https://github.com/SelectQuoteLabs/SQForm/blob/master/CHANGELOG.md#bug-fixes-1
5.6.3 (2021-10-08)
Bug Fixes
🐛 Only shows green fulfilled icon if field updated by user (a9747fb), closes #459
In version 5.6.3 the UI/UX team requested we change how the Green Success indicator works. The green success indicated should only appear if the user updates a field.
We no longer show the green success indicator on the initial page load for fields that are initially fulfilled.


make Python optional

related #280 <- #266 <- #231

I don't follow but happy to accept commit suggestions...

I don't follow but happy to accept commit suggestions...

Sorry! My previous comment was too obscure.

Passes GCP, ergo it works.
AWS is broken because I need to update the MFA sandbox credentials with the CI sandbox ones; AZ is broken because of #264 issues I need to investigate; K8S is broken because of #288.


[Storage] Upload-batch needs examples

az storage file upload-batch requires source and destination but gives nothing on how to specify it.  Most things I've tried don't work.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c633bcb6-d7c0-8bfe-76b6-c69fed9eaf90
Version Independent ID: 6b2e9a7e-c75f-0b48-0794-acd0ba474eba
Content: az storage file
Content Source: src/command_modules/azure-cli-storage/azure/cli/command_modules/storage/_help.py
Service: storage
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

@gwlperl what have you tried?
I've copied the help below:
--destination -d [Required]: The blob container where the files will be uploaded.
        The destination can be the container URL or the container name. When the destination is the
        container URL, the storage account name will be parsed from the URL.
--source -s      [Required]: The directory where the files to be uploaded are located.

Please also mention in the documentation that when uploading into the "$web" container, the $ should be escaped in bash:
az storage blob upload-batch -s ~/MyWebsite1 -d "https://mywebsite.blob.core.windows.net/\$web"

I've added an example for upload-batch with https://github.com/Azure/azure-cli/pull/7153.
@kostrse I am hesitant to add that documentation as it is bash-specific and applies to a variety of other possible web container names.

the following worked for me locally.
az storage file upload-batch --account-name [StorageAccountName] --destination [ShareName] --source . --pattern *
When I tried to run it from Azure DevOps though it broke. It was running on a Linux Build Agent. I changed the script to the following command, and this also worked.
az storage file upload-batch --account-name [StorageAccountName] --destination [ShareName] --source .

Please also mention in the documentation that when uploading into the "$web" container, the $ should be escaped in bash:
az storage blob upload-batch -s ~/MyWebsite1 -d "https://mywebsite.blob.core.windows.net/\$web"

Escape $web with single quotes in PowerShell az storage blob upload-batch --account-name myaacountname --source .  -d '$web'

Please also mention in the documentation that when uploading into the "$web" container, the $ should be escaped in bash:
az storage blob upload-batch -s ~/MyWebsite1 -d "https://mywebsite.blob.core.windows.net/\$web"

Escape $web with single quotes in PowerShell az storage blob upload-batch --account-name myaacountname --source . -d '$web'

Escaping $web with single quotes worked for me too

Thanks @divgo - I was tearing my hair out with the undocumented bug with the linux build agent (can't do --pattern *).

What if the folder already exists in the destination?
I have spent couple of hours to figure out on how to overwrite or avoid overwriting.
This is pretty unproductive. @microsoft help us to be productive.

As far as I know, only uploading a file to a file path in ADLS Gen2 file system with az storage fs file upload has --overwrite parameter for overwriting existing resource or not.
While uploading a file to a share with az storage file upload doesn't support --overwrite from service side.


Adds support for default Namespace in C#

This PR add support for multiple namespaces in .NET snippets
A relevant test has been added to validate how .net snippets would look like.
Ideally the snippet here would change to look like this,
GraphServiceClient graphClient = new GraphServiceClient( authProvider );

var set = new Microsoft.Graph.TermStore.Set
{
	Description = "mySet"
};

await graphClient.TermStore.Sets["{setId}"]
	.Request()
	.UpdateAsync(set);

I have split the generated diff into two commits. The interesting and non-interesting commit.

can you just link this one to an issue or create one for tracking purposes?

var set = new Microsoft.Graph.TermStore.Set
{
Description = "mySet"
};
there's a part of me that says only add namespaces for non default namespace.  what are your thoughts?

@andrueastman please add the full diff of the snippet generation using the new code (similar to here https://github.com/microsoftgraph/microsoft-graph-explorer-api/pull/269). The test you added makes sure that the happy path works, but having a full diff would give us confidence in terms of not having any regressions.

@zengin
If is use Termstore.Set compilation fails. I will reach out to you to get more clarification on this front.

@andrueastman I thought about partial namespace references in C++ when I wrote that comment. It seems like C# doesn't support it without explicit aliasing.
I will sign-off if you have no regression on the full generation.

Snippets Diff


[FLINK-16529][python]Add ignore_parse_errors() method to Json format …

What is the purpose of the change
JSON format currently support 'format.ignore-parse-errors' to skip dirty records in Java, which should consistent with Java in Python API.
Brief change log

Add ignore_parse_errors method in Json class to support 'format.ignore-parse-errors'.

Verifying this change

Add test_ignore_parse_errors method in JsonDescriptorTests to verify whether to support 'format.ignore-parse-errors'.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@SteNicholas Thanks a lot for the PR. Merging...
The test failure is because the e2e is not triggered and it's not related to this PR.


Create Actions Help dialog typo

https://github.com/auth0/auth0-cli/blob/7b0d17c56b5aeb670336077d6aa22203e39082cd/internal/cli/actions.go#L173-L175
Extra dash here in front of -n only noticed this because I tried copy+pasting the command 😅
=== dev-edintheclouds.eu.auth0.com error

 ▸    unknown flag: --n

Hey @tedsmitt thanks for reporting this and kudos to @jsoref for fixing this through #477 !


mesa3d: Rename extra arguments flag to BOARD_MESA3D_MESON_ARGS

To match with current Mesa's Android.mk

How about keeping the existing one in addition to the new one?

How about keeping the existing one in addition to the new one?

Sure, let me make a new PR then

I think you can force-push this one instead of creating new


Function invokation is not working

Example: http://localhost:8080/orientdb/function/gen
If gen is idempotent and, for example, return just constant.

Fixed by PR to OrientDB: https://github.com/orientechnologies/orientdb/pull/3589


Prices don't get imported.

Everything seems to work fine except every item has a price of 0gp.  I'm importing from the Items(SRD) compendium and when I open the compendium, the items clearly have prices.
To Reproduce
Generate Inventory using the Items compendium.
Expected behavior
Items populate with prices.

Desktop (please complete the following information):

Browser Chrome and Edge

I also see this:  DevTools failed to load source map: Could not load content for http://localhost:30000/modules/merchantsheetnpc/bundle.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE

I am having the same issue

Me too

I'm having the same problem

Shouldn't it be
	getPriceFromItem(item: any) {
		// @ts-ignore
		return item.system.price.value;
	}

instead of
	getPriceFromItem(item: any) {
		// @ts-ignore
		return item.system.price;
	}

Same issue. May 1st. Using v2.9.1.... Completely new world, no mods, just Merchant Sheet NPC. Price does not import when an item is dragged from the item list onto the NPC.


BIDS Steering Group election and Governance results

We are excited to announce the winning slate of the BIDS election is the Guiomar Niso chaired slate with Melanie Ganz, Robert Oostenveld, Russ Poldrack, and Kirstie Whitaker! Congratulations to them and thank you to all the slates and voters for making this a successful election!
Our winning slate represents multiple imaging modalities (MRI, MEG, EEG, iEEG, and PET) from around the world with several differing perspectives and expertise. The group members have been influential in pushing the BIDS Initiative initially and in extending BIDS into more imaging modalities. Their wealth of expertise will push BIDS forward into the derivative space, integrating across the modalities, sharing tools and apps, with a focus on reproducibility in the long-term. To learn more about this group please visit their description page. We have also shared the voter data and code used to determine the results.
Please join me in Congratulating Guiomar, Melanie, Robert, Russ, and Kirstie!
We will be welcoming our Steering Group with our accepted Governance document!

Congratulations! :-)


[WIP] Rewrite miri script in rust #2883

This is a sketch of a rewrite of miri script in Rust. It does not include changes made in https://github.com/rust-lang/miri/pull/2908 yet. Environment variables are not properly propagated yet, which is something I plan to address.
This PR is mostly a heads-up about the ongoing effort and it's state.
It's definitely not the cleanest code I've seen in my life, but my first goal was feature/interface parity. I will iterate on it a bit before marking it as ready.
I wonder though how this should be integrated/tested. Are you aware of anyone using ./miri in their scripts?
I guess we should keep existing miri script in place and let it run miri-script package directly?
CI should probably cargo check this package as well.
Fixes #2883

Thanks for the PR! Someone will take a look and review this eventually, we're just all busy currently -- sorry for the delay.

Hey,
No problem - that's totally understandable. I intend to polish this before marking this PR as ready for review. Sadly I couldn't find time for that (or anything, really) recently.
Miri script works as is, we don't need to rush this in.

I wonder though how this should be integrated/tested.

FWIW I'm not particularly worried about testing this code. Obviously it would be nice if it had good tests, but a lot of this is mucking about with the state of "the system", and the parts of this that really matter will get exercised regularly by us. Write tests if they help you build confidence that this works. But I think it would be easy to go overboard and spend more effort on the test suite than the tool.

Are you aware of anyone using ./miri in their scripts?

I don't think this is particularly worth worrying about.

I guess we should keep existing miri script in place and let it run miri-script package directly?

Yes. ./miri is much shorter than cargo run --manifest-path=miri-script/Cargo.toml -- . It would be neat if the script were turned into the thinnest wrapper around that. User workflows could be unaffected, the CI setup could stay as-is, and so on.

I'm done leaving comments. I think this is an amazing start, and I'd love to try it out when the problem with unset CARGO_EXTRA_FLAGS is addressed.

:umbrella: The latest upstream changes (presumably #2948) made this pull request unmergeable. Please resolve the merge conflicts.

@RalfJung it looks like there's an issue with ./miri toolchain where on Windows setting an override for a directory doesn't affect subsequent call to rustc --print sysroot. Using dustup run rustc --print sysroot does propagate the override properly. I'm not sure what I'm doing wrong; I've pulled so much hair on this that at this point I might have to see a barber. :/

it looks like there's an issue with ./miri toolchain where on Windows setting an override for a directory doesn't affect subsequent call to rustc --print sysroot. Using rustup run rustc --print sysroot does respect the override.

I assume the difference is that miri-script itself is run inside a cargo run which runs in rustup. So some rustup env vars are set which take precedence over the toolchain file. We should probably unset them / not forward them to programs we invoke.

Hm, that sounds plausible. What do you say to having something akin to:
cargo build --manifest-path "$(dirname "$0")"/miri-script/Cargo.toml && "$(dirname "$0")"/miri-script/target/debug/miri-script $@
instead of:
cargo run --manifest-path "$(dirname "$0")"/miri-script/Cargo.toml -- $@
The former should not go through rustup, so it won't set its environment variables - but it will still be possible to set them just in case someone wants to do that.

Hm, then we have to make assumptions about where cargo puts the build... But that might still be the better option than fiddling with the environment.

:umbrella: The latest upstream changes (presumably #2986) made this pull request unmergeable. Please resolve the merge conflicts.

I'm going to take over this PR -- at this point I think it is easier if I just implement things the way I prefer, rather than trying to explain to you how I would like this to be changed. :)  Your groundwork has been extremely helpful for this, thanks a ton!

Looks like there is a problem (which the old code work around in an incorrect way)... for things like ./miri clippy -- -D warnings, we want all of -- -D warnings to be forwarded to clippy. That is, we don't want the clap parser to intercept this -- at all.
Is that possible?

Hi,
I am sorry for not carrying this further - I've had less time recently for OS work. :/
As for the "--" forwarding issue, I believe I've annotated clippy and fmt subcommands with allow_leading_hyphen. I recall that there were still issues with it tho.
Another problem with what I've had up to this point was that new fmt was noticeably slower than the old one. I suppose it came down to formatting files sequentially Vs using xargs in a shell script - which could've parallelized different rustfmt instances under the hood.

Another problem with what I've had up to this point was that new fmt was noticeably slower than the old one.

I fixed that by running rustfmt a single time on all the files, instead of having a new rustfmt invocation for each file. (That matches what the old script does.)

As for the "--" forwarding issue, I believe I've annotated clippy and fmt subcommands with allow_leading_hyphen. I recall that there were still issues with it tho.

That's not sufficient -- as the clap docs for trailing_var_arg say, "users still have the option to explicitly escape ambiguous arguments with --". I don't know if clap has a way to to disable this. If not, we won't be able to use clap.
All the CI failures currently are caused by this.

@bors r+

:pushpin: Commit e5b358ab1702ddced1e670be34a9feaeab3d2673 has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit e5b358ab1702ddced1e670be34a9feaeab3d2673 with merge 273cdaba35121f004cb9092fd6e28fe0a46cb2fa...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 273cdaba35121f004cb9092fd6e28fe0a46cb2fa to master...


Click on the outline title and text will flicker

Click on the outline title and text will flicker

@Eriky-git I'll need more info to verify that, because on my machine it doesn't. Which OS, Obsidian version, Mononote version, please?

I have a similar issue. I have a note pinned in the sidebar. When I use the middle mouse button to open a link twice, the second tab disappears, but the remaining tab flickers and I cannot unfocus from that tab. My note is in the right sidebar, and I have not tried it in the left sidebar.

OS: Ubuntu 20.04
Obsidian: 1.5.3
Mononote: 1.1.1

There appear to be no issues in the developer console:
loading obsidian-auto-link-title
plugin:obsidian-tasks-plugin:149 [2024-02-04-10:01:30.999][info][tasks] loading plugin "Tasks" v6.0.0
plugin:mononote:91 Plugin Mononote v1.1.1 initialized

Thanks for the detailed report, @mattrmd.

but the remaining tab flickers and I cannot unfocus from that tab.

That sounds suspiciously like an endless loop to me. I'll take a look the next time I work on Mononote!
Mononote is currently not my highest priority, tho, so that might take a few weeks. I will look into it, just not right away.

https://github.com/czottmann/obsidian-mononote/assets/41268511/28758a79-bcbd-47a7-9e12-28e77d70bc45
just like this。
OS：mac os 14.1.2 (23B92)
Obsidian: 1.5.7

I'll look into it during the next few days!

The same!
There is this issue, when your Plugin is active and I click on a linked mentions entry:
https://www.screenpresso.com/=W7P4b
Thank you.
Have a great day.
Mic.

@MichaelLepori This looks like an unrelated issue; either way, I've moved it into a separate issue. If it turns out to have the same cause, great, but I'd like to prevent those unwieldy "And also…" bug reports. 😅

Same problem, here's a screencast for documentation purposes
screencast

Fixed in Release 1.2.1. Re-open the ticket if it isn't, please!

I updated Mononote, and the issue seems to be resolved. Thanks, @czottmann !

Me too. Thank you @czottmann !!


Appending an Instruction class instead of an instance gives an unhelpful error message

What is the expected enhancement?
If a user forgets the () for their gate, they'll see the following error message:
>>> import qiskit as qk
>>> from qiskit.extensions.standard import *
>>> qr = qk.QuantumRegister(2)
>>> qc = qk.QuantumCircuit(qr)
>>> qc.append(CnotGate, qr[:], [])
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/kevin.krsulichibm.com/q/qiskit-terra/qiskit/circuit/quantumcircuit.py", line 462, in append
    for (qarg, carg) in instruction.broadcast_arguments(expanded_qargs, expanded_cargs):
TypeError: broadcast_arguments() missing 1 required positional argument: 'cargs'

because instruction will be an Instruction subclass, and not an instance. (broadcast_arguments will be called as a static method on the class, instead of an instance method so self will be missing. Thus the TypeError for missing cargs)
In QuantumCircuit.append, we already check if not isinstance(instruction, Instruction) before checking hasattr(instruction, 'to_instruction').
This should be restructured so that if instruction is not an Instruction instance, and does not have a to_instruction, we raise. (Optionally, we can check if issubclass(instruction, Instruction) and if so, suggest adding ()).

@1ucian0 could I try and implement this one? I am new to Qiskit, and this looks like a good first issue!

Go for it! Let me know if you need any assistance!


Sort-change events should not be triggered when [Bug Report] forms are initialized.

Element UI version
2.4.3
OS/Browsers version
win10 chrome  67.0.3396.99
Vue version
2.5.17-beta.0
Reproduction Link
https://jsfiddle.net/mmx38qxw/3576/
Steps to reproduce
no steps
What is Expected?
按照文档的说明：当表格的排序条件发生变化的时候会触发该事件，
所以表格初始化的时候不应触发sort-change事件，
What is actually happening?
现在表格初始化的时候也会触发sort-change事件

met this bug too, set default-sort, and after table is loaded 'sort-change' event is emmited

This is still an issue

This is still an issue
It seems that the latest version has been solved.


Is this project dead

If not my organization can take over maintaining it

Hey @KillDozerX2 - we're not doing active development but we're happy to accept improvement PRs and will make our best to move them forward to getting merged. Is there anything specific you'd like to address?

There are 3 PR's here that might need a push.


ctypes.windll.winmm.mciSendStringA behaves incorrectly

Description
I have a little application, which should act as a voicerecorder. Therefore I use the library ctypes. I wrote the application and tested it with python 2.7 and it worked fine. As a result i got an wav file which was playable.
But with ironpython I always get an error when trying to open a new type waveaudio. With this little code snippet, the problem is reproduceable (and working with python 2.7)
Steps to Reproduce
import ctypes

mciSendString = ctypes.windll.winmm.mciSendStringA
mciGetErrorString=ctypes.windll.winmm.mciGetErrorStringA

OpenCmd='open new type waveaudio alias 1337 wait'

buffer = ctypes.c_buffer(255)
errorcode = mciSendString(OpenCmd, buffer, 254, 0)

if errorcode:   # There was an error
    mciGetErrorString(errorcode, buffer, 254)

print(errorcode)
print(buffer.value)

I get the output:
292
Der Befehl erfordert einen Alias-, Datei-, Treiber- oder Gerätenamen.
With python 2.7 I get the expected output:
0
1
Versions
IronPython 2.7.10 <IP_ADDRESS> on .NET 4.0.30319.42000

With IronPython, strings are actually unicode. The solution to your issue is to prefix your OpenCmd string with b to ensure you have a bytes object:
OpenCmd = b'open new type waveaudio alias 1337 wait'

Thank you that helped!


search support by typing in skin selection

manually scrolling up or down on champions with too many skins is a pain, skin filtering/ searching by typing could be nice

just bind it to pg up pg down


Improve ngtf File handling

This (finally) adds support for a configurable directory for all the extra files used by ngtf and its handlers, set by -x/--extrasdir.
Additionally improve the handling of some of the pyopenssl files since it handles non-existent dhparams poorly.

Why is an extras dir needed at all? Why not specify paths to all the needed files on per-file/per-feature basis? We already support that for some files, but not others (e.g., MiTM certs/keys).

I don't want handlers adding command line options right now so that kills
per-file. Generally I think relying on ./ was always hacky and sad I just
never got around to it.
Afaik the only input file that can be specified right now is the SSL cert
for the blame server. Nothing related to handlers or the actual mitm is.
On Mon, Aug 10, 2015, 12:42 klyubin<EMAIL_ADDRESS>wrote:

Why is an extras dir needed at all? Why not specify paths to all the
needed files on per-file/per-feature basis? We already support that for
some files, but not others (e.g., MiTM certs/keys).
—
Reply to this email directly or view it on GitHub
https://github.com/google/nogotofail/pull/81#issuecomment-129580189.


Check-in: Is Tye still active?

Just checking in to see what's going on in Tye Land.  I've given some talks on it, and last I heard (in November) it was targeted as being integrated in some fashion into .NET 6.  Looking at the contrib graph, things have definitely slowed down in recent months.
Any guidance from the core team?
Thanks!

Hey @jlikens, we are still working on Tye and planning to move forward with it. But we had some priorities come up in other areas and things have slowed down for a bit while we take care of them. You should see some announcements and such from us again soon.


NG: Need to clarify commit of writes in StorageDriver interface

Right now, the commit for chunks headed to backends like s3 and azure is unhandled. We need a solution such that multiple calls to WriteStream followed by some action correctly commit multipart uploads.
The original approach was to pass the total size to WriteStream, as a size argument. Unfortunately, this can be easily confused with the size of the chunk provided by the reader (a mistake that I have clearly made, even after getting clarification :disappointed:). Issue #781 proposes to completely remove the confusing argument. The V2 api also defers the posting of the actual size to the API to the last chunk, making the use of the size argument as the completion sigil problematic.
There are a few options:

Bring back the size argument and clearly document that its the "total size" of the uploading content. If size is negative, leave the upload open so one only needs to pass it in the last chunk.

Refactor WriteStream(path string, offset int64, reader io.Reader) (nn int64, err error) into WritePartial(path string, offset int64, reader io.Reader) (nn int64, err error) and WriteCommit(path string, offset int64, reader io.Reader) (nn int64, err error).

(nuclear) Move the registry storage API up to the registry semantic level. This process is already represented in the storage package in the V2 registry, as LayerUpload. This avoids the entire notion of a VFS and standardizes on a common interface but defers a lot of behavior to the backend. It does have the benefit that the storage layout can be optimized for the particular backend.

The ongoing API changes are in the branch below, for reference:
https://github.com/stevvooe/docker-registry/tree/ng-storagedriver-updates
This branch will be PR'd sometime today, but I'd like for us to figure out this situation ASAP.
@BrianBland @AndreyKostov @ahmetalpbalkan @dmp42

As far as I can recall, we've worked out most of the issues with the driver API. If there are still problems, let's open up a new issue in docker/distribution referring back to this issue.


Don't use --require-hashes with pip-audit

require-hashes requires all dependencies to be pinned, but this isn't the case for things like six, which come from a different brew formula

Let's see if this works: https://github.com/Homebrew/brew-pip-audit/actions/runs/4895986640/jobs/8742228795


[BUG] Error detected while processing BufWinEnter Autocommands for "*" (luasnip)

Field
Description

Plugin
luasnip

Nixpkgs
unstable

Home Manager
unstable

[x] I have read the FAQ and my bug is not listed there.

Description
I am trying to apply my nixvim configuration to a new machine. This successfully works on my NixOS 23.11 device but when applying to my nix-darwin machine I run into trouble. This specific error occurs when I open a new instance of nvim. When I disable the luasnip plugin the error does not occur.
Full Stack Trace:
Error detected while processing BufWinEnter Autocommands for "*":
Error executing lua callback: ...e/nvim/site/pack/packer/start/LuaSnip/plugin/luasnip.lua:87: attempt to call field '_load_lazy_loaded' (a nil value)
stack traceback:
        ...e/nvim/site/pack/packer/start/LuaSnip/plugin/luasnip.lua:87: in function <...e/nvim/site/pack/packer/start/LuaSnip/plugin/luasnip.lua:86>
Error executing lua callback: ...e/nvim/site/pack/packer/start/LuaSnip/plugin/luasnip.lua:95: attempt to call field '_load_lazy_loaded' (a nil value)
stack traceback:
        ...e/nvim/site/pack/packer/start/LuaSnip/plugin/luasnip.lua:95: in function <...e/nvim/site/pack/packer/start/LuaSnip/plugin/luasnip.lua:94>
Error executing lua callback: ...e/nvim/site/pack/packer/start/LuaSnip/plugin/luasnip.lua:103: attempt to call field '_load_lazy_loaded' (a nil value)
stack traceback:
        ...e/nvim/site/pack/packer/start/LuaSnip/plugin/luasnip.lua:103: in function <...e/nvim/site/pack/packer/start/LuaSnip/plugin/luasnip.lua:102>

Minimal, Reproducible Example (MRE)

{ config, pkgs, inputs, ... }: {
  programs.nixvim = {
    enable = true;

    plugins = {
      luasnip.enable = true;
      cmp = {
        enable = true;
        settings = {
          snippet = { expand = "luasnip"; };
          mapping = {
            __raw = ''
              cmp.mapping.preset.insert({
                ['<C-n>'] = cmp.mapping.select_next_item(),
                ['<C-p>'] = cmp.mapping.select_prev_item(),
                ['<C-y>'] = cmp.mapping.confirm { select = true },
                ['<C-space>'] = cmp.mapping.complete {},
                ['<C-l>'] = cmp.mapping(function()
                  if luasnip.expand_or_locally_jumpable() then
                    luasnip.expand_or_jump()
                  end
                end, { 'i', 's' }),
                ['<C-h>'] = cmp.mapping(function()
                  if luasnip.locally_jumpable(-1) then
                    luasnip.jump(-1)
                  end
                end, { 'i', 's' }),
                })
            '';
          };
        };
      };
      cmp_luasnip.enable = true;
};

I discovered the issue. There was some left over packages from a previous install located in ~/.local/share/nvim/..., removing these and now everything works as intended.


squash migrations

This is a prerequisite to https://github.com/RedHatProductSecurity/osidb/pull/49. I squashed all possible migrations (except the exploit ones as I do not touch this as Standa kinda owner). This is a first step to clean them up. Only after the release we can remove the old migrations. The squash was definitely not an automatic process. There was a lot of manual work included. The automatic output was more than 5k lines which I then manually sqaushed to 1.5k omitting unnecessary or later removed steps.

LGTM but I would suggest doing the following to formally verify that the squashed migration is correct:
1. Delete all migrations in a separate branch

2. Call `makemigrations`

3. Compare by diff the single migration file generated by `makemigrations` with the squashed migrations file

I was running makemigrations on top of the squashed ones until it stopped adding or removing stuff so I considered it as a reference of equality but of course I can try the clean state and compare.

@Elkasitu I removed all the migrations and generated them from scratch to compare with the squashed version. The result is that the freshly generated ones are low quality subset of the squashed ones. One thing is that they are sorted in a very dummy way so for example there is a lot of relations done in Add and not Create step as during the creation the related model does not exist yet. Second thing is that they are both differently formatted even though run through the same black command which is something I cannot explain but I did not dig in very much. The from-scratch-migration also miss unique together which is weird. Of course it miss the row level security. Otherwise they are functionally equivalent.

@Elkasitu @JakubFrejlach so please one more look. I created separated migration to remove mitigated_by field and put it before the squash so it can be squashed too. Then I reintroduced that field but only as a serializer field with deprecation mark and comment. I will still be provided but always empty (it is optional anyway). The weird is that the swagger behavior is to just remove it from the docs - Adrian has a good point what this means for the bindings ...

Actually I am kinda confused right now, looking for example at the Flaw.impact treating in SFM2, we do not allow the empty value (None) anymore (the validations won't allow it so the only way is to force it through BZ), so why is the default necessary? thinking blank is allowed so the Flaws with missing impact values will be imported correctly but do we want the behavior that newly created flaws would get the empty impact by default? This thought also applies to some other attributes (eg. source, etc.). I might be missing some bigger picture, but this feels weird to me.

Maybe I am confused :smile: I thought that blank means that the value is not required on the API or Serializer level and null is for the database level. Which leads me to think that blank without default will result in the failure on the DB level when no value is provided which is lower than it should happen. I would await this to be caught by some validation or considered OK which would be not if there is no default as it would just fail. Do I understand it wrong? :smile:

@Elkasitu @JakubFrejlach so please one more look. I created separated migration to remove mitigated_by field and put it before the squash so it can be squashed too. Then I reintroduced that field but only as a serializer field with deprecation mark and comment. I will still be provided but always empty (it is optional anyway). The weird is that the swagger behavior is to just remove it from the docs - Adrian has a good point what this means for the bindings ...

I will need to investigate, will try to regenerate bindings with the deprecated field in place and will report back, how it behaves.

@Elkasitu @JakubFrejlach so please one more look. I created separated migration to remove mitigated_by field and put it before the squash so it can be squashed too. Then I reintroduced that field but only as a serializer field with deprecation mark and comment. I will still be provided but always empty (it is optional anyway). The weird is that the swagger behavior is to just remove it from the docs - Adrian has a good point what this means for the bindings ...

Well I've tried your branch myself and it is present crossed out, so I guess this behavior is correct

@JakubFrejlach thank you for valuable comments! For the deprecated attribute in schema it really looks OK so maybe I did something wrong or really overlooked it (but I am convinced that I ctrl+f searched for it). For the default string value I actually really do not know what is correct here. I for some reason first thought that without default but with blank it should not work because something needs to be stored when it is not null. However it will actually store an empty string when no value is specified so it will work no problem. Therefore specifying NOVALUE which is actually an empty string as default is actually no change. I quite like that it is more explicit because the standard implicit default empty string is not very intuitive. So the change is just for the reader but makes no functional difference. I can remove it if you are against.

Also, I've just remembered that we do have a compatibility shim, which is doing this None -> empty string for us. Look at the osidb/mixins.py::NullStrFieldsMixin. This was done so the import from the BZ where we still do have the double empty representation (Null/None vs Empty string).

@JakubFrejlach thank you for valuable comments! For the deprecated attribute in schema it really looks OK so maybe I did something wrong or really overlooked it (but I am convinced that I ctrl+f searched for it). For the default string value I actually really do not know what is correct here. I for some reason first thought that without default but with blank it should not work because something needs to be stored when it is not null. However it will actually store an empty string when no value is specified so it will work no problem. Therefore specifying NOVALUE which is actually an empty string as default is actually no change. I quite like that it is more explicit because the standard implicit default empty string is not very intuitive. So the change is just for the reader but makes no functional difference. I can remove it if you are against.

Also, I've just remembered that we do have a compatibility shim, which is doing this None -> empty string for us. Look at the osidb/mixins.py::NullStrFieldsMixin. This was done so the import from the BZ where we still do have the double empty representation (Null/None vs Empty string).

It seemed to me that Django would do it automatically but I was not completely sure. I was playing in the console a bit. null=True fields obviously allow NULL which is not correct. null=False just fails with an error when it gets None but it has to be assigned explicitly. Even without default when I created an object without setting any values they were set to "". I also forget about the mixin which solves the issue with the explicit None so now my defaults are really extra. I will remove them.

@Elkasitu @JakubFrejlach I removed mitigated_by removal and will create a another pull request for it with respect to N-1 compatibility and also to make this one more single purposed. I also removed unnecessary string default values. Hopefully now the changes are not controversial any more :smile_cat:


Add local drive support to BraketLocalAhsDevice

Description of changes:
Update the BraketLocalAhsDevice to validate pulses correctly when both global and local drives are present.
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General

[x] I have read the CONTRIBUTING doc
[x] I used the commit message format described in CONTRIBUTING
[ ] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

How does this PR fit in relative to the https://github.com/aws/amazon-braket-pennylane-plugin-python/pull/147? Will this be merged afterwards?

This PR builds on top of it. The main PR currently only supports a global drive on the local simulator, but the braket API also allows local detunings to be defined. This PR validates and translates local drives in a ParametrizedEvolution into objects supported by the braket.ahs module to be used on the local simulator. @lillian542 can confirm, but I think AWS plans on eventually adding the same functionality to their hardware, at which point we would just need to move over this code to the parent class of BraketLocalAquilaDevice.

All local drives must either be floats or callables
Why is that? Is that a restriction we are imposing?

All local drives must either be floats or callables

Why is that? Is that a restriction we are imposing?

Yes. The way local drive is implemented in Braket is by applying a "global" detuning to all wires, and the magnitude of that detuning differs per wire: $\delta_{\text{local}}(t) h_i n_i$, where i is the wire index, $\delta_{local}$ is time dependent detuning, and $h_i$ is the atom dependent magnitude. For this to work, if a user specifies multiple terms for local detuning, they need to follow the same general shape, but they don't need to have the same magnitude. The per-wire magnitude is computed by the functions added in this PR.
For example, users can specify detuning1 = lambda p, t: p * np.sin(t) on wires [0, 1], and detuning2 = lambda p, t: 0.5 * p * np.sin(t) on wires [2]. Both functions have the same shape, and the code in this PR will use detuning1 as $\delta{local}and per wire magnitude[1, 1, 0.5, 0.5]`.
For the shape to be the same, we enforce that local detunings are either all constant, or all callables differing only in magnitude.


Cleaned up flow type for selectors in narrowSelector

Issues in focus: #2971, #3166
Removed redundant messages word in the logical operation performed under getIfNoMessages and added flow type for it
Added flow type for getStream in narrow. This one was different because the selector returned either Subscription if the Stream was subscribed to before, or Stream + in_home_view=true if it was not subscribed to before. A type could have been declared for the latter case but it seemed unnecessary so instead, I used spread syntax to define the return type.
Tests ran:

[x] tools/test

Looks good -- thanks @AB261 !
Two small things:

Because each of these is a bit more than something totally boring and mechanical, and each one makes sense on its own, it's clearest to split them as two separate changes.
The type Stream is already an exact object type:

export type Stream = {|
  stream_id: number,
[...]
|};

so the $Exact is redundant and can be left out. (We probably have some of those elsewhere in the codebase, left over from before we went and made almost all our object types exact -- probably you saw one of those. They can be taken out too.)
I'll go ahead and merge, with those tweaks.

Merged -- thanks again!
I also added a commit on top, 75b7381cc. Take a look at that and the two commits preceding it.


Expose MarkdownEngine.currentDocument to contributed extensions

VS Code's Markdown engine has stored the URI of document under parsing but it's not exposed to Markdown preview extensions (markdown-it plugins).
Exposing the location of current document (MarkdownEngine.currentDocument) to the second argument of markdown-it functions (env object) would like to be good for contributed extensions. Please let me hear if there is any concern.
Motivation
My extension, marp-team.marp-vscode, has implemented the support of CSS themeing that is separated from markdown.styles built-in preference. I have used a hacky way (execute md.normalizeLink() directly) to get the placed directory of Markdown under parsing. I need it for matching the rule of CSS path resolution into markdown.styles.
https://github.com/marp-team/marp-vscode/blob/a3dc7bd8d50e97b995a2c7b57f38479cf1696334/src/extension.ts#L30-L32
Until VS Code 1.39.x, that was expected to get URI to the workspace folder Markdown belongs, or the directory that Markdown is placed.
Unfortunately this is no longer working since 1.40.0 by the change in 36aa903 (reported in marp-team/marp-vscode#100). I tried to fix this but failured because I could not find the correct way to get current document while parsing.
I have recognized the design of markdown.styles to avoid reading arbitrary files (#75039), and I'm sure following this principle should be better to make extension secure.

I know I am too late for this feature request, but I think this is comparatively easy to fix and would improve the configurability of markdown-it plugins a lot.
I am currently adding a markdown-it plugin to the Argdown VSCode extension and want to load configuration files specific to the workspace of the currently previewed document. As I do not want to use a "messy workaround" as in the marp plugin, I think I have to give up on this.

@christianvoigt Thanks for having same opinion!
The workaround may have misdetection the location of workspace while opening the exactly same 2 Markdowns in different workspaces, so I don't want to use this trick if possible.
Should I open as a new issue to continue this?


Formly with advanced select ?

Can I use formly with advanced selects like https://github.com/angular-ui/ui-select or https://github.com/lordfriend/nya-bootstrap-select ?
I mean keeping all options like ajax, multiple and so on?

Absolutely. You simply need to create a custom template and use those directives in your custom template. I'm actually doing this currently with ui-select.

There are likely a few things in there that you'd need to change from my example, but the concept is fairly straightforward :-) Good luck!

Also, if you do get this implemented, I would love to have an example on the website. Create an example by following the instructions here

@piernik, do we need to keep this issue open?

no thanks


source of Tomato framework

Please share the latest and updated source of the Tomato framework inside examples too.

good idea. I'll do that soon

Not bad if just like Blockdom, Tomato framework supports Typescript with correct typing.


Explorer not fetching latest stellar.toml

Hi Team,
We have setup our new token on PUBLIC chain https://stellar.expert/explorer/public/asset/USD1-GDZSI5NQM4IU2NOQOMNXGAGU6K2NMU2G25C4P4UTH5SUY3IH5B3W74F4
However, we had a bit of an issue with stellar.toml hosting. The Explorer tried to fetch the toml and it get blocked (connection failed).
We had resolved file hosting issue but for some reason the explorer still caching old stellar.toml.
Would team be able to assist getting with the issue?
Kind regards,
Sokun

same problem

@SGZone-hash Thanks for bringing this issue to our attention. The best way to resolve this is to contact our support team.
For the fastest resolution, please click on the link below to our dedicated support line:
Support: Help Center
Note: Click on the live chat icon at the bottom corner of the page to start a conversation


[FR] Decouple progress frontend

IIUC, due to Juno-specific check in @progress macro implementation, code using @progress can only work inside Juno:
https://github.com/JunoLab/Juno.jl/blob/554707e93034b847621b8df7236d59f7718dc778/src/progress.jl#L105-L106
The specification in Juno.progress docstring also does not specify that using LogLevel(-1) is crucial.
These are issues I noticed while writing a ProgressMeter-Logging bridge ProgressMeterLogging.jl and adding a frontend support in my package https://github.com/tkf/Transducers.jl/pull/63.  I think a cleaner solution may be having a base package with a spec and a reference implementation of frontend progress macros and functions.
What do you think? Is it a good approach to decouple progress logging interface (frontend API and specification documentation) from Juno?

Yes, definitely.

does not specify that using LogLevel(-1) is crucial.

It isn't for Juno's implementation -- any logging level higher or equal to -1 works (or higher than the min_enabled_level of the global logger). Should still be documented though.

OK, I created https://github.com/tkf/ProgressLogging.jl. Do you want to move it to https://github.com/JunoLab?

Sure, why not -- invited you to the org. Thanks for splitting out the code!

I got a permission error when I tried to transfer it to JunoLab so I transferred the repository to you.  Can you move it to JunoLab?

Hm, weird. Should be transferred now.

Thanks!


Add procfile for Heroku deployment

Hi,
Proc file is missing for deployment on Heroku. Can you provide some assistance for the same?

I don't use the Heroku platform but once you first push the app, you'll have to do this in the environment:

Make sure virtualenv is installed (pip install virtualenv I think, Heroku presumably has Python already)
Make sure your pwd is the root of this repo
virtualenv venv
./venv/scripts/activate.sh
pip install -r requirements.txt

And from then on to start the app it's just a matter of ./venv/scripts/activate.sh then python run.py.
So your procfile (I'm not that familiar with them either) might look like:
web: ./venv/scripts/activate.sh; python run.py
Assuming you don't need fully qualified paths and semi-colons are allowed.
If this works or you figure it out, feel free to open a pull request. 👍

I want to integrate this tool into another existing scanner. Is there an API that I can use to extend jawfish?

Not the way it's currently written - I coded this as a younger, more naive developer. At the moment the bulk of its work is client-side (in-browser).
I agree that it would be more useful in such a setup. It could be included in a devops pipeline. The UI could go to Electron from the current browser-based solution.
Opening a separate issue.


MudTextField get "jumpy" when mixed with none helpertext variants PR #199

Describe the bug
MudTextField get "jumpy" when mixed with none helpertext variants PR #199
Expected behavior
Should not "jump"
This can easily be seen at https://mudblazor.com/components/form under "Simple form validation". Click on username and click elsewhere so error messages get displayed, now you will see the input "jumps" to get the space needed for the error message.
I will fix it in the morning.

Will not make it into 1.3.0, working on remaking the whole InputControl, Textfield structure overall since it tends to break to easily and is implemented differently in various components.

@Garderoben any plans to address this? Feels like this fell through the cracks. A pure css solution is possible, admittedly it's a bit fragile:
div.mud-input-control-input-container:last-child::after
{
    /* need some significant content (e.g. nbsp) or else the placeholder won't show */
    content: "\00A0";
    /* some props from .mud-input-helper-text and .mud-input-control-helper-container */
    margin-top: 3px;
    font-size: 0.75rem;
    font-weight: 400;
    line-height: 1.66;
}

Try it here: https://try.mudblazor.com/snippet/QaQmOollJLJMzAhl

Hey @bachratyg,
We are currently facing the same issue. Did you get any feedback or updates to this issue?

Nothing new. I've been using the css workaround ever since.

@bachratyg Thank you for the workaround. I'll use it as well.

@Garderoben Hello, I am having the same issue with multiple text fields in one row. The one that has an error jumps up. Any plans to continue on this? Best regards.

@henon Want me to fix this so the space is pre-allocated if any kind of validation is enabled?

Sure, if you want, go ahead Daniel.


why the cropped mask are all black?

They're not. The pixels in the mask images are either 0 or 1, thus looking like all black.


Update dependencies.

It appears to but what this really does in uncover a new bug in bubbles/lipgloss that wasn't there before. I'm in touch with the charm folk to get this fixed there instead of here.

Do you have any idea of a timescale?
As you said, the failure here is just local and I'm evaluating just importing it as it is and commenting out the unit tests. so that our automatic tests don't revert the import.


Loading gltf models is painfully slow.

Bevy version
0.12.0
[Optional] Relevant system information
If you cannot get Bevy to build or run on your machine, please include:
$ cargo --version
cargo 1.75.0 (1d8b05cdd 2023-11-20)
windows 11
AdapterInfo { name: "NVIDIA GeForce RTX 2060 with Max-Q Design", vendor: 4318, device: 7954, device_type: DiscreteGpu, driver: "", driver_info: "", backend: Dx12 }
What you did
Loading a scene using gltf
What went wrong
It took roughly 50 seconds to load a single model in release mode. By comparison, I loaded the same model here https://gltf-viewer.donmccurdy.com/ and takes less than a second to load.
Additional information
Here's the file I used. It's a model I exported from ue5. https://www.dropbox.com/scl/fi/ihcf4wttx1edc09gedoc6/idle_relaxed.glb?rlkey=jdsw4wm0ehjrof5m65ney4dvd&dl=0

Related upstream discussion: https://github.com/gltf-rs/gltf/issues/409

I don't have those kind of loading time using the scene_viewer example
https://github.com/bevyengine/bevy/assets/8672791/905504f3-5cf5-4f0f-949c-1e2515c3bebc
Could you give more details on your CPU and hard drive?


Reports | Dates need to be in DD/MM/YYYY istead of epoch date

Hi @shambhavigoel1002  Please add the development tasks to close this ticket

Hi @Ramu-kandimalla  Can you please add more description for the above issue

Hi @devarajd94  Please add more details to the ticket (screenshot or Video) will be helpful

HI @rajeshcherukumalli  can you please tect and confirm

Hi @ankitSharmaBeehyv,
Verifed the below reports in DEV environment for the date formats

For Applications checked in 'Register of criminal miscellaneous petitions'
For Hearing checked in 'A Diary Register'
For Orders checked in 'Process Register'
For Cases checked in 'Calendar of summary cases' reports.

Orders and cases are updated with new cases and date format is displayed as new date format,
Reference: https://jam.dev/c/13c3cee6-1e3e-410c-bf97-ccf6f16fe268
Issue: For Hearing and Applications newly created data is not inserted into the reports.

Hi @Ramu-kandimalla , verified the reports with following fields in dev environment working fine

In 'A Diary Register' report 'Data.hearing.startTime' field date format is displayed in the DD/MM/YYYY format with time.
In 'Hearing Book' report 'Data.hearing.endTime' field date format is displayed in the DD/MM/YYYY format with time
In 'Calendar of summary cases' report 'Data.caseDetails.filingDate' field date format is displayed in the DD/MM/YYYY format
In 'Register of criminal miscellaneous petitions' report 'Data.applicationDetails.createdDate' field date format is displayed in the DD/MM/YYYY format
In 'Process Register' report 'Data.orderDetails.createdDate' field date format is displayed in the DD/MM/YYYY format

All the reports are verified with newly created data, for old cases the same data is displaying.
please find the reference reports
Process Register-new.csv
Register of criminal miscellaneous petitions.csv
Calendar of summary cases.csv
Hearing Book-new.csv
A Diary Register-new.csv

@Ramu-kandimalla  , @ankitSharmaBeehyv  mentioned some process is to be enhanced on getting old data into reports once this one is confirmed we can check for old data also in the reports

Hi @rajeshcherukumalli  Please verify the changes in UAT


Added ability to disable mergeclaims

Fixes #861

hello any chances to merge this pull request?

Thanks for this -- I used this as the basis for something slightly different, but the feature is now in. Thanks again.

Thanks for this -- I used this as the basis for something slightly different, but the feature is now in. Thanks again.


[NFC, Incremental] Use let's instead of var's for the ChangedInput struct.

@CodaFi Introduced a nice new type, but doesn't need to be mutable, so use lets.

@swift-ci please test

@swift-ci please test

But it doesn't need to be mutable

That's not what var and let signal primarily in this language. In particularly, let is semantically stronger than something like const. It is an anti-pattern to use let for struct fields that are not semantically constants in most cases. All it does is make it harder to use - and in particular initialize - instances of this value in a way that does not go through the memberwise initializer. I am neutral on its removal given that we do not have code mutating through these members, but for the future this kind of refactoring is not always a positive.

But it doesn't need to be mutable

That's not what var and let signal primarily in this language. In particularly, let is semantically stronger than something like const. It is an anti-pattern to use let for struct fields that are not semantically constants in most cases. All it does is make it harder to use - and in particular initialize - instances of this value in a way that does not go through the memberwise initializer. I am neutral on its removal given that we do not have code mutating through these members, but for the future this kind of refactoring is not always a positive.

let in structs is almost an attractive nuisance. An assignment to a struct field declared as a var behaves semantically identically to a complete re-creation of the struct and its fields but with the point-mutation applied, which is what this kind of refactoring inspires users to type explicitly when they inevitably discover they don't have access to the setter. You don't really... win anything.

let in structs is almost an attractive nuisance. An assignment to a struct field declared as a var behaves semantically identically to a complete re-creation of the struct and its fields but with the point-mutation applied, which is what this kind of refactoring inspires users to type explicitly when they inevitably discover they don't have access to the setter. You don't really... win anything.

⛵

⛵

Thank you, @CodaFi .

Thank you, @CodaFi .

If some nice contributor would like to take up the charge of refactoring this type to hide its memberwise init, I would greatly appreciate it.  Ideally, stat'ing inputs and comparing them against the build record would be a service provided by some aggregate with access to the file system that would be the only thing that could construct instances of this value.
@owenv @cltnschlosser what do you think?

If some nice contributor would like to take up the charge of refactoring this type to hide its memberwise init, I would greatly appreciate it.  Ideally, stat'ing inputs and comparing them against the build record would be a service provided by some aggregate with access to the file system that would be the only thing that could construct instances of this value.
@owenv @cltnschlosser what do you think?

If some nice contributor would like to take up the charge of refactoring this type to hide its memberwise init, I would greatly appreciate it. Ideally, stat'ing inputs and comparing them against the build record would be a service provided by some aggregate with access to the file system that would be the only thing that could construct instances of this value.
@owenv @cltnschlosser what do you think?

Is the idea just to make an explicit fileprivate initializer?

If some nice contributor would like to take up the charge of refactoring this type to hide its memberwise init, I would greatly appreciate it. Ideally, stat'ing inputs and comparing them against the build record would be a service provided by some aggregate with access to the file system that would be the only thing that could construct instances of this value.
@owenv @cltnschlosser what do you think?

Is the idea just to make an explicit fileprivate initializer?


openjdk: remove explicit flag to include ZGC

Description of changes

Since Java 15, ZGC is a default JVM feature and therefore does not need to be enabled explicitly. The platforms it is available on automatically include it, rendering the explicit flag obsolete.
The flag was originally introduced by https://github.com/NixOS/nixpkgs/commit/162914742327002d49bd1dde424d399842ff7b5f but ZGC is not an experimental feature anymore since Java 15.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

javaPackages.compiler.openjdk15 does not build because the build applies flags which are not yet supported in the (outdated) JDK 15 version.
javaPackages.compiler.openjdk16 also does not build for me. I followed https://github.com/NixOS/nixpkgs/blob/master/doc/stdenv/stdenv.chapter.md#building-a-stdenv-package-in-nix-shell-sec-building-stdenv-package-in-nix-shell, and the package fails to build because make thinks no work should be done.
If I change the SHELL in nix develop or nix-shell when building openjdk16, the build succeeds. On an earlier commit, https://github.com/nixoS/nixpkgs/commit/cddebdb60de376c1bdb7a4e6ee3d98355453fe56, make fails with the same error if I use a non-c locale, but works with LC_ALL=C. This no longer works on newer nixpkg revisions.
As 15 and 16 are out of date in nixpkgs and have reached their EOL, maybe it is best to remove them? In any case, I have no idea why 16 fails and I can't quite explain the behaviour.

Hey @edwtjo, could you take a look at this PR please?

Borderline staging candidate, usually the cutoff is at 1000 packages, this is below that but it might still be good to review rebasing-between-branches. Other than that there seems to be some additional problems addressed in your commit is added in #255971


Product migrate

Have you an idea for this problem ?
Magento <IP_ADDRESS> to Magento 2.0.0 with mgrate-data-tool v0.1.20

Thanks

Hi quienti,
Did you do exactly steps in the guide of this tool?https://github.com/ubertheme/magento2_data_migration/blob/master/README.md
For this case, you can make reset this step by URL:
http://URL_TO_THIS_TOOL/migrate/reset/step/5
and you can re-migrate this step after reset.
Let's do it and tell me know how it goes.
Regards,
quynhvv

Hi
I followed your guide step by step and I have reset my step 5.
But I have same issue.

Hi ,
Get the same error in the same table and we have 5000 categories and can upload max 1001 categories. Can you help us ?
Best Regards,
Philip

Hi guys:
That issue because, your magento 1 databse the are a wrong value in cataloginventory_stock_item table.
Did your Magento 1 working fine now?
Can you make re-index successfully the database in back-end of Magento 1 website now?
To solve this issue, you can do steps bellow:
Step 1:
Down load this PHP file: https://github.com/ubertheme/magento2_data_migration/blob/master/protected/controllers/MigrateController.php
and replace it to path in your working: /protected/controllers/MigrateController.php
Step 2: Make manual reset the step 5 by URL: http://URL_TO_THIS_TOOL/migrate/reset/step/5
Step 3: Re-start data migration on this step and next steps.
Do it and let's me know how it goes.
Regards,
quynhvv

Thanks, I will try now

Actually, my step 5 is very long because I have more 1 000 products...
But I check my database and in my table "cataloginventory_stock_item", all items are duplicated.
You can see my screenshoot here

@quienti:
Yes, let's do steps as i suggested to solved the issue in your working.
Regards,
quynhvv

Hi,
After reindex the sqlstate 23000 is gone. But can't upload all the categories max 1001 categories then go to the next step ( no error ) . I change also the new migrate controller file. Do you have a solution for the categories ?
Thanks,
Philip

MAX 1001 categories , i have more then 5000 categories

@philipvandebriel:
Did you check the total of categories migrated in database of Magento2? How many is it?
Can you share me the screenshot of list categories in magento 1 website?
Let's capture for me full of screenshot in step 4.
Regards,
quynhvv

Hi,
Magento 1

and magento 2

Before i start the step4 all categories are checked, after only the first 1001 have a green check.

Ok maybe i need to change this max_input_vars in php.ini this is now 1000

That because you have multiple websites in the Magento 1 database.
Did you see the new field named 'website_id' in cataloginventory_stock_item table in magento 2
database?
Your update work fine ! All products are migrated
But now, I have an other problem with my customer

I have 2 customers groups, and this problem occurs on the seconds groups
(Sorry for my english, I'm French)

Ok, I have found the problem
Magento 2 have already 4 customers groups, and my database have a customers groups with same id !
So, I have change a customer groups id on Magento 2 and it's works

Hi Quienti,
you need to change the max_input_vars in php.ini  max_input_vars = 10000
I had the same problem with our categories

@philipvandebriel:
That because there are too much of categories levels in your categories tree in Magento1 database.
I have tuning to support your case with 5000+ categories. To solve the issue as you said, let's do steps as bellow:
Step 1: Make manual reset the step 4 by URL: http://URL_TO_THIS_TOOL/migrate/reset/step/5
Step 2: Download the file at https://github.com/ubertheme/magento2_data_migration/blob/master/protected/views/migrate/step4.php
and replace it to path in your working: /protected/views/migrate/step4.php
Step 3: Download the file at: https://github.com/ubertheme/magento2_data_migration/blob/master/protected/controllers/MigrateController.php
and replace it to path in your working: /protected/controllers/MigrateController.php
Step 4: Restart with data migration on this step. See more:

Note: Don't miss re-settings the max_execution_time and max_input_time in your web server before re-start with step 4.
Let's do it and tell me know how its goes.

After i change max_input_vars = 10000 then the categories are ok, now i am busy with our 7000 products.

@philipvandebriel : Great, Let's tell me know after you finished. ;)
On Fri, Nov 27, 2015 at 12:08 AM, philipvandebriel<EMAIL_ADDRESS>
wrote:

After i change max_input_vars = 10000 then the categories are ok, now i am
busy with our 7000 products.
—
Reply to this email directly or view it on GitHub
https://github.com/ubertheme/magento2_data_migration/issues/9#issuecomment-159961483
.

--
Best regards, Quynh Vu Van.
http://www.magentocommerce.com/certification/directory/dev/1639183/
Skype:  quynh.vv
Mobile:<PHONE_NUMBER>

also change this after

AddHandler fcgid-script .fcgi
IdleTimeout 7200
BusyTimeout 7200
ProcessLifeTime 7200
IPCConnectTimeout 7200
IPCCommTimeout 7200
FcgidIOTimeout   7200

max_input_vars = 10000
memory_limit = 2048M
max_execution_time = 18000

you need to change the max_input_vars in php.ini max_input_vars = 10000

I had the same problem with our categories

So, just change this value can work ?
Just restart all migration with many hours, I'm very happy !! ^^

@quienti: Yes, let's do it and tell me know how it goes ;)

Ok, I launch that, but a result in few hours ^^

Products migrate;
Error mod_fcgid: read data timeout in 7200 seconds stop after 6700 products
so i change now ; and start again
IdleTimeout 15000
BusyTimeout 15000
ProcessLifeTime 15000
IPCConnectTimeout 15000
IPCCommTimeout 15000
FcgidIOTimeout 15000

because i have 7000 products, until now this migrate module work normally for me ( so only change the settings in the server)

Hi,
Migrate products and customers ok.
Now i have this error; i change from memory 2G to 8G same error after 1041 sales orders

Fatal error: Allowed memory size of<PHONE_NUMBER> bytes exhausted (tried to allocate 88 bytes) in /var/www/clients/client1/web2/web/migrate-data-tool/yii/db/CDbCommand.php on line 518

Hi!
Like yesterday, I got a problem with my migration
https://cloud.githubusercontent.com/assets/7326954/11427880/bbbab98e-9466-11e5-9ad3-b7d67c26cd3f.PNG
All my sales are not migrated !
For example, in my database, my firt sale id is 687, but in magento 1, is id 1

Hi,
Did you check your php info ;

Yes

Hi,
Did you check your error.log from the server ?
Before i get this with my categories ;
mod_fcgid: stderr: PHP Warning:  Unknown: Input variables exceeded 1000. To increase the limit change max_input_vars in php.ini

Maybe you need to reset step 7 and check the sales ID if it is zero after reset
http://URL_TO_THIS_TOOL/migrate/reset/step/7

Hi,
After reset step 7 i get this in my database ;

and auto increment start on 1

I have no error in error.log, I reset all database in magento 2 and restart all migration

@quienti :
Before you restart the data migration, you should follow this: https://github.com/ubertheme/magento2_data_migration/issues/11
Regards,
quynhvv

Yes, I see that and I have get your last master and I had add this fix too

Hi Quynhvv,
I have a memory problem in step 7, change from 2G to 8G but nothing change ;
Fatal error: Allowed memory size of<PHONE_NUMBER> bytes exhausted (tried to allocate 88 bytes) in /var/www/clients/client1/web2/web/migrate-data-tool/yii/db/CDbCommand.php on line 518

@philipvandebriel:
Did you try with this settings?
//memory_limit
@ini_set('memory_limit', '-1');

On Fri, Nov 27, 2015 at 3:44 PM, philipvandebriel<EMAIL_ADDRESS>wrote:

Hi Quynhvv,
I have a memory problem in step 7, change from 2G to 8G but nothing change
;
Fatal error: Allowed memory size of<PHONE_NUMBER> bytes exhausted (tried to
allocate 88 bytes) in
/var/www/clients/client1/web2/web/migrate-data-tool/yii/db/CDbCommand.php
on line 518
—
Reply to this email directly or view it on GitHub
https://github.com/ubertheme/magento2_data_migration/issues/9#issuecomment-160071970
.

--
Best regards, Quynh Vu Van.
http://www.magentocommerce.com/certification/directory/dev/1639183/
Skype:  quynh.vv
Mobile:<PHONE_NUMBER>

Hi,
Ok i will try with -1

Hi Quynhvv,
Yes there is a problem not all my sales are migrated, same problem as quienti . Busy with sales quote now , memory is stable (no memory errors until now)

Start again with step 7 ;
replace the block will work.
foreach ($sales_order2->attributes as $key => $value){
if (isset($sales_order->$key)){
/**
* Magento 2 only accept max length of store name = 32 chars
* So we have to check length of store name here to split
*/
$val = $sales_order->$key;
if ( in_array($key, array('store_name')) && strlen($val) > 32) {
$val = substr($val, 0, 32);
}
$sales_order2->$key = $val;
}
}

Not working for me, all my order are not migrated :/ And I had add this fix...

Sales orders complete now, start with "sales quote"

Hi,
Problem with sales quote need long time ( 430000 rows more ten 12 hours), is this normal ?
mod_fcgid: error reading data from FastCGI server

Hi guys:
Let's follow this:
https://github.com/ubertheme/magento2_data_migration/releases/tag/v0.1.21


bottom links should open in new tab

slack, documentation, blog, etc.

combine w 548?

Fixed in AugurProject/augur-ui-react-components@54b53616f0e149a4651a89e8441097779f8b22db


Misspelling in the module-info.java

Hallo
I found a typo here.
requires org.kordamp.iconli.core;
I think it has to look like this.
requires org.kordamp.ikonli.core;

In previous versions of Ikonli they had a typo. Now they fixed it. Maybe you can provide a pull request that updates the ikonli libs and fixes "our" typo?

ohh sorry, I just noticed it and was about to write it, you had already answered. I use the Ikonli version 12.1.0 and 11.5.0

I updated the ikonli version used in PDFViewFX to 12.2.0.


add netBufferPool

Issues associated with this PR
Your PR should present related issues you want to solve.
Sign the CLA
Make sure you have signed the CLA
Solutions
You should show your solutions about the issues in your PR, including the overall solutions,
details and the changes. At this time, Chinese is allowed to describe these.
UT result
Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases.
And you need to show the ut result.
Benchmark
If your code involves the processing of every request, you should give the Benchmark Result
Code Style

Make sure Goimports has run
Show Golint result

Codecov Report

:exclamation: No coverage uploaded for pull request base (stable@ff0bb60). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             stable     #745   +/-   ##
=========================================
  Coverage          ?   55.42%
=========================================
  Files             ?      232
  Lines             ?    23577
  Branches          ?        0
=========================================
  Hits              ?    13068
  Misses            ?     9309
  Partials          ?     1200

Impacted Files
Coverage Δ

pkg/network/connection.go
29.27% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff0bb60...a81bdbe. Read the comment docs.


Create 2022-02-23-port-assignment-on-cisco-8100-8200-and-cisco-8800-platforms.md

This pull request has been automatically generated by prose.io.

Hi Lampros, Mike, can you please grant CS Lee access to 8000 group? Thanks.


Add LabelSelector to NamespaceSelector

I wrote a grotesquely monstrous custom NamespaceSelector comparison tool for the tests. Not sure if there was a better way to do that?
Addresses:

https://github.com/stolostron/backlog/issues/25135

/lgtm
/hold
Feel free to unhold, just giving a chance for other reviews

Haha, okay I guess I was headed in the right direction with this, then. I thought about redefining the struct so that it's alphabetical and use that to just compare strings as you suggest, but that seemed overly simple for a test. I'm glad this seems like an appropriate approach to you also. It just was starting to seem like I needed a unit test for my helper test function!

Okay, this should be good for another review. Sorry for the noise!

@dhaiducek could you please squash the last three commits together?

/unhold


fix(android): key user not authenticated

This change handles KeyStoreException "Key user not authenticated" the same way as KeyPermanentlyInvalidatedException
fixes #223

Thanks!!


Plotting variables to analyse the DDP performance

In GitLab by @cmastalli on Nov 15, 2018, 17:35
null

In GitLab by @cmastalli on Nov 15, 2018, 17:46
mentioned in merge request !14

In GitLab by @cmastalli on Nov 15, 2018, 17:47
assigned to @cmastalli

In GitLab by @cmastalli on Nov 16, 2018, 08:49
closed


Use Cabal generated information

Specifically the list of enabled extensions from the .cabal file plus the generated macro header file.

It'd also be useful to be able to point hlint at a .cabal file (or even a cabal.project or stack.yaml), instead of all the various source directories, which can add up in bigger projects.

My guess is we want a special flag --project which lets you give a project file, e.g. a .cabal file. And also, if you pass files/directories as normal, and they contain project files (cabal files) they add those files to the command line as though they had been passed with --project.
Note that I don't want to add a dependency on the Cabal library, because it's huge and changes too often. Some approximate parsing is enough.