feat: add trigger code-annotations

Description
Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.
Useful information to include:

Motivation and context of the implementation
What's the intended use of this change?
Use cases and usage examples available

Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions. Also, link to any relevant documentation useful for reviewers.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for testing this change, including any necessary setup, e.g., additional requirements, plugins, configuration variables, etc, and environment details to ensure the reviewer can test the change.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.

Any other PRs or issues that should be linked here? Any related PRs?
Any special concerns or limitations? For example: deprecations, security, or anything you think should be noted.

Checklists
Check off if complete or not applicable:
Merge Checklist:

[ ] All reviewers approved
[ ] Reviewer tested the code following the testing instructions
[ ] CI build is green
[ ] Version bumped
[ ] Changelog record added with short description of the change and current date
[ ] Documentation updated (not only docstrings)
[ ] Code dependencies reviewed
[ ] Fixup commits are squashed away
[ ] Unit tests added/updated
[ ] Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Post Merge:

[ ] Create a tag
[ ] Create a release on GitHub
[ ] Check new version is pushed to PyPI after tag-triggered build is
finished.
[ ] Delete working branch (if not needed anymore)
[ ] Upgrade the package in the Open edX platform requirements (if applicable)

Thanks for the pull request, @mariajgrimaldi!
What's next?
Please work through the following steps to get your changes ready for engineering review:
:radio_button: Get product approval
If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.

This process (including the steps you'll need to take) is documented here.

If it doesn't, simply proceed with the next step.

:radio_button: Provide context
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...

Blockers

This PR is waiting for OEP-1234 to be accepted.

Timeline information

This PR must be merged by XX date because ...

Partner information

This is for a course on edx.org.

Supporting documentation
Relevant Open edX discussion forum threads

:radio_button: Get a green build
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.
:radio_button: Update the status of your PR
Your PR is currently marked as a draft.  After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.

:radio_button: Let us know that your PR is ready for review:
Who will review my changes?
This repository is currently maintained by @openedx/hooks-extension-framework.  Tag them in a comment and let them know that your changes are ready for review.
Where can I find more information?
If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

Overview of Review Process for Community Contributions
Pull Request Status Guide
Making changes to your pull request

When can I expect my changes to be merged?
Our goal is to get community contributions seen and reviewed as efficiently as possible.
However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.


ecu addrs: check msg length

Looks like this was hit once while testing on a branch, good to catch though. Needed for https://github.com/commaai/openpilot/pull/27697 to not regress fingerprinting if a remote frame happens to be on the bus

This actually has happened quite a few times in the wild, removing my other filters. 88 times, mostly across a few dongles and mostly the Honda Civic (Bosch and Nidec).
addr_scan_exc_affected_dongles {'ecca667110ff6812', '5cfa1ad8f35779d0', 'a3f025079c99dde7', 'b9a21c12423207c5', 'a9009cfb3ac0c3c3', '7f6cd31ea33923bd'}
addr_scan_exc_affected_platforms {'HONDA CIVIC (BOSCH) 2019', 'HYUNDAI SONATA 2020', 'HONDA ACCORD 2018', 'HONDA CIVIC 2016'}


gender neutral language

change "she raises" to "they raise"

@emberstevens : Thanks for your contribution! The author, @mrbullwinkle, has been notified to review your proposed change.

This article was slated for retirement, and has now been retired and is no longer live.
#please-close


[Storage] Name properties on clients - Emulator support

This PR allows parsing the names from a url meant for emulators in storage-blob and storage-queue.

containerName and blobName for blob
queueName for queue

After the changes in this PR, storage packages currently support the following

the emulator url when the blobEndpoint is http://<IP_ADDRESS>:10000/devstoreaccount1
the emulator url when the queueEndpoint is http://<IP_ADDRESS>:10001/devstoreaccount1
emulator connection string shorthand also works

UseDevelopmentStorage=true
(with proxyURI) UseDevelopmentStorage=true;DevelopmentStorageProxyUri=http://<IP_ADDRESS>:10001

and

[Major Use Case/Scenario]  any url or a connection string that is provided for a storage account by the portal.

@XiaoningLiu mentioned that we need to add support for the following cases

endpoint is localhost, or other single word domain without any dot in the endpoint
IP addresses (v4 or v6) - For (Dev) testing environments

Considering the support to be added is non-breaking, @jeremymeng and @ramya-rao-a suggested that we do the updates after the p.5 release.
So, I believe this PR is safe to merge, I'll log an issue for the "TO DO - Add more support" which would be picked up post p.5.


Warn when changing a name to the wrong name

The title sounds amazingly infeasible, but hear me out.
Every once in a while, a local mapper gets frustrated that armchair mappers from elsewhere keep changing a road name to something it shouldn’t be. Perhaps the street-level imagery is outdated or misleading or an official source like TIGER is simply incorrect. The local mapper can tag the road with not:name (optionally with not:name:note or source:not:name). If an armchair mapper later comes along changing name to the same value as not:name, iD should issue a validation warning.
There are some other not:* tags too.

@jleedev gave an example of this road, which was changed to the same misspelling on two separate occasions.

This POI has two names in not:name. Changing name to either or both of them should result in a warning.

@1ec5 Interesting. I do think iD should honor semicolon-separated not:name values for this validation.

@1ec5 Is there consensus on how to tag incorrect names in different languages? I see a little usage of not:name:cy and not:name:en, but are these supposed to map only to name:cy and name:en? Or if a value in not:name equals name:de, should iD issue a warning?
I think I'd prefer the latter, so all incorrect names in all languages go in not:name. This could lead to some edge cases, but iD already has a field for not:name.

In general, not:x should only apply to x, and subkeys not:x:y should only apply to x:y, not x:z or x. A namespace is just that, not a specific variation of the namespaced key.
Imagine a situation where mappers feel the need to clarify that the Spanish name of a place is not the same as the local name (which happens to be in English). This seems like quite a corner case, so I guess we can wait and see if iD’s use of not:name for all languages happens to cause any problems.

@1ec5 Hmm I see your point about not crossing namespaces. Might have to re-evaluate this.


Remove GridSet class from Public API

I don't think the GridSet object really needs to be called by users at all, as they are not manually defining gridsets. All the grid information is available to the users via the Field.grid attributes, and FieldSet.gridset attributes.
I also think that the GridSet itself can be majorly simplified (ie, add_grid() removed/majorly refactored, grids being an actual set, turning it into a dataclass) to the point that we could maybe even outright replace it with some utility functions/processors that pull grid information from the Fields. That's out of topic for this issue, just a hint to where I can see this going.
@erikvansebille  any insight onto the history of the gridset class?

Yes, good point. The GridSet is perhaps a bit over-engineered. The idea was to mimic the ParticleSet architecture/structure, but the GridSet is, as you say, much simpler; essentially just a list (set?) of Grids.
So yes, there could certainly be some cleaning here!


Problem changing light color in HomeKit since 0.81.

Home Assistant release with the issue:
0.81.x

Last working Home Assistant release (if known):
0.80.3
Operating environment (Hass.io/Docker/Windows/etc.):
Raspberry Pi 3B, Raspbian 9, Python 3.5

Component/platform:
https://www.home-assistant.io/components/homekit/

Description of problem:
Since the upgrade, RGB lighting entities no longer function correctly in HomeKit. For example, I have an RGB bulb running ESPurna that connects to HA via the MQTT Light component and HA forwards that light to HomeKit. Since 0.81 I can no longer directly change the bulb’s color in HomeKit using the color wheel; however, the color temperature wheel does still work. The weird thing is, If I change the color temperature first, then I’m able to change the bulb’s color once. The color wheel shows up for the device in HomeKit, however the change is never actually applied by HA. Initially, HomeKit shows the device color as having changed, but if you back out of the light’s color settings and come back it shows the color didn’t actually change (as reflected in HA and by the light itself).
So: Change Color Temperature -> Change Color works. But: Change Color -> Change Color doesn’t work.
I’ve verified changing the bulb’s color multiple times directly in HA works fine. I’m also seeing the HomeKit requests in the HA log when trying to change color. After downgrading to 0.80.3 the problem goes away, so there seems to be an issue with either some of the HomeKit changes made in 0.81.x or problems with the new version of hap-python that 0.81.x is using.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
mqtt:
  broker: localhost
  username: hass
  password: !secret mqtt_password
  client_id: HASS-<MAC Address Removed>
  birth_message:
    topic: 'homeassistant/status'
    payload: 'online'
  will_message:
    topic: 'homeassistant/status'
    payload: 'offline'
  discovery: true
  discovery_prefix: homeassistant

# Apple Homekit Bridge
homekit:
  auto_start: false
  filter:
    include_entities:
      - light.ceiling_fan_light
      - light.bathroom_light
      - light.hallway_light
      - media_player.directv
      - switch.audio_stack
      - switch.desk_lamps
      - switch.soldering_iron
      - climate.thermostat77083b
      - sensor.bme680_temperature
      - sensor.bme680_humidity

Traceback (if applicable):

Additional information:

Does this error occur for all lights (even different platforms)?
Can you test the demo light platform. I ran a quick test and didn't noticed anything unusual. It's probably not the HAP-python update, since that included mostly bugfixes.

Same Issue.  Yeelight RGB bulb.  HassIO 1.4.0

@cdce8p I meant to mention that, as a test, I included one of my LIFX bulb entities in the HomeKit bridge (or maybe it was a Flux LED bulb I had sitting around; I’ve done so much testing the last few days I can’t remember) and it had the same problem.
Later tonight I’ll make a seperate install of 0.81.x and test the Demo Light platform.

@timothybrown thank you for describing this issue as I am having the same problems and seeing the exact same symptoms .  I am new to Home Assistant (2 weeks) and just got the Yeelight yesterday so wasn't sure if the mistake was on my end or not until I found your post.
I will say I have perfect control of the Yeelight both from Home Assistant as well as Amazon Alexa (exposed via Haaska, not linking it to Yeelight's cloud) so I concur the trouble is only while attempting control through HomeKit or Siri.
.... anxiously standing by to see what the experts find.

I believe I finally know what you're describing. To set a color in HA form HomeKit, HA needs a change in saturation and hue to happen. Until the latest update, this wasn't a problem since both where updated simultaneously. However with https://github.com/ikalchev/HAP-python/pull/162 I excluded calls with the same values which is the reason setting a different color (with the same saturation) doesn't work anymore.
I'll open a PR in HAP-python to revert this change.

This will be fixed with 0.81.3.

I just wanted to update this and confirm that the problem appears to be fixed since the 0.81.4 update. Thanks!


I can't run run_sr.lua

The following is my mistake：
t_folder=dataset/ model_folder=model/ th run_sr.lua                                                                          {
ntrain : inf
beta1 : 0.9
name : "super_resolution"
dataset : "folder"
niter : 250
lr : 0.001
model_folder : "model/"
gpu : 1
nThreads : 4
t_folder : "dataset/"
batchSize : 32
loadSize : 96
}
Starting donkey with id: 1 seed: 1
table: 0x40c0e918
Starting donkey with id: 3 seed: 3
table: 0x41c70418
Starting donkey with id: 4 seed: 4
table: 0x410d8418
Starting donkey with id: 2 seed: 2
table: 0x41b53db0
Creating train metadata
table: 0x41632658
Creating train metadata
table: 0x410d8a28
Creating train metadata
table: 0x40222228
Creating train metadata
table: 0x40c0ebf0
running "find" on each class directory, and concatenate all those filenames into a single file containing all image paths for a given class
now combine all the files to a single large file
running "find" on each class directory, and concatenate all those filenames into a single file containing all image paths for a given class
load the large concatenated list of sample paths to self.imagePath
now combine all the files to a single large file
load the large concatenated list of sample paths to self.imagePath
running "find" on each class directory, and concatenate all those filenames into a single file containing all image paths for a given class
now combine all the files to a single large file
load the large concatenated list of sample paths to self.imagePath
/root/torch/install/bin/luajit: /root/torch/install/share/lua/5.1/threads/threads.lua:183: [thread 4 callback] .../Photo-Realistic-Super-Resoluton-master/data/dataset.lua:210: Could not find any image file in the given input paths
stack traceback:
[C]: in function 'assert'
.../Photo-Realistic-Super-Resoluton-master/data/dataset.lua:210: in function '__init'
/root/torch/install/share/lua/5.1/torch/init.lua:91: in function </root/torch/install/share/lua/5.1/torch/init.lua:87>
[C]: in function 'dataLoader'
...tic-Super-Resoluton-master/data/donkey_folder_supres.lua:69: in main chunk
[C]: in function 'dofile'
/home/Photo-Realistic-Super-Resoluton-master/data/data.lua:33: in function </home/Photo-Realistic-Super-Resoluton-master/data/data.lua:23>
[C]: in function 'xpcall'
/root/torch/install/share/lua/5.1/threads/threads.lua:234: in function 'callback'
/root/torch/install/share/lua/5.1/threads/queue.lua:65: in function </root/torch/install/share/lua/5.1/threads/queue.lua:41>
[C]: in function 'pcall'
/root/torch/install/share/lua/5.1/threads/queue.lua:40: in function 'dojob'
[string "  local Queue = require 'threads.queue'..."]:13: in main chunk
stack traceback:
[C]: in function 'error'
/root/torch/install/share/lua/5.1/threads/threads.lua:183: in function 'dojob'
/root/torch/install/share/lua/5.1/threads/threads.lua:264: in function 'synchronize'
/root/torch/install/share/lua/5.1/threads/threads.lua:142: in function 'specific'
/root/torch/install/share/lua/5.1/threads/threads.lua:125: in function 'Threads'
/home/Photo-Realistic-Super-Resoluton-master/data/data.lua:21: in function 'new'
run_sr.lua:31: in main chunk
[C]: in function 'dofile'
/root/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:145: in main chunk
[C]: at 0x00406670
I'm sure I have the training data I need in my catalog.
Can you help me?

I have the same problem. Have you solved it?


Card mixin

I'm aware that currently cards are a lot simpler than buttons right now
but this may change in future and it feels cleaner to be able to create
new card styles without needing to know the internals of how they're
implemented.

Thanks!


Please provide package repositories for important Linux distros

Please provide packges for important Linux distros like Debian, Ubuntu, Centos.
It seems awkward to me that I should check for a new version of these tools and install them manually.

It makes more sense to ask questions like this on the prometheus-users mailing list rather than in a GitHub issue. On the mailing list, more people are available to potentially respond to your question, and the whole community can benefit from the answers provided.


Fix bug when no name was configured

The mail contained "Hello undefined"

Thanks so much for your contribution @maryum375! 😄
LGTM. Next time, please format your code according to the project's code style. 👍

Released v1.0.26 @maryum375 👍


package reinstall

Don't know this issue is related to this place but I want to share here as I'm using angular 5 template.
We working on remote server vsts. One of my colleague install third party library and PR was completed for those package changes. After I clone the master with new branch I end up with error  can not find module "Third party library "

Package(Third party library) exists in package.json and package-lock.json  but not in node_modules directory.
Are we doing any thing wrong in installing packages, we never faced this issue while using aspnetcore 2.0 angular 2 template.

@SteveSanderson  Every time I need to do this (when ever any of us install third party package)? no other way ? just like core packages getting Installed default with out running  any command after cloning.


Update README.md

Addresses some typos and tweaks some of the sentences for clarity

Thanks @marcjay appreciate it! English is not my first language so really appreciate the review!


Decimals columns in european de-DE culture misbehaving and null-ing the values

Decimals columns in european "de-DE" culture misbehaving and null-ing the values.
In (de-DE) culture decimal point is [,] and thousand separator is [.]

Does this issue occur when the grid loads for the first time or when an attempt is made to modify the value in a numeric column?
Do you see any JavaScript errors in the browser console window?
What version of CRM is used?

Ok, apologies, it is our mistake.
We have changed a bit the main code to adapt for our needs, one change was to use  elements instead of  for editable fields and that failed width jquery .find() .. in the updates.
Just to answer your questions: we use it in a Dynamics 365 online solution, no errors in the browser console, we just modified a [quantity] field and got always nulled because of the mismatch.
Want to point out that your work in this project is awesome and we appreciate it. Thumbs up!
There are a few places for improvements but that's why we started to customize the component to fit our scenario.
Kind regards,
Claudiu


Update datasets to 2.20.0

Update datasets to 2.20.0.
This PR is intended to address the CI errors raised by this update, as a first step before:

#3037

Note I have commented an assertion is test_statistics_endpoint: c437c9f

pandas downcasts a float column to int if all the numbers can be downcast to integers, e.g. [1.0, 2.0, 3.0]
I don't think this is a big issue


Slow download

It looks that xcode-install is downloading 5x times slower the Xcode.dmg than through Safari.
I run xcode-install install 7, and while it was downloading I checked in Activity Monitor to see the download speed. It was between 700KB/s - 1MB/s.
Then, while xcode-install was downloading the dmg, I started another download through Safari. Safari was downloading it with 5.6MB/s.
It looks that is a limitation of the curl command. To be able to do a multi-part download, would require to run several instances of curl at the same time for different file parts.

This is how it might look when run from shell:
url=https://developer.apple.com/downloads/xcode.dmg

curl -fsSL --range 0-900000000 -o xcode.part1 $url &
proc1=$!

curl -fsSL --range 900000001-1800000000 -o xcode.part2 $url &
proc2=$!

curl -fsSL --range<PHONE_NUMBER>-2700000000 -o xcode.part3 $url &
proc3=$!

curl -fsSL --range<PHONE_NUMBER>- -o xcode.part4 $url &
proc4=$!

wait $proc1 $proc2 $proc3 $proc4

cat xcode.part? > xcode.dmg

Not sure anymore if this is an issue, because suddenly it started to work fine.
Closing for now.


nrf_rtc_timer: fix for announcement starvation

This PR provides the Nordic fix for #20585.  It also provides a test application that can be used to verify the presence of the bug.
Sample output of the test for unpatched Nordic devices (fixed in this PR):
[    60.069] 599: still running, would pass at 3600 s
[   120.081] 1197: still running, would pass at 3600 s
[   180.016] 1794: still running, would pass at 3600 s
[   240.051] 2392: still running, would pass at 3600 s
[   300.080] 2990: still running, would pass at 3600 s
[   360.018] 3587: still running, would pass at 3600 s
[   420.050] 4185: still running, would pass at 3600 s
[   480.071] 4783: still running, would pass at 3600 s

    Assertion failed at ../src/main.c:69: test_starve: (now_diff > 0 is false)
[     0.094] 5102: Time went backwards by 511900: was 511.994

FAIL - test_starve

Sample output of the test for unpatched SysTick devices (nucleo_l476rg) (fixed in #15478):

Running test suite starve_fn
===================================================================
starting test - test_starve
Cycle clock runs at 80000000 kHz
There are 8000 cycles per tick (10000 Hz ticks)
[     0.023] 1: still running, would pass at 3600 s

    Assertion failed at ../src/main.c:69: test_starve: (now_diff > 0 is false)
[     0.001] 537: Time went backwards by 53587: was 53.588

FAIL - test_starve

Context and timer_API tests are failing for nrf5340, cpuapp. @pabigot could you run the tests for nrf53? This core runs on 128 MHz

Context and timer_API tests are failing for nrf5340, cpuapp.

Those fail for me on master as well.  Last touch to this file was #20940 ; reverting that doesn't make it work on nrf53.

Proposed for 2.1.  It does fix the Nordic part of #20585.

Tested this on all nRF SoCs - no issues observed (specific to this patch)


Prevent Invalid Character Entry - Copy and Paste

Currently, you can still paste invalid characters into an input box when "preventInvalidInput: true".

preventInvalidInput uses the keyPress event to prevent entering invalid input. After each keyPress it confirms the current key that was pressed is valid. It doesn't look at the whole value for the input box. That's why pasting in a value bypasses the prevention.
I really don't want to check the whole input value every time a key is pressed because performing regex matches can get quite expensive. If you really want to prevent the user from pasting invalid input, then I recommend creating another directive that does it and apply it to the input box.


Update single value to single stream api added

Ready for Review

@kristinpeterson and @sarahhenkens: Please review.

@aryajsomanpillai @kk25q Can you squash the commits into one? http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

Squashed all commits. Ready for Review.


Tui alt

Missing 2 pages, but functional for NGT

I apologize for the size of this PR

Issues encountered:
white patch rows/cols text field can't be deleted
target selection window doesn't close immediately on pressing c
no error message/tui doesn't work when terminal is a small size


[IDE][Sema] Add test cases for issues no longer occurring in the stress tester

SR-14708 and SR-15497 are no longer happening in the stress tester. Add their test case to the test suite.
rdar://78781625
rdar://85602946

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please test


pacaur and pacman-like command sets can be mixed

Pacaur specific command set (-s, -i, -d, -m,  -y, -k, -u) and pacman-like command set (-S, -Ss, -Si, -Sw, -Su, -Qu) can be mixed resulting in erratic behavior.
Includes a sanity check to avoid this mess. When detected, pacman-like command should take precedence over pacaur specific commands and pass the additional options to pacman.

In addition to be not trivial to fix, this bug is absolutely boring to fix. Knowing that the best workaround is simply to not mix the command sets, I guess I'll never fix it. Better relying on user practical sense rather than adding lot of ugly code that decrease maintainability. After all, nobody complained since that issue has been opened 5 months ago, and man page has already been much improved to avoid any confusion.
Closing as "wontfix", or rather "ll'never fix it, it's not worth it".


Full-text run search

This is a work based on PR of https://github.com/sematic-ai/sematic/pull/482
Since that branch is not rebased, the remaining work continues on this branch.
Support full-text search for the name, calculator_path, description, source_code, id, tags fields. There is a new page(UI) for searching runs.

Closes #546

Confine scroll bar to array rows, make search field, array header and pagination sticky. Make width fixed. Thank you.

These changes are made. Screencast is updated in the description. I will keep working on the Python part. But in case you found area of improvement for the frontend part, please also let me know.

Thanks for reviewing the PR. Please take another look!


[BXMSPROD-1355][1.7.x] GA flow dynamic mapping

https://issues.redhat.com/browse/BXMSPROD-1355
related PRs:

https://github.com/kiegroup/kogito-pipelines/pull/184
https://github.com/kiegroup/kogito-apps/pull/879
https://github.com/kiegroup/kogito-examples/pull/725
https://github.com/kiegroup/kogito-runtimes/pull/1360

The Linux check is successful.


Fleet without label selector is assigned to all devices

If a fleet is generated without a label selector, it will be assigned to all devices, including those with a fleet selector, and will create a conflict on them.

This commit should have fixed the issue - is it included in your setup?
https://github.com/flightctl/flightctl/commit/e1f3380c5d65b68c8af0bc45147eea462a9bd2e0


Warn on unused MagicHash (fixes #357)

Here you go sir, let me know if I've tested this sufficiently. Cheers!

Thanks! Does magic hash allow # just as a suffix? Or in the middle? Is a#b allowed?

Yup, just at the end. All identifiers, including type class names (!). Yes, a#b is allowed... though it means a # b ;)

Pull request looks textbook perfect - thanks a lot - merged with gratitude!


Suggestion: Make bars under search bars animated.

This is just a suggestion so i'm not really expecting a response to this but i'll go ahead and say it anyways.
In order to make it a more comfy look and feeling, you should make the search bars in the theme animated. What i'm saying is that when it is clicked, the blue line under it can slide out to either side, instead of it just appearing. I feel that many people will like this new feature and that it will make the theme just a tad bit better.
This can be done with a simple addition of css code.

Here is another example of what I was talking about: https://stackoverflow.com/questions/46887024/underline-animation-on-click
Let me know if you do agree to this.

While it would look nice, it's not part of the Fluent UI design system.
So it won't be added.

Oh ok, No problem.
I have the code for this.. you can dm me for it if you change your mind. Kiyoshi#5246


Static Typing

This PR leverages existing BYOND as syntax (and 515 proc return types) to implement static typing in a way that's completely compatible with BYOND syntax. It's a continuation of https://github.com/OpenDreamProject/OpenDream/pull/336 that also supports vars.
Procs:

Vars:

TODO:

[x] Support proc arg type declarations
[x] Finish adding type annotations to the stddef (will do in future PRs)
[ ] Tons of unit tests
[ ] Handle var/datum/foo as text (emit a pragma for as on non-root vars)
[ ] Find other cases where astypes aren't properly handled
[ ] Decide on a default pragma config setting for this
[ ] Figure out what to do about 515's /proc/foo() as /datum/bar
[ ] Rewrite the error messages to have less-sucky formatting
[ ] Misc cleanup (this PR was initially a copypaste of #336 and may have some stinky holdovers)

Superceded by https://github.com/OpenDreamProject/OpenDream/pull/1705


Remove IDictionary from IIsADictionary<TKey,TValue> definition

This removes any ambiguity when enumerating the items in an instance of IIsADictionary<TKey,TValue>.
Any implementation of IIsADictionary<TKey, TValue> must always provide implementations for the contract of IDictionary<TKey, TValue> so there is little value in having the IDictionary contract where boxing and unboxing will be incurred, except to distinguish types that implement IDictionary that are not IIsADictionary.
Removes the cost boxing of values in VerbatimDictionaryKeysConverter by having TKey and TValue generic type parameters.

ported to 5.x in https://github.com/elastic/elasticsearch-net/commit/4dd15772415c64b87e7122d650788b84e16cdc61


[1.12] Plant Interactor in Compact Machine crashes save during launch

Industrial Foregoing Version:
1.12.2-1.12.13-237
TeslaCoreLib Version:
1.0.15
Crashlog If Applicable (Upload to pastebin/gist):
https://pastebin.com/3a8VQ4t9
I have 3-4 Plant Interactors growing crops in several 13x13x13 Compact Machines.  For some reason when I launch the game it crashes (See block entity being ticked data in pastebin). Game ran fine last night and I did a backup right before shutting down.. I will see if recovering a backup resolves the issue or allows the save to launch.

Discord Integration Issue

Confirmed: Save launches after disabling Discord mod.


API changed

Hi,
since they published a new App for the Lavviebot the API URLs changed :-(
I tried packet capture on my phone and i see connections to amazon aws.
maybe you could upgrade this project?
greets
Marcel

ok i'll have to wait than. Yeah i love it! Would be great to get the usage notification to start the robot vacuum after cats distributed litter everywhere ;-)

Are you referring to the IoT usage Log found in the cat tab of the app or the cat log found under IoT device?

@marcelverdult
Library and Home Assistant integration have been rewritten.


File with a fake circular dependency to itself

I've noticed a strange behavior with madge. It turns out that I have a file called auth0.ts, which acts as a facade for Auth0, which starts like this:
import * as Auth0 from "auth0";
This is not a circular dependency, as I have installed the auth0 package via npm, and it shows up in my package.json. The import works as expected, giving me access to the content of  the auth0 package. However, running npx madge -c auth0.ts still complains:
Processed 1 file (608ms) (1 warning)

✖ Found 1 circular dependency!

1) auth0.ts

I have this same issue with an absolute path named utils and any other file named utils
// src/components/shared/utils.ts
import { myFunc } from 'utils'

This results in an image like this:

Workaround is to use a relative path, for now.

Hey! Does it still happen if you set includeNpm to true: https://github.com/pahen/madge#configuration?

Hey @mrjoelkemp, thanks for chipping in! I can confirm I'm still hitting the same issue with includeNpm: true in the config.

Thanks for confirming. We just delegate to the typescript compiler for module path resolution: https://github.com/dependents/node-filing-cabinet/blob/master/index.js#L145-L153. Are you supplying a typescript config? If so, perhaps there's a relevant configuration option you can set.

I run into this issue too, it appears like it's trying to use the classic moduleResolution, even though I have set node

The problem occurs when using extends. If the moduleResolution is changed in the base config, but not in the config file, then the problem occurs.

This also happened to us but we're not using TS. I have a module on redux/index.js (imported elsewhere as ./redux) that acts as a facade to Redux. The first line is import { combineReducers } from 'redux' which I'm guessing is the one detected as a circular dependency.
Using it as CLI on v4.0.2.

This happens to me as well. If you have a file named foo.ts that has an import from "foo" despite "foo" being an npm module madge will act as if the file imports itself.

I had the same problem and found out, that supplying madge the path to the tsconfig instead of the tsconfig object causes madge (or a dependency of it) to provide its dependencies a tsconfig object that does not contain strings for compilerOptions.module and compilerOptions.moduleResolution respectively (we are using esnext and node for those) but numbers. The receiving side then tries to find the corresponding (canonicalized?) value and sees a number and removes it, which in turn results in undefined for those two values. As a workaround I used get-tsconfig like this which is capable of ignoring comments in a tsconfig:
  import { getTsconfig } from 'get-tsconfig';

  const { config } = getTsconfig(tsConfigPath);
  const madgeResult = await madge(path.join(__dirname, './src'), {
    tsConfig: config,
  });

Supplying the object instead of the path seems to not cause the aforementioned removal of those options.
This not only fixed the problems mentioned in this issue, but various missing resolved dependencies to directories containing an index.ts

This seems to be the culprit. It causes property-values of the wrong format (numbers instead of strings) to be written over the correct ones. Maybe just pick the values that are actually needed or exclude the ones, that can already be found in the target?

Hi 👋
I was implementing madge in a project today, and I found this issue. I followed the chain of calls and the problem is what @mx-bernhard mentioned:
Let's say you have a tsconfig.json with these props:
{
  "compilerOptions": {
    "target": "es5",
    "module": "esnext",
    "moduleResolution": "node"
  }
}

If you run madge via CLI and send --ts-config tsconfig.json, you'll end up in this if, which will read the tsconfig.json and format its compilerOptions using TypeScript's parseJsonSourceFileConfigFileContent, which will replace those string values with (probably) enum indexes:
{
  "compilerOptions": {
    "target": 1,
    "module": 99,
    "moduleResolution": 2
  }
}

Now, the problem is that the generated object (with numbers instead of strings) is what madge sends down to its dependencies, specially filing-cabinet.
Inside filing-cabinet, when trying to resolve a path a for ts files, we end up in this check, which runs TypeScript's convertCompilerOptionsFromJson, and yes, that function expects strings, not numbers, so the result is
{
  "compilerOptions": {
    "target": undefined,
    "module": undefined,
    "moduleResolution": undefined
  }
}

For anyone interested, I just made a small workaround to be able to use CLI:
Since madge uses the rc package, and as @mx-bernhard pointed on their comment, "Supplying the object instead of the path seems to not cause the aforementioned removal of those options.", I made a shell script that would read the tsconfig.json, put it on a .madgerc and then run the CLI.
#!/bin/sh -e

TS_CONFIG=$(node -e "console.log(JSON.stringify(require('get-tsconfig').getTsconfig().config, null, 2))")

JSON_STRING=$(cat <<EOF
{
  "_note_": "This file is autogenerated",
  "tsConfig": $TS_CONFIG,
  "fileExtensions": ["js", "ts", "tsx"]
}
EOF
)

echo "$JSON_STRING" > .madgerc
madge ./src -c --warning

This is called from a script in the package.json, but if you indent to run it directly, you should prefix the call to madge with pnpm exec/npx/yarn dlx/whatever.
Don't forget to chmod +x

(I really like the ora UI :P)


systemd: fix degraded warning

The reload can actually fail when trying to warn about degraded units because it was running the --state=failed query incorrectly, and then it wouldn't actually reload anything:
The user systemd session is degraded:
Failed to connect to bus: No such file or directory
home-manager.service: Main process exited, code=exited, status=1/FAILURE

Doh! Thanks for the fix!

Can it be backported to 19.09, please?

@wedens Yep, done!


[BUG] Create certification campaign check for option field correlated_status

Trying to create a search campaign using SDK however I keep getting validation error for an option field correlated_status. It is defined as a type dict. So it needs some value of type dict but the validation code then checks against enum so overall the validation fails. I was able to work around the problem by changing the type for correlated_status to StrictStr. It is an optional field but it looks like because of dict type it has become mandatory?

Here is the error if you don't pass the correlated status in Campaign
correlatedStatus
Input should be a valid dictionary [type=dict_type, input_value='CORRELATED', input_type=str]
For further information visit https://errors.pydantic.dev/2.8/v/dict_type
If you pass it in dict format then the error is for allowed values
Value error, must be one of enum values ('CORRELATED', 'UNCORRELATED') [type=value_error, input_value={'type': 'dict_type', 'in...}, 'input_type': 'list'}, input_type=dict]
For further information visit https://errors.pydantic.dev/2.8/v/value_error
I was able to make it work by changing the type of that field to str in campaign.py
correlated_status: Optional[StrictStr]

The issue appears to be same as reported in #21

Hey @niranjan-pontis, you are correct that this is a duplicate of #21. This has been fixed in https://github.com/sailpoint-oss/python-sdk/commit/59b096ba03213367f492f2ed0040b44727ef08a7


api_key cannot be defined without access_token

Describe the bug
I cannot specify api_key since it fails and requests to specify access_token (which then takes precedence)
(I am aware that the key is deprecated and I want to move to the token asap 😃 )
I reduced my problem to the following dummy code
terraform {
  required_version = ">= 1"
  required_providers {
    artifactory = {
      source  = "jfrog/artifactory"
      version = "10.7.6"
    }
  }
}

provider "artifactory" {
  url           = "https://jfrog.com"
  check_license = false
  api_key       = "not-a-real-key"
}

data "artifactory_file" "code" {
  repository  = "no-real-repo"
  path        = "no-real-path"
  output_path = "${path.module}/code.zip"
}

failing with
│ Error: Missing JFrog Access Token
│
│   with provider["registry.terraform.io/jfrog/artifactory"],
│   on test.tf line 11, in provider "artifactory":
│   11: provider "artifactory" {
│
│ While configuring the provider, the Access Token was not found in the JFROG_ACCESS_TOKEN/ARTIFACTORY_ACCESS_TOKEN environment variable or provider
│ configuration block access_token attribute.
╵

I assume the problem is that only the token is validated without checking if the key was specified: https://github.com/jfrog/terraform-provider-artifactory/blob/1942a28912362a431a0cdb0e93f3a859089e7de4/pkg/artifactory/provider/framework.go#L142-L150
With:

Terraform v1.7.5 on darwin_arm64
provider registry.terraform.io/jfrog/artifactory v10.7.6
Artifactory 7.41.12

Expected behavior
The Terraform run is successfully authenticating using the api_key and does not ask for the access_token.
Additional context
Add any other context about the problem here.

@kelvin-glass-db Thanks for the report! I've added this issue to our plan.


Adding missing !default in sass variables

Making all the variables overwriteable from my own project, when having the plugin installed via NPM or Bower.

Thanks!


Streamline server specific entry points

Kestrel and WebListener have their own Program.Main that wraps Hosting's. This allows the commands to be simplified, but requires each server to add its own --server parameter. See https://github.com/aspnet/KestrelHttpServer/blob/dev/src/Kestrel/Program.cs#L15-L20
Proposal: Add a code path in Hosting's Program class that allows servers to directly provide a reference to their server factory that will be passed into WebHostBuilder.UseServer(IServerFactory factory)
Note we want to avoid just duplicating the logic from Hosting's Main method in the other servers, as that becomes difficult to maintain. It's already hard enough to maintain IIS's parallel startup code.

Do we still need this? I think we should remove the server specific entry points in RC2.

If the server entrypoints go away then you don't need this exact item, but you need almost the same thing for WebApplication.Run to specify the server.

As part of https://github.com/aspnet/Hosting/issues/525, the only entry point will now be in Startup.Main.


this.renderer.pipelines not recognised by TypeScript

Phaser Version: Phaser v3.52.0 (WebGL | Web Audio)

Operating system: N/A

Browser: N/A

Description

Seems like some type definitions missing from typescript. Pipelines definitely exists under renderer as I can use them if i disable typescript.
Example Test Code

with typescript enabled just try
this.renderer.pipelines
Additional Information

This is because pipelines doesn't exist on CanvasRenderer (and never will). You'll have to force-type this.renderer yourself to WebGLRenderer in your code to avoid the error.


The fleet telemetry log shows the following, may I ask which certificate is incorrect?

{"activity":true,"context":"fleet-telemetry","level":"info","msg":"2024/10/17 07:04:42 http: TLS handshake error from <IP_ADDRESS>:33972: tls: client didn't provide a certificate\n","time":"2024-10-17T07:04:42Z"}

"tls": {
"server_cert": "/etc/certs/server/telemetry.test.etc.hrhaoche.com_public.crt",
"server_key": "/etc/certs/server/telemetry.test.etc.hrhaoche.com.key"
},
"ca": "/etc/certs/server/0001_chain.pem"

{"activity":true,"context":"fleet-telemetry","level":"info","msg":"2024/10/17 07:28:04 http: TLS handshake error from <IP_ADDRESS>:42603: remote error: tls: bad certificate\n","time":"2024-10-17T07:28:04Z"}
{"activity":true,"context":"fleet-telemetry","level":"info","msg":"2024/10/17 07:28:32 http: TLS handshake error from <IP_ADDRESS>:63486: remote error: tls: bad certificate\n","time":"2024-10-17T07:28:32Z"}
{"activity":true,"context":"fleet-telemetry","level":"info","msg":"2024/10/17 07:28:38 http: TLS handshake error from <IP_ADDRESS>:36844: tls: client didn't provide a certificate\n","time":"2024-10-17T07:28:38Z"}

2024-10-17 14:51:55,923 I  [TeslaHttpUtil       ] -353- param: {"config":{"hostname":"telemetry.test.etc.hrhaoche.com","port":443,"fields":{"VehicleSpeed":{"interval_seconds":60}},"ca":"-----BEGIN CERTIFICATE-----\nMK9T7jD91xiFCC3ho9ijamUShzl5J2uul4A\nIw==\n-----END CERTIFICATE-----\n"},"vins":["LRW3E7ET3RC217335"]}
2024-10-17 14:51:55,930 I  [TeslaHttpUtil       ] -357- httpPost: POST https://<IP_ADDRESS>/api/1/vehicles/fleet_telemetry_config HTTP/1.1
2024-10-17 14:51:56,532 I  [TeslaHttpUtil       ] -361- Response body: {"response":{"updated_vehicles":1}}

[root@iZ6we1ixwfxc3flb8l3stwZ server]#    openssl rsa -in /etc/certs/server/telemetry.test.etc.hrhaoche.com.key -pubout -outform pem | openssl pkey -pubin -pubout -outform pem > private.pub
writing RSA key
[root@iZ6we1ixwfxc3flb8l3stwZ server]#
[root@iZ6we1ixwfxc3flb8l3stwZ server]# openssl x509 -in /etc/certs/server/telemetry.test.etc.hrhaoche.com_public.crt -pubkey -noout -outform pem > certificate.pub
[root@iZ6we1ixwfxc3flb8l3stwZ server]# diff private.pub certificate.pub
[root@iZ6we1ixwfxc3flb8l3stwZ server]#


Macro keys as hotkeys

First of all this is a great little app. However, I'm not sure if it is just the keyboard I am using (Razer Blackwidow), but the macro keys do not seem to work as hotkeys.
It would be great it these could be used as hotkeys. I understand that this is a very small issue, so no worries if you don't plan on adding this anytime soon!

There was a request for this on Logitech keyboards, and something tells me that I had to include the Logitech SDK to detect them.
I have a Razer Blackwidow, so can see what it produces.
My gut feeling is that it will require an SDK too. Will update the issue with my findings.

Assing any combination to the hotkey, and then bind this combination to the macro switch using whatever resource your keyboard have. Did the trick for me.

Third party keyboard support requires drivers/libraries.
As mentioned a good solution is to map the macro key to a key combination, and use that combination as the hotkey in audio switcher.


Add support for initial password in login dialog

Adds the ability to set an initial password in the login dialog.  Use case is if a password is stored  it can be retrieved "displayed" in the login dialog the next time it is opened.

thx @Stoom


APPS/{x509,req}: Fix description and diagnostics of -key, -in, etc. options - port to 3.0

This is a proposed backport of #16440 (as discussed there) from master to 3.0:
Over the years, the x509 and req app options have become a mess
and their documentation and help output is partly outdated, incomplete, or even wrong.
I recently came across this issue again when extending the tests in #16342.
This PR improves the description of the -key, -in, and related options
and adds some warnings for useless or problematic option combinations.
Note that this does not change the semantics of the options.

[x] documentation is added or updated

I am afraid this is more than just a pure bug or doc fix. For that reason this IMO cannot be merged to 3.0 branch. I could approve this for master branch though.

All these changes are already in master.
Which of them should I remove for the variant to be included in 3.0?

All these changes are already in master. Which of them should I remove for the variant to be included in 3.0?

The newly added warning messages.

So I've removed in this backport PR the newly added warning messages.

This pull request is ready to merge

Merged - thanks


Add EVOLVEO Heat M30v2 TRV

Adds the manufacturer code _TZE200_8whxpsiw for the EVOLVEO Heat M30v2 TRV.
Fixes: #1798

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.699%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5310

Relevant Lines:
7406

💛  - Coveralls

Codecov Report
Base: 71.69% // Head: 71.69% // No change to project coverage :thumbsup:

Coverage data is based on head (f897f0c) compared to base (aa476ad).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1800   +/-   ##
=======================================
  Coverage   71.69%   71.69%
=======================================
  Files         239      239
  Lines        7406     7406
=======================================
  Hits         5310     5310
  Misses       2096     2096

Impacted Files
Coverage Δ

zhaquirks/tuya/ts0601_trv.py
33.21% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


How to load model and images in this project

Please author help me to run this program, I'm trying to learn something from your work but somehow I cannot able run this program. it gives me this error
"usage: main.py [-h] [-t THRESHOLD] model id_folder [id_folder ...]
main.py: error: the following arguments are required: model, id_folder"
please anybody help me :(

You need to enter this code in your virtual environment (TensorFlow):cd C:\Users\Dell\Desktop\ Facerecognition-master\Facerecognition-master (change it to your path),then enter:python main.py ./20170512-110547/20170512-110547/20170512-110547.pb ./ids/(change it to your path)

As mentioned above you need to pass the model and a directory with images. There are more detailed instructions in the readme. The structure of the directory with images is very important so make sure you get it right.


PER-4777 Collect sessions transformer

New transformer that will create a final list per grouping key by concatenating sublists and order them based on a time (recency) and score (relevance) manner.

Update on the open question around the grouping by from: https://github.com/tidal-music/per-transformers/pull/19/files#r1792117572
After double checking, there doesn't seem to be a clean solution to do the aggregation in another way.
The challenge comes from having to generate 2 aggregations that are using different windows (one by time and the other by score).
For a dataset with:

The initial aggregation will construct the resulting list accumulating step by step, producing the following result:

At that point, the most recent session will contain the final form of the collected items by recency and the lowest scored session will contain the collected items by relevance.

Which then can get selected in a max aggregation.

Found a new way of selecting the last incrementally generated collected list by using F.last() in separate steps and then joining.


Generating API with amplify codegen

Describe the bug
Getting next error while generating API with amplify codegen
`amplify codegen
Downloaded the schema
Code generated successfully and saved in file src/app/API.service.ts
(node:89114) UnhandledPromiseRejectionWarning: SyntaxError: Syntax Error: Expected Name, found ( (187:7)
185 |   )
186 | {

187 |       (
|       ^
188 |       company:$company,
189 |       showDeleted:$showDeleted
190 |   )
at t (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/prettier/parser-graphql.js:1:511)
at Object.parse (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/prettier/parser-graphql.js:1:50995)
at Object.parse (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/prettier/index.js:9739:19)
at coreFormat (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/prettier/index.js:13252:23)
at format (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/prettier/index.js:13510:73)
at formatWithCursor (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/prettier/index.js:13526:12)
at /usr/local/lib/node_modules/@aws-amplify/cli/node_modules/prettier/index.js:44207:15
at Object.format (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/prettier/index.js:44226:12)
at format (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/amplify-graphql-docs-generator/lib/src/index.ts:111:19)
at render (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/amplify-graphql-docs-generator/lib/src/index.ts:78:10)
(node:89114) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:89114) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
⠸ Generating GraphQL operations^C
`

Amplify CLI Version
4.5.0
To Reproduce
Steps to reproduce the behavior or terminal output if applicable
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Mac
Node Version v13.2.0

Additional context
Add any other context about the problem here.

@vitaliyzolotoy is amplify api gql-compile succeeds? Please share the generated API.service.ts as it seems that prettier has some problem with it. Is tsc able to compile the above file or there is a syntax error in the generated code?

amplify api gql-compile was succeed. API.service.ts was empty

amplify api gql-compile runs but did not gererate queries and mutations

Hi @vitaliyzolotoy could you provide more detailed steps for reproducing this?

Closing this issue since I am not able to reproduce this. Please comment if you have more detailed steps for reproducing this version with 4.11.0


Improve pre-commit

Initializes the pre-commit script on rebuild as well, runs npm install silently and exits if npm install errors

How about just on switch to dev?

dev is the default option so we can't be sure select dev will be run. What do you think?


Error: pull model manifest:

What is the issue?
pulling manifest
Error: pull model manifest: Get "https://registry.ollama.ai/v2/library/llama3.1/manifests/latest": read tcp <IP_ADDRESS>:50767-><IP_ADDRESS>:443: wsarecv: An existing connection was forcibly closed by the remote host.
OS
Windows
GPU
Nvidia
CPU
Intel
Ollama version
0.3.5

Looks like a dupe of #4042


Support jsx-transform for React extensions

React 17 has support for jsx without React: https://reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html
Our ESBuilder needs to also add this support as it doesn't come for free. More info in this issue: https://github.com/evanw/esbuild/issues/334

Is this required for the initial release or just a nice to have?

I think we need to have this since the current build tool support it. I'll look into whether this is feasible. If it's not we'd need to add a disclaimer into our release notes that React is required for jsx even if you're not using any specific React methods or hooks

FYI: esbuild added support for the jsx-runtime transform recently: https://github.com/evanw/esbuild/issues/334

@vividviolet is this still something we think is important for GA?

I think so - it used to work with the old build tools so we'd just be putting back something that's missing

@vividviolet are you able to share some context you have on how we might go ahead and implement this?

Re-opening this because we only implemented this the Node CLI, not the Go CLI. The Node CLI isn't used publicly yet.
Jsx implementation in Node
Follow-up PR to add-back the React import when using Go


Is it possible to execute a LEFT join query in Arangodb's AQL?

My Environment

ArangoDB Version:        Version 0.14.15, build e32307e, Go go1.13.6
Storage Engine:           Single Server
Deployment Mode:       Arangodb as a systemd service on host network
Deployment Strategy:   AWS EC2 t2.large

Component, Query & Data
Affected feature:
AQL
AQL query (if applicable):
FOR A in employees_admins
  FOR E in employees
   FOR R in regions
    FOR C in countries
   FILTER A.emp_rgn_adm_emp_nbr == E.emp_nbr
  FILTER A.emp_rgn_adm_rgn_cd == R.region_cd
   FILTER C.ctry_cd == A.emp_rgn_adm_ctry_cd

LET X = MERGE (A,E,R,C) SORT E.emp_lst_nm DESC RETURN X

Problem:
When I use merge all joins are INNER joins, but I need some of them to be LEFT joins. I don't know how to do it with AQL.
Ex:
FOR A in employees_admins
  FOR E in employees
   FOR R in regions
    FOR C in countries
   FILTER A.emp_rgn_adm_emp_nbr == E.emp_nbr (Should be INNER JOIN)
  FILTER A.emp_rgn_adm_rgn_cd == R.region_cd (Should be LEFT JOIN)
   FILTER C.ctry_cd == A.emp_rgn_adm_ctry_cd (Should be LEFT JOIN)

LET X = MERGE (A,E,R,C) SORT E.emp_lst_nm  DESC RETURN X

I think I solved it by doing:
FOR A in employees_admins
FOR E in employees
FOR R in regions
FOR C in countries
FILTER A.emp_rgn_adm_emp_nbr == E.emp_nbr
FILTER A.emp_rgn_adm_rgn_cd == R.region_cd || C.ctry_cd == A.emp_rgn_adm_ctry_cd
LET X = MERGE (A,E,R,C) SORT X.emp_lst_nm DESC RETURN X

Definitive solution:
FOR A in employees_admins
  FOR E in employees
   FOR R in regions
    FOR C in countries
   FILTER A.emp_rgn_adm_emp_nbr == E.emp_nbr
  FILTER A.emp_rgn_adm_rgn_cd == R.region_cd || C.ctry_cd == A.emp_rgn_adm_ctry_cd

LET X = MERGE (A,E,R,C) FILTER X.ctry_cd == X.emp_ctry_cd SORT X.emp_lst_nm DESC RETURN X

Well, I actually almost go it. I got the result query I wanted except there are unnecessary registries. What I need is to set some constrain in which emp_rgn_adm_nbr can't have any duplicates. How do I do that?

Hi, did you try collect?

If entire "rows" are identical, then you may also use RETURN DISTINCT.

Hi, did you try collect?

Could you please provide an example?

If entire "rows" are identical, then you may also use RETURN DISTINCT.

I tried with RETURN DISTINCT, the problem with that aql function is that I can only use it with a single collection's value but not for various merge values where I can specified which one should be the one with no-duplicates constrains.
https://www.arangodb.com/2015/07/return-distinct-in-aql/
As @dothebart said before, COLLECT seems appropriate, but I'm unsure how to write the right syntax of it for my query requirements.

RETURN DISTINCT can be used for any single value. This can also be an object/document:
FOR doc IN coll
  FOR doc2 IN coll
    FOR doc3 IN coll
        RETURN DISTINCT doc

It returns each document once, e.g. 2 documents if there are 2 documents in coll. Without DISTINCT it would return each document 4 times, 8 in total.
You should be able to do this:
FOR A in employees_admins
  FOR E in employees
    FOR R in regions
      FOR C in countries
        FILTER A.emp_rgn_adm_emp_nbr == E.emp_nbr
        FILTER A.emp_rgn_adm_rgn_cd == R.region_cd || C.ctry_cd == A.emp_rgn_adm_ctry_cd
        LET X = MERGE (A,E,R,C) FILTER (X.emp_rgn_adm_rgn_cd == X.ctry_rgn_cd || X.ctry_rgn_cd == X.region_cd) && ((!X.emp_rgn_adm_rgn_cd && X.emp_rgn_adm_ctry_cd) || (X.emp_rgn_adm_rgn_cd && !X.emp_rgn_adm_ctry_cd))
        RETURN DISTINCT X

If there's more query after LET X that prevents a RETURN operation, then you can turn this part into a subquery, like:
LET x = ( FOR A in employees_admins ... RETURN DISTINCT X)
...
RETURN x

Assuming that each row of the intermediate result is identical, COLLECT would be pretty straightforward:
LET X = ...
COLLECT x = X
RETURN x

Hi @codewithpatelo,
Did you have a chance to check Simran-B's previous comment?


Latest release is still 2.4.0 while a releases as new as 2.5.1 is out there....

A tag or something needs to be moved?

Always use the highest version, in this case v2.5.1. This is just a github issue, it requires to specify a description for each tag, otherwise it is not going to be marked as latest.

Thanks for taking care of it. Now it shows as following and nobody can be confused what is the latest stable release. Great work by the way!!


Extension issue

Issue Type: Bug
Extension Name: doxdocgen
Extension Version: 1.3.2
OS Version: Windows_NT x64 10.0.19042
VS Code version: 1.62.3

:warning: We have written the needed data into your clipboard. Please paste! :warning:

Feel free to reopen with more information


Update configure-adfs-sso.md

@microsoft-github-policy-service agree company="Microsoft"

@dknappettmsft
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Closing this PR as we don't use tabs part way through steps. I'll request a general edit pass of this article from a separate team.
#please-close


Jsonschema suport throughout rest / registry requests

add typed schemas
add mock compatibility class

@gabriel-tincu : hi, with this PR, can Aiven support curl GET Kafka topics in JSON format via Schema Registry REST endpoint?


DCD-1550: Updated LTS version for each product.

Pull request description
This PR updated LTS version for each product.
Checklist

[ ] I have added unit tests
[x] I have applied the change to all applicable products
[x] I have added the change description to the changelog.md and Chart.yaml files
[x] (Atlassian only) Internal Bamboo CI is passing

Internal Bamboo CI: https://server-syd-bamboo.internal.atlassian.com/browse/DCD-K8SHELMTEST80

Out of curiosity, what is the main reason for this release? Is this as part of 'frequent release' practice?

Yes, and we have customers waiting for the change to be merged to main to test, hence this release.


New hlarp release for opam

New features from Leo + version constraints for Re

done https://github.com/ocaml/opam-repository/pull/7175


Norminette bad indentation in global values with multi-line initialization

Describe the bug
The bug occurs when you try to initialize a global multiline variable as a two-dimensional array with tab
Erroneous code
int  g_test[3][2] = {
  {-3, 42},
  {42, 1},
  {-42, 0}
}

Additional infos

OS:  Ubuntu 20.04 LTS
python --version: Python 3.8.10
norminette -v: <= 3.3.52

Additional context
The identation of global variables initialized in multi-dimensional arrays does not follow the identation of the entire file as expected with structs and enums

Occurs in other scopes as well:
void	main(void)
{
	static int	t[3][2] = {
		{1, 1},
		{2, 2},
		{3, 3},
	};
}

Error: INVALID_HEADER       (line:   1, col:   1):      Missing or invalid 42 header
Error: TOO_MANY_TAB         (line:   4, col:   1):      Extra tabs for indent level
Error: TOO_MANY_TAB         (line:   5, col:   1):      Extra tabs for indent level
Error: TOO_MANY_TAB         (line:   6, col:   1):      Extra tabs for indent level


only run gofumpt on .go files in pre-commit hook

Editing README.md otherwise produces a warning like this:
README.md:1:1: illegal character U+0023 '#'

@mvdan You're right. The 3 stars are supposed to do recursive matching, however...
 git diff --cached --name-only -- '*.go'

already matches recursively, whereas
 git diff --cached --name-only -- *.go

does not. By the way,
 git diff --cached --name-only -- ***.go

doesn't match recursively either, but
git diff --cached --name-only -- **/*.go

does.
Please remember this for the next time you use git to filter through files ;)

@mvdan You're right. The 3 stars are supposed to do recursive matching, however...
 git diff --cached --name-only -- '*.go'

already matches recursively, whereas
 git diff --cached --name-only -- *.go

does not. By the way,
 git diff --cached --name-only -- ***.go

doesn't match recursively either, but
git diff --cached --name-only -- **/*.go

does.
Please remember this for the next time you use git to filter through files ;)

Those are different :) I always use '*.go', since that literally just passes that string to git, meaning "any indexed file which has a go extension". Without the quoting, then the shell just tries to expand to the Go files in the current directory, which is entirely different.

Those are different :) I always use '*.go', since that literally just passes that string to git, meaning "any indexed file which has a go extension". Without the quoting, then the shell just tries to expand to the Go files in the current directory, which is entirely different.


feat(lcov): remove uncovered but skipped lines

Reporter lcovonly for .lcov files should force coverage for uncovered but skipped lines in collector map.
This will allow SonarQube or other analysis tools that use lcov files to show good coverage measurements.

Coverage increased (+0.002%) to 97.525% when pulling 6d0e071af9405ec8f6e3b91cad0a27b2aac3d4b1 on djedje72:lcovonly-fix-skipped into 89e338fcb1c8a7dea3b9e8f851aa55de2bc3abee on gotwarlost:master.

🆙


Add post about localization.

New post that'll come out on the 28th of march (though its already online for this PR).

LGTM!
Thanks @janhesters merging this PR. Just as an fyi - we finalized a hoodie design yesterday, so you'll be hearing from us soon!


[hotfix] Replace OptimizingProcess#Status with ProcessStatus.

Why are the changes needed?

Replace OptimizingProcess#Status with ProcessStatus.
Brief change log

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x]  Run test locally before making a pull request

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

thanks for your contribution, LGTM, @majin1102 @czy006 could you please take a look at this when you're free, thanks

Thanks for the contribution! @zhangwl9


Returning null from a deserializer

Today I ran into a issue because I forgot to return a value from my deserializer callable.
Is there a valid use-case to return null from a deserilizer or could we improve DX by throwing a Exception with a proper message when a deserilizer doesnt return anything aka returns `null´?
In case someone defines a deserilizer method, shouldnt it be obligatory to return a proper deserialized value?

I'm actually returning null in a number of cases in sabre/dav code, so in my case I would say: yes I think there's cases where this might be useful. In some cases I just want to be able to respresent "there was no value".
Your unittests should ideally just catch this... I have wondered if we can make the testing experience a bit better


Adding enhanced subnet support to allow for sufficient subnet support

Description
Adding enhanced subnet support to allow for sufficient subnet support
to fix error of InsufficientSubnetSize

closing this to use load balancer


Deployment of this project

This issue concerns the deployment of this portfolio project, by:

Editing the README.md file
Editing the style.css file
Editing the index.html file

You can take a look at the deployment at this address :Portfolio

Hello @Enoisong     😃 🥳 🎉 🎈
Great Job 😄 👏 You've done it. Your project is complete!  There is nothing else to say other than... it's time to merge it 👍🏻 ✅
To Highlight 💯

Descriptive issues ✔

Congratulations! 🎉

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


[Doc]Add version upgrade instructions

Add version upgrade instructions
Proposed changes
Issue Number: close #xxx
Problem Summary:
Describe the overview of changes.
Checklist(Required)

Does it affect the original behavior: (Yes/No/I Don't know)
Has unit tests been added: (Yes/No/No Need)
Has document been added or modified: (Yes/No/No Need)
Does it need to update dependencies: (Yes/No)
Are there any changes that cannot be rolled back: (Yes/No)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

The three-digit version is not the official release. Is it appropriate to mention it in the official documentation?


Open new tab when clicking on page in nav

The behavior of links in the sidebar (e.g. Favorites, Recent) doesn't match the behavior of links in the page.
When I click links in the page while clicking Cmd on the Mac, it creates a new tab as I expect. But when I do the same for links in the sidebar, it replaces the current tab. I'd expect the behavior in the nav to match the behavior in pages.

P.S. this is an awesome plugin! Thanks for writing it.

Thanks @devonzuegel, I will implement this in the next week :)

Fixed in https://github.com/pengx17/logseq-plugin-tabs/releases/tag/v1.8.5

So fast, wow!


Relations among entities about the reset Event

Hi，
After initialization, enter the page and directly click reset. The content in the list of Regions on the right will disappear, as shown in the figure. What is the reason？

@Wigithub1201 Hi, it's very old version of LS, please try the latest one (e.g. v1.5.0post0)


Make That's All more intuitive

Fixes #103.
That's All now behaves more as people expect:

If we meet rounds within two clear rows, then stop
Otherwise jump to rounds after two clear rows (e.g. killing a touch half way/half a course of Cambs)

Just running Wheatley in a single room this feels a bit less intuitive. If called in the middle of a touch Wheatley will currently start ringing rounds at the next handstroke. With this change if called at backstroke Wheatley will still ring the handstroke in the method.
I think this does improve touches that come round at hand, where That's all is called in the rounds handstroke.

Just running Wheatley in a single room this feels a bit less intuitive...

Perhaps... the main issue people were having is that if That's All only takes effect at the next handstroke, then calling it too late would cause Wheatley to ring the first non-rounds row of the method and then snap back which several people have noted as irritating.  I think I would rather support that use-case better at the expense of slightly unintuitive behaviour when calling That's All in the middle of a touch (which will hopefully be eventually superceded by the Rounds call anyway)... what do you think?

/rebase

Hmm OK so it looks like the auto rebase bot doesn't cause the PR checks to rerun...

https://www.github.com/cirrus-actions/rebase/tree/3bd4fdcde2740cb0815bca85001f4369a7a5aebb/README.md
Mentions using a personal access token to run check

Also that comment apparently triggered the rebase workflow...

Mentions using a personal access token to instead of GITHUB_TOKEN

Ooh I'll fix that at some point... got bare work to do rn.  I'll make an issue to remind me.

Also that comment apparently triggered the rebase workflow...

Ah yes it looks like the comment text is checked after the CI run starts.  Kinda annoying really cos it massively clutters the CI action history.


Bug: Dorako UI making a few popups unreadable

Not sure on the descriptor for the specific type of popup, but it's the one that appears when it asks to reload the application.
Steps to recreate:
Mac system needs to be in dark mode (Chrome browser dark or light does not affect the result, only system dark or light).
Have Dorako UI on.
Looks like this

Made using Find the Culprit kinda hard 😅

Dorako UI 3.6.1
FVTT 12.331
PF2e 6.4.1
MacOS Sonoma 14.7

Same issue here currently with the same popups and possibly a few others - I encountered it a handful of times when GMing last night, will have to play around to pinpoint exactly which windows it was.
Running on Windows with the latest versions of Dorako UI, FVTT (via Forge), PF2e, Chrome. System is in Dark Mode but I typically use Core Rulebook (Light) theme. If I switch to dark the text color is light and thus visible but I prefer the Light sheets.

Should be fixed now, can you confirm?

Winner, it works! Thank you for your service 🫡


How to get Region Code?

We want to get region code after users type phone number manually.

I can't think of a great way to expose that as an API in the library. Let's say we create a new method called regionCode(), what should it return if:

The input field is empty
The input field doesn't have a valid country code (e.g. "+422222")
The input field only has the beginning of a valid country code (e.g. ("+5")

Is returning null good enough for all those different cases? It's hard to know how this API would end up being used in the end by different clients. So if you need the code my suggestion is to implement it yourself on your end and then decide how you should handle these particular cases based on your specific needs.
You can build it assuming there's always a space after the code, so something like this should work:
text.substringBefore(" ")

If you want to make sure you only get the code if it's valid, then you can check if there's a space in the string before running that.
if (text.contains(" ")) text.substringBefore(" ") else null

Note that the space is only added once an additional number is inputted after the code, so if the input is just "+1", there won't be a space in the text yet even though "1" is a valid code.

Thanks for you feedback. I wrote this code for my purpose.
`public static PhoneNumber parsePhoneNumber(final Context context, final String phoneNumber) {
if (TextUtils.isEmpty(phoneNumber)) return null;
try {
String pureNumber = purePhoneNumber(phoneNumber);
if (phoneNumber.startsWith("+")) pureNumber = "+".concat(pureNumber);
        PhoneNumberUtil phoneNumberUtil = PhoneNumberUtil.createInstance(context);
        Phonenumber.PhoneNumber number = phoneNumberUtil.parse(phoneNumber, null);
        int countryCode = number.getCountryCode();
        String regionCode = phoneNumberUtil.getRegionCodeForCountryCode(countryCode);
        PhoneNumber result = new PhoneNumber();
        result.fullNumber = pureNumber;
        result.countryCode = countryCode;
        result.regionCode = regionCode;
        String prefix;
        if (phoneNumber.startsWith("+")) {
            prefix = "+" + countryCode;
        } else {
            prefix = "" + countryCode;
        }

        result.numberPart = pureNumber.substring(prefix.length());

        return result;
    } catch (Exception ex) {
        ex.printStackTrace();
    }

    return null;
}

public static String purePhoneNumber(String str) {
    StringBuilder result = new StringBuilder();
    int len = str.length();
    for (int idx = 0; idx < len; idx++) {
        char c = str.charAt(idx);
        if (c >= '0' && c <= '9') {
            result.append(c);
        }
    }

    return result.toString();
}

class PhoneNumber {
public String fullNumber;
public int countryCode = 0;
public String regionCode = "";
public String numberPart;
}
`


Replaced TravisCI badge with Github Actions badges

Coverage remained the same at 91.632% when pulling 282b9082cf567074ed68661e35afab563c20b7b3 on m6121:master into 2083b2ceef042abd7fda5ea7af26666930fdb5be on rdmorganiser:master.


[BUG] TS7016: Could not find a declaration file for module './dist/es5'.

🐛 Bug Report
Angular 13.x
During ng build there is an error:
TS7016: Could not find a declaration file for module './dist/es5'. 'node_modules/exceljs/dist/es5/index.js' implicitly has an 'any' type.

Lib version: 4.4.0
typescript: 4.5.5
The expected behaviour:
No error during building Angular app

I have the same problem


FilePicker: How to allow picking URLs of site pages?

Category
[ ] Enhancement
[ ] Bug
[x] Question
Version
Please specify what version of the library you are using: v1.19.0
Question 1
Is it possible to configure FilePicker component to display ASPX page files also? At least on the "Site" tab where I can pick a page from the SharePoint site. There is a task to provide users with ability to reference a page by its URL.
Question 2
As I can see from the code, there is an argument includePageLibraries in the getSiteMediaLibraries(). However, all the calls of this method are parameterless. Is it planned to propagate this argument to FilePicker props?

Same issue here, we'd like to be able to browse the files in the SitePages tab using the FilePicker component, just like the picker in the Quick Links webpart. At the moment (version 2.1.0) it is only possible to browse Documents and Site Assets.
Picker in Quick Links webpart

Picker in FilePicker component (Hid everything except Site)

Any updates on this issue?

Hi @msgx - thank you for reporting this one!
The enhancement PR has been merged and will be included in the next release.
In a meanwhile you can test the functionality in beta version.

Hi @msgx - thank you for reporting this one!
The enhancement PR has been merged and will be included in the next release.
In a meanwhile you can test the functionality in beta version.

v2.5.0 has been released.


x/crypto/ssh: add package for Key Revocation Lists

What version of Go are you using (go version)?
go version go1.9.2 darwin/amd64

What did you expect to see?
x/crypto/ssh has support for SSH Certificates and an ssh.CertChecker.IsRevoked() method, but there seems to not be support for OpenSSH's Key Revocation List (KRL) format. It would be useful to be able to marshal/unmarshal revocation lists for use by an OpenSSH server in Go.

@hanwen?

sounds like a useful feature. I think it could be separate subpackage of SSH.

After digging around I found stripe/krl which supports what I need. It might still be useful to have that functionality as a package under x/crypto/ssh, but its up to you all to keep this open or not.

This wasn't implemented for 2 years, and there's a third-party package that seems to meet the need, so reverting the Proposal-Accepted and bouncing it back to the committee. I think the lack of activity suggests we can do without it.

Based on the discussion above and two years of inactivity after the initial acceptance, it sounds like this is a likely decline and that people who need KRLs can use https://github.com/stripe/krl. This does not seem like enough people need it to adopt it.
Leaving open for a week for final comments.

No change in consensus, so declined.


improve logic when we import tests with ids fixes #762

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.

Rebased, and merged.
Thanks for your contribution !


Added support for PlantUML diagrams.

Added first attempt at support for PlantUML diagrams.
See #39 for more details.

Coverage increased (+0.02%) to 81.646% when pulling 8a230ec46b0c519d49144dcfb9bf2076fa831677 on gushakov:master into b76ada13c4d2b05037fa747251f63118e9cce3dc on ferstl:master.

Thank you!


Enhancement: DuckDB native schema inference

Remove italics helper text upon creation.
REMEMBER, BE SMART!
S: Specific
M: Measurable
A: Achievable
R: Relevant
T: Time-Bound
Goal-State/What/Result
A clear and concise description of what the enhancement is and the target goal-state.
Why/Purpose
Clear and concise answer to why this should be done now.
By When
A target date for done-done completion of the entire enhancement.
Issue/Spec written and reviewed:
Done-Done:
Done-Done

[ ] Principles Driven
[ ] The Algorithm
[ ] PM/Design Review
[ ] DX/UX Review
[ ] Threat Model / Security Review
[ ] Tests
[ ] Performance / Benchmarks
[ ] Documentation
[ ] Samples/Quickstarts/Tutorials
[ ] Release Notes

The Algorithm

[ ] Every requirement questioned?
[ ] Delete (Scope) any part you can.
[ ] Simplify.
[ ] Break down into smaller iterations/milestones.
[ ] Opportunities for automation.

Specification
Provide a basic specification of the enhancement.
Security Review
Provide threat model and security review.
How/Plan
A clear and concise plan of how this should be implemented.
Implementation (Sub-Issues)

[ ] Sub-Issue 1
[ ] Sub-Issue 2

QA

[ ] Sub-Issue 1
[ ] Sub-Issue 2

https://github.com/spiceai/spiceai/issues/2461


ValueError: shape mismatch in assignment.

Just tried to run the example code given on github readme.
import markov_clustering as mc
import networkx as nx
import random

# number of nodes to use
numnodes = 200

# generate random positions as a dictionary where the key is the node id and the value
# is a tuple containing 2D coordinates
positions = {i:(random.random() * 2 - 1, random.random() * 2 - 1) for i in range(numnodes)}

# use networkx to generate the graph
network = nx.random_geometric_graph(numnodes, 0.3, pos=positions)

# then get the adjacency matrix (in sparse form)
matrix = nx.to_scipy_sparse_matrix(network)
result = mc.run_mcl(matrix)

Gives the following error:
Traceback (most recent call last):
  File "/home/baqir/code/email-sentiment-analysis/algorithms/markov_clustering_visual.py", line 22, in <module>
    result = mc.run_mcl(matrix)
  File "/home/baqir/code/email-sentiment-analysis/env/lib/python3.6/site-packages/markov_clustering/mcl.py", line 233, in run_mcl
    matrix = prune(matrix, pruning_threshold)
  File "/home/baqir/code/email-sentiment-analysis/env/lib/python3.6/site-packages/markov_clustering/mcl.py", line 93, in prune
    pruned[matrix >= threshold] = matrix[matrix >= threshold]
  File "/home/baqir/code/email-sentiment-analysis/env/lib/python3.6/site-packages/scipy/sparse/_index.py", line 109, in __setitem__
    raise ValueError("shape mismatch in assignment")
ValueError: shape mismatch in assignment

Do not understand if this is a scipy error or markov-clusterting error in passing valid arguments.

Getting the same error here...
From inspecting the codes, it seems to be an error related to scipy... somehow, at the time of prunning, both the matrices involved (matrix and pruned) get correctly classified as scipy sparse matrices (isspmatrix returns true), but once you get to the assignment line and inside scipy, I guess the matrix on the right side (called x in the setitem method) returns false when asking if its a sparse matrix.
From there on, as it gets treated as a numpy array, the mismatch happens.
That is what I understand at least.
I guess I only started having this error after updating scipy to version 1.3 (1.2 was the version available at the time of markov-clustering latest release), so downgrading to 1.2 seems to have made the trick for me (conda install scipy=1.2).
I havent tried it much yet.. but a couple of runs and I dont have the error prompting up...
Hope it helps.

I am still having the same issue, despite downgrading scipy to 1.2.0.  Are there other dependencies that may be needed?  I ran the example code pasted by @baqir00, and got this error:
  File "<input>", line 1, in <module>
  File "/home/jlg374/.local/lib/python3.7/site-packages/markov_clustering/mcl.py", line 233, in run_mcl
    matrix = prune(matrix, pruning_threshold)
  File "/home/jlg374/.local/lib/python3.7/site-packages/markov_clustering/mcl.py", line 93, in prune
    pruned[matrix >= threshold] = matrix[matrix >= threshold]
  File "/home/jlg374/.local/lib/python3.7/site-packages/scipy/sparse/_index.py", line 124, in __setitem__
    raise ValueError("shape mismatch in assignment")
ValueError: shape mismatch in assignment

Creating a parallel dok matrix fixes the issue, but makes the algorithm slower:
`def prune(matrix, threshold):
"""
Prune the matrix so that very small edges are removed.
The maximum value in each column is never pruned.
:param matrix: The matrix to be pruned
:param threshold: The value below which edges will be removed
:returns: The pruned matrix
"""
dok_m = matrix.todok(copy=False)  # INTRODUCED BY ME TO FIX BUG WITH SCIPY>=0.13 -- DOK ALLOWS ASSIGNMENT
if isspmatrix(matrix):
    pruned = dok_matrix(matrix.shape)
    pruned[matrix >= threshold] = dok_m[dok_m >= threshold]  # DOK ALLOWS ASSIGNMENT
    pruned = pruned.tocsc()
else:
    pruned = matrix.copy()
    pruned[pruned < threshold] = 0

# keep max value in each column. same behaviour for dense/sparse
num_cols = matrix.shape[1]
row_indices = matrix.argmax(axis=0).reshape((num_cols,))  # NEED CSC OR CSR FOR ARGMAX
col_indices = np.arange(num_cols)
pruned[row_indices, col_indices] = dok_m[row_indices, col_indices]  # DOK ALLOWS ASSIGNMENT

return pruned`

Unfortunately argmax() isn't implemented for dok matrices, so both copies need to be kept.

For anyone still having trouble with this issue: upgrading scipy up from 1.3.x seems to have fixed it for me. It's working on 1.4.1 and 1.5.1 where it would previously fail.


Skip line in Tlint

I have some code that I can't reformat, is there a way to skip a line from being linted?
Similar to // @phpstan-ignore-next-line
Thanks!

Hi, @Jonyorker; there isn't a way to skip only part of a file in TLint.
You'll have to exclude the whole file using a tlint.json file.


how to use this?

Hi,
It allows you to specify what column to show and order by on the select menus for example Countries::getListForSelect('citizenship') will create an array populated with the values of the citizenship column and the country id as it's key.

?


Added IEquatable to Attachment

Other types on Activity already implement this interface.

@EricDahlvang,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


German Special Chars

Describe the bug

Using i18n-ally to edit my laravel website / app in visual studio code
All works more then fine and i am happy with the tool
but when using blade and some calls like {{ __(D&T) }} it wont recog those values as it does with the others
this also happens with all the other special chars like umlauts from german like {{ __(Son scheiß haha) }} .
Did i miss somethig ?
encoding is set to utf-8 (home.balde.php)
Device Infomation

OS: Ubuntu
Version: LTS
VS Code Version: Current

We don't expect to see special chars in i18n keys and we believe it's a better pactice. If you somehow really what to use use them, you can try with this config:
https://github.com/antfu/i18n-ally/wiki/Configurations#advanced-configurations
"i18n-ally.regex.key": ".*?"

We don't expect to see special chars in i18n keys and we believe it's a better pactice. If you somehow really what to use use them, you can try with this config:
https://github.com/antfu/i18n-ally/wiki/Configurations#advanced-configurations
"i18n-ally.regex.key": ".*?"


More robust fallback behaviour on Windows

#15

Merged, thanks!

You're welcome. And wow. You're fast.


how would i make songs in the hotfix?

I made a version with just the page i dont really  know how to add shit there

In order to add songs you must add them to WeekData.hx (source code) I don't think that the free play song list is working.
Once you added your song to WeekData.hx and added the required files (charts "songName.json" and music "Inst.mp3" / "Voices.mp3") wait until the project is recompiled (workflow) and move it into the page

Yo so it wont recompile it fails

it gets to script run lime haha and then fails

Maybe I can help you through some social media or something

Sure heres my email<EMAIL_ADDRESS>

i could send you a screen shot of my error

?

sure

oh and one more thing


On iOS, the user list does not seem to be scrollable

When running 2.4.0 and the master build as of this writing, the users list does not seem to be scrollable on iOS for me. It tries to scroll the entire page. The channel list works fine. This is not an issue on Safari for Mac and only affects iOS, so I'm not sure what's going on here and my initial troubleshooting did not turn up an answer. I know it affects at least iOS 10 and 11, and I think it used to work with an older version of The Lounge, but I have not yet had time to check that.

Hmm, #1520 might have affected this?
(This is the issue I meant to comment on when I did on 1547… I should stop trying to GitHub on my phone. 😂)

I don’t think so, as that was only committed a week ago, and this issue existed at least in 2.4.0.

Can you test if removing this line helps?
https://github.com/thelounge/lounge/blob/8f275c6a5554d7b7fe921174313bb9fc67148702/client/css/style.css#L1289

That was the first thing I tried and it didn't work. I just tried removing all instances of it from the css file, and THAT worked. I'll have to see if there's a way to keep it and not have it break things when I have a bit more time later today.

I've been testing various things for a few hours and haven't come up with anything that works while keeping any instance of that in the css file, and most of the solutions I was finding online for this are pretty hacky. All instances have to be removed for it to work at all, which of course means you lose momentum scrolling on mobile WebKit.

Can you try adding $('.names').on('touchstart', function(event){}); to client/lounge.js?

Unfortunately doesn't seem to have any effect.

When I tested yesterday, it wasn’t working and now it is. I think I know what changed, but won’t be able to test until later today. I’ll follow up then.

 It just starts working the second time you click a channel (i.e. a channel has to be selected first, switched to another one, and then come back). I don't know enough about what events get triggered when you do that to understand what's happening there.

@Gilles123 Is it related to #1556?

Nope, it's unrelated. That's just a thing I noticed/was annoyed by while testing this, but it's a separate issue. What I know right now is that most recent comment.

Seems to be fixed for me on master

Never mind - wasn’t the first channel i opened


Register Oceananigans v0.9.2

@JuliaRegistrator register()
Bug fix in PR #337 is important for GPU usability so releasing a new patch.

Error while trying to register: Version 0.9.1 already exists

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/2551
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if Julia TagBot is installed, or can be done manually through the github interface, or via:
git tag -a v0.9.2 -m "<description of version>" c95160f03da7b28b0e850e69acdba7e8a809f9d0
git push origin v0.9.2

This was an accidental release. Will release v0.9.3 when PR #343 is merged.


Fix widow pad frames

Fixes #4234.
It turns out the empty frames created by pad have a non-zero size (they had padding applied to them). This made #2517 not work with those frames.
This PR solves the issue by applying the following transformation: each of the empty frames generated by pad that come before any content become zero-sized.[^1] In case of a pad element that generates only empty frames, the last one is always kept in order to make sure the element never "disappears".
[^1]: It is actually a tiny bit more complicated than that, due to some frames having negative dimensions (see this Discord message).

Turns out this is harder than I thought. I'm marking this as a draft for now.

Actually, I just forgot to add a test ref! So this PR is now ready for review.

Is there an associated issue for this?
The whole approach of skipping zero-sized frames in the flow is a bit of hack in my opinion. Adding to this with more complexity in padding seems like a potential maintainance burden to me. It is already very hard to change this in the flow already due to the various ad-hoc bug fixes in it.

Is there an associated issue for this?

There is not. I can create one.
Another idea I had after making this PR, which may feel less hacky, was to allow fragments to contain "fillers" instead of frames, which act as zero-sized frames, and are used instead of an empty frame that would have been created to fill a region when nothing fits into it. I don't know how this related this would be to #4212 (if at all).

I created #4234.

Let's wait with this until after the layout refactor (if I don't fix it myself during it). Every extra somewhat ad-hoc fix makes incremental refactoring harder.

Ok. I'm closing this PR, then.


Verify contract offer request flow (message dispatchers and handlers)

Depends on PR #285

@jimmarino can you please adde some more details what needs to be done - just to make sure we are on the same page. Thanks!

I tested the data transfer on the main branch (including requesting the data offers first) and its working fine. Also there is now an update for the simple 5 documentation in PR #321.
Dominik Pinsel<EMAIL_ADDRESS>Daimler TSS GmbH, legal info/Impressum

@DominikPinsel can this one be closed, since we merged the PR already?

@mspiekermann Yea. Sorry I forgot about this and will close it myself.


Add CPAK and CVR form factor

Issue type : Feature request
Environment

Python version:  2.7.9
NetBox version: 2.1.5

Description
Add new form factors for interfaces
Cisco CPAK and CVR are proprietary form factor for 100G optics.
https://www.cisco.com/c/en/us/products/collateral/interfaces-modules/transceiver-modules/data_sheet_c78-728110.html
We use it for Cisco N77 and ASR module, and sometimes running CVR (CFP2 to CPAK adapter).
We propose this patch for the community ;)
PR to come

PR : https://github.com/digitalocean/netbox/pull/1552/files

According to the data sheet, the CVR is an adapter for the CPAK form factor, and not a form factor itself. I'll add CPAK as a 100GE form factor.

Also adding the CFP2 and CFP4 100GE form factors.

So should I suggest another patch or you manage it ?
Thanks !

Thanks !


[Forms] MapView: stacklayout  holding buttons not transparent to input when all buttons are hidden.

I would like to use the Mapsui.UI.Forms.MapView class  because I use the "Pins" feature this class provides but with all buttons hidden.
The problem is the stacklayout that hold the buttons remains "visible". It is transparent(I cannot really "see" it) but I cannot drag the map through it.
https://github.com/Mapsui/Mapsui/blob/a01d10d482ed499a10e4e4a7e3e78c1ebd34e77d/Mapsui.UI.Forms/MapView.cs#L135
The problem appeared on an android physical device (the one I am currently testing my application on: Samsung J3 "SM-J330FN" Android 9). I did not test it on any other device.
Suggestion: maybe we could toggle the visibility of this stacklayout dynamically in a similar way it is done for the buttons separators but only when all button are hiddens:
https://github.com/Mapsui/Mapsui/blob/a01d10d482ed499a10e4e4a7e3e78c1ebd34e77d/Mapsui.UI.Forms/MapView.cs#L658
EDIT:
We can easily see where this StackLayout is on Android with the developer options that allow you to see layout bounds "show layout bounds".

Should be fixed in 2.0.0-beta.33.


Add MANIFEST.in

Can we add a manifest file here?  https://packaging.python.org/guides/using-manifest-in/

The project doesn't contain much package data, just a py.typed file, which is added here:
https://github.com/piccolo-orm/targ/blob/8660cbc42b2758e58ae3771a2d398cf5fbddfe37/setup.py#L36
Are there any other reasons for a MANIFEST.in file?

I'm in the process of adding this to conda-forge.org/; and a MANIFEST.in file helps greatly with building the binaries (e.g. adding in the requirement.txt file)
I can patch it myself downstream but it's better to add it upstream here. No worries if it's too much hassle

@thewchan I can add it - no problem. I was just wondering the reason for it.

Thanks so much, I appreciate it!

I believe so, if I run into problems again I'll come back for help. Thanks so much 👍


Change LED‘s for SanmuLink CC2538 Board

Hello, can you please make one Hex File with USB Support and change LED‘s from -> to
PB1 -> PC7
PB2 -> PC6
PB3 -> PC5
PB4 -> PC4
for the Sanmulink SM14Z2538 6LoWPAN Dev Board
https://a.aliexpress.com/_BfhHNOaB
Many Thanks for your good work.

Hi!
Please, try this build:
https://www.dropbox.com/s/8w7495nzca5hu71/ZNP.hex?dl=1
If everything works fine I'll add new LED layout to repository.

Thank you for your fast processing. The Board is still already on the way since 28 Days. As soon as it has arrived I will test it directly. I did not expect such a quick processing. ;-)

@reverieline
Hi!
The shipping from china took a little longer.
I Flash the SanmuLink CC2538SF53 Board with your dropbox ZNP.hex File.
First, Many Thanks for you gear work!
Result:
Works in Zigbee2Mqtt = Firmware version is zStack30x
LED´s
Connenct the Board to USB or after Push Reset Button
LED glow for 1sec
PC6, PC5, PC4
LED
PC7 = always off
PC6 = green (see it only 1 sec after add USB Cable
PC5 = Blink Orange if start - join new Device from Zigbee2Mqtt
PC4 = Blink Red after a device Send a State
Buttons on Board

Push K1 Button connected to PC00 = Log Output in Zigbee2Mqtt

zigbee2mqtt:error 2020-06-05 13:18:17: Adapter disconnected, stopping
zigbee2mqtt:info  2020-06-05 13:18:17: MQTT publish: topic 'zigbee2mqtt/bridge/state', payload 'offline'
zigbee2mqtt:info  2020-06-05 13:18:17: Disconnecting from MQTT server
zigbee2mqtt:error 2020-06-05 13:18:17: Failed to stop zigbee
npm
ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: node index.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Push K2 Button connected to PC1 = nothing happens

Push Reset Button = Device Reboot

Would it be an idea, sensible and possible to use the K2 button for Join new device?
or generally use the K1 (PC00) and K2 (PC1) buttons for something?
Can you tell me what exactly the 4 LEDS indicate? especially PC7 and PC6

Hello @reverieline ! I have a problem with the firmware you shared (dropbox link), the linkquality is very low (0-55) with the internal antenna. Do you have an idea ? :) thanks

Hello Everyone with a Sanmulink Board
SM14Z2538PA1V1.0-20181030
or
SM14Z2538PA1V2.0-20200510
The manufacturer has a bug on the board. With using USB he switched two 5V to 3.3V step-down voltage regulators one behind the other. TPS76933 -> AMS1117 3.3
The result with using USB Port = On 5V Side is only 3.3V and at 3.3V Side only 2.1V.
To low for the Blue LED D1 and the CC2538 Module e.g. bad link quality
So that the 5V and 3.3V on the Board can be used correct via USB and the CC2538 gets its 3.3V operating voltage,
the following must be changed. See pictures

Unfortunately, on this board the diode pins are designed differently, please help and explain how to compile each new batch "JH_2538_2592_ZNP_UART_20201010.patch" to match it to this board.

SM14Z2538PA1V3.0-20201017
V3.0
PB1 change to PC5 (LED1)
PB2 change to PC4 (LED2)
PB3 change to PC1 (LED3)
PB4 change to PC0 (LED4)
Push Button K1 on PC7
Push Button K2 on PC6
————————————
The problem is I don't know how to compile step by step. What programs do I need, what settings, what to click.


doc minor fixes

refactor doc: use "not in" operator
fix doc typo: renamed test_{div,index_of}

Thank you!

Thanks you! Now it's good :)

This project is awesome 🤟 I am enjoying reading the documentation