Load Balancer Resource Leak

Even with the delete.sh there's still a resource leak.  There is a load balancer quota of 15, so it could present a problem if numerous clusters are deployed and deleted.
These resources are leaked:
gcloud compute forwarding-rules
gcloud compute target-pools
gcloud compute firewall-rules

Found this issue with the command:
kubectl get events

Graphical delete is here, though I'm not sure you can get all the resources that way. https://console.developers.google.com/networking/loadbalancing/list


TextButton not working inside AppBar actions[ ]

Steps to Reproduce

Run flutter create bug.
Update the lib/main.dart as follows

import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  const MyHomePage({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text("Test App"),
        actions: [
          TextButton(
            onPressed: () {},
            child: const Text(
              "Button 1",
            ),
          ),
          TextButton(
            onPressed: () {},
            child: const Text(
              "Button 2",
            ),
          )
        ],
      ),
    );
  }
}

Expected results:
TextButton should be visible in AppBar
Actual results:
TextButton is not visible. But if we replace TextButton with ElevatedButton then it will work fine. I think TextButton should also give the same behaviour as ElevatedButton meaning TextButton should also be visible.

Logs

 flutter run --verbose -d chrome
[  +96 ms] executing: uname -m
[  +43 ms] Exit code 0 from: uname -m
[        ] x86_64
[   +8 ms] executing: [/home/ayaan/workspace/repos/flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[   +5 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] 0d1358d7ee4c08d8e99a9f1b0cf6d2031a2e1fcb
[        ] executing: [/home/ayaan/workspace/repos/flutter/] git tag --points-at 0d1358d7ee4c08d8e99a9f1b0cf6d2031a2e1fcb
[  +15 ms] Exit code 0 from: git tag --points-at 0d1358d7ee4c08d8e99a9f1b0cf6d2031a2e1fcb
[   +1 ms] executing: [/home/ayaan/workspace/repos/flutter/] git describe --match *.*.* --long --tags 0d1358d7ee4c08d8e99a9f1b0cf6d2031a2e1fcb
[  +43 ms] Exit code 0 from: git describe --match *.*.* --long --tags 0d1358d7ee4c08d8e99a9f1b0cf6d2031a2e1fcb
[        ] 2.3.0-16.0.pre-278-g0d1358d7ee
[   +7 ms] executing: [/home/ayaan/workspace/repos/flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[   +5 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] origin/master
[        ] executing: [/home/ayaan/workspace/repos/flutter/] git ls-remote --get-url origin
[   +4 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/ayaankhan98/flutter
[  +99 ms] Unable to locate an Android SDK.
[   +4 ms] executing: [/home/ayaan/workspace/repos/flutter/] git rev-parse --abbrev-ref HEAD
[   +5 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] master
[  +75 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +3 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'WindowsUwpEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +92 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[   +2 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'WindowsUwpEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +92 ms] Skipping pub get: version match.
[ +151 ms] Generating /home/ayaan/workspace/testapp/android/app/src/main/java/io/flutter/plugins/GeneratedPluginRegistrant.java
[ +524 ms] Launching lib/main.dart on Chrome in debug mode...
[ +140 ms] Updating assets
[ +102 ms] Waiting for connection from debug service on Chrome...
[  +82 ms] <- reset
[  +10 ms] /home/ayaan/workspace/repos/flutter/bin/cache/dart-sdk/bin/dart --disable-dart-dev
/home/ayaan/workspace/repos/flutter/bin/cache/artifacts/engine/linux-x64/frontend_server.dart.snapshot --sdk-root
/home/ayaan/workspace/repos/flutter/bin/cache/flutter_web_sdk/ --incremental --target=dartdevc --debugger-module-names --experimental-emit-debug-metadata
-DFLUTTER_WEB_AUTO_DETECT=true --output-dill /tmp/flutter_tools.AWAJDR/flutter_tool.WLMDTU/app.dill --libraries-spec
file:///home/ayaan/workspace/repos/flutter/bin/cache/flutter_web_sdk/libraries.json --packages /home/ayaan/workspace/testapp/.dart_tool/package_config.json
-Ddart.vm.profile=false -Ddart.vm.product=false --enable-asserts --track-widget-creation --filesystem-root /tmp/flutter_tools.AWAJDR/flutter_tools.DLXQDR
--filesystem-scheme org-dartlang-app --initialize-from-dill build/b1b715402d823b7fd5c2b68d2edcb2ce.cache.dill.track.dill --platform
file:///home/ayaan/workspace/repos/flutter/bin/cache/flutter_web_sdk/kernel/flutter_ddc_sdk_sound.dill --sound-null-safety
[  +16 ms] <- compile org-dartlang-app:/web_entrypoint.dart
[+23608 ms] Waiting for connection from debug service on Chrome... (completed in 23.7s)
[        ] Synced 28.6MB.
[        ] <- accept
[        ] Caching compiled dill
[ +391 ms] Using Google Chrome 91.0.4472.77 unknown

[ +100 ms] executing: uname -m
[  +14 ms] Exit code 0 from: uname -m
[        ] x86_64
[ +431 ms] [CHROME]:Gtk-Message: 22:39:08.532: Failed to load module "appmenu-gtk-module"
[ +145 ms] [CHROME]:
[        ] [CHROME]:DevTools listening on ws://<IP_ADDRESS>:33447/devtools/browser/3ca3f787-eda3-4e88-a5ca-1b84d36aeb55
[ +572 ms] DwdsInjector: Received request for entrypoint at http://localhost:42399/main_module.bootstrap.js
[   +9 ms] MetadataProvider: Loading debug metadata...
[  +27 ms] MetadataProvider: Loaded debug metadata (sound null safety)
[  +14 ms] DwdsInjector: Injected debugging metadata for entrypoint at http://localhost:42399/main_module.bootstrap.js
[+2287 ms] ChromeProxyService: Initializing expression compiler for main_module.bootstrap.js with sound null safety: true
[  +99 ms] DevHandler: Debug service listening on ws://<IP_ADDRESS>:41415/By2zPxj_N-c=/ws

[  +33 ms] This app is linked to the debug service: ws://<IP_ADDRESS>:41415/By2zPxj_N-c=/ws
[  +11 ms] Debug service listening on ws://<IP_ADDRESS>:41415/By2zPxj_N-c=/ws
[        ] 💪 Running with sound null safety 💪
[   +5 ms] 🔥  To hot restart changes while running, press "r" or "R".
[        ] For a more detailed help message, press "h". To quit, press "q".
[   +1 ms] An Observatory debugger and profiler on Chrome is available at: http://<IP_ADDRESS>:41415/By2zPxj_N-c=
[+2891 ms] DevTools activation throttled until 2021-06-16 04:08:36.603489.
[+101179 ms] The Flutter DevTools debugger and profiler on Chrome is available at: http://<IP_ADDRESS>:9102?uri=http%3A%2F%2F<IP_ADDRESS>%3A41415%2FBy2zPxj_N-c%3D
[+52979 ms] DevHandler: Stopped debug service on ws://<IP_ADDRESS>:37035

[ +179 ms] Application finished.
[  +11 ms] "flutter run" took 1,86,251ms.
[ +264 ms] ensureAnalyticsSent: 252ms
[   +1 ms] Running shutdown hooks
[        ] Shutdown hooks complete
[        ] exiting with code 0

flutter analyze
Analyzing testapp...
No issues found! (ran in 3.2s)

 flutter doctor -v
[✓] Flutter (Channel master, 2.3.0-17.0.pre.278, on Manjaro Linux 5.4.123-1-MANJARO, locale en_IN)
    • Flutter version 2.3.0-17.0.pre.278 at /home/ayaan/workspace/repos/flutter
    • Upstream repository https://github.com/ayaankhan98/flutter
    • Framework revision 0d1358d7ee (6 days ago), 2021-06-09 01:59:04 -0700
    • Engine revision 299c801978
    • Dart version 2.14.0 (build 2.14.0-190.0.dev)

[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/linux#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[✓] Chrome - develop for the web
    • CHROME_EXECUTABLE = /opt/google/chrome/chrome

[✓] Linux toolchain - develop for Linux desktop
    • clang version 11.1.0
    • cmake version 3.20.3
    • ninja version 1.10.2
    • pkg-config version 1.7.3

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/linux#android-setup for detailed instructions).

[✓] VS Code
    • VS Code at /snap/code/current
    • Flutter extension version 3.23.0

[✓] Connected device (2 available)
    • Linux (desktop) • linux  • linux-x64      • Manjaro Linux 5.4.123-1-MANJARO
    • Chrome (web)    • chrome • web-javascript • Google Chrome 91.0.4472.77 unknown

! Doctor found issues in 2 categories.

Edit the style property and make the text font color to white

Edit the style property and make the text font color to white

It's visible. I thought default color is white that's why i didn't thought about changing text color

Edit the style property and make the text font color to white

It's visible. I thought default color is white that's why i didn't thought about changing text color

Solved then??

Edit the style property and make the text font color to white

It's visible. I thought default color is white that's why i didn't thought about changing text color

Solved then??

yes button is visible. But shouldn't the default text color supposed to be white?

That is because of the primary swatch defined in Theme Data, where there is a map of colors by default for the entire app. Also, I guess the text button copies the same ThemeData and hence the primary swatch.

That is because of the primary swatch defined in Theme Data, where there is a map of colors by default for the entire app. Also, I guess the text button copies the same ThemeData and hence the primary swatch.

I see, Basically what is happening is if primarySwatch is green then TextButton text color becomes green, if primarySwatch is blue then TextButton text color becomes blue or anything thing else, In all these cases TextButton will not be visible unless we explicitly set color for TextButton to make it visible.
But the case with Elevated button is not same, It's not required to set style property of Elevated button to make it visible. It automatically takes different color as compared to background of AppBar to make itself visible.
I think TextButton should also exhibit the same behaviour isn't?

Also in theme_data.dart it's mentioned
207 |   /// The [textTheme] [TextStyle] colors are black if the color scheme's
208 |  /// brightness is [Brightness.light], and white for [Brightness.dark].

textTheme and TextStyle should be by default such that it is visible with any primarySwatch color. This is not working as expected in case of TextButton. Isn't?

Check out the TextButton properties, the textstyle references the foreground color. I am not sure if that is the case, but you can check this
textStyle: resolvedTextStyle?.copyWith(color: resolvedForegroundColor),

@ayaankhan98
You may override the primarySwatch property using colorScheme property, as below:
theme: ThemeData(
        primarySwatch: Colors.blue,
        colorScheme: ColorScheme.fromSwatch(
          primarySwatch: Colors.green
        ).copyWith()
      ),

which shows the TextButtons in green color and are visible in appbar, as below:

You may override the primarySwatch property using colorScheme property, as below:

Yes we can override, But my point is by default it should be such that it is visible by itslef.

flutter doctor -v
/Users/dhs/Documents/Fluttersdk/flutter/bin/flutter doctor --verbose
[✓] Flutter (Channel stable, 2.2.2, on Mac OS X 10.15.4 19E2269 darwin-x64, locale en-GB)
    • Flutter version 2.2.2 at /Users/dhs/Documents/Fluttersdk/flutter
    • Framework revision d79295af24 (6 days ago), 2021-06-11 08:56:01 -0700
    • Engine revision 91c9fc8fe0
    • Dart version 2.13.3

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.56.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 91.0.4472.106

• No issues found!

@ayaankhan98 - you're right, it really shouldn't be necessary to do anything in this case.  The problem is that the AppBar's background defaults to the color scheme's primary color, as do the text buttons' text color.
The sample below shows how to workaround the issue.
We could mitigate the problem by wrapping the actions in a TextButtonTheme with a style like the one below.  That doesn't cover all cases, since one can specify the AppBar's background color - https://github.com/flutter/flutter/pull/71184 - and the color might not contrast very well with ColorScheme.onPrimary. However the approach shown below could be used in that case.
class MyHomePage extends StatelessWidget {
  const MyHomePage({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    final ButtonStyle style = TextButton.styleFrom(
      primary: Theme.of(context).colorScheme.onPrimary
    );
    return Scaffold(
      appBar: AppBar(
        title: const Text("Test App"),
        actions: [
          TextButton(
            style: style,
            onPressed: () {},
            child: const Text(
              "Button 1",
            ),
          ),
          TextButton(
            style: style,
            onPressed: () {},
            child: const Text(
              "Button 2",
            ),
          )
        ],
      ),
    );
  }
}

Unfortunately the "fix", #85585, had to be reverted because the many application tests failed because we were overriding the default foreground color for TextButtons. It's not really practical to try and detect the situation where the contrast between the default text button theme's foreground color and the AppBar's background color is so low that we should override the text button theme's foreground color. It's possible but not practical because it would introduce a complex dependency that would difficult to document and likely to confuse when it wasn't expected. For example, an app that tried to animate the foreground color of TextButton AppBar actions might be surprised when - mid animation - the expected color was automatically changed.
So, instead we'll "fix" this problem by documenting the remedy noted in https://github.com/flutter/flutter/issues/84642#issuecomment-863573868


Make datbase objects AutoClosable

Situation
In cases where you create transient database objects in test cases, you want to make sure that the are dropped after the test case.
The cleanest way to get rid of test-case-specific objects would be to initialize them in a try-with-resources and let Java clean them up. This also works if the test fails.
Acceptance Criteria

Database objects that support drop() also implement AutoClosable

After prototyping this idea, it turns out, it has the side effect of requiring users to use close() in cases where they don't use try-with-resources. This would make it necessary to wrap drop() in close() instead of the other way round and that not only breaks the existing interface, it is also awkward to read in the code.


floor - writer - cache result of GetSchemaDefinition() call

Whilst debugging a performance degradation issue in production the pprof
CPU samples came back indicating that the majority of heap allocations
were being generated by calls to GetSchemaDefinition(), by moving these
calls out of the hot path and caching the schema definition hopefully
the GC load can be reduced.

Codecov Report

Merging #52 (5c29fa5) into master (54c24c6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   85.11%   85.11%
=======================================
  Files          47       47
  Lines        9492     9494    +2
=======================================
+ Hits         8079     8081    +2
  Misses       1045     1045
  Partials      368      368

Impacted Files
Coverage Δ

floor/writer.go
77.45% <100.00%> (+0.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54c24c6...5c29fa5. Read the comment docs.


Feature Request : able to action 'testing.unhideTest' from a task.

I would like to run all the tests from the task.
However, if there is a hidden test (e.g. by mistake), that test will not be executed.
Is it possible to make testing.unhideTest work from task?
Or if there is a command that ignores the hidden ones and runs all tests, that would be fine.
task.json
        {
            "label": "test all",
            "type": "shell",
            "problemMatcher": [],
            "dependsOrder": "sequence",
            "promptOnClose": true,
            "dependsOn": [
                "testing.unhideTest",
                "testing.runAll",
            ]
        },

        {
            "label": "testing.unhideTest",
            "type": "shell",
            "problemMatcher": [],
            "command": "${command:testing.unhideTest}", # no action
        },
       {
            "label": "testing.runAll",
            "type": "shell",
            "problemMatcher": [],
            "command": "${command:testing.runAll}",
        },

It looks like testing.unhideTest expects some arguments and you're looking for a command that unhides all.

Code pointer for the existing action: https://github.com/microsoft/vscode/blob/5ca4d13b40a6b72a39b7ebf55941cdfa2d0558f6/src/vs/workbench/contrib/testing/browser/testExplorerActions.ts#L90

Should there be a new command to unhide all tests say testing.hideAll or a task to run all tasks including hidden tests - testing.runAllIncludingHidden?

@Suven-p Yes! please.

Verified it unhides all hidden tests.


Fixes for build error

The errors fixed:
index.d.ts:
Cannot find namespace 'NodeJS'. ts(2503) [24,35]
Cannot find name 'Buffer'. Do you need to install type definitions for node? Try npm i @types/node. ts(2580) [66,22]

Bump

@unional I am not sure if you saw this. It is a minor PR.

Hi @dctrotz I need to find some time to test this. Thanks for the PR.
🌷

When I try to build, I get some additional errors because typings is deprecated. I'll do some major update to the project instead.
Thanks for the PR thou. 🌷


Update actions/checkout to v4 (node 16->20)

Gets rid of deprecation noise in some of the CI runs.

Thanks!


Automatic tests of games

I think it would be nice to have a general test suite for all games which makes these kinds of generic tests, like action-infoset consistency, zero-sumness if the game claims so, etc., it would be beneficial for game developers. I didn't notice such a thing in the lib. The kinds of tests we've done in GTLib are:

isDomainZeroSum
domainMaxUtility
domainMaxDepth
isNumPlayersCountActionsConsistentInState
isActionGenerationAndAOHConsistent

It's not much, but catches bunch of bugs fast.

We have these already. See tests/basic_tests.cc (these are simulation tests done by all games) and integration_tests/api_test.py.


Fix issue with modifying permissions when not the main owner

Just try to modify permissions when you have the permission node perms but you did not create the group.

I think this went online, what version is it in?

The newest citadel.
On Tue, Mar 3, 2015 at 8:37 PM, ttk2<EMAIL_ADDRESS>wrote:

I think this went online, what version is it in?
—
Reply to this email directly or view it on GitHub
https://github.com/Civcraft/NameLayer/issues/76#issuecomment-77080753.

then its online
On Tue, Mar 3, 2015 at 7:42 PM rourke750<EMAIL_ADDRESS>wrote:

The newest citadel.
On Tue, Mar 3, 2015 at 8:37 PM, ttk2<EMAIL_ADDRESS>wrote:

I think this went online, what version is it in?
—
Reply to this email directly or view it on GitHub
https://github.com/Civcraft/NameLayer/issues/76#issuecomment-77080753.

—
Reply to this email directly or view it on GitHub
https://github.com/Civcraft/NameLayer/issues/76#issuecomment-77081269.


CallerID implementation throws a "Class not registered (Exception from HRESULT: 0x80040154 (REGDB_E_CLASSNOTREG))"

I'm using the example of CallerID and when I'm trying to run it on my device it throws that exception. I'm in the 10586 build in my device.

Can you isolate the problem to a specific line of code? What class is not registered?

I don't see this error being thrown in the caller id sample, though when I tried to create a similar solution I got exactly the error described

Since you say that the sample itself runs fine, the problem is elsewhere. You can open a support case with our Developer Support team who can further help with the specific problem you are experiencing. Please use these steps below for further help:

Visit http://aka.ms/storesupport and sign-in with your Microsoft account
Under the “App Development” section choose "Windows 10 universal app development", then choose the appropriate problem type and category to get engaged through a formal support channel


FixedBase refactor: rename msm -> mul, declutter the interface and hide aux methods

Description
I don't think it's worth doing a bigger refactor proposed in https://github.com/arkworks-rs/algebra/issues/432 - yet still the two MSMs we had were confusing people. This PR is sort of bridging this gap of having a documented, simple interface that is clearly distinct from VariableBaseMSM.
I renamed FixedBase::msm into FixedBase::mul and introduces the following refactors:

Make all methods except for mul private. (Edit: get_window_table also remains public)
Simplify the mul interface: takes g and list of scalars as the parameters. The rest of the parameters can be inferred, and the internal methods called from mul directly.
Add a description and add a doctest

@msmirnov18
closes: #432

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (master)
[ ] Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[ ] Wrote unit tests
[ ] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[ ] Re-reviewed Files changed in the GitHub PR explorer

Actually, I think get_window_table should remain public e.g. for Groth16.

What do you think about just moving this to the ScalarMul trait? I think since we're doing a breaking change, a larger refactor would be nice too. I can handle it if you'd like.

Sure, we can move it. I'm open to other refactors too, the question is how useful this method is.

What other refactors are you thinking of, actually?

Sure, we can move it. I'm open to other refactors too, the question is how useful this method is.

In general this method is useful whenever you want to multiply the same element by different scalars. This is useful primarily in setup methods for, e.g., Groth16 or KZG, but only in testing.
So I'd like to keep it, and just make it easier to use.

What other refactors are you thinking of, actually, aside from moving?
I'll take a stab at these changes, and then we can compare and see if they're worth it.

@mmagician I've added my changes; let me know if there's anything further you'd like to change.

Looks good, I'd approve if I weren't the PR author 👍🏼 Thanks for the changes!


Fix Source timeStamp to consistently use Epoch time

React SyntheticEvent timestamps are based on the DOM event timeStamps that are derived as 'time since document load'. (https://developer.mozilla.org/en-US/docs/Web/API/Event/timeStamp).
The timeStamp field on the Nova Source object is expected to use the Javascript Epoch time format (milliseconds since Jan 1 1970).
This change uses the underlying event data attached to the React SyntheticEvent to convert the UIEvent timeStamp into standard Epoch format, and falls back to Date.now() if the data is not available.

This looks good, but I just want to note that this wasn't always the case (before 2016), but probably not a case we need to consider?
See e.g. this polyfill https://github.com/majido/high-resolution-timestamp-polyfill/blob/master/translate-timeStamp.js

Hmm, that is interesting. I don't think we need that level of complexity for the current hosts, but will need to keep that in mind.

This looks good, but I just want to note that this wasn't always the case (before 2016), but probably not a case we need to consider?
See e.g. this polyfill https://github.com/majido/high-resolution-timestamp-polyfill/blob/master/translate-timeStamp.js

Hmm, that is interesting. I don't think we need that level of complexity for the current hosts, but will need to keep that in mind.

Need to learn how to use GitHub. Apparently you don't resolve comment threads, but you can abandon the entire PR? :)


Error adding a package with libgit backend.

Fixed in https://github.com/npasserini/iceberg/commit/1a799d3bd5408662c0e9565d2de547c50e4a168f


Prometheus configuration reloads slowly

Bug Report
I'm reloading Prometheus configurations through a continuous deployment process using ansible.  I'm finding that configurations take such a long time to reload that what seem like sensible timeout thresholds are consistently passed by the reload process.
What are some factors that could be causing the significant reload times?
What did you do?
curl -X POST localhost:9090/-/reload
What did you expect to see?
Expected Prometheus to reload my configuration in < 90s
What did you see instead? Under which circumstances?
Prometheus seems to take ~2.5 minutes to reload the configuration.
Environment
Prometheus is deployed using docker with the configuration mounted from the file system to
/etc/prometheus/prometheus.yml.  I am loading a new file to the local filesystem and almost immediately triggering a reload of the prometheus configuration via lifecycle APIs.
Containers aren't rebooted frequently.

System information:
Linux 4.4.0-1057-aws x86_64

Prometheus version:

prometheus, version 2.2.1
build date:       20180314-14:15:45
go version:       go1.10

Prometheus configuration file:

global:
  scrape_interval: 30s
  scrape_timeout: 30s

alerting:
  alertmanagers:
  - file_sd_configs:
    - files:
      - /etc/prometheus/alertmanagers.yml

rule_files:
  - /etc/prometheus/rules/*.yml

scrape_configs:
  - job_name: '<redacted>'
    ec2_sd_configs:
    - region: us-east-1
      port: 9100
      access_key: <redacted>
      secret_key: <redacted>
    relabel_configs: <redacted>

  - job_name: '<redacted>'
    ec2_sd_configs:
    - region: <redacted>
      port: 9100
      access_key: <redacted>
      secret_key: <redacted>
     relabel_configs: <redacted>

  - job_name: '<redacted>'
    ec2_sd_configs:
    - region: <redacted>
      port: 9100
      access_key: <redacted>
      secret_key: <redacted>
    relabel_configs: <redacted>

  - job_name: '<redacted>'
    ec2_sd_configs:
    - region: <redacted>
      port: 9090
      access_key: <redacted>
      secret_key: <redacted>
    relabel_configs: <redacted>

  - job_name: '<redacted>'
    ec2_sd_configs:
    - region: <redacted>
      port: 9090
      access_key: <redacted>
      secret_key: <redacted>
    relabel_configs: <redacted>

  - job_name: '<redacted>'
    ec2_sd_configs:
    - region: <redacted>
      port: 9090
      access_key: <redacted>
      secret_key: <redacted>
    relabel_configs: <redacted>

  - job_name: '<redacted>'
    kubernetes_sd_configs:
    - role: pod
      api_server: <redacted>
    bearer_token: <redacted>
    scheme: https
    relabel_configs: <redacted>

  - job_name: '<redacted>'
    kubernetes_sd_configs:
    - role: pod
      api_server: <redacted>
    bearer_token: <redacted>
    scheme: https
    relabel_configs: <redacted>

  - job_name: '<redacted>'
    kubernetes_sd_configs:
    - role: pod
      api_server: <redacted>
    bearer_token: <redacted>
    scheme: https
    relabel_configs: <redacted>

  - job_name: '<redacted>'
    kubernetes_sd_configs:
    - role: pod
      api_server: <redacted>
    bearer_token: <redacted>
    scheme: https
    relabel_configs: <redacted>

  - job_name: '<redacted>'
    static_configs:
    - targets: ['<redacted>']

  - job_name: '<redacted>'
    static_configs:
    - targets: ['<redacted>']

Logs:
No relevant logs available

Do you have rule groups taking 2.5 minutes to evaluate?

I have a single rule group with 5 recording rules and 12 alerting rules.  Is there a way that I could hook into Prometheus to get a gauge of how long it is taking to evaluate that rule group?

If you look at the Rules Status page it'll tell you.

@brian-brazil my rules group is reporting taking 440ms to evaluate

@krasi-georgiev In a continuous deployment context, the problem is that the deployment job would appear to have succeeded in the event of a failure to reload

There's something odd going on then. How are you measuring the 2.5 minutes, and can you share logs?

@brian-brazil I'm not measuring strictly -- more eyeballing it.  I can guarantee the time is more than 90s though, as that is my failure threshold.  I'll get you some details about the process and some logs as well.

First thing's first -- here are some stats on timing reloads with a local curl request:
$ time curl -X POST localhost:9090/-/reload
real	1m44.133s
user	0m0.000s
sys	0m0.008s

$ time curl -X POST localhost:9090/-/reload
real	3m24.448s
user	0m0.008s
sys	0m0.004s

$ time curl -X POST localhost:9090/-/reload
real	2m0.908s
user	0m0.000s
sys	0m0.008s

I didn't execute those curls consecutively -- I left a bit of time between executions.  It definitely highlights some inconsistency in the behavior.

Here are some logs from the server where I executed the above reloads
b9ed65e46f5d12625ea54a0ef356eb25baf49f2e259fdb0c9f2f9ebb8206605d-json.log

EC2 discovery error and relative timeout, from the logs:
"discovery manager scrape" discovery=ec2 msg="Refresh failed" err="could not describe instances: EC2RoleRequestError: no EC2 instance role found"

Hi,
We too get the same problem. Is this solved with your latest version? Do we have any updates on this case?
Thanks,
Teja

I am working on a PR that will speed up the reloading quite a bit. The problem is that stopping scraping loops for running target is now executed in serial and I am updating the code to stop these in parallel.
Will link the pr when ready.


Multiple metrics and regularization

Hello all,
I would like to use a combination of two image-based metrics and a regularization term for the elastic registration of CT lung images. This is defined in the elastix parameter file as follows:
(Registration "MultiMetricMultiResolutionRegistration")
(Metric "AdvancedNormalizedCorrelation" "AdvancedNormalizedCorrelation" "TransformBendingEnergyPenalty")

(FixedImagePyramid "FixedRecursiveImagePyramid" "FixedRecursiveImagePyramid")
(MovingImagePyramid "MovingRecursiveImagePyramid" "MovingRecursiveImagePyramid")
(ImageSampler "Random" "Random")
(Interpolator "BSplineInterpolator" "BSplineInterpolator")

I provide elastix with two moving images (-m0 -m1) and two fixed images (-f0 -f1) as well as the typical input/output parameters, but I obtain an error at execution:
Description: itk::ERROR: itk::ERROR: MultiMetricMultiResolutionRegistration(0000025A5C22BED0): The NumberOfInterpolators should equal 1 or equal the NumberOfMetrics
If I try to add interpolator, image sampler and image pyramid descriptions for the penalty term it gives me another error:
Description: itk::ERROR: FixedRecursivePyramid(000002A2B81755C0): Input Primary is required but not set.
I have implemented this multi metric with penalization feature by adding some logic to count separately the "image based", "transformation based" and "point set based" metrics. This allows to check for the number of image pyramids and interpolators according to the specified metrics, since it seems to me that such components are needed only for the "image based" metrics.
I will make a pull request with a link to this issue to facilitate tracking.
Best,

@alvarez-pa Thank you for your carefully written issue and pull request, Pablo! We will have a closer look this month. As it appears such a fundamental issue, we may need some more time.

Hello all,
I seem to have run into the same issue! I want to provide Elastix with multi-channel data (-f0 ... -f5 and -m0 ... -m5) and want to use two regularizers (transform bending penalty and corresponding points penalty) alongside an image similarity metric (normalized mutual information).
I understand it might be hard to merge the fix described within a stable release. I was wondering if @alvarez-pa had a compiled binary with his local fix that could be shared. Thanks in advance!
Cheers,
Ishaan

Hello @ishaanb92,
I do not have access anymore to the machine where I compiled Elastix with the fix to this problem. Therefore, I unfortunately cannot give you any binaries. However, you may try to recompile the code yourself with the fix applied.
If you decide to recompile, you may proceed in two ways:

You compile an old version of Elastix containing the fix. You will find the code in my github repository: https://github.com/alvarez-pa/elastix/tree/fix_enhance.
You apply the fix to a more recent version of Elastix. You can see what changes are needed here: https://github.com/SuperElastix/elastix/pull/482/files.

There may be other ways, but those are the two I am aware of. I hope it helps.
Best,
Pablo


Padding and alignments of buttons, etc are weird when using styled + tailwind

When using Prime React with Styled + Tailwind options (Vite and Nextjs, for example), the padding on the button and the alignment of the icons/ other components is different than what is shown on the documentation page.
When using the original values in vite-styled-tailwind/src/index.css:
font-size: 16px;
line-height: 24px;

The button and the input field have excessive padding, the icon in the cutton is too low, radio buttons look normal.

Now I change the values in in vite-styled-tailwind/src/index.css:
font-size: 14px;
line-height: 18px;

to match font size: 14px used the Button Component documentation page (https://primereact.org/button/). line-height is not used there, interestingly enough.
As one can see, the buttons look different, also the alignment of the radio buttons and the icon inside the button is off:

There seems to be some issue here where Tailwind is interfering with the layout, can anyone help out? Thanks.

Yeah this is tricky with Tailwind + Styled mode.  There are lots of conflicting CSS I am sure.

What would you suggest? Should I remove Tailwind altogether, or use Unstyled mode?

well you miht be able to debug it and see what is causing the padding issues and recommend a fix to PrimeReact.

Can you provide a stackblitz so I can take a look on the problem?

The code I tested is the one from this repo:
https://github.com/primefaces/primereact-examples/tree/main/vite-unstyled-tailwind


CI: Workflow chrome shows Annotations warnings

Describe the bug
Running the example workflow .github/workflows/example-chrome.yml produces Annotation warnings:

"Unexpected input(s) 'headless', valid inputs are ['record', 'config', 'config-file', 'env', 'browser', 'command', 'start', 'start-windows', 'build', 'install', 'install-command', 'runTests', 'wait-on', 'wait-on-timeout', 'parallel', 'group', 'tag', 'working-directory', 'headed', 'spec', 'project', 'command-prefix', 'ci-build-id', 'cache-key', 'quiet', 'component']"

"No files were found with the provided path: examples/chrome/cypress/videos. No artifacts will be uploaded."

"No files were found with the provided path: examples/chrome/cypress/screenshots. No artifacts will be uploaded."

See for example run<PHONE_NUMBER>.
Steps to reproduce the issue
Open a pull request
View the the action logs for https://github.com/cypress-io/github-action/actions/workflows/example-chrome.yml
Expected behavior
There should be no Annotations warnings in the log.
Suggested Fixes

Correct the paths for artifact uploads. Add v9 for v9 tests.
Ensure that the artifact names are unique. Append -v10 to v10 tests.
Convert the incorrect parameter headless: true to headed: false

PR https://github.com/cypress-io/github-action/pull/670 is submitted to resolve this issue


[CONFLUENCE PLUGIN] Support edit urls

In 7.4.17, when a user saves a page or blogpost, a PUT request is made to /rest/api/content. Send this as an event.
In 7.4.17, when a user deletes a page, /rest/api/content is not invoked (archiving of page). When the page is actually purged, again /rest/api/content is not being invoked. The current confluence server api suggests that POST is used for creation and DELETE for deletion. So those two are also added.
Handle null query when sending the url in the event
Add http method as a query param

@sushant-glean can you please generate the new package & upload ?

Has been released as v1.2.1 on marketplace- https://marketplace.atlassian.com/apps/1228567/glean-activity-plugin-for-confluence-data-center-server/version-history#b1000070


Polymer.dom(elem).cloneNode(true) does not copy the values of changed properties

I am not sure if this is by design or a bug, but If I modify a property of an element and later clone it, the cloned instance has the original value.
Here is a jsbin: http://jsbin.com/vijiji/edit?html,console

This is by design.  The native HTML cloneNode only clones HTLM attributes, not JS properties.
Polymer provides a reflectToAttribute: true setting for properties you can use to keep the attribute in sync with the property, which will allow the current values to be copied when cloned, however updating attributes on elements is a fairly expensive operation and can impact performance
Depending on the circumstance, it may be better to implement a cloneWithProperties API on your element which calls Polymer.dom(this).coneNode(true) and then copies properties over.
Hope that helps.

@kevinpschaaf This is grate idea.
Without "reflectToAttribute: true" .setAttribute('data', JSON) on clonedNODE don't bind data.
How to set/copy these properties?


Add multi-select-combo-box

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


The reference implementation allows getters/setters on the same fields that already have address takers

This is quite counter-intuitive, especially as the reference implementation always pick the address taker in such a case (as far as I can tell), even for trivial cases like foo.x = 42;
I think it should be a validation failure to have such useless getters and setters.

The C++ implementation does the right thing on that, the spec was updated, and the JS implementation is gone, so I'm closing this issue.


[Linear] Setting of cycle does not work anymore

Extension
https://www.raycast.com/linear/linear
Description
When creating an issue the cycle is not set correctly anymore.
Steps To Reproduce
Create an issue from raycast with a cycle. Check in linear app (where the cycle is not set).
Current Behaviour
No response
Expected Behaviour
No response

Could you send a recording to see what happens?

Hope it is clear like this:
Uploading Raycast Bug.mp4…

@thomaslombart any progress on this?

No progress on it yet. There is a growing list of extensions to maintain at Raycast, which implies that we cannot be at the top of everything. So, feel free to take a shot at it and open a PR. It will be greatly appreciated! 😊
Note that having a PR merged will earn you some credits as we want to reward contributions. You’ll then be able to exchange them in a swag store that we’ll launch soon!

@raycastbot assign me

Checked on my end and setting the cycles is working now. Maybe an issue with linear api itself, b/c I definitely noticed it not working in the timeframe @brunovollmer  created this issue.
Moreover, the way we've implemented the graphQL mutation should work as intended:
https://github.com/raycast/extensions/blob/5c077f5a72c66ae6caab0a5958f4d89fb30c86df/extensions/linear/src/api/createIssue.ts#L44-L46
Closing this issue. Please re-open if the latest version of the command/extension does not work for you @brunovollmer

@raycastbot close this issue

Works fine! Thanks for checking


Pyspark testing suite

Description
This PR adds functionality to test within a spark environment, via TravisCI. It should address the this issue. This enables us to test the various distribution components of skdist.
Working Travis build: https://travis-ci.com/Ibotta/sk-dist
TODO:

Add tests for encoderizer
Looking into 2 java install warnings
Think through supporting different Spark versions

Motivation and Context
I followed examples in these repos:
https://github.com/malexer/pytest-spark
https://github.com/fdosani/travis-pytest-spark
https://github.com/databricks/spark-sklearn
Additional notes:

added the openjdk8 for jdk (this is what spark 2.4 needs)
ensure correct java env variables (JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk-amd64)
separate install_requires,tests_require, and  extras_require (install these in Travis) in setup.py
Tests are pretty quick (34s)
Install fairly quick (38s)

How Has This Been Tested?

Local Spark environment setup via TravisCI
Added initial tests
Ensured tests passed in all 3 supported python versions

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project.
[X] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have added reviewers to the PR.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

My vote would be to merge this in and revisit a more holistic testing approach in the future. I think it is important to have coverage of existing Spark functionality and perhaps the best testing suite will become more clear as the library matures. Looking for a decision cc @denver1117


Middleware Provider crashes to validate password

Steps:

Fresh hawkular-services and latest MiQ master.
Fill the form for a new MW provider.
Press validate.

@miq-bot add_label providers/hawkular

@miq-bot add_label bug

Looks like when transmitting to restfull we forgot to edit submitting of forms. Old way was send update everytime user did some change, but with moving to restfull and using Mixins::EmsCommonAngular we expect all parameters to be present in params object, instead on in session.
@rubenvp8510 what do you think?

@karelhala  you're right, it seems like the Mixins::EmsCommonAngular expect the parameters in a different way.

Yeah, no prob. However this should be fixed rather soon, since it's blocker. Btw the prefered way would be to move creating of new provider to angular version, you can look at how it's done in ems_infra or ems_container.
Looks like we have to define couple of new routes, create form file and we should be good to go.

for some reason this was not closed when the fixing PR was merged, so @lucasponce I think you can close the issue manually

Verified, issue is fixed with latest docker image.

Ok, closing manually.


change the script

https://github.com/MicrosoftDocs/windows-itpro-docs/issues/9895

Dear @JohanFreelancer9,
kindly do the copy editor review for this PR.
Dear @e0i, for your information
Thank you

@tiburd The PR from one of the independent contributors has been copy edited and is ready for review. Thanks.

The replacement PR has been merged. Thank you for the discussion.


feat: basic unstructured loader for langchainjs

Summary
Implements a basic Unstructured file loader for langchainjs. The loader posts the specified file to the Unstructured REST API. The API is not public yet, but you can run it locally using the instructions here. The test is disabled temporarily, but once we have a hosted API for the test to hit I can add in a PR to enable it.
Adds node-fetch and form-data as dependencies. Couldn't figure out how to get the mixed/multipart-form post to work without those, but maybe someone who's better than me at node can suggest an alternative :)
Testing

Install the Unstructured API locally using the instructions  here.
Run make run-web-app
Uncomment the code in langchain/src/document_loaders/tests/unstructured.test.ts
Run yarn test. The tests should pass and you should see a 200 in the logs for the Unstructured API.

@MthwRobinson thanks for this! I'll have a look at removing the node-fetch dependency, I think there is a way of doing it without it

@MthwRobinson getting the following issue running this locally after converting it to use native fetch available in Node 16 onwards (which is what we support)

Will push my changes to a branch so you can see/try

Changes here https://github.com/Unstructured-IO/langchainjs/compare/feat/unstructured-loader...hwchase17:langchainjs:nc/unstructured?expand=1
Any ideas let me know

Ah, in that branch getting this error instead
INFO:     <IP_ADDRESS>:63419 - "POST /general/v0.0.4/general HTTP/1.1" 500 Internal Server Error
ERROR:    Exception in ASGI application
Traceback (most recent call last):
  File "/Users/nuno/.pyenv/versions/unstructured/lib/python3.8/site-packages/uvicorn/protocols/http/httptools_impl.py", line 419, in run_asgi
    result = await app(  # type: ignore[func-returns-value]
  File "/Users/nuno/.pyenv/versions/unstructured/lib/python3.8/site-packages/uvicorn/middleware/proxy_headers.py", line 78, in __call__
    return await self.app(scope, receive, send)
  File "/Users/nuno/.pyenv/versions/unstructured/lib/python3.8/site-packages/fastapi/applications.py", line 271, in __call__
    await super().__call__(scope, receive, send)
  File "/Users/nuno/.pyenv/versions/unstructured/lib/python3.8/site-packages/starlette/applications.py", line 118, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/Users/nuno/.pyenv/versions/unstructured/lib/python3.8/site-packages/starlette/middleware/errors.py", line 184, in __call__
    raise exc
  File "/Users/nuno/.pyenv/versions/unstructured/lib/python3.8/site-packages/starlette/middleware/errors.py", line 162, in __call__
    await self.app(scope, receive, _send)
  File "/Users/nuno/.pyenv/versions/unstructured/lib/python3.8/site-packages/starlette/middleware/exceptions.py", line 79, in __call__
    raise exc
  File "/Users/nuno/.pyenv/versions/unstructured/lib/python3.8/site-packages/starlette/middleware/exceptions.py", line 68, in __call__
    await self.app(scope, receive, sender)
  File "/Users/nuno/.pyenv/versions/unstructured/lib/python3.8/site-packages/fastapi/middleware/asyncexitstack.py", line 21, in __call__
    raise e
  File "/Users/nuno/.pyenv/versions/unstructured/lib/python3.8/site-packages/fastapi/middleware/asyncexitstack.py", line 18, in __call__
    await self.app(scope, receive, send)
  File "/Users/nuno/.pyenv/versions/unstructured/lib/python3.8/site-packages/starlette/routing.py", line 706, in __call__
    await route.handle(scope, receive, send)
  File "/Users/nuno/.pyenv/versions/unstructured/lib/python3.8/site-packages/starlette/routing.py", line 276, in handle
    await self.app(scope, receive, send)
  File "/Users/nuno/.pyenv/versions/unstructured/lib/python3.8/site-packages/starlette/routing.py", line 66, in app
    response = await func(request)
  File "/Users/nuno/.pyenv/versions/unstructured/lib/python3.8/site-packages/fastapi/routing.py", line 237, in app
    raw_response = await run_endpoint_function(
  File "/Users/nuno/.pyenv/versions/unstructured/lib/python3.8/site-packages/fastapi/routing.py", line 163, in run_endpoint_function
    return await dependant.call(**values)
  File "/Users/nuno/.pyenv/versions/unstructured/lib/python3.8/site-packages/slowapi/extension.py", line 729, in async_wrapper
    response = await func(*args, **kwargs)  # type: ignore
  File "/Users/nuno/dev/unstructured-pipeline-general/./prepline_general/api/general.py", line 168, in pipeline_1
    response = pipeline_api(
  File "/Users/nuno/dev/unstructured-pipeline-general/./prepline_general/api/general.py", line 52, in pipeline_api
    elements = partition(filename=temp_file.name)
  File "/Users/nuno/.pyenv/versions/unstructured/lib/python3.8/site-packages/unstructured/partition/auto.py", line 69, in partition
    raise ValueError(f"{msg}. File type not support in partition.")
ValueError: Invalid file /var/folders/s_/r3cdpdn51ks9bw89jryhr08w0000gn/T/tmpo6z4is5k. File type not support in partition.```

@nfcampos - Give it a try on this branch. Added in a quick fix that we'll need to clean up, but you should be able to test against that now.
cc: @LaverdeS

@MthwRobinson it works for me now, pushed some changes to my branch above, do you want me to combine it with yours?

@nfcampos - Yeah do you want to merge your branch into this one?

Great! When would we want to merge this? Given the API isn't public yet

Thanks for all the help! We should have the container ready sometime next week, I think it makes sense to hold on merging til then. @LaverdeS is working on that right now. We'll keep in touch on the status!

Hey guys. Unstructured's pipeline-general has all the fixes now in this branch. You can tryout the API running the target make run-web-app and parse your .txt files and the other 8 doc-types 🙌🏼. Thank you for your contributions!


Print body on error to aid in debugging

It would be really nice to print out the body of the webhook when it fails.
Even better would be to print out a curl command line to reproduce the failure, with any secrets un-substituted. Unclear if this is implementable though.
That said, just redacting the URL and making printing out the body (and header) on failure an opt-in feature that folks who don't have secrets in their body or header can opt into would be awesome. Formatting it as a curl commandline (but with the user having to provide a URL) would still be really helpful.
I know its possible to simulate this, but the best way I've found is pretty convoluted: add the body to the job's environment and add steps to print that environment prior to the webhook attempting to pass it as the body. It'd be much cleaner and nicer to have the webhook JS code do this error logging for us.

:sigh:
It seems the github action UI already supports this and I just didn't realize it. Nevermind. Sorry for the noise.


Fixing permission issue during rm_injections

Post bump, this should fix origin 10009.
StreamFileAsTar makes an attempt to chmod the rm-injections script to 666 before injecting it with a tar stream, but StreamFileAsTarWithCallback was actually setting these permissions on the primordial source for rm-injections.
Before this PR, rm-injections ended up as root:root 600 in the build container. Now it should be 666 and source-able by the default user.

@bparees

lgtm [merge]


More checkpoint fixes

Description
Fix issues discovered by running test suite with checkpoint_threshold=0 with auto_checkpoint=true
Fix failing tests in:

test/test_files/update_rel/create_ldbc_sf01.test, test/test_files/transaction/create_rel/insert_rels_to_different_nodes.test - correctly use old/new csr header offsets in CSRNodeGroup::checkpointColumn

test/test_files/update_node/set_tinysnb.test - fix infinite loop in UpdateInfo::hasUpdates

test/test_files/update_node/set_empty.test - sync num values for struct columns/chunks

test/test_files/transaction/create_rel/insert_rels_to_newly_added_node.test - ensure values returned by csr header get start/end offset is increasing as nodeOffset increases

test/test_files/update_rel/create_batch.test - (partially fixed, still incorrect query result) - fixed segfault caused by filling gaps in node group collections with nullptrs

Contributor agreement

[ ] I have read and agree to the Contributor Agreement.

These are now fixed in #3963 and #3959 .


Request new feature

god day mate, request for a new feature where you can set the location of the bar whether top or bottom just like the new Windows Defender or the Skype Preview navigation bar. TY

hey buddy. Maybe something like that?

I'm looking into Windows Defender (from W10 Creatros Update) and don't see how to set up "left Navigation bar" to top or bottom. I'm missing something? A Screen Shot would be nice :)

something like this mate, the items can be set top then other in bottom, that would be a great enhancement on the control

Ok, i see now.
You could use two Navigation controls and perform some Anchor hack to make this layout.
The problem is that the Navigation control can grow if it has child nodes (like Demo#2 and Demo#3).
If you have a layout like Demo#1, placing two controls and default panel control with same backcolor as Navigation control, you could have someting like:

Note the Anchors of each control & panel
Not the feature you request but hey, you know 😃

oww, i did not think of that, I'm only using the demo 1, thanks for your hack, but it owuld be a great feature if implemented.


Can you explain this classification by using simple code in python

I need a basic program to show genes tumour classification in deep learning.

Hi @rajitnair - this repository implements the analyses described in the papers linked from the README in the root of the repo. It doesn't sound like it provides what you are requesting. Thanks for your interest!


Preflight will only return if event.isInvalidHTTPMethod() is true

We have a legacy API application thats does not make use of 'restful resources'. Its just a bunch of jumbled endpoints which can respond to any method (yes this wrong, but it is what we have to deal with) and I don't necessary want to go to every handler/action to specify the this.allowedMethods structure.
The cors module will only respond to a preflighted request if the current event is an invalidHTTPMethod.
if ( event.isInvalidHTTPMethod() ) {
    log.debug( "No handler action for an OPTIONS request.  Returning a 200 OK." );
    event.noExecution();
    event.renderData( "plain", "Preflight OK" );
    return;
}

Currently my work around is to change the above if statement to:
 if ( event.isInvalidHTTPMethod() || event.getHTTPMethod() == "OPTIONS" )
However I dont think this is the correct approach as the OPTIONS method will not neccessary mean that the current event is a preflight request. I thought about prehaps making this a configurable option.
What are your thoughts?
Regards
Ryan

I'm not sure I'm understanding your request.  The code exists there to allow you to provide your own action for an OPTIONS request, but fall back to the Preflight OK if no action was written.
I'm guessing you are using route() so that all HTTP verbs are matched?  And so you are looking for a way to say, "use the default preflight response for this request".  Is that correct?
My initial thought is that we could introduce a new setting, something like shouldReturnPreflightResponse which accepts a UDF/closure that takes the event and returns a boolean.  The default would return event.isInvalidHTTPMethod() so existing applications work the same.
// interceptors/CORS.cfc
if ( settings.shouldReturnPreflightResponse( event ) ) {
    log.debug( "Returning the default 200 OK preflight response." );
    event.noExecution();
    event.renderData( "plain", "Preflight OK" );
    return;
}

// ModuleConfig.cfc
settings = {
    // ...
    "shouldReturnPreflightResponse" = function( event ) {
        return event.isInvalidHTTPMethod();
    }
}

You could then modify that setting in your config/ColdBox.cfc file:
moduleSettings = {
    "cors": {
        "shouldReturnPreflightResponse": function( event ) { return true; } // this will always be true since this is only ever called for OPTIONS requests.
    }
};

Thoughts?  If you like it, you can maybe put together a PR?


Eliminate bqiface and complete test coverage in query package

This change eliminates the query/bqiface package in favor of moving the bigBueryImpl.Query to the query package.
This change also completes test coverage of all code within the bqx repo.

This change is

Pull Request Test Coverage Report for Build 70

18 of 18 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 67:
0.0%

Covered Lines:
238

Relevant Lines:
238

💛  - Coveralls


Add prettierrc.json config

This pull request adds a prettierrc.json configuration file to the project.
The configuration ensures that all outputted code conforms to a consistent style.

I merged it into develop directly and formatted all files. Thanks for the PR!


er#123

Problem encountered on https://dotnet.microsoft.com/learn/aspnet/hello-world-tutorial/install
Operating System: windows
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.

When the application is ready to be released, you create a release version of the build. In a release version, you remove the code that's required for debugging. Again, in both the visual and the command-line tools, you can compile a release version.
To run the release version, you must install the .NET runtime on the destination computer. This computer will run your compiled .NET assembly.

.NET is popular in enterprises for various reasons. Advantages include its ecosystem and its integration with other Microsoft products, including Azure cloud services and on-premise server products. Further, .NET is a strongly typed system, so it avoids many of the bugs that can arise in loosely typed systems. Developers can choose to use an object-based paradigm in C# or a functional-based paradigm in F#. They use the language that best fits the kinds of problems they need to solve.


VITS Japanese模型训练报错

/content/vits/utils.py:134: WavFileWarning: Chunk (non-data) not understood, skipping it.
sampling_rate, data = read(full_path)
INFO:zerot:Saving model and optimizer state at iteration 1 to ../drive/MyDrive/zerot/G_0.pth
INFO:zerot:Saving model and optimizer state at iteration 1 to ../drive/MyDrive/zerot/D_0.pth
Traceback (most recent call last):
File "train_ms.py", line 299, in
main()
File "train_ms.py", line 55, in main
mp.spawn(run, nprocs=n_gpus, args=(n_gpus, hps,))
File "/usr/local/lib/python3.7/dist-packages/torch/multiprocessing/spawn.py", line 200, in spawn
return start_processes(fn, args, nprocs, join, daemon, start_method='spawn')
File "/usr/local/lib/python3.7/dist-packages/torch/multiprocessing/spawn.py", line 158, in start_processes
while not context.join():
File "/usr/local/lib/python3.7/dist-packages/torch/multiprocessing/spawn.py", line 119, in join
raise Exception(msg)
Exception:
-- Process 0 terminated with the following error:
Traceback (most recent call last):
File "/usr/local/lib/python3.7/dist-packages/torch/multiprocessing/spawn.py", line 20, in _wrap
fn(i, *args)
File "/content/vits/train_ms.py", line 123, in run
train_and_evaluate(rank, epoch, hps, [net_g, net_d], [optim_g, optim_d], [scheduler_g, scheduler_d], scaler, [train_loader, eval_loader], logger, [writer, writer_eval])
File "/content/vits/train_ms.py", line 151, in train_and_evaluate
(z, z_p, m_p, logs_p, m_q, logs_q) = net_g(x, x_lengths, spec, spec_lengths, speakers)
File "/usr/local/lib/python3.7/dist-packages/torch/nn/modules/module.py", line 722, in _call_impl
result = self.forward(*input, **kwargs)
File "/usr/local/lib/python3.7/dist-packages/torch/nn/parallel/distributed.py", line 511, in forward
output = self.module(*inputs[0], **kwargs[0])
File "/usr/local/lib/python3.7/dist-packages/torch/nn/modules/module.py", line 722, in _call_impl
result = self.forward(*input, **kwargs)
File "/content/vits/models.py", line 495, in forward
z_slice, ids_slice = commons.rand_slice_segments(z, y_lengths, self.segment_size)
File "/content/vits/commons.py", line 63, in rand_slice_segments
ret = slice_segments(x, ids_str, segment_size)
File "/content/vits/commons.py", line 53, in slice_segments
ret[i] = x[i, :, idx_str:idx_end]
RuntimeError: The expanded size of the tensor (32) must match the existing size (0) at non-singleton dimension 1.  Target sizes: [192, 32].  Tensor sizes: [192, 0]
我自己提取的wav文件进行训练，结果发现程序报错，自己尝试解决但是没有成功，希望大佬能帮忙解决一下。

音频过短

请问大概多长的音频比较合适？

0.35s

了解，谢谢大佬解答疑惑！


dr-auto-sync: judge whether RocksWriteBatchVec is empty

Signed-off-by: lhy1024<EMAIL_ADDRESS>
What is changed and how it works?

Issue Number: Close #13194
What's Changed:
judge whether RocksWriteBatchVec is empty

Related changes

Need to cherry-pick to the release branch
6.2

Check List
Tests

Unit test

Release note
None

/merge


doesnt work on ixel.in

it doesnt work in ixel.in

please be specific on what did not work?
like what things does it break?
if you do have any issues, most cases you might just have to put them into the whitelisted list
as using this method to stop paste blocking can sometimes cause unintended consequences...

@vsreenathreddy1 You probably want to update the extension's options to add ixel.in to the exclusions list.

Open Chrome to: chrome://extensions/?options=nkgllhigpcljnhoakjkgaieabnkmgdkb
Add https?://.*?ixel.in/.* to the second text box

For backwards compatibility with older versions of this extension, the default configuration is to blacklist all sites and whitelist a few. I think the opposite is a better solution: whitelist all sites and blacklist only the troublesome ones. I've been wanting to change the extension to do just that, but that's still a work in progress.


Word separation doesn't select the $ in  PHP's variables

The default setting should be:
    "[php]": {
        "editor.wordSeparators": "`~!@#%^&*()-=+[{]}\\|;:'\",.<>/?", //no $
    },

I think it's nicer for things like alt+arrow keys to work predictably across different file types, but this is there for users to configure with the configuration you suggest if they prefer something different.

The problem is that no one working with PHP would not want to select the whole variable. Every single PHP developer needs to search on SO and copy and paste this setting every time they install vscode and it's just a pain the IDE doesn't just handle it right by default.


Change template readme.md to use new david devDependency links

The old devDependency links were causing me problems by showing the wrong number of dev dependencies I have and their version, so I had a look at the issues from david and it seems that they changed the devDependency links.
Instead of #info=devDependencies they now use ?type=dev, once I did this change in my own project david started displaying the right badge and details.
Official David issue here

Thanks! I have a lot of repositories to update now 😳

You're welcome.
I really love the package, so I decided to help a bit!


Proposal to change default H.264 levels

Proposal to change default H.264 levels
The H.264 standard defines a set of capabilities called profiles. By default, the transcode-video tool uses the high profile. Within that profile, the standard also defines contraints called levels.
Here are the levels used by transcode-video for certain output resolutions:

Output resolution
H.264 level

1080p or Blu-ray video
4.0

720p
3.1

480i, 576p or DVD video
3.0

These levels were originally chosen to match those available from the iTunes Store at the same resolutions.
The problem is that when using my special, or default, ratecontrol system, output bitrates might not conform to the constraints defined by these levels. So, pedantic as it might seem, I think it's time to change this.
I propose that all H.264 video at resolutions of 1080p and below use level 4.1, which has a much higher upper boundary on conforming bitrates.
When Apple added support for 1080p video to the iPhone in 2011 for the 4S model, they supported level 4.1. And pretty much any other device made in the last 7 to 10 years supports level 4.1 video. Desktop software like VLC has supported 4.1 far longer than that.
If you really need support for legacy devices in the future, you can always add something like --handbrake-option encoder-level=3.0 to your command line.
Let me know what you think. Thanks.

Go for it. It doesn't really impact the vast majority of use cases, and there's a path backwards to cover the infrequent edge cases.

Sounds good to me..seems very reasonable and well thought out.
On Wed, Oct 24, 2018 at 4:16 PM Don Melton<EMAIL_ADDRESS>wrote:

Proposal to change default H.264 levels
The H.264 standard defines a set of capabilities called profiles. By
default, the transcode-video tool uses the high profile. Within that
profile, the standard also defines contraints called levels.
Here are the levels used by transcode-video for certain output
resolutions:
Output resolution H.264 level
1080p or Blu-ray video 4.0
720p 3.1
480i, 576p or DVD video 3.0
These levels were originally chosen to match those available from the
iTunes Store at the same resolutions.
The problem is that when using my special, or default, ratecontrol system,
output bitrates might not conform to the constraints defined by these
levels. So, pedantic as it might seem, I think it's time to change this.
I propose that all H.264 video at resolutions of 1080p and below use level
4.1, which has a much higher upper boundary on conforming bitrates.
When Apple added support for 1080p video to the iPhone in 2011 for the 4S
model, they supported level 4.1. And pretty much any other device made in
the last 7 to 10 years supports level 4.1 video. Desktop software like
VLC has supported 4.1 far longer than that.
If you really need support for legacy devices in the future, you can
always add something like --handbrake-option encoder-level=3.0 to your
command line.
Let me know what you think. Thanks.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/donmelton/video_transcoding/issues/226, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABLkQkEGO7XA0eACzGMiiBLq0PPfxCkOks5uoNiXgaJpZM4X5E1v
.

Thanks @RodBrown1988, @khaosx and @Thor263 for the quick feedback! I've coded the change now and I'm testing it. And in the process I've found two other small bugs. :)
I'll probably land this tomorrow if there are no other objections.

Don, I was curious in what cases when using your default ratecontrol system does the bitrate exceed the levels defined in 4.0?

@cameronks When the input is extremely complicated, e.g. very grainy or high motion with small objects like confetti, there is a risk that the bitrate could exceed 25 Mbps.
An example of when this can happen is transcoding the HBO "static" logo at the beginning of some episode of shows like "Game of Thrones."
And, unfortunately, there's no way to fix that. My special, or default, ratecontrol system is designed to violate its VBV constraints. That's how it maintains quality.

@cameronks BTW, this is never a risk when using my ABR ratecontrol system or the new VBR ratecontrol system which I'm working on now and will likely unveil next week.

After looking at what streaming services like Netflix and Amazon are doing, I've decided to back out this change for now. They seem to be sticking to the old H.264 levels and I don't know why. They probably know something I don't. :)
In the meantime, I'll hold open this proposal and re-evaluate the situation for the next release.
Thanks again to the feedback from @RodBrown1988, @khaosx, @Thor263, @cameronks and all those folks on Twitter!

@arikalish Thanks for the great detective work!
Apparently these "smart" TVs are actually "stupid." Something we knew all along. :)
OK, it's looking more and more like I shouldn't make this change. Good thing I backed it out already.