issue in Eegro map api integration

Hi Team,
I have faced the below mentioned issues with integration in existing ios app.
Undefined symbols for architecture arm64:
"AppRunner::TryBindDisplay(GLKView&, id&)", referenced from:
-[EGMapView initView:] in EGMapView.o
ld: symbol(s) not found for architecture arm64
Please suggest the way to resolve that issue asap.
Thanks

Hi @Parveentyagi - could you please confirm that you have managed to build & run https://github.com/eegeo/ios-api-example ?

Hi Tim
i have try to integrate the ios -api in my existing app according to steps mentioned on git. But face that issue AppRunner::TryBindDisplay(GLKView&, id&)", referenced from:
-[EGMapView initView:] in EGMapView.o
Please help me.
I want to done it asap, so i make a call to but paid version of sdk.
Thanks

Hi
Please help to resolve that issue.
Thanks

Investigating and will get back to you as soon as we can.

See comments on #9 for future improvement to the iOS API to make this clearer. We will assist in the mean time.

@Parveentyagi:- We have investigated and confirmed that our ios api is functioning as expected.. Could you please confirm that you are able to build and run https://github.com/eegeo/ios-api-example
This is important as it will confirm whether or not there is a wider issue with your development environment & our ios api. Please confirm that you are able to follow the instructions in https://github.com/eegeo/ios-api-example/blob/master/README.md and that you can compile and run on a device.

Hi Tim,
Thanks for the update.
I am able to run the example after downloading it and folloow the steps to install the pod files.
Example app show the map for Downtown.
I am follow that link ( https://github.com/eegeo/ios-api) to integarte the eegeo iOS api in my existing app.

@Parveentyagi:- Glad to hear you can run the ios-api-example.
The error you are seeing is a linker error, it is because your project is not linking our static library. the ios-api-example project shows you how to configure your xcode project to correctly link + reference our header libraries.
Could you please try to look at the settings in the ios-api-example project and apply them to your xcode project, specifically around linking native libraries?

Hi Tim,
Thanks for the update.
I have tried multiple time to integrate the eegeo sdk and api in my existing app. I have followed the step same as mentioned in the below mentioned url.
https://github.com/eegeo/ios-api
Could you please provide me the link to download or clone form git the latest iOS Apis and sdk.
Regards,

@Parveentyagi:- the instructions at https://github.com/eegeo/ios-api are how to build the ios-api from source, if you wished to contribute to our ios-api.  It doesn't sound like you want to do this.
You need to be following the guidance set out in ios-api-example - which is how to consume the ios-api, i.e. with a Podspec + project settings as per https://github.com/eegeo/ios-api-example
Given that you can build & run ios-api-example, you should be able to follow the steps to re-create ios-api-example until we action issue #9 which will make this clearer for people in your situation.

Hi Tim,
I have also tried the same steps as mentioned on that link (https://github.com/eegeo/ios-api) for example app. Drag and drop ios api and sdk in to the project and run the app.
Then i have got that error.
ld: library not found for -leegeo-api

@Parveentyagi:- not sure if I can be much clearer - please stop following the instructions at https://github.com/eegeo/ios-api - the instructions there are if you want to build the ios-api from source which you don't.
Please follow instructions at https://github.com/eegeo/ios-api-example - these instructions set you up against the binary of the ios-api from cocoapods. The Xcode + podspec in ios-api-example shows you how to setup your own project from scratch.

HI Tim,
Thanks for the feedback.
I will try again.

Thanks @Parveentyagi:- we are also trying to reproduce the issue you are seeing - if we start from ios-api-example we are unable to reproduce. If we start from a completely blank project we can reproduce. I will send around additional information later.
Additionally, when we resolve issue #9 in the coming weeks, this will be much more straight forward.
Strongly recommend starting from ios-api-example in the mean time

Hi Tim,
I hope you are doing well.
Please let me know any update on the issue mentioned above related to eegeo ios api integration in a existing/new project.
Thanks

Hi Tim,
I hope you are doing well.
Please let me know any update on the issue mentioned above related to eegeo ios api integration.
Thanks

Hi @Parveentyagi issue #9 is underway and is due in the 1.1 milestone

Closing as #9 is complete


doc: correct mdlinter errors on doc

mdlinter errors are fixed with this patch.
Signed-off-by: Humble Chirammal<EMAIL_ADDRESS>

@Madhu-1 @nixpanic ptal.

Which errors are these? Do you know why the static-check does not report them?

@humblec can you please check why CI didn't catch this one?

@Madhu-1 @nixpanic I can check why it was not caught on CI. However as long as this change looks good we could let this get in.

It would help if you can at least include the error messages from the linter. I am not sure the changes are correct/required.


⚠ Bofrost.at has degraded performance

In 27407c3, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1321 ms

Resolved: Bofrost.at performance has improved in 4537189.


Update repo to work with TF 0.13

Update required_version to 0.12.26 everywhere.
Add pre-commit hooks.
Update version numbers in CI build.
Run go fmt and terraform fmt.
Remove updating of Markdown files when we publish AMIs. Too much work to maintain, not enough value.

Tests passed! This PR is ready for review.

Thanks for the review! Merging now.


Switching workspaces on one monitor hides fullscreen app on second monitor

Background
I'm having an issue where switching workspaces that are both on the same monitor results in a fullscreen app minimizing on my other monitor. I'll go into more detail below.
"Displays have separate Spaces" is enabled.
"Group windows by application" is enabled. (disabling doesn't seem to affect this issue)
My main monitor is positioned to the left of my laptop screen. I like to watch a fullscreen video on my laptop screen while working on other things on my main monitor.
I have aerospace workspaces 1 and 2 on my main monitor. workspace 0 on my laptop screen.
When I switch between workspaces 1 and 2 (on main monitor), the video on workspaces 0 goes away to show the desktop. I can still hear the audio and if I just click the screen on the laptop then the video shows up again.
It looks like the apps from inactive workspaces are being moved to the bottom right corner of my laptop monitor. I suspect this might be what is causing the video to go away.
What I've tried

I thought it might just be my browser (chrome) because I have chrome in multiple workspaces including the one playing the video. However, I tried using a different browser for the video only and the issue still happens.
I tried changing my main display to the laptop screen in macOS settings thinking maybe the apps would get moved to my other monitor instead of the laptop monitor. However, the apps always move to the bottom-right of the laptop screen regardless of the settings.
I temporarily tried swapping which monitors my workspaces are on (1 and 2 moved to my laptop screen, 0 moved to my main monitor). This way the video was playing fullscreen on my main monitor and my other apps on my laptop screen. This did "fix" the issue in that I could switch between workspaces 1 and 2 and workspace 0 stayed fullscreen. This leads me to believe the issue is related to where the inactive apps get moved to.
I temporarily moved the arrangement of my laptop in macOS settings to be on the left of my main monitor instead of the right. This did "fix" the issue. This is further evidence that the root of the issue is where the inactive apps get moved to.

Possible solution
(assuming there isn't already a known solution)
This issue could be solved for me if there was a setting  to control which monitor inactive apps get moved to. If they moved to my main monitor instead of my laptop monitor I think the issue would be solved. On a side note, it seems weird that apps (even inactive ones) would get moved to a different macOS Space. Shouldn't they always stay in the same Space to keep things isolated?
Alternatively, there could be a settings to control which corner apps get moved to. It appears to always be the bottom-right. If it could be configured to be the bottom-left, then I think it would fix the issue for me.

+1. Happens with other apps as well, when in apple native fullscreen.

+1 same monitor setup and experienced same issue

+1


handleChange type doesn't work

Bug report
Current Behavior

no type error with
onChange(v: number)

Expected behavior
with this commented

we finally get type error

Reproducible example

Suggested solution(s)

https://github.com/formium/formik/blob/80f9a831797429ae3c4457a47b6d8391e9d8bd2c/packages/formik/src/types.tsx#L140-L145
modify preact-like typing
Additional context

Your environment

Software
Version(s)

Formik
2.2.6

React
17.0.1

TypeScript
4.0.5

Browser
Any

npm/Yarn
1.22.4

Operating System
Big Sur

You would have to pass onChange={handleChange("lengthMeterTo")} so it would automatically pass your value back to the field itself.
If that callback is typed with a string, that would be an issue. It should be any. You can accomplish this right now with
const [{ onChange }] = useField<number>("lengthMeterTo");

// this onChange knows it will be a number.
<YourInput onChange={onChange} />

What you're requesting for handleChange is actually impossible to completely type. Even though you suggest "kind of" typing it, it doesn't type it based off of Values and name, so it is an incomplete type. We're trying to figure out how to give full typing to values and all related callbacks based on name, and have had some success with #1334 #2655 but nothing to merge just yet. Our successful tries require bleeding edge TypeScript, which we're not going to depend on just yet. Probably targeted for v3.

You would have to pass onChange={handleChange("lengthMeterTo")} so it would automatically pass your value back to the field itself.
If that callback is typed with a string, that would be an issue. It should be any. You can accomplish this right now with
const [{ onChange }] = useField<number>("lengthMeterTo");

// this onChange knows it will be a number.
<YourInput onChange={onChange} />

What you're requesting for handleChange is actually impossible to completely type. Even though you suggest "kind of" typing it, it doesn't type it based off of Values and name, so it is an incomplete type. We're trying to figure out how to give full typing to values and all related callbacks based on name, and have had some success with #1334 #2655 but nothing to merge just yet. Our successful tries require bleeding edge TypeScript, which we're not going to depend on just yet. Probably targeted for v3.

Duplicate of #2084 at al

Duplicate of #2084 at al

Thanks for getting back to me, that solution work for me!

Thanks for getting back to me, that solution work for me!


.Net: Update MistralAI kernel syntax samples

Motivation and Context
Adding a new function calling sample
Description

Contribution Checklist

[ ] The code builds clean without any errors or warnings
[ ] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[ ] All unit tests pass, and I have added new tests where possible
[ ] I didn't break anyone :smile:

I'm not sure this is good way, in my opinion better will be unify samples due to many models has almost identical samples.

I'm not sure this is good way, in my opinion better would be unify samples due to many models has almost identical samples.

There is a separate workstream underway to do this. Depending on when that work completes and when these changes get merged to main these samples may become obsolete and will be removed.

@markwallace-microsoft okay, thanks for clarification


Add ASN test

The test is just enough to trigger exception Asn_core.Ambiguous_syntax.

nice, then we may want to adapt albatross.opam to run the test (by adding  ["dune" "runtest" "-p" name "-j" jobs] {with-test} to the build: stanza) :)

nice, then we may want to adapt albatross.opam to run the test (by adding  ["dune" "runtest" "-p" name "-j" jobs] {with-test} to the build: stanza) :)

thanks

thanks


update dependencies; reorganize gulp build

update module dependencies in generated package.json
remove redundent insert-css dependency (it is pulled in by bespoke-highlight already)
alphabetize imports in gulpfile.js
fix structure of autoprefixer config
add engine requirements to generated package.json
bump version of generator to 3.0.0
rename browserify error handler to browserifyPlumber to reflect purpose
drop unused done argument to clean tasks
run clean task at start of deploy
be explicit about pug pretty indentation
don't watch scripts inside theme folder (to simplify)
minor code style changes

All your propositions have been included some existing commits of #38 and new commits at the end. I just handled the version differently. See #38 discussion.

:+1:


Issue with a plural in 'ru' locale

Hi,
i have an issue with plural in ru locale, example:
Здесь {n,plural,=0{котов нет} =1{есть один кот} one{# кот} few{# кота} many{# котов} other{# кота}}!
if n = 101, should work 'one' and result must be a '101 кот', but work 'other' and result is '101 кота'
I check it on PHP Yii2 Framework, and it's work perfect for 'ru' locale
And i found some helpful links
(http://www.yiiframework.com/doc-2.0/guide-tutorial-i18n.html#plural)
(http://intl.rmcreative.ru/tables?locale=ru)
(http://www.unicode.org/cldr/charts/latest/supplemental/language_plural_rules.html#ru)
Can you help me please ?
P.S. I'm sorry for my awful english :(

It's likely that you need to load the ru locale data on the page, otherwise it will be falling back to English's pluralization rules where 101 will being other.


[1.x] website CI fails with 'module 'jinja2' has no attribute 'contextfilter''

Description
website CI fails with 'module 'jinja2' has no attribute 'contextfilter'':

Fixed.


make general fixes

Description

add appropriate links to pages in post preview component
update readme to include netlify deploy link and Qunzhi Zhou in contributions
other general fixes that are deemed necessary
include useEffect hooks to set scroll position to (0,0) on page load on multiple pages

Related Issue

resolves #53

Type of change

[x] New feature (enhancement)
[x] Bug fix
[x] Refactor
[ ] Breaking change
[x] Documentation

How Has This Been Tested?

[ ] Automated testing
[x] Manual testing

Checklist:

[x] Does a similar (open or closed) pull request not already exist?
[x] Is the pull request head repository a fork repository?
[x] Is the pull request compare branch a development branch?
[x] Does the code build without new warnings?
[x] Has testing been performed that proves changes are effective and work?
[ ] Has a self- and/or peer-review of the code been performed?
[x] Is the person responsible for the repository assigned to the pull request?
[x] Is the pull request linked to a project?
[x] Is the pull request linked to a milestone?

For more information, refer to the Contributing Guidelines and Code of Conduct links at the bottom of this page.

Hi, love the changes!
Perhaps one potential UI fix would be on the post preview components, where I've noticed that a link icon? has been appearing on the right side of the title. Perhaps this should be removed following the ui prototype design? Final decision is up to you.

Hi, love the changes!
Perhaps one potential UI fix would be on the post preview components, where I've noticed that a link icon? has been appearing on the right side of the title. Perhaps this should be removed following the ui prototype design? Final decision is up to you.

Yup that's because the title is now also a link to the particular post (based on its ID) so i felt like it needed a call to action for people to realise they can click on it

Looks all good now, but just one potential ui issue at the bottom of the communities page, i think we can add . padding-bottom:20px for the class com-bodyContainer in the communities.css.

Hi, love the changes!
Perhaps one potential UI fix would be on the post preview components, where I've noticed that a link icon? has been appearing on the right side of the title. Perhaps this should be removed following the ui prototype design? Final decision is up to you.

Yup that's because the title is now also a link to the particular post (based on its ID) so i felt like it needed a call to action for people to realise they can click on it

Right! That's algood then. Thanks!

Looking good, thanks for all the hard work! Just following on from Xiaoqi's comment, since we added padding to the communities page, did we also want to pad the bottom of the home and posts page?

Lets make this an issue for the next team :P


Can the Arduino code be changed over the air?

Hi!
My D1 Mini is on a hard to reach spot, can it be accessed over the air?
I have to make changes on two devices, one I have to clear the credencials as the car will be sold and the other a have to change the node name. Can it be done over the air?
Thanks!

Kinda yes but probably no.  If you compiled the code yourself and set the otaPassword, then yes you can use the arduino Over-The-Air flash update mechanism to flash the device.  If you didn't set this value at compile time, you'll need physical access to the device.

Thanks a lot!


Docs for iot-data publish() method are incorrect

Describe the bug
The documentation for iot-data publish() method says:

The message body. MQTT accepts text, binary, and empty (null) message payloads.

Which is correct (emphasis mine), however, the parameter types listed in the docs are:
payload=b'bytes'|file
Which is incorrect, publish() does accept text. Libraries like boto3-stubs use these docs to generate type stubs, which in this case causes mypy to indicate a type error on this code:
mqtt.publish(
    topic=topic,
    qos=1,
    payload=json.dumps(payload)  # Argument "payload" to "publish" of "IoTDataPlaneClient" has incompatible type "str"; expected "Union[bytes, IO[bytes], StreamingBody]"  [arg-type]
)

Honestly, I have no idea where this should be reported since the botocore methods and docs are all generated from JSON files that come from elsewhere, but this seems like a good place to start.

Hi @joshfriend,
Thanks for your comment. The reason it shows as b'bytes'|file is because the API model shape for this property is a blob:
https://github.com/boto/botocore/blob/10a6b17198c6765828a2d5ce8f924f2e22338164/botocore/data/iot-data/2015-05-28/service-2.json#L380

It's been left for backwards compatibility but isn't strictly "intended".

Thanks for the explanation! I'm going to close this and just make sure I encode to bytes to avoid mypy errors since I get the sense that this could change in the future 😄


Update buildkit image tag to fix CVEs

Reference
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


将公共代码抽成单独方法

Codecov Report

Merging #138 (685ee81) into main (c9b0f1a) will decrease coverage by 1.09%.
The diff coverage is 85.18%.

@@             Coverage Diff              @@
##               main     #138      +/-   ##
============================================
- Coverage     65.71%   64.62%   -1.10%
+ Complexity     8549     8420     -129
============================================
  Files           421      421
  Lines         47011    46859     -152
  Branches       9578     9533      -45
============================================
- Hits          30894    30281     -613
- Misses        12433    12937     +504
+ Partials       3684     3641      -43

Impacted Files
Coverage Δ

...ibaba/fastjson2/writer/ObjectWriterBaseModule.java
83.83% <85.18%> (+2.46%)
:arrow_up:

...n/java/com/alibaba/fastjson2/util/UnsafeUtils.java
30.18% <0.00%> (-49.06%)
:arrow_down:

...main/java/com/alibaba/fastjson2/util/JDKUtils.java
40.25% <0.00%> (-30.07%)
:arrow_down:

...va/com/alibaba/fastjson2/reader/ValueConsumer.java
16.66% <0.00%> (-16.67%)
:arrow_down:

...in/java/com/alibaba/fastjson2/JSONReaderASCII.java
66.74% <0.00%> (-14.76%)
:arrow_down:

...in/java/com/alibaba/fastjson2/JSONWriterUTF16.java
66.78% <0.00%> (-10.61%)
:arrow_down:

...java/com/alibaba/fastjson2/JSONWriterUTF8JDK9.java
73.41% <0.00%> (-8.87%)
:arrow_down:

...in/java/com/alibaba/fastjson2/JSONWriterJSONB.java
52.04% <0.00%> (-6.23%)
:arrow_down:

.../main/java/com/alibaba/fastjson2/util/IOUtils.java
55.06% <0.00%> (-5.07%)
:arrow_down:

...baba/fastjson2/reader/FieldReaderObjectMethod.java
74.41% <0.00%> (-4.66%)
:arrow_down:

... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9b0f1a...685ee81. Read the comment docs.


Minor Clarification Update to Profile Service Docs

Updated profile service docs.
Misleading, as going by the code, access tokens doesn't actually get their claims via Identity Resources. It only gets them via API Resources.
Vice versa as well. Identity tokens doesn't actually get their claims via API Resources. It only gets them via Identity Resources.
At this point we cannot accept PRs for new features, only bugfixes. Thanks!
What issue does this PR address?
Misleading documentation.
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements

[x] The commit follows our guidelines
[ ] ~Unit Tests for the changes have been added (for bug fixes / features)~ N/A

Other information:

thanks!


Use Phosphor layouts

This makes flexx.ui be based on Phosphor, so we can take advantage of the great layout and future widgets. Also fixes several other things on the way.

Hurray!
El oct. 1, 2015 10:28 AM, "Almar Klein"<EMAIL_ADDRESS>escribió:

Merged #37 https://github.com/zoofIO/flexx/pull/37.
—
Reply to this email directly or view it on GitHub
https://github.com/zoofIO/flexx/pull/37#event-424215942.


x/tools/gopls: completion doesn't work correctly in some conditions

gopls version
v0.14.2
go env
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\worlpaker\AppData\Local\go-build
set GOENV=C:\Users\worlpaker\AppData\Roaming\go\env
set GOEXE=.exe
set GOEXPERIMENT=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=C:\Users\worlpaker\go\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\worlpaker\go
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=C:\Program Files\Go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLCHAIN=auto
set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=go1.21.6
set GCCGO=gccgo
set GOAMD64=v1
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=NUL
set GOWORK=
set CGO_CFLAGS=-O2 -g
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-O2 -g
set CGO_FFLAGS=-O2 -g
set CGO_LDFLAGS=-O2 -g
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=C:\Users\worlpaker\AppData\Local\Temp\go-build2689359370=/tmp/go-build -gno-record-gcc-switches

What did you do?
Completion doesn't work correctly in some conditions.
variable completion after comma:
package main

func main(){
	minimum, maximum := 0, 0
	minimum, max
}

Demonstration
https://github.com/golang/go/assets/34960716/367e50c3-0a45-48e4-9839-3a2c4bccd588
What did you see happen?
The completion of max became maxmaximum.
What did you expect to see?
The completion for max should be maximum.
Editor and settings
No response
Logs
No response

Thank you. This looks like a duplicate of #58833, right?
Thanks for digging into this and working on a fix! As commented on the CL, it would be helpful to explain a theory of how to handle syntax errors.

Yes, it is. Although the first scenario (max<>) logically doesn't have any syntax errors.

Thanks. For what it's worth, the first scenario does have syntax errors (e.g. https://go.dev/play/p/lVxgY6Dczjf notes a syntax error).

I will take a look at the fix. We can keep this issue open since the other issue is about go/parser.


Mouse interaction abstractions

Abstractions to support mouse interaction. Basically you tag Diagrams with the actions that should be emitted when they are clicked, or mouse(enter/leave/move)'d.

TODO: re-export stuff from a prelude module? Grr

TODO: put all docs where they belong

BUG: doesn't draw anything until first window size or mouse event comes in. Need to reorganize sig graph to solve this one.


Make user creation optional

Lots of accounts restrict creating IAM users. We should make the user optional either via a CreateUser=True/False parameter or if the password is blank skip user creation.

See #9

Resolved in https://github.com/aws-samples/no-tears-cluster/pull/9


scene picking precision with huge values in world matrices

Reported by @sebavan
with (really) high values in mesh world matrix, picking doesn't work.
https://playground.babylonjs.com/#KNE0O#1171
This is caused by float precisions. In this method:
https://github.com/BabylonJS/Babylon.js/blob/cc9d16b2b2867bd783f0d20d6cfac17e55e17e6e/src/Culling/ray.ts#L560
world matrix is multiplied by view and projection, then inverted. Matrix is using float and precision loss makes it impossible to pick mesh later in the code.
To improve precision, view ray is computed then transformed back into the mesh coordinates system. It's not bullet proof. With even higher values, picking will have 'holes' in resolution.

Sounds like this might impact perfs quite substantially, let me check if there are other ways around in the customer code.

Should it also modify the intersectsMesh to not do it twice ? in case of distant ray enable ?

Nop: https://github.com/BabylonJS/Babylon.js/blob/cc9d16b2b2867bd783f0d20d6cfac17e55e17e6e/src/Culling/ray.ts#L800
There is a predicate per mesh that update the ray, then, the returned ray is computed with identity matrix
https://github.com/BabylonJS/Babylon.js/blob/cc9d16b2b2867bd783f0d20d6cfac17e55e17e6e/src/Culling/ray.ts#L837


Make sure warden is capable to verify init-/side-cart containers added to pods after initial admission.

Description
It looks like our current implementation of warden admission webhook is not capable to intercept and verify image authenticity in case an init container is added to the workload by an external tool (i.e dynatrace instrumentation).
AC

[ ] if an init container is added to a running workload in protected namespace, it is inspected by warden and allowed or blocked if it's not authentic or explicitly allowed

Testing strategy
Add automated test proving that if an init container is added to a running workload in protected namespace, it is inspected by warden and allowed or blocked if it's not authentic or explicitly allowed
Reason
We need to support this case as all images (incl. initcontainers) may include hostile code and should not be admitted in case are not proved to be authentic or explicitly allowed.
Troubleshooting

A workload could be a subject to multiple webhooks, i.e istio, dynatrace, warden.
We should investigate if we could enforce our warden webhook  to be executed as the last one.


Updated recommendation to install Az.Accounts in accordance with issue 397.

Updated recommendation to install Az.Accounts in accordance with issue 397.

Awesome. Thanks!


CAN'T UPLOD *.CSV FILES

I need upload CSV files via php script but it is not possible.
I tryed by using the getStarted.php example , simply changing the file to upload, but the script permits to upload PNG images files only.
Is there any setting to make it possible ?
Thanks

I discovered the problem : the filenamo of CSV that I tryed to upload contained the underscore (_) character.
By removing it, it worked  !!


Job submission dialog should clear error message

@alesgenova This is another one that should be pretty easy to fix up.


chore: reduce duplication in simp tactic syntaxes

See https://github.com/leanprover-community/mathlib4/pull/236#issuecomment-1071914406

bors r+


Self-Managed Node Groups Not Joining EKS Cluster (CoreDNS 'DEGRADE' Error)

Description
Iam attempting to create a self managed node groups to launch EC2 instances using Amazon Linux 2023 EKS optimized AMI. However. I am encountering an issue where the node groups are not joining the cluster, which is resulting in a 'DEGRADE' error for CoreDNS.
When I use the same Terraform code and eks module to create an EKS cluster with managed node groups, it works perfectly, with no issues related to node joining or CoreDNS.
This appears to be a bug. Is there a workaround to resolve this problem by modifying the Terraform code? Any suggestions or advice would be greatly appreciated.
Error: waiting for EKS Add-On (ecp-ppp-prod:coredns) create: timeout while waiting for state to become 'ACTIVE' (last state: 'DEGRADED', timeout: 20m0s)
│
│   with module.eks.aws_eks_addon.this["coredns"],
│   on .terraform/modules/eks/main.tf line 498, in resource "aws_eks_addon" "this":
│  498: resource "aws_eks_addon" "this" {
│
Here is the Terraform modules and Reproduction Code
module "eks" {
  source  = "terraform-aws-modules/eks/aws"
  version = "~> 20.13"

  cluster_name                   = local.name
  cluster_version                = local.cluster_version

  vpc_id     = module.vpc.vpc_id
  subnet_ids = module.vpc.private_subnets
  control_plane_subnet_ids = module.vpc.intra_subnets

  cluster_endpoint_private_access = true
  cluster_endpoint_public_access  = true

  enable_irsa = true

  enable_cluster_creator_admin_permissions = true

  # This will set the cluster authentication use API and CONFIG MAP, EKS will automatically create an access entry for the IAM role(s) used by managed nodegroup(s)
  authentication_mode = "API_AND_CONFIG_MAP"

  # EKS Addons
  cluster_addons = {
    coredns    = {
      most_recent = true
    }

    eks-pod-identity-agent = {
      most_recent = true
    }

    kube-proxy = {
      most_recent = true
    }
    vpc-cni = {
      # Specify the VPC CNI addon should be deployed before compute to ensure
      # the addon is configured before data plane compute resources are created
      # See README for further details
      before_compute = true
      most_recent    = true # To ensure access to the latest settings provided
      configuration_values = jsonencode({
        env = {
          # Reference docs https://docs.aws.amazon.com/eks/latest/userguide/cni-increase-ip-addresses.html
          ENABLE_PREFIX_DELEGATION = "true"
          WARM_PREFIX_TARGET       = "1"
        }
      })
    }
  }

  self_managed_node_groups = {
    # AL2023 node group utilizing new user data format which utilizes nodeadm
    # to join nodes to the cluster (instead of /etc/eks/bootstrap.sh)
    al2023_nodeadm = {

      name = "cis-self-mng"
      use_name_prefix = true
      launch_template_description     = "Self managed node group example launch template"

      # ebs_optimized     = true
      enable_monitoring = true

      subnet_ids = module.vpc.public_subnets

      min_size         = 1
      max_size         = 3
      desired_capacity = 1

      instance_type = "m6i.large"

      enable_bootstrap_user_data = true
      is_eks_managed_node_group = false

      ami_id = data.aws_ami.image_cis_eks.id

      launch_template_name            = "amazon-eks-al2023-node-1.30"
      launch_template_use_name_prefix = true
      launch_template_description     = "amazon-eks-al2023-node-1.30"

      // The following variables are necessary if you decide to use the module outside of the parent EKS module context.
      // Without it, the security groups of the nodes are empty and thus won't join the cluster.
      vpc_security_group_ids = [
        module.eks.cluster_primary_security_group_id,
        module.eks.cluster_security_group_id,
      ]

      # AL2023 node group utilizing new user data format which utilizes nodeadm
      # to join nodes to the cluster (instead of /etc/eks/bootstrap.sh)
      cloudinit_pre_nodeadm = [
        {
          content_type = "application/node.eks.aws"
          content      = <<-EOT
            ---
            apiVersion: node.eks.aws/v1alpha1
            kind: NodeConfig
            spec:
              featureGates:
                InstanceIdNodeName: true
              cluster: ecp-ppp-prod
              apiServerEndpoint: https://xxxx.us-east-1.eks.amazonaws.com
              certificateAuthority: xxxxx
              cidr: 1xx.xx.0.0/16
              kubelet:
                config:
                  shutdownGracePeriod: 30s
                  featureGates:
                    DisableKubeletCloudCredentialProviders: true
              config: |
              [plugins."io.containerd.grpc.v1.cri".containerd]
              discard_unpacked_layers = false
          EOT
        }
      ]
    }
  }

  tags = local.tags
}

And i even tried with self managed module however getting the same issue.
module "self_managed_node_group" {
  source = "terraform-aws-modules/eks/aws//modules/self-managed-node-group"
  version = "20.13.1"

  name                = "cis-self-mng"
  cluster_name        = "xxx-ppp-prod"
  cluster_version     = "1.30"
  cluster_endpoint    = "https://xxx.gr7.us-east-1.eks.amazonaws.com"
  cluster_auth_base64 = "xxx"
  cluster_ip_family    = "ipv4"
  cluster_service_cidr = "xx.xx.0.10"

  subnet_ids = module.vpc.private_subnets

  ami_id   = data.aws_ami.image_cis_eks.id

  user_data_template_path = "${path.module}/modules/user_data/templates/al2023_custom.tpl"

  cloudinit_pre_nodeadm = [{
    content      = <<-EOT
      ---
      apiVersion: node.eks.aws/v1alpha1
      kind: NodeConfig
      spec:
        kubelet:
          config:
            shutdownGracePeriod: 30s
            featureGates:
              DisableKubeletCloudCredentialProviders: true
    EOT
    content_type = "application/node.eks.aws"
  }]

  cloudinit_post_nodeadm = [{
    content      = <<-EOT
      echo "All done"
    EOT
    content_type = "text/x-shellscript; charset=\"us-ascii\""
  }]

  // The following variables are necessary if you decide to use the module outside of the parent EKS module context.
  // Without it, the security groups of the nodes are empty and thus won't join the cluster.
  vpc_security_group_ids = [
    module.eks.cluster_primary_security_group_id,
    module.eks.cluster_security_group_id,
  ]

  min_size     = 1
  max_size     = 4
  desired_size = 1

  launch_template_name   = "cis-self-mng"
  instance_type          = "m5.2xlarge"

  tags = {
    Environment = "xxx-ppp-prod"
    Terraform   = "true"
  }
}

This is my VPC supporting TF module
################################################################################
# VPC supportings
################################################################################

module "vpc" {
  source  = "terraform-aws-modules/vpc/aws"
  version = "~> 5.0.0"

  name = local.name
  cidr = local.vpc_cidr

  azs             = ["us-east-1a", "us-east-1b", "us-east-1c"]
  private_subnets = ["10.xx.xx.0/24", "10.xx.xx.0/24", "10.xx.xx.0/24"]
  public_subnets  = ["10.xx.16.xx/26", "10.xx.xx.128/26", "10.xx.xx.1xx/26"]

  enable_nat_gateway     = true
  create_igw             = true

  single_nat_gateway     = false
  one_nat_gateway_per_az = false

  enable_dns_hostnames   = true
  enable_dns_support     = true

  enable_flow_log                      = true
  create_flow_log_cloudwatch_iam_role  = true
  create_flow_log_cloudwatch_log_group = true

  public_subnet_tags = {
    "kubernetes.io/role/elb"                        = 1
    "kubernetes.io/cluster/${var.environment_name}" = "owned"
  }

  private_subnet_tags = {
    "kubernetes.io/role/internal-elb" = 1
    # Tags subnets for Karpenter auto-discovery
    # "karpenter.sh/discovery" = local.name

    "kubernetes.io/cluster/${var.environment_name}" = "owned"

  }

  tags = local.tags

}

Module version [Required]:

Terraform version:
< terraform {
required_version = ">= 1.3"
} >

Provider version(s):
<Execute: terraform providers -version
required_providers {
aws = {
source  = "hashicorp/aws"
version = ">= 5.52"
}>

Terminal Output Screenshot(s)

Additional context

This appears to be a bug

I would disagree and state this is a user configuration error

I would disagree and state this is a user configuration error

@bryantbiggs - I understand your perspective. Could you please provide more details on what specific configuration errors you believe might be causing this issue? I have reviewed all the VPC and EKS cluster network configurations, but any further suggestions or insights would be greatly appreciated.

I was running into this over the past few days trying bottlerocket nodes via self-managed-node-groups. It feels like platform is already deprecated. You need to specify ami_type the way the logic is written (also here and here) in the self-managed-node-group module - it will always pick AL2_x86_64 by default if not explicitly set - unless I'm misinterpreting this.
TLDR;
try setting ami_type to AL2023_x86_64_STANDARD in your node group map

I would disagree and state this is a user configuration error

The default example from official documentation does not create a working EKS cluster, so agree or disagree, in order to provide a working module documentation must be updated regardless

I'm sorry, what?

I'm sorry, what?

Don't be, try to use module's documentation  as is and you won't achieve creating of a working EKS cluster

I am also encountering an error and would like to resolve it using the TF EKS module. Could you please advise if there are any specific input values I need to add explicitly to fix it?

I mean, thats just an example how how you could use the module - it has made up values so it won't work if you try to deploy it as is.

This is obvious, I did create VPC and subnets
vpc.tf
resource "aws_vpc" "my_vpc" {
  cidr_block = "<IP_ADDRESS>/16"

  tags = {
    Name = "study-vpc"
  }
}

resource "aws_subnet" "my_subnet_1" {
  availability_zone = "us-east-1a"
  vpc_id            = aws_vpc.my_vpc.id
  cidr_block        = "<IP_ADDRESS>/24"

  tags = {
    Name = "study-subnet-1"
  }
}

resource "aws_subnet" "my_subnet_2" {
  availability_zone = "us-east-1b"
  vpc_id            = aws_vpc.my_vpc.id
  cidr_block        = "<IP_ADDRESS>/24"

  tags = {
    Name = "study-subnet-2"
  }
}

cluster.tf
module "eks" {
  source  = "terraform-aws-modules/eks/aws"
  version = "20.13.1"

  cluster_name    = "study-cluster"
  cluster_version = "1.29"

  authentication_mode = "API"

  cluster_endpoint_public_access = true

  cluster_addons = {
    coredns = {
      most_recent = true
    }
    kube-proxy = {
      most_recent = true
    }
    vpc-cni = {
      most_recent = true
    }
  }

  vpc_id     = aws_vpc.my_vpc.id
#   control_plane_subnet_ids = [aws_subnet.my_subnet_1.id, aws_subnet.my_subnet_2.id]
  subnet_ids = [aws_subnet.my_subnet_1.id, aws_subnet.my_subnet_2.id]

  # EKS Managed Node Group(s)
  eks_managed_node_groups = {
    small = {
      subnet_ids = [aws_subnet.my_subnet_1.id, aws_subnet.my_subnet_2.id]
      min_size     = 1
      max_size     = 1
      desired_size = 1

      instance_types = ["t3.small"]
      capacity_type  = "SPOT"
    }
  }

  # Cluster access entry
  # To add the current caller identity as an administrator
  enable_cluster_creator_admin_permissions = true
}

node is failing to join the cluster
I don't believe that module has a value if I have to investigate why even basic example doesn't work

@bryantbiggs I believe if you were to create a cluster with just self-managed-node-groups using non AL2 AMIs you would be able to recreate the main issue of this thread..  I don't believe eks_managed_node_groups would have the same issue, but I haven't tried personally because ami_type is properly null'd. Basically when no nodes join the cluster the TF apply gets stuck when deploying the marketplace-addons because they never get healthy.
see my comment above for more details
If you wanted to recreate the issue that I was facing you could use our example root module here (from this specific sha) - we've since fixed this by specifying ami_type      = "BOTTLEROCKET_x86_64" in our self managed node group settings.
replication -
note: you might want to set cluster_endpoint_public_access = true in fixtures.secure.tfvars to poke around
tofu init
tofu apply --var-file fixtures.common.tfvars --var-file fixtures.secure.tfvars --auto-approve

anyway sorry guys I missed that the topic was about self-managed node group, I was trying to create aws-managed node group
just I think bad documentation is a common issue for this specific module
other Anton's modules I did use worked as a charm and have awesome docs

@mossad-zika that is not suitable VPC
In terms of self-managed node group with AL2023, it does work https://github.com/clowdhaus/eks-reference-architecture/blob/main/self-managed-node-group/eks_default.tf
Just validated it myself

@mossad-zika that is not suitable VPC
In terms of self-managed node group with AL2023, it does work<EMAIL_ADDRESS>Just validated it myself

Right, you're using ami_type = "AL2023_x86_64_STANDARD" - if you tried without setting ami_type and used platform instead, I think you'd run into this issue where your nodes wouldn't join the cluster.
It seems like ami_type is already required, whereas in most of the code (comments) it reads like platform should still work

From the PR
https://github.com/terraform-aws-modules/terraform-aws-eks/pull/3030#issue-2284014736

The platform functionality is still preserved for backwards compatibility until its removed in the next major version release

I don't believe this to be the case, because ami_type always wins, and ami_type defaults to Amazon Linux 2 due to default vars. We just ran into this using bottlerocket nodes and only specifying platform

I feel like we are mixing issues now - in terms of self-managed node groups joining the cluster, I think I have proven that works
In terms of platform and backwards compatibility - that seems like a separate issue

and in terms of platform - I am less inclined to try to do anything to fix that (unless theres a really, really strong case to do so - if there is anything that can be done) because with the number of different OS offerings now, its going to fail at least half of the time
For example - try to launch arm based instances with it ... you can't. Adding support for AL2023 sort of forced my hand in terms of needing to use something else, and we already have the ami_type on EKS managed node groups so why not make that consistent - after all, those will be the various AMI types that we should support here either way

Right, yeah I guess my thing was this release had some breaking changes specifically to self-managed-node-groups in via variable defaults that just took a bit to figure out because suddenly our nodes weren't joining the cluster when we bumped this module version.

imo, just depends on how close you guys are to releasing v21, otherwise I'd add a note that ami_type is required, remove the default in the variable declaration, etc.

just depends on how close you guys are to releasing v21,

trying to hold major versions here for a year (is the goal)
I'll take a look this evening and see if there is anything obvious we could do in the interim

imo, just depends on how close you guys are to releasing v21, otherwise I'd add a note that ami_type is required, remove the default in the variable declaration, etc.

Just ran into this and debugged it the hard way.  An error if ami_type isn't specified would help.  Wasn't expecting it to default to AL2 even though I had set platform to al2023

This issue has been resolved in version 20.14.0 :tada:

If the use case involves selecting ami_type='CUSTOM' to create a self-managed node group using the custom CIS Amazon Linux 2023 Benchmark-Level AMI optimized for EKS, does the deployment support using a launch template with a custom AMI for the node group?
for example:
module "eks_default" {
source  = "terraform-aws-modules/eks/aws"
version = "~> 20.0"
cluster_name    = "${local.name}-default"
cluster_version = "1.30"
  enable_cluster_creator_admin_permissions = true
  cluster_endpoint_public_access           = true

  # EKS Addons
  cluster_addons = {
    coredns    = {}
    kube-proxy = {}
    vpc-cni    = {}
  }

  vpc_id     = module.vpc.vpc_id
  subnet_ids = module.vpc.private_subnets

  self_managed_node_groups = {
    default = {
      instance_type = "m5.large"

      ami_type = "CUSTOM"
      ami_id = data.aws_ami.image_cis_eks.id

      min_size     = 2
      max_size     = 3
      desired_size = 2
    }
  }

  tags = module.tags.tags
}

ami-id.tf
# Setup data source to get amazon-provided AMI for EKS nodes
data "aws_ami" "image_cis_eks" {
  most_recent = true
  owners      = ["0xxxxx"]

  filter {
    name   = "name"
    values = ["amazon-eks-al2023-node-1.30-v20240607"]
  }
}
output "eks_ami_id" {
  value = "${data.aws_ami.image_cis_eks.id}"
}

Just for the reference, here is the CIS Benchmark AMI details.

you can use a custom AMI, yes - but your AMI data source seems to be configured to look for the EKS AL2023 AMI. I think you want to configure that to use the CIS AMI
I also am not familiar with the CIS AMI, but you'll need to investigate how that AMI wants/needs the user data to be configured in order for nodes to join the cluster


Move *-nvidia image build workflow into main repo

Now that nvidia has removed the building of the nvidia kmod in favor of a build from akmods, we can easily migrate the building of *-nvidia images into this repo as a job that runs after successful *-main builds.

This is going to be so cool, the efficiency benefits on real builders will be awesome!

This is great idea. I'll work on this first thing tomorrow


Security vulnerability in build process

Hi there,
For a couple of weeks, Github has been giving me the following warning relating to the use of the Imageset plugin 1.1.0-beta2 on my Kirby build (now updated to 2.5.11).

I was hoping you'd have fixed this but maybe you didn't see; perhaps now it's right I draw your attention to it. I really need Imageset in my forthcoming build; all of my image work relies on it, and this issue is beyond my skillset.
Thanks,
Simon Collison

Hi @colly,
I ran a quick npm audit within the repo to investigate this. As far as I can tell (node_modules/ is said to contain more modules than there are particles in the whole universe) this is a dependency used by node-sass in the build process and nothing that is nothing that should affect the actual frontend code. From a security point of view, it should be safe to use ImageSet. However, I’ll update the dependencies with the next release.
Cheers,
Fabian

Great. Thanks for the clarity, and for continued maintenance of the plugin.


Undeterministic results when encoding multi-threaded on a Mac

When running the encoder multi-threaded on a Mac, each run will produce slightly different results.
The issue cannot be reproduced on a Linux or Windows.

Seems theres no problem after all


--forbid-only now handle an empty suite marked only

Description of the Change
As #2944 , --forbid-only didn't catch an empty suite that marked as only because checking forbidOnly is happened in runTest.
So, I added forbidOnly check in runSuite when there is no greped tests and there are _onlySuites. To run forbidOnly check in runTest, I made new empty test here.
Alternate Designs
Not delegate runTest for forbidOnly,  throw forbid error in runSuite?
Why should this be in core?
If there is an empty suite that marked only, tests will be passed with --forbid-only option.
Possible Drawbacks
If I added an empty test with no title, there is no test name in output. It looks a little bit weired. Any idea?
  nothing
    1)

  0 passing (3ms)
  1 failing

  1) nothing
       :
     Error: `.only` forbidden
      at Runner.runTest (lib/runner.js:436:8)
      at /Users/outsider/Dropbox/projects/github/mocha/lib/runner.js:568:12
      at next (lib/runner.js:364:14)
      at /Users/outsider/Dropbox/projects/github/mocha/lib/runner.js:374:7
      at next (lib/runner.js:298:14)
      at Immediate._onImmediate (lib/runner.js:342:5)

Applicable issues
close #2944

Coverage increased (+0.1%) to 90.617% when pulling 3a52260e9c32f77ddeb11ce1fdfdaeea90091b24 on outsideris:issue-2944 into ee2ef44ba57ae021e1115ef61ffeb230fb6b3065 on mochajs:master.

If there is an empty suite that marked only, tests will be passed with --forbid-only option.

Don't follow you. If the suite is empty, then there are no tests to run -- therefore, none will pass or fail.

See additional comments in #2944.

@outsideris please see this implementation and tell me what you think:
https://github.com/boneskull/mocha/commit/8a929c54f9d964fcc97e503ae4b43e1ba81cd55f
(if you push your branches to mochajs/mocha instead of your fork, we can collaborate easily)

I also feel my approach is good. I will check your implement.

my implementation will fail as soon as the suite.only is encountered, before running any tests.  it doesn't make sense to me to continue processing suites if we know we will fail.

I applied @boneskull 's implementation. Fast-fail is good.
Also, I add code to throw an empty suite marked .skip with --forbid-pending like --forbid-only.  As https://github.com/mochajs/mocha/issues/2944#issuecomment-441851621 , --forbid-pending has same bug.
For clearify, output is different between .only/.skip at suites and test cases.
.only/.skip at suites
describe.only("Suite", function() {
  it("should be tested", function() { })
});

$ mocha --forbid-only example.js
/Users/outsider/Dropbox/projects/github/mocha/lib/interfaces/common.js:128
            throw new Error('`.only` forbidden');
            ^

Error: `.only` forbidden
    at Object.create (/Users/outsider/Dropbox/projects/github/mocha/lib/interfaces/common.js:128:19)
    at Object.only (/Users/outsider/Dropbox/projects/github/mocha/lib/interfaces/common.js:95:21)
    at Function.context.describe.only (/Users/outsider/Dropbox/projects/github/mocha/lib/interfaces/bdd.js:67:27)
    at Object.<anonymous> (/Users/outsider/Dropbox/projects/github/mocha/example.js:1:72)
    at Module._compile (internal/modules/cjs/loader.js:688:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:699:10)
    at Module.load (internal/modules/cjs/loader.js:598:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:537:12)
    at Function.Module._load (internal/modules/cjs/loader.js:529:3)
    at Module.require (internal/modules/cjs/loader.js:636:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at /Users/outsider/Dropbox/projects/github/mocha/lib/mocha.js:287:27
    at Array.forEach (<anonymous>)
    at Mocha.loadFiles (/Users/outsider/Dropbox/projects/github/mocha/lib/mocha.js:284:14)
    at Mocha.run (/Users/outsider/Dropbox/projects/github/mocha/lib/mocha.js:718:10)
    at Object.<anonymous> (/Users/outsider/Dropbox/projects/github/mocha/bin/_mocha:642:18)
    at Module._compile (internal/modules/cjs/loader.js:688:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:699:10)
    at Module.load (internal/modules/cjs/loader.js:598:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:537:12)
    at Function.Module._load (internal/modules/cjs/loader.js:529:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:741:12)
    at startup (internal/bootstrap/node.js:285:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:739:3)

.only/.skip at test cases
describe("Suite", function() {
  it.only("should be tested", function() { })
});

$ mocha --forbid-only example.js

  Suite
    1) should be tested

  0 passing (2ms)
  1 failing

  1) Suite
       should be tested:
     Error: `.only` forbidden
      at Runner.runTest (lib/runner.js:436:8)
      at /Users/outsider/Dropbox/projects/github/mocha/lib/runner.js:568:12
      at next (lib/runner.js:364:14)
      at /Users/outsider/Dropbox/projects/github/mocha/lib/runner.js:374:7
      at next (lib/runner.js:295:14)
      at Immediate._onImmediate (lib/runner.js:342:5)

awesome.

@outsideris 	you  may want to move the require('chai') in test/reporters/base.spec.js to the top of the file.  that might address the timeout.

I moved require('chai') to the top of the file.
For history, it was discussed in #3527 .

@plroebuck are you still opposed to this idea?


Be able to import subscriptions/publishers dynamically

Thinking about multiple development teams. It'd be interesting if each team provide a fake response (subscriptions) of its services. Doing like this, a team that consumes information from that service wouldn't have to change their tests, as long as their tests can import these fake subscriptions dynamically.
The solution I can think of is to do the same that a requisition currently does. Extend this feature for publishers and subscriptions as well.

:tada: This issue has been resolved in version 4.6.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Minor tweaks for CI tests

No wait is required if we're waiting for job to complete
Added a small wait for 5 seconds after deploying operator
Cleaning up benchmark-operator before deleting cb operator

@dustinblack PTAL

Small comment, but it's not exactly related to this commit. Otherwise LGTM.

Closing this and will work on a new PR since #69 got merged


No video formats found

Checklist

[x] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2020.11.26
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--username', 'PRIVATE', '--password', 'PRIVATE', '--sleep-interval', '250', 'https://app.pluralsight.com/library/courses/angular-nodejs-restful-services/table-of-contents', '--verbose']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2020.11.26
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.19041
[debug] exe versions: none
[debug] Proxy map: {}
[pluralsight:course] angular-nodejs-restful-services: Downloading JSON metadata
[download] Downloading playlist: Integrating Angular with Node.js RESTful Services
[pluralsight:course] playlist Integrating Angular with Node.js RESTful Services: Collected 52 video ids (downloading 52 of them)
[download] Downloading video 1 of 52
[pluralsight] Downloading login page
[pluralsight] Logging in
[pluralsight] angular-nodejs-restful-services-m0-0: Downloading JSON metadata
[pluralsight] angular-nodejs-restful-services-m0-0: Downloading mp4-high-widescreen viewclip graphql
[pluralsight] angular-nodejs-restful-services-m0-0: Downloading mp4-high-widescreen viewclip JSON
WARNING: Unable to download JSON metadata: HTTP Error 403: Forbidden
[pluralsight] angular-nodejs-restful-services-m0-0: Waiting for 3 seconds to avoid throttling
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp8xa81xl2\build\youtube_dl\YoutubeDL.py", line 803, in wrapper
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp8xa81xl2\build\youtube_dl\YoutubeDL.py", line 824, in __extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp8xa81xl2\build\youtube_dl\extractor\common.py", line 532, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp8xa81xl2\build\youtube_dl\extractor\pluralsight.py", line 421, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp8xa81xl2\build\youtube_dl\extractor\common.py", line 1359, in _sort_formats
youtube_dl.utils.ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Description

Getting error from pluralsight - No video formats found

do you have the solution link from original issue? pls share. I got this error from latest version too.


Edited incorrect or unnecessary details out of readme

When I initially wrote this I did so mainly because it needed to be done and with my understanding on the process at the time, I made a few assumptions either from the perspective of "it worked for me so I must include this." or if it works in the official branch of Fast64 it would work here.
In this PR I cut out incorrect or unnecessary details.

For specific context, I mentioned the use of Large Texture mode for textures bigger then 32x32, which in fact does not work.
I mentioned materials requiring Segment C, which is not at all always the case as I implied beforehand.
And I mentioned needing the microcode to be F3DEX2/LX2, to clarify I put that in because it is what the official fast64 documentation mentions to use, however after many mods I find this to be more detrimental then anything and the default microcode works much better in SoH(textures may not follow the UVs incorrectly with the F3DEX2/LX2 microcode .


Some kind of spam error and camera shake

Maybe it has something to do with BodyCam
The assembly code is 018d4517-b96d-5245-3458-0ea2642a0b4e

https://github.com/cmooref17/Lethal-Company-TooManyEmotes/assets/72872478/8064e25d-0772-415a-aa38-b2497c75212c

Even after death, the same thing

I restarted the game at the same time - where was this error, the shaking continued at startup

After disabling BodyCam, everything became fine. Apologize...


Update FCS to v.8 and all the packages as well

Fantomas must be updated to use FCS 8 as well, so it should not be merged until https://github.com/dungpa/fantomas/issues/203 is closed and Fantomas version referenced in this PR updated, too.

I updated Fantomas, formatting works in tests and reality.
FSharpLint does not work neither in tests nor in IDE.


feat(indexer): new JRPC method to list substates

Description

Added new columns template_address, module_name and timestamp to the substates SQLite table.
Added new column timestamp to the events SQLite table. For now it's populated but not used by any method yet.
The event_scanner fetches and stores in database the values for all the new fields in substates and events
New JPRC method list_substates
Updated TypeScript bindings related with the new indexer method
Removed old logic for event storing in the event_manager, it's all now done only on the event_scanner and controlled by the event filter in the indexer config

Motivation and Context
On https://github.com/tari-project/tari-dan/pull/1043 we refactored the Indexer to automatically store all substates related to events. This PR follows on that work and adds a new JRPC method list_substates that allows to fetch and filter all the substates stored in the Indexer database. It also adds some metadata (template_address, module_name, timestamp) to substates.
The new method JRPC method list_substates has the following optional parameters:

filter_by_template: String with the template address of the components that we want to filter
filter_by_type: String with the only type of substate that we want. Possible vaules are "Component", "Resource", "Vault", "UnclaimedConfidentialOutput", "NonFungible", "TransactionReceipt" and "FeeClaim"
limit: u64 value for the maximum number of results that we want (intended for pagination)
offset: u64 with the position of the first result that we want (intended for pagination)

How Has This Been Tested?
Manually by:

Spawning a local network using tari_swarm
Performing some transactions to generate events and substates
Inspecting the Indexer database and also querying the new list_substate method

What process can a PR reviewer use to test or verify this change?
See previous section
Breaking Changes

[x] None
[ ] Requires data directory to be deleted
[ ] Other - Please specify

LGTM - looks like a graphQL test is missing the timestamp field or it should be optional


Adding platform and abi tags in our node-pre-gyp.

Allows to use more than one runtime. Should fix #8887 and #10558.

All of the Kokoro failures are various timeouts. Merging this one, since it's fairly small, and node tests passed.


First release version

When running corp-semantic-release for the first time, it doesn't increment the version based on what's in package,json, instead it resets it to version 1.0.0.

That’s the intended behavior. This aligns with semantic-release as far as I remember.

Thanks for getting back to me quickly.
Fair enough. So we've been working on an npm module and have been manually incrementing its version. We'd like to start using corp-semantic-release but because of this behaviour it will reset us back to v1.0.0 which will cause us problems. What's the best approach in this situation ?

The idea behind semantic-release and Corp-semantic-release is to automate the version number so you never set the version manually. This number allocation is based on your strstured commit messages since the last semver tag. Then the tool decides if bump is a patch, minor or major, again it s all based on commit messages.
If you really want to set the version manually, sorry tools mentioned here are not suitable for your case.

I think I explained the situation poorly.
We started a project without using semantic release and had been incrementing the version manually.
We are now up to v1.5.0
We would like to start using semantic release to automate the versioning. We don't want to increment the version manually any more.
The concern we have is upon using it for the first time it will set us back to v1.0.0 which we don't want. Is there a way to make its first release match/use our current package.json version?

You probably incrementes version by changing in the package.json only and never created a tag to match the version. If that’s what you did, all you need to to is create a semver tag to match what you have now, then corp-semantic-release will know how to increment.

I m on mobile now. In one hour, I’ll look at the code to tell you the npm command to run. It may be just “giy tag v1.5.0” with the “v” or not, I don’t remember now

Awesome! Thanks for your help. I've been looking into this and the tags have a "v" at the start. Thanks again

ahhh now I get what was happening to me as well. Thank you both for the clarification. Perhaps a comment about this in the README would be very useful :)
Great tool Leo.


Usage with Winston

The docs explain how to use feathers-logger with winston:
var winston = require('winston');
var feathers = require('feathers');
var logger = require('feathers-logger');
var memory = require('feathers-memory');

var app = feathers()
    .configure(logger(winston))
    .use('/users', memory);

app.log('Server Started');

But Winston is normally instantiated and configured first, like so:
const winston = require('winston');

const winstonLogger = new winston.Logger();

// Add transport to winston logger here

How do I add a transport to the logger if I pass the winston function as per the example instructions?

Updated: Passing the instantiated winston logger seems to work for me. Here's a sample using winston (@2.4.4) with winston-raven-sentry
const feathers = require('@feathersjs/feathers')
const express = require('@feathersjs/express')
const feathersLogger = require('feathers-logger')
const winston = require('winston')

const app = express(feathers())

const sentryConf = {
  dsn: 'put sentry dsn here'
}

const sentryConf = app.get('sentry')
const logger = new winston.Logger()

logger.add(Sentry, sentryConf)
app.use(logger.transports.sentry.raven.requestHandler())

app.configure(feathersLogger(logger))

Second update: Winston doesn't have to be instantiated, see https://github.com/winstonjs/winston/tree/2.x#logging.
Closing


Debugger for Ghidra?

Hi I noticed you have the ability to add plug-ins, do you have any compatible plug-ins to add a debugger feature? Or is there a built in debugger in the near future planned?

There is currently no way to debug your code but yes, the NSA seems to be working on it.
Cf. https://github.com/NationalSecurityAgency/ghidra/issues/24#issuecomment-470676329


Param groups. Collapsable Groups in UI

Enable grouping of params with "group" property in param definition object.
Enable expand/collapse of param groups in UI

This PR implements the feature I requested here: https://github.com/fxhash/fxlens/issues/30
I don't have React experience, so please feel free to improve if needed.

Hey there! Many thanks for reviewing my proposal and providing clear feedback.
Regarding the code quality comments, they are very welcome. As stated above, I'm not very familiar with React and only have basic understanding with Typescript, so I'm taking good note of these.
Regarding the API for defining the groups, I agree that changing the structure so that groups are defined first, and then params as 2nd level, is cleaner and avoids redundancy. Actually @fraguada suggested this yesterday in a private conversation and makes a lot of sense. I implemented it in the way I did because, as far as I understand, changing the API in that way would have required changes in other areas of the system, breaking compatibility until those were upgraded. Since the main motivation for this fork was to make the feature available to me now while working on a generative project, I thought this was the best route to go by now.
The issue with sorting the groups is "solved" in a loose way just by defining the params in the desired order (in my project I define them so that all "group 1" are defined first, then all "group 2" ones, etc... It seems from the results I got that this order is preserved when iterating the list in the UI. But yes, ideally order should be more explicit.
Finally, regarding setting a schedule for integrating this feature, I 100% understand this is not priority, specially since you guys are currently engaged in big important changes like ethereum support and more. This implementation solves my practical issue while developing generative tokens locally, so no hurry at all to get it into your pipeline. Glad to know, though, that you found it interesting and worth of your consideration 👍


How do we deal with redirects?

Obviously, they need to be a certain kind of node -- when exported, they should render to an .html file that performs a JavaScript redirect. Any other ideas?

Current ideas:

create nodes dynamically (or through emitters, see #15) that represent a URL that will perform a redirect
when exporting, have these export a HTML page with a meta tag redirect
when serving live, have these perform Location header redirects


2月分

全102本、うち新規35本

[x] P0290R4 apply() for synchronized_value
[x] P1715R1 Loosen restrictions on "_t" typedefs and "_v" values.
[x] P2022R0 Rangified version of lexicographical_compare_three_way
[x] P2308R0 Template parameter initialization
[x] P2497R0 Testing for success or failure of charconv functions
[x] P2749R0 Down with "character"
[x] P2754R0 Deconstructing Avoiding Uninitialized Reads of Auto Variables
[x] P2770R0 Stashing stashing iterators for proper flattening
[x] P2771R0 Towards memory safety in C++
[x] P2772R0 std::integral_constant literals do not suffice - constexpr_t?
[x] P2773R0 Considerations for Unicode algorithms
[x] P2779R0 Make basic_string_view's range construction conditionally explicit
[x] P2782R0 A proposal for a type trait to detect if value initialization can be achieved by zero-filling
[x] P2784R0 Not halting the program after detected contract violation
[x] P2786R0 Trivial relocatability options
[x] P2787R1 pmr::generator - Promise Types are not Values
[x] P2788R0 Linkage for modular constants
[x] P2789R0 C++ Standard Library Ready Issues to be moved in Issaquah, Feb. 2023
[x] P2790R0 C++ Standard Library Immediate Issues to be moved in Issaquah, Feb. 2023
[x] P2791R0 mandate concepts for new features
[x] P2796R0 Core Language Working Group "ready" Issues for the February, 2023 meeting
[x] P2797R0 Proposed resolution for CWG2692 Static and explicit object member functions with the same par
[x] P2798R0 Fix layout mappings all static extent default constructor
[x] P2799R0 Closed ranges may be a problem; breaking counted_iterator is not the solution
[x] P2802R0 Presentation of P1385R7 to LEWG at Issaquah 2023
[x] P2803R0 std::simd Intro slides
[x] P2805R0 fiber_context: fibers without scheduler - LEWG slides
[x] P2806R0 do expressions
[x] P2807R0 Issaquah Slides for Intel response to std::simd
[x] P2808R0 Internal linkage in the global module
[x] P2810R0 is_debugger_present is_replaceable
[x] P2812R0 P1673R11 LEWG presentation
[x] P2815R0 Slides for presentation on P2188R1
[x] P2816R0 Safety Profiles: Type-and-resource Safe programming in ISO Standard C++
[x] リビジョン更新系68本

完了！！


#14773: Set default to true when getting active ethernet cores

Ticket
Link to Github Issue
https://github.com/tenstorrent/tt-metal/issues/14773
Problem description
T3K VMs were failing on some watcher tests in t3k unit tests.
What's changed
With help from @mo-tenstorrent @tt-dma. These changes allow for T3K VMs to pass t3k unit tests due to failing to enumerate correctly which core to use.
Merging this test in allows for T3K VMs to be added into CI and alleviate heavy t3k functional test load
Checklist

[ ] Post commit CI passes https://github.com/tenstorrent/tt-metal/actions/runs/11695346421
[ ] Blackhole Post commit (if applicable) https://github.com/tenstorrent/tt-metal/actions/runs/11695417179
[ ] Model regression CI testing passes (if applicable)
[ ] Device performance regression CI testing passes (if applicable)
[ ] New/Existing tests provide coverage for changes
[ ] t3k unit https://github.com/tenstorrent/tt-metal/actions/runs/11695348568
[ ] t3k freq https://github.com/tenstorrent/tt-metal/actions/runs/11695347560

Custom Dispatch on previously failing t3k tests
https://github.com/tenstorrent/tt-metal/actions/runs/11694254577/job/32567562536
https://github.com/tenstorrent/tt-metal/actions/runs/11694265540/job/32567581892
https://github.com/tenstorrent/tt-metal/actions/runs/11694273627/job/32567674280

Great Find 🚀


Numeric widget and localized number formatting.

Replaces text fields where the user is expected to input a number with NumericWidget, supporting extended syntax and formatting. (See https://github.com/GTNewHorizons/ModularUI/pull/62.)
Replaces instances where a dynamic text field is being communicated between server and client with a purely client-side method. In some cases this allows the client to do localization on these texts correctly. (See https://github.com/GTNewHorizons/ModularUI/pull/69.)
Modifies other instances where the UI displays a number to use a locale-aware formatter. (See https://github.com/GTNewHorizons/ModularUI/pull/67.)

Notes:

Neutron Sensor UI required a rework to implement this. Previously, the player would specify an expression, such as >150MeV, which was then parsed and evaluated compared to the current energy of the Neutron Accelerator. The new UI looks much like the UI of covers, it has a numeric threshold and an invert setting. Since the numeric widget supports SI suffixes, the player can still type an expression like 150M into the field and set the expected threshold.

Sensors placed in-world update seamlessly to the new system, so existing setups won't explode! With one exception: comparisons for == and != are no longer supported, they are converted to <= and > respectively. This means that triggers ==0eV and !=0eV continue working as expected. I can't think of any other reason why one would want to test for exact (in)equality here, I also asked in discord, and got no answers.
* YOTTank UI text formatting depends on https://github.com/GTNewHorizons/ModularUI/pull/71. This will not work until the transitive dependency is updated through GT5 again (sorry Dream). Please don't merge this PR until this is done. Done.

Tracking down every single instance where a mod writes a number is nearly impossible. I use a few heuristics and code searches, but it is very likely that I miss some places. If an UI displays an unformatted or wrongly formatted number somewhere, please report it to be fixed.

Ready for review and merge.


Place "rootURL" in correct location

This project uses semver, please check the scope of this pr:

[x] #none# - documentation fixes and/or test additions
[ ] #patch# - backwards-compatible bug fix
[ ] #minor# - adding functionality in a backwards-compatible manner
[ ] #major# - incompatible API change

CHANGELOG

Update location of rootURL configuration option messed up during prior Ember CLI upgrade

Approved


   I wonder if intel machines have ever encountered such a situation

Hi. Sorry for the late reply. No, I have not encountered this problem.


Add footer in feedback and nearby page

I want to add footer in feedback and nearby page to make it easy for the customer to visit the site.
Please assign this issue to me under gssoc-extd and hacktoberfest.

Okk
On Fri, 1 Nov, 2024, 8:46 pm github-actions[bot], @.***>
wrote:

🙌 Thank you for bringing this issue to our attention! We appreciate your
input and will investigate it as soon as possible !
—
Reply to this email directly, view it on GitHub
https://github.com/mansiruhil13/Bobble-AI/issues/1152#issuecomment-2452049433,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BKSUFC4YA3NAZ7MS2JKPCILZ6OLMJAVCNFSM6AAAAABRAOGVZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJSGA2DSNBTGM
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Allow use of consensus sequences from other programs

I have had a request to allow the use of consensus sequences generated by other programs.  There is a skeleton in the code to allow this but decisions have to be made as to the format of the input file.  The request was for a file with sequence data only not a FASTQ format.

ScarMapper now uses PEAR to generate the consensus.  The original method still exists in the code as well.  Closing this for now.  It is a simple thing to input a FASTQ file with only consensus sequences.  Not an easy thing to input a file not in FASTQ format though.  Don't see a need for this feature at this time.


.show database Samples schema returns err "column of type System.String, which was unknown"

Running the Mgmt(..) query .show database Samples schema returns the error DataTable had column of type System.String, which was unknown.
I am seeing this error on a number of databases I have been developing against and tests against the Samples demonstration database also return this error.
The following code can reproduce.
package main

import (
	"context"
	"fmt"
	"io"
	"os"

	"github.com/Azure/azure-kusto-go/kusto"
	"github.com/Azure/go-autorest/autorest/azure/auth"
)

const (
	showTablesKql    = ".show tables | project TableName" // good query..
	showDbKql        = ".show database Samples schema"    // bad query
	dbName           = "Samples"                          // via https://help.kusto.windows.net
	connectionString = "https://help.kusto.windows.net"
)

func check(err error, where string) {
	if err != nil {
		fmt.Fprintf(os.Stderr, "ERROR: %s -> %v\n", where, err)
		os.Exit(1)
	}
}

func main() {
	azCreds, err := auth.NewAuthorizerFromCLIWithResource(connectionString)
	check(err, "authorizer")

	authorizer := kusto.Authorization{Authorizer: azCreds}
	client, err := kusto.New(connectionString, authorizer)
	check(err, "client")

	rows, err := client.Mgmt(context.Background(), dbName, kusto.NewStmt(showDbKql))
	check(err, "mgmt")

	for {
		row, err := rows.Next()
		if err != nil {
			if err == io.EOF {
				check(err, "eof")
			}
			check(err, "row")
		}
		fmt.Printf("%#v\n", row)
	}
}

Running the above returns
go run main.go
ERROR: row -> DataTable had column of type System.String, which was unknown
exit status 1

Note that if you swap to another working query (eg showTablesKql), it confirms parsing of other mgmt commands are successful.

At a quick glance, I'd guess something is causing this line to occur:
@.***/-/blob/kusto/internal/frames/v1/v1.go?L41
Which is in turn skipping the V1 frames type translation from happening on line:
https://sourcegraph.com/github.com/Azure/azure-kusto-go/-/blob/kusto/internal/frames/v1/v1.go?L47
V1 and V2 frames have different names for types and we have an internal type in Go we use to represent all column types.  Normally, what should happen, is when we receive a V1 frame and we translate it to the correct type. In this case:
"system.string":                   types.String
That looks like it is getting skipped.
John Doak
Manager, Layer 1 Reliability Engineering
@.***

From: Jesse Ward @.>
Sent: Tuesday, September 20, 2022 2:26 PM
To: Azure/azure-kusto-go @.>
Cc: Subscribed @.***>
Subject: [Azure/azure-kusto-go] .show database Samples schema returns err "column of type System.String, which was unknown" (Issue #116)
Running the Mgmt(..) query .show database Samples schema returns the error DataTable had column of type System.String, which was unknown.
I am seeing this error on a number of databases I have been developing against and tests against the Samples demonstration database also return this error.
The following code can reproduce.
package main
import (
"context"
"fmt"
"io"
"os"
    "github.com/Azure/azure-kusto-go/kusto"
    "github.com/Azure/go-autorest/autorest/azure/auth"

)
const (
showTablesKql    = ".show tables | project TableName" // good query..
showDbKql        = ".show database Samples schema"    // bad query
dbName           = "Samples"                          // via https://help.kusto.windows.net
connectionString = "https://help.kusto.windows.net"
)
func check(err error, where string) {
if err != nil {
fmt.Fprintf(os.Stderr, "ERROR: %s -> %v\n", where, err)
os.Exit(1)
}
}
func main() {
azCreds, err := auth.NewAuthorizerFromCLIWithResource(connectionString)
check(err, "authorizer")
    authorizer := kusto.Authorization{Authorizer: azCreds}
    client, err := kusto.New(connectionString, authorizer)
    check(err, "client")

    rows, err := client.Mgmt(context.Background(), dbName, kusto.NewStmt(showDbKql))
    check(err, "mgmt")

    for {
            row, err := rows.Next()
            if err != nil {
                    if err == io.EOF {
                            check(err, "eof")
                    }
                    check(err, "row")
            }
            fmt.Printf("%#v\n", row)
    }

}
Running the above returns
go run main.go
ERROR: row -> DataTable had column of type System.String, which was unknown
exit status 1
Note that if you swap to another working query (eg showTablesKql), it confirms parsing of other mgmt commands are successful.
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-kusto-go%2Fissues%2F116&data=05|01|John.Doak%40microsoft.com|41ae2c632dcd4f1ea2b808da9b4eca30|72f988bf86f141af91ab2d7cd011db47|1|0|637993059956736307|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=vwkoHpBKGR20v2nrQ2ysPFqhHVsMYyfcgO1%2BfTKBTOU%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKCSL7E6JOJGHNPFW7HGD5TV7ITYRANCNFSM6AAAAAAQRO72AE&data=05|01|John.Doak%40microsoft.com|41ae2c632dcd4f1ea2b808da9b4eca30|72f988bf86f141af91ab2d7cd011db47|1|0|637993059956736307|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=I8dml%2BMV07KEPB3JNQBasT2sV4YExAaL5CFy%2BJdzu4o%3D&reserved=0.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Expandable rows TableView

Closes
✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:
RSP

@ktabors

Noticed when I changed the locale, there is a css/rendering flicker where the ExpandableRowChevron changes from closed to expanded after the table flips.

I can't seem to reproduce this, was this in particular story/browser?

Just to confirm, no changes were made when TableView became TableViewBase. They looked the same in my editor.

There were some changes, but def hard to see with the new diff. https://github.com/adobe/react-spectrum/commit/dfcdea154620b418190b4d44193aba7a3ac89e03#diff-613fe2bf090dadb8c1be12e5cbd07f8257055654cf30e819e1f3d0362dfdc930 is helpful here, shows the TableView changes before the naming changes.

I need to confirm if this is preexisting. There seems to be a slow re-rendering with the resizable columns example...

I'll see about reproducing this on main

btw, great work on this. It's looking really awesome overall. Only really had minor nits. 🥳

Two additional thoughts:

I think we should temporarily prefix expandedKeys, defaultExpandedKeys, onExpandedChange, and childItems (on Row) with UNSTABLE_ as well. In addition we should add something to the prop description that explains that they only work if hasExpandableRows is true. I wouldn't change the shared Expandable interface for now, so maybe that means copying those type definitions into the table types temporarily.
Maybe hasExpandableRows should be called allowsExpandableRows? It's subtle but to me, "has" implies that there are currently expandable rows in the content, but that might not always be the case if the content is user generated (e.g. if there are no sub folders). "Allows" makes it clearer that it can contain expandable rows but might not always. 🤷


[EXPERIMENT, DO NOT MERGE] Implementing a Future type using Concurrency

⚠ This PR is experimental only. Do not merge it!
This change adds a Future type to the Concurrency library that can be used to represent a value to be lazily and asynchronously resolved "later." Futures are a common feature of concurrency libraries (see for instance Combine.Future or std::future.
Today in Swift, Task<T, E> can be used as a future, however it immediately schedules its work when it is instantiated and it may keep references to memory and other resources longer than is strictly necessary. This Future type attempts to be lighter-weight.
Note: I don't intend to merge this PR. I opened it so I could run builds and tests only.

@swift-ci please smoke test

@swift-ci please smoke test windows

@swift-ci please smoke test


Focusing slotted child in firstUpdated does not work

Description
The guide recommends using the firstUpdated lifecycle method to programatically focus a child node. If the node you wish to focus is slotted inside another custom element, calling focus() does nothing.
I'm not sure if this is a lit-element bug, a browser bug, or a deficiency of the Shadow DOM v1 design.
Live Demo
https://stackblitz.com/edit/y3xeha?file=my-element.js
Steps to Reproduce

Create a custom element that places its light DOM children into a <slot>:

class FirstElement extends LitElement {
  render() {
    return html`<slot></slot>`;
  }
}

Create a second custom element that uses the first, and composed a button inside it:

class SecondElement extends LitElement {
  render() {
    return html`
      <first-element>
        <button>I should be focused</button>
     </first-element>
    `
  }
}

Have the second custom element attempt to focus the button it has composed inside the first:

  firstUpdated() {
    this.querySelector('button').focus();
  }

Expected Results
When an instance of the second element is added to the DOM, the button it contains should be focussed.
Actual Results
The button is not focussed.
Browsers Affected

[x] Chrome
[x] Firefox
[ ] Edge (untested)
[x] Safari 11
[ ] Safari 10 (untested)
[ ] IE 11 (untested)

Versions
<!--
`npm ls` will show the version of webcomponents.js and lit-element
```
    "@webcomponents/webcomponentsjs": "^2.2.7",
    "lit-element": "^2.0.1"
```

In this case you are using the right callback, however your code is not taking into account the requirement that the child element must also be fully update before you can focus its contents. If take a look at https://stackblitz.com/edit/y3xeha-o4gmjt?file=my-element.js you will see the context in question working as expected.
The operative difference is the following:
  async focusButton() {
    await this.shadowRoot.querySelector('my-frame').updateComplete;
    this.shadowRoot.querySelector('#test').focus();
  }

Here the parent element is waiting for its child to completely update before attempting to focus it's contents. This delay ensure that the button will actually have a <slot/> to be displayed in (i.e. actually be available for receiving focus) before focusing the element.
Hope that helps!

@Westbrook Thanks, that works for my use-case. Although I notice the problem reappears if composed element also composes its slotted content: https://stackblitz.com/edit/y3xeha-mqtjqg?file=my-element.js
It would be nice if there was some lifecycle method that was called when the DOM was definitely ready to be manipulated.

You may be referencing this: https://github.com/Polymer/lit-element/pull/400 Very WIP, some what speculative, and may not be exactly what you're looking for, so if you have thoughts or use cases that you think it should support, add them to https://github.com/Polymer/lit-element/issues/365
Cheers!


Support Fields

HEC supports passing additional fields that are not directly part of the event data. This is useful for example to provide additional metadata about the events beyond just the sourcename.
https://docs.splunk.com/Documentation/Splunk/7.2.1/Data/IFXandHEC

Agreed - we'll look to add this functionality

Meta-Data support for Docker - assigning to self

Hi @dtregonning
This feature would meet our use case perfectly. We want to be able to specify the Splunk index from within the application logs, and unfortunately there is no simple way of doing this with the current version of the Splunk docker logging driver.
I note this issue has been open for 3 years, I'm surprised there isn't more interest. Do you know if there is a plan to include this at all?
Thanks


Can't use vim-airline with latest neovim-git

environment

vim: Neovim latest head
vim-airline: Latest installed via VimPlug
OS: ArchLinux
terminal: gnome-terminal and tmux

actual behavior
airline fails when trying to launch the editor and makes it unusable until I disable airline and restart the editor.
Screenshot of the error attached, let me know if you need more detailed logs.

expected behavior
No errors should be thrown.

@aignas, is it this? https://github.com/neovim/neovim/issues/4471

please report at neovim bug tracker. Thanks.