Move comment action out of models package

As title.

Codecov Report

Merging #9254 into master will increase coverage by 0.01%.
The diff coverage is 52.42%.

@@            Coverage Diff             @@
##           master    #9254      +/-   ##
==========================================
+ Coverage   41.03%   41.05%   +0.01%
==========================================
  Files         556      556
  Lines       72535    72596      +61
==========================================
+ Hits        29763    29801      +38
- Misses      39027    39047      +20
- Partials     3745     3748       +3

Impacted Files
Coverage Δ

services/pull/merge.go
51.11% <0%> (ø)
:arrow_up:

modules/notification/webhook/webhook.go
37.31% <100%> (ø)
:arrow_up:

services/issue/status.go
57.14% <100%> (ø)
:arrow_up:

models/issue_comment.go
42.85% <100%> (ø)
:arrow_up:

modules/notification/base/null.go
64.51% <100%> (ø)
:arrow_up:

modules/notification/notification.go
72.51% <100%> (ø)
:arrow_up:

modules/notification/mail/mail.go
22.38% <100%> (ø)
:arrow_up:

modules/notification/ui/ui.go
74.46% <100%> (ø)
:arrow_up:

models/error.go
32.42% <20%> (-0.25%)
:arrow_down:

models/issue.go
52.18% <36.66%> (+0.07%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9c67a8...f582fd2. Read the comment docs.


Suggestion: When clicking a notification, open the link in the tweet

I often get a desktop notification with a link in the tweet. If I click on the notification, nothing happens.
I think it would be great to open the first link (or only open the link if there is only one link in it).
What do you think?

Unfortunately, I am not using desktop notification.  (Therefore, control of the notifications is not correct.)
I think the listener for chrome.notification.onClicked should work to close notification.
chrome.notification.onButtonClicked looks like to able to use for some feature (open link, quick Likes, quick Retweet, Reply...), but "button" is only two.
If there is only two, they would be "Likes" and "Retweet"...

I see. Hm, so would more options solve that? (let the user set which buttons to display)

@studioddtonline I've solved this issue on my fork, if you want you can cherry pick those commits:
https://github.com/kurtextrem/SilverBirdM/commit/b6363a3a0a5d39713176c0a7d500cc3ec229ea7a
https://github.com/kurtextrem/SilverBirdM/commit/e793a4465253894df36cfcfc057d1b2ac7fad8a2
https://github.com/kurtextrem/SilverBirdM/commit/47b4cc6fa854d4acbfe91d40a3eeef14ccec6157
https://github.com/kurtextrem/SilverBirdM/commit/69d50412568888be31cd5c98a5a5d9c5ee08067d

I saw these patch sets, but i think that it is difficult to merge as is.

You could try replacing everything in the file with this version: https://github.com/kurtextrem/SilverBirdM/blob/master/lib/NotificationManager.js


fixes #24422 leading double quote in non-quoted \t separated field

fixes issue #24424 leading double quote in non-quoted field with \t separator

I signed it!


case enum

We have enums and you can use case with them:
enum Color
  Red
  Green
  Blue
end

color = Color::Red
a = case color
    when Color::Red
      1
    when Color::Green
      2
    when Color::Blue
      3
    end

Enums are great because, unlike symbols, they are type-safe. They are like a group of limited and documented symbols. You can't accidentally misspell them. And you can use them as restrictions.
However, the above case has a few issues:

You have to repeat the enum's name in every branch.
a's type is nilable, because there's an implicit else part with nil. Ideally the compiler should be smart and know there are no other possible values. This is partly because the compiler blindly transforms the case into a series of if-elseif, but also, because of how our type inference works, color might eventually get another type.
There's no way to say that we want to cover all cases and, later, when we add another enum value, let the compiler know that we want a compiler error until we cover all cases again. This would be somewhat similar to D's final switch.

I'm thinking about having something like this:
# But with a less ugly syntax...
case color as enum Color
when Red
  ...
when Green
  ...
when Blue
  ...
end

Possibly with a modifier to make it final.

Now that we added enum query methods, it can be done like this:
color = Color::Red
a = case color
    when .red?
      1
    when .green?
      2
    when .blue?
      3
    end

Could this be documented? The book shows an example like this, but there isn't a clue that this is automatically derived.
Also, after this discussion I'd expect an compile error, but running this code compiles fine and prints 1 : (Int32 | Nil) on Crystal v0.22.0.
enum Color
  Red
  Green
  Blue
end

color = Color::Red
x = case color
  when .red?
    1
  when .green?
    2
  end

printf("%s : %s\n", x, typeof(x))

(Related: #1846)


Issue deploying template via docker

🙂 Expected behavior
Run docker image using templates for typesctipt application
What is expected to happen?
🫠 Actual behavior
ExecaError: Command failed with exit code 1: docker container create --volume './.cartesi/image.tar:/tmp/input' 'cartesi/sdk:0.9.0' /usr/bin/env bash -c
'cat /tmp/input | crane export - - | bsdtar -cf /tmp/output --format=gnutar @/dev/stdin'

Error response from daemon: create ./.cartesi/image.tar: "./.cartesi/image.tar" includes invalid characters for a local volume name, only
"[a-zA-Z0-9][a-zA-Z0-9_.-]" are allowed. If you intended to pass a host directory, use absolute path

🧪 Minimal test case
Please describe a minimal test case that demonstrates the bug.
If possible, this should be an automated test.
🌎 Environment
MAC 14 M1
What is the environment that the bug happens?
What is the Rollups version?
0.9.0
✔ Possible solutions
(This section is optional.)
Any hint on how to solve the issue?
What parts of the code will be affected?

What is the output of cartesi doctor?

What is the output of cartesi doctor?
Error: Unsupported Docker version. Minimum required version is 23.0.0. Installed version is 20.10.17.

Trying with new version

What is the output of cartesi doctor?
Error: Unsupported Docker version. Minimum required version is 23.0.0. Installed version is 20.10.17.

Trying with new version

It helped, thank you


UserWarning when using lightgbm.Dataset from pandas.DataFrame if both train and valid_sets are specified

First off, I am not sure if this is related/hinted at in #960.
I am sorry if (you feel) this is a duplicate, feel free to close it.
As per the title, when using lightgbm.Dataset constructed from pandas.DataFrame for both train and validation data, I get the warning UserWarning: categorical_feature in param dict is overridden. even if categorical_feature is never specified.
And a question, if I may; I am now not sure now if lightgbm properly uses the categorical features despite this warning. Does this behavior have any effect on the actual models?
MWE:
from sklearn.datasets import load_iris
import pandas as pd
import lightgbm as lgbm

X, y = load_iris(return_X_y=True)
X = pd.DataFrame(X)
X[0] = X[0].astype(int).astype('category')

X_train = X.sample(100)
y_train = y[X_train.index]
X_eval = X[~X.index.isin(X_train.index)]
y_eval = y[X_eval.index]

d_train = lgbm.Dataset(X_train, y_train)
d_eval = lgbm.Dataset(X_eval, y_eval)

params = {}
lgbm.train(params, d_train, valid_sets=d_eval)

Environment info
OS: Debian GNU/Linux 8 (jessie) in a docker container hosted on Windows 10 Enterprise, 64 bit.
Python: 3.6.4
Lightgbm: 2.2.3

Thanks for the clarification!

Thanks for the clarification!


1.20.6 update?

I'm really looking forward to updating to version 1.20.6, will it happen?

Realized


QOS 2 Supported?

Hi,
I tried to publish with qos 2, but does not work.
$conn->publish($request->getParameter('target'), $msg, 2);
Don't know if I'm missing some detail.
Thanks in advance

Hello,
Support publish qos2 now?

Me2 looking forward for this feature.

I guess the issue lies within this code part of subscribe:
//$qos
$cmd += ($qos << 1);

According to MQTT spec the fixed header of PUBLISH should be 0x82; the QoS doesn't go there. The QoS is just is part of the payload.
I guess the two lines cited above could be removed.


IntegrationTesting  MultimediaPartReader / XDocument

When trying to do integration testing with a  MTOM  Related Message, I keep running into an issue  where application code that I can run successfully in a webserver  does not work in the integration testing framework.
The issue is when using the MultipartReader,  we read a section that matches a media type.  We then take that MultipartSection.Body   Stream  and use the XDocument.Load( stream).
Again,  in an actual server this code works just fine.  When attempting to run an integration test though, the code no longer works and I get an XDocument Exception saying  that there is no root element.
Here is an abstraction of the code in the controller that is giving me issue in an integration test
 var boundary = Request.GetMultipartBoundary();

            var reader = new MultipartReader(boundary, Request.Body);
            bool done = false;
            while (!done)
            {
                var section = await reader.ReadNextSectionAsync();
                if (section != null)
                {
                    foreach (var header in section.Headers)
                    {
                        Console.WriteLine($"{header.Key}: {header.Value}");
                    }

                    XDocument.Load(section.Body);

                   // var body = await section.ReadAsStringAsync();
                   // Console.WriteLine(body);

                }
                else
                {
                    done = true;
                }

            }
            return "Hello World";

With the Xunit Test Method

  var request = new HttpRequestMessage();
            request.Headers.Add("MIME-Version", "1.0");

            var outboundPayload = new MultipartContent("related", "uuid:3f4da383-2009-4fbd-a202-2a678f4ec28f+id=9");
            outboundPayload.Headers.ContentType.Parameters.Add(new NameValueHeaderValue("type", "\"application/soap+xml\""));
            outboundPayload.Headers.ContentType.Parameters.Add(new NameValueHeaderValue("start", "\"<http://test.org/0>\""));

            var soapXml = @"<s:Envelope
                            xmlns:s=""http://www.w3.org/2003/05/soap-envelope""
                            xmlns:a=""http://www.w3.org/2005/08/addressing"">
                          <s:Header>
                            <a:Action s:mustUnderstand=""1"">test</a:Action>
                            <a:MessageID>urn:uuid:00000000-0000-0000-0000-000000000000</a:MessageID>
                            <ActivityId CorrelationId=""00000000-0000-0000-0000-000000000000""
                                xmlns=""http://schemas.microsoft.com/2004/09/ServiceModel/Diagnostics"">
                              00000000-0000-0000-0000-000000000000
                            </ActivityId>
                            <a:ReplyTo>
                              <a:Address>http://www.w3.org/2005/08/addressing/anonymous</a:Address>
                            </a:ReplyTo>
                            <a:To s:mustUnderstand=""1"">http://test</a:To>
                          </s:Header>
                          <s:Body>
                          </s:Body>
                        </s:Envelope>";

            ///Ensuring the XML can be loaded
            XDocument.Parse(soapXml);

            var payload = new ByteArrayContent(Encoding.UTF8.GetBytes(soapXml));

            payload.Headers.Add("Content-ID", "<http://test.org/0>");
            payload.Headers.Add("Content-Transfer-Encoding", "8bit");
            payload.Headers.Add("Content-Type", "application/soap+xml");

            outboundPayload.Add(payload);
            request.Content = outboundPayload;

            request.RequestUri = new Uri($"/test", UriKind.Relative);
            request.Method = HttpMethod.Post;

            var client = _factory.CreateClient();
            var response = await client.SendAsync(request);

Using a WebApplicationFactory
  public class XUnitWebApplicationFactory<TStartup> : WebApplicationFactory<TStartup> where TStartup : class
    {
        protected override IWebHostBuilder CreateWebHostBuilder() => WebHost.CreateDefaultBuilder().UseStartup<Startup>();
        protected override void ConfigureWebHost(IWebHostBuilder builder)
        {
            builder.UseContentRoot(".");
            base.ConfigureWebHost(builder);
        }
    }

Hi. It looks like this is a question about how to use ASP.NET Core. While we do our best to look through all the issues filed here, to get a faster response we suggest posting your questions to StackOverflow using the asp.net-core-mvc tag.

@javiercn do you have any recommendations here?

Nope. We don’t have enough info either. We might be able to help if we get a repro project. @tratcher as this is not WAF specific.

What's the output from this line if you disable the XML parsing?
// var body = await section.ReadAsStringAsync();
// Console.WriteLine(body);
What version of ASP.NET Core is this? 2.2?

yes it is netcoreapp2.2
it works as expected outputting the payload of the multipartSection
<s:Envelope
xmlns:s="http://www.w3.org/2003/05/soap-envelope"
xmlns:a="http://www.w3.org/2005/08/addressing">
<s:Header>
<a:Action s:mustUnderstand="1">test</a:Action>
<a:MessageID>urn:uuid:00000000-0000-0000-0000-000000000000</a:MessageID>

00000000-0000-0000-0000-000000000000

<a:ReplyTo>
<a:Address>http://www.w3.org/2005/08/addressing/anonymous</a:Address>
</a:ReplyTo>
<a:To s:mustUnderstand="1">http://test</a:To>
</s:Header>
<s:Body>
</s:Body>
</s:Envelope>
@Tratcher  I have created a repo project you can pull at the following link
https://github.com/Frankwayne/aspnetCore.multipartReader.XDoc.StreamIssue

Mitigation:
                    var memoryStream = new MemoryStream();
                    section.Body.CopyTo(memoryStream);
                    memoryStream.Seek(0, SeekOrigin.Begin);
                    XDocument.Load(memoryStream);

The most likely issue is that the MultipartReaderStream reports CanSeek = true, but Length = 0. I don't see where the XDocument Load call checks those, but I wasn't able to debug into that code.


Add svb compression to slow5

This PR adds a simple way to use StreamVByte compression with slow5. This is the primary way that slow5 files are compressed, so if you are using poly to io between different file stores or pipe between different programs, StreamVByte greatly helps - I've seen reduction in total database size (storing fastq and slow5 reads) from 12Gb to 7.1Gb using just this one weird trick (database engineers hate him)
The code changes have 100% code coverage, and I'm pretty sure I wrote more comments than actual code (not including tests).

@TimothyStiles Any thoughts?


import fails on Colab

I am unable to use this on Colab.
! pip install pyarmviz
import PyARMViz

Throws the error
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-154-d1ad5a21fa69> in <module>()
----> 1 import PyARMViz

5 frames
/usr/lib/python3.6/typing.py in _type_check(arg, msg)
    372         not isinstance(arg, (type, _TypingBase)) and not callable(arg)
    373     ):
--> 374         raise TypeError(msg + " Got %.100r." % (arg,))
    375     # Bare Union etc. are not valid as type arguments
    376     if (

TypeError: Parameters to generic types must be types. Got <module 'PyARMViz.Rule' from '/usr/local/lib/python3.6/dist-packages/PyARMViz/Rule.py'>.

Hi!
Please vote for my contribution to the project (https://github.com/Mazeofthemind/PyARMViz/pull/22).
I want to solve this problem for other users.
I tried to contact the repository owner via gmail.


Replica Function support (Lambda@Edge)

I'm still in the process of testing out what exactly the issue might be but I have a good hunch that the service does not know how to deal with edge function logs.
Likely this is because they're located in the region that the end user was closest to. (edge location)
This means that when an end user makes a request near Oregon.... then the logs for that lambda will end up in the Oregon region.
Additionally, the log prefix is different as well in that its:
/aws/lambda/us-east-1.demo-stack-proxy-dev-originRequest
vs the traditional...
/aws/lambda/demo-stack-proxy-dev-originRequest
I thought I might be able to shim the issue by running around and putting MONITORED=0 on all the replica functions... but as it appears (from the console anyway) you can't tag replica functions.
I'm not sure how you can even programmatically detect if they are replica functions.... looking into that now.
UPDATE:
You can't seem to see the function when you make a aws lambda list-functions but you can see it when you aws lambda get-function directly. However, there does not seem to be any replica identifying traits other then all replica function names start with us-east-1. regardless of what region a developer usually uses. Edge function masters always get created in us-east-1.
I'm going to start looking into your source to see if I can just add a check for us-east-1. as a prefix in the function name and exclude it for now. Later, maybe there is a way to even have these logging by adding subscription filters to the region related logs.

So I take it deploying this monitor to all regions that could have edge function executions doesn't work (yet)? Targeting region functions log groups shouldn't be hard.
Why do you want to disable monitoring for those functions? Is it more broken than simply not working?
What issues are you seeing? As I said this service works great for us, but we are not currently using edge lambda function.

No, as is, it seems to be fully broken as I think the Dummy Custom Resources that initially calls those subscribe functions are failing and causing the deploy to fail and roll back. This is maybe to do with it trying to locate a replica's associated log group and failing?
Deploying to all regions might work but is a bit overkill in my mind, especially since the regions that are “likely to have edge functions” is all of them.  So it would be impossible to predict.
I'm going to dive into the code a bit more and see if I can see exactly what the issue might be. But let me know if you have any ideas. I'm very happy to test them.

I'd love to see what the cloudformation template / resource lambda function logs look like (you need to be quick to find them before everything is torn down).
Also I'm sure @macmcirish has some input here in what would be interesting to look at!

AFK, for 1hr then will look for ya.
Also, I think I can alter these refs to logs and have it check for replica log groups across regions.
https://github.com/blackflux/lambda-monitor/blob/04e8d5ec00c5085388f8223d398b7acd5bfe6966/src/logic/util/lambda.js#L28

@iDVB Failing on the post deploy hook via a dummy resource is a frustrating issue that I plan to make much easier to understand :) up until now, I was the only one suffering from this, so I'm sorry to put you through my pain. Fortunately this is only an issue on the very first deploy of the stack, as when the initial deploy fails the teardown of the stack also deletes the log group.
To examine the log group before the teardown happens:

Open the Cloudwatch Management Console in the targeted region
Deploy the stack
As the stack is deploying, refresh the page until /aws/lambda/lambda-monitor-${YOUR_STAGE_HERE}-subscribe and /aws/lambda/lambda-monitor-${YOUR_STAGE_HERE}-set-retention appear. Open the log groups immediately.
When the logs are attached to this log group, you can find the error output on why the custom resource failed to deploy.

Once you have this info, it'll be a lot easier to track down the reason that this is failing to stabilise on deploy. Looking forward to hearing back from you!

Thanks! Actually, it seems to successfully send the error to Rollbar... so I CAN see that its due to

ResourceNotFoundException: The specified log group does not exist.

which led me to hypothesize about it not being able to fine the replica log groups.
Testing your steps to catch the logs though...

Looks like I can see pretty much the same thing in the Rollbar logs

@MacMcIrish @simlu  Any reason lambda.js isn't using AWS.REQUEST.promise().then() rather then creating your own promises? https://aws.amazon.com/blogs/developer/support-for-promises-in-the-sdk/

@iDVB Not really. That should probably be changed if the tests just continue working. I've already done that in other places last night.

Working on a PR for this now...
https://github.com/blackflux/lambda-monitor/pull/371

Task outline:
(1)
CloudTrail needs to be getting events from all regions
This is necessary so we can do actions based on edge lambda function log group creation.
(2)
The subscribe and set-retention need to be updated to handle "CloudTrail log group events" and "non CloudTrail log groups events" differently. For CloudTrail events only the log group that triggered the invocation should be handled. Otherwise we need to do an "expensive" check all call.
This is necessary so we do not overload the system with requests, otherwise this could get expensive and we will run into throttling.
(3)
Handle edge log group subscription correctly (when an edge log group gets created we need to check the master function for tags etc). This should be relatively easy, we just need to check if this is an edge log group and check the master function for tags.

I would start by figuring out what the lambda event for the CloudTrail log group creation event looks like (i.e. how much meta information is available).

Going to test to see what we can see in the CT event by letting it trigger a function with
console.log(JSON.stringify(event, null, 2)) in it.


Add high-level documentation and examples on managing keyboard focus.

Use case
My app must manage focus and the on-screen keyboard.  I read the provided documentation:

FocusNode class

Contains a single example of how to create a widget that can focus/unfocus itself and change its behavior depending on its focus state.

Focus class

Contains a partial example, which is an excerpt of the FocusNode example.

FocusScope class

No examples

FocusManager class

No examples.  Documentation explains briefly what it does, but makes no mention of how to use it for anything.

FocusScopeNode class

No examples.

I found the provided documentation to be missing key information:

How to use Focus and FocusScope to control focus in an application with multiple widgets.
Examples of common use-cases:

How to focus a widget in response to a tap.
How to automatically focus a new widget.
How to unfocus a widget.
How to keep a widget focused.
How to keep a focused widget visible.
How to keep the keyboard on screen.
How to determine when the keyboard is visible and update the display accordingly.
How to move focus from one widget to the next in a form.
How to specify the order of widget focus movement.
How to provide expected software keyboard decorations to move from one widget to the next.
How to dismiss the software keyboard on non-Android platforms.

My app requires all of these use-cases.  So far, I have made-do with reading Flutter's source code (a huge time sink), stackoverflow answers, and snippets shared in Flutter issues.  My implementations are unsatisfactory in many ways.  Today I have just wasted 2 hours trying to solve the problem of keeping the keyboard on screen on iOS, still with no solution.  Focus management is an area where I have sunk a lot of time working around missing parts of Flutter.  It has been and continues to be a struggle, a large energy sink.  I want to be building features and solving problems for my users, not fighting against the UX framework.
I think better documentation would help me and other app developers to arrive at good solutions quickly.
Proposal
Please allocate some time to writing some high-level documentation on managing keyboard focus in Flutter.

cc @gspencergoog

Thanks for filing this with the comprehensive list, @mleonhard.  I've added it to our task list, and we will definitely address this.

I'm working on developing some of the additional docs and examples that are needed, but some of your use cases are currently not supported by Flutter:
Determining when the keyboard is visible and update the display accordingly.
The software keyboard on Android doesn't give any event when it is hidden by the user.  The view insets get updated, but it's a generic size update, and we don't have any way to know if it was because of the keyboard disappearing or not. Regardless, we've been able to detect the keyboard state in some apps by looking at the MediaQueryData.viewInsets, because virtually the only reason those change is because a keyboard is visible.
Keeping the keyboard on screen
Keeping the keyboard on the screen if it's already visible is something we should be able to do, but it's not currently supported by the framework. We have a TextInput class and a TextInputConnection that it produces, but the framework currently only has a concept of the focused control having a text input connection, and only one thing can have primary focus at a time, so we'd have to introduce something that holds the text connection open during a transition, for instance.
On Android, it's not possible to force the keyboard to be shown, since the user can dismiss the keyboard.
Dismissing the software keyboard on non-Android platforms.
Yes, iOS does have a way to dismiss the keyboard, but we don't have an API for it yet.
Some of these related issues might be of interest to you:
https://github.com/flutter/flutter/issues/46882
https://github.com/flutter/flutter/issues/44681

For "How to use Focus and FocusScope to control focus in an application with multiple widgets.", what kinds of control are you referring to?  Here's what I was going to start with:

Restricting focus to a set of widgets (FocusScope)
Switching focus between two widgets using another widget.

But your request is somewhat general, so I'm not sure what specifics you were missing, or use cases you wanted to see and didn't find.

I think most of these are addressed now.  I'm going to close this, and if you have specific additional issues, please file them separately so we can prioritize appropriately.  Thanks for reporting this!


Added New Brach For Color Input

Color Input with Custom Color Picker

It still has some small bugs but it's for review.

We can customize picker as per our need. also a custom inputs. Which can see by runing app/color-inputs of color-picker branch.

Thanks for the contribution! However, instead of maintaining a custom color picker, I had in mind to leverage React Aria Components (RAC) for a more standardized and accessible solution. Their color picker provides robust accessibility features out of the box, which would simplify our implementation and reduce our maintenance overhead.


convert inline links to references?

Context
I'm an apologetic reference link fan. For me, they make the source document easier to read, and I often send markdown documents by email (for various reasons) where it is particularly important to get those pesky links out of the way.
Proposal
It would be nice if mdformat could (optionally? in a plugin?) completely convert all inline links to references in a document. It's not a simple task, as references might clash with each other, so there needs to be some tracking for that...
I understand if that can't be part of mdformat per se, but I figured i would use this space to open up discussion about this, perhaps someone else has already found and fixed that problem themselves?
Thanks!
Tasks and updates
No response

Super interested by this as well. Would be happy to try and send a PR if a maintainer can provide some initial guidance :smile:

Would love to see this - but it does mean this tooling needs to make very opinionated decisions about how to make the translation from inline -> reference links work

what is the ID system enforced? ( [text used][ID])
what is the location of reference links in a page? (always at the end?)

how are references sorted? (ID alphanumeric decending?)

is the inverse possible? (replace ID with URL)

Good questions.

ID system: I'd say, use the text as-is, i.e. [some text] or [some text][], and [some text]: url. The user can then change the ID and mdformat would respect it next times it formats.
location: I think it currently always puts all references at the end of the page
sorting: I'd say sort on IDs yes, lower case, 0 -> 9 then a -> z
seems doable. Might be done in later PRs?

We just need updates from maintainers :slightly_smiling_face: I offered help for another issue but didn't get any answer :confused:

Fun fact: mdformat was inline links only originally https://github.com/executablebooks/mdformat/issues/32

This shouldn't be hard to do at all. Mdformat already places references at the end of the document, orders alphabetically, canonicalizes labels to lower case etc. so much of what has been discussed here is already implemented.
It's just that we have to come up with the link label completely on our own.

I'd say, use the text as-is

This isn't a good enough spec. The link text can be empty string, link label cannot. Link text is unlimited in size, link label is limited to 999 characters. There's probably more pitfalls.
An alternative is to number the labels, 1, 2, 3, 4, ... . There are certainly documents that have more than 1000 links though.
So I think in extreme cases we probably have to resort to some kind of hash values.
So I'm not sure about this at all.

Maybe even more importantly, I have a feeling there's more users that don't want this feature than those who do. I may be wrong. If there's anyone who has a use case where this feature would really suck, please write in this thread! :smile:
In any case, the plugin API remains to be there for people who want to extend mdformat.

Thanks for the update @hukkin, and for pointing out the shortcomings of the proposal :slightly_smiling_face: I might try to write a plugin for that! That would be a good first exercise to get to know mdformat's internals :smile:


Transfer issues from Q/A Spreadsheet

Copy genuine unfinished items from the Drought Q/A spreadsheet to this project board.  Spreadsheet is here: https://docs.google.com/spreadsheets/d/1sFu73FKCAXIKzQC8ewBNWx9WeAe-rl4NIrVLugRHfdE/edit#gid=0

Done.


vscode.debug API should provide the current thread/stack frame ids

Currently the vscode.debug API provides a way to send custom events to debug adapters. But it is missing one fairly important thing - there is no way to know what the current thread id / frame id is. So a debug adapter could maybe guess. But it feels like there should really be a way to query this.

Hi @hediet, I noticed you self-assigned this recently. I was wondering, is there any kind of plan as to what an eventual API on this might look like? I also wanted to check that this feature request is the same one discussed on a different repo here. Is the idea here to allow access to the ID of the "current" stack frame in the sense of the one that the user has selected in the VS Code debugger view in the sidebar?

It is unclear if this ever gets implemented, but I have a personal interest in it, thus I assigned it to myself to keep track of it.

@elazarcoh In principle we are willing to accept a PR. But since this is extension API it has to go through our extension API review process.
The first thing we need is an API proposal.

is it something I can start? or it is something that is done only internally

Hello,
I also need the feature (get the current user selected frame id) in order to update the windows of the debugger extension (especially for multi-core devices). Does this feature make progress? Is there any workaround to get the frame id?

@PaDebug if you'd like to help, you can write the API proposal. That would be the first step.

@elazarcoh  What do I need to do to write the API proposal?
I would propose extending the debug namespace by an event which fires when the user selected a different stack frame in the call stack window. For example:
export namespace debug {
/**
 * An event which fires when the user selected a different stack frame in the call stack window.
 */
export const onDidChangeSelectedStackFrame: Event<StackFrame>;

}
The interface StackFrame consists of two properties: frameId and associated threadId. This would provide enough information to update the thread and stack frame in the Debug Adapter via custom request.
export interface StackFrame {
/**
 * Id of the associated thread (DAP id).
 */
readonly threadId: number;

/**
 * Id of the stack frame (DAP id).
 */
readonly frameId: number;

}
What do you think about this?

@weinand  will this do?

If this is implemented, it needs to be specific to a session. As in threadId/frameId are not enough. We have to deal with multiple concurrent debug sessions. Needs DebugSession object or at least the sessionId.
Doesn't frameId encapsulate/include threadId from a DA's perspective?

Doesn't frameId encapsulate/include threadId from a DA's perspective?

Yes, but I think you want to expose both so that a VS Code extension could call any DAP API which either took a thread id or a frame id.

@gregg-miskelly @hediet could you tell me what the use case is? And does "current" mean "selected in the UI"?

Yes, "current" means the one selected in the UI.
I originally ran into this when I wanted to implement Set Next Statement in the C# extension before the VS Code UI added support for it. It has also come up when potentially wanting to support a disassembly window (though again, this was solved by building the feature in VS Code instead). My team doesn't have a current need for this, though I still think this is a good idea as this makes the extension API very limited in terms of building any kind of debugger feature. Without this feature, it isn't possible for an extension to make valid DAP requests for lots of feature areas, especially anything involving looking at variables/expression evaluation.

For another use case, I ran into this when trying to develop a debugging extension for Python. One of the features was that you could type in a variable name, or more generally an expression, and you would get back a certain visualization of the value of that expression. In order to do this, the extension sends the expression over the DAP to have Python evaluate it and send the value back. However, the variable, or any variables in the expression have to actually be in scope for this to work.
If the user clicks back to a different stack frame in the UI, they can now view the values of variables in the build-in VSCode debugging panel. Since my extension also allows you to, in a sense, view the values of variables, the user expects to be be able to use it for any variables that they can see in the debugging panel. So I need to know when they switch stack frames to give them that experience. Right now my extension basically maintains a parallel list of stack frames in the UI, so if the user wants to climb back up the call stack and use my extension, they have to click the stack frame in both VSCode's built-in UI and in my extension's UI.

My use case is my debug visualizer extension. When the user selects a different stack frame than the top one, the watch windows and the visualizer window disagree.

I also have a use-case for having additional views participate in the debugging; being able to show a custom "registers" view that tracks with selection, for example. We also have some breakpoint functionality that changes if we're in an active session, and would leverage the active thread to 'scope' which threads for which it is active.
So, I'd want to both interrogate the current/selected thread/stack frame (in session context) and to listen for changes

What would be the next step for moving this forward?  It is required for our use-case, where we are moving an existing debugger to vscode, and need to provide functionality that depends on the frame selection context.
But I believe this would be required more generally for any debugger that wants to provide any custom views that should show information for the selected context.
Ive started a branch based on @elazarcoh 's original branch, proposing this UI, just to test, and would propose the API below.
https://github.com/mblout/hx-vscode/tree/mblout/debug-selection-63943
@weinand How are API change discussions driven, by the issue topic "api-proposal"?
(I haven't attempted to contribute before; can i add "api-proposal". @hediet  Should i assign this to me?)
	export namespace debug {
	  /**
	   * An event describing UI selection changes
	   */
		export type DebugFocusType = 'thread' | 'stackFrame' | 'empty';
		export interface DebugFocus {
			readonly type: DebugFocusType;
			/**
			 * Id of the debug session (DAP id). May be undefined if terminated, etc.
			 */
			readonly sessionId?: string;

			/**
			 * Id of the associated thread (DAP id). May be undefined if a session is selected, but no thread of frame is (this
			 * state is not currently possible in the UI)
			 */
			readonly threadId?: number;
			/**
			 * Id of the stack frame (DAP id), if applicable. May be undefined if a thread is selected, but no frame is (this
			 * state is not currently possible in the UI)
			 */
			readonly frameId?: number;
		}
		/**
		 * The currently focused thread or stack frame id, or `undefined` if this has not been set. (e.g. not in debug mode).
		 */
		export let focus: DebugFocus | undefined;

		/**
		 * An {@link Event} which fires when the {@link debug.focus} changes. Provides a sessionId. threadId is not undefined
		 * when a thread of frame has gained focus. frameId is defined when a stackFrame has gained focus.
		 */
		export const onDidChangeDebugFocus: Event<DebugFocus | undefined>;
	}

Hopefully, we get some traction on this. I have been waiting nearly three years for this. So many exciting things can happen with this.

Looking at https://github.com/microsoft/vscode/compare/main...mblout:hx-vscode:mblout/debug-selection-63943, I think this is a reasonable proposal. I think that we could move forward with getting this into vscode as proposed API. I can't give any guarantee on how quickly we can stabilize that API but I think we could give you all something to experiment with and see if it properly fits your scenarios.
Info about frame/thread/session is exposed to API as context for contributed context menu actions in the callstack view. I think we should have extension API that matches that, which is set up here:
https://github.com/microsoft/vscode/blob/80026b700aaa26f1e280678f0011b3f7afa68ee5/src/vs/workbench/contrib/debug/browser/callStackView.ts#L56-L85
And I think I'd like to see three types here instead of one type with some optional properties that are only valid in certain combinations.
Also we should be more specific, maybe say callstackFocus and onDidChangeCallstackFocus. I wish there was one word that could mean "thread or frame or session", then I would say focusedX.
If you can prepare a PR against the vscode repo, we can get it merged into vscode as proposed API.

Thank you very much @roblourens
I want to make sure I understand; I think you are saying you would like the highlighted code, which sets up the menu item context, to be exposed through this new listener API.  The existing context is 'any' with three properties.
You would also like to see distinct types, and I'm not sure where you mean;
something like this, where each of these types would be what each of those assignXContext functions set up today?
onDidChangeCallStackFocus: Event<SessionContext | ThreadContext | StackFrameContext | undefined>

or are you thinking something like:
onDidChangeCallStackFocus: Event<StackFrameContext | undefined>
onDidChangeCallThread: Event<ThreadContext | undefined>

@roblourens i separated the listener registrations and event types into two more specific ones; hoping this is more like what you're suggesting. (I wasn't sure about: the menu item context example seems to be type-less, with optional properties, and wasn't sure how to reconcile that with the rest of you comment)
Thank you for your comments! Maybe you could take a quick look before I do a PR
https://github.com/mblout/hx-vscode/blob/mblout/debug-selection-63943/src/vscode-dts/vscode.proposed.debugFocus.d.ts

Sorry, I meant more like the way you had it initially with a single event and focus property, like your first example
onDidChangeCallStackFocus: Event<SessionContext | ThreadContext | StackFrameContext | undefined>
"Context" doesn't have to be part of the name. Also, instead of sessionId, you can use a session property of the type  DebugSession that already exists

@roblourens Thanks again! I still have some questions, but thought it might be easier to just create the PR and work through it there: https://github.com/microsoft/vscode/pull/179132
I did switch back to the one listener registration, and a 'union' event type.  But kept "Focus" in the name for the type to have it be distinct from other types elsewhere, and did not include DebugSession in the union, as that can be listened to elsewhere.  (But maybe the PR it the place...). Happy to hear all feedback.
re: paperwork, wasn't sure how to associate the pr with the issue, not sure if someone needs to assign to me? Let me know if i'm missing some steps, etc, Also let m e know if there's anything I can do to facilitate (meeting, etc).
(Looking forward! This is critical for us to move forward, and I expect it really does open up some interesting and obvious debug enhancements.)

Does anybody also need to react to the selected debug configuration in the dropdown? There is also a feature request for this- I'm less enthusiastic about that, it seems unexpected to have the dropdown do anything other than decide which launch config to start. But another extension has a usecase where it signals which platform and arch you are targeting and so they can change up the UI based on that information. If you would also use that here it might make sense to tackle it at the same time.

Seems like an unrelated feature to me; I would suggest it should be a separate API - I think the distinction between selection related to artifacts related directly to debug UI context is different than "debug-related" UI selection (I think its debatable that it belongs in the 'debug' namespace)
I'd prefer to keep the scope of this change minimal - this is must-have for providing UI that can show information for a thread/stackframe context in sync with the existing views.
(Do you happen to have the issue? I'd like to understand the scenario - i'm not imagining why it changing the UI after launching isn't acceptable. Thanks!)

Verified the proposal exists, re-opening this issue for having a single record of all discussions until finalised.
There are issues with the form of the proposals, namely us not using discriminated unions but old fashioned classes and instanceof-checks

Hi @jrieken , i'm still trying to learn and understand the contribution process, and wanted to understand your comment above;
is there some action I should take for the changes that were part of this PR? https://github.com/microsoft/vscode/pull/179132/files
I see you added a lint rule, and also disabled it for the discriminators in some of the debug types; do these need to change? Thanks!

Instead of using the discriminated type union interfaces for stackFrameFocus, we will use classes, and consumers can check the type with instanceof. If you would like to work on that, go for it, but we can also leave it alone while it's in the proposed state.
If you work on it, the class implementations go in extHostTypes.ts and you can see how this is handled for other APIs.

thanks for the guidance! i took a stab at it here: https://github.com/microsoft/vscode/pull/181244
i was uncertain on:

is it typical to expose the statis "isXXXXXX" functions as part of the API?
how should I handle checking the "DebugSession" property? i added a comment to the pull request

Also, how does a "proposed api" get promoted to first-class API?  And is there any process in which i can participate, or anything i can do?

Wanted to ask if there is anything I can do to make the discussions about promoting this proposed API easier?
Would a runnable demo help, like a vscode-mock-debug pull request?
Animated GIF or other form of doc/example? Thanks again!


comments/commentThread/actions and comments/comment/actions not fully supported

Refs: https://github.com/microsoft/vscode/issues/74472
comments/commentThread/actions and comments/comment/actions seem to be new names for comments/commentThread/context and comments/comment/context. This is great, because the old name is not good - it is not a context menu and can be easily confused.
However the new menu title id simply does not work, while the old one works. So it seems to not be fully supported yet.
The json schema works with the new name actions. Great
Also when updating to the new name make sure to update the comment sample her https://github.com/microsoft/vscode-extension-samples/tree/048fa2f156090c43cbe56bc4e2788aa77c091a5d/comment-sample

Fixed with 2185280ed5783338b418ecdb8f62c4a13a2b560b


DOC-2554 added code samples for set datatype in C#

Code samples for the set datatype doc page.

Closes #212


postgres script generation code

Fixes # .
Changes proposed in this pull request:

@anz-bank/sysl-developers

This pull request adds the capabality

to read the sysl file and generate postgres sql command
comapare two sysl files and generate alter table/create table postgres commands

There are new files added to achieve this. There are two existing files which have been changed.

Types.go - Added a new parameter to the struct ExecuteArgs
ints_test.go - Added a new function named compareSql

@sidhartha-priyadarshi Can I suggest that you close this PR as it is flooded with GolangCI responses, squash + rebase down to a single commit and create a new PR when you're ready.
Also, please run make (or make test ) locally before pushing to minimise GolangCI hassling you.
I'm also happy to sit with you if you want to discuss the required changes to get this merged before the break.

Closing the pull request. Will reopen once the fixes are in place.

@anz-gordonj7 please note. The pull request is closed now. Will raise another pull request when the code is finalized.


I found that when there are linesegment models in the scene, there are many jagged lines that cannot be eliminated...

I found that when there are linesegment models in the scene, there are many jagged lines that cannot be eliminated...

code
let child = [];
sponza.traverse(object => {
if (object.material) {
object.material.envMap = environment;
child.push(object)
}
})
child.forEach(m=>{
m.add(new THREE.LineSegments(new THREE.EdgesGeometry(m.geometry,90)))
})

such as

Both SMAA and fxaa are invalid

I'm afraid post-processing ambient occlusion and (in general) SMAA/FXAA don't work with just lines. Disabling dpeth-write on the lines should help the AO work though.

thank you, it works


Infinite Loading via SWR

Currently, infinite loading is handled via a custom fetch() function. This works, but by leveraging SWR's built in caching, we could potentially decrease the amount of requests to the Reddit API, which is currently capped at 60 hits per minute.

[ ] Refactor <Results /> to use SWR instead of custom fetch()

Note: The SWR library is already installed and used for <Search />

@mayankjx Sure thing!

No longer interested in pursuing this. Closing.


AT+CIPSERVERMAXCONN

Hello.
In last commit I saw about AT+CIPSERVERMAXCONN. Can you provide more info? Is it related to https://github.com/espressif/esp32-at/issues/28 ?
Will it be possible to run server on multiple ports by specifying which connection accepts on which port? For example CONN0 port 80, CONN2 port 400, etc?
Will this also work on ESP8266 AT software?
Thanks for response.

Hi @MaJerle ,
This command is configured with the maximum connection of the server accept. For example, if AT allows 5 connections, and I send AT+CIPSERVERMAXCONN=3, so there are two connection is reserved for client. By the way, there is a bug about this in idf, and we are debugging it.
I think this satisfies #28. And if you have any question or request,just feel free to let me know.Thanks.

This feature does not satisfie #28 because feature 28 allows you to be master to specify exact server connection you want for purpose (for example connection for port). This is allowed by LwIP and therefore should be implemented as new feature to support server on multiple connections each with different port.

Yes,you can set max connection when calling esp_at_module_init().


Release v1.12.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.335%

Totals

Change from base Build<PHONE_NUMBER>3:
0.0%

Covered Lines:
913

Relevant Lines:
938

💛  - Coveralls


Add null() func which makes NULL value in AST builder

cc. @ShaddyDC

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

7 of 7 (100.0%)  changed or added relevant lines in 1 file are covered.
53 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.1%) to 98.543%

Files with Coverage Reduction
New Missed Lines
%

test-suite/src/tester/mod.rs
19
87.5%

core/src/executor/aggregate/mod.rs
34
81.82%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
36929

Relevant Lines:
37475

💛  - Coveralls


setup.py test not installing elements from extra_requires with markers

Steps to reproduce (requires using Python2):
$ git clone https://github.com/alex/cryptography
$ cd cryptography
$ git checkout other-style-environment-markers
$ virtualenv .venv
$ source .venv/bin/activate
$ python setup.py test
[...]
Traceback (most recent call last):
  File "setup.py", line 307, in <module>
    **keywords_with_side_effects(sys.argv)
  File "/Users/alex_gaynor/.pyenv/versions/2.7.13/lib/python2.7/distutils/core.py", line 151, in setup
    dist.run_commands()
  File "/Users/alex_gaynor/.pyenv/versions/2.7.13/lib/python2.7/distutils/dist.py", line 953, in run_commands
    self.run_command(cmd)
  File "/Users/alex_gaynor/.pyenv/versions/2.7.13/lib/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()
  File "/Users/alex_gaynor/.virtualenvs/tempenv-465426949608b/lib/python2.7/site-packages/setuptools/command/test.py", line 210, in run
    with self.project_on_sys_path():
  File "/Users/alex_gaynor/.pyenv/versions/2.7.13/lib/python2.7/contextlib.py", line 17, in __enter__
    return self.gen.next()
  File "/Users/alex_gaynor/.virtualenvs/tempenv-465426949608b/lib/python2.7/site-packages/setuptools/command/test.py", line 153, in project_on_sys_path
    require('%s==%s' % (ei_cmd.egg_name, ei_cmd.egg_version))
  File "/Users/alex_gaynor/.virtualenvs/tempenv-465426949608b/lib/python2.7/site-packages/pkg_resources/__init__.py", line 971, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/Users/alex_gaynor/.virtualenvs/tempenv-465426949608b/lib/python2.7/site-packages/pkg_resources/__init__.py", line 857, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'ipaddress' distribution was not found and is required by cryptography

You can see the patch that triggers this here: https://github.com/pyca/cryptography/pull/3796

So, the problem appears to be here: https://github.com/pypa/setuptools/blob/master/setuptools/command/test.py#L188-L196
extras_require is totally ignored -- I don't know the setuptools code quite well enough to know where to find the code that processes extras_require though.

If you're using setuptools < 36.2.0, then you can put those requirements in install_requires:
 setup.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git i/setup.py w/setup.py
index fec78409..c929cace 100644
--- i/setup.py
+++ w/setup.py
@@ -279,12 +279,12 @@ setup(
         "idna >= 2.1",
         "asn1crypto >= 0.21.0",
         "six >= 1.4.1",
+        "enum34; python_version < '3'",
+        "ipaddress; python_version < '3'",
+        "cffi >= 1.7; python_implementation != 'PyPy'",
     ],
     tests_require=test_requirements,
     extras_require={
-        ":python_version < '3'": ["enum34", "ipaddress"],
-        ":python_implementation != 'PyPy'": ["cffi >= 1.7"],
-
         "test": test_requirements,
         "docstest": [
             "doc8",

Except generated wheels won't be correct, because markers are stripped from the metadata.  setuptools >= 36.2.0 aims to fix that by automatically moving requirements in install_requires that are using markers to extras_require, which of course is problematic with this use case...

@benoit-pierre Yeah... I would love nothing more than to do it that way, unfortunately setuptools + pip gained support for the extras_require version before they gained support for "inline markers", so to avoid breaking quite so much of the world, I'm trying to use the extras_require version.

 setuptools/command/test.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git i/setuptools/command/test.py w/setuptools/command/test.py
index c14b1242..f13cb732 100644
--- i/setuptools/command/test.py
+++ w/setuptools/command/test.py
@@ -11,7 +11,7 @@ from setuptools.extern import six
 from setuptools.extern.six.moves import map, filter

 from pkg_resources import (resource_listdir, resource_exists, normalize_path,
-                           working_set, _namespace_packages,
+                           working_set, _namespace_packages, evaluate_marker,
                            add_activation_listener, require, EntryPoint)
 from setuptools import Command
 from setuptools.py31compat import unittest_main
@@ -204,7 +204,11 @@ class test(Command):
         """
         ir_d = dist.fetch_build_eggs(dist.install_requires or [])
         tr_d = dist.fetch_build_eggs(dist.tests_require or [])
-        return itertools.chain(ir_d, tr_d)
+        er_d = []
+        for k, v in dist.extras_require.items():
+            if k.startswith(':'):
+                er_d.extend(dist.fetch_build_eggs(v))
+        return itertools.chain(ir_d, tr_d, er_d)

     def run(self):
         installed_dists = self.install_dists(self.distribution)

Is that correct? It looks like it will install all items in extras_require, regardless of if their marker matches.

Oups! Forgot to actually call evaluate_marker:
if k.startswith(':') and evaluate_marker(k[1:]):

Now to add a test to the testsuite...

Not an expert in the setuptools code, but looks plausible to me!

@benoit-pierre Is this issue still open? It seems like a regression I'd like to correct asap.

@jaraco I don't think this is a regression, although I'd be appreciative if it was fixed quickly :-)

@jaraco: it's not a regression, see #1106.


update iam-auth for 1.24 - 1.28

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm


Bump image crate to v 0.24.0

I needed better WebP support, so I upgraded this to the recently released v0.24.0 of image-rs. Here's the PR in case it's helpful. Thanks for this package btw!

Thanks!


Added learner profile field search

@v-samarth : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Docs Build status updates of commit 072c336:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-community-training/learner-experience/web-app.md
:white_check_mark:Succeeded
View

microsoft-community-training/media/Profile Field - edit from learner view 2.PNG
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

PRMerger Results

Issue
Description

Image File
This PR contains an image file(s).


(rebase) Namespace writing - resolves #52

This rebases #52 to add support for writing namespaces.
Like the original requester I'm open to feedback on this, I just wanted to get that PR updated and ready to either merge, ready for feedback on what else to do, or else reject the whole idea.

Good catches - thanks for the review

It turns out there was a logical issue in #32 - which caused empty elements without a default to get skipped in the output unless they had a default.  I added a failing test of this, confirm that test passed prior to #32, then updated the code added on #32 to make it pass again.

Sorry for the noise - I reset my branch, rebased and reapplied the commits and I think this is ready to look at now.


Crosschasm c5 updates for Cellular device and iOS. Also requires openxc-message-format update.

Globally, can you replace tabs with 4 spaces to match the rest of the code?

Overall - awesome! There's some minor style things, but it's great how neatly this fit into the architecture used in the firmware already.
One concern - there are no unit tests for any of the new code. I'd like to at least see a few basic tests to see that the modem functions are called when it is enabled.

I'll have to talk to @mgiannikouris about some of the larger issues that are still unresolved.
@peplin Do you have docs or recommendations for adding the tests? Also, info on how to run the travis builds locally before doing a push? Is that the recommended way for CI?

Hey Eric, yes there's a couple of quick docs here on the test suite: http://vi-firmware.openxcplatform.com/en/master/testing.html#test-suite
To summarize, each supported platform consolidates its board-specific code under the platforms directory. Thest of the code base is just regular ol' C (with some C++ nicities used sparingly). We also implement those platform-specific functions with test stubs so we can compile everything on a regular x86 architecture with gcc or clang. There are unit and functional tests in the tests directory, and then recently I added a complete integration test suite that runs on the actual hardware. That level of testing is probably practical for this case, since it would involve an external server.

I did see your changes, it's looking good. Short of adding new tests, could you try and make it compile OK with the test suite we run in CI? Everything has to compile with the clang compiler (it gives very nice warnings which act as a linter for C/C++). You can see the errors from CI through the red links above in this PR ^^^.


youtube-dl: 2<IP_ADDRESS> -> 2020.07.28

https://github.com/ytdl-org/youtube-dl/releases/tag/2020.07.28

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Thanks! Backported as eeb91b03a5cef25c3931bdd4438f006a293adef9 to stable.


[home page navigation]

Description
Issue
When I visited the website and went to the next pages then I realized that we have to go to the previous button to go to the home page i.e. 1st page of the website, our time is wasted in doing this so have a solution.
solution
we can add the functionality of navigating the home page by clicking on the logo of the website, it will save time.
Screenshots

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSoC'24 contributor.
[X] I want to work on this issue.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

@Akshatakapare This issue has been resolved already


go get build error

Hi, looks like the latest master doesn't install through go get.
$ go get -u github.com/stamblerre/gocode
# github.com/stamblerre/gocode/internal/suggest
../../go/pkg/mod/github.com/stamblerre/gocode@v0.0.0-20181016172724-12640289f650/internal/suggest/suggest.go:130:3: cannot use func literal (type func(*token.FileSet, string, []byte) (*ast.File, error)) as type func(*token.FileSet, string) (*ast.File, error) in field value

What version of Go are you using (go version)?
go1.11.1 darwin/amd64
What operating system and processor architecture are you using (go env)?
macOS 10.14 Mojave

Based on the error message, I think you need to update your version of golang.org/x/tools, because the go/packages API changed to include a 3rd parameter in that function.

Ah! I had overlooked that with being in a bit of a hurry at the time. Thanks and apologies for the issue!


Add additional startup code required by #455

We weren't loading extensions (or calling our sanity-check routines), so
calling populate() in haas init_db was throwing an exception.
Since we obviously need some tests for basic stuff like this, this patch
adds a few that try to verify that the server-side commands work
correctly.

Other than my comments, looks good.
Have you run the full deployment tests with this?

Re: tests, the cli module previously had zero test coverage --- the deployment tests don't interact with any of the code modified by this patch (nor do any of the other tests, save the ones introduced in this patch).

I made the change to api_server_init that @henn suggested. I've also merged in the stuff on #478, since I needed 668b3d9; This may complicate the order in which to merge these, since now this pr has commits on either side of that, but at least it's linear...

+1

+1 and merging


ReDoS Middleware

Is your feature request related to a problem? Please describe.

https://owasp.org/www-community/attacks/Regular_expression_Denial_of_Service_-_ReDoS
Describe the solution you'd like

Describe alternatives you've considered

Additional context

This should be done on the infrastracture level rathen than application


Fix issue 123: Repeated reserialization of DAGs

Issue #, if available: #124
Description of changes
Issue #124 happens because we are always calling airflow db migrate to make sure the database is migrated. The assumption was that the operation is a no-op if the DB is already initialized. However, this is not the case, and a reserialization of DAGs is happening every time this command is called. To avoid this, I am changing the code for executing migration to check if migration is needed.
Testing
I did multiple tests using the Docker Compose setup. More testing by Amazon MWAA developers before this PR is merged. Suggested testing:

Create an internal 2.9.2 environment and make sure it is functioning normally. Also check ECS logs to ensure there are no issues.
Create a pre-2.9.2 environment and do an in-place upgrade to 2.9.2 and make sure the process is flawless.
Run a 2.9.2 environment with auto scaling enabled (ensuring that workers are being created and terminated continuously) and make sure migrations are not causing any issues.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

When it's merged, will MWAA 2.9.2-based instances be automatically updated? We are also affected by https://github.com/apache/airflow/issues/40082 and waiting for the fix before we propagate upgrade from 2.8 to 2.9 on PRD

When it's merged, will MWAA 2.9.2-based instances be automatically updated? We are also affected on DEV & UAT environments by apache/airflow#40082 and waiting for the fix before we propagate upgrade from 2.8 to 2.9 on PRD

Unfortunately no, you would need to trigger an environment update to have the Docker containers updated. Even a no-op update would do, though, so it should be pretty easy to do.

@rafidka sure, that's not an issue. Are changes immediately propagated to MWAA after merging PR or is there any build- / deployment-related delay we have to take into consideration before we can trigger an update and test new containers?

Are changes immediately propagated to MWAA after merging PR or is there any build- / deployment-related delay we have to take into consideration before we can trigger an update and test new containers?

After the PR is merged, we sync it internally and deploy it via internal pipelines where it goes through testing, and then becomes available to different regions around the world gradually. Usually, assuming no test failures or pipeline blockages, this takes a couple of days. I am currently out of office, but @dhegberg should be able to help you with status updates. Daniel, we need to have this PR merged asap, as it is a production issue for our customers.

MR is merged, so asking for the status update then 😄 Can we proceed with the re-deployment or nor yet?

@Mercury2699 - can you confirm if this has been deployed to all the waves/regions?

@jaklan Yes, this fix has been deployed to all regions. Customers can trigger environment update to receive the latest image.


stm32h7: more progress on dual core

Add *cm4 target. This has identical registers to the *cm7
equivalent, but different interrupts
Fix error in RCC GCR relating to C-M4 core
Add dualcore parts of DBGMCU peripheral
Add dualcore parts of EXTI peripheral
Fix EXTI register access for dual clore

Still TODO

Add dualcore parts of SYSCFG

We already combine e.g. STM32F405 and STM32F415 in the stm32f405 module where the only difference is CRYP, and the same goes for most existing crypt/no-crypt families I believe

I would support combining too, with hindsight. ST does split the SVDs in this case, but the only difference really is the HASH and CRYP peripherals. We should combine H74xx and H75xx across the family at the same time.
I'd suggest naming the combination H747 etc, even though H757 is the superset. Mostly to help new users find it, as the H747 parts are more popular and common - eg. the program-it-in-javascript thing Arduino are touting at CES

ST does split the SVDs in this case

Aren't we copying the same source file stm32h7x5_cm{4,7}.svd into two different files for cryp/no-cryp?

I'd suggest naming the combination H747 etc, even though H757 is the superset. Mostly to help new users find it, as the H747 parts are more popular and common - eg. the program-it-in-javascript thing Arduino are touting at CES

This sounds good. Do you want to do it in this PR? It looks like recombining 747/757 should be ok?

This sounds good. Do you want to do it in this PR? It looks like recombining 747/757 should be ok?

Sure, combining the dual core parts here ⬇

Thanks, this all looks good and ready to merge. Please could you fix the merge conflict?


Update pattern to work on Windows Server versions

I have updated the pattern to work on both Windows Desktop and Windows Server versions. In Windows Server versions, the
pattern was causing compatibility issues due to a change in the 10th byte. The previous pattern was
{ 0x48,'?','?', 0x74,'?',0x48,'?' ,'?' ,0x74,'?' ,0x48,'?' ,'?' ,'?' ,'?',0x74,0x33 },

I have updated the pattern to { 0x48,'?','?', 0x74,'?',0x48,'?' ,'?' ,0x74 } which is now compatible with both Windows Desktop and Windows Server versions.


Using dhall for governance

Thank you @Gabriel439 for the talk. I'm interested in how Dhall is being used for governance.  Is there a sample org doc or contract? This could be a "killer app".
https://youtu.be/ikEx56F6g1M?t=6249

I was referring to this: https://twitter.com/buchmanster/status/1343743673817829377

Thank you again!

You're welcome! 🙂


Wiki Migrations

Description
The slow process of moving it all.


Introduce a script to add rulesets

Use it to introduce a few from BazelCon
Fixes #15

maybe we also want to update the jq script so that it keeps the data sorted?

I guess one advantage of sorting is that it is less likely that PR's to this will conflict


Blocks not filling in space

Hi,
I'm having trouble getting the masonry to work right. Sometimes, my rows aren't being completely filled by blocks, and an empty block is rendered. For example, I've set the sizes to be [1,1] and [2,1]. But sometimes, when a [2,1] block is rendered on a row, there should be space for a [1,1] block on the right; but in my case it's an empty space.
Here's an example of my issue: http://paperscrunch.com/mason-test/
Any idea why this is happening? Am I doing something wrong? Or is it an issue with bootstrap?

Just quickly looking at this it may be an issue with the transitions - seems that is causing mis-counts so it isn't filling the space properly.

I'm having trouble with fillers too - it doesn't seem to be inserting any. Are we supposed to put the filler dom elements in manually or is it supposed to insert them dynamically. Either way, I can't seem to get them to render to cover gaps.

Working through issues tonight.
Mason will do 1 of 2 things:

If no filler is specified it will copy at random elements from the grid to use as fillers.
If you specify a filler this should be a dom element that is available for mason to use via a class name.


Parse neuroglancer layers

parse ngl layers
create bounding boxes from annotations

What do you think about the interface of ngl_state being two functions:

Yeah that sounds good. So the return type of read_remote_annotations would be List[Union[BoundingCube, Vec3D]]?

I think List[Union[BoundingCube, Vec3D]] should be good -- maybe somebody will need a mix at some point.

Actually this is the result of rebasing. There were multiple conflicts.
On Sat, Dec 3, 2022, 10:17 PM supersergiy @.***> wrote:

@.**** approved this pull request.
This is really solid!
The only thing is that github shows that 108 files have changed, so it
took some effort to figure out what actually changed. I think rebasing
main instead of merging should make it better
—
Reply to this email directly, view it on GitHub
https://github.com/ZettaAI/zetta_utils/pull/118#pullrequestreview-1203599399,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACPB7HXBNVQVFKJAZU2BY5TWLQLL3ANCNFSM6AAAAAASHKOD44
.
You are receiving this because you authored the thread.Message ID:
@.***>

closing in favor of #141


Fix nginx syntax to disable error logs

Setting error_log to off will create a file named off in the directory where nginx is running.
See: https://www.wpoven.com/tutorial/how-to-disable-nginx-logs-on-your-server/

Closing due to lack of interest.


SDFSOF-64-PR1: RPC Actions: implement logic and validations

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What
RPC actions and unit tests:

notify_interactive_flow_completed
request_offchain_funds
request_onchain_funds
notify_onchain_funds_received
notify_offchain_funds_received
notify_offchain_funds_sent

Why
RPC actions should replace PATCH /transactions endpoint
Known limitations
[TODO or N/A]

Reference Server Preview is available here:https://anchor-ref-pr976.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr976.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr976.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr976.previews.kube001.services.stellar-ops.com/

I will merge this PR and create new one (fireblocks_integration -> softserve-develop) as soon as https://github.com/stellar/java-stellar-anchor-sdk/pull/969 is approved

Reference Server Preview is available here:https://anchor-ref-pr976.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr976.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr976.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr976.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr976.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr976.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr976.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr976.previews.kube001.services.stellar-ops.com/


Homework 5

drift https://video.drift.com/v/abzpcKT0kEOseu3K6ipLyEhjcc4IR6TLJsJIJP81bMJg/

Metric
Value

alert_status
b:white_check_mark: OK/b

bugs
6

code_smells
11

reliability_rating
E (at least 1 Blocker Bug)br/Note: A being best, E being worst

security_rating
A (0 Vulnerabilities)br/Note: A being best, E being worst

vulnerabilities
0


chore(deps): update terraform terraform-ibm-modules/base-ocp-vpc/ibm to v3.30.0

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/base-ocp-vpc/ibm (source)
module
minor
3.29.3 -> 3.30.0

Release Notes

terraform-ibm-modules/terraform-ibm-base-ocp-vpc (terraform-ibm-modules/base-ocp-vpc/ibm)
v3.30.0
Compare Source
Features

Introduce support for managing the default worker pool (#499) (1207679)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 1.4.25 :tada:
The release is available on:

GitHub release
v1.4.25

Your semantic-release bot :package::rocket:


conditional copy command added

*Issue #41 *
Description of changes:
This issue occurs when there is no file/dir in /var/lib/docker/ . This change will check if that dir contains something before firing cp command.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

closed in #57


[Issue-3463] Extension - Add validate for Solochain when receive, transfer with Generic ledger account

Related issue(s)

#3463

Is your feature request related to a problem(s)? Please describe.

Extension - Add validate for Solochain when receive, transfer with Generic ledger account

Describe the solution you'd like

Extension - Add validate for Solochain when receive, transfer with Generic ledger account

Describe alternatives you've considered

No

Additional context

No

🚀 Deployed on https://pr-3464--sw-web-runner.netlify.app


Add high level comments

Looks great. I am hoping to get #12 taken care of today. If for some reason I can't I will fix up the dom-module comment. Thanks for your help.


[Bug]: type-hinting for ManyArgumentsExpression is wrong

What happened?
Nothing major, the type hinting for ManyArgumentsExpression is currently:
     * @param  non-empty-array<int, \Illuminate\Contracts\Database\Query\Expression>  $expressions

rather than
     * @param  non-empty-array<int, string|\Illuminate\Contracts\Database\Query\Expression>  $expressions

This works but complains:
new Coalesce(['assignments.ends_at', 'contracts.starts_at']);

This works as expected
new Coalesce([new Expression('assignments.ends_at'), new Expression('contracts.starts_at')]))
ManyArgumentsExpression deliberately supports string or Expression and via use of the StringizeExpression trait
How to reproduce the bug
new Coalesce(['assignments.ends_at', 'contracts.starts_at']);
vs
new Coalesce([new Expression('assignments.ends_at'), new Expression('contracts.starts_at')]))
Package Version
0.7.0
PHP Version
8.1
Laravel Version
10.19
Which operating systems does with happen with?
Windows
Notes
No response

Fixed with release 0.7.1


Update repo-sync/pull-request ref to version that outputs pr_number

Fixing https://github.com/Expensify/Expensify/issues/157916
Follow-up to https://github.com/Expensify/Expensify.cash/pull/2329
Failed workflow run: https://github.com/Expensify/Expensify.cash/commit/e16252f47640d5ba5328d979a3f3c4bea746545d/checks
What happened? I was relying on an output from the repo-sync/pull-request action that didn't exist in the commit hash we were pointing to. So this PR just updates our action to point at the latest commit hash: https://github.com/repo-sync/pull-request/commits/master

This is exactly the kind of thing you just won't catch without actual testing.

🚀 Deployed to staging in version: 1.0.43-9🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production in version: 1.0.44-0🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Huffman Coding

Huffman Coding is available in the following language:

Java

@Kumar-laxmi
Can you assign me this issue? I will try to solve this using Java

Assigned!
@Priyanshu-Singh-1 : Java

Assign me this issue i will do it in Python.

@Priyanshu-Singh-1 What is your status because it has been 3 days since you were assigned this issue

@Kumar-laxmi
I have completed my part, but I am not creating the PR because for the 4 issues I have created the PR that has not been merged. Also, it is becoming little chaos, when during merging. This is the PR I am talking about: #184
So, if you still want I can add my this part to the previous PR. My suggestion is to merge that PR since you have already approved it. So, that I can create a new one for this issue.
@Kumar-laxmi Please tell what to do, so I add my part now, or wait for the previous PR to get merged ?

@Kumar-laxmi
I have also added the Huffman coding in java.
This is the PR containing the mentioned issue. #184

This algorithm has been implemented in all four languages


Transfer files from current Github repo

Currently working out of https://github.com/rladies/tutorials_deep-learning-with-r-ladies/ need to transfer files over to this repo.

Done with Pull Request #6


feat(hits): allow configuring hitsPerPage

allow configuring hitsPerPage on hits widget
rewrite a little of the hits widget to only use what we need to use (may have to expose more things in the future, like the query done in the empty template)
rename noResults in the widget API to empty (typeahead style)
removed hitsPerPage configuration from the pagination template
some linting and deps upgrade for free

I am sorry I also included some fixes that are not directly related to the feature. Still in hard ptotoyping mode :dancer:

LGTM!


Week 18 Review Ticket - Shreya Sapkal

CPT Scoring Assignment #2
Individual Notes & Hacks for Model and Object-Oriented Programming
Individual Notes for View and Frontend Coding
Team work from the week

CPT grading seems a little difficult with columns being free form on why they got point.  0/1 grading is you have it or not.   Your summary is excellent, the objective of these reviews is personalization.   You show that in your reflection/summary.

0/1 - Summary is great but I am a bit confused on your criteria, there is a lot of personalization
0/1 - Your backend is great but I see no tester code, you also need to explain how your code works like self, constructor, etc.
1/1 - Your frontend is good and I see good progress for the website -  You understand the criteria and evaluations of CPT. Also, we want to see how understanding scoring of these examples will help you exceed CPT requirements.
Total: 1/3

OOP Hacks and Code: 1/1
CRUD Frontend: 1/1
CPT Grading: 1/1
Comments: Shreya, I really enjoyed all parts of your code. I'm assuming your group is doing a program on searching brands of cars, and I think you have developed both your OOP backend code with individualized class, attributes, and features. I do think the individual OOP code could be developed much further. I also liked how you updated your page with login/signup systems, with detail on the visual design. CRUD is definitely established. CPT scoring does really need checkboxes or another way to show that the requirements of CB are being met. Even if one or two of the final requirements weren't met here, you have proven that work is being done.


Add performance monitoring

An event that I don't think has been included is number of instruction bytes executed in order to evaluate how good a job instruction compression is doing.


Bumping extension ES version 2018 -> 2019

Pull Request Test Coverage Report for Build 421598676

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 43.165%

Totals

Change from base Build 421419736:
0.003%

Covered Lines:
24110

Relevant Lines:
51208

💛  - Coveralls


[M68000] CHK.W instruction Pcode is "UNIMPLEMENTED"

Describe the bug
Pcode is not generated for a CHK.W instruction. (68030 mode). This prevents the decompiler from decoding any function which uses it.
To Reproduce
Steps to reproduce the behavior:

Decompile the attached code block.
Note that Ghidra fails to disassemble the CHK instruction into Pcode.

Expected behavior
CHK instruction is represented correctly in Pcode, or at least represented as a no-operation so the decompiler doesn't fail.
Screenshots
        00463b4c 04 40 00 30     subi.w     #0x30,D0w
                                                      (register, 0x47, 1) = INT_LESS (register, 0x2, 2), (con
                                                      (register, 0x46, 1) = INT_SBORROW (register, 0x2, 2), (
                                                      (register, 0x43, 1) = COPY (register, 0x47, 1)
                                                      (register, 0x2, 2) = INT_SUB (register, 0x2, 2), (const
                                                      (register, 0x44, 1) = INT_SLESS (register, 0x2, 2), (co
                                                      (register, 0x45, 1) = INT_EQUAL (register, 0x2, 2), (co
        00463b50 41 bc 00 2a     chk.w      #0x2a,D0w
                                                      UNIMPLEMENTED
        00463b54 e3 40           asl.w      #0x1,D0w
                                                      (unique, 0xf300, 4) = INT_SUB (const, 0x10, 4), (const,
                                                      (unique, 0xc180, 2) = INT_RIGHT (register, 0x2, 2), (un
                                                      (unique, 0xc200, 2) = INT_AND (unique, 0xc180, 2), (con
                                                      (register, 0x47, 1) = INT_NOTEQUAL (unique, 0xc200, 2),
                                                      (register, 0x2, 2) = INT_LEFT (register, 0x2, 2), (cons
                                                      (register, 0x44, 1) = INT_SLESS (register, 0x2, 2), (co
                                                      (register, 0x45, 1) = INT_EQUAL (register, 0x2, 2), (co

Environment (please complete the following information):

OS: Ubuntu 20.04.2 LTS
Java Version: 11.0.10 (OpenJDK)
Ghidra Version: Seen with 9.2.2 and current Git HEAD.
Ghidra Origin: 9.2.2 from ghidra-sre.org, Git build built locally from Git repository.

@philpem a bit late to the party, but would something like this work for you (replace the definitions for both chk.l and chk.w in 68000.sinc on your installation with this):
:chk.w eaw,reg9dnw		is (op=4 & reg9dnw & op68=6 & $(DAT_ALTER_ADDR_MODES))... & eaw {
  local signed_register:2 = sext(reg9dnw);
  local signed_bound:2 = sext(eaw);

  if ((signed_bound s>= 0) && (signed_bound s<= signed_register)) goto inst_next;
  NF = signed_bound s< 0;
  local chkvector:1 = 6;
  __m68k_trap(chkvector);
}

:chk.l eal,reg9dn		is (op=4 & reg9dn & op68=4 & $(DAT_ALTER_ADDR_MODES))... & eal {
  local signed_register:4 = sext(reg9dn);
  local signed_bound:4 = sext(eal);

  if ((signed_bound s>= 0) && (signed_bound s<= signed_register)) goto inst_next;
  NF = signed_bound s< 0;
  local chkvector:1 = 6;
  __m68k_trap(chkvector);
}

If so I can extend this for CHK2 and CMP2 as well and make a PR out of it...

Looks fine to me, @agatti!


Building package folly:x64-windows failed with: BUILD_FAILED

Package: folly:x64-windows
Vcpkg version: 0.0.105-2018-03-17-33a8ee0a88b277dab4be336169f4b975f8c41cbb
λ Gvcpkg.exe install folly:x64-windows
The following packages will be built and installed:
folly[core]:x64-windows
Starting package 1/1: folly:x64-windows
Building package folly[core]:x64-windows...
-- CURRENT_INSTALLED_DIR=G:/vcpkg/vcpkg/installed/x64-windows
-- DOWNLOADS=G:/vcpkg/vcpkg/downloads
-- CURRENT_PACKAGES_DIR=G:/vcpkg/vcpkg/packages/folly_x64-windows
-- CURRENT_BUILDTREES_DIR=G:/vcpkg/vcpkg/buildtrees/folly
-- CURRENT_PORT_DIR=G:/vcpkg/vcpkg/ports/folly/.
-- Warning: Dynamic building not supported yet. Building static.
-- Using cached G:/vcpkg/vcpkg/downloads/facebook-folly-v2<IP_ADDRESS>.tar.gz
-- Testing integrity of cached file...
-- Testing integrity of cached file... OK
-- Extracting done
-- Applying patch G:/vcpkg/vcpkg/ports/folly/cmake-link-boost-fix.patch
-- Applying patch failed. This is expected if this patch was previously applied.
-- Applying patch G:/vcpkg/vcpkg/ports/folly/cmake-link-boost-fix.patch done
-- Applying patch G:/vcpkg/vcpkg/ports/folly/msvc-15.6-workaround.patch
-- Applying patch failed. This is expected if this patch was previously applied.
-- Applying patch G:/vcpkg/vcpkg/ports/folly/msvc-15.6-workaround.patch done
-- Configuring x64-windows
-- Configuring x64-windows done
-- Build x64-windows-dbg
CMake Error at scripts/cmake/vcpkg_build_cmake.cmake:129 (message):
Command failed: G:/vcpkg/vcpkg/downloads/cmake-3.10.2-win32-x86/bin/cmake.exe;--build;.;--config;Debug;--target;install;--;-v;-j1
Working Directory: G:/vcpkg/vcpkg/buildtrees/folly/x64-windows-dbg
See logs for more information:
G:\vcpkg\vcpkg\buildtrees\folly\install-x64-windows-dbg-out.log
Call Stack (most recent call first):
scripts/cmake/vcpkg_install_cmake.cmake:24 (vcpkg_build_cmake)
ports/folly/portfile.cmake:48 (vcpkg_install_cmake)
scripts/ports.cmake:72 (include)
install-x64-windows-dbg-out.log

i use vcpkg install folly:x64-windows --head，it build failed too.
λ vvcpkg install folly:x64-windows --head
The following packages will be built and installed:
folly[core]:x64-windows (from HEAD)
Starting package 1/1: folly:x64-windows
Building package folly[core]:x64-windows from HEAD...
-- CURRENT_INSTALLED_DIR=G:/vcpkg/vcpkg/installed/x64-windows
-- DOWNLOADS=G:/vcpkg/vcpkg/downloads
-- CURRENT_PACKAGES_DIR=G:/vcpkg/vcpkg/packages/folly_x64-windows
-- CURRENT_BUILDTREES_DIR=G:/vcpkg/vcpkg/buildtrees/folly
-- CURRENT_PORT_DIR=G:/vcpkg/vcpkg/ports/folly/.
-- Warning: Dynamic building not supported yet. Building static.
-- Purging cached G:/vcpkg/vcpkg/downloads/facebook-folly-master.tar.gz to fetch latest (use --no-downloads to suppress)
-- Downloading https://api.github.com/repos/facebook/folly/git/refs/heads/master...
-- Downloading https://api.github.com/repos/facebook/folly/git/refs/heads/master... OK
-- Skipping hash check for G:/vcpkg/vcpkg/downloads/temp/facebook-folly-master.tar.gz.version.
-- Downloading https://github.com/facebook/folly/archive/master.tar.gz...
-- Downloading https://github.com/facebook/folly/archive/master.tar.gz... OK
-- Skipping hash check for G:/vcpkg/vcpkg/downloads/temp/facebook-folly-master.tar.gz.
-- Extracting source G:/vcpkg/vcpkg/downloads/facebook-folly-master.tar.gz -- Extracting done
-- Applying patch G:/vcpkg/vcpkg/ports/folly/cmake-link-boost-fix.patch
-- Applying patch failed. This is expected if this patch was previously applied.
-- Applying patch G:/vcpkg/vcpkg/ports/folly/cmake-link-boost-fix.patch done
-- Applying patch G:/vcpkg/vcpkg/ports/folly/msvc-15.6-workaround.patch
-- Applying patch failed. This is expected if this patch was previously applied.
-- Applying patch G:/vcpkg/vcpkg/ports/folly/msvc-15.6-workaround.patch done
-- Configuring x64-windows
-- Configuring x64-windows done
-- Build x64-windows-dbg
CMake Error at scripts/cmake/vcpkg_build_cmake.cmake:129 (message):
Command failed: G:/vcpkg/vcpkg/downloads/cmake-3.10.2-win32-x86/bin/cmake.exe;--build;.;--config;Debug;--target;install;--;-v;-j1
Working Directory: G:/vcpkg/vcpkg/buildtrees/folly/x64-windows-dbg
See logs for more information:
G:\vcpkg\vcpkg\buildtrees\folly\install-x64-windows-dbg-out.log
Call Stack (most recent call first):
scripts/cmake/vcpkg_install_cmake.cmake:24 (vcpkg_build_cmake)
ports/folly/portfile.cmake:48 (vcpkg_install_cmake)
scripts/ports.cmake:72 (include)
Error: Building package folly:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: folly:x64-windows
Vcpkg version: 0.0.105-2018-03-18-1e73b6550cdea2792defdf8a142c24f4b80317a4
Additionally, attach any relevant sections from the log files above.
install-x64-windows-dbg-out.log

Hmm. You trying to build Folle with VS2015. I think they do not support it.

ok, i use VS2017, it works good！


Direct insert values in worker - Q3

This feature is to support insert cnch table from any workers to avoid the server load.

This has already been auto picked.


Discord app

Maybe we could get Discord somehow installed there? It's available as arch package, as flatpack package too, and is in modern days essential for gaming at all. Would that be a big problem to implement?

While it can be installed, GamerOS does not do multitasking. You're probably better off using your phone for discord


GnuPG: add scdaemon shared access patch

Motivation for this change
GnuPG stubbornly refuses to share access to smartcards, which, among other things, makes it not work properly with Yubikey-manager.
This adds a patch maintained by MacOS GPGTools which adds an option to enable shared smartcard access.
There is no change in default behavior, and patch applies cleanly without modifications, so I see no reason why Nix should not have it as well.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Added description with links. Let me know if you would like to see something more.

@uosis That's great, comments thanks.
Should this patch use fetchpatch (making it easier to update the patch given that https://github.com/GPGTools/MacGPG2/blob/dev/patches/gnupg/scdaemon_shared-access.patch seems to change every now and then with newer GPG releases) or does that not work for this package?

For other reviewers:
GPG upstream seems to find shared card access controversial because it may (apparently?) allow other apps to interact with a hardware-button security key than the one that requested the operation (GPG), see https://wiki.archlinux.org/index.php/GnuPG#Shared_access_with_pcscd (now linked in the comment).
It seems a legitimate use case to me to make shared card access an optional add-in feature for people who want to trade usability for a changed threat model, so carrying this patch looks sensible to me.

@uosis How is this added feature supposed to be used? The Arch wiki says

After patching your scdaemon you can enable shared access by modifying your scdaemon.conf file and adding shared-access line end of it.

Should there also be a NixOS setting to enable that easily?

Should this patch use fetchpatch (making it easier to update the patch given that https://github.com/GPGTools/MacGPG2/blob/dev/patches/gnupg/scdaemon_shared-access.patch seems to change every now and then with newer GPG releases) or does that not work for this package?

I see no reason to not use fetchpatch - I was just following the same pattern as other patches in this package. Changed to use fetchpatch.

GPG upstream seems to find shared card access controversial because it may (apparently?) allow other apps to interact with a hardware-button security key than the one that requested the operation (GPG), see https://wiki.archlinux.org/index.php/GnuPG#Shared_access_with_pcscd (now linked in the comment).

And just to add to this, while the security concern may have had some weight in the old days of plain "dumb" smartcards, now that smartcards are actually USB tokens with physical button authorization for each operation, the whole argument is moot.

@uosis How is this added feature supposed to be used? The Arch wiki says

After patching your scdaemon you can enable shared access by modifying your scdaemon.conf file and adding shared-access line end of it.

Should there also be a NixOS setting to enable that easily?

It is a user level configuration setting in ~/.gnupg, so I don't think there is anything to do here at NixOS level. I have home-manager branch that adds this option that I will try to get merged in after this PR is in.

@peti @vrthra @fpletz any opinion re: merging this?


Can only evaluate once?

It seems that I can only evaluate once? If I do it again I get this:
Evaluation of [run_tm (as_arith_expr (expr_to_term (Neg (Lit 42))))] failed: <input>(0,4-0,21): (Error 47) Duplicate top-level names [CanonDeep.__compute_dummy__]; previously declared at <input>(0,4-0,21)

Is this a known issue?

Nope, and since all the tests interactive mode tests seem to pass, it'd help to have a repro :)

;;; Started F* interactive: ("***/everest/FStar/bin/fstar.exe" "***/M.fst" "--ide" "--smt" "***/everest/z3-<IP_ADDRESS>f29cebd4df6-x64-osx-10.11.6/bin/z3")
{"kind":"protocol-info","version":2,"features":["autocomplete","autocomplete/context","compute","compute/reify","compute/pure-subterms","describe-protocol","describe-repl","exit","lookup","lookup/context","lookup/documentation","lookup/definition","peek","pop","push","search","segment","vfs-add"]}
;;; Complete message received: (status: nil; message: ((kind . "protocol-info") (version . 2) (features "autocomplete" "autocomplete/context" "compute" "compute/reify" "compute/pure-subterms" "describe-protocol" "describe-repl" "exit" "lookup" "lookup/context" "lookup/documentation" "lookup/definition" "peek" "pop" "push" "search" "segment" "vfs-add")))
;;; [23.15ms] Feature list received
;;; Processing queue
>>> {"query-id":"1","query":"vfs-add","args":{"filename":null,"contents":"module M\n\n"}}
>>> {"query-id":"2","query":"push","args":{"kind":"full","code":"module M\n","line":1,"column":0}}
{"kind":"response","query-id":"1","status":"success","response":null}
;;; Complete message received: (status: "success"; message: ((kind . "response") (query-id . "1") (status . "success") (response . :json-null)))
{"kind":"response","query-id":"2","status":"success","response":[]}
;;; Complete message received: (status: "success"; message: ((kind . "response") (query-id . "2") (status . "success") (response)))
;;; Queue is empty (1 overlays)
>>> {"query-id":"3","query":"compute","args":{"term":"()","rules":["beta","delta","iota","zeta","reify","pure-subterms"]}}
{"kind":"response","query-id":"3","status":"success","response":"()"}
;;; Complete message received: (status: "success"; message: ((kind . "response") (query-id . "3") (status . "success") (response . "()")))
;;; Queue is empty (1 overlays)
>>> {"query-id":"4","query":"compute","args":{"term":"()","rules":["beta","delta","iota","zeta","reify","pure-subterms"]}}
{"kind":"response","query-id":"4","status":"failure","response":"<input>(0,4-0,21): (Error 47) Duplicate top-level names [M.__compute_dummy__]; previously declared at <input>(0,4-0,21)\n"}
;;; Complete message received: (status: "failure"; message: ((kind . "response") (query-id . "4") (status . "failure") (response . "<input>(0,4-0,21): (Error 47) Duplicate top-level names [M.__compute_dummy__]; previously declared at <input>(0,4-0,21)
;;; ")))
;;; Queue is empty (1 overlays)

Oh, I misunderstood "evaluate".  Thanks.
The bug is likely in the implementation of
let run_and_rewind st task =
  let env' = push st.repl_env "#compute" in
  let results = try Inl <| task st with e -> Inr e in
  pop env' "#compute";
  match results with
  | Inl results -> (results, Inl st)
  | Inr e -> raise e

But I can't quite spot what's wrong with that.  @nikswamy?

Looks like the sigmap isn't being rolled back

Fixes in https://github.com/FStarLang/FStar/pull/1399, thanks.


Feature request: Length normalisation  in ctc_beam_search_decoder

I have studied that length normalisation improves the result of beam search. So, is there any plan of adding length normalisation in ctc_beam_search_decoder?

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

I think length normalization only makes sense when using a language model (LM).
In case a character-level LM is used, a labeling with say L characters gets scored L times. Each scoring is done with a value between p=0..1. Therefore, the LM-score for a long text is usually too low and length normalization makes sense in this case.


Force recreation of Kubernetes HTTP client

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #288
Special notes for your reviewer:
Release note:
Force recreation of Kubernetes HTTP client

LGTM after squashing.

Squashed!


For #3617, Show scaling progress and details

For #3617 .
Changes proposed in this pull request:

Add SyncTaskProgress.

/run ci

/run ci

/run ci