AMQP-687: Fix Conditional Rollback [1.6.x]

JIRA: https://jira.spring.io/browse/AMQP-687
When using a rule-based transaction attribute with a rollback/no-rollback rule,
the rule is ignored when providing the transaction attribute directly to the container
rather than via a transaction advice,
Also, user exceptions are always wrapped in a ListenerExecutionFailedException which
limits the ability to configure rules, even when using an advice.

Honor the attribute rollBackOn() mechanism within the container
Add ListenerFailedRuleBasedTransactionAttribute to allow the user to configure rules based on the actual exception.

Add docs.
AMQP-686: Handle ImmediateAcknowledgeAmqpException
JIRA: https://jira.spring.io/browse/AMQP-686
Previously, ImmediateAcknowledgeAmqpException only worked if thrown by
an error handler, not a listener.
Examine the cause chain to see if this exception appears, and handle accordingly.
An AmqpRejectAndDontRequeueException found first stops the chain traversal.
Also clarify the javadocs to make it clear the current transaction is ended
immediately, not all message delivery.
checkstyle
Polishing and Fixes
While polishing for PR comments, I found some more problems (existing code).
When using an external transaction manager, txRollback() was called twice, once
within the transaction and once by the after completion in the transaction synchronization.
This was benign because the delivery tags were not registered, but incorrect.
Now, the delivery tag is always registered and the rollback done by the synchronization.
Added more tests and added tests for the local transaction scenario.
Add missing .this
Polishing
Conflicts:
spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/AbstractMessageListenerContainer.java
spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/DirectMessageListenerContainer.java
spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/SimpleMessageListenerContainer.java
spring-rabbit/src/test/java/org/springframework/amqp/rabbit/listener/ExternalTxManagerSMLCTests.java
spring-rabbit/src/test/java/org/springframework/amqp/rabbit/listener/ExternalTxManagerTests.java
spring-rabbit/src/test/java/org/springframework/amqp/rabbit/listener/LocallyTransactedTests.java
src/reference/asciidoc/whats-new.adoc
Resolved.
Conflicts:
spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/BlockingQueueConsumer.java
spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/SimpleMessageListenerContainer.java
Resolved.

Merged as https://github.com/spring-projects/spring-amqp/commit/21dd858d41b64f1f9b2c626af11e45290506183d after rebase.


feat: add created at field for message deleted log

close #2120.
this issue have been approved by a core dev but since they can't add the approve label, they said on discord that feel free to treat it as approved. click me for more info.
due to discord.RawMessageDeleteEvent doesn't provide the message object we can't get the message create time.

Maybe also a timestamp for the time it was deleted? Because after a few days, the Discord message only shows the date, not the time and it'd be nice to have that at a glance

Maybe also a timestamp for the time it was deleted? Because after a few days, the Discord message only shows the date, not the time and it'd be nice to have that at a glance

Oh I only just saw this now.
I wouldn't mind having the full timestamp in the embed footer for deletion time, but I think that can be scoped in a separate issue since this PR is currently ready to be merged.
There are a couple other log embeds I want to slightly change cosmetically as well.

I think that can be scoped in a separate issue
For sure. We can create a separate issue for that, including the other cosmetic changes you mentioned. You can assign me to that if you'd like, I wouldn't mind working on it 🙂


Link format makes it tough to tell what's a link or not

What bug did you encounter?
On the August 3 call to the Annika character there's what looks like a link to https://developerquiz.org, but it doesn't seem to link anywhere
In general accessibility-wise I know the advice is to not distinguish interactive elements solely by one characteristic (ie color) and this is all the more important for links in bodies of text (ie some color-blind users won't be able to tell these are meant to be links at all.)
Currently, I believe your links fail WCAG 1.4.1 - I'd recommend adding an underline to links and only applying that styling to things that are actually linking somewhere.  Ideally, you might also consider making the color more distinct from your body text and making the cursor a pointer when over links (not sure if that's an accessibility issue but I know it confused me haha)
Steps to Reproduce
Play the game to august 3rd, get on the phone call to Annika, and proceed to the step where she's discussing developer quizzes. Try and click on the link. The game will proceed to the next dialogue slide instead.
Screenshots
No response
Additional Information
No response

Hi @srsexton94 !
It is my understanding that the reference to the developer quiz site is not supposed to be an active link.
I think it is just there so people can explore the site later on their own outside of the game.
But it does make sense to remove the link styling so people aren't tempted to click on it.

Fixed in a45212e


Drag-to-trash should abort if a block is not deletable.

What's the desired behavior here?  A bounce?  Reverting the drag?

Reverting the drag.
And this will be easier once events are in place since we'll be collecting
the right information to do the revert.
On Jun 23, 2016 5:12 PM, "geppy"<EMAIL_ADDRESS>wrote:

What's the desired behavior here? A bounce? Reverting the drag?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/blockly-android/issues/305#issuecomment-228222588,
or mute the thread
https://github.com/notifications/unsubscribe/AKjbp0Wdgeu95Zgw2cq8dpC9iojbenxIks5qOyEDgaJpZM4ItBSO
.

Open question #370.

Current behavior respects the dragged root block's deletable flag.  Respecting children is an open question in #370.


Drawer Anchor.End and Anchor.Bottom visible on page when closed

Things to check

[X] I have searched the existing issues for this bug
[X] To rule out a caching problem I made sure the bug also happens in an incognito tab

Bug type
Component
Component name
MudDrawer
What happened?
Already reported here: #4930 but that was 2 years ago.
The drawer exists visibly off-screen if Anchor is set to Anchor.End or Anchor.Bottom
The example on the MudBlazor website has the same issue
See here: Try MudBlazor
Open the 'End' drawer, then close it. Then scroll to the right.
Open the 'Bottom' drawer, then close it. Then scroll down.
Expected behavior
MudDrawer should be hidden when closed.
Reproduction link
https://try.mudblazor.com/snippet/tZTfT8IwEMff-Se8NDGBRCeI-uDcAiKJD04fJPpIyta4htEupeOHhP_d_tiARUANuIf1end8vne70n4_wJQ5An9ycXIXZNF9JiVn8IYFxUx6KDecHplJBC-sk9Bw6KFWtVoDz4eXlLAHgadEVNssjLlwXiUWslZDvjHuLlZMv3IUfpdFmq6W47N7PNVstRyffc8VYKTx1iopGAmbD60BZdG5Bihcn6sVwTuNZKy3U20geCT0I5baERsLgVXRHmwsBN2ETLCkXGEaaF14y8qs6x-lXGAxR34F1LMu5JHgiAjrLSK6W-jNU-4h_XbiG-QHc2in9oPpcI652MrRjGc8CQjLymDlfKJsCAGWoWo035qd004SfZq4IIaax_74-yc60F0eQOjw0ShjVG5hFB7b10bvarKtkEdkASYvFVSNhMCA8wTMaN2S3w4R8hGWY2MpKPsAewLOIB-8WyklTTiNvp89sLyaSV2sujYFgAdSZMRde22y8hdVrELjKVVfA6qbuDJSPyEeF53Yy-C2FDYapgklgZr1ejpD7vcM255OadTrp1syBoLgobtTWd0P-3Sv_kvX_rn3Se_gbihf7ijuB2l1bR2m27z-le6yYt_LLw
Reproduction steps

Open 'End' drawer.

Close 'End' drawer.

Scroll to right.

Open 'Bottom' drawer.

Close 'Bottom' drawer.

Scroll down.

Relevant log output
No response
Version (bug)
7.15.0
Version (working)
No response
What browsers are you seeing the problem on?
Edge
On which operating systems are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

While I can see the reproduction in the Try.Mud ... I can't seem to reproduce this in freshly created app. Do you have a basic github repo where this happens?

While I can see the reproduction in the Try.Mud ... I can't seem to reproduce this in freshly created app. Do you have a basic github repo where this happens?

Unfortunately I'm experiencing it in a quite large application so not sure how best to isolate or replicate it.
I would have thought it would be easier to diagnose based on the TryMud example, since it's a self-contained rendering in an iframe.
I've tried inspecting it myself but am unsure what to look for, other than toying with the css rules.

The issue is testing a fix. I need to successfully replicate it, apply the fix and show that it's gone. I was looking into a fix but can't actually recreate the error (outside of the TryMud)

The issue is testing a fix. I need to successfully replicate it, apply the fix and show that it's gone. I was looking into a fix but can't actually recreate the error (outside of the TryMud)

I've managed to reproduce it - easier than I thought!
https://github.com/[Stuart88/MudDrawerBug](https://github.com/Stuart88/MudDrawerBug)
Some possibly important project details

Template: MudBlazor Web App (MudBlazor)
Interactive render mode: Auto
Interactivity location: Per page/component
MudBlazor version: 7.15.0

The only changes I made to the solution were:

Add <MudThemeProvider /> in MainLayout
Create and place <ThingWithDrawer> component in Home page

Thanks, will look again when I get a chance.

Wrapping your @Body within a MudLayout appears to resolve this issue by the way.

In my application that unfortunately doesn't work.

@Stuart88 when you say it didn't work, what was the result?
How does the MainLayout look in your application?

@Stuart88 when you say it didn't work, what was the result?
How does the MainLayout look in your application?

First I tried
<MudLayout>
        @Body
</MudLayout>

but the result was the same
Next I tried
<MudLayout>
    <MudMainContent>
        @Body
    </MudMainContent>
</MudLayout>

but that made it even worse, ha.
However, I've just tried the same in the basic repro I provided earlier. For me, I see the the issue there too.

I have an acceptable workound for my use case. I've used position and overflow css properties with some divs and a global custom drawer component placed in MainLayout.
This preserves all existing functionality of MudDrawer, so no need for the new CSS rules that I saw in the PR related to this issue.
I don't know if it helps or not, perhaps the framework MudDrawer component could be wrapped in a div and placed similarly somehow. Sorry, not sure of the internals of how MudBlazor does its thing.
@inherits LayoutComponentBase

        @Body

        <ApplicationMainDrawer @rendermode=@InteractiveWebAssembly />
        @*<ApplicationMainDrawer> directly renders a <MudDrawer> *@


fix typo

closes #29

Thanks for submitting this PR... I'm not sure what happened with this comment 😄. I had originally copied this from some of our internal EECS 280 repositories for project specs, but apparently got halfway through changing the comment, forgot what I was doing, and never looked back.
I made a commit to fix the comment - it wasn't just a typo, but it was inaccurate (e.g. the project specs use Jekyll, but the async lectures don't at all).


Add unit tests for XML entity parsers

This branch adds unit tests for XML parsers by moving the logic to dedicated categories and adding test XML files.
It furthermore improves the readability in a couple of places by preferring guard statements over force-unwrapping optionals.
For the commonly shared properties id and tags, I've added superclass OverpassEntity that all entities (nodes, ways and relations) inherit from. I'm not sure whether this is the best approach and would like to get feedback and am very open for suggestions. 👍🏼

Thank you, @wtimme! This PR is amazing. Separating basic data into OverpassEntity increases simplicity. The OverpassResponse.swift's number of lines are reduced almost by half! And the unit tests are great as well! Good job! 👏

Thank you, @wtimme! This PR is amazing. Separating basic data into OverpassEntity increases simplicity. The OverpassResponse.swift's number of lines are reduced almost by half! And the unit tests are great as well! Good job! 👏


When the update argument for Command is provided as a TypedDict, mypy raises a complaint

Checked other resources

[X] This is a bug, not a usage question. For questions, please use GitHub Discussions.
[X] I added a clear and detailed title that summarizes the issue.
[X] I read what a minimal reproducible example is (https://stackoverflow.com/help/minimal-reproducible-example).
[X] I included a self-contained, minimal example that demonstrates the issue INCLUDING all the relevant imports. The code run AS IS to reproduce the issue.

Example Code
from typing import Literal, TypedDict

from langgraph.graph import StateGraph
from langgraph.types import Command

class State(TypedDict):
    foo: str

def node_a(state: State) -> Command[Literal["node_b"]]:
    return Command(update=State(foo=state["foo"] + "a"), goto="node_b")

def node_b(state: State) -> State:
    return State(foo=state["foo"] + "b")

builder = StateGraph(State)
builder.set_entry_point(node_a.__name__)
builder.add_node(node_a)
builder.add_node(node_b)
graph = builder.compile()
print(graph.invoke(State(foo="")))

Error Message and Stack Trace (if applicable)
error: Argument "update" to "Command" has incompatible type "State"; expected "dict[str, Any] | Sequence[tuple[str, Any]]"  [arg-type]
        return Command(update=State(foo=state["foo"] + "a"), goto="node_b")
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Found 1 error in 1 file (checked 1 source file)

Description
The program runs fine.
It's strange that we define the state format using TypedDict, yet receive warnings when using TypedDict as input, right?
Because the internal type hints uses dict, mypy complains when receiving a TypedDict.
I think changing the type hint to Mapping could resolve this.

# before
update: Union[dict[str, Any], Sequence[tuple[str, Any]]] = ()

# after
update: Union[Mapping[str, Any], Sequence[tuple[str, Any]]] = ()

If you agree with this change, I can quickly submit a simple PR to address the issue.
System Info
System Information

OS:  Linux
Python Version:  3.13.1 (main, Dec  4 2024, 08:54:15) [GCC 13.2.0]

Package Information

langchain_core: 0.3.24
langgraph: 0.2.59

This issue has been resolved in langgraph==0.2.60. Thank you. 😊


Array as a JSON root is not supported

The problem
If specific URL returns JSON and root object is an array it causes anexception
Invalid JSON body:
Traceback (most recent call last):
  File "/Users/me/Library/Caches/pypoetry/virtualenvs/ec-QLVbNtLr-py3.9/lib/python3.9/site-packages/requests_cache/cache_keys.py", line 170, in normalize_json_body
    body = filter_sort_dict(body, ignored_parameters)
  File "/Users/me/Library/Caches/pypoetry/virtualenvs/ec-QLVbNtLr-py3.9/lib/python3.9/site-packages/requests_cache/cache_keys.py", line 213, in filter_sort_dict
    return dict(sorted(data.items()))
AttributeError: 'list' object has no attribute 'items'

According to JSON spec array is a valid root.
Expected behavior
It should properly cache the request.
Workarounds
I'm using an external API so I cannot avoid this.
Environment

requests-cache version: 0.9.2
Python version: 3.9.1
Platform: MacOS

Thanks for reporting that. I'll get that fixed soon.

Fixed! This will be included in the next patch release.

Great - thank you 👏


Auto-open Readme on project open

Type: Feature Request
I am aware of the user setting to Auto-open Readme on project open.
However, my project (ApiLogicServer) creates projects, often for 1st-time VSCode users.  New users would not have set this option.  Perhaps the default should be to use this?
I am also aware of the tasks option to run commands on startup.  In particular, code -r readme.md works well, except for macs where new users might not have enable the command line option.
So, despite days of research, I have not found a way to force VSCode to open the readme.md (or Welcome.md) on startup.
I really believe it would be valuable to provide a way to open one of these on startup, if they exist.
VS Code version: Code 1.85.1 (0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2, 2023-12-13T09:48:16.874Z)
OS version: Darwin arm64 23.2.0
Modes:

You can set "workbench.startupEditor": "readme" for this

@mjbvz Thanks for your reply.
This works for me only as a user setting.  It is not available as a project setting, and is accepted but ignored as a workspace setting, perhaps overwritten by the user setting.
In my case - new users - they generally don't know about settings, so will have the default user setting.  So overriding from this effectively disables the workspace option.
I most want this as a project setting, workspace would be ok.  Currently, I am not able to make either work.


Support voxel-based GD-MAE?

Thanks for your great work. In the code I see only the pillar implementation(assert height dimension is 1 in spt_backbone.py). I wonder whether you may support voxel-based implementation. Does GD-MAE support voxel-based embedding? Why and why not?

The MAE-style pretraining could also be used for voxel-based embedding (as far as I know, there is not much difference between voxel-based and pillar-based models). Since the baseline is pillar-based models (e.g., SPT), we only do experiments for them.


Cannot delete pages or menus

I'm using version 1.0.7.  Apparently, I can't delete any pages.  If I navigate to the list of pages in admin and try to delete it, the page seems to be deleted, but then it's back.  This happens with any page, regardless of whether it's added to a menu, whether it's got a parent page, etc.  The only way I found to delete the page is to manually delete the row from content table in the database and then in the advanced section of admin reload the database.
The same apparently applies to menus, except I have to delete that menu from pages that contain it before deleting it from the database, otherwise it'll be reinserted into the database with empty content.

this is strange... it has been fixed few days ago
can you try to replace the src folder with the one from this zip
https://github.com/microweber/dist/raw/master/microweber-latest.zip

Oh, ok.  My install is from about  a week ago.  Can you point out which files have changed for this?  I don't want to replace the whole src dir, as I've made some customisations.

replace 2 files
src/Microweber/Providers/Content/ContentManagerHelpers.php and src/Microweber/functions/api_callbacks.php
this should fix the error

Thanks! Yes, this fixes the problem.

Cool, i am glad it works,
will leave this issue open for few days in case someone else has this problewm


warning<EMAIL_ADDRESS>Compiler version doesn't include clang or GCC: "c++" "--version"

This happens when compiling rustc on Ubuntu 22.04. c++ --version shows:
c++ (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Copyright (C) 2021 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

#1000 should fix this, it's awaiting review

Also I think this is dup of #958

Also I think this is dup of #958

It is. Didn't see that issue.


update Kui's packaging docs

https://github.com/IBM/kui/blob/master/docs/dev/packaging.md#browser-packaging needs update

Reference: https://github.com/IBM/kui/issues/1123


Update integration tests for user discoverable applications

Update integrations tests for filtering discoverable apps with spaces in name.
Related Issue

https://github.com/wso2/product-is/issues/16274

Related PR

https://github.com/wso2/identity-api-user/pull/173

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/5664824709

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/5664824709
Status: cancelled

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/5664849819

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/5664849819
Status: success


Some values not being exported with CSV exports

I did some testing after I saw the recent changes for fixing AF on flagged variant exports with 4.7.1a, and noticed that polyphen/SIFT values don't seem to be populated anymore, they are empty fields. REVEL, which comes after those 2, is still being exported. I experience this with my own local VCF/CRAM data as well as when running with the demo data on the main gene.iobio.io site and exporting the results to CSV.
Also, I'm not sure what the criteria is for whether or not the bamDepth values for proband/mother/father are supposed to be exported, but for as long as I've used the tool I've noticed issues with that. Recently it seems like sometimes it is, and sometimes it isn't filled in, and I haven't been able to pinpoint why. When I exported the CSV with the trio demo data for example, all bamDepth values are  empty, but when I tested exporting a single flagged variant in a different VCF/CRAM trio dataset which was heterozygous in the proband/father of a trio, the bamDepthProband is there, but bamDepthFather is empty. I was wondering if perhaps it is only populated if the bamDepth is different than the depth/combined refcount/altcount, as I've noticed that as a pattern, but I wasn't sure.
gene-iobio-flagged-variants-test.csv
I've attached the .csv from exporting the demo trio data, which shows the blank values

Thank you for the informative report on these gene.iobio issues. I will look into these this week and hopefully have a fix by the end of this week or next.
Best regards,
Tony Di Sera

I'm working on this bug fix right now. Since we no longer display SIFT and Polyphen in the variant detail panel, I would vote for removing it from the .csv. Any objections?

In order to export bamDepth (along with bamDepthMothe, bamDepthFather), preprocessing code was added to CohortModel.promiseExportVariants. This code refreshes the variants to be exported with these field by finding the matching coverage region in the bam depth. This code that finds the matching coverage region was incorrectly looking for an exact match on the variant start position. The code was fixed to look for a matching region, as the bam depth records are binned to minimize traffic and memory consumption.
Code in model.VariantExporter had to be fixed to properly initialize the bamDepth fields for called variants. Exporting called variants in a vcf format is an edge case that requires special code that recalls the variants in order to capture the correct vcf header and records. This code also had to preserve the bamDepth fields that were obtained in the CohortModel preprocessing described above.
In summary, the bamDepth, bamDepthMother, and bamDepthFather fields are now exporting properly. Also, for clarity, SIFT and Polyphen columns have been removed from the exported dataset since they are no longer displayed in the variant detail panel.


@jest/types config is missing timers option

🐛 Bug Report
@jest/types config in Config.ts, InitialOptions and DefaultOptions needs to have timers: 'real' | 'fake' | 'modern';
To Reproduce
Navigate to jest/packages/jest-types/src/Config.ts. Observe that the timers field in InitialOptions and DefaultOptions is missing the option modern.
Expected behavior
The timers field has an option for modern.
envinfo
 System:
    OS: Windows 10 10.0.19042
    CPU: (12) x64 Intel(R) Xeon(R) CPU E5-1650 v4 @ 3.60GHz
  Binaries:
    Node: 12.18.3 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.12.3 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 6.14.6 - C:\Program Files\nodejs\npm.CMD

Wanna send a PR fixing it? 🙂


Add an option to check by request IP

Add the options for verify requet IP based on IP address.

@tylerhunt that sounds fair easy for just IP check.
While I implementing my change, and I found that subnet check it's more suitable at least for my case, which is basically making requests between EC2 instances and I realized that internal IP change due DHCP. That being said what's your opinion on subnet check https://github.com/tylerhunt/rack-canonical-host/pull/47/commits/0f41f14101852d75989f97f3f31477aab69d7c7c ?

@hecbuma Couldn't the subnet check be done using the same block format? What's the use case here? I can't recall anyone ever using this middleware for IP/subnet filtering in this way, and it strikes me that this may not be the right level within your stack to perform this check.

Is this PR still relevant then? Should it be closed?


Fix add_shaders_directory glob mask

Current glob mask fails to detect files fs_texture.sc and vs_texture.sc
[!.def] matches the last symbol before .sc
!(.def) matches the whole pattern
Before: broken
After: fixed

Hey, thanks for the suggestion. The build doesn't pass though since it doesn't match any shaders now. Can you tell me on what platform you get an invalid glob match as it seems to work on my windows pc and the linux build on github?

After a bunch of debugging of a seemingly related issue, I'd run into this as well. Picks up vs_basic.sc but not vs_grid.sc (on account of the d).

@Razenpok I don't believe CMake globbing expressions support parenthesized subpatterns like that.
I've just switched to:
    file(GLOB VERTEX_SHADER_FILES CONFIGURE_DEPENDS FOLLOW_SYMLINKS "${SHADERS_DIR}/vs_*.sc")
    file(GLOB FRAGMENT_SHADER_FILES CONFIGURE_DEPENDS FOLLOW_SYMLINKS "${SHADERS_DIR}/fs_*.sc")

This won't match uniforms.sh or varying.def.sc anyways.

Well thanks for pointing out the issue. I've fixed it in 10a36c5a9e164f2f55d737af0473d14d05881624 .
Now I glob everything and you would have two ways of writing the shader filenames (since we still want to distinguish them somehow)
vs_texture.sc
texture.vert.sc
fs_texture.sc
texture.frag.sc
And there is also a wrong scenario: fs_wrong.vert which will be captured by both but you shouldn't do it anyway. If you want to have your own logic you can always rework or suggest a new cmake function. You could even use the ones provided by BGFX itself which are the ones I use anyway.


Kubernetes pods OOMKilled on DataTarget.CreateSnapshotAndAttach

When running on Kubernetes, at the point of calling DataTarget.CreateSnapshotAndAttach on a different .NET process, I often (but not always) have the pod killed with OOMKilled. If I increase the memory limit (fairly significantly), it doesn't occur.
To a certain extent this makes sense - I think that method "duplicates" the process. But it surprised me because the processes really use very little memory indeed (~50-100MB of allocated memory (via GC.GetTotalMemory()) with limits several times that.
Back in the day, I had issues with .NET Core apps hitting the memory limit because the GC (I think) wasn't looking at the cgroups info correctly, if I remember correctly? Could that be the case here - I guess, is there a rule of thumb I can use for setting an appropriate memory limit in Kubernetes in a way that works with DataTarget.CreateSnapshotAndAttach?

Sorry I don't have extensive knowledge of kubernetes.  In terms of memory usage, it was my vague understanding that memory isn't completely duplicated by PssCaptureSnapshot unless the page of memory in the target process is modified.  So basically, it's my (possibly mistaken) understanding that creating a snapshot should be fairly low memory usage unless the target process is really churning through a lot of memory changes at the time.
Note that ClrMD does have some options to reduce its memory usage but it will come at a high performance penalty.
To answer your question though, I unfortunately don't have any recommendations with using ClrMD in a memory limit.  There's a lot of moving parts in ClrMD under the hood which we don't fully control, and keeping it capped to a certain amount of memory (or even knowing the appropriate amount of memory needed) is unfortunately not something I really know how to quantify.  It would be highly dependent on what you are doing with the API.
(Closing this issue since I don't think I can help, but I'm happy to re-open or reply further if you have more questions!)


Allow different instance type per role

Needs https://github.com/AppScale/appscale-tools/pull/675

https://ocd.appscale.com:8080/job/Daily Build/4662/

@jeanleonov Yes you brought up a good point. I have made the changes, which should allow for compatibility with old tools and new. It would look for instance type under node layout for the new changes and if not it would default to the instance type passed in the options. I was able to test autoscaling using both current master tools and my tools branch and it seems to work.

https://ocd.appscale.com:8080/job/Daily Build/4736/

Latest build: https://ocd.appscale.com:8080/job/Daily Build/4745/

https://ocd.appscale.com:8080/job/Daily Build/4750/

https://ocd.appscale.com:8080/job/Daily Build/4758/

Latest build: https://ocd.appscale.com:8080/job/Daily Build/4763/ and Tools test rerun: https://ocd.appscale.com:8080/job/Tools-test/3115/

Latest all blue build: https://ocd.appscale.com:8080/job/Daily Build/4767/


[WIP] Exercise collection interface

yield only records in template

Cease yielding datasetState and pages since pages exists on records via records.pages

Setting debounce immediate to true
A couple of reasons for this:

When overwriting the slice method, we always setReadOffset at the start
of the slice.
The integration for rendering records uses an {{#each records as
|record|}} helpers, which uses objectAt just like
ember-collection. However, with the debounce at false, we sometimes
setReadOffset to the end of the array records.length, which then forces the
collection to request more records and grow. This occurs infinitely.

This looks great! :+1:

The pages section of the demo is broken, so need to fix that!


IMAP/SMTP error - Greeting never received

Hello!
I'm trying to connect my account with Nylas via IMAP/SMTP.
But after 30 sec I always get this error message: Greeting never received
My account works properly in Thunderbird or Geary. Only in Nylas don't.
I'm using Linux system Debian 10.
Here is console output after this error.
What should I do? Any suggestions are very welcome.

I have the same issue, in Thunderbird it works fine.
name: 'APIError',   error: null,   body: { message: 'Greeting never received', type: 'api_error' },   requestOptions:     { url: 'http://localhost:2578/auth',      method: 'POST',      json: true,      timeout: 180000,      path: '/auth',      body:        { provider: 'office365',         email<EMAIL_ADDRESS>        name: 'Carlos xxxxxxxx',         settings: [Object] } },   statusCode: 500,   message: 'Greeting never received',   errorType: 'api_error' } { pluginIds: [] } Invalid api key 401

I solved this by upgrading to newest version of Nylas from this repository. :octocat:
Downloads here.
Hope it helps.


perf(*): adjust resource quota

What this PR does / why we need it:
按平台组件稳定性指南 和 2.11.0-rc.1 的压测结果调整资源配额
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #

Special notes for your reviewer:
/cc @jianglinjian

Release note:

NONE

/lgtm

/cherrypick release-1.3


High CPU usage on sending big files

Additionally the same issue was with memory, but fix is almost ready

Usage of CPU while sending files of size 900MB is 101.4%


'PhantomDownloader' object has no attribute 'drivers'

Just trying to launch e05_phantomjs.py example.
INFO:pomp.engine:Prepare downloader: <__main__.PhantomDownloader object at 0x10e0be3c8> INFO:pomp.engine:Start crawler: <__main__.TwitterSpider object at 0x10e78c128> INFO:pomp.engine:Start pipe: <e02_quotes.PrintPipeline object at 0x10e77ff60> Traceback (most recent call last):   File "e05_phantomjs.py", line 200, in <module>     pomp.pump(TwitterSpider())   File "/usr/local/lib/python3.6/site-packages/pomp/core/engine.py", line 271, in pump     iterator(next_requests), crawler,   File "/usr/local/lib/python3.6/site-packages/pomp/core/engine.py", line 158, in process_requests     self._req_middlewares(requests, crawler), crawler):   File "e05_phantomjs.py", line 109, in process     request.driver_url = self.drivers[0].command_executor._url AttributeError: 'PhantomDownloader' object has no attribute 'drivers'

I don't know what is going on...
Where is my attempt
$ git clone https://github.com/estin/pomp
$ cd pomp
# isolate environment via awesome pipenv
$ pipenv install .
$ pipenv shell
$ pip install futures lxml selenium
$ python setup.py develop

And run phantomjs example
$ python examples/e05_phantomjs.py
...skipped...
---------------------------------------------------------------------------
Pycoders Weekly likes: 2
body: Pycoders Weekly (Issue #305): Cogent -http://mailchi.mp/pycoders/pycoders-weekly-issue-263-source-209833 …
---------------------------------------------------------------------------
Pycoders Weekly likes: 5
body: Which Python course is teaching you how to work with large amount of data? –http://bit.ly/2FUreCM
---------------------------------------------------------------------------
Pycoders Weekly likes: 5
body: Guido van Rossum: BDFL Python 3 retrospective –http://bit.ly/2FVHCTH
DEBUG:__main__:close all phantomjs nodes
INFO:pomp.engine:Stop pipe: <e02_quotes.PrintPipeline object at 0x7f2e347995c0>
INFO:pomp.engine:Stop crawler: <__main__.TwitterSpider object at 0x7f2e34799748>
Statistics:
 requests/responses/exceptions = 8/8/0

Where my versions are
$ python --version
Python 3.6.4

$ phantomjs --version
2.1.1

$ pip freeze
futures==3.1.1
lxml==4.2.1
-e git+https://github.com/estin/pomp@ce0cca94c17a62da592fe90962f103a425e817c3#egg=pomp
selenium==3.11.0

Can you gather more info about it?

Oh... I see pomp on 0.2.1 has this issue.
$ pip freeze
futures==3.1.1
lxml==4.2.1
pomp==0.2.1
selenium==3.11.0

$ python examples/e05_phantomjs.py
INFO:pomp.engine:Prepare downloader: <__main__.PhantomDownloader object at 0x7fda86c12860>
INFO:pomp.engine:Start crawler: <__main__.TwitterSpider object at 0x7fda85b78438>
INFO:pomp.engine:Start pipe: <e02_quotes.PrintPipeline object at 0x7fda85b782b0>
Traceback (most recent call last):
  File "examples/e05_phantomjs.py", line 200, in <module>
    pomp.pump(TwitterSpider())
  File "/home/user/.local/share/virtualenvs/tmp-XVr6zr33/lib/python3.6/site-packages/pomp/core/engine.py", line 271, in pump
    iterator(next_requests), crawler,
  File "/home/user/.local/share/virtualenvs/tmp-XVr6zr33/lib/python3.6/site-packages/pomp/core/engine.py", line 158, in process_requests
    self._req_middlewares(requests, crawler), crawler):
  File "examples/e05_phantomjs.py", line 109, in process
    request.driver_url = self.drivers[0].command_executor._url
AttributeError: 'PhantomDownloader' object has no attribute 'drivers'

You can try  to upgrade pomp from this repo
$ pip install -U git+https://github.com/estin/pomp@ce0cca94c17a62da592fe90962f103a425e817c3#egg=pomp

I do't know when I can find some time to prepare Pomp for releasing to pypi.


Readme cleanup

removed duplicate "Binary data transfer" from readme

Thank you for your contribution. That's merged and backported now.


Typing to find file name in list doesn't bring highlighted file into view

Description
Typing to find file name in list doesn't bring highlighted file into view.
i.e. You are in a folder with a lot file, you know the first few letters of the filename, start typing, and expecting it to be highlighted and brought into view. It's highlighted but not brought into view in List view.
Steps To Reproduce

Be in list view in a folder with a large amount of files
Start typing filename to hightlight/move to file like in Windows Explorer
File is highlighted, but Files isn't hovered/centred to that file as expected

Requirements
Change behaviour so selected file is centered on screen
Files Version
<IP_ADDRESS>
Windows Version
10.0.19045.4046
Log File
Not needed

Thanks for the report, Are you using compact size (slider to lowest)?

Thanks for the information, We're tracking this in #15955. You can check there or click subscribe in the right sidebar for updates.


PKCS12_parse(): Fix reversed order of certs output

It turned out that the list of certs returned by PKCS12_parse() was reversed (as compared to the order in the PKCS#12 input).

See also issue #6698.

See also issue #6698.

Does that mean we need to support both formats?

See also issue #6698.

Does that mean we need to support both formats?

I would say no.
I agree with @levitte https://github.com/openssl/openssl/issues/6698#issuecomment-404310234 that the certificate order reversal currently done by PKCS12_parse() is a bug, not a feature.
The documentation PKCS12_parse() says nothing about the order of the certificates, but it would be natural that the given order is maintained, as reported also by @davidben.

The fact that we know of one use that (so far) relies on the inverted order should not keep us from correcting this behavior.
It should not be a problem for the use mentioned by @filipnavara to adapt to the fixed version whenever they move to using an OpenSSL version that includes this fix.
I've just amended the commit of this PR to include in CHANGES.md:

PKCS12_parse now maintains the order of the parsed certificates
when outputting them via *ca (rather then reversing it).

and added Fixes #6698 to the commit message.

Would have been good if this had been sorted out already two years back, right after the issue was reported.

I suppose the quadratic complexity of looping over the shift call can be ignored as you don't have PKCS12 files with hundreds of certs.

The question is whether we should fix this on 1.1.1 as well.

The question is whether we should fix this on 1.1.1 as well.

Good point - the bug is in since 2009, and for consistency it would make much sense.
Once this is approved I'll provide a backport PR.

I suppose the quadratic complexity of looping over the shift call can be ignored as you don't have PKCS12 files with hundreds of certs.

It's also easy enough to avoid by just leaving ocerts alone. :-P
    for (i = 0; i < sk_X509_num(ocerts); i++) {
        X509 *x = sk_X509_value(ocerts, i);
        if (...) {
            ...
        }

        if (ca != NULL && x != NULL) {
            if (!X509_add_cert_new(ca, x, X509_ADD_FLAG_DEFAULT))
                goto err;
            X509_up_ref(x);
        }
    }

It's also easy enough to avoid by just leaving ocerts alone. :-P

It's actually not that easy - your above suggestion does not use X509_up_ref(x) for the *cert assignment case,
and  X509_up_ref() may fail, which needs to be handled properly.
So I think it's better to use sk_X509_shift(ocerts).
Still your comment motivated me to have a closer look at the code of PKCS12_parse() and the auxiliary functions it calls.
It turns out that there were some possibilities to make it a little more efficient and more general (ocerts may be NULL in some situations, and after the loop mentioned above, ocerts is guaranteed to be empty), and the adherence to the coding guidelines could be improved.
I did this and also updated/extended the documentation of PKCS12_parse().

It's actually not that easy - your above suggestion does not use X509_up_ref(x) for the *cert assignment case,

Ah yeah. And sk_X509_free should probably turn into sk_X509_pop_free.

and X509_up_ref() may fail, which needs to be handled properly.

Not really. Most of the project does not bother checking, neither do most external callers in my experience. See the discussion in https://github.com/openssl/openssl/issues/12230. Making it fallible was a mistake, IMO.

It's actually not that easy - your above suggestion does not use X509_up_ref(x) for the *cert assignment case,

Ah yeah. And sk_X509_free should probably turn into sk_X509_pop_free.

sk_X509_free is sufficient in this case because, as I wrote above, after the loop ocerts is guaranteed to be empty.

and X509_up_ref() may fail, which needs to be handled properly.

Not really. Most of the project does not bother checking, neither do most external callers in my experience. See the discussion in #12230. Making it fallible was a mistake, IMO.

Maybe, but most of the X509_up_ref() calls within the OpenSSL code do check its result.

sk_X509_free is sufficient in this case because, as I wrote above, after the loop ocerts is guaranteed to be empty.

I meant in the O(N) version, which does not modify ocerts.

Merged - thanks @davidben and @t8m for the interesting discussion.


cannot run hic_breakfinder after install successfully

Hi Dr. Dixon,
I have installed hic_breakfinder successfully with BamTools2.4.0. But when I try to run hic_breakfinder by "./hic_breakfinder", I meet following problem:
weihuap@genome-dev:/hive/weihuap/software/hic_breakfinder-master/install/bin$ ./hic_breakfinder
./hic_breakfinder: error while loading shared libraries: libbamtools.so.2.4.0: cannot open shared object file: No such file or directory
My "LD_LIBRARY_PATH" is as follow:
weihuap@genome-dev:/hive/weihuap/software/hic_breakfinder-master/install/bin$ echo $LD_LIBRARY_PATH
/hive/weihuap/software/bamtools-2.4.0/build/install_dir/lib/bamtools
weihuap@genome-dev:/hive/weihuap/software/hic_breakfinder-master/install/bin$ ls $LD_LIBRARY_PATH
libbamtools.a  libbamtools.so  libbamtools.so.2.4.0
Can you please help me solving this problem? I have been working on this for a few days not cannot solve it.
Thanks in advance.
Weihua

When installing, I did:
./configure CPPFLAGS=" -I /hive/weihuap/software/bamtools-2.4.0/build/install_dir/include/bamtools  -I /hive/weihuap/software/eigen-323c052e1731" LDFLAGS="-L /hive/weihuap/software/bamtools-2.4.0/build/install_dir/lib/bamtools" --prefix=/hive/weihuap/software/hic_breakfinder-master/install
make
make install

Hi,
Did you solve this problme? I met the same question, hope you solved it already!
Thanks


[reminder] several of the plugins need (minor) updates pushed to npm

I hate to be a nag, but… :smiley:
carta-md has received npm updates as the result of the recent flurry of activity in this monorepo, but several of the plugins that are tightly coupled to these changes aren't yet published.
This comparison, of the diff between tags that sufficiently bookend these changes, indicates that the following plugins have been touched:

plugin-code
plugin-emoji
plugin-math
plugin-tikz

Done, thanks 👍


Add role and role integration fields

Add the role/roleIntegration fields to Component and SequenceAnnotation for SBOL 2.1.

Add a list of URIs for the Roles in the Component and SequenceAnnotation classes.
Add a URI field for the RoleIntegration into the Component class.

Fixed by d21ee1883e8d28f4e0c9597ccf42edafd74d374b


Distinct validation rule not working on top-level array

Laravel Version: 5.6.39
PHP Version: 7.1.28
Database Driver & Version: mariadb 10.4

Description:
I'm not 100% sure that this is a bug or intended behaviour but I've been validating an array of values as follows:
$array = [
    ['id' => 1],
    ['id' => 2],
];
$rules = [
    '*' => 'array',
    '*.id' => 'required',
];
Validator::make($array, $rules)->validate();

Now if I use the distinct rule on the '*.id' column it doesn't work. However if I put it into a non-top-level property, it does eg
$array = [
    'items' => [
        ['id' => 1],
        ['id' => 2],
    ],
];
$rules = [
    'items' => 'array',
    'items.*.id' => 'required|distinct',
];

I guess the question is, are top-level array validation rules supposed to work like this?
Steps To Reproduce:
Using the following code, the Validator instance will not fire a validation error.
$array = [
    ['id' => 1],
    ['id' => 1],
];
$rules = [
    '*' => 'array',
    '*.id' => 'required|distinct',
];
Validator::make($array, $rules)->validate();

@driesvints This is still an issue in 5.8.29.

I reproduced it in laravel 5.8 and without  '*' => 'array',  it works fine!
$array = [
['id' => 1],
['id' => 1],
];
$rules = [
'*.id' => 'required|distinct',
];
Validator::make($array, $rules)->validate();


Make the class CommunityIdProcessor final

Description
This is a follow-up PR for Add community_id ingest processor, the new added class CommunityIdProcessor should be final, but in the original PR we neglected that.
Other main classes of the ingest processors don't have this issue.
This PR should be backported to 2.x branch.
Related Issues
https://github.com/opensearch-project/OpenSearch/issues/2787
Check List

[ ] Functionality includes testing.
[ ] API changes companion pull request created, if applicable.
[ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gaobinlong could you please backport to 2.x manually? thank you


"Bicaz", "Ciuta" and "Corni" are listed in the drop-down menu

Description:
"Bicaz", "Ciuta" and "Corni" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Bicaz" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Bicaz, MARAMUREȘ (Bicaz)" and "Comuna Bicaz, MARAMUREȘ".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Type "Ciuta" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Ciuta, MARAMUREȘ (Bicaz)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Type "Corni" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Corni, MARAMUREȘ (Bicaz)".


Make textile client dependent methods more robust

Change log

Make Space Service wait for Textile Client init/hub connection before executing methods such as list dir, get notifs, etc. In case of a timeout or 3 consecutive failed connections, return an error.

Notes
This flow was discussed with @giankotarola yesterday and we agreed it would allow the frontend to better handle wait times, as the FE can display the loading states of each component while textile is not ready (e.g. show skeletons in notifs or file list), and only fail execution if there's a deeper error such as no internet connection.
Also this fixes the issue where if you log out and log in into the same account, it didn't display the existing files. Now that the client returns the response after textile is initialized, the FE is receiving the files and displaying them correctly.
@giankotarola: I tested this version using the electron app and it's working fine, but I'm not able to see the loading components (for example something to display that the list of files is loading). Maybe that needs to be implemented?
[ch18397]

@dmerrill6 cool! And yea, it was implemented but had to be reverted since it had a bug, but def will be fixed soon.


Complete support of Regex Backreferences

Related to #1167
Backreference constructions should be supported:

\<number>
\k<name> or  \k'name'
\k<number> or  \k'number'

The correct implementation also assumes the following points:

The groups are sorted in the way that named groups go after numbered groups.
MatchSparse entity is implemented for explicitly numbered groups, like: (?<1000>abc)

77c91c7a9cddbad018b231b7d8d064625a7ea3e7 - Order pattern groups while parsing
2fa5e32b491bd33fcc85e806da6ab5861bec69fe - MatchSparse has been introduced
02d1aa72411cbf1feb09f90e57670740cce88657 - 	Sparse groups logic, unit tests
b1c16c2abc2cdd46e4a8f8a4e52fb7ce34977b91 - Enhanced Backreference validation
80b46b59db444b7908c3ccf4b7cf375f55cef404 - NotSupportedException for backreferences inside groups

PR #1367 fixes the issue partially:

The constructions above are supported
MatchSparse is implemented
Groups order is fixed

However, the following restrictions are remain:

Backreferences only to the closest (to the left) group are supported, e.g.: (abc)def \1
Backreferences to child groups of the closest one are also supported: ((abc)def) \2
Backreferences to non-neighbor groups are NOT supported: (abc)(def) \1
Backreferences inside groups are NOT supported: (abc)(\1)

The restrictions are connected with the way how pattern is processed. They will be eliminated in the future releases.


Change the Default run_as_user to 0 for K8s Workers

the default run_as_user for Airflow <= 1.10.10 was an empty string which defaulted to 0 but we changed it to 50000 in https://github.com/apache/airflow/pull/9038 (and 1.10.11).
This PR reverts this behaviour and uses same default as Airflow <= 1.10.10

Make sure to mark the boxes below before creating PR: [x]

[x] Description above provides context of the change
[x] Unit tests coverage for changes (not needed for documentation changes)
[x] Target Github ISSUE in description if exists
[x] Commits follow "How to write a good git commit message"
[x] Relevant documentation is updated including usage instructions.
[x] I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

This will be a temp fix till until we pass the UID for the image (in the Helm chart)

Fixed in our ap-airflow docker iamges instead.


Proposal: Comma (,) sepator for attrs! and style!

Proposal: Allow to write attrs! and style! also this way:
attrs!{At::Type => "text", At::PlaceHolder => "Article Title"}

I'll implement it if you agree.

Go for it. I originally wanted to have both, but ran into technical issues, which I think a recent PR of yours fixed. Semicolon's more consistent with CSS/inline styles. Comma's more natural for Rust. (Although lack of a built-in HM literal leaves the correct answer biguous). Both options avail's the way to go.


feat: add ci-cd workflow for tests

I added ci-cd stages for tests, can you check out please? @jonasob @artfwo

Can you checkout my pr? I have been added ci-cd workflow for tests @wjt @jonasob @pombredanne @artfwo

I have a couple of questions here:
What is the purpose of this change?
Why is extra chmod +x test.sh in the workflow file? This file should already be executable after checkout.

I have a couple of questions here:
What is the purpose of this change?
Why is extra chmod +x test.sh in the workflow file? This file should already be executable after checkout.

In my previous pr If you remember. I fixed the hash value in tests, there was no ci-cd stages right there, I think ci-cd stages important to development. For example some changes on hashing algorithm may impacts to tests so we can understand some places are broken. If you think unnecessary for this project we can close the pr
You are right about chmod +x test.sh, may it is unnecessary line but I wrote to make them more understandable, I can remove it
Thanks for comments @artfwo

Thanks for clarifying, @eredotpkfr . I am fine with merging this, given the following:

chmod +x test.sh is removed - it's an unnecessary command
there is no need for build status image in the README, as github shows the checkmark when browsing the source anyway - if you'd like to keep it nevertheless, please change the alt text to something meaningful, i.e. Tests Status

I changed the things you said, thanks for your interest @artfwo


[MRG] MAINT: read_spikes -> cell_response.py

Cruft from #305

Codecov Report

Merging #320 (dce04cd) into master (eb17311) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #320   +/-   ##
=======================================
  Coverage   90.43%   90.43%
=======================================
  Files          14       14
  Lines        2425     2425
=======================================
  Hits         2193     2193
  Misses        232      232

Impacted Files
Coverage Δ

hnn_core/network.py
92.68% <ø> (-0.38%)
:arrow_down:

hnn_core/__init__.py
100.00% <100.00%> (ø)

hnn_core/cell_response.py
83.73% <100.00%> (+2.48%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb17311...dce04cd. Read the comment docs.

Just realized, are there no tests for the read_spikes function?

there are tests actually, see here for example: https://github.com/jonescompneurolab/hnn-core/blob/master/hnn_core/tests/test_cell_response.py#L28-L29.
feel free to merge if/when you're happy. It's a straightforward PR just moving things around.

Ah I see, I think my confusion was why none of the test files had to modify the imports (but read_spikes is actually in the init). Embarrassingly I think I may have written some of those tests 😄


Changed and tested cli output for comparing tokens from a release and branch

Description
Changed how I printed out the cli version and branch names in the report.
Motivation and Context
The functionality for comparing release tokens with branch tokens and vice versa (due to how I did the file importing) was already there; however, the way I coded the cli output displayed the version and branch names as one or the other. This was because I wasn't sure if that was something we wanted before merging the previous PR, but now this PR will change it so you can compare between releases and branches.
How Has This Been Tested?

Added snapshot tests to file import test file to check comparison between branch tokens and release tokens (and vice versa)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Tests

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Run report for 85b5eade
Total time: 12.6s | Comparison time: 13.4s | Estimated savings: 776.3ms (5.8% faster)

Action
Time
Status
Info

🟩
SyncWorkspace
0ms
Passed

⬛
SetupToolchain(node:~20.12)
1.3s
Skipped

🟩
InstallWorkspaceDeps(node:~20.12)
7.3s
Passed

🟩
SyncProject(node, diff)
0.5ms
Passed

🟩
SyncProject(node, root)
0.6ms
Passed

🟩
RunTask(diff:diff)
105.3ms
Passed

🟩
RunTask(diff:test)
4.1s
Passed

🟩
RunTask(root:test)
1.5s
Passed

Touched files
tools/diff-generator/src/lib/cli.js
tools/diff-generator/test/fileImport.test.js
tools/diff-generator/test/snapshots/fileImport.test.js.md
tools/diff-generator/test/snapshots/fileImport.test.js.snap
tools/diff-generator/test/test-cli-outputs/expected-branch-release-compare.txt
tools/diff-generator/test/test-cli-outputs/expected-release-branch-compare.txt
tools/diff-generator/test/updatedToken.test.js


Update tsconfig.json

By placing "types" under "compilerOptions", TypeScript offers better control over type management, helps prevent conflicts, i think its help a little

It seems "types": ["@cloudflare/workers"] already was inside the compilerOptions object in the previous state, and it was just moved to the top of the declared properties.
You're right in assuming that it should be under compilerOptions, (see: https://www.typescriptlang.org/tsconfig#types), but this PR actually breaks the tsconfig.json given that types is now preceded by other properties but does not have a comma in the end of line.


When SIGINT is detected by devbox run send SIGTERM to the pid of the script that is running

Summary
When SIGINT is detected by ``devbox run` send SIGTERM to the pid of the script that is running.  Fixes #1815
How was it tested?
I ran a script before this change and CTRL-C could not cancel it.  With this change it can be canceled.

Is there a good way to add test for these cases into the repository? If there is, I will gladly do it.

I made an initial stab of doing it this way and cancelling didn't work.  I will try to get back to this in a bit.


Specified port, COMX, does not exist (Windows)

Just an FYI.  There seems to be some port number, beyond which the Serial constructor throws a IO Exception on Windows.  When my device was enumerated at COM20 (with -e in test_serial), trying to connect to it throws.  When I changed to COM2 it worked as expected.  I have had this problem with Windows software before so I knew to try that...I can't remember the root cause.
C:\Users\AndersonM\Documents\Visual Studio 2013\Projects\wjwwood-serial-6e47bdd\
visual_studio\Debug>test_serial.exe -e
(COM20, USB Serial Port (COM20), FTDIBUS\COMPORT&VID_0403&PID_6001)

C:\Users\AndersonM\Documents\Visual Studio 2013\Projects\wjwwood-serial-6e47bdd\
visual_studio\Debug>test_serial.exe "COM20" 57600
Unhandled Exception: IO Exception: Specified port, COM20, does not exist., file
c:\users\andersonm\documents\visual studio 2013\projects\wjwwood-serial-6e47bdd\
src\impl\win.cc, line 71.

Just a confirmation over here: https://github.com/bakercp/ofxSerial/issues/5#issuecomment-70861734
@wjwwood Seems like the solution would be to take @anderwm 's approach and append "\." in the win impl.

what I used:
"string port = "";
port.append("\\\\.");
port.append("\");
port.append(devicesInfo[deviceIndx].getPort());
success = device.setup(port), 9600);"
learned that \ removes following char. thanks @bakercp

I reproduced this and fixed it in #84, thanks guys!


Confusing error message when redefining input on operation used by other operations

Describe the bug
If an operation DoA is called from another operation DoB, then redefining the signature of DoA in a subsequent cell can result in confusing error messages that appear to refer to lines in the  current cell, but that actually refer to lines in the DoB cell.
To Reproduce
Steps to reproduce the behavior:

Define two operations, DoA and DoB in distinct cells, making sure that DoB calls DoA at least once.
In a new cell, redefine DoA and modify its signature.
See error

Expected behavior
An error message indicating clearly that the compilation error is with respect to DoB, and not the cell currently being executed.
Screenshots

System information

+1 to fixing this, I ran into this today and it was very confusing.


LICENSE file is missing from the repository

What's the license for heroku-javaagent?

MIT. License file has been added


Handle glucose datetimes that are timezone-aware

cc @bewest

Great, looking forward to trying this soon.


shell cmd: "devmem dump" only works for the 1st call

Describe the bug
Shell command "devmem dump" works properly when I call it for the first time. But when I call the exact same command again, it shows an error '-a <address>' is mandatory.
To Reproduce
Steps to reproduce the behavior:

cd "$(west topdir)/zephyr"
west build --board qemu_x86 --target run samples/hello_world/ -- -DCONFIG_SHELL=y
call command "devmem dump -a 0 -s 0x100" in the shell
above command works fine
call command "devmem dump -a 0 -s 0x100" in the shell again
above command doesn't work

Expected behavior
both calls to the command should work
Impact
What impact does this issue have on your progress (e.g., annoyance, showstopper): N/A
Logs and console output
-- west build: running target run
[3/12] Linking C executable zephyr/zephyr_pre0.elf

[11/12] Linking C executable zephyr/zephyr.elf
Memory region         Used Size  Region Size  %age Used
             RAM:       90144 B         3 MB      2.87%
        IDT_LIST:          0 GB         2 KB      0.00%
[11/12] To exit from QEMU enter: 'CTRL+a, x'[QEMU] CPU: qemu32,+nx,+pae
SeaBIOS (version zephyr-v1.0.0-0-g31d4e0e-dirty-20200714_234759-fv-az50-zephyr)
Booting from ROM..
*** Booting Zephyr OS build zephyr-v3.4.0-554-g33b116407b03 ***
Hello World! qemu_x86

uart:~$ devmem dump -a 0 -s 0x100
Mapped 0x0 to 0x7fa000

007FA000: 53 ff 00 f0 53 ff 00 f0  c3 e2 00 f0 53 ff 00 f0 |S...S... ....S...|
007FA010: 53 ff 00 f0 54 ff 00 f0  53 ff 00 f0 53 ff 00 f0 |S...T...  W...3...|
007FA040: 90 d2 00 f0 4d f8 00 f0  41 f8 00 f0 fe e3 00 f0 |....M...  S...S...|
007FA090: 53 ff 00 f0 53 ff 00 f0  53 ff 00 f0 53 ff 00 f0 |S...S... S...S...|
007FA0A0: 53 ff 00 f0 53 ff 00 f0  53 ff 00 f0 53 ff 00 f0 |S...S... S...S...|
007FA0B0: 53 ff 00 f0 53 ff 00 f0  53 ff 00 f0 53 ff 00 f0 |S...S... S...S...|
007FA0C0: 53 ff 00 f0 53 ff 00 f0  53 ff 00 f0 53 ff 00 f0 |S...S... S...S...|
007FA0D0: 53 ff 00 f0 53 ff 00 f0  53 ff 00 f0 53 ff 00 f0 |S...S... S...S...|
007FA0E0: 53 ff 00 f0 53 ff 00 f0  53 ff 00 f0 53 ff 00 f0 |S...S... S...S...|
007FA0F0: 53 ff 00 f0 53 ff 00 f0  53 ff 00 f0 53 ff 00 f0 |S...S... S...S...|
uart:~$ devmem dump -a 0 -s 0x100
'-a <address>' is mandatory
uart:~$ devmem dump -a 0 -s 0x100
'-a <address>' is mandatory

Environment (please complete the following information):

OS: Linux
Toolchain: Zephyr SDK
Commit SHA or Version used: 33b116407b03883efd889f75d69f5bc753b7ade3

This is likely a result of this https://github.com/zephyrproject-rtos/zephyr/issues/52700

Still a problem, as getopt globals need to be in TLS or protected via pthread_key_create.
I would say, if we are to use pthread_key_create then we need to (mandatorily) unify pthreads and k_threads.
That actually wouldn't be all that bad.

I need to check if this is still an issue. From what I recall, I was able to run it multiple times recently. There may have been improvements to the underlying getopt() function.

Hello, I was testing devmem dump and saw this issue but it works several times when enabling SHELL_GETOPT

Hello, I was testing devmem dump and saw this issue but it works several times when enabling SHELL_GETOPT

Thanks for confirming. That reflects my recent observations too.
I'll close this as complete.


Added support for TalkAbout comments in blog posts

Added view files needed to support TalkAbout comments in blog posts. **For the life of me I could not figure out where in the template file the logic is to add these files only if the TalkAbout comments selection is chosen so this will still need to be done.

I believe this is already addressed, in so far as a new template CS site now supports TalkAbout comments on blog posts (if the CS installer template option is chosen to enable TalkAbout commenting).  This must have been done elsewhere in parallel to this PR...


LinkedHashMap#put has O(n) complexity but documentation states it is O(1)

In case if the Map already has the given key, LinkedHashMap#put complexity becomes O(n).
The documentation states it is O(1) - http://www.vavr.io/vavr-docs/#_collections
Remove also has O(n) complexity.
For reference, java.util.LinkedHashMap#put has O(1) complexity.
See also the discussion here: https://github.com/vavr-io/vavr/issues/1838
Either the documentation should be adjusted of the implemention should be changed to actually be O(1).  This, of course, would involve major changes, because both queues must be changed in O(n).

BTW, Kotlin persistent collections have O(log(n)) for put.

I know, there is still plenty of room for improvement. Mid-term, I would love to see Scala 3 collection impls here (e.g. Champ).


[FEATURE REQUEST] Implement manual test coverage for the BinaryTree.

What would you like to Propose?
Implement manual test coverage for the BinaryTree, see file src/main/java/com/thealgorithms/datastructures/trees/BinaryTree.java .
Issue details
This issue blocks issue #2 .
Additional Information
No response

fixed


Update home-assistant recipe to latest version (2022.x)

Currently the layer contains an almost 4 year old version of home assistant. Update to the latest version considering only the minimal dependencies in this first step.

I am looking into this right now. Home Assistant core 2022.5.1 plus its new and updated dependencies. Will keep you updated.

@bachp Have a look at my draft PR when you have time and let me know if that goes in the direction you are aiming at.


Feature/add tune methods

tests still needed, present but not complete

PR -> master, instead of -> develop


2.5.1 release

Make bin/express compatible with 2.5.1 release

too late now :D not a huge deal, I'll get it next time


fix: months not updating when changing options

Closes #1069

Also closes #725

Also closes #725

Are you sure about that? It seems that is asking of dynamically set the first week of the day based on the locale...is that automatic?

Also closes #725

Are you sure about that? It seems that is asking of dynamically set the first week of the day based on the locale...is that automatic?

We can add a test to confirm but I believe it's because the month wasn't being recreated (which handles that automatically if not specified)

Also closes #725

Are you sure about that? It seems that is asking of dynamically set the first week of the day based on the locale...is that automatic?

We can add a test to confirm but I believe it's because the month wasn't being recreated (which handles that automatically if not specified)

Do you know of a locale that has a different starting day?

Also closes #725

Are you sure about that? It seems that is asking of dynamically set the first week of the day based on the locale...is that automatic?

We can add a test to confirm but I believe it's because the month wasn't being recreated (which handles that automatically if not specified)

Ok checked and it's true...adding a test for that too

You're incredible! Can we make the same changes to the Range Calendar? If you don't have time I can take care of it!

I should be able to do it


Load recent data from PDMR

Description
As a developer, I want to load the latest PDMR data to the PDX Finder.
Acceptance criteria

[x] data validation
[x] data loaded to K8

@zperova there are hundreds of full genes expression data sets available for us on PDMR. I think we all forgot about this. It might be a good time to consider extending our current pipelines to retrieve and format this data the the PDX Finder.

Will not load for this release to focus on existing models' metadata improvements.

Data is validated and mutation data is lifted to genome assembly GRch38 and is ready to be loaded. I will load it when I have access to my EBI device.

Left to do:

copy data from local repo to Kubernetes
prepare the data - reload h2 database
mapping in Admin UI @zperova
run ETL to load mapped data

New ticket for these:

[ ] mapping of unmapped entities
[ ] run ETL for validation

closing


fix "Cursor disappear if we choose the same currency from the currency selector"

Details
We should focus input only when select currency modal closed and input screen is active again
Fixed Issues
$ https://github.com/Expensify/App/issues/11095
PROPOSAL: https://github.com/Expensify/App/issues/11095#issuecomment-1251267647
Tests

Click FAB -> Request/Send money or Go to any chat -> Request/Send money
Choose the currency which is already selected
Verify that cursor doesn't disappear

[x] Verify that no errors appear in the JS console

PR Review Checklist
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps

Click FAB -> Request/Send money or Go to any chat -> Request/Send money
Choose the currency which is already selected
Verify that cursor doesn't disappear

[ ] Verify that no errors appear in the JS console

Screenshots
Web
https://user-images.githubusercontent.com/96077027/195514059-8d78df8b-31a5-4fd2-8fdb-5836f560abd3.mov
Mobile Web - Chrome
https://user-images.githubusercontent.com/96077027/195514112-fca8c130-214c-40db-aa08-5091ae3bddd4.mp4
Mobile Web - Safari
https://user-images.githubusercontent.com/96077027/195514161-4874a557-aaac-47c8-9eac-424b0c1b5ef4.mov
NOTE: This doesn't work on mobile safari even if choose different currency from currency selector before this fix, so it's not a regression. We can handle mobile safari issue in separated GH.
Desktop
https://user-images.githubusercontent.com/96077027/195514192-a9025a19-9297-4cd6-8890-6d0da3bcbdd1.mov
iOS
https://user-images.githubusercontent.com/96077027/195514239-e4b414cf-7b1a-459b-a3b5-46d99f1c5988.mov
Android
https://user-images.githubusercontent.com/96077027/195514258-7c962ffa-86ee-45cb-abd5-dcc47c8f2b18.mp4

Tests passed

🚀 Deployed to staging by @thienlnam in version: 1.2.16-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@aimane-chnaif
Do we need to create a new GH issue  for mWeb/Safari base on your note below? Please let me know.
NOTE: This doesn't work on mobile safari even if choose different currency from currency selector before this fix, so it's not a regression. We can handle mobile safari issue in separated GH.
https://user-images.githubusercontent.com/93399543/196172238-56b56d05-758c-41f1-b234-3835c3e57664.mp4

@kbecciv So we don't have to create a new issue for now. There are many similar issues for the problem.
I agree to create a tracking issue for these. cc: @thienlnam

Sounds good! Thank you both for quick reply.

🚀 Deployed to production by @sketchydroide in version: 1.2.16-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


chore: remove unused import

I added that import by accident in https://github.com/foundry-rs/forge-std/pull/384.


Removes special character from input string

Hi,
I am trying to convert with Init cap, it works a perfectly great job, But whenever input contains Special Characters (@#$&&), it will remove that chars from Sting.
Input => address first line @#$
output=> Address First Line.
Thanks

This is working as intended.

Some times  use case is different, In my case needs to make address fields init cap
for ex : mg street , pune 123#
expected output => Mg Street , Pune 123#

This package won't be able to do that for you, you'll be better off writing the logic for yourself. E.g.
value.replace(/\s\S/g, x => x.toUpperCase())


Colab problem: The expanded size of the tensor (10) must match the existing size (11) at a non-singleton dimension 1.

I put up a quick colab hoping for this to work, but when running the demo I get an error:
Here is the Colab.
Running the test.py --epoch...
unet/config.json: 100% 743/743 [00:00<00:00, 2.91MB/s]   diffusion_pytorch_model.safetensors: 100% 3.44G/3.44G [00:34<00:00, 99.9MB/s]   Traceback (most recent call last):     File "/content/DreamPose/test.py", line 48, in <module>       unet = get_unet('CompVis/stable-diffusion-v1-4', "ebb811dd71cdc38a204ecbdd6ac5d580f529fd8c", resolution=512)       File "/content/DreamPose/models/unet_dual_encoder.py", line 30, in get_unet       unet.conv_in.weight[:, 4:] = torch.zeros(unet.conv_in.weight[:, 3:].shape) # new weights initialized to zero
RuntimeError: The expanded size of the tensor (10) must match the existing size (11) at non-singleton dimension 1.  Target sizes: [320, 10, 3, 3].  Tensor sizes: [320, 11, 3, 3]

+1

+1

I solved this by making the following changes to in this file   models/unet_dual_encoder.py  line 30
https://github.com/johannakarras/DreamPose/blob/5bf30b7df70cf6f2e0bb25556c6ff2cbf0f2b1bf/models/unet_dual_encoder.py#L30C1-L30C117
        unet.conv_in.weight[:, 4:] = torch.zeros(unet.conv_in.weight[:, 3:].shape) # new weights initialized to zero

change to
        unet.conv_in.weight[:, 4:] = torch.zeros(unet.conv_in.weight[:, 4:].shape) # new weights initialized to zero


Remove runtime registered extensions after execution

This prevents a bug when an extension was registered in native, but the
native execution aborted without removing the extension again. Now, when
executing the wasm code the extension is still registered and it fails
of being registered. So, the wasm execution fails as well. This can
happen for example for the VerificationExt.
polkadot companion: https://github.com/paritytech/polkadot/pull/1773

bot merge


Can't create audio, if import from another thread.

My play func:

If i directly call "play" function, sound play, but if i use call from timer, sounds just not play:

My other code:

Audio imported successfuly, but audio from "CreateSound2D" is not valid.

The timer doesn't execute the function from another thread but still from the same game thread. As for your issue with the sound wave not being played back when executed from the timer, it might be due to various reasons. For example, your object might be garbage collected during the import, and that's why the OnResultNative never gets broadcasted, not sure about your particular context.

Accidentally closed the issue. So, if you have any other context, please let me know.

Found solution, just this function in UE5 just broken:

they return nullptr if WorldContextObject is World object.

UWorld* World = GEngine->GetCurrentPlayWorld(nullptr);
Also return null into ur delegete func.

The OnResultNative delegate is executed in the game thread, so there should be no difference between executing your game logic-specific code and the code after OnResultNative in terms of their behavior, as all the delegates in the plugin broadcast the state externally to the game thread. So, I believe the issue is simply that the world of your UGothicUE5Dialog is invalid by the time you tried to obtain it. If you want, you could also directly pass the WorldContextObject in your UFUNCTION, which is especially relevant if you call it from a Blueprint class, as it almost always has a valid world in the majority of contexts:
UFUNCTION(BlueprintCallable, meta = (WorldContext = "WorldContextObject"))
void Play(UObject* WorldContextObject);

Please feel free to reopen this issue if it's still relevant.


Hardhat style console.logs don't work for uint

From https://github.com/gakonst/foundry/blob/bab7e2d672bf9459645c01201b37e6fcfd257521/evm-adapters/src/sputnik/cheatcodes/cheatcode_handler.rs#L746 it looks like the method signature is always for log(uint), but the abigen seems to only produce signatures for ethers::core::types::U256.
If you need more information let me know, you can easily repro by adding a console.log with any uint value to the console tests.
Happy to submit a PR if you can point me in the right direction (also DSTest logs work just fine).

nice catch,
so what's happening under the is that abigen! takes the console.log json https://github.com/gakonst/foundry/blob/master/evm-adapters/testdata/console.json and generates Binding for all those calls
However the type for p0 of function log(uint p0) is actually uint256 the the json (format it then line 8762):
  {
    "inputs": [
      {
        "internalType": "uint256",
        "name": "p0",
        "type": "uint256"
      }
    ],
    "name": "log",
    "outputs": [],
    "stateMutability": "view",
    "type": "function"
  },

however the function uses log(uint) when sending the payload and the generated rust type is
        ///Container type for all input parameters for the `log`function with signature `log(uint256)` and selector `[248, 44, 80, 241]`
        #[ethcall(name = "log", abi = "log(uint256)")]
        pub struct Log333Call {
            pub p_0: ethers::core::types::U256,
        }

I believe editing the type manually in the json file for log(unit) and log(int) should work, we also want a test for that so in the event we have to recompile the console.json we're reminded of that.

Ah ok, thanks for the explanation! What are your thoughts on changing console.sol to explicitly match the generated ABI like:
-    function log(uint p0) internal view {
-        _sendLogPayload(abi.encodeWithSignature("log(uint)", p0));
+    function log(uint256 p0) internal view {
+        _sendLogPayload(abi.encodeWithSignature("log(uint256)", p0));
     }

The only things I could think of were if they aren't always equivalent or if the upstream Hardhat file changes it's more annoying to track/maintain.
In the meantime I'll take a look at the abigen! proc_macro stuff (I don't know Rust, but this has been an enjoyable way to learn).

The only things I could think of were if they aren't always equivalent or if the upstream Hardhat file changes it's more annoying to track/maintain.

that's the point against it, lets simply support more functions instead of editing the ABI which might cause problems down the line.
This is basically how the EthCall macro works:
https://github.com/gakonst/ethers-rs/blob/0b1f3b1dcfcd4a16d455af7850c75b29d366cf22/ethers-contract/tests/common/derive.rs#L432-L438
So what we should do here is:

add two more structs that derive EthCall (LogUint LogInt) same as above
try to decode them here as well: https://github.com/gakonst/foundry/blob/bab7e2d672bf9459645c01201b37e6fcfd257521/evm-adapters/src/sputnik/cheatcodes/cheatcode_handler.rs#L265-L268

We probably want to try to decode them first, since they are more common than most of the console log calls

When viewing the expanded output, I can see that despite #[ethcall(name = "log", abi = "log(uint)")], the signature is still log(uint256):
#[ethcall(name = "log", abi = "log(uint)")]
pub struct LogUint {
    pub p_0: ethers::core::types::U256,
}

...

impl ethers::contract::EthCall for LogUint {
    fn function_name() -> ::std::borrow::Cow<'static, str> {
        "log".into()
    }
    fn selector() -> ethers::core::types::Selector {
        [248, 44, 80, 241]
    }
    fn abi_signature() -> ::std::borrow::Cow<'static, str> {
        "log(uint256)".into()
    }
}

It seems to come down to ethers-core/src/abi/human_readable.rs#L333 returning a Uint(256) for "uint": ethabi/src/param_type/reader.rs#L147. I'm not really sure the best way to work around this right now.
If this has reached the cost/benefit tipping point where explaining things isn't worth it and you want to just move on I won't mind, I certainly appreciate the help so far (but would still be interested in seeing this through if you are open to it).

ah interesting, I guess that makes sense since unit really is uint256.
Then we have to implement this by hand, which is fine.
This looks great and is basically it already! would you like to open a PR with that, we basically need:

[ ] Manual EthCall implementation for LogUint + LogInt, as you did already
[ ] add additional decoding checks to where we already try to decode ConsoleCalls

Ah I didn't even think to copy the expanded output, I think the cargo expand disclaimer made me wary.
Sounds good! I'll open a PR when I get a chance.


Filter the result from params

New feature. The idea is to create a FilterStruct that can be used to filter the result of a query using the request's query params. The dev can give the rules to the structure and use it on the action he/she wants.
type FilterStruct struct {
    OnlyParams   [] FilterRuleParams
    WithDefaults [] FilterRuleWithDefault
    MustFilter   [] FilterMust
}

OnlyParams will hold the rules that take the model field, the param field to look up and a FieldRule
WithDefaults will hold the rules that take the model field, the param field, the FildRule and a default value that will be used if no param field was found in the request
MustFilter will hold the rules that take the model field, the FieldRule and the value (so these rules won't look to the request query params)

The FieldRule can be some constants like MinInt, Bool, MaxLength... and translate after to SQL
Paginator can be used as a base to wire this with pop/{Connection, Query}
Example: django-filters

This can kinda be done with Scoping...this just seems a tad heavy  to me...unless I am missing something...

I feel identified with this solution, and actually, we're doing something similar in our apps, I feel Scoping provides the base to build something like this but a FilterStruct could provide an upper level (actions level) and a generalization for filtering lists across the app.

@robbyoconnor now that I noticed this is in the pop repository, I'm not so positive about the idea, maybe we could build a filtering package that translates the filtering struct into a pop scope.

The idea of Scoping is a little bit different from Filtering. Usually when you scope, you filter with a know value, in filtering you get the values from the request params.
Of course you can use Scope for Filtering

maybe we could build a filtering package that translates the filtering struct into a pop scope

Since what the Scope method does is execute a function that will use Where why not using Where directly.

now that I noticed this is in the pop repository, I'm not so positive about the idea

I think too that it should be on a different package

Hey there.
I already wrote a filter package. You can find it here. The README file has a how to but it's pretty simple. Any thoughts and/or suggestions are welcome.
As for the pop package maybe the *Query can add a method Filter like
// Same as PaginationParams interface
type ParamProvider interface {
        Get(string) string
}

type Filterer interface {
        FilterQuery(*Query,  ParamProvider) *Query
}

func (q *Qurery) Filter(f Filterer, p ParamProvider) *Query {
        return f.FilterQuey(q, p)
}

Like this there are no external imports and the *Query can use the filter of your choice.


Issue with k8s.io/docs/tasks/tools/install-minikube/

This is a Bug Report

Problem:
user@user-VirtualBox:~$ sudo minikube start --vm-driver=virtualbox
! minikube v1.9.2 on Ubuntu 18.04
! Both driver=none and vm-driver=virtualbox have been set.
Since vm-driver is deprecated, minikube will default to driver=none.
If vm-driver is set in the global config, please run "minikube config unset vm-driver" to resolve this warning.

Using the none driver based on user configuration
Starting control plane node  in cluster minikube
Running on localhost (CPUs=3, Memory=5841MB, Disk=15052MB) ...
OS release is Ubuntu 18.04.4 LTS
Preparing Kubernetes v1.18.0 on Docker 19.03.8 ...

kubelet.resolv-conf=/run/systemd/resolve/resolv.conf
! This bare metal machine is having trouble accessing https://k8s.gcr.io

To pull new external images, you may need to configure a proxy: https://minikube.sigs.k8s.io/docs/reference/networking/proxy/

Proposed Solution:
Page to Update:
https://kubernetes.io/...

$ minikube version
minikube version: v1.9.2
$ kubectl version --client
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.2", GitCommit:"52c56ce7a8272c798dbc29846288d7cd9fbae032", GitTreeState:"clean", BuildDate:"2020-04-16T11:56:40Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

OS: $ uname -a
Linuxuser-VirtualBox 5.3.0-46-generic #38~18.04.1-Ubuntu SMP Tue Mar 31 04:17:56 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
I am trying to install and configure kubectl and Minikube in a VPN and inside company proxy

Hi @vetbijaya. I would suggest you move this issue to https://github.com/kubernetes/minikube. Additionally, look at the instructions at https://minikube.sigs.k8s.io/docs/start/ to install minikube.
The --vm-driver has been deprecated. Try -
sudo minikube start --driver=virtualbox

Looks like you are not able to access https://k8s.gcr.io, you will need to configure a proxy mentioned in the output of minikube start.

I was able to run minikube using sudo minikube start --driver=virtualbox now but it keeps on crashing the Ubuntu while trying to start. Can you help me how to resolve that? Is there any known issue with minikube configuration hosted on Ubuntu on Virtual Box?
Regarding the proxy configuration, I already have set that in environment variables.

@vetbijaya  Please don't run minikube as root or with 'sudo' privileges. It isn't necessary with virtualbox driver.

@RA489 I already solved the above issue. Thank you!


GSC workloads are failing during the signing process with the error unknown loader.entrypoint.

Description of the problem
As part of latest commit 87c752f3a61d578b8e2c600e2305aca99c44d812 loader.entrypoint has been removed, This change has not been backported to GSC, causing all workloads to fail during the signing process.
Steps to reproduce

docker build --tag ubuntu20.04-bash --file test/ubuntu20.04-bash.dockerfile .
./gsc build --insecure-args ubuntu20.04-bash test/ubuntu20.04-bash.manifest
./gsc sign-image ubuntu20.04-bash enclave-key.pem
Expected results
GSC signing build should be successful
Actual results
./gsc sign-image --remove-gramine-deps bash-test enclave-key.pem
Signing graminized Docker image `gsc-bash-test-unsigned` -> `gsc-bash-test`...
Step 1/12 : FROM gsc-bash-test-unsigned as unsigned_image

 ---> 72a80de071dc
Step 2/12 : ARG BUILD_ID

 ---> Running in 2890a1a7d571
Removing intermediate container 2890a1a7d571
 ---> e8b372551d8a
Step 3/12 : LABEL build_id=$BUILD_ID

 ---> Running in 6eb0aaa7c61f
Removing intermediate container 6eb0aaa7c61f
 ---> 3feec5ba6ac7
Step 4/12 : COPY gsc-signer-key.pem /gramine/app_files/gsc-signer-key.pem

 ---> 28254e568bf3
Step 5/12 : ARG passphrase

 ---> Running in 76a6610bf14c
Removing intermediate container 76a6610bf14c
 ---> 4b507cbeb027
Step 6/12 : RUN export PYTHONPATH="${PYTHONPATH}:$(find /gramine/meson_build_output/lib -type d -path '*/site-packages')" && gramine-sgx-sign       --key /gramine/app_files/gsc-signer-key.pem       --manifest /gramine/app_files/entrypoint.manifest       --output /gramine/app_files/entrypoint.manifest.sgx       ${passphrase:+--passphrase "$passphrase"}

 ---> Running in 0f4e73cf1f12
Traceback (most recent call last):
  File "/gramine/meson_build_output/bin/gramine-sgx-sign", line 174, in <module>
    main() # pylint: disable=no-value-for-parameter
  File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 1434, in invoke

    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.10/dist-packages/click/core.py", line 783, in invoke

    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/click/decorators.py", line 33, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/gramine/meson_build_output/bin/gramine-sgx-sign", line 130, in main

    manifest = Manifest.load(manifest_file)
  File "/gramine/meson_build_output/lib/python3.10/site-packages/graminelibos/manifest.py", line 388, in load

    return cls.loads(f.read())
  File "/gramine/meson_build_output/lib/python3.10/site-packages/graminelibos/manifest.py", line 384, in loads
    return cls(s)
  File "/gramine/meson_build_output/lib/python3.10/site-packages/graminelibos/manifest.py", line 348, in __init__
    raise ManifestError('Unknown loader.entrypoint format (not a TOML table)')
graminelibos.manifest.ManifestError: Unknown loader.entrypoint format (not a TOML table)

Removing intermediate container 0f4e73cf1f12
Failed to build a signed graminized Docker image `gsc-bash-test`.

@anjalirai-intel: Would you pls help test if https://github.com/gramineproject/gsc/pull/225 resolves the issue? Thanks!

@kailun-qin I tested the PR #225 with Ubuntu 22.04 distro. No issue to report, gsc signing was successful.


Fast breeder reactor upkeep

The Fast Breeder Reactor has an optional enrichment recipe that is done automatically if blankets are provided but doesn't throttle the main reaction.
This is currently modeled by having the enrichment process as a separate recipe. However, the enrichment node still contributes to the population, maintenance and computing requirements.
I don't know the best solution, but potentially creating a different node specifically for the enrichment process would be the simplest solution.

Hello.
For backward compatibility I left this enrichment process as separate recipe, because it was like this in previous version. I didn't think about upkeep cost.
I could merge this recipe, so FBR will have either plain fuel-to-steam recipe and fuel-to-steam+enrichment.
Actually enrichment process cannot work without fuel-to-steam, and this will follow in game behavior close enough.

The opposite is true though, and in a balanced system the enrichment is
over producing slightly.
On Thu., Jun. 8, 2023, 11:28 Alexey Usov, @.***> wrote:

Hello.
For backward compatibility I left this enrichment process as separate
recipe, because it was like this in previous version. I didn't think about
upkeep cost.
I could merge this recipe, so FBR will have either plain fuel-to-steam
recipe and fuel-to-steam+enrichment.
Actually enrichment process cannot work without fuel-to-steam, and this
will follow in game behavior close enough.
—
Reply to this email directly, view it on GitHub
https://github.com/doubleaxe/daxfb-calculator/issues/6#issuecomment-1582823554,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBNRB4GGYTO7ZLXRMCC6E3XKHVQ5ANCNFSM6AAAAAAY6L44EM
.
You are receiving this because you authored the thread.Message ID:
@.***>

Made this:

It will be a little quirky if you want parts of this recipe to have different rates, you will have to use storages to supply/remove exceed resources, but it is most I can do without changing many parts of project.

Fixed in v1.0.20