step 22 hotel feedback form small fixes

https://github.com/freeCodeCamp/freeCodeCamp/blob/db5854ecf6900af4ce952b4d2bd536ea75aa9671/curriculum/challenges/english/25-front-end-development/workshop-hotel-feedback-form/66a96127422411756204bc1b.md?plain=1#L10-L12
Needed fixes:
Below the label element => Below the `label` element
another checkbox input => another checkbox `input`
Add another label => Add another `label`

This looks like something that can be fixed by "first-time" code contributors to this repository. The files you should look at to work on a fix are those linked above.
Please make sure you read our guidelines for contributing, we prioritize contributors following the instructions in our guides. Join us in our chat room or our forum if you need help contributing; our moderators will guide you through this.
Sometimes we may get more than one pull request. We typically accept the most quality contribution followed by the one that is made first.
Happy contributing.

I have submitted a PR above that fixes this issue. Please tell me if I need to improve this PR


Update docker image when a release is patched

We were encountering an issue that was fixed with CARLA <IP_ADDRESS>, but then we saw that the CARLA 0.9.7 docker image wasn't upgraded to the latest binary release of CARLA 0.9.7.x.  Please rebuild the applicable docker images when a new patch is released.
$ docker pull carlasim/carla:0.9.7
0.9.7: Pulling from carlasim/carla
Digest: sha256:0828ebed3bd6c38e2fe27f93cb0b36e4342fa241407d1f64d1c18ac4b04aa201
Status: Image is up to date for carlasim/carla:0.9.7
docker.io/carlasim/carla:0.9.7
$ docker run --rm carlasim/carla:0.9.7 cat VERSION
0.9.7
$ tar -I pigz -xf CARLA_<IP_ADDRESS>.tar.gz
$ cat VERSION
0.9.7-12-g1f7669e

@qhaas you are right. We will take care of this. Sorry for the inconvenience.
Adding @bernatx to give this the right visibility.


Balance between HMM training and setting of initial probabilities?

In the Literature, people have used a simple Left-Right model or a ergodic model as a baseline for their hidden Markov Model. I have not come across a publication, in which the probabilities have been extracted from data. This makes sense, as in a usual usecase of the hidden markov model we cannot observe the hidden state, thus we cannot gather information about state transitions or emissions.

It should be said though, that in our case we should make use of prior gathered information by extracting and constructiong initial state probability vector as well as transition and emission matrices. Since the EM Algorithm finds only local optima, it is sensitive to its starting point. Thus, if we give the algorithm a better starting point, e.g. the transition/emission matrices, we obtain a good model alomst instantaniously. The question becomes if we should apply smoothing to the gathered information, and then train the model on the observation seqeunces or if we should simply set the emissions/transitions/init probabilities as is.


Revert "Disable F40 CI (CVE-2024-3094 response)"

F40 is safe to use again
This reverts commit 0cc7cc99e69272acbcf357516688512a9654b95d.

We should wait on this until https://github.com/osbuild/osbuild/pull/1769 and/or https://github.com/osbuild/osbuild/pull/1768 are merged, otherwise it's just more churn :/

There may be some issues with f40 runners? Need to wait for https://github.com/osbuild/images/pull/725 and https://github.com/osbuild/images/pull/716 to get sorted out so I'll convert this to a draft.

Already done in 2e4793907d80b24fadb7d528463dde2e0a06797d


High cpu usage MacOS

Hello everyone.
The last days ( later last release ) VS code is using a lot of CPU.
What is it?

Someone can help?

Hi @roblourens,

So, the problem is with the extension?

Yes, please file an issue on that extension's repo


Add version infomation to image_hashes file

This is to stop issues when the image implicitly changes e.g. assisted installer version is bumped. Before this the user would have to know that they need to remove the image hashes file to get the new version.

Closing pull request as project is being archived.


Failed to publish to RTSP server after leaving the screen still for a few second

Hi pedroSG94,
I am using DisplayService and RtspSender. I am capturing my phone screen and publish it as a RTSP stream to a RTSP server. I found that if I do not move the phone screen for a few second, there will be log "RtspSender: Skipping iteration, frame null" and then it stops publishing to the server. Do you have any idea on how can I still publish the screen even it is not moving?
Thank you so much.

Hello,
Maybe this is related with your case:
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/issues/960
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/issues/63

thx. #960 resolved my problem.


Don't issue PhanTypeReturnMissing if the method always throws

This isn't a complete implementation of the 'only possible to throw'
definition, but seems like a reasonable first start. If the only way
to exit a function is a throw then the return isn't missing, and it
will never return the wrong value.
This is usefull for patterns where a base class defines a method
with a return type, but the implementation is to throw a
NotImplemented exception.

I realize this (the new private method) isn't really the standard pattern for analyzing code in Phan. If you have suggestions on a better way (new visitor?) i can work that out.

Great idea @ebernhardson.
I think I'm comfortable solving just this special case. Solving just for a single throw and not any kind of branching will add some complexity in explaining the rule to folks, but the frequency of this special case is probably high enough to justify it.
Was there anything else you wanted to add to this patch, or shall I merge it?

I'm happy with the patch, merge away.


docs: Fat container documentation fixes

Added additional details about how to use the fat container, and how to manage / maintain it.
Also includes some refactorings that shouldn't affect the functionality significantly.

@mohanarpit, also, I've also renamed the fat_container folder to just docker, since it'll be the only way forward.

@mohanarpit, just resolved conflicts (!). Can you approve again please?

@mohanarpit, really sorry for bothering you so much today, but noticed a problem just now. The Dockerfile was still referring to fat_container. Fixed and pushed. Can you approve again please? Thanks 🙏


⚠ Bofrost.lu has degraded performance

In 86f8bef, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1315 ms

Resolved: Bofrost.lu performance has improved in fa20197 after 7 minutes.


Add documentation files for the new methods

Fixes #40 #19

@ChrisRackauckas I'll merge this now, if there's something more needed let's do that from a new PR.

Thanks!


Allows containers to connect to host local-only services such as databases

Takes the following very common pattern : a server hosts a database (say mysql) and several web applications. Those webapp are .. well, webapps, and hence present huge security risks, especially if coded in php or ruby.
So we dockerize them. The user feels no need to dockerize the database, among other reasons because  there are other (undockerized) programs than webapps that connect to it.
The database is listening to <IP_ADDRESS>:XXX (3306 for mysql).
With current docker (1.5.0), this setup up is not possible. Containers can not connect to the database. There are quite some people asking for this on internet (check stackoverflow, some blogs, and this tracker).
Common "solutions" involve either

opening the database (<IP_ADDRESS>:PORT instead of <IP_ADDRESS>:PORT), which is a no-go for some obvious reasons

make the database listen to the interface docker0. This prevent other services to connect to the database, and is error-prone (the database must be started after docker). Moreover, mysql documentation explicitely mentions that it is not possible for mysql to connect to two interfaces (here docker0 and localhost). "solutions" mentionning the docker option "--add-host" fall in this category.

using docker run option "--host=net" (my current favorite), which makes the container far less secure by NOT using network separation. This is a kinda tradeoff between using docker and not.

I'm pretty sure this is fundamentally impossible without --net=host... but I'll leave to others smarter than I to confirm and close.
One other alternative would be to setup a veth pair and have mysql listen on that.

Err.. my understanding is that it's not currently possible. The ticket is about requesting this feature. The use case seems quite important, isn't it ?

@orzel What I'm saying is it is technically impossible to do this.
Localhost on the host is local only. You can only share localhost's if you are in the same net namespace.
So you can either --net=host or you don't use localhost.

It's also "impossible" to connect the container's network stack with outside, but somehow docker manages to do it (i see something with "proxy" with netstat on the host).

No, it's not impossible to connect the container's network stack, this is done via the bridge and some iptables natting.
But also, the host cannot connect to the container's localhost, and vice-versa.
You can setup a proxy to proxy connections to localhost, but then that proxy would need to be listening on something not localhost... which defeats the purpose of having it on localhost.

Aside from what cpuguy83 has said, unix domain sockets would both solve this issue, and give you a performance boost as well.
Databases, such as postgres & mysql, support listening on unix domain sockets instead of TCP sockets. The advantages here are that you can forward unix domain sockets into a container via a volume mount (docker run -v). Unix domain sockets are also faster than TCP sockets as they don't have to go through the normal network stack. Unix domain sockets are also more secure, as you can set permissions on the socket file, where as with binding to TCP <IP_ADDRESS>, anyone with access to the box can connect.

I know very well what sockets are and i actually use them locally as well. I'm totally sold to sockets :-)
It's not always possible though (typically, i use some vserver that can't access it, but can connect to <IP_ADDRESS>).
I hadn't thought about connecting to those from containers though, and that seems indeed a good idea.
iiuc, you mean something like
docker run -v /var/run/mysqld/mysqld.sock:/var/run/mysqld/mysqld.sock (...)
right ?
Or maybe only using the directory, i'm not sure if docker can 'volume' mount a file of such kind (socket).
anyway, thanks for the hint.

Docker can volume mount sockets without issue. However the one catch that would encourage using the directory. When the daemon listening on the socket restarts, it has to unlink and create a new socket. Thus if docker is sharing the named socket explicitly, it'll be sharing the old one. Thus it's better to share the directory in this case.
As for applications which only support domain sockets, I just throw socat into the image, and start it up in the background inside the container (having it listen on <IP_ADDRESS>, and forward to the named socket).

@phemmer : this last post of you is VERY useful. You should consider adding this to some documentation somewhere or at least in a blog post. I will definitely (volume) share the directory instead of the socket. I didn't know about socat, this is something very useful to know about in this context.
Thanks a lot !

@orzel https://docs.docker.com/userguide/dockervolumes/#mount-a-host-file-as-a-data-volume
I'm going to go ahead and close this one, let me know if you think there's something else we can do here.
Thanks!

er??? I know how to use both types of docker 'volumes'. That's not the point.
My point about documentation is that both excellent Phemmer's points should be added to the documentation.

use volumes to make the socket available in container, using a volume on the directory containing the socket instead of only the socket.
use socat to provide a localhost(<IP_ADDRESS>) tcp connection inside the host from a socket

Note that this solves my problem, but not all cases. Typically if a service is only available as tcp on the host, containers can't use it.
The request feature is about accessing local-only (<IP_ADDRESS>) tcp services on the host from containers, and is still valid (or isn't it?).

@orzel I would say it's not valid since it is literally impossible to do this.


Setup automatic updates

Feature Request
Setup reference to source repository and make new builds and commits are found on main branch.

probably better to use the NuGet reference


Run Azure tests grouped on the CI thus saving some time

@llowinge this adds a new azure group. Note that AZURE_BLOB_CONTAINER_NAME was renamed to AZURE_EVENT_HUBS_BLOB_CONTAINER_NAME

Seems to save some time. Here is the job execution before the change

and here it is after the change


Support Rack 2.1.x

It hasn't been released it yet, however, that PR changes internals and breaks the integration.
Do you think it will be fine to not test against Rack edge? Otherwise, all open PRs will fail :disappointed:

We should be calling out that this will affect Grape. I'll add a comment.

@dnesteryuk Let's make sure we have a plan forward. Can you help form an educated opinion about what should happen? a) change grape, if so how, and can it be backward compatible b) push back on the change in Rack before it gets released.

Can you explain why this breaks grape?

Unfortunately, I don't know Grape internals very well. What I see Grape middlewares get "broken" response.
[#<Rack::Response:0x00005609074ab198 @status=200, @header={"Content-Type"=>"application/json"}, @writer=#<Method: Rack::Response(Rack::Response::Helpers)#append>, @block=nil, @length=0, @body=["null"], @buffered=false>, nil, nil]

for example, there.
The expected response is:
[200, {"Content-Type"=>"application/json"}, ["null"]]

Maybe some Grape middleware does something weird, so Grape gets broken because of the change in Rack. I don't know yet... :disappointed:

Can you explain why this breaks grape?

Haven't debugged. It breaks specs. Unclear whether it breaks Grape.

Closed by https://github.com/ruby-grape/grape/pull/1956 I believe, thanks @ioquatix


knative deployer failed to update the Knative Service:    referenced Secret xxxis not present

Hi,
I got this issue when re-reploying a service:
func deploy --remote
...
arning: git settings are only applicable when running with --remote.  Local source code will be used.deploy error: knative deployer failed to update the Knative Service:
  referenced Secret "bing-apikey" is not present in namespace "agent-less"

Error: knative deployer failed to update the Knative Service:
  referenced Secret "bing-apikey" is not present in namespace "agent-less"

However, the secret does exist in this namespace:
kn secret list -n agent-less
NAME                                        TYPE
bing-apikey                                 Opaque

I have a env using secret in the func.yaml:
run:
  envs:
  - name: BING_API_KEY
    value: '{{ secret:bing-apikey:apiKey }}'

This issue only happens when re-reploying a function. The workaround is to delete the existing function first before deploy it:
func delete -n agent-less bing-search-tool
Removing Knative Service: bing-search-tool
Removing Knative Service 'bing-search-tool' and all dependent resources

func deploy --remote

This does seem like a bug if you can work around the issue by removing/deploying again.

after debugging, I find the cause is that the default service account does not have permission to get the secret.
secrets "xxx" is forbidden: User "system:serviceaccount:agent-less:default" cannot get resource "secrets" in API group "" in the namespace "agent-less"

func/pkg/knative/deployer.go:
func checkResourcesArePresent(ctx context.Context, namespace string, referencedSecrets, referencedConfigMaps, referencedPVCs *sets.Set[string], referencedServiceAccount string) error {

	errMsg := ""
	for s := range *referencedSecrets {
		_, err := k8s.GetSecret(ctx, s, namespace)
		if err != nil {
			// here
			errMsg += fmt.Sprintf("  referenced Secret \"%s\" is not present in namespace \"%s\"\n", s, namespace)
		}
	}

Thanks for running through the debugging!
From my experience, by default a Function deployed (which is just a regular service) has access to secrets in the namespace to which it was deployed.  This may require a change to the cluster's configuration, or way to specify the permissions with which it executes.

Yes, it could be fixed easily by adding permission to the service account. Maybe we can improve the error message by adding something like the original error so that it will not be confusing.


[Question] How to install this package?

Hi, first of all thanks for this nice library, I have following instruction on README to install on my apps but got wrong package installed (https://www.npmjs.com/package/react-native-worklets) I think it is wrong package? does react-native-worklets is available on npm registry ?

can confirm! yarn add react-native-worklets installs the wrong package. there is no lib directory, no type defs, and the version it installs is 0.0.1-alpha

          From what I've tested, it works perfectly with Expo, but the installation command is applying the wrong version. As a temporary solution, I did the following:

Installation via:
npm install chrfalch/react-native-worklets#main
Import via:
import { Worklets } from "react-native-worklets/src"
Originally posted by @fabio-alss-freitas in https://github.com/chrfalch/react-native-worklets/issues/100#issuecomment-1576835293


add more model into benchmark and evaluate workflow

make evaluate dataset as an input in workflow; add more models into evaluation regression
react evaluate config to make it easy to maintain. Add llama3、qwen1.5 moe、kvint4 config for evaluate regression.
add more models into benchmark and modify max batch size in benchmark.
add more support models and remove some old models in regression test.

benchmark test record: https://github.com/zhulinJulia24/lmdeploy/actions/runs/8998731504
evaluation test record: https://github.com/zhulinJulia24/lmdeploy/actions/runs/9012663244

https://github.com/zhulinJulia24/lmdeploy/actions/runs/9015990252  this contains all


Code formatting cleanup

@Eshcar
I have already made the formatting fixes commented inline, but I wanted you to see them before this PR is merged.
I do have some more substantial design concerns.

Why do these concurrent classes need to be public,
And within these classes why do so many of the methods need to be public?
Ideally, only the Builder needs to be public ... and why do we need two builders?


Do you know  FLOPs of every model?

your only show params of every model in the table,but i need FLOPs of every model,can you show me.thanks

hi，another question，i can not download the box by the url in your file cifar10_download.by

No I don't have the statistic for FLOPS of every model.
I check the Box link and it is still working. However, I also add a new Google Drive link.


cloudflared: 2022.5.2 -> 2022.5.3

Description of changes
https://github.com/cloudflare/cloudflared/blob/2022.5.3/RELEASE_NOTES
cc: @ckiee
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 175487 run on aarch64-darwin 1

1 package built:

cloudflared

@ckiee are you on linux (just trying to narrow down variables)?

@techknowlogick I rebuilt it and now it's functioning fine, using NixOS, config here. Maybe disable the test and make an issue upstream mentioning it's intermittent?

Version 2022.6.3 was released three days ago. So you might consider updating your pr.

@kilianar thanks. I've updated to 2022.7.0

Closing as a newer PR includes these changes, and more


Fall back to suffix based entry type detection

Fixes #170
Changes proposed in this PR

Fall back to path suffix based entry type detection

Tests performed

I found a ZIP file where ZIPFoundation marks it as file while it is a directory. Originally it was an EPUB file, but due to copyright issues I've deleted entires using zip -d -r 'zip file.zip' 'paths...'.
Added a fixture and test called testReadingEntryTypes which checks read entry list with expected ones. Test properly failed without a patch

Further info for the reviewer
Test case introduces a struct for better readability. Had to implement Equatable protocol by hand due to missing auto-synthesis on swift 4.0
Zip file
Here is a problematic zip file testReadingEntryTypes.zip

Hi GRiMe2D,
Archives that don't specify their entry types aren't 💯 correct, but I think it makes sense here to be liberal when reading such archive.
Thanks for your contribution, great work!

Hi @weichsel, thanks for accepting PR and merging to the main branch. Can we actually create a release now? Because, our app relies on this patch and I want to replace patched fork with this original repository. Thanks!

Hi @weichsel, thanks for accepting PR and merging to the main branch. Can we actually create a release now? Because, our app relies on this patch and I want to replace patched fork with this original repository. Thanks!

Can we actually create a release now

Still need to perform some cleanups/tests but I will try to release a version in the upcoming days.


Can add custom stack to middleware fixes #227

Thanks Zack for the fix :heart: and sorry for such late reply!


chore(ci): add pin submodule and run codegen workflow

Summary
Add a workflow to bump and pin submodules on repository_dispatch event. It can also be triggered by workflow_dispatch with a commit id.
After the submodule is updated, the workflow will run codegen to generate potential new rule docs. When everything is done, this workflow will create a PR to update the submodule and the docs.
A newly triggered action will cancel the previous ongoing one of the same trigger event type. And actions triggered by the same event type will land in the same PR head branch.
I also updated the codegen project and cargo scripts. The previous setup has some issues.
repository_dispatch issuer is yet to be implemented in the main repo, it will need a personal access token.
Auto merge is implemented for update contributors and pin submodule codegen workflows. However there're some conditions that have to be met:

I'm going to mark this as draft because due to the nature of github actions I'll have to test them on the main branch. And I'm now testing new things so the main branch will be updated.

I think we have the proper settings now

Okay, I'm going to merge this to test whether it'll function in this repo.


Add Math functions & constants

I have an off-the-wall idea here: since these only work with numbers and not BigInts, maybe all of these should fold into the Number feature?

Merged into #1567


[1.1.4] Interface not responding

Extremely rarely when changing something the interface totally breaks and stops responding to user inputs. The suspicion is that this issue has something to do with box selection manager and/or rotation/move/scale gizmo locking up user inputs when it shouldn't, potentially due to incorrect ImGui.WantCaptureKeyboard and ImGui.WantCaptureMouse reporting

There had been no reports or signs of this issue since 1.1.11. Closing for now


[RFC] Add libs that are not yet present

First of all, I would like to say that this project is very cool, congratulations. I find out the project recently and I would like to know if there is a possibility to contribute adding the Libs that are not yet present in the project? Like tkinter and sqlite.

@youknowone thanks for the response, I found everything I needed where you indicated. The what_left.sh file helped a lot too.


Remove unnecessary https://profilesite.com/ from the database and add code to add it while using.

Tried removing it on localhost! There is not much memory reduction as expected! Going with current way would be best! Lot of code change required which also might break things.


Change to make the manual weight entry only show up when the site doe…

…s NOT recognize a scale as being present. If it recognizes a scale it will hide the field.

:+1:


No module named "dstruct"

Hey,
I noticed the release of TranscriptClean version 2 now in python3 and implemented multi threading, which is very nice, thank you.
However, I am getting the error "no module named "dstruct"". I am assuming this is the same dstruct.py from TALON, its just missing from the TranscriptClean repo.

Yes, looks like I simply forgot to add the dstruct.py class to Git! Thanks for catching that. I have uploaded the file now.


[BACKEND] Fix canonicalization of LocalLoad op

Currently, we create a new op at the location of the ConvertLayout op during canonicalization. For pure ops, it is fine, but for LocalLoad op, we need to create the new op at the location of the LocalLoad op (as memory could have been changed in between)
The core Triton is a small number of people, and we receive many PRs (thank
you!).  To help us review your code more quickly, if you are a new
contributor (less than 3 PRs merged) we ask that you complete the following
tasks and include the filled-out checklist in your PR description.
Complete the following tasks before sending your PR, and replace [ ] with
[x] to indicate you have done them.

[X] I am not making a trivial change, such as fixing a typo in a comment.

[X] I have written a PR description following these
rules.

[ X] I have run pre-commit run --from-ref origin/main --to-ref HEAD.

Select one of the following.

[/test ] I have added tests.

/test for lit tests
/unittest for C++ tests
/python/test for end-to-end tests

[ ] This PR does not need a test because FILL THIS IN.

Select one of the following.

[ ] I have not added any lit tests.
[X ] The lit tests I have added follow these best practices,
including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)

please run pre-commit hook

Sorry about that, have pushed with the pre-commit hook changes applied


Replication auto_check for nextgenrepl full-sync

The nextgenrepl aae full-sync supports a schedule of checks, where each type of check has a different scope:

all_check: Full-check over all time;
day_check: Check over the previous day only;
hour_check: Check over the previous hour only;
range_check: Check if and only if a previous check had highlighted a time range over which to constrain results;
no_check: Don't check.

The enhancement is to offer a further check type - auto_check:

auto_check:  If a range has been discovered, perform a range_check, otherwise if the current time is within the all_check_window perform an all_check, otherwise perform a day_check.

The all_check_window will consist of a start hour (0 to 23) and an end hour (0 to 23).  So setting the start hour to 23 and the end hour to 6, would prompt all_check between 23:00 and 06:59 and day_check between 07:00 and 22:59 (where a range_check cannot be triggered).
If no window is defined, then auto_check will always use all_check when no range has been discovered.
The default schedule will change for tictac aae full-sync from [{all_check, 24}] to [{auto_check, 24}].
There will be an additional remote_console command to allow for the window to be cleared or reset across the cluster at run-time.

From a configuration perspective the window should follow the model of the bitcask merge window.

https://github.com/basho/riak_kv/pull/1816


MATLAB.jl: Error loading MATLAB Module in OSX

Hi am new to Julia and have been trying to use MATLAB.jl. It installed just fine using the Pkg.add("MATLAB") command, but when I type using MATLAB , I get the following error:
ERROR: LoadError: LoadError: MethodError: `min` has no method matching min(::Array{Union(UTF8String,ASCIIString),1})
Closest candidates are:
  min(::Any, ::Any)
  min(::Any, ::Any, ::Any)
  min(::Any, ::Any, ::Any, ::Any...)
 in get_paths at /Users/arora/.julia/v0.4/MATLAB/src/mxbase.jl:20
 in include at /Users/arora/CODES/Julia_source/julia/usr/lib/julia/sys.dylib
 in include_from_node1 at /Users/arora/CODES/Julia_source/julia/usr/lib/julia/sys.dylib
 in include at /Users/arora/CODES/Julia_source/julia/usr/lib/julia/sys.dylib
 in include_from_node1 at /Users/arora/CODES/Julia_source/julia/usr/lib/julia/sys.dylib
 in reload_path at /Users/arora/CODES/Julia_source/julia/usr/lib/julia/sys.dylib
 in _require at /Users/arora/CODES/Julia_source/julia/usr/lib/julia/sys.dylib
 in require at /Users/arora/CODES/Julia_source/julia/usr/lib/julia/sys.dylib
while loading /Users/arora/.julia/v0.4/MATLAB/src/mxbase.jl, in expression starting on line 66
while loading /Users/arora/.julia/v0.4/MATLAB/src/MATLAB.jl, in expression starting on line 34

When I try running commands like restart_default_msession() I get errors lile ERROR: UndefVarError: restart_default_msession not defined
Do you know what could be going wrong here and how can this be fixed ? I am on Julia 0.4.  thanks a lot

I fixed this issue using the git cloned version instead of the Pkg.add() , but now I have a new error showing up:
ERROR: LoadError: LoadError: UndefVarError: RTLD_GLOBAL not defined
 in load_libmx at /Users/arora/.julia/v0.4/MATLAB/src/mxbase.jl:76
 in include at /Users/arora/CODES/Julia_source/julia/usr/lib/julia/sys.dylib
 in include_from_node1 at /Users/arora/CODES/Julia_source/julia/usr/lib/julia/sys.dylib
 in include at /Users/arora/CODES/Julia_source/julia/usr/lib/julia/sys.dylib
 in include_from_node1 at /Users/arora/CODES/Julia_source/julia/usr/lib/julia/sys.dylib
 in reload_path at /Users/arora/CODES/Julia_source/julia/usr/lib/julia/sys.dylib
 in _require at /Users/arora/CODES/Julia_source/julia/usr/lib/julia/sys.dylib
 in require at /Users/arora/CODES/Julia_source/julia/usr/lib/julia/sys.dylib
while loading /Users/arora/.julia/v0.4/MATLAB/src/mxbase.jl, in expression starting on line 84
while loading /Users/arora/.julia/v0.4/MATLAB/src/MATLAB.jl, in expression starting on line 34

I am trying to find a solution to this so any help is very welcomed :-) . thanks

So.. looks like I was able to track this problem down to RTLD_GLOBAL | RTLD_LAZY parameters. I think something must have changed from 0.3 to 0.4. The following call fails (with the above error):
libmx = dlopen(matlab_library("libmx"), RTLD_GLOBAL | RTLD_LAZY)
and I had to remove and RTLD_GLOBAL | RTLD_LAZY replace this command by
libmx = dlopen(matlab_library("libmx"))
...similarly for other dlopen function calls in mxbase.jl. After I did that, the module seems to load fine. Any clarifications on this are welcomed ?
thanks.

(was missing using Compat.Libdl)

Thanks for fixing it !


Fix export icon fill color inconsistency

Description

Changed control icon color from #000 to #333 (for consistency with the default MapLibre controls).
Improved formatting of the above referenced SVG string, specifically using percent-encoding (again for consistency) and swapping the use of " and ' (for the sake of proper convention as well as consistency).

Type of Pull Request
Bugfix, fixes #49.

[x] Code is up-to-date with the main branch
[x] No lint errors after pnpm lint
[x] Make sure all the exsiting features working well

@sudolev Thank you for your PR. Could you add changeset file in your PR by pnpm changeset for releasing package?


Formatting breaks in with statement with leading comments on as

with test as (
    # test
foo):
    pass

The above code gets formatted to:
with test as
# test
(foo):
    pass

Most likely this can be handled in a similar manner as done in #6594

Looks like this is still a problem.

It looks like there are a lot of deviations in our with formatting, I need to revisit it holistically.


Test

Please fill in all relevant information:
Check which applies

[ ] ACOM has approved (only relevant when creating new stock codes)
[ ] It is an existing code where the description needs modification
[ ] A new stock code that needs to be created
[ ] It is an existing code where the description needs modification
[ ] It is an existing stock code that needs to be split into 2 or more components

Please Provide information regarding the request below:
The existing code
The description
Which Benchmark, Expert Group or Workshop has requested a new stock code
The reason for the request
The contact Professional Officer for the request
When the Reference Management Group (RMG) receives the request, it will be reviewed and accepted or denied depending on the information given in this template.
Checklist for RMG

[ ] The request has been accepted
[ ] The request has been denied
[ ] The new stock code is created
[ ] The stock description has been changed
[ ] The old stock has been deprecated, and reference made to the new stock code(s)

The background of the denial of a request from the RMG
If the request is accepted the stock code will be created by the relevant data manager in the vocabulary, whereafter the Professional Officer needs to create a stock list record in SID by linking the stock code to the year(s) for which it is valid.

@Osanna123 , @MariaMakri , @cekv here is my go to it. Disregard formatting. Thanks

@MariaMakri Remove 'The reason for this request'
Change the 'Please select the most relevant case' to 'Please select one of the following cases'

@cekv @odontaster @MariaMakri @pcrjoana above is the version from me. The RMG part is changed a lot, as the previous steps looked more like a DM's procedure than an actual check-list for the request.
Still, I feel that the 'Request processed by the RMG' is normally covered by our labels (i.e. approvedAsIs, rejected, etc), so not sure if it's redundant and should be removed.


Substring out of bounds issues

Compiling using ifort 16.0.2 on Windows x64, with the build order determined from source analysis tools (dynamic-debug is simply a build directory).
>ifort /check:all /warn:all /standard-semantics /Od /traceback ^
    /Fe:..\dynamic-debug\packmol.exe ^
    /module:..\dynamic-debug\ ^
    /object:..\dynamic-debug\ ^
    sizes.f90 molpa.f90 usegencan.f90 initial.f90 feasy.f90 ^
    pgencan.f90 random.f90 packmol.f90 io.f90 polartocart.f90 ^
    geasy.f90 fgcommon.f90 heuristics.f90 cenmass.f90 title.f90 ^
    gencan.f
Intel(R) Visual Fortran Intel(R) 64 Compiler for applications running on Intel(R) 64, Version 16.0 Build 20160204
Copyright (C) 1985-2016 Intel Corporation.  All rights reserved.

initial.f90(18): remark #7712: This variable has not been used.   [CHECK]
                   movefrac,movebadrandom,check)
------------------------------------------^
initial.f90(546): remark #7712: This variable has not been used.   [PRECISION]
subroutine restmol(itype,ilubar,n,x,fx,solve,precision,seed)
---------------------------------------------^
initial.f90(546): remark #7712: This variable has not been used.   [SEED]
subroutine restmol(itype,ilubar,n,x,fx,solve,precision,seed)
-------------------------------------------------------^
random.f90(5): remark #7712: This variable has not been used.   [SEED]
double precision function rnd(seed)
------------------------------^
packmol.f90(709): remark #8291: Recommended relationship between field width 'W' and the number of fractional digits 'D' in this edit descriptor is 'W>=D+7'.
      write(*,"( /&
-------------------^
packmol.f90(709): remark #8291: Recommended relationship between field width 'W' and the number of fractional digits 'D' in this edit descriptor is 'W>=D+7'.
      write(*,"( /&
-------------------^
packmol.f90(709): remark #8291: Recommended relationship between field width 'W' and the number of fractional digits 'D' in this edit descriptor is 'W>=D+7'.
      write(*,"( /&
-------------------^
packmol.f90(792): remark #8291: Recommended relationship between field width 'W' and the number of fractional digits 'D' in this edit descriptor is 'W>=D+7'.
          write(*,"( /, 62('#'),/,                           /,&
----------------------------------------------------------------^
packmol.f90(792): remark #8291: Recommended relationship between field width 'W' and the number of fractional digits 'D' in this edit descriptor is 'W>=D+7'.
          write(*,"( /, 62('#'),/,                           /,&
----------------------------------------------------------------^
io.f90(880): remark #7712: This variable has not been used.   [FIX]
                  pdb,tinker,xyz,moldy,fix,&
---------------------------------------^
fgcommon.f90(511): remark #8291: Recommended relationship between field width 'W' and the number of fractional digits 'D' in this edit descriptor is 'W>=D+7'.
    write(98,"(i10,4(tr2,d13.7))") i, g(i), gbest, error, stepbest
--------------------------^
gencan.f(4): remark #7712: This variable has not been used.   [LAMBDA]
      subroutine evalal(n,x,m,lambda,rho,f,flag)
------------------------------^
gencan.f(4): remark #7712: This variable has not been used.   [RHO]
      subroutine evalal(n,x,m,lambda,rho,f,flag)
-------------------------------------^
gencan.f(62): remark #7712: This variable has not been used.   [LAMBDA]
      subroutine evalnal(n,x,m,lambda,rho,g,flag)
-------------------------------^
gencan.f(62): remark #7712: This variable has not been used.   [RHO]
      subroutine evalnal(n,x,m,lambda,rho,g,flag)
--------------------------------------^
gencan.f(125): remark #7712: This variable has not been used.   [N]
      subroutine evalhd(n)
------------------------^
gencan.f(2569): remark #7712: This variable has not been used.   [STEREL]
     +fmin,maxfc,iprint,fcnt,inform,xtrial,d,gamma,sigma1,sigma2,sterel,
-----------------------------------------------------------------^
gencan.f(2570): remark #7712: This variable has not been used.   [STEABS]
     +steabs,epsrel,epsabs,infrel,infabs)
------^
gencan.f(2570): remark #7712: This variable has not been used.   [INFREL]
     +steabs,epsrel,epsabs,infrel,infabs)
---------------------------^
gencan.f(2570): remark #7712: This variable has not been used.   [INFABS]
     +steabs,epsrel,epsabs,infrel,infabs)
----------------------------------^
gencan.f(2966): remark #7712: This variable has not been used.   [INFREL]
     +epsabs,infrel,infabs)
-------------^
gencan.f(3804): remark #7712: This variable has not been used.   [INFREL]
     +sigma1,sigma2,sterel,steabs,epsrel,epsabs,infrel,infabs)
------------------------------------------------^
gencan.f(3804): remark #7712: This variable has not been used.   [INFABS]
     +sigma1,sigma2,sterel,steabs,epsrel,epsabs,infrel,infabs)
-------------------------------------------------------^
gencan.f(5163): remark #7712: This variable has not been used.   [LAMBDA]
      subroutine calchd(nind,ind,x,d,g,n,xc,m,lambda,rho,hd,xtmp,sterel,
----------------------------------------------^
gencan.f(5163): remark #7712: This variable has not been used.   [RHO]
      subroutine calchd(nind,ind,x,d,g,n,xc,m,lambda,rho,hd,xtmp,sterel,
-----------------------------------------------------^
gencan.f(5163): remark #7712: This variable has not been used.   [XTMP]
      subroutine calchd(nind,ind,x,d,g,n,xc,m,lambda,rho,hd,xtmp,sterel,
------------------------------------------------------------^
gencan.f(5163): remark #7712: This variable has not been used.   [STEREL]
      subroutine calchd(nind,ind,x,d,g,n,xc,m,lambda,rho,hd,xtmp,sterel,
-----------------------------------------------------------------^
gencan.f(5164): remark #7712: This variable has not been used.   [STEABS]
     +steabs,inform)
------^
gencan.f(5164): remark #7712: This variable has not been used.   [INFORM]
     +steabs,inform)
-------------^

As long as the unused variables are expected, then the warnings appear mostly
harmless, assuming the potential for output fields full of asterisks is acceptable.
Then running using the water and urea example from http://www.ime.unicamp.br/~martinez/packmol/examples/mixture-comment.inp
>dynamic-debug\packmol.exe < mixture-comment.inp
##############################################################

 PACKMOL - Packing optimization for the automated
 generation of starting configurations for
 molecular dynamics.

                                          Version 16.070.3

##############################################################

  Packmol must be run with: packmol < inputfile.inp

  Userguide at: www.ime.unicamp.br/~martinez/packmol

  Reading input file... (Control-C aborts)
forrtl: severe (408): fort: (12): Variable RECORD has substring ending point 201 which is greater than the variable length of 200

Image              PC                Routine            Line        Source
packmol.exe        000000013F507C3E  Unknown               Unknown  Unknown
packmol.exe        000000013F4619EA  GETKEY                   1727  io.f90
packmol.exe        000000013F469BAF  GETINP                    108  io.f90
packmol.exe        000000013F44C276  MAIN__                    105  packmol.f90
packmol.exe        000000013F5A050E  Unknown               Unknown  Unknown
packmol.exe        000000013F585EBF  Unknown               Unknown  Unknown
kernel32.dll<PHONE_NUMBER>9C59ED  Unknown               Unknown  Unknown
ntdll.dll<PHONE_NUMBER>AFB371  Unknown               Unknown  Unknown

This is associated with the code stretch (in io.f90 around line 1727 as indicated above):
do while(record(i:i).gt.' '.and.i.le.200)
  i = i + 1
end do

where record is a CHARACTER(200) variable.  Fortran does not define the order of operand evaluation (nor require short circuiting logical operators), so that means that if i has the value 201, the substring reference record(i:i) may still be evaluated even if the second operand to .and. is evaluated to be false.
(Whether a problem is observable will depend on the compiler and compile options used.)
What was perhaps intended was something like:
do while (i .le. len(record))
  if (record(i:i) > '') exit
  i = i + 1
end do

When the loop ends, i will either be the index of a character "less than or equal to blank" in record, or it will be one past the end of record.  Note that subsequent code to that loop expects that i is within the bounds of record!  A complete fix requires the behaviour of this subsequent code to be examined.
The greater-than comparison with an all blank string is suspicious - I don't see why the program would want to depend on the collation sequence of the processor in that way (Perhaps the test is to cover both blank and tab?  If so - better to make that explicit).
if (is_whitespace(record(i:i))) exit

function is_whitespace(ch)
  character, intent(in) :: ch
  logical :: is_whitespace
  is_whitespace = (ch == '') .or. (ch == achar(9)) ! .or. whatever else...
end function is_whitespace

The inappropriate mixing of a test against string length with the substringing itself appears in a few places - I gave up after fixing three or so.

Thank you IanH, I fixed the bug by changing the loop to " ... .and. i .lt. 200 " instead of ".le.". The code that follows is fine with that change.

The suggestion of the "is_whitespace" function is interesting. I will think of including that, although I never had issues with that comparison. Thank you.


chore: upgrades OTel propagators to 1.0.0.

Description
This PR upgrades OTel propagators aiming to solve the breaking change where go.opentelemetry.io/contrib/propagators/b3 is either an own module and it isn't across versions.

@jcchavezs tests are failing


Run Operations_Test_SetB_* tests for rancher/kontainer-driver-metadata tests

Currently, v2prov tests that run in KDM (e.g. https://drone-pr.rancher.io/rancher/kontainer-driver-metadata/3208 / https://drone-pr.rancher.io/rancher/kontainer-driver-metadata/3215) only run subset of operations test (SetA_*) while tests in rancher/rancher run both SetA_* and SetB_* tests (e.g. https://drone-pr.rancher.io/rancher/rancher/40449/5/2).
This leaves possibility for RKE2/K3s regressions to go into KDM undetected and not be discovered until rancher/rancher pipelines are executed (and potentially block CI) - and it already happened with Test_Operation_SetB_MP_EtcdSnapshotOperationsWithThreeEtcdNodesOnNewNode failing very often in May RKE2 patches (see https://drone-pr.rancher.io/rancher/rancher/40439/5/2 for example).
Additional context: This is a follow-up to https://github.com/rancher/rancher/issues/43585

Closing this one as PR was merged and branch protection rules updated to require updated tests for merging the PRs into dev-v2.9 and release-v2.9 branches.
FYI @daviswill2 - it's QA/None


:sparkles: Implemented Strict Mode Support

This PR adds the ability to have the action run in strict mode, meaning it will exit with none success status code if at least one vulnerability is encountered. The default behavior will remain that it will not fail if it encounters a vulnerability. As those are present in the Security-tab and it allows for better handling of false-positives.

Codecov Report
Base: 97.87% // Head: 97.87% // No change to project coverage :thumbsup:

Coverage data is based on head (0c02d1a) compared to base (afab4ad).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage   97.87%   97.87%
=======================================
  Files           3        3
  Lines         235      235
=======================================
  Hits          230      230
  Misses          4        4
  Partials        1        1

Flag
Coverage Δ

unit-tests
97.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Verified behavior in Playground Repository:


enhancement: use constructor tear-off instead of switch case for response mapping

suggestion of: #19

thanks @rutesantos4, way cleaner!


Unable to read files password-protected by Adobe Protect PDF online tool

Apparently PDFio cannot open PDF files that were password-protected via this online tool by Adobe. The encryption label is PDFIO_ENCRYPTION_AES_128. In fact, the files are properly decrypted but afterwards the following error messages appear:
Corrupt stream data.
Unable to decompress stream data for object 4: Data error.
Unable to find pages object.

The same unprotected files are read correctly.
I have tried this by adding a test in the test routine of the provided Visual Studio solution on Windows 11. Thank you.
P.S. The following does not have to do with this issue, but it is just a brief comment. The encryption labeled by PDFIO_ENCRYPTION_AES_256 corresponds to V6 R6. However from the PDF 2.0 specifications I understand that it should be associated with V5 R6; also I have a protected 2.0 PDF which has indeed V=5 and R=6.

Can you attach the before and after PDF files that show this? I've been separately tracking what might be the same issue (#42), but haven't figured out the proper fix yet.

Here they are:
test.pdf
test-protected.pdf
Password is "password" (without quotes).

What's interesting is that the last 16 bytes of the user password value are nul (0)... This is technically allowed (you are supposed to pad with 16 bytes of arbitrary data) but might be significant...

[master 7d22477] Fix opening of certain encrypted PDF files (Issue #62)


Last Updated on Alignment not working on ShareLatex

The text if getting cut by the right boundary in sharelatex

corrected the issue by replacing:
\lastupdatedon
with
\begin{flushleft}
\lastupdatedon
\end{flushleft}


Export distilled whisper to TFLite

Have you tried the TFLite export notebook on Distilled Whisper (https://github.com/huggingface/distil-whisper)? I modified the script like this:
import tensorflow as tf

from datasets import load_dataset
from transformers import WhisperProcessor, WhisperFeatureExtractor, TFWhisperForConditionalGeneration, WhisperTokenizer

feature_extractor = WhisperFeatureExtractor.from_pretrained("distil-whisper/distil-small.en")
tokenizer = WhisperTokenizer.from_pretrained("openai/whisper-small.en", predict_timestamps=False)
processor = WhisperProcessor(feature_extractor, tokenizer)
model = TFWhisperForConditionalGeneration.from_pretrained("openai/whisper-small.en")
# Loading dataset
ds = load_dataset("hf-internal-testing/librispeech_asr_dummy", "clean", split="validation")

inputs = feature_extractor(
    ds[0]["audio"]["array"], sampling_rate=ds[0]["audio"]["sampling_rate"], return_tensors="tf"
)
input_features = inputs.input_features

# Generating Transcription
generated_ids = model.generate(input_features=input_features)
print(generated_ids)
transcription = processor.tokenizer.decode(generated_ids[0])
print(transcription)
model.save('/content/tf_whisper_saved')

I am not sure if the same tokenizer as for regular whisper can be used... Anyways, this piece of code crashes:
# Convert the model
converter = tf.lite.TFLiteConverter.from_saved_model(saved_model_dir)
converter.target_spec.supported_ops = [
  tf.lite.OpsSet.TFLITE_BUILTINS, # enable TensorFlow Lite ops.
  tf.lite.OpsSet.SELECT_TF_OPS # enable TensorFlow ops.
]

Any idea on how to get a successful distilled whisper export?

I have not tried converting Distilled Whisper to TFLite

Do you have any plans of adding support for distilled whisper?

Just setting all the paths to distil-whisper/distil-small.en, like this:
import tensorflow as tf

from datasets import load_dataset
from transformers import WhisperProcessor, WhisperFeatureExtractor, TFWhisperForConditionalGeneration, WhisperTokenizer

feature_extractor = WhisperFeatureExtractor.from_pretrained("distil-whisper/distil-small.en")
tokenizer = WhisperTokenizer.from_pretrained("distil-whisper/distil-small.en", predict_timestamps=False)
processor = WhisperProcessor(feature_extractor, tokenizer)
model = TFWhisperForConditionalGeneration.from_pretrained("distil-whisper/distil-small.en")
# Loading dataset
ds = load_dataset("hf-internal-testing/librispeech_asr_dummy", "clean", split="validation")

inputs = feature_extractor(
    ds[0]["audio"]["array"], sampling_rate=ds[0]["audio"]["sampling_rate"], return_tensors="tf"
)
input_features = inputs.input_features

# Generating Transcription
generated_ids = model.generate(input_features=input_features)
print(generated_ids)
transcription = processor.tokenizer.decode(generated_ids[0])
print(transcription)
model.save('/content/tf_whisper_saved')

We tried the same WAV file on the regular whisper small and distilled. The differences are minimal. 22 vs 21 seconds. Does anybody have a rationale behind this?

@mikel-brostrom Good work, Could you post generated Distiled whisper small  tflite model via google drive link ?
People can benefit with this model


[Bug] Server build on Linux cannot load firebase plugins

[REQUIRED] Please fill in the following fields:

Unity editor version: 2019.4.29
Firebase Unity SDK version: 8.1.0
Source you installed the SDK: unitypackage
Problematic Firebase Component: Auth, database
Other Firebase Components in use: None
Additional SDKs you are using: Mirror
Platform you are using the Unity editor on: Mac
Platform you are targeting: Linux x86-64
Scripting Runtime: Mono

[REQUIRED] Please describe the issue here:
After building a server build for Linux and uploading to a Google cloud platform e2-micro instance with debian 10 (default), this is the output from running the server:
lawsonh@testserver1:~/server$ ./server.x86_64
Set current directory to /home/lawsonh/server
Found path: /home/lawsonh/server/server.x86_64
Mono path[0] = '/home/lawsonh/server/server_Data/Managed'
Mono config path = '/home/lawsonh/server/server_Data/MonoBleedingEdge/etc'
Preloaded 'FirebaseCppApp-8_1_0.so'
Unable to preload the following plugins:
        FirebaseCppAuth.so
        FirebaseCppDatabase.so
        FirebaseCppFirestore.so
        liblibvhacd.so

Steps to reproduce:
Try building a Linux server build with those firebase plugins and run it on GCP
What happened? How can we make the problem occur?
Try building a Linux server build with those firebase plugins and run it on GCP

Fixed, it was a GCP thing. you have to do TERM=xterm


Collection venue closing times

On the opening times and library pages we need to display the periods in the year when the library is closed.
At present this is added directly to the page and opening-times templates.
This isn't ideal, as it requires some hackery on the generic page template to know when to include the library times.
It also means that it is stuck to the bottom of the page, when we really want it to appear between other body slices, i.e. the 'Get in touch' info. should go below it.

This PR adds a label to the collectionVenue body slice, which is used to determine whether the slice should display the venue opening times OR the closed times, so that the closed times can be displayed as any other body slice.
It also means we could then get rid of the opening-times template and just use the generic page template for /opening-times

There is in my head... I'll create an issue


checkA11y failing when called after setting cy.clock

Hi,
I noticed that checkA11y failed when called after using the cy.clock(...) function to set a date
I get the following error when trying to call checkA11y :
cy.then() timed out after waiting 4000ms.

Your callback function returned a promise that never resolved.

The callback function was:

function(a){i(e)&&(e=void 0),i(t)&&(t=void 0),i(n)&&(n=void 0);var o=t||{},s=o.includedImpacts,u=r(o,["includedImpacts"]);return a.axe.run(e||a.document,u).then((function(e){var t=e.violations;return s&&Array.isArray(s)&&Boolean(s.length)?t.filter((function(e){return s.includes(e.impact)})):t}))}

Running cypress-axe  0.8.1 and cypress 4.12.1

I've been fighting this issue for the past couple days and had not connected the dots with the cy.clock() tests being the culprits until I saw this bug report.

I was able to work around this by restoring the clock  before calling checkA11y().

Thanks for the workaround, I had not thought of that !


Iterator aggregate functionality

This PR allows an IteratorAggregate to be used for automatically binding lists of data.
Closes #467

This needs documenting before the PR can be merged. I'll write the docs here so it can be copied easily into the wiki.


Request: Make album art and song information independent of each other.

Description
Would be a nice addition if you could make the song album art and song information independent of one another in regards to scaling. I would like to make the album art a little bigger while keeping the song information at a smaller size.

Im with this too however maybe there is a way to scale them separately using the .ini file but im not good with Rainmeter internals

Description
Would be a nice addition if you could make the song album art and song information independent of one another in regards to scaling. I would like to make the album art a little bigger while keeping the song information at a smaller size.

Actually I think I have found it!
You have to edit Cover.ini file manually. Here is how, under labels:
[MeterCover]
[MeterPrevious]
[MeterPlayPause]
[MeterNext]
To variables W, H add(+) desired number. Example, for first (MeterCover) I added 20 on it, MeterPrevious, MeterPlayPause and Meter Next I added 8.
Lastly, on [MeterDuration] add desired value only to variable X. (I added 20 but you can experiment and see what fits best)

I believe that if you go into variables.ini, you can do a similar thing by changing CoverSize.
CoverSize=200 ; Size of the cover image. ; Default: 200

Should be possible, but it might take a few days time and it will be hidden inside the variables.ini file. I'll keep you guys updated here.

You can edit the scale directly in the variables.ini file:
ScaleSongInformation=0.4

Would be great to surface this value in the settings.


[Graphiql Explorer Plugin] (Next.js) Cursor/Caret jumps when editing query manually

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When editing the query by hand when using the GraphiQL component together with the explorerPlugin passed in the props array, the cursor resets, and appears in the first line of the editor.
I'm currently implementing the plugin as stated in the README
Expected Behavior
The caret shouldn't jump to the beginning.
Steps To Reproduce
1. Clone https://github.com/crjm/graphiql-explorer-test
2. cd into cloned repo, `npm install`
3. `npm run dev`
4. Open Explorer plugin, trigger fields
5. Start typing directly into the editor
6. The caret will jump to the first line of the editor.

Module pattern

[ ] graphiql-umd
[X] graphiql-esm
[ ] graphiql-commonjs

Environment
- GraphiQL Version: latest
- OS: Ubuntu 22.04
- Browser: Firefox
- Bundler: Next.js (Webpack 5)
- `react` Version: 18.2
- `graphql` Version: 15.8

Anything else?
No response

I can't replicate this in your repository or with StackBlitz. Are you able to take a screen capture to share?

I can't replicate this in your repository or with StackBlitz. Are you able to take a screen capture to share?

:wave: seems to happen in StackBlitz as well. Recording below
https://user-images.githubusercontent.com/1578458/199839723-1f14bebb-ea72-4ad3-8027-86d95a1d6747.mp4

@jonathanawesome just checking if you were able to reproduce :pray:

Yep, thanks...I see it now and you're probably right that it's related to the dynamic import. Curious that we haven't had this reported before, I wonder if it has something to do with next 13.
Have you tried downgrading to next 12?
Have you tried with babel rather than with swc?

Thx for the quick reply Jonathan. It also happens in next 12. Regarding babel, we haven't tried that yet.
We'll keep doing some more tests

Here's a related conversation with a workaround.

I'm experiencing the cursor jump as well and I'm using neither NextJS nor SSR 😕 I am using the explorer plugin, though I saw the problem occur when I disabled it. One thing I think I noticed: when I removed the explorer plugin along with the code that keeps the user-typed query in state (this is needed for the explorer plugin, see https://github.com/OneGraph/graphiql-explorer-example/blob/master/src/App.js#L88) and sets that query as a prop on the GraphiQL instance, I couldn't reproduce the problem.

GraphiQL Version: 2.0.9
OS: Mac OS Ventura
Browser: Chrome
Bundler: Babel
react Version: 18.2.0
graphql Version: 16.6.0

We applied the following workaround, but it does not prevent the the cursor jumps completely, it only makes them happen less often. Is this bug being worked on? It is pretty annoying.
diff --git a/src/App.tsx b/src/App.tsx
index a0658c1..68553a7 100644
--- a/src/App.tsx
+++ b/src/App.tsx
@@ -1,4 +1,4 @@
-import React from 'react';
+import React, {useEffect} from 'react';
 import GraphiQL from 'graphiql';
 import 'graphiql/graphiql.css';
 import<EMAIL_ADDRESS>@@ -105,8 +105,14 @@ const App = () => {
         return api != null ? api.url.substring(0, api.url.lastIndexOf("/")) : "";
     }

+    const [isClientRendering, setIsClientRendering] = useState(false);
+    useEffect(() => {
+        setIsClientRendering(true);
+    }, []);
+
     return (
         <>
+            {isClientRendering ?
             <GraphiQL fetcher={fetcher} query={query} onEditQuery={updateQuery} plugins={[explorerPlugin]} toolbar={{
                 additionalContent: (
                     <>
@@ -165,6 +171,7 @@ const App = () => {
                 ),
             }}>
             </GraphiQL>
+                : null}
             {showComparer && (
                 <Comparer
                     query={query}

We applied the following workaround, but it does not prevent the the cursor jumps completely, it only makes them happen less often. Is this bug being worked on? It is pretty annoying.

I'm not currently working on this (and my assumption is that no one else is, either), nor do I plan to. The OneGraph Explorer plugin that's in this repository is a legacy placeholder that is meant to hold folks over until we've had the time to design and develop the new "core" plugin with similar functionality (see here).
That said, this is open source software. If any one out there that is deeply impacted by this issue would like to take the time to come up with a working solution, we'd be happy to review and merge.

We applied the following workaround, but it does not prevent the the cursor jumps completely, it only makes them happen less often. Is this bug being worked on? It is pretty annoying.

I'm not currently working on this (and my assumption is that no one else is, either), nor do I plan to. The OneGraph Explorer plugin that's in this repository is a legacy placeholder that is meant to hold folks over until we've had the time to design and develop the new "core" plugin with similar functionality (see here).
That said, this is open source software. If any one out there that is deeply impacted by this issue would like to take the time to come up with a working solution, we'd be happy to review and merge.

Thanks, good to know. We will consider if we stop using explorer for a while, or at least offer a version without it.

@jonathanawesome I know little react, do you think the bug is that useState triggers unwanted re-renders? Which of these do you think is worth trying?
Rewrite the solution using:

useEditorContext
useRef
memo

Does the issue seem to be fixed here?
I've decided to start deploying our graphiql + webpack w/ plugins example again so we can make these issues more easily reproducible
https://deploy-preview-3328--graphiql-test.netlify.app/webpack/

awesome to hear @marcosnils , thanks for checking it out for me. I will merge as #3330 as 0.3.0 releases of the plugins. it will cause breaking changes to the plugin implementations that will simplify plugin usage

@marcosnils  here is a version to test in your implementation, can you confirm it works in your implementation?
fix canary<EMAIL_ADDRESS>please follow these instructions  to update your implementation with the new plugin signature.

@rrva try the above ^

this fix has been released as 0.3.0!
please note the changelog again, one slight naming convention tweak to code exporter plugin while we were making a breaking change.
if you are using the module from npm, the changelog instructions will help you, and the READMEs have been updated.
if you are using the CDN bundle path, follow the updated example for explorer plugin and/or  for code exporter plugin

Awesome @acao
Have not tested yet, but this is a big one for us. It prevented explorer usage so we were stuck with using both v1 and v2 in parallel. v1 had explorer, v2 can send auth headers. Looking forward to use v2 for all use cases

@rrva oh dear, yes we added the headers tab in<EMAIL_ADDRESS>or so I believe, but you should be able to use the latest 2.x and the<EMAIL_ADDRESS>together without this bug now! let us know if there are still issues in your implementation and we can re-open, but this seemed to resolve the issue for several people using either the module or UMD builds

We're currently using the 3.0.6 version of GraphiQL and are still experiencing the issue. It seems to happen less often, though.


Event notifications

I'd like to know when the car starts driving. But you could add a bunch of other events for notification as well. Would be awesome if it showed notifications in the OSX notifications area.

Starts driving
Starts Charging
Finishes Charging
Unlocks
Locks
Turns on AC
etc

@traviscollins  There is a problem with this solution and I've been debating it in other threads. If we set up a notification system like this, we need to keep pinging the car all the time, this will prevent the car from sleeping and will degrade battery life whenever the app is running. The way it is setup today, it will stop pinging when the window is not active (not visible) and will get back to normal 10s pings as soon as the window is opened. If you open the app and the car is sleeping, it will attempt to wake the car then start the pinging again. This way, we don't prevent the car from sleeping.
We can still think about notifications, but it will come with this price, maybe could be an optional feature, that user can enable but will be warned about the non-sleeping issue.
What do you think?

TeslaFi has a well documented solution to this.
https://support.teslafi.com/knowledge-bases/2/articles/640-enabling-sleep-settings-to-limit-vampire-loss
I think you should make a SaaS offering. Make it open source for everyone that wants to host it themselves, but offer it as a paid premium service for those not tech savvy enough to host it themselves. The paid service would include all the advanced polling and tracking services.

Thanks for the information!
The initial goal for this app was to not have any server-side functionality and act as a simple, local solution for people looking to monitor their Tesla without the need for trusting a third party with their access token. If I implement a notification/logging mechanism that runs in a server (separated from the desktop app), this will change. Another option is to make the desktop app the notification/logging server itself and the limitation will be that it must be running in order to these services to work.
Having a service/server is a great solution to provide cool features and be able to monitor/log data 24/7 and looks like we can work with the sleeping issue and make it in a way it will not affect battery life (according to your article).
I just need to figure out if this is something I will be able to support if I create a server (it could be open source) but I still need to provide our hosted solution so people can use without the need to configure/run a server somewhere. This means I need different standards in terms of support and need to dedicate a lot more time. My goal was never to make it a commercial thing, but it can change.
I will think about it as I develop more features, fix bugs, get feedback from users and hopefully find some contributors. Let's see where this can go.
Thanks for all your input.

I happen to run a Google Cloud consulting company. Happy to walk you through what it takes to run a service like this at minimal cost and time. Done right, it’s easier to do that you might think.
bigarmor.com

On Jun 19, 2019, at 4:47 PM, Geraldo Ramos<EMAIL_ADDRESS>wrote:
Thanks for the information!
The initial goal for this app was to not have any server-side functionality and act as a simple, local solution for people looking to monitor their Tesla without the need for trusting a third party with their access token. If I implement a notification/logging mechanism that runs in a server (separated from the desktop app), this will change. Another option is to make the desktop app the notification/logging server itself and the limitation will be that it must be running in order to these services to work.
Having a service/server is a great solution to provide cool features and be able to monitor/log data 24/7 and looks like we can work with the sleeping issue and make it in a way it will not affect battery life (according to your article).
I just need to figure out if this is something I will be able to support if I create a server (it could be open source) but I still need to provide our hosted solution so people can use without the need to configure/run a server somewhere. This means I need different standards in terms of support and need to dedicate a lot more time. My goal was never to make it a commercial thing, but it can change.
I will think about it as I develop more features, fix bugs, get feedback from users and hopefully find some contributors. Let's see where this can go.
Thanks for all your input.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks! I'm not scared about running the service, it will just unavoidably lead to more work and maintenance.
I have good experience with AWS cloud (ECS, EC2, Lambda, etc), Google Cloud, Heroku and tools like docker, kubernetes and so on. It won't be a problem to get this running very fast. It's just a matter of setting up support channels for customers, billing management (most likely using Stripe) and a bunch of other things that will definitely require more dedication if I want to make a small/tiny business out of this.
Thanks again.
Geraldo


”Cristești” is listed in the drop-down menu

Description:
"Cristești" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Cristești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Cristești, IAȘI".


Improve KeysBackup API and performance

As done on iOS:

[x] https://github.com/matrix-org/matrix-ios-sdk/pull/634
and

[x] https://github.com/matrix-org/matrix-ios-sdk/pull/635/files

[x] Also we could indicate progress for recovery with passphrase, as this can take a while (steps could also be displayed to user: derivating key, downloading, importing...)

Also we could indicate progress for recovery with passphrase, as this can take a while (steps could also be displayed to user: derivating key, downloading, importing...)

Done in #3000


pkg_zip does not maintain directory structure

pkg_zip does not maintain the directory structure of the files placed inside it, nor does it have an option to.
For the iOS package manager CocoaPods, when archiving code for distribution (rather than relying on git), the directory structure of the decompressed archive must match the globs in the package specification file (.podspec)
if i have a podspec with the following:
package.source_files = ["Sources/**/*.swift"]

and use the same in pkg_zip:
pkg_zip(
    name = "PodName",
    srcs = glob(["Sources/**/*.swift"])
  )

All of the .swift files are unpacked at the root level of the archive. This breaks the CocoaPod import, since the package expects files to be under Sources
While this specific usecase is fixable (with package_dir), CocoaPods supports "subspecs", that allows for optionally importing chunks of code:
package.subspec "Module1" do |sub|
  sub.source_files = ["Sources/package1/**/*.swift"]
end
package.subspec "Module2" do |sub|
  sub.source_files = ["Sources/package2/**/*.swift"]
end

When compressed, all of the code needs to be available in the archive, so adding package_dir as Sources would then leave everything in the Sources directory when decompressed, and the .podspec would not match any files.
In order for these pkg_ rules to work for CocoaPods, there needs to be a way to maintain the directory structure when archiving files.

I hit the same thing. pkg_files obviously don't produce a zip. So is the recommendation to do a pkg_files then a genrule w/ a manual zip on top of that in order to make a zip that preserves the directory structure?

The recommendation is to create a one or more pkg_files targets, and then pass them to pkg_zip in its srcs attribute.  Note that the path manipulation functions in pkg_files supplant the ones provided by pkg_zip (and also pkg_tar).
For a more concrete example, take a peek at the one @aiuto mentioned in his comment, above.

pkg_files should be the srcs to pkg_zip.
load("//:pkg.bzl", "pkg_zip")
load("//pkg:mappings.bzl", "pkg_files", "strip_prefix")

pkg_files(
    name = "srcs",
    srcs = glob(["Sources/**/*.swift"]),
    strip_prefix = strip_prefix.from_pkg(),
)

pkg_zip(
    name = "pod",
    srcs = ["srcs"],

)

$ bazel build :*
INFO: Analyzed 6 targets (1 packages loaded, 6 targets configured).
...
$ unzip -v ../bazel-bin/i434/pod.zip
Archive:  ../bazel-bin/i434/pod.zip
 Length   Method    Size  Cmpr    Date    Time   CRC-32   Name
--------  ------  ------- ---- ---------- ----- --------  ----
      20  Defl:N       22 -10% 1980-01-01 00:00 ab34387b  Sources/a/foo.swift
      26  Defl:N       28  -8% 1980-01-01 00:00 0cd071f9  Sources/b/foo.swift
--------          -------  ---                            -------
      46               50  -9%                            2 files

Sorry to get back to this so late, went down some other related rabbit holes. Using pkg_files works, and I get why, still learning a lot about bazel, so some of the intentional verbosity in the BUILD files isn't what I expect.
Thank you for the help!

Thanks! pkg_files works like a charm. I had incorrectly assumed a filegroup would work in its place.

Just for closure.  I do actually agree that pkg_*(srcs=glob(["**/*.switft"])) would be least surprising if it maintained the directory structure. It's just that we have years of people using and expecting the older (and dumb) behavior of flattening the tree. As tempting as it is, I don't want to potentially break a lot of people.

@aiuto out of curiosity, WDYT about adding a flatten flag to pkg_* that defaults to false and doing a breaking change? It would let people keep the old (and I agree with you, bad) behavior until they get a chance without increasing the ecosystem wide tech debt over time?

Perhaps this discussion should be continued in https://github.com/bazelbuild/rules_pkg/issues/354, where we are considering this very problem?
I would personally argue that it isn't necessarily bad behavior -- if your default mode of operation has files going to odd locations that have nothing to do with your source paths, you're going to be stripping everything pretty much by default anyway.
Regardless, that behavior may be too surprising to be effective.

Sounds good. One place for discussion is best.
On Thu, Dec 2, 2021 at 7:58 AM Andrew Psaltis @.***>
wrote:

Perhaps this discussion should be continued in #354
https://github.com/bazelbuild/rules_pkg/issues/354, where we are
considering this very problem?
I would personally argue that it isn't necessarily bad behavior -- if your
default mode of operation has files going to odd locations that have
nothing to do with your source paths, you're going to be stripping
everything pretty much by default anyway.
Regardless, that behavior may be too surprising to be effective.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_pkg/issues/434#issuecomment-984604656,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXHHHBTSQXC2HX43AY42TLUO5UO7ANCNFSM5F3DXCBQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


[minor]: Introduce IndexSet and IndexMap aliases.

Which issue does this PR close?

Closes #.
Rationale for this change
This Pr is similar to PR. It replaces all usages of indexmap::IndexSet and indexmap::IndexMap with datafusion_common::IndexSet and datafusion_common::IndexMap to enforce consistency across DataFusion.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

It replaces all usages of indexmap::IndexSet and indexmap::IndexMap with datafusion_common::IndexSet and datafusion_common::IndexMap to enforce consistency across DataFusion.

if some new code uses indexmap::IndexSet directly, will it cause compile-time or CI failure?

It replaces all usages of indexmap::IndexSet and indexmap::IndexMap with datafusion_common::IndexSet and datafusion_common::IndexMap to enforce consistency across DataFusion.

if some new code uses indexmap::IndexSet directly, will it cause compile-time or CI failure?

Actually, neither as far as I know. This is just a name alias.

Can Clippy's disallowed types or methods be used to enforce consistency?
Otherwise, I would prefer to ensure consistency going into opposite direction.
If datafusion-common doesn't re-export IndexSet, then the code should consistently use indexmap::IndexSet as the only(?) available option.

Let's keep improving on main

Can Clippy's disallowed types or methods be used to enforce consistency?

We can add them to clippy disallowed-types.
But I am a bit doubtful whether this PR is necessary because, unlike HashMap, indexmap does not have two implementations in DataFusion that need to be unified.  I think indexmap = { workspace = true } already provides consistency.
In addition, this type alias has added a permanent dependency for datafusion-common and can propagate to other packages. Even if one day, common/cse.rs no longer needs IndexMap.
We also need to create a type alias for indexmap::Equivalent to ensure consistency.

I think indexmap = { workspace = true } already provides consistency.

I agree with that and also suggested in https://github.com/apache/datafusion/pull/13611#issuecomment-2514087988

In addition, this type alias has added a permanent dependency for datafusion-common

good point.
common is pretty common to depend on, but also is too fat already (eg pulls sqlparser dependency).
avoiding dependencies is a good thing.

I aggree with @findepi and @jonahgao that this might indeed be unnecessary. At first, this occurred to me as a natural continuation of the previous HashMap and HashSet work. However, it seems that, we have a single option anyway also without enforcing consistency, this is not helpful. Should I retract these changes?

I aggree with @findepi and @jonahgao that this might indeed be unnecessary. At first, this occurred to me as a natural continuation of the previous HashMap and HashSet work. However, it seems that, we have a single option anyway also without enforcing consistency, this is not helpful. Should I retract these changes?

Thanks @akurmustafa.  I think retracting these changes will make things simpler.


Flattening generates mesh with indices = 0

Hi, as I mentioned I've been trying to integrate Eigen in your tool. I managed to do that, I run the tool as suggested, but the output is a mesh with same vertices as the original one + the new UV and but all the faces are set to 0.
My main looks like the following:
#include <Bff.h>
#include <MeshIO.h>
#include <iostream>

int main(int argc, char** argv) {

	std::ifstream ifs("./test_mesh.obj");
	std::stringstream ss_content;
	std::string content;
	std::istringstream iss_content;

	if(ifs) {
		std::cout << "Reading file!" << std::endl;
		ss_content << ifs.rdbuf();
		content = ss_content.str();
		iss_content = std::istringstream(content);
	}

	ifs.close();

	Mesh test_mesh;

	if(!MeshIO::read(iss_content,test_mesh))
		std::cout << "Reading problems!" << std::endl;

	BFF flattening_module(test_mesh);

	EigenDenseMatrix boundaryData(flattening_module.data->bN);

	std::cout << "flattening mesh" << std::endl;

	flattening_module.flatten(boundaryData,true);

	std::cout << "mesh flattened, now storing into a file" << std::endl;

	test_mesh.write("./output_test_mesh.obj", false, false);

	return 0;

}

The only code I changed are the linear algebra wrappers, but nothing has changed inside the Mesh  BFF, BFFData and MeshIO, so I assume the manipulation of the indices should be the same as before.

Just to clarify, faces seem to be loaded correctly, it's after the processing I'm getting this.

Never mind it worked... I probably wasn't supposed to use the MeshIO class... by using the following
#include <Bff.h>
#include <MeshIO.h>
#include <iostream>

int main(int argc, char** argv) {

	Mesh test_mesh;

	if(!test_mesh.read("./test_mesh.obj"))
		std::cout << "Reading problems!" << std::endl;

	BFF flattening_module(test_mesh);

	EigenDenseMatrix boundaryData(flattening_module.data->bN);

	std::cout << "flattening mesh" << std::endl;

	flattening_module.flatten(boundaryData,true);

	std::cout << "mesh flattened, now storing into a file" << std::endl;

	test_mesh.write("./output_test_mesh.obj",false,true);

	return 0;

}

I got the following output:

v 0.707107 -0.707107 0
v 0.707107 0.707107 0
v -0.707107 0.707107 0
v -0.707107 -0.707107 0
vt 0.853553 0.853553
vt 0.146447 0.853553
vt 0.853553 0.146447
vt 0.146447 0.853553
vt 0.146447 0.146447
vt 0.853553 0.146447
f 1/3 2/1 3/2
f 1/6 3/4 4/5

Which is the same as the one provided by your tool (with the rescaling enabled). But again, is there a reason why the coordinates are scaled?

The mesh class "normalizes" the model, which it probably shouldn't do. I would comment out this line:
https://github.com/GeometryCollective/boundary-first-flattening/blob/23d8448a817f5175ebffd79f233076444b3a8d5e/mesh/src/Mesh.cpp#L34

Is this final normalization a mistake then?

Yes, it won't be there in the next version.


TopoSorter: Only allow certain params to be incomplete

For the containers which are allowed to be declared with incomplete types, it is only the contained types which are allowed to be incomplete. Other template parameters (e.g. allocators) must always be defined before use.

Codecov Report

Merging #392 (1c63505) into main (fcb50df) will decrease coverage by 22.94%.
The diff coverage is 69.23%.

@@             Coverage Diff             @@
##             main     #392       +/-   ##
===========================================
- Coverage   68.62%   45.69%   -22.94%
===========================================
  Files         116      104       -12
  Lines       11439    11081      -358
  Branches     1903     1847       -56
===========================================
- Hits         7850     5063     -2787
- Misses       2610     5158     +2548
+ Partials      979      860      -119

Files
Coverage Δ

oi/type_graph/TopoSorter.cpp
77.92% <100.00%> (-15.04%)
:arrow_down:

test/test_topo_sorter.cpp
0.00% <0.00%> (-99.36%)
:arrow_down:

... and 75 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Initial plugin design

Goal of this plugin is to queue up captured events (from the track_event() plugin hook) in an internal database table then send them off to a remote Datasette instance via the /db/table/-/insert API) rate limited to send a batch at most once every 10s.
TODO:

[x] Finalize schema
[x] Document the /-/insert v.s. /-/create bit
[x] Settings to control rate limits
[x] Add tests
[x] Publish alpha to PyPI

Alpha released: https://pypi.org/project/datasette-events-forward/


⚠ Bofrost.at has degraded performance

In dba953a, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1588 ms

Resolved: Bofrost.at performance has improved in ee59e48 after 20 minutes.


[package.json] Leave the protocol choice for a Github repo to npm

Fixes #1371

Landed internally, should be here with the next sync. Thanks for fixing it, @brentvatne!


Update RS REST Transport for Ochsner Epic

We need to verify the requirements to connect with Ochsner's Epic. Ott previously had start a draft of changes to RS's REST transport here https://github.com/CDCgov/prime-reportstream/pull/13922. We need to validate which of those changes still need to be made.
Pre-conditions

[ ] Obtain documentation regarding Epic's REST endpoint for Ochsner
[ ] Obtain auth specs for Ochsner

Completion Criteria

[ ] We can send a message to Ochsner's Epic staging/test environment from ReportStream staging and it is successfully received

Tasks

[ ] Make any changes required to RS Rest Transport
[ ] Change transport settings for Ochsner in RS staging to send to Ochsner staging/test env
[ ] Confirm message is successfully received in Ochsner's staging/test env

Other Notes

(https://github.com/CDCgov/prime-reportstream/pull/13922) is a PR that Ott started back in April 2024 that contains changes that may be needed for Ochsner

Blocked on completion of security questionnaire


recipes-kernel: add strict apparmor support patches for Linux Yocto kernel

Cherry picked kernel patches that enable strict confinement.
I've only verified them to build on dunfell atm

From my testing those patches work with Linux 5.4 but don't apply cleanly to 5.10, so it might make sense to change the bbappend to have a version in it

I'll open a followup PR with the rename to make it version specific.


Fold deleted if whichwrap+=,l set

Describe the bug
Fold is deleted if whichwrap+=,l is set and you x in an empty line above it
To Reproduce
vim --clean
:set whichwrap+=,l foldmethod=marker
Create a fold using markers and close it
Create an empty line above the fold - O
x or <del> on empty line
The entire fold plus the empty line are deleted
Expected behavior
The fold isn't deleted, the cursor is placed on the first column of the line containing the closed fold
Environment (please complete the following information):

Vim version: Vi IMproved 8.1
OS: Void Linux
Terminal: kitty

Yeah, internally, x is translated to dl, which moves to the next line and deletes it. I think this patch fixes it. Theoretically, this could also happen with X and :set whichwrap=h on an empty line after a fold, but Vim doesn't delete the fold in this case, so we do not need to take care of this.
diff --git a/src/normal.c b/src/normal.c
index 2422de585..fbb3cb911 100644
--- a/src/normal.c
+++ b/src/normal.c
@@ -7399,8 +7399,8 @@ nv_optrans(cmdarg_T *cap)

     if (!checkclearopq(cap->oap))
     {
-       /* In Vi "2D" doesn't delete the next line.  Can't translate it
-        * either, because "2." should also not use the count. */
+       // In Vi "2D" doesn't delete the next line.  Can't translate it
+       // either, because "2." should also not use the count.
        if (cap->cmdchar == 'D' && vim_strchr(p_cpo, CPO_HASH) != NULL)
        {
            cap->oap->start = curwin->w_cursor;
@@ -7414,7 +7414,9 @@ nv_optrans(cmdarg_T *cap)
            ResetRedobuff();
            AppendCharToRedobuff('D');
        }
-       else
+       // if on an empty line and using 'x' and "l" is included in the whichwrap option,
+       // do not delete the next line
+       else if (!(cap->cmdchar == 'x' && vim_strchr(p_ww, 'l') != NULL && gchar_cursor() == NUL))
        {
            if (cap->count0)
                stuffnumReadbuff(cap->count0);
diff --git a/src/testdir/test_fold.vim b/src/testdir/test_fold.vim
index 7aef51f8b..90a6c2701 100644
--- a/src/testdir/test_fold.vim
+++ b/src/testdir/test_fold.vim
@@ -757,3 +757,14 @@ func Test_fold_delete_with_marker()
   bwipe!
   bwipe!
 endfunc
+
+func Test_fold_delete_with_marker_and_whichwrap()
+  new
+  let content=['', 'folded line 1 "{{{1', '  test', '  test2', '  test3', '', 'folded line 2 "{{{1', '  test', '  test2', '  test3']
+  call setline(1, content)
+  set fdm=marker ww+=l
+  normal! x
+  call assert_equal(content, getline(1, '$'))
+  set fdm& ww&
+  bwipe!
+endfunc

Christian wrote:

Yeah, internally, x is translated to dl, which moves to the next
line and deletes it. I think this patch fixes it. Theoretically, this
could also happen with X and :set whichwrap=h on an empty line
after a fold, but Vim doesn't delete the fold in this case, so we do
not need to take care of this.
diff --git a/src/normal.c b/src/normal.c
index 2422de585..fbb3cb911 100644
--- a/src/normal.c
+++ b/src/normal.c
@@ -7399,8 +7399,8 @@ nv_optrans(cmdarg_T *cap)

     if (!checkclearopq(cap->oap))
     {
-       /* In Vi "2D" doesn't delete the next line.  Can't translate it
-        * either, because "2." should also not use the count. */
+       // In Vi "2D" doesn't delete the next line.  Can't translate it
+       // either, because "2." should also not use the count.
        if (cap->cmdchar == 'D' && vim_strchr(p_cpo, CPO_HASH) != NULL)
        {
            cap->oap->start = curwin->w_cursor;
@@ -7414,7 +7414,9 @@ nv_optrans(cmdarg_T *cap)
            ResetRedobuff();
            AppendCharToRedobuff('D');
        }
-       else
+       // if on an empty line and using 'x' and "l" is included in the whichwrap option,
+       // do not delete the next line
+       else if (!(cap->cmdchar == 'x' && vim_strchr(p_ww, 'l') != NULL && gchar_cursor() == NUL))
        {
            if (cap->count0)
                stuffnumReadbuff(cap->count0);
diff --git a/src/testdir/test_fold.vim b/src/testdir/test_fold.vim
index 7aef51f8b..90a6c2701 100644
--- a/src/testdir/test_fold.vim
+++ b/src/testdir/test_fold.vim
@@ -757,3 +757,14 @@ func Test_fold_delete_with_marker()
   bwipe!
   bwipe!
 endfunc
+
+func Test_fold_delete_with_marker_and_whichwrap()
+  new
+  let content=['', 'folded line 1 "{{{1', '  test', '  test2', '  test3', '', 'folded line 2 "{{{1', '  test', '  test2', '  test3']
+  call setline(1, content)
+  set fdm=marker ww+=l
+  normal! x
+  call assert_equal(content, getline(1, '$'))
+  set fdm& ww&
+  bwipe!
+endfunc

Thanks.  But the line should still be deleted, thus in this case the
translated operation is "dd".
--
Facepalm statement #1: "I'm going to New York tomorrow, hopefully I have time
to visit the White House"
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


Fix: Report Command Bug template points to wrong test folder

Hi team,
The current template for creating issues via .github/ISSUE_TEMPLATE/report_command_bug.md have incorrect folder name for the tests folder.
You can find the tests under the `tests` directory of the [`dice`](https://github.com/dicedb/dice) repository
Should be
You can find the tests under the `integration_tests` directory of the [`dice`](https://github.com/dicedb/dice) repository
since we have migrate from the tests folder.
Thanks
Apoorv

hey, i want to fix this, can you assigned me this?


URL search query term

This PR adds the feature to change add a search query term to the url on search and to search for packages if a search term is included in the url. It includes specs, all of which are currently passing.

Closes #18. Closes #39.


[10.x] Ensure lazy-loading for trashed morphTo relations works

Since #50124 its no longer possible to lazy-load trashed morphTo relations.
Once the Conditionable trait is removed from the Relation class all works fine.
This PR covers this scenario with a test.

Wow, my first PR that breaks everyone's Laravel installation! 😅
The issue then still persists. I guess I'll have to investigate further.


Confuse about the success rate

I am new to metaworld! Thank you for the configuration of such meaningful and complex projects. I have some questions about the metaworld. In the project setting, does the success rate represent the success in one step or one episode? Because in your project, the agent will reach the max path length in one episode, such as 150, so does the success rate represent the average success rate in 150 steps or the success rate in the last step? Can you give me some points about it.

Another question! In ml45/10, we set 45 train environments, what is the relationship between the class num and the task num? If the task num is also 45/10, which means every environment only has one task?

@avnishn

Hi @jp18813100494, thanks for checking out Metaworld!
Let me try to answer your questions in order:

In the project setting, does the success rate represent the success in one step or one episode?

Let me start by saying that Success is equal to 1 if any step in an episode, the agent enters a success state of that environment. A successful episode would be one where any step in that episode is a successful step. For example in pick-place-v1 the agent is tasked with picking up a puck and placing it in a randomly placed 3d region that has a 7cm radius. Successful states in this environment would be defined by this region, and any way that the puck can end up in this region. If the puck enters this region during an episode, then the Success of that episode would be equal to 1, and 0 otherwise.
From there to compute the Success Rate of the agent on an environment, we collect a certain number of trajectories ~10-100, and observe how many of those are successful episodes. The Success Rate of the agent on that environment is then computed as number of successful episodes / total episodes.

I'm not quite sure if I understand your second question, so let me know if this answer doesn't satisfy you:
In the benchmark ml45, which is made up of 45 different environments, there are more than 45 tasks:
In a single Metaworld environment we define a single task of that environment to be 1 unique initialization of the object position and goal position. In the case of pick-place-v1, this would correspond to one random pair of (object_position, goal_position) where object_position is the starting position of the puck, and goal_position is the location of the center of the spherical region described above.
Depending on the benchmark that you are using, there is either 1 unique task per environment in that benchmark, or 50 unique tasks. For ML benchmarks such as ML1, ML10, and ML45, there are 50 unique tasks per environment in those benchmarks. For MT benchmarks such as MT1, MT10, and MT50, there is only 1 unique task per environment in those benchmarks.
I'm going to close this issue for now, but feel free to @ me (avnishn) and ask any more questions!

I'm not quite sure if I understand your second question, so let me know if this answer doesn't satisfy you:
In the benchmark ml45, which is made up of 45 different environments, there are more than 45 tasks:
In a single Metaworld environment we define a single task of that environment to be 1 unique initialization of the object position and goal position. In the case of pick-place-v1, this would correspond to one random pair of (object_position, goal_position) where object_position is the starting position of the puck, and goal_position is the location of the center of the spherical region described above.
Depending on the benchmark that you are using, there is either 1 unique task per environment in that benchmark, or 50 unique tasks. For ML benchmarks such as ML1, ML10, and ML45, there are 50 unique tasks per environment in those benchmarks. For MT benchmarks such as MT1, MT10, and MT50, there is only 1 unique task per environment in those benchmarks.
I'm going to close this issue for now, but feel free to @ me (avnishn) and ask any more questions!

Thanks for your sincere reply! As you said, for ML benchmarks such as ML1, ML10, and ML45, there are 50 unique tasks per environment.  What is the num of the training tasks in the ML45 setting?  I am clear of your setting of metaworld, but I don't know the detail of setting in your algorithm, MAML, RL, PEARL. Can you tell me the total num of your train task and test task for 50 environments for ML45 in PEARL? 45,5 or 45 50,550?

Hmm.
So the number of train tasks and test tasks for each benchmark doesn't change based on the algorithm.
Ml45 has 45 training environments and 5 testing environments. ML10 has 10 training environments and 5 test environments.
Each one of these environments has 50 unique task configurations. This would mean that in ML45. There are 4550 train tasks and 550 test tasks.
A meta learning algorithm that is being evaluated on ML10 or ml45 would train on the 10 and 45 environments, and each one of those environment's 50 unique tasks, and then would be evaluated on their meta adapt to the 5 test environments in ML10 and ML45. These test environments still have 50 unique tasks each, and each should be sampled during the many meta adapt test rollouts that will be completed throughout an algorithm's evaluation.
In terms of the code, changing an environment's task is as easy as calling the function set_task. For examples of how to use the function, refer to the examples in the readme.
A question one might have is: how often should set_task be called? While I don't have that information around from the original metaworld experiments (I am a maintainer of Metaworld, not one of the original authors) I can safely say that this is up to the implementor of the algorithm.
This may have been a bit more than you were looking for in an answer, but I hope that everything you are looking for is here!

I'm not quite sure if I understand your second question, so let me know if this answer doesn't satisfy you:
In the benchmark ml45, which is made up of 45 different environments, there are more than 45 tasks: In a single Metaworld environment we define a single task of that environment to be 1 unique initialization of the object position and goal position. In the case of pick-place-v1, this would correspond to one random pair of (object_position, goal_position) where object_position is the starting position of the puck, and goal_position is the location of the center of the spherical region described above.
Depending on the benchmark that you are using, there is either 1 unique task per environment in that benchmark, or 50 unique tasks. For ML benchmarks such as ML1, ML10, and ML45, there are 50 unique tasks per environment in those benchmarks. For MT benchmarks such as MT1, MT10, and MT50, there is only 1 unique task per environment in those benchmarks.
I'm going to close this issue for now, but feel free to @ me (avnishn) and ask any more questions!

Hi, I notice that in the paper (4.3 Evaluation Protocol), it says

Multi-Task 10, Multi-Task 50 (MT10, MT50): Learning one multi-task policy that generalizes to 50 tasks belonging to 10 and 50 training environments, for a total of 500, and 2,500 training tasks.

Therefore, it seems that in both MT10, MT50, we have 10 or 50 environments each with 50 tasks, which is contradicting to what you mention that only one unique task per environment.


mednaffe: init at 0.8

Things done:

[x] Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Please note, that points are not mandatory, but rather desired.

The commit should be titled mednaffe: init at 0.8.

@fpletz taken care of commit name, thanks.

The meta.version attribute is still present. Other than that, this looks ready to go.

@joachifm thanks. Removed.

Ah, I was just about to hit the button but I just had to pick a few more nits, sorry.