[modeline +light] invisible flycheck running icon

What did you expect to happen?
On +light modeline, when flycheck is in running state, we set the face to font-lock-comment-face here.
What actually happened?
At least for my theme, doom-molokai, this face is invisible on modeline.

It's odd because if I use this face on code, it shows normally, only on modeline that shows invisible.

Additional details:

Include a link to your private config: https://github.com/ericdallo/dotfiles/blob/master/emacs/.doom.d/config.el#L73

System information:

emacs   version    27.0.91
        features   XPM JPEG TIFF GIF PNG RSVG SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON PDUMPER GMP
        build      Jun 06, 2020
        buildopts  (--prefix=/nix/store/m2j53xz3xj8wazgyn8838f2zwgmpq07v-emacs-27.0.91 --disable-build-details --with-modules --with-x-toolkit=gtk3 --with-xft CFLAGS=-DMAC_OS_X_VERSION_MAX_ALLOWED=101200)
        windowsys  x
        daemonp    server-running
doom    version    2.0.9
        build      HEAD -> develop 7ecda0d8e 2020-06-05 04:05:29 -0400
        dir        ~/.dotfiles/emacs/.doom.d/
system  type       gnu/linux
        config     x86_64-pc-linux-gnu
        shell      /run/current-system/sw/bin/zsh
        uname      Linux 5.4.41 #1-NixOS SMP Thu May 14 05:58:30 UTC 2020 x86_64
        path       (/run/wrappers/bin ~/.nix-profile/bin /etc/profiles/per-user/greg/bin /nix/var/nix/profiles/default/bin /run/current-system/sw/bin ~/.emacs.d/bin ~/flutter/bin ~/.emacs.d/bin ~/flutter/bin /nix/store/m2j53xz3xj8wazgyn8838f2zwgmpq07v-emacs-27.0.91/libexec/emacs/27.0.91/x86_64-pc-linux-gnu/)
config  envfile    envvar-file
        elc-files  0
        modules    (:checkers syntax :completion (company +childframe) (ivy +icons) :ui doom doom-dashboard hl-todo (modeline +light) nav-flash ophints (popup +all +defaults) treemacs unicode vc-gutter vi-tilde-fringe window-select workspaces :editor evil file-templates fold (format +onsave) multiple-cursors rotate-text snippets :emacs (dired +ranger +icons) electric :term vterm :tools debugger (docker +lsp) (eval +overlay) lookup (lsp +peek) :lang (clojure +lsp) (dart +lsp) data emacs-lisp (go +lsp) (java +lsp) (javascript +lsp) (markdown +grip) nix (org +dragndrop +ipython +pandoc +present) (python +lsp) (ruby +lsp) (sh +lsp) web :config (default +bindings +smartparens))
        packages   ((cider) (clj-refactor) (clojure-mode) (dap-mode) (dhall-mode) (flutter) (flycheck-clojure) (flycheck-package) (hover) (lsp-dart :recipe (:local-repo ~/dev/lsp-dart :files (*.el) :no-byte-compile t)) (lsp-java) (lsp-mode :recipe (:local-repo ~/dev/lsp-mode :files (*.el) :no-byte-compile t)) (lsp-ui) (lsp-treemacs) (scss-mode) (treemacs) (paredit) (parrot :recipe (:host github :repo jnc-nj/parrot :branch master)) (posframe) (yaml-mode) (melpa-check :recipe (:host github :repo akirak/melpa-check :branch v3)))
        unpin      (treemacs lsp-treemacs (:lang dart))
        elpa       (vterm undercover shut-up el-mock dash)

I don't know what is the best approach, but we can create a specific defface for that, like how doom-modeline does?


chocolatey install dependencies

https://github.com/substrate-developer-hub/substrate-developer-hub.github.io/issues/1073
using chocolatey to install dependencies.

Thanks @saintfeng - @al3mart or @sacha-l  - do one of you guys have a windows build machine to test this procedure on? I would need to get access or configure a VM to do so 😅
Overall LGTM, pending a double-check on the procedure.

Tagging @al3mart here to check that these instructions work. Thank you !

I just tried this on a fresh win 10 box using the choco instructions and it worked well.

@saintfeng Can you imagine why didn't you run into any linker issues ? I think that offering an easy way of installing all this would be really good in terms of UX, but so far haven't worked for me.
Anyway, I will be happy of keep on trying new updates or tweaks.

Thanks @al3mart - should we add these instructions as a step here? Or do you think using Chocolately could lead to unnecessary confusion?

@sacha-l Well, I have tried again with clean PATH and I still run into the same linker not found error. But seeing that it is working for @gilescope and @saintfeng I am just afraid of not knowing why mine is failing and not knowing to help to users if they run into the same scenario.
Said so, I think that if we give all the options, choco + manual setup, and we add a comment like

Hey, if you are setting up LLVM using choco take into account this possible issue.

It should be fine. I don't think it could add confusion perse, as you can always set the dependencies by hand

Also, NukeManDan mentioned openssl is no longer needed. Can we confirm this?
And, a clear msg was give out that substrate repo didn't support windows building. Should we point out this?

https://matrix.to/#/!HzySYSaIhtyWrwiwEV:matrix.org/$163051470614557KVfGC:matrix.parity.io?via=matrix.parity.io&via=corepaper.org&via=matrix.org
Shawn reports that OpenSSL should not be needed, I think we can remove. If there are errors, we will watch closely and add that back.

https://github.com/paritytech/substrate/search?q=honggfuzz
Are you referring to npos-elections (and other aspects of substrate) cannot be build on windows? If so, yes, we should note that in this instruction, another reason to use WSL (but also the kind note to use it when you fail to build will at least help push others there, as we already do)

there were discussions about honggfuzz, like https://github.com/paritytech/substrate/issues/5957 and https://github.com/paritytech/substrate/pull/3872

conflict resolved

While I think we can still trim deps here, this is OK as is for now :)


openldap does not return distinguishedName field

Looks like OpenLDAP does not return distinguishedName on this call:
records = conn.search_s(current_app.config['LDAP_BASE_DN'],
                                    ldap.SCOPE_SUBTREE, query, fields)

result:
[('cn=boris,ou=users,dc=syncloud,dc=org',
{'objectClass': ['simpleSecurityObject', 'person'],
'description': ['LDAP administrator'],
'userPassword': ['{SSHA}***'],
'cn': ['boris'], 'sn': ['boris']})]

Is there any workaround or is it supported at all?

Hi,
You need to set LDAP_OBJECTS_DN to whatever field you want. distinguishedName is just the default. Full list of options here: https://flask-simpleldap.readthedocs.org/en/latest/


[Blockchain] Tx validation problem

Componet
blockchain.validator
Assignee
@junk-sound  @zeroFruit
Bug detail
It succeeds or fails depending on the number of transactions during the transaction verification process.

요거 진행중인가요??


[Bug]: slidesInView method returns invisible items

Which variants of Embla Carousel are you using?

[ ] embla-carousel (Core)
[X] embla-carousel-react
[ ] embla-carousel-vue
[ ] embla-carousel-svelte
[ ] embla-carousel-autoplay
[ ] embla-carousel-auto-scroll
[ ] embla-carousel-solid
[ ] embla-carousel-auto-height
[ ] embla-carousel-class-names
[ ] embla-carousel-fade
[ ] embla-carousel-docs (Documentation)
[ ] embla-carousel-docs (Generator)

Steps to reproduce
I use embla-carousel-react with Shadcn's carousel component. I need nextScrollSnap (similar to previousScrollSnap method) method so that i can get next visible item in carousel when next button  pressed. i wanted to use slidesInView method to achieve next scroll snap item but it returns different sized array for each next button press. You can see results in console.
Stackblitz
Expected Behavior
slidesInView method returns 1 more item if next/previous button pressed before scroll animation ends.
nextScrollSnap method would help me to use it like previousScrollSnap method.
Additional Context
I have also tried...
What browsers are you seeing the problem on?
Chrome
Version
v8.5.1
CodeSandbox
No response
Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues
[X] I agree to follow this project's Contributing Guidelines for bug reports

@erkanaltinors thanks for your question. I’m confused, the title suggests there’s something wrong with slidesInView (which shouldn’t be the case because Embla uses IntersectionObserver under the hood) but in your description it seems like you want to know which slide is next in turn?
If that’s the case, please move your question to a discussion in the help category instead. This isn’t a bug.
Thanks for understanding.

hi @davidjerleke , slidesInView method returns 1 more item if next button pressed before scroll animation ends. You can see the log if next button several times quickly.

Discussion added. Closing this issue. Thanks @davidjerleke

@erkanaltinors this is expected, because during transition, all slides with any part visible are considered in view. That’s how IntersectionObserver works (which is a native browser API).
If you want slides to be considered in view only when the full slide is in view, set the inViewThreshold option to 0.99.


What is the exact version of Office.js library?

How can I find the version of Office.js. My company requires us to obtain legal approvals for specific versions, so as we use Office JavaScript API we need to be able to find out how versions change.

Hi @dmitriyyepishin,
Office.js doesn't have versions, in this sense. We only support the latest version published to the CDN. Our officially stated policy can be found here: https://github.com/OfficeDev/office-js#support
Is there a specific concern your company has?

Thank you for your response. Our legal department reviews various product versions that we use to check for security and other issues to ensure that we protect our customers. Most products have version numbers and security and other issues can be tracked by version. Does Office.js have an issue tracker of some sort that we can access and monitor?

Issues with Office.js are tracked on the product repo here: https://github.com/OfficeDev/office-js
The NPM package you linked is usually the latest version, though I should call out this line from the Support section:

The frequency of the updates to this repository and related NPM package to match the CDN version is not guaranteed.

In practice, that accounts for the lag between publishing a new version to the CDN and that version getting published as an NPM package. Office Add-ins technically run off of the former.
Let me loop in @jeremy-msft, in case further clarifications are needed.

Thank you for the feedback. How can one know what version an issue has been fixed in?

Well, the answer is probably unfulfilling, but there aren't version notes in that capacity. Fixes are also often implemented through changes to Office itself, so the npm version wouldn't reflect that change anyway. What we can say is that the latest version on the CDN is the most patched version and that we maintain backward compatibility.
I'm going to close this issue, since there's nothing actionable to be done here. Please let us know if you have further questions.


feat: Add Array type to MultipartFormDataType variants for REST api

Description
Users can add an array as a value for multipart requests, and it will handle every item in the list as a part of the multipart request.

Example body:
--IpJ9ACFxVbhXlAQuIFccoJ0K0ttFS5PVyfX3
Content-Disposition: form-data; name="myArray"
Content-Type: text/plain;charset=UTF-8
Content-Length: 3

One
--IpJ9ACFxVbhXlAQuIFccoJ0K0ttFS5PVyfX3
Content-Disposition: form-data; name="myArray"
Content-Type: application/json
Content-Length: 1

2
--IpJ9ACFxVbhXlAQuIFccoJ0K0ttFS5PVyfX3
Content-Disposition: form-data; name="myArray"
Content-Type: application/json
Content-Length: 4

true
--IpJ9ACFxVbhXlAQuIFccoJ0K0ttFS5PVyfX3
Content-Disposition: form-data; name="myArray"
Content-Type: text/plain;charset=UTF-8
Content-Length: 4

Four
--IpJ9ACFxVbhXlAQuIFccoJ0K0ttFS5PVyfX3--

Fixes #10876
Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

How Has This Been Tested?

Unit test - DataUtilsTest.testParseMultipartArrayDataWorks()

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: feature/10876-backend-allow_dynamic_string_arrays_multipart

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
55.78 (0.02)
37.23 (0.02)
35.38 (0.03)
56.03 (0.01)

:green_circle:
app/client/src/utils/WorkerUtil.ts
89.76 (0)
72.55 (1.96)
100 (0)
93.33 (0)

:green_circle:
app/client/src/utils/helpers.tsx
69.75 (2.77)
37.95 (3.59)
56.14 (5.26)
67.6 (2.8)

/ok-to-test sha=af686a0

/ok-to-test sha=af686a0

/ok-to-test sha=af686a0

/ok-to-test sha=2c8f0bf

/ok-to-test sha=f8355af

/ok-to-test sha=a9f8a03

/ok-to-test sha=a9f8a03

/ok-to-test sha=a9f8a03

/ok-to-test sha=a9f8a03

/ok-to-test sha=a9f8a03

/ok-to-test sha=a9f8a03

/ok-to-test sha=fca63f1


Crash w/ Streams Mod

Forge 2221
Valkyrien Warfare v0.8.7b
Streams v0.3
Farseek v2.1
Nether Ex v1.1.0b (Shown as nex in the crash log.)
I got a crash once my world loaded with the Streams Mod.
And, based on the crash log, it looks like the Nether Ex Mod might also be involved.
Crash Log:
crash-2017-02-18_00.59.14-server.txt

After starting a game without Nether Ex and only Streams and Valkyrien Warfare, the world loaded fine.
So it looks like the problem is from Nether Ex or both Nether Ex and Streams.

I am unable to reproduce this bug

Old issue, closed.


Error Message format when gauge quits due to a fatal error

Format errors in a specific format when gauge errors with a specific format.
Suggested format for showing errors.
Error ----------------------------------

Error message

Get Support ----------------------------
	Docs:          https://docs.gauge.org
	Bugs:          https://github.com/getgauge/gauge/issues
	Chat:          https://gitter.im/getgauge/chat

Your Environment Information -----------
	OS, gauge version with commit hash
	plugins with version

can you paste a sample output?

Sample output
Error ----------------------------------

Failed to read last run information. Reason: [File /usr/somebody/a/.gauge/failures.json doesn't exist.]


Small availability checking fixes

A handful of problems found by inspection.

@swift-ci Please smoke test


⚠ WSINGRESOS - GENERICO has degraded performance

In 73899e2, WSINGRESOS - GENERICO (https://srvshyweb.yucatan.gob.mx/cgi-bin/wspd_cgi.sh/WService=wsingresos/internet/servicios/wsGenericoPagosWeb.r) experienced degraded performance:

HTTP code: 200
Response time: 6188 ms

Resolved: WSINGRESOS - GENERICO performance has improved in 39e16cc.


Generate correct dependencies for ALLOCATE AVAILABLE

The ALLOCATE AVAILABLE function requires a special second argument that uses the first element of the priority profile to indicate the entire array. This special arrangement avoids giving the full dimension name in the argument, which would then require the dimension name to appear on the LHS. Like Vensim, SDEverywhere references all elements of the priority profile based on the first element. But this results in the first element alone being listed as a reference. For instance, the command:
sde generate --list models/allocate/allocate

includes this among the references for the shipments[region] variable:
_priority_vector[_region,_ptype]

The ptype and pextra elements are constants by convention and so are not needed in the references. However, the ppriority and pwidth elements are needed as references. This happens to not be an issue in our small test model, but puts dependencies out of order in a larger model.

We need to rewrite the references for an ALLOCATE AVAILABLE variable when they are generated in   EquationReader. Drop the ptype reference, but use its subscript family to find the ppriority and pwidth index names. Splice them into the original reference to derive the correct references. The listing for allocate.mdl now contains these references:
_priority_vector[_region,_ppriority], _priority_vector[_region,_pwidth]

I also corrected a mistake in the _ALLOCATE_AVAILBLE C function. The initial x value in the search should be in the midpoint of the mean extremes, but the calculation of this was wrong.


Improve Documentation

Currently this repo, like many others in the talon ecosystem, has a discoverability challenge. Most users want to quickly understand commands and not need to reference .talon files. The model help command is a good start, but does not describe the whole grammar. As such, based on usage patterns in the public forks, it seems that people are just using model $PROMPT and not applying targets or destinations.
We have a few options

Use a docs as code approach

talondoc doesn't support .talon-list files so I don't think it is the proper choice at the moment. I am also just not much of a fan of readthedocs and it is better for API reference imo, not documentation.
We could autogenerate docs locally but we can't do that in CI since talon doesn't run in CI

Create a simple website describing the grammar more fully

Thinking of having a horizontal row of drop down menus. Each menu contains all the options for that particular part of the grammar. Each menu drop down would be labeled if that part of the grammar is required or optional. (i.e. model is required, but [{user.modelSource}] is not when speaking a command)
Could use any JS framework, or even vanilla JS. We just want something that would compile to a static site such that it can be hosted on github pages, or ran locally without npm installed
We probably still want to template the final page in some capacity, so we can pass in the list of prompts dynamically from talon  and not need to worry about hard coding all of them.
We probably want to have a page for any talon settings, lists, and tags that affect this repo.

This is mainly described in the readme's but people are probably not referencing those much

It would be nice to have a quick tutorial. So having a sample use case and all the commands a user would need to do to accomplish it

We could also just use Docusaurus for all of this like the talon wiki or Cursorless docs does, but I feel that is overkill. I would like to ship the site in this repo and have it be easy to template or create custom interactive docs, even if it is less feature rich.

Open to other ideas if anyone has a preferred strategy. We don't need to implement all of the above all at once. We have a lot of cool functionality in this repo and I want to make it easier for new users to discover and use.

based on usage patterns in the public forks, it seems that people are just using model $PROMPT and not applying targets or destinations

While I do think it is objectively a good idea to focus on having good documentation, I think it is difficult to draw a strong conclusion based on the usage patterns in public forks:

It is not a requirement in this repository to make a fork to use it
Those who have forked the repo are not necessarily using it regularly
The usage patterns of people whether they're using a fork or not is opaque since we aren't tracking people

I think that one of the best ways to see and learn how to use talon in community and elsewhere is to have videos demonstrating how people use it. I sometimes tried to publish videos of my usage patterns in #demos in the talon community slack but I could do it more often. The main thing that prevents me from doing it more is that I'm working on proprietary things and can't share that.
I like the ideas here for improving the documentation. One question that I have is how we will know if the documentation improvements have been successful-I don't think that looking at the forks is going to be very useful for answering that question. Maybe we can use a poll or something like that?

Yes I agree that patterns in forks are not ideal data. However, we don't have any other data. So it's the best we have. Either way, I don't have any indication that anyone is using the more complicated commands. So mainly just trying to improve discoverability. The lack of issues posted here is probably a good sign frankly, but it also means that people are probably not exploring / tinkering much. Thats just my best guess.

I think some demonstration videos could go a long way. The other day I was pairing with someone and I used 'model blend' in his reaction was 'wow'. A lot of these commands are much better seen and understood that way than to read about.

Yup you are right. I think gifs are good too.

Closed since I think the docs are improved since this was opened.

That being said we could still use some gifs or better helpers (i.e. drop downs to dynamically see the grammar of a valid command) but that is out of scope for this issue probably


Sinter Custom Sampler

Similar to how sinter supports custom decoders, it should support custom samplers.
Use cases for this include someone lightly wrapping the flip or tableau simulator, or using a more complex tool like a cirq or numerical simulator to produce the measurement or detector outcomes.
This should allow people to avoid re-implementing sinter's nice multiprocessing approach to sampling when they want to make a change to how the sampler works.

Hi, has there been any progress on this issue recently? I have a project coming up that requires a custom sampler. If you currently don't have the time to address it, I would be willing to contribute.


(WAYF) Add isGuestTenant to tenant model

Finished review. Back to @mrvisser for follow-up

This is now ready for review. To @nicolaasmatthijs

Looks good. Merged


Node 10 requires 4.9, this is mentioned in the issue template. I'll try to make that even more explicit

Originally posted by @nschonni in https://github.com/sass/node-sass/issues/2383#issuecomment-389539548

am using Node 10.14.0 bu facing the below issue

<EMAIL_ADDRESS>install D:\Yasar\wiproshopTracker\node_modules\node-sass
node scripts/install.js

Downloading binary from https://github.com/sass/node-sass/releases/download/v4.5.3/win32-x64-64_binding.node
Cannot download "https://github.com/sass/node-sass/releases/download/v4.5.3/win32-x64-64_binding.node":
HTTP error 404 Not Found
Hint: If github.com is not accessible in your location
try setting a proxy via HTTP_PROXY, e.g.
  export HTTP_PROXY=http://example.com:1234

or configure npm proxy via
  npm config set proxy http://example.com:8080

Added another note in https://github.com/sass/node-sass/commit/dfe1f05aba0f681eb237bc146d8cf1716d1086c4


Merge to live!

[Add-ins] (auth) Update when to use Exchange user identity token

Update correct section

Docs Build status updates of commit b2f67f1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/add-ins/authentication.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Devices Showing offline

I am able to see devices after installing apk on android. But they are offline all the time.
Please Help

The application may be being killed by some battery monitoring task, it should respawn on a notification or on a clipboard event.
Alternatively, could it be possible that your IP has changed?

I have given all permissions from settings and disabled battery
optimization for this application, autorun enabled etc.
To followup this case

How can I check if application is running or not?
How can I start the application? I don't have any way from which I can
launch the application.

IP change is not the case, I checked it. Admin panel is up and running. And
I can access it on that IP only. The same IP is configured while building
the apk.
Thanks and regards,
On Sun, Oct 27, 2019, 00:42 Jack Rogers<EMAIL_ADDRESS>wrote:

The application may be being killed by some battery monitoring task, it
should respawn on a notification or on a clipboard event.
Alternatively, could it be possible that your IP has changed?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/etechd/L3MON/issues/4?email_source=notifications&email_token=AEHVR563VUBBQUVLB6OF3JDQQSJBVA5CNFSM4JFMGFB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECKO5XY#issuecomment-546631391,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEHVR57GRGRQW3JBO2GZC33QQSJBVANCNFSM4JFMGFBQ
.

Try going to your dialer and dialing *#*#8088#*#* This should bring up one of the original menus, though more importantly, start the service running again.
If this doesn't bring up a menu, try recompiling and re installing the APK.
To see if the app is running, goto Android Settings -> Apps & Notifications -> See All *** Apps and look for Process Manager, click it and you should see 2 buttons Uninstall and Force Stop, if Force Stop is grayed out, the app is not running.
If all of the above still doesn't solve your issue, can you download ADB tools and connect to the phones shell and run this command: logcat | grep L3MON and pop the output on Gist/Pastebin for me; please?
Thanks

Yes, Force stop option is disabled.
And adb logs shows this
W/BroadcastQueueInjector: Unable to launch app com.etechd.l3mon/10172 for
broadcast Intent { act=android.provider.Telephony.SECRET_CODE
dat=android_secret_code://8088 flg=0x10000010 }: process is not permitted
to  auto start
I have enabled all permissions from settings. Disabled all battery
optimizations.
Thanks
On Fri, 1 Nov 2019 at 21:34, Jack Rogers<EMAIL_ADDRESS>wrote:

Try going to your dialer and dialing ##8088## This should bring up
one of the original menus, though more importantly, start the service
running again.
If this doesn't bring up a menu, try recompiling and re installing the APK.
To see if the app is running, goto Android Settings -> Apps &
Notifications -> See All *** Apps and look for Process Manager, click it
and you should see 2 buttons Uninstall and Force Stop, if Force Stop is
grayed out, the app is not running.
If all of the above still doesn't solve your issue, can you download ADB
tools and connect to the phones shell and run this command: logcat | grep
L3MON and pop the output on Gist/Pastebin for me; please?
Thanks
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/etechd/L3MON/issues/4?email_source=notifications&email_token=AEHVR55ER3C4YUWFUFZ372TQRRHQTA5CNFSM4JFMGFB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC3LLAQ#issuecomment-548844930,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEHVR5YTWV2JHEITVQGL7QLQRRHQTANCNFSM4JFMGFBQ
.

What device is this running on, Is it a Xaiomi? If so, please have a read thru this https://stackoverflow.com/questions/29627856/reboot-receiver-is-not-working-in-xiaomi-phones
It appears the app is being blocked from starting by some process manager on your device still.
Thanks

Yes it is a Xaiomi device, I will follow those answers and try to make
changes, and will keep you updated.
Thanks And Regards
On Tue, 5 Nov 2019 at 22:55, Jack Rogers<EMAIL_ADDRESS>wrote:

What device is this running on, Is it a Xaiomi? If so, please have a read
thru this
https://stackoverflow.com/questions/29627856/reboot-receiver-is-not-working-in-xiaomi-phones
It appears the app is being blocked from starting by some process manager
on your device still.
Thanks
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/etechd/L3MON/issues/4?email_source=notifications&email_token=AEHVR55Q7625D2ULKVPZJ2TQSGUA3A5CNFSM4JFMGFB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDDSCJQ#issuecomment-549921062,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEHVR53REEB22UY2B6QZJG3QSGUA3ANCNFSM4JFMGFBQ
.

It started working.
So on Xaiomi devices, one need to disable MIUI Optimization setting from developer options.
(And of course grant permissions and allow auto start and disable battery optimization - which I already did before starting this thread.:P)
Thanks @Jack-Rogers for the help.
L3MON Tested and working as advertised. :)

Excellent stuff, Glad you got it going!


HTTP error 404 Not Found

$npm install
npm WARN deprecated<EMAIL_ADDRESS>Way too old

><EMAIL_ADDRESS>install /data/data/com.termux/files/home/hsg/hexo/node_modules/node-sass
> node scripts/install.js

Downloading binary from https://github.com/sass/node-sass/releases/download/v4.12.0/android-arm64-72_binding.node
Cannot download "https://github.com/sass/node-sass/releases/download/v4.12.0/android-arm64-72_binding.node":

HTTP error 404 Not Found

https://github.com/sass/node-sass/blob/master/TROUBLESHOOTING.md#404s
Android isn't supported. You can search the issue tracker for the previous discsussions


Serialization issue getting images for product with custom image type

Hi,
Our client has a image type called Rotator Image (I assume this is a custom image type based on a extension) and I get an JSON serialization exception raised when trying to load images for a product using the following call client.GetImagesForProduct.
Exception is:
Newtonsoft.Json.JsonSerializationException
Message = "Requested value 'rotator_image' was not found."
Error converting value "rotator_image" to type 'Magento.RestApi.Models.ImageType'. Path 'types[0]', line 1, position 172.

I added the type to the enumerator in the latest version 1.0.4


Create plot_genome_data.ipynb

Current coverage is 58.77%

Merging #70 into master will not affect coverage as of eddad71

@@            master     #70   diff @@
======================================
  Files           11      11
  Stmts         1999    1999
  Branches         0       0
  Methods          0       0
======================================
  Hit           1175    1175
  Partial          0       0
  Missed         824     824

Review entire Coverage Diff as of eddad71

Powered by Codecov. Updated on successful CI builds.

This is meant to be a sketch of a data quality panel that we could add to the genome landing page.
There are 4 plots included in this notebook, Contig GC% vs Contig position, Contig GC% vs Contig Length, Contig GC% vs log10 Contig Length, and then a distribution plot of Cumulative GC%.

Looking for feedback on contents for genome landing page data quality summary panel, @samseaver @briehl @aparkin @psdehal.  Marcin is working on some plots using the data_api.  I'd like to make sure we have something useful for microbes and plants at least.  Marcin can submit new plot screens here as he makes updates.

Attached is a screenshot for the latest version of this notebook. I'm still
testing  which plots might work with which data but the idea is to generate
a set of plots from which we can make selections. The bottom right
histogram has a strange y-axis for still unknown reasons and there are more
upgrades in the works.
[image: Inline image 2]
On Fri, Sep 18, 2015 at 11:47 AM, Matt Henderson<EMAIL_ADDRESS>wrote:

Looking for feedback on contents for genome landing page data quality
summary panel, @samseaver https://github.com/samseaver @briehl
https://github.com/briehl @aparkin https://github.com/aparkin @psdehal
https://github.com/psdehal. Marcin is working on some plots using the
data_api. I'd like to make sure we have something useful for microbes and
plants at least. Marcin can submit new plot screens here as he makes
updates.
—
Reply to this email directly or view it on GitHub
https://github.com/kbase/data_api/pull/70#issuecomment-141533555.

It didn't seem like the new screenshot appeared correctly

I didn't see the graphics either. Do you have a mock-up of the entire page yet?
There are key tables we would want for different genome types of course.
There are the basic functional enrichments.
Measurements of goodness of annotation (number of specifically annotated genes, etc. etc. with possible inkage to supporting data).
Some depiction of the replicons and their key properties (including location... eg. K. lactis has a nuclear genome and a cytoplasmic plasmid with an orthogonal replication system).
Something about quality and closure of sequence.
...

Thanks, Adam -- there is no mockup, but my understanding is we will be
working off of the existing genome landing page. We have looked at the
ENSEMBL genome page design and it has most of the details you list and
more. My only comment for now is that we are working with the data which is
available in current genome objects. I think the hope is that future KBase
reference genome uploads will have more data. Your suggestions may help
prioritize which data to collect or create, even if only with the data API.
Strange about the graphic -- there is no attachment or graphic is blank?
It is showing in my gmail email thread and I am attaching the image I
downloaded from the thread.
Maybe its some file extension issue? Just in case I renamed the extension
to .pnge so if this does work then you'll have to rename.
I also attached one with a different file name in case that was the problem
...
If all that fails there's google drive:
https://drive.google.com/file/d/0Bw1H97l186NEbkRnRVI2M0tqaFk/view?usp=sharing
[image: Inline image 2]Screen Shot 2015-09-19 at 12.45.21 AM.png
[image: Inline image 1]
On Sun, Sep 20, 2015 at 2:40 PM, Adam Arkin<EMAIL_ADDRESS>wrote:

I didn't see the graphics either. Do you have a mock-up of the entire page
yet?
There are key tables we would want for different genome types of course.
There are the basic functional enrichments.
Measurements of goodness of annotation (number of specifically annotated
genes, etc. etc. with possible inkage to supporting data).
Some depiction of the replicons and their key properties (including
location... eg. K. lactis has a nuclear genome and a cytoplasmic plasmid
with an orthogonal replication system).
Something about quality and closure of sequence.
...
—
Reply to this email directly or view it on GitHub
https://github.com/kbase/data_api/pull/70#issuecomment-141837550.

@realmarcin to have the screenshots with plots appear in the github PR you can drag and drop the image into a comment.

good idea, thanks
On Sun, Sep 20, 2015 at 7:15 PM, Matt Henderson<EMAIL_ADDRESS>wrote:

@realmarcin https://github.com/realmarcin to have the screenshots with
plots appear in the github PR you can drag and drop the image into a
comment.
—
Reply to this email directly or view it on GitHub
https://github.com/kbase/data_api/pull/70#issuecomment-141859547.

@aparkin the specific goal here is to sketch out and determine an additional panel to add to the genome landing page that provides a data quality summary.  I would like to determine what that content should be independent of what we actually have in the objects today.  It may be that there is a difference between what should be there vs what we have, and then at that point we may not be able to provide all of that today, but we could work towards the full content.  So far the plots Marcin has worked on are oriented around the assembled contig sequences, as you mentioned some quality measures of the annotation of the sequence is also important to have.  I would like to make sure we're getting the content right here.

@samseaver @aparkin can you give a thumbs up/thumbs down to each of the plots marcin is proposing for the data quality panel?  Basically you're seeing his sketch so far.  If the content is way off, please make suggestions and/or direct him to literature or examples that would be constructive for data quality of microbial and eukaryotic assembly and microbial and eukaryotic annotation.
Marcin is working on a plot showing numbers of features per contig.

Now with the Nx plot. The last missing piece is reflecting the contig length steps in the percentiles.

Its not the full screenshot because my jupyter output panel is misbehaving again.
There are still issues with two histogram scales.

These are nice summaries for the assemblies. Is there a maximum number of contigs that can be evaluated? I only ask because some of the draft eukaryotic or metagenomic assemblies can have many tens to hundreds of thousands of sequences (or more). Note these displays are also useful for comparing different assemblies, such as to overlay multiple curves in a single Nx plot. For example, see figure 2b here: http://www.pnas.org/content/early/2015/09/15/1516718112.full.pdf

Thanks for the feedback, its really appreciated.
Yes, there is an upper limit and we don't have a hard number yet, but my
gut says things will start breaking down around 10E6 data points. We have
tried generating these plots in series for many genomes and things stop
after a few large eukaryotic ones because of browser memory limits. For
those extreme datasets we may need a different strategy such as serving a
static image from a KBase service. However, these things are hard for
everyone and there are some real problems there.
For the multiple comparison ideas -- yes, that's in the plans. Many of
these plots could show multiple assemblies, with some redesign. This will
become more powerful when performance of the API is optimized and when more
genomes and assemblies are available as new objects.
In the future sometime there will be a focus on assemblies and reads as
well, and that will allow to plug in to all the per-base quality measures.
On Sat, Sep 26, 2015 at 7:26 AM, Michael Schatz<EMAIL_ADDRESS>wrote:

These are nice summaries for the assemblies. Is there a maximum number of
contigs that can be evaluated? I only ask because some of the draft
eukaryotic or metagenomic assemblies can have many tens to hundreds of
thousands of sequences (or more). Note these displays are also useful for
comparing different assemblies, such as to overlay multiple curves in a
single Nx plot. For example, see figure 2b here:
http://www.pnas.org/content/early/2015/09/15/1516718112.full.pdf
—
Reply to this email directly or view it on GitHub
https://github.com/kbase/data_api/pull/70#issuecomment-143453612.

Marcin, let's get this notebook in the develop branch.  We also have it in the CI Narrative, but I would like to also see it checked in.

@realmarcin when you are not busy with something else, switch the target of this PR to develop so we can get it merged.  At the time we were working off of master, so it makes sense that it originally was going there.  I was hoping for more feedback but that didn't show, so we'll just get this in and move on.

OK, thanks.
On Mon, Nov 2, 2015 at 2:23 PM, Matt Henderson<EMAIL_ADDRESS>wrote:

@realmarcin https://github.com/realmarcin when you are not busy with
something else, switch the target of this PR to develop so we can get it
merged. At the time we were working off of master, so it makes sense that
it originally was going there. I was hoping for more feedback but that
didn't show, so we'll just get this in and move on.
—
Reply to this email directly or view it on GitHub
https://github.com/kbase/data_api/pull/70#issuecomment-153176889.

For switching the target branch, it looks like I need reclone and move over
my changes?
I checked and my current fork has no develop branch listed on github, so
perhaps it was created after I cloned.
On Mon, Nov 2, 2015 at 2:26 PM, Marcin Joachimiak <
<EMAIL_ADDRESS>wrote:

OK, thanks.
On Mon, Nov 2, 2015 at 2:23 PM, Matt Henderson<EMAIL_ADDRESS>wrote:

@realmarcin https://github.com/realmarcin when you are not busy with
something else, switch the target of this PR to develop so we can get it
merged. At the time we were working off of master, so it makes sense that
it originally was going there. I was hoping for more feedback but that
didn't show, so we'll just get this in and move on.
—
Reply to this email directly or view it on GitHub
https://github.com/kbase/data_api/pull/70#issuecomment-153176889.

If you set up the remote upstream, you can git fetch upstream, then that
will pick up the develop branch.
At that point you just need to commit that file to your local develop
branch and submit a PR to data_api:develop and we can merge it in.
You should not need to refork.
On Tue, Nov 3, 2015 at 3:01 PM, realmarcin<EMAIL_ADDRESS>wrote:

For switching the target branch, it looks like I need reclone and move over
my changes?
I checked and my current fork has no develop branch listed on github, so
perhaps it was created after I cloned.
On Mon, Nov 2, 2015 at 2:26 PM, Marcin Joachimiak <
<EMAIL_ADDRESS>wrote:

OK, thanks.
On Mon, Nov 2, 2015 at 2:23 PM, Matt Henderson<EMAIL_ADDRESS>wrote:

@realmarcin https://github.com/realmarcin when you are not busy with
something else, switch the target of this PR to develop so we can get it
merged. At the time we were working off of master, so it makes sense
that
it originally was going there. I was hoping for more feedback but that
didn't show, so we'll just get this in and move on.
—
Reply to this email directly or view it on GitHub
https://github.com/kbase/data_api/pull/70#issuecomment-153176889.

—
Reply to this email directly or view it on GitHub
https://github.com/kbase/data_api/pull/70#issuecomment-153516244.

Great, thanks!

On Nov 3, 2015, at 4:13 PM, Matt Henderson<EMAIL_ADDRESS>wrote:
If you set up the remote upstream, you can git fetch upstream, then that
will pick up the develop branch.
At that point you just need to commit that file to your local develop
branch and submit a PR to data_api:develop and we can merge it in.
You should not need to refork.
On Tue, Nov 3, 2015 at 3:01 PM, realmarcin<EMAIL_ADDRESS>wrote:

For switching the target branch, it looks like I need reclone and move over
my changes?
I checked and my current fork has no develop branch listed on github, so
perhaps it was created after I cloned.
On Mon, Nov 2, 2015 at 2:26 PM, Marcin Joachimiak <
<EMAIL_ADDRESS>wrote:

OK, thanks.
On Mon, Nov 2, 2015 at 2:23 PM, Matt Henderson<EMAIL_ADDRESS>wrote:

@realmarcin https://github.com/realmarcin when you are not busy with
something else, switch the target of this PR to develop so we can get it
merged. At the time we were working off of master, so it makes sense
that
it originally was going there. I was hoping for more feedback but that
didn't show, so we'll just get this in and move on.
—
Reply to this email directly or view it on GitHub
https://github.com/kbase/data_api/pull/70#issuecomment-153176889.

—
Reply to this email directly or view it on GitHub
https://github.com/kbase/data_api/pull/70#issuecomment-153516244.

—
Reply to this email directly or view it on GitHub.

Ok, this notebook has been merged into the develop branch, closing this PR.


Plugin not working

I've installed the plugin but I can't seem to access it as socialAuth is an undefined variable. Do I need to initialize it?

I've found an error in docs, you should access to the plugin instance via cordova.plugins.socialAuth

@jvence I've updated the docs https://github.com/xxsnakerxx/cordova-plugin-social-auth/commit/8c08dd35b72381ac820a883c21750ba7ea4c0e22

Closed due no lack activity


Resizable drawer issue after scrolling

Hi, @saade @s-r-x  please check the below recording, I can't resize the drawer after scrolling.

Chrome:  91.0.4472.77 (Official Build) (x86_64)
macOS Big Sur
"@bull-monitor/express": "^0.26.0"

https://user-images.githubusercontent.com/7368063/121697771-5f260180-ca9b-11eb-89f2-731a02c845aa.mp4

Aslo, do you think it is possible to allow resizable width until to 50vw?

Hmm, i can hotfix that. No problem
@s-r-x what you think about the 50vw? Currently it allows up to 2x drawerWidth

@saade sure, why not

np, just to be inline with you =)
ps. this is in a FHD monitor, looks kinda a overkill

what about 30vw? or max to 5x width? it is good to see these as screenshots.

@saade, yeah,  looks weird. reminds me of Insomnia's ui. but if the man likes queue names like test2_test2_test2_extension_dissaproval - let him have it!

actually right now I'm not quite sure that resizable drawer was a good idea. maybe simple material tooltips would be a better option... Personally I'll be happy with any option, because standard drawer width covers all my needs :)

@weilinzung fixed in 0.27.2


HTTP auth redundancy

When using HTTP, user is prompted for authentication at each operation. This is fine for pushing but for pulling this is irritating when pulling multiple branches...
Figure out a way to cache user credentials for a given time (commander?)

Check this

Fixed, closing now.


What exactly this function do?

Is this function is only for proxy? What if I want to use blob trigger in a function and send every message arrives at blob to virtual machine? (Assuming I have a windows service listening in Virtual machine in a VNET)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: de4662c6-e943-b48f-6d19-8d0db28007b5
Version Independent ID: b8219a5a-94f0-3246-9a59-9d308f93d78a
Content: Integrate Azure Functions with an Azure virtual network
Content Source: articles/azure-functions/functions-create-vnet.md
Service: azure-functions
GitHub Login: @alexkarcher-msft
Microsoft Alias: alkarche

Hi @codemaker Thanks for reaching out. We will review and update as appropriate.

@codemaker  Have you considered ASE for this. In ASE,you have the option for putting Azure Function inside the VNET itself. In that way , it will not act as a Proxy and you have complete control for the inflow and outflow traffic .

@codemaker For now I will proceed with closure of this and If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


feat: another idea of Validator Middleware

I like the current validator middleware API:
app.post(
  '/json',
  validation((v) => ({
    json: {
      'post.author.name': v.isAlpha,
    },
  })),
  (c) => {
    return c.text('Valid')
  }
)

But there are times when I want "Types":
  async (c) => {
    const data = await c.req.json()
    // How can I access `post.author.name` ?
    return c.text('Valid')
  }

So I implemented the new idea of Validator Middleware that support "Types". This is the approach of "declaring the keys of properties first".
app.post(
  '/posts',
  validator((v) => ({
    id: v.json('post.id').asNumber().isRequired(),
    title: v.json('post.title').isRequired().isLength(400),
    body: v.json('post.body').isOptional(),
  })),
  (c) => {
    const data = c.req.valid()
    return c.text(`ID is ${data.id}, Title is ${data.title}`)
  }
)

Wow, we got "Types"!
There are other good points to this approach as well.

Easy to understand the result data because "declaring property name first".
Easy to writing rules. v.isLength(400) is better than [v.isLength, 400] .
Getting only "declared properties". Additional properties are always ignored. It's safe.

I liked the current Validator Middleware, but I like this one even better.
One thing that bothers me is the implementation of hono.ts has become more complex.
How do you think about this?

@yusukebe
That's wonderful!
The following points are also very good

Easy to understand the result data because "declaring property name first".
Easy to writing rules. v.isLength(400) is better than [v.isLength, 400] .
Getting only "declared properties". Additional properties are always ignored. It's safe.

I think the implementation of this PR is good, but let me confirm one point.
Is it best to insert it as middleware?
For example, we could define it as a function like the following.

Define rules
Applying the rule

I think this way can be implemented only in the middleware without complicating hono.ts.
I also think this approach would allow multiple rules to be applied in a single request.
However, I understand the opinion that "inserting as middleware is more declarative to the request".
import { validationRule, validate } from 'middleware/validator'

const rule = validationRule((v) => ({
  id: v.json('post.id').asNumber().isRequired(),
  title: v.json('post.title').isRequired().isLength(400),
  body: v.json('post.body').isOptional(),
}))
app.post('/posts', (c) => {
  const data = validate(c, rule)
  return c.text(`ID is ${data.id}, Title is ${data.title}`)
})

Hi @usualoma !
Thank you for the comment.

However, I understand the opinion that "inserting as middleware is more declarative to the request".

Yes. I think it's better to validate before dispatching the handler. Besides, the API is prettier if it's as Middleware.
I would like to go with this if no one else has an opinion.

I think we can go ahead with the PR as is!

Hi @yusukebe!
Is the merge result of this PR currently working correctly? I got the following results in my environment.

I made the following changes and it worked.
diff --git a/src/middleware/validator/middleware.ts b/src/middleware/validator/middleware.ts
index 5e9d059..d168c47 100644
--- a/src/middleware/validator/middleware.ts
+++ b/src/middleware/validator/middleware.ts
@@ -7,14 +7,12 @@ type ValidationFunction<T> = (v: Validator, c: Context) => T

 type Schema = Record<string, VString | VNumber | VBoolean | VObject>
 type SchemaToProp<T> = {
-  [K in keyof T]: T[K] extends VBase
-    ? T[K]['type'] extends 'number'
-      ? number
-      : T[K]['type'] extends 'boolean'
-      ? boolean
-      : T[K]['type'] extends 'string'
-      ? string
-      : never
+  [K in keyof T]: T[K] extends VNumber
+    ? number
+    : T[K] extends VBoolean
+    ? boolean
+    : T[K] extends VString
+    ? string
     : never
 }

Alternatively, the following changes also worked.
diff --git a/src/middleware/validator/validator.ts b/src/middleware/validator/validator.ts
index d12bba6..54ca8e9 100644
--- a/src/middleware/validator/validator.ts
+++ b/src/middleware/validator/validator.ts
@@ -163,9 +163,10 @@ export abstract class VBase {
 }

 export class VString extends VBase {
+  type: 'string' = 'string'
+
   constructor(options: VOptions) {
     super(options)
-    this.type = 'string'
   }

   isEmpty = (
@@ -212,9 +213,10 @@ export class VString extends VBase {
 }

 export class VNumber extends VBase {
+  type: 'number' = 'number'
+
   constructor(options: VOptions) {
     super(options)
-    this.type = 'number'
   }

   isGte = (min: number) => {
@@ -227,9 +229,10 @@ export class VNumber extends VBase {
 }

 export class VBoolean extends VBase {
+  type: 'boolean' = 'boolean'
+
   constructor(options: VOptions) {
     super(options)
-    this.type = 'boolean'
   }

   isTrue = () => {

@usualoma
You are right. I have fixed the problem with the following PR, please review it.
#545


WASM support

WASM Support Added in v3.0.4.

@mayur-ctn  when will be v.3.0.4 released?

@JagadishaIncture Its already live

I Don't see Js Target in build.gradle

@JagadishaIncture Its added in the library. v3.0.4


[CV] Request new entry: total ion current max (until RT)

What is the QC term's name?
total ion current max (until RT)
Briefly describe the QC term.
This metric should capture the maximum value of a run's total ion current (TIC) (until a given retention time)
Like in #247 and #246 this could either be one or two metrics (one global, one until a given retention time)
This could maybe be modeled using a tuple or table specifying the RT and the maximum TIC until this RT (while maybe RT=-1 means globally)
What is the QC term's unit?
intensity / arbitrary and time (in seconds)
Value type
MS:4000004 ! n-tuple
Describe any additional information.

this term is ID-free and can easily be calculated using all spectra (MS1 and MS2)
it is applicable to a single run
the value should be (relatively) constant for same / similar samples

We have related terms MS:4000029 ! area under TIC in MS1 and MS:4000030 ! area under TIC in MS2, this would be the sum of those two? We also have MS:4000054 ! TIC quarters RT fraction.


[Bugs] AMF processes entire plaintext initial NAS message

Describe the bug
While testing the free5gc AMF for some NAS security features introduced in the 5G specifications, I found that the AMF processes any plaintext initial NAS message entirely (all IEs in the message are processed), without further check or warning. While the AMF still requests the replay of the initial NAS message in the Security Mode Complete, it does not care in case nothing is replayed, or a different message than the initial one, what seems contradictory to the "spirit" of the 5G security specification.
You can refer to 3GPP TS 33.501 section 6.4.6 for the global overview of the feature (while it is not saying anything specific to do in case the initial NAS message is not replayed or different), and TS 24.501 section 4.4.6 for the list of IEs that are to be processed in plaintext initial NAS message.
There are 2 main risks with this:

The early processing of all IEs in the AMF, and missing check against the replayed message, could potentially enable some man-in-the-middle attack at the radio interface, where some cellular capabilities of a targeted subscriber are downgraded by the attacker.
Processing all IEs, before subscriber's authentication has happened, may expose the AMF more than needed ; e.g. I could reach many assertions, and a memory corruption in the AMF demon, with malformed IEs in initial NAS messages.

To Reproduce
No easy way to reproduce with available open-source tools. A modification of a gNB / UE emulator can be done to send the entire initial NAS message in clear-text, and not replaying it (or replaying with a different message) in the Security Mode Complete message.
Expected behavior
I believe only "clear-text" IEs from the initial NAS message should be processed in the first place, then other IEs should be processed from the replayed message in the Security Mode Complete which is security protected. In case this replayed message is not provided, I believe the NAS connection should be dropped.
Environment (please complete the following information):

free5GC Version: v3.0.5
OS: Ubuntu 20.04
Kernel version: 5.4.0-62-generic
go version: go1.14.4 linux/amd64

Trace File
Configuration File
No specific configuration required.
PCAP File
A pcap is provided, where the complete initial NAS message is in clear text, and is not replayed in the Security Mode Complete message. The AMF does not issue any specific logging related to this issue, it processes all IEs from the initial NAS message.
free5gc_nas-init-nosec.pcap.gz
Log File
No specific log exists for this issue.

Hello @p1-bmu ,the current version of free5GC is upgraded to 3.3.0. Please try again to see if the same bug will appear when using free5GC version 3.3.0, thank you.
Link: https://github.com/free5gc/free5gc


New demo and bug fix

demo3.sh generates a full-page screenshot of a website. Also removed the >/dev/null from exec_script so that the response data can be used in scripts (useful in demo3.sh)

@644
thanks pull request!!
I’ll check this week!

@644
demo3.sh looks good!
And thanks fix exec_script! 👍 👍 👍


set third dimension size

Currently the geometry in third dimension is implicitly of length 1 in model units of length.
It would be nice to allow the user to set it to some other value, especially when the total compartment volume is relevant, e.g. when importing an ODE model with inter-compartment reactions (thanks @baronvonderheyden)
Need to work out what the implications are of changing this, for model/sbml/GUI/simulation.
Ideally would also offer to rescale parameters in the model automatically when changing this length such that current model behaviour is preserved.

for a PDE model, changing this doesn't actually change anything observable (in terms of species concenrtrations) in the model

the PDE (in terms of concentrations) does not depend on the depth
we are simulating a 2d slice of a 3d model assuming no variation in the z-direction

what it does change is the area of the membranes / volume of compartments, & hence the total species amount in the compartments

typically not relevant for compartment reactions when importing an ODE model

if they are in the initial form of COMPARTMENT_VOLUME * dc/dt (this is what COPASI provides)
since we symbolically divide by this volume factor, its actual value doesn't affect the imported reaction rate in terms of concentrations

but very relevant when importing an ODE with membrane reactions

they are divided by the membrane area, which does depend on the depth
if the ODE was constructed with realistic volumes, the depth should match the one in the ODE to roughly reproduce the dynamics on import

to represent this properly in SBML, I guess we need to write 3d models instead of 2d models? (with XxYx1 sampled field? with 2d mesh?)


🐛 BUG: Functions Routing returns 404

What version of Wrangler are you using?
latest
What operating system are you using?
mac
Describe the Bug
Hello,
There is no way to report CF bug on a free plan. Just want to let you know, that a few hours back Functions Routing (https://developers.cloudflare.com/pages/platform/functions/#functions-routing) stopped working and routed functions now returns 404 HTTP code. I believe this is a critical bug on CF side, because the last time I deployed my personal project was a week ago. Since then everything was working fine till today.

Deployed routes:
{
  "routes": {
    "GET /ping": {
      "module": [
        "ping.js:onRequestGet"
      ]
    },
    "POST /collect": {
      "module": [
        "collect.js:onRequestPost"
      ]
    },
    "POST /perf": {
      "module": [
        "perf.js:onRequestPost"
      ]
    }
  },
  "baseURL": "/"
}

404 page (defined in public/404.html) is returned when going to /ping.

I just successfully deployed Functions on a project of mine, and the routing seems to be working as expected. Can you please provide example reproduction steps for this?

Interesting. Could you please tell me what happens when "Functions requests today" (known limitation of 100k/daily) limit is reached? Is 404 status code returned for function routes?

Ah, yes, Functions be disabled until midnight UTC (when your daily limits reset). The static assets of your project will continue to be served as normal.

Ah, yes, Functions be disabled until midnight UTC (when your daily limits reset). The static assets of your project will continue to be served as normal.

Okay let's see if that's the issue. It is interesting that the "Functions requests today" counter in the dashboard stuck at 79,109 / 100,000.

@GregBrimble okay, so after the limits reset everything works fine again. Anyways, could anyone create a ticket internally for this? 429 HTTP status code should be returned instead of 404. Super confusing, this could save me hours...
Moreover, "Functions requests today" counter in the dashboard is not working properly in this case.


Unable to fly on Orion

I am a moderator and can only fly on atlas IGN: DraconiacLatias

Closing the issue, if it has not been resolved feel free to re-open the issue.


Support release image on modern docker, upgrade guest distro to 22.04

The first commit fixes #24. It is not clear if #18 is still relevant, but it seems like passing --init is simpler to guarantee our docker-init.
The second commit brings the guest distro to ubuntu 22.04 (Linux 5.15.0-87-generic as of this PR).

Thanks for the PR.
The first commit looks good to me.
I think we don't have to support overriding DOCKER_INIT if we instead search for docker-init in $PATH.
Your changes and this should make it work with old and new Docker:

in initrd/Makefile: remove all references to docker-init
in initrd/mkinitrd.sh: cp $(command -v docker-init) $TMP_DIR/sbin/

Regarding Ubuntu 22.04
Is there a special reason for switching to 22.04? Keep in mind that we must also support s390x.
I would prefer to stay on 20.04 for now unless there is a good reason to switch.
But we could put an additional Dockerfile.2204 in qemu/x86_64/ together with your change in qemu_amd64.go for people who want to try out 22.04.

So the issue with searching $PATH for docker-init is that modern installs put it at /usr/libexec/docker/docker-init, which is not in $PATH. We can of course search $PATH:/usr/libexec/docker.
It's not clear to me what the downsides are of --init, but I'm happy to switch the PR to either strategy, just let me know which you prefer and I'll update the PR.

As for Ubuntu 22.04, there isn't a specific reason other than getting a newer kernel (I need some newer features). The s390x part of this project is irrelevant to me, but I understand the concern for maintaining support for it. Another option here (though maybe too-clever) would be to parameterize FROM ubuntu:20.04, e.g.:
ARG UBUNTU_VERSION=20.04
FROM ubuntu:$UBUNTU_VERSION

The we have the Makefile pass through an optional --build-arg UBUNTU_VERSION=22.04.
However, the downside, and where we'll introduce some more complexity is that we'll need some system for constructing kernel.conf dependent on our kernel version. For example, in our ubuntu:22.04 version, we needed to add netfs.ko. If you know what are core requirements are, we can dynamically construct this dependency list using lib/modules/*/modules.dep. Or probably, even better, change the logic of init to remove loadKernelModules/kernel.conf and instead use logic more similar in modprobe.go to automatically resolve these dependencies at runtime (probably a tiny performance hit in parsing modules.dep at runtime).
Alternatively, we can add a Dockerfile.2204 and have the Makefile take care of that optionally. However, there may be interest in 24.04 next year 😉.
Again, let me know what strategy you prefer, and I'd be happy to update the PR.

I'm sorry for the confusing regarding the PATH. In all my systems the mount path is always /sbin/docker-init. So your commit is ok. But we could consider removing the check in initrd/Makefile. With your changes it's no longer needed.
So please create a PR with your first commit.

If /sbin/docker-init does not exist we could simple try to copy from /usr/libexec/docker/docker-init to support "modern installs". You can add this to your PR if you like.

Regarding 22.04 I would prefer a second Dockerfile. If we integrate a second distro/version then we must always test and support it. The base kernel modules are copied into the initrd. Therefore we  need the kernel.conf. I think we should make it possible to use 22.04+ but I don't want to switch now nor support two versions. There are other things waiting to be fixed, e.g. removing 'pkg/errors'. A 2nd. PR with a Dockerfile.2022 and maybe some instructions in the readme on how to use it is very welcome.

Thanks @ConnorNelson
See branch ubuntu2204.


context.res is unfamiliar - this should look like a http/connect/express response object

Most node developers will be most familiar with the http/connect/express style of response object, e.g. res.status(200).send({ }), rather than an unfamiliar, proprietary API.

Yeah, this has been a TODO. Basically we have the minimum in place required, but our whole .NET/Node interop layer will be improving. There should be some existing issues for that.

RC Justification: Given that this is likely a breaking change and is related to the consistency work, we should consider this.

@christopheranderson @danderson00 @mathewc
My proposal:
Bring in express as a dependency and provide a express.response object in node.  Replace response.end with a function that maps the express.response object to our existing res object & executes context.done.
A few benefits:

we don't need to worry about keeping our shim up to date with the express api
can simply point at the express docs
don't break existing functions which attach { status: ..., body: ....}

If we go this route, however, is there a point to route back to our http trigger?  Not sure what extra steps occur in the pipeline & if they are necessary, we could just send the response back from node code.

Note that this issue applies to both req and res. Whatever improvements we make should factor in both.
Yes, that is an option. Thus far I've tried to minimize such inbuilt dependencies, but this would really be no different than our built in .NET package dependencies in the case of C# + HttpRequestMessage.
The question is whether the Express response object would expose APIs that won't work correctly in Functions or will cause issues. Also, we need to investigate the details of what the mapping code in your "end" replacement would look like.

@mamaso Have you done more work on this?  If not, we're considering moving to backlog.

I'd like to get this work done along with all the other http improvements we've made.

@mathewc I've made a small connect adaptor for Azure Function and its working like a charm. I'm now able to use express and all middlewares that every node.js developer knows.
I'm using it like that :
const app = express();
app.use(whatever);

const handler = new ConnectHandler();
handler.addRequestListener(app);

export default function handle(context) {
  handler.handleAzureRequest(context);
}

I should maybe consider making an open source project with that.. 😄

@yvele Interesting.
I'm not seeing where your function logic is in the above example. It looks like you just call directly into handler.handleAzureRequest? Also, using this model, you'd be instantiating a new express app per function? Not sure if there are any negative implications to that. Express apps and middleware chains are generally created once on application startup.

@lindydonna Haven't done any work, vaca + wanted more feedback / proposals.
@yvele interested to see this adapter of yours.  Also @mathewc I think that this will function as one express app thanks to require caching.

@mamaso @mathewc I've made an open source project from my Azure Function to Express adapter https://github.com/yvele/azure-function-express It may have some limitations (multipart upload)s but work with a basic usage (routing, basic middlewares, etc.)


Add fleetctl config and auth commands

$ fleetctl config set address https://localhost:8080
[+] Set the "address" config key to "https://localhost:8080" in the "default" context

$ fleetctl config set ignore_tls true
[+] Set the "ignore_tls" config key to "true" in the "default" context

$ fleetctl setup --email<EMAIL_ADDRESS>--password "abc123"
[+] Fleet setup successful and context configured!

$ cat ~/.fleet/config
contexts:
  default:
    address: https://localhost:8080
    email<EMAIL_ADDRESS>    ignore_tls: true
    token: eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzZXNzaW9uX2tleSI6IlUvdm05Vk9wSG0xUlA4SUtjQnBhb2ovWlo1TXppSEVXcFRCNFNPb2tHQnNLUFpDQXFieVpWWnpJb0UvczQzcWkyd1pHZXJOa29SNFVIQ2hNZUc0K09RPT0ifQ.rHawSN8JvD4jjWAPTYX2Ep9ZpMt3u4mSIQcu920C-_s

$ fleetctl logout
[+] Fleet logout successful and local token cleared!

$ cat ~/.fleet/config
contexts:
  default:
    address: https://localhost:8080
    email<EMAIL_ADDRESS>    ignore_tls: true
    token: ""

I think Do should return a *http.Response, but I'm not opposed to extracting some shared helpers that accept a *http.Response for consistent JSON parsing.


DOMException thrown that "Blocked a frame from accessing a cross-origin frame"

Are you requesting a feature or reporting a bug?
A bug
What is the current behavior?
Sign-in page hanged and there is an exception thrown in console.
What is the expected behavior?
Sign-in successfully.
How would you reproduce the current behavior (if this is a bug)?
Just force sign-in case.
Provide the test code and the tested page URL (if applicable)
Tested page URL:
http://alpha-www.gdfcx.net/
Test code
File1 ----- logindata.js:
import { Selector } from 'testcafe';
var usname = "18621504828";
var pwd = "123456";
var logina = Selector('li[class="no-login"]');
var loginpage = Selector('iframe[id="login-iframe"]');
var usernameInput = Selector('input[placeholder="手机/邮箱/用户名"]');
var pwdInput = Selector('input[placeholder="密码"]');
var loginBtn = Selector('a[class="sso-submit"]');
exports.usname = usname;
exports.pwd = pwd;
exports.logina = logina;
exports.loginpage = loginpage;
exports.usernameInput = usernameInput;
exports.pwdInput = pwdInput;
exports.loginBtn = loginBtn;
File2 ---- login.js:
import { t  } from 'testcafe';
var logindata = require('../data/logindata.js');
export default class LoginCSS {
constructor () {
this.logina = logindata.logina;
this.loginpage = logindata.loginpage;
this.usernameInput = logindata.usernameInput;
this.pwdInput  = logindata.pwdInput;
this.loginBtn  = logindata.loginBtn;
this.loginLink = logindata.loginLink;
}
async login () {
    await t
	.maximizeWindow()
	.wait(5000)
	.click(this.logina)
	.wait(2000)
	.switchToIframe(this.loginpage)
	.wait(2000)
	.typeText(this.usernameInput,logindata.usname)
	.wait(2000)
	.typeText(this.pwdInput, logindata.pwd)
	.wait(2000)
	.click(this.loginBtn)
	.wait(2000)
	.switchToMainWindow()
	.wait(2000)
}

}
Specify your

operating system: Win7
testcafe version: 0.17.0-alpha1
node.js version:v6.11.0

I think it is similar with issue#1580, could you please have a check. Greatly appreciated!

Hi @hang-ren,
Unfortunatly, I cann't reproduces this issue. See video https://www.screencast.com/t/kZDwK56U

@LavrovArtem，
So weird.
I saw you use "https" to access the link from the video, right? But in my code it is "http", could you help to double check the difference? From my side, I can sign-in successfully both with "https" and "http" manually.
Thanks a lot!
BRs,
Hang

Hi @hang-ren,
I use http link, but it immediately redirect to https via 301 status code and the location header.

Also please try to run your test in incognito mode in Chrome via command below:
testcafe "chrome --incognito" test-name.js
It excludes the possibility of the plugins affecting on the page.

Thanks @LavrovArtem , I had tried it as your mentioned but still met the same issue.
I think I need research my website firstly, maybe it is a bug from my website.
Thanks for your suggestion all the same. And please close this issue.

Thank you for your time. Please let me know if you find the cause of this behavior.


Using $refresh in a function?

Is it possible to use $refresh to force a component to update?
I have this function in one component:
selected: function(item) {
    return this.$store.stats.includes(item.value)
}

which is used by:
<template x-for="(item, index) in items" :key="index">
    <div :class="{ 'font-medium bg-primary': selected(item)  }">...</div>
</template>

It basically checks if that item's value is in the Spruce store array of stats.
The value of this.$store.stats gets changed after this is called (I can't change the loading order either) but this function doesn't then seem to reflect this change.
I appreciate that I'm probably pushing Alpine to/past the limit, it's on a project that started off quite simple and keeps evolving, and a rewrite into something like Vue isn't feasible.
Any help would be really appreciated!

Refresh should work as expected. Was it not doing anything? I'm not sure how it will work with Spruce though. If you have an example of something not working I can try to debug why.

Thanks @KevinBatdorf - what would the syntax be this.$refresh?
Are $parent.$refresh() or $component('foo').$refresh() options?

Yea sure, thanks - I know my way around Alpine, just new to magic helpers! Cheers


Search sites by physical address in sites page

User Story
As Nelly the network engineer,
I want to be able to search sites in sites page by physical address in free form and supporting regex i.e. anything from that text field,
So that I can get faster responses than using generic search over all fields (top right corner)
I will know this is done:

when I see a Physical Address input form on https://nautobot.abcdcom/dcim/sites/
when that search supports regexp

Pertains To (Optional)

[ ] Automation
[ ] Circuits
[ ] DCIM
[ ] IPAM
[ ] Misc (including Data Sources)
[x] Organization
[ ] Plugins (and other Extensibility)
[ ] Security (Secrets, etc)
[ ] Image Management
[x] UI/UX
[ ] Documentation
[ ] Other (not directly a platform feature)

Database Changes (Optional)

?

External Dependencies (Optional)

?

Thanks for the request! The requirement for regex searching relates to #1400.

Might be related to #1052

While Sites no longer exist in 2.0, searching by multiple fields, including via Regex or contains, was introduced via several features: Dynamic Filter Form, Regex Filtering.
Demo: https://next.demo.nautobot.com/dcim/locations/?physical_address__ic=6301 Silver


Find replacement for https://github.com/pkg/errors

https://github.com/pkg/errors is now archived since errors package has a way to wrap errors AND the main maintainer is stepping down from the maintainer team. Here are details https://github.com/pkg/errors/issues/245
Unfortunately, default library errors wrapping is not the best. Personally, I don't like three facts:

It requires doing fmt.Errors("something: %w", err) with %w which is ultra-easy to forgot and do %v instead. There are linters for that, but add extra lint when our language is compiled... feels weird. Plus it is prone to inconsistent wrapping.
Doing errors.New sometimes then relying on fmt to wrap errors does not look clean. Swapping between fmt and errors in return looks like unnecessary complexity for the reader.
There is no stack trace functionality which we use heavily https://github.com/thanos-io/thanos/blob/main/cmd/thanos/main.go#L131

Options:
A. We could write our own wrapper over errors to accomplish this, borrowing some code from pkg/errors, but it is (especially stack tracing) a bit of complexity to the maintainer.
B. We could use other drop-in replacements https://github.com/emperror/errors - it was not touched lately but seems like not many issues are on it. The API is a bit large though.
C. We could live without stack trace functionality. This is what the majority of projects are doing lately.
I am not a fan of standard library flow as mentioned before, and I don't think we mind setting a new standards in the ecosystem (e.g with https://github.com/efficientgo/tools/tree/main/core). But for time being, maybe it makes sense to start with B and check how it goes first? 🤔
Thoughts?

I personally could live with your two first points; having stack trace functionality is nice. Option B would make most sense, at least for the time being, to me.

Hi @bwplotka & @matej-g, Can I work on this?

A. We could write our own wrapper over errors to accomplish this, borrowing some code

If you wish to go with this approach, I have a better option. Recently, I have worked with a package
stacktrace:-> https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/platform/tast/src/chromiumos/tast/errors/stack/stack.go
errors -> https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/platform/tast/src/chromiumos/tast/errors/errors.go
It's very small (hardly 200 lines total) yet very elegant code (supports both wrapping and unwrapping). I think we can borrow it. What do you think? I'd be happy to the replacement. Thank you.

Hey @bisakhmondal, thanks for your interest! Do you have any opinion on which solution to go with?
Let's see if @bwplotka has any further opinion which route to take as well, would be cool if you'd take it! :rocket:

Awesome! I'd say if you found a good replacement, the code is not too complex and you have a good idea of how we can leverage it in Thanos repository, go for it :rocket:

Looking at so many references to this issue the PR, how about we publish it as a separate go pkg. Lots of redundant work might be saved.
What do you think guys?


SteamVR_Behaviour_Skeleton glitches

I'm having an issue with (what I assume is) the smoothed transform of the hand skeleton. I'm working on a non-euclidean title and we're using portals to teleport the player instead of using the default teleportation. For this I need to detach the hands from the player in order for the hands to teleport freely from the player. But it seems that the transform of the hand skeleton depends on buffered input. This makes a lot of sense to me as the raw input would probably be jittery, but when I teleport there is a huge change in velocity making the hands jitter for a few frames Example. I also have an image of this convergence in action Log.
So my question is. Is there any way to either clear this buffered input so avoid this or is there another way that I should solve this issue? I also made a post on the Unity forums asking for help with this.

I managed to fix the jittering by setting the velocity and angular velocity of the rigidbody in the hand collider to zero when calling the teleport function in the hand collider.


Correct #2342 - "added requirements to dependencies build README"

Reverts #2342 and adds the actual requirements.
This inadvertently causes a policy change instead of adding the requirements to building with the tested set of dependencies, see post-merge discussion in said PR.

Note: Once contrib/gitian-descriptors/* has been upgraded to use a more recent Ubuntu (which I still target for 1.14.4), we can rework the prerequisites to reflect these (and make sure that CI and Gitian are using the same platforms.)


Cinema

What type of change does this PR introduce?

[ ] Bugfix
[X ] Feature
[ ] Refactor
[ ] Documentation
[ ] Not Sure?

Does this PR introduce breaking changes?

[ ] Yes
[X ] No

List any relevant issue numbers:
#107
Description:
This package will be more important than just this little module.
It's actually works :)
Actual features :

Recommend movie with an note <5 stars on themoviedb.org

Future features :

Great logo with leon color's
Give movies in cinema actually and in future
Give information about movies
Give information about actors/actress/realisator etc...
Recommend an serie
Recommend series and movies who match with your interest

API use :
db : www.themoviedb.org
with wrapper : https://github.com/celiao/tmdbsimple

v 1.0.0 is out
Tests, readme and features are now useable


add automatic pep8 test in travis

It's very useful and easy to modify travis.yml。

FWIW I'm developing a tool named coala which let's you use linters and write your own rules. It allows you to put in a very small config file, e.g.:
[python]
files = **/*.py
ignore = docs/**
bears = PEP8Bear, PyImportSortBear, PyUnusedCodeBear, PyLintBear
use_spaces = True
# The following yield false positives in PyLint, e.g. it doesn't understand some
# of the Flask magic.
pylint_disable = R0903, C0103, E1101

What's special about this is that you get one executable for all your code analytics (you could add a section for checking your RST files e.g. easily), you can use it in Gedit, Sublime, Atom or from the command line (JSON, interactive, custom format) and, most importantly, it can automatically apply fixes (we use autopep8, isort and autoflake for PEP8Bear, PyImportSortBear and PyUnusedCodeBear) so your initial time to get your code clean should be far shorter. Config is also less redundant because if you specify line_length in coala all Bears will pick that up (otherwise it's a bug ;)) so you don't have to specify it again for each tool.
(Bonus: if you want specific "rules" for your project you can easily write your own bears that reside in your repository. Want to check your commit messages? :)
Bonus 2: you get one unified way to mark issues in certain lines/ranges as false positives.
Bonus 3: we're working on a service that provides you PR comments but it's very alpha. But one day it will be ready.)
Of course coala is open source. coala-analyzer.org provides more info - or me.

continued in #1702


pointing the url to the repo in the preactjs org

Just shifted this repo to the official org, updating the link here

Good catch, thanks Prateek!


feat: Change model format to split on ' ' instead of '/'

Description
As a developer, I would like to type my model format like -> 'String myString' instead of 'String/myString'.
Desired Solution
Instead of splitting at '/' we would need to split at ' '.
Additional Context
Very easy change :)

Fixed and in version 0.3.7 of model brick: https://brickhub.dev/bricks/model/0.3.7 🎉


Merge develop -> master

There isn't really and difference yet- this just puts master on a better baseline

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2

See the complete overview on Codacy


replace doLast with dependsOn

in all our gradle scripts wherever possible.
https://stackoverflow.com/questions/17438219/better-to-use-task-dependencies-or-task-dolast-in-gradle

I didn't find in our project places where we are using "Alternative A" which I understand can cause problems.  We create separate task for new activities (I'm talking about Alternative B) and I think we are doing it in correct way.
Additionally we don't  use shortcut for 'doLast' method what is recommended by doc https://docs.gradle.org/3.3/userguide/tutorial_using_tasks.html#sec:a_shortcut_task_definition
If I do not understand the problem or I missed something please provide more details

I've looked through the gradle files. And it looks OK now. Probably task dependencies were fixed in last update.
The idea is that you should never call one task from another directly (using doLast notation), instead us task dependencies. Also it is good idea to atomize any actions which do make any changes to files since some building blocks could be executed separately.
The only problematic place I see for now is this one:
task staticContent(dependsOn: build) {
  doLast {
    cleanBeakerxStatic(kernelIdName)
    copyLibsToBeakerxStatic(kernelIdName, configurations, jar)
    saveBeakerxStaticKernelJson(kernelIdName, "$mainClassName", mainClassToReplace)
  }
}

It is better to create a separate tasks for each of given actions (clean. copy and generate meta) in each kernel and use them. No need to copy functions in each kernel, you can just do something like this:
subprojects{ kernel ->
  task cleanStatic{
    cleanBeakerxStatic(kernel.name)
  }
}

thx for the review altavir.


Added Trailhead badge in readme

Added Trailhead badge in readme:

Codecov Report

Merging #39 (b0f2143) into master (7a9a4f0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   96.06%   96.06%
=======================================
  Files          36       36
  Lines        1244     1244
=======================================
  Hits         1195     1195
  Misses         49       49

Flag
Coverage Δ

Apex
96.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a9a4f0...b0f2143. Read the comment docs.


yWorks merge

Still not all functions added, but on the half way ;)

the second(!) Matrix.prototype.toString  for the first commit looks broken - probably a copy paste error - should be inverse not toString()


fix: fixed image overflow in message attachments

Summary

Fixed the overflow if a message attachment is wider than the Viewport. (https://developers.mattermost.com/integrate/reference/message-attachments/#images)
This is done by modifying the getViewPortWidth and introducing a new VIEWPORT_IMAGE_ATTACHMENT_OFFSET.
The value of it is calculated with the padding of the MessageAttachment component (2 * 12) + the padding of the AttachmentImage component (2,5 + 5) => 31,5
https://github.com/mattermost/mattermost-mobile/blob/9b450cf68b60b47ebcb4ca84af9cc07293397567/app/components/post_list/post/body/content/message_attachments/message_attachment.tsx#L42
https://github.com/mattermost/mattermost-mobile/blob/9b450cf68b60b47ebcb4ca84af9cc07293397567/app/components/post_list/post/body/content/message_attachments/attachment_image/index.tsx#L26-L28
Ticket Link

None
Checklist

[ ] Added or updated unit tests (required for all new features)
[X] Has UI changes
[ ] Includes text changes and localization file updates
[ ] Have tested against the 5 core themes to ensure consistency between them.
[ ] Have run E2E tests by adding label E2E iOS tests for PR.

Device Information
This PR was tested on:

Samsung Galaxy S22, Android 14

Screenshots

Example Attachment
"attachments": [
        {
            "fallback": "test",
            "color": "#FF8000",
            "image_url": "https://raw.githubusercontent.com/mattermost/mattermost/refs/heads/master/server/tests/orientation_test_1.jpeg"
        }
    ]

Before
After

Release Note

Fixed image overflow when using message attachments.

Hello @fxnm,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Please review, this is a high priority for one of our paying customers

@larkox I was away on PTO, and still catching up to all PRs.  Let me get right on this.

@yasserfaraazkhan I assume you had tested this locally based on this.
@amyblais can we still include this in v2.23?  We had code-freeze last Monday.

Yes Rahim, tested it locally


device->platform showing non object property.

I want to access my client device name using antonioribeiro/tracker.
But while i dd() the out put it's showing 'Non Object Property'
public function postUser(Request $request)
   {
   	$user=new User();
   	$user->name= $request->Input(['name']);
   	$user->email=$request->Input(['email']);
   	$user = Tracker::currentSession();
   	dd($user->device->platform) ;
   	//dd( $user->device->is_mobile);

   	$user->save();
   	return redirect('userPage');
   }

As long as you are logging devices, it works.


Don't require permission to access <all_urls>

It's totally possible to make this extension respond to a command or user action rather than request permission to all_urls. This is an unnessecary permission, only activeTab is needed.

<all_urls> is not in the permissions list though, it's just a match pattern for the content scripts, so that they are injected in any URL. Theoretically I could manually inject the scripts and styles one by one when the user changes the active tab, but this would slow the users down, besides AFAIK it's best practices to use content scripts for any script that should be persistent in any website.

<all_urls> is not in the permissions list though, it's just a match pattern for the content scripts, so that they are injected in any URL. Theoretically I could manually inject the scripts and styles one by one when the user changes the active tab, but this would slow the users down, besides AFAIK it's best practices to use content scripts for any script that should be persistent in any website.

You could remove the content scripts entirely then use scripting.executeScript to run the content script. Because you would inject on keyboard shortcut or extension icon click, you'd only need activeTab. This would only require minor changes to the content scripts themselves, so that when injected they automatically open the popup instead of listening for a keyboard shortcut.

Also it's not a question, it's a suggestion

Yeah but if I did that it wouldn't be as responsive (having to load the whole thing every time), plus I feel like content scripts are just expected of Chrome Extensions anyway. I do use the executeScript method on install (since content scripts don't automatically get added on existing tabs), and I did try doing it "on demand" (by checking if the tab had the extension injected or not), it just took longer.

Yeah but if I did that it wouldn't be as responsive (having to load the whole thing every time), plus I feel like content scripts are just expected of Chrome Extensions anyway. I do use the executeScript method on install (since content scripts don't automatically get added on existing tabs), and I did try doing it "on demand" (by checking if the tab had the extension injected or not), it just took longer.

First, what did you inject? Also it could be faster if you used some web accessible resources
It's already slow, that's a whole separate issue, it wouldn't need to load much, loading in a content script takes a matter of milliseconds, if you're saying that querying tabs and bookmarks would take a long time you can simply poll in background then when the user presses a keyboard shortcut return the cached, then get a fresh copy and update UI. To my knowledge you are querying everything when the shortcut is pressed, so this wouldn't make much of a difference in time.
That way the data flow would look like this:

Background page polling and getting bookmarks, history, actions, etc, every ~2 seconds
User presses keyboard shortcut
Content script injected
Content script asks for data from bg script, then waits for response (this would be cached data, accurate as of <2 seconds)
Search 🎉

Also, I'm not sure if you're already doing this or not, but a massive performance improvement would be to do the searching in the background, that way you can also show a loading animation in the page and not slow down the main page

plus I feel like content scripts are just expected of Chrome Extensions anyway.
Seeing a "this extension can access the contents of all pages you visit, your browsing history,  and your bookmarks" makes me hesitate to install, and I'm sure many other users, which may be part of why this repo has +400 stars, but your extension only has 66 users:

I can look into it again, if it can remove a permission and still perform as well that's definitely worth it for sure. I'll be working on optimizations anyway to make it work faster so it could definitely work.
In terms of stats btw, they aren't updating, it always takes a few days to show the actual user count. From the dashboard I can see there's over 1000 installs, so I don't know if this permission is really causing users to hesitate.
That said it is true that some permissions really do put people off. Like I've had concerns especially regarding the "history" permission for example. But maybe it's more a matter of messaging, with my Screenity extension I made it very clear that no data was being stored and I reassured users more.

I can look into it again, if it can remove a permission and still perform as well that's definitely worth it for sure. I'll be working on optimizations anyway to make it work faster so it could definitely work.

Also what do you think about using optional permissions, e.g. just require the tabs permission at first (by default tabs and actions), then if a user tries to use something else request an optional permission, also maybe some occasional toasts to nudge users in the right direction. If I'm installing an extension and it wants to read my browsing history, all urls, etc, that's sort of scary. But if I install it then when I turn on a feature it asks for a permission like that, I'll be much more likely to grant it.

In terms of stats btw, they aren't updating, it always takes a few days to show the actual user count. From the dashboard I can see there's over 1000 installs, so I don't know if this permission is really causing users to hesitate.

Oh, that's fair lol, happens to me too

That said it is true that some permissions really do put people off. Like I've had concerns especially regarding the "history" permission for example. But maybe it's more a matter of messaging, with my Screenity extension I made it very clear that no data was being stored and I reassured users more.

I think optional permissions are a huge plus here, that's pretty much what they're meant for, if you show a toast 1/3 random times if the user doesn't have history or bookmarks permissions granted yet, then a big enable button, chances are, they'll grant it.


Design Tokens: Border colors updates

Describe the bug
There is a discrepancy between Figma Border design tokens and the auro.alaskaair.com Border design tokens.
var(--auro-color-border-primary-on-light) & var(--auro-color-border-primary-on-dark) need updated to new hex values.
and 2 border-divider colors need added.
To Reproduce
Steps to reproduce the behavior:

View the breakdown of Figma border colors vs Auro border colors in this Figma file https://www.figma.com/file/ufoYH9MYNkD26P7ywVQ0fP/Debugging?node-id=15%3A1465

Expected behavior
Update 2 existing tokens:
var(--auro-color-border-primary-on-light) to #626B79
var(--auro-color-border-primary-on-dark) to #9FABBB
Add 2 new tokens:
var(--auro-color-border-divider-on-light) to rgba(0, 0, 0, 0.15)
var(--auro-color-border-divider-on-dark) to #FFFFFF
Screenshots

Desktop (please complete the following information):

OS mac
Browser chrome
Version [e.g. 22]

Additional context:
auro-input line color currently appears incorrect but is using the correct -primary-on-light token. Updating the tokens will give it the proper #626B79 line color.
The current primary-on-light color is too light and very much resembles the -disabled-on-light token which is undesirable. This color is better leveraged as a -border-divider only.
@audreychae97 @bridgetglewis


Frontend: Muted conversations

@keybase/react-hackers CC @mlsteele
Here's our conversation muting support.  New behavior:

If you run keybase chat mute someone, you'll see a shh next to their entry in the sidebar.  The conversation snippet will go away from the sidebar.  You won't get desktop notifications for new messages from them anymore.
If you run keybase chat mute -u someone, the reverse will be true.
If you open the sidebar (information icon) for your conversation, there's an "Mute notifications" checkbox that has the same effect as switching between mute and mute -u.

The commits 27afe20bcd07...8df80f165d65 introduce visual changes on linux. :mag_right: 3 changed

Changed: Menubar-Private_Async_Writing (before) (after)

Changed: Chat_Side_Panel-Normal (before) (after)

Changed: Chat_Side_Panel-Empty (before) (after)

@MarcoPolo Thanks, did both of those!

The commits 27afe20bcd07...36ed65b9eecc introduce visual changes on linux. :mag_right: 3 changed

Changed: unlock_folders-Success (before) (after)

Changed: Chat_Side_Panel-Normal (before) (after)

Changed: Chat_Side_Panel-Empty (before) (after)


Don't exit early after FUSE_FORGET of the root inode

Exiting early prevents the file system from ever receiving FUSE_DESTROY.
Plus, FUSE_FORGET for the root inode can happen for at least two reasons
other than an impending unmount:

An unmount attempt that fails with EBUSY
Extreme vnode pressure, theoretically

LGTM😀