add articles/service-fabric/service-fabric-cluster-creation-setup-aad-via-portal.md for portal step by step Azure AD configuration for service fabric

add articles/service-fabric/service-fabric-cluster-creation-setup-aad-via-portal.md for portal step by step Azure AD configuration for service fabric.
steps are related to automatic steps documented here: articles/service-fabric/service-fabric-cluster-creation-setup-aad.md

Docs Build status updates of commit a1c9550:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/service-fabric/service-fabric-cluster-creation-setup-aad-via-portal.md
:warning:Warning

Details

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-app-registration.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-app-registration-client-properties.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-api-cluster-add.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-api-delegated.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-api-grant.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-api-grant-confirm.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-app-registration.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-authentication.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-aad-add.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-aad-settings.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-app-registration.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-authentication.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-branding.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-expose-applicationid.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-expose-scope.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-roles.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-roles-admin.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-roles-readonly.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-add-assignment.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-add-user.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-admin-role.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-filter.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-no-filter.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-readonly-role.png
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.

articles/service-fabric/service-fabric-cluster-creation-setup-aad-via-portal.md

Line 38, Column 1: [Warning: alt-text-bad-value - See documentation] Alt text 'portal-app-registration' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 52, Column 1: [Warning: alt-text-bad-value - See documentation] Alt text 'portal-cluster-app-registration' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 59, Column 1: [Warning: alt-text-bad-value - See documentation] Alt text 'portal-cluster-branding' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 65, Column 1: [Warning: alt-text-bad-value - See documentation] Alt text 'portal-cluster-authentication' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 77, Column 1: [Warning: alt-text-bad-value - See documentation] Alt text 'portal-cluster-expose-applicationid' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 98, Column 1: [Warning: alt-text-bad-value - See documentation] Alt text 'portal-cluster-expose-scope' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 104, Column 1: [Warning: alt-text-bad-value - See documentation] Alt text 'portal-cluster-roles' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 112, Column 1: [Warning: alt-text-bad-value - See documentation] Alt text 'portal-cluster-roles-admin' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 120, Column 1: [Warning: alt-text-bad-value - See documentation] Alt text 'portal-cluster-roles-readonly' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 130, Column 1: [Warning: alt-text-bad-value - See documentation] Alt text 'portal-app-registration' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 138, Column 3: [Warning: alt-text-bad-value - See documentation] Alt text 'portal-client-app-registration' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 144, Column 3: [Warning: alt-text-bad-value - See documentation] Alt text 'portal-client-authentication' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 154, Column 1: [Warning: alt-text-bad-value - See documentation] Alt text 'portal-client-api-delegated' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 158, Column 1: [Warning: alt-text-bad-value - See documentation] Alt text 'portal-client-api-grant' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 160, Column 1: [Warning: alt-text-bad-value - See documentation] Alt text 'portal-client-api-grant-confirm' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 167, Column 1: [Warning: alt-text-bad-value - See documentation] Alt text 'portal-app-registration-client-properties' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 183, Column 4: [Warning: alt-text-bad-value - See documentation] Alt text 'portal-enterprise-apps-filter' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 187, Column 4: [Warning: alt-text-bad-value - See documentation] Alt text 'portal-enterprise-apps-no-filter' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 194, Column 1: [Warning: alt-text-bad-value - See documentation] Alt text 'portal-enterprise-apps-add-user' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 198, Column 1: [Warning: alt-text-bad-value - See documentation] Alt text 'portal-enterprise-apps-add-assignment' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 204, Column 1: [Warning: alt-text-bad-value - See documentation] Alt text 'portal-enterprise-apps-readonly-role' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 210, Column 1: [Warning: alt-text-bad-value - See documentation] Alt text 'portal-enterprise-apps-admin-role' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 231, Column 1: [Warning: alt-text-bad-value - See documentation] Alt text 'portal-managed-cluster-aad' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 238, Column 1: [Warning: alt-text-bad-value - See documentation] Alt text 'portal-cluster-aad-add' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.
Line 247, Column 1: [Warning: alt-text-bad-value - See documentation] Alt text 'portal-cluster-aad-settings' is the same as the image file name. This redundancy adds no value for users of screen readers. For accessibility, add more descriptive alt text.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit aab7bf7:
:bulb: Validation status: suggestions

File
Status
Preview URL
Details

articles/service-fabric/service-fabric-cluster-creation-setup-aad-via-portal.md
:bulb:Suggestion

Details

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-app-registration.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-app-registration-client-properties.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-api-cluster-add.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-api-delegated.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-api-grant.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-api-grant-confirm.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-app-registration.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-authentication.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-aad-add.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-aad-settings.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-app-registration.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-authentication.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-branding.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-expose-applicationid.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-expose-scope.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-roles.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-roles-admin.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-roles-readonly.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-add-assignment.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-add-user.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-admin-role.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-filter.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-no-filter.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-readonly-role.png
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.

articles/service-fabric/service-fabric-cluster-creation-setup-aad-via-portal.md

Line 71, Column 5: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/active-directory/develop/reference-breaking-changes#appid-uri-in-single-tenant-applications-will-require-use-of-default-scheme-or-verified-domains' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 47e3f63:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-app-registration.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-app-registration-client-properties.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-api-cluster-add.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-api-delegated.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-api-grant.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-api-grant-confirm.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-app-registration.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-authentication.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-aad-add.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-aad-settings.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-app-registration.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-authentication.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-branding.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-expose-applicationid.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-expose-scope.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-roles.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-roles-admin.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-roles-readonly.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-add-assignment.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-add-user.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-admin-role.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-filter.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-no-filter.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-readonly-role.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-user-assignments.png
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@sukanyamsft
Can you review the proposed changes? Note that the new article needs to be added to a TOC.
Also, these changes are extensive and should be made in the private repo instead. Should @jagilber get set up in the private repo?
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@Court72 Hi Courtney! I'm the maintainer for the Service Fabric docs. I don't know if Sukanya will check her mail on this.
Everything looks good on my side. You can merge this.

Docs Build status updates of commit d4401d6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-app-registration.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-app-registration-client-properties.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-api-cluster-add.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-api-delegated.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-api-grant.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-api-grant-confirm.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-app-registration.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-authentication.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-aad-add.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-aad-settings.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-app-registration.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-authentication.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-branding.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-expose-applicationid.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-expose-scope.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-roles.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-roles-admin.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-roles-readonly.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-add-assignment.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-add-user.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-admin-role.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-filter.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-no-filter.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-readonly-role.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-user-assignments.png
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit d6bb46a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-app-registration.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-app-registration-client-properties.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-api-cluster-add.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-api-delegated.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-api-grant.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-api-grant-confirm.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-app-registration.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-client-authentication.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-aad-add.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-aad-settings.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-app-registration.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-authentication.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-branding.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-expose-applicationid.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-expose-scope.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-roles.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-roles-admin.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-cluster-roles-readonly.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-add-assignment.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-add-user.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-admin-role.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-filter.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-no-filter.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-readonly-role.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/portal-enterprise-apps-user-assignments.png
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

#sign-off
cc: @tomvcassidy @sukanyamsft

@jborsecnik can you please merge?

hi @mamccrea @tomvcassidy - this pr contains a new article and a lot of new images. we can't merge it in the public repos.  I note that at a glance I can see some blocking issues, but likely can't see them all because we'll need Acrolinx, and staging to be able to do a full review.  Can you move it or would you like assistance?
Thanks.

@Jak-MS I might need some assistance with that. How do I go about doing that?

@tomvcassidy
No problem! The PR review team can move the commits. Before we do so, the content must be ready to publish, so the following issues need to be resolved first:
articles/service-fabric/media/service-fabric-cluster-creation-setup-aad-via-portal/*
articles/service-fabric/service-fabric-cluster-creation-setup-aad-via-portal.md
portal-cluster-aad-add.png
portal-cluster-aad-settings.png
portal-managed-cluster-aad.png

In these file and folder names, expand "aad" to "azure-ad" or "azure-active-directory"

portal-cluster-expose-applicationid.png

Separate all words with a hyphen in this file name: "applicationid" --> "application-id"

articles/service-fabric/service-fabric-cluster-creation-setup-aad-via-portal.md

Revise the alt text in this new article so that it's 40-150 characters, starts with a description of the image ("Screenshot of..." or "Diagram of..." Don't use "Image" of "Graphic." Screenreaders say this automatically.), and ends with a period.
Remove all horizontal lines --- (nonstandard formatting).

Let us know if you have any questions. Thanks!

Learn Build status updates of commit 952902d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-app-registration.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-app-registration-client-properties.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-client-api-cluster-add.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-client-api-delegated.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-client-api-grant.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-client-api-grant-confirm.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-client-app-registration.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-client-authentication.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-cluster-app-registration.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-cluster-authentication.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-cluster-azure-ad-add.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-cluster-azure-ad-settings.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-cluster-branding.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-cluster-expose-application-id.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-cluster-expose-scope.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-cluster-roles.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-cluster-roles-admin.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-cluster-roles-readonly.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-enterprise-apps-add-assignment.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-enterprise-apps-add-user.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-enterprise-apps-admin-role.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-enterprise-apps-filter.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-enterprise-apps-no-filter.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-enterprise-apps-readonly-role.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-enterprise-apps-user-assignments.png
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

hey @Court72 and @tomvcassidy i committed fixes for issues https://github.com/MicrosoftDocs/azure-docs/pull/98306#issuecomment-1259672739

Thanks, @jagilber. We'll start moving these commits into the private repo. We'll link the new PR when it's created.

The commits in this PR have been moved to the private repo: https://github.com/MicrosoftDocs/azure-docs-pr/pull/214123

Learn Build status updates of commit 3d4a762:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-app-registration.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-app-registration-client-properties.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-client-api-cluster-add.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-client-api-delegated.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-client-api-grant.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-client-api-grant-confirm.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-client-app-registration.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-client-authentication.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-cluster-app-registration.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-cluster-authentication.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-cluster-azure-ad-add.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-cluster-azure-ad-settings.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-cluster-branding.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-cluster-expose-application-id.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-cluster-expose-scope.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-cluster-roles.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-cluster-roles-admin.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-cluster-roles-readonly.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-enterprise-apps-add-assignment.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-enterprise-apps-add-user.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-enterprise-apps-admin-role.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-enterprise-apps-filter.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-enterprise-apps-no-filter.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-enterprise-apps-readonly-role.png
:white_check_mark:Succeeded

articles/service-fabric/media/service-fabric-cluster-creation-setup-azure-ad-via-portal/portal-enterprise-apps-user-assignments.png
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Nested questions behave strangely

Originally reported by @joiskash
Describe the bug

questionnaireResponseChangedCallback not called in drop-down after selecting an answer
Clear answer items if enableWhen condition is false. This happens when you select an answer, the conditional logic is true, and then you deselect. Not clearing the answer corrupts the questionnaire response. Because the questionnaire response will now have both answers,even though it should actually have the last edit.
enableWhen bug questionnaireResponseItem.answer.any instead of questionnaireResponseItem.contains
Handle nested items in answers for linkIdMapsQuestionnaireResponseMap

Component
SDC lib
To Reproduce
Use the following questionnaire in the gallery app.
Expected behavior
Behaves normally
Screenshots
If applicable, add screenshots to help explain your problem.
Smartphone (please complete the following information):

Device: Pixel4a

Additional context
questionnaire:
{
  "meta": {
    "profile": [
      "http://hl7.org/fhir/uv/sdc/StructureDefinition/sdc-questionnaire|2.7"
    ],
    "tag": [
      {
        "code": "lformsVersion: 29.0.3"
      }
    ]
  },
  "version": "1",
  "status": "draft",
  "experimental": true,
  "publisher": "IPRD",
  "name": "Malaria net distribution",
  "title": "Malaria Net Survey",
  "resourceType": "Questionnaire",
  "item": [
    {
      "type": "choice",
      "code": [
        {
          "code": "lga-codes",
          "display": "LGA",
          "system": "https://www.oyo.com/codes"
        }
      ],
      "extension": [
        {
          "url": "http://hl7.org/fhir/StructureDefinition/questionnaire-itemControl",
          "valueCodeableConcept": {
            "coding": [
              {
                "system": "http://hl7.org/fhir/questionnaire-item-control",
                "code": "drop-down",
                "display": "Drop down"
              }
            ],
            "text": "Drop down"
          }
        }
      ],
      "required": true,
      "linkId": "1",
      "text": "LGA",
      "answerOption": [
        {
          "valueCoding": {
            "code": "oluyole",
            "display": "OLUYOLE",
            "system": "https://www.oyo.com/codes/lga"
          }
        },
        {
          "valueCoding": {
            "code": "akinyele",
            "display": "AKINYELE",
            "system": "https://www.oyo.com/codes/lga"
          }
        }
      ],
      "item": [
        {
          "type": "choice",
          "code": [],
          "extension": [
            {
              "url": "http://hl7.org/fhir/StructureDefinition/questionnaire-itemControl",
              "valueCodeableConcept": {
                "coding": [
                  {
                    "system": "http://hl7.org/fhir/questionnaire-item-control",
                    "code": "drop-down",
                    "display": "Drop down"
                  }
                ],
                "text": "Drop down"
              }
            }
          ],
          "required": false,
          "linkId": "ward-akinyele",
          "text": "Ward",
          "enableWhen": [
            {
              "answerCoding": {
                "code": "akinyele",
                "system": "https://www.oyo.com/codes/lga"
              },
              "question": "1",
              "operator": "="
            }
          ],
          "answerOption": [
            {
              "valueCoding": {
                "code": "ikereku",
                "display": "Ikereku",
                "system": "https://www.oyo.com/codes/wards"
              }
            },
            {
              "valueCoding": {
                "code": "iroko",
                "display": "Iroko",
                "system": "https://www.oyo.com/codes/wards"
              }
            }
          ],
          "item": [
            {
              "type": "choice",
              "code": [
                {
                  "code": "ward-Iroko",
                  "display": "Net distribution",
                  "system": "https://www.oyo.com/codes"
                }
              ],
              "extension": [
                {
                  "url": "http://hl7.org/fhir/StructureDefinition/questionnaire-itemControl",
                  "valueCodeableConcept": {
                    "coding": [
                      {
                        "system": "http://hl7.org/fhir/questionnaire-item-control",
                        "code": "drop-down",
                        "display": "Drop down"
                      }
                    ],
                    "text": "Drop down"
                  }
                }
              ],
              "required": false,
              "linkId": "ward-Iroko",
              "text": "Net distribution",
              "enableWhen": [
                {
                  "answerCoding": {
                    "code": "iroko",
                    "system": "https://www.oyo.com/codes/wards"
                  },
                  "question": "ward-akinyele",
                  "operator": "="
                },
                {
                  "answerCoding": {
                    "code": "akinyele",
                    "system": "https://www.oyo.com/codes/lga"
                  },
                  "question": "1",
                  "operator": "="
                }
              ],
              "enableBehavior": "all",
              "answerOption": [
                {
                  "valueCoding": {
                    "code": "hla-primary-school",
                    "display": "HLA Primary School",
                    "system": "https://www.oyo.com/codes/distributionCenter"
                  }
                },
                {
                  "valueCoding": {
                    "code": "christ-apostolic-church",
                    "display": "Christ Apostolic Church",
                    "system": "https://www.oyo.com/codes/distributionCenter"
                  }
                }
              ]
            },
            {
              "type": "choice",
              "code": [
                {
                  "code": "ward-ikereku",
                  "display": "Net distribution",
                  "system": "https://www.oyo.com/codes"
                }
              ],
              "extension": [
                {
                  "url": "http://hl7.org/fhir/StructureDefinition/questionnaire-itemControl",
                  "valueCodeableConcept": {
                    "coding": [
                      {
                        "system": "http://hl7.org/fhir/questionnaire-item-control",
                        "code": "drop-down",
                        "display": "Drop down"
                      }
                    ],
                    "text": "Drop down"
                  }
                }
              ],
              "required": false,
              "linkId": "ward-ikereku",
              "text": "Net distribution",
              "enableWhen": [
                {
                  "answerCoding": {
                    "code": "ikereku",
                    "system": "https://www.oyo.com/codes/wards"
                  },
                  "question": "ward-akinyele",
                  "operator": "="
                }
              ],
              "answerOption": [
                {
                  "valueCoding": {
                    "code": "ogun-state-water-corporation",
                    "display": "Ogun state water corporation Arakanga",
                    "system": "https://www.oyo.com/codes/distributionCenter"
                  }
                },
                {
                  "valueCoding": {
                    "code": "iberekodo-central-mosque",
                    "display": "Iberekodo Central Mosque",
                    "system": "https://www.oyo.com/codes/distributionCenter"
                  }
                }
              ]
            }
          ]
        },
        {
          "type": "choice",
          "code": [
            {
              "code": "ward-oluyole",
              "display": "Ward oluyole",
              "system": "https://www.oyo.com/codes"
            },
            {
              "code": "ward-codes",
              "display": "Ward",
              "system": "https://www.oyo.com/codes"
            }
          ],
          "extension": [
            {
              "url": "http://hl7.org/fhir/StructureDefinition/questionnaire-itemControl",
              "valueCodeableConcept": {
                "coding": [
                  {
                    "system": "http://hl7.org/fhir/questionnaire-item-control",
                    "code": "drop-down",
                    "display": "Drop down"
                  }
                ],
                "text": "Drop down"
              }
            }
          ],
          "required": false,
          "linkId": "ward-oluyole",
          "text": "Ward",
          "enableWhen": [
            {
              "answerCoding": {
                "code": "oluyole",
                "system": "https://www.oyo.com/codes/lga"
              },
              "question": "1",
              "operator": "="
            }
          ],
          "answerOption": [
            {
              "valueCoding": {
                "code": "okanhinde",
                "display": "Okanhinde",
                "system": "https://www.oyo.com/codes/wards"
              }
            },
            {
              "valueCoding": {
                "code": "ayegun",
                "display": "Ayegun",
                "system": "https://www.oyo.com/codes/wards"
              }
            }
          ],
          "item": [
            {
              "type": "choice",
              "code": [
                {
                  "code": "ward-okanhinde",
                  "display": "Net distribution",
                  "system": "https://www.oyo.com/codes"
                }
              ],
              "extension": [
                {
                  "url": "http://hl7.org/fhir/StructureDefinition/questionnaire-itemControl",
                  "valueCodeableConcept": {
                    "coding": [
                      {
                        "system": "http://hl7.org/fhir/questionnaire-item-control",
                        "code": "drop-down",
                        "display": "Drop down"
                      }
                    ],
                    "text": "Drop down"
                  }
                }
              ],
              "required": false,
              "linkId": "ward-okanhinde",
              "text": "Net distribution",
              "enableWhen": [
                {
                  "answerCoding": {
                    "code": "okanhinde",
                    "system": "https://www.oyo.com/codes/wards"
                  },
                  "question": "ward-oluyole",
                  "operator": "="
                },
                {
                  "answerCoding": {
                    "code": "oluyole",
                    "system": "https://www.oyo.com/codes/lga"
                  },
                  "question": "1",
                  "operator": "="
                }
              ],
              "enableBehavior": "all",
              "answerOption": [
                {
                  "valueCoding": {
                    "code": "olojuoro-school",
                    "display": "Olojuoro Pry. Sch.",
                    "system": "https://www.oyo.com/codes/distributionCenter"
                  }
                },
                {
                  "valueCoding": {
                    "code": "agbeja-school",
                    "display": "Agbeja N. P. Sch",
                    "system": "https://www.oyo.com/codes/distributionCenter"
                  }
                }
              ]
            },
            {
              "type": "choice",
              "code": [
                {
                  "code": "ward-ayegun",
                  "display": "Net distribution",
                  "system": "https://www.oyo.com/codes"
                }
              ],
              "extension": [
                {
                  "url": "http://hl7.org/fhir/StructureDefinition/questionnaire-itemControl",
                  "valueCodeableConcept": {
                    "coding": [
                      {
                        "system": "http://hl7.org/fhir/questionnaire-item-control",
                        "code": "drop-down",
                        "display": "Drop down"
                      }
                    ],
                    "text": "Drop down"
                  }
                },
                {
                  "url": "http://lhcforms.nlm.nih.gov/fhirExt/dataControl",
                  "valueString": "[]"
                }
              ],
              "required": false,
              "linkId": "ward-ayegun",
              "text": "Net distribution",
              "enableWhen": [
                {
                  "answerCoding": {
                    "code": "ayegun",
                    "system": "https://www.oyo.com/codes/wards"
                  },
                  "question": "ward-oluyole",
                  "operator": "="
                }
              ],
              "answerOption": [
                {
                  "valueCoding": {
                    "code": "aspen-arena",
                    "display": "ASPEN ARENA",
                    "system": "https://www.oyo.com/codes/distributionCenter"
                  }
                }
              ]
            }
          ]
        }
      ]
    },
    {
      "type": "integer",
      "code": [
        {
          "code": "number-nets",
          "display": "Number of nets",
          "system": "https://www.oyo.com/codes"
        }
      ],
      "extension": [
        {
          "url": "http://hl7.org/fhir/StructureDefinition/maxValue",
          "valueInteger": 5
        }
      ],
      "required": true,
      "linkId": "number-nets",
      "text": "Number of nets"
    },
    {
      "type": "string",
      "code": [],
      "required": true,
      "linkId": "head-of-household",
      "text": "Initials of the Head of the Household"
    },
    {
      "type": "boolean",
      "code": [
        {
          "code": "phone-number-permission",
          "display": "Does Head of household agree to provide phone number for healthcare use?"
        }
      ],
      "required": true,
      "linkId": "phone-number-permission",
      "text": "Does Head of household agree to provide phone number for healthcare use?",
      "initial": [
        {
          "valueBoolean": "false"
        }
      ],
      "item": [
        {
          "type": "choice",
          "code": [
            {
              "code": "country-code",
              "display": "Country code",
              "system": "https://countrycode.com/countryCodes"
            }
          ],
          "extension": [
            {
              "url": "http://hl7.org/fhir/StructureDefinition/questionnaire-itemControl",
              "valueCodeableConcept": {
                "coding": [
                  {
                    "system": "http://hl7.org/fhir/questionnaire-item-control",
                    "code": "drop-down",
                    "display": "Drop down"
                  }
                ],
                "text": "Drop down"
              }
            }
          ],
          "required": false,
          "linkId": "country-code",
          "text": "Country code",
          "enableWhen": [
            {
              "answerBoolean": true,
              "question": "phone-number-permission",
              "operator": "="
            }
          ],
          "enableBehavior": "all",
          "answerOption": [
            {
              "valueCoding": {
                "code": "nigeria",
                "display": "+234",
                "system": "https://countrycode.com/countryCodes"
              }
            },
            {
              "valueCoding": {
                "code": "india",
                "display": "+91",
                "system": "https://countrycode.com/countryCodes"
              }
            },
            {
              "valueCoding": {
                "code": "usa",
                "display": "+1",
                "system": "https://countrycode.com/countryCodes"
              }
            },
            {
              "valueCoding": {
                "code": "south-africa",
                "display": "+27",
                "system": "https://countrycode.com/countryCodes"
              }
            }
          ]
        },
        {
          "type": "string",
          "code": [
            {
              "code": "phone-number",
              "display": "Phone number",
              "system": "https://countrycode.com/countryCodes"
            }
          ],
          "required": false,
          "linkId": "phone-number",
          "text": "Phone number",
          "enableWhen": [
            {
              "answerBoolean": true,
              "question": "country-code",
              "operator": "exists"
            }
          ],
          "enableBehavior": "all"
        }
      ]
    }
  ]
}

Would you like to work on the issue?
Yes

@joiskash about "Clear answer items if enableWhen condition is false" how do you reproduce it in your questionnaire?

Select answers for the first 3 questions i.e. LGA, ward, distribution center
Then press submit you will see the correct items in the questionnaire response
Now select a new LGA, new ward and new distribution center note that the ward also has to be different/new.
Then press submit, you will see the answers selected at step 1 and step 3 in the questionnaire response

@joiskash can you please verify that your questionnaire works with the fixes here? thanks

Yes i just tried with an updated version of my questionnaire with more answer options. It works fine! Thanks! @jingtang10


Can be use a point(dot like ui) for change value of knob

Hi Guys,
This project is really awesome. I've one query.
Can I use a point(dot like ui) for change value of knob as show in attachment? Please let me know if you have any suggestion.

Thanks guys!

Any suggestion would be very helpful to me!

Not by default. You need to modify by yourself to get this result. But it is a good suggestion. Currently, I am very busy with other projects but I will take a look later.

I tried to add this, but no luck.


Links to security-config page should be updated

Links to https://developer.android.com/preview/features/security-config.html which are used in several places in the README are not working anymore, I guess google removed that page.
Instead https://developer.android.com/training/articles/security-config.html should be used (I guess).
I'll create a PR a bit later if you won't beat me to it (or explicitly state that it is not needed) :)

I found two occurrences of that URL in the README and fixed those, and I don't see any in the advanced docs. Are there others?
Thanks for pointing this out!

No, I think I also saw only two of them!

OK, marking as fixed -- thanks again!


fix(next): __dirname to inner scope

If you use storybook and serwist together, they will conflict for __dirname variable.
Because it is already created with a global scope, it cannot be used by branching from the business logic it uses.
So I suggest moving to scope within the function.

Huh, that's funny. Wondering why @serwist/next's scope and Storybook's scope are the same thing, though. I doubt that's the case - it's probably that __dirname is already defined in the global scope since we are in a CJS context. If that's the case, I'm not sure why it only happens to you, though. Still, instead of always defining a __dirname, perhaps we can do this instead:
if (!("__dirname" in globalThis))
  globalThis.__dirname = fileURLToPath(new URL(".", import.meta.url));

Or, instead of using the name __dirname, we use dirname instead. Not really in favour of this though, since we would compute __dirname twice for no reason.

Or, instead of using the name __dirname, we use dirname instead. Not really in favour of this though, since we would compute __dirname twice for no reason. Also, can you try renaming both __dirname to dirname in your local copy of @serwist/next and Storybook to see if that fixes the bug?

After changing the file name, it works without problem. But I think this is not a fundamental solution.
This is because the root of the problem occurs when the same variable is declared in the global scope, and although it is fortunately avoided now, it may unfortunately overlap with other libraries in the future.
Probably, before Next.js15, next.config.js operated in CommonJS format, so there would have been no problem using the global variable like __dirname.
However, from Next.js15, it changed to ESM method. Perhaps that's why setting global variables seems to have the same scope as other libraries.
With the change to ESM, I think there will be a problem with the use of __dirname, which was a global variable.
So I think setting it to the function scope as I suggested is better, but what about you?

@jthcast

However, from Next.js15, it changed to ESM method. Perhaps that's why setting global variables seems to have the same scope as other libraries.

That's not the case - you can use either ESM or CJS. That we redeclared __dirname was a mistake and should be fixed, yes. However, I don't really like moving the declaration to the function scope. Rather, I prefer it if we declare __dirname only when necesssary, reusing precomputed values when possible. Basically, use Node.js's __dirname in CJS and fileURLToPath(new URL(".", import.meta.url)) in ESM. A bit like this:
const dirname = "__dirname" in globalThis ? __dirname : fileURLToPath(new URL(".", import.meta.url));

This approach avoids declaring the __dirname to the global scope, making it accessible to other modules although it would be an incorrect value in such modules, like in the approach I suggested earlier. I guess this is the way.

That's not the case - you can use either ESM or CJS, and this has been the case for years (what you meant to say is that Next.js now supports a TypeScript configuration file).

Thanks for letting me know.
Please confirm that I modified it the way you suggested. 2d1c2ae

@jthcast that's good. Thanks! We didn't have a changeset, but I can add that later.


kpartitionmanager is not feeling so well

Main window shows up but everything is greyed out.
Likely related console output:
kf.coreaddons: "Could not find plugin kpmcore/"
Could not create instance of plugin   ""
Loaded backend plugin:  "pmsfdiskbackendplugin"

c4223babe5e96077c8d6da5c775c84a89f8ac01b fixes most of it, with the caveat that kpartitionmanager needs to actually be installed system-wide, as it requires polkit actions and whatnot. The failure mode for "no polkit" is really bad though.


Cant Sign In

Issue Type: Bug
Can't to sign in using your MS account
Extension version: 0.3.4
VS Code version: Code 1.42.1 (c47d83b293181d9be64f27ff093689e8e7aed054, 2020-02-11T14:45:59.656Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz (12 x 3696)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: unavailable_offskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.92GB (6.59GB free)

Process Argv

Screen Reader
no

VM
0%

Thanks for reaching out. Can you give us more details about your scenario? Also, your logs may provide us with helpful information. You can access them via the Live Share: Export Logs command from the command palette (ctrl + shift + p) and attach them to this issue.

Same issue. Sign in with GitHub and sign in with user code also doesn't work. OS used: Ubuntu 16.04.
PFA the logs
logs.zip

@aletsdelarosa Same issue. Logs: signing.zip

Thank for your reporting these issues. We have made improvements to the authentication flow described in this issue and solved the underlying problem. If this issue persists for you, please reopen the ticket! Thank you


operator ibm-security-verify-access-operator (22.10.0)

Signed-off-by: asha<EMAIL_ADDRESS>Thanks for submitting your Operator. Please check the below list before you create your Pull Request.
New Submissions

[ ] Are you familiar with our contribution guidelines?
[ ] Have you packaged and deployed your Operator for Operator Framework?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Have you considered whether you want to use semantic versioning order?
[ ] Is your submission signed?
[ ] Is operator icon set?

Updates to existing Operators

[x] Did you create a ci.yaml file according to the update instructions?
[x] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[ x Is your submission signed?

Your submission should not

[ ] Modify more than one operator
[ ] Modify an Operator you don't own
[ ] Rename an operator - please remove and add with a different name instead
[ ] Modify any files outside the above mentioned folders
[ ] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[ ] Description of the managed Application and where to find more information
[ ] Features and capabilities of your Operator and how to use it
[ ] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[ ] Human readable name and 1-liner description about your Operator
[ ] Valid category name1
[ ] One of the pre-defined capability levels2
[ ] Links to the maintainer, source code and documentation
[ ] Example templates for all Custom Resource Definitions intended to be used
[ ] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/hold

/unhold

/merge possible

/merge possible

/merge possible

/hold

/unhold

/merge possible

@scottexton You have to approve this PR as explained here and then do /hold and /unhold

/hold

/unhold

/merge possible


Added AdminHeader component

Description

What work was done?
AddedHeader component to align with the AdminDashboard page.

Why was this work done?
The AdminHeader component is to be used across all admin dashboard pages

What feature / user story is it for?
Addresses this feature on this trello card

Any relevant links or images / screenshots

Wireframe for Admin Dashboard that displays AdminHeader component at the top.

Co-authored-by: @ORiveraJr84 & @kyle-naumann
Initial rendering of Admin Dashboard that displays AdminHeader component at the top.

Co-authored-by: @Regbmiller
Type of change

[x] New feature (non-breaking change which adds functionality)

Change Status

[x] Incomplete/work-in-progress, PR is for discussion/feedback

Has This Been Tested

[x] Yes

Under the files changed tab, all the files other than AdminHeader.js are caught in this PR because it has commits of a git rebase that had conflicts, which were resolved. Those files will not make any changes to the ones in main since they are exactly the same.

Loom video

Nice clean code Rodolfo! I'm excited to see how styling will bring this page to life. Wondering if we have global button components we can use/create to have uniform styling throughout the admin page.

@rikaciminieri Thanks for taking a look! Yeah a common button for the admin makes sense. Thanks!

@jraval Thank you!


Problem publishing a custom project with custom bundle and modules in different folder

This is how I have organized our folders to keep all our modules for a Project in a repo.
This is the root folder of our submodule repo and its nested folder and relevant files
\Orchard2\src\OrchardCore.DistribWebAPI
\Orchard2\src\OrchardCore.DistribWebAPI\Bundles\Directory.Build.props
\Orchard2\src\OrchardCore.DistribWebAPI\Bundles\PCCOM.Distrib.WebAPIBundle\PCCOM.Distrib.WebAPIBundle.csproj
\Orchard2\src\OrchardCore.DistribWebAPI\DistribWebAPI\DistribWebAPI.csproj (this is our startup project)

\Orchard2\src\OrchardCore.DistribWebAPI\Modules\PCCOM.Distrib.WebAPI.Core\PCCOM.Distrib.WebAPI.Core.csproj
D:\PROYECTOS\DistribOrchardWebAPI\Orchard2\src\OrchardCore.DistribWebAPI\Modules\PCCOM.Distrib.WebAPI.Setup\PCCOM.Distrib.WebAPI.Setup.csproj
...

This works properly and can be run from VStudio. However when I publish it I get following error:
  DistribWebAPI -> D:\PROYECTOS\DistribOrchardWebAPI\Orchard2\src\OrchardCore.DistribWebAPI\DistribWebAPI\bin\Release\netcoreapp1.1\DistribWebAPI.dll
  Copying package assets
D:\PROYECTOS\DistribOrchardWebAPI\Orchard2\src\OrchardCore.DistribWebAPI\Bundles\PCCOM.Distrib.WebAPIBundle\PCCOM.Distrib.WebAPIBundle.csproj : error MSB4057: The target "CopyPackageAssetFiles" does not exist in the project.

Maybe it is useful for you to know which is the content of this file \Orchard2\src\OrchardCore.DistribWebAPI\Bundles\Directory.Build.props
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <Import Project="..\..\OrchardCore.Build\OrchardCore.Commons.props" />
</Project>

Does it have anything to do with the fact I have the bundle in a subfolder that it is not the default one? I mean other bundles are in OrchardCore folder. I moved it to a different location because I want to keep in the same repo my root project, my bundle project and its specific modules.
Any idea?

I did the following before publishing, but it didn't solve the problem:
Orchard2\git clean -xdf
Orchard2\src\OrchardCore.DistribWebAPI\git clean -xdf
Orchard2\dotnet restore

This doesn't seems like an issue with one of the CI tasks in this repo.   If you can supply which task and your CI build output, reactivate

Yes you are right, Iddin't noticed I submit my issue to the wrong repo


Move DirectGovernanceFarmer to diamond facets

We've migrated most of our contracts to the diamond proxy implementation. But not all of them.
What should be done:

refactor DirectGovernanceFarmer to be part of the diamond facets
add DirectGovernanceFarmer to the deployment script
refactor DirectGovernanceFarmer tests accordingly

/start

@molecula451 try with the /start command

👀

/start

i'm finishing things here, this is one of our biggest contracts by far

/start

timelabel less than 4 hours 🤣

not not really, maybe the diamond cuts section, but not the debugging, anyway just for fun 😄

timelabel less than 4 hours 🤣

not not really, maybe the diamond cuts section, but not the debugging, anyway just for fun 😄

Perhaps https://cursor.sh can help you save time.
This with gpt4 + copilot is really powerful.

in your copilot dreams you are still the driver  🤣

This with gpt4 + copilot is really powerful.

+1 for this setup!


Typo in installation instructions

In Python installation line 5 should read
git submodule init; git submodule update

Looks like it's missing a .. code-block:: bash
Also a period at the end of the introductory sentence


Inconsistent buttons for adding new benches.

https://openbenches.org/ has two buttons people can click to add a new bench. One button is labelled "New Bench" and the other "Add a new bench". Clicking either button takes the visitor to the same place and as such should they should have the same label.
The buttons achieve the same thing but are implemented differently. "New Bench" is an input element which submits a form and takes the visitor to https://openbenches.org/add/  Because it's an input element it can't be right/context/long clicked to open the destination in a new tab.
"Add a new bench" is a div that contains a hyperlink to https://openbenches.org/add/ which be right/context/long clicked to open the destination in a new tab. Since both buttons do the same thing it seems logical that they be constructed identically. The hyperlink method seems preferable.

Yup - sounds good. Go ahead and make the change.
From memory, one is a button so it will line up with the other. Worth testing to make sure it still looks OK.

Now I'm going to have to look up again how to do do this whole forking branching pull request malarky. :D

Consistent wording on buttons to add benches. All the things to click look consistent.
https://validator.w3.org says "No errors or warnings to show." when fed the HTML.

For comparison this is what the site currently looks like in Firefox

Those weird almost drop shadow like border things don't show up in all browsers.
Look good? If so I'll try and sort out a pull request with the changes.

Looks good. Send a PR - to a different branch - and I'll test it out.


Reduce default max_dbs_open to 100

With q=8 being the default shard setting, and the Linux default of
1024 file handles per process out of the box on virtually every distro,
the maximum number of databases an unmodified user environment could
conceivably open simultaneously is 128. (Assuming one view/index per
database open as well, that number drops to 64.)
When we hit these limits (enfile / emfile Erlang errors) CouchDB starts
acting very erratically, leading to lots of scary errors and in some
cases inconsistent databases. We have a recent report of mem3 dying as a
result, which took the ets tables with it - and this occurred with just
32 databases, with multiple views . In another case a user reported
pereceived database corruption (which was actually a combination of
error reports + app-server layer errors).
While we should recommend ulimit/fs.file-max be bumped in production
use, and consequently bumping max_dbs_open as well, we should defend
against these kinds of errors for users who compile and install from
source (our official distribution option). max_dbs_open = 100 makes this
kind of error less likely.
This also matches our couchdb-documentation repository, which still
reflects a setting of 100 and was never updated to match our increased
500 limit.
The alternate approach is for us to better handle enfile / emfile errors
and react accordingly, but there are are a significant number of touch
points in the code where this can cause issues.

Note that tests are failing because a change in a separate repo, couchdb-config is required. See reference above.

For the failing tests I'd just add the dependency update in this PR as a separate commit.
Did we just talk about a log message during startup that looked at the max file handle count and added a warning or did we actually add that. And/or is that just a hard thing to do portably for our target platforms? I seem to recall a similar discussion about this issue for the test suite.

The max_dbs_open field is a bit of a misnomer in that it would be more accurate to call it max_shards_open because it tracks the number of open shards, not the number of open dbs. You should not be hitting file open limits with max_dbs_open=500 on a system with file limit of 1024 with just dbs. If we're letting views fall through the cracks then we should fix it so view shards are regulated as well.
I don't think reducing this value to 100 is a good change, as 100 is quite low for a default.

I will close this PR, but before I do, I'll run some tests as to what we can do to fix this issue. Given recent issues filed I'm not sure what @chewbranca says is true in practice.
The especially difficult part is if the system wide fs.file-max setting is too low, we may never hit the couchdb process's file handle limit before hitting the kernel max limit, and we start getting emfile/enfile errors anyway. Again for reference on CentOS/RHEL the default fs.file-max is 4096, so if you're running 3-4 other fd-hungry daemons on the box, even with the default 1024 fd limit, you're going to run into this situation. Perhaps we need to do more probing on this front, os-dependent as much as possible...
If what we're running into is an issue with view shards not db shards, then yeah, we need more. @sagelywizard was working on this in https://github.com/apache/couchdb/pull/477 so perhaps we should close that out as well.

also @davisp even if I was to move forward with merging the other repo, it's a circular dependency problem: couchdb-config's test depends on the definition of MAX_DBS_OPEN which is in this repo, and the overall couchdb repo test suite depends on couchdb-config's test suite passing. What a pain.

Best thing I can think of without thinking too hard is to just merge things that aren't this repo to master and then we gate that on the CI on this repo passing? Can always revert.
Second option is to pull the hash as a temporary bump here maybe?

Closing until I can confirm what we should do re: @chewbranca 's comments.


The periodic table is truncated

The periodic table is truncated in a way that some elements are not accessible:

It is not possible to scroll to the desired elements either.
Version: 2021.8.24
On AiiDAlab.

Note so self: Fix by pointing to other notebook/moving to vertical layout.


[Key Vault] Generate nonce for key release by default

Per this comment, we may want to generate a (non-cryptographic) nonce when one isn't provided as a parameter to key release. This may or may not be necessary since the parameter is currently optional for the operation and is "just an identifier the client can send in order to detect freshness in certain more complex confidential compute scenarios".

[x] Investigate whether or not default generation is desirable
[ ] Implement default generation if so

After asking the service team about this, generating a nonce won't be necessary.


Seg fault while trying to ingest

While attempting to run the benchmark, I keep running into seg faults.
I'm running Redis 4.02 (OSS) / RediSearch 0.21.3 with 5 nodes. While running the benchmark using this:
./RediSearchBenchmark -engine redis -shards 5 -hosts "localhost:6379,localhost:6380,localhost:6381,localhost:6382,localhost:6383"     -file ~/enwiki-latest-abstract.xml

I'm guessing this is a RediSearch issue, so I'll x-post an issue over on that repo.
Here are the dumps - I was pretty consistently getting 2 out of 5 shards seg faulting.
redisearch-ingest-seg-fault2.txt
redisearch-ingest-seg-fault1.txt

There is a bug in redis 4.0.2 that was fixed already, run it with redis unstable, it shouldn't happen.

Gotcha. I'll run it and report back.

It might be a different issue, since the benchmark doesn't do multi IIRC.
But using the latest redis is a must in this context.
On Fri, Oct 20, 2017 at 6:31 PM Kyle J. Davis<EMAIL_ADDRESS>wrote:

Gotcha. I'll run it and report back.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/RedisLabs/RediSearchBenchmark/issues/2#issuecomment-338240755,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAetupmHRI42ewUNmMT0y1wVQUBySL7cks5suLzigaJpZM4QABqr
.

Still getting seg faults in a similar pattern (run the benchmark, within a few seconds two nodes give segs, the rest run with no problem) with unstable.
Not sure if this is relevant, but I'm running the bog standard install of unstable with redis.io provided conf file and redisearch and port set via the command line when starting the servers.
seg-fault-4.txt
seg-fault-3.txt
I may try rolling back the versions of RediSearch until I hit one that works with the benchmark.

This must be a relatively recent bug. Unstable + RediSearch 0.20.0 and 0.21.0 do not cause seg faults.

ok, I'll try to recreate.
What are you using to run the benchmark? wikipedia extracts?
On Mon, Oct 23, 2017 at 2:31 PM Kyle J. Davis<EMAIL_ADDRESS>wrote:

This must be a relatively recent bug. Unstable + RediSearch 0.20.0 and
0.21.0 do not cause seg faults.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/RedisLabs/RediSearchBenchmark/issues/2#issuecomment-338659452,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAeturwui2WPan3yC8_3mAhiAPexhdJkks5svJU9gaJpZM4QABqr
.

Yup. Wikipedia extracts.

@mnunberg do you mind having a look?

@stockholmux how long until the segfault is triggered. Trying to reproduce but no luck so far.

ok, I seem to have triggered it.

@stockholmux btw did you get this on Mac or Linux?

@mnunberg AWS / Ubuntu: c4.4xlarge.

I believe I've fixed the issue. Can you verify? (latest master on RediSearch)

@mnunberg I won't have a chance until Thursday, unfortunately.

closing given this issue is no longer relevant/applicable.


RegisterForPushNotifications doesn't work when autoRegistration is set to false

🐛 Bug Report
I want to request notification permissions from the user on the press of a specific button, so I've set autoRegistration to false in the AppDelegate:
            LoadApplication(new App(new iOSInitializer()));
            FirebasePushNotificationManager.Initialize(options, true);
            return base.FinishedLaunching(app, options);

and then on the button click event handler:
           CrossFirebasePushNotification.Current.RegisterForPushNotifications();
and I get the prompt to allow notifications, but when I look at the subscribed topics, it shows as none. I haven't checked if OnTokenRefresh is ever executed afterwards but I don't use tokens on this specific app.
If I set autoRegistration to true, I get the notification prompt on app's first startup, and it works. But if I set autoRegistration to false, SubscribedTopics is empty.
Expected behavior
Calling CrossFirebasePushNotification.Current.RegisterForPushNotifications(); shows the prompt, user chooses Allow, and any topics subscribed to afterwards show be registered.
Actual behavior
The prompt is shown, but any topics subscribed to afterwards are not registered.
Reproduction steps

Put FirebasePushNotificationManager.Initialize(options, false); in AppDelegate.
Add an event handler to a button on a view.
Add CrossFirebasePushNotification.Current.RegisterForPushNotifications(); to the event handler
Subscribe to a topic
Call CrossFirebasePushNotification.Current.SubscribedTopics

Configuration
Platform:

[ ] :iphone: iOS
[ ] :monkey: Xamarin.Forms

have same issue, any progress on this?

I have found the problem, but not the solution yet.
The problem seem to be in the public void Subscribe(string topic).
For some reson, hasToken is false even though there is a token availible.
if (!hasToken)
            {
                pendingTopics.Enqueue(new Tuple<string, bool>(topic, true));
                return;
            }


fix mode parsing and label support

Hi,
I'm really sorry but the commit yesterday contained an error.
And I added support for labels.
Regards
Joke

Agreed. Checking for a list or dict would be wise.


Imprint page 404

The imprint-page does not exist:

Dear orc-hfg,
thank you very much for reporting an issue. I created the link, but I was waiting until having the page to link to: that explains the "page not found" of your second image. Now everything should work fine (or less nonfunctional). Thank you also for the patience... sometimes it takes longer as expected...
For everyone reading this, we can learn two things:
Issue report
That's basically how an issue report works. Someone (in this case orc-hfg, but it could be you) reports that there is an issue (in this case: there is no imprint page). In order to do that, it's important to be clear on how to reproduce the problem, or at least communicate what the problem is. Orc-hfg used two pictures, and we could quickly understand what the problem was. A good approach is also to think in three questions:

what did you do? (first image, clicking on imprint),
what did you expect to happen? (in this case obvious, to be linked to the imprint page after clicking the link) and
what did actually happen? (getting a 404 error page).

It is possible that maintainers or developers contact you to get more information about the problem: yes, suddenly you become a world expert or at least the most reliable source to this problem!
Imprint pages
Imprint pages is the part of a publication that connects this document with an authorship and ownership, which implies legal responsibilities. It's the equivalent to the page (normally at the beginning, sometimes at the end) in which you will find all the editorial information, ISBN, etc. in a book: this is crucial if you decide to take any legal action. In Germany (and in many other countries), websites are obligated to declare who is responsible for them, according to the Telemediengesetz.
In the first part of our imprint, you will find information about how to contact me, as I am the ultimate responsible for the website. Then, we attached some disclaimers to protect us against possible complaints. It's a quite standard procedure, and I just copy search for a template in internet (the first result happens to be from JuraForum, in German). I have no idea how good or bad they are, so I compared with the Imprint of other websites I consider reliable and after checking that nothing was miss and that everything there makes sense, I create the imprint page. I'm not an expert on this topic (and hence I cannot recommend you any services), but your personal data is mandatory, and the disclaimers seems a standard protection. For the English version, I translated and added the note at the beginning, indicating that the "real" version is the German: this makes sense, because everything will be processed by the German legal system.
If you're working in a website, you should clarify this point as soon as possible: Here you are declaring who is the ultimate responsible person or group of every information on the web. In the university context, this person could be the rector, or the director in cultural institutions. I decided to take the responsibility of the "The abc of digital literacy" website, because I understand as a project or materials which are part of the course I was teaching. From my point of view, the responsible should control (and proof) all the published information. As I am already "proofreading" all the changes of the website, I have no problem on getting this responsibility. Of course, we may change this (and the imprint) if we need it.


[Bug] 2.0.2 创建用户授权后 with as语句报错空指针

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
2.0.2
What's Wrong?
创建test用户，并授权
create user test idenified by 'test'; grant all on *.* to test; grant all on *.*.*  to test;
执行with as类型语句
WITH aa AS ( SELECT * FROM numbers ( "number" = "24" ) ) select * from aa;
报错
ERROR 1105 (HY000): errCode = 2, detailMessage = Unexpected exception: null
fe.log报错

What You Expected?
解决这个问题
How to Reproduce?
创建test用户，并授权
create user test idenified by 'test'; grant all on *.* to test; grant all on *.*.*  to test;
执行with as类型语句
WITH aa AS ( SELECT * FROM numbers ( "number" = "24" ) ) select * from aa;
Anything Else?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

202已经复现，202上CIR-6481正在处理。203有fix。


Policy for billable resources

Is it possible to identify which tags are passed to Cost Managment in a policy?
It would be ideal to enforce a required tag (say, "costcentre") in a policy but only for resources that are billable.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 55b4c3f6-7ea3-9b94-cd8c-cbe37dc31656
Version Independent ID: 0310805b-ff71-85bf-3f74-ca4caa6a46ce
Content: Tag resources for logical organization - Azure Resource Manager
Content Source: articles/azure-resource-manager/management/tag-resources.md
Service: azure-resource-manager
Sub-service: management
GitHub Login: @tfitzmac
Microsoft Alias: tomfitz

@OffColour - I am not aware of a way to easily identify within a policy which resource types pass tags to the cost report. But, given that most resource types that support tags also pass the values to the cost report, and those that don't pass the values currently are moving towards compliance, I would recommend tagging all the resources. I think it is potentially confusing if you don't tag a resource now but next month it adds compliance with the cost report.

Thank you @tfitzmac for helping on this thread.
@OffColour - Thank you for reaching out to us, please review the above information shared by @tfitzmac  and let us know if you have any further queries.

Thanks. It's more an issue with resources that don't support tags so applying a blanket policy requiring a tag makes it impossible to get 100% compliance.

As long as you set the mode to Indexed, the policy is only applied to resources that support tags. Here is more information.

#please-close

@tfitzmac Hi, this doesn't work unfortunately. Using the built-in policy "Inherit a tag from the resource group" which has mode set to indexed tries to apply tags to the following types:
microsoft.insights/actionGroups
microsoft.operationsmanagement/solutions
microsoft.network/networkWatchers/connectionMonitors
microsoft.network/networkWatchers/flowLogs
Microsoft.Network/trafficManagerProfiles
They all report as non-compliant as they don't support tags.

@tfitzmac Hi, this doesn't work unfortunately. Using the built-in policy "Inherit a tag from the resource group" which has mode set to indexed tries to apply tags to the following types:
microsoft.insights/actionGroups
microsoft.operationsmanagement/solutions
microsoft.network/networkWatchers/connectionMonitors
microsoft.network/networkWatchers/flowLogs
Microsoft.Network/trafficManagerProfiles
They all report as non-compliant as they don't support tags.

Those resource types all have a tags property in the REST API. I also tested adding tags to trafficManagerProfiles, and it worked fine. Perhaps there is something else that is causing non-compliance.


Content of the key file

How should the content in the keyfile be specified?

The content will be autogenerated


readme: note some info on adding a task

Description
Updates the readme to document the requirement of implementing
the _postCheck hook so that we can rely more on automation
of checking the correctness of upgrade scripts

@mark Do you want to keep this PR open?

We don't have this info documented, even though it's our new standard, so I do think we should get this merged


Complete redesign of the resource registry

Addressed the feedback from @mrBliss and @nfrisby . Moreover, did another thorough peer review over hangout with @nfrisby which resulted in a few subtle tweaks. I think this is ready for a final review by @nfrisby and can then be merged.


[BUG] Type 'ReactNativePlugin' is not assignable to type 'ITelemetryPlugin'.

Description
Same as this issue https://github.com/microsoft/applicationinsights-react-js/issues/32
Tried with the following versions:

@microsoft/applicationinsights-react-native v3.0.3
@microsoft/applicationinsights-web v3.0.2

and

@microsoft/applicationinsights-react-native v4.0.0-nightly.2306-02
@microsoft/applicationinsights-web v3.0.3-nightly3.2306-01

Steps to Reproduce
import { ApplicationInsights } from '@microsoft/applicationinsights-web';
import { ReactNativePlugin } from '@microsoft/applicationinsights-react-native';

var RNPlugin = new ReactNativePlugin();
var appInsights = new ApplicationInsights({
    config: {
        instrumentationKey: 'YOUR_INSTRUMENTATION_KEY_GOES_HERE',
        extensions: [RNPlugin]
    }
});
appInsights.loadAppInsights();

We have not yet released a compatible version of this component to fully support v3 of Application Insights
https://github.com/microsoft/applicationinsights-react-native#compatibility-matrix
As part of the release we will be renumbering to match the major number of the supported react framework


Update Install.zh.md

修改如下：
（1）在创建数据库时记得替换掉“<IP_ADDRESS>”的ip地址为本机地址；
（2）提醒4.4章节中部署这些服务的包文件是去哪里获取的；
（3）提供日志文件目录路径用于调试；
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?

Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

Code formatting

Closing issues
Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

thanks


Blinking except for the first element in input chips

When delete chip, every chips are blinking (exclude first chip).
I guess this isn't web issue, only react.

Thanks for opening! Confirmed an issue...looks like the click should not be propagated.

I don't know why first element is fine.
But I guess animation(mdc-chip-set--input) is executed every time.


Fix metrics-exporter Prometheus dependency

This PR embeds all relevant Prometheus dependencies
(even transitive ones) into the metrics-exporter bundle;
some new ones were missing due to the 0.11.0 update.
The update also seems to add some new functionality related
to OpenTelemetry, which we don't use (:crossed_fingers:),
but which we still need to exlude from the generated Import-Packages
header.
Your pull request should…

[x] have a concise title
[x] close an accompanying issue if one exists
[x] be against the correct branch
[x] include migration scripts and documentation, if appropriate
[x] pass automated tests
[x] have a clean commit history
[x] have proper commit messages (title and body) for all commits

This was broken by #2663 by the way. ;)

Sorry!

Hi, I've never tried this metrics exporters, but I'll check it out in order to review this pull

Hi Karen, this is how the metrics should look like:

https://stable.opencast.org/metrics

I recently worked on extending the metrics-exporter with additional metrics and also ran into that issue after updating the dependency. I can report that with this patch running the develop distribution is working again. The metrics endpoint also works as expected, i.e. all metrics found in https://stable.opencast.org/metrics are still contained.

Thanks for reviewing this → Merging


Wire up multi-cursor timer queue implementation

What changed?
Wire up multi-cursor timer queue implementation

Why?
Part of multi-cursor queue implementation

How did you test it?
Unit test, integration test, local canary

Potential risks
N/A, feature flag disabled

Coverage decreased (-0.4%) to 67.593% when pulling 6eea90c57286b7626ab806984e0f1f7fbc6b0e3d on yycptt:multi-cursor-timer-queue into 9ffa5e4bb22ee8c47d373a3ac707b690713dc8ac on uber:master.


remove constants; read liberty data; get port orders; separate flops …

…in clusterable chunks; rewrite netlist

My feeling is that there will be subsequent work on this PR but it is ready to be merged and more testing will follow.


Dev s100/feature/182912 create folder structure for s100 erp facade fts

Hi,
This PR contains folder structure for s100 ERP facade fts.
Thanks

Not required


Validation gen unions

Add union generation
Update enum generation
Added "support variables" which both unions and enums use to initialize state (eg. a set of enum symbols).

@thockin This feels feature complete to me.  It expands on some parts of the generator, so I don't want to rush the merge.

Quick update on this one:

I've rebased and moved all the enum support out (I'll submit a separate PR with the feedback from this PR incorporated)
https://github.com/jpbetz/kubernetes/pull/11#discussion_r1698966035 will need to be carefully addressed.  I'm working on that.
I need to restructure ExtractValidations to return a struct that contains a list of FunctionGen and a list of SupportVarGen

@thockin OK, this is ready for more review.  The only major gap is fatal/dependent field support (per offline discussion-- I'll hold on that since you have it already in progress).

Thanks @thockin!  Feedback addressed.

Thanks @thockin. Feedback applied

@thockin Feedback applied in latest commit


Indicate whether the users are globally visible

Maybe a mid-level warning if _users is visible anonymously, and a high-level warning if any user names look like email addresses.

Good idea :)


CAMEL-20399: String to short type conversion fails

Description
String to short type conversion fails with:
NoTypeConversionAvailable No type converter available to convert from type: java.lang.String to the required type: short
to reproduce it just test:
assertEquals(Short.parseShort("1"), context.getTypeConverter().mandatoryConvertTo(short.class, "1"));

Target

[X] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[X] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[X] I checked that each commit in the pull request has a meaningful subject line and body.

[X] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

why do you need a short, any real use-case for using it

I think there is an option in hdfs changed from int to short in 4.3.0.. we removed hdfs in 4.4.0 but I guess is useful anyway

ok thanks. Yeah I was trying to say since we have not had this reported before then I wondered how you found out eg what did you did = what is the use-case.
But its a simple and good fix and indeed missing

why do you need a short, any real use-case for using it

I found out because of a component option that is set to short.


Exporting with bootstrap style

I use bootstrap for styling, everything works fine..
but when exporting there is a problem with the display...
is there a way to still use bootstrap not using inline css. Because the display is too complex

It needs inline css to work. There is a theoretical automated way of looping over all elements and assigning external CSS as an internal one using javascript.
Haven't tried it and not sure if it works or not


make debian branch compatible with git-buildpackage

we should probably switch to using this more efficient packaging tool

This was closed in 9cc6337  on Nov 2, 2016