Add region to "Outputs" panel of WorkflowView [BW-449 spin-off]

Spun off from BW-449 to avoid overcomplicating it.
Tested live on alpha.
Before:

After:

UX Changes:

Move location content to a collapsible panel to avoid overwhelming the table below
Show output bucket name and location
"Files" becomes a link to the appropriate tab on the Data page (before this change, I just thought "Files" was just a (not especially helpful!) word, rather than a reference to the Data tab)
Link to the Tables page (ditto)

@cjllanwarne This looks good to me. I like the added clarity! Can you just make sure we have a Jira ticket specific to this change

@cjllanwarne This looks good to me. I like the added clarity! Can you just make sure we have a Jira ticket specific to this change

Chris, this looks stale. Closing for now and please feel free to reopen if you want to work on getting this in.


Question about new menu item "FIXME" under "More" in the top navigation

I don't understand the "FIXME" menu option under the "More" menu for lessons that have been transitioned to Workbench. I see this in my lesson (lc-git: https://librarycarpentry.org/lc-git/reference.html) and also in another lesson I'm referring to (lc-spreadsheets: https://librarycarpentry.org/lc-spreadsheets/reference.html)
I'm pretty sure we didn't have that link in the Github versions, but I might be wrong.
Tagging, @carpentries/core-team-curriculum

Hi @emcaulay,
That is likely because the original version did not have a title (which was found to be a bug in the former template).
The solution is to edit that page and add change the title at the top from 'FIXME' to 'Reference'

Both of these pages should be documents that contain reference information for learners, namely a glossary, but it could be other reference material.

Thank you again for bringing this up, @emcaulay. Because of your reporting, I was able to find and correct the bug in my transition script. Moving forward, lessons will have the correct title for the reference page.
Please let me know if you would like me to create a pull request to fix the reference tite.

Awwww, that is so sweet of you to take the time to let me know. I feel
really good that I was able to help the bigger project, and I wouldn’t have
known that without your letting me know! Thank you! I love to contribute!


Add new rule: "SHOULD select appropriate one of date or date-time format"

Closing https://github.com/zalando/restful-api-guidelines/issues/797.

@tfrauenstein thanks for the suggestions. Applied.

👍

@ePaul you marked this PR with zally-change label, does it mean we need to adjust Zally?

@vadimturkov Hmm, that would be the meaning of this label, but looking at the text again, I don't remember anymore why I did this.

:+1:


Fix countries resolver performance

I want to merge this change because it's a 3.0 backport of #9318

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-6175 country query does multiple redundant SQL queries


Introduce metrics-based inventory into the agent.

This is a squashed commit of the work done by
Joel Takvorian, Jay Shaughnessy and Lukas Krejci

Do not merge - travis shows green but fails itests on mine and @jshaughn machines. I think travis isn't running the tests. Need to confirm what's going on.


Support spdlog version before v1

Before v1 include name for file spdlog's sink was file_sinks.h and in v1 it has been changed to basic_file_sink.h.
This patch allows successful compilation on Linux Mint 19.2 and probably fix Ubuntu too.

As long as the user has docker installed, they should be able to build on any Linux platform with a sufficiently recent version of the kernel. Are you trying to build this locally?

Yes, I've built it locally.

I've also managed to build it in OSX, but have not tried to run yet.

It's unclear whether we're going to support building JCoz locally without docker. We may, but it will depend on implementing #17 using something like Bazel, and also on #2, in which we'll be subsumed by coz's build system. For now, I'm hesitant to add any workarounds like this to the Makefile until we're more settled on what our approach to building will be (which should be decided sometime in the next week).
@vchekan Is building with docker an option for you at this point? I also encourage you to join our Gitter channel (https://gitter.im/JCoz-profiler/community) so you can join the discussion on what the best approach is.

@Decave yes, docker is fine. Perhaps worth mentioning on README.md.
Im planning to play with in next week or two and will share experiences.

Ok so 18.04 aka bionic comes with 0.16.3. Debian stretch comes with 0.11.0, and anything newer seems to get 1.3.1.
Are you able to install 1.3.1 for the local install? I'll take a look at the release notes for spdlog.

@vchekan Sounds good, I'll add more comments tomorrow on how to use Docker to build and run the profiler. For now, I'm going to close out this PR if you don't mind.


[Beta 24] Flux generates by itself

As the title says. Details to follow.
In my world I barely dabbled in Thaumcraft. I'ver unlocked the Auromancy, Arcane Infusion and Alchemy tabs and have not progressed in them. I have built but never used a crucible. I have built the materials required to progress in the mod (to unlock above mentioned tabs), but nothing that would drain a chunk's vis to cause flux.
Yet in my base's chunk I have 20 flux in the aura, with surrounding chunks having varied values (some worse, some better).
In case this is relevant, there is a Magical Forest about 12 chunks diagonally. It is not chunk loaded and I do rarely approach that area.
I also pulled up an old world where I haven't even come across vis crystal and the chunks where I spend most of my time have flux in them.
There is some kind of leak...

Almost everything I do create flux... I've realize that too! When I visit a biome or chunk that I've barely use, the flux level is under 0. But anytime my character suffer a special event from thaumcraft, it increase the flux level in that specific chunk. As example, one of the special event make the character throw up some flux goo. Now a few of my nether's chunks have flux because of that.
Moreover, flux use to scatter between chunks. Not sure about the required level, but as soon as one chunk contain 20 pollution points, additional points may be generated in the surrounding chunks instead. Then, I end up with a average 10 pollution points in every chunks around my casual playground. Somehow, when I read vis level, using a thaumometer, or a caster, it looks like if the equilibrium between vis and flux level in a chunk is built to contain a minimum of flux.
Since infusion, alchemy, and using the infernal furnace create flux, sometime I wonder if using an arcane workbench use to create flux too.
Personally once I've learn to live with what goes out of my control, it doesn't bother me much about what are my flux reading in chunks I  barely use. Either way, it will not be high enough to open a rift, as I guess a minimum of 45 points are required to create one. The only negative point about having over 10 flux point inside a chunk is that this flux dramatically reduce Vis crystal farming speed. Also, when I try to clean it up while using flux condenser ± any amount of lattice, the condenser only have influence in the chunk where it stand, and what I've said about flux scatter won't work the other way around. As example, dropping a chunk flux level to 0 who previously was over 70 points, will not lower surrounding chunks flux level. I could have a chunk at level 0 net to one at level 45.
It looks like cleanup is more about prevention than a usable way to fix mistakes. With all the fun and love I have for this mod, good luck and I can't wait to learn if something different is planned about flux cleaning for the next thaumcraft version!

Either way, it will not be high enough to open a rift, as I guess a minimum of 45 points are required to create one. The only negative point about having over 10 flux point inside a chunk is that this flux dramatically reduce Vis crystal farming speed. Also, when I try to clean it up while using flux condenser ± any amount of lattice

@alxcool are you saying it's possible to attain the condenser without forming a rift? I did some testing and the research would not appear for me before I caused a rift.
Did I miss the sweet spot, or is there a special gimmick?

Yet in my base's chunk I have 20 flux in the aura, with surrounding chunks having varied values (some worse, some better).
(...)
I also pulled up an old world where I haven't even come across vis crystal and the chunks where I spend most of my time have flux in them.

Working as intended. Sometimes chunks generate with a random, low flux value. This is not flux you have generated, this is flux that is just part of the world. It is so little that it doesn't negatively affect you at all.
Mind you, 20 flux is rather high for that. Are you sure you don't have any other mods present that hook into Thaumcraft in some way? I've seen reports from multiple people playing large kitchen sink modpacks that state they have gotten warp without ever touching Thaumcraft, and having warp can cause events that can raise the ambient flux levels, as alxcool stated.

Since infusion, alchemy, and using the infernal furnace create flux, sometime I wonder if using an arcane workbench use to create flux too.

It doesn't. Just consuming vis does not make flux appear. Infusion also doesn't usually create flux unless it goes unstable. Alchemy doesn't create flux either - but leaving unused essentia in the crucible will.
There are exactly two unpreventable flux sources, and those are: the infernal furnace (which might produce 2-3 points for a full stack of smelted items), and essentia smelters (which, with upgrades, can be made almost 100% clean, but only almost).

As example, dropping a chunk flux level to 0 who previously was over 70 points, will not lower surrounding chunks flux level. I could have a chunk at level 0 net to one at level 45.

This is something I have noticed too. When a rift eats flux out of a chunk, excess flux from neighboring chunks will start to flow in. But a flux condenser strangely enough does not trigger this equalizing behavior.

I was going to edit my above comment, but I then felt it deserved a separate post:
Update 2: went for some more testing regarding this.  It's hard to me to quantify because it almost immediately spreads to adjacent chunks, but I can guarentee it's at least 3 points of flux.
Using Salis Mundus on items to convert them causes more flux (unsure if it's this action, or fulfilling a milestone requirement in any research topic - most likely fulfilling the requirement). This seems to inject 2.5-3 more points of flux into your chunk all the while reducing your max usable vis.
Actually completing a research milestone (hit "complete" button)? Did nothing, interestingly.
Since getting the dream book to completing the "First Steps" research I was left with 11 flux on the chunk I first fell asleep on to get the book. Unsure on the surrounding chunks as it usually spreads out far.

Nothing in my code should be causing flux for any of the reasons listed above. That is very, very strange.

I've done the exact same testing twice in an instance with just Thaumcraft and Baubles - once near a Magical Forest, the second away from any I could see.
On both situations nothing happened - which is as you say.
It's some interaction with other mods, I guess. I can give you my modlist, if you want.

That would be helpful, thanks.

Below is the modlist.
I copied them to a separate instance and turned off half of them - nothing happened with them off. Out of curiosity I turned them all on (still on the separate instance) and the effect was nowhere to be seen...
I returned to my original instance and repeated the whole ordeal and nothing. I am at a loss. I know nothing of working in Java except buzzwords I picked up over the years, so I want to point my finger at possible memory leaks on my side or something.
AppleSkin-mc1.12-1.0.9.jar
AutoRegLib-1.3-20.jar
Baubles-1.12-1.5.2.jar
BetterFps-1.4.8.jar
BiblioCraft[v2.4.5][MC1.12.2].jar
BiomesOPlenty-1.12.2-<IP_ADDRESS>9-universal.jar
BloodMagic-1.12.2-2.3.3-101.jar
Blur-1.0.4-14.jar
Botania+r1.10-356.jar
Chameleon-1.12-4.1.3.jar
Chisel-MC1.12.2-<IP_ADDRESS>.jar
CodeChickenLib-1.12.2-<IP_ADDRESS>5-universal.jar
CraftTweaker2-1.12-4.1.9.jar
CTM-MC1.12.2-<IP_ADDRESS>.jar
DynamicSurroundings-1.12.2-<IP_ADDRESS>.jar
EnderStorage-1.12.2-<IP_ADDRESS>-universal.jar
extrautils2-1.12-1.9.4.jar
FastLeafDecay-v14.jar
filenames.txt
First trial
foamfix-0.10.2-1.12.2.jar
FTBLib-<IP_ADDRESS>.jar
FTBUtilities-<IP_ADDRESS>.jar
Guide-API-1.12-2.1.6-61.jar
ImmersiveEngineering-0.12-85.jar
intwheel-1.12-1.2.7.jar
InventoryTweaks-1.63.jar
jeiintegration_1.12.2-<IP_ADDRESS>.jar
jei_1.12.2-<IP_ADDRESS>.jar
journeymap-1.12.2-5.5.2.jar
JustEnoughResources-1.12.2-<IP_ADDRESS>.jar
LootBags-1.12.2-2.5.7.jar
MagicalPsi-1.3.jar
Mantle-1.12-<IP_ADDRESS>.jar
mcjtylib-1.12-3.0.5.jar
memory_repo
MetalChests-v3.5.6.g296a413.jar
modtweaker-4.0.14.jar
MouseTweaks-2.8-mc1.12.1.jar
MTLib-3.0.5.jar
mystcraft-1.12.2-<IP_ADDRESS>.jar
mystcraft_info-1.12.2-<IP_ADDRESS>.jar
NaturesCompass-1.12.2-1.5.1.jar
OpenBlocks-1.12.2-1.8.jar
OpenModsLib-1.12.2-0.12.jar
Pam's+HarvestCraft+1.12.2z.jar
plustic-<IP_ADDRESS>.jar
Psi-r1.1-59.jar
Quark-r1.5-130.jar
RedstoneFlux-1.12-<IP_ADDRESS>-universal.jar
Reliquary-1.12.2-<IP_ADDRESS>7.jar
rflux-1.12-0.3.0.jar
rftools-1.12-7.56.jar
SBM-WoodenShears-1.12-0.0.1b8.jar
SpiceOfLife-mc1.12-1.3.12.jar
StorageDrawers-1.12.2-5.3.7.jar
TConstruct-1.12.2-<IP_ADDRESS>.jar
Thaumcraft-1.12.2-6.1.BETA24.jar
ThaumicInventoryScanning_1.12.2-2.0.10.jar
ThaumicJEI-1.12.2-1.5.3-20.jar
theoneprobe-1.12-1.4.24.jar
topaddons-1.12.2-1.7.0.jar
twilightforest-1.12.2-3.8.689-universal.jar
Waystones_1.12.2-4.0.62.jar
xnet-1.12-1.7.4.jar

Regardless of random flux generation not being hard coded it really seems to exist... random parts of the world will have flux in them for no apparent reason. Yes... "very, very strange".

I've just found out about the existence of flux sponges. I cheated one in and went around flying in creative on my nearby chunks. I drained no less than 1000 flux from the chunks nearby that I could monitor using a dioptra. This is a ridiculous number on a fresh world that - I repeat - hasn't even seen a vis crystal be harvested.
Thaumcraft progression has not been started and that's what I had to clean. Either mod interaction or something else is causing this. I'll keep playing for now and later on I'll monitor the situation again (I'm thinking of only starting Thaumcraft after I get out of my cave and can start traveling to Mystcraft ages).
Since I am very convinced this will happen again, at that point, would you like to zip my save and upload it? Maybe some other files/folders from the instance?

Update: still have not started a single crystal...

I have exactly same issue a you and i share some mods with yours, but none of them have anything to do with TC (like TOP, JEI, Bibliocraft).
The Flux simply generates in ridiculous amounts out of nowhere for no reason. On my fifth busywork of being a magical janitor walking around base scrubbing Flux away i found out that it doesn't generate in some janky buggy manner like suddenly going up to 20, it's a deliberate process. I've set up a flux remover, fed it Herba, whipped out Thamometer, and the Flux was just going 10...11...10...11...12...13 etc. outpacing the Scrubbers attempts to remove it.
I've since just cheated in sponge and regularly remove around 500-800 flux every few ingame days despite barely using Furnace and staying away from Mirrors because i have enough Flux generate by itself to bother with additional sources.

Interstingly, I cannot reproduce this on a flat creative world I use for testing.
I had that world with the day cycle turned to false and I read here that flux is to be generated with the high vis values, and the lunar cycle. I cannot find ingame documentation suporting this, but I turned the day/night cycle back on, planted a Silverwood tree and just sat there afk for hours - nothing happens on that world.
I cannot find a pattern on what causes this, but it can happen on any dimension so far (End, Nether). I've recently dumped the Overworld in favor of a Mystcraft age. I dread the thought of picking up a Thaumometer and see what me building my new home has done to the aura...


Indexed references

Treat indexed references as first class references
Indexed lenses : at, contains, resultAt
iwhereOf : filters the accessed elements based on an index
ibackwards, itakingWhile, idroppingWhile, isplitting, ...
reindex: applies a function on the index
<.> : combine indexed references


Add vuexi

Vuexi is a library to enhance developer agility working on vuex async actions

I wrote down a little bit more in README.md

@LinusBorg


Please invite me to the GitHub Community Organization

Name
Chidubem Jonah
Discord Username (if applicable)
Bobmaintain
Additional Context
To learn and share knowledge

Thank you


Unable to load the website after generating a layout

I made a long layout located in this gist, and was able to upload it to the website, but it timed out and gave an error saying something along the lines of being unable to receive build status of the project.
Attempting to reload brings up this error in firefox:

I just tried again, and this error occurs
Traceback (most recent call last):
File "/kicad/src/tasks.py", line 71, in generate_kicad_project
log_path = kicad.new_pcb(task_id, task_request, __update_percentage)
File "/kicad/src/kicad.py", line 280, in new_pcb
generate_pcb_file(project_full_path, project_name)
File "/kicad/src/kicad.py", line 122, in generate_pcb_file
raise Exception(f"Generate .kicad_pcb from netlist failed: details: {log}")
Exception: Generate .kicad_pcb from netlist failed: details: ./kicad/pcbnew/action_plugin.cpp(163): assert "PgmOrNull()" failed in register_action().
Unable to find footprint Stabilizer_Cherry_MX_2u in /kicad/e57f1ae3-3e5d-421e-866b-2b0dc980e875/keyboard/libs/keyswitch-kicad-library/footprints/Mounting_Keyboard_Stabilizer.pretty
Unable to find footprint Stabilizer_Cherry_MX_2u in /kicad/e57f1ae3-3e5d-421e-866b-2b0dc980e875/keyboard/libs/keyswitch-kicad-library/footprints/Mounting_Keyboard_Stabilizer.pretty
Unable to find footprint Stabilizer_Cherry_MX_2u in /kicad/e57f1ae3-3e5d-421e-866b-2b0dc980e875/keyboard/libs/keyswitch-kicad-library/footprints/Mounting_Keyboard_Stabilizer.pretty
Unable to find footprint Stabilizer_Cherry_MX_2u in /kicad/e57f1ae3-3e5d-421e-866b-2b0dc980e875/keyboard/libs/keyswitch-kicad-library/footprints/Mounting_Keyboard_Stabilizer.pretty
Unable to find footprint Stabilizer_Cherry_MX_2u in /kicad/e57f1ae3-3e5d-421e-866b-2b0dc980e875/keyboard/libs/keyswitch-kicad-library/footprints/Mounting_Keyboard_Stabilizer.pretty
Unable to find footprint Stabilizer_Cherry_MX_6u in /kicad/e57f1ae3-3e5d-421e-866b-2b0dc980e875/keyboard/libs/keyswitch-kicad-library/footprints/Mounting_Keyboard_Stabilizer.pretty

This is with the following options and using the layout in the gist linked above:

Matrix: Automatic
Footprints: MX
Routing: Full
Controller circuit: None

thank you for reporting, based on the log it is related to https://github.com/adamws/keyboard-tools/issues/10 issue
something is definitively buggy, I will have a look in my spare time

@mrwm Give it a try now, I just deployed v0.3
There were two problems you encountered:

wrong stabilizer footprint name for MX switches (6fa7c8732627f8574aa862ce3927ebff881051ea)
poor performance. Some big layouts could hog server. I'm running this on 1CPU 1GB RAM machine. I found out that one of the dependencies were consuming a lot of resources - in worst case scenario it could even crash server. It should be better now<PHONE_NUMBER>6fd4555e5b6f312e03d6d4217956d2)

I've run your layout (from first message) and it succeed.
It would fail if you try to use  Controller circuit: ATmega32U4 option but that is an issue for another day.

I just tried it out, and I don't see any errors anymore. I didn't realize that long layouts could become a form of stress test, haha :sweat_smile:


observe/catch a link click inside email or hangout

would it be possible to attach/observe link clicks in the email or ... on the hangout popup menu?
Thank you

Not planned or currently in scope.
If a reasonable use-case can be presented, PRs may be considered ok.


Multiple tables

In this PR I did the following:

[ ] Created a table named owners with columns, id: integer, full_name: string, age: integer
[ ]  Created a table named species, id: integer, name: string
[ ] Modified animals table: Removed column species, Add column species_id , Add column owner_id
[ ] Inserted data into the owner's table.
[ ] Inserted data into the species table.
[ ] Modified inserted animals so it includes the species_id value
[ ] Modified inserted animals to include owner information owner_id

Wrote queries to answer questions:

[ ] What animals belong to Melody Pond?

[ ] List of all animals that are pokemon (type is Pokemon).

[ ] List all owners and their animals, including those that don't own any animal.

[ ] How many animals are there per species?

[ ] List all Digimon owned by Jennifer Orwell.

[ ] List all animals owned by Dean Winchester that haven't tried to escape.

[ ] Who owns the most animals?

Hi, @afanimartin,
there is no linters config for this specific project,, Kindly assist if I'm mistaken..
Regards


AllowFipsAlgorithmPolicy is misleading

I think this policy should be called "EnableFipsAlgorithmPolicy", as the behaviour I've experienced by enabling the policy within InTune (Device Config Profiles --> Win10 Device Restriction -->Properties --> Settings --> Password --> "Federal Information Processing Standard (FIPS) policy) when I set it to "Allow" seemed to set the registry key "HKLM\SYSTEM\CurrentControlSet\Control\Lsa\FipsAlgorithmPolicy:MDMEnabled" to 1.
Setting the policy to 'Not configured' does not set the corresponding registry key to 0, and FIPS mode stays on.
Also note that the Group Policy setting "Windows Settings/Security Settings/Local Policies/Security Options/System cryptography: Use FIPS-compliant algorithms for encryption, hashing, and signing" corresponds to a different registry key: "HKLM\SYSTEM\CurrentControlSet\Control\Lsa\FipsAlgorithmPolicy:Enabled".
FIPS mode will be on if either of the keys is set to 1 (and in fact there are 2 other keys that do the same)
I suggest the Policy is renamed, the settings are change to Enable and Disable, and that when set to Disable the corresponding registry key is set to 0.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b290a291-ccb6-953f-0679-2a56a927620e
Version Independent ID: 6a86d25c-12ea-1f8d-2758-4d13352e7718
Content: Policy CSP - Cryptography - Windows Client Management
Content Source: windows/client-management/mdm/policy-csp-cryptography.md
Product: w10
Technology: windows
GitHub Login: @ManikaDhiman
Microsoft Alias: dansimp

@dancs85 I agree with your points. but renaming I have doubt

This feedback seems to be better suitable for Feedback Hub platform.
The issues section of this repository is intended for content fixes.
Please send the feedback to Microsoft with the Feedback Hub app
Feel free to re-open this issue if for further suggestions to improve the documentation itself.
Thanks.


support stablecoins

Most of the FTs on Bitcoin are garbage, with stablecoins being the exception. However, stablecoins require the ability to limit the issuer and open up the issuance time window. Is it possible for Runes to support this?

When a rune is etched, the creator can specify that it is not an open mint, and allocate the entire supply to themselves. For later issuance, the creator can mint a very large number of runes, and put it in cold storage, and transfer runes out of cold storage in order to issue more of the stablecoin.


DOTNETCORE|Latest runtime issue with az webapp config set

I noticed that if you update the Linux FX Version to Stack '.NetCore' and MajorVersion 'Latest' in the azure portal (App Service->Configuration->General Settings)
when you run the command:
az webapp config show --resource-group rg --name webapp
The value returned in the json is:
"linuxFxVersion": "DOTNETCORE|latest"
with 'latest' in full lowercase.
When you run az webapp list-runtimes --linux the suggested string is 'DOTNETCORE|Latest' with slightly different casing of 'Latest'
If you try to update the app service stack via the command:
az webapp config set --resource-group rg --name webapp --linux-fx-version "DOTNETCORE|Latest"
The command succeeds but navigating to App Service->Configuration->General Settings in the azure portal does not highlight the Stack and MajorVersion as expected, displaying empty drop downs.
Whereas after running the command (lower case 'l')
az webapp config set --resource-group cs-test-application-linux-syd --name cs-api-test-mel --linux-fx-version "DOTNETCORE|latest"
Navigating to App Service->Configuration->General Settings in the azure portal does highlight the correct Stack and MajorVersion
Just want to confirm if this is a known issue and whether the names can be made consistent in az webapp list-runtimes.

taking a look in to this.

should be fixed by https://github.com/Azure/azure-cli/pull/13688


Error in SyntaxNode

Describe the bug
This came from testing against the ATR model
To Reproduce
A short code snippet of what you have ran. Please change or remove any specific values or anything that can't be public. For example:
problem = montepy.read_input("tests/models/3region_freshfuel.imcnp")

Error Message (if any)
In [3]: problem = montepy.read_input("tests/models/3region_freshfuel.imcnp")
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Cell In[3], line 1
----> 1 problem = montepy.read_input("tests/models/3region_freshfuel.imcnp")

File ~/dev/montepy-test/montepy/input_parser/input_reader.py:31, in read_input(destination, mcnp_version, replace)
     29 problem = mcnp_problem.MCNP_Problem(destination)
     30 problem.mcnp_version = mcnp_version
---> 31 problem.parse_input(replace=replace)
     32 return problem

File ~/dev/montepy-test/montepy/mcnp_problem.py:303, in MCNP_Problem.parse_input(self, check_input, replace)
    301         self._transforms.append(obj)
    302 if trailing_comment is not None and last_obj is not None:
--> 303     obj._grab_beginning_comment(trailing_comment)
    304     last_obj._delete_trailing_comment()
    305 trailing_comment = obj.trailing_comment

File ~/dev/montepy-test/montepy/data_inputs/importance.py:379, in Importance._grab_beginning_comment(self, new_padding)
    377 for part, tree in self._particle_importances.items():
    378     if last_padding is not None and last_tree is not None:
--> 379         last_tree._grab_beginning_comment(last_padding)
    380         self.__delete_common_trailing(part)
    381     last_padding = tree.get_trailing_comment()

AttributeError: 'SyntaxNode' object has no attribute '_grab_beginning_comment'

MCNP input file snippet
TODO
Version

Version 0.4.2

Additional context
This is incomplete and a MwE will take some work to create.

Moving everything to #580.


Solid regular function components

Solid js regular function component dont accept the component type. But it is a really good thing to have.
function App(props): Component {       return <div> {props.children} </div> }

That's typescript I think. You are trying to accomplish the equivalent of this right:
const App: Component = (props) => {
  return <div>{props.children}</div>
}

But what you wrote says that the function returns a Component rather than is a Component, which it doesn't. TypeScript not supporting typing functions like this is just a shortcoming of TypeScript. Same issue in React or any function component based system.

I recommend using the const syntax, but you can also do function App(props): JSX.Element

As far as I can tell there is no action to be taken here. Thanks for creating the issue.


add missing interface paths

Added some missing paths and removed ipv6 multicast counters as those are not yet implemented in OC.
Updated relevant readme for test with mdlint and removed the reference to IPv6 multicast counters

Pull Request Functional Test Report for #1513 / 90a3f774cdc1e51ea99da5c417202246635fd913
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

RT-5.1: Singleton Interface

Cisco 8000E

RT-5.1: Singleton Interface

Cisco XRd

RT-5.1: Singleton Interface

Juniper cPTX

RT-5.1: Singleton Interface

Nokia SR Linux

RT-5.1: Singleton Interface

Openconfig Lemming

RT-5.1: Singleton Interface

Help


HHH-18111 Call EventManager for stored procedures

https://hibernate.atlassian.net/browse/HHH-18111

Please rebase

Thanks!


Refactor Database and SQL files structure

Fixes #2

Hi @punith1213,
Thank you so much for taking the time to review and suggest improvements to the stored procedures in my project. I truly appreciate the thought and effort you put into expanding the functionality, especially the additional fields and the new procedures.
While your suggestions are insightful and would undoubtedly enhance the flexibility of the database layer, I have concerns about privacy and data minimization. Specifically, I’ve intentionally avoided including fields like account creation date, last connection date, and locale to limit the exposure of potentially sensitive user information. This approach aligns with the principles I aim to follow in protecting user privacy within this project.
That being said, your ideas for additional procedures like filtering by locale and retrieving engagement data are fantastic and could be incredibly useful for future developments where privacy concerns are addressed differently. I’ve taken note of your contributions and may revisit them later if the project’s goals or requirements evolve in a way that aligns with your suggestions.
Thanks again for your input—it’s always great to have collaborators who bring fresh perspectives to the table!
Best regards,
@Vianpyro

If you need any assistance, feel free to reach out to me.

Thank you! Adding the email in the selected rows gave me the idea to add it masked!

CREATE OR REPLACE PROCEDURE get_all_persons()
BEGIN
SELECT
person_id,
name,
CONCAT(SUBSTRING(email, 1, 2), '***', SUBSTRING_INDEX(email, '@', -1)) AS masked_email,
registration_date,
last_login,
locale_id
FROM person;
END //
Explanation:
SUBSTRING(email, 1, 2): Extracts the first two characters of the email address.
'***': Adds asterisks as the mask.
SUBSTRING_INDEX(email, '@', -1): Extracts everything after the @ symbol (domain name).
CONCAT(...): Combines the masked part and the domain name to form the masked email.
Usage in Procedures:
You can apply this masking in your stored procedures where the email is selected.


Clean Boot Messages - UA masked off

Codecov Report

Merging #1305 (00425d7) into image_v2.7 (db05de6) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           image_v2.7    #1305   +/-   ##
===========================================
  Coverage       46.49%   46.49%
===========================================
  Files              28       28
  Lines            4951     4951
  Branches          826      826
===========================================
  Hits             2302     2302
  Misses           2592     2592
  Partials           57       57

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db05de6...00425d7. Read the comment docs.


remove unused devDependencies

@haxxmaxx  Can I merge now? or Do we need Tobias and Henrik's approval as well?

@haxxmaxx  Can I merge now? or Do we need Tobias and Henrik's approval as well?

No need for more approvals, but the test are not running no Circle CI today for some reason, we want those to pass before merging

No need for more approvals, but the test are not running no Circle CI today for some reason, we want those to pass before merging


Fail to parse empty case

foo x = case x of
bar = undefined
Gives a parse error. See https://github.com/haskell/haskell-ide-engine/issues/967 for more.

Confirmed works with HEAD that doesn't use HSE for parsing, so fixed in the next release.


Turn off rendering lower floors when "upstairs"

Hi there! This is a request for the low detail plugin; disable rendering lower levels of the map. Going upstairs in Zeah, especially to 3rd floor of Kourend Castle and Arceus Library really impacts my FPS because it's rendering all of the lower floors.
This was a feature with the low detail setting back in old RS2, which you had to pick on the website (http://i.imgur.com/Z95tbmO.png) as there was no in-game settings for graphics back so that explains why OSRS has nothing like this. I think it was finally added to the in-game settings after the RS HD update and was labeled "visible levels." if you disabled it, you would just see a black void instead of the lower floors.
It would be highly appreciated if such a feature could be added to the client. Places like Zeah are just too harsh on my CPU after I've climbed a few floors.
Anyway, thank for your time. Apologies for the bad writing in this post, my English isn't that great. T_T

added in 1c191f005b9c25ae8d1591d9373d516107d3d35b


How can work with ExtendedTextBox?

There are few fields in our application with ExtendedTextBox class type. It looks like as usual text field, but performs some specific functions.
ClassName: ExtendedTextBox
ControlType: ControlType.Custom
This ExtendedTextBox contains internal form with not defined ClassName.
I can successfully find both of them:
External form:
winDriver.findElementByAccessibilityId("formName");
Internal form:
winDriver.findElement(By.xpath(".//*[@AutomationId='#formName']//*[@ClassName='']"))
But, I cannot use methods senKeys() or clear() for type or clear text.
I getting error:
HTTP/1.1 500 Internal Error
Content-Length: 133
Content-Type: application/json
{"status":13,"value":{"error":"unknown error","message":"An unknown error occurred in the remote end while processing the command."}}
I've tried set cursor in field before sendKey
actions.moveToElement(element).click().build().perform();
But it not work
How can work with ExtendedTextBox?

@erohinalexey Use paste to set text
https://stackoverflow.com/questions/15141430/selenium-paste-text-into-textarea

Set text to Clipboard
Click on field
Clear field using Ctrl + A, then Delete
Paste text into field using Ctrl + V

C# code:
public void CopyPaste(IWebElement element, string text)
{
	Clipboard.SetText(copy);
	element.Click();
	Thread.Sleep(100);
	element.SendKeys(OpenQA.Selenium.Keys.Control + "a" + OpenQA.Selenium.Keys.Delete);
	Thread.Sleep(100);
	element.SendKeys(OpenQA.Selenium.Keys.Control + "v");
}

@erohinalexey Use paste to set text
https://stackoverflow.com/questions/15141430/selenium-paste-text-into-textarea

Set text to Clipboard
Click on field
Clear field using Ctrl + A, then Delete
Paste text into field using Ctrl + V

C# code:
public void CopyPaste(IWebElement element, string text)
{
	Clipboard.SetText(copy);
	element.Click();
	Thread.Sleep(100);
	element.SendKeys(OpenQA.Selenium.Keys.Control + "a" + OpenQA.Selenium.Keys.Delete);
	Thread.Sleep(100);
	element.SendKeys(OpenQA.Selenium.Keys.Control + "v");
}

Thanks, but the main troubles are: both sendKey() and clear() methods are not work for this field.


Maker stops sending heartbeat and orders

The maker stopped sending orders and heartbeat.
It looks like he dropped connections to takers which are constantly being reestablished but we don't send any heartbeats or orders
Last message was sent at "timestamp":"2022-04-05T19:49:36.316154252Z

I've looked into this but we don't have any other logs here unfortunately. I am closing this as unactionable :/


Specify what to use for jsxFragment option on build

This is hoping to solve the issue I encountered in https://github.com/visgl/react-google-maps/issues/2
The previous build would produce:
import React$1, { useState, useMemo, useEffect, useCallback, useContext, useLayoutEffect, forwardRef, useImperativeHandle, Children, useRef } from 'react';

After this change it produces:
import React, { useState, useMemo, useEffect, useCallback, useContext, useLayoutEffect, forwardRef, useImperativeHandle, Children, useRef } from 'react';

This is important because the code a fragment produces is:
return /*#__PURE__*/React.createElement(React.Fragment, null);

Which would cause an error that said React is not defined when imported as React$1. Perhaps there is another way to fix this, but I am not super familiar with microbundle.
Here is a microbundle issue referencing the same React reference import error: https://github.com/developit/microbundle/issues/809
This also pointed me towards this direction: https://www.fabiofranchino.com/log/how-to-use-microbundle-with-react-and-avoid-reference-error/

@leighhalliday Thanks a lot for spotting this! I haven't tried it in a next.js context yet..
If you spot more problems with it (especially regarding SSR and such), please let us know!

I just published your fix in version 0.0.4, can you retest if the problem persists?


Cannot read property 'httpHost' of undefined

Receiving this error:
[03/11/2020, 19:56:56] [eWeLink] *** Disabling plugin [v3.10.0] ***
[03/11/2020, 19:56:56] [eWeLink] Cannot read property 'httpHost' of undefined
I just changed from Ewelink-Max to Ewelink because of other issues. Worked good for a few days, but now run into this issue.
[03/11/2020, 20:00:16] [eWeLink] Plugin [v3.10.0] initialised. Syncing with eWeLink...
[03/11/2020, 20:00:16] [eWeLink] Sending HTTP getHost() request. This text is yellow for clarity.
{
"appid": "oeVkj2lYFGnJu5XUtWisfW4utiN4u9Mq",
"country_code": "+32",
"nonce": "jsf8rc91",
"ts":<PHONE_NUMBER>,
"version": 8
}
[eWeLink] Sending HTTP login() request. This text is yellow for clarity.
{
"countryCode": "+32",
"password": "hidden",
"email": "hidden"
}
[eWeLink] Sending HTTP login() request. This text is yellow for clarity.
{
"countryCode": "+32",
"password": "hidden",
"email": "hidden"
}
[eWeLink] *** Disabling plugin [v3.10.0] ***
[03/11/2020, 20:00:22] [eWeLink] TypeError: Cannot read property 'httpHost' of undefined
at new eWeLinkWS (/usr/local/lib/node_modules/homebridge-ewelink/lib/ewelink-ws.js:15:25)
at eWeLinkPlatform.eWeLinkSetup (/usr/local/lib/node_modules/homebridge-ewelink/lib/ewelink-platform.js:79:23)
at processTicksAndRejections (internal/process/task_queues.js:93:5)

Double


Fastapi: Url with path param without replacement in profiles_sampler and/or before_send_transaction

Problem Statement
Hi all,
Is it possible to get the original path without path params replacement in either the profile_sampler or before_send_transaction for a fastapi integration?
We are trying to filter out some transactions and we have generated a list of all the paths we want to exclude/subsample.
E.g. one would be /streams/status/{camera}/data/{lens} . However, in both functions' arguments dicts I can only see the url with the replaced path param (e.g.   /streams/status/myCamera/data/myLens) which can't really be compared against the string value of the route.
The transaction name is correctly reported without replacement in sentry, but I don't seem able to find that value in either transaction_context nor event. Am I missing something?
Solution Brainstorm
I think it would be really helpful to have this value included so it can be used for subsampling and filtering

Hey @lucabergamini, thanks for writing in.
In before_send_transaction, the first argument (the event) has the unfiltered URL (not just the path) in event["request"]["url"].
In profiles_sampler you get the sampling context as the sole argument and the path should be in sampling_context["asgi_scope"]["path"].
Let me know if that helps.

Hi @sentrivana
thanks for the reply. That indeed works, but I've realised something after writing the original question.
before_send_transaction is called at the very end of the endpoint lifespan. That means that I won't be able to control the sampling and all endpoints call will be traced. This would cause a performance issue In our prod env.
profile_sampler seems to be called before. However the issue with that is that is called before everything else as far as I know, so even before fastapi url resolution. I've tried adding a middleware to inject context, but I believe that does not work exactly for this reason.
Is there any way to get any info to the profile_sampler or to postpone its evaluation? Currently, I resorted to running the path resolution in the function itself (which works, but it's a bit clunky)

@lucabergamini I think what you want is actually a custom traces_sampler -- it allows you to set the sampling decision for a transaction at an earlier point than before_send_transaction and afaik prevents child spans from being created if not sampled.
That being said, the traces_sampler callback happens at virtually the same point in time as profiles_sampler (with the same sampling context as well) so if you're missing information in the profile sampling context, you'll have the same issue with the traces_sampler. If you need more than the path in the sampling context, you might indeed need to get any additional info in the function itself, as you wrote.

Hi @sentrivana, that makes perfect sense, thanks for your support.
I'll close this as I consider it solved.


PENDING action not dispatched

Version Number
4.2.0
Code Example
const setVariable = (variable) => ({
  type: 'SET_VARIABLE',
  payload: new Promise(resolve => {
    setTimeout(() => {
      resolve(variable);
    }, 3000);
  }),
});

Expected Behavior
See the following actions dispatched:
SET_VARIABLE, then SET_VARIABLE_PENDING, then after 3s, SET_VARIABLE_FULLFILLED
Actual Behavior
SET_VARIABLE, then after 3s, SET_VARIABLE_FULLFILLED.

SET_VARIABLE shouldn't be dispatched.
Only SET_VARIABLE_PENDING and SET_VARIABLE_FULFILLED.
How have you added the middleware?

Yes, somewhere in the store definition I have applyMiddleware(promiseMiddleware()). It works because SET_VARIABLE_FULFILLED gets dispatched, I didn't create this action type.

Can you share your store config?

On May 06, 17, at 05:13, Amaury Martiny<EMAIL_ADDRESS>wrote:
Yes, somewhere in the store definition I have applyMiddleware(promiseMiddleware()). It works because SET_VARIABLE_FULFILLED gets dispatched, I didn't create this action type.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/pburtchaell/redux-promise-middleware/issues/153#issuecomment-299629874, or mute the thread https://github.com/notifications/unsubscribe-auth/ADrbrFM1lohgU_zJOxyBIi_hhMrpqZTrks5r3EfDgaJpZM4NSsNQ.

import { createStore, applyMiddleware, compose } from 'redux';
import thunk from 'redux-thunk';
import promiseMiddleware from 'redux-promise-middleware';
import { createLogger } from 'redux-logger';
import { autoRehydrate, persistStore } from 'redux-persist';

import rootReducer from './reducers';
import { AppActions } from './ducks/App';

// Creates the store
const configureStore = () => {
  /* ------------- Redux Configuration ------------- */

  const middleware = [];

  // Add redux-logger in dev mode
  if (process.env !== 'production') {
    middleware.push(createLogger());
  }
  const enhancers = [];

  /* ------------- Thunk Middleware ------------- */

  middleware.push(thunk);

  /* ------------- Promise Middleware ------------- */

  middleware.push(promiseMiddleware());

  /* ------------- Assemble All Middlewares ------------- */

  enhancers.push(applyMiddleware(...middleware));

  /* ------------- AutoRehydrate Enhancer ------------- */

  // Add the autoRehydrate enhancer
  enhancers.push(autoRehydrate());

  const store = createStore(rootReducer, compose(...enhancers));

  // Begin periodically persisting the store
  persistStore(store, {
    whitelist: ['auth'],
  }, () => store.dispatch(AppActions.setAppLoaded(true)));

  return store;
};

export default configureStore;

That looks correct to me. Apologies but I haven't used the latest version. Can you please try changing the promise value to be for a key called promise in the payload.
from:
const setVariable = (variable) => ({
  type: 'SET_VARIABLE',
  payload: new Promise(resolve => {
    setTimeout(() => {
      resolve(variable);
    }, 3000);
  }),
});

to:
const setVariable = (variable) => ({
  type: 'SET_VARIABLE',
  payload: { promise: new Promise(resolve => {
    setTimeout(() => {
      resolve(variable);
    }, 3000);
  }) },
});

If the problem is still there after that. Next try installing redux-promise-middleware@2 to see if the problem still happens in that version too.
I can't see any path in the code that would lead to _FULFILLED being dispatched without a _PENDING first... are you absolutely certain that the first action type has no suffix??

Mysterious. I tried the two ways, I tried version 2, but always the same result:

I tried to play a bit with the code, and using dispatch instead of next does dispatch the PENDING action. The APP_LOADED, APP_LOADED_PENDING and APP_LOADED_FULFILLED are all dispatched. I'm not aware of all the repercussions it can have though, so I'm not 100% sure it's a good idea.

You're adding the redux logger as the first middleware. Add the logger middleware after the redux-promise-middleware to see which actions it dispatches.

Ha of course! Thanks tomatau.


Recipe App

Description
We are a team of two members: @leloufadel  and @ClarenceAtim .
We have created this app to keep track of recipes and ingredients. We also allowed to make recipes public.
Features Implemented
A login page built with devise.
A registration page built with devise.
A food list (with all CRUD implementation, except for 'update').
Displays a list of food added by the logged-in user as in the wireframe, also quantity of a given food.
Leads to a form that allows users to add new food.
Recipes list (with all CRUD implementation, except for 'update'):
Displays a list of recipes created by the logged-in user as in the wireframe.
Leads to recipe details.
If the user is the owner of the recipe, allows the user to delete it.
Public recipe list:
Displays a list of all public recipes ordered by newest as in the wireframe.
Leads to recipe details.
Recipe details:
Displays a toggle button that allows for a recipe to be made public or private.
If the recipe is public or the user is the owner of the recipe, displays the recipe details as in the wireframe.
If the user is the owner of the recipe, leads to the form that allows the user to add new food.
General shopping list view (only for a group that has less than 3 members):
Shows the list of food that is missing for all recipes of the logged-in user.
Should count the total food items and total price of the missing food.
Eager loaded to make sure there are no N+1 queries happening.
A navigation menu that allows users to open all of the pages created.
Unit and integration tests

Remove confirmation for Email.


About spurious wake-up in keepalive thread

-File: StunCandidateHarvest.java
-Funcation: runInSendKeepAliveMessageThread
-Code:
if (timeout > 0)  {
                try
                {
                    sendKeepAliveMessageSyncRoot.wait(timeout);
                }
                catch (InterruptedException iex)
                {
                }
                /*
                 * Apart from being the time to send the STUN keep-alive
                 * message, it could be that we've experienced a spurious
                 * wake-up or that we've been canceled.
                 */
                return true;
}

My question is:
Why don't we change the if into while and recalculate the timeout value to fix the spurious wake-up issue here ? (I did this and testing is pass) Something I have missed ?
If we just return ture here, then means we never send keepalive message to server side.
So that server side will close the channel after timeout...

If we just return ture here, then means we never send keepalive message to server side.

No, as the method's doc says returning true means that the method should be invoked again (resulting in the timeout being re-calculated as you suggest. And indeed this is how it's used.

Hello bgrozev,
Thanks for your reply.
We can find out that the sendKeepAliveMessageTime value only will be set if we do not return ture.
So in the next round, the sendKeepAliveMessageTime still is -1, so that the timeout seams never being re-calculated.
And server side can not see any REFRESH method from the client during my testing, util i changed the code as i said before.


Module/Mission Initialization Overhaul

Short Summary
As developer/contributor I want to have an easy and reliable way to implement new features, so that I've to edit as less files as possible of the existing framework to add my enhancements.
Description
The current implementation of the mission initialization is not that bad, but still needs too much places to "register a module":

https://github.com/KillahPotatoes/KP-Liberation/blob/v0.97/Missionframework/init.sqf#L36
https://github.com/KillahPotatoes/KP-Liberation/blob/v0.97/Missionframework/KPLIB_functions.hpp#L16
https://github.com/KillahPotatoes/KP-Liberation/blob/v0.97/Missionframework/KPLIB_ui.hpp

The functions and ui hpp files can't be eliminated, but the entries in the init.sqf could be replaced with a postInit attribute for a "init function" for each module. Maybe we can expand this in a later stage to a "auto registering" of available modules, but for now we should eliminate the init.sqf dependency for modules.
Also a closer look of the current initServer, initPlayerLocal and init could be a good idea. We should get rid of all these waitUntils (especially in the init.sqf) in the end.
Sub-Tasks

[ ] Create initialization functions for each module
[ ] Remove the current initialization calls in the init.sqf
[ ] Implement the functions as postInit functions in the module functions library
[ ] Have a look for a possibility to improve the mission initialization
[ ] Share research results and/or implement the possible tweaks

This is kind of connected to the refactoring / overhaul we'll do in #467


Uniform Theme For website

Pull Request: Establish Uniform Theme with Color Codes
Issue: #123
Uploading bandicam 2024-10-28 11-40-19-780.mov…
Hi  @rishicds
Summary
This pull request aims to implement a consistent design theme across the website, drawing inspiration from the Google Developer Student Club's branding. The primary background color has been set to #1D4ED8 (bg-blue-500), with #1E40AF (bg-blue-600) designated as the secondary color to ensure a cohesive and polished look throughout all pages.
Changes Made

Color Consistency: Implemented the primary color #1D4ED8 for key components and #1E40AF as a secondary color, ensuring a uniform design across the website.
Typography: Established consistent font styles and sizes for headings, body text, and buttons to enhance readability and maintain a unified appearance.
Reusable Components: Developed reusable UI components (such as buttons and cards) that align with the established design principles, promoting consistency and efficiency in the codebase.
Spacing & Alignment: Standardized margins and paddings across various elements to achieve a balanced and visually appealing layout.
Responsive Design: Ensured all design elements are responsive, maintaining a consistent look across different devices and screen sizes.

Testing

Verified the rendering of all components across multiple browsers and devices to ensure visual consistency.
Conducted usability testing to confirm that the new design enhances user experience without introducing any issues.

Additional Notes
This theme enhancement is intended to create a visually appealing and cohesive user interface. Future updates may include expanding the color palette to incorporate additional accent colors.

can u upload video once it hasnt been uploaded

https://github.com/user-attachments/assets/a6f373d1-5682-42e0-ae7d-e7b8fa969e94

Hi @rishicds , let me know if any further changes are needed.

Hi @rishicds , please check my PR.

fix conflicts please

upload a video after fixing conflicts, new header should be there

@dev129 can you send  a screenshot that will suffice no need video

theme already settled


Add a Web Dynpro ABAP App to Your Portal Site

Tutorial URL: https://developers.sap.com/tutorials/cp-portal-cloud-foundry-webdynpro-app.html
Please specify the step you are referring to
Step 5:
4. In the Purchase Orders group, click the Web Dynpro ABAP app called Search POs to launch it.
I have followed all the steps as suggested but after launching I am getting the below error:
"Service cannot be reachedWhat has happened?URL call was terminated because the corresponding service is not available.
NoteThe termination occurred in system with error code 404 and for the reason Not found.

What can I do?Select a valid URL.HTTP 404 - Not foundYour SAP Internet Communication Framework Team"

Hi
Please share an image of your destination configuration and also 2 images of your app configuration (both main screen and navigation configuration)
Please also add a screenshot from after your launch the app and include the URL in it
Thanks

Thank you for your feedback. We haven't heard from you in a while, so we are closing the issue.
If you still have questions, feel free to reopen the issue.


configuration

Hello,
you write in the readme that you can set which options you want to have synchronized, what is the default? That everything is synchronized?
Among the suggestions is also listed "snippets" is that a specific add-on?

By default, syncSettings.resources is ["extensions", "keybindings", "settings", "snippets", "uiState"]. So every resources are synchronized.
User Snippets: https://code.visualstudio.com/docs/editor/userdefinedsnippets#_create-your-own-snippets


cpp-netlib can't build in visual studio 2013

My system is Windows 7, I download the cpp-netlib 0.12.0-final, and my boost is 1.60, I use cmake to generate visual studio 2013 project, but there are some error, i try to repair some error.
cpp-netlib-0.12.0-final\boost\network\message.hpp
basic_message(const basic_message&) = default;
basic_message(basic_message&&) = default;
basic_message& operator=(basic_message const&) = default;
basic_message& operator=(basic_message&&) = default;
I dedele "= default"
cpp-netlib-0.12.0-final\boost\network\protocol\http\client\async_impl.hpp
~async_client() throw() = default;
changed:
~async_client() = default;
cpp-netlib-0.12.0-final\boost\network\protocol\http\client\connection\async_protocol_handler.hpp
debug_escaper(debug_escaper const&) = default;
debug_escaper(debug_escaper&&) noexcept = default;
changed:
debug_escaper(debug_escaper const&);
debug_escaper(debug_escaper&&);
But there are some othre question I can't resolve.
cpp-netlib-0.12.0-final\boost\network\protocol\http\client\connection
351:  callback(make_iterator_range(begin, end), ec);
420:  callback(make_iterator_range(begin, end), ec);
visual studio show can't convert type:
boost::iterator_range<std::_Array_const_iterator<_Ty,1024>>
can not convert
const boost::iterator_range<const boost::network::uri::uri::value_type *> &:

Does MSVC 2013 support C++11 features we're using here? Could it be that you need to just enable C++11 mode for MSVC 2013, and don't have to modify the 0.12.0-final release sources?

I think this issue was fixed (0.13-release), but we have not tested for MSVC 2013, and we are not going to. Therefore, I will close this issue. MSVC 2015 will be supported for the 0.13 release and beyond.


Figure out how to publish the final datasets

Can we generate Frictionless packages from the final nodes?

Publish as parquet!

Also, publish via RoAPI.

Also, generate a Frictionless package (with Dagster) for the final datasets parquet files.

Also, publish on GitHub artifacts. Pypi does something like this for some of their datasets!

Wow, I didn't know RoAPI, awesome!
+1 for parquet files.

Maybe it is best to way to the first release version of duckdb. I head it will be soon.  Meanwhile, I would upload a parquet.

So, datasets are being pushed to HuggingFace and also exposed in the HuggingFace API space with ROAPI!


MySql.Data.dll Problem

MySqlBackup Method not working in .NET Framework 4.5.2

You have provided too little clues and insufficient info to identify or guess your problem. Try provide more details.

string constring = "server=localhost;user=root;pwd=qwerty;database=test;";
string file = "C:\backup.sql";
using (MySqlConnection conn = new MySqlConnection(constring))
{
using (MySqlCommand cmd = new MySqlCommand())
{
using (MySqlBackup mb = new MySqlBackup(cmd))
{
cmd.Connection = conn;
conn.Open();
mb.ImportFromFile(file);
conn.Close();
}
}
}
The above line of code doesn't compile when working with .NET 4.5.2.

Even if I add MySql.Data.DLL reference to my Project.

I think you might have referenced the wrong .NET version of DLL.

I referred to Version 6.x.x till 8.x.x (Latest Stable) all of them didn't work.

You may attach a simple sample project that will generate the error. I can have a look on it.

This happened during a project i was working on, since i couldn't figure out what is wrong, I switched to SQL Server. But if you want to test it I can direct you to my project and you would just need to make few changes in one of the Methods to generate Error. My Project. Just change the method private void RestoreDatabase() with the above lines of code in this Issue thread. Thanks.

in Service.cs

I have downloaded your the sample project that you have provided.
Here is the problem:
Every release or every build of MySqlBackup.NET is bound with specific version of MySql.Data.DLL.
Problem 1: If there is a new version of MySql.Data.DLL, MySqlBackup.NET is required to recompiled / rebuilt.
Problem 2: If you reference a newer target platform of MySqlBackup.NET (i.e. version 4.6 or 4.7), it will not work in your project. This is because your project has a lower target platform 4.5.2. Version 4.6 of DLL won't work in 4.5.2.
Steps to resolve this problem:
Note 1: You must use a .net platform version of MySqlBackup.NET build at .net framework 4.5.2 or lower (i.e. 4.0 or 4.5)
Note 2: If you download the pre-built version MySqlBackup.NET, you must use the specific version of MySql.Data.DLL which bound together with it. It is usually located at the same folder of the MySqlBackup.NET inside the downloaded zip.
Note 3: If you wish to use your downloaded version or NUGET version of MySql.Data.DLL, then you need to do either one of the following options:
Option 1: Include the source code of MySqlBackup.NET directly into your project, which I personally STRONGLY RECOMMENDED.
Option 2: Recompile or rebuild MySqlBackup.NET with your version of MySql.Data.DLL.
You may read more about at the following wiki page:
https://github.com/MySqlBackupNET/MySqlBackup.Net/wiki/How-to-Add-This-Library-into-Your-Project
=================
By the way, I would like to talk a little bit about the sample project that you have presented.
The presented project don't have elements of MySqlBackup.NET. It is a normal error free project. It requires me to manually modify your project to re-generate the error that match to your description which I even not 100% sure that replicates your original of problem. It is usually not your working project.
That is not a good example of "Sample Project" for presenting error. A "sample project" refers here should be a very tiny program with one purpose only >> to demonstrate or to re-produce the error.

Alright, Understood, I will have to regenerate the errors.  Closing this issue for now, will reopen it when I'll have all the required details. Thanks.


[WIP] Add Python 3.12 support.

There seems to be an issue with numpy (1.24.4): not supporting PEP 517 builds

done with #166


Support for multiple order-by parameters in the by-query endpoint.

Hey, I just made a Pull Request!
Summary
Support multiple order by parameters in the by-query endpoint. Setting up possibility of then-by queries in dynamic pickers, dropdowns, tables, etc. Closes #17560
Cursor Pagination
I had some trouble implementing the full pagination. It works in it's current form and the basic idea is that we check if each order-by column's value is either greater than or less than (if we're in reverse) the previous value. There should be no issues with this approach, but please verify that's the case.
Risks
We're adding an additional n leftOuterJoins to this query, this may cause a significant slow down from the base cursor pagination base approach.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@vinzscam PTAL :)

Nice work! We deferred this specific use case for the future because of the complexity of performing such additional queries given the current database structure.
I wonder if it makes sense to add this PR to https://github.com/backstage/backstage/issues/12247 and test the multiple order-by parameters’ approach once the pagination work is done. By doing so, we can properly assess the performance of the current queryEntities implementation and the suggested in this PR properly. WDYT?

@vinzscam Gentle ping on this, thoughts on my comment above?

@vinzscam Gentle ping on this, thoughts on my comment above?

Hi, sorry for the late answer 🙈
I wanted to do some performance testing on our catalog but didn't have the time so far. I think we should do that, given that this feature is going to be useful also in the Entities Table, where adopters might want to sort by multiple column.
I've added the PR to #12247

@vinzscam 👍 , sounds good.

Hey sorry @sennyeya this has a conflict now.
@vinzscam a gentle ping.

Easiest conflict I've dealt with in a long while 😁!

@vinzscam Can you take another look at this?

I think we should pause this feature as none of the existing components need to retrieve the data sorted on multiple fields at the moment. As we haven’t assessed the performance of the changes we might risk that the code introduces some complexity to the pagination work, which right now is still in development.
I think we should re-evaluate this in the future, in case this feature becomes critical, so that we can find the best way to implement the feature.

We can close and revisit. My primary goal with this work was to add contextual namespace headers to the items in the OwnerPicker list, so items with the same name/display name but different namespaces were distinguishable.


feat: no longer use wrapped process.stdout and process.stderr

When a spinner is started, it creates a mock version of process.stdout.write and process.stderr.write to capture all log messages (from console.log, debug, ux.log, etc...) and then flushes the captured logs just before re-rendering the spinner.
By encapsulating process.stdout and process.stderr (introduced here), the spinner was no longer able to capture all logs messages - just the ones that went through the encapsulated process.stdout and process.stderr. This means that anything sent to the terminal via console.log or debug was at risk of being overwritten when the spinner re-render.
The solution here is to back out of using the encapsulated process.stdout and process.stderr. These were originally added so that it would be easier to stub process.stdout|stderr.write in unit tests (see mocha issue related to stubbing process.stdout.write). In place of that, I've reduced the usage of process.stdout.write to write.stdout and write.stderr and added makeStubs method to ux that people can use if they need to stub those.
I've also deprecated the Stream class that was used to encapsulate process.stdout and process.stderr and will be removed in the next major version
Fixes #799
Closes #828
(Passing tests depend on https://github.com/oclif/core/pull/836)

QA Notes

linked this into the demo plugin used in the issues repo:
before
➜  plugin-demo git:(main) ✗
 ➜  ./bin/dev demo
hello world 1
spinner... ⣻
hello world 2
spinner... done

after
✅
➜  plugin-demo git:(main) ✗ 🔗1
 ➜  ./bin/dev demo
hello world 1
hello world 2
hello world 3
spinner... done

linked into plugin-source doing a force source pull with a remote change
before
 ➜  sf force source pull
Warning: We plan to deprecate this command in the future. Try using the "project retrieve start" command instead.
Loading source tracking information... ⣟
Loading source tracking information... ⣽ Retrieving metadata from the org
Loading source tracking information... ⡿ Checking for deletes from the org and updating source tracking files
Updating source tracking...
Updating source tracking... done

after
✅
 ➜  sf force source pull
Warning: We plan to deprecate this command in the future. Try using the "project retrieve start" command instead.
Loading source tracking information... ⣷
Updating source tracking... done


Update extensiongalleries for 1.5.1 hotfix - arc and azcli

Hotfix version bump for this bug: https://github.com/microsoft/azuredatastudio/pull/20305

@alanrenmsft When you have time, could you please update the gallery with vsix files arc-1.5.1.vsix and azcli-1.5.1.vsix from here: https://mssqltools.visualstudio.com/CrossPlatBuildScripts/_build/results?buildId=167035&view=results


[google_maps_flutter] Clean up google_maps_flutter plugin

Description
Clean up google_maps_flutter plugin. This change should not have any functional differences.

A few minor formatting changes and additions of @Nullable annotations
Removed pass-through of activityHashCode. In the legacy plugin use case, the value is derived from registrar.getActivity(). In the new plugin use case, the value should never be used because it uses DefaultLifecycleCallbacks instead of ActivityLifecycleCallbacks.
Replaced custom lifecycle state ints with androidx.lifecycle.Lifecycle.State enum. Also simplify paused/stopped states, which don't need their own dedicated states. Paused == started and stopped == created.
Fixed a bug where the Lifecycle object was being leaked onDetachFromActivity by nulling out the field.
Moved GoogleMapListener to its own file. Declaring multiple top level classes in the same file is bad practice.

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

One thing to check - in the PR description it says that activityHashCode is -1 for the legacy plugin, my understanding is that it is -1 for the v2 (new) embedding, am I correct?

I updated the description to clarify that the value is derived from registrar.getActivity(). What I had been referring to was the legacy new GoogleMapFactory call site in GoogleMapsPlugin#registerWith passed in a value of -1.

please look at this issue has opened more than a year ago  .you should fixed .it's happened with all version of the packages

please look at this issue has opened more than a year ago .you should fixed .it's happened with all version of the packages

Thanks for the pointer. I don't think this change will address that, but I have some theories on how it might be fixed. I'll look into it in another pull request.


one-way-input does not update value after two keyEvents

I don't really know the root of this but I can reproduce easily in this twiddle:
https://ember-twiddle.com/538f16c371b8a118abd82363c0f2b862
Current behavior
Setting value to null, undefined, or empty string does clear the input field. But only for the first time; subsequent attempts seem to do nothing.
Expected behavior
Setting value to null, undefined, or empty string should clear the input field

The basic issue is that there is nothing to force the input to update. The first time value changes from undefined to null (forcing the rerender that you see after the first), and subsequent updates simply this.set('value', null) (which was the previous value) so there is no need to rerender.
Simpest fix is to provide the update action to the one-way-input:
{{one-way-input value
  update=(action (mut value))
  keyEvents=(hash 13=(action "update"))
}}

See updated demo

Oh! Ok. I get it. Thanks.


I like chef? Please don't make my life harder?

It stopped working with chef and its OSS so I fixed it?
Ref: https://twitter.com/gosukenator/status/589003773894217728

:+1:

LGTM

:+1:

:+1:

As commented in #367 , I got the apologize from him in Twitter. So I will merge this.
Very sorry for my immature attitude.

Released as v2.28.4.

I have to say "Otsukaresama deshita(Hard work for this issue)!" to @mizzy -san


Preserve single \ in string literals

# Input
pattern_esc = r"'\', '\\'"

# Ruff
pattern_esc = r"'', '\\'"

Expected: Same as input
Probably relevant code:
https://github.com/astral-sh/ruff/blob/03018896deebfeb2cf96c28c897dd98a5e1c7699/crates/ruff_python_formatter/src/expression/string.rs#L413-L481
Playground

@MichaReiser Can I work on this?

@MichaReiser Can I work on this?

Sure!


updated limitation on partitioning with custom column

Added limitation when using a custom column as partition key, we cannot use any data type other than NVARCHAR(MAX).

@devmaven : Thanks for your contribution! The author, @mamccrea, has been notified to review your proposed change.

Hi @devmaven - thank you for your contribution! I have discussed with the Stream Analytics team, and instead of a note, we'd like to add the following sentence to the end of the Partition key options paragraph. "The partition key must be NVARCHAR(MAX)."
Can you please commit that change? Or if you'd rather, you can close this PR and I will commit the change for you.
Again, thank you for your contribution to docs.

@devmaven : Thanks for your contribution! The author, @mamccrea, has been notified to review your proposed change.

Looks good @devmaven! #sign-off


Force GC returns false

When I do a Force GC on a .NetCore3.1 or .Net6 process, status returns success= False. Below is the log captured.
Started with command line: "C:\Tools\Perfview\PerfView64.exe"
PerfView Version: 2.0.74  BuildDate: Mon, 08 Nov 2021 22:34:08 GMT
PerfView Start Time 26/12/2021 13:56:25
Warning: PdbScope not found at C:\Tools\Perfview\PerfViewExtensions\PdbScope.exe
Disabling the Image Size Menu Item.
Warning: ILSize not found at C:\Tools\Perfview\PerfViewExtensions\ILSize.dll
Disabling the IL Size Menu Item.
Started: View
Completed: View   (Elapsed Time: 0.087 sec)
Started: Forcing a GC to process 26580
Starting Heap dump on Process 26580 running architecture Amd64.
Exec: "C:\Users****\AppData\Roaming\PerfView\VER.2021-12-<IP_ADDRESS>.447\Amd64\HeapDump.exe" /ForceGC 26580
Loading the ETWClrProfiler.
Turning on debug privilege.
Could not enumerate .NET runtimes on the system.
0.1s: Enabling JScript Heap Provider
0.1s: Enabling EtwClrProfiler
0.1s: Enabling CLR GC events
0.1s: Requesting a JScript GC
0.1s: Requesting a DotNet GC
0.1s: Requesting .NET Native GC
10.1s: Waiting for reply
20.1s: Waiting for reply
30.2s: Waiting for reply
40.2s: Waiting for reply
50.3s: Waiting for reply
60.1s: Timed out after 60 seconds, GCs done but dead loops between .NET and JS heap may still exist.
60.1s: Requesting ETWClrProfiler unload.
60.1s: Shutting down ETW session
[ 60.1s: Done forcing GCs success=False]
Completed: Forcing a GC to process 26580   (Elapsed Time: 60.549 sec)
When done on a .Net4.8 process it works with status returning success=True

It looks like the error here is Could not enumerate .NET runtimes on the system..
@davmason, do you know if we should be able to enumerate runtimes with the code at https://github.com/microsoft/perfview/blob/main/src/HeapDump/GCHeapDumper.cs#L783 in order to attach the profiler to a .NET 6 process?  From a quick test, this doesn't appear to work for .NET 6.

No, that approach is unsupported and removed from coreclr. Even if you could get a CLRMetaHost, we don't support ICLRProfiling anymore.
The new way to attach a profiler since .net core 3.1 is to attach using the DiagnosticsClient. We don't currently have a way to query per process for whether it has a loaded runtime, but we do provide GetPublishedProcesses so it should be easy to implement that method by checking if the process you care about is in the list of available processes to attach to.
@josalem as an aside, it seems worthwhile to add a IsProcessPublished(int pid) method to DiagnosticsClient

Does this basically mean that ForceGC is not working for .NET Core 3.1+ processes? Are there any plans to support this?

I wouldn't expect this mechanism to come to .NET Core, but it is possible to force a GC and capture a heap snapshot via ETW / dotnet-trace.  I would recommend using this mechanism instead.

Closing as by design.


refmt duplicating comments on each run causing 100% CPU usage

I have this code
<EMAIL_ADDRESS>jsConverter]
type validationErrors = [
  | `FilePathMissing
  | `FilenameMissing
  | `LanguageMissing
  | `NameMissing
  | `DevPlatformMissing
  | `DestinationsMissing
  | `AnalyticsPlatformMissing
  | `ApiKeyMissing/* (apiKeyError) */
];

And when I run refmt it get's changed to this
<EMAIL_ADDRESS>jsConverter]
type validationErrors = [
  | `FilePathMissing /* (apiKeyError) */
  | `FilenameMissing /* (apiKeyError) */
  | `LanguageMissing /* (apiKeyError) */
  | `NameMissing /* (apiKeyError) */
  | `DevPlatformMissing /* (apiKeyError) */
  | `DestinationsMissing /* (apiKeyError) */
  | `AnalyticsPlatformMissing /* (apiKeyError) */
  | `ApiKeyMissing /* (apiKeyError) */
];

Then on each following refmt it multiplies the comment in each line with the number of lines so after 2 refmt runs this is the result
<EMAIL_ADDRESS>jsConverter]
type validationErrors = [
  | `FilePathMissing /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */
  | `FilenameMissing /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */
  | `LanguageMissing /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */
  | `NameMissing /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */
  | `DevPlatformMissing /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */
  | `DestinationsMissing /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */
  | `AnalyticsPlatformMissing /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */
  | `ApiKeyMissing /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */ /* (apiKeyError) */
];

And then after some number of formats it causes refmt to use 100% CPU and crash

I already have an issue filed here: https://github.com/facebook/reason/issues/1828
I marked it as Good First Task.

@jordwalke we need to migrate our ast to use omp 4.06 to fix this. The locations aren't part of the poly-variants itself in the ast 4.04. The comment interleaving algorithm thinks that the location of every poly-variant is that of the whole thing…
We should probably upgrade in the near future to use the 4.06 ast, or hack the existing ast to estimate locations. (I strongly prefer the first)
cc @chenglou


Spritesheet error on Windows

Took ages to start the game, and got this:
A fatal error has occured

Spritesheet size 957 would be over max array size 512 - falling back to 'slow' path.

Did actually load and work though

Let me guess, this is using the Intel graphics driver? This exact thing happened on mine for a while, but I think a driver update fixed it. It's clearly a driver limitation, not a hw limit.
The super slow texture upload I can't do anything about, and the slow-mode-fallback really should be a warning, not an error.
I could try to resurrect my sprite packing branch and see if that helps (using a packed 2d spritesheet instead of a texture array) but that's not high on my prio list ATM.
It might be useful to run an opengl extension & limits viewer and paste the results (I'll probably add the same info to the openapoc log soon ish if crappy drivers are going to be common)

Yep, it was an Intel Graphics driver. No worries about it, just first time I'd seen it. It'll be fine for now


CM-197 Update browser versions

https://liveintent.atlassian.net/browse/CM-197
Chrome, firefox and Edge would use latest.
IOSes have the pinned versions, cause there's one version per os, and there's no way to have the latest OS.
Author Todo List:

[X] Add/adjust tests (if applicable)
[X] Build in CI passes
[X] Latest master revision is merged into the branch
[X] Self-Review
[x] Set Ready For Review status

The test for Firefox 52/Win 7 seems to fail: https://automate.browserstack.com/dashboard/v2/builds/58fe471cfd7f2f6e87a9669a472f98e860253958/sessions/06bbb2d896154c7646ecfcd74a51781270219679. Is our reporting broken?

Browserstack doesn't know about the test retries. So that specific test run failed, but it succeeded after the browser restart.


provide loading prop to root component

Hi.
To enable display common loading animation, loading prop can help it shows.
If root component reach loading prop, it would be useful.
Thank you

It already able if loadProps method in the component.

It already able if loadProps method in the component.


Run camo in Docker

Testing plan: Started a new docker instance, verified that image URLs load, and are /external_content/...
Fixes #20101.
Fixes zulip/docker-zulip#179.
...but both of those only once these changes are in a Zulip Server release which docker-zulip can pull in.

Merged, thanks @alexmv!


#2354 use safe operator for access to getShortImageName()

use safe operator for access to getShortImageName() on currently deployed artifact and show 'N/A' if no image deployed yet
fixes #2354

Codecov Report

Merging #2358 into release-0.7.2 will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           release-0.7.2    #2358   +/-   ##
==============================================
  Coverage          37.39%   37.39%
==============================================
  Files                156      156
  Lines               9331     9331
  Branches             164      164
==============================================
  Hits                3489     3489
  Misses              5361     5361
  Partials             481      481

Flag
Coverage Δ

#moduleA
24.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 144f2af...8fdc159. Read the comment docs.


How to use simd with wasm-bindgen?

Summary
How to use simd in wasm-bindgen? could you give me a example , thanks a lot.
Additional Details
Provide any additional details here.

Using simd with wasm-bindgen should be basically the same as without wasm-bindgen, and you can find more information about using it here.


Fixing a bug where we are trying to create internal AWS tags

Fixes #7

Note: Fixed on master beyond just this change... renaming any tags with a key prefix of aws:... to internal-aws:... so it doesn't fail.  This way we preserve all keys for informational purposes even if we have to rename it slightly.


Feature Request: Allow click.launch() to specify the application to launch the url

Currently, click.launch() uses xdg-open to launch applications (On Linux). This is not always desirable, for example, I'd like to open a file with a specific PDF viewer which is not the default.
Looking at the code, launch() further calls the open_url method. Is it possible to add another argument to the method specifying which application to use to open the URL? I'd be willing to contribute if this seems useful to others as well.

In that case you should use your own function. The idea of launch() is to let each user's operating system decide. If you know the file and application you want ahead of time, use subprocess.run() directly.


updated the build script

There are probably bigger sustainability questions about how we deal with the new micro releases, but this is what I did to make it work.

I have only 1 comments to enable GitHub action to work.
have you tried it for 2021.3 as well ?
thx a lot @makeclean

A couple of changes that seem to be needed...
OS name detection is not working here
index d23b327..f7c714d 100644
--- a/scripts/unix_share_build.sh
+++ b/scripts/unix_share_build.sh
@@ -55,11 +55,10 @@ function setup_var() {
         echo "unknown Trelis/Cubit version"
         return 1
     fi
-
-    if [ "OS" == "MAC" ]; then
+    if [ $OS == "MAC" ]; then
         BUILD_SHARED_LIBS="OFF"
         BUILD_STATIC_LIBS="ON"
-    elif [ "OS" == "UBUNTU"]; then
+    elif [ $OS == "UBUNTU" ]; then
         BUILD_SHARED_LIBS="ON"
         BUILD_STATIC_LIBS="OFF"

Name of the function seems outdated
index 55d68bc..2467b17 100755
--- a/scripts/build_plugin_linux.sh
+++ b/scripts/build_plugin_linux.sh
@@ -25,19 +25,23 @@ SED="sed"
 source ${SCRIPTPATH}/scripts/unix_share_build.sh

-build_hdf5
+linux_build_hdf5

Also, I noticed that the plugin builds againts libMOAB.so.0, while the lib file is named libMOAB.so.5. I just linked it, and after that, the plugin is working with 2021.3 !

Do we need all three of these workflow files? or does unix replace linux and macos?

Do we need all three of these workflow files? or does unix replace linux and macos?

no I kept them to help me unifying them.
we will only keep the unix.yml one

A couple of changes that seem to be needed...
OS name detection is not working here
index d23b327..f7c714d 100644
--- a/scripts/unix_share_build.sh
+++ b/scripts/unix_share_build.sh
@@ -55,11 +55,10 @@ function setup_var() {
         echo "unknown Trelis/Cubit version"
         return 1
     fi
-
-    if [ "OS" == "MAC" ]; then
+    if [ $OS == "MAC" ]; then
         BUILD_SHARED_LIBS="OFF"
         BUILD_STATIC_LIBS="ON"
-    elif [ "OS" == "UBUNTU"]; then
+    elif [ $OS == "UBUNTU" ]; then
         BUILD_SHARED_LIBS="ON"
         BUILD_STATIC_LIBS="OFF"

Name of the function seems outdated
index 55d68bc..2467b17 100755
--- a/scripts/build_plugin_linux.sh
+++ b/scripts/build_plugin_linux.sh
@@ -25,19 +25,23 @@ SED="sed"
 source ${SCRIPTPATH}/scripts/unix_share_build.sh

-build_hdf5
+linux_build_hdf5

Also, I noticed that the plugin builds againts libMOAB.so.0, while the lib file is named libMOAB.so.5. I just linked it, and after that, the plugin is working with 2021.3 !

@MigMagan thx for your feedback.
the OS is not supposed to be a detection but a variable set by the user (see the updated comments), also I haven't try to script yet, I was focussing on the GitHub action build...
about the libMOAB.so, I am unsure about what you mean by linked it, but it should be included in the plugin folder as we import ${PLUGIN_ABS_PATH}/moab/lib/libMOAB.so*...

@makeclean @gonuke @pshriwise this should be ready for a extensive review.
I also included a merge of the linux and Mac GitHub action into unix GitHub action.
I only included the 17.1.0 and 2021.4 version yet as this is the only version we have both .deb for ubuntu and .dmg for Mac ...
not that 2021.5 has just been released.....


MIDI_IN_PORTS_NUM undeclared

I followed the README and put MIDI_IN_PORTS_NUM and MIDI_OUT_PORTS_NUM into main.h but I get an error when compiling usbd_midi.c:
arm-none-eabi-gcc "../Middlewares/ST/STM32_USB_Device_Library/Class/MIDI/Src/usbd_midi.c" -mcpu=cortex-m0plus -std=gnu11 -g3 -DDEBUG -DUSE_HAL_DRIVER -DSTM32G0B1xx -c -I../Core/Inc -I../Drivers/STM32G0xx_HAL_Driver/Inc -I../Drivers/STM32G0xx_HAL_Driver/Inc/Legacy -I../Drivers/CMSIS/Device/ST/STM32G0xx/Include -I../Drivers/CMSIS/Include -I../USB_Device/App -I../USB_Device/Target -I../Middlewares/ST/STM32_USB_Device_Library/Core/Inc -I../Middlewares/ST/STM32_USB_Device_Library/Class/HID/Inc -I"/Users/kamil/STM32CubeIDE/workspace_1.12.0/Abraxas/Middlewares/ST/STM32_USB_Device_Library/Class/MIDI/Inc" -O0 -ffunction-sections -fdata-sections -Wall -fstack-usage -fcyclomatic-complexity -MMD -MP -MF"Middlewares/ST/STM32_USB_Device_Library/Class/MIDI/Src/usbd_midi.d" -MT"Middlewares/ST/STM32_USB_Device_Library/Class/MIDI/Src/usbd_midi.o" --specs=nano.specs -mfloat-abi=soft -mthumb -o "Middlewares/ST/STM32_USB_Device_Library/Class/MIDI/Src/usbd_midi.o"
In file included from ../Middlewares/ST/STM32_USB_Device_Library/Class/MIDI/Src/usbd_midi.c:43:
/Users/kamil/STM32CubeIDE/workspace_1.12.0/Abraxas/Middlewares/ST/STM32_USB_Device_Library/Class/MIDI/Inc/usbd_midi.h:49:41: error: 'MIDI_IN_PORTS_NUM' undeclared here (not in a function)
   49 | #define USB_MIDI_REPORT_DESC_SIZE      (MIDI_IN_PORTS_NUM * 16 + MIDI_OUT_PORTS_NUM * 16 + 33)
      |                                         ^~~~~~~~~~~~~~~~~
/Users/kamil/STM32CubeIDE/workspace_1.12.0/Abraxas/Middlewares/ST/STM32_USB_Device_Library/Class/MIDI/Inc/usbd_midi.h:50:41: note: in expansion of macro 'USB_MIDI_REPORT_DESC_SIZE'
   50 | #define USB_MIDI_CONFIG_DESC_SIZE      (USB_MIDI_REPORT_DESC_SIZE + USB_MIDI_CLASS_DESC_SHIFT)
      |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~
../Middlewares/ST/STM32_USB_Device_Library/Class/MIDI/Src/usbd_midi.c:127:48: note: in expansion of macro 'USB_MIDI_CONFIG_DESC_SIZE'
  127 | __ALIGN_BEGIN static uint8_t USBD_MIDI_CfgDesc[USB_MIDI_CONFIG_DESC_SIZE]  __ALIGN_END =
      |                                                ^~~~~~~~~~~~~~~~~~~~~~~~~
/Users/kamil/STM32CubeIDE/workspace_1.12.0/Abraxas/Middlewares/ST/STM32_USB_Device_Library/Class/MIDI/Inc/usbd_midi.h:49:66: error: 'MIDI_OUT_PORTS_NUM' undeclared here (not in a function)
   49 | #define USB_MIDI_REPORT_DESC_SIZE      (MIDI_IN_PORTS_NUM * 16 + MIDI_OUT_PORTS_NUM * 16 + 33)
      |                                                                  ^~~~~~~~~~~~~~~~~~
/Users/kamil/STM32CubeIDE/workspace_1.12.0/Abraxas/Middlewares/ST/STM32_USB_Device_Library/Class/MIDI/Inc/usbd_midi.h:50:41: note: in expansion of macro 'USB_MIDI_REPORT_DESC_SIZE'
   50 | #define USB_MIDI_CONFIG_DESC_SIZE      (USB_MIDI_REPORT_DESC_SIZE + USB_MIDI_CLASS_DESC_SHIFT)
      |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~
../Middlewares/ST/STM32_USB_Device_Library/Class/MIDI/Src/usbd_midi.c:127:48: note: in expansion of macro 'USB_MIDI_CONFIG_DESC_SIZE'
  127 | __ALIGN_BEGIN static uint8_t USBD_MIDI_CfgDesc[USB_MIDI_CONFIG_DESC_SIZE]  __ALIGN_END =

I notice that file does not #include "main.h" anywhere so I'm not sure how it's supposed to pick up the number of ports based on your scheme?

I guess I forgot to mention that you need to include
usb_device.h in main file as well. Could you recheck?

Ok. It is actually not my scheme, but ST guys. They did things as they did.
You can follow the includes route starting from my usbd_midi.c file:
usbd_midi.c -> usbd_midi.h -> usbd_ioreq.h -> usbd_def.h -> usbd_conf.h -> main.h
Perhaps you are using some old ST libraries, that's why this issue occurs. But you can always put MIDI_IN_PORTS_NUM and MIDI_OUT_PORTS_NUM in usbd_desc.h for example.

I'm using the latest HAL for STM32G0. I went down the chain and it seems that usbd_conf.h doesn't include main.h in a freshly-generated project. Maybe it would be better to suggest those defines go in there?

Actually I like more when all macros are located in one place in main.h
Anyway I've added alternative path for those defines below in the README as well

Sure. I'm gonna leave them in usbd_conf.h since that's where all the other USB-related macros are, seems to make sense rather than having the USB stack depend on the application main.

Yes, this will be the best place to have them (logically). But usbd_conf.h doesn't seem to have any "user sections". So, when you generate new code with CubeMX, you may lose these macros.

In mine it has this section:
/* Private variables ---------------------------------------------------------*/
/* USER CODE BEGIN PV */
#define MIDI_IN_PORTS_NUM   0x01 // Specify input ports number of your device
#define MIDI_OUT_PORTS_NUM  0x01 // Specify output ports number of your device
/* USER CODE END PV */

Interesting...)

Ok. I'll mention this file instead.


Consider to use `git ls-files' for file search if possible

For quick file lookup in a very large code base under git VCS it is beneficial to use `git ls-files' command. It's fast because it doesn't need to read directory entries to traverse project's structure. It won't show files which are not in git's index, so for completeness this method must be combined with slower recursive file tree walk.

I don't like the added complexity this would introduce. Let's add it to our list of ideas for #55. Closing as duplicate.


Trivial python syntax fixes

Can one of the admins verify this patch?

Nevermind, python2 doesn't support yield from.


Merge latest updates from dev - [closed]

In GitLab by @wknet123 on Mar 20, 2018, 10:04
Merges dev-devops -> dev-devops

In GitLab by @wknet123 on Nov 13, 2019, 10:42
The test coverage for backend is  %   and for frontend is 38.11%   check console log

In GitLab by @wknet123 on Nov 13, 2019, 10:42
the it is failed check console log

In GitLab by @wknet123 on Nov 13, 2019, 10:42
The test coverage for backend is  %   and for frontend is 38.11%   check console log

In GitLab by @wknet123 on Nov 13, 2019, 10:42
the it is failed check console log

In GitLab by @wknet123 on Nov 13, 2019, 10:42
closed


save path incomplete

The save path that is displayed in the column as well as in the general tab just shows the download directory. It is supposed to show the full path including the downloaded torrent. I've had this issue with other rutorrent setups too. I suspect that something change in rutorrent a few months ago that caused this breakage.

Yes this is a RuTorrent feature, which I have no control over. If you think this is an issue you should raise it with them. https://github.com/Novik/ruTorrent


Add an abort() method in focusstack class ?

Hi,
Do you think it is possible/useful, to add an abort() method in the streaming interface of focustack class ?
I think it can be usefull, in cases where wait_done() method returns an error during a processing, in order to abort any  scheduled tasks left in queue.

I think the currently existing .reset() method should do it.


Add cirq_google.FSimGateFamily class.

This PR adds a new cirq_google.FSimGateFamily class which can be used to:

Convert any compatible FSimGate type to another compatible FSimGate type.
Accept (potentially parameterized) instances of compatible FSimGate types.

The gate family is also used to replace existing logic in cirq_google for checking / converting against fsim types. Once merged, this would also be useful to perform similar checks and conversions in pyle.
This is part of the roadmap item: #3243

@MichaelBroughton I removed the unrelated change and have added a manual override for the specific case. This should work for the next couple of releases -- till the other issue is fixed and has gone through a deprecation cycle before the changes are released.
This PR is ready for review.

@dstrain115 Thanks for the review. I've addressed your comments.
I'll merge once @maffoo takes another look.


Enable js urb.bind to a foreign {ship}: v2

Supercedes #378
In addition to adding remote %peel, this reverts %gall handling of foreign diff results to an earlier version, which incorrectly translates the data using the desk of the local app with the same name. This is caused by an arvo limitation, which necessitates ames negative ackgnolwedgments be given explicitly instead of being generated from a crash.

I'd like to approve this, but I have no idea how.


Add support for querying PACS

Description
Fixes #480

query the VNA for a study, trying PACS instead if a study is not found
if the study is found in PACS but it's available online, do not pull the study (we're assuming it's available in the VNA)
add test to check a study is pulled from PACS if it's not available in the VNA
update imaging API docs to explain the secondary dicom archive is queried if a study is not in the primary dicom archive
rename VNAQR_ environment variables to PRIMARY_DICOM_
add environment variables for SECONARY_DICOM_ (PACS)

Type of change
Please delete options accordingly to the description.

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] This change requires a documentation update

Suggested Checklist

[x] I have performed a self-review of my own code.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[ ] I have commented my code, particularly in hard-to-understand areas.
[x] I have passed on my local host device. (see further details at the CONTRIBUTING document)
[x] Make sure your branch is up-to-date with main branch. See CONTRIBUTING for a general example to syncronise your branch with the main branch.
[x] I have requested PR review to UCLH-Foundtry/arc-dev
[ ] I have adddressed and marked as resolved all the review comments in my PR.
[ ] Finally, I have selected squash and merge

oh but it came up again, okay worth fixing as well

I think the only thing that on thinking about it would be useful (I didn't say on the issue) is that if the secondary dicom server hasn't been defined then we should return early

Oh good idea, what's the best way to check this? Check that that SECONDARY_DICOM_MODALITY environment variable is defined and that the modality exists on Orthanc?

Oh good idea, what's the best way to check this? Check that that SECONDARY_DICOM_MODALITY environment variable is defined and that the modality exists on Orthanc?

Yeah I think so. Though I'm not sure what we do on the orthanc configuration side, maybe set some default dummy values as it'll never be connected to?

Thanks for the reviews! I think the systems tests should be passing locally now @mxochicale but let me know if you're still having issues