Column selector and kanban vertical spacing

A bit of space should be added between the column selector bottom and the top of the kanban board. This would add consistency with other Spotfire visuals like the cross table for instance.

#mod-kanban  in main.css would need some margin-top: 10px;


upgrade should have an option to wait for the new deployments/pods to startup properly

it could be the upgrade fails; so it'd be nice to have a wait mode that waits for all the updated Deployments to become ready within a time period then return a failure if it fails to work
We could also add a revert CLI argument so that if things dont' upgrade in, say, 10 minutes, it reverts back to the previous version?

Has anything happended with these suggestions? Just curiuos since they make sense.
Is it 'safe' to perform an upgrade using the upgrade command running on a kubernetes cluster (not minikube)? I am on version 2.2.163 and would like to upgrade to latest.

We've now got a readinessTimeout argument you can pass into kubernetesApply() in your Jenkinsfile to supply the wait timeout where the pipeline waits for the new version to come up before failing the pipeline if it fails.
https://github.com/jenkinsci/kubernetes-pipeline-plugin/blob/master/devops-steps/src/main/java/io/fabric8/kubernetes/pipeline/devops/ApplyStep.java#L31
Though we should be enabling this OOTB on all our pipelines - maybe optionally loading this configuration from the fabric8-pipeilnes ConfigMap resource in case folks wanna configure this globally on a per team basis.
We don't yet have a rollback-on-failure logic though which would be nice!


add AutocompleteRequestPermsMiddleware

replaced by https://github.com/fullctl/fullctl/pull/250/files


Change default enabled feature

As @fabi1cazenave said: maybe the angle mod should not be enabled by default, e.g. if we consider how many could be using ANSI keyboards.

Je dirais même plus : ANSI or orthogonal keyboards (i.e. non-ISO).

Another argument: if you want anglemod, you may already have enabled it through kalamine --angle-mod (which is ihmo a preferable option than kanata, in order to have the same keymap in grub and when typing luks password, and to keep kanata for fancy features like lt & hrm).


Save or Print a Certificate

The certificate, specifically the Front End but probably the others too, cannot be printed on a single page or saved as an image.
The certificate page is built with an image and overlaying name and date. When you try to save the image, it is saved without the name and date. The print of the page results in a too large images that does not fit on a single page.
Quincy suggested I'll check for a solution - here is a simple solution that can be implemented:
change the size of the image/page to fit a page by adding zoom style to the body of the page (either in the html or css):
<body style="zoom: 43%" >
This will ensure you can print the page to a PDF file or the printer and will fit one page (letter size,
portrait and landscape).
Another issue is that the date does not align nicely after "on". This can be fixed by changing the .cert-date class:
.cert-date {
...
  top: 990px;
...
}

You may come with other, maybe more creative solutions.
Thanks,
Benny

Would it possible to get the base certification image plus the date, name, and verification link all in one SVG element / file? That might make it easier to convert to a printable format like PNG.

cc @QuincyLarson @BerkeleyTrue.

I used https://web-capture.net/  I just added my link to where my certification was at and converted it to a jpeg image and it worked. The image came out a very good size. If you want to stretch it out some guess you could drop and drag it into Word or Open Office and right click and press the Rotate left of Right feature and stretch it out some to make it look bigger.
I also tried everything from Prnt Screen with crappy results the above worked for me though. Off to https://www.sololearn.com/ its free to use also.
Peace

Open the link of your certificate.Enable full screen and then press 'prt sc' key on your keyboard..
Open MS paint and then >right click>paste..
Select the image and crop it ..
Save it in png format..

Hey guys!
I get the certificate printed on a A4 in the following steps:

Getting the image with Firefox screen capture;
Opening the image saved on downloads and printing landscape on a PDF printer
Checking the pdf file and printing in a regular printer.

I just screenshotted!
Perfect certification!

I have created PDF converter for Free Code Camp certificates, please use it under terms, thanks.
http://j.mp/fcc2pdf

@bhallak I give you props for your initiative in creating this certification generator. But these certifications will not be verifiable on freeCodeCamp's servers, and are thus meaningless except to people too lazy to verify them by visiting the URL. Thus, your tool does more harm than good by making it easier for people to create misinformation.
Also, this is unauthorized use of my signature. Thus I kindly ask that you remove your project or remove my signature and make it clear this is a parody.


Unique Scroll Speed for notes?

Describe your problem here.
If even possible, how would I go about setting a scroll speed unique to a note type?
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

Check psych discord Kevin made it


Secrets managed by vault and consul-template

originally posted https://github.com/fredrikhgrelland/terraform-nomad-minio/pull/19#discussion_r491885284 by @zhenik
User-story

Key-value pairs (minio access and secret keys) exist already exist in the vault as a secrets
Secrets rendered in nomad_job via consul-template

Idea
The user, who is responsible for deploy, does NOT provide credentials. Credentials are provided by vault, and rendered  by consul-template

relevant https://github.com/fredrikhgrelland/terraform-nomad-postgres/issues/18

@dangernil this issue is a duplicate of https://github.com/fredrikhgrelland/terraform-nomad-minio/issues/66


Remove duplication checking for the existence of endpoint to speed up container starting

CreateEndpoint will check if the endpoint exist or not(https://github.com/docker/libnetwork/blob/master/network.go#L674)
, so there is no need to check before call CreatEndpoint in connectToNetwork since
checking the existence of the endpoint could take much time especially
if we use external K-V store, this would slow down the starting of container.
Signed-off-by: Lei Jitang<EMAIL_ADDRESS>

ping @mrjana @mavenugo

@coolljt0725 Thanks. we have been thinking of making this change. LGTM.
@mrjana ?

@coolljt0725 Ideally we have to remove this check in both places since we can't guarantee that anyways. But definitely can remove the redundant docker check. LGTM

ping @cpuguy83

LGTM.
Windows CI is down for maintenance.

LGTM


Adding Meteor Files to an existing collection

I set up the upload field following the instructions. (using React)
Now, it saves in a new collection UserFiles.
I would like the image to be attached to a different collection. I have tried doing so using simpl-schema.
In the doc, I found the default Files collection schema.
https://github.com/VeliovGroup/Meteor-Files/wiki/Schema
Can you give me any hint on how to do that ?
Best

Hello @sbdm05 ,
Not sure what you're exactly mean by:

I would like the image to be attached to a different collection.

But in MongoDB there is two ways to reference data between collections:

Referense by _id as in any other relational database
[recommended] Get shallow copy of the record from UserFiles and attach it to the collection of your choice, it can be done in onAfterUpload hook or afterUpload event

Hello @sbdm05 ,
Any news on your end? Have you solved it?

Closed due to silence at issue owner end.
Feel free to reopen it in case if the issue still persists on your end.


Replace Boost.Asio with Asio

Description

If merged this pull request will replace the use of Boost.Asio with Asio as part removing dependencies on compiled Boost libraries for issue #605.
Proposed changes

Replaces uses of Boost.Asio with Asio
Removes use of boost::system::error_code
Updates parts of Boost libraries used in CONTRIBUTORS.md
Adds Asio to libraries used in CONTRIBUTORS.md
Adds Asio as a git submodule
Enables git submodule support on AppVeyor

I think this looks good assuming everything works correctly.  We may want to change asioServiceManager to AsioContextManager so the names don't get confusing at some point.

Reminder: make sure docs are up to date for cloning git submodules


Configuration DB Recommendations

You state "Full. We recommend that you switch the configuration database to the simple recovery model to restrict growth of the log file" but in the notes you state that we should backup the Transaction log frequently to force truncation. We can't do both of these, can you please clarify the guidance.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a8065895-eb6b-e4a5-967a-73bee4605d50
Version Independent ID: ce168605-1ed4-d626-476d-d4120be2a6cf
Content: Database types and descriptions in SharePoint Server
Content Source: SharePoint/SharePointServer/technical-reference/database-types-and-descriptions.md
Service: sharepoint-server-itpro
GitHub Login: @bentoncity
Microsoft Alias: stevhord

@bentoncity please review and correct.

Hi Dean, I'm researching the note to see if this should actually be removed. Will address as soon as I get more information from the product team.

Revised the statements to show the preferred method is to set the config database to full recovery model and to take backups to truncate the logs.


cmd: Remove newer version check on ecctl version

Description

Removes the check for a newer version against the current ecctl version
since it requires a GitHub Token. It is not the most useful of features
and not well documented. It would be handy to have the ability to check
for newer versions without any request token or authenticaiton. For the
time being I am removing the check.
How Has This Been Tested?

ecctl version doesn't check for updates anymore.

I understand the reason behind this change, however I still find this feature useful sometimes.
Instead of removing this code, how about putting it behind a --check-for-new-version switch that is false by default?

This is a public / open source tool. IMHO it's a terrible idea to ask people to set an env variable with their GH token ( forcing them to open a GH account if they don't have ) to check for ecctl version.
+1 to completely remove the feature and re-thing another way of checking versions

The code removed is trivial and again, I don't think it's the best experience, I take your feedback @karencfv and @infraredgirl, while the functionality provided is useful, the way on which it is, not so much. I have some ideas on how to provide a better experience with this and uptd.


Add participants to Slack channel

I am getting messages from Slack saying that our hackathon participants will be billed as full members. I'm trying to find out why.  I've reached out to @cpshadle @joebenclark and @OGarcia11 trying to see if anyone knows how I can invite the guests without CDISC actually being billed for them.  "Single-channel guests" are free but they are limited in number.

Everyone on the participation roster has been invited to Slack.


Revert the deprecation of some methods

Chapman and CCA vault need to be tested / compared with Solr again before this is ready for review.

You can use calisphere-id as the field, instead of identifier, and instead of _id, so:
hash_id.update(str(couch_doc.get('calisphere-id', 'ABC123')).encode(encoding="UTF-8"))
This should probably actually error out noisily if there is no calisphere-id, but we can sort that later. calisphere-id should also never be an array, so you probably don't need the str() or .encode() trappings.
hash_id.update(couch_doc.get('calisphere-id', 'ABC123'))

@amywieliczka Ok, all changes made here.


Function that return as string the actual numbers

Ideally is enough to have a function that print 3 TODO | 1 FIXME so it can be used on https://github.com/nvim-lualine/lualine.nvim or other statusline

i agree with @Mte90 ,that would be a useful one

Ideally is enough to have a function that print 3 TODO | 1 FIXME so it can be used on https://github.com/nvim-lualine/lualine.nvim or other statusline

Do you have idea how to realize counter of todo-comments in lualine?

Hey, I wrote a plugin that does what you need to add counts in nvim-lualine: https://github.com/bezhermoso/todos-lualine.nvim
In the meantime, I've requested to make this or something similar part of the plugin itself: https://github.com/folke/todo-comments.nvim/issues/259

Hey, I wrote a plugin that does what you need to add counts in nvim-lualine: https://github.com/bezhermoso/todos-lualine.nvim
In the meantime, I've requested to make this or something similar part of the plugin itself: https://github.com/folke/todo-comments.nvim/issues/259

I'm already realized todo counter in NEVIRAIDE.

The issue is still there.

it is still there...

I am evaluating to change the plugin I am using  jus t because of this action...

sigh


Update version in package.json on release

The version in package.json ist not updated:
https://github.com/taskmedia/action-conventional-commits/blob/ddf12d3ca3e31eed4cd0be5432b9d09ba4583ce8/package.json#L3

currently the version is only published to release/v* branches and not to main


How to run this code Sir

How to run this code any demo please sir.

This library doesn't currently support WhatsApp multi-device login. I encourage you to try another library.

But dear sir how to work no issues if not support.
But i need how to run . Please send me any tutorial videos . please sir
On Saturday, May 7, 2022, Faiz Jazadi @.***> wrote:

Closed #26 https://github.com/p4kl0nc4t/kyros/issues/26.
—
Reply to this email directly, view it on GitHub
https://github.com/p4kl0nc4t/kyros/issues/26#event-6565752561, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AZBNKT7XNIFLVJUSQUVAGU3VIVT7XANCNFSM5VHLSCTA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Add Suggestions UI & experimental shell completions support

There's two parts to this PR that should be considered separately.

The Suggestions UI, a new graphical menu for displaying suggestions / completions to the user in the context of the terminal the user is working in.
The VsCode shell completions protocol. This enables the shell to invoke this UI via a VT sequence.

These are being introduced at the same time, because they both require one another. However, I need to absolutely emphasize:
THE FORMAT OF THE COMPLETION PROTOCOL IS EXPERIMENTAL AND SUBJECT TO CHANGE
This is what we've prototyped with VsCode, but we're still working on how we want to conclusively define that protocol. However, we can also refine the Suggestions UI independently of how the protocol is actually implemented.
This will let us rev the Suggestions UI to support other things like tooltips, recent commands, tasks, INDEPENDENTLY of us rev'ing the completion protocol.
So yes, they're both here, but let's not nitpick that protocol for now.
Checklist

Doesn't actually close anything
Heavily related to #3121, but I'm not gonna say that's closed till we settle on the protocol
See also:

#1595
#14779
https://github.com/microsoft/vscode/pull/171648

Detailed Description
Suggestions UI
The Suggestions UI is spec'ed over in #14864, so go read that. It's basically a transient Command Palette, that floats by the user's cursor. It's heavily forked from the Command Palette code, with all the business about switching modes removed. The major bit of new code is SuggestionsControl::Anchor. It also supports two "modes":

A "palette", which is like the command palette - a list with a text box
A "menu", which is more like the intellisense flyout. No text box. This is the mode that the shell completions use

Shell Completions Protocol
I literally cannot say this enough times - this protocol is experimental and subject to change. Build on it at your own peril. It's disabled in Release builds (but available in preview behind globals.experimental.enableShellCompletionMenu), so that when it ships, no one can take a dependency on it accidentally.
Right now we're just taking a blob of JSON, passing that up to the App layer, who asks Command to parse it and build a list of sendInput actions to populate the menu with. It's not a particularly elegant solution, but it's good enough to prototype with.
How do I test this?
I've been testing this in two parts. You'll need a snippet in your powershell profile, and a keybinding in the Terminal settings to trigger it. The work together by binding Ctrl+space to essentially send F12b. Wacky, but it works.
{ "command": { "action": "sendInput","input": "\u001b[24~b" }, "keys": "ctrl+space" },

function Send-Completions2 {
  $commandLine = ""
  $cursorIndex = 0
  # TODO: Since fuzzy matching exists, should completions be provided only for character after the
  #       last space and then filter on the client side? That would let you trigger ctrl+space
  #       anywhere on a word and have full completions available
  [Microsoft.PowerShell.PSConsoleReadLine]::GetBufferState([ref]$commandLine, [ref]$cursorIndex)
  $completionPrefix = $commandLine

  # Get completions
  $result = "`e]633;Completions"
  if ($completionPrefix.Length -gt 0) {
    # Get and send completions
    $completions = TabExpansion2 -inputScript $completionPrefix -cursorColumn $cursorIndex
    if ($null -ne $completions.CompletionMatches) {
      $result += ";$($completions.ReplacementIndex);$($completions.ReplacementLength);$($cursorIndex);"
      $result += $completions.CompletionMatches | ConvertTo-Json -Compress
    }
  }
  $result += "`a"

  Write-Host -NoNewLine $result
}

function Set-MappedKeyHandlers {
  # VS Code send completions request (may override Ctrl+Spacebar)
  Set-PSReadLineKeyHandler -Chord 'F12,b' -ScriptBlock {
    Send-Completions2
  }
}

# Register key handlers if PSReadLine is available
if (Get-Module -Name PSReadLine) {
  Set-MappedKeyHandlers
}

TODO

[x] (prompt | format-hex).Ctrl+space -> This always throws an exception. Seems like the payload is always clipped to
{"CompletionText":"Ascii","ListItemText":"Ascii","ResultType":5,"ToolTip":"string Ascii { get
and that ain't JSON. Investigate on the pwsh side?

Still concerned about building on their protocol camping on their OSC, but since it is very experimental it's probably OK.

You have bare unchecked TODOs in the body of this PR. I was about to merge, but I didn't want them in there unchecked--the merge message should be relatively complete. Is this PR ready? Are the TODOs relevant?

You have bare unchecked TODOs in the body of this PR

Ah, I BET that was the "; in the JSON" issue you called out earlier, because that works now!


Fix QGIS crash on plugin initialization

Fixes #993, by creating the column count first before setting their properties, and changing the index to 0 (0-based, first), since we now have only one column.
Based on the suggestion by @Huite in https://github.com/Deltares/Ribasim/issues/993#issuecomment-2187242512.
By repeatedly running pixi run test-ribasim-qgis-ui I am quite confident this fixes the issue. If I change the 0 back to 1 I got a crash again within a few tries.

It makes sense that this fixes it (although still weird that doesn't just raises an exception).
I've approved, although take a look at my review comments -- since you're looking at this anyway.

Thanks, addressed comments in 7cd92b32776c2fae8d44cbc95f7b67850b47f2b5.
Looks good now:


uucore: fix help section doesn't render 3+ level headers

While working on help for cut I've noticed that headers for levels below 2 are not rendered.
This is due to the fact that every they start with ##.
To reproduce check current help for dd command before and after the fix.
I'm not sure if it's the best solution.

I think it makes sense, but it's a bit subtle. Another way is to check that it starts with ## but not ###. Maybe that conveys the intent a bit better. Could you also add a comment?

I didn't want to add extra check as you could have ###,  ####  up to 6.

Actually, l.starts_with("##") && !l.starts_with("###") would work for any number, because #### also starts with ###. But I like your solution with an extra comment too.

Could you please add a test to make sure we don't regress in the future?

Thanks for the fix and the test :)


Health check support to run on Kubernetes with load balancer

Hi Robert - thanks for this and very sorry its taken me so long to getting around to looking at it. I've implemented hiding the nginx version in 9a271c2, but not the kubernetes stuff as that is too implementation specific


fix: config sonar issues

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?

Documentation
Update Readme docs if needed.

Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

Code formatting

Closing issues
Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

Codecov Report

Merging #92 (58d970a) into master (8565854) will increase coverage by 0.59%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   52.70%   53.29%   +0.59%
==========================================
  Files          40       40
  Lines        2605     2608       +3
==========================================
+ Hits         1373     1390      +17
+ Misses       1177     1161      -16
- Partials       55       57       +2

Impacted Files
Coverage Δ

config.go
50.00% <100.00%> (+50.00%)
:arrow_up:

map.go
13.79% <0.00%> (+13.79%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8565854...58d970a. Read the comment docs.


DBZ-3907 Build debezium tool images

https://issues.redhat.com/browse/DBZ-3907

@ani-sha, any idea on that build failure?

I take it the version updates and kcctl addition is done as a follow-up?

any idea on that build failure?

@gunnarmorling Just fixed the build failure.

kcctl addition is done as a follow-up?

Also added kcctl. Could you check if it is correctly done?

@ani-sha, any idea on the build failure?

@gunnarmorling The build was related to the website-builder image, which failed in this step https://github.com/debezium/docker-images/blob/084f1661540e6523d5976d19cb2f98cf5bb2ee53/website-builder/Dockerfile#L27 as the Gemfile and Gemfile.lock are present inside debezium/debezium.github.io.
So @jpechane suggested doing a curl from the debezium/debezium.github.io and it should work now.

So @jpechane suggested doing a curl from the debezium/debezium.github.io and it should work now.

Hum, hum, gotcha. So I'm feeling a bit uneasy about this kind of circular dependency established here between the actual project and the builder image. But I can't think of a better way either. So let's go with this for now.

And applied; thanks, @ani-sha!


[C++] Generate message pretty printers

It would be very convenient if the generated code could also pretty print (to string, ostream or whatever) in some suitable name=value format (FIX, json, protobuf ShortDebugString to name a few candidates), for debugging / logging purposes.

I dipped my toe in the water with PR #296 .  I am thinking of expanding this work by adding the ability to print to an ostream (for enums, options, decimals) as well as having a toJson() method for each message, since JSON seems the most useful human readable encoding.
If anyone has any suggestions, please let me know.

Hi,
I'm interested in working on this.
Is it still relevant? Is someone else working on it?

@MatthiasKauer We would be happy accepting a PR for this.


NavigationBarTitle Large does not display

Whenever I use    .navigationBarTitleDisplayMode(.large) in any of my screens... it either doesn't display the title or makes it inline.
Do you know what might be the issue?

Hello @AdzeB, I think the default display mode of the navigationBarTitle("Title") method is .large when you set the title with this method, and if you want to change its display mode then you can use this method, .navigationBarTitle("Title", displayMode: .inline).

Hello @cp-amisha-i , Thanks.


Does Crash every 10 minutes

Currently I am using Docker 20.10.0 and the latest version of castblock.
Every 10 minutes the container crashes.
This causes that castblock is not able to block the ads until the container restarts.
Also it would be clever to implement a healthcheck

This seems like a bug in go-chromecast. Do you mind reporting it here? https://github.com/vishen/go-chromecast


[SelectInput] Input's 'type' prop cannot be overwritten [bug]

[x] I have searched the issues of this repository and believe that this is not a duplicate.
Expected Behavior
I want to set the value of select input's 'type' prop to 'text' ('hidden' by default).
  <Select
    key="input"
    multiple
    value={this.getSelectedKeys()}
    renderValue={() => this.getSelectedValues()}
    onClick={(e) => this.showMenu(e.currentTarget)}
    input={<Input />}
    inputProps={{
      id: this.props.id,
      classes: { input: classes.input },
      type: "text",
      readOnly: true
    }}
  />

Current Behavior
There is possible to overwrite any other input's prop except 'type'.
Steps to Reproduce (for bugs)
The problem lies here:
https://github.com/mui-org/material-ui/blob/c83a60e4ef175d4405540f00a1079a25bf8acc12/src/Select/SelectInput.js#L296
Swapping the lines 295 and 296 should fix this bug.
Context

Your Environment

Tech
Version

Material-UI
1.0.0-beta.33

React
16.2.0

browser
Chrome

I'll try to fix this by myself! :)


added Makefile

replacing build script build.sh with GNUMake file. This will allow
one script to build, test, run go tool such as lint fmt and build
Docker image.
Change-Id: Ic4bc7db14e5e276902daaeefe13a6a55277d57eb

LGTM now, thanks for all the updates!

Thanks for your thorough review @zshi-redhat . Going to merge this now.


hystrix - best practise for logging exceptions

I'm trying to log the "potential" exception of longRunning within fallback
@Component
public class MyService {

  @HystrixCommand(fallbackMethod = "fallback")
  public void longRunning() {
     // this could fail
  }

  public void fallback() {
    // fallback code
  }
}

Trying to access HystrixRequestLog.getCurrentRequest() within the fallback method throws

java.lang.IllegalStateException: HystrixRequestContext.initializeContext() must be called at the beginning of each request before RequestVariable functionality can be used.

Is there any documented best practise?
Could the fallback method additionally offer access to the HystrixCommand object, which has the exception trace if any ...?

Could the fallback method additionally offer access to the HystrixCommand object,

I don't think that is possible with the current implementation of Javanica. I'm not a huge fan of Javanica though so there is a good chance we'll replace or enhance it at some point.
You can log the exceptions using logging.level.com.netflix.hystrix.AbstractCommand: DEBUG. Or you can set up the HystrixRequestLog in the caller of MyService, but it isn't done for you.

Thanks for the information - setting the logging level at least logs it now - although it looks quite serious as the complete stack trace is logged.

Dave,
Replacing javanica sounds like an interesting idea.  Out of curiosity, what do you see as javanica shortcomings?  Whats on the wish list?

@joshuawhite929 I think the async and Observable support was an afterthought (the programming model is ugly anyway). It will also be difficult (I think) to re-use javanica for other circuit breaker libraries. I don't have any concrete ideas about how to replace it, so nothing will happen in the short term anyway.

I ran into the same problem and solved it by switching from javanica to an anonymous class. Then I can access the exception:
    private HystrixCommand<Collection<Resource<ZipCodeData>>> getZipCodeDataCommand(String location) {
        return new HystrixCommand<Collection<Resource<ZipCodeData>>>(
                HystrixCommand.Setter
                        .withGroupKey(HystrixCommandGroupKey.Factory.asKey("geodata"))
                        .andCommandKey(HystrixCommandKey.Factory.asKey("getZipCodeData"))
                        .andCommandPropertiesDefaults(
                                HystrixCommandProperties.Setter()
                                        .withExecutionTimeoutInMilliseconds(TIMEOUT)
                        )
        ) {
            @Override
            protected Collection<Resource<ZipCodeData>> run() throws Exception {
                HashMap<String, Object> arguments = new HashMap<>();
                arguments.put("searchterm", location);
                ParameterizedTypeReference<PagedResources<Resource<ZipCodeData>>> responseType = new ParameterizedTypeReference<PagedResources<Resource<ZipCodeData>>>() {
                };
                String href = homeResourceRepository.getHomeLink("search", "geodata").expand(arguments).getHref();
                URI uri = new URI(href);
                ResponseEntity<PagedResources<Resource<ZipCodeData>>> byZip = restTemplate.exchange(uri, HttpMethod.GET, null, responseType);
                return byZip.getBody().getContent();
            }

            @Override
            protected Collection<Resource<ZipCodeData>> getFallback() {
                Exception exception = executionResult.getException();
                if(exception==null){
                    LOG.warn("geodata fetch fallback! ZipCodeData for: '{}' NO EXCEPTION", location);
                }else {
                    LOG.warn("geodata fetch fallback! ZipCodeData for: '{}' Error:{}", location, exception.getMessage());
                    LOG.debug("Stacktrace: ", exception);
                }
                return new ArrayList<>();
            }
        };
    }

Closed for lack of feedback. Please, reopen if there is something new to add.


Add support for DXIL shaders

Description
It seems like I am not allowed to use DXIL with RenderDoc. Capturing isn't enabled when doing so. It would be a great feature to be allowed to. I don't necessarily need extensions with DXIL such as raytracing or shader introspection, but I'd very much like to view information the same way as with DXBC. I'm assuming the problem you'd have is that you require a ID3D12ShaderReflection object and you can't use D3DReflect to acquire that. You can however link dxc and use the following code on the compiled blob:
IDxcLibrary* lib{};
doHr(DxcCreateInstance(CLSID_DxcLibrary, __uuidof(IDxcLibrary), (void**)&lib));

IDxcBlobEncoding* binBlob{};
doHr(lib->CreateBlobWithEncodingOnHeapCopy(bin.data(), bin.size(), CP_ACP, &binBlob));

IDxcContainerReflection* refl{};
doHr(DxcCreateInstance(CLSID_DxcContainerReflection, __uuidof(IDxcContainerReflection), (void**)&refl));

doHr(refl->Load(binBlob));
doHr(refl->FindFirstPartKind(hlsl::DFCC_DXIL, &shaderIdx));

ID3D12ShaderReflection* shaderRefl{};
doHr(refl->GetPartReflection(shaderIdx, __uuidof(ID3D12ShaderReflection), (void**) &shaderRefl));

//... reflect
// .. Release objects

where bin is the binary as an std::vector<std::uint8>.
Steps to reproduce
Get a DX12 binary with DXIL shaders.
Environment

RenderDoc version: v1.6 https://github.com/baldurk/renderdoc/commit/0e7f772596035137416be01766c2d61205efc63e
Operating System: Windows 10 1909 18363.628
Graphics API: DirectX 12 SM 6.0

Yes, you must query for support using ID3D12Device::CheckFeatureSupport and D3D12_FEATURE_SHADER_MODEL to see what shader models are supported, and it is illegal to use DXIL without that support being reported as available. If you're seeing this error then your code is incorrect and is not checking for support before trying to create a pipeline using DXIL.

But SM 6.0 & DXIL is supported on all modern hardware, nvidia has added support to even very old GPUs (I don't fully know about AMD). It runs fine and I have an RTX 2080 Super with latest drivers, so by all standards it should be supported. DXBC (SM 5.0) is not stored for the shaders so cannot be used.

It also must be supported by the runtime, hence the feature check. Widely supported isn't the same thing as unconditionally supported.

I can't bring much to the conversation, but I would like to second the request to add DXIL support to RenderDoc.
If I understand you correctly Baldurk, his code is wrong because it doesn't query for the shader model support, but RenderDoc being injected is ultimately the reason the runtime reports that DXIL is not supported, is this correct?
My shaders run perfectly fine without injecting RenderDoc, or while debugging using PIX. But I would very much like to be able to completely uninstall PIX and use RenderDoc which is superior in so many ways.

Yes RenderDoc is intercepting the query and returning a lower shader model capability than the runtime/driver actually supports. It does this for other things that are unsupported as well like raytracing. My point is that your code could run on a different system where the runtime/driver doesn't support SM6 so you still need to query.
DXIL support is something I'm aware of but I currently don't have an estimate on when it may be supported. I do plan to handle it eventually but unfortunately by its nature DXIL is not particularly tool friendly and is really only intended for use by MS's runtime and drivers, so is going to be quite painful to support. Currently there are higher priority things to look at elsewhere.

There are plenty of valid scenarios where someone might not support anything but DXIL.

Kiosk or location-based system where you have fixed hardware.
Demo, sample, or R&D framework where supporting every hardware combination is not the goal.
Most games look at PC scalability fairly late in the process - dropping down to SM5 would be considered PC scalability, and even if your engine can do it, you might not have everything compiling in SM5. Plus compiling two sets of shaders on shader generator systems like UE4 is a huge drag on development speed.

So it's fine if you've put this on low on the priority list for other reasons, but let's acknowledge there are perfectly valid scenarios to only support SM6/DXIL.

Sure to be clear I'm not saying that everyone is forced to support SM5 nor that there aren't cases where it makes sense to only target SM6. What I mean is that you should at least check for it at startup even if all you do is "if less than SM6, fatal error".

Probably, but that seems kind of a minor detail beside the point.
The problem is people would like to use RenderDoc w/SM6, and RenderDoc doesn't support DXIL. DXIL, like it or not, has become part of the D3D12 ecosystem.
I feel like this discussion detracted from that core issue.

I'm not sure I really understand what you're getting at. I understand that the request is to add DXIL support, that's why this issue is open and marked as an unresolved feature request to track that. It's not as if I'm closing this issue as resolved because the query exists. As I mentioned above I do plan to do it at some stage, and I get that until it's implemented then this is a blocker if you don't have any kind of fallback path.
I explained how to query for DXIL support because this is not only a RenderDoc problem, as if you were to run code that assumed DXIL support on a PC which didn't have it then you'd likely crash. Whether you have a fallback or a fatal error or whatever else is up to what makes sense for you. Having that feature query doesn't have any effect on when DXIL support might be added, so what's the problem with explaining it?

Regardless; the GPUs that don't support SM6 are long gone by now (GTX 5xx series which were released 8 years ago) and if they aren't, they wouldn't be able to run the programs anyways (since they don't have enough VRAM). Intel still has integraded cpus that are very old that don't support it, so that could be the only reason to detect it.
Supporting DXIL by itself doesn't mean we want raytracing support. Like I mentioned; you don't have to support every extension. I'd be fine with just debugging DXIL without raytracing and then using pix for the remainder.

DXIL does require both hardware and software support, both in terms of a recent enough driver and recent enough version of windows, but I appreciate that it's quite possible you may be reasonably assuming that it's supported and in that case RenderDoc will disable capturing and display an error message. This isn't the only case where not checking for feature support or not checking error messages may trip you up while running under RenderDoc (e.g. trying to use raytracing interfaces will likely crash) which is why I pointed out the recommended way in the API to query for support. Whether you query or not, DXIL isn't supported currently so all it gives you is a nicer way to handle that case (whatever handling that may be).
Again, I understand that the feature request is to support DXIL and I never suggested that this wasn't a valid feature request, I honestly don't understand where anyone has gotten that impression. I also definitely know that it's possible to support DXIL without supporting raytracing and I get that there is value in supporting one without the other. I only mentioned raytracing in the context of another case where RenderDoc will change the reported functionality to less than what the driver supports.
As I mentioned above, supporting DXIL itself without any extensions is still a lot of work and right now it is not a priority to work on. This issue will track any progress and I will update here when DXIL support is implemented, as with any other feature request.
Unfortunately I have limited time and resources and that means I cannot instantly start working on every feature request that is made. I have to make a judgement call based on the amount of work required, the audience and the potential benefit. I appreciate that this is a blocking issue for projects that require DXIL, so for you it may be very important, but only a certain fraction of users are working on such projects so that must be weighed up against the benefit of features for a larger group of users.

I've pushed support for DXIL shaders and that commit removes the restriction on capturing and replaying as well as allowing up to SM6.6 from the CheckFeatureSupport query.
If you run into any bugs related to DXIL shaders (and I'm sure there will be some) please file them as new issues with a repro case.

Thank you very much, will be very useful to me


The current validity bond is less than half of the previous validity bond.

From my understanding, the current validity bond will not be less than half of the previous one.
But It seems to me that it has decreased by about 62.4%.

The previous validity bond is that:
validityBond [InAttoEth]:<PHONE_NUMBER>8340618
blockNumber: 7246596
timestamp(UTC datetime):<PHONE_NUMBER>(2019-02-20 23:59:55)

The current validity bond is that:
validityBond [InAttoEth]:<PHONE_NUMBER>4833033
blockNumber: 7246597
timestamp(UTC datetime):<PHONE_NUMBER>(2019-02-21 00:00:20)

I got these values by calling the contract function getOrCacheValidityBond using Web3.js.
'use strict';
const Web3 = require('web3');
main();

async function main(){
  const web3 = new Web3('https://eth-mainnet.alchemyapi.io/jsonrpc/7sE1TzCIRIQA3NJPD5wg7YRiVjhxuWAE');
  const abi = getAbi();
  const universeAddress = '0xe991247b78f937d7b69cfc00f1a487a293557677';
  const contract = new web3.eth.Contract(abi.Universe,universeAddress);

  let blockNumber = 0;
  let validityBondInAttoEth =0;

  //"blockNumber": 7246596, "timeUtc": "2019-02-20 23:59:55", "timestamp":<PHONE_NUMBER>,
  blockNumber = 7246596;
  validityBondInAttoEth = await contract.methods.getOrCacheValidityBond().call(undefined,blockNumber);
  console.log('blockNumber:'+blockNumber+'\n'+'validityBondInAttoEth:'+validityBondInAttoEth+'\n');

  //"blockNumber": 7246597, "timeUtc": "2019-02-21 00:00:20",  "timestamp":<PHONE_NUMBER>,
  blockNumber += 1;
  validityBondInAttoEth = await contract.methods.getOrCacheValidityBond().call(undefined,blockNumber);
  console.log('blockNumber:'+blockNumber+'\n'+'validityBondInAttoEth:'+validityBondInAttoEth+'\n');

}
function getAbi(){
  return     {
    "Universe": [
    {
      "constant": false,
      "inputs": [],
      "name": "getOrCacheValidityBond",
      "outputs": [
        {
          "name": "",
          "type": "uint256"
        }
      ],
      "payable": false,
      "stateMutability": "nonpayable",
      "type": "function"
    }
    ]
  }
}

The result is that:
blockNumber:7246596
validityBondInAttoEth:26994944668340618

blockNumber:7246597
validityBondInAttoEth:10154469944833033

For your reference, the whitepaper says as follow:

This is a bug in the v1 contracts where if no markets resolve in a given week the bond will return to its original default value. It should instead stay the same as it was previously.

Ah yes, there's nothing we can do about this for v1 but it has been fixed in the v2 code already iirc.
We don't have a ticket for that because it was in Clubhouse -- but @nuevoalex I think we should basically mark this as a dupe.
Can you add a link to the fixed code for perpetuity and we can dupe this?
@CrystalBallBe -- Thanks for investigating this!

I'm wrong about that above feedback.
@nuevoalex Did you schedule fixing this?

Yup! There's a task in the backlog


⚠ gorzdrav.org has degraded performance

In 59062f6, gorzdrav.org (https://gorzdrav.org) experienced degraded performance:

HTTP code: 200
Response time: 1947 ms

Resolved: gorzdrav.org performance has improved in b1b465a.


[$250] [HOLD for payment 2024-12-11] Android - Expense - Save button moves up and down when keyboard is open

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.67-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
**Email or phone of affected tester (no<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Launch ND or hybrid app.
Go to workspace chat.
Tap + > Submit expense > Manual.
Enter amount > Next.
Tap Merchant.
Might have to exit merchant editor and tap Merchant field again to see Save button move when keyboard is open.

Expected Result:
Save button will not move up and down when the keyboard is open.
Actual Result:
Save button moves up and down when the keyboard is open.
Similar behavior is seen across the app when keyboard is open and where there is Save or Submit button.
Workaround:
Unknown
Platforms:

[x] Android: Standalone
[x] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/c576183f-5213-4e66-939c-d2e20fcd0b3a

View all open jobs on GitHub
Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021865866933542877637
Upwork Job ID:<PHONE_NUMBER>542877637
Last Price Increase: 2024-12-08

I already mentioned this problem here - https://github.com/Expensify/App/pull/42143#discussion_r1858383050
This is PR that introduced new hook useSafePaddingBottomStyle hook, that updates style from JS thread. However new implementation of KeyboardAvoidingView is based on reanimated usage (i. e. synchronous style changes depending on keyboard position), but this hook performs updates in JS (which are slower) and because of that we see this two stage update on Android.
We can fix it:

by making useSafePaddingBottomStyle returning an instance of useAnimatedStyle;
or by specifying necessary margin pb5 as keyboardVerticalOffset property in KeyboardAvoidingView (this approach is preferable, because we don't need to create many animated views and a single view will control keyboard interpolation).

However it's pretty big changes in both variants and it will take some time to implement (because useSafePaddingBottomStyle implicitly gets used in many places already, so we will have to go through each screen and verify that there is no jumps).
@mountiny do you think we can deprioritise this and remove blocker label? It was kind of something expected to see such instant button shifts, and I wanted to handle it in follow up tickets (but again it'll take some time to prepare a PR).

I agree, lets do this properly without rushing. I think its not that major to block deploy, user can use the app fine

I have a standing Android <> ios bug swap with @jliexpensify.

@mountiny - if @kirillzyusko needs some time to work on this, shall we make this a weekly?

I think we can keep it daily so @kirillzyusko can work on this with urgency in the coming days.
Can you base your changes on this PR, @kirillzyusko please? https://github.com/Expensify/App/pull/53250

PR in main

@mountiny should we change PR title to show that the fix in main branch?

Payment Summary

C: @ZhenjaHorbach $250 (to be paid via Upworks)
C+: @allroundexperts $250 (to be paid via ND)
@kirillzyusko (Agency)

Upworks job
Just waiting on the checklist

BugZero Checklist:

[x] [Contributor] Classify the bug:

Source of bug:

[x] 1a. Result of the original design (eg. a case wasn't considered)
[ ] 1b. Mistake during implementation
[ ] 1c. Backend bug
[ ] 1z. Other:

Where bug was reported:

[ ] 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
[ ] 2b. Reported on staging (eg. found during regression or PR testing)
[x] 2d. Reported on a PR
[ ] 2z. Other:

Who reported the bug:

[ ] 3a. Expensify user

[ ] 3b. Expensify employee

[ ] 3c. Contributor

[ ] 3d. QA

[x] 3z. Other: Agency member

[x] [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/42143#discussion_r1858383050

[x] [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A

[x] [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

[ ] [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:

Regression Test Proposal
Precondition:

Login to the App using an account that has a workspace chat.

Test:

Launch NewDot App.
Go to workspace chat.
Tap + > Submit expense > Manual.
Enter amount > Next.
Tap Merchant.
Exit the merchant editor and tap Merchant field again.

Verify that the save button will not move up and down when the keyboard is open.
Do we agree 👍 or 👎

Paid and job closed, @allroundexperts here is the payment summary.


CAN'T CREATE WALLET

Failed to fetch
The above error occurred in task vr
created by vr
created by takeEvery(account/fetchAccount, vr)
created by xr
Tasks cancelled due to error:
takeEvery(account/fetchAccount, vr)
Or
TypeError: Failed to fetch

I haven't seen "Failed to fetch" on here, but it sounds like it would come from the block explorer interaction, since grpc-web uses xmlhttprequest internally.
We're trying some things to improve the stack traces. But for now:
@Sugidigi, could you find if there are any failed requests in the developer tools network panel?


Integrating golangci-lint

What this PR does / why we need it:
Repository housecleaning.
Which issue(s) this PR fixes
Partially addresses #1176, baby steps towards #1178
Special notes for your reviewer:
Seems like GitHub is not running the actions on this PR as vmware-tanzu, but it's available on my fork
Release note:
NONE

@wilsonehusin Please squash commits and include signoff


Don''t clear text on device rotation

https://github.com/SCOTT-HAMILTON/Trollslate/commit/aa716799de1b2088143151a2d5be96d93ce2e929

Sorry but I'm not sure to understand what's the issue, maybe I somewhat fixed it while working on the other issues.
Becaus when I write some text on the trollTextField and then change the phoneAngle, the textField still keeps its content.

Did you change the angle with 90°?
From portrait to landscape...

Still an issue on Delacroix


Docs: fix typos in removed event docs

Noticed these on http://canjs.com/docs/can.events.removed.html

Awesome, thank you.


"Change folder" doesn't remove the old folder

Operation System: MacOS 10.12.5
Beaker Version: 0.7.2
Perhaps I'm misunderstanding the purpose of the feature but shouldn't it move the content to a new folder and remove the old one?

We're planning to add a prompt, "Do you want to remove the old folder?"


SubsetTrieError is really not that helpful

The SubsetTrieError has a single variant that could be a lot better:
pub enum SubsetTrieError {
    #[error("Tried to mark nodes in a tracked trie for a key that does not exist! (Key: {0}, trie: {1})")]
    /// The key does not exist in the trie.
    UnexpectedKey(Nibbles, String),
}

There are two issues with it:

The error string itself can only be created if we traverse over a hash node when marking nodes that a given set of keys access.

While the error string is technically correct, it's not really clear that we encountered a hash node.
On top of this, if we end up traversing down the trie and end up hitting an empty node, even though there is not a leaf at the end of the path, this will not trigger the error (despite the node "not existing"). The reason for this is when an insert occurs in a sub-trie, we need to ensure that all of the nodes down to it are not hashed out before the insert occurs (hence the node should be an empty node).

Both of the arguments used by the error are very unhelpful is the majority of the cases.

The first argument of Nibbles is only the remaining part of the key that was left when we encountered the hash node.
The second String argument is the entire trie, which is pretty unhelpful if the trie is large.
Ideally (although difficult), we should probably include:

The trace from the root down to the hash node (if possible using the same format that trie queries use).
The entire trie in a format that is easily usable by trie diff & trie query (do we actually need this?).

Came up from #503.

The second String argument is the entire trie, which is pretty unhelpful if the trie is large.

While this is generally true, the only place we're actually leveraging this error is upon facing a hash node with remaining Nibbles, so we will only print a single node as opposed to a huge trie. But if we were to use this elsewhere then it definitely would be a problem.
Otherwise I'm agreeing that printing the remaining part of the key only is usually insufficient, unless the hash node is located sufficiently close to the root to still carry meaningful info.

so we will only print a single node as opposed to a huge trie

Oh that's true, good catch.
If I can instead change this error to instead include a query of the traversal (so it includes each node and it's associated key), should I go ahead and make that change?

I don't think we need to even bother with the intermediate nodes. Having the final hash node and the whole key should be enough I think 🤔

Hmm maybe... I might be remembering wrong, but when we hit hash nodes during sub-trie generation, wasn't it helpful to know what the parent node was immediately above the hash node? I think this might be pretty easy to impl since we can just do a trie query on error.

Hmm I didn't encounter this myself, but maybe that was helpful for some edge cases yeah.. Although if you have the whole key you can use the trie_query tool to see the whole path, without clogging all the error responses (in case the intermediate nodes don't matter for most cases). But I'm not strongly opinionated on this.

I put together most of a PR yesterday to use trie_query, so my gut is lets just add that (since it's definitely an improvement from what we currently have).


Varun Malpani

Rules:-
1)Follow @shubham7668 and add star in this repository
2)No c++/c file will be accepted
3)Add snapshots of working project
Follow all rules in order to get hacktoberfest-accepted tag

Done.
On Wed, Oct 5, 2022 at 2:19 AM Nehal @.***> wrote:

Rules:-
1)Follow @shubham7668 https://github.com/shubham7668 and add star in
this repository
2)No c++/c file will be accepted
3)Add snapshots of working project
Follow all rules in order to get hacktoberfest-accepted tag
—
Reply to this email directly, view it on GitHub
https://github.com/shubham7668/hacktober/pull/223#issuecomment-1267561214,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXZJK46AJI3FAHYQOQALC3DWBSJ5VANCNFSM6AAAAAAQ45C3NA
.
You are receiving this because you authored the thread.Message ID:
@.***>


[MudSelect] Control popover width

Description
MudSelect hardcoded the RelativeWidth of the MudPopover to true. This ensures that the popover width matches the select field width. However, when items available for selection are longer than the width of the select field, they are cut off. This may not always be desirable.
This change

Utilizes the FullWidth parameter from MudBaseInput

Forwards that value to the MudPopover component
Defaults to false which is the opposite of the current behavior (current behavior is considered a bug)

Updates mudPopover.js to set either min or max width based on the value of RelativeWidth

While a non js fix would be preferred, the current js is what enforces the max-width restriction and without setting min-width, the popover may render smaller than the select field, instead of matching its size, when RelativeWidth is false and the item list options are short in length.
Resolves #10195
How Has This Been Tested?
Visually - unit test viewer
Added a  unit test to confirm applied popover classes
Type of Changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (fix or improvement to the website or code docs)

Checklist

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[x] I've added relevant tests.

cc @versile2

Wouldn't false be a better default?

Sure, just figured I'd leave the current behaviour as is. But yes, I could change that

ahh we were just discussing this, FullWidth (which defaults to False) is used on MudMenu to do this and defaults to false. I would suggest matching this behavior especially if the default is going to be false anyways. Also AutoComplete is affected by the same limitation/bug.

Just saw the conversation on #10204. Based on that, should I use FullWidth in the MudSelect instead of RelativeWidth and default said FullWidth to false?  This would allow the popover to exceed its parent by default and if the user sets it to true it would match the select field size.

I would say so and match the behavior to mudautocomplete, fullwidth is inherited from mudinputbase for those two so no need to even add a property.

Yes, that's what I did. By use it in the select I didn't mean add a new property but use the inherited one.

Yeah, already done

I thought about that and I don't.  I can't think of a valid use case where the page shouldn't grow right of content exceeds

regression https://github.com/MudBlazor/MudBlazor/issues/10235


Iusse while building app

I tried integrating the Stripe payment gateway by going through your given docs. Stripe should work on the local server or not. But when pushed on the server getting some error. I have attached the error image screenshot given below.

@Altamash-s-s The stripe module is installed incorrectly.
Pls, check your directory: ./vue-storefront/src/modules/

I followed all steps which you have given and applied one by one correctly but now after selection of stripe payment way, on order placing getting this Error1: "Error placing an order. Cannot place order because a payment  method was not provided."
Error2: "The order can not be transferred because of server error. Order has been queued". I have attached Error screenshot.


Don't depend on prometheus's default features.

Fix #5.

Thanks for the PR blush will release a new version later today.

I don't see the new release yet.


After update: Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'replace')

After update getting this error with icons failing to load. Found where error is coming from. Fixed when removing ":.replace(/^i-/, ''))"
From changelog:

const iconName = computed(() => (appConfig.nuxtIcon?.aliases || {})[props.name] || props.name)

const iconName = computed(() => ((appConfig.nuxtIcon?.aliases || {})[props.name] || props.name).replace(/^i-/, ''))

Console error:
Icon.vue:25  Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'replace')
at ReactiveEffect.fn (Icon.vue:25:97)
at ReactiveEffect.run (chunk-BVQHDTV7.js:423:19)
at get value [as value] (chunk-BVQHDTV7.js:1383:35)
at Icon.vue:54:22
at callWithErrorHandling (chunk-BVQHDTV7.js:1565:32)
at ReactiveEffect.getter [as fn] (chunk-BVQHDTV7.js:3099:22)
at ReactiveEffect.run (chunk-BVQHDTV7.js:423:19)
at doWatch (chunk-BVQHDTV7.js:3195:26)
at watch (chunk-BVQHDTV7.js:3050:10)
at setup (Icon.vue:54:1)

Seeing this on a clean install, npx nuxi init + npm i nuxt-icon

I've got the same problem, i there a fix other than the open pr?
Maybe going to an older version?


No logo in NavBar

there is no logo in nav bar so plz assign me this issue

I would like to work on this issue. Please assign this task to me as the label of Gssoc24 and level.


Adding the melody editor block to the music drawer

A new category was created in the music drawer called "melody" where the new block will reside. The block uses playUntilDone() and therefore is blocking. This allows multiple melodies to be stacked to create longer melodies. The picture below is an example of how to play a melody in the background of a game and conditionally change the type of music.

This block should be near the top of the drawer. All this work to hide it at the bottom.

This block should be near the top of the drawer. All this work to hide it at the bottom.

Yea I think it needs to be moved higher as well. The whole drawer may need to be rearranged, though. There are some blocks that are not compatible as well. Like the set tempo block does not change the tempo of the melody from the melody editor.

Not sure where to report this but I seem to get "calling non-function" when trying to call play melody from a forever block.

@chino please open an issue in the relevant editor repo (microbit, arcade, adafruit) and include a share link with the code that is giving you the error. You can create a share link for a project like this:

Thanks!


Add react@18 as peer dependencies

I wanted to use this in a new ephemeral project but react version was incompatible.
For now I use it as a local library but it would be nice to be able to install it through yarn :)
Thanks

@themouette Hey! You can use overrides in your package.json file:
"overrides": {
    "react": "^18.2.0",
    "react-dom": "^18.2.0"
  }

But this pull request still needs to be merged of course.

Oh right, sry for the delay, LGTM of course :)

Build failed because of the outdated Github Action configuration. I'll release a new package on NPM tomorrow.


nerdctl0 not created after deleted

when I first use nerdctl, the bridge "nerdctl0" is created. but after I delete that bridge using "ip link delete", the bridge never created again.
what should I do to resolve it?

Does it work after rebooting?

No, I tried but it does not work. I look into the code and can't find where the bridge is created. Can you show me where that bridge is created? thanks!

The bridge is created by just running CNI bridge plugin
https://github.com/containerd/nerdctl/blob/46be3b7fd8d8921603d3844475abb784f06077e6/pkg/netutil/netutil_unix.go#L38-L56
https://github.com/containernetworking/plugins/tree/v1.0.1/plugins/main/bridge

Do you see any error when you run sudo nerdctl --debug-full run --rm  alpine ip a?
Does dmesg show anything related?

In my machine, start container using nerdctl will give a error: FATA[0001] failed to create shim: OCI runtime create failed: container_linux.go:349: starting container process caused "error adding seccomp filter rule for syscall clone3: permission denied": unknown
So I suppress the seccomp by using --security-opt "seccomp=unconfined" then I can start container without warning. it show:
DEBU[0000] detected <IP_ADDRESS> nameserver, assuming systemd-resolved, so using resolv.conf: /run/systemd/resolve/resolv.conf
DEBU[0000] final cOpts is [0x7704c0 0x7707e0 0x770850 0x770680 0x7703f0 0x770540 0x770540 0x770af0]
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN qlen 1000
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
inet <IP_ADDRESS>/8 scope host lo
valid_lft forever preferred_lft forever
inet6 ::1/128 scope host
valid_lft forever preferred_lft forever

Also, there is nothing related in dmesg.

The bridge is created by just running CNI bridge plugin
https://github.com/containerd/nerdctl/blob/46be3b7fd8d8921603d3844475abb784f06077e6/pkg/netutil/netutil_unix.go#L38-L56
https://github.com/containernetworking/plugins/tree/v1.0.1/plugins/main/bridge

But where nerdctl call the lib of cni? I can't find the entry.

clone3

Please make sure to run nerdctl v0.11.2 or later.
https://github.com/containerd/nerdctl/pull/360

But where nerdctl call the lib of cni? I can't find the entry.

Here: https://github.com/containerd/nerdctl/blob/46be3b7fd8d8921603d3844475abb784f06077e6/pkg/ocihook/ocihook.go#L321

Thanks @AkihiroSuda -, I reinstall runc and the issue is gone. Maybe the runtime is old and won't compatible with the oci-hooks offered by nerdctl. But I'm also confused with that runc is not used by containerd, so, why runc will affected the result.

runc is not used by containerd

used.

runc is not used by containerd

used.

Yeah, containerd-shim-runc-v2 call runc. thanks!


[VEGEMITE-312] Bump zendesk_apps_support to 4.29.5

:v:
/cc @zendesk/vegemite
Description
Fixes a security vulnerability.
Compare diff: https://github.com/zendesk/zendesk_apps_support/compare/v4.29.2...v4.29.5
Changes

https://github.com/zendesk/zendesk_apps_support/pull/281 (low risk, adding validation for manifest type oauth)
https://github.com/zendesk/zendesk_apps_support/pull/285 (no risk, version bump only)
https://github.com/zendesk/zendesk_apps_support/pull/268 (Makes the oauth param required when the oauth section is present.) @fbvilela , do you know what the risk of this change is?
https://github.com/zendesk/zendesk_apps_support/pull/287 (no risk, version bump only)
https://github.com/zendesk/zendesk_apps_support/pull/284 (low risk, deprecate old ruby versions)
https://github.com/zendesk/zendesk_apps_support/pull/259 (low risk, dependabot pr merge + bug fix).

References

JIRA: https://zendesk.atlassian.net/browse/VEGEMITE-312

Risks

Low. Might lead to regressions in functionality.

Closing in favour of https://github.com/zendesk/zendesk_apps_tools/pull/346.


Change the VMware disk controller to PVSCSI

The mptspi and mptscsih kernel modules, needed for the older LSI Logic
controller, have been deprecated in CentOS 6.8 and 7.2 (see issue #386)
https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/6.8_Technical_Notes/chap-Red_Hat_Enterprise_Linux-6.8_Technical_Notes-Deprecated_Functionality.html
https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/7/html/7.2_Release_Notes/chap-Red_Hat_Enterprise_Linux-7.2_Release_Notes-Deprecated_Functionality.html#idp5588384

My proposed patch made changes to the wrong part of the code - closing, sorry.


Something goes wrong when I open my .json files.

In my vimrc file, I  have "set cursorline cursorcolumn".
When I open a json file with this plugin off:

While with it on:

(1)My double quotation disappers
(2)My cursor gets into a mess
How can I solve the problem? Thanks.

Please refer to issue #140 .


Introducing new  prop - allowModifiedKeys

In some cases I want to allow the special keys (e.g. alt, ctrl, meta, shift) to be pressed while clicking on a Link component.
This new prop (default false) will allow just that.

We need to ignore these keys, as they map to new windows and tabs in most browsers. If we don't, the browser behavior will change.


Remove lodash dep in odsp driver

Yeah, I think we will be able to reduce the size of driver by a lot with this change, lets see.


[Functions] Add a flag to create the storage account in az functionapp create

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
Add a flag to create the storage account in az functionapp create, this will not change the current behavior, also it will allow for a more streamlined approach to creating function apps
Intended behavior after this proposal:

If storage account information is provided --> use this [existing behavior]
If # 1 is not provided and create storage flag is provided --> create a storage account with appname-strg (need to make sure the name is valid) [new behavior]
If none are provided --> throw and error [existing behavior]
If # 1 and # 2 are provided, use the provided storage account

This CLI command is owned by Functions team.


Encryption for Azure Redis Cache

Could you please add about encryption at rest and transit ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c84b7eee-6a44-a59b-a6ac-f9b483e51193
Version Independent ID: a01b9cf7-2ae7-7bcd-8c6c-8d0c01162970
Content: What is Azure Redis Cache?
Content Source: articles/redis-cache/cache-overview.md
Service: cache
GitHub Login: @wesmc7777
Microsoft Alias: wesmc

@dhanvi I have forward this to the content owner to evaluate and update as appropriate.

Yes, we'll add this soon.

This is being looked into.

Waiting for Monday build verification.

#please-close


WIP: TextQuestionForm

Description
Please explain the changes you made here.
Checklist

[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

Issue(s)
Fixes #<issue_number>; Fixes #<issue_number>; Fixes #<issue_number>...

This is an out-of-date PR. This work has since been merged via a different PR.


DBZ-6870 add more debugging information to detect stuckness

@nancyxu123 Is this something I should pay attention too? If not and it is WIP could you please mark it as a draft?

@nancyxu123 Is this something I should pay attention too? If not and it is WIP could you please mark it as a draft?

It's WIP! Marking it as draft thanks!


Dedupe 360Link results

Lots of links can be presented right now.  Probably with many repeated.  Look at deduping results.

Still needs work, but better than before.
Consider merging on ProviderId +  Start + End date ranges.

Now sorting by database and only providing one link per provider.


Add support for Multiple Checkboxes

Supersedes #222.

This is now ready for review. r=? @almet @Natim @leplatrem

SHIP IT!

Released in v0.33.0.


Deal better with restarted peers

Improves the behaviour reported at #28.

I reckon the isConnectedPeer should be lifted out, i.e. the flag passed to doAddConnection should simply be an indication as to whether this is a "new" peer, where "new" includes "restarted".
That indicator should be calculated by registerRemote: a peer is "new" if a) it is not present in the topology, or b) is present and has a different UID, or c) is present and has no connections.

c) is present and has no connections.

The reason we need this is because we may, temporarily, have multiple connections to the same peer.
Looking at this again, perhaps we should leave the code in this PR as is. After all, it does address the problem, and is quite straightforward.

I have rebased and made the change suggested at https://github.com/weaveworks/mesh/pull/29#issuecomment-199783229.
A couple of aspects are now potentially hard to follow: the computation of isJustAddedPeer which relies on the behaviour of fetchWithDefault, and the absence of locking round len(conn.remote.connections), which (I think) relies on remote not being the local peer and connections never being modified after creation on a remote peer.
CircleCI tests have failed, which seems to be in the etcd code and unrelated.

As discussed, the "has no connections" tests is probably too narrow. When two clusters come together, a 2nd in-progress connection between them may well find the other peer in the topology, with lots of connections to peers on its side of the cluster. We'd still need to send it the full gossip, so it can learn about our side of the cluster.
The symmetric unicast route check of the previous version is a conservative approximation of whether another peer is part of our cluster, which is kinda what we want here.

I removed the last commit, so now we are back to checking the unicast topology.

LGTM. @peterbourgon what's up with the CI failures?

@rade It's the vendoring nonsense. Needs a rebase on master to get this.

I'll do that...


Some references to files are missing in stack trace with async/await

Stacktrace is not having the reference to actual file name from where the error is triggered for the protractor.
Protractor version: 5.1.2
configuration:
   exports.config = {
    framework: 'jasmine2',
    jasmineNodeOpts: {
    showColors: true,
    defaultTimeoutInterval: 300000,
    print: function () {
    }
  }
 onPrepare()
  {
    jasmine.getEnv().addReporter(new SpecReporter({spec: {displayStacktrace: true,}}));
  }

Sample spec:
it('Protractor stack trace issue', async () =>
  {
    const helper = new SearchHelper();
    await helper.doSearch('test');
 });

search-helper.ts:
    async doSearch(text) {
      await browser.get('http://google.com');
      await browser.wait(EC.visibilityOf(element(by.name('q1'))), 10000, 'No Element found');
      await element(by.name('q1')).click(); //invalid locator
    }

1. Stack Trace with browser.wait
✗ Protractor stack trace issue
    -Failed: No Element found Wait timed out after 10007ms
    Wait timed out after 10007ms
	at WebDriverError (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/error.js:27:5)
	at TimeoutError (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/error.js:238:5)
	at /usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/promise.js:2107:17
	at process._tickCallback (internal/process/next_tick.js:109:7)

	From asynchronous test: Error at Suite.<anonymous> (/Users/e2e/sample-spec.ts:27:3)
	at Object.<anonymous> (/Users/e2e/sample-spec.ts:15:1)
	at Module._compile (module.js:570:32) at Module.m._compile (/Users/node_modules/ts-node/src/index.ts:392:23)
	at Module._extensions..js (module.js:579:10)
	at Object.require.extensions.(anonymous function) [as .ts] (/Users/node_modules/ts-node/src/index.ts:395:12)

2. If we comment browser.wait statement then the stacktrace is
✗ Protractor stack trace issue
     Failed: No element found using locator: By(css selector, *[name="q1"])
     at WebDriverError (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/error.js:27:5)
     at NoSuchElementError (/usr/local/lib/node_modules/protractor/node_modules/selenium-webdriver/lib/error.js:168:5)
     at elementArrayFinder.getWebElements.then (/usr/local/lib/node_modules/protractor/lib/element.ts:851:17)
     at process._tickCallback (internal/process/next_tick.js:109:7)Error
     at ElementArrayFinder.applyAction_ (/usr/local/lib/node_modules/protractor/lib/element.ts:482:23)
     at ElementArrayFinder.(anonymous function) [as click] (/usr/local/lib/node_modules/protractor/lib/element.ts:96:21)
     at ElementFinder.(anonymous function) [as click] (/usr/local/lib/node_modules/protractor/lib/element.ts:873:14)
     at SearchHelper.<anonymous> (/Users/e2e/search-helper.ts:14:34) **at step (/Users/e2e/search-helper.ts:32:23)
     at Object.next (/Users/e2e/search-heper.ts:13:53)
     at fulfilled (/Users/e2e/search-helper.ts:4:58)**
     at process._tickCallback (internal/process/next_tick.js:109:7)

     From asynchronous test: Error at Suite.<anonymous> (/Users/e2e/sample-spec.ts:27:3)
     at Object.<anonymous> (/Users/e2e/sample-spec.ts:15:1) at Module._compile (module.js:570:32)
     at Module.m._compile (/Users/node_modules/ts-node/src/index.ts:392:23)
     at Module._extensions..js (module.js:579:10)
     at Object.require.extensions.(anonymous function) [as .ts] (/Users/node_modules/ts-node/src/index.ts:395:12)

Observe the 2nd stack trace, it has references to search-helper file but it's not there in the first stack trace. It's very important to have this reference in stack trace for debugging.

Any suggestions?

How is this issue not getting more traction? @tsharan and I can't be the only people with this problem. In my case, I'm not getting anything useful at all that lets me know what the problem is. This is not the first time I've noticed this in the last couple weeks. I'm in the process of migrating all of our tests to use the async/await pattern and I've run into this problem several times along the way. I've even tried setting the logLevel to 'DEBUG' and I'm still not getting anything more than the basic jasmine default timeout error. What am I missing? I feel like there is something I must not know about using async/await or more people would be complaining about this problem.
Here is my super useful stacktrace:
× should do something
        - Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
            at ontimeout (timers.js:386:11)
            at tryOnTimeout (timers.js:250:5)

**************************************************
*                    Failures                    *
**************************************************

1) Smoke Tests - should do something
  - Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.

Executed 14 of 14 specs (1 FAILED) in 1 min 12 secs.

Thankfully, I was actively working on this test so I knew exactly what was wrong but if this test had failed as part of a deployment verification process, aside from the spec that actually failed, I wouldn't have a clue where to start looking .

Experience the same issue described by @tsharan. Browser.wait along with async/await shortens the stack trace, so it is not useful any more for debug purpose.

For what it's worth, I think the way to get some stacktraces that are actually useful in this situation is to wrap everything in a try/catch block. I usually skip this part but it's technically the right way to use async/await. Once you catch the error you can just log it to the console to see something useful.

Try/catch definitely should be used. Though, it still doesn't solve the problem.
Referring to tsharan original samples. Stack trace shows reference to method doSearch from search-helper.ts, but doesn't show reference to where it was called in Sample spec.

I think the solution is here: https://github.com/nodejs/node/issues/11865

Try Error.stackTraceLimit = Infinity; in your code. Works with Node.js 12.x.x

I've tried the Error.stackTraceLimit = Infinity; solution but that didn't work for me, does anyone else still have this issue? or did anyone solve this using a different solution?
I'm using node 12.16.1


[fix][txn] Fix getting last message ID when there are ongoing transactions

Motivation

Consumer/Reader API getLastMessageIds should return the max read position instead of lastConfirmedEntry.
https://github.com/apache/pulsar/blob/2322004069f23ecca1a12a4ced898fed854275fb/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java#L2117-L2122
When the transaction buffer is recovering, the MaxReadPosition of the topic is unknown. Wait it recovers completely is needed.
The MaxReadPosition should be the previous position of the first ongoing transaction position instead of EntryID -1. Because compacted decide whether the topic's managedLedger is null by EntryID == -1
https://github.com/apache/pulsar/blob/2322004069f23ecca1a12a4ced898fed854275fb/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java#L2161-L2176

Modifications

Return max read position when calling getLastMessageIds.
Call checkIfTBRecoverCompletely before getting the max read position.
If transaction buffer recovery fails, return Unknown error to the client.

Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

@coderzc
Could you please help review

The MaxReadPosition should be the previous position of the first ongoing transaction position instead of EntryID -1.
Compacted decide whether the topic's managedLedger is null by EntryID == -1

I'm not sure what does it actually means.

@coderzc
Could you please help review

The MaxReadPosition should be the previous position of the first ongoing transaction position instead of EntryID -1.
Compacted decide whether the topic's managedLedger is null by EntryID == -1

I'm not sure what does it actually means.

@coderzc
Could you please help review

The MaxReadPosition should be the previous position of the first ongoing transaction position instead of EntryID -1.
Compacted decide whether the topic's managedLedger is null by EntryID == -1

I'm not sure what does it actually means.

I think this change is correct since the first entryID of ongoing maybe 0, and its previous entry can't be directly by entryID-1.

@liangyepianzhou I think this pr also fixes #21456.

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

Codecov Report

Merging #21466 (f229294) into master (517961e) will increase coverage by 41.55%.
Report is 111 commits behind head on master.
The diff coverage is 75.00%.

Additional details and impacted files

@@              Coverage Diff              @@
##             master   #21466       +/-   ##
=============================================
+ Coverage     31.82%   73.37%   +41.55%
- Complexity    11870    32661    +20791
=============================================
  Files          1511     1893      +382
  Lines        116133   140721    +24588
  Branches      12585    15502     +2917
=============================================
+ Hits          36963   103260    +66297
+ Misses        74228    29344    -44884
- Partials       4942     8117     +3175

Flag
Coverage Δ

inttests
24.11% <66.66%> (?)

systests
24.72% <62.50%> (?)

unittests
72.68% <75.00%> (+40.86%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...ransaction/buffer/impl/TopicTransactionBuffer.java
87.74% <100.00%> (+67.23%)
:arrow_up:

...nsaction/buffer/impl/TransactionBufferDisable.java
56.52% <100.00%> (+8.90%)
:arrow_up:

...sar/broker/service/persistent/PersistentTopic.java
78.49% <50.00%> (+32.61%)
:arrow_up:

...ransaction/buffer/impl/InMemTransactionBuffer.java
57.57% <50.00%> (+57.57%)
:arrow_up:

...va/org/apache/pulsar/broker/service/ServerCnx.java
72.10% <73.33%> (+35.24%)
:arrow_up:

... and 1575 files with indirect coverage changes


Add Javadoc links from StopWatch to DurationUtils

Added a JavaDoc link from StopWatch to DurationUtils, as DurationUtils provide similar functiontionality, which could be used in simple use cases.

Merged. TY @obfischer 👍


TELEWORK: Workflow becomes detached from form

Background:

[ ] On Thursday July 28 the @DonMoffatt and others on the PSA discovered that the workflow is becoming detached if a forms designer edits the form in PROD. This happens even if we are not attaching the workflow. We alerted Simen, who quickly reproduced the problem and found a temporary workaround.

Steps to Reproduce:

[ ] Put the form in edit mode. Exit without making changes (or makes changes - it happens both ways).

Actual Behavior:

[ ] The workflow becomes detached upon saving. After saving the workflow is not called, and when you put the form in edit mode the workflow is no longer attached.

Expected Behaviour:

The workflow does not become detached when you save the form after an edit by a forms designer. Telework form needs to be cleaned due to an issue that in some cases created a new entry in the form-process-mapper database table instead of updating the existing Telework form entry in that table.
Environment:
[x]  DEV
[ ]  TEST
[ ]  PROD

Only happens in Prod

@simen can we/dev team connect about a longer term fix for this one?

@MeghanStothers the fix for this issue is in PR review.

Deployed and tested successfully on DEV.

Deployed and tested successfully on TEST. Will move the ticket to Review to be tested by the PSA team.
The telework form was cleaned in the TEST's DB.

@DonMoffatt @Stella-Archer
This is ready to be reviewed on TEST. If it was successful please let me know to move it to PROD.

Hi @iman-jamali-fw  Hasan and I tested this in TEST. Please apply the fix to PROD. Can  you also tell us what broke after it appeared to work on PROD before 10? Please IM me/Hasan or Stella if something critical like that breaks in addition to tagging us here.

Updated to high priority

@DonMoffatt @HasanSifat It is deployed to PROD. Can you test to see if the issue resolve?
Cleanup on PROD requires more work, I'll work on a strategy and will discuss it with @simensma-fresh before moving forward. In the meantime, the issue of workflow detached on form update/save should never happen again with this fix.
@DonMoffatt Can you update me on what happened in the morning so I can investigate? It might have something to do with the extra Telework forms-process-maper records in the DB (the ones that need to be clean up) but can tell for sure before investigating.

@DonMoffatt
Take a look at this PR which will explain the issue you faced and a fix.
https://github.com/bcgov/digital-journeys/pull/493

Successfully deployed and tested on DEV and TEST by me. Ready to be deployed to PROD.

@DonMoffatt @HasanSifat
The fix is ready for test on the TEST. I created multiple entries in form-process-mapper table in DB to simulate the PROD. Please take a look and let me know if it works as expected, then I'll be able to deploy it to PROD.

Tested successfully in PROD! Ticket ready to be closed

@MeghanStothers We're good to go from our end to push the fix for this to production. Let me know if we have the go-ahead for making it live, and we'll trigger the release

Ready to be deployed to PROD!

@HasanSifat @DonMoffatt @MeghanStothers We've now deployed this to production

Tested successfully in PROD! Ticket ready to be closed


Allowing Symfony 3 components

Before sending PR I want to ask first. Is there some related issue to not to allow Symfony 3 components?
This is one of few places, that disallows to try project running on Symfony 3.

The reason is that Symfony 3 is not yet ready, and I know we will still have some BC breaks related to the Templating component, which will affect this bundle (and until a few hours ago, the bundle was broken on Symfony 3 btw)

@stof I know it was broken, because I'm building Symfony 3 sandbox and this is one of few packages that is not compatible (doesn't allow Symfony 3 and/or buggy with it).
That's why I want allow it and to add a test suite for Symfony 3.

Allowing the testsuite on Symfony 3 can be done with some tricks, without actually allowing it for real if it does not work yet

This bundle is not part of Symfony demo anymore so the issue is not relevant anymore.


In Form floating label text is cut when select input

"dependencies": {
"native-base": "^2.4.2",
"react": "16.3.1",
"react-native": "0.55.2",
},
except first input other input label is cut at top.

heres my code:
return (
      <ScrollView style={{ flex: 1, backgroundColor: '#FFF' }}>
        <View style={styles.container}>
          <Image source={imagePath} resizeMode={Image.resizeMode.center} />
            <Form style={styles.inputContainer}>
              <Item floatingLabel>
                Username
                <Input
                  ref='username'
                  returnKeyType='next'
                  onSubmitEditing={() => { this.email._root.focus(); }}
                />
              </Item>
              <Item floatingLabel>
                Email
                <Input
                  getRef={(input) => { this.email = input; }}
                  returnKeyType='next'
                  onSubmitEditing={() => { this.password._root.focus(); }}
                />
              </Item>
              <Item floatingLabel>
                Password
                <Input
                  getRef={(input) => { this.password = input; }}
                  secureTextEntry
                />
              </Item>
            </Form>
          <View style={{ padding: 10 }} />
          <View style={styles.buttonStyles}>
            <Button text="SIGN UP" onPress={this.onLoginButtonPressed.bind(this)} />
          </View>
       </View>
     </ScrollView>
    );

<Form>
  <Item floatingLabel>
    Username
    <Input />
  </Item>
  <Item floatingLabel>
    Username
    <Input />
  </Item>
  <Item floatingLabel last>
    Password
    <Input secureTextEntry />
  </Item>
</Form>

     "native-base": "2.4.2"
    "react": "16.3.1",
    "react-native": "0.55.2",

@ZeroCool00 you can check this in NativeBase-KitchenSink app

Sorry, i forget to mention its working in ios, but in android its cut.

and as mention in this file

@ZeroCool00 tried your code. Working fine for me.
Code
import React, { Component } from 'react';
import { ScrollView } from "react-native";
import { Container, Header, Content, Form, Item, Input, Label, View, Button, Text } from 'native-base';
export default class App extends Component {
  render() {
    return (
      <ScrollView style={{ flex: 1, backgroundColor: '#FFF' }}>
        <View >
          <Form >
            <Item floatingLabel>
              Username
              <Input
                ref='username'
                returnKeyType='next'
                onSubmitEditing={() => { this.email._root.focus(); }}
              />
            </Item>
            <Item floatingLabel>
              Email
              <Input
                getRef={(input) => { this.email = input; }}
                returnKeyType='next'
                onSubmitEditing={() => { this.password._root.focus(); }}
              />
            </Item>
            <Item floatingLabel>
              Password
              <Input
                getRef={(input) => { this.password = input; }}
                secureTextEntry
              />
            </Item>
          </Form>
          <View style={{ padding: 10 }} />
          <View>
            <Button text="SIGN UP" />
          </View>
        </View>
      </ScrollView>
    );
  }
}

Gif

@akhil-geekyants  Its strange.. as per your answer i also check in emulator.. in emulator its working fine.. but in my real device..
i have a moto g4 plus.

in which device you checked?

@ZeroCool00 Nexus 6, redmi 4a

@akhil-geekyants  finally i checked on Moto Z Play. label not cutting.. but this problem is still remain with some devices like mine. and i found many issue regarding flaoting label cut. and each issue is closed without solved.. plz dont overlooked it.

@ZeroCool00 see this issue comment https://github.com/GeekyAnts/NativeBase/issues/1532#issuecomment-359722984

@akhil-geekyants  Thank you so much.. finally fix it..  add paddingTop: 2 in label.js and it worked


[Bug] In app review works exactly once and crashes on other attempts

Bug
Version Number of Plugin: 3.0.0-beta
Device Tested On: Google Pixel 4 XL (android 11), Xiaomi Mi 5 (android 8)
Simulator Tested On: -
Expected Behavior
I can open in app review popup more then one time
Actual Behavior
Nothing happens or app crashes
Steps to reproduce the Behavior

Install beta version of this app: https://play.google.com/store/apps/details?id=com.whitebox.nuretimetable
Go to Menu tab
Click on Rate the app
After you'll see in app review popup click outside it (so it closes)
Click on Rate the app again
You won't be able to open in app review popup again no matter what you do (even app reinstall won't help)

Additional info
Video of the issue: https://photos.app.goo.gl/MoXgRaVmMw3FXnxX6
Source code: https://github.com/maxkoshevoi/NureTimetable/blob/master/NureTimetable/NureTimetable/UI/ViewModels/Info/MenuViewModel.cs#L57
Exception info: report-2517968357235299999-9b8f9ae9-4252-41b1-b305-72c434be123c.txt

@maxkoshevoi thank you for opening the issue!
Could you please check to see if it is related to this issue?

@saamerm hi. Doesn't seem so. I don't use Xamarin.AndroidX... packages and using latest version of Xamarin Forms NuGet

@saamerm sorry, misunderstood the issue. For now in app review is available only in public beta version of my app, so seems like it should work

Ow, so there is no point of calling this more then once a month? Interesting. Seems like it's impossible (from a practical standpoint) to make this a button.
https://developer.android.com/guide/playcore/in-app-review#quotas

But still, calling RequestReview shouldn't throw an exception, which it sometimes does now

Yeah certainly, it doesn’t seem to make it a button. Can you try to wait between clicks and see if it still crashes? It seems to be a Task cancellation exception

Yes, It indeed doesn't crash if I don't click too often.

I think this issue can be closed then, but could you please mention somewhere (is your article and in readme here) that this functionality can only be used several times a year?
Thanks for your help =)

@maxkoshevoi Sounds great! Btw, check out (this sample)[https://github.com/PatGet/XamarinPlayCoreUpdater] and see if you have the same exception


Changing format of empty table cells

Is it possible to change the format of empty table cells? My goal is to change the font of some empty cells to Calibri. But no matter what I try, they always revert to the default Cambria font.
Here is my current code:
def format_cell(cell, font_name, font_size, bold=False):

    # Add run if cell is empty
    if not cell.text.strip():
        paragraph = cell.paragraphs[0]
        paragraph.add_run("")  # Works with .add_run(" ")

    # Apply format
    for paragraph in cell.paragraphs:
        for run in paragraph.runs:
            run.font.size = Pt(font_size)
            run.font.name = font_name
            run.font.bold = bold

This code works when I add a space using paragraph.add_run(" "), but I need the cells to remain completely empty. I also attempted a workaround where I add a space, apply the formatting, and then remove the space. But the cells still end up with the default font.
Here is the code for my workaround:
def format_cell(cell, font_name, font_size, bold=False):
    was_empty = not cell.text.strip()

    # Add temporary space
    if was_empty:
        paragraph = cell.paragraphs[0]
        paragraph.add_run(" ")

    # Apply format
    for paragraph in cell.paragraphs:
        for run in paragraph.runs:
            run.font.size = Pt(font_size)
            run.font.name = font_name
            run.font.bold = bold

    # Remove temporary space
    if was_empty:
        cell.text = ""

Any help would be greatly appreciated!

Solution: You need to create a custom style for your table so that when you have an empty cell, the custom style is applied instead of the default style.
Another tip: You can use this custom style to change the language of the table.
doc = Document()

# Custom table style
table_style = doc.styles.add_style("table_style", docx.enum.style.WD_STYLE_TYPE.TABLE)
table_style.font.name = "Calibri Light (Überschriften)"
table_style.font.size = docx.shared.Pt(8)

# Optional: set language
lang = docx.oxml.shared.OxmlElement('w:lang')
lang.set(docx.oxml.shared.qn('w:val'), 'de-DE')
table_style._element.rPr.append(lang)

# Create table with custom style
table = doc.add_table(rows=3, cols=10, style="table_style")

Nice work @CookiePolicyEnforcer :)


Workspace symbol search returns no results when query includes dependencies

If I search for *HashSet, VS Code (1.46, also observed in 1.45 before updating), it says "No matching workspace symbols", but I see non-empty results from the request

request trace
[Trace - 3:27:48 PM] Sending request 'workspace/symbol - (41)'.
Params: {
    "query": "*HashSet"
}

[Trace - 3:27:48 PM] Received response 'workspace/symbol - (41)' in 42ms.
Result: [
    {
        "kind": 26,
        "location": {
            "range": {
                "end": {
                    "character": 52,
                    "line": 135
                },
                "start": {
                    "character": 0,
                    "line": 133
                }
            },
            "uri": "file:///home/jbalint/.cargo/registry/src/github.com-1ecc6299db9ec823/fnv-1.0.7/lib.rs"
        },
        "name": "FnvHashSet"
    },
    {
        "kind": 26,
        "location": {
            "range": {
                "end": {
                    "character": 65,
                    "line": 46
                },
                "start": {
                    "character": 0,
                    "line": 44
                }
            },
            "uri": "file:///home/jbalint/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-hash-1.1.0/src/lib.rs"
        },
        "name": "FxHashSet"
    },
    {
        "kind": 23,
        "location": {
            "range": {
                "end": {
                    "character": 1,
                    "line": 111
                },
                "start": {
                    "character": 0,
                    "line": 16
                }
            },
            "uri": "file:///home/jbalint/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libstd/collections/hash/set.rs"
        },
        "name": "HashSet"
    }
]

The issue here is that VS Code now interprets * as a special symbol and does some helpful client-side filtering. They' added an ability to chain queries like foo.rs @ bar recently, and that's what causing this.
The fix here is to change our * and # symbols to something which doesn't conflict with VS Code new handling.

Also, this is a pretty important thing to fix, so help here is greatly appreciated :)

Should FST + ImportMap approach be used here also?

Yes, but this is somewhat orthogonal, this issue is purely an editor UI problem.

Hi! I'd gladly help with this, as it pains me regularly. The thing to do would be to find new symbols to replace # and @, correct?

Sounds like it. #Foo seems to work for me (though the manual shows Foo#, which doesn't work), but *Foo and Foo* don't.

Investigation
So I poked a bit at this and here are my findings.
The filtering that discards queries like Foo* happens here https://github.com/microsoft/vscode/blob/d22941af5d75800591770e69fd6ef08593cf1d75/src/vs/workbench/contrib/search/browser/symbolsQuickAccess.ts#L155
scoreFuzzy2 compares the returned value from rust-analyzer, returns a non-numeric score and skips the result with continue.
I wasn't able to figure out why scoreFuzzy2 returns a non-numeric score because debugging a release VScode instance using typescript source maps wasn't tenable (the instruction pointer jumps all over place).
I tried replacing * with other characters, but that didn't convince the fuzzy score to change. I tried replacing * with a whole word like dep_symbols, adapting the code appropriately in https://github.com/rust-analyzer/rust-analyzer/blob/c9672a0539a59b626619724092077f57c70e6ffe/crates/rust-analyzer/src/handlers.rs#L362
then entering #Foo dep_symbols into the quick search, but doGetSymbolPicks only considers the first word as the query parameter and discards the second one.
Proposed workaround
Would the alternative of always searching in dependency crates be acceptable? Aka always call q.libs().
That bypasses requiring a marker in the search query (thus bypassing the above fuzzy search problem), while providing a better UX to developers that would expect non-local types to appear.
I'm not sure if that has any performance gotchas like always building a bigger index. Afaik it's already populated will all crate types?


Support a couple more fontmake args

See #750.

Just tested it and it seems that it is working :)