SPARK-9446 Clear Active SparkContext in stop() method

In thread 'stopped SparkContext remaining active' on mailing list, Andres observed the following in driver log:
15/07/29 15:17:09 WARN YarnSchedulerBackend$YarnSchedulerEndpoint: ApplicationMaster has disassociated: <address removed>
15/07/29 15:17:09 INFO YarnClientSchedulerBackend: Shutting down all executors
Exception in thread "Yarn application state monitor" org.apache.spark.SparkException: Error asking standalone scheduler to shut down executors
        at org.apache.spark.scheduler.cluster.CoarseGrainedSchedulerBackend.stopExecutors(CoarseGrainedSchedulerBackend.scala:261)
        at org.apache.spark.scheduler.cluster.CoarseGrainedSchedulerBackend.stop(CoarseGrainedSchedulerBackend.scala:266)
        at org.apache.spark.scheduler.cluster.YarnClientSchedulerBackend.stop(YarnClientSchedulerBackend.scala:158)
        at org.apache.spark.scheduler.TaskSchedulerImpl.stop(TaskSchedulerImpl.scala:416)
        at org.apache.spark.scheduler.DAGScheduler.stop(DAGScheduler.scala:1411)
        at org.apache.spark.SparkContext.stop(SparkContext.scala:1644)
        at org.apache.spark.scheduler.cluster.YarnClientSchedulerBackend$$anon$1.run(YarnClientSchedulerBackend.scala:139)
Caused by: java.lang.InterruptedException
        at java.util.concurrent.locks.AbstractQueuedSynchronizer.tryAcquireSharedNanos(AbstractQueuedSynchronizer.java:1325)
        at scala.concurrent.impl.Promise$DefaultPromise.tryAwait(Promise.scala:208)
        at scala.concurrent.impl.Promise$DefaultPromise.ready(Promise.scala:218)
        at scala.concurrent.impl.Promise$DefaultPromise.result(Promise.scala:223)
        at scala.concurrent.Await$$anonfun$result$1.apply(package.scala:190)
        at scala.concurrent.BlockContext$DefaultBlockContext$.blockOn(BlockContext.scala:53)
        at scala.concurrent.Await$.result(package.scala:190)15/07/29 15:17:09 INFO YarnClientSchedulerBackend: Asking each executor to shut down

        at org.apache.spark.rpc.RpcEndpointRef.askWithRetry(RpcEndpointRef.scala:102)
        at org.apache.spark.rpc.RpcEndpointRef.askWithRetry(RpcEndpointRef.scala:78)
        at org.apache.spark.scheduler.cluster.CoarseGrainedSchedulerBackend.stopExecutors(CoarseGrainedSchedulerBackend.scala:257)
        ... 6 more

Effect of the above exception is that a stopped SparkContext is returned to user since SparkContext.clearActiveContext() is not called.

I get it, but why treat this cleanup specially? if they all should be attempted in succession regardless of whether previous cleanup failed, there are ways to do that too.

Merged build triggered.

Merged build started.

Test build #38874 has started for   PR 7756 at commit f5fb519.

Test build #38874 has finished for   PR 7756 at commit f5fb519.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

While this prevents an exception from causing the stopped SparkContext to stay active, I'm a little worried that the exception is still allowing the other resources that need to be stopped (the listener bus, SparkEnv, etc.) to keep running instead of getting cleaned up as well.

Thanks for the quick reviews.
See if rev2 is better.

Merged build triggered.

Merged build started.

Looks noisier, but might indeed be worth it. Does @vanzin have an opinion? if it looks good then this needs a JIRA

Test build #38878 has started for   PR 7756 at commit 6e02cd9.

I'm not sure CoarseGrainedSchedulerBackend::stop() needs to call stopExecutors() (they'll die or be killed by the cluster manager), which is the underlying reason for the exception... but I guess this is safer. Not pretty, but safer.
I'd write a more descriptive description (referring to a mailing list e-mail is not very helpful), but other than that, LGTM.

In CoarseGrainedSchedulerBackend.scala, around line 281:
  override def stop() {
    stopExecutors()

Test build #38878 has finished for   PR 7756 at commit 6e02cd9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Yes, I'm aware the code exists. I'm saying that I don't see a good reason for its existence.

Merged build finished. Test PASSed.

So I'm not sure if this is the desired behavior, but would we want to change this:
      Utils.tryLogNonFatalError {
        _dagScheduler.stop()
        _dagScheduler = null
      }

to this:
      Utils.tryLogNonFatalError {
        _dagScheduler.stop()
      }
      _dagScheduler = null

(and so on for the other similar tries)?

Doesn't seem to matter, considering we have the following at the beginning of stop():
    if (!stopped.compareAndSet(false, true)) {
      logInfo("SparkContext already stopped.")
      return

Anything I can do to move this forward ?

@tedyu I think it does matter in that it unconditionally clears refs to these resources if closing them fails. It seems slightly better, if we're bothering to make this more complex. Otherwise it seems pretty reasonable.

Merged build triggered.

Merged build started.

Test build #39065 has started for   PR 7756 at commit 7339ff2.

Test build #39065 has finished for   PR 7756 at commit 7339ff2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Anything I need to do for this issue ?

LGTM

Merged into master and 1.4


fix: fix snapshot deletion script

I just tested again and noticed this section from the head command.
 leading '-', print all but the last NUM lines of each file
So actually you were right. I fixed the script locally, because it looked like a mistake, but it's actually correct behaviour.


"We're not running within systemd" when running within systemd

Background
I'm running lnd with systemd. I noticed on a recent restart via systemctl that We're not running within systemd was printed in the logs. Also, the wallet did not automatically unlock in spite of wallet-unlock-password-file being set - I'm not sure if this is related.
Your environment

0.14.0-beta.rc4
5.10.17-v8+ aarch64 GNU/Linux
bitcoind 0.21

Steps to reproduce
Restart lnd managed by systemd with systemctl.
Expected behaviour
No "We're not running within systemd" message in the logs. Wallet unlocks automatically with wallet-unlock-password-file
Actual behaviour
"We're not running within systemd" message appears in the logs. Walled required manual unlock.

Just a note after investigating some more, it looks like my lnd.conf file within the lnd data directory was not loaded at all, which explains why the wallet was not unlocked (most noticeably the lack of alias). I restarted lnd again via systemctl and this time it did pick up the config and automatically unlock the wallet, however I still see the "We're not running within systemd" message in the logs.

Can you somehow verify that the NOTIFY_SOCKET is set for lnd when it's started with systemd? That's the env variable that is used to detect whether or not lnd was started by systemd.

I had the same issue but then I googled this NOTIFY_SOCKET and found out the Type of the service should be notify and mine was simple. After changing it to notify lnd indeed reports that it sees systemd: [INF] LTND: Systemd was notified about our readiness
If OP's unit is setup with notify type and lnd still doesn't see systemd it's easy to check the env var with
cat /proc/`pidof lnd`/environ | tr '\0' '\n' | grep NOTIFY

for me it returns NOTIFY_SOCKET=/run/systemd/notify

Thank you @rkfg for looking into this.
Closing this since the fix seems to be adding Type=notify to the [Service] section of the systemd service description file.

I will try the Type=notify line and report back next time I restart my node, thank you.

I changed Type=simple to Type=notify and got Systemd was notified about our readiness in the lnd logs, so I can confirm that the fix works.
@guggero - would it make sense to have an example systemd service setup within the lnd repo or an associated "official" lnd documentation repo? Right now the only two such examples I can find online are in gists, and both of them use Type=simple. I would bet that a lot of lnd/systemd users out there aren't notifying systemd properly due to this.

Damn, looks like I wrote an unclear log message. Any ideas how to change it? Maybe "We're not running within systemd or service type isn't notify"?


feat: add struct tags to AdditionalProperties

As noted in #242, we are missing the - tag which allows picking up
the additional properties in i.e. a JSON object.
Closes #242.

I merged a different solution in #278 (and commented in #242). If you feel that doesn't do the trick, feel free to reopen this and we'll take a second look. Thanks!


fix: script to count the number of converted tests

Signed-off-by: Meenal Trivedi<EMAIL_ADDRESS>

@kegsay please review


Language processing issue

Hi!
I loved mailtrap and use it for testing e.g. registration emails.
Since the latest vs of mailtrap breaks the functionality for new users, I'm trying to migrate over to sendria.
However, emails sent in other languages are now broken, where previously they worked.
For example, I expected the string "lösenord" (Swedish for password) but using the new REST API, I now get "lÃ¶senord".
Thanks!

Hi @KathrynN,
Great to hear you love Sendria! Thank for your feedback 👍
I've tested locally sending some content with characters outside ASCII, also copied some swedish texts from some websites, and send it to sendria. Unfortunatelly I can't reproduce this problem.
Could you please show me some content of incorrectly displayed message with all headers? Content of 'Source' tab would be great, then I'll be able to reproduce and fix this issue. Thanks!

Seems to be working!
Best,
Kat


Add and configure static code analyzers

[x] codeclimate
[ ] roslyn analyzers

added https://codeclimate.com/github/ci-mon/cimon


Update view-service-health.md

Added a note that "Each admin can have their Preferences set and the above limit of two email address is per admin account."

Issue#https://github.com/MicrosoftDocs/OfficeDocs-Enterprise/issues/954

Please copy review @JohanFreelancer9


Issue when adding hot-keys

Version: 1.0.105
Platform: win32 10.0.18363
Plugins: save-output, scrollbar
There is an issue when trying to add new hot-keys, the pop-up for adding the new hot-key doesn't appear, but when changing to other config menu, appears, but it is not possible to add the hot-key.

This should be fixed by now, please try again with the latest release.


feat(email): Form Submission - Additional Three headers implementation

closes #244
Changes

feat(email api): Update three headers and email subtitle titles based on backend implementation
feat(email api): Headers
[x] subject = headers["X-Mail-Subject"]
[x]  sender_addr = headers["X-Mail-Sender-Address"]
[x]  (optional) sender_name = headers["X-Mail-Sender-Name"]
feat(email api): Subject titles
[x]  [BETA] Update your financial institution profile
[x]  [BETA] Complete your user profile

How to Test

Code Inspect submitUpdateFinancialProfile.ts and submitUserProfileFi.ts to verify implementation
Navigate to /update-financial-profile
Fill out the form and hit 'Submit'
In the Network Tab, you should see similar to the screenshot below

Screenshot

References

Follow-up to https://github.com/cfpb/sbl-frontend/issues/239
CURL Example - https://github.com/cfpb/regtech-mail-api/pull/4/files

Updated link to backend implementation of these headers


Update monix.io documentation for 3.0

....

I think we're approaching time when we should start thinking about this. :)
Current API documentation is fantastic but I feel like monix.io docs are very important for new users.  I know it was a big factor to try this library in my case.
It could be a good opportunity to finish Observable documentation, update Task about new features (like TaskLocal and bracket) and of course write section about Iterant. Showing integration with cats-effect might be a good idea too!
I know API might still change but I feel like it's better to change some things if needed than wait for the last possible moment.
My idea is that we could design a draft for everything we want to write about. Think listing desired content and then gradually filling it with examples and explanation. I don't have any experience with it and I don't know how did you approach writing existing documentation but I think that writing everything at once might not be very likely.
How do you see it? Of course I volunteer to help out :D

Thanks @Avasil for volunteering. The first hurdle is the setup and I started re-configuring the website to compile for two versions instead of one.

@alexandru I'm about to write something, I don't have too much spare time lately so it might be slow but that's better than nothing. :D
I could start with Observable which is probably the most urgent, covering things from ReactiveX and Akka Streams.
Next thing - I was thinking that more reference applications could help. Either in separate monix-examples repo or examples subproject. Could be even accompanied by blog post or something to get more attention and explanation. That's not very urgent but I feel like that's a cool thing to do and I'd be happy to work on it but I need to gather ideas first so any feedback is welcome.

@Avasil thanks,
Note that we have a new branch on the monix.io repository where I'm gradually updating the docs for 3.x: https://github.com/monix/monix.io/tree/series/3.x
For writing stuff on Observable, clone that and start writing in _tut/3x/reactive/.
That branch now has a README with how the website can be built.

Is there any update on this?
I am finding it very hard getting my head around this library. The examples in the Observer docs feel esoteric and there is nothing in the Observable section.

@anjuna
It is in progress but not released yet.
There is Observable PR here: https://github.com/monix/monix.io/pull/34
You can view its content
I hope it will be helpful. If explanations there are not clear please make a comment on the PR - I'd really appreciate it!
Also, good place to ask questions is gitter:
https://gitter.im/monix/monix

Thanks for the quick response! I'll certainly check that out.
Also thanks for all the effort gone into library, and all the comments in the code itself. I'm just such a newbie to reactive programming it was always going to be hard...
Are there some good books/other resources you can recommend to help me get my head around it?

@anjuna
Tbh you don't have to think too much about Observers or Subscribers in the beginning. Learn how to use Task (it's much better documented) and use Observable methods and then convert it to Task ( I have a section about it in the linked PR)
I don't have anything about streaming in general other than few talks:
https://monix.io/presentations/
https://www.youtube.com/watch?v=brnq6RsVeN4 (note this is for Monix 2.3.x so there will be some changes in 3.0 but it should give you an idea how to use it)
https://www.youtube.com/watch?v=81I_nzjUYy4 (this one uses fs2 but it's a great talk and you can do the same things with Monix)
You might also check out rx java documentation, there will be similarities to Monix Observable.
And I can recommend two books which might be helpful in general:
https://www.manning.com/books/functional-and-reactive-domain-modeling
https://www.manning.com/books/reactive-design-patterns
There are 50% discounts very often, check their deals of the day

This ticket is too generic. The website is now compiled against 3.0.0-RC2. It's incomplete, but if issues are needed, we'll create more specific ones, otherwise I'm considering this to be solved.


Update the Board Members for the new year

We gotta update the new board memebers in the home page
https://msclubsliit.org/board

fixed


Chaging the text On and Off

I tried to change the text On and Off to Yes and No and the toggle got broken.
The html :
<input class="toggle" type="checkbox" data-toggle="toggle" data-size="small" >
Js :
$('.toggle').bootstrapToggle({
    on: 'Yes',
    off: 'No'
});

Hmn i put the js on top of the html : )


[Feature] Integration with developing time

Is your feature request related to a problem? Please describe.

Developing micro services is also challenging.
Describe the solution you'd like

Have a integration with Tilt: https://github.com/tilt-dev/tilt
Describe alternatives you've considered

Additional context

Yes, the idea is interesting, we can easily contribute vela as a tilt-extension. But it's hard to show what's the value of kubevela if users are already using tilt.
vela and tilt are very similar in deveper interface. If user uses tiltfile, they won't want to learn appfile. If we give up appfile and directly use tiltfile, It's hard to show using vela is better than using K8s. The complexity of K8s can be easily hidden by tilt-extension.

Yes, the idea is interesting, we can easily contribute vela as a tilt-extension. But it's hard to show what's the value of kubevela if users are already using tilt.
vela and tilt are very similar in deveper interface. If user uses tiltfile, they won't want to learn appfile. If we give up appfile and directly use tiltfile, It's hard to show using vela is better than using K8s. The complexity of K8s can be easily hidden by tilt-extension.

Let's hold until we have more Capability such as rolling update with traffic management.

Let's hold until we have more Capability such as rolling update with traffic management.

Nocalhost is also an option to integrate, it's a developing tool similar with tilt.

Let's re-visit this issue, I think it's a good time to integrate tilt with KubeVela now.
Developing tools such as Tilt and Nocalhost can help users using KubeVela easily by integrate with IDE doing local development. By using KubeVela, users can have a consistent experience from local development, testing to production deploy. The same KubeVela application yaml with components/traits/workflow specified can work in all these environments.
So what's benifit for users who are already using tilt to manage K8s resources?

KubeVela can help launch an environment very easily. The environment includes a new K8s cluster, cloud resources or anything that need to be prepared previously.
KubeVela has a very good workflow mechanism, it can help developers to manage dependencies, especially for micro services. The developer may need to setup a lot of microservices that was maintained by other teams. With the help of KubeVela, these dependency and resources lifecycle  can be managed easily with only one KubeVela application yaml.
One KubeVela  application can orchestrate and manage as many K8s resources as you need, you can bundle them as a whole in one application yaml.
KubeVela has lots of operational management capabilities, such sa rollout, traffic management, etc.. These capabilities can help developers to test the real production deployment.

Hey @wonderflow, this seems pretty interesting! I would like to work on it. Could you guide me where to start from?

I suggest these steps:

Get familiar with what KubeVela and tilt is. Read docs of both projects.
Deploy KubeVela by using kind or minikube, run application.
Try write a tilt plugin to integrate with KubeVela.

The final goal is users using tilt developing with a KubeVela application yaml locally and any change could deployed in the K8s cluster and preview.

@wonderflow I would like apply for this project under the LFX mentorship program. I have read the previous comments and the requirements you mentioned. Looking forward to it.

@Lakshya8066 @MarcaWitt  Thanks for your interest, you could write a proposal for your plan on this issue.

Thank you @wonderflow. I am working on that.

thank you @wonderflow.I am working on that too.

The issue looks pretty interesting. I have a few ideas regarding the same based on whatever I have worked on or have some experience about. I'd like to apply for this project under LFX if possible. Hope I get the opportunity
Thanks!!

@kaustubhsharma-009  Sure, you're welcome and please send your proposal here.

@wonderflow  sorry teacher,I have submitted the proposal to LFX.

I had submitted my proposal along with a cover letter on the LFX mentorship application @wonderflow
Thanks!

ref #2577 #2545


X509: inconsistent treatment of trust anchors on strict chain checking

In #12478 I added various certificate well-formedness checks according to requirements in RFC 5280 section 4,
which are enabled only if X509_V_FLAG_X509_STRICT is set.
It is important to note here that RFC 6818 section 2 points out that RFC 5280 is not applicable to certain certificates:

Consistent with Section 3.4.61 of X.509 (11/2008) [X.509], we note
that use of self-issued certificates and self-signed certificates
issued by entities other than CAs are outside the scope of this
specification.  Thus, for example, a web server or client might
generate a self-signed certificate to identify itself.  These
certificates and how a relying party uses them to authenticate
asserted identities are both outside the scope of RFC 5280.

In #12478 I tried  to implement this exception in check_chain_extensions() of x509_vfy.c line 524 as directly as possible, namely by the following guard, where i==0 indicates the begin of a chain, i.e., the position of the cert to be verified, which usually is an end-entity cert:
!(i == 0 && (x->ex_flags & EXFLAG_CA) == 0
         && (x->ex_flags & EXFLAG_SI) != 0)

Yet I was advised in https://github.com/openssl/openssl/pull/12478#discussion_r484075271 to change this to
num > 1

which means that the chain (including the trust anchor cert) has at least two elements,
i.e., the cert to be verified is not at the same time the trust anchor at the end of the chain,
or in other words: the certificate to validate is not directly trusted.
Among others, this has the advantage that it avoids the hardly implementable condition "issued by entities other than CAs".
Yet two drawbacks are:

the above mentioned exception from RFC 6818 is not closely followed
for the trust anchor at the end of a chain the strict cert checking is not done in a uniform way but:
the strict checking is done for trust anchor certs if and only if they are in a chain with at least two elements.

I believe it would be more clean not to perform these strict checks on trust anchors regardless in which chain they are used,
i.e., to replace the above condition by
i < num - 1

meaning that it is done for all certs  i in the chain except for the final one at position num - 1, representing the trust anchor.

I wonder how that condition works with partial chains...
Does this mean, that the strict checks are not performed, when
only an intermediate CA is installed in my PKI folder, and it will break
as soon as the root CA is installed as well?

I wonder how that condition works with partial chains... Does this mean, that the strict checks are not performed, when only an intermediate CA is installed in my PKI folder, and it will break as soon as the root CA is installed as well?

Good question - right, if that intermediate CA cert is not well-formed and is used as a trust anchor, it would not be strictly checked, while it would get checked if you use a different trust anchor and that intermediate CA cert is not trusted but part of the (remaining) chain.
To me, this behavior ist closest to the intention of RFC 6818 section 2.
OTOH, it may be seen as an inconsistency in checking certs.
@vdukhovni what do you think?

@vdukhovni can you comment here please?

@vdukhovni ping again

How important are these exclusions to strict checking in practice?
Does it make sense for applications that support partial chains or that validate bare EE certificates to also request strict checking?
Or, is it perhaps reasonable (and simplest) to document that strict checks don't try to make ad hoc exceptions, and that applications that want to make exceptions, should avoid requesting strict checks?
The num > 1 and i < num - 1 conditions are, e.g., a somewhat fragile in the case of DANE with 2 1 0 TLSA records that carry the trust anchor in the form of a bare public key, in which case the deepest certificate in the chain is not in fact a trust-anchor, it is merely signed by a bare public key, rather than a public key inside a certificate. And yet, the rules for the EE and intermediate certs should probably be the same as they would be in the case of a TA that was in certificate form.
Basically, I am sceptical that the library can reliably determine whether the context is or isn't outside the boundaries of RFC5280, and perhaps we should enforce strict checking whenever requested without ad hoc exceptions, leaving the decision to avoid strict checks to the application.
Therefore, I'm inclined to read https://datatracker.ietf.org/doc/html/rfc6818#section-2 rather narrowly, as applying at most to just EE-only chains, subject also to there not being a bare-public-key DANE-TA.
So, if we're to do anything in the library, it should be num > 1, not i < num - 1, but also taking DANE 2 1 0 into account.
My instinct is to leave this to the application, it is simple, and intuitive.


[FeatureReq - Partner Center] Support controlled flighting of Microsoft Edge Add-ons from Partner Center

Feature request, filed on behalf of iCloud Team:
Is your feature request related to a problem? Please describe.
Since the Edge store does not support flighting, our new version of an extension is made available to everyone available as soon as it's published
Describe the solution you'd like
Edge store needs to support flighting

Thank you for your feedback. Currently, flighting extensions on Edge Add on Store is not on our backlog. we will update this thread, once we start thinking about it. In the meanwhile, if you have any feedback around this item then please add it to comments.


[Question] How to create channel?

Help me. How to create channel? What am I doing wrong?
GuildAction guildAction = new GuildAction(event.getJDA(), event.getGuild().getName()); guildAction.addChannel(guildAction.newChannel(ChannelType.TEXT, "channel-name")).queue();
When using I get this output:
DEBUG net.dv8tion.jda.core.requests.Requester - Encountered issue with headers when updating a bucket
What is the problem?

The problem is that you are looking at DEBUG logs, its not a problem.
The github issue tracker is reserved for feature requests and bug reports. Your issue is neither and should be sorted out inside of our discord server. Go to discord.gg/0hMr4ce0tIl3SLv5 to receive the needed help.


LCP reporting depends on how early getFCP was called

If getLCP is called after the user input has happened the callback function is not exucuted until the next user input. If user leaves the page without any additional input I suppose the tracking doesn't occur at all. If the cwv tracking code is loaded as an asynchronous external js, whether the tracking occurs is dependent on whether the getLCP is called before the last user input or after.
Test page to reproduce that. Each second a new getLCP call happens. If you click on the red square the previous getLCP calls yeild callbacks and corresponding messages are displayed. Yet all the getLCP calls that happen after the click won't yield callbacks until the next click happens.
https://jsfiddle.net/rbe9fhyo/

If getLCP is called after the user input has happened the callback function is not exucuted until the next user input.

Yes, this is expected. Waiting to report LCP until user input has no effect on what the LCP value is, it just dictates how soon it can be reported.

If user leaves the page without any additional input I suppose the tracking doesn't occur at all.

LCP is always reported either at user input or when the page is backgrounded or unloaded, so it doesn't matter if the user never interacts with the page after getLCP() is called. It also doesn't matter when getLCP() is called, the same LCP value will always be reported for that page.

If the cwv tracking code is loaded as an asynchronous external js, whether the tracking occurs is dependent on whether the getLCP is called before the last user input or after.

Again, it doesn't matter when the library is loaded or when getLCP() is called, the same LCP value will always be reported for the current page.

Test page to reproduce that.

This test page confirms what I said above. And as you can see, if you switch tabs or navigate away from the page, all of the LCP callbacks that haven't yet fired, will fire. And the exact same LCP value is logged in each case.


Added support for downloading PNG file along with SVG file.

I have added a new file called svg-crowbar-png.js
In the above file I have added a function called downloadPNG() which uses the SVG source to create a PNG file ready for download using the canvas. This change also adds a new button called "Download PNG" and changes the original download button to "Download SVG" and gives user option to choose either downloads.
The changes also include a new link for bookmarklet which adds the link to the svg-crowbar-png.js file served from CDN.rawgit.com
All the changes can be seen at the demo on: http://shubhanshu.com/svg-crowbar/

@napsternxg : it may be relevant to rather embed the raster. See https://github.com/NYTimes/svg-crowbar/issues/16

Uncaught ReferenceError: d3 is not defined

A very useful feature. For example to paste diagrams like this into Github you need to convert it to PNG.

There's a DOM 5 in Safari when the image source is encoded to base64 (line 247 in napster's pull request) because Safari doesn't like escape characters but Chrome is okay with it.
This will work instead:
Original: 'data:image/svg+xml;base64,'+ btoa(source.source);
New: 'data:image/svg+xml;base64,'+ btoa(unescape(encodeURIComponent(source.source)));


reverting a merge commit fails

Description
Steps to reproduce:
Create a repository
create a commit
create a new branch
make a change to the file from the original commit in the new branch
create a pull request
merge the pull request
click the merge commit id  e.g. https://try.gitea.io/JensTimmerman/test/commit/84f4738d2ab5263abe4dc2460b24c4d78aa6c68c
click on operations, revert
select the main branch in the pop up
select create a new branch for this commit and start a pull request on the revert page that shows up (e.g. https://try.gitea.io/JensTimmerman/test/_cherrypick/84f4738d2ab5263abe4dc2460b24c4d78aa6c68c/main?ref=main&refType=branch&cherry-pick-type=revert )
click propose file change
You get an error (on the page https://try.gitea.io/JensTimmerman/test/_cherrypick/84f4738d2ab5263abe4dc2460b24c4d78aa6c68c/main ):
Unable to apply patch 'Error: Stdout: Stderr: error: No valid patches in input (allow with "--allow-empty") Err: exit status 128'
(this error is slighty different on different versions of gitea, or perhaps depending on the exact test scenario)
The 'new patch' textfield shows
revert 84f4738d2ab5263abe4dc2460b24c4d78aa6c68c
instead of the code to be changed
The debug logs state:
2022/12/24 22:36:02 ...dules/git/command.go:179:Run() [D] [63a77ed2] /var/lib/gitea/data/tmp/local-repo/upload.git1909367275: /usr/bin/git -c protocol.version=2 -c uploadpack.allowfilter=true -c uploadpack.allowAnySHA1InWant=true -c credential.helper= read-tree -m a0830bee2fbb72fb55370bc8a9c0c4e05acba853 686d56c5e84498ca372c8ed86b9e743aa57c4955 b269bbeb490033dd65b029dce65b85780cd2a519
2022/12/24 22:36:02 ...rvices/pull/patch.go:238:AttemptThreeWayMerge() [E] [63a77ed2] Unable to run read-tree -m! Error: exit status 128 - fatal: this operation must be run in a work tree
	 - fatal: this operation must be run in a work tree

Gitea Version
1.17.4
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots

Git Version
2.31.1
Operating System
centos8 stream
How are you running Gitea?
I'm using the do1jlr.gitea ansible role to deploy on a container on centos8stream running on proxmox.
But this is probably not relevant since I'm able to reproduce this issue on try.gitea.io.
Database
PostgreSQL

Got same problem while reverting
Git Version - 2.31.1, Wire Protocol Version 2 Enabled
Gitea Version - 1.19.3 built with GNU Make 4.1, go1.20.4
RockyLinux 8.7

I'd like to work on this if no one else has picked it.


Is this 3D?

If not, do you know of a comparable 3D physics library?

three.js

This isn't 3D, and Three.js isn't a physics library. There are several Three.js physics engine integrations, but none that are "point-based" in the same way as far as I know.

https://particulatejs.org/ is somewhat similar and solves 3D systems, but doesn't have stiffness in the constraints.

This example (source) seems to have stiff constraints.

https://github.com/mattdesl/verlet-system is another lib that works in 3d.


CORE-14350: Standardise publisher clientIds for metrics traceability

By having a standard we should be able to better track Kafka metrics in the cluster

Please can you add the topic names for the functions that triggers main processes like:

Wake up calls
Cleanups
State consumption

Please can you add the topic names for the functions that triggers main processes like:

Wake up calls
Cleanups
State consumption

Kafka producers can send to any topic. In Corda it is common in most of our subscriptions that the producer will send to many topics in a single transaction. It doesn't make sense to tie a producer to a topic for its client id. The consumer group name might be a better way to tie a producer and consumer together for the patterns which use both as part of the consumer&produce loop?

We've gone in a different direction and this work will no longer be needed.


feat(docs): Key rotation / owner -> nullifier key docs

Closes https://github.com/AztecProtocol/dev-rel/issues/279

Docs Preview
Hey there! 👋 You can check your preview at https://664b490589a77b87aa2684e5--aztec-docs-dev.netlify.app

Benchmark results
Metrics with a significant change:

app_circuit_proving_time_in_ms (FPC:fee_entrypoint_public): 15,101 (+76%)
app_circuit_proving_time_in_ms (FPC:fee_entrypoint_private): 9,685 (-45%)
protocol_circuit_witness_generation_time_in_ms (private-kernel-reset): 5,269 (-16%)
protocol_circuit_witness_generation_time_in_ms (private-kernel-tail): 2,668 (-46%)
protocol_circuit_witness_generation_time_in_ms (base-parity): 241 (-78%)
protocol_circuit_proving_time_in_ms (private-kernel-inner): 52,084 (+17%)
protocol_circuit_proving_time_in_ms (private-kernel-tail): 47,161 (+22%)
protocol_circuit_proving_time_in_ms (public-kernel-tail): 992 (-16%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
64 txs

l1_rollup_calldata_size_in_bytes
740
740
740

l1_rollup_calldata_gas
6,680
6,668
6,692

l1_rollup_execution_gas
586,865
586,853
586,877

l2_block_processing_time_in_ms
1,617 (+1%)
6,063
12,063 (-1%)

l2_block_building_time_in_ms
35,467 (+1%)
139,613
277,949 (+1%)

l2_block_rollup_simulation_time_in_ms
35,246 (+1%)
138,819
276,402 (+1%)

l2_block_public_tx_process_time_in_ms
16,637
71,136
143,308 (+1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
18,145 (-1%)
33,855 (+1%)

node_database_size_in_bytes
21,401,680
38,096,976

pxe_database_size_in_bytes
29,868
59,425

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
512 leaves
1024 leaves
2048 leaves
4096 leaves
32 leaves

batch_insert_into_append_only_tree_16_depth_ms
13.0 (-2%)
21.2 (-1%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.7
31.8
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.757 (-2%)
0.652 (-1%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
61.4 (-1%)
98.5 (+1%)
317 (+1%)
612
1,195
2,375
N/A

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
543
1,055
2,079
4,127
N/A

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.630 (-1%)
0.608 (+1%)
0.577 (+1%)
0.572
0.567
0.567
N/A

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
73.3 (-1%)
144
453
900
1,780
3,546 (-1%)
N/A

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
106
208
692
1,363
2,707
5,395
N/A

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.640 (-1%)
0.648
0.616
0.619
0.617
0.616 (-1%)
N/A

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
80.7

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
108

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
0.709

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
84,586
673,158

Transaction size based on fee payment method
| Metric |  |
| - |  |
Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes
2 new note hashes

tx_pxe_processing_time_ms
40,679 (+9%)
3,688 (-1%)
123,439 (+8%)

Metric
0 public data writes
1 public data writes
2 public data writes
4 public data writes
8 public data writes

tx_sequencer_processing_time_ms
1,279 (-15%)
2,279
1,863 (-2%)
2,780 (-2%)
1,789 (-2%)


Added Eoin Keary

Is there a reason Eoin isn't adding himself? Also the name is misspelt.

Yeah he asked me to add him, he's indisposed atm, not sure if has a Github account either, also my bad on misspell, I was going to update the PR to reconcile the changes that have happened since I forked, give me a few mins and I'll tidy it up

Awesome thanks!


Some events not firing

Hi,
I'm using latest leaflet.pm version with Leaflet 1.0.3 and some events aren't firing (markerdragend, dragend ,  ...) but create and remove events do fire. Does also someone else notices this problem?

hi @themre - can you create a JSfiddle so I can see the issue? Then I can debug and help/fix

http://jsfiddle.net/LnzN2/1101/
I'm trying to detect when I draw points of polygon and when I finish editing. Basically I want to detect all editing events so start and finish of edit mode would be enough (so I could get all shapes that were drawn).

@themre how about this?
http://jsfiddle.net/LnzN2/1102/
there is no pm:edit for the map, it's only for the layers.
So something like this should work:
// listen to when a new layer is created
map.on('pm:create', function(e) {
  console.log(e)

  // listen to when a new layer is created
  e.layer.on('pm:edit', function(e) {
    console.log('edit', e)
  });
});

does that solve your issue?

I will try later today,thanks. Does this fire also when dragging nodes? So I can save changes.

It fires after you dragged a node and/or created/deleted a new node

hi, sorry for being late. I tried it but it fires when your start and release the drag. I tried using only
e.layer.on('pm:dragend', function(x) {
    console.log('dragend', x)
  });

on newly created layer and it doesn't fire. How can I use this?

@themre
e.layer.on('pm:edit', function(x) {
  console.log('edit', x)
});

fires whenever the layer changes.
That means AFTER you dragged an existing vertex.
Or as soon as you add a new vertex.
If you simply drag one of the "middlemarkers" (the small dot between two vertexes), you basically create AND edit a vertex so it fires when you start dragging (because you created a vertex) and when you release it (because you edited the newly created vertex).

yeah, pm:edit works fine, I was just asking how to use pm:drag because I'm not able to call it.In the docs it says that this event is also available, just don't know in which case it is fired.

@themre ahh ok. I thought you wanted to have events when you start and end dragging a vertex. If you want that you can use this:
// listen to when a marker of a polygon-vertex is being dragged
polygonLayer.on('pm:markerdragstart', function(e) {//...});
polygonLayer.on('pm:markerdragend', function(e) {//...});

See this fiddle as an example: http://jsfiddle.net/LnzN2/1116/
(Draw a polygon, enable edit mode and start editing it (look into the console too))
pm:drag is fired when you move the whole layer. See this fiddle:
http://jsfiddle.net/LnzN2/1117/
(Draw a polygon, enable edit mode and start moving it as a whole (look into the console too))
Does that help you?

perfect. don't know why markerdragend didn't work, perhaps there was some typo. oh well... thanks again :)

Just as there is an 'pm:drawstart' event, it would be ideal if there were an event
'pm:editstart', to enable or disable layers.
map.on('pm:editstart', function(e) {
road.pm.enable(options);
road.pm.disable();
    road2.pm.enable(options);

});

@josejaner you basically want to hook into the "global edit mode" button and add you own logic, right?
I'd suggest to add your own button for that. The "global edit mode" button just loops through all map layers and fires pm.enable() them.

can you help me? @codeofsumit
All events are turned off when dragging a layer or marker and can get coordinates ...
But when downloading coordinates from json or any ... no event fired.


[HOW-TO] Performance Mode on OpenEntity

Question
Hi guys, I 've seen there is a check in OpenEntity for the UCITestMode, should the PerfMode be added as well ?
As if you need to track any action after opening an Entity, you are not able at the moment, since it refreshes the url and PerfMode is not added.
Thanks.

I was trying to push changes, but I could not.
This should do the trick in WebClient OpenEntity method:
var queryParams = "&flags=easyreproautomation=true";
if (Browser.Options.UCITestMode) queryParams += ",testmode=true";
if (Browser.Options.UCIPerformanceMode) queryParams += "&perf=true";
driver.Navigate().GoToUrl(link + queryParams);

@imartinflores Next code is working for me:
const string entityName = "contact";
var guid = new Guid("b27102b9-25c1-ea11-a812-000d3a19016b");
xrmApp.Entity.OpenEntity(entityName, guid);

OpenEntity method modifications:
if (Browser.Options.UCITestMode)
{
	link += "&flags=testmode=true";
}
if (Browser.Options.UCIPerformanceMode) link += "&perf=true";

driver.Navigate().GoToUrl(link);

yeah, is this merged ?

yeah, is this merged ?


Create sdk.meltano.com subdomain with redirect to https://meltano-sdk.readthedocs.io

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/138
Originally created by @aaronsteers on 2021-06-04 21:01:51

View 6 previous comments from the original issue on GitLab


Training and Validation Loss

I am training the Yolo with MobilenetV1 on VOC07+12 trainval dataset. I loaded Mobilenet with imagenet weights and built Yolo layers on top of it. I freeze the Mobilnet for first 50 epochs and tried to train to get a stabilized loss, after that I unfreeze all layers to train the network further.
I trained up to 105 epochs and still on it, the training loss decreased from 26 to around 12, val loss is around 14, and now further the loss is not decreasing and fluctuating around 12 and 14 respectively, as the loss is on Plateau the learning rate got decreased from 1e-4 to 1e-8.
I want to know:
Is this normal ?
Should I still continue training further ?
If anyone trained on the same dataset, I wanted to know the optimum loss they could reach ? (My each epoch is taking approximately 20mins)
Specifications:
Dataset : VOC 07+12 trainval with 0.1% validation set
Batch size : 16
Input shape : (416, 416)
Training on : Google Colab GPU

Hi @gopi231091
I am training on VOC0712 and got the same result as you. I am wondering this is normal or not too. I hope you can share your experience. Thank you.

the same result... I want know your final loss and your result on your test set if it possible. Thanks. @hongsamvo @gopi231091

the same result... I want know your final loss and your result on your test set if it possible. Thanks. @hongsamvo @gopi231091

besides, if you remanbered, is there any other tricks? thank you so much.

@diegolitianfu I did this project for a long time ago, so I can't remember that I solved this issue or not.


Improve setup script

Things like ensuring the correct overlay is loaded, the web files are copied to the correct directory, etc., are all manually done. It really should be performed during operation of the setup script.

Need to be able to:
Set where files are copied to, adjust startup scripts accordingly
Set TEMP sensor type, path and GPIO line for related relay, as well as GPIO line for non-temp related relay

See #22 as this directly relates to the setup.

See #18 as this directly relates to the setup.

This now includes #16 and #17, as it covers all setup issues.


getCarrier Not Working on iOS

Summary
GetCarrier deprecated on iOS 16.4 and newer. Now i'm getting "--" when run getCarrier.

Version
10.8.0

Affected OS
iOS

OS Version
16.5.1

Current behavior
Package Getting "--" on iOS
Expected behavior
It should get the carrier name

If you post a PR that solves the issue we can merge it

@mikehardy I was using your package for SIM Card Signal. API you using in package is deprecated on iOS.

If you post a PR that solves the issue, we can merge it

No, API deprecated as I said and the API has no alternative for get Carrier name. If there was an alternative, I would do it, you can be sure :)


Mutating object's property of props does not warn anything

Version
2.6.10
Reproduction link
https://codesandbox.io/embed/389331xv4p
Steps to reproduce

type whatevet in text and text2 form
check it console

What is expected?
I expect that MyInput2 also warn "Avoid mutating a prop directly..." error.
What is actually happening?
Warn anything

I have no idea why It don't warn anything if add or mutate object's property  in props. Yes, i should use emit to mutate props' data. But i want to understand why it happen. If this is a bug of Vue, i hope it will be fixed later.

This has been explicitly mentioned in the docs:

Note that objects and arrays in JavaScript are passed by reference, so if the prop is an array or object, mutating the object or array itself inside the child component will affect parent state.

In Vue 2 there is currently no (performant enough) way to detect nested mutations. In Vue 3 however, this will indeed trigger warnings.

I searched hours on the internet about this question. First i thought that it was clearly forbidden to mutate props. Then i noticed myself that mutate an object doesn't trigger warnings. But i knew i read somewhere that is was because Vue doesn't detect nested mutations.
I see the documentation said that changing an object in child will reflect changes in parent but in red alert like "don't do this". But it's clearly seems the simplest things to do. And if i take the official documentation, it said that we should make a copy in data or computed. But it's the same things that mutating props !! (because reference, it's just that Vue doesn't detect it so no warnings).
So how should we make to avoid mutating props for REAL, and why is this a problem for reference types ? It seems to be a real problem because Evan You said that in vue 3 warnings will be trigger even on nested structure, but i don't see why because, parent is updated so the data stay sync.
Should we juste pass one level nested object to component ? Should we make deep copy every times ?
Why the documentation is so ambigious about that ?
I think the whole internet need this clarification (or is it just me :p ?),
Thanks.


Move CRI release logic to Makefile

Allows building the cri-release package outside of the github action. This is also much simpler than the cri-release which was recently removed as it uses the locally built binaries and scripts which are now in containerd/containerd.
Verified Github release changes at https://github.com/dmcgowan/containerd/runs/1153643111

LGTM
thanks @dmcgowan


fix: fixed pageSize functionality

Fixes
Fixes issue https://github.com/twilio/twilio-java/issues/723
updating functionality for setting pageSize in twilio-java.
Checklist

[x] I acknowledge that all my contributions will be made under the project's license
[ ] Run make test-docker
[ ] Verify affected language:

[ ] Generate twilio-go from our OpenAPI specification using the build_twilio_go.py using python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go and inspect the diff
[ ] Run make test in twilio-go
[ ] Create a pull request in twilio-go
[ ] Provide a link below to the pull request

[ ] I have made a material change to the repo (functionality, testing, spelling, grammar)
[ ] I have read the Contribution Guidelines and my PR follows them
[ ] I have titled the PR appropriately
[ ] I have updated my branch with the main branch
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added the necessary documentation about the functionality in the appropriate .md file
[ ] I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.

@kridai PR needed against twilio-java showing the proposed changes.

https://github.com/twilio/twilio-java/pull/726


Meeting to discuss how to capture CC action items and follow up.

[x] Stephen and Peter will set up a meeting next week to discuss how to track the action items and have circle members report on them.
[x] Update Admin Meeting Document format

Peter - In the TH deliverable in 1 week in reference onboarding

Example

After Town Hall - Audit Update - 5 Minutes
Thorsten - to give an update on last nights ATH “Audit Update”
https://github.com/Catalyst-Auditing/Audit-and-Oversight-Coordination/issues/56

Action :
Any updates, feedback or suggestions.

Closed and being refined with this action item

https://github.com/Catalyst-Circle/Catalyst-Circle-Admin-Coordination/issues/105


Support Server-Side Rendering (SSR)

Thanks for the great work on Framework!
For even faster (perceived) page loads it would be valuable to render initial views of charts and other content on the server, then "hydrate" them on the client once corresponding runtime cells are ready. For example, I'd like to publish static SVG as part of the initial page content, which can then be replaced with "live" content upon load.
I realize there be dragons here, especially with arbitrary code that may involve randomness, generators, or otherwise cause strange changes of content upon hydration, and so on. Nevertheless, I see a lot of value in being able to knowingly opt-in to SSR.
I imagine one would have to instantiate a runtime during server-side compilation then extract resulting content. We do something similar in Living Papers using Puppeteer to extract and screenshot runtime-generated content, though a lighter weight approach (e.g., using jsdom and node canvas?) may be preferable and cover common use cases.
It looks like some work in this direction is ongoing, though I'm not sure of the planned scope. So, just wanted to share a plug for this!

Related #234 #141.

As a complement/alternative/easy first step, I would like to think about registering cell dimensions #933.

Agreed! This would support very cool use cases, added a discussion as well:
https://github.com/observablehq/framework/discussions/855

Maybe we should reopen this issue, which is mentioned in https://github.com/observablehq/framework/blob/fa804894d0de62dd710e5c1b7630df2ded2d9e13/docs/jsx.md?plain=1#L114 and not completely completed? Or open a new one with new goals (SSR code blocks, hydration…).

We have #234 #145 already so let’s keep this closed. We could open up another issue for JSX hydration.


i want using streamWriter.MergeCell，but it's just in branch master，When will the new tag be released?

Description

Steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Output of go version:
(paste your output here)

Excelize version or commit ID:
(paste here)

Environment details (OS, Microsoft Excel™ version, physical, etc.):

The next version v2.4.1 will be released on August 2nd, 2021, and the changelog of this version on the documentation website.


Ctrl+left arrow

Hi @rux616 I'm unsure if I am doing someting wrong. After installing the repo file I would expect the follwing shortcut: Ctrl+left/right arrow to jump to end/start of word (the same as on PC) ?

I believe that's what should be happening. Though to be more exact, what's happening in the background is that a Ctrl+{Left Arrow,Right Arrow} input is being translated to an Option+{Left Arrow,Right Arrow} input, unless the program currently active is one of the ones in the "Generally Excepted Applications" list in the "List of Shortcuts" section of the readme.
That being said, I have not had access to a Mac in some time, so I can't personally verify.

First, thank you so much for making these, coming from windows/linux for my entire life I was losing my mind trying to type.
That said, I'm having the same problem, this is the only one I've found that doesn't seem to work. I've tried in many different apps (Slack, vs-code, basic text editors, firefox) but most programs still seem to jump to the start of the line instead of just moving words.


Namespaces refactor patch

Fixed a line I missed from my previous PR, refactoring namespaces. Sorry for the trouble!

:+1:


Option to disable logging to console when syncing/updating data

Hey :wave:
opts.syncForm() logs the updates to the console every time the form data has changed. When this is used in content scripts (as opposed to background/popup/options scripts) it (in my opinion) pollutes the console. I suggest add logging to the console as an "option" passed to the syncForm function as an optional argument like so:
// This is an optional argument
// Default value can be `true` as it currently is
const options = {
	logging: false;
};

opts.syncForm(form, options);

Cheers,
Mihir

Makes sense! It can be added as an option to new OptionSync(key, {logging: false}) so it's shared across all the methods.

Yeah, that can be done too!
Should I create a PR for this? I have looked at code and I'm guessing it's a simple if (logging === true) check that we need to add before logging any info/warning to the console.

It's probably best to have an overridable logging function so we don't have to use if every time. Something like:
	constructor(options) {
		this.storageName = options.storageName || 'options';
		if (options.logging === false) {
			this.log = () => {};
		}
	}
	log() {
		console.log(...arguments);
	}

Yes of course, much neater.

Hey, I'm having some trouble getting the _log function correctly called from other methods in the class. The constructor and log function:
constructor(options = {}) {
	this.storageName = options.storageName || 'options';
	if (options.logging === false) {
		this._log = () => {};
	}
}

_log(method, list = []) {
	console[method](...list);
}

and it should be called like so:
this._log('info', ['Current options:', options]);

However, I'm getting the following TypeError when trying it on an extension of my own locally:
Uncaught (in promise) TypeError: this._log is not a function
    at Function._applyToForm (content.js:188)

I'm guessing it's got to do with the scope of this changing, but I'm not sure.

Ah yeah because _applyToForm is a static method. You can changed it to be a regular method and change its calls from OptionsSync._applyToForm to this._applyToForm
Also
- _log(method, list = []) {
+ _log(method, ...args) {

And
- this._log("info", ["Current options:", options]);
+ this._log('info', 'Current options:', options);

Thanks! Please publish to npm too :relaxed:


Fix for Issue/#720.

Issue Number
Relevant issue number

Resolves #720

Please check the following

[ ] Do the tests still pass? (see Run the Tests)
[ ] Is the code formatted properly? (see Linting (Formatting))
For New Features:

[ ] Have tests been added to cover any new features or fixes?
[ ] Has the documentation been updated accordingly?

Please describe additional details for testing this change
-Refactored the ready/notReady state for the card-flip animation.
-Opponent's ready state is reset in the state.  Client bug, server is ok.
-Fixed a bug where the opponent's indicator would display the player's userName.  The state.players array wasn't being sorted, so p0 was at index 1 and p1 at index 0
-created a test file for testing the lobby join/leave/ready actions.  (unfinished)

I push my modifications, but forgot it was going to trigger the pr again.  I'm not done yet, I'll finish over the weekend

There is one test ( the very last one ) that I don't know how to set up.  Could someone help me out?

I realize I got off track with too many changes that were not related to this specific issue.  @seriouslysean you were right.
So I rolled back to the original version of the file and just added the missing tests related to this PR:  when players get ready, leave and join back.
I also modified other assertions that became useless since pr #712.  This PR introduced a new way of handling lobby-cards.

@Haviles04

I see some test were changed to arrow functions, then changed back, now we have a mix, can we switch them all to arrow?

There was a problem with some arrow functions that need to call this.gameSummary.  That's why I changed them back to regular functions.

@Haviles04

I see some test were changed to arrow functions, then changed back, now we have a mix, can we switch them all to arrow?

There was a problem with some arrow functions that need to call this.gameSummary. That's why I changed them back to regular functions.

Ah Okay, I understand.. I think we can fix that by using cy.get('game-summary').then(), but that's probably for a different PR

LGTM, leaving it to @itsalaidbacklife for final approval


I don't understand this PR. Is it just a copy of the existing go branch?

Looks like it. I'll close it, if there's something else to it, we can reopen.


[spacewx]: Create DSCOVR notebook

The challenge Develop the Oracle of DSCOVR is proposing taking a ~blind / low-level approach to predicting geomagnetic storms, to cope with DSCOVR degradation.
This challenge will be challenging!
This notebook will do following:
(note will draw on a notebook I created last year: https://github.com/HarveySouth/spaceapps-2022/blob/main/notebooks/data_preparation.ipynb)

[ ] add some code to do some of the low-level work, so people can get started faster

[ ] download the low-level spectral data
[ ] show how to read it into pandas
[ ] get a summary of values
[ ] plot an example spectra

[ ] give some background on Kp and geomagnetic storms

[ ] cover how solar wind plasma and Bz affect Kp
[ ] crosslink to Lockwood work
[ ] show how to read in Kp & WIND data from the OMNI dataset
[ ] show what correlation of Kp with OMNI-WIND Earth-propagated Bz and plasma parameters is - that this temper expectations
[ ] discuss propagation time from L1 to Earth, and that also need to consider L1 halo orbits, spacecraft ephemerides

[ ] give some background on DSCOVR anomalies

[ ] cross-link to the Loto'aniu paper on conditions where DSCOVR data is poor, and why, and when
[ ] suggest that anomaly investigation best be done by comparing with other in-situ data (e.g. WIND), not downstream (Kp)
[ ] mention SWFO - that there's life after DSCOVR!

Whoops, forgot to GH-N tag commit messages for these two commits:

50e8e29: Add DSCOVR notebook from 2022
55a2eba: Add conda environment files


Fix some low-hanging request evaluator performance fruit [5.2]

We've added a lot of new requests lately and converted more of the declaration checker to use requests. This has led to an increase in per-request overhead. This PR addresses some of this overhead:

Don't build the request dependency graph by default since it's currently only used for debugging
Look for a cached result before checking for a cycle to avoid expensive AnyRequest allocation

@swift-ci Please test


Should expose custom pattern matching

The options do not currently expose the slug-component's option for changing the permalink pattern.
This makes it impossible to add common permalink conditions like changing say, "John's Metalsmith Guide" to "johns-metalsmith-guide" (currently this plugin would instead make it "john-s-metalsmith-guide".)
Or to handle other special characters mid-sentence, i.e., "Metalsmith, Node, and Javascript Are Great" currently becomes "metalsmith-node-javascript-are-great" instead of "metalsmith-node-and-javascript-are-great".
Best solution would be to make the match pattern used for slugs exposed to the options of the metalsmith-permalinks plugin, especially since its slug component already supports the feature.

I believe this has in the meantime been implemented, see e9edcbd74506f4c2ab0320d1f8b8b464db3ec58a


Calico integration

Calico in Mantl: https://microservices-infrastructure.readthedocs.org/en/latest/components/calico.html
Kubernetes plugin: https://github.com/projectcalico/calico-docker/tree/master/docs/kubernetes
We need to contemplate if it's possible to switch from flannel to Calico which is already implemented in Mantl. We should start from networking since it's the most crucial building block.
Also, Weave Scope works nicely with Calico so we could consider integrating it as well: http://www.projectcalico.org/calico-and-weave-scope

It's not on our roadmap any more.


Docker compose build 失败

 => ERROR [5/8] RUN gradle build                                                                                5.8s
------
 > [5/8] RUN gradle build:
#8 0.769
#8 0.769 Welcome to Gradle 7.1!
#8 0.769
#8 0.770 Here are the highlights of this release:
#8 0.770  - Faster incremental Java compilation
#8 0.770  - Easier source set configuration in the Kotlin DSL
#8 0.771
#8 0.771 For more details see https://docs.gradle.org/7.1/release-notes.html
#8 0.771
#8 0.868 Starting a Gradle Daemon (subsequent builds will be faster)
#8 5.268
#8 5.268 FAILURE: Build failed with an exception.
#8 5.268
#8 5.268 * Where:
#8 5.268 Build file '/fisco-bcos-browser/server/fisco-bcos-browser/build.gradle' line: 3
#8 5.269
#8 5.269 * What went wrong:
#8 5.269 A problem occurred evaluating root project 'fisco-bcos-browser'.
#8 5.269 > Plugin with id 'maven' not found.
#8 5.270
#8 5.270 * Try:
#8 5.270 Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
#8 5.271
#8 5.271 * Get more help at https://help.gradle.org
#8 5.271
#8 5.271 BUILD FAILED in 4s
#8 5.272 Unable to list file systems to check whether they can be watched. The whole state of the virtual file system has been discarded. Reason: Could not query file systems: could not open mount file (errno 2: No such file or directory)

yes,The same problem
Build file '/fisco-bcos-browser/server/fisco-bcos-browser/build.gradle' line: 3

Higher versions of gradle have removed the maven plugin， please use gradle v 5.2.1
FROM gradle:jdk8
change to
FROM gradle:5.2.1-jdk8

https://github.com/YoungWilliamZ/fisco-bcos-browser-docker/pull/11


Control over pitch change as you zoom into object?

Hi,
In this example, as you zoom in the pitch gradually changes to 90. Is there any way to prevent this behaviour? I
'd like to be able to look at the cliff face when zoom in.
cheers

You can try constrainCamera : false parameter.
https://jsfiddle.net/2tq7mwud/
or modify source code:
https://github.com/melowntech/vts-browser-js/blob/master/src/browser/control-mode/map-observer.js#L448

That's exactly what I needed thanks! I just re-read my comment and realised i forgot to link the example, sorry


mkdocs plugin for typer

First check

[x] I used the GitHub search to find a similar issue and didn't find it.
[x] I searched the Typer documentation, with the integrated search.
[x] I already searched in Google "How to X in Typer" and didn't find any information.
[x] I already searched in Google "How to X in Click" and didn't find any information.

Description
I see that typer uses mkdocs to generate its awesome documentation.  I also see that there is an extension to mkdoc for click apps.  I tried pointing mkdocs at my typer application to generate documentation but ran into:
mkdocs_click._exceptions.MkDocsClickException: 'app' must be a 'click.BaseCommand' object, got <class 'typer.main.Typer'>

I was wondering if anyone had tried to write a mkdoc plugin for Typer.

Well, that wasn't too hard, https://github.com/bruce-szalwinski/mkdocs-typer.

Well, that wasn't too hard, https://github.com/bruce-szalwinski/mkdocs-typer.

Thanks for reporting back and closing the issue 👍

Sorry for the long delay! 🙈  I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.


Add MacBook Pro host mouse fix.

Mouse didn't work for me. I played around with the VM settings until I found a combination that seems to do the trick.

It have conflicts now. Ill add it manually and update the repo

Awesome, thanks! It took me a while to figure this out, so hopefully it will save somebody some time.


Issues with unit tests

Bug Report
Expected behavior
All unit tests should be successful.
Observed behavior

Incorrect library dependency for ScalaTest in learn.sbt causing: can't expand macros compiled by previous versions of Scala

Solving the previous error unveils that multiple tests are failing.

Most failures are due to DenseInstance and SparseInstance inconsistent returns for invalid indexes.

Steps to reproduce the issue
Command line
sbt test
Data source
N/A
Infrastructure details

Java Version: 8
Scala Version: 2.11.8
Spark version: 2.3.2
OS version: N/A
Cluster mode or local mode? N/A

The related pull request has been merged


settingsUI: Fix the UI of Authentication settings.

#21001
GIFs or screenshots: <!-- If a UI change.  See:
https://zulip.readthedocs.io/en/latest/tutorials/screenshot-and-gif-software.html
-->
EARLIER -

NOW -

@timabbott please review.

Thanks for the quick PR @jai2201 !
@jai2201 there is no need to @-mention Tim when asking for a review. Many folks could do the first round of review for you work, so just a comment saying that your PR is ready for review works great.
@sahil839 do you have any feedback on this one before Tim takes a look?

Thanks for the quick PR @jai2201 !
@jai2201 there is no need to @-mention Tim when asking for a review. Many folks could do the first round of review for you work, so just a comment saying that your PR is ready for review works great.
@sahil839 do you have any feedback on this one before Tim takes a look?

Sure alya.

I gave the width and td CSS to the specific ID of this table, instead of to the whole class to avoid braking things, and also to swap the checkbox icons to left i swapped the  of checkbox with the  of {{method}}

@sahil839 , I have made the changes you asked for, can you have a look at it once.

also, @alya do we have to implement this change also, of clicking the Text against the checkbox should also allow to
uncheck-check the checkbox ?

Merged, after adjusting the commit message to match our style.
Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages.  Commit messages are a very important form of communication in the project, so please address this issue in all of your current and future PRs.
I also marked this to not close the issue, since I think we want to do https://github.com/zulip/zulip/pull/21002#discussion_r796926698 first.


mount storage

As a developer, I want to be able to mount storage to my container.
$ ocd storage mount [name] [--path=] [--component]

$ ocd storage mount will link a pvc to a component at the specified path
Dependency on #226
Subtask of #170

See: https://github.com/redhat-developer/ocdev/issues/226 can we close this @kadel ?

We don't have mount implemented, just create and list.

closed in #472


Support AutoMigrate

Following are the pull request from issue #723

It should be in-par with the features we support for manual migrations, i.e creating entry in migration table, if any error happens rollback everything.

Let's discuss on #723

@reski-rukmantiyo are you still working on the issue?

Yes, still working on this. Will submit ASAP this week.
From: Umang Mundhra @.>
Date: Thursday, 4 July 2024 at 14.01
To: gofr-dev/gofr @.>
Cc: Reski Rukmantio @.>, Mention @.>
Subject: Re: [gofr-dev/gofr] Support AutoMigrate (PR #725)
[CAUTION - EXTERNAL EMAIL]

This email came from outside of Lintasarta. Please verified the sender before opening attachment or clicking embedded links. If you suspect this is spam send this email as an attachment to @.***
@reski-rukmantiyohttps://github.com/reski-rukmantiyo are you still working on the issue?
—
Reply to this email directly, view it on GitHubhttps://github.com/gofr-dev/gofr/pull/725#issuecomment-2208257287, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APOBE7DFTCFKPJM5B4IT35LZKTXL3AVCNFSM6AAAAABJNH2UCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBYGI2TOMRYG4.
You are receiving this because you were mentioned.Message ID: @.***>
Reski Rukmantio
Senior Manager
CLOUD SOLUTION
[Lintasarta]
Lintasarta
MenaraThamrin Lt. 12, Jl.M.H. Thamrin kav. 3
JAKARTA 10250
Indonesia
T 230 2345 Ext.
F 230 3883
@.***
[W] www.lintasarta.net


Update asynchronous.py

Add support for questdb 'BYTE' type

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I'm in the process of writing tests, I'll roll your change in once that test infra is in place. See #5.


SHA is not set when parsing static git context for GitLab repositories in "commits/" scenario

Describe the bug
When parsing static git context for GitLab repositories in commits/ scenario, only the branch property is set to the parsed value. The URL structure in GitLab repositories accepts both a branch name or SHA as a "Git revision" to follow after commits/.
To Reproduce
Steps to reproduce the behavior:

Parse static git context for https://gitlab.com/gitlab-org/gitlab/-/commits/c87cfbb77c2cf36356d010d1c0b21817c42f70ef
Confirm that SHA property is not set, only the branch property

Expected behavior
SHA property in the static git context should be set
Desktop (please complete the following information):

Daytona Version: [v0.24.0]

/bounty $20

/attempt #904

Hello @Tpuljak if I understand this issue correctly, the section after commits\ should be set to StaticGitContext.Sha if it is a SHA hashcode or set to StaticGitContext.Branch if otherwise, correct ?

Hello @Tpuljak if I understand this issue correctly, the section after commits\ should be set to StaticGitContext.Sha if it is a SHA hashcode or set to StaticGitContext.Branch if otherwise, correct ?

That's correct. If it's a commit URL, then both the branch and SHA props should be set to the commit hash, if it's a branch URL, then only the branch prop should be set.


Doesn't work with new U2F keys?

The UI of this seems like it should allow reconfiguring U2F keys, given that it shows a U2F boolean on the main page.  But when I plugin my GH branded U2F yubikey it doesn't notice it at all...  Any idea what's wrong?

Seems like it should, but you need to use another tool:
https://github.com/Yubico/yubikey-neo-manager
I agree, I'd expect one tool to allow me to configure my Yubikey, but it seems fragmented with multiple apps and libraries.

Ah thanks @kylemanna.  For the most part I've found the yubikey ecosystem to be sensible, though this is their first departure from their relatively large original gui.  As long as there is a tool that will let me reset my key I'm happy.

Actually, just installed that app and it detects the device but then claims that it is not supported. :cry:

If you are using the new GitHub special edition Octocat keys, those keys are U2F only. Those keys, as well as our Security Keys cannot be configured using the Personalization Tool. See https://www.yubico.com/faq/why-doesnt-the-yubikey-personalization-tool-recognize-my-security-key/.

That's really too bad; I'd like to be able to replace the internal keys.  Thanks for letting me know though!


make --output dir if it doesn't exist, as already done with -W

Running honggfuzz with -o and -W where neither directory exists:
> ls | grep hftmp
> /path/honggfuzz -z -P -i working-corpus/ --output hftmpo -W hftmpW -- ./target
[...]
[2020-05-07T09:47:51-0700][F][11897] main():331 Output directory 'hftmpo' is not writeable: No such file or directory
> ls | grep hftmp
hftmpW

Only the -W directory is created.
After code change:
> ls | grep hftmp
> /path/to/honggfuzz -z -P -i working-corpus/ -o hftmpo -W hftmpW -- ./target
[...fuzzing output...]
> ls | grep hftmp
hftmpo
hftmpW

Thanks!


How to add support for new devices

The same device cannot be controlled or set up when connected through XiaomiGateway3, but it can be fully displayed and controlled through Xiaomi Miot Auto.

You can read this page and then try to configure it yourself.

You should to writer converter like many other users. Check other issues.


debug_mode

:~/realtime_object_detection$ python run_stream.py
run_stream.py:59: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
cfg = yaml.load(ymlfile)
Traceback (most recent call last):
File "run_stream.py", line 102, in main
debug_mode = cfg['debug_mode']
KeyError: 'debug_mode'

Hi @skywo1f,
Thank you for the report.
Deprecated warning does not have any problem at present.
yaml.load () without Loader = ... is deprecated

Make sure that there is a debug_mode entry in config.yaml for debug_mode key error.


Bump minimum required compiler to be 1.2.0

This PR bumps the minimum required compiler to be 1.2.0. This allow us to use features included in 1.1, like Int128 literals, enabling #11944 #5545 and avoiding hacks like this.
It's still missing a mechanism to make visible the minimum required version. That will come with another PR.

We should remove 1.0 and 1.1 from CI immediately, right?

The AArch64 Docker images are still using 1.0.0

@HertzDevil great opportunity to see the check installed in action https://github.com/crystal-lang/crystal/pull/12937/commits/a40e66097dc4a3673c42c72ac3c91bc688000c78


Disable globbing when executing zeus rake

Enables easy use of the Zeus rake aliases with tasks that accept arguments via square brackets.

Confirmed to be equally necessary with or without #2058


Question: how to make tabs in tabline always visible?

I'm using the Airline along with the CtrlSpace plugin.
When I open lot of buffers on current tab, my tabs list is truncated in tabline, I see only buffers list on top of my screen, how I can prevent tabs from truncating by huge buffers list? I don't care about buffers could be truncated, but seeing tabs is more important for me.
environment

vim: NVIM v0.2.0
vim-airline: 81f089322a670376be1daf7817f110812f785387
also vim-ctrlspace 92dd9591d33f4b18a59c7c6850cc7e56dd1f83a7
OS: Fedora Workstation 25
Have you reproduced with a minimal vimrc: yes

if you are using terminal:

terminal: termite, konsole
$TERM variable: xterm-256color
color configuration (:set t_Co?): 256

does it work without vim-ctrlspace? I think there is a setting to display both buffers and tabs, but this is disabled by default. However, it might be that vim-ctrlspace forces this.

ping

@chrisbra I created minimal config pasted below and yes, this happens only with vim-ctrlspace, but without ctrlspace I see only current buffer even if g:airline#extensions#tabline#show_buffers is set to 1.
se hidden " required for ctrlspace

let g:airline_powerline_fonts                            = 1
let g:airline#extensions#tabline#enabled                 = 1
let g:airline#extensions#tabline#show_buffers            = 1
let g:airline#extensions#tabline#switch_buffers_and_tabs = 0

se rtp+=$HOME/.config/nvim/vim-airline/        " c386332
se rtp+=$HOME/.config/nvim/vim-airline-themes/ " a7fcf53
se rtp+=$HOME/.config/nvim/vim-ctrlspace/      " f7987e4

nn <C-Space> :CtrlSpace<CR>

fu s:InitIssue()
	for i in range(5) | tabnew | endfo
	for i in range(10) | exec 'e foobarbaz'.i | endfo
endf

com InitIssue call s:InitIssue()

Here is a screencast that shows how it behaves: https://www.youtube.com/watch?v=spukhsvCjrQ


Updated Helm download Url

Task name: HelmInstallerV0/V1
Description:  Updated the helm download url as the previous link was stale and could be used to send malicious payload.
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N)
Checklist:

[ ] Task version was bumped - please check instruction how to do it
[ ] Checked that applied changes work as expected

One comment here, though -- make sure we are downloading the versions which are available on get.helm. It would be bad if we are pinned to some old helm version which is not available in the new place and our tasks will be failing.

Please also make sure that task version is bumped (you can find more info here) - otherwise task won't be updated.


code added

Code added in C++ language in code folder .
Wanted to add code as a GSSoC'21 participant .

link it with the issue.

Please check now commits

Also update the link to the code in the readme

Please check now
And as I new to algo-tree so I am unable to find the readme to update this code .
So please if possible send the link of readme so that I can update there too

PR without assignment.

Why it's invalid ? @rish-singhal
I have attached the issue number #1660 .

PRs are invalid if the issue is not assigned to the one who makes the PR. Wait first the issue is assigned to you.

So any more required changes ?

Readme file is in array/number theory

Updated readme

@rish-singhal is there any more changes to do ? If no then please merge it .

There are changes, so look at the comments

-> I have added "s"  in test case .
-> I have changed the time complexity too.
-> I have updated the readme too .
anything else @rish-singhal ,

Add information about the method you are using. For example, reversing the digits or something like that.

The readme file you updated is incorrect.

There should be test cases not test case's

added a short description about the algo , updated readme , added "s"
@rish-singhal

Readme file is in algorithm/number theory

This is the readme file you have to update.

And according to your description, it comes out that if the first and last points are not same then return false,
but what about 1006541?

you should also mention that you are updating those points

Done @Rohan27s

Just update the spelling of satisfied in the description*

And also, sort the list according to the name of the algorithm in readme.

changed spelling

@rish-singhal

sort the list according to the name of the algorithm in readme

Currently this is the readme , just tell me where should I place it .

@rish-singhal

It's okay to place in fundamental, just sort the list --
The links should be lexicographic order.
A, B, C,....
https://en.m.wikipedia.org/wiki/Lexicographic_order

Now fine ? Should I push it

Just switch Fibonacci and factorial
Fa.. comes before Fi..
Then push the changes

@rish-singhal

great!

@rish-singhal Though I know my code is not that great , but Level 0 it too low .
Usually in other projects mentors are giving the Level  0 for just a file deletion or like that , so I request you to add level 1 tag at least .

I don't have a say in this... this is what the group follows.
As the code is simply iteration over digits of a number. And does not require any extra data structure or algorithm: Level0 is assigned.
You can ask @rudrakshi99 in case you have doubt, if she's okay with it. She will assign level1.
I am just following the instructions.

Okay , I agree to your point of view .
But it's a request so if possible then please add it  else I can't argue .
@rudrakshi99 @rish-singhal


Improve content card 7

reference:

right now the content card has no hover property and kind of mixes with the bg ....enable hover property and also apply a box shadow to improve the ui

assign me @Rajdip019 @rupsha014


Added badges to docs

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   79.16%   79.16%
=======================================
  Files           2        2
  Lines          24       24
  Branches        6        6
=======================================
  Hits           19       19
  Misses          4        4
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9158272...e5e3636. Read the comment docs.


fix: getManyReference compatible with strapi

Hi
if you use ReferenceManyField the api request is not compatible with strapi which uses getManyReference function. it was wrong and i fixed it and test it.

@sepehr09  thank you for your contribution. I appreciate you identifying and fixing this issue!


[ERROR] Could not execute .NET AssemblyANalyzer on Windows 10

Hello,
i have small issues on Dependency-check and .NET binary dependency check
there is my enviroment

Windows 10 version 10.0.19043
Dotnet 6.0.101 on path C:\Program files\dotnet
Dependency-check plugin 6.5.1 on path C:\dependency-check
Dotnet SDK 6.0.101 on path C:\Program files\dotnet\sdk

When i start a scan with these commands: C:\dependency-check\bin\dependency-check.bat --scan /path/of/source/ --format HTML --out /path/of/source/report.html --log /path/of/source/report.log
i got results only for npm dependency that exist on my sources file and see and error about .NET assembly like that:
[ERROR] Could not execute .NET AssemblyANalyzer
what's wrong?
Thanks

at the moment donet 3.1 is required to run ODC. It will still be able to analyze assemblies built for the new runtime. We will likely update to the most recent LTS version soon.

I just opened a ticket (#3951) to track the update - which will be planned for the 7.0 release.


Feature Request - Force Inline All

Do you have plans to have a Force Inline All option[checkbox], with the ability to adjust just the Force Block section?
I find the spacing to be frustrating at times, where I'm having to delete a lot of un-needed spaces and new lines.
Thanks for taking a look at this.

I agree with this! I uninstalled the plugin because I don't want newlines to be forced on me. Would love to still be able to use the auto close functionality though.

With 0.20.0 you can use "*" for the Force Inline option to accomplish this.

Tried this, it didn't work.

Can you send me paste in config file (Atom Menu > Open Your Config File). Also confirm you updated to autoclose-html 0.20.0 which you can see in Preferences, Packages tab. You shouldn't need to restart atom, but give that a try as well.


window.open background

This is one part feature request, and one part discussion as I'm not even sure this should be done, but I think it's worth talking about.
Google Chrome has a non-standard web background window API that was forgotten by everyone except possibly the Chrome team, for hosted apps.
The documentation for it was removed from the official site, but luckily there's a backup of it on the Internet Archive, and the API still works in hosted web apps on Chrome till this day.
https://web.archive.org/web/20130402163034/https://developers.google.com/chrome/apps/docs/background
I was thinking it fits Beaker's Background Tabs feature and might be a great way to let web apps programatically run in the background [with permission, on user interaction].
Again though, I'm not sure this is a good idea.

Never heard of this in Chrome, it sounds really useful. Do you know why they removed the docs for it? Feels like they may want to phase it out.

It's definitely something being phased out. It predates Service Workers and has only stuck around so long because Google Drive takes advantage of it.
I was just thinking it might be good to support as it's prior art instead of making something new (if that's on the table).


Vercel preset + edge middleware , sets 404 to /api/* endpoints

Environment
Operating System: macOs 12.5.1 (21G83)
Node Version: v16.11.1
Nuxt Version: 3.0.0-rc.6
Package Manager<EMAIL_ADDRESS>Builder: vite
Reproduction
https://stackblitz.com/edit/github-usfnbu
Describe the bug
If a middleware.ts file is created in the root of the project to use vercel's edge middleware, the config.json file that nitro generates sends to 404 to all /api/* endpoints
For example:
{
  "version": 3,
  "routes": [
    {
      "src": "/_nuxt(.*)",
      "headers": {
        "cache-control": "public,max-age=31536000,immutable"
      },
      "continue": true
    },
    {
      "handle": "error"
    },
    {
      "status": 404,
      "src": "^(?!/api).*$",
      "dest": "/404.html"
    },
    {
      "handle": "filesystem"
    },
    {
      "src": "/(.*)",
      "dest": "/"
    }
  ]
}

But if not have that middleware.ts file, the build not generates this exeception to api endpoints
Additional context
No response
Logs
No response

When using nitro, please consider exclusively using server/ directory to avoid such conflicts.


Add a snippet field to Decoration and CrossReference RPC to control whether or not to return snippets. [phab:D1843]

Created by danielmoy-google at 2017-08-08 00:09:10:

danielmoy-google commented inline (context lost during migration) at 2017-08-08 00:11:28:
Right I don't know what the original intention was here.  For the purposes of what I'm doing right now I basically just need a single boolean bit here, but I intentionally made an enum instead so that we could presumably handle this TODO in the future.
I could instead just change back to a boolean.
I don't know enough about what an indexer-default or line-based snippet is to be able to properly implement that right now though, I think.

danielmoy-google commented inline (context lost during migration) at 2017-08-08 00:11:28:
Do we want a snippets boolean toggle for DecorationRequest as well?  I wasn't sure if that even made sense...

fromberger commented inline (context lost during migration) at 2017-08-08 05:09:02:
Since the goal is to allow the caller to control what data they get back, it probably isn't worth doing for xrefs if we don't also do it for decorations. But I'd be interested in opinions from schroederc and zarko.

fromberger commented inline (context lost during migration) at 2017-08-08 05:09:02:
Probably ALL doesn't make sense, since that implies if we have multiple "moieties" of snippet, we would be returning them all. I think probably we want to limit this to one kind only—that's all there's space for in the protocol messages now.
Maybe DEFAULT?

schroederc commented inline (context lost during migration) at 2017-08-08 16:14:31:
Some of the indexers emit snippet offsets for the anchors (usually based on the enclosing expression) but our current clients just wanted simple line-snippets so we don't use them.  There's no current use-case, but it's possible some other client may want them in the future.

schroederc commented inline (context lost during migration) at 2017-08-08 16:14:31:
Put the TODO next to the enum values.

schroederc commented inline (context lost during migration) at 2017-08-08 16:14:31:
Is the implementation in an upcoming change?

schroederc commented inline (context lost during migration) at 2017-08-08 16:14:31:
I'd put the control in both requests.  It's not a terrible feature to implement.

schroederc commented inline (context lost during migration) at 2017-08-08 16:14:31:
Just a note: this changes the default behavior of the requests from returning snippets to not.  This will require a staged release and fixing all clients that care.

danielmoy-google wrote at 2017-08-08 17:06:26:

Addressing first round of comments in (earlier comment).

fromberger commented inline (context lost during migration) at 2017-08-08 17:10:23:
The comment also

fromberger commented inline (context lost during migration) at 2017-08-08 17:10:23:
// What kind of snippets to return (or none).

danielmoy-google commented inline (context lost during migration) at 2017-08-08 17:12:07:
Yup, agreed.  Got a list of steps.

danielmoy-google commented inline (context lost during migration) at 2017-08-08 17:12:07:
Yes.  Next change will be to add the logic, but have default to return snippets.  Then gotta wrangle all clients, fix their code, wait for their release cycles, and then have a follow-up change to default this to none.

danielmoy-google commented inline (context lost during migration) at 2017-08-08 17:12:07:
Ok cool can leave the todo in for now.

danielmoy-google commented inline (context lost during migration) at 2017-08-08 17:12:07:
Oh sorry, my original comment here was written wrong.  I am definitely sticking it in DecroationRequest (in fact, for my current use-case, that's the one that I absolutely need).  I meant to ask here, should I also stick it in DocumentationRequest
s/Decoration/Documentation/

danielmoy-google wrote at 2017-08-08 17:16:43:

Additional comments for (earlier comment).

danielmoy-google commented inline (context lost during migration) at 2017-08-08 17:17:03:
Yea I figured 'all available' is roughly correct for now, no?  We can change comment if there's ever more modes in the future.

fromberger commented inline (context lost during migration) at 2017-08-08 17:18:25:
I guess in the degenerate case where only one is available, that's true -- but if there's more than one option we won't ever be returning more than one of them, which seems confusing.

danielmoy-google commented inline (context lost during migration) at 2017-08-08 17:26:30:
Ok then maybe the best be here is to remove comments entirely?

fromberger commented inline (context lost during migration) at 2017-08-08 17:30:40:
Well, either that or just be specific about the desired behaviour: For example this might sensibly be
// Return the default snippet for each item that has one.
or something along those lines. We don't have to define exactly what "default" is necessarily; it's the "give me something, I don't care what" option.

danielmoy-google commented inline (context lost during migration) at 2017-08-08 17:34:21:
Ok that's fair - if/when we have additional options they'll almost certainly need comments anyways.

danielmoy-google wrote at 2017-08-08 17:34:54:

Additional comments for (earlier comment).

fromberger accepted this revision at 2017-08-08 17:36:33

fromberger commented inline (context lost during migration) at 2017-08-08 17:41:25:
I don't think it's necessary to add it to the Documentation request. Documentation arguably doesn't make any sense without snippets—unlike the other requests where snippets are just part of the metadata.
We can change our minds later if we need to, but I think for now I'd leave it out.

danielmoy-google closed via commit 989a158544b8b69eade82a7c321d3a09a1ea3a7e at 2017-08-08 17:42:32


Add support for EDIF files

This small PR adds support for EDIF files (vendor-neutral gate-level netlists), which makes it easier to work with IPs from tools outside of the Xilinx ecosystem.  Note that when you instantiate a block whose implementation is defined in an EDIF file, you need to include a Verilog stub for the module in the sources list.  This stub should include the setting synthesis syn_black_box:
module myblock (
    input a,
    input b,
    output c
) /* synthesis syn_black_box */;
endmodule

More information here.

Codecov Report

Merging #13 into master will decrease coverage by 0.08%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   69.27%   69.19%   -0.09%
==========================================
  Files          59       59
  Lines        3906     3925      +19
==========================================
+ Hits         2706     2716      +10
- Misses       1200     1209       +9

Impacted Files
Coverage Δ

anasymod/analysis.py
61.12% <0.00%> (-0.28%)
:arrow_down:

anasymod/filesets.py
63.63% <55.55%> (-0.70%)
:arrow_down:

anasymod/generators/vivado.py
80.18% <66.66%> (-1.00%)
:arrow_down:

anasymod/sources.py
74.68% <66.66%> (-0.32%)
:arrow_down:

anasymod/targets.py
95.65% <100.00%> (+0.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39f8195...3dd458f. Read the comment docs.


Update reproduction log.

Everything went on well and the experiments were reproduced.
Environment: MacBook Pro (2019), 32GB RAM and 500G SSD, MacOS 12.0.1, JAVA <IP_ADDRESS>, Maven 3.8.6, Python 3.8.15.

Codecov Report
Base: 58.82% // Head: 58.82% // No change to project coverage :thumbsup:

Coverage data is based on head (8e661c6) compared to base (2d3de32).
 Consider uploading reports for the commit 2665d6c to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2028   +/-   ##
=========================================
  Coverage     58.82%   58.82%
  Complexity     1130     1130
=========================================
  Files           186      186
  Lines         10932    10932
  Branches       1486     1486
=========================================
  Hits           6431     6431
  Misses         4011     4011
  Partials        490      490

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Lazy initialisation of session

Is there a way to do "lazy" initialisation of the session - ie. start the session only when it's actually being used? At the moment, using the session middleware initialises the session on every single page regardless of whether it's actually used on that page, which prevents caching of every single response at a reverse proxy (as responses with cookies are not cacheable at any intermediary server). On my site, only certain pages uses the session, whereas others are fine without it (and I want to cache those pages in Nginx).

I guess I could do this by having my own middleware that wraps SessionMiddleware and only uses it when I know a session is needed (otherwise, bypass it and go directly to the next middleware).
Even so, it would be good to be able to have "session free" controllers that don't start a session. WebForms has enableSessionState which allowed you to enable or disable session on a per-form basis, maybe MVC could have an attribute for that? I also think the session in prior versions of ASP.NET MVC isn't initialised until you explicitly use it, but I'm not 100% sure about that.

The SessionMiddleware is already designed to be lazy. See https://github.com/aspnet/Session/blob/dev/test/Microsoft.AspNet.Session.Tests/SessionTests.cs#L28. If it's failing to be lazy that's probably an issue in consumption (MVC?).
That said, your described behavior sounds bizarre, Set-Cookie and no-cache should only be set on responses that didn't have the request cookie to begin with (and only if session was actually written to). Even if session weren't lazy, it shouldn't write the cookie to every response.

If it's failing to be lazy that's probably an issue in consumption (MVC?).

I'm also using identity/authentication, so it might be something in that middleware. I'll do some investigation and close this out if the issue is elsewhere.

Even if session weren't lazy, it shouldn't write the cookie to every response.

Sure, but after the cookie is set, it's sent in every request from then onwards (via the Cookie request header). Proxies may be set up to not cache any requests that contain a cookie, as the server-side response may vary depending on the cookie. For example, if I have an admin section that is only available when I'm logged in, I wouldn't want any of its responses to be cached at a proxy at all, just in my browser.
In my case, I'm using nginx and I explicitly turn off caching if there's a session cookie:
map $http_cookie $logged_in {
    default 0;
    # Never cache responses if they have auth cookies in them
    ~ASPXAUTH 1;
    ~.MONOAUTH 1;
    ~.AspNet.Session 1;
}

...
    # Scenarios where we don't want to cache
    proxy_cache_bypass $logged_in;
    proxy_no_cache $logged_in;

This is working with the current ASP.NET 4 site, as it is not setting the ASPXAUTH cookie until the session actually begins (so logged out users correctly get the cached responses). In theory (based on your comment) it should be working on the ASP.NET 5 site too, I just need to figure out what's initialising the session too early.

Okay I figured it out. MVC is setting __ControllerTempData to an empty byte array when it loads the temp data: https://github.com/aspnet/Mvc/blob/ff6cbfd7cf93f1bb85e5a3ef24bb4c9a9d7cd38e/src/Microsoft.AspNet.Mvc.ViewFeatures/TempData/SessionStateTempDataProvider.cs#L145-L147. This means that there's always data in the session when accessing MVC TempData, and thus it always initialises it. It seems intentional based on that code.
For now I'll just get rid of TempData in my code. I'll move this to the ASP.NET MVC repo.


"Couldn't find ffmpeg or avconv - defaulting to ffmpeg, but may not work", RuntimeWarning

Describe the bug
Getting an ffmpeg error in the make logs
llm-server-1  |  * Restarting with stat
llm-server-1  | /usr/local/lib/python3.9/site-packages/pydub/utils.py:170: RuntimeWarning: Couldn't find ffmpeg or avconv - defaulting to ffmpeg, but may not work
llm-server-1  |   warn("Couldn't find ffmpeg or avconv - defaulting to ffmpeg, but may not work", RuntimeWarning)

To Reproduce
Steps to reproduce the behavior:

git clone
make install
(In a new terminal.) make logs

Expected behavior
No error
Screenshots

Desktop (please complete the following information):

OS: macOS
Chrome (but not really a browser issue)
Tip of main<PHONE_NUMBER>d68c9fc3373a5572598fa574b29465)

Additional context
The macOS has ffmpeg installed e.g.
ffmpeg -h
ffmpeg version 6.0 Copyright (c) 2000-2023 the FFmpeg developers
  built with Apple clang version 14.0.3 (clang-14<IP_ADDRESS>.1)

hey @tpmccallum , this should usually not affect the copilot performance, but we will add support for it.
@ah7255703 can help us with that.