Fix tags view

Hi,
This PR fixes several issues reported in https://github.com/go-gitea/gitea/issues/23221.
It does three things:

Fixes the DefaultBranch variable that has not been set.
Sets Title and Message for newly created tags from the Tag message. This makes it easier to create releases from tags that have messages and for those that don't it doesn't have any effect.
Makes UI changes so that tags look more like proper releases.

Before:

After:

I purposefully didn't reformat the template so that the diff is cleaner but can do so if that's welcome.
Thanks for your time!

I'm a bit confused because in the issue, the GitHub screenshot shows a tag, but in the gitea screenshot, it shows a release.
Release body text is from the manually created release.
Tag body text is from the git tag message.
Is this how this works? It almost seems like you are using the tag message as the release body text, but I don't think this is matching GitHub's behaviour.

I'm a bit confused because in the issue, the GitHub screenshot shows a tag, but in the gitea screenshot, it shows a release.

It shows a tag. Why do you think it shows a release? The PR makes the display of tags similar to releases. (Or maybe I misunderstood something...)

Release body text is from the manually created release UI.
Tag body text is from the git tag message.

Is this how this works? It almost seems like you are using the tag message as the release body text, but I don't think this is matching GitHub's behaviour.

In my experience it matches GitHub's behavior, see for yourself here: https://github.com/wiktor-k/pysequoia/releases/tag/v0.1.14 and compare with https://try.gitea.io/wiktor/pysequoia/releases/tag/v0.1.14
Then if you compare with my second screenshot it looks more similar to what GitHub renders.
Maybe I misunderstood your question...

Ah, I see Github has a separate page for display of a single tag, which gitea lacks (clicking the tag takes you to the code view).
Do you think we can match GitHub in this regard? E.g. Releases tab should only be for manual releases, and single Tags could be viewed on a separate page just like https://github.com/wiktor-k/pysequoia/releases/tag/v0.1.14.

Ah, I see Github has a separate page for display of a single tag, which gitea lacks (clicking the tag takes you to the code view).

Actually the route is there and the single tag view is also there it's just not used when you click the tag. This is one more thing that I've fixed in this PR.
(replacing src in URL takes to the single tag view: https://try.gitea.io/wiktor/pysequoia/releases/tag/v0.1.15 ).

Do you think we can match GitHub in this regard? E.g. Releases tab should only be for manually created releases, and single Tags should be viewable on a separate page just like https://github.com/wiktor-k/pysequoia/releases/tag/v0.1.14.

I think it already almost works like that. See the URL above. IMHO the tag view just lacked a little bit of polish that the release view had. I hope that this PR bridges the gap a little.

Sounds good, I will test this and I think we should change the link in the tag list to point to the single tag instead. The old link to repo view could then either be moved to the footer or dropped altogether.

Great! Thanks for your time!

@a1012112796 Indeed, this looks better. I've captured your diff into a commit and added it here. Thanks!

Codecov Report

Merging #23243 (0ccc6d3) into main (33e556e) will increase coverage by 0.14%.
The diff coverage is 54.99%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main   #23243      +/-   ##
==========================================
+ Coverage   47.44%   47.58%   +0.14%
==========================================
  Files        1140     1143       +3
  Lines      150804   151088     +284
==========================================
+ Hits        71549    71900     +351
+ Misses      70788    70681     -107
- Partials     8467     8507      +40

Impacted Files
Coverage Δ

cmd/serv.go
2.59% <0.00%> (-0.06%)
:arrow_down:

models/actions/run.go
1.72% <0.00%> (+0.01%)
:arrow_up:

models/actions/run_list.go
0.00% <0.00%> (ø)

models/actions/status.go
22.85% <0.00%> (-1.39%)
:arrow_down:

models/actions/task.go
1.69% <0.00%> (-0.01%)
:arrow_down:

models/auth/oauth2.go
60.52% <ø> (ø)

models/auth/twofactor.go
19.73% <ø> (ø)

models/db/engine.go
44.80% <ø> (ø)

models/unittest/testdb.go
12.92% <0.00%> (ø)

modules/auth/password/hash/pbkdf2.go
69.69% <ø> (ø)

... and 119 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Gave it a test, there's still a few things missing from the Tag view:
Compare GitHub to this PR:

Big header should be added
Tag message (as seen via git show <tag>) is missing

I'm not sure the backend infrastructure is there to obtain the tag message, so if it isn't we could defer that to another PR.

Tag message (as seen via git show ) is missing

@silverwind are you observing a tag that was pushed before this change? Since this commit I fixed the message update for pushed tags. But that will only work for new tags, as the code runs on tag push. (For testing you can remove the tag from UI and git push --follow-tags from console).

Big header should be added

Agreed. I'll fix that right away.

@silverwind are you observing a tag that was pushed before this change

Yes, old tag. Do we store the tag message in the database? We should not, this is retrievable live from the git repo.

@silverwind are you observing a tag that was pushed before this change

Yes, old tag. Do we store the tag message in the database? We should not, this is retrievable live from the git repo.
Releases are fine to store in the database, but tag name and message is part of the git repo.

Tags have been synced to databases when necessary because they just could be added or deleted, and cannot be modified. I think branches should also be synced to databases in future PRs. The beneficial of the operations will help in better performance, better paginations, better search, and better sort.

It sound completely wrong to me to sync tags to database.
You can for example not delete a tag without also deleting it from git itself. Releases are fine in the DB as they are unrelated to git, but tags should be purely based on git. I would suggest at minimum falling back to reading tag info from git if DB does not info on it, but really this sounds completely broken to me.

It's fine to have additional attributes related to a tag in the DB, but the tag base attributes like tag name, message, signature and the tag's existance should come from git only.

It sound completely wrong to me to sync tags to database.
You can for example not delete a tag without also deleting it from git itself. Releases are fine in the DB as they are unrelated to git, but tags should be purely based on git. I would suggest at minimum falling back to reading tag info from git if DB does not have it, but really this sounds completely broken to me.

But the code was there for many years from @lafriks. And there is no better method to resolve the problem to search, sort, pagination problem. If there is any better idea, I think we can discuss them.

Sure, but I would like to at least see the tag message,signature etc of past tags, just like GitHub show, I think it should be possible to fallback to git in case db does not have the tag, right?

I guess we can postpone the tag discussion, and take this PR purely as an UI improvment. I strongly believe that all tag data should come from git and git only. Releases on the other hand are a concept specific to Gitea, of course and have nothing to do with git, except that they can optionally point to tags.

Please resolve the conflicts.

Resolved conflict, rebased on top of main. Tested at it still looks nice:


Is there an option for admin consent?

Is there an optional to use admin consent with MSAL? Our scenario need to grant permission to a webapp to have admin access and make changes to tenants. Admin consent is needed. But not seeing an option with the extraQueryParameters. If not today, is it possible to add the support in near future? and what's the timeline looks like.

I think you'll find help on the wiki:  https://github.com/AzureAD/microsoft-authentication-library-for-js/wiki/Prompt-behavior

I believe this should be done during app registration if I am not wrong. @navyasric Can you confirm how and where admin consent can be set in our flow? Particularly is it in MSAL's scope?

An admin will now be able to see the consent experience inline, would this work for your needs:
https://docs.microsoft.com/en-us/azure/active-directory/develop/application-consent-experience

@JingyuShao Please reopen if the above data is not sufficient for your needs.

I think this still will not work in multi-tenant env. The workflow to grant using application registered in tenantA for user in tenantB is following:

Create app registration in tenantA, allow multi-tenancy, set required permission (for example, User.ReadWrite.All)
Create Web UI + msal.js, use client id from the step 1
Log in using account from tenant B. You will be prompted only for basic consent (view basic profile + sign in). It will be the same even if user is the tenant's B admin.
Send admin consents using URL https://login.microsoftonline.com/_tenant_b_id/adminConsent?client_id=_app_from_tenantA_clientid (here you will see the UI from @aashiman comment https://github.com/AzureAD/microsoft-authentication-library-for-js/issues/601#issuecomment-481412868)

And looks like the step 4 is not possible using msal at all, at least I was not able to find how to do that.

Running into this issue as well, any advice?


terraform-example-foundation-app/6-anthos-install/db-scripts/populate-ledger-db.yaml" does not exist

When I try to execute below command
kubectl apply -n transactions --context ${CTX_1} -f ${HOME}/terraform-example-foundation-app/6-anthos-install/db-scripts/populate-ledger-db.yaml
error: the path "/home/XXXX/terraform-example-foundation-app/6-anthos-install/db-scripts/populate-ledger-db.yaml" does not exist
Looks like above mentioned file is not available in the repo.
Any idea how to generate that populate-ledger-db.yaml file

https://github.com/GoogleCloudPlatform/terraform-example-foundation-app/pull/50#issuecomment-838964462


Add units to data export tables

On a regular basis I get clarification requests for the data export tables.
I think it would be a good improvement if we add units to the data export tables.
Either in the names of the attributes or in an extra row below the column titles.

I think this is a mini flat tire!


Notification when the file on disk changes and you have a dirty editor open

VSCode Version: 1.47 - Insiders
OS Version: macOS

Steps to Reproduce:

Open a github issue notebook file
Turn off auto save and make some changes
Open the same file in another editor, make changes, save
Come back to VS Code, save the notebook

Right now it just saves the file to disk while we should show some warning/notification.

Does this issue occur when all extensions are disabled?: Yes/No

Fixed via notification when the file on disk changes and you have a dirty editor open


Added feature #61254

Added feature #61254, with all the characters proposed (., ,, ;).
Also added the setting in the preferences for the user enable/disable the feature.
In the future, the setting can also allow to choose the characters used to exit.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: TiagoR98 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding and happy coding!


Prefix not applied to all classes

Dear Codyhouse Team,
the configurable prefix does not apply to all classes like text-component, form-control, form-label and form-legend.
Is that intentional?

Hi! Yes, it's intentional. The reason being: we consider the typography, buttons, forms, icons scss files as templates to be copied and modified 'locally'. The reset and utility classes, on the other hand, could be imported from the node module (in case we add new utility classes, you can update the module).
@import 'https://unpkg.com/codyframe/main/css/reset.css'; /* ← reset */

/* ↓ copy these templates from Github & modify them locally */
@import 'typography.css';
@import 'icons.css';
@import 'buttons.css';
@import 'forms.css';

/* ↓ import here the CodyHouse components */
@import 'components/_1_header.css';
@import 'components/_1_footer.css';
/* ... */

@import 'https://unpkg.com/codyframe/main/css/util.css'; /* ← utility classes */


Artman Workflow Java sources staging

This PR is automatically generated by Artmanflow tool

According to @michaelbausor the php failures are expected since the build pulls in the master branch of gax-php, which requires an update in generated php code, which isn't reflected in the repo yet.


feat: Improve UI to show (failed) Pod Reason/Status-Details

Problem:
Rancher does not Show the very important information of the reason - and in general details -  of failed pods. You have to look this up manually in the YAML. The status is the "one and only thing" I care about most, and this information is not found in the UI.
List of failed Pods:

Pod Detail View (of failed pod) => No detail Information about failed Status available.

Status can only be found in YAML:

Solution:
The status should be shown directly in the UI.

+1

Hi @ichtestemalwieder is there an easy way to create a failed pod? It will be great if you can share your yaml

@loganhz, thanks for your answer.
Background: Kubernetes stores Events only for an hour by default (https://github.com/kubernetes/kubernetes/issues/52521).
Within this hour you can find in the Rancher UI under "Status" the reason about the faild Pod. But after the hour has passed (as can be seen in the screenshot above), the Rancher UI does not make it possible in anyway to find the reason for the failed pod.
Fix: Please see the kubectl output below, you can find information about the pod (even afther the hour) in the Status/Reason/Message fields. And these should somehow be used to display the status in the UI. I am new to kubernetes maybe there is more or even better inormation, I do not know about. So this should be discussed with someone how knows more;-)
> kubectl describe pod keycloak-796d4f6bc6-24m7c
Name:           keycloak-796d4f6bc6-24m7c
Namespace:      default
Priority:       0
Node:           etw2/
Start Time:     Wed, 01 Jan 2020 01:38:45 +0000
Labels:         pod-template-hash=796d4f6bc6
                workload.user.cattle.io/workloadselector=deployment-default-keycloak
                workloadID_ingress-11cdb1de408ca49a88715b279e8234a8=true
Annotations:    cattle.io/timestamp: 2020-01-01T01:38:31Z
                field.cattle.io/ports: [[{"containerPort":8080,"dnsName":"keycloak","kind":"ClusterIP","name":"web","protocol":"TCP"}]]
                workload.cattle.io/state: {"ZXR3Mg==":"c-gxgtk:m-hkq42"}
Status:         Failed
Reason:         OutOfcpu
Message:        Pod Node didn't have enough resource: cpu, requested: 200, used: 900, capacity: 1000
IP:
IPs:            <none>
Controlled By:  ReplicaSet/keycloak-796d4f6bc6
Containers:
  keycloak:
    Image:      jboss/keycloak
    Port:       8080/TCP
    Host Port:  0/TCP
    Requests:
      cpu:     200m
      memory:  300Mi
    Environment:
      DB_VENDOR:                 h2
      PROXY_ADDRESS_FORWARDING:  true
    Mounts:
      /var/run/secrets/kubernetes.io/serviceaccount from default-token-xc742 (ro)
Volumes:
  default-token-xc742:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  default-token-xc742
    Optional:    false
QoS Class:       Burstable
Node-Selectors:  <none>
Tolerations:     node.kubernetes.io/not-ready:NoExecute for 300s
                 node.kubernetes.io/unreachable:NoExecute for 300s
Events:          <none>

YAML to reproduce is below:
Please note, that I bound the pod to a specific host (nodeName) and then requested  more CPU than this machine has.  This leads to a failed scheduling loop.
When doing this, you will realize another bug/problem with Rancher UI. As new pods are being scheduled very fast, the UI becomse unresponsive. Try to open the "context menu with right click" (ony the workloads screen) will  be impossible.  To stop the scheduling cllick on the deployment and then click on "Config Scale: - (Minus)" and scale to zero (this also requires several clicks as it seems unresponsive).
Note: You have to wait an hour bevor the events get deleted.
But as stated above the Status/Reason/Message Fields can be seen directly from the first second on.
apiVersion: apps/v1
kind: Deployment
metadata:
  name: debian-deployment
  labels:
    app: debian
spec:
  selector:
    matchLabels:
      app: debian
  template:
    metadata:
      labels:
        app: debian
    spec:
      containers:
      - name: debian
        image: debian
        resources:
          requests:
            cpu: "20"
      nodeName: etw5

Thanks @ichtestemalwieder ! Please check if the screenshot is what you wanted.
For the re-creating failed pod too fast issue, it looks like it is by design. I think you need to scale it to zero to stop it. And then you could use Rancher UI or kubectl to remove those failed pods. Didn't find a way to limit it in Kubernetes side. Maybe you can google it. :)
For the action menu one, could you file another issue please?

@loganhz. Thanks so much. Absolutely great, love it, is super informative. You can see with one view what the status is.  Thanks!
(Sorry, as I am quite new here: I assume this issue will be closed automatically with the merge/releaes of the fix? In case I have to close it, please let me know.)

Rancher QA will validate and close it.


guard-minitest falsely claims there are 0 tests to run

$ ruby hamming_test.rb
# ...
15 runs, 0 assertions, 0 failures, 2 errors, 13 skips

BUT:
$ guard
# ...
0 runs, 0 assertions, 0 failures, 0 errors, 0 skips

$ guard -d
# ...
23:33:20 - DEBUG - Running: ruby -I"test" -I"spec" -r minitest/autorun -e "" --
# ...

# ./Guardfile
guard :minitest do
  # with Minitest::Unit
  watch('hamming.rb') {'hamming_test.rb'}
  watch('hamming_test.rb')
end

#./Gemfile.lock
# ...
guard (2.13.0)
guard-minitest (2.4.4)
# ...

$ ruby --version
ruby 2.3.0p0 (2015-12-25 revision 53290) [x86_64-darwin15]

$ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.11.3
BuildVersion:	15D21

ruby -I"test" -I"spec" -r minitest/autorun -e ""

What if you run just that command instead of guard?

$ ruby -I"test" -I"spec" -r minitest/autorun -e ""
#...
0 runs, 0 assertions, 0 failures, 0 errors, 0 skips

When I edit it as follows, the tests are run:
$ ruby -I"-r minitest/autorun -e " hamming_test.rb
# ...
15 runs, 0 assertions, 0 failures, 2 errors, 13 skips

$ tree
.
├── Guardfile
├── README.md
├── hamming.rb
└── hamming_test.rb

0 directories, 4 files

The files have to be within directories specified with the test_folders option.
Your file hamming_test.rb is neither in spec nor test, so it's ignored.
See: https://github.com/guard/guard-minitest#test_folders-and-test_file_patterns
I'd suggest just moving hamming_test.rb to a test subdirectory.
And change the watches to handle this.

Thx for the info. Instead of moving the files, I did:
guard :minitest, test_folders: './', test_file_patterns: '*_test.rb' do
which made more sense in my particular case.


[DRAFT] Do single server signature help

Review last commit.
Based on #6718 6718

Merged my PR, you can rebase/merge 😀


Fix Lint/DuplicateMethods

Summary
Investigated the Lint/DuplicateMethods offenses and need guidance on how best to address them.
Details

Offense count: 2
Added review note as I'm unsure how these should be handled.
Review note: In the two instances of duplication, both methods are under MultilineArgument, but one self method calls another that belongs to the private Builder class.
Here's the code in question

Motivation and Context
Working to help solve issue 1021!
How Has This Been Tested?
bundle exec rake :+1:
Screenshots (if appropriate):
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

I think you could safely inline those two method calls on lines 32 and 36, and construct the types directly there. Leave the Builder to just be used for the from_core method.

So, in getting more familiar with the code and realizing that builder.doc_string and builder.data_table are pretty widely used concepts, it makes removing them from the Builder class not a good idea, IMO. Here's some info on what I did, and why:
*There's only a single point that calls MultilineArgument.doc_string directly when running the rake tests, so I've changed it to MultilineArgument.doc_string_builder and modified the method outside Builder in multiline_argument.rb to match.

While there seem to be no tests that touch lines 35-37 of multiline_argument.rb aka data_table I've updated it to match the dos_string_builder naming scheme, too. This section of code potentially has a coverage issue as it seems like we're not testing arrays. I can comment out the code called here, and rake doesn't break
I've also changed the #from method for both string and array argument types, so that code that utilizes #from will work accordingly too.

Running bundle exec rake succeeds without any errors due to this change.
Commit inc!

Inlined the function so things should look/feel better.


fix verify gendocs

master verify gendocs is broken. GA beacon and other stuff.

@lavalamp

LGTM

How did this get past Shippable? My bad. :(

It was probably a merge of something with a stale pass.

Yeah, this is a case where we need a submit queue versus a presubmit check.

https://github.com/GoogleCloudPlatform/kubernetes/pull/11073#issuecomment-120511345 +1

@rjnagal for merge

Build is broken, so I'm merging.


Editor crashes when stopping a running scene on Linux

When I run any of the example scenes - the Playground main scene or any of the sub-scenes in ..., the Editor dies after I click the play button the second time to stop the scene.
Device: OAK-D-Lite
Unity: 2021.2.7f1
OS: Ubuntu 21.10 x86_64
Kernel: 5.13.0-27-lowlatency
CPU: Intel i7-7820X @3.60 GHz, 8 physical cores
GPU: NVIDIA TITAN RTX, driver version 470.86
Memory: 64 GB
The setup is the same as described in issue #8, only now what I do is:

open a scene in editor
push the play button to start preview run
push the play button to stop preview run
the editor crashes

I tried to run in gdb again
gdb /opt/unity/2021.2.7f1/Editor/Unity

Only this time there were more bogus signals trapped when I didn't want to, so to set up gdb:
set mi-async 1
set pagination off
set non-stop on
handle SIGXCPU SIGPWR SIG36 SIG37 nostop noprint
run -projectPath ~/hax/depthai-unity/OAKForUnity/URP/

Now I open the scene in the editor, push the play button, wait for the scene to fully load, go to gdb again and hit Ctrl+C
handle SIGXCPU stop print
continue

Now I hit the play button again to stop the running scene. The Editor dies, and I get a stack trace (actually about 30 killed threads, only number 1 seems to be relevant):
Thread 1 "Unity" received signal SIGXCPU, CPU time limit exceeded.
backward::SignalHandling::sig_handler (signo=0, info=0x3db61d19, _ctx=0xbf7efc623c114bb3) at /home/strazce/.hunter/_Base/062a19a/e4f2f5b/72dac15/Install/include/backward.hpp:4263
4263	  sig_handler(int signo, siginfo_t *info, void *_ctx) {
(gdb) thread 1
[Switching to thread 1 (Thread 0x7fffed3ad340 (LWP 167877))]
#0  backward::SignalHandling::sig_handler (signo=0, info=0x3db61d19, _ctx=0xbf7efc623c114bb3) at /home/strazce/.hunter/_Base/062a19a/e4f2f5b/72dac15/Install/include/backward.hpp:4263
4263	  sig_handler(int signo, siginfo_t *info, void *_ctx) {
(gdb) bt
#0  backward::SignalHandling::sig_handler(int, siginfo_t*, void*) (signo=0, info=0x3db61d19, _ctx=0xbf7efc623c114bb3) at /home/strazce/.hunter/_Base/062a19a/e4f2f5b/72dac15/Install/include/backward.hpp:4263
#1  0x00007ffff0207520 in <signal handler called> () at /lib/x86_64-linux-gnu/libc.so.6
#2  0x00007ffff020780a in __GI___sigsuspend (set=0x7ffedc5e11a0) at ../sysdeps/unix/sysv/linux/sigsuspend.c:26
#3  0x00007ffedc2a47ac in GC_suspend_handler_inner () at /opt/unity/2021.2.7f1/Editor/Data/MonoBleedingEdge/MonoEmbedRuntime/libmonobdwgc-2.0.so
#4  0x00007ffedc2a4665 in GC_suspend_handler () at /opt/unity/2021.2.7f1/Editor/Data/MonoBleedingEdge/MonoEmbedRuntime/libmonobdwgc-2.0.so
#5  0x00007ffff0207520 in <signal handler called> () at /lib/x86_64-linux-gnu/libc.so.6
#6  __futex_abstimed_wait_common64 (private=<optimized out>, cancel=true, abstime=0x7fffffffc0f0, op=393, expected=0, futex_word=0x7ffceff36940 <schedulerState+24832>) at futex-internal.c:57
#7  __futex_abstimed_wait_common (cancel=true, private=<optimized out>, abstime=0x7fffffffc0f0, clockid=0, expected=0, futex_word=0x7ffceff36940 <schedulerState+24832>) at futex-internal.c:87
#8  __GI___futex_abstimed_wait_cancelable64 (futex_word=futex_word@entry=0x7ffceff36940 <schedulerState+24832>, expected=expected@entry=0, clockid=clockid@entry=0, abstime=abstime@entry=0x7fffffffc0f0, private=<optimized out>) at futex-internal.c:139
#9  0x00007ffff02617f0 in do_futex_wait (sem=sem@entry=0x7ffceff36940 <schedulerState+24832>, abstime=abstime@entry=0x7fffffffc0f0, clockid=0) at sem_waitcommon.c:112
#10 0x00007ffff0261893 in __new_sem_wait_slow64 (sem=0x7ffceff36940 <schedulerState+24832>, abstime=0x7fffffffc0f0, clockid=0) at sem_waitcommon.c:184
#11 0x00007ffcef4be377 in XLink_sem_timedwait () at /home/strazce/hax/depthai-unity/build/depthai-core/libdepthai-core.so
#12 0x00007ffcef4bb203 in DispatcherWaitEventCompleteTimeout () at /home/strazce/hax/depthai-unity/build/depthai-core/libdepthai-core.so
#13 0x00007ffcef4b8dff in XLinkResetRemoteTimeout () at /home/strazce/hax/depthai-unity/build/depthai-core/libdepthai-core.so
#14 0x00007ffcef4a8faa in dai::XLinkConnection::close() (this=0x55556730b6e0) at /home/strazce/hax/depthai-unity/depthai-core/src/xlink/XLinkConnection.cpp:186
#15 0x00007ffcef2fbb21 in dai::DeviceBase::closeImpl() (this=0x55555a883480) at /home/strazce/hax/depthai-unity/depthai-core/src/device/DeviceBase.cpp:369
#16 0x00007ffcef2e8508 in dai::Device::closeImpl() (this=0x55555a883480) at /home/strazce/hax/depthai-unity/depthai-core/src/device/Device.cpp:82
#17 0x00007ffcef2fbacd in dai::DeviceBase::close() (this=0x55555a883480) at /home/strazce/hax/depthai-unity/depthai-core/src/device/DeviceBase.cpp:359
#18 0x00007ffdaab221c9 in DAICloseDevice(int) (deviceNum=0) at /home/strazce/hax/depthai-unity/src/device/DeviceManager.cpp:207
#19 0x0000000040762fb3 in  ()
#20 0x00007fffffffca00 in  ()
#21 0x000055555e72d010 in  ()
#22 0x00007fffffffc8b0 in  ()
#23 0x00007ffda9e2aa80 in  ()
#24 0x00007ffda9e2aa80 in  ()
#25 0x000055555caa4638 in  ()
#26 0x0000000040762f11 in  ()
#27 0x000055555b6b4f10 in  ()
#28 0x00007fffffffc6c0 in  ()
#29 0x00007fffffffc5f0 in  ()
#30 0x0000000000000000 in  ()

Hi ! this last week I had not much time to dig into the issue, but I've doing some tests. It's bit strange because the stacktrace points to close device. Would you mind to comment lines 289, 299 and 309 - DAICloseDevice((int) device.deviceNum); of file URP\Assets\Plugins\OAKForUnity\Scripts\Predefined\PredefineBase.cs     and check stacktrace?. I need to check more in deep but it's bit strange as still facing crash when comment the close device.

@gespona try recreating - we got some fixes addressing underlying XLink in develop - might be worth checking against that

Thanks @themarpe !  Will give a try for sure and give feedback here .. during my tests I was noticing some unstability when updated to latest main ... so makes sense and I was about to check with you in the core part.

Hi ! @themarpe reading again your comment ... just to clarify with context from discord .. I'm able to reproduce the issue all the time. Last iteration on the unity plugin is focused first on Windows (and it's working fine there and on Mac) I was checking if something related to last improvements on Unity side could lead to this crash.
So this morning I went back to latest version tested on Linux (based on depthai-core 18th Sep) and everything works fine (release v2.10.0) and unity editor is not crashing when stop the scene. Probably this is not good enough workaround for the moment for @sliwowitz as this version was not supporting OAK-D-Lite.
I tested again develop but still crashing, so will ping you to check together, ok?

Sounds good - thanks!

Would you mind to comment lines 289, 299 and 309 - DAICloseDevice((int) device.deviceNum); of file URP\Assets\Plugins\OAKForUnity\Scripts\Predefined\PredefineBase.cs and check stacktrace?. I need to check more in deep but it's bit strange as still facing crash when comment the close device.

Yep. Still crashing even with these lines commented out. As you mention in the other comment, older depthai-core does not have this problem? I'll try to look into it next week, though I have to try with the new versions as I only have the OAK-D-Lite

Would you mind to comment lines 289, 299 and 309 - DAICloseDevice((int) device.deviceNum); of file URP\Assets\Plugins\OAKForUnity\Scripts\Predefined\PredefineBase.cs and check stacktrace?. I need to check more in deep but it's bit strange as still facing crash when comment the close device.

Yep. Still crashing even with these lines commented out. As you mention in the other comment, older depthai-core does not have this problem? I'll try to look into it next week, though I have to try with the new versions as I only have the OAK-D-Lite

Any chance to get the stacktrace? :) I'm working on few suggestions from @themarpe but no luck for now. I tested with OAK-D and depthai-core 2.10.0 and everything works fine but it's version previous OAK-D Lite support so not good enough workaround for you. Will try to speed up on the issue.

I'm not at my main machine until Tuesday. I'll get the stacktrace when I'm back.

Thanks a lot @sliwowitz !

OK. Here's the stack trace oak-d-no-device-close.log, but this time I have no idea what's happening or even where. At the beginning of the file, you can see that the main thread didn't die this time, but was running when the editor crashed. When I poked in, it was sleeping inside some GC cycle. Most of the other threads seem to be:

Burst/JIT related which have died either waiting for a pthread futex, or maybe also in a GC cycle -  I don't know anything about C# internals, just guessing from the function names.
Unity threads dying on SystemNative_Read

This time, the exception seems to be the last two threads, "Unity" number 156 starting at line 751, and "Loading.Preload" number 158 starting at line 771.
You won't find any reference to anything depthai in any of the dead threads. If I interrupt all threads and poke inside oak-d-no-device-close-all-threads.log, the three threads referencing depthai - no. 150 (l.67), no. 149 (l. 81), and no. 148 (l. 95) all seem to be peacefully waiting or polling.

@sliwowitz Thanks a lot for taking the time and send the info. Yes it's being a tricky/difficult issue.
About this case without closing device, yes it's really strange because initially though the crash was directly related to execute close device, but then I was surprised to see the crash commenting the lines.
So with @themarpe we're investigating other potential issues related to smart pointers, asan, ... as core v2.10 with OAK-D is working fine.
Thanks for your patience on this issue.

I gave this a try again today, and cannot reproduce the issue anymore with neither OAK-D Lite or my new OAK-D Pro :-). I'm on Ubuntu 22.10 with Unity 2022.2.1f1 or 2012.3.16f1 now. My guess would be it was fixed by one of recent core version bumps.
Not even clicking the unimplemented features (face detection, body pose, etc.) in running scene would crash the Editor (it crashes the build though). Overall it feels much more robust now - as robust as the Editor gets on Linux.

How can I change the prewiew resolution of the face detector scene? I change it to 600*300,but the face detector function doesn't work.

Hi @sliwowitz !, I was doing my own round of tests on Linux and I can confirm that I was not able to reproduce the issue anymore.  Also I agree with you, the "fix" comes with recent core version bumps ;)    Closing the ticket ;)


Fix circular reference in compiler

When trying to migrate to vitest found that we had some circular reference that caused more issues. This is just fixing that part.

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/2767/
Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/2767/


Putting a scrollview inside an other one can lead to total lost of touch events

Versions

Python: Python 3.8.1
OS: Arch Linux
Kivy: v2.0.0rc1, git-315ca99, 20200222
Kivy installation method: pip install --user git+https://github.com/kivy/kivy.git

Description
If a ScrollView is placed inside an other ScrollView, and if the inner ScrollView is virtually under a widget (e.g. a button), the touch events in the button are lost. Please check the test code below for a better understanding.
Code and Logs
In the code below, a ScrollView (InnerScrollView) is added in the hierarchy under a main ScrollView. This is a use case seen in a real chat application.
Try to click on the button, the first time it works as expected. Clicking on the button will move the inner scrollview virtually "under" the button. Click again on the button, if the bug is still present, the second click won't work. If you move the main scrollview to the initial position (or any position where the inner scrollview is not virtually "under" the button), it will work again.
from kivy.config import Config
Config.set('kivy', 'log_level', 'debug')

from kivy.app import App
from kivy.lang import Builder
from kivy.factory import Factory
from kivy.uix.boxlayout import BoxLayout
from kivy.metrics import dp

kv = """
#:import rand_float random.uniform

<CustomLabel@Label>:
    size_hint: 1, None
    height: dp(30)
    text: 'some label'

<InnerScrollItem@Label>:
    size_hint: None, 1
    width: dp(200)
    text: "item"

<InnerScrollView@ScrollView>:
    do_scroll_y: False
    size_hint: 1, None
    height: dp(50)
    canvas.before:
        Color:
            rgba: 0, 0.8, 0.8, 1
        Rectangle:
            pos: self.pos
            size: self.size
    BoxLayout:
        size_hint: None, 1
        width: self.minimum_width
        InnerScrollItem:
        InnerScrollItem:
        InnerScrollItem:
        InnerScrollItem:
        InnerScrollItem:

<Test>:
    orientation: "vertical"
    Button:
        size_hint: 1, None
        height: dp(25)
        text: 'click me'
        on_press: root.on_button_press()
    ScrollView:
        id: main_scrollview
        do_scroll_x: False
        BoxLayout:
            id: box_layout
            orientation: "vertical"
            size_hint: 1, None
            height: self.minimum_height
"""

class Test(BoxLayout):
    def __init__(self, *args, **kwargs):
        super(Test, self).__init__(*args, **kwargs)
        self.ids.box_layout.add_widget(Factory.InnerScrollView())
        for i in range(100):
            self.ids.box_layout.add_widget(Factory.CustomLabel())

    def on_button_press(self):
        print("click OK")
        scrollview = self.ids.main_scrollview
        scrollview.scroll_y = 1 - scrollview.convert_distance_to_scroll(0, dp(25))[1]
        print(
            "the inner scrollview has been moved under the button, if the bug is not "
            "fixed, the next click won't work"
        )

class TestApp(App):
    def build(self):
        return Test()

if __name__ == '__main__':
    Builder.load_string(kv)
    TestApp().run()

note: after double check, it may be a duplicate of https://github.com/kivy/kivy/issues/6460, sorry if this is the case, but the test in this ticket may be a hint for the debugging.

Closing as duplicate


Hydration from column names

My use case: I listen to MySQL binary log row events (which contain only column names) and want to hydrate doctrine entities from those.
I added an option (hydrateBy) to control whether the input data array's keys are entity field names (default) or database column names.
I also added an option (hydrateId, turned off by default) to hydrate primary key fields too. This is useful for example when the primary key is not auto-generated by the database.

Thanks for merging. Are you going to make a release too with it?

Did you see my comment on #7?
I'll get #7 merged in then tag a new release.


Issue 1568 npm to yarn

Summary
Add a yarn.lock file at the root of the project.
Replace NPM with Yarn in travis.yml file.
Test Plan
Ensure that travis run without errors.
All current npm scripts has been manually tested (prepublish, pretest, build, dev, postbuild, lint, format, flow, test, test-ci), there are many lint warning on test files (see attached screenshots).

[x] get yarn set up for yourself
[x] cd draft-js && rm -rf node_modules && yarn install
[x] verify that builds, lint, tests, etc. are passing
[x] commit the resulting yarn.lock file that gets added to the root of the repo
[x] update .travis.yml to use yarn instead of npm for all commands. Note that the yarn commands may vary a bit from the npm CLI commands.

Hi @Tonours,
Thanks for submitting this PR, if you can amend the comments above from Paul I then should be able to land this.

Hi @zpao and @mitermayer !
Good catch for website package.json and yarn upgrade in travis @zpao 👍
So, the website now have a yarn.lock file :-)

@zpao , Now that we will move from npm to yarn, can we do something about this line on our package.json ?
"devEngines": {
    ...
    "npm": "2.x || 3.x"
}

Can we either remove that npm engine or bump it to latest npm ?

Also @Tonours, do you mind rebasing your pull request with master to fix your segfault ?

Looks like the builds are failing in travis due to that npm version on our package.json
yarn run v1.3.2
$ node node_modules/fbjs-scripts/node/check-dev-engines.js package.json
assert.js:42
  throw new errors.AssertionError({
  ^
AssertionError [ERR_ASSERTION]: Current npm version is not supported for development, expected "5.5.1" to satisfy "2.x || 3.x".

Hi @mitermayer !
Thanks for your feedback 👍
I've updated npm devEngines requirements for npm.
Let me know if everything is good for you.


Linux server directory problem

root@iZ2ze3qm14oebwj7c6a0d9Z:/mnt/fhd# ls
 ForUpload  'ForUpload\config\iwtcms'  'ForUpload\config\iwtcms\iwtcms.json'   SwapFile   TestOnlyServer   grandServer   lost+found   wget-log
root@iZ2ze3qm14oebwj7c6a0d9Z:/mnt/fhd#

The server was under /mnt/fhd/ForUpload, like where the start script and the 'mods' directory takes place, however the mod is generating its configs outside the game folder, in the root folder of the drive's mounting point.

@AXCWG Fixed in 1.2.0-Fix_2


How to sync variables name across few files?

I am trying to implement this obfuscator as vite plugin, but it is very not friendly to all the dynamic imports stuff and other things. Whatever I try it breaks the code for some reason. I am not an expret in vite tho, but I assumer half of the problems lise in not synchronized variables names. I thought use of single obfuscator instance to obfuscate the code will help.
I have like a million errors, even tho it is most probably my fault, half of them will be pretty usefull to invastigate to improve the obfuscator.

this gets interesting :P

Also, I don't get it, when static properties gets replaced (with some string modificator). It seems to work inconsistent

Move declarations breaks imports

I made exactly like rollup-obfuscator with javascript-obfuscator, but it worked


go mods

I wanted to bosh on this a little but before I start I've updated it to go mods incase thats handy?

Lots of updates done to the Makefiles to get everything working done
Stuck at go generate now as its attempting to pull content from the ../../vendor dep path.. I'll have to dig into this further to see how they're handling that in more recent versions of kube builder (I've not done much generating before)

Converting the PR to a draft as its WIP

That issue can be solved by creating a tools.go file that includes the tool dependency, eg following this https://marcofranssen.nl/manage-go-tools-via-go-modules

Rebased to let the tests run

Hey @toelke, I think I was able to repro the test failure locally. This seemed to fix it for me:

https://github.com/starkers/wave/pull/1

I've tried to combine this PR + Mark's but, but I couldn't able to compile the tests with: go test -c ./...:
# sigs.k8s.io/controller-runtime/pkg/log
../../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.2.2/pkg/log/log.go:48:31: cannot use NullLogger{} (value of type NullLogger) as logr.Logger value in argument to NewDelegatingLogger
../../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.2.2/pkg/log/null.go:30:21: cannot use NullLogger{} (value of type NullLogger) as logr.Logger value in variable declaration
../../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.2.2/pkg/log/null.go:48:37: undefined: logr.InfoLogger
../../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.2.2/pkg/log/null.go:54:9: cannot use log (variable of type NullLogger) as logr.Logger value in return statement
../../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.2.2/pkg/log/null.go:59:9: cannot use log (variable of type NullLogger) as logr.Logger value in return statement
../../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.2.2/pkg/log/deleg.go:103:9: cannot use res (variable of type *DelegatingLogger) as logr.Logger value in return statement
../../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.2.2/pkg/log/deleg.go:116:9: cannot use res (variable of type *DelegatingLogger) as logr.Logger value in return statement
# github.com/go-logr/glogr
../../../go/pkg/mod/github.com/go-logr/glogr@v0.1.0/glogr.go:18:9: cannot use glogger{…} (value of type glogger) as logr.Logger value in return statement
../../../go/pkg/mod/github.com/go-logr/glogr@v0.1.0/glogr.go:127:36: undefined: logr.InfoLogger
../../../go/pkg/mod/github.com/go-logr/glogr@v0.1.0/glogr.go:142:9: cannot use new (variable of type glogger) as logr.Logger value in return statement
../../../go/pkg/mod/github.com/go-logr/glogr@v0.1.0/glogr.go:148:9: cannot use new (variable of type glogger) as logr.Logger value in return statement
../../../go/pkg/mod/github.com/go-logr/glogr@v0.1.0/glogr.go:151:21: cannot use glogger{} (value of type glogger) as logr.Logger value in variable declaration
../../../go/pkg/mod/github.com/go-logr/glogr@v0.1.0/glogr.go:152:12: undefined: logr.InfoLogger
# github.com/go-logr/zapr
../../../go/pkg/mod/github.com/go-logr/zapr@v0.1.0/zapr.go:133:39: undefined: logr.InfoLogger
../../../go/pkg/mod/github.com/go-logr/zapr@v0.1.0/zapr.go:156:9: cannot use &zapLogger{…} (value of type *zapLogger) as logr.Logger value in return statement

I have merged #145. Thank you so much for the work in this PR!


Create Endpoint POST /exchange/:exchId/:txId#4

For details of what goes into this endpoint, see Section 3: Wallet continues the exchange, of the DCC's Enhanced VC-API Flow document, linked to from Slide 7 of the Sign-and-verify refactoring plan.

@dmitrizagidulin @jchartrand ok to close this issue?

@kayaelle Yes, ok with me.

Thanks!


Test test_state_with_pathlib fails on Python 3.13.0a4

In Fedora Linux, we’re testing Python 3.13.0a4. As reported in https://bugzilla.redhat.com/show_bug.cgi?id=2264873, the test test_state_with_pathlib fails on Python 3.13.0a4 because it attempts to set the read-only property _raw_path on a PosixPath object.
=================================== FAILURES ===================================
___________________________ test_state_with_pathlib ____________________________
h5io/tests/test_io.py:415: in test_state_with_pathlib
    path_obj_reload = read_hdf5(
h5io/_h5io.py:529: in read_hdf5
    return _read(fid)
h5io/_h5io.py:523: in _read
    return _triage_read(fid[title], slash=slash)
h5io/_h5io.py:596: in _triage_read
    return _setstate(
h5io/_h5io.py:944: in _setstate
    setattr(obj, k, v)
E   AttributeError: property '_raw_path' of 'PosixPath' object has no setter
- generated xml file: /builddir/build/BUILD/h5io-h5io-0.2.2/junit-results.xml --
=========================== short test summary info ============================
SKIPPED [1] h5io/tests/test_io.py:30: could not import 'tables': No module named 'tables'
SKIPPED [1] h5io/tests/test_io.py:489: only python3.11 or lower
FAILED h5io/tests/test_io.py::test_state_with_pathlib - AttributeError: property '_raw_path' of 'PosixPath' object has no setter
=================== 1 failed, 13 passed, 2 skipped in 0.52s ====================

I can’t give instructions to reproduce this in a virtualenv yet, because there isn’t a numpy wheel for Python 3.13 yet:
$ python3.13 -V
Python 3.13.0a4
$ python3.13 -m venv _e
$ . _e/bin/activate
(_e) $ pip install -e .
[attempts to compile numpy from the sdist, but explodes]

However, I’m happy to test any proposed patches.

Hi @musicinmybrain thanks for the feedback, that is definitely very valuable.
Can you try the following?:
from pathlib import Path

if __name__ == "__main__":
    p = Path("test/path/local")  # this path does not need to exist
    reduced = p.__reduce__()
    print(reduced, [type(el) for el in reduced])

On Python 3.12 this returns:
(<class 'pathlib.PosixPath'>, ('test', 'path', 'local')) [<class 'type'>, <class 'tuple'>]

Does it return the same with Python 3.13?

With Python 3.13, it does return the same:
(<class 'pathlib.PosixPath'>, ('test', 'path', 'local')) [<class 'type'>, <class 'tuple'>]

Since numpy published a wheel compatible with Python 3.13, you can now reproduce this in a virtualenv:
$ gh repo clone h5io/h5io
$ cd h5io
$ python3.13 -m venv _e
$ . _e/bin/activate
(_e) $ pip install -e .
(_e) $ pip install pytest pytest-cov
(_e) $ python -m pytest

There are no h5py wheels, though. Hopefully https://github.com/h5py/h5py/pull/2444 will help with that and I can use it in https://github.com/h5io/h5io/pull/102


CaptureRequest not handled in case that user captures before the request flow starts collection

A case of that is to capture immediately after the page is shown:
        // The content to be captured ⬇
        Ticket(modifier = Modifier.capturable(captureController))

        Spacer(modifier = Modifier.size(32.dp))

        // Captures ticket bitmap on click
        Button(
            onClick = {
                uiScope.launch {
                    ticketBitmap = captureController.captureAsync().await()
                }
            }
        ) {
            Text("Preview Ticket Image")
        }

        LaunchedEffect(Unit) {
            ticketBitmap = captureController.captureAsync().await()
        }

In such case, captureRequest will be emitted (in CaptureController#captureAsync) before CapturableModifierNode starts to collect the captureRequests flow (in CapturableModifierNode#observeCaptureRequestsAndServe), so this request will never be handled.
Reproducer: https://github.com/ssttkkl/Capturable/commit/57f4d9c9e4de70b16740c24e46041056856c596d

A simple solution is make the observing job launch in dispatcher except the Main dispatcher. I tried to fix it and maybe I can make a PR to solve this issue. https://github.com/ssttkkl/Capturable/commit/7bad2cfaf56eb59cd5c95834f489e69fb0a03346

A simple solution is to set extraBufferCapacity = 0 and use suspend emit method, so that the emission will suspend until the flow collection starts.
I tried to fix it: https://github.com/ssttkkl/Capturable/commit/7bad2cfaf56eb59cd5c95834f489e69fb0a03346 An extra coroutineScope was introduced to run the emission and wait for result async.

Thanks for reporting the issue. Will look into this, I would not want to introduce another CoroutineScope here as it'll serve concurrent requests as well which we don't want.

Fixed in v3.0.0


Update requirements.txt

re-synced

whoa! Sorry - somehow I was in your github tree rather than mine! I have a fork - I must have clicked through into yours without noticing. Ignore, ignore, ignore!
Sorry again


Fixes issue 529.

File.separator instead of / so that file system paths are processed properly when running builds on windows. Actually the problem was covered by TestDependenciesSpec "unused test dependencies are reported" already: Running it on windows failed before doing this change. With the change it now passes.

Thank  you for this contribution! It'll be in the next release.


[Feature][UI Next] Add apis.

Purpose of the pull request
close #7462

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

Merging #7463 (129654d) into dev (91e3423) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #7463      +/-   ##
============================================
- Coverage     41.26%   41.21%   -0.05%
+ Complexity     3659     3655       -4
============================================
  Files           635      635
  Lines         26426    26426
  Branches       2959     2959
============================================
- Hits          10905    10892      -13
- Misses        14495    14510      +15
+ Partials       1026     1024       -2

Impacted Files
Coverage Δ

...r/plugin/registry/zookeeper/ZookeeperRegistry.java
48.64% <0.00%> (-8.11%)
:arrow_down:

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...org/apache/dolphinscheduler/remote/utils/Host.java
37.77% <0.00%> (-2.23%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
52.11% <0.00%> (-1.41%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91e3423...129654d. Read the comment docs.


[CT-3444] Migration progress script

Introduce a script to track progress of removing direct core dependencies in a repo / path

Closed by: https://github.com/dbt-labs/dbt-core/pull/9160


[BugFix] fix deleting data file by mistake when do partial update in cloud native primary table

In current implementation, TxnLog in meta cache will be modified when do partial update and it could cause deleting data file by mistake. E.g.

We have TxnLog in meta cache:

OpWrite {
        RowsetMetadataPB {
               segments : ["aaa.dat"]
        }

        rewrite_segments : ["bbb.dat"]
    }

If publishing version failed when putting TabletMeta to object storage, so that TxnLog in meta cache will be:
OpWrite {
        RowsetMetadataPB {
               segments : ["bbb.dat"]
        }

        rewrite_segments : ["bbb.dat"]
    }

Then SR publish version again, bbb.dat will be moved to trash files, and will be deleted later.

What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[x] 3.1
[ ] 3.0
[ ] 2.5

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:heart_eyes: pass : 25 / 26 (96.15%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/storage/lake/tablet_manager.cpp
9
10
90.00%
[833]

:large_blue_circle:
src/storage/lake/meta_file.cpp
3
3
100.00%
[]

:large_blue_circle:
src/storage/lake/rowset_update_state.cpp
10
10
100.00%
[]

:large_blue_circle:
src/storage/lake/update_manager.cpp
3
3
100.00%
[]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:heart_eyes: pass : 25 / 26 (96.15%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/storage/lake/tablet_manager.cpp
9
10
90.00%
[833]

:large_blue_circle:
src/storage/lake/meta_file.cpp
3
3
100.00%
[]

:large_blue_circle:
src/storage/lake/rowset_update_state.cpp
10
10
100.00%
[]

:large_blue_circle:
src/storage/lake/update_manager.cpp
3
3
100.00%
[]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:heart_eyes: pass : 25 / 26 (96.15%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/storage/lake/tablet_manager.cpp
9
10
90.00%
[833]

:large_blue_circle:
src/storage/lake/meta_file.cpp
3
3
100.00%
[]

:large_blue_circle:
src/storage/lake/rowset_update_state.cpp
10
10
100.00%
[]

:large_blue_circle:
src/storage/lake/update_manager.cpp
3
3
100.00%
[]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:heart_eyes: pass : 25 / 26 (96.15%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/storage/lake/tablet_manager.cpp
9
10
90.00%
[833]

:large_blue_circle:
src/storage/lake/meta_file.cpp
3
3
100.00%
[]

:large_blue_circle:
src/storage/lake/rowset_update_state.cpp
10
10
100.00%
[]

:large_blue_circle:
src/storage/lake/update_manager.cpp
3
3
100.00%
[]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:heart_eyes: pass : 18 / 18 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/storage/lake/meta_file.cpp
4
4
100.00%
[]

:large_blue_circle:
src/storage/lake/rowset_update_state.cpp
10
10
100.00%
[]

:large_blue_circle:
src/storage/lake/rowset_update_state.h
1
1
100.00%
[]

:large_blue_circle:
src/storage/lake/update_manager.cpp
3
3
100.00%
[]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:heart_eyes: pass : 20 / 20 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/storage/lake/meta_file.cpp
3
3
100.00%
[]

:large_blue_circle:
src/storage/lake/tablet_manager.cpp
4
4
100.00%
[]

:large_blue_circle:
src/storage/lake/rowset_update_state.cpp
10
10
100.00%
[]

:large_blue_circle:
src/storage/lake/update_manager.cpp
3
3
100.00%
[]

@Mergifyio backport branch-3.2

@Mergifyio backport branch-3.1


Workflow build.yaml is not run

Background

Workflow build.yaml do not run because [Error: .github#L1] every step must define a usesorrun key

Acceptance Criteria

Make this workflow run normally

Fixed in #509 + test in #514 @anhductn2001


modular

How about getting this fully modular to load only the components we require and not the full bulk, this would improve load times etc substancially

@g0shed, thank you for posting an issue! Have you tried importing only the components you want?
import { Button } from '@advanced-data-machines/tailwindcss-vue';
Vue.use(Button);

// or

// only array of components you want
import TailwindcssVue, { Button } from '@advanced-data-machines/tailwindcss-vue';
Vue.use(TailwindcssVue, { components: [Button] });

Docs are in the process.

still imports the whole thing, I tried that before...

How about the following?
import Button from '@advanced-data-machines/tailwindcss-vue/dist/components/button';
Vue.use(Button);

I had .22 loaded, now with .24 this has worked indeed, thank you for your help

No problem! The bundle has been enhanced between the .22 and .24 release.


Dynamic resources are supported only for writing

What kind an issue is this?

[ ] Bug report. If you’ve found a bug, please provide a code snippet or test to reproduce it below.
The easier it is to track down the bug, the faster it is solved.
[ ] Feature Request. Start by telling us what problem you’re trying to solve.
Often a solution already exists! Don’t send pull requests to implement new features without
first getting our support. Sometimes we leave features out on purpose to keep the project small.

Issue description
Dynamic resources are supported only for writing, for doing multi-index/type reads, use an appropriate search query.
What should I do to reda?
Steps to reproduce
Code:
                  CREATE
EXTERNAL TABLE `recommend_users`
(
    `uid`  BIGINT,
    `task_date`  STRING
)PARTITIONED BY (`day` string)
STORED BY 'org.elasticsearch.hadoop.hive.EsStorageHandler'
TBLPROPERTIES('es.resource' = 'recommend_users_{task_date}/recommend_users',
    'es.index.auto.create' = 'true',
    'es.nodes' = 'http://xxxxx',
    'es.port'='9200',
    'es.net.http.auth.user'='xxx',
    'es.net.http.auth.pass'='xxx'
)

Strack trace:
Failed with exception java.io.IOException:org.elasticsearch.hadoop.EsHadoopIllegalArgumentException: Cannot read indices that have curly brace field extraction patterns in them: recommend_users_{task_date}

Version Info
OS:         :
JVM         :
Hadoop/Spark:  3.2.1
ES-Hadoop   :  7.11.1
ES          :  5.5.1
Hive.      : 3.2.1

Feature description

Using dynamic resources is a little odd with integrations like Hive where the integration is expressed as a read/write data store. In most integrations we support, the index name is specified at the point where the read operation or write operation is defined.
We have two configurations that should help: es.resource.read and es.resource.write. In this case, instead of setting just es.resource you could try setting es.resource.write to be recommend_users_{task_date}/recommend_users and set es.resource.read to be recommend_users_*/recommend_users.


⚠ Bofrost.fr has degraded performance

In 3d09c8e, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1946 ms

Resolved: Bofrost.fr performance has improved in f1b02b9 after 22 minutes.


Implement GeoDA attack

Description
This pull requests adds the query-efficient Geometric Decision-based Attack (GeoDA) by Rahmati et al. (https://arxiv.org/abs/2003.06468).
Fixes #969
Type of change
Please check all relevant options.

[ ] Improvement (non-breaking)
[ ] Bug fix (non-breaking)
[x] New feature (non-breaking)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Codecov Report

Merging #1001 (d1e3a53) into dev_1.7.0 (3a95707) will decrease coverage by 0.58%.
The diff coverage is 15.34%.

@@              Coverage Diff              @@
##           dev_1.7.0    #1001      +/-   ##
=============================================
- Coverage      62.53%   61.94%   -0.59%
=============================================
  Files            220      221       +1
  Lines          19008    19248     +240
  Branches        3451     3508      +57
=============================================
+ Hits           11886    11924      +38
- Misses          5814     6011     +197
- Partials        1308     1313       +5

Impacted Files
Coverage Δ

...attacks/evasion/geometric_decision_based_attack.py
14.89% <14.89%> (ø)

art/attacks/evasion/__init__.py
100.00% <100.00%> (ø)

art/defences/detector/poison/activation_defence.py
84.28% <0.00%> (-0.34%)
:arrow_down:

art/attacks/poisoning/bullseye_polytope_attack.py
15.78% <0.00%> (+1.40%)
:arrow_up:

Codecov Report

Merging #1001 (9a5980b) into dev_1.7.0 (29a22be) will decrease coverage by 15.93%.
The diff coverage is 83.91%.

@@              Coverage Diff               @@
##           dev_1.7.0    #1001       +/-   ##
==============================================
- Coverage      41.81%   25.87%   -15.94%
==============================================
  Files            220      221        +1
  Lines          19116    19303      +187
  Branches        3493     3527       +34
==============================================
- Hits            7993     4995     -2998
- Misses         10196    13919     +3723
+ Partials         927      389      -538

Impacted Files
Coverage Δ

...attacks/evasion/geometric_decision_based_attack.py
83.83% <83.83%> (ø)

art/attacks/evasion/__init__.py
100.00% <100.00%> (ø)

art/metrics/privacy/membership_leakage.py
12.72% <0.00%> (-72.73%)
:arrow_down:

...defences/preprocessor/spatial_smoothing_pytorch.py
12.35% <0.00%> (-69.67%)
:arrow_down:

...defences/detector/poison/ground_truth_evaluator.py
17.80% <0.00%> (-68.50%)
:arrow_down:

...estimators/speech_recognition/tensorflow_lingvo.py
16.74% <0.00%> (-66.52%)
:arrow_down:

art/attacks/evasion/boundary.py
13.87% <0.00%> (-63.01%)
:arrow_down:

art/attacks/evasion/square_attack.py
10.47% <0.00%> (-62.86%)
:arrow_down:

...ences/preprocessor/spatial_smoothing_tensorflow.py
25.00% <0.00%> (-61.37%)
:arrow_down:

...cks/evasion/imperceptible_asr/imperceptible_asr.py
14.71% <0.00%> (-60.07%)
:arrow_down:

... and 69 more


Fix topology view tests

Flaky test unskipped, but I cant reproduce the failures after many retries...

Gonna re-run it 3 times here and if it's always green I'll approve.


第30题：模版函数想传递指针方式？

提示：

traits萃取器
c++11 新特性 通用引用
t rvalue references can be used to solve both these problems.

参考资料
https://github.com/FunctionDou/STL/blob/master/8 全特化和偏特化.md
https://github.com/FunctionDou/STL/blob/master/7 traits萃取剂.md

通过常量 和非常量 方式解决 右值问题不扩展性不好
这种方法有两个问题。 首先，如果工厂没有一个参数，而是多个参数，则必须为各种参数的非常量和常量引用的所有组合提供重载。 因此，该解决方案对于具有多个参数的函数的扩展性极差。
There are two problems with this approach. Firstly, if factory had not one, but several arguments, you would have to provide overloads for all combinations of non-const and const reference for the various arguments. Thus, the solution scales extremely poorly to functions with several arguments.
http://thbecker.net/articles/rvalue_references/section_08.html

https://isocpp.org/blog/2012/11/universal-references-in-c11-scott-meyers

https://stackoverflow.com/questions/3106110/what-is-move-semantics

Rvalue references
We now understand that moving from lvalues is potentially dangerous, but moving from rvalues is harmless. If C++ had language support to distinguish lvalue arguments from rvalue arguments, we could either completely forbid moving from lvalues, or at least make moving from lvalues explicit at call site, so that we no longer move by accident.


Double click bracket to select content

Move mouse to bracket, and Double Click to select content.

Should work for bracests/parentheses/curly bracests/single quote/double quote
This feature is inspired  by Eclipse. But I love VSCode mutch better.

see https://stackoverflow.com/questions/51884000/double-click-inside-brackets

Really hoping to get this one, all existing suggest is still very much annoying to use and not cover other kind of language. A lot IDE is having this though


Add basic setup instruction

It would be good to have some setup instruction like what is needed and how to run the project.

I'll prepare that.

PR: #315

Closing as this is merged. Thanks for your contribution!


fix clump selection

This was an issue with how WBT was handling the isolated filter ('clump') for cases where the flood extent > the nodata


Fix #2837 validation errors in qdrant.add_texts

To fix https://github.com/hwchase17/langchain/issues/2837
Update vectors generation of add_texts , keeping the same as from_texts which works fine:
vectors=[self.embedding_function(text) for text in texts],
to
vectors=self.embedding_function(texts)

ah, I got it, thanks !


question

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0e380713-8a99-fca5-7a98-4096bcab9c57
Version Independent ID: 088ac63e-886e-71f2-bc9b-36f25f93305a
Content: Create a new entry in a SharePoint list - Microsoft Graph beta
Content Source: api-reference/beta/api/listitem-create.md
Product: sharepoint
Technology: microsoft-graph
GitHub Login: @spgraph-docs-team
Microsoft Alias: MSGraphDocsVteam

how can I add a new row to hyperlinkorpicture column
I use URL and description
using graph Api and endpoint
but it keeps giving error
i have tried to change column formatting using patch but that doesn't work either

Hi,
Thanks for your feedback. Unfortunately this repo is for keeping track of issues or new contributions in the Microsoft Graph docs and not to provide help about how to use Microsoft Graph. You should rely on the Microsoft Graph support area (https://developer.microsoft.com/en-us/graph/support) for this kind of questions. I'm going to close this item. Thanks for your understanding.


Exposing QIF account types mapping

Hello,
In qif.py file __init__() function - the account_types is set hard-coded. Not having a way to customize it in the mapping is limiting because and also it is hard to use it since it is hidden.
I will gladly expose it thru the mapping. I think that the current value should be the default if the user did provide one in the mappings. Since the key account_type is already used to map the transaction field for debit/credit, it should be something else.
What do you think?
Eran.

Seems perfectly reasonable. Also, why not keep the same name? The words differ by an s.


Add Kurdish language to YukkiMusic

Hello,
i added kurdish lang for YukkiMusic

hello dear the lang code of "kurdish" language is "ku" so can you rename all files ckb to ku

In kurdish language have more dialect, I know but it's  central kurdish Dialect
miss rose used this code to kurdish language
.

oh ok


Account Created

"This password reset token is invalid."
Anyone know why every password reset token is instantly invalid?

The module doesn't handle the password resetting or anything user related other than telling the API to create it if needed.

But normally no problem. There is a problem with the accounts created from the module

The module doesn't create accounts in any way different from as it would have been through the panel itself. I have no control over password reset tokens.


Please make Stillcolor Sequoia compatible

Just installed Mac Sequoia and Stillcolor stopped working.
Guess you are on it already. If not, now you know :)
Kind regards, Audun

Hey @tunhovd - what is exactly the error you're seeing? Does the app not launch at all? Or does it run but menu options don't function?
I'm not sure I will install Sequoia anytime soon so I appreciate the additional context. I've read that Sequoia has a stricter Gatekeeper and permission system.

My apologies. I did not see the program running.
After I installed the latest MacOs I thought Stillcolor was not running, (freaked out), and wrote a message at your forum.
It’s all good. Please feel free to delete this thread.
Kind regards, Audun

No worries, thanks!


Add auth token support

Prevents Authorization Error when you attempt to connect to a gnatsd
server with an authorization token instead of user:pass.
Added test to auth spec

Fixes https://github.com/nats-io/pure-ruby-nats/issues/10

Thanks!


Cannot sync horizontalpodautoscalers.autoscaling

Describe the bug
I'm getting this error when trying to sync horizontalpodautoscalers.autoscaling:
E0817 14:43:12.562410   33147 workload_apiexport_controller.go:211] "kcp-workload-apiexport" controller failed to sync "root:my-workspace|kubernetes", err: apiresourceschemas.apis.kcp.dev "rev-552.horizontalpodautoscalers.autoscaling" is forbidden: [spec.group: Invalid value: "autoscaling": should be a domain with at least one dot]

This is strange because it works for deployments.apps and poddisruptionbudgets.policy.
To Reproduce
Steps to reproduce the behavior:
Create a syncer with --resources=horizontalpodautoscalers.autoscaling, apply it and observe error aforementioned.
Expected behavior
A clear and concise description of what you expected to happen.
No errors
Additional context
Add any other context about the problem here.

Need to add autoscaling to https://github.com/kcp-dev/kcp/blob/11138a2647f6bd4fb636746b6a1f093ffab988d1/pkg/admission/apiresourceschema/validation.go#L41
/help
/good-first-issue

/assign


Cannot access vue-cli using phone on local wifi network

Version
3.12.0
Reproduction link
https://github.com/Armour/vue-typescript-admin-template/tree/minimal
Environment info
System:
    OS: Windows 10
    CPU: (12) x64 Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz
  Binaries:
    Node: 10.15.3 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.12.3 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 6.4.1 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: 44.18362.387.0
  npmPackages:
    @tinymce/tinymce-vue:  3.0.1
    @vue/babel-helper-vue-jsx-merge-props:  1.0.0
    @vue/babel-plugin-transform-vue-jsx:  1.0.0
    @vue/babel-preset-app:  3.11.0
    @vue/babel-preset-jsx:  1.1.0
    @vue/babel-sugar-functional-vue:  1.0.0
    @vue/babel-sugar-inject-h:  1.0.0
    @vue/babel-sugar-v-model:  1.0.0
    @vue/babel-sugar-v-on:  1.1.0
    @vue/cli-overlay:  3.11.0
    @vue/cli-plugin-babel: ^3.11.0 => 3.11.0
    @vue/cli-plugin-e2e-cypress: ^3.11.0 => 3.11.0
    @vue/cli-plugin-eslint: ^3.11.0 => 3.11.0
    @vue/cli-plugin-pwa: ^3.11.0 => 3.11.0
    @vue/cli-plugin-typescript: ^3.11.0 => 3.11.0
    @vue/cli-plugin-unit-jest: ^3.11.0 => 3.11.0
    vue-class-component: ^7.1.0 => 7.1.0
    vue-cli-plugin-element: ^1.0.1 => 1.0.1
    vue-cli-plugin-style-resources-loader: ^0.1.3 => 0.1.3
    vue-count-to:  1.0.13
    vue-eslint-parser:  5.0.0 (2.0.3)
    vue-hot-reload-api:  2.3.3
    vue-i18n:  8.14.0
    vue-image-crop-upload:  2.5.0
    vue-jest:  3.0.4
    vue-loader:  15.7.1
    vue-property-decorator: ^8.2.2 => 8.2.2
    vue-router: ^3.1.2 => 3.1.2
    vue-splitpane:  1.0.4
    vue-style-loader:  4.1.2
    vue-svgicon: ^3.2.6 => 3.2.6
    vue-template-compiler: ^2.6.10 => 2.6.10
    vue-template-es2015-compiler:  1.9.1
    vue2-dropzone:  3.6.0
    vuedraggable:  2.23.0
    vuex: ^3.1.1 => 3.1.1
    vuex-class: ^0.3.2 => 0.3.2
    vuex-module-decorators: ^0.10.1 => 0.10.1
  npmGlobalPackages:
    @vue/cli: Not Found

Steps to reproduce
Open up port 8080 in Windows Firewall. Run yarn serve
You will be able to run fine on local machine
Try to connect to the provided IP address and port on your phone ie. http://<IP_ADDRESS>:8080
What is expected?
Should be able to see your vue website on your phone
What is actually happening?
Get denied. Wont show on phone

Have tried settings things in vue.config.js like this
devServer: {
host: '<IP_ADDRESS>',//your ip address
port: 8080,
...
}
but doesnt work.

I'm running into this exact issue.

Running vue-cli-service serve prints two URLs, both of which I can view from the computer I'm running it on

  App running at:
  - Local:   http://localhost:8081/
  - Network: http://<IP_ADDRESS>:8081/

Trying to view the "Network" URL will not load on any other devices on this same network - it will spin indefinitely and time out without making a connection.
I tried adding an exception for port 8081 in the Windows Firewall and even disabling the Firewall entirely, and it doesn't work
I have other local web servers running on other ports on this machine and I'm able to connect to them just fine
I've tried specifying devServer.public in vue.config.js as my <IP_ADDRESS>:8081, <IP_ADDRESS>, <IP_ADDRESS>:8081, <IP_ADDRESS> - no success
I've tried a number of combinations of settings under devServer, e.g. port, host, public, disableHostCheck,
I've tried this entire process with a number of different ports (8080, 8081, 48175, 53123, etc) with all the same results - works on this machine, but not from other devices

I'm running into this exact issue.

Running vue-cli-service serve prints two URLs, both of which I can view from the computer I'm running it on

  App running at:
  - Local:   http://localhost:8081/
  - Network: http://<IP_ADDRESS>:8081/

Trying to view the "Network" URL will not load on any other devices on this same network - it will spin indefinitely and time out without making a connection.
I tried adding an exception for port 8081 in the Windows Firewall and even disabling the Firewall entirely, and it doesn't work
I have other local web servers running on other ports on this machine and I'm able to connect to them just fine
I've tried specifying devServer.public in vue.config.js as my <IP_ADDRESS>:8081, <IP_ADDRESS>, <IP_ADDRESS>:8081, <IP_ADDRESS> - no success
I've tried a number of combinations of settings under devServer, e.g. port, host, public, disableHostCheck,
I've tried this entire process with a number of different ports (8080, 8081, 48175, 53123, etc) with all the same results - works on this machine, but not from other devices

I'm running into this exact issue.
* Running `vue-cli-service serve` prints two URLs, both of which I can view from the computer I'm running it on

  App running at:
  - Local:   http://localhost:8081/
  - Network: http://<IP_ADDRESS>:8081/

* Trying to view the "Network" URL will not load on any other devices on this same network - it will spin indefinitely and time out without making a connection.

* I tried adding an exception for port 8081 in the Windows Firewall and even disabling the Firewall entirely, and it doesn't work

* I have other local web servers running on other ports on this machine and I'm able to connect to them just fine

* I've tried specifying `devServer.public` in `vue.config.js` as `<IP_ADDRESS>:8081`, `<IP_ADDRESS>`, `<IP_ADDRESS>:8081`, `<IP_ADDRESS>`

* I've tried a number of combinations of settings under devServer, e.g. `port`, `host`, `public`, `disableHostCheck`,

* I've tried this entire process with a number of different ports (8080, 8081, 48175, 53123, etc) with all the same results - works on this machine, but not from other devices

I found a workaround:
Run a command prompt as administrator and run this command: netsh interface portproxy add v4tov4 listenport=8082 connectaddress=<IP_ADDRESS> connectport=8081
That will let you connect to :8082 to view what is locally visible on 8081 (after you add 8082 to allowed inbound connections in Windows Firewall). I'm still not clear on why this is necessary - and it also only seemed to work if I ran the command while the web server was already running, though that might have been a coincidence..

That worked for me as well. Thank you.


notify / opt out when added to a starter pack or list

Describe the Feature
Starter packs and lists should have the option to opt out - either to never be added to them or to be only added by accounts you follow, or to opt out of individual packs you have been added to - and users should be notified every time when they're added to a list or pack. This is especially important as people are making negative / prejudiced / hate-based starter packs like 'people to block' or 'accounts not to follow' which isn't safe or inclusive.
Attachments
No response
Describe Alternatives
No response
Additional Context
This is especially important as people are making negative / prejudiced / hate-based starter packs like 'people to block' or 'accounts not to follow' which isn't safe or inclusive.

related to #5066 and #5493

I agree that a user should be able to prevent being added to a starter pack. I don't think opt-in makes sense here since it's probably going to make starter packs basically useless if only people who familiarize themselves with what a starter pack is can be on one, but an opt-out to prevent being added to a starter pack, or a "ask me for permission every time I'm added to a starter pack" is probably a good idea.
As for opt-out or permission to be added to a list - not a good idea. One huge advantage BlueSky has over X is that if there's a certain group of people you don't want to hear about, you can add a list of people to your block or mute list. If I don't want to hear about Trump, I can mute a list of people who constantly post about Trump. If I don't want to hear about Biden I can mute a list of people who constantly post about Biden. And so on. The whole point of custom labelers and custom moderation lists is for people to be able to customize their experience to not include content they don't want to see in their feed.
It would just be like Twitter where Elon Musk decided that you can no longer block his account and have to see his posts in your feed even if you don't want to ...


New functions: accept/ignored message requests

Can you explain what a request is?  As in what is the value we are passing to this function?  It doesn't seem like there's a way to get this within the api, is there?  Do we need to add a "message_request" event?
Can we merge these two functions together under a name like "handleMessageRequest(accept)" that takes true when you want to accept and false for ignore?
This is awesome otherwise, though ideally we would have some docs as well.

@Schmavery When some man trying to contact you and its not a friend of your friend or you are not in same group, message is sent to "Others" thread, where you can "accept" or "ignore" a request to chat, when you accept, the message and whole thread is moved into normal group, else its ignored (of course)

I'm sorry, I should have been clearer.  I mean in the context of the API.  I understand what a message request is, but I don't understand what value we're passing into these functions.

@abdawoud ping...

Hey @abdawoud maybe you should collaborate with @how2945ard since he's working on https://github.com/Schmavery/facebook-chat-api/pull/247

I think this functionality is merged now.  Thanks a lot for your investigation of this feature @abdawoud !


[FRG] - Make positioning more intuitive

I wanted to create a simple two-column layout.
Expectation
I add two "Print label" elements. Position one on the left-side. Position the second one near the middle.

It created both with a "Add Y" value of 40.
Result
The Add Y ends up causing the actual Y value to grow, and not be the same for both. It ends up being Element1Y + Element1Height + Element2AddY.

Ideally the visual editor would more accurately represent the end result, but I understand the challenges of that, especially with the dynamic nature of reports. I would imagine a system where the AddY is actually a relative Y value from the top of the report section, not just based on the previous element. You'd probably need both an AddY and a SectionOffsetY or something like that though, because the AddY property is useful in other instances.

I have been thinking about this more. In a comment on another issue, I provided a sample report. Attached is the way that report looks in the editor.

Because of the nature of the editor and the positioning, everything ends up stacked on top of each other, which makes creating and editing the reports difficult.
Do you have any ideas on how to make editing the reports easier? Or are we using the tool incorrectly?

If you get to a point where you're working on this, I'm starting to get a decent collection of reports written in the new FRG style. If you end up wanting additional examples, feel free to shoot me an email and I can get you some sample data and JSON structure objects.

I've just gotten to the point where I was able to test the new positioning system, using absoluteX/absoluteY.
Wow! It's so much easier to use. Thank you!

Yeah, it makes it night and day difference.


Issue #147

Solves #147.

Thanks! At a glance this looks good. Will have to check it out a little more locally, but should be able to merge quite quickly.

I labeled this as a breaking change, but it's a very mild breaking change. We might still want to push it back to next "major version", i.e. 0.5. We might also want to release 0.5 very soon, and push back the name change to 0.6.


enhancement: check and fetch discovery data at login

Coverage: 91.317% (+0.03%) from 91.289% when pulling 9075a6b5406373e004ce2fc2d1fccc8ed2894c9f on embbnux:feat/checkDiscovery into 25223f1b52f4e1ae98e2c2f8633a972ddf1c07b4 on ringcentral:master.


FIX: readLinearizedTempC() return NAN upon error instead of 0

Use nan as error sentinel instead of 0 since 0 is a valid temperature.
Users with custom error-detection code could possibly be impacted...

I need this fix too! Manually applying it in my code base while the pull request lays ignored.

I added a .zip under the open issue "readLinearizedTempC() correction" fixing this and a issue with cold junction calculations... since adafruit is not maintaining this anymore.

hiya this library is being deprecated, and replaced with our shiny new circuitpython library, which has this function ported over
we are archiving this repo
please check out https://github.com/adafruit/Adafruit_CircuitPython_MAX31855/blob/master/adafruit_max31855.py#L95
and if it is still amiss please open an issue in that repo!


[Rust] Update README to link to Rust library

Also removes an out-of-date comment in the Rust README.

+1. I had just updated the README.md so all good now


Update finagle and scalacheck

Finagle 6.33 and Scalacheck 1.13 are here.

Hey, I just published catbird 0.2 against Finagle 6.31 this morning! :smile:
The new ScalaCheck isn't likely to work against the current ScalaTest (see this issue).

Thanks Travis! I'm going to keep Scalacheck on 1.12.5 then.

Current coverage is 86.25%

Merging #522 into master will increase coverage by +0.42% as of e3397c8

Powered by Codecov. Updated on successful CI builds.


500 Error Exporting to PDF

Today I started receiving an HTTP 500 error when attempting to export one of my files to PDF. No additional error messaging is included in the response body, just a generic internal server error response.

Should be fixed now. Sorry for the trouble.


make smol a bit bigger

The fading header still operates fine with this larger logo on Chrome, Safari, and Firefox


Moderation

Commands to implement

kick
ban
unban
warn
remove-infraction (might need a reword of the name)
infractions

Have these actions be logged in the log channel also

For remove infraction, I'd consider the name "infraction delete", as with the infraction as the command name, delete as the parameter.
Other commands considerable:

infraction search (searches for infractions of a user? or if the infraction matches a reason of some sort)
infraction archive (gets all the infractions of the entire guild, stored as a CSV file)

Infraction should be made a command group yeah


[NuGet.Server.V2] NuGetPrivateODataController: Push/Delete not work

Does anyone try to run the sample in the NuGet.Server.V2 repository?
When I enabled the authentication for uploading and deleting packages here:
https://github.com/NuGet/NuGet.Server/blob/master/samples/NuGet.Server.V2.Samples.OwinHost/Controllers/NuGetPrivateODataController.cs#L18-L19
The HTTP stack return always HTTP 406 here:
https://github.com/NuGet/NuGet.Server/blob/master/samples/NuGet.Server.V2.Samples.OwinHost/BasicAuthentication.cs#L39
And then the user will never be prompted for username and password.
I don't see the trees in the forest...
Please, can anyone help me!?

@DoCode , apologies for the slow response.
Have you been able to resolve the issue?

@skofman1 hehe. One month later... 😉
But yes. I resolved this issue. But currently I can not remember what the solution was. 😅 It's 2:45am in Germany and I should sleep now... I look tomorrow and come back here, ok?

@DoCode , apologies again 😃
It will be great if you share your solution for everyone who will get into the same situation in the future!

Hi Ppl!
im facing the same problem here.. at least i think. Did you solved or know what to do?

Hi @scherenhaenden, yes I fixed this, but currently, I have NO time to look what the issue in the sample was...
I am completely overcommitted...

I had the 406 error as well, but I wasn't working with security at the time. After a lot of research I discovered that having a # in any file within your package will cause the zip operation to fail and result in a 406 response. I had font files with # in their name. I had to remove them from my package but then it worked. I hope this helps.

Faced with the same issue. Push/delete operation returns 406 in case you're not authorized.


[PA-1010] [PA-1110] Add Deeper Backup Validation to test cases

What this PR does

It adds the functionality of validation of backups to all testcases that do some kind of backup.
nightly test cases are run and verified; others not
refactoring some test cases to reduce context switching which is triggered due to the requirement of Validation of backup to be done while context is the cluster on which the cluster to be backed up is present.
fix LicensingCountWithNodeLabelledBeforeClusterAddition torpedo log test name
note that validation is not called by any testcase directly, instead new functions are introduced which indirectly call validation, like CreateBackupWithValidation,CreateBackupWithCustomResourceTypeWithValidation,CreateScheduleBackupWithValidation,backupSuccessCheckWithValidation,CreateBackupWithNamespaceLabelWithValidation
refactor CreateBackupWithoutCheck to have CreateBackupByNamespacesWithoutCheck, and GetNextScheduleBackupName to have GetNextCompletedScheduleBackupName and GetNextCompletedScheduleBackupNameWithValidation

Which issue(s) this PR fixes
Closes #PA-1010, #PA-1110
Special notes for your reviewer
Tests using ValidateBackup

Some were added in previous PR

[x] RestoreEncryptedAndNonEncryptedBackups (https://aetos.pwx.purestorage.com/resultSet/testSetID/181219/testCaseID/935525)
[x] ViewOnlyFullBackupRestoreIncrementalBackup (https://aetos.pwx.purestorage.com/resultSet/testSetID/180969/testCaseID/934101)
[x] NamespaceLabelledBackupSharedWithDifferentAccessMode (https://aetos.pwx.purestorage.com/resultSet/testSetID/181014/testCaseID/934325)
[x] IssueMultipleRestoresWithNamespaceAndStorageClassMapping (https://aetos.pwx.purestorage.com/resultSet/testSetID/180993/testCaseID/934203)
[x] ShareBackupAndEdit (https://aetos.pwx.purestorage.com/resultSet/testSetID/181091/testCaseID/934772)
[x] ReplicaChangeWhileRestore (https://aetos.pwx.purestorage.com/resultSet/testSetID/181091/testCaseID/935070)
[x] MultipleCustomRestoreSameTimeDiffStorageClassMapping (https://aetos.pwx.purestorage.com/resultSet/testSetID/181091/testCaseID/934868)
[x] ShareBackupWithDifferentRoleUsers (https://aetos.pwx.purestorage.com/resultSet/testSetID/181091/testCaseID/934926)
[x] ResizeVolumeOnScheduleBackup (https://aetos.pwx.purestorage.com/resultSet/testSetID/181477/testCaseID/937030)
[x] BackupSyncBasicTest (https://aetos.pwx.purestorage.com/resultSet/testSetID/181292/testCaseID/936077)
[x] CustomResourceRestore (https://aetos.pwx.purestorage.com/resultSet/testSetID/181240/testCaseID/935741)
[x] SwapShareBackup (it is failing on my cluster even without the changes, so untested. But it is succeeding in nightly, so my code should also be fine, ig)
[x] DeleteIncrementalBackupsAndRecreateNew (https://aetos.pwx.purestorage.com/resultSet/testSetID/181444/testCaseID/936793)
[x] ShareBackupsAndClusterWithUser (https://aetos.pwx.purestorage.com/resultSet/testSetID/181240/testCaseID/935771)
[x] ShareBackupWithUsersAndGroups (https://aetos.pwx.purestorage.com/resultSet/testSetID/181292/testCaseID/935900)
[x] ShareAndRemoveBackupLocation (https://aetos.pwx.purestorage.com/resultSet/testSetID/181292/testCaseID/935981)
[x] ClusterBackupShareToggle (https://aetos.pwx.purestorage.com/resultSet/testSetID/181411/testCaseID/936570)
[x] ScheduleBackupCreationAllNS (https://aetos.pwx.purestorage.com/resultSet/testSetID/181456/testCaseID/936893)
[x] DuplicateSharedBackup (https://aetos.pwx.purestorage.com/resultSet/testSetID/181292/testCaseID/936397)
[x] BackupLocationWithEncryptionKey (https://aetos.pwx.purestorage.com/resultSet/testSetID/181219/testCaseID/935483)
[x] RestartBackupPodDuringBackupSharing (https://aetos.pwx.purestorage.com/resultSet/testSetID/182091/testCaseID/940717)
[x] ScaleDownPxBackupPodWhileBackupAndRestoreIsInProgress (https://aetos.pwx.purestorage.com/resultSet/testSetID/182224/testCaseID/941332)
[x] ScaleMongoDBWhileBackupAndRestore (https://aetos.pwx.purestorage.com/resultSet/testSetID/182143/testCaseID/940860)
[x] MultipleInPlaceRestoreSameTime (https://aetos.pwx.purestorage.com/resultSet/testSetID/182250/testCaseID/941883)
[x] ScheduleBackupCreationSingleNS (https://aetos.pwx.purestorage.com/resultSet/testSetID/182091/testCaseID/940620)
[x] CancelAllRunningRestoreJobs (https://aetos.pwx.purestorage.com/resultSet/testSetID/182250/testCaseID/941589)
[x] ResizeOnRestoredVolume (https://aetos.pwx.purestorage.com/resultSet/testSetID/181184/testCaseID/935297)
[x] RebootNodesWhenBackupsAreInProgress (https://aetos.pwx.purestorage.com/resultSet/testSetID/182403/testCaseID/942159)
[x] BackupMultipleNsWithSameLabel (https://aetos.pwx.purestorage.com/resultSet/testSetID/182250/testCaseID/941615)
[x] SharedBackupDelete (https://aetos.pwx.purestorage.com/resultSet/testSetID/182250/testCaseID/941526)
[x] DeleteSharedBackup (https://aetos.pwx.purestorage.com/resultSet/testSetID/182250/testCaseID/941431)
[x] KillStorkWithBackupsAndRestoresInProgress (https://aetos.pwx.purestorage.com/resultSet/testSetID/182180/testCaseID/941011)
[x] DifferentAccessSameUser (https://aetos.pwx.purestorage.com/resultSet/testSetID/182250/testCaseID/941860)
[x] DeleteAllBackupObjects (https://aetos.pwx.purestorage.com/resultSet/testSetID/179931/testCaseID/927641)
[x] BasicSelectiveRestore (https://aetos.pwx.purestorage.com/resultSet/testSetID/179931/testCaseID/927538)
[x] CustomResourceBackupAndRestore (https://aetos.pwx.purestorage.com/resultSet/testSetID/179931/testCaseID/927509)
[x] AllNSBackupWithIncludeNewNSOption (https://aetos.pwx.purestorage.com/resultSet/testSetID/186338/testCaseID/963931)
[x] CloudSnapsSafeWhenBackupLocationDeleteTest (https://aetos.pwx.purestorage.com/resultSet/testSetID/186287/testCaseID/963638)
[x] IssueDeleteOfIncrementalBackupsAndRestore (https://aetos.pwx.purestorage.com/resultSet/testSetID/186078/testCaseID/962662)
[x] DeleteBucketVerifyCloudBackupMissing (https://aetos.pwx.purestorage.com/resultSet/testSetID/186111/testCaseID/962876)
[x] LicensingCountWithNodeLabelledBeforeClusterAddition (it is failing on my cluster, so untested. But it is succeeding in nightly, so my code should also be fine, ig)
[x] CancelClusterBackupShare (https://aetos.pwx.purestorage.com/resultSet/testSetID/186055/testCaseID/962583)

The combined tests will be run soon

Not in nightly:

[x] BackupRestartPX (not tested)
[ ] BackupCRsThenMultipleRestoresOnHigherK8sVersion (skipping as this uses CRDs, etc.)
[x] BackupAlternatingBetweenLockedAndUnlockedBuckets (not tested)
[x] LockedBucketResizeOnRestoredVolume (not tested)
[x] LockedBucketResizeVolumeOnScheduleBackup (not tested)
[x] StorkUpgradeWithBackup (not tested)
[x] ShareLargeNumberOfBackupsWithLargeNumberOfUsers (not tested)
[x] IssueMultipleDeletesForSharedBackup (not tested)
[x] AddMultipleNamespaceLabels (not tested)
[x] ManualAndScheduleBackupUsingNamespaceLabel (not tested)
[x] SetUnsetNSLabelDuringScheduleBackup (not tested)
[x] BackupRestoreOnDifferentK8sVersions (not tested)
[x] ScheduleBackupDeleteAndRecreateNS (not tested)

irrelevant (no backup validation required):

NodeCountForLicensing
DeleteUsersRole
CreateMultipleUsersAndGroups
CancelAllRunningBackupJobs
LicensingCountBeforeAndAfterBackupPodRestart
UpgradePxBackup
BackupClusterVerification
UserGroupManagement

tried SwapShareBackup, some issue:

https://aetos.pwx.purestorage.com/resultSet/testSetID/180207/testCaseID/930364 (nightly run "fail" due to not deleting location)
https://aetos.pwx.purestorage.com/resultSet/testSetID/181498/testCaseID/937152 (my run fail , also location issue - BUT, AFTER A LONG TIME, location deleted (like 10 min))
https://aetos.pwx.purestorage.com/resultSet/testSetID/181240/testCaseID/935613 (some other issue)
https://aetos.pwx.purestorage.com/resultSet/testSetID/181551/testCaseID/937391 (ran without changes, and still got error. which means, my code ismost likely fine)
https://aetos.pwx.purestorage.com/resultSet/testSetID/186216/testCaseID/963373

tried LicensingCountWithNodeLabelledBeforeClusterAddition, some issue:

https://aetos.pwx.purestorage.com/resultSet/testSetID/186216/testCaseID/963245

Please provide one full run with all the 47 test cases that we are currently running in the pipeline

@mkoppal-px  Nightly Vanilla test run: ✅
aetos: http://aetos.pwx.purestorage.com/resultSet/testSetID/188768
jenkins: https://jenkins.pwx.dev.purestorage.com/job/portworx-backup/job/system-tests/job/px-backup-system-test-vanilla/215/display/redirect

@kshithijiyer-px  You can verify that functionality is not being changed for context switches in two ways:

first trace the code by looking for where context switches have been added and removed, then you can determine context at any given point in code. Use this info to check if all functions which are context-dependent are still executing in the same context as before, which will logically prove that the code is still functioning the same.
The other method which has more implicit trust is the runtime execution check. Just take the logs for this run and compare with any nightly run, and you'll see that the context is the same wherever it matter.

I have done the same multiple times and everything works correctly.


Graph Try-It on MS Learn showing blank screen when activated.

Describe the bug
Graph Explorer is embedded in Microsoft Learn site as a feature via an iFrame next to the code block that users can easily open up and try out the graph explorer for learning purposes. This feature has been in place on MS Learn for a while and we were reported by the partner team that multiple users are facing the same issues with blank screen when activating the Try-It experience.
To Reproduce
Steps to reproduce the behavior:

Go to Quickstart: configure a restricted user experience with Assigned Access - Configure Windows | Microsoft Learn
Click on Try-It on the code block if the iFrame on the right side pane doesn't open automatically.
You'll see the blank screen on the right side pane, but you should really see the Graph Explorer experience embedded.
See error:

Expected behavior
User should be given a graph explorer environment opened within iFrame on the right side pane from the screenshot above, this experience is activated when user clicks on "Try-It" button from the code block.
Screenshots
attached above.
Desktop (please complete the following information):

OS: Windows
Browser Edge
Version 126.0.2592.61
Issue was reported in multiple environments with multiple users

Smartphone (please complete the following information):

Device: N/A
OS: N/A
Browser N/A
Version N/A

Additional context
Add any other context about the problem here.

Hi @musale is this something you could look into?

@thewahome will it take a while for this code to be in production? I can still reproduce the issue on this page:
https://learn.microsoft.com/en-us/mem/intune/fundamentals/remote-help-macos?tabs=graph%2Cintune#code-try-0
It loads successfully the first time and then if i close it and try again or reload the page it doesn't work.

No. Not too long. A new release is going out this week

@scottbreenmsft @jupajupajupa
These changes are live. This problem should be fixed now


GUSD vault shows incorrect APY and misleads users

#176 is not working unfortunately, can you review and resubmit?

Weird, it works for me:

Perhaps the CDN cache wasn't invalidated properly when you first checked? (Though the CI pipeline attempts to invalidate it)

Turns out if the yGUSD balance is greater than 0, then there is a visual issue:

THank you for catching that for me @milkyklim


Add .NET 8 as target framework

Closes #129
Feedback is appreciated.

Will update the projects in Consumers.sln soon.

Will update the projects in Consumers.sln soon.

The consumers don't need to multi-target so I'll be changing them shortly when I change them to use a locally built NuGet package (the same as what Vogen does). This basically means a build step is run to produce a NuGet package with a very high number 999.999.x.x and it's set to use 999.99.* I've had lots of issues of failing tests/examples because of wrong NuGet packages.


request help: cannot find conf token and receive undefined filter

Issue description
hi team, I met a problem, I developed a filter in runner-plugin/src/main/java/org/apache/apisix/plugin/runner/filter/, but the plugin wasn't effective, the error details are:

could you give me some ideas? thank you.
Environment

your apisix-java-plugin-runner version
0.2.0

it's resolved, because my code error, thanks very much.

it's resolved, because my code error, thanks very much.

I also faced this issue, what's your solution?


After Deleting the User, user's profile picture is not deleted in the server!

For Feature Requests
Desired Feature: none
For Bug Reports

BookStack Version (Found in settings, Please don't put 'latest'): 19
PHP Version: 7.2
MySQL Version: 5.7

Expected Behavior
Profile Picture needs to be deleted if the user is deleted.
Current Behavior
After Deleting the User, user's profile picture is not deleted on the server!

Hi @ssddanbrown
I'll work on this bug.
I'll do the following to fix this bug
After successful deletion of a User account

Delete profile pics from uploads folder
Delete user profile pic record from images table

Please let me know If you want to perform any other thing in this action.

Thanks a Lot!

@ssddanbrown - Submitted a merge request - https://github.com/BookStackApp/BookStack/pull/646/files
Please review it.