Add B3TextMapCodec to jaeger-core

As B3 context propagation is not Zipkin specific, it would be nice if B3TextMapCodec was included in jaeger-core.

it is not a requirement for Core, why do we want it there? If people need B3 they can include jaeger-zipkin.

But that also pulls in a large set of unneeded dependencies. If it was in core people can decide to use b3 propagation rather than the jaeger specific one which plays together more nicely with other non-jaeger-traced services.

if they other services are not jaeger-traced, they are not using jaeger-backend either, so wouldn't you need zipkin reporting as well?

if they other services are not jaeger-traced, they are not using jaeger-backend either, so wouldn't you need zipkin reporting as well?

Not if they use a different (maybe custom) backend but also use B3 for context propagation.
To add some background, I'm currently trying to make stagemonitor as independent from the underlying OT impl as possible. So that swapping out the implementation is as easy as possible. This however requires all implementations to use the same propagation format. B3 is the obvious choice here as it is used most widely.
Also, I need to be able to get ahold of the traceId, spanId and parantId in an impl independent way. This can also be achieved by injecting the B3 headers into a Map and getting the IDs via the well known B3 header names.

Well, I still don't like putting B3 into core. I think the cleanest solution is to build/release an extra jar in the jaeger-zipkin module, e.g. jaeger-zipkin-b3.
Let me check with the team if we have any pending work. I think we should be ready to release 0.18

Fwiw there most certainly are non zipkin B3 systems not just internal. For
example cloud foundry router uses B3 but does not report to zipkin at all.
It uses log scraping approach for PCF metrics which shares no code or
architecture with zipkin. Same thing for nike wingtips. There are other
zipkin clones that use B3 as well if need be I can list the non internal
ones. This is why we made the b3-propagation repo btw..
jaeger-b3 here is probably the right name. We have a repo b3-propagation so
if apis are stable we could publish adapter there too... like b3-jaeger ;)
On 10 Apr 2017 3:05 am, "Felix"<EMAIL_ADDRESS>wrote:

if they other services are not jaeger-traced, they are not using
jaeger-backend either, so wouldn't you need zipkin reporting as well?
Not if they use a different (maybe custom) backend but also use B3 for
context propagation.
To add some background, I'm currently trying to make stagemonitor as
independent from the underlying OT impl as possible. So that swapping out
the implementation is as easy as possible. This however requires all
implementations to use the same propagation format. B3 is the obvious
choice here as it is used most widely.
Also, I need to be able to get ahold of the traceId, spanId and parantId
in an impl independent way. This can also be achieved by injecting the B3
headers into a Map and getting the IDs via the well known B3 header names.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/uber/jaeger-client-java/issues/136#issuecomment-292805600,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD619S7Hb4lFAfoGohfRwhKkA5BS4kBks5ruSv1gaJpZM4M4EJq
.

The problem with publishing externally is that the trace context might
change here and then require coordinated updates. Also there havent been
others asking.. another option is to manually exclude the zipkin
dependencies as they arent likely used for inject extract iirc.
On 10 Apr 2017 8:35 am, "Adrian Cole"<EMAIL_ADDRESS>wrote:

Fwiw there most certainly are non zipkin B3 systems not just internal. For
example cloud foundry router uses B3 but does not report to zipkin at all.
It uses log scraping approach for PCF metrics which shares no code or
architecture with zipkin. Same thing for nike wingtips. There are other
zipkin clones that use B3 as well if need be I can list the non internal
ones. This is why we made the b3-propagation repo btw..
jaeger-b3 here is probably the right name. We have a repo b3-propagation
so if apis are stable we could publish adapter there too... like b3-jaeger
;)
On 10 Apr 2017 3:05 am, "Felix"<EMAIL_ADDRESS>wrote:

if they other services are not jaeger-traced, they are not using
jaeger-backend either, so wouldn't you need zipkin reporting as well?
Not if they use a different (maybe custom) backend but also use B3 for
context propagation.
To add some background, I'm currently trying to make stagemonitor as
independent from the underlying OT impl as possible. So that swapping out
the implementation is as easy as possible. This however requires all
implementations to use the same propagation format. B3 is the obvious
choice here as it is used most widely.
Also, I need to be able to get ahold of the traceId, spanId and parantId
in an impl independent way. This can also be achieved by injecting the B3
headers into a Map and getting the IDs via the well known B3 header
names.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/uber/jaeger-client-java/issues/136#issuecomment-292805600,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD619S7Hb4lFAfoGohfRwhKkA5BS4kBks5ruSv1gaJpZM4M4EJq
.

zipkin.internal.Util is used

zipkin.internal.Util is used

I could patch to make that go away.. would that be worthwhile? Ex brave has
HexCodec for this and it would be 86 lines of rarely ever change code
copy/pasted (with tests)

or.. we could shade that class from zipkin

Do you mean shading manually (aka copy pasta) or is it possible to shade just one class with the gradle shade plugin?

Do you mean shading manually (aka copy pasta) or is it possible to shade
just one class with the gradle shade plugin?

not sure what gradle supports, but I've done cherry-pick shading in the
past with maven:
https://github.com/openzipkin/zipkin/blob/master/zipkin/pom.xml#L100
either way, though. it isn't much code and the code in question (hex codec)
is quite stable.

In the mean time I shaded the B3 class into stagemonitor. It feels like a work around and I'd prefer the B3 class to be in jaeger-core or jaeger-b3 but I'd be ok with it.
@yurishkuro how would you like to proceed?

Can you do a pr to build an extra jaeger-b3 jar in the jaeger-zipkin module? Or move to a separate module if that's easier.
I think one format we'd want to support in core will be github.com/tracecontext

https://github.com/uber/jaeger-client-java/pull/141


linuxbrew does not support services

Please note that we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you repeatedly fail to use the issue template, we will block you from ever submitting issues to Homebrew again.

[x] are reporting a bug others will be able to reproduce and not asking a question. If you're not sure or want to ask a question do so on our Discourse: https://discourse.brew.sh
[x] ran a brew command and reproduced the problem with multiple formulae? If it's a problem with a single, official formula (not cask) please file this issue at Homebrew/homebrew-core: https://github.com/Homebrew/homebrew-core/issues/new/choose. If it's a brew cask problem please file this issue at https://github.com/Homebrew/homebrew-cask/issues/new/choose. If it's a tap (e.g. Homebrew/homebrew-php) problem please file this issue at the tap.
[x] ran brew update and can still reproduce the problem?
[x] ran brew doctor, fixed all issues and can still reproduce the problem?
[x] ran brew config and brew doctor and included their output with your issue?

What you were trying to do (and why)
Linuxbrew currently does not support brew services.  This was confirmed on Twitter.
What happened (include command output)
There is no note in the install about the service (or how to manually start the program) at the end of install like there is in macOS (my service):
morgo@ryzen:/tmp$ brew install tidb-server.rb
==> Cloning https://github.com/pingcap/tidb.git
Updating /home/morgo/.cache/Homebrew/tidb-server--git
==> Checking out tag v2.1.5
HEAD is now at 4dc3093 CHANGELOG: add changelog for v2.1.5 (#9501)
HEAD is now at 4dc3093 CHANGELOG: add changelog for v2.1.5 (#9501)
==> make server
==> Caveats
This install of TiDB uses goleveldb as the storage engine instead of TiKV,
and is slower than a production install. Any benchmarks will be unreliable.

tidb-server does not bundle any clients. To use the MySQL client:
brew install mysql-client
mysql -h <IP_ADDRESS> -P4000 -uroot
==> Summary
🍺  /home/linuxbrew/.linuxbrew/Cellar/tidb-server/2.1.5: 7 files, 43.8MB, built in 37 seconds

Also trying to list or start services produces errors:
morgo@ryzen:/tmp$ brew services start tidb-server
sh: 1: list: not found
sh: 1: list: not found
Error: Failure while executing; `'' load -w /home/morgo/Library/LaunchAgents/homebrew.mxcl.tidb-server.plist` exited with 1.

morgo@ryzen:~$ brew services list
sh: 1: list: not found
sh: 1: list: not found
Name        Status  User  Plist
mysql       stopped
tidb-server started morgo /home/morgo/Library/LaunchAgents/homebrew.mxcl.tidb-server.plist

What you expected to happen
If services is not yet supported, I think it is fine to print a warning if a plist is defined.  The plist_options :manual  should be printed regardless though.
Step-by-step reproduction instructions (by running brew commands)
Try with any Formula that uses a plist:
brew install mysql
brew services start mysql

Linuxbrew cannot support plist services as-is as they are specific to macOS's launchctl.

Yep, @morgo has suggested printing an error message to this effect.

Here's the link to the brew services command: https://github.com/Homebrew/homebrew-services/blob/c7e22c9a4f6eae437884c53c3c6cfd760208e0b0/cmd/brew-services.rb#L91
You can print an error message with…
odie "brew services is supported only on macOS" unless OS.mac?

Thank you, I will take a look.

Here's the function that prints the services information with brew info:
https://github.com/Homebrew/brew/blob/01bd14be616904f6ebbb8e01492dea54740942f1/Library/Homebrew/extend/os/mac/caveats.rb#L4
Copy the plist_manual code
https://github.com/Homebrew/brew/blob/01bd14be616904f6ebbb8e01492dea54740942f1/Library/Homebrew/extend/os/mac/caveats.rb#L34-L37
from there to
https://github.com/Homebrew/brew/blob/01bd14be616904f6ebbb8e01492dea54740942f1/Library/Homebrew/caveats.rb#L139


feat: add upvote function

The code is really messy ATM
&
I encountered some issues while attempting to do this
Issues:

page required to refresh to get the latest change. (each time you upvote/remove upvote the item, the page is refreshed)
upvote change is not synchronized.

Any suggestions on how to improve this are really welcome and appreciated.

Touching grass 🌳
Would come back to continue this afterward 👾

The CI error appears to be unrelated to this change.
Also, can you please change the name of VoteBtn to VoteButton to align it with other component names?

@huai-jie, I've made a few improvements. PTAL and test. WDYT?

LGTM!

Thank you for all your work, @huai-jie!


auth: update default config and website docs

Missed some docs and default config for #505

Also you should update the default-config.yaml file.


Slow reaction from C/C++ microsoft extension in vscode, Macos M1

Describe the bug
Dear orb developers:
Hope everything fine for you. It has been quite a while from last update in orb, that C/C++ extension (microsoft.com) in vscode seems to be very slow, which lags and even stops responding editing C code files. However, it's an intermittent status (extension works fine for few minutes but then, breaks for few minutes) that really bothering coding.
The issue appears about 2 weeks ago. I have tried reinstalling the extension or rebooting orbstack, seems not work.
Also I don't find similar questions in others' issues, thus I don't know if it is an occasional situation for my device or something.
Maybe I will try Clangd extension instead temporarily. Thanks a lot for your help.
To Reproduce
use vscode to ssh orb, and then edit the C files using C/C++ extension
Expected behavior
No response
Diagnostic report (REQUIRED)
OrbStack info:
Version: 1.4.3
Commit: 75d38a2c2d9a2b42d64378a8f50f31d4d566df10 (v1.4.3)
System info:
macOS: 14.3.1 (23D60)
CPU: arm64, 8 cores
CPU model: Apple M1
Model: MacBookAir10,1
Memory: 8 GiB
Diagnostic report failed: get presigned url: Post "https://api-license.orbstack.dev/api/v1/debug/diag_reports": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

---------------- [ cut here ] ----------------
Screenshots and additional context (optional)
No response

I have also encountered similar issues. I cannot even get the C/C++ extension installed. 😭

I have also encountered similar issues. I cannot even get the C/C++ extension installed. 😭

I have somehow solved this problem, hope this also works fine for you.
According to what I know, this is due to the vscode extension of C/C++ while sshing remote server. The Intellisense server will get down for no reason sometime. I think the extension developers have not fixed it offically.

orb should at lease give 2 GB memory for the vm cause the extension needs enough space to work (from my mac, 1GB will stop the Intellisense service.)
you can try to switch the mode of using Rosetta in orb set, this can work, probably.

And if you constantly occur the issue, the best way now to solve is to disable intellisense service of C/C++ extension and substitute it with "Clangd" extension. However, from my experience, Clangd extension is not good as C/C++ extension...😮💨

Low performance due to running out of memory doesn't sound like an OrbStack issue.


Tooltip data is disappearing

The first time you mouseover a mob, the tooltip correctly displays relevant quest requirements.
If you move your mouse away then back onto the mob, only the default tooltip displays.
It seems that mousing over a Unit Frame will reset this behaviour.
Tested with no other addons running and issue persists.
See these two screenshots taken immediately after one another.

Yeah I noticed that bug also while testing it myself. I know that letting the tooltip completely disappear and then mousing over again fixes the behavior, but I don't know why I have to let it disappear. Hovering over the nameplate probably just generates a fresh tooltip object within the game.

Fixed


How to Communicate with device

So I am a little lost. I now have two Minis set up. One that I loaded the ESPHome version into and that is working very well with HA.
I just loaded this repo into a second one. It looks like it is working correctly as the server code sees the board when it is powered up. I also see the devices from HA.
But I do not know how to actually use it? Is there a wake word?

Solved.


Add synthetic monitoring for atlantis

atlantis plan

Locks and plans deleted for the projects and workspaces modified in this pull request:

dir: environments/demo workspace: grafana-cloud-objects-demo-ws-01


unexpected program termination

Observation from @elcojacobs in #521:

Another issue I noticed:
Why do the commented lines result in an overflow exception?
https://godbolt.org/z/fv5NKk
Same program with fsanitize doesn't even work:
https://godbolt.org/z/MtmYsW

Like cause is a failing CNL_ASSERT in a to_chars support function.

@elcojacobs have you tried debugging this program to see if std::terminate or std::abort are being called? I think those functions are likely to cause a return value of 255 in CE.

On closer inspection there appears to be a divide-by-zero error here:
auto d = a/b;


866 readonly user

The idea here is to add a read only user.
To test, create users and then modify one of the users in MongoDB to have 'read_only_user' == true.
The idea is that if a user is read only, that will limit them to only being a Viewer.
Intended behavior for groups (not implemented) - if a read only user is added to a group, that user will only be a Viewer for datasets  regardless of group level permission.
Problem right now. After trying to share with a user, I want to go through the datasetRoles and see if the new user was successfully added. I think there is something wrong with my hook because after I add the user, even when I call getRoles(datasetId), the new user is not added but it is being returned by the back end endpoint.

This is draft, but I am having a problem with the MangeUsers component.
Toggling the switch for read only user does change the value of the boolean for the user, but this change is not reflected unless you refresh the page.

I am marking this pull request ready for review.
How the read only user works, at least for now.
A user can be made a read only user by an admin in the "Manage Users"  component. A read only user can only have Viewer permissions for any dataset in the instance. Trying to add a read only user as other roles will throw an error.
For groups. A read only user can be added to a group, but no matter what role the group is assigned, that user will still only be a Viewer. So if the group has Editor access, the read only user in the group will only be a Viewer.
This seemed like the least confusing way for users to share data with a read only user. They might share data with a particular group, and can just add the read only user. This seemed to be less complicated than having to create another group or share each dataset individually.
A read only user can also not be made an admin. This seemed to make sense since if the user was admin, they would have all permissions.

I see several unresolved modules errors.

@ddey2 do you still have module errors?

Regarding the use cases, I have a query - I can set a user as read_only_user who is an admin. Should we actually do that? Won't admin means that the user should have all access? On turning off admin, I can't make the user as admin again, as it is a read_only_user. This makes sense, I guess. So, in 1st scenario too, I think we won't let that.

I changed this and now you cannot make an admin a read only user. It will be disabled there.

I see several unresolved modules errors.

@ddey2 do you still have module errors?

those errors are fixed now.

@tcnichol However, I see that I can't turn off the 'Read only' toggle switch even for non-admin users. In the below ss, clicking on read-only switch doesn't work.

let me check this out.

For now,
I removed 'groups' and 'new dataset' from the left drawer for the read only user.
I also allowed the read only user to view metadata definitions but not create or delete.
Will need to check other API routes to make sure read only user cannot create using the API.

Once I turned on read only, i cannot turn it off. Seems like a frontend problem because I see no interaction with backend.

Once I turned on read-only first, then turn on admin; read-only seems to be frozen.

The first has been solved. Not sure if the "Once I turned on read-only first, then turn on admin; read-only seems to be frozen." is by design.


When I log in to GitHub account, it shows that I can't access this website

I can't log in to Microsoft account or GitHub account to display vscode Dev blocked connection。
1.I changed vscode permissions to administrator，but failed
2.I can log in to GitHub normally
3.I tried other networks. I can't log in

I look forward to your reply as soon as possible

Maybe https://github.com/microsoft/vscode/issues/150149#issuecomment-1134288797

++ 我也登陆不上去了，我还以为系统出问题了
嗯… 无法访问此页面
vscode.dev 已拒绝连接。
请尝试：
•检查连接
•检查代理和防火墙
ERR_CONNECTION_REFUSED
详细信息

I look forward to your reply as soon as possible

i have the same problam

I look forward to your reply as soon as possible

应该是被墙了，真是操蛋

i have the same problam

the true is  Vscode in China has same problem。I tried many ways ，but it still shows that he rejects the link request

i resolve this problem. edit hosts file (/etc/hosts)，add line
<IP_ADDRESS> vscode.dev

thanks！
however  My web page shows that the login is successful But vscode didn't log in successfully

So it appears that vscode.dev is blocked in China? Does the same apply to github.dev? Can someone check for me (go to github.dev/microsoft/vscode)?

我按照你的设置了还是不行呀

It can access and login normally in China mainland,i've tried

So it appears that vscode.dev is blocked in China? Does the same apply to github.dev? Can someone check for me (go to github.dev/microsoft/vscode)?

It can access and login normally in China mainland,i've tried

/duplicate https://github.com/microsoft/vscode/issues/149538
I'm going to mark this as a duplicate in favor of https://github.com/microsoft/vscode/issues/149538 just so I have one issue to track this. I will look into working around the blocking of vscode.dev next month. Sorry all, I wish China didn't block vscode.dev... but I don't have any say in the matter, I suppose.

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Fix "No recent conversations" not showing up

The first commit just centers the "No recent conversations" text and makes it smaller to be consistent with the rest of the app.
The second commit attempts to solve #2521 by making "No recent conversations" show when there is <=1 conversations instead of 0 conversations since a conversation with welcome-bot (which shouldn't be there) is always returned.

Closing this, as it is not the correct logic.


Option for excluding columns from cell edits total

N.B: Excluding columns from the schema is probably a bad hack which has unintentional consequences that I am unaware of.

closing due to no activity


Table Fragmentation?

Are there any plans to support table fragmentation?

No plans for fragmentation support yet. But it should be straightforward with the existing Erlang API.

So just call the Erlang Mnesia API directly.  Fair enough.  For what it is worth, I would love to see support for fragmentation in Memento.


Page on CL extension in docs

Installation
Content assist
Command runner

@worksofliam
I'll have a look at this and see if I can come up with something. Give me a hint on what "command runner" refers to.

@SJLennon You can open a CL source and press Control/Command+R like you can with SQL.

Been experimenting with CTRL+R.  Seems like it won't work if there is any output, e.g. DSPLIBL or SNDUSRMSG aren't  acceptable, whereas CRTDTAARA is. Trying to workout the user case for this feature. I've trolled through open and closed issues and it looks like it is primarily for pseudo source, which fits in with CRTDTAARA working.
But...
Ctrl+R works for this:
PGM
    CRTDTAARA DTAARA(LENNONSB/DELETE_ME) TYPE(*CHAR) LEN(20) VALUE('PLEASE DELETE ME') +
     TEXT('DELETE THIS')
ENDPGM

but Ctrl+R doesn't work for this, which is a likely pseudo source use case
PGM
 CRTMSGF    MSGF(LENNONS1/CUSTMSGF) TEXT('Customer +
                          Related Messages')
 ADDMSGD    MSGID(DEM0000) MSGF(LENNONS1/CUSTMSGF) MSG('Press Enter to +
                          update. F12 to Cancel.')
 ENDPGM

Output:

Both pieces of code compile with Ctrl+E and execute successfully.

@worksofliam
😕 Working on the documentation, but I'm having trouble figuring out how CL Code assist consistently works.
For example, if I enter just "d" it provides assistance without any action on my part:

Or if I enter just "s" I also get assistance with no action on my part:

Though in both these cases the pick list it incomplete. Commands starting with "d" include  DCL , DCLF , DCLPRCOPT, DCPOBJ, DEL, DEP,  DLCOBJ  and more. There are a boatload of commands that start with "s".
If  I enter just  "dofor"  nothing happens.
But if I enter a space after "dofor"  and then hit Ctrl+Space I get assistance:

If I enter "s" and a space and Ctrl+Space I get quite a list, though I don't understand why some of then are provided. For example, why is "WHEN" provided"? And why is "SAV" missing?

And if I enter "sa " and Ctrl+Space why doesn't "SAV" show up?

Questions:

When are single characters a special case, not needing a space plus Ctrl+Space?
Why does single character assistance provide incomplete results?
Why do some pick lists exclude some commands and/or return seemingly irrelevant results.
Why does CTRL+R fail for the CRTMSGF/ADDMSGD code shown in the previous message?

FWIW: I'm working on PUB400.COM, in case that makes any difference

@SJLennon
I will summarize your questions instead of answering one by one, since I think it will answer swiftly.
In the content assist for CL, you are seeing two types of icons in the list.

A square - these are snippets, not directly provided by the content assist, but are hardcoded snippets defined by the extension. We don't control how these appear - though it seems they are always show, but then filtered and ordered by some kind of fuzzy search.
The abc icon/label - which is an actual suggestion from our extension. We are only showing suggestions for specific commands, which is likely why you are forced to trigger the control assist with your shortcut (Ctrl+Space). I believe we only search after 3 characters have been provided.

For the pseudo source issue: I am going to look at that now.

@worksofliam OK, this is my understanding:
a) The snippets defined in the extension allow partial entry of  some commands chosen by the extension developer
b) Ctrl+Space provides prompting for the parameters of a command that has been keyed completely. (This goes back to the server for the command parameters and defaults. Which is what RDi does.)
It will be interesting to document the nuances of these two situations. Is the intention that more snippeted commands may be added/contributed?
(The currently snippet list is interesting: SNDSMTPEMM is something I have never used and I'm not even authorized to on PUB400. Had to Google it 🤕 )
Seems like when I was trying to create screen shots, for the snippets I saw a description turn up of each item in the pick list, e.g. DLTF  showed "Delete File". But I'm not seeing that this morning.  Is this a VS Code setting that I've somehow flipped?

@worksofliam

For the pseudo source issue: I am going to look at that now

Seems like one line at a time may be executed:

If you highlight multiple lines you get an error--doesn't know where the first command ends and runs them together:

Question: Was the intention that multiple lines could be executed so that it could be used as pseudo source? Seems like I saw such a request from the "bob" project.
Making progress with the rest of the CL documentation.

How i can enable the CL content assist?
In Setting there is no option to enable it.

You need to install the CLLE language tools extension. I have a pull request in to update the documentation but don't know when it will be accepted.
[cid:4086538b-284b-48ba-aac7-126d914e7709]

From: PIO-HimanshuGehlot @.>
Sent: Friday, June 28, 2024 7:57 AM
To: codefori/vscode-ibmi @.>
Cc: SJLennon @.>; Mention @.>
Subject: Re: [codefori/vscode-ibmi] Page on CL extension in docs (Issue #1973)
How i can enable the CL content assist?
In Setting there is no option to enable it.
—
Reply to this email directly, view it on GitHubhttps://github.com/codefori/vscode-ibmi/issues/1973#issuecomment-2196744761, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQC3TEZF4KJSW5IDJQI53QTZJVFRRAVCNFSM6AAAAABFWCMXQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJWG42DINZWGE.
You are receiving this because you were mentioned.Message ID: @.***>

Is there any option to enter commands like we used to do on green screen command line?
suppose i have created a command that will add 5 libraries into my *libl so how i can issue the same command on VS code?

@PIO-HimanshuGehlot
As far as I know, there is no equivalent of entering a command on the command line or in QCMD.
However, you can execute a CL command by highlighting it and pressing Ctlr+r;

Output after Ctrl+r:

@SJLennon  thanks for the help.
and i want to ask while entering the CL command which key will prompt the parameters that we needed as you can see in below screenshot, i have pressed Ctrl + Space but it is not giving me the parameters that should have for that perticular command?

@PIO-HimanshuGehlot It works for me.

Not sure why you are having problems.

Do other system commands work?
You do have a library list set in your connection?

(Bear in mind that I didn't do any of the coding on the extension, I've just contributed some documentation, which has just been updated: https://codefori.github.io/docs/extensions/clle/)

It's weird, i don't know what is the issue exactly.
I have two systems, in one of those its working fine.
Also I don't have any library set in my connection.

@PIO-HimanshuGehlot Make an issue in the CL extension repo (IBM/vscode-clle) and we can look into it for you.

Is there any option to enter commands like we used to do on green screen command line? suppose i have created a command that will add 5 libraries into my *libl so how i can issue the same command on VS code?

@PIO-HimanshuGehlot Sorry for the late reply... you can use the Command Profiles in Code for IBM i to run your command and setting the library list via CL commands. HTH.

Fixed in Docs PR #32


Foreign keys not working

I can't make it work any way. I tried both overriding from the "Table" class and calling it on the property.
Overriding:
class Requests extends Table {
  IntColumn get requestId => integer()();
  IntColumn get requestTypeId => integer()();
  IntColumn get numberOfDocuments => integer()();

  @override
  Set<Column> get primaryKey => {requestId};
}

class RequestDocuments extends Table {
  IntColumn get requestId =>
      integer()();
  IntColumn get documentId => integer()();
  IntColumn get documentStateId => integer()();

  @override
  Set<Column> get primaryKey => {requestId, documentId};

  @override
  List<String> get customConstraints => [
        'FOREIGN KEY(request_id) REFERENCES requests(request_id)',
      ];
}

On the property:
class Requests extends Table {
  IntColumn get requestId => integer()();
  IntColumn get requestTypeId => integer()();
  IntColumn get numberOfDocuments => integer()();

  @override
  Set<Column> get primaryKey => {requestId};
}

class RequestDocuments extends Table {
  IntColumn get requestId =>
      integer().customConstraint('REFERENCES requests(request_id)')();
  IntColumn get documentId => integer()();
  IntColumn get documentStateId => integer()();

  @override
  Set<Column> get primaryKey => {requestId, documentId};
}

What I am doing wrong?
Originally posted by @JPiris88 in https://github.com/simolus3/moor/issues/14#issuecomment-502613545

(moved to a new open issue for a better overview)
Both ways should work, actually. The custom constraint will only be written when the table is created. Perhaps you already had a file of the database on your device before you added the constraint?
Also, I think sqlite doesn't enforce references by default, so this library should have a way to turn that on explicitly.

I uninstalled my app from the emulator and also wiped the emulator data in the AVD Manager, so the database file has been created again. I do this very often.
Regarding your second suggestion, I also thought that so I tried to enabling foreign keys executing the next command, but it doesn't work:
FlutterQueryExecutor.inDatabaseFolder(path: 'db.sqlite', logStatements: false).runCustom("PRAGMA foreign_keys = ON")

That's actually a good idea: When passing the FlutterQueryExecutor as a constructor and calling it there, the custom statement is executed.
@UseMoor(...)
class Database extends _$Database {
  Database()
      : super(
          FlutterQueryExecutor.inDatabaseFolder(
            path: 'db.sqlite',
            logStatements: true,
          )..doWhenOpened((e) => e.runCustom('PRAGMA foreign_keys = ON')),
        );

Arguably, this really isn't an acceptable solution. I'll implement some proper post-opening callbacks in the next versions which hopefully make this easier.

In the next version (1.5), you will be able to do the following:
@override
MigrationStrategy get migration {
  return MigrationStrategy(
    beforeOpen: (engine, details) async {
      await engine.customStatement('PRAGMA foreign_keys = ON;');
    },
  );
}

The beforeOpen callback is new and will be called whenever the database is opened. The customStatement method is also new and can run arbitrary statements that don't necessarily have a return value.


cloned pypi version and fixed application_id bug caused by shell's …

…account deletion

Understandable, sorry I've been dead, I'll give you collaborator access so you can manage this repository if you have time.


Clarify backend=backend runs things in job mode for v2 primitives

If you set backend=backend in a v2 primitive it will run the program in job mode, even if it's inside a batch/session context
with Batch(backend=backend):
    sampler = SamplerV2(backend=backend)

so in general we should emphasise to users that they should not do this and instead use these formats:
with Batch(backend=backend):
    sampler = SamplerV2()

or
with Batch(backend=backend) as batch:
    sampler = SamplerV2(session=batch)

(note session=batch is confusing and will likely be changed in future)

@javabster I want to take this one

(note session=batch is confusing and will likely be changed in future)

Yeah we are deprecating both session and backend parameters in primitive __init__ to avoid this confusing in the next release (hopefully coming out this week). The replacement is mode.

thanks @arujjval go ahead and work on this, make sure to check out the README for contribution instructions before you get started.
@jyu00 for now we'll just mention the version without session or backend and then update with mode in a later PR


Stop overriding locations for expressions within f-strings

https://github.com/RustPython/RustPython/pull/4384 fixed the location of FormattedValue. Now, expressions within f-strings should have the correct locations. Here's a quick demo.
https://user-images.githubusercontent.com/17039389/210124329-b0c71bd5-3c9a-4b44-949a-9f774f56fac9.mov
> cargo run -- --show-source --no-cache --select C,F a.py
a.py:1:4: C408 Unnecessary `list` call (rewrite as a literal)
  |
1 | f"{list()}"
  |    ^^^^^^ C408
  |
a.py:2:6: F821 Undefined name `x`
  |
2 | f"{  x   }"
  |      ^ F821
  |
a.py:4:6: C408 Unnecessary `dict` call (rewrite as a literal)
  |
4 | f"""{dict()}"""
  |      ^^^^^^ C408
  |
a.py:6:5: F821 Undefined name `x`
  |
6 | rf"{x}"
  |     ^ F821
  |
a.py:8:7: F821 Undefined name `x`
  |
8 | rf"""{x}"""
  |       ^ F821
  |
a.py:11:2: F821 Undefined name `x`
   |
11 | {x}
   |  ^ F821
   |
a.py:14:6: F821 Undefined name `x`
   |
14 | f"\n{x}"
   |      ^ F821
   |
a.py:16:10: F821 Undefined name `x`
   |
16 | f"\u1234{x}"
   |          ^ F821
   |
a.py:18:6: F821 Undefined name `x`
   |
18 | f"\\{x}"
   |      ^ F821
   |
a.py:20:14: F821 Undefined name `x`
   |
20 | f"\\\\\\\\\\{x}"
   |              ^ F821
   |
a.py:23:2: F821 Undefined name `x`
   |
23 | {x}"
   |  ^ F821
   |
Found 11 error(s).
2 potentially fixable with the --fix option.

What?!?!? Noooo way!

 That looks like a really impressive change.

What I did was the following:

Use the right offset when parsing expressions within f-strings.
Fix the lexer to preserve the original string to compute the right locations

This also seems to be a little bit faster...

Honestly this makes me so happy. This is great. Thank you.


Greater touch zone for anchor points

Currently it is a bit fiddly to use anchor points, especially when not very familiar with touch screens. To solve this the anchor points should have a bigger (invisible or less visible) area that also catches the touch events.

When implementing one should note that the current AnchorHandler performs a getPickResult() that expects to directly find the ConnectionAnchor (which is a Circle), not its child or parent or anything else. This behavior should be upgraded when changing the area that catches events to more than just the one ConnectionAnchor Circle.

Fixed in the latest ui-types-bowtie branch, this branch still needs to be cleaned though


Tmp ci

for test

Codecov Report
Base: 60.49% // Head: 63.17% // Increases project coverage by +2.67% :tada:

Coverage data is based on head (fa6bd68) compared to base (a5ec1c3).
Patch coverage: 3.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
+ Coverage   60.49%   63.17%   +2.67%
==========================================
  Files          70       75       +5
  Lines       18583    21322    +2739
==========================================
+ Hits        11242    13470    +2228
- Misses       7341     7852     +511

Impacted Files
Coverage Δ

pallets/elections-phragmen/src/lib.rs
92.02% <ø> (ø)

pallets/elections-phragmen/src/migrations/v3.rs
0.00% <0.00%> (ø)

pallets/elections-phragmen/src/migrations/v4.rs
0.00% <0.00%> (ø)

pallets/elections-phragmen/src/migrations/v5.rs
0.00% <0.00%> (ø)

runtime/src/lib.rs
10.88% <ø> (ø)

pallets/elections-phragmen/src/weights.rs
7.14% <7.14%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Updateserver: Allow all admins to have access

This isn't really all that great unless the update automatically rolls back in case of merge conflicts, which is.... actually pretty complex to implement.
I gave it a try a couple of years ago and arrived to https://hastebin.com/zocuqojolo.js, but I ultimately abandoned it after finding out that

There were still Git-originated edge cases
It wasn't really cross-platform (mainly due to PowerShell treating stderr writes as actual execution errors)

IMO, the best way around that would be to use a specialized Git dependency like NodeGit

Or, in the case of merge conflicts, it just makes it so that the hotpatch lock is enabled and it notifies Dev or something.
In theory, there shouldn't be uncommited code that would cause a merge conflict.  In practice, the code that is uncommited should be separated enough from whatever could possibly conflict with what's on the master branch.

Toggling the hotpatch lock sounds great for most situations, but it still leaves the server files in a bad state for the nowadays increasingly common case of a server crash.

There could be a separate command, /serverreset [commit hash], that does git reset --HARD [commit hash].

But yes, doing git rebase --abort does sound like a good idea. 👍

Does git rebase --abort restore uncommitted code and staged code to their previous position?

I thought git rebase --abort could only be used during an interactive rebase i.e. git rebase -i. If you try to using it after a non-interactive rebase has been completed i.e. git rebase HEAD~1 it responds with "No rebase in progress?".  If you want to undo a rebase you'd have to do what  panpawn suggested or play around with git checkout and git reflog to get to the commit point before the rebase (which I believe restores uncommitted/staged code).

I thought git rebase --abort could only be used during an interactive rebase i.e. git rebase -i

That's not true. I avoid interactive rebases like the plague, and I still abort rebases every now and then.
Hard resets should be out of the question imo. They are way too risky for an automated task.

I alias REPO="origin master" git fetch $REPO && git rebase --merge $REPO to unfuckmyrepo in .zshrc to handle merge conflicts. git rebase --continue after editing the files that conflict and running git add so the issues can be resolved. I don't see why admins who aren't devs should be in charge of updating the server if they're likely not capable of fixing potentially dangerous problems that can crop up. Asking a dev later isn't much more than a mitigation to a problem that doesn't need to happen in the first place, especially if git rebase --abort is being recommended so problems can be ignored and dealt with another time (despite it being able to prevent the server from being buggy longer than it should be).
I can understand why permitting more people to update the server can be appealing, but I just find it too risky to be worth it. Maybe I'm just paranoid though

I might have misunderstood what @wgma00 said about aborting rebases...
As it turns, out, git rebase --autostash can't be aborted with git rebase --abort if there is a failure in the stash reapply phase.

So what about if git pull --rebase --autostash fails? That's the important one.

We currently run git rebase --autostash in /updateserver.
git pull --rebase --autostash, on the other hand, seems to have a variety of bugs even on bleeding edge Git releases, as suggested by https://stackoverflow.com/a/30209750. I have verified the fast-forward issue in my own setup: it creates the stash but it isn't applied at all after the pull.

What if this could work like a queue? Admins who aren't devs could push updates to production, and if they have a merge conflict, they could be left to the devs to handle. That'd help keep the best of both worlds without the need to fight git

Has this feature been requested by non-dev admins? I feel like the feature may go unused as they would trust the better judgement of dev-admins.

The idea is that the server could get patched new code more frequently, and that they could consult any tech staff if the server is in a safe state to patch at any given time

What if this could work like a queue? Admins who aren't devs could push updates to production, and if they have a merge conflict, they could be pushed aside for the devs to handle later, so long as no more updates are pushed beforehand. That'd help keep the best of both worlds without the need to fight git to make it work, but even if it can still occasionally delay updates getting pushed to the server, it'd still be an improvement. I'm not saying to give up, but to take this gradually

I like this idea.  So, this could probably be merged as-is, and then explained to non-tech admins how this works?

I still don't understand how you propose to make this not-dangerous.

As in, security-wise, or with merge-conflicts? Can you elaborate?

I would assume dangerous to the server.

That still doesn't answer my question @AustinXII

With merge conflicts.

Oh sorry I meant that in an affecting the server kind of way (breaking the server directly) not the users (breaking into accounts and then server subsequently)

As it turns, out, git rebase --autostash can't be aborted with git rebase --abort if there is a failure in the stash reapply step (tested with Git 2.11.1.windows.1)

This is really frustrating, honestly.
Is there any way to do a rebase with a dirty tree, and completely undo it if it fails?
What if we manually stash?

One thing we could do is manually store the current ref, stash, pull --rebase, stash pop, and if there's a conflict, reset --hard that ref, and stash pop again.
@panpawn, if you could do that, I'd be willing to give other admins the ability to /updateserver.

@panpawn?


Adding unit tests

What this PR does / why we need it:
Adding unit tests for the server feature.
Yes, tiger/rkhunter don't make too much sense to be run inside a chroot environment, but they are running in a rather limited mode and will check regular stuff like file permissions, setuid files, setgid files, ssh configuration, etc.
Which issue(s) this PR fixes:
Fixes #4
Special notes for your reviewer:
Tests using sysctl and run inside a chroot make no sense, will be either removed or disabled.
Release note:

Can you please squash the commits?


Rocket.chat Taskbar icon is pixelated under Windows 10 [3.2.2]

Hi,
Operating system: Windows 10 x64 19042.985
App Version: 3.2.2
Description: Rocket.chat Taskbar icon is pixelated under Windows 10 (when labels are enabled in Taskbar settings).

Current Behavior: pixelated icon looks vintage
Expected Behavior: having the same icon as the pinned one or when taskbar labels are hidden

Thank you

I don't have that bug

If I disable labels, the icon is fine, but if labels are enabled then the icon becomes ugly.

Is this being looked at? My screen resolution is 3840x2160 (HDPI)

Please test if the problem persists with our latest release. I will be closing the issue but if there is any problem yet, we will open it again.

@jeanfbrito Problem persists with release 3.8.7 (latest).

This happens because you are using a 4k resolution with scale tu increase the size? It should be a problem with Windows in high resolutions.

Yes, it is using font scaling. But I have had this setting all along and the pixelation was not occurring with previous versions of the RC client.

What exactly are the previous versions? Could you test if without scale it will work normally?
We already have a big resolution icon on the project, but I cant understand why its not being used in your case.

This is 3.2.0 "with" scaling still turned on (as shown in the previous settings screenshot). As you can see, the icon looks perfect on HDPI

I have the same problem with custom icons without any scaling on 1920x1080 display with Windows 10 and Windows 11.
Also, if I delete custom icons, stock icon is also blurry.


Error when opening Netflix

I'm submitting a ...

[X] bug report
[ ] feature request
[ ] support request

General infomration
Prerequisites

[X] Are you running the latest version?
Yes 0.12.7

Description
addon seems broken
Installation

[ ] I installed the plugin via zip from the Releases page
[X] I´m using the Netflix Repo
[ ] I´m using a different source (Please tell which)

Operating System

[X] Linux (x86/x64)
[ ] OSX (x86/x64)
[ ] Windows (x86/x64)
[ ] Linux (ARM)
[ ] Android

Additional informatin on the environment
Libreelec millhouse nightly
Debug log
20:46:36.465 T:140268224399104   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <type 'exceptions.ImportError'>
Error Contents: No module named urllib3
Traceback (most recent call last):
File "/storage/.kodi/addons/plugin.video.netflix/addon.py", line 11, in
from resources.lib.KodiHelper import KodiHelper
File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/KodiHelper.py", line 21, in
from resources.lib.MSL import MSL
File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/MSL.py", line 25, in
import requests
File "/storage/.kodi/addons/script.module.requests/lib/requests/init.py", line 43, in
import urllib3
ImportError: No module named urllib3
-->End of Python script error report<--
20:46:36.492 T:140269684732480   ERROR: GetDirectory - Error getting plugin://plugin.video.netflix/?Return
20:46:36.493 T:140269684732480   ERROR: CGUIMediaWindow::GetDirectory(plugin://plugin.video.netflix/?Return) failed

sorry for the paste, seemed faster.

crap... close this... fixed by reinstall

This is caused by some modules update of kodi. Restart it and all works again

Uninstall the netflix addon, reinstall and reboot .... all works


Cannot attach tags in Sentry 21.2.0

Hello,
First I would like to say thank you for keeping this plugin alive.
I have run into an issue after updating to Sentry 21.2.0 where enabling attach tags throws an error on publishing a notification:
AttributeError: 'Event' object has no attribute 'get_tags'
  File "sentry/utils/safe.py", line 23, in safe_execute
    result = func(*args, **kwargs)
  File "sentry/plugins/bases/notify.py", line 92, in rule_notify
    self.notify(notification)
  File "sentry/plugins/bases/notify.py", line 60, in notify
    event.group, event, triggering_rules=[r.label for r in notification.rules]
  File "sentry_mattermost/plugin.py", line 176, in notify_users
    self, event, template, triggering_rules)
  File "sentry_mattermost/plugin.py", line 80, in create
    params["tags"] = get_tags(event)
  File "sentry_mattermost/plugin.py", line 39, in get_tags
    tag_list = event.get_tags()

Full error report here: https://sentry.liquidcrystalstudios.com/share/issue/e8de7369191b4364a5d485692bffbbb2/
Thanks,
Trevor

Hi Trevor,
It's seems like we have fixed the issue.
Please feel free to double check.
Kind regards,
Team Biekos

Dear @tlf30,
Did you by any chance get time to test the latest version?
Have a lovely day.
My best regards.

@PXke, I have been in the artic circle for the last two weeks! It was cold, we saw -54⁰ F.
I am currently traveling home. I will test once I get in back.

Dear @tlf30
Enjoy, It sounds like it has been cool and fun.
Have a safe trip
Best
G.

@aurorecr @PXke I just tested the update, it works great.
Thank you for your work on this.

Pleasure! Enjoy your trip,
Kind regards,
Aurore


javascript files for recent changes in modules.json

Some changes were made in modules.json for which javascript files were not generated. This PR merges all those files.

@shivanshbindal9 Thank you!


import yft vehicle

everything works great except the wheel location on vehicles. it seems to 180 the tire along the center of the car and put the tire on the right front instead of the left front. after reading all the threads about rotation looks like there might be a rotation calculation that needs fixed. IDK its supper cool great work! Any way to fix this on my end?

Actually it was my fault. After your edits you have to put all the other wheels under the FL wheel with ZModeler3.


openstack refarch deploy-dns fails missing ServerGroupAntiAffinityFilter

BUG REQUEST INFO:
Environment:

Cloud provider: my own hardware

OS (printf "$(uname -srm)\n$(cat /etc/os-release)\n"):

Linux 3.10.0-514.26.2.el7.x86_64 x86_64
NAME="Red Hat Enterprise Linux Server"
VERSION="7.3 (Maipo)"
ID="rhel"
ID_LIKE="fedora"
VERSION_ID="7.3"
PRETTY_NAME="Red Hat Enterprise Linux"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:redhat:enterprise_linux:7.3:GA:server"
HOME_URL="https://www.redhat.com/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"

REDHAT_BUGZILLA_PRODUCT="Red Hat Enterprise Linux 7"
REDHAT_BUGZILLA_PRODUCT_VERSION=7.3
REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="7.3"

Version of Ansible: (ansible --version):

ansible <IP_ADDRESS>
  config file = /etc/ansible/ansible.cfg
  configured module search path = Default w/o overrides

Version of Jinja: (pip freeze | grep -i jinja)

-bash: pip: command not found

Version of Shade: (pip freeze | grep -i shade)

-bash: pip: command not found

Openstack-ansible-contrib version (commit) (git rev-parse --short HEAD):
138e625

Copy of used inventory files and custom variables (please omit your secrets!):
# dns-vars.yaml
---
domain_name: ocp3.example.com
contact<EMAIL_ADDRESS># real DNS servers from environment
dns_forwarders: [x.x.x.x, y.y.y.y]

update_key: "pxxxxxxxxxxxxxxxxxxxxx=="
slave_count: 2

stack_name: dns-service
external_network: external-179

image: rhel7
flavor: tiny-1x1
ssh_user: cloud-user
ssh_key_name: ocp3

# NOTE: For Red Hat Enterprise Linux:
#rhn_username: "rhnusername"
#rhn_password: "NOT A REAL PASSWORD"
#rhn_pool: "pool id string"
# Either RHN or Sat6
sat6_hostname: "satellite.company.com"
sat6_organization: "Company"
sat6_activationkey: "system-import"

Command used to invoke ansible:
#!/bin/bash
export ANSIBLE_HOST_KEY_CHECKING=False
ansible-playbook --private-key ocp3.key -e @dns-vars.yaml -vv\
        openshift-ansible-contrib/reference-architecture/osp-dns/deploy-dns.yaml | tee dns-deploy.log

Output of ansible run:

Using /etc/ansible/ansible.cfg as config file

PLAYBOOK: deploy-dns.yaml ******************************************************
5 plays in openshift-ansible-contrib/reference-architecture/osp-dns/deploy-dns.yaml

PLAY [Deploy the DNS servers] **************************************************

TASK [Check whether the stack exists already] **********************************
task path: /home/stack/openshift/openshift-ansible-contrib/reference-architecture/osp-dns/deploy-dns.yaml:16
fatal: [localhost]: FAILED! => {"changed": true, "cmd": ["openstack", "stack", "show", "dns-service"], "delta": "0:00:01.417990", "end": "2017-08-26 19:18:42.678917", "failed": true, "rc": 1, "start": "2017-08-26 19:18:41.260927", "stderr": "Stack not found: dns-service", "stdout": "", "stdout_lines": [], "warnings": []}
...ignoring

TASK [Create the Heat Stack] ***************************************************
task path: /home/stack/openshift/openshift-ansible-contrib/reference-architecture/osp-dns/deploy-dns.yaml:21
fatal: [localhost]: FAILED! => {"changed": false, "failed": true, "msg": "Stack 'dns-service' failed.", "rc": 1, "stderr": "\n Stack dns-service CREATE_FAILED \n\n", "stdout": "2017-08-27 02:18:49Z [dns-service]: CREATE_IN_PROGRESS  Stack CREATE started\n2017-08-27 02:18:49Z [dns-service.network]: CREATE_IN_PROGRESS  state changed\n2017-08-27 02:19:00Z [dns-service.network]: CREATE_COMPLETE  state changed\n2017-08-27 02:19:01Z [dns-service.hosts]: CREATE_IN_PROGRESS  state changed\n2017-08-27 02:21:14Z [dns-service.hosts]: CREATE_FAILED  ResourceInError: resources.hosts.resources.slaves.resources.slaves.resources[1].resources.host: Went to status ERROR due to \"Message: ServerGroup policy is not supported: ServerGroupAntiAffinityFilter not configured, Code: 400\"\n2017-08-27 02:21:14Z [dns-service]: CREATE_FAILED  Resource CREATE failed: ResourceInError: resources.hosts.resources.slaves.resources.slaves.resources[1].resources.host: Went to status ERROR due to \"Message: ServerGroup policy is not supported: ServerGroupAntiAffinityFilter not configured, Code: 400\"\n", "stdout_lines": ["2017-08-27 02:18:49Z [dns-service]: CREATE_IN_PROGRESS  Stack CREATE started", "2017-08-27 02:18:49Z [dns-service.network]: CREATE_IN_PROGRESS  state changed", "2017-08-27 02:19:00Z [dns-service.network]: CREATE_COMPLETE  state changed", "2017-08-27 02:19:01Z [dns-service.hosts]: CREATE_IN_PROGRESS  state changed", "2017-08-27 02:21:14Z [dns-service.hosts]: CREATE_FAILED  ResourceInError: resources.hosts.resources.slaves.resources.slaves.resources[1].resources.host: Went to status ERROR due to \"Message: ServerGroup policy is not supported: ServerGroupAntiAffinityFilter not configured, Code: 400\"", "2017-08-27 02:21:14Z [dns-service]: CREATE_FAILED  Resource CREATE failed: ResourceInError: resources.hosts.resources.slaves.resources.slaves.resources[1].resources.host: Went to status ERROR due to \"Message: ServerGroup policy is not supported: ServerGroupAntiAffinityFilter not configured, Code: 400\""]}
        to retry, use: --limit @/home/stack/openshift/openshift-ansible-contrib/reference-architecture/osp-dns/deploy-dns.retry

PLAY RECAP *********************************************************************
localhost                  : ok=1    changed=1    unreachable=0    failed=1

[stack@director openshift]$ openstack stack event list dns-service
2017-08-27 02:18:49Z [dns-service]: CREATE_IN_PROGRESS  Stack CREATE started
2017-08-27 02:18:49Z [dns-service.network]: CREATE_IN_PROGRESS  state changed
2017-08-27 02:19:00Z [dns-service.network]: CREATE_COMPLETE  state changed
2017-08-27 02:19:01Z [dns-service.hosts]: CREATE_IN_PROGRESS  state changed
2017-08-27 02:21:14Z [dns-service.hosts]: CREATE_FAILED  ResourceInError: resources.hosts.resources.slaves.resources.slaves.resources[1].resources.host: Went to status ERROR due to "Message: ServerGroup policy is not supported: ServerGroupAntiAffinityFilter not configured, Code: 400"
2017-08-27 02:21:14Z [dns-service]: CREATE_FAILED  Resource CREATE failed: ResourceInError: resources.hosts.resources.slaves.resources.slaves.resources[1].resources.host: Went to status ERROR due to "Message: ServerGroup policy is not supported: ServerGroupAntiAffinityFilter not configured, Code: 400"

Anything else do we need to know:
This is a fresh OSP cluster installed with help of Tiger team, and I am a OpenStack newb.
Running all from Director node as ocp3 user in ocp3 project.
I'm working through the ref arch to deploy DNS
Apparently I do not have an anti affiinity configuration in Nova and am not sure how best to rectify.
This does not seem to be listed as a prereq in the ref arch. I know it is written for OSP 10 and I am on OSP 11.

Give this a look it may be relevant
https://github.com/redhat-openstack/openshift-on-openstack/issues/249

I'm trying to understand how to modify the director's heat templates to enable this and do a openstack overcloud deploy to fix it.
Would the manual fix be to uncomment the first 2 lines below and restart openstack-nova?
[root@osp-comp-01 nova]# grep -E 'enabled_filters=|available_filters=' /etc/nova/nova.conf
#available_filters=nova.scheduler.filters.all_filters
#enabled_filters=RetryFilter,AvailabilityZoneFilter,RamFilter,DiskFilter,ComputeFilter,ComputeCapabilitiesFilter,ImagePropertiesFilter,ServerGroupAntiAffinityFilter,ServerGroupAffinityFilter
#baremetal_enabled_filters=RetryFilter,AvailabilityZoneFilter,ComputeFilter,ComputeCapabilitiesFilter,ImagePropertiesFilter,ExactRamFilter,ExactDiskFilter,ExactCoreFilter

I sent a note to refarch-feedback suggesting there is a missing pre-req.

Ping my engineers after you sent the email but will also ping a couple osp experts on here as well to get some more traction.
@tomassedovic @bogdando

I think I'm getting closer with advanced_overcloud_customization doc
[stack@director manifests]$ grep _filters /etc/puppet/modules/nova/manifests/scheduler/*
# [*scheduler_available_filters*]
#   Defaults to ['nova.scheduler.filters.all_filters']
# [*scheduler_default_filters*]
# [*baremetal_scheduler_default_filters*]
# [*scheduler_use_baremetal_filters*]
#   (optional) Use baremetal_scheduler_default_filters or not.
  $scheduler_available_filters                    = ['nova.scheduler.filters.all_filters'],
  $scheduler_default_filters                      = $::os_service_default,
  $baremetal_scheduler_default_filters            = $::os_service_default,
  $scheduler_use_baremetal_filters                = false,
...
[stack@director scheduler]$ grep "_filters" /usr/share/openstack-tripleo-heat-templates/puppet/services/nova-*
/usr/share/openstack-tripleo-heat-templates/puppet/services/nova-scheduler.yaml:            nova::scheduler::filter::scheduler_available_filters: {get_param: NovaSchedulerAvailableFilters}
/usr/share/openstack-tripleo-heat-templates/puppet/services/nova-scheduler.yaml:            nova::scheduler::filter::scheduler_default_filters: {get_param: NovaSchedulerDefaultFilters}

I think I need to add the following to my custom_hiera.yaml
NovaSchedulerDefaultFilters:
 [RetryFilter,AvailabilityZoneFilter,RamFilter,DiskFilter,ComputeFilter,ComputeCapabilitiesFilter,ImagePropertiesFilter,ServerGroupAntiAffinityFilter,ServerGroupAffinityFilter]

For the keystone token expiration (which is called out as pre-req) I resorted to Ansible to configure the controllers "by hand".

@dlbewley unfortunately I'm not sure how to sat that up via tripleo/director, but I want to check one thing: does your cluster have more than one compute node? Anti-affinity won't ever work otherwise.
If you only have one compute node, set this in your vars file:
slave_server_group_policies: ['affinity']

That will still require having the filter, though.
I think leaving the list empty should work everywhere but I don't have a set up where to test this right now -- so you could try that and see if it unblocks you in the meantime.

@tomassedovic I have multiple compute nodes.
I ran into an issue with deployment and my cloud is down. I have opened a case with support and I'll try changing the server group to 'affinity' and resume troubleshooting this once we have the deploy running cleanly again.

@tomassedovic on OSP10 there's a case for backporting soft-anti-affinity on heat (as on nova it's already supported). See:

https://bugzilla.redhat.com/show_bug.cgi?id=1480338

After my cloud was fixed up, the scheduler blocker was cleared. I do think the ref arch might be more comprehensive it it included the nova filters required. @markllama
I'm now finding that  bind-server.yml:9 is perturbed by the lack of firewalld in my rhel 7 image, but that's another issue.


On checkboxes, the dirty/pristine flag isn't triggered until a user interacts with the very last item

Versions

vee-validate: 2.2.0
vue: 2.6.10

Describe the bug
On checkboxes, the dirty/pristine flag isn't triggered until a user interacts with the very last item. I was running into this issue with Buefy -- but i've created a demo showing the issue in Buefy and with native checkboxes.
To reproduce
Steps to reproduce the behavior:

See the demo -- clicking checkbox one or two will not set the dirty/pristine flags.
Click checkbox 3, it will set the flags

Expected behavior
Should be switched when any item is interacted with
Demo link
https://codepen.io/lfkwtz/pen/qvLQpN

This is because of the name attribute is the same for all inputs. While this is normal for checkboxes and HTML, vee-validate uses the name attribute to identify the fields. So it keeps registering the field until the very last item which overrides the previously registered field of the same name.
There is no way around that with the directive unless you use a different name for each input, v-model would still work fine even if the names are not the same.
However, with ValidationProviders you could validate them and have the flags reported as expected without issues.
Here is an example with Providers instead of the directive:
https://codepen.io/anon/pen/rRPvEw


Upgrade gene.iobio to vue-cli (decide if vue.js version 2 or 3)

We need to upgrade gene.iobio to vue.js 2 or 3, using the latest version of build tools (webpack, node sass etc.)

@stefinfection - Would you mind commenting on the problem we are seeing with building clin.iobio related to node sass? Is there a specific version of node.js and webpack.js we should upgrade to?


python3Packages.tweepy: 4.0.1 -> 4.3.0

Motivation for this change
Update to latest upstream release 4.3.0
Change log:

https://github.com/tweepy/tweepy/releases/tag/v4.3.0
https://github.com/tweepy/tweepy/releases/tag/v4.2.0
https://github.com/tweepy/tweepy/releases/tag/v4.1.0

Fix build failure detected in https://github.com/NixOS/nixpkgs/pull/145691
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 145698 run on x86_64-linux 1

7 packages built:

ioccheck
python38Packages.pyalgotrade
python38Packages.tweepy
python39Packages.pyalgotrade
python39Packages.tweepy
semiphemeral
turses

Result of nixpkgs-review pr 145698 run on x86_64-linux 1

7 packages built:

ioccheck
python38Packages.pyalgotrade
python38Packages.tweepy
python39Packages.pyalgotrade
python39Packages.tweepy
semiphemeral
turses


ARROW-16539: [C++] Bump bundled thrift to 0.16.0

Appveyor failure looks like something with gtest, so unrelated. The other Windows failure is https://github.com/apache/arrow/runs/6393577373?check_suite_focus=true#step:7:1065, not sure what that's about. https://github.com/apache/thrift/blame/master/build/cmake/DefinePlatformSpecifc.cmake#L67 mentions this lib, and https://github.com/apache/thrift/commit/7f9abb1cc0f4b2793a48f45ddfcf0d2b287cc50c is the only change to this file since 0.13, so I'm guessing the issue is elsewhere.
If we can resolve this and want to move forward, we should of course run all of the nightlies to check for more issues.

Still no luck @kou. I've tried a few more things. I'm not sure how much this is worth pushing on, I don't think there's any great benefit to upgrading other than generally trying to stay up to date/amortize the cost of updating if there is a critical fix in the future.

I'll try something in this branch.

CI is green.
This is ready to merge.

@github-actions crossbow submit -g nightly

Thanks @kou!


[BUG] Typescript demo store login example doesn't work

To Reproduce

Create a new demo store: https://stackblitz.com/github/Shopify/hydrogen/tree/dist/templates/demo-store-ts
Create an account
Try to login with that account
Notice that const { customerAccessToken } = useSession() is still undefined

Expected behaviour
Logging in after creating an account should give a valid customerAccessToken
Additional context
I did also try connecting this to my own store to see if it was an issue with the demo Shopify account, but I was still able to replicate the problem on my store

Hi @selvinkuik,
Thanks for reporting. There seems to be some issue with the cookie within the Stackblitz web container environment.
Could you validate this is an issue also on https://www.hydrogen.shop or when running the demo store locally?

Hi @juanpprieto
I faced similar issue on Azure App Service.
Azure App Service currently use Node 18.2.0 today.
Node 18.2.0 is using undici 5.2.0 and it may had cookie issue.
https://github.com/nodejs/undici/issues/1463
And this issue is resolved from Node 18.3.0.
We can reproduce it with using Node 18.2.0 locally.
Http response set-cookie header was not available even if below code work,
https://github.com/Shopify/hydrogen/blob/main/templates/demo-store/src/routes/account/login.server.tsx#L76-L84


Uplift third_party/tt-metal to d0326ed27d1885b7f0c573f4885f4c9d4f0c9676 2024-12-29

This PR uplifts the third_party/tt-metal to the d0326ed27d1885b7f0c573f4885f4c9d4f0c9676

Going to merge. Brings 4 tt-metal commits,  forge ci passed.


Add ability to filter file list

Hi @crahan,
As discussed in #23, here is one more pull request.
I added filter_pattern setting. It allows to filter file list according to a pattern. Example: display only files with a particular extension (see issue #12).
Please review when you get a chance and let me know if you have any comments.
Thanks,
Andrii

Hi @crahan,
what is your timeline for merging/releasing this feature? I would be also interested in this.

@dekromp I'll try and get a new release out this weekend. I'd like to include https://github.com/crahan/ipyfilechooser/issues/28 in this release as well.

@andriykorchak apologies for the delay on this PR. It's been merged to master and will be available in release 0.4.0 shortly. Thanks as always for your contribution!


Move to react-photo-album

This PR replaces react-photo-gallery library with react-photo-album.
Additional changes:

React peer dep version bumped to >=16.14.0 in order to meet react-photo-album's peer dep requirement
Added rollup-plugin-peer-deps-external plugin to rollup build pipeline

Resolves #9

@igordanchenko - great work :) I've tested the changes and upgrade-path, it all looks good. Off to merging and releasing a new version. Thank you!


Add sources to override sources fetcher

This PR is a proposition to be able to override the source fetcher.
This can collide with #42 but I think it's a simpler solution to the problem.
User needs to define by itself how to fetch the dependency, but with that it works with all repository etc.. (no guessing).
The usage is pretty simple:
pkgs.buildGoApplication {
  pname = "my-app";
  version = "0.1";
  pwd = ./.;
  src = ./.;
  modules = ./gomod2nix.toml;
  sources = {
    "my-dependency_v0.10.0"= builtins.fetchGit {
      url = "git@github.com:test/my-dependency.git";
      ref = "master";
      rev = "xxxxxxxxx";
    };
  };
}

I just wonder if it is a problem that we don't verify the origin sha of the dependency and that we move the responsability of the "sha" on the fetchGit
WDYT?

Hi, this works for my private repositories. Would also be interested in knowing about the disadvantages of this solution.

It would be nice to have support to pass in packages of private go modules so they can be easily re-used between derivations.

Anyway we can have this merged?

Anyway we can have this merged?

@marcusramberg: You merged some PRs recently. Maybe there is a chance you could have a look at that as well, since @adisbladis seems out of office?

I went down a huge path to get this working for myself and I landed on this as the cleanest way, imo
test = pkgs.buildGoModule {
            name = "test";
            src = gitignore.lib.gitignoreSource ./.;
            doCheck = false;
            ldFlags = "-mod=mod";
            vendorHash = "sha256-ZKp4eeZRFWbogDadB8ZJfBXhSYyVYq1uPpz2WekvtPg=";
            CGO_ENABLED = 0;
            overrideModAttrs = (oldAttrs: {
              impureEnvVars = oldAttrs.impureEnvVars or [ ] ++ [
                "NIX_GITLAB_TOKEN"
              ];
              preBuild = /* bash */ ''
                export HOME=$(mktemp -d)
                cat > ~/.netrc <<EOF
                machine code.il2.gamewarden.io
                  login oauth2
                  password $NIX_GITLAB_TOKEN
                EOF
                export GOPRIVATE=YOURPRIVATESCM/*
                export GONOSUMDB=YOURPRIVATESCM
              '';

              preferLocalBuild = true;
            });
          };

Maybe we can use this as a way to inspire something that will support private repos?

@juliens can you rebase this branch?

Thanks @juliens! I am noticing an issue in build:
error: builder for '/nix/store/bp37lm1x2l79sfmm5gz92xrnmyhxdi3y-omit-1.28.0.drv' failed with exit code 1;
       last 11 log lines:
       > Running phase: unpackPhase
       > unpacking source archive /nix/store/a3d53dch6pg6d36m4rgrg2my3nin03jg-source
       > source root is source
       > Running phase: patchPhase
       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: configurePhase
       > Running phase: buildPhase
       > Building subPackage .
       > internal/omit/omit.go:8:2: cannot find module providing package github.com/omit/omit/api/v1alpha1: import lookup disabled by -mod=vendor

I assume this is because the go.mod in github.com/omit/omitcontains a replace.
So inside the vendor directory github.com/omit/omit/api/v1alpha1 is actually github.com/omit/omit is there any suggestions on working around this?


[Feature Request:] Move images to Quay

Contact Details
<EMAIL_ADDRESS>Is your feature request related to a problem? Please describe.
kubeshark-front and kubeshark-hub pods are stuck in ImagePullBackOff due to Docker Hub rate limiting. It would be a good idea to move these images to another registry without rate limiting like Quay.
bash-3.2$ oc get pods
NAME              READY   STATUS             RESTARTS   AGE
kubeshark-front   0/1     ImagePullBackOff   0          2m8s
kubeshark-hub     0/1     ImagePullBackOff   0          2m8s

1s          Warning   Failed           pod/kubeshark-front   Failed to pull image "docker.io/kubeshark/front:latest": rpc error: code = Unknown desc = reading manifest latest in docker.io/kubeshark/front: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
1s          Warning   Failed           pod/kubeshark-front   Error: ErrImagePull
1s          Normal    BackOff          pod/kubeshark-front   Back-off pulling image "docker.io/kubeshark/front:latest"
1s          Warning   Failed           pod/kubeshark-front   Error: ImagePullBackOff
33s         Normal    Scheduled        pod/kubeshark-hub     Successfully assigned kubeshark/kubeshark-hub to ip-10-0-133-117.us-west-2.compute.internal
33s         Normal    AddedInterface   pod/kubeshark-hub     Add eth0 [<IP_ADDRESS>/23] from ovn-kubernetes
33s         Normal    Pulling          pod/kubeshark-hub     Pulling image "docker.io/kubeshark/hub:latest"
1s          Warning   Failed           pod/kubeshark-hub     Failed to pull image "docker.io/kubeshark/hub:latest": rpc error: code = Unknown desc = reading manifest latest in docker.io/kubeshark/hub: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
1s          Warning   Failed           pod/kubeshark-hub     Error: ErrImagePull
1s          Normal    BackOff          pod/kubeshark-hub     Back-off pulling image "docker.io/kubeshark/hub:latest"
1s          Warning   Failed           pod/kubeshark-hub     Error: ImagePullBackOff

Eventually pods go into ErrImagePull depending on how images were pulled from that IP in that time period. THis is a bigger problem on larger clusters and also when redeploying kubeshark several times on the same environment.
2m25s       Warning   Failed           pod/kubeshark-hub     Error: ErrImagePull
Original Thread
No response
Describe the solution you'd like to see
Move kubeshark-front and kubeshark-hub images to Quay and change default location of images in kubeshark code
Provide additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@smalleni thanks! That's good information

I agree, Quay or GHCR is the way to go.

@mateuszdrab ghcr.io is blocked in China.


recording idea or something like that

What feature do you want to get added on the base engine?
idk if  this is stupid or would be impossible or not, but what if you could record a replay as mp4 with no lag?
you could use ffmpeg for this and make it render in another window like zenith or something (if that's possible)
this would probably be cool, since you wouldn't have to wait for a song to finish at 0.1x speed like watching paint dry
tell me if any updates on this
To test your sight, and reliability, please select the option of what should NOT be requested.
Proper credit that was forgotten

obs:

obs

What feature do you want to get added on the base engine?
idk if this is stupid or would be impossible or not, but what if you could record a replay as mp4 with no lag? you could use ffmpeg for this and make it render in another window like zenith or something (if that's possible)
this would probably be cool, since you wouldn't have to wait for a song to finish at 0.1x speed like watching paint dry tell me if any updates on this
To test your sight, and reliability, please select the option of what should NOT be requested.
Proper credit that was forgotten

obs exists retard

GitHub didn't allow me to be more specific, i hid this comment because it seemed rude.

What feature do you want to get added on the base engine?
idk if this is stupid or would be impossible or not, but what if you could record a replay as mp4 with no lag? you could use ffmpeg for this and make it render in another window like zenith or something (if that's possible)
this would probably be cool, since you wouldn't have to wait for a song to finish at 0.1x speed like watching paint dry tell me if any updates on this
To test your sight, and reliability, please select the option of what should NOT be requested.
Proper credit that was forgotten

That's actually impossible to implement in smth like FNF, i know there's Black MIDI stuff but FNF.. you can't do smth like that

oh ok thanks though

also moxie you didn't have to call me a fuckin retard for that
what i meant by that is it could do it faster instead of having to wait 0.05 seconds for a frame to go by

also moxie you didn't have to call me a fuckin retard for that what i meant by that is it could do it faster instead of having to wait 0.05 seconds for a frame to go by

it's a dumbass question

A similar feature to this has been implemented by HRK_EXEX, so this issue will be opened back up for questioning. https://www.youtube.com/watch?v=5k6PIQUAITc&t=0s

interesting

Added in https://github.com/JordanSantiagoYT/FNF-PsychEngine-NoBotplayLag/commit/a61415ce11370b39af263ea811272aae5efc6caf


Bump ed25519 => v2; k256 => v0.13; signature => v2

Bumps all of the above dependencies to their latest versions, which use the new signature v2 release:
https://github.com/RustCrypto/traits/pull/1211

[ ] Referenced an issue explaining the need for the change
[ ] Updated all relevant documentation in docs
[ ] Updated all code comments where relevant
[ ] Wrote tests
[ ] Added entry in .changelog/

Note: there's a PR to use the signature v2 crate's traits with ed25519-consensus here:
https://github.com/penumbra-zone/ed25519-consensus/pull/6

Hmmm, the docs failure seems to be coming from generic-array:
https://github.com/informalsystems/tendermint-rs/actions/runs/4386941224/jobs/7681624555#step:4:290

Appears to be a bug in the generic-array crate, unfortunately.
I can see if I can configure the docs job to skip that crate.

D'oh, cargo doc --exclude only works for crates in the same workspace.
Not sure how to fix the doc build without an upstream fix in generic-array. The best I can do is point it at that PR using patch.crates-io

Codecov Report

Merging #1285 (a828992) into main (60e10ab) will decrease coverage by 0.1%.
The diff coverage is 70.5%.

:exclamation: Current head a828992 differs from pull request most recent head 3784e1e. Consider uploading reports for the commit 3784e1e to get more accurate results

@@           Coverage Diff           @@
##            main   #1285     +/-   ##
=======================================
- Coverage   64.1%   64.0%   -0.1%
=======================================
  Files        271     271
  Lines      24291   24330     +39
=======================================
+ Hits       15584   15595     +11
- Misses      8707    8735     +28

Impacted Files
Coverage Δ

tendermint/src/public_key.rs
75.6% <25.0%> (+5.6%)
:arrow_up:

tendermint/src/signature.rs
44.6% <33.3%> (-0.5%)
:arrow_down:

tendermint/src/account.rs
82.5% <100.0%> (ø)

tendermint/src/crypto/default/signature.rs
92.0% <100.0%> (ø)

tendermint/src/test.rs
100.0% <100.0%> (ø)

tendermint/src/vote.rs
78.3% <100.0%> (ø)

tendermint/tests/alt_crypto.rs
92.5% <100.0%> (ø)

... and 6 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

The build failure is a semi-recent nightly regression.
The docs build on nightly-2023-03-01, for example. (I'm not sure why it's using nightly in the first place?)

Pinned the nightly used to build the docs and it passed, but that seems like an unrelated build failure which would impact any branch

I'm not sure why it's using nightly in the first place?

I believe we are building the docs on nightly to match what docs.rs is doing.


Signatures: search multiple paths, environment variable?

Packaging retdec currently requires bundling all signatures ~4GB unpacked, many of which a user may not want.  For example I personally don't have use for PE signatures, while naturally many people do.  They might not find my signatures useful. Or whatever.
Instead of having retdec look to a fixed location (or require user intervention to specify an alternative path), could retdec support reading from multiple locations?
This way the same retdec binaries could be made to use any combination of signature collections-- making it natural to split the large database into optional components.
This also would make it easy for folks to convince retdec to use their additional signatures locally generated, allows updating signatures separately from retdec, and could be used for third-party signature collections (although hopefully for the most part everyone helps create a common collection).
Search path environment variable could be something like "RETDEC_SIGNATURES_PATH".
Benefit of env var is that users don't have to invoke tools differently, setting variables is something a package manager could facilitate.
Thoughts? I haven't looked much at how signatures are searched/loaded, so one question I hope you can answer is if this is even possible/reasonable given the current notion of signatures.
I'd be happy to help implement and test this if folks think this would be useful/a good idea.

Loosely related to #143.

Thanks for the suggestion. Right now I'm not sure how we will address this, but we definitely should, and will.

We discussed it and came up with this design #224. This would allow:

Remove whatever stock RetDec signatures from share/retdec/support/static-code and use it like that, or (re)pack it to create a custom RetDec package.
Add any signatures to share/retdec/support/static-code and pack it to create a custom RetDec package.
Add user local signatures to share/retdec/user-support/static-code/ (or whatever that directory will be named, the name is not final). This directory will not be removed and replaced if RetDec's stock support package gets updated.

It does not allow:

Custom signature directories specified via environment variable. Signatures need to be copied to either share/retdec/support/static-code, share/retdec/user-support/static-code/, or always specified via command line argument. We may implement this, but it would need more discussion - e.g. are environment variables the right/best way to go, or maybe use some config files where multiple locations could be specified? If we already have such configs, what else could be there? Some other solution? etc.


Helpers declared after routes aren't available.

When I have a Grape::API application and I declare a namespace, if I declare a route before the helpers block, those helpers aren't available to the route. If I declare the route after, they are. For example:
require 'grape'
class DamnDirtyGrape < Grape::API
    resource :foo do
        get :broke do
            # NoMethodError here.
            hello_helper
        end

        helpers do
            def hello_helper
                "Hello World!"
            end
        end

        get :works do
            hello_helper
        end
    end
end

In Sinatra, a simiilar small framework from which Grape takes inspiriation, both methods work
require 'sinatra'
get '/' do
    hello_helper
end

helpers do
    def hello_helper
        "Hello World!"
    end
end

It's not a major priority but given that Sinatra behaves this way it would be nice from a consistency perspective. If anyone is willing to mentor me a little for this I am more than willing to give it a stab myself.
Cheers and thanks!
Steven!

Is this problem still going on? Looks to be solved.

This issue is still valid:
class API < Grape::API
  prefix :api
  version 'v1', using: :path
  get '/' do
    puts hello_helper
  end

  helpers do
    def hello_helper
      'Hello World!'
    end
  end
end

Output:
undefined local variable or method `hello_helper' for #<#<Class:0x000055f26581eea0>:0x000055f265e1f9f8> (NameError)


Reduce constraint count of a function call

Pasting my comment from slack:
A function call adds 200k constraints to an app circuit? That's surprising.
Edit: ok I've looked at the code and can see it's hashing all fields of a flattened PrivateCircuitPublicInputs. (Links in reverse order)

https://github.com/AztecProtocol/aztec-packages/blob/d4921a032a56eb0ba464b0e505f6ac11cb41502d/noir-projects/noir-protocol-circuits/crates/types/src/abis/private_circuit_public_inputs.nr#L53
https://github.com/AztecProtocol/aztec-packages/blob/d4921a032a56eb0ba464b0e505f6ac11cb41502d/noir-projects/noir-protocol-circuits/crates/types/src/abis/private_call_stack_item.nr#L59
https://github.com/AztecProtocol/aztec-packages/blob/d4921a032a56eb0ba464b0e505f6ac11cb41502d/noir-projects/aztec-nr/aztec/src/context/private_context.nr#L488

I can think of some potential optimisations:

When a call is made, don't hash the entire public inputs. I'm sure that only a subset of this data that can be hashed (and actually I thought we were only hashing a subset, so this is a pleasant surprise), whilst ensuring the call can't do anything malicious. E.g. just hashing the call_context, tx_context, args_hash, returns_hash, and maybe side_effect_counters? Maybe we can get away with just hashing the call_context, args, and returns? It feels to me like the calling app only needs to validate this info, and not any of the side effects created by the called function. The kernel circuit can unpack the rest of the PrivateCircuitPublicInputs to validate the side effects, counters, the consistency of the header.

Aside, it doesn't look like the call_context conveys the gas limits that are being forwarded from the calling function to the called function. Where is that info? Hopefully not in the TxContext?

We can go further, and change the "topology" of how the data is hashed, so that hashes of some fields can be precomputed.

E.g. hashes of zeros (e.g. if there are no return values for a function call).
If the function call is known at compile time, many of the hashes of data in the PrivateCircuitPublicInputs can be precomputed ahead of time.

E.g. the example in this thread, of a token transfer: precompute hashes of the contract address (if that's not circular and impossible), function selector, whether it's a delegate/static call.
Also, maybe we can pre-compute hashes of zero args, if we know not all args will be used by a function call. Similar for returns. That might require structuring args hashing and returns hashing as a merkle tree, instead of as a flat list, so that subtree roots of zeros can be precomputed.

I guess we're not using poseidon yet, because it's still inefficient? That'll speed things up nicely.

cc @LeilaWang @LHerskind - not sure whose remit this falls under :)

When a call is made, don't hash the entire public inputs. I'm sure that only a subset of this data that can be hashed (and actually I thought we were only hashing a subset, so this is a pleasant surprise), whilst ensuring the call can't do anything malicious. E.g. just hashing the call_context, tx_context, args_hash, returns_hash, and maybe side_effect_counters? Maybe we can get away with just hashing the call_context, args, and returns?

I've been looking into this and I see that we call hash on private call stack item in 2 places:

first one is in the app circuit,
and second time in the kernel.

And it looks that in the kernel it checks that the hash which traveled all the way from app circuit matches the computed hash. I would need a feedback from someone who knows the kernel's better to check whether we could optimize this.
@iAmMichaelConnor do you have a clue here? If not I would wait for Alvaro to come back and bother him on Monday.

It's a good idea! We only need to check call_context, args_hash, returns_hash in PrivateCircuitPublicInputs. Actually we don't even need to hash them anymore, as the data will be a lot cheaper after switching to databus. We can update the struct to be:
struct PrivateCallRequest {
  contract_address,
  function_data,
  call_context,
  caller_context,
  args_hash,
  returns_hash,
  start_side_effect_counter,
  end_side_effect_counter,
}

Good point re the data bus.
Why can't the PrivateCallRequest be:
struct PrivateCallRequest {
  contract_address,
  function_data, // not sure what's in here?
  call_context,
  // caller_context, // not this
  args_hash,
  returns_hash,
  // start_side_effect_counter, // not this
  // end_side_effect_counter, // not this
}

I figured the other data that I've commented-out is available to the kernel circuit through other public inputs?

They need to be in the call request because they are the data the caller expects in each nested call.
function_data: contains function_selector and is_private. It needs to be specified in the request so that the kernel can check that a nested call/function is indeed the request is for.
caller_context: it's already in the current call request. It contains the caller's contract address, is_static, and the storage contract address and msg_sender (both zeroed if it's not a delegate call). It's set by the caller and verified by the kernel. It needs to be in the request so that a kernel can verify a nested call's msg_sender, storage contract address, etc.
start and end counters: they need to be in the request because the caller has to enforce the counter range of a nested call, which affects the order of the side effects from the caller and from the nested call. If they are not checked, then I can basically move a nested call, i.e. I can pretend a child function is called after the caller's 3rd side effect instead of the 1st.

@LeilaWang, for public calls, we are currently hashing PublicCircuitPublicInputs in its entirely, similar to the private inputs that does not really seem necessary.
As part of #7285, I use
        pedersen_hash([
            self.contract_address.to_field(),
            self.public_inputs.call_context.hash(),
            self.function_data.hash(),
            self.public_inputs.args_hash,
            self.public_inputs.returns_hash,
            self.public_inputs.start_side_effect_counter as Field,
            self.public_inputs.end_side_effect_counter as Field,
        ], GENERATOR_INDEX__CALL_STACK_ITEM)

for the private call stack item hash. And for public I was thinking that:
std::hash::pedersen_hash_with_separator([
            item.contract_address.to_field(),
            item.public_inputs.call_context.hash(),
            item.function_data.hash(),
            item.public_inputs.args_hash,
            item.public_inputs.returns_hash,
            item.public_inputs.start_side_effect_counter as Field,
            item.public_inputs.end_side_effect_counter as Field,
            item.public_inputs.start_gas_left.da_gas as Field,
            item.public_inputs.start_gas_left.l2_gas as Field,
            item.public_inputs.end_gas_left.da_gas as Field,
            item.public_inputs.end_gas_left.l2_gas as Field,
        ], GENERATOR_INDEX__CALL_STACK_ITEM)

Should do the job. Very similar values, mainly with the gas values as well, but I don't know if they are actually needed like this. I don't really know about something like the hashes etc. But maybe you or @dbanks12 would be able to provide more data on if this is a fair change?

For public call, we don't need to include:

end_side_effect_counter: it's always zero. I want to remove it at some point.
returns_hash: don't see we use a public function's returns_hash anywhere 🤔
And the following because the function making the public call request doesn't care about these, and the public kernel computes or checks them in a nested call against the previous kernel's public inputs:

start_gas_left
end_gas_left

But looking at the code


fix: vuln remediation

fix: vuln remediation

I was unable to run tests - got errors:
"error="databricks: not implemented"


CodeLens doesnot load unless a change is made to the file

dotnet --info
.NET Command Line Tools (2.1.2)
Product Information:
Version:            2.1.2
Commit SHA-1 hash:<PHONE_NUMBER>
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.16299
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\2.1.2\
Microsoft .NET Core Shared Framework Host
Version  : 2.0.3
Build    : a9190d4a75f4a982ae4b4fa8d1a24526566c69df
VSCode Version : 1.19.0
C# Extension Version : 1.13.1
Steps to reproduce
Open a folder in code
Expected  behavior
CodeLens appears when omnisharp starts
Actual behavior
CodeLens doesnot appear untill there is some change to the file or we switch between files.

My bad.I just noticed that after omisharp starts CodeLens takes some time before loading.


Import / merge newer less code

Less v481 and v490 are out now.  Look at integrating changes from those versions (some of which we already have as we've shared code back and forth.)

Oh wait, only 481.  Doh.

Reviewing the changes, almost all of them are just incorporations of work I already did for this version.

I'm closing this for now.  We should reevaluate in the future against newer versions of less


Incorrect data being updated

So this is a bit of a weird one, and I not entirely sure it is not a bug in my code.
Database:
const database = new Loki(`${appRoot}/data/app_db.json`, {
    autoloadCallback: autoloadCallback,
    autoload: true,
    autosave: true,
    autosaveInterval: 4000
});

Express API:
router.put('/:id', (req, res) => {
        const { id } = req.params;
        const { oid, displayName } = req.user;
        const item = req.body;

        item.updatedBy = displayName;
        item.updatedByOid = oid;

        const put = new Promise((fulfill, reject) => {
            try {
                const collection = database.getCollection(type);
                const result = collection.findOne({ '$loki': parseInt(id, 10) });
                // const result = collection.get(id);
                if (result) {
                    const updated = Object.assign({}, result, item);
                    collection.update(updated);
                    fulfill(updated);
                }
            } catch (ex) {
                reject(ex);
            }
        });

        put.then(item => res.status(200).send(item))
            .catch(error => console.error(error));
    });

I am using Lokijs to store data from a React website. I instantiate Loki as above and pass the database object to the Express router. It is accessed by three endpoints simultaneously (ie /api/applications, /api/review and /api/finalise - all running the code above and reading/writing to the same collection).
I find that if I update a record ($loki = 1) and then update a second record ($loki = 2) and then update the first record again the database starts to return the wrong data from the get() function (which is used by update(). The data is correct, the ID supplied is correct, but what comes back is incorrect. I have successfully overwritten all my records by doing this update repeatedly.
I do not believe the issue is in Lokijs, but could my usage be causing this? I have a single instance of Loki on my server and am using getCollection() on the same collection across three classes. I could not find a use case or any warning this might be a problem in the documents.

I refactored my code to have a central database class that simply uses find, insert and update and I call that from my api code. The issue seems to have gone away now. I think I was treading on my own toes doing all the work in a single function.


Add support for PHPUnit 6

This isn't as big a change as it looks. Most of the changed files are adding a switch to PHPUnit configs and updating composer.json files. The vast majority of test case changes are adding assertions to tests which previously did not make assertions, or annotating tests as not performing assertions where applicable. In the diff, I'll call out important things to note.

Other workaround was found. This isn't needed right now, though I may bring it back around in the future!


Matched name slot content should remove slot attribute?

When a named slot is matched and preprocessed by WebC, the slot attribute should be removed lest it be processed in the browser as a client side slot.
https://www.11ty.dev/docs/languages/webc/#named-slots

Also worth thinking about: is there a way to both pre-process a slot in WebC and keep a slot attribute around for use as a client-side slot?
<!-- THIS IS NOT REAL WEBC SYNTAX -->
<img slot="left-client" webc:slot="left-server">

It may be more straightforward to use props for this? e.g. <img @slot> for the WebC-only slot and <img slot> for the HTML attribute.