WIP Factoring the script to bring up single node ipv6 k8s

Signed-off-by: Serguei Bezverkhi<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: sbezverk
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbezverk: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
31ba102a4bf8538927eb570c6f1938a3db5c22b3
link
/test e2e-bookInfoTests-trustdomain

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
31ba102a4bf8538927eb570c6f1938a3db5c22b3
link
/test e2e-bookInfoTests-trustdomain

prow/istio-pilot-multicluster-e2e.sh
31ba102a4bf8538927eb570c6f1938a3db5c22b3
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
31ba102a4bf8538927eb570c6f1938a3db5c22b3
link
/test e2e-bookInfoTests-trustdomain

prow/istio-pilot-multicluster-e2e.sh
31ba102a4bf8538927eb570c6f1938a3db5c22b3
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
31ba102a4bf8538927eb570c6f1938a3db5c22b3
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-trustdomain.sh
31ba102a4bf8538927eb570c6f1938a3db5c22b3
link
/test e2e-bookInfoTests-trustdomain

prow/istio-integ-k8s-tests.sh
31ba102a4bf8538927eb570c6f1938a3db5c22b3
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
66b18f9f9ef1e889e9c4d2150a567eee8580234c
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
66b18f9f9ef1e889e9c4d2150a567eee8580234c
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
66b18f9f9ef1e889e9c4d2150a567eee8580234c
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
66b18f9f9ef1e889e9c4d2150a567eee8580234c
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
09dc78e701fc7f4fc183796184304735cae6dce1
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
66b18f9f9ef1e889e9c4d2150a567eee8580234c
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
b32d27189f99d97f95f5bb522344d5969eafd9d6
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
66b18f9f9ef1e889e9c4d2150a567eee8580234c
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
707bf8b57acc84070e21e952cdde3dd483839984
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
66b18f9f9ef1e889e9c4d2150a567eee8580234c
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
a544a5c625ec1cde5df2b1821b97ffad359b9720
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
a544a5c625ec1cde5df2b1821b97ffad359b9720
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
a544a5c625ec1cde5df2b1821b97ffad359b9720
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
a544a5c625ec1cde5df2b1821b97ffad359b9720
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
6de3ff535feab443f5109b24dfb2ae45d1824ba8
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
a544a5c625ec1cde5df2b1821b97ffad359b9720
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
e9938824674b0a0fdbc4706e4379261133b8742b
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbezverk: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
e9938824674b0a0fdbc4706e4379261133b8742b
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
e9938824674b0a0fdbc4706e4379261133b8742b
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Closing this - will merge the one in tools.


lib/cmsis_rtos_v2: Fix overflow in osKernelGetInfo()

If any of the Zephyr version numbers went beyond 99, the "%2d" printf
specifiers would expand to fit and the string would run over the
memory on the stack used for os_str[].
Recent GCC versions (remember native_posix and x86_64 use the host
compiler) were actually detecting this and correctly issuing a warning
(but only if the 3-digit char value would overflow the actual array
size!), which was breaking sanitycheck for me on Fedora 28 and Ubuntu
18.04 build hosts.  Pretty impresive warning.
As it happens this was wasteful anyway; we were spending bytes on the
stack (and in rodata to store the constant which, and the cycles
needed to copy it into place on the stack where it would be
overwritten immediately) when we could just snprintf() directly into
the buffer the user gave us.
Signed-off-by: Andy Ross<EMAIL_ADDRESS>

Codecov Report

Merging #12216 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #12216      +/-   ##
==========================================
+ Coverage   48.25%   48.25%   +<.01%
==========================================
  Files         293      293
  Lines       44130    44128       -2
  Branches    10591    10591
==========================================
  Hits        21296    21296
+ Misses      18567    18565       -2
  Partials     4267     4267

Impacted Files
Coverage Δ

lib/cmsis_rtos_v2/kernel.c
6.25% <0%> (+0.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56d144c...66d0851. Read the comment docs.


Program stops after '$client = Client::getInstance();'

So I am trying completely new to this library, and when I tried to run the example code, it did not work, I am trying to find a php error log, but I have not yet found one, Im running IIS on php 7.0 (windows server 2019) The reason I know it crashes on $client = Client::getInstance(); is because i just echo numbers and see what line crashes, Sorry for the vaugeness, but I am really stuck on this one. Thanks.

Bump

I made a mistake, too. Have you solved it

Strict Standards: Declaration of JonnyW\PhantomJs\DependencyInjection\ServiceContainer::load() should be compatible with Symfony\Component\DependencyInjection\Container::load($file) in D:\wamp\www\wcphp\vendor\jonnyw\php-phantomjs\src\JonnyW\PhantomJs\DependencyInjection\ServiceContainer.php on line 21


setup instructions should tell the user what to expect after running the helloworld program

The Mac and Linux setup instructions tell the user to compile and run the helloworld program. For the sake of completeness, we should tell the user to expect the program to print "Hello, world." and exit normally.
Found while looking at #1388.

Closing as we no longer have them do this.


Lines Ordinal Scale fix

This fixes issue #522. The isFinite function was added to fix #91. Because of directly using isFinite we ignore Ordinal values for y attribute of Lines.
@rmenegaux

looks good @ssunkara1


web slowness

From some time i observe frontend slowness also api timeputs:
Describe the bug
to get webpage now i need to wai ~8sec:

in logs i dont see anything.
Version
v0.45.14
changedetection.io needs your support!
Desktop (please complete the following information):

OS: [e.g. iOS] windows/andorid
Browser [e.g. chrome, safari] brave/chrome/opera...
Version [e.g. 22]

You dont say anything about what you were doing at the time in the application, if you are using browsersteps - while you are configuring a new browserstep setup, the application is "single threaded" and will make the other requests wait while it connects to the browser

when i logged no jobs were running


Implemented YAML configuration

[closes #1]
Example YAML:
# config/fixturator.yml

excluded_models:
- Secret
- DelayedJob

included_models:
- User

excluded_attributes:
- secret_attribute
- ssn

model_level_excluded_attributes:
  User:
  - middle_name
  - drivers_license

included_models and excluded_models seem to me in opposition to each other. What is the intended behavior for the following case:
We have the following ActiveRecord models:

Apple
Banana
Citron
Durian
Elderberry

This is our fixutator file:
excluded_models:
  - Citron

included_models:
  - Apple
  - Banana

Which of the five models will have fixtures generated when running the task?

Glad you asked! I think this is a problem in my naming of "included". Internally (in the code) I have it as "only", which is more clear - but I'm not sure how to translate that to the config file.
The only models selected would be those that are included.
If you had this:
excluded_models:
  - Citron

included_models:
  - Apple
  - Citron

it would only generate fixtures for Apple.

Okay, now that I have a better understanding of the intent, I think we should scrap the notion of excluded_models altogether. We're only creating a situation where the config file could fight itself internally. If we drop the opt-out model, the opt-in model becomes more clear.
models:
  - Apple
  - Banana
  - Citron:
    excluded_attribues:
      - seed_count

The models key is not required, and could be assumed. I put it here to have a sense of grouping in case global settings are to be added at a later time.
If this is truly meant as an opt-in solution, which I think makes the most sense, especially in our use case, we should double down on that and drop support for opt-out, because I would argue our implementation does not behave as expected.


Incorrect AQ scoring of game.

Latest AQ version, running on Sabaki 0.33.2, Windows 10, CPU i5-6500, GPU Nvidia GTX 970

Reproduction procedure.
I played this game against Leela 0.11 on OGS with Chinese scoring 7.5 Komi in config file and sabaki. The end game score was W+0.5. However AQ (black) had winrate about 99% and kept playing moves.
Here is the game:
https://online-go.com/game/11644066
SGF : https://online-go.com/api/v1/games/11644066/sgf
Load Sabaki 0.33.2 on Windows, attach AQ with following config file, no commands within sabaki and run the game.
https://i.imgur.com/qwOWir0.png
https://i.imgur.com/ZuWfW8T.png
https://i.imgur.com/H2hU6OT.png
https://i.imgur.com/vbjFn4j.png
At move 305, AQ is showing 93.6 win victory when points are W+1.5

AQ config file:
### Hardware setting ###
# Set number of 1-8 for 'gpu count'.
# 'thread count' is number of the total usable threads.
-gpu count =1
-thread count =4

### Time contorol setting ###
-main time[sec] =0
-byoyomi[sec] =7
-emergency time[sec] =1

### Thinking setting ###
-japanese rule =off
-komi =7.5
-symmetrical index =8
-use pondering =on
-mimic go =off
-never resign =off

### File settings ###
# Use 'self match' mode on console for debug.
-self match =off
-save log =on
-pb path =pb
-resume sgf path =

### Cluster settings ###
# Not need to change.
-master =off
-worker =off
-worker count =1

As described in README, the latest version was trained with Komi = 6.5. It may misunderstand endgame situation, but it is not a bug.


GlobalHookMode.FINAL

Hello,
I played around with it. But I run into problems.
Indeed, it stops forwarding the key events to other applications. But now all keys are blocked.
It would be better, if only keys which are registered, will be blocked for other applications.
I'm testing with Windows 10 and  [Windows]+[G] for example.
Please have a look.

Hello @luecking, sorry for the late reply.
There are two ways to be doing this. One is unfortunately not so easy to do, with the current design of the library, the other is much more less elgant:
Option A: Would be that every event (similar to e.g. events in JavaScript) get a "preventDefault" method. That way you would be able to call the method in your handler, which would prevent forwarding the message to further hooks. That way you could for each event decide, if you want to forward it or not. In the design of this library, it was crucial to not block the input event handling, as otherwise inputs might be lost. Thus the decision was made to store every event in an inputBuffer instead, continue processing the native input event, while another Java thread processes the inputBuffer. This means, also regardless of "how long" the processing of your eventhandler takes, no inputs will be skipped. This also means, when your event handler is called, the input processing is already processing the next hook, so to implement a "preventDefault" method, would require a redesign of big parts of this library.
Option B: Currently every keystroke is captured by the library and forwarded to your handler. This is also the way the low-level system hook is inteded to be used natively. There is no way of just capturing events of single keys. Rather you ignore the input events you are not interested in. This means also my library does not know what keys you are actually interested in, so "what keys you registered". When it comes to the "FINAL" setting, one could add a new "key map" that defines the keys for which the events should NOT be forwarded. This adds another level of complexity: which keys should be forwarded and which keys shouldn't? In your example you said you don't want to forward [Windows] + [G]. Both are separate input events. This means, what to do? Blocking all [Windows] key event inputs is not desired. You would have to first block the [Windows] key fowarding, and if any other key than [G] is pressed, re-fire the forwarding, which is not possible using these low-level hook methods!
In short: I am not completely satisfied with both solutions, which is why I would like to put this issue on "inactive" for now. Please feel free to come up with any better idea or submit a pull request.
Sorry, hope this helps anyways. Thanks & regards, Kristian


Wake1st/earliest unhandled branch

Added a "find the earliest unfinished node" functionality. It works by updating a dictionary full of TreeNodes, each with an id and child id's. When the button is selected, it searches recursively through the tree, storing the earliest node it can find. It returns that node after searching the whole tree. A node is unfinished/unhandled if it:

lacks outgoing connections
has unconnected outgoing connections (the node it's calling doesn't exist)

Updated the docs (not certain if the photo will work, I just made up the url which should exist after merging).

also did a little bit of "cleanup" (some whitespace editing), but that's just aesthetics.

Let me know if there are some things you want me to add/update.

This is great!
Thanks for contributing!
I'll take a look and comment/approve when I get a chance next.

I'm seeing some error messaging from the tree when deleting already connected dialogue nodes.
Would love to see it handled before I full commit.

sure! I'll take a look at it when I can.


feat: Custom readers and writers

Same as #770 , but this version removes all the hardcoded readers and writers in the weaver and gets them from the NetworkReader and NetworkWriter instead using attributes.
This eliminates the need to modify the weaver every time we add a new type to NetworkReader and NetworkWriter.
To use it for your own classes,  declare a [NetworkReader] and [NetworkWriter] function to handle your type.  for example:
public partial struct Quest
{
    public ScriptableQuest scriptableQuest;

    public int progress;
    public bool completed;
    ...
}

And write a custom reader/writer:
[NetworkWriter]
public static void WriteQuest(NetworkWriter writer, ScriptableQuest scriptableQuest) {
     writer.Write(scriptableQuest.Name.GetStableHashCode());
}

[NetworkReader]
public static ScriptableQuest ReadQuest(NetworkReader reader) {
    int hash = reader.ReadInt32();
    return ScriptableQuest.dict[hash];
}

Another example,  say you want to be able to use Url:
[NetworkWriter]
public static void WriteUrl(NetworkWriter writer, Url url) {
     writer.Write(url.ToString());
}

[NetworkReader]
public static Url ReadUrl(NetworkReader reader) {
    string txt = reader.ReadString();
    return new Url(txt);
}

Now you can use Urls as syncvars,  inside synclists,  as parameters in rpc methods and in messages

This is literally the most useful feature of the past month. This simplifies so many things. SyncDicts are nice, SyncSets are nice, etc, but the implications of this PR in particular are wild:

you can modify serializers for existing types without being able to edit their source code
you can transparently implement compression on SyncVars, RPCs, Commands, etc
you can [SyncVar] structs that you define in other assemblies by defining readers and writers for them
we no longer need to go register new type readers and writers in the weaver
I'm sure there many more uses that I havent thought of.
Please merge this, this is an excellent idea, and an excellent execution.

that's better.
here is what I still don't like: the Weaver weaves structs automatically. it could weave classes automatically (it does for MessageBase), but for classes we would need [NetworkWriter] then.
OR: if we allow the weaver to weave classes automatically, then there would be two ways to do it.

@vis2k   the weaver does weave classes automatically.   In fact,  if you change that test and remove the { get; set; }   the test passes even on current mirror.
The purpose of this PR is not to weave classes, but to make it so that you can have a different behavior than just serializing all fields.

I need to come up with  way to work with asmdefs

Closing because this does not work with multiple assemblies


Verify: allow fault checker to span more than 1 segment

As of now, the flat receipt verification only allows the fault checker to span 1 segment. It's possible that the fault checker could span more than 1 segment as we make changes in the future so we should allow the fault checker to span more than 1 segment.

closed by #824


ensure results count is updated when addresses change

fix for #949 (updated to check that filterconfig is initialised)

@grs could we enable web console tests that verify this fix within this PR? (No. 26. https://github.com/EnMasseProject/enmasse/issues/824)

@tkratky yes, can you confirm the tests? That issue has three, but two seem to be the same one (line 106 is not disabled). The second test is now marked as also failing due to another unopened issue so I have left that disabled but revised the comment.

@grs : enabled tests for brokered as well, so now everything looks fine, thank you!

@tkratky doh! sorry, got confused by the similar filename and tests!


Added info about what winml runs on by default

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/faq.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


ReadSharp using old version of NReadability and SgmlReader

Kindly update with latest portable ports of NReadability and SgmlReader.
Thanks
prabhu

SgmlReader, last update 2013. NReadability 2014. There are no new updates.


Fix gradlew execution for non-standard systems

Change the shell requested by gradlew to bash, as it appears the syntax used by the wrapper script does some Bash-specific things which fail when it is run on a system where /bin/sh does not point to a Bash shell.
Resolves: #2903
Contributor Checklist

[x] Review Contribution Guidelines
[x] Sign Gradle CLA
[ ] Link to Design Spec for changes that affect more than 1 public API (that is, not in an internal package) or updates to > 20 files
[x] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[ ] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[ ] Ensure that tests pass locally: ./gradlew <changed-subproject>:check

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation including proper use of @since and @Incubating annotations for all public APIs
[ ] Recognize contributor in release notes

The proposed change modifies the checked-in Wrapper of Gradle core. Were you intending to build Gradle itself and it failed for you? Or was the intention to change the Wrapper script that is generated whenever you run the wrapper task? My guess is the second one.

Ah, yes, my intent was to modify the gradlew script that gets generated when you run gradlew init on a new project.

The shell was intentionally changed to sh with the PR https://github.com/gradle/gradle/pull/621. If there are still pieces in the script that are bash-specific then we should find an alternative solution compatible with sh.

There seem to be a lot of pieces not working properly with the sh that is default on Solaris 5.10 since it's not a POSIX shell. For one thing, it isn't even possible to use $(command) to avoid spawning a subshell, you have to use backticks for that. Fixing the first offending line by changing:
i=$((i+1))

To:
i=`expr $i + 1`

only uncovers that the next thing that fails is the case statement just below:
case $i in
    (0) set -- ;;
esac

This complains about ./gradlew: syntax error at line 144: (' unexpected`
It seems that /bin/sh is not a very reliable way to get the shell you want for a script of moderate complexity (such as gradlew). I could try and fix everything else I find (stay tuned!), but I wonder if it might actually help portability by just saying bash and then not having to accommodate the lowest common denominator sh out there. It would let us jump through fewer hoops inside the wrapper script and might make for more readable / more powerful script code.
But I'll see exactly how much would need to change for the wrapper script to run more happily on Solaris.

The changes required to make the wrapper script work for Solaris 5.10 were fewer than I expected: see 69e73de9a390a33716e1e343e292f937632e9c91. I can't say with 100% certainty that the case statement changes in the Cygwin block won't break on Cygwin but I assume that since this should be more standard, Cygwin should not have an issue with them...

Cleaned up the branch, and rebased into a single commit: 01c8f438fefb8cc4eecc908e4dfcd2db387289bf

Is this PR okay for inclusion in the Gradle upstream? If not, what would you guys like to see done here?

No worries, it was on us for taking so long to look at this PR.


Remove UrlMatcherInterface from main container

I think we should remove UrlMatcherInterface from main container because this is stateful service.
As solutuion we can pass UrlMatcherInterface object in a controller with RequestInterface as an item of attributes. Or as subitem with route params ( #55 )

Where should URL matcher instance be created?
How would you change these?

https://github.com/yiisoft/app/blob/master/config/params.php#L78
https://github.com/yiisoft/router-fastroute/blob/master/src/UrlGenerator.php#L28
https://github.com/yiisoft/router/blob/master/src/Middleware/Router.php#L19
https://github.com/yiisoft/yii-debug/blob/master/src/Collector/RouterCollector.php#L21
https://github.com/yiisoft/yii-demo/blob/master/src/Command/Router/ListCommand.php#L21

Where should URL matcher instance be created?

If the Matcher is independent and stateless, then something like this is expected:
interface UrlMatcherInterface
{
    public function match(RouteCollection $routes, ServerRequestInterface $request): MatchingResult;
}

But we have Matcher that dependeds on the route. This means that you need to receive it directly from a router.
Here, by the router, i mean a container that contains all services necessary for routing related to only this router.
Let it be RouterInterface, which we don't have.

What should UrlMatcherInterface do?
From description:
/**
 * UrlMatcherInterface allows finding a matching route given a PSR-8 server request. It is preferred to type-hint
 * against it in case you need to match URL.
 */

Why does Matcher include the getCurrentRoute() method? Shouldn't it be in the MatchingResult?
Regarding getLastMatchedRequest method same question.
Why do we take the collection of routes from the matcher and not from the router?

How would you change these?

1 https://github.com/yiisoft/app/blob/master/config/params.php#L78
2 https://github.com/yiisoft/router-fastroute/blob/master/src/UrlGenerator.php#L28
3 https://github.com/yiisoft/router/blob/master/src/Middleware/Router.php#L19
4 https://github.com/yiisoft/yii-debug/blob/master/src/Collector/RouterCollector.php#L21
5 https://github.com/yiisoft/yii-demo/blob/master/src/Command/Router/ListCommand.php#L21

1 - I'm not sure i know why it's there, but i'm guessing for detect the last matched route. In any case some thing like a MatchingResult should be contained in Request->attributes.
2 - URI from Request required but not a Matcher. In fact, after reading this, you should be concerned about other questions.
3 - RouterMiddleware should require the RouterInterface and take Matcher from there.
4 - Need a routes collection here, not matcher. RouterCollector should require the RouterInterface and take RouteCollection from there.
5 - Need a routes collection here, not matcher. ListCommand should require the RouterInterface and take RouteCollection from there.


⚠ Bofrost.lu has degraded performance

In b492303, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1408 ms

Resolved: Bofrost.lu performance has improved in 6308a8b after 7 minutes.


Updating values

Hi, I have some problems updating the values because it´s the first thime i use Git
Could you type the code whit blank spaces to paste my information?
Thanks

which values refer ?. c_user and xs in the config file can be edited with any text editor

Thanks, i did it :)
Now I have problmes with scraping,


Created A Page that Explains Closure and Pure Functions with Carefully Chosen Examples

Hi Freddie and the Team,
I have created a page of content that would help students understand the concepts of closure and what pure functions are about.
Please let me know what else I could add / or delete to make it better.
If you would give me the green light to go, I can then create some tutorial activities extended from those contents, and further exercises.
Cheers,
Tianxiao

In my commit ed59aa2, I adapted an exercise question I saw on Exercism. I made a contrasting example on using object-orientated way and using the functional method to create a matrix generater.

I deleted the gitignore file. Would you like to try again?

I would merge this but it is saying:

This branch has conflicts that must be resolved
to resolve conflicts before continuing.

I don't know how to do that immediately


Revert "Bump actions/upload-artifact from 3 to 4"

Reverts fsprojects/FSharp.Control.TaskSeq#206

This should fix the fact that test reports are not generated. I.e., we see this on all of the recent PRs, including the #206 that we are reverting, which seems to have introduced this issue.

Yep, this solves it, it works. Reported here: https://github.com/dorny/test-reporter/issues/343.


feat(WKWebView): [ios] RNCWKWebView send headers on all page requests

This enables the WKWebView implementation to send the headers set on the source prop on every page load request rather than just the initial load request.
Fixes #4, #68, and #25

Hello, thank you for this, I've seen it requested a lot, could the same be done for android ?

Hey @Titozzz thanks for your quick reply. It was my understanding that android would send through the headers for all GET requests. Is that not right?
Understandably this is a fairly controversial change/implementation and a breaking one as well. Should I add a prop to RNCWKWebView to enable this behaviour?

If you just align iOS functionality to android, it might be a bugfix. If we change behavior, we can do breaking change easily with semver anyway so don't worry too much about it.

Note that Android does not set headers on subsequent page loads. This will need to be done for Android as well.
@Titozzz Do you want to require that we do this for Android before merging or are you okay merging with iOS only?
Secondly, do we want to add a feature flag? I think it's fine to publish without a flag, but it is a breaking change.

If there is a way to have this on android at the same time it would be awesome, as the difference between the two would be quite annoying I think ?
If we do both at the same time I don't think feature flag is necessary, but if it's only on iOS it would prob be better

@jamonholmgren I like that. Makes it explicit and makes people think about which headers they are attaching for which requests.

@jamonholmgren this is a nice solution and I'm happy to update the PR.

Is there a way to achieve the same behavior on android?

On Android, it looks like we can set custom headers by overriding shouldInterceptRequest (see here and the Stackoverflow answer I saw first).
We should probably make the behavior the same across iOS and Android.

@mattycas : It would be nice to know the reason why this was closed, since this had active discussion around it? Was there a separate PR which caused this to be closed?

I'd love someone to champion this PR and move it forward. Any volunteers?


Runtime packages

Now, we have symbols from AppSource Apps and Microsoft Apps - we need to go the next step.

[ ] How does partners generate and publish runtime packages to NuGet easily
[ ] Document how to share NuGet packages with other partners
[ ] Document how to trust partner NuGet packages (using PATs, OAuth and federated credentials)

We have a flow that’s working, more or less.
I’ve updated the repo that @freddydk created for Runtime generation. I reworked it so the Runtime generation can now be triggered just by specifying the repo name.
The action grabs the latest release from the specified repo and resolves all dependencies using the internal NuGet feed. Once the runtimes are generated, the resulting NuGet package is uploaded to a second organization. From there, we invite our partner and grant them access to the runtimes.
This setup has a few drawbacks. First, everyone you invite can see each other, which isn’t ideal. Second, the UI is clunky—you have to use PowerShell, and there’s no GUI. Third, it’s horribly inefficient. We’re building some of our apps from versions 21.0 to 25.1 in every language for every release. That’s a ton of wasted compute cycles. But as long as Microsoft is footing the bill, I’m not too concerned. If it ever gets too expensive for them, they can deal with fixing the runtime situation themselves.
Another quirk: you need a separate BC Runtime repo for every App repo. If you don’t, builds from different apps might cancel each other out. That said, since Microsoft is paying, the best strategy might be to create a new organization for every App repo. This would let you parallelize runtime creation even further, though I’m not sure how many organizations you can actually create before hitting a limit.
Honestly, it’s a waste of time trying to work with this runtime mess. Microsoft needs to stop chasing AI hype and focus on building a proper framework—one that allows partners to spend their time delivering value to customers instead of dealing with these problems.


Always error asynchronously from parseAsync method

Closes #411

Coverage remained the same at 100.0% when pulling 6dc1e46db53432712b17114447eaeed71673a1b3 on juanjoDiaz:always_error_async-from_parseAsync into b57715b300eb17e50fdc332fb969860f96d31321 on zemirco:master.

Once you merge #413 I'll rebase and we can merge this.

@knownasilya this is ready to go
Not to release. Since we can't release until 5.0 now.


Some nodeSelector and tolerations use global values

Bug report
The restructured Helm chart of 1.9.0 uses "global" nodeSelector and toleration values at some places (e.g. cilium-operator-deployment.yaml). Specific values are not always used.

@mtneug could you please post links to specific lines and explain if/how is this problematic?

@errordeveloper basically it means that if you use the operator.nodeSelector configuration option in Helm, it will not take effect for the operator containers. See the options and how they are used below, seems like operator and preflight both have this problem:
$ git grep nodeSelector install/kubernetes/
install/kubernetes/cilium/README.md:| clustermesh.apiserver.nodeSelector | object | `{}` |  |
install/kubernetes/cilium/README.md:| etcd.nodeSelector | object | `{}` |  |
install/kubernetes/cilium/README.md:| hubble.relay.nodeSelector | object | `{}` |  |
install/kubernetes/cilium/README.md:| hubble.ui.nodeSelector | object | `{}` |  |
install/kubernetes/cilium/README.md:| nodeSelector | object | `{}` |  |
install/kubernetes/cilium/README.md:| nodeinit.nodeSelector | object | `{}` |  |
install/kubernetes/cilium/README.md:| operator.nodeSelector | object | `{}` |  |
install/kubernetes/cilium/README.md:| preflight.nodeSelector | object | `{}` |  |
install/kubernetes/cilium/templates/cilium-etcd-operator-deployment.yaml:{{- with .Values.nodeSelector }}
install/kubernetes/cilium/templates/cilium-etcd-operator-deployment.yaml:      nodeSelector:
install/kubernetes/cilium/templates/cilium-operator-deployment.yaml:{{- with .Values.nodeSelector }}
install/kubernetes/cilium/templates/cilium-operator-deployment.yaml:      nodeSelector:
install/kubernetes/cilium/templates/cilium-preflight-deployment.yaml:{{- with .Values.nodeSelector }}
install/kubernetes/cilium/templates/cilium-preflight-deployment.yaml:      nodeSelector:
install/kubernetes/cilium/templates/clustermesh-apiserver-deployment.yaml:{{- with .Values.clustermesh.apiserver.nodeSelector }}
install/kubernetes/cilium/templates/clustermesh-apiserver-deployment.yaml:      nodeSelector: {{- toYaml . | nindent 8 }}
install/kubernetes/cilium/templates/hubble-relay-deployment.yaml:{{- with .Values.hubble.relay.nodeSelector }}
install/kubernetes/cilium/templates/hubble-relay-deployment.yaml:      nodeSelector:
install/kubernetes/cilium/templates/hubble-ui-deployment.yaml:{{- with .Values.hubble.ui.nodeSelector }}
install/kubernetes/cilium/templates/hubble-ui-deployment.yaml:      nodeSelector:


Overhaul Product Pages: auth, contractkit and deploy

📝 Changed routes:

/auth
/contractkit

(view full size)
(view full size)

/deploy

(view full size)

Commit f9ede1614e48e27202f3175f1bf522c282b23102 (https://thirdweb-7l12a1fj2.thirdweb-preview.com).


GraphiQL Collections ala Postman

https://www.postman.com/saleor-qa/workspace/saleor-qa/request/20521197-dbec96de-1ac9-4c2b-bca1-ac26b7d5e14a

[ ] pre-defined examples filled in the GraphiQL following the grouping done in the docs

Created an external GraphiQL plugin in the Saleor organization.


Add Dockerhub automated build integration #866

As stated in issue #866 I want to be able to have a badge which shows the dockerhub build status.

Is this duplicate of #856

Thanks for this PR. It does look like it overlaps with #856.
I like your the way this handles the 404 / not found case.
Could you add that to your branch for #856 @eddiewebb?
The tag build feature would be a great addition, but unfortunately we can't have a badge that is "unbounded" in time or number of requests. To support the tag feature, we'd need them to add an API that allows accessing this information more directly.
Also related: #886 #241

@paulmelnikow  added to #856, but checking for 404 which works for both invalid user and invalid repo (some reason docker hub returns valid JSON with invalid repo, but a html page for invalid user.

agree on busy, new look just committed.

Since this will need to be reworked, and we're tracking that in #935, I'll close this.


Roadmap for 6.x

Currently, I want to implement the following changes before releasing 6.x. More may still be added:
Integrate normalizr
This should, if done right, solve issue #6, #7, and #19 all together. This library originally assumed all FETCH responses came wrapped in a data envelope, but that assumption can't remain. Currently there is a workaround active in the master branch, but normalizr offers a more robust and recognizable solution to this problem.
To implement this, the following changes are needed:

[ ] Add normalizr as a dependency (probably) or a peerDependency (ideally)
[ ] Change FETCH action creators to take a Schema object
[ ] Change the saga to store the Schema object, and then denormalize the data. After that, it can dispatch one action for each collection. There will need to be a new action type (GOT_NORMALIZED_DATA), since FETCH_ONE_SUCCESS would require dispatching potentially a lot of actions, but FETCH_SUCCESS would store collections and parameters, which doesn't make sense.
[ ] Change the reducer to handle GOT_NORMALIZED_DATA
[ ] Investigate further to see if it's helpful to store the Schema objects in the store at any point (currently I think this isn't helpful)
[ ] Scrub references to id, using the schema's idAttribute instead.
[ ] Investigate FETCH_ONE, CREATE, and UPDATE to see how normalizr will be implemented
[ ] Investigate DELETE to see if normalizr needs to be implemented.

Handle response envelopes in a smarter way
Once normalizr is in, we'll be in a better spot to handle response envelopes. Currently there are two big issues with how it's handled.

'data' is assumed as the key holding the data, and if it's not present the payload is assumed to be the records.
The response envelope, if it exists, is stored in the awkwardly named 'otherInfo'.

I would like to do the following:

[ ] Use normalizr Schema to specify the shape of the response.
[ ] Specify a clever default that emulates the current behaviour as much as possible.
[ ] Store the response envelope, if it exists, in record.envelope (instead of record.otherInfo).
[ ] Deprecate record.otherInfo and remove it from documentation, but leave it as a key until 7.x or even 8.x (or forever, if 6.x is just so stable and great we don't need any more breaking changes).

Store response headers, and make them accessible
I really love http://www.vinaysahni.com/best-practices-for-a-pragmatic-restful-api, and it inspired the backend that this library was originally written to consume. In this document, he talks about how pagination may someday soon move to live in response headers, rather than in a data envelope. I'd love to support that. It will involve a breaking change to ApiClient.js however *(and by extension, any custom ApiClient implementations that library consumers have written).

[ ] Update ApiClient.js to return headers as well as response body. If possible, continue to handle responses that don't include the headers. I think the best way will be to return an object with the shape { headers, payload }, and if the return value isn't in that shape, assume it is a 5.x ApiClient that is only passing a payload.
[ ] Store the headers alongside the envelope in the collections store, and make them accessible in selectors.
[ ] Consider whether request headers should be stored alongside params in the collections store.
[ ] Consider how FETCH_ONE, CREATE, UPDATE, and DELETE may/may not need to persist response headers.

For future reference: given a Fetch API response object, you can convert the headers to a plain object like this:
Array.from(response.headers.entries()).reduce((obj, [key, value]) => {
  obj[key] = value
  return obj
}, {})

See also #65 for discussion about passing a parser to the ApiClient.
Renaming this issue because it probably isn't the roadmap anymore


C2-2734: Fix 404s

I switched this PR to Draft status, since the work in this PR is incomplete and requires further changes/testing before it can be merged.


Example in Getting-started doesn't work

I am using the automapper and it used to work nicely but not now it seems. I need the functionallity that you present in the "getting started guide", to add new properties to destination model.
If we run the code:
var objA = { prop1: 'From A', prop2: 'From A too', prop3: 'Also from A (really)' };

automapper
   .createMap('sourceType', 'destinationType')
   .forMember('prop1', function (opts) { opts.mapFrom('prop2'); })
   .forMember('prop2', function (opts) { opts.ignore(); })
   .forSourceMember('prop3', function (opts) { opts.ignore(); })
   .forMember('prop4', function () { return 12; })

var objB = automapper.map('sourceType', 'destinationType', objA);

instead of your result we get
{prop1: "From A"}
**and not **
{
"prop1": "From A too",
"prop4": 12
}
Also another problem is that if we have a nested object, which has another mapper and has null value we can't just use
              automapper.map('ItemDto', 'ItemModel', opts.sourceObject.item)
  });````

because it returns an empty object but we want the null value.

I managed to bypass this by using

```
.forMember('item', (opts: AutoMapperJs.IMemberConfigurationOptions) => {
             return opts.sourceObject.item ? automapper.map('ItemDto', 'ItemModel', opts.sourceObject.item) : null
  });
```

I second the first issue. Adding new members doesn't work.

Thanks for using AutoMapper and reportage those issues. I will have a look next week, on a vacation right now ;)...

Have fun!

I checked the first one, the example in the getting started guide does no longer work indeed. Ignoring a member completely ignores it, even if it was mapped from another property before. However, this works just fine for the example:
var objA = { prop1: 'From A', prop2: 'From A too', prop3: 'Also from A (really)' };

var fromKey = 'should be able to use mapFrom to switch ';
var toKey = 'properties and ignore a property as well';

automapper
    .createMap(fromKey, toKey)
    .forMember('prop1', (opts: IMemberConfigurationOptions) => { opts.mapFrom('prop2'); })
    .forMember('prop2', (opts: IMemberConfigurationOptions) => { opts.mapFrom('prop1'); })
    .forSourceMember('prop3', (opts: ISourceMemberConfigurationOptions) => { opts.ignore(); });

var objB = automapper.map(fromKey, toKey, objA);

expect(objB).toEqualData({ prop1: objA.prop2, prop2: objA.prop1 });

The part of adding new members does not work either, I just fixed that one ;) ...
I will have a look at the 'null object' and create a new release after that.

Hi @Duskfall @jrusinek ,
Just released v1.6.4 which should have solved your issues. Please let me know if it does not ;).
Cheers!


dataclass regression from 1.9 to 1.10

Initial Checks

[X] I have searched GitHub for a duplicate issue and I'm sure this is something new
[X] I have searched Google & StackOverflow for a solution and couldn't find anything
[X] I have read and followed the docs and still think this is a bug
[X] I am confident that the issue is with pydantic  (not my code, or another library in the ecosystem like FastAPI or mypy)

Description
This would pass in 1.9, but fails in 1.10. I don't think it should fail,
def test_is_builtin_dataclass():
    from dataclasses import dataclass
    from pydantic.dataclasses import dataclass as pydantic_dataclass, is_builtin_dataclass

    @dataclass
    class A:
        something: int

    assert is_builtin_dataclass(A)
    pydantic_dataclass(A)
    assert is_builtin_dataclass(A)  # Fails here

@PrettyWood Could you comment?
Example Code
No response
Python, Pydantic & OS Version
1.10

Affected Components

[ ] Compatibility between releases
[ ] Data validation/parsing
[ ] Data serialization - .dict() and .json()
[ ] JSON Schema
[X] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - construct(), pickling, private attributes, ORM mode
[ ] Settings Management
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

Worked around, still seems odd to me though


Disable Predict button on click.

On the home page (./templates/home-page.html), once the Predict button is clicked, it should be disabled so that multiple requests are not sent to the server.
Use client side JavaScript (JS) to handle this.
Steps:

Add an id to the Predict button in ./templates/home-page.html.
Create a new JS file at ./static/js.
Include it in the {% block head %} section of ./templates/home-page.html (example) after adding {% block head %}{% endblock %} to ./templates/base.html (example).
In the new JS file

Refer to the Predict button using const <element> = document.querySelector("#<element-id>").
Add an event listener with a click event to the button.
In the event listener, use <element>.disabled = true to disable the button.

@HarshKapadia2 I will do this task.

Go ahead @Haroonchik.
Please take note of the suggestions on PRs and commit messages that I gave you in PR #15.

@HarshKapadia2 Check, please  https://github.com/HarshKapadia2/one-or-two/pull/17

PR #17 merged!

Hey @Haroonchik, I am hosting a Hacktoberfest and Open Source session tomorrow. If you're interested, registration and further details are available here: https://bit.ly/otcHacktoberfest1


This API doesn't work at all

Honestly, ur StompClient API doesn't work at all, There is no response when I make the connection. Try it by urself

+1 this, doesn't work for me either. None of the delegates are called.

Yes, true.. none is working

Yeah nothing for me either


improvemen Provide the user with a suggestion to avoid th…

…e error.
Proposed changes
Issue Number: close #xxx

run buildall

run buildall

run buildall


Allow the cookbook to install EPEL on Alma Linux

Also, remove testing for CentOS 8 (use Stream instead).
Signed-off-by: Lance Albertson<EMAIL_ADDRESS>

Released as: 4.4.0


Single Image score

In my scenario, I need to compute the mAP.5:.95 metric for an individual image output.
I have two files at my disposal, e.g. ground_truth.txt and prediction.txt.  I am seeking guidance on how to utilize the globox library to calculate the scores for a single file.

A one-file dataset is still a dataset. You can use the regular AnnotationSet methods to read the annotations, for instance AnnotationSet.from_yolo_v7 and others.


Generated json options don't match docs. (AuthEndpoint vs AuthPath)

The json file created by the CLI doesn't match the docs on the homepage for AuthEndpoint / AuthPath)
Which should it be?
Sorry for the very large images. Not sure how to scale them down smaller.

Heres the docs:

The auth host is not necessary unless your echo server is on a different host than you app server.
With just host:
host - http://new.dn.dev:6001
authEndpoint - http://new.dn.dev/broadcasting/auth
With authHost:
host - http://new.dn.dev:6001
authHost - http://auth.dn.dev
authEndpoint - http://auth.dn.dev/broadcasting/auth
Not sure if that helps, or is there is an issue ?

The docs show the config key authPath
The json generated file has only a config key authEndpoint
Is this a mistake/typo?

Ah the docs are wrong. Updated


registered new user successfully but getting error while uploading package API key is invalid

Registered new user successfully but getting error while uploading package API key is invalid.
If I upload package from UI working perfectly fine. with the first registered user also it is working great,
but getting following error when create new user and use its API key.
Failed to process request. 'The specified API key is invalid or does not have permission to access the specified package.'.
The remote server returned an error: (403) Forbidden..
command is also correct works for first registered user
"nuget push *.nupkg NEWAPIKEY  -source http://mydemo-website.azurewebsites.net/"
Also checked tables Roles , UserRoles they are empty.

Try:
"nuget push *.nupkg NEWAPIKEY -source http://mydemo-website.azurewebsites.net/api/v2/package"

cool thanks :)


Expose generic TreeWalker

query and queryAll only operate on elements to be equivalent to querySelector and querySelectorAll in DOM.
Exposing a generic walker that understands text and comment nodes is necessary as well.
This should probably be the base for query and queryAll with both of them ANDing isElement into the given predicate.

Fixed with #6


Format and refactor

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5a8955a) 100.00% compared to head (d117a2d) 100.00%.

:exclamation: Current head d117a2d differs from pull request most recent head 2b121b8. Consider uploading reports for the commit 2b121b8 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           21        21
  Lines          239       239
=========================================
  Hits           239       239

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[AutoDiff] Cherry-pick AutoDiff bug fixes and two features into 5.3

This PR attempts to cherry-pick the latest differentiable programming changes into release/5.3, including various bug fixes and two notable features:

#31173: [AutoDiff] Support differentiation of wrapped properties.
#32069: [AutoDiff] Support differentiation of branching cast instructions.

Since the entire differentiable programming feature is gated by import _Differentiation, merging this into 5.3 should be low-risk.

@swift-ci please smoke test

@swift-ci please smoke test macOS

18:34:16 --
18:34:16 Exit Code: 2
18:34:16
18:34:16 Command Output (stderr):
18:34:16 --
18:34:16 <unknown>:0: warning: using sysroot for 'MacOSX' but targeting 'iPhone'
18:34:16
/Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-release/5.3/swift/test/IRGen/framepointer_arm64.sil:13:8: error: no such module 'Swift'
18:34:16 import Swift
18:34:16        ^
18:34:16 FileCheck error: '-' is empty.
18:34:16 FileCheck command line:  /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-release/5.3/buildbot_incremental/llvm-macosx-x86_64/bin/FileCheck /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-release/5.3/swift/test/IRGen/framepointer_arm64.sil --check-prefix=CHECK

The test failure seems unrelated to this change.

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 9929f613de7cf1fe794a183f8a8b8102245ac10d

@swift-ci Please test linux

Build failed
Swift Test Linux Platform
Git Sha - 9929f613de7cf1fe794a183f8a8b8102245ac10d

@swift-ci Please test linux

Build failed
Swift Test Linux Platform
Git Sha - 9929f613de7cf1fe794a183f8a8b8102245ac10d

@swift-ci Please test linux

This looks fine to me.
@DougGregor any concerns about taking this patch into 5.3?  Most of it exclusively touches autodiff.


Add option to create a 'result' symlink to colmena build

Using nix build results in a 'result' symlink to the built system configuration. This is useful if you want to compare that one with another using for example nix store diff-closures.
However colmena does not create such a symlink, it is required to manually parse the terminal output to get the location of the freshly built system.

If you run colmena apply --keep-result there will be symlinks to the top-level NixOS closures in $PWD/.gcroots/node-NAME.


Drag bug when the dragging element inner size is changed

Hello there,
I found a problem while changing the inner size of dragged elements.
This fiddle : https://jsfiddle.net/rw49knza/2/ shows the problem.
The first drag is ok, while dragging I hide the purple element.
After the first drag, the first element is still draggable whereas the others are not (the event 'sortstop' is fired right after 'sortstart').
Is there a way to refresh sizes in the sortstop event ?
Regards, Olivier

It think this is because you had sortable('.drag')[0].addEventListener  whereas you should have sortable('.drag').addEventListener
With the [0] you add the eventlistener only to the first element. If you try your initial JSfiddle you can see that the first element is still draggable but the others aren't

This is not an issue with the sort stop. Even before you start dragging it does not work for the second or third item.
Changing the "ghost" element is problematic.
What would be interesting is to allow for a changed ghost element. I had this option in here at some point but removed it because it produced some issues, however, I don't remember which, so this would be an interesting option for the future. So this issue is basically a duplicate of #271 with an additional note, that changing the inner element size is not supported.


feat: allow GoogleAuth in GlobalOptions

Fixes: googleapis/nodejs-googleapis-common#175.
Depends-on: googleapis/google-auth-library-nodejs/pull/803.

@proppy left comments on google-auth-library-nodejs. tldr; I'd like to better understand the use-case before we  expose a lower level client in the API.

@bcoe let's discuss this in https://github.com/googleapis/nodejs-googleapis-common/issues/175 as I already started describing the usecases I'm after in the issue comments.

@proppy apologize for this stalling, this something we'd like to kick back into motion?

@bcoe we have a workaround for it, so it's not urgent. But I still think this would be a good idea to allow this.

@proppy this seems reasonable to me, given that OAuth2Client inherits from AuthClient.
Where I'm a little confused though, is I don't believe GoogleAuth does:
https://github.com/googleapis/google-auth-library-nodejs/blob/master/src/auth/googleauth.ts#L97
So I'm wondering if this would actually address your issue?

Where I'm a little confused though, is I don't believe GoogleAuth does

Yes, and that's what I was trying to fix with https://github.com/googleapis/google-auth-library-nodejs/pull/803 and this very CL :)

I think I have this covered in #287 :)


Flaky crashes in signal handler on ARM64 Linux

(gdb) bt
#0  dart::ThreadInterrupterLinux::ThreadInterruptSignalHandler (signal=27, info=0x7fa737bd60, context_=0x7fa737bde0)
    at runtime/vm/thread_interrupter_linux.cc:23
#1  <signal handler called>
#2  0x0000007fa6566b5c in ?? ()
#3  0x0000007fa7475060 in ?? ()
#4  0x0000007fa7a64901 in ?? ()
Backtrace stopped: previous frame inner to this frame (corrupt stack?)

(gdb) info registers
x0             0x1b 27
x1             0x7fa737bd60<PHONE_NUMBER>24
x2             0x7fa737bde0<PHONE_NUMBER>52
x3             0x7f980227c0<PHONE_NUMBER>72
x4             0x882    2178
x5             0x7fa732b6d1<PHONE_NUMBER>65
x6             0x7fa732b728<PHONE_NUMBER>52
x7             0x2  2
x8             0x7fa7474a90<PHONE_NUMBER>08
x9             0x2755434    41243700
x10            0x573b5edc<PHONE_NUMBER>
x11            0x45f1a  286490
x12            0x18 24
x13            0x7fa732b810<PHONE_NUMBER>84
x14            0x0  0
x15            0x7fa7474ec0<PHONE_NUMBER>80
x16            0x1  1
x17            0x7fa7a62022<PHONE_NUMBER>66
x18            0x7ff1ab8b10<PHONE_NUMBER>04
x19            0x7f980227c0<PHONE_NUMBER>72
x20            0xe35000 14897152
x21            0x7fa7475060<PHONE_NUMBER>96
x22            0x0  0
x23            0xd15690 13719184
x24            0x7fa7a65f41<PHONE_NUMBER>25
x25            0xd15670 13719152
x26            0x7f980227c0<PHONE_NUMBER>72
x27            0x7fa732b810<PHONE_NUMBER>84
x28            0x7fa7a227c0<PHONE_NUMBER>72
x29            0x7fa737cfb0<PHONE_NUMBER>12
x30            0x7fa928e510<PHONE_NUMBER>76
sp             0x7fa737ac00 0x7fa737ac00
pc             0x8f27a4 0x8f27a4 <dart::ThreadInterrupterLinux::ThreadInterruptSignalHandler(int, siginfo_t*, void*)+12>
cpsr           0x60000000<PHONE_NUMBER>
fpsr           0x10 16
fpcr           0x0  0

(gdb) disassemble
Dump of assembler code for function dart::ThreadInterrupterLinux::ThreadInterruptSignalHandler(int, siginfo_t*, void*):
   0x00000000008f2798 <+0>: sub sp, sp, #0x1, lsl #12
   0x00000000008f279c <+4>: sub sp, sp, #0x160
   0x00000000008f27a0 <+8>: cmp w0, #0x1b
=> 0x00000000008f27a4 <+12>:    stp x29, x30, [sp,#-48]!
   0x00000000008f27a8 <+16>:    mov x29, sp
   0x00000000008f27ac <+20>:    stp x19, x20, [sp,#16]
   0x00000000008f27b0 <+24>:    adrp    x19, 0xe38000 <_ZN4dartL16BootStrapEntriesE+8568>
   0x00000000008f27b4 <+28>:    str x21, [sp,#32]
   0x00000000008f27b8 <+32>:    mov x20, x2
   0x00000000008f27bc <+36>:    ldr x0, [x19,#2200]
   0x00000000008f27c0 <+40>:    str x0, [x29,#4488]
   0x00000000008f27c4 <+44>:    b.eq    0x8f27f0 <dart::ThreadInterrupterLinux::ThreadInterruptSignalHandler(int, siginfo_t*, void*)+88>

@zanderso @johnmccutchan

The C stack pointer has to be 16-byte aligned, and we're not allowed to access memory beyond the stack pointer. I checked V8. It updates the C stack pointer to a legal value in lockstep with updates to the JS stack pointer.

Some offline context:

When in Dart code the C stack pointer is moved near the stack limit.
When the kernel invokes the signal handler, it uses the C stack pointer.
The crash occurs when accessing something in the stack (likely because the C stack pointer points somewhere invalid).

As an interim fix, we'll bump the C stack pointer on frame builds. We should adjust the stack overflow check to look at the C stack pointer instead of the Dart stack pointer because it is closer to the stack limit, but the currently simulation of CompareRegisters(CSP, TMP) is not correct (it does assemble correct because it works on hardware).  The long term fix should be updating the C stack pointer as we go as Zach points out.

6e2c4636cddece36c87ca77f69955a8490c8a0dd


Add support for additional rule conditions

We should add support for addtional conditions that need to be met, more than just a string/regex match of a given line.
A good reason for this is the following rule:

In HTML, when you have an anchor tag with target="_blank", the called since can access certain properties of the calling site through window.opener.location. To prevent this, add rel="noopener noreferrer" to the anchor tag.

Currently, this rule would be hard to implement with a simple regular expression.
We could implement this with an embedded function, but since DevSkim is cross-platform, we'd need a way for all engines to interpret the code. I took a look at some JS interpreters for Python, but they're all either very incomplete or require per-platform binaries. We can still go down this route, but I had another idea that might get us part of the way there.
Here's a new rule I added:
[    {
        "id": "DS610000",
        "name": "HTML Link Missing noopener or noreferrer",
        "tags": [
            "API.DangerousAPI"
        ],
        "applies_to": [
        ],
        "severity": "moderate",
        "description": "When you use target=\"_blank\", you should also use rel=\"noopener noreferrer\". See https://mathiasbynens.github.io/rel-noopener for more information.",
        "replacement": "",
        "rule_info": "https://github.com/Microsoft/DevSkim/blob/master/guidance/DS610000.md",
        "patterns": [
            {
                "pattern": "target.*_blank",
                "type": "regex-word",
                "conditions": [
                    {
                        "name": "line-match-any",
                        "value": ["noopener", "noreferrer"],
                        "invert": true
                    }
                ]
            }
        ],
        "fix_it": []
    }
]

Each condition object has a name (the name of the function to run), the data passed to that function, and whether it's expected to return true or false.
In Python, line-match-all is mapped to:
def _line_match_all(line, targets):
    logger.debug('_line_match_all({0}, {1})'.format(line, targets))

    line = line.lower()
    return all([t.lower() in line for t in targets])

So each engine would need to implement the same set of functions, but I think the full set might end up being rather small.
Thoughts?

I had already been thinking that if we went the lambda route we would want a set of predefined library functions so that common patterns weren't repeated over and over in various lambdas.  Even if we do eventually go the lambda route (is there a language that is well implemented in Python, JS/TS, Java, and .Net?  Lua?) the library functions would still be useful then, and it gets us part of the way there now.
Raul was interested in contributing to conversations about expanding the rule sophistication, so might be worth roping him in.  Do you happen to know his GH handle, since having the conversation on an open platform would allow other interested parties to chime in

I'm right here.
first and foremost, I'd have to get my head wrapped around lambdas sufficiently enough to be able to envision how that would work. for one, I believe that in order to make this work, we would have to re-imagine the way we look at the code - whether it is object-based, functional-based, or procedural-based constructs. then I believe being able to reflect upon the object -node map interactions will we be able to apply lambda expressions on those respective code models. it may be lightweight graphs, it may be proximity-based, similar to yara, perhaps. it would be good to brainstorm this deeper.

On a tangent - that's a fairly permissive pattern.  Do you think something more along the lines of
target\s*=\s*\\*[\'\"]\s*_blank\s*\\*[[\'\"]
would be appropriate?  It would narrow down to the specific pattern of target="_blank", allowing for optional spaces, either quote type, and the possible presence of escaping slashes (in case its being written from another language)

Conditions are now implemented. Closing the issue


Merge to live

Docs Build status updates of commit 11da255:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/excel-async-model.md
:white_check_mark:Succeeded

docs/develop/javascript-objects.md
:white_check_mark:Succeeded

docs/develop/scripting-fundamentals.md
:white_check_mark:Succeeded

docs/images/script-sharing.png
:white_check_mark:Succeeded

docs/includes/async-reference-documentation-link.md
:white_check_mark:Succeeded

docs/overview/excel.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Combining Coordinator and Overlord into one service does not fully work

Druid version : 0.12.1-iap3
We followed the configuration at http://druid.io/docs/latest/configuration/coordinator.html to enable feature druid.coordinator.asOverlord.enabled=true .
However after restarting the Coordinator service, the webUI on http://coordinator-host:port/console.html could not load worker list. We got 500 server error message instead. See screenshot attached

configuration :

on all nodes -> common.runtime.properties:
druid.selectors.indexing.serviceName=druid/overlord

on coordinator node -> runtime.properties:
druid.coordinator.asOverlord.enabled=true
druid.coordinator.asOverlord.overlordService=druid/overlord

@TwojaWina was there an exception stack trace in the coordinator log?

@gianm try to add more indexer configuration in runtime.properties of  coordinator:
druid.indexer.queue.startDelay=PT30S
druid.indexer.runner.type=remote
druid.indexer.storage.type=metadata


Scrollchor disables functionality of submit button

Not sure if you've ran into a similar problem before, but what I'm trying to do is search by location and by doing so the map will display 5 markers of breweries close by. However when I added   around the submit button it auto scrolls but the markers don't show up anymore. Any reason for loss of functionality you could explain to me? Please and thank you!

sorry! I don´t understand what is your issue.
a example repo could be useful.

I'm sorry! Thank you for getting back to me so promptly, I really appreciate it. But I just ran a callback function and got it working. Sorry and thank you again!

I do not deserve them.
Feel free to reopen this issue if you needed it


Fix package globs for poudriere.conf.

Globs should now work when specifying packages in ALLOW_NETWORKING_PACKAGES, ALLOW_MAKE_JOBS_PACKAGES, and PRIORITY_BOOST.
Closes #860.

Thanks!


Fix/assimp windows

:tada: This PR is included in version 5.18.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


What about /openid, /.well-known/openid-configuration ?

What should the kcp server do about the /openid and /.well-known/openid-configuration URL paths?

@MikeSpreitzer could you please update the description with more details as to what this ask is about? Thanks!


Selection isn't rendered after changing dimension

Reproduction steps:

Make a selection in a dimension
~Make a new dimension via /script run custom_dimension('error', 123)~
~Get there with /execute in error run tp @p 0 100 0~
Go to another dimension
Make a new selection
Observer the bug (or not observe it)

Will look into it hopefully soon.

Adding to this: making a selection in one dimension and then changing dimension and making a new one, the old one is neither deleted nor active. When going back to the first dimension, the markers are there, but the selection does nothing.

Actaullay, the issue is wider: the selection has absolutely no clue about dimension. Since it stores its coordinates as triplets (and not the marker entity), making a selection in one dimension, changing dimension, and the executing a command will affect the coordiantes of the selection, but in the new dimension. To repoduce:
-Make a selection in OW
-Go to the nether
-Run /se move ~ ~ ~
A random portion of the nether will be moved to the player.


Consider reusing azure:* configs for the NextGen provider

Currently, all the provider configuration is done with settings starting with azure-nextgen:. It would be nice to use plain azure: prefix. At least, in the scenario when both providers are used in the same project, the user wouldn't need to set the same settings twice.

This goes hand in hand with https://github.com/pulumi/pulumi-azure-nextgen/issues/148.


Pin book theme to 0.3 series

This pins the book theme to the 0.3 series (release candidates and above). So that we're not pulling directly from master anymore.
closes #9

seems to work as expected?

seems to work as expected?

I guess... we should be able to confirm it if we check the logs on RTD, do we have easy access to RTD?

@damianavila we can confirm just by looking at our docs and noticing that there are features in there that are only in the pre-release (which there are!, for example the white background in the header dropdown menus on https://docs.2i2c.org/en/latest/)

Yeah, I know... although it would be nice to have access to the RTD logs in case we are talking about imperceptible changes 😉.

we do also have easy access to the RTD logs in that case - you should be able to see https://readthedocs.org/projects/2i2c-pilot-documentation/builds/

Sorry, I should be more explicit here.
I am aiming for the whole team need to be a maintainer there... just bus factor stuff 😉.

ah - you mean to have admin access for the RTD builds for all of our sites? Yes definitely agree. I wonder if there is a way to add a github team rather than an individual for RTD access?

ah - you mean to have admin access for the RTD builds for all of our sites? Yes definitely agree.

Indeed

I wonder if there is a way to add a github team rather than an individual for RTD access?

Not sure... it would be nice!

I asked around on Twitter, let's see what they say


[DON'T MERGE] [BEAM-11992] Run CrossLanguage ValidatesRunner tests only for Spark 3

Run XVR_Spark PostCommit

Huh, looks like I was wrong - guess we'll have to investigate where this error is coming from.

Yep my suspicion without knowing anything is something being hardcoded or some parameter missing from the python side. Any help is extremely welcomed

Just kidding - we forgot to run the seed job. So the failed job was still running both tests.

run seed job

Run XVR_Spark PostCommit

Oh how silly ok it is green so maybe the easiest path is to just create a second set of XVR tests for Spark 3. I I will prepare a PR for that.


Completed POST post

Resolves #6, #19
I think it resolves 19, it just stores the description as plain string
As an author, I want to make public posts.
Right now, ALL fields except title, description and author are nullable. I thought it would be easier to test on the front end but will eventually have to validate against that
I haven't written tests yet bc its easier to test first if my GET are working so i'll implement it then
Post is missing comment information

Django migrate can't detect because of missing __init__.py T.T


Always use the --cluster-version flag for the gke provider.

We use gcloud beta container everywhere now, so we shouldn't be using --cluster-api-version anymore.
@jlowdermilk @mbforbes

lgtm

Any volunteers to do a giant Jenkins cleanup? :-)


feat: new logging system with extra data and more strict error format

More strict error format, same as main log. Without new {extra:..} nested object
Feature for specify content logging extra data for add ability save context data for all logs (useful for expresskit request and response)
Fix types for logs. Extra object for pino logger may be empty or undefined. Not necessary processing it with prepareExtra

Maybe this is not breaking changes, please fix me
Concept at Expresskit lib
https://github.com/gravity-ui/expresskit/pull/47

@resure fixed


Getting concurrent.futures._base.CancelledError from simple binary tree built from futures

I'm getting the following exception from a binary tree that I'm building from futures (based largely on an example in the dask docs that uses delayed instead of futures).
Here's the function in question:
from dask.distributed import default_client
from toolz import first

def tree_reduce(objs, func=sum):

    while len(objs) > 1:
        new_objs = []
        n_objs = len(objs)
        for i in range(0, n_objs, 2):
            inputs = objs[i:i + 2]
            obj = get_client().submit(func, inputs)
            new_objs.append(obj)
        wait(new_objs)
        objs = new_objs

    return first(objs)

And my reproducible test:
    n_parts = 15
    client = Client(cluster)

    a = client.scatter(range(n_parts))
    b = tree_reduce(a)
    b = b.result()

    assert(sum(range(n_parts)) == b)

The exception is intermittent and happens about 50% of the time:
self = <tornado.gen.Runner object at 0x7f2cf6ce5710>

    def run(self) -> None:
        """Starts or resumes the generator, running until it reaches a
        yield point that is not ready.
        """
        if self.running or self.finished:
            return
        try:
            self.running = True
            while True:
                future = self.future
                if future is None:
                    raise Exception("No pending future")
                if not future.done():
                    return
                self.future = None
                try:
                    exc_info = None

                    try:
>                       value = future.result()
E                       concurrent.futures._base.CancelledError

I've tried doing a dask.distributed.wait after each level of the tree. I've also tried waiting for b in the reproducible example before calling result. I'm completely stumped as to why this is happening. I'm running this on a workstation with 2x V100s.
I believe I'm doing something very wrong but I can't figure out what it is.

Thanks for the issue @cjnolet .  I'm sorry to hear that you've had a frustrating time.
If you can provide a minimal reproducible example I'd be happy to run through it and see if I can reproduce the problem.  You're really close to this with your current code, but it looks like you have a custom function func in there, it's not clear how you're creating a cluster (hopefully a bare LocalCluster() will do), and there are also missing imports.  Anything you can do to make this process copy-pastable would be welcome.
You mention that you are using two V100s.  Is it necessary to use GPUs to reproduce the problem?  If so, I might divert you to RAPIDS folks.

Absolutely, @mrocklin. Actually, I am using the LocalCUDACluster but this is a simple pytest that's not storing any data on GPUs (though I was able to reproduce it w/ CuPy arrays).
Oddly enough, this issue seems exclusive to the use of client.scatter. This example seems to work fine:
    from dask_cuda import LocalCUDACluster
    from dask.distributed import Client

    cluster = LocalCUDACluster(protocol="tcp")
    client = Client(cluster)

    import numpy as np

    def s(x):
        return x

    n_parts = 15
    a = [client.submit(s, i) for i in range(n_parts)]
    b = tree_reduce(a)
    b = b.result()

    print(str(b))

    assert(sum(range(n_parts)) == b)

Thanks @cjnolet .  In the future if you're able to provide a copy-pasteable example that anyone can run that would help.  For example, if you don't need LocalCUDACluster then please just don't include it in the example.  That way people who don't have access to GPUs (like me) can help you without having to manually modify your example.  Also, if you're able to provide something that a maintainer can just copy and paste into an IPython session it really helps out a lot.  Most of us aren't actually paid to help you with these things, and we go through a lot of issues, so anything you can do to get the time expectation on our end to under a minute is very welcome.
I tried cobbling together a copy-pastable example from your comments below:
from dask.distributed import get_client, wait, Client, LocalCluster
from toolz import first

def tree_reduce(objs, func=sum):

    while len(objs) > 1:
        new_objs = []
        n_objs = len(objs)
        for i in range(0, n_objs, 2):
            inputs = objs[i:i + 2]
            obj = get_client().submit(func, inputs)
            new_objs.append(obj)
        wait(new_objs)
        objs = new_objs

    return first(objs)

cluster = LocalCluster()
client = Client(cluster)

def add(parts): return sum(parts)

n_parts = 15
a = client.scatter(range(n_parts))
b = tree_reduce(a, func=add)
b = b.result()

print(str(b))

assert(sum(range(n_parts)) == b)

Unfortunately it seems to work fine on my machine.  I ran this ten times and each time it was fine.
So I think that the next step here is for you to try to provide a copy-pasteable example that a maintainer can run that fails.
(Sorry for the github issue lecture.  It's been a busy day.)

My apologies, @mrocklin. Thank you for being patient with me.
Here's a slightly modified script that fails for me everytime. It seems the number of workers is important (On my tests, I have only 2 workers and in our environment it's not always trivial to increase the number of workers).
from dask.distributed import get_client, wait, Client, LocalCluster

from toolz import first

#import pytest

def tree_reduce(objs, func=sum):

    while len(objs) > 1:
        new_objs = []
        n_objs = len(objs)
        for i in range(0, n_objs, 2):
            inputs = objs[i:i + 2]
            obj = get_client().submit(func, inputs)
            new_objs.append(obj)
        wait(new_objs)
        objs = new_objs

    return first(objs)

#@pytest.mark.parametrize("n_parts", [1, 2, 5, 10, 15])
def test(n_parts):

    client = Client(cluster)

    def add(parts): return sum(parts)

    a = client.scatter(range(n_parts))
    b = tree_reduce(a, func=add)
    b = b.result()

    print(str(b))
    assert(sum(range(n_parts)) == b)

if __name__ == "__main__":

    cluster = LocalCluster(n_workers=2)

    for i in range(25):

        for n_parts in [1, 2, 5, 10, 15]:
            test(n_parts)

Ah, that's perfect.  Thank you @cjnolet .  I'm able to reproduce.  I'll try to take a look at this this weekend.

Here is a simpler failure.  I've removed the tree reduction.
from dask.distributed import Client, LocalCluster

async def test(n_parts, client):
    a = await client.scatter(range(n_parts), hash=True)
    future = client.submit(sum, a)
    await future

async def f():
    async with Client(n_workers=2, processes=False, asynchronous=True) as client:
        for i in range(25):
            for n_parts in [1, 2, 5, 10, 15]:
                print(n_parts)
                await test(n_parts, client)

if __name__ == "__main__":
    import asyncio
    asyncio.get_event_loop().run_until_complete(f())

I think that the problem here has to do with the scattered futures, which get deleted and recreated in quick succession.  There is probably some subtle race condition in how the client and scheduler are counting references.  @jacobtomlinson , this might be something that you enjoy digging into.  It should give some understanding of internals, and should help out other NVIDIA folks.

Thanks @mrocklin! I verified that your new script fails every time when n_parts=2
Our CI always executes our tests against the bleeding edge versions of dask and distributed. It is currently blocked by the sudden presence of CancelledError in several of our algorithms. It seems that these errors started about a week ago and we're seeing the issue even in tests / code that haven't change recently.
In addition to the cancelledError, I'm also seeing some strange subsequent errors in dask array/cudf from_delayed() that an instance of a cudf.Dataframe was expected but a Future was found instead. Sometimes I'm able to fix these errors by not having a future.result() overwrite a variable that was holding a reference to a future, for example:
This consistently has a cancelled error:
X = [client.submit(...) for x in X]
X = client.compute(X, sync=True)

This errors less frequently:
X = [client.submit(...) for x in X]
X_local = client.compute(X, sync=True)

Based on the example, I'm thinking this workaround is not fixing the issue, but just lowering the chances for the potential race condition.

The error that you have uncovered here happens when

We create some futures by scattering data (not normal computations)
We delete those futures
We recreate those exact same futures a millisecond later

I don't have enough information on your other fail cases to know if they are the same unfortunately.  If you're not scattering things then it might be something different.  In that case I would encourage you to raise another issue with a minimal reproducible example.

I looked at this and there is a race condition but I am not sure that we can easily resolve inside of dask.  The race condition being that as we are scattering, we are deleting at the same.  I think there are a few options:

when we scatter wait a tick
when we scatter call transitions directly (it's not this call but something like, scheduler -- complete your tasks
ask user to wait a tick in between scatter/submit calls
uniqueness around scattered keys (this could be fairly limiting for other tasks but would avoid collisions)

Dask should be robust to this.  We shouldn't rely on users to be careful
here.
I think that someone needs to look deeply at how we currently count
references and send task-released messages around.  I think that
@jacobtomlinson would be a good person for this if he has time.
On Wed, Mar 25, 2020 at 1:17 PM Benjamin Zaitlen<EMAIL_ADDRESS>wrote:

I looked at this and there is a race condition but I am not sure that we
can easily resolve inside of dask. The race condition being that as we are
scattering, we are deleting at the same. I think there are a few options:

when we scatter wait a tick
when we scatter call transitions directly (it's not this call but
something like, scheduler -- complete your tasks
ask user to wait a tick in between scatter/submit calls
uniqueness around scattered keys (this could be fairly limiting for
other tasks but would avoid collisions)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/issues/6027#issuecomment-604063575, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACKZTGY4SBYUIDQ6QCDTHLRJJRGLANCNFSM4LP3ZN2Q
.

In other words.  This isn't something that we want to work around or
avoid.  This is something that we should dive into.  Diving into it is hard
though and will require some previous experience with the internals of the
distributed scheduler.
On Wed, Mar 25, 2020 at 1:25 PM Matthew Rocklin<EMAIL_ADDRESS>wrote:

Dask should be robust to this.  We shouldn't rely on users to be careful
here.
I think that someone needs to look deeply at how we currently count
references and send task-released messages around.  I think that
@jacobtomlinson would be a good person for this if he has time.
On Wed, Mar 25, 2020 at 1:17 PM Benjamin Zaitlen<EMAIL_ADDRESS>wrote:

I looked at this and there is a race condition but I am not sure that we
can easily resolve inside of dask. The race condition being that as we are
scattering, we are deleting at the same. I think there are a few options:

when we scatter wait a tick
when we scatter call transitions directly (it's not this call but
something like, scheduler -- complete your tasks
ask user to wait a tick in between scatter/submit calls
uniqueness around scattered keys (this could be fairly limiting
for other tasks but would avoid collisions)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/issues/6027#issuecomment-604063575, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACKZTGY4SBYUIDQ6QCDTHLRJJRGLANCNFSM4LP3ZN2Q
.

I am looking at this now. Although I'm feeling a little in at the deep end with this. Some pointers to where I should start looking would be appreciated.

Yeah, it's non-trivial.  I would probably start by printing out or
otherwise recording every time the client and scheduler think that the task
has been created or cancelled.  I think that by looking through that list
that you'll be able to eventually spot something fishy.
On Wed, Mar 25, 2020 at 1:27 PM Jacob Tomlinson<EMAIL_ADDRESS>wrote:

I am looking at this now. Although I'm feeling a little in at the deep end
with this. Some pointers to where I should start looking would be
appreciated.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/issues/6027#issuecomment-604068965, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACKZTDL2CQ2LHHZP6NQHKTRJJSMDANCNFSM4LP3ZN2Q
.

I've created another further simplified reproducer.
from dask.distributed import Client

async def f():
    async with Client(
        n_workers=1, processes=False, asynchronous=True, silence_logs=False
    ) as client:

        d = [0, 1]
        a = await client.scatter(d, hash=True)
        print(await client.submit(sum, a))

        del a

        d = [1, 2]
        a = await client.scatter(d, hash=True)
        print(await client.submit(sum, a))

if __name__ == "__main__":
    import asyncio

    asyncio.get_event_loop().run_until_complete(f())

If we scatter some data and delete it, but then immediately scatter some more data with a common value and try to operate on it we see the CancelledError.
This is because the following chain of events happen:

Futures are created by the client and data is sent to the scheduler
Scheduler creates the keys and sends the data to the worker
Futures are deleted by the client, queueing a request to the scheduler for deletion
Scheduler queues keys for deletion by the workers
New futures are created by the client
Scheduler creates new keys, one is the same as the previously deleted key, and sends data to the worker
Deletion task arrives at the worker and it removes the keys, despite one being recreated
Scheduler tries to compute on lost data, the exception is raised

The issue seems to be a result of the time delay between the client deleting a future and the worker deleting the data. The data is recreated during that time.
I feel like the logic here is reasonable. If the user deletes some data it should be deleted. If they recreate it again then they pay a performance penalty compared with not deleting it.
Perhaps one solution to this would be to introduce some reference counting for keys on the worker. When a key is created in Worker.update_data a count should be incremented. And then when it is deleted in Worker.delete_data it should be decremented and deleted only if the count gets to zero.
I'll start working on a PR for this.

Is this issue also present in dask-yarn cluster? I tried out the easy reproducible example and see the same error. If yes, would this be fixed by https://github.com/dask/distributed/pull/3643?

Getting the same  concurrent.futures._base.CancelledError error on LocalCluster.
I am using client.run() to run a function on all workers in sync mode. Error is intermittent, 1 in 10 runs.
I am wondering if this is related to nanny. By default run does not use it.

Getting the same  concurrent.futures._base.CancelledError error on LocalCluster.
I am using client.run() to run a function on all workers in sync mode. Error is intermittent, 1 in 10 runs.
I am wondering if this is related to nanny. By default run does not use it.


Want to change the height of the searchbar, editing css doesn

https://github.com/mervick/emojionearea/blob/master/scss/_variables.scss#L28


Fix NOTES.txt tooltips when adding a LoadBalancer service

Description
Fixes some errors in NOTES.txt when installing or upgrading with a LoadBalancer service.

Add the namespace arg in two commands where it was missing
Append -router to the end of the "fullnames".  For example, with a basic install/upgrade, kubectl get svc --namespace dev -w druid fails but kubectl get svc --namespace dev -w druid-router works as intended.
Corrects the jsonpath search by changing ip to hostname.

Given a basic installation that does not change the configuration too much, and assuming that the service changed to a LoadBalancer is the router, the commands in this section of the notes now work as intended.

This PR has:

[x] been self-reviewed.
[x] been tested in a test Druid cluster.

Hi! Not sure how to address that build failure – this is my first open source PR :) – based off the logs it looks like the exceptions don't have anything to do with my changes, right?

Yes, there are some flaky tests. I've re-started the failed tests.


How to output a posteriori probability of each decoding unit？

How to output a posteriori probability of each decoding unit？

please see https://github.com/wenet-e2e/wenet/blob/main/wenet/transformer/asr_model.py#L319


Add Chinese Translation

Added Chinese translation.

Solves #225  @tonybaloney .

@BlackHole1 @yihong0618 , did the changes as requested, please review.

Thanks everyone.


Make mounting reset for arms forward

That's a really hard position to get in 😢

Frick you’re right… I was testing with arms-only. Doing the rest of the movement kinda breaks the balance ;-;

Marking as draft. I think a toggle for this would be nice, on the mounting tab or in settings.

Scratching this PR. I instead want a toggle for T-Pose (vrchat) and another for arms forward (v-tubing). To elaborate, it's not immediately here on my todo list


Show inherited functions in Debug (when deploying with foundry)

Description
This implements the same inheritedFrom functionality previously done for hardhat. Also, I did a small renaming in hardhat-scripts.
Additional Information

[x] I have read the contributing docs (if this is your first contribution)
[x] This is not a duplicate of any existing pull request

Related Issues
Related to discussion #558 and PR #564
Your ENS/address: harmont.eth

:warning:  This PR also includes merge-changes from #601 .


fix: Remove log crate's features

The release_max_level_off and max_level_trace in prod were replaced by a noop and are not unly no longer needed, but also force downstream crates to disable logging in optimized releases.

Thanks a lot!

Thank you so much for merging this. I forgot to remove this.


Error at Cifar-recipe example

After I run the model.fit(...) cell I see that error
MXNetError: [18:00:59] src/symbol/symbol.cc:121: Symbol.InterShapeKeyword argument name softmax_label not found.
Candidate arguments:
	[0]data
	[1]convolution114_weight
	[2]convolution114_bias
	[3]batchnorm114_gamma
	[4]batchnorm114_beta
	[5]convolution115_weight
	[6]convolution115_bias
	[7]batchnorm115_gamma
	[8]batchnorm115_beta
	[9]convolution116_weight
	[10]convolution116_bias
	[11]batchnorm116_gamma
	[12]batchnorm116_beta
	[13]convolution117_weight
	[14]convolution117_bias
	[15]batchnorm117_gamma
	[16]batchnorm117_beta
	[17]convolution118_weight
	[18]convolution118_bias
	[19]batchnorm118_gamma
	[20]batchnorm118_beta
	[21]convolution119_weight
	[22]convolution119_bias
	[23]batchnorm119_gamma
	[24]batchnorm119_beta
	[25]convolution120_weight
	[26]convolution120_bias
	[27]batchnorm120_gamma
	[28]batchnorm120_beta
	[29]convolution121_weight
	[30]convolution121_bias
	[31]batchnorm121_gamma
	[32]batchnorm121_beta
	[33]convolution122_weight
	[34]convolution122_bias
	[35]batchnorm122_gamma
	[36]batchnorm122_beta
	[37]convolution123_weight
	[38]convolution123_bias
	[39]batchnorm123_gamma
	[40]batchnorm123_beta
	[41]convolution124_weight
	[42]convolution124_bias
	[43]batchnorm124_gamma
	[44]batchnorm124_beta
	[45]convolution125_weight
	[46]convolution125_bias
	[47]batchnorm125_gamma
	[48]batchnorm125_beta
	[49]convolution126_weight
	[50]convolution126_bias
	[51]batchnorm126_gamma
	[52]batchnorm126_beta
	[53]convolution127_weight
	[54]convolution127_bias
	[55]batchnorm127_gamma
	[56]batchnorm127_beta
	[57]convolution128_weight
	[58]convolution128_bias
	[59]batchnorm128_gamma
	[60]batchnorm128_beta
	[61]convolution129_weight
	[62]convolution129_bias
	[63]batchnorm129_gamma
	[64]batchnorm129_beta
	[65]convolution130_weight
	[66]convolution130_bias
	[67]batchnorm130_gamma
	[68]batchnorm130_beta
	[69]convolution131_weight
	[70]convolution131_bias
	[71]batchnorm131_gamma
	[72]batchnorm131_beta
	[73]convolution132_weight
	[74]convolution132_bias
	[75]batchnorm132_gamma
	[76]batchnorm132_beta
	[77]fullyconnected6_weight
	[78]fullyconnected6_bias
	[79]softmaxoutput5_label

The examples under notebooks are outdated. You are welcome to submit a fix or use examples under image-classification.
If you want to fix this, I suggest changing the name of SoftmaxOutput to softmax

Please use this example to train CIFAR-Network; https://github.com/dmlc/mxnet/tree/master/example/image-classification

Fixed in PR #737


java.lang.NullPointerException Error

Hi. I keep getting this error: http://pastebin.com/bQLWZT9R
Can you please work on a fix? It happens so often, and it greatly hampers the quest-making experience.

Did you use the color code "&" in your quests name?

Please do not use color codes where not supported. While expanding such functionality is planned, doing so now will cause errors of this nature.

Yes, but I didn't use color codes in the named title. Now I get this error: http://pastebin.com/t63EyYcW


Windows: Implement ReadMemInfo()

Signed-off-by: John Howard<EMAIL_ADDRESS>@swernli
This PR is part of the proposal described in docker/docker issue 10662 to port the docker daemon to Windows. This implements ReadMemInfo in pkg\system. It replaces the workaround I was going to initially do in #13613

LGTM

LGTM


Restore check if schema exists before trying to create in bootstrap

Summary
In Kong 0.12.2 there was a feature introduced: to not require schema creation permission during migration if the schema already exists.
https://github.com/Kong/kong/commit/9beaa6258ae924a766d09bb0e9ddcf44866eb2cc
But it is no longer present on Kong 1.X.
Old file responsible: https://github.com/Kong/kong/blob/0.12.2/kong/dao/migrations/cassandra.lua line 34
New file responsible: https://github.com/Kong/kong/blob/1.4.2/kong/db/strategies/cassandra/connector.lua line 877
Now the migration fails if cassandra user for Kong doesn't have permissions to create schema.
I think that was a nice feature.
Is there some reason why it was dropped?

The comment there says (https://github.com/Kong/kong/blob/1.4.2/kong/db/strategies/cassandra/connector.lua#L877):
 -- create keyspace if not exists

Arguably it does not do what the comment says, so I will mark this as a bug then.

Looks like the root of the problem is that if you have permissions to use a keyspace but not to create it, then CREATE KEYSPACE IF NOT EXISTS fails even if the keyspace already exists.
If that's the case, then yes, we should add that check from 0.x back into our migrations logic.

Closing this as we added it back with #5361. Sorry for all inconvenience, must have something to do with switching the migration framework.


Update chokidar

What version of Livereload are you using?
0.8.2
What OS are you using?
macOS 10.14.6
What web browser are you using? (Browser name and specific version please)
Chrome 78.0.3904.108
Expected result
chokidar 3.x used
Actual result
chokidar 2.x used
Steps to reproduce issue

Install livereload
yarn why chokidar

Why is this important?
chokidar 3.x has significant performance improvements
Another option would be to use the native watch support in node

We won't be using fs.watch because

The fs.watch API is not 100% consistent across platforms, and is unavailable in some situations.

I'll look at updates to chokidar.

Reading through the documentation for fs.watch a bit more, I think that not using it is the right call, but updating to 3.x would be great!

https://github.com/fsevents/fsevents/issues/291


feat(tx builder): use cgw for simulation configs

What it solves
Instead of using a hardcoded list of chains where simulation isn't supported, use CGW/config service to get the config of the current chain and check its features list.
How this PR fixes it
I've replaced a hardcoded array of chain ids with an async call to CGW. I've added useAsync from the wallet repo for this.

Simulation is disabled on Aurora, so no button is shown:

Tested by @liliya-soroka ✅