Failed to deploy Etcd cluster

HINT: We are running latest, straight out of master build of kube-aws so we expect failures :disappointed:
Issue
When deploying cluster and having >1 (e.g. 3) instances of Etcd we have following issue:
Etcd cluster is never bootstrapped, because the etcd of the first node (etcd-member service) waits for quorum and never gets "active", so CloudFormation SUCCESS signal never gets sent.
BUT: If we send cfn-signal manually from the first node, cluster bootstraps fine then, because second Etcd already gets quorum in cluster of three instances. Rest of the cluster (controllers/workers) are also start fine after this.
BUT: Clusters with one Etcd get deployed just fine.
Any advice on what we could look into?
I mean, we are bleeding edge runners with master, so I assume we ourselves are guilty in this thing, but still in would be nice to get some clues on what's happening.
Thanks!

@ivanilves Hi! Thanks as always for using kube-aws.
Would you mind sharing full output from journalctl?
I'm interested in especially how etcdadm related systemd units are working. For example, etcdadm-reconfigure.service is responsible to skip waiting for quorum to meet when it is the first etcd node.

-- Logs begin at Fri 2018-02-23 12:58:57 UTC, end at Fri 2018-02-23 13:11:45 UTC. --
Feb 23 13:01:38 ip-10-0-21-174.eu-west-1.compute.internal systemd[1]: Dependency failed for etcdadm reconfigure runner.
Feb 23 13:01:38 ip-10-0-21-174.eu-west-1.compute.internal systemd[1]: etcdadm-reconfigure.service: Job etcdadm-reconfigure.service/start failed with result 'dependency'.
Feb 23 13:03:39 ip-10-0-21-174.eu-west-1.compute.internal systemd[1]: Dependency failed for etcdadm reconfigure runner.
Feb 23 13:03:39 ip-10-0-21-174.eu-west-1.compute.internal systemd[1]: etcdadm-reconfigure.service: Job etcdadm-reconfigure.service/start failed with result 'dependency'.
Feb 23 13:05:04 ip-10-0-21-174.eu-west-1.compute.internal systemd[1]: Starting etcdadm reconfigure runner...

Feb 23 13:05:31 ip-10-0-21-174.eu-west-1.compute.internal etcdadm[2630]: /opt/bin/etcdadm: info: member_set_initial_cluster_state: setting initial cluster state to: new
Feb 23 13:05:31 ip-10-0-21-174.eu-west-1.compute.internal etcdadm[2630]: /opt/bin/etcdadm: info: _systemctl_daemon_reload: running `systemctl daemon-reload` to reload etcd-member.service
Feb 23 13:05:31 ip-10-0-21-174.eu-west-1.compute.internal systemd[1]: Started etcdadm reconfigure runner.

core@ip-10-0-21-174 ~ $ sudo systemctl  --type=service | grep -v active
  UNIT                                                    LOAD   ACTIVE     SUB     JOB   DESCRIPTION
  etcd-member.service                                     loaded activating start   start etcd (System Application Container)

core@ip-10-0-21-174 ~ $ sudo systemctl status etcd-member.service
● etcd-member.service - etcd (System Application Container)
   Loaded: loaded (/usr/lib/systemd/system/etcd-member.service; enabled; vendor preset: disabled)
  Drop-In: /etc/systemd/system/etcd-member.service.d
           └─20-aws-cluster.conf, 30-unit-type.conf, 40-version.conf
   Active: activating (start) since Fri 2018-02-23 13:05:31 UTC; 24min ago
     Docs: https://github.com/coreos/etcd
  Process: 3256 ExecStartPre=/usr/bin/chown -R etcd:etcd /var/lib/etcd2 (code=exited, status=0/SUCCESS)
  Process: 3255 ExecStartPre=/usr/bin/systemctl is-active decrypt-assets.service (code=exited, status=0/SUCCESS)
  Process: 3251 ExecStartPre=/usr/bin/systemctl is-active cfn-etcd-environment.service (code=exited, status=0/SUCCESS)
  Process: 3238 ExecStartPre=/usr/bin/rkt rm --uuid-file=/var/lib/coreos/etcd-member-wrapper.uuid (code=exited, status=254)
  Process: 3235 ExecStartPre=/usr/bin/mkdir --parents /var/lib/coreos (code=exited, status=0/SUCCESS)
 Main PID: 3260 (etcd)
    Tasks: 8 (limit: 32768)
   CGroup: /system.slice/etcd-member.service
           └─3260 /usr/local/bin/etcd

Feb 23 13:29:44 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: 2018-02-23 13:29:44.205540 I | raft: f9fd16a06c52657a is starting a new election at term 1006
Feb 23 13:29:44 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: 2018-02-23 13:29:44.205582 I | raft: f9fd16a06c52657a became candidate at term 1007
Feb 23 13:29:44 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: 2018-02-23 13:29:44.205597 I | raft: f9fd16a06c52657a received MsgVoteResp from f9fd16a06c52657a at term 1007
Feb 23 13:29:44 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: 2018-02-23 13:29:44.205610 I | raft: f9fd16a06c52657a [logterm: 1, index: 3] sent MsgVote request to 336f5c9c1c24bf5c at term 1007
Feb 23 13:29:44 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: 2018-02-23 13:29:44.205629 I | raft: f9fd16a06c52657a [logterm: 1, index: 3] sent MsgVote request to eb5dba92fbb75af9 at term 1007
Feb 23 13:29:45 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: 2018-02-23 13:29:45.705540 I | raft: f9fd16a06c52657a is starting a new election at term 1007
Feb 23 13:29:45 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: 2018-02-23 13:29:45.705580 I | raft: f9fd16a06c52657a became candidate at term 1008
Feb 23 13:29:45 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: 2018-02-23 13:29:45.705595 I | raft: f9fd16a06c52657a received MsgVoteResp from f9fd16a06c52657a at term 1008
Feb 23 13:29:45 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: 2018-02-23 13:29:45.705607 I | raft: f9fd16a06c52657a [logterm: 1, index: 3] sent MsgVote request to 336f5c9c1c24bf5c at term 1008
Feb 23 13:29:45 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: 2018-02-23 13:29:45.705630 I | raft: f9fd16a06c52657a [logterm: 1, index: 3] sent MsgVote request to eb5dba92fbb75af9 at term 1008

-- Logs begin at Fri 2018-02-23 12:58:57 UTC, end at Fri 2018-02-23 13:31:19 UTC. --
Feb 23 13:01:38 ip-10-0-21-174.eu-west-1.compute.internal systemd[1]: Dependency failed for etcd (System Application Container).
Feb 23 13:01:38 ip-10-0-21-174.eu-west-1.compute.internal systemd[1]: etcd-member.service: Job etcd-member.service/start failed with result 'dependency'.
Feb 23 13:03:39 ip-10-0-21-174.eu-west-1.compute.internal systemd[1]: Dependency failed for etcd (System Application Container).
Feb 23 13:03:39 ip-10-0-21-174.eu-west-1.compute.internal systemd[1]: etcd-member.service: Job etcd-member.service/start failed with result 'dependency'.
Feb 23 13:05:31 ip-10-0-21-174.eu-west-1.compute.internal systemd[1]: Starting etcd (System Application Container)...
Feb 23 13:05:31 ip-10-0-21-174.eu-west-1.compute.internal rkt[3238]: rm: unable to resolve UUID from file: open /var/lib/coreos/etcd-member-wrapper.uuid: no such file or directory
Feb 23 13:05:31 ip-10-0-21-174.eu-west-1.compute.internal rkt[3238]: rm: failed to remove one or more pods
Feb 23 13:05:31 ip-10-0-21-174.eu-west-1.compute.internal systemctl[3251]: active
Feb 23 13:05:31 ip-10-0-21-174.eu-west-1.compute.internal systemctl[3255]: active
Feb 23 13:05:31 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: ++ id -u etcd
Feb 23 13:05:31 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: + exec /usr/bin/rkt run --uuid-file-save=/var/lib/coreos/etcd-member-wrapper.uuid --trust-keys-from-https --mount volume=coreos-systemd-dir,target=/run/systemd/system --volume coreos-systemd-dir,kind=host,source=/run/systemd/system,readOnly=true --mount volume=coreos-notify,target=/run/systemd/notify --volume coreos-notify,kind=host,source=/run/systemd/notify --set-env=NOTIFY_SOCKET=/run/systemd/notify --volume coreos-data-dir,kind=host,source=/var/lib/etcd2,readOnly=false --volume coreos-etc-ssl-certs,kind=host,source=/etc/ssl/certs,readOnly=true --volume coreos-usr-share-certs,kind=host,source=/usr/share/ca-certificates,readOnly=true --volume coreos-etc-hosts,kind=host,source=/etc/hosts,readOnly=true --volume coreos-etc-resolv,kind=host,source=/etc/resolv.conf,readOnly=true --mount volume=coreos-data-dir,target=/var/lib/etcd --mount volume=coreos-etc-ssl-certs,target=/etc/ssl/certs --mount volume=coreos-usr-share-certs,target=/usr/share/ca-certificates --mount volume=coreos-etc-hosts,target=/etc/hosts --mount volume=coreos-etc-resolv,target=/etc/resolv.conf --inherit-env --stage1-from-dir=stage1-fly.aci quay.io/coreos/etcd:v3.3.1 --user=232 --
Feb 23 13:05:37 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: pubkey: prefix: "quay.io/coreos/etcd"
Feb 23 13:05:37 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: key: "https://quay.io/aci-signing-key"
Feb 23 13:05:37 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: gpg key fingerprint is: BFF3 13CD AA56 0B16 A898  7B8F 72AB F5F6 799D 33BC
Feb 23 13:05:37 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]:         Quay.io ACI Converter (ACI conversion signing key<EMAIL_ADDRESS>Feb 23 13:05:37 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: Trusting "https://quay.io/aci-signing-key" for prefix "quay.io/coreos/etcd" without fingerprint review.
Feb 23 13:05:37 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: Added key for prefix "quay.io/coreos/etcd" at "/etc/rkt/trustedkeys/prefix.d/quay.io/coreos/etcd/bff313cdaa560b16a8987b8f72abf5f6799d33bc"
Feb 23 13:05:37 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: Downloading signature:  0 B/473 B
Feb 23 13:05:37 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: Downloading signature:  473 B/473 B
Feb 23 13:05:37 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: Downloading signature:  473 B/473 B
Feb 23 13:05:39 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: Downloading ACI:  0 B/14.6 MB
Feb 23 13:05:39 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: Downloading ACI:  15.9 KB/14.6 MB
Feb 23 13:05:40 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: Downloading ACI:  965 KB/14.6 MB
Feb 23 13:05:41 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: Downloading ACI:  3.92 MB/14.6 MB
Feb 23 13:05:42 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: Downloading ACI:  9.13 MB/14.6 MB
Feb 23 13:05:42 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: Downloading ACI:  14.6 MB/14.6 MB
Feb 23 13:05:42 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: image: signature verified:
Feb 23 13:05:42 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]:   Quay.io ACI Converter (ACI conversion signing key<EMAIL_ADDRESS>Feb 23 13:05:44 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: 2018-02-23 13:05:44.886631 I | pkg/flags: recognized and used environment variable ETCD_ADVERTISE_CLIENT_URLS=https://ec2-54-77-203-10.eu-west-1.compute.amazonaws.com:2379
Feb 23 13:05:44 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: 2018-02-23 13:05:44.887195 I | pkg/flags: recognized and used environment variable ETCD_CERT_FILE=/etc/ssl/certs/etcd.pem
Feb 23 13:05:44 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: 2018-02-23 13:05:44.887308 I | pkg/flags: recognized and used environment variable ETCD_CLIENT_CERT_AUTH=true
Feb 23 13:05:44 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: 2018-02-23 13:05:44.887443 I | pkg/flags: recognized and used environment variable ETCD_DATA_DIR=/var/lib/etcd

/usr/bin/systemctl is-active etcd-member.service returns 3 as long as etcd-member.service is activating, so this /etc/systemd/system/cfn-signal.service would never start to give a CFN signal:
[Unit]
Wants=etcd-member.service
After=etcd-member.service

[Service]
Type=simple
Restart=on-failure
RestartSec=10

EnvironmentFile=/var/run/coreos/etcd-node.env
ExecStartPre=/usr/bin/systemctl is-active etcd-member.service
ExecStartPre=/usr/bin/rkt fetch quay.io/coreos/awscli:master
ExecStart=-/opt/bin/cfn-signal

The only error I can see in journalctl:
Feb 23 13:06:42 ip-10-0-21-174.eu-west-1.compute.internal etcd-wrapper[3260]: 2018-02-23 13:06:42.924908 E | etcdserver: publish error: etcdserver: request timed out

@mumoshu to be honest I got pretty confused by

only 2 of 3 nodes for etcd members are running

from
etcdadm[2630]: /opt/bin/etcdadm: info: member_reconfigure: 1 more nodes are required until the quorum is met
etcdadm[2630]: /opt/bin/etcdadm: info: member_set_unit_type: setting etcd unit type to "notify". `systemctl daemon-reload` required afterwards
etcdadm[2630]: /opt/bin/etcdadm: info: member_reconfigure: only 2 of 3 nodes for etcd members are running, which means cluster is still in bootstrap process. searching for a etcd snapshot to recover this member
etcdadm[2630]: /opt/bin/etcdadm: info: member_remote_snapshot_exists: checking existence of s3://schip-cluster-cfn-dev/kube-aws/clusters/etsninja/instances/dd70e860-1898-11e8-8b86-50fae9b818d2/etcd-snapshots/snapshot.db
etcdadm[2630]: /opt/bin/etcdadm: info: member_remote_snapshot_exists: s3://schip-cluster-cfn-dev/kube-aws/clusters/etsninja/instances/dd70e860-1898-11e8-8b86-50fae9b818d2/etcd-snapshots/snapshot.db does not exist
etcdadm[2630]: /opt/bin/etcdadm: info: member_bootstrap: remote snapshot for etcd0 does not exist. skipped downloading
etcdadm[2630]: /opt/bin/etcdadm: info: member_local_snapshot_exists: checking existence of file /var/run/coreos/etcdadm/snapshots/etcd0.db
etcdadm[2630]: /opt/bin/etcdadm: info: member_bootstrap: backup not found. starting brand new etcd0...
etcdadm[2630]: /opt/bin/etcdadm: info: member_set_initial_cluster_state: setting initial cluster state to: new
etcdadm[2630]: /opt/bin/etcdadm: info: _systemctl_daemon_reload: running `systemctl daemon-reload` to reload etcd-member.service
systemd[1]: Started etcdadm reconfigure runner.

... cause there were no 2 nodes... There wes only 1 initial (first) etcd0 instance :sweat:

Hi @ivanilves I don't think that this is the issue (as it got fixed at some moment, I remember) but by any chance did you try to deploy the cluster several times and still have etcd nodes in "Terminated" state in AWS console?

Hi @camilb !
Well, we always deploy to a cluster with a new, random name.
So if deploy fails, CFN stack stays in CREATE_FAILED state and eventually we delete it.
And if deploy fails, we deploy a new cluster with a new random name, etc, we never redeploy failed-to-create clusters :innocent:
This is an experimentation system, so clusters are random-named and short-lived.

Hmm, would you mind sharing your cluster.yaml?
My best bet is that your etcd provisioning step(s) is timing out due to env-specific issues + too small instance type!
You said just rerunning cfn-signal worked? That's an another sign that your instance type for etcd was not sufficient.

We run it at m4.large. Which are reasonable IMO. How do you think, should we increase the instance? :thinking:
Anyway, here you can find the link to cluster.yaml (with some private data obscured): https://gist.github.com/ivanilves/e8e1049c8668814e83b6688a8f4f55d5
Huge thanks for your outstanding support and quick responses! :crown:

@ivanilves Thx for sharing!

do you think, should we increase the instance? 🤔

Nope. That sounds enough. But I believe that I pointed it.
Would you mind removing KubernetesCluster: "etsninja" from stackTags and try again?
We seem to have overlooked the fact about the KubernetesCluster tag specified by users.
In nutshell, etcdadm expects only either of KubernetesCluster or kubernetes.io/cluster/$CLUSTER_NAME tag to be put onto etcd nodes.
When the both tags exists, etcdadm would misunderstand the number of running etcd nodes.
You did see member_reconfigure: only 2 of 3 nodes for etcd members... message, right?
That's an indication of the problem I guess.
Also see: https://github.com/kubernetes-incubator/kube-aws/blob/8961f27f9f2ac9da628b208fee5290e20861c66a/etcdadm/etcdadm#L145-L149

Great, you are right @mumoshu !!! :clap:
Renaming KubernetesCluster tag fixed the etcd bootstrap process.
Thank you and closing the issue!


fix(docs): fix broken links in documentation

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area ci

/area event

/area event_derive

/area plugin

/area plugin_api

/area plugin_derive

/area plugin_tests

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gnosek
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [gnosek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

118560c fix(docs): fix broken links in top-level event README
c98e04a fix(docs): export TableWriter and Validated* vtable variants

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, gnosek
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,gnosek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 414b6e2caef390ae105198667f9e6e923eadcc4a


Misspelling above..

Near the top of the page it states "View and reset a conference ID assigned to a user in Microsoft Teasms."  <-- Change to "Teams".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 04f02841-8def-d3af-f4bf-cd92654b6364
Version Independent ID: bf92954c-cc85-d5a7-f190-0636467a2490
Content: See, change, and reset a conference ID assigned to a user in Skype for Business Online
Content Source: Skype/SfbOnline/audio-conferencing-in-office-365/see-change-and-reset-a-conference-id-assigned-to-a-user.md
Service: skype-for-business-online
GitHub Login: @tonysmit
Microsoft Alias: tonysmit

@d1bjo0 Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@officedocsbot assign @scanum


CLI interface

For this version, the CLI interface should handle this (at a minimum)

[ ] Initiate a new Tiden project
[ ] Create stream
[ ] Create nano
[ ] Create namespace
[ ] Create module
[ ] Create element
[ ] Moving/Removing of all above

It would be pretty awesome if nanos, connects, and Element tests could automatically figure out what props are available on an Element. This way a lot of code could be auto-generated when creating things. I find a lot of my time is actually spent on just setting up the basic boilerplate.
The most simple and obvious way would be to enforce components to declare what props they are using. This comes with some cons though:

we're limiting the use of alternative mechanisms of creating Elements (Tiden might ship with HotHaunted support out-of-box, but it should be possible to use whatever you want, otherwise we turn into yet another framework).
Actual use and declared use will definitely go out of sync from time to time. This is annoying, especially when teammates make changes and then CLI/UI is found to be broken weeks later.

An alternate idea might be to use Element tests as the de-facto truth. We have the ability to check what props are actually being set on the element. So the tool could sniff what the tests do and replicate that. This also encourages users to write tests, which I think is an excellent bonus.


REPL Rewrite

Below lists plans for REPL in VS Code Python as of (May 31st, 2024).
More subset of steps are subject to being added as I move forward incrementally.
Milestone 1:

[X]  Investigate the state of REPL support in the extension #21590
[X]  Become familiar with REPL code
[X] Implement Run Selection/Line in xxx be more smart #18105  (Has to be merged after removing support for 3.7) and #21778
[x] Implement Go to next line only when non-selection/non-highlighted case #21838  (Has to be merged after removing support for 3.7 along with the previous item)
[x] Create, fix tests that were testing selection previously.
[x] Set up an experiment for smart shift+enter and Go to next block line (dynamic cursor movement) in code base.
[x] Deprecate 3.7 and merge the smart send (smart shift+enter, go to next block line) after.
[x] Create tests for both TypeScript and Python side for smart selection, dynamic cursor movement
[x] Enable experiments for all tests in the repo, specifically beneficial for smoke test involving new features.
[x] Warning message, and setting to show when user is trying to smart send with invalid code in the currently opened Python file.

Milestone 2:

[x] Investigate shell integration for Python REPL in VS Code. #21966
[x] Decorations for denoting success/failure next to REPL prompt. (Currently sleeping mode while fixing bug for pwsh users)
[x] Add Python as Shell Type in VS Code Core.
[x] Enable recent command history. (Need PR in VS Code core itself)
[x] Reduce risk of first command being ignored or duplicated into shell that launches Python REPL in Terminal.
[x]  Address issue where rerun command was backed up by one sequence: https://github.com/microsoft/vscode-python/issues/23016
[x] Address issue where wrong exit code was shown: https://github.com/microsoft/vscode-python/issues/22942

Milestone 3:

[x] Spike: Investigate common ground between I.W. and Python REPL. Let users use I.W. without having to install Jupyter or IPython kernel. #23029
- This would enable things like Syntax Highlighting, intellisense out of the box since Pylance understands editor type of IW.
[x] Built in Python REPL (Experimental setting) https://github.com/microsoft/vscode-python/issues/23332
[x] Build custom Python interactive interpreter for VS Code that can communicate natively. https://github.com/microsoft/vscode-python/issues/23091
[x] Look into relationship between native VS Code REPL and Interactive Window. Spike with rebuilt IW with different design and non-Jupyter based backend would be helpful: https://github.com/microsoft/vscode-python/issues/23029
[ ] Implement and support for variable pane #17183
[ ] Allow Smart Send on built-in REPL https://github.com/microsoft/vscode-python/issues/23521
[ ] Native REPL for VS Code with new Editor type?  ---> Depends on feedback from user studies.

@anthonykim1 @luabud I was wondering if the new REPL would be able to support completions from a language server? Does VS code give you the ability to put up a completion list? (Maybe similar to how history works?, you tab and then it tabs through completions)

Hello @rchiodo I'm not entirely sure what you mean, but are you talking about Intellisense? In terms of command history, I believe you can use up and down arrow to navigate through previous commands in the new notebook style REPL.

Great! Try adding
"interactiveWindow.executeWithShiftEnter": false,
"python.REPL.sendToNativeREPL": true,
``` in your settings.json to give the new REPL a try!


ImdsCredential raises ServiceRequestError when connection refused

When one of its token requests gets no response from IMDS, ImdsCredential should raise ClientAuthenticationError. Currently it propagates whatever exception the pipeline raised, for example ServiceRequestError:
import os
from azure.identity._credentials.imds import ImdsCredential

# causes the credential to skip the probe, and guarantees a request error
os.environ["AZURE_POD_IDENTITY_AUTHORITY_HOST"] = "https://localhost:37807"
ImdsCredential().get_token("scope")

Traceback (most recent call last):
  ...
azure.core.exceptions.ServiceRequestError: <urllib3.connection.HTTPSConnection object at 0x7fc365b51520>: Failed to establish a new connection: [Errno 111] Connection refused

I expect this is rare in the real world because it requires IMDS to have first responded to the probe request, which is to say the scenario is that IMDS was available but has stopped responding.
Changing the exception type could break some applications. Both ServiceRequestError and ClientAuthenticationError inherit AzureError, but an application could conceivably handle ServiceRequestError specifically.

Close as won't fix.
Will revisit it if there is a customer report.


anti synergy between ICB_BLOCKED and "broken yield"-fixing logic

described in comment in arbiter_interested around "voluntary_fixme" case
i'm fixing this with a gross hack, which requires threading a flag through both arbiter functions and saving it in each struct hax for explore to use later. i wish i knew a more elegant way to fix it

abandoning this approach just gonna use try_avoid_fp_deadlock and accept unsoundness of ICB

not actually unsound because of preemption being required for correctness; makes sense to screw around with / bypass icb here


Making custom health card operations

My team is trying to make a SMART Health cards implementation using FHIR Works. As part of the implementation, we need an ability to create custom extended operations, so that we can issue health cards as part of a Patient request (POST /Patient/:id/$health-cards-issue). Has anyone done this before?  Or can provide some guidance on how to accomplish such a task?
The pattern we're following is defined here:
https://smarthealth.cards/#via-fhir-health-cards-issue-operation

Super interesting use-case. I do not know of anyone doing this. At face value this seems to be more of a authentication feature than a FHIR one. I would probably focus on building a small lambda that takes in a verifiable JWT from an idP and then calls a FHIR server to determine if that user can have a HealthCard created.
One question I wasn't able to answer is do we need to track the HealthCards created? Do HealthCards need to be revoked?
Another path forward: If you want Update the router to handle this new endpoint -- could get started somewhere here: https://github.com/awslabs/fhir-works-on-aws-routing/blob/mainline/src/router/routes/genericResourceRoute.ts#L34
Like I said I would suggest to keep this feature outside of the FHIR server but happy to chat more

Thanks for the quick follow-up @rsmayda!
My understanding was that since we needed to create an endpoint built on top of the original /Patient/:id this would require changes to the FHIR Server. Specifically, it looks like we want an "Extended Operation" (https://www.hl7.org/fhir/operations.html) for "$health-cards-issue". On first pass it looked like FHIR Works had Operations, and I thought we could just add this new operation in somewhere.
The SMART Health Cards framework has an Operation defined here: https://smarthealth.cards/artifacts/operation-patient-i-health-cards-issue.json
I'll take a look at the router, that does look like the starting point. And to answer your Q, I think there might need to be some type of auditing trail for health card access. I don't think revoking is a feature tho.

So the nice thing about serverless is you could have another lambda accepting this specific request. https://github.com/awslabs/fhir-works-on-aws-deployment/blob/mainline/serverless.yaml#L78-L88
in the path parameter you could have something like /Patient/{id}/$health-cards-issue and method set to POST. Just a thought 👍

Ah that could work! I'll play around with it and see what I can get.
We also thought about creating some sort of proxy within API Gateway, that would route requests to another lambda.

@rsmayda If we take this approach, is it as simple as, modifying the fhir-works-on-aws-deployment package to include this new request. But then point the handler to another package/folder/repo?
I'm thinking it's prob best to modify the original FHIR Works solution as little as possible, and just have this custom lambda be more of an extension (e.g. we just need to deploy the lambda code each time it has changed vs having to redeploy the FHIR Works package/s each time).

There are a few 'gotchas' like:

the order of the declared API GW paths should be most specific to least specific (ie list your custom path, should be first)
AuthN/AuthZ will have to be custom (or you can rely on communication to FWoA instance)

I am sure there may be others, you discover along the path
But overall yeah it is that "simple"

I'm thinking it's prob best to modify the original FHIR Works solution as little as possible

100% agree with you it will make merging in new changes from us much easier :)

Got it, thanks!
A little unrelated Q. I know the default FHIR works uses cognito as the auth component. Is it easy to switch this out to another identity provider (thinking okta or id.me)?

For the default role based access control repo (https://github.com/awslabs/fhir-works-on-aws-authz-rbac) it wasn't built for the purpose to be flexible. That said you could use that as your base and adjust from there.
Another option is to use the SMART AuthZ package which was built for flexibility: https://github.com/awslabs/fhir-works-on-aws-authz-smart. In this case you just need to pass in OAuth2 and patient_picker information so really any modern idP would work in this situation.


[Bug]: Garbled characters in email notification subject

Preflight Checklist

[X] I could not find a solution in the documentation, the existing issues or discussions
[X] I have joined the ZITADEL chat

Environment
Self-hosted
Version
latest
Describe the problem caused by this bug
When I switch the language to Simplified Chinese, the Chinese email subject received is garbled.
The RFC 5321 document explains that SMTP protocol only supports US-ASCII encoding for subjects.
To reproduce

Set the user language to Chinese
Send any email notification to this user

Screenshots
On macOS device:

On iOS device:

Expected behavior
No response
Operating System
Device: [Mac, iPhone 12 Pro]
OS: [macOS Ventura 13.5.2, iOS 16.6.1]
Relevant Configuration
No response
Additional Context
No response

@hifabienne Thank you, according to the instructions you provided, my problem has indeed been solved! I would like to know if there was any special handling for UTF-8 encoded strings in this setting?

Hei @jinrenjie
So you just entered the same text in the custom texts again and this works?
I actually don't know if there is something special in the encoding.
Maybe @livio-a knows more?

Hey @jinrenjie
Thanks for pointing this out. I've just tested and seems like it's dependant on the provider, e.g. Google is still able to handle / display non-ascii, while Apple doesn't.
I'll create a fix for this.

Hei @jinrenjie So you just entered the same text in the custom texts again and this works? I actually don't know if there is something special in the encoding. Maybe @livio-a knows more?

Yes, I entered the same text again and saved it, then sent an email notification and the title was displayed normally!


is it working in vita3k

the emulator

I'm not familiar with Vita3k, but to be able to run Kero Blaster port, you'll have to install 2 taihen plugins (kubridge and fd_fix). But after a quick search, the Vita3k seems hadn't support taihen plugin yet (said by one contributor, at https://github.com/Vita3K/Vita3K/issues/2494#issuecomment-1507690818). So I guess at this stage, you'll need to have a real vita to run the port.

-isn't ps vita has official release as of wiki said
-do you use source code

isn't ps vita has official release as of wiki said

As far as I know, "Kero Blaster" has no official PSV release.

do you use original source code

This project is basically a "loader" for the Android version of "Kero Blaster". The code in this repository contains no game resource (except the title image and screenshots, if it counts) nor the game's source code.

say it's loader
could you port it to a TASble platform
wii/3ds/linux/psp/ps2/psx

After a deep look on vita3k, I realise vita3k might not even need the kubridge plugin to load the required resource. This means vita3k might be able to run this game.
I'll re-evaluate this in a while.

could you port it to a TASble platform
wii/3ds/linux/psp/ps2/psx

@dananothername Linux is officially supported, you could check it in Steam.
For other platform, due to the compability of the game binary's architecture, only 3DS among these might be capable for the port method used in this repository. I'm not familiar with 3DS platform, so this is not planned. I may try it after I start to play 3DS stuff.


Fix failure in closing PRs

Fix an error in PullRequestsService.Edit when closing PRs
due to 'base' field being present together with
State = 'closed'.  In this case the GitHub API v2.17.5
responds with an error:
'Cannot change base branch of closed pull request'.
Fixes #1250.

Thank you, @gauntface!
Merging, but not creating new release yet.


Delay loading search field dropdown data

Overview
As part of our redesign of the sidebar to support extended fields we researched search behavior and hid list frequently used search fields. If the search fields are never shown, their dropdown list option do not need to be fetched.
Connects #1729
Demo

Notes
When refreshing the page after selection both a facility type and a processing type, the facility type options do not populate. This is not a regression and is a non-ideal behavior in the current implementation of filtering options based on the connection between facility type and processing type.
Testing Instructions

Open the dev tools network tab and filter by XHR
Browse http://localhost:6543/ and verify that API request are not made for

/api/contributor-types
/api/facility-processing-types
/api/product-types
/api/worker-ranges

Click "More filters" and verify that fetches are now make and that all the dropdowns are populated
Select items in all the extended field dropdowns then refresh the page, verify that the selections are restored

Checklist

[x] fixup! commits have been squashed
[x] CI passes after rebase
[x] CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

I rebased this on develop and force pushed along with some cleanup.

We want to make other adjustments to fields in this new sub-component so since I effectively did a review of @TaiWilkin 's initial work I am going to approve and merge this. If there are additional clean ups or changes we would like to do they can be made in a follow up PR.


[SPARK-8303] Move DateUtils into unsafe package.

This contains also #6738. Should be merged after #6738.

Merged build triggered.

Merged build started.

Test build #34650 has started for   PR 6753 at commit 1f5a3b1.

Test build #34650 has finished for   PR 6753 at commit 1f5a3b1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.


test(react): icTabs Cypress Tests

icTabs Cypress Tests
Summary of the changes
Completed migration of end-to-end and visual regression tests to Cypress for IcTabs, and removed old end-to-end and loki visual regression tests.
Related issue
#1773

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: MI6-286:x: github-actions[bot]You have signed the CLA already but the status is still pending? Let us recheck it.


Importing logger data does not support single parameter results

In importdata.py ,  the line containing parameter names is assumed to have at least 2 parameters. If the input file contains only a single parameter, it will not work correctly.
I think the best solution is to look for a date or time header column as well. This can be a default value 'Date' or 'Time' or an optional value specified in a config file. Doing it this way has the added bonus of determining the date and time columns in advance and not having to check that they're specified every iteration.

Good one. We hit against this ourselves a few weeks ago.
You'll see in the example files that in some instances the date/time headers are in a different row, so you can't scan for them that easily. In any case, the date/time columns are established once.
The problem with lowering the threshold to 1 is that in some cases, data providers put a whole blob of metadata above the datarows. This often also includes the parameter name (ie the column header to search for).
I'm wondering whether simply specifying a number of rows to skip is the simplest solution. I'm trying to make this as simple for the user as possible. Would there be another more robust way?


Simpler completion

After @mpickering pointed this out yesterday, I noticed that completion was a lot more complicated than it needed to be. Instead of the convoluted wrangling we do with import declarations, all the information we need is in the GlobalRdrEnv.
In addition to this, I've separated out the step of getting the type information/snippets for the completion into the LSP CompletionItemResolve request. Type information for local variables which
is readily at hand in the TypecheckedModule itself is still reported in the original completion request.
A potential performance issue I've tried to fix is that looking up the types of all the possible completions would result in GHC loading a bunch of interface files it didn't need to.
For example, consider a module that imports Prelude, but doesn't use any functions from GHC.Enum(like enumFrom). Normally, GHC will not load the interface file for GHC.Enum. However, when we try to get the type of the enumFrom completion, this forces GHC to go and actually load the interface file for that module.
I've implemented the function we used to look up the type information to just return Nothing in this case and not try to load the GHC.Enum interface file. You can see this in action in the "does not pull in unnecessary modules until needed" test case I've added.
The above behaviour is up for discussion, and I will re-implement the old/default behaviour for getTypeForName depending on the consensus.
The behavioural changes due to this PR are:

Completion items need to be resolved to get their type information/snippets.
The types/snippets for some functions from modules that haven't been used previously may not be available, as described above.

I agree with @Lorenzo, I think the completion logic is significant enough to split out

@bubba, @lorenzo any comments on the type lookup behaviour? If I restore the old behaviour, because looking up the type is anyway done in the resolveCompletion step, the interface file would only be loaded in when the user goes over the relevant completion (or whenever the client decides to resolve the completion).

@wz1000 I don’t think I fully understand the consequences of changing the behavior, superficially this looks ok to me. What do you think the consequences of not having the old behavior might be?

This is how the new behaviour manifests itself in vscode:
Before GHC has loaded the GHC.Enum interface file, the completion item looks like this:

After I add a usage of enumFrom, GHC is forced to load the GHC.Enum interface file, we get the type for fromEnum also. When the completion is selected, we will also a "snippet" for the argument.

If I revert to the old behaviour, just having the fromEnum entry selected will make GHC load the interface file for GHC.Enum, and we will get the type of fromEnum in the completion window even if we don't have a usage of enumFrom elsewhere in the file.

I think doing the expensive work in the resolve step is the right way to go. As I understand it, this is precisely why the resolve step exists.
Completion needs to be a fast/unintrusive operation, so reducing the work done is a good step.

I am happy with this approach, and agree we should move the stuff into its own file.
But for traceability it would be better to land this one as a change to HieExtras, so we can see the diff, and then add a second administrative change to move the code around.

@wz1000 relying on Hoogle for type information felt a bit dodgey, so I am happy that this is the correct way, even if it is a bit slower to resolve, which happens "asynchronously" so I am not concerned.
But in your example posted, does this mean that completion won't show any types until that interface file is loaded by means of it being used inside the document? Or is a completion request alone able to force it to load the interface file?

@bubba

But in your example posted, does this mean that completion won't show any types until that interface file is loaded by means of it being used inside the document?

This. But I guess it won't be too bad to load the interface file on a completion resolve request.
Btw, for a comparison of memory usage before and after this patch, see BEFORE and AFTER
The test is loading the file 20 times, then loading it 20 times asking for completions every time. The bump in the middle in BEFORE is when we start asking for completions.

I've changed it so that the interface file is loaded in when the client asks to resolve the completion, and the type/snippet is available for every symbol in the completion list.
This should be ready to merge now.


Fix Test Set doc to include datamodule

In the test set documentation it still uses the old test_dataloader format and not the new datamodule argument:
https://pytorch-lightning.readthedocs.io/en/stable/test_set.html

the heading says Test with additional data loaders, so I believe it's correct. Maybe add a section for Test with data modules??

I think I saw somewhere that train_dataloader approach was no longer recommended?

It's just another option but both dataloaders and datamodules are supported.

Ah ok.


New version: Zen-Team.Zen-Browser version 1.0.2-b.0

Pull request has been created with komac v2.8.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

Installs correctly on my VM

See https://github.com/microsoft/winget-pkgs/pull/197532#issuecomment-2532654154


Sampling logic error? x-b3-flags / x-b3-sampled logic question

Hi-
Quoting https://github.com/openzipkin/b3-propagation/#debug-flag-1

Debug is encoded as X-B3-Flags: 1. Debug implies an accept decision: don't also send X-B3-Sampled: 1.

Though https://github.com/openzipkin/zipkin-go-opentracing/blob/master/zipkin-recorder.go#L86 only checks the Sampled flag.
Should there be additional logic added to accept(sample) traces flagged as debug? I can create a PR, but maybe my understanding of this is incorrect.
Thank you!

when https://github.com/openzipkin-contrib/zipkin-go-opentracing/pull/123 is complete, flaws around b3 handling will go away I think

Closing as #123 has been merged and now used the B3 propagation package from Zipkin Go.


Updates SPM setup snippet since 'package(name:url:from:)' is deprecated

The SPM configuration snippet was using the deprecated package(name:url:from:). Updated the README.md to use the recommended package(url:from:) and changed from to point to the latest version.

thanks!


Auth across multiple subdomains

Hello, I would like to make my auth sync across multiple subdomains domain.com -> a.domain.com
Similarly to
https://github.com/orgs/supabase/discussions/5742
Is there a convenient way to handle this via the nuxt module?

I have the same question. Would be nice to have an answer in 2024

Hi, we are solving this by passing a domain option to the client
supabase: {
        redirect: false,
        cookieOptions: {
            domain: process.env.NUXT_PUBLIC_COOKIE_DOMAIN,
        },
    },

Hi, we are solving this by passing the parent domain as the domain in the cookie options
supabase: {
    redirect: false,
    cookieOptions: {
        domain: process.env.NUXT_PUBLIC_COOKIE_DOMAIN,
    },
},

Can you elaborate a little more on that? I've tried everything I can think of and I can't get it to work across subdomains. It still sets a value in localStorage, which prevents it from working across subdomains. How exactly are you signing the user in and then how are you getting the user value?

For us, it just works by passing example.com as the NUXT_PUBLIC_COOKIE_DOMAIN. Then, we can sign in on sub1.example.com and it recognizes our user on sub2.example.com. We are signing them in using useSupabaseClient<Database>().auth.signInWithOAuth and useSupabaseClient<Database>().auth.signInWithPassword.Then, we use useSupabaseUser to get the user data.

For us, it just works by passing example.com as the NUXT_PUBLIC_COOKIE_DOMAIN. Then, we can sign in on sub1.example.com and it recognizes our user on sub2.example.com. We are signing them in using useSupabaseClient<Database>().auth.signInWithOAuth and useSupabaseClient<Database>().auth.signInWithPassword.Then, we use useSupabaseUser to get the user data.

Hmm, weird. I've tried doing the same exact thing. It does correctly recognize the access_token and refresh_token cookies for example.com, but there's ALSO a value saved to localStorage that the useSupabaseUser() reads from which messes everything up. For example, if you log into sub1.example.com, and then visit sub2.example.com, it'll show you as logged in which is correct - but then try logging out on either subdomain and the localStorage on the other domain won't be deleted so it'll start giving errors about the auth session not being found or something.

Hmm, weird. I've tried doing the same exact thing. It does correctly recognize the access_token and refresh_token cookies for example.com, but there's ALSO a value saved to localStorage that the useSupabaseUser() reads from which messes everything up. For example, if you log into sub1.example.com, and then visit sub2.example.com, it'll show you as logged in which is correct - but then try logging out on either subdomain and the localStorage on the other domain won't be deleted so it'll start giving errors about the auth session not being found or something.

I just tested this on our product and it correctly logs out across domains. I have to note that we are using an unpublished version from my PR #357. Wanna try it out too and see if it works there? @supabase/ssr does handle storing auth tokens a bit differently than this library originally did, I believe.

Hmm, weird. I've tried doing the same exact thing. It does correctly recognize the access_token and refresh_token cookies for example.com, but there's ALSO a value saved to localStorage that the useSupabaseUser() reads from which messes everything up. For example, if you log into sub1.example.com, and then visit sub2.example.com, it'll show you as logged in which is correct - but then try logging out on either subdomain and the localStorage on the other domain won't be deleted so it'll start giving errors about the auth session not being found or something.

I just tested this on our product and it correctly logs out across domains. I have to note that we are using an unpublished version from my PR #357. Wanna try it out too and see if it works there? @supabase/ssr does handle storing auth tokens a bit differently than this library originally did, I believe.

Oh yeah, that's definitely gotta be the solution! How can I use your version?

Oh yeah, that's definitely gotta be the solution! How can I use your version?

It is not easy at the moment, I had to use a git submodule and put this into nuxt.config.ts
export default defineNuxtConfig({
    modules: [
        './modules/supabase-nuxt/src/module.ts',
        ...
    ], ...


Added scroll up button in notes

PR Fixes:

Added a scroll up button in notes so that the user doesn't have to keep scrolling up after he/she have read through them,
added video to show how efficient is for the user to scroll back up to Show Content button

fix-
https://github.com/user-attachments/assets/6de52f02-aa53-46c1-9954-a19e83218749
*tried to solve this using script from next/script and not using hooks to avoid usage of "use client"
Resolves #[Issue Number if there]
Checklist before requesting a review

[] I have performed a self-review of my code
[] I assure there is no similar/duplicate pull request regarding same issue

too clumsy, putting up a new one, with minimal changes


vscode-extensions.matklad.rust-analyzer: Extension fails to activate

Describe the bug
The extension fails to activate.
Steps To Reproduce
Steps to reproduce the behavior:

Install the extension via home-manager
Attempt to activate it by opening VS Code to a Rust project

Expected behavior
For the extension to activate successfully.
Additional context
Logs:
[2021-08-06 16:59:01.070] [exthost] [error] Activating extension matklad.rust-analyzer failed due to an error:
[2021-08-06 16:59:01.070] [exthost] [error] TypeError: Cannot destructure property 'ANY' of 'require$$26' as it is undefined.
	at Object.<anonymous> (/nix/store/59nk7z6h9gfcqqjv0kiajns9j4pwn173-vscode-extension-rust-analyzer-2021-08-02/share/vscode/extensions/matklad.rust-analyzer/out/src/main.js:2378:13)
	at Module.u._compile (/nix/store/d81pjajpc0xcplx7ch921lrw4s8v37g1-vscode-1.58.2/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:4:1315)
	at Object.Module._extensions..js (internal/modules/cjs/loader.js:1155:10)
	at Module.load (internal/modules/cjs/loader.js:982:32)
	at Module._load (internal/modules/cjs/loader.js:823:14)
	at Function.f._load (electron/js2c/asar_bundle.js:5:12913)
	at Function.i._load (/nix/store/d81pjajpc0xcplx7ch921lrw4s8v37g1-vscode-1.58.2/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:103:27843)
	at Function.b._load (/nix/store/d81pjajpc0xcplx7ch921lrw4s8v37g1-vscode-1.58.2/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:103:24471)
	at Function.l._load (/nix/store/d81pjajpc0xcplx7ch921lrw4s8v37g1-vscode-1.58.2/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:93:59004)
	at Module.require (internal/modules/cjs/loader.js:1006:19)
	at require (internal/modules/cjs/helpers.js:88:18)
	at Function.t [as __$__nodeRequire] (/nix/store/d81pjajpc0xcplx7ch921lrw4s8v37g1-vscode-1.58.2/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:5:101)
	at u._loadCommonJSModule (/nix/store/d81pjajpc0xcplx7ch921lrw4s8v37g1-vscode-1.58.2/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:103:25877)
	at u._doActivateExtension (/nix/store/d81pjajpc0xcplx7ch921lrw4s8v37g1-vscode-1.58.2/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:89:12556)
	at u._activateExtension (/nix/store/d81pjajpc0xcplx7ch921lrw4s8v37g1-vscode-1.58.2/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:89:11657)
	at processTicksAndRejections (internal/process/task_queues.js:93:5)
	at async Promise.all (index 0)

Notify maintainers
@oxalica
Metadata
 - system: `"aarch64-darwin"`
 - host os: `Darwin 20.6.0, macOS 11.5.1`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.4pre20210707_02dd6bb`
 - channels(winter): `""`
 - channels(root): `""`
 - nixpkgs: `/nix/store/a0wni8bqlfwqr67qjwg0yhlfwg2nlq4r-source`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: vscode-extensions.matklad.rust-analyzer
# a list of nixos modules affected by the problem
module:

Note: rolling back to https://github.com/NixOS/nixpkgs/commit/1454412796de471d1826154344c18178a44288bb#diff-95ca71480a98f51984b63d5ea3b588211290c1b3d96af0fbda2a7363c1aff0a7 fixes the issue.

Hello, I've been looking at this since yesterday. I think we need to pin rollup to 2.51 to avoid https://github.com/rollup/rollup/issues/4195 / https://github.com/npm/node-semver/issues/318 - I am presently regenerating node-packages.nix to test this fix.
I think you are right that my 08-02 update introduced the regression. I apologize, can cut a revert PR later today if my fix doesn't work and if that would be desirable.


Use platform specific path

Retrieves the platform specific path when getting the project path, using the right path separators on each platform.
Since this issue seems to be Windows specific and I don't have a Windows computer I can't test if this actually fixes the issue but sounds like it should. Closes #34.

I can confirm that this patch does correct the issue, and allow projects to be launched in the Editor with normal playInEditor mode.


GPL Ghostscript 9.52: Unrecoverable error, exit code 1

this is result of running following php sample codes in command line
$pdflib = new ImalH\PDFLib\PDFLib();
$pdflib->setPdfPath('./sample.pdf');
$pdflib->setOutputPath('./images/');
$pdflib->setImageFormat(\ImalH\PDFLib\PDFLib::$IMAGE_FORMAT_PNG);
$pdflib->setDPI(96);
$pdflib->setPageRange(1,$pdflib->getNumberOfPages());
$pdflib->setFilePrefix('page-'); // Optional
$pdflib->convert();

GPL Ghostscript 9.52: Unrecoverable error, exit code 1
error is for running getNumberOfPages method
sample.pdf is near to php file and there is an images folder there

pdf file is an standard pdf file and is converted before with other pdf to image php classes like _https://github.com/spatie/pdf-to-image_

hmm.. will have to look into, @mablae do you think you can check this issue ?

I modified this library for me.
public function getNumberOfPages(){
if($this->number_of_pages == -1){
if($this->gs_command == "gswin32c.exe" || $this->gs_command == "gswin64c.exe"){
$this->pdf_path = str_replace('\', '/', $this->pdf_path);
$delimiter = "/";
$exit=preg_split("/".$delimiter."([^".$delimiter."]+)$/", $this->pdf_path,-1, PREG_SPLIT_DELIM_CAPTURE | PREG_SPLIT_NO_EMPTY);
$ex="--permit-file-read=".$exit[0]."/";
}
$pages = $this->executeGS('-q '.$ex.' -dNODISPLAY -c "('.$this->pdf_path.') (r) file runpdfbegin pdfpagecount = quit"',true);
$this->number_of_pages = intval($pages);
}
return $this->number_of_pages;
}

I'm running into the same problem. Have you had time to look at this?

I modified this library for me.
public function getNumberOfPages(){ if($this->number_of_pages == -1){ if($this->gs_command == "gswin32c.exe" || $this->gs_command == "gswin64c.exe"){ $this->pdf_path = str_replace('', '/', $this->pdf_path); $delimiter = "/"; $exit=preg_split("/".$delimiter."([^".$delimiter."]+)$/", $this->pdf_path,-1, PREG_SPLIT_DELIM_CAPTURE | PREG_SPLIT_NO_EMPTY); $ex="--permit-file-read=".$exit[0]."/"; } $pages = $this->executeGS('-q '.$ex.' -dNODISPLAY -c "('.$this->pdf_path.') (r) file runpdfbegin pdfpagecount = quit"',true); $this->number_of_pages = intval($pages); } return $this->number_of_pages; }

This had a little bug, i fixed it and now it is transforming correctly to images
`    public function getNumberOfPages(){
if($this->number_of_pages == -1){
if($this->gs_command == "gswin32c.exe" || $this->gs_command == "gswin64c.exe"){
$this->pdf_path = str_replace('\', '/', $this->pdf_path);
$delimiter = "/";
$exit = preg_split("/" . preg_quote($delimiter, '/') . "([^" . preg_quote($delimiter, '/') . "]+)$/", $this->pdf_path, -1, PREG_SPLIT_DELIM_CAPTURE | PREG_SPLIT_NO_EMPTY);
$ex = "--permit-file-read=" . $exit[0] . "/";
        }
        $pages = $this->executeGS('-q '.$ex.' -dNODISPLAY -c "('.$this->pdf_path.') (r) file runpdfbegin pdfpagecount = quit"',true);
        $this->number_of_pages = intval($pages);
    }
    return $this->number_of_pages;
}
`


python3Packages.XlsxWriter: 1.2.9 -> 3.0.2

Motivation for this change
https://github.com/jmcnamara/XlsxWriter/blob/main/Changes
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofborg build python3Packages.XlsxWriter

I didn't know I was code owner of this random python package

I didn't know I was code owner of this random python package

This was triggered by the changing of the branch. This one triggers too many rebuilds for master.

@ofborg eval


Update request flow document and diagram

Update the Kyma documentation describing the request flow in API Gateway.

Request flow
This diagram illustrates the request flow for three cases:

Accessing secured resources with an OAuth2 token
Accessing secured resources with a JWT token
Accessing unsecured resources without a token

TIP: Learn how to Configure authorizations.
Accessing secured resources with an OAuth2 token
The developer sends a request to access a secured resource with an OAuth2 access token issued for a registered client. The request is proxied by the Oathkeeper proxy. The proxy identifies the token as an OAuth2 access token and sends it to the registered Token Introspection endpoint in the Hydra OAuth2 server. The OAuth2 server validates the token and returns the outcome of the validation to Oathkeeper. If the validation is successful, Oathkeeper checks the token against the Access Rules that exist for the resource and authorizes the request. Upon successful authorization, the request is forwarded to the resource.
Accessing secured resources with a JWT token
The developer sends a request to access a secured resource with a JWT token. The request is proxied by the Oathkeeper proxy. The proxy identifies the token as a JWT token and fetches the public keys required for token validation from the registered OpenID Connect-compliant identity provider. Oathkeeper uses these keys to validate the token. If the validation is successful, Oathkeeper checks the token against the Access Rules that exist for the resource and authorizes the request. Upon successful authorization, the request is forwarded to the resource.
Accessing unsecured resources without a token
The developer sends a request to access a resource without a token. The request is proxied by the Oathkeeper proxy. The proxy checks if there are Access Rules created for the resource, and verifies if it can be accessed without a token. If the resource can be accessed without a token, the request is forwarded to the resource.


Added Unix and Windows ADO automation scripts

These scripts have been moved over from checkedc-clang into this new repo checkedc-automation.

Great work! Did you run automated testing for building the an Ubuntu 18.04 package to make sure that still works.
think you need to update the script for building packages on Windows, and run the automated jobs to build installers for 32-bit and 64-bit Windows to make sure they also still work. The script for building packages for Windows relies on msbuild, but we're now running cmake targeting ninja.
Did you figure how to use cmake/Ninja with the Visual Studio IDE?
We also need to update the documentation for checked c clang to mention that there are scripts for automation and that they live in this repo.

Thanks David. My idea was to get these scripts merged and then start moving jobs one-by-one to use these. The way I plan to do this is to clone each job and test the scripts on it and switch over the actual job to the new one and that's when I wanted to test the various scenarios (Ubuntu 18.04, 32-bit builds, etc).
I was able to successfully build using cmake/ninja with VS IDE. The steps are pretty straightforward and documented here: https://docs.microsoft.com/en-us/cpp/build/customize-cmake-settings?view=vs-2019
I can share these with Katherine and have her try them out too.
I will update the docs in the next PR.


woocommerce_molpay_seamless plugin clashes with WPLMS theme

Hi, as I checkout with MOLPAY, page got stuck with infinite loading:

Here is the error from console window:

Here is the script directed by console window:

I did not install ordering plugin since it is optional, but I have gone through all steps properly.
Could it be there is a clash of javascript?
Thanks.

Hi @serefina , upon checking. This happens due to jQuery library been loaded twice. May refer the fix from the following discussion.
https://stackoverflow.com/questions/47346965/wordpress-media-library-not-working-mediaelementplayer-is-not-a-function
https://stackoverflow.com/questions/7882374/how-do-i-implement-jquery-noconflict

Thank you!
Regards,
Emily
On 30 Aug 2019, at 13:18, chenyaau94 <notifications<EMAIL_ADDRESS>wrote:
Hi @serefinahttps://github.com/serefina , upon checking. This happens due to jQuery library been loaded twice. May refer the fix from the following discussion.
https://stackoverflow.com/questions/47346965/wordpress-media-library-not-working-mediaelementplayer-is-not-a-function
https://stackoverflow.com/questions/7882374/how-do-i-implement-jquery-noconflict
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MOLPay/WordPress_WooCommerce_WP-eCommerce_ClassiPress/issues/18?email_source=notifications&email_token=ADD25G6A3U6SLW4ZJ23H3RTQHCUSRA5CNFSM4IQY64CKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5QSBEA#issuecomment-526459024, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADD25G7YXBEDKHP3JKD6XETQHCUSRANCNFSM4IQY64CA.

Close as issue resolve.


Fix CMakeLists.txt includes dir when using project with add_subdirectory

Otherwise the search directory is incorrrect and compilation failes with
fatal error: 'ink_stroke_modeler/internal/prediction/kalman_filter/kalman_filter.h' file not found

CLA has been submitted.


isBinary field does not work with the property field in Azure backend

According to the PR at #311, the isBinary field doesn't work with property field for Azure backend. I have a idea to solve this and I am creating this issue to track it.

Essentially I am thinking of an Azure specific option propertyAzure that will be handled by the Azure backend only and won't trip the JSON.parse in the kv backend. This would help the Azure backend have the same compatibility options that is present without the isBinary field. Let me know how this sounds.

See #495


Fixed double post issues #36 and #37 by adding break statements to Switch

This should fix issues #36 and #37.  The switch statement in /routes/endpoints/slash/welcome/welcome.js was missing break; after each condition.  This was causing fall-through to the case below.  In addition, changed the switch condition to better reflect the data being sent in, so that the first case (two messages) only triggers if there are two unique target_Ids or channels.

This branch has been deployed to Glitch for review.  Feel free to message me to revert the environment when done with the review.


[ETFE-3115] Add submission model creation and update declaration view/controller

Note: raised as draft as #22 needs to go into main first and then this branch rebased from main.

Rebased from #22


README.md

Hello! Can you please make a README.md how can I use this code?

The lib is not yet stable. U can follow the test here to use it: https://github.com/youyuanwu/tonic-h3/blob/3bd143c782026d695e2cac9ed0e51a8b433aa8de/tonic-h3-tests/src/lib.rs#L58
But the APIs might change in future.

Great job man! I hope you continue this project. I will follow this project


App pop up error message when I use camera and upload

Describe the bug.
When I use the camera function to snap and upload, it show error message "Something want wrong"
Steps to reproduce.

Launch the app.

Click on the camera icon

Snap and upload  the image

And note the bug

Expected behavior
I expected that the camera should upload normally
Screen recording
https://youtu.be/gtIgPrPRe1o
Devices and Versions):)

Device: [Gionee]

Version [7.0]

App version [2.5.0]

hi @darewealth,
i worked on the backend interface that receives those images. can you check if the error persists?

The issues still persist

@darewealth Thank you for the feedback. Looking at your screen capture, it crashes while processing the image (resizing and compressing to jpg) which is done before uploading the photo. Unfortunately it's hard to tell what exactly the problem is. It might be that you're low on memory or disk space or it could be something device-specific. I will add more detailed error messages to the next version of the app so it's easier to pinpoint the issue.


Psych Engine 0.6.3 hxCodec is Broken????? idk

Describe your bug here.
So i am coding my mod in psych engine 0.6.3 (too lazy to port) and after update the libraries and stuff because the engine was like "i dont wanna compile" the videos started to have issues like an error popup when i first see a video on the game or the fact that videos doesn't loop.
yes, i changed to various versions (2.6.0, 2.5.1, git and 3.0.2)
and fixed the popup error and loop error but now i got a error that causes the game crash after the video play for the 3- 6 time while changing menus and getting get_buffer related errors.

 *  El proceso del terminal "C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe -Command lime test windows --connect 6000" finalizó con el código de salida 1.
 *  Las tareas reutilizarán el terminal, presione cualquier tecla para cerrarlo.

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
Most of the Files like PlayState and The Menus Looks but nothing related to the libraries codes, just the versions of them for compile lol

The first one also happens to me and I deleted the file in the bin and recompiled it and the error went away, although after a while it comes out again but it is the only temporary way I know, the second one I don't know

yeah, did that and solved the plugin thing but now the console keeps dropping that error and after 3-4 times from traveling trought menus the game crashes.
no idea why

If you still have problems with that, I think I can help you now, I found something to download all the requirements and also change various things in the files, the game no longer crashes when I switch between menus, if you want to talk faster we can use discord

oh sure why not
that would help me a lot
this is my discord: honton129

If you still have problems with that, I think I can help you now, I found something to download all the requirements and also change various things in the files, the game no longer crashes when I switch between menus, if you want to talk faster we can use discord

ok so externally we find out hxcodec just sucks only at mp4sprites wich is we got the problem lol
so i will just close this thing as not fixed and maybe when i found a solution or something i will comment it here


state change triggers onChange which is indistinguishable from a click

Am I off base on this? I've got a parent component that holds the rating in state and passes it as the initialRating prop. If the parent changes its state, it rerenders the Rating component. That triggers componentDidUpdate in Rating, which triggers onChange. But onChange is supposed to represent a click of the control. I only changed the rating programmatically, but since onChange fires, I can't tell that there hasn't been a click.
Thanks!

Could you please give an example where I can reproduce this behavior? Maybe it is related to #86...
You can use this codepen if you want.

In the constructor:
this.state = {
    rating: 0
}

and then:
onChangeRating = (rating) => {
    this.setState( {rating: rating},
      () => { this.props.goToScreen('feedback') });
}

```and in render():
`<Rating readonly={false} start={0} stop={5} initialRating={this.state.rating} fullSymbol={<FeedbackStarFull />} emptySymbol={<FeedbackStar />} onChange={this.onChangeRating.bind(this)}/>`

So, when I change my parent component state outside of these bits, it rerenders my parent, which rerenders Rating. Rating's componentDidUpdate() calls onChangeRating(), but I can't know in onChangeRating() whether onChangeRating() got called because the user clicked the Rating or because of my parent rerendering.

So I can't do what I'm doing here, which is to assume onChangeRating() is due to a click, and take the user to a feedback screen. My parent rerenders trigger onChangeRating(), which wrongly goes to the feedback screen when all my parent rerender wanted was to set the correct rating value.

Release 1.1.2 should solve this issue.
Now onChange is only called when the value is changed by a click event. It is not called when new props are passed.


One to One Relatoin Not working , Shows Empty Data

type User struct {
	Id       int64
	Username string
	Email    string
	Profile  Profile
}

type Profile struct {
	Id        int64
	UserID    int64 `sql:"index"`
	Firstname string
	Lastname  string
}

func GetUsers(c *gin.Context) {

	var users []User
	var profile []Profile
	db.Select("id, username, email").Find(&users)

	db.Model(&profile).Related(&users)

	c.JSON(200, users)

}

It shows the Users table data but the Profile is empty . I have tried all combinations Has One , Belongs To .. I am not able to get any results . What am i doing wrong ?

I'm having the same issue. gorm runs only one insert query when we save the user, profile doesn't get saved

the profile should be an struct, but not slice. and it needs to have primary key value.

making profile a struct does not solve the problem i am getting empty result sets


Azure Blob Services API - ABSBlobClient.CopyBlob is cumbersome to use

CopyBlob on ABSBlobClient in Azure Blob Services API has the following defition:
CopyBlob(BlobName: Text; SourceName: Text)

Where BlobName is the destination and SourceName is the source.
A note about the SourceName which maps to x-ms-copy-source is that when using API version beginning with 2012-02-12, the Source MUST be the full URL of the object.
So if I want to copy a blob from test/source.txt to test/destination.txt inside my current ABSBlobClient, I have to do the following:
ABSBlobClient := ABSBlobClient.Initialize('myaccount', 'mycontainer', Authorization);
ABSBlobClient.CopyBlob('test/destination.txt', ' https://myaccount.blob.core.windows.net/mycontainer/test/source.txt');

The URL I have to build, if I do not want to hardcode variables. The URL can already be generated by the library, but is marked as Internal.
As far as I can see, all other functions regarding ABSBlobClient, the blobnames are simply blobnames and not full URL's.
This confuses developers using the app as can be seen in #15011, #21671 as the service returns error 400.
Some suggestions to make it easier to use

Create a new function CopyBlobInContainer which finds the URL, by using "ABS URI Helper".ConstructUri to find the URL of the BLOB
Highligt that the source MUST be the full URL of the blob

@joandrsn this looks like a good improvement for the system application, that is totally open source.
And if there are already test for CopyBlobInContainer it should be not this difficult to create new test for a new procedure.
Feel free to create a pull request to fix it on your own.

I just subscribed to this ticket because I tried using CopyBlob incorrectly too.  After using the other ABS functions which take storage account and container names as parameters I tried to use the CopyBlob function in a similar way.  i.e. just specifying the blob 'name' like this
        ABSBlobClient.Initialize('abstemptest', 'blobtest', Authorisation);
        Response := ABSBlobClient.CopyBlob('TestTextFileCopy.txt', 'TestTextFile.txt');

which promptly gave me the error

The error stumped me for a while because ABSBlobClient is initialised to the specific storage container so calling CopyBlob on it in the context of the container is a logical thing to do. It wasn't till I came looking here that I realised I needed to specify a URL for the SourceName parameter.

I believe this issue was fixed with PR #24481.
The snippet now looks for HTTP in the URL:
https://github.com/microsoft/BCApps/blob/203e4001cb5d1e8e8b51e24fba406921e3a21486/src/System Application/App/Azure Blob Services API/src/ABSClientImpl.Codeunit.al#L616-L619
Thank you @ajkauffmann


how to update Ionicons icons

i have been checkout Ionicons's site ~ it looks updated
so i was wondering if i can update the icons
thx~

See this thread: https://github.com/oblador/react-native-vector-icons/issues/200


HTML

HTML
User Story
As a boot camp student
I want the Prework notes to be structured on a webpage
so that I can easily find and read information
Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I visit the website in my browser
THEN I see four boxes titled HTML, CSS, Git, and JavaScript with associated notes listed

Updated the HTML file and pushed the same to Github.


Upgrade com.uber.nullaway:nullaway 0.10.8 -> 0.10.9

This PR contains the following updates:

Package
Type
Update
Change

com.uber.nullaway:nullaway

patch
0.10.8 -> 0.10.9

com.uber.nullaway:nullaway
compile
patch
0.10.8 -> 0.10.9

Release Notes

uber/NullAway
v0.10.9
Compare Source

Add support for external init annotations in constructors (#725)
Ignore incompatibly annotated var args from Kotlin code. (#721)
Support for specific libraries/APIs:

Add Throwable.getCause and getLocalizedMessage() library models (#717)
Support more test assertions in OptionalEmptinessHandler (#718)
Support isInstanceOf(...) as implying non-null in assertion libraries (#726)

[Refactor] Avoid redundant Map lookups (#722)
Build / CI tooling for NullAway itself:

Update to Error Prone 2.18.0 (#707)

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade NullAway 0.10.8 -> 0.10.9

See:
- https://github.com/uber/NullAway/blob/master/CHANGELOG.md
- https://github.com/uber/NullAway/compare/v0.10.8...v0.10.9


COMP: Fix GPU modules PrintSelf compiler errors

COMP: Restore PrintSelf in itkGPUPDEDeformableRegistrationFilter.h
COMP: Provide prefix-less member name to itkPrintSelfObjectMacro
COMP: Fix compile error due to a missing parenthesis
ENH: Provide printing ability to time resource classes

PR Checklist

[X] No API changes were made (or the changes have been approved)
[X] No major design changes were made (or the changes have been approved)

I am building locally. The commit I pushed was an obvious fix which I did before providing you the rest of the errors.

Output-Build.txt
4 projects failed to build now. I think this is less.

I am building locally.

Will fail if you do not comment TimeProbe object instance serialization in itkGPUFiniteDifferenceImageFilter.hxx. I will propose adding printing capabilities in a new commit within this PR if we are sure it is definitely an ovesight.

Will fail if you do not comment TimeProbe object instance serialization in itkGPUFiniteDifferenceImageFilter.hxx. I will propose adding printing capabilities in a new commit within this PR if we are sure it is definitely an ovesight.

@dzenanz Please test locally when you have time. We may need to change
 os << indent << "InitTime: " << static_cast<typename NumericTraits<TimeProbe>::PrintType>(m_InitTime) << std::endl;
 os << indent
 os << "ComputeUpdateTime: " << static_cast<typename NumericTraits<TimeProbe>::PrintType>(m_ComputeUpdateTime)
    << std::endl;
 os << indent << "ApplyUpdateTime: " << static_cast<typename NumericTraits<TimeProbe>::PrintType>(m_ApplyUpdateTime)
    << std::endl;
 os << indent << "SmoothFieldTime: " << static_cast<typename NumericTraits<TimeProbe>::PrintType>(m_SmoothFieldTime)
    << std::endl;

to
m_InitTime.Prin(os, indent);
m_ComputeUpdateTime.Print(os, indent);
m_ApplyUpdateTime.Print(os, indent);
m_SmoothFieldTime.Print(os, indent);

but I want to see if that is strictly necessary.

My last commit makes it compile cleanly, but 3 tests now fail:
itkGPUGradientAnisotropicDiffusionImageFilterTest2D (Failed)
itkGPUGradientAnisotropicDiffusionImageFilterTest3D (Failed)
itkGPUDemonsRegistrationFilterTest2 (SEGFAULT)

I will look into it next week, unless someone else takes a look over the weekend.

My last commit makes it compile cleanly,

Thanks @dzenanz :100:. Sorry for not having addressed all.

but 3 tests now fail:
I will look into it next week, unless someone else takes a look over the weekend.

I will not be able to look into this.

The latest force-push fixes all test errors for me. Feel free to merge this into other commits, or otherwise reorganize PR.

The latest force-push fixes all test errors for me. Feel free to merge this into other commits, or otherwise reorganize PR.

Done. Thanks @dzenanz :100:.

/azp run ITK.macOS

/azp run ITK.Linux


reviewer comments

really great stuff! My feedback begins on line 526 of the Rmd
@datalorax

Thanks Diana! Unfortunately, something went wrong with your commit so you can't easily see the changes you made (it looks like the entire file was deleted and then added again).
I did see your summary review at the bottom, however. I liked the idea of including a textbox or caption to discuss missing data. Nice review overall!


PACT to verify Status code 206 or 400

I'm trying to verify the PACT with status code 400 but i'm unable to generate a PACT because of its failing due to mocked server

I doubt this is failing due to mocked server. More likely, it is failing due to the HTTP client you are using will throw an exception when it receives a 400+ response.

Yes, exactly how to over come it

You need to handle the exception in your test code.

Any example which helps me, I tried it but unable to achieve it.

Here you go: https://github.com/DiUS/pact-jvm/blob/master/pact-jvm-consumer-junit/src/test/java/au/com/dius/pact/consumer/PactConsumer400Test.java


Getting embeddings using text-embedding-005 model

REQUIRED: Demonstrate how to get embeddings using text-embedding-005 model.

--- Make text-embedding-005 and CODE_RETRIEVAL_QUERY the default ---

REQUIRED: Fill out the below checklists or remove if irrelevant

If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:

[X] Use the notebook template as a starting point.
[X] Follow the style and grammar rules outlined in the above notebook template.
[X] Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
[X] Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
[X] You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
[ ] This notebook has been added to the CODEOWNERS file under the Official Notebooks section, pointing to the author or the author's team.
[ ] The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

Stale.


Don't echo authentication passwords (rest backend)

What is the purpose of this change? What does it change?
Bugfix: Don't echo authentication passwords
When using a password in the URL of a rest backend, in some cases
the password was displayed in the restic log:

when creating a repository
when restic failed to open the repository

The URL should now be displayed with "***" in place of the password.
Fixes issue https://github.com/restic/restic/issues/2241
Was the change discussed in an issue or in the forum before?
closes #2241
Checklist

[x] I have read the Contribution Guidelines
[x] I have enabled maintainer edits for this PR
[x] I have added tests for all changes in this PR
~I have added documentation for the changes (in the manual)~
[x] There's a new file in changelog/unreleased/ that describes the changes for our users (template here)
[x] I have run gofmt on the code in all commits
[x] All commit messages are formatted in the same style as the other commits in the repo
[x] I'm done, this Pull Request is ready for review

Question before ticking the last box:
Do you know of any other place where the password could be displayed in the log? I cannot find any other place.

Please rebase the PR onto the current master branch.

Sorry, this was my intention but I pushed the wrong branch 😥

Sorry, this was my intention but I pushed the wrong branch 😥

Do you need help with rebasing?

I think I managed, it's just something I don't do every day so I forget the git commands 👍 thanks

Hmm, is this specific to the REST backend, or are there other backends that it affects/fixes too? In other words, is this something that is only worth mentioning for the REST backend?

@rawtaz The PR only affects the REST backend. I'm not aware that other backends have the option to include a password in the repository address.

I noticed that the changelog entry said the password was replaced with "", which is what I think is most conventional and makes more sense than "xxxxx". Can you please make the code and also the tests use "" for the obfuscation instead of "xxxxx"?

@creativeprojects Could you also mask the repository URL in the debug.Log call in line 607 of cmd/restic/global.go?

Could you also mask the repository URL in the debug.Log call in line 607 of cmd/restic/global.go?

I was a bit puzzled by it, and couldn't find it the other day. But I think I found it now: do you mean the one in line 617?
https://github.com/creativeprojects/restic/blob/issue-2241/cmd/restic/global.go#L617

I was a bit puzzled by it, and couldn't find it the other day. But I think I found it now: do you mean the one in line 617?
https://github.com/creativeprojects/restic/blob/issue-2241/cmd/restic/global.go#L617

Oh, sorry for the confusion, apparently the debug.Log statement moved in the meantime. I had debug.Log("parsing location %v", s) in mind which is now in line 634 on your branch.


Sort conditional exports objects

The default field should be sorted to appear last in the a conditional exports object.
Additionally, the types field should be sorted to appear first when present.
The Node.js documentation has some information on ordering rules:

"default" - the generic fallback that always matches. Can be a CommonJS or ES module file. This condition should always come last. (source)

Nested conditions should also be sorted.
Related to #197

PRs welcome! I think also getting opinions from folks in #197 (@dandv, @Xunnamius) would be useful.


define all typography

Issue

close #236

Overview (Required)

add roboto_regular.ttf and roboto_medium.ttf
define all typography

Links

I downloaded roboto font here.

https://fonts.google.com/specimen/Roboto

Screenshot

Before
After

Please run spotlessKotlinApply🙏


too many divs

In place of divs you can use other elements like sections, figures or articles

They're purely for styling (not for images or articles).


Spring Boot Plugin: bootJar does not work when you change default excludes only in IJ Plugin

What happened?
Currently the plugin fails to run the bootJar with the following error:
Execution failed for task ':app-docker:bootJar'.
Cannot change default excludes during the build. They were changed from [**/##, **/%%, **/~, **/.#, **/.DS_Store, **/., **/.bzr, /.bzr/, **/.bzrignore, **/.cvsignore, **/.git, /.git/, **/.gitattributes, **/.gitignore, **/.gitmodules, **/.hg, /.hg/, **/.hgignore, **/.hgsub, **/.hgsubstate, **/.hgtags, **/.svn, /.svn/, **/CVS, /CVS/, **/SCCS, /SCCS/, /vssver.scc] to [/##, **/%%, **/~, **/.#*, **/.DS_Store, **/.*, **/.bzr, /.bzr/, **/.bzrignore, **/.cvsignore, **/.git, /.git/, **/.gitattributes, **/.gitmodules, **/.hg, /.hg/, **/.hgignore, **/.hgsub, **/.hgsubstate, **/.hgtags, **/.svn, /.svn/, **/CVS, /CVS/, **/SCCS, /SCCS/, **/vssver.scc]. Configure default excludes in the settings script instead.

However, if you run the same task from the command line using the same gradle wrapper it works.
Relevant log output or stack trace
Execution failed for task ':app-docker:bootJar'.
> Cannot change default excludes during the build. They were changed from [**/#*#, **/%*%, **/*~, **/.#*, **/.DS_Store, **/._*, **/.bzr, **/.bzr/**, **/.bzrignore, **/.cvsignore, **/.git, **/.git/**, **/.gitattributes, **/.gitignore, **/.gitmodules, **/.hg, **/.hg/**, **/.hgignore, **/.hgsub, **/.hgsubstate, **/.hgtags, **/.svn, **/.svn/**, **/CVS, **/CVS/**, **/SCCS, **/SCCS/**, **/vssver.scc] to [**/#*#, **/%*%, **/*~, **/.#*, **/.DS_Store, **/._*, **/.bzr, **/.bzr/**, **/.bzrignore, **/.cvsignore, **/.git, **/.git/**, **/.gitattributes, **/.gitmodules, **/.hg, **/.hg/**, **/.hgignore, **/.hgsub, **/.hgsubstate, **/.hgtags, **/.svn, **/.svn/**, **/CVS, **/CVS/**, **/SCCS, **/SCCS/**, **/vssver.scc]. Configure default excludes in the settings script instead.

Steps to reproduce
Create a project that uses gradle plugin id 'org.springframework.boot' version '3.2.4'.
Add the following to the projects setting.gralde file:

import org.apache.tools.ant.DirectoryScanner

DirectoryScanner.removeDefaultExclude('**/.gitignore')

Run bootJar gradle task using intellij plugin.
Gradle IntelliJ Plugin version
241.14494.240
Gradle version
8.5
Operating System
Windows
Link to build, i.e. failing GitHub Action job
No response

How is this issue related to the IntelliJ Platform Gradle Plugin?

Because it only fails when I run the task using the Intellij Platform Gradle Plugin. If you run it from the command line using the same version of gradle it works as expected.

You mislead it with the Gradle plugin for IntelliJ IDEA.
This project is a plugin for the Gradle build system, used for developing plugins.

Please file an issue in YouTrack, in the IntelliJ IDEA project:
https://youtrack.jetbrains.com/newIssue?project=IDEA