Error when running simulate

Hi ,
I am trying to run Scaden simulate for my data .
This is how my data looks currently :
data_counts.txt : 2627 rows (cell types )  and 26405 columns ( genes )
data_celltypes.txt : 2627 cell type labels corresponding to the rows in data_counts.txt.
When I run the command
scaden simulate --data data_scaden/ -n 100 --pattern "*_counts.txt"

I get the following output and the .h5ad file is not created:
Datasets: ['data']
Loading data dataset ...
Index(['Celltype'], dtype='object')
CRITICAL:root:No common genes found. Exiting.

Please let me know if I am going wrong somewhere? and How I can fix this ?
Thanks ,
RK

Hi RK,
this looks like a formatting issue. Can you quickly run
scaden example
And check whether your data has a similar format as the example data that is generated?

Hi Kevin,
I checked and realized it was because I had created the file with R and it didnt read in properly. I fixed it and was able to generate the training sets. But I have a new error now:
Datasets: ['data']
Loading data dataset ...
Index(['Celltype'], dtype='object')
No. of common genes: 26404
Merging unknown cell types: ['unknown']
Available celltypes: ['SC-T3', 'SC-T1', 'SC-B1', 'SC-M2', 'SC-B4', 'SC-M3', 'SC-B2', 'SC-F1', 'SC-T6', 'SC-F4', 'SC-M4', 'SC-M1', 'SC-T4', 'SC-F3', 'SC-F2', 'SC-T2', 'SC-T5', 'SC-B3']
Subsampling data...
Normal samples: 100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 50/50 [00:29<00:00,  1.70it/s]
Sparse samples: 100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 50/50 [00:15<00:00,  3.28it/s]
Finished!
Celltypes: ['SC-T3', 'SC-T1', 'SC-B1', 'SC-M2', 'SC-B4', 'SC-M3', 'SC-B2', 'SC-F1', 'SC-T6', 'SC-F4', 'SC-M4', 'SC-M1', 'SC-T4', 'SC-F3', 'SC-F2', 'SC-T2', 'SC-T5', 'SC-B3']
Found datasets: ['data', 'example']
Processing data
c:\users\rk\anaconda3\lib\site-packages\anndata\_core\anndata.py:119: ImplicitModificationWarning: Transforming to str index.
  warnings.warn("Transforming to str index.", ImplicitModificationWarning)
Traceback (most recent call last):
  File "c:\users\rk\anaconda3\lib\runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "c:\users\rk\anaconda3\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\rk\Anaconda3\Scripts\scaden.exe\__main__.py", line 7, in <module>
  File "c:\users\rk\anaconda3\lib\site-packages\scaden\__main__.py", line 33, in main
    cli()
  File "c:\users\rk\anaconda3\lib\site-packages\click\core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "c:\users\rk\anaconda3\lib\site-packages\click\core.py", line 782, in main
    rv = self.invoke(ctx)
  File "c:\users\rk\anaconda3\lib\site-packages\click\core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "c:\users\rk\anaconda3\lib\site-packages\click\core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "c:\users\rk\anaconda3\lib\site-packages\click\core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "c:\users\rk\anaconda3\lib\site-packages\scaden\__main__.py", line 176, in simulate
    simulation(simulate_dir=out,
  File "c:\users\rk\anaconda3\lib\site-packages\scaden\simulate.py", line 20, in simulation
    create_h5ad_file(simulate_dir, out_name, unknown_celltypes)
  File "c:\users\rk\anaconda3\lib\site-packages\scaden\preprocessing\create_h5ad_file.py", line 92, in create_h5ad_file
    y = sort_celltypes(y, labels, celltypes)
  File "c:\users\rk\anaconda3\lib\site-packages\scaden\preprocessing\create_h5ad_file.py", line 61, in sort_celltypes
    idx = [labels.index(x) for x in ref_labels]
  File "c:\users\rk\anaconda3\lib\site-packages\scaden\preprocessing\create_h5ad_file.py", line 61, in <listcomp>
    idx = [labels.index(x) for x in ref_labels]
ValueError: 'SC-T3' is not in list

Could you please help me figure this out?
Thanks!

Hi,
the issue seems to be that a celltype in your reference celltype list is not in you simulated data.
Could you give me the exact commands you have been using so far?
Thanks!

Hi Kevin
I ran the following command:
scaden simulate --data zhang_data/ -n 100 --pattern "*_counts.txt"

Here is the data I used:
https://drive.google.com/drive/folders/15XDsJkbaM_LipLKVk2Ui9JYekkXG0ytU?usp=sharing
Let me know if you need anything else .
Thanks

Hi
Sorry for the trouble ,
But now I am able to create the data.h5ad and processed.h5ad files.
However when I run scaden train , I get the following error:
Traceback (most recent call last):
  File "c:\users\ramya.mallela\anaconda3\lib\runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "c:\users\ramya.mallela\anaconda3\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\ramya.mallela\Anaconda3\Scripts\scaden.exe\__main__.py", line 7, in <module>
  File "c:\users\ramya.mallela\anaconda3\lib\site-packages\scaden\__main__.py", line 33, in main
    cli()
  File "c:\users\ramya.mallela\anaconda3\lib\site-packages\click\core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "c:\users\ramya.mallela\anaconda3\lib\site-packages\click\core.py", line 782, in main
    rv = self.invoke(ctx)
  File "c:\users\ramya.mallela\anaconda3\lib\site-packages\click\core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "c:\users\ramya.mallela\anaconda3\lib\site-packages\click\core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "c:\users\ramya.mallela\anaconda3\lib\site-packages\click\core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "c:\users\ramya.mallela\anaconda3\lib\site-packages\scaden\__main__.py", line 76, in train
    training(data_path=data_path,
  File "c:\users\ramya.mallela\anaconda3\lib\site-packages\scaden\train.py", line 64, in training
    cdn256.train(input_path=data_path, train_datasets=train_datasets)
  File "c:\users\ramya.mallela\anaconda3\lib\site-packages\scaden\model\scaden.py", line 295, in train
    self.logits = self.model(x, training=True)
  File "c:\users\ramya.mallela\anaconda3\lib\site-packages\tensorflow\python\keras\engine\base_layer.py", line 998, in __call__
    input_spec.assert_input_compatibility(self.input_spec, inputs, self.name)
  File "c:\users\ramya.mallela\anaconda3\lib\site-packages\tensorflow\python\keras\engine\input_spec.py", line 255, in assert_input_compatibility
    raise ValueError(
ValueError: Input 0 of layer sequential is incompatible with the layer: expected axis -1 of input shape to have value 100 but received input with shape (128, 26404)

Please let me know how I can fix this
Thanks
Rk

Hi RK,
glad you fixed it - I will look into this, it shouldn't be so easy to break.
As far as I can tell you are running on windows, right? I fear that this might be the cause for your problems, because I couldn't directly find an issue with your data.
I will try to replicate the error locally!

Okay I could run the command without changing anything in the celltypes file, so it is very likely something windows specific. If you can, try on any kind of unix-system (Mac or Linux).
One thing I noticed is that your .h5ad file was created using your data and the example data, so make sure you delete those example files from the folder before simulation and any other steps! That might cause the problem.
(base) kevin@kevins-mbp scaden_test % scaden simulate --data deconv_data -n 100 --pattern "*_counts.txt"

     ____                _
    / ___|  ___ __ _  __| | ___ _ __
    \___ \ / __/ _` |/ _` |/ _ \ '_ \
     ___) | (_| (_| | (_| |  __/ | | |
    |____/ \___\__,_|\__,_|\___|_| |_|

Datasets: ['data']
Loading data dataset ...
Index(['Celltype'], dtype='object')
No. of common genes: 26404
Merging unknown cell types: ['unknown']
Available celltypes: ['SC_B4', 'SC_F2', 'SC_M4', 'SC_T3', 'SC_T1', 'SC_B3', 'SC_F4', 'SC_T4', 'SC_F3', 'SC_F1', 'SC_T6', 'SC_T2', 'SC_B2', 'SC_M3', 'SC_T5', 'SC_M1', 'SC_B1', 'SC_M2']
Subsampling data...
Normal samples: 100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 50/50 [00:18<00:00,  2.71it/s]
Sparse samples: 100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 50/50 [00:11<00:00,  4.54it/s]
Finished!
Celltypes: ['SC_B4', 'SC_F2', 'SC_M4', 'SC_T3', 'SC_T1', 'SC_B3', 'SC_F4', 'SC_T4', 'SC_F3', 'SC_F1', 'SC_T6', 'SC_T2', 'SC_B2', 'SC_M3', 'SC_T5', 'SC_M1', 'SC_B1', 'SC_M2']
Found datasets: ['data']
Processing data
/Users/kevin/anaconda3/lib/python3.8/site-packages/anndata/_core/anndata.py:119: ImplicitModificationWarning: Transforming to str index.
  warnings.warn("Transforming to str index.", ImplicitModificationWarning)
... storing 'ds' as categorical

Hi kevin,
Thanks a lot for looking into this .
That is weird, because I have my data in a separate folder, though it says Found datasets: ['data', 'example']

Exactly, that's a bit weird. Maybe make sure to delete everything example related and try again :)

I am able to train the model.
Just one more question:
How many models does it train on?

Awesome :)
Scaden trains three different DNNs for 5000 steps and then averages their predictions.

Hi Kevin,
I was successfully able to train the model , but I got the following error .
Please note: I initially ran this on windows, but I also did another run on Ubuntu 18.04.5 .
2021-02-25 08:04:19.030342: I tensorflow/compiler/jit/xla_cpu_device.cc:41] Not creating XLA devices, tf_xla_enable_xla_devices not set
2021-02-25 08:04:19.030483: W tensorflow/stream_executor/platform/default/dso_loader.cc:60] Could not load dynamic library 'libcuda.so.1'; dlerror: libcuda.so.1: cannot open shared object file: No such file or directory
2021-02-25 08:04:19.030500: W tensorflow/stream_executor/cuda/cuda_driver.cc:326] failed call to cuInit: UNKNOWN ERROR (303)
2021-02-25 08:04:19.030517: I tensorflow/stream_executor/cuda/cuda_diagnostics.cc:156] kernel driver does not appear to be running on this host (xxxx): /proc/driver/nvidia/version does not exist
2021-02-25 08:04:19.030721: I tensorflow/core/platform/cpu_feature_guard.cc:142] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX2 AVX512F FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
2021-02-25 08:04:19.031302: I tensorflow/compiler/jit/xla_gpu_device.cc:99] Not creating XLA devices, tf_xla_enable_xla_devices not set
2021-02-25 08:04:20.356815: I tensorflow/compiler/mlir/mlir_graph_optimization_pass.cc:116] None of the MLIR optimization passes are enabled (registered 2)
2021-02-25 08:04:20.376247: I tensorflow/core/platform/profile_utils/cpu_utils.cc:112] CPU Frequency:<PHONE_NUMBER> Hz

Let me know if there are any dependencies I am missions. Also, I am not using any GPU.
Thanks !

Okay wow you really collect all the errors 😁
Alright, how did you install Scaden?
Is there a possibility to just use the docker image I provide instead? This seems to be some system related issue.

Haha!
I installed Scaden with pip .
I have some other issue with using docker currently due to the way its set up , which is why I had to install scaden.
Okay - I will look into it .
Do let me know if there is anything that can help.
Thanks!

Okay ... yes it looks like a problem with tensorflow, which has given me headaches in that area quite frequently.
Not really sure what the issue is and how to solve it. But you could try just uninstalling and re-installing tensorflow in your environment (so pip uninstall tensorflow and then pip install tensorflow), maybe that helps.

Oh actually - you said you were able to train the model - did that run through? Could you make the prediction?
Those might just be extensive logging messages that you can ignore. I think I saw them before.

Okay yes - nevermind . I just ran it and I think I have some predictions .
Sorry for the trouble! and thanks once again!


Setup Travis

Set up travis to run tests automatically when you push or get pull requests.

Travis CI has now been integrated with legionJS.


Refine natural keys for various DCIM models

Closes: #3972
What's Changed

TODO

[ ] Explanation of Change(s)
[ ] Added change log fragment(s) (for more information see the documentation)
[ ] Attached Screenshots, Payload Example
[ ] Unit, Integration Tests
[ ] Documentation Updates (when adding/changing features)
[ ] Example Plugin Updates (when adding/changing features)
[ ] Outline Remaining Work, Constraints from Design

Do i still need to write test for these models with changed natural_key? 🤷🏽♂
Since there are test already for natural_key


Add option to leave suite and os empty

:person_frowning: Problem Statement
Right now, I’m defining my suites and os in my kitchen.yml file and overwriting sections like the driver itself with a different kitchen file.
But this could always contain differences between every cookbooks.
When I add a new platform, I just want to add this platform into my kitchen.yml file and not additionally to my GH Action yml file.
I know, it will change the behaviour in the view of the action into a single one instead of the matrix way. So it would also be great to have a concurrent option, which could be set. So different suites can be ran at the same time.
:grey_question: Possible Solution

Make suite and os optional
Add concurrent option with numbers as inputs

:arrow_heading_up: Describe alternatives you've considered
The only way would be not to use this action.

Happy to have this feature added if you want to write the code!


Fix "SyntaxWarning: is with a literal."

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: nis-spiir sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #651 into master will decrease coverage by 0.72%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #651      +/-   ##
==========================================
- Coverage   87.01%   86.29%   -0.73%
==========================================
  Files          52       50       -2
  Lines        5285     5283       -2
  Branches      566      559       -7
==========================================
- Hits         4599     4559      -40
- Misses        513      535      +22
- Partials      173      189      +16

Impacted Files
Coverage Δ

...storage-blob/azure/storage/blob/baseblobservice.py
91.60% <0.00%> (-0.37%)
:arrow_down:

...torage-blob/azure/storage/blob/_upload_chunking.py
71.86% <100.00%> (ø)

...storage-common/azure/storage/common/_connection.py
94.20% <100.00%> (-2.90%)
:arrow_down:

azure-storage-queue/azure/storage/queue/_error.py
78.57% <0.00%> (-21.43%)
:arrow_down:

...-storage-common/azure/storage/common/_constants.py
91.30% <0.00%> (-8.70%)
:arrow_down:

...torage-queue/azure/storage/queue/_serialization.py
81.81% <0.00%> (-6.07%)
:arrow_down:

...-common/azure/storage/common/_common_conversion.py
61.03% <0.00%> (-5.20%)
:arrow_down:

...-storage-file/azure/storage/file/_serialization.py
77.77% <0.00%> (-4.45%)
:arrow_down:

...zure-storage-common/azure/storage/common/_error.py
80.34% <0.00%> (-3.42%)
:arrow_down:

azure-storage-common/azure/storage/common/_auth.py
88.23% <0.00%> (-2.95%)
:arrow_down:

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ee73e7...8d8e950. Read the comment docs.

Can this be merged?
Also support for python34 seems a bit silly, it was released in March 2014 and is EOL

@nis-spiir - Thanks!
I also just now got these warnings on Python 3.8 and wanted to send this PR.
Looks like this repo isn't active any more?!
See https://github.com/Azure/azure-storage-python/issues/655#issuecomment-623129287
/usr/local/Cellar/azure-cli/2.4.0/libexec/lib/python3.8/site-packages/azure/storage/blob/_upload_chunking.py:403: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if n is 0 or self._buffer.closed:
/usr/local/Cellar/azure-cli/2.4.0/libexec/lib/python3.8/site-packages/azure/storage/blob/baseblobservice.py:1009: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if lease_duration is not -1 and \
/usr/local/Cellar/azure-cli/2.4.0/libexec/lib/python3.8/site-packages/azure/storage/blob/baseblobservice.py:2660: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if lease_duration is not -1 and \
/usr/local/Cellar/azure-cli/2.4.0/libexec/lib/python3.8/site-packages/azure/storage/common/_connection.py:82: SyntaxWarning: "is" with a literal. Did you mean "=="?
  self.protocol = self.protocol if parsed_url.scheme is '' else parsed_url.scheme


Getting undefined method error on has-many through search

related to http://projects.theforeman.org/issues/10551
Searching this particular has-many through relationship will cause raise an error. Autocomplete works fine.
has_many :environments, :through      => :content_view_environments,
                        :class_name   => "Katello::KTEnvironment",
                        :inverse_of   => :content_view_versions,
                        :after_remove => :remove_environment

scoped_search :in => :environments, :on => :name, :rename => :environment, :complete_value => true

server output
2015-05-27 11:23:05 [I] Completed 500 Internal Server Error in 16.6ms (Views: 0.3ms | ActiveRecord: 1.2ms)
2015-05-27 11:23:05 [D] With body: {"displayMessage":"undefined method `klass' for nil:NilClass","errors":["undefined method `klass' for nil:NilClass"]}

@jlsherrill

I investigated this a tad bit (when i was investigating the issue with @johnpmitsch), the issue is here:
https://github.com/wvanbergen/scoped_search/blob/master/lib/scoped_search/query_builder.rb#L260
reflection_by_name() is being called and passed a table name, not the name of an association.  Since we are using this within an isolated engine and are properly namespacing all of our models, the table name here is katello_content_view_environments, but the association name on the end object is simply 'content_view_environments'.
You can reproduce this in the test with this simple change:
diff --git a/spec/integration/relation_querying_spec.rb b/spec/integration/relation_querying_spec.rb
index 53638c6..01149e4 100644
--- a/spec/integration/relation_querying_spec.rb
+++ b/spec/integration/relation_querying_spec.rb
@@ -255,7 +255,7 @@ ScopedSearch::RSpec::Database.test_databases.each do |db|

         # The related classes
         class Mar < ActiveRecord::Base; belongs_to :baz; belongs_to :koo; end
-        class Baz < ActiveRecord::Base; has_many :mars; end
+        class Baz < ActiveRecord::Base; has_many :other_mars, :class_name => "Mar", :foreign_key => :b

         # The class on which to call search_for
         class Koo < ActiveRecord::Base

@wvanbergen @domcleal thanks! any idea when this will be released so we can start using it in katello?

Version 3.2.2 has been released.

@wvanbergen :+1:


Phone number

Is it possible to send a message using the phone number of the user?

I figured it out myself :D if somebody is wondering, it is like
Bot.deliver(
recipient: {
id: '45123'
phone_number: 'phone number here'
},
message: {
text: 'Human?'
}
)


Reduce duplicate code in image building tasks/mojos

We could probably organize this in the framework style like how the registry requests work.

Related to https://github.com/GoogleContainerTools/jib/issues/478 as well

I think this is done for the most part. Feel free to reopen if you think there's more that should be done.


Split cache

Description
Describe the proposed changes made in this PR.
How was this PR tested?
Describe how you tested this PR.

Superseded by #3857.


[Publishing] Create Gcloud commands and rest API for below templates. Target JDBC

Java - GCSToJDBC
Python - GCSToJDBC
Python - JDBCToJDBC
Add the commands in : go/go/dataproc-gcp-documentation-internal document also contains commands for reference from other templates

Added to document

LGTM


[Bugs] : Content not found

Site URL
https://www.linkshub.dev/languages/cpp
Description of the above provided site
No content found in languages > c ++ programming
Category
Languages
Sub Category
c++
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)

You've been assigned @rahulpandey70

It is a bug @rahulpandey70 . As you can see, there are resources present in this subcategory,

Don't add a new resource, there must be a issue while referencing the category name. Refer to contributing guidelines.


CAMEL-11682: Add sasl.jaas.config setting

I have tested the PR against IBM MessageHub and it worked with the following routes:
final String brokers = "kafka04-prod01.messagehub.services.eu-de.bluemix.net:9093,kafka05-prod01.messagehub.services.eu-de.bluemix.net:9093";

final String saslJaasConfig = "org.apache.kafka.common.security.plain.PlainLoginModule required username=\"USERNAME\" password=\"PASSWORD\";";

from("direct:in")
.to("kafka:test?"
    + "brokers=" + brokers
    + "&saslMechanism=PLAIN"
    + "&securityProtocol=SASL_SSL"
    + "&sslProtocol=TLSv1.2"
    + "&sslEnabledProtocols=TLSv1.2"
    + "&sslEndpointAlgorithm=HTTPS"
    + "&saslJaasConfig=" + saslJaasConfig );

and KafkaConsumer
final String brokers = "kafka04-prod01.messagehub.services.eu-de.bluemix.net:9093,kafka05-prod01.messagehub.services.eu-de.bluemix.net:9093";

final String saslJaasConfig = "org.apache.kafka.common.security.plain.PlainLoginModule required username=\"USERNAME\" password=\"PASSWORD\";";

from("kafka:test?"
    + "brokers=" + brokers
    + "&saslMechanism=PLAIN"
    + "&securityProtocol=SASL_SSL"
    + "&sslProtocol=TLSv1.2"
    + "&sslEnabledProtocols=TLSv1.2"
    + "&sslEndpointAlgorithm=HTTPS"
    + "&saslJaasConfig=" + saslJaasConfig
    + "&groupId=mygroup")
.to("stream:out");

The camel-kafka tests were failing on master before I made my changes.  The failures were:
[ERROR] Failures:
[ERROR] org.apache.camel.component.kafka.KafkaConsumerOffsetRepositoryEmptyTest.shouldStartFromBeginningWithEmptyOffsetRepository(org.apache.camel.component.kafka.KafkaConsumerOffsetRepositoryEmptyTest)
[ERROR]   Run 1: KafkaConsumerOffsetRepositoryEmptyTest.shouldStartFromBeginningWithEmptyOffsetRepository:74 mock://result Received message count. Expected: <10> but was: <0>
[ERROR]   Run 2: KafkaConsumerOffsetRepositoryEmptyTest.shouldStartFromBeginningWithEmptyOffsetRepository:74 mock://result Received message count. Expected: <10> but was: <0>
[ERROR]   Run 3: KafkaConsumerOffsetRepositoryEmptyTest.shouldStartFromBeginningWithEmptyOffsetRepository:74 mock://result Received message count. Expected: <10> but was: <0>
[INFO]
[ERROR] org.apache.camel.component.kafka.KafkaConsumerOffsetRepositoryResumeTest.shouldResumeFromAnyParticularOffset(org.apache.camel.component.kafka.KafkaConsumerOffsetRepositoryResumeTest)
[ERROR]   Run 1: KafkaConsumerOffsetRepositoryResumeTest.shouldResumeFromAnyParticularOffset:75 mock://result Received message count. Expected: <3> but was: <0>
[ERROR]   Run 2: KafkaConsumerOffsetRepositoryResumeTest.shouldResumeFromAnyParticularOffset:75 mock://result Received message count. Expected: <3> but was: <0>
[ERROR]   Run 3: KafkaConsumerOffsetRepositoryResumeTest.shouldResumeFromAnyParticularOffset:75 mock://result Received message count. Expected: <3> but was: <0>
[INFO]
[INFO]
[ERROR] Tests run: 43, Failures: 2, Errors: 0, Skipped: 2

LGTM. Will merge soon.

@davsclaus @lburgazzoli @zregvart may I have your feedback too?

@oscerd looks good to me, not sure about the failing tests. I think for future proofing we could add a Map<String, String> additionalProperties or similar (but that's another issue).

Thanks for the PR. It has been merged. Can you close this?

Is there something missing? I see you reopened the PR..

Sorry, for closing and re-opening.  I misread the GITHUB BOT feedback on the Jira ticket and thought I needed to do close the ticket another way.
Thanks for reviewing and merging.


FlutterInAppWebView 6.0.0-beta.31 does not build, "Dart library 'dart:ui_web' is not available on this platform"

Environment

Technology
Version

Flutter version
3.7.10

Dart version
2.19.6

Plugin version
6.0.0-beta.31

Android version
-

iOS version
16.4

macOS version
13.6.1 (22G313)

Xcode version
14.3.1 (14E300c)

Device information:
Chrome
Description
After adding the dependency to the project, when you start a build (I've just tested in debug mode but I think is the same in release-mode), after a while this error message (image attached) will returns in console.
We used Flutter 3.7.10 and dart-sdk 2.19.6.
The build was done for web (so chrome) on a MacbookPro with Mac 13.6.1.
You don't need any kind of library component, just add it to the pubspec.
Images

Could you try to run “flutter clean” and then install dependencies again?

Have you tried to upgrade to the latest Flutter version?

Yeap, on the latest version of Flutter and Dart it seems to work correctly. But I am actually strictly tied to version 3.7.10 and can't update. So its certain now that the problem is the Dart and Flutter version, I will then resolve it by updating flutter.
I would like to suggest you to update the minimum requirements to avoid a similar issues.

Ok, then probably I need to update the minimum Dart SDK version.
Maybe you can use Flutter 3.7 and update just the Dart SDK?

No, I can't do it because Flutter depends on dart language version. Even if I try to upgrade only the Dart-SDK, Flutter will only use the embedded Dart-SDK version, so the 2.19.6. In any I case I don't think that upgrade only the Dart-SDK is a good idea, who knows how many errors it could lead to... the only one solution is to upgrade Flutter I think.

Ok, in the meantime I will check if I can fix somehow the error using Flutter 3.7

@fawdlstty I'm not able to reproduce the error, I can compile using Flutter 3.7.10 and latest Flutter version without any error.
Try to run flutter clean and install all the dependencies again.

Using flutter clean does not work, updating the flutter version solves the problem, but it brings more problems, and I am still investigating the cause of the problem

Unfortunately I’m not able to reproduce the issue, it just compiles as expected using Flutter 3.7.10.
@matteopapiani01 are you able to compile using Flutter 3.7.10?

I don't know, I tried it yesterday with Flutter 3.7.10 and it worked. So yes I guess.
@fawdlstty maybe you have in cache an old version; try with flutter pub cache clean, this command will remove every package every of every Flutter project that you have installed on your pc. Then try again with flutter pub get and flutter pub upgrade.

No, I encountered issues with the old version of Flutter and the new version of this package.

I'm getting the same error, how to resolve it? @pichillilorenzo @matteopapiani01
Launching lib/main.dart on Chrome in debug mode...
main.dart:1
: Error: Undefined name 'platformViewRegistry'.
platform_view_registry_dart_ui_web.dart:8
    return ui_web.platformViewRegistry
Failed to compile application.

Version details:
flutter_inappwebview: ^6.0.0

Flutter 3.10.6 • channel stable • https://github.com/flutter/flutter.git
Framework • revision f468f3366c (6 months ago) • 2023-07-12 15:19:05 -0700
Engine • revision cdbeda788a
Tools • Dart 3.0.6 • DevTools 2.23.1

I'm getting the same error, how to resolve it? @pichillilorenzo @matteopapiani01
I tried flutter pub cache clean but still same
Launching lib/main.dart on Chrome in debug mode...
main.dart:1
: Error: Undefined name 'platformViewRegistry'.
platform_view_registry_dart_ui_web.dart:8
    return ui_web.platformViewRegistry
Failed to compile application.

Version details: flutter_inappwebview: ^6.0.0

Flutter 3.10.6 • channel stable • https://github.com/flutter/flutter.git
Framework • revision f468f3366c (6 months ago) • 2023-07-12 15:19:05 -0700
Engine • revision cdbeda788a
Tools • Dart 3.0.6 • DevTools 2.23.1

👋 late to the party. I'm on 3.10.1 - I get Error: Undefined name 'platformViewRegistry'. on every version after 6.0.0-beta.28. I'm going to switch my project version over to 3.7.10 to try the other fix.

Same issue, anyone found a work around ?
../../../.pub-cache/hosted/pub.dev/flutter_inappwebview_web-1.0.8/lib/web/shims/platform_view_registry_dart_ui_web.dart:8
:19: Error: Undefined name 'platformViewRegistry'.
    return ui_web.platformViewRegistry
                  ^^^^^^^^^^^^^^^^^^^^

Version Details:
Flutter 3.10.1 • channel stable • https://github.com/flutter/flutter.git
Framework • revision d3d8effc68 (9 months ago) • 2023-05-16 17:59:05 -0700
Engine • revision b4fb11214d
Tools • Dart 3.0.1 • DevTools 2.23.1

@psikosen flutter master doesn't seem to have this issue if you're able to switch. I'm using 3.13.9 and that works as well.

同样的问题，有人找到解决方法吗？
../../../.pub-cache/hosted/pub.dev/flutter_inappwebview_web-1.0.8/lib/web/shims/platform_view_registry_dart_ui_web.dart:8
:19: Error: Undefined name 'platformViewRegistry'.
    return ui_web.platformViewRegistry
                  ^^^^^^^^^^^^^^^^^^^^

版本详情： Flutter 3.10.1 • 稳定版 • https://github.com/flutter/flutter.git 框架 • 修订版本 d3d8effc68（9 个月前） • 2023-05-16 17:59:05 -0700 引擎 • 修订版本 b4fb11214d 工具 • Dart 3.0.1 • DevTools 2.23.1

Has anyone found a solution to the same problem?
../../.pub-cache/hosted/pub.flutter-io.cn/flutter_inappwebview_web-1.0.8/lib/web/shims/platform_view_registry_dart_ui_web.dart:8:19: Error: Undefined name 'platformViewRegistry'.
return ui_web.platformViewRegistry
^^^^^^^^^^^^^^^^^^^^
Failed to compile application.

我遇到了同样的错误，如何解决？@pichillilorenzo@matteopapiani01
我试过了flutter pub cache clean，但还是一样
Launching lib/main.dart on Chrome in debug mode...
main.dart:1
: Error: Undefined name 'platformViewRegistry'.
platform_view_registry_dart_ui_web.dart:8
    return ui_web.platformViewRegistry
Failed to compile application.

版本详情： flutter_inappwebview: ^6.0.0

Flutter 3.10.6 • 频道稳定 • https://github.com/flutter/flutter.git
框架 • 修订版 f468f3366c（6 个月前） • 2023-07-12 15:19:05 -0700
引擎 • 修订版 cdbeda788a
工具 • Dart 3.0.6 • DevTools 2.23.1

我遇到了同样的错误，如何解决？@pichillilorenzo@matteopapiani01
我试过了flutter pub cache clean，但还是一样
Launching lib/main.dart on Chrome in debug mode...
main.dart:1
: Error: Undefined name 'platformViewRegistry'.
platform_view_registry_dart_ui_web.dart:8
    return ui_web.platformViewRegistry
Failed to compile application.

版本详情： flutter_inappwebview: ^6.0.0

Flutter 3.10.6 • 频道稳定 • https://github.com/flutter/flutter.git
框架 • 修订版 f468f3366c（6 个月前） • 2023-07-12 15:19:05 -0700
引擎 • 修订版 cdbeda788a
工具 • Dart 3.0.6 • DevTools 2.23.1

👋 迟到了。我使用的是 3.10.1 -Error: Undefined name 'platformViewRegistry'.之后的每个版本我都用过6.0.0-beta.28。我要将我的项目版本切换到3.7.10以尝试其他修复。

I encountered the same error. How did you solve it?

我遇到了同样的错误，如何解决？@pichillilorenzo@matteopapiani01
我试过了flutter pub cache clean，但还是一样
Launching lib/main.dart on Chrome in debug mode...
main.dart:1
: Error: Undefined name 'platformViewRegistry'.
platform_view_registry_dart_ui_web.dart:8
    return ui_web.platformViewRegistry
Failed to compile application.

版本详情： flutter_inappwebview: ^6.0.0

Flutter 3.10.6 • 频道稳定 • https://github.com/flutter/flutter.git
框架 • 修订版 f468f3366c（6 个月前） • 2023-07-12 15:19:05 -0700
引擎 • 修订版 cdbeda788a
工具 • Dart 3.0.6 • DevTools 2.23.1

我也遇到了同样的错误。你是怎么解决的？ @rahul-dezerv @pichillilorenzo

@matteopapiani01 没有，我在使用旧版本的 Flutter 和新版本的这个包时都遇到了这个问题。 触发问题的代码很新，两天前更新的： https://github.com/pichillilorenzo/flutter_inappwebview/blob/7bb70eb7d97ef36866af5915c61548a456a45578/flutter_inappwebview_web/lib/web/shims/platform_view_registry_dart_ui_web.dart

I encountered the same error. How did you solve it?  @fawdlstty

I encountered the same error. How did you solve it? @fawdlstty

@MichaelSSY Good night. Time has passed too long, and I have forgotten this mistake. As I mentioned earlier, the Flutter version is strongly related to the Flutterapp. I will share a version I am using: Flutter: 3.16.9, Dart：3.2.6，DevTools：2.28.5，flutter_inappwebview：^6.0.0-beta.31

I encountered the same error. How did you solve it? @fawdlstty

@MichaelSSY Good night. Time has passed too long, and I have forgotten this mistake. As I mentioned earlier, the Flutter version is strongly related to the Flutterapp. I will share a version I am using: Flutter: 3.16.9, Dart：3.2.6，DevTools：2.28.5，flutter_inappwebview：^6.0.0-beta.31

Does this version run on the web without any errors? I am using this version to run the web end, but it still reports an error, which is strange.

Does this version run on the web without any errors? I am using this version to run the web end, but it still reports an error, which is strange.

After using this version, you can create a new project and add the content to web/index.html file:
<script type="application/javascript" src="assets/packages/flutter_inappwebview_web/assets/web/web_support.js"
    defer></script>

See if there is no problem, it may be caused by the original project file and needs to be checked one by one
Additionally, the screenshot does not seem to indicate the version of flutter_inappwebview

这个版本在web端运行没有错误吗？我用这个版本运行web端，但是还是报错，很奇怪。

使用该版本后，您可以创建一个新项目并将内容添加到web/index.html文件中：
<script type="application/javascript" src="assets/packages/flutter_inappwebview_web/assets/web/web_support.js"
    defer></script>

看看没有问题的话，可能是原有项目文件导致的，需要逐个检查
此外，截图似乎没有显示版本flutter_inappwebview

The version I am using is flutter_inappwebview: 6.0.0 rc.3

Same issue, is there any solution?

Time has passed too long, and I have forgotten this mistake. As I mentioned earlier, the Flutter version is strongly related to the Flutterapp. I will share a version I am using: Flutter: 3.16.9, Dart：3.2.6，DevTools：2.28.5，flutter_inappwebview：^6.0.0-beta.31

After using this version, you can create a new project and add the content to web/index.html file:
<script type="application/javascript" src="assets/packages/flutter_inappwebview_web/assets/web/web_support.js" defer></script>

See if there is no problem, it may be caused by the original project file and needs to be checked one by one
Additionally, the screenshot does not seem to indicate the version of flutter_inappwebview

@AAChartModel This solution is effective for me, you can try following the steps

In case someone gets here you can find a solution in here
Also in my case the problem was that for using  usePathUrlStrategy() in main I imported import 'package:flutter_web_plugins/flutter_web_plugins.dart and it doesn't work. The right way is to import 'package:flutter_web_plugins/url_strategy.dart';


Model#11 order model

Created Order Model. Added all needed fields _id IntegerField PrimaryKey +
paymentMethod ChoiceField +
shippingAddressId IntegerField ForeignKey +
userId IntegerField ForeignKey +
orderDate DateTime +
shippingStatus ChoiceField +
Also created feature for creating order only for authenticated users and modifying order for admins
Resolves #11

@strangerok1507 need your review


Let "Anonymous usage statistics gathering" be opt-in instead of opt-out

As a privacy-conscious user, I do not want the app to connect to Sentry, Mixpanel and Google Analytics by default, so that my privacy is not invaded

Background
I am using an Open Source tool for Android file transfer in order to avoid Google and the likes as much as possible. Since I am very conscious of my privacy, I run a local firewall. When I started openmtp, my firewall informed me that the app was attempting to connect to the following hosts:

google-analytics.com
mixpanel.com
sentry.com

I understand that collecting metrics might be important to you, but please understand that for me, these connection attempts are not desirable. Tracking should be opt-in instead of opt-out, in my opinion.
Acceptance criterias

By default, "Anonymous usage statistics gathering" should be disabled
If the toggle was never set to "Enabled", the app should not make any request to Mixpanel, Google Analytics or Sentry

PS: I hope that this way of raising the issue is acceptable. I am thankful for the effort you have put into this app, and as I stated, I understand that it might be desirable to collect such data. However, I believe that users should actively decide that they want to provide the data, instead of the application just assuming an opt-in. Thanks for your consideration!

Many apps now initialise with a window prompting a user to en/disable tracking. As with wtimme, my firewall made me aware of the connection attempt.


Update flyway-core to 7.12.1

Updates org.flywaydb:flyway-core from 7.9.2 to 7.12.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.flywaydb", artifactId = "flyway-core" } ]

labels: library-update, semver-minor

Superseded by #312.


Dev

Before the 13th of January, Marc wants the CLOSUP website to be able to handle City of Brea (attached) template and make sure the empty template, conversion process, iXBRL viewer has no issues. I believe there are no major issues on the dev branch and want to see if we can merge it into main before this deadline.
The CLOSUP website has been updated so that instead of being embedded, you click on the 'Get Started' button and it opens a new tab with the main branch deployment on Heroku.
The following conversion works on dev branch
City of Brea, CA.xlsx
What we want to review (on different browsers too) @kwheelan @sarraha786

[ ] UI/UX is right (following conversion)
[ ] Downloading button, uploading, converting, deleting files, opening iXBRL viewer all work
[ ] Make sure CLOSUP website loads the tool properly
[ ] Make sure the empty ACFR template is up to date

@lucakato
I'll continue reviewing, but on first pass, there are a few major issues. When I add the Clayton files (Word and Excel) or even just the Brea file, it takes me to the right page, but then the "Download File" button doesn't do anything. Then clicking on "Click to View in Browser" doesn't fully load the interactive viewer. See screenshot:

Usually when it gets stuck loading like that, it's because of an error in the XBRL.
Tested with Brea Excel and this Clayton file:
Clayton Excel.xlsx


does this repo supports weight pruning?

hey @bubbliiiing
does this repo supports the pruning during training? If not is there any other references you know which supports pruning on yolov4-tiny with darknet as backbone.
thanks

Sorry, it can't


Many to many self reference table - guid Id changes itself

https://stackoverflow.com/questions/52191661/many-to-many-self-reference-table-guid-id-changes-itself

Also a better documentation should be added for self referencing one-to-one and many-to-many tables

This issue was moved to aspnet/EntityFrameworkCore#13225


Question: how are name collisions handled?

I want to be able to publish multiple instances of the same service running in the network on different hosts.
In avahi, there is a specific way to handle collision errors, and a default way to change the name (calling avahi_alternative_service_name, works by appending "#1", "#2", etc.)
How is this done in this library?

This is not currently handled, please feel free to open a pull request with an integration of avahi_alternative_service_name and some Bonjour equivalent

This has been a long time coming but I've started to implement this in #40
I'm having some trouble actually triggering a name collision in Avahi while testing. Is this something you had experience with? Thanks.

Resolved in https://github.com/windy1/zeroconf-rs/pull/40


Feature/248233 - Shortcuts for document splitting

This PR will fix this original ticket: https://netbeans.org/bugzilla/show_bug.cgi?id=248233

Created action for horizontally split and added shortcut
Created action for vertically split and added shortcut
Created action for clear split and added shortcut
Refactored code a bit.

Regards
Chris

Created a JIRA ticket too: https://issues.apache.org/jira/browse/NETBEANS-59

I verified the steps provided in JIRA ticket as follows:

Open any document what you want
Hit ctrl + shift + h to split the document horizontally
Hit ctrl + shift + v to split the document vetically
Hit ctrl + shift + c to clear split the document
Play around of hitting randomly the shortcuts

As I am working on macOS the shortcuts I had to use were comm + ctrl + shift + h, comm + ctrl + shift + v and comm + ctrl + shift + c
I confirm the working of these shortcuts as explained in the steps.  Usually when we need keyboard shortcuts we also add Menu options for the actions, can we apply menu options for these actions also?

Chris, as was discussed elsewhere, the patches change line endings to Windows line endings (CRLF), and so look like deletion and addition of each line in the file (including the license headers, which I suppose you didn't want to change). Please fix this, ensuring the patch is using the just "LF" as line endings, and is only changing what should/needs to be changed. This is to keep the history clean, and to aid reviews. I'd also suggest to squash the commits and rebase, so that there's only one commit merged when this is being merged.
Thanks.

So what should I do exactly here? Changing the line endings back or what? It was not my intention to change that of course not. But I created 3 new files so all of these are really new files, which didn't exist before. Only to let you know that.

I've confirmed that your PR files have windows line endings.
Please try to check your line endings using the following plugin:
http://plugins.netbeans.org/plugin/36810/show-and-change-line-endings
The cause may be core.autocrlf configuration. Please try to check it:
git config -l

When you commit your changes, if line endings are not changed to LF, please try to change it to false.
e.g.
git config --global core.autocrlf false

Then, clone the repository again.
One Note:
If you create a new file in windows, its line ending is CRLF by default. So you have to change it.
Thanks.

@junichi11 thx for the info, yes I confirmed the line endings of CRLF too. So I changed the autocrlf from true to false. So now I have to clone it again? Maybe not possible to create a new feature branch and change the line endings?
So as I understand it right, I have to make a new PR with the changes, that I made again?

So now I have to clone it again?

Perhaps, need not do it if the other file line endings are not CRLF. If you want to use this PR, you can do the following steps (I can be wrong):

Remove your remote branch once
Fix your line endings for your changes. then commit
To create just one commit, rebase (or git reset --soft and commit?)
Push your branch again

BTW, Did you read an email[1] from Jan? Probably, you should wait a while.
[1]<EMAIL_ADDRESS>

Yes, I knew that mail. But there is no official comment about that and no decision made yet.

See this PR #3


Empty or incomplete server list when using French Free Mobile Internet provider (LTE mobile broadband)

It looks like there was no dedicated issue, here is a first attempt to workaround the problem:

https://github.com/DaemonEngine/Daemon/pull/283

Free Mobile is a French Internet Provider (mobile broadband), it is very used as it is one of the only 4 mobile broadband providers for France.
When an user is connected to Internet through this kind of connection (for example sharing Internet with his phone), the game don't get answers from queried servers. It's possible the servers don't receive the queries to begin with.
It appears that waiting a bit between each server query works around the issue (hence the #283 attempt).
Among people who experience the problem are:

@illwieckz
@bmorel
@necessarily-equal
@superdupont-fr
err404 (chat user)
BL0CKY_DUDE (chat user)

The current workaround is to use https://unvanquished.net/servers/ if unv:// protocol integration is working.
I tag this issue as Enhancement and not as Bug because that's likely not a bug in our code, but a problem in provider's infrastructure. Though, it would be useful if our engine was more resilient to providers with network issues.

On a side note, a new implementation of server querying may also want to take care of that other issue:

https://github.com/DaemonEngine/Daemon/issues/284

the duplicate https://github.com/DaemonEngine/Daemon/issues/654 has some screenshots

I almost never use shared connexion. But, I can test this case if needed. (since you added me in the list :D )

@bmorel reports the same issue happens with another French Mobile Internet provider: Bouygues Telecom.

This is nothing out of the ordinary... some servers missing during a client server list refresh has always happened since Tremulous. The client just sends a serverinfo request and the server doesn't appear if the packet gets lost or the response takes too long. If you guys have not seen this before now, you must have been blessed with unusually reliable ISPs.

But when this bugs happen, having at least one sever listed in the list is the exception, otherwise none are listed.

FWIW I think the problem I had yesterday was a temporary problem, as I did not had it before, and it seems it's gone this morning.


Uncaught Error: Assertion Failed: Expected service:liquid-fire-transitions to resolve to an Ember.Service but instead it was (unknown mixin).

Ember 1.13.0-beta.2
Ember-Data 1.17 & 1.18 beta (same error/result)
In addition to all these deprecations that are blocking the ember-inspector from working.  Am I missing a thread somewhere about how to work w/ glimmer-betas & canary?

+1

anything?  If its going to be a couple weeks until its safe to use Liquid-fire and glimmer thats fine, it would just be good to know that so we can focus on other things.

This is fixed in the latest liquid-fire, and it was also made into a non-breaking warning in the latest Ember canary.

For reference: https://github.com/ef4/liquid-fire/pull/294


Unautherized to apply changes - License is invalid error while connecting Office 365 to Sentinel

Describe the bug
I am getting "Unautherized to apply changes - License is invalid " error while connecting Office 365 to Sentinel. I have Global Admin access on the tenant and read write/access on the log analytics workspace.
To reproduce:
Go to Azure --> Sentinel Workspace --> Configuration--> Data Connectors --> Office 365 --> Open Connector Page-->  Configruration (Check Exchange and Sharepoint) --> Apply Changes.

Thanks for reporting, we are aware of the issue and working on a resolution.  Thanks for your patience.

Looks like it is working now.


refactor: introduce AppBuilder trait

I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
NOTE: The PR is now in draft mode for discussion. Since the whole PR may be bigger(>1000 LOC), I will separate it into multiple small PRs and share the important abstraction first.
This PR introduces the new trait in the cmd/ crate called AppBuilder. It's a simple abstraction based on the original code that makes our cli structure cleaner.
Based on the original design, we can have the following concept:

App: For most scenarios, it's a running service, for example, frontend, metasrv, etc. Also, it can be a cli tool. Each subcommand can be treated as App;

AppBuilder: The builder of the App;

Options: For building the App, we need Options. For most scenarios, Options can implement Configurable trait;

We can use the AppBuilder to build and run the App:
/// Build the options and app, then start the app.
async fn start(self) -> Result<()> {
    self.build_options()?.build_app().await?.run().await
}

The original implementation has many build() and load_options(), which seems too complicated. If we use AppBuilder, the code can be:

Accept the command line argument to create AppBuilder, then build and run the App;
Each component(frontend.rs/datanode.rs/metasrv.rs/cli.rs) only needs to implement AppBuilder;

The following is the snippet of the code:
...
#[tokio::main]
async fn main() -> Result<()> {
    ...
    start(Command::parse()).await
}

async fn start(cli: Command) -> Result<()> {
    match cli.subcmd {
        SubCommand::Datanode(cmd) => cmd.new_app_builder(cli.global_options).start().await,
        SubCommand::Frontend(cmd) => cmd.new_app_builder(cli.global_options).start().await,
        SubCommand::Metasrv(cmd) => cmd.new_app_builder(cli.global_options).start().await,
        SubCommand::Standalone(cmd) => cmd.new_app_builder(cli.global_options).start().await,
        SubCommand::Cli(cmd) => cmd.new_app_builder(cli.global_options).start().await,
    }
}
...

For each App, we need to create the AppBuilder struct and implement the trait(most methods are from the original implementation). Take cmd/datanode.rs for example:
...
#[derive(Default)]
pub struct DatanodeAppBuilder {
    command: Option<StartCommand>,
    global_options: GlobalOptions,
    datanode_options: Option<DatanodeOptions>,
}

#[async_trait]
impl AppBuilder for DatanodeAppBuilder {
    fn build_options(mut self) -> Result<Self> { ... }

    async fn build_app(mut self) -> Result<Box<dyn App>> { ... }
}

...

There are some references for implementation:

src/bin/greptime.rs

src/datanode.rs

Checklist

[ ]  I have written the necessary rustdoc comments.
[ ]  I have added the necessary unit tests and integration tests.
[x]  This PR does not require documentation updates.

Close it because it seems the refactoring is unnecessary. I got some new ideas based on the refactoring, but I still need some tests. I will bring the new PR in the future.


evcc: 0.109.2 -> 0.110.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for evcc is: "EV Charge Controller"
meta.homepage for evcc is: "https://evcc.io"
meta.changelog for evcc is: "https://github.com/andig/evcc/releases/tag/0.110.1"
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 0.110.1 with grep in /nix/store/i6ivlj3lvjg9v6hxr4iwvqrvji04mywj-evcc-0.110.1
found 0.110.1 in filename of file in /nix/store/i6ivlj3lvjg9v6hxr4iwvqrvji04mywj-evcc-0.110.1

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
evcc
nixos-install-tools
tests.nixos-functions.nixos-test

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/i6ivlj3lvjg9v6hxr4iwvqrvji04mywj-evcc-0.110.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A evcc https://github.com/r-ryantm/nixpkgs/archive/297c9cf19cdc0c719572f2a3ba62314e8abadc4a.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/i6ivlj3lvjg9v6hxr4iwvqrvji04mywj-evcc-0.110.1
ls -la /nix/store/i6ivlj3lvjg9v6hxr4iwvqrvji04mywj-evcc-0.110.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

evcc
nixos-install-tools

Maintainer pings
cc @mweinelt for testing.

Warning: a test defined in passthru.tests did not pass

The update check now happens instantly on startup and it considers not reaching github.com a fatal error.


👻emmmm.....  Can I realtime print the output line by line when executing ios_popen() ？

I am a newbie about this.
Here's my code
It waits for the command to finish before printing the output together

void my_popen(NSString *input, void(^output)(NSString *output, BOOL isEnd)) {

    const char *command = input.UTF8String;

    char result_buf[1024];
    int rc = 0;
    __block FILE *fp;

    fflush(stdout);
    fp = ios_popen(command, "r");

    if(NULL == fp)
    {
        perror("popen failed！");
        output(@"popen failed！", YES);
        return;
    }
    while(fgets(result_buf, sizeof(result_buf), fp) != NULL)
    {
        if('\n' == result_buf[strlen(result_buf)-1])
        {
            result_buf[strlen(result_buf)-1] = '\0';
        }
        output([NSString stringWithFormat:@"%s", result_buf], NO);
    }

    rc = pclose(fp);
    if(-1 == rc)
    {
        printf("【%s】【%d】\r\n", command, rc);
    }
    else
    {
        printf("【%s】【%d】【%d】\r\n", command, rc, WEXITSTATUS(rc));
    }
}

So, does that work?
You could also do it with the getline() function:
getline(result_buf, 1024, fp);

@holzschu
I hit a breakpoint and found it blocked on this line of code
fp = ios_popen(command, "r");

It took a few seconds to continue

Ah, now I understand the question.
Yes, by default, ios_system commands run in the foreground if they are the first command to be called. Meaning the command runs entirely, then gives back control to the app. The solution to have interactive communication between the command and the application is to run them in queues or threads, as you have done.
You could (probably) also make it work by sending the ios_popen2 command in an async queue, and have the reading in the main loop.
You could also simplify your code with:
    thread_stdout = fdopen(fd[1], "w");
    thread_stdin =  fdopen(fd[0], "r");
    ios_system(command);

and then listen to thread_stdout in the async queue.  By default, ios_system commands write their standard output to a stream called thread_stdout and listen to a stream called thread_stdin.

@holzschu
I see.  thx


Error reports should be sent through a REST service instead of SMTP

We need to create a REST service for error reporting. Designer should use this service instead of JavaMail for error reporting. We can make this service generic enough so that in the future it can be used by other clients (like MDWHub).

migrated this issue to the mdw-designer repo.
closed the issue,removed the milestone, removed the designer label , removed the project and marked as duplicate in this repo.


Defer Last Commit Info

One of the biggest reasons for slow repository browsing is that we wait
until last commit information has been generated for all files in the
repository.
This PR proposes deferring this generation to a new POST endpoint that
does the look up outside of the main page request.
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

This is a reworking of part of #16063

Another option here is to not attempt to generate last commit data in the main loop and leave that to the lastcommit post instead.

Codecov Report

Merging #16467 (a741466) into main (b08e14b) will increase coverage by 0.00%.
The diff coverage is 40.70%.

@@           Coverage Diff           @@
##             main   #16467   +/-   ##
=======================================
  Coverage   45.43%   45.43%
=======================================
  Files         717      717
  Lines       84182    84234   +52
=======================================
+ Hits        38244    38275   +31
- Misses      39789    39802   +13
- Partials     6149     6157    +8

Impacted Files
Coverage Δ

modules/git/last_commit_cache_nogogit.go
38.77% <0.00%> (+2.92%)
:arrow_up:

modules/git/commit_info_nogogit.go
61.85% <23.52%> (+1.24%)
:arrow_up:

modules/git/log_name_status.go
61.13% <25.00%> (-1.37%)
:arrow_down:

routers/web/repo/view.go
41.18% <45.56%> (-0.34%)
:arrow_down:

modules/git/last_commit_cache.go
100.00% <100.00%> (ø)

modules/git/notes_nogogit.go
70.00% <100.00%> (ø)

routers/web/web.go
91.74% <100.00%> (+0.01%)
:arrow_up:

modules/git/blame.go
65.71% <0.00%> (-1.43%)
:arrow_down:

models/repo_list.go
77.04% <0.00%> (-0.78%)
:arrow_down:

services/pull/pull.go
41.93% <0.00%> (-0.44%)
:arrow_down:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b08e14b...a741466. Read the comment docs.


Improve Player Usability

This pull request introduces changes to enhance player usability.
Purpose of Change

To improve player usability.

Changes

Add displays for volume and playback position.

This allows users to easily confirm their current status.

Moving the volume bar immediately affects the volume, without waiting for it to be released.

This makes volume control more intuitive for the user.

Change the default volume scale to dB. !! caution: breaking change !!

This allows users to control lower volumes more precisely.
The current linear scale can still be selected in the settings.
Although this is a breaking change, I believe it will not greatly confuse current users since the scale is not currently explicitly mentioned.

Add settings to set the initial volume.

This allows users to set a default volume that matches their environment.

Add setting explanation to README.md.

Tests

I've confirmed the change visually.
Add tests for the newly defined class, PlayerSettingService (playerSettingsService.test.ts).
Some tests have been modified to assess the volume display and volume change behavior.
The changes are compatible with all existing tests, including those added or modified.

As I am new to VSCode extension, TypeScript, and GitHub practices, I welcome any feedback.

Thank you for your detailed comments.
Your concrete feedback helps me better understand the design direction and makes it easier to address the issues.
I will address the issues you mentioned, but I have a question about the test mentioned above.
I wrote the comment as individual reply.
I would appreciate your comment.


add RESPONSE_CODE_DETAILS and CONNECTION_TERMINATION_DETAILS to access log

These log operators should be very useful for troubleshooting and debugging in many cases.
Example Logs (RESPONSE_CODE_DETAILS):
[2020-10-29T03:22:16.126Z] "GET /headers HTTP/1.1" 200 - via_upstream - "-" 0 547 5 4 "-" "curl/7.73.0-DEV" "24e58e43-e576-9048-829b-02e3f3da16f0" "httpbin:8000" "<IP_ADDRESS>:80" inbound|8000|| <IP_ADDRESS>:51680 <IP_ADDRESS>:80 <IP_ADDRESS>:59022 outbound_.8000_._.httpbin.foo.svc.cluster.local default
[2020-10-29T03:23:33.415Z] "- - -" 0 NR filter_chain_not_found - "-" 0 0 0 - "-" "-" "-" "-" "-" - - <IP_ADDRESS>:80 <IP_ADDRESS>:59800 - -
[2020-10-29T03:24:13.520Z] "- - HTTP/1.1" 400 DPE http1.codec_error - "-" 0 11 0 - "-" "-" "-" "-" "-" - - <IP_ADDRESS>:80 <IP_ADDRESS>:60214 - -
[2020-10-29T03:25:20.162Z] "GET /headers HTTP/1.1" 403 - rbac_access_denied_matched_policy[none] - "-" 0 19 0 - "-" "curl/7.73.0-DEV" "07541777-6ee2-908f-a78b-867fe257ac80" "httpbin:8000" "-" - - <IP_ADDRESS>:80 <IP_ADDRESS>:60898 outbound_.8000_._.httpbin.foo.svc.cluster.local -
[2020-10-29T03:26:11.561Z] "GET /headers HTTP/1.1" 403 - rbac_access_denied_matched_policy[ns[foo]-policy[httpbin]-rule[0]] - "-" 0 19 0 - "-" "curl/7.73.0-DEV" "090a1897-d696-99b1-90f0-2673113ba258" "httpbin:8000" "-" - - <IP_ADDRESS>:80 <IP_ADDRESS>:33204 outbound_.8000_._.httpbin.foo.svc.cluster.local -

Example Logs (CONNECTION_TERMINATION_DETAILS):
[2020-10-29T03:28:26.690Z] "- - -" 0 - - rbac_access_denied_matched_policy[ns[foo]-policy[httpbin]-rule[0]] "-" 761 701 5 - "-" "-" "-" "-" "<IP_ADDRESS>:80" inbound|8000|| <IP_ADDRESS>:55464 <IP_ADDRESS>:80 <IP_ADDRESS>:34574 outbound_.8000_._.httpbin.foo.svc.cluster.local -

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[X] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[X] Does not have any changes that may affect Istio users.

would be great to see an example of what this looks like

would be great to see an example of what this looks like

sure, I'm waiting for my other istio/proxy PR (https://github.com/istio/proxy/pull/3045) merged and then update Envoy in istio to test this PR and include the output.

Sounds good. This sounds super useful

@yangminzhu: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-distroless-k8s-tests_istio

integ-operator-controller-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-ipv6-k8s-tests_istio

integ-multicluster-k8s-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-k8s-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
a5b694855bd13ea3f9805ff1ec5f24816a5773f1
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
ebd34c1f746457c4358cf82df233180d526ed646
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

really helpful

/test integ-pilot-k8s-tests_istio

Confused by your original example: HTTP/1.1 400 http1.codec_error DPE. Shouldn't it be HTTP/1.1 400 DPE http1.codec_error based on %RESPONSE_CODE% %RESPONSE_FLAGS% %RESPONSE_CODE_DETAILS%? was that for a different version of the PR?

Clearly useful, will approve if @istio/wg-policies-and-telemetry-maintainers approve

to be clear, this is changing the default Istio format for access logs?
@mandarjog @nrjpoddar what do we want to do for defaulting in a Telemetry API world to match this?  This is currently NOT shared across "providers".

I do think this is an API and it will break users who have tooling around log parsing. I would suggest that we create a global option to conditionally disable it in 1.9 with upgrade documentation around the impact of this change.

I do think this is an API and it will break users who have tooling around log parsing. I would suggest that we create a global option to conditionally disable it in 1.9 with upgrade/release notes documentation around the impact of this change.

The user should explicitly set the log format in accessLogFormat if they intend to process it, relying on the default log format seems too fragile for real use cases. And it is a bit strange to create a global option to control the default logging format when it is already configurable by accessLogFormat.

Confused by your original example: HTTP/1.1 400 http1.codec_error DPE. Shouldn't it be HTTP/1.1 400 DPE http1.codec_error based on %RESPONSE_CODE% %RESPONSE_FLAGS% %RESPONSE_CODE_DETAILS%? was that for a different version of the PR?

Oh, sorry about that, it's from my test cluster that is using out-dated code. Updated the description to include the latest log based on this PR.

I do think this is an API and it will break users who have tooling around log parsing. I would suggest that we create a global option to conditionally disable it in 1.9 with upgrade/release notes documentation around the impact of this change.

@nrjpoddar The user should explicitly set the log format in accessLogFormat if they intend to process it, relying on the default log format seems too fragile for real use cases. And it is a bit strange to create a global option to control the default logging format when it is already configurable by accessLogFormat.

I see, if that’s the case why do we need to change defaults? Shouldn’t we document how to update the default format and add these additional fields. Changing the default might be warranted if you can share issues filed by users where this info would have helped in debugging. Other way to think about this is we can document steps for logging these fields, add a warning about make them default next release but keep the default as is for a release and measure if we can get some feedback.

I do think this is an API and it will break users who have tooling around log parsing. I would suggest that we create a global option to conditionally disable it in 1.9 with upgrade/release notes documentation around the impact of this change.

@nrjpoddar The user should explicitly set the log format in accessLogFormat if they intend to process it, relying on the default log format seems too fragile for real use cases. And it is a bit strange to create a global option to control the default logging format when it is already configurable by accessLogFormat.

I see, if that’s the case why do we need to change defaults? Shouldn’t we document how to update the default format and add these additional fields. Changing the default might be warranted if you can share issues filed by users where this info would have helped in debugging. Other way to think about this is we can document steps for logging these fields, add a warning about making them default next release but keep the default as is for a release and measure if we can get some feedback.

RESPONSE_CODE_DETAILS and CONNECTION_TERMINATION_DETAILS are generally quite useful in troubleshooting why a request is denied, Envoy and many filters will set the two fields to give extra information of the deny, for example, RBAC filter could set it to include the name of the policy that caused the deny, the HTTP connection manager could it to include the reason the stream is reset and by who, etc.
The most relevant documentation I can find on istio.io is this one: https://istio.io/latest/docs/tasks/observability/logs/access-log/#enable-envoy-s-access-logging, it tells how to enable the access log but doesn't mention the default value of accessLogFormat.
The Mesh config doc (https://istio.io/latest/docs/reference/config/istio.mesh.v1alpha1/#MeshConfig) mentions the following:
accessLogFormat | string | Format for the proxy access log Empty value results in proxy’s default access log format

It says proxy's default access log format but doesn't document the log format at all.
And I believe we had changed the log format a few times before, the most recent I can find is this PR https://github.com/istio/istio/pull/16237 that adds the ROUTE_NAME log operator to the default log format.
I can abandon this PR and just update the task to mention the two log operator but I'm afraid that would be much less useful and cannot be used if not all proxy version is up-to-date because the new log operator is added in newer Envoy.

I am in favor of enabling this by default for the reasons @yangminzhu mentioned.
Users who are broken by this, are "wrong". We cannot make the entire project freeze just because we may break someones workflow. If you want to parse access logs, you should use JSON and/or define a stable format.
This is no different then us changing an istiod log format.

Ok, I see your points and I agree with the benefits. Here are my asks:

Release notes "none" is not correct for this change. I would suggest adding a release and upgrade note to let users know about this change in 1.9.
Can you augment this https://istio.io/latest/docs/tasks/observability/logs/access-log/#enable-envoy-s-access-logging document to add a section about changing logging format?
Add tests for "default" access logs ensuring we can catch changes in future.

@yangminzhu what do you think?

Add tests for "default" access logs ensuring we can catch changes in future.

This will be especially important as we transition to a fuller Telemetry API. We want to ensure that transition is seamless, and having tests around default behavior will help in that regard.

Ok, I see your points and I agree with the benefits. Here are my asks:

Release notes "none" is not correct for this change. I would suggest adding a release and upgrade note to let users know about this change in 1.9.

Sure, will add one.

Can you augment this https://istio.io/latest/docs/tasks/observability/logs/access-log/#enable-envoy-s-access-logging document to add a section about changing logging format and what the default format is?

will do.

Add tests for "default" access logs ensuring we can catch changes in future.

I can add some unit tests, does that sound good to you?

@yangminzhu what do you think? We can do some of this in follow-on PRs if we agree on principle.

I think I can just update the PR to include the release note and unit test, will need a separate PR to update the istio.io documentation. Thanks!

@yangminzhu I'm not the right person to ask unit vs integration tests for this as I'm not familiar with the code. If @douglas-reid or @mandarjog are happy with your test I'm good too, so check with them.

/test unit-tests_istio


fix(plugins/plugin-kubectl): Deployment Summary Ready shows "undefined/N" if there are no pods ready yet

Fixes #7762

Description of what you did:

My PR is a:

[ ] 💥 Breaking change
[x] 🐛 Bug fix
[ ] 💅 Enhancement
[ ] 🚀 New feature

Please confirm that your PR fulfills these requirements

[x] Multiple commits are squashed into one commit.
[x] The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
[x] All npm dependencies are pinned.

/lgtm


Add PartiallyInvalid HTTPRoute Condition

Proposed changes
Replace previously used TODO Conditions with PartiallyInvalid HTTPRoute Condition.
Problem: There was no HTTPRoute Condition that conveyed when a Route was PartiallyInvalid.
Solution: Added the PartiallyInvalid HTTPRoute Condition.
Testing: Manually deployed HTTPRoute with invalid and valid rules and checked to see if the HTTPRoute correctly displayed the new condition. Also checked to see if the matches are valid, with an invalid filter, that the HTTPRoute correctly displayed the new condition. Added additional Unit Tests.
Please focus on (optional): Did I update all the documentation? Are the tests that I added all necessary and done correctly?
Closes #485
Checklist
Before creating a PR, run through this checklist and mark each as complete.

[x] I have read the CONTRIBUTING doc
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have checked that all unit tests pass after adding my changes
[x] I have updated necessary documentation
[x] I have rebased my branch onto main
[x] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Since we are using our own version of PartiallyInvalid (copied from Gateway sig), should I open up a ticket which is for switching to their definition when they release it in 1.0?


Clean up Papyrus log errors

[07/27/2015 - 07:57:20PM] Cannot open store for class "Tree", missing file?
[07/27/2015 - 07:57:20PM] Cannot open store for class "_de_deletecraftingobjectscript", missing file?
[07/27/2015 - 07:57:20PM] Cannot open store for class "_frost_clothingsystem", missing file?
[07/27/2015 - 07:57:20PM] Cannot open store for class "PF__0203A5CA", missing file?
[07/27/2015 - 07:57:20PM] Error: Unable to bind script PF__0203A5CA to (1F03A5CA) because their base types do not match
[07/27/2015 - 07:57:20PM] Cannot open store for class "PF__0203A5C8", missing file?
[07/27/2015 - 07:57:20PM] Error: Unable to bind script PF__0203A5C8 to (1F03A5C8) because their base types do not match
[07/27/2015 - 07:57:20PM] Cannot open store for class "PF__0203A5C9", missing file?
[07/27/2015 - 07:57:20PM] Error: Unable to bind script PF__0203A5C9 to (1F03A5C9) because their base types do not match
[07/27/2015 - 07:57:20PM] Cannot open store for class "PF__0203A5C6", missing file?
[07/27/2015 - 07:57:20PM] Error: Unable to bind script PF__0203A5C6 to (1F03A5C6) because their base types do not match
[07/27/2015 - 07:57:20PM] Cannot open store for class "PF__02039AF4", missing file?
[07/27/2015 - 07:57:20PM] Error: Unable to bind script PF__02039AF4 to (1F039AF4) because their base types do not match
[07/27/2015 - 07:57:20PM] Cannot open store for class "PF__02039573", missing file?
[07/27/2015 - 07:57:20PM] Error: Unable to bind script PF__02039573 to (1F039573) because their base types do not match
[07/27/2015 - 07:57:20PM] Cannot open store for class "_DE_DELETEMETEST", missing file?
[07/27/2015 - 07:57:20PM] Error: Unable to bind script _DE_DELETEMETEST to (1F061F69) because their base types do not match
[07/27/2015 - 07:57:20PM] Cannot open store for class "PF__02039576", missing file?
[07/27/2015 - 07:57:20PM] Error: Unable to bind script PF__02039576 to (1F039576) because their base types do not match
[07/27/2015 - 07:57:20PM] Cannot open store for class "PF__02039578", missing file?
[07/27/2015 - 07:57:20PM] Error: Unable to bind script PF__02039578 to (1F039578) because their base types do not match

Resolved all but:

[07/27/2015 - 07:57:20PM] Cannot open store for class "_de_deletecraftingobjectscript", missing file?
[07/27/2015 - 07:57:20PM] Cannot open store for class "_frost_clothingsystem", missing file?

Fixed the deletecraftingobjectscript error.
The _frost_clothingsystem error will always be present if Frostfall 3.0 is not installed due to a linkage that occurs when compiling a Campfire script that has an optional call to FrostUtil. It is safe, only occurs once during start-up, and can be ignored.


Getting an Error : Failed to connect to yts.mx

**Please complete the following information:**
- App Version - Latest
- Affected Device(s)  - Android
Describe the Bug:
Getting an Error : Failed to connect to yts.mx
Expected Behavior:
Should connect and display movies list

I am seeing this issue from last night & seems like the issue is from yts.mx website. Can you check if the website is loading in your Android Chrome browser? In my opinion, it should not!
The problem is sometimes it loads but later on, we start getting SSL issues. I've contacted the site admins (yesterday) to let them know about this behavior, lets see how long it takes for them to resolve the issue from their side.
Once this is done, the app will automatically start working normally!

It opens up on browser if i use any VPN and set country to Germany etc.

Yup, I know the problem is specific to the Asia! For now, you have to use VPN if you want the app to function as well or wait till YTS  owners resolve this issue.


Not able to establish communication for geometry_msgs/Twist

hi @TommyChangUMD .
I am running ros2 humble in my laptop(Ubuntu 22.04) and ros1 noetic in raspberry pi model 4b (Buster), I am using this repo docker to build the ros1_bridge. However, when I used my laptop as publisher to publish geometry_msgs/msg/Twist, which is
ros2 topic pub -r 10 /cmd_vel geometry_msgs/msg/Twist "linear:   x: 1.0   y: 0.0   z: 0.0 angular:   x: 0.0   y: 0.0   z: 0.0"
and then I run ros2 run ros1_bridge dynamic_bridge --bridge-all-topics
the log will be
... created 2to1 bridge for topic '/cmd_vel' with ROS 2 type 'geometry_msgs/msg/Twist' and ROS 1 type '' [INFO] [1731121524.097166280] [ros_bridge]: Passing message from ROS 2 geometry_msgs/msg/Twist to ROS 1 geometry_msgs/Twist (showing msg only once per type) ...
It seems like it cannot determine the ROS1 type. At the rpi side, I also cannot receive the published message.
When I do in opposite way,  which I run the publisher in rpi side, the ros1_bridge terminal will show:
... created 1to2 bridge for topic '/cmd_vel' with ROS 1 type 'geometry_msgs/Twist' and ROS 2 type 'geometry_msgs/msg/Twist' [INFO] [1731123313.842520272] [ros_bridge]: Passing message from ROS 1 geometry_msgs/Twist to ROS 2 geometry_msgs/msg/Twist (showing msg only once per type) ...
In this way, my ubuntu 22.04 system can receive the published message from rpi.
In summary, my problem is that the rpi noetic cannot receive message published from ubuntu humble, but ubuntu humble can receive message from rpi noetic. Please give me some advices.
The command ros2 run ros1_bridge dynamic_bridge --print-pairs shows
... 'geometry_msgs/msg/Twist' (ROS 2) <=> 'geometry_msgs/Twist' (ROS 1) ...
Command to build docker:  docker build . --build-arg ADD_custom_msgs=1 -t ros-humble-ros1-bridge-builder
I followed the README and the compiling process has no problem.

Have you verified this is also the behavior with ros noetic running inside the docker container (instead of on a remote raspberry pi machine)?   It's working fine for me.
When I run:
ros2 run ros1_bridge dynamic_bridge --bridge-all-topics
  <I got>
    created 2to1 bridge for topic '/cmd_vel' with ROS 2 type 'geometry_msgs/msg/Twist' and ROS 1 type 'geometry_msgs/Twist'
    created 2to1 bridge for topic '/rosout' with ROS 2 type 'rcl_interfaces/msg/Log' and ROS 1 type 'rosgraph_msgs/Log'
    [INFO] [1731163481.818010430] [ros_bridge]: Passing message from ROS 2 geometry_msgs/msg/Twist to ROS 1 geometry_msgs/Twist (showing msg only once per type)
    removed 2to1 bridge for topic '/cmd_vel'
    created 2to1 bridge for topic '/cmd_vel' with ROS 2 type 'geometry_msgs/msg/Twist' and ROS 1 type 'geometry_msgs/Twist'

Also, instead of --bridge-all-topics, you might want to try --bridge-all-1to2-topics to see if that makes any difference?
I have updated the README.md to provide more information about these parameters.

Hi @TommyChangUMD .
I havent try to run in docker, will try it later. Let me update my current situation.
Same as my issue, I want to communicate from rpi noetic to ubuntu 22.04 humble.
This is my testing procedure:
I ssh into rpi and run roscore
Then I source custom_msgs/install/setup.bash & source ros1_bridge_builder/local_setup.bash
I am using /cmd_ve topic to test communication (No typo). I open another terminal in humble to run
ros2 topic pub -r 10 /cmd_ve geometry_msgs/msg/Vector3 "{x: 1.0, y: 0.0, z: 0.5}"
Then i run ros2 run ros1_bridge dynamic_bridge --bridge-all-topics
Here is its output:
... created 2to1 bridge for topic '/cmd_ve' with ROS 2 type 'geometry_msgs/msg/Vector3' and ROS 1 type 'geometry_msgs/Vector3' [INFO] [1731240547.070943429] [ros_bridge]: Passing message from ROS 2 geometry_msgs/msg/Vector3 to ROS 1 geometry_msgs/Vector3 (showing msg only once per type) ...
In rpi terminal, I run rostopic hz /cmd_ve
Then I get
subscribed to [/cmd_ve] no new messages no new messages no new messages ^Cno new messages
I think this is quite weird, because I am able to receive the message publish from rpi noetic. My target is to publish message from humble to noetic to let it run. I need to able to receive the message first, but seems cannot. I am not sure where is the problem exist. Btw, the --bridge-all-1to2-topics did not work.

OK.  Thanks for the additional details.  Let me take a closer look and get back to you.

Hi, I just solve this issue, this is because of hostname issue.
In /etc/hosts of rpi, I need to specify the ip of laptop, so the rpi can receive the message from laptop, it works now.


Typo in Under Known Vendors - ISC - dhcpd key

Under Known Vendors - ISC - dhcpd
The key is listed as isc_dhcp
This should be isc_dhcpd
Thank you for pulling the vendor product over as metadata.

Thank you


[autogrid] Allow disabling sorting for specific column

When using a custom renderer for a column that aggregates multiple fields you might not have a sensible single value to sort by. For example, for an address renderer there isn't really a single field that you would want to sort:
<AutoGrid
  visibleColumns: ['name', 'address'],
  columnOptions: {
    address: {
      renderer: AddressRenderer,
    },
  },
/>

In such cases it should be possible to disable sort. Furthermore, if a column's path points at an ObjectModel, sorting should be disabled automatically.
As a workaround, it would be possible to replace the auto rendered column with a custom non-sortable column.

Implemented


Sync eng/common directory with azure-sdk-tools repository

Sync eng/common directory with azure-sdk-tools repository

/check-enforcer override

/check-enforcer override

@chidozieononiwu - this was not supposed to be merged, there are changes that are getting overriden. @mitchdenny @weshaggard - a heads up on this PR would have been great. Now all the cosmos emulator CIs are failing.


Unable to use Performance Monitoring in symfony 4.4

Environment
How do you use Sentry?
self-hosted 21.9.0
Which SDK and version?
sentry/sentry-symfony 4.2.2
Steps to Reproduce
I've successfully setup sentry, it collects exceptions and errors. I want to configure the sentry.yaml to have Performance Monitoring too. What I found in the official documentation is not a yaml configuration but a Php config that I don't really know how to implement. I imagined that maybe bundles.php is where I have to go but it is a lot of irregular changes for that file. So I searched in this repository and found a full.yaml file which has some related properties but those options are not available for me.
final sentry.yaml after commenting some of the unavailable lines
sentry:
    dsn: '%env(SENTRY_DSN)%'
#    transport_factory: App\Sentry\Transport\TransportFactory
#    logger: app.logger
    options:
        integrations:
            - App\Sentry\Integration\FooIntegration
        default_integrations: false
        send_attempts: 1
        prefixes:
            - '%kernel.project_dir%'
#        sample_rate: 1
#        traces_sample_rate: 1
#        traces_sampler: App\Sentry\Tracing\TracesSampler
        attach_stacktrace: true
        context_lines: 0
        enable_compression: true
        environment: development
        logger: php
        release: 4.0.x-dev
        server_name: localhost
        before_send: App\Sentry\BeforeSendCallback
        tags:
            context: development
        error_types: !php/const E_ALL
        max_breadcrumbs: 1
        before_breadcrumb: App\Sentry\BeforeBreadcrumbCallback
        in_app_exclude:
            - '%kernel.cache_dir%'
        in_app_include:
            - '%kernel.project_dir%'
        send_default_pii: true
        max_value_length: 255
        http_proxy: proxy.example.com:8080
        capture_silenced_errors: true
        max_request_body_size: 'none'
        class_serializers:
            App\FooClass: App\Sentry\Serializer\FooClassSerializer
    messenger:
        enabled: true
        capture_soft_fails: false
    tracing:
        dbal:
            enabled: false
            connections:
                - default
        twig:
            enabled: false
        cache:
            enabled: false
        console:
            excluded_commands:
                - app:command

Expected Result
I though it may start monitoring performance but it didn't.
Actual Result
This error popped up when I tried to reload first page. (the transfer_factory, logger, sample_rate, traces_sample_rate, traces_sampler were all unavailable too.)
Fatal error: Uncaught Symfony\Component\Config\Definition\Exception\InvalidConfigurationException: Unrecognized option "tracing" under "sentry". Available options are "dsn", "listener_priorities", "messenger", "monolog", "options", "register_error_listener". in C:\Users\me\PhpstormProjects\Cafe\vendor\symfony\config\Definition\ArrayNode.php:314 Stack trace: #0 C:\Users\me\PhpstormProjects\Cafe\vendor\symfony\config\Definition\BaseNode.php(410): Symfony\Component\Config\Definition\ArrayNode->normalizeValue(Array) #1 C:\Users\me\PhpstormProjects\Cafe\vendor\symfony\config\Definition\Processor.php(34): Symfony\Component\Config\Definition\BaseNode->normalize(Array) #2 C:\Users\me\PhpstormProjects\Cafe\vendor\symfony\config\Definition\Processor.php(50): Symfony\Component\Config\Definition\Processor->process(Object(Symfony\Component\Config\Definition\ArrayNode), Array) #3 C:\Users\me\PhpstormProjects\Cafe\vendor\symfony\dependency-injection\Extension\Extension.php(111): Symfony\Component\Config\Definition\Processor->p in C:\Users\me\PhpstormProjects\Cafe\vendor\symfony\config\Definition\ArrayNode.php on line 314

Looks like it was an out of date vendor files problem, composer install fixed it.


Roll Flutter Engine from f37733035060 to 7ce53852eadc (1 revision)

https://github.com/flutter/engine/compare/f37733035060...7ce53852eadc
2024-06-05<EMAIL_ADDRESS>Update testing/skia_gold_client/README.md (flutter/engine#53233)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Add discourse actor authorization

@pmusaraj This is ready to go once https://github.com/discourse/discourse-activity-pub/pull/84 is merged.

Authorizations now have a dedicated model and table (existing mastodon authorizations will be migrated)
Discourse actor authorizations are now supported.
The interface in user preferences has been improved.

@pmusaraj This one is ready to go.

@pmusaraj I've rebased and updated this so it's ready again.

Thanks @angusmcleod, will look into this today!

@angusmcleod sorry, "today" came and went. This is still top of my mind for this week, will review it as soon as I can.

@angusmcleod the required user api auth redirects steps make this change difficult to accept for general use, users will just run into the problem too often.
I think we may need a change in core here that lets the plugin handle this more gracefully. Maybe a plugin site setting so that if AP is enabled in the source site, auth redirect URLs coming from other AP Discourse instances can be automatically accepted. What do you think?
In the meantime, do you want to put the Discourse-to-Discourse authentication behind a site setting for the purpose of this PR? Just so we can keep iterating and testing while we work out the auth redirect limitation.

I understand what you're saying and it's been on my mind. The limitation here is that we can't have an open redirect, as it would turn the ActivityPub plugin into a security vulnerability. The premise of this feature, with this limitation in mind, is that there will be a handful of sites that a plurality of forum users are federating with and that the admins of those sites can plausibly authorize the redirect as needed. We can improve the UX, but this will be a hard limitation in this context, unless there's some way of overcoming the vulnerabilities of an open redirect that I'm not familiar with. The long term solution to this is supporting decentralized identity (e.g. identity proofs https://socialhub.activitypub.rocks/t/fep-c390-identity-proofs/2726), however that's a bigger project.

The limitation here is that we can't have an open redirect, as it would turn the ActivityPub plugin into a security vulnerability.

Right, we don't want to allow open redirects. But there's got to be a middle ground. When I authorize myself with Mastodon, I can complete it without the Mastodon admin having to allowlist the Discourse instance. Do they inherently trust redirect urls that match the client application's url? Should we do the same in core?
I should also note that I am getting an error when testing this PR using my Mastodon account. On my test site, I see:

In logs, I see
[Discourse Activity Pub] Failed to process https://mstdn.ca/users/pmusaraj: Could not resolve object

/var/www/discourse/plugins/discourse-activity-pub/lib/discourse_activity_pub/ap/object.rb:138:in `process_failed'
/var/www/discourse/plugins/discourse-activity-pub/lib/discourse_activity_pub/ap/object.rb:151:in `process_failed'
/var/www/discourse/plugins/discourse-activity-pub/lib/discourse_activity_pub/ap/object.rb:199:in `resolve'
/var/www/discourse/plugins/discourse-activity-pub/lib/discourse_activity_pub/ap/object.rb:177:in `resolve_and_store'
/var/www/discourse/plugins/discourse-activity-pub/app/models/discourse_activity_pub_actor.rb:232:in `find_by_ap_id'
/var/www/discourse/plugins/discourse-activity-pub/app/controllers/discourse_activity_pub/authorization_controller.rb:78:in `redirect'
actionpack-<IP_ADDRESS>/lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'

I can authorize the same account (https://mstdn.ca/users/pmusaraj) on meta.discourse.org just fine.

When I authorize myself with Mastodon, I can complete it without the Mastodon admin having to allowlist the Discourse instance. Do they inherently trust redirect urls that match the client application's url? Should we do the same in core?

The reason that it works in Mastodon is because they have a client credentials OAuth flow and each Mastodon instance effectively acts as an OAuth server. But I take your point. Let me think about this a bit more.

Closed in lieu of https://github.com/discourse/discourse-activity-pub/pull/129