allow api keys in external auth token

Here is a scenario:
Customer has an external auth server that generates oauth auth tokens (they must be JWT based). This external auth server can add a claim for the Apigee API Key.
The user must be able to tell the adapter in which claim the api key is contained in the JWT. Once Envoy has validated the JWT, the adapter will run api key verification on the claim.

There are a couple of claims used currently by the adapter, such as api_product_list and application_name, that are likely not in the tokens generated by other oauth servers, and possible impossible to map.

Ok. Here's how it will work:

Operator adds a config item in the handler. eg. api_key_claim:  apikeyfield where apikeyfield is any string valid for a JWT claim
JWT token validated per Istio auth policy
adapter checks passed JWT claims for apikeyfield
a. if present, auth treats as if api_key had been passed directly, no other JWT claims are considered
b. if not present, auth falls back to normal JWT token behavior so properly formatted JWT tokens can still work

Sound good?

LGTM

The final precedence of all auth methods will match this :

If JWT w/ API Key - use API Key in claims
API Key - use API Key
JWT token - use JWT claims

If any method is provided but fails, the next available one(s) will be attempted. If all provided methods fail, the request will be rejected.


Output path as chromium gets successfully downloaded

Fixes #679.

Travis cycled green but didn't update check here: https://travis-ci.org/GoogleChrome/puppeteer/builds/272216427
Force-landing this.


Hash Calculator

Someone suggested this on IRC, could be integrated into the miners chart.

you mean like xmr/day based on avg. hashrate?

Yeah, exactly. I think I can work in something simple into the miner's main graph without too much hassle. We have some room there.

I like the idea, tho it has been disconsidered in the past because it tends to lead new miners in mistake and all the "but the site said I would get X and only got Y" kind of complaints ... just my take on it ...

It's also dependent on external APIs
On Wed., Sep. 25, 2019, 1:33 p.m. kic0<EMAIL_ADDRESS>wrote:

I like the idea, tho it has been disconsidered in the past because it
tends to lead new miners in mistake and all the "but the site said I would
get X and only got Y" kind of complaints ... just my take on it ...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/M5M400/supportxmr-gui/issues/2?email_source=notifications&email_token=AFOTSFZRSOFGGXXLWQH5I6TQLND7BA5CNFSM4IZMSX5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7RSGII#issuecomment-534979361,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFOTSF5VT5TYJYMQBO5ZP63QLND7BANCNFSM4IZMSX5A
.


Interop Integrationpoint shouldn't force to expose appyx interface

Current interop integration point required activities to implement IntegrationPointAppyxProvider.
This expose the interface in module edges, forcing parent modules to implement appyx event if they are not using it.
Example.
Module A -> Module B
Module B implements SomeActiviy: RibAcitivty(), IntegrationPointAppyxProvider{...}
Module A has no appyx dependencies.
Compilation failed as Module A will try to resolve  IntegrationPointAppyxProvider

@SamuPS this should not be a problem in the next release of Appyx. Please let me know whether you still face a problem, and we can reopen this issue.


DCOS-51269: COPS-4710 affecting : Package-specific icons not showing for some services installed from Universe

Add icons for services that are installed from
Universe, but are not classified as Frameworks.
Closes https://jira.mesosphere.com/browse/DCOS-51269
Testing

Start some universe services that are not classified as frameworks, for example "spark-history" or "kibana".
Check that they have their own icons and not the default ones (as icons don't work in production, you can inspect the element to see the link and verify that they are showing a missing icon and not the default one).
Check the same thing for services inside folders.
Verify that no universe or not-universe service breaks the UI.

Trade-offs
This is work in progress. I have to update/add tests, but it's otherwise reviewable.
Dependencies
None.
Screenshots
Before

After

It's great to see this fixed!
Have we found out what the actual issue is? If there are package definitions lacking labels, we should probably tell someone. If it's us (or rather dcos-ui) misinterpreting the data, we should plan to refactor this solution sometime to not only have access to the images but rather all of a frameworks functionality, right?

@pierrebeitz , the problem was that some non-framework services from Universe want to have icons as well and until not we didn't allow them to have icons unless they came from the metadata.

@natmegs , the marathonApps used to only have health properties, now they have non-health properties as well (images), so they fail this check since they lack a key.

@GeorgiSTodorov Right, I guess the part I don't understand is why would adding an additional property (images) cause a check for marathonApps[key].health.key to fail? Are there changes to the health property that I missed?

marathonApps[key].health.key fails, because not all marathonApps keys have health, as some of them are images.

Tomorrow I will post marathonApps before and after to hopefully clear this confusion.

Before

After

We have no name here because the name is not defined here - https://github.com/dcos/dcos-ui/pull/3820/files#diff-7b6a93d2ba53835d3ed69d3f2e183f45R505 . Our first instinct might be to add a name, but the test will still fail, because it doesn't have health.
After with name

An alternative fix would be to check if name exists here - https://github.com/dcos/dcos-ui/pull/3820/files#diff-7b6a93d2ba53835d3ed69d3f2e183f45R505 , but in practice all applications have names and I don't want to change the code only for some test to pass.

@natmegs I think the new addition to processMarathonGroups is causing this data to show up in the test.
I think we should add health data to the application fixtures, or if they aren't supposed to have health data, just modify the test to use a filter() before the forEach() to make it look more deliberate.

@brandonc , I think adding health data to the fixtures is also an option. I will try and I will do it instead, if it's not too complicated.

@juliangieseke said that he wants to do a follow-up PR for these tests.

no follow up PR. found a legit bug in this one.

@juliangieseke , what is the bug?

I pushed @juliangieseke 's fix with the assumption that Applications always have health and snapshot.

@nLight , your suggestions and help are always welcome. What exactly are your concerns?

I will look into the failing tests next week to see if they are legitimate.

Had to restart the current test run, there was a jenkins internal error

:tada: This PR is included in version 2.92.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

Thanks @natmegs , @Poltergeist , @DanielMSchmidt .


Bind not watching deep with key like 'some.inner'

Hello,
The bind function is not watching deep with key like some.inner because angular.isObject always returns false with call:
isObject(scope[key])
The correct is object test must be:
isObject($parse(key)(scope))
Possible related issues:
#322
Best regards,
Bernardo  Baumblatt.

Anyone who uses this feature have any thoughts?

Hello Gregory,
Are you asking for a solution or an opinion? Well, I think that is the first option because of bug label.
In this case, my fault, I was not clear enough. Let me try again..
Actual Code:
var bindToScope = function(scope, key, def, lsKey, type) {

........

return scope.$watch(key, function(newVal) {
    addToLocalStorage(lsKey, newVal, type);
}, isObject(scope[key]));

Fixed Code:
var bindToScope = function(scope, key, def, lsKey, type) {

........

return scope.$watch(key, function(newVal) {
    addToLocalStorage(lsKey, newVal, type);
}, isObject($parse(key)(scope)));

So, and the fix goes to ... line 466!
Best regards,
Bernardo Baumblatt


Weekly Triage meetings: Jan–Jun 2024

Triage issues in JupyterLab and corresponding projects.
Meeting is typically held at 09:00 US Pacific time on Tuesdays.
Meeting info: https://zoom.us/my/jovyan?pwd=c0JZTHlNdS9Sek9vdzR3aTJ4SzFTQT09
Previous notes:

https://github.com/jupyterlab/team-compass/issues/203 (2023-07 through 2023-12)
https://github.com/jupyterlab/team-compass/issues/169 (2023-01 through 2023-06)
https://github.com/jupyterlab/team-compass/issues/151 (2022-07 through 2022-12)
https://github.com/jupyterlab/team-compass/issues/137 (2022-01 through 2022-06)

Goals
Act on long-running, highly demanded, or highly discussed issues to get them ready for development work.
Resources
https://jupyterlab.readthedocs.io/en/latest/developer/contributing.html#submitting-a-pull-request-contribution
Triage Process
All requested information, where applicable, is provided. From the templates in JupyterLab’s issues:
For a bug:

Description, preferably including screen shots
Steps to reproduce
Expected behavior
Context, such as OS, browser, JupyterLab version, and output or log excerpts

For a feature request:

Description of the problem
Description of the proposed solution
Additional context

The issue should represent real, relevant, feasible work. In short, if a knowledgeable person were to be assigned this issue, they would be able to complete it with a reasonable amount of effort and assistance, and it furthers the goals of the Jupyter project.

Issues should be unique; triage is the best time to identify duplicates.
Bugs represent valid expectations for use of Jupyter products and services.
Expectations for security, performance, accessibility, and localization match generally-accepted norms in the community that uses Jupyter products.
The issue represents work that one developer can commit to owning, even if they collaborate with other developers for feedback. Excessively large issues should be split into multiple issues, each triaged individually, or into team-compass issues to discuss more substantive changes.

Read issues
Tag issues
a. good first issue
b. bug
c. feature parity
d. Tag milestones
Identify duplicates
Respond to issues
Assign another person

Add milestone if you can achieve the goal.
Meetings
Primary focus:

JupyterLab untriaged issues
Notebook untriaged issues
JupyterLab Desktop untriaged issues

January 2, 2024

Name
Organization
Username

Jason Weill
AWS
@jweill-aws

Michał Krassowski
QuanSight
@krassowski

Rosio Reyes
Anaconda
@RRosio

Before the meeting, 21 issues in JupyterLab needed triage. After the meeting, 7 remain.

https://github.com/jupyterlab/jupyterlab/issues/15527 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/15529 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/15535 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/15545 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/15546 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15547 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15550 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15557 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15558 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15559 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/15560 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15561 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15566 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/15569 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15573 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/15574 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15579 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15589 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15590 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15594 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15595 (accepted)

Before the meeting, 6 issues in Notebook needed triage. After the meeting, 2 remain.

https://github.com/jupyter/notebook/issues/7182 (needs info)
https://github.com/jupyter/notebook/issues/7195 (accepted)
https://github.com/jupyter/notebook/issues/7199 (accepted)
https://github.com/jupyter/notebook/issues/7200 (accepted)
https://github.com/jupyter/notebook/issues/7202 (needs info)
https://github.com/jupyter/notebook/issues/7205 (accepted)

We did not triage JupyterLab Desktop issues, due to a lack of time.

January 9, 2024

Name
Organization
Username

Jason Weill
AWS
@JasonWeill

Eric Gentry
Anaconda
@ericsnekbytes

Rosio Reyes
Anaconda
@RRosio

Jeremy Tuloup
QuantStack
@jtpio

Before the meeting, 20 issues in JupyterLab needed triage. After the meeting, 5 remain.

https://github.com/jupyterlab/jupyterlab/issues/15527 (closed)
https://github.com/jupyterlab/jupyterlab/issues/15529 (closed)
https://github.com/jupyterlab/jupyterlab/issues/15535 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/15545 (closed)
https://github.com/jupyterlab/jupyterlab/issues/15566 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/15573 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/15601 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15602 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/15603 (closed)
https://github.com/jupyterlab/jupyterlab/issues/15605 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15606 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15608 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15609 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15610 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15611 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15613 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15614 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15615 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/15616 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15617 (accepted)

Before the meeting, 5 issues in Notebook needed triage. After the meeting, 2 remain.

https://github.com/jupyter/notebook/issues/7182 (accepted)
https://github.com/jupyter/notebook/issues/7202 (needs info)
https://github.com/jupyter/notebook/issues/7208 (accepted)
https://github.com/jupyter/notebook/issues/7209 (needs info)
https://github.com/jupyter/notebook/issues/7210 (accepted)

Before the meeting, 4 issues in JupyterLab Desktop needed triage. After the meeting, 1 remains.

https://github.com/jupyterlab/jupyterlab-desktop/issues/727 (accepted)
https://github.com/jupyterlab/jupyterlab-desktop/issues/729 (needs info)
https://github.com/jupyterlab/jupyterlab-desktop/issues/739 (closed)
https://github.com/jupyterlab/jupyterlab-desktop/issues/744 (closed)

January 23, 2024

Name
Organization
Username

Jason Weill
AWS
@JasonWeill

Michał Krassowski
QuanSight
@krassowski

Rosio Reyes
Anaconda
@RRosio

Akshay Patil

Before the meeting, 33 issues in JupyterLab needed triage. After the meeting, 5 remain.

https://github.com/jupyterlab/jupyterlab/issues/12545 (closed)
https://github.com/jupyterlab/jupyterlab/issues/15535 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15566 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15573 (closed)
https://github.com/jupyterlab/jupyterlab/issues/15602 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/15624 (closed, duplicate of https://github.com/jupyterlab/jupyterlab/issues/14752)
https://github.com/jupyterlab/jupyterlab/issues/15625 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15628 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15629 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15632 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15633 (closed, fixed by https://github.com/jupyterlab/jupyterlab/pull/15642)
https://github.com/jupyterlab/jupyterlab/issues/15635 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15637 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/15651 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15654 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15655 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15656 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15657 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15658 (closed in favor of https://github.com/jupyter-server/jupyter-scheduler/issues/473)
https://github.com/jupyterlab/jupyterlab/issues/15660 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15663 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15664 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15670 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15671 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15672 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15673 (needs discussion)
https://github.com/jupyterlab/jupyterlab/issues/15674 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/15675 (closed)
https://github.com/jupyterlab/jupyterlab/issues/15676 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15681 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15682 (closed, duplicate of https://github.com/jupyterlab/jupyterlab/issues/2405)
https://github.com/jupyterlab/jupyterlab/issues/15683 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/15685 (accepted)

Before the meeting, 4 issues in Notebook needed triage. After the meeting, 1 remains.

https://github.com/jupyter/notebook/issues/7202 (accepted)
https://github.com/jupyter/notebook/issues/7214 (accepted)
https://github.com/jupyter/notebook/issues/7216 (accepted)
https://github.com/jupyter/notebook/issues/7221 (needs info)

We did not triage JupyterLab Desktop issues, due to a lack of time.

January 30, 2024

Name
Organization
Username

Jason Weill
AWS
@JasonWeill

Michał Krassowski
QuanSight
@krassowski

Before the meeting, 14 issues in JupyterLab needed triage. After the meeting, 1 remains.

https://github.com/jupyterlab/jupyterlab/issues/15602 (accepted, blocked)
https://github.com/jupyterlab/jupyterlab/issues/15637 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15673 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15674 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/15686 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15689 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15693 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15698 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15700 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15704 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15705 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15706 (closed)
https://github.com/jupyterlab/jupyterlab/issues/15709 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15713 (accepted)

Before the meeting, 2 issues in Jupyter Notebook needed triage. After the meeting, none remain.

https://github.com/jupyter/notebook/issues/7221 (accepted)
https://github.com/jupyter/notebook/issues/7225 (accepted)

Before the meeting, 3 issues in JupyterLab Desktop needed triage. After the meeting, none remain.

https://github.com/jupyterlab/jupyterlab-desktop/issues/745 (accepted)
https://github.com/jupyterlab/jupyterlab-desktop/issues/746 (accepted)
https://github.com/jupyterlab/jupyterlab-desktop/issues/754 (accepted)

February 7, 2024

Name
Organization
Username

Jason Weill
AWS
@JasonWeill

Michał Krassowski
QuanSight
@krassowski

Before the meeting, 13 issues in JupyterLab needed triage. After the meeting, 2 remain.

https://github.com/jupyterlab/jupyterlab/issues/9665 (needs user testing)
https://github.com/jupyterlab/jupyterlab/issues/15674 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/15719 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15725 (closed in favor of https://github.com/ipython/ipython/issues/14319)
https://github.com/jupyterlab/jupyterlab/issues/15729 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15739 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15741 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15744 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15746 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15748 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15749 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15754 (closed, duplicate of https://github.com/jupyterlab/jupyterlab/issues/15744)
https://github.com/jupyterlab/jupyterlab/issues/15755 (closed, duplicate of https://github.com/jupyterlab/team-compass/issues/234)

Before the meeting, 4 issues in Jupyter Notebook needed triage. After the meeting, 1 remains.

https://github.com/jupyter/notebook/issues/7228 (closed)
https://github.com/jupyter/notebook/issues/7229 (accepted)
https://github.com/jupyter/notebook/issues/7231 (accepted)
https://github.com/jupyter/notebook/issues/7238 (needs info)

Before the meeting, 1 issue in JupyterLab Desktop needed triage. After the meeting, 1 remains.

https://github.com/jupyterlab/jupyterlab-desktop/issues/759 (needs info)

February 13, 2024

Name
Organization
Username

Jason Weill
AWS
@JasonWeill

Before the meeting, 17 issues in JupyterLab needed triage. After the meeting, 1 remains.

https://github.com/jupyterlab/jupyterlab/issues/9665 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/15674 (closed)
https://github.com/jupyterlab/jupyterlab/issues/15731 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15757 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15758 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15759 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15764 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15768 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15771 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15776 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15777 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15786 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15787 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15786 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15787 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15792 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15793 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15795 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15796 (accepted)

Before the meeting, 6 issues in Jupyter Notebook needed triage. After the meeting, 4 remain.

https://github.com/jupyter/notebook/issues/7238 (needs info)
https://github.com/jupyter/notebook/issues/7239 (needs info)
https://github.com/jupyter/notebook/issues/7241 (accepted)
https://github.com/jupyter/notebook/issues/7242 (closed in favor of https://github.com/ipython/ipykernel/issues/1211)
https://github.com/jupyter/notebook/issues/7252 (needs info)
https://github.com/jupyter/notebook/issues/7254 (needs info)

Before the meeting, 3 issue in JupyterLab Desktop needed triage. After the meeting, 1 remains.

https://github.com/jupyterlab/jupyterlab-desktop/issues/759 (needs info)
https://github.com/jupyterlab/jupyterlab-desktop/issues/767 (accepted)
https://github.com/jupyterlab/jupyterlab-desktop/issues/768 (closed)

February 27, 2024

Name
Organization
Username

Jason Weill
AWS
@JasonWeill

Before the meeting, 14 issues in JupyterLab needed triage. After the meeting, 3 remain.

https://github.com/jupyterlab/jupyterlab/issues/15806 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/15816 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/15820 (closed)
https://github.com/jupyterlab/jupyterlab/issues/15835 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15836 (closed, duplicate of https://github.com/jupyterlab/jupyterlab/issues/15704)
https://github.com/jupyterlab/jupyterlab/issues/15856 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15859 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15861 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15863 (needs discussion)
https://github.com/jupyterlab/jupyterlab/issues/15868 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15870 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15871 (accepted)

Before the meeting, 9 issues in Jupyter Notebook needed triage. After the meeting, 3 remain. (@RRosio triaged all of these except 7275.)

https://github.com/jupyter/notebook/issues/7239 (closed)
https://github.com/jupyter/notebook/issues/7252 (closed)
https://github.com/jupyter/notebook/issues/7254 (closed)
https://github.com/jupyter/notebook/issues/7263 (needs info)
https://github.com/jupyter/notebook/issues/7271 (accept)
https://github.com/jupyter/notebook/issues/7275 (need triage)
https://github.com/jupyter/notebook/issues/7276 (accept)
https://github.com/jupyter/notebook/issues/7279 (accept)

No issues in JupyterLab Desktop needed triage.

March 5, 2024

Name
Organization
Username

Jason Weill
AWS
@JasonWeill

Michał Krassowski
QuanSight
@krassowski

Before the meeting, 13 issues in JupyterLab needed triage. After the meeting, 1 remains.

https://github.com/jupyterlab/jupyterlab/issues/15806 (closed)
https://github.com/jupyterlab/jupyterlab/issues/15816 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15863 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15890 (closed)
https://github.com/jupyterlab/jupyterlab/issues/15897 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15900 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/15901 (closed, duplicate of https://github.com/jupyterlab/jupyterlab/issues/15821)
https://github.com/jupyterlab/jupyterlab/issues/15902 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15903 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15907 (closed, duplicate of https://github.com/jupyterlab/jupyterlab/issues/15525)
https://github.com/jupyterlab/jupyterlab/issues/15911 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15912 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15918 (accepted)

Before the meeting, 7 issues in Notebook needed triage. After the meeting, 1 remains.

https://github.com/jupyter/notebook/issues/7263 (closed)
https://github.com/jupyter/notebook/issues/7275 (closed)
https://github.com/jupyter/notebook/issues/7284 (needs info)
https://github.com/jupyter/notebook/issues/7285 (accepted)
https://github.com/jupyter/notebook/issues/7286 (accepted)
https://github.com/jupyter/notebook/issues/7287 (accepted)
https://github.com/jupyter/notebook/issues/7288 (accepted)

Before the meeting, 5 issues in JupyterLab Desktop needed triage. After the meeting, 1 remains.

https://github.com/jupyterlab/jupyterlab-desktop/issues/783 (accepted)
https://github.com/jupyterlab/jupyterlab-desktop/issues/784 (accepted)
https://github.com/jupyterlab/jupyterlab-desktop/issues/785 (closed, duplicate of https://github.com/jupyterlab/jupyterlab-desktop/issues/307)
https://github.com/jupyterlab/jupyterlab-desktop/issues/786 (accepted)
https://github.com/jupyterlab/jupyterlab-desktop/issues/787 (needs info)

@RRosio Thank you very much for triaging the Notebook issues for the last couple of weeks! Would another time of day work better for you so that we could all join triage together?

March 12, 2024

Name
Organization
Username

Jason Weill
AWS
@JasonWeill

Michał Krassowski
QuanSight
@krassowski

Rosio Reyes
Anaconda
@RRosio

Before the meeting, 23 issues in JupyterLab needed triage. After the meeting, 1 remains.

https://github.com/jupyterlab/jupyterlab/issues/15900 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15919 (closed, duplicate of https://github.com/jupyterlab/jupyterlab/issues/6129)
https://github.com/jupyterlab/jupyterlab/issues/15921 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15923 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/15929 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15930 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15931 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15933 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15937 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15939 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15943 (closed, duplicate of https://github.com/jupyterlab/jupyterlab/issues/4778)
https://github.com/jupyterlab/jupyterlab/issues/15944 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15947 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15951 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15952 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15955 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15960 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15965 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15966 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15967 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15968 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15971 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15972 (accepted)

Before the meeting, 2 issues in Notebook needed triage. After the meeting, 1 remains.

https://github.com/jupyter/notebook/issues/7289 (closed)
https://github.com/jupyter/notebook/issues/7293 (needs info)

Before the meeting, 1 issue in JupyterLab Desktop needed triage. After the meeting, none remains.

https://github.com/jupyterlab/jupyterlab-desktop/issues/792 (accepted)

March 19, 2024

Name
Organization
Username

Jason Weill
AWS
@JasonWeill

Michał Krassowski
QuanSight
@krassowski

Before the meeting, 20 issues in JupyterLab needed triage. After the meeting, 5 remain.

https://github.com/jupyterlab/jupyterlab/issues/15923 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15977 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15979 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/15980 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/15981 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15986 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15989 (answered)
https://github.com/jupyterlab/jupyterlab/issues/15990 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15991 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15992 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15993 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/15999 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16001 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/16002 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/16003 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16007 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16008 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16019 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16020 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16021 (accepted)

Before the meeting, 4 issues in Notebook needed triage. After the meeting, 2 remain.

https://github.com/jupyter/notebook/issues/7283 (needs info)
https://github.com/jupyter/notebook/issues/7293 (accepted)
https://github.com/jupyter/notebook/issues/7296 (accepted)
https://github.com/jupyter/notebook/issues/7298 (needs info)

Before the meeting, 2 issues in JupyterLab Desktop needed triage. After the meeting, 1 remains.

https://github.com/jupyterlab/jupyterlab-desktop/issues/796 (needs info)
https://github.com/jupyterlab/jupyterlab-desktop/issues/799 (accepted)

April 2, 2024

Name
Organization
Username

Jason Weill
AWS
@JasonWeill

Michał Krassowski
QuanSight
@krassowski

Rosio Reyes
Anaconda
@RRosio

Before the meeting, 11 issues in JupyterLab needed triage. After the meeting, 2 remain.

https://github.com/jupyterlab/jupyterlab/issues/16001 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/16035 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/16040 (closed)
https://github.com/jupyterlab/jupyterlab/issues/16062 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16063 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16065 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16066 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16074 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16076 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16079 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16085 (accepted)

Before the meeting, 4 issues in Notebook needed triage. After the meeting, 2 remain.

https://github.com/jupyter/notebook/issues/7303 (closed in favor of https://github.com/jupyterlab/jupyterlab/issues/5908)
https://github.com/jupyter/notebook/issues/7304 (needs info)
https://github.com/jupyter/notebook/issues/7310 (accepted)
https://github.com/jupyter/notebook/issues/7311 (accepted)

Before the meeting, 4 issues in JupyterLab Desktop needed triage. After the meeting, 2 remain.

https://github.com/jupyterlab/jupyterlab-desktop/issues/796 (needs info)
https://github.com/jupyterlab/jupyterlab-desktop/issues/802 (closed)
https://github.com/jupyterlab/jupyterlab-desktop/issues/804 (closed, duplicate of https://github.com/jupyterlab/jupyterlab-desktop/issues/709)
https://github.com/jupyterlab/jupyterlab-desktop/issues/807 (needs info)

April 16, 2024

Name
Organization
Username

Jason Weill
AWS
@JasonWeill

Michał Krassowski
QuanSight
@krassowski

Rosio Reyes
Anaconda
@RRosio

Before the meeting, 7 issues in JupyterLab needed triage. After the meeting, 1 remains.

https://github.com/jupyterlab/jupyterlab/issues/16143 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16144 (closed, duplicate of https://github.com/jupyterlab/jupyterlab/issues/14106)
https://github.com/jupyterlab/jupyterlab/issues/16145 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16148 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/16164 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16165 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16167 (accepted)

Before the meeting, 8 issues in Notebook needed triage. After the meeting, 3 remain.

https://github.com/jupyter/notebook/issues/7304 (needs info)
https://github.com/jupyter/notebook/issues/7310 (needs info)
https://github.com/jupyter/notebook/issues/7316 (closed)
https://github.com/jupyter/notebook/issues/7317 (accepteD)
https://github.com/jupyter/notebook/issues/7318 (accepted)
https://github.com/jupyter/notebook/issues/7320 (closed)
https://github.com/jupyter/notebook/issues/7322 (closed, duplicate of https://github.com/jupyter/notebook/issues/7062)
https://github.com/jupyter/notebook/issues/7323 (needs info)

We did not triage JupyterLab Desktop issues, due to time constraints.

April 23, 2024

Name
Organization
Username

Jason Weill
AWS
@JasonWeill

Rosio Reyes
Anaconda
@RRosio

Eric Gentry
Anaconda
@ericsnekbytes

Before the meeting, 29 issues in JupyterLab needed triage. After the meeting, 3 remain.

https://github.com/jupyterlab/jupyterlab/issues/16174 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16175 (closed)
https://github.com/jupyterlab/jupyterlab/issues/16176 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16177 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16178 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16179 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16180 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16181 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16182 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16183 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16184 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16185 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16186 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16187 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16192 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16196 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16200 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16201 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/16203 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16205 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16209 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16210 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16211 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16212 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16215 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16220 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16221 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/16226 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16227 (needs info)

Before the meeting, 11 issues in Notebook needed triage. After the meeting, 6 remain.

https://github.com/jupyter/notebook/issues/7304 (needs info)
https://github.com/jupyter/notebook/issues/7310 (needs info)
https://github.com/jupyter/notebook/issues/7323 (accepted)
https://github.com/jupyter/notebook/issues/7325 (needs info)
https://github.com/jupyter/notebook/issues/7329 (accepted)
https://github.com/jupyter/notebook/issues/7330 (needs info)
https://github.com/jupyter/notebook/issues/7334 (accepted, maintenance)
https://github.com/jupyter/notebook/issues/7336 (needs info)
https://github.com/jupyter/notebook/issues/7338 (needs info)
https://github.com/jupyter/notebook/issues/7339 (closed)
https://github.com/jupyter/notebook/issues/7340 (accepted)

Before the meeting, 4 issues in JupyterLab Desktop needed triage. After the meeting, 2 remain.

https://github.com/jupyterlab/jupyterlab-desktop/issues/796 (needs info)
https://github.com/jupyterlab/jupyterlab-desktop/issues/807 (needs info)
https://github.com/jupyterlab/jupyterlab-desktop/issues/808 (accepted)
https://github.com/jupyterlab/jupyterlab-desktop/issues/812 (closed)

May 7, 2024

Name
Organization
Username

Jason Weill
AWS
@JasonWeill

Rosio Reyes
Anaconda
@RRosio

Michał Krassowski
QuanSight
@krassowski

Carlos Brandt

@chbrandt

Before the meeting, 18 issues in JupyterLab needed triage. After the meeting, 2 remains.

https://github.com/jupyterlab/jupyterlab/issues/16267 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/16272 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16276 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16277 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16278 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16279 (answered)
https://github.com/jupyterlab/jupyterlab/issues/16280 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16281 (closed)
https://github.com/jupyterlab/jupyterlab/issues/16282 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16283 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16286 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16289 (closed, duplicate of https://github.com/jupyter-lsp/jupyterlab-lsp/issues/1082)
https://github.com/jupyterlab/jupyterlab/issues/16290 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16294 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16295 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16297 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16299 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16303 (accepted)

Before the meeting, 7 issues in Notebook needed triage. After the meeting, 3 remain.

https://github.com/jupyter/notebook/issues/7304 (closed)
https://github.com/jupyter/notebook/issues/7310 (closed)
https://github.com/jupyter/notebook/issues/7325 (needs info)
https://github.com/jupyter/notebook/issues/7338 (needs info)
https://github.com/jupyter/notebook/issues/7351 (needs info)
https://github.com/jupyter/notebook/issues/7358 (accepted)
https://github.com/jupyter/notebook/issues/7359 (accepted)

Before the meeting, 4 issues in JupyterLab Desktop needed triage. After the meeting, 1 remains.

https://github.com/jupyterlab/jupyterlab-desktop/issues/796 (closed)
https://github.com/jupyterlab/jupyterlab-desktop/issues/815 (closed)
https://github.com/jupyterlab/jupyterlab-desktop/issues/822 (accepted)
https://github.com/jupyterlab/jupyterlab-desktop/issues/824 (needs info)

May 14, 2024

Name
Organization
Username

Jason Weill
AWS
@JasonWeill

Michał Krassowski
QuanSight
@krassowski

Before the meeting, 15 issues in JupyterLab needed triage. After the meeting, 2 remain.

https://github.com/jupyterlab/jupyterlab/issues/16267 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/16279 (closed)
https://github.com/jupyterlab/jupyterlab/issues/16310 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16311 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16313 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16315 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16316 (closed)
https://github.com/jupyterlab/jupyterlab/issues/16319 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16320 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/16321 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16323 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16326 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16327 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16328 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16329 (accepted)

Before the meeting, 11 issues in Notebook needed triage. After the meeting, 2 remain.

https://github.com/jupyter/notebook/issues/7325 (needs info)
https://github.com/jupyter/notebook/issues/7338 (needs info)
https://github.com/jupyter/notebook/issues/7351 (closed)
https://github.com/jupyter/notebook/issues/7360 (accepted)
https://github.com/jupyter/notebook/issues/7364 (accepted)
https://github.com/jupyter/notebook/issues/7365 (accepted)
https://github.com/jupyter/notebook/issues/7366 (accepted)
https://github.com/jupyter/notebook/issues/7367 (accepted)
https://github.com/jupyter/notebook/issues/7368 (accepted)
https://github.com/jupyter/notebook/issues/7369 (closed, duplicate of https://github.com/jupyterlab/jupyterlab/issues/15610)
https://github.com/jupyter/notebook/issues/7370 (accepted)

No issues in JupyterLab Desktop needed triage.

May 21, 2024

Name
Organization
Username

Jason Weill
AWS
@JasonWeill

Michał Krassowski
QuanSight
@krassowski

Rosio Reyes
Anaconda
@RRosio

Jiayi Xu

@Sunnyweather1314

Before the meeting, 10 issues in JupyterLab needed triage. After the meeting, none remain.

https://github.com/jupyterlab/jupyterlab/issues/16320 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16332 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16334 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16336 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16337 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16339 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16340 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16345 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16347 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16349 (accepted)

Before the meeting, 4 issues in Notebook needed triage. After the meeting, none remain.

https://github.com/jupyter/notebook/issues/7325 (closed)
https://github.com/jupyter/notebook/issues/7338 (accepted)
https://github.com/jupyter/notebook/issues/7373 (accepted)
https://github.com/jupyter/notebook/issues/7376 (accepted)

Before the meeting, 2 issues in JupyterLab Desktop needed triage. After the meeting, none remain.

https://github.com/jupyterlab/jupyterlab-desktop/issues/826 (closed)
https://github.com/jupyterlab/jupyterlab-desktop/issues/827 (accepted)

May 28, 2024

Name
Organization
Username

Jason Weill
AWS
@JasonWeill

Michał Krassowski
QuanSight
@krassowski

Rosio Reyes
Anaconda
@RRosio

Before the meeting, 14 issues in JupyterLab needed triage. After the meeting, 2 remain.

https://github.com/jupyterlab/jupyterlab/issues/16350 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/16353 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16358 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16359 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16364 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16366 (closed, moved to https://github.com/jupyter/nbclassic/issues/281)
https://github.com/jupyterlab/jupyterlab/issues/16369 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16371 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16373 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/16374 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16376 (closed, duplicate of https://github.com/jupyterlab/jupyterlab/issues/15013)
https://github.com/jupyterlab/jupyterlab/issues/16379 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16386 (closed)

Before the meeting, 4 issues in Notebook needed triage. After the meeting, 1 remains.

https://github.com/jupyter/notebook/issues/7375 (closed, duplicate of https://github.com/jupyter/notebook/issues/7373)
https://github.com/jupyter/notebook/issues/7377 (needs info)
https://github.com/jupyter/notebook/issues/7379 (accepted)
https://github.com/jupyter/notebook/issues/7380 (accepted)

Before the meeting, 5 issues in Classic Notebook (nbclassic) needed triage. After the meeting, none remain.

https://github.com/jupyter/nbclassic/issues/266 (accepted)
https://github.com/jupyter/nbclassic/issues/272 (accepted)
https://github.com/jupyter/nbclassic/issues/273 (accepted)
https://github.com/jupyter/nbclassic/issues/276 (accepted)
https://github.com/jupyter/nbclassic/issues/281 (accepted)

No issues in JupyterLab Desktop needed triage.

June 4, 2024

Name
Organization
Username

Jason Weill
AWS
@JasonWeill

Michał Krassowski
QuanSight
@krassowski

Rosio Reyes
Anaconda
@RRosio

Before the meeting, 18 issues in JupyterLab needed triage. After the meeting, 5 remain.

https://github.com/jupyterlab/jupyterlab/issues/16350 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/16373 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16388 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16389 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/16391 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16395 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/16399 (moved to https://github.com/jupyterlab/jupyterlab-desktop/issues/834, accepted)
https://github.com/jupyterlab/jupyterlab/issues/16400 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16401 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16402 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16410 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/16413 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16415 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16416 (needs discussion)
https://github.com/jupyterlab/jupyterlab/issues/16422 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16425 (closed)
https://github.com/jupyterlab/jupyterlab/issues/16426 (closed, duplicate of https://github.com/jupyterlab/jupyterlab/issues/15267)
https://github.com/jupyterlab/jupyterlab/issues/16433

Before the meeting, 5 issues in Notebook needed triage. After the meeting, 2 remain.

https://github.com/jupyter/notebook/issues/7377 (closed)
https://github.com/jupyter/notebook/issues/7381 (closed, duplicate of https://github.com/jupyterlab/jupyterlab/issues/12583)
https://github.com/jupyter/notebook/issues/7383 (needs info)
https://github.com/jupyter/notebook/issues/7388 (needs info)
https://github.com/jupyter/notebook/issues/7390 (accepted)

Before the meeting, 2 issues in JupyterLab Desktop needed triage. After the meeting, 2 remain.

https://github.com/jupyterlab/jupyterlab-desktop/issues/831 (needs info)
https://github.com/jupyterlab/jupyterlab-desktop/issues/833 (needs info)

No issues in Classic Notebook (nbclassic) needed triage.

June 18, 2024

Name
Organization
Username

Jason Weill
AWS
@JasonWeill

Rosio Reyes
Anaconda
@RRosio

Michał Krassowski
QuanSight
@krassowski

Before the meeting, 15 issues in JupyterLab needed triage. After the meeting, 2 remain.

https://github.com/jupyterlab/jupyterlab/issues/16389 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/16410 (closed)
https://github.com/jupyterlab/jupyterlab/issues/16416 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16468 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16478 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16479 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16480 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16481 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16483 (closed)
https://github.com/jupyterlab/jupyterlab/issues/16485 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16489 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16491 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16492 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16494 (closed)
https://github.com/jupyterlab/jupyterlab/issues/16497 (needs info)

Before the meeting, 5 issues in Notebook needed triage. After the meeting, 2 remain.

https://github.com/jupyter/notebook/issues/7388 (closed)
https://github.com/jupyter/notebook/issues/7394 (accepted)
https://github.com/jupyter/notebook/issues/7397 (needs info)
https://github.com/jupyter/notebook/issues/7398 (accepted)
https://github.com/jupyter/notebook/issues/7401 (needs info)

Before the meeting, 3 issues in JupyterLab Desktop needed triage. After the meeting, 2 remain.

https://github.com/jupyterlab/jupyterlab-desktop/issues/837 (needs info)
https://github.com/jupyterlab/jupyterlab-desktop/issues/839 (needs info)
https://github.com/jupyterlab/jupyterlab-desktop/issues/840 (closed, duplicate of https://github.com/jupyterlab/jupyterlab-desktop/issues/824)

No issues in Classic Notebook (nbclassic) needed triage.

June 25, 2024

Name
Organization
Username

Jason Weill
AWS
@JasonWeill

Rosio Reyes
Anaconda
@RRosio

Before the meeting, 8 issues in JupyterLab needed triage. After the meeting, 4 remain.

https://github.com/jupyterlab/jupyterlab/issues/16389 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/16497 (closed)
https://github.com/jupyterlab/jupyterlab/issues/16499 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16505 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16513 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/16515 (accepted)
https://github.com/jupyterlab/jupyterlab/issues/16517 (needs info)
https://github.com/jupyterlab/jupyterlab/issues/16518 (accepted)

Before the meeting, 4 issues in Notebook needed triage. After the meeting, 3 remain.

https://github.com/jupyter/notebook/issues/7397 (closed, moved to https://github.com/jupyterlab/jupyterlab/issues/16522)
https://github.com/jupyter/notebook/issues/7401 (needs info)
https://github.com/jupyter/notebook/issues/7402 (needs info)
https://github.com/jupyter/notebook/issues/7407 (needs info)

Before the meeting, 2 issues in JupyterLab Desktop needed triage. After the meeting, none remain.

https://github.com/jupyterlab/jupyterlab-desktop/issues/837 (accepted)
https://github.com/jupyterlab/jupyterlab-desktop/issues/841 (accepted)

No issues in Classic Notebook (nbclassic) needed triage.


Propagate error stacktrace in monitor

Wouldn't it be more informative to the advanced user to receive whatever was thrown (especially if it's an error object)?

@jeffbski Please let me know if this is a feasible change! We're using redux-logic and want to be able to send the stacktrace up to our bug tracking service.

Any updates on this? would love to have it in my projects 😭

landed in 4.0.0

Thank you so much!

 Sorry for the delay, I somehow didn't see it was there.
On Wed, Mar 17, 2021 at 5:08 PM nightpool @.***> wrote:

Thank you so much!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/jeffbski/redux-logic/pull/144#issuecomment-801474186,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAABMOK63W2BD3R3DLRSNALTEER5BANCNFSM4HLDO6IA
.

--
Jeff Barczewski
Founder of CodeWinds
http://codewinds.com/
Live and Online developer training


goauth2 is deprecated

golang.org/x/oauth2 should be supported in it's place.

yep.  @kjk started to update links in #163, but we need to update the sample code as well.  Feel free to send over a PR, or otherwise I'll get to it when I can.

PR at #166

very timely considering the upcoming code.google.com sunset! :smile:

fixed in #166


askForUpdatePermission

Hi, it's a way to request for update permission to get push notifications work?

Currently that is not available.  That will be added soon, probably this week.

ok, thanks.

Version 1.6.0 now has askForUpdatePermission and related functions.  Can you verify this is working and post results here?

Ok, I'll test and let you know if work.


chore(release): v0.4.0 🎉

:robot: I have created a release *beep* *boop*
0.4.0 (2022-02-24)
Features

events: expose method to create example kinesis event (a656110)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/uladkasach/simple-lambda-testing-methods/releases/tag/v0.4.0 :sunflower:


Supported AWS MSK version with dapr 1.9.5

Hi Team,
We are currently using dapr 1.9.5 and we would like to know what is the supported AWS MSK version for pub/sub component?
We are getting the following error with Apache kafka (AWS MSK) version 2.8.1,
"error when publish to topic StateStorItemCreated in pubsub kafka-pubsub: kafka server: Request was for a topic or partition that does not exist on this broker"

We have not tested with AWS MSK yet. From the error message, I would first see if the topic is already present in MSK - but the error message can just be masking another issue behind the scenes.
If you have AWS support plan, I recommend reaching out to them. It would be great to see AWS being more active on Dapr OSS project.

This issue is resolved. Basically the issue is in our MSK cluster configuration and while creating the MSK cluster, used the default configuration.  Created a new configuration by modifying the below parameters,
auto.create.topics.enable=true --> default value is false.
default.replication.factor=2 --> default value is 3, but in our env we have only two zones.
With the above configuration dpar pub/sub component is working fine.


Issue with running the project

Hey childrentime, I tried running the project located in /examples/base, but it seems that I couldn't get it work. I'm not sure if I'm launching it incorrectly.
Here's how I  started the project:

In the /pareto, pnpm i
In the /examples/base, pnpm dev

When I visit localhost:4000, the project doesn't start.  Could you please confirm whether I have started the project correctly, or if the project is still under development?

sorry. please visit localhost:4000/home because it need to map routes.

The project is under devoplopment. I have some changes in local.  However, I've been quite busy with work recently. As soon as I get a bit of free time, I will push again.


Feature Request : New command - zectl chroot

I would like to request a new feature that I think might be useful.  When working with some machines I have zectl on I have setup a "recovery" rootfs.  This exists on all of my systems and I use it bring up the system.  Afterwards I clone this environment and use the clone to build out the rest of the system.  If the system ever ends up in an un-bootable state I can use this as a starting point to fix issues.  In the middle of this recovery process and maybe other processes I think it might be useful to be able to chroot into another "env".  It would be great if zectl could handle the process of setting up the mounts and everything necessary to allow me to chroot into another root and run things like pacman to correct errors in the system.  I have not put much thought into how something like this might exactly work though.

I agree this would be a nice feature, I will put it on my list of potential improvements.
One concern I have is making sure it works correctly on multiple different distros.


Restrict logging org.apache.catalina to INFO in logging.properties

It appears we don't have any restrictions, so when we change the overall default to FINE, we get too much logging from org.apache.catalina (like processExpires every minute).

Basically, this involves adding the following line to multiple logging.properties files. The line is:
org.apache.catalina.level = INFO

The files are:

eureka-webapp/src/main/resources/logging.properties
eureka-services/src/main/resources/logging.properties
eureka-protempa-etl/src/main/resources/logging.properties

Done.


chore(package): update npm-pkgbuild to version 6.0.14

:tada: This PR is included in version 5.0.51 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Clicking a number for the next month in December goes backwards

When looking at the calendar for December, 2012 and pressing the number 4 for the next month (Jan 4, 2013), it instead selects November 4, 2012.
Screenshot:

Click the 4 and it selects November 4 instead of what should be January 4.

Do you know what fixed this. I cannot update to the latest master, so need to patch our version.


[FEATURE] Limited products per user

Is your feature request related to a problem? Please describe.
No, my feature request is not related to any problems
Describe the solution you'd like
It would be nice to see a way for free products to have a limit per user. For example: A user could receive one free bot host and no more
Describe alternatives you've considered
Possibly a manual review of orders before manually completing orders.

Hi,
This feature has now been included in commit 5b223e56d03b7828268a62707755789f5eecd9d1


No Detailed error message while deploying data factory

Hello,
We are getting only data exception error message while deploying the code using release. Please check below screen shot for more details.

Did you enable Diagnostic/debug log to see more details?


Proposal section 3 and sketch

Readme related:

[x] sketch

Proposal section 3 related

[ ] persona/usage example

@shivajena Thanks for the work.  It looks good as far as the requirements of milestone1 is concerned.  But since I am not the reviewer, I will let @squisty merge into the main branch if he sees fit.

For the avoidance of doubt, I will have the README.md link to the sketch file appropriate once it is merged into the main branch.


[style]: Improving Navbar

What's the style idea?
We need to improve the navigation section as it looks very simple and we can improve some features of nav bar like adding seach bar.
Add screenshots
Add screenshots
Code of Conduct

[ ] I agree to follow this project's Code of Conduct

can i also improve by contributing the navbar

Hey @Tanusingh02 !
I would love to work on this issue.
Kindly assign me this issue under the GSSOC '23

Hey @Tanusingh02
I would like to help you in improving the nav bar.
As you said we can add the search bar and even change some themes either by using Material UI or CSS.
Please assign me this issue under GSSOC '23 whenever it's possible.

Hey We can improve the navbar by implementing the hover effect , (scaling over hovering and light outline).
We can also change the color item once it is clicked.
We can change the light/dark emoji to an more relatable icon.
We can implement an bottom border for navbar to separate it from the rest of the page.
Kindly assign me this task.

Hello!
I'd be glad to contribute to this project.
Please give me this task as part of the GSSOC '23.

I would like to work on this issue under GSSOC'23.
We can change the navbar css (design) and enhance the user experience.
please assign me this issue

Assign me!


Ignore any pyproject.toml without a [tool.ruff] section

Resolves #1223.

Need to add a "test" to the sample project in ./resources/test/project.


Live Reload for Angular Frontend (configuration.entry['main'] should not contain the item '[...]sockjs-node' twice)

Hi, I've created an Angular frontend, if I run:
npm run serve:single-spa:example
This script uses:
--live-reload false
Instead If I set:
--live-reload true
I get this error:
An unhandled exception occurred: Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.
 - configuration.entry['main'] should not contain the item 'C:\Workspace\example\project-example\node_modules\webpack-dev-server\client\index.js?http://<IP_ADDRESS>:0&sockPath=/sockjs-node' twice.
   -> A non-empty array of non-empty strings
See "C:\Users\user\AppData\Local\Temp\ng-pDaMMT\angular-errors.log" for further details.

Why? I can serve the Angular frontend with "live reload"? Thank you

I transferred this issue to single-spa-angular. I was the one who originally implemented this, but it was maybe 3 years ago so I don't remember the details. My basic understanding of why live-reload is set to false is that Angular CLI's wepback config is very rigid in its assumptions and live reloading maybe changed the webpack entry in such a way that the main.ts exports were lost. I won't have time to look into this myself but welcome others who want to help with it.

Here's a discussion where someone else was facing the same issue:
https://single-spa.slack.com/archives/C8R6U7MT7/p1608216112406100
Slack Join Link

@joeldenning
the slack invitation link is not working anymore. Could you setup a new one?

@joeldenning
the slack invitation link is not working anymore. Could you setup a new one?

Sorry to reopen this, but the slack link doesn't work. I can't see how y'all did to fix the issue.
I am facing the exact same one. No matter how the live reload is set ( true or false).
Here's the stack trace:
An unhandled exception occurred: Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API s
chema.
 - configuration.entry['main'] should not contain the item 'C:\Users\xxxx\seeker-service\node_
modules\@angular-builders\custom-webpack\node_modules\webpack-dev-server\client\index.js?http://<IP_ADDRESS>:0&sockPath=/sockjs-node' twice.
   -> A non-empty array of non-empty strings
See "C:\Users\UTILIS~1\AppData\Local\Temp\ng-aL6xDk\angular-errors.log" for further details.
error Command failed with exit code 127.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I met the same issue when I used "@angular-builders/custom-webpack": "11.1.1", with details:
An unhandled exception occurred: Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.

configuration.entry['main'] should not contain the item 'D:\doan\category\node_modules\webpack-dev-server\client\index.js?http://<IP_ADDRESS>:0&sockPath=/sockjs-node' twice.
-> A non-empty array of non-empty strings
See "C:\Users\Admin\AppData\Local\Temp\ng-SYb74g\angular-errors.log" for further details.

I change from"@angular-builders/custom-webpack": "11.1.1"  to "@angular-builders/custom-webpack": "10.0.1" it work but in the console throw a lot error about webpack-dev-server.

Could you give me a solution? @joeldenning

@joeldenning , @filoxo,
We're sorry to bother. The issue prevents us from moving on. Would you mind giving us a clue?

@joeldenning , @filoxo,
We're sorry to bother. The issue prevents us from moving on. Would you mind giving us a clue?

I fixed it by add  "--live-reload false" to the start script
"scripts": {
"ng": "ng",
"start": "ng serve --port 4201 --live-reload false",
"build": "ng build",
"test": "ng test",
"lint": "ng lint",
"e2e": "ng e2e",
"build:single-spa:category": "ng build category --prod --deploy-url http://localhost:4200/",
"serve:single-spa:category": "ng s --project category --disable-host-check --port 4200 --deploy-url http://localhost:4200/ --live-reload false"
},

Thanks, @Sotatek-KhoaPham , I'm going to try that. Did not add it to the start  srcipt.

Add this to extra-webpack.config.js to fix for now:
  // temp fix for
  // An unhandled exception occurred: Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.
 // - configuration.entry['main'] should not contain the item '\node_modules\webpack-dev-server\client\index.js?http://<IP_ADDRESS>:0&sockPath=/sockjs-node' twice.
 let removeDup = {};
 singleSpaWebpackConfig.entry.main = singleSpaWebpackConfig.entry.main.filter((item) => {
  if(!removeDup[item]) {
    removeDup[item] = true;
    return true;
  }
  return false;
 });

I am facing similar issue after I upgraded my micro-apps to angular v12. Please provide a permanent fix so that I can release my angular upgrade to production environment.

@cjosue15 I think your code is ok, do you have a stackblitz or repo to reproduce that?

Hello, sorry for the late resply, this is my github repo, please if you have any question, let me know.

@cjosue15 I think your code is ok, do you have a stackblitz or repo to reproduce that?

Hello @tscislo , sorry for the late resply, this is my github repo, please if you have any question, let me know.

@cjosue15 I cannot see modifications in your webpack config: https://github.com/cjosue15/microfrontend-example/blob/main/todo-list-react/webpack.config.js

@tscislo I think you looked in the worng file. This is the correct url: Angular repo
by the way, i commented the new config

This seems to be resolved with the latest published version. I've just checked it with our integration apps that we have, I've run them with live-reload enabled and I didn't encounter any error.


[RJSF] Menu-component portal shift for tooltips and add slider for percent

Signed-off-by: Abhishek-kumar09<EMAIL_ADDRESS>Description

Fix Menu component not showing and clicking on it closes the tooltip
Add slider for the percent fields

This PR fixes #
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

This change is universal, right? Any field of type “percent” will be affected, yes?

Yes, if the label for text-field or the key of the text-field is including the percent as a keyword, it will show the range slider.
But at very few places the label of the textfield is not marked as percent, eg. is:

here the the key/label of the text-field is value and not percentage, that's why the slider is not present.

This change is universal, right?

Yes, The change will be reflected in the extension as well as meshery


Merge appsync-emulator-serverless with serverless-appsync-offline

I was wondering if we should merge this repo and https://github.com/aheissenberger/serverless-appsync-offline
Does this repo make sense as a standalone?
I see a couple of refactoring that would simplify everything.
As a Serverless plugin, you receive in the constructor the Serverless instance which I think would remove all the responsibility from the emulator form parsing the yml and instantiating its own (incomplete and wrongly configured) Serverless instance which by the way adds overhead.
If I am not mistaken, The serverless instance would already come with the service object containing everything the emulator needs.
Right now, things like sls offline start ---stage local --profile foo does not work because the dummy Serverless instance (ServerlessConfig) uses dev for stage by default and I assume the default profile.
Or Did I miss something?
Thanks

Not opposed to this but when we built this library initially the conversations we had (some with aws) included using the code with other platforms than serverless. I still have vague dreams to do this so I would be very open to refactoring to make this lib easier to use with serverless as a plugin but I am less supportive of a future where this only works with serverless. I would like to move in the opposite  direction where we can integrate with other platforms such as the new amplify tooling/plugins.

@lightsofapollo I get your point; and I agree.
In that case we should move in a direction where createServer receives normalized object containing all the info needed: schema, datasources, templates.
Then anything using the emulator your be responsible of normalizing the input and pass it to the emulator.
In this case, the appsync-offline plugin would extract the info from the serverless instance, normalize it, and inject it into the emulator.

@bboure I love that approach!


Created an installer

I didn't included all the useless stuff, this time.
Also, The installer is created to make a more "user friendly" installation than a command...

This still embeds a copy of rustup and a compiled python script.
Git is not supposed to be used for this.
Personally, I will never accept a PR that adds a script to install dependencies like this. The user should be able to install Rust themselves. If they need their hand held, they surely won't be able to understand and modify the code.


How to get amount of notes in song

Describe your problem here.
How do I get the total amount of notes (unloaded or not) in a song of any or a certain type?
I.E. something like
getProperty('UnspawnNoteAmount')
or what ever
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
Yes, Some Minor Playstate and discord stuff, mostly the playstate, it being adding a FlxTrail event

Leaving this comment to come back here on my computer.

getProperty('unspawnNotes.length')


Replace url parameter in the app.start

Description
Replacing url parameter for host parameter in the start method.
This PR fixes #613

Hey @carlosm27 👋 No changes are showing up in the diff. Is this expected?? 😅

This looks great @carlosm27 😄 Good job! Can you please add some documentation regarding it too

Yes, no problem

Hey @carlosm27 👋
Can you please update the docs in the new_docs/documentation folder as well??

Hey @carlosm27 👋
Can you please update the docs in the new_docs/documentation folder as well??

Absolutely

Hey @sansyrox. Do I update only the getting_started page or all the pages where the app.start() appears?

Hey @carlosm27 👋

Hey @sansyrox. Do I update only the getting_started page or all the pages where the app.start() appears?

I think a simple find and replace would work 🤔

Hey @carlosm27 👋
Thank you for your PR 😄 I have suggested some changes as I plan to gradually break compatibility. We will completely remove the URL after 2-3 major releases.

Hey @sansyrox thank you for taking a time and reviewing my PR. I appreciate it.

Hey @carlosm27 👋
Windows tests are failing for some reason. Can you please have a look?

Hey @carlosm27 👋
Windows tests are failing for some reason. Can you please have a look?

Hey @carlosm27. Yes, no problem.

Hey @IdoKendo 👋

Anyway, from previous PRs in the repo, I think breaking changes are acceptable before v1, so not sure it's even worth the trouble. @sansyrox WDYT?

I suppose you are right here. And url/host are positional params too. Will not be a super big breaking change.

Hey @carlosm27 👋
All good now. Can you please update the docs too? We have references to ROBYN_URL in a lot of places. Can you replace it with ROBYN_HOST?

Hey @carlosm27 👋
All good now. Can you please update the docs too? We have references to ROBYN_URL in a lot of places. Can you replace them with ROBYN_HOST?

Hey @sansyrox. Yes, absolutely.

This should also be replaced in robyn --create
this is what it generates using robyn --create
if __name__ == "__main__":
    app.start(url="<IP_ADDRESS>", port=8080)

it should be changed to
if __name__ == "__main__":
    app.start(url="<IP_ADDRESS>", port=8080)

# OR

if __name__ == "__main__":
    app.start(port=8080)


bump to vnext for linting/typing + black update to latest version

Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

/check-enforcer override
Only failing core - ci black check since we bump the version of black in this PR, but this will be merged to fix it shortly after: https://github.com/Azure/azure-sdk-for-python/pull/35171


Feature Request: Smoothly scroll in new lines

Summary of the new feature/enhancement
Some hardware terminals allowed smoothly scrolling in new lines. It should be possible to implement this kind of feature in a software terminal emulator as well.
YouTube demonstration (VT525 smooth scrolling):
https://www.youtube.com/watch?v=Iju_pOQM0a0

This seems like it'll be a dupe of #1066. When that one's fixed, this should be too. Thanks!

I may have been premature in closing this. This is definitely not a dupe of #1066, this is something entirely else.
I'm not sure how possible this is. I guess hypothetically we could render a portion of a line at a time, or just render the frame and then apply some sort of transform on it. Getting the velocity by which to scroll these lines might be hard though - how fast should a new line appear on the screen? What happens if multiple lines are output during the course of a frame?
I'm not saying it's impossible, but it will be hard.

If there were an internal buffer, when there is a pause in output, all the lines could then render in.  But this should be an option to enable, rather than a new default.

FYI: iTerm2 counterpart

Note that in addition to the VT100 DECSCLM mode for switching between smooth and jump scrolling, later terminals also had the DECSSCLS command, which gave you more control over the speed of smooth scrolling.
I don't think the exact speeds matter that much, since the smooth scrolling on a VT100 was originally 6 lines per second (STD 070 gives that value too), while on later terminals the default speed was 9 lines per second. I believe the original value was simply the result of the monitor refresh rate (60Hz) and the number of scan lines in a row (10).

I think this issue actually includes three related but different things:

Scrolling in new lines smoothly, as per the original issue description.
Handling precision touchpad scrolling, which is at the (sub-)pixel instead of line level, as per #1980 which was closed as a duplicate of this.
Animating mouse wheel or PgUp/PgDn etc. scrolling, as per this comment 😉

Description of the new feature/enhancement
I would absolutely die and go to heaven if smooth and precise (i.e. animated and pixel-by-pixel) scrolling were implemented. One of the top reasons I started using Edge Chromium over Chrome was due to the slightly better smooth scrolling implementation.
Being able to easily read text while scrolling smoothly and precisely is a game... changer...! Especially, if you have a free scroll wheel like the MX Master 3 and/or a 120Hz+ monitor.
Proposed technical implementation details (optional)
Implementing something like this is outside of my wheelhouse, but I found some great information on the topic here: pavelfatin.com/scrolling-with-pleasure
I understand that the pure intent of a terminal emulator is to display single lines as quickly and efficiently as possible. But from a UX perspective, smooth/precise scrolling feels sooo good with the right peripherals.
Let me know your thoughts please! 😁

From #8548

Obligatory reference to Pavel Fatin's Scrolling with Pleasure. Scroll smoothing compensates (poorly) for low precision. #8548 was about alleviating low precision by utilizing high precision. Same problem, two different solutions. Ideally there would be a UX issue and two implementation issues, reopening #8548.

Obligatory reference to Pavel Fatin's Scrolling with Pleasure. Scroll smoothing compensates (poorly) for low precision. #8548 was about alleviating low precision by utilizing high precision. Same problem, two different solutions. Ideally there would be a UX issue and two implementation issues, reopening #8548.

https://gyazo.com/75806dcc6eceeb640c733769556b1d2a
Sublime Text + Terminus = The best implementation of scrolling in ANY program, let alone a terminal.
Implement this and you've just boosted your UX super far.

Hi, was there any update on the issue?

Nope. We'll make sure to update this thread when there is. In the meantime, might I recommend the Subscribe button?

That way you'll be notified of any updates to this thread, without needlessly pinging everyone on this thread ☺

Notes from around the web:

https://github.com/xtermjs/xterm.js/issues/1140
https://github.com/xtermjs/xterm.js/pull/3616

That PR implements it as a timer that continually scrolls a single line at a time even when the accumulated scroll delta is bigger than that, so the scrolling doesn't happen all at once.
I was more picturing this as a viewport that accepted a floating-point offset, so that we could have a fractional amount of lines at a time. Like, for precision trackpads where you might not always have 100% of a row scrolled.

@zadjii-msft As I understand it, the xtermjs issues you linked are regarding mouse-wheel scrolling of the scrollback buffer. This feature request was for smooth scrolling of the terminal output. The simplest case being when you output a line feed at the bottom of the screen, it should smoothly scroll the new line into view.
The complication is that you generally need to be able to render more lines than you actually have in the buffer. For example, if you have a 30 line screen, and you're going to scroll up a line, you'd typically just erase the top line, move everything up by one, and then insert your new content on the bottom line. With smooth scrolling, though, the top line is sliding out of view at the same time as the new bottom line is sliding into view, so you actually need to be rendering 31 lines at the same time.
This is probably not a big deal if you're doing a full screen scroll and you have a scrollback buffer. But it ideally needs to work with margin-based scrolling too, and that becomes trickier. If it's not practical, though, we could probably get away with just letting the top line disappear in those cases. It should still a produce a reasonably nice effect I think.

That's an excellent point! I think letting partially visible lines simply disappear would look a bit weird. Another pragmatic solution would be to just disable smooth scrolling when margins are set.
Since most of the time you're not using them it should satisfy most use cases.
With AtlasEngine drawing smoothly scrolling content that covers the entire viewport is sufficiently easy thankfully. It already has a "viewport" parameter in pixel, whose Y and W (top and bottom) parameters need to be offset by the scroll position modulo terminal cell height (both in pixels). This would automatically shift the contents around. Alternatively we could add another float parameter between 0 and 1 that is just the floating point scroll position modulo 1.0.

One thing any smooth scrolling feature needs to account for is the rendering backlog. Physical terminals signalled the computer via the RS-232 signals to stop sending characters when its buffer was full. Windowed terminals don't (or can't) do that. A usability improvement over the behavior of these older machines would be increasing the speed proportionally to the backlog - so that it never takes more than "x" seconds to reach the end of the buffer.
The approach Reflection uses is the same a couple physical terminals I have used rely on - the last line only scrolls into the screen if there is a rendering backlog and other lines to be rendered after it. If there is no backlog, the line shows on the screen (because, usually, it means the user is typing and they'd like to see what is being written.

adding notes:
https://github.com/microsoft/terminal/assets/18356694/b5eaba75-2580-4dc3-9434-f4ae0a6d37f1
which I got from https://news.ycombinator.com/item?id=38851642, which is about https://flak.tedunangst.com/post/terminal-smooth-scrolling

@zadjii-msft Lmao, I read the same article on Hacker News and came here to say the exact same thing.


activating evaluation edition to genuine licensed edition

Hi,
I tried using your lab and really liked it, now I want to make this a legit lab which means I need to activate the evaluation edition of the endpoints (dc ,wef, win10). otherwise, they will keep shutting down after 60 minutes when the evaluation period ends. (the WEF is already shutting down, but I saw that's a known issue here)
I own an MSDN account that has license keys for every edition but upgrading them to standard editions (not eval) doesn't seem to work, and after googling a bit, it might be impossible to do with the intention of keeping the current configuration as you set (dc and wef are especially important..).
is there any solution for this?
Thanks! :)

@omrirefaeli when you say "upgrading them to standard editions doesn't seem to work", are you attempting to use dism.exe for the upgrade (as outlined here): http://woshub.com/how-to-upgrade-windows-server-2016-evaluation-to-full-version/
To be honest, I rebuild the lab so often that I haven't needed to keep it running past 30 days and haven't tried this before, but it sounds like something I should try to figure out.

long story short, this specific guide you posted did the trick for the windows servers. I was able to change them to the regular standard edition and activate. I was trying to do this on the windows 10 all along and it isn't possible there so it took some time to try it again on the servers haha.
anyways, thank you!


ci: fix dashboard ci down by setup-protoc@v3

This patch fix the version mismatch for setup-protoc that make ci happy.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR fix arduino/setup-protoc@v3 version is mismatch caused by #18710 by set the right version for it.
Wrong action: https://github.com/yihong0618/risingwave/actions/runs/11090307344
Right action by set it to the right version https://github.com/yihong0618/risingwave/actions/runs/11090308904/job/30812486809
Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

This action will not be triggered in ci unless proto files are modified. Please make sure it passes the CI.
Also out release script is using protoc 3.15.8. Please be careful if you want bump it to 23.x

Also out release script is using protoc 3.15.8.

Shall we use 26 instead? According to this:
https://github.com/protocolbuffers/protobuf/blob/436bd7880e458532901c58f4d9d1ea23fa7edd52/src/Makefile.am#L21

Also out release script is using protoc 3.15.8.

Shall we use 26 instead? According to this:
https://github.com/protocolbuffers/protobuf/blob/436bd7880e458532901c58f4d9d1ea23fa7edd52/src/Makefile.am#L21

not exactly, seems we need to set the version to latest
according to this issue: https://github.com/arduino/setup-protoc/issues/99

https://github.com/arduino/setup-protoc/releases/tag/v2.0.0 Start from v2.0.0, setup-protoc only supports new protobuf version schema. That's why it does work with 3.x

Thanks


Port remote configuration option to nginx.

Ports config option and tests to nginx.
depends on the addition to psol first.
still tracking down crash when the remote server is on the same nginx instance as the server fetching the config. (this issue doesn't show up on apache)

the crash mentioned in the first comment was due to worker_processes being set to 1.
I talked to @jeffkaufman offline and am bumping the value to 2 for this test so that the test can be self-contained and not rely on a secondary server.

$RCPORTN added.

LGTM.
Could you squash the commit history and force push?  There are a lot of commits in there that don't need to end up in trunk.
(Don't merge until the PSOL side of the change is in, though.)

ugh, broke it squashing, redoing in a minute

deleting this one, see #925 (same code pre breaking squash)


It is worth noting that the values that can correctly be stored are limited to boolean, string, number, [], and {}.  Essentially, only stuff that can be JSON encoded which means no bigint, Map, Set, etc..  I wonder if it is worth creating a type for this that is more specific, and possibly a similar helper function for browserStorageLocalSet, that is type constrained?

          It is worth noting that the values that can correctly be stored are limited to `boolean, string, number, [], and {}`.  Essentially, only stuff that can be JSON encoded which means no `bigint, Map, Set, etc.`.  I wonder if it is worth creating a type for this that is more specific, and possibly a similar helper function for `browserStorageLocalSet`, that is type constrained?

type JsonPrimitive = string | number | boolean
type JsonType = JsonPrimitive | Array<JsonPrimitive> | Record<string, JsonPrimitive>

Alternatively, we could perhaps override the types for browser.storage.local.get and browser.storage.local.set so we don't need the helper functions?  You'll have to lookup how to do type overrides (and if it is possible in this context), I always forget how to do it.
Originally posted by @MicahZoltu in https://github.com/DarkFlorist/TheInterceptor/pull/256#discussion_r1148317217

done


Phasor causes issues, cloned repo

Hi,
I tried Phasor-Demo.html and got the following problems
GET http://localhost:8080/succ_data.bytes 404 (Not Found)
xhrLoad @ phaser.js:57692
loadFile @ phaser.js:57660
beginLoad @ phaser.js:57317
start @ phaser.js:57293
preUpdate @ phaser.js:18624
updateLogic @ phaser.js:26735
update @ phaser.js:26684
updateRAF @ phaser.js:46614
_onLoop @ phaser.js:46598
CreatureMeshBone.js:2994 Uncaught TypeError: Cannot read property 'pointsArray' of null
    at Creature.LoadFromDataFlat (CreatureMeshBone.js:2994)
    at new Creature (CreatureMeshBone.js:2762)
    at Object.create (Phasor-Demo.html:67)
    at Phaser.StateManager.loadComplete (phaser.js:18858)
    at Phaser.SignalBinding.execute (phaser.js:19555)
    at Phaser.Signal.dispatch (phaser.js:19378)
    at Phaser.Loader.nextFile (phaser.js:58096)
    at Phaser.Loader.fileComplete (phaser.js:57896)
    at XMLHttpRequest._xhr.onload (phaser.js:57685)
Creature.LoadFromDataFlat @ CreatureMeshBone.js:2994
Creature @ CreatureMeshBone.js:2762
create @ Phasor-Demo.html:67
loadComplete @ phaser.js:18858
execute @ phaser.js:19555
dispatch @ phaser.js:19378
nextFile @ phaser.js:58096
fileComplete @ phaser.js:57896
_xhr.onload @ phaser.js:57685
debug3Export_character_img.png:1 GET http://localhost:8080/debug3Export_character_img.png 404 (Not Found)

Phasor-Pack-Demo.html does work, what is the difference.

Hello,
Please resync/update. I just checked in a change that points the Phaser Demo to point to an available/existing character animation asset on the repository.
Thanks


DatePicker (localized) does not work correctly for years before 1980

[x ] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
If I choose a date, this date should correctly displayed
Current Behavior
For the year 1979 and longer ago, the localized version interpretes the months wrongly, e.g. July will be August, August will be September and so on. Sorry, it is difficult to explain for me in english, but luckily easy to reproduce ;-)
Steps to Reproduce (for bugs)
You can reproduce the bug here:  http://www.material-ui.com/#/components/date-picker. Use the localized example (I tried the french version), as this bug only appears in the localized version
Try to set the datepicker to the "19 July in 1968", the date in the output-field will show "19 August in 1968"
This could be helpful for bugfixing:
If you click on the arrows for the months, You will see, that the month "march" ("mars") appears two times, only after the second click the next month is shown

Same issue here, but using locale = 'es-ES'

Hi Natalie,
thanks for your response!
I thought also about the 1970 Unix thing, but the bug also in the year 1979 and longer ago, but not in 1980 and "younger".

In locale =‘es-ES’ there are no problems between 1980 and 1970, that’s why I said the UNIX thing... also not seeing it in Material UI official API for DatePicker on locale=‘fr’, only beyond 1969... but maybe it’s something related to our own configurations on each machine 🤷♀

The date picker is a challenging component to implement. The complexity comes from different sources: date manipulation and correctness, internationalization, keyboard/touch/mouse interactions, customization capabilities. We haven't been porting it to the v1-beta branch yet, nor it's a priority. But we are documenting alternatives. Here are some components that are promising:

material-ui-pickers
material-ui-time-picker

I'm closing for #4787.


Downgrade OldJsonPlugin to be older than JsonPlugin

Summary
The intent of OldJsonPlugin is to demonstrate that this plugin architecture can handle multiple dependencies of differing versions, but dependabot in its wisdom bumped both to the same version, making this example useless.
Obsoletes #4472

Thanks for making this update @SinZ163
Before we merge this (and forget what happened), can you add an update to the .github/dependabot.yml file so this doesn't get updated.  You can add a versions element like here to the entry for the OldJsonPlugin here to prevent dependabot from updating that plugin.
Thanks again!

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: SinZ163 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@BillWagner Done.
Thanks for the pointers, was wondering how to configure dependabot to prevent this happening again.

this PR fixed issue #4307


[Enhancement] Automatically run a min distribution build when a version increment is merged into OpenSearch core

Is your feature request related to a problem? Please describe
The CI checks in the security repo require that the min distribution of core is available on Linux and Ubuntu distros for the respective version. When security received auto-cut version increment PRs, they will always fail until a min distribution of core is available.
Oftentimes, someone will mention the EE team to ask for a build to be triggered to produce the artifacts. Can there be automation put into place to automatically create a min distro when a version increment is merged into OpenSearch core?
Describe the solution you'd like
Add automation to kick off a min distribution build after a version increment is merged into OpenSearch core.
Describe alternatives you've considered
Ping EE team on Github or Slack
Additional context
No response

[Triage] Right now, when OpenSearch core increments its version, we have a daily workflow to raise the PR for respective version manifest (e.g. https://github.com/opensearch-project/opensearch-build/pull/4113) and add it to our CI Jenkins.
Once this PR is approved and all checks pass, I remember this new workflow will help merge it and our distribution build Jenkins job will start to generate OpenSearch core.
I think the problem is that the version increment PR is cut before the above process so the check fails because the core is not built yet.
We have a discussion talking about the approach to re-run the CI checks for auto-cut version increment PR for plugins. https://github.com/opensearch-project/opensearch-build/issues/2706, but for now we would need you to re-run the CI checks when the core is built.


python demo_mnn.py  initMNN: init numpy failed

Traceback (most recent call last):
File "demo_mnn.py", line 406, in
class NanoDetMNN(NanoDetABC):
File "demo_mnn.py", line 407, in NanoDetMNN
import MNN as MNNlib
File "C:\5tools\anaconda3\envs\pytorch\lib\site-packages\MNN_init_.py", line 8, in
from _mnncengine import *
Exception: initMNN: init numpy failed

Have you installed numpy?

I got same error. I solved it by upgrading numpy to 1.20.x

Got the same issue with MMN==1.1.4, pip install MNN==1.1.0 solved the problem

I got the same error as MNN==1.1.4, either numpy== 1.19.5 or 1.16.x,
when i reinstall numpy==1.20, the error was gone.


Tooltip panel has grey background behind corners

Godot version
4.0.3-stable
System information
Arch linux, i3 wm
Issue description
I'm experiencing a 'bug' with tooltips. The moment you round the corners, you can see some grey box behind the tooltip. I don't think this is intended to be there, but correct me if I am wrong or if I'm doing something wrong here.

Steps to reproduce
Use a custom theme, change the panel property of the tooltip and add rounded corners.
Minimal reproduction project
tooltip_bug.zip

Does not require a project.

That would actually be very helpful to make sure we can test the right scenario and reproduce the issue.

Does not require a project.

That would actually be very helpful to make sure we can test the right scenario and reproduce the issue.

I've added a test project, but it is basically what the reproduction steps say. I've been trying to figure out why this happens but I can't quite find why it does that.
Maybe it inherits from window, like popup does, and it does not make the window itself transparent? if that is the case it would be an easy fix, but I don't have much time to actually check it out. I may give it a try tomorrow morning to see if that would fix it

Thanks for the report! Consolidating with https://github.com/godotengine/godot/issues/78823.