Uds support

Closes #3092

Also it looks like test failed in CI

Also it looks like test failed in CI

Yep, that's why I'm setting up a Linux machine right now, because I can't reproduce the failing tests on Mac.

UDS can be enabled with
new PrismaClient({ __internal: { useUds: true } })

I tried it out and looks like it is working well :100:


Backport python-jinja2 2.7.3  for RH 6

Need for jinja2 v2.3 on RH 6 but if doing the update, use v2.7.2 from RH 7.
Needed for next point release

Simple backport fails due to python 2.7 incompatibilities with Redhat 6 python 2.6, it shall take longer

using build from copr, backport of jinja2 2.7.3 to RH 6

Out to test


Stopped working

It used to work for me, now it freezes File Manager, and I have to close it to be able to navigate.
I can see one level of directory on mounted volume, but trying to open any lower folder and I get: Some operations are getting longer... abort then I cannot use File Manager until I restart it.
Please fix this :(

@nabilh2020 Unfortunately, I cannot start to fix your issue because your comment didn't include information to find the reason. Could you post the debug log here which the you face the issue by the following steps: https://github.com/yoichiro/chromeos-filesystem-cifs/wiki/How-to-Capture-the-Console-Log-of-DevTools

@nabilh2020 I close this issue because you did not provide any information to fix this issue. You can repoen this issue when you can get the logs and other valuable information. Thank you for the reporting.


Improvements

Problem

SMTP connexion fails because localhost is not on the TLS certificate.
Users can only connect using username, login form says "Username of email".

Solution

Use the main domain instead of localhost.

Search users in LDAP using mail and username. This doesn't work when a user have multiple mail (see https://github.com/wekan/ldap/issues/57).

Fix linter

Use $YNH_ARCH instead of ynh_detect_arch

PR Status

[x] Code finished and ready to be reviewed/tested
[x] The fix/enhancement were manually tested (if applicable)

Automatic tests

!testme


refactor: use tweetnacl directly

Follows Deno Deploy example at https://deno.com/deploy/docs/tutorial-discord-slash
Uses official tweetnacl instead.

Thanks, i wrote this code back when deno was still being introduced so not much was known about best practices. Will merge looks good. 😊


Improve style of components in different themes

Why
In this Figma page in the "Final" section you can find design improvements for the components.
TODOS
Adjust component style for React and WebJS

[x] Change sub-headline to regular font weight
[x] Align the top error text+icon to the input field and button by adding the same vertical padding as for the rest of the component and resize the warning icon to 20x16px. (See Figma design)
Ensure that the top error styling follows the rule for every error message of every length
[x] When opening the signup screen, set the cursor automatically to the uppest input field (same as for login)
[x] Adjust the style of the Email OTP without Email shortcut and Phone OTP according to the Figma.
[x] Adjust background of OTP input fields when full code is entered. (To discuss with adam) Figma

Light mode

[x] Change the input field border color to #D4D4D4
[x] Change the hover color of the button to #1953FF + opacity of 0.75
[x] Change the "or" separation text and line color to #000000 + opacity 0.75
[x] Change the disabled color to #DFDFE0
[x] Change the Icon color of email and phone and user (passkey error screen) to black.

Dark mode

[x] Change the input field border color to #848CA6
[x] Change text color to #A1A1A1 (except Title and subitle)
[x] Change the hover color of the button to #1953FF + opacity of 0.5
[x] Change the "or" separation text and line color to #ffffff + opacity 0.75
[x] Change the disabled color to #6F7486
[x] Change the Icon color of email and phone and user (passkey error screen) to white.
[x] Adjust the Top Error background color to #5B5B6B

Developer panel

[ ] Adjust hover color for email shortcuts according to Figma. (Color #525D83)

Update

[ ] "Space Grotesk" font-weight issue in react
[ ] Button disabled color is not as shown in Figma (Lightmode #DFDFE0 Darkmode #6F7486)
[ ] Change top error text color in light mode to color #4D5562
[ ] In dark mode, primary (or secondary) color on every other screen is grey instead of white
[ ] Make "or" separation less heavy (clarify with Adam)

Update

[ ] In darkmode keep the color of the main text and the icons of all the other screens white (screenshot 1, if you need clarification ask adam)
[ ] In white mode change the hover color of the social buttons and email shortcut button to RGB(245, 245, 245, 100)
[ ] If no much time required, in darkmode change the country code color to white and in the dropdown change text and country code also to white

[ ] In darkmode change the text of the identifier to fully white instead of grey. (It's not a problem if the identifier text in the passkey-append screen is also white)


Coroutine for Swift

Coroutine can be used for generate a list of values without creating a array. And it's a useful mechanism for lazy evaluation.

Hi @SusanDoggie, per our swift-evolution guidelines, please start a thread discussing this on the swift-evolution mailing list before sending a pull request.  This suggestion has already come up, and has been deferred due to its close inter-relation with concurrency support, which is out of scope for Swift 3.


Migrate from Rollup to TSC

This allows inspecting sources when consuming the package, and the build is significantly faster.
I still need to test to see if the generated NPM package works. Putting this PR up for tracking purposes.
Other notes:

the compiled tests seem to be included in the final build, since tests are covered by the current tsconfig.json. This should not affect bundle size but build times (which are really fast) can be reduced by using a different tsconfig for tests
I removed the baseUrl from tsconfig.json so we don't have to hardcode a path to node_modules for any package

@macalinao I updated the checksize scripts to the new build locations. Interestingly it added 2 bytes to the gzipped core bundle but reduced 77 bytes from the gzipped react bundle.

@macalinao I updated the checksize scripts to the new build locations. Interestingly it added 2 bytes to the gzipped core bundle but reduced 77 bytes from the gzipped react bundle.

Nice. We should be able to reduce size further by using tslib, which I think we should implement in a later PR

Is it working in your codebases? In Next.js it seems like it's resolving the root package but not the subfolders like /persist. Are you seeing that too?

Is it working in your codebases? In Next.js it seems like it's resolving the root package but not the subfolders like /persist. Are you seeing that too?

I only tested @legendapp/state/react-- will look into subfolders
did you clear the Next.js cache? And are you using the root package.json as the linked package, rather than the one in dist/?

I only tested @legendapp/state/react-- will look into subfolders

I'm seeing the error on the /react path too.

did you clear the Next.js cache? And are you using the root package.json as the linked package, rather than the one in dist/?

I did an rm -rf .next before running the Next project which afaik clears the cache, or is there a better way to clear the cache? I emptied the node_modules/@legendapp/state folder and copied the whole package folder into there.

Also what Node version are you testing on? I am on Node 18

I'm using Next.js v13.2.4 and I tried on Node 16 and 18. Both of them have issues with loading .ts files, I think because the file named "react" is react.ts so it's trying to load that?

I only tested @legendapp/state/react-- will look into subfolders

I'm seeing the error on the /react path too.

did you clear the Next.js cache? And are you using the root package.json as the linked package, rather than the one in dist/?

I did an rm -rf .next before running the Next project which afaik clears the cache, or is there a better way to clear the cache? I emptied the node_modules/@legendapp/state folder and copied the whole package folder into there.

Also what Node version are you testing on? I am on Node 18

I'm using Next.js v13.2.4 and I tried on Node 16 and 18. Both of them have issues with loading .ts files, I think because the file named "react" is react.ts so it's trying to load that?

Hmm I was having a similar error where Parcel was trying to compile the source but it disappeared after clearing the cache
The .next/ thing should theoretically work. Did you also make sure the package was built? And cleared dist/?  And maybe deleted node_modules? (I am using PNP so I don't have a node_modules directory)
I'll try running my code again-- maybe I missed something

Just tested it again (this time published to NPM as @simplyianm/legend-state) -- react import works but I found an issue with the wildcard imports, which I'll push a fix for shortly

Hmm, I changed the page to return null and just do this:
import { observable } from '@simplyianm/legend-state';
import { useComputed } from '@simplyianm/legend-state/react';

const o = observable({ test: 'helloz' });
console.log(o.peek());
console.log(useComputed);

export default (function Clients() {
    return null;
});

And it fails with the same error.

I think having uncompiled .ts files in the root is problematic? I believe some environments don't respect exports in package.json and just use the file structure? I'm not sure what could be the difference between our projects?

Another platform that still has issues with exports is repack. I have to fallback to cjs everytime

Hmm not sure what happened with my Next.js setup-- I can take a look when I have time, though it seems I can't get the wildcard exports working on my setups with Parcel and Next.js. I think there are a few solutions here:

We can split the package into subpackages compiled with TSC, e.g. @legendapp/state and @legendapp/state-react, then create a legacy package bundled with Rollup which references the subpackages
We can force any package consumers to change their imports, which would require a major bump

Might be more trouble than it's worth-- since the original issue was around not being able to see sources with the existing package setup, I might try tackling that individually.

Hmm not sure what happened with my Next.js setup, but I can take a look again.
To resolve the sources issue, maybe I should try moving all sources into the src/ directory and seeing if it causes the bundlers to not resolve the TypeScript source files as the main file. Will experiment with this

I think the exports will break on any package consumers not using Node's new module resolution-- will see if there is a way to fix this at least for Next.js

In the latest v3 alpha I migrated from rollup to tsup which is significantly faster and should be more correct. So since this PR is now very out of date I’m going to close it. But please let me know if you want to pick up the concept again on the latest version.


How to make the tabs move up along with the content when scrolling?

Good morning I need the scroll to move along with the content, that is to say when under the scroll the tabs must go up as if of a content it was and when lower the scroll this returns to its normality

+1

@izamorar
Did you get any solution for this?

@ihadeed Please can you help with any CSS or JS hack to achieve this, I'm trying to implement the instagram like tab with this supertabs, but the content of each tab keep scrolling beneath the SuperTabs. Please help in any way you can i'm stucked. Thank you


How to create XLA compiled model from a TF Saved Model

Issue type
Others
Have you reproduced the bug with TensorFlow Nightly?
No
Source
source
TensorFlow version
TF 2.11
Custom code
No
OS platform and distribution
No response
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
NONE
Standalone code to reproduce the issue
I have a TF Saved Model which I want to convert to a CUDA Graph. I see that there is initial implmentation of CUDA Graphs in XLA here - https://github.com/tensorflow/tensorflow/commit/563c2ab50c43d16149ccfa143c8f97ebdb800a7e

How can I use XLA to convert a TF Saved Model to a CUDA Graph?

Relevant log output
No response

@sushreebarsa Can you help with above query? I want to see how I can use XLA with TF to enable CUDA Graphs

@ndeep27 There isn't a direct way to create an XLA compiled model from a TensorFlow SavedModel in TensorFlow 2.  Please refer to this official documentation. Could you try to consider converting your SavedModel to a TFLite model. TFLite utilizes its own interpreter and optimizations, potentially achieving similar performance benefits on mobile and embedded devices.
Thank you!


[MXNET-117] Sparse operator broadcast_mul/div(csr, dense) = csr

Description
Add a sparse operator on CPU that supports broadcast_mul/div(csr, dense) = csr operations.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [MXNET-117]
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[x] Add support for broadcast_mul/div(csr, 1Ddense) = csr
[x] Add support for broadcast_mul/div(csr, 2Ddense) = csr
[x] Add test for broadcast_mul/div(csr, 1Ddense) = csr
[x] Add test for broadcast_mul/div(csr, 2Ddense) = csr

Comments
Duplicate PR with #10150, getting a new PR due to renaming of my branch
Example for broadcast_mul/div(csr, 1Ddense) = csr
import mxnet as mx
a = mx.nd.array([[0,0,3],[0,2,0],[1,0,0]]).tostype('csr')
b = mx.nd.array([1,2,3])
mx.nd.broadcast_mul(a,b).asnumpy()
array([[ 0.,  0.,  3.],
[ 0.,  4.,  0.],
[ 3.,  0.,  0.]], dtype=float32)

@marcoabreu the pylint result failed on lines not added by this PR. Is there anything not tested on CI?

@eric-haibin-lin the pylint check passed in http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/PR-10208/7/pipeline. There was a short time between upgrading the instances and merging my PR to reflect the necessary changes (pylint fixes included) in which pylint failures could have been possible. It should be resolved now.

@sergeykolychev Hi, my PR is failing some tests because I've changed some interface in Python but I'm not familiar with Perl so I'm not able to make the same changes in Perl. I wonder if you could please give some help on how to make corresponding changes in Perl so that my builds could pass? Thanks!

@haojin2 Hi Hao, certainly, when you need this by the latest ? I'm on vacation right now but if it's pressing I can look at it sooner.

@sergeykolychev Probably by the end of this month would be a hard deadline for me, since it would be good check this in for the next release. I guess all what we need are some minor changes to the interface similar to my changes to sparse.py in this PR on the Perl side, so I think any help at your earliest convenience is appreciated, thanks for your response and enjoy your vacation!

@haojin2 ok, I'll fix this problem for you until end of Thursday this week.
Don't worry and continue your development, I'll take about the perl side.

Sure, please take your time! Thanks a lot for your help!

@haojin2 https://github.com/haojin2/incubator-mxnet/pull/1 this fixes the perl tests. Thanks.

@sergeykolychev Thank you very much!

Update on 4/8:
A small benchmark for this operator is added to compare the new implementation with the fallback implementation
import mxnet as mx
import scipy
import numpy as np
import time

def measure_cost(repeat, f, *args, **kwargs):
    # start bench
    start = time.time()
    results = []
    for i in range(repeat):
        results.append(f(*args, **kwargs))
    for result in results:
        result.wait_to_read()
    end = time.time()
    diff = end - start
    return diff / repeat

def main():
    shape_lhs = (256, 1000000)
    vec = np.random.uniform(size=(256, 1))
    mx_vec = mx.nd.array(vec)
    for density in [0.01, 0.005, 0.001]:
        csr = scipy.sparse.random(256, 1000000, density=density, format = 'csr', dtype=np.float32)
        mx_csr = mx.nd.sparse.csr_matrix((csr.data, csr.indices, csr.indptr), shape=shape_lhs, ctx=mx.cpu())
        mx_dns = mx_csr.tostype('default')
        sparse_cost = 0.0
        dns_cost = 0.0
        for i in range(10):
            sparse_cost += measure_cost(100, mx.nd.broadcast_mul, mx_csr, mx_vec)
            dns_cost += measure_cost(100, mx.nd.broadcast_mul, mx_dns, mx_vec)
        print("%.2f %%" % (density*100), dns_cost / sparse_cost)

if __name__ == "__main__":
    main()

Results: (density speedup)
(1.00%  9.453656599452351)
(0.50% 18.406541290116778)
(0.10%  53.18159853487238)


Internationalization (i18n)

This should be baked into core, every string, everywhere.
Library tbd, will post suggestions.
http://meteorpedia.com/read/i18n

Powerful: https://atmospherejs.com/gadicohen/messageformat (my vote)
Simple/Old school: https://atmospherejs.com/tap/i18n/

about messageFormat:
Note: Each translation string must have a unique key. In the above example, trans_string is the key.

Wow, that's incredibly annoying.
The other package, i18n, is also awful imo, because you also need unique keys for everything and have to keep a translation file updated all the time.
Why can't it just use msgfmt.

Yeah, there doesn't seem to be a meteor specific package for gettext.
This looks pretty decent as a general js solution.
https://slexaxton.github.io/Jed/

@thomwiggers why don't you like unique keys? Don't most i18n packages require that?

Everything I've worked with (aka gettext in Django, but also in php) roughly works like this:
Source file:
{{ trans 'This gets translated' }}

nl_NL.po
msgid "This gets translated"
msgstr "Dit wordt vertaald"

So this means you don't need to hassle with keeping things synchronous, and if you don't translate a string it'll just display the original language.
Adding identifiers to strings is supported iirc, but that's mostly to support stuff where there are words that are the same in one language (Dutch: "bank", English: "bank" or "sofa")

In your example, is msgid not the unique key for the message?

Yes, but it's also the English text. I don't see that in these meteor packages.
On 6 August 2015 19:08:53 CEST, Jason<EMAIL_ADDRESS>wrote:

In your example, is msgid not the unique key for the message?

Reply to this email directly or view it on GitHub:
https://github.com/meteor-gazelle/meteor-gazelle/issues/134#issuecomment-128446173

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

I like unique keys, since using the english text is exactly the same, or worse, and will become very apparent when you make a typo or want to change said english text.
When that happens you have two options:

Change the english text used in the templates (essentially the "key"), then go through every .po file and change the text there, and make sure all translators have up to date keys, or...
You leave the template text asis and create a new english .po file to translate the "shitty english" to "good english".

Gettext fixes your problem by allowing for 'fuzzy' translations, where it does a 'close enough' guess. Often you only need to briefly review them and you're done.
Tooling for gettext is also really mature. Stuff like transifex etc..

gettext ftw. Jed seems... overkill, but I think it should work.
Besides the "how do things get translated" bits, we're going to need some infrastructure to generate .po files, make it easy for people to translate things, etc. If the translation process is "create and PR a .po file", nobody will do it.
Not everything here will apply, but OpenStack has a lot of infra here we may be able to crib from:

https://wiki.openstack.org/wiki/Translations
https://wiki.openstack.org/wiki/Translations/Infrastructure

The thing I really like about the way OpenStack does translation, is it makes it ridiculously easy for developers. Just _("wrap your string") and it will get picked up as a translation and pushed into Transifex. Updates to the English form are managed by marking line numbers and whatnot, AIUI. Translators can do their thing directly on Transifex's website, and then a periodic job pulls translations from Transifex and proposes a patch for review.
All of that said, I don't know that this is the best use of our time right now. I would like to figure it out so we can start marking strings or whatever, but the rest of the process might take some time.

I'm in favor of revisiting this issue in the future as it is low priority. We can organize an internalization effort as well to go along side this.


Fix payment table semantics

https://github.com/gratipay/gratipay.com/pull/3414#commitcomment-11203627

I'd really like to fix _check_balances before we retry #3415. I don't have the time to fix it now, but I should be able to within 3-4 hours.

I'm ready to merge if you're okay with 46f047b0bdc3b4aa642a4ae6fc8d1c0f03665527, @rohitpaulk.

To be clear: this wasn't the reason why we have no payments, correct?

This bug is unrelated to that, yes?

this wasn't the reason why we have no payments, correct?
This bug is unrelated to that, yes?

Yes, and yes. :)

k :)


H200 support

Is there any plan to support H200 hub?

What functionality are you looking for?
I believe that there's a high chance that the one that exists for H100 will work for H200 too. Have you tried it?

No I didn’t try it, I have to buy it that’s why I am asking. Thanks
Il 16 dic 2023, 21:16 +0100, Mihai Dinculescu @.***>, ha scritto:

What functionality are you looking for?
I believe that there's a high chance that the one that exists for H100 will work for H200 too. Have you tried it?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

If you end up giving it a try, please let us know how it goes!

Hello,
I just testing H200 and looks it not working:
cargo run --example tapo_h100     Finished dev [unoptimized + debuginfo] target(s) in 0.13s      Running target/debug/examples/tapo_h100Error: Http(Error { kind: Timeout, context: None, source: Some(Error { description: "Timeout was reached", code: 28, extra: None }), source_type: Some("curl::error::Error"), local_addr: None, remote_addr: None })
When I triedL530 it works.

Hmm, a timeout error is not what I was expecting.
Can I double-check that you've pulled the correct IP address from the Tapo app?
Also, can you please post the logs you get from RUST_LOG=debug cargo run --example tapo_h100?

Sure
My IP is right, because I have static IP for HUB
Linux:

Tapo mobile APP:

Linux ping:

Interesting.
As a test, could you please replace the contents of the is_passthrough_supported function with Ok(false) and then see what RUST_LOG=debug cargo run --example tapo_h100 outputs?

It looks same:

idk...

I just tried IP in browser. When I try L530 I will get 200 OK but when I try HUB 200 I will get time out...

Hmm, I get timeouts with H100 when I try to access it from a different network adapter (H100 on Wifi and a PC on LAN).
Is it the same case for you?

Ok, HUB 200 is probably using port 443 (HTTPS), when I try it in browser I will get: {}

Hmm, I get timeouts with H100 when I try to access it from a different network adapter (H100 on Wifi and a PC on LAN). Is it the same case for you?

I dont have H100

I was wondering if you have the same setup as me, with the hub on wifi and a PC/laptop on LAN (or a different Wifi) trying to call it.

If you want to try it over HTTPS, you can change the URL at https://github.com/mihai-dinculescu/tapo/blob/a87a062e8293f11966dcc78ffbe86bf830eb605c/tapo/src/api/api_client.rs#L632

If you want to try it over HTTPS, you can change the URL at
https://github.com/mihai-dinculescu/tapo/blob/a87a062e8293f11966dcc78ffbe86bf830eb605c/tapo/src/api/api_client.rs#L632

Problem with SSL:
Error: Http(Error { kind: BadServerCertificate, context: None, source: Some(Error { description: "SSL peer certificate or SSH remote key was not OK", code: 60, extra: None }), source_type: Some("curl::error::Error"), local_addr: Some(<IP_ADDRESS>:41144), remote_addr: Some(<IP_ADDRESS>:443) })

I was wondering if you have the same setup as me, with the hub on wifi and a PC/laptop on LAN (or a different Wifi) trying to call it.

I have:
router -> switch -> server, hub 200, PC, Access point
I am on PC and try it with PUTTY from server.
Hub is connected with LAN

I found this:
https://github.com/petretiandrea/home-assistant-tapo-p100/issues/578
They have same problem

Argh, I was afraid of this. This library also supports only the legacy protocol and the newer Klap one.
It might be worth doing one last hurrah and disable the SSL verification by replacing https://github.com/mihai-dinculescu/tapo/blob/main/tapo/src/api/api_client.rs#L68 with
        let client = HttpClient::builder()
            .title_case_headers(true)
            .ssl_options(isahc::config::SslOption::DANGER_ACCEPT_INVALID_CERTS)
            .build()?;

But I wouldn't hold my breath.
I'm considering purchasing a camera in the next weeks/months and that will give me an opportunity to look into the third protocol.

Ok,
I tested with ssl_option and same problem:

Argh, I was afraid of this. This library also supports only the legacy protocol and the newer Klap one.
It might be worth doing one last hurrah and disable the SSL verification by replacing main/tapo/src/api/api_client.rs#L68 with
        let client = HttpClient::builder()
            .title_case_headers(true)
            .ssl_options(isahc::config::SslOption::DANGER_ACCEPT_INVALID_CERTS)
            .build()?;

But I wouldn't hold my breath.
I'm considering purchasing a camera and/or H200 to look into the third protocol in the following weeks/months.

Hey, I am currently having the same issue. Is there any implementation of the Tapo Camera protocol or documentation of it? I'm having a really hard time reversing it.
I have some network logs and it seems to encrypt communication pretty swiftly on the latest version. According to the Tapo it seems to use AES-256-CBC-PKCS#7.

Having a look at the decompiled tapo app would be my first port of call.
Also, this library might might be a useful source of inspiration.

It uses a different protocol, like the one used by Tapo Camera

It uses a different protocol, like the one used by Tapo Camera

Yes, however it seems to have changed protocols again in a newer firmware version. In this issue someone seems to have gotten it working, however an authentication packet on the latest firmware looks like this:
{
    "method": "login",
    "params": {
        "cnonce": "9AAF7F6F13190C8F",
        "digest_passwd": "5BBC5A0C5B08876DA6F08A0380AC60ECE55EE135FB8610010E580BEF0A2C37FD9AAF7F6F13190C8F080693488D027476",
        "encrypt_type": "3",
        "username": "admin"
    }
}

Whereas authentication previously looked like this:
"method": "login",
            "params": {
                "hashed": True,
                "password": self.hashedPassword,
                "username": self.user,
            },

If anyone knows how to reset it to the previous authentication mechanism please let me know, i tried resetting the hub and using another fresh account already but the encryption persists for all requests.


netty: how to limit size of tcp packets (request for info) (netty 4.1.30)

@normanmaurer This is not an issue, but need to figure out how to limit the size of tcp packets written by websocket servers using netty.
We are running a websocket server built on top of vert.x (3.6.2) which uses netty (4.1.30) using the native epoll transport enabled.
During periods of heavy traffic, looking at the capture, we see the size of tcp packets approaching 64k. The client (chrome browser) is slowing down while processing these large tcp packets (carrying websocket payload of text based json data). We feel, chrome is consuming a lot of time trying to decode and parse these json payloads (multiple json messages packed together).
We want to understand how can we make use of any socket options in netty, to try to limit the size of these packets to a low number (probably 8k) in order to improve the performance of chrome processing these messages. I have already tried using SO_SNDBUF set to 4k, but the tests did not show any difference in the packet size.
Any help is much appreciated.
Expected behavior
Actual behavior
Steps to reproduce
Minimal yet complete reproducer code (or URL to code)
Netty version
4.1.30
JVM version (e.g. java -version)
<IP_ADDRESS>
OS version (e.g. uname -a)
Linux m-ar2vm117 2.6.32-696.30.1.el6.x86_64 #1 SMP Tue May 22 03:28:18 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

@pvub Your question doesn't make sense. IP packets are at most 0-1KB, and slightly larger if you do a ton of configuration.   I think you should ask your question on Stack Overflow instead.

@normanmaurer This is not an issue, but need to figure out how to limit the size of tcp packets written by websocket servers using netty.
We are running a websocket server built on top of vert.x (3.6.2) which uses netty (4.1.30) using the native epoll transport enabled.
During periods of heavy traffic, looking at the capture, we see the size of tcp packets approaching 64k. The client (chrome browser) is slowing down while processing these large tcp packets (carrying websocket payload of text based json data). We feel, chrome is consuming a lot of time trying to decode and parse these json payloads (multiple json messages packed together).
We want to understand how can we make use of any socket options in netty, to try to limit the size of these packets to a low number (probably 8k) in order to improve the performance of chrome processing these messages. I have already tried using SO_SNDBUF set to 4k, but the tests did not show any difference in the packet size.
Any help is much appreciated.
Expected behavior
Actual behavior
Steps to reproduce
Minimal yet complete reproducer code (or URL to code)
Netty version
4.1.30
JVM version (e.g. java -version)
<IP_ADDRESS>
OS version (e.g. uname -a)
Linux m-ar2vm117 2.6.32-696.30.1.el6.x86_64 #1 SMP Tue May 22 03:28:18 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Normally, TCP manages everything itself on your behalf. If you don't see any issue, do not worry much unless you're a Network Engineer.
Coming back to your issue of 64K Packet size. Are you sure you are getting 64K Payloads? How did you check this? Because most Networking Devices support 1500 bytes MTU and anything above will get dropped so TCP adjusts the packet size itself. Assuming you're on LAN then there could be a possibility. Can you just check using Wireshark or any other Packet Capture Tool to confirm Packet Size?

@carl-mastrangelo @hyperxpro We took a capture, and the TCP packets are maxing at 64k, as seen in wireshark. We tried using setSendBufferSize() on the channel options, to 4k to see if it makes any difference, but have seen no change in packet size.
I went through epoll native transport channel code, and found out that SND_BUF size is not being honoured, as it gets re-adjusted when writing to socket.
https://github.com/netty/netty/blame/6c05d16967df5cadcebcc498223eec3f25bacf89/transport/src/main/java/io/netty/channel/socket/nio/NioSocketChannel.java#L413
As you can see adjustMaxBytesPerGatheringWrite() re-defines the max write size based on how much the socket can take.
Even though the intention of adjusting max write size could be to have maximum throughput, in our case we do not want to be sending large packets out to the client, in order to not overwhelm. So there is a need for me to limit the write size to a value we find can give the best responsive experience for the client.
Right now there is no way to avoid the re-adjustment of write size.

@carl-mastrangelo @hyperxpro We took a capture, and the TCP packets are maxing at 64k, as seen in wireshark. We tried using setSendBufferSize() on the channel options, to 4k to see if it makes any difference, but have seen no change in packet size.
I went through epoll native transport channel code, and found out that SND_BUF size is not being honoured, as it gets re-adjusted when writing to socket.
https://github.com/netty/netty/blame/6c05d16967df5cadcebcc498223eec3f25bacf89/transport/src/main/java/io/netty/channel/socket/nio/NioSocketChannel.java#L413
As you can see adjustMaxBytesPerGatheringWrite() re-defines the max write size based on how much the socket can take.
Even though the intention of adjusting max write size could be to have maximum throughput, in our case we do not want to be sending large packets out to the client, in order to not overwhelm. So there is a need for me to limit the write size to a value we find can give the best responsive experience for the client.
Right now there is no way to avoid the re-adjustment of write size.

I see something is not right. Can you share the Wireshark Packet Capture file (.pcap)? And would you mind telling me a bit about your topology like LAN or Cloud.

@hyperxpro We are running this on a LAN. nginx fronting the server for ssl. Attached is a small capture snippet with the large packets.
4k_sendBuffer_bigFrameExample.pcap.zip

I see that you're using Localhost (<IP_ADDRESS>) and 64K Packets are normal for it. Completely fine.

as explained here there is nothing wrong. Also please use stack overflow for questions next time. Closing....


Make forecast.io update interval configurable

Description:
Adds a config parameter (update_interval) to the forecast sensor to set the minimum update interval. Handy if you don't need super-current weather data and want to conserve your API quota. The default remains 120 seconds.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#990
Example entry for configuration.yaml (if applicable):
update_interval: 'HH:MM'

OR
update_interval: 'HH:MM:SS'

OR
update_interval:
  # At least one of these must be specified:
  days: 0
  hours: 0
  minutes: 3
  seconds: 30
  milliseconds: 0

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

I like this, but I'm not sure it's the best approach - if another component want to use this functionality, it'll be a copy pasta job.
It's also scarily close to delay used in scripts, I'm not sure how best to go about moving this implementation up, but it would be nice if we didn't duplicate this functionality.

@lwis I agree and there is even a pivotal story for just that: https://www.pivotaltracker.com/story/show/113041443 . However I don't see that being done anytime soon and this will suffice for now. (also even with that story we would still have to throttle the update calls).
@KlaasH code looks great 🐬


vc1parser: add boundary check for every read bits

fix #527

@yizhouwei , why close it?

@yizhouwei, you just need update you repo, then the pull requst wil remove h265 parser automatically.


average_triage_time into QoS

Add average_triage_time to quality-of-service fact, where it's missing. It should be the average time in seconds between issue-was-opened and bug-was-accepted or enhancement-was-accepted.

@yegor256 Do I understand correctly bug-was-accepted and enhancement-was-accepted this is the addition of labels to issue? And the time of X-was-accepted can be taken from label-was-attached judge?
Can I try this one?

@yegor256 And one more clarification, the average value must be calculated for issues of open from f.since?

@Yegorov you understand it correctly. It's f.when, not f.since.

@yegor256

It's f.when, not f.since.

Why from f.when?  f.when - is now Time

@Yegorov if you mean the QoS fact, then we should use since, but for the issue-was-opened, bug-was-accepted, and enhancement-was-accepted we should use when.


style: pragma once in header file

Commit Message:
Add pragma once almost every header.
Signed-off-by: Yuchen Dai<EMAIL_ADDRESS>Additional Description:
for f in `find include/ source/ test/ -name "*.h"`; do grep "pragma once" $f >/dev/null|| echo $f; done | grep -v test_data |grep -v test/config/integration/certs |grep -v chromium |  xargs sed -i '1s/^/#pragma once\n\n/'

Exceptions
ource/common/chromium_url/url_parse.h
source/common/chromium_url/url_parse_internal.h
source/common/chromium_url/url_canon_stdstring.h
source/common/chromium_url/url_canon_internal.h
source/common/chromium_url/url_canon.h
test/config/integration/certs/clientcert_hash.h
test/config/integration/certs/client_ecdsacert_hash.h
test/config/integration/certs/upstreamlocalhostcert_hash.h
test/config/integration/certs/upstreamcert_hash.h
test/config/integration/certs/server_ecdsacert_hash.h
test/config/integration/certs/servercert_hash.h
test/extensions/transport_sockets/tls/test_data/extensions_cert_info.h
test/extensions/transport_sockets/tls/test_data/ca_cert_info.h
test/extensions/transport_sockets/tls/test_data/no_subject_cert_info.h
test/extensions/transport_sockets/tls/test_data/san_uri_cert_info.h
test/extensions/transport_sockets/tls/test_data/san_dns2_cert_info.h
test/extensions/transport_sockets/tls/test_data/selfsigned_rsa_1024_cert_info.h
test/extensions/transport_sockets/tls/test_data/selfsigned_ecdsa_p256_cert_info.h
test/extensions/transport_sockets/tls/test_data/no_san_cert_info.h
test/extensions/transport_sockets/tls/test_data/san_only_dns_cert_info.h
test/extensions/transport_sockets/tls/test_data/san_multiple_dns_cert_info.h
test/extensions/transport_sockets/tls/test_data/selfsigned_rsa_3072_cert_info.h
test/extensions/transport_sockets/tls/test_data/selfsigned_rsa_4096_cert_info.h
test/extensions/transport_sockets/tls/test_data/unittest_cert_info.h
test/extensions/transport_sockets/tls/test_data/selfsigned2_ecdsa_p256_cert_info.h
test/extensions/transport_sockets/tls/test_data/password_protected_cert_info.h
test/extensions/transport_sockets/tls/test_data/san_ip_cert_info.h
test/extensions/transport_sockets/tls/test_data/intermediate_ca_cert_info.h
test/extensions/transport_sockets/tls/test_data/san_dns3_cert_info.h
test/extensions/transport_sockets/tls/test_data/selfsigned_ecdsa_p384_cert_info.h
test/extensions/transport_sockets/tls/test_data/selfsigned_cert_info.h
test/extensions/transport_sockets/tls/test_data/fake_ca_cert_info.h
test/extensions/transport_sockets/tls/test_data/selfsigned2_cert_info.h
test/extensions/transport_sockets/tls/test_data/long_validity_cert_info.h
test/extensions/transport_sockets/tls/test_data/san_dns_cert_info.h
test/extensions/transport_sockets/tls/test_data/san_dns4_cert_info.h
test/extensions/transport_sockets/tls/test_data/expired_cert_info.h
test/extensions/transport_sockets/tls/test_data/expired_san_uri_cert_info.h

Risk Level: LOW
Testing: self-contained
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
Part of #15264
[Optional Deprecated:]
[Optional API Considerations:]

also, why the exceptions?

LGTM, thanks! Optionally, would you be willing to also extend the format scripts to catch this, to future-proof?

Yes, it's on my plate. Not started yet though. Any help is welcomed. I will label the issue

also, why the exceptions?

test data seems auto generated and not linked in C++ code.
chromium_url: I need to understand if this requirement is adding the overhead to chomium_url owner when updating the new version.
I have no immediate answer in the night :(

Gotcha, thanks for the explanation :-)


Unhandled exception tracking doesn't work in node 0.12

This used to work in 0.10 (and I think 0.11), but in 0.12 the process exits before the post request is able to transmit data (https://github.com/Microsoft/AppInsights-node.js/blob/master/applicationInsights.ts#L138-L147).
I don't think there's a good way to fix this, the Error should be re-thrown immediately after it is tracked to avoid letting the app continue in an unstable state. It might work to do a synchronous file stream write before re-throwing the error, then reading the data from disk when the app starts.
I'm leaving it as-is since people might be using it in older versions of node without issue, but it would be good to find a better long-term solution.

This will be fixed by writing to disc synchronously when a crash has occurred

https://github.com/Microsoft/ApplicationInsights-node.js/blob/feature/v15-schema-and-auto-collection/AutoCollection/Exceptions.ts#L34
https://github.com/Microsoft/ApplicationInsights-node.js/blob/feature/v15-schema-and-auto-collection/Library/Channel.ts#L61-L91
https://github.com/Microsoft/ApplicationInsights-node.js/blob/feature/v15-schema-and-auto-collection/Library/Sender.ts#L104

This could be improved by writing the crash to a separate file and then ensuring that the crash file is sent first next time the app starts. Currently the crash would overwrite an existing file on disk.

This is fixed in version 0.15


Using Translation Strings on PageApprovalStatus

For:
https://github.com/ProfessionalWiki/PageApprovals/issues/73
Loading Icon is gonna show for less than a second in most scenarios.

Why a loading icon? Is this related to the translations?

Why a loading icon? Is this related to the translations?

Loading... text was hardcoded so I used a loading icon instead of using translation for this.

I think the loading text look better than the icon. Even though it's very quick (but might me slower on a bigger live wiki), it looks a bit more abrupt when the big icon is replaced by text.
https://github.com/ProfessionalWiki/PageApprovals/assets/1428594/204657a4-32a0-46f8-be87-a871a47562a8
https://github.com/ProfessionalWiki/PageApprovals/assets/1428594/c051608a-1e63-40ec-9c66-cf059ead8bf2

The icon is super small and should load seamlessly; I just wanted to avoid writing a translation for "Loading". I am not sure which one looks better, considering that they are going to show up for a few microseconds; I guess it doesn't matter.

Spinners are not great psychologically. In this case you also draw attention to one part of the page that is not there yet.
In order or worse to better (my opinion ofc):

Spinner
Loading...
Do not show anything
Show a visually similar placeholder

If you agree, then removing the spinner and showing nothing instead should be simple enough.


aider-chat: 0.56.0 -> 0.57.0

Description of changes
Simple package update, but should close
closes https://github.com/NixOS/nixpkgs/issues/342572
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 343759 run on x86_64-darwin 1

2 packages built:

aider-chat
aider-chat.dist

Result of nixpkgs-review pr 343759 run on x86_64-linux 1

2 packages built:

aider-chat
aider-chat.dist


docs: fix reserved scopes links

@peintnermax here are some conflicts. I think livio did already solve some parts in the proto

issue was already fixed.. closing


fix setup JDK 17 in Code Check CI

Proposed changes
Issue Number: close #xxx
Fix Code Check CI
see:

https://lists.apache.org/list?dev@doris.apache.org:lte=1M:JDK_17
https://github.com/actions/setup-java?tab=readme-ov-file#install-multiple-jdks

I have tested it in my repo:
https://github.com/Selflocking/doris/actions/runs/8206035510/job/22444233830?pr=2

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

@Yukang-Lian This PR has been open for many days, could you help review it? thanks🥹

@Yukang-Lian This PR has been open for many days, could you help review it? thanks🥹

OK

run buildall

@Selflocking  Every time you merge master into your PR, you need to comment 'run buildall' and wait check pass. Actually, if there is no conflict between master and your PR, you do NOT need to merge it.

run buildall

https://github.com/apache/doris/pull/32161 after this comment, we do not check java version on clang-tidy prepare

#32161 after this comment, we do not check java version on clang-tidy prepare

so should i close this pr?


Add modal for edit_view

This pull requests add the ability to use a modal dialog for the edit_view instead going to a separate page. It depends on this pull request getting merged first: https://github.com/flask-admin/flask-admin/pull/918
Bootstrap 3 screenshot: http://i.imgur.com/RfEwPP9.png
Bootstrap 2 screenshot: http://i.imgur.com/RVyCt4t.png
Here's an example of how the modal dialog would be enabled for the edit_view:
class PostAdmin(sqla.ModelView):
    edit_modal = True

Demo here: http://<IP_ADDRESS>:5000/admin/post/
This was inspired by @OleksandrLoboda's pull request: https://github.com/flask-admin/flask-admin/pull/265
Also, thanks to @tandreas for testing

I like it. Seems to work nicely.
Could you add some tests?

:+1: nice feature!

@petrus-jvrensburg I added a test. It just checks whether the modal gets added when edit_modal is enabled and is removed when disabled. Let me know if you had something else in mind.

@pawl That's great, thanks.
I'll add the new functionality to the docs as part of the current refactor.


TPI: PYTEST output

Refs: 21861

[x] macOS @jrieken
[ ] linux @rzhao271
[ ] windows @amunger

Complexity: 4
Author: @eleanorjboyd
Create Issue
Create Issue

Thank you for doing this testing!
Setup
1. Clone the test repo from [[here](https://github.com/eleanorjboyd/inc_dec_example_repo)](https://github.com/eleanorjboyd/inc_dec_example_repo) or use your own repo of pytests.
2. Launch VSCode and open the `inc_dec_example_repo/inc_dec_example_test_suite` testing repo folder.
3. Add the following to your settings in VSCode: `"python.experiments.optInto": ["pythonTestAdapter"],`
4. Use the "create environment" command from the command palette, select `venv` and a Python version >=3.7.
5. (for pytest)
    1. In the terminal, run `python -m pip install pytest`.
    2. From the command palette, run "python: configure tests", select `pytest` and then "." (root directory)
6. click the test explorer icon (beaker)
7. configure tests
    1. pytest: pytest → root

Testing:

in your settings.json you should see a "python.testing.pytestArgs": [] make the following changes and see the desired output. Output will be in the Test Results panel unless stated otherwise

Testing Output TPI specifics

Add --color=yes

check to see if the results are in color

switch to using log level error

check to see that only error and critical logs show up (change back after)

in the test result panel click on a failed test item

check that you can see a stack trace of sorts about the failed test

change test assert to assert True

check that printing and logging does not appear

Add ["-o", "log_cli=true"], and keep assert True

check that logging now occurs

From the terminal run python -m pytest test_logging.py and make sure it looks the same as it looks when you run just test_logging.py from the test explorer

Non execution related tests

Add -v to the args, set vscode log level to trace , then check in the “python” logs that you can see the list of tests discovered

something like the following:
<Module outer_nested_folder/test_outer_folder.py>
  <Function test_outer_folder1>
  <Function test_outer_folder2>
<Module outer_nested_folder/inner_nested_folder/test_nested.py>
  <Function test_answer_1pNest>
<Module outer_nested_folder/inner_nested_folder/test_unittest.py>
  <UnitTestCase test_class_unittest>

switch to “python test logs” confirm you see a deprecation message

switch to using log level error

Is this just the python logging level in settings or is there a pytest argument to do this? I don't see any difference when using the python log level setting

@amunger this should be in the code in the test so switching the following lines. Sorry that was unclear!
# caplog.set_level(logging.DEBUG)  # Debug level
    caplog.set_level(logging.ERROR)  # Error level


Live

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/TOC.md
:white_check_mark:Succeeded

windows-iotcore/connect-your-device/IoTDashboard.md
:white_check_mark:Succeeded

windows-iotcore/release-notes/Insider/RPi3BP.md
:white_check_mark:Succeeded

windows-iotcore/tutorials/Tutorials.md
:white_check_mark:Succeeded

windows-iotcore/tutorials/quickstarter/PrototypeBoards.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


making Auth - bad clock errors clearer

Description
Clarify 401 Auth - bad clock error.
[Describe what this change achieves]
This change adds clarification to the HTTP 401/403 Authentication errors due to time skew between client and server.
Issues Resolved
[List any existing issues this PR resolves]
Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] The CLA has been signed. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

Great idea to add a Troubleshoot.md @jeremymv2 I added to really minor comments. LGTM once they are fixed

Thanks @jeremymv2 for this clarification


(*BPFMap) GetValue return unexpected value when using BPF_MAP_TYPE_PERCPU_ARRAY

Recently, I am learning BPF programming from taking the lecture in xdp-tutorial repository. In the kernel side program, I have created the Map in BPF_MAP_TYPE_PERCPU_ARRAY type and updated the value without atomic operation.
    rec = bpf_map_lookup_elem(&xdp_stats_map_percpu, &key);
    if (!rec)
        return XDP_ABORTED;

    rec->rx_packets += 1;
    rec->byte_counters += data_end - data;

And I looked for the value in the map with (*BPFMap) GetValue() function, but I got unexpected value. When I went deeply into the code, I realized (*BPFMap) GetValue() just return part of the data.
If we just using libbpf in userspace side, the implementation will be like,
    struct datarec values[nr_cpus];

    if ((bpf_map_lookup_elem(fd, &key, values)) != 0) {
	fprintf(stderr,
	    "ERR: bpf_map_lookup_elem failed key:0x%X\n", key);
	return;
    }

    /* Sum values from each CPU */
    for (i = 0; i < nr_cpus; i++) {
	sum_pkts  += values[i].rx_packets;
	sum_bytes += values[i].rx_bytes;
    }

So I implemented my own GetValue function,
func (b *myBPFMap) GetValuePerCPU(key unsafe.Pointer) ([]byte, error) {
	value := make([]byte, b.ValueSize()*runtime.NumCPU())
	valuePtr := unsafe.Pointer(&value[0])

	ret, errC := C.bpf_map_lookup_elem(C.int(b.GetFd()), key, valuePtr)
	if ret != 0 {
		return nil, fmt.Errorf("failed to lookup value %v in map %s: %w", key, b.GetName(), errC)
	}

	return value, nil
}

And finally I got what I expected.
Does we need to a new method to obtain what I have mentioned above, or I have missed something critical.
Thanks for your answers.

The variable num_cpu was parsed from the file /sys/devices/system/cpu/possible, which is 0-127 in my case, but my presented CPUs are 8.

I think I see your point. This part was tackled by @grantseltzer but he is off this and next week.
Here is an example on how we read that file in tracee:
https://github.com/aquasecurity/tracee/blob/00c0de0099bf9fb0802971f44a42861775c66973/pkg/utils/environment/amount_cpus.go#L1

Note it has a special syntax for enabled CPUs versus disabled ones.

With that said,
It is complicated to use runtime.NumCPU() value like you did: Imagine you have 32 CPUs in your system, and enabled to your runtime CPUs 0, 4,5,6,12,14 (either because you're in a cgroup cpuset or because you simply disabled the others).
How would you know which per-cpu buffer to read for the CPUs you have online ?
If you use runtime.NumCPU() your logic will get values 0-7, but your online cpus are different. Thus the need to read all of them, no ?
Let me know if not =D.

That makes sense. I just confuse about where does the kernel get this value (/sys/devices/system/cpu/possible) from, since my hardware platform can't be supported that CPUs. By the way, I am running Linux 5.15.0-41-generic #44-Ubuntu SMP  x86_64 x86_64 x86_64 GNU/Linux on VM with 8 CPUs settings. The "possible_cpus" seems much more larger. Anyway this issue's major topic is solved, I will close this issue soon.
Appreciated. @rafaeldtinoco


Empire freezes after upgrade

Empire Version
March 11 commit - 45d219e1f5e50dd9b10e4442aecbb26f1df7650c
OS Information (Linux flavor, Python version)
Ubuntu - 2.7
Expected behavior and description of the error, including any actions taken immediately prior to the error. The more detail the better.
List the agents
Screenshot of error, embedded text output, or Pastebin link to the error
       163 modules currently loaded

       1 listeners currently active

       5 agents currently active

(Empire) > agents

[*] Active agents:

  Name               Internal IP     Machine Name    Username            Process             Delay    Last Seen
  ---------          -----------     ------------    ---------           -------             -----    --------------------
[!] Exception: need more than 29 values to unpack

After this Empire was just frozen

Were these agents active before the update?

@enigma0x3 yes, and yes

This is likely due to the fact that the update included a backend database change. See http://www.harmj0y.net/blog/empire/empire-1-5/ for details.


refactor(transformer/exponentiation-operator): correct comment

Follow-on after #7410. Update comment to reflect the changed logic.

#7476  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Only alters a comment, so merging without review.

Merge activity

Nov 25, 9:12 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.


[feat] adapter module

Fixes #625
Resolves #2249
Exposes two new modules, @sveltejs/kit/adapter and @sveltejs/kit/app. Instead of importing from ../output/server/app.js, adapter authors can now do this instead
import app from '@sveltejs/kit/app'; // can also be named import, { init, render }

app.init()

// somewhere, app.render()

The only thin I wonder about the async / await thing is that top-level await isn't available until Node 14.8, so maybe the adapters wouldn't work with Node 12. But this change does look really nice

Raising the min version to Node 14.8 isn't the worst thing to happen. Node 12 is only considered in Maintenance until April 2022. Hell, Node 14 moves to maintenance mode in Oct 2021.

I'm not sure if it's just the node adapter or others as well, but module resolutions and bundling don't play well with each other nicely

By this do you mean the use of esbuild in the adapters? From what I understand reading the code, all adapters would have to output the adapt build output to ${SVELTE_KIT}/output/server/app.js, is that correct?

@JeanJPNM that's a good idea! It should be possible, it might need to be configured from the adapter's side to manually resolve the alias though
@jthegedus actually, I'm not sure either, but I know the node adapter is a special case since it's the only one that has a rollup config (begin doesn't count), and how it treats dependencies and devDependencies differently

This should now allow authors to import from @sveltejs/kit/app and call init and render.
An additional step has also been added to the list of things that an adapter should do, which is to import { appResolver } from '@sveltejs/kit/adapter' and pass it to the esbuild plugins for build options

@JeanJPNM I've had a couple of discussions with @dummdidumm as well about this and the results seems to vary each time. In my case, I don't see it either with declaring it as type alias (type Foo = ...), but we seem to agree that this works correctly with node_modules generated from package-lock.json. Can you also try and see if it works for you using package-lock.json, and if using a clean pnpm-lock.json vs linking it to a local copy of kit differs too?

By using package-lock.json you mean installing the dependencies with npm?

installing the dependencies with npm

Yes

@ignatiusmb I left an idea for a path forward on this on the issue: https://github.com/sveltejs/kit/issues/2249#issuecomment-928675529. Let me know what you think about that idea

Sure, replied in the issue thread, #2514 also gave me some more ideas.
I'll convert this to draft for now since we obviously need to rethink on the approach. Might also need to rewrite the docs because authors can technically still just point the import directly to the generated output and skipping the bundling step, but of course they would miss out on the typings which defeats the purpose yet again.

Another idea might be to make the application a real module instead of relying on an esbuild plugin to resolve the location. Instead of writing the server output to .svelte-kit/output/server, we could try writing it to node_modules/@sveltejs/user-app with a package.json file:
		{
			"name": "@sveltejs/user-app",
			"version": "0.0.1",
			"private": true,
			"type": "module",
			"main": "app.js"
		}

I think I'm going to go ahead and close this for now since it's probably not the direction we'd go in. I filed https://github.com/sveltejs/kit/issues/2569 to track this as an issue. It might be easier to just start fresh with a new PR if we go with the node_modules approach, but feel free to reopen this if you'd rather update this one


Fix for issue #1535

Enhances SQLiteAdapter::hasTable() so that it can find tables in any already-attached database, including temporary tables when explicitly asked for.
Also fixes a quoting issue the original implementation had: table names containing ' would previously cause the method to error out. This required changing the PdoAdapter::quoteValue() method visibility to protected.

How do I find out what Stickler is actually complaining about? I've tried running phpcs locally and it only complains about something I didn't write.

@markstory do you know what is going on with sticklerci here?

@lorenzo It is attempting to apply phpcbf changes but can't because the changes are coming from a fork. I will get it updated so that fixer failure doesn't stop other errors from being reported.

I'll merge this now and solve the issues later. Thanks for the contribution!

Oops, after a second look at the tests, it is clear that there are tests failing. It is not just style issues. Reverting!

Can you please send a new pull request with passing tests?

They had passed on my end in the first place, so it may take a bit of fiddling. I'd imagine it's a cross-version compatibility thing. I'll have a look, though.

thanks!


Bug fix for values with :

The values for bom-ref, purl were getting cut-off when using : as the delimiter. This replaces it with another string |>
Added cdxgen-minimal profile to ignore licenses. pypi verified publisher is also setup, so feel free to release this.

@prabhu Changed to use cdxgen-extended rather than minimal for clarity since it excludes more fields than just cdxgen. Fantastic catch on bom-refs and purls getting cut off!


ArrayExpression class, BinOp.ne fix, docstrings fixes,

@stuartjchapman thanks, I'll pull these into a develop branch and merge later with some other changes

Merged into develop branch


How to disable press child Item on scrolling in Ios

In carousel render item, each item can pressable but on scrolling item it should not be press item and on android don't press on scrolling meaning work correctly but in ios  press the item in scrolling and how to disable pressing item in scrolling
here is my code
<Carousel
                autoPlay={false}
                loop={false}
                width={DEVICE_WIDTH * 0.85}
                style={{
                  width: '100%',
                }}
                height={160}
                data={accounts}
                scrollAnimationDuration={300}
                vertical={false}
                renderItem={({item}) => {
                  return (
                    <AccountCard
                      {...item}
                      onPress={() => {
                        console.log('press')
                       // on ios it log 'press' on scrolling
                      // other code ....
                      }}
                    />
                  )
                }}
                onSnapToItem={index => {
                  setCurrentIndex(index)
                }}
              />
```jsx
<!---
Any problem that does not include an accurate reproduction step is likely to be closed
-->
**Describe the bug**
A clear and concise description of what the bug is. If you intend to submit a PR for this issue, tell us in the description. Thanks!

**To Reproduce**
Steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

**Expected behavior**
A clear and concise description of what you expected to happen.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Versions (please complete the following information):**
 - react: v^18.2.0
 - react-native: v^0.72.4
 - react-native-reanimated: v^3.3.0
 - react-native-reanimated-carousel: ^3.5.1
 - react-native-gesture-handler: ^2.12.0

**Smartphone (please complete the following information):**
 - Device: all Iphone
 - OS:
 - Browser [e.g. stock browser, safari]
 - Version [e.g. 22]

**Additional context**
Add any other context about the problem here.

@minkgkyaw9899 Have you found a solution to this problem?
I'm facing the same problem

@minkgkyaw9899 Have you found a solution to this problem?
I'm facing the same problem
EDIT : I am able to avoid this problem using the Touchable element from react-native-gesture-handler insted of react-native

@rtorrente Your solution works on the Web app, not just iOS and Android. Thank you!
Just to be more specific, this is the solution that worked for me:
import { TouchableOpacity } from 'react-native-gesture-handler';


[slider] Slider feedback

I expected divs instead of spans, would have saved me a couple situations when my width/height styles wouldn't work right away
Indicator has position absolute, which makes it harder to style. I don't understand how this is helping me. See this PR for an example.

Note: when closing this issue, please make sure that this and this kludge in the demos are removed.

Thumb has position absolute, which makes sense. However, if it's positioned absolutely, we need to specify relative to what, otherwise it's a gotcha for the dev to figure out and find the Thumb in a random position on the page first. We need to set position: relative on the Track.
We need a prop or a CSS variable to make a slider to work like Radix/macOS slider—Radix and macOS sliders position the Thumb so that its edges are contained within the track (and we always align the Thumb's center to the track edge instead, so it ends up poking out of the Track at the edges)
minStepsBetweenValues name wasn't too intuitive—will think if there's something better
Cursor movement is tracked incorrectly when the Control part has padding

https://github.com/user-attachments/assets/16a1bf2e-2ead-4555-8b65-167653920706
Not sure what Control sizing has to do anything with the cursor movement; I'd expect it all to be done relative to the Track
Search keywords:

I'd expect it all to be done relative to the Track

Supposedly the Control is the "tracked area", and the Track is just a dumb component purely for styling the track, because without it you'd have to use a pseudo-element on the Control to style a "visible track" (or insert your own span)... naming issue?

Cursor movement is tracked incorrectly when the Control part has padding

This is probably still a bug, I'll check it out

Movements are actually relative to the Control which is the "tracked area", and the Track is just a dumb component purely for styling the track, because without it you'd have to use a pseudo-element on the Control to style a "visible track" (or insert your own span)... naming issue?

I was explained that Control is the clickable area, so I had used a bit of padding on it (including horizontal) to make clicks and taps easier.
I think no matter what size the Control is, the Thumb would always be placed relative to the visible Track.
In the Anatomy we are also placing Thumb into the Track so altogether that's why I expected it to work this way

I'll remove the horizontal padding from Control in my demo just to be safe for now, but let's still take a note to discuss later whether it's a legit design decision
https://github.com/mui/base-ui/pull/980/commits/de8e9ab72c10a437856c270b2a2463aa90b4583d

We need a prop or a CSS variable to make a slider to work like Radix/macOS slider

"Need" seems a bit strong here? We designed it this way intentionally. When the thumb is contained, the thumb position usually doesn't visually communicate the value accurately, and the pointer becomes misaligned. This seems like a better design.

@colmtuite I'd actually argue that inset thumb has to be the default

the thumb position usually doesn't visually communicate the value accurately

Slider isn't a component for entering precise values anyway, so this doesn't seem like the most important constraint here. Sometimes it's important, sure—I'm well aware of https://github.com/radix-ui/primitives/issues/1966, but precise mapping is more of an edge case for slider in my opinion. It's fine as long as it's going to be an option.
Otherwise, we can't ignore a class of slider designs, like this one:

Centered thumb wouldn't work in UIs like this one too because it would yield a layout collision:

iOS sliders are the same. Because of potential layout collisions and misalignments, I'd almost never want to use a centered thumb—I wouldn't use a slider when a precise value matters anyway.

the pointer becomes misaligned

This has always seemed just like an implementation mistake in Radix. Don't see why it should be misaligned—if thumb has, say, 100px of travel, that should be covered by 100px of pointer travel.
Native range input sliders (which are inset by default) and macOS sliders don't have this issue:
https://jsfiddle.net/1j9x06yu/

One more point to consider is that with Radix, it's possible to implement a centered thumb yourself via a 0px thumb element and pseudo elements for the visual thumb, but the reverse doesn't work—you can't implement an inset thumb with the design that we have.

Altogether, I think we need something like position: "inset" | "centered" on the Thumb, with inset being the default because it slots into any design layout well and can work with two most common slider design styles—a thin track with a larger thumb, and a thick track and same size thumb.

Thumb has position absolute, which makes sense. However, if it's positioned absolutely, we need to specify relative to what, otherwise it's a gotcha for the dev to figure out and find the Thumb in a random position on the page first. We need to set position: relative on the Track.

Yes, if we're setting position: absolute as an inline style, then we must set position: relative as an inline style too. Either we set both inline styles, or leave both up to the user.

Indicator has position absolute, which makes it harder to style. I don't understand how this is helping me.

Hmm right yeah, it's nested inside the track so it just needs a way to handle width

Either we set both inline styles, or leave both up to the user.

How about for all the slider parts we leave the position property up to the user? position is relatively easy to figure out


Fix the paper name.

Small fix for the linked paper name.

Thanks a lot for bringing this mistake to our attention! However, the problem seemed to be the other way around. The title was good but the URL was wrong (the paper "User Tracking on the Web via Cross-Browser Fingerprinting" was already mentioned before). I just fixed it in commit b789a47ff612c300173e2350d998b30acfe2314a.


feat: add French translation

Hi,
This PR adds the French translation.

Thank you for your contribution


Implement mbtiles support

Resolves #321

Pull Request Test Coverage Report for Build 1530

4 of 297 (1.35%)  changed or added relevant lines in 5 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-2.1%) to 50.079%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

library/src/main/java/io/ona/kujaku/views/KujakuMapView.java
3
24
12.5%

library/src/main/java/io/ona/kujaku/plugin/switcher/layer/MBTilesLayer.java
0
31
0.0%

library/src/main/java/io/ona/kujaku/mbtiles/MbtilesFile.java
0
52
0.0%

library/src/main/java/io/ona/kujaku/mbtiles/TileHttpServer.java
0
94
0.0%

library/src/main/java/io/ona/kujaku/mbtiles/MBTilesHelper.java
1
96
1.04%

Files with Coverage Reduction
New Missed Lines
%

library/src/main/java/io/ona/kujaku/views/KujakuMapView.java
1
23.63%

Totals

Change from base Build 1525:
-2.1%

Covered Lines:
2860

Relevant Lines:
5711

💛  - Coveralls


MLFlowLogger slows down the throughput twice than wandbLogger

🚀 Feature Request

I found that MLFlowLogger slows down the throughput twice than wandbLogger. I saw that there are lots of "import mlflow" in
https://github.com/mosaicml/composer/blob/dev/composer/loggers/mlflow_logger.py, is that root cause? Thanks
Motivation

[Optional] Implementation

Additional context

@viyjy can you please detail your workload so we can try to reproduce this?

I am training Mosaic/diffusion model by following this yaml. I have tried to replace this wandb logger by mlflow but found that will decrease the throughput by 10 times.
I realized that the reason might be that there are too many monitors. Therefore, I tried to only keep [speed_monitor, lr_monitor] (https://github.com/mosaicml/diffusion/blob/main/yamls/hydra-yamls/SD-2-base-256.yaml#L76C3-L76C3) and found that the throughput of wandb logger is still 2 times higher than the mlflow logger.

hi @viyjy, with this PR in, I think your throughput issue should be fixed. You can try it out by running off of dev or wait until a patch release next week.

This should be fixed in 0.16.1! Feel free to reopen if it's still an issue


Inconsistent breakpoint in responsive toggle for navigation

Expected Behavior
When changing the viewport size, I expect things marked with show-for-medium to transition at the same time as a responsive title bar that has the attribute data-hide-for="medium".
Current Behavior
The two transition at different but neighboring pixel values.  See below for an example.
Test Case/Steps to Reproduce
Test Case: https://codepen.io/IamManchanda/pen/LymroM?editors=1000
This is the link provided by the Foundation docs when you click on "Edit in Browser" for the first example under the heading "Responsive Toggle."  The Foundation doc is here: https://get.foundation/sites/docs/responsive-navigation.html.
How to reproduce:

Open up the developer console, open the device toolbar, and set the viewing mode to "Responsive."
Adjust the width to 680px.  Nothing changes from the normal large format.
Adjust the width to 679px.  The menu changes, but the callout remains visible.
Adjust the width to 678px.  The callout disappears.

Context
I have some dramatic changes in style on my app involving the top nav between medium and large views, and at the "transition pixel" (analogous to 679px in the example), things look bad.
Your Environment

Foundation version(s) used: 6.6.2
Browser(s) name and version(s): Chrome 85.0.4183.83
Device, Operating System and version: Desktop, CentOS 7

Checklist

[X] I have read and follow the CONTRIBUTING.md document.
[X] This is a bug report or a feature request.
[X] There are no other issues similar to this one.
[X] The issue title and template are correctly filled.

show and hide are min and max so this is expected as they are 1px different. You may want to swap the logic.

So interestingly, I tried the example on my MacBook Pro running Chrome 85.0.4183.102, and both transitions occur at 639/640px, which is correct and in line with what I expect.  So I thought maybe I was imagining things, so I went back to my CentOS box, and lo! I was able to reproduce the problem, so there must have been something related to how ems are defined.
Looking at the source code, .show-for-medium has a rule at max-width: 39.9375em, and .hide-for-medium has a rule at min-width: 40.0em, so that means that 0.0625em is not equivalent to 1 pixel on the Linux version of Chrome.
I did some more inspecting, and lo and behold, the Mac's default font-size is 16px, whereas the Linux's default font-size is 17px.  So I'm certain that explains the difference.  (That's why the breakpoint was nominally at 680px instead of 640px in my steps to reproduce.)
As an experiment, I changed max-width to 39.999em for .show-for-medium, and that fixed the issue on CentOS.  I'm not sure what other side effects changing breakpoints so that they end in .999em would be, but if it has no side effects, I think that should actually be the correct solution, rather than having to do a workaround with swapping the logic.

See https://github.com/foundation/foundation-sites/blob/develop/scss/_global.scss#L13
You might want to cgeck the browser / OS settings and set this to 16px in Foundation Sites.

Okay, apparently, my Linux Chrome's font size setting was set to "Custom," which explains the discrepancy.
But that raises this question: since clients are in control of that setting, and since people with visual impairment would probably set their baseline font size to be bigger than 16px, how feasible is it for Foundation to increase its compatibility with custom settings by updating how the breakpoints are calculated?
If this issue is not a bug, then I'd like to at least request the change as a feature.

Not a bug per se, just a calculation issue with the default root font-size that can be changed.

Just ran in to this problem too, with visibility classes.
A client is complaining that the mobile header appears on their laptop @ 1366px and I couldn't figure out why until I checked on my home PC and saw it. My browser has a slightly larger standard font size of 18px.
I've already got $global-font-size to 18px so I'm not really sure what to do here. All I can think of short-term is to override Foundation's visibility classes with our own using hard-coded px values.

The global font-size should be 16px by default.

The global font-size should be 16px by default.

Even with $global-font-size: 16px;, the problem still exists.
I created a demo to help test:
https://tobm1.csb.app/
Sandbox URL: https://codesandbox.io/s/foundation-font-size-test-tobm1?file=/src/foundation.scss
On a browser with normal text size settings, the demo works correctly, as you would expect.
But, on a browser with larger text size settings (e.g. 18px), the elements don't change visibility until 1537px.
I've looked in both Chromium Edge and Firefox and both exhibit the same behavior.

Chromium Edge: Menu > Settings > Appearance > Customize Fonts. Then change slider until Standard font reads 18.
Firefox: Menu > General > Fonts & Colors. Then change Size dropdown to 18.

Please check the generated code (from your scss) and what is set on html, body as font-size.

(body just inherits the 16px value)

Semi-related, https://stackoverflow.com/questions/42903778/media-queries-in-em-not-affected-by-the-base-font-size
I think what's happening is the em units in media queries are not relative to the html/body font-size, but to the browser font-size instead.


Orbiting items (3D)

Description
Create the component as shown in the video attached below. We already have an orbiting items component as this one, but this is more complex and 3d looking.
Animation Preview

Screenshot/Video: https://github.com/user-attachments/assets/5ba932d2-b669-4190-93db-bd62c661b479

[!NOTE]
Please refer to the Animata contributing guidelines available here for rules on how to contribute to the project. Let us know in the comments if you’re working on this issue, and feel free to ask any questions!

Requirements

[ ] Create a new animated component that matches the provided design.
[ ] Add example usage of the component in the documentation or storybook.

 Guidelines & Best Practices

Write reusable and clean code following the project’s style guide.
The component should be fully customizable. The user should be able to modify props such as duration, easing, color, and size where applicable.
Follow the Contributing Guidelines before submitting your pull request.

[!IMPORTANT]
To ensure more contributors have the opportunity to participate, we kindly request that:

Each contributor submits only one pull request related to this issue.
If you're interested in working on this issue, first check if it has already been claimed. If not, assign yourself to the issue and move it to In Progress on the project board.

Additional resources
Posted on X by: https://x.com/oguzyagizkara/status/1699745310312960219

Checklist

[ ] I have read and followed the contributing guidelines.
[ ] I have developed the component according to the requirements.
[ ] I have tested the component across different browsers and screen sizes.
[ ] I have documented the component for future reference.
[ ] I have submitted a pull request with appropriate labels and referenced this issue number.

Hello my name is Erick! I'm a web development student from Costa Rica starting to make contributions to OSS projects Web3/Web2, I would love to contribute to this project I have experience working with TS/Next.js/React and Tailwind.
You can check my OD profile https://app.onlydust.com/u/evgongora
Looking forward to work on this! :)

hey @sudhashrestha can you please share the icons image in the referred video..
Would love to work on this

@Pikachu-345 You don't need to use those exact icons. You can just use lucide-react for this.

@evgongora You have another ticket assigned already so I'm assigning this one to @Pikachu-345

@sudhashrestha  does this org has any slack or discord server where we can discuss issues ?
Cause there are some question about this issue..

@Pikachu-345 here's the discord link: https://discord.gg/YfvqMf5MTE

Hey @sudhashrestha  @hari have created a PR #243 please review and suggest changes if required


[WIP] Ember cli

Closes #3237
Reading through the commits is the best way to track progress; they're fairly atomic.
Currently, I can't get anything to happen (even error messages) on ember serve, although I did do some fiddling to get the new resolver to pick up a few of our utils.
Playing with this branch
The goal is for the following commands to do something:
# First terminal
<ghost> $ node index
# Another terminal
<ghost>/core/client $ ember server --proxy http://localhost:2368

Visiting http://localhost:4200 then serves up the app, some day :)
Todos

[ ] get ember serve to show something, or at least print an error
[x] move to ember-cli app layout
[x] move to ES6 for ember / DS
[x] add sass/autoprfixer
[x] remove client related grunt tasks
[ ] update grunt to run ember-cli tasks
[ ] update development/release/install workflows and readmes
[ ] remove unused root-level deps in bower.json and package.json that have moved to the client-specific versions of those files
[ ] move app config to configuration/environment.js (ghost-paths needs some work to hook in to our node app's config)
[ ] add client dependencies to ember-cli via addons / brocfile (partially done? showdown's missing)
[ ] refactor client grunt tasks
[ ] discuss new code styles now that we'll be able to do es6 (http://6to5.org/docs/learn-es6/)
[ ] ?????

Ghost's now trying to serve up the files generated by ember-cli.
I have an issue where my css lookups in /ghost/* are all getting redirected to the html /ghost that I need to figure out.
301 REDIRECT /ghost/css/ghost.min.css?v=foobar -> /ghost/css/ghost.min.css/?v=foobar
Not sure where that's from
Anyways, to play with this now, do
``sh
in core/client
$ ember build --watch
```sh
# in the root dir, a separate console
$ node index

Massively redid this, it actually works now ;) Updated todos

Updated again, first pass through the gruntfile. grunt [dev,init.prod] are all working now, but grunt dev won't auto rebuild ember yet -- need to spawn a background ember build --watch

Awesome. I'm traveling right now but I'll try to give this a once-over in the next couple of days.

Thanks!
And let's just agree not to merge any PRs that modify files in core/client
until this one's in, agreed?  :D
On Sat, Feb 14, 2015 at 1:09 PM, Jason Williams<EMAIL_ADDRESS>wrote:

Awesome. I'm traveling right now but I'll try to give this a once-over in
the next couple of days.
—
Reply to this email directly or view it on GitHub
https://github.com/TryGhost/Ghost/pull/4853#issuecomment-74389984.

I've been going over this and it's definitely functional, which is really exciting.  I made some notes while going through it:

do we need client/tests/?

do we need the "qunit" dependencies in client/bower.json?

status of client/package.json?

do we need things like express?

remove client/app/config-dev.js and config-prod.js?

do we need to consider ember-cli disableAnalytics (client/.ember-cli) in regards to PRIVACY.md?

client lint files need to exclude client/dist/

what are we doing about indentation (ember-cli generates indent of 2, everything else is 4)?

bunch of client jscs/jshint errors that need to be dealt with

remove client/app/config-dev.js and config-prod.js
Yep, missed those this second time around.

what are we doing about indentation (ember-cli generates indent of 2, everything else is 4)?
I'd vote for lazily bumping up to 4 - move to 4 when someone comes in and makes a change, but leave at 2 for now

bunch of client jscs/jshint errors that need to be dealt with
Where can I see these?

package.json
@rwjblue if we never use ember serve, do we need express in the ember-cli's package.json?

disabling analytics
Yeah, i'll turn that off

do we need client/tests
I was hoping you'd be able to tell me! I figured the unit tests you've been doing would go in there, but I'm sure we can keep doing them however we currently are (..?)

q-unit deps
Probably not, if we aren't going to be using it ;)

what are we doing about indentation (ember-cli generates indent of 2, everything else is 4)?
I'd vote for lazily bumping up to 4 - move to 4 when someone comes in and makes a change, but leave at 2 for now

The only problem with that is that JSCS is checking for an indentation of 4.  So once the tests are running far enough to get to the linting, JSCS is going to go crazy over anything that was auto-generated with an indent of 2.

bunch of client jscs/jshint errors that need to be dealt with
Where can I see these?

If you fix up Gruntfile.js to exclude client/dist when building the list of files to lint, then you can run grunt jshint:client and grunt jscs:client.

do we need client/tests
I was hoping you'd be able to tell me! I figured the unit tests you've been doing would go in there, but I'm sure we can keep doing them however we currently are (..?)

I'll have to do some research on that.  I just wasn't sure if you had a strategy in place that involved leaving the ember-cli generated client/tests/ in place but actually running our Ember tests from core/test/client (I realize they're not actually working right now).  I'm guessing the answer is "no" and client/tests/ is just there because tests need to be sorted out still.

The only problem with that is that JSCS is checking for an indentation of 4. So once the tests are running far enough to get to the linting, JSCS is going to go crazy over anything that was auto-generated with an indent of 2.

Copy that, I'll just run the jshint and jscs tasks and clean up accordingly

client/tests/

Yeah, ember-cli just put them there and I wasn't sure if we wanted to work with using it as our testing framework or keep doing our own thing. Looks like that's the last big decision that needs to be made.. mind if I lean on you for it? ^ ^

@rwjblue if we never use ember serve, do we need express in the ember-cli's package.json?

Nope, you don't need it.

Yeah, ember-cli just put them there and I wasn't sure if we wanted to work with using it as our testing framework or keep doing our own thing. Looks like that's the last big decision that needs to be made.. mind if I lean on you for it? ^ ^

In theory it would be better from ember-cli's perspective if the tests were in the "normal" location, but I think it is slightly worse ergonomics for y'all (meaning it would be nice if they could stay where they are currently).  We can make fixes/changes for this in ember-cli if needed, ping me in #ember-cli and we can chat through it...

Do we need to consider ember-cli disableAnalytics (client/.ember-cli) in regards to PRIVACY.md?

Yes, that makes sense.

In theory it would be better from ember-cli's perspective if the tests were in the "normal" location

I know we had this discussion a few months back regarding the location of Ember tests, and I was in favor of the path of least resistance then (i.e., locating them under /client), and I have to say that after working with ember-cli that I'm really in favor of doing it now.
I was able to get all the client tests running (and passing!) via ember test in like 20 minutes using ember-cli-mocha and ember-mocha.  I wasted that much time just trying to guess what to change in our current customized setup (and didn't get anything close to working).

I know we had this discussion a few months back regarding the location of Ember tests, and I was in favor of the path of least resistance then (i.e., locating them under /client), and I have to say that after working with ember-cli that I'm really in favor of doing it now.

Less work for me, yay!

Also, that weird problem I've been having where I can't test the rendered output of a component is gone when running the tests under ember-cli.

Awesome!

@novaugust
I have the Ember tests working here: https://github.com/jaswilli/Ghost/tree/ember-cli-tests
I tried to create a discrete commit for every piece of work if you want to cherry-pick them onto your branch (or whatever works).
Basically what I did was:

Set up the ember-cli test infrastructure to use Mocha.
Removed all the qunit stuff.
Moved the Ember tests from core/test/client/unit/ into core/client/tests/unit/.
Removed core/test/client/.
Changed Brocfile.js to not run jshint.
Re-worked the jshint / jscs grunt tasks to accommodate the ember-cli changes.
Changed the indentation of ember-cli generated files from two to four spaces.
Made the necessary adjustments to .jshintrc files and ES6 imports to the existing Ember test files.

All the tests are now passing.

=O
So... squish commits (Leaving me first one + your first one with all the file moves alone) and merge after the next release?

Yeah, definitely want to leave the move/rename files commits standalone.  After that, I'd squash where it makes sense but I'd rather err on the side of more smaller commits than ending up with only a couple that are impossible to navigate.

Definitely don't stress about commit squashing on this one. When moving/renaming files you absolutely want to keep that separate from code changes.
Where things go neatly together, squish em, otherwise don't.

:+1: squashed one unneeded commit from mine work
... i can't believe this is happening
Thanks a lot for taking on the tests @jaswilli!

rebased on 0.5.9. @ErisDS @jaswilli @dbalders shall we take it for one last spin and get it in? :)

I have taken this for a very quick spin, running grunt init + npm start or npm start --production seems to work, but running grunt prod makes both npm start and npm start --production throw this error:

ERROR: Javascript files have not been built.

Because the check at core/server/index.js:82 fails due to all of the files having a hash in the filename:
http://puu.sh/gqnTa.png
Which lead me to wondering 2 things:

what's that hash and why it's different for each file?
where did the dev assets go?

In the existing system, grunt init builds all the standard (unconcatenated and unminified) assets for development mode, and grunt prod builds the production versions (but doesn't remove the development versions). If I run in production mode, the production assets should be used and if I run in development mode I get dev assets.
The intention of the separation is so that when running grunt dev (i.e. the watch task) you aren't waiting for slower minification functions to finish.
I'm not sure what the ember-cli way to manage all of that is? Once I understand that, I can help get the release process working again. That relies heavily on the .npmignore file, which currently references the old project structure.

The hashes come from the built in fingerprinting in ember-cli, easily turned off - sorry for not noticing them ;) http://www.ember-cli.com/#fingerprinting-and-cdn-urls
Re: minification, ember-cli already only minifies if the environment is production, so we're good there.

Oh, and so you do know the ember-cli way of managing all that stuff, it's inside of the Brocfile.js, where we do var app = new EmberApp(options) //or whatever it was, we just mess with that options object

Known issue:
If you grunt init && grunt dev for the very first time, the express server will fail because it will be checking for the built files before ember build has had time to output them...

Found an issue with asset delivery for non-admin assets, leaving myself a note here:

@novaugust to fix that, I believe you just need to change {{asset "css/ghost.min.css" ghost="true"}} to {{asset "ghost.css" ghost="true" minifyInProduction="true"}} on L20 of user-error.hbs:
https://github.com/TryGhost/Ghost/blob/master/core/server/views/user-error.hbs#L20

Congratulations!


Reformat with black v23

Our CI started failing because Black cut a new release, which our code did not adhere to.
Specifically, this change
Now our code conforms to this new rule.

@marySalvi @manthey Hoping to get a quick review on this to keep certain that the main branch is always passing CI tests.


[#4009] Update samples to support latest Node version - JavaScript

Fixes # 4009
Description
This PR updates the ARM templates of the JavaScript samples to use Node 20 as default.
Proposed Changes

Updated Node to version 20 in all ARM templates.
Updated Node required version in README files.

Testing
These images show the resources created in Azure and a bot working after the deployment.

/promoted 4010


add hook for checking sdk version on codegen

@SferaDev this PR may no longer be necessary now that we decided to check and prompt here: https://github.com/xataio/client-ts/compare/feat/pgroll-next-prompt?expand=1

Closing this in favor of https://github.com/xataio/client-ts/pull/1514


Click on tab bar to reload the same page?

Hi.
I have 3 tabs: AM | PM | LUNCH
the sequence for each tab is the same
tab > loads page with list view > click on listview item > item details .
My problem is,
When a user is on AM tab and does not click 'back' to the listview page, the page is left hanging unless they go back. So assuming i did not do that and now i navigate on PM page and i want to click back on AM tab, i see the details and not the loaded page with listview.
How do i go about such that when i am on other tabs, when i click back another tab i reload my listview instead of having to manually go back to reach the listview?

Hi, isn't this behavior a little weird for users? I have a similar behavior but it only goes to "first page" when the user press a second time the tab item. Maybe could help you:
tabBarComponent:  ({jumpToIndex, ...props, navigation}) => (
    <TabBarBottom {...props} jumpToIndex={index => {
      const { state } = navigation,
            { routes } = state;
      if (state.index === index && routes[index].index !== 0) {
        navigation.dispatch(NavigationActions.reset({
    index,
    key: routes[index].key,
    actions: [
      NavigationActions.navigate({ routeName: routes[index].routeName })
    ]
  })
      } else {
        jumpToIndex(index);
      }
    }}/>
  )

@augustoabreu  hi, jumpToIndex(index) meaning i have to set my screens as indexes under state? Currently my listview are nested inside a Stack.

@saeropark
The index in jumpToIndex(index) is the corresponding number of your tabs. Like this:
const tabs = TabNavigator({
  home: StackNavigator(), // index = 0
  users: StackNavigator(), // index = 1
  settings: StackNavigator(), // index = 2
})

The index in state.index is the current screen on state.routes array.
--
To  hide the header of main stack:
const stack = StackNavigator({
  login: StackNavigator,
  tabs: tabs
}, {
  headerMode: 'none'
})

@augustoabreu I am using your code snippet but for some reason it doesn't work for tab1 and tab2. It works only for tab0. When I tap on Tab0 the stack is reset, but when I navigate inside tab2 stack and tap Tab2 I receive an error.
I am using:
"react-navigation": "^1.0.0-beta.11"
"react": "16.0.0-alpha.12"
"react-native": "0.45.1"
"redux": "~3.6.0"
cc @maxmcd
I have a StackNavigator containing a TabNavigator containing 3 StackNavigators.
import React from 'react'
import PropTypes from 'prop-types'
import {connect} from 'react-redux'
import {
    Button,
    Platform,
} from 'react-native'
import {
    Header,
    StackNavigator,
    TabNavigator,
    TabBarTop,
    NavigationActions,
} from 'react-navigation'

const StackA = StackNavigator({
    ScreenA1: {
        screen: ScreenA1ViewContainer,
        navigationOptions: {
            header: null,
        },
    },
    ScreenA2: {screen: ScreenA2ViewContainer},
}, {
    navigationOptions: {
        tabBarLabel: 'TAB A',
    },
})

const StackB = StackNavigator({
    ScreenB1: {
        screen: ScreenB1ViewContainer,
        navigationOptions: {
            header: null,
        },
    },
    ScreenB2: {screen: ScreenB2ViewContainer},
}, {
    navigationOptions: {
        tabBarLabel: 'TAB B',
    },
})

// Root navigator is a StackNavigator
const StackC = StackNavigator({
    Account: {
        screen: ScreenC1ViewContainer,
        navigationOptions: {
            header: null,
        },
    },
    ScreenC2: {screen: ScreenC2ViewContainer},
}, {
    navigationOptions: {
        tabBarLabel: 'TAB C',
    },
})

// TabNavigator is nested inside StackNavigator
export const Tabs = TabNavigator({
    TabA: {screen: StackA},
    TabB: {screen: StackB},
    TabC: {screen: StackC},
}, {
    ...TabNavigator.Presets.AndroidTopTabs,
    tabBarPosition: 'top',
    animationEnabled: true,
    swipeEnabled: true,
    backBehavior: 'initialRoute',
    lazy: false,
    tabBarComponent:  ({jumpToIndex, ...props, navigation}) => (
        <TabBarTop
            {...props}
            jumpToIndex={tabIndex => {
                const { state } = navigation
                const { routes } = state
                if (routes[tabIndex].index !== 0) {
                    const stackRouteName = ['ScreenA1', 'ScreenB1', 'Account'][tabIndex]
                    navigation.dispatch(NavigationActions.reset({
                        index: tabIndex,
                        actions: [
                            NavigationActions.navigate({ routeName: stackRouteName })
                        ],
                    }))
                } else {
                    jumpToIndex(tabIndex)
                }
            }}
        />
    )
})

const OnboardingStack = StackNavigator({
    Onboarding: {screen: OnboardingViewContainer},
}, {
    headerMode: 'none',
})

const AppNavigator = StackNavigator({
    Home:       {screen: Tabs},
    Onboarding: {screen: OnboardingStack},
}, {
    headerMode: 'none',
})

I receive the error:

Any help would be greatly appreciated.

@fabriziomoscon did you find a solution for the error?

yes I solved.
I ended up using a fork:
"react-navigation": "https://github.com/cribspot/react-navigation.git#187913749f61f27e109af841b5558235032652b7"
check this out: https://github.com/react-community/react-navigation/pull/1335

I have the same issue as @fabriziomoscon. Is there any way to fix this problem or workaround that does not involve switching to a PR-branch of the project.
When someone can point me in the right direction, I can try to create a PR for this issue.

@florianeckerstorfer The PR is already created. Check out PR #1335

@spencercarli I think this issue can be closed as tabBarOnPress is available in the latest release (1.0.0-beta.13)