Add Awonuga-Oluwapelumi to Before I Die

Issue Addressed

Proposed Changes and Benefits

Screenshots

Notes to Reviewers

Checklist

[x] I have thoroughly read and understand The Contribution Guidelines.
[x] The title of this PR follows the keyword: brief description of change format, using one of the following keywords:

Feature - adds new or amends existing user-facing behavior.
Chore - changes that have no user-facing value, refactors, dependency bumps, etc.
Fix - bug fixes.
Docs - fixing typos and adding new content.

[x] I have listed my proposed changes and their benefits.
[x] I have linked the corresponding issue in the Issues section.

Hi @XanderRubio,
I’ll fix it and revert.
Thank you!

Excellent! Looking forward to seeing and very grateful for your time.

Excellent @Dunni0! Your new image looks great on the preview link, and thank you for taking the extra time to change it. Going ahead with merging now.

@Dunni0   Your pull request has been successfully merged!!! Congratulations .
If you haven't already, please go ahead and star this repo and you are more than welcome to continually contribute to this project by assisting with our open issues, or adding your own new open issues, and additionally you can get an idea of ideas we have to continually grow this project further as technology and tech stack continually evolve by looking at the ROADMAP for the project. Have a great day, and thank you for taking the time to contribute,
Awonuga! You can view your contribution now on the live link. Have a great rest of your day, and I will be sending you an invite to be a member of the Before I Die Code now.


runtime: use parent goroutine's stack for new goroutines

This is a speculative idea from discussion with @aclements. Jotting it down so it doesn't get lost and to open discussion.
Spinning off many goroutines that grow their stack and then exit can be a source of performance pain. See e.g. #18138. One approach to fixing this is tracking and using statistics about stack growth behavior per spawn site.
Another possible approach is to:

switch immediately in the scheduler from parent goroutine to spawned goroutine
use the (free part of) the parent's stack as the spawn's stack
relocate the spawn's stack as needed

The idea here is that the parent goroutine's stack is likely to have plenty of free space, so if the spawn is short-lived, we can avoid doing any stack allocation for it at all, much less multiple stack growths.
If the spawn lives long enough that the parent goroutine starts running again, then this is worse. So it might be worth tracking some basic statistics on the fly to decide whether to do this.

One common pattern where this may be problematic is where a parent spawns a goroutine and blocks on receiving the result of that goroutine from an unbuffered channel. In the basic form of this design, this would always force a stack-rip. A few ways I can think to get around this:

Encourage people to use a single-element channel instead. Not so great for existing code.
Statically recognize this "send and exit" pattern and compile it into a combined operation that does them in the opposite order (the difference is unobservable). The value would still have to be buffered somewhere until the parent reached the channel receive. This may be tricky because there's no way to bound the amount of buffering necessary.
Let the parent keep running until it blocks (like today), and then start running the new goroutine on the parent's stack. We'd need somewhere to stash the goroutine's argument frame. Here we could at least bound the amount of buffering for the argument frames, since we could always fall back to spawning a full goroutine.

For solution 2 or 3, we could always do something like _defer objects, which are manually allocated and freed by the runtime.
Cilk (which inspired this idea) structurally enforces something like solution 2, but the spawning code always has to pre-arrange a place to put the result.

How about allocating the child goroutine's stack in the same allocation but not right next to the parent's stack? That is, suppose the parent has 100K allocated stack space, say (base, base+100K), and is currently using 60K. When it spawns the child, we can put the child's stack at, say, base+90K, and adjust the parent's stack bound. When either the parent's stack grows to 90K, or the child's stack grows to 10K, (or the parent fires up more goroutines which uses up the stack), relocate the stack.
This way, both goroutines are runnable (if not otherwise blocked), and the scheduler can choose whatever appropriate.

When it spawns the child, we can put the child's stack at, say, base+90K, and adjust the parent's stack bound.

If and when https://github.com/golang/go/issues/25999#issuecomment-400841088 materializes then this could even be done precisely by knowing how much both parent and child need in term of stack space.

In Go terms I believe Cilk basically turned the go command into a call but
the calling frame was prepared in such a way that the parent's goroutine
stack could be copied, stolen, and then resumed by another P. I never
figured out the actual mechanism used in Cilk stealing but Go's ability to
relocate stacks is unique and seems to be part of the solution for Go. I
suspect that we could copy the child goroutine instead but that seems
racier.
This would also bound the number of goroutines the scheduler would have to
manage as well as a lot of other nice properties discussed in the Cilk
papers. Go should preserve these bounds if we do this.
On Fri, Sep 7, 2018 at 6:40 PM, Carlo Alberto Ferraris <
<EMAIL_ADDRESS>wrote:

When it spawns the child, we can put the child's stack at, say, base+90K,
and adjust the parent's stack bound.
If and when #25999 (comment)
https://github.com/golang/go/issues/25999#issuecomment-400841088
materializes then this could even be done precisely by knowing how much
both parent and child need in term of stack space.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/27345#issuecomment-419584853, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA7Wnx2xixDi0c2XgX3C78od7v5KuIijks5uYvXUgaJpZM4WSA6H
.

This would also bound the number of goroutines the scheduler would have to
manage as well as a lot of other nice properties discussed in the Cilk
papers. Go should preserve these bounds if we do this.

I think it's worth striving for similar bounds, but Cilk was able to achieve these bounds strictly only because it had a very strict fork/join model of parallelism, where the parent function couldn't even return until all of its child threads had returned/exited. Because of Go's ad hoc parallelism, the best we could do (which would still be quite good) is to say, if your program is structured like X, then it will have some space and time bounds.

Let the parent keep running until it blocks (like today), and then start running the new goroutine on the parent's stack. We'd need somewhere to stash the goroutine's argument frame. Here we could at least bound the amount of buffering for the argument frames, since we could always fall back to spawning a full goroutine.

@pjweinb pointed out to me today that we could switch to the child when the parent blocks or tries to start a second child goroutine. Bounding it to a single pending goroutine makes the bookkeeping much simpler and may go towards ensuring Cilk-like space bounds. We could also combine this with @cherrymui's idea, which would give us a place to put the pending argument frame: when the parent go's the child, we immediately assign most of the parent's remaining stack to the child, put the goroutine's argument frame in its section of the stack, shrink the parent's stack bounds, and let the parent keep running. When the parent blocks, tries to start another child, or encounters its stack bound, we switch to the child (without moving the parent's stack at that time).

This seems promising- any updates about working towards improving goroutine speculative stack spawning?

Sadly, no. Too much other work on our collective plates right now.


Deprecate sample in favor of Spring Boot 2 sample

Accompanies the removal of the associated Quickstart article.

Note: This change should not be merged until the new quickstart article and repository is published.


ui: session persistence

persist socket sessions across reloads so you can refresh the page during generation and resume.

i also did a memoization sweep of a lot fo components cause we were getting some hits on progress images that cluttered console output and made it impossible to troubleshoot

Works as advertised.


Support authentication on global region for AWS IAM

This PR enables one to perform AWS IAM authentication when the Vault instance is configured on the Global STS endpoint (us-east-1) and the application is deployed on another region.

@Amuerte Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@Amuerte Thank you for signing the Contributor License Agreement!

Close #758


Unsaved Changes Lost When Switching Back and Forth between Tabs

Description
When I open a new diagramm the changes in my first diagramm are undone.
All diagramms that are opened in XML View are reloaded  and all changes are removed.
Steps to Reproduce
Steps to reproduce the behavior:

Open a diagramm (or create a diagramm)
Change something in the diagramm
Switch to XML View of the diagramm
Create a new diagramm (File -> new File -> ... or Cntl +T have the same effect)
Go back to the first diagramm (all changes are undone)

Expected Behavior
When I open a new diagramm the other diagrammes should not be changed.
Environment

Windows 10
Modeler 3.0
Plugin: camunda-modeler-property-info-plugin

I can reproduce this. Thanks for letting us know. We'll fix this ASAP.

The bug appears as soon as the sheet of a tab is switched with unsaved changes.

This bug was introduced by fixing https://github.com/camunda/camunda-modeler/issues/1318. Now that every time the xml prop passed from App to MultiSheetTab through EditorTab changes the cached lastXML property of MultiSheetTab is overridden the up-to-date XML that was cached after switching sheets will be replaced by the outdated XML passed to MultiSheetTab.

Closed via https://github.com/camunda/camunda-modeler/pull/1356.

Released as v3.1.0


MSL: Out-of-order offsets cause uniform struct member to be mis-declared and referenced

SPIR-V conversion to MSL fails MSL compilation when out-of-order offsets cause uniform struct member to be mis-declared and referenced.
The following SPIR-V:
       OpMemberDecorate %358 0 Offset 80
       OpMemberDecorate %358 1 Offset 0
       OpMemberDecorate %358 2 Offset 64
       OpMemberDecorate %358 3 Offset 48
 %62 = OpTypeInt 32 1
 %69 = OpTypeVector %62 4
 %76 = OpTypeInt 32 0
 %84 = OpTypeVector %76 3
%179 = OpConstant %76 3
%355 = OpConstant %76 8
%356 = OpTypeArray %62 %355
%357 = OpTypeArray %69 %179
%358 = OpTypeStruct %356 %357 %84 %76

%189 = OpConstant %62 0
%197 = OpConstant %62 1
%364 = OpAccessChain %363 %360 %197 %189
%365 = OpLoad %69 %364
       OpStore %362 %365

results in this incorrect MSL struct and references:
struct _358
{
    int4 _m0[3];
    uint _m1;
    uint3 _m2;
    int4 _m3[8];
};

program_source:185:10: error: cannot initialize a variable of type 'int4' (vector of 4 'int' values) with an lvalue of type 'int4 const constant[8]'
    int4 _362 = _360._m3;
         ^      ~~~~~~~~
program_source:188:10: error: cannot initialize a variable of type 'int4' (vector of 4 'int' values) with an lvalue of type 'int4 const constant[8]'
    int4 _370 = _360._m3;
         ^      ~~~~~~~~
program_source:191:10: error: cannot initialize a variable of type 'int4' (vector of 4 'int' values) with an lvalue of type 'int4 const constant[8]'
    int4 _377 = _360._m3;
         ^      ~~~~~~~~
program_source:197:24: error: subscripted value is not an array, pointer, or vector
    int _393 = _360._m1[0];
               ~~~~~~~~^~
program_source:200:24: error: subscripted value is not an array, pointer, or vector
    int _401 = _360._m1[1];
               ~~~~~~~~^~
program_source:203:24: error: subscripted value is not an array, pointer, or vector
    int _408 = _360._m1[2];
               ~~~~~~~~^~

but results in this correct GLSL struct and references:
layout(set = 0, binding = 0, std140) uniform _358_360
{
    layout(offset = 80) mediump int _m0[8];
    layout(offset = 0) mediump ivec4 _m1[3];
    layout(offset = 64) uvec3 _m2;
    layout(offset = 48) mediump uint _m3;
} _360;

ivec4 _362 = _360._m1[0];
ivec4 _370 = _360._m1[1];
ivec4 _377 = _360._m1[2];
int _393 = _360._m0[0];
int _401 = _360._m0[1];
int _408 = _360._m0[2];

These CTS tests (total 50) fail as a result:
dEQP-VK.ubo.random.all_out_of_order_offsets.*

SPIR-V file:
out-of-order-offsets-uniform-struct-members.spv.zip

There are two problems here:

_m2 is at the wrong offset--it should be at offset 64, but in the MSL it is at offset 52. We need to insert padding to put it at the correct offset, even after reordering.
Reordering the members breaks access chains into the structure, which assume the old order.


[4.0.0.beta-5] @HosListener event.preventDefault does not work on ion-button

Bug Report
Ionic Info
Run ionic info from a terminal/cmd prompt and paste the output below.
Ionic:
   ionic (Ionic CLI)          : 4.0.5 (/usr/lib/node_modules/ionic)
   Ionic Framework            : @ionic/angular 4.0.0-beta.5
   @angular-devkit/core       : 0.7.0-rc.3
   @angular-devkit/schematics : 0.7.0-rc.3
   @angular/cli               : 6.1.5
   @ionic/ng-toolkit          : 1.0.7
   @ionic/schematics-angular  : 1.0.5
System:
   NodeJS : v9.8.0 (/usr/bin/node)
   npm    : 6.4.0
   OS     : Linux 4.9

Describe the Bug
I created a directive to prevent clicks from happening in a component. event.preventDefault or stopPropagation does not seem to work if used within a @HostListener click event.
Steps to Reproduce
Steps to reproduce the behavior:

Create any Ionic v4 project
Create a directive with @HostListener click event, and prevent default the event from there.
Use the directive in any button
See behaviour

Related Code
I made a stackblitz
This is the directive, it contains a hostlistener for the click events.
  @Directive({
      selector: '[appDisable]'
  })
  export class DisableDirective {

      @Input() ifTruthy: boolean = false;

      @HostListener('click', ['$event']) clickEvent(event: Event): boolean {
          if (this.ifTruthy) {
              console.log('Preventing click');
              console.log('This should prevent further clicks from happening?');
              event.preventDefault();
              event.stopPropagation();
              return false;
          }

          return true;
      }

      constructor(
          private element: ElementRef,
          protected renderer: Renderer2) {
      }

  }

And then I added it to an ionic button.
<ion-button appDisable [ifTruthy]="1 === 1" (click)="presentAlert()">Disabled</ion-button>
Expected Behavior
It is expected that the common (click) button from the component is not executed.
Additional Context
StackOverflow
IonicForum

The execution order of events is this case is not ensured, the best way you have to fix this event is using CSS or the disabled prop.

@manucorporat could you elaborate? I added a console log on both methods and the @Hostlistener executes first.


program is slowing down after 10,000 lines of code written.

VSCode Version: 1.5.1
OS Version: 10.11.6

@furkankinyas Can you please provide a file that can help us reproduce the slowness you are experiencing. For example, here I am copy-pasting up to 10k lines and it works fine for me. Perhaps this is happening in a certain file type or in a certain file shape.

@furkankinyas Do you have a laptop with a touchscreen?

Closing after a number of days without a reply.


Bug: Pipeline addition not working properly in safari browser

📜 Description
User unable add multiple CD pipeline and also plus(+) sign is deflated as well in first addition.
👟 Reproduction steps
1- Open safari browser
2- Create a custom application
3- Add CI and CD pipe line
4- Add multiple CD pipe line
👍 Expected behavior
It should be add properly and also multiple pipeline addition should be there.
👎 Actual Behavior
It is actually while we adding the CD pipe line plus sign visible nearby CI pipeline and after that unable to add multiple
CD pipeline.
☸ Kubernetes version
1.22 microk8s
Cloud provider

🌍 Browser
Chrome
🧱 Your Environment
No response
✅ Proposed Solution
No response
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find any similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Fixed in this PR:  https://github.com/devtron-labs/dashboard/pull/820


Workflow and UI directions

I got started with some quick thumbnail sketches to highlight key information+states for each step of the flow, and explore UI patterns that we can use.

Details of each concept

A) Tabs or wizard like breadcrumbs:
Split the three major steps — Filter, List, Details — into individual tabs, with either some tabs disabled (no details till you select something in the list) or visual cue of which step of the flow you are, and what you can jump to (filled/stroked circles).
What works:

Clear mental model
Highlights the major steps: Filter, Select, Explore

What doesn’t work:

Tabs are usually mutually-exclusive, and the relation between the tabs isn’t as evident
The actual workflow is non-linear, so can’t use a wizard/step-by-step interface — you might jump into the second step (link to results of a filter) or last step (link to a changeset detail)
Leaves no context to quickly jump across changesets — you need to switch tabs to go next

B) Vertical Accordions
Each section expands to the full screen, with one vertical bar each for the other sections. Allows you to hover on the bar to get a glance of that section, which might be helpful in switching from details view to list of changesets and jumping to another changeset.
What works:

Allows you to get a glance of the previous section
Can glance at the whole list of changesets and jump around easily

What doesn’t work:

Narrow column width for glancing would limit what can be shown for each section while keeping a consistent layout
Collapsed states can’t be used to show any detail (except icons or vertical text)

C) Horizontal Accordions
Similar to above, but with the sections stacked horizontally. The bar for filters could show the specific filters that are being used, and the bar for changeset list could show the selected row (and more rows on hover/glance)
What works:

Easy to use a consistent expanded and collapsed layout
Better context for both filters and list
Scope for better transitions

What doesn’t work:

There’s lesser real estate on the Y axis (on a typical wide-screen monitor), so this will take significant screen space to show detailed collapsed sections
The changeset list won’t be easy to view completely in a glance (only a few rows on hover)

E) Map based
Shows bounding box of each changeset in the search result on a map, and allows you to hover to see basic info and click to see details
What works:

Orients you geospatially — could be useful for users that are focusing on one area regularly
Bigger changesets (that could correlate to more impact) will be easier to spot
More details could be shown by adding visual properties to the bbox: thicker bbox for high number of features, colors for more additions/modifications/deletions etc.

What doesn’t work:

Might get very complex for low zoom levels or high number of changesets
Would be difficult to interact with overlapping bbox

Hoverable Edge Panels
Both Filters and Changeset list collapse into small panels on the top and left edge, and hovering on each part shows more details (change existing filter or view detail of other changesets in the list)
What works:

Allows quicker modification of filters
Persistent view of changeset list

What doesn’t work:

Not too valuable to have such interactivity for each part of filter & list
More value in parsing through the whole list at once instead of hovering on each item

Conclusion:
We’ll go ahead with (C), and I’ll work on more detailed designs that I can use to get feedback from users.
cc @ajithranka @kepta @batpad @geohacker

Tagging @willemarcel for visibility

Great work, @rasagy!

Might get very complex for low zoom levels or high number of changesets

We have a default pagination in the API that returns 50 changesets each time, but the user can change the page size.
My impression is that the biggest error of the first version of OSMCHA was to show the results in a list and not in a map. I don't know how was the feedback you had from the users about this, but since we are dealing with geospatial data, I feel it's very important to show the results over a map. If we could use the second screen of D in the C concept, it would sound good for me.
About the filters, some people argued that we have too many options, so it would be good to select the main options and hide the others in an advanced filters button. With the API we have the possibility of defining the area of the filter as a BBOX or to draw/use a MultiPolygon and to filter using any field of the changeset/feature database model.

@rasagy You should join our roadmap meeting on Monday!
I think how we approach OSM validation will also influence the UI design of OSMCha.
IMO less focus on exploration of what is bad and more focus on working through incidents that we know are bad.

Talked with a few more folks in the Data team, and did two rounds of discussions with @ajithranka and @kepta around the interface as well. I feel I have much more clarity on what can work now, adding these wireframes that we used to discuss in the ticket for reference + more feedback:
Filters

A dedicated (nearly full-screen) filters section, that has:

Saved filters (Pick from drop down that shows name + fields modified in it)
Frequently used filters (Preferably grouped together visually — for example the three set of controls for suspicious/flagged changesets shown together)
Other filters (that can go on with a scroll)
Action buttons (Reset, Save for future use, Search)

Once you search, this panel collapses to one line (shown in bottom of the sketch), that shows count of fields modified, as well as list of fields (I’m omitting actual values since they could be very long, like reasons or list of users).
Possible questions to get feedback on:

How should saved filters be shown? (Name+fields? Sorted by last saved or name?)
Should filters that aren’t frequently used be hidden by default (like an advanced filter that @willemarcel suggested)?
How should a saved filter be shown when collapses? What if some fields are changed?

Changeset List (Search Results)

Fairly similar to the current view — I’m keen to not change much here since this works well.
Possible questions to get feedback on:

Does absolute time work better or relative time? Or relative till a point (say 1 week), and then absolute?
Do truncated comments with full text on hover work? Should #tags be highlighted first?
How often would one click on anything apart from the changeset id to view details? Right now you can click on id, username and validator’s username
How would a map view be more useful in your workflow compared to a list view (To gauge if it even makes sense, since the map view will have challenges like how do we paginate, visual encoding etc.)

Changeset Detail

This is the hardest section to crack — based on my discussions there are different ideas on what is needed at this stage. My hypothesis is to show only the current changeset selected, and next changeset (as a way to know what comes next) — everything else in the list accessible through some interaction (hover/scroll/click etc.)
My initial idea was to do A, but the hover-to-show-more-items approach wasn’t working out well. @kepta has been building on top of C which is interesting as well, but would take too much space to show a list that isn’t valuable to persistently see. When seeing details you want to focus only on the details (unlike say a shopping scenario where you would want to peek and compare at other list items).
Based on some feedback from @ajithranka, I’m going to pursue D — each row in the list will expand to have more details show up, while maintaining the context in the list.

Possible questions to get feedback on:

What changeset information is valuable that isn’t being shown in the search result + changeset map? (We show source, editor, imagery in the detail page, and a section each for features & discussions)
Is there value in seeing feature list + discussions at one time, or would an accordion/tabs work better?

Next, I’ll be fleshing these out in more detail and work with @ajithranka & @kepta in identifying components that we need to design for this. I also have enough material to do another round of feedback, and I’m hoping to also talk a bit to the community about this. Will share updates on this as it happens.
cc @batpad @willemarcel @geohacker

but would take too much space to show a list that isn’t valuable to persistently see.
@rasagy could you give more details on why you think it would take too much space.

In my opinion after a certain optimum width, say 790px, we can switch to design C. This way we would have a persistent thing always there for the user. He/she would not need to switch context again and again when switching between 2 totally different views.
Another reason why I think having a sidebar is important, is that the changeset page doesnot really demand a full width. Even if we don't take the sidebar approach, we mind end up having a max-width with centred content. (Similar to the current osmcha).

Also, I like how apple mail does it. I guess the problem with having a sidebar is that we can't show enough. Which I think can be mitigated by incorporating a 2 row layout like the mail app does below.

Again it is a preference (it might be biased as I like to have a persistent UI element around to give context). What do you think?
@rasagy

Just noticed OSM also have a nice changeset sidebar, similar to what we need.
I feel on top of having a changeset list similar to this, we can also have a load more button to load the next pages, instead of having the user click on an array of page number.

cc @planemad

Adding @Rub21  for visibility.

Good work, guys!!
In the case of the concept C, what information would be in the sidebar when a user access the changeset detail url directly?
The saved filters will have an URL as well for sharing between users.

In the case of the concept C, what information would be in the sidebar when a user access the changeset detail url directly?

@willemarcel That’s the slightly hard part: we can’t show all the info we show in the tabular form, so we’ll have to pick a few of the fields. For making a quick prototype, I’m using changeset id, time, user id, created/modified/deleted and reason.

He/she would not need to switch context again and again when switching between 2 totally different views.

Just noticed OSM website also incorporates a changeset sidebar, similar to what we need.

@kepta My concern here is that there are two views of the list of changesets in this approach: A full screen table (like right now) and a collapsed panel on the left. We’ll not only end up hiding a few fields, but also show two different layouts for the same information which isn’t ideal.
Concept D however keeps the user in the same context, expanding a table row. Somewhat like this:

This will allow us to use the table row data (so we don’t need to show fields like username, time etc. again in the details page), and make it easy to view the next changeset in the list.
I’ll work on two quick layouts tomorrow to show the difference.

Awesome ticket! @rasagy so cool.
As a user of osmcha, here is how I am seeing the frontend faster than existing workflow.
The 3 views can be integrated into 2 views. First view being the personalized information for the user, saved filters and filters themselves. Second a being an efficient screen division between changeset list sidebar and details with changeset map.

Filters : Dedicated view
Result changeset list on sidebar + changeset details on the side

Sidebar approach seems to feels appropriate to the need for me.
After the search finishes, from the result page this information would be sufficient

Existing filter: new mapper+all+25-04-1027 to 26-04-2017. Click to change.

Count of: changeset list retrieved + reviewed + harmful

From the sidebar similar to OSM, this information would be great to have

changesetID by username (47563827 - manoharuss)
time since changeset (5hours ago, 3months ago)
A bar or a pie chart showing experience of the user (we need to figure this out)
count of deletions+creations+modifications
thumbs up/down
changeset comment

The otherside of the page can be completely dedicated to detail

All the metadata information regarding the changeset
suspicious features + reason+description of error+JOSM buttons
A larger screen grab for changesetmap

A bigger lift would be the way the frontend can switch between changesets.

Keyboard shortcuts up and down to sift down changesets in the sidebar (detail page will change for each shift)
pressing G or Bfor changeset review should just automatically goto next changeset
prefetching changeset-map linear down, so by the time we open it, it is already loaded

Concept D however keeps the user in the same context, expanding a table row. Somewhat like this:

On this approah ^^ : I feel like we can do a lot more with the screen real estate. This method needs more clicks and how would it look when changing from changeset to changeset with keyboard shortcuts on the screen?
The whole changeset detail, changeset map under the expanding box approach will need a bigger box which means there are fewer in the list of changesets below and above the box.

@rasagy I now understand your reasons behind design D.
Had a couple of doubts,

The current osmcha container is 1108px tall. By most screen standards it would require scrolling to view the entire thing. Design D would hence require at the very least 1108 x  changesetOpen scroll height available, if she chooses to keep some changesets open. I feel this makes it very scroll intensive.
Having a scroll intensive layout would have one more blocker, which is the changeset-map. Changeset map is a real scroll grabber. The user has to consciously make sure while scrolling she doesn't land her mouse pointer on the changeset map, if that happens the scroll stops immediately and you start zooming in out of the map.

The points below assume the design allows two or more changesets open.

From an implementation point of view, this assumption allows multiple gl instances running simultaneously. Which could be a problem.
How does this design support hyperlinking, ie. if a user wants to share the current changeset, how does she share the url? Considering multiple changesets could be open in the scroll view.

Here’s a stab at the concept C & D:
List of changesets

On searching with filters, you’ll get a list of changesets — like the current interface. The only main change here is sorting buttons on the top right, and a toggle for list | map that is optional for now (we can decide this based on the amount of effort it’ll take for us to get this right).
Concept C: Collapsed panel on left

On clicking any table row, the table collapses to the left as shown, with the current row highlighted.
Pros:

Long list of changesets available persistently — works better for workflows where you skip changesets often
Can show more details on demand (hover)
This works great if we show a map view of all the changesets
Separates scroll for list and details

Cons:

There’s a stark difference between the list layout and the collapsed layout — users will have to learn to skim through the two views differently
The collapsed layout will only show a subset of fields, which will lead to frequent interaction with the list for more details of each item
Less width for the detail view means that the changeset map will get harder to use (especially with the info and tables being shown)
Since the left panel shows a subset of information, we’ll have to show the details (shown on hover) in the Details panel

Concept D: Expanded table rows

On clicking any table row, the table scrolls to show that row on the top. Details show up below the row so that the next changeset row is shown in the bottom of the screen (the darkened area is below the fold)
Pros:

Consistent view for the changeset details (as a table row)
Full-width area for the changeset details (and changeset map)
Reuses the table row to show the important details, so they don’t need to be shown again in the details view
Works well for the workflow where user wants to go through the changesets linearly

Cons:

Only the next changeset details are visible without scroll
Table row might truncate some fields — we’ll need multi-line rows or wrap content + show full content for that field on hover as a popup
Multiple scrolls — each section in details (like changeset discussion) might have a scroll if we want to ensure that the whole details section fits in the screen, and changeset map has a scroll as well. This means to scroll down, the user will have to scroll from the next item in the list

@manoharuss Thanks for the detailed feedback! I’m going to expand on your thoughts about what to show in the filter bar on the top.

Keyboard shortcuts up and down to sift down changesets in the sidebar (detail page will change for each shift)
pressing G or Bfor changeset review should just automatically goto next changeset

This makes sense, and is something we can think about in both the concepts — it’ll be definitely useful.

prefetching changeset-map linear down, so by the time we open it, it is already loaded

We discussed this during our initial sync in the pros vs cons for a single page react app vs the current way where we create a new DOM altogether. Once we have our first cut out, we’ll focus more on the optimization using ideas like the one you mentioned.

Feedback from @kepta:

Design D would hence require at the very least 1108 x changesetOpenpx to scroll.

True. If we build a more fluid layout that uses the full-width, we can reduce some of this — the details that take up considerable size will be shown in the table row itself, therefore the details section will need to show action buttons, suspicious/flagged features, and changeset discussions (if any). I think this should be doable in the space.

I feel this makes it very scroll intensive.
Having a scroll intensive layout would have one more blocker

Yes, that’s definitely a con, and once we get to the details I would like to see what is the best way to tackle this. With Changeset map being much more useful now (links to other tools + better properties table), we’ll not let it scroll below the screen even if we use Concept C, so will have to tackle this regardless.

From an implementation point of view, this assumption allows multiple gl instances running simultaneously.

As you mentioned, we’ll stick with a collapsable view (like an accordion) so you can only view one changeset at a time.

How will this impact the productivity of swapping between two changesets.

This is a good point to test out. I’m thinking that we’ll need shortcuts to collapse the detailed view + jump back and forth between changesets.

I got a chance to make a rough prototype of design C and D.
Here is design C.
Here is design D.
@rasagy thoughts?

@kepta Looks good. Based on our quick chat, design D will struggle with scroll context when trying to expand/collapse different accordions. Let’s go ahead with concept C and find ways to make it responsive (to work well with a split screen layout alongside JOSM), and find ways to make the list of changesets on the left less space-consuming.
cc @ajithranka

We have adopted a full screen layout of changeset-map, refer this refactor for the updated changeset-map.
Closing this ticket,


Method to chech tile is ready seems not working properly with Google 3D tiles

Thanks for the great work.  @ebeaufay
I find tiles cannot load correctly in some area with Google 3D tiles.
For example, using your Ultra Globe example, if I move to Eifel Tower in France.
It seems down to when checking child tiles isReady, it hit the case that the Tile does not have children, no meshcontent and material visibility is False. Thus cannot hide the parent tile. Can you shed some light about your inference?
Many thanks.

Yep, I broke something recently, working on a fix right now

it seems like google made some changes and have empty tiles that this code considers as an unloaded tile but it should be an easy fix

Fixed in 9.2.8

was a bit quick.. better fix in 9.2.9

yeah I always forget the key but I change regenerate it no worries.
I may have made a mistake in the fix, try 9.2.12, should be better


sys/linux: cdrom generic description

Rules for "/dev/cdrom". Can find this bug (https://nvd.nist.gov/vuln/detail/CVE-2018-11506) and generate a c-repro for it.
Signed-off-by: Denis Efremov<EMAIL_ADDRESS>

Nice, thanks!


Use new color settings library's responsive input colors

Add in to all inputs in settings menus once this issue is resolved:
https://github.com/ardittristan/VTTColorSettings/issues/11

no need, fixed with CSS instead by setting input background to "unset"


Memory Profiling a Bud service

I'm wondering if there is a way to do a Memory Profiling in a Bud service because I'm noticing a possible memory leak.
I'm reading about the native Golang package pprof, but to do this analysis is necessary to have access to the main package or routers.
The image below shows the service is using more and more memory, it doesn't stop.

I was using the 0.2.5 version and recently updated it to 0.2.8, but it happens in both versions.

Hey @Fuerback, thanks for doing this research! I'd say it's still a bit early days for memory optimization in Bud, but first guess is I saw this the other day: https://github.com/rogchap/v8go/issues/367
Are you able to trigger out of memory (OOM) errors? It might just build up and then garbage collection triggers after a bit.
If you dig any deeper, please let me know your findings!

Hey @matthewmueller, I'm not experiencing any OOM errors.
I'll share if I find something interesting.
Thanks for the quick answer!

V8 isolate is never closed:
https://github.com/livebud/bud/blob/bff7b1fac6e69bacdabf524376ee564c6fdd2cb9/package/js/v8/v8.go#L17

Also, if reusing isolates value should be released after Eval. This could also leak memory. New v8go allows:
defer value.Release()

@dobarx, thanks for your research!
Right now we are reusing the isolates and context for the duration of the service, but they would get cleaned up on close:
https://github.com/livebud/bud/blob/bff7b1fac6e69bacdabf524376ee564c6fdd2cb9/package/js/v8/v8.go#L133-L138
This seems like the right approach though we haven't had the time to do any more in-depth research. My thinking around keeping context around is that since we're running developer-controlled scripts, we're not concerned about security issues. It's a bit faster too IIRC.
You are right that we aren't currently releasing the value:
https://github.com/livebud/bud/blob/bff7b1fac6e69bacdabf524376ee564c6fdd2cb9/package/js/v8/v8.go#L113-L131
value.Release(), does seem promising.


External Downloader Does not Work with mpd urls

[ ] I'm running youtube-dl version 2<IP_ADDRESS>
[ ] External downloader does not work while downloading from an mpd url.

Example:
youtube-dl --verbose -f bestvideo -c -i --external-downloader-args '-n 10' --external-downloader axel -o 'test.mp4' https://dash.akamaized.net/akamai/bbb_30fps/bbb_30fps.mpd
Verbose log
[debug] System config: []
[debug] User config: ['-o', '[%(upload_date)s][%(id)s] %(title)s (by %(uploader)s).%(ext)s', '--external-downloader', 'aria2c', '--external-downloader-args', '-c -j 3 -x 3 -s 3 -k 1M']
[debug] Custom config: []
[debug] Command-line args: ['--verbose', '-f', 'bestvideo', '-c', '-i', '--external-downloader-args', '-n 50', '--external-downloader', 'axel', '-o', 'test.mp4', 'https://dash.akamaized.net/akamai/bbb_30fps/bbb_30fps.mpd']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2<IP_ADDRESS>
[debug] Python version 3.8.5 (CPython) - Linux-5.7.0-2parrot2-amd64-x86_64-with-glibc2.29
[debug] exe versions: ffmpeg 4.3-3, ffprobe 4.3-3, phantomjs 2.1.1, rtmpdump 2.4
[debug] Proxy map: {}
[generic] bbb_30fps: Requesting header
WARNING: Falling back on generic information extractor.
[generic] bbb_30fps: Downloading webpage
[generic] bbb_30fps: Extracting information
[debug] Invoking downloader on 'https://dash.akamaized.net/akamai/bbb_30fps/bbb_30fps.mpd'
[dashsegments] Total fragments: 160
Description
It seems that using an external downloader does not work while downloading from an mpd url. Tested with axel and aria2c.
Did not work on both.

Well, maybe that's not the correct stream source. Because there's no url inside that mpd.
Try to look for another url instead. or m3u8

both axel and aria2c do not support downloading DASH formats so there is nothing to be done.

both axel and aria2c do not support downloading DASH formats so there is nothing to be done.


Porting sanity & distrib script to Python3

Through 2to3.

Tests are looking good, so I'm going to merge this.


Update featured product section

Updated the featured product section, especially :

Switched price div and vendor to be combined in a <dl> for a11y purposes. There's more semantic and a screen reader would read something like :

Product title
Definition list, 3 items
Vendor - XXX
Regular price - XX$
Sale price - X$

Placeholder when no product are selected
Some nit stuff like controlling whitespace and making sure there's no empty tag anywhere.

What's the overlap between this and sections/product.liquid? Can we reduce repetition?

They happen to share most of the same code but schema is different. Unless we start separating schemas from .liquid file, i'm not sure how we can reduce repetition. Suggestions?

Closing because this is now stale


only exec commands on running pods

Fix another bug of watchdog. This should fix the SeedListDown alert in devnet2.

Updated the image watchdog:0.4.11 with the changes from this PR


[WIP] Set ClusterDeploymentCondition for all status

Currently we assume all ClusterDeploymentConditions to have negative polarity, consequently we only set them for the first time if their Status=True. Eliminate this assumption and allow all conditions to be set regardless of their status.
/cc @dgoodwin

Looks like the polarity stuff from the metrics pr slipped in here. Main change looks good, good luck with those tests. :)

Looks like the polarity stuff from the metrics pr slipped in here. Main change looks good, good luck with those tests. :)

Oops! Dropped it...

/assign @dgoodwin
/cc @akhil-rane


Issues in running karma

**I'm submitting an issue with running karma test case. We are using external library angular2localization and on running test using "npm test"  , we are getting below issue. I have searched similar issue in angular2 seed, but could not find it anywhere.
09 11 2016 12:31:12.195:WARN [web-server]: 404: /base/node_modules/angular2localization/bundles/angular2localization.umd.min.js
Chrome 54.0.2840 (Windows 7 0.0.0) ERROR: '(SystemJS) XHR error (404 Not Found) loading http://localhost:9876/base/node_modules/angular2localization/bundles/angular2localization.umd.min.js
Error: XHR error (404 Not Found) loading http://localhost:9876/base/node_modules/angular2localization/bundles/angular2localization.umd.min.js
at XMLHttpRequest.wrapFn [as _onreadystatechange] (http://localhost:9876/base/node_modules/zone.js/dist/zone.js?c35727d0e64913b5669320b167e496fc94fc6928:647:29)
at ZoneDelegate.invokeTask (http://localhost:9876/base/node_modules/zone.js/dist/zone.js?c35727d0e64913b5669320b167e496fc94fc6928:236:37)
at Zone.runTask (http://localhost:9876/base/node_modules/zone.js/dist/zone.js?c35727d0e64913b5669320b167e496fc94fc6928:136:47)
at XMLHttpRequest.ZoneTask.invoke (http://localhost:9876/base/node_modules/zone.js/dist/zone.js?c35727d0e64913b5669320b167e496fc94fc6928:304:33)
Error loading http://localhost:9876/base/node_modules/angular2localization/bundles/angular2localization.umd.min.js as "angular2localization" from http://localhost:9876/base/dist/dev/app/app.component.js'
Current behavior
On running npm test, above issue is coming, and tests is failed.
Expected behavior
There should not be such issue and test case must run.
Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Please tell us about your environment:
Operating system- Windows 7, IDE - Visual studio code, package manager - npm, HTTP server
npm --version = 3.10.8

**Angular Seed Version:
"name": "angular2-seed",
"version": "0.0.0"

Node: node --version =v6.8.0

Please, could you show how you modified files in order to follow the wiki page https://github.com/mgechev/angular-seed/wiki/Add-external-dependency

Is it only when running tests, that the dependency cannot be found.
Can you run npm start without errors in the browser console?
What about production mode: Can you run npm run serve.prod without errors in the browser console?

I have similar issue but with ng2-webstorage, i read the wiki but those two steps required for testing didn't work.

Try to add it to karma.conf.js. Open this file, and in files array add a line like this:
{ pattern: 'node_modules/angular2localization/bundles/angular2localization.umd.min.js', included: false, watched: false },
If not try with something like:
{ pattern: 'node_modules/angular2localization/**/*.js', included: false, watched: false },
Hope it helps!

I already did with ng2-translate and ng2-webstorage and included it also in test-config.js just like described in wiki, same error

I get the files loaded in browser by inserting this  to karma.con, files:
      {pattern: 'node_modules/angular-2-local-storage/dist/angular-2-local-storage.js', included: true, watched: false}
however i got this error:
.... ERROR
  Uncaught ReferenceError: require is not defined
  at node_modules/angular-2-local-storage/dist/angular-2-local-storage.js:2

Finished in 0.497 secs / 0 secs
.....

I think that it is because angular-2-local-storage is a commonjs module and not a systemjs one.
how could I setup it correctlly?
I'm able to run npm start after adding 'angular-2-local-storage': 'node_modules/angular-2-local-storage/dist/angular-2-local-storage.js' to SYSTEM_CONFIG_DEV.paths, doing the same but for test-config.js does not work...

Here @vyakymenko listed the steps required for including a dependency in karma.config.js.


Update data_processing.md

Fix errors and font formatting in the document

Thank you @arthuo, merging the PRs.


@1.3.0, add puppeteerLaunchOptions, update deps

close #179, close #180

Coverage increased (+0.01%) to 99.223% when pulling 5f9d6021da58a55965e047ca3173003da9b3d238 on rc-1.3.0 into 99ca466c860095b9402db70ccd4719a136bef6c5 on master.


Reset elapsed time when PR goes from draft to published

My team uses elapsed time to our internal PR SLA. Our process is to create a DRAFT for developers to react to PR quality checks before considering work ready for review.
Because PRs could be up for days in DRAFT, I want a way to reset the elapsed time when transitioning a PR from DRAFT to PUBLISHED.

Would still really like to see this.


fix the question of SparkSQL call iceberg's expire_snapshots procedur…

…es blocking in local model

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

You're going to need to back up and do more homework here https://spark.apache.org/contributing.html

Can one of the admins verify this patch?


Introduce Setting.Property.Masked for masking sensitive information

Summary of the changes / Why this improves CrateDB
Same as #8714 which was closed as it was based on a brach that got merged
Checklist

[x] User relevant changes are recorded in CHANGES.txt
[x] Touched code is covered by tests
[x] Documentation has been updated if necessary
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

Should we keep this on a feature branch until the new property is in use?

Should we keep this on a feature branch until the new property is in use?

ok, no problem


unpredictable API response for streaming keys/buckets

When performing a bucket or key streaming operation, the riak's API would in some cases:

respond with the full set
respond with a partial set, then {timeout}
respond with an empty set

This is using the HTTP API

Can be seen in clusters where the data on disk greatly (i.e. at least 10 times) exceeds the available RAM dedicated to Riak.

I'm consistently getting partial set, then {timeout}. The workaround (I'm using the Python client) for our use case (delete keys), is to wrap the stream in a try/except block wrapped in a while block, and let the client reconnect.

Are you setting the timeout high enough on the request?


Bit banging SPI implementation

For my MAX7219 crate I've translated the shiftOut function from the Arduino platform to rust, in order to aid with bit-banged serial transfer.
As proposed at https://github.com/rust-lang-nursery/embedded-wg/issues/39#issuecomment-367524427, it might be an idea to move this function to the embedded-hal crate.
I am willing to send a PR to move this to the embedded-hal crate, and extend the implementation to be on par with the Arduino one (https://github.com/arduino/Arduino/blob/master/hardware/arduino/avr/cores/arduino/wiring_shift.c#L40).
But before I make the PR, I'd like to check if there are any objections/ideas/comments regarding this, so here's what I was thinking:

Be on par with the Arduino implementation (MSB+LSB support).
Renaming the function to shift_out instead of shiftOut.
Moving it to the spi.rs file here in embedded-hal, so it's importable like this: use embedded_hal::spi::shift_out.
Implementing the shiftIn function is for another time and PR.
Making clear in the documentation comments that this is a bit-banged implementation.

For reference, my current implementation lives here: https://github.com/maikelwever/max7219/blob/master/src/lib.rs#L127

I love the idea of having bit-banged implementations of common serial protocols -- but does it make sense in this this crate? My understanding is that embedded-hal's purpose is to define an abstraction layer, not to implement anything directly. I'd definitely favor a separate bit-bang-hal crate that implements the protocol, and possible others (like I2C) in the future.
I also think the API bears careful thinking on. Instead of a standalone function, it should probably be a type implementing the embedded_hal::spi::FullDuplex trait. Making it a function forces driver developers to choose between supporting a bit-banged or hardware-based implementation -- which should really be a choice made when putting together an application.
Perhaps something like bit_bang_hal::spi::Spi?

I'd definitely favor a separate bit-bang-hal crate that implements the protocol, and possible others (like I2C) in the future.

:+1: though I would probably put embedded-hal in the name. Alternatively, it could be one of the keywords of the crate.

it should probably be a type implementing the embedded_hal::spi::FullDuplex trait.

I also think it should be a (generic) type implementing the SPI trait(s). Then it can be used with SPI based driver crates.

I've proposed Wave generation trait. Could this be implemented on top of that trait or should it be different?
Obviously, receiving end will need something else, but it doesn't conflict with transmitting.

https://crates.io/crates/bitbang-hal

As stated above, there is a working bitbanging SPI implementation in the bitbang-hal.
I think @sajattack will probably welcome any improvements.
@maikelwever can this issue be closed?

It's been a while for me, but I think this issue can be closed indeed.


Update AWS SDK to 1.12.765

Update AWS SDK to 1.12.765

@mneethiraj Any chance to land this before release-ing Ranger 2.5.0?

@kokosing  - this update will likely not be to be included in Ranger 2.5.0 release; release-candidate #3 is already out for voting. I suggest getting this merged in master branch for 3.0.0 release; if a maintenance release is necessary, 2.5.1 release can be considered.

Patch merged via RANGER-4884.

Thank you!


Addition: new icon for zip filetypes

This change: (check at least one)

[x] Adds a new feature
[ ] Fixes a bug
[ ] Improves maintainability
[ ] Improves documentation
[ ] Is a release activity

Is this a breaking change? (check one)

[ ] Yes
[x] No

Is the: (complete all)

[x] Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
[x] Test suite(s) passing?
[ ] Code coverage maximal?
[ ] Changeset added?

What does this change address?
Added a new filetype icon svg: "filetype-zip.svg"
How does this change work?
One new file that contains the svg information for the ZIP filetype icon.

Hey! Not sure why it's doing that. I added it to the UI kit here: https://www.figma.com/file/sPvnmrxhsJpQqMYrQKwXve/Pharos-UI-Kit?node-id=1805%3A4073
And I believe it is centered as the others are...?
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Dane Hillard @.>
Sent: Friday, May 20, 2022 2:53:47 PM
To: ithaka/pharos @.>
Cc: Lori Lundy @.>; Mention @.>
Subject: Re: [ithaka/pharos] Addition: new icon for zip filetypes (PR #349)
Caution: This message did not originate from within ITHAKA's email system. Please use caution when opening attachments and following links within this message.
@daneah requested changes on this pull request.
I believe the SVG for the new icon is improperly aligned compared to the existing filetype (and perhaps other) icons—note how it hugs further up and left compared to the text than the other icons do. @fswleehttps://github.com/fswlee or @lorilundy711https://github.com/lorilundy711, can you help understand the disparity?
[Screen Shot 2022-05-20 at 14 51 52]https://user-images.githubusercontent.com/1808306/169593636-b30cd605-f37a-46c9-9912-dd340efafabe.png
—
Reply to this email directly, view it on GitHubhttps://github.com/ithaka/pharos/pull/349#pullrequestreview-980557927, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATC2LXQSNTSUFY2GX6K2OODVK7NTXANCNFSM5WQBYFNA.
You are receiving this because you were mentioned.Message ID: @.***>

@Alex @.***> did message me a little bit ago asking for a new svg file so perhaps this is related to his ask for a new asset!
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Lori Lundy @.>
Sent: Friday, May 20, 2022 2:56:41 PM
To: ithaka/pharos @.>; ithaka/pharos @.>
Cc: Mention @.>
Subject: Re: [ithaka/pharos] Addition: new icon for zip filetypes (PR #349)
Hey! Not sure why it's doing that. I added it to the UI kit here: https://www.figma.com/file/sPvnmrxhsJpQqMYrQKwXve/Pharos-UI-Kit?node-id=1805%3A4073
And I believe it is centered as the others are...?
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Dane Hillard @.>
Sent: Friday, May 20, 2022 2:53:47 PM
To: ithaka/pharos @.>
Cc: Lori Lundy @.>; Mention @.>
Subject: Re: [ithaka/pharos] Addition: new icon for zip filetypes (PR #349)
Caution: This message did not originate from within ITHAKA's email system. Please use caution when opening attachments and following links within this message.
@daneah requested changes on this pull request.
I believe the SVG for the new icon is improperly aligned compared to the existing filetype (and perhaps other) icons—note how it hugs further up and left compared to the text than the other icons do. @fswleehttps://github.com/fswlee or @lorilundy711https://github.com/lorilundy711, can you help understand the disparity?
[Screen Shot 2022-05-20 at 14 51 52]https://user-images.githubusercontent.com/1808306/169593636-b30cd605-f37a-46c9-9912-dd340efafabe.png
—
Reply to this email directly, view it on GitHubhttps://github.com/ithaka/pharos/pull/349#pullrequestreview-980557927, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATC2LXQSNTSUFY2GX6K2OODVK7NTXANCNFSM5WQBYFNA.
You are receiving this because you were mentioned.Message ID: @.***>

@acjreno if you can please create a changeset and push it here we can get this merged!


Create Partner Login page for CBOs/TIs

It's just a normal login page, except it's just for CBOs (Community Benefit Orgs) who are our TIs (Trusted Intermediaries).
See https://newmibridges.michigan.gov/s/isd-partnershiplanding?language=en_US, which is a good example of what this page could look like.

Needs additional discussion before work can get started; need to figure out if multi-factor authentication is required for TI.
Lianne to add to city agenda / send email to confirm.

And it also needs to consider what kind of information needs to be put in the “page”.
People who may check out this page, IT(CBO) = application > admin. Are we putting any IT(CBO) information here to let applications look for support? or is there any other website that already provides IT(CBO) information and can point them out? like seattle.gov?

The login part for the partner can be something like this.


untangle scaling xx by weights from setting where xx should be set to zero

What changes does this PR introduce?
Separate scaling xx by weights from setting where xx is set to zero
What is the current behaviour?
Currently, the determination of where xx is being set to zero is tied to only when the logical doscaling is true.  This flag should only be used to check if xx should be scaled by the weight or not, not whether xx should be non-zero or zero.
What is the new behaviour
This fix now untangle these two behaviors: whether doscaling is true or false does not determine whether xx is being set to zero or nonzero.  xx is scaled by weights when doscaling is .true., as intended.  Outside of this doscaling loop, xx will be determined nonzero if the weight is nonzero, else it is set to zero, as intended.
Does this PR introduce a breaking change?
This potentially can break any experiment where the a user has the following combination of setting: (1) control xx_genarr[2d,3d] that were non-zeros outside of landmask, (2) chose to have xx being zero by their weights=0. and (3) chose doscaling=.false. .  The way it should have worked is that the user should get xx=zero where their weights are zero (satisfy (2) above).  However, due to the bug, by setting (3) , they skipped the code determining where xx should be zero, and thus they'd get nonzero xx where weights=0.  If they then read their xx adjustments to force their model, the trajectory of the model will differ now than before.
Other information:
This behavior was fixed by An and Arash for ctrl_map_ini_gentim2d.F in 2017 for xx_gentim2d, and the same fix is now applied to xx_genarr[2d,3d].
Suggested addition to tag-index
Separate scaling xx by weights from setting where xx is set to zero
(To avoid unnecessary merge conflicts, please don't update tag-index. One of the admins will do that when merging your pull request.)

eeks, i sadly got my many branches tangled again, so frustrating! could you help?


Wrong link address

Challenge Name

https://www.freecodecamp.com/challenges/manipulating-complex-objects
Issue Description

The link to json.org (see the Screenshot) should use a HTTP format not HTTPS. (http://json.org/)
Browser Information

Browser Name, Version: Google Chrome, 51.0.2704.106 m
Operating System: Microsoft Windows 10 Home
Mobile, Desktop, or Tablet: Desktop

Your Code

Screenshot

This has been fixed in https://github.com/FreeCodeCamp/FreeCodeCamp/pull/9710 and will reach main website soon.
Thanks and Happy Coding!

what is this>??

some please help me what is this why im getting so much email ??

Hello!
Looks like you may have accidentally subscribed to all notifications for the FreeCodeCamp repository. To stop receiving notifications please visit the subscriptions page or click on the image below and select "Not watching".

We are sorry for your inconvenience!


DHT11/DHT22 sensor library fixed.

Fixed DHT library.
Tested with DHT11 and DHT22 modules.

Thanks @sheinz, this looks really good.
@jsuiker sent the original DHT implementation - do you have any comments on this?

If it works, it's good in my book :)  I'm glad someone got a chance to test both units and make some improvements...


Add mobile id and proximity chip id to folio user record

According to https://uit.stanford.edu/service/registry/data-identifiers proximity can only have 0 or 1 occurrence. It does not say anything about mobileid.


Failed Formatting of Label for Part 2 - Device Registration - Step 2

See image below... The label for part 2 has invalid formatting.

That was weird - I couldn't see what was wrong with that.   I had to literally re-type that step 2 for the formatting to get recognized by the MD interpreter.  Thanks for pointing that out.


Create an get acceleration function similar to get_velocity

see databallpy.features.differentiate get_velocity()

closed in #204


Rewrite to support async/ASGI Django (Waiting for Django ORM to be async)

This issue is waiting for the Django ORM to be async and pushed to master
We all had our hopes up for an async ORM to be pushed with Django 3.2, but this seems unlikely at the moment. Alpha has been released without any mention of async, and the ORM design has not been finalized.
I've created this issue to document and discuss anything related to this.

This can now be started.
I am no longer using Django myself, but I'll be happy to review if someone wants to implement it.
Example async aware middleware for Django can be found in our other repo django-guid


error: failed to select a version for wasm-bindgen

i am trying to make a fetch.
i have these as dependencies:
[dependencies]
iced = { version ="0.3", features = ["async-std", "debug"] }

wasm-bindgen = { version = "0.2.69", features = ["serde-serialize"]  }
js-sys = "0.3.5"
wasm-bindgen-futures = "0.4.23"
serde = { version = "1.0.80", features = ["derive"] }
serde_derive = "^1.0.59"

[dependencies.web-sys]
version = "0.3.4"
features = [
    'Headers',
    'Request',
    'RequestInit',
    'RequestMode',
    'Response',
    'Window',
]

but I keep getting this error when i run cargo update:
> cargo update
    Updating crates.io index
error: failed to select a version for `wasm-bindgen`.
    ... required by package `wgpu v0.7.0`
    ... which is depended on by `iced_wgpu v0.4.0`
    ... which is depended on by `iced v0.3.0`
    ... which is depended on by `gui v0.1.0 (..)`
versions that meet the requirements `=0.2.69` are: 0.2.69

all possible versions conflict with previously selected packages.

  previously selected package `wasm-bindgen v0.2.73`
    ... which is depended on by `js-sys v0.3.50`
    ... which is depended on by `wasm-bindgen-futures v0.4.23`
    ... which is depended on by `gui v0.1.0 (..)`

failed to select a version for `wasm-bindgen` which could resolve this conflict

from i what i decipher from this, iced_wgpu depends on v0.2.69 of wasm-bindgen. but in order for me to make a fetch i need the futures_0_3 feature from wasm-bindgen-futures which is available in wasm-bindgen v0.2.73.

This is because wgpu pins the wasm-bindgen version to 0.2.69.
Try the master branch of wgpu:
[patch.crates-io]
wgpu = { git = "https://github.com/gfx-rs/wgpu-rs.git", rev = "41f44da" }

Is there any other way to make a asynchronous http request though that doesn't depend on these?

Just checking the basics, would a Command or Subscription solve your problem?

I dont think they do. The issue is not only about the request being asynchronous. Afaik I need these crates to make a fetch from inside webassembly. Anyways, I guess I will just wait for them not to pin the older versions of wasm-bindgen.


Problem with config

When I use config.easykeymaps[CKEDITOR.ALT + 81] = String.fromCharCode(190);
I get error: Uncaught TypeError: Cannot set property '4456531' of undefined.
So I wanted to use the second method of defining shortcuts, but how to get this 7 digit number to config certain shortcut?

To install plugin I've put it inside plugin directory and add to my config file config.extraPlugins = 'easykeymap';, do I need to do something more?
Anyway this method works
config.easykeymaps = {         4456530 : String.fromCharCode(174),   //ALT + R         4456515 : String.fromCharCode(169)   //ALT + C     };
as well as 'console.log(CKEDITOR.ALT + "Q".charCodeAt())', so thank you for your help.

Ok, I got it . I may have to update the documentation.
BR
Roni


Adjust notebooks to xclim-testdata changes

Pull Request Checklist:

[ ] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #xyz

[ ] (If applicable) Documentation has been added / updated (for bug fixes / features).
[ ] (If applicable) Tests have been added.
[ ] CHANGELOG.rst has been updated (with summary of main changes).

[ ] Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

Adds the branch name to the xclim.testing.open_dataset calls
Cleans up a few comments within the Jupyter code blocks

Does this PR introduce a breaking change?
No. This fixes an issue arising from changes to the testing data.
Other information:
The next release of xclim will have modified xclim.testing utilities. Though, this only really affects a few code blocks, it's likely that these changes will need to be revisited eventually.

@sarahclaude @juliettelavoie Once this is in, I'll merge the cookiecutter update and the remaining automated PRs should close themselves


chore: append xlgao-zju as chaos mesh committer

Signed-off-by: STRRL<EMAIL_ADDRESS>as https://github.com/chaos-mesh/chaos-mesh/pull/3317 is going to be merged, I create this PR for updating the taichi bot configuration

/ok-to-test

/merge


Hidden Directory?

On Windows,
After creating a new project, e.g with the command "composer create-project laravel/laravel my-cool-app "5.2.*""
The "my-cool-app" directory is seen in the command shell with the "l" command but I can't find the directory with windows explorer?

I'm guessing you downloaded Laravel but in a directory not shared with Windows, which directory did you download Laravel in ?


Update SqlServerDatabaseModelFactory.cs

@yzi2004 - Can you explain why this change is required? It has no functional impact. T-SQL can use implicit column alias name from projection in order by.

@smitpatel  I have  some sql server 2008 R2 database, But for some reason, it is running in compatibility level 80. When I is scaffold db, I get a error [Msg 209, Level 16, State 1, Line 1 Ambiguous column name 'name'.].

@yzi2004 - EF Core supports SqlServer 2008 and above only. i.e. Databases which has compatibility level at least 100. So connecting to database with compat level 90 on SqlServer 2014 instance wouldn't work.
While this change would make scaffolding Db scenario work, the EF Core will still fail at runtime because the SQL we generate from runtime may not adhere to what is supported on older version of SqlServer.
Are you planning to use the same database with EF? Or you are just trying to use scaffolding tool? Can you give us more details on how you plan to use EF Core with your database?

@smitpatel  EF Core supports SqlServer 2008 and above only.  I see.   We have a asp.net mvc site access this database by EF 6.2 , I just want to convert it to asp.net core for study.


vue2 transition does not take effect

migration from 1.x
vue1.x  to vue2
vm.$appendTo to myElement.appendChild(vm.$el)
vm.$remove to vm.$el.remove()
transition does not take effect，component root nodes arouse transition ？

Transitions are no longer triggered via imperative DOM manipulations in 2.0. You need to control them with Vue's rendering mechanism.

那我该如何完成这个动画呢? 尤大 能否给我举个栗子。


Need extra expose PORT

Hi,
You image is great but from my point of view it's missing a EXPOSE 5000 for example.
When you use it with a docker registry, you need an extra port to connect to it.
Could you just add one and update the docs according to this issue?
Thank you

Thank you for the suggestion. Although it's not necessary for it to be on the expose line, since you can still route to 5000 internally with the docker run command, it does explicitly show that the port is available.
I went ahead and added it for clarity.


Possibility to show several messages to the user

notifications list

We can copy from https://github.com/HugoGresse/open-feedback/blob/master/src/admin/notification/


java.io.NotSerializableException: com.linkedin.gradle.python.util.OperatingSystem$Linux

When I was trying to build some custom tasks around building virtual environments I discovered that if I declared outputs, the task would fail.
I've created a branch for reference, and reproduced the issue in the example-project.
Here's a sample of what the error looks like
$ gradle installPythonRequirementsInAnotherVenv

FAILURE: Build failed with an exception.

* What went wrong:
Unable to store input properties for task ':installPythonRequirementsInAnotherVenv'. Property 'pythonDetails' with value 'com.linkedin.gradle.python.extension.PythonDetails@601bcc16' cannot be serialized.
> java.io.NotSerializableException: com.linkedin.gradle.python.util.OperatingSystem$Linux

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 0s
6 actionable tasks: 2 executed, 4 up-to-date

To suppress the error, just comment out this line.
From what I can see OperatingSystem is never serializable, but Gradle only tries to serialize it when outputs are declared for the task.

I was playing around with this, this evening.
I found I was able to resolve this by Removing the Input decorator from the packageExcludeFilter attribute in PipInstallTask.groovy, and also marking the virtualEnvironment, pythonDefaultVersions, operatingSystem attributes in PythonDetails.java as transient.
But I'm not sure that's the best approach.  I'm much more of a Python guy than a JVM guy.
Thoughts?

Nice find! I'm working on a PR right now. I should have it open in the next few hours for you to take a look at.

Thanks!
Just tested and confirmed the issue is resolved in your branch.
I'll close this issue and leave a comment on the PR.


GPUParticles3D can't plot a different mesh at the front end of a trail

Godot version
4.0
System information
Linux
Issue description
The video in the announcement of the GPUParticles feature in this original PR suggests it should be possible to plot an different mesh at the front end of a trail mesh.

Doing the obvious thing of assigning a mesh to the second Draw Pass results in a mess of extra objects, none of which are positioned at the front end of a trail.

(I've tried a lot of the less obvious combinations as well, and none of them work either.  I found this shortcoming as I was attempting to replicate quite a nice magic tinsel particle emitted that someone did in VRChat [unity 2019].)
Steps to reproduce
Open the 3D/Particles Demo Project, go to the Testers/GPUParticlesTrails/GPUParticles3D node and assign a small BoxMesh to Pass 2 of Draw Passes
The following warning will appear on the node:
"Trails enabled, but one or more mesh materials are either missing or not set for trails rendering."
Minimal reproduction project
N/A

Doesn't the example use a subemitter with the Constant mode and an amount of 1 particle?

The example uses a 3D mesh that's rigged in blender


Use Github stars for "tracked repos"

- Do you want to request a feature or report a bug?
Feature
Instead of manually adding GitHub repos that a user is interested in following, Open Sauced could instead utilize a users' starred repos to populate their tracked repo list.
This would likely need to be prefaced with Github authentication.

Trying to think through this and I personally have hundreds of starred repos. I would need some sort of filtering or search to make this feature useful. I am not convinced this is the best route since it would also encourage unstarring repos.
Perhaps adding a searchable or paginated list of starred Repos to the New Repo form would be ideal.

#153 now tracks repos you have contributed to. This is a temporary fix. The plan now will be to present the user a way to create an open-sauced-goals repo to store notes and track repos. Outlined in https://github.com/bdougie/open-sauced/issues/117#issuecomment-526795800


Do you mind if I write a request to be added to F-Droid?

Hi @Artem13327, not at all, would be cool if it is included there!

@Artem13327, here is my information:
AuthorName: Dustin Hendriks
AuthorEmail<EMAIL_ADDRESS>AuthorWebSite: https://www.linkedin.com/in/dustinhendriks/
WebSite: https://github.com/jetspiking/AndME
IssueTracker: https://github.com/jetspiking/AndME/issues
(ApplicationName: AndME)

Ah, is this a requirement? I'd rather not adjust my repository with (for the application irrelevant) data just because F-Droid needs it.

There you go :smiley:

Thanks @Artem13327 for contacting @IzzySoft 👍

@jetspiking gladly done! But not being an Android dev myself, I'm afraid this was all I can contribute in terms of PRs (especially givven the many tasks already on my table).
@Artem13327 depends. It's a means of contact. The only other ones are Gmail (I'd never reach out on that, nor on Hotmail & Co, for privacy reasons; if you send a mail from such my server would auto-reply for me suggesting you to use a "decent mail provider") or Github (which some people hesitate using for the very same reason). So a libre social network (like a Fediverse instance) might be welcome, if there are no other means.
Btw: Where did you see it used in AuthorWebSite? All I have set here is:
AuthorName: Dustin Hendriks
AuthorEmail<EMAIL_ADDRESS>SourceCode: https://github.com/jetspiking/AndME
IssueTracker: https://github.com/jetspiking/AndME/issues
Changelog: https://github.com/jetspiking/AndME/releases
Donate: https://www.buymeacoffee.com/DustinHendriks

Ah, above in the comment – and yes, for those I agree (we're speaking F/LOSS here, and all those services are proprietary – would be nice to see at least a single libre one; many f/loss devs are e.g. somewhere on the Fediverse). Also Website should not point to the Github account (that can already be deduced from SourceCode).
Btw: For donation links you might wish to take a look at Github's FUNDING.yaml (to be placed either into /.github or right in the repo root). Depending which services you use:
# These are supported funding model platforms

github: [ jetspiking ] # Github Sponsors if you have enrolled to that
patreon: # Replace with a single Patreon username
open_collective: # Your OpenCollective handle
ko_fi: # Replace with a single Ko-fi username
tidelift: # Replace with a single Tidelift platform-name/package-name e.g., npm/babel
community_bridge: # Replace with a single Community Bridge project-name e.g., cloud-foundry
liberapay: # Your Liberapay UserName
issuehunt: # Replace with a single IssueHunt username
otechie: # Replace with a single Otechie username
lfx_crowdfunding: # Replace with a single LFX Crowdfunding project-name e.g., cloud-foundry
custom: ['https://www.buymeacoffee.com/DustinHendriks'] # up to 4 URLs

That would be picked up automatically by F-Droid (and also by my updater), giving you an easy way to update it when needed.


[Blameable] Query error when use blameable

Query produced add extra _id in column
Feb  9 20:57:43 |CRITI| REQUES Uncaught PHP Exception Doctrine\DBAL\Exception\InvalidFieldNameException: "An exception occurred while executing 'SELECT k0_.id AS id_0, k0_.kode AS kode_1, k0_.nama AS nama_2, k0_.created_by AS created_by_3, k0_.updated_by AS updated_by_4, k0_.deleted_by AS deleted_by_5, k0_.created_at AS created_at_6, k0_.updated_at AS updated_at_7, p1_.id AS id_8, p1_.kode AS kode_9, p1_.nama AS nama_10, k0_.propinsi_id AS propinsi_id_11, p1_.created_by_id AS created_by_id_12, p1_.updated_by_id AS updated_by_id_13, p1_.deleted_by_id AS deleted_by_id_14 FROM kabupaten k0_ LEFT JOIN propinsi p1_ ON k0_.propinsi_id = p1_.id ORDER BY k0_.id ASC LIMIT 30':  SQLSTATE[42S22]: Column not found: 1054 Unknown column 'p1_.created_by_id' in 'field list'"

This is hardly useful.
Failing test case is needed.

@TomasVotruba : i dont know how to solve this problem, even after read the event subscriber
Just add minimal config like doc and you will get error like that

Copy this test,
https://github.com/KnpLabs/DoctrineBehaviors/blob/master/tests/ORM/BlameableTest.php
modify it so the query is incorrect,
get query and compare it to desired one

I have the same problem
Symfony 5.04 with EasyAdmin. Migration went through OK, but when I'm trying to list. edit or add items in EasyAdmin it comes up with an error:
`An exception has been thrown during the rendering of a template ("An exception occurred while executing 'SELECT u0_.id AS id_0, u0_.name AS name_1, u0_.deleted_at AS deleted_at_2, u0_.created_by_id AS created_by_id_3, u0_.updated_by_id AS updated_by_id_4, u0_.deleted_by_id AS deleted_by_id_5 FROM unit_type u0_ WHERE u0_.id IN (?, ?, ?) ORDER BY u0_.id DESC' with params [3, 2, 1]:
SQLSTATE[42S22]: Column not found: 1054 Unknown column 'u0_.created_by_id' in 'field list'"`

Failing test case in PR is needed

For some reason Blameable is attempting to fetch 'created_by_id', which isn't created when the schema is updated.  It really shouldn't be appending _id onto the end of the column name.  I'm having this issue as well Symfony 5.0.5, doctrine-behaviors 2.0

Correct, but it seems to work fine for some entities in my project. I have implemented my own UserBundle with Blameable and it saves the details fine in database, but not for the entities in App (both entities has been setup in the same way). Could the location be an issue?

In BlameableSubscriber there is a function mapEntity with if condition and if the first requirement is met the mapping to the table column is set to the created_by_id, but for else the column is created_by
if ($this->userProvider->provideUserEntity()) {
    $this->mapManyToOneUser($classMetadataInfo);
 } else {
    $this->mapStringUser($classMetadataInfo);
}

then in function mapManyToOneWithTargetEntity we have the below:
$classMetadataInfo->mapManyToOne([
    'fieldName' => $fieldName,
    'targetEntity' => $userEntity,
    'joinColumns' => [
         [
             'onDelete' => 'SET NULL',
        ],
    ],
]);

Maybe the array passed to Doctrine\ORM\Mapping\ClassMetadataInfo mapManyToOne() needs setting the column name?

I was just tinkering with this today with a filter I was writing.  There's a few condition checks in the ClassMetadataInfo class that determines it's 'association'/'relationship'.  Which is where it appends _id to the $columnName.   I think the BlameableSubscriber may need more/less logic to determine the user's relationship to the object.  I some how got it trying to query created_by_id_id at one point.  I've since gave up and reverted to Gedmo.  Meh

It seems that was fixed and merged #491 but there is no new version with this fixes. Do you know when new release will be made?

I confirm that switching to dev-master instead of 2.0.1 solved the issue for me

Closing as resolved


Add content based on consolidation of Petr's & Artyom's work

Merge following two repositories
https://github.com/petrkotas/openshift-env
https://github.com/cynepco3hahue/kubevirt-ansible
As a result this repository contains Ansible roles & playbooks to deploy KubeVirt on

stand alone K8S
OpenShift deployment

cc @cynepco3hahue @petrkotas
We need to have some discussion how to proceed with merging process.

@petrkotas @lukas-bednar I can see that Petr deployment concentrates at most on the vagrant, so maybe we can add roles from my repository, Vagrantfile from the Petr repository and adapt this Vagrantfile to use my roles?

Also, we can take my README.md and add a section for vagrant deployment.

@cynepco3hahue ok, for start think you can push your changes here from your old repo ...
cd cynepco3hahue/kubevirt-ansible
git remote add kubevirt-incubator git@github.com:kubevirt-incubator/kubevirt-ansible.git
git push -f kubevirt-incubator master

or you can consider to transfer ownership of your repo, to kubevirt-incubator.

@cynepco3hahue Yes this was exactly my thinking. That we adapt your roles and use my vagrant :).
Best would be start with your repository as @lukas-bednar wrote and than add my changes.
I can do that so we have a starting point.

@petrkotas @lukas-bednar I added #4, so if it looks fine we can merge it and go on with Petr repository.

I have taken look at #4 I can start on that.

@petrkotas @lukas-bednar I think we added all base content, so I will close this one.


feat(CORS): set allow private network header

Summary of Changes
Allow private networks as an option in CORS
Related Issues
#2381
Pull Request Checklist
This is just a reminder about the most common mistakes.  Please make sure that you tick all appropriate boxes.  But please read our contribution guide at least once; it will save you a few review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.

[ ] Applied changes to both WSGI and ASGI code paths and interfaces (where applicable).
[ ] Added tests for changed code.
[ ] Prefixed code comments with GitHub nick and an appropriate prefix.
[ ] Coding style is consistent with the rest of the framework.
[ ] Updated documentation for changed code.

[ ] Added docstrings for any new classes, functions, or modules.
[ ] Updated docstrings for any modifications to existing code.
[ ] Updated both WSGI and ASGI docs (where applicable).
[ ] Added references to new classes, functions, or modules to the relevant RST file under docs/.
[ ] Updated all relevant supporting documentation files under docs/.
[ ] A copyright notice is included at the top of any new modules (using your own name or the name of your organization).
[ ] Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.

[ ] Changes (and possible deprecations) have towncrier news fragments under docs/_newsfragments/, with the file name format {issue_number}.{fragment_type}.rst. (Run towncrier --draft to ensure it renders correctly.)

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
PR template inspired by the attrs project.

Ok! Thank you! I Will change that!

I added a test in TestCustomCorsMiddleware, but I am not sure if it was supposed to be in the TestCorsMiddleware
I put it in custom because it's an optional value and not default. Also I didnt change any of the existing tests, should I also add like
assert 'Access-Control-Allow-Private-Network'.lower() not in h in the existing tests?

It seems that our tests fail with the newly released websockets 14.0, this is not caused by your changes. We'll try to address this separately.

okk


filepond input UI is broken with Bootstrap 4.5

  div.flex-column
          div.input-group.mb-3
            input.form-control.filepond(type='file')

This is working with bootstrap 4.0, but upgraded to 4.5 and it looks like this

after upload:

upgrade to latest filepond 4.25.1 and remove .input-group solves this problem


Adapter 1.5.0 stop working with JS-Controller 7.0.3

I have updated my iobroker to js-controller 7.0.3. The harmony adapter stops working after the update. Adapter shows all condition green, but my harmony hub is not discovered.

Thanks for debug log. Sad to say that it does not show any problem.
As there have been no changes between js-controller 6 and js-controller 7 which obviously could cause this problem, please open a topic at iobroker forum (https://forum.iobroker.net) and post a link here so that we can get an isea if this problem effects more users.
And for completness: Did you update any other component at the same time?
Which js.controller did you use beforw when harmony was working?
Did you update O/S or node ?

The following topic at forum looks related to this issue
And most likely cdrtom and tom0 at forum are identical.
So I will close here as the problem seems to be solved according to linked forum topic.


npm install error[install in raspberry pi with raspbian acrroding to debian ]

Hi , I try to install codecombat in raspberry pi 3 , and get error when command "npm install", this is the log .
npm-debug.log

Try manually installing bower first?


Remove Plus for Fully Evolved Forms

Just to make sure I understand it correctly - the Plus sign under the candy on the Species view is to show how many pokemon you need to catch before you get the fully evolved form, correct? So if that's the case, I don't think the Plus should show up for fully evolved forms.

Your understanding is correct, but I'm not getting a + for any fully evolved Pokemon... Are you working from the most recent commit of master?

Just a bit of proof, there's a few full evolves on this screen:

Yes. And this is what it looks like on mine:

Nvm, after a hard refresh, they went away.

Ah, that's a cache issue. Open up dev tools in Chrome(Ctrl + shift + i on Windows and Linux, cmd + opt + i on Mac), then click and hold refresh. You should see the option to 'Empty cache and hard reload'. Click that and log back in. That should resolve it.

Sorry, I changed the condition to hide those + signs in the push for #86

Got ya. All good now =D


[CIVP-13523] Escaping in read_civis has changed from v1.6.0 to v1.7.0 of the python client

@keithing merged the other PR and had to resolve a conflict with the CHANGELOG


Fix docs build again

Should we close this PR?

No @bobbinth you can approve it ... it's just a small name change, we reverted it because the build broke but that was for another reason..

Unless, of course, it's been done elsewhere, in which case, yes, close. @Dominik1999 may know better

We can merge this of course, but as far as I can tell, this PR has no changes. Or am I missing something?

We can merge this of course, but as far as I can tell, this PR has no changes. Or am I missing something?

It had one change which was then reverted. It would be good to get this in if it's not yet in. However, it's another PR one with a ton of merge conflicts I can't deal with because they're files outside of my remit. So let's close.


v9 - Proposal to ensure addons are compatible with v9 before updating a site or installing addon

My experience of running v8 addons on v9rc sites so far has been mixed.
Simple blocks can look OK on the page, but the block edit dialogs usually need some work to look good because form controls, floats, bootstrap labels and font awesome icons have all changed.
More complex edit dialogs, dashboard pages and code that integrates with other core functionality need a lot of work. Not many major changes, but a big accumulation of all the time tracking down many little changes and testing.
Many sites owners will update from v8 to v9 without thoroughly checking addon compatibility first, then either discover that dialogs etc are seriously glitched or brick their site. We get a rush of ‘failed update’ forum posts on every major core update and I can foresee v9 being a record breaker.
Many v9 fresh install site owners will also try and install addons/themes that have not been updated for addon compatibility and consequently glitch or brick their site.
My proposed solution is to have a flag in package controllers confirming maximum version compatibility. If not set, it will default to the previous major core version.
Package install and the core upgrade procedure in v9 can then check that flag and refuse to update unless all packages are already flagged v9 compatible.
for example

// core base class
abstract class Package implements LocalizablePackageInterface{

   public function getMaxAppVersion(){
      if(isset($this->maxAppVersion)){
         return $this->maxAppVersion;
      } else {
         // sets a default of v8.latest that prevents any un-confirmed v8 package being installed on v9
         // max handles special case of v7 addons already in use on v8 sites
         return max( 8, extract_major_version_from($this->appVersionRequired ));
      }
   }
}

// An updated package
class Controller extends Package
{
    protected $appVersionRequired = '8.5.2';
    // This package has been updated by the developer and confirmed as v9 compatible,  but will not be compatible with v10.
    protected $maxAppVersion  =  '9';
    //....
}

// A package that has not been updated
class Controller extends Package
{
    protected $appVersionRequired = '8.5.2';
    // This package has not been updated. It defaults to only being compatible with v8
    //....
}

// A package built for v9
class Controller extends Package
{
    protected $appVersionRequired = '9.0.0';
    // This package has been built for v9. It is automatically compatible with all v9, but will not be compatible with v10.
    //....
}

This flag can also be used in the marketplace to provide a big 'v9 Compatible' rosette on updated packages.
The mechanism is automatically capable of handling further major version updates.
A beneficial side effect of this flag will be to weed out addons that are not actively maintained in the marketplace.

@JohntheFish , I think you have to add a $minAppVersion as well, because v9 packages may not work on v8 or their styling may not be working in v8.

I have asked a question about this for the September Town Hall
https://concrete5.slack.com/archives/CDX2TLZ6E/p1630161580002100

My question missed the town hall. Some discussion on slack when I posted
https://concrete5.slack.com/archives/CDX2TLZ6E/p1630161580002100

On forums, see https://forums.concretecms.org/t/marketplace-warning-or-separate-section-for-v9/811/5

Well, you seem to have strong opinions about this. Clearly my response to this proposal isn't something you're interested in discussing so I'm going to let others continue to this.

My apologies for appearing heavy handed. That was not my intent. I do like the prospect of being able to check compatibility before attempting and update. But I don't think such a check can rely on developers maintaining 'Map Files to Compatible Versions'.

'Map Files to Compatible Versions' has become unworkable and is avoided by developers. With v9 the information in that section will default to 'compatible' for many marketplace items that have not even been updated to work with v8.
Experience of updating for v9 by myself and other regular marketplace developers is that the nearly all packages will need at least some changes in order to avoid breaking either the addon or the site. The changes required are rarely just cosmetic to the edit dialogue.

Whatever mechanism we end up with, the key requirement is that a package developer needs to make a positive assertion that a package is compatible with v9. All packages ignored by their developers, abandoned or incompatible, would then be excluded from v9 by default.
Implementing $maxAppVersion and requiring it to be set for v9 (defaulting to v8.* where not set) would achieve that requirement while coexisting with existing mechanisms.

I understand the effort behind this, but I just don't think this is a workable approach. We've already cut off backward compatibility for add-ons from 5.6 to 5.7, and you're asking me to do it again. I understand that it's a different situation because the developer can just mark the add-on as compatible (whereas with the 5.7 shift there was obviously no way to do that without rewriting the add-on) but by default the add-on is what, unavailable?
I also don't really understand how this will help in a practical sense. Let's say a developer doesn't keep up with the "compatible versions" checkbox on the marketplace. So their add-on is then served by default to someone buying it for v9. What happens when they download it and the add-on code itself doesn't let them install it? That sounds like a nightmare.
I'm not willing to make the assumption that there is a huge population of wholesale broken add-ons out there. Will the updates in dependencies break some more complex add-ons? Absolutely, and that's not ideal, but it's not something we can really help given the way we're hooked into some external dependencies. Are there simpler add-ons that are also broken in v9? If that's the case, I'd rather figure out some simple ways to help those add-ons not be broken, if at all possible. I'm also exploring better backward compatibility for themes to ensure that they are not broken post-update.
If there is indeed a huge population of broken add-ons, rather than just disallowing all add-ons that aren't flagged as compatible, I'd much rather do the following.

When v9 is added to the version list, do NOT mark existing add-ons as compatible by default. That means v9 shows up in the marketplace version selector, but add-ons are not just opted in as compatible with it.
Do not change the way add-ons actually install in Concrete.

What would this do? It would disallow developers from selling for version 9 unless they specifically opted in. This would force them to vet the add-on.
By the time a user actually has an add-on on their site and is trying to install it, I don't see how a version check at that time is going to help them, unless it also matches the compatibility of the versions listed on marketplace.concretecms.com

I think your note (1) would be workable. I realise marketplace integration from a site checks the version list for package install/update, but does the core updater also check that before updating?
We have 2 site-breaking scenarios:

A v8 site with addons installed updates to a v9 core and breaks because of incompatible addons - only be recoverable from a backup
A v9 site then installs an addon that is not compatible with v9 - usually recoverable by uninstalling

When v9 is released, I foresee (1) as being the big risk. Once v9 has been around for a while, the risk of (1) will diminish and (2) will grow as new sites install addons.
When implementing, please consider the long term process. Developers shouldn't need to reassert v9 compatibility with every subsequent addon update or every subsequent minor core version. Once v9 compatibility has been confirmed, when a developer subsequently uploads a new addon version it should automatically apply to all listed core versions (the current default behaviour unless a developer has decided to set version compatibility manually). If a developer maintains a single addon code base across 50 core versions, they shouldn't have to set 50 selects each time they update their addon.
When you are working on the code in that section of the marketplace, anything you can do to improve the usability of managing the long list of selects against core versions will be good for long-term developers. Perhaps a latest option? Perhaps a button to set all? Perhaps changing it to something other than a long list of core versions? I don't know what is feasible with the underlying data.

By the time a user actually has an add-on on their site and is trying to install it, I don't see how a version check at that time is going to help them, unless it also matches the compatibility of the versions listed on marketplace.concretecms.com

With that in mind, what is the difference between the proposed $maxAppVersion and the current $appVersionRequired property?
https://github.com/concrete5/concrete5/blob/c8d75f8b2b2ff3bdf06b088eeff2dfac2a86605a/concrete/src/Package/Package.php#L797
Isn't $appVersionRequired also parsed by the marketplace uploader?
Historically, it has always been much easier for those outside of Portland Labs to get a change made to the cms core than it has been to get Portland Labs to make a change to the marketplace site. Hence my enthusiasm for $maxAppVersion and mechanisms divorced from the marketplace site. It enables everyone to get involved in using and enhancing.

I'm afraid while you concentrate on a technical side of the issue, my original concern has been lost in the technicalities.
I believe there should be a warning in the Market Place saying that (some) v8 packages may not work in v9 out of the box unless clearly stated otherwise to avoid customers paying for a package, realizing it doesn’t work or looks ugly and then demanding a refund thus getting the package for free. Or a separate section should be made for v9 packages in the MP.
I’ve just checked a couple of my big applications in v9.  So although versioning is good, who knows when or if it will be implemented. But I think the warning must be put in the MP now regardless.
Or do I have to edit all my package pages and put the warning myself that they don't work in v9?

We have since placed a warning in the marketplace and I consider this resolved.


import from nixpkgs and registry

I looked at automating this but is seems like it will be a bit problematic, had to drop a few to avoid errors like in https://github.com/numtide/nixpkgs-terraform-providers-bin/pull/6 where the provider has been renamed/moved but the old one still exists on the registry.

good stuff, thanks


create folder path recursively if missing when generating files

before this, if we specified a path to writing generated files that don't exist the file creation fails.
{ [Error: ENOENT: no such file or directory, open '[....removed]/src/graphql/schema/local/__generated__/schema.graphql']
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path:
   '[....removed]/src/graphql/schema/local/__generated__/schema.graphql' }

Thanks! I believe the recursive option for was only added recently, but I presume this shouldn't cause any errors if running on older node versions.


Epic - Implementation of RFC 0020: Qiskit release cycle and versioning

Tasks to implement RFC 0020: Qiskit release cycle and versioning
The implementation of this RFC is to extend the documentation:

[x] Initial documentation release https://github.com/Qiskit/documentation/pull/396
[x] Include QPY support https://github.com/Qiskit/documentation/pull/1563

Implemented and closed by 7a74b08793475b7b0142d3a3f7142cabcfd33ab8