bug: Redundant calls to refresh endpoint of plex

Description of the bug
So my current setup is:

Radarr grabs a movie and imports it (trigger in autopulse)
bazarr uses signalr connection to radarr and notices the new file, so starts looking for subtitles
bazarr downloads a subtitle, manual trigger in autopulse
bazarr downloads another subtitle, manual trigger in autopulse (etc etc)

The manual url bazarr uses:
http://<IP_ADDRESS>:2875/triggers/manual?path=%2fmnt%2fmvanbaaknas%2fSeries%2fPeda%c3%a7o+de+Mim+%282024%29+%5bimdb-tt27505298%5d%2fSeason+01'
Logs of autopulse registering the triggers:
2024-09-25T15:48:21.245219Z DEBUG autopulse::routes::triggers: added 1 file from manual trigger
2024-09-25T15:48:21.245311Z  INFO actix_web::middleware::logger: <IP_ADDRESS> "GET /triggers/manual?path=%2fmnt%2fmvanbaaknas%2fSeries%2fPeda%c3%a7o+de+Mim+%282024%29+%5bimdb-tt27505298%5d%2fSeason+01 HTTP/1.1" 200 429 "-" "curl/8.7.1" 0.010673
2024-09-25T15:48:28.622728Z DEBUG autopulse::routes::triggers: added 1 file from manual trigger
2024-09-25T15:48:28.622806Z  INFO actix_web::middleware::logger: <IP_ADDRESS> "GET /triggers/manual?path=%2fmnt%2fmvanbaaknas%2fSeries%2fPeda%c3%a7o+de+Mim+%282024%29+%5bimdb-tt27505298%5d%2fSeason+01 HTTP/1.1" 200 429 "-" "curl/8.7.1" 0.003517
2024-09-25T15:48:37.469985Z DEBUG autopulse::routes::triggers: added 1 file from manual trigger
2024-09-25T15:48:37.470066Z  INFO actix_web::middleware::logger: <IP_ADDRESS> "GET /triggers/manual?path=%2fmnt%2fmvanbaaknas%2fSeries%2fPeda%c3%a7o+de+Mim+%282024%29+%5bimdb-tt27505298%5d%2fSeason+01 HTTP/1.1" 200 429 "-" "curl/8.7.1" 0.004094
2024-09-25T15:48:55.249892Z DEBUG autopulse::routes::triggers: added 1 file from manual trigger
2024-09-25T15:48:55.249986Z  INFO actix_web::middleware::logger: <IP_ADDRESS> "GET /triggers/manual?path=%2fmnt%2fmvanbaaknas%2fSeries%2fPeda%c3%a7o+de+Mim+%282024%29+%5bimdb-tt27505298%5d%2fSeason+01 HTTP/1.1" 200 429 "-" "curl/8.7.1" 0.003927

All triggers are like 1 or 2 minutes from each other. The trigger timers thing works ok as autopulse worker only sends the files to the targets after X minutes after the last trigger for a directory/file.
BUT ... autopulse sends multiple refresh requests for the same directory to plex. While I would expect it to do only 1 per directory:
logs from the nginx that is running as reverse proxy of my plex instance:
2a02:a443:381e:1::240 - - [25/Sep/2024:17:58:04 +0200] "GET /library/sections HTTP/1.1" 200 6316 "-" "-" "-"
2a02:a443:381e:1::240 - - [25/Sep/2024:17:58:04 +0200] "GET /library/sections/13/refresh?path=%2Fmnt%2Fmvanbaaknas%2FSeries%2FPeda%C3%A7o+de+Mim+%282024%29+%5Bimdb-tt27505298%5D HTTP/1.1" 200 0 "-" "-" "-"
2a02:a443:381e:1::240 - - [25/Sep/2024:17:58:04 +0200] "GET /library/sections/13/refresh?path=%2Fmnt%2Fmvanbaaknas%2FSeries%2FPeda%C3%A7o+de+Mim+%282024%29+%5Bimdb-tt27505298%5D HTTP/1.1" 200 0 "-" "-" "-"
2a02:a443:381e:1::240 - - [25/Sep/2024:17:58:04 +0200] "GET /library/sections/13/refresh?path=%2Fmnt%2Fmvanbaaknas%2FSeries%2FPeda%C3%A7o+de+Mim+%282024%29+%5Bimdb-tt27505298%5D HTTP/1.1" 200 0 "-" "-" "-"
2a02:a443:381e:1::240 - - [25/Sep/2024:17:58:04 +0200] "GET /library/sections/13/refresh?path=%2Fmnt%2Fmvanbaaknas%2FSeries%2FPeda%C3%A7o+de+Mim+%282024%29+%5Bimdb-tt27505298%5D HTTP/1.1" 200 0 "-" "-" "-"
2a02:a443:381e:1::240 - - [25/Sep/2024:17:58:04 +0200] "GET /library/sections/13/refresh?path=%2Fmnt%2Fmvanbaaknas%2FSeries%2FPeda%C3%A7o+de+Mim+%282024%29+%5Bimdb-tt27505298%5D HTTP/1.1" 200 0 "-" "-" "-"

with autoscan this results in only 1 HTTP call to the refresh endpoint with that directory.
Steps To Reproduce
Contact the autopulse daemon with the same path several times, each within the timeout period from the other.
For example, run the following command 2 or more times in a couple of seconds and watch the outgoing http calls to plex.
Expected: only one per directory
Actual: every trigger results in a http request to plex, even if the directory/file is the same
curl --basic --user admin:password 'http://<IP_ADDRESS>:2875/triggers/manual?path=%2fmnt%2fmvanbaaknas%2fSeries%2fPeda%c3%a7o+de+Mim+%282024%29+%5bimdb-tt27505298%5d%2fSeason+01'

Additional Information
Running autopulse 1.0.1 with the following configuration:
app:
  hostname: <IP_ADDRESS>
  port: 2875
  database_url: sqlite:///var/db/autopulse/autopulse.db
  log_level: debug

auth:
  username: admin
  password: password

opts:
  check_path: false
  max_retries: 5
  default_timer_wait: 300
  cleanup_days: 10

triggers:
  manual:
    type: manual

targets:
  plex:
    type: plex
    url: https://my.plex.server
    token: SUPERSECRITNOTGOINGTOSHAREHERE

webhooks: {}

I think the best way to solve this is to just check that the path is not already in the database in a pending process state. I'll add that in a PR

I think the best way to solve this is to just check that the path is not already in the database in a pending process state. I'll add that in a PR

That would indeed be the best option I guess.
As long as it does reset the timer though ;)

Yep, it should still reset the timer since it will just return the existing event

Feel free to check out pr-46 once this finishes

Feel free to check out pr-46 once this finishes

I dont use docker. But I can check later today.

Feel free to check out pr-46 once this finishes

I can confirm that it now sends only 1 refresh:
2024-09-27T08:46:30.183013Z  INFO autopulse: 💫 autopulse starting up...
2024-09-27T08:46:30.186775Z  INFO actix_server::builder: starting 12 workers
2024-09-27T08:46:30.186790Z  INFO actix_server::server: Tokio runtime found; starting in existing Tokio runtime
2024-09-27T08:46:30.186798Z  INFO actix_server::server: starting service: "actix-web-service-<IP_ADDRESS>:2875", workers: 12, listening on: <IP_ADDRESS>:2875
2024-09-27T08:46:37.667117Z DEBUG autopulse::routes::triggers: added 1 file from manual trigger
2024-09-27T08:46:37.667204Z  INFO actix_web::middleware::logger: <IP_ADDRESS> "GET /triggers/manual?path=%2fmnt%2fmvanbaaknas%2fSeries%2fPeda%c3%a7o+de+Mim+%282024%29+%5bimdb-tt27505298%5d%2fSeason+01 HTTP/1.1" 200 429 "-" "curl/8.7.1" 0.008685
2024-09-27T08:46:50.701050Z DEBUG autopulse::routes::triggers: added 1 file from manual trigger
2024-09-27T08:46:50.701148Z  INFO actix_web::middleware::logger: <IP_ADDRESS> "GET /triggers/manual?path=%2fmnt%2fmvanbaaknas%2fSeries%2fPeda%c3%a7o+de+Mim+%282024%29+%5bimdb-tt27505298%5d%2fSeason+01 HTTP/1.1" 200 429 "-" "curl/8.7.1" 0.000375
2024-09-27T08:47:20.030644Z DEBUG autopulse::routes::triggers: added 1 file from manual trigger
2024-09-27T08:47:20.030714Z  INFO actix_web::middleware::logger: <IP_ADDRESS> "GET /triggers/manual?path=%2fmnt%2fmvanbaaknas%2fSeries%2fPeda%c3%a7o+de+Mim+%282024%29+%5bimdb-tt27505298%5d%2fSeason+01 HTTP/1.1" 200 429 "-" "curl/8.7.1" 0.000290
2024-09-27T08:47:32.948891Z DEBUG autopulse::routes::triggers: added 1 file from manual trigger
2024-09-27T08:47:32.948959Z  INFO actix_web::middleware::logger: <IP_ADDRESS> "GET /triggers/manual?path=%2fmnt%2fmvanbaaknas%2fSeries%2fPeda%c3%a7o+de+Mim+%282024%29+%5bimdb-tt27505298%5d%2fSeason+01 HTTP/1.1" 200 429 "-" "curl/8.7.1" 0.000280
2024-09-27T08:48:03.330211Z  INFO autopulse::service::runner: sent 1 file to targets

@mvanbaak Sorry to ping you on a fixed issue, but I was wondering, how did you configure Bazarr to trigger notifications to Autopulse? (i.e http://<IP_ADDRESS>:2875/triggers/manual?path=%2fmnt%2fmvanbaaknas%2fSeries%2fPeda%c3%a7o+de+Mim+%282024%29+%5bimdb-tt27505298%5d%2fSeason+01)
The closest I got was using the Form notification type:
form://admin:password@autopulse_host:2875/triggers/my_bazarr?:title&:type&:version&:message&method=get&attach-as=path
But it seems attach-as doesn't work as I hoped, as it seems path is always missing ("Query deserialize error: missing field path").
Tried also with JSON type, but same issue, no file attached, no way to extract the path.
Looking at the default payloads in Bazarr notifications, it seems to pretty much always be some plain text (i.e "MyMovie : English subtitles manually downloaded from embeddedsubtitles with a score of 100.0%."),
Thus I don't really see how to extract the file path, any tips would be appreciated!

You used Bazarr Notifications (with apprise), right? (I don't see any other native way)

No, I use Custom Post-Processing which is under Settings -> Subtitles. I use http there to send a http request :)

The closest I got was using the Form notification type with the following URL: form://admin:password@autopulse_host:2875/triggers/my_bazarr?:title&:type&:version&:message&method=get&attach-as=path
But it seems attach-as doesn't work as I hoped, as path is always missing ("Query deserialize error: missing field path"). Tried also with JSON type, but same issue, no file attached, no way to extract the path.
Looking at the default payloads in Bazarr notifications, it seems to pretty much always be some plain text (i.e "MyMovie : English subtitles manually downloaded from embeddedsubtitles with a score of 100.0%."), Thus I don't really see how to extract the file path, any tips would be much appreciated!

Much easier!! I didn't know about this setting, thanks for your help


west.yml: Update libmetal for v2010.10 release

Update to a newer libmetal v2010.10 release
Signed-off-by: Kumar Gala<EMAIL_ADDRESS>

I believe this will fix #26142

Closing in favor of #29490 to have one PR for both libmetal & openamp.


Remove Red Cross from Case Reason Picklist

Critical Changes
Changes
Issues Closed

@mkolodner this one looks good, but since it touches the yml file I'd like to this when we are done with Metecho and ready to deploy/test the package.  Metecho doesn't like yml file changes

You're the boss!


Create funaab.txt

Federal University of Agriculture, Abeokuta

Your fork is based off of the jetbrains/swot repo rather than leereilly/swot - if you want your contribution to be included in this repo, please fork this repo make the change and create a new PR


Image registry

Image registry

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://657b0f7e7b7b6e1f5e0b6f4b--harness-developer.netlify.app


Possible issue: sample_id as int vs str

Sometimes I see integer sorting and sometimes I see alphanumeric sorting; at the least, we should be sure that IDs always match up correctly (i.e. the right sample ID with the right BAM IDs).

I would support forcing the IDs to be strings on load in. Mostly because they may be 0-padded and if we interpret them as int they could lose their meaning. For example 00012


xenon3 shadow + serviceloader

This branch has the following features:

Uses shadow plugin to relocate adaptor dependencies instead of classloader for each adaptor, so no need to unpack nested jars
Adaptors are discovered using ServiceLoader instead of manifest entries
Shrinked adaptor gradle file to include statement and it's dependencies

Sadly it takes over 10 minutes to build the shadow jar (38Mb) for the hdfs adaptor.
In the xenon-cli I used this branch as dep without
any problems.
The Jersey conflict is gone and the cli single jar distro works.

Nice work! We'll split off the bigger (and misbehaving) adaptors like hadoop or gridftp after the refactor is complete


Update to use OpenMC v0.14.0, update documentation

This PR does some updates to the archetype library to be compatible with OpenMC v0.14.0. A full list of changes in this PR (it suffers from scope creep unfortunately):

Updating DepleteReactor archetype to now accept thermal power (instead of just using the power_cap parameter for depletion) and flux (required input for OpenMC IndependentOperator
Remove the procedure to check for previous core composition -- this was a quick implementation that should really be thought through more for better implementation.
Update methods in Depletion class to be compatible with OpenMC v0.14.0, and associated tests
Running integration tests only on PR, and not actually running the tests (we know they fail because of issue #12)
Add unit tests for the openmcyclus.Depletion class to CI (with help from @ceserz2)
Add .gitignore for repo
Improve documentation, which includes updating the README (change format from md to rst), adding a CHANGELOG, and CONTRIBUTING guidelines
Updating examples/micro_xs.csv to format used in OpenMC v0.14.0
Updating inputs in examples directory to include the new parameters added to DepleteReactor
Add comparison/materials.xml and comparison/chain_endfb71_pwr.xml for better reproduction of running the benchmark directory
Update the comparison/OpenMC.ipynb for OpenMC v0.14.0

Hello @abachma2! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file openmcyclus/DepleteReactor.py:

Line 626:9: E265 block comment should start with '# '
Line 632:31: W291 trailing whitespace
Line 634:52: W291 trailing whitespace
Line 637:52: W291 trailing whitespace
Line 638:80: W291 trailing whitespace

In the file openmcyclus/depletion.py:

Line 132:51: W291 trailing whitespace
Line 171:57: E231 missing whitespace after ','

In the file tests/unit_tests/test_depletion.py:

Line 50:65: W291 trailing whitespace
Line 58:80: E501 line too long (108 > 79 characters)
Line 62:77: W291 trailing whitespace
Line 63:70: W291 trailing whitespace

So it turns out that initializing the micro_xs and materials objects in the Depletion class doesn't work so well when running this in Cyclus (I could have sworn this was working a week or two ago). So I updated things to initialize these objects with the DepleteReactor class, and use them as inputs to methods in the Depletion class. The model_path attribute of the DepleteReactor class is read in as an input to the Depletion class to prevent having to re-input that information. The tests should be updated to incorporate these changes.

Thanks for the feedback @yardasol! It should all be addressed now.


Proposal

Given tasks:

rubric={mechanics: 5}

[x] Add in the README the link to a proposal.md file describing the project.

Your proposal should be no more than 1,000 words. It should include the following sections:

Motivation and purpose

Description of the data

Research questions and usage scenarios

You will be assessed on the reasoning underlying your proposal as well as the quality and clarity of your writing.
Motivation and Purpose
In a few sentences, provide motivation for why you are creating a dashboard. Who is your target audience, and what role are you embodying? What problem could your dashboard solve for the intended user? Be brief and clear.
Description of the data
In your proposal, briefly describe the dataset and the variables that you will visualize. If you are planning to visualize a lot of columns, provide a high-level descriptor of the variable types rather than listing every single column. For example, indicate that the dataset contains a variety of categorical variables for demographics and provide a brief list rather than describing every single variable.
Research questions and usage scenarios
The purpose of this section is to get you to think about how your target audience might use the app you’re to designing and to account for those needs in the proposal.
For this, it can be helpful to create a brief persona description of a member in your intended target audience and write a small user story for what they might do with your app. User stories are typically written in a narrative style and include the specific context of usage, tasks associated with that use context, and a hypothetical walkthrough of how the user would accomplish those tasks with your app.

Implemented with https://github.com/J99thoms/Super-Smash-Dashboard/commit/c0cfc164cafa6d939827300cdecdde0ad13a0ad0.


Ability to grab the namespace off the claim

What problem are you facing?
Trying to figure out how I can get the namespace off the claim to be able to provision resources in the provider using the name of the namespace in the name.
How could this Function help solve your problem?
Is there a way to pull metadata properties from the claim, specifically the namespace using go-templating or do I need to take the namespace as a parameter?

You can grab the claim namespace from the XR's crossplane.io/claim-namespace label.
Here's an example of creating an EnvironmentConfig resource with a claim_namespace key equal to the namespace the claim was deployed to.
{{ $claimNamespace := index $.observed.composite.resource.metadata.labels "crossplane.io/claim-namespace" }}

---
apiVersion: apiextensions.crossplane.io/v1alpha1
kind: EnvironmentConfig
metadata:
  name: test
data:
  claim_namespace: {{ $claimNamespace }}
---

AWESOME!

@silverbp is it ok to close this issue?


Master

Merges Development into Master.
@aayusharora
The previous commit was correct but a bit faulty. It incorporated all the changes of the development branch. But the meta-data was not correct because since I used the merge --squash option. Now, it should be fine. Please review it. Thanks!!

Current coverage is 32.10% (diff: 32.10%)

No coverage report found for master at 63b2139.

Powered by Codecov. Last update 63b2139...17d8a8b


Kivy packaging for OS X error in Example create app from scratch

Software Versions

Python: 11.3.4
OS:mac 12.6.8
Kivy: 2.2.1
Kivy installation method: pip

Describe the bug
This line in the example can't possibly work:
git clone https://github.com/user/myapp.git
1 - It's impossible to log in to user (it's unknown of course. and so is the password.
2 - It's not clear whether this step is mandatory. If it's not it should say so. If it is, then more detail is needed to explain how to put something into GitHub that could be downloaded and that would satisfy the next steps
Expected behavior
I expected that a "from scratch" example would work since I'm not a mind reader and could never figure this out without first having a working example.
To Reproduce
just try to follow the steps. It will fail for anyone that tries:
git clone https://github.com/user/myapp.git
They will also get:
fatal: Authentication failed for 'https://github.com/user/myapp.git/'
It also says:
remote: Support for password authentication was removed on August 13, 2021.
But of course since "user" does not exist on GitHub, nothing could possible work
Additional context
Perhaps same real sample app in some real user's folder could be supplied so that it could be downloaded.

It may help identifying the problem if you explain where you found this line.
Maybe others know exactly what you are referring to, but I couldn't find any document or example code in Kivy or Buildozer that would tell a user to run that command.


OIDC Implementation - Handle the callback for Google provider

The external OIDC providers can be supported through hub-auth configurations. This issue is not applicable now.


Add without_boundaries to Casing trait

Intro
Add without_boundaries to the Casing trait to allow the below usage:
"2dTransFormation".without_boundaries(&Boundary::digits()).to_case(Case::Snake)

Motivation
There is a with_boundaries method in both Casing and StateConverter. But we can only use without_boundaries with StateConverter. It is convenient to have without_boundaries in Casing.
Worry

Haven't fully tested this. Though the code in the doc seems working well.
Adding a method to the Casing trait is a breaking change. (IMO)

I have used and it seems to work well.
@rutrum Would you please review this? I think it is useful when want to convert the case of str without several boundaries.

This is a good idea.  I've been working on 0.7.0 in dev so I'm going to merge your PR there.  Thanks for the suggestion.


BUG: A file is licensed Apache-2.0, but the license text is not distributed

This is a pyzmq bug

[X] This is a pyzmq-specific bug, not an issue of zmq socket behavior. Don't worry if you're not sure! We'll figure it out together.

What pyzmq version?
26.2.0
What libzmq version?
N/A
Python version (and how it was installed)
N/A
OS
N/A
What happened?
The file zmq/eventloop/zmqstream.py is licensed Apache-2.0,
https://github.com/zeromq/pyzmq/blob/01ed5532a7710653a9925ec25d11cfe37185f672/zmq/eventloop/zmqstream.py#L2-L14
so a copy of the Apache license text should be included in source distributions, but no such license text file is present.
Code to reproduce bug
Reproduce by inspecting the source tree.

Traceback, if applicable
N/A

More info
This can be resolved by adding the contents of https://www.apache.org/licenses/LICENSE-2.0.txt to a file at the top level of the source tree and verifying that it appears in the sdist.

Similarly, zmq/ssh/forward.py is LGPL-2.1-or-later,
https://github.com/zeromq/pyzmq/blob/01ed5532a7710653a9925ec25d11cfe37185f672/zmq/ssh/forward.py#L2-L18
but it is my understanding that (unlike Apache-2.0) the GPL-family licenses do not require the license text to be distributed.

Thanks! Updated to add the Apache text to the licenses directory for the derivative work.

Thanks! Looks good to me.


Add missing #[allow(unsafe_code)] attributes

Fixes #4394.

@davidhewitt Do we have a standard way to test this sort of thing? I also noticed we have some other unsafe usage without #[allow(unsafe_code)]. I'm happy to add those too if that's appropriate.

Great question. From a quick try, it looks like adding #![forbid(unsafe_code)] to src/tests/hygiene/mod.rs will probably do the trick? We already try to cover all macros for hygiene there, so it's maybe a good way to cover them for unsafety at the same time :)

adding ui tests that should pass (for example i added pymodule_missing_docs a while ago) is also an option

Thanks! When can we expect a new release which includes this bugfix (either 0.23 or a backport to 0.22.x)?

I'm prepping 0.22.3 bugfix which includes this fix, to be released in the coming days.

Thank you for adding these attributes! FYI, they cause some changes to buildability for crates that disable unsafe at the top-level via forbid(unsafe_code), since Rust apparently doesn't distinguish between macro expansions and first-party code for lint attributes.
The fix (in my case) was to weaken forbid(...) to deny(unsafe_code), to allow the macro-expanded attributes to correctly override the top-level setting.
See https://github.com/woodruffw/pyrage/commit/68d66179f542c5ac21fae744311645663d877aae for an example of the above.

I'm prepping 0.22.3 bugfix which includes this fix,

Note that this seems to have broken the build for users that declare #[forbid(unsafe_code)] in their main.rs.
IMO this should have been a semantic versioning major bump.
error[E0453]: allow(unsafe_code) incompatible with previous forbid
  --> my.rs:33:1
   |
33 | / create_exception!(
**snip**
   |
  ::: main.rs:11:11
   |
11 |   #![forbid(unsafe_code)]
   |             ----------- `forbid` level set here
   |
   = note: this error originates in the macro `$crate::pyobject_native_type_named` which comes from the expansion of the macro `create_exception` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0453]: allow(unsafe_code) incompatible with previous forbid

Does #[forbid(unsafe_code)] trigger with 0.22.2? If not, it feels really weird to me that us explicitly marking these uses of unsafe as allowed causes problems.

forbid means that the attribute cannot be allowed subsequently.
deny means that the attribute can be allowed subsequently.
Therefore, I changed my code to #[deny(unsafe_code)] and everything is fine.
It is Ok to have this kind of change in macros.
However, IMO it was an API change that required a major bump. I did not expect such a build breakage from a cargo update or a not---locked build.

Sorry that we broke builds here; that wasn't the intention, and I believed this to be a bugfix based on user reports that this lint was firing in their code.
Given that the lint wasn't firing for you despite the forbid, I can only assume we added this allow to places it's not needed, i.e. we added it to too many places.
Perhaps there is something we can do to adjust our testing methodology and get this partially reverted for 0.22.4.

Thanks for your helpful and quick answer.
Yes, it's a bit puzzling what's really going on. Maybe it depends on the Rust compiler version whether a lint triggers without this allow in the macros?
I use Rust 1.81.0.
Just to be sure I reverted my project back to pyo3 0.22.2 with the original #![forbid(unsafe_code)] in place.
It shows no warning in the compiler and clippy runs.

I did a bit of investigation with this reverted and the reproduction from #4394. The lint seems to trigger only on the
#[pyclass(get_all)] option and goes away if that is removed. The additional code for get_all is here
https://github.com/PyO3/pyo3/blob/0079003c49c2b7ac1e5c66b3f73f2ef11621476f/pyo3-macros-backend/src/pymethod.rs#L769-L799
and in contrast to other emitted code with unsafe in it, this one has a Span. And if I remove that span, then the warning goes away with it. So maybe the correct solution is to make sure to only emit unsafe code without a Span?
But I'm not really sure why that works. Without an explicitly set Span, quote! uses the call_site span, which in my understanding should behave the same as if the generated code was written out manually, which is clearly not the case here...

I've staged the revert onto #4575, so we will ship that when we get the other fixes done.


Feature: View & set ERC20/721/1155 balances

The Request
The ability to view & set ERC20, ERC721 and ERC1155 tokens & balances.
Problem
Right now, a user cannot view or set their ERC20/721/1155 tokens & balances.
Solution
As a user, I want the ability to drill into my account and view my ERC20/721/1155 tokens. I should be able to:

See a list of my ERC20 tokens & balances, as well as the ability to set balances & remove tokens,
See a list of my ERC721/1155 tokens & balances, as well as the ability to set balances on my ERC1155 tokens & remove tokens.

Assigned to @ditto-eth

@jxom Hey! I might be interested in tackling this. If I'm not mistaken, importing and setting ERC-20 tokens has already been implemented, so completing this issue will require adding:

importing ERC-721 tokens
importing and setting ERC-1155 tokens

Clarifications:

Is the idea to let users manually import each token / NFT? Or should all tokens and NFTs automatically-populate (like in Etherscan)? If the latter, might have to discuss the feasibility of a couple different approaches.
For the UI, my thought was to have another tab next to Tokens (see below) titled NFTs, and there would be two input fields: address and tokenId. That section can contain both ERC-721 and ERC-1155, distinguished by a tag next to their names (how Etherscan displays it).

Rivet

Etherscan

Is the idea to let users manually import each token / NFT? Or should all tokens and NFTs automatically-populate (like in Etherscan)? If the latter, might have to discuss the feasibility of a couple different approaches.
For the UI, my thought was to have another tab next to Tokens (see below) titled NFTs, and there would be two input fields: address and tokenId. That section can contain both ERC-721 and ERC-1155, distinguished by a tag next to their names (how Etherscan displays it).

yo I did the initial implementation. There are issues regarding token imports https://github.com/paradigmxyz/rivet/issues/56 (sync after fork, already done) and https://github.com/paradigmxyz/rivet/issues/57 (before fork). Only thought on auto populate is how far back to search and to ignore certain tokens potentially since some accounts are spammed with NFTs (say you import vitalik.eth or the default foundry ones).
For the UI yea there is already a commented out NFT section in the code that is separate. We discussed probably needing to separate the sections but also to separate it in the code, potentially as a separate store to store different metadata from erc20 (also need some code to check if it's an NFT, like checking getApproved, setApprovalForAll, isApprovedForAll, or even the different approve interface from erc20)


ST-216 Tax Code History

[ ] Unit tests passing
[ ] Coverage reached
[ ] Acceptance tests passing
[ ] Reviewed

Closing this PR. No longer required


CODEOWNERS is broken (III)

A comma was added to a new path in
9dbdd81
But GitHub's CODEOWNERS parsing cannot handle commas in paths
Related to #16000

Can we just, go once through the CODEOWNERS file and remove all commas? So we avoid new breakings when doing legitimate changes to the file.
I this this should do it; we are , anyways, careful, when doing changes in that file (doesn't mean I don't agree with adding a CI check)


Git multi select and stage is broken

Issue Type: Bug
Refer to #43787
This is happening again in stable and on the latest insiders,
Edit: It only happens when using
 "window.titleBarStyle": "custom"
VS Code version: Code - Insiders 1.26.0-insider (5a4eab812bd485942061f71af39f3eabc52a1035, 2018-07-11T09:38:12.464Z)
OS version: Windows_NT ia32 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-4460  CPU @ 3.20GHz (4 x 3193)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwarevideo_decode: enabledvideo_encode: enabledvpx_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
7.94GB (3.72GB free)

Process Argv
C:\Users\bmf.ribeiro\AppData\Local\Programs\Microsoft VS Code Insiders\Code - Insiders.exe

Screen Reader
no

VM
0%

Extensions (20)

Extension
Author (truncated)
Version

Bookmarks
ale
0.19.1

vagrant
bbe
0.5.0

solargraph
cas
0.17.5

vscode-eslint
dba
1.4.12

githistory
don
0.4.1

gitlens
eam
8.4.1

tslint
eg2
1.0.33

vscode-npm-script
eg2
0.3.5

ruby-linter
hoo
1.0.0

Ionide-fsharp
Ion
3.22.3

docthis
joe
0.7.1

VS-code-vagrantfile
mar
0.0.7

prettify-json
moh
0.0.3

csharp
ms-
1.15.2

PowerShell
ms-
1.8.1

vscode-docker
Pet
0.0.27

material-icon-theme
PKi
3.5.1

Ruby
reb
0.18.0

vscode-icons
rob
7.24.0

gitblame
wad
2.4.2

(1 theme extensions excluded)

Can you show me the full steps of what you do to reproduce this issue? Can you reconfirm that it only happens with "window.titleBarStyle": "custom"?

Yes, it only happens  with "window.titleBarStyle": "custom"..

I believe I misunderstood the other issue, mine is slightly different, they
are both selected but when I press stage, only one of the files is staged.

Can you show me the full steps of what you do to reproduce this issue?

https://gfycat.com/SlipperyGloomyDartfrog
Screen capture of the bug
João Moreno<EMAIL_ADDRESS>escreveu no dia quinta, 12/07/2018
à(s) 14:52:

Can you show me the full steps of what you do to reproduce this issue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/54112#issuecomment-404519228,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APWm20XnWC8CiG2B0Ukgr1uhBvMuQhTWks5uF1SqgaJpZM4VL6uC
.

Screen capture of the bug

So... broken doesn't mean that it doesn't work... just that it works partially. And you use the context menu to stage. A current workaround for you is to use the inline + actions... they also work when you have multiple selection.

@sbatten Those actions use special contexts to support multiple selection. Can you double check?

This wasn't due to your changes @sbatten... the fake menu, which predates you, wasn't ready for getting passed an actionRunner. I went ahead and fixed that up.

Yeah, the title could have been clearer...
Thank you for the quick fix!


chore: update readme with nova and hypernova as proving backends

Description
We integrated noir as a frontend to sonobe, a library being joint-developed by 0xPARC and PSE. It  implements various folding schemes such as nova and hypernova, with which noir circuits can be folded. It includes some example code showing how to do this using nova.

Thank you for the work and this PR!


Add "force downgrade" (client) and "prefer downgrade" (server) options

This adds the following two options to the library:

On the client side, ForceDowngrade(true) instructs the client proxy to downgrade all requests by (a) switching to HTTP/1, (b) omitting the Accept: application/grpc header, (c) omitting the TE: trailers header, and (d) sending a special header to request a gRPC-Web response (this is to guard against any overzealous gRPC-aware proxies that might "fix" the issues caused by a-c before forwarding to the backend). The server side is extended to recognize this header.
On the server side, PreferGRPCWeb(true) instructs the server to always send a gRPC-Web response when the client indicates that it accepts it and the method is downgradable (i.e., not client- or bidi-streaming).

(d) sending a special header to request a gRPC-Web response (this is to guard against any overzealous gRPC-aware proxies that might "fix" the issues caused by a-c before forwarding to the backend). The server side is extended to recognize this header.

Curious, how would a proxy know a HTTP/1.x request without Accept: application/grpc and TE: trailers know this is a gRPC request? Just trying to understand why the new header is necessary

Curious, how would a proxy know a HTTP/1.x request without Accept: application/grpc and TE: trailers know this is a gRPC request? Just trying to understand why the new header is necessary

gRPC requests are identified by their Content-Type: application/grpc header

Curious, how would a proxy know a HTTP/1.x request without Accept: application/grpc and TE: trailers know this is a gRPC request? Just trying to understand why the new header is necessary

gRPC requests are identified by their Content-Type: application/grpc header

Sorry it's been a while since I've thought about the protocol


Publish Null safe version to pub

Need to publish this package to pub for upgrading intl_phone_number_input

Need to publish this package to pub for upgrading intl_phone_number_input

or remove the ../ path and use git path so that intl_phone_number_input can be migrated. We can change that later when this one is published to pub
@natintosh
Any thoughts on this ?

I'm sorry about that. There's still a lot of work to be done on this repo (bugs on the iOS part). I'll push an update as soon as I'm able to.
I don't use a MacBook, and that's the primary cause of the hold up. If you happen to own one, I wouldn't mind working with you to try to fix the issue.
Once again I apologize for the hold up.

If you need to test any mac specific things let me know I can do that for you .

Alrighty 👍.
The issue with the library on iOS is that the only method functioning is formatAsYouType, while the rest are either returning null or an empty string.
So, I was trying to build an interdependent library following this guide interdependent-iOS#Federated-Plugin, since an original library existing and some of the methods already exists in libphonenumber.

Let's connect over a call if you're free ? Ping me on<EMAIL_ADDRESS>

I just sent you an email. Thanks for helping out

@pr-1, thanks for having the meeting with me.
This is what is going to happen and what you would see after you have resolved the cocoa pod issue and opened libphonenumber_plugin/example/ios/Runner.xcworkspace from Xcode.

on the navigator panel to the left of your screen, you'll see two Folder, Runner and Pods.
The source code of the iOS platform code is located inside the Pod folder, with a relative path of Development Pods/libphonenumber_plugin/../../example/ios/.symlinks/plugins/libphonenumber_plugin/Classes/SwiftLibPhoneNumberPlugin.swift, to locate the swift code.
If you are able to run the code ../example/lib/main.dart on an iOS device, you would notice that only PhoneNumberUtils.asYouTypeFormatter works, while the others return their null values respectively. As shown in the screenshot below.

Whereas, if you run the same codebase on Android or Web, you will get something similar to this.

The printed statements are correct for each scenario.
Thanks once one.


catch: 1.12.2 -> 3.0.0-preview3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/catchorg/Catch/releases.
meta.description for catch is: "A multi-paradigm automated test framework for C++ and Objective-C (and, maybe, C)"
meta.homepage for catch is: "http://catch-lib.net"
meta.changelog for catch is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 3.0.0-preview3 with grep in /nix/store/fznphyczmq2xw27qy14188rd44hs57a2-catch-3.0.0-preview3

directory tree listing: https://gist.github.com/b852f54317323693ff44f004511dc228

du listing: https://gist.github.com/ef48a81d8aa3852cff154c9895b4febe

Rebuild report (if merged into master) (click to expand)

2900 total rebuild path(s)

901 package rebuild(s)

877 x86_64-linux rebuild(s)
699 i686-linux rebuild(s)
529 x86_64-darwin rebuild(s)
795 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
DisnixWebService
R
abcl
adapta-gtk-theme
adoptopenjdk-icedtea-web
alloy
alloy4
alloy5
antlr
antlr3
antlr3_4
antlr3_5
antlr4
antlr4_7
apache-airflow
apache-jena
apache-jena-fuseki
apacheKafka
apacheKafka_0_10
apacheKafka_0_11
apacheKafka_0_9
apacheKafka_1_0
apacheKafka_1_1
apacheKafka_2_0
apacheKafka_2_1
apacheKafka_2_2
apacheKafka_2_3
apacheKafka_2_4
apacheKafka_2_5
ape
apeClex
apktool
areca
asciidoc-full
asciidoc-full-with-plugins
avian
axoloti
azureus
bareos
baresip
bazel
bazel-remote
bazel-watcher
bazel_0
bazel_0_26
bazel_0_29
bazel_1
bazel_3
belle-sip
btrbk

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/fznphyczmq2xw27qy14188rd44hs57a2-catch-3.0.0-preview3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A catch https://github.com/r-ryantm/nixpkgs/archive/96b87f8a635bbdc6d06980e9e0efd064d26de794.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/fznphyczmq2xw27qy14188rd44hs57a2-catch-3.0.0-preview3
ls -la /nix/store/fznphyczmq2xw27qy14188rd44hs57a2-catch-3.0.0-preview3/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings
cc @edwtjo @knedlsepp for testing.

Invalid, this is a preview release. Also, Catch2 version 3.x will break API and should be a separate package once it available.

Reported issue upstream https://github.com/catchorg/Catch2/issues/2053

Upstream has fixed; closing


Test application crashes with memory problems.

See the following logs
https://gist.github.com/slavchev/29f6c541c0ad4001babf
https://gist.github.com/slavchev/6e34b9037ead8c9511bf
https://gist.github.com/slavchev/8a31e05520700e579f89
https://gist.github.com/slavchev/1af1797056b6c600088c

This is already fixed.


Unable to open the initial device, quitting.

Hi Altmany. I am fairly new at coding, and I am trying to use both export_fig and append_pdfs to create some reports.
When running the following code:
Route = 'G:\\My Drive\\IMEPE Courses\\IMPE5011_Power System Planning\\Project\\BDD\\Reports';
pRF = 0.1;
append_pdfs(Route + "\\GEP_pRF"+num2str(pRF*100)+".pdf",Fig_Naams_list);

I get this error :
Error using append_pdfs (line 131)
GPL Ghostscript 9.56.1: **** Could not open the file
"C:\Users\newsu\AppData\Local\Temp\tp80f2c0bd_7573_4a0a_a16b_0304327f0f8f.pdf" .
**** Unable to open the initial device, quitting.`

In some other instances, the error reads:
Error using append_pdfs (line 131)
GPL Ghostscript 9.56.1: **** Could not open the file "C:\\Users\\newsu\\Desktop\\GEP1.pdf" .
**** Unable to open the initial device, quitting.

I have tried:

Reinstalling GhostScript,
Using absolute and relative directories,
Trying to save the file in the Desktop or in a directory that shouldn't be a problem in case GhostScript didn't have read/write permissions.

Also, in case the problem is related, when trying to append several figures in a single file using export_fig I have the following problem:
for i = 1:size(Output_G_exist,3)
      [fig,Fig_Naam] = graph_EnergyProduction(Output_G_exist(:,:,i),Output_G_cand(:,:,i),num2str(i+2020),"GEP",pRF,"");
      export_fig(Figures_Route + "\" + Naam + ".pdf",[fig],-append);
      Fig_Naams_list = [Fig_Naams_list;strcat(Figures_Route +"\"+ Fig_Naam +".pdf")];
end

The following error pops up:
Error using append (line 46)
Not enough input arguments.

Error in GraphingModule_Script (line 33)
        export_fig(Figures_Route + "\" + "GEP" + ".pdf",[fig],-append);

Perhaps it is a foolish error I might be making, but I need the help because I've run out of ideas on how to fix it.
In case you need more details, or outright need me to send you my code, I will gladly do so.
Thanks.

why are you using \ instead of \  in your paths???

I used to write codes in Python, so in Python I was taught to use double backslash ("\") when dealing with strings so as the interpreter to not confuse it with a different command. For instance, the string "\n" will create a new line. So as to prevent any kind of misinterpretation when using append_pdfs I also tried with double backslash instead of just single.
Given the error that append_pdfs is displaying, I just tried many things including adding double backslash after single didn't work. However, apparently MatLab correctly interprets the double backslash:

So, the path name C:\\Users\\newsu\\Desktop\\GEP1.pdf" should be as valid as C:\Users\newsu\Desktop\GEP1.pdf".
Moreover, I tried both, and the output error is exactly the same.

So, I was considering that that is not really the problem so something else.
Thanks for your time.

I don't know what's going on with your code and if all the file paths are correct - you will need to debug this on your own.
One error for certain in your code is that your command export_fig(Figures_Route + "\" + Naam + ".pdf",[fig],-append); is wrong - you need to put the -append in a string, otherwise Matlab will think that you want to do the negative value of the append variable or function which is obviously silly.

That actually did help. Thanks for your help and time.


University of Nariño

udenar.edu.co
Universidad de Nariño
Pasto - Nariño, Colombia
Torobajo - Calle 18 Carrera 50
https://www.udenar.edu.co/facultades/ingenieria/ingenieria-en-sistemas/

@jfajardo I am sorry, the domain udenar.edu.co is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Pack at https://education.github.com/discount_requests/application. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


Added default branch functionality

Changelog

Added the functionality to fetch the PAUL.yaml from the default branch

issue: https://github.com/Spazzy757/paul/issues/20

/cat


Can not update Plotly because of Datapane restriction

System Information

OS: Windows 10
Python version: 3.8.10
Python environment: conda
Using jupyter:  false
Datapane version: 0.11.11

Bug / Issue
This issue is relevant to https://github.com/conda-forge/plotly-feedstock/issues/96
The problem is we can't update to Plotly 5.1.0 because the Datapane told us to have Plotly version under 5.
If anyone have any solution for this issue, please share your thoughts here :)

hello,
i experience this issue too, on 2 different laptops, plotly is stuck in v4.14.3, if datapane is installed, even has been updated to v0.11.11
if we tried to update the plotly via conda, package conflict error appears, as explained on github link above

Hi,
Thanks for raising - we're looking into now and should have a release out very shortly that will support both v4 and v5 versions of Plotly.


Make rebuild support ocamlc

Add a new command "rec" to be used in rebuild as a replacement for ocamlc. This is needed to
support ocamlc specific functionalities, such as compiling cmo files.
#725

Merging this to unblock @freebroccolo


Rest fails to retrieve private/cli metrics

A note for the community

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
If you are interested in working on this issue or have submitted a pull request, please let us know in a comment

Problem
The node > healthy status seems to be only reported when we enable Zapi.
When only the Rest collector is enabled, or listed first in the collectors, it seems the normal Node counters are being collected, but this part of counters from /api/private/cli/node is not returning data and we have no "healthy" field:
endpoints:
  - query: api/private/cli/node
    counters:
      - ^^node                                        => node
      - ^health                                       => healthy
      - ^max_aggr_size                                => max_aggr_size
      - ^max_node_vvols                               => max_vol_num
      - ^max_vol_size                                 => max_vol_size
      - ^vendor                                       => vendor
      - cpu_busy_time                                 => cpu_busytime

When we manually try to browse to the API we get the results returned:
https://<IP>/api/private/cli/node?fields=health,node,vendor
We seem to have this issue with both 9.8.0, 9.13.1.
We want to try to only use Rest as to not have to extend both Rest and Zapi configuration files with additional metrics.
Configuration
Admin:
Tools:
Exporters:
    influxdb:
        exporter: InfluxDB
        addr: -REDACTED-
        bucket: test-harvest
        org: -REDACTED-
        token: -REDACTED-
Defaults:
    use_insecure_tls: true
Pollers:
    unix:
        datacenter: local
        addr: -REDACTED-
        collectors:
            - Unix
        exporters:
            - influxdb
    cl01:
        datacenter: dc01
        addr: -REDACTED-
        auth_style: basic_auth
        username: -REDACTED-
        password: "-REDACTED-"
        use_insecure_tls: true
        exporters:
            - influxdb
        collectors:
            - Zapi
            - ZapiPerf
            - Rest
            - RestPerf
        labels:
            - customer: cus1
            - instance: cl01
    cl02:
        datacenter: dc02
        addr: -REDACTED-
        auth_style: basic_auth
        username: -REDACTED-
        password: "-REDACTED-"
        use_insecure_tls: true
        exporters:
            - influxdb
        collectors:
            - Rest
            - RestPerf
            - Zapi
            - ZapiPerf
        labels:
            - customer: cus1
            - instance: cl02
    cl3:
        datacenter: dc3
        addr: -REDACTED-
        auth_style: basic_auth
        username: -REDACTED-
        password: "-REDACTED-"
        use_insecure_tls: true
        exporters:
            - influxdb
        collectors:
            - Rest
            - RestPerf
            - Zapi
            - ZapiPerf
        labels:
            - customer: cus1
            - instance: cl3

Poller
Rest
Version
23.11
Poller logs
No response
OS and platform
Ubuntu 20.04
ONTAP or StorageGRID version
9.8.0, 9.13 (simbox)
Additional Context
No response
References
No response

Hi @rahulguptajss
I have tested this API call on both a 9.8 physical system and 9.13.1 simbox.
In both cases we get a response similar to this:
{
  "records": [
    {
      "node": "cl02-01",
      "vendor": "NetApp",
      "health": true,
      "cpu_busy_time": 22003,
      "max_aggr_size":<PHONE_NUMBER>20800,
      "max_vol_size":<PHONE_NUMBER>32800,
      "max_node_vvols": 500
    }
  ],
  "num_records": 1
}

I will collect the logs and send them by mail.

hi @frankvdbh are you all sorted here or have anymore questions?

@frankvdbh closing this one, please reopen if you get a chance to follow-up.


Question about markdown syntax

Is there any reason to use quoting syntax for code evaluations and use  tags instead of backticks for inline code marking? Besides these, I see HTML tables in source files.
For example:
> \> 'John ⇒ JOHN

> \> '(John Q Public) ⇒ (JOHN Q PUBLIC)

> \> '2 ⇒ 2

> \> 2 ⇒ 2

> \> '(+ 2 2) ⇒ (+ 2 2)

> \> (+ 2 2) ⇒ 4

> \> John ⇒ Error: JOHN is not a bound variable

> \> (John Q Public) ⇒ Error: JOHN is not a function

and
Note that '2 evaluates to 2 because it is a quoted expression, and 2 evaluates to 2 because numbers valuate to themselves. Same result, different reason. In contrast, 'John evaluates to John because it is a quoted expression, but evaluating John leads to an error, because evaluating a symbol means getting the value of the symbol, and no value has been assigned to John.

and

    defun
    define function

    defparameter
    define special variable

    setf
    set variable or field to new value

    let
    bind local variable(s)

    case
    choose one of several alternatives

    if
    do one thing or another, depending on a test

    function (#')
    refer to a function

    quote (')
    introduce constant data

Can you clarify what you think the problem is?  You gave an example, but I didn't understand what you think is wrong with it, or what you propose to change.  Perhaps link to a file and line where the problem is within the repo.
As written, I'm reading your question as "why use backticks?".  And the only answer I can think of is "because it's markdown syntax".
re: your html tables question, is that the same issue or a separate topic from the code formatting?

Let me know if I understand you correctly. Looking at chapter 1:

There's quoting used, like > for blockquotes, to indent code, instead of code blocks, with ``` before and after.
We're using  instead of backticks: `
We're using
 instead of Markdown tables.

You'd rather we use Markdown when we can, instead of html.
I agree with this.

I agree with using Markdown as much as possible.

I need to improve my writing skills 😂
@pronoiac Yes, that's exactly what I mean.
If you prefer markdown syntax, I'm going to change quotes to code blocks,  to backticks and
 to markdown tables while I read through the book.

@casouri, there's news: we imported chapters from a cleaner source. (There are major changes. You should probably pull down the changes before doing much editing.) There's lots of cleanup to do - the conversion tool is a work in progress - but at least  and
 are gone.

Cool 😄

Some questions/problems:

What is this [ ](#){:#st0015} stuff?

## [ ](#){:#st0015}4.2 Stage 2: Specification
{:#s0015}
{:.h1hd}

Extra bullet:

* • We need a list of allowable operators.

The code blocks are separated and have extra stuff mentioned in 1):

`(defun achieve (goal)`
!!!(p) {:.unnumlist}

` “A goal is achieved if it already holds,`
!!!(p) {:.unnumlist}

` or if there is an appropriate op for it that is applicable.”`
!!!(p) {:.unnumlist}

Typos are gone, but I think the port tool needs some enhancement. Fixing all of these errors by hand is a lot of work.

Is this issue handled? Can we close it?

Yeah


Add progressbar and notification. Closes #479

Looks okay but I can't reproduce this because something in the connection layer is broken (react client doesn't connect new dats, so no alert will be triggered).

I hope this was fixed by your webpack PR


--max-target-megabytes flag now supported for --no-git flag as well

Description:
--max-target-megabytes was not working for the case --no-git was on.
This PR fixes this problem
Checklist:

[X] Does your PR pass tests?
[ ] Have you written new tests for your changes?
[X] Have you lint your code locally prior to submission?

@eyalatox thanks for the PR!


Cannot read properties of undefined (reading 'volume')

Describe the bug
A clear and concise description of what the bug is.
When running anything todo wiith GuildQueue i keep getting this>
let guildQueue = client.player.getQueue(message.guild.id); has been added to my player script.
To Reproduce
Steps to reproduce the behavior:
Cannot read properties of undefined (reading 'volume')
TypeError: Cannot read properties of undefined (reading 'volume')     at Object.exports.run (C:\ModManager\commands\advmusic.js:105:45)     at module.exports (C:\ModManager\events\messageCreate.js:145:15)     at Client.emit (node:events:390:28)     at MessageCreateAction.handle (C:\ModManager\node_modules\discord.js\src\client\actions\MessageCreate.js:23:14)     at Object.module.exports [as MESSAGE_CREATE] (C:\ModManager\node_modules\discord.js\src\client\websocket\handlers\MESSAGE_CREATE.js:4:32)     at WebSocketManager.handlePacket (C:\ModManager\node_modules\discord.js\src\client\websocket\WebSocketManager.js:350:31)     at WebSocketShard.onPacket (C:\ModManager\node_modules\discord.js\src\client\websocket\WebSocketShard.js:443:22)     at WebSocketShard.onMessage (C:\ModManager\node_modules\discord.js\src\client\websocket\WebSocketShard.js:300:10)     at WebSocket.onMessage (C:\ModManager\node_modules\ws\lib\event-target.js:199:18)     at WebSocket.emit (node:events:390:28)`
Expected behavior
Do action requested.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
OS: Windows
Smartphone (please complete the following information):
N/A
Additional context
Code in use is:
https://pastebin.com/yG3PiAj1

Where should the let guildQueue = client.player.getQueue(message.guild.id); be located? I Believe this is what I am struggling with..
I get the error even when music is playing.

Where should the let guildQueue = client.player.getQueue(message.guild.id); be located? I Believe this is what I am struggling with..
I get the error even when music is playing.

It should be placed in the command/event where you need it


support accelerated networking

@paulczar PTAL

or perhaps @shane-snyder or @diana-sari  ?

hello @davidkarlsen thanks for the PR!
i ran this locally and encountered this error, any thoughts on the taints formatting there?
➜  helm-charts git:(feature/accel-nw) helm upgrade --install -n openshift-machine-api \
  infra mobb/aro-machinesets
Release "infra" does not exist. Installing it now.
Error: 3 errors occurred:
	* admission webhook "default.machineset.machine.openshift.io" denied the request: json: cannot unmarshal object into Go struct field MachineSpec.spec.template.spec.taints of type []v1.Taint
	* admission webhook "default.machineset.machine.openshift.io" denied the request: json: cannot unmarshal object into Go struct field MachineSpec.spec.template.spec.taints of type []v1.Taint
	* admission webhook "default.machineset.machine.openshift.io" denied the request: json: cannot unmarshal object into Go struct field MachineSpec.spec.template.spec.taints of type []v1.Taint

@diana-sari that was probably the case before this PR as well?
What version is your cluster?

see what happens if you change this default:
machineTaints: {}

to:
machineTaints: []

yeah i actually am seeing similar error from main branch, this is a fresh git clone and following steps from the readme:
➜  helm-charts git:(main) helm upgrade --install -n openshift-machine-api \
  infra mobb/aro-machinesets
Error: UPGRADE FAILED: failed to create resource: admission webhook "default.machineset.machine.openshift.io" denied the request: json: cannot unmarshal object into Go struct field MachineSpec.spec.template.spec.taints of type []v1.Taint

try taints as an empty list.
what version is your cluster?
perhaps this PR can be merged anyways as it is not the one introducing the error.

while this PR might not be related to the error, we do need to investigate this further so please bear with us, and actually i'll be out this week so i'll leave it to Paul for time being (and i already DM him so hopefully he'll take a look at this when he gets the chance), appreciate your patience in advance!

I can reproduce your error:
helm upgrade --install -n openshift-machine-api test .
Release "test" does not exist. Installing it now.
Error: 3 errors occurred:
        * admission webhook "default.machineset.machine.openshift.io" denied the request: json: cannot unmarshal object into Go struct field MachineSpec.spec.template.spec.taints of type []v1.Taint
        * admission webhook "default.machineset.machine.openshift.io" denied the request: json: cannot unmarshal object into Go struct field MachineSpec.spec.template.spec.taints of type []v1.Taint
        * admission webhook "default.machineset.machine.openshift.io" denied the request: json: cannot unmarshal object into Go struct field MachineSpec.spec.template.spec.taints of type []v1.Taint

 aro-machinesets  oc version
Client Version: 4.16.5
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: 4.14.33
Kubernetes Version: v1.27.15+6147456

and if I change the default values as I suggested previously, it will pass:
helm upgrade --install -n openshift-machine-api test .
Release "test" has been upgraded. Happy Helming!
NAME: test
LAST DEPLOYED: Wed Aug 14 15:22:50 2024
NAMESPACE: openshift-machine-api
STATUS: deployed
REVISION: 2
TEST SUITE: None
 aro-machinesets  git diff

diff --git a/charts/aro-machinesets/values.yaml b/charts/aro-machinesets/values.yaml
index c6436f8..d672ffc 100644
--- a/charts/aro-machinesets/values.yaml
+++ b/charts/aro-machinesets/values.yaml
@@ -16,7 +16,7 @@ machineLabels: {}
   # uncomment this to have infra-nodes
   # node-role.kubernetes.io/infra: ""

-machineTaints: {}
+machineTaints: []
   # uncomment this to have dedicated infra-nodes with taints
   # - key: node-role.kubernetes.io/infra
   #  effect: NoSchedule

@diana-sari old problem fixed in this PR. CC @paulczar

@diana-sari ? @paulczar ? Are there any other maintainers? Is this project still actively maintained?

sorry @davidkarlsen we've got a mix of vacations and illness on the maintainer group.  I'm looking at this today.


Fix ClassCastException with local presenters

After obfuscation, my local presenters have the same class name and field name in view. And in case when two MvpDelegate for each view have the same hashCode, generateTag() return equals tags for 2 different presenter. According MvpFacade.getInstance().getPresenterStore().get(tag); (In MvpProcessor) return already exist presenter, but type of the presenter are different. In result after call  of method bind() in PresenterBinder throw ClassCastException. I have already caught this exception.

I know that i can use tag in InjectPresenter for unique. But i think, that it will be redundant code.


Add support for unicode characters in the headers

Some headers have unicode characters and the processed file is being output with character unknown character '�'

Turns out unicode is supported by default. The file we were using for testing was using some encoding that was not UTF-8


[azure-kinect-sensor-sdk] macOS build failure

Host Environment

OS: macOS
Compiler: revision

To Reproduce
Steps to reproduce the behavior:
./vcpkg install azure-kinect-sensor-sdk
Failure logs
Computing installation plan...
The following packages will be built and installed:
    azure-kinect-sensor-sdk[core]:x64-osx -> 1.4.0-alpha.0#6
Detecting compiler hash for triplet x64-osx...
Could not locate cached archive: /Users/adammac/.cache/vcpkg/archives/93/930f8b5bac6d9b73761ac3276168b364138931b3.zip
Starting package 1/1: azure-kinect-sensor-sdk:x64-osx
Building package azure-kinect-sensor-sdk[core]:x64-osx...
-- Using cached /Users/adammac/dev/vcpkg-macos/vcpkg/downloads/microsoft-Azure-Kinect-Sensor-SDK-v1.4.0-alpha.0.tar.gz
-- Cleaning sources at /Users/adammac/dev/vcpkg-macos/vcpkg/buildtrees/azure-kinect-sensor-sdk/src/.0-alpha.0-a0fc9b9902.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /Users/adammac/dev/vcpkg-macos/vcpkg/downloads/microsoft-Azure-Kinect-Sensor-SDK-v1.4.0-alpha.0.tar.gz
-- Applying patch fix-builds.patch
-- Applying patch disable-c4275.patch
-- Applying patch fix-dependency-imgui.patch
-- Applying patch add-MATROSKA_VERSION-define.patch
-- Using source at /Users/adammac/dev/vcpkg-macos/vcpkg/buildtrees/azure-kinect-sensor-sdk/src/.0-alpha.0-a0fc9b9902.clean
-- Configuring x64-osx-dbg
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:105 (message):
    Command failed: /Users/adammac/dev/vcpkg-macos/vcpkg/downloads/tools/cmake-3.19.2-osx/cmake-3.19.2-macos-universal/CMake.app/Contents/bin/cmake /Users/adammac/dev/vcpkg-macos/vcpkg/buildtrees/azure-kinect-sensor-sdk/src/.0-alpha.0-a0fc9b9902.clean -DK4A_BUILD_DOCS=OFF -DBUILD_TOOLS=OFF -DK4A_SOURCE_LINK=OFF -DK4A_MTE_VERSION=ON -DBUILD_EXAMPLES=OFF -DWITH_TEST=OFF -DIMGUI_EXTERNAL_PATH=/Users/adammac/dev/vcpkg-macos/vcpkg/installed/x64-osx/include/bindings -DCMAKE_MAKE_PROGRAM=/Users/adammac/dev/vcpkg-macos/vcpkg/downloads/tools/ninja-1.10.1-osx/ninja -DCMAKE_SYSTEM_NAME=Darwin -DBUILD_SHARED_LIBS=OFF -DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=/Users/adammac/dev/vcpkg-macos/vcpkg/scripts/toolchains/osx.cmake -DVCPKG_TARGET_TRIPLET=x64-osx -DVCPKG_SET_CHARSET_FLAG=ON -DVCPKG_PLATFORM_TOOLSET=external -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON -DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON -DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE -DCMAKE_VERBOSE_MAKEFILE=ON -DVCPKG_APPLOCAL_DEPS=OFF -DCMAKE_TOOLCHAIN_FILE=/Users/adammac/dev/vcpkg-macos/vcpkg/scripts/buildsystems/vcpkg.cmake -DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON -DVCPKG_CXX_FLAGS= -DVCPKG_CXX_FLAGS_RELEASE= -DVCPKG_CXX_FLAGS_DEBUG= -DVCPKG_C_FLAGS= -DVCPKG_C_FLAGS_RELEASE= -DVCPKG_C_FLAGS_DEBUG= -DVCPKG_CRT_LINKAGE=dynamic -DVCPKG_LINKER_FLAGS= -DVCPKG_LINKER_FLAGS_RELEASE= -DVCPKG_LINKER_FLAGS_DEBUG= -DVCPKG_TARGET_ARCHITECTURE=x64 -DCMAKE_INSTALL_LIBDIR:STRING=lib -DCMAKE_INSTALL_BINDIR:STRING=bin -D_VCPKG_ROOT_DIR=/Users/adammac/dev/vcpkg-macos/vcpkg -D_VCPKG_INSTALLED_DIR=/Users/adammac/dev/vcpkg-macos/vcpkg/installed -DVCPKG_MANIFEST_INSTALL=OFF -DCMAKE_OSX_ARCHITECTURES=x86_64 -G Ninja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=/Users/adammac/dev/vcpkg-macos/vcpkg/packages/azure-kinect-sensor-sdk_x64-osx/debug
    Working Directory: /Users/adammac/dev/vcpkg-macos/vcpkg/buildtrees/azure-kinect-sensor-sdk/x64-osx-dbg
    Error code: 1
    See logs for more information:
      /Users/adammac/dev/vcpkg-macos/vcpkg/buildtrees/azure-kinect-sensor-sdk/config-x64-osx-dbg-out.log
      /Users/adammac/dev/vcpkg-macos/vcpkg/buildtrees/azure-kinect-sensor-sdk/config-x64-osx-dbg-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_cmake.cmake:328 (vcpkg_execute_required_process)
  ports/azure-kinect-sensor-sdk/portfile.cmake:25 (vcpkg_configure_cmake)
  scripts/ports.cmake:133 (include)

Error: Building package azure-kinect-sensor-sdk:x64-osx failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `./vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: azure-kinect-sensor-sdk:x64-osx
  Vcpkg version: 2021-01-13-unknownhash

Additionally, attach any relevant sections from the log files above.

Computing installation plan...
The following packages will be built and installed:
    azure-kinect-sensor-sdk[core]:x64-osx -> 1.4.0-alpha.0#6
Detecting compiler hash for triplet x64-osx...
Could not locate cached archive: /Users/adammac/.cache/vcpkg/archives/93/930f8b5bac6d9b73761ac3276168b364138931b3.zip
Starting package 1/1: azure-kinect-sensor-sdk:x64-osx
Building package azure-kinect-sensor-sdk[core]:x64-osx...
-- Using cached /Users/adammac/dev/vcpkg-macos/vcpkg/downloads/microsoft-Azure-Kinect-Sensor-SDK-v1.4.0-alpha.0.tar.gz
CMake Error at CMakeLists.txt:112 (find_library):
  Could not find LibUSB using the following names: libusb-1.0

Additional context
Add any other context about the problem here, such as what you have already tried to resolve the issue.

It cannot find libusb-1.0

Duplicated to #12995.

@JackBoosY are we positive this is a duplicate of #12995?
I see that at one point you mentioned that it cannot find libusb: https://github.com/microsoft/vcpkg/issues/12995#issuecomment-678080450
but then later it seems like the issue there is that libuvc has 2 different versions:
https://github.com/microsoft/vcpkg/issues/12995#issuecomment-720992478
That issue does not seem to try to solve finding libusb.

@adammpolak  Can #14750 solve this issue?

@adammpolak Yep. And you can pull #14750 changes to test it also.

Sorry for triple checking, but this means I test by cloning this repo: https://github.com/fran6co/vcpkg/tree/azure_linux ?
Or how do I checkout this update locally (I don't want to provide wrong feedback on the fix working)

@JackBoosY I:

cloned https://github.com/fran6co/vcpkg/
checked out azure_linux
ran bash bootstrap-vcpkg.sh
ran ./vcpkg install azure-kinect-sensor-sdk
Was able to get through dependencies then run into this issue: Could not find a package configuration file provided by "libuvc" with any of the following names ...

Full vcpkg/buildtrees/azure-kinect-sensor-sdk/config-x64-osx-dbg-err.log below
Building package azure-kinect-sensor-sdk[core]:x64-osx...
-- Downloading https://github.com/microsoft/Azure-Kinect-Sensor-SDK/archive/v1.4.1.tar.gz -> microsoft-Azure-Kinect-Sensor-SDK-v1.4.1.tar.gz...
-- Extracting source /Users/adammac/dev/vcpkg/downloads/microsoft-Azure-Kinect-Sensor-SDK-v1.4.1.tar.gz
-- Applying patch fix-builds.patch
-- Applying patch fix-dependency-imgui.patch
-- Applying patch add-MATROSKA_VERSION-define.patch
-- Applying patch fix-linux.patch
-- Applying patch fix-uvc.patch
-- Using source at /Users/adammac/dev/vcpkg/buildtrees/azure-kinect-sensor-sdk/src/v1.4.1-4c7ddb5afb.clean
-- Configuring x64-osx-dbg
CMake Error at /Users/adammac/dev/vcpkg/scripts/buildsystems/vcpkg.cmake:653 (_find_package):
  Could not find a package configuration file provided by "libuvc" with any
  of the following names:

    libuvcConfig.cmake
    libuvc-config.cmake

  Add the installation prefix of "libuvc" to CMAKE_PREFIX_PATH or set
  "libuvc_DIR" to a directory containing one of the above files.  If "libuvc"
  provides a separate development package or SDK, be sure it has been
  installed.
Call Stack (most recent call first):
  CMakeLists.txt:114 (find_package)

It seems that this PR has an issue with libuvc (so it seems like the libusb issue has been solved?)

At least #14750 fixed the issue about libusb, I will try to support OSX after that merged.

Thank you @JackBoosY !

@adammpolak The upstream explicitly supports Linux and Windows.
https://github.com/microsoft/Azure-Kinect-Sensor-SDK#introduction


Multi-WAR support for two additional use cases

Describe the Enhancement
In #402, we merged in multi-war support when building from source. This feature request is to add support for using precompiled assets.
Both of the following cases should work when this feature request is complete:

Precompiled assets path pointing to a directory with multiple WAR files in it, buildpacks see the same
Precompiled assets path pointing to a directory with a single WAR file in it, buildpacks will see the WAR file not an exploded WAR.

Motivation
Support multi-wars when building assets outside of buildpacks.
Steps to Test

mkdir single-war
./mvnw package one of your apps or a Paketo sample app
Move that into the single-war/ directory
pack build -p ./single-war/ and include all the other options for pack build you'd normally use

Pack will use the directory as the application contents, so inside the container buildpacks will see the contents of that folder as /workspace.

mkdir multi-war
./mvnw package one of your apps or a Paketo sample app
Copy that into the multi-war/ directory twice with different names.
pack build -p ./multi-war/ and include all the other options for pack build you'd normally use

Pack will use the directory as the application contents, so inside the container buildpacks will see the contents of that folder as /workspace.

+1

+1

Resolved with #500


Update OAuth2 client BBE

Purpose
$title
Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #20365 into release-stage will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           release-stage   #20365   +/-   ##
==============================================
  Coverage          15.21%   15.21%
==============================================
  Files                 50       50
  Lines               1341     1341
  Branches             208      208
==============================================
  Hits                 204      204
  Misses              1121     1121
  Partials              16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b8e2e4...9a6da23. Read the comment docs.


Sponsor tools to cover

[x] Datree (@kaiwalyakoparkar )
[ ] Teleport (@kaiwalyakoparkar ) (As time permits not sure)

[ ]  https://goteleport.com/docs/database-access/guides/mongodb-atlas/

[x] .xyz domain (@shreemaan-abhishek )
[x] Twillio api (SMS/ whatsapp) (@shreemaan-abhishek )
[x] Google dev library (usage of angular or firebase? https://devlibrary.withgoogle.com/ submit here too if used) (@ashwinexe)
[x] Stream (build an activity feed? ) (@starlightknown )

[x] https://getstream.io/chat/docs/sdk/react/

[x] Allan ai (@starlightknown )
[ ] kubeshop (@kaiwalyakoparkar ) (As time permits not sure)
[x] EddieHub (@kaiwalyakoparkar, @ashwinexe , @starlightknown , @shreemaan-abhishek )
[x] GitHub (@kaiwalyakoparkar, @ashwinexe , @starlightknown , @shreemaan-abhishek )
[ ] Symbl.ai (@starlightknown )

Google dev library is done using Firebase hosting


Support zeebe:VersionTag and zeebe:versionTag errors

zeebe:VersionTag not supported error

zeebe:versionTag not supported error

Related to https://github.com/camunda/camunda-modeler/issues/4480

Requires https://github.com/camunda/camunda-bpmn-js-behaviors/pull/81 and https://github.com/camunda/bpmnlint-plugin-camunda-compat/pull/173.


Clean up C++ code regarding constants

Sometimes we use define macros, sometime static variables, sometimes const variables within a namespace, sometimes constexpr within a namespace, etc etc.
We should agree on a single way.

Merged into #74


mfcc returns NaNs when signal contains zeros

I suppose this behaviour should be avoided:
julia> using MFCC

julia> X, = mfcc(zeros(1000));

julia> any(isnan.(X))
true

Adding a small constant fixes the problem:
julia> X, = mfcc(zeros(1000).+eps());

julia> any(isnan.(X))
false

not sure this is the common practice though...

it would be more numerically stable to clip than to add a constant. Or else consider the log1p function.
Librosa clips to -80 dB by default https://github.com/librosa/librosa/blob/ceb862f6117f959bda0ecc04f6891ea2c80b0ce0/librosa/core/spectrum.py#L1447

See https://github.com/JuliaDSP/MFCC.jl/pull/14


create ~/.escli directory if not exists when adding a new profile

Related Issue
resolve #14
P.S.
Thank you for awesome work!

@BlueWhaleKo Thank you!


[skip ci] Disable GitHub Actions for PRs

Description
Since they don't work on PRs from forks. Not ehough permissions to update status checks.
Related Issues
#2492
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

/cc @amirh

I'm a little confused, checking in this would (if I hadn't revert the origin PR) would mean that we have the status but it's only updates when new PRs are merged?

@fkorotkov Is this still needed?

Nope since moving to https://github.com/cirruslabs/gh-submit-queue


Moments trace is flaky in integration test so ignoring

Goal

Testing

Release Notes

WHAT:
WHY:
WHO:

#621  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on  Graphite

Merge activity

Mar 25, 2:28 AM EDT: @bidetofevil merged this pull request with Graphite.


Goodpie dependency!

Removed pie dependency
Introduced lo dependency

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

10 of 14 (71.43%)  changed or added relevant lines in 3 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.3%) to 77.254%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/opatranslator/opa_translator.go
3
7
42.86%

Files with Coverage Reduction
New Missed Lines
%

standalone_apis.go
4
76.6%

Totals

Change from base Build<PHONE_NUMBER>:
-0.3%

Covered Lines:
1311

Relevant Lines:
1697

💛  - Coveralls


Restore job detail title font

Webportal Font Solution:

FontClassNames (Use to custom text)
Different classname has different default styles. Incudes:

FontSize
FontWeight
FontFamily: A font map for different language with a fallback const FontFamilyFallbacks = `'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif`;

Text component (Recommended to use as default text)
Has a parameter variant to control the font styles.

Tachyons. The tachyons css module is not recommended right now. However the history code still has tachyons styles. Will be removed step by step.

Coverage remained the same at 34.037% when pulling eaa03b796b8d3cb959e8572e6b63b5d00a44f53e on font into 5467091c462ad51b46133b9e866922e44601f5a4 on master.


Handle metal3 separately

They don't exist in OCP 4.12 and below,
and they would fail gathering all other resources
ECOPROJECT-1899

/retest

/cherry-pick release-0.7

/approve

/lgtm

/lgtm
Giving a chance to get more reviews, feel free to unhold
/hold

/lgtm
/unhold


Change spring-sleuth package to include version.

Use the "-v1x" for this package. when we add support for sleuth 2.x we will use "-v2x"

Codecov Report

Merging #1417 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1417   +/-   ##
=========================================
  Coverage     83.71%   83.71%
  Complexity     1522     1522
=========================================
  Files           233      233
  Lines          6993     6993
  Branches        661      661
=========================================
  Hits           5854     5854
  Misses          939      939
  Partials        200      200

Impacted Files
Coverage Δ
Complexity Δ

...trib/spring/sleuth/v1x/OpenCensusSleuthTracer.java
59.83% <ø> (ø)
23 <0> (?)

.../spring/sleuth/v1x/OpenCensusSleuthProperties.java
0% <ø> (ø)
0 <0> (?)

...ontrib/spring/sleuth/v1x/OpenCensusSleuthSpan.java
80.95% <ø> (ø)
5 <0> (?)

.../sleuth/v1x/OpenCensusSleuthAutoConfiguration.java
0% <ø> (ø)
0 <0> (?)

.../sleuth/v1x/OpenCensusSleuthSpanContextHolder.java
84.44% <ø> (ø)
16 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aefcc4...24237db. Read the comment docs.


Archeology: How to get source maps in 0.x?

I've been reading the docs of node-sass 0.9.6 and below and have tried to follow the README's instructions on how to get source maps.
This is my config
var stats = {};

sass.renderSync({
  file: 'foo.scss',
  sourceComments: 'map',
  sourceMap: 'foo.map',
  stats: stats
});

When running the above config I get stats.sourceMap as undefined.
What am I missing?

It seems like outFile: [path: String] in options is missing, which is mandatory to generate source-maps in trans-compilation.
For some other reason, libsass does not infer the output path from input path (by merely replacing extensions), even when source-map is requested. Also, the philosophy of node-sass is to remain slim wrapper and bring about transparency between libsass and consumer (without injecting/setting options on behalf of consumer).

Right, I did miss that option. Only in my example in this issue though. That should teach me to copy/paste my examples instead of retyping :)
Anyway, what I am trying to do is create a node-sass version agnostic compatibility layer for tool integrators. It's supposed to allow them to use the latest node-sass API, but let the consumer decide what version of node-sass they are running, and everything should still "just work".
The only thing I'm missing at the moment are sourcemaps from 0.x in these cases:

sass.[render | renderSync]({ data: '...' }): No matter what sourcemaps settings I provide there will never be a sourcemap from render via data.
sass.renderSync({ file: '...' }): renderSync seems to not create sourcemaps either.

These are my test cases: https://github.com/Munter/node-sass-evergreen/blob/master/test/test-sourceMap.js
I've added overrides for render with data and renderSync with file in order to make my tests pass for now.
Any insights in possibly wrong or missing configuration? Or were these cases simply not covered by sourcemaps in version 0.x?

The following is producing source-map on Windows with<EMAIL_ADDRESS>require('node-sass').render({
  file: 'blah.scss',
  outFile: 'blah.css',
  sourceMap: true,
  success: function(css, map){console.log(css, map)}})
// .render() returns the generated code and does not write to file-system

require('node-sass').renderFile({
  file: 'blah.scss',
  outFile: 'blah.css',
  sourceMap: true,
  success: function(cssFilePath, mapFilePath){console.log(cssFilePath, mapFilePath)}})
// .renderFile() writes to file-system and returns path


Update drupal-ionic for Drupal 8

Very cool project!
D8 has built in REST API using HAL.  Do you have any plans to update this to work with D8?

I'd be interesting in forking or a redux using ionic  and D8.

I'll get started with that now that Drupal8 is officially released!

Want some help? I was thinking about rolling the Drupal backend into docker

Ionic 2 might also be a good fit. @flexgrip - Drupal 8 docker also sounds like a good idea https://github.com/mglaman/platform-docker may be a good fit as an example.

Ionic2 is in beta as Angular2 is still in beta as well, I'm worried that if we use NG2/Ionic2 and then stuff changes a lot it will break a lot our build, what do you think?
About the docker that sounds great! You could create the backend stuff @flexgrip

I think you're right. It looks like, for right now, ionic 2 cli works with existing angular/ionic 1 apps. Maybe it's best to continue with ionic 1 and Drupal 7, but then branch ionic 2 with D8.
For my purposes, I've found out a lot of the modules I need in D8 are not ready. Stripe subscription stuff, etc.
However, I'm going try and muddle through. So yes, I'll whip up a docker build of D8 that's made to work with your project out of the box.

Sound good?

Actually, I'm going to create a D7 companion for this in docker as well. Both will be hosted on the registry :)

@flexgrip sounds perfect. Let me know about the D7 services and endpoints, maybe you could setup an API doc wherever you wish for me to integrate into ionic. This ionic repo is using an old version of ionic so I will work on updating it and improve it. We could setup a gitter conversation maybe
Any help is well received from other contributors.

What do you guys think about having a yeoman generator for drupal-ionic ?

Well, I don't know. I have some not so liberal views on the current JS trends. I'd be hesitant to make any project too dependent on all the js stuff.
However, yeoman seems to be ok. I figured you'd eventually make it into a 3rd party installable npm package. But that's probably too deep.

I think that an NPM package that installs or generate a new project it's a good way to go, maybe way more complicated than a yeoman generator, but more profesional. I want something like 'drupal-ionic generate projectName` and that will generate the ionic app with our services n stuff

I think this is already not valid for the current d8 version?


HDDS-10452. Improve Recon Disk Usage to fetch and display Top N records based on size.

What changes were proposed in this pull request?

This pull request introduces enhancements to the Recon disk usage endpoint to significantly improve usability and performance when dealing with large datasets:
Top Entities Focus: The endpoint has been updated to efficiently sort and display only the top entities by size. This targeted approach helps users easily identify the most significant space consumers, addressing the impracticality of visualizing thousands of records in a single view.
Efficient Sorting with Parallel Streams: To manage and sort vast numbers of records effectively, we've implemented parallel stream processing.
Key advantages of using parallel streams include :-

Better Utilization of Multi-core Processors: Enables concurrent sorting operations across multiple cores, drastically cutting down processing times for large datasets.
Optimized for Large Datasets: The parallelism overhead is more efficiently distributed over a large number of elements, making it particularly suited for our use case.

What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10452
How was this patch tested?
Manually Tested Out the API and also using Integration Testing :-
Results from Manual Testing :-

Created 4 files of 100MB, 10MB, 1MB & 10KB under dir-1

{
  "status": "OK",
  "path": "/volumetest/buckettest/dir1",
  "size": 111010000,
  "sizeWithReplica": -1,
  "subPathCount": 4,
  "subPaths": [
    {
      "key": true,
      "path": "/volumetest/buckettest/dir1/key100MB",
      "size": 100000000,
      "sizeWithReplica": -1,
      "isKey": true
    },
    {
      "key": true,
      "path": "/volumetest/buckettest/dir1/key10mb",
      "size": 10000000,
      "sizeWithReplica": -1,
      "isKey": true
    },
    {
      "key": true,
      "path": "/volumetest/buckettest/dir1/key1MB",
      "size": 1000000,
      "sizeWithReplica": -1,
      "isKey": true
    },
    {
      "key": true,
      "path": "/volumetest/buckettest/dir1/key10kb",
      "size": 10000,
      "sizeWithReplica": -1,
      "isKey": true
    }
  ],
  "sizeDirectKey": 111010000
}

@devmadhuu and @dombizita could you please take a look?

@ArafatKhan2198
Arfafat Can you set Limit on API

@devmadhuu @adoroszlai @smitajoshi12
Could you please review the latest changes? Here's a quick summary:

Switched to Parallel Sorting: To improve performance, we're now using parallel sorting. More details are in the description.
Added a Toggle for Sorting: There's a new boolean flag to turn sorting on or off.
Set a Limit of 30 Records: We've added a constant to limit the response to the top 30 records in Disk Usage.

@devmadhuu @adoroszlai @smitajoshi12
Could you please review the latest changes? Here's a quick summary:
* Switched to Parallel Sorting: To improve performance, we're now using parallel sorting. More details are in the description.

* Added a Toggle for Sorting: There's a new boolean flag to turn sorting on or off.

* Set a Limit of 30 Records: We've added a constant to limit the response to the top 30 records in Disk Usage.

Thanks @ArafatKhan2198 for handling some points. However I am not sure if parallelStreaming always improves performance, in fact rather sometimes, it increases more overhead and may do bad than good. I would like you to have a look here.

@devmadhuu @adoroszlai @smitajoshi12
Could you please review the latest changes? Here's a quick summary:
* Switched to Parallel Sorting: To improve performance, we're now using parallel sorting. More details are in the description.

* Added a Toggle for Sorting: There's a new boolean flag to turn sorting on or off.

* Set a Limit of 30 Records: We've added a constant to limit the response to the top 30 records in Disk Usage.

Thanks @ArafatKhan2198 for handling some points. However I am not sure if parallelStreaming always improves performance, in fact rather sometimes, it increases more overhead and may do bad than good. I would like you to have a look here.

Thanks a lot, devmadhuu, for the comment and the article! I've read through it carefully and here's my analysis:
Parallel Streaming concern:

Parallel streams introduce overhead for managing multiple threads.
This overhead can outweigh the benefits of parallel processing for small datasets or simple operations.

After going through the article I can summarise the following ➖

Factors affecting performance:

Data size: Parallel streams benefit from large datasets where the overhead is justified.

This sorting algorithm will be applied to response objects at a single level in the file system hierarchy, which could potentially encompass several hundred thousand items in the worst-case scenario under ideal conditions.

Computation intensity: Operations involving complex calculations benefit more from parallelization.

Sorting is considered a moderately complex calculation in the context of parallelization.

Stream source: Easily splittable sources like arrays perform better in parallel streams,

We are using Lists as our source.

@ArafatKhan2198 @devmadhuu Please omit @mention when quoting the message that asked for review.  Including it re-subscribes folks mentioned who may have already unsubscribed from the discussion (sorry, I don't have time to review this).

@devmadhuu @adoroszlai @smitajoshi12
Could you please review the latest changes? Here's a quick summary:
* Switched to Parallel Sorting: To improve performance, we're now using parallel sorting. More details are in the description.

* Added a Toggle for Sorting: There's a new boolean flag to turn sorting on or off.

* Set a Limit of 30 Records: We've added a constant to limit the response to the top 30 records in Disk Usage.

Thanks @ArafatKhan2198 for handling some points. However I am not sure if parallelStreaming always improves performance, in fact rather sometimes, it increases more overhead and may do bad than good. I would like you to have a look here.

Thanks a lot, @devmadhuu , for the comment and the article! I've read through it carefully and here's my analysis:
Parallel Streaming concern:

Parallel streams introduce overhead for managing multiple threads.
This overhead can outweigh the benefits of parallel processing for small datasets or simple operations.

After going through the article I can summarise the following ➖

Factors affecting performance:

Data size: Parallel streams benefit from large datasets where the overhead is justified.

This sorting algorithm will be applied to response objects at a single level in the file system hierarchy, which could potentially encompass millions of items in the worst-case scenario under ideal conditions.

Computation intensity: Operations involving complex calculations benefit more from parallelization.

Sorting is considered a moderately complex calculation in the context of parallelization.

Stream source: Easily splittable sources like arrays perform better in parallel streams,

We are using Lists as our source.

Do we have any performance measure data  over 1 million records at least with and without parallel streaming. I am emphasizing it because I have experienced , that even with few 10K of records, parallel streaming do bad more than good. So I would suggest to publish some figures of performance with and without parallel streaming at least with 1 million records.

@devmadhuu @adoroszlai @smitajoshi12
Could you please review the latest changes? Here's a quick summary:

Switched to Parallel Sorting: To improve performance, we're now using parallel sorting. More details are in the description.
Added a Toggle for Sorting: There's a new boolean flag to turn sorting on or off.
Set a Limit of 30 Records: We've added a constant to limit the response to the top 30 records in Disk Usage.

Pls check on UI, what is the max limit in dropdown we are setting and using. I think its changed to 10k+. Pls check and confirm.

Could you please review the latest changes? Here's a quick summary:
* Switched to Parallel Sorting: To improve performance, we're now using parallel sorting. More details are in the description.

* Added a Toggle for Sorting: There's a new boolean flag to turn sorting on or off.

* Set a Limit of 30 Records: We've added a constant to limit the response to the top 30 records in Disk Usage.

Thanks @ArafatKhan2198 for handling some points. However I am not sure if parallelStreaming always improves performance, in fact rather sometimes, it increases more overhead and may do bad than good. I would like you to have a look here.

Thanks a lot, @devmadhuu , for the comment and the article! I've read through it carefully and here's my analysis:
Parallel Streaming concern:

Parallel streams introduce overhead for managing multiple threads.
This overhead can outweigh the benefits of parallel processing for small datasets or simple operations.

After going through the article I can summarise the following ➖

Factors affecting performance:

Data size: Parallel streams benefit from large datasets where the overhead is justified.

This sorting algorithm will be applied to response objects at a single level in the file system hierarchy, which could potentially encompass millions of items in the worst-case scenario under ideal conditions.

Computation intensity: Operations involving complex calculations benefit more from parallelization.

Sorting is considered a moderately complex calculation in the context of parallelization.

Stream source: Easily splittable sources like arrays perform better in parallel streams,

We are using Lists as our source.

Do we have any performance measure data over 1 million records at least with and without parallel streaming. I am emphasizing it because I have experienced , that even with few 10K of records, parallel streaming do bad more than good. So I would suggest to publish some figures of performance with and without parallel streaming at least with 1 million records.

Thanks for the comments @devmadhuu tested this out on a cluster with 10 million keys,
These were the results :-
Sequential sort time: 7657 ms
Parallel sort time: 1279 ms

I believe we could got with parallel sort.

Could you please review the latest changes? Here's a quick summary:
* Switched to Parallel Sorting: To improve performance, we're now using parallel sorting. More details are in the description.

* Added a Toggle for Sorting: There's a new boolean flag to turn sorting on or off.

* Set a Limit of 30 Records: We've added a constant to limit the response to the top 30 records in Disk Usage.

Thanks @ArafatKhan2198 for handling some points. However I am not sure if parallelStreaming always improves performance, in fact rather sometimes, it increases more overhead and may do bad than good. I would like you to have a look here.

Thanks a lot, @devmadhuu , for the comment and the article! I've read through it carefully and here's my analysis:
Parallel Streaming concern:

Parallel streams introduce overhead for managing multiple threads.
This overhead can outweigh the benefits of parallel processing for small datasets or simple operations.

After going through the article I can summarise the following ➖

Factors affecting performance:

Data size: Parallel streams benefit from large datasets where the overhead is justified.

This sorting algorithm will be applied to response objects at a single level in the file system hierarchy, which could potentially encompass millions of items in the worst-case scenario under ideal conditions.

Computation intensity: Operations involving complex calculations benefit more from parallelization.

Sorting is considered a moderately complex calculation in the context of parallelization.

Stream source: Easily splittable sources like arrays perform better in parallel streams,

We are using Lists as our source.

Do we have any performance measure data over 1 million records at least with and without parallel streaming. I am emphasizing it because I have experienced , that even with few 10K of records, parallel streaming do bad more than good. So I would suggest to publish some figures of performance with and without parallel streaming at least with 1 million records.

Thanks for the comments @devmadhuu tested this out on a cluster with 10 million keys, These were the results :-
Sequential sort time: 7657 ms
Parallel sort time: 1279 ms

I believe we could got with parallel sort.

Thanks @ArafatKhan2198 for testing out and publish the figures. This looks promising.

@dombizita Could you please take a final look at it!
I believe we are done and can merge it

Thanks @ArafatKhan2198  for working on this patch.


OLM OperatorGroup targetNamespace not respected

When deploying through the Operator Lifecycle Manager (OLM) the grafana-operator deployed will only watch the namespace it's deployed into.
This is a problem for us as we strictly divide the operators from the actual project.
So for example we would have a namespace my-project that is team managed and an other namespace my-project-operators where all operators supporting the my-project namespace reside.

The prometheus operator seems to do this by reading the olm.targetNamespaces annotation that it gets assigned by OLM.
If I read the grafana-operator.v2.0.0.clusterserviceversion.yaml correctly, it would also be possible for this project.
I'd assume that metadata.annotations['olm.targetNamespaces'] could be read instead of the current fieldRef to metadata.namespace.
As I'm not sure how to test this locally I'm here for your opinion.

@zetaron Right, at the moment when you install via operatorhub you only get a single namespace setup. The operator has multi namespace support for dashboards. Grafana and DataSource CRs still need to be created in the operators namespace.
As far as i know, OLM does not offer a way to provide a list of namespaces for the operator to watch (only single or all) even though the operator supports it using the --namespaces flag.
So i wonder what the value of olm.targetNamespaces would be if you select all namespaces?
I can give this a try locally with OLM.

@pb82 What would it take to be able to create the Grafana and DataSource CRs in an operated (watched) namespace, that is not the one where the operator itself is deployed?
If I understand they way OLM works correctly the olm.targetNamespaces annotation is fed by the OperatorGroup responsible for a given namespace/subscription. On the OperatorGroup CR the targetNamespaces field is a list.
Reading the Documentation on Understanding the Operator Lifecycle Manager (OLM), specifically Table 1. InstallModes and supported OperatorGroups the annotation should be an empty string if all namespaces are to be operated/watched on.

@zetaron I think multi namespace support would also mean multi instance support. And from the top of my head, the biggest hurdle to true multi namespace support is that the operator currently assumes that there is only one instance of Grafana (per operator instance). For example, the operator internally keeps track of the credentials and URL to Grafana (see here). If we allow Grafana CRs in multiple other namespaces, then we must also make sure that the Operator can manage multiple instances.
We'd also need to change the way dashboards are imported: currently there is one set of label selectors. With true multi namespace support, every Grafana instance would have its own dashboard selector and they might even overlap. So to import a dashboard we would have to figure out all Grafana instances (and their urls, credentials...) that have matching selectors.
And data sources would also need a selector mechanism similar to dashboards which is currently not the case.

I can give this a try locally with OLM.

@pb82 Can you try this out to see if it's possible (or should be possible)

@zetaron we'll re-evaluate this when we begin working on multi namespace support and cluster level operators.

@pb82 isn't this solved by v5?

@pb82 bump

Hi @zetaron Is this still an issue? Just going back through our oldest issues, not sure if this was resolved yet or not, the version you've indicated it for was ~3 major releases ago.
I'll close off this issue for now, feel free to re-open if it's still applicable, however, as it stands, v2 is no longer supported