Exception when 'import' is used in comments

A freshly installed pipreqs (in a venv) crashes on pylint source (in a venv in my case)
Offending line is: https://bitbucket.org/logilab/pylint/src/cc5990f6a12a467d09567bfc1b210ba999f6cb13/pylint/test/functional/unused_import.py?at=default#cl-3
~/src/c3 $ pipreqs .
Traceback (most recent call last):
  File "/home/koert/src/c3/.ve2/bin/pipreqs", line 11, in <module>
    sys.exit(main())
  File "/home/koert/src/c3/.ve2/local/lib/python2.7/site-packages/pipreqs/pipreqs.py", line 167, in main
    init(args)
  File "/home/koert/src/c3/.ve2/local/lib/python2.7/site-packages/pipreqs/pipreqs.py", line 139, in init
    candidates = get_all_imports(args['<path>'])
  File "/home/koert/src/c3/.ve2/local/lib/python2.7/site-packages/pipreqs/pipreqs.py", line 48, in get_all_imports
    res = map(get_name_without_alias, item.split(","))
  File "/home/koert/src/c3/.ve2/local/lib/python2.7/site-packages/pipreqs/pipreqs.py", line 130, in get_name_without_alias
    name = REGEXP[0].match(name.strip()).groups(0)[0]
AttributeError: 'NoneType' object has no attribute 'groups'
~/src/c3 $ pip freeze
docopt==0.6.2
pipreqs==0.2.4
requests==2.7.0
yarg==0.1.9

same problem here. i tried installing pipreqs with pipsi. get the same error.

Fixed in version 0.2.5

Wow. That's some fast response time. Thank you.

While testing this fix, I just ran pipreqs over a collection of virtualenvs on my dev machine. I found these lines causing similar issues with version 0.2.5
# astroid
import zipimport  # manager.py
import import_package_subpackage_module  # tests/testdata/python2/data/package/absimport.py

# IPython
from importlib.machinery import all_suffixes  # core/completerlib.py
import importlib  # html/notebookapp.py
from IPython.utils.importstring import import_item  # Many files

# Nose
from nose.importer import Importer, add_path, remove_path  # loader.py

# pyflakes
from pyflakes.test.test_imports import Test as TestImports  # test/test_doctests.py

# setuptools
import zipimport  # command/easy_install.py

# twisted
from importlib import invalidate_caches  # python/test/test_deprecate.py

Interesting, thanks for reporting.

This should be fixed in the latest version, I've added your test cases https://github.com/bndr/pipreqs/blob/master/tests/_data/test.py

I can confirm all of the above issues are fixed.
I've run pipreqs on all of the virtualenvs on our CI, and I had no more crashes; so pipreqs is able to parse at least most popular (and a few less popular) codebases.

Thanks, if you come across any more bugs, feel free to open an Issue.
On Tue, May 12, 2015 at 8:18 am, bndr/pipreqs
<EMAIL_ADDRESS>wrote:
I can confirm all of the above issues are fixed.
I've run pipreqs on all of the virtualenvs on our CI, and I had no more crashes;
so pipreqs is able to parse at least most popular (and a few less popular)
codebases.
—
Reply to this email directly or view it on GitHub
[https://github.com/bndr/pipreqs/issues/17#issuecomment-101149320] .[https://github.com/notifications/beacon/ABF6cF0Vnlb9AFaU-6zL9CVulxkzljVGks5oIZLIgaJpZM4EWSGJ.gif]


Fix setting vmin vmax

closes #303
Fixes the problem in #303. Main problem is that clipping for the Normalize object is set to False by default in matplotlib. I have set this value to True and added tests. I don't think we currently have a usecase for setting it to False, but feel free to comment if there is a usecase for us currently.

Code lgtm, but can you add the fix to the changelog? Also, what do you think of plotting a 2x1 grid with the non-clipped and clipped image so it's visually easy see the difference?

added to changelog. Regarding 2 x 1 grid, I would if ncols was working xD. I don't want to create a fig object here now.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.35%. Comparing base (1b9b577) to head (179951b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
+ Coverage   80.21%   80.35%   +0.13%
==========================================
  Files          11       11
  Lines        1739     1746       +7
==========================================
+ Hits         1395     1403       +8
+ Misses        344      343       -1

Files
Coverage Δ

src/spatialdata_plot/pl/utils.py
70.21% <100.00%> (+0.34%)
:arrow_up:

Why the aversion against the fig object? Used it f.e. in the 0-transparency cmap PR: https://github.com/scverse/spatialdata-plot/pull/302/files#diff-59872f651a8fef967621d774a8b7441219dc474f1d9604424c54fe19a162bbfd

I would just solve the issue with ncols as well:) like I would not add more code in a test because of ncols, though behavior in this case is a bit tricky

added the baseline to the test for now and will open an issue on ncols as argument


Can you provide the link for 2.2 times cropped dataset of MPII+NZSL hand dataset?

Hi,
Great work guys!
Can you also provide the link for the MPII+NZSL hand dataset which is 2.2B times cropped?

It is the Hands with Manual Keypoint Annotations dataset from here.

Hey, actually the question I was trying to ask was about the cropped hand images, can you provide the script for cropping hands from the MPII +NZSL dataset images or a 2.2B cropped hand MPII + NZSL dataset with annotations?

The cropping is done in the dataset file: https://github.com/MichiganCOG/ViP/blob/master/datasets/Manual_Hands.py#L82
It's more efficient to make those changes on-the-fly rather than creating new images.


some corrections

fix Delete EventSub Subscription documentation
Correct documentation for parse_response
remove note about overriding
add Self: Sized to methods that are missing it
CheckUserSubscription -> CheckUserSubscriptionRequest
fix mention of ChannelRaid Beta

bors r+


Fix upload progress indicator in Google Cloud Storage target

Line 144 of luigi/contrib/gcs.py in master tries to multiply 100 * a MediaUploadProgress object, resulting in TypeError. A little hard to detect, unless uploading a file that takes several chunks to upload. This sample code:
# coding: utf-8

import luigi
from luigi.contrib import gcs
import os

bucket_name = os.getenv('GSCBUCKET', 'warehouse-hadoop')

class GCSUpload(luigi.Task):

    def output(self):
        target = 'gs://%s/tmp/big' % bucket_name
        return luigi.contrib.gcs.GCSTarget(target)

    def run(self):
        f = self.output().open(mode='w')
        f.write("\0" * 10000000)
        f.close()

Results in the following error:
  File "/Users/thomas/Dropbox/envs/etl-luigi/lib/python2.7/site-packages/luigi/contrib/gcs.py", line 145, in _do_put
    logger.debug('Upload progress: %.2f%%', 100 * progress)
TypeError: unsupported operand type(s) for *: 'int' and 'MediaUploadProgress'

While patched gcs.py in my branch logs progess as expected.

Thanks! But I would like to have a text case too, if possible. :)

I'll see what I can do

Ahem. The current gcs_test.py is like:
@attr('gcloud')
class GCSTargetTest(_GCSBaseTestCase, FileSystemTargetTestMixin):

    def create_target(self, format=None):
        return gcs.GCSTarget(bucket_url(self.id()), format=format, client=self.client)

    def test_text(self):
        """
        Skipping this test, not sure if UNICODE is working yet.

        Here's a failing which caused me to mute this test for now:

        https://travis-ci.org/spotify/luigi/jobs/66188889
        """
        pass

    def test_atomicity(self):
        """
        Intermittent failure in
        https://travis-ci.org/spotify/luigi/jobs/69597336
        """
        pass

Just sayin'. ;)
Still, I'll see if I can make a test that works. Despite the comment above, I don't think unicode is the issue here.

OK, looking at this a little closer, there is a test_put_file in the GCSClientTest class that isn't just a pass. Right now the file just says "hi"—I think all I have to do is get it to generate a larger file, and it will show the TypeError.

gcs_test.py updated with a > CHUNKSIZE write in test_put_file. Now fails with gcs.py in HEAD, and passes with my fix.

Great. Thanks @tym :)


native: changing the parentDir of a sharedLibraryLinkFile is not honored if different from the parentDir of the sharedLibraryFile

Changing the parent directory of a sharedLibraryLinkFile is not honored when this parent directory is different from the parent of the sharedLibraryFile
Expected Behavior
No error
Current Behavior
 Task :linkMainDebugExecutable
LINK : fatal error LNK1104: cannot open file 'C:\Users\fandre\Documents\git\gradle\subprojects\docs\src\samples\native-binaries\cpp\lib\Pocohellod.lib'

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':linkMainDebugExecutable'.
> A build operation failed.
      Linker failed while linking maind.exe.
  See the complete log at: file:///C:/Users/fandre/Documents/git/gradle/subprojects/docs/src/samples/native-binaries/cpp/build/tmp/linkMainDebugExecutable/output.txt

Context
I am trying to put all sharedLibraryFiles in a bin directory while putting all the corresponding sharedLibraryLinkFile in a lib directory
Steps to Reproduce (for bugs)
Override the build.gradle in gradle\subprojects\docs\src\samples\native-binaries\cpp by the one in attachement and build the project.
Your Environment

Build scan URL: https://scans.gradle.com/s/m3ndk5vg4tp4s#summary
build.gradle.txt

@lacasseio Could you have a look?

Thanks for submitting this issue. It is effectively an overlook in term of functionality with regards to MSVC and MinGW. To work around this limitation, I suggest the following modification to the build script:
[...]
if (it instanceof SharedLibraryBinarySpec) {
    sharedLibraryFile = toBin(prefixByPoco(sharedLibraryFile))
    sharedLibraryLinkFile = toLib(prefixByPoco(sharedLibraryLinkFile))

    // WINDOWS ONLY
    linker.args "/implib:${sharedLibraryLinkFile}"  // For MSVC only
    // use the following for MinGW
    // linker.args "-Wl,--out-implib,${sharedLibraryLinkFile}"

    // This next part is simply to ensure the directory is created as the compiler (tested on MSVC only) won't create it
    def binary = it  // Simply to expose the binary in the `doFirst`
    tasks.withType(LinkSharedLibrary) {
        doFirst {
            binary.sharedLibraryLinkFile.parentFile.mkdirs()
        }
    }
} else if (...

This feature requires a bit more discussion as MSVC and MinGW provide linker flags to specify the output location of the import library but differ for other compilers in functionality. This epic will track the solution for this issue. Until then, I'm closing this issue.


RFC: Licensing

@awalias I'm interested on your take on licensing.
There seem to be a wave of great opensource projects that have to switch to a more restrictive license, basically because their existence is threatened by the big cloud players. Here are some that I know of using Business Source.

Sentry -> BSL | Dicsussion
Cockroach -> BSL | Discussion
Redis -> Apache2 + Commons | Discussion
Mongo -> SSPL | Discussion

I really like MIT / Apache2.0, but I have to sympathise with these companies. I think no matter what, we have to be on a fully permissive license (for everything?), but keen to hear your thoughts.

Apache2 it is


Enable NuGet updater image to support arm64

The NuGet updater image depends on powershell but currently only an amd64 package is provided, not arm64.  While production is on amd64 machines, contributors might be on ARM and could benefit from being able to build and run locally.
As of PowerShell version 7.4.5, there is no arm64 .deb file provided for installation, but there is a .tar.gz with pre-built binaries that could be extracted to the image.  Docker supports predefined values that can be used to determine the architecture of the underlying machine: https://docs.docker.com/build/building/variables/#multi-platform-build-arguments

FYI, I have added PR to fix this issue. It's fairly straight forward, TARGETARCH variable is already used in quite a few other dockerfiles


[Feature Request] Inline datepicker

Existing Component
Yes
Component Name
Datepicker
Description
Inline display datepicker like https://jqueryui.com/datepicker/#inline

Sorry, we have no plan to support this.

You might be interested in https://github.com/ElemeFE/element/issues/9878
Though there is no clear timeline when such a major version will be released.


[Snyk] Upgrade @lion/ui from 0.5.6 to 0.6.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @lion/ui from 0.5.6 to 0.6.0.
As this is a private repository, Snyk-bot does not have access. Therefore, this PR has been created automatically, but appears to have been created by a real user.
:sparkles: Snyk has automatically assigned this pull request, set who gets assigned.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 8 versions ahead of your current version.
The recommended version was released 23 days ago, on 2024-03-27.

Release notes

Package name: @lion/ui

0.6.0 - 2024-03-27BREAKING:

[form] set focus to the first erroneous form element on submit (mildly breaking, since it could conflict with custom focus management)
Update to lit version 3
Moved to scoped-elements v3

Patch Changes

[input-tel-dropdown] use ScopedElementsMixin in to run test-suite with select-rich
[core] add Firefox to browserDetection
[textarea] set box-sizing in tests to make it work cross browser
[input-stepper] fix the toggling of the disabled state for the buttons
[core] update types for ScopedElementsMixin
[form-core] order aria-labelledby and aria-describedby based on slot order instead of dom order
[input-range] add screen-reader labels for minimum and maximum value
[form-core] remove fieldset label/helpt-text from input-field aria-labelledby/aria-describedby. See #1576
[validation-messages] get correct validation min and max dates in French
[form-core]: set aria-disabled next to the disabled attribute for NVDA screen reader
[input-stepper] a11y enhancement & added translations
[checkbox-group] add role="list" and role="listitem" to checkbox-indeterminate and its children

0.6.0-beta.0 - 2024-03-26Minor Changes

beta release with:

Update to lit version 3
Moved to scoped-elements v3

0.6.0-alpha.5 - 2024-03-18Minor Changes

[core] allow SlotRerenderObject to first render on connectedCallback via firstRenderOnConnected

Patch Changes

[tests] fix type errors for SlotMixin.test.js
[input-tel-dropdown] use ScopedElementsMixin in to run test-suite with select-rich
[core] add Firefox to browserDetection
[overlays] skip local-positioning tests for Firefox, and added a todo to fix later
[textarea] set box-sizing in tests to make it work cross browser

0.6.0-alpha.4 - 2024-03-05

0.6.0-alpha.3 - 2024-02-26

0.6.0-alpha.2 - 2024-02-13

0.6.0-alpha.1 - 2024-02-07

0.6.0-alpha.0 - 2023-12-19

0.5.6 - 2024-03-20Patch Changes

e6b8dd1: [@ lion/ui]: Fix "Multiple versions of Lit loaded." by pinning @ open-wc/scoped-elements version.
8b7cc43: feat: allow SlotRerenderObject to first render on connectedCallback via firstRenderOnConnected

    from @lion/ui GitHub release notes

Commit messages

Package name: @lion/ui

79a6467 Merge pull request #2231 from ing-bank/release-0.6.0
2e3ba64 chore: correct changelog for 0.6.0 release
3955951 chore(ui): release 0.6.0
ef4acf2 chore(ui) release 0.6.0-alpha.5
7ecf043 fix: type errors for SlotMixin.test.js
8b90d52 feat: allow SlotRerenderObject to to first render on connectedCallback via `firstRenderOnConnected`
21a4ef5 chore: update scopedElementsMixin documentation (#2217)
61db0ed fix(overlays): skip local-positioning tests for firefox, added a todo to fix later
a847f99 fix(textarea): fix box-sizing inside tests to make it work cross browser (#2210)
2fab9e5 fix(input-tel-dropdown): use ScopedElementsMixin in to run test-suite with select-rich (#2209)
e211f3c chore(ui): release 0.6.0-alpha.4
e34d4b6 chore(release): 0.6.0-alpha.4
8fd440d fix(ui): type fixes ScopedElements
ea71f61 fix(ui): LionInputStepper focus issue
f1630c0 chore(release): 0.6.0-alpha.3
31e079d feat(form): set focus to the first erroneous form element on submit
69f9d81 fix(validation-messages): get correct validation min and max dates in French (#2163)
9745609 chore: remove validate-messages.js as redundant
72bc630 chore(ui): release 0.6.0-alpha.2
b032d96 chore: do an alpha release bypassing changeset pr
00a7e39 feat(ui): adopt @ open-wc/scoped-elements mixin v3
8bd2755 chore: update to lit3 and other dependencies
44bc4bf Version Packages
3737c49 fix(providence-analytics): allow compatibility with node 16

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
👩💻 Set who automatically gets assigned
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

https://github.com/tokens-studio/style-dictionary-configurator/pull/103


feat: docker setup for development environment

Issue Ticket Number

#69

Description
Added docker setup for development environments
Breaking Changes

[ ] Yes
[x] No

If your feature introduces breaking changes or if something is missing, please mention the related issue tickets.
Development Tested?

[x] Yes
[ ] No

Confirm whether the changes have been tested locally during development.
Tested in Staging?

[x] Yes
[ ] No

Indicate whether the changes have been tested in the staging environment for dev to main.
Database Changes

[ ] Yes
[x] No

Does this support hot reload?


Basic documentation on how to set up Prometheus monitoring

Fixes #131.
This is just intended as a basic getting-started guide for now. This does NOT cover:

HA
Prom-per-node (see https://github.com/stackabletech/issues/issues/165)
Thanos archival
Alerts
Grafana

bors r+


Fixed Aimsun Bugs

Pull request information

Status: ready to merge
Kind of changes: bug fix
Related PR or issue:

Description

Replaced scenario with network
fixed Aimsun bugs

Pull Request Test Coverage Report for Build 4579

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.914%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

flow/core/params.py
0
1
0.0%

Totals

Change from base Build 4566:
0.0%

Covered Lines:
9205

Relevant Lines:
10125

💛  - Coveralls


Typedef link to purple same as Keyword

Thank you for your work!
In nvim-treesitter @type.definition is usually used for the identifier of a type definition not the keyword.
See https://github.com/nvim-treesitter/nvim-treesitter/issues/5544
Consider an example in golang with the current highlight groups:
type test int

type and test will be purple here.
I looked up how tokyonight handles this:
https://github.com/search?q=repo%3Afolke%2Ftokyonight.nvim typedef&type=code
No defining Typedef whatsoever.
And indeed @type.definition will be redirected to the Type highlight group, if the line is deleted.

Now Typedef  is changed to Yellow


⚠ Text Filter API Endpoint has degraded performance

In 6cc1fa4, Text Filter API Endpoint (http://textfilter.roblox.com/) experienced degraded performance:

HTTP code: 200
Response time: 9928 ms

Resolved: Text Filter API Endpoint performance has improved in ade3be9.


Begin to remove ProjectSnapshotManagerDispatcher

Commit by commit is encouraged.
This is the beginning work to remove ProjectSnapshotManagerDispatcher, which runs a single thread to synchronize work. Instead, this moves to a SlimReadWriteLock, with an added factory for easy use, to manage reading and writing data.

Marking as ready for review. There are still some known test failures I'm investigating, and PR feedback I will address around naming/usage.

Whats the plan for merging this? Are you hoping to merge and follow up with more PRs, or keep updating this PR? If the former, I think perhaps we should hold this off for 17.8 P1, given its not long til that can happen. Its pretty risky to futz with the project system, and the high (and lazy) use of Moq in the old tests means its hard to get much of an idea of confidence.
Having said that, I didn't review the tests because I'm not sure if I should yet.

Agree this should be 17.8 P1. I'll wait til after snap to merge. Please also review tests. There will be a follow up to get rid of the type (as much as possible), but that will be a more mechanical change once this settles and would just bloat this PR.

Before

Method
Job
Toolchain
Mean
Error
StdDev
Median
Min
Max
Gen0
Gen1
Allocated

'Does thread contention add/remove of documents'
Job-PECWGR
.NET 7.0
14.33 ms
0.194 ms
0.190 ms
14.25 ms
14.10 ms
14.69 ms
1100.0000
10.0000
17.54 MB

'Does thread contention add/remove of documents'
Job-TKGXVZ
.NET Framework 4.7.2
41.29 ms
0.762 ms
1.640 ms
40.67 ms
38.95 ms
46.21 ms
3070.0000
30.0000
18.44 MB

After

Method
Job
Toolchain
Mean
Error
StdDev
Median
Min
Max
Gen0
Gen1
Allocated

'Does thread contention add/remove of documents'
Job-PECWGR
.NET 7.0
12.02 ms
0.152 ms
0.127 ms
12.01 ms
11.80 ms
12.26 ms
1190.0000
20.0000
19.06 MB

'Does thread contention add/remove of documents'
Job-TKGXVZ
.NET Framework 4.7.2
34.87 ms
0.577 ms
0.540 ms
34.69 ms
34.03 ms
35.80 ms
4080.0000
80.0000
24.51 MB

I'm going to take this and break into smaller changes. CI has constantly been a "it works on my machine" and I haven't figured out the root cause of why there's a race between documents getting added to the project and the request for semantic tokens from logs. After a lot of attempts to resolve, breaking up seems like the best next step. I'll link to this PR for all PRs I open.


DependencyResolutionException on SignInManager

I did not know if this should be issued on Identity or Mvc repository, but I chose here because it occurs only with SignInManager.
In short terms:

Create an IAccountServices interface.
Implement that interface in another assembly
In the implementation class, use SignInManager<ApplicationUser> as a parameter on the constructor
Inject the assembly via Autofac

And then, this is the error:
An exception of type 'Autofac.Core.DependencyResolutionException' occurred in Autofac.dll but was not handled in user code

Additional information: An exception was thrown while invoking the constructor 'Void .ctor(Microsoft.AspNet.Identity.UserManager`1[SignInManagerProblem.Models.ApplicationUser], Microsoft.AspNet.Hosting.IHttpContextAccessor, Microsoft.AspNet.Identity.IUserClaimsPrincipalFactory`1[SignInManagerProblem.Models.ApplicationUser], Microsoft.Framework.OptionsModel.IOptions`1[Microsoft.AspNet.Identity.IdentityOptions], Microsoft.Framework.Logging.ILoggerFactory)' on type 'SignInManager`1'.

And the InnerException says:
{"Value cannot be null\r\nParameter name: contextAccessor"}
I made a minimum viable example. Build the Module project and then reference it's DLL on the Startup.cs class. Download it here

Does your container actually have a IHttpContextAccessor service registered at the point where SignInManager is being created?

@HaoK I used those Autofac registrations on the end of the public void ConfigureServices(IServiceCollection services), after all service registrations, although I don't know where IHttpContextAccessor is registered exactly  (maybe with the other Identity services?).
Instancing SignInManager throws this error only in this specific case. Controller, for example, are able to use it without any problem.

Exactly, the service only exists as part of the request (its scoped), so the controller ctor is run during the request.  You can't create an instance of SignInManager outside of the request scope today because it of the IHttpContextAccessor service

@HaoK Oh, it makes sense now. Better use it directly on Controllers for now.


[BUG] form elements can not be dragged

The bug
Whenever I'm trying to drag & drop a form element (button, input, select, textarea, checkbox, radio) - nothing happens. A green line suggesting to attach an element that I'm dragging should appear but it does not happen. This elements can not be used.
"form" and "label" elements work fine.
Ubunut 18.04
Chromium Version 77.0.3865.75 (Official Build) snap (64-bit)
Tested with Opera - the same issue there.

Not a bug https://github.com/artf/grapesjs-plugin-forms/blob/2a49511ecff7ed00062985dffd2306d0df9c461f/src/components.js#L192
If you want form elements to be inserted outside of <form>s just extend and set draggable: true

How can I change default attributes on Demo site for example?
from
draggable: 'form, form *',
to
draggable: true

Not a bug
https://github.com/artf/grapesjs-plugin-forms/blob/2a49511ecff7ed00062985dffd2306d0df9c461f/src/components.js#L192
If you want form elements to be inserted outside of <form>s just extend and set draggable: true

How can I change default attributes on Demo site for example?
from
draggable: 'form, form *',
to
draggable: true


load fails on ubuntu

Hi
When trying to load vss0.so, sqlite3 core-dumps (vector0 succeds):
SQLite version 3.42.0 2023-02-23 14:43:15
Enter ".help" for usage hints.
Connected to a transient in-memory database.
Use ".open FILENAME" to reopen on a persistent database.
sqlite> .load ./vector0
sqlite> .load ./vss0
Illegal instruction (core dumped)

Ubuntu 20.04.5 LTS, freshly compiled sqlite3 from trunk.
Tried to build from source, succeded for vector0 so far (after getting recent cmake ...).
With vss0, stuck here (faiss built appearently in vendor/ in trial before):
~/MAKE/sqlite-vss$ make loadable
cmake -B build; make -C build
-- Could NOT find MKL (missing: MKL_LIBRARIES)
-- Configuring done
-- Generating done
-- Build files have been written to: /home/myself/MAKE/sqlite-vss/build
make[1]: Entering directory '/home/myself/MAKE/sqlite-vss/build'
make[2]: Entering directory '/home/myself/MAKE/sqlite-vss/build'
make[3]: Entering directory '/home/myself/MAKE/sqlite-vss/build'
make[3]: Leaving directory '/home/myself/MAKE/sqlite-vss/build'
[ 48%] Built target faiss_avx2
make[3]: Entering directory '/home/myself/MAKE/sqlite-vss/build'
make[3]: Leaving directory '/home/myself/MAKE/sqlite-vss/build'
make[3]: Entering directory '/home/myself/MAKE/sqlite-vss/build'
[ 49%] Building CXX object CMakeFiles/sqlite-vss.dir/src/extension.cpp.o
/home/myself/MAKE/sqlite-vss/src/extension.cpp:496:34: error: ‘idx_t’ is not a member of ‘faiss’
  496 |   std::vector<std::vector<faiss::idx_t>*> * insert_to_add_ids;
      |                                  ^~~~~

What is the proper way to build from source?
I did copy the source from faiss-1.7.3 into vendor/faiss, same for vendor/sqlite-vector

Hey @baikal , sorry that you had issues here: I've made a ton of build improvements in v0.0.2 (2023-04-10), would you mind giving it another shot? More specifically, the extra sqlite-vector extension was removed, so compiling yourself should be much easier.
In addition, the pre-compiled extensions were fixed, so it should work as-is without the Illegal instruction (core dumped)  error

Building according to docs.md worked like a charm. Thank you.
But I do always get Illegal instruction (core dumped) on the .load ./vss0 part.
In any combination of extensions:

precompiled v0.0.2
v0.0.3
self compiled debug
self compiled release

with sqlite3 versions:

system SQLite version 3.31.1
the one from vender/sqlite SQLite version 3.40.1
recent one from trunk 2023-04-07 11:18:08 c07b62bef96bb69e9b1ce08f0084fdce8de981f4d8ea9689c87a41f1e4451ac7

Thanks for the detailed report! I'm not 100% sure what's happening here, but here are some notes:
On a Docker ubuntu 20.04 image, I'm able to run the pre-compiled binaries fine:
from ubuntu:20.04

RUN apt-get update && apt-get install -y wget sqlite3

ADD https://github.com/asg017/sqlite-vss/releases/download/v0.0.3/sqlite-vss-v0.0.3-vector0-linux-x86_64.tar.gz .
ADD https://github.com/asg017/sqlite-vss/releases/download/v0.0.3/sqlite-vss-v0.0.3-vss0-linux-x86_64.tar.gz .

RUN tar -xvzf sqlite-vss-v0.0.3-vector0-linux-x86_64.tar.gz
RUN tar -xvzf sqlite-vss-v0.0.3-vss0-linux-x86_64.tar.gz

RUN apt-get install -y libgomp1 libatlas-base-dev liblapack-dev

And build + run with this:
$ docker build -t vss-test .
$ docker run --rm -it vss-test sqlite3 :memory: '.load /vector0' '.load /vss0' 'select vss_version()'
v0.0.3

Some ideas to try:

Make sure you have those system libraries installed:  libgomp1 libatlas-base-dev liblapack-dev. I don't think it's this, since then you'd see an error message like "cannot open shared object file:", but worth double checking
Make sure the vector0.so and vss0.so extensions that you are loading are from the same release/build. Here are the checksums I have from v0.0.3:

$ sha256sum vector0.so
4e632fdc9c8cf6b576896b462aed445a622e64a62e6c9caca898b5858419ff5b  vector0.so
$ sha256sum vss0.so
bdfde741e4f0fb2766a1f1af0a77a9fb3b9a5bea82bf04c34f504f9d8f5fa91b  vss0.so

I dont think it's this, but if you're building youself try changing [this line](target_link_libraries(sqlite-vss faiss_avx2)) in CMakeLists.txt from faiss_avx2 => faiss, in case your machine doesn't support these platforms. I dont think it's this, because I think you would see a compile error before it finishes building, but worth a shot
If you're building youself, try adding a few print statements in this block of vss-extension.cpp. If you do see your print statements, see which is the last line of code that works before it fails

Tried with your Dockerfile (using podman instead of Docker). Everything fine up to loading vector0, sudden exit after loading vss0 (no core dump message, but no vss_version output either). Hm, that hints towards the avx2 subject, right?
And yes, the libraries are installed and I always tried the combo vector0.so / vss0.so from the very same version/build.
Changed the faiss_avx2 --> faiss in CMakeLists.txt, and had to do rm -rf build and rm dist/*/* to get make loadable to do anything at all.
But that fixed it:
SQLite version 3.42.0 2023-04-07 11:18:08
Enter ".help" for usage hints.
Connected to a transient in-memory database.
Use ".open FILENAME" to reopen on a persistent database.
sqlite> .load ./vector0
sqlite> .load ./vss0
sqlite> select vss_version();
v0.0.3

Interesting, that the build succeded previously with faiss-avx2 ...

Maybe instead of having 2 versions, the code can check if the processor uses the AVX2 instruction set and then call the appropriate functions. There are some crypto libraries that do that, they detect if the processor has a sha256 and use the hardware accelerated one otherwise use the code one.
GPT returned this code to detect (for GCC):
#include <iostream>
#include <cpuid.h>

bool is_avx2_supported() {
    unsigned int eax, ebx, ecx, edx;

    // Get the highest function parameter for CPUID
    __get_cpuid(0, &eax, &ebx, &ecx, &edx);

    if (eax < 7) {
        // AVX2 is not supported if the highest function parameter is less than 7
        return false;
    }

    // Get the feature flags in ebx using leaf 7 and subleaf 0
    __get_cpuid_count(7, 0, &eax, &ebx, &ecx, &edx);

    // Check the AVX2 bit (bit 5) in ebx
    return (ebx & (1 << 5)) != 0;
}

int main() {
    if (is_avx2_supported()) {
        std::cout << "AVX2 is supported." << std::endl;
    } else {
        std::cout << "AVX2 is not supported." << std::endl;
    }
    return 0;
}

Compiled with:
g++ -o avx2_check avx2_check.cpp && ./avx2_check

Cross-platform solution:
https://stackoverflow.com/questions/6121792/how-to-check-if-a-cpu-supports-the-sse3-instruction-set

Thanks for sharing, didn't know you could do that! Unfortunately, I'm not sure if it'll work here: I think the avx2 instructions are run when SQLite dlopen's the vss0 extension, before any sqlite-vss is even ran. I think the only way to avoid avx2 is to compile Faiss with that different option, which we can't do at runtime

Yes, I looked for AVX2 instructions on sqlite-vss and did not found. Only found the link to faiss-avx2 in the makefile
In this case the check for the presence of AVX2 instructions should be added on FAISS
I saw this discussion and it appears that the faiss binary has support for AVX2 and falls back to slower implementation if it is not present. Exactly what is desired. But I am not sure if that is the case, no time to dive deeper.


Fixed link in README.

Changes
Fix the link in README file.

Thank you for proactively fixing the issue that you've found @jcs090218.
In this case it is as intended, unfortunately.
While that is the correct link, it will change the moment our new domain goes live. Since we were asked by Unity to remove any trademark violations, we chose to temporarily break the link. The new URL should should be up in a few days.

Got it! Thanks for the clarification!
Close this issue now! ;)


chore(main): release 0.40.6

:robot: I have created a release beep boop
0.40.6 (2024-10-28)
Bug Fixes

bump phpunit/phpunit from 11.4.2 to 11.4.3 (#919) (ef7924e)
bump the symfony group with 55 updates (#918) (21cad65)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

0.40.6
:sunflower:


Version string seems to be borked on v4

Just installed it on a phat, the version string displays as "3.60)(変革-4".

Expected behavior. You can blame YouTube's shitty user agent processing.


Expose applied decorators in generated docs

This is a feature request for TypeDoc to expose the decorator(s) applied to a type (such as class) in the generated doc.
For example, I assume I have defined a decorator named "serialize" that applies to classes.  When I write the following in my TypeScript source...
@serialize
class MyClass { }

...it would be awesome if the generated doc indicated that MyClass has been decorated with @serialize.  Currently, the generated doc does not expose this fact, but this sort of information can be vital to understanding a complex system of types that makes sophisticated use of decorators.
Of course, one would also be able to navigate to the decorator's own documentation from any such reference.
Going further, decorators often take arguments.  Ideally, the specific arguments values passed to the decorator should also be exposed in the generated docs.
For example, let's assume we have additional decorators that identify the "handler" class and another that lists "excluded" members (in an array).
@serialize
@handler(MyHandler)
@excluded([ "foo", "bar" ])
class MyClass { }

Again, it would be awesome if generated doc not only indicated that MyClass has been decorated with @handler and @excluded, but also listed the argument values passed to each decorator, with appropriate doc links as necessary.
For example, one would be able to navigate to the documentation for MyHandler, the value of the argument to @handler.
Lastly, my vote for the presentation of "applied decorators" in the generated doc would be to use a natural-looking syntax (as in the above examples), simply embellished with the necessary hyperlinks.

Duplicate of #97?

Useful to expose validations if using something like https://github.com/typestack/class-validator or other custom features.

@aciccarello I think these are separate things. I see #97 as basic support for calling out functions marked with @decorator as decorators (as opposed to being lumped in with other plain old functions). If I'm understanding @mattflix's request correctly, they're asking that the documentation for classes (and, I'm assuming, the other decorator targets - params, properties, and methods) gets rendered with any decorators applied in the source code. This is similar to how Microsoft includes attributes in their documentation (see https://docs.microsoft.com/en-us/dotnet/api/system.io.binaryreader?view=netframework-4.7.2 for an example - note the System.Runtime.InteropServices.ComVisible attribute).

Yes, @DanielSchaffer summarizes my feature request exactly.

That's a fair distinction. Thanks for clarifying.

@aciccarello Correct me if I'm wrong, but the data to support this should already exist. This really just needs some template work to render what's in the the decorators property in https://github.com/TypeStrong/typedoc-default-themes, right?

[ ] Add icon set for decorators
[ ] Add decorators signature partial, to be used as part of all types of signatures. Includes links to decorator documentation, as well as linked parameter values, if applicable
[ ] Add Decorators documentation partial
[ ] Add class declaration partial, similar to member declaration partial - e.g. class Foo extends Bar implements Something {}
[ ] Add decorators to class declaration display (including linking to decorators and parameters)
[ ] Add Decorators section to reflection template
[ ] Add method/param/property decorators to member signature display

Until the TypeScript team has updated to the new decorators proposal, and moved support out of an experimental flag, I don't want to spend time on this.
TypeDoc does expose some decorator info in the model, so a custom theme could theoretically do this today


Allow Token Exchange with Session Token

We should allow Session Tokens to be exchanged for OAuth / OIDC tokens on the Token Exchange. This would give developers the opportunity to get an access_token from a session token, without the need of going though the complete OAuth Code Flow.
Open Questions

How to handle scope, audience, ..., resp. do we need any restrictions?
...

@livio-a will check whether the use of an oauth / oidc client to exchange the session token is ok. Checks to done on exchange is according to the current ones on client credentials

Hi @livio-a, Any update regarding issue?

No updates yes, as soon as we have you will see it on the issue.
It is currently not our highest priority so I can't give you a concrete ETA.


Cannot update profile if your SSO name is 1 character long

Describe the Bug
Updating your Bookstack profile picture is not possible as long as your name is less than 2 characters.
Steps to Reproduce

Log into Bookstack with SSO while your SSO name is 1 character long
Try to update your profile picture

Expected Behaviour
Updating my profile picture should work, but it doesn't.
Screenshots or Additional Context
I get an error message "The name must be at least 2 characters." when trying to update my profile picture.
Browser Details
Firefox 132 on Arch Linux
Exact BookStack Version
24.10

Thanks for reporting @trwnh, don't see any reason to have a minimum of 2 rather than 1, so have changed this in 6f1c54d018f7d55301eb4c31055b04769f5924d7 to be part of the next patch release.


bevy_reflect: Add ReflectRef/ReflectMut/ReflectOwned convenience casting methods

Objective
#13320 added convenience methods for casting a TypeInfo into its respective variant:
let info: &TypeInfo = <Vec<i32> as Typed>::type_info();

// We know `info` contains a `ListInfo`, so we can simply cast it:
let list_info: &ListInfo = info.as_list().unwrap();

This is especially helpful when you have already verified a type is a certain kind via ReflectRef, ReflectMut, ReflectOwned, or ReflectKind.
As mentioned in that PR, though, it would be useful to add similar convenience methods to those types as well.
Solution
Added convenience casting methods to ReflectRef, ReflectMut, and ReflectOwned.
With these methods, I was able to reduce our nesting in certain places throughout the crate.
Additionally, I took this opportunity to move these types (and ReflectKind) to their own module to help clean up the reflect module.
Testing
You can test locally by running:
cargo test --package bevy_reflect --all-features

Showcase
Convenience methods for casting ReflectRef, ReflectMut, and ReflectOwned into their respective variants has been added! This allows you to write cleaner code if you already know the kind of your reflected data:
// BEFORE
let ReflectRef::List(list) = list.reflect_ref() else {
    panic!("expected list");
};

// AFTER
let list = list.reflect_ref().as_list().unwrap();

@MrGVSV if this is merge-conflict-free tomorrow for the merge train I'll get this in :)


[Candidate 2v2 FallOut ZH v1] Supply and oil positions require tweaking

Describe the bug
Supply and oil positions require tweaking. Please refer to Jundiyy for more information.
Expected behavior
Supply and oil positions are properly placed.

I will do this, hopefully tonight after work.

FallOut ZH v1.zip
Done the tweaking and also removed the texture in #96.
Found 4 cars in the middle which I have set to non-useable (I hope).

Fixed with https://github.com/xezon/GeneralsRankedMaps/commit/706590269a242fc8c05cfdb34a4ae54cc8fcd9bb


Check, review and restrict the editable managed objects fields in IDM: userEditable fields

Description
The user could edit the consent and change manually the values stored in the consent in IDM.
Restrict the editable fields to protect the consent values stored in IDM we need to review the fields defined in the managed objects to identify the fields which may not be edited by the user in the self user UI.

Consents now managed by the RCS


Dashboard memory leak

Run siege -b http://dashboard.mycluster.com for a while and watch flynn-dashboard eat up you memory.
Memory and CPU usage stays high when stopping the siege.

[257321.107153] Killed process 4018 (flynn-dashboard) total-vm:305620kB, anon-rss:292808kB, file-rss:0kB```

From syslog:
Sep 17 06:40:30 flynn-node kernel: [767587.485629] Out of memory: Kill process 29895 (flynn-dashboard) score 252 or sacrifice child
Sep 17 06:40:30 flynn-node kernel: [767587.486534] Killed process 29895 (flynn-dashboard) total-vm:277320kB, anon-rss:264580kB, file-rss:0kB

This appears to happen even when I'm not actively using the dashboard... furthermore flynn does not restart the dashboard server once it is killed by the OS.

I've confirmed there is a memory leak, CPU usage does subside. Interestingly, memory usage rises fastest when running siege -b http://dashboard.mycluster.com/ping which leads me to believe the in-memory assets are not to blame. I think a good starting point is to switch away from martini (#992).

The /ping endpoint is no longer effected, still tracking down the source of the leak.

Memory usage appears to stabilize over time. If you'd like to inspect what's going on, set GODEBUG=gctrace=1 for the dashboard app.

Will this change be in if I rebuild my cluster tomorrow? I'd like to get rid of the ugly cronjob that scales down and up the dashboard app once every day xD

Yeah, as long as the nightly build succeeds.

This is still an issue.
ubuntu@flynn-node:~$ flynn-host version
v20151104.1

@kwando does it's usage continue to grow, or remain relatively steady?

@jvatic well, after restarting the dashboard app (scale web=0, scale=1)  and clicking around in the UI htop shows memory usage of 0.3 %.  I left it unattended for 4 days and then memory consumption was near 25 % on the same server (2GB RAM).

I've narrowed this down to a memory leak in the session store we use (opened upstream issue: https://github.com/gorilla/sessions/issues/59).

@jvatic good work!


ansible-playbook --check fails due to skipped register step

unbound -h command is not destructive, so it is ok to run it always
fixes #21

the PR is blocked by https://github.com/reallyenglish/ansible-role-example/issues/33


Implementing Token Based Authentication and authorization

Related Issues

Tests can be created anonymously
Creation of tests should only be limited to the teacher (Google Classrooms assumes this is the creator of the test). But the current system allows not only a random user logged in to create tests but also anonymous users on the internet. This is a basic security requirement, and that would prevent anyone from using this app in a serious environment.

Closes: #83 #119
Describe the changes you've made
Using the User schema, when a user is logged in or signed up to the website --> we create a jwt with cookies in the browser that stores the necessary information.
I wrote auth middleware functions that check whether the user is a teacher or a general user of the website through decoding the previously-stored jwt.
Checklist:
<!--
Example how to mark a checkbox:-
- [x] My code follows the code style of this project.
- [x] My code follows the style guidelines of this project.
- [x] I have performed a self-review of my own code.
- [x] I have commented on my code, particularly in hard-to-understand areas.
- [x] I have made corresponding changes to the documentation.
- [x] My changes generate no new warnings.

@osamamagdy can you integrate this authentication with google login, as we use google login for signin and signout.

@aavishkarmishra of course i can but i can't find the file where the function of signing up is added. Can you guide me to its path in the repo?

@aavishkarmishra Done now

@aavishkarmishra Is this still pending review?

Hello @Deeksha2501 , I need your review for this


Document the intention to delete KongIngress support for Gateway API

Is there an existing issue for this?

[X] I have searched the existing issues

Problem Statement
We don't want to support KongIngress together with Gateway API routes, but certain KongIngress features aren't available in GW API today.
Proposed Solution
Clearly document the intended dynamic: explicitly and effectively disable support for KongIngress features in conjunction with GW API routes (and suggest ways to do KongIngress things with pure Gateway API) to give the user base possibility to migrate easily
Additional information
No response
Acceptance Criteria

[ ] KIC docs say that KongIngress support in GW API is deprecated & expected to be disabled in KIC 3.0.

This is iffy without https://github.com/Kong/kubernetes-ingress-controller/issues/2941 since some of those features have no migration path yet (GWAPI has indicated they don't intend to support standard APIs for things like connection timeouts, and those don't have annotations yet--ironically because we originally thought GWAPI was going to add them).
This would further imply that we do remove KongIngress entirely and replace it with KongUpstream for upstream configuration outside the basic weighting offered by GWAPI standards. Some of those settings (hash_on, for example) are single KV pairs and could fit in annotations, but others (anything involving healthchecks) definitely do not.

Preferred location for this warning (@rainest's idea):

KongIngress reference
KongIngress guide
Changelog (the list of supported features for KongIngress)

https://github.com/Kong/docs.konghq.com/pull/4894 adds the guide note only. https://github.com/Kong/docs.konghq.com/pull/4813 is responsible for the Reference blurb, and now includes one.
Ended up not putting anything in the GWAPI support page since there's no functional effect. The only thing that still requires a KongIngress is some upstream configuration, and that only applies to Services, not any routing resource.

https://github.com/Kong/docs.konghq.com/pull/4813 is now in.
https://github.com/Kong/docs.konghq.com/pull/4894 is still pending but we're probably fine to release without it. There's no immediate need to have this right at release.

@rainest Is this resolved already?

With 4894 merged this is done, yes.


Update new Arbimon database checklist

Backend

[ ] https://github.com/rfcx/arbimon-db-migration

Frontend

[x] Maintenance page
[x] Uploader error message

Testing

Arbimon

[ ] Check all pages (eg. overview, project settings, members)

Legacy

[ ] Create a new project
[ ] Check created project
[ ] Check all legacy pages

PM

[ ] Upload recordings
[ ] Create a new template
[ ] Create a new playlist
[ ] Create PM job
[ ] Check job on Active job page
[ ] Check result

AED

[ ] Create a new AED job
[ ] Check job on Active job page
[ ] Check result

Clustering

[ ] Create a new clustering job
[ ] Check job on Active job page
[ ] Check result
[ ] Check detail on grid view

During migration


DSD-578: AlphabetFilter Component

Fixes JIRA ticket DSD-578
This PR does the following:

Adds AlphabetFilter component

How has this been tested?
Unit tests and in StoryBook
Accessibility concerns or updates

Checklist:

[ ] I have updated the Storybook documentation accordingly.
[ ] I have added relevant accessibility documentation for this pull request.
[ ] All new and existing tests passed.

Front End Review:

[ ] Review the Vercel preview deployment once it is ready.

@jackiequach Is this PR ready to be reviewed again?


GenAI eatting image from DOCX

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

#1451

Chage from docx2txt.process to extract them manually
Eatting image as Base64 | Table as HTML tag | Text for paragraph

Why was this change needed? (You can also link to an open issue here)

To using multiple vector store to retrieve correct image as paragraph order instead of zip them by docx2text.process()

Other information:
Progress the issue is now when we retrieve need to find the way to convert base64 back for AI to understand image

@dartpain  let me know if this correct approach or wrong direction

@dartpain this is the progress as we discussed on discord, let me know if this right direction.

for the text embedding seems work properly except the default document that using 768 dimension but clip using 512 dimension.
Image maybe I have to resize to make base64 smaller before embed to CLIP model
Issue here it stuck when I upload docx to server it seems stuck with document that contains images.


Add Code of Conduct

Addresses https://github.com/wiremock/community/issues/4
To merge it, we need to agree on a way of submitting the escalations. I could just add my personal or wiremock.org email for now, or we could create<EMAIL_ADDRESS>if @tomakehurst agrees

Let's create a<EMAIL_ADDRESS>group

Ready for review and merge


AvaloniaProperty.Register validate function missing TOwner parameter.

According the current and previous Avalonia documentation the AvaloniaProperty.Register validate function has the TOwner passed as a parameter but this is missing in the current implementation.
validate: A validation/coercion function of type Func<TOwner, TValue, TValue>. The function accepts the instance of the class on which the property is being set and the value and returns the coerced value or throws an exception for an invalid value.

The TOwner parameter is useful where you want to validate a property change against other properties of the TOwner class.  For example performing range constraint for a Value property, using MaxValue and MinValue properties that can be set for each instance of the TOwner control.
I see this is listed as a breaking change for v0.10 but unless there is a good reason to remove the TOwner parameter I would ask for it to be reinstated for the above reasons.
Avalonia 0.9.999 cibuild

We recently changed AvaloniaProperty validation to follow WPF semantics as people were complaining that it was hard to port controls: https://github.com/AvaloniaUI/Avalonia/pull/3287
As with WPF, if you want to receive an instance of the control you must define a coercion function, which cannot throw but can coerce the value to a valid value.
See the WPF docs for more info: https://docs.microsoft.com/en-us/dotnet/framework/wpf/advanced/dependency-property-callbacks-and-validation
The docs need updating but as they reflect the state of the current stable release, so they won't be updated until 0.10 is stable (we do need a way to host documentation for multiple versions, but this is a big TODO at the moment).


bootBuildImage still uses GraalVM 21.0

I updated my 0.9.2 project to the new 0.10.0 release (congrats!) but noticed my ./gradlew boottBuildImage command doesn't use GraalVM 21.1:
[creator]       Native Image: Contributing to layer
[creator]         GraalVM Version <IP_ADDRESS> (Java Version 11.0.10+8-jvmci-21.0-b06)

From the "Upgrade to 21.1" commit https://github.com/spring-projects-experimental/spring-native/issues/578 I noticed this configuration from samples:
// TODO Bring back "paketobuildpacks/builder:tiny" before 0.10.0 release
builder = "dmikusa/graalvm-tiny"

I can use dmikusa/graalvm-tiny builder as a workaround, but wanted to give a heads up in case this TODO was missed

Sorry, we had an unexpected issue during the release that delayed of a few hours the Buildpacks update, but it should now uses GraalVM 21.1 as expected.


Improvement: Ability to use Document Template Key when invoking query/command

Before: we can only use the document template UUID in order to view/update/delete/render.
After: we can use key too, so it is matching with the initial documentation https://docking.shipsaas.tech/usage/maintain-ids-keys-from-services

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.01% :tada:

Comparison is base (a13c3a2) 97.55% compared to head (f12239c) 97.57%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #23      +/-   ##
============================================
+ Coverage     97.55%   97.57%   +0.01%
- Complexity      130      131       +1
============================================
  Files            44       44
  Lines           614      618       +4
============================================
+ Hits            599      603       +4
  Misses           15       15

Files Changed
Coverage Δ

app/Models/DocumentTemplate.php
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Feedback: long content right-side navigation not scrollable

Looking at this section you can see that there are more sub-sections available but you can't scroll them, making the "Content" side navigation not fully usable.
You need to scroll all the way down to be able to see the bottom of it.
Top or middle of the page: can't see below @@updatedAt

Bottom: can see the rest

@nilubava  This should probably behave the same way the left sidebar does - in any event, we should try for it not to have a persistent scrollbar

@nilubava @hrescak Is this in progress still? It does not behave like the left-hand scrollbar at the moment.
I also wonder if we could have the right-hand nav 'follow' you as you scroll, so that if you're looking at a heading named 'generators', that is also what's highlighted in the right-hand nav? rather just scrolling with the length of the page (for API reference in particular you'll hit the end of the nav long before you hit the end of the page)

Let's make it move as the left one and @mhwelander will create an issue for the super awesome behavior

Closing this as it's implemented in the branch.


vscode-lean4

[ ] Extension name: vscode-lean4
[ ] Extension GitHub or homepage: https://github.com/leanprover-community/vscode-lean4

Hi! We're currently working on adding support for using Open-VSX in addition to our gallery in code-server - I'd recommend reaching out to the author of the extension and requesting them to publish to Open-VSX!

Hi! We're currently working on adding support for using Open-VSX in addition to our gallery in code-server - I'd recommend reaching out to the author of the extension and requesting them to publish to Open-VSX!

Thank you, I've relayed your message to everyone on the Lean Zulip chat. I hope someone knowledgeable could chime in because I couldn't really understand what you're saying.

Thank you, I've relayed your message to everyone on the Lean Zulip chat. I hope someone knowledgeable could chime in because I couldn't really understand what you're saying.

The extension has now been published on Open-VSX.

The extension has now been published on Open-VSX.


[bn] Localize portability.md & idempotence.md

Signed-off-by: Abdullah Arean<EMAIL_ADDRESS>Localizes “content/bn/portability.md"  "content/bn/idempotence.md" to Bengali
This is an initial PR as may need some improvements!
Tracking issue: #410

@AbdullahArean  kindly don't localize 2 files in one branch .

It was by accident, whatever, I will try my best to follow best practices. Thanks @mitul3737


[WIP] TypeScript Definitions

Still a work in progress as a few definitions are missing (BreadProvider, withTheme, and probably a few others). Feedback welcome!
Closes #322.

@skubakdj This looks great so far!
@punisher97 I'd love your feedback on this PR if you have some time

@skubakdj Thank you!, @codypearce Ok, I'll try it today and I'll tell you

@codypearce is a very good declaration file, to improve in the future, divide into several files and add defaultProps and comments (using the website), example AppBar
export interface AppbarProps {
  color?: Color
  style?: StyleProp<any>
  theme?: Theme
  barType?: 'normal' | 'simple' | 'prominent' | 'dense' | 'prominent dense'
  backgroundImage?: React.ReactNode
  position?: string
  elevation?: number

  navigation?: string | React.ReactNode
  onNavigation?: (...args: any[]) => void

  title?: string
  titleStyles?: StyleProp<any>
  onTitle?: (...args: any[]) => void
  subtitle?: string
  subtitleStyles?: StyleProp<TextStyle>
  textContainerStyles?: StyleProp<TextStyle>

  actionItems?: React.ReactNode

  children?: React.ReactNode
}

export class Appbar extends React.Component<AppbarProps> {
  render(): React.ReactElement
}

to
Components/AppBar.d.ts
export enum BarTypeEnum {
    REGULAR = 'regular',
    PROMINENT = 'prominent',
    DENSE = 'dense',
    PROMINENT_DENSE = 'prominent dense',
  }

  export interface IActionItem {
    name: string;
    onPress: (e: any) => void;
  }

  export interface AppBarProps {
    /**Each can be an object or node, renders on the right */
    actionsItems?: React.ReactNode | Array<IActionItem>;
    /**Type of appbar, other components change based on type:
     * @type {string}: regular, prominent, dense, prominent dense
     */
    barType?: BarTypeEnum;
    /**Renders image element as background*/
    backgroundImage?: Image;
    /** Component's background color */
    color?: string;
    /** Shadow on container appbar*/
    elevation?: number;
    /** OnPress for navigation IconButton if provided. */
    onNavigation?: (...args: any[]) => void;
    /** OnPress for title string if provided. */
    onTitle?:(...args: any[]) => void;
    /** Renders IconButton if string, or renders custom node on left of title */
    navigation?: React.ReactNode
    /** CSS position values applied to root appbar */
    position?: 'fixed' | 'relative' | 'absolute';
    /** Only displays on barType prominent, under the Title */
    subtitle?: string;
    /** Styles Subtitle */
    subtitleStyles?: StyleProp<ViewStyle>;
    /** Displays on the left after navigation. If string it follows guidelines */
    title?: string | React.ReactNode;
    /** Styles title if provided as string */
    titleStyles?: StyleProp<ViewStyle>;
    /** Styles root element */
    style?: StyleProp<ViewStyle>;
  }
  export class AppBar extends React.Component<AppBarProps, any> {
    public static defaultProps = {
      barType: BarTypeEnum.REGULAR,
      color: 'primary',
      elevation: 8,
      position: 'relative',
    };
    render(): React.ReactElement
  }
}

For me it's fine, I work with this, thanks!

Awesome suggestions @punisher97! Thanks for taking a look.
I should have some time this weekend to finish up the remaining definitions and give everything a final look over.

Just added the remaining types. I'm not sure withTheme is completely correct, but it seemed to work with some cursory testing.
It also seems like Travis is throwing prettier errors on files that haven't been modified. Not sure what's going on there but @codypearce if there's anything I need to change please let me know!

@skubakdj Looks great! Thanks for your contribution! I moved the index.d.ts to src so it will be served along with the project entry point index.js

@skubakdj Looks great! Thanks for your contribution! I moved the index.d.ts to src so it will be served along with the project entry point index.js

@codypearce  Sorry remember add types key in package.json to working properly;


Failed to parse result from HVM.

Reproducing the behavior
I don't have an NVIDIA gpu yet, so I'm currently working with run and run-c.
I'm trying to learn by doing different examples, but I'm running into an issue where sometimes when I try to run a program, it gives me a "Failed to parse result from HVM." error. This always happens when I try to use run-c and sometimes when I try the regular run, such as the sorting tree rotation example you gave in https://gist.github.com/VictorTaelin/face210ca4bc30d96b2d5980278d3921 (which I copied word-for-word to avoid errors while I figure it out).
I'm not entirely sure what is going wrong. I successfully installed HVM and most of my programs are working with a regular run command.
System Settings
OS: WSL Ubuntu 22.04.3 LTS
CPU: AMD Ryzen 7 Microsoft Surface (R) Edition, 2000 Mhz, 8 Core(s), 16 Logical Processor(s)
Additional context
No response

Was this today? I wonder if the temporary stack size increase I pushed yesterday (https://github.com/HigherOrderCO/HVM/commit/b338dbd317db7756945a0aa3823fc2cb2eec91fd) broke it in some computers.
@TheSimicSlaw can you please edit the generated hvm.c to use a smaller stack size? Like this:
hvm gen-c main.hvm > main.c

# edit 'main.c' to replace 'Port stack[4096];' by 'Port stack[256];'

gcc main.c -o main
./main

@edusporto can you please fully investigate this issue yourself? If the stack size is too large, decrease it to the largest reasonable amount. We should get rid of it when we're able to readback from C/CUDA properly. How's that work going?

The issue seems a bit deeper than that. Both when setting that stack to size 4096 and 256, running the program will sometimes return a valid result and sometimes an invalid one.
➜  /tmp ./test
Result: 16252928
- ITRS:<PHONE_NUMBER>
- TIME: 22.13s
- MIPS: 275.93
➜  /tmp ./test
Result: x1fffffff
- ITRS:<PHONE_NUMBER>
- TIME: 26.26s
- MIPS: 222.78

This seems like it will be tricky to diagnose, I'll look into it after finishing #362

Oh I thought my commit broke it. Well, this was working fine in the past. It just stopped working?
In this case, @enricozb, can you find which commit broke it? Maximum priority here.

@edusporto or @enricozb any updates?

@TheSimicSlaw Can you try again on the latest version, we've fixed a handful of bugs which might have included this issue. If not, please send an offending .hvm file so we can reproduce.

@enricozb It has not, unfortunately, been fixed. GitHub says it doesn't support the file type to link the .hvm file. How would you like me to send it to you?

I also have this issue.
OS: ubuntu on WSL2 on win11
GPU: nividia geforece 940MX
hvm 2.0.22
bend-lang 0.2.36
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2023 NVIDIA Corporation
Built on Fri_Jan__6_16:45:21_PST_2023
Cuda compilation tools, release 12.0, V12.0.140
Build cuda_12.0.r12.0/compiler.32267302_0
gcc (Ubuntu 12.3.0-17ubuntu1) 12.3.0
g++ (Ubuntu 12.3.0-17ubuntu1) 12.3.0

Also, how can I install from git, I only knows how to install through rust crate

@enricozb It has not, unfortunately, been fixed. GitHub says it doesn't support the file type to link the .hvm file. How would you like me to send it to you?
p.s. Sorry for the delayed response! A lot of stuff's gone down and I'm only now getting back to this.

You can make it into a gist (https://gist.github.com/) and then post the link here

Also, how can I install from git, I only knows how to install through rust crate

cargo install --path .


Unable to receive mails

Hello I have configured and installed docker-mailserver the last days. I am now able to send valid e-mails to gmail and other mail services.
My problem now is that I cannot receive any.
Neither local mails from<EMAIL_ADDRESS>to<EMAIL_ADDRESS>nor from my gmail account to<EMAIL_ADDRESS>I have disabled spamassassin, fail2ban, postgrey and clamav to ensure that no security mechanism is catching my mails.
I have not registered any aliases, because I don't need them at the moment.
here is my docker-compose.yml:
version: '2'

services:
  mail:
    image: tvial/docker-mailserver:latest
    hostname: subdomain
    domainname: domain.com
    container_name: mailserver
    ports:
      - "25:25"
      - "143:143"
      - "587:587"
      - "993:993"
      - "465:465"
    volumes:
      - ./data:/var/mail
      - ./state:/var/mail-state
      - /var/log/mail:/var/log/mail
      - ./config/:/tmp/docker-mailserver/
      - /etc/letsencrypt:/etc/letsencrypt
    environment:
      - ENABLE_SPAMASSASSIN=0
      - ENABLE_CLAMAV=0
      - ENABLE_FAIL2BAN=0
      - ENABLE_POSTGREY=0
      - ONE_DIR=1
      - DMS_DEBUG=1
      - PERMIT_DOCKER=connected-networks
      - SPOOF_PROTECTION=1
      - SSL_TYPE=letsencrypt
    cap_add:
      - NET_ADMIN
      - SYS_PTRACE
volumes:
  maildata:
    driver: local
  mailstate:
    driver: local
  maillogs:
    driver: local

What could be the problem here ?
Thx for the help :-)

Please check your logs (docker logs mail or in /var/log/mail in the container) and post relevant parts.
I would also advise you to re-enable the security checks and run as close to the default settings as possible, possibly except fail2ban (I personally don't want my containers to mess with the host firewall). If you do keep fail2ban disabled then remove NET_ADMIN as it is a security risk and is only needed by fail2ban. It should be possible to make things work with the standard security measures in place.
Finally connected-networks is very liberal, so make sure to test your server so that it is not an open relay. If it is you will soon find yourself blocked. I haven't tested the service so I can't vouch for it, but https://mxtoolbox.com/diagnostic.aspx seems to do the job.

Yes i will reenable these security checks, but I want to make it work first :-)
Here is the mail.log from sending a email from<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Sep 30 09:30:51 mail postfix/smtps/smtpd[20188]: connect from .....
Sep 30 09:30:51 mail postfix/smtps/smtpd[20188]: Anonymous TLS connection established from .....: TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)
Sep 30 09:30:51 mail postfix/trivial-rewrite[20192]: warning: do not list domain subdomain.domain.com in BOTH mydestination and virtual_mailbox_domains
Sep 30 09:30:51 mail postfix/trivial-rewrite[20192]: warning: do not list domain subdomain.domain.com in BOTH mydestination and virtual_mailbox_domains
Sep 30 09:30:51 mail postfix/trivial-rewrite[20192]: warning: do not list domain subdomain.domain.com in BOTH mydestination and virtual_mailbox_domains
Sep 30 09:30:51 mail postfix/smtps/smtpd[20188]: E41251E071C: client=....., sasl_method=PLAIN<EMAIL_ADDRESS>Sep 30 09:30:52 mail postfix/sender-cleanup/cleanup[20193]: E41251E071C<EMAIL_ADDRESS>Sep 30 09:30:52 mail postfix/sender-cleanup/cleanup[20193]: E41251E071C: replace: header MIME-Version: 1.0 from<EMAIL_ADDRESS><EMAIL_ADDRESS>proto=ESMTP helo=<[<IP_ADDRESS>]>: Mime-Version: 1.0
Sep 30 09:30:52 mail opendkim[195]: E41251E071C: DKIM-Signature field added (s=mail, d=subdomain.domain.com)
Sep 30 09:30:52 mail postfix/qmgr[960]: E41251E071C<EMAIL_ADDRESS>size=361, nrcpt=1 (queue active)
Sep 30 09:30:52 mail postfix/smtps/smtpd[20188]: disconnect from ..... ehlo=1 auth=1 mail=1 rcpt=1 data=1 quit=1 commands=6
Sep 30 09:30:52 mail postfix/smtpd[20196]: connect from localhost[<IP_ADDRESS>]
Sep 30 09:30:52 mail postfix/trivial-rewrite[20192]: warning: do not list domain subdomain.domain.com in BOTH mydestination and virtual_mailbox_domains
Sep 30 09:30:52 mail postfix/trivial-rewrite[20192]: warning: do not list domain subdomain.domain.com in BOTH mydestination and virtual_mailbox_domains
Sep 30 09:30:52 mail postfix/smtpd[20196]: 349401E071E: client=localhost[<IP_ADDRESS>]
Sep 30 09:30:52 mail postfix/cleanup[20197]: 349401E071E<EMAIL_ADDRESS>Sep 30 09:30:52 mail postfix/qmgr[960]: 349401E071E<EMAIL_ADDRESS>size=1081, nrcpt=1 (queue active)
Sep 30 09:30:52 mail postfix/smtpd[20196]: disconnect from localhost[<IP_ADDRESS>] ehlo=1 mail=1 rcpt=1 data=1 quit=1 commands=5
Sep 30 09:30:52 mail postfix/trivial-rewrite[20192]: warning: do not list domain subdomain.domain.com in BOTH mydestination and virtual_mailbox_domains
Sep 30 09:30:52 mail amavis[315]: (00315-13) Passed CLEAN {RelayedInbound}, [XXX.XXX.XXX.XXX]:7040 [XXX.XXX.XXX.XXX]<EMAIL_ADDRESS>-><EMAIL_ADDRESS>Queue-ID: E41251E071C, Message-ID<EMAIL_ADDRESS>mail_id: F9vhhI5mM80u, Hits: -, size: 866, queued_as: 349401E071E, 131 ms
Sep 30 09:30:52 mail postfix/smtp[20194]: E41251E071C<EMAIL_ADDRESS>relay=<IP_ADDRESS>[<IP_ADDRESS>]:10024, delay=0.32, delays=0.17/0.01/0.01/0.13, dsn=2.0.0, status=sent (250 2.0.0 from MTA(smtp:[<IP_ADDRESS>]:10025): 250 2.0.0 Ok: queued as 349401E071E)
Sep 30 09:30:52 mail postfix/qmgr[960]: E41251E071C: removed
Sep 30 09:30:52 mail postfix/local[20198]: 349401E071E<EMAIL_ADDRESS>relay=local, delay=0.03, delays=0.01/0.01/0/0.01, dsn=5.1.1, status=bounced (unknown user: "info")
Sep 30 09:30:52 mail postfix/cleanup[20197]: 3A6FA1E071F<EMAIL_ADDRESS>Sep 30 09:30:52 mail postfix/bounce[20199]: 349401E071E: sender non-delivery notification: 3A6FA1E071F
Sep 30 09:30:52 mail postfix/qmgr[960]: 3A6FA1E071F: from=<>, size=2952, nrcpt=1 (queue active)
Sep 30 09:30:52 mail postfix/trivial-rewrite[20192]: warning: do not list domain subdomain.domain.com in BOTH mydestination and virtual_mailbox_domains
Sep 30 09:30:52 mail postfix/qmgr[960]: 349401E071E: removed
Sep 30 09:30:52 mail postfix/local[20198]: warning: required alias not found: postmaster
Sep 30 09:30:52 mail postfix/local[20198]: 3A6FA1E071F<EMAIL_ADDRESS>relay=local, delay=0, delays=0/0/0/0, dsn=2.0.0, status=sent (discarded)
Sep 30 09:30:52 mail postfix/qmgr[960]: 3A6FA1E071F: removed
Sep 30 09:30:52 mail dovecot: imap(postmaster@subdomain.domain.com)<26255><fsbPFMCTlRdbEKP3>: Connection closed (IDLE running for 0.001 + waiting input for 0.001 secs, 2 B in + 10+10 B out, state=wait-input) in=690 out=1651 deleted=0 expunged=0 trashed=0 hdr_count=0 hdr_bytes=0 body_count=0 body_bytes=0
Sep 30 09:30:58 mail dovecot: imap-login: Login<EMAIL_ADDRESS>method=PLAIN, rip=XXX.XXX.XXX.XXX, lip=YYY.YYY.YYY.YYY, mpid=20221, TLS, session=<I+Ku5MGTgRtbEKP3>

This error message is reasonably clear:
Sep 30 09:30:52 mail postfix/local[20198]: 349401E071E<EMAIL_ADDRESS>relay=local, delay=0.03, delays=0.01/0.01/0/0.01, dsn=5.1.1, status=bounced (unknown user: "info")
And:
Sep 30 09:30:52 mail postfix/local[20198]: warning: required alias not found: postmaster
Have you created a user or alias for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Plus you get:
Sep 30 09:30:51 mail postfix/trivial-rewrite[20192]: warning: do not list domain subdomain.domain.com in BOTH mydestination and virtual_mailbox_domains
If you think you have created the info and postmaster accounts that could be the problem.

Have you created a user or alias for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>
-> A user -> my postfix-accounts.cf is filled with these two accounts and postfix-aliases.cf is empty

Sep 30 09:30:51 mail postfix/trivial-rewrite[20192]: warning: do not list domain subdomain.domain.com in BOTH mydestination and virtual_mailbox_domains
If you think you have created the info and postmaster accounts that could be the problem.

what do you mean here ?

?

I meant that if you had defined the users, then that warning would be next in line.
My theory is that the problem is caused by confusing subdomain and host. The way you have configured your yaml file the server should have a domain named domain.com and the server itself should have the host name subdomain. If that is what you want then you should define the two accounts as<EMAIL_ADDRESS>and<EMAIL_ADDRESS>If on the other hand you are really managing mail for subdomain.domain.com then you should probably define the domain to be subdomain.domain.com, the host to be something else (mail?) and then the users are fine as they are. The environment variables in the .env file must be updated as well as the yaml file.

I don't have a .env file. Is therefore any needed ?
To make it more understandable what I want:
the email address of postmaster should be<EMAIL_ADDRESS>So I thought that hostname is mail and domainname the mydomain.com.
Is that right ? But why can I send emails as them to google without any problems ?

Excuse me for standing on the hose

well... sometimes i don't see the wood for the trees...
So my main problem was solved. My hostname was with mail okay, but the domainname should include the subdomain ... (if I'd looked a little bit more detailed the manual, I could see that the described mail in the hostname was not used for the mail.example.com...)
So last problem before I start the security mechanisms again:
thunderbird throws an security exception, in which I have to download the certificate. I don't think that it should be done.

Okay weird situation now..
I'd figured out that if I define hostname as empty, then I can receive mails, but got the security exception, because the hostname of the container does not match the one in the letsencrypt cert. And if I define an override_hostname, then I cannot receive, but I can send mails.
I'd also figured out what you mean with .env files. I don't use them. I am using only the docker-compose.yaml and writing the environment args down there.
Is there someone who could help me out of that little trap ?

I'd ran now through the start_mailserver.sh. It uses only the hostname for the SSL. So it does not matter what is defined inside the domainname.
So now the question: Why can't I receive emails, when domainname and hostname are defined as mail.domain.tld. And emails registered are also<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

Somewhat simplified there are two types of mail accounts. One is for real users, i.e. users that can login and that have a home directory. The other is for virtual users that can read and send mail, but that should not have accounts on the host. If the host is mail.domain.tld and you define a user as<EMAIL_ADDRESS>then that is a local user on that host and the user is assumed to exist and permissions must be in place to allow the mail server to deliver mail to the user's home directory. If on the other hand you define the user as<EMAIL_ADDRESS>then it is a virtual user.
That is one part of the story. The other is that the start_mailserver.sh script makes some assumptions and uses the docker-mailserver specific accounts file for populating several Postfix configuration files. That breaks down and you get warnings when you don't follow the conventions.
I think you should either follow the conventions, stay close to the defaults and read up on the letsencrypt configuration, or make a deep-dive into Postfix and Dovecot to tweak the configuration the way you want it. Many are using letsencrypt so I very much doubt that your issue is unique. Check the wiki and see if you can adapt one of the working examples. Good luck!

Yes and I try to do like in the example, but I have trouble here, because of the errors above. The mails are having now a correct ssl cert, but the mails are bounced, because the email user is not found.
So is this docker-mailserver using local users? If yes, what rights should they have?
If no: why does my system say that it does not find any user although they are defined inside postfix-accounts.cf via setup.sh?

current status is that I've found the users "home" directory under /var/mail/mail.domain.tld/. The emails send to them were bounced, because the users were not found. I think the problem is not postfix itself, the problem should be inside dovecot. I am pretty frustrated now..

So the last problem was solved... problem was the mydestination definition from postfix.
Fixed with adding a postfix-main.cf inside config folder and added mydestination = localhost.$mydomain, localhost instead of mydestination = $myhostname, localhost.$mydomain, localhost

Now I can send emails to external and receive from external. As well as sending emails completely internal.


run_reports should set path to be directory found by regex.

run_reports looks for distinct subjects to create subject reports filenames, but doesn't use the information to limit the indexing of reportlets for just that subject. The path argument being passed to the Report object should be the path to the directory matched by the subject regex.

This is no longer the case.


Unable to reference ActivityRingView

I installed ActivityRings via CocoaPods. My project is a phone app with a watch extension. When I attempt to reference ActivityRingView in the phone app's main view controller, I get the following warning:

Hi there, thanks for opening an issue.
Could you try using the compilation-conditions branch and let me know if that works?

Fixed in #8


The conversation update is not send from Webchat

The conversation update is not sent from Webchat when I tried from "Test in Webchat" and my application (which is running using angular+javascript).  But I see that Conversation Update activity is sent from the emulator. How can I send it from Webchat?

Thank you for the question, @deenaMaistering. Is it possible that your bot just isn't responding to the conversation updates correctly? Try this code:
await turnContext.SendActivityAsync($"Conversation Update: {activity.From?.Id}");

if (activity.MembersAdded?.Any() == true)
{
    // Iterate over all new members added to the conversation.
    foreach (var member in activity.MembersAdded)
    {
        await turnContext.SendActivityAsync(member.Id);
    }
}

Test in Web Chat is sending the conversation updates just fine for me:

@deenaMaistering - Are you still working on this?

I am closing this issue due to inactivity. We are still happy to provide help if you need any, though it may be a good idea to make a new post if that's the case. Please have a look at this to find out the best places to ask for help, and consider asking questions on Stack Overflow.


Postpone machine cleanup when instance is still being created

What this PR does / why we need it:
This PR fixes a race condition in our providers Cleanup method - introduced in https://github.com/anexia-it/machine-controller/pull/10 - which occurs when a machine is deleted before the instance has been created.

merged upstream as https://github.com/kubermatic/machine-controller/pull/1571


Help wanted, position cursor/selected cell/ ready for input after setData

Is it possible to make a certain cell active after an jexcel('setData',data,false);
and have the cell ready for keyboard input?
I've tried to make the selectedCell point to the new cell, but after it I'm only able to use the arrow left and right but nut the enter, up or down.
Any help pointing me into the right direction is appreciated.
Explanation:
After an update on a cell I do:
data=....jexcel('getData');
do some operations on data without updating the table/screen
then: ....jexcel('setData',data)
This is working fine, but I cannot enter the next vertical field without using the mouse.

solved as follows, but I think not working in a multi jexcel form.
var sCell=...jexcel('getCellCursor');
var currentTD=$(sCell).prop('id');
...jexcel.selectedCell= $('#'+curTD);


sharding codec bytes configuration block

The zarr.json I get from running ome2024-ngff-challenge is missing a configuration section from the bytes codec within the sharding codec, and this prevents it from being viewed in vizarr, giving errors:
TypeError: Cannot read properties of undefined (reading 'endian')

I noticed that this IS found in the sample at https://deploy-preview-36--ome-ngff-validator.netlify.app/?source=https://uk1s3.embassy.ebi.ac.uk/idr/share/ome2024-ngff-challenge/0.0.5/6001240.zarr
It's also found in the spec at https://github.com/zarr-developers/zarr-specs/blob/main/docs/v3/codecs/sharding-indexed/v1.0.rst#configuration-parameters
Manually adding this in as follows allows the data to be viewed in vizarr:
{
  "chunk_grid": {
    "configuration": { "chunk_shape": [1, 1, 1, 1024, 1024] },
    "name": "regular"
  },
  "chunk_key_encoding": { "name": "default" },
  "codecs": [
    {
      "configuration": {
        "chunk_shape": [1, 1, 1, 256, 256],
        "codecs": [
          {
            "name": "bytes",
+           "configuration": {
+            "endian": "little"
+            }
          },
          {
            "configuration": {
              "blocksize": 0,
              "clevel": 5,
              "cname": "zstd",
              "shuffle": "bitshuffle",
              "typesize": 1
            },
            "name": "blosc"
          }
        ],
        "index_codecs": [
          { "configuration": { "endian": "little" }, "name": "bytes" },
          { "name": "crc32c" }
        ]
      },
      "name": "sharding_indexed"
    }
  ],
  "data_type": "uint8",
  "dimension_names": ["t", "c", "z", "y", "x"],
  "fill_value": 0,
  "node_type": "array",
  "shape": [1, 4, 1, 140, 167],
  "zarr_format": 3
}

"endian" is only required for multi-byte data types where endianness is applicable, so vizarr is non-conformant in this case.

Thanks @LDeakin.
Hi @manzt - does this look right to you? Potential issue with zarrita?
I tried to create a sample image to illustrate the issue: I'm not getting the expected error in vizarr but the image still fails to display and applying the change to zarr.json above seems to fix it (becomes viewable)
https://deploy-preview-36--ome-ngff-validator.netlify.app/?source=https://minio-dev.openmicroscopy.org/idr/v0.5/astronaut.zarr
Thanks

Yeah, this is a bug in zarrita. The issue arises not because endian is missing, but rather because the configuration object is omitted because it is empty.

Fix now available.

Thanks @manzt - Sample image above is now displaying in vizarr at https://hms-dbmi.github.io/vizarr/?source=https://minio-dev.openmicroscopy.org/idr/v0.5/astronaut.zarr
Closing...


SSPR page at windows login

After configuring the Registry key for "Reset Password" option,  When clicking on the Reset Password, SSPR portal is not opening and getting error "Something went wrong, try again later".
Able to access SSPR portal and reset password after login with user account. also when machine is connected to direct internet, Reset Password is working at login screen.
Any suggestions, what additional configuration is required. Device is hybrid joined.
Also another observation, defaultuser1 account is created when clicking on "Reset Password"  and every time new defaultuser1.machinename.001, 002... profile folder gets created when try to open the link from windows login.  Is SSPR portal is using defaultuser1 account to launch the portal at user login. Does it need proxy settings to open the portal when connected to corporate LAN.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c2015c6c-60c7-bb74-469c-e9320301d08a
Version Independent ID: 0ff19de6-c892-10ff-5fe8-f6a70abfa3f5
Content: Azure AD SSPR from the Windows 10 login screen
Content Source: articles/active-directory/authentication/tutorial-sspr-windows.md
Service: active-directory
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@vinodkmaurya Thanks for your feedback! We will investigate and update as appropriate.

@vinodkmaurya Please open a Azure Support Ticket so that Identity Support engineer can check further on this issue. In case you limitations in your support plan to open support ticket please let me know.

@vinodkmaurya We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.

Hello,
Did you figure this out? is it "expected" to have a default user created/used  when the user clicks on the SSPR link from login screen ?
Thank you in advance /Haïfa

Likewise, we seem to have the exact same behaviour, defaultuser and the function not actually working!

Hi @vinodkmaurya , I was facing the same issue like your. Could you please share how did you fixed it? I enable the 'Reset Password' and it was working when i connected to internet. But when i connected to corporate network, it then prompt the something went wrong message.


I think the model is not well trained

The balance between G and D is lost

Presently working on demonstrating the code via Jupyter Notebook to clearly understand the generator and discriminator functions.


[RFC] Conventions

So after walking through all of our components with @przspa we wrote down the conventions that should be used to standarize them. We tried to find a common patterns easily appliable to every component and scenario.
The purpose of those conventions is to have easy to use and learn API that works similar for similar use cases (so it's predictable).

Use Passing Listeners pattern and bind v-on="$listeners" on components root to hoist events (example SfArrow).
Use scoped slots for markup customization and put template inside them<slot :prop="prop">//template</slot> instead of wrapping slot into a markup with v-for or click event. Just give people needed data properties and methods and let them handle whole section markup by themselves.
Use v-bind in slot scope <slot v-bind="{foo, bar}"></slot> instead of passing scope properties one by one (example SfBreadcrumbs).
Use semantic HTML representation of the component that is not tied to CSS (avoid unnecessary wrappers, use correct HTML tags). It's a must-have to enable storefront-ui themes feature in a near future.
If there is more than 1 slot make all of them named ones. The only exception is when default slot is a default way of configuring the component (for example SfButton)
Use always PascalCase for components in templates (https://vuejs.org/v2/style-guide/#Component-name-casing-in-templates-strongly-recommended) to easily distinguish them from HTML tags.
Provide default value of a prop instead of marking it as required.
Internal components (for example SfAccordionItem that belongs to SfAccordion) shouldn't have separate SCSS files. Since internal component is just a part of it's parent it's styling should be treated as a whole.
BEM class names should be similar as scoped slot names that are replacing those BEM Blocks..
When we use nested components inside other component their props should be passed to parent component as object (for example in SfProductCard we have SfRating so instead of adding max/min props to SfProductsCard we add rating prop that accepts { max, min } object.)

What's next
I'm leaving this document for a few days to discuss all of the conventions. feel free to challange them or propose more!
Once we agree on those conventions every one will become an issue. I hope i can count ion your help with closing them!

Sounds good :)

We may also write conventions for prop names and object modeling.
We're usually adopting simple prop and slot names, in almost all cases with one word only.
When having more complex props (nested objects or array of objects), we may try to follow same conventions for nested property names, and we must define string case for property names, wdyt about it, pascal case or snake case?
myProp.nested_prop = 'any'

myProp.nestedProp = 'any'

@leomp12 good point and I agree with camel case ;)
The thing that I want to heavily discuss is point 2. For example. If we take a look at this PR:
https://github.com/DivanteLtd/storefront-ui/pull/222
according to new convention we should have:

      <slot name="prev" v-bind="{ go }">

          <SfArrow
            class="sf-arrow--long"
            aria-label="previous"/>

      </slot>

      <slot name="next" v-bind="{ go }">

          <SfArrow
            class="sf-arrow--long sf-arrow--right"
            aria-label="next"/>

      </slot>

instead of

      <slot name="prev">
        <SfArrow
          class="sf-arrow--long"
          aria-label="previous"/>
      </slot>

      <slot name="next">
        <SfArrow
          class="sf-arrow--long sf-arrow--right"
          aria-label="next"/>
      </slot>

While this approach is generally great for complicated use cases and limitless customization (since user only gets a scoped slot) it adds extra steps for simle ones (like the above where you need to explicitly include click handler. In other cases you might need to do v-for by yourself etc).
I'm curious about your opinion here @leomp12 @mayashavin

I don't think it would be a problem in this example, but as I commented on discord, I also don't think this approach is the best always, but almost always.
Anyway I agree we may use it as convention always to be predictable :)

Use scoped slots for markup customization and put template inside them//template instead of wrapping slot into a markup with v-for or click event.

I'm agree with this use case. I have wrapped slot with v-for then it would iterate to content of slot. It makes component hardly reusing. 😁


[1.19.2] Conflict with Banner Pattern Textures from other mods.

I've reported a problem with Banner Patterns missing their textures from Aditional Banners and Alex's Mobs in their respective issue trackers and I just discovered that it's a conflict with Create Enchantment Industry.
Here are both mod's issues:
https://github.com/AlexModGuy/AlexsMobs/issues/1403
https://github.com/Darkhax-Minecraft/AdditionalBanners/issues/34
ModList.txt
latest.log

Confirmed, I've found solutions for the problem, will be in next release.


Switch away from travis ci to something else

Travis seems to fail most of the time while the test setup seems to run just fine locally. Let's try semaphore instead.

Pull Request Test Coverage Report for Build 502

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.287%

Totals

Change from base Build 497:
0.0%

Covered Lines:
563

Relevant Lines:
645

💛  - Coveralls


router: bring back upstream request timings

Description:
As part of the changes in #2660 the timing of upstream requests was dropped and upstream logs that use %DURATION% no longer report timings. This change reinstates recording of upstream request timings and adds an explicit unit test.
Risk Level: Low
Testing: Unit test
Release Notes: n/a
Signed-off-by: Stephan Zuercher<EMAIL_ADDRESS>

The unit test doesn't include , so on my system it doesn't build because it can't find std::get_time. I don't see any include of  anywhere in envoyproxy/envoy, so I'm not sure which include is pulling in .


Added py.typed for mypy

This fixes https://github.com/jasondelaat/pymonad/issues/30
Thank you.

Whoa, I totally missed that. Sorry, I've been pretty bad about maintaining this lately. Thanks!


Issues with auto splitter for Gunfire Reborn

What features of the auto splitter don't work?
start, split, reset
Describe your Issue

[x] The game has recently received an update.

If there is any especially weird behavior with the timer, please describe what is happening.
Autosplitter doesn't activate by itself or split after a small update on May 15th, even if the timer is manually activated it doesn't fetch the IGT, reset function also doesn't work on game close if the timer is activated manually
Causes and Fixes
No response

Hi, I've pushed a change. However, I don't see why this should have been broken in the first place. The same logic was still used.

Hey, it appears that the functions for the timer/reset/igt/split do work now somewhat but there's a couple new things
It appears the autosplitter stops registering the game when the game is alt f4ed which is common w/ the game due to save file resetting, it'll pause the timer when the game is force closed but will fail to reset the timer when the game is reopened and if you reset the timer manually after you reopen the game all functions within the splitter will break and wont operate properly again until you close both the game and livesplit and then reopen the game and livesplit after that (the order which things were opened didn't matter previously), i made an example video here: https://streamable.com/xv1k3n
There's a couple things i've tried to get it to operate again after the game has been force closed, which all failed

I've tried pausing the game before alt f4ing to see if it'd reset properly then
I've tried resetting the timer manually after the game has been closed and went into a run to see if the timer would start
I've manually added the new script both through the autosplit activate menu in the splits editor & tried just using the scriptable autosplitter component

Hi, please try again when you have the time.

most functions seem to be working now but the last boss split does not split when a run is completed, it just resets the timer


[DOC] Make semantic line break edits to documentation rst files

Brief Description of Fix

Currently, the docs' raw rst files do not always follow the principles of Semantic Line Break for various markup format. This potentially weakens the readability of the rsf files both for current and future contributors.
I would like to propose a change, such that now the docs follow the Semantic Line Break principles.
Relevant Context

Link to documentation page
Link to exact file to be edited

I'd be happy to work on this during the Scipy2019 Saturday sprints :)

Assigned! :D


Don't see the loading / progress bar at the top

Version
v2.9.1
Reproduction link
http://www.nourl.com
Steps to reproduce
With an installation of nuxt / nuxt-edge, I don't see the loading / progress bar at the top.
According to this doc, the loading indicator should be enabled by default, but it isn't.
https://nuxtjs.org/api/configuration-loading#disable-the-progress-bar
I also tried this in nuxt.config.js:
  loading: { color: "#f00" },

What is expected ?
Loading / progress bar indicator should show up
What is actually happening?
It does not.

This bug report is available on Nuxt community (#c9665)

Maybe your page just loads very quickly, as in within the throttle time?
If not => reproduction

I see the loading bar (red) flash by quickly when an error page is seen...but not on other pages. I'd like the same to show up, except in blue. Will try to reproduce this again.

same here, loading is not showing

i found what was reason in my case.
i had a plugin which replaced mounted() hook in App.js file, so
mounted() {
this.$loading = this.$refs.loading
}

was not triggering

@andreynazarov3 Thanks, interesting reason. How exactly did the plugin replaced the hook? Runtime or in the template? Was it a 3rd party plugin?

@pimlie it was my own plugin to work with cookies on app mount, I was thinking that somehow it will not replace basic mounted hook and just add this additional functionality...
export default ({ app, store }) => {
  app.mounted = function() {
    .... some code
  };
};

@andreynazarov3 if you want to attach another method to mounted without overwriting the original one, use an array:
// plugins/cookie.js
export default ({ app, store }) => {
  app.mounted = [ app.mounted, function () {
    ... some code
  }];
};


Consider ingesting astronomer-providers docs

Please describe the feature you'd like to see
Astro providers are referenced several times in docs that we ingest today (docs.astronomer.io) but some context is missing.
Describe the solution you'd like
Can probably ingest with consolidated html extract from https://astronomer-providers.readthedocs.io/en/stable/
Are there any alternatives to this feature?
Additional context
Acceptance Criteria

[ ] All checks and tests in the CI should pass
[ ] Unit tests
[ ] Integration tests (if the feature relates to a new database or external service)
[ ] Example DAG
[ ] Docstrings in reStructuredText for each of  methods, classes, functions and module-level attributes (including Example DAG on how it should be used)
[ ] Exception handling in case of errors

Note:

[ ] After the implementation is complete, the data should be ingested to the dev database and the dev slackbot should be deployed.
[ ] This change should be tested by @vatsrahul1001 and after his take on quality of response, this should be merged

Note:

[ ] After the implementation is complete, the data should be ingested to the dev database and the dev slackbot should be deployed.
[ ] This change should be tested by @vatsrahul1001 and after his take on quality of response, this should be merged


[Forgot password]: Incorrect error message is shown when user tries to enter not valid e-mail address

Environment: macOS Catalina 10.15.4, Google Chrome 81.0.4044.122 (64-bit), Safari 13.1, Firefox 75.0 (64-bit)
Reproducible: always
Build found: commit 7439e88
Preconditions:
Go to GreenCity url: https://ita-social-projects.github.io/GreenCityClient/#/welcome;
Steps to reproduce:

Click on the 'Sign in' button in the top right part of the window.
Click on 'Forgot password?' link.
Enter data in 'Email' field in incorrect format (e.g. "qwerty")

Actual result:
Error message 'This is not email' displays below the 'Email' field

Expected result:
'Email' field should be highlighted in red color and error message 'Please check that your e-mail address is indicated correctly' should be displayed below the 'Email' field
User story: #472

Verified.


Link the menu items with section headers

Currently, if you click on menu items, nothing happens. It should have smooth-scrolling enabled and be linked properly to the respective section headers.

can I work on this?

can I work on this?

Sure. Feel free to submit PR.

can i work on this?


Redirecting User to homepage if User tries to access login page even after logging in

Fixes #5
I first created a new middleware, redirectToHomeIfLoggedIn() which checks if user is logged in already, if it is it redirects user to homepage otherwise it just calls next() to proceed to requested route
middleware/redirectToHomeIfLoggedIn.js
const redirectToHomeIfLoggedIn = (req, res, next) => {
  //Get user details from the jwt-token and add id to req object(body)
  const token = req.cookies["auth-token"];
  if (!token) {
    return res.redirect("/login");
  }

  // Checking if we are able to get user details, this means that user is already logged in
  try {
    const data = jwt.verify(token, process.env.JWT_SECRET);
    return res.redirect("/api/auth/console"); // So we redirect the user to home
  } catch (err) {
    next(); // Else we just continue to the requested page
  }
};

I then added this middleware to the login page i.e /login route
index.js
app.get("/login", redirectToHomeIfLoggedIn, (req, res) => {
  res.render("login");
});

Good Work