Causes SQL connection errors?

Causes SQL connection errors. When I install this extension, VS2013 constantly locks up and after a bit it will show an error message: "A netowrk-related or instance-specific error occurred while establishing a connection to SQL Server. ...". I can click OK to make that message go away, but VS will lock up again immediately and be locked until it throws that error message again (repeated until I kill VS with Task Manager). I uninstalled this extension and the issue went away. So it is definitely something this extension is doing.
In the background while VS was locked up, I noticed that this plugin did work - it found my tests and ran them. I'm excited about getting this into our process.
Any idea what I'm doing wrong?

I am honestly baffled by ths issue. I am quite sure, that the adapter does not try to connect to an SQL server anywhere in the code. Could you be using another extension, that does connect to an SQL server, and somehow conflcts with the adapter?
I would be interested in seeing your log file (you should be able to find one here: %LocalAppData%/2PS/KarmaTestAdapter/KarmaTestAdapter.log).

I don't see much in the log that would indicate any issues. I did another test, my first attempt was with an asp.net forms project together with a front-end project. I tried opening the front-end project on its own and re-installed the plugin and everything worked fine. So whatever is causing the problem must be only with the asp.net forms application. I tried with a blank new asp.net forms app and the problem did not recur. So the issue is some interaction with that particular forms app. I'm thinking this is probably not something you can solve.
I've tried a bunch of other things and things seem to be working now. There has to be something strange going on with the VS user settings on the project or solution that was causing this - or maybe some temporary files created to help facilitate testing - since it was also tied at least partially to when the test explorer window was open.
Sorry to bother you with an non-relevant issue. Thanks for the quick response!
Here are the other extensions I have installed:

CodeMaid
Grunt Launcher
Open Command Line
Package Intellisense
Productivity Power tools
Shared Project Reference Manager
Task Runner Explorer
Web Essentials
(and a bunch of others that come from Microsoft and are probably in every install of VS)

Here is the log file:
[07.04.2015 11:25:50.365] [Karma] [Debug] TestContainerDiscoverer created
[07.04.2015 11:27:02.149] [Karma] [Debug] [DSpa] Creating TestContainer for karma.conf.js
[07.04.2015 11:27:02.162] [Karma] [Debug] [DSpa] Watching KarmaTestAdapter.json
[07.04.2015 11:27:02.165] [Karma] [Debug] [DSpa] Watching karma.conf.js
[07.04.2015 11:27:03.041] [Karma] [Debug] [DSpa] [Server] Starting Karma: "C:\Program Files\nodejs\node.exe" C:\USERS\DAVID\APPDATA\LOCAL\MICROSOFT\VISUALSTUDIO\12.0\EXTENSIONS\QZWFZFD2.CWN\KarmaTestServer\Start.js --name DSpa --karma karma.conf.js
[07.04.2015 11:27:03.043] [Karma] [Debug] [DSpa] TestContainer created
[07.04.2015 11:27:03.500] [Karma] [Debug] [DSpa] INFO [karma]: starting karma server
[07.04.2015 11:27:04.211] [Karma] [Debug] [DSpa] INFO [VS Reporter]: Created
[07.04.2015 11:27:04.220] [Karma] [Debug] [DSpa] INFO [VS Jasmine]: Ready
[07.04.2015 11:27:04.228] [Karma] [Debug] [DSpa] Karma started using port 61062
[07.04.2015 11:27:04.613] [Karma] [Debug] [DSpa] INFO [VS Server]: Started - port: 61062
[07.04.2015 11:27:04.616] [Karma] [Debug] [DSpa] INFO [karma]: Karma v0.12.31 server started at http://localhost:61061/
[07.04.2015 11:27:04.619] [Karma] [Debug] [DSpa] INFO [launcher]: Starting browser Chrome
[07.04.2015 11:27:04.625] [Karma] [Warning] [DSpa] WARN [watcher]: Pattern "c:/Dev/Framework/Portal/TsSrc/src/3rdParty/*.js" does not match any file.
[07.04.2015 11:27:04.869] [Karma] [Debug] Refreshing containers: Karma started for DSpa
[07.04.2015 11:27:05.206] [Karma] [Debug] [DSpa] [Discover] Start
[07.04.2015 11:27:06.143] [Karma] [Debug] [DSpa] DEBUG [karma]: A browser has connected on socket SobwljRiMdnrukc6tN8p
[07.04.2015 11:27:06.151] [Karma] [Debug] [DSpa] INFO [Chrome 41.0.2272 (Windows 7)]: Connected on socket SobwljRiMdnrukc6tN8p with id 66552397
[07.04.2015 11:27:06.155] [Karma] [Debug] [DSpa] DEBUG [karma]: All browsers are ready, executing
[07.04.2015 11:27:06.158] [Karma] [Debug] [DSpa] INFO [VS Server]: Test run start
[07.04.2015 11:27:06.404] [Karma] [Debug] Refreshing containers: Test run started for DSpa
[07.04.2015 11:27:06.808] [Karma] [Debug] [DSpa] INFO [VS Server]: Test run complete
[07.04.2015 11:27:06.898] [Karma] [Debug] [DSpa] [Discover] Complete: 3 tests
[07.04.2015 11:27:06.901] [Karma] [Discover] 3 tests discovered in 1 test containers
[07.04.2015 11:28:15.650] [Karma] [Debug] [DSpa] [Discover] Start
[07.04.2015 11:28:15.656] [Karma] [Debug] [DSpa] [Discover] Complete: 3 tests
[07.04.2015 11:28:15.658] [Karma] [Discover] 3 tests discovered in 1 test containers
[07.04.2015 11:28:16.110] [Karma] [Debug] [DSpa] [Run] Start
[07.04.2015 11:28:16.374] [Karma] [Debug] [DSpa] [Run] Complete: 3 tests
[07.04.2015 11:28:16.376] [Karma] [Run] 3 tests run in 1 test containers

@davidpricedev
I'm just glad you got it working!


Drop '2' from BeamFnDataGrpcMultiplexer2 and BeamFnDataInboundObserver2

This is a follow-up for a comment in https://github.com/apache/beam/pull/25104 and was done in a separate PR since the move is easier to review this way.
Also remove InboundDataClient which was missed in https://github.com/apache/beam/pull/25104

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @y1chi


Defaults shouldn't override previously set variables

In our application we set the rollbar_token from environmental variables for security, but when rollbar loads itself up it blows away the already-set variables with it's defaults.

Thanks @kdonovan! This looks good to me. @jondeandres can you review as well?

@brianr it's nice for me.

Merge, thanks @kdonovan! Will get this out in the next release.

Released in 1.4.3 (now on rubygems)

This is breaking deploys for me. The problem is that by the time the Rollbar load:defaults task is run, the deploy.rb file has not been parsed, and thus my set :rollbar_token, ENV['ROLLBAR_ACCESS_TOKEN'] has not been run.
So I'm consistently getting the message Please specify the Rollbar access token, set :rollbar_token, 'your token'
@kdonovan How are you loading the Roller access token ENV variable?

I've detected the problem here.
fetch is not so safe cause it evaluates the default value if it's callable, https://github.com/capistrano/capistrano/blob/master/lib/capistrano/configuration.rb#L41.
We can do something crazy like Proc.new { Proc.new { ... } }, but is really ugly.
@kdonovan could you provide us the loading order you have when setting :rollbar_token, require 'rollbar/capistrano3 and others?
It seems you are setting :rollbar_token before `require 'rollbar/capistrano3' is executed, could be?
My suggestion is change that order, and we'll then revert this PR since it's being a problem for most of the users.

@kdonovan I could reproduce your problem with this code
task :foo do
  set :rollbar_token, proc { 'foo' }
end

before 'load:defaults', 'foo'

Are you using something similar? In that case 'load:defaults' will override your values.
We can fix this for everybody with this code:
namespace :load do
  task :defaults do
    set :rollbar_user,  Proc.new { ENV['USER'] || ENV['USERNAME'] } unless fetch(:rollbar_user)
    set :rollbar_env,   Proc.new { fetch :rails_env, 'production' } unless fetch(:rollbar_env)
    set :rollbar_token, Proc.new { abort "Please specify the Rollbar access token, set :rollbar_token, 'your token'" } unless fetch(:rollbar_token)
    set :rollbar_role,  Proc.new { :app } unless fetch(:rollbar_role)
  end
end

But probably the best is just not set anything before 'load:defaults' is executed, https://github.com/capistrano/capistrano/blob/master/lib/capistrano/setup.rb#L13.


GUI 8.8rc Splitter - GUI needs restarted when switching to a different coin

If I use the new splitter on a certain coin the first time it works great.  Then if I switch to a different coin and try the splitter, in the confirmation window it shows the coin that I was previously splitting.  If I restart the GUI and start with my 2nd coin then the confirmation window shows the correct coin for splitting.

https://github.com/KomodoPlatform/BarterDEX/issues/96


Regression in 1.6 with editing

We seem to be aggressively autocompleting even in places where we're making a new declaration.  This is a regression from 1.5 (incl. with VS 2015):
class Foo {
  // type "star(" here modulo quotes
}

Expected behavior: no autocomplete
1.6 behavior: autocompletes to "animationStartTime("

In VS2015 RTM we don't autocomplete here. The list appears by typing a completion character like that would leave you with star(.

Would it be possible to fix this for the 1.6 release?  It's pretty annoying, imho.

We could try. not sure if we can get it before 1.6 is out. there are already a lot of other issues.

Duplicate of #3377.


702 downport

see https://github.com/larshp/abapGit/commit/af93a489db35f480e2bcd70a0356e49e96d3d29c#commitcomment-23580513

hi, the problem is ony with this line now:
lcl_exit=>get_instance( )->change_local_host( CHANGING ct_hosts = lt_list ).

@tjankow2 try again, latest version

It's fine now, thanks.

👍 closing


Add issue template

Add issue template in the project.

I'll like to work on this, please assign this to me.

@bhattabhi013 what will you add in issues


Improved documentation for android Manifest modification

I had some problems understanding how it was meant, so I tried to improve the docs. Additionally I added the exported=true param which is needed for android 12.

The pipeline error is related to some dart nullability error, which I did not remotely touch. So I guess the problem is from somewhere else?

Thank you @supermar1010!


OAuth2TokenVerifier.verify(Map) -> OAuth2TokenVerifier.verify(T extends AbstractOAuth2Token)

Consider changing the verifier signature to accept a generic type that extends AbstractOAuth2Token to have a richer object model. This ensures users inject an OAuth2TokenVerifier that works with the class that needs it. For example:
public interface OAuth2TokenVerifier<T extends AbstractOAuth2Token> {

	void verify(T token) throws OAuth2AuthenticationException;

}

This would allow us to fix other places in the code to be type safe and still rely on interfaces. For example, JwtAccessTokenAuthenticationProvider currently relies on JwtAccessTokenVerifier which is a class. If we make the changes above, we could inject OAuth2TokenVerifier<Jwt> instead.
Using a subclass of AbstractOAuth2Token instead of Map also provides a richer domain model for OAuth2TokenVerifier.

@rwinch You beat me to this issue! I had a note to add this. This totally makes sense and I agree on all points.

One concern with this (now that I've begun implementing it), is that typing the parameter will make it a little tricker to share a verifier across multiple formats.
I don't think we lose much with this, but mentioning it here in case anyone sees a gotcha.

Let's say that we have a custom verifier that checks a particular claim, say the "iss" claim.
public void verify(Map<String, Object> attributes) {
    Assert.assertNotNull(attributes.get("iss"), "iss cannot be null");
}

The above verifier isn't directly tied to JWT, but instead can verify any token
to have the "iss" claim. For example, this class could be reused for an opaque token flow after it is exchanged for a set of claims:
oauth2().resourceServer()
  .addVerifier(issuerVerifier())
  .jwt()
  .opaque();

With the new contract, we'd do something maybe like this:
public void verify(AbstractOAuth2Token token) {
    String iss;
    if ( token instanceof Jwt ) {
        iss = ((Jwt) token).getIssuer();
    } else if ( token instanceof MyOtherTokenType ) {
        iss = (String) ((MyOtherTokenType) token).getClaimAsString("iss");
    } else {
        // ... exception
    }

    // ... assert
}

if we wanted to try and reuse. Though personally, I would prefer doing:
public void verify(Jwt token) {
    Assert.assertNotNull(token.getIssuer());
}

// ... and

public void verify(MyOtherTokenType token) {
    Assert.assertNotNull(token.getClaimAsString("iss"));
}

and tying them directly to the token type, which would mean possibly doubling up on the number of verifiers:
oauth2().resourceServer()
  .jwt()
    .addVerifier(jwtBasedIssuerVerifier())
  .opaque()
    .addVerifier(myOtherTokenTypeIssuerVerifier());

To be clear, I think this is a minor trade off. The stronger typing that we get, and the encapsulation benefit as well, are more important.

Taking a quick look at the current implementations of AbstractOAuth2Token, I'm not certain that adding a getAttributes method there is on the table

AbstractOAuth2Token defines the minimal set of attributes whereas OAuth2AccessToken defines the additional attributes defined by RFC 6749. So IMO it wouldn't make sense to define getAttributes() here since we already provide accessors to each of the attributes.

...though the original contract for verify (taking a Map) kind of implies that we only anticipate(d) verifying tokens that have attributes.

Jwt and IntrospectedAccessToken (future) do have additional attributes so these would be the types evaluated in OAuth2TokenVerifier.


Prompt when closing with connected trackers (#24)

Linked to #24
The prompt shows up when trying to close SlimeVR while trackers are still connected. I included a setting to let users choose if they want to be warned or not.
I also took the liberty of adding French translations.
This is the first time I work on an open source project, so please review the code I made and give me feedback on what to improve, as I'm sure it won't be perfect the first time!

You have commits that shouldn’t be here, please rebase and get rid of them as it messes with the diff on Github.

Ok, I'll makes these changes later today

?

It felt easier to just redo the branch entirely because my commit history was all borked up. I'll create a new PR in a few minutes, unless I can reference my new branch here?

I don't believe you can change the branch for an existing PR.
Making a new PR is fine, I won't be the one to cry about it (Git wizards might though)


[SPARK-47934] [CORE]  Ensure trailing slashes in HistoryServer URL redirections

What changes were proposed in this pull request?
This PR addresses the issue outlined in JIRA ticket SPARK-47934, where inconsistent application of trailing slashes in URL redirections within the Spark's history web UI was leading to unnecessary HTTP redirects by Jetty. This inefficiency caused increased load times and reduced the UI's performance.
Why are the changes needed?
to fix  SPARK-47934
Does this PR introduce any user-facing change?
no
How was this patch tested?
This patch was tested with an added unit test method in the HistoryServerSuite that verifies correct redirection behavior for different attempt IDs.
Was this patch authored or co-authored using generative AI tooling?
no

Welcome to the Apache Spark community, @huangzhir .
I added you to the Apache Spark contributor group and assigned SPARK-47934 to you.
Congratulations for your first commit!
This will be a part of Apache Spark 4.0.0. You can check it next Monday's Apache Spark 4.0.0-preview.


⚠ Pihole-KA has degraded performance

In 558725d, Pihole-KA ($URL_PIHOLE_MERZ_NIMBUS) experienced degraded performance:

HTTP code: 200
Response time: 20019 ms

Resolved: Pihole-KA performance has improved in c51bf48 after 42 minutes.


TS definition: ExtensionContext.subscriptions is not defined as array

VSCode Version: 1.6.0-insider
OS Version: macOS sierra (10.12)

Steps to Reproduce:

Create an extension
In the activate function, the ExtensionContext parameter has a subscriptions property which should be an array (see the definition). The TypeScript definition however declares it as {}.

This might be quite important. I have no idea when this was introduced. I was looking into upgrading my vscode-final-newline extension in the VS Code insiders build. This might be quite important.
// @bpasero @jrieken @Tyriar

It seems this is an issue in Disposable.from as well.

My bad, was installing an old vscode.d.ts file.


Add tests that fail if a new QuestionType enum is added

Description
Adds tests that fail if a new QuestionType enum is added, so that it is harder to miss files that should be changed when adding a new question type.
Checklist

[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

Issue(s)
Fixes #581
Sample test failure (added a NEW_TYPE enum):

So when we want to add a new QuestionType, we just add it to the ignore list along-side REPEATER? 😅

I'm hoping to get RepeatedQuestionDefinition in asap so there won't be an ignore list to add to soon :)


Factory Generates Invalid Values for Constrained Types in NewType

Overview
When we are generating our Pydantic models, we often prefer to have new distinct types as our field types. This improves our ability to understand our code but also it allows for static type checking of the values that get used. So for example, if I had code that was using a FirstName type in a field that is defined to take a LastName, the static type checker (or, really the IDE) will catch that problem.
We can also take advantage of the constrained types in the NewType declaration to reduce the work required to validate the field. For example we can do this:
FirstName = NewType('FirstName', constr(min_length=1, max_length=50))
LastName = NewType('LastName', constr(min_length=1, max_length=50))

class User(BaseModel):
    first_name: FirstName
    last_name: LastName

The problem comes with implementing the ModelFactory. After doing the above, the model factory no longer works out of the box:
class UserFactory(ModelFactory):
    __model__ = User

Example
>>> from pydantic import BaseModel, constr
>>> from typing import NewType
>>> from pydantic_factories import ModelFactory
>>> FirstName = NewType('FirstName', constr(min_length=1, max_length=50))
>>> LastName = NewType('LastName', constr(min_length=1, max_length=50))
>>> class User(BaseModel):
  2     first_name: FirstName
  3     last_name: LastName
>>> class UserFactory(ModelFactory):
  2     __model__ = User
>>> UserFactory.build()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "REDACTED/pydantic_factories/factory.py", line 726, in build
    return cast("T", cls.__model__(**kwargs))  # pyright: ignore
  File "REDACTED/pydantic/main.py", line 342, in __init__
    raise validation_error
pydantic.error_wrappers.ValidationError: 2 validation errors for User
first_name
  ensure this value has at least 1 characters (type=value_error.any_str.min_length; limit_value=1)
last_name
  ensure this value has at least 1 characters (type=value_error.any_str.min_length; limit_value=1)

Problem
This is not an issue when constr is used directly:
>>> class Test(BaseModel):
  2     a: constr(min_length=1)
>>> class TestFactory(ModelFactory):
  2     __model__ = Test
>>> TestFactory.build()
Test(a='6d')

So the issue must have something to do with having constr bound to the NewType. The ModelFactory appears to be using an empty string as a default in that case. This happens with all the constrained field types. When a constrained field type is used as the type a NewType is bound to, the ModelFactory will generate a basic value for that type; conint gets 0, confloat gets 0.0, condecimal gets Decimal('0.0'), conbytes gets b'', and so on.
>>> from pydantic import conbytes, constr, conint, confloat, conlist, condecimal, conset, confrozenset, condate
>>> from datetime import *
>>> ConBytes = NewType('ConBytes', conbytes(min_length=1))
>>> ConStr = NewType('ConStr', constr(min_length=1))
>>> ConInt = NewType('ConInt', conint(gt=0))
>>> ConFloat = NewType('ConFloat', confloat(gt=0))
>>> ConList = NewType('ConList', conlist(min_items=1, item_type=int))
>>> ConDecimal = NewType('ConDecimal', condecimal(gt=0))
>>> ConSet = NewType('ConSet', conset(item_type=str, min_items=1))
>>> ConFrozenSet = NewType('ConFrozenSet', confrozenset(item_type=str, min_items=1))
>>> class Test(BaseModel):
  2     con_bytes: ConBytes
  3     con_str: ConStr
  4     con_int: ConInt
  5     con_float: ConFloat
  6     con_list: ConList
  7     con_decimal: ConDecimal
  8     con_set: ConSet
  9     con_frozen_set: ConFrozenSet
>>> class TestFactory(ModelFactory):
  2     __model__ = Test
>>> TestFactory.build()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "REDACTED/pydantic_factories/factory.py", line 726, in build
    return cast("T", cls.__model__(**kwargs))  # pyright: ignore
  File "REDACTED/pydantic/main.py", line 342, in __init__
    raise validation_error
pydantic.error_wrappers.ValidationError: 5 validation errors for Test
con_bytes
  ensure this value has at least 1 characters (type=value_error.any_str.min_length; limit_value=1)
con_str
  ensure this value has at least 1 characters (type=value_error.any_str.min_length; limit_value=1)
con_int
  ensure this value is greater than 0 (type=value_error.number.not_gt; limit_value=0)
con_float
  ensure this value is greater than 0 (type=value_error.number.not_gt; limit_value=0)
con_decimal
  ensure this value is greater than 0 (type=value_error.number.not_gt; limit_value=0)

We are currently explicitly setting the faker values for each of the keys in the factory. But this is quite tedious for a big model and even more so when you've got a nested model. In the case of the nested models, we must explicitly create the nested factories now when we wouldn't need to otherwise.
Note:
The ModelFactory raises the following error if a constrained date is used:
pydantic_factories.exceptions.ParameterError: Unsupported type: <class 'pydantic.types.ConstrainedDateValue'>

Either extend the providers map or add a factory function for this model field

Unsupported type: <class 'pydantic.types.ConstrainedDateValue'>

Hi Mike,
Two different problems here- first is we don't have support in place for NewType. Second is what you reported regarding constrained dates.
I'll take a look when I can. It might take a few days.

Hey! Thanks for the response. About the constrained date, I hadn't ever tried that one, and I wanted to report what I found. Happy to create a new issue, if you'd like. I also noticed later that the constrained set, frozenset, and list don't cause errors.
Anyhow, thanks for looking into this.

@Goldziher would you mind if I take a look into this today? I always wanted to do a dive into Python typing internals

@Goldziher would you mind if I take a look into this today? I always wanted to do a dive into Python typing internals

By all means 😁, you're a maintainer.

@mikelane just FYI - the fix has been released in 1.15.0


makeXRCompatible might fail - catch and reject correctly

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/15231/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15231/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15231/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/15231/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/15231/merge
https://gui.babylonjs.com/?snapshot=refs/pull/15231/merge
https://nme.babylonjs.com/?snapshot=refs/pull/15231/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/15231/merge#BCU1XR#0

WebGL2 visualization test reporter:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15231/merge/testResults/webgl2playwright/index.html


QnA Maker how-to needs a little polishing

The article contains links into the QnA Maker documentation; however, these do not fit very well in the flow of the article. (We could perhaps review and move such links into the additional information section.)
Article: Use QnA Maker to answer questions
Link: https://docs.microsoft.com/en-us/azure/bot-service/bot-builder-howto-qna?view=azure-bot-service-4.0&tabs=cs
Issues

Remove the links to the QnA Maker documentation from the immediate instructions on how to create and publish the QnA Maker service.
We're missing information on adaptive learning, part of sample 49. This might be appropriate for the Additional information section, or it might need its own article.

Additional context
Tracy Boehrer brought this up in the context of people using this article while trying to get the associated sample 11 running. Following the chain of links was unhelpful in that context. Please include him as a reviewer on the eventual PR.

See also samples issue 2439.

Updated in master/main. Content update will go live with the next live-main sync.


Export static targets in a separate file

When packaging for a distro, we usually only ship shared objects by default, which could cause issues if static libraries are not present, but defined in the installed CMake project config.
This PR separates static libraries in a new TdStaticTargets export, and only includes it when exists.

Crc32c is an optional dependency and isn't used by TDLib. It was supposed to be specified manually during CMake configuration, but an attempt to find it always shouldn't harm.
This patch moves only some static library targets to a separate cmake file. There are other defined static libraries in the main CMakeLists.txt. Could you also elaborate, what kind of issues the patch is supposed to solve? Is the change to improve the error message shown when trying to link to a non-present static library?

Before this PR, an attempt to find_package(Td) on a system with no static libraries installed (e.g. distro splits the package and made -static subpackage as an optional dependency), it produces an error.
This PR isolates the static targets and includes them only when installed on the system, resolving the issue.

I has also pushed fixes for separation of installed static and dynamic libraries.


Add multipleOf field to parser

Describe the PR
Add ability to specify multipleOf struct field
Relation issue
N/A

To Review the PR, we need to have a passed test and positive code coverage.
Unfortunately, we had some trouble with the Travis-ci pipeline, and the build didn't run.
Please do another push with a slight change, so the build is triggered.

Thanks @ubogdan have pushed a small change to trigger, if you could please unblock the workflow :D


error building from windows

I was following all the readme steps to compile from windows but I get this error:
go run .\main.go

# rogchap.com/v8go
v8go.cc:16:37: fatal error: libplatform/libplatform.h: No such file or directory
compilation terminated.

main.go
package main

import (
	"rogchap.com/v8go"
	"fmt"
)

func main() {
	ctx, _ := v8go.NewContext()
	ctx.RunScript("const add = (a, b) => a + b", "math.js")
	ctx.RunScript("const result = add(3, 4)", "main.js")
	val, _ := ctx.RunScript("result", "value.js")
	fmt.Printf("addition result: %s", val)
}

i'm using go 1.16 and windows 10 64bits

This is one person had exactly the same problem as you do.  Please take a look. Hope this helps.

ok I found the libplatform folder in C:\msys64\mingw64\include, where I need to add this folder in order to compile?

follow the 4 steps in this section, it should works for you then.

For anyone who followed the Windows installation guide but still has trouble and found this thread I also had to do
pacman -S mingw-w64-x86_64-v8
and that cleared things right up

Which version of v8go are you using?
0.6.0 will have the static binaries for Windows.
If you want to test this before release you can use master: go get rogchap.com/v8go@master

I keep getting
d:/chocoportable/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: cannot find -lz
collect2.exe: error: ld returned 1 exit status

with rogchap.com/v8go v0.6.0
Any tips on what might be going on?

rogchap.com/v8go v0.6.0 works fine for me, had some issues with an existing chocolatey installations but solved it by cleaning up my PATH to make sure there are no mingw conflicts


fix update images (DO NOT MERGE)

ROCK images were published with updated names. This PR updates required resources to point to newly published images.
Summary of changes:

Updated configmap and metadata with published ROCK images.

New PR filed https://github.com/canonical/seldon-core-operator/pull/169 Closing.

PR with unsigned commits.
Another PR handled this https://github.com/canonical/seldon-core-operator/pull/171
Closing.


Newsletter #5: add link to Bitcoin Core weekly meeting

Citation link to the summary for the described conversation.

Tested ACK 79619e601af84d447a0a5a12c2c588fbba64cae1. Thanks!


WebGL support

Hi! It might be a long shot, but have you thought at all about what it would take to get this crate running within a WASM context, targeting WebGL? I know NanoVG itself has received minor attention on this question. I've been working a bit on recoding NanoVG in Rust with a particular focus on targeting WebGL, but I think this is silly given how much is already done here.
Personally I'm a bit lost on how emscripten re-targets GLES2 code to WebGL (see the linked issue), so I'm not sure yet what would be the best way to attack this problem... Just wanted to see if anyone has had any thoughts!

Interesting... haven't thought about it, no, but sounds cool.
A little googling finds this rust/webgl example ...so I guess something like this is possible

I think the biggest hurdle has to do with coercing NanoVG to interface with the WebGL API. WebGL is subset of GLES2, but there still has to be some sort of mapping layer between the WebGL and GLES2 APIs (because WebGL is built for JS; GL for C). Emscripten seems to provide such a layer, but I'm not sure WebAssembly (itself an evolution of Emscripten) has such a thing yet.
Anyway my long-term goal is to be able to code performant web GUIs in Rust, and I think something like NanoVG could be the basis. I'll post here if I make any progress relevant to this project. Thanks!


Embeddings and frontend

The following pull request includes the following updates:

addition of Python script that performed tests on embedding models
relocation of streamlit visualization script to src folder
initial development of v2 of streamlit within src folder
updates to requirements.txt to reflect new Python libraries to be used
relocation of the script that converts raw JSON to BigQuery ready parquet files to src/data subfolder

Two more things:

Remove all .py files in your repo that are currently empty. Looks like cookiecutter created a lot of them. But you don't want them there.
Squash your commits. You should always do this before merging a PR. It collapses all your commits for a branch into a single commit, that way it's easier to group commits together and figure out what was done where. See here on how to do this: https://gist.github.com/patik/b8a9dc5cd356f9f6f980


[Bug] It's not Working

Hi.
This is gerenating lots of errors. It's not even possible to open the actor sheet.

Thanks for making this! Hopefully the issue can get sorted at some point. I'm going to try and learn more about Foundry, maybe I'll be able to submit a fix in the future.

So I've been trying to replicate this issue with no success. On the local machine, it works exactly as it should. I'm going to do some more digging to try to figure out why on earth it's not working outside of the local environment. It might be a path that was made exact instead of relative, but will fix when I can.

For what it's worth, I can open the actor sheet on mine. I can't right click and assign it to a person though.

I cloned this and tried to play with it a bit, but I unfortunately have no idea what I'm doing.
That's the only issue I'm having: assigning sheets to players and keeping them hidden from others.

Unfortunately, I'm running into the same issue. Can't right-click on Actors to assign or delete. V9- Build 280 of FVTT.
Appreciate you making it regardless.


[Slider] valueLabel size should be configurable

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡
The size of the valueLabel should be configurable so that more characters can be shown.
Examples 🌈
Increasing the size to 50px allows for larger values to be displayed

Motivation 🔦
The current valueLabel on the slider is only large enough to display 3 characters. It is stuck at 32px, and it is not easily configurable.

@KamalAman You can provide your own implementation, if we move forward with #20153, we will get this support native.


Duplicate tag "g:rnvimr_draw_border" in file /home/kino/.cache/dein/.cache/init.vim/.dein/doc/rnvimr.txt

After I updated the all plugins with dein,
mentioned the following messages,
I don't know waht it means.
Update started: (2020/07/13 21:59:06)
Error generating helptags:
Vim(helptags):E154: Duplicate tag "g:rnvimr_draw_border" in file /home/kino/.cache/dein/.cache/init.vim/.dein/doc/rnvimr.txt
function 3[1]..dein#install#_polling[7]..113_install_async[9]..113_done[9]..dein#install#_recache_runtimepath[19]..
113_helptags, line 12
Done: (2020/07/13 21:59:45)

Thanks for your feedback. I use vim-plug which generates tag file silent, so I don't realize the error I made before.


Add OpenThread Support to ESP32 DeviceLayer using ot-esp32

This PR is tested with https://github.com/openthread/ot-esp32 for thread support on ESP32.
Since ot-esp32 requires ESP-IDF 3.3 or later, this PR depends on https://github.com/openweave/openweave-core/pull/567.

ThreadStackManagerImpl is copied from EFR32 with some changes for
ot-esp32.
ConnectivityManagerImpl and Warm is updated to support Thread if Enabled
Removed EFR32_OPENTHREAD_API check in GenericThreadStackManagerImpl_OpenThread

Codecov Report

Merging #597 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #597      +/-   ##
==========================================
- Coverage   54.14%   54.10%   -0.04%
==========================================
  Files         331      331
  Lines       57655    57731      +76
==========================================
+ Hits        31218    31237      +19
- Misses      26437    26494      +57

Impacted Files
Coverage Δ

src/inet/DNSResolver.cpp
47.55% <ø> (ø)

...i/security-support/native/WeaveSecuritySupport.cpp
57.89% <0.00%> (-15.44%)
:arrow_down:

...rofiles/data-management/Current/TraitPathStore.cpp
92.63% <0.00%> (-4.79%)
:arrow_down:

...lib/profiles/data-management/Current/TraitData.cpp
71.42% <0.00%> (-2.18%)
:arrow_down:

src/lib/core/WeaveFabricState.cpp
37.46% <0.00%> (-0.87%)
:arrow_down:

src/lib/core/WeaveTLVDebug.cpp
77.77% <0.00%> (-0.45%)
:arrow_down:

...les/data-management/Current/SubscriptionClient.cpp
7.55% <0.00%> (-0.08%)
:arrow_down:

src/lib/core/WeaveFabricState.h
17.39% <0.00%> (ø)

src/lib/core/WeaveTLVReader.cpp
94.86% <0.00%> (ø)

src/lib/core/WeaveTLVWriter.cpp
92.95% <0.00%> (ø)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27503bf...13f8e81. Read the comment docs.

@robszewczyk PTAL, this PR based on #567, but I think it is also OK to ignore #567 and merge this directly.

@robszewczyk I have rebased this PR, ptal.


Dataset Viewer issue for RUCAIBox/Data-to-text-Generation

Link
https://huggingface.co/datasets/RUCAIBox/Data-to-text-Generation
Description
The dataset viewer is not working for dataset RUCAIBox/Data-to-text-Generation.
Error details:
Error code:   ResponseNotFound

Thanks for reporting, @hoboyu11.
Please note that this is not an issue with the viewer itself: your dataset does not load.
Note that .tgz data files are not supported and you would need to:

Either changing the archive file format to a supported one, like .zip
Or implement a Python loading script; see docs here: Create a dataset loading script

I have opened a discussion in the "Community" tab of your dataset.
Let's continue the discussion there.


Go Forum  Problems using database/sql with denisenkom/go-mssqldb

macOS 10.13.1 High Sierra
Golang 1.9.2
Docker Toolbox
microsoft/mssql-server-linux:2017-latest

Hello. I've been using database/sql combined with denisenkom/go-mssqldb with a reasonable amount of success, but there are one or two glitches as I shall explain. I've had an issue active on the Golang forum for a couple of days but there's been no real response yet. I shall try to reproduce the essence of the issue here.
I have the following client code:
package main

import (
	q "github.com/carlca/bigdata/sqlserver"
	_ "github.com/denisenkom/go-mssqldb"
)

func main() {
	db := q.Connect()
	defer db.Close()
	tx := db.NewTx()
	tx.Exec("DROP TABLE IF EXISTS Company")
	tx.Exec(`CREATE TABLE Company
		(ProductID int PRIMARY KEY NOT NULL,
		ProductName varchar(25) NOT NULL,
		Price money NULL,
		Price2 money NULL,
		ProductDescription text NULL)`)
	tx.CommitTx()
}

I also have the following library code:
package sqlserver

import (
	"database/sql"
	"flag"
	"fmt"

	e "github.com/carlca/utils/essentials"
)

var (
	debug    = flag.Bool("debug", false, "enable debugging")
	password = flag.String("password", "", "the database password")
	port     = flag.Int("port", 1433, "the database port")
	server   = flag.String("server", "", "the database server")
	user     = flag.String("user", "", "the database user")
)

// DB inherits from sql.DB
type DB struct {
	*sql.DB
}

// Exec combines Prepare and Exec methods
func (db *DB) Exec(cmd string) {
	stmt, err := db.Prepare(cmd)
	e.CheckError("prepare: "+cmd+" failed", err)
	_, err = stmt.Exec()
	e.CheckError("exec: "+cmd+" failed", err)
	if *debug {
		fmt.Printf("exec: %v succeeded\n", cmd)
	}
}

// NewTx wraps the *DB.Begin func
func (db *DB) NewTx() *Tx {
	tnx, err := db.Begin()
	e.CheckError("BeginTx failed: ", err)
	if *debug {
		fmt.Printf("NewTx: succeeded\n")
	}
	return &Tx{*tnx}
}

// Tx inherits from sql.Tx
type Tx struct {
	sql.Tx
}

// Exec wraps *Tx.Exec
func (tx *Tx) Exec(cmd string) {
	stmt, err := tx.Prepare(cmd)
	e.CheckError("prepare: "+cmd+" failed", err)
	_, err = stmt.Exec()
	e.CheckError("exec: "+cmd+" failed", err)
	if *debug {
		fmt.Printf("exec: %v succeeded\n", cmd)
	}
}

// CommitTx wraps the *Tx.Commit func
func (tx *Tx) CommitTx() {
	err := tx.Commit()
	e.CheckError("tx.CommitTx failed: ", err)
	if *debug {
		fmt.Printf("tx.CommitTx succeeded\n")
	}
}

// Connect establishes contact with an SQL Server
func Connect() *DB {
	// parse command line flags
	flag.Parse()
	// dump flags if debug
	if *debug {
		fmt.Printf("password: %s\n", *password)
		fmt.Printf("port: %d\n", *port)
		fmt.Printf("server: %s\n", *server)
		fmt.Printf("user: %s\n", *user)
	}
	// build connection string
	connString := fmt.Sprintf("server=%s;user id=%s;password=%s;port=%d", *server, *user, *password, *port)
	// if debug dump connection string
	if *debug {
		fmt.Printf("connString: %s\n", connString)
	}
	// create an SQL Server connection
	dbx, err := sql.Open("mssql", connString)
	e.CheckError("Open DB failed: ", err)
	if *debug {
		fmt.Printf("open mssql: succeeded\n")
	}
	err = dbx.Ping()
	e.CheckError("db.Ping failed", err)
	return &DB{dbx}
}

and
package essentials

import (
	"fmt"
	"log"

	"github.com/pkg/errors"
)

// CheckError is function to check error with call stack
func CheckError(msg string, err error) {
	if err != nil {
		log.Fatal(fmt.Sprintf("%v: %+v", msg, errors.WithStack(err)))
	}
}

The problem is that I’m getting intermittant failure at the end of the client code. It says “panic: sql: connection returned that was never out”. When this occurs, however, if I wait a couple of seconds and run the client program again, it runs without failure.
The error message comes from a func *DB.putConn in sql.go, and seems to be a state dependent issue that occurs depending on timing.
I’ve had a search on Google but, apart from some mentions from github.com/go from 2012 or thereabouts, I cannot find any relevant references.
func (db *DB) putConn(dc *driverConn, err error) {
	db.mu.Lock()
	if !dc.inUse {
		if debugGetPut {
			fmt.Printf("putConn(%v) DUPLICATE was: %s\n\nPREVIOUS was: %s", dc, stack(), db.lastPut[dc])
		}
		panic("sql: connection returned that was never out")
	}
	if debugGetPut {
		db.lastPut[dc] = stack()
	}
	dc.inUse = false

	for _, fn := range dc.onPut {
		fn()
	}
	dc.onPut = nil

	if err == driver.ErrBadConn {
		// Don't reuse bad connections.
		// Since the conn is considered bad and is being discarded, treat it
		// as closed. Don't decrement the open count here, finalClose will
		// take care of that.
		db.maybeOpenNewConnections()
		db.mu.Unlock()
		dc.Close()
		return
	}
	if putConnHook != nil {
		putConnHook(db, dc)
	}
	added := db.putConnDBLocked(dc, nil)
	db.mu.Unlock()

	if !added {
		dc.Close()
	}
}

It’s worth pointing out that when the code fails, it is failing at a point after the occurrence of the very last item in the client code, namely the call to tx.CommitTx. The debug info and error message is:
go run simple.go -debug=true -server=<IP_ADDRESS> -password=<MyPassword> -user=sa
password: <MyPassword>
port: 1433
server: <IP_ADDRESS>
user: sa
connString: server=<IP_ADDRESS>;user id=sa;password=<MyPassword>;port=1433
open mssql: succeeded
NewTx: succeeded
exec: DROP TABLE IF EXISTS Company succeeded
exec: CREATE TABLE Company
                (ProductID int PRIMARY KEY NOT NULL,
                ProductName varchar(25) NOT NULL,
                Price money NULL,
                Price2 money NULL,
                ProductDescription text NULL) succeeded
tx.CommitTx succeeded
panic: sql: connection returned that was never out

goroutine 20 [running]:
database/sql.(*DB).putConn(0xc420098140, 0xc4202ae000, 0x14008a0, 0xc42004a1d0)
        /usr/local/go/src/database/sql/sql.go:1054 +0x202
database/sql.(*driverConn).releaseConn(0xc4202ae000, 0x14008a0, 0xc42004a1d0)
        /usr/local/go/src/database/sql/sql.go:380 +0x47
database/sql.(*driverConn).(database/sql.releaseConn)-fm(0x14008a0, 0xc42004a1d0)
        /usr/local/go/src/database/sql/sql.go:643 +0x3e
database/sql.(*Tx).close(0xc4202ca000, 0x14008a0, 0xc42004a1d0)
        /usr/local/go/src/database/sql/sql.go:1720 +0x91
database/sql.(*Tx).rollback(0xc4202ca000, 0x1, 0x0, 0x1057b91)
        /usr/local/go/src/database/sql/sql.go:1807 +0xef
database/sql.(*Tx).awaitDone(0xc4202ca000)
        /usr/local/go/src/database/sql/sql.go:1701 +0x5e
created by database/sql.(*DB).beginDC
        /usr/local/go/src/database/sql/sql.go:1451 +0x216
exit status 2

Also, I tried rearranging the client code with defer tx.CommitTx like so:
func main() {
	db := q.Connect()
	defer db.Close()
	tx := db.NewTx()
	defer tx.CommitTx()
	tx.Exec("DROP TABLE IF EXISTS Company")
	tx.Exec(`CREATE TABLE Company
		(ProductID int PRIMARY KEY NOT NULL,
		ProductName varchar(25) NOT NULL,
		Price money NULL,
		Price2 money NULL,
		ProductDescription text NULL)`)
}

When I ran it. It failed twice in quick succession and then ran without error the third and subsequent times.

This does seem odd. Can you reproduce it without the extra packages involved?
I'm also confused about the method names, the q.Connect() appears to return a "database/sql".DB struct, but the methods you list aren't on that struct. It is also odd that the name inside q.Connect calls *sql.DB a "conn" variable, when it is really a connection pool.

Thanks for the reply!

This does seem odd. Can you reproduce it without the extra packages involved?

I was hoping to introduce some more logging and debugging information, that's all.
On 3 Dec 2017, 22:23 +0000, Daniel Theophanes<EMAIL_ADDRESS>wrote:

I'm also confused about the method names, the q.Connect() appears to return a "database/sql".DB struct, but the methods you list
No, the q.Connect returns my own DB struct which has an embedded "database/sql".DB struct but with additional methods, such as NewTx(). You can ignore the new DB.Exec function as that is not used
aren't on that struct. It is also odd that the name inside q.Connect calls *sql.DB a "conn" variable, when it is really a connection pool.
I’m not sure which variable you’re referring to here. Which variable “is really a connection pool”?

I’m using dbx, err := sql.Open("mssql", connString)
To create the dbx variable which is an instance of "database/sql”.DB struct which is later used as  the basis of the returned “sqlserver”.DB (my own derived struct) instance.
Would it help if I put a "go get”…able version of the code up on Github.com?
Thanks,
Carl

If so do go get github.com/carlca/bigdata and go get github.com/carlca/utils.
Then cd carlca/bigdata/sqltest and the client file simple.go should be there.

There’s a badly worded comment there that says:
// create an SQL Server connection
whereas it should say something like:
// create a "database/sql".DB variable
On 3 Dec 2017, 23:34 +0000, Carl Caulkett<EMAIL_ADDRESS>wrote:

aren't on that struct. It is also odd that the name inside q.Connect calls *sql.DB a "conn" variable, when it is really a connection pool.
I’m not sure which variable you’re referring to here. Which variable “is really a connection pool”?

I'm unable to reproduce regardless of how many times I run it. My output:
daniel@conk ~/s/g/c/b/sqltest> ./run.sh
password:
port: 1433
server: <IP_ADDRESS>
user: sa
connString:
open sqlserver: succeeded
NewTx: succeeded
exec: DROP TABLE IF EXISTS Company succeeded
exec: CREATE TABLE Company
		(ProductID int PRIMARY KEY NOT NULL,
		ProductName varchar(25) NOT NULL,
		Price money NULL,
		Price2 money NULL,
		ProductDescription text NULL) succeeded
tx.CommitTx succeeded

That being said, I'm also running Go from master, not go1.9.2, so it is slightly different.

Also, if you're using SQL Server, you're wasting time creating Stmts. Just execute the sql directly, the server will cache plans and all that jazz.

Thanks a lot for trying Daniel. It's also different because, as mentioned, I'm running SQL Server as the Linux version in a Docker container on an Apple Mac.
I'll try your suggestion of abandoning the Stmts and see how that goes.

I'm running SQL Server on Linux directly. But that really shouldn't make a difference. The first go1.10 beta will be released soon. When they come out please download and try them on that. Thanks.

I had a big refactoring session and simplified a lot of things. My client code is now:
package main

import (
	q "github.com/carlca/bigdata/sqlserver"
	e "github.com/carlca/utils/essentials"
)

func main() {
	dbase, debug := q.Connect()
	defer dbase.Close()
	tx, err := dbase.Begin()
	e.CheckError("dbase.Begin()", err, debug)
	defer tx.Commit()
	_, err = tx.Exec("DROP TABLE IF EXISTS Company")
	e.CheckError("DROP TABLE", err, debug)
	_, err = tx.Exec(`CREATE TABLE Company
		(ProductID int PRIMARY KEY NOT NULL,
		ProductName varchar(25) NOT NULL,
		Price money NULL,
		Price2 money NULL,
		ProductDescription text NULL)`)
	e.CheckError("CREATE TABLE", err, debug)
}

and my library code is:
package sqlserver

import (
	"database/sql"
	"flag"
	"fmt"

	e "github.com/carlca/utils/essentials"
	// MSSQL driver
	_ "github.com/denisenkom/go-mssqldb"
)

var (
	debug    = flag.Bool("debug", false, "enable debugging")
	password = flag.String("password", "", "the database password")
	port     = flag.Int("port", 1433, "the database port")
	server   = flag.String("server", "", "the database server")
	user     = flag.String("user", "", "the database user")
)

// DB inherits from sql.DB
type DB struct {
	*sql.DB
}

// Connect establishes contact with an SQL Server
func Connect() (*DB, bool) {
	// parse command line flags
	flag.Parse()
	// dump flags if debug
	if *debug {
		fmt.Printf("password: %s\n", *password)
		fmt.Printf("port: %d\n", *port)
		fmt.Printf("server: %s\n", *server)
		fmt.Printf("user: %s\n", *user)
	}
	// build connection string
	connString := fmt.Sprintf("server=%s;user id=%s;password=%s;port=%d", *server, *user, *password, *port)
	// if debug dump connection string
	if *debug {
		fmt.Printf("connString: %s\n", connString)
	}
	// create an SQL Server connection
	dbx, err := sql.Open("mssql", connString)
	e.CheckError("Open DB", err, *debug)
	err = dbx.Ping()
	e.CheckError("db.Ping", err, *debug)
	return &DB{dbx}, *debug
}

and:
package essentials

import (
	"fmt"
	"log"

	"github.com/pkg/errors"
)

// CheckError is function to check error with call stack
func CheckError(msg string, err error, both bool) {
	if both {
		if err == nil {
			fmt.Println(fmt.Sprintf("%v succeeded", msg))
		} else {
			log.Fatal(fmt.Sprintf("%v failed: %+v", msg, errors.WithStack(err)))
		}
	} else {
		if err != nil {
			log.Fatal(fmt.Sprintf("%v failed: %+v", msg, errors.WithStack(err)))
		}
	}
}

The intermittant problem has disappeared it seems. I think I was trying to be too clever before with too many DB adn Tx funcs being wrapped for the sake of error checking. Now I think I've still got sufficient error checking with the advantage that the code runs error free.
My next project is to create a PostgreSQL equivalent using the github.com/lib/pq library. Hopefully the abstrations provided by the database/sql library should make this really easy!!


Semver and Releases

As of filing this, the latest release is v3.0.2, but the semver tags go up through v3.0.7. Should consumers of this package use the explicitly released version or the latest semver tag?

Hi @cholick,
We've just added a v4.0.0 release, which includes work for the OSBAPI 2.14 spec and relates to the v3.0.3 tag. The tags between v3.0.3 and v3.0.7 were created for internal use. In the future, we plan to be more explicit and less confusing about creating releases. Thanks for bringing this to our attention, and let us know if you have additional thoughts.
Winna and @kieron-pivotal


Users/xinlian/included path and exclude path update

This PR solve https://github.com/Azure/azure-sdk-for-java/issues/11192
IncludedPath ->
Remove constructor which takes jsonString
Add constructor which takes String path - and call logic of setPath(path) in the constructor
Change public Collection getIndexes() { -> public List getIndexes()
ExcludedPath ->
Add constructor which takes String path - and call logic of setPath(path) in the constructor

/azp run java - cosmos - tests


Changed Yammer references to Slack

Seems like an oversight...

Hi @fitzgeraldsteele, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@fitzgeraldsteele : Thanks for your contribution to the Azure documentation! The author, @msftman, has been notified to review your proposed change.


Problem with docker build

I'm struggling to get the proper linux environment to work for this, so I've resorted to using docker. I eventually got the program to work with the provided docker build instructions about a week or so ago on WSL2, but it doesn't seem to work for me any more.
docker build -t first-order-model . fails for me on this step: full log
Collecting opencv-python (from face-alignment==1.1.0)
  Downloading https://files.pythonhosted.org/packages/a1/d6/8422797e35f8814b1d9842530566a949d9b5850a466321a6c1d5a99055ee/opencv-python-<IP_ADDRESS>.tar.gz (88.0MB)
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-wuc0x2vh/opencv-python/setup.py", line 9, in <module>
        import skbuild
    ModuleNotFoundError: No module named 'skbuild'

Any ideas to get this working again?
Running on a fresh WSL2 Ubuntu build following the instructions here. Building with a fresh clone of this repo as well.
Thank you!

Hi, I have exactly the same problem after downloading OpenVino toolkit for linux with FPGA support version 2020.4.287.
the same issue is being solved in this thread, but I do not know, how to download changed files.
https://github.com/OpenVisualCloud/Dockerfiles/issues/549

Hi, this problem is described in issue in official opencv-python repo and in their FAQ.

Submited a pull request to fix it

Submited a pull request to fix it

This worked, thank you

Edit the Dockerfile, and add RUN pip3 install scikit-build==0.11.1 before the last Command
about like this:
FROM nvcr.io/nvidia/cuda:10.0-cudnn7-runtime-ubuntu18.04

RUN DEBIAN_FRONTEND=noninteractive apt-get -qq update \
 && DEBIAN_FRONTEND=noninteractive apt-get -qqy install python3-pip ffmpeg git less nano libsm6 libxext6 libxrender-dev \
 && rm -rf /var/lib/apt/lists/*

COPY . /app/
WORKDIR /app

RUN pip3 install scikit-build==0.11.1
RUN pip3 install setuptools

RUN pip3 install \
  https://download.pytorch.org/whl/cu100/torch-1.0.0-cp36-cp36m-linux_x86_64.whl \
  git+https://github.com/1adrianb/face-alignment \
  -r requirements.txt


Sprite icon previews flicker when browsing large groups of objects

When renaming lots of objects, AssetPreviews for sprites load in and out, causing them to flicker. Ideally we only need to load the icons that are in view of the scroll view. The function to Draw the PreviewPanel would calculate which rows will be on screen and call one of two functions:

DrawPlaceholderRow - just reserves the space of a row
DrawPreviewPanelRow - just as normal.

Repro steps:

Create a ton of sprites (duplicate a spritesheet)
Select all the sprites and open the Renamer window
Observe the icons flicker as you scroll

This appears to be fixed with Issue #97, which only draws the elements that will fit in the scroll view.


Exosuit step assist issue

The exosuit is currently "saving" the step assist feature to the player after they take it off. This is a major issue, and needs to be fixed.

I have determined that this issue is probably directly related to #185.

Was the step assist removed? Seems no longer available in 0.28.x!

No... I was just using it in my dev environment. You have to be wearing the boots.

I'm no longer able to reproduce this issue, oddly.

This was fixed at some point between March 6 and now. Myself and the @Esteemed-Innovation/testing-monkeys have confirmed this.


[Bug]: State value incorrect - divided by 1000 for Speedtest Ping value

Requirements

[X] I checked the troubleshooting section in the README to verify that I have the latest Mushroom version.
[X] I did a search to see if there is a similar issue or if a pull request is open.

Current Behavior
I am getting incorrect values displaying in my mushroom entity card for my speedtest ping result. When checking the actual state in Developer Tools in HA, the state correctly shows as 19 for example. However, the muchroom entity card shows a state of 0.019. The state always displays incorrectly by this factor. This was been happening for several weeks now, possibly as a result of an update somewhere. Previously, the state always used to display correctly. My other speedtest values for upload and download and both showing correctly, and they also use the mushroom entity card.
The ping state shows correctly when using a regular entity card, so the problem seems to be related to the mushroom entity card.
Expected Behavior
Show the state of the entity exactly as it displays in the Developer Tools State display in HA
Steps To Reproduce
Add a new mushroom entity card. Add entity 'sensor.speedtest_ping'. See incorrect state in card in primary information field. The same happens if you add the state to the Secondary Information field.
Context
YAML state

Environment
- Browser: Chrome
- HA Version: 2023.10.1
- Mushroom: 3.1.0

Anything else?
No response

Can you test with other official card (tile card for example). Do you have the same issue?

I did test with the built-in Entity card, and it does show correctly, so that pointed to the mushroom entity card as having the issue initially. I've now tried various other built-in cards, and some of them do also show the value incorrectly, so it's not isolated to the mushroom entity card after all. I guess I can close this now, and I'll have to dig deeper into whats causing this, as the state of the ping entity shows correctly in the HA Developer Tools State view. As the upload and download speeds are measured 'per second' I wonder if the ping is now also incorrectly being displayed in seconds, as opposed to milliseconds like it used to be, and how it should really be, to give the expected display. The ping entity unit of measurement is ms so that's what should be displayed. I guess maybe more of a generic frontend issue. Still not sure why the built-in entity card shows it correctly when other built-in cards don't though...


push.txt and test.txt added

check the push and test.txt

taken push.txt and test.txt as well

Thanks bro


feat: use hairlineWidth in custom mapping

Issue type
I'm submitting a ...

[ ] bug report
[x] feature request

Issue description
Current behavior:
When defining a custom mapping, we need to explicitly define variables such as my-border-width : 1
Expected behavior:
In custom-mapping.json file, we should be able to refer to StyleSheet.hairlineWidth.
Hairline width is very useful to draw crisps lines (and borders) in various situations. A use case would be to define component borders referring to that values instead of specifically specifying a value.

Hi 👋 Thanks for the proposal. Unfortunately, we don't plan using mappings to access something from js. But we use it only to map component parameters on theme variables (currently only colors).
Within the next releases, we plan to support more theme variables like global borderRadius, etc.
You still able to use withStyles function, can it be helpful?


Fix footnote handling for n-digit numbers

fixes #4815

Fix regex
Add new test

Don't merge yet.

There was a don't merge comment which is now gone so I assume it's ok?

@ErisDS Yes :) I had overlooked something and deleted the comment a minute later.


Support a set_args method in param models

To do:

[ ] Older pydantic support
[ ] Documentation

Closing in favor of https://github.com/zytedata/zyte-spider-templates/pull/46.


fix: add telemetry reporting

Fix #43.

@benoitf

I think we're missing lot of data in telemetryData
I would expect the time it has taken, in case of failure, which step succeed/failed.

did we have to restart and how many restart

It is always one restart if needed at all, I can send start and stop command outcome.

at which step the user stopped the flow

User cannot stop the flow right now, it keeps going until it is finished with failure or success.

for example it's different if user aborted if no podman machine was running vs error in doing the task
did we have a PodmanMachineRunning ?

I have added error messages to telemetry for registry configuration and subscription activation

was isSubscriptionManagerInstalled already installed ?

Follow up issue #113 created

Was it registryAccess part, vmActivation part

added field with error message for each part

for each step, the time it took as well.

Follow up issue #114 created

Then about the session, probably need some data (about the user being authenticated
I don't know what data we have but maybe number about some fields of the user (counter)

I need clarification for this. What king of tracking we want to do here. Number of logins for specific user? Session duration?


Update eventing and cloudevents SDK.

Proposed Changes

Update eventing and events SDK.

/assign @mattmoor

/lgtm
/approve

/woof

/test pull-knative-eventing-contrib-integration-tests


Weird behavior in dmenu mode

echo "c\nb\na" | walker -d

e, d, u, n or m matches everything
Pressing letter that matches history + tab completes from history, not useful in dmenu mode (ex: h + tab = hello)
Pressing arrow up puts f in search box doesn't happen with shift + tab

fixed (caused by matching other stuff Walker normally matches against, f.e. the sub.. in this case "dmenu"
fixed: disabled typeahead for dmenu-mode
fixed: disabled up-history in dmenu-mode


docs: Added style guide and branching to contributors guidelines

This should probably be merged to master also.

@mattwalsh-unity Just to confirm with you. Would you be OK with this change being merged into master aswell?
It's important as users will usually access the CONTRIBUTING.md in master via UI.

We don't want to merge this yet!
We need confirmation first that it will be merged to master. Otherwise the link will not work in the contributing

BTW my comment to @mattwalsh-unity was that we have not shared this file to the public intentionally we have in-advertently done so and that we should follow-up internally before we do; not that I am concerned about anything in the file.

BTW my comment to @mattwalsh-unity was that we have not shared this file to the public intentionally we have in-advertently done so and that we should follow-up internally before we do; not that I am concerned about anything in the file.

Who are "we" in this context?
When I spoke to the owner of this file he said that they had intended on sharing this file publicly but simply not gotten around to it, and also gave us the go ahead to share it publicly without objections from their side.

BTW my comment to @mattwalsh-unity was that we have not shared this file to the public intentionally we have in-advertently done so and that we should follow-up internally before we do; not that I am concerned about anything in the file.

Who are "we" in this context?
When I spoke to the owner of this file he said that they had intended on sharing this file publicly but simply not gotten around to it, and also gave us the go ahead to share it publicly without objections from their side.

To be clear its not just the owner that gets to make that choice... anytime we share internal content it should be vetted by legal and/or Director level people. Just because someone wrote a file and says sure share away doesn't mean that its okay to actually do it.


PostgreSQL v13.0 connection problem

Aqueduct can't connect database when PostgreSQL version is 13.0
os: windows 10
aqueduct version: 4.0.0-b1
>> aqueduct db upgrade
-- Aqueduct CLI Version: 4.0.0-b1
-- Aqueduct project version: 4.0.0-b1
*** There was an error connecting to the database 'username:pasword@localhost:5432/dbname'.
Reason: unable to connect to database.

The cause is "unsupported authentication method", which occurs because the postgres driver uses the md5 method, which in PostgreSQL 13 is not enabled by default (or not supported at all, I am not sure). So you either reconfigure the database (if it's possible), or downgrade PostgreSQL to v12. Or you can try to upgrade the postgres driver, but I couldn't make it work.

Adding/modding:

host    all             all             <IP_ADDRESS>/32            md5

... to:

C:\Program Files\PostgreSQL\13\data\pg_hba.conf

... should allow md5 authentication for PostgreSQL 13.  However, when I did that, I still had the same issue as @YTarikKalyoncu


Fix a clippy warning

This PR fixes a small clippy warning that was appearing in the CI. Basically, since the result is a unit structure, it doesn't make sense to bind it, even if it's to a discarded binding.

Fixed as part of #22


Manifest: Include PowerTable CID

Replaces: https://github.com/filecoin-project/go-f3/issues/484
By (optionally) including the power table CID in the manifest, nodes can join the network without having to have any state. Basically:

Load the manifest.
Attempt to load the power table from state.
If that fails and the manifest specifies the power table CID, attempt to fetch the power table from peers via the finality exchange protocol.
Finally, verify that the power table CID in the manifest matches the power table we loaded.
Proceed to sync finality certificates to catch up.
Once caught up, start GPBFT.

For testing, we can integrate this into the dynamic manifest server by:

Shipping a manifest with no power table CID (pre-f3-genesis).
Post-f3-genesis, we can ship another manifest that includes this power table CID.

 We can probably just punt on that and start GPBFT immediately (we'll cancel instances as we catch up anyways...).


unable to utilize the -MembershipType switch

I am trying to get a list of the 'Standard' team channels.  The process documented is failing:
Get-TeamChannel -GroupId $GroupID -MembershipType Private
Get-TeamChannel : Error occurred while executing
Code: BadRequest
Message: The query specified in the URI is not valid. The string 'Microsoft.Teams.GraphSvc.channelMembershipType'private'' is not a valid enumeration type constant.
InnerError:
RequestId: f8d3db34-31fe-4edd-a8b0-2363656b1817
DateTimeStamp: 2019-11-25T22:29:59
HttpStatusCode: BadRequest
At line:1 char:1

Get-TeamChannel -GroupId $GroupID -Member ...

  + CategoryInfo          : NotSpecified: (:) [Get-TeamChannel], ApiException
  + FullyQualifiedErrorId : Microsoft.TeamsCmdlets.PowerShell.Custom.ErrorHandling.ApiException,Microsoft.TeamsCmdlets.PowerShell.Custom.GetTeamChannel

PS C:\WINDOWS\system32> Get-Module -Name MicrosoftTeams -ListAvailable
Directory: C:\Program Files\WindowsPowerShell\Modules

ModuleType Version    Name                                ExportedCommands

Binary     1.0.18     MicrosoftTeams                      {Add-TeamChannelUser, Add-TeamUser, Set-TeamArchivedState, Get-CsPolicyPackage...}

@TimShegrud
thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


Trusted users

This is a solution for a couple of problems:

Users who arrange long-running usergroups but who have to wait for approval every month
Conference organising 'veterans' who have been running conferences for years, and for who we don't really need to spend time reviewing

A user can be set as 'trusted' by a joind.in admin, at which point their future event submissions get approved automatically (in the same way that admin submissions do).
There isn't really a set criteria for allowing someone to be trusted - I know there are a few conference/UG organisers who have been after this feature for a while and that we know well, so I guess we'd try it out on them first.

I think I've responded and/or resolved everything now - not my comment on the "trusted" field in the mapper - if you agree, then suggest this needs to go into JIRA.
As such, if you are happy with the fixes @heiglandreas please confirm :-)

Over to you @railto  :-)

Have pushed a few changes to clean the code up a little and respond to some of the concerns, so @railto   I guess it's over to you if everyone is happy :)

Tried to run this locally, but unfortunately getting - https://www.dropbox.com/s/3cxukd4mal4x4mg/Screenshot 2017-03-27 15.22.00.png?dl=0
PHPUnit also throwing some 70 errors when run via phing on the vagrant box

Never mind, local issue of my own doing


HBASE-24993 Remove OfflineMetaRebuildTestCore

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 57s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  0s
the patch passed

+1 :green_heart:
compile
1m  6s
the patch passed

+1 :green_heart:
javac
1m  6s
the patch passed

+1 :green_heart:
shadedjars
6m 40s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 40s
hbase-server in the patch failed.


Executable built with pyinstaller does not work

Hi!
I am currently trying to build an executable locally. The machine I am running on is a MacBook Air running MaOS. Building the executable works:
% pyinstaller ms_teams_hand_detector.py
63 INFO: PyInstaller: 4.6
63 INFO: Python: 3.9.7
76 INFO: Platform: macOS-12.0.1-x86_64-i386-64bit
77 INFO: wrote /Users/matthias/local_repos/ms-teams-hand-detector/ms_teams_hand_detector.spec
81 INFO: UPX is not available.
83 INFO: Extending PYTHONPATH with paths
['/Users/matthias/local_repos/ms-teams-hand-detector']
313 INFO: checking Analysis
342 INFO: checking PYZ
350 INFO: EXE target arch: x86_64
...

However, calling the executable from the dist folder yields the following error message when being executed.
% ./ms_teams_hand_detector
Traceback (most recent call last):
  File "ms_teams_hand_detector.py", line 2, in <module>
  File "PyInstaller/loader/pyimod03_importers.py", line 476, in exec_module
  File "cv2/__init__.py", line 180, in <module>
  File "cv2/__init__.py", line 110, in bootstrap
  File "cv2/__init__.py", line 108, in load_first_config
ImportError: OpenCV loader: missing configuration file: ['config.py']. Check OpenCV installation.
[923] Failed to execute script 'ms_teams_hand_detector' due to unhandled exception!

Any OpenCV / Python / PyInstaller experts?
Any hints how this could be fixed?
(BTW: I think about using github's CI to generate executables automatically for Windows, Linux and Mac OS)

Related:

https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/110
https://github.com/marcelotduarte/cx_Freeze/issues/1275


Ensorcellation & Elenai Dodge 2 mod conflict

When Dungeons Mobs, Elenai Dodge 2, and Esorcellation are all installed, if a player is shot by a bow enchanted with the Trueshot enchantment, the game hangs. I can't provide any more details. In singleplayer, there is no crash log. Attached is a crashlog from a RAD 2 server which experienced the bug.
crash-2022-09-21_00.18.09-server.txt

Fixed in latest beta :)


"Could not run explain" on queries that can be manually

The following queries show a "could not run explain" when run via dexter:
Query fe79b362d324b6da
Total time: 0.0 min, avg time: 0 ms, calls: 1
Could not run explain

SELECT COUNT(*) AS "__count" FROM "notification_notification" WHERE ("notification_notification"."tenant_account_id" = xx AND "notification_notification"."agent_id" = xxx AND "notification_notification"."id" = 'xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx'::uuid AND "notification_notification"."agent_id" = xxx)

However it returns results when run manually using EXPLAIN ANALYZE:
Aggregate  (cost=4.17..4.18 rows=1 width=8) (actual time=0.033..0.034 rows=1 loops=1)
  ->  Index Scan using chat_notification_tenant_account_id_2edd2b1e on notification_notification  (cost=0.14..4.17 rows=1 width=0) (actual time=0.027..0.028 rows=0 loops=1)
        Index Cond: (tenant_account_id = xxx)
        Filter: ((agent_id = xxx) AND (id = 'xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx'::uuid))
Planning Time: 0.276 ms
Execution Time: 0.089 ms

Help? 😂

@ankane this is what it shows -- I presume that if it is just a single layer it will show "could not run explain"?
[sql] EXPLAIN (FORMAT JSON)
SELECT COUNT(*) AS "__count" FROM "notification_notification" WHERE ("notification_notification"."tenant_account_id" = xxx AND "notification_notification"."agent_id" = xxx AND "notification_notification"."id" = 'xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx'::uuid AND "notification_notification"."agent_id" = xxx)
[sql] EXPLAIN (FORMAT TEXT)
SELECT COUNT(*) AS "__count" FROM "notification_notification" WHERE ("notification_notification"."tenant_account_id" = xxx AND "notification_notification"."agent_id" = xxx AND "notification_notification"."id" = 'xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx'::uuid AND "notification_notification"."agent_id" = xxx)
Aggregate  (cost=4.17..4.18 rows=1 width=8)
  ->  Index Scan using chat_notification_tenant_account_id_2edd2b1e on notification_notification  (cost=0.14..4.17 rows=1 width=0)
        Index Cond: (tenant_account_id = xxx)
        Filter: ((agent_id = xxx) AND (id = 'xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx'::uuid))

EXPLAIN (FORMAT TEXT) should show up 3 times for the query, so it's likely happening in another part of the output.


Update recommended-equipment

Updated auto-incrementer as per Abex request
Added plugin icon
Updated tags and description
Updated Readme page to fix broken link

Can you provide a reference for this requested change?

@raiyni Here is the reference from RuneLite dev channel: https://discord.com/channels/301497432909414422/419891709883973642/1273977480956477440
@adamk33n3r Please delete this from watchdog and reccomended-equipment. It writes the date&time into the jar and makes it non reproducable, which makes it hard for me https://github.com/adamk33n3r/runelite-watchdog/blob/master/build.gradle#L55

Ugh im sorry - I don't know how I closed this PR. I made a minor update to the readme (spelling), and then pushed it to the master branch of my fork. And I guess it auto-closed this PR?

Is writing the builds count on compilation all that important? if not, you could remove all of this from the build script https://github.com/t8or/runelite-recommended-equipment/blob/dd45953b8bfd1f67a609eb37acd7177797480550/build.gradle#L43-L55

@iProdigy We included it as it is helpful for development and testing. We will be keeping it in please.

You can generate this information in your shadowJar task instead?

You can generate this information in your shadowJar task instead?

Then the build number would only increment when building a shadowjar, which isn't always done. Would be weird to have the same build number for different release versions. This is already being restricted to only the build task (and explicitly ignoring the plugin hub task) so we're good here.

for plugin hub builds, you have versions as the identifier
for local development, you could check an environment variable you set on your machines that increments the build numbers, meaning you'd have version number + build number
would that solve your development/testing needs?

I suppose, but that's extra overhead for any developer to have to do. I'm not sure why the discussed and implemented solution isn't sufficient. The issue was the version changing during plugin hub deploy. This fixes that issue.

What you are doing isn't easily discernible by multiple reviewers and the easiest path forward is to not do it, as originally asked in the discord link.
I'm honestly still not sure why you need it for development and testing in its current state.  If that's the case, why does the increment count matter and not the commit hash?

I'm honestly still not sure why you need it for development and testing in its current state.  If that's the case, why does the increment count matter and not the commit hash?

A commit hash is still not granular enough when attempting to fix issues, at least in my experience. I can't speak directly for this plugin since I just copied it here, but for watchdog I have often sent multiple jars with fixes to users who reported issues to test them out. If using just the hash, since I haven't made commits, the file name would be the exact same and overwrite itself with every change. Having an incrementing build number let's each change I make be distinguishable no matter what without me having to think about it.
I hope that explains the process better and its usefulness. It's been like this in watchdog for years and is part of my development process when interacting with my users. In this case, since @t8or is the owner of this plugin, I'll leave the decision up to him for this PR. But I'd like more cooperation with my own.

for watchdog I have often sent multiple jars with fixes to users who reported issues to test them out

how are you tracking which changes are in which build? this sounds like the perfect use-case for commit, build, send shadowJar with commit hash in it to track exactly which commit someone is on

But I'd like more cooperation with my own.

The feedback is the same, as you are doing the exact same thing.

The nuance of this is way beyond me, so I asked Chat GPT to translate this into something I can understand lol

The Core of the Disagreement:
Developers like raiyni and pajlada believe that using commit hashes (a standard approach in development) should be sufficient to track changes.
Adamk33n3r argues that an incrementing build number is easier and more practical for his workflow, especially in development scenarios where uncommitted changes are tested. This method avoids confusion with file overwrites and makes each build distinct.

Please forgive my ignorance here. Essentially what this means is that Adamk33n3r prefers to track his changes via a value in the code that is updated rather than commits because he believes that you shouldn't commit testing changes until they are validated? While Raiyni and Pajlada you both prefer to push code and commit it to track your changes. Do I have this all figured correctly? Essentially, there are two different ways to track changes to the code - one is in the public way, and the other is inside the code?

My intent wasn't to sidetrack the PR, this was probably a question better asked in Discord - I was trying to understand the value of the build number if it cannot be tracked to code, not necessarily arguing against your PR. It'll be up to the maintainers to review this PR.

Merging as this is still better than the current behaviour


feat: dedicated websocket pod

Based on #2719

hey @krtk6160 ,
This PR https://github.com/GaloyMoney/galoy/pull/2783 is almost ready for the galoy-backend and new websocket server. I was talking with @nicolasburtey , how would we go about exposing this with a subdomain DNS like below:
ws.blink.sv -> websocket server


Circle: white fill fails to render

I noticed this for a plot with a nonstandard background color this fails:
var circleOuter = formsPlot1.Plot.Add.Circle(Coordinates.Origin, 1);
circleOuter.FillColor = Colors.White;

It seems to work in the test system... false alarm?
ScottPlot.Plot plot = new();
plot.DataBackground.Color = Colors.Gray;

var circle = plot.Add.Circle(Coordinates.Origin, radius: 10);
circle.FillColor = Colors.White;


Binding Redicts are added only occasionally

Description
Can't figure out why Binding Redirects are being added by paket only on some packages when I have set redirects: on or add --redirects parameter for paket.
Repro steps
In this simple example repo I have the following paket.dependencies file (and xunit is added to project ConsoleApplication):
redirects: on
source https://nuget.org/api/v2

nuget xunit

Now if i run any of the following

paket install
paket install -f
paket install -f --redirects
paket install -f --redirects --createnewbindingfiles

Expected behavior
Binding Redirects are added to the existing App.config file. For the package itself and also for all the transitive dependencies.
Could be that I've misunderstood something here, but the documentation  quite clearly states:

tells paket to create Assembly Binding Redirects for all referenced libraries

So I'd assume that all libraries that are added as reference in *.csproj, would get matching Binding Redirects added to App.config as well (direct and transitive).
Actual behavior
Binding Redirects are not added. Not for the given package nor for the transitive dependencies.
Remarks and additional info
No known workarounds. I tried to add the package with --redirects flag, but this did not help. Also tried to set nuget xunit redirects: force on paket.dependencies, but no luck there either.
On the other hand in the following test paket seems to add Binding Redirect for FSharp.Core, but not for UnionArgParser: https://github.com/Gonnagle/paket-tests/releases/tag/binding-redirects-partially-working
Weirdly if I try to add FSharp.Core to the original test (next to xunit) the redirects fail to appear for this package also...

In my very limited experience with Paket, I've noticed that binding redirects are lost/not generated for transitive dependencies.

If I remember correctly, the original implementation of BR code in Paket did exactly that - it was very simple and spat out BRs into the config file even if they weren't needed. I believe that the more recent implementation was a lot smarter and only added in BRs when they were necessary.

usually redirects: force do a better job than on

@forki is this a real argument? I couldn't find it documented anywhere.

Force? Yes in the dependencies file. Should be documented

I just tried it - it removed all BRs completely.

@isaacabraham that behaviour is easy enough to document :laughing:

I actually just managed to get the provided example to work by setting the redirects: force for the given nuget:
redirects: on
source https://nuget.org/api/v2

nuget xunit redirects: force

Changing the redirects: on the top of the file between on and off didn't seem to have any effect at all. And also tried to set this to force which resulted only to ``REDIRECTS: ON` to disappear from the lock-file (no BRs). So this seems to be supported only on individual dependencies?
Paket version used was 3.33.5.

Just tested this with 5.100.2 and it seems that the solution wide option paket.dependencies now works as expected. So changing it as follows:
redirects: force
source https://nuget.org/api/v2

nuget xunit redirects: force

And running paket install -f now creates the binding redirects as expected.


Fix typo in node configuration for kubelet service

Please remove extra spaces in "--kubeconfig" parameter in the first raw.
It's must look like:
Environment="KUBELET_KUBECONFIG_ARGS=--bootstrap-kubeconfig=/etc/kubernetes/bootstrap-kubelet.conf --kubeconfig=/etc/kubernetes/kubelet.conf"
B.R.
Vitaliy R.

Took me way to long to look at this... sorry. Thought it got resolved a long time ago, it didn't. Fixed it now


save/load DataArray to numpy npz functions

hey -
Apologies if this is bad form: I wanted to pass this along but don't have time to do a proper pull request.
I have found pickle to be really problematic for serializing data, so wrote these two functions to save to numpy's binary npz format and retrieve it. Generally, the numpy format is much less likely to bomb when attempting to load on another computer because of some unseen dependency. If there's interest, I could probably add this as a serialization method to DataArray in the next month or so.
def to_npz(da, file_or_buffer):
    if 'dims' in da.dims:
        raise ValueError('Can\'t use "dims" as a dim name.')
    if 'values' in da.dims:
        raise ValueError('Can\'t use "values" as a dim name.')
    arrays = {}
    arrays['dims'] = da.dims
    for dim in da.dims:
        arrays[dim] = da.indexes[dim]
    arrays['values'] = da.values
    np.savez(file_or_buffer, **arrays)

def from_npz(file_or_buffer):
    data = np.load(file_or_buffer)
    assert hasattr(data, 'keys'), "np.load returned a {}, not a dict-like object".format(type(data))
    assert 'dims' in data, 'Can\'t locate "dims" key in file'
    assert 'values' in data, 'Can\'t locate "values" key in file'
    for dimname in data['dims']:
        assert dimname in data, 'Can\'t locate "{}" key in file'.format(dimname)
    return xray.DataArray(data['values'], dims=data['dims'], coords=dict(zip(data['dims'], [data[dimname] for dimname in data['dims']])))

it's pretty speedy, here is an example for a (3, 4, 5) shaped DataArray:
In [42]:
def save_and_load_again(da):
    with open('/path/to/datarray.npz', 'w') as f:
        to_npz(da, f)
    with open('/path/to/datarray.npz', 'r') as f:
        a = from_npz(f)
    return a
%time (save_and_load_again(da) == da).all()
CPU times: user 12.6 ms, sys: 0 ns, total: 12.6 ms
Wall time: 26.2 ms
Out[42]:
<xray.DataArray ()>
array(True, dtype=bool)

This is a pretty reasonable way to save data, but my only concern is that it's not clear to me that we need another file format when netCDF already solves this problem, in a completely portable way. Have you tried using xarray's netCDF IO?

I hadn't, for a number of reasons. First, I've used csv, hdf, sql, json, yaml and other formats but never across netcdf until using this library as someone who isn't working in the physical sciences. Second, the documentation on netcdf is fairly dense. Third, didn't want to deal with installing the library.
I just did use it and seems like it is great for Datasets. As far as I can tell there is no way to save DataArrays directly, though?
Finally, would note that pandas has io methods for csv, excel, hdf, sql, json, msgpack, html, gbq, stata, "clipboard", and pickle. I think it's a strength to offer more choices.

I hadn't, for a number of reasons. First, I've used csv, hdf, sql, json, yaml and other formats but never came across netcdf until using this library as someone who isn't working in the physical sciences. Second, the documentation on netcdf is fairly dense. Third, didn't want to deal with installing the library.

OK, these are all fair points. Though you probably already have SciPy installed, which is enough for basic netCDF support.

I just did use it and seems like it is great for Datasets. As far as I can tell there is no way to save DataArrays directly, though?

This is true. But converting a DataArray to a Dataset is quite simple: arr.to_dataset(name='foo'), so I'm not sure it's worth adding.

Finally, would note that pandas has io methods for csv, excel, hdf, sql, json, msgpack, html, gbq, stata, "clipboard", and pickle. I think it's a strength to offer more choices.

Yes, choice is good -- but also note that none of those are invented file formats for pandas! I am slightly wary of going down this path, because at the point at which you have a file format that can faithfully represent every xarray object, you have basically reinvented netCDF :).
That said, something like JSON is generally useful enough (with a different niche than netCDF) that it could make sense to add IO support.

hey,
So - after using netcdf for a few days, definitely not looking back. This is great. By way of background, I am building a way to integrate storage of arbitrary arrays into an otherwise highly-structured schema. After using postgresql arrays flamed out (too slow, even at the raw SQL level), I moved on to saving the file path in my schema. I thought it would be sensible to keep everything in pure ndarray for simplicity. After trying out netcdf, I bit the bullet and wrote constructors for numpy, pandas and xarray types, and it's working great.
Looking back, I actually think the documentation could use some work to help people like me, who haven't used netcdf, realize it's great.
If you look at the docs, it starts with pickle, which for me is kind of a red flag since from my experience pickle is the world's most flaky persistence method (always has dependency issues). Then at netcdf you start with:
"Currently, the only disk based serialization format that xarray directly supports is netCDF."
I read this and think, ok so the IO is not really there yet. It's like an apology there aren't more choices.
"netCDF is a file format for fully self-described datasets that is widely used in the geosciences and supported on almost all platforms."
Hmm...geosciences...who knows what those people are doing? I'm also generally suspicious of academics when it comes to code.
"We use netCDF because xarray was based on the netCDF data model, so netCDF files on disk directly correspond to Dataset objects."
Ok, so it's easy for you. What about me?
I've been a bit over the top but you can see how someone who doesn't use netcdf might read this and think they need to write their own IO functions.
If it were me, I would start off selling how great this format is for xarray. Like, "netcdf is a blazing-fast, binary data format that allows transparent, self-describing persistence with zero of the dependency issues you get with pickle or other formats. It allows xarray Datasets to be saved intact and even used in out-of-core computations for larger-than-memory arrays."
Or something like that.
Finally, regarding DataArray not having it's own method to save: I think this is a deficiency that is easily solved. For me, getting into this library I started with just DataArrays. Now that I am using Datasets I can see how they are pretty dang powerful. But at first the simpler DataArrays were all I was using, and they had no direct IO.
To solve this, you could create a "magic" string for DataArrays. On save, to_netcdf converts the da to a Dataset with the magic key. On load, the load function recognizes the magic string and breaks out that DataArray to return it specifically.
I think that would be a quick, relatively painless way to give DataArrays equal footing with Datasets.
Anyway - my two cents. I am a huge fan of this library and happy to chip in regarding any of the above if desired. Thanks for your hard work on it.

Hi @jonathanstrong,
Just thought it would be useful to point out that the people who maintain NetCDF is Unidata, a branch of the University Corporation for Atmospheric Research. In fact, netCDF-4 is essentially built on top of HDF5 - a much more widely-known file format, with first-class support including an I/O layer in pandas. While it would certainly be great to "sell" netCDF as a format in the documentation, those of us who still have to write netCDF-based I/O modules for our Fortran models might have to throw up a little in our mouths when we do so...

@jonathanstrong this is really helpful feedback! You are right to be suspicious of academics when it comes to file formats :) If you have concrete suggestions for doc improvements along these lines, please do put together a PR!
I've thought about the "magic name" approach, too -- my only concern is that it would be weird to get a DataArray back from xarray.open_dataset. But maybe xarray.open is a better name, anyways...

cc @WardF

I'd vote for something format-specific, such as xr.from_netcdf unless open / open_dataset supports other formats...

@jonathanstrong - Thanks for the input.  I agree, we could spice up our IO docs.  Like you, I think it makes sense to play down the pickle serialization method.
@MaximilianR

unless open / open_dataset supports other formats...

It does.  From here:

Formats supported by PyNIO

xarray can also read GRIB, HDF4 and other file formats supported by PyNIO_, if PyNIO is installed. To use PyNIO to read such files, supply engine='pynio' to xarray.open_dataset.

@jhamman nice!

Closing this partly via https://github.com/pydata/xarray/pull/1169 and in favor of https://github.com/pydata/xarray/issues/1154


executor: extend USB debug messages

When USB_DEBUG is enabled, syzkaller crashes on unknown USB requests.
This helps to find missing descriptions for particular USB classes.

Codecov Report

Merging #1504 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1504   +/-   ##
======================================
  Coverage    56.2%   56.2%
======================================
  Files         142     142
  Lines       26415   26415
======================================
  Hits        14847   14847
  Misses      10859   10859
  Partials      709     709

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bc7021...a5da845. Read the comment docs.

LGTM


Opening Baubles Inventory Messes With Inventory

So basically when I opened the GUI for adding some more baubles to my new ring slots, it messes up with the inventory and makes the items go everywhere but the extra ring slots don't get messed up at all.
Before:

After:

I do have to say that I've tested this on both Client and Server side and it only seems to mess up on the server side for some reason, there are no problems in singleplayer.
Some details:
Minecraft 1.12.2
Forge <IP_ADDRESS>23
Baubles 1.12-1.5.2

Why was this closed?

I remember it being something on my side sorry. Can't think back to what it was though, I think another mod was interfering with it that allowed for more bauble slots.


GitHub Issue #177: make reading from php://input configurable

In response to feedback from #177 I decided to make reading the raw request body from php://input disabled by default and configurable through include_raw_request_body.
Unfortunately, I don't see any way to overcome PHP < 5.6 limitation of single read from php://input so I combined making it configurable and also saving the content of the stream for later use in $_SERVER['php://input']. This is not perfect, but I don't think we can do anything more for < 5.6 users due to PHP limitations.

Other than the comments this looks good

This LGTM but there is still an issue with the tests taking too long, I'm going to merge this and deal with the test timeouts elsewhere.


Fixes normalization with definitions from registries

interesting, test_validated_schema_cache produces a different amounts of cache_size for different interpreters. though no clear distinction between Python 2 and 3.


GetCurrentBranch Stopped working on issues

This is a major problem
Test on https://github.com/sindresorhus/refined-github/issues/3638 or even this issue.

???
There's no branch on issues.

But the more-dropdown...

Then the more dropdown… stopped working 😉

We should either ensure that more-dropdown doesn’t call the function where it doesn’t make sense, or that the function returns undefined when it doesn’t find the expected URL format

I think https://github.com/sindresorhus/refined-github/blob/d7d700a20befb552f9f64e15504b845dbe04e699/source/github-helpers/get-default-branch.ts can be used if getCurrentBranch() fails (combined with returning undefined if it can not find expected URL?
const reference = getCurrentBranch() || getDefaultBranch();

OR... should it be the other way, getCurrentBranch() returning getDefaultBranch() as a fallback?

getCurrentBranch() returning getDefaultBranch() as a fallback?

☝

I think getCurrentBranch does not make sense outside of code pages, it’s best to make it explicit like in your first example, only where necessary.

On this issue:
$('[type="application/atom+xml"]').href
"https://github.com/sindresorhus/refined-github/commits/master.atom"

So what's the error? It exists and it's already the default branch

$('[type="application/atom+xml"]').href
// Uncaught TypeError: Cannot read property 'href' of null

not for me

$('[type="application/atom+xml"]').href
// Uncaught TypeError: $(...) is null

Me neither (on Firefox)

I think I encountered the same issue that caused https://github.com/sindresorhus/refined-github/issues/2799 (i.e. GitHub doesn't cleanup the links after AJAX navigation)

I think we should send a ticket into github. We really depend on it, (the whole GithubURL will not work). I hope they are not removing it.

This is not a bug. Issues don’t have a branch.
GitHubURL does not depend on it. It works just fine.


delta tree performance test tool found performance drop

Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)
performance gap less than 5%
3. What did you see instead (Required)
uniform workload :
["Write Speed(rows count) data and diff"] [base=381777] ["this time"=327441] ["diff percentage"=-14.23%] ["standard gap"=5.00%]
incremental workload :
["Write Speed(rows count) data and diff"] [base=224131] ["this time"=197334] ["diff percentage"=-11.96%] ["standard gap"=5.00]
performance data record:
http://perf.pingcap.net/d/t8S6iJ_7k/tiflash-dtworkload-performance?orgId=1&from=now-20d&to=now
4. What is your TiFlash version? (Required)
TiFlash Release Version: v6.1.0-nightly
Edition:         Community
Git Commit Hash: 4ad156b924c88233bb7d9da43f2f47d249a16cdb
Git Branch:      heads/refs/tags/v6.1.0-nightly
UTC Build Time:  2022-05-06 10:57:22
Enable Features: jemalloc avx avx512 unwind
Profile:         RELWITHDEBINFO
Raft Proxy Git Commit Hash:   a03434d3758bee4fa335ce87da5f772eebe8f9cc
Git Commit Branch: HEAD
UTC Build Time:    2022-05-06 11:06:05
Rust Version:      rustc 1.60.0-nightly (1e12aef3f 2022-02-13)
Storage Engine:    tiflash
Prometheus Prefix: tiflash_proxy_
Profile:           release

/assign JinheLin

more information:
new performance drop:
log : http://rms.pingcap.net:31714/artifacts/testground/plan-exec-786506-rj9q2/plan-exec-786506-rj9q2-3406653061/main-logs
commit:
https://github.com/pingcap/tiflash/commit/f601de130d9f74141f654c2f63813d0aae1830d4
latest success commit:
https://github.com/pingcap/tiflash/commit/2b2750b7dfd7823be7c33e290492e1f8cffe1a76

According to the metrics, the degradation of performance happened in 2022-05-06 and 2022-05-10 and the performance in 2022-05-08 is normal.
I guess it may be affected by machine jitter. I think we should refer to the test results a few more times.
Note: Due to release testing of TiDB, the machine resources are insufficient these days and the performance testing is suspended since 2022-05-10.


Getting error: no such file or directory when running docker iron/cli image

When I try to run the following command, I'm getting an error from docker saying it can't start the container, with additional "no such file or directory" error that I think is coming from the iron/cli image itself.
docker run --rm  iron/cli --version

Version Info
Windows 10
Docker 1.9.1
Oracle VirtualBox 5.0.11r104393
iron/cli docker image: (latest) 2b76d773706a
My docker VM was created using Kitematic and looks like it has a minimal set of commands. I'm not that familiar with the linux version, but it says "MingGW64".
I noticed in Kitematic the PATH has references to sbin which doesn't exist:

I'm assuming the image is referencing a command that either isn't available in my MinGW64-version of linux or is in another location? Is there a workaround, like maybe modifying the PATH environment variable?

hi @lauraweindorf , thanks for the report. uploaded version 0.0.22 which should fix the issue with iron/cli image

please reopen if issues persist, thanks!

That worked! Thank you for such a quick fix @rdallman :-D