Compile error

lumenle@lumenle-PICO-KBU4:~/aws-sdk-cpp/build$ cmake .. -DBUILD_ONLY="s3;core"
-- Found Git: /usr/bin/git (found version "2.7.4")
-- TARGET_ARCH not specified; inferring host OS to be platform compilation target
-- Building AWS libraries as shared objects
-- Generating linux build config
fatal: 没有发现名称，无法描述任何东西。
-- Building project version: 1.7.63
-- The C compiler identification is GNU 5.4.0
-- The CXX compiler identification is GNU 5.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: /home/lumenle/aws-sdk-cpp/build/.deps
Scanning dependencies of target AwsCCommon
[  4%] Creating directories for 'AwsCCommon'
[  8%] Performing download step (git clone) for 'AwsCCommon'
正克隆到 'AwsCCommon'...
Note: checking out 'f5383755e934745811d777a8e6c6866791b4302e'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:
git checkout -b
HEAD 目前位于 f538375... Disable backtrace log on Android. (#232)
[ 12%] No patch step for 'AwsCCommon'
[ 16%] No update step for 'AwsCCommon'
[ 20%] Performing configure step for 'AwsCCommon'
-- The C compiler identification is GNU 5.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Performing Test AWS_HAVE_GCC_OVERFLOW_MATH_EXTENSIONS
-- Performing Test AWS_HAVE_GCC_OVERFLOW_MATH_EXTENSIONS - Success
-- Performing Test AWS_HAVE_MSVC_MULX
-- Performing Test AWS_HAVE_MSVC_MULX - Failed
-- Performing Test AWS_HAVE_GCC_INLINE_ASM
-- Performing Test AWS_HAVE_GCC_INLINE_ASM - Success
-- Performing Test HAVE_M_AVX2_FLAG
-- Performing Test HAVE_M_AVX2_FLAG - Success
-- Performing Test HAVE_AVX2_INTRINSICS
-- Performing Test HAVE_AVX2_INTRINSICS - Success
-- Performing Test HAVE_MM256_EXTRACT_EPI64
-- Performing Test HAVE_MM256_EXTRACT_EPI64 - Success
-- Performing Test HAVE_MAY_I_USE
-- Performing Test HAVE_MAY_I_USE - Failed
-- Performing Test HAVE_BUILTIN_CPU_SUPPORTS
-- Performing Test HAVE_BUILTIN_CPU_SUPPORTS - Success
-- Performing Test HAVE_MSVC_CPUIDEX
-- Performing Test HAVE_MSVC_CPUIDEX - Failed
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for stdbool.h
-- Looking for stdbool.h - found
-- Performing Test HAS_WGNU
-- Performing Test HAS_WGNU - Failed
-- Performing Test HAVE_SYSCONF
-- Performing Test HAVE_SYSCONF - Success
-- Building SIMD base64 decoder
-- Packaging currently only supported on Fedora.
-- Configuring done
-- Generating done
-- Build files have been written to: /home/lumenle/aws-sdk-cpp/build/.deps/build/src/AwsCCommon-build
[ 25%] Performing build step for 'AwsCCommon'
Scanning dependencies of target aws-c-common
[  1%] Building C object CMakeFiles/aws-c-common.dir/source/array_list.c.o
[  3%] Building C object CMakeFiles/aws-c-common.dir/source/byte_buf.c.o
[  5%] Building C object CMakeFiles/aws-c-common.dir/source/codegen.c.o
[  7%] Building C object CMakeFiles/aws-c-common.dir/source/common.c.o
[  8%] Building C object CMakeFiles/aws-c-common.dir/source/condition_variable.c.o
[ 10%] Building C object CMakeFiles/aws-c-common.dir/source/date_time.c.o
[ 12%] Building C object CMakeFiles/aws-c-common.dir/source/device_random.c.o
[ 14%] Building C object CMakeFiles/aws-c-common.dir/source/encoding.c.o
[ 16%] Building C object CMakeFiles/aws-c-common.dir/source/error.c.o
[ 17%] Building C object CMakeFiles/aws-c-common.dir/source/hash_table.c.o
[ 19%] Building C object CMakeFiles/aws-c-common.dir/source/lru_cache.c.o
[ 21%] Building C object CMakeFiles/aws-c-common.dir/source/priority_queue.c.o
[ 23%] Building C object CMakeFiles/aws-c-common.dir/source/string.c.o
[ 25%] Building C object CMakeFiles/aws-c-common.dir/source/task_scheduler.c.o
[ 26%] Building C object CMakeFiles/aws-c-common.dir/source/uuid.c.o
[ 28%] Building C object CMakeFiles/aws-c-common.dir/source/posix/clock.c.o
[ 30%] Building C object CMakeFiles/aws-c-common.dir/source/posix/condition_variable.c.o
[ 32%] Building C object CMakeFiles/aws-c-common.dir/source/posix/device_random.c.o
[ 33%] Building C object CMakeFiles/aws-c-common.dir/source/posix/mutex.c.o
[ 35%] Building C object CMakeFiles/aws-c-common.dir/source/posix/rw_lock.c.o
[ 37%] Building C object CMakeFiles/aws-c-common.dir/source/posix/system_info.c.o
[ 39%] Building C object CMakeFiles/aws-c-common.dir/source/posix/thread.c.o
[ 41%] Building C object CMakeFiles/aws-c-common.dir/source/posix/time.c.o
[ 42%] Building C object CMakeFiles/aws-c-common.dir/source/arch/cpuid.c.o
[ 44%] Building C object CMakeFiles/aws-c-common.dir/source/arch/encoding_avx2.c.o
[ 46%] Linking C shared library libaws-c-common.so
[ 46%] Built target aws-c-common
Scanning dependencies of target aws-c-common-assert-tests
[ 48%] Building C object tests/CMakeFiles/aws-c-common-assert-tests.dir/assert_test.c.o
[ 50%] Linking C executable /home/lumenle/aws-sdk-cpp/build/bin/aws-c-common-assert-tests
[ 50%] Built target aws-c-common-assert-tests
Scanning dependencies of target aws-c-common-tests
[ 51%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/test_runner.c.o
[ 53%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/array_list_test.c.o
[ 55%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/atomics_test.c.o
[ 57%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/byte_buf_test.c.o
[ 58%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/byte_order_test.c.o
[ 60%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/clock_test.c.o
[ 62%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/condition_variable_test.c.o
[ 64%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/cursor_test.c.o
[ 66%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/date_time_test.c.o
[ 67%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/device_random_test.c.o
[ 69%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/encoding_test.c.o
[ 71%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/error_test.c.o
[ 73%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/hash_table_test.c.o
[ 75%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/linked_list_test.c.o
[ 76%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/lru_cache_test.c.o
[ 78%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/math_test.c.o
[ 80%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/mutex_test.c.o
[ 82%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/priority_queue_test.c.o
[ 83%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/realloc_test.c.o
[ 85%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/rw_lock_test.c.o
[ 87%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/secure_zero_test.c.o
[ 89%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/split_test.c.o
[ 91%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/string_test.c.o
[ 92%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/system_info_tests.c.o
[ 94%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/task_scheduler_test.c.o
[ 96%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/thread_test.c.o
[ 98%] Building C object tests/CMakeFiles/aws-c-common-tests.dir/uuid_test.c.o
[100%] Linking C executable /home/lumenle/aws-sdk-cpp/build/bin/aws-c-common-tests
[100%] Built target aws-c-common-tests
[ 29%] Performing install step for 'AwsCCommon'
[ 46%] Built target aws-c-common
[ 50%] Built target aws-c-common-assert-tests
[100%] Built target aws-c-common-tests
Install the project...
-- Install configuration: "Release"
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/array_list.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/atomics.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/byte_buf.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/byte_order.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/clock.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/common.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/condition_variable.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/date_time.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/device_random.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/encoding.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/error.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/exports.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/hash_table.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/linked_list.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/lru_cache.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/math.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/mutex.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/priority_queue.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/rw_lock.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/string.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/system_info.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/task_scheduler.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/thread.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/time.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/uuid.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/array_list.inl
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/atomics_fallback.inl
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/atomics_gnu.inl
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/atomics_gnu_old.inl
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/atomics_msvc.inl
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/math.fallback.inl
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/math.gcc_overflow.inl
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/math.gcc_x64_asm.inl
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/math.msvc.inl
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/config.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/common/posix/common.inl
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/testing/aws_test_harness.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/lib/libaws-c-common.so.1.0.0
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/lib/libaws-c-common.so.0unstable
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/lib/libaws-c-common.so
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/lib/aws-c-common/cmake/aws-c-common-targets.cmake
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/lib/aws-c-common/cmake/aws-c-common-targets-release.cmake
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/lib/aws-c-common/cmake/aws-c-common-config.cmake
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/lib/cmake/AwsCFlags.cmake
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/lib/cmake/AwsSharedLibSetup.cmake
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/lib/cmake/AwsTestHarness.cmake
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/lib/cmake/AwsLibFuzzer.cmake
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/lib/cmake/AwsSanitizers.cmake
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/lib/cmake/AwsSIMD.cmake
[ 33%] Completed 'AwsCCommon'
[ 33%] Built target AwsCCommon
Scanning dependencies of target AwsChecksums
[ 37%] Creating directories for 'AwsChecksums'
[ 41%] Performing download step (git clone) for 'AwsChecksums'
正克隆到 'AwsChecksums'...
Note: checking out 'v0.1.2'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:
git checkout -b
HEAD 目前位于 78be31b... Install DLLs to the bin directory on windows (#15)
[ 45%] No patch step for 'AwsChecksums'
[ 50%] No update step for 'AwsChecksums'
[ 54%] Performing configure step for 'AwsChecksums'
-- The C compiler identification is GNU 5.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: /home/lumenle/aws-sdk-cpp/build/.deps/build/src/AwsChecksums-build
[ 58%] Performing build step for 'AwsChecksums'
Scanning dependencies of target aws-checksums
[  9%] Building C object CMakeFiles/aws-checksums.dir/source/cpuid_generic.c.o
[ 18%] Building C object CMakeFiles/aws-checksums.dir/source/crc.c.o
[ 27%] Building C object CMakeFiles/aws-checksums.dir/source/crc_jni.c.o
[ 36%] Building C object CMakeFiles/aws-checksums.dir/source/crc_sw.c.o
[ 45%] Building C object CMakeFiles/aws-checksums.dir/source/intel/cpuid.c.o
[ 54%] Building C object CMakeFiles/aws-checksums.dir/source/intel/crc32c_sse42_asm.c.o
[ 63%] Building C object CMakeFiles/aws-checksums.dir/source/arm/cpuid_arm.c.o
[ 72%] Linking C shared library libaws-checksums.so
[ 72%] Built target aws-checksums
Scanning dependencies of target aws-checksums-tests
[ 81%] Building C object CMakeFiles/aws-checksums-tests.dir/tests/crc_test.c.o
[ 90%] Building C object CMakeFiles/aws-checksums-tests.dir/tests/run_tests.c.o
[100%] Linking C executable /home/lumenle/aws-sdk-cpp/build/bin/aws-checksums-tests
[100%] Built target aws-checksums-tests
[ 62%] Performing install step for 'AwsChecksums'
[ 72%] Built target aws-checksums
[100%] Built target aws-checksums-tests
Install the project...
-- Install configuration: "Release"
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/checksums/crc.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/checksums/crc_jni.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/include/aws/checksums/exports.h
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/lib/libaws-checksums.so
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/lib/aws-checksums/cmake/aws-checksums-targets.cmake
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/lib/aws-checksums/cmake/aws-checksums-targets-release.cmake
-- Installing: /home/lumenle/aws-sdk-cpp/build/.deps/install/lib/aws-checksums/cmake/aws-checksums-config.cmake
[ 66%] Completed 'AwsChecksums'
[ 66%] Built target AwsChecksums
Scanning dependencies of target AwsCEventStream
[ 70%] Creating directories for 'AwsCEventStream'
[ 75%] Performing download step (git clone) for 'AwsCEventStream'
正克隆到 'AwsCEventStream'...
已经位于 'master'
您的分支与上游分支 'origin/master' 一致。
[ 79%] No patch step for 'AwsCEventStream'
[ 83%] No update step for 'AwsCEventStream'
[ 87%] Performing configure step for 'AwsCEventStream'
-- The C compiler identification is GNU 5.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
CMake Error at CMakeLists.txt:30 (include):
include could not find load file:
AwsFindPackage

-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for stdbool.h
-- Looking for stdbool.h - found
-- Performing Test HAS_WGNU
-- Performing Test HAS_WGNU - Failed
-- Performing Test HAVE_SYSCONF
-- Performing Test HAVE_SYSCONF - Success
CMake Error at CMakeLists.txt:77 (aws_use_package):
Unknown CMake command "aws_use_package".
-- Configuring incomplete, errors occurred!
See also "/home/lumenle/aws-sdk-cpp/build/.deps/build/src/AwsCEventStream-build/CMakeFiles/CMakeOutput.log".
See also "/home/lumenle/aws-sdk-cpp/build/.deps/build/src/AwsCEventStream-build/CMakeFiles/CMakeError.log".
CMakeFiles/AwsCEventStream.dir/build.make:106: recipe for target 'build/src/AwsCEventStream-stamp/AwsCEventStream-configure' failed
make[2]: *** [build/src/AwsCEventStream-stamp/AwsCEventStream-configure] Error 1
CMakeFiles/Makefile2:105: recipe for target 'CMakeFiles/AwsCEventStream.dir/all' failed
make[1]: *** [CMakeFiles/AwsCEventStream.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2
CMake Error at CMakeLists.txt:180 (message):
Failed to build third-party libraries.
-- Configuring incomplete, errors occurred!

Hi @lml0001 ,
can you try running the cmake command like this:
cmake .. -DBUILD_ONLY="s3" -DBUILD_SHARED_LIBS=ON

Hi @lml0001 ,
can you try running the cmake command like this:
sudo cmake .. -DBUILD_ONLY="s3" -DBUILD_SHARED_LIBS=ON

i try this way,  but the same error occurred

I haven't been able to reproduce this error...
I can't really think on what could be causing it and I'd be shooting in the dark here to know what was going on... I think the best thing I can suggest is for you to try with the latest version of the sdk.
Another thing you could try is installing the dependencies separately following this instructions. That might give us some more info on where the error is coming from at least.

I haven't been able to reproduce this error...
I can't really think on what could be causing it and I'd be shooting in the dark here to know what was going on... I think the best thing I can suggest is for you to try with the latest version of the sdk.
Another thing you could try is installing the dependencies separately following this instructions. That might give us some more info on where the error is coming from at least.

maybe I because use the 1.7.319 version of the aws-sdk-cpp，

mmm maybe, have you tried newer versions?
Also, make sure that you meet the minimum requirements for the sdk.

mmm maybe, have you tried newer versions?
Also, make sure that you meet the minimum requirements for the sdk.

but i have to use this version ,because my team  are using this version

@lml0001 ,
Sorry but can you walk me through exactly how you tried to build the sdk?
Also, what cmake version are you using?  And if you follow these instructions what error do you get when building the dependencies? Is it the same? which one fails?


Android Compose Add a Scrollable List

L
Downloading the Project and importing it to Android Studio either results in an error (ClassDefFoundError: org/gradle/internal/impldep/com/google/common/collect/Lists) and/or "Add Configuration..." being written where normally "App" would be (next to where the emulator can be chosen).
In which lesson and step of the codelab can this issue be found?
1 + 6.
How to reproduce?
Just download and import the project (:
Versions

What version of Android Studio are you using? Android Studio Dolphin | 2021.3.1 Patch 1
What API level are you targeting? Pixel 5 API 31

Additional information
Add any other context about the problem here.
Thanks for helping!
codelab: basic-android-compose

-training-add-scrollable-list

Hi @KuhliusMuh
Thank you for writing in with your issue.
I would suggest downloading and installing the latest stable version of Android Studio and trying again.
I downloaded the code and used "Android Studio Flamingo | 2022.2.1 Patch 2" with an emulator "Pixel 5 API 31" without any issues.
If you try that and still have an issue, please create a new issue so we can troubleshoot further.
Hope you are enjoying the course!
Regards.


fix: nonzero exit code on :wq

fixes #173
fixes #181
Hack to work around https://github.com/neovim/neovim/issues/21856

Reworked to use a different workaround suggested by @debugloop in #173. That approach seems to fix #181 as well, so it's preferable.


docs(doc/code-docs): support zh cn readthedocs

Motivation
Update readthedocs to use Chinese as the main language and English as the translation language.
Modification
doc/code-docs: update Chinese source file and add English as the translation language in locales.
Checklist
Before PR:

[x] Pre-commit or other linting tools are used to fix the potential lint issues.

LGTM


Update to provide new url helper functions file and us only onboarding.

What's this PR do?
This PR provides a new url/helpers.js file which contains a useful getPathnameSegments() function to grab a specified segment from a provided path (or defaults to window.location.pathname). Setup as a helper file so it can be used easily in other components!
This allows us to make sure we only show the Onboarding feature to users in the US.
How should this be reviewed?
👀  Can test by seeing if you see onboarding while coming from US and not see it if coming from outside the US.
Relevant tickets
Fixes #6860
Checklist

[ ] Tested on staging.

@DFurnes @deadlybutter

I feel like relying on the URL path seems a little fragile. Could we store this in the Drupal.settings object perhaps?

Hmmm, well yeah. Also turns out Drupal.settings.pathPrefix is already set in there<EMAIL_ADDRESS>Will switch to using that and just leave the URL helper.js in case it's useful @DFurnes

👍


AoT regression: multi-apps feature breaks ng2-bootstrap AoT compilation

I'm submitting a ...  (check one with "x")
[X] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see use [gitter](https://gitter.im/mgechev/angular2-seed) or [stackoverflow](https://stackoverflow.com/questions/tagged/angular2)

Current behavior
AoT build crashes during running of build.bundles.app.exp
[13:34:39] 'build.bundles.app.exp' errored after 1.17 s
[13:34:39] Error on fetch for dist/tmp/node_modules/ng2-bootstrap/components/modal/modal-backdrop.component.ngfactory.js at file:///var/www/sites_CLIENT_ri/node_modules/dist/tmp/node_modules/ng2-bootstrap/components/modal/modal-backdrop.component.ngfactory.js
	Loading dist/tmp/app/app.module.ngfactory.js
	Loading dist/tmp/app/main-prod.js
	Error: ENOENT: no such file or directory, open '/var/www/sites_CLIENT_ri/node_modules/dist/tmp/node_modules/ng2-bootstrap/components/modal/modal-backdrop.component.ngfactory.js'
    at Error (native)
[13:34:39] 'build.prod.exp' errored after 44 s
[13:34:39] Error in plugin 'run-sequence(build.bundles.app.exp)'
Message:
    Error on fetch for dist/tmp/node_modules/ng2-bootstrap/components/modal/modal-backdrop.component.ngfactory.js at file:///var/www/sites_CLIENT_ri/node_modules/dist/tmp/node_modules/ng2-bootstrap/components/modal/modal-backdrop.component.ngfactory.js
	Loading dist/tmp/app/app.module.ngfactory.js
	Loading dist/tmp/app/main-prod.js
	ENOENT: no such file or directory, open '/var/www/sites_CLIENT_ri/node_modules/dist/tmp/node_modules/ng2-bootstrap/components/modal/modal-backdrop.component.ngfactory.js'
Details:
    originalErr: Error: ENOENT: no such file or directory, open '/var/www/sites_CLIENT_ri/node_modules/dist/tmp/node_modules/ng2-bootstrap/components/modal/modal-backdrop.component.ngfactory.js'
Stack:
Error on fetch for dist/tmp/node_modules/ng2-bootstrap/components/modal/modal-backdrop.component.ngfactory.js at file:///var/www/sites_CLIENT_ri/node_modules/dist/tmp/node_modules/ng2-bootstrap/components/modal/modal-backdrop.component.ngfactory.js
	Loading dist/tmp/app/app.module.ngfactory.js
	Loading dist/tmp/app/main-prod.js
	Error: ENOENT: no such file or directory, open '/var/www/sites_CLIENT_ri/node_modules/dist/tmp/node_modules/ng2-bootstrap/components/modal/modal-backdrop.component.ngfactory.js'
    at Error (native)

Expected behavior
ng2-bootstrap AoT should successfully build AoT bundle
Minimal reproduction of the problem with instructions

Clone angular-seed repo
Add install and add ng2-bootstrap in project.config.js like

    this.addPackageBundles({
        name:'ng2-bootstrap',
        path:'node_modules/ng2-bootstrap/bundles/ng2-bootstrap.umd.js',
        packageMeta:{
            main: 'bundles/ng2-bootstrap.umd.js',
            defaultExtension: 'js'
        }
    });

npm run build.prod.exp

What is the motivation / use case for changing the behavior?
Even if it seems like ng2-bootstrap bug, it's not because old version works fine.
This commit https://github.com/mgechev/angular-seed/commit/eb2a2aa59fcc5a7e7358648e4fccaab7abb3e94d
breaks compile.ahead.prod.ts for ng2-bootstrap module.
When I rollback file, it AoT compilation works without a problem.
Please tell us about your environment:
Fedora 19

Angular Seed Version: 2.0.X
15bc65545aa0c1e2d5e0d84be3430efb28c49e0d

Node: node --version = 6.9.1

Seems related to https://github.com/mgechev/angular-seed/issues/1523

In my case it works fine with Angular 2.1.1 on Fedora Linux, the problem is in task script itself.

@irsick to me it seems related because of this path that the bundler is trying to follow:
file:///var/www/sites_CLIENT_ri/node_modules/dist/tmp/node_modules/ng2-bootstrap/components/modal/modal-backdrop.component.ngfactory.js

Same as in #1523.

@irsick the issue was caused by a bugfix in the Angular compiler. Now everything should work fine. Take a look at the fix here.

@mgechev I confirm, it works. Thanks!


Cannot send remote and local files

I cannot send both remote and local files
here's my code
            await self.send_local_files(['/home/jvfiel/project/brooky-controller/images/apr_map.jpg'],
                                             message=Message(text=text, mentions=mentions),
                                             thread_id=thread_id,
                                             thread_type=thread_type)

I tried  checking the package and I notice that it stocks on this part
upload_file = await self._state._upload(files, voice_clip=voice_clip)
on this function
async def _upload(self, files, voice_clip=False):
    print("uploading files....")
    # print(str(files[0])[1:10])
    print(files)
    upload_file = await self._state._upload(files, voice_clip=voice_clip)
    print(upload_file)
    return upload_file

any ideas? @tulir

I don't actually use those methods (I needed more control over the parameters) so it's possible something is broken. I just fixed a few bugs related to that (missing params and awaits), so maybe try again with 0.3.0rc3

I still can't get {{_sendFiles}} to work with 0.3.0.

@jvfiel How do I enable logging for the project to see what may go wrong here?


Add John Earl to contributors list

@jearl4, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?


Update TravisCI config for PHP7.4

Include 7.4 in builds.
Cache vendor directory for hopefully faster builds.

Fixes #2293

Looks like GD isn’t available? Is that a new default in 7.4? or maybe a Travis issue?

Looks like TravisCI had some updates for PHP extension issues. It's unclear if this PR precedes those? https://travis-ci.community/t/some-extensions-are-missing-in-php-7-4-0-zip-gmp-sodium/6320/8
Maybe try bumping this PR to see if the build succeeds this time?

@lonnieezell @MGatner I replicated your code with some fixes for PHP 7.4
Can you please have a look on my PR:
https://github.com/codeigniter4/CodeIgniter4/pull/2537

It looks good to me! Simple, working. All 7.4 tests passed too. I’ll let Lonnie make the final call since he worked on this one but I approve.

@lonnieezell i think now you can close this PR.

Ah, yeah. Thanks!


Transfer repo to bcit-ci

I am now a collaborator :)
If you grant me admin rights to the repo, I can do the transfer.
For composer:

we will need to update composer.json to reflect the new repo location
we may need to change the listing on packagist.org or add a new entry "codeigniter4/standard"

If you grant me admin rights to the repo, I can do the transfer.

Do you know where I set this I cant find it?

In settings > collaborators
You should see my name, with a combobox beside it with the rights I have for the repo.

I think that may be only be a Paid account option only, There's no dropdown next to your name. I do see one on collaborators for my company projects though.
I think I might have to use the transfer option in settings > danger zone
https://help.github.com/articles/about-repository-transfers/

So I think I should transfer to "bcit-ci"

agreed

Did you get an email?
After confirming I got this notification.

I didn't get notified. It looks like it is a bit more complicated than anticipated.
I have invited you to be a member of "bcit-ci".
Might have to tweak your settings within the org, but that will have to wait until later today ... it is final exam week, and I am off to inflict punishment :-/
Thanks,
Jim

From: louisl<EMAIL_ADDRESS>Sent: Monday, December 11, 2017 11:00 AM
To: louisl/CodeIgniter4-Standard
Cc: James Parry; Author
Subject: Re: [louisl/CodeIgniter4-Standard] Transfer repo to bcit-ci (#16)
Did you get an email?
After confirming I got this notification.
[screenshot 2017-12-11 18 58 37]https://user-images.githubusercontent.com/1140394/33848412-8ffee852-dea5-11e7-8f23-1da63a3e8821.png

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/louisl/CodeIgniter4-Standard/issues/16#issuecomment-350823038, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADDjb5aDwKC3k6zmKr0QntYqWdk3LU6Uks5s_XvhgaJpZM4Q9sdJ.

OK, I accepted the invite, tried again and .got the same error. I'll contact Github support

I just gave you admin access, but that is for the entire organization. I will fix that to maintainer rights on your repo once transferred.

From: louisl<EMAIL_ADDRESS>Sent: Monday, December 11, 2017 11:26 AM
To: louisl/CodeIgniter4-Standard
Cc: James Parry; Author
Subject: Re: [louisl/CodeIgniter4-Standard] Transfer repo to bcit-ci (#16)
OK, I accepted the invite, tried again and .got the same error. I'll contact Github support

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/louisl/CodeIgniter4-Standard/issues/16#issuecomment-350830564, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADDjb9ptg9sLcmXr9OIkpn-LfvvkBXyGks5s_YHogaJpZM4Q9sdJ.

Thanks, it's transferred :-)

Yay! I have made you an admin on the repo (as well as Lonnie), and just a "member" of bcit-ci.
I will announce this on the forum, but later this afternoon!
Thank you!!

Thanks @jim-parry, Hold off on the announcement for a little while I'm going to get the readme links, composer.json, travis job and packagist updated.

@jim-parry,
OK, just need to sort out packagist now, I think I add you as a maintainer then you can set up a package with the right namespace. Should I add "bcit-ci" for packagist? because I know there's a few different codeIgniter ones?

Our relevant "vendor" name is "codeigniter4".

From: louisl<EMAIL_ADDRESS>Sent: Monday, December 11, 2017 2:01 PM
To: bcit-ci/CodeIgniter4-Standard
Cc: James Parry; Mention
Subject: Re: [bcit-ci/CodeIgniter4-Standard] Transfer repo to bcit-ci (#16)
@jim-parryhttps://github.com/jim-parry,
OK, just need to sort out packagist now, I think I add you as a maintainer then you can set up a package with the right namespace. Should I add "bcit-ci" for packagist? because I know there's a few different codeIgniter ones?

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/bcit-ci/CodeIgniter4-Standard/issues/16#issuecomment-350872701, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADDjbyDhnOUzQpbcrps_ijYHJJZY8L7hks5s_aY5gaJpZM4Q9sdJ.

Ok it's all ready to go with release 1.0.1.
It seems you will need to add it in packagist to the codeigniter4 account then I abandon mine with a reference to the new one.
https://github.com/composer/packagist/issues/47

aaaaaaand, we are up & running. See
https://forum.codeigniter.com/thread-69545.html

From: louisl<EMAIL_ADDRESS>Sent: Tuesday, December 12, 2017 12:56 AM
To: bcit-ci/CodeIgniter4-Standard
Cc: James Parry; Mention
Subject: Re: [bcit-ci/CodeIgniter4-Standard] Transfer repo to bcit-ci (#16)
Ok it's all ready to go with release 1.0.1.
It seems you will need to add it in packagist to the codeigniter4 account then I abandon mine with a reference to the new one.
composer/packagist#47https://github.com/composer/packagist/issues/47

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/bcit-ci/CodeIgniter4-Standard/issues/16#issuecomment-350986368, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADDjb0zpPxr4su-w2PMG0Qr-JXJAWiJAks5s_j-ngaJpZM4Q9sdJ.

Nice one!, I've abandoned my version so anyone trying to install from louisl gets the message.
Let the mayhem begin!

Oh by the way, do you want me to look at getting Travis CI build for CodeIgniter4 checking against the standard?

This one works.
https://github.com/louisl/CodeIgniter4/blob/feature/travis-codesniffer/.travis.yml
Flags up a ton of stuff at the moment.
https://travis-ci.org/louisl/CodeIgniter4/jobs/315321638

Adding this to our travis-ci build would be handy, for sure :)

But only after we get a chance to go through the files and clean up what we've got first :)

Yeah I agree, probably best have a tidy up first using it.
It will fix in with the beautifier eg.
./vendor/bin/phpcbf ./system --standard=./vendor/codeigniter4/codeigniter4-standard/CodeIgniter4/ruleset.xml


a bug in 0.0.48 can't shutdown

on 0.0.48, on jupyter notebook -> kernel-> 'shutdown kernel' button after pressed, nothing happen to the pods . but on 0.0.47 and below no issue.  can help to check. I think is a bug

Hello, thangs for reporting. The problem is caused due to changes on Kubernetes client library, that we are using.
We are trying to fix it, in the meantime you can switch back to 0.0.47

Workaround for the problem:
Add this env variable to the lighter deployment:
...
    spec:
      containers:
      - env:
        - name: KUBERNETES_TLS_VERSIONS
          value: TLSv1.2
...

We'll release an updated version with this value as default


bug after sending e-mail from cloud functions

Process exited with code 16 at process.on.code (/layers/google.nodejs.functions-framework/functions-framework/node_modules/@google-cloud/functions-framework/build/src/invoker.js:275:22) at process.emit (events.js:198:13) at process.EventEmitter.emit (domain.js:448:20) at process.exit (internal/process/per_thread.js:168:15) at Object.sendCrashResponse (/layers/google.nodejs.functions-framework/functions-framework/node_modules/@google-cloud/functions-framework/build/src/logger.js:37:9) at process.on.err (/layers/google.nodejs.functions-framework/functions-framework/node_modules/@google-cloud/functions-framework/build/src/invoker.js:271:22) at process.emit (events.js:198:13) at process.EventEmitter.emit (domain.js:448:20) at emitPromiseRejectionWarnings (internal/process/promises.js:140:18) at process._tickCallback (internal/process/next_tick.js:69:34)
more_vert

Here is my cloud function code:
exports.sendCustomEmailVerification = functions.https.onCall((userData) => {
  let emailsList = userData.emails
  let promises = []
  emailsList.forEach((email) => {
    let msg = {
      personalizations: [{
        to: email,
        subject: 'Eventos esportivos IMPRESSIONANTES'
      }],
      from: {
        email<EMAIL_ADDRESS>        name: 'Kmais clube de vantagens'
      },
      reply_to: {
        email<EMAIL_ADDRESS>        name: 'Kmais clube de vantagens'
      },
      template_id: 'd-50e2370999f742709686efce8fb742a9'
    }
    sgMail.setApiKey('MY_API_KEY)
    promises.push(sgMail.send(msg))
  })
  return Promise.all(promises).then(() => {
    return 'deu certo'
  })

emailsList is in the following format: [ [ { email<EMAIL_ADDRESS>}, { email<EMAIL_ADDRESS>} ] ], so "to: email" is an array with 1000 emails. in the [ {} ] format.
should work. If i change 'email' to a fixed array, it works.

Hi @eeerrrttty,
Thanks for reporting the issue. However, I could not reproduce locally. Which version of the library are you on? Is this issue new for this version? Have you tried reproducing this on an older version of the library?
Thanks,
Shwetha

Hi @eeerrrttty,
Thanks for reporting the issue. However, I could not reproduce locally. Which version of the library are you on? Is this issue new for this version? Have you tried reproducing this on an older version of the library?
Thanks,
Shwetha

Try:
emailsList.forEach((item) => {
let msg = {
personalizations: [{
to: **item.**email,

Hello @silviokucz,
It looks like your message was truncated, could you please update or resend? Thank you!
With best regards,
Elmer

Hi @thinkingserious ,
I updated the comment, it seems to me that it has a small JavaScript mistake in the emailsList.forEach loop

Thank you @silviokucz!! We appreciate your help!


Girlscript Summer of Code Introduction/Tracking

👋 Hi @MAVRICK-1 ,
I am Sanjay, program Manager Girlscript Summer of Code. I'll be collaborating with you on preparing your repo for GSSoC'24 Program
Why are these changes required?
After Analysing last year's contributions and feedback it would be great for students to have a couple of standard readme files on the repo to understand what the project is all about and some issues detailing what they can contribute. This will help you to see increased engagement in your repository as well.
As mentioned students get a chance to learn step by step, how to build this project as well as invite mentors to collaborate and add features to this repo. I will generate issues, which will provide guidance on how to prepare your repo for Girlscript summer of code 2024 on 10th May.
This issue will serve as a tracking issue to track all issues related to GSSoC'24. I recommend creating a new branch for every issue and opening a pull request to track changes so we can effectively collaborate with each other and merge changes when you and I feel like those changes are ready to be merged on your primary branch.
If you have any questions or concerns, please feel free to leave a comment on this issue or any of the other issues that are generated.
I look forward to working with you :octocat:

[ ] #5
[ ] #4
[ ] #3
[ ] #2
[ ] #1

@sanjay-kv
Hello, this is Rishi Mondal, the project administrator of Codebin. I'd like to make some changes to the project. I want to upgrade it to another project. Could you please help me with this?
Repo link:https://github.com/MAVRICK-1/causewaylogin
I submitted the Codebin project for the MLH Code Snippet, but it hasn't been reviewed by the MLH team yet, so I couldn't add it. It would be very helpful if you could remove or replace the Codebin project with another one.
I already tried to contact Arushi garg but haven't got any reply


Run unittests

This change include many different changes that allows us to run the CPython test using libregtest. After the change you can do:
cargo run --release Lib/test/regrtest.py
== RustPython 3.5.0alpha (heads/run-unittests-dirty:cba70133, Dec 28 2019, 10:23:15) [rustc 1.40.0]
== cwd: /tmp/test_python_19746
== CPU count: 4
== encodings: locale=UTF-8, FS=utf-8
Run tests sequentially
0:00:00 [1/1] test_bool
test_bool passed

== Tests result: SUCCESS ==

1 test OK.

Total duration: 293 ms
Tests result: SUCCESS
<SystemExit object at 0x5571b65f8a10>

This change is based on the change in #1625.

This is sincerely great news!


NIFI-7878 rename onConfigured to onEnabled to make code more clear

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Rename onConfigured to onEnabled
Description of PR
rename onConfigured to onEnabled to make code more clear
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically main)?

[ ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Hi @ofirmgr - thanks for this contribution. Can you please create a JIRA describing the issue/improvement (https://issues.apache.org/jira/browse/NIFI)? And then update the title of this PR to prefix it with the JIRA reference? This helps us keeping track of everything. Thank you.

@pvillard31 do you want me to do that?

sorry for the delay. I just created jira issue and updated the titile


[Bug] Fix broken consensus tests on main branch - mocking StoreBlock in persistence module

Description
Fix a small bug on main introduced by removal of UtilityModule's StoreBlock function.
Issue
No associated issue. This is a quick followup to #254.

Type of change
Please mark the relevant option(s):

[ ] New feature, functionality or library
[x] Bug fix
[ ] Code health or cleanup
[ ] Major breaking change
[ ] Documentation
[ ] Other

List of changes

Fixed broken test on main by mocking the StoreBlock function on the persistence module in a consensus test
Remove the unused StoreBlock function in the utility module

Testing

[x] make develop_test
[ ] LocalNet w/ all of the steps outlined in the README

Required Checklist

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have tested my changes using the available tooling
[x] I have updated the corresponding CHANGELOG

If Applicable Checklist

[ ] I have updated the corresponding README(s); local and/or global
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added, or updated, mermaid.js diagrams in the corresponding README(s)
[ ] I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

Finish PR description before requesting review

@andrewnguyen22

Finish PR description before requesting review

Sounds good. I jumped the 🔫 on this one.

Versioning...

Please note that make develop_test works but there is still an issue with LocalNet we're going to need to fix.

@andrewnguyen22 Patched, updated, pushed, verified & merged.

Also, I just misunderstood what you meant by I realized you asked me to fix actor_test before merging. Oddly enough make develop_test passed for me, so:

Can you submit a PR with those unit test fixes.
I will investigate why make develop_test passes

@Olshansk can't reproduce the issue - seems fine

@andrewnguyen22 Following up here for posterity, fix is in #282


lib: src: simulations: Added Pi Approximation Simulation #54

Added Pi Approximation using Monte Carlo method
Closes #54

Planning to make any more changes?

Planning to make any more changes?

Nope. Anything else required?

Planning to make any more changes?

Nope. Anything else required?

nope


Drive temperature broken

The script somehow breaks synology drive temperature reporting, it gets stuck at 29C constantly, while smartmontools report correct temperature

Do you mean smartctl?
Which Synology model and DSM version?

Do you mean smartctl?

Yes, smartctl -a /dev/block | grep "Temp" shows correct temperature, its also shown correctly in "scrutiny"
Right now I’m patching synodrivedb.db by hand, we'll see if that will help

Which Synology model and DSM version?

SA6400, 7.2.2-72806

syno_hdd_db only edits model.dtb if the script detects a E10M20-T1, M2D20, M2D18 or M2D17 connected to a NAS model that does not officially support them and the E10M20-T1, M2D20, M2D18 or M2D17 is not already in model.dtb.
So the script would not touch model.dtb on a SA6400


Hostname verification failed

aws-msk-iam-sasl-signer-python version: 1.0.0
Python version: 3.11
Operating System: MacOS
Method of installation: pip3
Kafka library name: confluent-kafka-python
Kafka library version: 2.3.0
Provide us a sample code snippet of your producer/consumer

Producer configuration:
def get_outh(config_str):
    try:
        token, expiration_time = MSKAuthTokenProvider.generate_auth_token('us-east1')
        return token, expiration_time/1000
    except Exception as e:
        print(e)
        raise

producer = Producer(
            {
                'bootstrap.servers': brokers, # AWS MSK kafka isntance using port 9098
                'security.protocol': 'sasl_ssl',
                'logger': logger,
                'debug': 'broker,security',
                'sasl.mechanism': 'OAUTHBEARER',
                'oauth_cb': get_outh,
                'ssl.endpoint.identification.algorithm': 'none',
                'enable.ssl.certificate.verification': 'false'
            },
        )

Description
When trying to instantiate this producer and send a message I get a 'Hostname verification failed' error.
I tried disabling all SSL endpoint verification but it doesn't seem to affect the outcome.
What I Did
Log of the underlying librdkafka implementation
CONNECT [Stefans-MacBook-Pro.local#producer-1] [thrd:sasl_ssl://b-2.demodataplatformmskse.paysss.c14.kafka.us-east-1]: sasl_ssl://b-2.demodataplatformmskse.paysss.c14.kafka.us-east-1.amazonaws.com:9098/bootstrap: broker in state TRY_CONNECT connecting
STATE [Stefans-MacBook-Pro.local#producer-1] [thrd:sasl_ssl://b-2.demodataplatformmskse.paysss.c14.kafka.us-east-1]: sasl_ssl://b-2.demodataplatformmskse.paysss.c14.kafka.us-east-1.amazonaws.com:9098/bootstrap: Broker changed state TRY_CONNECT -> CONNECT
CONNECT [Stefans-MacBook-Pro.local#producer-1] [thrd:sasl_ssl://b-2.demodataplatformmskse.paysss.c14.kafka.us-east-1]: sasl_ssl://b-2.demodataplatformmskse.paysss.c14.kafka.us-east-1.amazonaws.com:9098/bootstrap: Connecting to ipv4#<IP_ADDRESS>:9098 (sasl_ssl) with socket 15
FAIL [Stefans-MacBook-Pro.local#producer-1] [thrd:sasl_ssl://b-1.demodataplatformmskse.paysss.c14.kafka.us-east-1]: sasl_ssl://b-1.demodataplatformmskse.paysss.c14.kafka.us-east-1.amazonaws.com:9098/bootstrap: SASL authentication error: [e15f74a3-a70d-44d8-9971-1a78c58919e3]: Hostname verification failed (after 440ms in state AUTH_REQ) (_AUTHENTICATION)
FAIL [Stefans-MacBook-Pro.local#producer-1] [thrd:sasl_ssl://b-1.demodataplatformmskse.paysss.c14.kafka.us-east-1]: sasl_ssl://b-1.demodataplatformmskse.paysss.c14.kafka.us-east-1.amazonaws.com:9098/bootstrap: SASL authentication error: [e15f74a3-a70d-44d8-9971-1a78c58919e3]: Hostname verification failed (after 440ms in state AUTH_REQ)

Have you made sure that the region used in generating the token is same as the region of the cluster?


Improve search for languages with accents

Description
Currently if a word is written with accents in Transifex, the user must include the accents to find it.
I know I could just add a synonym without accents, but that’s redundant. There are probably hundreds of missing synonyms like that.
The word should be written only once with the correct accents, and the search function should ignore them.
Screenshots
example with French (fr):

Diacritic-insensitive search was implemented in #8242. You may manually provide diacritic-folded synonyms, as I’ve continued to do in Vietnamese. However, the results you’re seeing have a different cause: the word “pétanque” is such a small part of the overall preset name “Terrain de boules (Pétanque, Bocce…)” that other, shorter presets have a much shorter edit distance. If you search for “boules petanque” or even “petanque b”, this preset appears on top.
iD doesn’t expect a preset name to contain a gloss with a list of synonyms. The synonym string in your screenshot should also contain “pétanque” in the list, since iD boosts exact matches. Also note the instructions for the “Boules/Bocce Court” string:

Translate the primary name. Optionally, add equivalent synonyms on newlines in order of preference (press the Return key).

So you can also add “Pétanque” and “Bocce” on a separate lines in the same string to ensure that iD will find and prioritize these search terms. #6139 remains open for labeling the preset with the matching synonym instead of the main preset name.

Okay, thanks for the explanation.
I don’t want to add diacritic-folded synonyms as they’re pointless in French (I’d even like to remove them all, is that a good idea?)
I didn’t write the current translation with synonyms in parentheses, but I think it’s quite useful for the user. Can I leave them and write it like this:?
Terrain de boules (Pétanque, Bocce...)
Terrain de Pétanque
Terrain de Bocce

and remove "Terrain de" from the synonym string, so only Pétanque, Bocce, Lyonnaise?

I think this will be solved by adding the respective aliases (and/or search terms) in transifex. Let's close this for now and see if that fixes is.

How can I test this now? I updated on transifex and build iD from source but it didn't pull the latest translation.


no such table: security

Startup failure initialising sql. Does not seem to affect execution.
Open PP

Help, Welcome, Open the Kommer sample file,
File, Save As, XML with "ID" attributes, kommer.xml

E:\sqlite>test kommer
-- Loading resources from tmp.txt
Error: near line 1: no such table: security

Microsoft Windows [Version 10.0.22631.3880]
Python 3.12.4
ppxml2db.py 1.0

E:\sqlite>type test.bat
@echo off
if %1!==! goto usage
if exist %1.db del %1.db
if exist tmp.txt del tmp.txt
rem for /f "tokens=*" %%f in (tables.txt) do echo .read %%f.sql >>tmp.txt
for %%f in (*.sql) do echo .read %%~nf.sql >>tmp.txt
sqlite3 -init tmp.txt %1.db .quit
rem del tmp.txt
@echo on
@ver
@python --version
@python ppxml2db.py --version
python ppxml2db.py %1.xml %1.db
python db2ppxml.py %1.db %12.xml
goto end
:usage
@echo off
echo.
echo Usage: %0 filename(without extension)
echo.
:end

E:\sqlite>type tmp.txt
.read account.sql
.read account_attr.sql
.read attribute_type.sql
.read bookmark.sql
.read config_entry.sql
.read config_set.sql
.read dashboard.sql
.read latest_price.sql
.read price.sql
.read pricedata.sql!.sql
.read property.sql
.read security.sql
.read security_attr.sql
.read security_event.sql
.read security_prop.sql
.read taxonomy.sql
.read taxonomy_assignment.sql
.read taxonomy_category.sql
.read taxonomy_data.sql
.read watchlist.sql
.read watchlist_security.sql
.read xact.sql
.read xact_cross_entry.sql
.read xact_unit.sql

Error generated by user file in folder: .read pricedata.sql!.sql.
Direct Windows support would be useful, including a specific list of required sql files (eg tables.txt).

Error generated by user file in folder: .read pricedata.sql!.sql.

Then please close this ticket as invalid (not related to the project itself).
To track files in a project directory (which are changed, which are stray), use the git tool.

Direct Windows support would be useful, including a specific list of required sql files (eg tables.txt).

There won't any special Windows support, this is a generic project. You're welcome to use any of many available POSIX-like layers for Windows, like Cygwin, MSYS, WSL, etc.

A POSIX-like layer to support Windows is an overkill. A trivial change to the following makefile code to use a list of sql files would support a Windows batch file too.
TABLES = .account .account_attr \
    .security .security_attr .security_event .security_prop .latest_price .price \
    .watchlist .watchlist_security \
    .xact .xact_unit .xact_cross_entry \
    .taxonomy .taxonomy_category .taxonomy_assignment .taxonomy_data \
    .dashboard \
    .property \
    .bookmark .attribute_type .config_set .config_entry

I'm closing this as the original reported issue was a user error. If there're other topics worth recording here, please open a separate ticket with clear naming and description.


Namespace and path resolving issues

After installing 2.7.0 I realized that there were many updates including seed command since 2.5.1
The fixes were good but, as I mentioned before, if you're using modules within any subdirectory configuration things are starting to get harder.
I know that scan paths issue were fixed recently but as I realized we're concatenating our seeder names like
return $namespace . '\\' . $name . '\\' . $seederPath . '\\' . $name . 'DatabaseSeeder';

which resolves to Modules\Modulename\src\Database\Seeders\Seeder name which is also invalid.
I didn't want to go with a quick fix so I wondered how we can solve this with a much more simple way instead of fixing it on SeedCommand.php.
As there's no other way than removing 'src/' [that's not a common solution] or find a new way of returning the namespace from all modules in a more generic way instead of an assumption of path string leads to it.
Can anybody please also try to work on some test cases using ./src as their psr-4 autoload and adding src/ as a path prefix on generator config like below on forthcoming versions?
'config' => ['path' => 'src/Config', 'generate' => true],
'command' => ['path' => 'src/Console', 'generate' => true],
'migration' => ['path' => 'src/Database/Migrations', 'generate' => true],
...
...
...

Hello,
Sorry for the late reply here.
I'm not sure what the issue is. If you have an src/ folder, you can just rename the modules folder in the config file to src.

I mean
We were using a custom configuration for generating packages to use as vendor packages later on. So we have a structure like
Modules
| - ModuleName
   | - src
       | -  ...

But we end up with directory issues (like on DatabaseSeeders etc) as the paths were defined as src/... but there were no src's shown under vendor.
We decided to define different namespaces for each module on composer that references src folders and continue with default config file.
So we can mark it as resolved for now.

Having this issue too. I don't want to keep my tests and config stuff in the same directory as my src. But when updating the path the namespaces becomes Module\ModuleName\src\Providers\, but I don't want the src in the namespace.
I think it would make sense to separate the path from the namespace in the config.
Is that possible?
Sorry for hijacking your thread jnbn 😬

Hello @rockymontana ,
This is indeed already possible, there is a namespace key you can set, example.

Perfect! Thanks


Binding Dictionary<int, object> throws FormatException when no data is provided (except RequestVerificationToken)

Describe the bug
Using asp.NET CORE 3.0, when posting a form with no data except __RequestVerificationToken, and binding Dictionary<int, object>, POST returns 500 with an exception "FormatException: Input string was not in a correct format."
To Reproduce
Steps to reproduce the behavior:
Using Asp.NET CORE 3.0 razor pages
Antiforgery is enabled
This is the razor view:
<form method="post">
    <button>Post</button>
</form>

This is the model:
public void OnPost(Dictionary<int, string> dict) {
}

When posting the form, exception ""FormatException: Input string was not in a correct format." is thrown.
Expected behavior
I expect that the bound property would be null (or an empty dictionary).

Thanks for contacting us, @vinklerradomir.
@pranavkm can you please give this a try? Most probably this will be something we will fix in 5.0, unless something really very severe comes out of this.


Error:  Can't retrieve XML file

When the user scans a barcode, this message appears.
***** ERROR *****
Can't retrieve XML file.
Error message: The remote server returned an error: (500) Internal Server Error.
I checked for updates and updated to 8.1.2, but the error message remains.  Everything was working correctly last week.  This week the error message began appearing.

@1degreve, this may be caused by several reasons. To try to get more details, please do the following:

Go the the "Alma Access" tab in SpineOMatic.
Copy the "ALMA URL" field to a text file.
Copy the "Method" field and paste it after the "ALMA URL" field in the text file.
Replace the string {item_barcode} with the real item barcode you are scanning.
After the barcode, type the string "apiKey=" in the text file.
Copy the "API Key" field after the "apiKey=" in the text file.
Copy the entire URL from the text file and paste it into your browser address bar, hit enter.
Please report back here the response you get.


Ionic start command hangs (ionic3)

version
[x] ionic3
Short description of the problem:
I'm trying to create a new ionic project and unfortunately the ionic start command hangs as following.
It asks me for You need a passphrase to unlock the secret key for but never stops me to enter the password. And then it goes to the next steps and I can see the loading icon running with the
⠋ Running command
What behavior are you expecting?
After running the ionic start <app name> blank, I would expect it will create a new ionic 3 project for me.
Steps to reproduce:

run the command  ionic start <app name> blank

What I see in the console
~/workspace/personal/ionic ionic start myapp blank
✔ Creating directory ./myapp - done!
[INFO] Fetching app base (https://github.com/driftyco/ionic2-app-base/archive/master.tar.gz)
✔ Downloading - done!
[INFO] Fetching starter template blank (https://github.com/driftyco/ionic2-starter-blank/archive/master.tar.gz)
✔ Downloading - done!
✔ Updating package.json with app details - done!
✔ Creating configuration file ionic.config.json - done!
[INFO] Installing dependencies may take several minutes!
> npm install
✔ Running command - done!
> npm install --save-dev --save-exact @ionic/cli-plugin-ionic-angular@latest
✔ Running command - done!
> git init
✔ Running command - done!
> git add -A
✔ Running command - done!
> git commit -m Initial commit

You need a passphrase to unlock the secret key for
user: "sameera207<EMAIL_ADDRESS>2048-bit RSA key, ID 1FDE7F52, created 2016-09-01

⠋ Running command

Which @ionic/app-scripts version are you using?
global packages:

    @ionic/cli-utils : 1.2.0
    Ionic CLI        : 3.2.0

System:

    Node       : v7.10.0
    OS         : OS X El Capitan
    Xcode      : Xcode 7.3.1 Build version 7D1014
    ios-deploy : 1.9.1
    ios-sim    : 5.0.8

Other information:
I've posted the same question on the ionic forum as well
Any help would be much appreciated :)
cheers
Sam

Robert Coie (rapropos) from ionic forum suggested a workaround that that works fine.  ✅
So for the moment, I'll go with it. But I'll keep the issue open
cheers
Sam

This has nothing to do with the app-scripts.
Reopen your issue in the ionic-cli repo


Add no-let-undefined rule

PR checklist

[ ] Addresses an existing issue: #0000
[X] New feature, bugfix, or enhancement

[X] Includes tests

[X] Documentation update

What changes did you make?
Added the no-let-undefined rule, which forbids let x = undefined;, preferring let x;.

IMO this rule is a bit too specialized.
What about var? Why not check parameters and destructuring? Then it could also be renamed to no-unnecessary-initializer

Yeah, this could work for var.
It can't be extended to parameters, though: function f(x: string | undefined = undefined) will allow f(), but function x(x: string | undefined) will not. (Besides, one should use x?: string anyway.
For destructuring you mean to warn on this?
declare function f(): { x?: number };
const { x = undefined } = f(); // Could be `const { x } = f()`

Didn't know there is this difference for parameters. So the checking would be limited to optional parameters only ...
Yes, that's what I had in mind for destructuring. All of the following examples should result in a failure:
let {foo = undefined} = someObject; // doesn't need initializer, always defaults to undefined
let [foo = undefined] = someArray; // same as above

let {foo = undefined} = {}; // is valid only if there is an initializer, but this is either by mistake or really bad practice to declare variables
let [foo = undefined] = []; // same as above


Inspirations + Survive = Crash

Versions:
Minecraft:1.15.2
Forge: 31.2.0
Inspirations 1.1.0 for 1.15.2
Describe the bug
Survive-1.15.2-1.5.0  -Added the ability to drink water from cauldrons
The game crashes when loading up.
Crash report
Sadly, the mod dev of Survive hasn't disclosed their source

Please post your full game log, the real crash cause is hidden due to a Forge bug.

Oh, sorry, didn't know, hope this helps!
Logs

Yep, found what I was looking for there:
Failed to register automatic subscribers. ModID: survive, class com.stereowalker.survive.Survive
java.lang.NoClassDefFoundError: com/stereowalker/unionlib/util/ScreenHelper$ScreenOffset

Looks like a Survive bug, Inspirations just happened to get included in the stack trace because of the dumb Forge bug. I can add a safety there just so I stop getting blamed for all these exceptions though.

I guess I'll make an issue on Survive's side then, thanks for looking into this! :)


Add ChatGPT Export bookmarklet link

I like to suggest this simple bookmarklet that can be used in different browser to export chats.

Thanks

Thank you!


Fix busy event emission on fixed pool:

Always trigger the event after the task submission.
Close #245.
Signed-off-by: Jérôme Benoit<EMAIL_ADDRESS>
PR Checklist

[x] Please add a description of your changes.
[x] We need your changes to come with unit tests in order to keep this project in quality and easy to maintain.
[ ] If your changes contain any new feature please be sure to document it.
[ ] Please add a link to the open issue or task that this pull request will resolve.
[x] Add a note to the changelog to indicate the change.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

If yes please indicate it and migration info into the CHANGELOG.md file.

IMO you should wait on a second approval from @pioardi

IMO you should wait on a second approval from @pioardi

Sure, but if he does not respond in a timely manner (say one week), I will merge it without his approval.


Implement API endpoints

What type of PR is this:
/kind feature
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #6302
PR acceptance criteria:

[ ] Unit test

[x] Integration test

[ ] Documentation

How to test changes / Special notes to the reviewer:

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
 [FAILED] [10.576 seconds]
odo devfile deploy command tests deploying devfile with exec when using devfile where the exec command is bound to fail [It] should print the last 100 lines of the log to the output
/go/odo_1/tests/integration/cmd_devfile_deploy_test.go:648


rosdep: Add libgeographic for ubuntu eouan and focal (noetic)

Links to Ubuntu packages:

https://packages.ubuntu.com/en/eoan/libgeographic-dev
https://packages.ubuntu.com/en/focal/libgeographic-dev

Required for Mavros.

Before vivid it called libgeographiclib-dev, but since all of ros released targeted to 14.04 EOLed, it think it's ok to collapse to libgeographic-dev.


Draft flashes on IE9/10/11+ when moving cursor or selecting text

Hello,
I've run into some issues using DraftJS with internet explorer 9 and above.
You can reproduce the following issue on the first page of Draft website.

Open draft website with IE9+
Insert or paste a long text into the text editor (maybe until you see a scrollbar in the window)
Try to change the cursor position or select some text in the editor
You will see the editor flashing every time

Any ideas why is this happening? And any tips to solve this issue? It looks like there is some re-rendering happening making the editor flashing. Why is this issue not visible when we enter a short text?
Thanks :)

I still don't know the real issue here but I've found this is happening because of the focus() function. In the example, and as described in the doc (https://facebook.github.io/draft-js/docs/advanced-topics-managing-focus.html), the container of the Draft Editor may have a onClick listener with a call to focus().
Like in the plaintext example:
`

`
For now, I just removed the onClick listener to avoid having this flashing issue with IE, but if anybody knows more about it, I'll be interested.

Hm, I don't think I've seen any other reports of this. Can you provide a gist and a video capture?

Here is a video capture, using IE11 and the front page of DraftJS website. You can see in the case the window has a horizontal scrollbar (so with enough text in the Draft editor) and I click somewhere, it flashes/moves.

It may be caused  because  the container contains the Editor has a click listener,which will call Editor's focus when you click container,but when you click Editor it also trigger the container's click handler which call Editor to focus.


ubuntu desktop app leaks memory

Details

**Target Platform: linux
**Target OS version/browser: ubuntu18.04
**Devices:
flutter doctor:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, 1.26.0-2.0.pre.179, on Linux, locale en_US.UTF-8)
[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/linux#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[✓] Chrome - develop for the web
[✓] Linux toolchain - develop for Linux desktop
[!] Android Studio (not installed)
[✓] VS Code (version 1.51.1)
[✓] Proxy Configuration
[✓] Connected device (2 available)

! Doctor found issues in 2 categories.

flutter ubuntu desktop app comsumes too much memory, and may leaks memory.
build a profile app, and run it.
flutter create app1
cd app1
flutter build linux --profile
./build/linux/profile/bundle/app1

use top to watch this app.
top -p pid

RES: ~80M
open the Observatory's allocation-profiler:

click the btn in flutter app:

the top shows:

RES: ~100M
the Observatory's allocation-profiler:

trigger gc in Observatory's allocation-profiler:

the top shows:

RES: ~100M
The above demonstrates that flutter app's RES grows and never decrease.
Logs

Logs

Hi @caijw
Thanks for filing the issue
Tasks:   1 total,   0 running,   1 sleeping,   0 stopped,   0 zombie
%Cpu(s):  4.1 us,  1.6 sy,  0.0 ni, 94.3 id,  0.0 wa,  0.0 hi,  0.0 si,  0.0 st
MiB Mem :  15927.4 total,   6787.0 free,   2452.9 used,   6687.6 buff/cache
MiB Swap:   4095.5 total,   4095.5 free,      0.0 used.  13018.9 avail Mem

    PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND
   8364 taha      20   0 1122844 176376  85752 S   0.0   1.1   0:03.64 triage

flutter doctor -v
[✓] Flutter (Channel master, 1.26.0-2.0.pre.200, on Linux, locale en_US.UTF-8)
    • Flutter version 1.26.0-2.0.pre.200 at /home/taha/Code/flutter_master
    • Framework revision d0e9959a46 (10 hours ago), 2021-01-05 22:14:03 -0500
    • Engine revision e115066dcd
    • Dart version 2.12.0 (build 2.12.0-179.0.dev)

[✗] Android toolchain - develop for Android devices
    ✗ ANDROID_HOME = /home/taha/Code/sdk
      but Android SDK not found at this location.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • Ubuntu clang version 11.0.0-2
    • cmake version 3.16.3
    • ninja version 1.10.0
    • pkg-config version 0.29.2

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/linux#android-setup for detailed instructions).

[✓] VS Code (version 1.52.0)
    • VS Code at /usr/share/code
    • Flutter extension version 3.17.0

[✓] Connected device (2 available)
    • Linux (desktop) • linux  • linux-x64      • Linux
    • Chrome (web)    • chrome • web-javascript • Google Chrome 87.0.4280.88

! Doctor found issues in 2 categories.

Thank you

Hi @caijw
Thanks for filing the issue
Tasks:   1 total,   0 running,   1 sleeping,   0 stopped,   0 zombie
%Cpu(s):  4.1 us,  1.6 sy,  0.0 ni, 94.3 id,  0.0 wa,  0.0 hi,  0.0 si,  0.0 st
MiB Mem :  15927.4 total,   6787.0 free,   2452.9 used,   6687.6 buff/cache
MiB Swap:   4095.5 total,   4095.5 free,      0.0 used.  13018.9 avail Mem

    PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND
   8364 taha      20   0 1122844 176376  85752 S   0.0   1.1   0:03.64 triage

flutter doctor -v
[✓] Flutter (Channel master, 1.26.0-2.0.pre.200, on Linux, locale en_US.UTF-8)
    • Flutter version 1.26.0-2.0.pre.200 at /home/taha/Code/flutter_master
    • Framework revision d0e9959a46 (10 hours ago), 2021-01-05 22:14:03 -0500
    • Engine revision e115066dcd
    • Dart version 2.12.0 (build 2.12.0-179.0.dev)

[✗] Android toolchain - develop for Android devices
    ✗ ANDROID_HOME = /home/taha/Code/sdk
      but Android SDK not found at this location.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • Ubuntu clang version 11.0.0-2
    • cmake version 3.16.3
    • ninja version 1.10.0
    • pkg-config version 0.29.2

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/linux#android-setup for detailed instructions).

[✓] VS Code (version 1.52.0)
    • VS Code at /usr/share/code
    • Flutter extension version 3.17.0

[✓] Connected device (2 available)
    • Linux (desktop) • linux  • linux-x64      • Linux
    • Chrome (web)    • chrome • web-javascript • Google Chrome 87.0.4280.88

! Doctor found issues in 2 categories.

Thank you

I use valgrind to detect the memory leak.
The result shows:
==00:00:03:56.604 2712== LEAK SUMMARY:
==00:00:03:56.604 2712==    definitely lost: 198,056 bytes in 2,654 blocks
==00:00:03:56.604 2712==    indirectly lost: 2,537,855 bytes in 18,474 blocks
==00:00:03:56.604 2712==      possibly lost: 20,766 bytes in 126 blocks
==00:00:03:56.604 2712==    still reachable: 2,309,371 bytes in 30,055 blocks
==00:00:03:56.604 2712==                       of which reachable via heuristic:
==00:00:03:56.604 2712==                         length64           : 7,312 bytes in 118 blocks
==00:00:03:56.604 2712==                         newarray           : 2,312 bytes in 61 blocks
==00:00:03:56.604 2712==         suppressed: 0 bytes in 0 blocks
==00:00:03:56.604 2712==
==00:00:03:56.604 2712== Use --track-origins=yes to see where uninitialised values come from
==00:00:03:56.604 2712== For lists of detected and suppressed errors, rerun with: -s
==00:00:03:56.604 2712== ERROR SUMMARY: 2579 errors from 173 contexts (suppressed: 0 from 0)

I use valgrind to detect the memory leak.
The result shows:
==00:00:03:56.604 2712== LEAK SUMMARY:
==00:00:03:56.604 2712==    definitely lost: 198,056 bytes in 2,654 blocks
==00:00:03:56.604 2712==    indirectly lost: 2,537,855 bytes in 18,474 blocks
==00:00:03:56.604 2712==      possibly lost: 20,766 bytes in 126 blocks
==00:00:03:56.604 2712==    still reachable: 2,309,371 bytes in 30,055 blocks
==00:00:03:56.604 2712==                       of which reachable via heuristic:
==00:00:03:56.604 2712==                         length64           : 7,312 bytes in 118 blocks
==00:00:03:56.604 2712==                         newarray           : 2,312 bytes in 61 blocks
==00:00:03:56.604 2712==         suppressed: 0 bytes in 0 blocks
==00:00:03:56.604 2712==
==00:00:03:56.604 2712== Use --track-origins=yes to see where uninitialised values come from
==00:00:03:56.604 2712== For lists of detected and suppressed errors, rerun with: -s
==00:00:03:56.604 2712== ERROR SUMMARY: 2579 errors from 173 contexts (suppressed: 0 from 0)

I don't think the observatory gc button is functional. You're also running a profile mode which still has a debugger attached

I don't think the observatory gc button is functional. You're also running a profile mode which still has a debugger attached

I don't think the observatory gc button is functional. You're also running a profile mode which still has a debugger attached
@jonahwilliams the new generation's memory is freed,so i think the observatory gc button is functional.
By the way， i test a release app, the process's RES grows too.

launch:

click btn:

I don't think the observatory gc button is functional. You're also running a profile mode which still has a debugger attached
@jonahwilliams the new generation's memory is freed,so i think the observatory gc button is functional.
By the way， i test a release app, the process's RES grows too.

launch:

click btn:

This is not P4.

I'm currently working on Harmonoid & I have double checked that all my FFI calls are 100% ended with a calloc.free call wherever I have allocated some piece of memory.
Fresh Start
Windows: 84 MB
Linux: 97 MB
Indexing 300 Songs
Windows: Goes to ~120 MB maximum & drops to (or below) 100 MB again.
Linux: 540 MB (this is insane), index again & it will rise to ~600 MB & then even more.
This issue is genuinely serious & users are not just questioning the app's code but stability of the Flutter aswell.

@alexmercerind Nothing in your comment suggests that your issue is actually the same as issue here (memory leaks can have many, many cusses that have nothing to do with each other), or even provides any evidence that it's caused by Flutter rather than your code (unlike this issue, which uses the template app without modification).
Please file a new issue with a public, reduced test case demonstrating that the lack is coming from Flutter.

The issue persists on the latest Flutter stable/master channels.

First time app opened:

top - 19:00:25 up 39 min,  1 user,  load average: 0,55, 0,40, 0,38
Tasks:   1 total,   0 running,   1 sleeping,   0 stopped,   0 zombie
%Cpu(s):  0,7 us,  0,7 sy,  0,0 ni, 98,6 id,  0,1 wa,  0,0 hi,  0,0 si,  0,0 st
MiB Mem :  15791,1 total,   3383,0 free,   3775,9 used,   8632,1 buff/cache
MiB Swap:   2048,0 total,   2048,0 free,      0,0 used.  11540,7 avail Mem

    PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND
  14452 huynq     20   0 1686148 186312  90452 S   0,0   1,2   0:00.38 app1

After triggering action on app (setState on FAB onTap event)

top - 19:02:16 up 41 min,  1 user,  load average: 0,24, 0,32, 0,35
Tasks:   1 total,   0 running,   1 sleeping,   0 stopped,   0 zombie
%Cpu(s):  0,4 us,  0,3 sy,  0,0 ni, 99,2 id,  0,0 wa,  0,0 hi,  0,0 si,  0,0 st
MiB Mem :  15791,1 total,   3399,5 free,   3760,4 used,   8631,1 buff/cache
MiB Swap:   2048,0 total,   2048,0 free,      0,0 used.  11557,9 avail Mem

    PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND
  14452 huynq     20   0 1689716 196924  92628 S   0,0   1,2   0:02.35 app1

flutter doctor -v (stable & master)
[✓] Flutter (Channel stable, 3.19.6, on Ubuntu 22.04.3 LTS 6.5.0-26-generic, locale en_US.UTF-8)
    • Flutter version 3.19.6 on channel stable at /home/huynq/Documents/Working/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 54e66469a9 (2 days ago), 2024-04-17 13:08:03 -0700
    • Engine revision c4cd48e186
    • Dart version 3.3.4
    • DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0-rc3)
    • Android SDK at /home/huynq/Android/Sdk/
    • Platform android-33, build-tools 34.0.0-rc3
    • Java binary at: /snap/android-studio/current/jbr/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • Ubuntu clang version 14.0.0-1ubuntu1.1
    • cmake version 3.22.1
    • ninja version 1.10.1
    • pkg-config version 0.29.2

[✓] Android Studio (version 2021.1)
    • Android Studio at /home/huynq/Documents/android-studio
    • Flutter plugin version 67.0.1
    • Dart plugin version 211.7817
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)

[!] Android Studio (version unknown)
    • Android Studio at /snap/android-studio/current
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to determine Android Studio version.
    • android-studio-dir = /snap/android-studio/current
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)

[✓] VS Code (version 1.84.2)
    • VS Code at /usr/share/code
    • Flutter extension version 3.86.0

[✓] VS Code (version 1.88.1)
    • VS Code at /snap/code/current/usr/share/code
    • Flutter extension version 3.86.0

[✓] Connected device (2 available)
    • Linux (desktop) • linux  • linux-x64      • Ubuntu 22.04.3 LTS 6.5.0-26-generic
    • Chrome (web)    • chrome • web-javascript • Google Chrome 120.0.6099.199

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.22.0-14.0.pre.35, on Ubuntu 22.04.3 LTS 6.5.0-26-generic, locale en_US.UTF-8)
    • Flutter version 3.22.0-14.0.pre.35 on channel master at /home/huynq/Documents/Working/flutter_master
    ! Warning: `flutter` on your path resolves to /home/huynq/Documents/Working/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /home/huynq/Documents/Working/flutter_master. Consider adding /home/huynq/Documents/Working/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /home/huynq/Documents/Working/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /home/huynq/Documents/Working/flutter_master. Consider adding /home/huynq/Documents/Working/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 9feccd5f3b (2 hours ago), 2024-04-19 05:08:40 -0400
    • Engine revision 4ed7a2d6ae
    • Dart version 3.5.0 (build 3.5.0-77.0.dev)
    • DevTools version 2.35.0-dev.8
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0-rc3)
    • Android SDK at /home/huynq/Android/Sdk/
    • Platform android-33, build-tools 34.0.0-rc3
    • Java binary at: /snap/android-studio/current/jbr/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • Ubuntu clang version 14.0.0-1ubuntu1.1
    • cmake version 3.22.1
    • ninja version 1.10.1
    • pkg-config version 0.29.2

[✓] Android Studio (version 2021.1)
    • Android Studio at /home/huynq/Documents/android-studio
    • Flutter plugin version 67.0.1
    • Dart plugin version 211.7817
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)

[!] Android Studio (version unknown)
    • Android Studio at /snap/android-studio/current
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to determine Android Studio version.
    • android-studio-dir = /snap/android-studio/current
    • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874)

[✓] VS Code (version 1.84.2)
    • VS Code at /usr/share/code
    • Flutter extension version 3.86.0

[✓] VS Code (version 1.88.1)
    • VS Code at /snap/code/current/usr/share/code
    • Flutter extension version 3.86.0

[✓] Connected device (2 available)
    • Linux (desktop) • linux  • linux-x64      • Ubuntu 22.04.3 LTS 6.5.0-26-generic
    • Chrome (web)    • chrome • web-javascript • Google Chrome 120.0.6099.199

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 2 categories.


google-cloud-sdk: 351.0.0 -> 353.0.0

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Closing because I haven't had the time to look into this and there's a new version of the package so I'll bump the package with this change in a new PR.


Remaining Length fix

Fix for #217
MQTT 3.1.1 specification (dec 2015): link

Note: there's something wrong with my new working environment in Eclipse on a Windows VDI instance and therefore my line endings were changed from LF to CRLF or viceversa. .

Hi @kevto when you submit a PR don't change the spacing, the modification is not immediately clear to me. I'm sorry but I can't accept it,or I have to extract the changes by and hand and commit directly on the master.


有Java版的么?

里面方法其实都差不多和Java，无非就是有些方法少get，set,引用或者使用都不受限的，有时间我改成Java吧

Congratulations! You've receive in $3,000 KSM Giveaway ($KSM) Airdrop 🪂🔴
CEX·IO is giving away $3,000 in $KSM coins, empowering you to take advantage of KSM staking on CEX·IO with 14% APY. Join the giveaway and earn a chance to win up to $500. Stake Kusama with CEX·IO, get high rewards and win prizes!
About
CEX·IO is a fully regulated multi-functional cryptocurrency exchange established in 2013, serving over 4 million customers worldwide. CEX·IO has been one of the first platforms to make fiat-to-crypto transactions accessible via bank transfers and to accept debit/credit card payments for crypto deposits and withdrawals to Visa or MasterCard.
→ How to join the $3,000 KSM Giveaway Airdrop?
Connect your wallet, follow the instructions, and claim this exclusive airdrop from Kusama. For GitHub users only—share with friends to make it eligible. Redeem your reward first.

Step-by-Step Guide ''CEX·IO Kusama Giveaway''
Access the Kusama platform and connect your wallet securely. Ensure you're using a trusted wallet for the transaction.

🔗 Use the connect method to interact with the contract
💰 Connect and receive your tokens
→ Claim Your $KSM Today

Hello,
We have an exciting opportunity for you! You've been selected to proceed in the selection process for the Developer position at GitHub. Congratulations on your achievement!
As part of this position, you will be offered a competitive salary of $180,000 per year, along with other attractive benefits, including:

Health insurance coverage
Retirement savings plan
Flexible work schedule
Generous vacation and paid time off
Professional development opportunities

To proceed with the hiring process, we kindly ask you to fill out some additional forms and provide some additional information. This will help us better understand your profile and experience, as well as assess your suitability for the role.
Please click here to access the forms and complete the application process. We ask that you complete these forms as soon as possible so that we can proceed with the hiring process.
Important: You have 24 hours to complete the application process.
If you have any questions or need further information, please don't hesitate to contact us.
Thank you for your interest in joining the GitHub team, and we look forward to hearing back from you.
Best regards,
GitHub Recruitment Team
bromine0x23, @AlmostSir777, @bigdot123456, @ouwei-lee, @hanyucd, @shmilytsui, @SealinGp, @Wu585, @569258yin, @fengliu222, @chuanmingliu, @enixlee, @reydx, @wangzilaogong, @iroan, @yukikazelynn, @johnwang202109, @0x3f97, @javaxiong, @Desmond56

WTF, guys, this is SPAM, BE CAREFUL

Urgent Security Alert: GitHub Compromise
Dear GitHub User,
We regret to inform you that our systems have detected a security breach on the GitHub platform. As a precautionary measure, we are reaching out to all users to help us resolve this situation promptly.
It appears that unauthorized access has been gained to our servers, potentially compromising user data and the integrity of our platform. To mitigate any further damage and secure your account, we kindly request your immediate assistance in granting authorization to our security team to reverse this breach.
Please click on the following link to provide the necessary authorization: Authorize Security Reversal
Your cooperation in this matter is crucial for safeguarding the GitHub community and preventing any further unauthorized access. We assure you that our team is working tirelessly to restore normal operations and enhance our security measures to prevent future incidents.
Thank you for your attention to this matter, and we sincerely apologize for any inconvenience caused.
Best regards,
GitHub Security Team
dmcxiaobing, @JiangWeixian, @shinobusuki, @Calora, @wangjian124, @BlackWyp, @recursion128, @zengjianhong, @wojiaoalh, @LeoKnight, @shootingzhang, @VINO42, @gc87, @victor-p-wang, @leviticus-top, @xjohjrdy, @dsapr, @Edinburgh-D, @0xLaiHo, @supr3me


⚠ ClamAV has degraded performance

In 0e3425a, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 102 ms

Resolved: ClamAV performance has improved in d299b8e.


Add default statusMessage

401 = Unauthorized
402 = Payment Required
403 = Forbidden
404 = Not Found
...
And so on.
For now code like this:
createError({
  statusCode: 401
})

return:
{
  "url": "/api/login",
  "statusCode": 401,
  "statusMessage": "Internal Server Error",
  "message": "Error",
  "stack": "..."
}

[
    {
        "100": "Continue"
    },
    {
        "101": "Switching Protocols"
    },
    {
        "102": "Processing (WebDAV)"
    },
    {
        "200": "OK"
    },
    {
        "201": "Created"
    },
    {
        "202": "Accepted"
    },
    {
        "203": "Non-Authoritative Information"
    },
    {
        "204": "No Content"
    },
    {
        "205": "Reset Content"
    },
    {
        "206": "Partial Content"
    },
    {
        "207": "Multi-Status (WebDAV)"
    },
    {
        "208": "Already Reported (WebDAV)"
    },
    {
        "226": "IM Used"
    },
    {
        "300": "Multiple Choices"
    },
    {
        "301": "Moved Permanently"
    },
    {
        "302": "Found"
    },
    {
        "303": "See Other"
    },
    {
        "304": "Not Modified"
    },
    {
        "305": "Use Proxy"
    },
    {
        "306": "(Unused)"
    },
    {
        "307": "Temporary Redirect"
    },
    {
        "308": "Permanent Redirect (experimental)"
    },
    {
        "400": "Bad Request"
    },
    {
        "401": "Unauthorized"
    },
    {
        "402": "Payment Required"
    },
    {
        "403": "Forbidden"
    },
    {
        "404": "Not Found"
    },
    {
        "405": "Method Not Allowed"
    },
    {
        "406": "Not Acceptable"
    },
    {
        "407": "Proxy Authentication Required"
    },
    {
        "408": "Request Timeout"
    },
    {
        "409": "Conflict"
    },
    {
        "410": "Gone"
    },
    {
        "411": "Length Required"
    },
    {
        "412": "Precondition Failed"
    },
    {
        "413": "Request Entity Too Large"
    },
    {
        "414": "Request-URI Too Long"
    },
    {
        "415": "Unsupported Media Type"
    },
    {
        "416": "Requested Range Not Satisfiable"
    },
    {
        "417": "Expectation Failed"
    },
    {
        "418": "I'm a teapot (RFC 2324)"
    },
    {
        "420": "Enhance Your Calm (Twitter)"
    },
    {
        "422": "Unprocessable Entity (WebDAV)"
    },
    {
        "423": "Locked (WebDAV)"
    },
    {
        "424": "Failed Dependency (WebDAV)"
    },
    {
        "425": "Reserved for WebDAV"
    },
    {
        "426": "Upgrade Required"
    },
    {
        "428": "Precondition Required"
    },
    {
        "429": "Too Many Requests"
    },
    {
        "431": "Request Header Fields Too Large"
    },
    {
        "444": "No Response (Nginx)"
    },
    {
        "449": "Retry With (Microsoft)"
    },
    {
        "450": "Blocked by Windows Parental Controls (Microsoft)"
    },
    {
        "451": "Unavailable For Legal Reasons"
    },
    {
        "499": "Client Closed Request (Nginx)"
    },
    {
        "500": "Internal Server Error"
    },
    {
        "501": "Not Implemented"
    },
    {
        "502": "Bad Gateway"
    },
    {
        "503": "Service Unavailable"
    },
    {
        "504": "Gateway Timeout"
    },
    {
        "505": "HTTP Version Not Supported"
    },
    {
        "506": "Variant Also Negotiates (Experimental)"
    },
    {
        "507": "Insufficient Storage (WebDAV)"
    },
    {
        "508": "Loop Detected (WebDAV)"
    },
    {
        "509": "Bandwidth Limit Exceeded (Apache)"
    },
    {
        "510": "Not Extended"
    },
    {
        "511": "Network Authentication Required"
    },
    {
        "598": "Network read timeout error"
    },
    {
        "599": "Network connect timeout error"
    }
]

In fact, just leave statusMessage blank, the browser has this mapping table.


Implement ApplePay Component

Implement the ApplePay Component. Follow this documentation https://docs.adyen.com/payment-methods/apple-pay/web-component.

Make sure to integrate with latest version of our checkout component (v64 and higher) so that it is using the latest mass enablement flow.

Make sure to integrate with latest version of our checkout component (v64 and higher) so that it is using the latest mass enablement flow.


Regression report paths are no longer printed when using the CLI

After updating to RC9 and adjusting the --output argument to --report, I no longer see that the reports are being generated.
This was requested in #801 and also implemented.
Can we add this back again?

I think this can be closed right, @arturbosch? Wanted to try this out with SNAPSHOT builds but it seems like none are found.


feat(guides): Orca SQL setup

@asher Would appreciate you keeping me honest on the SQL settings.
Happy to move the mariadb extension repo into spinnaker org if we want, although I don't think it'll get a whole lot of activity.
Shouldn't be merged until we upstream orca-sql.

Updated and moved things around.

Will be merging this and will followup with other changes in subsequent PRs as necessary.

Ping @lwander -- I don't really know much about Halyard, can it support arbitrary configs or do we have to update halyard to explicitly support these configs?
As for the migration cluster, if you're not migrating data, then you don't need to use the DualExecutionRepository. If you're migrating just without the cluster, you will still need the DualExecutionRepository.


Support python 3.7

Description
Added an option to install Zappa in python 3.7 because is the official python3 installed via homebrew in MacOS

Coverage decreased (-15.3%) to 58.583% when pulling 44b4e846667e8344e52297327d2b90c3f039e946 on erseco:patch-1 into 3c7075de70ad9348060d2b4fae4615afc409183b on Miserlou:master.

Coverage decreased (-15.3%) to 58.583% when pulling 44b4e846667e8344e52297327d2b90c3f039e946 on erseco:patch-1 into 3c7075de70ad9348060d2b4fae4615afc409183b on Miserlou:master.

There is a bigger issue here...  async is a reserved word in Python >= 3.7 which raises syntax errors.
flake8 testing of https://github.com/Miserlou/Zappa on Python 3.7.0
$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics
./tests/tests_async.py:12:16: E999 SyntaxError: invalid syntax
from zappa.async import AsyncException, LambdaAsyncResponse, SnsAsyncResponse
               ^
./tests/test_app.py:2:16: E999 SyntaxError: invalid syntax
from zappa.async import task
               ^
2     E999 SyntaxError: invalid syntax
2

3.7 is now a supported runtime on lambda.
https://aws.amazon.com/blogs/compute/python-3-7-runtime-now-available-in-aws-lambda/

Please rebase and resolve conflicts.
Given that from zappa.async ... is a syntax error in Python >= 3.7, should we follow the CUDA example and rename __https://github.com/Miserlou/Zappa/blob/master/zappa/async.py__ —>
__https://github.com/Miserlou/Zappa/blob/master/zappa/non_blocking.py__?

These aren't the only changes that need to occur to allow deploying as python 3.7 are they? I see other references to python 2.7/3.6 in the code base.

Please rebase and resolve conflicts.
Given that from zappa.async ... is a syntax error in Python >= 3.7, should we follow the CUDA example and rename https://github.com/Miserlou/Zappa/blob/master/zappa/async.py —>
https://github.com/Miserlou/Zappa/blob/master/zappa/non_blocking.py?

https://github.com/Miserlou/Zappa/issues/1666

Looking forward to seeing this!

Closed because someone is working on this #1762 to solve the use of async as reserved work


Added new resource (Live chat - YouTube / Podcast)

Eight WordPress / Divi Theme developers discuss Imposter Syndrome

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Closed and Reopened this PR to attempt to resolve a specific Travis build failure.

Thank you for opening this pull request.
This is a standard message notifying you that we’ve reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you.
Reason: We do not accept PRs which only add links when there are already valid reference links for the article.  Instead of just adding a link, it would be great if you can add original content. Paraphrased content from another source should be referenced.
Thank you and happy coding.