[BUG] Resizing Disk issue

Hi Guys,
There seems to be an issue when you resize disk, while terraform does show its going todo it correctly, whats actaully happening is it creates a new disk instead which is then blank so it then can't boot.
You can tell this as if you check the UI as its running, you can see its trying to craete a new one to replce old, where usually you would only see it change size.
I have tried adding in slot as id is no longer supported, but this did not help.
After initial creation

While second apply is done, after size change in manifest.
You can see its not going to destory it, but update in-place, but thats not what happens.
❯ terraform apply
proxmox_vm_qemu.vm[0]: Refreshing state... [id=pve01/qemu/271050]

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # proxmox_vm_qemu.vm[0] will be updated in-place
  ~ resource "proxmox_vm_qemu" "vm" {
        id                     = "pve01/qemu/271050"
        name                   = "tf-testvm01"
        # (37 unchanged attributes hidden)

      ~ disk {
          ~ size        = "20G" -> "50G"
            # (13 unchanged attributes hidden)
        }

        # (3 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value:

❯ terraform apply
proxmox_vm_qemu.vm[0]: Refreshing state... [id=pve01/qemu/271050]

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # proxmox_vm_qemu.vm[0] will be updated in-place
  ~ resource "proxmox_vm_qemu" "vm" {
        id                     = "pve01/qemu/271050"
        name                   = "tf-testvm01"
        # (37 unchanged attributes hidden)

      ~ disk {
          ~ size        = "20G" -> "50G"
            # (13 unchanged attributes hidden)
        }

        # (3 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

   Resources: 0 added, 1 changed, 0 destroyed.

After the apply finishes, you now see the disk-1 not disk-0 showing.  The machine then gets stuck in a reboot loop because theres now now OS on the disk (its blank).

Now if you just resize disk via UI while machine is on, it just changes size, it doesn't create a new one, so im not sure why terraform is behaving like this.
You can also see on the zfs dataset that its created an extra one, didnt delete the original either, it just created another disk then removed original (just not data).  It should of just adjusted the size of the original and not reaplce it.
root@pve01:~# zfs list|grep 27
rpool/prod/vm/vm-271050-cloudinit   135K  5.62T      135K  -
rpool/prod/vm/vm-271050-disk-0     1.35G  5.62T     1.35G  -
rpool/prod/vm/vm-271050-disk-1     99.5K  5.62T     99.5K  -

What should of happened is, it should of just adjusted the size of disk-0.
To duplicate this issue easily, you can see my example code below.  Just change size after initial build and re-apply to see issue.
# https://github.com/Telmate/terraform-provider-proxmox/blob/master/docs/resource_vm_qemu.md

terraform {
  required_providers {
    proxmox = {
      source  = "telmate/proxmox"
      version = "~> 2.6.5"
    }
  }
}

provider "proxmox" {
  pm_parallel       = 4
  pm_tls_insecure   = true
  pm_api_url        = var.pm_api_url
  pm_password       = var.pm_password
  pm_user           = var.pm_user
}

resource "proxmox_vm_qemu" "vm" {

  #
  # Machine Specifications
  #

  count             = 1
  name              = var.vm_hostname
  desc              = var.vm_desc
  vmid              = var.vm_id

  target_node       = var.pm_node

  cpu               = var.vm_cpu
  numa              = true
  memory            = var.vm_memory

  cores             = var.vm_cores
  sockets           = var.vm_sockets

  clone             = var.vm_template
  full_clone        = true

  pool              = var.vm_pool

  agent             = 1
  os_type           = "cloud-init"

  hotplug           = "network,disk,usb,memory,cpu"
  scsihw            = "virtio-scsi-pci"
  bootdisk          = "scsi0"
  boot              = "c"

  disk {
    slot            = 0
    size            = "20G"
    storage         = "prod-vm"

    type            = "scsi"
    ssd             = "true"
  }

  vga {
    memory = 0
    type   = "serial0"
  }

  #
  # Connectivity
  #

  # net/linux (vLAN 4001)
  network {
      model = "virtio"
      bridge = "vmbr1"
      tag = 4001
  }

  network {
      model = "virtio"
      bridge = "vmbr1"
      tag = 4002
  }

  ipconfig0 = "ip=${var.vm_ip}/24,gw=${var.vm_gw}"
  ipconfig1 = "ip=<IP_ADDRESS>/24"

  # Terraform
  ssh_user = "ubuntu"
  ssh_private_key = file("${path.module}/keys/id_rsa_terraform")

  # User public SSH key
  sshkeys = file("${path.module}/keys/id_rsa_netspeedy.pub")

  provisioner "remote-exec" {

    connection {
      type     = "ssh"
      user     = "root"
      host     = var.vm_ip
      private_key = file("${path.module}/keys/id_rsa_terraform")
    }

    inline = [
      "ip a"
    ]
  }

  #
  # Lifecycle
  #
  lifecycle {
    ignore_changes  = [
      network
    ]
  }

}

Any ideas on fix?
Only solution I have right now is to ignore the disks and manually make changes but that kinda defeats the object of terraform.

Hi,
I have the same problem. When the disk is resized, a new blank disk is created and the original one switches to the Unused disk state.
terraform version 1.0.1
telmate/proxmox provider 2.7.1

resource "proxmox_vm_qemu" "vm" {

        additional_wait           = 15
        agent                     = 1
        balloon                   = 0
        bios                      = "seabios"
        boot                      = "c"
        clone                     = "ubuntu-cloudinit"
        clone_wait                = 0
        cores                     = 4
        cpu                       = "host"
        define_connection_info    = true
        force_create              = false
        full_clone                = true
        guest_agent_ready_timeout = 600
        hotplug                   = "network,disk,cpu,memory,usb"
        kvm                       = true
        memory                    = 4096
        name                      = "cloudinit"
        numa                      = true
        onboot                    = false
        os_type                   = "cloud-init"

        sockets                   = 2
        target_node               = "virt-devel01-test"
        vcpus                     = 0
        ipconfig0                 = "ip=dhcp"

   disk {
        backup       = 0
        cache        = "none"
        iothread     = 0
        mbps         = 0
        mbps_rd      = 0
        mbps_rd_max  = 0
        mbps_wr      = 0
        mbps_wr_max  = 0
        replicate    = 0
        size         = "130G"
        ssd          = 0
        storage      = "ceph"
        type         = "scsi"
        }
}

I'm facing the same issue.
Have you guys found any workarounds in the meantime?
@soakes @tomKL25

Currently no I haven't, only work around I am using is to destory and rebuild with the new disk values.  Thankfully most of my stuff is ansiblized so not a major issue but for some this is.  Its a pain to do but thankfully I dont need to resize too oftern.

Just wanted to chime in here and say I am experiencing the same issue.  Does anyone know of an older version of the proxmox provider I can revert back to where this works?  Currently experiencing it on 2.6.5.

Our strategy has been to update the disk size in the proxmox web UI, and then edit the TF state. It works, but is definitely not ideal or how it should be.

I am experiencing a similar issue however it is a bit worse than just regrowing the disk. Any attempt to run terraform again (re-sizing the disk or not) will create a new blank disk. So simply applying your terraform apply twice will casue this provider to create a new disk (even if you have made no changes at all).

I'm experiencing the same issue. Any news?
Proxmox 7.1
Terraform v1.0.11

Hey all,
Same thing here:
If I use
disk {
    size            = "20G"
    type            = "virtio"
    storage         = "local-lvm"
 }

to resize template VM disk with proxmox then it create an unused disk 0 and I cannot boot anymore...
The only solution I got : I create a VM template with the correct size with Packer then I avoid to use disk with Proxmox...
Proxmox 7.8.1
Terraform 1.1.3
Telmate/proxmox v2.6.4

Hi guys,
Found a solution that works now, here it is
disk {
    slot            = 0
    size            = "20G"
    type            = "virtio"
    storage         = "local-lvm"
 }

Even resizing a disk works :)
Hope it can help
Fred

Oh, very nice.  I'll try this out in our dev environment,

Hi guys,
Found a solution that works now, here it is
disk {
    slot            = 0
    size            = "20G"
    type            = "virtio"
    storage         = "local-lvm"
 }

Even resizing a disk works :)
Hope it can help
Fred

yeah confirmed that adding slot=0 to our main.tf works.  This is on TF 1.0.9

Awesome find guys, thats one thing I never tried.

@soakes an official documentation has weird description for the slot parameter
slot | int |   | _(not sure what this is for, seems to be deprecated, do not use)_.

https://registry.terraform.io/providers/Telmate/proxmox/latest/docs/resources/vm_qemu
It would be great if someone from provider authors would give an explanation here.
Also, terraform is trying to modify base VM image on each plan
      ~ disk {
          ~ size         = "2252M" -> "30G"
          ~ type         = "scsi" -> "virtio"
            # (15 unchanged attributes hidden)
        }

Yeah it does.

Also, this option adds block device with partitions
vda     252:0    0   20G  0 disk
├─vda1  252:1    0  2.1G  0 part
├─vda14 252:14   0    4M  0 part
└─vda15 252:15   0  106M  0 part

Not sure what's happening here

Here's description from provider's source code
https://github.com/Telmate/terraform-provider-proxmox/blob/a222eb626fa30eda9b7670578c6180c3c8d50fe7/proxmox/resource_vm_qemu_test.go#L90
// slot setting to assign a non-standard disk position (scsi5 vs scsi0)

Also, adding slot 0 in terraform leads to a collision, where hard disk definitions point to the same file on filesystem

So I'm afraid that @fguiet answer is not suitable

Hi All,
Yeah it seems that this option is not suitable for our problem...
We'll have to wait for a fix...sorry
Fred

Hi Everybody. I have the same issue, even with the latest version of the telmate/proxmox 2.9.6

The provider for some reason "interchanges" the boot disc and the other disk, configured in the script. And tries to update the boot disc with the params defined for another one.

i have the solution - just use another virtio number for bootdisc instead of 0

This is still a blocking issue when using the provider. Anyone have any suggestions? From what I can see the proxmox api doesn't provide any easy way to identify disks (no ID returned from the api for example)

Should this be reopened?

Should this be reopened?

Yes, this is the only reason why we're not using this provider.

This is strange as its working fine for me as long as your using telmate/proxmox v2.9.6 or greater then its working but previous to this it wasn't.
❯ terraform plan
proxmox_vm_qemu.vm[0]: Refreshing state... [id=pve01/qemu/192101]
proxmox_vm_qemu.vm[1]: Refreshing state... [id=pve01/qemu/192102]
proxmox_vm_qemu.vm[2]: Refreshing state... [id=pve01/qemu/192103]

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # proxmox_vm_qemu.vm[0] will be updated in-place
  ~ resource "proxmox_vm_qemu" "vm" {
        id                        = "pve01/qemu/192101"
        name                      = "gkube01.example.io"
        tags                      = ""
        # (59 unchanged attributes hidden)

      ~ disk {
          ~ size         = "20G" -> "40G"
            # (17 unchanged attributes hidden)
        }

        # (4 unchanged blocks hidden)
    }

  # proxmox_vm_qemu.vm[1] will be updated in-place
  ~ resource "proxmox_vm_qemu" "vm" {
        id                        = "pve01/qemu/192102"
        name                      = "gkube02.example.io"
        tags                      = ""
        # (59 unchanged attributes hidden)

      ~ disk {
          ~ size         = "20G" -> "40G"
            # (17 unchanged attributes hidden)
        }

        # (4 unchanged blocks hidden)
    }

  # proxmox_vm_qemu.vm[2] will be updated in-place
  ~ resource "proxmox_vm_qemu" "vm" {
        id                        = "pve01/qemu/192103"
        name                      = "gkube03.example.io"
        tags                      = ""
        # (59 unchanged attributes hidden)

      ~ disk {
          ~ size         = "20G" -> "40G"
            # (17 unchanged attributes hidden)
        }

        # (4 unchanged blocks hidden)
    }

Will reopen so we can get to the bottom of why it seems to work for me.

terraform {
  required_providers {
    proxmox = {
      source = "telmate/proxmox"
      version = "2.9.6"
    }
  }
}

I was using v2.9.6 and it was working correctly, a few weeks back. Trying it out today seems to be failing.
Upgrading to v2.9.10 seems not to move the previous disk to unused0, but the VM doesn't boot.

I use version telmate/proxmox v2.9.14
The problem is current:
# proxmox_vm_qemu.this["k3s-master-0"] will be updated in-place
  ~ resource "proxmox_vm_qemu" "this" {
        id                        = "proxmox/qemu/104"
        name                      = "k3s-master-0"
        # (38 unchanged attributes hidden)

      ~ disk {
          ~ size               = "2G" -> "20G"
          ~ type               = "scsi" -> "virtio"
            # (25 unchanged attributes hidden)
        }

        # (1 unchanged block hidden)
    }
    ```

also facing this issue.

Any chance to get this fixed?
It workaround with "slot=0" doesn't work with scsi.

Well, the problem continues. I'm with the version
telmate v2.9.14
proxmox v8.1.4
terraform v1.7.1
It continues adding disks instead of expanding the disk it already has defined.

Please reopen this as I still have issue and slot=0 is not working.

Please reopen this as I still have issue and slot=0 is not working.

AFAIK you cant reopen a closed issue.  I would suggest you just create a new one and reference to this.


Login configuration

Updated front end to the website. Login page is in progress. Fake members have been added for testing. Portfolio pages are update and the models are associated. File paths have been seeded within the database and the migrations are ran upon tests for build.


Having multiple validation sets

Is it possible to define two validation sets (val1, val2), and perform validation on val1 every epoch and on val2 every 10th epoch?

You can refer to the separate_val in ConcateDataset
https://mmdetection.readthedocs.io/en/latest/tutorials/customize_dataset.html#concatenate-dataset

Feel free to reopen it if there is any question.


G810 media keys & M65 mouse

What are you experiencing an issue with?

[ ] Aurora
[ ] Aurora supported game, (Fill in the game)
[ ] Aurora Wrapper
[ ] Aurora Profile
[x ] Aurora supported device, (Fill in problematic devices)
[ ] Aurora Scripts
[ ] Aurora Updater
[x] Aurora Lighting issue
[ ] Other, (Fill in another issue here)

What kind of an issue is it?

[ ] Crash
[ ] Performance problems
[ ] Visual bug
[ ] Localization issue
[ ] Enhancement suggestion
[x ] Device issue
[x ] Other, (Fill in another type of issue here)

Expected behavior:
For the keyboard there are no way to include the media keys and caps/numlock indicators
Mouse should change with keyboard
Actual behavior:
Mouse does not light up at all
How often does this problem occur?

This problem occurs every time
Please describe the steps to reproduce this issue:
The issue can be reproduced by doing following steps:

Connecting mouse/keyboard
Running Aurora

What is the version of Aurora you are experiencing this issue with?

My version is... beta v0.6.0b
Does the previous version of Aurora have this issue?
Yes
Please include any logs, screenshots, or files that are related to this issue:

For logs, you can use: http://pastebin.com/
For screenshots, you can use: http://imgur.com/
For files, you can use: http://www.tinyupload.com/ , https://www.dropbox.com/ , or attach them to the issue.

Have you selected a mouse in the settings?
As for media/lock indicators, those aren't part of Logitech LED SDK.


Fix: Accept the feedback for the code style.

This PR is for the acceptance of  #16 PR's requested changes!
Thank you for your feedback! @X1nto

A one-liner arrow for a multiline if seems weird, using blocks instead

https://github.com/MateriiApps/pullrefresh/pull/16#discussion_r1705263375

Add a whitespace

https://github.com/MateriiApps/pullrefresh/pull/16#discussion_r1705263692

Change back DragRefreshSample.kt code to match with README.md

I rollback DragRefreshSample.kt code to the commit which is before #16 PR to match the sample code with README.md gif.

The gif in README.md is as below

Hello, @wingio!
Could you please help me review this PR and merge it?


Missing changelog for 1.8.0 release

Hello. Can you please add changelog intro for 1.8.0 release?

@sbatson5 looks like the v2 release is also not in the changelog. would be great if this could be updated so that people can easily see what the breaking changes are.

Thanks for calling this out. I have some time set on my calendar next week to do some OSS work.  I'll add info for 1.8, 1.9 and 2

Thank you very much! One of the things, I believe, that sets the ember community from others is a very strong emphasis on keeping changelogs, which in turn makes it very easy to perform updates and maintenance work. Again, thank you for upholding that emphasis.


Pharmcophoric point extractor

Description

All code for ligand chemical features was merged into a new class, PharmacophoricPointExtractor.
New generator functions to yield molecules from smi, txt and mol2 files.
New class to perform faster virtual screening using the multiprocessing module.
New unit tests and some were updated
All pharmacophore files were moved to a new folder.

Status

[ ] Ready to go

Codecov Report

Merging #50 (eaa4475) into main (566279d) will increase coverage by 0.78%.
The diff coverage is 74.10%.


Infinite Depth Issue

Hi Bolian, after my training using your code, I tested my model and found there is infinite depth resulting from the moving objects.

I wonder if this infinite depth as "holes" often appears in your experiments and how to alleviate such an issue.
Thanks.

Dear @feipan664
Thanks very much for pointing out this problem. We have been noticed it since the official TensorFlow repository. It is an unsolved issue, so I would like to highlight this issue as "help wanted" to encourage anyone who might consider using this repository to work together.  Soon I am going to share our experiences and thoughts about what measures did alleviate it (more like workrounds) and what measures may possibly alleviate it.

The "blackholes" issue is an intrinsic problem for unsupervised depth estimation methods whose main supervision is based on image reconstruction. While objects having the same velocity with the camera, they seems not changing in the adjacent frames and behaves like faraway things. Then infinity is an easy solution for the depth network to reconstruct images properly. "Depth from videos in the wild" does impose additional degrees of freedom to counteract the issue, but unfortunately its depth prediction still has the same tendency. I am tweaking the loss components to see if I can find any effective way to deal with the issue.

Dear @feipan664
It probably would take longer to tweak losses and do experiments to check their effects. I would like to share the workaround we found. You may try to remove all the lines containing "2011_09_29_drive_0004_sync_02" & "2011_09_29_drive_0004_sync_03" in train_files.txt. We found the "blackholes" issue trained on KITTI is mainly due to the dynamic objects in this scene.

Thank you so much for the answer. I will definitely check them out. I have also read recent works and this problem looks like very hard to deal with.

Dear @feipan664 Thanks very much for pointing out this problem. We have been noticed it since the official TensorFlow repository. It is an unsolved issue, so I would like to highlight this issue as "help wanted" to encourage anyone who might consider using this repository to work together. Soon I am going to share our experiences and thoughts about what measures did alleviate it (more like workrounds) and what measures may possibly alleviate it.

Hello,dear Chen,heve you ever try this work(struct2depth),they use mask_rcnn and try to modeling 3D object motion and ego-motion to solve this moving object problem,and depth_from_videos_in_wild code is also based on this,did it works?I'm trying to test it now.


CAMEL-20270: Introduce JBang plugins

Description

Introduce plugin mechanism to modularize Camel JBang
Add new plugin sub-commands (add, get, delete) to manage plugins
Plugin configuration is stored to user home directory
Load plugin commands on demand
Create 1st plugin for Camel K and move commands into separate Maven module camel-jbang-plugin-k

PR introduces plugins for Camel JBang where each plugin is able to add sub-commands to the CLI. The advantage of having a plugin in a separate Maven module is to modularize the Camel JBang CLI and avoid stuffing all dependencies and functionality into camel-jbang-core.
The PR adds a 1st plugin module camel-jbang-plugin-k that manages integrations on Kubernetes (the commands have been added to Camel JBang recently).
Users need to enable/add plugins with the new command camel plugin add. The plugin usually gets a name, a command and a dependency (Maven GAV) that is added on demand when the user calls a plugin command. Once the plugin is added for the environment all commands of the plugin get listed in the CLI and users can just call the sub-commands like every other sub-command.
The plugin config holding all enabled plugins for the environment is stored in the user.home directory (.camel-jbang-plugins.json).
Users are able to list enabled plugins with camel plugin get (--all option to list all supported plugins in the Camel project).
camel plugin get --all

Supported plugins:

 NAME     COMMAND  DEPENDENCY                             DESCRIPTION
 camel-k  k        org.apache.camel:camel-jbang-plugin-k  Manage Camel integrations on Kubernetes

camel plugin delete will remove a plugin from the current environment so that the plugin commands are no longer listed in the CLI and users will not be able to call the plugin`s commands any more.
Follow-up actions

Update the documentation to describe new JBang plugin mechanism
Extract more plugins from current Camel JBang sub-commands (e.g. sbom, hawtio, jolokia)

Target

[x] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking
Relates to CAMEL-20270
Apache Camel coding standards and style

[x] I checked that each commit in the pull request has a meaningful subject line and body.
[x] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

I didn't see whether there was some updates to the documentation - that is something we would need down the road when we have more plugins and users need to install them.
Also it may be possible to install multiple at once
camel plugin add foo bar cheese
or maybe you want all out of the box
camel plugin add --all


Extending events

Is it possible to have marker events on a clustered marker? I.e "mouseover", "mouseout", etc. Currently only a click event is supported.
Not sure what it would take to port, but markerclustererplus had this functionality.
Thanks.

In the renderer you can add events as desired.
const renderer = ({ count, position }) => {
  const clusterMarker = new google.maps.Marker({
                    label: { text: String(count), color: "white", fontSize: "10px" },
                    position,
                    // adjust zIndex to be above other markers
                    zIndex: Number(google.maps.Marker.MAX_ZINDEX) + count,
                });
  clusterMarker.addListener('click', someClickHandler);

  return clusterMarker;
}


Decode request to json if Content-Type of request is application/json

Thank you @cve

Hmm, I see that for /register it works, but for /login the Symfony's security component takes action which does not decode appliaction/json request... one of workarounds to this is using https://github.com/qandidate-labs/symfony-json-request-transformer I see

So... maybe a better aproach will be leave that responsibility (decoding appropriate request format [there is not only application/json but xml etc...]) outside of this bundle and note that in readme?
FOSRest has it's own decoder, ApiPlatform doesn't (I'm not sure), so for cases like that I can use https://github.com/qandidate-labs/symfony-json-request-transformer third party transformer...

@cve JSON is a very common format for getting a JWT so IMHO we should be able to ensure that a request content of this type will be decoded as well as a form-data one.
There is a work in progress for providing a Symfony built-in JSON authentication listener (see https://github.com/symfony/symfony/pull/18952) which should greatly help on this in the future.
But for now, I'm 👍  for ensuring this by our side.
Adding qandidate/symfony-json-request-transformer as a dependency is not be a problem to me, I'm just afraid that it converts all incoming requests (included the ones out of this bundle), that may be too much.
A solution would be to require it then override it with a check such as
public function onKernelRequest(GetResponseEvent $event)
{
    if (0 === strpos($event->getRequest()->attributes->get('_route'), 'rch_jwt_user')) {
        return parent::onKernelRequest($event);
    }
}

to ensure only the content of requests concerning a route of this bundle will be converted.
What do you think? Would you be motivated to work on this? so you can btw revert what has been done here, plus you deserve the credits of the feature.

I'm 100% agree with you. I will try to make changes later

Just a thing thought, could you open your PR on the 1.x branch? So I can tag a minor v1.3.1 then merge it into the master branch. Thank you in advance! Looking forward a PR from you.

Ok,
I'm try to install 1.3 from https://github.com/chalasr/rchjwtuserbundle/tree/1.x guide but it seems that this Readme is for 2.0 branch and I have errors during install it on fresh symfony 2.8

Could you please open an issue to develop what kind of problem you encounter?

Sorry, correct me if I'm wrong... I understood that I should make above changes (listener etc.) to the 1.x branch... So I'm clone that branch and try to install on the fresh Symfony 2.8 and I have errors... this is the issue I've created about it #11


Deployment to Github Pages issue: Cannot match any routes

Versions
Angular CLI: 1.5.5
Node: 8.9.4
OS: win32 x64
Angular: 5.0.0
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

@angular/cli: 1.5.5
@angular-devkit/build-optimizer: 0.0.34
@angular-devkit/core: 0.0.22
@angular-devkit/schematics: 0.0.38
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.8.5
@schematics/angular: 0.1.8
typescript: 2.4.2
webpack: 3.8.1

Error: Uncaught (in promise): Error: Cannot match any routes
I'm trying to deploy my Angular SPA app to github pages using this [/angular-cli/wiki](https://github.com/angular/angular-cli/wiki/stories-github-pages .)
I run this command ng build --prod --output-path docs --base-href learningangular
it reroutes my app from https://alamgirqazi.github.io/learningangular to https://alamgirqazi.github.io/learningangular/learningangular/
and I get the above error. I've added more detail here https://stackoverflow.com/questions/48436223/angular-cli-deploy-to-github-pages-issue-error-error-uncaught-in-promise-er#
Here's the link to the app: https://alamgirqazi.github.io/learningangular

in my case it works with leading/trailing slash in the base-href
ng build --prod --output-path docs --base-href /PROJECT_NAME/

It's better to change the documentation(https://github.com/angular/angular-cli/wiki/stories-github-pages),
from
ng build --prod --output-path docs --base-href PROJECT_NAME

to
ng build --prod --output-path docs --base-href /PROJECT_NAME/

This is already fixed in the docs on angular.io. Thanks for pointing this out!


Ubuntu 24.04 not an option

Describe the bug
The installer asks for the linux version to be able to install additional requirements.
I'm running Ubuntu 24.04 LTS. which is not an option. As it´s the current LTS release, I believe it should be.
Probably the logic behind could be the same as for Ubuntu 23.10. With a new LTS release they typically don't change that much from the previous non-LTS one.

You can use my alpha version: https://github.com/cryinkfly/Autodesk-Fusion-360-for-Linux#-getting-started


wrong direction of arrows in vector field generated by streamplot

Hi, I am trying to visualize the vector field of the SIS model, and here is what I found that might be an issue:
on the left side of the figure, the arrows point northwest should point the southwest (like the red rectangle I draw)

here is the code
using CairoMakie
let
β=0.5
μ=0.1
PP_SIS(S,I) = Point(-β*S*I+μ*I,β*S*I-μ*I)
fig = Figure(resolution = (1400, 800), fontsize = 20)
ax1 = fig[1, 1] = Axis(fig, xlabel = "S", ylabel = "I", title = "phase portrait of SIS model", aspect = 1, backgroundcolor = :black)

streamplot!(ax1, PP_SIS, 0..1, 0..1, colormap = Reverse(:plasma),
	  gridsize= (20,20), arrow_size = 20)

fig
end

This should also be fixed by https://github.com/JuliaPlots/Makie.jl/pull/1352

Ah thanks, you're probably right. If this does persist on master/post v0.15.2 we can reopen this.


e2e: retrieve the idea.log file for failing runs for extension logs

we should provide the idea.log file as an artifact if the run is failing

haven't seen the need lately, closing for now


Added login feature

Pull Request Test Coverage Report for Build 132

34 of 65 (52.31%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.8%) to 81.616%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/logic/parser/LoginParser.java
7
11
63.64%

src/main/java/seedu/address/logic/parser/ManagerParser.java
19
26
73.08%

src/main/java/seedu/address/logic/parser/EmployeeParser.java
0
20
0.0%

Totals

Change from base Build 130:
-0.8%

Covered Lines:
2020

Relevant Lines:
2475

💛  - Coveralls


swiProlog: 9.1.21 -> 9.2.5

Description of changes
This upgrades SWI-Prolog to the latest stable. See the changelog for more details.
Note that it appears to have been established practice in this package to import a development version of the SWI-Prolog source, though I haven't been able to find an indication that this was intentional. I am intentionally upgrading to a stable version instead, with the hope that from now on, this package will track SWI-Prolog stable.
SWI-Prolog stable versions only receive backported fixes after release, whereas in the development versions, anything goes, including backwards-incompatible breaks with previous versions of the same minor number. This means stable is suitable for doing backports to released versions of nixpkgs, while the development version is not.
I left some comments in the package source to point this out, in the hope that future importers will not accidentally pull in a dev version.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

LGTM, but please tag the person who made the switch to swipl-devel and see what the reason was for doing that

@barakber according to git history you originally upgraded swi-prolog from 7.6.4 to 8.1.4 back in 2019 (990acf7025a32c5f235a58468487d54fd511dbc8), along with various improvements to the packaging. This switched the version swi-prolog in nixpkgs tracks from stable to devel.
In this PR I am going back to tracking stable. I think it makes more sense to track stable, as this allows more easy backporting of fixes. Since we're going from 9.1.21 to 9.2.5, this should be a mostly clean upgrade path for people (as clean as it can be from a development version anyway).
I wasn't really sure why this change to use devel was made in the first place. Do you remember? And do you have objections to this switch back to stable?

Why not both? A swiprolog-devel for those who like it, and swiprolog as the stable.

I'm fine with both. But I feel strongly that the default should be stable.
Also, I don't think this PR has to be held up until that is implemented. Nobody really loses anything in this move to stable. People who might have relied on versions under development in 9.1 will find these features stabilized in 9.2. Luckily 9.1.21 is pretty late in the dev cycle so it should be pretty close already.

You are correct.


Find a better way for Protractor to sync with Angular

In order to inject mock modules into Angular before it bootstraps, Protractor currently does this:
Protractor changes window.name before navigating to an Angular site. Angular sees this name, halts bootstrap. After Angular injects the mock modules, Angular resumes bootstrap. This would be fine, except window.name isn't persistent across location.assign().
The way protractor is syncing with Angular implies the following:

protractor cannot implement back or forward
if another site redirects to Angular, mock modules will not be injected unless the test reloads Angular (i.e. if non-Angular log in page redirects to Angular app)

Need to think of a new communication protocol between Angular/protractor

Removing needs investigation, since this is in icebox.

Example of issues that this causes: https://github.com/angular/protractor/issues/2461

Closing in favor of https://github.com/angular/protractor/issues/3374


Switched from etcd2 to etcd3

Hey, this pull request not ready for merge. The main problem I got not solved right now is that all etcd3 clients needs to be connected to successfully start the etcd cluster. This means kubernetes will just come up when the etcd cluster is ready, which is currently not the provisioning approach you implemented. Maybe can you help me a bit with the Vagrantfile to first setup the etcd cluster, then deploy Kubernetes including the health checks?
Closes #245

Thank you for the review. I implemented your notes and it works now out of the box.


catdvi: fix generated code in configure script; fix darwin

add an int return type to generated main function to fix implicit int error
fixes #272384
Result of nixpkgs-review pr 272405 run on x86_64-linux 1

4 packages built:

catdvi
catdvi.dev
python310Packages.recoll
recoll (python311Packages.recoll)

build failures are unrelated -- failing with Project ERROR: Unknown module(s) in QT: webenginewidgets
Result of nixpkgs-review run on x86_64-darwin 1

2 packages failed to build:

python310Packages.recoll
recoll (python311Packages.recoll)

2 packages built:

catdvi
catdvi.dev

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1288

thanks!


Duplicated trade leading to wrong volume data

When the backfill Zenbot is executed several times in a row, some trades are duplicated.
In some cases, trades are fetched from exchange when they already exists in database. The direct effect is that OHLCV periods computed from this have incorrect volume data.
Volume data from "pre-roll" period can't be trusted.
It affects both the trade command and the sim command
How to reproduce
At 10h00, start a zenbot trade
At 10h05, stop it.
At 10h10, start it again.
Volume values from 10h00 to 10h05 are twice as much the real values.
Code details
There is a mechanism in backfill.js that is supposed to handle this case: It uses some marker objects, (stored in the resume_markers mongo table) to register timespan of registered trades. Unfortunately, it doesn't works.
There is a lot of case to handle (backfill over a timespan with zero, one or several markers. the markers can be fully included in the selected timespan, or only partially).
The current code don't handle any of this and is poorly designed.

I will not fix this myself: I have a workaround for my custom code and so I'm not impacted by this.
This issue is here to let people know, and give some hints for the ones willing to address the problem.

This is supposed to be handled by unique IDs on trades in the format of binance.ETH-USDT-9438710239, which trade.js forgets to assign. Fixed in #2517.


[Event Request] Codeunit 80 "Sales-Post" - procedure "PostSalesLine" - event "OnPostSalesLineOnBeforeInsertInvoiceLine" - Add new Parameters

Due to handle our own logic, we need additional parameters for the standard event "OnPostSalesLineOnBeforeInsertInvoiceLine" in Codeunit 80 "Sales-Post", procedure "PostSalesLine".
OLD CODE:
if SalesHeader.Invoice then
    if SalesHeader."Document Type" in [SalesHeader."Document Type"::Order, SalesHeader."Document Type"::Invoice] then begin
        OnPostSalesLineOnBeforeInsertInvoiceLine(SalesHeader, SalesLine, IsHandled);
	if not IsHandled then begin

NEW CODE:
if SalesHeader.Invoice then
    if SalesHeader."Document Type" in [SalesHeader."Document Type"::Order, SalesHeader."Document Type"::Invoice] then begin
        OnPostSalesLineOnBeforeInsertInvoiceLine(SalesHeader, SalesLine, xSalesLine, SalesInvHeader, SalesCrMemoHeader, IsHandled); // start kvspsa - Added new parameters
	if not IsHandled then begin

OLD PUBLISHER:
[IntegrationEvent(false, false)]
local procedure OnPostSalesLineOnBeforeInsertInvoiceLine(SalesHeader: Record "Sales Header"; SalesLine: Record "Sales Line"; var IsHandled: Boolean)
begin
end;

NEW PUBLISHER:
[IntegrationEvent(false, false)]
// start kvspsa - New parameters added
local procedure OnPostSalesLineOnBeforeInsertInvoiceLine(SalesHeader: Record "Sales Header"; SalesLine: Record "Sales Line"; var xSalesLine: Record "Sales Line"; var SalesInvHeader: Record "Sales Invoice Header"; var SalesCrMemoHdr: Record "Sales Cr.Memo Header"; var IsHandled: Boolean)
// stop kvspsa
begin
end;

Hi @StHillmann . I have a question about parameters you asked to add. Why do you need SalesCrMemoHeader on before insert of sales invoice header? The same question is relevant for #6564. In these two cases you asked for equal set of parameters for different types of insertions?

Hi @RomanZanizdra you are totally right!
Our background processing has been one procedure which takes both parameters, but I already have divided it up.
@AlexanderYakunin
Please remove "SalesCrMemoHeader" as parameter and sorry for this...

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Completions ignores sortText

VSCode Version: master
OS Version: ---

Building TabNine we encountered a bug in completions, where sortText is ignored if any CompletionItem does not contain sortText attribute. This causes the IDE to totally ignore the sortText in the ordering, forcing the sort algorithm to fallback to label only.
Steps to Reproduce:

Use suggestions from a source that provide sortText (such TabNine) & a source that does not provide sortText (such the built in lsp).
Completions suggestions's ordering will be based on the label and not on the sortText.

I traced the bug to this line:
https://github.com/microsoft/vscode/blob/master/src/vs/editor/contrib/suggest/suggest.ts#L274
The problem is that it is checked that sortText is present on both CompletionItems, breaking the sort functionality if any single item does not implement sortText.

Does this issue occur when all extensions are disabled?: Yes

@jrieken I'll be more than happy to create a PR if it'll be merged

If it's a good PR it'll be merged. Tho, I wonder if there was a specific reason for why things are they way they are. I could have also sworn that I have fixed this already... Needs a short trip down memory lane before making this change 🤔

Cool, let me know if you want me to provide a fix. Will ping every day. Thanks!

Found the issue: https://github.com/microsoft/vscode/issues/66109. So, this is actually fixed but in a sneaky way, e.g by always filling in the sortText-property (b4ead4e). Leaves the question what you are actually seeing? Do you have some simple steps to reproduce this?

This is an example:

We give our suggestions sortText of zeros (1st suggestions gets "0", 2nd "00" etc.; I also tried other characters combinations, none seem to change something) but our suggestions still only shown after some of the results coming from the lsp (not all of them, only those with the same Range of matching characters).
You can install TabNine and test it yourself.
This is where the sortText is set: https://github.com/codota/tabnine-vscode/blob/master/src/provideCompletionItems.ts#L95

Check this out: https://github.com/microsoft/vscode/blob/cb1dce0ef30d48c4259eb7d0a923926b3e6e16af/src/vs/vscode.d.ts#L3855-L3863
Basically, what is says (tries to say) is that once a prefix exists (ht in your sample) the match quality of that prefix and a suggestion overrules all sortText.

Unsure if you use filterText. With that property you can provide a string that matched against said prefix. Assuming in your sample you set it to html then ranking should be different. Also: you can hit cmd+/ to toggle explain mode - the details part of the suggest widget will then show some debug info, like so:

Thanks! That seem to make things much better. But I'm still confused about other ordering as such:

Hard to say. What does the explain widget say?

cmd+/ didn't trigger it. Do I need some special version of vscode for it?

I think you need to trigger it first on an item with details, like realPath or so and then go up


Content dimensions depending on barOnCls

I make a gap/padding in the content (using additional inner wrapper for that as suggested here) to accommodate scrollbars, but only if they are present (barOnCls is added), so in my css I add padding depending on presence of barOnCls. But after initialization the clipper height is set without this padding taken into account. I suspect (but not 100% sure yet), this is because content dimensions are read while this padding is not yet applied (barOnCls is added after dimensions are read)
What should be a proper solution for this: modifying the code so that dimensions a read after barOnCls is applied, or the gap for scrollbars should be added by different means (i.e. on the outer clipper element, because obviously scroller element can't take any padding)?
P.S.: I see this specifically with horizontal scrolling, not sure if it affects vertical scrolling as well, but I think it might not make any problem there

Yep, clipper can't have padding either because of OS X FF.


Fail building docker image on jetson nano

Message error is:
standard_init_linux.go:228: exec user process caused: no such file or directory
Jetson 4gb
Error is only when use FROM opendatacam/opendatacam-darknet-base:v1.0.0-odc-Yolo-v3-nano in Dockerfile
with FROM resinplayground/jetson-nano-cuda-cudnn-opencv:v0.2-slim(last versions)  work ok.

I assume you are building the master branch?
The current master does not build because of signing key changes on NVIDIA side, See https://github.com/opendatacam/opendatacam/issues/541. However that change is already fixed in development, so I suggest you try to build from development branch.
If you think this may be something else, please provide more logs. Thank you.

Yes with master branch, now i have tried in the dev branch and work ok with FROM opendatacam/opendatacam-darknet-base:v1.0.1-odc-Yolo-v3-nano


Incorrect selection change event kind when clicking on selection

Environment

VSCode Version: 1.20.0
OS Version: macOS 10.13.3
Does this issue occur when all extensions are disabled?: Yes

Steps to Reproduce
Create an extension to log selection change events:
import * as vscode from 'vscode';

export function activate(context: vscode.ExtensionContext): void {
    context.subscriptions.push(
        vscode.window.onDidChangeTextEditorSelection(function(e) {
            console.log('Selection changed:', e.kind);
        })
    );
}

Create a selection with the mouse, and then click somewhere within the selection. The selection change event that gets logged is of kind 3 (Command), but I would expect it to be of kind 2 (Mouse). Though it's not really documented exactly what the kinds mean, it seems like the Command kind is reserved for selection changes that come from executeCommand or editor.edit. See screencast:

The API more or less forwards what the editor announces...

I believe in this case, the dnd functionality (which is in /contrib/) kicks in, so the selection changes indirectly via an editor mouse down listener. The dnd code calls back into the editor, and the editor marks the reason as api...

Duplicate of #30230


ES AppTable.TaskInfo.NumOfChildTasks incremented but never decremented

Imported from trac issue 243.  Created by sseeger on 2018-08-14T19:36:23, last modified: 2019-07-03T12:48:08

Trac comment by jhageman on 2019-07-03 12:48:08:
Moved unfinished 6.6.1 issues to next minor release


M3-5180: React Query for Domains - Remove Redux, Allow Search, Attach to Ticket

Description 📝

Removes domains from Redux store
Connects React Query store to search
Make support ticket entity attachment pull from React Query store for domains
Makes the Domain Records page use React Query when updating the Domain
Removes functionality to convert domain groups to tags for legacy Classic Manager customers

How to test 🧪

Test Search
Test attaching Domains to support tickets
Test Domain details
Test creating, editing, and deleting domain records

Nicely done @bnussman! Seeing this never gets old.
I went through the flows you listed and things looked good, and also confirmed that all of the Cypress tests are passing (minus one unrelated image test that would be fixed by merging in the latest changes from develop).
The only thing I've noticed is some Jest errors from SearchLanding.test.tsx. They're not causing the tests to fail, but they do appear to be new errors (I'm not seeing them on develop).
yarn test Search/SearchLanding.test

@jdamore-linode Great find. Thankfully those errors are intentional. Previously, I mocked some errors with the MSW when testing Object Storage. I'll update the MSW to not throw these errors.


Increment version for storage releases

Increment package version after release of Azure.Storage.Blobs

API change check
API changes are not detected in this pull request.

/check-enforcer override


Scrolling inside different containers

Right now React-Scroll-To only supports scrolling on the window, but there are use-cases where a user might want to scroll inside different containers (say a div).
Proposed Idea:
Add a new prop to <ScrollTo> to accept a 'scrolling location'. This would look like:
<ScrollTo container={divRef}>
    {scroll => ... }
</ScrollTo>

Where the container could be a Ref passed in. If nothing is given in the container prop, default to using window.

Not really sure this is possible, but an API I would love to have is something like this:
<ScrollArea width={x} height={y} render={
  (left, top) => <Stuff />
} />

So that Stuff could be a big inner component which will get masked to a the dimensions provided by the ScrollArea
Ignoring any one of the dimension expands the ScrollArea to the width of its children

I like where this is going, it'd be great for the component to inherently know its scroll area without defining it. But, a few issues come up:

How would I then scroll using window? We could wrap the whole app in a ScrollArea and pass down the action, but seems messy for this use-case
Since the child is a function, it has to be evaluated before the DOM object can be accessed, or a proper height can be calculated.
ScrollArea would have to wrap the children in a div to account for an array of children. Not a problem, but changes behavior of the existing component.

Wrapping the whole site too with the component, though might look messy seems to be an elegant way to use the same API for all use cases. We can forget about the lower level abstraction that touches window & only bother about ScrollArea and its rather small API surface.

@ganderzz I threw together this Proof of Concept in CodeSandbox.
The API looks something like, which uses context:
const App = () => {
  return (
    <ScrollTo>
      {scroll => (
        <div>
          <button onClick={() => scroll(0, 100)}>Scroll down</button>
          <ScrollToContainer style={containerStyle}>
            <LongBaconIpsumText />
          </ScrollToContainer>
          <ScrollToContainer style={containerStyle}>
            <LongBaconIpsumText />
          </ScrollToContainer>
        </div>
      )}
    </ScrollTo>
  );
};

I tried an example without context and only used containerRef. The issue is that <ScrollTo /> would not rerender when the containerRef was finally available, and containerRef would always be null.
Let me know what you think of this.

@newyork-anthonyng I'm really liking it! A few things to think about:

What about calling the "ScrollToContainer" component ScrollArea.

Had to add a removeScrollToContainers function. If we wrap a ScrollToContainer in a toggle, the component will keep adding itself on every mount. Made a example here. (Removing ComponentWillMount in the ScrollToContainer will console.log the growing list)

@ganderzz Good point 👍
I created a new Pull Request to increase the code coverage to 100%. Once that's merged, I can try putting a Pull Request in for this issue.

... On adding the ScrollArea to ScrollToHOC:
I could maybe see this going two ways:

What if internally ScrollToHOC uses the render prop ScrollTo. This would allow any low-level functionality be located in ScrollTo, and have ScrollToHOC automatically consume any new features
Creating a new component/class that handles the scrolling/active scroll areas in an abstract way that both the ScrollToHOC and ScrollTo consume. Will need to do some testing, but this may be ideal as the dependency structure would be more tree-like, instead of the bulk of the functionality being silo'd in ScrollTo

@ganderzz
To me, it seems like the first option uses composition, and the second option uses inheritance. I remember reading this article from the React docs. It seems to be leaning more in favor of using composition. Thoughts?

@newyork-anthonyng My wording was off, I was thinking of it more like reusable functions instead of an actual class hierarchy. But thinking about it more, it would require a single global instance of a ScrollArea array.
I'm in favor of option 1 due to a single global object sounding like a bad idea. Option 1 would better encapsulate the ScrollArea array into each instance of ScrollTo and ScrollToHOC. Playing around with the idea, here's an example of option 1.

@ganderzz The sample you provided in Code Sandbox looks good 👍
I won't have time to work on a pull request for this though 😥

@newyork-anthonyng No problem, always good to have a second pair of eyes on things. I'll get a PR made up, and close this issue out!


add discovery host as sni host to xds-grpc cluster

Please provide a description for what this PR is for.
To enable SNI/TLS based routing to function properly, for example:
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
  name: istiod3
  namespace: istio3
spec:
  selector:
    istio: ingressgateway
  servers:
    - port:
        number: 15012
        protocol: tls
        name: TLS-XDS
      tls:
        mode: PASSTHROUGH
      hosts:
      - "istiod3.mycluster.appdomain.cloud"
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
    name: istiod3-vs
    namespace: istio3
spec:
    hosts:
    - istiod3.mycluster.appdomain.cloud
    gateways:
    - istiod3
    tls:
    - match:
      - port: 15012
        sniHosts:
        - istiod3.mycluster.appdomain.cloud
      route:
      - destination:
          host: istiod
          port:
            number: 15012

cc @howardjohn @irisdingbj @nmittler @frankbu
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@linsun: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
4e44b9ca3947a586f0bc0d2d30dcc1bb9e7dcf55
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

added a rel note file.  I did test this with multiple sni hosts routing to different istiod.

@linsun: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
c6c49624073905fceb8961208d7af59c52d3fb90
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-telemetry-k8s-tests_istio

I mean: I wouldn't mind if you pick that as well ! Current status - envoy sending "Host: xds" is clearly wrong according the the http spec.

I would love to avoid changing xds-grpc as the cluster name and instead
just fix it in envoy: https://github.com/envoyproxy/envoy/issues/11254. It
is a breaking change and impacting telemetry and tooling to change the
cluster name.
On Tue, Jul 21, 2020 at 10:30 AM Costin Manolache<EMAIL_ADDRESS>wrote:

@costinm commented on this pull request.
Looks good - I was making a similar change to also properly set the Host:
header, for cases where the gateway is the one terminating TLS ( which has
a number of benefits ).
I'll update my PR - it's basically just using the discovery_host as the
cluster name instead of hardcoded xds.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/25691#pullrequestreview-452679147,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXJQBWP3ZV6KHGO24UTR4XGEDANCNFSM4PDTTI6Q
.

Sorry John - your concern are valid, and I no longer support changing the cluster name... But telemetry and tooling
may still be affected: to properly support external termination of TLS ( in LBs or other servers in front of Istiod )
we seem to need to switch to the google_grpc XDS implementation, which allows passing JWT tokens - but has
very different telemetry. It'll be an option only.


[Bazel] Broken format line in cc_grpc_library

As following:
bazel/generate_cc.bzl, line 44, column 13, in _strip_package_from_path
                fail("'{}' does not lie within '{}'.".format(path, label_package))

Indeed: https://github.com/grpc/grpc/blob/d19802d42c0f5bef6c375756bba9a941be9c2a7a/bazel/generate_cc.bzl#L44

Sorry, my bad. It's ok there.


Issue 22 support for tokenisation

Creating a new PR for this as I have merged it in my fork but our code is still referencing this codebase

I'm cool with that, I updated the README in my fork to give the team credit and such. I also plan to run that update to Omnipay 3. Killing this PR.


removed path attribute from class RoleSettings class

removed path attribute from class RoleSettings class in file repository_service_tuf_api/bootstrap.py
Closes #259

Thank you @deepgohil for your first contribution!
First, you should remember to sign off your commits (basically using the -s with the git commit command).
It is essential to agree with the project's DCO
Second, the error message you see Error: Process completed with exit code 255. here https://github.com/vmware/repository-service-tuf-api/actions/runs/4163657578/jobs/7205257315 doesn't give you the full information.
If you scroll above you will see that: test: FAIL ✖ in 39.48 seconds and you can check the tests run by clicking tox: test` button:

this will expand information about the executed tests.
There you can see errors in some tests.
Basically, the problems are that there are places where you create a RoleSettingsobject and try to access the path attribute which you just removed.
Try fixing this locally and if you want to run the tests locally you should have installed an environmental variable and installed our dependencies (see https://github.com/vmware/repository-service-tuf-api#installing-project-requirements) and then you can run tox -e test to check if you have fixed the tests.
If you still need help, don't hesitate to ask.

Also, I don't want to forget:
this change should be aimed against the feature/roles-simplification branch.
If you don't mind I will change the target branch because this is part of a bigger feature we develop in a separate branch.

I opened a similar pr to yours which you can use as help if you want:
https://github.com/vmware/repository-service-tuf-api/pull/262
Also, if you want to message as and get a faster response you an ask us at the [#repository-service-for-tuf](https://cloud-native.slack.com/archives/C047L55314N) channel on the CNCF Slack Workspace.

@deepgohil I just realized that I will need to remove the path attribute into another pr https://github.com/vmware/repository-service-tuf-api/pull/262.
The idea is that a new version of the CLI will be released and we need to be compatible with it.
I can help you with choosing another good-first-issue if you want.

Closing this pr (thanks @deepgohil again for your contribution), but I needed this change merged soon.
This pr is surpassed by #262


Investigate execution times of concurrent tests on VSAN

The actual (before #802) concurrent tests on CI usually takes around 80 seconds to complete in vmfs datastores. On vsan it can take anywhere between 80 to 3000 seconds to complete.
Investigation is needed to understand if some kind of adjustment is needed in the vmdk_ops service when running on VSAN, which may not be tuned for the rate of create/delete operations of the tests or if we are triggering background processess that slow's it down.

Pulling in this one to figure if there is an issue to address or not.

duplicate to #1057


ImportError: No module named caffe2.python

Hi folks,
I was able to build Caffe2 on Windows 10 with Anaconda2 without issues. When I tried to run the RNN sample from: https://caffe2.ai/docs/RNNs-and-LSTM-networks.html
I see this error:
python char_rnn.py --train_data shakespeare.txt
Traceback (most recent call last):
  File "char_rnn.py", line 8, in <module>
    from caffe2.python import core, workspace, cnn, utils
ImportError: No module named caffe2.python

I've copied the caffe2_pybind11_state.pyd file into the Anaconda2\DLLs folder.
What did I miss?
Thanks for any suggestions.
Wes

Seems like a pythonpath issue - you should set your pythonpath to where caffe2 is built/installed. This link would be helpful:
http://stackoverflow.com/questions/3701646/how-to-add-to-the-pythonpath-in-windows-7

I have this issue too. Here's what I did:

Copy caffe2_pybind11_state.pyd to 'C:\Python27amd64\DLLs'
In python interpreter:

>>> import sys
>>> sys.path

Verify 'C:\Python27amd64\DLLs' is in that path
Interpreter:
>>> import caffe2
Result:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: No module named caffe2

Ah, okay, Yangqing is right. The following interpreter line resolves the issue:
>>> sys.path.append('C:\\Users\\<username>\\Source\\Repos\\Python\\caffe2\\build')
import caffe2
Works.

I have this issue.the folder 'C:\Users\\Source\Repos\' is empty. what do you think its mean?


vignette's aren't visible in dark color theme

Vignette fonts are not visible in R Help Pane when using a dark color theme:

What's the best solution here? Since vigenttes and object help share the same R Help window, I assume they are both going to have same font negative operation applied to them when they're used with a dark color theme, but since vignettes are a bit more complicated this doesn't always work out, as above.
Thanks!

Pane is Web browser and is styled via CSS files, there is no font or color reversal. Styling files are in Program Files\Microsoft Visual Studio 14.0\Common7\IDE\Extensions\Microsoft\R Tools for Visual Studio\Themes.

Which specific search leads to this page? Thanks

So it appears that vignettes include HTML encoded CSS that overrides theming
<link href="data:text/css;charset=utf-8,body%7Bbackground%2Dcolor%3A%23fff%3Bmargin%3A1em%20auto%3Bmax%2Dwidth%3A800px%3Boverflow%3Avisible%3Bpadding%2Dleft%3A2em%3Bpadding%2Dright%3A2em%3Bfont%2Dfamily%3A%22Helvetica%20Neue%22%2C%20Helvetica%2C%20Arial%2C%20sans%2Dserif%3Bfont%2Dsize%3A14px%3Bline%2Dheight%3A20px%7D%23header%7Btext%2Dalign%3Acenter%7D%23TOC%7Bclear%3Aboth%3Bmargin%3A0%200%2010px%200%3Bpadding%3A4px%3Bborder%3A1px%20solid%20%23CCCCCC%3Bborder%2Dradius%3A5px%3Bbackground%2Dcolor%3A%23f6f6f6%3Bfont%2Dsize%3A13px%3Bline%2Dheight%3A1%2E3%7D%23TOC%20%2Etoctitle%7Bfont%2Dweight%3Abold%3Bfont%2Dsize%3A15px%3Bmargin%2Dleft%3A5px%7D%23TOC%20ul%7Bpadding%2Dleft%3A40px%3Bmargin%2Dleft%3A%2D1%2E5em%3Bmargin%2Dtop%3A5px%3Bmargin%2Dbottom%3A5px%7D%23TOC%20ul%20ul%7Bmargin%2Dleft%3A%2D2em%7D%23TOC%20li%7Bline%2Dheight%3A16px%7Dtable%3Anot%28%5Bclass%5D%29%7Bmargin%3Aauto%3Bmin%2Dwidth%3A40%25%3Bborder%2Dwidth%3A1px%3Bborder%2Dcolor%3A%23DDDDDD%3Bborder%2Dstyle%3Aoutset%3Bborder%2Dcollapse%3Acollapse%7Dtable%5Bsummary%3D%22R%20argblock%22%5D%7Bwidth%3A100%25%3Bborder%3Anone%7Dtable%3Anot%28%5Bclass%5D%29%20th%7Bborder%2Dwidth%3A2px%3Bpadding%3A5px%3Bborder%2Dstyle%3Ainset%7Dtable%3Anot%28%5Bclass%5D%29%20td%7Bborder%2Dwidth%3A1px%3Bborder%2Dstyle%3Ainset%3Bline%2Dheight%3A18px%3Bpadding%3A5px%205px%7Dtable%3Anot%28%5Bclass%5D%29%2C%20table%3Anot%28%5Bclass%5D%29%20th%2C%20table%3Anot%28%5Bclass%5D%29%20td%7Bborder%2Dleft%2Dstyle%3Anone%3Bborder%2Dright%2Dstyle%3Anone%7Dtable%3Anot%28%5Bclass%5D%29%20tr%2Eodd%7Bbackground%2Dcolor%3A%23f7f7f7%7Dp%7Bmargin%3A0%2E5em%200%7Dblockquote%7Bbackground%2Dcolor%3A%23f6f6f6%3Bpadding%3A13px%3Bpadding%2Dbottom%3A1px%7Dhr%7Bborder%2Dstyle%3Asolid%3Bborder%3Anone%3Bborder%2Dtop%3A1px%20solid%20%23777%3Bmargin%3A28px%200%7Ddl%7Bmargin%2Dleft%3A0%7Ddl%20dd%7Bmargin%2Dbottom%3A13px%3Bmargin%2Dleft%3A13px%7Ddl%20dt%7Bfont%2Dweight%3Abold%7Dul%7Bmargin%2Dtop%3A0%7Dul%20li%7Blist%2Dstyle%3Acircle%20outside%7Dul%20ul%7Bmargin%2Dbottom%3A0%7Dpre%2C%20code%7Bbackground%2Dcolor%3A%23f5f5f5%3Bborder%2Dradius%3A3px%3Bcolor%3A%23333%7Dpre%7Boverflow%2Dx%3Aauto%3Bborder%2Dradius%3A3px%3Bmargin%3A5px%200%2010px%200%3Bpadding%3A10px%7Dpre%3Anot%28%5Bclass%5D%29%7Bbackground%2Dcolor%3Awhite%3Bborder%3A%23f5f5f5%201px%20solid%7Dpre%3Anot%28%5Bclass%5D%29%20code%7Bcolor%3A%23444%3Bbackground%2Dcolor%3Awhite%7Dcode%7Bfont%2Dfamily%3Amonospace%3Bfont%2Dsize%3A90%25%7Dp%20%3E%20code%2C%20li%20%3E%20code%7Bpadding%3A2px%204px%3Bcolor%3A%23d14%3Bborder%3A1px%20solid%20%23e1e1e8%3Bwhite%2Dspace%3Ainherit%7Ddiv%2Efigure%7Btext%2Dalign%3Acenter%7Dtable%20%3E%20caption%2C%20div%2Efigure%20p%2Ecaption%7Bfont%2Dstyle%3Aitalic%7Dtable%20%3E%20caption%20span%2C%20div%2Efigure%20p%2Ecaption%20span%7Bfont%2Dstyle%3Anormal%3Bfont%2Dweight%3Abold%7Dp%7Bmargin%3A0%200%2010px%7Dtable%3Anot%28%5Bclass%5D%29%7Bmargin%3Aauto%20auto%2010px%20auto%7Dimg%3Anot%28%5Bclass%5D%29%7Bbackground%2Dcolor%3A%23FFFFFF%3Bpadding%3A2px%3Bborder%2Dradius%3A3px%3Bborder%3A1px%20solid%20%23CCCCCC%3Bmargin%3A0%205px%3Bmax%2Dwidth%3A100%25%7Dh1%7Bmargin%2Dtop%3A0%3Bfont%2Dsize%3A35px%3Bline%2Dheight%3A40px%7Dh2%7Bborder%2Dbottom%3A4px%20solid%20%23f5f5f5%3Bpadding%2Dtop%3A10px%3Bpadding%2Dbottom%3A2px%3Bfont%2Dsize%3A145%25%7Dh3%7Bborder%2Dbottom%3A2px%20solid%20%23f5f5f5%3Bpadding%2Dtop%3A10px%3Bfont%2Dsize%3A120%25%7Dh4%7Bborder%2Dbottom%3A1px%20solid%20%23f5f5f5%3Bmargin%2Dleft%3A8px%3Bfont%2Dsize%3A105%25%7Dh5%2C%20h6%7Bborder%2Dbottom%3A1px%20solid%20%23ccc%3Bfont%2Dsize%3A105%25%7Da%7Bcolor%3A%230033dd%3Btext%2Ddecoration%3Anone%7Da%3Ahover%7Bcolor%3A%236666ff%7Da%3Avisited%7Bcolor%3A%23800080%7Da%3Avisited%3Ahover%7Bcolor%3A%23BB00BB%7Da%5Bhref%5E%3D%22http%3A%22%5D%7Btext%2Ddecoration%3Aunderline%7Da%5Bhref%5E%3D%22https%3A%22%5D%7Btext%2Ddecoration%3Aunderline%7Ddiv%2Er%2Dhelp%2Dpage%7Bbackground%2Dcolor%3A%23f9f9f9%3Bborder%2Dbottom%3A%23ddd%201px%20solid%3Bmargin%2Dbottom%3A10px%3Bpadding%3A10px%7Ddiv%2Er%2Dhelp%2Dpage%3Ahover%7Bbackground%2Dcolor%3A%23f4f4f4%7Dcode%20%3E%20span%2Ekw%7Bcolor%3A%23555%3Bfont%2Dweight%3Abold%7Dcode%20%3E%20span%2Edt%7Bcolor%3A%23902000%7Dcode%20%3E%20span%2Edv%7Bcolor%3A%2340a070%7Dcode%20%3E%20span%2Ebn%7Bcolor%3A%23d14%7Dcode%20%3E%20span%2Efl%7Bcolor%3A%23d14%7Dcode%20%3E%20span%2Ech%7Bcolor%3A%23d14%7Dcode%20%3E%20span%2Est%7Bcolor%3A%23d14%7Dcode%20%3E%20span%2Eco%7Bcolor%3A%23888888%3Bfont%2Dstyle%3Aitalic%7Dcode%20%3E%20span%2Eot%7Bcolor%3A%23007020%7Dcode%20%3E%20span%2Eal%7Bcolor%3A%23ff0000%3Bfont%2Dweight%3Abold%7Dcode%20%3E%20span%2Efu%7Bcolor%3A%23900%3Bfont%2Dweight%3Abold%7Dcode%20%3E%20span%2Eer%7Bcolor%3A%23a61717%3Bbackground%2Dcolor%3A%23e3d2d2%7D" rel="stylesheet" type="text/css" />

Is this something acceptable? (Code colors are TBD). Plots are images and cannot be styled to dark.

Sorry for the late response (traveling overseas this week) and thanks for finding the cause. the fix looks great and loving the dark theme help pane!
For font colors, I think the white on dark for text is great, but for headings and links could you also choose lighter colors? Currently, Rmd's render section headings with a dark blue font which is very hard to read on a dark background:

Thanks again!

Final look

R Markdown is totally different thing, but we'll have a look.

Meanwhile you can adjust colors in Tools | Options | Environment | Fonts and Colors - look for Markdown... section

https://github.com/Microsoft/RTVS/commit/a096ce35a2a45519edbff31dcdb20e80071a36e3


Missed Contact status type error

The documentation states that the following state type should be provided when a contact is missed/ rings out:
ContactStateType.MISSED: Indicates the contact timed out before the agent could accept it.

However, when a contact is missed/ rings out I get the following state type instead:
ContactStateType.ERROR

Would someone be able to give me an idea of what I have done wrong?

Check the CCP logs in depth- The reason you missed the call may be the cause of error- commonly in our application of the CCP- the Agent's browser hosting the CCP doesn't have appropriate permissions when the contact is initialized, so the core app is looking for hardware and wasn't allowed it, even though earlier in the session, it did. Or something to that extent. Definitely need a CCP revamp that is better at managing some of the changes to browsers...
We have found setting your agent's chrome browser permissions to "allow" for mic, notifications, audio, background sync instead of "ask" or any of the other "option" settings, helps this. Any issues with not ringing or ringing late etc? Audio?

@oharez So these are the following scenarios I am testing:

Customer hangs up once it reaches the agent
Call rings out (after 20s) and assigned to the next agent (with visible CLI)
Call rings out (after 20s) and assigned to the next agent (anonymous number as it seems to behave differently)

All of the above states result in the contact state error, especially the customer hanging up scenarios, why would that throw an error. That should not result in a contact state error for the customer contact on the agent side.
Note: Anonymous does have more issues than just the above. It also forces the agent into an offline state after ring out due to some unhandled exception within the streams library itself, which does not provide any decent logging info due to the nature of the error.


Streamline optional Android build and centralize dependencies versions

This PR fixes compilation issues in the android app, simplifies the optional android build logic a little, and centralizes the versions of the project's dependencies in a Version.kt file in buildSrc.
We now assume that Android Studio is used for development in the phoenix-shared module (not IntelliJ).

Works on my devices :thumbsup:
Here's what I tested:

remove ~/.m2 directory
compile & run app on simulator
compile & run app on device


LLAMA2-7b PPL Scores

Hi, thank you for sharing this interesting and insightful work. I am reaching out to inquire about the perplexity scores for the LLAMA2-7b model as reported in Table 2. I have followed the evaluation script detailed in your repository to assess the model using the settings provided:
MODEL_NAME=meta-llama/Llama-2-7b-hf
CUDA_VISIBLE_DEVICES=2 python eval_lm.py \
    --model_name $MODEL_NAME \
    --dataset_path wikitext \
    --dataset_name wikitext-103-v1 \
    --dataset_split test \
    --output_dir $OUTPUT_DIR \
    --stride 32 \
    --max_length 1024

The results I obtained were as follows:

Word-level PPL: 15.3
Token-level PPL: 7.54

Additionally, with a stride of 4, I observed:

Word-level PPL: 15.31

I was wondering if you could provide some insight into the observed discrepancy with the reported scores. Is there a particular aspect of the evaluation setup that I might have overlooked, or are such differences within an expected range under certain conditions (e.g., GPU device)?

Maybe you confused Llama with Llama-2. The Llama-2 family doesn't include a 33B model.


Windows Server Best Practices module does load properly in PowerShell 7 P6

The BestPractices module can, apparently, be loaded using Import-Module (In P6). Using -Verbose shows the module at least partly loading. But no commands are available and Get-BPAModule does not run.
In earlier preview versions of PowerShell 7, This module did NOT load using Import-module OR using the earlier Import-WinModule. Now the module seems to load but is not available. And there are not any error/warning messages to guide the IT Pro. If anything, this is WORSE than the behaviour of using the older PSWIndowsCompatibility module.
Steps to reproduce
# Import the BestPracticesmodule
Import-module BestPractices   # produces no error
Get-Module                    # Produces no output
Import-module BestPractices -Verbose
VERBOSE: Loading module from path 'C:\Windows\system32\WindowsPowerShell\v1.0\Modules\BestPractices\BestPractices.psd1'.
VERBOSE: Loading 'TypesToProcess' from path 'C:\Windows\system32\WindowsPowerShell\v1.0\Modules\BestPractices\Microsoft.BestPractices.Types.ps1xml'.
VERBOSE: Loading 'FormatsToProcess' from path 'C:\Windows\system32\WindowsPowerShell\v1.0\Modules\BestPractices\Microsoft.BestPractices.Cmdlets.Formats.ps1xml'.
# Test it out
Get-BPAModel                  # produces no output (and no errors!)

Expected behaviour
The expected behaviour is that Get-BPAModel returns the BPA models available.
Actual behaviour
No error messages and Get-BPAModel returns no output (or errors).
Environment data
PS C:\Windows\System32> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.0.0-preview.6
PSEdition                      Core
GitCommitId                    7.0.0-preview.6
OS                             Microsoft Windows 10.0.17763
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

@anmenaga  can you take a look?

Interesting... Importing BestPractices module in Windows PS actually breaks Get-FormatData cmdlet:

This breaks WinCompat because Get-FormatData is used in implicit remoting call chain: Import-Module -UseWindowsPowerShell -> [implicit PS remoting code] -> Export-PSSession -FormatTypeName "*" -Session $s -> [in session $s] Get-FormatData -TypeName '*'
Another issue is that we are missing an error-reporting path in one case in implicit remoting code; this should be fixed independently.

I think the priority here is to fix it so that an error is reported to the user.

I'd LIKE the priority to be getting the module to work either natively or via the new compat logic.
But if that can't happen, then at least an error message back to the user.

In RC1, there is a new and different error message. The best practices module still does not load fully:
PS C:\Foo> # Import the BestPracticesmodule
PS C:\Foo> Import-module BestPractices   # produces no error
Import-Module: Failed to generate proxies for remote module 'BestPractices'. Running the Get-FormatData command in a remote session reported the following error: Unable to cast object of type 'Microsoft.PowerShell.Commands.Internal.Format.ControlReference' to type 'Microsoft.PowerShell.Commands.Internal.Format.ComplexControlBody'..

@anmenaga Should I expect that the fix for this would have to come via an update to Windows PowerShell?  Or do you foresee a workaround being implemented in PowerShell core edition?


Implement a function in the Viz object to export Crosstab data

We're leveraging the Embedding API to embed Vizs and programmatically retrieve the Viz information (filters, parameters, data, ...) and compare it to expected values.
The Embedding API exposes a Viz.displayDialogAsync function that displays an export dialog.
For the Crosstab export, this function displays a modal on top of the embedded Viz with a "Download" button.
We can't interact with this "Download" button programatically as it is in an iframe (CORS issues).
We don't have this issue with the "Export Data" dialog for example since it opens a new browser Window.
We'd like to have a "Viz.exportCrosstabAsync" function that would take an Excel/CSV parameter and automatically download the Crosstab data in the selected format, exactly like the exportImageAsync shortcut.

It would also be cool to add:

showExportPDFDialog
showExportCrossTabDialog
showExportDataDialog

Just discovered this is still a missing feature as of the 2022.4 release, and chiming in on this thread as I'd consider it a very notable missing feature that will significantly impact our plans to migrate to Embedding API.
V2 Feature
In the v2 JS API, the crosstab (csv) and Excel exports accept worksheetInDashboard as an argument in the function allowing you to specify which worksheet to export:
showExportCrossTabDialog(worksheetInDashboard)

Shows the Export Data dialog, which is currently a popup window. The worksheetInDashboard parameter is optional. If not specified, the currently active Worksheet is used. If there is no currently active Worksheet, the method throws an exception.

cf. https://help.tableau.com/current/api/js_api/en-us/JavaScriptAPI/js_api_ref.htm#viz_class
V3 Gap
In the v3 embedding API, the only available option to export data via CSV or Excel is to use
displayDialogAsync(dialogType: [TableauDialogType])

Display one of the export dialogs based on the dialogType parameter

cf. https://help.tableau.com/current/api/embedding_api/en-us/reference/interfaces/viz.html#displaydialogasync
& https://help.tableau.com/current/api/embedding_api/en-us/reference/enums/tableaudialogtype.html
This requires you to pass in "export-cross-tab".  When using that method, it displays this export dialog that surfaces all the options to the user, and limits the ability to customize the export experience that we've built using the v2 API:

Use Cases
We use the v2 method pretty widely across our app.  The most common use-cases are:

Creating a "hidden" export worksheet on a dashboard to allow for pre-defining columns and/or pre-aggregated data.  This can help prevent exposure of granular information that needs to remain inaccessible to users (i.e. PII data) while still allowing for exported ad-hoc data analysis.
Limiting the worksheets to improve the user-experience.  In a lot of cases, for example using a worksheet on a dashboard as a dynamic data-driven title: it doesn't make sense to export this title-page, but the naming convention may indicate to users that there is valuable data on that worksheet.  Instead of allowing users to export all worksheets, we can limit to a subset of worksheets that only contain relevant and usable data.

It is important to be able download a PDF/PowerPoint/Excel Crosstab without the Tableau dialog for a few reasons:

Web Portal design: The Tableau dialog seems out of place in a custom web portal design
White-labelling: This is an extension of the above point. Even though the Tableau logo is not on the dialog box the additional box breaks the flow but also highlights the presence of a different tool breaking the white-labelling possibility with Tableau.
Custom PDF/Powerpoint download flows: Some customers want to limit the PDF/Powerpoint download options to specific sizes so showing the dialog makes that difficult.
One click Excel downloads: Web developers I have worked with have preferred adding just one button to provide a one step download of data as Excel instead of having an intermediate dialog.

This gap was implemented in Embedding API release 3.6.0.


Decouple node and edge creation

Would it be possible/desirable to separate node and edge creation?
When we create a streamz pipeline we are creating a directed task graph. Currently this is done by creating nodes and simultaneously attaching them to other nodes (creating an edge). However, we may run into the situation where we want a bunch of nodes sitting in a library waiting to be used. This way users could mix and match how their nodes connected, essentially adding edges after the nodes were imported.

Can you motivate the reasons behind creating nodes before attaching them?
Why not create at the time of attachment?  I don't think I have an
intuition for your use case.
On Thu, Aug 17, 2017 at 5:40 PM, Christopher J. Wright <
<EMAIL_ADDRESS>wrote:

Would it be possible/desirable to separate node and edge creation?
When we create a streamz pipeline we are creating a directed task graph.
Currently this is done by creating nodes and simultaneously attaching them
to other nodes (creating an edge). However, we may run into the situation
where we want a bunch of nodes sitting in a library waiting to be used.
This way users could mix and match how their nodes connected, essentially
adding edges after the nodes were imported.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mrocklin/streamz/issues/56, or mute the thread
https://github.com/notifications/unsubscribe-auth/AASszKkmtAjb1NCUMCYlodIpgPb_JAufks5sZLNIgaJpZM4O62Np
.

I create a few nodes which map some function onto the data. Then I'd like to write 5 pipelines which use these nodes in different positions in the execution. Currently I'd need to duplicate the code for those nodes 5 times, since their upstream nodes would be different and that is bound at instantiation. With nodes created without a graph I could just import the nodes into the 5 pipelines and just plumb them together.

But the nodes would be the same objects, no?  Wouldn't they inadvertently
feed data between the pipelines?
On Thu, Aug 17, 2017 at 7:51 PM, Christopher J. Wright <
<EMAIL_ADDRESS>wrote:

I create a few nodes which map some function onto the data. Then I'd like
to write 5 pipelines which use these nodes in different positions in the
execution. Currently I'd need to duplicate the code for those nodes 5
times, since their upstream nodes would be different and that is bound at
instantiation. With nodes created without a graph I could just import the
nodes into the 5 pipelines and just plumb them together.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mrocklin/streamz/issues/56#issuecomment-323223998,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AASszNcJeESy1g9FsYdw-c5dqU-gA1wJks5sZNIGgaJpZM4O62Np
.

Maybe. That would only happen if I was running all the pipelines at once. One could run a deep copy on the node to make copies?

Is it costly to make a new node each time as is currently done?  What are the advantages of pre-instantiating these objects ahead of time rather than creating them on the fly?  So far in my toy examples I've only run into cases where recreating every time was free.

how does this differ from connect?
(https://github.com/mrocklin/streamz/pull/45)

Connect may have solved this issue, we just need to have a unique source for every incoming node to connect to.


Add copy buttons to each code snippet

I've attempted to solve this at #68, is it what you had in mind @zenorocha?

Merged ;)


Synth Grid Paste Bug-fix

Hey,
The synth grid was allowing a paste when no synth had been copied (eg. after program launch) leading to a reproduce-able crash every time. I added a little guard routine to the pasteSynth() method to prevent this.
Just thought i'd open a pull request to this issue i found and fixed, as a test to make sure i'm following the right code-upload-pull procedure before i get going pushing the other changes as individual branches.
Sorry i've been slow on this, am not on internet much at the moment.
Ok, all the best!

It might be that the wires don't get rebuilt because a Container has to figure out the number of inputs/outputs so in the first pass it might not know that number and it skips the connected wires.
This is a very good find and a good PR. :+1:

Ok, fixed it.
Your method worked very nicely. Thanks.

No, thank you for the bugfix. :)


Update docs

"npm run build-all" became invalid after the #203 PR was merged.

Intentional as we moved this to an ember-cli addon.
There may be work to create a custom build pipeline to support globals for backwards compat.
Cc @stefanpenner To hear his thoughts

I have very little  motivation to support globals, but if that is a popular request we can easily support it, but wrapping the output with it's own local loader and re-exporting the things we need for globals.

Err, sorry.
I think we spoke about bringing over something comparable to what liquid fire does to handle custom builds.  It doesn't involve globals :)

I think we spoke about bringing over something comparable to what liquid fire does to handle custom builds. It doesn't involve globals :)

ah ok


Adjust 3d to new data structure

Codecov Report

:exclamation: No coverage uploaded for pull request base (curved-mesh@072825b). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             curved-mesh       #9   +/-   ##
==============================================
  Coverage               ?   92.06%
==============================================
  Files                  ?      124
  Lines                  ?    12874
  Branches               ?        0
==============================================
  Hits                   ?    11853
  Misses                 ?     1021
  Partials               ?        0

Flag
Coverage Δ

unittests
92.06% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 072825b...f2d95f0. Read the comment docs.


Compositor doesn't support wlr-output-management-unstable-v1

I'm trying to run the C rewrite in Ubuntu Disco. For Sway and wlroots, I'm using the ppa here https://launchpad.net/~samoilov-lex/+archive/ubuntu/sway. I've compiled the kanshi binary locally in a docker container.
Upon running,  kanshi exits with:
compositor doesn't support wlr-output-management-unstable-v1

config:
{
    output "Sharp Corporation 0x1476 0x00000000" mode 3840x2160 scale 2 position 0,0
}

This needs the latest sway commit. wlr-output-management-v1 has been added recently to sway.
If this is an issue, you can stick to the Rust version temporarily.

Thank you, I can live without for a bit no probs.