Class-style TypedDict variables with NotRequired annotations are treated as Required

Environment data

Language Server version: v2022.3.1
OS and version: Windows 10, 19043
Python version (& distribution if applicable, e.g. Anaconda): 3.7.7

Expected behaviour
Using NotRequired should work in class-style type definitions just as it does in alias style.
class FooClass(TypedDict):
    x: NotRequired[int]
FooAlias = TypedDict('FooAlias', {'x': NotRequired[int]})

Actual behaviour

Logs

// Lots of searching for typesheds and analyzing files. No errors.
(20292) Background analysis message: getDiagnosticsForRange

Code Snippet / Additional information

class FooClass(TypedDict):
    x: NotRequired[int]
FooAlias = TypedDict('FooAlias', {'x': NotRequired[int]})
foo: FooClass = {} # Error
foo: FooAlias = {} # No Error

Since this is a core type checker issue, I've created a tracking bug in the pyright issue tracker.

I'm not able to repro the problem. There is an error reported for the code sample, but it's not related to Required or NotRequired. It's because you have redeclared the symbol foo.
Here's an updated code sample with no errors reported.
from typing import TypedDict
from typing_extensions import NotRequired

class FooClass(TypedDict):
    x: NotRequired[int]

FooAlias = TypedDict("FooAlias", {"x": NotRequired[int]})
foo1: FooClass = {}
foo2: FooAlias = {}

@erictraut
"Fixed" example, hopefully :T
utils.py
try:
    from typing import TypedDict, Required, NotRequired
except ImportError:
    from typing_extensions import TypedDict, Required, NotRequired

test.py
from utils import TypedDict, NotRequired

class FooClass(TypedDict):
    x: NotRequired[int]

FooAlias = TypedDict("FooAlias", {"x": NotRequired[int]})

foo1: FooClass = {}
foo2: FooAlias = {}

This is expected behavior. The problem is that you're re-exporting Required and NotRequired from a local file (utils.py). These are special forms that pyright (the type checker that underlies pylance) needs to handle early in its analysis, so it can't deal with this form of aliasing. You must import them directly from typing or typing_extensions if you want them to work with pyright.

@erictraut - But why does it want with the construction style and break only with definition style?

Because the class style makes use of type annotations and the function style doesn't. Those are very different code paths — both within the Python interpreter and in a static type checker.
I really with that the function style was never introduced, and I recommend against using it. Stick with the class style for best results. The same is true for dataclass, Enum, and NamedTuple definitions.


feat: added FileSystemWatcher for pyproject.toml

Closes #122

@microsoft-github-policy-service agree

@xytian315 Sorry for the delayed response on this. I have refactored the code to be simpler for our case.

Closing as stale, we can re-open this, if you want to continue working on this.


Add KServe support

This PR adds support to KServe inference services (IS) by setting a TrustyAI service as an InferenceLogger for KServe IS.
If IS is part of a ModelMesh deployment, the behaviour is the same as previously.
KServe and ModelMesh IS are differentiated by checking the IS's serving.kserve.io/deploymentMode: ModelMesh annotation.
Other changes

Dependencies updated to better align with the ODH operator
Updated KServe API from v1alpha1 to v1beta1

/retest

/test trustyai-service-operator-e2e

/retest

/retest


Update coverage badge

The Coveralls link was using the previous org, 5afe, instead of safe-global.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 92.497%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
4324

Relevant Lines:
4575

💛  - Coveralls


Unit tests

Fixes https://issues.redhat.com/browse/CCXDEV-5407

[x] Decouple components to comply with SRP
[x] For new (semi-) pure components, create basic unit tests 🛸

@AllenBW, could you have a quick look at it? 🐱

Codecov Report

Merging #21 (2b5e3d7) into master (4031c4d) will increase coverage by 20.91%.
 Consider uploading reports for the commit 2e37ccc to get more accurate results

@@             Coverage Diff             @@
##           master      #21       +/-   ##
===========================================
+ Coverage        0   20.91%   +20.91%
===========================================
  Files           0       19       +19
  Lines           0      263      +263
  Branches        0       65       +65
===========================================
+ Hits            0       55       +55
- Misses          0      185      +185
- Partials        0       23       +23

Impacted Files
Coverage Δ

src/Components/Breadcrumbs/index.js
0.00% <0.00%> (ø)

src/Components/Cluster/index.js
0.00% <0.00%> (ø)

src/Components/ClusterHeader/index.js
0.00% <0.00%> (ø)

src/Routes.js
0.00% <0.00%> (ø)

src/Services/SmartProxy.js
0.00% <0.00%> (ø)

src/Components/Breadcrumbs/Breadcrumbs.js
100.00% <100.00%> (ø)

src/Components/Cluster/Cluster.js
100.00% <100.00%> (ø)

src/Components/ClusterHeader/ClusterHeader.js
100.00% <100.00%> (ø)

src/AppEntry.js
0.00% <0.00%> (ø)

src/App.js
0.00% <0.00%> (ø)

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4031c4d...2e37ccc. Read the comment docs.

will merge it now as I need to proceed and don't want to create git conflicts; if something looks suspicious, we can tackle it in a separate PR 🥷
btw, the enzyme library looks a bit hard to use with the functional components wrapped by contexts / using context hooks inside. I am looking towards https://testing-library.com/docs/react-testing-library/intro/ in the future instead


Feature:  http proxy

Can we expose the operation of setting system proxy in the nextjs-chatgpt-app project? Currently, i found that the traffic is not going through the system-level proxy.

Can you give more details about this? (I don't have a system proxy, and I assumed it would be transparent).
What is it, on which OS, and how should it look like on the UI?

Just like this function :
const HttpProxyAgent = require('https-proxy-agent');

const proxy = 'http://<IP_ADDRESS>:7890';
const agent = new HttpProxyAgent(proxy);

post fetch can use this proxy。Of course, it does not need to be placed in the ui interface, but can be placed in the configuration file

I'm looking into this. There are 2 featches: 1 from the UI to the /pages/api/chat.ts (aka 'frontend to backend' of this app), and another one from the backend to the OpenAI Chat API (https://api.openai.com/v1/chat/completions).
Do you need both to go through the proxy, or just one of them? If it's just the backend->openAI, I think I have some quick fix for it.
Do you need UI to configure the proxy, or is it okay to have runtime configuration (e.g. if an environment variable, such as HTTPS_PROXY_URL is set)?

I  want to backend->openAI，now I implement it by calling the interface I wrote myself~~

Do you deploy the backend yourself? If so, I can then update the backend->OpenAI to be like this:
// Set up the proxy agent if the environment variable is set
  const proxyAgent = process.env.HTTPS_PROXY ? new HttpsProxyAgent(process.env.HTTPS_PROXY) : null;

  const res = await fetch('https://api.openai.com/v1/chat/completions', {
    headers: {
      'Content-Type': 'application/json',
      Authorization: `Bearer ${apiKey}`,
    },
    method: 'POST',
    body: JSON.stringify(streamingPayload),
    agent: proxyAgent, // Add the proxy agent to the fetch options
  });

I.e. if you set HTTPS_PROXY (or something similar) when running the App, the request backend->OpenAI shall go through that. What do you think?

i hava try this yesterday,but failed。But you can try it

Totally see the issue. The backend is deployed to the Edge runtime (faster), but node modules such as 'https-proxy-agent' are not supported. Possibly I can just tell to not use the Edge runtime (and instead use a normal backend) when one defines the HTTPS_PROXY env var.
This will ensure that we run a normal backend, and you'll get full nodejs package support.

The code to fix it (in chat.ts), would be:
//noinspection JSUnusedGlobalSymbols
export const config = process.env.HTTPS_PROXY ? {} : { runtime: 'edge' };

OK  thank you very much, I'm not very good at nodejs ~

Can you push this feature to the master

Cannot yet. I tried to just switch the 'runtime' type from 'edge' to 'nodejs', but unfortunately the full handler (and streaming response functions) will need to be rewritten.

Will it be supported in the future？

I will not write this feature in the near feature, but if someone contributes the code I'll merge the PR.

I will not write this feature in the near feature, but if someone contributes the code I'll merge the PR.

Okay, I'll close this issue first

This issue should be reopened to prevent duplicates IMO.

Reopening. Please note that at the moment, Vercel Edge functions do not seem compatible with proxy solutions.
Which means to either move to the slower 'node runtime', or not supporting proxy. This is something that should be handled by a fork maybe?
Or looking for creative solutions.


Revert "feat: add bootcamp cost calc guide"

Reverts freeCodeCamp/freeCodeCamp#35278

@raisedadead I think it's just a lint error.  If I fix the css, it all seems fine.  Should I put that in a PR?

Sure, go for it. But the previous PR that got merged by @QuincyLarson also adds unwanted files to the repository. I'll let you decide and make the changes.

Oh, okay. If you don't want the files, it seems pointless to fix them.


Set-AuthenticodeSignature's HashAlgorithm should default to SHA256

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce

Obtain a code signing cert and assign it to $Certificate
Sign a file using that certificate Get-ChildItem dbatools.dll -Recurse | Set-AuthenticodeSignature -Certificate $certificate

That file is signed as SHA1

The docs say:
https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.security/set-authenticodesignature?view=powershell-7.2
-HashAlgorithm
Specifies the hashing algorithm that Windows uses to compute the digital signature for the file.

For PowerShell 3.0, the default is SHA256, which is the Windows default hashing algorithm. For PowerShell 2.0, the default is SHA1. Files that are signed with a different hashing algorithm might not be recognized on other systems. Which algorithms are supported depends on the version of the operating system.

Please please please also update the Microsoft.PowerShell.Security module that 5.1 uses, too. The world would appreciate this more secure default.
Expected behavior
Considering SHA1 is deprecated, insecure and not the expected algorithm per the docs, the `HashAlgorithm` should default to SHA256 instead of SHA1

Actual behavior
The default is SHA1

Error details
No response
Environment data
Name                           Value
----                           -----
PSVersion                      7.2.4
PSEdition                      Core
GitCommitId                    7.2.4
OS                             Microsoft Windows 10.0.22000
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals
No response

Tentative PR to set the actual default to SHA256 https://github.com/PowerShell/PowerShell/pull/17560. Need to finalize the tests which I will look into tomorrow.

@WG-Security We agree that SHA-256 should be the default hashing algorithm.  This is technically a breaking change, but we feel it is minor and just needs to be documented.

@PaulHigin it’s already documented, it states it’s been SHA256 since PowerShell v3 but that is not the case.
https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.security/set-authenticodesignature?view=powershell-7.2

For PowerShell 3.0, the default is SHA256, which is the Windows default hashing algorithm. For PowerShell 2.0, the default is SHA1

While technically a breaking change I feel this should be back-ported as far as possible. SHA1 has been essentially unsupported for years now and PowerShell should be using SHA256 where possible.

Ok, so this is a bug fix.

And a security bug fix. Any chance we can get it fixed for 5.1 since it's in scope? 😇


Extract webpack alias configuration in one single file (#4961)

You can verify that:

Configuration files are created/modified
Aliases are working
App tests are working

Configuration files are created/modified
create a react app
yarn create-react-app my-app

verify the alias configuration
cat  my-app/node_modules/react-scripts/config/webpack.alias.config.js

the file should look like this:
'use strict';

// @remove-on-eject-begin
const path = require('path');
// @remove-on-eject-end

const aliases = {
  // @remove-on-eject-begin
  // Resolve Babel runtime relative to react-scripts.
  // It usually still works on npm 3 without this but it would be
  // unfortunate to rely on, as react-scripts could be symlinked,
  // and thus @babel/runtime might not be resolvable from the source.
  '@babel/runtime': path.dirname(
<EMAIL_ADDRESS>  ),
  // @remove-on-eject-end
  // Support React Native Web
  // https://www.smashingmagazine.com/2016/08/a-glimpse-into-the-future-with-react-native-for-web/
  'react-native': 'react-native-web',
};

module.exports = aliases;

now eject the project:
cd my-app && yarn eject

verify the alias config:
cat config/webpack.alias.config.js

it should be like this:
'use strict';

const aliases = {

  // Support React Native Web
  // https://www.smashingmagazine.com/2016/08/a-glimpse-into-the-future-with-react-native-for-web/
  'react-native': 'react-native-web',
};

module.exports = aliases;

Aliases are working
edit config/webpack.alias.config.js as follow:
'use strict';

const path = require('path');
const paths = require('./paths');

const aliases = {

  // Support React Native Web
  // https://www.smashingmagazine.com/2016/08/a-glimpse-into-the-future-with-react-native-for-web/
  'react-native': 'react-native-web',
  'my-alias' : path.resolve(paths.appSrc, 'my-package')
};

module.exports = aliases;

edit src/App.js as follow
import React, { Component } from 'react';
import logo from './logo.svg';
import './App.css';

import hello from 'my-alias';

class App extends Component {
  render() {
    return (

{hello}

            Edit src/App.js and save to reload.

            Learn React

    );
  }
}

export default App;

launch app
yarn start

you should see hello from my-package

App tests are working
Add alias to jest moduleNameMapper, editing the package.json file.
...
"jest": {
...
   "moduleNameMapper": {
      "^react-native$": "react-native-web",
      "^.+\\.module\\.(css|sass|scss)$": "identity-obj-proxy",
      "my-alias" : "<rootDir>/src/my-package"
    },
...
}
...

edit the app test src/App.test.js to verify the import resolve the aliased module
import React from 'react';
import ReactDOM from 'react-dom';
import App from './App';

it('renders without crashing', () => {
  const div = document.createElement('div');
  ReactDOM.render(<App />, div);

  expect(div.querySelector('#alias').textContent).toBe('Hello from my-package');

  ReactDOM.unmountComponentAtNode(div);
});

Run the test
yarn test

Hey! Thanks for this but we were going to fully merge our webpack config files soon.
If you'd like to work on this, feel free to send a PR with the files merged in their entirety.


Adding ability to generate any custom load shape with LoadTestShape class

Resolves https://github.com/locustio/locust/issues/1432
Adding a base LoadTestShape class for users to inherit in order to generate any user_count/hatch at 1 second resolution.

The the locustfile will be searched for a LoadTestShape class and used it if present
If present, this will run as a greenlet on the master and will continuously edit/update and optionally stop a running load test
Added 3 examples to show how it could be used, including a step-load type of test.
User and hatch rate in the UI is effectively ignored if a LoadTestShape class is present. Is that OK? Maybe we log a warning?
Exit with error if a LoadTestShape is present and a conflicting option is also specified as argument (users, hatch-rate or step-load)

Tests:

Update 4 tests to ensure the LoadTestShape class is not in user_classes (is this useful?)
Added test for a basic load test shape to ensure user_count/hatch_rate is changed throughout a test

To do:

Update docs

Initial testing looks good 🚀

Comments from @cyberw

I think the shape should be possible to have in a separate file

We'll need a couple really of good unit tests for this

Please give me suggestions if we need more tests as I'm not sure. This addition is simply editing a running test so much of this functionality should be covered already.

make sure there is no error for parameters (-u, -t etc) not being specified when there is a shape.

It will exit with an error.

correctly applying stop_timeout when ramping down
where new slaves are added during the test

The current behaviour here won't change?
Comments from @heyman

Unfortunately the stepload implementation isn't very good and I think it should be removed

We can replace the stepload code with the more general approach in this PR but also this PR is quite similar to the stepload implementation. Please clarify.

@cyberw I've addressed all your comments

@cyberw please re-review and when you're happy I'll work on docs

Looks great now. One question. How does it work when running web UI?
@heyman I'll probably merge this soon. Last chance to give your view. Step two could be to remove the step-load thingy if you agree this is better.

I still need to write docs and this is not a quick task IMO.

How does it work when running web UI?

Like I said in my opening comment, basically if a load test is started via the UI or API, the hatch rate and users is simply ignored. I think that's fair, if you're using a custom shape you will be a pretty advanced user anyway. I was thinking we could log a warning? What do you think?

I think logging a warning is fine (we should change that for -u/-r/-t parameters to make them behave that way as well tbh, but that may be a later thing)

OK I've included a few words in the log message to indicate the user_count/hatch_rate are ignored. I've also disabled editing a running shape test as this doesn't make sense.
I'll work on docs now.

OK I wrote a nice doc. Personally I think this feature deserves a mention in docs/what-is-locust.rst? But I'm obviously biased 😅
Anything else @cyberw?

Do I have to generate the API docs myself? Or is that done in CI or something?
$ make build_docs
sphinx-build -b html docs/ docs/_build/
Running Sphinx v2.4.3
Running `locust --help` command and storing output in /Users/max.williams/git/locust/docs/cli-help-output.txt
Generating RST table for Locust environment variables and storing in /Users/max.williams/git/locust/docs/config-options.rst

Extension error:
Could not import extension sphinx_search.extension (exception: No module named 'sphinx_search')
make: *** [build_docs] Error 2

I think it fits best in running-locust-without-web-ui.rst (but maybe it deserves a mention somewhere else too)
While you are adding the warning about ignoring -u/... when running with web ui, can you do it for non-custom-load-shapes as well? I've been annoyed by that many times + it is good to be consistent. Bonus points if you prefill the web ui form with the values from parameters instead of warning :)
Api docs are generated in CI (but if you install the readthedocs-sphinx-search package then you should be able to build them locally as well)

Regarding the docs, I think you can add it the same way as we did step load (a mention in the menu and a link in a suitable place, but keep it in a separate rst file). And then after a while, we remove step load :P Or maybe re-implement it using this method.

While you are adding the warning about ignoring -u/... when running with web ui, can you do it for non-custom-load-shapes as well?

There's not really a place for me to log warning if user/hatch is passed because these are ALWAYS passed. In master, locust will throw an exception or error if you don't set user/hatch when starting a test.

can you do it for non-custom-load-shapes as well? I've been annoyed by that many times + it is good to be consistent

I'm happy to add something but I'm not 100% sure what you mean. You mean a combination of command arguments and the UI? Or?
Here's what I have now in this PR, when running locust from command line:
    if shape_class and (options.num_users or options.hatch_rate or options.step_load):
        logger.error("The specified locustfile contains a shape class but a conflicting argument was specified: users, hatch-rate or step-load")
        sys.exit(1)

If you start a load test from the UI or API and there is a shape class in use then user/hatch is ignored and this is logged:
logger.info("Shape test starting. User count and hatch rate are ignored for this type of load test")

Editing a running load test with a shape class nothing but will log:
logger.info("There is an ongoing shape test running. Editing is disabled")

I've been annoyed by that many times + it is good to be consistent. Bonus points if you prefill the web ui form with the values from parameters instead of warning :)

If you create an new issue (it sounds separate) then I'll happily address it in a new PR 🙂

Looking really good now. Is it worth adding a test case for master/worker setup as well?

Is it worth adding a test case for master/worker setup as well?

OK @cyberw, done, with master + 3 workers scaling up, down and stop.
Are we ready? 😃 🙏

Looks amazing. One last question: what will happen if additional workers connect during the test? Will new users launch on the newly connected workers?
Tbh I'm not sure that is a use case we need to provide full support for, but some people argued differently (discussing global rps wait time I think). If it should work then maybe add it to the test? (adding a worker and then ramping up, making sure the users remain balanced after ramp up)

what will happen if additional workers connect during the test? Will new users launch on the newly connected workers?

This behaviour is unchanged by this PR. Users are rebalanced across all workers when new workers connect. Does a test of that functionality have a relation to this PR? There is already the test_rebalance_locust_users_on_worker_connect test

I was just thinking those two features might be worth testing together. Maybe not. Merging now! Thanks a bunch!

@cyberw when is a new release likely to be made?

Tonight if you’re lucky, tomorrow if you are not :)

You weren't lucky :(
Also, I think I'll want to hold of for some more merges (1468 in particular seems to be very close)

Also, can you make a PR that greys out the numbers that cant be edited in the UI when running with a shape?
Also, I noticed something weird. What is going on here: https://github.com/locustio/locust/blob/62fa37bb7e6b71ac31cb013d22a310b50daa9693/locust/shape.py#L34

Also, can you make a PR that greys out the numbers that cant be edited in the UI when running with a shape?

I can.

the variable run_time is never used...

That is intentional. The user has to override tick() anyway and this was to show that they most likely want to calculate the run time and that this is how you do it. All 3 examples have the same line (but it's used). I can remove it? Or add a comment?

👍
I think it makes sense to remove it, feels like it adds about as much confusion as it removes :) Also, pylance complains about it.

OK: https://github.com/locustio/locust/pull/1524


Disable direct access to Marathon/Chronos master nodes

@ankanm and @vmahedia Please review.

LGTM

LGTM


What is the right way of Implementing FormBuilderChoiceChip??

on select of particular chip I want to use the value for some calculation and display....
I tried to achieve it with onChanged method and it is not working, I am getting following error when I tried to implement it....
Couldn't infer type parameter 'T'. Tried to infer 'int?' for 'T' which doesn't work: Parameter 'onChanged' declared as 'void Function(T?)?' but argument is 'void Function(Object?)'. The type 'int?' was inferred from: Parameter 'options' declared as 'List<FormBuilderFieldOption>' but argument is 'List<FormBuilderFieldOption<int?>>'. Consider passing explicit type argument(s) to the generic.
FormBuilderChoiceChip(
              name: 'choice_chip',
              decoration: InputDecoration(
                labelText: 'Select an option',
              ),
              onChanged: (value){
                  print(value);
              }
              options: [
                FormBuilderFieldOption(
                    value: 'Test', child: Text('Test')),
                FormBuilderFieldOption(
                    value: 'Test 1', child: Text('Test 1')),
                FormBuilderFieldOption(
                    value: 'Test 2', child: Text('Test 2')),
                FormBuilderFieldOption(
                    value: 'Test 3', child: Text('Test 3')),
                FormBuilderFieldOption(
                    value: 'Test 4', child: Text('Test 4')),
              ],
            )

Please suggest how to get selected chip value...

Hi @rmControls ,
I just tried your code-snippet, and everything is working fine on package version6.0.1.
Please, provide which version of the package that you are using,
and provide the code you want to implement and is failing.

I am also using version 6.0.1...
flutter version 2.2.2
android studio 4.1.0

This still an issue?


debugFeatures crashes on opening debug tab

Windows Terminal version
1.11.3471.0
Windows build number
19043.1415
Other Software
not relevant, crashing on opening any tab.
Steps to reproduce

enable "debugFeatures": true, via edeting the config json
restart windows terminal to activate it
open a tab while holding left and right alt (on my keyboard - azerty be period layout, right alt is altgr no idea if that matters)

does not matter if the tab you open is from the dropdown list or via the "+" button. opening it via the shortcut ctrl+shift+t does nothing.
Expected Behavior
openes a new tab with a debug window. or at least does not crash.
it wasn't quite clear if release builds of wt can even enable this feature.
Actual Behavior
hangs for a few seconds, the crashes wt and all open tabs. (program just closs).
does work in current preview of wt.
eventlog shows this, dunno if there's any other debugging output to provide:
Faulting application name: WindowsTerminal.exe, version: 1.11.2112.13011, time stamp: 0x61b80d0f
Faulting module name: Microsoft.Terminal.Control.dll, version: 1.11.2112.13011, time stamp: 0x61b80b7f
Exception code: 0xc0000005
Fault offset: 0x000000000000fa8e
Faulting process id: 0x6674
Faulting application start time: 0x01d81582c31ccf1f
Faulting application path: C:\Program Files\WindowsApps\Microsoft.WindowsTerminal_1.11.3471.0_x64__8wekyb3d8bbwe\WindowsTerminal.exe
Faulting module path: C:\Program Files\WindowsApps\Microsoft.WindowsTerminal_1.11.3471.0_x64__8wekyb3d8bbwe\Microsoft.Terminal.Control.dll
Report Id: 698fd48e-3ac8-4f83-8a76-294d506043c9
Faulting package full name: Microsoft.WindowsTerminal_1.11.3471.0_x64__8wekyb3d8bbwe
Faulting package-relative application ID: App

site note, also tested it with no "debugFeatures": true,
then alt left+right & mouseclick just open a new sidetab.

@inphobia "debugFeatures": true is a hit-and-miss with each release. It works with the Windows Terminal Preview Version: 1.12.3472.0

The only issue is debug pane not closing when exiting the tab, even though it exits with code zero:

It could be by design!

Yea this was fixed in #11445, which is in v1.12.2922.0+. /dup #11282


User Profile Issues with slug and medium

@Bhumi101097 When a user profile is updated, the slug is changing automatically if the display name is changed. The slug should not change after a user is created unless the user modifies it.
@fyrepenguin I am not able to replicate this issue, is this still an issue?

So, if 'user' is the slug that I have before and I update my profile, it becomes 'user-1' and if I update the profile again, it becomes 'user-1-1' and so on, instead of keeping it just as 'user'


Make all credential types mockable

While reading through https://github.com/Azure/azure-sdk-for-net/issues/20911, I noticed that only some credential types in the Azure Identity library expose protected, parameterless constructors and are therefore mockable. This is a tracking issue to update the affected credential types accordingly, to adhere to Azure SDK for .NET mocking guidelines.

@scottaddie:  Can you help us understand for what the scenarios are where mocking TokenCredential is not sufficient?   There's no API in any Azure SDK package that is credential based but does not take TokenCredential.

@jsquire We have customers who want to test code that didn't accept/use the TokenCredential abstraction and instead accepted the derived type. I linked to an issue in my original comment that shows an example.
My bigger concern is that we're inconsistent across credential types.

To be clear, I'm not opposed to the requested change, just trying to understand the scenario.


Information On Batch Size And Learning Rate

The discord link in the README does not work for me.
Do you have any information on what batch size or learning rate to use?  I could only find the max learning rate that was used in the paper.  Experimentally, I found that too small of a batch size seems to cause issues
What batch size and learning rate do you recommend and why?

The discord link is active.
You might probably need to join the HuggingFace discord server and the ML-4-AUDIO channel within it to gain access.
The discussion about learning rates could be found in the same thread.
The max learning rates used in the paper can be found from the very final page.
Regarding batch size, it highly depends on the GPUs being used and their memory capacity.
While higher batch sizes are recommended, one needs to experiment and fixate on the batch size which gives maximum utilization of GPU memory while not leading to out-of-memory issues.
It is to be noted that the batch size in the scripts of this repository refer to the per-GPU batch size.

Thanks for great work
Was the batch size mentioned here
https://huggingface.co/vasista22/whisper-kannada-medium
Total or per gpu?

@Theodotus1243 , the batch size for the above mentioned model is the per GPU batch size.

Thanks
How much gpus have you used, to properly reproduce your experience

@Theodotus1243 , 8 A-100 GPUs have been used for about a week to train the mentioned model

What can be the best parameters for A100 machine for finetuning large-v2??


[FR] Provide commands to download supporting files in tutorials

There are some changes required in order to run some of the tutorial notebooks that we provide via the Run in Google Colab and Download notebook options. Ideally we would provide cells directly in the notebooks that will download the necessary files into the user's working directory
Known issues:

Part II of the uniqueness tutorial requires a query_flickr.py script
The Open Images tutorial requires an open_images_eval directory to be downloaded from source

New notebook access options

This was addressed by moving the open images tutorial to https://github.com/voxel51/fiftyone-examples and updating the other notebooks to work when run as standalone notebooks.

This was addressed by moving the open images tutorial to https://github.com/voxel51/fiftyone-examples and updating the other notebooks to work when run as standalone notebooks.


Add scatterplot to alpha diversity app

This PR adds a scatterplot visualization to the alpha diversity app. When finished, this resolves #304
The approach was the same as that for boxplot, with one small addition. When the yAxisVariable is undefined, the logic called it a date. Since our computed variable is on the y axis, we are always in this case. So there were a few additions to handle this scenario.
At this point i've learned that this will get messier when we add the next app :) The reason is that the computation is going to specify two variables instead of one. Perhaps we could have the app tell the front end which variables it will override?

At this point i've learned that this will get messier when we add the next app :) The reason is that the computation is going to specify two variables instead of one. Perhaps we could have the app tell the front end which variables it will override?

Yeah, this is a big piece I've been trying to work out, although it's been several weeks since I thought about it.
One possibility is that all of our visualization components could optionally be told which variables to use for which axes. This moves the current visualization component logic of pulling variables off of the computation, to having the computation component pass in the variables to the visualization component.
The other piece of the puzzle is to have a utilize that takes the incoming variables and the input variables, and returns a normalized set of variables used by the app. This would allow us to get rid of code like this: https://github.com/VEuPathDB/web-eda/blob/3bf646f4f3a5e1d21897dc50a163d426c239e30a/src/lib/core/components/visualizations/implementations/ScatterplotVisualization.tsx#L743-L747

Thanks @dmfalke ! Since this branch is only getting merged in to initial-apps-run, do i need to do any versioning or additional organization-type things before merging?

Nope! Merge freely!


Installation Fails

Installation fails with the following error message:
Using: C:\Program Files\WindowsApps\yuk7.archwsl_<IP_ADDRESS>_x64__35zwpb4sx6e50\rootfs.tar.gz
Installing...
ERR: winapi error #2147746605
HRESULT: 0x8004032d
Press enter to exit...

Expected behavior:
The WSL Distro installs without error.
Enviroment:

Windows build number: 10.0.22635.2483
Security Software: Windows Defender
WSL version: WSL 2
ArchWSL version: <IP_ADDRESS>
ArchWSL Installer type: appx
Launcher version: 22020900

Anyone tracking this?

Same here, did you find any solution?

That's a hack though, not a solution - this issue should still be fixed within the ArchWSL software.

I installed wsl with wsl --install, which included Ubuntu.  I receive this error anyway.
Windows 11 Pro 22H2 build 22621.3155 under Parallels on a M1 Pro Macbook, both .zip and .appx install methods.


Fix webview background

This patch fix webview background and refactor ImageView background

@realitix could you explain what this problem looks like?
Also would appreciate it if you could share a minimal JSON example where this is failing so I can see what's wrong and we can use it as future reference.

Hi @gliechtenstein. It exactly the same problem as my last commit (about background image not displayed). You changed the section background to white so we can't see the background.
With this commit, I take a different approach, as soon as there is a background setted, the section background becomes transparent. It's more logical.
You can try with the instagram Json app: https://www.jasonbase.com/things/LELD.json

@realitix awesome. Just tested it out and looks great! Merged! Thanks :D
Just copy/pasting the JSON inline here for future reference:
{
  "$jason": {
    "head": {
      "title": "Pastel Sample",
      "description": "Gradient animation effect like Instagram",
      "actions": {
        "$load": {
          "type": "$render",
          "options": {
            "template": "body"
          }
        }
      },
      "templates": {
        "body": {
          "header": {
            "style": {
              "background": "rgba(0,0,0,0)",
              "color": "#ffffff"
            }
          },
          "style": {
            "color": "rgba(0,0,0,0)",
            "border": "none",
            "background": {
              "type": "html",
              "text": "<!DOCTYPE html><html><style>body{background:linear-gradient(135deg,rgb(113,23,234) 0%,rgb(234,96,96) 100%);animation: a 10s ease infinite;background-size:400% 400%;}@keyframes a {0%{background-position:0% 50%}50%{background-position:100% 50%}100%{background-position:0% 50%}}</style></html>"
            }
          },
          "sections": [
            {
              "items": [
                {
                  "type": "vertical",
                  "style": {
                    "align": "center"
                  },
                  "components": [
                    {
                      "type": "space",
                      "style": {
                        "height": "40"
                      }
                    },
                    {
                      "type": "image",
                      "url": "http://njaidswalk.org/wp-content/uploads/2015/02/instagram.png",
                      "style": {
                        "width": "50%"
                      }
                    },
                    {
                      "type": "space",
                      "style": {
                        "height": "40"
                      }
                    },
                    {
                      "type": "textfield",
                      "name": "username",
                      "placeholder": "Username",
                      "style": {
                        "placeholder_color": "rgba(255, 255, 255, 0.95)",
                        "color": "rgb(255,255,255)",
                        "background": "rgba(255, 255, 255, 0.2)",
                        "font": "HelveticaNeue",
                        "padding": "20",
                        "corner_radius": "5",
                        "width": "80%",
                        "height": "60",
                        "size": "14"
                      }
                    },
                    {
                      "type": "space",
                      "style": {
                        "height": "20"
                      }
                    },
                    {
                      "type": "textfield",
                      "name": "password",
                      "placeholder": "Password",
                      "style": {
                        "placeholder_color": "rgba(255, 255, 255, 0.95)",
                        "color": "rgb(255,255,255)",
                        "background": "rgba(255, 255, 255, 0.2)",
                        "font": "HelveticaNeue",
                        "padding": "20",
                        "corner_radius": "5",
                        "width": "80%",
                        "height": "60",
                        "size": "14",
                        "secure": "true"
                      }
                    },
                    {
                      "type": "space",
                      "style": {
                        "height": "20"
                      }
                    },
                    {
                      "type": "button",
                      "text": "Log In",
                      "style": {
                        "width": "80%",
                        "height": "60",
                        "border_width": "1",
                        "border_color": "rgba(255, 255, 255, 0.4)",
                        "color": "rgba(255, 255, 255, 0.5)",
                        "corner_radius": "5",
                        "size": "14"
                      }
                    }
                  ]
                }
              ]
            }
          ]
        }
      }
    }
  }
}


blog: k8s_custom_deploy intro post

Short post using a public Kafka Helm chart as an example.

i think this is ok if the goal is to get the announcement out and have a tutorial to point people at
i feel like the high-level narrative is a bit muddled. there's a lot about tilt internals. the example uses Helm. Other places talk about custom tools. I feel like it requires a lot of context to understand. but maybe that's ok.
@Chimney42 what do you think?

Good point.
I agree, this blogpost focuses a lot on the technical implementation and a bit too little on the problem it solves, for my taste.
I think, if we can add one or two sentences at the very beginning explaining the problem/use-case it would feel more rounded.

Thanks for the feedback, much appreciated!
I revamped the intro/context, let me know if it reads better now.
I played around with both Knative + OpenFaaS this morning -- I'm going to replace the example with OpenFaaS, which I think is better suited to this as it deploys stuff to K8s via its CLI but doesn't really have YAML template features like Helm/Knative. (Not totally true, but you need to use the operator to get OpenFaaS CRDs, which isn't the default afaict)

Okay, updated the example to use OpenFaaS which has a faas-cli deploy cmd that builds + deploys an image w/o a Dockerfile or any K8s YAML, so fits better into this pattern.
Also added a short section on using tilt get kapp to debug

Oh wow @nicks I totally missed tilt-dev/tilt-extensions#297 (knative extension) the other day.
I'm going to add a call-out to that at the end here!

blog/assets/images/k8s-custom-deploy/title.jpg

is this waiting on anything to go out?

is this waiting on anything to go out?

No, this should have gone out last week...my fault, I made tweaks from L's feedback and never pushed.
Publishing momentarily!


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative-sandbox/channel-wg-leads
/assign knative-sandbox/channel-wg-leads
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/pkg 517ef02...d82be48:
  > d82be48 Disable controllers using a command-line flag (# 2339)

/cherry-pick release-1.0


[zlib] Build error

Host Environment

OS: Windows 10
Compiler: revision
vcpkg-tool version: 2022-05-05-67e17c1782801cf481be9ac0b3765dff3e4bdeb8
vcpkg-scripts version: 193797555 2022-05-23 (10 hours ago)

To Reproduce
Steps to reproduce the behavior:
 ./vcpkg.exe install  --triplet=x64-mingw-dynamic --host-triplet=x64-mingw-dynamic assimp
Failure logs
Installing 3/13 zlib:x64-mingw-dynamic...
Building zlib[core]:x64-mingw-dynamic...
-- Using community triplet x64-mingw-dynamic. This triplet configuration is not guaranteed to succeed.
-- [COMMUNITY] Loading triplet configuration from: D:\vcpkg\triplets\community\x64-mingw-dynamic.cmake
-- Downloading https://github.com/madler/zlib/archive/v1.2.12.tar.gz -> madler-zlib-v1.2.12.tar.gz...
-- Extracting source D:/vcpkg/downloads/madler-zlib-v1.2.12.tar.gz
-- Applying patch cmake_dont_build_more_than_needed.patch
-- Applying patch 0001-Prevent-invalid-inclusions-when-HAVE_-is-set-to-0.patch
-- Applying patch debug-postfix-mingw.patch
-- Applying patch 0002-android-build-mingw.patch
-- Using source at D:/vcpkg/buildtrees/zlib/src/v1.2.12-f2d39b538c.clean
-- Configuring x64-mingw-dynamic
-- Building x64-mingw-dynamic-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:158 (message):
    Command failed: D:/vcpkg/downloads/tools/cmake-3.22.2-windows/cmake-3.22.2-windows-i386/bin/cmake.exe --build . --config Debug --target install -- -v -j13
    Working Directory: D:/vcpkg/buildtrees/zlib/x64-mingw-dynamic-dbg
    See logs for more information:
      D:\vcpkg\buildtrees\zlib\install-x64-mingw-dynamic-dbg-out.log

Call Stack (most recent call first):
  installed/x64-mingw-dynamic/share/vcpkg-cmake/vcpkg_cmake_build.cmake:112 (vcpkg_execute_build_process)
  installed/x64-mingw-dynamic/share/vcpkg-cmake/vcpkg_cmake_install.cmake:41 (vcpkg_cmake_build)
  ports/zlib/portfile.cmake:26 (vcpkg_cmake_install)
  scripts/ports.cmake:146 (include)

error: building zlib:x64-mingw-dynamic failed with: BUILD_FAILED
Please ensure you're using the latest port files with `git pull` and `vcpkg update`.
Then check for known issues at:
    https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+zlib
You can submit a new issue at:
    https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[zlib]+Build+error
Include '[zlib] Build error' in your bug report title, the following version information in your bug description, and attach any relevant failure logs from above.
    vcpkg-tool version: 2022-05-05-67e17c1782801cf481be9ac0b3765dff3e4bdeb8
    vcpkg-scripts version: 193797555 2022-05-23 (10 hours ago)

contents of vcpkg/buildtrees/zlib/install-x64-mingw-dynamic-dbg-out.log:
[1/18] cmd.exe /C "cd /D D:\vcpkg\buildtrees\zlib\x64-mingw-dynamic-dbg && "C:\Program Files\mingw-w64\x86_64-8.1.0-posix-seh-rt_v6-rev0\mingw64\bin\windres.exe" -D GCC_WINDRES -I D:/vcpkg/buildtrees/zlib/src/v1.2.12-f2d39b538c.clean -I D:/vcpkg/buildtrees/zlib/x64-mingw-dynamic-dbg -o D:/vcpkg/buildtrees/zlib/x64-mingw-dynamic-dbg/zlib1rc.obj -i D:/vcpkg/buildtrees/zlib/src/v1.2.12-f2d39b538c.clean/win32/zlib1.rc"
FAILED: zlib1rc.obj D:/vcpkg/buildtrees/zlib/x64-mingw-dynamic-dbg/zlib1rc.obj
cmd.exe /C "cd /D D:\vcpkg\buildtrees\zlib\x64-mingw-dynamic-dbg && "C:\Program Files\mingw-w64\x86_64-8.1.0-posix-seh-rt_v6-rev0\mingw64\bin\windres.exe" -D GCC_WINDRES -I D:/vcpkg/buildtrees/zlib/src/v1.2.12-f2d39b538c.clean -I D:/vcpkg/buildtrees/zlib/x64-mingw-dynamic-dbg -o D:/vcpkg/buildtrees/zlib/x64-mingw-dynamic-dbg/zlib1rc.obj -i D:/vcpkg/buildtrees/zlib/src/v1.2.12-f2d39b538c.clean/win32/zlib1.rc"
'C:\Program' is not recognized as an internal or external command,
operable program or batch file.
C:\Program Files\mingw-w64\x86_64-8.1.0-posix-seh-rt_v6-rev0\mingw64\bin\windres.exe: preprocessing failed.
ninja: build stopped: subcommand failed.

Additional context
Add any other context about the problem here, such as what you have already tried to resolve the issue.

'C:\Program' is not recognized as an internal or external command,
operable program or batch file.

Move your MinGW toolchain to a path without spaces. (It is not a vcpkg issue.)

@pattakosn
After moving MinGW toolchain to a path without spaces, is this issue solved?

mingw is installed on the top level (d:msys ), i do not know why this isC:\Program Files\mingw-w64\x86_64-8.1.0-posix-seh-rt_v6-rev0\mingw64\bin\windres.exe was used. I updated msys and vcpkg to the latest versions and retried in a msys mingw64 terminal and zlib compiled (but the package i wanted to installed again failed to install because an other package failed). I think this can close, I will submit a new one for the other one. Thanks

Thanks for your reply!


Fix nsp errors

Fix vulnerabilities reported in npm run nsp
 Name           Installed   Patched                        Path                                                                                More Info
 marked         0.3.6       >=0.3.9<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>                                                          https://nodesecurity.io/advisories/531
 mime           1.3.4       >= 1.4.1 < 2.0.0 || >= 2.0.3<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>                                      https://nodesecurity.io/advisories/535
 mime           1.3.4       >= 1.4.1 < 2.0.0 || >= 2.0.3<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>                                             https://nodesecurity.io/advisories/535
 fresh          0.5.0       >= 0.5.2<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>                                     https://nodesecurity.io/advisories/526
 closure-util   1.24.0      None<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>                                                                 https://nodesecurity.io/advisories/165
 static-eval    0.2.4       >=2.0.0<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>             https://nodesecurity.io/advisories/548
 static-eval    0.2.4       >=2.0.0<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>                                https://nodesecurity.io/advisories/548
 debug          2.6.8       >= 2.6.9 < 3.0.0 || >= 3.1.0<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>                                     https://nodesecurity.io/advisories/534
 debug          2.6.4       >= 2.6.9 < 3.0.0 || >= 3.1.0<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>        https://nodesecurity.io/advisories/534
 debug          2.6.4       >= 2.6.9 < 3.0.0 || >= 3.1.0<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS> https://nodesecurity.io/advisories/534

This will involve submitting PRs to our upstream dependencies as listed above. Most of the above don't really effect us because they are 'Denial of Service' attacks, and since we don't run a server it's not really an issue.
One that is probably worth looking at is
 Name           Installed   Patched                        Path                                                                                More Info
 closure-util   1.24.0      None<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>                                                                 https://nodesecurity.io/advisories/165

Although I've only had a quick look at the reported vulnerabilities.
Note that it'd be a good goal to resolve all the reported vulnerabilities, then we can add nsp check to our test runner.

After the merge of #253 the nsp report looks like this
 Name          Installed   Patched                        Path                                                                                More Info
 mime          1.3.4       >= 1.4.1 < 2.0.0 || >= 2.0.3<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>                                                                          https://nodesecurity.io/advisories/535
 parsejson     0.0.3       None<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS> https://nodesecurity.io/advisories/528
 static-eval   0.2.4       >=2.0.0<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>                                          https://nodesecurity.io/advisories/548
 static-eval   0.2.4       >=2.0.0<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>                                                             https://nodesecurity.io/advisories/548

karmadependencies can also be ignored as the aim is to move away from that test runner (see work started on branch https://github.com/maputnik/editor/compare/master...orangemug:fix/web-driver-tests-v6-circleci-config)

This should be a part of our general workflow instead of raised as a separate ticket. Closing issue


Added names for commands

I had this work already on another branch.

is this still due?

Yes, I believe it is still valid. They are just some improvements for the Circle CI build.


Fix pages with earlier revisions displayed

Acceptance criteria

[ ] https://bugzilla.mozilla.org/show_bug.cgi?id=1551999

Tasks
If relevant, you can make a checklist for tasks.

[ ] This is an incomplete task.

Parking this until we can determine a way to access the Prod DB for testing/dev purposes.

Time was not nice to us. It was a horrendously tricky thing to debug too. We can only hope for a Yari future where the source of truth is in git and not a RDBMS system that has some sneaky bug that we can never reproduce. Also, the underlying content has changed too much.


Ublacklist not working when I sign in my google account

Expected Behavior
Ublacklist functions normally.
Actual Behavior
Links are not blocked and the "block this site" is missing as well.
Steps to Reproduce the Problem

The extension working as intended when I do not login in my google account.

I login in.
Any functions of the extension disappear.

Specifications

OS: Windows 10
Browser: Chrome

Some solutsions I have tried but did not work:
Turning all other extentions off;
Only turn on ublacklist in incognito mode;
Cleared all caches and cookies;
Update/Reinstall Chrome (current Chrome Version 108.0.5359.125);
The extension worked fine before (to be exact, before google's new endless scrolling, but someone else has raised that issue) but now any funtions do not show up and I fail to find the reason. Would appriciate any solutions to this. Thanks in advance!

Came here to report the same thing. Almost had a heart attack when Quora reappeared in Google search results. Chrome 108.0.5359.125

Same behavior here: only works when signed out of Google. Using latest macOS & Firefox.

I just did a search for "blarg" while logged in and logged out. I compared the HTML for a search result provided by Google in both cases.
 Looking at the source code, that identifier is mentioned many times, so it seems like it might be the cause.

Thank you for your report. This issue will be fixed in v8.2.3.
Note: This issue only occurs when you are logged in and your language and region are set to English and US, respectively.


[Bug] Layer lock with tri layers

Describe the bug
The layer lock feature does not seem to handle layers that have been activated by update_tri_layer_state function. When one of the layers that are used to activate the tri layer is released the layer is moved back to the layer that is still being held. This makes it not possible to use a layer lock key to keep the layer on the tri activated layer.

Information
Here is the userspace code that I use to set the tri layers:
/**
 * @brief Tri state handler
 *
 * This handles activating a layer by holding down two other layers.
 *
 * @param state Curret layer state that will be updated
 */
layer_state_t layer_state_set_user(layer_state_t state) {
  return update_tri_layer_state(state, _RAISE, _LOWER, _ADJ);
}

@EdenEast thank you for reporting this. That's an interesting edge case.
Here is a method to lock the tri layer. In keymap.c, change layer_state_set_user() as
layer_state_t layer_state_set_user(layer_state_t state) {
  if (!is_layer_locked(_ADJ)) {
    state = update_tri_layer_state(state, _RAISE, _LOWER, _ADJ);
  }
  return state;
}

With tri layer "layer RAISE + layer LOWER = layer ADJ," what's happening is:

Layer switches are held to activate layers RAISE and LOWER.
update_tri_layer_state activates the tri layer ADJ.
Layer Lock is pressed while layer ADJ is active. The behavior of the Layer Lock key is to toggle the lock on the highest active layer, locking ADJ as intended. Layers RAISE and LOWER are not locked.
Layer switches for RAISE and LOWER are released. When this happens, update_tri_layer_state deactivates ADJ overriding the lock. Layer Lock notes that its lock was overridden and unlocks ADJ.

That last point is working as intended: Even when a layer is nominally "locked," it is possible and expected that other features may nevertheless turn the layer off. It is arguable a good thing that the lock is easily broken, since this avoids a situation where it is impossible to switch layers due to a layer being stuck on.
The solution is to adjust layer_state_set_user a bit to take into account when the ADJ layer is locked.

Thanks @getreuer, for the explanation and help with this. This solved my issue.

Wonderful, that's great to hear. Thank you for confirming the fix and reporting this issue!


getting exception on iterator

getting a crash here when the DB is open in 2 processes:
Thread 1: Fatal error: 'try!' expression unexpectedly raised an error: database is locked (code: 5)
extension FailableIterator {
    public func next() -> Element? {
        return try! failableNext()
    }
}

// when iterating
for row in try db.prepare(...) {
        }

SQLite blocks the file when you access it. You need to keep a global reference to the connection to avoid this kind of issues. On another matter of things, this repo is abandoned. The Author is involved in some kind of online teaching courses and even though he has activity on other repos he seems to not have the courage to announce he will not be continuing with this one. My advice is that you switch to another library like GRDB.

We merged a fix replacing the try! by a try?.

@NathanFallet I am still getting this issue on the latest release 0.14.1. It appears the try? you mention is still a try!, so this is still an issue.

@tw0po1nt We reverted this fix; as explained in #1075, you should use failableNext() and handle the error by yourself using a do/catch block. We cannot provide a default behavior (e.g. return nil) when an error occurs, it's up to you to choose what you want to do.


Add Radialstackdecoupler

Closes #2818

I've seen many mods use a similar folder structure and many of them switch from <modname>/GameData/<modname> to GameData/<modname>. With that in mind I'll suggest using "find"       : "GameData/M22Ind",.

@plague006 Done

:+1:


Mc/more noir syntax milestones

Description
Just making a PR so I can discuss some code with Jake and Kev. Please don't merge. It's broken.
Update. So this code got as far as:

Refactoring the filing structure
Attempting to make Set (and many other structs) generic over a Note
Attempting to make Map generic over any state variable type (Set is a state variable type, technically).

Jake is helpfully looking into why the compiler's unhappy at the mo :)
Edit: focus on the stuff in yarn-packages/noir-contracts/ - I didn't make most of the changes being shown in this diff - I built off one of Alvaro/Joss's branches (to inherit their latest example noir contract examples), and I think Github has become confused!!!
Checklist:

[ ] I have reviewed my diff in github, line by line.
[ ] Every change is related to the PR description.
[ ] I have linked this pull request to the issue(s) that it resolves.
[ ] There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
[ ] The branch has been merged or rebased against the head of its merge target.
[ ] I'm happy for the PR to be merged at the reviewer's next convenience.

Still want this open?

Let's keep the branch live, for Jake/Guillaume to reference (I'm not sure if they've had a chance to look yet), but we can close the PR, thanks for flagging.


Megatronlm client

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 5 committers have signed the CLA.:white_check_mark: janEbert:x: katrinklug:x: rrutmann:x: KlaudiaTH:x: ghstgsYou have signed the CLA already but the status is still pending? Let us recheck it.


feat: add product link in explore now btn

Fixed #20
Check (put an 'x' between the square brackets) everything which applies:

[x]  I have added the issue number for which this pull request is created.

@nitin-pandita, please let me know about this update.

Fixed #20
Check (put an 'x' between the square brackets) everything which applies:

[x]   I have added the issue number for which this pull request is created.

@nitin-pandita, please let me know about this update.

Great work @lionelritchie29 , thanks for contributing, I am merging your pull request now. Please leave a star to the repo for the new contributors to contribute


Move unit tests that depend on std_msgs out of rclrs into a separate package?

The rationale is that rclrs itself should not need std_msgs.

Duplicate of https://github.com/ros2-rust/ros2_rust/issues/237


[Wave Collect] New Resources to Publish

Publish Date - May 1
[DRAFT]

I'm ready to be assigned! I also requested access to the doc.

Thanks @ren-jones - I've shared the doc 😄

Ren's finished reviewing and I've replied to his comments. Looking good!

Not OD

@ren-jones and @kevinksullivan - just checking to see what this is waiting on. Do you need me to do anything?

I'm unassigning myself because I'm not part of bugzero at the moment and I don't think I can complete the next steps here. Feel free to ping me if you need something from me

Checking with Maddy on this one


Get all contacts that have pagination

Hi,
first of all thanks a lot for the library.
I'm trying to get all contacts by using this code. I have 3 contacts for testing purpose.
`$contactsResponse = $contactsEndPoint->get('all',null,$list_id,null,null,null,null,null,null,null,null,null,null,true,1);
    do {
        $contactsResponse = $contactsEndPoint->next();
        print_r(contactsResponse);
    } while ($contactsResponse);`

I'm getting 504 document error and i'm only get the first and the second contact but no on the third contact.
What is the correct way to use the next()?
Thanks a lot.

I believe you get an array from the get request that is paginated.  So if you have more than one page, you would need to call next().  But in your case, you just have 3 things, so not paginated.
So try printing the $contactsResponse before calling next.  That should contain an array that you can foreach through to get what you want.
Let me know if that does not work.

In the get i set the limit to 1, hoping to get the other 2.
if i set the limit to 500, i get all of the contacts without issue and there are no next.

This is the logic I am using for getting all contacts.  I wrote all this a while ago, so not sure how everything works!
// Get all current Constant Contact users
$contactsClient = new \PHPFUI\ConstantContact\V3\Contacts($client);
$list = $contactsClient->get(status: 'all', limit: 500);
do
	{
	foreach ($list['contacts'] as $contact)
		{
		print_r($contact);
		}
	$list = $contactsClient->next();
	}
while ($list);

You seem to have a lot of parameters on the get() call.  Maybe use named parameters?  You could easily be off by one.

Thanks a lot for the example, i will give it a test.
Do you have examples for adding contacts, subscribe, unsubscribe and re-subscibe as well?

Actually I do have some examples!  Check out my Bicycle Club Website repo: https://github.com/phpfui/BicycleClubWebsite2023
Looks like the good stuff is here: https://github.com/phpfui/BicycleClubWebsite2023/blob/master/App/Cron/Job/ConstantContactSync.php
Let me know if you get it working.

Thanks, I will look into it and let you know the results.

This is the logic I am using for getting all contacts. I wrote all this a while ago, so not sure how everything works!
// Get all current Constant Contact users
$contactsClient = new \PHPFUI\ConstantContact\V3\Contacts($client);
$list = $contactsClient->get(status: 'all', limit: 500);
do
	{
	foreach ($list['contacts'] as $contact)
		{
		print_r($contact);
		}
	$list = $contactsClient->next();
	}
while ($list);

You seem to have a lot of parameters on the get() call. Maybe use named parameters? You could easily be off by one.

i have tested using this code and set the limit to 1. i only get 1 contact and it's keep looping and then i get 504 Gateway error..
What could possible goes wrong?
Thanks.

Not sure at this point. You will probably need to talk to CC support to see if they have any idea of what is happening.
If you look into the client class code, I think you should be able to see the actual URLs and data sent to CC. They don't support any libraries just to make things super difficult.

I give another test by calling the $contactsClient->next(); twice and i get all of the other 2 contacts.
so i use this approach:
`$contactsResponse = $contactsEndPoint->get(status: 'all',include_count: true,lists: $list_id, limit: 1);
$counts = $contactsResponse['contacts_count'];
    $pages =  1;
    if ($counts > 1) {
        $pages = intdiv($counts,1);
    }

    if ($pages > 1) {
        for ($i = 2; $i <= $pages; $i++) {
            print_r($contactsEndPoint->next());
        }
    }`

It is working for me. maybe you have a better way?

Looks like it would work. I would use a bigger limit and iterate through the returned array of contacts.  That would minimize the number of API calls you are making. I believe CC has a rate limited API, so you can't call them too often.  I think I added a rate limiter into the client, so it should not be a problem. Still not sure why you are getting a gateway error.

I have update my code to use 500 as the limit.
Another thing, i copied your code on create contact like this:
        $contactBody = new \PHPFUI\ConstantContact\Definition\ContactPostRequest();
        $contactBody->first_name = $data['firstname'];
        $contactBody->last_name = $data['lastname'];
        $contactBody->create_source = 'Account';
        $contactBody->list_memberships = [new \PHPFUI\ConstantContact\UUID($list_id)];
        $email = new \PHPFUI\ConstantContact\Definition\EmailAddressPost();
        $email->address = $data['email'];
        $email->permission_to_send = 'explicit';
        $contactBody->email_address = $data['email'];
        $contactsEndPoint->post($contactBody);

I get this error:
 Unknown Error: AbanteCart core v.1.3.4 PHPFUI\ConstantContact\Definition\Base::__construct(): Argument #1 ($initialValues) must be of type array, string given, called in /home/php81abdev7/public_html/ctct/extensions/constantcontact_integration/core/lib/ctct/vendor/phpfui/constantcontact/src/ConstantContact/Definition/Base.php on line 177 in /home/php81abdev7/public_html/ctct/extensions/constantcontact_integration/core/lib/ctct/vendor/phpfui/constantcontact/src/ConstantContact/Definition/Base.php on line 57

Did i miss anything?

There is now a new version that fixes the assignment of the wrong type to properties that should be an object.
Closing this as answered.  Open a new issue if you find another issue.


Required props: alt, width, height

Is your feature request related to a problem? Please describe.
Pretty common pattern across the industry for image components is to require a width, height, and alt attribute.

Width and height help to let the browser understand the area that the image is going to take. This is especially important when it comes to layout shift, which provides a bad user experience, and actually will penalize your app
Alt text is great to help push accessibility, which isn't a web requirement, but is a really great thing to promote as critical to image placement. Someone can simply do alt="" if they dont have one.

Describe the solution you'd like
i'm not sure what Nuxt patterns are for required props. not having a src 500's.
Describe alternatives you've considered
These aren't things required to make an image work but promoting these as best practices are critical to building a better web, making it easier for people to opt-in to better patterns for better user experience and accessibility.

Layout shift example without size attributes

Added in https://github.com/nuxt-modules/cloudinary/commit/9be462289d4eb00d33555acb6fe2e0697f6f30fe


Android wear?

No experience with android development but I believe this would be a cool addition to this repo!

https://github.com/mtford90/react-native-watch-connectivity/pull/123

Related to https://github.com/fabOnReact/react-native-wear-connectivity/issues/33
Requires first completing issue https://github.com/fabOnReact/react-native-wear-connectivity/issues/32

[ ] add to react-native-watch-connectivity package.json the react-native-wear-connectivity library
[ ] add to RNWatch.android.ts the sendMessage and receiveMessage react-native-wear-connecitivity APIs.
[ ] add more APIs to (see RNWatch.ios.ts for the missing APIs in wearOS).


[Storage][Blob] STG71 Features - Incremental Snapshot Header: GetPageRange with x-ms-previous-snapshot-url header

GetPageRange supports a new header x-ms-previous-snapshot-url. The functionality is the same as the prevsnapshot parameter, exception x-ms-previous-snapshot-url only works with managed disk accounts.
Add a new API only for documentation use. will not check for the managed disk accounts when it's invoked in our client.
Add test support for an additional managed disk account.

after this change do we need to defined these variables for live test build pipeline/local runs
Refers to: sdk/storage/sample.env:9 in ecc0c62. [](commit_id = ecc0c62, deletion_comment = False)

@jeremymeng These variables are optional. The test case will be skipped if they are not configured properly. Maybe I should mention this in the CONTRIBUTING.md.
  it("getPageRangesDiff with URL", async function () {
    let mdBlobServiceClient: BlobServiceClient;
    try {
      mdBlobServiceClient = getGenericBSU("MD_", "");
    } catch (err) {
      // managed disk account is not properly configured
      return this.skip();
    }
...
}

Maybe

Maybe I should mention this in the CONTRIBUTING.md.

yes please document new env variables.

after this change do we need to defined these variables for live test build pipeline/local runs
Refers to: sdk/storage/sample.env:9 in ecc0c62. [](commit_id = ecc0c62, deletion_comment = False)

@jeremymeng Yes, I think we need to defined these variables for live test build pipeline. Do you know who can help with this?


103 incorrect reference to error in stdauth middleware

Probably worth adding this code to the admin auth middleware too


fix #109733 prevent double '(read-only)' suffix in titlebar

This PR fixes #109733
@bpasero please review and merge if satisfactory.

Thanks, I was looking into the code myself for 5 minutes and was not able to think about a solution that is straight forward. I am not a big fan of the approach to introduce a flag, but I will comment more next milestone.

My suggested fix: https://github.com/microsoft/vscode/commit/cfb74bdabd480e0305fa4a93267af2c215727b3d

Thanks, but I went with the alternate approach.

No problem. Thanks for fixing it a better way.


Improve distributedCp and distributedMv and Persist

Set readtype to NO_CACHE to distributedCp and distributedMv (in migration definition)
Increase buffersize to 8 MB (from 8KB or less) for these jobs
Make distributedMv carry writetype

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6088/
Test FAILed.

I'm curious, how much does the buffer size change affect loading a large file?

Merged build finished. Test PASSed.

@gpang I was running a test of persisting a 100GB file to s3, with the previous tiny buffer I was not able to finish it; after changing to the large (8MB) buffer, it completes within a hour.

alluxio-bot, merge this please.

alluxio-bot, cherry-pick this to branch-2.0 please

alluxio-bot, cherry-pick this to branch-2.1 please


Context Deadline Exceeded on Install

Output of helm version:
Client: &version.Version{SemVer:"v2.7.2", GitCommit:"8478fb4fc723885b155c924d1c8c410b7a9444e6", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.9.1", GitCommit:"20adb27c7c5868466912eebdf6664e7390ebe710", GitTreeState:"clean"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.): AWS
I am wrapping the Helm libs in a REST service and have implemented endpoints to:

Get all Releases in a namespace
Get information about a specific release by name
Deploy a release from a chart pulled from Quay

The first two endpoints work fine, no connection issues and returns the data as expected.
However, the endpoint that I am POSTing to in order to deploy a chart returns the following error:
time="2018-06-20T22:55:27Z" level=error msg="context deadline exceeded
I traced through the debugger and found it was happening on the connect method where it calls grpc.DialContext.
Is there something occurring in the helm cli that makes this call succeed? Or did I stumble upon a bug here?
Any help would be greatly appreciated :) I pasted some of my calling code below.
func (hc *HaasController) deployRelease(params map[string]string, chart io.Reader) ([]byte, error) {
  name := params["name"]
  namespace := params["namespace"]

  installopts := []helm.InstallOption{
    helm.ReleaseName(name),
  }

  opts := []helm.Option{
    helm.Host(fmt.Sprintf("%s,%s", hc.TillerHost, hc.TillerPort)),
  }

  c := helm.NewClient(opts...)
  resp, err := c.InstallReleaseFromChart(chart, namespace, installopts...)
  if err != nil {
    log.Errorf("error installing chart: %v", err) // Errors with context deadline exceeded
    return nil, err
  }

  bytes, err := json.Marshal(resp)
  if err != nil {
    log.Errorf("error marshalling response: %v", err)
    return nil, err
  }

  return bytes, nil

}

Well, it was starring me in the face this whole time...
helm.Host(fmt.Sprintf("%s,%s", hc.TillerHost, hc.TillerPort))
there's a , instead of a : in between the host and port.
Closing :)


Attempted to serialize scalar '0' with incompatible type 'DateTime' on Date column when table is empty

Bug description
Using prisma.model.aggregate on a Date column of an empty table (or with where condition that does not match any rows) leads to the error:
(node:35040) UnhandledPromiseRejectionWarning: Error:
Invalid `prisma.post.aggregate()` invocation:

  Attempted to serialize scalar '0' with incompatible type 'DateTime'

How to reproduce
import { PrismaClient } from '@prisma/client'

async function main() {
  const prisma = new PrismaClient()
  prisma.$connect()
  const result = await prisma.post.aggregate({
    max: { created_at: true },
  })
  console.log(result)
  prisma.$disconnect()
}

main()

Expected behavior
I would expect to receive a null value for result.max.created_at if no row exists/matches.
Prisma information
model Post {
  id         Int      @id
  created_at DateTime @db.Date

  @@map("posts")
}

Environment & setup

OS: Windows
Database: PostgreSQL
Node.js version: 14.15.5
Prisma version:

Environment variables loaded from .env
prisma               : 2.17.0
@prisma/client       : 2.17.0
Current platform     : windows
Query Engine         : query-engine 3c463ebd78b1d21d8fdacdd27899e280cf686223 (at<EMAIL_ADDRESS>Migration Engine     : migration-engine-cli 3c463ebd78b1d21d8fdacdd27899e280cf686223 (at<EMAIL_ADDRESS>Introspection Engine : introspection-core 3c463ebd78b1d21d8fdacdd27899e280cf686223 (at<EMAIL_ADDRESS>Format Binary        : prisma-fmt 3c463ebd78b1d21d8fdacdd27899e280cf686223 (at<EMAIL_ADDRESS>Studio               : 0.353.0
Preview Features     : createMany, groupBy

Hey @some-user123
Thanks for reporting this. I can confirm this issue. Looks like client is currently trying to serialize true as date so we should fix that.


Exception using MockWebServer with Https on Android P

Got the following exception when running Android P with https:
java.lang.VerifyError: Verifier rejected class okhttp3.internal.tls.HeldCertificate$Builder: okhttp3.internal.tls.HeldCertificate okhttp3.internal.tls.HeldCertificate$Builder.build() failed to verify: okhttp3.internal.tls.HeldCertificate okhttp3.internal.tls.HeldCertificate$Builder.build(): [0x9D] register v7 has type Reference: org.bouncycastle.asn1.ASN1ObjectIdentifier but expected Reference: org.bouncycastle.asn1.DERObjectIdentifier (declaration of 'okhttp3.internal.tls.HeldCertificate$Builder' a
Here is the test code to start the MockWebServer:
    MockWebServer mockWebServer = new MockWebServer();
    mockWebServer.useHttps(SslClient.localhost().socketFactory, false);
    mockWebServer.start();

Are you shipping an incompatible version of bouncycastle with your project? HeldCertificate depends on bouncycastle 1.50, though perhaps we should update the library to require a newer version.

... or perhaps build our own certificate encoder and avoid the bouncycastle dependency altogether!

@swankjesse  does that mean that including implementation com.squareup.okhttp3:okhttp-tls:3.11.0 is enough since org.bouncycastle:bcprov-jdk15on:1.50 is a transitive dependency, right?
That's not the case in my project where I do the following to setup https for testing with MockWebServer:
val localhostCertificate = HeldCertificate.Builder()
    .addSubjectAlternativeName(InetAddress.getByName("localhost").canonicalHostName)
    .build()

If I don't add additional bouncy castle dependencies I get the following error:
java.lang.AssertionError: java.security.NoSuchAlgorithmException: no such algorithm: ECDSA for provider BC
at okhttp3.tls.HeldCertificate$Builder.generateKeyPair(HeldCertificate.java:429)
at okhttp3.tls.HeldCertificate$Builder.build(HeldCertificate.java:353)
...

Nevertheless, I can confirm that  you get this error
java.lang.VerifyError: Verifier rejected class okhttp3.internal.tls.HeldCertificate$Builder: okhttp3.internal.tls.HeldCertificate okhttp3.internal.tls.HeldCertificate$Builder.build() failed to verify: okhttp3.internal.tls.HeldCertificate okhttp3.internal.tls.HeldCertificate$Builder.build(): [0x9D] register v7 has type Reference: org.bouncycastle.asn1.ASN1ObjectIdentifier but expected Reference: org.bouncycastle.asn1.DERObjectIdentifier (declaration of 'okhttp3.internal.tls.HeldCertificate$Builder' a

if you use a different version of bouncy castle (like org.bouncycastle:bctls-jdk15on:1.60)

@sockeqwe gotcha. You must be pulling in yet another version somehow. If you explicitly specify 1.50 does it work?
In any case we should update our code to 1.60 for the next release.

okhttp + bcprov-jdk15on

java.lang.AssertionError: java.security.NoSuchAlgorithmException: no such algorithm: ECDSA for provider BC
at okhttp3.tls.HeldCertificate$Builder.generateKeyPair(HeldCertificate.java:429)
at okhttp3.tls.HeldCertificate$Builder.build(HeldCertificate.java:353)

okhttp + bcprov-ext-jdk15on

implementation "com.squareup.okhttp3:okhttp-tls:3.11.0"
implementation "org.bouncycastle:bcprov-ext-jdk15on:1.50"

causes aapt2 error at compile time
AGPBI: {"kind":"error","text":"Program type already present: org.bouncycastle.LICENSE","sources":[{}],"tool":"D8"}

okhttp (excluding bouncycastle) +  bcprov-ext-jdk15on

implementation (testLibraries.okhttpTls){
  exclude group: 'org.bouncycastle'
}
implementation "org.bouncycastle:bcprov-ext-jdk15on:1.50"

causes
java.lang.AssertionError: java.security.NoSuchAlgorithmException: no such algorithm: ECDSA for provider BC
at okhttp3.tls.HeldCertificate$Builder.generateKeyPair(HeldCertificate.java:429)
at okhttp3.tls.HeldCertificate$Builder.build(HeldCertificate.java:353)

okhttp + bcpkix

implementation "com.squareup.okhttp3:okhttp-tls:3.11.0"
implementation "org.bouncycastle:bcpkix-jdk15on:1.50"

causes
java.lang.AssertionError: java.security.NoSuchAlgorithmException: no such algorithm: ECDSA for provider BC
at okhttp3.tls.HeldCertificate$Builder.generateKeyPair(HeldCertificate.java:429)
at okhttp3.tls.HeldCertificate$Builder.build(HeldCertificate.java:353)

Is there any other bouncy castle dependency that I should use?
Btw. starting in bouncy castle 1.60 seems to have a dedicated artifact for tls:  org.bouncycastle:bctls-jdk15on:1.60

Our tests pass with bcprov-jdk15on.

on my macbook during unit tests it works too, but not on an android
emulator.
Jesse Wilson<EMAIL_ADDRESS>schrieb am So., 29. Juli 2018,
23:45:

Our tests pass with bcprov-jdk15on.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/square/okhttp/issues/4175#issuecomment-408708132, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAjnrlRbIUp3X_dmLvcdEv80MhpydJh0ks5uLizfgaJpZM4Vi8iR
.

Hm. Will investigate.

I created a new issue here: #4183

Instead of using SslClient.localhost().socketFactory, I create a cert and load to Android Keystore,
MockWebServer mockWebServer = new MockWebServer();
mockWebServer.useHttps(getSSLSocketFactory(), false);

private SSLSocketFactory getSSLSocketFactory() throws Exception {
        char[] password = "password".toCharArray();

        KeyPairGenerator keyPairGenerator = KeyPairGenerator.getInstance("RSA");
        keyPairGenerator.initialize(1024, new SecureRandom());
        KeyPair keyPair = keyPairGenerator.generateKeyPair();

        Calendar notAfter = Calendar.getInstance();
        notAfter.add(Calendar.DAY_OF_YEAR, 1);
        X509v3CertificateBuilder builder = new JcaX509v3CertificateBuilder(
                new X500Principal("CN=localhost"),
                new BigInteger("1"),
                new Date(),
                notAfter.getTime(),
                new X500Principal("CN=localhost"),
                keyPair.getPublic());

        ContentSigner contentSigner = new JcaContentSignerBuilder("SHA256WithRSAEncryption")
                .build(keyPair.getPrivate());

        builder.build(contentSigner);

        X509Certificate certificate = new JcaX509CertificateConverter()
                .getCertificate(builder.build(contentSigner));

        KeyStore keyStore = KeyStore.getInstance(KeyStore.getDefaultType());
        InputStream in = null;
        keyStore.load(in, password);
        Certificate[] certificateChain = {certificate};
        keyStore.setKeyEntry("private", keyPair.getPrivate(), password, certificateChain);
        keyStore.setCertificateEntry("cert", certificate);

        KeyManagerFactory keyManagerFactory =
                KeyManagerFactory.getInstance(KeyManagerFactory.getDefaultAlgorithm());
        keyManagerFactory.init(keyStore, password);
        TrustManagerFactory trustManagerFactory =
                TrustManagerFactory.getInstance(TrustManagerFactory.getDefaultAlgorithm());
        trustManagerFactory.init(keyStore);
        SSLContext sslContext = SSLContext.getInstance("TLS");
        sslContext.init(keyManagerFactory.getKeyManagers(), trustManagerFactory.getTrustManagers(),
                new SecureRandom());
        return sslContext.getSocketFactory();
    }

Running it with our current code on Android P:
Caused by: java.security.NoSuchAlgorithmException: ECDSA KeyPairGenerator not available
        at java.security.KeyPairGenerator.getInstance(KeyPairGenerator.java:241)
        at okhttp3.tls.HeldCertificate$Builder.generateKeyPair(HeldCertificate.java:426)

This is fixed by replacing ECDSA with RSA2048
    HeldCertificate localhostCertificate = new HeldCertificate.Builder()
        .addSubjectAlternativeName(localhost)
        .rsa2048()
        .build();

But I’d still like to figure out how to get ECDSA working on Android!


Counter example added

Issue #18

Coverage decreased (-0.002%) to 32.816% when pulling 7e5237a7bb3fe34fa6474a303f9986cf69bc1193 on example_counter into deab373f9f05a2688cb48042551c90685afd6881 on master.


is it accurate?

I really liked it but when i compare charts provided by DigitalOcean and linux-dash.... values are highly different.
linux-dash shows CPU usage is 70%+
DigitalOcean shows CPU usage is ~4%
i don't know which one to believe

I'm not sure why you're seeing such varying results. The linux-dash demo is also hosted on DigitalOcean and the graphs relatively match. DigitalOcean shows 6% and the demo shows 5%.
Are you able to confirm which one is correct by seeing the output of top command on the server?

from linux-dash
24325	root	0.2	3728	7420	bash
24312	root	0	3456	11360	sshd
24509	www-data	0.2	7096	113760	apache2
25220	root	3	3224	9992	sshd

from ````top````` command
25637 root      20   0 10224 3368 2544 S    2  0.2   0:00.21 sshd
24508 www-data  20   0  113m  17m 9.9m S    1  0.9   0:00.19 apache2
25140 www-data  20   0  112m  15m 8732 S    1  0.8   0:00.10 apache2
24509 www-data  20   0  111m 7104 2080 S    1  0.3   0:00.24 apache2
23948 root      20   0     0    0    0 S    0  0.0   0:00.13 kworker/0:2
24384 root      20   0  2816 1172  936 R    0  0.1   0:00.33 top

I am not sure whether you are asking for this info or not but i am ready to debug more.

@lorvent : no, I meant the system load line of top output. It is usually found on the 3rd line and starts with "CPU(s)".
The 4th number in that row shows CPU idle %. It should be a number followed by a percentage sign and " id". That is the percentage of CPU which is not being utilized. That number + the Linux dash number should roughly equal 100.
You can see it here:

@lorvent any updates?

hi, sorry for delay
idle : 96.3%
as per linux-dash:
1_min_avg	36.5 %
5_min_avg	16.5 %
15_min_avg	10 %

@lorvent do you have the most recent copy of Linux dash?
 These are not compatible measurements.
Please see #325 for details. Short version: update Linux dash and you'll see 2 cpu graphs: one showing utilization and another showing cpu avg load.

Hi,
i just updated and YES, i see those two now.
CPU utilization matching with graphs in DO...

Awesome. Glad those graphs are matching now.


Added FloScript language

Floscript is the the configuration language for the ioflo runtime engine.
https://github.com/ioflo

Tests are failing. Can anybody explain what is going wrong ?

@0486
First of all, truly sorry for the long delay in anyone responding to this PR.
Thank you so much for desiring to contribute and writing a language grammar.  Unfortunately, we currently are no longer accepting new languages into the core repository.  The existing maintainers simply don't have time to maintain new languages (fixing bugs, dealing with issues, etc).  We'd still love to host your language as a 3rd party module though - if you're willing to help maintain it.
It's easy to turn your language into a module that anyone who likes can easily integrate with Highlight.js using a single line of code:
<script src="/path/to/highlight.min.js"></script>
<!-- they'd simply add your language modules -->
<script src="/path/to/highlightjs-Floscript.js"></script>
<script>hljs.initHighlightingOnLoad();</script>

It's also possible for users to rebuild the highlight.js library to include specific 3rd party modules, all in a single file (vs loading a bunch of 3rd party languages one at a time).
If you'd like to become the maintainer for this language then we're happy to create a new repository in the highlightjs organization and host the repository there.  That assumes you'd be open to reviewing issues and fixing bugs as they arise.  You're also welcome to host the repo yourself and we'll link to it from our README.
There isn't much in the way of how to docs on this yet, but there are sample repositories and it's honestly pretty easy.  We're still fleshing out an official "spec" for 3rd party modules, but even after that's done it should require minimal changes from the examples we have already.  IE, if you wanted to get started now there isn't any big reason to wait.
My own robots.txt grammar repository is a great, simple example:
https://github.com/highlightjs/highlightjs-robots-txt
If you have any questions feel free to ask.

Travis-ci tests are failing. Can anybody explain what is going wrong ?

I tried to look at this, but since the repository has moved since then the link no longer functions.

Closing for inactivity; (also finally cleaning all these old PRs out for the new year).
As mentioned above if you're interested in becoming the maintainer of a 3rd party module, please respond [whenever you find time] and we'd be happy to help you get started.


fix(gui): Fix notification icon path

This fixes the path to the notification icon.
Change-Type: patch
Changelog-Entry: Fix notification icon

Closing – this has already been fixed by #1943


PR: Update duplicates.yml

Description of Changes

[ ] Wrote at least one-line docstrings (for any new functions)
[ ] Added unit test(s) covering the changes (if testable)

[ ] Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

For next time you could push directly to master (that's what I've doing for all the duplicates I've added here).

I feel apprehensive of doing that :-p, but I will try next time!


OpenStack metadata collection handles manually terminated instances

@schfeca75 or @keyki please review!

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/2367/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/2368/


BitcoinCore Torv3

https://twitter.com/pwuille/status/1315105797517393920?s=20

As a result of testing v1.7RC1 there were no problems ... will be part of final release of v1.7. Closing issue.


upgrade chart versions

change jenkins-x/jenkins-x-platform to version 0.0.3737
change jenkins-x/jx-build-templates to version 0.0.562
change jenkins-x/prow to version 0.0.455

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jstrachan
If they are not already assigned, you can assign the PR to them by writing /assign @jstrachan in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/test all

@jstrachan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

ng
f38bc74aaea4966c2bfa1ba4ce8346f63a9a997c
link
/test ng

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jstrachan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

ng
f38bc74aaea4966c2bfa1ba4ce8346f63a9a997c
link
/test ng

tekton
f38bc74aaea4966c2bfa1ba4ce8346f63a9a997c
link
/test tekton

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jstrachan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

ng
f38bc74aaea4966c2bfa1ba4ce8346f63a9a997c
link
/test ng

tekton
f38bc74aaea4966c2bfa1ba4ce8346f63a9a997c
link
/test tekton

prow
f38bc74aaea4966c2bfa1ba4ce8346f63a9a997c
link
/test prow

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Extension host terminated unexpectedly - Message always appearing

Whenever I launch VSCode, I am always receiving this message:

I already clicked the Restart Extension Host multiple times but it doesn't resolve the issue.

By opening the DevTools, I saw this error on the console:

Line 281 of extensionService.ts error on this Code:
console.error('Extension host terminated unexpectedly. Code: ', code, ' Signal: ', signal);
Line 126 of messageService.ts error on this Code:
console.error(toErrorMessage(message, true));

VSCode Version:

OS Version: Windows 10
Steps to Reproduce:

Updated VSCode to version: January 2018 (version 1.20)
Installed extension:

Does this issue occur when all extensions are disabled?: Yes

Just to confirm, you still see this error even when starting VSCode from the command line with --disable-extensions? If so, can you try the following:
Wherever VSCode is installed (should be C:\Program Files (x86)\Microsoft VS Code), go to \resources\app and rename the extensions folder there and add new folder with nothing in it called extensions.
This will remove the extensions you've installed and the extensions that are built into VSCode. If loading VSCode with all extensions removed fixes the problem, then one of the built in extensions is likely causing the issue and we will try to narrow it down

Hi there! I tried following your instructions and looks like one of the extension is really giving the error. I also tried launching the VSCode with the disabled extensions and it works fine. There is no error message.

@KBPsystem777 Great! So now we know it is one of the extensions. Is it possible for you, by process of elimination, to narrow down which one it is?
Otherwise, when the extension host crashes, it is possible to view the log file which would indicate what it was doing before it crashed: F1 > Developer: Show logs... > Extension Host.

@alexandrudima after narrowing it down, looks like the error is from GitLens extension.
Also per following your instructruction, this is the log I have:
[2018-02-27 03:17:17.990] [exthost1] [info] extension host started
[2018-02-27 03:17:18.027] [exthost1] [info] ExtensionService#_doActivateExtension vscode.emmet {"startup":true,"activationEvent":"*"}
[2018-02-27 03:17:18.028] [exthost1] [info] ExtensionService#loadCommonJSModule c:\Program Files\Microsoft VS Code\resources\app\extensions\emmet\out\extension
[2018-02-27 03:17:18.166] [exthost1] [info] ExtensionService#_doActivateExtension vscode.git {"startup":true,"activationEvent":"*"}
[2018-02-27 03:17:18.167] [exthost1] [info] ExtensionService#loadCommonJSModule c:\Program Files\Microsoft VS Code\resources\app\extensions\git\out\main
[2018-02-27 03:17:18.321] [exthost1] [info] ExtensionService#_doActivateExtension vscode.merge-conflict {"startup":true,"activationEvent":"*"}
[2018-02-27 03:17:18.321] [exthost1] [info] ExtensionService#loadCommonJSModule c:\Program Files\Microsoft VS Code\resources\app\extensions\merge-conflict\out\extension
[2018-02-27 03:17:18.361] [exthost1] [info] eager extensions activated

@KBPsystem777 In this case, can you please open an issue directly against the extension at https://github.com/eamodio/vscode-gitlens/issues


fix(config): swap ZW080 bitmasks for siren volume and siren sound

swapped hex byte code on siren volume and siren sound as these were reversed

@zwave-js-bot rename commit

@zwave-js-bot rename commit


Make ide-python launch pyls with virtual env awareness

Currently, pyls is launched without setting the VIRTUAL_ENV environment variable.
This prevents ide-python from having support for python virtualenvs.

Thanks for the PR.
Fixed in #38


gpio: gpio_sch: fix check for interrupt trigger

The controller does not support trigger. However, the check for
this condition was incorrectly (as GPIO_INT_LEVEL is 0). So fix
it.
Signed-off-by: Daniel Leung<EMAIL_ADDRESS>

Codecov Report

Merging #13143 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13143   +/-   ##
=======================================
  Coverage   48.73%   48.73%
=======================================
  Files         315      315
  Lines       46538    46538
  Branches    10743    10743
=======================================
  Hits        22678    22678
  Misses      19348    19348
  Partials     4512     4512

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b6204b...49e688b. Read the comment docs.


Missing ATTR_FORECAST_CLOUD_COVERAGE

Hi,
In v1.2.2 the ATTR_FORECAST_CLOUD_COVERAGE const is missing from const.py and the component can't be initialized. This PR fixes it by importing from the core weather component.

Thank you so much for opening this! I missed a file in the release, and wouldn't have noticed the bug without your PR. I pulled the release and I'm going to put the variable in the const.py file to fit with the broader Home Assistant style, so will be addressed that way


Auto-crafting a Mekanism Speed Upgrade Fails

Issue description:
Auto-crafting a Mekanism Speed Upgrade fails due to a hard requirement for Tinker's Construct Clear Glass.
What happens:
Receive an error that the glass is not available, no matter the type, unless you have an auto-crafting recipe set up for Tinker's Construct Clear Glass (the actual recipe takes any available glass).  Manually doing this works fine; it is only autocrafting that does not work.
It does appear that if you set it to auto-craft a number of upgrades that you actually have in your system, then cancel, then go back and tell it to craft more where you need to craft more glass than you currently have, the issue goes away.
What you expected to happen:
I expect to be able to auto-craft a Mekanism Speed Upgrade using Refined Storage on the first try whether I have all of the glass or not, as long as I have a recipe available to auto-craft the missing glass.
Steps to reproduce:

Set up an auto-crafting recipe to create a Mekanism Speed Upgrade using either Vanilla Glass or EnderIO Quite Clear Glass
Try to autocraft and specify a value higher than any available amount of glass, especially any Tinker's Clear Glass.
See the error warning that there are missing resources, even though they can also be auto-crafted just fine individually (the glass, in this case - both Vanilla glass and Quite Clear Glass from EnderIO)
Try to craft a single upgrade, assuming you have enough resources and do not require any other machines - just straight crafting
Cancel step 4
Try step 2 again, and it appears to work fine going forward

Version (Make sure you are on the latest version before reporting):

Minecraft: 1.10.2
HermitPack:  1.4.0-1.10.2 Beta [Latest]
Forge: <IP_ADDRESS>4
Refined Storage: 1.2.4
Mekanism:  9.2

Does this issue occur on a server? [yes/no] Likely - though in this case, it is a local game.  I have not tested this, though I doubt it makes much of a difference.  The issue is very much likely the same.
If a (crash)log is relevant for this issue, link it here:
N/A

I think @way2muchnoise fixed this in dev yesterday, is that true?

Yeah most likely fixed in #643


Update Java version

Fixes #269

@usmansaleem please review when you have a chance. Thanks a million


Update build parameters

[x] I have taken backward compatibility into consideration.

Addresses CVE-2023-3089

/lgtm


Update README

Travis badge points to actual build
Updated code snippets according to this
Add alt-text to the demo and update link to github issue

This should also solve broken links at https://pypi.org/project/pytest-sugar/ provided an update is issued.
btw: thanks for a nice plugin

Thanks for the PR!


Color is broken JS

Javascript issue. Unless someone uses it and can make it work with the dummy_app, I'm all in favor of removing the whole thing. For the moment, t's uselessly bloating the JS file and the CSS file.

Fixed.