[BUG] Message lock renewal not working for 10+ minutes processin durationg when using different ServiceBusReceiver instances for CompleteMessageAsync and RenewMessageLockAsync

Library name and version
Azure.Messaging.ServiceBus 7.8.0, 7.8.1 and 7.9.0
Describe the bug
When using transactions and invoking RenewMessageLockAsync on a different ServiceBusReceiver and processing durations are over 10 minutes then invoking CompleteMessageAsync CAN results in a MessageLockLost if that is the only message concurrently being processed.
A similar bug was reported earlier. This has been fixed in 7.8.0 when invoking invoking CompleteMessageAsync on the same receiver as CompleteMessageAsync.

https://github.com/Azure/azure-sdk-for-net/issues/28025

Expected behavior
The client not gets into a faulty state where lock renewal seems to succeed but when CompleteMessageAsync is invoked that it fails with MessageLockLost.
Actual behavior
The client can get into a faulty state where:

any message that will be ack'd via CompleteMessageAsync where processing is longer then the queue lock duration will fail
any message that result in a lock renewal via RenewMessageLockAsync will incorrectly succeed

Reproduction Steps
var lockDuration = TimeSpan.FromMinutes(5);
var renewalInterval = lockDuration - TimeSpan.FromSeconds(10);
var queueName = "test-" + DateTimeOffset.UtcNow.ToUnixTimeMilliseconds();
var cs = Environment.GetEnvironmentVariable("AzureServiceBus_ConnectionString");
var admin = new ServiceBusAdministrationClient(cs);
await admin.CreateQueueAsync(new CreateQueueOptions(queueName) { LockDuration = lockDuration, AutoDeleteOnIdle = TimeSpan.FromMinutes(10) });
var sw = Stopwatch.StartNew();
using var logger = new AzureEventSourceListener((ea, m) => Console.Out.WriteLineAsync($"{sw.Elapsed,-15:g} [{ea.Level,-13}] {m}"), EventLevel.Verbose);
await using var client = new ServiceBusClient(cs, new ServiceBusClientOptions { EnableCrossEntityTransactions = true });
await using var sender = client.CreateSender(queueName);
await sender.SendMessageAsync(new ServiceBusMessage());
await using var receiver = client.CreateReceiver(queueName);

var message = await receiver.ReceiveMessageAsync(); Trace.Assert(message != null);
using var cts = new CancellationTokenSource(TimeSpan.FromMinutes(11));
await RenewLockAsync(message!, cts.Token);
using var ts = new TransactionScope(TransactionScopeAsyncFlowOption.Enabled);
await sender.SendMessageAsync(new ServiceBusMessage());
await receiver.CompleteMessageAsync(message);
ts.Complete();

async Task RenewLockAsync(ServiceBusReceivedMessage message, CancellationToken cancellationToken)
{
    var renewLockReceiver = client.CreateReceiver(queueName);

    while (!cancellationToken.IsCancellationRequested)
    {
        var delayTask = await Task.Delay(renewalInterval, cancellationToken)
            .ContinueWith(t => t, TaskContinuationOptions.ExecuteSynchronously);
        if (delayTask.IsCanceled) return;
        await renewLockReceiver.RenewMessageLockAsync(message);
    }
}

Environment

net6
windows 10

@JoshLove-msft it seems either 7.8.1 or 7.9.0 caused a regression

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

@JoshLove-msft it seems 7.8.1 caused a regression. Behavior is happening in both 7.8.1 and 7.9.0.

But you cannot reproduce in 7.8.0?

@JoshLove-msft good question. I thought I had tested that after the release of it as that should have contained the earlier fix but not Today. Let me test that for you and I'll report it. Currently I'm assuming 7.8.0 had the fix.

I have not been able to repro the issue on 7.9.0 using your code. Here are the relevant logs.
The send link closes due to the idle timeout as expected, but the complete is still successful as the receive link remains open.
0:09:44.7111341 [Informational] test-1659636468657-6aaa3c1d-073f-4520-bfdc-d1e9a2fb1a8e: RenewLockAsync start. MessageCount = 1, LockToken = 1b0df878-9929-41e6-b76e-f8f31603fb55
0:09:44.883603  [Informational] test-1659636468657-6aaa3c1d-073f-4520-bfdc-d1e9a2fb1a8e: RenewLockAsync done. LockToken = 1b0df878-9929-41e6-b76e-f8f31603fb55
0:10:03.2098949 [Informational] Send Link Closed. Identifier: test-1659636468657-498474e3-0fda-4c84-aa30-51c9f823c6ee, linkException: Azure.Messaging.ServiceBus.ServiceBusException: The link 'G8:443458260:amqps://jolovsbdemo.servicebus.windows.n
et/-5a023aac;0:5:8' is force detached. Code: publisher(link20190829). Details: AmqpMessagePublisher.IdleTimerExpired: Idle timeout: 00:10:00. (GeneralError).
0:11:03.9606736 [Informational] test-1659636468657-498474e3-0fda-4c84-aa30-51c9f823c6ee: SendAsync start. MessageCount = 1
0:11:04.4098184 [Informational] AmqpTransactionDeclared for LocalTransactionId: b7b604f7-8929-4c97-a971-106368e16dee:1 AmqpTransactionId: txn:b418b91f925c4c23be4bb60e9aae2945__G8:24852075_G8.
0:11:04.4117466 [Informational] Creating send link for Identifier: test-1659636468657-498474e3-0fda-4c84-aa30-51c9f823c6ee.
0:11:04.4124126 [Verbose      ] test-1659636468657-498474e3-0fda-4c84-aa30-51c9f823c6ee: Requesting authorization to amqps://jolovsbdemo.servicebus.windows.net/test-1659636468657
0:11:04.587461  [Verbose      ] test-1659636468657-498474e3-0fda-4c84-aa30-51c9f823c6ee: Authorization to amqps://jolovsbdemo.servicebus.windows.net/test-1659636468657 complete. Expiration time: 08/04/2022 18:37:51
0:11:04.7621102 [Informational] Send link created for Identifier: test-1659636468657-498474e3-0fda-4c84-aa30-51c9f823c6ee.
0:11:04.941077  [Informational] test-1659636468657-498474e3-0fda-4c84-aa30-51c9f823c6ee: SendAsync done.
0:11:04.9468972 [Informational] test-1659636468657-6aaa3c1d-073f-4520-bfdc-d1e9a2fb1a8e: CompleteAsync start. MessageCount = 1, LockToken = 1b0df878-9929-41e6-b76e-f8f31603fb55
0:11:05.2011377 [Informational] test-1659636468657-6aaa3c1d-073f-4520-bfdc-d1e9a2fb1a8e: CompleteAsync done. LockToken = 1b0df878-9929-41e6-b76e-f8f31603fb55
0:11:05.4151386 [Informational] AmqpTransactionDischarged for LocalTransactionId: b7b604f7-8929-4c97-a971-106368e16dee:1 AmqpTransactionId: txn:b418b91f925c4c23be4bb60e9aae2945__G8:24852075_G8 Rollback: False.
0:11:05.4192947 [Verbose      ] Closing a ServiceBusReceiver (Identifier 'test-1659636468657-6aaa3c1d-073f-4520-bfdc-d1e9a2fb1a8e').
0:11:05.4354443 [Verbose      ] A ServiceBusReceiver has been closed (Identifier 'test-1659636468657-6aaa3c1d-073f-4520-bfdc-d1e9a2fb1a8e').
0:11:05.451127  [Verbose      ] Closing a ServiceBusSender (Identifier 'test-1659636468657-498474e3-0fda-4c84-aa30-51c9f823c6ee').
0:11:05.4552164 [Verbose      ] A ServiceBusSender has been closed (Identifier 'test-1659636468657-498474e3-0fda-4c84-aa30-51c9f823c6ee').
0:11:05.4582133 [Verbose      ] Closing a ServiceBusClient (Identifier 'jolovsbdemo.servicebus.windows.net-2eba0a28-4fc2-4097-894d-444ddcc79d0b').
0:11:05.4746853 [Verbose      ] A ServiceBusClient has been closed (Identifier 'jolovsbdemo.servicebus.windows.net-2eba0a28-4fc2-4097-894d-444ddcc79d0b').

@JoshLove-msft It seems my repro code was incorrect and I found the difference. I've updated the description with the following:

When using transactions and invoking RenewMessageLockAsync on a different ServiceBusReceiver and processing durations are over 10 minutes then invoking CompleteMessageAsync CAN results in a MessageLockLost if that is the only message concurrently being processed.

The important question is. Is this actually a supported scenario?

If yes, then it should be fixed
If no, then invoking RenewMessageLockAsync on a different ServiceBusReceiver instance should result in an exception.

Renewing a message with a different receiver is supported. Keeping the receive link alive past the 10 minute idle time enforced by the service will not happen if you are using a different receiver. This explains the behavior that you are seeing.

@JoshLove-msft I honestly find the response a little confusing. To me it reads as if this is unsupported.
I don't think this issue can already be closed. This behavior should atleast be documented somewhere.
My interpretation is
"It is unsupported but works if done within the 10 minute idle time".
If you take into consideration that the maximum value of LockDuration is 5 minutes then obviously processing durations past 5 minutes should be renewed but it is strange that the IDLE time the limiting factor here. For example, if there is concurrent message processing then a message CAN actually be processing for a much longer duration over 10 minutes because the receiver isn't Idle.
For now we need to interpret this as unsupported as processing durations over 10 minutes must be expected.

Renewing a lock with a different receiver is supported for an unlimited amount of time. You can keep renewing the lock as long as you want and the message will not be delivered to any receivers during this time. Independent of this, the service has behavior where it closes any idle receiver links after 10 minutes. If you are able to keep your receiver open beyond 10 minutes of receiving the initial message, then you can use it to complete the message. One way to keep the receiver open is to use it to renew message locks. Another way is to use it to receive other messages. In your case, you are letting the receiver go idle after receiving the initial message, and it gets closed after 10 minutes. It can no longer be used to complete the message once it gets closed by the service.
The reason that this works when using the same receiver to renew message locks, is that the receiver does not go idle. There is nothing special about using the same receiver to renew message locks other than the fact that it causes the receiver to not be idle.

Reopening until we document the behavior of the 10 minute server idle timeout resulting in link close and the fact that renewing a message lock keeps the receive link open.

Another way is to use it to receive other messages. In your case, you are letting the receiver go idle after receiving the initial message, and it gets closed after 10 minutes.

I think in our case that is actually happening. For example, allowing for a processing concurrency of 10 but then having only a single message in the queue. That means 9 receive operations are waiting for a message. If no message are in the queue (meaning, the queue is more or less idle) this can happen too.


request id handling: redesign for added flexibility and zipkin header handling

Trello:

https://trello.com/c/dlbLmRDB/343-make-use-of-zipkin-headers-in-preference-to-request-id-pt-1
https://trello.com/c/UOXf4vZZ/308-make-use-of-zipkin-headers-in-preference-to-request-id

This is designed to be fully backwards-compatible. Hopefully it achieves that and is thus deployable at will.
As before, this will cause apps to look for a DM-Request-ID header on requests and take that on as the request id if that's present. This will allow "downstream" apps to continue to assume the request id generated by an upstream app. However failing that it will now also look for a X-B3-TraceId header to allow our hosting infrastructure to assign an appropriate id for us. This has the advantage of added certainty that a (single) id is assigned to all requests, whether they start their journey through an app running this middleware or not.
The previous implementation already had a mechanism which would do a similar thing, controlled by the DM_DOWNSTREAM_REQUEST_ID_HEADER config setting - I simply made the feature more generic - allowing an arbitrary sequence of header names to be checked for in priority order (DM_TRACE_ID_HEADERS). However the previous config settings are respected and used as the defaults of DM_TRACE_ID_HEADERS
Also added the ability to record "span id" if it is provided to us.
Added a centralized, extensible way for a request to specify headers which should be propagated in onwards (internal) http api requests rather than have the apiclient need to know the exact details of what details to drag out of where as it currently does. This should allow us to easily add propagatable headers such as debug flags with minimal cross-repo-churn.
By default it propagates headers using all alternative header names it knows about, again, for compatibility reasons.
Because I think this should be 100% back-compatible I haven't done a major version bump. Hoping that's ok.

p.s. the tests failing is simply because I didn't realize we still -utils to pass with py2.7. Trivial fix, will do soon.

Well, as for YAGNI there are two possible uses mentioned in your own linked repo https://github.com/openzipkin/b3-propagation - a "debug" flag and a "sample decision" flag.
If you're able to describe all of the behaviours of your tests in test names, you're not testing nearly enough combinations. Or you will have written so many similarly named tests that you will have made a naming mistake somewhere. Belief that a single feature can be expressed in a single test (or a couple) is a fallacy. You need to know your various features work together. Though I admit I hadn't really paid attention to the test names, mostly inheriting them from their predecessors.

Sure, I did spot the "debug' one but is this something we maybe one day could use rather than something we actually want to use (I assume on top of some other possible work needed to actually implement it and use it). Just if we did all this and never added another header for the next year it feels like it could be overkill. Saying that, you've done it so there is not too much harm of taking that extra functionality.

Sure, whilst I don't 100% agree with everything in your statement, I do acknowledge that to test the combinations would be hard to do so without setting up your test in this way. I'm just making sure that the impact that has on readability is worth the trade off, and if so, what can we do to further improve the readability to minimise that affect whilst still keeping the coverage and structure to your tests.

I want to use it, to the point that I was vaguely considering inventing something like it before I realized zipkin had already thought of it. Its use: flip a request into crazy-log-everything mode, including e.g. SQL timestamps.

I really honestly think this style of test running is much much easier to read in the long run. Instead of figuring out what hundreds of lines of deceptively-similar-yet-not-always-the-same duplicated procedural code are supposed to do (and then what they actually do do) - each with their own potential logical gaps and etcetera, the only executable code you have to understand here is a few tens of lines that say really "all our tests follow this form: they set this and this and this up, they execute the function, then they check this and this". From there you just source the variables back to their construction, which is hopefully quite gotcha-free (I've only used single assignments anywhere) and the variable names should help you a lot.

Also relying on what someone else's idea of "clear test naming" is extremely hit and miss in my experience.

I've posted another change - I noticed that actually the standard calls for plain un-hyphenated hex values as ids, so I've made our generated ones comply with that too seeing as we're going to be transmitting them under zipkin header names we should try and behave ourselves.
The implication here of course is that paas's router will not be sending us UUIDs, just random hex values, and so that's what we're going to be using. Let's just hope none of our components weren't expecting UUID4s (i.e. with the 12th and 16th nibbles set to 0x1 and 0x4 respectively) (extremely extremely unlikely)

That's it. I'm merging in the next 10 minutes unless I get any objections.


Upscaling doesnt cooperate with new webUI

Describe your environment

GPU: cpu
VRAM: [if known]
CPU arch: arm
OS: macOS
Python: Anaconda
Branch: development
Commit: 636c356aafdeceab646648bcb25ba38c16a49e32

Describe the bug
Using the new webUI. When I select any image from right gallery and click on upscale (have settings for 4x), the progressbar animates for a while, then it says "Disconnected." But the upscaling continues (as shown in terminal). When upscaling is finished, webUI shows "Connected" again, but gallery on the right side doesnt update. I have to refresh the browser, for it to show the newly upscaled image (upscale finishes correctly just webUI didnt learn that)

probably relates to https://github.com/invoke-ai/InvokeAI/pull/786

Hi, it is because upscaling is a thread-blocking task and the server is unable to maintain its socket connection to the client. I have the same issue. #799 increases the timeout values and should help. I will add an listener to reconnect events that updates the gallery, so if something does time out, it automatically updates when the server is free again.
I will leave this issue open as a reminder to add the refresh on reconnect.

@psychedelicious Thank you! Just a question as I am not at all familiar with how it works in python. Isnt it possible to make the webserver (sockets) run in separate thread?

@ioma8 No worries. I'm sure there is a way, but I only know enough to be dangerous and alas, in this case, not quite enough to be useful. I only wrote my server script because the old UI's server wasn't quite enough to let me build the UI I wanted to build.
We have a new server and API on the way which, I believe, are properly threaded. Somebody who knows what they are doing are making them :)

#807 adds gallery refresh on reconnect


Character Editor

Hello, I'm Ali.
Not long time ago, I made a character editor for this engine, because I wanted to help the development of it and didn't have anything to do. I made this entirely by my own, and used my creativity for this, so it comes as good as possible. It doesn't bother me if anyone wants to edit this code for improvement, additions, and so on.
I hope that my contribution for this engine helped. :)

Could you provide videos of the character editor, of everything you can do

Could you provide videos of the character editor, of everything you can do

Sure, here is some footage of it (had to compress this video so I can upload it to GitHub):
https://github.com/FNF-CNE-Devs/CodenameEngine/assets/75845687/38ee1c95-5b3b-4e3e-9613-7a79e13c4318

Could you provide videos of the character editor, of everything you can do

Sure, here is some footage of it (had to compress this video so I can upload it to GitHub): https://github.com/FNF-CNE-Devs/CodenameEngine/assets/75845687/38ee1c95-5b3b-4e3e-9613-7a79e13c4318

I can see that some of the placements of the buttons and such are out of bounds, try and look at the style of the metadata screen in codename, also i can see that you are on a old version, preferabbly you should use the latest version

Could you also add like code so it shows where gf is placed

Could you also add like code so it shows where gf is placed

What do you mean.

Could you also add like code so it shows where gf is placed

What do you mean.

Like the player positioning, but for gf

Could you also add like code so it shows where gf is placed

What do you mean.

Like the player positioning, but for gf

Isn't that too much? I mean, I am just coding new stuff instead of improving the code..

Could you also add like code so it shows where gf is placed

What do you mean.

Like the player positioning, but for gf

Isn't that too much? I mean, I am just coding new stuff instead of improving the code..

Fine ill add it to the todo list later

Could you also add like code so it shows where gf is placed

What do you mean.

Like the player positioning, but for gf

Isn't that too much? I mean, I am just coding new stuff instead of improving the code..

Fine ill add it to the todo list later

thanks. :)

hope it would merge


Deploy sssom api on server

I send you the login data on slack. Keep it safe.
Here are some instructions on how to open a port:
https://www.cyberciti.biz/faq/how-to-open-firewall-port-on-ubuntu-linux-12-04-14-04-lts/
Here are some instructions on how to setup a website, but I don't think this is needed at all:
https://www.namecheap.com/support/knowledgebase/article.aspx/10330/2188/how-to-install-linux-apache-mariadb-php-stack-lamp-on-ubuntu-and-host-a-website/

The address for the API is in the oxo2 slack channel.


Async producer failed to deliver message

I was using the following code to do testing against AsyncProducer. I compiled the code into bin async_producer_main, and then executed ./async_producer_main --brokers=<IP_ADDRESS>:9092,<IP_ADDRESS>:9093,<IP_ADDRESS>:9094. It reported "2015/03/24 22:38:24 Failed to write access log entry: kafka: Failed to produce message to topic test_topic: dial tcp <IP_ADDRESS>:9092: connection refused" errors. All the brokers are in good states (I can use the Kafka shell CLI to produce and consume messages). BTW, telnet to <IP_ADDRESS> 9092 on server <IP_ADDRESS> also works.
package main

import (
	"github.com/Shopify/sarama"
	"log"
	"os"
	"strings"
	"flag"
	"time"
)

func main() {
	brokers := flag.String("brokers", "", "The Kafka brokers, separated by comma")
	flag.Parse()
	if *brokers == "" {
		flag.PrintDefaults()
		os.Exit(1)
	}

	brokerList := strings.Split(*brokers, ",")
	log.Printf("Kafka brokers: %s", strings.Join(brokerList, ","))

	config := sarama.NewConfig()
	config.Producer.RequiredAcks = sarama.WaitForLocal
	config.Producer.Flush.Frequency = 500 * time.Millisecond
	producer, err := sarama.NewAsyncProducer(brokerList, config)
	if err != nil {
		panic(err)
	}

	for i := 0; i < 10; i++ {
		producer.Input() <- &sarama.ProducerMessage {
			Topic: "test_topic",
			Key: sarama.StringEncoder("<IP_ADDRESS>"),
			Value: sarama.StringEncoder("This is a test"),
		}
	}

	go func() {
		for err := range producer.Errors() {
			log.Println("Failed to write access log entry:", err)
		}
	}()

	time.Sleep(time.Millisecond * 10000)
	defer func() {
		if err := producer.Close(); err != nil {
			log.Fatalln(err)
		}
	} ()
}

Looks like your Kafka brokers are not registering the proper hostname in Zookeeper. Kafka reports the names of all the brokers in the cluster, and we try to connect from them on the client. Obviously connecting to <IP_ADDRESS>:9092 from the client will fail because the broker doesn't run on the same machine.
You will have to check your Kafka broekr's server.properties file.

Thanks a lot, @wvanbergen. Problem solved after revisting the server.properties


Spotify Playback Thing

This pull request adds a Spotify Playback thing.
yes...

can you add that this is specific to LavaSrc & a link to LavaSrc?

thanks


ORC-1307: Add .clang-format to enforce C++ code style

There are some guidelines on formatting: https://orc.apache.org/develop/coding/. But no tooling has been available to enforce the style of C++ code. This patch aims to be the starting point. Follow-up changes will include automatic scripts to format cpp source files and per-commit check.

cc @williamhyun and @stiga-huang

I have tried to apply clang-format-action to verify whether the C++ files follow the .clang-format config file. However, I got an error as below:

<EMAIL_ADDRESS>is not allowed to be used in apache/orc. Actions in this workflow must be: within a repository owned by apache, created by GitHub, verified in the GitHub Marketplace, or matching the following: /@[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]+, AdoptOpenJDK/install-jdk@, JamesIves/github-pages-deploy-action@5dc1d5a192aeb5ab5b7d5a77b7d36aea4a7f5c92, TobKed/label-when-approved-action@, actions-cool/issues-helper@, actions-rs/, al-cheb/configure-pagefile-action@, amannn/action-semantic-pull-request@, apache/, burrunan/gradle-cache-action@, bytedeco/javacpp-presets/.github/actions/, chromaui/action@, codecov/codecov-action@, conda-incubator/setup-miniconda@, container-tools/kind-action@, container-tools/microshift-action@, dawidd6/action-download-artifact@, delaguardo/setup-graalvm@, docker://jekyll/jekyll:, docker://pandoc/core:2.9, eps1lon/actions-label-merge-conflict@, gaurav-nelson/github-action-markdown-link-check@*,...

After some research, I figured out that this action is not whitelisted by the Apache project setting: https://github.com/orgs/community/discussions/25488. Unfortunately I don't have the permission to add it. Do you know how to do that, or is there any alternative? @dongjoon-hyun @williamhyun @stiga-huang

Given that there are many other projects like Apache Arrow, there might be ASF-approved GitHub Action.
We need to file an INFRA JIRA to ask about what is allowed or to ask to add a new GitHub Action plugin.

Given that there are many other projects like Apache Arrow, there might be ASF-approved GitHub Action.
We need to file an INFRA JIRA to ask about what is allowed or to ask to add a new GitHub Action plugin.

I have checked Apache Arrow but it uses cpplint manually and does not integrate it with the GitHub workflow.

jidicula/clang-format-action

I have checked apache/arrow, apache/avro, and apache/impala. It looks like none of them use Github workflow to apply style check. Apache Arrow uses cpplint manually but it requires hard work to match the style between clang-format and cpplint.
I have filed an INFRA JIRA: https://issues.apache.org/jira/browse/INFRA-23873.

@dongjoon-hyun Now it is good to go.

Thank you so much, @wgtmac .

Since it looks very intrusive, cc @williamhyun , @omalley , @stiga-huang , @guiyanakuang , too.

Thanks for adding this! One concern is that this PR touch most of the c++ codes. git blame will always point to this PR.
It seems that keeping the indent inside namespace can save many changes. Probably we can have a try?

Thanks for adding this! One concern is that this PR touch most of the c++ codes. git blame will always point to this PR. It seems that keeping the indent inside namespace can save many changes. Probably we can have a try?

That's a good catch! Let me add NamespaceIndentation:All to reduce lines of change.

Thanks for adding the new rule! Now I see some changes are refactoring simple functions like
    bool operator != (const FileVersion & right) const {
      return !(*this == right);
    }

into in one line
    bool operator!=(const FileVersion& right) const { return !(*this == right); }

Does it mean the previous syntax won't be accepted anymore? Impala allows both format. Not sure if this takes effect:
https://github.com/apache/impala/blob/3938dae8be6f28132de67f10d0361665e5c6cad3/.clang-format#L7
It'd be nice if both formats are allowed. But I'm ok with merging the current PR.

AllowShortFunctionsOnASingleLine: Inline

Unfortunately AllowShortFunctionsOnASingleLine: Inline fails the format check. I changed it to AllowShortFunctionsOnASingleLine: Empty instead. Please check @stiga-huang

I just committed this. Thank you all! @dongjoon-hyun @stiga-huang @williamhyun @guiyanakuang


Information in the App is contradictory to the FAQ

Where to find the issue
In the App (click on the Risk Card and scroll all the way down to "Risk of Infection") and here in the FAQ.
Describe the issue
In the App (under the point "Risk of Infection") is written:

[...] your encounter was restricted to a short time AND at a greater distance.

And in the FAQ is written:

All exposures for a diagnosis key that lasted less than 10 minutes in total (regardless of how close the smartphones came during that time) OR during which the smartphones were more than 8 meters (73 dB attenuation) apart on average (regardless of how long the exposure lasted) are rated as harmless.

Suggested change
Make sure that the FAQ and the App doesn't say different things.
Edit: As I know now that the FAQ is correct, I think the Text in the App has to be updated.

Internal Tracking ID: EXPOSUREAPP-2357

Hello @Ein-Tim,
thank you for reaching out. I have addressed your issue to our development team so that they can take care of it as soon as possible.
Thank you,
MP
Corona-Warn-App Open Source Team

With the updated Texts this problem would be solved, I will leave this issue open until it's finally released 👍

Are these Texts now with 1.3.1, released?

Are these Texts, now with 1.3.1, released?

Yes they are... I've already seen ppl on Twitter sharing screenshots of them 🙂.

Thanks @daimpi
Will close this Issue now


Add support for HTTP security headers.

I often find myself writing configurations for CSP, HSTS and HPKP. These changes add support for these configurations to Prism.

Thanks for contributing! Please take a look at the comments I made regarding the code itself.
Also, it looks to me that hpkp and hsts look alike a lot. Couldn't they be merged as a single component?
It would be great if you could add examples and tests. Please refer to my comment https://github.com/PrismJS/prism/pull/1014#issuecomment-240993951 for details.

Hey :-)
I fixed up the code based on the comments. I think that should now be good.
I will have a look at the requirements for the examples and tests.

I've learnt a lot more about regexp than I intended ;-)
How is it looking now?

Getting there... :-D

I won't merge until I'm back on a computer next week (currently reviewing with my phone). In the meantime, if you can write examples and tests, and think about my suggestion to merge hpkp and hsts, it would be really great!

We could merge HPKP and HSTS but they're different technologies and may diverge further in the future. Also, the numeric value ranges are different for the two. From my side it makes sense to keep these separate.
As for the examples and test I will take a look at what's required.


feat(rpc): net namespace

Create an implementation of net_ namespace for rpc

Codecov Report

Merging #363 (05212fb) into main (70635b7) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   73.72%   73.72%   -0.01%
==========================================
  Files         231      233       +2
  Lines       21950    22013      +63
==========================================
+ Hits        16183    16229      +46
- Misses       5767     5784      +17

Impacted Files
Coverage Δ

crates/net/rpc/src/lib.rs
100.00% <ø> (ø)

crates/net/rpc/src/net/mod.rs
0.00% <0.00%> (ø)

crates/net/network/src/fetch/mod.rs
73.50% <0.00%> (-0.85%)
:arrow_down:

crates/interfaces/src/db/tables.rs
0.00% <0.00%> (ø)

crates/tasks/src/lib.rs
87.03% <0.00%> (ø)

crates/net/network/src/state.rs
50.22% <0.00%> (+0.44%)
:arrow_up:

crates/net/eth-wire/src/capability.rs
61.79% <0.00%> (+1.12%)
:arrow_up:

crates/net/network/src/listener.rs
84.09% <0.00%> (+2.27%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[FEATURE] Add a base strategy optimization pipeline for Backtesting.py

Add a base strategy optimization pipeline for the Backtesting.py library.
Don't forget the documentation.

change report_pdf and report_html to show the result heatmap from optimization


ENYO-2249: Migrate ExpandablePickerSample to moonstone-extra panels

Enyo-DCO-1.1-Signed-off-by: Igor Kuzko<EMAIL_ADDRESS>

Thanks @iKuzko. We should also comment out the sample from the samples list in moonstone-samples, so the build system doesn't load two versions of the JS/CSS. Like this PR: https://github.com/enyojs/enyo-strawman/pull/143/files#diff-e121d3b1897d905147bcd18359327c7aL46

Don't worry about it, I gotcha. :smile:

This PR is no longer necessary as we'll be integrating extra and regular into one branch, so this issue will automatically resolve itself soon.


Vue build not working

Hi,
I'm experimenting problems trying to compile the project. When I ran npm run build, the console throws me that message:

We are slimming down vue-cli to optimize the initial installation by removing the vue build command.
Check out Poi (https://github.com/egoist/poi) which offers the same functionality!

Maybe documentation of project contribution is outdated?
Thanks,

@Pedrazl say me more...
You import vuesax with npm?
Create a project with vue-cli-3 before?
When you import a lib, the scripts in package.json dont change, you use the build for the project created and not to libraries included.

Any idea @brunokunace ? What steps should I follow to work in the project and make a PR?


Missing / incorrect program mapping for TCR790WP dryer

The problem
I noticed that many of the programs of the TCR790WP dryer are missing (number shown), or mapped incorrectly. Some examples:

Program reported
Actual program

2
Cottons

9
Cottons ECO

1
Automatic extra

Automatic extra
Smoothing

I can provide a PR, but not sure how to handle those differing program mappings.
Version of miele integration having the issue?
0.0.23
Version of Home Assistant Core having the issue?
2022.8.6
Anything in the logs that might be useful for us?
No response
Additional information
No response

If you can provide a list program IDs/names (a complete one would be best), I can handle the PR.
Unfortunately Miele provides no list at all and various reverse engineered online sources are somewhat contradictory. We verified what we could with the available devices.

Sure, here you go:

Program reported
Actual program EN (UK)

2
Cottons

9
Cottons ECO

3
Minimum iron

5
Delicates

gentle_minimum_iron (= 31)
Bed linen

1
Automatic

4
Wollens handcare

17
Silks handcare

8
Express

14
Shirts

13
Denim

24
Steam care

15
Sportswear

22
Basket programme

16
Outerwear

12
Proofing

6
Timed drying Warm air

19
Standard pillows

7
Timed drying Cool air

cottons (=20)
Large pillows

11
Cottons hygiene

9
Cottons ECO

automatic_plus (=10)
Pre-ironing

@apeeters Thank you!
@astrandb We seem to have the first overlapping program IDs within a device class. (10, 20, 31). How should we handle that? Maybe solicit some more input in the forums first, to make sure there is actually overlap and some incorrect lists going around?

@mundschenk-at I think we must make sure that there is a true overlap before we redesign the mapping structure. I would be happy if you could ask around.

My TEJ675WP (dryer) reports this:
1	Automatic plus
2	Cottons
3	Minimum iron
4	Woollens handcare
5	Delicates
6	Warm air
7	Cool air
8	Express
9	Cottons
10	Pre-ironing
12	Proofing
13	Denim
14	Shirts
15	Sportswear
16	Outerwear
17	Silks handcare
19	Standard pillows
22	Basket programme
31	Bed linen

2 and 9 are Cottons, but 9 with a ' ' (single space) at the end.

Does your device have "Cottons ECO" (according to the manual/UI), @mamoel666? This might be a bug on Miele's side. I'll try get additional listings from other (older) dryers - they might have changed the numbering for their heat-pump models.

FYI: try different language settings on your machine, i.e. US vs UK make a huge difference.

I took the names directly from the Miele Swagger-UI.
The manual says:

@mundschenk-at If it turns out that there is troublesome overlap of raw_value we could change approach for translation.
We could use the returned clear text in default language (en) as index instead of the numeric value. This would be a breaking change for users that use the sensor values in templates or automations, The alternative to maintain separate tables for each device type and version can be an Sisyphean effort over time.

We could use the returned clear text in default language (en) as index instead of the numeric value. This would be a breaking change for users that use the sensor values in templates or automations, The alternative to maintain separate tables for each device type and version can be an Sisyphean effort over time.

I'm still hoping that any overlap will be "localized" to an easily identifiable subtype (i.e. dryers with WP as the last characters of their model number). I'll ask around in the HA forums.
@mamoel666 So Cottons  with the space is definitely the ECO variant. Apparently they only identified it by the tag/arrow on this device because it has a physical wheel for program selection (in the German EU energy consumption report it is identified as "Baumwolle mit Pfeil", i.e. "Cottons with arrow").

Sure, here you go:

For the record: these are the program names I see on the display of the machine, Iin HA, I only noted down the program id.

Hi, any update about this topic? I have a TCJ690WP tumble dryer and program names are completely wrong. At the moment I've forked the repository and I'm using my own mappings for the dryer programs.

I have an ongoing discussion with developers at Miele regarding the documentation of program names etc. Will report back here if we can get proper documantation directly from Miele or if we have to do some more reverse engineering.


SingleLineAfterImportsFixer - fix for line after import already added using CRLF

Fixes https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/5028

Thank you @kubawerlos.


ctx.delete doesn't return deleted value

When doing
form = ctx.delete(:form) #=> nil

the return value is nil. Maybe we shouldn't provide #delete in the first place?

Maybe we shouldn't provide #delete in the first place?

hmm good point. Although, ctx is intended to work extension over hash, yeah ?
PS: Fix is #15

Released in 0.5.1 🍻


Gateway silently conflict when port 80 has http2 and http

This is a common case occurring when mixing our autogenerated k8s ingress gateway with knative (or others). We have one gateway on port 80 which is using protocol HTTP2, and another using protocol HTTP

@rshriram any idea what we can/should do here? it seems like we should be able to support both h1 and h2 on port 80?

ref https://github.com/knative/serving/issues/5163


Returning from resource details view resets page number

A user navigates to the resources view and requests the details of a resource present on a page larger than 1
When the user clicks the back arrow from the resource details view, it is routed back to the first page of the resources view and not to the page the user came from.

Screencast from 2023-07-18 07-44-42.webm

@LukasStordeur my propositions for that improvement is to modify behaviour of the pagination and introduce extra dependency to query. But that comes with question, do we want to introduce that in every place that pagination is available or only to that specific page.
The changes itself doesn't seem to be complicated but they are at the root of components that are reused across this kind of pages.
Solution proposed:
change functions that are responsible to navigate through subpages from updating whole link to pass only parameter responsible for previous/next subpage back to the dependency list and from there keep track of current page.

@LukasStordeur


Version 1.2 (Submarine Update Patch)

Decided to make this myself using your code as a base.

Seems good, thanks for the contribution!


git clone fails if there are spaces in path

My username on my windows machine has a space in it and the git clone commands were failing because there were no quotes around the path so the command line thought the path was multiple arguments.

This issue is now fixed as of 0a263f1.


DOC: use README.rst for setup.py long-description

need to update pypi with this.

Current coverage is 87.19% (diff: 100%)

Merging #278 into master will not change coverage

@@             master       #278   diff @@
==========================================
  Files             5          5
  Lines           414        414
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            361        361
  Misses           53         53
  Partials          0          0

Powered by Codecov. Last update 88267c7...ee5c047

Can you update with the new Python README? That might be worth a proofread (I see at least one typo)

Will need to do an update of feather-format after Arrow 0.17.0 goes out and will update the README then. Thanks @jreback!


chore(package): update github-repository-provider to version 7.4.33

:tada: This PR is included in version 8.5.56 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Improve onboarding process for the new contributors

Is your feature request related to a problem? Please describe.

New contributors flow is reading the contribution guide, forking/fetching the repo, and then running tests. Without downloading and running devnet this error message will pop up:

Error: Jest: Got error running globalSetup - /Users/tabaktoni/Work/starknet.js/__tests__/config/jestGlobalSetup.ts, reason: Setting Account using all known strategies failed, provide basic test parameters

This means auto-setup is unable to configure default env params aka. no local devnet is running on port 5050
Describe the solution you'd like
Improve the process so that new contributors can frictionlessly run the tests.
The suggested solution is to alter the messaging suggesting devs download & run starknet-devnet-rs latest docker image and run on port 5050
docker run -p 5050:5050 shardlabs/starknet-devnet-rs:latest
starknet-devnet-rs Repo
Improve the contribution guide readme.
Describe alternatives you've considered
Propose an additional improvement to this process in the form of the issue.
Additional context
The final goal is to have a simple process for new contributors' onboarding with all required resources available.
Remove the necessity for core devs to support new contributors.

@tabaktoni  I can take this one, if that's ok :)


It is not possible to have a root node with empty path segment and a view

It's not possible to set the root node's path segment as an empty string or a slash - fix.

OK, maybe the navigation structure you provide is not as expected. This only works if you provide the nodes not as an array but as a single root node object (with children) where pathSegment is set to empty string. Maybe you provide an array (as we always had it like that in our examples, but now you can actually specify the tree from the root node (which is only one and that is why it may not be an array)).

@pekura You are right. Unfortunately I need an additional node in the top-navigation, so I need to have two main nodes, and because of that it won't work for me.


CALICO_K8S_NODE_REF needs docs

Need CALICO_K8S_NODE_REF documented. https://github.com/projectcalico/calico/blob/master/calico_node/startup/startup.go#L187

CC @emanic @ozdanborne
I thought we had these docs, but apparently not - anyone know where they went?


Add resource-pack-sha1 to server.properties

The sed command in
https://github.com/itzg/docker-minecraft-server/blob/master/start-finalSetup04ServerProperties#L16
does nothing if the line is not already in the file.

[09:14:03] [Server thread/WARN]: You specified a resource pack without providing a sha1 hash. Pack will be updated on the client only if you change the name of the pack.

This is now available on Docker Hub


How do I achieve this on Windows 7

I tried to run the script on windows 7 but I am not able to run it successfully.  Please find the error log below,
/system/bin/sh: D:/Public/Git/Git/data/local/tmp/adbmirror//minicap: not found
/system/bin/sh: D:/Public/Git/Git/data/local/tmp/adbmirror//minitouch: not found
Please do the needful on this.

This was never intended to run on windows.
But I guess that you are missing some binaries

any workaround to run on windows?

I do not know, I do not use windows.


Training a model with data not COCO style

❓ Questions and Help
Hi,
I'm trying to implement this model, but the context of the images is completely different to COCO's context, I mean there isn't similar classes or objects in general, so my question is if is possible to NOT use the COCO style format? I only have the information of every polygon in order to get the mask, also I need to use different classes, where are defined the classes of the model?
Thanks!

You can create your own dataset object, like the one present in voc.py, but you'd need to also write some evaluation code and it would be quickly complicated.
You can use the COCO style dataset for your custom dataset, and the classes can be completely different. It's generally easier to go via this approach than writing your own evaluation script.

I'm closing this issue, but let me know if you have further questions

Hi @fmassa
You have right, I convert my dataset to COCO style, now I have a problem with the shapes, I already did the changes in the config file according with #297, I have only 5 classes (background included) but the model is still waiting for the 81 classes of coco dataset.
Error:
RuntimeError: Error(s) in loading state_dict for GeneralizedRCNN: 	size mismatch for roi_heads.box.predictor.cls_score.weight: copying a param with shape torch.Size([81, 1024]) from checkpoint, the shape in current model is torch.Size([5, 1024]). 	size mismatch for roi_heads.box.predictor.cls_score.bias: copying a param with shape torch.Size([81]) from checkpoint, the shape in current model is torch.Size([5]). 	size mismatch for roi_heads.box.predictor.bbox_pred.weight: copying a param with shape torch.Size([324, 1024]) from checkpoint, the shape in current model is torch.Size([20, 1024]). 	size mismatch for roi_heads.box.predictor.bbox_pred.bias: copying a param with shape torch.Size([324]) from checkpoint, the shape in current model is torch.Size([20]). 	size mismatch for roi_heads.mask.predictor.mask_fcn_logits.weight: copying a param with shape torch.Size([81, 256, 1, 1]) from checkpoint, the shape in current model is torch.Size([5, 256, 1, 1]). 	size mismatch for roi_heads.mask.predictor.mask_fcn_logits.bias: copying a param with shape torch.Size([81]) from checkpoint, the shape in current model is torch.Size([5]).
Idk if the problem is the model that I load, it's the same used in demo.ipynb: ../configs/caffe2/e2e_mask_rcnn_R_50_FPN_1x_caffe2.yaml
Or I have to change something else.
My class dataset has the same structure of coco.py, extends torchvision.datasets.coco.CocoDetection and has the same returning values (without keypoints).
I'm literally reading all the source code in order to understand as much as possible (btw it's a beautiful code), I want to make a tutorial step-by-step of how to use this model, but it's a bit tricky.
Thanks.

The problem is that you need to adapt the state_dict of the model to remove the last layers, which are specific to COCO (81 classes). More information can be found in https://github.com/facebookresearch/maskrcnn-benchmark#finetuning-from-detectron-weights-on-custom-datasets

Excellent! Thanks for your quick response!!

Hi
I have created a Maskrcnn_benchmark model for medical images with 3 classes (High grade, Normal grade and Low grade). My model detects only high grade, not other two which means I got only one specific output. I have used coco style json file, 5000 Iterations, 93 high grade images, 23 normal images and 25 low gade images. Any help please.
Many thanks


[BUG]: Next.js 15 + middleware causes __import_unsupported error

Describe the bug
If I have an Next.js app that is on Next.js 15 and has a middleware, the adapter can build the application but at runtime the application throws a __import_unsupported error:

Steps to reproduce

Create a new Next.js 15 application
Install the adapter (the experimental release)
add a middleware file
build and preview the application
navigate to the application's url to see the error

Minimal reproduction: https://github.com/dario-piotrowicz/open-next-15-middleware-experimental-repro
Expected behavior
The application should just work
@opennextjs/cloudflare version
https://pkg.pr.new/@opennextjs/cloudflare@experimental
Node.js version
20
Wrangler version
3
next info output
Operating System:
  Platform: darwin
  Arch: arm64
  Version: Darwin Kernel Version 24.1.0: Thu Oct 10 21:03:15 PDT 2024; root:xnu-11215.41.3~2/RELEASE_ARM64_T6000
  Available memory (MB): 32768
  Available CPU cores: 10
Binaries:
  Node: 20.11.0
  npm: 10.2.4
  Yarn: 1.22.19
  pnpm: 9.12.1
Relevant Packages:
  next: 15.1.0 // Latest available version is detected (15.1.0).
  eslint-config-next: 14.2.5
  react: 19.0.0
  react-dom: 19.0.0
  typescript: 5.7.2
Next.js Config:
  output: N/A

Additional context
#141 implements a simple fix for this
but:

the fix should be done properly with AST manipulation
we should understand better why this issue gets triggered and if the proposed patch is the appropriate solution

We already have a fix for this in aws but at the moment it's not applied to cloudflare https://github.com/opennextjs/opennextjs-aws/blob/697681bf9ce25212ce4e2e94d886ca425428280d/packages/open-next/src/build/edge/createEdgeBundle.ts#L141-L147. Just moving this a few line up should be enough.
This happens when the middleware runs in the same place as the main handler.
They use defineProperty for __import_unsupported both in the middleware and in the main server but they define it with configurable:false

Great, thanks for the context @conico974 😄
Ah ok, so you're saying that this is a fix to be made in the aws package and that we'll then inherit right? 🙂
I'm happy to give it a go unless you want to take it on 😄

I could do it tomorrow if you want, but if you want to do it in the meantime feel free to do so

I could do it tomorrow if you want, but if you want to do it in the meantime feel free to do so

https://github.com/opennextjs/opennextjs-aws/pull/678 🙂

Reopening until this is merged to main

Reopening until this is merged to main

Added to the Done (experimental branch) column


[Snyk] Upgrade @grpc/grpc-js from 1.7.3 to 1.10.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @grpc/grpc-js from 1.7.3 to 1.10.1.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 39 versions ahead of your current version.
The recommended version was released a month ago, on 2024-02-15.

Release notes

Package name: @grpc/grpc-js

1.10.1 - 2024-02-15
Fix a bug causing channels using the round_robin LB policy to fail to reconnect after a connection drops (#2667)

1.10.0 - 2024-02-06
Implement gRFC A52: gRPC xDS Custom Load Balancer Configuration (#2555)
Implement gRFC A42: xDS Ring Hash LB Policy (#2568)

Note: This feature is not compatible with Node 14 or below. To disable it in those versions, set the environment variable GRPC_XDS_EXPERIMENTAL_ENABLE_RING_HASH=false.

Implement the xDS part of gRFC A62: pick_first: sticky TRANSIENT_FAILURE and address order randomization (Currently experimental, enabled by environment variable GRPC_EXPERIMENTAL_PICKFIRST_LB_CONFIG) (#2572)

1.9.14 - 2024-01-16
Fix a bug that could rarely cause connection leaks (#2644)
Fix a bug that could cause clients to go IDLE incorrectly some time after calling waitForReady (#2643)

1.9.13 - 2023-12-12
Fix a bug that could cause the Node process to close early when establishing a connection while a request is pending (#2626)

1.9.12 - 2023-11-27

1.9.11 - 2023-11-16

1.9.10 - 2023-11-14

1.9.9 - 2023-10-30

1.9.8 - 2023-10-27

1.9.7 - 2023-10-19

1.9.6 - 2023-10-17

1.9.5 - 2023-10-02

1.9.4 - 2023-09-26

1.9.3 - 2023-09-13

1.9.2 - 2023-08-31

1.9.1 - 2023-08-22

1.9.0 - 2023-08-01

1.8.21 - 2023-07-28

1.8.20 - 2023-07-25

1.8.19 - 2023-07-24

1.8.18 - 2023-07-13

1.8.17 - 2023-06-27

1.8.16 - 2023-06-20

1.8.15 - 2023-06-05

1.8.14 - 2023-04-12

1.8.13 - 2023-03-23

1.8.12 - 2023-03-07

1.8.11 - 2023-02-24

1.8.10 - 2023-02-22

1.8.9 - 2023-02-15

1.8.8 - 2023-02-08

1.8.7 - 2023-01-25

1.8.6 - 2023-01-25

1.8.5 - 2023-01-23

1.8.4 - 2023-01-12

1.8.3 - 2023-01-11

1.8.2 - 2023-01-09

1.8.1 - 2023-01-03

1.8.0 - 2022-12-07

1.7.3 - 2022-10-21

    from @grpc/grpc-js GitHub release notes

Commit messages

Package name: @grpc/grpc-js

513a61a Merge pull request #2667 from murgatroid99/grpc-js_round_robin_idle_fix
429a66d grpc-js: round_robin: always have children reconnect immediately
1b753af Merge pull request #2656 from murgatroid99/grpc-js_1.10.0
2555725 Merge pull request #2655 from murgatroid99/grpc-js-xds_1.10_deexperimentalize
b1c45a8 grpc-js/grpc-js-xds: Bump version to 1.10.0
322b165 grpc-js-xds: De-experimentalize tested features and update feature list
f70c322 Merge pull request #2650 from murgatroid99/grpc-js_server_interceptors
4d7a7fb Merge pull request #2651 from satazor/support/remove-typescript-as-dep
7c9a5e7 Make extra trailer behavior consistent with old code
24c258a grpc-health-check: Move `typescript` as a dev dependency
f52d142 grpc-js: Implement server interceptors
666a374 Merge pull request #2645 from murgatroid99/master_merge_1.9.x
3915f57 Merge 1.9.x into master
5be83dd Merge pull request #2643 from murgatroid99/grpc-js_idle_timer_fix
b8dc020 Merge pull request #2644 from murgatroid99/grpc-js_channelz_socket_connecting_handle_fix
2b31f8c grpc-js: Shutdown transport if a state change occurs while connecting
6da0b49 grpc-js: Fix and optimize IDLE timeouts
442e3ea Merge pull request #2638 from XuanWang-Amos/backport-1.9-psm-interop-shared-build
6e6f942 Merge pull request #2635 from XuanWang-Amos/psm-interop-shared-build
2a7c906 Merge pull request #2637 from chakhsu/master
9b68bce Merge pull request #2635 from XuanWang-Amos/psm-interop-shared-build
3cdaebd fix: export type VerifyOptions
493f9bf buildscripts: Use the Kokoro shared install lib from the new repo
c5d35fe Merge pull request #2634 from Spinny03/master

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

@dependabot rebase


v-on:click not working on md-button

I'm trying to call a function after clicking a <md-button> with v-on:click, but it's not working. When I try the same thing with a ordinary <button>, it does work.
Here's a CodePen: http://codepen.io/anon/pen/WRWxzP
Thanks for the great work! :D

Try v-on:click.native. See https://github.com/marcosmoura/vue-material/releases/tag/v0.7.0

Thanks dude, worked like a charm!


Main documentation

Why did you delete the thread_pool? I still use it in the main to do tests... it will be eventually deleted but not today.

?


[BUG]gen model-package with relative path has incorrect imports from v0.25.0

Problem statement
gen model-package with relative path has incorrect imports from v0.25.0
Command
swagger generate server -P v1.Principal -A iotx -t ./ -f ./swagger/swagger.yaml --model-package=../pkg/endpoint/v1

Imports
v0.24.0
...
// This file was generated by the swagger tool.
// Editing this file might prove futile when you re-run the generate command

import (
	"net/http"

	"github.com/go-openapi/runtime/middleware"

	v1 "github.com/kaisawind/iotx/pkg/endpoint/v1"
)
...

v0.25.0
// This file was generated by the swagger tool.
// Editing this file might prove futile when you re-run the generate command

import (
	"net/http"

	"github.com/go-openapi/errors"
	"github.com/go-openapi/runtime/middleware"
	"github.com/go-openapi/runtime/security"
	"github.com/go-openapi/strfmt"
	"github.com/go-openapi/swag"
	"github.com/go-openapi/validate"

	"github.com/kaisawind/iotx/apiserver/restapi/operations"
	"github.com/kaisawind/iotx/apiserver/restapi/operations/command"
	"github.com/kaisawind/iotx/apiserver/restapi/operations/device"
	"github.com/kaisawind/iotx/apiserver/restapi/operations/logr"
	"github.com/kaisawind/iotx/apiserver/restapi/operations/oauth"
	"github.com/kaisawind/iotx/apiserver/restapi/operations/product"
	"github.com/kaisawind/iotx/apiserver/restapi/operations/rule"
	"github.com/kaisawind/iotx/apiserver/restapi/operations/system"
	"github.com/kaisawind/iotx/apiserver/restapi/operations/topic"
	"github.com/kaisawind/iotx/apiserver/restapi/operations/user"
	"github.com/kaisawind/iotx/pkg/endpoint/v1"
)

v0.24.0 ✔
v0.25.0 ❌
v0.26.0 ❌
v0.27.0 ❌
Swagger specification
Has nothing to do with swagger
Steps to reproduce
swagger generate server -P v1.Principal -A iotx -t ./ -f ./swagger/swagger.yaml --model-package=../pkg/endpoint/v1

Environment
swagger version: 0.27.0
go version: 1.16.5
OS: Linux 5.10.42-1-MANJARO

imports now working
https://github.com/golang/go/issues/45398

Maybe it can help other people who are in this trouble.
http://docs.studygolang.com/doc/go1.16
Build commands like go build and go test no longer modify go.mod and go.sum by default.
Instead, they report an error if a module requirement or checksum needs to be added or
updated (as if the -mod=readonly flag were used). Module requirements and sums may be
adjusted with go mod tidy or go get.

Goimport not working very well, when there is a module requirement.
Because imports.Processcan't throw an error, when go mod error, so go-swagger looks like it runs fine, but it's not.
When we use goimport -v -w *.go command to format go file, we get the same go file, nothing changed. But we can get many errors, just like blow.
2021/07/29 10:25:23.504525 loading package names: err: exit status 1: stderr: go<EMAIL_ADDRESS>requires
<EMAIL_ADDRESS>missing go.sum entry; to add it:
        go mod download github.com/golang-jwt/jwt

Just go mod tidy before run go-swagger, all works well

@casualjim @sbstp

It's not go-swagger's, but go imports module.


Allow custom decoders for spec fields

In nebula-sdk the decoder was a json decoder, and spec field receiving structs could implement UnmarshalJSON for custom decoding. The shift to mapstructure lost this ability. Luckily mapstructure 1.4.1 adds a TextUnmalshallerHookFunc that will apply when decoding fields that implement UnmarshalText.
Specifically: https://github.com/relay-integrations/relay-email/blob/d418e3930a1cad5d547653999f680e9377d2d95a/steps/email-sender-smtp/pkg/sender/spec.go#L8-L20

Don't forget to update CHANGELOG.md before you cut a new release.


check mov_mask for foreground

From what I understand blocks which are all in the mask should not be considered for the registration, I think checking the mov_mask is missing.

Hi @orena1! Thanks for another BigStream PR!
This is a good thought, but actually cannot be merged. There is a reason we only check the fixed image mask for determining which blocks to process. Recall that the fixed and moving image do not have to be on the same voxel grid. For example, you might have a fixed image shape of (1000, 2000, 3000) and spacing of (1.0, 0.5, 0.5) and a moving image shape of (500, 750, 1000) and spacing of (1.5, 2.0, 2.0). It's still perfectly ok to register these two images.
Now, when we carve the image into blocks we must choose which voxel grid upon which to define our blocks, it cannot be consistently defined on both voxel grids at the same time when we account for the possibility of the images having different shapes. We definitely want to choose the fixed image voxel grid to define our blocks, since the final deform will also be defined on this voxel grid. Simply looking at the same voxel coordinates in the moving image/mask does not account for the possibility that the grids could be different. It also does not account for any image origins or initial transforms given in the static_transform_list.
Alternatively, what would make sense, is to check the fixed mask in the block as we do now, but then determine exactly which region this block corresponds to in the moving voxel grid - after accounting for the different voxel spacings, possibly different image origins, and any initial transforms given. Then we could check the moving image mask in that mapped region. However this is a very expensive computation to do up front in the main process for every block and the feature is not worth the expensive computation. We do have to do this once we have mapped all the blocks to separate workers, see here, but that is done on the workers, so it's in parallel and isn't a bottle neck point for the overall computation.
Now that I think about this however, a better implementation would be to do this moving mask foreground check in the distributed function, instead of up front. This would avoid trying to align blocks which have fixed data foreground to blocks that have no moving image foreground - which would likely result in a distortion. Let me know if you're following me here, because I think this is a good idea worth discussing, it just needs to be in a different spot.

The idea is that the moving mask foreground check would occur just after this line. If there is foreground, we just proceed with the alignment. If there is no foreground I think we would need to create a dummy transform result - a vector field of the correct shape with all zeros - and then proceed with that as if it had actually been computed. Basically we would just be skipping the call to the alignment pipeline. That would save time, and it would also possibly prevent distortions in areas where there is fixed foreground but no moving foreground.

Thanks a lot @GFleishman , I understand the problem.
My work involves registering 2d-slices to 3d, the 2d-slices are extended to 3D stacks, but many of the pixels in that fake-3D stack are 0s. This result with trying to register a real-3D-block to a block with is black and than we get to this error:

I assume I am lucky as when I move the 2D slice to fake-3D I transform the spacing to be identical to the 3D, so my solution works, but indeed it will not be general enough.
I must say that I do not really understand how the spacing works, I understand the intuition but do not really understand how you overcome it, so I do not know how to implement your suggested solutions.
Thanks

Hi again - thanks for describing your application. Lots of others have asked me about 2D to 3D registration so I'm really excited that someone is using BigStream to make that possible. Now that I understand your problem, there are two new feature proposals I can suggest that might make your workflow easier. I may have time to implement one of these myself soon.
Feature proposal 1: Add virtual masking options
Currently, fix_mask and mov_mask must either be None or a numpy array containing ones and zeros. That is, you have to explicitly create your own mask outside of bigstream and then provide it. I would consider allowing fix_mask and mov_mask to also be a tuple of arbitrary length containing ints or floats. In such a case, the function would consider any value in that tuple to be background, and create masks internally where appropriate, using that data. Going one step further I could allow fix_mask and mov_mask to be a function which takes an array as input and returns a bool. In that case, bigstream would apply that function internally at the appropriate times to create masks.
For your application, you could then just do mov_mask=(0,) to mask out all your padded data. Internally this would be much easier to work with than a large array equal in size to the image itself.
Feature proposal 2: Add image origins to the distributed_piecewise_alignment_pipeline
Right now it sounds like when you convert from 2D to 3D you are simply padding planes of zeros on top of and below the real data. You would do this such that the final shape of the padded "faked 3D" image is the same as the fixed image shape, and you would put the correct number of planes above and below such that the position of the real data plane was as close as possible to where you think it needs to register into the fixed 3D volume. Is that correct?
If you were doing this with the in-memory non-distributed function I would suggest that you use a mov_origin. All the alignment functions in align.py take this argument. Here it is for the alignment_pipeline. The documentation is obviously pretty sparse so I don't blame anyone for not understanding how this could help them. Basically the origins let you specify how the fixed and moving image voxel grids should be positioned relative to one another.
So, for your application, instead of padding with a really large number of planes above and below the real data plane, you would pad with just a few planes above and below, and then define a mov_origin that was equal to the offset of the moving data (0, 0, 0) voxel from the fixed data (0, 0, 0) voxel. Origins are in physical units, so you would need to take the voxel spacings into account.
However - origins are currently not available for the distributed pipelines because they complicate the blocking process. However I think this is solvable and I may be willing to work on it in the future.

Also @orena1, I noticed that you have not clicked the star button for the bigstream repository. If you are finding it useful, and want to motivate us to add features and provide support, can you please do so? The best reason to continue building open source software is because you know it is making an impact. Simple metrics like the star count help me demonstrate impact.

Hi @GFleishman , so the 2D -to- 3D stack is a plane, but it is manually warpped with bigwarp, the results is a warpped 2D plane inside a cube,  usually the some part of the plane (albit small) is visible in each Z-plane of the fake stack.
I think the first solution that you suggested is more easy to understand and use as a user. Thanks a lot!
My current use-case currently is to finetune the bigwarp registration using deform registration with bigstream.

Hi again! Thanks for following through and starring the repository, I'm really grateful!
That's great that you're combining BigWarp and BigStream - that is a really powerful workflow that should be able to handle almost any image registration problem. You may not want to get into this too much, but it is possible to take the transform from BigWarp and use it with BigStream. Here's a post I wrote recently helping someone else do just that:
https://forum.image.sc/t/combining-bigwarp-and-bigstream/95663/3
Ok - I'm going to close this PR without merge, but again thanks so much for offering it and sparking a good discussion. I'm going to submit a feature-request to the issues section of the repository describing the two features above and I'll note that you're more interested in feature (1), which I agree is more easy to use right away.


Pinning icon alignment

@roryabraham Please have a look
Details
Fixed regression that caused due to my PR
Fixed Issues
Fixes https://github.com/Expensify/Expensify.cash/issues/1728
https://github.com/Expensify/Expensify.cash/issues/1661
Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[ ] Android

Screenshots
Web

Mobile Web

Desktop

iOS

Android

Hmm actually I think this did not fix the issue.
You can see from the outline that the entire row is not clickable:

The outline should encompass the entire row, and the pin & pencil icons should be nested inside of the row and they should be clickable.


schema.prisma comment with double quote occurs error

Bug description

/Users/kyu/Desktop/hakhak/hakhak/node_modules/@prisma/client/index.js:210
const dmmf = JSON.parse(dmmfString)
                  ^
SyntaxError: Unexpected token 앞 in JSON at position 4899
    at JSON.parse (<anonymous>)
    at Object.<anonymous> (/Users/kyu/Desktop/hakhak/hakhak/node_modules/@prisma/client/index.js:210:19)
    at Module._compile (internal/modules/cjs/loader.js:955:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:991:10)
    at Module.load (internal/modules/cjs/loader.js:811:32)
    at Function.Module._load (internal/modules/cjs/loader.js:723:14)
    at Module.require (internal/modules/cjs/loader.js:848:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/kyu/Desktop/hakhak/hakhak/src/services/prisma.service.ts:62:16)
    at Module._compile (internal/modules/cjs/loader.js:955:30)

A comment with double quote in schema.prisma occurs error about JSON parsing like below

schema.prisma

// fin :
// "앞으로
// 좋겠다!"

@prisma/client/index.js

const dmmf = JSON.parse(dmmfString)

How to reproduce
run my project ( ts-node main.ts )
Expected behavior
In documentation properties, Prisma should escape quote or double quote.
Prisma information
@prisma/cli          : 2.0.0-beta.2
Environment & setup

OS: [e.g. Mac OS, Windows, Debian, CentOS, ...]
Database: [PostgreSQL, MySQL, MariaDB or SQLite]
Prisma version: [Run prisma -v to see your Prisma version]
Node.js version: [Run node -v to see your Node.js version]

Hi,
Can you please provide a complete reproduction inside of a Git repository? I was unable to reproduce this in my reproduction attempt as shown below:

prisma generate
yarn dev

schema.prisma

prisma generate

ts-node main.ts

when I delete double quote in schema.prisma, error disappears

I am still unable to reproduce this:

Can you please tell me which OS you are using and please paste the datamodel here once instead of the screenshot :pray:?

My prisma/client version was preview025.
I think that was the reason why I got error.


mpd: provide service file

Like for example mdev does, in /ect/sv/

mpd is meant to run by the user, not by root. I cannot add a service file that is user specific.

mpd has a specific user setting to run in as a user (user mpd in my case), see https://wiki.archlinux.org/index.php/Music_Player_Daemon#System-wide_configuration

On 2020-04-10 01:08, Camille wrote:

mpd has a specific user setting to run in as a user (user mpd in my
case), see
https://wiki.archlinux.org/index.php/Music_Player_Daemon#System-wide_configuration
--
You are receiving this because you commented.
Reply to this email directly, view it on GitHub [1], or unsubscribe
[2].
Links:
[1]
https://github.com/kisslinux/community/issues/646#issuecomment-611776365
[2]
https://github.com/notifications/unsubscribe-auth/AHU5WZC5DZXQIAG64SICULTRLZBMPANCNFSM4MDMJZOQ

Oh, I didn't know about that. I'll add a service script then. Thanks for
the input.
--
Best regards,
Cem Keylan


Allow using noted items on (demon) butlers

unable to use noted items on demon butler in poh

Added in 25055f80a836b32a02bd63e05472015619b89390 and will be in the next release :)


[exec] Add template support

Description
This PR makes leeway exec interpret the command as template. With this change users can now

use exec as means to query the workspace, e.g. list all Go packages:leeway exec --filter-type go -- echo {{ .Package.FullName }}

use exec to continue to interact with leeway, e.g. build all Yarn packages:leeway exec --filter-type yarn --plain -- echo leeway build {{ .Package.FullName }} | sh

Similar things could be done with leeway describe, but would require jq and more effort:
# list all Go packages
leeway collect -o json | jq -r '.[] | select(.type == "yarn") | .metadata.fullName'

# build all Yarn packages
leeway collect -o json | jq -r '.[] | select(.type == "go") | .metadata.fullName' | while read f; do echo leeway build $f; done | sh

Closing for now - the same can be achieved with leeway collect


Docker login fails with missing errors

I am using azure/docker-login for quite a while but now it is failing with a weird error of missing username while login, whereas I have already configured the secrets.
A more intriguing fact is that this error is only shown in the case of the event pull_request but when a commit is made to master the login is a success.
Logs & Pull Request :
https://github.com/layer5io/meshery/pull/1952/checks?check_run_id=1430739345

Did you grab the latest commit ID from the action? Looks like environment variable updates broke this... I moved to the latest version, but now we get errors about not finding the module @actions/core... hmm.
Here's the error I see after moving to azure/docker-login@944f3176a9cfe29e1c53e92dff83e4f8c6eef52b
Probably needs to be added to the package.json file?
internal/modules/cjs/loader.js:800
    throw err;
    ^

Error: Cannot find module '@actions/core'
Require stack:
- /home/runner/work/_actions/azure/docker-login/944f3176a9cfe29e1c53e92dff83e4f8c6eef52b/lib/login.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:797:15)
    at Function.Module._load (internal/modules/cjs/loader.js:690:27)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/home/runner/work/_actions/azure/docker-login/944f3176a9cfe29e1c53e92dff83e4f8c6eef52b/lib/login.js:11:14)
    at Module._compile (internal/modules/cjs/loader.js:959:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:995:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Function.Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module.runMain (internal/modules/cjs/loader.js:1047:10) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/runner/work/_actions/azure/docker-login/944f3176a9cfe29e1c53e92dff83e4f8c6eef52b/lib/login.js'
  ]
}

We switch to dockerhub login action as soon as we experienced error with the azure, but do let me know if the action gets fixed again 🙂

@jeffwilcox Could you share the version that you are specifying with the action? Ideally it should be v1.
@kushthedude Could you share the logs of failing workflow? The current link doesn't seem to have any logs.

Closing this stale issue. If the problem still persists fee free to re-open this. 😃


(#386) Update autoComplete dropdown

Description Of Changes
This updates the autoComplete dropdown to use <p> elements instead of
<ul> elements. This allows the proper selections to be made in the
dropdown.
Motivation and Context
This bug was causing the wrong package to be search for.
Testing

Run the site.
Search for mar, but do not select anything or press enter.
On your keyboard, press the down arrow. You are taken to the first suggestion.
Click with your mouse on the first suggestion, and you are taken to the correct url. Repeat for other suggestions if wanted.

Operating Systems Testing
n/a
Change Types Made

[x] Bug fix (non-breaking change).
[ ] Feature / Enhancement (non-breaking change).
[ ] Breaking change (fix or feature that could cause existing functionality to change).
[ ] Documentation changes.
[ ] PowerShell code changes.

Change Checklist

[ ] Requires a change to the documentation.
[ ] Documentation has been updated.
[ ] Tests to cover my changes, have been added.
[ ] All new and existing tests passed?
[ ] PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

https://github.com/chocolatey/home/issues/302
https://gitlab.com/chocolatey/community-infrastructure/community.chocolatey.org/-/issues/1257
https://github.com/chocolatey/choco-theme/issues/386

@st3phhays thank you very much for getting this fixed!


Fix/table changes

add ability to change header color, rows color, add ability to create monochrome table

Hi @SavDelMar! I would like to suggest couple improvements to your pr. I would rename commit messages and prop names to headerBackgroundColor and rowBackgroundColor since you changing only it.

From my perspective, it just makes things more complicated. This is a pretty specific case that can only be used once. Moreover, everything that's introduced in this PR can be done via CSS on the project level.
This is exactly why we have classNames as static strings so that they can be modified at the project level.

@SavDelMar it there some ticket for those changes?

@SavDelMar is there some ticket for those changes?

I agree about colors, but in Panenco Design system we have 2 types of tables: striped and monotone with dividers, so maybe it would be useful to have this  'striped' prop . But yes, it also can be done via css

Closed for now. Won't be used in all project, so will be implement in one project only


Internal pages omit product name

In Chromium, any internal chrome:// pages - like settings, bookmarks, extensions - have a "Chromium" title in the address bar, along with the product icon. Firefox also has this style for everything that starts with about:
Why does this userstyle hide the title then? Or even if intended, a preference would make sense.
Firefox 63.0b8, style build b0002274c55e25484d794999e256a6ea8ea0b61f.

Should have been fixed in 1ba2429685e81811d8d3c38d283a1c0e5c0edf07.

Confirmed fixed.


Add 'pre-commit' configuration and fix style

This revision includes:

Add .pre-commit-config.yaml for pre-commit package
Modify some files' style to pass the pre-commit test

Are there any concerns, @utilForever ?


Quote Generator App

Using an API to build a random quote generator

I would like to work on this issue.Please assign it to me @urvashi-code1255 @harshgupta20 :)

I would like to work on it

I would like to work on this issue for GSSOC 2021. I would implement this idea using an API wherein a user could choose a category and the quote would be generated accordingly.


what the difference between process.env.NODE_ENV === development  and DEV ?

When creating logger, sample code is like this one:
if (process.env.NODE_ENV === `development`) {
  const createLogger = require(`redux-logger`);
  const logger = createLogger();
  middlewares.push(logger);
}

Is there any difference with the following one?
if (___DEV___) {
  const createLogger = require(`redux-logger`);
  const logger = createLogger();
  middlewares.push(logger);
}

It depends on your webpack config.
If you define __DEV__ in webpack, it'll be available as global. It some boilerplates it equals process.env.NODE_ENV.


broken by a recent commit to telescope

get_node_text now returns multiple lines which telescope does not lik

fix it in the plugin, but need to code a better solution


Flutter released apk is not working but debug apk is working fine

The _getMessages() function is used to fetch SMS messages from the phone and stores them in _messages. Also, in the UI part, I have a reload button (floatingActionButton), which calls _getMessages().Now, the expected behavior is that as soon as the app is opened, the existing messages should be fetched and displayed, and for new messages which arrive later, to view them on-screen, the user can press the reload button which calls _getMessages() again and the new messages are displayed.
This code works in the debug apk, but the released apk when installed on other devices (not in debugging mode), the application doesn't work.
import 'package:OffQuiz/home/Quiz/quizCard.dart';
import 'package:OffQuiz/shared/appBar.dart';
import 'package:flutter/material.dart';
import 'package:telephony/telephony.dart';

class Home extends StatefulWidget {
  Home({Key? key, required this.title}) : super(key: key);

  final String title;

  @override
  _HomeState createState() => _HomeState();
}

class _HomeState extends State<Home> {
  final telephony = Telephony.instance;
  List<SmsMessage> _messages = [];

  @override
  void initState() {
    super.initState();
    _getMessages();
  }

  Future<void> _getMessages() async {
    List<SmsMessage> temp;
    temp = await telephony
        .getInboxSms(columns: [SmsColumn.ADDRESS, SmsColumn.BODY]);
    setState(() {
      _messages = temp;
    });
  }

  @override
  Widget build(BuildContext context) {
    // getMessages();

    return Scaffold(
      appBar: appBar("OffQuiz"),
      body: _messages.length != 0
          ? ListView(
              children: _messages
                  .map((quiz) => QuizCard(
                        quiz: quiz,
                      ))
                  .toList(),
            )
          : Center(
              child: Column(
                mainAxisAlignment: MainAxisAlignment.center,
                crossAxisAlignment: CrossAxisAlignment.center,
                children: [
                  Text(
                    "Please reload to fetch the latest quizzes",
                    style: TextStyle(
                        fontSize: 20,
                        fontWeight: FontWeight.w400,
                        color: Colors.grey),
                  ),
                ],
              ),
            ),
      floatingActionButton: FloatingActionButton(
        onPressed: _getMessages,
        child: Icon(
          Icons.refresh,
          color: Colors.white,
        ),
      ),
    );
  }
}

@shounakmulay can you please help here.

Issue Resolved


Cocoapods

Love it so muchs! Will be available through cocoapods? Thank you!

@ivangodfather I haven't gotten around to Cocoapods yet, but if you'd like to submit a pull request, it's always welcome :)
Otherwise, I'll try to get around to it one of these days.

I done this implementation myself last month for my library. Just follow this post and this checklist.

@edekhayser We can't just submit a pull request because you as the owner have to send it to CocoaPods

@lfarah Thanks for the links, I just set it up. If you could verify that it is working, it would be much appreciated.


Argument of type "null | string" is not assignable to parameter of type "null | string"

Bicep version
0.12.1
Describe the bug
After upgrading to 0.12.1 we get the following error on conditional property values using the ternary operator. The code did work for at least 16 months before, but after the upgrade the compilation fails. Even the error message is confusing as the mentioned types match:
Argument of type "null | string" is not assignable to parameter of type "null | string"
We are getting this error for the following resource block:

We didn't change that code for over a year.
To Reproduce
See screenshot
Additional context
We compiled the exact same code with previous bicep versions and it works. So it seems this error is definitely caused by version 0.12.1

yes, I have the exact error too. @alex-frankel @briandmoore I have emailed you my error earlier today. this is impacting customer's deployments when using Azure Pipeline with Microsoft Hosted agents since this version has already made its way to Azure DevOps

Same issue here

Same issue with object
Argument of type "null | object" is not assignable to parameter of type "Identity | null" (BCP070)

having the same today. Yesterday there was no issue with that code.
Error BCP070: Argument of type "null | object | object" is not assignable to parameter of type "Identity | null".

yes, I have the exact error too. @alex-frankel @briandmoore I have emailed you my error earlier today. this is impacting customer's deployments when using Azure Pipeline with Microsoft Hosted agents since this version has already made its way to Azure DevOps

Not able to uninstall the current binary and install older binary either, I had no luck. System environment variable can be changed so it references the old binary.

What else I have noticed, I only got this error in local modules. Using the same module published in an ACR will not produce this error!

What else I have noticed, I only got this error in local modules. Using the same module published in an ACR will not produce this error!

Same here.

Working on it! We will work on getting a new release out ASAP. In the meantime, are folks able to downgrade to an older version using az bicep install --version v0.11.1?

I haven't updated bicep since a while and also getting this error in vscode and in a pipeline with ubuntu (ms-hosted) agents. Both are not using v12

@SeSeicht -- VS Code and the hosted agents are both capable of auto-upgrading. Can you confirm you are not running v0.12 by checking az bicep version in your pipeline and/or checking the extension:

@SeSeicht -- VS Code and the hosted agents are both capable of auto-upgrading. Can you confirm you are not running v0.12 by checking az bicep version in your pipeline and/or checking the extension:

you are right, my vscode extension is updated automatically, even az bicep version is still showing the old version

@SeSeicht -- VS Code and the hosted agents are both capable of auto-upgrading. Can you confirm you are not running v0.12 by checking az bicep version in your pipeline and/or checking the extension:

2022-11-04T15:58:56.9203654Z /home/vsts/work/1/s/policies/assignments/policyAssignmentsModule/resourceGroup/deploy.bicep(74,20) : Error BCP070: Argument of type "null | object | object" is not assignable to parameter of type "Identity | null".
2022-11-04T15:58:56.9204601Z /home/vsts/work/1/s/policies/assignments/policyAssignmentsModule/resourceGroup/deploy.bicep(74,20) : Error BCP070: Argument of type "null | object | object" is not assignable to parameter of type "Identity | null".
2022-11-04T15:58:56.9207063Z /home/vsts/work/1/s/policies/assignments/policyAssignmentsModule/managementGroup/deploy.bicep(59,20) : Error BCP070: Argument of type "null | object | object" is not assignable to parameter of type "Identity | null".
2022-11-04T15:58:56.9207814Z /home/vsts/work/1/s/policies/assignments/policyAssignmentsModule/managementGroup/deploy.bicep(59,20) : Error BCP070: Argument of type "null | object | object" is not assignable to parameter of type "Identity | null".
2022-11-04T15:58:56.9209356Z /home/vsts/work/1/s/policies/assignments/PolicyAssignments_cx.bicep(105,31) : Error BCP104: The referenced module has errors.
2022-11-04T15:58:56.9209986Z /home/vsts/work/1/s/policies/assignments/policyAssignmentsModule/deploy.bicep(1,1) : Info Bicep Linter Configuration: Custom bicepconfig.json file found (/home/vsts/work/1/s/bicepconfig.json).
2022-11-04T15:58:56.9210620Z /home/vsts/work/1/s/policies/assignments/policyAssignmentsModule/deploy.bicep(79,28) : Error BCP104: The referenced module has errors.
2022-11-04T15:58:56.9211518Z /home/vsts/work/1/s/policies/assignments/policyAssignmentsModule/deploy.bicep(101,29) : Error BCP104: The referenced module has errors.
2022-11-04T15:58:56.9212075Z /home/vsts/work/1/s/policies/assignments/policyAssignmentsModule/deploy.bicep(123,28) : Error BCP104: The referenced module has errors.
2022-11-04T15:58:56.9212693Z /home/vsts/work/1/s/policies/exemptions/PolicyExemptions_cx.bicep(1,1) : Info Bicep Linter Configuration: Custom bicepconfig.json file found (/home/vsts/work/1/s/bicepconfig.json).
2022-11-04T15:58:56.9213385Z /home/vsts/work/1/s/policies/definitions/PolicyDefinitions_cx.bicep(1,1) : Info Bicep Linter Configuration: Custom bicepconfig.json file found (/home/vsts/work/1/s/bicepconfig.json).
2022-11-04T15:58:56.9214109Z /home/vsts/work/1/s/policies/assignments/policyAssignmentsModule/subscription/deploy.bicep(1,1) : Info Bicep Linter Configuration: Custom bicepconfig.json file found (/home/vsts/work/1/s/bicepconfig.json).
2022-11-04T15:58:56.9214873Z /home/vsts/work/1/s/policies/assignments/policyAssignmentsModule/subscription/deploy.bicep(59,20) : Error BCP070: Argument of type "null | object | object" is not assignable to parameter of type "Identity | null".
2022-11-04T15:58:56.9215619Z /home/vsts/work/1/s/policies/assignments/policyAssignmentsModule/subscription/deploy.bicep(59,20) : Error BCP070: Argument of type "null | object | object" is not assignable to parameter of type "Identity | null".
2022-11-04T15:58:56.9216313Z /home/vsts/work/1/s/policies/deploy.bicep(1,1) : Info Bicep Linter Configuration: Custom bicepconfig.json file found (/home/vsts/work/1/s/bicepconfig.json).
2022-11-04T15:58:56.9216849Z /home/vsts/work/1/s/policies/deploy.bicep(16,27) : Error BCP104: The referenced module has errors.
2022-11-04T15:58:56.9996289Z [33;1mVERBOSE: Invoke task with[0m
2022-11-04T15:58:57.0046898Z [33;1mVERBOSE: {
2022-11-04T15:58:57.0047307Z   "subscriptionId": "$(subscriptionId)",
2022-11-04T15:58:57.0047656Z   "templateFilePath": "/home/vsts/work/1/s/policies/deploy.bicep",
2022-11-04T15:58:57.0047968Z   "additionalParameters": {},
2022-11-04T15:58:57.0048339Z   "parameterFilePath": "/home/vsts/work/1/s/policies/.parameters/dev.weu.parameters.json",
2022-11-04T15:58:57.0048712Z   "location": "westeurope",
2022-11-04T15:58:57.0049127Z   "managementGroupId": "dev-mg-cx",
2022-11-04T15:58:57.0049443Z   "resourceGroupName": "$(resourceGroupName)"
2022-11-04T15:58:57.0049690Z }
2022-11-04T15:58:57.0049980Z [0m
2022-11-04T15:58:57.0336886Z [33;1mVERBOSE: Determined deployment scope [managementGroup][0m
2022-11-04T15:58:57.0439327Z [33;1mVERBOSE: Testing with deployment name [policies-20221104T1511570378Z][0m
2022-11-04T15:58:57.0457514Z [33;1mVERBOSE: Performing the operation "Test" on target "Management group level deployment".[0m
2022-11-04T15:59:03.9792490Z [33;1mVERBOSE: Using Bicep v0.11.1[0m
...
2022-11-04T15:59:31.0609020Z [33;1mVERBOSE: 15:59:31 - Template is valid.[0m
2022-11-04T15:59:31.1892187Z [33;1mVERBOSE: Template is valid[0m
2022-11-04T15:59:31.6351996Z ##[error]Script failed with exit code: 1
2022-11-04T15:59:31.6373994Z [command]/usr/bin/az account clear

@alex-frankel  this is a shortend output from an ADO pipeline with ubuntu-latest which says that its using bicep v0.11.1

@SeSeicht Fun fact: If you wrap the place where the variable is used into an any(...), the error goes away. Not really nice, but at least a workaround.

@SeSeicht Fun fact: If you wrap the place where the variable is used into an any(...), the error goes away. Not really nice, but at least a workaround.

this workaround works for me aswell!


gen: refactor for regeneration and better file overview

⚠  Thee is a change to devctl gen ami logic. Now package is taken from the --dir flag instead of being fixed to key.
Here I'm applying lessons learned here https://github.com/giantswarm/devctl/pull/46.
The improvements are not so visible when generating single file but are definitely more visible with multiple. The structure should be also more straightforward when adding new input package.

Build fails.


Polaris - PI Web API Data Analysis Upload - Path manipulation

225110

All Polaris issues have been resolved. Resolution from (https://docs.microsoft.com/en-us/dotnet/api/system.uri?view=net-5.0#security-considerations)


Add hook processors

What does this PR do?
Add a hook to processors from the api
All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you successfully ran tests with your changes locally? Including container validation.
[x] Have you lint your code locally prior to submission?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Have you labelled this PR correctly?


Use color in Github Actions

Looks like colorized text is showing up just fine on Github Actions:
https://github.com/dawidd6/homebrew-test/commit/585717b67f9eda62a79c69e699f50b21fff9b397/checks
I think it's worth it to make this change.

Nice spot! this makes things much more readable.


Route GET /repos/:owner/:repo does not work?

var auth = {
            token: process.env.GITHUB_ACCESS_TOKEN,
            type: 'oauth',
        }
    }

var github = new Github();
github.authenticate(auth);

github.repos.get({ owner: 'joliejuke', repo: 'myRepo' }, function(err, res) {

            if (err) {
                return reject(err)
            }
            return resolve(res)
        });

Got response 404 from Github api v3.
Maybe there is a change on github API but I didn't notice that.
Do you have same problem? Or did I miss something in my code?

"Works on my machine" with the latest npm right now.
It's always a little tough since a 404 in GitHub can also mean "there's a private thing, but you can't see it"

joliejuke/myRepo seems to be private. Make sure process.env.GITHUB_ACCESS_TOKEN has access to private repos.

Thanks guys for your answers :)
I just found why it was 404...
I have created a repo with my account "joliejuke", but this repo live in an Organisation, so I could not reach it using the route /repos/joliejuke/:repo
Nice module btw, it helps a lot :)

Ah ok. Glad you got it resolved!


bill of materials for the non-3D printed parts

bill of materials for the non-3D printed parts would be very very very very helpful recreate and try the project.
thank you!

I'll be filling in the BOM as I work on the project, apologies for the delay. The harmonic drive uses 608 and 688 bearings, plus some M3 square nuts and M3 bolts (I believe 20mm length for the bearing posts). But I will be uploading a full BOM in the next few weeks!

Is there any update on this?

Is there any update on this?

Hey sorry about that. I'm currently reworking the design from scratch so this design of the full arm is frozen. I plan to have a full BOM with the redesign which will be in Onshape so it is more accessible. But I don't have any idea of the full BOM for this iteration so if you want to build any part of it, you will need to open the cad and work out fasteners from that. Bearings are already included. And some heat stake inserts are used in the larger shallow holes where there's a screw but no obvious nut.


Makes charset explicit in MySQL tables

Travis just started failing due to unicode characters not returning.
This makes character set explicit in our defaults in case others have
the same problem.

note: not sure exactly what caused this in travis, but it appears to have recently picked up mysql 5.6.33

merging as needed to unbreak travis


Portainer settings change via API is not applied

Hi,
Bug description
The API call to change  "logoURL" parameter, changes the link to the logo displayed on WI (URL: ), but changes are not applied and the previous logo remains in the top right corner of the WI and on the authorization page until I manually hit the 'Save Settings' button.
Steps to reproduce the issue:

Put the new logo to the Portainer setting via its API
Example of the request:

curl -k --include --request PUT -H "Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwidXNlcm5hbWUiOiJhZG1pbiIsInJvbGUiOjEsImV4cCI6MTYyMTM1MjYzNn0._Hwy5k4AfaOHovlyYiqWPMj35291SHx2b9RFaeG8LeQ" https://localhost:9443/api/settings -d '{"logoURL":"https://new_logo.png"}'

The response is 200 OK:
HTTP/1.1 200 OK
Content-Type: application/json
X-Content-Type-Options: nosniff
X-Xss-Protection: 1; mode=block
Date: Tue, 18 May 2021 08:59:17 GMT
Content-Length: 1273

{"LogoURL": "https://new_logo.png" .....}

Open Portainer WI
Go to the 'Settings' menu
See the Logo URL is changed, but the old logo is still applied

Expected behavior
The logo is changed across the application in the appropriate places without additional manual actions
Current behavior
The logo stays old until manual saving the settings via 'Save Settings' button.
Portainer Logs
Nothing useful in logs
Technical details:

Portainer version: 2.5.0 Portainer CE
Docker version (managed by Portainer): Docker version 19.03.11-ol, build f0aae77
Kubernetes version (managed by Portainer): no Kubernetes, using Swarm instead
Platform (windows/linux): Linux CentOS
Command used to start Portainer (docker run -p 9000:9000 portainer/portainer): the docker swarm service creation command is used according to Portainer's documentation
Browser: Chrome Version 90.0.4430.212
Use Case (delete as appropriate): Using Portainer at Home, Using Portainer in a Commerical setup.
Have you reviewed our technical documentation and knowledge base? I hope - yes

Additional context
Using SSL connection.
I tend to think this issue is actual not only for the logo changes but for all settings we change via API which require saving
Thank you in advance for your help.

I could not reproduce the issue. Have you tried logging out and back in after using the curl statement?

Hi,

I could not reproduce the issue.
After I run the curl command and refresh the page the UI gets updated with new logo.

Thank you for the update.
Nope, it doesn't work for me this way, unfortunately.
But after additional testing, I noticed that the logo had been eventually updated after logout/login to the Portainer WI
Is this something expected?

Could not reproduce this.
Have you tried clearing cache or Ctrl+Refresh?

Hi @samdulam

Could not reproduce this.
Have you tried clearing cache or Ctrl+Refresh?

Yes, sure.
I've made a short video to show how it goes.
In this video, the API requests were made in the background (you'll see the link is changed after clicking a different menu), then I reloaded the page with cache clearing, but nothing changed till 'Save settings' pressing.
And the issue has gone after logging out and the usual refreshing the page.
https://user-images.githubusercontent.com/30658596/120434556-4c1d7e00-c385-11eb-9721-6de22576e9f1.mp4
This is not critical as it seems to be changed at last, just worried for the settings to be applied via API.

I can reproduce that in a different way as well.
Have custom logo off
Open Portainer in Firefox and Chrome.
Enable custom logo in Chrome
Refresh in Firefox does not change the logo
The reason for this is that it's using the local storage:

Clear the local storage and the change takes effect.