SIFT Upgrade Broken

I'm receiving 8 failures when performing a "sift upgrade". Any ideas?

[user@siftworkstation v2017.48.0]$ grep "result: false" -C 5 saltstack.log
      stdout: ''
    comment: Command "dconf load /org/gnome/terminal/ < /usr/share/sift/terminal-profiles.txt"
      run
    duration: 400.584
    name: dconf load /org/gnome/terminal/ < /usr/share/sift/terminal-profiles.txt
    result: false
    start_time: '13:50:42.384238'
  cmd_|-sift-config-theme-gtk_|-gsettings set org.gnome.desktop.interface gtk-theme Arc_|-run:
    __id__: sift-config-theme-gtk
    __run_num__: 467
    __sls__: sift.config.user.theme
--
    duration: 277.05
    name: gsettings set com.canonical.Unity.Launcher favorites "['application://gnome-terminal.desktop',
      'application://firefox.desktop', 'application://org.gnome.Nautilus.desktop',
      'application://unity-control-center.desktop', 'unity://running-apps', 'unity://expo-icon',
      'unity://devices']"
    result: false
    start_time: '13:50:44.065846'
  cmd_|-sift-config-unity-icon-size_|-dconf write /org/compiz/profiles/unity/plugins/unityshell/icon-size 32_|-run:
    __id__: sift-config-unity-icon-size
    __run_num__: 478
    __sls__: sift.config.user.unity
--
      stdout: ''
    comment: Command "dconf write /org/compiz/profiles/unity/plugins/unityshell/icon-size
      32" run
    duration: 471.551
    name: dconf write /org/compiz/profiles/unity/plugins/unityshell/icon-size 32
    result: false
    start_time: '13:50:44.343090'
  cmd_|-sift-config-unity-launcher-user_|-gsettings set com.canonical.Unity.Launcher launcher-position Bottom_|-run:
    __id__: sift-config-unity-launcher-user
    __run_num__: 475
    __sls__: sift.config.user.unity
--
      stdout: ''
    comment: Command "gsettings set com.canonical.Unity.Launcher launcher-position
      Bottom" run
    duration: 289.36
    name: gsettings set com.canonical.Unity.Launcher launcher-position Bottom
    result: false
    start_time: '13:50:43.494162'
  ? cmd_|-sift-config-unity-minimize-window_|-dconf write /org/compiz/profiles/unity/plugins/unityshell/launcher-minimize-window
    true_|-run
  : __id__: sift-config-unity-minimize-window
    __run_num__: 479
--
    comment: Command "dconf write /org/compiz/profiles/unity/plugins/unityshell/launcher-minimize-window
      true" run
    duration: 661.74
    name: dconf write /org/compiz/profiles/unity/plugins/unityshell/launcher-minimize-window
      true
    result: false
    start_time: '13:50:44.814843'
  ? cmd_|-sift-package-perl-cpan-configure_|-perl -MCPAN -e 'my $c = "CPAN::HandleConfig";
    $c->load(doit => 1, autoconfig => 1); $c->edit(prerequisites_policy => "follow");
    $c->edit(build_requires_install_policy => "yes"); $c->commit'_|-wait
  : __id__: sift-package-perl-cpan-configure
--
  file_|-sift-version-file_|-/etc/sift-version_|-managed:
    __run_num__: 536
    __sls__: sift.vm
    changes: {}
    comment: 'One or more requisite failed: sift.config.sift-config'
    result: false
  file_|-symlinks-cases_|-/home/davisrg/Desktop/cases_|-symlink:
    __id__: symlinks-cases
    __run_num__: 462
    __sls__: sift.config.user.symlinks
    changes: {}
--
    __sls__: sift.config.user
    changes: {}
    comment: 'One or more requisite failed: sift.config.user.unity.sift-config-unity-favorites,
      sift.config.user.unity.sift-config-unity-minimize-window, sift.config.user.terminal.sift-config-terminal-profiles-install,
      sift.config.user.unity.sift-config-unity-launcher-user, sift.config.user.unity.sift-config-unity-icon-size'
    result: false
  test_|-sift-config_|-sift-config_|-nop:
    __run_num__: 535
    __sls__: sift.config
    changes: {}
    comment: 'One or more requisite failed: sift.config.user.sift-config-user'
    result: false
  test_|-sift-packages_|-sift-packages_|-nop:
    __id__: sift-packages
    __run_num__: 250
    __sls__: sift.packages
    changes: {}

Are you running from terminal while in the unity desktop?
Sent from my iPhone

On Feb 8, 2018, at 07:03, Richard Davis<EMAIL_ADDRESS>wrote:
I'm receiving 8 failures when performing a "sift upgrade". Any ideas?
[user@siftworkstation v2017.48.0]$ grep "result: false" -C 5 saltstack.log
stdout: ''
comment: Command "dconf load /org/gnome/terminal/ < /usr/share/sift/terminal-profiles.txt"
run
duration: 400.584
name: dconf load /org/gnome/terminal/ < /usr/share/sift/terminal-profiles.txt
result: false
start_time: '13:50:42.384238'
cmd_|-sift-config-theme-gtk_|-gsettings set org.gnome.desktop.interface gtk-theme Arc_|-run:
id: sift-config-theme-gtk
run_num: 467
sls: sift.config.user.theme
duration: 277.05
name: gsettings set com.canonical.Unity.Launcher favorites "['application://gnome-terminal.desktop',
'application://firefox.desktop', 'application://org.gnome.Nautilus.desktop',
'application://unity-control-center.desktop', 'unity://running-apps', 'unity://expo-icon',
'unity://devices']"
result: false
start_time: '13:50:44.065846'
cmd_|-sift-config-unity-icon-size_|-dconf write /org/compiz/profiles/unity/plugins/unityshell/icon-size 32_|-run:
id: sift-config-unity-icon-size
run_num: 478
sls: sift.config.user.unity
stdout: ''
comment: Command "dconf write /org/compiz/profiles/unity/plugins/unityshell/icon-size
32" run
duration: 471.551
name: dconf write /org/compiz/profiles/unity/plugins/unityshell/icon-size 32
result: false
start_time: '13:50:44.343090'
cmd_|-sift-config-unity-launcher-user_|-gsettings set com.canonical.Unity.Launcher launcher-position Bottom_|-run:
id: sift-config-unity-launcher-user
run_num: 475
sls: sift.config.user.unity
stdout: ''
comment: Command "gsettings set com.canonical.Unity.Launcher launcher-position
Bottom" run
duration: 289.36
name: gsettings set com.canonical.Unity.Launcher launcher-position Bottom
result: false
start_time: '13:50:43.494162'
? cmd_|-sift-config-unity-minimize-window_|-dconf write /org/compiz/profiles/unity/plugins/unityshell/launcher-minimize-window
true_|-run
: id: sift-config-unity-minimize-window
run_num: 479
comment: Command "dconf write /org/compiz/profiles/unity/plugins/unityshell/launcher-minimize-window
true" run
duration: 661.74
name: dconf write /org/compiz/profiles/unity/plugins/unityshell/launcher-minimize-window
true
result: false
start_time: '13:50:44.814843'
? cmd_|-sift-package-perl-cpan-configure_|-perl -MCPAN -e 'my $c = "CPAN::HandleConfig";
$c->load(doit => 1, autoconfig => 1); $c->edit(prerequisites_policy => "follow");
$c->edit(build_requires_install_policy => "yes"); $c->commit'_|-wait
: id: sift-package-perl-cpan-configure
file_|-sift-version-file_|-/etc/sift-version_|-managed:
run_num: 536
sls: sift.vm
changes: {}
comment: 'One or more requisite failed: sift.config.sift-config'
result: false
file_|-symlinks-cases_|-/home/davisrg/Desktop/cases_|-symlink:
id: symlinks-cases
run_num: 462
sls: sift.config.user.symlinks
changes: {}
sls: sift.config.user
changes: {}
comment: 'One or more requisite failed: sift.config.user.unity.sift-config-unity-favorites,
sift.config.user.unity.sift-config-unity-minimize-window, sift.config.user.terminal.sift-config-terminal-profiles-install,
sift.config.user.unity.sift-config-unity-launcher-user, sift.config.user.unity.sift-config-unity-icon-size'
result: false
test_|-sift-config_|-sift-config_|-nop:
run_num: 535
sls: sift.config
changes: {}
comment: 'One or more requisite failed: sift.config.user.sift-config-user'
result: false
test_|-sift-packages_|-sift-packages_|-nop:
id: sift-packages
run_num: 250
sls: sift.packages
changes: {}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Actually GNOME, not Unity (Ubuntu GNOME 16.04).
On Thu, Feb 8, 2018 at 9:40 AM, Erik Kristensen<EMAIL_ADDRESS>wrote:

Are you running from terminal while in the unity desktop?
Sent from my iPhone

On Feb 8, 2018, at 07:03, Richard Davis<EMAIL_ADDRESS>wrote:
I'm receiving 8 failures when performing a "sift upgrade".
Nautilus.desktop',
'application://unity-control-center.desktop', 'unity://running-apps',
'unity://expo-icon',
'unity://devices']"
result: false
start_time: '13:50:44.065846'
cmd_|-sift-config-unity-icon-size_|-dconf write
/org/compiz/profiles/unity/plugins/unityshell/icon-size 32_|-run:
id: sift-config-unity-icon-size
run_num: 478
sls: sift.config.user.unity
stdout: ''
comment: Command "dconf write /org/compiz/profiles/unity/
plugins/unityshell/icon-size
32" run
duration: 471.551
name: dconf write /org/compiz/profiles/unity/plugins/unityshell/icon-size
32
result: false
start_time: '13:50:44.343090'
cmd_|-sift-config-unity-launcher-user_|-gsettings set
com.canonical.Unity.Launcher launcher-position Bottom_|-run:
id: sift-config-unity-launcher-user
run_num: 475
sls: sift.config.user.unity
stdout: ''
comment: Command "gsettings set com.canonical.Unity.Launcher
launcher-position
Bottom" run
duration: 289.36
name: gsettings set com.canonical.Unity.Launcher launcher-position Bottom
result: false
start_time: '13:50:43.494162'
? cmd_|-sift-config-unity-minimize-window_|-dconf write
/org/compiz/profiles/unity/plugins/unityshell/launcher-minimize-window
true_|-run
: id: sift-config-unity-minimize-window
run_num: 479
comment: Command "dconf write /org/compiz/profiles/unity/
plugins/unityshell/launcher-minimize-window
true" run
duration: 661.74
name: dconf write /org/compiz/profiles/unity/
plugins/unityshell/launcher-minimize-window
true
result: false
start_time: '13:50:44.814843'
? cmd_|-sift-package-perl-cpan-configure_|-perl -MCPAN -e 'my $c =
"CPAN::HandleConfig";
$c->load(doit => 1, autoconfig => 1); $c->edit(prerequisites_policy =>
"follow");
$c->edit(build_requires_install_policy => "yes"); $c->commit'_|-wait
: id: sift-package-perl-cpan-configure
file_|-sift-version-file_|-/etc/sift-version_|-managed:
run_num: 536
sls: sift.vm
changes: {}
comment: 'One or more requisite failed: sift.config.sift-config'
result: false
file_|-symlinks-cases_|-/home/davisrg/Desktop/cases_|-symlink:
id: symlinks-cases
run_num: 462
sls: sift.config.user.symlinks
changes: {}
sls: sift.config.user
changes: {}
comment: 'One or more requisite failed: sift.config.user.unity.sift-
config-unity-favorites,
sift.config.user.unity.sift-config-unity-minimize-window,
sift.config.user.terminal.sift-config-terminal-profiles-install,
sift.config.user.unity.sift-config-unity-launcher-user,
sift.config.user.unity.sift-config-unity-icon-size'
result: false
test_|-sift-config_|-sift-config_|-nop:
run_num: 535
sls: sift.config
changes: {}
comment: 'One or more requisite failed: sift.config.user.sift-config-
user'
result: false
test_|-sift-packages_|-sift-packages_|-nop:
id: sift-packages
run_num: 250
sls: sift.packages
changes: {}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sans-dfir/sift/issues/223#issuecomment-364131609, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ANbgBCt9g2ZeZIqQQ8HLiLoPoBHNrfseks5tSwd2gaJpZM4R-Zex
.

Unfortunately, SIFT only supports 16.04 and Unity if you want all it's theme capabilities, background images, etc ...
You can try sift upgrade --mode=packages-only it should only install packages and skip all theme related instructions.

Ah ok, thank you for the quick response. I attempted the packages-only
workaround, but that option didn't seem to work. I think it may only work
with sift install, not sift upgrade, but since it's already installed, no
luck. Would there be any other workaround, or do I need to start from
scratch?
On Thu, Feb 8, 2018 at 10:05 AM, Erik Kristensen<EMAIL_ADDRESS>wrote:

Unfortunately, SIFT only supports 16.04 and Unity if you want all it's
theme capabilities, background images, etc ...
You can try sift upgrade --mode=packages-only it should only install
packages and skip all theme related instructions.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sans-dfir/sift/issues/223#issuecomment-364139498, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ANbgBMFNaDopQeYOI1OUS2HeGuK2S-wmks5tSw0_gaJpZM4R-Zex
.

I don't think you need to start over from scratch, but I might have to release a new version of the CLI tool to allow packages-only to work on upgrade.
Technically everything is separate because of how all the states are written, so even though the "upgrade" failed and it won't ever mark your current version as being the latest, only the ones that failed actually failed, so anything else was installed or upgraded successfully. It doesn't rollback anything in the face of failure.

Ok, thank you. Another workaround may simply be to install the Unity
Desktop in addition to the GNOME environment to fulfill the dependencies
(apt install ubuntu-desktop). I will give that a try as well.
Richard
On Thu, Feb 8, 2018 at 11:01 AM, Erik Kristensen<EMAIL_ADDRESS>wrote:

I don't think you need to start over from scratch, but I might have to
release a new version of the CLI tool to allow packages-only to work on
upgrade.
Technically everything is separate because of how all the states are
written, so even though the "upgrade" failed and it won't ever mark your
current version as being the latest, only the ones that failed actually
failed, so anything else was installed or upgraded successfully. It doesn't
rollback anything in the face of failure.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sans-dfir/sift/issues/223#issuecomment-364157903, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ANbgBGtCxbyqYH5ZiipySqcoZIk41faVks5tSxpEgaJpZM4R-Zex
.

This worked correctly. Installing the "ubuntu-desktop" package on Ubuntu GNOME 16.04 allows the sift upgrade to complete with no errors.

Installing ubuntu-desktop did not fix this issue for me.


Chapter 4 edits

notes:

table 4.1: it seems L1 divides by 4 while the others divide by 2
4-7: you say all_loads = fb_hit + l1_hit + l1_miss, but your table has

29580 mem_load_retired.fb_hit
19036 mem_load_retired.l1_miss
497204 mem_load_retired.l1_hit
[schwarzgerat](0) $ echo $((29580 + 19036 + 497204))
545820
[schwarzgerat](0) $

but you have:
546230 mem_inst_retired.all_loads
leaving 410 unexplained

4.8: again, i think it predicts target, not direction
don't like equating branch prediction and speculative execution. you can have BP without SE (for just fetch, for instance).

@dankamongmen

notes:

table 4.1: it seems L1 divides by 4 while the others divide by 2

Not sure if you want me to change anything in that table. Please let me know.

4-7: you say all_loads = fb_hit + l1_hit + l1_miss, but your table has

29580 mem_load_retired.fb_hit 19036 mem_load_retired.l1_miss 497204 mem_load_retired.l1_hit
[schwarzgerat](0) $ echo $((29580 + 19036 + 497204))
545820
[schwarzgerat](0) $

but you have:
546230 mem_inst_retired.all_loads
leaving 410 unexplained

Yeah, this is the artifact of using performance counters. The numbers may not exactly match. I will add a footnote about it in a separate commit.

4.8: again, i think it predicts target, not direction

Agree.

don't like equating branch prediction and speculative execution. you can have BP without SE (for just fetch, for instance).

Agree. But did I make this mistake in this chapter? I don't remember seeing this.


Files under the WEB-INF directory are directly accessible in a default installation

When creating a completely clean default installation of the openwayback web application, it is possible to get access to files in the WEB-INF directory by browsing to directly to the URLs of the form:
http://server:port/wayback/WEB-INF/web.xml
http://server:port/wayback/WEB-INF/classes/logging.properties
The WEB-INF directory is supposed to be restricted by default as it contains details of the application configuration which could potentially be a leak of sensitive information.
This affects installing both as the ROOT and as a non-root application. For the non-root, use URLs of the form:
http://server:port/context/wayback/WEB-INF/web.xml
http://server:port/context/wayback/WEB-INF/classes/logging.properties
This was seen using a standard CentOS7 minimal install, installing tomcat 7 with "yum install tomcat", then using the installation instructions on the openwayback wiki to install the 2.3.2 release.

Confirmed.
What's happening is that OWB is capturing any request to <contextroot>/wayback/<anything>.
If "anything" matches a replay URI (e.g. starts with a timestamp) it gets redirected into replay rendering.
Everything else gets mapped onto the root of the webapp folder. This allows access to search pages, banner resources etc.
Unfortunately, this includes the WEB-INF folder, and not by accident. This is actually needed to serve the JSP etc. stored under WEB-INF.
The best option I can see is to put in a black list of resources that aren't allowed to be served in this manner in place.
My suggested blacklist:
WEB-INF/lib
WEB-INF/classes
WEB-INF/*.xml

Implemented this might look something like: https://github.com/iipc/openwayback/pull/354
I'm aware that this is a hack-y fix. But a proper fix would likely require throwing out OWB entire 'controller' framework and replacing it with something more sensible (like Spring MVC perhaps).

Thanks for looking at this so quickly. I appreciate the proposed solution coming in so soon.
I agree that the proper fix would probably involve a fairly substantial re-write using a more standard MVC framework, which doesn't seem like a bad idea, although I appreciate that it will probably be fairly time-consuming. Rolling your own frameworks does come with the danger of missing things like this.
However, even a more "hack-y" patch like your suggestion should probably work from a whitelist rather than blacklist principle. This would be more in line with what you would get from an MVC framework like Spring where you have to configure your application to explicitly map the URLs that you want to expose.
I would feel more comfortable if you whitelisted the jsps and images that you need to expose rather than blacklist files you don't want to expose. Using a blacklist, if you add a new file at some point in the future that isn't covered by the blacklist, then it is exposed by default, this is the kind of thing that can sit un-noticed for a long time. Using a whitelist, if you add a new file at some point it is hidden by default, and if you need it to be exposed it will be obvious pretty quickly if you forget to whitelist it.

The problem with a white list is that there may be cases where someone has extended Wayback and added additional resources under WEB-INF. At a minimum, the use of a white list means making the list easily configurable, which is more code.
That said, if someone wants to write up a bit more comprehensive solution using a white list, I wont object!

Agreed. Of course a blacklist also potentially has this problem if the resource added needs some extra configuration, which the user assumes is protected by default as it's in the WEB-INF folder. It is arguably even more likely that the config would contain sensitive information (external server credentials for example) if it was part of an extension than the default configuration files.
In either case, user configurable lists seem necessary, and documentation that if you are extending the functionality, you have to be aware of this.

@kris-sigur, regarding the comment:
Unfortunately, this includes the WEB-INF folder, and not by accident. This is actually needed to serve the JSP etc. stored under WEB-INF.

Based on something I saw in the Wayback 1.4.0 release notes that says "Changed locations of replay, query, and exception .jsp files within .war file to underneath WEB-INF, so they are not directly accessible via HTTP" I was thinking it was not intentional in OpenWayback that files under WEB-INF are directly accessible.
Before seeing #354 I had put something like this in my local web.xml file:
    <security-constraint>
        <web-resource-collection>
            <web-resource-name>precluded methods</web-resource-name>
            <url-pattern>/wayback/WEB-INF/*</url-pattern>
        </web-resource-collection>
        <auth-constraint/>
    </security-constraint>

as a temporary fix to prevent the content under WEB-INF being directly accessible via http, and it seemed to work without breaking the application--though because this is blocking access via a URL pattern it has to be done for every access point. I am not proposing this as a solution since as far as I know it would have to be done for every access point created and seems hacky, but being able to block access to the WEB-INF content this way with the application still seeming to function properly made me wonder about whether the WEB-INF does need to be at all public.
Perhaps this doesn't make a difference anyway in regard to what you are describing is the overall problem and as far as having to change a lot of code to fix the issue, in which case I can test out the changes in #354. I just wanted to bring it up.

Closing per #354


Scroll bar is too small

Hi,
I'm using your library and every thing seem to be good, but the scroll bar in Infinitive loader is too small. How can I increase the height of scrool bar?
Using Inspect in chrome, the element ReactVirtualized__Grid__innerScrollContainer has style:
width: auto;     height: 79920px;     max-width: 365px;     max-height: 79920px;     overflow: hidden;     position: relative;
I think 79920px is very large so the scroll bar is small. but at the begining page load, there are only 30 items fetched from API, so why 79920px?

Is this project under maintained or downed?

Hi,
I'm using your library and every thing seem to be good, but the scroll bar in Infinitive loader is too small. How can I increase the height of scrool bar?
Using Inspect in chrome, the element ReactVirtualized__Grid__innerScrollContainer has style:
width: auto; height: 79920px; max-width: 365px; max-height: 79920px; overflow: hidden; position: relative;
I think 79920px is very large so the scroll bar is small. but at the begining page load, there are only 30 items fetched from API, so why 79920px?

I think that this is problem from React Semantic UI, not from React-virtualized.


Fixing a single quote

Major contribution here. There was a rogue ‘ that should be a '.

/approve
/cherrypick release-0.19


🌱 Improve metal3 remediation controller unit tests coverage

This PR adds following unit tests for metal3 remediation controller.
Controller folder coverage  76.4%->80%

/hold

/unhold

/test-ubuntu-integration-main

/test-ubuntu-integration-main

/test-ubuntu-integration-main

/retitle 🌱 Improve metal3 remediation controller unit tests coverage

/test-ubuntu-integration-main

/lgtm

/test-ubuntu-integration-main


chore: x/tokenfactory audit

Closes: #1914
What is the purpose of the change
Auditing the x/tokenfactory module
Brief Changelog

Revising proto comments
Revising keeper and types godocs
Revising tests

Not sure why, but after modifying the proto schemas and running make proto-gen, I get no updated compiled files...

Not sure why, but after modifying the proto schemas and running make proto-gen, I get no updated compiled files...

I tried running make proto-all on my side and saw some updates to pb.go files.
Maybe try make proto-all instead of proto-gen? If it doesn't generate anything in your local environment, please let me know. I can try to make a commit from my side to see if that fixes it

@p0mvn I tried both commands and I get no diff. I'm not sure but maybe it's because I'm on an m1 chip? Regardless, I have zero issues compiling proto in the SDK repo...

That's weird. Probably, a machine-specific issue. I made https://github.com/osmosis-labs/osmosis/pull/1971 to your PR to see if that fixes CI. This is what my Linux machine produces from your branch

Did you find nothing odd in the logic / tests / events of token factory?

Did you find nothing odd in the logic / tests / events of token factory?

I think test coverage could improve, but what is there there now looks sufficient.


Add Spanish

This is an initial attempt at adding the ES language. I can't claim that I've done extensive research on it, but I think adding it might be important for testing the API.

@Mottie Thanks for the basic Spanish setup. Feel free to squash-merge this PR.


Using adyen-web in capacitor on IOS

Using adyen-web in capacitor on IOS results in sending the request to "https://checkoutshopper-test.adyen.com/checkoutshopper/" with the "origin" header set as "capacitor://appname.com".
This results in "Invalid client key or unknown origin". Probably because of adyen not accepting "capacitor://" as a valid scheme for the origin. (it accepts "capacitor://appname.com" in the "allowed origin" on your account page of adyen, but it's not working).
We could use a plugin for capacitor for native HTTP requests, but then we need to be able to overwrite the "default" fetch method used in several locations.

Is this a use case adyen-web wants to support?
Is it maybe a bug in adyen for not accepting "capacitor://appname.com" as "allowed origin"?

@marcperez?

Hi @joepjoosten,
Please, make sure you are using the new Client Keys (or migrate from origin keys to client keys). As long as you add your origin (capacitor://appname.com) in the list of allowed origins, the requests should be accepted.
Hope that helps!
Cheers!

Closing the issue, feel free to reopen if you need any more help! Cheers!

Hi Marc, thanks for the quick response! We are using the client-key and we added the capacitor to the allowed origins. It all works well on Android and web (both using the same client-key and http://localhost as origin) From Adyen support I got the message back that no other than http/https is supported. Which could clarify the issue; what are you thoughts on this?

Hi @marcperez,
What @hrietman  is saying is correct. Support is saying that they only support http/https as allowed origins for the drop-in integration. Should we assume this project is only for web based clients? (so not to be used in the webview of ios on a capacitor app)

Hi @joepjoosten/@hrietman,
Since this seems to be an issue with the integration and not a bug on the library itself, let’s communicate through the support channel.
Cheers!


RFC: Source Removal Buildpack

Readable

OK, I've been thinking about this more and it appears like some of my comments yesterday were not in line with the intention of this RFC. Sorry for the confusion. That said, I would like to request some clarification on a couple of points.

The summary only talks about contributing a buildpack. The implementation does not talk about how the buildpack will be contributed. If we're going to contribute a buildpack, I feel like this RFC needs to address that in the implementation. See the Rust RFC as an example.

There is also mention of env variables BP_EXCLUDE_FILES and BP_INCLUDE_FILES. It is unclear if the intent of this is to describe how the buildpack works or if the intent is to propose these as a standard UI that all Paketo buildpacks should follow. I think this needs to be clarified.

The RFC suggests that the Utilities team adopt this buildpack, but this RFC is not being proposed as a Utilities team RFC. Given my uncertainty voiced through #1 and #2, I'm not sure this is wrong, but I'm not sure this is right either. I think this is a point we should consider as I want to make sure that we're targeting the right team so that the correct set of voting members is allowed to weigh in on the RFC.

This may become an unnecessary buildpack with the merging of this RFC, one of the proposed default utility buildpacks in a purge buildpack that will allow files to be ignored before export.

This may become an unnecessary buildpack with the merging of this RFC, one of the proposed default utility buildpacks in a purge buildpack that will allow files to be ignored before export.

Yes, that's true. I'm not sure how far out that will be, maybe it's still worth having this in Paketo until then. I recommended your buildpack to two or three people since you posted this. It's definitely useful.
When the time comes, you could submit your buildpack as a potential candidate for an official utility buildpack.

The idea of the buildpack wrapping a centralized source-removal package makes sense to me. This seems analogous to the environment variables buildpack, which provides buildpack end-users with functionality that buildpack authors leverage within buildpacks via packit/libcnb.

I am doing to put this in draft until I have had sometime to reach out to the CNB project about potentially making this one of their default utility buildpacks.

It seems as if making this a CNB default buildpack is out of scope for the time being so I am going to reopen RFC for discussion!

Questions from before: https://github.com/paketo-buildpacks/rfcs/pull/129#issuecomment-970314149
Also, thoughts on exposing the logic/code through a module that could be imported by other buildpacks? This buildpack would then also consume that module.
I don't think the Java buildpacks could use this buildpack directly, it's not going to fit into the workflow, but we currently have a request for more full-featured include/exclude logic like this. it would be nice to reuse the logic/code and have a consistent implementation. If you expose it as a module that we can go import, that would work perfect for us.

OK, I've been thinking about this more and it appears like some of my comments yesterday were not in line with the intention of this RFC. Sorry for the confusion. That said, I would like to request some clarification on a couple of points.

The summary only talks about contributing a buildpack. The implementation does not talk about how the buildpack will be contributed. If we're going to contribute a buildpack, I feel like this RFC needs to address that in the implementation. See the Rust RFC as an example.
There is also mention of env variables BP_EXCLUDE_FILES and BP_INCLUDE_FILES. It is unclear if the intent of this is to describe how the buildpack works or if the intent is to propose these as a standard UI that all Paketo buildpacks should follow. I think this needs to be clarified.
The RFC suggests that the Utilities team adopt this buildpack, but this RFC is not being proposed as a Utilities team RFC. Given my uncertainty voiced through add initial structure #1 and Add license 1 #2, I'm not sure this is wrong, but I'm not sure this is right either. I think this is a point we should consider as I want to make sure that we're targeting the right team so that the correct set of voting members is allowed to weigh in on the RFC.

@dmikusa-pivotal
I think that I have resolved everything in this comment:

I have added a section that walks through the promotion process. If more details are needed please let me know.
I put the current implementation in a sub-section that hopefully clarifies that this is the current behavior of the buildpack and not an interface proposal.
I have re-aimed the RFC so that is applies only to the utilities sub-team.

If you have any other concerns feel free to let me know!


Change flush_ms to flush_interval

Given we already use Duration for other interval fields, this one looked out of place.
Change flush_ms to flush_interval to make it uniform.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@rajatgoel LGTM. Mind fixing the style checks?


Complete quoting for parameters of some CMake commands

Some parameters (like "${CMAKE_CURRENT_SOURCE_DIR}/boost" and "${DIR}") are passed to CMake commands in your build scripts without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like semicolons.
I would recommend to apply advices from a wiki article.

I would appreciate another constructive comment for remaining update candidates.

elfring, this is the CMakeLists.txt file in the llvm38 branch: https://github.com/trailofbits/mcsema/blob/llvm38/CMakeLists.txt and this is where cmake is invoked: https://github.com/trailofbits/mcsema/blob/llvm38/bootstrap.sh#L111-L140
Are these satisfactory?

I see that there are still update candidates left over also in build scripts from other project directories.

Can you point them out in the llvm38 branch?

How do you think about another example like ${MCSEMA_DIR}?

Can you make your CMake fixes and submit a PR?

I am unsure when one of the affected scripts contains information like “…, all rights reserved.”.

The license of all of the McSema codebase is a 3-clause BSD license. I have my source code editors auto add that. If that is not compatible with the license then please also submit a PR for those files, adding whatever the correct license header is required.

I can not quickly determine if a licence information in a specific file is really inappropriate according to your intention.


mmex: 1.6.3 -> 1.6.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/moneymanagerex/moneymanagerex/releases.
meta.description for mmex is: Easy-to-use personal finance software
meta.homepage for mmex is: https://www.moneymanagerex.org/
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.6.4 with grep in /nix/store/518g95dd06s3q7x0rj868gjf1368mfic-money-manager-ex-1.6.4
found 1.6.4 in filename of file in /nix/store/518g95dd06s3q7x0rj868gjf1368mfic-money-manager-ex-1.6.4

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
mmex

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/518g95dd06s3q7x0rj868gjf1368mfic-money-manager-ex-1.6.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A mmex https://github.com/r-ryantm/nixpkgs/archive/3575f5b6cd7420eae6bbe6c9c33b0619ab845849.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/518g95dd06s3q7x0rj868gjf1368mfic-money-manager-ex-1.6.4
ls -la /nix/store/518g95dd06s3q7x0rj868gjf1368mfic-money-manager-ex-1.6.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

mmex

Maintainer pings
cc @viric for testing.

Wrong tag 😕

1.7.0 is out.


Not detecting state change

I have something like this:
const [num, setNum] =  useState(0);
...
useHotkeys('backspace, del, delete', () => {
    console.log("current state: ", num);
});

Whenever I change the num somewhere in my code like this: setNum(3)
when I press delete it still always says the initial state.
ie. "current state: 0"

You need to pass num in the dependency array like:
const [num, setNum] =  useState(0);
...
useHotkeys('backspace, del, delete', () => {
    console.log("current state: ", num);
}, [num]);

It's documented here https://github.com/JohannesKlauss/react-hotkeys-hook#parameters (maybe better to use that repo when you have a question about one of the react packages)

Right!
Thank you so much this makes a lot of sense!


refactor should validate input syntax

Do we allow dynamic parameters? If we do, then the implementation is broken. Note the output of refactor below.
gauge --refactor "A context step which gets executed before every scenario" "A context step which gets executed before every scenario with
<foo> and <bar>"

Resuts in
Spec:
* A context step which gets executed before every scenario with "" and ""

Implementation:
step 'A context step which gets executed before every scenario with {} and {}' do |foo, bar|
end

That is expected behaviour. If an existing dynamic parameter is reordered, then it should be reflect accordingly, but in the case that new parameters are added, they are treated as static values.
We could use the placeholder values instead of empty static args is what i think.

A context step which gets executed before every scenario with "foo" and "bar"

Refactoring does not add empty parameter values now. <> are used only as placeholders and mark positions where a parameter needs to be added or moved.
Existing dynamic/static/special parameters will be moved based on the new position of the parameter and new parameters will always be static values.


Is there any reason why Name is not preserved when cloning a Parser

Hello,
I just discovered Eto.Parse and I really enjoy it. Great piece of work.
I would like use it to build a library of reusable parsers which can be combined in multiple small grammars for scraping items in documents.
The problem is that when cloning a Parser, the names are lost and it does not properly fill the Matches property of the result
The following test fails
			var p = Eto.Parse.Terminals.Literal("hello");
			var helloNamed = p.Named("greetings");
			Assert.AreEqual("greetings", helloNamed.Name);
			var helloClone = helloNamed.Clone();
			Assert.AreEqual("greetings", helloClone.Name); // FAILS helloClone.Name is null

I just checked Parser copy constructor, and it does not set the name of the new instance to the one of the source.
Is there any reason for this, or can I make a Pull request ?

Just discovered that AddMatch property is not copied either in Parser copy constructor.
I connot see a reason why, and from a newcomer perspective I do not predict any negative impacts.

The main reason is having two parsers with the same name in the same grammar is a conflict.  It could very well copy the name, however as you can just overwrite it with the WithName() extension.
Thanks for the feedback! (and sorry for the late response)


error in keras-glove-testing-api-example.ipynb when training data has blank lines

I created a new branch and tried to push my changes to the branch so I could create a PR and attach the fix to it, but I got a permission denied error. How can I contribute to this repo?

Hey @carolgrrr! The usual way to contribute on GitHub is to fork the repo into your own GitHub namespace (e.g. my fork exists at https://github.com/kbrose/article-tagging) where you have permissions to push changes, create a branch, and then submit a Pull Request back to the upstream repository. Since it sounds like you've already cloned this repository, you'll also need to handle multiple remotes. Let me know if you have further questions.


add draft of external source links

So here's my draft of what this should look like for #68.  I think that's really all we need.  We could do with a better explanation of how to make plugins.  And we should get a bigger list of plugins to link to.
Can I just mention I really wish we were using Markdown for our readme rather than restructured text?  It took me many tries to figure out how to do inline hyperlinks right.

There is not short description of plugins.

calibre source: calibre source for zaw

If you can do better in Markdown, you can fully rewrite README.

I think this is probably enough information for people to go off of.  I think we can just merge this as-is and make incremental improvements from there.

make incremental improvements from there.

Improvements will be discussed in #68.


Fix shoving into enemies

I recently watched a maintainer get pushed into stationary enemies

Record in constants roles that inherently avoid enemies. When shoving, check if enemies, and if there are threatening enemies in range of a tile and not a rampart. Avoid tiles that are threatening


request.auth.attempt() returning error too soon

In the Authentication docs there is an example something like this:
    * login (request, response) {
        const email = request.input('email')
        const password = request.input('password')
        const login = yield request.auth.attempt(email, password)

        if (login) {
            response.route('profile')
            return
        }

        response.unauthorized('Invalid credentails')
    }

If the email or password is invalid an error comes back something like this:
PasswordMisMatchException: Password does not match
The attempt() method doesn't allow the rest of the code to continue once it fails / throws error. So response.unauthorized('Invalid credentails') never fires. Any ideas?

You need to wrap the attempt method instead a try/catch block.
try {
  const login = yield request.auth.attempt(email, password)
  response.route('profile')
} catch (e) {
  response.unauthorized('Invalid credentails')
}

and of course, based on the exception type, you can return contextual errors like Email is incorrect or Password does not match.
Also I will update the docs

Thank you so much! Really excited about this framework. Keep it up!
On Wed, Jul 6, 2016 at 9:58 PM Harminder Virk<EMAIL_ADDRESS>wrote:

You need to wrap the attempt method instead a try/catch block.
try {
const login = yield request.auth.attempt(email, password)
response.route('profile')
} catch (e) {
response.unauthorized('Invalid credentails')
}
and of course, based on the exception type, you can return contextual
errors like Email is incorrect or Password does not match.
Also I will update the docs
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/adonisjs/adonis-auth/issues/9#issuecomment-230986099,
or mute the thread
https://github.com/notifications/unsubscribe/ABG02o0PIUd7PQvvZQpnKmp6NYodb9m_ks5qTJV-gaJpZM4JGqYZ
.

@andrewdelprete Closing the issue, please feel free to create new issue if you face any problems


GameState + Element + Absorption + Laser and fate indicator

Refactor of GameState to pure computed logic in engine with new GameState (ProbabilityTooLow, GoalsNotCompleted)
Added pulsating Laser element once Victory GameState is computed
Click on laser fires the simulation
Moved random SVGs to assets/graphics
Fixed many small bugs
Created dedicated Absorption class and enforced consistent naming (probabilty, detection, etc.)
Massive element logic refactor which each element having its own class and own transition
Added polarization and probability as optional cell arguments to make polarizer, qwp, sugar solution, etc working.
Redesigned Polarizer and QWP who are now working.
Fixed levels to work accordingly
Bumped the sandbox elements to 10
Cleaned simulation
Created indicator interface which allows to specify polarization of laser from level cell
Cleaned encyclopedia grid
Added fate from sampleRandomRealization
Added fate indicator

Controls are working fine, see Klem for missing icons.


control-service: Turn-off debug mode for builder script

Builder job pods run a shell script, which builds and uploads the
data job image. Currently, it runs in debug mode which is not needed
in production environments.
This change turns off debug mode, and logs only required and non-sensitive
steps.
Testing Done: Uploaded new builder job image to docker hub, and ran a local
instance of the Control Service to verify that only necessary data is logged.
Signed-off-by: Andon Andonov<EMAIL_ADDRESS>

Testing Done: TODO

?

Testing Done: TODO

?

Oopsie, I updated the commit message, but I forgot to edit the PR message. :)


add multithread robocopy in PublishBuildArtifacts

Publish Build Artifacts is too slow.
In VSO, our build often takes around 20 minutes in this step.
add /MT:128 to robocopy

Hi @lengly, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@bryanmacfarlane @chrisrpatterson - thoughts?
internally we had talked about doing this before as an advanced option and leaving the default as not multi-threaded. the task has a Mac/Linux implementation as well, so the option would only apply when running on windows.

This feature has been implemented in a different change @4683


Add Entry fails with empty Redux store

Get the above error when trying to "Add entry" to the map
Steps to reproduce:

Open app
Open Inspect -> Application tab
Right-Click Storage -> Local storage
Select "Clear"
Click "Add Entry" button in UI
Enter GPS Coordinates
Click "Add to Tracks" button

We are working on this

it has be fixed by https://github.com/Path-Check/safeplaces-frontend/commit/b24b76ae0f092fc2c6ad78204e9ea85e1c127f63


Whac A Mole Game

easy to play
user friendly
interactive ui
attractive

@Sulagna-Dutta-Roy Please assign this issue to me under gssoc'24

This is not the correct way of raising Issues. As per the guidelines you should use feature request add all the details. Also whack and mole game already exists here #262. So closing this @taneeshaa15

Sorry mam, I will take care of the things you said.


Handle Office Open XML types for filed generated outside MSOffice

This is another stab to fix #39. We run into this same problem using mimemagic.
It looks like the check for [Content_Types.xml] was added in addition to the zip file check to avoid false positives using Paperclip. This keeps the zip check plus the xl/ (and word/ and ppt/) in the first 5000 bytes, without assuming that '[Content_Types].xml' will always be the first file in the archive.
This pull request also adds additional tests with a file generated by RubyXL (the one provided in this comment) and a file generated with Google Docs.

@minad / @junaruga is it possible for you to merge this or would you merge another PR if I take this and fix the merge conflicts?

@minad @junaruga I fixed the merge conflicts here: https://github.com/minad/mimemagic/pull/64

@atambo thanks. @minad could you check this? Sorry I am still not familiar with this project.

@rosa I don't think this change is a good idea. Lots of zip files (eg. png) could have the 'xl/' characters accidentally in the first 5000bytes of the files, so there is a big risk of misidentifying such files.  I would suggest keeping the [Content_types].xml check but make it more relaxed about the position where it needs to be at.

@gsar 👍 Thanks for taking a look!
At the end we worked around this issue in a different way, so I'll close this PR and will open a new one if we run into this again (and if nobody makes the change you suggests first, of course!).


Lifting Swagger to OpenApi instances

Thank you for contributing to Atlas! We appreciate your effort and dedication to improving this project. To ensure that your contribution is in line with the project's guidelines and can be reviewed efficiently, please fill out the template below.
Remember to follow our Contributing Guide before submitting your pull request.
Summary
Please provide a brief, concise summary of the changes in your pull request. Explain the problem you are trying to solve and the solution you have implemented.
Type of Change
Please mark the relevant option(s) for your pull request:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Code refactoring (improving code quality without changing its behavior)
[ ] Documentation update (adding or updating documentation related to the project)

Checklist
Please ensure that your pull request meets the following criteria:

[ ] I have read the Contributing Guide
[ ] My code follows the project's coding style and best practices
[ ] My code is appropriately commented and includes relevant documentation
[ ] I have added tests to cover my changes
[ ] All new and existing tests pass
[ ] I have updated the documentation, if necessary

Testing
Please describe the tests you have added or modified, and provide any additional context or instructions needed to run the tests.

[ ] Test A
[ ] Test B

Additional Information
If you have any additional information or context to provide, such as screenshots, relevant issues, or other details, please include them here.

Initial commit showcases examples of lifting instances from Swagger to OpenApi, using commands swaggerToOpenApiSchema and convertNamedSchema.  We use the former to lift a ToSchema Swagger instance when a ToParamSchema had also been defined.  We used the latter when this had not been the case.

Nice contribution! We really need the OpenAPI spec. Some code generators don't work with the legacy swagger API spec. This is a great update! Nice work!

Main functions are swaggerToOpenApiSchema and swaggerToOpenApiSchema', exported by GeniusYield.Utils.

I gave up on adding field additionalProperties to function liftSwaggerSchema.  Instead, I added it directly to instance of OpenApi.ToSchema for GYValue, which apparently is the only datatype in Atlas that has it.

Added function printOpenApiSchema to test manually:
ghci> -- Testing a datatype lifted with swaggerToOpenApiSchema'
ghci>
ghci> :m GeniusYield.Types.TxOutRef
ghci> import GeniusYield.Utils
ghci> import Data.Proxy
ghci>
ghci> printOpenApiSchema (Proxy @GYTxOutRef)
(fromList [],NamedSchema {_namedSchemaName = Just "GYTxOutRef", _namedSchemaSchema = Schema {_schemaTitle = Nothing, _schemaDescription = Nothing, _schemaRequired = [], _schemaNullable = Nothing, _schemaAllOf = Nothing, _schemaOneOf = Nothing, _schemaNot = Nothing, _schemaAnyOf = Nothing, _schemaProperties = fromList [], _schemaAdditionalProperties = Nothing, _schemaDiscriminator = Nothing, _schemaReadOnly = Nothing, _schemaWriteOnly = Nothing, _schemaXml = Nothing, _schemaExternalDocs = Nothing, _schemaExample = Nothing, _schemaDeprecated = Nothing, _schemaMaxProperties = Nothing, _schemaMinProperties = Nothing, _schemaDefault = Nothing, _schemaType = Just OpenApiString, _schemaFormat = Just "hex", _schemaItems = Nothing, _schemaMaximum = Nothing, _schemaExclusiveMaximum = Nothing, _schemaMinimum = Nothing, _schemaExclusiveMinimum = Nothing, _schemaMaxLength = Nothing, _schemaMinLength = Nothing, _schemaPattern = Just "[0-9a-fA-F]{64}#\"d+", _schemaMaxItems = Nothing, _schemaMinItems = Nothing, _schemaUniqueItems = Nothing, _schemaEnum = Nothing, _schemaMultipleOf = Nothing}})
ghci>
ghci>
ghci> -- Testing a datatype lifted with swaggerToOpenApiSchema
ghci>
ghci> :m GeniusYield.Types.PaymentKeyHash
ghci> import GeniusYield.Utils
ghci> import Data.Proxy
ghci>
ghci> printOpenApiSchema (Proxy @GYPaymentKeyHash)
(fromList [],NamedSchema {_namedSchemaName = Just "GYPaymentKeyHash", _namedSchemaSchema = Schema {_schemaTitle = Nothing, _schemaDescription = Just "The hash of a payment public key.", _schemaRequired = [], _schemaNullable = Nothing, _schemaAllOf = Nothing, _schemaOneOf = Nothing, _schemaNot = Nothing, _schemaAnyOf = Nothing, _schemaProperties = fromList [], _schemaAdditionalProperties = Nothing, _schemaDiscriminator = Nothing, _schemaReadOnly = Nothing, _schemaWriteOnly = Nothing, _schemaXml = Nothing, _schemaExternalDocs = Nothing, _schemaExample = Just (String "e1cbb80db89e292269aeb93ec15eb963dda5176b66949fe1c2a6a38d"), _schemaDeprecated = Nothing, _schemaMaxProperties = Nothing, _schemaMinProperties = Nothing, _schemaDefault = Nothing, _schemaType = Just OpenApiString, _schemaFormat = Just "hex", _schemaItems = Nothing, _schemaMaximum = Nothing, _schemaExclusiveMaximum = Nothing, _schemaMinimum = Nothing, _schemaExclusiveMinimum = Nothing, _schemaMaxLength = Just 56, _schemaMinLength = Just 56, _schemaPattern = Nothing, _schemaMaxItems = Nothing, _schemaMinItems = Nothing, _schemaUniqueItems = Nothing, _schemaEnum = Nothing, _schemaMultipleOf = Nothing}})
ghci>
ghci>
ghci> -- Testing OpenApi.ToSchema of GYValue, which is special in that it lifts the field 'Swagger.additionalProperties'
ghci>
ghci> :m GeniusYield.Types.Value
ghci> import GeniusYield.Utils
ghci> import Data.Proxy
ghci>
ghci> printOpenApiSchema (Proxy @GYValue)
(fromList [],NamedSchema {_namedSchemaName = Just "GYValue", _namedSchemaSchema = Schema {_schemaTitle = Nothing, _schemaDescription = Just "A multi asset quantity, represented as map where each key represents an asset: policy ID and token name in hex concatenated by a dot.", _schemaRequired = [], _schemaNullable = Nothing, _schemaAllOf = Nothing, _schemaOneOf = Nothing, _schemaNot = Nothing, _schemaAnyOf = Nothing, _schemaProperties = fromList [], _schemaAdditionalProperties = Just (AdditionalPropertiesSchema (Inline (Schema {_schemaTitle = Nothing, _schemaDescription = Nothing, _schemaRequired = [], _schemaNullable = Nothing, _schemaAllOf = Nothing, _schemaOneOf = Nothing, _schemaNot = Nothing, _schemaAnyOf = Nothing, _schemaProperties = fromList [], _schemaAdditionalProperties = Nothing, _schemaDiscriminator = Nothing, _schemaReadOnly = Nothing, _schemaWriteOnly = Nothing, _schemaXml = Nothing, _schemaExternalDocs = Nothing, _schemaExample = Nothing, _schemaDeprecated = Nothing, _schemaMaxProperties = Nothing, _schemaMinProperties = Nothing, _schemaDefault = Nothing, _schemaType = Just OpenApiInteger, _schemaFormat = Nothing, _schemaItems = Nothing, _schemaMaximum = Nothing, _schemaExclusiveMaximum = Nothing, _schemaMinimum = Nothing, _schemaExclusiveMinimum = Nothing, _schemaMaxLength = Nothing, _schemaMinLength = Nothing, _schemaPattern = Nothing, _schemaMaxItems = Nothing, _schemaMinItems = Nothing, _schemaUniqueItems = Nothing, _schemaEnum = Nothing, _schemaMultipleOf = Nothing}))), _schemaDiscriminator = Nothing, _schemaReadOnly = Nothing, _schemaWriteOnly = Nothing, _schemaXml = Nothing, _schemaExternalDocs = Nothing, _schemaExample = Just (Object (fromList [("ff80aaaf03a273b8f5c558168dc0e2377eea810badbae6eceefc14ef.474f4c44",Number 101.0),("lovelace",Number 22.0)])), _schemaDeprecated = Nothing, _schemaMaxProperties = Nothing, _schemaMinProperties = Nothing, _schemaDefault = Nothing, _schemaType = Just OpenApiObject, _schemaFormat = Nothing, _schemaItems = Nothing, _schemaMaximum = Nothing, _schemaExclusiveMaximum = Nothing, _schemaMinimum = Nothing, _schemaExclusiveMinimum = Nothing, _schemaMaxLength = Nothing, _schemaMinLength = Nothing, _schemaPattern = Nothing, _schemaMaxItems = Nothing, _schemaMinItems = Nothing, _schemaUniqueItems = Nothing, _schemaEnum = Nothing, _schemaMultipleOf = Nothing}})

Moved the repl tests shown in previous comment to doctests added to files:  PaymentKeyHash.hs, TxOutRef.hs, and Value.hs.

Superseded by #308.


Add admin mode to approve thread

Summary by Sourcery
Add an admin mode feature to the thread context, allowing users to toggle admin privileges. Implement a UI component for toggling admin mode and display an approval button when admin mode is active.
New Features:

Introduce an admin mode feature that allows users to toggle admin privileges within the thread context.

Enhancements:

Add a visual component for toggling admin mode with a button that changes appearance based on the admin mode state.

Summary by CodeRabbit

New Features

Introduced a new user role, moderator, with specific permissions across various tables for enhanced access control.
Added an admin_secret for improved security in the Hasura application.

Bug Fixes

Updated authentication logic to dynamically assign user roles based on the provider.

Documentation

Enhanced type definitions for user roles and session management to support the new moderator role.

Chores

Updated utility functions to improve role management capabilities and string extraction logic.
Modified configuration settings to improve compatibility with older environments.

Video - https://drive.google.com/file/d/13U-y79F81HmFaFQw03mvEPY3bPm1JJ4Z/view?usp=sharing. @AndlerRL


Feature request: default subcommand

Hi @sigoden, continuing to love using argc for all of my shell scripts. One pattern that I see coming up sometimes is a desire for a "default subcommand". Basically, I have a script called "backup", and I want it to... perform a backup. But I also want to add subcommands, like "backup verify" or "backup restore". With the current system, I can't do this, because the main command is completely masked by the presence of subcommands.
So the feature request is for the ability to designate a subcommand as a "default" one. Something like this:
#!/usr/bin/env bash

# @cmd
# @default_subcommand
backup() { :; }

# @cmd
restore() { :; }

eval "$(argc --argc-eval "$0" "$@")"

This script could be invoked as argc; argc backup; argc restore. Now, this behavior would cause ambiguity with positional arguments. For example, if the backup subcommand accepted arguments, should argc $PARAM be an error, or invoke argc backup $PARAM? What if $PARAM was restore? So, in order for a subcommand to be eligible as a default subcommand, it cannot accept any positional arguments.
Ideally this feature would also work with nested subcommands in the same way, so e.g. with 3 subcommands backup; backup::incremental; backup::full I could designate backup::incremental as the default for the backup command (which again could be the default subcommand for the overall script).
It would be nice if the shell completion also understood when a command was the default and showed arguments for that subcommand when there wasn't one given.
Thanks again for the consideration. Loving the activity on this project!

use main function.
# @cmd
backup() { :; }

# @cmd
restore() { :; }

main() {
  backup
}

eval "$(argc --argc-eval "$0" "$@")"

# @cmd
backup() { :; }

# @cmd
backup::incremental() { :; }

# @cmd
backup::full() { :; }

backup::main() {
  backup::incremental
}

eval "$(argc --argc-eval "$0" "$@")"

One quirk I found while playing with it is that the main command really only works if it doesn't take arguments/options/flags. If you need any of these, you have to specify the main function as a separate @cmd. It can still be invoked using the parent command, but you can't pass any parameters to it when you invoke it this way. Example: in the following, argc; argc main --incremental both work, but argc --incremental does not.
# @cmd
restore() { :; }

# @cmd
# @option --incremental
main() { :; }

eval "$(argc --argc-eval "$0" "$@")"

It would be nice to be able to use the normal @option/@flag with the main function without using @cmd, like this:
# @cmd
restore() { :; }

# @option --incremental
main() { :; }

eval "$(argc --argc-eval "$0" "$@")"

Again, allowing @arg invites ambiguity, so maybe that one should be disabled.

After pr #150, main fn can accept arguments/options/flags.
# @flag --incremental

# @cmd
restore() { :; }

main() { :; }

eval "$(argc --argc-eval "$0" "$@")"

#296 implement the feature.


[Fix #13076] Fix an incorrect autocorrect for Naming/RescuedExceptionsVariableName

Fixes #13076.
This PR fixes an incorrect autocorrect for Naming/RescuedExceptionsVariableName when using error for an omitted hash value.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Thanks! That was awesomely fast too :)


There were many lost events in the trace

When I am running PerfView in Debug/Release mode, I am getting below mentioned error popup. It is consistent across multiple trials.

During Debug, I get an additional popup as shown below ::

The two issues are not likely to be related.    For the lost events, the possibility for lost events built into ETW, and the advice that is given (right now /InMemoryCircularBuffer I think might be broken, but the /BufferSize advice is reasonable.
To diagnose  the assert, we need to at least know the assert that is firing (my code is different than yours as there is no assert on line 1884.   The closest one in my source is this line
Debug.Assert(eventsToStacks[i].EventIndex < eventsToStacks[i + 1].EventIndex);

which would be very suprising because just a few lines higher we sort the eventsToStack array.

You are right !!!
I am getting AssertionFailed(Lost Condition) from the below mentioned code in TraceLog.cs\CopyRawEvents()
        // The eventsToStacks array is sorted.
        for (int i = 0; i < eventsToStacks.Count - 1; i++)
            Debug.Assert(eventsToStacks[i].EventIndex < eventsToStacks[i + 1].EventIndex);

I need a way of reproducing your problem.  Ideally you put your ETL.ZIP file up on some cloud drive and send me a download link to it<EMAIL_ADDRESS>if you wish to do it privately).

I have sent a mail with the attachment.

Note to self: I have downloaded this on vancem1\downloads\PerfViewData.Issue_457.etl
I actually got an 5 asserts
Debug.Assert((emitted && IsDead) || KernelModeStackKey != 0);
Debug.Assert(eventsToStacks[idx].EventIndex != eventIndex);
Debug.Assert(UserModeStackIndex == CallStackIndex.Invalid);
Debug.Assert(UserModeStackIndex >= 0);
But the last ist he one that @SudhindraChegu  saw
Debug.Assert(eventsToStacks[i].EventIndex < eventsToStacks[i + 1].EventIndex);
Fails when I = 2725.   because the EventIndexes are EQUAL.  Now having two stacks for a given event is also weird, and the previous asserts are probably telling us something about why.
However I think it is fair to say that this asset is likely to indicate that only one stack is 'wrong' and the effect should be confined to one stack.
Thus it is likely to be a minor issue.   You can ignore it for now.  I will see if I can get some time to look at this more carefully, but it may not be for days or more.

Sure ... Thanks for the analysis !!
On Thu, Dec 7, 2017, 12:17 AM Vance Morrison<EMAIL_ADDRESS>wrote:

Note to self: I have downloaded this on
vancem1\downloads\PerfViewData.Issue_457.etl
I actually got an 5 asserts
Debug.Assert((emitted && IsDead) || KernelModeStackKey != 0);
Debug.Assert(eventsToStacks[idx].EventIndex != eventIndex);
Debug.Assert(UserModeStackIndex == CallStackIndex.Invalid);
Debug.Assert(UserModeStackIndex >= 0);
But the last ist he one that @SudhindraChegu
https://github.com/sudhindrachegu saw
Debug.Assert(eventsToStacks[i].EventIndex < eventsToStacks[i +
1].EventIndex);
Fails when I = 2725. because the EventIndexes are EQUAL. Now having two
stacks for a given event is also weird, and the previous asserts are
probably telling us something about why.
However I think it is fair to say that this asset is likely to indicate
that only one stack is 'wrong' and the effect should be confined to one
stack.
Thus it is likely to be a minor issue. You can ignore it for now. I will
see if I can get some time to look at this more carefully, but it may not
be for days or more.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/perfview/issues/457#issuecomment-349736433,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Agdb93fqxW_zlFauCuqzuOdCrKXnGxF-ks5s9uElgaJpZM4Qx0Gq
.

Fixed via #424.


Parameterize augur-sdk eth node URL via connector

The websocket connector will need a remote augur-sdk server url AND a eth node url.


Str to int

Prefer the VRP's ASN to be uint32
Add checks whether the VRP's Prefix Length and Max Length make any sense in relationship to the AFI

Discussed with @job, no objections from my side.

Quick reply here (busy day/quick reply from mobile, so bound to be incorrect): I think I read there were some issues with routers receiving packers via rtr with a host part that is non-zero.
This pr fixes the 'prefix length invalid, causing a router to have issues' case but it may be good to double check that the parsing does make sure that the host part is zero. I think rejecting the file is likely better then masking the host part to zero.

To follow up on this: I checked the packets sent after a SLURM file changes that containers a prefix where the host part is non-zero. Stayrtr sends the correct prefix if the host-part is non-zero in the json:
...
"prefixAssertions": [
...
      {
        "asn": 65002,
        "prefix": "<IP_ADDRESS>/24",
        "maxPrefixLength": 26
      }
    ]
...


Adapt to latest SCDF docs

see https://github.com/spring-cloud/spring-cloud-dataflow/pull/965/files?diff=unified#r85108779
(should only be merged once this server project depends on a post-M2 fixed-version of SCDF)

This should not have been merged. Sorry, the comment was wrong, we need SCDF POST M2 (I misread the released version at the time)

@ericbottard: SCDF core is already at 1.1.0.M2. Which version are you referring to?

Something AFTER M2 (need to have https://github.com/spring-cloud/spring-cloud-dataflow/commit/6bb63ffd63396e582194084099e77b7777a83dad in a released version)


Account for missing response on Webcrawler

Description

This PR addresses an issue with a broken monitor on Webcrawler. In https://github.com/dust-tt/dust/pull/7985, we assumed that a response would always be present (the Cheerio types are always set to any, which isn't very helpful). We've observed errors in production when a web page times out, resulting in no available response.
Logs are here.
Risk

Deploy Plan

PMRR.

LGTM :pray:


What's 'Maximum Number of Secondary STAs supported'?

Hi,
On Windows 10 preview build 21313, there is a new capabilities/attribute called: Maximum Number of Secondary STAs supported. Is it the same meaning as last value in this page 'The maximum number of supported simultaneous STA/WFD clients.'?
If not, where can I find the definition of the 'Maximum Number of Secondary STAs supported'?
Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3e977c01-a8a4-ae66-effb-dcbd76d6b3d2
Version Independent ID: 1ebe4ba6-a3ac-aeab-2b51-ec3b73a51577
Content: WDI_TLV_VIRTUALIZATION_CAPABILITIES - Windows drivers
Content Source: windows-driver-docs-pr/network/wdi-tlv-virtualization-capabilities.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @aviviano
Microsoft Alias: amvivian

Hi @guliteb, thanks for opening this issue. The 'Maximum Number of Secondary STAs supported' field is used for a new feature that we are introducing in the upcoming Windows releases and is not part of the WDI_TLV_VIRTUALIZATION_CAPABILITIES settings. We can't share further details about the field right now. Would you like to be contacted when those details are publicly available?

Yes, that would be good. Thanks.

@guliteb Please provide an email where we can reach you. Thanks.

<EMAIL_ADDRESS>

Thanks @guliteb. We'll contact you when these details are available.

Hi Amy, do you have any details available for sharing?

Hi @guliteb, the details are not available yet. I do have you on my contact list and I'll let you know once the info is public.


Use GCP Application Default Credentials

@mondora
The middleware should also have support for using application default credentials rather than passing a service account directly to the middleware as part of the config.
I have made the addition on my end and would like to open the PR for you, but it appears that your repo security rules forbid me from doing so.
If you can relax the rules I will open the PR for you to review!

@mondora
The middleware should also have support for using application default credentials rather than passing a service account directly to the middleware as part of the config.
I have made the addition on my end and would like to open the PR for you, but it appears that your repo security rules forbid me from doing so.
If you can relax the rules I will open the PR for you to review!

I am struggling to make the middleware work with ADC please could you post your code here or in a Gist so everyone can use it, since the repository author is not responding.


Refactor: Merge client and server Request

depends on https://github.com/dream11/zio-http/pull/1094

Codecov Report

Merging #1125 (f33a0f9) into main (d603324) will increase coverage by 0.17%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##             main    #1125      +/-   ##
==========================================
+ Coverage   57.56%   57.74%   +0.17%
==========================================
  Files          73       73
  Lines        2418     2416       -2
  Branches       79       79
==========================================
+ Hits         1392     1395       +3
+ Misses       1026     1021       -5

Impacted Files
Coverage Δ

zio-http/src/main/scala/zhttp/http/Request.scala
45.16% <0.00%> (+1.82%)
:arrow_up:

...main/scala/zhttp/service/EncodeClientRequest.scala
100.00% <ø> (ø)

...io-http/src/main/scala/zhttp/service/Handler.scala
75.00% <ø> (ø)

zio-http/src/main/scala/zhttp/service/Client.scala
90.90% <100.00%> (+4.70%)
:arrow_up:

zio-http/src/main/scala/zhttp/http/Version.scala
44.44% <0.00%> (+22.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d603324...f33a0f9. Read the comment docs.


Updates rc5

Codecov Report

Merging #209 into rc-ng4-upgrade will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           rc-ng4-upgrade   #209   +/-   ##
=============================================
  Coverage             100%   100%
=============================================
  Files                  42     42
  Lines                 989    989
  Branches              152    152
=============================================
  Hits                  989    989

Flag
Coverage Δ

#builder
100% <ø> (ø)
:arrow_up:

#runtime
100% <ø> (ø)
:arrow_up:

#srcapp
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5454e9a...832bcc0. Read the comment docs.


텍스트 필드에 empty string을 넣었을때, 에러가 발생합니다.

Doctor summary (to see all details, run flutter doctor -v):
[!] Flutter (Channel stable, 3.7.1, on macOS 13.5.2 22G91 darwin-arm64, locale ko-KR)
! Warning: dart on your path resolves to /opt/homebrew/Cellar/dart/3.0.5/libexec/bin/dart, which is not inside your current
Flutter SDK checkout at /Users/lulu/dev/flutter. Consider adding /Users/lulu/dev/flutter/bin to the front of your path.
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.3)
[✓] IntelliJ IDEA Ultimate Edition (version 2022.3.1)
[✓] VS Code (version 1.82.2)
[✓] Connected device (3 available)
[✓] HTTP Host Availability
버전: korea_regexp: 1.0.1
텍스트필드에 값을 입력하고, 지우는 과정에서 empty string이 되었을때 아래와 같은 에러가 발생 합니다.
Invalid value: Valid value range is empty: -1

이슈 처리 완료되어 닫겠습니다.


Prevent reading all node_modules when using [untyped]

I want import 'foo/bar' to not throw "cannot find module" errors, but want to prevent the server looking at all my node_modules.
With the current options there is no way to get this to work.
a.
[untyped]
.*/node_modules/.*

Problem: Dramatically slower server startup.
This makes the server scan all my node_modules. I have ~3000 project files, and 200K files in node_modules.
This means the server takes 1 minute to start versus instantly.
Instead of needing to read and watch every node_module file to ensure import 'foo/bar' is valid, just check whether the files exist during type checking process. But I would be fine with just ignoring the check of whether my imports are valid for node_modules too.
b. ignore
[ignore]
.*/node_modules/.*

Problem: "Cannot find module" errors for any import foo from 'foo'.
c. ignore all node_modules except first level of dirs
(Ignore all node_modules dirs except the first)
[ignore]
.*/node_modules/.*/.*/.*

# Needed for pnpm because Flow tests regexes on realpaths - see #7429
.*/node_modules/\.registry\.npmjs\.org/.*/.*/node_modules/.*/.*/.*

Problem: import 'foo/bar' doesn't work.
d. declarations
[declarations]
.*/node_modules/.*

Problem: Still slow server startup - scans every file.
Problem: Errors are shown for all 3rd party modules with type annotations of which there are usually hundreds broken (e.g. graphql@0.13.2). This will happen perpetually because there will always be deprecations and new features, and flow doesn't have a way to version type annotations.
e. name_mapper for all non-relative requires
[ignore]
.*/node_modules/.*

[options]
# Match `import 'foo'` but not `import './foo'`.
module.name_mapper='^[A-Za-z]+.*' -> '<PROJECT_ROOT>/any.js.flow'

any.js.flow
// @flow
declare module.exports: any;

Doesn't scan or watch any node_modules. All package imports will be replaced with any type - just liked [untyped] does.
Problem: This doesn't work with a monorepo where import foo from 'foo' could refer to a symlinked package.
Problem: It's not flexible.

Solution
Add an option module.system.node.silence_module_not_found_errors_in_ignore_paths or something like that.
Related

https://github.com/facebook/flow/pull/4916#issuecomment-423248422

a lot of us want type processing in node modules but NO errors shown in any node modules. We want errors to be shown in our own code when we missuse a module, but we don't want to see that any node modules did something wrong internally. We want to be able to maintain code that is error free and see that on a PR there are no flow errors, but we can't do that when node modules reports hundreds of errors for dependencies I can't control.

Not checking node_modules https://github.com/facebook/flow/issues/1548
Any way to deal with node_modules dependencies errors #5568

One could do the following;
add the library you want to ignore to [ignore]
then create a JS-file with similar name  to library in the flow-typed folder.
with the content:
// @flow
declare module "<LIBRARY_NAME>" {
  declare module.exports: any;
}

Standard is just to use flow-typed which can help you stub any definitions that don't exist in flow-typed. Then you can safely ignore all of node_modules which solves performance issue and module resolution.

@Brianzchen I don't understand why that would be the standard recommendation. This would prevent library authors from including useful Flow type definitions in their npm packages. Surely this could only hurt flow's adoption?
In my experience, flow-typed is useful but not adequately complete.

flow-typed will solve the immediately issue of performance and not being able to resolve anything.
I should have been more thorough in explaining though. You're right this would stop library developers from shipping flow types, which is why flow also comes with exclusions for ignores which you can read about here, https://flow.org/en/docs/config/ignore/ (at the bottom of the page)
So your flow config would look something like
[ignore]
<PROJECT_ROOT>/node_modules/.*
!<PROJECT_ROOT>/node_modules/not-excluded-package-A/.*
!<PROJECT_ROOT>/node_modules/not-excluded-package-B/.*

# other stuff...

To my knowledge flow has no way of knowing if a package ships with flow types, so it has to be a manual process. My recommendation is that if flow-typed stubs the library, you should check if it ships with flow types.
Hope this was an appropriate explanation.

Thank you, that is helpful.
Still, though, this seems like a workaround, not a solution. Manually declaring how to handle the types for every dependency is tedious, if nothing else. Again, this feels like a barrier to adoption.
I have found that using [declarations] to scan my node_modules works exactly how I would like, except that it is very slow.
It seems that there should be some solution that flow could implement to improve the performance. Perhaps this needs to be a separate ticket, but it seems very important to me.

why is this closed? The number one benefit to Flow (vs TypeScript, others) is that I can run it on vanilla js quickly and efficiently!
At the very least why not extend [lint] config to allow power users to ignore cannot-resolve-module errors?
There are huge javascript libraries where there's no chance of ever migrating them - even adding // @flow is asking a lot in some cases ;). So please just give an option to use Flow with flexible adoption/migration plans by disabling certains checks and directories

@vjpr @murrayju it's too bad this issue was closed as I agree with you both there should be just a single line of config to address this issue.
Here's my workaround, 2 lines of config per node_module you need to import:
[ignore]
<PROJECT_ROOT>/node/.*
<PROJECT_ROOT>/node_modules/.*
<PROJECT_ROOT>/src/__tests__/.*
<PROJECT_ROOT>/webpack.config.js
<PROJECT_ROOT>/pom.xml
<PROJECT_ROOT>/.babelrc
<PROJECT_ROOT>/frontend.iml
# to avoid import errors, parse only necessary modules per: https://github.com/facebook/flow/issues/7431
!<PROJECT_ROOT>/node_modules/react/index.js
!<PROJECT_ROOT>/node_modules/react-dom/index.js

[options]
# no need to add // @flow to every file, by default it parses all with flow
all=true

[declarations]
<PROJECT_ROOT>/node_modules/react/index.js
<PROJECT_ROOT>/node_modules/react-dom/index.js

[untyped]

[include]

[libs]

[lints]


Disable output

It would be great if there will be a flag to disable output.
Now I am forced to use statement `with io.capture_output() as captured:' to solve this problem in jupyter notebook. In a file script, you usually have to do more complicated ways.

The Blur Detector object by itself is not programmed to show the output image during every run. In the example.py file, i am using cv2.imshow() to display the output. Are you sure you are running your codes without this so as to not display the image by default?

Oh, sorry for the ambiguity. I meant progress output.
In the source code this can be seen in the function: https://github.com/Utkarsh-Deshmukh/Spatially-Varying-Blur-Detection-python/blob/8c8a35b51169ff588b8dd145f8a9a6c7d1bfbb01/BlurDetector.py#L32-L50


Fix handling of ETF redirection in MarketWatchClient

Fix handling of ETF redirection in MarketWatchClient
Description
This PR addresses an issue where requests to MarketWatch for ETF tickers were being redirected, causing the get_price method to fail. The solution includes:

Allowing httpx to follow redirects automatically by setting follow_redirects=True in the get request.

Changes Made

Updated the get_price method in MarketWatchClient to include follow_redirects=True in the GET request.

Testing

Tested with various stock and ETF tickers to ensure correct redirection handling and price retrieval.

DId you tests it on your local machine. If yes can you send a screenshot or fix the automatics tests


building rn project on ios fails with: No matching function for call to 'objc_msgSend'

i could successfully export the unity project, but building the react-native ios project fails with "No matching function for call to 'objc_msgSend'"

What is your unity project? First step, It is recommended to use Cube instead of.

@f111fei i used an own simple one.
I figured out, that this only happens on the simulator. It works only on a device

Had the same problem, switching Enable Strict Checking of objc_msgSend Calls to No in Build Settings fixed the problem.

If I try to run the project on the device I get the following error:
▸ Compiling RCTBundleURLProvider.m

❌  /Users/federico/code/react-native-unity-demo/node_modules/react-native/React/Base/RCTBundleURLProvider.m:17:53: use of undeclared identifier 'undefined'; did you mean 'underline'?

const NSUInteger kRCTBundleURLProviderDefaultPort = RCT_METRO_PORT;
                                                                     ^

▸ Compiling RCTLayoutAnimationGroup.m
▸ Compiling RCTNavigator.m
▸ Compiling RCTTabBar.m
** BUILD FAILED **

The following build commands failed:

	CompileC /Users/federico/code/react-native-unity-demo/ios/build/Build/Intermediates.noindex/React.build/Debug-iphoneos/React.build/Objects-normal/arm64/RCTBundleURLProvider.o Base/RCTBundleURLProvider.m normal arm64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)```

@nmsdvid 's solution caused 201 errors in my XCode project 🙃 Still haven't tried in a real device yet

Had the same problem, switching Enable Strict Checking of objc_msgSend Calls to No in Build Settings fixed the problem.

Followed your steps but unable to run project in iOS. 😕

I am facing the same problem during running the #react-native-unity-demo project No matching function for call to 'objc_msgSend.If anyone found the solution please help it's highly appreciated.


This seems interesting!

It could help many macOS users when setting up Windows on a VM. Keep up the excellent work 👍

Man, I wish GitHub could add comments.


ZapfDingbats and Symbol rendering

I have the following test code, which prints out the Latin small letter h, using different font faces:
doc.fontSize(30);
drawHorizontalLine(doc);
doc.font("ZapfDingbats").text("\u0068");

drawHorizontalLine(doc);

doc.font("Symbol").text("\u0068");

drawHorizontalLine(doc);

doc.font("Helvetica").text("\u0068");
drawHorizontalLine(doc);

doc.font("Ico-Moon").text("\ue600");
drawHorizontalLine(doc);

doc.font("Helvetica").text("\u0068");
drawHorizontalLine(doc);

doc.end()

The problem here is that using either ZapfDingbats or Symbol font-faces, the character is drawn above its line as the picture shows (The red arrows are pointing where the characters should be drawn)

Also, on the picture the PDF was opened inside an iframe using Chrome on Ubuntu. However when I downloaded this PDF and opened with a local PDF reader, the ZapfDingbats and Symbol characters were missing.

Did you ever end up resolving this?


Question about mask in V3

Hello,
I've already used PIXI in several projects, firstly, i want to thank you for all this awesome work!
But for my current project, I need to do a mask with a complexe shape, that i can't draw with code. The perfect solution for me could be to have a PNG image as a mask, and render my texture only on the visible part of this PNG.
Something like that seems to be possible with the V3 (http://www.goodboydigital.com/client/goodboy/nebulon/)? But there's not a lot of documentation yet and the deadline for my project doesn't allow me to wait the official release..
Could someone help me a little bit with that?

You can use a sprite as a mask in v3, just assign a sprite to another sprites mask property.

Hello,
thank for your response,
You mean that a mask will only use the visible pixels of the sprite, no matter what there are inside? Using alpha too I guess? If yes, seems to be very awesome!
But, i've just made a quick test, and it doesn't seem to work as expected:
var textureLogo = PIXI.Texture.fromImage('img/logo-mask.png');
var logoMask = new PIXI.Sprite(textureLogo);

var textureTexture = PIXI.Texture.fromImage('img/logo-texture.jpg');
var logoTexture = new PIXI.Sprite(textureTexture);

canvasStage.addChild(logoMask);
logoTexture.mask = logoMask;
canvasStage.addChild(logoTexture);
canvasRenderer.render(canvasStage);

logo-mask.png is a PNG file where the shape is black and the rest is transparent.
If I comment the line logoTexture.mask = logoMask; the both images appear
I think I misunderstood something?
(sorry for my english, and thanks again for help!)

Try waiting until the images load, then using the mask. Don't remember if it handles unloaded images properly.

I already wait the end of loading before apply the mask. I've simplified a little bit the code for my post, but in fact, I use the new PIXI.loader to preload my assets, then I draw my stage.
Using Texture.fromFrame or Texture.fromImage the results are the same: when I apply the mask, the both images disappear, even in a big setTimeout to be sure i'm waiting enough time for loading.

hi there! are you using webGL? Alpha masking is only available in webGL at the mo. cheers!

Hi!
I've found the solution thanks to your help,
two things:

first, I was using a black and transparent PNG, if I use the same with white instead of black it works,
I don't know if it's "normal" that black be considered as transparent?
secondly, it need a second "render" call, in a ````setTimeout(function() {}, 0)``` to be displayed.. weird

Thanks again to your help

good stuff! yes alpha masks use alpha / color to make life easy for people. So black and alpha of 0 will mask the item. Thanks!

Ok!
Just a little precision about the second point, it doesn't need a setTimeout, just need two calls to render:
canvasRenderer.render(canvasStage);
canvasRenderer.render(canvasStage);

and it's ok, but without the second, the mask doesn't display.. Don't know if it's "normal" again?

@GoodBoyDigital
This is the first time I am using pixijs in my any project and I found it is very easy (yet POWERFUL) to start with it. Previously I was using three.js library and I have spent almost a month to optimize my program and still struggling with performance and this library has fixed all performance issue one day however I have not fully implemented in my system but getting +ve feelings.
My program is totally based on 2d graphics and in first face I have started to implement complex polygons with holes. Sooner I came to know pixijs does not support non-zero winding rules or any direct api to add holes in polygon but can be done using PIXI.Sprite. I have achieve it anyhow but don't know whether there is better approach then below.
        var renderer = PIXI.autoDetectRenderer(1200, 900);
		document.body.appendChild(renderer.view);

		// create the root of the scene graph
		var stage = new PIXI.Container();

		//beneathObject1 & beneathObject2 are added to make sure an overlapping object with hole is working as expected.
		var beneathObject1 = new PIXI.Graphics();
		beneathObject1.beginFill(0XFFFFFF);	//White object
		beneathObject1.drawRect(0, 0, 800, 800);
		beneathObject1.endFill();
		stage.addChild(beneathObject1);

		var beneathObject2 = new PIXI.Graphics();
		beneathObject2.beginFill(0X60b044);	//Green object
		beneathObject2.drawRect(100, 100, 600, 600);
		beneathObject2.endFill();
		stage.addChild(beneathObject2);

		//Adding hole into the shape
		var baseObject = new PIXI.Graphics();
		baseObject.beginFill(0XF41A1A); //Red object
		baseObject.drawRect(0, 0, 500, 500);
		baseObject.endFill();

		//Mask object is the polygon with holes.
		var maskObject = new PIXI.Graphics();
		maskObject.beginFill(0XF41A1A); //Red object
		maskObject.drawRect(0, 0, 500, 500);
		maskObject.endFill();

		maskObject.beginFill(0X000000); //Objects(Black colored) which I want to remove
		maskObject.arc(100, 100, 25, 0, 2 * Math.PI);
		maskObject.arc(100, 200, 25, 0, 2 * Math.PI);
		maskObject.endFill();

		var mask = new PIXI.Sprite(maskObject.generateTexture());
		mask.position.x = 310;
		mask.position.y = 190;

		baseObject.mask = mask;

		stage.addChild(mask);
		stage.addChild(baseObject);

		renderer.render(stage);
		renderer.render(stage);

Output:

One last thing as @jeremypetrequin mentioned I have to call renderer.render(stage); twice to get correct output. Don't know why is that?

Just a quick question.
The docs say Graphics.
Can a mask be any DisplayObject or is it limited to say, Graphics | Sprite?

Right now it is Graphics | Sprite.
This line needs to be updated: https://github.com/GoodBoyDigital/pixi.js/blob/07e4e26f8fd404524a7ebaa73c210de3d8f2cf25/src/core/display/DisplayObject.js#L225
(and the @property line below that removed)

I just stumbled over this issue myself. I can't seem to get masking working at all. I'm using a sprite loaded from an Image to mask a rectangle created from a PIXI.Graphics object. This is my code:
var bg_color = 0xCFD1CE;

var render_options = {
    antialias: true,
    backgroundColor: bg_color
};

this.renderer = new PIXI.CanvasRenderer(window.innerWidth, window.innerHeight, render_options);

document.body.appendChild(this.renderer.view);

var app = new PIXI.Container();

var variable = PIXI.Sprite.fromImage('img/testmask3.png');

setInterval(function()  {
    var rColor = Math.random() * 0xFFFFFF;
    app.removeChildren();
    var first = new PIXI.Graphics();
    first.beginFill(rColor).drawRect(0, 0, 640, 480).endFill();

    var second = new PIXI.Graphics().beginFill(0x000000).drawCircle(100, 100, 30)
    first.mask = variable;
    app.addChild(first);

    this.renderer.render(app);
}, 500);

I used these three testimages as masks:
1.

2.

3.

@englercj I am getting the same issue as @SphinxC0re .
Using the WebGL renderer, latest Pixi.js source from master.
I verified that the mask is loaded and my code looks like:
    var object = new PIXI.Sprite.fromImage(this.getAssetPath(layer.image));

    object.width = layer.width;
    object.height = layer.height;
    object.x = layer.x;
    object.y = layer.y;

    var mask = PIXI.Sprite.fromImage(this.getAssetPath(layer.mask));

    object.mask = mask;

    container.addChild(object);

and of course I have renderer.render(container) running in a RAF callback.
Are we using the mask property wrong with PIXI.Sprite objects?
Thanks!

Update: If I specify the object.x and object.y as 0, then the mask works perfectly. As I increase the object's position in the X and/or Y axes, the object gets "cut" in its top and left boundaries.

Add the mask as a child of the object is is masking, so that it follows it around.

Thanks,
Just did that and indeed it is masking in the correct place, but it seems like it's smaller than it should be. The mask image is exactly the same size as the object's image, but the resulting masked object I get is smaller for some reason?
Also, what's the reasoning behind having the mask layer in the layer tree itself? For me it seems like a "mask" is just like any other layer property that changes its appearance.
Thanks again,
Bar.

Has support for canvas alpha masking ever been included? Is it possible? The project uses PIXI.js for server side rendering of video with heavy use of masking. Thank you so much!!

No alpha masking works using a gl shader, no canvas support.


Parent hyperlink is removed

I am using the lazy load in a code structure like below -

However, when the loading happens, the external a tag is not considered. Is there a way to do so?

Your HTML is invalid - you cannot put a link inside another link. You don't need to though - the instructions provide the answer...

Alternatively, the instructions also describe how to use (almost) any containing element:


ci: update build and add worflow for maven central publishing

feat: allow publishing in custom repo with command line argument
ci: add release workflow (that publishes on maven central)
ci: add test workflow
build: update gradle wrapper
fix gpg variable names which were confusing in build.gradle
chore: bump version to release 1.0.0

Note: for now the CI only authorize publishing release versions (no snapshots)
I'll add a snapshot workflow if necessary

Thank you very much @nsenave


The stretchly.Setup.0.19.1.exe is quarantined by Symantec (Malware / WS.Reputation.1)

Hi,
New version's installer (stretchly.Setup.0.19.1.exe) is blocked by Symantec.
Operating system: Windows 10 Enterprise, 64-bit, version 1709, OS Build 16229.904
Symantec Endpoint Protection: version 14 (14.0 RU1 MP1) build 3876 (14.0.3876.1100) with latest definition files
See attached pics.
Please check.
Thanks,
vinczu

Seems that Symantec quarantined it because it has only seen this file by less than 5 user. TBH: weird, no idea what they are trying to say...

I've submitted a dispute form at Symantec, let's see

great :+1: in general, there used to be problems with false positives for electron-based apps in past

good news: issue is now solved, I could install the 0.19.1 version
Reply from Symantec:

Upon further analysis and investigation we have verified your submission and, as such, the detection(s) for the following file(s) will be removed from our products:
File name: stretchly.Setup.0.19.1.exe
MD5: B10C2BAA408A7584A3A9E659521084EE
SHA256: 1AFA54BAFDBE2C19EBD5DC41C8235CA086200577BB737AB9D7CF0B984C136563
Note: Whitelisting may take up to 24 hours to take effect via Live Update

Great! Thanks for your help!


feat: Adds globalClusterSelfManagedSharding to cluster

Proposed changes
Adds globalClusterSelfManagedSharding to cluster
Choosing not to update examples as this is an advanced use case
Link to any related issue(s): CLOUDP-256268
Type of change:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as
expected)
[ ] This change requires a documentation update

Required Checklist:

[x] I have signed the MongoDB CLA
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added any necessary documentation (if appropriate)
[x] I have run make fmt and formatted my code
[x] I have tested the CDK constructor in a CFN stack. See TESTING.md
[x] If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments
Manual testing:
Create

UI

Update

UI

Delete

nice! knit: PR description checklist is not updated

Added screenshots of testing now :D


[Envato Sales] ... it doesn't work.

Extension
https://github.com/raycast/extensions/tree/de047f2e9ad02d2c79a526f2291f64f74aca05b6/extensions/envato/
Description

Error:

Steps To Reproduce
added envato api token
set all permision to yes.
but it says 'something wrong'
Current Behaviour
No response
Expected Behaviour
No response

I can't add the error message. github says "too long body"


Static port for cortex-nginx service

I want to register Cortex(cortex-nginx service especially) in my own service discovery. The problem is that everytime I reinstall Cortex, cortex-nginx NodePort is changing.
Correct me if Im wrong, but shouldn`t this chart give us possibility to define static NodePort for the cortex-nginx service?

I want to register Cortex(cortex-nginx service especially) in my own service discovery. The problem is that everytime I reinstall Cortex, cortex-nginx NodePort is changing. Correct me if Im wrong, but shouldn`t this chart give us possibility to define static NodePort for the cortex-nginx service?

yep feel free to create an PR which introduces this logic. Although I think it's weird to do anything Node Port related 🤷

I want to register Cortex(cortex-nginx service especially) in my own service discovery. The problem is that everytime I reinstall Cortex, cortex-nginx NodePort is changing. Correct me if Im wrong, but shouldn`t this chart give us possibility to define static NodePort for the cortex-nginx service?

Its certainly possible to pin a static port, but it seems like you'd be better off specifying an ingress pointing to the service. Would have to know more about your use case, but this does seem kinda odd.


Destinations converted to lower case and spaces replaced with underline in Destinations field - destination_sign

URL
https://www.openstreetmap.org/edit?relation=13134194#map=19/-23.54554/-46.59221
How to reproduce the issue?
Add a two-word capitalized destination name using the form field
Screenshot(s) or anything else?
No response
Which iD Editor versions do you see the issue on?
Released version at openstreetmap.org/edit
Which browsers are you seeing this problem on?
No response

Thanks for reporting this issue. openstreetmap/id-tagging-schema#515 has a fix.

Em seg., 27 de jun. de 2022 às 15:23, Minh Nguyễn @.***>
escreveu:

Thanks for reporting this issue. openstreetmap/id-tagging-schema#515
https://github.com/openstreetmap/id-tagging-schema/pull/515 has a fix.
—
Reply to this email directly, view it on GitHub
https://github.com/openstreetmap/iD/issues/9185#issuecomment-1167619666,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAVLUCMCSOQAXHQUJ56LFN3VRHWT5ANCNFSM5Z6MM64Q
.
You are receiving this because you authored the thread.Message ID:
@.***>

Thanks!


Get test-coverage > 90%

@86%. Improve by:

removing MultiSelect (+ 1%)
parsing args (+ 1.5 %)

We will not implement changing configs for now. If we will be able we can improve more by

adding thresholds
thematic_view = False

then only at build_dashboard.py we have significant lines open (CLI and build environment) but these cannot be tested.