Re-write userguide to support Python 3 and future proofing Sphinx

This are a complete re-write of the Sphinx support for the manual, changes included and not limited too:

Changed the requirement to Python 3 and changed conf.py to reflect those changes
Contribution documentation and readme
Minimal makefile (for building html/epub...)
Removed "cilexer" dependency
Added requirements.txt for automatic building userguide
Removed bundle theme and load it externally with pip
Custom Javascript for adding chapter and subject classes to all pages
Changed some code styling in the userguide that broke

As discussed in #2644.
Checklist:

[X] Securely signed commits
[X] User guide updated
[X] Conforms to style guide

Forgive my ignorance, but let me restate this to see if I have it right.

We use Sphinx to generate HTML content from the user_guide_src code
The styling is handled at least partly by the theme, "sphinx_rtd_theme"
The theme is not compatible with Sphinx version 2 (latest: 2.4.4) so must run on 1.8.5
Sphinx 1.8.5 is not compatible with Python 3

If I got that all right, I'd be in favor of looking into using a more recent branch of the theme, assuming it's compatible with our source code. Looking at their repo there have been hundreds of commits to master since that last release which was more than a year ago. I'd really like to be on Python 3 as I think it would increase our chances or reusable GitHub Action code to assist with automation.

Relevant thread: https://github.com/readthedocs/sphinx_rtd_theme/issues/379

we will not be supporting installation from the repository. We do not want to support users using our master branch, which is not even alpha release quality. We will be releasing to PyPI as development releases more often once some of our structural changes are ironed out. - agjohnson commented on Oct 16, 2019

So that actually suggests sticking with the current release as @jreklund suggested and hoping they have a release soon.

Just ask away, I figured out this myself yesterday so I'm quite fresh on the subject myself.

That's correct it (with dependencies) turn our rst files into X format. We use it for html and epub.
Correct, that theme provide the base html structure and styling. On top of that we have our own stylesheet.
Correct, the current theme version break the search function. Currently waiting for this to be merged into a release. https://github.com/readthedocs/sphinx_rtd_theme/pull/728
Sphinx 1.8.5 support Python 3, if installed with pip3 instead of pip. But ammaraskar/sphinx-action looks like it runs with pip (Python 2). Sphinx 2 have dropped support for Python 2, don't remember if I got it to run or not, I destroyed like 8 virtual machines yesterday... Will have to check it out again.

Okey, made another go at this. We can use Python 3, as long as the virtual machine in actions dosen't restart. We can use the following script to install pip3 and alias it to pip.
pre-build-command: "sudo apt install -y python3-pip && alias pip='pip3'"
And it can install our requirements.
sphinx==1.8.5
sphinxcontrib-phpdomain>=0.7.0
docutils<=0.16

May raise an question about it in the project itself, as their requirements.txt lists 2.0.0 and that not be possible with pip. Only with pip3.

Actions are not hard to update, might be worth a PR to the owner or a fork to support pip3. I'm not sure about your question in "Update 3" - I wasn't planning on automating anything about the User Guide via Travis, is that still relevant?
Sorry about the merge conflict, I forgot this touched a bunch of pages. I'll look more closely at User Guide updates before this is done.

I don't know if their actions make some auto-magic like their Travis build. If it does; Python 3 are already being used.
PIP have some functions to create virtual environments, you always get the correct version when building. That's what Travis are using to get a correct Python 3.7 pip build going. So that where my question, if you have build any of those. As you can include it into the project.
At the moment I'm rewriting the manual to support Python 3 instead. Ignoring the virtual environment.
No worries, it happens. Will look at what went wrong.

I have now updated the manual reflecting Python 3 instead.

I'll make a test Python Action when I have a chance and check out the default versions and what pip is mapped to - then we can decide if using the existing Action makes sense or if we need to fork something.

Okey, I have now merged in another branch I have been working on. As this are no longer a PR for just removing cilexar, but a complete re-write of Sphinx with Python 3 and other goodies.
I have updated the main post and the title to reflect that.

@jreklund This looks amazing, and like a lot of work. It's also totally out of my league. I was trying to hang on this PR but I think I'll need someone else to review. Not sure if @lonnieezell feels comfortable doing that or if we need someone else, but I would like to get this merged in so we can look at automatic UG deployments.

Thanks! It took a fair amount of time to figure it out myself, so I don't expect people to now it themselves. If you want me to clarify some design choices I'm happy to do so. :-)

I downloaded it and gave it a spin. Had to install pyenv to get away from python 2 (I'm not sure if my company's deploy scripts will work on v3 or not so wanted to make sure to keep both). 3.6 gave me errors, but 3.7 worked great. The UG itself looks great, also. Nice job!
The only thing I can think I'd like to change is to fix the width of the main column to something more readable.
Merging. Thanks!

Hi, thanks. I can now keep going updating the manual, it where kinda hard too see if everything looked OK, as code didn't receive correct syntax highlight without this (on my machine).
Did you take down notes on what kind of errors you received on Python 3.6? I had no troubles compiling the manual on 3.6.9 on Ubuntu Server, that's the version I got from the OS package manager.
I have had the same problem, and I'm only on a 1080p display. The default value are 800px, but that can be kinda narrow for some of our pages. Personally I think anything above 900px give a bad experience, as you can't see it all at once. But as the theme already had the whole page, I didn't change it.

Unfortunately I didn't take notes. I think it was a single package that was complaining. I shrugged, realized I wasn't on the latest version of Python and upgraded and it all worked like a charm after that.
Besides readability, I have an ulterior motive - We've been given the chance to get Carbon ads to running, and was hoping to find a nice spot to the side of the text that was out of the way but still above the fold to place a single small ad. But I first need to figure out where the theme actually is lol.

@jreklund I've been playing a bit and got things working pretty well. I've created a new template that overrides the layout.html file, adding the script tag for the Carbon ads. Have it all styled up and even limited the content width to max of 60em.
Any idea how I could specify that the add only gets inserted when I build? I don't need the ad showing up for everyone as they work on the docs (though I guess that's potentially extra clicks ha!) Trying to find something maybe using environment variables but so far I'm striking out.

I looked up some things today in the docs and it took some time to actually notice that the width of the text had changed. It just seamed so natural.
They only way are to replace / insert that file into the correct folder after the docs have been built, you can't specify different environments and include different files (what I know of). You didn't need to edit conf.py correct? You just added a complete copy of layout.html (with changes) into the correct folder?
Instead of replacing the layout file, what can be done instead are creating a custom JS file, and let it add Carbon

Didn't need to edit conf.py. Just added a new file _templates/layout.html with the following:
{% extends "!layout.html" %}

{% block menu %}
    {{ super() }}
    <script async type="text/javascript" src="//cdn.carbonads.com/carbon.js?serve=CE7I62QW&placement=codeignitercom" id="_carbonads_js"></script>
{% endblock %}

And added some styles to citheme.css for the ads.
Don't suppose you can provide an example of inserting that via javascript?
The 4.0 manual is hosted on codeigniter.com now. I cheated a bit last night and used the current version instead of 4.0.2 version, but otherwise, the latest release will be on codeigniter.com and the in development branch should be where it previously was. I would like to look at changing that in the near future, so that all docs are hosted on codeigniter.com with a version switcher, but we're not quite there yet.

Okey, that looked kinda neat. You didn't need to replace the whole thing. That's good!
If you want to do it JS style. You can modify conf.py:
# A list of JS files.
html_js_files = [
	'js/citheme.js',
	'js/cicarbon.js',
]

source/_static/js/cicarbon.js:
/*
 * Add Carbon Ads underneath navigation to support CodeIgniter Foundation
 */
window.onload = function() {
	// Create a HTML DOM Element Object
	var carbon   = document.createElement('script');
	carbon.async = true;
	carbon.type  = 'text/javascript';
	carbon.src   = 'https://cdn.carbonads.com/carbon.js?serve=CE7I62QW&placement=codeignitercom';
	carbon.id    = '_carbonads_js';

	// Append Carbon Ads to .wy-menu
	document.querySelector('.wy-menu').appendChild(carbon);
}

That would be neat to do it like readthedocs.io and just link to one manual and you can pick any version. They also provide links to download it.

After have looked thru the userguide with ads on for a while, it's kinda hard to even see it. So we should (if page is wide enough) make it either fixed in the right corner or just position it there with absolute.
Here are a mockup.

I agree with that. And that was my initial thought. At the time I did that I hadn't yet explored how easy it was to change the theme. But I an put a margin on the main content area for desktops, at least, to keep it workable. I'll have to see how that works on mobile in both of these situations. I didn't actually look into that at all. oops!
If you were willing would you mind taking a look at something else with the docs? There are two things reported on the forums today that I thought were just me, since my connection sucks often. The flicker of unstyled content is the most annoying. I haven't had a chance to dig into what's doing that just yet. But it would be awesome if you were able to!

If you render the ad under the menu, you can use media queries to move it on desktop, if the screen are big enough.
I think the blinking text comes from loading all JS resources before CSS and creating a rendering blockage. There are too many files getting loaded. It's worst in FireFox. Personally I haven't notices anything more than a jumping menu, those + signs in Google Chrome. But now then I start testing other browser, omg! That's horrible.
Will see if I can figure something out.


recommend docs for all major functions to have self contained examples (even if with dummy data)

Goes a long way to get more people interested and adopt

@apratap Great suggestions. If you check out this markdown here https://github.com/Sage-Bionetworks/mhealthtools/blob/develop/vignettes/Introduction to mhealthtools.Rmd explains what vignettes are available or will be available in the near future. Do you suggest more than this for all the utility functions too?

My suggestion was that help on major functions should have demo code (hopefully self-contained)
?mhealthtools::get_tapping_features -> lacks any example

@itismeghasyam check @apratap suggestion. Basically, move some of the content in the vignettes to the main functions themselves using /examples tag. Check roxygen2 on how to write examples.

Resolved by #88


Keras models

Basic fix to clarify the saving of keras models.

Does this solve an existing Issue?

If so, please link to the issue.
If not, please describe what your change does and why.

Running the basic examples, I see issues with the keras handling of the model saving (I think due to the lack of specificity of the h5py File handler)
File "/home/mcoughlin/anaconda3/envs/aiqc/lib/python3.8/site-packages/tensorflow/python/saved_model/loader_impl.py", line 111, in parse_saved_model
raise IOError("SavedModel file does not exist at: %s/{%s|%s}" %
OSError: SavedModel file does not exist at: /home/michael.coughlin/.local/share/aiqc/temp_keras_model/{saved_model.pbtxt|saved_model.pb}

Put an x inside the applicable checkboxes [ ].

Primary type of change:

[ ] New feature.
[x] Bug fix.
[ ] Refactor.
[ ] Documentation.
[ ] Build/ devops.
[ ] Test.
[ ] Other.

Checklist:

[x] I have actually ran this code locally to make sure it works.
[ ] I have pulled and merged the latest main into my feature branch.
[ ] I have ran the existing tests, and inspected areas that my code touches.
[ ] I have updated the tests to include my changes.
[ ] I have included updates to the documentation.
[ ] I have built the documentation files make html.

Describe the env you tested on: OS, Python version, shell type (e.g. cli, ide, notebook).
Linux, 3.8, python script

Contains breaking changes:

[ ] Yes (explain what functionality it breaks).
[x] No

How to run the tests.
The source code for tests is located in aiqc/aiqc/tests/__init__.py.
Once we are confident that our schema handles all data types and analysis types, we will invest more rigorous testing.
import aiqc
from aiqc import tests

q1 = tests.make_test_queue('keras_binary')
q1.run_jobs()

q2 = tests.make_test_queue('keras_multiclass')
q2.run_jobs()

q3 = tests.make_test_queue('keras_regression')
q3.run_jobs()

q4 = tests.make_test_queue('keras_image_binary')
q4.run.jobs()

q5 = tests.make_test_queue('pytorch_binary')
q5.run.jobs()

q6 = tests.make_test_queue('pytorch_multiclass')
q6.run.jobs()

q7 = tests.make_test_queue('pytorch_regression')
q7.run.jobs()

q8 = tests.make_test_queue('pytorch_image_binary')
q8.run.jobs()

I ran with success tests 1-3 which I could imagine this touches. Does test 4 work generally?

q4.run.jobs()
Traceback (most recent call last):
File "", line 1, in
AttributeError: 'Queue' object has no attribute 'run'

Hey thanks so much for jumping in @mcoughlin.
So .run.jobs() is my fault it should be run_jobs(). I have pushed a fix for this in the PR template just now.
I have cloned and ran your code successfully, and also tested it with inference. Maybe it was a linux/conda thing. So if these new lines make it work for you, then that's great.
Could you please import h5py up at the top of the file?
Could you provide a more explicit variable name than g?
Thanks again!

@aiqc Yeah thanks. I figure it is some weird conda / package thing, thanks for being flexible.

@mcoughlin Would you be interested in joining our slack channel?

@aiqc sure.

@mcoughlin word, shoot me your email address at<EMAIL_ADDRESS>at i'll send you an invite.

Sorry, I should have just merged this originally instead of nitpicking.
I wanted to include these edits in the latest release of the package so I worked them in.
Thank you for figuring this out!


HBASE-21714 Deprecated isTableAvailableWithSplit method in thrift module

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
300
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
324
master passed

+1
compile
41
master passed

+1
checkstyle
39
master passed

+1
shadedjars
337
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
98
master passed

+1
javadoc
36
master passed

_ Patch Compile Tests _

+1
mvninstall
310
the patch passed

+1
compile
39
the patch passed

+1
javac
39
the patch passed

-1
checkstyle
37
hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
344
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
656
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
118
the patch passed

+1
javadoc
37
the patch passed

_ Other Tests _

+1
unit
291
hbase-thrift in the patch passed.

+1
asflicense
13
The patch does not generate ASF License warnings.

3101

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/217

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 75de4cef6954 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / e884a25f8d

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/1/artifact/out/diff-checkstyle-hbase-thrift.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/1/testReport/

Max. process+thread count
1775 (vs. ulimit of 10000)

modules
C: hbase-thrift U: hbase-thrift

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@nyl3532016 You can reuse the old PR actually. not a big problem anyway.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
249
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
267
master passed

+1
compile
34
master passed

+1
checkstyle
30
master passed

+1
shadedjars
249
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
78
master passed

+1
javadoc
28
master passed

_ Patch Compile Tests _

+1
mvninstall
244
the patch passed

+1
compile
33
the patch passed

+1
javac
33
the patch passed

-1
checkstyle
29
hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
256
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
463
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
89
the patch passed

+1
javadoc
28
the patch passed

_ Other Tests _

+1
unit
278
hbase-thrift in the patch passed.

+1
asflicense
9
The patch does not generate ASF License warnings.

2438

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/217

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 5973013fe39c 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / e884a25f8d

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/2/artifact/out/diff-checkstyle-hbase-thrift.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/2/testReport/

Max. process+thread count
1783 (vs. ulimit of 10000)

modules
C: hbase-thrift U: hbase-thrift

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/2/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
47
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
237
master passed

+1
compile
29
master passed

+1
checkstyle
28
master passed

+1
shadedjars
249
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
77
master passed

+1
javadoc
28
master passed

_ Patch Compile Tests _

+1
mvninstall
245
the patch passed

+1
compile
30
the patch passed

+1
javac
30
the patch passed

-1
checkstyle
29
hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
245
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
495
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
87
the patch passed

+1
javadoc
31
the patch passed

_ Other Tests _

+1
unit
283
hbase-thrift in the patch passed.

+1
asflicense
11
The patch does not generate ASF License warnings.

2379

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/217

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 4d3da1020c7b 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / e884a25f8d

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/3/artifact/out/diff-checkstyle-hbase-thrift.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/3/testReport/

Max. process+thread count
1778 (vs. ulimit of 10000)

modules
C: hbase-thrift U: hbase-thrift

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/3/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
39
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
242
master passed

+1
compile
33
master passed

+1
checkstyle
33
master passed

+1
shadedjars
273
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
76
master passed

+1
javadoc
29
master passed

_ Patch Compile Tests _

+1
mvninstall
234
the patch passed

+1
compile
31
the patch passed

+1
javac
31
the patch passed

-1
checkstyle
29
hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
248
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
520
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
87
the patch passed

+1
javadoc
29
the patch passed

_ Other Tests _

+1
unit
265
hbase-thrift in the patch passed.

+1
asflicense
11
The patch does not generate ASF License warnings.

2253

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/217

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 8739f86a9063 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / e884a25f8d

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/4/artifact/out/diff-checkstyle-hbase-thrift.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/4/testReport/

Max. process+thread count
1809 (vs. ulimit of 10000)

modules
C: hbase-thrift U: hbase-thrift

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/4/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
39
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
260
master passed

+1
compile
31
master passed

+1
checkstyle
34
master passed

+1
shadedjars
272
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
80
master passed

+1
javadoc
30
master passed

_ Patch Compile Tests _

+1
mvninstall
252
the patch passed

+1
compile
31
the patch passed

+1
javac
31
the patch passed

-1
checkstyle
32
hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
272
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
523
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
88
the patch passed

+1
javadoc
30
the patch passed

_ Other Tests _

+1
unit
260
hbase-thrift in the patch passed.

+1
asflicense
10
The patch does not generate ASF License warnings.

2324

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/217

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux bb0bd2583c78 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / e884a25f8d

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/5/artifact/out/diff-checkstyle-hbase-thrift.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/5/testReport/

Max. process+thread count
1925 (vs. ulimit of 10000)

modules
C: hbase-thrift U: hbase-thrift

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/5/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

this checkstyle -1 is a problem?

@nyl3532016 Yes, would be good to get this fixed before committing it. It should be an easy one.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
39
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
247
master passed

+1
compile
32
master passed

+1
checkstyle
31
master passed

+1
shadedjars
255
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
78
master passed

+1
javadoc
29
master passed

_ Patch Compile Tests _

+1
mvninstall
237
the patch passed

+1
compile
32
the patch passed

+1
javac
32
the patch passed

-1
checkstyle
32
hbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
262
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
516
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
86
the patch passed

+1
javadoc
28
the patch passed

_ Other Tests _

+1
unit
268
hbase-thrift in the patch passed.

+1
asflicense
10
The patch does not generate ASF License warnings.

2256

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/217

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 3ec125d05510 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / e884a25f8d

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/6/artifact/out/diff-checkstyle-hbase-thrift.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/6/testReport/

Max. process+thread count
1791 (vs. ulimit of 10000)

modules
C: hbase-thrift U: hbase-thrift

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/6/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
44
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
260
master passed

+1
compile
30
master passed

+1
checkstyle
32
master passed

+1
shadedjars
272
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
78
master passed

+1
javadoc
30
master passed

_ Patch Compile Tests _

+1
mvninstall
234
the patch passed

+1
compile
31
the patch passed

+1
javac
31
the patch passed

+1
checkstyle
30
the patch passed

+1
whitespace
1
The patch has no whitespace issues.

+1
shadedjars
261
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
476
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
88
the patch passed

+1
javadoc
30
the patch passed

_ Other Tests _

+1
unit
310
hbase-thrift in the patch passed.

+1
asflicense
9
The patch does not generate ASF License warnings.

2290

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/217

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 1d019037a1df 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / e884a25f8d

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/7/testReport/

Max. process+thread count
1784 (vs. ulimit of 10000)

modules
C: hbase-thrift U: hbase-thrift

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/7/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
40
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
239
master passed

+1
compile
32
master passed

+1
checkstyle
31
master passed

+1
shadedjars
252
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
78
master passed

+1
javadoc
29
master passed

_ Patch Compile Tests _

+1
mvninstall
239
the patch passed

+1
compile
32
the patch passed

+1
javac
32
the patch passed

+1
checkstyle
30
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
262
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
510
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
87
the patch passed

+1
javadoc
29
the patch passed

_ Other Tests _

+1
unit
287
hbase-thrift in the patch passed.

+1
asflicense
11
The patch does not generate ASF License warnings.

2261

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/217

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux f3901508eb13 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / e884a25f8d

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/8/testReport/

Max. process+thread count
1795 (vs. ulimit of 10000)

modules
C: hbase-thrift U: hbase-thrift

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-217/8/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.


error() breaks when exception code isn't an int

https://github.com/chriso/klein.php/blob/master/src/Klein/Klein.php#L931
throw new UnhandledException($msg, $err->getCode(), $err);

I'm not exactly the mechanism this got called, but it got called when I had a PDO Exception.  The problem is that getCode on a PDOException doesn't always return an int.  This is mentioned at https://secure.php.net/manual/en/exception.getcode.php. "Returns the exception code as integer in Exception but possibly as other type in Exception descendants (for example as string in PDOException)."
So instead of my global exception handler telling me what went wrong, I got an error about a Wrong parameters passed to the Exception constructor. Maybe just rethrow the same exception instead of wrapping it in an UnhandledException, which might other important info in the original?

@jk3us Did you have any luck resolving this? I'm experiencing the same issue.

I don't think I ever did.  After figuring out which exception was causing the problem, I fixed the error in my sql query and haven't had to deal with it since.  Sorry.


Optimization: set ODocument.setAllowChainedAccess(false) on query and traverse

By setting ODocument.setAllowChainedAccess(false) reading fields is much more efficient. This is valid on SQL select, traverse and OTraverse as well.

Shall we declare the chain access deprecated and false by default ?
this will speed up all the operation against odocument, and in long term this could be solved in a better way by the query engine.

:+1:

WDYT to set it deprecated now ad change the default behavior in 2.1? Does everything work by setting it to false?

tests fail if ran with the setting set to false by default, it need more work that can be done for 2.2

Which test fail? The tests that use the field chain?

the test failing where test related to sql, so this depends on the refactor of the sql executors.

Hi,
With the new query engine this has no meaning anymore, closing.
Regards


ClaimsProviders Document Never Says What a Claims Provider is

[Enter feedback here]
Good content provided about the structure of the ClaimsProviders section of a TrustFrameworkPolicy XML document used in defining Custom Policies for Azure AD B2C. But it never says what a Claim Provider is or why this is an important part of the schema. Author probably thought this obvious.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 50989808-7816-49b4-af9c-fb3111a7b56b
Version Independent ID: 7b1e4892-9ad2-b2c6-5b9f-e524faa2a0b1
Content: ClaimsProviders  - Azure Active Directory B2C
Content Source: articles/active-directory-b2c/claimsproviders.md
Service: active-directory
Sub-service: b2c
GitHub Login: @msmimart
Microsoft Alias: mimart

@dkeisen Thank you for your feedback . We will have this checked with the content team and update the thread.


Change '|' to a more accessible key or pattern

Hello, hope you are doing well! Thank you for the very useful plugin!
Currently, the plugin requires the user to type the key '|'.
Although this works, there is a problem:
On other keyboards - for example, on French keyboards - the key '|' is difficult to type.
As such, it may be more ideal if this key were — if possible — made customizable, or changed to a more accessible key, such as ';' or '-'.
Or — which in fact may be more ideal — if instead of a key, a pattern which is not normally entered naturally, was used, such as ':::' or '...'.
This would make the plugin more accessible, faster to use, and ultimately more ideal for all users.
Thank you for your consideration, and have a great day!

thanks to mention that,
I will make it customizable from flow ui in addition to the normal way "|" for old users who get used to it,
the customizable key will be by default ";"  until user change it.
stay tuned to v2.0.5, it will release soon
thanks again for your time to make the plugin good. 🫀

Sorry for making a late update
last few weeks I have had final exams 😅
the ability to customize the execute key is now available in v2.1.0
it will be available soon in flow (at most 24 hours)

If you have any questions or any ideas tell me
and sorry again for the late update


classes conflict when using docker-java for production code

Hi there !
First, thank you for the great work. I use testcontainers since a few months, and it's great !
I have an issue in one of my app using :

docker-java 3.2.2 for production code, with transport-zerodep
testcontainers 1.14.3 for integration testing

This kind of code raises a NoSuchMethodError when executed in an integration test :
@Bean
DockerClient client(DockerClientConfig config, DockerHttpClient transport){
    return DockerClientImpl.getInstance(config, transport);
}

Caused by: java.lang.NoSuchMethodError: com.github.dockerjava.core.DockerClientImpl.getInstance(Lcom/github/dockerjava/core/DockerClientConfig;Lcom/github/dockerjava/transport/DockerHttpClient;)Lcom/github/dockerjava/api/DockerClient;

When digging a little, I found out that test containers embeds docker-java 3.2.0, and the classes are not shaded.  So It conflicts with my production code using docker-java 3.2.2.
It seems that this getInstance method was added in docker-java 3.2.2 (others are deprecated).
As a workaround, I stick with docker-java 3.2.0, and a transport-okhttp for now, but still, this issue could help someone else :)

Hi @juwit,
First of all, thanks for upgrading to the latest version of docker-java and especially for trying the zerodep (aka Apache HttpClient5) transport! :)
There is indeed an issue when both libraries are used. The history of it is full of hard decisions, where docker-java's set of dependencies was so hard to have that we decided to re-shade it and include into Testcontainers' jar.
The good news is that we worked with the docker-java team and extracted the API module, so the next release of Testcontainers will finally stop including docker-java-api classes 🎉
Expect it (1.15.0 release) to happen soon, and I hope the workaround worked fine for now.
Actually, I think you can even use 3.2.2, but, instead of calling getInstance(config, transport), you can replace it with getInstance(config).withDockerCmdExecFactory(new OkHttpDockerCmdExecFactory()), or even zerodep + DefaultDockerCmdExecFactory. These are deprecated but fully working methods (disclaimer: I am the current maintainer of docker-java))

Hi @bsideup
Thank you for your reply.
I upgraded to docker-java 3.2.2, and used okhttp-transport with this snippet :
@Bean
DockerClient client(DockerClientConfig config){
    return DockerClientImpl.getInstance(config)
        .withDockerCmdExecFactory(new OkHttpDockerCmdExecFactory());
}

I'll wait for the testcontainers 1.15 release to switch to the zerodep transport (couldn't make it work)
You're doing great work with docker-java, I may open a few issues, or maybe contribute to it if I can find the time to do so.

@juwit thanks for your kind feedback :)
FYI I just submitted https://github.com/testcontainers/testcontainers-java/pull/2882 for that.
I will close this issue since it is a duplicate of #1113


Codesys not connecting to mqtt server

I have a Wago PFC100 and I have a mqtt server running in my local network without authentication.
I have tried the testMQTT(client:={mqttserver:1883} test function but the plc doesn't seem to connect to the mqtt server.
When I look at MQTTClient > MQTT_Control > sResultIp the value is empty.
When I look at #3 I think this value should be set. If this doesn't works it suggest a dns issue?

Hi Sander,
does you URL_DATA looks like this?

Do you realy write testMQTT(client:={mqttserver:1883} ?
should look like: testMQTT(client:='mqttserver:1883')
BR Stefan

what i wrote was: testMQTT(client:='<IP_ADDRESS>:1883');
And my url data looks like this.

And I don't see a connected client to my mqtt server.

Hi Sander,
with a static IP it have to look like:

With static IP I don't use DNS, this have to work.
You may look in ErrorHistory in HANDL_MQTT, maybe you have a problem with dynamic memory.
If this, I don't stat conecting or spliting connection string.
BR Stefan

Hi Sander,
with a static IP it have to look like:

With static IP I don't use DNS, this have to work.
You may look in ErrorHistory in HANDL_MQTT, maybe you have a problem with dynamic memory.
If this, I don't stat conecting or spliting connection string.
BR Stefan

Hi Stefan I have set a static ip in the web based management page.
This doesn't fix it.
I have looked at the error history. And you called it.

It seems to be a dynamic memory issue.
What does this mean. Is this a hardware issue or a configuration issue?

Hi Stefan I have set a static ip in the web based management page.
This doesn't fix it.
I have looked at the error history. And you called it.

It seems to be a dynamic memory issue.
What does this mean. Is this a hardware issue or a configuration issue?

Hi ,
That ist a configuration issue .
You need to increase the dynamic memory
Right click on the application

properties
Dynamic memory settings
increase maximum size of memory

How much memory do I need? Do you know?

Hi Sander,
here you see your usage of dynamic memory in bytes:

If you use more subscriptions and more instances of callback FBs this will grow.
and yes, it could be usefull to set up some setup instructions ;)
BR Stefan

this usage is in bytes or mb?
100 mb wasn't enough for the GreatExampleOfAdvantages project.
my plc only has 256 mb ram does this also limit the dynamic memory?

This is displayed in Bytes i think.
At least when i limit Dynamic memory at 20000 Bytes it run without Problems

Hi,
yes these are Bytes. I testet the GreatExampleOfAdvanteges with 20000Bytes(20kByte).
At most I setup my Raspi with 2000000 Bytes and got enough left.
@sanderobdeijn yes your physical memory limits the dynamic memory. But my lib takes only veeery few of it. I think with 1000000(1MByte) you can make almoste everythink with my lib on your plc...
100MBytes(100000000) are more then enough for this example.
BR Stefan

yeah my bad I forgot about Kbytes. I have used 153600 bytes or 150 kBytes. It has been long since I had to calculate in bytes.


Missing License File

Could you add a LICENSE file to project

https://github.com/ashwinputhige/airtable-schema-chrome-extension/blob/master/LICENSE


Public Key URL is outdated

The URL https://contoso.b2clogin.com/contoso.onmicrosoft.com/b2c_1_signupsignin1/v2.0/.well-known/openid-configuration is outdated

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b05bb7df-98fc-1342-640d-02063f6d8a11
Version Independent ID: f6ac357f-f846-83c5-f19f-91e1bc0954e3
Content: Overview of tokens - Azure Active Directory B2C
Content Source: articles/active-directory-b2c/tokens-overview.md
Service: active-directory
Sub-service: b2c
GitHub Login: @kengaderdus
Microsoft Alias: kengaderdus

@mroedder-d7
Thanks for your patience. Replace b2c_1_signupsignin1 with your own user flow. b2c_1_signupsignin1 is just an example value.
#please-close


More specific config group

As requested by NFC here (more unique than pouch):
https://github.com/runelite/plugin-hub/pull/5911#issuecomment-2109127125

Appreciate it, but I'm just gonna remove the config for now until it's needed.


Setting EAS environment variables in app.config.js

I'm using the suggested environment variable technique of setting the .extra key on my manifest, and reading from expo-constants in my app. When I try to use this technique in combination with eas.json env variables, it doesn't work because the environment variables don't seem to be available in app.config.js, so the extra keys aren't set.
I could load the eas.json myself and use process.env.EAS_BUILD_PROFILE  to load it, but then I can't have different env vars for iOS and Android since there's no EAS_BUILD_PLATFORM, so I'd have to either go with Android or iOS. Something like this:
import easBuildConfigs from './eas.json';

const easConfig = easBuildConfigs.builds.android[process.env.EAS_BUILD_PROFILE];
const ENV_VAR = easConfig?.env?.SITE_URL || process.env.ENV_VAR;

export default {
  /* ... */
  extra: {
    ENV_VAR,
  }
}

I also assume this wouldn't work with secret env vars either, though I haven't tried. I didn't see any suggested approaches for how to combine these two, so let me know if there's something better I should be doing.

I just decided to maintain my own environment variable dictionaries in app.config.js and use EAS_BUILD_PROFILE to select from that. I'll leave this issue open in case I just have this wrong, but that seems like the simplest solution.

Sth like that is already in progress, when running eas build all the values from env field in eas.json for selected profile will be loaded into environment before evaluating app.config.js. We are also considering adding env with build profile name, but I'm not sure if we decided on that yet.
For now the only approach is to duplicate those envs in local environment and in eas.json

Yeah, you also can't rely on eas.json in there because doing a regular expo publish wouldn't get the vars either, so it needs to handle both cases. Feel free to close out if y'all don't feel this problem represents an actionable issue, or if you already had something open for the work you mentioned.

Hi so just a quick one: the fix by @wkozyra95 seems to only work on Android. For iOS builds, I have to use @wbobeirne's workaround (editing the app.config.js to explicitly include content from eas.json).

@Ricool06 it will be fixed in the next release, but either way it shouldn't affect you. envs were not passed to the function that just resolved ios entitlements,  which I assume are always the same in your app. I assume it didn't work for you because you threw an error if some env was missing


My code gets stuck on a certain epoch for a long time

Hi,
When I run "bash run.sh woods cifar100 dtd dtd", my code gets stuck on a certain epoch for a long time, such as the 23rd epoch.
Sometimes the exception "Exception ignored in: <function Variable.del at 0x7f512914a200>" occurs.
Is that why? Is there something wrong with my environment? Is the pytorch version or python version wrong?
When running "bash run.sh woods cifar10 dtd dtd", it will run normally.

Sometimes it‘s ok, sometimes the program crashes.


auth: pam fallback log message and always call pam_end after pam_authenticate

Changed the log, because someone used an absolute path for general:pam_module.
Also new release maybe?
People that use 0.3.0 are quite a bit behind by now and don't have d9f644125468054d2a237adf4ae676f64c0da918.

Also new release maybe?

sure.


ENH: Change exception being raised on prep.remove

When removing a prep template that already had processed data, the
remove method would raise an exception that was not caught by the
handler. The solution was to change the QiitaDBError (which is a base
class and I think is to generic) to a QiitaDBExecutionError.
Fixes #909

Coverage remained the same at 79.07% when pulling 3f8a433c73b8489fc3c4b7760f05bab25582e2aa on ElDeveloper:issue-909 into d1ad2b536a68a0a53e0f02eea9703203a9afd62b on biocore:master.

:+1:


Development: Short Answer Number Input

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] I followed the coding and design guidelines.
[x] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[x] I implemented the changes with a good performance and prevented too many database calls.
[x] I documented the Java code using JavaDoc style.

Client

[x] I followed the coding and design guidelines and ensured that the layout is responsive.
[x] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[x] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[x] I documented the TypeScript code using JSDoc style.
[ ] I added multiple screenshots/screencasts of my UI changes.
[x] I translated all newly inserted strings into English and German.

Motivation and Context

#5459
Description

Added Spot Type Number to Short Answer Quiz Exercise
Steps for Testing

Prerequisites:

1 Instructor
1 Student
1 Course

Log in to Artemis as Instructor
Navigate to Course Management
Select the Course
Navigate to Exercises
Click + Create Quiz
Input Quiz Title
Click + Add Short-Answer Question
Input Question Title
Clear the question template
Click Add Number Spot
Input the option either in range format (e.g 0.5 - 10) or a single number (e.g 8.0)
Click Save
Log out and Log in as Student
Click Start Quiz
Input to the spot should be limited to number only
Submit

Review Progress

Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Exam Mode Test

[ ] Test

Test Coverage

Class/File
Branch
Line

Screenshots

Codecov Report
Base: 79.89% // Head: 79.89% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (10c5cf6) compared to base (23d146c).
Patch coverage: 82.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #5829   +/-   ##
==========================================
  Coverage      79.89%   79.89%
- Complexity     12371    12380    +9
==========================================
  Files           2102     2103    +1
  Lines          83674    83734   +60
  Branches       12545    12558   +13
==========================================
+ Hits           66851    66899   +48
- Misses          9344     9350    +6
- Partials        7479     7485    +6

Flag
Coverage Δ

client
75.52% <74.46%> (+<0.01%)
:arrow_up:

server
84.67% <96.42%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../java/de/tum/in/www1/artemis/config/Constants.java
100.00% <ø> (ø)

...ises/quiz/manage/quiz-exercise-detail.component.ts
80.41% <ø> (ø)

.../quiz/manage/quiz-exercise-validation.directive.ts
66.21% <ø> (ø)

...answer-question/short-answer-question.component.ts
79.51% <0.00%> (-0.97%)
:arrow_down:

...r-question/short-answer-question-edit.component.ts
85.36% <70.00%> (-0.46%)
:arrow_down:

...ebapp/app/entities/quiz/short-answer-spot.model.ts
85.71% <75.00%> (-14.29%)
:arrow_down:

.../quiz/shared/short-answer-question-util.service.ts
77.14% <80.95%> (+0.47%)
:arrow_up:

.../artemis/domain/quiz/ShortAnswerSubmittedText.java
89.18% <94.73%> (+6.58%)
:arrow_up:

...m/in/www1/artemis/domain/enumeration/SpotType.java
100.00% <100.00%> (ø)

...m/in/www1/artemis/domain/quiz/ShortAnswerSpot.java
96.87% <100.00%> (+0.72%)
:arrow_up:

... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


To share tables with multiple dbmap

I want to create a connection pool ,it has many dbmap,and eache dbmap has  a new connection. the  dbmap has the same tables. so , some dbmaps  should share they tables.but DbMap don't has  dbmap.SetTables([]*TableMap) function to support do it.
I initialize the first dbmap1 ,and create tables ( use AddTableWithName() and CreateTables()),when I creat the next dbmap2,I do not neet to create tables,and
    dbmap1 := &DbMap{Db: connect(), Dialect: dialect}
dbmap2 := &DbMap{Db: connect(), Dialect: dialect}
dbmap3 := &DbMap{Db: connect(), Dialect: dialect}

tables := new([]*TableMap)

dbmap1.SetTables(tables)
dbmap2.SetTables(tables)
dbmap3.SetTables(tables)

https://github.com/hpgood/gorp/commit/9b1aa8f7fa97931d4bb17725b5dec8fa1da454d3
https://github.com/hpgood/gorp/commit/f19396d63eadef441a537bc9546f87a9bfc39446

I'm not sure if it is smart to allow this. TableMap could (potentially) cache information that is depending on the used dialect. It isn't that bad performance-wise to re-create the TableMap three times. I've put this in milestone v2.1-maybe, so it'll come up again when we get to v2.1.


Fix date parsing/timezone issue

I'm closing this as stale. The backend and frontend have been rewritten since 2023 and 2024.


Check for banned variables in parameters

I'm not sure yet how this should look. It's only ever SingleParameter that could contain an input that should be checked, though not always. An example is the common (name, type) combo for arguments: name should be checked but type shouldn't be.
Do Parameters need to start using static initializers too?

Still positive on this idea, but out of scope for now.


Add a flag to stop rendering.

Those jump properties caused a warning message that those were not supported.


Fixes for Failing GitHub Actions

Changes

Remove bundle workflow. This has not worked in months, and the
capabilities are now implemented in the ci.yaml workflow.
Revert to using the latest operatorhub image. The catalog_sa image
was removed.

/kind cleanup
Submitter Checklist

[ ] Includes tests if functionality changed/was added
[ ] Includes docs if changes are user-facing
[x] Set a kind label on this PR
[x] Release notes block has been filled in, or marked NONE

Release Notes
NONE

/approve
Self-approving

/lgtm


webSocketServerEvent(String msg) should pass the client as well

Right now webSocketServerEvent(String msg) only passes the message.
This library would be 1000 times better if you know which client sended the message!

Hello,
There is no maintainer on our side anymore. But I can happily merge some PRs and/or transfer ownership of this repository


hide tray icon

Description of the new feature / enhancement
hide tray icon of PowerToys
Scenario when this would be used?
all time
Supporting information
No response

/dup #9526


Remove code for handling unknown types in room-chat.qtpl template

it looks to me like matrix-static should display "Cannot Understand Event" when it gets an event with a type it doesn't recognize, but instead, it just doesn't display that event.

See event sent by TravisR $15036237191020krcWp:t2l.io

It could, but it's trying to match riot-web's behaviour and doesn't

Okay. For the record, it was this from the template that made me think all events were handled. IMO, matrix-static should either just represent all events as best it can or have this code removed as the template will never see an event it doesn't understand anyway.
https://github.com/t3chguy/matrix-static/blob/8ea746526596675018cd562bdefef280d14a695c/src/github.com/t3chguy/matrix-static/templates/room-chat.qtpl#L252

Very true
Initially I didn't filter events but currently it's actually essential

Fixed by 5c796ba6cb71309810be655c2192df8cc901a5cd


fix: improve frontend

Description:

Is this change user facing?
YES/NO

References (if applicable):

added loom video @h4ck3rk3y https://www.loom.com/share/e22041c42c514af8bfb2d3ce68cc2993?sid=184037a9-4119-4b49-be31-d6b3c4d5f5e2


Cannot import nx package module using AutomationClient.Modules.CreateOrUpdate

Hi everyone,
I've been trying to import nx package using the AutomationClient namespace but it does not work, the status of this module keeps hanging on "Importing". I found that it works fine with the modules which are created by author azure-sdk.
Here is my code:
var moduleCreateOrUpdateParameters = new ModuleCreateOrUpdateParameters()
{
   Name = module.Name,
   Location = ResourceGroupInfo.Location,
   Tags = null,
   Properties = new ModuleCreateOrUpdateProperties
   {
      ContentLink = new ContentLink
      {
         Uri = new Uri(module.Url),
         Version = module.Version
      },
    },
};
var result = AutomationClient
                       .Modules
                       .CreateOrUpdate(ResourceGroupInfo.Name,
                                                  AutomationAccountName,
                                                  moduleCreateOrUpdateParameters);

Here is Az.Accounts module by azure-sdk (link which works fine with the code above:
name: Az.Accounts
url: https://www.powershellgallery.com/api/v2/package/Az.Accounts/1.5.2
version: 1.5.2

And the code does not work with nx package by MSFT_OSTC (link on Powershell Gallery):
name: "nx"
url: "https://www.powershellgallery.com/api/v2/package/nx/1.0"
version: "1.0"

Is there anything wrong with my code or Azure-SDK does not support such kind this function at this moment?
I really appreciate if any helps. thank you guys.

Hi, we took a look at the code and it seems fine. We also looked at the module you are trying to import and other people are able to successfully import it. We don't filter module uploads by author at all.
Unfortunately it seems like you need to open a support ticket so we can figure out if there's anything going on with your automation account in particular. By opening a support ticket and giving permission for us to access your data, we are able to see some backend data about your account which can help narrow down the cause. Sorry we couldn't solve the issue here!

Hi zjalexander, I wonder if the location of automation account played the role for this issue. I'll create a support ticket soon. Thank you for your support.

Just want to make a note here. I solved this issue by ignoring the version.


Cannot read property 'slice' of undefined

Exception on Heroku/Syslog drain
1676 <190>1 2021-04-18T16:14:03.967169+00:00 app web.1 - - [31m2021-04-18T16:14:03.966Z - workerId:82 - error (FROM /verify/email ): {"uuid":"JdJ9i6AnS3","message":"Something went wrong while performing request","context":["Cannot read property 'slice' of undefined",{"type":"TypeError","message":"Cannot read property 'slice' of undefined","stack":"TypeError: Cannot read property 'slice' of undefined\n    at Object.str [as keccak256] (/app/node_modules/eth-lib/lib/hash.js:317:11)\n    at keccak256 (/app/node_modules/web3-utils/dist/web3-utils.cjs.js:199:26)\n    at e.post.ie (/app/dist/server.js:1:114371)\n    at /app/dist/server.js:1:18761\n    at Layer.handle [as handle_request] (/app/node_modules/express/lib/router/layer.js:95:5)\n    at next (/app/node_modules/express/lib/router/route.js:137:13)\n    at complete (/app/node_modules/passport/lib/middleware/authenticate.js:268:13)\n    at /app/node_modules/passport/lib/middleware/authenticate.js:275:15\n    at pass (/app/node_modules/passport/lib/authenticator.js:431:14)\n    at Authenticator.transformAuthInfo (/app/node_modules/passport/lib/authenticator.js:453:5)\n    at /app/node_modules/passport/lib/middleware/authenticate.js:272:22\n    at IncomingMessage.req.login.req.logIn (/app/node_modules/passport/lib/http/request.js:55:13)\n    at JwtStrategy.strategy.success (/app/node_modules/passport/lib/middleware/authenticate.js:253:13)\n    at verified (/app/node_modules/passport-jwt/lib/strategy.js:115:41)\n    at JwtStrategy.w.Strategy [as _verify] (/app/dist/server.js:1:29056)\n    at process._tickCallback (internal/process/next_tick.js:68:7)"},]}[39m

investigating the root cause of this problem why users without email are trying to verify email


[Helm] Added CRD variables

What this PR does / why we need it:
See: #200
Makes Helm Chart Templates more general-purpose by refactoring constants.
Special notes for your reviewer:
Two areas for debate:

I went with simpler rather than more expressive for the variables. This doesn't constrain to the existing CRDs nor does it provide a mechanism to support multiple versions. But, for now, this should be sufficient.

crds:
  group: akri.sh
  version: v0

For clarity I used printf to format apiVersion but you may prefer the alternative:

{{ printf "%s/%s" .Values.crds.group .Values.crds.version }}
Rather than
{{ .Values.crds.group }}/{{ .Values.crds.version }}
If applicable:

[ ] this PR contains documentation
[ ] this PR contains unit tests
[ ] added code adheres to standard Rust formatting (cargo fmt)
[ ] code builds properly (cargo build)
[ ] code is free of common mistakes (cargo clippy)
[ ] all Akri tests succeed (cargo test)
[ ] inline documentation builds (cargo doc)
[ ] version has been updated appropriately (./version.sh)

this will require a change to version.sh as well
    YAML_FILES="$BASEDIR/deployment/helm/templates/debug-echo.yaml $BASEDIR/deployment/helm/templates/onvif.yaml $BASEDIR/deployment/helm/templates/udev.yaml $BASEDIR/deployment/helm/templates/opcua.yaml"
    YAML_VERSION_PATTERN="^apiVersion: akri.sh/"
    for YAML_FILE in $YAML_FILES
    do
        check_file_version "$YAML_FILE" "$YAML_VERSION_PATTERN" "$CRD_VERSION"
        if [ "$?" -eq "1" ]; then exit 1; fi
    done

will need to become something like (untested)
    HELM_VALUES="$BASEDIR/deployment/helm/values.yaml"
  group: akri.sh
  version: v0
    check_twoline_version "$HELM_VALUES" "group: akri.sh" "version: $CRD_VERSION"
    if [ "$?" -eq "1" ]; then exit 1; fi

and a similar change in the update section.

this will require a change to version.sh as well
    YAML_FILES="$BASEDIR/deployment/helm/templates/debug-echo.yaml $BASEDIR/deployment/helm/templates/onvif.yaml $BASEDIR/deployment/helm/templates/udev.yaml $BASEDIR/deployment/helm/templates/opcua.yaml"
    YAML_VERSION_PATTERN="^apiVersion: akri.sh/"
    for YAML_FILE in $YAML_FILES
    do
        check_file_version "$YAML_FILE" "$YAML_VERSION_PATTERN" "$CRD_VERSION"
        if [ "$?" -eq "1" ]; then exit 1; fi
    done

will need to become something like (untested)
    HELM_VALUES="$BASEDIR/deployment/helm/values.yaml"
  group: akri.sh
  version: v0
    check_twoline_version "$HELM_VALUES" "group: akri.sh" "version: $CRD_VERSION"
    if [ "$?" -eq "1" ]; then exit 1; fi

and a similar change in the update section.

The redoubtable ./version.sh .... How can I test the changes to ensure a CRD bump and without breaking things?

artificially bump version.txt to 2.0.0?
Is there a ./update.sh --dry-run equivalent?

The redoubtable ./version.sh .... How can I test the changes to ensure a CRD bump and without breaking things?

artificially bump version.txt to 2.0.0?
Is there a ./update.sh --dry-run equivalent?

The redoubtable ./version.sh .... How can I test the changes to ensure a CRD bump and without breaking things?

artificially bump version.txt to 2.0.0?
Is there a ./update.sh --dry-run equivalent?

there is no --dry-run equivalent.  good idea though.
it has been a while since i changed the script but if i remember correctly, run through and do -u -p (0.1.5 should become 0.1.6), -u -n (0.1.6 should become 0.2.0), -u -m (0.2.0 should become 1.0.0), -c -s (should work), then change version.txt and run -c -s (all checks should fail).  then when you're done testing, you should be able to set version.txt to what you want and then do -u -s.

The redoubtable ./version.sh .... How can I test the changes to ensure a CRD bump and without breaking things?

artificially bump version.txt to 2.0.0?
Is there a ./update.sh --dry-run equivalent?

there is no --dry-run equivalent.  good idea though.
it has been a while since i changed the script but if i remember correctly, run through and do -u -p (0.1.5 should become 0.1.6), -u -n (0.1.6 should become 0.2.0), -u -m (0.2.0 should become 1.0.0), -c -s (should work), then change version.txt and run -c -s (all checks should fail).  then when you're done testing, you should be able to set version.txt to what you want and then do -u -s.

@bjfelds please sanity check https://github.com/deislabs/akri/pull/205/commits/a1f94797b2dfeb1a6813a36c5773346e378f9c98 for me please.

Eye-balling (!) existing changes continue to be OK
./deployment/helm/values.yaml property crds.version is bumped by a major version change

NOTE ./version.sh -c -s terminates on first failure so it's unclear whether all checks fail or just the first. If this isn't my mistake, perhaps an update to the script to continue through all tests?

Questions:

To confirm do you want me to bump versions (patch?) with this PR too?
Is there a documented protocol for version bumping (what changes trigger version bumps)?

@bjfelds please sanity check https://github.com/deislabs/akri/pull/205/commits/a1f94797b2dfeb1a6813a36c5773346e378f9c98 for me please.

Eye-balling (!) existing changes continue to be OK
./deployment/helm/values.yaml property crds.version is bumped by a major version change

NOTE ./version.sh -c -s terminates on first failure so it's unclear whether all checks fail or just the first. If this isn't my mistake, perhaps an update to the script to continue through all tests?

Questions:

To confirm do you want me to bump versions (patch?) with this PR too?
Is there a documented protocol for version bumping (what changes trigger version bumps)?

the version.sh changes look good to my eye too ... the proof, as they say, is in the pudding though.  please do update the version with -u -p.
versioning is addressed in contributing.md ... not sure how clear or visible that is though.  feedback welcomed :)

the version.sh changes look good to my eye too ... the proof, as they say, is in the pudding though.  please do update the version with -u -p.
versioning is addressed in contributing.md ... not sure how clear or visible that is though.  feedback welcomed :)