CyberFinn: added functionality for users to view the Round-End Summar…

About the PR
I added functionality for players to view the Round-End Summary again, after closing it. Simply open the Options pane (F10) - the button will appear beneath the Quit button - after round-end.
Why / Balance
This change was made after I spotted a few complaints (and had some myself) about not being able to pull up the round-end summary after closing it. No balance changes made, it's simply a button click that displays the UI again.
Technical details
I'm simply storing the data from the round end summary, then showing the form again once the user clicks a button. Also, I hide/show the button at will. This is so that Command/others cant view "game mode = revs" during the game, as it will only appear after the end of the round.
Media
No media added

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
no breaking changes
Changelog
I added functionality for players to view the Round-End Summary again, after closing it. Simply open the Options pane (F10) - the button will appear beneath the Quit button - after round-end.
:cl:

add: Added functionality for users to see the Round-End-Summary again, after closing it. Press F10 to see the option after round-end (While in-game, between restart). The option will also appear on Lobby screen, above the OOC chat. The option will be disabled during rounds, to prevent metagamers from seeing round info.

you sir, are based. sigma even. chad if you insist. the GOAT. the MVP.

thankyouthankyouthankyouthankyouthankyouthankyouthankyou

FINALLY ohmygod

finally

Just a few other stuff

I would recommend showing a screenshot or video of the feature in action
Your build is failing tests, please check it out
Please don't use webedit, use your git client and a proper ide.

Defs agree lol, and thanks for the advice!
I've got a vid of the feature in action, here for you. (apologies that it's a bit sped up, had to keep it below 10mb for the upload)
Just wanted to note that I am running into trouble debugging locally. I cant see that OOC chat, which pops up 2min after round end, and it seems linked to that it cant find my network ID (Because I'm running on localhost), so crashes when trying to pop out. Have you ran into that before? How did you fix - or do you have any ideas I could try to fix? (I am still very new to game dev, and devving on this game/engine lol)
Also on the build-failure item, I see that it's failing on the "Build & Test Debug / build (u
https://github.com/space-wizards/space-station-14/assets/146375585/84191b58-0acc-4090-8e16-b2f18e622181
buntu-latest)", and I can see that one of the failures are:
Error Message:
Found arbitrage on FunCrateGambling cargo product! Cost is 10000 but sell is 13443.65273436904!
Expected: less than or equal to 10000
But was:  13443.65273436904d,
Which is unrelated to the changes I made?
The other failure was some null reference exception, which it got when executing some code in the RoundEndSummaryWindow, which may be a result of the changes I made after the previous review, will check it out and fix.
Thanks again for the guidance - and merry christmas!

Just a few other stuff

I would recommend showing a screenshot or video of the feature in action
Your build is failing tests, please check it out
Please don't use webedit, use your git client and a proper ide.

actually if you scroll a little more
 Error Message:
   System.NullReferenceException : Object reference not set to an instance of an object.

  1) Test was dirty-disposed.

  Stack Trace:
     at Content.Client.RoundEnd.RoundEndSummaryWindow.MakePlayerManifestTab(RoundEndPlayerInfo[] playersInfo) in /home/runner/work/space-station-14/space-station-14/Content.Client/RoundEnd/RoundEndSummaryWindow.cs:line 132
   at Content.Client.RoundEnd.RoundEndSummaryWindow..ctor(String gm, String roundEnd, TimeSpan roundTimeSpan, Int32 roundId, RoundEndPlayerInfo[] info, IEntityManager entityManager) in /home/runner/work/space-station-14/space-station-14/Content.Client/RoundEnd/RoundEndSummaryWindow.cs:line 36
   at Content.Client.GameTicking.Managers.ClientGameTicker.DisplayRoundEndSummary(RoundEndMessageEvent message) in /home/runner/work/space-station-14/space-station-14/Content.Client/GameTicking/Managers/ClientGameTicker.cs:line 176
   at Content.Client.GameTicking.Managers.ClientGameTicker.RoundEnd(RoundEndMessageEvent message) in /home/runner/work/space-station-14/space-station-14/Content.Client/GameTicking/Managers/ClientGameTicker.cs:line 167
   at Robust.Shared.GameObjects.EntityEventBus.ProcessSingleEventCore(EventSource source, Unit& unitRef, EventData subs) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Shared/GameObjects/EntityEventBus.Broadcast.cs:line 332
   at Robust.Client.GameObjects.ClientEntityManager.DispatchReceivedNetworkMsg(MsgEntity message) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Client/GameObjects/ClientEntityManager.cs:line 203
   at Robust.Client.GameObjects.ClientEntityManager.TickUpdate(Single frameTime, Boolean noPredictions, Histogram histogram) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Client/GameObjects/ClientEntityManager.cs:line 148
   at Robust.Client.GameStates.ClientGameStateManager.ApplyGameState() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Client/GameStates/ClientGameStateManager.cs:line 282
   at Robust.Client.GameController.Tick(FrameEventArgs frameEventArgs) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.Client/GameController/GameController.cs:line 535
   at Robust.UnitTesting.RobustIntegrationTest.IntegrationGameLoop.SingleThreadRunUntilEmpty() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 1001
   at Robust.UnitTesting.RobustIntegrationTest.IntegrationGameLoop.Run() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 988
   at Robust.UnitTesting.RobustIntegrationTest.ClientIntegrationInstance.ThreadMain() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 812
--- End of stack trace from previous location ---
   at Robust.UnitTesting.RobustIntegrationTest.IntegrationInstance.WaitIdleImplAsync(Boolean throwOnUnhandled, CancellationToken cancellationToken) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 437
   at Robust.UnitTesting.RobustIntegrationTest.IntegrationInstance.WaitRunTicks(Int32 ticks) in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/RobustIntegrationTest.cs:line 529
   at Content.IntegrationTests.Pair.TestPair.RunTicksSync(Int32 ticks) in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Pair/TestPair.Timing.cs:line 18
   at Content.IntegrationTests.Tests.RoundEndTest.<>c__DisplayClass0_0.<<Test>g__WaitForEvent|6>d.MoveNext() in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Tests/RoundEndTest.cs:line 124
--- End of stack trace from previous location ---
   at Content.IntegrationTests.Tests.RoundEndTest.Test() in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Tests/RoundEndTest.cs:line 106
   at Content.IntegrationTests.Tests.RoundEndTest.Test() in /home/runner/work/space-station-14/space-station-14/Content.IntegrationTests/Tests/RoundEndTest.cs:line 141
   at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter`1.BlockUntilCompleted()
   at NUnit.Framework.Internal.MessagePumpStrategy.NoMessagePumpStrategy.WaitForCompletion(AwaitAdapter awaiter)
   at NUnit.Framework.Internal.AsyncToSyncAdapter.Await(Func`1 invoke)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.RunTestMethod(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context)
   at NUnit.Framework.Internal.Execution.SimpleWorkItem.<>c__DisplayClass4_0.<PerformWork>b__0()
   at NUnit.Framework.Internal.ContextUtils.<>c__DisplayClass1_0`1.<DoIsolated>b__0(Object _)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at NUnit.Framework.Internal.ContextUtils.DoIsolated(ContextCallback callback, Object state)
   at NUnit.Framework.Internal.ContextUtils.DoIsolated[T](Func`1 func)
   at NUnit.Framework.Internal.Execution.SimpleWorkItem.PerformWork()

I believe RoundEndSummaryWindow would be something you modified

actually if you scroll a little more

I believe this would be something you modified

sorry I'm so blind lol - I'm still reading through this and checking, but it could be that the build is running into the same issue I had here:

it was crashing for me when I wasnt connected to my Steam account, because this specific line (Line 132) couldnt determine my network ID,
Think it's the same issue?
Will keep checking, but thanks again for the help and guidance!

Just made an update - I forgot to add the option to the OOC chat, so fixed that.
Here are some vids showing the features in action:
https://github.com/space-wizards/space-station-14/assets/146375585/d0ea4ab2-2710-490c-9f51-27d5a22017d5
https://github.com/space-wizards/space-station-14/assets/146375585/f7f803bb-5492-4fae-bb4a-3e0e5f212d66

idk why all the checks are failing on:

Fetched in submodule path 'RobustToolbox', but it did not contain f797bf4d7d3aa0360ea9ee30ed1ceba2b889a81a. Direct fetching of that commit failed.

I resolved all previous merge conflicts and got the branch 100% up to date with SS14 origin, it's literally the same, except the changes I added (which are awaiting approval),
I'm totally stumped on how to resolve lol - Someone help please :')

idk why all the checks are failing on:
* Fetched in submodule path 'RobustToolbox', but it did not contain f797bf4d7d3aa0360ea9ee30ed1ceba2b889a81a. Direct fetching of that commit failed.

I resolved all previous merge conflicts and got the branch 100% up to date with SS14 origin, it's literally the same, except the changes I added (which are awaiting approval), I'm totally stumped on how to resolve lol - Someone help please :')

you made robust toolbox changes, revert your changes there

you made robust toolbox (engine) changes, revert your changes there
If you need them then please make a seperate engine pr

So this is whats confusing me, I didnt make any changes to the RobustToolBox,
and merged the latest version (from SS14) into my project - because there was previously a merge conflict on it.
After merging it into my project, there's no longer merge conflicts, so it should be the most updated version that everyone else has - but it's failing for some reason.
I'm so confused :')

ah I see the issue now, so weird.. I dont have RobustToolBox linked in the project for some reason now?
Gonna try to resolve, unsure how this even happened

ok RobustToolBox issue seems to be resolved now, also only 1 check failing [Build & Test Debug / build (ubuntu-latest)]
Failed 1, passed 311 tests,
Failing on:

Any advice on how I should resolve - if needed?
_escapeWindow is static in this context, so unsure if that's what's causing the issue (Causing _escapeWindow to NOT be null at this point at runtime - which causes the Debug.Assert to throw exception, and test to fail)

btw can you can test locally with dotnet test -e COMPlus_gcServer=1

btw can you can test locally with dotnet test -e COMPlus_gcServer=1

Thanks for this lol, I've just started running the SS14 test packages within VS 2022,
But it's been a bit of a hit & miss,
Not getting the same errors consistently - it's either one or the other, or both.
the 2 errors are the "Debug.Assert" one from earlier,
and the other is the "null ref exception" when it tries to access the player's network ID.
I ran a test on the second error ("null ref" one), and saw this:

So I'm convinced it's failing because it can't determine the player ID of the agent running the tests (I also made no changes to this section of code - other than the try/catch surrounding it, so it should be 100% identical to the rest of prod)
Unsure what's causing our "Debug.Assert" issue though, will keep checking, but VS is being unfriendly towards me lately :')
Thanks again for all the help! :D

so this is frustrating me quite a bit,
it seems that someone has dropped some files/modules off the robustToolBox, and now, when I try to pull the latest changes from it into my project, it drops those and causes the "No submodule update checker / Submodule update in pr found (pull_request)" check to fail.
Just tested with the prod code (no changes made) and it happened again.

no longer have time to monitor and maintain my change until it gets approved

so this is frustrating me quite a bit, it seems that someone has dropped some files/modules off the robustToolBox, and now, when I try to pull the latest changes from it into my project, it drops those and causes the "No submodule update checker / Submodule update in pr found (pull_request)" check to fail.
Just tested with the prod code (no changes made) and it happened again.

This is one of the reasons why it's highly recommended to leave your local master exactly the same as upstream's and do your changes in a branch. We manually bump the RobustToolbox submodule pretty often and don't allow PRs to change it for obvious reasons, there are a lot of ways your submodule can get out of sync and into the changes so i can't exactly tell what happened in your case, but if you had worked in a different branch and left master the same all you've have to do to get rid of RT's changes and merge upstream master is this:
git switch master # Switch to your local master

git pull upstream master # Get the changes from upstream, this step requires having the upstream configured in your git tho

git switch YourBranch # Switch to your changes

git merge master # Merge upstream changes (may make your RobustToolbox get out of sync and appear as changed in some edge cases)

git checkout master RobustToolbox # Sync the submodule with upstream, do note that if you've already commited the submodule before, this would fix it too

git commit -a -m "New commit" # Commit all new changes

git push # Push, may require a forceful push if you really messed up

so this is frustrating me quite a bit, it seems that someone has dropped some files/modules off the robustToolBox, and now, when I try to pull the latest changes from it into my project, it drops those and causes the "No submodule update checker / Submodule update in pr found (pull_request)" check to fail.
Just tested with the prod code (no changes made) and it happened again.

This is one of the reasons why it's highly recommended to leave your local master exactly the same as upstream's and do your changes in a branch. We manually bump the RobustToolbox submodule pretty often and don't allow PRs to change it for obvious reasons, there are a lot of ways your submodule can get out of sync and into the changes so i can't exactly tell what happened in your case, but if you had worked in a different branch and left master the same all you've have to do to get rid of RT's changes and merge upstream master is this:
git switch master # Switch to your local master

git pull upstream master # Get the changes from upstream, this step requires having the upstream configured in your git tho

git switch YourBranch # Switch to your changes

git merge master # Merge upstream changes (may make your RobustToolbox get out of sync and appear as changed in some edge cases)

git checkout master RobustToolbox # Sync the submodule with upstream, do note that if you've already commited the submodule before, this would fix it too

git commit -a -m "New commit" # Commit all new changes

git push # Push, may require a forceful push if you really messed up

thanks so much for this man! Gonna try to resolve.
I got so deterred because nothing was working lol. Gonna try again tho - thanks again!


[WIP] Multi-weight support porting

Fixes #4679

[x] Ports all models from prototype to main area and adds documentation to the builders
[ ] Updates the examples and tutorials
[ ] Updates the test_models.py to use weights and move the test_prototype_models.py tests
[ ] Updates the reference scripts and me _presets.* private

The commit 5a96c9a completes the porting. As we see, all the tests pass while using the BC compatibility layer of the solution. Aka all tests, documentation etc use of pretrained instead of weights.

@NicolasHug @jdsgomes Thank you both for your heroic reviews and support on this work. I'm running few last checks on the references and if all pass, I'll merge the PR soon.
I really hope that going forwards we will find better ways to land prototype APIs into main without such massive PRs.

Vamos!! Multi Weight support.
( I really wish if GitHub has GIF search like Giphy lol)


readyState handler can fire too early in Internet Explorer

Same deal as jquery/jquery#901 (“sometimes IE10 and lower have document.readyState == "interactive" way too early”).

Closing this as I'm merging #220. I'll create another issue to backport this to 0.13.x.


Wrong download format

Describe the bug
When set the format for download to mp4 the downloaded format is webm
To Reproduce
Steps to reproduce the behavior:

Select webm
Record your screen
download it

Expected behavior
should be mp4 file extension
Desktop (please complete the following information):

OS: Windows
Browser: Firefox

I think it's not a bug it's the feature.


home does not compile on wasm

Problem
The home crate does not build for wasm32-unknown-unknown. I encountered this through a transitive dependency from another crate.
Steps
$ cargo new bugreport
$ cd bugreport
$ echo 'home = "0.5"' >> Cargo.toml
$ cargo build --target wasm32-unknown-unknown

results in error:
error[E0425]: cannot find function `home_dir_inner` in the crate root
  --> .cargo/registry/src/index.crates.io-6f17d22bba15001f/home-0.5.5/src/env.rs:33:16
   |
33 |         crate::home_dir_inner()
   |                ^^^^^^^^^^^^^^ not found in the crate root

Possible Solution(s)
Home has no obvious place in wasm, so I suggest adding the following (and I'm happy to add this myself, along with CI test on wasm target)
#[cfg(target_arch = "wasm32")]
fn home_dir_inner() -> Option<PathBuf> {
    None
}

Notes
No response
Version
No response

You're absolute correct. home doesn't mean to be used on wasm target at this time. I wonder if the crate should also specify home as a target platform dependency.
Some related issues about what the return value should be:

https://github.com/brson/home/pull/26
https://github.com/WebAssembly/wasi-filesystem/issues/59

Could you also share the crate depending on home here so that we can have more data points to think about it?
BTW, a semi-related feature requests:

https://github.com/rust-lang/cargo/issues/6179

triage: @rustbot label -S-triage +S-needs-design +O-wasm

I encountered this in polars which moved from dirs to home in a recent release (dirs::home_dir returns None):

https://github.com/pola-rs/polars/issues/8783

I am pretty into this suggestion, similar to what you've proposed.

My suggestion would be to have home_dir return None, for now. That way, we don't need to block you here, and an implementation can be added later if we figure out what it should do.

std::env::home_dir also returns a None on unsupported platforms despite its deprecation.
I want to expand the proposal to align with things mentioned above — returns None on currently unsupported platforms. Simply starting from this:
/// Returns `None` on unsupported platforms.
///
/// We can figure out the implementation of each platform when needed.
#[cfg(not(any(unix, target_os = "redox", windows)))]
fn home_dir_inner() -> Option<PathBuf> {
    None
}

Let's do a quick poll.
@rfcbot fcp merge

@rfcbot concern support
What is our overall plan/strategy for home?
Polars is a dataframe library and switch to home in pola-rs/polars#8449 because

smaller
cargo-team maintained

As a general home crate, cargo_home doesn't fit.  Supporting wasm builds would also make sense.
As a crate meant for cargo and rustup, it has a very generalized name and seems people would be reading more into it being "cargo-team maintained" than we might want.  In this case, supporting wasm builds miscommunicates the intended support.
So which is this intended to be and can we document it?

My take is that home is primarily for rustup and cargo. I checked my box on this change because it is a relatively small change with what I think is little impact. But I think I would be against larger changes unless they are specifically to support cargo and rustup. So my perspective is to provide support on an as-available basis (like very small changes), but otherwise not accept larger changes.
We should have tagged @LucioFranco, since they said they would help with maintaining it. That's not a process we have handled too well.

Adding more context: When we originally moved home to the cargo repo, it was because it is primarily used by cargo and rustup, and it needed a place to live. @LucioFranco indicated they would also help with maintenance, though our expectations were that it should need very little maintenance for cargo/rustup's use cases. I think it might be the wrong takeaway for people to think it is now "cargo team blessed", and that it is a good fit for general-purpose use. We should decide on what exactly that means, but I would like to give @LucioFranco some time to respond if they are still available as a maintainer. Otherwise, we may need to better communicate the status and purpose of the crate.

For me, I'm not against general improvements but more so if we clarify the intended "blessed"-ness of this rate to Polars, would they move away from it and the request for wasm support would go away?

Not a blocker but something else for us to keep in mind is that to support wasm means we need to at least verify we build in wasm which means we would need another CI job running.    This likely wouldn't "break the bank" on our CI times but we should be mindful of it.

support wasm means we need to at least verify we build in wasm which means we would need another CI job running

This is a good point! Now I am more convinced that we shouldn't support any further use case unless the original maintainer or someone stands out and commits to it.

…but I would like to give @LucioFranco some time to respond if they are still available as a maintainer.
…So which is this intended to be and can we document it?

My 2 cents before Lucio puts their words here:
`home` is merely for rustup and cargo's use cases. You are suggested to use a
more general package on crates.io for other scenarios. `home` always returns
`None` for unsupported platforms, which might be unexpected.

Sorry I was taking a break for a while and this issue then escaped me. I think adding support for wasm doesn't make much sense anyways since its not a nix or windows platform. In addition, I don't think any of us have the bandwidth to figure that out at the moment.

Hey Lucio. Glad you're coming back! And thanks for having a look at this.
By not supporting wasm and other platforms, do you prefer always returning a None, or compile failure? I am okay with either way.

@LucioFranco Just checking in again if you think you'll have time to help with this issue or the maintenance of home in general. Weihang indicated you have been busy with things lately, so I understand. Just to relay that the cargo team doesn't want to take on the maintenance of home as a general-purpose crate for the community, so we would like to avoid getting pulled into spending time on issues like these. If you don't think you will have time for the foreseeable future, we are thinking of documenting that home is not intended for anything but use inside of cargo and rustup, and suggest people use some other crate instead.
Also note that in https://github.com/rust-lang/rust/issues/71684 there seems to be some interest in providing a new solution in std, which might be an option for some if someone wants to try to help there.

@ehuss Hi! I currently don't have time for home so I think the idea of keeping home a crate of internal use is a good idea. Thanks for the reach out!

Is this something I could help out with? At this point the home crate has 370 dependents on crates.io and 60k downloads per day on weekdays, so it feels like it is a de facto standard whether the Cargo team likes it or not, and not doing the (presumably limited amount of) maintenance necessary to make this a broadly acceptable solution feels like a waste.

Yup, I'll see if I can squeeze out an ACP.

@djc please tag me on it when you do and feel free to pull me in if you want help with any part of it!

I'm going to cancel the FCP here since I don't think it is likely to move forward.
@rfcbot cancel
The team would like to see someone open an ACP as mentioned above in https://github.com/rust-lang/cargo/issues/12297#issuecomment-1707097192. @joshtriplett (who is also on the libs team) has also indicated they would like to see that route move forward.

FYI https://github.com/rust-lang/libs-team/issues/372


Add list of code pattern that are hostile to modules

https://www.reddit.com/r/cpp/comments/1cdtabj/comment/l1hbkxk/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button

STL commented:

Named modules can't emit macros, so either they need to be replaced with real language tech (e.g. INT_MIN => numeric_limits::min()) or a companion macro-only header needs to be provided.


Legal section / DMCA link

As per https://github.com/ipfs/website/pull/80#discussion_r46239252, This adds a legal section, with a link to the DMCA form.

LGTM

I don't have permissions to merge, so someone needs to merge me or give me access to merging.

LGTM, one comment to add above.

This sort of stuff needs a LGTM from me before merging anyway :)
On Sat, Jan 16, 2016 at 17:00 Kyle Drake<EMAIL_ADDRESS>wrote:

I don't have permissions to merge, so someone needs to merge me or give me
access to merging.
—
Reply to this email directly or view it on GitHub
https://github.com/ipfs/website/pull/90#issuecomment-172261362.

@kyledrake can you post in the PR again when you update them? pushing commits does not notify anyone.
great, this LGTM. merging. will get published soon


use defineProperty for attributes getter setters

Add some option to map.define plugin that will define property on the map object using defineProperty https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/defineProperty
API variant:
define:{
   fullName: {
      get: function(){..},
      property: true
      //defineProperty: true // as alternative
   }
}

Are you looking to support direct property access?
Instead of this, I've been thinking about a can.define that would let you to add behavior directly to prototypes like:
MyConstructor = function(...){...}
can.define(MyConstructor.prototype,{
  first: "string",
  last: "string",
  fullName: {
    get: function(){ return this.first + " " + this.last }
  }
});
can.event(MyConstructor.prototype)

thing = new MyConstructor()
thing.first = "Alex"
thing.last = "Osh"

thing.fullName // "Alex Osh"

thing.bind("fullName", function(ev, newVal, oldVal){ ... })

thing.last = "Oshkosh"

can.define is fine, maybe map/define plugin could use it ternally to allow usage of its API.

@whitecolor '*' would not work.  With only getter / setters, we would need to know every property ahead of time for computes to work.
Proxies would allow any property to work. Here's a prototype: https://github.com/canjs/can-observe.  Please join me in convincing Chrome to add them: https://twitter.com/mraleph/status/640144111627030528.
If you are interested in making something like this work, I can add you to the can-observe project.

Closing because this work should be done in can-observe.


Server not being blacklisted on timeout

My hypothesis is that the unicorn (or something upstream) has a timeout shorter than the timeout being used by the db gem (mysql2).
I'm investigating what these settings do and what happens when I set them and if makara handles it appropriately.
production:
  connect_timeout: 1
  read_timeout: 1
  write_timeout: 1
  checkout_timeout: 1

@sax @Drakula2k does the postgres AR gem have similar settings?

We've run into issues with postgres connections, but have solved them by using PGBouncer as a proxy, and issue a "DISCARD ALL" as the server_reset_query to ensure that state does not persist between killed connections.

Postgres adapter works on top of libpq, which offers only one timeout parameter: connect_timeout. http://www.postgresql.org/docs/9.4/interactive/libpq-connect.html#LIBPQ-CONNSTRING
It's related only to connections initialization, so adapter is causing long timeouts when connected server goes down/unreachable. There's also keepalive parameters on libpq (and some kind of built-in timeout as long as it's raising an exception eventually), but I didn't come to a good solution yet.

Came up with this. https://github.com/taskrabbit/makara/pull/104

@Drakula2k see what I did. Maybe there's just some message to check for in postgres that goes over the built-in timeout. I spent forever trying to figure out how to write a test that simulated network disconnect but eventually realized a SLEEP call would also work :-)
Might be wroth trying on the postgres side to get the message right.

merged the mysql2 version to handle timeout. anyone want to look at others or should i close?

@bleonard The problem with postgres is not about catching the exception. I need to make timeout time configurable (there is no read_timeout/write_timeout variables for postgres adapter). Currently it's about 60 sec which is unacceptable.

i'd very nervous to adding timeout code at the makara layer. I'd rather handle responses from the lower level library. Rubys timeout library is not so reliable.

I agree. It is easy to accidentally kill timeout threads in a way that is not thread safe, at which point your db adapter is corrupted and unable to handle any new connections. libpq is only thread safe so long as clients are thread safe.
Sent from my iPhone

On Jan 8, 2016, at 3:40 PM, Brian Leonard<EMAIL_ADDRESS>wrote:
i'd very nervous to adding timeout code at the makara layer. I'd rather handle responses from the lower level library. Rubys timeout library is not so reliable.
—
Reply to this email directly or view it on GitHub.

I didn't mean adding a Ruby timeout, I'm planning to fix it inside postgres adapter's native extension.

Yeah, I know @Drakula2k - just thinking about a more global option and then throwing it out right away for anyone interested.

feel free to make another issue for python. going to close this out because we're handling mysql better.


Add documentation about streaming audio from http links

There has been an issue causing playing remote urls that are HTTP not to work and after some research, I found out that this is specific to Android only and can be fixed by adding android:usesCleartextTraffic="true" in the AndroidManifest.xml file. I figured this info should be included in the docs since there are multiple folks who ran into it as well.
This PR should close out these issues: #375, #369, possibly #181, and #383

my problem not solved
audioplayer log shows:
_platformCallHandler call audio.onComplete {value: true, playerId: 218462da-d4b7-4e71-8e5c-4e33f8799859}

LGTM


Can't run Model Builder properly because Cuda can't detect Visual Studio

Using

Visual Studio 2019
Model Builder <IP_ADDRESS>1102

additional error
gpu training failed please check that your gpu is configured properly

You can continue without the cuda extension in VS. It's unrelated to Model Builder's GPU driver needs.

apparently it doesn't work without the proper cuda
or there is an issue with my nvidia because i'm unable to access the control panel
other issue that i encountered
https://github.com/dotnet/machinelearning-modelbuilder/issues/906
Thanks to this info its solved now
https://github.com/dotnet/machinelearning-modelbuilder/issues/887
i had to install ML.Net Model Builder GPU Support along with ML.Net Model Builder.
to verify if its using the GPU is to look if gpu is 100% Memory usage


illegal_argument_exception: [routing] is missing for join field [joinField]

ElasticDump version: 3.3.19
Elasticsearch version: 6.3.0
Node.js version (note that nodejs v8+ is required for this tool): v9.11.2
Full command you are having issue with (with inputs and outputs)

Exporting to file (works):
#!/usr/bin/env bash
elasticdump \
  --input=http://<IP_ADDRESS>:9200/index \
  --output=/data/index-mapping.json \
  --type=mapping

elasticdump \
  --input=http://<IP_ADDRESS>:9200/index \
  --output=/data/index-analyzer.json \
  --type=analyzer

elasticdump \
  --input=http://<IP_ADDRESS>:9200/index \
  --output=/data/index-data.json \
  --type=data

importing from file on another server (doesn't work)
#!/usr/bin/env bash
elasticdump \
  --input=index-analyzer.json \
  --output=http://<IP_ADDRESS>:9200/index \
  --type=analyzer

elasticdump \
  --input=index-mapping.json \
  --output=http://<IP_ADDRESS>:9200/index \
  --type=mapping

elasticdump \
  --input=index-data.json \
  --output=http://<IP_ADDRESS>:9200/index \
  --type=data

It fails with:
{ _index: 'index',
  _type: 'doc',
  _id: 'article-112437',
  status: 400,
  error:
   { type: 'mapper_parsing_exception',
     reason: 'failed to parse',
     caused_by:
      { type: 'illegal_argument_exception',
        reason: '[routing] is missing for join field [joinField]' } } }

Currently working on a simple data set to reproduce.

Are you using the same elasticsearch version for both servers ?

Can you provide the dataset? That’ll help tremendously

Currently on vacation, will work on a very simple dataset to reproduce when I'm back at the end of the coming week. Thanks you in advance for looking into it!

Closing this issue due to lack of activity.

@paolociccarese Can you provide a simple dataset to reproduce the issue? Still haven't managed to do this yet.

I can confirm the issue for the following versions:
~# elasticdump --version
4.1.1

~# curl localhost:9200
{
  "name" : "S74eeM1",
  "cluster_name" : "docker-cluster",
  "cluster_uuid" : "WlNA_Dn-Roy8dKNwW0GXlg",
  "version" : {
    "number" : "6.4.2",
    "build_flavor" : "default",
    "build_type" : "tar",
    "build_hash" : "04711c2",
    "build_date" : "2018-09-26T13:34:09.098244Z",
    "build_snapshot" : false,
    "lucene_version" : "7.4.0",
    "minimum_wire_compatibility_version" : "5.6.0",
    "minimum_index_compatibility_version" : "5.0.0"
  },
  "tagline" : "You Know, for Search"
}

The dataset that causes this is around 30GB, so still working on providing a simple dataset to reproduce.

 With a slight modification the import succeeds (with missing data of course), perhaps this helps finding the problem:
https://gist.githubusercontent.com/tholu/5ea72ada3f8b75712a04e1c5b6dfaa09/raw/34df39f386e60233e4c467f6cfc7f25a2b946602/items_201811120743_058746a5-data-sample.json
@ferronrsmith Can you reopen the issue? Thanks!

The issue you're having is because you're trying to use a meta-field
{"fields":{"related":["385920"]}}

without specifying the parseExtraFields flag.

@ferronrsmith Sorry to bother you again! The exception is gone, but the document is not imported:
Modified import:
elasticdump \
  --input=${INDEX}-data-sample-broken.json \
  --output=http://<IP_ADDRESS>:9200/${INDEX} \
  --type=data \
  --parseExtraFields related

Result:
Fri, 14 Dec 2018 11:02:21 GMT | starting dump
Fri, 14 Dec 2018 11:02:21 GMT | got 1 objects from source file (offset: 0)
Fri, 14 Dec 2018 11:02:21 GMT | sent 1 objects to destination elasticsearch, wrote 0
Fri, 14 Dec 2018 11:02:21 GMT | got 0 objects from source file (offset: 1)
Fri, 14 Dec 2018 11:02:21 GMT | Total Writes: 0
Fri, 14 Dec 2018 11:02:21 GMT | dump complete

sent 1 objects to destination elasticsearch, wrote 0

One of the libs might not be reporting the errors correctly.
{"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"Malformed action/metadata line [1], expected a simple value for field [related] but found [START_ARRAY]"}],"type":"illegal_argument_exception","reason":"Malformed action/metadata line [1], expected a simple value for field [related] but found [START_ARRAY]"},"status":400}

So what can I do here? Is this an issue in elasticdump? Or what am I actually doing wrong? Am I dumping the data wrong?

Error is from elasticsearch and it's clear. It expected a simple value and found an array. Read the docs : https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-field-names-field.html
i.e ES has no dedicated array type

I think that the problem is in the initial dump procedure. @tholu has the mapping defined as
...

"related":{"type":"keyword","store":true,"similarity":"boolean"}

...

Which causes that in the dump the content of _source.related (stored field) is also exported under "fields":{"related":["385920"]}. But this is not a meta-field, just regular field with "store":true configured.
Then the import procedure tries to put the content of this stored field into meta fields and fails, from reasons @ferronrsmith mentions. But the original cause is, that stored fields are exported together with meta fields and the import doesn't distinguish these.


[Ledger] Add Aleph Zero network

Is your feature request related to a problem? Please describe.
Add Aleph Zero network

S2kael
Please see the link below to our dedicated support line:
Support :( https://discord.com/invite/dBvqrrgP )

At the moment, support transfer AZERO token only

Version test: https://file.cdmteck.com/s/4oimk9zDJ8R5Aai/download?path=%2F&files=./upgrade-ui-pr-1566-build-1.0.11-2023-06-27T10-34-45UTC.zip
Validation passed for cases:

Connect account

Show balance

Send fund with native token: https://alephzero.subscan.io/extrinsic/0x82f3998737d86bf0ceaae286117305ddd12729348dd7dafb898838a289b9d32d

Send fund with PSP token, Staking, Send NFT

Connect and approve request from dApp


faster Neus

Hey, Thanks for your work !
I asked the same in the SyncDreamer repo,
Are you planning to add faster neus implementations ? like neus2 or something else ?

Hi, thank you for the intriguing suggestion!!
I also think "faster NeuS (e.g., NeuS2)" would be helpful for other future studies.
I'll work on this after I get back from holiday.

Ok thanks.
Maybe I can also look at it in the next couple of days maybe I can help.
Happy new year.


Faster requeueing when exponentially backoffed shoot shall be deleted

How to categorize this issue?

/area usability
/kind enhancement
/priority normal
What would you like to be added:
When a shoot that fails to be created or reconciled for a long time then it is exponentially backoffed. When it is later deleted by the user, then it might still take the full backoff time (~16m) until the deletion flow starts (because we only use one queue and only differentiate which flow to start when we pick it up).
The same applies for other operation types like migration and restoration.
Let's enhance our event handlers in the shoot controller and enqueue shoots faster when the operation type changes.
/cc @timebertt @vlerenc @dguendisch
Why is this needed:
Faster reaction time of Gardener, improved user experience

/assign


Display a date in a format and send in another format?

Is there a way to display a date with a format 'dd-mm-yyyy' and send a date with 'yyyy-mm-dd' when the form is submitted?

dup #1168


Problem with mapping of Credit Line

For Object 34753...
I expected to see:
Museum purchase with funds provided by the Eddie and Sylvia Brown Challenge Grant, matching funds, and the estate of Anna Fehl, for the acquisition of African American Art, 2004
but instead I saw:
Nothing/Blank
The current query was:
PREFIX owl: <http://www.w3.org/2002/07/owl#>
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX crm: <http://www.cidoc-crm.org/cidoc-crm/>
PREFIX skos: <http://www.w3.org/2004/02/skos/core#>
PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>
PREFIX foaf: <http://xmlns.com/foaf/0.1/>
PREFIX dct: <http://purl.org/dc/terms/>
PREFIX dc: <http://purl.org/dc/elements/1.1/>
PREFIX schema: <http://schema.org/>

SELECT ?credit_line ?credit_line_class
WHERE {
{
  <http://data.thewalters.org/object/34753> a crm:E22_Man-Made_Object ;
    crm:P67i_is_referred_to_by ?credit_line_class .
  ?credit_line_class a crm:E33_Linguistic_Object;
    crm:P2_has_type <http://vocab.getty.edu/aat/300026687> ;
    rdf:value ?credit_line .
}

}

Yup, this is a valid issue.  The mapping has ttp://vocab.getty.edu/aat/300026687, which is missing the "h" in http.


ANSI vs ISO

Hello!
I noticed that for the Pulse 15 the US ANSI layout and US ISO layout are exactly the same, while in the Keyboards & Layout page on the company's website they are different.
ANSI
This is the ANSI keyboard in the repo:

And this is the one from the Tuxedo website:

As you can see the enter keys are different, and the layout in this repo is incorrect.
ISO
This is the ISO keyboard in the repo:

And this is the one from the Tuxedo website:

Please have a closer look:

I'm referring to the shape of the enter key, in this repo the enter key is "vertical", in the tuxedo website the enter key is "horizontal".

Yes, that's why the layer is labelled "JUST FOR ORIENTATION". You can see that by opening the file in Inkscape.
Long story short: submitting a custom layout based on this file you will get a proper ANSI layout.


volume contest query

A query for getting

a volume for specific weeks (weeks are caluclated dynamically based on the date input)
a sum of volume for all generated weeks

Input data:

user address
start date

Example:
Date input: 2023-08-06
week1:

start_dt=datetime.datetime(2023, 8, 6, 0, 0, tzinfo=datetime.timezone.utc),
end_dt=datetime.datetime(2023, 8, 12, 23, 59, 59, 999000, tzinfo=datetime.timezone.utc)

week2:

start_dt=datetime.datetime(2023, 8, 13, 0, 0, tzinfo=datetime.timezone.utc)
end_dt=datetime.datetime(2023, 8, 19, 23, 59, 59, 999000, tzinfo=datetime.timezone.utc)

Query example:
{
  volumeContest(
    where: {user: "0x4c9f34a10b433316f3c7f70ceea1c16d8a6c3060e3d0a4787a79adbc754b050", startDate: "2023-05-01"}
  ) {
    user {
      id
    }
    weeks {
      id
      name
      startDt
      endDt
      score
      volume
    }
    totalContestScore
    totalContestVolume
  }
}


LANL 10/16 predictions

LANL Theoretical Biology and Biophysics group predictions using CovTransformer (a transformer model for covid variant predictions) for 10/16 are included in this merge request.
We encountered an issue with "NA" not being correctly recognized as NA when performing parquet validation. Please email me if this is an issue on the back-end.
We have clipped our NA/NaN/Null predictions into 0, to comply with the normalization requirement that frequencies must sum to 1.

The views expressed here are those of the authors and does not necessarily represent the official views of the National Institutes of Health, Los Alamos National Laboratory, or the US Government."

Hi @MKupperman , thanks for the submission! We will need to investigate this validation error, as it may be a bug on our end.  A few of us have been traveling this week, hence our delay in getting to look at your submission.
I did some diagnostics on your file, and here is what I see:

your file contains only mean output type (this should pass validation)
all of the values in the "output_type_id" column are "NA" (this should also pass validation, as this is the correct thing to do if the output type is mean)

When I read the file into R, it is seeing the output_type_id column as character and is seeing "NA" as the string "NA" rather than the special NA value. I think this is causing the validations to throw an error erroneously. We will check into this and try to fix it ASAP.
Tagging @zkamvar and @annakrystalli as our validation gurus for support here.

Hello @MKupperman !
I had a look and it is in fact a valid error. It seems your NAs have been encoded as "NA" character strings and not NA values (i.e. missing values)
If you convert your output_type_id values to NAs the check passes. See below:
repo_url <- "https://github.com/MKupperman/variant-nowcast-hub.git"
file_path <- "LANL-CovTransformer/2024-10-16-LANL-CovTransformer.parquet"

hub_path <- withr::local_tempdir()
# Clone the repository into the current temporary directory
gert::git_clone(url = repo_url, path = hub_path)

# Read File
tbl_chr <- hubValidations::read_model_out_file(file_path,
  hub_path = hub_path,
  coerce_types = "chr"
)
#> ℹ Updating superseded URL `Infectious-Disease-Modeling-hubs` to `hubverse-org`
tbl_chr
#> # A tibble: 13,104 × 7
#>    location clade value target_date output_type output_type_id nowcast_date
#>    <chr>    <chr> <chr> <chr>       <chr>       <chr>          <chr>
#>  1 AL       24A   0     2024-09-15  mean        NA             2024-10-16
#>  2 AL       24A   0     2024-09-16  mean        NA             2024-10-16
#>  3 AL       24A   0     2024-09-17  mean        NA             2024-10-16
#>  4 AL       24A   0     2024-09-18  mean        NA             2024-10-16
#>  5 AL       24A   0     2024-09-19  mean        NA             2024-10-16
#>  6 AL       24A   0     2024-09-20  mean        NA             2024-10-16
#>  7 AL       24A   0     2024-09-21  mean        NA             2024-10-16
#>  8 AL       24A   0     2024-09-22  mean        NA             2024-10-16
#>  9 AL       24A   0     2024-09-23  mean        NA             2024-10-16
#> 10 AL       24A   0     2024-09-24  mean        NA             2024-10-16
#> # ℹ 13,094 more rows

hubValidations::check_tbl_values(tbl_chr,
  round_id = "2024-10-16",
  file_path = file_path, hub_path = hub_path
)
#> <error/check_error>
#> Error:
#> ! `tbl` contains invalid values/value combinations.  Column
#>   `output_type_id` contains invalid value "NA".

# Values in output)type_id column are not `NA`s
all(is.na(tbl_chr$output_type_id))
#> [1] FALSE
# Values in output)type_id column are actually characters
all(tbl_chr$output_type_id == "NA")
#> [1] TRUE

# Convert to  NA values
tbl_chr$output_type_id <- NA_character_
tbl_chr
#> # A tibble: 13,104 × 7
#>    location clade value target_date output_type output_type_id nowcast_date
#>    <chr>    <chr> <chr> <chr>       <chr>       <chr>          <chr>
#>  1 AL       24A   0     2024-09-15  mean        <NA>           2024-10-16
#>  2 AL       24A   0     2024-09-16  mean        <NA>           2024-10-16
#>  3 AL       24A   0     2024-09-17  mean        <NA>           2024-10-16
#>  4 AL       24A   0     2024-09-18  mean        <NA>           2024-10-16
#>  5 AL       24A   0     2024-09-19  mean        <NA>           2024-10-16
#>  6 AL       24A   0     2024-09-20  mean        <NA>           2024-10-16
#>  7 AL       24A   0     2024-09-21  mean        <NA>           2024-10-16
#>  8 AL       24A   0     2024-09-22  mean        <NA>           2024-10-16
#>  9 AL       24A   0     2024-09-23  mean        <NA>           2024-10-16
#> 10 AL       24A   0     2024-09-24  mean        <NA>           2024-10-16
#> # ℹ 13,094 more rows

hubValidations::check_tbl_values(tbl_chr,
  round_id = "2024-10-16",
  file_path = file_path, hub_path = hub_path
)
#> <message/check_success>
#> Message:
#> `tbl` contains valid values/value combinations.

# Write the file back, re-read and check again
arrow::write_parquet(tbl_chr, fs::path(hub_path, "model-output", file_path))

tbl_chr <- hubValidations::read_model_out_file(file_path,
  hub_path = hub_path,
  coerce_types = "chr"
)
#> ℹ Updating superseded URL `Infectious-Disease-Modeling-hubs` to `hubverse-org`
hubValidations::check_tbl_values(tbl_chr,
  round_id = "2024-10-16",
  file_path = file_path, hub_path = hub_path
)
#> <message/check_success>
#> Message:
#> `tbl` contains valid values/value combinations.

Created on 2024-10-18 with reprex v2.1.0

@MKupperman, I have a couple of diagnostic questions for you:

What did you use to create the model output (R, Python, Excel, Julia, small-batch hand crafted artisan spreadsheets, etc)?
How did you create the parquet file? Did you write directly from the table in memory to parquet format or did you write to CSV and then convert that into a parquet file?
Would you be able to share the code you use to create the output?

Thank you for the report!

Hi all, thanks for looking into this!
@zkamvar - here's some information.

Model outputs are assembled in Python using Pandas.
Specifically, we form a list of dictionaries (one dictionary per row, setting "NA" for the output_type_id), and invoke pandas.DataFrame.from_dict. We then serialize the dataframe to a parquet file using the Pandas method, to_parquet, with the pyarrow engine.
I can't share the full file, but here's a MWE for the process we used.

mport pandas as pd

# Define the data as a list of dictionaries
data = [
    {"location": "AL", "clade": "24E", "value": 0.0, "target_date": "2024-09-22", "output_type": "mean", "output_type_id": "NA", "nowcast_date": "2024-10-23"},
    {"location": "AL", "clade": "24E", "value": 0.0, "target_date": "2024-09-23", "output_type": "mean", "output_type_id": "NA", "nowcast_date": "2024-10-23"}
]

# Convert the list of dictionaries to a pandas DataFrame
df_mwe = pd.DataFrame(data)

# Display the DataFrame
df_mwe

If we coerce to pd.NA (or None), the corresponding dtype that the validation tool receives is vctrs_unspecified, rather than chr. Similarly, using np.nan to encode gives a "double" (numeric) data type, instead of char. Seems like an issue to fix on the backend.
For now, we'll add some R to the pipeline and do the conversion there, as @annakrystalli suggested.

Thank you for the MWE, @MKupperman! I've opened https://github.com/hubverse-org/hubValidations/issues/131 to track the issue.

Adding 10/23 submissions to the PR. Should pass integration tests now.


Sending traces to the agent in k8s

Describe the bug
Getting the following error trying to send traces to my DD agent running in Kubernetes
{"Timestamp":"2018-11-01T14:24:57.5749038+00:00","Level":"Error","MessageTemplate":"An error occurred while sending traces to the agent at {Endpoint}","Exception":"System.Net.Http.HttpRequestException: Cannot assign requested address ---> System.Net.Sockets.SocketException: Cannot assign requested address\n   at System.Net.Http.ConnectHelper.ConnectAsync(String host, Int32 port, CancellationToken cancellationToken)\n   --- End of inner exception stack trace ---\n   at System.Net.Http.ConnectHelper.ConnectAsync(String host, Int32 port, CancellationToken cancellationToken)\n   at System.Threading.Tasks.ValueTask1.get_Result()\n   at System.Net.Http.HttpConnectionPool.CreateConnectionAsync(HttpRequestMessage request, CancellationToken cancellationToken)\n   at System.Threading.Tasks.ValueTask1.get_Result()\n   at System.Net.Http.HttpConnectionPool.WaitForCreatedConnectionAsync(ValueTask1 creationTask)\n   at System.Threading.Tasks.ValueTask1.get_Result()\n   at System.Net.Http.HttpConnectionPool.SendWithRetryAsync(HttpRequestMessage request, Boolean doRequestAuth, CancellationToken cancellationToken)\n   at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)\n   at System.Net.Http.HttpClient.FinishSendAsyncBuffered(Task`1 sendTask, HttpRequestMessage request, CancellationTokenSource cts, Boolean disposeCts)\n   at Datadog.Trace.Agent.Api.SendAsync[T](T value, Uri endpoint)","Properties":{"Endpoint":"http://localhost:8126/v0.3/traces","SourceContext":"Datadog.Trace.Agent.Api"}}
To Reproduce
string ddAgentAddr = String.IsNullOrWhiteSpace(Environment.GetEnvironmentVariable("DD_AGENT_ADDR")) ? "http://localhost:8126" : $"http://{Environment.GetEnvironmentVariable("DD_AGENT_ADDR")}";
System.Uri uri = new System.Uri(ddAgentAddr);
Tracer.Create(uri);

Expected behavior
Traces show up fine if I run my service locally + sending to local DD Agent. I'm sure the agent runs fine in k8s as my other services, using different libraries, are able to send traces to the agent.
Runtime environment (please complete the following information):

Instrumentation mode: manual with NuGet
Tracer version: tried both 0.4.1-beta and 0.5.0-beta

Additional context
I'm sending over http://<IP_ADDRESS>:8126 as the uri but I notice the error contains "Endpoint":"http://localhost:8126/v0.3/traces ? Not sure if the default of localhost:8126 is being written over on Tracer.Create?
In trace.agent.log, there are no error messages

2018-11-01 14:40:03 INFO (trace_writer.go:97) - flushed trace payload to the API, time:253.26402ms, size:307 bytes
2018-11-01 14:40:13 INFO (trace_writer.go:97) - flushed trace payload to the API, time:163.809104ms, size:555 bytes
2018-11-01 14:40:18 INFO (service_mapper.go:59) - total number of tracked services: 0
2018-11-01 14:40:18 INFO (stats_writer.go:265) - flushed stat payload to the API, time:247.369233ms, size:742 bytes
2018-11-01 14:40:28 INFO (stats_writer.go:265) - flushed stat payload to the API, time:274.774159ms, size:419 bytes
2018-11-01 14:40:38 INFO (stats_writer.go:265) - flushed stat payload to the API, time:298.825843ms, size:493 bytes
2018-11-01 14:40:58 INFO (api.go:324) - [lang:go lang_version:1.11beta1 interpreter:gc-amd64-linux tracer_version:v1.0] -> traces received: 3, traces dropped: 0, traces filtered: 0, traces amount: 1205 bytes, services received: 0, services amount: 0 bytes
2018-11-01 14:40:58 INFO (api.go:324) - [lang:nodejs lang_version:v9.4.0 interpreter:v8 tracer_version:0.6.0] -> traces received: 2, traces dropped: 0, traces filtered: 0, traces amount: 3145 bytes, services received: 0, services amount: 0 bytes

Able to see that other services are able to send to DD agent.

Looks very similar to https://github.com/DataDog/dd-trace-csharp/issues/149


Implement LSPS0

This issue is part of https://github.com/breez/breez-sdk/issues/385
https://github.com/BitcoinAndLightningLayerSpecs/lsp/blob/main/LSPS0/README.md
In short: ability to receive and send LSP messages through lightning custom messaging.

Fixed by https://github.com/breez/breez-sdk/pull/470


Old mstest references in example

Type of issue
Outdated article
Description
[Enter feedback here]
The references for MSTest is refering to version 2. The current version of mstest is 3.4. The article should be updated to reflect that.
Page URL
https://learn.microsoft.com/en-us/dotnet/core/testing/unit-testing-with-mstest
Content source URL
https://github.com/dotnet/docs/blob/main/docs/core/testing/unit-testing-with-mstest.md
Document Version Independent Id
4675decb-333f-0508-5a3d-ce71dc85936d
Article author
@ncarandini
Metadata

ID: 1c123f1f-8ae8-db21-2eac-4297bfc30b44
Service: dotnet-fundamentals

I believe this should be fixed by #40996, but wasn't linked when PR was created.
CC: @MattKotsenas @IEvangelist @BillWagner


feat: add C ndarray interface and refactor implementation for stats/base/dmskmax

Resolves None
Description

What is the purpose of this pull request?

This pull request:

adds C ndarray interface for stats/base/dmskmax
refactors JavaScript implementation
updates tests, docs, examples and benchmarks

Related Issues

Does this pull request have any related issues?

This pull request:

resolves None

Questions

Any questions for reviewers of this pull request?

No.
Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.
Checklist

Please ensure the following tasks are completed before submitting this pull request.

[x] Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

lib/ndarray.native.js has a linting warning of the line length being greater than 80, i can't seem to remember what comment to add to escape that warning @reviewer

only js benchmarks need to be updated here

/stdlib update-copyright-years


Changing quality of pdf

Hi
I use BookStack with wkhtmltopdf. Is there a way to change the quality of exported pdf files? At the moment, they appear (although I may well be wrong) that they are produced in low quality format. Is it possible to change the render quality? Could it be added as an option on the settings page?
Many thanks
Mark

Hi @techauthoruk,
wkhtmltopdf does have some quality options that we could expose but the defaults are already at fairly high settings so it makes me think there may be other issues at play here if you're seeing low quality ouput...
Do you have an example of a generated low-quality PDF?

Hi @ssddanbrown
Thank you for taking the time to reply. This is all very embarrasing.....I have created a few pdfs and they all look fine. The only change I have made in the last few days is applying the 0.28.2 update, although I dont think that corrected any pdf issues with wkhtmltopdf.
Anyway, all looks fine so apologies for bothering you. I will close this issue.
Thanks again!

Closed


Personal mission #4

@ItamarShDev
Tdd misstion .
fixed find_a_person
added 2 new function
and tests for all function, they also pass.

:+1:


Quickstart archetypes missing files

Environment Details

Helidon Version: 2.0.0-RC2

Problem Description
During the conversion of the quickstarts to the new archetype mechanism we lost some files (from both the SE and MP quickstarts):

Dockerfile, Dockerfile.jlink, Dockerfile.native
app.yaml

We have guides and documentation that assume these files will be there.
I also noticed that src/main/resources/META-INF/native-image/reflect-config.json is now src/main/resources/native-image/reflect-config.json (no META-INF). Is that a problem? The file appears to have an empty element, so it might be a no-op. Maybe we included it to show where this configuration goes?

See PR #2057


[staging & production] Cannot add project to dashboard when having only admin read access

Steps

Log into staging or production as user A
Go to a project on which user A and user B have admin access
Open another window and log in as user B
As user B create a component within that project and not add user A as a contributor to that component
Confirm that user A has read access via being an admin on the parent project (user B can go to Sharing page of the component and ensure that user A's name is listed under 'Admins on Parent Projects')
Here, user A is Cailey and user B is Muffin:

As user A, go to the project
Look at the top-right of the page to add project to dashboard
Look for the icon to watch project

Expected
I expect that user A would be able to add the project to the dashboard and watch the project.
Actual
User A does not have the option to add the project to the dashboard (button is completely missing) or watch the project (button is disabled).

It's still a private component. User A can view it only because he has
admin right on parent project. User A can still see all the logs of the
component from parent project log. But I don't think we should offer user A
the right to track the private component from watch log. In real world,
User A can just ask User B to add him as a contributor to that component to
track it.
On Thu, May 14, 2015 at 10:47 AM, Cailey Fitzgerald <
<EMAIL_ADDRESS>wrote:

Steps

Log into staging or production as user A
Go to a project on which user A and user B have admin access
Open another window and log in as user B
As user B create a component within that project and not add user
A as a contributor to that component
Confirm that user A has read access via being an admin on the
parent project (user B can go to Sharing page of the component and ensure
that user A's name is listed under 'Admins on Parent Projects') Here, user
A is Cailey and user B is Muffin: [image: screen shot 2015-05-14 at 9
56 02 am]
https://cloud.githubusercontent.com/assets/5975444/7633091/fdd72172-fa1f-11e4-883c-9ed72c277184.png
As user A, go to the project
Look at the top-right of the page to add project to dashboard
Look for the icon to watch project

Expected
I expect that user A would be able to add the project to the dashboard and
watch the project.
Actual
User A does not have the option to add the project to the dashboard
(button is completely missing) or watch the project (button is disabled).
[image: screen shot 2015-05-14 at 10 47 08 am]
https://cloud.githubusercontent.com/assets/5975444/7634094/967de07c-fa26-11e4-8b79-539eb7082fd8.png
—
Reply to this email directly or view it on GitHub
https://github.com/CenterForOpenScience/osf.io/issues/2715.

@sloria what are your opinions on this?

If you can see it without the use of a special link, you should be able to put it in your project organizer.

+1 to @brianjgeiger -- that is my thought

Talked with @lbanner @saradbowman , you can view that project just becasue you are the admin of the parent project. You have the right to be aware what's going on. However, as the fact you are not a contributor of that child component, you should not be able to include that in your project organizer as your project or a public project. Neither should you be able to watch it to track it. @sloria thoughts?

If they can make a bookmark to go to the project whenever they want (which they could), they should be able to use the project organizer to go to it. Also, they could go around the "don't use the project organizer" restriction by going to their project organizer, expanding the project that they are administrator on, and dragging the component into another folder.
What disabling that button does is to create an inconsistent user interface for reasons that are opaque to the end user. If they can view it, they should be able to add it to their project organizer in all they ways they can other projects.

Just chatted with Nan about it.  I agree with Brian G.

Should now be fixed.


Project initialization failed on windows machines on missing sed command

Describe the bug
On windows machines the initialization (call sbt in command line) failed due to missing command sed on windows.
Expected behavior
Call sbt will work.
Desktop (please complete the following information):

OS: Windows

Additional context
Partial output with an errors.
[info] loading settings for project spark-data-standardization from build.sbt,publish.sbt ...
Exception in thread "Thread-15" java.io.IOException: Cannot run program "sed": CreateProcess error=2, The system cannot find the file specified
at java.lang.ProcessBuilder.start(ProcessBuilder.java:1048)
at scala.sys.process.ProcessBuilderImpl$Simple.run(ProcessBuilderImpl.scala:75)
at scala.sys.process.ProcessImpl$PipedProcesses.runAndExitValue(ProcessImpl.scala:142)
at scala.sys.process.ProcessImpl$PipedProcesses.runAndExitValue(ProcessImpl.scala:121)
at scala.sys.process.ProcessImpl$CompoundProcess.$anonfun$x$4$1(ProcessImpl.scala:100)
at scala.sys.process.ProcessImpl$Spawn$$anon$1.run(ProcessImpl.scala:27)

Workaround
Comment lines below in file build.sbt
lazy val currBranchName = "git branch --show-current".!!.trim
lazy val baseBranchName = (
  "git show-branch -a"
    #| raw"grep \*"
    #| s"grep -v $currBranchName"
    #| "head -n1"
    #| raw"sed s/.*\[\(.*\)\].*/\1/"
).!!.trim
scalafmtFilter.withRank(KeyRanks.Invisible) := s"diff-ref=${baseBranchName}

Proposal to solve
lazy val currBranchName = "git branch --show-current".!!.trim
lazy val baseBranchName = System.getProperty("os.name").toLowerCase match {
  case win if win.contains("win") =>
    ???           **<find alternative solution for windows>**
  case osName =>
    (
      "git show-branch -a"
        #| raw"grep \*"
        #| s"grep -v $currBranchName"
        #| "head -n1"
        #| raw"sed s/.*\[\(.*\)\].*/\1/"
      ).!!.trim
}

This bug issue has been solved by PR #33

This bug issue has been solved by PR #33


FAMC.STAT PROVEN

The GEDCOM7 spec says in defining g7:enumset-FAMC-STAT:

Value
Meaning

CHALLENGED
Linking this child to this family is suspect, but the linkage has been neither proven nor disproven.

DISPROVEN
There has been a claim by some that this child belongs to this family, but the linkage has been disproven.

PROVEN
There has been a claim by some that this child does not belong to this family, but the linkage has been proven.

If the linkage has been proven but there has NOT been a claim by some that this child does not belong to this family, what value should be chosen?   The current wording of PROVEN disallows that status for this case.

My instinct is that this change is how people likely used PROVEN, but I will note that the requirement of a disputation has been present since this tag's introduction in 5.5.1 and there may be applications that use the disputation implication of PROVEN in their user interface. Thus, I worry that allowing unchallenged PROVENs  might actually be a breaking change in a subtle but sometimes meaningful way.

Discussed 2022-10-18
We don't think FAMC.STAT PROVEN is much used, so changing it is probably OK. We want to check with a few other people before moving forward, though. If anyone reading this note knows of cases that use FAMC.STAT PROVEN, to mean there was a dispute or not, please let us know.

Unless we are talking about DNA proof, relationships to a family are never truly “proven”, and that we can only base linkage on how good the existing evidence is. However, we can say that “proven” means that “strong evidence exits” that the family relationship exists.
I am reluctant to want to include the language that “their was a claim” that the connection was/is false because their may not be any controversy, rather that the connection has “strong evidence to be true”.   Maybe change the description to: “Strong evidence exists to indicate that the linkage to this family is correct.”
If we can not agree to change the definition then a 4 option should be added with a definition that indicate that “strong evidence exists and is currently unchallenged”.

Proposed:
Add something like

When these enumeration values were introduced it was assumed, but never specified, that "proven" referred to the definition provided by the Board of Certification of Genealogists. Because that meaning was not specified and other definitions of "proven" exist, existing files may use these values in other ways.


Tag releases?

Hello,
It would be great to have tagged releases, so we could use them to include DromeAudio in the Homebrew core.
Thanks!

Thanks for the suggestion - created a tagged release here: https://github.com/joshb/DromeAudio/releases/tag/v0.3.0

Thanks a lot :smile:


add Edit menu

As referenced in #72 this ensures proper text field behavior (undo/redo, copy/paste, quick emoji picker🐠) on macOS. Do linux and windows currently show the menu?

Looks great! Thanks for this :D


foreign keys on models with multiple primary keys

Changes

rework ForeignKeys to work with multiple primary keys. Untested yet.
add field_name for getter/setters
fix #101
use the descriptor protocol for many2many
remove defunct (wrong type) and unused many_to_many collection

Missing
Tests

Except the tests (multiple primary keys) I finished the cleanup of foreign keys and fixed the issue 101 on the way.
Do we want to merge it already? And continue to integrate tests later (I have also to provide some docs for ExcludeField)

oops, there is another bug.
I will finish it first


Upgrade utf8

Here it is: UTF8 conversion while upgrading fixes #1756

Since for the moment this is not necessary I'm closing it.


A bug in preprocess pipeline: ValueError: mode must be 'r', 'w', or None, got: rb

used system and hardware: ubuntu 20.04 and 4*3090
hi, I'm find a bug in RVC1006Nvidia zip file. The trackback is "ValueError: mode must be 'r', 'w', or None, got: rb".
i'm changed a part of code on "RVC1006Nvidia/infer/lib/audio.py":
original is:
def audio2(i, o, format, sr):
    inp = av.open(i, "rb")
    out = av.open(o, "wb", format=format)

i'm fixed it is:
def audio2(i, o, format, sr):
    inp = av.open(i, "r")
    out = av.open(o, "w", format=format)

so this is a small bug, but i hope this bug are fix it well.

I was having the same issue after finally getting the WebUi working in a weird way (I don't wanna talk about the troubleshooting and installations rabbit hole I went down), and this manual fix appears to have worked for me. I can pre-process my audio now! (I'm using Linux Mint 21).

Thank you, this fixed the latest release for me on Linux.

Thank you very much colstone, this helped me as well.

I was having the same error, fixing the code didn't work out for me, after reading some documentation i found out that the PyAV library from version onwards 10.0.0 doesn't support "rb" and "rw" as arguments for av.open(), so i fixed it by forcing version 9.2.0 in requirements.txt
av==9.2.0


Refresher components visible ontop of the content!

Ionic version:  (check one with "x")
[ ] 1.x
[x] 2.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
Refresher components are visible ontop of the content on pull down.
Expected behavior:
Refresher components should only be fully visible when pulled down completely.
Steps to reproduce:

Install latest nighly version
Start project
Place refresher component

Related code:
insert any relevant code here

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
ordova CLI: 6.5.0
Ionic Framework Version: 2.1.0-201703061537
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.1.3
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 10
Node Version: v6.10.0
Xcode version: Not installed

Thanks for opening an issue with us. Unless im not understanding the issue correctly, this is how refresher has always worked. Is the behavior different when you do not use nightly in your app?

The orange line is the beginning of the content. Normaly the text of the refresher is behind the content and only visible when you pull down far enough ... here the text is visible even when it is behind the content. Normal behaviour can be seen in the refresher V2 docs

Hmm interesting, unfortunately i cant reproduce this in my test app. Would you mind sharing a repo or plunker that reproduces the issue? Thanks

Had the same issue on a specific page. Solved this by adding
z-index: 99999;
background-color: white;

Hello all! As it seems it has been a while since there was any activity on this issue and we can unfortunately not reproduce this on our end, i will be closing it for now. Feel free to comment if you are still running into this issue. Thanks for using Ionic!


Fix off by one error during calculation of number of lines in the matrix files

The number of lines should always be the next bigger integer not the closest smaller integer
resolves DEV-1513

The fix looks good, however we need to wait for Mike's branch to be merged to reproduce the error and see if the fix works.


[BUG] Circuit without gates on Amazon Braket raises error

dev = qml.device("braket.local.qubit", wires=2, shots=100)

@qjit
@qml.qnode(dev)
def f(x: float):
    return qml.expval(qml.PauliZ(0) @ qml.PauliX(1))

f(0.7)

RuntimeError: [OpenQasmRunner.hpp][Line:343][Function:Expval] Error in Catalyst Runtime: max() arg is an empty sequence

This appears to be fixed!


Passing Username and Password to from_mqtt()

It looks like in Paho the username and password for the connection is set by calling the username_pw_set() method on the client object before running client.connect(). This sets the _username and _password attributes for the client.
Would it be possible to implement an argument in .from_mqtt() to pass authentication parameters through to client.username_pw_set()?

Would you like to try this?
--- a/streamz/sources.py
+++ b/streamz/sources.py
@@ -896,12 +896,15 @@ class from_mqtt(from_q):
     :param client_kwargs:
         Passed to the client's ``connect()`` method
     """
-    def __init__(self, host, port, topic, keepalive=60 , client_kwargs=None, **kwargs):
+    def __init__(self, host, port, topic, keepalive=60 , client_kwargs=None,
+                 user=None, pw=None, **kwargs):
         self.host = host
         self.port = port
         self.keepalive = keepalive
         self.topic = topic
         self.client_kwargs = client_kwargs
+        self.user = user
+        self.pw = pw
         super().__init__(q=queue.Queue(), **kwargs)

     def _on_connect(self, client, userdata, flags, rc):
@@ -913,6 +916,8 @@ class from_mqtt(from_q):
     async def run(self):
         import paho.mqtt.client as mqtt
         client = mqtt.Client()
+        if self.user:
+            client.username_pw_set(self.user, self.pw)
         client.on_connect = self._on_connect
         client.on_message = self._on_message

Worked like a charm, thanks!

Please feel free to contribute this as a PR

Submitted, thanks again for the help.


"WebAssembly.String is undefined, adding polyfill" - remove this from production builds?

For OUR development, I see why this is nice.
For our (soon to be production) users, it's confusing/noise.
Can we get rid of it? Hide it behind a opt-in compile flag or something?

Also, while inspecting the WASM module, my real system paths are visible. Can I hide them?

@ykmnkmi – please open another issue!


Transformer training with Nuscenes

As for the Transformer training with Nuscenes datasets, How long does it takes?I have running epochs 30,but the result is not desired ,is the file "__merged_road.jpg" the result?It seems to be wrong.

Hi,
The results are visualized in 'merged_road' yes. You can check the validation metric results to see if the training is complete. It is hard to comment on the state of the model based on a few visual examples.


Visualisation code for temporal clustering

Could you please provide the visualization code for temporal clustering of videos (i.e. the script used to generate the visualization in https://github.com/PKU-YuanGroup/Chat-UniVi?tab=readme-ov-file#visualization-for-the-video-inputs )

Sorry, we currently don't have a good video visualization script either. We took a rudimentary approach to visualizing the video, manually recording the position of each event frame, then putting together frames within the same event, and then invoking the code with a slight adjustment.


Tests gobject

Thanks!
Let's see if I've fixed ffi_type sufficiently.
@homu r+

:pushpin: Commit 9426478 has been approved by gkoz

:hourglass: Testing commit 9426478 with merge 3c31dbc...

:broken_heart: Test failed - status

Only last va_list problem and warning

This'll be easier to fix after merging.

Uh-oh. We simply can't support va_list so it's blacklisting time.

IMHO good way to blacklisting add
[[objects]
name = "GObject.SignalCVaMarshaller"
status = "ignore"

and check status in generate_aliases.
PS. Commenting pub type GSignalCVaMarshaller = GVaClosureMarshal; fixed build

Also we can check all non-internal namespaces in fix_external_name

This doesn't seem appropriate under [[objects]]. Also for the purpose of sys modules I'd like something less verbose, like a single array with blacklisted identifiers, e.g.
ignore = [
    "SignalCVaMarshaller",
    "SomethingElse",
]

Yeah, bad types from external namespaces could be a problem...

We can just rename [[objects]] to something else [[identifiers]]

This way we don't need add second check.

toml allows this BTW
[[GObject.SignalCVaMarshaller]]
status = "ignore"

Could save some typing.

But how to detect that it is objects ?

If the generator went through the objects (and other items) it finds in the library, it would know and just check them against the config.

So we need store toml in environment?

And do parsing on every request?

I assumed it's parsed once and held in memory :)

Yes, it parsed as toml file, but we needed parse "status=ignore" on every request, as we can't "combine" all old [[objects]] to one category and parse to own format.

Asking the toml::Table if it has a key status inside a table Widget inside a table Gtk should not involve parsing. (I should've put single brackets in that example: [Gtk.Widget])

But we needed parse status

I see. Okay, currently all items are uniform pairs of name and status so we actually can parse them once. If some items' configs get distinct keys in the future, we surely can manage that somehow (the library knows which is which after all).

But explicitness could be a virtue too I guess.

We can count ignore as simply alias for [[objects]]name=...\status='ignore'

The main thing from my point of view, that is stored in name => Status. With the test of the dubbing, etc.

An ignore shorthand is okay.


chore: add jest coverage workflow

:tada: This PR is included in version 4.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Close image if it's not loading

Hello,
For example: we open in iv program any image, for example 3. In status bar we can see information about it: (3/3)....
Now we have 3 displaying images. For example i open 4 image, but it's not open. In statusbar we have (4/4)... but iv displaying 3 images now and 4 black screen and note that image cannot be opened. I suggest if iv cannot load image, show error message to user and close this image. I want to write patch. What do you think about it?
Thank you.

I was looking through old bugs to see if there was low hanging fruit I could work on, and this is the oldest open one.  Does anybody have thoughts on whether this is desired behavior, or something that should be changed so broken images aren't retained as "open"?  I confirmed that this is still what happens when you open a broken image.

Coalescing.


Discord bot

Implement social loop SDK so we can have Discord/Twitter challenges and notifications when a match progresses.

[ ] Connect to the game's Torii server
[ ] Figure out how to listen to game Models change from the bot
[ ] Display game messages to a specific Discord channel
[ ] Announce new Challenges (configurable)
[ ] Announce new Duels (configurable)
[ ] Announce duel rounds results (configurable)
[ ] Announce finished Duels (configurable)
[ ] Figure out if we can link a Discord user to their wallet
[ ] Challenge another player using the bot

Moved to #17


Added shape inference for TFL to Tosa Lowering

Some TFLite operations need the rank/shape of operands to lower to the
appropriate TOSA operations. By performing shape inference during the
lowering, underspecified IR can be lowered without TFLite shapes known during
compilation.
Note this splits lowering from quantized type removal as the Dialect Conversion
framework does not agree with multiple sources of types.

It would seem you get all of what CreateAndInfer does if you just used effectively https://github.com/llvm/llvm-project/blob/24c8eaec9467b2aaf70b0db33a4e4dd415139a50/mlir/include/mlir/Interfaces/InferTypeOpInterface.td#L136.

It would seem you get all of what CreateAndInfer does if you just used effectively<EMAIL_ADDRESS>
So I am not entirely certain that is true. This works for the majority of operations however tosa.rescale depends on the result element type being specified directly by the constructor.
Overall it would be nice to have an interface that supports this, however I don't think the current ones do. E.g. all the existing utilities are member functions as well, requiring a constructed op to reify the shapes.

It would seem you get all of what CreateAndInfer does if you just used effectively<EMAIL_ADDRESS>
So I am not entirely certain that is true. This works for the majority of operations however tosa.rescale depends on the result element type being specified directly by the constructor.

I see, so rescale can change the result element type and the target element type is not an attribute?

Overall it would be nice to have an interface that supports this, however I don't think the current ones do. E.g. all the existing utilities are member functions as well, requiring a constructed op to reify the shapes.

You are doing construction time inference, so the producers are all created before a new op is. But you are correct that if you want to reify before creating an op, then you can't. But that feels weird to me to do: I see this as straddling line between tensor world and buffer world and should be a dedicated pass to go from one to the other.

orts this, however I don't think the current ones do. E.g. all the existing utilities are member functions as well, requiring a constructed op to reify the shapes.

Overall I think the right choice is to affix the output element type as a type attr for tosa.rescale. It actually avoids some other issues as well (u8 needing to persist as a type until tosa-to-linalg).
It may be worth raising with the ARM folks.

Everything should be cleaned up including some changes due to moving the quantization stripping to an optional pass. Verified manually but there may be integration issues needed internally.


Multiple ideas from podcast-ext project

Hey !
I'm co-founder of podCloud, a French podcasting platform (hosting, discovering, listening platform).
We were actually working on the same project as yours, beginning months ago since 2019.
podCloud/podcast-ext
We had multiple emotions when we discovered your project. We first ignored it, then we changed our namespace to podext to prevent future issues.
Now, given the growing community supporting your initiative, I'm wondering if it's better for us to retire our project and join yours, for the better good of podcast feeds and work together.
Nevertheless we had given many thoughs on this so I guess we could keep some ideas and also propose them here.
I'm mostly thinking about episodes and podcast licence and our "cultural" tags, allowing podcasters to tag in episodes books, games, movies, events, TV shows, even objects. I'll let you take a look at it, let me know what you think of them.
podCloud/podcast-ext

This all looks super-exciting - thanks so much for sharing it.
The 'licence' looks very interesting. I wonder whether there's a method of incorporating that somehow into the  tag that already exists in RSS? (Is it possible to use a namespace to modify an existing tag?) I'm thinking of the type:
<copyright licence="CC-BY">My Podcast Company</copyright>
The episode metadata is fascinating; the idea of tagging books, games and movies etc is really interesting. I wonder how this can be made webscale, and have unambiguous data about each thing? A UAN/ISBN code?
I think it definitely worth proposing some here.

This all looks super-exciting - thanks so much for sharing it.
The 'licence' looks very interesting. I wonder whether there's a method of incorporating that somehow into the  tag that already exists in RSS? (Is it possible to use a namespace to modify an existing tag?) I'm thinking of the type:
<copyright licence="CC-BY">My Podcast Company</copyright>
The episode metadata is fascinating; the idea of tagging books, games and movies etc is really interesting. I wonder how this can be made webscale, and have unambiguous data about each thing? A UAN/ISBN code?
I think it definitely worth proposing some here.

@PofMagicfingers This is great!  Thanks for bringing your project knowledge here.  Please add yourself to the contributors.txt file right away.  Looking through your repo, there is so much overlap of ideas. ❤
I agree with James that the metadata stuff looks awesome. Please do some tag proposals and we can all start refining things.

@PofMagicfingers This is great!  Thanks for bringing your project knowledge here.  Please add yourself to the contributors.txt file right away.  Looking through your repo, there is so much overlap of ideas. ❤
I agree with James that the metadata stuff looks awesome. Please do some tag proposals and we can all start refining things.

Thanks for the warm welcome ! I'll create issues for tag proposals in the upcoming days.
@daveajones Thanks a lot, I'll add myself ! Do you mind if we also add @Bigaston who helped me a lot on our original ideas ? :slightly_smiling_face:
@jamescridland That's an interesting idea, I think we could do that, but technically it should be in the following form :
<copyright podcast:licence="CC-BY">My Podcast Company</copyright>
However I'm not sure the copyright tag is available at item level. We'll discuss this in the dedicated issue when I'll create it :D

Thanks for the warm welcome ! I'll create issues for tag proposals in the upcoming days.
@daveajones Thanks a lot, I'll add myself ! Do you mind if we also add @Bigaston who helped me a lot on our original ideas ? :slightly_smiling_face:
@jamescridland That's an interesting idea, I think we could do that, but technically it should be in the following form :
<copyright podcast:licence="CC-BY">My Podcast Company</copyright>
However I'm not sure the copyright tag is available at item level. We'll discuss this in the dedicated issue when I'll create it :D

Yes, please add whoever has contributed in even the slightest way. Even if it’s just inspirational.  Everyone gets credit here. 😊
DJ
On Jan 31, 2021, 3:52 AM -0600, Pof Magicfingers<EMAIL_ADDRESS>wrote:

Thanks for the warm welcome ! I'll create issues for tag proposals in the upcoming days.
@daveajones Thanks a lot, I'll add myself ! Do you mind if we also add @Bigaston who helped me a lot on our original ideas ? 🙂
@jamescridland That's an interesting idea, I think we could do that, but technically it should be in the following form :
My Podcast Company
However I'm not sure the copyright tag is available at item level. We'll discuss this in the dedicated issue when I'll create it :D
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Yes, please add whoever has contributed in even the slightest way. Even if it’s just inspirational.  Everyone gets credit here. 😊
DJ
On Jan 31, 2021, 3:52 AM -0600, Pof Magicfingers<EMAIL_ADDRESS>wrote:

Thanks for the warm welcome ! I'll create issues for tag proposals in the upcoming days.
@daveajones Thanks a lot, I'll add myself ! Do you mind if we also add @Bigaston who helped me a lot on our original ideas ? 🙂
@jamescridland That's an interesting idea, I think we could do that, but technically it should be in the following form :
My Podcast Company
However I'm not sure the copyright tag is available at item level. We'll discuss this in the dedicated issue when I'll create it :D
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

I created all relevant issues, I guess.
Before closing this one, we own podcast-ext.org domain name, do you want to discuss what we could do with it together ?
We could redirect it to this project, or let it die.

Whatever you think on the domain name. Totally up to you.
Thanks for bringing over these ideas. I’ll be updating the proposal list in the readme in the next week or so to prepare for phase 3.


Cannot get electron.remote.require to work

I'm trying to get an angularjs-app, which I package with electron, to play together with karma-electron. Previously we used PhantomJS, but I would like to move away from this. The problem is that in a couple of places I have a require('electron').remote.require('./main.js') to get access to some Node stuff from within the renderer process. I cannot seem to get this to work. Using the full path of main.js makes it work, but that is (obviously) undesirable.
I have set __filenameOverride to the location of index.html and loadScriptsViaRequire is set to true. Doesn't seem to make a difference. Clearly, the require is looking in the wrong place for my script (it's in the same directory as index.html). What magic is required to get it working? Issue #11 seems to suggest that it should just work, but doesn't provide me with the detail to get it working in my case...

It seems that remote.require is looking in node_modules/karma-electron/lib for ./main.js, so apparently it is using the cwd of the launcher to look for modules. __filenameOverride seems to refer to the normal require, it isn't picked up by the remote.require.

I've got a few questions:

Can you verify there's no bundler being used that might affect require? (e.g. browserify, webpack)
What's the error message you're receiving?
Would it be possible to get a minimal test case reproducing this issue?

I've tried to create an example which is as minimal as possible (not easy), I've uploaded it to https://github.com/michelwilson/karma-electron-minimal-example. The uploaded version works in karma-electron, do a npm install; bower install; karma start to make it go. Comment out src/script.js:4 and comment src/script.js:6 to break it. The working version doesn't work when you do a electron ..
The error I get is:
Electron 1.7.10 (Node 7.9.0) ERROR
  Uncaught Error: Cannot find module './main.js'
  Error: Cannot find module './main.js'
      at Module._resolveFilename (module.js:470:15)
      at Function.Module._resolveFilename (/XXX/minimal/node_modules/electron/dist/resources/electron.asar/common/reset-search-  paths.js:35:12)
      at Function.Module._load (module.js:418:25)
      at Module.require (module.js:498:17)
      at EventEmitter.<anonymous> (/XXX/minimal/node_modules/electron/dist/resources/electron.asar/browser/rpc-server.js:263:70)
      at emitTwo (events.js:106:13)
      at EventEmitter.emit (events.js:194:7)
      at WebContents.<anonymous> (/XXX/minimal/node_modules/electron/dist/resources/electron.asar/browser/api/web-contents.js:256:13)
      at emitTwo (events.js:106:13)
      at WebContents.emit (events.js:194:7)
  at /XXX/minimal/node_modules/electron/dist/resources/electron.asar/renderer/api/remote.js:234

Great, that helped a bunch! Here's what the issues I found:

We aren't preprocessing src/*.js which is causing __filename and __dirname to be set as the Electron index.html

Once this was resolved and client.loadScriptsViaRequire was set back to true, require('../main.js') started working from the renderer (i.e. require, not electron.remote.require)

This library mostly targets renderer only testing. As a result, the require('electron').remote path issue was unexpected
What is happening: electron.remote.require is resolving from the remote context, meaning it's resolving from the main file of karma-electron (i.e. node_modules/karma-electron/lib/electron-launcher.js)

One workaround is to use require(__dirname + '/../main.js')
For a more permanent fix though, I suggest using our launcher require option. Documented here:

https://github.com/twolfson/karma-electron/tree/5.2.2#launcher-configuration

To summarize, the following fixes should resolve everything but we recommend the launcher require option instead of electron.remote.require:
karma.conf.js:
// ...
        preprocessors: {
            'src/**/*.js': ['electron'],
            'test/**/*.js': ['electron']
        },
        client: {
            useIframe: false,
            loadScriptsViaRequire: true
        },

// ...

script.js:
// ...
node_script = require('electron').remote.require(__dirname + '/../main.js');
// ...

Ah that gives some insight. I've got the minimal example working, now. To get the actual application to work, a bit more is required, as the __dirname trick doesn't seem to work there ... in karma-electron, __dirname refers to the directory of script.js, in electron itself it points to the directory of index.html.
I am not sure what use the launcher require option has. If I use it to require the main Electron script, this seems to start the application, in parallel with the test. Certainly not what I wanted to achieve ;)

Well, I don't fully understand why, but I got things working. For anyone encountering similar problems (you never know, and I hate finding problems without solutions ;)):

I've disabled loadScriptsViaRequire
__filenameOverride is set to the correct location of index.html (the one in the dev output directory, in my case
this can be checked by printing __dirname from the script in which you want to remote.require something, very useful!
and finally, this allows you to do remote.require(__dirname + '/something.js').

No idea if this is the 'right' way, but it makes it work for me :) Thanks for the assistance!

Glad to hear we got it working. If you'd like, I can help direct you in the direction with respect to main.js. Could you provide more context on why you need to load main.js?

In case of the real application, main.js exposes certain functionality that can only be handled outside of the renderer process: sending a UDP broadcast for server discovery. The reason for using karma-electron is to build midway tests at the frontend level of the stack, which talk to an actual backend. This gets us three things: midway tests of the frontend code, tests of the protocol between frontend and backend, and integration tests for the backend. Downside is of course that any test failures pose an interesting puzzle ;)
Anyway: it seems to be working, I can call frontend service layer functions, that call all the way into the backend, so I'm happy.

Cool, thanks for the info. Here's a few options:

Break out UDP connection logic into its own file (maybe a client). Then load that into main.js and in testing, load only that file (or maybe a test/karma-require.js which loads it)
Move to contract-based fixture testing instead of using a live server

This is preferable due to (1) faster test runs and (2) reusable pattern with 3rd party services which can have downtime
This would mean generating expected request/response transmissions in 1 location and reusing them in your tests
For me, I've typically generated those in the server tests with either fs.writeFileSync or an assertion that the request/response are 1:1 with whatever is on disk. Then, I'd set up a mock using those fixtures in the renderer tests
Here's an example with HTTP fixtures

https://github.com/twolfson/multi-image-mergetool/blob/1.32.1/test/server/update-image-set-filepath-show.js#L52-L58
https://github.com/twolfson/multi-image-mergetool/blob/1.32.1/test/browser/application-update-similar-images.js#L21
https://github.com/twolfson/multi-image-mergetool/blob/1.32.1/test/test-files/http-responses/xhr.js

Use a tool like spectron which is better equipped for full application testing

https://github.com/electron/spectron
Although, I'm guessing you already understand the tradeoff you've made by using Karma (less likely to break, easier to debug)

Interesting reading, thanks! I particularly like the idea of contract-based fixtures, as this circumvents the problem of not really testing the API by explicitly defining it. Even gives you a form of documentation for the API :) Thanks! I believe that I'll continue to use the current approach, due to time/budget constraints, unfortuntely. However, there'll always be future projects :)


Declutter Settings Page

The current Settings page displays all options on a single screen. Even though similar options are grouped and expandable on click, the page has become cluttered and overwhelming for users.
Proposed Solution:
Redesign the Settings page to display only the primary categories:

Cloud Backup
Security
Reminders
Customize Theme, Fonts, and Language

(Keep rest of the options like Send Feedback, Share with Friends, Project on Github and App version as it is)
On clicking these options, further relevant options needs to be displayed on a different screen.
Widgets Involved:
- lib/core/pages/settings_page.dart
- lib/core/widgets/settings_tile.dart

Tasks

[ ] Create a new page settings_details.dart in  lib/core/pages.
[ ] Remove widgets from ListView in settings_page.dart and addthe following options. (Use SettingsTile widget to display these options.)

Cloud Backup
Security
Reminders
Customize Theme,  Fonts and Language

[ ] On clicking any of the primary categories, navigate to settings_details.dart. Pass route parameters (e.g., pageTitle) to identify which category's settings to display in settings_details.dart.

@SankethBK assign it to me?

Sure @devpawann