Release GetMandateConstraints and RevokeMandate

Had to introduce some changes as well in the base ApiClient class:

enabled signing requests which have no request content (e.g. revoke mandate)
added overloaded PostAsync methods which can be used when no response content is expected (204 NoContent response, e.g. revoke mandate)

@ubunoir could you please share the screenshot of the tests from your local machine against our sandbox?

Locally I have all tests passed:

Here I can see that System.ComponentModel.DataAnnotations.ValidationException : Your client id is required error everywhere, not sure why?

Here I can see that System.ComponentModel.DataAnnotations.ValidationException : Your client id is required error everywhere, not sure why?

Unfortunately that is because the GH action that runs the cake script is not able to get the settings from your fork for some odd reason, despite the actions have been configured to work with forks as well 🤷🏻♂
We will try to fix it but for now, please always remember to put a screenshot of the result of the tests from your local machine (it would be good if you can show at least the new added tests as well).


Reorganize Get Started content

We have lots of get started content. We need to organize the journey better. We should create a new landing page for the get started content, highlighting the journey from day 1 to building the app you want to build. That means any of the following:

watch the C# 101 videos
explore in your browser
explore in Jupyter notebooks
read an overview of the language
install and run dotnet-try tutorials

The journey ends with installing the .NET SDK, and choosing the kind of application you want to build.
In addition, the current "Overview" section can be retired, closing the related issues.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: df2cc16c-fcf9-41e6-a1e5-92dfc2869495
Version Independent ID: 4421a02c-f819-1483-12c6-7dab4f289a46
Content: Introduction to C# - interactive tutorials
Content Source: docs/csharp/tutorials/intro-to-csharp/index.md
Product: dotnet-csharp
Technology: csharp-get-started
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

This is the final task in the plan developed for #17365 (Comments there include notes and links to other issues.)
Question: Is there good C# intro content on MS Learn to add in this issue?
/cc @mairaw @BethMassi

The tasks needed to finish this are as follows:

#18237
#18138
#3276
#19715 (see https://github.com/dotnet/docs/issues/19715#issuecomment-692807675)

Closing this as the plan is complete.


how to reproduce fig18.c?

Hello, SMART is a great job, and I am interested in it. Could you please tell me how to get sherman's result? I have tried to use "cmake -DSTATIC_MN_IP=on -DENABLE_CACHE=on -DLONG_TEST_EPOCH=off -DSHORT_TEST_EPOCH=off -DMIDDLE_TEST_EPOCH=off -DENABLE_CACHE_EVICTION=off -DON_CHIP=on .."  to run sherman, but the result is similar to SMART. How can I get the sheman's result, as the fig18c shows?
Looking forward to your early reply. Thanks a lot!

Hi LiYuTingxxn, thanks for your attention!
To reproduce Sherman's results, you should use our forked Sherman repo.
We have reproduced the experiments again, and the results are correct.
If you still fail to reproduce the results, could you please describe your experimental settings and the unexpected results in detail?
Do you run the code on the  r650 machines of CloudLab? And do you change any Sherman parameters (e.g., span size,  key size, value size, number of MNs, number of clients)?
I am willing to help you.
@LiYuTingxxn

Thank you for your reply!
The Sherman repo set VALUE is uint64_t , how do you support value size >= 512B? I have set VALUE to "std::array<uint64_t,define::valLen>"(as SMART used)  in Sherman  to support variable length value, but  I failed to run  when value size >=512B. Could you pelease tell me how to support larger value size in sherman?

Hi LiYuTingxxn, we use the simulatedValLen in Common.h to simulate value sizes larger than 8 bytes. As shown below:
https://github.com/River861/Sherman/blob/d63c224b8c2ff5b398df7a3833e53a8bea5c9f7a/include/Common.h#L126C20-L126C36
The implementation of the Value field is shown below:
https://github.com/River861/Sherman/blob/d63c224b8c2ff5b398df7a3833e53a8bea5c9f7a/include/Tree.h#L103-L106
Therefore, you just need to set the simulatedValLen to your expected value size as follows:
constexpr uint32_t simulatedValLen = 512;

@LiYuTingxxn

Ok, Thanks a lot!


Microsoft.media provider stuck in "registering"

Describe the bug
We are trying to deploy azure-caf-enterprise-scale and the init was fine. The problems occurs with the policy definitions, it get's stuck on one of the providers. This occurs while we are doing a Terraform plan, and after we cancel the plan we noticed an error message.
We created three new subscriptions and we notived that on the management one it's trying to register the Microsoft.media provider, even though we didn't request this after the creation and we only did Terraform plan afterwards. Is this expected and why is it stuck at registering on this particular provider?
Related command
az provider register --namespace microsoft.media
Errors
Plan: 224 to add, 0 to change, 0 to destroy.
╷
│ Error: Error ensuring Resource Providers are registered.
│
│ Terraform automatically attempts to register the Resource Providers it supports to
│ ensure it's able to provision resources.
│
│ If you don't have permission to register Resource Providers you may wish to use the
│ "skip_provider_registration" flag in the Provider block to disable this functionality.
│
│ Please note that if you opt out of Resource Provider Registration and Terraform tries
│ to provision a resource from a Resource Provider which is unregistered, then the errors
│ may appear misleading - for example:
│
│ > API version 2019-XX-XX was not found for Microsoft.Foo
│
│ Could indicate either that the Resource Provider "Microsoft.Foo" requires registration,
│ but this could also indicate that this Azure Region doesn't support this API version.
│
│ More information on the "skip_provider_registration" flag can be found here:
│ https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs#skip_provider_registration
│
│ Original Error: Cannot register providers: Microsoft.Media. Errors were: waiting for Subscription Provider (Subscription:
"6dadd044-b342-48fc-b7ac-0a742955e576"
│ Provider Name: "Microsoft.Media") to be registered: context canceled
│
│   with provider["registry.terraform.io/hashicorp/azurerm"].connectivity,
│   on providers.tf line 17, in provider "azurerm":
│   17: provider "azurerm" {
│
╵
╷
│ Error: Error ensuring Resource Providers are registered.
│
│ Terraform automatically attempts to register the Resource Providers it supports to
│ ensure it's able to provision resources.
│
│ If you don't have permission to register Resource Providers you may wish to use the
│ "skip_provider_registration" flag in the Provider block to disable this functionality.
│
│ Please note that if you opt out of Resource Provider Registration and Terraform tries
│ to provision a resource from a Resource Provider which is unregistered, then the errors
│ may appear misleading - for example:
│
│ > API version 2019-XX-XX was not found for Microsoft.Foo
│
│ Could indicate either that the Resource Provider "Microsoft.Foo" requires registration,
│ but this could also indicate that this Azure Region doesn't support this API version.
│
│ More information on the "skip_provider_registration" flag can be found here:
│ https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs#skip_provider_registration
│
│ Original Error: Cannot register providers: Microsoft.Media. Errors were: waiting for Subscription Provider (Subscription:
"1a6c15e7-2b1a-4ae4-a829-64945b37e408"
│ Provider Name: "Microsoft.Media") to be registered: context canceled
│
│   with provider["registry.terraform.io/hashicorp/azurerm"].management,
│   on providers.tf line 23, in provider "azurerm":
│   23: provider "azurerm" {
Issue script & Debug output
cli.knack.cli: Command arguments: ['provider', 'register', '--namespace', 'microsoft.media', '--debug']
cli.knack.cli: init debug log:
Enable color in terminal.
Enable VT mode.
cli.knack.cli: Event: Cli.PreExecute []
cli.knack.cli: Event: CommandParser.OnGlobalArgumentsCreate [<function CLILogging.on_global_arguments at 0x000001D3E3A15240>, <function OutputProducer.on_global_arguments at 0x000001D3E3B5FEB0>, <function CLIQuery.on_global_arguments at 0x000001D3E3DAD240>]
cli.knack.cli: Event: CommandInvoker.OnPreCommandTableCreate []
cli.azure.cli.core: Modules found from index for 'provider': ['azure.cli.command_modules.resource']
cli.azure.cli.core: Loading command modules:
cli.azure.cli.core: Name                  Load Time    Groups  Commands
cli.azure.cli.core: resource                  0.335        51       227
cli.azure.cli.core: Total (1)                 0.335        51       227
cli.azure.cli.core: Loaded 51 groups, 227 commands.
cli.azure.cli.core: Found a match in the command table.
cli.azure.cli.core: Raw command  : provider register
cli.azure.cli.core: Command table: provider register
cli.knack.cli: Event: CommandInvoker.OnPreCommandTableTruncate [<function AzCliLogging.init_command_file_logging at 0x000001D3E64503A0>]
cli.azure.cli.core.azlogging: metadata file logging enabled - writing logs to 'C:\Users\dusan.zakic.azure\commands\2023-11-07.13-58-59.provider_register.9564.log'.
az_command_data_logger: command args: provider register --namespace {} --debug
cli.knack.cli: Event: CommandInvoker.OnPreArgumentLoad [<function register_global_subscription_argument..add_subscription_parameter at 0x000001D3E6453010>]
cli.azure.cli.core.profiles._shared: Traceback (most recent call last):
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/profiles/_shared.py", line 655, in _get_attr
AttributeError: module 'azure.mgmt.resource.resources.v2022_09_01.models' has no attribute 'ExemptionCategory'
cli.knack.cli: Event: CommandInvoker.OnPostArgumentLoad []
cli.knack.cli: Event: CommandInvoker.OnPostCommandTableCreate [<function register_ids_argument..add_ids_arguments at 0x000001D3E64A9000>, <function register_cache_arguments..add_cache_arguments at 0x000001D3E64A9120>]
cli.knack.cli: Event: CommandInvoker.OnCommandTableLoaded []
cli.knack.cli: Event: CommandInvoker.OnPreParseArgs []
cli.knack.cli: Event: CommandInvoker.OnPostParseArgs [<function OutputProducer.handle_output_argument at 0x000001D3E3B5FF40>, <function CLIQuery.handle_query_parameter at 0x000001D3E3DAD2D0>, <function register_ids_argument..parse_ids_arguments at 0x000001D3E64A9090>]
cli.azure.cli.core.commands.client_factory: Getting management service client client_type=ResourceManagementClient
cli.azure.cli.core.auth.persistence: build_persistence: location='C:\Users\dusan.zakic\.azure\msal_token_cache.bin', encrypt=True
cli.azure.cli.core.auth.binary_cache: load: C:\Users\dusan.zakic.azure\msal_http_cache.bin
urllib3.util.retry: Converted retries value: 1 -> Retry(total=1, connect=None, read=None, redirect=None, status=None)
msal.authority: openid_config = {'token_endpoint': 'https://login.microsoftonline.com/5442ad35-e3c2-4ad7-ad38-e30286b48083/oauth2/v2.0/token', 'token_endpoint_auth_methods_supported': ['client_secret_post', 'private_key_jwt', 'client_secret_basic'], 'jwks_uri': 'https://login.microsoftonline.com/5442ad35-e3c2-4ad7-ad38-e30286b48083/discovery/v2.0/keys', 'response_modes_supported': ['query', 'fragment', 'form_post'], 'subject_types_supported': ['pairwise'], 'id_token_signing_alg_values_supported': ['RS256'], 'response_types_supported': ['code', 'id_token', 'code id_token', 'id_token token'], 'scopes_supported': ['openid', 'profile', 'email', 'offline_access'], 'issuer': 'https://login.microsoftonline.com/5442ad35-e3c2-4ad7-ad38-e30286b48083/v2.0', 'request_uri_parameter_supported': False, 'userinfo_endpoint': 'https://graph.microsoft.com/oidc/userinfo', 'authorization_endpoint': 'https://login.microsoftonline.com/5442ad35-e3c2-4ad7-ad38-e30286b48083/oauth2/v2.0/authorize', 'device_authorization_endpoint': 'https://login.microsoftonline.com/5442ad35-e3c2-4ad7-ad38-e30286b48083/oauth2/v2.0/devicecode', 'http_logout_supported': True, 'frontchannel_logout_supported': True, 'end_session_endpoint': 'https://login.microsoftonline.com/5442ad35-e3c2-4ad7-ad38-e30286b48083/oauth2/v2.0/logout', 'claims_supported': ['sub', 'iss', 'cloud_instance_name', 'cloud_instance_host_name', 'cloud_graph_host_name', 'msgraph_host', 'aud', 'exp', 'iat', 'auth_time', 'acr', 'nonce', 'preferred_username', 'name', 'tid', 'ver', 'at_hash', 'c_hash', 'email'], 'kerberos_endpoint': 'https://login.microsoftonline.com/5442ad35-e3c2-4ad7-ad38-e30286b48083/kerberos', 'tenant_region_scope': 'EU', 'cloud_instance_name': 'microsoftonline.com', 'cloud_graph_host_name': 'graph.windows.net', 'msgraph_host': 'graph.microsoft.com', 'rbac_url': 'https://pas.windows.net'}
msal.application: Broker enabled?  You can monitor using 'az provider show -n microsoft.media'
cli.knack.cli: Event: CommandInvoker.OnTransformResult [<function _resource_group_transform at 0x000001D3E647A440>, <function x509_from_base64_to_hex_transform at 0x000001D3E647A4D0>]
cli.knack.cli: Event: CommandInvoker.OnFilterResult []
cli.knack.cli: Event: Cli.SuccessfulExecute []
cli.knack.cli: Event: Cli.PostExecute [<function AzCliLogging.deinit_cmd_metadata_logging at 0x000001D3E64505E0>]
az_command_data_logger: exit code: 0
cli.main: Command ran in 3.385 seconds (init: 1.049, invoke: 2.335)
telemetry.main: Begin splitting cli events and extra events, total events: 1
telemetry.client: Accumulated 0 events. Flush the clients.
telemetry.main: Finish splitting cli events and extra events, cli events: 1
telemetry.save: Save telemetry record of length 3328 in cache
telemetry.main: Begin creating telemetry upload process.
telemetry.process: Creating upload process: "C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe C:\Program Files\Microsoft SDKs\Azure\CLI2\Lib\site-packages\azure\cli\telemetry_init.pyc C:\Users\dusan.zakic.azure"
telemetry.process: Return from creating process
telemetry.main: Finish creating telemetry upload process.
Expected behavior
Terraform successfully registers the provider after running plan.
Environment Summary
Terraform 1.6.3
az cli 2.53.1
Additional context
No response

Thank you for opening this issue, we will look into it.

I am also getting this problem with micosoft.media not registering during plan and the resource provider remaining stuck in registering in Azure.

The same issue here. Additionally, if you click "Unregister" in the portal it will stick in the "Unregistering" state. It seems it's not the issue with azcli itself, but something with the provider registration on Azure side.

I have the same issue. Running terraform plan I received the following:
Original Error: Cannot register providers: Microsoft.Media. Errors were: waiting for Subscription Provider (Subscription: "xxxxxxxxxxxxx"
│ Provider Name: "Microsoft.Media") to be registered: context deadline exceeded
Mine here has been running the register command for almost 4 hours now.

Yeah I've just hit this too on a new subscription

Same here, I noted problem in new subscription today. Same terraform module works in "old" subscription but not in "new" one.
Problem is the same as @rmxuser describe - Microsoft.Media registration.
I've manually registered service via azure CLI and verified the result. Media is registered but for some reason, issue persist.
Thanks.

Hello,
Same problem here by using Terraform and Azure DevOps Pipeline. Registering is stuck for 4h now .

Hello again,
I found a workaround:
$subscriptionId = ""; # replace with subscription GUID
Connect-AzAccount;    # Not needed if running from Cloud Shell on Azure Portal
$token = (Get-AzAccessToken).Token;
$res = Invoke-WebRequest https://northcentralus.management.azure.com/subscriptions/$subscriptionId/providers/microsoft.media/register?api-version=2021-04-01 -Headers @{ 'Authorization' = "Bearer $token" } -Method Post;
#Validate registration state. It can take a couple of mins for registration to complete.
$provider = Invoke-WebRequest https://management.azure.com/subscriptions/$subscriptionId/providers/microsoft.media?api-version=2021-04-01 -Headers @{ 'Authorization' = "Bearer $token" };
($provider.Content | ConvertFrom-Json).registrationstate        # Should print out Registered

Nice workaround I'm going to give it a go now!
Looking in the network inspector when clicking register in the azure portal it seemm to use the 2014-04-01 api.
{
"requests":[
{
"httpMethod":"POST",
"name":"{id}",
"requestHeaderDetails":{
"commandName":"Microsoft_Azure_Resources.RPStatus.registerRP"},
"url":"/subscriptions/{id}/providers/microsoft.media/register?api-version=2014-04-01-preview"}
]
}

Hi , I'm hitting a same issue on a new subscription.

Still stuck in "Registering" over here even after trying @SerreRom 's suggestion.

Microsoft.media stuck on "registering" state using Terraform...
The same deployment runs perfectly in a different (older and already configured) subscription.
Seems to be an issue with the registering procedure.

Thank you @SerreRom, but for me still in a stuck state for some reason:

For those who want to try, don't forget to change this URL to the location you usually deploy:
" https://northcentralus.management.azure.com"   Mine becomes: "https://uksouth.management.azure.com"
Not sure if it makes a difference, but northcentralus didn't work for me.

haven't tried the workaround that is mentioned by @SerreRom but the api-version 2021-04-01 is not listed on the portal.

Thank you @SerreRom, but for me still in a stuck state for some reason:

For those who want to try, don't forget to change this URL to the location you usually deploy:
" https://northcentralus.management.azure.com"   Mine becomes: "https://uksouth.management.azure.com"
Not sure if it makes a difference, but northcentralus didn't work for me.

I had the same thing but when I went into the portal it said that Microsoft.media was registered

It finally switched to registered for me on all three new subscriptions. I will post an update if i have any more issues on new subscriptions that i will probably provision soon.

I can also confirm that the status has been changed to "registered" in the portal:

I left it for the night and now it is showing as registered as well for me.


Issue with k8s.io/docs/reference/issues-security/security/

please delete any contribution with me..tq!

@hariz22 can you clarify the change that you want to happen?
/triage needs-information


FFmpegMergerPP:  handle "malformed AAC bitstream" error when merging

Please follow the guide below
Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Bug fix
[ ] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Enhancement to FFmpegMergerPP:  If merging fails because of a "malformed AAC bitstream" automatically the option -bsf:a aac_adtstoasc is applied and a second attempt is made.
This pull request is loosely related to #24488.  Please see #24309 for details.

https://github.com/ytdl-org/youtube-dl/blob/049c0486bbd57a9bb5fb5a6a5eeff82fd4ac03ff/youtube_dl/postprocessor/ffmpeg.py#L571-L583

In the current implementation FFmpegFixupM3u8PP isn't used by the Nexx extractor, only FFmpegMergerPP.
Please have a look at my comment: https://github.com/ytdl-org/youtube-dl/issues/24309#issuecomment-604617023  Thank you.


qat: improve qat_dpdk_app, openssl-qat-engine

Fixes: #1687
Fixes: #1705

drop generic from qat_dpdk_app
add compress-perf to e2e
make openssl-qat-engine use ubuntu 24.04 and drop all custom builds
drop e2e tests for qat generic

sorry for not changing to draft before you already made comments.
Thanks for the comments though. I was just commiting the changes to this commit not to lose the work.

I guess because of the last commit of 3 commits cd/validate does not pass.
Give your opinion about the change of the name of the app crypto-perf that does not make sense to me.

Please give your opinion about the change of the name of the app crypto-perf that does not make sense to me.

You're right that the name is a bit misleading but we cannot rename it for now (getting a better name does not justify the amount of work/changes needed outside of this repository).

Please give your opinion about the change of the name of the app crypto-perf that does not make sense to me.

You're right that the name is a bit misleading but we cannot rename it for now (getting a better name does not justify the amount of work/changes needed outside of this repository).

I understood, and I somewhat guessed it would not be possible to change. Let me drop the last commit then.

Fixes: #1687

This isn't fixing all of it. I'm noticing I did not have the issue tasks defined very clearly. I think it would make more sense to rework the commits so that you get to run the tests on e2e-qat until #1699 is available. That is, make the kustomization changes but keep .yamls using generic. What do you think?

I am now confused.
Umm, how do you want to keep generic?
As an overlay of each case?

Umm, how do you want to keep generic?

I proposed to make it so that it's possible to keep using e2e-qat (and DPDK tests running) for now but with all the cleanup done. This PR drops generic but it also stops running the tests

I'd still suggest we get the big chunk of changes tested + merged on the old setup. There's a lot of unrelated things blocked by e2e-spr gaps (too old kernel for the compress-perf fix)


Testing Parse Server's capability and pricing on AWS

I have set up parse-server-example on AWS micro instance (free-tier) for testing purposes. I want to see how many requests it can handle before failing. To do this I also need your help to properly test in a real time scenario. I will write up an Android app just to make some dummy requests to parse server and will upload the APK soon on Drive. Please download it and make the bulk requests on April 10 12:00PM GMT. Anyone interested?

I do not recommend testing against any AWS instance that doesn't provide guaranteed Compute Units (nano, micro, and even the T2 small, medium, and large instances only give "Burstable" ECU). In my experience, testing on anything in that category leads to wildly erratic performance numbers, as the CPU will be periodically throttled to limit your usage to the burst credits that you have accrued.
Depending on your own computer and network connection, you might be able to generate a significant amount of load yourself by using Apache Bench.

This is not really an issue here
For implementation related questions or technical support, please refer to the Stack Overflow and Server Fault communities.


build: allow unified builds on Windows

We cannot query the location of the clang target when clang is built in
a unified build.  Use a generator expression instead.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please smoke test

Does the generator expression work in non-unified builds too? Can we just use it all the time?

No, it wouldn't work on standalone builds since it needs a target :-(

@swift-ci please smoke test

@swift-ci please smoke test

Aw, I was hoping the CMake exports file would make things that qualified as valid targets. Okay.

Yes, CMake exports would count as valid targets, unfortunately, we do not currently use that for the standalone builds.  I've been migrating to the exports files as part of the new Swift support in CMake (libdispatch is now exporting the targets for use in Foundation/XCTest).

Wait, if Im doing a get_target_property - I should be able to use the generator expression everywhere.  Thanks @jrose-apple!

@swift-ci please smoke test Linux platform

@swift-ci please smoke test Linux platform

@swift-ci please smoke test and merge

@swift-ci please smoke test and merge

@swift-ci please test macOS platform

Build failed
Swift Test OS X Platform
Git Sha - df85e322dc7ddcd6c8c1286059a5dab51e89f15e

@swift-ci please test macOS platform

@swift-ci please smoke test


[#3806] Setting WRITE_BUFFER_LOW_WATER_MARK before WRITE_BUFFER_HIGH_…

…WATER_MARK results in an internal Exception
Motivation:
Setting the WRITE_BUFFER_LOW_WATER_MARK before WRITE_BUFFER_HIGH_WATER_MARK results in an internal Exception (appears only in the logs) if the value is larger than the default high water mark value. The WRITE_BUFFER_HIGH_WATER_MARK call appears to have no effect in this context.
Setting the values in the reverse order works.
Modifications:

deprecated ChannelOption.WRITE_BUFFER_HIGH_WATER_MARK and
ChannelOption.WRITE_BUFFER_LOW_WATER_MARK.
add one new option called ChannelOption.WRITE_BUFFER_WATER_MARK.

Result:
The high/low water mark values limits caused by default values are removed.
Setting the WRITE_BUFFER_LOW_WATER_MARK before WRITE_BUFFER_HIGH_WATER_MARK results in an internal Exception (appears only in the logs) if the value is larger than the default high water mark value. The WRITE_BUFFER_HIGH_WATER_MARK call appears to have no effect in this context.
Setting the values in the reverse order works.

@Scottmitch @jiafu1115 @trustin @nmittler PTAL

Also /cc @rkapsi

LGTM and thanks for fixing this long forgotten ticket.

ship it

LGTM sans a few nits

Cherry-picked into 4.1 as 3e5dcb5f3efbb26d5e6cf4cd229b03c285d62462.
@jiafu1115 thanks again!


Doesn't work

I can't get OGC to work the last message I see in terminal is "Initializing CustomDraw" and the menu never comes up in-game. I've tried running OGC and battlefront 2 as admin.
Log Output:
[INFO] Directory already exists at C:\Users\rmess\AppData\Local\Temp\OpenGameCamera\2022.01.20-030356
[INFO] found SWBF2 at pid 13536
[INFO] LoadLibraryW found at 00007FFFB781FEE0
[INFO] memory allocated in SWBF2: 0x00000000006E0000
[INFO] wrote 170 bytes to allocated memory
[INFO] OGC injected into SWBF2: threadId=13276
[INFO]

SOLVED - It was a conflict with OGC and  MSI afterburner. Quitting afterburner fixes the issue.


Feature request：CSS（transform-translate3d）

I think this feature will have a lot of people needing :+1:

Yes, it would be useful for slick slider for example

yes I need this too I can't take a screenshot of a div with a slider inside :(


Add music functions to the UI

In this branch I:

Added function to display all music
Added function to display all genres
Added function to create new music

Project Approved 👍
Hi @NduatiKagiri , This is @mrjuda  your code reviewer.
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding! 👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me [@mrjuda] in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Add support for Unreal Engine 4.27

Pull Request Title:
Add support for Unreal Engine 4.27
Pull Request Description:
Hello! I really enjoyed using your plugin, and I needed to adjust it to work with an Unreal Engine 4.27 project. This pull request includes modifications to add support for UE4.27.
Summary of Changes
Replaced some UE5-specific modules with equivalent or alternative modules available in UE4.27.
Updated unsupported macros and functions to compatible versions in UE4.27, while keeping the original functionality intact.
Notes
No changes were made to the setup process, so the integration steps remain the same.
All adjustments were made to ensure compatibility without altering the primary logic of the plugin.
Thanks for considering this contribution! I’d be happy to discuss any adjustments or improvements if needed.

Thank you for your love for this project! I'm very sorry for seeing it so late. I'll check it this weekend.

Thanks man ^^


Spike: Expose graceful failure conventions for model configuration to the API

Context:
Model configuration such as model name, modalities, max context length, and other defaults are currently stringly typed across multiple services. This can lead to rapid development cycles being brittle, or production failures due to re-configuration of model backends or APIs.
Tracking issue for solutions to this problem. Some options:

Graceful fallback to defaults
Service discovery...?

If issues related to this arise, we will address them.


Renamed capitalized acronyms to camel-case

Issue #135
Renamed the following names:
- toJSONString
- handleHTTPPost
- handleHTTPOptions
- printJSONMessage
- fromJSONString
- fromJSONDict
- toJSONDict
- HTTPClient

+1; thanks @dcolligan. I'd like to merge this ASAP to minimise disruption - @pashields, any objections?

Looks good, merging.


WiFi Connectivity issues

I'm having connectivity issues with my NUKI Hub.
It would start by missing some pings and eventually completely dropping the connection.
Now I have enabled these option that I saw being recommended in an other topic.
"Restart if bluetooth beacons not received" to 60 seconds
"Restart on disconnect".
Since I made this change (30min ago), I have a constant ping open to the NUKI Hub and the connection dropped 2 times, but came back online this time. So the restart option seems to help.
Here you can see the pings that go missing:

Reply from <IP_ADDRESS>: bytes=32 time=51ms TTL=254
Reply from <IP_ADDRESS>: bytes=32 time=165ms TTL=254
Reply from <IP_ADDRESS>: bytes=32 time=303ms TTL=254
Reply from <IP_ADDRESS>: bytes=32 time=90ms TTL=254
Reply from <IP_ADDRESS>: bytes=32 time=100ms TTL=254
Request timed out.
Request timed out.
Request timed out.
Request timed out.
Request timed out.
Request timed out.
Request timed out.
Request timed out.
Request timed out.
Request timed out.
Request timed out.
Reply from <IP_ADDRESS>: bytes=32 time=177ms TTL=254
Reply from <IP_ADDRESS>: bytes=32 time=216ms TTL=254
Reply from <IP_ADDRESS>: bytes=32 time=101ms TTL=254

When this happens I see this happing via the console window:

Attempting MQTT connection
MQTT: Connecting without credentials
MQTT connected
HASS setup for lock completed.
-> FROM here
Attempting MQTT connection
MQTT: Connecting without credentials
MQTT disconnected. Reason: TCP_DISCONNECTED
MQTT connect failed, rc=Free Heap: 101396
Attempting MQTT connection
MQTT: Connecting without credentials
MQTT disconnected. Reason: TCP_DISCONNECTED
MQTT connect failed, rc=Free Heap: 101600
Attempting MQTT connection
MQTT: Connecting without credentials
MQTT disconnected. Reason: TCP_DISCONNECTED
MQTT connect failed, rc=Free Heap: 113544
Attempting MQTT connection
MQTT: Connecting without credentials
MQTT disconnected. Reason: TCP_DISCONNECTED
MQTT connect failed, rc=Free Heap: 114588
Attempting MQTT connection
MQTT: Connecting without credentials
MQTT connected
HASS setup for lock completed.
-> TO here

My system information:

NUKI Hub version: 8.31
run: true
deviceId:<PHONE_NUMBER>
deviceIdOp:<PHONE_NUMBER>
mqttbroker: <IP_ADDRESS>
mqttport: 1883
mqttuser:
mqttpass:
mqttlog: false
lockena: true
mqttpath: nuki
openerena: false
mqttoppath:
maxkpad:
opmaxkpad:
mqttca:
mqttcrt:
mqttkey:
hassdiscovery: homeassistant
dhcpena: false
ipaddr: <IP_ADDRESS>
ipsub: <IP_ADDRESS>
ipgtw: <IP_ADDRESS>
dnssrv: <IP_ADDRESS>
nwhw: 1
rssipb: 60
hostname: nukihub
nettmout: -1
restdisc: true
rstbcn: 60
lockStInterval: 1800
configInterval: 3600
batInterval: 1800
kpInterval: 1800
kpEnabled: false
accLvl: 0
regAsApp: false
nrRetry: 3
rtryDelay: 100
crdusr: ***
crdpass: ***
pubauth: false
pubdbg: false
prdtimeout: 60
hasmac: false
macb0:
macb1:
macb2:
MQTT connected: Yes
Lock firmware version: 4.0.37
Lock hardware version: 8.3
Lock paired: Yes
Lock PIN set: No
Lock has door sensor: No
Lock has keypad: No
Network device: Built-in Wifi
Uptime: 28 minutes
Heap: 93540
Stack watermarks: nw: 6104, nuki: 680, pd: 232
Restart reason FW: ConfigurationUpdated
Restart reason ESP: ESP_RST_SW: Software reset via esp_restart.

My ESP32:
ESP32-WROOM-32D
(Is there a better ESP32 you can recommend?)
My network environment is run on Unifi.

I'm closing here, let's follow up in issue #236


Incorrect hover activity on the 'filter by categories' in the search view on mobile

Current behavior

On mobile devices after clicking on the chosen filter, and then clicking on it to switch it off, the hover remains visible. This may confuse the user which filters are currently being applied.

Expected behavior

After clicking on the chosen filter to switch it off, hover should disappear.
Steps to reproduce the issue

The problem appears on https://demo.storefrontcloud.io/ and https://next.storefrontcloud.io

Go to https://demo.storefrontcloud.io/ on a mobile device
Open search window by clicking on the loupe
Type a word, for example, 'top'
Click on any filter
Unclick chosen filter

Can you handle fixing this bug by yourself?

[ ] YES
[x] NO

Which Release Cycle state this refers to? Info for developer.
Pick one option.

[ ] This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[ ] This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[x] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

Browser: Chrome, Firefox
OS: Android, v7 on Samsung Galaxy S8

I am working on it

Thanks @idodidodi! :)


bugs on 2062 jeth calendar

bugs on 2062 jeth calendar

Thanks @dgfool , the issue has been identified and resolved.

@TheCrossLegCoder when you will publish those fixes as release btw?

@TheCrossLegCoder The issue has been closed, but the package has not been deployed yet, which is causing some production issues. We hope you can deploy it as soon as possible. We greatly appreciate your contribution to the .NET developer community in Nepal.
FYI @dgfool

@neapes new version is now deployed in nuget : 2.0.1
I was actually working on verifying all the dates before publishing. But here you go for now.

@TheCrossLegCoder thanks for quick action.
FYI @dgfool


add slackpkg, fix readme leaving out mageia

kept this as a separate branch so that it'd be easier to implement, i guess? includes the relocation of nix i had done in #19, and if either get done before the other, and i notice it: ill merge it to be with the latest lol

You'll need to remove 333e92f from this branch. Also, update the readme for both this and the other PM you added.

oh, whoops! yeah, ill get on that.

Huh, neat. I can request review from myself.

@willeccles that should do it!

@willeccles should be up to standard now; should i reorder the script to be in alphabetical order as well?

@willeccles should be up to standard now; should i reorder the script to be in alphabetical order as well?

No, we have them in the order they are for some reason that I can't remember. The order within the script isn't really important so long as the order of the cases at the bottom and the order of the respective functions matches.

I'm fairly certain that you haven't read CONTRIBUTING.md - being that this uses ls, and you suggested both cat and grep in my PR.

Do not rely on coreutils; if you need to use something from coreutils, you should write a shell function to do it. See tot and has, for example.

I'm fairly certain that you haven't read CONTRIBUTING.md - being that this uses ls, and you suggested both cat and grep in my PR.

Do not rely on coreutils; if you need to use something from coreutils, you should write a shell function to do it. See tot and has, for example.

oh; i-
yeah i have no excuse: i wasnt sure what coreutils were.
i did read through the CONTRIBUTING.md, i guess just not enough.

but honestly i think that slackware is a distro that just happens to be so backwards that it expects you to use ls to view the packages that you have.


Add reference recommendations to usage docs

Adds a section to the usage docs providing more information and recommendations about reference files. Fixes #1086.
PR checklist

[x] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repository.
[ ] Make sure your code lints (nf-core lint).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[ ] Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
[x] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).

I've opened this a draft as I think it would be good to get more comments etc. before merging. Most of the checklist didn't seem relevant for a docs only change and I wasn't sure how to edit CHANGELOG.md.

Good suggestions on content, but much of this is already covered, if at a lower level of detail, in the pre-existing material.
I've suggested some minor improvements to flow etc of your additions, but in general these need to be worked into existing sections to make sure we're not repeating ourselves.

This was just a bit of an information dump to start with but I agree it makes sense to combine with what is already there. I guess I overlooked it because it is an "options" section further down and I figured that was more about the technical details of the different arguments and not so much the broader question of which genome/annotation to use. Could we move the combined section closer to the start as it's likely to be relevant to more users than the options sections?

Good suggestions on content, but much of this is already covered, if at a lower level of detail, in the pre-existing material.
I've suggested some minor improvements to flow etc of your additions, but in general these need to be worked into existing sections to make sure we're not repeating ourselves.

This was just a bit of an information dump to start with but I agree it makes sense to combine with what is already there. I guess I overlooked it because it is an "options" section further down and I figured that was more about the technical details of the different arguments and not so much the broader question of which genome/annotation to use. Could we move the combined section closer to the start as it's likely to be relevant to more users than the options sections?

Let's postpone reorganisation for a future PR (@drpatelh may have views), and stick with the new content integration for the moment.

@pinin4fjords I've incorporated your suggestions and moved the new content to the existing sections

Thanks alot for this @lazappi ! We will include it in the next release!
Would love for @tdanhorn @MatthiasZepper to give this a once over too since they were involved in discussions in the parent issue.
PS: I also sent you an invite to become a member of the nf-core community on Github. Hopefully, future contributions won't have to be approved on PRs.


Unrar not working on arm (soyoustart)

Hi, I have tried the following command but it´s not working in Debian 9 32 bits, I have got this message:
"/var/www/rutorrent/plugins/unpack/unrar_dir.sh: line 13: /bin/unrar: cannot execute binary file: Exec format error"
apt-get remove -y unrar-free && cd /tmp && wget https://www.rarlab.com/rar/rarlinux-5.5.0.tar.gz && tar -xzf rarlinux-5.5.0.tar.gz && cd /tmp/rar && cp /tmp/rar/rar /bin && cp /tmp/rar/unrar /bin
Thanks

Well I fixed it:
nano /etc/apt/sources.list
Paste:
deb http://ftp.us.debian.org/debian/ stretch main contrib non-free
deb-src http://ftp.us.debian.org/debian/ stretch main contrib non-free
deb http://security.debian.org/debian-security stretch/updates main contrib non-free
deb-src http://security.debian.org/debian-security stretch/updates main contrib non-free
deb http://ftp.us.debian.org/debian/ stretch-updates main contrib non-free
deb-src http://ftp.us.debian.org/debian/ stretch-updates main contrib non-free
sudo apt-get update sudo apt-get dist-upgrade sudo apt-get install unrar
Regards

the best solutions are the ones people come up with themselves :) Glad you got it working.


⚠ Bofrost.de has degraded performance

In 04b9f4a, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1118 ms

Resolved: Bofrost.de performance has improved in b89213a after 35 minutes.


Conversion error: Get Dictionary Value failed because Shortcuts couldn't convert from Text to Dictionary.

I’ve tried sw-dlt a couple times in the past but always come back to getting stuck on this error. Is there any fix?
Happens on Get Value for output_code in 🔗decodedProps after Url Decode Shortcut Input

Can you share a link that returns this error?

I just took a closer look at it and this was happening with anything I threw at the shortcut.
For now, reinstalling a-shell Mini after doing a full uninstall with documents & data from Settings > General > iPhone Storage has SW-DLT working again.
Thanks for getting back to me, hope this solution sticks and can help anyone else who runs into this issue.

Reopening - I was completely wrong about what was happening here. I get the conversion error whenever sharing a Tiktok link (which yt-dlp fully supports) to the shortcut from the share menu. But copying to clipboard, setting SW-DLT t- check clipboard, and running from Shortcuts manually works fine.
Example link: https://www.tiktok.com/@allthethingsmarine/video/7271337115437255978
Open in Safari (or tiktok app)
Share sheet > SW-DLT
Get Conversion error: Get Dictionary Value failed because Shortcuts couldn't convert from Text to Dictionary.
Not sure what other info I can provide to help but I do notice that this also happens when sharing a Proxitok link to the shortcut. yt-dlp uses the generic extractor for proxitok rather than the built-in Tiktok extractor, so maybe it's something in common to both original Tiktok and the alternative Proxitok urls? Let me know if I can check anything else.
Proxitok example link: https://proxitok.pussthecat.org/@allthethingsmarine/video/7271337115437255978

I found another scenario with similar behavior. If a YouTube short is open in Safari and shared to SW-DLT from the Safari share menu button, you get the Conversion error. Example url: https://m.youtube.com/shorts/UWd_3FxoJXw
But using the share button on the page gives a different url which works fine with SW-DLT. Same url shared from in the YouTube page window: https://youtube.com/shorts/UWd_3FxoJXw?si=11lO1S7oJjisGkdj
The weird thing is that copying and pasting the first url turns it into the second form, which is what SW-DLT receives if I copy to clipboard and pass it to the shortcut manually. I get the m.youtube url from the Safari address bar or if I share it to another shortcut, so I'm assuming that's what SW-DLT gets from the share sheet in the first case. Hope this helps.

Thanks for the link, I will test them!

Ok, here's another one that makes me think it's not a url structure issue. Any twitter post with media shared to SW-DLT from the browser (Safari bottom bar icon) share sheet gives the Conversion error. Example url: https://twitter.com/NPR/status/1646138100035272704
And for me the url is identical in the address bar, copied, etc. Using the share button below post > Share post via ... in the twitter webapp itself to share to SW-DLT from that share sheet does work. So weird. Maybe something to do with the URL vs Article distinction that shortcuts makes?

I have released v3.19 which hopefully fixes some instances of these errors, however I have not been able to reliably reproduce it to know the real reason, so I'm leaving this open for now.
Does anyone else have links they can share that consistently give this error? Please add the following details:

iOS version
Link
Which options you used (fps, resolution, etc)

iOS Version: 17.0.3
Example link: https://www.tiktok.com/t/ZT8DHDB8m/
Steps to reproduce:

Open above link/video in Tiktok App
Tap share ↗ arrow in lower right corner
In second row of share options scroll to the end and tap ... More for system Share Sheet
In Share Sheet tap SW-DLT shortcut
Before any options appear, "Conversion error" appears and ends the shortcut.

It's interesting that it happens before you can even choose what to download. Can you check if this version works?
https://www.icloud.com/shortcuts/29d5c77bfec64d23947bdc849fa047a6

It's interesting that it happens before you can even choose what to download. Can you check if this version works?
https://www.icloud.com/shortcuts/29d5c77bfec64d23947bdc849fa047a6

This version worked for me! Didn’t try the one from a few days before. Thank you so much!

Thanks for checking, this tells me that the issue is caused by actions not failing silently as expected. Apparently they now stop the shortcut.
I will include the fix in the next update (anyone using the above version should have no issue getting the update).


Layout:When NavDrawer or SideNav Pinned, Panel Height overflows beyond content

I'm not sure if this is the default behavior, but when Navdrawer is pinned, the height of the panel component increases resulting in a Vertical scrollbar even when content is not overflowing.
**Desired bhevior: **
Panel vertial scrollbar should not appear when content is not overflowing the screen.

It's definitely a bug. The space shouldn't affect the main panel, maybe it was broken at some moment. Do you have a repository with this example to debug it from there?

Seems to be due to a min-height of 100% set on  'data-reactroot', when removing it, the problem goes away, but not sure what other parts get affected when I remove that.
And it happens with the example in layout Readme.md file
I'm using react-toolbox 2.0.0 beta-6

I tried here to override styling using flex model, but faced an issue when NavDrawer is always visible (theme wrapper was flex: 1, and it overlapped my content making it not usable).
Also Drawer is removed from DOM when not visible, this leads to issues. For example if I use react-router v4 and my Switch tag is a root one, and each Route is wrapped with Layout incl. NavDrawer , after I change route NavDrawer just disappears without animation.
Maybe it could be a good idea to restyle layout with flex taking all this into account.

It should work now! @olegstepura maybe it's a better idea to use flex indeed, but I need to dig deeper and remember the organization. This is going to be a target to be moved to styled components and that will be a good moment to check it out.
What I don't get is the problem with Switch. I've tried it out in a different project and it was working nicely using routes for the content. Maybe you can open a different issue to try to reproduce it?

Well, I need to create a test repo I think. Will open separate issue then.

@javivelasco was this fix included in the release of 2.0.0.beta.7 ? If yes, seems like it's not fixed (scrollbar appears when NavDrawer is opening or is closing (only during animation phase).

Nope sorry, I released before fixing but we can release again :)

@javivelasco let's release again ;)


Be able to see more than 1 aura per indicator

The main issue here is that if you want to use the anchor BOTTOM LEFT for debuffs for example, like really BIG, and want to track multiple debuffs or whatever, it will just show 1 one debuff, the one that you put first on the lines of that anchor. It will be incredibly good for configuration to add an option that multiple auras can be seen per anchor and they arrenge upwards, backwards, right, left, whatever.

I too want this, it's just going to take a while to implement it. I need to refactor a lot of the logic as it is right now to make this more feasible. Hang in there

The more I think about this, the more I wonder if it's necessary. Can you give me a use case where tracking multiple auras in a single spot is required over putting the auras into the 9 spots already provided? Do we need to track more than 9 things at once?
My concern is that the indicators are already very small as it is with 9, let alone if we start adding sub-indicators. The size would be so small to fit them all that it would effectively make the text and icon impossible to see

I remember I wanted this because theres no profile per spec or per class, so when I was using my paladin and then my priest I couldnt see some auras because they were using the same place, ,but yes u have a point, currently im happy with the addon as it is, but i think you should add something per character

There are profile's per spec and per class actually and have been for quite a while. You can find them under the "Profile" menu option

Oh great, do you think its possible to move the anchors though?

For tooltips?

No, like move the actual icon a little to the left or right for example on the party frame or raid frame

Yes that has been implemented for a few weeks now. Check your config panel

I am getting this error
757x RaidFrameIndicators\AuraIndicators.lua:166: Attempt to access forbidden object from code tainted by an AddOn
[string "=[C]"]: in function GetName' [string "@RaidFrameIndicators\AuraIndicators.lua"]:166: in function UpdateIndicators'
[string "@RaidFrameIndicators\EnhancedRaidFrames.lua"]:58: in function <...ceRaidFrameIndicators\EnhancedRaidFrames.lua:58>
[string "=(tail call)"]: ?
[string "=[C]"]: in function `CompactUnitFrame_UpdateAuras'
[string "@FrameXML\CompactUnitFrame.lua"]:101: in function <FrameXML\CompactUnitFrame.lua:54>
Locals:
(*temporary) = ForbiddenNamePlate17UnitFrame {
0 =
WidgetContainer =  {
}
classificationIndicator =  {
}
castBar =  {
}
maxDispelDebuffs = 0
inVehicle = false
optionTable =  {
}
overAbsorbGlow =  {
}
totalAbsorb =  {
}
myHealPrediction =  {
}
aggroHighlight =  {
}
hideCastbar = true
myHealAbsorbRightShadow =  {
}
overHealAbsorbGlow =  {
}
newUnit = true
selectionHighlight =  {
}
myHealAbsorbLeftShadow =  {
}
ClassificationFrame =  {
}
unit = "nameplate17"
unitExists = true
disableMouse = true
otherHealPrediction =  {
}
BuffFrame =  {
}
name =  {
}
totalAbsorbOverlay =  {
}
myHealAbsorb =  {
}
maxBuffs = 0
maxDebuffs = 0
RaidTargetFrame =  {
}
healthBar =  {
}
displayedUnit = "nameplate17"
LoseAggroAnim =  {

Please open a new ticket for issues not related this one

By default, Blizzard will track 3 or so debuffs on frames to that bottom left anchor. In PvP this is useful because often times you pair it with a set of commands to actually extend the amount of debuffs shown per frame. Say I stop using Blizzard default tracking and use "Poison, Magic, Curse, etc." modifiers. Then a person has both Shadow Word: Pain and Vampiric Touch on them it would only show the one instead of pushing it to the side and displaying both magic debuffs. Same thing applies to something like full feral dots. I'm not sure if you support bleed tracking, but being able to see all the feral DoTs on a player at a single time is very valuable. In a PvE aspect, in the Workshop portion of Mechagon there are the mobs that put Arcing Zap on players. This debuff doesn't stack and is instead treated as an individual debuff with each application. Healers more than likely prioritize dispelling the person who has more than one instance of the debuff opposed to the person with just one. However, its hard to tell how many debuffs a person has if only one is available to view at a time. I think that's where the practical application of being able to see more than one aura lies.

Interesting. There are some limitations though, I.e. There's just not enough physical room on eachbindicstor to

Sadly, I don't have the brain for something like that, but I am fairly good with ideas behind systems and not so much the systems themselves.
I'm not sure if this is of any help to you,  but here are the scripts I run when I start my game and plan do PvP or do M+. You can probably make more sense of the scripts than I can, but I believe that they are essentially recreating the debuff anchor and unlocking the amount of debuffs shown. An issue that comes with just using this method for M+ is that with things like Griveous/Challengers burden it doesn't adjust debuffs accordingly and they end up being overwritten and falling under other anchors.
(They're run in this order as well)
Script 1:
/run function sp(f,i) tr="TOPRIGHT";f2=f.debuffFrames;s=f2[1]:GetWidth();f3=f2[i];f3:SetSize(s,s);f3:ClearAllPoints();if i>6 then f3:SetPoint("BOTTOMRIGHT",f2[i-3],tr,0,0) else f3:SetPoint(tr,f2[1],tr,-(s*(i-3)),0) end end
Script 2:
/run function CBF(f,i) bf=CreateFrame("Button",f:GetName().."Debuff"..i,f,"CompactDebuffTemplate");bf.baseSize=22;bf:SetSize(f.buffFrames[1]:GetSize()) end;function mv(f) for i=4,12 do sp(f,i) end end
Script 3:
/run function mv3(f) CompactUnitFrame_SetMaxDebuffs(f,12); if not f.debuffFrames[4] then for i=4,12 do CBF(f,i) end end mv(f) end;hooksecurefunc("CompactUnitFrame_UpdateDebuffs",function(f) if f:GetName():match("^Compact") then mv3(f) end end);

Hi, I'm also very interested in this feature, playing Rdruid, and in my case, i'd like to have Rejuvenation, Germination, Regrowth all in the same spot next to each other
What about letting user add extra indicator, where you select the anchor location (e.g. Top Left) and can set different horizontal and vertical offset.
A solution like this shouldn't require too much refactoring and geta rid of the "not enough room" problem, it basically let's user create new spots wherever they want.

This definitely seems like it could be one approach to this feature, but as Britt said above:

My concern is that the indicators are already very small as it is with 9, let alone if we start adding sub-indicators. The size would be so small to fit them all that it would effectively make the text and icon impossible to see

For your case, assuming you aren't using all 9 anchors, or even if you are they do support horizontal and vertical offset with the recent updates. So you can easily put your HoTs all right next to one another. I know I'm literally no help when it comes to helping with the coding aspect, but I do think that keeping only 9 anchors and growing off of them should be the focus.

I made a fork of an old version (2.3.0) for just this purpose because I needed this for classic, since as a priest I had 10 different buffs to keep track of these to prevent overwriting other priests' buffs as the default UI would not show them.
It's a bit crude of an implementation using 6 preassigned indicators per corner, though it performs very well.
I will try to see if I can bring the changes up to version 3.1. However, the fort also has a number of other features mixed in; A combat toggle and a mouseover bug fix where the auras from this addon would block mouseover casts. So I will see if I can separate them into independent features, before a potential pull request.

Pull requests are welcome! I'm certain you'll have to modify your code a great deal, as it's effectively a different codebase since 2.3.
As to the main topic of this thread, I have ideas for having up to 4 indicators per position, leading to 36 possible indicators. Any more than 4 I feel would be extreme. With 4 we can split one indicator into a 2x2 grid, and the math to resize and reshape these mini-grids dynamically won't be too complex.

I don't know if you're still working on it, but it would be useful!

Any update on this feature? This is very helpful for mythic+. Id like to be able to track my buffs on party members around the frame which is great but I don't want to lose the default blizzard debuff implemtation of having 3 debuffs listed. Sometimes people get multiple debuffs on boss fights that are important to see at the same time.


Update: Catch non-fixable rules that enable the fixable property in require-meta-fixable rule

[ ] Evaluate whether this new violation causes too many false positives when rules use helper functions for reporting violations (which could prevent us from detecting that they are fixable)

I think the solution to this is to put it behind an option (default off) since it may be too aggressive for some people. Will update.


Unquoted format causing unwanted font behavior and rendering

Adds quotes to eot format. Unquoted format causes unwanted font rendering issues. This adds in the quotes to the format, a la the other formats in same line of code.

While I appreciate you taking the time to file a PR, the eot format was made  obsolete by Microsoft in January of 2016, so if you're using Font.js for eot in 2019 still, something has gone horribly wrong, and my advice as this library's author is to not use eot, and use a Font library that is actually getting some active development on it rather than something I wrote back in the days when the webfont landscape was super fragmented, rather than today's unified "use woff/woff2 and that's literally all you need to support any still-supported browser".


JSON serialization for nullable containers

Is there any particular reason for wrapping nullable containers inside of array when deserializing /serializing from/to JSON?
This is blocker for creating a schema which can parse existing JSON structure.

In the Bond, nullable<T> is represented in serialized payloads identically to list<T> for all serialization protocols. At the serialization/deserialization level, this is an elegant, protocol-agnostic way to encode presence/absence of a value. In hindsight, was this perhaps a poor choice five years ago? That's debatable. Can it be changed in the protocols we have today? Nope: that would break a ton of existing serialized data.
Another thing to remember: Bond's Simple JSON protocol isn't intended to parse existing, arbitrary JSON structures. The goal with the Simple JSON protocol is to use valid JSON that is relatively easy to work with using other JSON libraries. However, the goal is not to output fully idiomatic JSON or to be an arbitrary JSON serialization/deserialization library: other libraries already have that covered. Bond focuses more on the efficient manipulation of schematized data across languages and formats.
To parse your existing JSON structures, you could either transform them into JSON that the Simple JSON protocol expects or implement your own parser/transform. Issue #100 tracks the need to have a customer transform example to make solving this sort of problem more accessible to more people.
Hope this helps.

Thanks for detailed answer, I used custom contract resolver for JSON.NET to deserialize JSON and then Bond's binary serializer to wire it to the backend. Though, I'm not sure about performance of this solution.


Print reason for re-running resolver in verbose mode

Looks great! I just have one comment.

I finished this PR and based it off #2424 to be able to get advantage that packages always have names.

@swift-ci please smoke test

@swift-ci please smoke test


Results for minikube_jjb

Test
Result
Retries
Duration (HH:MM:SS)

test_backpack
Pass
0
00:01:43

test_ycsb
Pass
0
00:02:02

test_fiod
Pass
0
00:08:20

test_fs_drift
Pass
0
00:05:49

test_smallfile
Pass
0
00:06:59

test_pgbench
Pass
0
00:02:52

test_iperf3
Pass
0
00:03:13

test_sysbench
Pass
0
00:02:07

test_uperf
Pass
0
00:05:31

test_byowl
Pass
0
00:01:59

test_hammerdb
Pass
0
00:04:06

Results for kni_jjb

Test
Result
Retries
Duration (HH:MM:SS)

test_backpack
Pass
1
00:03:49

test_ycsb
Pass
1
00:04:01

test_fiod
Pass
0
00:11:46

test_fs_drift
Pass
0
00:08:06

test_smallfile
Pass
0
00:09:06

test_pgbench
Pass
0
00:03:17

test_iperf3
Pass
0
00:04:03

test_sysbench
Pass
0
00:02:25

test_uperf
Pass
0
00:05:44

test_byowl
Pass
0
00:02:48

test_hammerdb
Pass
0
00:05:32

@mkarg75 please drop a link to the snafu PR once its in and lets get the image locations updated to cloudbulldozer and then I think we'll be good to go. Thanks!

@mkarg75 please drop a link to the snafu PR once its in and lets get the image locations updated to cloudbulldozer and then I think we'll be good to go. Thanks!

So i guess this means that we wait for the snafu PR to get in and then update this and merge right?

right, I've handed the mssql image to Russ yesterday so that he can add it to the "official" repo. Once that's done I can add the location to my code and file the PR.

right, I've handed the mssql image to Russ yesterday so that he can add it to the "official" repo.


opensearch-java-client: support for multiple transport options

The opensearch-java-client supports different transport options:

Apache HTTP Client 5
AWS SDK Client
RestClient

Currently only the "classic" RestClient is supported.
Apache HTTP Client 5 and AWS SDK Transports shall also be supported

implemented with 1.2.5 (LTS) and 1.3.1


Add Code of Conduct

We recommend that every repo has a code of conduct. If you don’t feel comfortable creating your own Code of Conduct from scratch we highly recommend using one of the templates provided by GitHub. If you do use a template, please read through the template and ensure that you can and will abide by the Code of Conduct.
Please follow these instructions on how to add a Code of Conduct.
Sample: https://github.com/Recode-Hive/Stackoverflow-Analysis/blob/main/CODE_OF_CONDUCT.md

Hi @hereisSwapnil ,
I am Interested in this issue. Could you please assign this issue to me under GSSoC'24

I would like to work on this issue. Please assign it to me.


HIVE-27706 : Backport of HIVE-24693 : Convert timestamps to zoned times without string operations

Backport of HIVE-24693
JIRA URL : https://issues.apache.org/jira/browse/HIVE-27706

Added the change along with other changes in https://github.com/apache/hive/pull/4840 so closing this one.


Create README.md

Created ReadMe from Google assistant  integration page on home assistant website.

Hi @mcarter14777,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

I know that these instructions are outdated but this will serve as a backbone for updating. I will try to configure this addon so I can actually update instructions

I agree. I'll try to find a speaker, microphone and some spare time to try to work through the setup procedure and write some up to date documentation.


refactor tool is a little opinionated :)

RefactorEx changes formatting, for example
[] |> Enum.map(fn a -> a end) |> List.first()

Which is perfectly fine, simple and short enough to be readable and passes any of my formatters
Hitting F2 and renaming a to b results in
[]
|> Enum.map(fn b -> b end)
|> List.first()

Which is fine, but does add an extra 'unnecessary' formatting change and thus a larger, more difficult to read diff
(marginally, this is all minor, but considering it was valid code in the first place I'd say more bug than feature)

Definetily would mark as bug as well specially because of the harder diffs part. I'll take a look soon

Hello, i found the problem. The issue was the placeholder name I was using for the renamers was too long (: name_being_refactored_31_08_2003), so when rendered, it automatically formated the code like that. v0.1.27 is using a way shorter name (:y) and in the test it didn't introduce extra newlines anymore.

Hello, i found the problem. The issue was the placeholder name I was using for the renamers was too long (: name_being_refactored_31_08_2003), so when rendered, it automatically formated the code like that. v0.1.27 is using a way shorter name (:y) and in the tests it didn't introduce extra newlines anymore.


Make attribute + knowledge panels title cards less round (as designed in Figma)

Attribute and knowledge panels title cards have a very round background, whereas the design in Figma is much less rounded.
The large rounding for the health etc. cards should be kept.
Current version of Smoothie:

Design in Figma (corner radius: 8)

A radius of 8px is expected here


Wrong container is referenced in Jascha030\PluginLib\Plugin\PluginApiRegistryAbstract

In get method, return $this->locator->get($id); should be return $this->container->get($id);.
Same goes for has method.

Fixed in 1.0.5


python3Packages.pyuptimerobot: init at 21.11.0

Motivation for this change
Python API wrapper for Uptime Robot
https://github.com/ludeeus/pyuptimerobot
This is a Home Assistant dependency.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 145468 run on x86_64-linux 1

3 packages built:

home-assistant
python38Packages.pyuptimerobot
python39Packages.pyuptimerobot


Json field error

  "dependencies": {
    "@contentful/app-sdk": "4.14.1",
    "@contentful/default-field-editors": "^1.4.10",
    "@contentful/f36-components": "4.48.0",
    "@contentful/react-apps-toolkit": "1.2.14",
    "contentful-management": "10.26.0",
    "react": "17.0.2",
    "react-dom": "17.0.2",
    "react-scripts": "5.0.1"
  },

Hi @j-quelly
Can you post the code that you used to get to this error state? thank you!


PEP styling and some module organisation

Codecov Report

Merging #18 into master will increase coverage by 0.46%.
The diff coverage is 26.95%.

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   12.78%   13.24%   +0.46%
==========================================
  Files           8       15       +7
  Lines        2072     1834     -238
  Branches      547      485      -62
==========================================
- Hits          265      243      -22
+ Misses       1795     1579     -216
  Partials       12       12

Impacted Files
Coverage Δ

maybrain/algorithms/__init__.py
0% <0%> (ø)

maybrain/algorithms/modularity.py
0% <0%> (ø)

maybrain/allen.py
0% <0%> (ø)
:arrow_up:

maybrain/algorithms/others.py
0% <0%> (ø)

maybrain/algorithms/degeneration.py
0% <0%> (ø)

maybrain/braineac.py
0% <0%> (ø)
:arrow_up:

maybrain/algorithms/normalisation.py
0% <0%> (ø)

maybrain/algorithms/robustness.py
0% <0%> (ø)

maybrain/utils/__init__.py
100% <100%> (ø)

maybrain/constants.py
100% <100%> (ø)

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f079d5...9b09ba1. Read the comment docs.


Clerk: Failed to load Clerk on Electron app

[x] Review the documentation: https://clerk.com/docs
[x] Search for existing issues: https://github.com/clerkinc/javascript/issues
[x] Go through package changelog files.
[x] Provide the Frontend API key from your application dashboard.

Package + Version

[ ] @clerk/clerk-js
[x] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[ ] @clerk/localizations
[ ] @clerk/clerk-expo
[ ] @clerk/backend
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/fastify
[ ] @clerk/chrome-extension
[ ] gatsby-plugin-clerk
[ ] build/tooling/chore
[x] electron-react-boilerplate
[ ] other:

Dependencies + versions
Provide a json with the dependencies used in your project (copy paste from yarn.lock / package-lock.json) or a github project / template that reproduces the issue.
Include the @clerk/ packages and their versions!*
Example:
{
  "dependencies": {
    "react": "18.2.0"
  },
  "devDependencies": {
    "@clerk/clerk-react": "4.20.5"
  },
  "peerDependencies": {
    "react": "18.2.0"
  }
}

Browser/OS
I'm using electron-react-boilerplate and downgrade my Electron to version 22.3.14.
Description
I follow example in the docs for @clerk/clerk-react,here is snippet of my App:
        <ClerkProvider publishableKey="pk_xxxxxxxxxxxxxx">
          <Router>
            <Routes>
              <Route path="/" element={<MainWindow />} />
            </Routes>
          </Router>
        </ClerkProvider>

When I open new browserwindow (Chromium), it breaks with error message: Clerk failed to load.
Error trace:
Call Stack
 undefined
  renderer.dev.js:2312:11
 async _IsomorphicClerk.loadClerkJS
  renderer.dev.js:2002:11

After trying vite-boilerplate it resulting in the same error, and further inspection I found that it was caused by Content Security Policy in the HTML file used by electron.
The solution was to allow clerk origin, but since I do not know what to specify, currently I tested it using wild card like this:
    <meta
      http-equiv="Content-Security-Policy"
      content="default-src 'self' ; script-src 'self'; style-src 'self' 'unsafe-inline'; script-src-elem *; connect-src *; worker-src blob: *; img-src *"
    />

But, wildcard seems wrong to me, what should I specify for the script-src-elem, connect-src, worker-src, img-src such that I clerk resources can load but without me allowing everything '*'

@azamuddin Did you update the allowed_origins property for your Electron instance via Clerk Backend API?

Did you mean I have to update it via API? I didn't do that because I thought I do not need to do any API stuff
I thought everything can be configured in the dashboard pages.
This needs to be added in the getting started, perhaps need special page for Electron

@azamuddin what is the solution?

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


proxy avatar for third party using api

Coverage remained the same at 75.713% when pulling f39ca1ecccc5397440716739cc0bfb67c27be900 on proxyAvatar into 4ed752e24bf773ff07ed5631069e1757de28c37d on master.

This broke the gulp website since we were passing the avatar URL to the proxy URL.  You need a better way of communicating these changes.  cc @piamancini

@phated avatars load fine for me on https://gulpjs.com/
what url should we be looking at?

@piamancini I just fixed it but it's been broken for 9 days based on when this was merged.


#10 Updating pipelines, linting, and dependencies.

Codecov Report

Merging #11 (2e8f4e2) into main (8065b0f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #11   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines          293       297    +4
  Branches        45        46    +1
=========================================
+ Hits           293       297    +4

Flag
Coverage Δ

metadata
100.00% <ø> (ø)

metadata-jsonschema
100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

metadata-jsonschema/src/utils.ts
100.00% <100.00%> (ø)


Create example iOS project using redistributable Swift library

[ ] Create a simple iOS project demonstrating use of the library
[ ] Add building the project to CI - as an additional step validating that libraries are built correctly and working

doesn't fit in the time schedule


Content metadata

For issue #4, I added a form with an input for text and a controlled field so users can search for poems filtering by genre. More controlled fields can be added (date ranges, length, etc.) later but this is a start.
I put this form on the home page under the jumbotron, since I think anything more than a basic search form would be too busy to put in the nav bar. Not sure about this location though, since it takes up a bit of prime real-estate :grimacing: What do you all think about creating a dedicated page for conducting advanced searches? Another option might be to add this form as a collapsing/expanding component on the home page.

Maybe have the genre, and more advanced, search form would be better as an expanding/collapsing component on the homepage.  That way it doesn't take up too much space away from the features.  What do you think?

I tested out your code for the genre search form, it all works great, I think that would be a good feature to add to the navigation or maybe an advanced search feature.  I do think that you could add a submit button around line 70 and add a blank field in the list of genres, that way if the result isn't in the drop-down users can still search on their own.

Code looks great! What do you all think about having the form pop open like a modal?

I added a "search" button to the genre/advanced search form. Thanks for catching that @masonpam! I also added a 'None Selected' entry for the controlled genre field.
I implemented @csdarcher's idea to make the advanced search form a modal window in order to keep it from cluttering up the home page. We can add an "Advanced Search" link right next to the "Basic Search" in the navbar. I think that would be the most intuitive place to put it.

I tested out the code in my environment.  It seems like the search bar that was created is gone.

I can see the code under the jumbotron starting at line 64.  But it isn't showing up when I preview it.

I tested a couple different things and when I got rid of class="modal fade" on line 65 the modal came right back.  I think there was an error with code not recognizing spaces.  So the class="modal fade" from line 65 should actually look like class="modal-fade".  I tested this out too and the search area is there when I changed that.
I think your code looks great and with that small change it's ready to merge and deploy.

Adjusted title of pull request to be more descriptive: Content metadata => Advanced Search

Thanks for the review, ya'll! I've added basic and advanced search to the nav bar and the advanced search modal is visible/working now. @masonpam, thanks for testing out the modal. The modal and fade classes seem to be getting properly applied now.


Error installing version 2.1.18

Short description of the problem:
Getting an error when trying to install version 2.1.18
Steps to reproduce:

On Mac OSx, run npm install -g ionic@latest or npm install -g<EMAIL_ADDRESS>I'm getting this error:

npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated<EMAIL_ADDRESS>use uuid module instead
npm WARN deprecated<EMAIL_ADDRESS>use uuid module instead
/usr/local/lib
└── (empty)

npm WARN In<EMAIL_ADDRESS>replacing bundled version of mime-types with<EMAIL_ADDRESS>npm WARN In<EMAIL_ADDRESS>replacing bundled version of cross-spawn with<EMAIL_ADDRESS>npm WARN In<EMAIL_ADDRESS>replacing bundled version of semver with<EMAIL_ADDRESS>npm WARN In<EMAIL_ADDRESS>replacing bundled version of form-data with<EMAIL_ADDRESS>npm WARN In<EMAIL_ADDRESS>replacing bundled version of request with<EMAIL_ADDRESS>npm WARN In<EMAIL_ADDRESS>replacing bundled version of ionic-app-lib with<EMAIL_ADDRESS>npm ERR! Darwin 16.0.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "-g"<EMAIL_ADDRESS>npm ERR! node v7.2.0
npm ERR! npm  v4.0.2
npm ERR! path /usr/local/lib/node_modules/.staging/ansi-392b32ed
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall rename

npm ERR! enoent ENOENT: no such file or directory, rename '/usr/local/lib/node_modules/.staging/ansi-392b32ed' -> '/usr/local/lib/node_modules/ionic/node_modules/cordova-lib/node_modules/ansi'
npm ERR! enoent ENOENT: no such file or directory, rename '/usr/local/lib/node_modules/.staging/ansi-392b32ed' -> '/usr/local/lib/node_modules/ionic/node_modules/cordova-lib/node_modules/ansi'
npm ERR! enoent This is most likely not a problem with npm itself
npm ERR! enoent and is related to npm not being able to find a file.
npm ERR! enoent

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/fotouhm/Infinity-Workspace/UnifiedMobile/Ionic2/npm-debug.log

Here is the out of ionic info on my machine before installation attempt:
Your system information:

Cordova CLI: 6.4.0
Ionic Framework Version: 2.0.0-rc.4
Ionic CLI Version: 2.1.17
Ionic App Lib Version: 2.1.7
Ionic App Scripts Version: 1.0.0
ios-deploy version: 1.9.0
ios-sim version: 5.0.13
OS: macOS Sierra
Node Version: v7.2.0
Xcode version: Xcode 8.2.1 Build version 8C1002

Figured out the solution from the ionic changelog.
Had to remove the older version of ionic-cli first, using:
npm uninstall -g ionic


[SPARK-18608][ML] Fix double-caching in ML algorithms

What changes were proposed in this pull request?
1, For Predictors, add protected[spark] var storageLevel to store the storageLevel of orignal dataset
2, Use dataset.storageLevel instead of dataset.rdd.getStorageLevel to avoid double caching
How was this patch tested?
Existing tests

Test build #73209 has started for PR 17014 at commit 39210f5.

Test build #73209 has finished for PR 17014 at commit 39210f5.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73209/
Test FAILed.

Merged build finished. Test FAILed.

Test build #73213 has started for PR 17014 at commit 1457751.

Test build #73213 has finished for PR 17014 at commit 1457751.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73213/
Test FAILed.

Test build #73214 has started for PR 17014 at commit 845512a.

Test build #73215 has started for PR 17014 at commit bc314b6.

Test build #73214 has finished for PR 17014 at commit 845512a.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73214/
Test FAILed.

Test build #73215 has finished for PR 17014 at commit bc314b6.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73215/
Test FAILed.

Test build #73217 has started for PR 17014 at commit 0b26a1c.

Test build #73217 has finished for PR 17014 at commit 0b26a1c.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73217/
Test FAILed.

Test build #73219 has started for PR 17014 at commit 0298f0c.

Test build #73219 has finished for PR 17014 at commit 0298f0c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73219/
Test FAILed.

It's better if we can fix this without breaking API. Let's allow some time to see if there's a better solution.
Meanwhile, if we have to add the new parameter, can we set some default value?

@srowen @hhbyyh You are right. I will update this without breaking train. Thanks for pointing it out!

Test build #73252 has started for PR 17014 at commit b81eeb7.

Test build #73252 has finished for PR 17014 at commit b81eeb7.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73252/
Test FAILed.

Merged build finished. Test FAILed.

Test build #73253 has started for PR 17014 at commit a3f3bb6.

Test build #73253 has finished for PR 17014 at commit a3f3bb6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73253/
Test PASSed.

ping @hhbyyh ?

Hi @zhengruifeng , is there any update?

@hhbyyh I think I misunderstood your comments in jira. I will update this pr with the new plan: directly add protected var storageLevel in Predictor, without adding setter and getter of it now..

Test build #74921 has started for PR 17014 at commit fca364d.

Test build #74925 has started for PR 17014 at commit 9c58cb3.

Test build #74921 has finished for PR 17014 at commit fca364d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74921/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74925/
Test PASSed.

Test build #74932 has started for PR 17014 at commit 8aefaf1.

Test build #74932 has finished for PR 17014 at commit 8aefaf1.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74932/
Test FAILed.

Test build #74935 has started for PR 17014 at commit b76438c.

Test build #74935 has finished for PR 17014 at commit b76438c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74935/
Test PASSed.

ping @hhbyyh
I updated the PR, can you please help reviewing this? Thank in advance.

I'm trying to refresh my memory and clear the targets on the topic, basically we want to achieve:

Avoid double caching. If Input Dataset is already cached, then we should not cache the internal RDD.

If input Dataset is not cached, some algorithms may need internal RDD caching to avoid warning from MLlib and also to avoid unnecessary re-computation. But I'm not sure about the scope. (Should we add this for all the algorithms? This is a behavior change for many algorithms). I don't think we have an ideal way to detect if a Dataset should be cached (it's parent may be cached already), and thus not sure if we should take action based on the speculative condition.

Avoid public API change.

Let me know if I miss anything. I'll check on code now.

Test build #75414 has started for PR 17014 at commit 52a7b65.

@hhbyyh  Thanks for you comments!  And sorry for this late reply.
I update this PR: 1,limit the scope, only modifiy algorithms in which double-caching already exist
2, add a function handlePersistence to avoid code duplication

Test build #75414 has finished for PR 17014 at commit 52a7b65.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75414/
Test PASSed.

ping @MLnick  Can you help reviewing this?

Jenkins, retest this please

Test build #76663 has started for PR 17014 at commit 52a7b65.

Test build #76663 has finished for PR 17014 at commit 52a7b65.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76663/
Test PASSed.

Merged build finished. Test PASSed.

ping @MLnick  Can you help reviewing this?

Test build #79263 has started for PR 17014 at commit 49d6038.

Test build #79263 has finished for PR 17014 at commit 49d6038.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79263/
Test PASSed.

ping @MLnick ?

Test build #81211 has started for PR 17014 at commit 513a2ef.

Test build #81211 has finished for PR 17014 at commit 513a2ef.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81211/
Test PASSed.

@WeichenXu123 @yanboliang I have updated this PR according to the comments. Thanks.

cc @zhengruifeng
I update my comment you need check again, thanks!
I read the PR again, it still do not resolve double-caching issue in KMeans.
in KMean, your code check
val handlePersistence = dataset.storageLevel == StorageLevel.NONE
supporse the dataset is cached,
handlePersistence will get false, the following code do not persist dataset:
if (handlePersistence) instances.persist(StorageLevel.MEMORY_AND_DISK)
BUT!!
in MLlibKMeans, it will check the storage level the passed in instance RDD, it will still get NONE, so in MLlibKMeans it will cache it again. ==> Double caching.
So this case we need to pass the handlePersistence flag to the mllib implementation code.

@WeichenXu123 Agree that we should pass handlePersistence to mllib impl. Thanks for pointing it out!

@WeichenXu123 Current impl of mllib.KMeans seems do not support caching, it just (log warnings)[https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala#L216] before and after the training. Do we need to cache the RDD in mllib.KMeans?

@zhengruifeng OK. so the the part of KMeans in this PR still works. No need change I think.

I think about this double-cache issue for a few days. One big problem is that, we are hard get precise storage level info. For example, we may add map transform on cached dataset and then pass it to ML algos, which make the storage level info submerged. This big problem make the auto-decision for handlePersistence meaningless.
So my proposal is, add a parameter handlePersistence for these algos, let user to control whether to persistence input data (So if user already persist input data in upstream, he can set the parameter  to false). But we can let the handlePersistence default value to be true for these algo, this won't break the current activity of these algos.
cc @jkbradley @yanboliang @smurching  What do you think about this?  Once we reach consensus this PR can move forward.

@WeichenXu123 That approach sounds reasonable to me.
My main thought (& this might be obvious) is on the implementation level -- as long as we implement this by adding an org.apache.spark.ml.Param named handlePersistence, I think we can maintain binary compatibility. I'd be concerned about making handlePersistence an argument to fit(), which seems like it might break binary compatibility.

@smurching Yes this should be added as a ml.Param, we should not add as an argument.
@zhengruifeng Would you mind update the PR according to our discussion result above ?
Make handlePersistence as a ml.Param (added to these algos, default value be true).
And we don't need to modify the Predictor and any other public interface for now.

@WeichenXu123 Sounds good. And since adding handlePersistence as a ml.Param may influences many algs (more than that in this PR), I think we may need more discussion  @MLnick @yanboliang
And if we add handlePersistence, should we also add a param intermediateStorageLevel to let users choose the storagelevel (like (ALS)[https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala#L216])?

Thanks all for discussing this!  I'm just catching up now.
I'm OK with adding handlePersistence as a new Param, but please do so in a separate PR and JIRA issue.  I'd like to backport the KMeans fix since it's a bug causing a performance regression, but we should not backport the new Param API.

@zhengruifeng @jkbradley I create a PR #19107  for quick fix KMeans perf regression bug.
This PR can continue to work on adding Param of handlePersistence which is not so emergent.
Thanks!

@WeichenXu123 @jkbradley  I am curious about why ml.Kmeans is special that it needs a separate PR

@zhengruifeng KMeans regarded as a bugfix(SPARK-21799) because the double-cache issue is introduced in 2.2 and cause perf regression.
Other algos also have the same issue, but the issue exists in those algos for a long time and they related to Predictor so it is not so easy to fix, we can leave them in here and do more discussion.

Test build #81372 has started for PR 17014 at commit df4d263.

Test build #81372 has finished for PR 17014 at commit df4d263.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81372/
Test FAILed.

Merged build finished. Test FAILed.

Test build #81373 has started for PR 17014 at commit 971e52c.

Test build #81373 has finished for PR 17014 at commit 971e52c.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81373/
Test FAILed.

Test build #81376 has started for PR 17014 at commit f8fa957.

Test build #81376 has finished for PR 17014 at commit f8fa957.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81376/
Test FAILed.

Jenkins, retest this please

Test build #81393 has started for PR 17014 at commit f8fa957.

Test build #81393 has finished for PR 17014 at commit f8fa957.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81393/
Test PASSed.

Hi @zhengruifeng, thanks for your work on this!
Now that we're introducing a new handlePersistence parameter (a new public API), it'd be good to track work in a separate JIRA/PR as @jkbradley suggested so others are aware of the proposed change.
I've created a new JIRA ticket for adding the handlePersistence param here: SPARK-21972. Would you mind resubmitting your work as a new PR that addresses the new JIRA ticket (SPARK-21972)?
Thanks & sorry for the inconvenience!

@smurching OK, I will close this PR and resubmit it to the new ticket.


Update Composer dependencies (2022-01-20-00-09)

Visual regression test passed!
View the visual regression test report


Fix golint issues and add to CI

Fail build build on lint fail...

Is this ticket still relevant with our move to prettier etc.? Closing in favor of #703, but please reopen if still relevant.


Add support for MCBE Preview Realms

For #42
This PR should be fully complete and ready to merge, the only thing that is needed is tests.

Thanks, to avoid a conflict with #40 we can merge this after that

Can you resolve the conflict?

Can you resolve the conflict?

Done.


zammad: fix path to sendmail

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Change is tested and works. This fixes the issue that the application is unable to send mail via local MTA due to it depending on the hardcoded path /usr/sbin/sendmail.

@SuperSandro2000 I think the maintainers had enough time to react. May I ask you to merge the change and backport it to 23.05?


Use placeholders for absolute paths in completionEntryDetails.

This fixes an issue that I know @andrewbranch, @MariaSolOs, and I have run into for replay logs using completionEntryDetails. completionEntryDetails often reuses data from the prior completionInfo request, which can contain absolute paths from the crawler session that are no longer valid for the replaying machine.

This is good, but I think it’s an incomplete fix for use with tsserver-replay. The data also includes a symbolId that’s technically deterministic but very sensitive, and when I tried to use tsserver-replay, the ids were off by 3 and nothing worked. tsserver-replay probably needs to have some special logic for requesting completion details where it uses the real source and data it got from the previous completionInfo request instead of the logic captured in the request log.

Gotcha - so we'll have to do some best-effort work to match up responses or else this still won't work. That's a little frustrating and risky, but it might just be good enough.


Can we reference values.yaml files values in Chart.yaml dependencies section:

Output of helm version:  v3.1.2
Output of kubectl version: v1.21
Cloud Provider/Platform (AKS, GKE, Minikube etc.): AWS EKS
Hello All,
Is there way we can reference values.yaml file values in Chart.yaml dependencies section. One of requirement is we have a umbrella chart, where we want the dependencies chart version to be read from different env values.yaml file, so that we can specify different chart version for subcharts for different env.
Thanks
parasappa

afaik there is no such option yet, see https://github.com/helm/helm/issues/2205

Closing this issue as answered. Please feel free to comment here and let us know if you have further questions. Thanks!


Getting cURL error 60: SSL certificate problem: certificate has expired

Describe the bug
SSL Certificate issue
To Reproduce
A clear test case to reproduce the bug
Expected behavior
A clear and concise description of what you expected to happen.
Additional context
Add any other context about the problem here.

Thank you for reporting.
Please provide a reproduction code sample so that I can look into it.
Few things you might want to check:

Check your SSL certificate in your server
Check out the Guzzlehttp Client library for more details on why you might be getting this issue

Feel free to reopen with a reproduction case.


'gameout' event doesn't get fired

Version

Phaser Version: 3.16.1

Operating system: Windows

Browser:

Description

Callback registered to the 'gameout' event via this.input.on(Phaser.Input.Events.GAME_OUT, callback) from a scene is never invoked when mouse leaves canvas or moves to an overlay. 'gameover' event works fine, though.
Example Test Code

Additional Information

I can confirm this too.

Same problem for me. macOS / Safari.

Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.


fix: quickstart card size and alignment

Description

fix quickstart card size and alignment

Testing required outside of automated testing?

[x] Not Applicable

Screenshots (if appropriate):

[x] Not Applicable

Rollback / Rollforward Procedure

[x] Not Applicable

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.30.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: