Incorrect (?) taxon parsing: Helicopsyche von Siebold 1856

I am not sure if this is a gnverifier issue or ITIS (Integrated Taxonomic Information System) issue.
When the genus Helicopsyche is queried like so through gnverifier API, we get two results from Catalogue of Life and two results from ITIS.
I believe there is a parsing error in the second result from ITIS where in the classificationPath parameter, the last entry is Helicopsyche von but von is part of the authorship von Siebold.
I have not been able to verify if any other taxon identified with an authorship with a suffix (like von Siebold) have the same problem.

thanks for letting us know @BenMerSci, looks like it is classification import script for ITIS that creates the error. Parser does parse the genus correctly: https://parser.globalnames.org/?format=html&names=	Helicopsyche+von+Siebold%2C+1856+&with_details=on
I am working on renewing data sources right now, so very timely observation, I will check if it is my ITIS import script to blame. Hopefully this error will disappear in a couple of weeks

Thank you for the reply Dimus!
I'll check back in a couple of weeks

@BenMerSci, I updated ITIS and some other data-sources, and I do not see the error you spotted anymore. The harvesting is completely new now, and there is some chance I missed something, so if you see other problems, please let me know!

I confirm that it is solved, thank you for the followup @dimus!
I will let you know if I find anything else.


on decimalfield

What's the purpose of DecimalField generally? Coercing possible floats and strings that might look like a decimal.Decimal into one? What about the 'places' arguments for it? Is that the spot at which truncation should happen or otherwise ? Any tips and comments would be helpful 🤯

I'm not sure what you mean. It's purpose is to take string input and create a Decimal object from it. It's no different than any other typed field in that regard.

whats the argument places supposed to do? is it meant to set the decimal places to a certain spot?
i.e - '23.23920320' with places=3 should be equal to Decimal('23.239') ?

Presumably. There's an open issue, #101, that the arguments don't seem to work right now.

heh....go figure. i was wondering if i was going crazy or something. i think i know how to patch it assuming it is not doing what its intended to. thanks! saved me the run around.

Duplicate of #101


Implement expected withdrawals API

Problem description
Latest beacon API spec requires expected withdrawals API

https://github.com/ethereum/beacon-APIs/pull/304

Solution description
Implement the following route:

https://ethereum.github.io/beacon-APIs/#/Builder/getNextWithdrawals

Additional context
No response

I want to work on this issue can you assign to me .

@MujahidAli954 any progress?

It looks learnable. I'd like to assignt it.

I try to point to implement this function.
https://github.com/ChainSafe/lodestar/blob/918924eabad9ca615acf3d92ff50828fb40fedea/packages/state-transition/src/block/processWithdrawals.ts#L65


Add IE to start menu

I'm unable to pin Internet Explorer (IE) to the start menu using this line, Windows 10 1709
<start:DesktopApplicationTile Size="2x2" Column="0" Row="4" DesktopApplicationLinkPath="%APPDATA%\Microsoft\Windows\Start Menu\Programs\Accessories\Internet Explorer.lnk"
any idea/suggestion?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 140f038c-e307-78f0-5165-309e0cf34ca5
Version Independent ID: b1011259-ee05-21a4-5308-aabc8b0dd74b
Content: Configure Windows 10 taskbar (Windows 10)
Content Source: windows/configuration/configure-windows-10-taskbar.md
Product: w10
GitHub Login: @jdeckerMS
Microsoft Alias: jdecker

Are you applying the Start layout using Group Policy or MDM? There's a note in the Start layout XML (https://docs.microsoft.com/en-us/windows/configuration/start-layout-xml-desktop#startdesktopapplicationtile) that says "In Start layouts for Windows 10, version 1703, you should use DesktopApplicationID rather than DesktopApplicationLinkPath if you are using Group Policy or MDM to apply the start layout and the application was installed after the user's first sign-in."

Using group policy. Unfortunately this is a desktop app 'Internet Explorer' not a modern app

DesktopApplicationID entry for IE is: DesktopApplicationID="Microsoft.InternetExplorer.Default"
Also, copy the .lnk to %ALLUSERSPROFILE%\Microsoft\Windows\Start Menu\Programs.

Thanks for the ID. a question, why i need to move the shortcut outside of $appdata$ it works fine for File Explorer but not IE?

I'm not positive that you do, but I found a thread on the forum with a problem similar to yours and that was the solution they found: https://social.technet.microsoft.com/Forums/en-US/d2a5d021-b5d9-4ce2-ba2c-d5bf0baf2345/exportimport-startlayout-doesnt-retain-ie-11-pin

Closing.


Bugs with Cassini Original Target Name

Name: Matthew Tiscareno
Email<EMAIL_ADDRESS>Type: Problem/Bug
Comment: The Cassini Original Target Name has a couple anomalies.
There are two versions of Atlas, one with a colon at the end.  Furthermore, the green numbers for "Atlas" say 42 but when you click on it you get 1607 hits, while the green numbers for "Atlas:" say 0 but when you click on it you get 42 hits.
There are also two versions of N/A.  If you click on either of them, you get a dialog box saying there was an error!
Finally, I'm not sure whether anything can/should be done about this, but the tooltip for Cassini Original Target Name clearly says that you shouldn't use it, but I didn't click on the tooltip until I had been using it for some time: in fact, I didn't click on it until after I realized what it already said, that Intended Target Name is a better choice.

It turns out that these are problems with the COUVIS_0xxx metadata. There really are observations where the cassini target name is "Atlas:".


review dependencies

Review the dependencies in setup.py. I think for most, spare the azure-python-sdk we can live with a > dependency rather than requiring the exact version, dns module is an example.

it would be only relevant for people installing azurectl via 'pyton setup.py build & install' or from pip if we want to make it available there too.
In principal I agree, however you don't know exactly if the program works with another version of the modules.

do we really want to extend the setup.py module requirements to version we don't know if they work ?
That's basically my question and I'm ok if a majority of the team has no problem with it

Python does not have a "multi-version" solution. Thus we need to be a bit more relaxed about the dependencies, IMHO. I agree that there is risk in opening up the dependency, on the other hand I hate to be so paranoid.
Lets get James' thoughts on this.

It seems the python community has an answer for everything, so I went in search for it.
I believe what we want is ~= instead of ==.
See pep440 for details.

Yes, that's the technical detail, question is, are you in favor of opening the range in this way?

Well, yes.
If we're going to do exact version lockdowns, we need to add some automation to read those versions from OBS.
I think that's overkill, when all we really want is to ensure that our stuff works with current stuff. Using the ~= matcher lets us ignore minor changes to the dependencies (which shouldn't break anything, and we don't have time to babysit anyway), but forces us to make a change, and do some testing, on a major change to a dependency.
I think that's the best balance we can achieve with the tools at hand.

I'll took this one because I'm currently working on azurectl due to the $MS review of my SDK patches
James hope you don't mind

Fixed


Grid search YOLOX base_lr

Describe the feature
mim grid search can search optimal lr like followings.
search_args = '--optim_wrapper.optimizer.lr 0.001 0.01 0.2'

But YOLOX lr search has a problem. We should search base_lr instead of optim_wrapper.optimizer.lr because of param_scheduler.
https://github.com/open-mmlab/mmdetection/blob/dev-3.x/configs/yolox/yolox_s_8xb8-300e_coco.py#L175
Config is like following.
base_lr = 0.01
optim_wrapper = dict(
    type='OptimWrapper',
    optimizer=dict(
        type='SGD', lr=base_lr, momentum=0.9, weight_decay=5e-4,
        nesterov=True),
    paramwise_cfg=dict(norm_decay_mult=0., bias_decay_mult=0.))

param_scheduler = [
   ...
    dict(
        type='CosineAnnealingLR',
        eta_min=base_lr * 0.05,  # This part is a problem for lr grid search.
        begin=5,
        T_max=max_epochs - num_last_epochs,
        end=max_epochs - num_last_epochs,
        by_epoch=True,
        convert_to_iter_based=True),
    ...
]

However, we currently do not have the function to properly search lr and param_scheduler by searching base_lr.
Motivation
I request the following features.

mim gridsearch mmdet yolox_s_8xb8-300e_coco.py --work-dir tmp --gpus 1  --search-args '--base_lr 1e-2 1e-3'
Then, along with base_lr, the appropriate optim_wrapper.optimizer.lr and param_scheduler are set and the search can be performed.

Yes, sometime the gridsearch require inter dependant values which is currently not supported. I would like this feature as well.

Hi @okotaku @Chop1 , thanks for the attention to mim gridsearch!
You are totally right that sometimes we need to search for an inter-dependant value that could affect multiple places in the configs.
Currently, I don't have a good solution to address this.
Let's leave this issue open, at some point we need to support it or someone has a good solution. ^_^


Improving C# metadata API

-- lots of improvements in C# metatada API (allow handlers to read request metadata, allow clients to read trailers)
-- populated ServerCallContext with some useful information (metadata, deadline, etc.)
-- ServerCallContext is now the last parameter in server handlers (alpha feedback).
-- added some tests
-- some other small fixes (health check service should now work correctly).

Fixes https://github.com/grpc/grpc/issues/1989


could not build on ubuntu-mate 16.04

Hello.
I am trying to build vicon_bridge from catkin_ws on ubuntu-mate 16.04 installed on raspberry pi 3. The procedure that  I followed for the build is,
1- Download ViconDataStreamSDK from company website to /home/pi/Documents/.
2- Download vicon_bridge from this repository to catkin_ws/src.
3- Set the library path as,
export LD_LIBRARY_PATH=/home/pi/Documents/ViconDataStreamSDK_1.7.1_96542h/Linux32-boost-1.55.0/20170125_96542h.x86/:$LD_LIBRARY_PATH
4- catkin build
However, I am geting a build error as,
Errors     << vicon_bridge:make /home/pi/catkin_ws/logs/vicon_bridge/build.make.010.log
make[2]: *** No rule to make target '/usr/bin/libViconDataStreamSDK_CPP.so', needed by '/home/pi/catkin_ws/devel/.private/vicon_bridge/lib/vicon_bridge/testclient'.  Stop.
make[1]: *** [CMakeFiles/testclient.dir/all] Error 2
make: *** [all] Error 2
cd /home/pi/catkin_ws/build/vicon_bridge; catkin build --get-env vicon_bridge | catkin env -si  /usr/bin/make --jobserver-fds=6,7 -j; cd -
...............................................................................
Failed     << vicon_bridge:make           [ Exited with code 2 ]
Failed    <<< vicon_bridge                [ 3.0 seconds ]
[build] Summary: 0 of 1 packages succeeded.
[build]   Ignored:   None.
[build]   Warnings:  None.
[build]   Abandoned: None.
[build]   Failed:    1 packages failed.
[build] Runtime: 3.1 seconds total.
catkin_make is also not working. Can someone help me?
Thank you so much.

I have meet this same problem,how to settle this problem?thanks...

Hi @cdlwhm1217096231, It never worked for me on 16.04. To solve the problem, I installed Ubuntu 14.04 on my laptop and received the Vicon data. Following this, I used ROS Multimaster Fkie (http://wiki.ros.org/multimaster_fkie) to share the data with my raspberry pi 3 (which has Ubuntu mate 16.04 installed on it) and my laptop (which has Ubuntu 14.04 installed on it).

thank you,my raspberry pi 3 has installed ubuntu 16.04, how to receive the vicon data and use it for fix my robot navigation

U re welcome :) Install Ubuntu 14.04 on another computer and receive the vicon data. Then share the data with your raspberry pi 3 using ros multimaster fkie.

ok,thank you!


Introspect command shouldn't show non supported databases

Do not show SQLite3 in option till introspection is not available for SQLite3.

Related to #51

Closing in favor of #11


I get empty return for this

Can anyone help me to see what's wrong with the following line please?
https://github.com/suntong/lang/blob/820cf694de6b099256f429b9fff91265461eef25/lang/Go/src/ds/structs_example.go#L131-L147
it prints:
map[string]interface {}{}
while the previous test prints the following, which is what I want:
map[string]interface {}{"Servers":[]main.Server{main.Server{Name:"Arslan", ID:123456, Enabled:true}, main.Server{Name:"Arslan", ID:123456, Enabled:true}}}

How to fix it to make it working? Thx!

Hi @suntong  The servers field need to be uppercase, so Servers. Otherwise the reflect package will not read it. Here is the same example: https://play.golang.org/p/rP5q47J3Ke


AES Benchmark

testing: warning: no tests to run
PASS
BenchmarkEncryptAesCbc-8         2000000              6043 ns/op            4112 B/op          9 allocs/op
--- BENCH: BenchmarkEncryptAesCbc-8
        crypt_test.go:33: encryption speed: 135.10 Mbit/s
        crypt_test.go:33: encryption speed: 1595.52 Mbit/s
        crypt_test.go:33: encryption speed: 1678.08 Mbit/s
        crypt_test.go:33: encryption speed: 1771.06 Mbit/s
        crypt_test.go:33: encryption speed: 1801.60 Mbit/s
BenchmarkDescryptAesCbc-8        3000000              4475 ns/op            2048 B/op          7 allocs/op
--- BENCH: BenchmarkDescryptAesCbc-8
        crypt_test.go:56: decryption speed: 315.57 Mbit/s
        crypt_test.go:56: decryption speed: 2388.31 Mbit/s
        crypt_test.go:56: decryption speed: 2354.67 Mbit/s
        crypt_test.go:56: decryption speed: 2458.94 Mbit/s
        crypt_test.go:56: decryption speed: 2454.74 Mbit/s
ok      github.com/meshbird/meshbird/secure     36.253s


Cannot delete cluster build outside of PCM

ParallelClusters created outside of PCM are listed on the PCM main page and there is a functioning Delete button. But PCM has insufficient IAM permissions to delete clusters created outside of PCM, thus the CFN stack wil go to state "DELETE_FAILED".
Error message:
"API: iam:DetachRolePolicy User: arn:aws:sts::XXXXXXXXXX:assumed-role/stesachs-pcluster-manager-ParallelClusterUserRole-1D9BDG028QH9H/stesachs-pcluster-manager--ParallelClusterFunction-yUrGn2AGbR5F is not authorized to perform: iam:DetachRolePolicy on resource: role clustername-Role24989d8ee41c1575-1Q55UE4K27TZ0 because no identity-based policy allows the iam:DetachRolePolicy action"

Thank you, we'll investigate the issue and report here when we fix it

This is also true for clusters created within pcluster manager.

This is also true for clusters created within pcluster manager.

Meaning by creating a cluster on a PCM installation, you cannot manage it or delete it via another PCM installation on the same account?

This may be related to https://github.com/aws/aws-parallelcluster/issues/4031, will keep you posted as soon as we either have a fix or a workaround


VerifyTotp is returning false randomly even Step time is not expired

HI , VerifyTotp is returning false randomly even Step time is not expired. Please suggest us what should we have to do now.

Ensure that your server and client system times are in sync.

Ensure that your server and client system times are in sync.

I'm seeing this too, but running locally with one clock. This is for version 1.2.2. I haven't tested the new version yet.
I saw on Stack Overflow someone else having this issue.. I modified their test loop, results of the first 200 loops.
Is there something I'm missing?
@kspearrin @Anitha-cmd
0
verify-:False-4
verify-:False-33
verify-:False-63
verify-:False-93
100
verify-:False-122
verify-:False-152
verify-:False-182
200

for (int i = 0; i < 10000; i++) {
var clientSecret = "USER1";
var _secretKey = "HIHI-SECRET";
var bytes = System.Text.Encoding.UTF8.GetBytes($"{clientSecret}-{_secretKey}-{i}");
var totp1 = new OtpNet.Totp(bytes, step: 30);
            var t = DateTime.UtcNow;
            var result = totp1.ComputeTotp(t);
            // Console.WriteLine($"{t} - TOTP code: {result}");
            Thread.Sleep(1000);
            var input = result;
            long timeStepMatched;
            var totp2 = new OtpNet.Totp(bytes, step: 30);

            bool verify = totp2.VerifyTotp(DateTime.UtcNow, input, out var window);

            if (!verify) {
                Console.WriteLine("{0}-:{1}-{2}", "verify", verify, i);
            }

            if (i % 100 == 0) {
                Console.WriteLine($"{i}");
            }

        }
        Console.WriteLine("Done Testing");

}

@markbauer1975 , please see https://github.com/kspearrin/Otp.NET#expanded-time-window.
You have not specified a Verification Window, so you are most likely hitting the 30-second boundary.  This is evidenced by your output showing up at almost exactly 30 second intervals.  The first one at 4 seconds is due to the time you started the execution - probably at 0:26 seconds after the top of a minute (4 seconds prior to a 0:30 boundary) or 0:56 seconds (4 seconds prior to the top of a minute).
The documentation explains that absence of the Verification Window essentially means there is none, so any time you create a code and verify it crossing a "top of the minute" or 0:30 "bottom of the minute" boundary, it will fail.
Add a window that includes previous step = 1 and it should not fail using only the 1 second delay specified in your loop.
Better yet, use the RFC-specified window per the docs:
totp.VerifyTotp(totpCode, out timeWindowUsed, VerificationWindow.RfcSpecifiedNetworkDelay);
or using your code:
bool verify = totp2.VerifyTotp(DateTime.UtcNow, input, out var window, VerificationWindow.RfcSpecifiedNetworkDelay);

The following problem assume a default expiry duration of 30 seconds is used.
If I create a new token at 10:15:00 current time, it gets expired at 10:15:30 current time, which is as expected, but when I create a new token at let's say 10:15:28 current time, it is expired after 2 seconds at 10:15:30 time mark, instead of expiring after 30 seconds.
I want my tokens to expire after exact 30 (or N) seconds, no matter I generate them at "top of the minute" or "bottom of the minute" boundaries. Is it possible?

@kspearrin @markbauer1975 @damiarnold @Anitha-cmd
can you help me the below code ,,My problem is that the first time it's false and the second time I create code it's true,
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using OtpNet;
using Microsoft.Extensions.Logging;
namespace DmzApi.Helper.HtopCustom
{
public class HtopCustomHelper : IHtopCustomHelper
{
private readonly ILogger _logger;
    public HtopCustomHelper(ILogger<HtopCustomHelper> logger)
    {
        _logger = logger;

    }

    public bool verifyCode(string code,string key,int sec)
    {
        var result = false;
        try
        {
            //  var bytes = Base32Encoding.ToBytes("JBSWY3DPEHPK3PXP");
            //var key = "MGI3OTNiZDg0OWVkZWM5NGZjNmYxZTJlNTEwMzM4MTZmZjRhZmIwZDhlYmVmMGJiMGM3NzllZjc1MDY5OGFmN2ZmYmFjYWEzZDY5YTBhYzg1YzQyZDQ3MTQ1NTIxZWY5NWE2N2QxOWYwYzczMWU0NzJiYjE1ODEyYWYxMjk3MTk=";

            byte[] data  = System.Convert.FromBase64String(key);
            string decodedString  =  System.Text.Encoding.UTF8.GetString(data);

            //var totp = new Totp(Encoding.ASCII.GetBytes(key), step: 30, OtpHashMode.Sha512);
            _logger.LogInformation("finally get bytes:" + System.Text.Encoding.UTF8.GetBytes(decodedString));

            byte[] serkey = System.Text.Encoding.UTF8.GetBytes(decodedString);
            _logger.LogInformation("verifyCode finally serkey get bytes:" + serkey);
            var totp = new Totp(serkey, step: sec);

            Console.WriteLine("verifyCode");
            Console.WriteLine(decodedString);

            //var totp = new Totp(Encoding.ASCII.GetBytes(key), step: 60, OtpHashMode.Sha512);
            //var totp = new Totp(Encoding.ASCII.GetBytes(key), step: 1, OtpHashMode.Sha512);
            long time;
            result = totp.VerifyTotp(code, out time, null);

            _logger.LogInformation("time:" + time);

        }
        catch (Exception ex)
        {
            throw ex;
        }

        return result;

    }

    public (string, string) createCode(string mobile,int _step)
    {

        var code = "";
        var base64StringKey = "";

        try
        {

            //var bytes = Base32Encoding.ToBytes("JBSWY3DPEHPK3PXP");
            // var key = "MGI3OTNiZDg0OWVkZWM5NGZjNmYxZTJlNTEwMzM4MTZmZjRhZmIwZDhlYmVmMGJiMGM3NzllZjc1MDY5OGFmN2ZmYmFjYWEzZDY5YTBhYzg1YzQyZDQ3MTQ1NTIxZWY5NWE2N2QxOWYwYzczMWU0NzJiYjE1ODEyYWYxMjk3MTk=";
            //var totp = new Totp(Encoding.ASCII.GetBytes(key), step: 60, OtpHashMode.Sha512);
            // var totp = new Totp(Encoding.ASCII.GetBytes(key), step: 30, OtpHashMode.Sha512);
            var now = DateTime.Now;
            //var now = DateTime.Now;
            var key = KeyGeneration.GenerateRandomKey(20);
            // var data = now.Ticks.ToString() + mobile;
            //var data = now + mobile;
            var data = now + mobile;

            // base64StringKey = ticks;
            // var plainTextBytes =  System.Convert.ToBase64String(System.Text.Encoding.UTF8.GetBytes(ticks));
            _logger.LogInformation("createCode");
            _logger.LogInformation("now:" + now);

            base64StringKey = System.Convert.ToBase64String(System.Text.Encoding.UTF8.GetBytes(data));

            byte[] serkey = System.Text.Encoding.UTF8.GetBytes(data);
            _logger.LogInformation("createCode finally serkey get bytes:" + serkey);
            var totp = new Totp(serkey, step: _step);

            code =  totp.ComputeTotp();

            //code = totp.ComputeTotp();

        }
        catch (Exception ex)
        {
            throw ex;
        }

        return (code, base64StringKey);

    }

}

}

my expired time is 90 second

when the randomly return false , the time output is 0

Ensure that your server and client system times are in sync.

How to recalculate the remaining time of each re-generated code, I am using the current timestamp as the key encryption.


fix: builder register procedure

Checklist

[x] I have read the coding guide
[ ] My change requires a documentation update and I have done it
[ ] I have added tests to cover my changes.

Description
Fixes the logger registration procedure so that two identical loggers are not created.

This change is

Closed in favor of #3147


Functions in Kotlin: Android Basics with Compose

URL of codelab
In which task and step of the codelab can this issue be found?
Describe the problem
Steps to reproduce?

Go to...
Click on...
See error...

Versions
Android Studio version:
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

Itsn't option to finish 8 step.


The tag 1.13.0 moved

The tag 1.13.0 is now pointing to 1.14.0 instead of its original commit (e4736e24c6a0eb643e5114ff263903e8f50440f1).
Unfortunately this has spread into Dockerhub and the original autoware/autoware:melodic-1.13.0 also changed.
I suppose this was a mistake during Gitlab -> Github transition(?)

@filiperinaldi this has been fixed now. I think we can close this issue

@filiperinaldi

@filiperinaldi / @sgermanserrano This was done intentionally. We don't consider the Docker repository or CI to be parts of the actual release. The tags on this repository are just there to generate containers with the correct source code. This tag was moved forward to fix a couple of bugs but it doesn't reall matter on what commit the tags reside in this repository. I'm going to move both 1.13.0 and 1.14.0 up to the latest commit on this repo to generate containers which have some critical bug fixes.

 The reason I raised this issue was because the re-tagging of 1.13 to 1.14 broke our workflow due to the new autoware image adding "USER autoware" causing all "RUN apt-get" to fail.
Just to emphasise what I mean, for example the Autoware project itself could suffer from the same issues if the ROS project was randomly updating their docker images.
The version of the docker tags on the Docker repo are still important to version the docker tooling and scripts.
What is the con in tagging the docker repo together with the rest of the project? Doing a patch fix to the docker will require all repos to be tagged but if it is a fix deemed important then it sounds the right thing.

@filiperinaldi You are, of course, correct. I'm sorry for the confusion. For future releases, we will consider the docker repository part of the official release and will not move tags. For the time being, 1.13.0 and 1.14.0 both point to the same commit to fix a critical bug which was found in 1.13.0. If this is too problematic, I can move it back, but work-arounds will be required by others so I would prefer not to at this time, if possible. Please let me know. 1.12.0 and before should be unaffected.

Hi Josh, we will push a workaround on our side for 1.13.
Thanks,
Filipe

Hi Josh, we will push a workaround on our side for 1.13.
Thanks,
Filipe


Is there any special trick to use t.throws() with async functions?

I might be doing something stupid, but I could not make t.throws() work with async functions.
Here is a small test I did (in TypeScript, which accepts top awaits):
import { strict as assert } from 'node:assert'
import * as util from 'node:util'
import { test } from 'tap'

await test('throws', async (t) => {

  const syncFunc =  (flag: boolean): void => {
    if (flag) {
      assert(false)
    }
  }

  const setImmediatePromise = util.promisify(setImmediate);

  const asyncFunc = async (flag: boolean): Promise<void> => {
    if (flag) {
      assert(false)
    }
    await setImmediatePromise()
  }

  t.throws(() => { syncFunc(true) }, '1')

  t.throws(async () => { await asyncFunc(true) }, '2')

  // This might be useless or plainly wrong, but I tried it too.
  await t.throws(async () => { await asyncFunc(true) }, '3')

  try {
    await asyncFunc(true)
    t.notOk(false, '4 not ok')
  } catch (error) {
    t.ok(true, '4 ok')
  }

  t.end()
})

The result is:
  sync and async throws
    ✓ 1
    1) 2
    2) 3
    ✓ 4 ok

In other words, the assertion is thrown and catched as expected by regular code, but t.throws() fails to identify it properly.
For now I'll use regular code to check exceptions, but, if possible, it would be nice to be able to use the more compact t.throws() with async functions too.

You can use t.rejects. t.throws expects an immediate throw, but a failing async function returns a failing promise instead of throwing synchronously.

Ah, ok, so this was the trick I missed.
Thank you.
If there is nothing that can be done to make t.throws() work with async functions directly, you can close this ticket.

Yeah, I mean, async functions don't throw, so the failed assertion is technically correct 😅

Perhaps you can make this explicit in the documentation, since the current explanation was not clear for me.


Introduce failing txn type so state syncer understand failing txns

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

#1070  👈
#1069
feature/pos-networking-and-syncing

This stack of pull requests is managed by Graphite.

Merge activity

Feb 27, 7:58 PM EST: @lazynina started a stack merge that includes this pull request via Graphite.


Any support for transition group ?

Any support for transition group ?

From/to what?

@facebook-github-bot label Icebox

@facebook-github-bot close

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/any-support-for-transition-group-
ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub.
Also, if this issue is a bug, please consider sending a PR with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.

Some update on this issue : TransitionGroup does work on react-native, using prop component={View}, but it seems super slow.
I'm currently running it on the iOS simulator and removing/adding an item in a list of 10 takes roughly 500ms. The lowest the list the faster, at a list of 1 it takes probably around 50ms.
Here's some sample code if you want to try:
import TransitionGroup from 'react-addons-transition-group';

export default class TestProject extends Component {
  state = {
    data: ['One', 'Two', 'Three', 'Four', 'Five', 'Six', 'Seven', 'Eight', 'Nine', 'Ten'],
  }

  reset = () => {
    this.setState({
      data: initialData,
    });
  }

  buttonPress = () => {
    this.setState({
      data: this.state.data.slice(1),
    });
  }

  render() {
    return (
      <View style={s.view}>
        <Button
          title="Reset"
          onPress={this.reset}
        />
        <Button
          title="Delete row"
          onPress={this.buttonPress}
        />
        <TransitionGroup component={View}>
          { this.state.data.map(data => (
            <View key={data}>
              <Text>{data}</Text>
            </View>
          ))}
        </TransitionGroup>
      </View>
    );
  }
}

Also, you will need to install react-dom for TransitionGroup to work.


File upload in wdi5

Hi everyone,
I have an App with an sap.m.upload.UploadSet in it and I want to test it now.
I tried a lot of things but could not attach a File, fire an event and test the upload,
My SAPUI5-Tree looks like this:

Would be great if you can help me

Hi, there's a recipe for that in the -well- "recipe" section of the docs: https://ui5-community.github.io/wdi5/#/recipes?id=conducting-a-file-upload
Also, I don't see this being a real issue, but more of a support request (that's why I'm closing this). You might be happy to learn that the steering committee agreed to open up wdi5 for vendors offering commercial support for the tool - stay tuned! (note that wdi5 will forever stay Open Source, with a dual license: derived 🍺 -ware and Apache 2.0)
For community support, please post in https://answers.sap.com/questions/ask.html (and tag it with a user tag wdi5) and hop over to the wdi5 Slack channel .


Screenshot: Add finalWidth and finalHeight to the size object

See https://forum.babylonjs.com/t/create-screenshot-using-render-target-ignores-hardware-scaling-level/39626/3

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/13702/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13702/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13702/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/13702/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13702/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13702/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13702/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/13702/merge#BCU1XR#0

No, precision is simply a multiplication factor for width/height: it is the same as passing widthprecision/heightprecision`.
With the PR, you can pass only widthFinal or heightFinal, and it will calculate the other according to the camera's aspect ratio. If you pass both values, it will use the values you passed. I think most people will pass one of the widthFinal or heightFinal values, so it's really only one more parameter to pass, but dealing with finalWidth/finalHeight was no more difficult (and a copy/paste of the existing width/height), which is why I did it that way.


Cortana integration?

Would be cool that a "remind me" command or any other Cortana-specific commands  would open the command in Cortana.
In the future this could leverage a rich connection with Cortana, surfacing the result in a "card" in search results.
Not many people may use Cortana as it's now enterprise focused, but i find it useful myself.
Right now i have too many avenues to get things (Win Search, Powertoys run, cortana) and would be cool to consolidate.

I also, initially though about this but, then took back thinking it's Integration with some backend wiz gona be ms account and then cortana.
+1 for create notes and add reminder but please no cortana integration (It's not that I don't like cortana but..😅) I feel it personally in that case it will become current windows search. 😶
May be syncing locally notes, reminders & others will be a pretty good choice and then optional cortana integration.

maybe figure out something from here: https://ourcodeworld.com/articles/read/44/how-to-add-voice-commands-to-your-webpage-with-javascript

@shirkerohit
Maybe you should try onenote...

One note for?@dentistfrankchen

It's onenote the software. You can use it to create notes and syncing them with your phone , Ipad...with just an ms account.

Can't you do this already?  Just enable "Hey Cortana"

Maybe this guy want to use cortana inside run?
It would enhance run's function since it would be able to understand audio command...
However, since Microsoft is kind of "giving up" cortana, maybe you should consider this issue #4931

I have post an idea in #4931, you guys can support me by giving my idea a thumb up.

Cortana already supports text input. Can't we leverage that instead?

From: dentistfrankchen<EMAIL_ADDRESS>Sent: Monday, July 13, 2020 11:31:06 PM
To: microsoft/PowerToys<EMAIL_ADDRESS>Cc: Scott M<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [microsoft/PowerToys] Cortana integration? (#4863)
I have post an idea in #4931https://github.com/microsoft/PowerToys/issues/4931, you guys can support me by giving my idea a thumb up.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerToys/issues/4863#issuecomment-657945780, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB53LXLPUSEJ45WOGSC72ZTR3PGPVANCNFSM4OUTYGHA.

I still think it is a bit unclear what the ask here is.

@crutkas basically PTRun should consolidate and essentially replace all "inputs" for the OS. Windows Search, Cortana, even the Omnibox. Would be neat if I could ask "who is the president" or "remind me to do [x] tomorrow"
Don't know if that makes sense.

It's onenote the office software. You can use it to create notes and syncing them with your phone , Ipad...with just an ms account.

Thanks for suggesting but, I already do that. The op was referring to integration of Cortana with PoerRun to which I suggested we can have something local like type note > "type note"

It's onenote the office software. You can use it to create notes and syncing them with your phone , Ipad...with just an ms account.

Thanks for suggesting but, I already do that. The op was referring to integration of Cortana with PowerToysRun to which I suggested we can have something local like type note > "type note"

Now I understand. I think it is a good idea, and i suggest that you draw a picture to illustrate your point, which will make it to be more clear for the designers of pt run.

I am glad that helped to clarify my point mate!

I understand your ask, that is outside our goals for PT Run.

This isn't something that is within the goals for PT Run and no one has upvoted this so we're going to close this out.


Should this target HKCU, not HKLM?

The code references this Registry folder:
$IEMainReg = 'HKLM:\Software\Microsoft\Internet Explorer\Main'
While the referenced keys/values are correctly updated, perhaps you should target HKCU, not HKLM? Certainly that would mean the inclusion of [PsDscRunAsCredential] and therefore mandate the use of WMF 5.1, and required additional code to implement. But as DSC runs as System, I am struggling to understand the point of this cmdlet in its current form: if this is about IE defaults, then AFAIK using HKLM does not achieve this.
Thank you.

There seems to be registry entries there
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Internet Explorer\Main]
"ApplicationTileImmersiveActivation"=dword:00000001
"AssociationActivationMode"=dword:00000000
"AutoHide"="yes"
"Start Page"="http://go.microsoft.com/fwlink/p/?LinkId=255141"
"Anchor_Visitation_Horizon"=hex:01,00,00,00
"Cache_Percent_of_Disk"=hex:0a,00,00,00
"Default_Page_URL"="http://go.microsoft.com/fwlink/p/?LinkId=255141"
"Default_Search_URL"="http://go.microsoft.com/fwlink/?LinkId=54896"
"Default_Secondary_Page_URL"=hex(7):00,00,00,00
"Delete_Temp_Files_On_Exit"="yes"
"Enable_Disk_Cache"="yes"
"Extensions Off Page"="about:NoAdd-ons"
"Local Page"="C:\\Windows\\System32\\blank.htm"
"Placeholder_Height"=hex:1a,00,00,00
"Placeholder_Width"=hex:1a,00,00,00
"Search Page"="http://go.microsoft.com/fwlink/?LinkId=54896"
"Security Risk Page"="about:SecurityRisk"
"Use_Async_DNS"="yes"
"x86AppPath"="C:\\Program Files (x86)\\Internet Explorer\\IEXPLORE.EXE"

So I think this resource is meant to be used to set the start page for new users?.
Your proposal would be allowed to set it for current users to, but that would only work for one user on the machine since two resources with the same key would fail.


slurmctld fails to start: invalid plugin select/cons_res

I'm trying to launch a virtual cluster in a Rocky 8 instance on Jetstream2 following the documentation here.
On the instance I create, slurmctld fails to start, giving an error in the logs: fatal: Can't find plugin for select/cons_res.  slurmctld --version prints slurm 23.11.4.
In the slurm.conf documentation, it looks like cons_res is "legacy" and no longer an accepted value for the SelectType setting in slurm.conf.
If I change select/cons_res to the allowed select/cons_tres value in slurm.conf, then slurmctld starts successfully.

Fixed by #21


How to train it using 16 or more gpus which are in different nodes?

Hi, because we are using torchrun and torchrun can support multi-node, our repository can directly train on multi-node.
Please refer to
https://discuss.pytorch.org/t/how-could-we-use-torchrun-to-start-multi-node-training/138039
https://pytorch.org/docs/stable/elastic/run.html

Thank your for your reply!


[bulk] Validation: converted html tables to markdown

Docs Build status updates of commit 2a3fc86:
:warning: Validation status: warnings

File
Status
Preview URL
Details

BingMaps/rest-services/examples/optimized-waypoints-example.md
:warning:Warning
View
Details

BingMaps/rest-services/examples/optimized-waypoints-example.md

Line 105, Column 1: [Warning: code-block-indented - See documentation] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 111, Column 1: [Warning: code-block-indented - See documentation] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 117, Column 1: [Warning: code-block-indented - See documentation] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit d4bbfdd:
:warning: Validation status: warnings

File
Status
Preview URL
Details

BingMaps/rest-services/examples/optimized-waypoints-example.md
:warning:Warning
View
Details

BingMaps/rest-services/examples/optimized-waypoints-example.md

Line 111, Column 1: [Warning: code-block-indented - See documentation] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 117, Column 1: [Warning: code-block-indented - See documentation] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 674db04:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingMaps/rest-services/examples/optimized-waypoints-example.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Global effort to fix build validation errors
@eriklindeman, @stevemunk
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you’d like to see. Thank you!


[CT-2036] Parsing: model ‘latest’ attribute

Parse latest: Optional[boolean], as configured in a model yaml property file. Should be available as a model node attribute in the manifest. Should be None for un-versioned models, True if explicitly set via model property, or if model has highest numeric version, and False otherwise.
Validation

only one version of a given model can have latest: true set
only versioned models can have latest set to true or false

I'm going to close this as a standalone issue, I think we'll need to capture it as part of the updated version spec proposed in #6866. We can reopen if that's the wrong call


Add package serializetools

Hi Dominik,
Thanks for the suggestion. You’ll see I made a pull request of “packages”. Thanks again for looking after all of this. Nice book, btw.
	Robert  (grokqcd)

Robert Edwards
Jefferson Lab
<EMAIL_ADDRESS>757-269-7737

On Jun 1, 2017, at 7:15 PM, Dominik Picheta<EMAIL_ADDRESS>wrote:
@dom96 commented on this pull request.
In packages.json https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_nim-2Dlang_packages_pull_514-23discussion-5Fr119751451&d=DwMCaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=tkVxXxmyj3kxSyw99H0avw&m=ACkrMte4lxOkcqvreFXsXXzglADKsErzwNvaGbNEpT8&s=5f9zeW7pZJx9MjHvc5_BRis3d5R7jUBX3bCrKMhDxmY&e=:

@@ -6453,5 +6453,16 @@
"description": "Shiny bindings to the JACK Audio Connection Kit.",
"license": "MIT",
"web": "https://github.com/Skrylar/nim-jack"

},
{
"name": "serializetools",
"url": "https://github.com/JeffersonLab/serializetools",
"method": "git",
"tags": [

 "yes"

Some tags would be nice here :)
I can add them for you if you don't wish to mess with the PR. Just tell me which to add.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_nim-2Dlang_packages_pull_514-23pullrequestreview-2D41660952&d=DwMCaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=tkVxXxmyj3kxSyw99H0avw&m=ACkrMte4lxOkcqvreFXsXXzglADKsErzwNvaGbNEpT8&s=k2UFaa4Ljb0PpqWHWM6E48bgHyYger0cVIBzAtl1FD4&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABI9tCx6HikurW23llSvNHK-2DvrP3-5FYKiks5r-5F0X0gaJpZM4NtlOW&d=DwMCaQ&c=lz9TcOasaINaaC3U7FbMev2lsutwpI4--09aP8Lu18s&r=tkVxXxmyj3kxSyw99H0avw&m=ACkrMte4lxOkcqvreFXsXXzglADKsErzwNvaGbNEpT8&s=hr7D_PltM3URsxy8UWTnOngOVXLich9XE7VqtfNfZlI&e=.


Add DeferredEventsTrait

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Tests pass?
✔

Fixed issues
#36

WDYT about making a service instead of a trait? It should be more flexible as I see:
interface DeferredEventService {
    public function pushEvent(object $event): void;
    public function releaseEvents(): void;
}


1.4.1

Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

@MyLifeForWorld what do you want to do？

Codecov Report

Merging #3400 (9569bed) into develop (23a407e) will increase coverage by 0.36%.
The diff coverage is 52.38%.

@@              Coverage Diff              @@
##             develop    #3400      +/-   ##
=============================================
+ Coverage      51.11%   51.47%   +0.36%
- Complexity      3297     3333      +36
=============================================
  Files            614      616       +2
  Lines          20125    20172      +47
  Branches        2514     2484      -30
=============================================
+ Hits           10287    10384      +97
+ Misses          8806     8723      -83
- Partials        1032     1065      +33

Impacted Files
Coverage Δ
Complexity Δ

...c/main/java/io/seata/core/context/RootContext.java
47.16% <0.00%> (-3.78%)
18.00 <0.00> (-1.00)

.../src/main/java/io/seata/core/protocol/Version.java
7.40% <ø> (ø)
2.00 <0.00> (ø)

...io/seata/core/rpc/netty/RmNettyRemotingClient.java
39.13% <ø> (ø)
10.00 <0.00> (ø)

...io/seata/core/rpc/netty/TmNettyRemotingClient.java
55.95% <ø> (ø)
13.00 <0.00> (ø)

...scovery/loadbalance/ConsistentHashLoadBalance.java
89.28% <ø> (ø)
3.00 <0.00> (ø)

.../discovery/loadbalance/LeastActiveLoadBalance.java
100.00% <ø> (ø)
7.00 <0.00> (ø)

...eata/discovery/loadbalance/LoadBalanceFactory.java
50.00% <ø> (ø)
1.00 <0.00> (ø)

...seata/discovery/loadbalance/RandomLoadBalance.java
100.00% <ø> (ø)
2.00 <0.00> (ø)

...a/discovery/loadbalance/RoundRobinLoadBalance.java
66.66% <ø> (ø)
3.00 <0.00> (ø)

...very/registry/zk/ZookeeperRegisterServiceImpl.java
60.46% <0.00%> (-0.48%)
26.00 <0.00> (ø)

... and 80 more

我想更新我本地fork的代码，因为不会操作，搞成了提交，很抱歉


Pass extra data via captureException/captureMessage

I am adding extraParams support provided in the Sentry documentation https://docs.sentry.io/enriching-error-data/context/?platform=browser#extra-context
@Turbo87

@Turbo87

https://docs.sentry.io/enriching-error-data/context/?platform=browser#extra-context refers to their new SDK, but ember-cli-sentry is still using raven-js internally. are you sure that the same is possible with raven-js?

yup @Turbo87 extra params is support by raven-js, I tested this branch in my app and works very fine.
https://github.com/getsentry/sentry-javascript/blob/a01b4ee7f7ba03167d7424daae2fb2f2206687cb/packages/raven-js/test/raven.test.js#L588-L600
can we merge this?

the legacy client (raven-js) has a setExtraContext() method that can be used for the same purpose:
this.raven.callRaven('setExtraContext', {
  whatever: 'you want'
});

see https://docs.sentry.io/clients/javascript/usage/#raven-js-additional-context

thanks @Turbo87

thanks @Turbo87


Name in tooltip for "defined but never used" is not updating after changing name in code

Platform: Window 8.1. x64
Atom: 1.0.2
Atom-JSHint: 1.3.9
Steps:

Write a simple variable in js file.
Save file (this runs jshint on the file).
Change name of the variable.
Save file.
Read the message on the tooltip.

What's expected:
Tooltip shows changed name of variable.
What's happening:
Tooltip shows previous name of variable.
Sample:

The message on status bar at the bottom is correct though.

Closing as this project is deprecated. 🌵


Disable Auto init from DOM

I'm mainly using simplebar-react, but in one specific case I also have to initialize simplebar via vanila JS package.
Before extracting simplebar-core as separate everything was working fine because of SimpleBar.instances check. But right now I'm getting 2 scrollbars instead of 1.
So, is it possible to add an option to disable auto init from DOM elements? or disable MutationObserver after initialization?

Hi @Nicolai8
I see how that can be an issue with the latest version. Maybe you can try adding data-simplebar="init" to the element that gets instantiated 2 times, it should prevent the vanilla SimpleBar from instantiating again.
Let me know if that works!

Sorry, I reverted back to previous version and completely forgot about the raised issue on the GitHub.
Was trying recently to update lib again.
There are few things with data-simplebar="init" approach:

I can't add it to the <SimpleBar /> react component because in the Observer watcher it will trigger new instance initiation without check if it's initialized or not
so, I have to wrap <SimpleBar /> with <div data-simplebar="init" /> - this fix an issue visually, but:
*also generates massive amount of unnecessary HTML:

have to rework, some components


Maps cannot overlap

Hi. When I run lio-sam in Gazebo simulation environment, the maps cannot overlap.

Here are my .xacro files and params.yaml files:
https://github.com/AntarcticaSkj/flie-about-LIO-SAM

Hello,I also had the same problem,did you solve it?


Feature/tf dataset adapter

Adapter for handling tensorflow's tf.data.Dataset

Codecov Report

Merging #144 (d780937) into master (1e578e8) will increase coverage by 0.09%.
The diff coverage is 90.47%.

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   78.95%   79.04%   +0.09%
==========================================
  Files         110      112       +2
  Lines        5388     5459      +71
==========================================
+ Hits         4254     4315      +61
- Misses       1134     1144      +10

Impacted Files
Coverage Δ

elegy/data/tests/array_adapter_test.py
100.00% <ø> (ø)

elegy/data/tests/dataset_test.py
98.97% <ø> (ø)

elegy/data/tests/list_adapter_test.py
100.00% <ø> (ø)

elegy/data/tests/utils_test.py
100.00% <ø> (ø)

elegy/data/data_handler.py
71.42% <66.66%> (-1.91%)
:arrow_down:

elegy/data/tf_dataset_adapter.py
81.39% <81.39%> (ø)

elegy/data/tests/tf_dataset_adapter_test.py
100.00% <100.00%> (ø)

elegy/data/data_adapter.py
57.14% <0.00%> (-6.28%)
:arrow_down:

elegy/data/generator_adapter.py
41.30% <0.00%> (-4.70%)
:arrow_down:

elegy/metrics/metric.py
68.18% <0.00%> (-1.39%)
:arrow_down:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e578e8...d780937. Read the comment docs.

Codecov Report

Merging #144 (d780937) into master (1e578e8) will increase coverage by 0.09%.
The diff coverage is 90.47%.

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   78.95%   79.04%   +0.09%
==========================================
  Files         110      112       +2
  Lines        5388     5459      +71
==========================================
+ Hits         4254     4315      +61
- Misses       1134     1144      +10

Impacted Files
Coverage Δ

elegy/data/tests/array_adapter_test.py
100.00% <ø> (ø)

elegy/data/tests/dataset_test.py
98.97% <ø> (ø)

elegy/data/tests/list_adapter_test.py
100.00% <ø> (ø)

elegy/data/tests/utils_test.py
100.00% <ø> (ø)

elegy/data/data_handler.py
71.42% <66.66%> (-1.91%)
:arrow_down:

elegy/data/tf_dataset_adapter.py
81.39% <81.39%> (ø)

elegy/data/tests/tf_dataset_adapter_test.py
100.00% <100.00%> (ø)

elegy/data/data_adapter.py
57.14% <0.00%> (-6.28%)
:arrow_down:

elegy/data/generator_adapter.py
41.30% <0.00%> (-4.70%)
:arrow_down:

elegy/metrics/metric.py
68.18% <0.00%> (-1.39%)
:arrow_down:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e578e8...d780937. Read the comment docs.

@charlielito lets merge this before #139

@charlielito lets merge this before #139

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 92.10526% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.24%. Comparing base (1a2fcc9) to head (338217f).
Report is 82 commits behind head on master.

Files with missing lines
Patch %
Lines

elegy/data/tf_dataset_adapter.py
86.00%
7 Missing :warning:

elegy/data/data_handler.py
66.66%
2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   78.97%   79.24%   +0.26%
==========================================
  Files         112      114       +2
  Lines        5475     5589     +114
==========================================
+ Hits         4324     4429     +105
- Misses       1151     1160       +9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


rename want-help Github label to help wanted

Github seems to make this a standard now.

(Didn't find a blog post about this.)

Codecov Report

Merging #877 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #877   +/-   ##
=======================================
  Coverage   90.85%   90.85%
=======================================
  Files          92       92
  Lines        6274     6274
=======================================
  Hits         5700     5700
  Misses        371      371
  Partials      203      203

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8297c52...30730d3. Read the comment docs.


Replace slashes in file names with character based on variable

Relates to issue #3.
Use the slash_replace_char to use as a replacement for slashes in file names. Always remove the leading slash. Default to removing the slashes (i.e. replacing with "") to maintain backwards compatibility.

Thanks for a good improvement, ready to merge!

Thanks for a good improvement, ready to merge!


error loading playlists without images

Describe the bug
images can be null in some playlists. seems to be true for some old playlists, but also empty playlists
To Reproduce

Create an empty playlist.
Remove Playlist_cache.json
Start spotify_player
Note empty playlists window

Expected behaviour
Playlists should load
Log and backtrace
Relevant log line
2024-03-25T01:17:07.902710Z ERROR client_request{request=GetUserPlaylists}: spotify_player::client::handlers: Failed to handle client request: json parse error: invalid type: null, expected a sequence at line 1 column 392: invalid type: null, expected a sequence at line 1 column 392
Screenshots
If applicable, add screenshots to help explain your problem.

Environment

OS: Arch
Application version: 0.17.1

Additional context
example problematic json
{"href":"https://api.spotify.com/v1/users/.../playlists?offset=0&limit=1","limit":1,"next":"https://api.spotify.com/v1/users/.../playlists?offset=1&limit=1","offset":0,"previous":null,"total":43,"items":[{"collaborative":false,"description":"","external_urls":{"spotify":"https://open.spotify.com/playlist/..."},"href":"https://api.spotify.com/v1/playlists/...","id":"...","images":null,"name":"My Playlist #26","owner":{"display_name":"...","external_urls":{"spotify":"https://open.spotify.com/user/..."},"href":"https://api.spotify.com/v1/users/...","id":"...","type":"user","uri":"spotify:user:..."},"primary_color":null,"public":true,"snapshot_id":"...","tracks":{"href":"https://api.spotify.com/v1/playlists/.../tracks","total":0},"type":"playlist","uri":"spotify:playlist:..."}]}

I'm well aware of this issue: https://github.com/ramsayleung/rspotify/issues/459, it seems rspotify doesn't want to fix it. I implemented a patch but only for get-playlist API. Will put another patches for get-playlists.

@mochimisu can you try running in https://github.com/aome510/spotify-player/pull/402 to see if it fixes the issue?

Before the next release, one may use the API to check which playlist is the culprit. Go the the spotify API documentation link below and test the query with limit = 50 offset = 0 on your own account (you need to be logged in):
https://developer.spotify.com/documentation/web-api/reference/get-a-list-of-current-users-playlists
Then Ctrl+F for "images": null


Getting menu by humanized name

Adds the possibility to get the meny not only by id, but also by name

Next good idea and good work. I'm ready to merge these commits.
Action view generate little bug.  $_GET['variable'] every time is string, and condition is_int($id) in Model::findModel($id) have problem.
First simple solution, change
public function actionView($id){ 		$m = Model::findModel($id);`
for this
$m = Model::find($id)->one();
About Exception, I'll think later.

Action view generate little bug. $_GET['variable'] every time is string

I've thought about that today we can fix it by checking the $id by regex
public static function findModel($id){
if (is_int($id)) {
$where = ['menu_id' => $id];
}
replacing by
public static function findModel($id){
if (preg_match('#[\d]+#'$id)) {
$where = ['menu_id' => $id];
}
I think it fixes the bug

Wow! You've merged all my commits - thanks ))

Why not :)
You implement a lot of interesting changes. It now plans to change a little. (maybe you already it did)

Change the class and file names migration. (I did it c8143e4)
For a time, hide the icons select until as:
a) option icons - the last in the list, under input the url. hide icons in LINE DIVIDER
b) icons will not break the dropmenu. more space between link and icon
c) in update item section -> will be able to change the icon - it seems to me that another column in the table is needed
possibility change name of menu input menu_name above section drop to edit/trash and unique attribute menu_name in model

Yes, 1,2,3 are good ideas
I used to use # in regex 'cause sometimes it is easier to read regex when you are not schielding slashes
i.e
//some/route/path/
#some/route/path#


Demo app relaunch issue

I get the below issue when i run following command
npm run demo.ios
Scenario
Above command runs successfully and launches the app the first time, when i try to run same command second time i get the below error
Note:
In order to avoid the below error i have to delete the following folders

hooks
node_modules
platforms

and run above command as if its first time running the application.
Error message
$ npm run demo.ios

<EMAIL_ADDRESS>demo.ios /Users/jayandhanrajasundaram/Documents/workspace/nativescript-nodeify
npm run preparedemo && cd demo && tns debug ios

<EMAIL_ADDRESS>preparedemo /Users/jayandhanrajasundaram/Documents/workspace/nativescript-nodeify
cd demo && tns plugin add .. && tns install

npm ERR! addLocal Could not install /Users/jayandhanrajasundaram/Documents/workspace/nativescript-nodeify/demo/node_modules/readable-stream/string_decoder/@*
npm ERR! Darwin 16.4.0
npm ERR! argv "/usr/local/Cellar/node/7.5.0/bin/node" "/usr/local/bin/npm" "install" ".." "--save"
npm ERR! node v7.5.0
npm ERR! npm  v4.3.0
npm ERR! path /Users/jayandhanrajasundaram/Documents/workspace/nativescript-nodeify/demo/node_modules/readable-stream/string_decoder/@*
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall open
npm ERR! enoent ENOENT: no such file or directory, open '/Users/jayandhanrajasundaram/Documents/workspace/nativescript-nodeify/demo/node_modules/readable-stream/string_decoder/@'
npm ERR! enoent ENOENT: no such file or directory, open '/Users/jayandhanrajasundaram/Documents/workspace/nativescript-nodeify/demo/node_modules/readable-stream/string_decoder/@'
npm ERR! enoent This is most likely not a problem with npm itself
npm ERR! enoent and is related to npm not being able to find a file.
npm ERR! enoent
npm ERR! Please include the following file with any support request:
npm ERR!     /Users/jayandhanrajasundaram/.npm/_logs/2017-03-06T17_27_45_048Z-debug.log
Command npm failed with exit code 254
plugin add
┌─────────┬───────────────────────────┐
│ Usage   │ Synopsis                  │
│ General │ $ tns plugin add  │
└─────────┴───────────────────────────┘
Installs the specified plugin and any packages that it depends on.
Attributes
* <Plugin> is a valid NativeScript plugin, specified by any of the following.
    * A <Name> or <Name>@<Version> where <Name> is the name of a plugin that is published in the npm registry and <Version> is a valid version of this plugin.
    * A <Local Path> to the directory which contains the plugin, including its package.json file.
    * A <Local Path> to a .tar.gz archive containing a directory with the plugin and its package.json file.
    * A <URL> which resolves to a .tar.gz archive containing a directory with the plugin and its package.json file.
    * A <git Remote URL> which resolves to a .tar.gz archive containing a directory with the plugin and its package.json file.

Sending exception report (press Ctrl+C to stop).....
npm ERR! Darwin 16.4.0
npm ERR! argv "/usr/local/Cellar/node/7.5.0/bin/node" "/usr/local/bin/npm" "run" "preparedemo"
npm ERR! node v7.5.0
npm ERR! npm  v4.3.0
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR<EMAIL_ADDRESS>preparedemo: cd demo && tns plugin add .. && tns install
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>preparedemo script 'cd demo && tns plugin add .. && tns install'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the nativescript-nodeify package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     cd demo && tns plugin add .. && tns install
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs nativescript-nodeify
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls nativescript-nodeify
npm ERR! There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?
npm ERR! Please include the following file with any support request:
npm ERR!     /Users/jayandhanrajasundaram/.npm/_logs/2017-03-06T15_38_02_150Z-debug.log
npm ERR! Darwin 16.4.0
npm ERR! argv "/usr/local/Cellar/node/7.5.0/bin/node" "/usr/local/bin/npm" "run" "demo.ios"
npm ERR! node v7.5.0
npm ERR! npm  v4.3.0
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>demo.ios: npm run preparedemo && cd demo && tns debug ios
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>demo.ios script 'npm run preparedemo && cd demo && tns debug ios'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the nativescript-nodeify package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run preparedemo && cd demo && tns debug ios
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs nativescript-nodeify
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls nativescript-nodeify
npm ERR! There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?
npm ERR! Please include the following file with any support request:
npm ERR!     /Users/jayandhanrajasundaram/.npm/_logs/2017-03-06T15_38_02_189Z-debug.log

Please use a fresh project to retest if you want.


Viewers: legend does not show all categories after filtering in specific cases

1.17.8
data:
PubChemReduced (1).csv

Open a table
Add a line chart (bar chart, scatterplot, pie chart, trellis plot)
Configure line chart splitting so that legend is shown (i.e. not too many categories)
Open filters panel
Apply some filtering, so that number of categories in legend is reduced
Select one or several categories in line chart's legend
Reset filtering

Expected results: All categories are shown on the line chart when filtering is reset.
Actual results: Only categories that were selected are shown after resetting filtering. Resetting line chart view does not bring back hidden categories. An error occurs

html_dart2js.dart:3558 2023-12-08 13:25:50.928 NullError: method not found: 'setAllValues$1' on null
	login.dart.js_1.part.js?72350 43913:29   dart.GridFilterBase_onFrameAttached_closure4.call$1
	login.dart.js?72350 8690:18              dart._rootRunUnary
	login.dart.js?72350 12518:41             _CustomZone.runUnary$2
	login.dart.js?72350 12437:21             _CustomZone.runUnaryGuarded$2
	login.dart.js?72350 11381:20             _ForwardingStreamSubscription._sendData$1
	login.dart.js?72350 11331:16             dart._BufferingStreamSubscription._async$_add$1
	login.dart.js?72350 11993:14             _ForwardingStreamSubscription._async$_add$1
	login.dart.js?72350 12068:16             _WhereStream._handleData$2
	login.dart.js?72350 12021:22             dart._ForwardingStreamSubscription._handleData$1
	login.dart.js?72350 5710:14              BoundClosure.eval
	login.dart.js?72350 8690:18              dart._rootRunUnary
	login.dart.js?72350 12518:41             _CustomZone.runUnary$2
	login.dart.js?72350 12437:21             _CustomZone.runUnaryGuarded$2
	login.dart.js?72350 11381:20             _BroadcastSubscription._sendData$1
	login.dart.js?72350 11331:16             dart._BufferingStreamSubscription._async$_add$1
	login.dart.js?72350 9203:22              _SyncBroadcastStreamController__sendData_closure.call$1
	login.dart.js?72350 9142:20              _SyncBroadcastStreamController._forEachListener$1
	login.dart.js?72350 9185:14              _SyncBroadcastStreamController._sendData$1
	login.dart.js?72350 9066:14              dart._BroadcastStreamController.add$1
	login.dart.js?72350 41896:42             J.add$1$ax
	login.dart.js_1.part.js?72350 141358:11  EventBus.fire$3
	login.dart.js_1.part.js?72350 141362:21  EventBus.fire$2
	login.dart.js_1.part.js?72350 8207:41    Object.AppEvents_fire
	login.dart.js_1.part.js?72350 42633:11   FiltersCore__initHeader_closure4.call$0
	login.dart.js_1.part.js?72350 115128:29  icon_closure.call$1
	login.dart.js_1.part.js?72350 98815:29   Icons__bindIcon_closure.call$1
	login.dart.js?72350 29281:28             dart._EventStreamSubscription_closure.call$1
	login.dart.js?72350 8694:16              dart._rootRunUnary
	login.dart.js?72350 12518:41             _CustomZone.runUnary$2
	login.dart.js?72350 12437:21             _CustomZone.runUnaryGuarded$2
	login.dart.js?72350 12601:27             dart._CustomZone_bindUnaryCallback_closure.call$1
	login.dart.js?72350 6926:29              invokeClosure_closure0.call$0
	login.dart.js?72350 4274:25              _IsolateContext.eval$1
	login.dart.js?72350 3852:28              Object._callInIsolate
	login.dart.js?72350 5539:20              dart.invokeClosure
	login.dart.js?72350 5558:18              HTMLElement.<fn>

Another possibly related case:

Open a table
Add a plot with legend
Select several categories in legend (using ctrl-click)
Apply some filter, so that data for some of the selected categories is no longer shown

Expected results: categories with no data shown should not be shown in the legend.
Actual results: all selected categories are still shown in the legend:

Regarding last case, for now we do not change or hide legend items if we have filtering in it, though yes, we can change it for inViewerFilter to show only the ones that are present in global filter.
Also, i propose to get rid of the case with global filtering in legend(its rarely useful and will stay in way of implemented the legend this new way. Supporting several cases of synchronizing legend and global filters is really not something we want)

Filtering on the legend should only filter the viewer

Case 1: All categories are shown on the line chart when filtering is reset but the error remains

1.18.0


Using  { subscribe: true }  with useFirestoreQueryData causes infinite loading status.

Using  { subscribe: true }  with useFirestoreQueryData or useFirestoreQuery causes infinite loading status when I refresh a page in Nextjs app.
const ContactsLandingPage: React.FC = (): React.ReactElement => {
  // ? next router
  const { push } = useRouter()

  // ? permissions gate
  const {
    customClaims: { accountId }
  } = usePermissionsGateContext()

  // ? the firebase services
  const firestore = useFirestore()

  // ? the contacts
  const contactsColRef = collection(firestore, `customer_accounts_data/${accountId}/contact`).withConverter(
    contactConverter
  )
  const {
    status: contactsStatus,
    error: contactsError,
    data: contacts
  } = useFirestoreQueryData(['contacts', { accountId }], contactsColRef, { subscribe: true }, {})

"firebase": "^9.4.0",
"@react-query-firebase/firestore": "^0.4.2",
"react-query": "^3.32.3",

New findings
The "permissions gate" above was using useAuthIdToken to get the custom claims
export default function useIdTokenResult() {
  const auth = getAuth(useFirebaseApp())
  return useAuthIdToken(['token'], auth, { forceRefresh: true })
}

Changing forceRefresh to false solved the issue, however, this doesn't explain why it got stuck in fetching in the first place.

Oh weird, not seem this myself (or in tests). Is there anything showing in console when the request is hanging?

Hi @Ehesp. There's no error in the console. The edge case here is that this happens only on page refresh. The initial load works just fine, but if I refresh the page the query remains stuck in fetching state indefinitely.

What is the difference between a page refresh and initial load? Also I assume this works ok when subscribe is false?

Hi @Ehesp
The first load if { forceRefresh: true }  works as expected,

however after F5 all the queries having { subscribe: true } hand in indefinite fetching state

Huh, I'm confused :D Are you doing any sort of local caching? I'd of thought a page refresh would reset everything anyway back to square one.
I'll see if I can reproduce this.

@Ehesp  The issue was resolved in the latest "react-query": "^3.33.7", couldn't pinpoint which commit fixed it though. Closing


Added simple word counting application

Great project!
I've added a simple word count application that I have been using to test some of the other implementations with.
This one looks pretty fast 🚀

Hi @pmcgleenon, thank you for your comparison and cataloguing efforts! Would you mind creating a self-contained benchmarks/demo-app repo and change the PR to link to that instead? I would rather not include commands in the library repo - that's why https://github.com/keilerkonzept/sliding-topk-tui-demo isn't under cmd/ here either ;)


Cannot import Dataset from "impagination"

It would be nice to be able to import Dataset from "impagination"
Would a vendor-shim of impagination allow us to do this? At the moment we have to import Dataset from 'npm:impagination' for in-addon and consumer use if they want to roll their own. This issue was discovered while looking into #212

Hey any chance on getting an update for this?
Maybe using https://github.com/ef4/ember-auto-import?


Swagger tutorial doesn't correspond with the new version of sample project at GitHub

The tutorial about using Swagger in ASP.NET Core WebAPI (https://docs.microsoft.com/en-us/aspnet/core/tutorials/web-api-help-pages-using-swagger) has code listings, that include fererences to TodoRepository, that was changed by TodoContext in recent  update (https://github.com/aspnet/Docs/pull/3399).
Tutorial now needs to be updated to correspond with the actual codebase of the sample project.

There's a sample project with final result for the tutorial here: https://github.com/misha-fm/Docs/tree/master/aspnetcore/tutorials/web-api-help-pages-using-swagger/sample/src/TodoApi). There code in this project corresponds with the article. So it seems that both article and a sample project with final result need to be updated.

Article needs work - csat 59% with high viewership.

@ardalis  If you have any hours left.


Improve intro of natural deduction example

Add more information about the natural deduction
example so that readers will have a better context.
Signed-off-by: David A. Wheeler<EMAIL_ADDRESS>

@nmegill - this just improves the intro in a non-controversial way. OK to merge?

OK to merge.


Test-PartnerAddress not working anymore

The procedure worked fine the last months. Now it suddenly stopped working, my script hasn't changed.
Steps to reproduce
Using the example from docs (after logging in via Connect-PartnerCenter):
Test-PartnerAddress -AddressLine1 '700 Bellevue Way NE' -City 'Bellevue' -Country 'US' -PostalCode '98004' -State 'WA'
Expected behavior
Address should get verified
Actual behavior
An error gets thrown:
Test-PartnerAddress : Unexpected character encountered while parsing value: {. Path '', line 1, position 1.
Debugging I can see, that the HTTP Request to the Partner Center API seems to work fine:
DEBUG: ============================ HTTP REQUEST ============================
HTTP Method:
POST

Absolute Uri:
https://api.partnercenter.microsoft.com/v1/validations/address

Headers:
Accept                        : application/json
MS-PartnerCenter-Client       : Partner Center PowerShell
MS-CorrelationId              : "GUID"
X-Locale                      : en-US
MS-RequestId                  : "GUID"
MS-SdkVersion                 : <IP_ADDRESS>

Body:
{
  "AddressLine1": "700 Bellevue Way NE",
  "City": "Bellevue",
  "Country": "US",
  "PostalCode": "98004",
  "State": "WA"
}

And the HTTP Response is working aswell:
DEBUG: ============================ HTTP RESPONSE ============================
Status Code:
OK

Headers:
Transfer-Encoding             : chunked
Request-Context               : appId=...
MS-CorrelationId              : "GUID"
MS-RequestId                  : "GUID"
X-Locale                      : en-US
Date                          : Wed, 28 Jul 2021 06:47:34 GMT

Body:
{
  "originalAddress": {
    "country": "US",
    "city": "Bellevue",
    "state": "WA",
    "addressLine1": "700 Bellevue Way NE",
    "postalCode": "98004"
  },
  "suggestedAddresses": [
    {
      "country": "US",
      "city": "Bellevue",
      "state": "WA",
      "addressLine1": "700 Bellevue Way NE",
      "postalCode": "98004-5046"
    }
  ],
  "status": "VerifiedShippable"
}

After that the procedure fails with "Unexpected character encountered while parsing value: {. Path '', line 1, position 1"

Same problem is occurring with New-PartnerCustomer commandlet.

@mprentice22153 We replaced the Test-PartnerAddress function with a direct call to the Partner Center API. We are still using New-PartnerCustomer, we just had to add -DisableValidation so the Address does not get checked again, but the cmdlet works without the validation.

@DonEmmaPerez Thank you.  The parameter solved my issue.


LayoutGroup.contentInsets extended whole content width

I found LayoutGroup.contentInsets extended whole content width.
reproduction code is here https://github.com/ichiko/IBPCVCLLayoutGroupContentInsetsBug.
When horizontal column >= 2, collectionView width was larger than window width witch scrollable horizontal.

expected (run on iOS 13)
actual (iOS 12.4)

Facing the same issue. Have you found any solution?

Facing the same issue. Have you found any solution?


Where is this BUILDARCH coming from?

https://github.com/caos/zitadel/blob/26e4e607bc85b32f99e4295096436205462306c9/build/dockerfile#L21

It's a predefined ARG variable of docker: https://docs.docker.com/engine/reference/builder/#automatic-platform-args-in-the-global-scope

@adlerhurst In that case, 2 questions:

shouldn't BUILDARCH be defined in the dockerfile: https://github.com/caos/zitadel/blob/26e4e607bc85b32f99e4295096436205462306c9/build/dockerfile#L21

Also, that specific line:

FROM ${BUILDARCH}-base AS base would resolve to something like FROM x86_64-base AS base or FROM arm_64-base AS base or something like that - yes?
Where would x86_64-base or arm_64-base images come from?
To give some context my docker builds are all failing with this dockerfile saying BUILDARCH isn't defined but before solving this specific problem, I would like to learn from you the 2 questions above.

Hi @gc-ss
BUILDARCH is a predefined ARG from docker itself. It requires the docker BuildKit backend. So the commands will only work if you prepend DOCKER_BUILDKIT=1 before the actual docker command:
COMPOSE_DOCKER_CLI_BUILD=1 DOCKER_BUILDKIT=1  && docker-compose -f ./build/local ...
or
DOCKER_BUILDKIT=1 docker build -f build/dockerfile . -t zitadel:gen-fe --target go-copy -o .
The resolved docker steps arm64-base and amd64-base are defined just above:
https://github.com/caos/zitadel/blob/26e4e607bc85b32f99e4295096436205462306c9/build/dockerfile#L8-L9
https://github.com/caos/zitadel/blob/26e4e607bc85b32f99e4295096436205462306c9/build/dockerfile#L11-L12
We use this to automatically set ENV vars depending on the platform the docker build command is executed.
At the moment we only set the variable for downloading the specific protoc binary.
Regarding your docker build failures:
Did you run the docker / docker compose commands using DOCKER_BUILDKIT=1?
If so, can you provide me with some infos please:

Which version of docker do you have installed?
OS?
Arch? ARM / x68?

Appreciate this @livio-a
The parent issue is https://github.com/caos/zitadel/issues/2063

Did you run the docker / docker compose commands using DOCKER_BUILDKIT=1?

I did. The command I typed in is:
COMPOSE_DOCKER_CLI_BUILD=1 DOCKER_BUILDKIT=1 \
&& docker-compose -f ./build/local/docker-compose-local.yml --profile database -p zitadel up --exit-code-from db-migrations \
&& sleep 5 \
&& docker-compose -f ./build/local/docker-compose-local.yml --profile database --profile init-backend --profile init-frontend --profile backend --profile frontend --profile setup -p zitadel up -d

Which version of docker do you have installed?
latest

OS?

Ubuntu 20.04

Arch? ARM / x68?
x68

I am doing all of this on EC2
I can make any number of EC2 instances of any configuration available to you/your team - you just need to give me your public SSH key and I will enable access so you can duplicate what I can see

@livio-a  How does your /etc/docker/daemon.json look like?

closing this with reference to https://github.com/caos/zitadel/issues/2063#issuecomment-887084055:
buildkit has to be enabled in deamon.json
fix for the linux local build with the docker compose file are we testing right now and will be discussed in #2063 and the corresponding PR (#2076)


Use shebang to override pythonPath on a per-file basis

I have a collection of scripts in various languages which have no file extensions but have the appropriate shebangs, including a mix of #!/usr/bin/env python and #!/usr/bin/env python3 files in the same directory. VSCode already successfully detects the language, but the Python extension always uses the interpreter set in pythonPath, resulting in some of the files reporting errors that don't actually apply. Ideally, the Python extension would resolve the shebang to determine the correct interpreter to use for that file so that users don't have to manually switch back and forth.
This was previously discussed in #497, and it was stated that this was a choice made by design to avoid possible issues. I think that's a perfectly reasonable position for default behavior, but it would be nice to have the option to enable shebang support.

There should be a code lens in the latest version of the extension that you can click to switch the selected Python interpreter to the interpreter in the shebang

Have you tried this approach?

Coding it for the same reason as #497
Please upvote on that issue and add your comments there.
Thanks

@DonJayamanne That issue is locked, non-collaborators can't upvote or comment on it.

Fixed

Sorry about that


Add the openssl installation to the instruction.

Build guide doesn't work because we don't have openssl installation command.

Need check ssl installation in
Red Hat
Ubuntu
Arch
Brew

In Arch it is installed by default: https://wiki.archlinux.org/title/OpenSSL


OSX getopt is different from linux's

I have been trying to install this for a while but was not able to succeed. I would try to debug it myself, but my knowledge of bash and make is limited.
It does seem that gnu-getopt (or at least the version installed with brew install gnu-getopt) returns different output than the one installed in Linux.
When I execute getopt -T the only output I get in osx is two dashes ('--'). It seems that this output is not expected by this line, and it always fails. I have tried executing it with GETOPT_COMPATIBLE=, with similar results:
bash-4.3$ make
GNU getopt is not installed.
make: *** [deps] Error 1
bash-4.3$ GETOPT_COMPATIBLE= make
GNU getopt is not installed.
make: *** [deps] Error 1
bash-4.3$ GETOPT_COMPATIBLE=true make
GNU getopt is not installed.
make: *** [deps] Error 1
bash-4.3$

I think that your problem is simply that gnu-getopt has not overridden osx-getopt. There are some explanations in #22.
Try :
out=$(getopt -T)
if (( $? != 4 )) && [[ -n $out ]]; then
    echo "not GNU"
else
    echo "GNU"
fi

You may have recieved a message when you were installing, like this one (#22) :

This formula is keg-only, which means it was not symlinked into /usr/local.

OS X already provides this software and installing another version in parallel can cause all kinds of trouble.
At last there seems to be no problem with replacing OSX/BSD getopt by GNU getopt. If you are really afraid, you can:

add GETOPT_COMPATIBLE= to your shell rc (this will set the variable),
or add an alias to getopt at the beginning of love-release.sh and recompile.
If installed with Homebrew, add alias getopt='/usr/local/bin/getopt'.

If you want to double-check my code, this is the manual explaining everything :

-T, --test
Test  if  your getopt(1) is this enhanced version or an old version.  This generates no output, and sets the error status  to  4.   Other  implementations of getopt(1), and this version if the environment  variable  GETOPT_COMPATIBLE  is set, will return '--' and error status 0.

And my code snippet to detect the same thing :
    command -v getopt > /dev/null 2>&1 || {
        local opt=false
    } && {
        unset GETOPT_COMPATIBLE
        local out=$(getopt -T)
        # error status != 4 and output is non-empty (ie = '--')
        if (( $? != 4 )) && [[ -n $out ]]; then
            local opt=false
        fi
    }
    if [[ $opt == false ]]; then
        >&2 echo "GNU getopt is not installed. Aborting."
        local EXIT=true
    fi

There was a small problem I discovered reading Google Shell style guide with local variables. It is related to your problem but it is not the direct cause, I think.
        local out=$(getopt -T)
        if (( $? != 4 )) && [[ -n $out ]]; then
            local opt=false
        fi

becomes this:
        local out
        out=$(getopt -T)
        # error status != 4 and output is non-empty (ie = '--')
        if (( $? != 4 )) && [[ -n $out ]]; then
            local opt=false
        fi

Have you succeeded installing and using love-release ?

Hi there,
In my case installing gnu-getopt with brew install gnu-getopt meant that it was not even installed in /usr/local/bin. Adding a link like that is called "symlinking" in homebrew. You can try to create the symlink:
$ brew link gnu-getopt
Warning: gnu-getopt is keg-only and must be linked with --force
Note that doing so can interfere with building software.

I don't want to do that with --force; can't risk my computer not building software correctly - I need it to earn my keep.
Gnu-getopt was available in the install dir, which happens to be /usr/local/Cellar/gnu-getopt/1.1.6/bin/getopt. I was able to run it from there.
I have tried making an alias to it at the top of lua-release.sh:
#!/usr/bin/env bash

alias getopt='/usr/local/Cellar/gnu-getopt/1.1.6/bin/getopt'

Unfortunately the output is still the same, with or without GETOPT_COMPATIBLE=:
bash-4.3$ make
GNU getopt is not installed.
make: *** [deps] Error 1
bash-4.3$ GETOPT_COMPATIBLE= make
GNU getopt is not installed.
make: ***

May I suggest exploring other options instead of forcing the dependency on gnu-getopt? As it is, it seems more trouble than it's worth, at least in osx. If it's being used just so that there are long options (--author in addition to -a), I'd just stick with short options. Another one could be using something like this. But I have not tried that one.
Now that we are talking about this, why is bash 4 a dependency, too?

It's just that you had to add an alias in love-release.sh but also in the Makefile (cause it checks for dependencies too).
I made a branch so you can try it.
I will manage to make love-release use GNU getopt, fallback to getopts_long or simply use short options.
About bash... come, on ! it's been around since 2009 ! I just didn't take the time to see which features were introduced in bash 4 and if it could cause incompatibilities... but I think I just use a very specific case of parameter expansion... converting from uppercase to lovercase. That can easily be replaced with a tr '[[:upper:]]' '[[:lower:]]'.

f*ck it I'll just learn Python in rewrite it

Sorry but no dice:
bash-4.3$ make
GNU getopt is not installed.
make: *** [deps] Error 1

bash-4.3$ GETOPT_COMPATIBLE= make
GNU getopt is not installed.
make: *** [deps] Error 1

bash-4.3$ /usr/local/Cellar/gnu-getopt/1.1.6/bin/getopt -V
getopt (enhanced) 1.1.6

bash-4.3$ git diff
diff --git a/Makefile b/Makefile
index 491a074..206e26b 100644
--- a/Makefile
+++ b/Makefile
@@ -79,6 +79,7 @@ deps:
                echo "unzip is not installed.";

I don't doubt that- but still, my OSX had 3.x. I had to update. It's just yet another pebble in the way.

f*ck it I'll just learn Python and rewrite it

That would be a bit crazy, wouldn't it? xD
If you are considering the rewrite path, may I suggest doing it in Lua? If you do a luarock then people should be able to install it with luarock install love-release. You could even use rocks for the zip & curl stuff, and specify them as dependencies, so the installation was dependency-free. After a quick look, it seems you would need luafilesystem + luacurl + lua-zlib (or some other zip lib

Yes that could be nice, but doesn't luarock only provide lua libraries ? love-release is an executable, a command, not a lib. How could I use advantage of love-release ?

Not at all, you can create executables as well!
Here's an example: the telescope luarock provides an executable called tsc. It does so by doing two things:

It adds a "bin" section to its rockspec: https://github.com/norman/telescope/blob/master/rockspecs/telescope-0.6.0-1.rockspec#L26-L27
tsc is a file provided by the luarock too, written in lua: https://github.com/norman/telescope/blob/master/tsc

Hi !
I have began to rewrite love-release, you can check the https://github.com/MisterDA/love-release/tree/luarocks branch :)
And you can install it with luarocks too !
luarocks install --server=http://luarocks.org/dev love-release

But don't forget to check the troubleshooting section, there are some bugs with the zip library I use.
Thanks for the help !

^O^ cool!


test fixes

Current coverage is 3.18%

Merging #33 into master will decrease coverage by -12.28% as of 0f6a7c9

@@            master    #33   diff @@
=====================================
  Files           81     24    -57
  Stmts          905    157   -748
  Branches        62      4    -58
  Methods                 0
=====================================
- Hit            140      5   -135
+ Partial          1      0     -1
+ Missed         764    152   -612

Review entire Coverage Diff as of 0f6a7c9

Powered by Codecov. Updated on successful CI builds.


Kudu APIs to publish to Azure from any platform

This "Kudu APIs to publish to Azure from any platform" section needs to either be removed or at least sectioned off. It is not required and it's difficult where these steps should start and end.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 684d1f55-3d8b-9ba6-ee65-e8f84c2b4244
Version Independent ID: 2db330b4-e830-715f-0a15-e406f85e1d3b
Content: Visual Studio publish profiles for ASP.NET Core app deployment
Content Source: aspnetcore/host-and-deploy/visual-studio-publish-profiles.md
Product: aspnet-core
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@Placid7 	I don't see

This Kudu APIs to publish to Azure from any platform section

There is a section The Kudu service
Kudu is super useful.

That's because it's embedded in the "Publish profiles" section. Just search for the string "Kudu" or "Kudu APIs to publish to Azure from any platform" and actually above that is "dotnet publish can use folder, MSDeploy, and Kudu publish profiles:" It completely breaks the flow of the document.


Fix constructor regression

This was caused by https://github.com/moment/moment/pull/2368/files#diff-e792da0601bb2705000e86ef203f8e73R61
We should have had a test to cover for this case :)
Fix for #2512

LGTM

My bad.  +1 for more tests.