--deploy-url stop working after upgrading to Angular v8.x

Bug report
I have a project, that was upgraded from Angular v7.x to v8.x.
After the upgrade the build flag --deploy-url stop working
Steps to reproduce:

I've tested this scenario on 2 new projects, one with Ng7 and 2nd with Ng8 and this bug happen on Ng8

Create new angular project:
ng new hello

Create new component:
ng g c hello

At the bottom of your app.component.html paste this line: (inject the newly created component):
<app-hello></app-hello>

Edit the hello component:

css file:
.demo{ background-image: url("/assets/hello.jpg"); }
html file:

hello works!

Paste this script to your package.json:

  "scripts": {
    "prod": "ng build --prod --base-href=./ --deploy-url=/myapp/",
    ...
  },...

Run this command:
npm run prod

Search in the dist/ folder (search in text) the value: "/assets/hello.jpg"

Result:

Angular v7 (Result ok) - The search result is located in this line (notice the myapp):
{background-image:url(/myapp/assets/hello.jpg)

Angular v8 (Result Bug) - The search result is located in this line (missing myapp):
{background-image:url(/assets/hello.jpg)

###Conclusion:
It looks like the build flag --deploy-url stop working. This flag should edit my css files and add the folder (in the example case: 'myapp') to the path of the asset.
Your Environment
Windows: 10
Node: 12.8.1
Angular-Cli: 8.2.2
If this isn't a bug, but my incorrect use of this feature, please let me know so I could close this issue.

Hi @Gil-Epshtain, this is expected.
Kindly see: https://github.com/angular/angular-cli/issues/14587

Hi @alan-agius4 , I didn't understand you. You write that this is "expected", but you have linked a 2nd issue ,which is similar, but on anther build flag: --base-url. Are you saying that my issue is a duplication? or are you saying that this behavior is the new Angular 8 way? if so how should I reference my assets from my styles files???

@Gil-Epshtain, this is expected and will be the default in future versions of the CLI. For the time being until you transition all resources path you can use the rebaseRootRelativeCssUrls flag.
From https://github.com/angular/angular-cli/issues/14587#issuecomment-497368020

Root relative URLs are a standardized method to reference a resource path from the root of a host. The previous behavior of the Angular CLI prevented this from occuring and resulted in an inability to reference stylesheet assets in this manner. The initial reason for this behavior is no longer present in the internal implementation of the Angular CLI. Therefore, this now unnecessary and non-standard behavior is being phased out. If an application currently relies on this behavior, a compatibility option rebaseRootRelativeCssUrls has been provided for the 8.x release cycle to facilitate transition away from this non-standard and limiting behavior. The recommended method to transition is to use relative paths within the source stylesheet. This allows the build system to process and generate a full URL for the asset.

To reference images in your stylesheet you need to use relative paths, which such paths the build system will be able to process and manage the resource. Since the build system is now managing the resource, it will process the file as needed and add it to the output of the application and it will also hash the filename.

See also: https://github.com/angular/angular-cli/pull/13684

@alan-agius4 , Your solution - of using relative path isn't valid!!
Not only that the path itself look like this: ./../../../../../assets/images/my-img.jpg this isn't readable code.
But that's not the problem, I can live with unreadable code, however the problem is that in production the relative path is differ (it's one folder dipper), So each time I'm publishing a production version I need to go over all of my scss files on manual edit all the references! that's can't be!!


Batch size impact on speed and VRAM consumption

I ran some tests with different batch sizes and noticed that neither VRAM usage nor transcription speed changed significantly. I tested with batch sizes of 64, 128, and 512 on an A100 GPU. Is this normal? Theoretically, VRAM usage should increase along with speed as the batch size grows. I'm using the batched pipeline in my tests.

How does batching work on CPU? Without batching I don't see improvement in transcription speed above 4 threads. Does batching allows me to use more threads? Is batching supposed to also improve transcription speed on 4 threads compare to no batching?

I don't use it on CPUs unfortunately, feel free to test it and report the results


[CELEBORN-3] Add metrics for top disk usage apps for version 0.1.x.

[ISSUE-950]Add metrics for top disk usage apps.
What changes were proposed in this pull request?
Add metrics about top N disk-used apps.
Here are the results:

Why are the changes needed?
What are the items that need reviewer attention?
Related issues.
closes #950
Related pull requests.
How was this patch tested?
/cc @related-reviewer
/assign @main-reviewer

Extra 2 questions to to confirmed:

Does the log in the screencut consist with the real shuffle size?
Has this pr been tested on HA mode with some master killed?

Thanks.

Extra 2 questions to to confirmed:

Does the log in the screencut consist with the real shuffle size?
Has this pr been tested on HA mode with some master killed?

Thanks.

The result is consist with the real shuffle size. I've checked it.
The test will be done later.


No devices foun under this Xiaomi account

Device model / 设备型号
dreame.vacuum.p2029
Component version / 插件版本
1.0.0b3
HA core version / HA版本
2024.11.2
Integrated mode / 集成方式
Local (本地模式)
The problem / 问题详情
Hi,
I've been using this integration for a long time but now I'm facing an issue: my vacuum is not available.
However, I think there's an issue with the login/account part because that's what I get If I try to reconfigure the integration.

I usually set it to "Local", I also tried Automatic and Cloud but no change.
I have 3 devices on my accout on such server, just verified by re-authenticating the app on my phone.
The integration has stopped working since the 16th november.
I was using the latest stable. I just updated to the beta, no difference.
I tried loggin in with email and user ID, no difference.
Entity attributes / 实体属性
"unavailable"

Home Assistant Logs / 系统日志
2024-11-18 12:23:48.947 WARNING (MainThread) [custom_components.xiaomi_miot.core.xiaomi_cloud] Got xiaomi devices for  failed: {'code': 0, 'message': 'SERVICETOKEN_EXPIRED'}
2024-11-18 12:23:51.232 ERROR (SyncWorker_7) [miio.miioprotocol] Got error when receiving: {'code': -9999, 'message': 'user ack timeout'}

Try master branch.

same issue on 0.7.22 version
xiaomi connected devices stop working ...  when I try reset with force .option  = no device found ...
on xiaomi home app .. is device conected and working ...  but in this integration suddenly stop  responsing

wget -O - https://get.hacs.vip | DOMAIN=xiaomi_miot ARCHIVE_TAG=master bash -

Thanks. I've ran this command and rebooted HA, but the version installed seems to be: 0.7.23

By the way, no difference, the setup errors out and I still get the exact same error.

登录失败/没有实体等常见问题解决办法 #500 (comment)

It complains  {"code":0,"message":"invalid signature"}
2024-11-18 22:27:54.745 WARNING (MainThread) [custom_components.xiaomi_miot.core.xiaomi_cloud] Error while executing request to https://api.io.mi.com/app/v2/message/v2/typelist: {"code":0,"message":"invalid signature"}
2024-11-18 22:27:54.748 WARNING (MainThread) [custom_components.xiaomi_miot.sensor] Get xiaomi message for xx failed: {'code': 0, 'message': 'invalid signature'}
2024-11-18 22:27:55.030 WARNING (MainThread) [custom_components.xiaomi_miot.core.xiaomi_cloud] Error while executing request to https://api.io.mi.com/app/v2/homeroom/gethome_merged: {"code":0,"message":"invalid signature"}
2024-11-18 22:27:55.102 WARNING (MainThread) [custom_components.xiaomi_miot.core.xiaomi_cloud] Error while executing request to https://api.io.mi.com/app/home/device_list: {"code":0,"message":"invalid signature"}
2024-11-18 22:27:55.103 WARNING (MainThread) [custom_components.xiaomi_miot.core.xiaomi_cloud] Got xiaomi devices for<EMAIL_ADDRESS>failed: {'code': 0, 'message': 'invalid signature'}
2024-11-18 22:27:55.177 WARNING (MainThread) [custom_components.xiaomi_miot.core.xiaomi_cloud] Error while executing request to https://api.io.mi.com/app/scene/history: {"code":0,"message":"invalid signature"}
2024-11-18 22:27:55.178 WARNING (MainThread) [custom_components.xiaomi_miot.sensor] Get xiaomi scene history for xx xx failed: {'code': 0, 'message': 'invalid signature'}
2024-11-18 22:27:55.196 WARNING (MainThread) [custom_components.xiaomi_miot.core.xiaomi_cloud] Error while executing request to https://api.io.mi.com/app/scene/history: {"code":0,"message":"invalid signature"}
2024-11-18 22:27:55.197 WARNING (MainThread) [custom_components.xiaomi_miot.sensor] Get xiaomi scene history for xx xx failed: {'code': 0, 'message': 'invalid signature'}
2024-11-18 22:27:55.422 WARNING (MainThread) [custom_components.xiaomi_miot.core.xiaomi_cloud] Error while executing request to https://api.io.mi.com/app/scene/history: {"code":0,"message":"invalid signature"}
2024-11-18 22:27:55.424 WARNING (MainThread) [custom_components.xiaomi_miot.sensor] Get xiaomi scene history for xx xx failed: {'code': 0, 'message': 'invalid signature'}

Relogin

Relogin

I selected Auto Mode and 更新设备列表 and submitted the login request, then got this log.

Try master branch.
wget -O - https://get.hacs.vip | DOMAIN=xiaomi_miot ARCHIVE_TAG=master bash -

same issue here, tried master branch but it's asking for a captcha, REMOVED is because I removed the actual code
⚠ Login to xiaomi error: &&&START&&&{"code":87001,"desc":"验证码输入错误","captchaUrl":"/pass/getCode?icodeType=login&0.REMOVED","type":"manMachine"}

Same problem. api.io.mi.com says 404 when doing curl, could that be a problem?

Same issue with updated version 0.7.23
Got xiaomi devices for XXXX failed: {'code': 0, 'message': 'SERVICETOKEN_EXPIRED'}

master branch ...

Can you bump the version so it pulls update in HACS

Removing and re-adding the account worked for me.

I tried it...and it worked.
I deleted the old account and re-added it and now it works.

Automatically solved when installing v0.7.24. Thank you!


Does JS SDK retry failed tracked telemetry?

Hi,
From time to time we notice missing telemetry for our JS clients.
I wanted to check please whether the current SDK retries sending telemetry when the request fails or when there is a partial success.
If there are no retries, I would also suggest try sending an exception with the previous errors.
Thanks,
Ido.

Yes, the SDK will retry if it couldn't reach the AppInsights endpoint or if the endpoint returned a retriable error (e.g. server error, but not for quota exceeded or JSON parse error). The SDK will also log exceptions, internal exceptions will have "AI:" or "AI (Internal):" prefix.
Could you explain scenarios when you noticed missing telemetry?

Hi,
For some custom events, the count of our JS client side events is different than the equivalent server side events. There could be various of reasons of course but I wanted to eliminate temporary connectivity issues or similar causes.
We've also found a bug in our telemetry which was hard to discover - from time to time events were rejected by AI as we set null instead of a numeric value in a measurement. an SDK exception is such cases would be very useful.
Thanks a lot!
Ido.

The SDK will not send these type of errors by default. But you can enable verboseLogging - see IConfig. With verboseLogging logging enabled the SDK will send all warnings and critical errors to AppInsights.
You will be able to review them later in the Portal - search for Traces with 'AI ' prefix.
Please re-open this issue if you have more questions or comments. Thank you!

Great thank you very much.


Fix client side streaming example in the getting started guide

Thanks for the awesome library!
Unless I'm missing something, shouldn't this be stream.message() (i.e this function)?

@orf it can be both! The Streaming type implements Stream as well where you can use the StreamExt trait from the futures crate to call next on it.

Looks like the tutorial uses both versions which I think is good, so I think we can close this. Let me know if you have any questions :)

Ok! My bad, thank you @LucioFranco!


What's the meaning of matched objects and unmatched objects?

Hi, @orrzohar , thanks for your great work.
Here, I have some questions about your paper as follows:

what's the meaning of matched objects? Do them refer to the pairs of output embedding and its relative annotated labels (labels and boxes supervision)?

How to get the un-known objects bounding box after training?

Hi @luomingshuang,

Yes, exactly, matched queries/object proposals are query embedding/proposals that were matched to one of the GT objects via the Hungarian matching function (~had high overlap with GT box/label)
To get the unknown object bboxes you need to filter out the boxes with the label '80'

Best,
Orr

Cool，thanks.

Em, hi @orrzohar , another question is that all the boxes (including unknow objects and class-known objects) are generated by the  f_bbox head when inference?

Hi @luomingshuang,
The f_bbox head generates both unknown and known bounding boxes but only has known object supervision, i.e., in training, there is no GT box supervision for unknown objects (this would violate the open world assumption. see datasets/torchvision/open_world, where all cls_ids not in the known range are filtered out).
This is a task of generalization and learning to detect unknown/novel objects given only known/labeled object supervision. Essentially, the f_bbox head needs to learn to localize all the objects in an image given only partial labeling, and the cls head learns to classify each proposal into either a known class, background, or unknown object.

Thanks a lot.


Show custom view

Added ability to show custom view

Will close for now as we do not plan to integrate the proposed enhancement. However, I am grateful for your work on and with our component. Please continue contributing to open source software, this helps a lot.


Added "mode_overrides_title" property to FileDialog

My personal way of fixing #10007. This boolean makes that, if true (the default), changing the FileDialog's mode will change the window title accordingly, which is the normal behaviour before this pull. But if false, it will keep whatever title it is currently on.

Why not test if the title is empty?

@Zylann Then the title would only be changed by the very first mode change when empty, not being able to be changed by subsequent mode changes.

Hmm it feels odd to me to mix two meanings on the same variable (automatic title and custom title) but I guess it would involve more changes...

If this API a bit weird, but I can't think of a better way to solve this use case, so I guess it's good enough :)


Support for sorting

Sorting should be done in the backend (i.e. as part of the query, sorting over the entire result set)
Can be passed in as tuple (column, direction)
UI: make this a section of the dropdown - NOTE: this means not hiding the entire dropdown in read-only mode.

DUPLICATE of #23.


Question: Does anyone uses DBFlow with RxJava/RxAndroid?

Any experiences with DBFlow and RxJava?
Something which shouldn't be used?
Any comments?

I use the combo and they work pretty well together. Are there any particular queries about them?

In the near future - definitely. :-)
Can I ask you if I have some trouble?

a) How do you use RxJava and DBFlow? Do you load models for a list or "only" single model loading?
b) Do you also use RxJava for saving models?
My workflow:

I get a lot of objects/models from a server (JSON) and I want to store them.
Then want to load and show them in a RecyclerView - if there is a new model in the database I want to load and show it in the list immediately.

a - both
b - yes
I'm doing the same thing as you, I'm not sure if this is the best way of doing so but my code is like this for getting messages from a server
 public Observable<List<Message>> getConversation(String userId) {
        return Observable.create(subscriber -> {
            subscriber.onNext(messageListQuery(userId));
            webService.getMessages(userId).subscribe(res -> {
                for (ApiMessage m : res.results) {
                    Message message = m.toDbModel();
                    message.save(false);
                }
                subscriber.onNext(messageListQuery(userId));
            });
        });
    }

    private List<Message> messageListQuery(String userId) {
        return new Select().from(Message.class).where(Condition.column(Message$Table.USERFK_USERID).is(userId)).queryList();
    }

where webService.getMessages() returns an Observable (using Retrofit)

just short answer before looking deeper in your answer. :-)
I also use Retrofit.


[Texture Factors] New Mix node (in 3.4) isn't exported like the old MixRGB node was.

Describe the bug
Back in 3.3 (or maybe 3.2) you were able to add a MixRGB node to factor a color to any texture. It was especially useful for AO textures, you'd mix them with white to control their intensity. Since 3.4 MixRGB node became Mix node and it doesn't seem to work anymore (I'm just assuming this is due to the change to the MixRGB node but it could be unrelated).
By the way the documentation is using the outdated MixRGB node, so this should be fixed as well.

To Reproduce
Steps to reproduce the behavior:
Export the .blend I provided to .glb and open it in a threejs viewer, you'll see the AO texture is at full intensity (very dark) even though the Mix node is set to a factor of .5
Expected behavior
The AO texture should be exported at 50% intensity
Screenshots
This should work but does not:

.blend file/ .gltf
Sofa_Mood_NewYork.zip
Version

OS: Windows
Blender Version 3.4

Additional context
You can also try to Mix the basecolor with white and it still won't work (unlike what is stated by the documentation) so I'd say it's most likely something wrong with the new Mix node.

#1804.
Although for AO, it should switch to use a Mix Float node now instead of a Mix Color node (Color was only used because there wasn't a way to lerp floats before), with Mix Color still supported by the exporter for back compat.

My bad I searched "MixRGB" in opened issues, not closed ones, rookie mistake. Glad this is taken care of already!


Possibility to specify resources and limits for services containers

Hi,
I'm using ARC with runner-container-hooks in kubernetes mode.
I'd like to be able to define resources/limits for the services.
When service container is added to the container job pod, it has no resources defined, which, in my case, is not accepted (I need to provide some resources, otherwise I will get default values, which are way to small to operate).
Currently, the only way to do it, is to use ACTIONS_RUNNER_CONTAINER_HOOK_TEMPLATE providing services as fixed containers in the spec, which means I cannot use them from workflow - I will end up with containers with names that are duplicated (from service and from pod spec).
Am I missing something?
Would it be possible to either provide resources from workflow, or to follow $job pattern (from the hook) to only adjust service containers?

Hey @katarzynainit,
I think the best approach is to follow the $job pattern and re-use it for services. This would be a good improvement of the hook extension for sure.

Understood!
Any possibility to see such option on the "backlog"? Or you'd rather expect contribution? :)

I can take this one, unless you would like to contribute :relaxed: I can review it

Will ping you with PR once it's ready :)

Hi @nikola-jokic
Can you please check https://github.com/actions/runner-container-hooks/pull/136 ?

Hi @katarzynainit,
thanks that you brought up this topic!
What I am wondering here https://github.com/actions/actions-runner-controller/discussions/3338 is it possible to set just one spec for all service containers?
Or would this be part of an additional implementation phase @nikola-jokic ?

Hey @katarzynainit,
I'm sorry for the delay. I hope I'll review these changes this week, and we can issue a new hook release for them :relaxed:
Thank you again for your contributions!
@David9902 With the current change, no, but there could be a way of having $service as container to specify it. I'll reach out to the team to get a second opinion, and I'll let you know :smile:

Thanks for merging the PR :)
I'm leaving the issue open as there is additional discussion with @David9902


Fix GITHUB.SHA and GITHUB.REF for repository_dispatch

Why:
Fixes https://github.com/github/docs/issues/1494

What's being changed:
I've changed the GITHUB.SHA and GITHUB.REF values to refer to the default branch.

Check off the following:

[x] All of the tests are passing.
[x] I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
[x] For content changes, I have reviewed the localization checklist
[x] For content changes, I have reviewed the Content style guide for GitHub Docs.

@ba32107 Thanks so much for opening a PR! I'll get this triaged for review 💖

Hi @janiceilene, just commenting so the PR doesn't go stale. Any chance this could be reviewed? Thanks.

@ba32107 Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

Bump


Emoji reaction not working

https://photos.app.goo.gl/9HoLpEiRFcj99BXPA

Bug Report Dump (Auto-generated)

Version 1.20.0<PHONE_NUMBER>)
Device: iPhone X (iOS 11.3)
TestFlight: false

https://github.com/fastlane/fastlane/issues/12573
Emojis seem to have been disabled for one reason or another, wonder if we can pick up the error and see if there's an API to detect it. Might be the temporary lock feature?

Can anyone get the network response? Are you able to disable emoji on repos? Or specific issues?


Support for runtime permissions for Android and iOS

Android M, and iOS, both have a concept of runtime permissions. A customer asked if this was possible to use inside of Flutter.

@sethladd @abarth is there any work here? As far as I understand it, this is transparent to the app. You simply request permissions in the manifest and code, and the OS takes it from there?
https://developer.android.com/training/permissions/requesting.html#perm-check

Would the UI ever need to determine if a permission has been granted yet (or not) ? For example, would I want to show UI screen A or B if a permission has been granted ?

Yes, good catch. The UI is actually expected to do that (as the user may decline the permission, and the app is expected to deal with that), e.g.:
// Assume thisActivity is the current activity
int permissionCheck = ContextCompat.checkSelfPermission(thisActivity,
        Manifest.permission.WRITE_CALENDAR);

From discussion today this is a documentation gap, not a framework gap. We should document that if a plugin needs a certain permission x, then best practice is to offer hasPermissionX method in the Dart API of the plugin.

My understanding from @lukef was the permission dance on iOS and Android were a non-trivial amount of code.  So much so he was considering writing a flutter plugin to help with such?

I'm not sure I understand. The there are many different checks, so the actual checks would need to be placed where the native code under those checks is located. @lukef can you elaborate?

It's not clear what is being requested here. @mit-mit If there's something we should document, can you file a bug specifically saying what should be documented? Thanks!

We have an early stage plugin here: https://github.com/goposse/permit.
It is NOT ready for any kind of integration, but it will support common permission on iOS and Android. We decouple the permissions from the feature as it is generally impossible to integrate the two and have acceptable UX.
I'll let you know when it is refactored and ready for review.

The goposse/permit library is no longer maintained. Other than forking it (I'm a beginner with Dart, won't know what I'm doing), what alternatives are there?

You can look at the permit code as a good starting point however, you should definitely invest in an understanding of how the permissions work on iOS and Android as they are system level requirements and they can change from time to time.
Some plugins will implement permissions directly as well so you could check to see if there is a plugin that you can use that will provide that feature also.

Thanks @lukef, I'll invest time in understanding permissions, I'm concerned with Android for now, so I'll spend time there first

Feel free to leave a question on stack overflow as well. That way I (or someone else) can answer and other people who might get stuck can benefit!


2D array Proposal

hi, i would like to propose the addition of 2D Array as an Object just like Array is
he is a post ive created in reddit that demonstrates sort function in a 2D array
https://www.reddit.com/r/godot/comments/78kp8x/bubble_sort_for_2d_array/
the 2D array in the post is sorted according to their rows.
if it will be an Object in Godot, here are some of its functions that i would like to propose

Array2D.sort_column(int,bool) #int = number of column, 0 is the start. bool = true if ascending order
sort the Array 2D accorring to the column selected
Array2D.sort_row(int,bool) #int = number of row, 0 is the start. bool = true if ascending order
sort Array 2D accourding to the row selected

here are just some. really love Godot and this is what i think it lacks (as well as Batching)

I know I recommended that you migrate this proposal here, but I'm thinking to myself that this object actually doesn't really reflect the particulars of this repository. An Array2D type would be a Reference extending type rather than anything extending Node, and this repo is for Node-based extensions. Perhaps I should create a supplemental godot-data-extensions repository that mirrors this one, but is dedicated to data structures and utilities instead.
Gimme a few minutes and I'll set something up.

Ok, I'm done getting it set up. Please re-create this issue there and we can move forward with an implementation for an Array2D there. 👍

Thanks Will, sorry if i misplaced my issue here, will do as you said, thanks!

@lainv0hndyrec No, not your fault. I was the one who told you to post it here in the first place. I just realized it didn't quite fit after-the-fact. ^_^


Expose inventory to the deploy

Is your feature request related to a problem? Please describe.
When setting up master/slave (or broker/workers) architecture, I like to whitelist connections. Currently I have to duplicate definitions in the host.
Describe the solution you'd like
Enable access to siblings in the same group, maybe via host.siblings to allow something like this
generator_pipeline = ["broker", "worker1", "worker2"]

brokers = [
   ("broker", {"allow":"generator_pipeline"},
]

or some kind of other reflection to allow accessing inventory

@Tezar it should be possible to achieve this using group data files and importing inventory, for example:
# inventory.py
brokers = ["broker"]
workers = ["worker1", "worker2"]

# group_data/brokers.py
from pyinfra import inventory
allow = [host.name for host in inventory.get_group('workers')]

This is only possible within data files because the inventory has to be fully parsed before it can be used, ie it can't self-reference within the same file. Does this help?

Thanks @Fizzadar , this (or something like this) will work for my use case.
Actually knowing that I can access inventory in this manner even from deploy solves this, since I can call
inventory.get_group(host.data.allow) directly within the deploy file.


feat(RHTAPREL-731): add script to promote changes

This commit adds a script to create a PR that will promote changes from development to the staging branch, or from the staging branch to the production branch.

I still need to test this but I updated it so feedback can be posted as if it works, I don't expect to make many changes or any at all

I still need to test this but I updated it so feedback can be posted as if it works, I don't expect to make many changes or any at all

Cool. I wonder if it would make sense to simply do a force push of development to the staging branch next time we promote - just to get rid of the previous mismatches between the branches. But if you think it's not necessary and it will still work ok, I'm fine without it too.

I still need to test this but I updated it so feedback can be posted as if it works, I don't expect to make many changes or any at all

Cool. I wonder if it would make sense to simply do a force push of development to the staging branch next time we promote (one time only) - just to get rid of the previous mismatches between the branches. But if you think it's not necessary and it will still work ok, I'm fine without it too.

I plan to overwrite staging and production one time with force pushes, yes. This is almost ready, but it seems it only works the first time. So, I am going to switch it to creating a new branch on the user's repo instead of directly merging like development into staging

I changed the --override --force-to-staging flags to parameters so in the future github action I can do
script: promote-branch.sh --force-to-staging $FORCE --override $OVERRIDE
  env:
    FORCE: {{ inputs.force-to-staging }}
    OVERRIDE: {{ inputs.override }}

I didn't see a way to make this work for manual invocation in a github action while keeping them as flags


MoSQL::Schema::PGError (NameError)

Hi,
When I run the command mosql --collections collections.yml --skip-tail for importing data from Mongo db to Postgre, I am getting the following error.
`rescue in block in copy_data': uninitialized constant MoSQL::Schema::PGError (NameError)
SQL Tables are creating successfully. But the data is not imported.
Any idea about this issue?

@thejusss, Were you able to make this work ?

@thejusss I was getting the same error. I was using an unsupported data type called UUID in my collections.yml. Replaced it with CHARACTER VARYING and I was able to successfully import the data.

from a performance perspective, UUID is much better comparing to CHAR, that's very important due to nature of MongoDB id.

Solved!
Just downgrade the 'pg' gem version to 0.21 version. The constants PGError and another similar are deprecated from 1.0.0 'pg' gem version.


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative-sandbox/networking-wg-leads
/assign knative-sandbox/networking-wg-leads
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping k8s.io/apiextensions-apiserver 7e2da33...cf300a6:
  > cf300a6 Update dependencies to v0.23.9 tag
bumping knative.dev/pkg 6c9c1c6...a01dfed:
  > a01dfed bump to k8s 0.23.9 (# 2565)
  > 449f7e6 Update community files (# 2564)
  > ed7ab1d upgrade to latest dependencies (# 2559)
bumping knative.dev/hack 782bbaa...9dabf7c:
  > 9dabf7c Update community files (# 206)
bumping k8s.io/apimachinery 276a8a7...276a8a7:
bumping k8s.io/api e08b72c...f89a761:
  > f89a761 Update dependencies to v0.23.9 tag
bumping knative.dev/networking cddb0ff...d2c739d:
  > d2c739d upgrade to latest dependencies (# 698)
  > 20876d7 bump go.mod to v1.18 (# 694)
  > 19a4157 remove defunct markdown linting variable (# 696)
  > 8baa0ac upgrade to latest dependencies (# 692)
  > d6a574e Update community files (# 697)
bumping k8s.io/client-go 14fa49e...11f68c5:
  > 11f68c5 Update dependencies to v0.23.9 tag
bumping k8s.io/gengo 4627b89...397b4ae:
  > 397b4ae Merge pull request # 227 from SimonBaeumer/add-gitignore
  > 940203f Merge pull request # 226 from SimonBaeumer/add-link-to-code-generator
  > 6697a9b Add IDE config files to .gitignore
  > 6c88d16 Add link to code-generator tree in introduction text
  > 7b3c0fe Add .idea/ to .gitignore
bumping k8s.io/code-generator 31c00a6...31c00a6:
bumping k8s.io/klog/v2 43cc75f...0990e81:
  > 0990e81 Merge pull request # 342 from pohly/harshanarayana-reviewer
  > 33351c0 Merge pull request # 341 from pohly/contextual-logging-state-fix
  > 442891b OWNERS: add harshanarayana
  > ea66a13 Merge pull request # 337 from pohly/testing-logger-stop
  > c2d5a45 contextual logging: enable by default again
  > 7a070b4 Merge pull request # 333 from harshanarayana/tests/GIT-275-add-additional-test-for-kv
  > 9405f8e ktesting: stop using testing.T when test completes
  > 265aa25 Merge pull request # 327 from pohly/buffer-logger
  > 280fc18 GIT-275: add tests for int and struct keys
  > 78f38f6 ktesting: fix type assertion
  > ca252b1 Merge pull request # 328 from pohly/fatal-backtrace-revert
  > 325472d ktesting: capture log data in memory
  > 66544b3 ktesting: use black box testing
  > 49e17d5 Merge pull request # 332 from harshanarayana/bug/GIT-331/fix-variable-shadown
  > c5c3132 klog.Fatal: document behavior and alternatives
  > 6b3fb0b Merge pull request # 329 from pohly/apidiff-fix
  > 9c48b7d Merge pull request # 330 from pohly/logtools-removal
  > e4329d2 GIT-331: fix shadowing key from the kv pair
  > c977919 klog.Fatal: revert dumping of all stack backtraces to stderr
  > ea35802 Merge pull request # 320 from pohly/state-restore
  > 49d73a5 GitHub: use apidiff with more recent Go
  > e9884d2 remove hack/tools
  > a585df9 Merge pull request # 326 from pohly/remove-trim-duplicates
  > 3c90bf9 refactor global state
  > 788efcd Merge pull request # 325 from pohly/logr-marshaler
  > cebb190 internal: remove unused TrimDuplicates
  > 296f5e6 save and restore state
  > 42bf7a2 Merge pull request # 322 from pohly/kobjs-performance
  > 369b848 support logr.Marshaler
  > cc2ce06 Merge pull request # 315 from pohly/logcheck-regexp
  > 87ca629 Merge pull request # 324 from pohly/trim-duplicates
  > 8a3e48e replace KObjs with KObjSlice
  > c697110 Merge pull request # 314 from pohly/stop-flush-daemon-clarification
  > 5079582 logcheck: fix detection of invalid * regexp in filter
  > 7a827a0 Merge pull request # 319 from pohly/klog-help-texts
  > 4c3943c use faster MergeKVs
  > ff92e06 test: add benchmark for KObjs
  > d07cbbf Merge pull request # 313 from pohly/logcheck-contextual-logging
  > 47f254f StopFlushDaemon: document flushing on shutdown
  > 2910cb1 README.md: clarify -logtostderr
  > 6f47a32 klogr: simplify test failure message
  > 4a4a786 Merge pull request # 297 from pohly/logcheck-contextual-logging
  > 7179178 hack/tools: drop dependency on golangci-lint
  > e2432e8 serialize: add MergeKVs as faster TrimDuplicates alternative
  > b46e95d Merge pull request # 311 from pohly/contextual-logging-stable
  > 1876dee logcheck: harmonize report messages
  > e6d69a5 serialize: benchmark and test TrimDuplicates
  > 7b1c318 Merge pull request # 310 from pohly/fork-clock
  > 36e44e7 promote non-test APIs to stable
  > 216a02e logcheck: add check for With* and NewContext
  > e3af9af dependencies: avoid k8s.io/utils, fork clock code instead
  > 317fe52 logcheck: optionally warn about using direct klog logging
  > 41995aa logcheck: detect if V().Enabled()
  > 5b4c326 logcheck: warn about functions with both Logger and Context
  > 567c037 logcheck: support logr.Logger
  > c4c35ff logcheck: support import renaming and improve klog.V(2) handling
  > df531eb logcheck: support running as golangci-lint plugin
  > 3f08024 logcheck: also check for format specifier in calls like klog.Info
  > 0c36cf7 logcheck: move into package
  > 93980ca logcheck: add test cases for parameter check

/retest
/lgtm
/approve

/retest

/lgtm
/approve


这次重构后新发布的版本就是一坨shit！！！！

连播放下一曲都会崩溃的版本，不知道是怎么release出来的！！！！
随机循环模式，任意播放列表都会出现
Exception in thread Thread-1:
Traceback (most recent call last):
File<EMAIL_ADDRESS>line 801, in __bootstrap_inner
self.run()
File<EMAIL_ADDRESS>line 754, in run
self.__target(*self.__args, **self.__kwargs)
File "build/bdist.macosx-10.13-x86_64/egg/NEMbox/player.py", line 251, in run_mpg123
self.next()
File "build/bdist.macosx-10.13-x86_64/egg/NEMbox/player.py", line 409, in next
self.next_idx()
File "build/bdist.macosx-10.13-x86_64/egg/NEMbox/player.py", line 386, in next_idx
self.shuffle_order()
File "build/bdist.macosx-10.13-x86_64/egg/NEMbox/player.py", line 323, in shuffle_order
self.order.clear()
AttributeError: 'list' object has no attribute 'clear'

You can you up.


When using GitHub Pull Requests and Issues extension, TSServer and electron crash

Issue Type: Bug
Repro step:

See .ts file diff with GitHub Pull Requests extension
TSServer crashes

[Info  - 02:34:42.568] Using tsserver from: /Users/yk-yamada/.vscode-insiders/extensions/ms-vscode.vscode-typescript-next-4.6.20220211/node_modules/typescript/lib/tsserver.js
[Info  - 02:34:42.568] <syntax> Forking...
[Info  - 02:34:42.569] <syntax> Starting...
[Info  - 02:34:42.570] <semantic> Forking...
[Info  - 02:34:42.572] <semantic> Starting...
[Info  - 02:34:43.947] TSServer exited. Signal: SIGABRT
[Info  - 02:36:34.430] Starting TS Server
[Info  - 02:36:34.430] Not starting server. Too many crashes.

Extension version: 1.3.3
VS Code version: Code - Insiders 1.65.0-insider (Universal) (bb221a61d29deabd99ee9431736d04f2175cb596, 2022-02-11T05:16:57.139Z)
OS version: Darwin x64 21.2.0
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
5, 4, 4

Memory (System)
32.00GB (0.35GB free)

Process Argv
ui

Screen Reader
no

VM
0%

A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256197
vstes627:30244334
pythonvspyl392:30422396
pythontb:30258533
pythonptprofiler:30281269
vshan820:30294714
pythondataviewer:30285072
vscod805cf:30301675
pythonvspyt200:30323110
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
pythonvs932:30404738
wslgetstartedc:30421358
vsclayoutctrt:30405800
dsvsc009:30436273
pythonvsnew555cf:30426299
vsbas813:30436447
vscscmwlcmt:30428973
azactmsalcf:30432849

From https://github.com/microsoft/vscode/issues/143135, the last line of the log are:
Info 3244 [12:28:07.440] [typescript-tslint-plugin] "Computing tslint semantic diagnostics for '^/review/Users/jkearl/Developer/vscode/src/vs/workbench/common/webview.ts'"
Info 3245 [12:28:07.440] [typescript-tslint-plugin] "(runTsLint) start"
Info 3246 [12:28:07.440] [typescript-tslint-plugin] "(loadLibrary) trying to load ^/review/Users/jkearl/Developer/vscode/src/vs/workbench/common/webview.ts"
Info 3247 [12:28:07.440] [typescript-tslint-plugin] "(getGlobalPackageManagerPath) Begin - Resolve Global Package Manager Path for: npm"
Info 3248 [12:28:07.852] [typescript-tslint-plugin] "'npm config get prefix' value is: /usr/local"
Info 3249 [12:28:07.852] [typescript-tslint-plugin] "(getGlobalPackageManagerPath) Done - Resolve Global Package Manager Path for: npm"

I suspect either the extension or tslint itself is treating the in-memory file as a on-disk file, and then not handling the resulting errors

Please test out the latest version of this extension. If it still doesn't fix the problem, I'll reopen but likely won't have time to investigate myself


PR: Do not import spyder before install_repo in bootstrap.py

Issue(s) Resolved

Fixes #19832
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @mrclary

/show binder

@ccordoba12 @dalthviz, Spyder now launches in Binder, but there are still a few problems. The following missing dependencies are, indeed, missing from the conda environment, but I'm not sure why.

Okay, it seems that Binder behaves differently when built from the 5.x branch vs. the master branch. I'm not sure exactly why that is.
The binder link above, in this PR, on 5.x, results in the repository copied to a "spyder" directory in the home directory and missing dependencies in the environment. The shortcut on the desktop is labeled with 5.x.
I cherry-picked this PR's changes onto the master branch in my fork and built the binder from there and found that the repository is copied to the home directory and all dependencies are installed and Spyder launches and runs fine. The shortcut on the desktop is labeled with 4.x.
So I suppose everything is okay if run from the master branch. But it seems that some idiosyncrasies should be cleaned up at some point.

Spyder now launches in Binder, but there are still a few problems. The following missing dependencies are not installed in the environment and I'm not sure why.

@mrclary, we've talked about this before but probably you forgot it. So, we create Binder links for PRs through an associated repo to avoid rebuilding the Binder instance on every PR commit, which is very inefficient:
https://github.com/spyder-ide/binder-environments
However, I haven't had time to update it in a long time, hence the missing dependencies.
I propose to do the following to improve the situation regarding Binder:

Remove the binder folder in this repo to use the one in binder-environments instead (there's a branch on it per branch here).
Update the 5.x, master and spyder-stable dependencies in binder-environments with the latest changes here. Right now, those branches are separate, but you can push directly to them and then check that the Binder image is built as expected by clicking on the launch | binder button of the Readme associated to each branch.
Create a subrepo for binder-environments in external-deps and sync it with the corresponding branch here.
Change test_dependencies_for_binder_in_sync to do use external-deps/binder-environments/binder/environment.yml instead.
Add a section in CONTRIBUTING.md explaining how to add/update a new dependency in binder-environments. Perhaps we should start merging from 5.x to master on that repo so that contributors don't have to open two PRs there.
Remove the launch | binder button in our Readme and add a new section instead called Run Spyder in your browser. That should contain a small explanation of what Binder is and three buttons (you can create custom Binder buttons here):

launch | stable version: That will use the link of the Binder button in https://github.com/spyder-ide/binder-environments/tree/spyder-stable.
launch | 5.x: It'll use the link in https://github.com/spyder-ide/binder-environments/tree/5.x
launch | master: It'll use the link in https://github.com/spyder-ide/binder-environments/tree/master

Add a new instruction in RELEASE.md so that our release manager don't forget to update the dependencies of the spyder-stable branch in binder-environments.

This way we'd make sure that binder-environments is always up to date and it could be used reliably by users.
@mrclary, I think this would be a cool project for you to take on. Besides, it'd be great if you could work on it because I'm really busy with other things.


CodeLens features are not showing up in .NET Core applications

Ported from TFS - filed by @balachir
REPRO STEPS

New ASP.NET Core Web Application (.NET Core) > Web Application
Open Controllers\HomeController.cs

EXPECTED
CodeLens features to work in the cs file
Actual:

This doesn't repro anymore.


Removing unused tables files in shared memory.

Using repeatedly the temperature.set command may cause an error due to the maximum number of files that can be opened per-process. I added some lines to avoid that.
There is also a fix int the README.md:
gdbus call -e -d net.zoidplex.wlr_gamma_service -o /net/zoidplex/wlr_gamma_service -m net.zoidplex.wlr_gamma_service.temperature.set 4000

instead of
gdbus call -e -d net.zoidplex.wlr_gamma_service -o /net/zoidplex/wlr_gamma_service -m net.zoidplex.wlr_gamma_service.set_temperature.set 4000

Thank you!


⚠ ClamAV has degraded performance

In 2960cc8, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 566 ms

Resolved: ClamAV performance has improved in 074cfd2 after 5 minutes.


DN-FPN module

Dear Author,
I am honored to have the opportunity to read your work. In your paper, you mentioned that the DN-FPN module is a plug-and-play module. However, I couldn't find the related code. Could you please point out the location of this code in more detail? Thank you very much.

Hi, please referred to Issue#3. Thank you.


Object gen & Collision detection

Forgive me for combining the two, but it simply made coding and testing a bit easier.
The obstacles are stored as Rect objects. Separately, it keeps track of which obstacles are currently visible in screen. This allows for faster rendering and collision detection. Currently the obstacles are drawn with a simple GL_LINES, though a prettier implementation (hopefully with 3d objects) will follow.
@alexwalterbos RFR!

Looks good! :+1:


Update css-image-orientation.json

Safari TP version 103 supports image-orientation CSS3 property

Are you sure? Looking at https://developer.apple.com/safari/technology-preview/release-notes/ I see mentioning of using the EXIF image orientation but there's no mention of the image-orientation property. In which case it should probably match the a #1 support that iOS Safari already has.

Closing until further info is provided.


[Service Bus] Support for OperationOptions in management operations

Issues:
#8172 - Operations should support canceling via abort signal and tracing, and the requestOptions set by the user.
#9638 - OperationOptions for AMQP vs HTTP
TO DO:

[x] Separate interfaces for OperationOptions and OperationOptionsForHTTP
[x] Plug in the new options before sending the request
[x] Add operationOptions argument for all the methods
[ ] Handle tracing at all the levels starting from the user facing APIs till the executeXMLRequest that calls coreHttp.sendRequest
[x] Add tests for abort signals, and for the various options set by the user with requestOptions
[x] Changelog

/azp run js - servicebus - tests

/azp run js - servicebus - tests

/azp run js - servicebus - tests

I would recommend implement tracing support out of this PR.

I was thinking the same.

/azp run js - servicebus - tests

/azp run js - servicebus - tests

/azp run js - servicebus - tests

/azp run js - servicebus - tests

One unrelated test failed in the browser, not doing anything.


Don't force http scheme when using virtual host

ExAws must not force the http scheme for S3 urls when using virtual_host: true.
AWS fully supports serving objects via HTTPS with virtual hosts.
In fact, some regions (notably Oregon) require the virtual_host format, and serve a 301 permanent redirect if you attempt to use the path-based format. So ExAws currently cannot produce an https url for Oregon buckets at all, breaking usage in these regions.
The only caveat (which I assume this logic was trying to fix initially) is if you create a bucket which is not DNS compliant.  However, this is thoroughly documented throughout AWS's documentation.

When using virtual hosted–style buckets with SSL, the SSL wild card certificate only matches buckets that do not contain periods. To work around this, use HTTP or write your own certificate verification logic.

@benwilson512 Let me know if there's anything else I can help clarify regarding this.  When you give the :+1: I can fix the tests.

Ah this is clearly an oversight on my part. Thanks! The tests are just failing because PRs from other people don't include the AWS keys used in some of the tests.


Add bash completion for docker plugin upgrade

Ref #29414
As the corresponding feature will be added in 1.13.1, this PR should go there as well.
Ping @sdurrheimer for zsh completion
Notes for reviewers:
The first non-option is completed as <plugin name:tag>. Completions that include : require __ltrim_colon_completions so that they work on the part after the colon.
The following argument is completed to the available plugin names without the tag, but with a colon appended.

@mlaventure For me, the PR works if cherry-picked onto 1.13.x. Maybe you forgot to install a plugin when you checked?

hum, I had vieux/sshfs installed. Let me double checked, maybe I had the old binary running.

@albers I have the issue with all the plugin commands that should complete on the plugin names actually.
I tried on top of e5a90d4

@mlaventure Maybe #30867?

That's really strange. Maybe I'm doing sonething wrong. Here's what I did:
$ git branch
* master
$ git fetch origin 1.13.x
From https://github.com/docker/docker
 * branch            1.13.x     -> FETCH_HEAD
$ git checkout 1.13.x
Branch 1.13.x set up to track remote branch 1.13.x from origin.
Switched to a new branch '1.13.x'
$ git fetch albers completion-plugin-upgrade
From https://github.com/albers/docker
 * branch            completion-plugin-upgrade -> FETCH_HEAD
$ git cherry-pick 2c52ec8403d721e567a7c3c129fc38c650b85ba4
[1.13.x 32428de] Add bash completion for `docker plugin upgrade`
 Date: Wed Feb 8 13:40:13 2017 +0100
 1 file changed, 20 insertions(+)
$ git log --oneline -2
32428de Add bash completion for `docker plugin upgrade`
e5a90d4 Merge pull request #30875 from albers/fix-30858
$ make binary shell BIND_DIR=.

In a separate shell
$ docker exec -ti $(docker ps -lq) dockerd

Back in DIND
root@1af0ae499ea0:~# docker plugin install --grant-all-permissions vieux/sshfs
latest: Pulling from vieux/sshfs
86b5589884b3: Download complete
Digest: sha256:e5e584b1a2d0855d0be5817506e07f774c7c248db42015caa1e605a60c256007
Status: Downloaded newer image for vieux/sshfs:latest
Installed plugin vieux/sshfs

root@1af0ae499ea0:~# docker plugin upgrade <tab>  # works!

@albers rebuilt my docker-dev image (I tend to keep them around a while), it seems to work now. Not sure what was wrong.
Let's get this merged :)

@mlaventure Thanks! Are you working on Ubuntu?

I am yes, still on 14.04.5 though


Aerospike client 3 not working

Hi, I have installed v3 C client and it seems not supported (failed at get_client() with KeyError(3,0)).  Any idea? Is this still active?
thanks,

Hi,
The implementation for Aerospike 3 is nonexistent, as per the status matrix. Aerospike 2 LibEvent is known to work in production (my employer uses it), but I designed this to be easy to extend (see https://github.com/benjolitz/aerospike/blob/master/aerospike/implementations_as2libevent.py)
Still, since we've just moved our servers to AS3, I plan to get a rudimentary nonblocking interface using pthreads and lock-free queues. On a side note, I contacted Aerospike and learned that Aerospike 3 servers are backwards compatible with Aerospike 2 clients.
In short,
-- Pull requests are more than welcome.
-- As a stopgap, if you need basic Aerospike functionality (version 3 is really defined by aggregates, UDFs), I suggest getting the Aerospike 2 LibEvent 2 C client and trying this library.

And yes, it is still active. I've been tied up in work of late.

Hi @benjolitz,
Thanks for responding. Ok, I'll try with ver. 2.  Do you know where I can download ver. 2 C client? There web site only has ver. 3 available.
And thanks for sharing!
James

http://www.aerospike.com/download/client/libevent/2.1.41/
Ben

On Jan 6, 2015, at 6:00 PM, James Wong<EMAIL_ADDRESS>wrote:
Hi @benjolitz,
Thanks for responding. Ok, I'll try with ver. 2. Do you know where I can download ver. 2 C client? There web site only has ver. 3 available.
And thanks for sharing!
James
—
Reply to this email directly or view it on GitHub.

Oh you are fast!
somehow overlooked that. Thanks again!

Hi @benjolitz,
I built the v.2 client.  It default to static link lib and so I change it to use the Makefile.native which produce the .so.
Do you remember you had to do a lot of tweaking to the makefile in order to get it to work?  So far I have to add "-lssl, -levent-2.0" to the LDFLAGS in order to produce a .so which will work with CDLL("libev2citrusleaf-2.0.so.1").  However, the ctypes.util.find_library("ev2citrusleaf-2.0") still doesn't return.
The "ld -lev2citrusleaf-2.0" failed at ld: warning: cannot find entry symbol _start; not setting start address
thanks

Here is the patch I use to build Aerospike LibEvent2 on Linux:
https://gist.github.com/benjolitz/bbdb48ed33eb50711f23
Drop it into the top level source directory for the C driver (citrusleaf-XXX) and apply it with patch -p1 < patch_name.patch where patch_name.patch is the content of the above link.
With regards to being recognized by ctypes.util.find_library, placing the shared libraries into /usr/lib usually does the trick.
The weakest part of this entire system is, unfortunately, Aerospike's poor configuration paired with the Python Standard Library's not-so-good ability to locate shared libraries.
Let me know how it goes!

Hey @benjolitz,
Thanks a lot!   Though I have several questions, now I can do basic put/get key.

What is the expected signature of callback for put_key()?
Somehow I can't get the put_key() to store string value right.

client.put_key(cb, "test", "demo", "As", name="AS Inc", address="CA US", id=1001)
(None, {}, 1,<PHONE_NUMBER>) {}

client.get_key(cb, "test", "demo", "As", 1000)
(None, {'name': "\xe0 \x94\xbf'\x7f", 'address': "\xe0 \x94\xbf'"}, 1, 2591989) {}
(Where the "cb" callback simply print *args, **args)

So, the "id" bin is missing and the string bins (name/address) returned as hex code.
However, using the C client cli would retrieve all 3 bins (id is correct, name/address is the same hex code)
Any suggestions?

Seems the batch operation (get_many/put_many) are not done yet, right?

Thanks again for your help.
James

You're welcome.
The callbacks have the signature of (error_code, bins, generation_val, expiration_val), where error_code is an integer or None, bins are key-value pairs if the operation should return them (via a get), generation and expiration vals are relevant to the generation count and expiration (if specified in seconds).
With regards to your example, delete the key and try placing only string values in it:
Example (in the CLI):
$ aerospike-cli --host xxx.xxx.xxx.xxx
/snip
>>> bl_put_key('test', 'demo', "As", name="AS Inc", address="CA US", id='1001')
(None, {}, 4,<PHONE_NUMBER>)
>>> bl_get_key('test', 'demo', 'As')
(None, {'id': '1001', 'name': 'AS Inc', 'address': 'CA US'}, 4,<PHONE_NUMBER>)

I believe you've found a long standing bug (one that I think I understand well enough to tackle now), but let's verify that it is an error inside the integer encoding function by using only string values.
And Batch operations are unimplemented. currently. One consequence of building this driver for production at my employer was that we were forced to create a minimum spanning set of functionality.
I'd like to resolve that by gradually getting missing/buggy functions working perfectly.

How did you start this "aerospike-cli"? I can't locate it.  So I'm still using the python repl to do that.
And somehow, the string data are not being pulled out correctly as shown below,

client.put_key(cb, "test", "demo", "As3", name="AS Inc", address="CA US", id="1001")
(None, {}, 1,<PHONE_NUMBER>) {}

client.get_key(cb, "test", "demo", "As3")
(None, {'id': '\xe0 \x94\xbf', 'name': "\xe0 \x94\xbf'\x7f", 'address': "\xe0 \x94\xbf'"}, 1, 2591986) {}

So I think the integer type is being saved correctly as the following test suggests (note my use of different clients to perform put/get),
Using pypy repl to put_key works,

client.put_key(cb, "test", "demo", "As5", age=999)
(None, {}, 1,<PHONE_NUMBER>) {}

In fact, the integer type data can be retrieved correctly using the out-of-box cli (/opt/aerospike/bin/cli) installed with the server.
[23:50:14 /etc/aerospike]$ cli -n test -o get -s demo -k As5
{'age': 999}

Yes, put_key preserves values perfectly. It's get_key that is broken.
I've found a bug and fixed it in the integer handling code. So get_key with ints as values should work as intended. See cd14dd0e15ec860713e004a26d9896f4933cf1cc
To be less confusing, I recommend the following lines be placed after import:
from aerospike.logger import logger
import logging

logger.addHandler(logging.StreamHandler())
logger.handlers.pop(0)
logger.handlers[0].setLevel(logging.DEBUG)
logger.setLevel(logging.DEBUG)

That should give you better debugging output.
Ah, you're using PyPy. That might explain the the string issues - I wondered when I'd get bitten by that. Let me look into that.
With the recent bugfix, can you try get_key on the key you placed 'age' in?
pip uninstall -y aerospike; pip install git+https://github.com/benjolitz/aerospike.git

Can you give me the output of when you start up pypy?

Also, aerospike-cli should be installed within your path.
If you're using a virtualenv, you'll find it in the bin/ directory of your virtualenv.
To manually invoke it, try python -c 'import tools; tools.setup_cli()' --host xxx.xxx.xxx.xxx where the xxx's represent the aerospike node.

I've done some poking around. The bug appears on PyPy alright. In some cases, it uses the wrong char* pointer. That is very wrong. CPython appears to not provoke the error.
PyPy will place the wrong values for the bins into the Aerospike store. get_key is unaffected. Tracking down.

Ok, for values inside bins, we're using the ev2citrusleaf_object_dup_str function as a stopgap. I need to investigate PyPy as I'd rather pin a string in memory, but I need to figure out the most efficient way to do that.
Currently, we'll copy the string into the C heap and avoid the chance of PyPy playing string optimization games.
Fix in 2550b53a0e5b964714d5b117948da6b34fc9c72a
I believe things should work for you now, as we've fixed the integer handling bug for get_key and the string encoding bug for PyPy.

Here's the pypy output if it is still needed. I'll test the new fix now.
(venvpypy)[16:27:39 /home/jameswong]# pypy
Python 2.7.6 (32f35069a16d819b58c1b6efb17c44e3e53397b2, Aug 19 2014, 23:32:55)
[PyPy 2.3.1 with GCC 4.4.7 20120313 (Red Hat 4.4.7-4)] on linux2
Type "help", "copyright", "credits" or "license" for more information.

Hey Ben, it's working perfectly now!
So from your experience, how is the performance of this async mode query? Do you use an event to notify the main thread to continue or your application is architected async way already?

Excellent.
The original use case for this driver was to allow a mature Tornado service to exceed the performance of a Java pixel processor, needing to meet a minimum 1,500 requests per second per core to justify it. We got 1,700 requests per second per core without optimization (avoid excess allocations, strip out dead code, make logging asynchronous).
We'd use something like '''result = yield gen.Task(connection.get_key, namespace, keyset, key_name)''' inside a Tornado handler decorated with<EMAIL_ADDRESS>and '''@asynchronous'''
When work is done, the pthread_t that is doing the work in C will callback into Python by securing the GIL and activating the constant callback (_handle_event_callback). Inside of python, we convert the void* user_data pointer to something we can look into the registered callback dictionary, run it and remove it.
An early prototype of this would wrap every callback with ffi.callback(...) but that proved to be expensive.
I'm confident there are further optimizations that can be made. For starters, the work dispatcher can be moved into C. It's only in Python due to a race condition within the Aerospike driver (it doesn't like having work added to a live event loop, only a stopped one.)


Adding scroll to top functionality

@charmaine Let me know if you would like me to refactor the scroll to top functionality in any way. I know it be quite costly to have scrolling animation.
Thanks!

Hey @nmkettler! This is a super neat addition, thanks for contributing to the repo ✨
Feel free to work on anything else in this repo-- or even make a separate PR to refactor the scroll-to-top 😄


Reaction bar oddness is back

Bug Report Dump (Auto-generated)

Version 1.19.0<PHONE_NUMBER>)
Device: iPhone 6s (iOS 11.3.1)
TestFlight: false

What happens after dequeueing that cell? @gingerbeardman
Sent with GitHawk

Sorry I'm not sure what you mean? @jdisho

What happens after scrolling up and down or refreshing?
This issue also happened to me sometimes ago, but looked fine after scrolling/refreshing. @gingerbeardman
Sent with GitHawk

Haven't seen this lately with the redesign, closing. Feel free to reopen if it occurs again/still.


indexpack: Add a VFS for read-only access to a ZIP file. [phab:D28]

Created by fromberger at 2015-02-04 21:35:20:
This change makes it possible to open a zip file containing in index
pack directory, and read out compilations and files without having to
first unpack the file.  This variant is read-only, and the operations
that write will report errors.  We may change that in the future, but
for now we only need read.

schroederc commented inline (context lost during migration) at 2015-02-04 21:46:56:
Comments needs cleaned up.
"contents an indexpack" -> "contents of an indexpack"
"rootand" -> "root and"

schroederc commented inline (context lost during migration) at 2015-02-04 21:46:56:
s/of its root directory//

schroederc commented inline (context lost during migration) at 2015-02-04 21:46:56:
2015

schroederc commented inline (context lost during migration) at 2015-02-04 21:46:56:
s/,//

schroederc commented inline (context lost during migration) at 2015-02-04 21:46:56:
s/,//

schroederc commented inline (context lost during migration) at 2015-02-04 21:46:56:
One-liner function

schroederc accepted this revision at 2015-02-04 21:46:56

fromberger wrote at 2015-02-04 21:51:29:

Various comment fixes from review:

fromberger wrote at 2015-02-04 21:52:46:

Consolidate one-liners.

fromberger wrote at 2015-02-04 21:52:49:
Thanks—done throughout.

schroederc commented inline (context lost during migration) at 2015-02-04 22:18:07:
Year still needs updated.

fromberger wrote at 2015-02-04 22:20:20:

Update copyright year, too.

fromberger commented inline (context lost during migration) at 2015-02-04 22:21:15:
Missed this one first time round, thanks. Fix't.

fromberger wrote at 2015-02-04 22:55:12:

Make OpenZip take a reader rather than a path.

fromberger wrote at 2015-02-04 22:56:14:
Actually, I realized in retrospect I can't use zip.OpenReader here, so I made some adjustments to the OpenZip signature.
Turns out to make things a little simpler that way, anyway, and all the tests still pass. :)

fromberger closed via commit e643d6fdfb1975a1ba0273dbc01a91fa1901aea1 at 2015-02-05 18:17:38

commit 48a6585efab227e2e4862b1a147c7b6dbf4702f5
305e3e3caf8bf0a281eca3945c2f593414d9ce80
6184cacb693ee8e68f701a28702e334472480a9c
136e9c1a1c76a2d700348437eba7387b19b3fda6
09ba69cc8fb50b4ad35eb24f512fdad85a71ad67


print tidy version from python

On the command line, I can use tidy -version to print the version of the used library.
Could you add a wrapper for that, too?
This is interesting, because after some years of stagnation,
development of HTML Tidy has officially  been picked up again:
http://www.html-tidy.org/
http://www.htacg.org/
https://github.com/htacg/tidy-html5
This also means you should update all links to
http://tidy.sourceforge.net/
to point to
http://www.html-tidy.org/
instead.

partly fixed by f59ede40fedaac0d9096b0cda858a3d13ed22b50


DHCP to TS

Clean dhcp server's code using typescript

Fork repo and convert to TypeScript + contribute to DefinitelyTyped to add typescript types to npm repo


Do I need to scan multiple times?

Question
I've looked at the documentation and one of the first steps is to scan for a device using BleManager. Let's say I do not know when the user will turn their device on. Does that mean I need to use a timer to constantly call scanAndConnect? Or is there some sort of event I should be waiting on so that I only call scanAndConnect when needed?

scanAndConnect should work first time if the device is paired before app is launched.


Selecting "Language" in drawer sets incorrect item highlight

The globe next to "Language" in the drawer gets highlighted when selected, but only opens a dialog, so the current highlighted item should not be changed.

Fixed in commit c7a79aade7af01186384cee826b66218f17cf4d1


A small window for options of extensions?

When the option of extensions is opened, could it pop from the bottom instead of a new tab?
Just like the lemur browser and rains browser.

Duplicate of https://github.com/kiwibrowser/src.next/issues/479 .

@kyoyacchi, If your referring to the Kiwi Browser, the following link provides guidance to your question.
https://github.com/kiwibrowser/src.next#releases
~Ibuprophen


Crimson isle fixes

@DuckySoLucky this is kind of a mess but basically this PR is:

An upstream from skycrypt dev branch
These changes: https://github.com/DuckySoLucky/SkyCrypt/pull/8/commits/c20c53525eeda08327880f1882051ed378398818

If you can upstream your branch from skycrypt/development than this should show only the real file changes...


New directory/added data totals in verbose output don't add up

Output of restic version
restic 0.9.2 compiled with go1.10.3 on linux/amd64

How did you run restic exactly?
restic -r sftp:restic@example.org:/restic-repo -v backup /etc /home /opt /srv /var

What backend/server/service did you use to store the repository?
sftp
Expected behavior

the number of reported new directories is greater than 1
the reported 'added to the repo'  space matches the 'processed' amount

Actual behavior
lock repository
load index files
start scan on [/etc /home /opt /srv /var]
start backup on [/etc /home /opt /srv /var]
scan finished in 4.646s: 44955 files, 86.558 GiB
uploaded intermediate index b80f7afc
uploaded intermediate index b0ef6087

Files:       44955 new,     0 changed,     0 unmodified
Dirs:            1 new,     0 changed,     0 unmodified
Data Blobs:  57306 new
Tree Blobs:      2 new
Added to the repo: 20.895 GiB

processed 44955 files, 86.558 GiB in 7:16

Note that:

the specified backup locations certainly contain more than 1 directory (vs. Dirs: 1 new).
the total reports on the one hand Added to the repo: 20.895 GiB but before and later reports that it scanned/processed 86.558 GiB

Steps to reproduce the behavior

make sure that restic repository destination is empty (such that it's created from scratch in the next backup command
call restic -r ... -v backup ... (see above)
check out the verbose output

Do you have any idea what may have caused this?
no
Do you have an idea how to solve the issue?
no
Some additional information - one day later, a 2nd  run (same backup as above) to create a 2nd snapshot yields this output:
[..]
scan finished in 2.963s: 44934 files, 86.569 GiB

Files:          14 new,   743 changed, 44177 unmodified
Dirs:            0 new,     1 changed,     0 unmodified
Data Blobs:    122 new
Tree Blobs:      2 new
Added to the repo: 49.436 MiB

processed 44934 files, 86.569 GiB in 0:08
snapshot 8a03dc7b saved

Again, the output reads as if the last snapshot just contained one directory which is clearly incorrect.
Did restic help you or made you happy in any way?
yes, its documentation is very well written and thus a joy to read; restic is very fast for what it does and otherwise seems to work fine

Hey, thanks for the report. The directory numbers are wrong, we're already aware of this bug and it this is tracked as #1863.
The second expectation you mentioned ("the reported 'added to the repo' space matches the 'processed' amount") is, I think, based on a misunderstanding:

processed is the sum of all data in the files/dirs to backup
added to the repo is the amount of newly added data to the repository

Since restic uses clever deduplication, it is realistic that for an initial backup of file/dirs with ~86GiB data in them, the deduplicated data is only ~21GiB in size.
Does that make sense to you? Please let us know if you have ideas on how to improve the documentation on this...
I'm going to close this issue for now. The main bug is tracked as #1863, please subscribe over there to get a notification once we resolve it.
Please feel free to add further comments. Thanks!

Yes, makes sense - the space difference can be explained by the deduplication.
Is it possible to tweak the verbose output to make it obvious to new users that deduplication is going on?
For example, instead of
Added to the repo: 49.436 MiB

perhaps something like this:
Added to the repo: 49.436 MiB (deduplicated)

In the documentation, the start of the 'Backing up' section already has a verbose output example. Perhaps it makes sense to tweak the numbers a bit such that a bigger difference between added and processed volume is easily noticed. A small paragraph after that output could then explain that the (in some cases quite dramatic) difference is a result of the clever deduplication.

I've added a bit of text as you suggested: https://github.com/restic/restic/commit/31176d212b796906115b01d612c30d356060e7e2


fix broken link to 'Hexastore: sextuple indexing ...' PDF

.

Coverage remained the same at 95.413% when pulling 244aed21ecfd5317304d76663c50392554a0ef8c on GreenRobot777:patch-1 into 33ece87a70e03c4ad2d93fc6d73ad5a81a8075a2 on levelgraph:master.

thanks!


Implement Error Handling Across All Pages and Components

Error Handling Implementation Checklist

[ ] Study Materials
[ ] Events
[ ] Student Management
[x] Registers Management
[x] Users Management
[ ] Deleted and Rejected Users
[ ] Documents Management for Signature
[ ] General Error Handling Across All Pages and Components

[ ] When delete event the alert does not appear.


Nightly performance runs for Segment Replication with Remote store.

Nightly performance runs for Segment Replication with Remote store.

Should this be transferred to https://github.com/opensearch-project/opensearch-build ?
@bbarani


Add Directives support in SpeechletResponse

I've added Directive types for all directive currently described in the documentation. Have tested only Dialog Directives with my skill though.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Serhii Hrynko seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

I've also reviewed implementation of directives in original Java library. They doesn't seem to provide implementation to directives other than [https://github.com/amzn/alexa-skills-kit-java/tree/master/src/com/amazon/speech/speechlet/dialog/directives](Dialog directives). As for Dialog directives, it looks like they added to new types: DialogIntent and DialogSlot, with the only difference from Intent and Slot in missing Slot.Resolutions field. However, documentation directly states that updatedIntent field takes an Intent object (https://developer.amazon.com/docs/custom-skills/dialog-interface-reference.html#use-updatedintent). And new added types don't enforce restriction of not changing intent and slot names, so I don't think we should do this as well.

@stefann42, @dg-racing, @Jasc01, @teriansilva : I've merged #23, #48 (only locale support), #52 (with #49) into this PR. I consider this a minimal required update. #41 is covered by these changes. #31 mostly interferes, but contains basic permissions support, so has to be merged separately.
Could you, please, review changes and leave your comments?

@ElvenMonky You rock! Thanks for the quick turnaround. To clarify, rather than code review and merge https://github.com/AreYouFreeBusy/AlexaSkillsKit.NET/pull/23, https://github.com/AreYouFreeBusy/AlexaSkillsKit.NET/pull/48, https://github.com/AreYouFreeBusy/AlexaSkillsKit.NET/pull/52, https://github.com/AreYouFreeBusy/AlexaSkillsKit.NET/pull/49, https://github.com/AreYouFreeBusy/AlexaSkillsKit.NET/pull/41, and https://github.com/AreYouFreeBusy/AlexaSkillsKit.NET/pull/31 I should code review this PR (https://github.com/AreYouFreeBusy/AlexaSkillsKit.NET/pull/53) and merge, correct?

Yes, exactly.

Sorry for inconvinience, but I found it necessary to provide better support for all current request types. So I've added one more commit to PR.
Hovever, more interfaces with new directives and requests can be added in the future, so we need to find a way to make Speechlet extensible by external interface libraries, and probably extract existing interfaces into separate assemblies (and nuget packages), as not all skills will use all available interfaces.


Add enums (from Portal) for subnet delegation service name

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

Anyone review this?

Hi @magodo, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

@magodo , please follow above instructions to get breaking change review approval.

@magodo any chance we can get this re-opened?

@raych1 Before going through the breaking change review, could you please assign this to the NRP team to review whether the list is comprehensive?

@raych1 Before going through the breaking change review, could you please assign this to the NRP team to review whether the list is comprehensive?

@MikhailTryakhov , can you review this PR?

@raych1  that's totally don't need to be merged, so closing the PR.
@magodo  please read carefully our documentation before making such PRs: https://microsoft.sharepoint.com/teams/Aznet/_layouts/OneNote.aspx?id=%2Fteams%2FAznet%2FOneNotes%2FNRP migrated&wd=target(Hydra %2B SDK.one|96F7B95B-A378-4CA5-903B-C88F894873EF%2F[NEWEST] Swagger-> SDK -> PowerShell Process Overview|71B816ED-DAE5-4907-94D8-DE7EE13278A0%2F)

@MikhailTryakhov could you clarify further on why this has been closed?
These Enum values not being defined is problematic for us (since we have no means of determining the canonical casing for Enum's, and use these definitions to workaround casing inconsistencies in the API.
In addition, per my understanding - not defining these means it's easier for breaking changes to be introduced, since these aren't reviewed by the ARM team?

Ping @MikhailTryakhov - any update on this one? ^


How do I create plugins?

Hello,
Where can I find information on creating plugins?
I cant find the documentation anywhere.
Thanks

Hi there,
dmenu-extended-plugins has the existing plugins for dmenu-extended that you could use as a starting point.
In that repository there is a file called plugin_example.py that shows the simplest way to start.
Sorry there's not much documentation, if I find there is sufficient demand I will take some time to write something up.


Filter for the run-test: field of the OPAM file

I have a Coq development where the test suite fails only with Coq 8.17, seemingly because of a bug in Coq or Paramcoq, or an interaction issue between Equations and Paramcoq. Since I think that the issue is not worth investigating further, I would like to add the filter below to turn off the test suite only with Coq 8.17.
run-test: [ [make "-j%{jobs}%" "build-misc" ] { coq:version < "8.17" | "8.18" <= coq:version } ]

However, Coq-community templates do not seem to provide the functionality to produce this line, and I had to edit the OPAM file by hand. See also: https://github.com/pi8027/stablesort/pull/25#discussion_r1625692392

If the user is OK with writing the filtering syntax manually in the meta.yml file, then it would be easy to add this.


roll back progressive hyd/wq steps mode

since this feature's being bumped from v2.1 - feature is tracked in #12

no need


"statement if evaluation" compiles differently if inside interpolated string

I feel like this is a bug but I could just be doing it wrong.
"true" if evaluation  compiles to if (evaluation) "true"
But wrap that in a string:
"#{"true" if evaluation}" compiles to "" +  (evaluation ? 'true' : void 0);
which of course makes for some unexpected strings when the evaluation is false.

It ain't a bug. If you use an if/else as an expression ... it will compile into an expression. The value of an if statement that never runs is naturally undefined. You may want to write:
"#{if evaluation then "true" else ""}"

Ah, ok.  Thanks!

You're using a conditional expression as a value. When there's no alternative, it produces void 0.
$ coffee -bep 'a = ("true" if evaluation)'
var a;

a = (evaluation ? "true" : void 0);

$ coffee -bep 'a = (if evaluation then "true" else "other")'
var a;

a = (evaluation ? "true" : "other");

This is the desired output. To do what you're expecting, make an array:
$ coffee -bep '"#{["true" if evaluation]}"'
"" + [evaluation ? "true" : void 0];


Python 3.10 Support

Python 3.10 officially released on 09-Nov-2021 - support for this should be included / verified.

acc crit:

[ ] have CI/CT running in py3.10 - and pass
[ ] have tox tunning in py3.10 = and pass
[ ] added the py3.10 trove / classifiers "Programming Language :: Python :: 3.10"


Integrate signing with artifact promotion jenkins job

Description
Integrate signing with artifact promotion jenkins job. Created a groovy function for jenkins job which can also be used for jenkins job to sign standalone artifacts
Issues Resolved
#1351
#1383
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1395 (a589a0d) into main (c18e136) will increase coverage by 0.37%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1395      +/-   ##
============================================
+ Coverage     94.08%   94.45%   +0.37%
============================================
  Files           139      120      -19
  Lines          3061     2978      -83
  Branches          8        0       -8
============================================
- Hits           2880     2813      -67
+ Misses          173      165       -8
+ Partials          8        0       -8

Impacted Files
Coverage Δ

src/system/temporary_directory.py
83.87% <0.00%> (-12.91%)
:arrow_down:

src/system/os.py
92.30% <0.00%> (-7.70%)
:arrow_down:

tests/jenkins/jobs/BuildAssembleUpload_Jenkinsfile

src/jenkins/Messages.groovy

tests/jenkins/jobs/InputManifest_Jenkinsfile

tests/jenkins/jobs/BuildArchive_Jenkinsfile

tests/jenkins/jobs/BuildDockerImage_Jenkinsfile

src/jenkins/BuildManifest.groovy

.../jenkins/jobs/PromoteArtifacts_actions_Jenkinsfile

tests/jenkins/jobs/GetManifestSHA_Jenkinsfile

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c18e136...a589a0d. Read the comment docs.

As of now, the code does not run tests correctly due to the changes we have on @peternied sha generating task.
We will add the test case corrections later.
Thanks.

As of now, the code does not run tests correctly due to the changes we have on @peternied sha generating task. We will add the test case corrections later.
Thanks.

I see half a dozen other issues, happy to CR when this is ready.

Overall this is good, but still needs some work.
I am confused by the naming of createSha512 vs. createSignatureFiles vs. signArtifacts.

Why do we need both createSignatureFiles and signArtifacts? One just calls the other.
If createSha512 creates .sha512 files, then the second method should be called createSig (it creates .sig files, right?) to match. The other option could be createSha512Checksums and createSignatureFiles.

I was under the impression that signing calls out to an internal signing service. Is that no longer the case? Why are we importing the GPG key? How do those things relate?
I still have an issue with the attempt to only import the PGP key once. I understand that signArtifacts tries to be independent, but I'd rather have a separate function called importPGPKey() that needs to run once before signArtifacts, which would make it so much clearer about what's going on. And since signing is done with the said PGP key, maybe their names could match, e.g. importPGPKey() and signWithPGPKey().
Why are the changes to docker images required?
The documentation needs to be revised in this PR to explain what's going on, start with https://github.com/opensearch-project/opensearch-build#signing-artifacts.

One is the groovy file which can be used in jobs. The other is the closure function is to use with promoteArtifacts.groovy
I'll refactor the function names

We call the opensearch signer client, but it does not get the gpg as per my understanding. Every usage that I have come across thus far has imported the gpg key.
We can call the gpg key download from the same file as a function.

The promotion workflow was already complication, and I think this PR is suffering with complexity is being added there isn't clear purpose to each component. My recommendation is that we have a promotion artifact selector, activities, coordinator and a workflow - which aligns closely to what is already on origin/main.

Artifact selection finds all artifacts that should be promoted, tosses them into a list

Activities take in a file path and product additional artifacts that will be included in the upload, not folders

CreateSha512, path to file -> sha512 next to file in the workspace
CreateSignature, path to file -> signature next to file in the workspace

Coordinator takes an input bucket, output bucket, selector, ordered list of activity to download everything into the workspace, run a selector(s) on it, run activities on the select artifacts, and upload the artifacts to the output bucket.

This code handles the management of the workspace environment, so files vs folders can be handled here with loops rather than making activities more complicated

As @dblock mentioned, we could add further parameterize the inputs to make this work for for any kind of promotion workflow. Consider if we re-wrote the S3 upload aspect as an activity that is run last. This might be in scope for the current change or another follow up item.
As there might be additional trade-offs around start-up/tear down time associated within signing system, rather than address them in this PR it might make more sense to circle back if performance is a concern, - even if this workflow takes an hour its a vast improvement from the current process.
Thanks to everyone for the dedication and hardwork on this PR - Merry Christmas!

We have modified the promoteArtifacts to first sign and create sha for everything we have and then upload everything at last in this PR itself. We use the directory structure to save time when creating signatures. This is much more flexible than giving only the path to artifact as input.
I agree that we should extend this for any kind of promotion, can create an issue and work on it on a different PR.

We use the directory structure to save time when creating signatures.

I have strong preferences towards maintainability and testability, making trade-offs for performance can be useful, what are the performance metrics for this version?  I am comfortable if this workflow takes an hour - what are the criteria you are using, how would my proposal change the performance?

We use the directory structure to save time when creating signatures.

I have strong preferences towards maintainability and testability, making trade-offs for performance can be useful, what are the performance metrics for this version? I am comfortable if this workflow takes an hour - what are the criteria you are using, how would my proposal change the performance?

If we don't follow the directory structure, it would involve bringing up the pipenv, cloning the signer, running bootstrap, signing the artifact. Therefore, running the signer on a directory would save us a lot of time.
Although, I am not sure how maintainability or testability would be affected if we sign or create .sha  for all files in a directory?  It rather makes our functionality more flexible as iterating through the dir files is also managed as a black box.

We use the directory structure to save time when creating signatures.

I have strong preferences towards maintainability and testability, making trade-offs for performance can be useful, what are the performance metrics for this version? I am comfortable if this workflow takes an hour - what are the criteria you are using, how would my proposal change the performance?

If we don't follow the directory structure, it would involve bringing up the pipenv, cloning the signer, running bootstrap, signing the artifact. Therefore, running the signer on a directory would save us a lot of time. Although, I am not sure how maintainability or testability would be affected if we sign or create .sha for all files in a directory? It rather makes our functionality more flexible as iterating through the dir files is also managed as a black box. The process flow works for single files as well.

Saving all the files in a dedicated folder then sign/sha all of them in one take is definitely better. Not only this is easily extensible later on if we need to sign/sha more files, but also simplify the setups of the s3uploads. We can have one s3uploads to replace the current 3.

Also, pytest issues.

@peterzhuamazon - Added changes for sha512 file text to be
``

Also, pytest issues.

Did you mean groovy tests? I updated those for shafile changes to be as robust as possible

Also, pytest issues.

Did you mean groovy tests? I updated those for shafile changes to be as robust as possible

Also, pytest issues.

Did you mean groovy tests? I updated those for shafile changes to be as robust as possible

Yes, groovy. Thanks.

Will let @peternied take it from here, you have all my feedback.

@peternied is on vacation this week. @peterzhuamazon @bbarani can you help review?

Even though we have approved this I also want @peternied to take a look before we merge.
Thanks.


Set correct content-type for responses in LocalHttpServer.

Proposed changes
HtmlUnit driver checks content type for images, when download them. If response with image doesn't equal "image" driver handles such image as not displayed. It leads to fail some tests.

Coverage decreased (-0.04%) to 64.317% when pulling 1d6754a988b6192a0ea194357fff03744ace350a on Localserver_fix_content_type into 2d40bf1996f0fd61a375e6f5dc758f94eaf8e605 on master.

Codecov Report

Merging #636 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master    #636      +/-   ##
===========================================
- Coverage     60.53%   60.5%   -0.04%
  Complexity      772     772
===========================================
  Files           148     148
  Lines          2752    2752
  Branches        272     272
===========================================
- Hits           1666    1665       -1
- Misses          981     982       +1
  Partials        105     105

Impacted Files
Coverage Δ
Complexity Δ

...e/selenide/impl/WebDriverThreadLocalContainer.java
81.88% <0%> (-0.73%)
31% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d40bf1...1d6754a. Read the comment docs.


chore(metadata): fix support states

Description
Please explain the changes you made here.
Updates the plugin support values that were erroneously set as "tech-preview"
Which issue(s) does this PR fix

Fixes #?
https://issues.redhat.com/browse/RHIDP-4797

PR acceptance criteria
Please make sure that the following steps are complete:

[ ] GitHub Actions are completed and successful
[ ] Unit Tests are updated and passing
[ ] E2E Tests are updated and passing
[ ] Documentation is updated if necessary (requirement for new features)
[ ] Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Will any of these drop back to tech preview when they're no longer bundled/wrapped inside RHDH but on the plugin registry? If so might be better to keep them declaratively TP instead of GA.

/retest


[FLINK-20298][docs] Replace usage of {{ site.baseurl }} in documentation

What is the purpose of the change
Replace usage of {{ site.baseurl }} in documentation.
Brief change log
Change {{ site.baseurl }} to {% link ... %}.
Verifying this change
Execute docs/build_docs.sh and docs/check_links.sh without errors.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Hi, @dawidwys @sjwiesman
Could you help to review at your convenience ?
Thanks~

Thanks for the review @dawidwys
I need some time to be familiar with the grammar of Jekyll.
I wonder if I could open another JIRA ticket to solve the remaining problems because this PR has changed a large number of files, and if others change these files there might be lots of conflicts to resolve.

@Shawn-Hx I think that is fair. Could you please create corresponding JIRA issues so that we do not forget about it. I will review the current PR in the meantime.

Thanks @dawidwys
I have created FLINK-20422. Please take a look.

@dawidwys I have resolved the conflicts, but I fount that deployment/resource-providers/hadoop.md don't exist so build_docs.sh will fail.

Yes, I've also stumbled upon this when trying to move your PR forward. I created the https://issues.apache.org/jira/browse/FLINK-20426 which should be fixed soon.

@dawidwys
I noticed that the problem has been fixed and resolved the conflicts. Now ./build_docs.sh and ./check_links.sh can be executed without error, PTAL :)


Specimen titles/labels

Add either a title or label to specimens, depending on the usage.
The Color specimen already does something similar.

@bldng do you have a specific specimen in which you'd like to see support for title/label? Many specimen already support a title prop.

I think this was my idea initially, and the reason for it was that there's no good way to label specimens right now, especially when they're not full page width. Another use would be to add labels to code blocks so you can e.g. denote the language (I'd make the free-form though).


Does custom query work for all database types now?

Yes; column validation should work for all databases but row is only supported for BigQuery and Hive.

How about customer query?
On Wed, May 4, 2022 at 12:24 AM Neha Nene @.***> wrote:

Closed #464
https://github.com/GoogleCloudPlatform/professional-services-data-validator/issues/464
.
—
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/professional-services-data-validator/issues/464#event-6545896140,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYSI4UVZXN4CKQJXEQJY2X3VIIC2BANCNFSM5U5DCK4A
.
You are receiving this because you authored the thread.Message ID:
<GoogleCloudPlatform/professional-services-data-validator/issue/464/issue_event/6545896140
@github.com>


where can i get token and credentials?

  credentialsPath: path.join(__dirname, "../credentials.json"),
  tokenPath: path.join(__dirname, "../token.json")

Please follow these steps:
https://developers.google.com/gmail/api/quickstart/nodejs


Ef/checkout refactor

What kind of change does this PR introduce? (check at least one)

[x] Bugfix
[x] Refactor

Does this PR introduce a breaking change? (check one)

[x] No

Does this PR fulfill these requirements:

[x] All tests are passing

Additional Information
In preparation for a refined debugger that allows you to hop around the history tree, this PR addresses a couple existing issues:

Calling checkout only reset the next ref of the direct parent of the action you were checking out. If you checked out a branch that was more than one action away from the most recent shared action, that would leave the next chain pointing down the wrong branch
If you remove an action from within an inactive branch, we won't reconcile on that action (per PR #335). This means that checking out an action further in that branch would have an invalid state. This PR addresses that by determining the most recent action shared between the current head and the newly desired head, and reconciling on that (after properly hooking up the next chain)

TODO:
Realizing now that toggle needs a similar treatment that remove just underwent, or we can pull a cop out and disable toggling of inactive actions.

Codecov Report

Merging #336 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #336   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          24     24
  Lines         820    837   +17
=====================================
+ Hits          820    837   +17

Impacted Files
Coverage Δ

src/history.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfe1d0d...e3316da. Read the comment docs.


Check we are not in SO

If we are printing (for example) when we inject code we have a problem boi

Not sure why you closed all these issues?