inter: 3.1 -> 3.3

The name of this font has also changed from "Inter UI" to simply "Inter"
as of version 3.3.
Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Can the font be used with the old font name, in other words is it worth adding a attrpath package alias?

As per the release notes at https://github.com/rsms/inter/releases it appears that the font name has changed completely. As for the testing package on my local machine, it only has fonts under the name "Inter".

As per the release notes at https://github.com/rsms/inter/releases it appears that the font name has changed completely. As for the testing package on my local machine, it only has fonts under the name "Inter".

Hi @nathyong, thanks for contributing and sorry for the wait!
Would you mind adding a deprecation error in pkgs/top-level/aliases.nix for the old attribute name? Preferably with some minimal information that tells the users of the old package what they need to expect, ie. that both the package and font names changed. You can see examples of how to do this by searching for throw in that file. I think that would be the best possible user experience in this case.
Thanks again!

Superseded by https://github.com/NixOS/nixpkgs/pull/57605


GrumPHP should be run with --no-interaction

We don't pass in --no-interaction and normally, this may not cause a problem. But to avoid any problems, we should pass this in by default.

Fixed by #126


bug(gui-client): Clearing logs doesn't clear IPC service logs on Windows

Add this to the smoke test after the zip export.
I think it's cause of the permissions. On Linux I have a special thing for it: https://github.com/firezone/firezone/blob/c35a7579a802edb9658201dfcc070fe46d514e2e/rust/gui-client/src-tauri/deb_files/firezone-client-ipc.service#L10-L11
If #5279 merged, we could send a signal over IPC, but that one's blocked on a failing test

Closing in favor of #5453


Add kargo image.

Chainguard Images Pull Request Template
Image Size

[X] The Image is smaller in size than its common public counterpart.

Notes:
Image Vulnerabilities

[X] The Grype vulnerability scan returned > 0 CVE(s) (please explain in the notes).

Notes: One false positive that I nacked: https://github.com/wolfi-dev/advisories/pull/248
Basic Testing - K8s cluster

[X] The container image was successfully loaded into a kind cluster.

Notes:
Basic Testing - Package/Application

[X] The application is accessible to the user/cluster/etc. after start-up.

Notes: The dashboard works!
Helm

[X] A Helm chart has been provided and the container image can be used with the chart.  If needed, please add a -compat package to close any gaps with the public helm chart.

Notes:
Processor Architectures

[X] The image was built and tested for x86_64.
[X] The image was built and tested for aarch64.

Notes:
Functional Testing + Documentation

[X] Functional tests have been included and the tests are passing.  All tests have been documnted in the notes section.

Notes:
Environment Testing + Documentation

[X] There has not been a request and/or there is no indication that this image needs tested on a public cloud provider.

Notes:
Version

[X] The package version is the latest version of the package.  The latest tag points to this version.

Notes:
Dev Tag Availability

[X] There is a dev tag available that includes a shell and apk tools (by depending on 'wolfi-base')

Notes:
Access Control + Authentication

[X] The image runs as nonroot and GID/UID are set to 65532 or upstream default

ENTRYPOINT

[X] applications/servers/utilities set to call main program with no arguments e.g. [redis-server]

CMD

[X] For server applications give arguments to start in daemon mode (may be empty)

Environment Variables

[X] Environment variables not added and not required.

 Logs DO NOT write to file.

Documentation - README

[X] A README file has been provided and it follows the README template.

As part of a Chainguard effort to reduce code duplication and provide higher quality images, we have stopped accepting pull requests for changes to images in this repository. Due to this, we are closing all pull requests today in order to start fresh.
If you think this pull request was closed in error, please feel free to re-open this pull request or open an issue and we will try to help you out. Thank you!


Inconsistency in taxon:compound, name:compound mapping? Example (Q105216729)

Hello:
I want to use Lotus to reconstruct evolution of natural products on phylogenetic trees. I began entering some references and taxon:compound pairs that are not in Lotus (or Wikidata) and found some unexpected complications and/or inconsistencies on how the taxon: compound and name:compound mapping depicted in Lotus in encoded in Wikidata and how these associations can be retrieved using queries of Wikidata. Can you help me understand what is happening so that I can add and retrieve data effectively? Thank you! Tanya
I give as example the compound blepharin (Q105216729 on Wikidata).
1. If you query "blepharin" in Lotus, you get no results.
2. If you query the InChIKey encoding of blepharin, "PYQSUTLVBSTCSK-UHFFFAOYSA-N", in Lotus, you get "Q105216729
2-[(3-hydroxy-2h-1,4-benzoxazin-2-yl)oxy]-6-(hydroxymethyl)oxane-3,4,5-triol".
3. That name "2-[(3-hydroxy-2h-1,4-benzoxazin-2-yl)oxy]-6-(hydroxymethyl)oxane-3,4,5-triol" does not appear in the Wikidata (nor PubChem) record for "blepharin". "Blepharin" does not occur in the Lotus record for "2-[(3-hydroxy-2h-1,4-benzoxazin-2-yl)oxy]-6-(hydroxymethyl)oxane-3,4,5-triol". Why not? Where is this name coming from, and why doesn't the name in the Wikidata record appear on Lotus (and vice versa)?
4. The chemical structure illustrated on Lotus for Q105216729 is not the same as chemical structure illustrated on PubChem for PubChem CID	14605136 (blepharin). PubChem has the structure depicted with N-C(=O). Lotus has the structure illustrated with N=C(-OH). Are these the same structure?
5. When you look at the Wikidata record for blepharin (Q105216729), you do not see the taxa listed on Lotus as containing this compound (record Q105216729 on Lotus). There is no "found in taxon P703" statement in the Wikidata record for the species listed on Lotus: Acanthus montanus, Blepharis edulis, Acanthus ebracteatus .
6. When you click on the Wikidata symbol for the reference for each of these taxon records in Lotus, you will see that the species name and the compound name "blepharin"  both occur in the "main subject P921" statement for the reference (Q42783412) on Wikidata. This seems a dangerous way to make the taxon:compound link since a publication may has as its "main subject" multiple species and multiple compounds, but all combinations of them do not necessarily occur. How many of the taxon:compound links in Lotus are made via this "main subject" statement in the reference? Is there a plan to transfer these links to "found in taxon P703" statements on the compound Wikidata record?
7. When I query Wikidata for all compounds in, e.g. Acanthus montanus (Q4672080), it does not return blepharin (Q105216729). The query yields 10 compounds.   See query text below.
SELECT DISTINCT ?taxon ?children ?childrenLabel ?structure ?structureLabel ?structure_inchi
WHERE {
VALUES ?taxon {
wd:Q4672080                           # You can remove the Qxxxxxx and hit Ctrl+space, type the first letters and it should autocomplete
}
?children (wdt:P171*) ?taxon.          # Include children taxa
?structure wdt:P234 ?structure_inchi ;  # Get the InChI
(p:P703/ps:P703) ?children.          # Found in given taxon/taxa
SERVICE wikibase:label { bd:serviceParam wikibase:language "en". }}
8. When I query Lotus for the text string "Acanthus montanus", the query returns 16 compounds, including Q105216729. How can I retrieve the Lotus result from Wikidata?

Hi @tatyanalivshultz!
Thank you very much for getting in touch! Your project looks fantastic. It is something we have also wanted to do for a long time. Really thrilled to see where this will go!
(I quickly went through your bibliography...very cool!)
For the specific questions:
First of all, the data on lotus.naturalproducts.net is not up-to-date. We currently have some limitations in updating it so please better take the data from Wikidata, Zenodo (https://zenodo.org/communities/the-lotus-initiative), or PubChem (feeding on Zenodo also)

Chemical names are heavily discouraged to look for chemical compounds. They are not "identifiers" at all and can lead to huge discrepancies indeed. Checking the names of hundreds of thousands of compounds is not trivial, so many of them are also possibly incorrect in many sources.
This is exactly what I wanted to suggest. InChIKeys are the way to go.
The names present on the website were generated using proprietary software (molconvert by ChemAxon). This is not the case anymore and is the reason why names can change. There are additional limitations in Wikidata, as the labels cannot be more than 250 characters long, so sometimes you might not find the name on Wikidata. Moreover, there is currently no "chemical name" property on Wikidata, so we only rely on the label anyone can change and eventually adapt to their language. It looks very intuitive to search for "limonene" but if you want to do so for the whole tree of Life, you will have to forget it...
What you mention here are tautomers. We have some of them in the LOTUS corpus and eventually not all of them can be perfectly standardized. (The chemical "truth" is rather an equilibrium between the different species, changing depending on solvent, pH, etc.) This "problem" is known in cheminformatics for many years, but I think there is still no real solution to it.
The data on Wikidata is moving every second. If someone considered the "found in taxon" statement incorrect and removed it, it won't appear anymore. If someone adds (like you did, thank you 😊 ) new statements, they won't appear on the other LOTUS endpoints instantly. We usually try to do trimestrial versions of LOTUS, including all the new changes made on Wikidata, they are then stored on Zenodo.
Wow, you went deep into digging, beautiful! Those statements (on the references) were actually made by one of our collaborators and were based on the "found in taxon" statements we had at the time. They will probably lose synchronization with time going, as most probably 99% of the people will only update the data on one side. The tagging of "main subject" on articles was made to identify literature matching given subjects, mainly in the frame of Scholia. See https://scholia.toolforge.org/taxon/Q135389 for example. This might change in the future following some of our recent discussions (https://www.wikidata.org/wiki/Wikidata_talk:WikiProject_Chemistry/Natural_products#Mapping_near_to_ubiquituous_compounds)
True, because there is no "found in taxon" Acanthus anymore. This statement was removed from Wikidata (correctly or not, as for any community-based curation, 99% of it is good, we cannot avoid human errors but it goes toward the better).
I think you already found https://www.wikidata.org/wiki/Wikidata:WikiProject_Chemistry/Natural_products#Queries to guide some of your queries, your query is correct, no issue. 6 of the 16 compounds present in the outdated data were removed.

We are really happy to discuss anything in more depth! Please reach out so we can see how to best help you achieve what you want (also including chemical similarity in the speciation gradient, for example, etc.)

Dear Adriano:
Thank you for your detailed reply. I apologize for my delayed reply.  I've
been working on other projects and am just now getting back to this one.
I would like to contribute to Lotus, via Wikidata, the taxon:compound
information for Apocynaceae that I have among my references, and then
export all the taxon:compound records from Wikidata to reconstruct
evolution of chemical classes on a phylogeny of Apocynaceae.
Thank you for your detailed replies to my questions  about chemical names
(1-3). I am not a chemist (I'm a plant taxonomist) so the redundancy and
ambiguity of chemical names is unfamiliar to me. Given what you told me, I
think the following would be the best way for me to proceed:

If the article provides a SMILES or InChIKey formula for a chemical, use
that to find it in PubChem.
If there is only a chemical name, locate an image of the chemical
structure. Either the structure is illustrated in the article or it is
illustrated in one of the references.
Capture each image as a png file and use OSRA (
https://cactus.nci.nih.gov/cgi-bin/osra/index.cgi) to convert it to a
SMILES formula.
Check that the SMILES formula is correct by using SMILES to Image (
http://hulab.rxnfinder.org/smi2img/) to check against the original image.
Search PubChem for the SMILES formula.

One of the first issues that I encountered with this approach is a compound
that doesn't appear to be in PubChem. I'm pretty sure that the SMILES
formula is correct. How would I proceed in this situation?
I'm attaching the reference to this email. The compound is compound 1 in
the article (see also png attached). And below is the SMILES formula that I
got from OSRA and checked on SMILES to Image.
Nc1ccccc1C(=O)OC3OC(COC2OCC(O)(CO)C2O)C(O)C(O)C3O
If you have any advice on best practices for doing this, I'd love to hear
it!
Best regards,
Tanya
Tatyana Livshultz
On Thu, Mar 16, 2023 at 3:17 AM Adriano Rutz @.***>
wrote:

Hi @tatyanalivshultz https://github.com/tatyanalivshultz!
Thank you very much for getting in touch! Your project looks fantastic. It
is something we have also wanted to do for a long time. Really thrilled to
see where this will go!
(I quickly went through your bibliography...very cool!)
For the specific questions:
First of all, the data on lotus.naturalproducts.net is not up-to-date. We
currently have some limitations in updating it so please better take the
data from Wikidata, Zenodo (
https://zenodo.org/communities/the-lotus-initiative), or PubChem (feeding
on Zenodo also)

Chemical names are heavily discouraged to look for chemical
compounds. They are not "identifiers" at all and can lead to huge
discrepancies indeed. Checking the names of hundreds of thousands of
compounds is not trivial, so many of them are also possibly incorrect in
many sources.
This is exactly what I wanted to suggest. InChIKeys are the way to
go.
The names present on the website were generated using proprietary
software (molconvert by ChemAxon). This is not the case anymore and is the
reason why names can change. There are additional limitations in Wikidata,
as the labels cannot be more than 250 characters long, so sometimes you
might not find the name on Wikidata. Moreover, there is currently no
"chemical name" property on Wikidata, so we only rely on the label anyone
can change and eventually adapt to their language. It looks very intuitive
to search for "limonene" but if you want to do so for the whole tree of
Life, you will have to forget it...
What you mention here are tautomer
https://en.wikipedia.org/wiki/Tautomers. We have some of them in the
LOTUS corpus and eventually not all of them can be perfectly standardized.
(The chemical "truth" is rather an equilibrium between the different
species, changing depending on solvent, pH, etc.) This "problem" is known
in cheminformatics for many years, but I think there is still no real
solution to it.
The data on Wikidata is moving every second. If someone considered
the "found in taxon" statement incorrect and removed it, it won't appear
anymore. If someone adds (like you did, thank you 😊 ) new statements,
they won't appear on the other LOTUS endpoints instantly. We usually try to
do trimestrial versions of LOTUS, including all the new changes made on
Wikidata, they are then stored on Zenodo.
Wow, you went deep into digging, beautiful! Those statements (on
the references) were actually made by one of our collaborators and were
based on the "found in taxon" statements we had at the time. They will
probably lose synchronization with time going, as most probably 99% of the
people will only update the data on one side. The tagging of "main subject"
on articles was made to identify literature matching given subjects, mainly
in the frame of Scholia https://scholia.toolforge.org/. See
https://scholia.toolforge.org/taxon/Q135389 for example. This might
change in the future following some of our recent discussions (
https://www.wikidata.org/wiki/Wikidata_talk:WikiProject_Chemistry/Natural_products#Mapping_near_to_ubiquituous_compounds
)
True, because there is no "found in taxon" Acanthus anymore. This
statement was removed from Wikidata (correctly or not, as for any
community-based curation, 99% of it is good, we cannot avoid human errors
but it goes toward the better).
I think you already found
https://www.wikidata.org/wiki/Wikidata:WikiProject_Chemistry/Natural_products#Queries
to guide some of your queries, your query is correct, no issue. 6 of the 16
compounds present in the outdated data were removed.

We are really happy to discuss anything in more depth! Please reach out so
we can see how to best help you achieve what you want (also including
chemical similarity in the speciation gradient, for example, etc.)
—
Reply to this email directly, view it on GitHub
https://github.com/lotusnprod/lotus-web/issues/59#issuecomment-1471434146,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2RIB2VY4V47LJ722VY5T43W4K47LANCNFSM6AAAAAAV4NQP5I
.
You are receiving this because you were mentioned.Message ID:
@.***>

Your work looks amazing (and we clearly need plant taxonomists!).
If there is anything we can do to help, very happy to!
What you suggest looks good.
I would recommend using https://decimer.ai/ developed by some collaborators for the structure recognition from image.
Do not hesitate to contact us for more details if needed.
PS: As a strating point: https://w.wiki/6bt5


Docs

Added Equations and plots to some NumPy losses.
Changed the docstrings to improve nbdev documentation.

Sounds good, I will change the torch pinball_loss to quantile_loss

@kdgutier In the future you can use the following commands to set your credentials. With this change, each commit will have your user.
git config --global user.name "your_github_name"
git config --global user.email "your_github_email"

Also it would be great to follow conventional commits.  :)


rust-analyzer can't find Rust source on nightly-2020-07-29

I see
rust-analyzer failed to load workspace: Failed to find sysroot for Cargo.toml file [...]/Cargo.toml. Is rust-src installed?: can't load standard library from sysroot /home/at/.rustup/toolchains/nightly-2020-07-29-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src (discovered via `rustc --print sysroot`) try running `rustup component add rust-src` or set `RUST_SRC_PATH`

with the rust-src component installed on nightly-2020-07-29.
rust-analyzer expects let src_path = sysroot_path.join("lib/rustlib/src/rust/src"); but nightly-2020-07-29 seems to have changed the paths:
/home/at/.rustup/toolchains/nightly-2020-07-28-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/:
total 118,784
-rw-r----- 1 at at 115,526 2020-07-29 21:25 Cargo.lock
drwxr-x--- 1 at at     260 2020-07-29 21:25 src/

/home/at/.rustup/toolchains/nightly-2020-07-29-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/:
total 118,784
-rw-r----- 1 at at 115,526 2020-07-29 21:17 Cargo.lock
drwxr-x--- 1 at at     328 2020-07-29 21:17 library/

# ls -l /home/at/.rustup/toolchains/nightly-2020-07-28-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src
total 0
drwxr-x--- 1 at at  32 2020-07-29 21:25 build_helper/
drwxr-x--- 1 at at 340 2020-07-29 21:25 liballoc/
drwxr-x--- 1 at at 638 2020-07-29 21:25 libcore/
drwxr-x--- 1 at at  32 2020-07-29 21:25 libpanic_abort/
drwxr-x--- 1 at at 128 2020-07-29 21:25 libpanic_unwind/
drwxr-x--- 1 at at  96 2020-07-29 21:25 libproc_macro/
drwxr-x--- 1 at at  48 2020-07-29 21:25 libprofiler_builtins/
drwxr-x--- 1 at at 534 2020-07-29 21:25 libstd/
drwxr-x--- 1 at at  60 2020-07-29 21:25 libterm/
drwxr-x--- 1 at at 250 2020-07-29 21:25 libtest/
drwxr-x--- 1 at at  72 2020-07-29 21:25 libunwind/
drwxr-x--- 1 at at 234 2020-07-29 21:25 stdarch/
drwxr-x--- 1 at at 144 2020-07-29 21:25 tools/
# ls -l /home/at/.rustup/toolchains/nightly-2020-07-29-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library
total 0
drwxr-x--- 1 at at  50 2020-07-29 21:17 alloc/
drwxr-x--- 1 at at  50 2020-07-29 21:17 core/
drwxr-x--- 1 at at  26 2020-07-29 21:17 panic_abort/
drwxr-x--- 1 at at  26 2020-07-29 21:17 panic_unwind/
drwxr-x--- 1 at at  36 2020-07-29 21:17 proc_macro/
drwxr-x--- 1 at at  42 2020-07-29 21:17 profiler_builtins/
drwxr-x--- 1 at at  36 2020-07-29 21:17 rtstartup/
drwxr-x--- 1 at at  32 2020-07-29 21:17 rustc-std-workspace-alloc/
drwxr-x--- 1 at at  50 2020-07-29 21:17 rustc-std-workspace-core/
drwxr-x--- 1 at at  50 2020-07-29 21:17 rustc-std-workspace-std/
drwxr-x--- 1 at at  66 2020-07-29 21:17 std/
drwxr-x--- 1 at at 234 2020-07-29 21:17 stdarch/
drwxr-x--- 1 at at  26 2020-07-29 21:17 term/
drwxr-x--- 1 at at  26 2020-07-29 21:17 test/
drwxr-x--- 1 at at  42 2020-07-29 21:17 unwind/

I was wondering why it stopped resolving std paths... Fallout from https://github.com/rust-lang/rust/pull/73265

Hmm, this still seems to be broken when editing on rustc

Do you think that's related to this issue or to the fix in #5586? I'm not sure how it finds the rust-lang/rust stdlib.

Not sure either, I haven't looked into this yet. There's no error message from rust-analyzer though.

Ah, looks like this was a local problem. I had RUST_SRC_PATH set to src in my Rust checkout.


Track down and fix fuel consumption allocation

There is a methodology for allocating fuel consumption to generators in place right now, but a large chunk of the generator records that don't sum up to the total plant-level fuel consumption in the generation fuel table.
Track down these records to understand the issues with the current methodology.
This is a continuation of #1026.

@cmgosnell was this addressed by #1608?


MTR join Webex meeting Note

Please add below note to the bottom of the article
ThirdParty join is not supported by WebEx for the Personal Conference option because of encryption.
Customers will have to use the WebEx Meetings Pro option.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9c62081e-2421-80b9-8ba9-aaf8fd55e432
Version Independent ID: 5df3c5e5-978f-cfa7-9e5c-3cd7f65fa8ff
Content: Enable Teams Rooms devices to join third-party meetings - Microsoft Teams
Content Source: Teams/rooms/third-party-join.md
Service: msteams
GitHub Login: @dstrome
Microsoft Alias: dstrome

@howardzhangmsft . Thanks for pointout. i  sent support site of  isco webex , and i conformed , what you said is correct. So thanks for found out.

@dstrome

@howardzhangmsft Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


Move website to AWS

Having to manage the servers myself is becoming a burden and I started to believe it might be cheaper in total (considering the time spent managing the servers) to move to AWS.

Won't be doing this for now, because the servers we have are good enough and cheap.


format parseEvents

good afternoon, there used to be a response format for the function parseEvents
Array<{
  fields: Object,
  name: 'event_name',
  tick: 2131
}>

but now it's just an object array and it's not clear to which particular event the data belong to.

Sorry I am kinda in the middle of adding some docs and made a few changes to js side.. made 2 changes:

parse_events was split into 2:

parse_event(str) // one event only
parse_events([str]) // multiple events

the parse_events is to support multiple events in one call. This split was mostly done due to Python reasons.

The output was changed from:
  Array<{
    fields: Object
    event_name: 'bomb_planted',
    tick: 75316,
  }>

to:
  Array<{
    event_name: 'bomb_planted',
    site: 311,
    tick: 75316,
    user_name: 'player1',
    user_steamid: '765611111111111'
  }>

where "event_name" and "tick" are moved into the the same place as the other fields. I thought this was going to be much more elegant, but I'm happy to hear your opinion about it.

Thank you very much, I will use your lib to write a web service, I hope the package will be maintained and updated


Android Basics: change-app-icon

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-training-change-app-icon#5
In which task and step of the codelab can this issue be found?
   steps 4 and 5 in "Move vector drawable files into -v26 directory"

Describe the problem
   Description of steps 4 and 5 in "Move vector drawable files into -v26 directory" is incorrect

Steps to reproduce?

Go to step 13(Confirm icon path..)

zoom up picture below step 13,check the folder for foreground and background xmls.
ic_launcher_background.xml - is in drawable-v24
ic_launcher_foreground.xml - is in drawable

go to step "Move vector drawable files into -v26 directory".

4 .steps 4 and 5 tells u that
ic_launcher_background.xml - is in drawable
ic_launcher_foreground.xml - is in drawable-v24
It should be vice versa(folders for launcher layers) in android studio its also vice versa.

(Left click on the ic_launcher_background.xml file and drag it from the drawable folder into the drawable-anydpi-v26 folder. Recall that putting a resource in an "any dpi" directory indicates that it's a resource that can scale to any density.
Left click on the ic_launcher_foreground.xml and drag it from the drawable-v24 folder into the drawable-anydpi-v26 folder.)
Versions
Android Studio version: 4.1
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

@artnkfv
Thank you so much for reporting this issue. This is fixed and will be published soon.


Screenshot needs to be deleted from filesystem

Right now the only place the screenshot is being deleted is after a Twitter post:
twitter.post('statuses/update', params, function(err) {
    if (err) {
        console.log(err)
    }
})
fs.unlink(screenshot)

The screenshot needs to be deleted in the following cases: if the user only is posting to Mastodon and not Twitter, if the screenshot was not uploaded to Twitter successfully (the callback returns so the fs.unlink code is never hit).
I used async for the screenshot code before because it simplified the coordination of all these async network requests a lot.

Thanks for catching this. As part of #159 I'm going to reintroduce your async/await code which should make handling this easier. I'll leave this ticket open as a reminder to double check the screenshot isn't left sitting around for this case where Mastodon is configured and Twitter is not.


✨ bump rukpak to v0.19.0

Description

Reviewer Checklist

[ ] API Go Documentation
[ ] Tests: Unit Tests (and E2E Tests, if appropriate)
[ ] Comprehensive Commit Messages
[ ] Links to related GitHub Issue(s)

/hold until #718 merges so we can rebase/re-test, since this is a pretty good set of bumps

/hold cancel


Rename gpuType/gpuNumber to skuType/skuNumber

Rename gpuType -> skuType, gpuNumber -> skuNumber.

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   89.06%   89.06%
=======================================
  Files           8        8
  Lines        2231     2231
=======================================
  Hits         1987     1987
  Misses        192      192
  Partials       52       52

Flag
Coverage Δ

#unittests
89.06% <ø> (ø)

Impacted Files
Coverage Δ

...com/microsoft/hivedscheduler/pkg/algorithm/cell.go
92.15% <0.00%> (ø)

...om/microsoft/hivedscheduler/pkg/algorithm/types.go
86.30% <0.00%> (ø)

...om/microsoft/hivedscheduler/pkg/algorithm/utils.go
86.54% <0.00%> (ø)

...m/microsoft/hivedscheduler/pkg/algorithm/config.go
96.69% <0.00%> (ø)

...hivedscheduler/pkg/algorithm/intra_vc_scheduler.go
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76ed604...80614d6. Read the comment docs.

Maybe we need to explain the concept of SKU somewhere in the documentation, as this name is not that intuitive. For example we can say
A SKU type defines the concrete resource type, for example a certain GPU type (K80, V100, etc.) or CPU cores (for CPU-only jobs).

Seems there is still a lot of "GPU" in the code. I suggest to search for "GPU" without case sensitive or match word, instead of for gpuNumber/gpuType explicitly


Connect email newsletter subscription from to StoneShot Api

Test newsletter subscription with StoneShot by connecting our subscription form to their api.
Padmaja has gotten access to their test account

@BorghildSelle - great if you could check with Matthew if we (in theory) could also have a subscription solution for local news and satellite site news in addition to those we currently have.

Check if firstname/lastname is required for contact

@meols Putting this on hold until we find out if Stoneshot can meet our requirement of triggering newsletter distribution

Closing this as we are not going to use vendor


Updating of Documentation

individual portfolio and segment is to be maintained by respective members (unless explicitly specified)
@tantantan277 @shanseet @ssunil3232


IdentityServr4(3.02)

I use IdentityServr4(3.02) to prompt the following utterance when using oidc authorization
The specified RSA parameters are not valid; both Exponent and Modulus are required fields.
That's where it went wrong

What is the reason

Not enough info.

@leastprivilege  This is my translation of the json data
{"nbf":1576216462,"exp":1576216762,"iss":"http://localhost:5000","aud":"mvc","nonce":"637118129446237778.M2MxNGQ0Y2ItYjg3Yy00YjJjLTkyMjUtYTNiNGJlM2YxNWU3YTdkMjdhYTYtZWEyYi00MmVkLTlhMDgtODEyMzg3MzA0YmM5","iat":1576216266,"c_hash":"EGOx8WiK_NbJSqZUL1Kn0A","s_hash":"2ybXt4P5c2VxecKb8vTgIw","sid":"30tTyfrK-7pamP5eJ_Y9WA","sub":"1","auth_time":1576202876,"idp":"local","amr":["pwd"]}

Thank you. I've solved it  @leastprivilege


MPI: flip domain decomposition

In master we decompose z -> y -> x
Now we decompose x -> y -> z
that is, the fastest varying dimension is decomposed last.
so if I have a grid (16, 16, 16) and 2 MPI ranks, each rank gets

with master: (16, 16, 8)
with this PR (8, 16, 16)

The larger the fastest (innermost) dimension, the better the performance should be

Codecov Report

Merging #915 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #915      +/-   ##
=========================================
- Coverage    89.2%   89.2%   -0.01%
=========================================
  Files         106     106
  Lines       12474   12473       -1
  Branches     2513    2513
=========================================
- Hits        11127   11126       -1
  Misses       1031    1031
  Partials      316     316

Impacted Files
Coverage Δ

devito/mpi/distributed.py
90.94% <100%> (-0.04%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8998fc1...f40fba1. Read the comment docs.

Merged.


[FLINK-28229][streaming-java] Introduce Source API alternatives for StreamExecutionEnvironment#fromCollection() methods

What is the purpose of the change
This pull request adds FLIP-27 Source API alternatives for FromElementsFunction and FromIteratorFunction.
Brief change log

Added CollectionSource
Added IteratorSource

Verifying this change
This change added tests and can be verified as follows:

Added tests for both sources, validating elements emission, snapshot and recovery from snapshot logic.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
The serializers: (yes)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)

Hi, @zentol ! I've resolved comments, replaced old sources in related methods of StreamExEnv with new ones and fixed all failed tests that followed this replacement. Now I'm waiting for your decision about DataGeneratorSource

@zentol One concerns regarding the idea to migrate the existing methods in StreamExecutionEnvironment to DataGeneratorSource is that adding the flink-streaming-java dependency on flink-connector-datagen introduces a somewhat unexpected cycle between flink-architecture-tests-test and flink-clients. How can we address this?

@zentol I implemented the alternative approach you proposed based on the DataGeneratorSource. There are a couple of open questions, but I'd like to get your general feedback before working on them.


Feature Request - Last Access Time

Is it possible to add a last access time property to identify the last time a table was accessed?
The advantage here is to identify and move a table for cold storage or to delete unused tables

This is a great feature. But the cost would be huge. We would need to store it in transaction logs. This means we would need to make a commit when a table is accessed. Alternatively, we can try to store the access time into Hive Metastore. But it won't work for people who access tables using a file path.
Do you have access logs for the storage? You can also use these logs to figure out the unused tables as well.

This is a great feature. But the cost would be huge. We would need to store it in transaction logs. This means we would need to make a commit when a table is accessed. Alternatively, we can try to store the access time into Hive Metastore. But it won't work for people who access tables using a file path.
Do you have access logs for the storage? You can also use these logs to figure out the unused tables as well.

Hi @zsxwing  Generally I use hive tables, I was thinking of use Hive metastore, because it already have this metadata field.

Hi @zsxwing  Generally I use hive tables, I was thinking of use Hive metastore, because it already have this metadata field.


Support for Jenkins installations w/ Github OAuth Plugin

My repo utilizes Github OAuth. Can you support this in the future? https://wiki.jenkins-ci.org/display/JENKINS/Github+OAuth+Plugin

+1 on that!

Anybody would be willing to pick this up?

+1, is there a workaround to sign in on the app?

I'd love this too, I noticed at the authentication section the subtext Or API token. Maybe there is something possible there? On GitHub you can also login using your regular username and the API token as password which works around two-factor auth.

Thanks @dsbaars, even knowing where to find the API token is handy, I'm logged in now.

So what is the workaround for using it with github auth enabled?

What @dsbaars said. Just use the API token in place of the password.

+1

@kanuku In the future, please use github reactions instead of +1 to avoid comment and notification spam.


support for adding CORS headers?

Hi
Wanted to get your thoughts on possibility of some config options for adding CORS support.  As a dev hack in one system I'm currently using nginx in front of fabio to do this, but that just seems wrong :)  I don't really want to be adding CORS directly into the backend API as it's specific to the deployment. Using the consul backend, I'm thinking this should probably be supported via consul tags, so that it can be enabled only for specific services if needed.  I might be able to spend some time on this if you think it's useful.
Thanks

That sounds like a good idea although you then make your service behavior dependent on fabio instead of nginx. This is the same as the strip prefix discussion but I get the impression that enough people want this so lets at least provide a mechanism to provide this properly.
Can you provide an example request including the headers fabio should add? Using tags will probably not work in all cases since a service can register multiple prefixes in different domains, e.g. a.com/foo and b.org/bar for which you may need to provide different headers.
Before you start coding lets hash out first what this could look like. Pls have a look at my last comment on #42 which suggests a format for providing options.

I did some digging and started a proposal for a more generic syntax which would allow configuration of a whole bunch of issues. See #111 for details.

@boyvinall Could you provide an example of the headers which would need to be added?

Hi @magiconair, sorry for going quiet, got swamped with some things.  A really simplistic example would be something like this:
Access-Control-Allow-Origin: *
Access-Control-Allow-Methods: *
Access-Control-Allow-Headers: Keep-Alive,User-Agent,X-Requested-With,If-Modified-Since,Cache-Control,Content-Type,Authorization

(I should say, I'm not hugely familiar with CORS, I just needed to add support for it to something that also fabio - and it seemed to me that this might be a nice feature-add.)  The * above might be better tied down somewhat to say exactly which origin domains and HTTP methods are permitted.  As I got a little further into this, I started to suspect that this feature request might actually be more generalised as adding in any desired response headers - indeed, the relevant bit of my (still development) nginx config is basically this:
server {
    listen *:80 default_server;
    listen *:443 default_server ssl;
    ssl_certificate        /path/to/cert-chain.pem;
    ssl_certificate_key    /path/to/privkey.pem;
    server_name _;
    add_header 'Access-Control-Allow-Origin' '*' always;
    add_header 'Access-Control-Allow-Methods' '*' always;
    add_header 'Access-Control-Allow-Headers' 'Keep-Alive,User-Agent,X-Requested-With,If-Modified-Since,Cache-Control,Content-Type,Authorization';

    location / {
        if ($request_method = 'OPTIONS') {
            return 200;
        }
        proxy_pass "http://<IP_ADDRESS>:8000";
    }
}

So, it's just adding the headers and maybe forcing an empty HTTP 200 if you get an OPTIONS request.

Managing CORS though fabio would certainly be something that we would use

I think the OPTIONS request really should be passed on to the backend server rather than just 200'ing. Services not written with CORS in mind tend not to handle the OPTIONS preflight but those written for CORS often make use of it for validation checks.

I'm going to close this as I don't need it any more, and also I think the more generic header support mentioned in #168 should cope with it.


Use the JSON states taxonomy to translate States

We now have a JSON export of the states for the contributor tab:
https://static.openfoodfacts.org/data/taxonomies/states.json
You can enable the contributor tab in the app settings.

Hey @teolemon. I want to work on this.I can see two tasks in the above Issue:

Improve the UI
Make the translations available in our own language

Shall I start working on this? Also for the UI do you have any particular suggestions in mind?

If you're still in for this, there's a couple of suggestions:

[ ] Fix the dark mode by removing the hardcoded white background: https://user-images.githubusercontent.com/1689815/87653900-80c91c80-c756-11ea-92bb-7cabbffa721f.png
[ ] Remove the image card (we now have a dedicated tab for it)
[ ] Create 2 states sections - DONE & TODO: https://github.com/openfoodfacts/openfoodfacts-androidapp/issues/1498

The current implementation uses the slugs present in the product instead of the translation in your language available in the taxonomy (and is a bit ugly)

I have implemented the translation. Do you have any layout in mind for this? @teolemon

The current implementation uses the slugs present in the product instead of the translation in your language available in the taxonomy (and is a bit ugly)

I have implemented the translation. Do you have any layout in mind for this? @teolemon


Move seed number info from comment to property

I think it is better to use special element for seed info.

I like this!

This looks like it would really solve an issue I've got, any chance we could see a release of the gem with it?


Add Yarn lockfile to gitignore

Is there any particular reason for adding it?

@kbrsh maybe someone who uses Yarn would contribute

It's not used in this project, and IMO contributors should be responsible enough to only add the files they worked on.


Make the REPL a bit nicer to use

Currently, the repl is mostly used for debug purposes - compiled code is printed, and each piece of code is executed with its own context and stack. It would be nice to have a opt-in/opt-out way to toggle this debugging functionality.
Additionally (idk how hard or easy this is) up-arrow and down-arrow would be nice to select previous snippets, and it'd be cool if ^Cing while the repl was executing something only exited that execution, not the entire repl.

Perhaps a Vyxal REPL deserves its own project? I'd be happy to make it, once I find time :p

In progress here: https://github.com/Vyxal/Crosshatch/

Should there be a .vyxal_history file or should it only remember the current session's history when you hit the up arrow?


Interpolation support

Resolves #296

This looks like a useful addition. Although if  interpolate is being exposed does it also make sense to expose tension?

Although if interpolate is being exposed does it also make sense to expose tension?

Yes, I think so - good idea! I've updated to expose tension too.

Nice one - thanks.


How do I use this driver for MTI-30?

Hi,
I have a MTI-30 model. When I run the driver it crashes with
[ERROR] [1628158672.132779485] [xsens_mti_node]: No MTi device found.
but lsusb does show this ;
Bus 001 Device 007: ID 2639:0003 Xsens MTi-30 AHRS
How can I use this driver for my sensor ?

Ahh OK.
Needed to do;
sudo chmod 777 /dev/ttyUSB0
it will be nice if you put a notice on Readme about that. So other people notice it.

@jediofgever  This issue has been documented in the readme. Take a look at the following point in the troubleshooting section. The correct way to handle this issue is by adding the user to dialout group. Doing a chmod, sometimes resets the permissions when the device is disconnected and connected back.

- The device is recognized, but I cannot ever access the device -

    Make sure you are in the correct group (often dialout or uucp) in order to
    access the device. You can test this with

        $ ls -l /dev/ttyUSB0
        crw-rw---- 1 root dialout 188, 0 May  6 16:21 /dev/ttyUSB0
        $ groups
        dialout audio video usb users plugdev

    If you aren't in the correct group, you can fix this in two ways.

    1. Add yourself to the correct group
        You can add yourself to it by using your distributions user management
        tool, or call

            $ sudo usermod -G dialout -a $USER

        Be sure to replace dialout with the actual group name if it is
        different. After adding yourself to the group, either relogin to your
        user, or call

            $ newgrp dialout

        to add the current terminal session to the group.

    2. Use udev rules
        Alternatively, put the following rule into /etc/udev/rules.d/99-custom.rules

            SUBSYSTEM=="tty", ATTRS{idVendor}=="2639", ACTION=="add", GROUP="$GROUP", MODE="0660"

        Change $GROUP into your desired group (e.g. adm, plugdev, or usb).

Many thanks for the additional info. I will switch to that method then.
I


Provide a way to iterate through the edges of a device

Is your feature request related to a use case or problem? Please describe.
I am working on the 2 qubit interaction visualization and wanted to generate random characterization data for each of the edges of the Sycamore chip.
Describe the solution you'd like
There is no way to retrieve a list of the edges on the chip - despite the cirq.google.Sycamore representation printing out the diagram nicely.
Describe alternatives/workarounds you've considered
As currently I'm only working on an example, I will just rely on a copy-pasta from the SerializableDevice.__str__ function:
            # Find pairs that are connected by two-qubit gates.
            Pair = Tuple['cirq.GridQubit', 'cirq.GridQubit']
            pairs = {
                cast(Pair, pair)
                for gate_defs in self.gate_definitions.values()
                for gate_def in gate_defs
                if gate_def.number_of_qubits == 2
                for pair in gate_def.target_set
                if len(pair) == 2
            }

But this is far from ideal. It would be much better to have something like cirq.google.Sycamore.edges() or something similar.
Additional context (e.g. screenshots)
Maybe the generic GraphDevice is the answer to this as well?
What is the urgency from your perspective for this issue? Is it blocking important work?
P3 - I'm not really blocked by it, it is an idea I'd like to discuss / suggestion based on principle
(because I have a workaround at the moment)

The above workaround doesn't work for Bristlecone, it uses a completely different way to display the ascii diagram based on neighbors_of:
    def neighbors_of(self, qubit: GridQubit):
        """Returns the qubits that the given qubit can interact with."""
        possibles = [
            GridQubit(qubit.row + 1, qubit.col),
            GridQubit(qubit.row - 1, qubit.col),
            GridQubit(qubit.row, qubit.col + 1),
            GridQubit(qubit.row, qubit.col - 1),
        ]
        return [e for e in possibles if e in self.qubits]

The above workaround doesn't work for Bristlecone, it uses a completely different way to display the ascii diagram based on neighbors_of:
    def neighbors_of(self, qubit: GridQubit):
        """Returns the qubits that the given qubit can interact with."""
        possibles = [
            GridQubit(qubit.row + 1, qubit.col),
            GridQubit(qubit.row - 1, qubit.col),
            GridQubit(qubit.row, qubit.col + 1),
            GridQubit(qubit.row, qubit.col - 1),
        ]
        return [e for e in possibles if e in self.qubits]

+1 for adding this to the device. For reference, we usually refer to "pairs" internally, rather than "edges", see our internal GridDevice implementation.

+1 for adding this to the device. For reference, we usually refer to "pairs" internally, rather than "edges", see our internal GridDevice implementation.


How do I uninstall this software?

I follow the README to install it with install.sh script for Debian, but there is no uninstall script.

cd build
sudo ninja uninstall
rm -rf ~/.local/share/hawck

This will remove the binaries, systemd configurations, and example files.


Clarified page type as web page

Clarified layout type as "web page."

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

This is my first pull request. I have a lot to learn before I can truly contribute to freecodecamp's cause, but saw this as something simple that might help clarify something for users.

@RandellDawson Yes, you are probably right. Thank you for the feedback.

Since you seem to agree, I am going to close this PR.  Thank you for opening this pull request for us to review.  We would welcome future pull requests from you.
Thank you and happy coding.


Add missing quotes

@gothicx I'm pretty sure it's still valid YAML without the quotes :-)
But if it's confusing, I guess it does no harm to add them

@crayfishx It probably work, but for the args I think it's easier to identify them with the color in the YAML syntax highlighter.

Fair enough


(ui) Update owners.json

Since we had a team change in the recent history I would like to propose two new owners for this repository.

@mesosphere-mergebot sync

@mesosphere-mergebot Ready-for-review

@mesosphere-mergebot label Ready For Review

@mesosphere-mergebot changelog-not-required "Not a user-facing change."

@mesosphere-mergebot override-status teamcity/dcos/test/terraform/aws/onprem/static/group2 teamcity/dcos/test/terraform/aws/onprem/static/strict/group/1

@mesosphere-mergebot override-status teamcity/dcos/test/terraform/aws/onprem/static/group2  DCOS-62478

@mesosphere-mergebot merge-it


Include the child tag name into 'InvalidChildElement' error.

This makes the error much more useful. Including the actual name of a tag that caused problem makes it possible to figure out what's wrong with the gpx file without having to go through the library code finding out what did it expect.
Full context
I've been trying to parse the gpx track from my Garmin device, but gpx::read errored out with:
invalid child element in track

I opened the file and saw the following:
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<gpx xmlns="http://www.topografix.com/GPX/1/1" xmlns:gpxx="http://www.garmin.com/xmlschemas/GpxExtensions/v3" xmlns:gpxtrkx="http://www.garmin.com/xmlschemas/TrackStatsExtension/v1" xmlns:wptx1="http://www.garmin.com/xmlschemas/WaypointExtension/v1" xmlns:gpxtpx="http://www.garmin.com/xmlschemas/TrackPointExtension/v1" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" creator="GPSMAP 64s" version="1.1" xsi:schemaLocation="http://www.topografix.com/GPX/1/1 http://www.topografix.com/GPX/1/1/gpx.xsd http://www.garmin.com/xmlschemas/GpxExtensions/v3 http://www8.garmin.com/xmlschemas/GpxExtensionsv3.xsd http://www.garmin.com/xmlschemas/TrackStatsExtension/v1 http://www8.garmin.com/xmlschemas/TrackStatsExtension.xsd http://www.garmin.com/xmlschemas/WaypointExtension/v1 http://www8.garmin.com/xmlschemas/WaypointExtensionv1.xsd http://www.garmin.com/xmlschemas/TrackPointExtension/v1 http://www.garmin.com/xmlschemas/TrackPointExtensionv1.xsd">
  <metadata>
    <link href="http://www.garmin.com">
      <text>Garmin International</text>
    </link>
    <time>2018-02-22T10:40:38Z</time>
  </metadata>
  <trk>
    <name>2018-02-22 11:40:31</name>
    <extensions>
      <gpxx:TrackExtension>
        <gpxx:DisplayColor>Blue</gpxx:DisplayColor>
      </gpxx:TrackExtension>
      <gpxtrkx:TrackStatsExtension>
        <gpxtrkx:Distance>60986</gpxtrkx:Distance>
        <gpxtrkx:TotalElapsedTime>88210</gpxtrkx:TotalElapsedTime>
        <gpxtrkx:MovingTime>14117</gpxtrkx:MovingTime>
        <gpxtrkx:StoppedTime>4865</gpxtrkx:StoppedTime>
        <gpxtrkx:MovingSpeed>4</gpxtrkx:MovingSpeed>
        <gpxtrkx:MaxSpeed>19</gpxtrkx:MaxSpeed>
        <gpxtrkx:MaxElevation>1334</gpxtrkx:MaxElevation>
        <gpxtrkx:MinElevation>1102</gpxtrkx:MinElevation>
        <gpxtrkx:Ascent>1692</gpxtrkx:Ascent>
        <gpxtrkx:Descent>1660</gpxtrkx:Descent>
        <gpxtrkx:AvgAscentRate>0</gpxtrkx:AvgAscentRate>
        <gpxtrkx:MaxAscentRate>2</gpxtrkx:MaxAscentRate>
        <gpxtrkx:AvgDescentRate>0</gpxtrkx:AvgDescentRate>
        <gpxtrkx:MaxDescentRate>-4</gpxtrkx:MaxDescentRate>
      </gpxtrkx:TrackStatsExtension>
    </extensions>
    <trkseg>
      <trkpt lat="60.4295433965" lon="7.7490838990">
        <ele>1166.69</ele>
        <time>2018-02-21T10:10:28Z</time>
      </trkpt>
      <trkpt lat="60.4295495991" lon="7.7490779478">
        <ele>1166.69</ele>
        <time>2018-02-21T10:10:29Z</time>
      </trkpt>
      <trkpt lat="60.4295322485" lon="7.7490347810">
        <ele>1166.82</ele>
        <time>2018-02-21T10:11:00Z</time>
      </trkpt>
      ...many...more...track...points....
    </trkseg>
  </trk>
</gpx>

It was my first time looking at GPX and my first time using rust-gpx (also the first time playing with Rust), so I couldn't tell right away which part of that XML is considered invalid. However I saw that the xml schema/namespace references some Garmin's extensions to GPX and thought that it must be what rust-gpx doesn't like.
I had a look at src/parser/track.rs and saw that it matches some standard tags, and for any other tag it just returns InvalidChildElement("track") throwing away the actual name of "invalid" element.
I didn't want to keep eyeballing my file, cross-referencing it with the list of tags expected by track.rs. Instead I wanted to actually improve the error message, so I made this patch which makes it produce the following error message:
invalid child element 'extensions' in track

This gives a reference to the unexpected thing and allows to easily find it in the xml file, meaning that if later somebody runs the parser on unsupported gpx file they'll have easier time figuring out the problem and reporting it.
P.S. I'm very much a rust newbie, so any improvement suggestions will be appreciated.
P.P.S. I still want to parse and process my files and also improve the experience of parsing GPX files with third-party extensions, but that'll go into another issue/PR.

The build was failed due to code formatting. I've now run cargo fmt and amended the commit.

@zudov, this is great, thank you for putting this together. I've merged it in as https://github.com/georust/rust-gpx/commit/92dbb56564cfd9defdc9a655d0cda84af5c3ec64.
I look forward to any thoughts/work you have on enabling extensions! I'm not sure the best way to approach it so I'd love to see where you go. I opened https://github.com/georust/rust-gpx/issues/8 as a tracking issue for it.


Cannot run pyvista examples on npps0

The error message is:
libGL error: No matching fbConfigs or visuals found
libGL error: failed to load driver: swrast
2024-05-16 18:35:20.590 (   3.412s) [    7F9ADE20F240]vtkXOpenGLRenderWindow.:651    ERR| vtkXOpenGLRenderWindow (0x334a150): Cannot create GLX context.  Aborting.
ERROR:root:Cannot create GLX context.  Aborting.
Aborted (core dumped)

To reproduce on npps0 run:
python -m venv venv
source venv/bin/activate
pip install pyvista
python -c "import pyvista as pv; pv.examples.download_puppy().plot()"

The libGL errors disappear if the following environment variable is set:
export LIBGL_ALWAYS_INDIRECT=1

I can confirm that I can reproduce the issue.

I found an issue on pyvista repo but the solution provided there doesn't work for me. Dropping it here for reference. https://github.com/pyvista/pyvista/issues/3176

@plexoos I think that I found the solution to the issue. Need to use the vtk os-mesa variant. See https://github.com/pyvista/pyvista/discussions/4024
python -m venv venv
source venv/bin/activate
pip install pyvista
pip uninstall vtk -y
pip install vtk-osmesa --extra-index-url https://gitlab.kitware.com/api/v4/projects/13/packages/pypi/simple

After this, the command runs without error.
(venv) [rahmans@npps0 ~]$ python -c "import pyvista as pv; pv.examples.download_puppy().plot()"
(venv) [rahmans@npps0 ~]$

Can you please verify?

Can confirm that I can run this example and save the image output to pdf
import pyvista as pv
from pyvista import examples
pl = pv.Plotter()
_ = pl.add_mesh(examples.load_airplane(), smooth_shading=True)
_ = pl.add_background_image(examples.mapfile)
pl.save_graphic("img.pdf")

Thank you Sakib! I followed your instructions and the command indeed ran without errors on npps0. On my laptop, however, when I run the same pyvista example I get an interactive window displaying some 3D capabilities. I wonder if there is something else is missing from our setup on npps0...

@dmitri: Is that the 3D window you mentioned?

If it is interactive and the object can be rotated with your mouse pointer then yes. Here is the command I use python -c "import pyvista as pv; pv.examples.download_puppy().plot()"

Great! It means the problem is on my side. Could you freeze your virtual environment and share it with me so I can reproduce? Also, if there is anything else you think I need to adjust in my environment please let me know.

@plexoos I really did nothing special, just "python -m venv blah",with the standard Python 3.12 as installed on our node, then "pip install pyvista". If there is anything suspect it's the pipeline for graphics from npps0 to your screen (not a strong theory but still). I'm on mobaXterm. Are you sure you have the X11 forwarding in place?

AFAICT, my X11 forwarding works and I can open graphical windows (xlock, xeyes) on my laptop from npps0. However, when I do the test as in the original post I get nothing and the command just exits. @rahmans1 does it open a window for you on your remote terminal?
@buddhasystem there must be something different in your environment on npps0 as both Sakib and I see the errors as reported but in your case it simply works with the default vtk

Well, since I did this with the virtual env, and I don't have extras, it really boils down to something external to the host, npps0. But there are more mysteries -- when running examples on my local WSL2 machine, I see black screen in the pyvista GUI. When I kill the app the true picture appears briefly. I tried my GL trick I use with Geant, it didn't help. Unfortunately, there is something arcane in how pyvista works wrt drivers.

The issue may be quite complex i.e. qt and vtk version related: https://github.com/pyvista/pyvistaqt/issues/54

@plexoos ...and I also tested on a standalone Debian machine with an older NVIdia GPU where things "just work". So in the end, we are looking at some combinatorial situation with vtk, qt, pyvista and perhaps actual drivers. Do we like this platform?

So in the end, we are looking at some combinatorial situation with vtk, qt, pyvista and perhaps actual drivers

My assumption is that we use the same libraries on the same machine with the same drivers... Isn't it the case?

Can confirm that it doesn't open an interactive window when I remote login from Mac.

I also cannot open x windows when using the default python on npps0:
$ python -c "import matplotlib.pyplot as plt; plt.plot([1,2,3]); plt.show()"
<string>:1: UserWarning: FigureCanvasAgg is non-interactive, and thus cannot be shown

However, the official python images works just fine
docker run --rm --volume="$HOME/.Xauthority:/root/.Xauthority" -e DISPLAY=$DISPLAY --network=host python:3.12.0 sh -c 'pip install matplotlib; python -c "import matplotlib.pyplot as plt; plt.plot([1,2,3]); plt.show()"'

From that I conclude that there is something wrong with how python was installed on npps0

Just to add that the airplane example works 100% for me on npps0:
python -c "import pyvista as pv; pv.examples.load_airplane().plot()"

...and yet, this forces us to install indirect dependencies like pyqt. What else do we need to install to make the pyvista example work?

Just to add that the airplane example works 100% for me on npps0: python -c "import pyvista as pv; pv.examples.load_airplane().plot()"

please provide complete instructions so we can also verify that

Nope, same error for me
$ python -c "import pyvista as pv; pv.examples.load_airplane().plot()"
libGL error: No matching fbConfigs or visuals found
libGL error: failed to load driver: swrast
2024-05-22 11:56:06.802 (   1.738s) [    7F21B6827240]vtkXOpenGLRenderWindow.:651    ERR| vtkXOpenGLRenderWindow (0x34ebef0): Cannot create GLX context.  Aborting.
ERROR:root:Cannot create GLX context.  Aborting.
Aborted (core dumped)
(venv) [dmitri@npps0:~]
$ pip freeze
certifi==2024.2.2
charset-normalizer==3.3.2
contourpy==1.2.1
cycler==0.12.1
fonttools==4.51.0
idna==3.7
kiwisolver==1.4.5
matplotlib==3.9.0
numpy==1.26.4
packaging==24.0
pillow==10.3.0
platformdirs==4.2.2
pooch==1.8.1
pyparsing==3.1.2
python-dateutil==2.9.0.post0
pyvista==0.43.8
requests==2.32.2
scooby==0.10.0
six==1.16.0
urllib3==2.2.1
vtk==9.3.0

Looks like one need to enable GLX on the MacOs X-window side
defaults write org.xquartz.X11 enable_iglx -bool true

With this the pyvista test command at least tries to open a local window but it is black and disappears right away. The new error message is:
$ python -c "import pyvista as pv; pv.examples.download_puppy().plot()"
2024-05-22 14:00:26.238 (   1.346s) [    7F6559354240]vtkOpenGLRenderWindow.c:710    ERR| vtkXOpenGLRenderWindow (0x355fae0): Unable to find a valid OpenGL 3.2 or later implementation. Please update your video card driver to the latest version. If you are using Mesa please make sure you have version 11.2 or later and make sure your driver in Mesa supports OpenGL 3.2 such as llvmpipe or openswr. If you are on windows and using Microsoft remote desktop note that it only supports OpenGL 3.2 with nvidia quadro cards. You can use other remoting software such as nomachine to avoid this issue.
ERROR:root:Unable to find a valid OpenGL 3.2 or later implementation. Please update your video card driver to the latest version. If you are using Mesa please make sure you have version 11.2 or later and make sure your driver in Mesa supports OpenGL 3.2 such as llvmpipe or openswr. If you are on windows and using Microsoft remote desktop note that it only supports OpenGL 3.2 with nvidia quadro cards. You can use other remoting software such as nomachine to avoid this issue.
Segmentation fault (core dumped)

@plexoos Can we try using a different platform plugin than what it defaults to. Check out this issue.
https://github.com/pyvista/pyvista/issues/2924

Sure, I am open to any solution. Have you tried to use xvfb?

@plexoos I don't have permission to install xvfb on npps0.

hm... looks like you are in the wheel group. Does sudo work for you? @buddhasystem

@plexoos I would really like to understand what we are pursuing here. If it's just validation of the Opticks tests, would an export to PDF work as a reasonable approximation? Unless this "pyvista" is a part of our final product, there is no sense in trying to make this finicky package work for all cases. Alternatively, I can lend you an extra desktop for your office where you can visualize with pyvista -- if it's about going through the opticks example, it should do the trick.

This is becoming a time sink.

If you have better suggestions how to visualize the results from an opticks tests, please let us know. pyvista was suggested by the author, see https://groups.io/g/opticks/message/526

@plexoos I made a suggestion which is workable, use any computer other than Mac to visualize it. This is the most expedient solution.

I am closing this issue as we have found a workaround for Mac users to view graphical windows (with 3D OpenGL graphics) by utilizing remote desktops such as tigervnc. It appears the Windows users may have better luck opening such windows directly from a remote GPU host.


<EMAIL_ADDRESS>hash check failed

Download: (OK):download completed.
Checking hash of MSIAfterburnerSetup.zip ... ERROR Hash check failed!
App:         extras/msiafterburner
URL:         https://download.msi.com/uti_exe/vga/MSIAfterburnerSetup.zip?token=exp=zzzz~acl=/*~zzzzzzzz#/dl.zip
First bytes: 50 4B 03 04 14 00 00 00
Expected:    e71a5b2dd4bf010c6742f8138ba3f6500082c46baf940ba950fe50213d9579e8
Actual:      521cdbe532a8a8dfb3217a4b0b99c6b8f2709b90dcf0d764dbbcbf4b8f1230f9
Please try again or create a new issue by using the following link and paste your console output:
https://github.com/ScoopInstaller/Extras/issues/new?title=msiafterburner%4<IP_ADDRESS>94%3A+hash+check+failed

#6976


Discussion: Future Plans

First of all, I think I rushed it when I put Vite under 1.0-rc state. There are definitely still some rough edges that I want to improve that may result in non-trivial breaking changes:

I want to refactor into a plugin structure that allows better reuse of logic between the dev server and the production build (similar to WMR's universal Rollup plugin interface). This will also replace the current transform API, and better separate the concept between "server middleware" and a "file transform". Additionally, this allows the dev server to expose an API to apply all transforms to a given file without going through the server middleware chain, which has non-trivial overhead (such an API is needed when I was investigating SSR support in Vite).

We may also want to rethink the file aliasing/resolver handling to make it simpler (e.g. using resolveId from the unified rollup plugin interface instead)

Move Vue specific logic into its own dedicated plugin (this also gets rid of all Vue-specific config options)

But looks like there is already an ecosystem growing, so there's already some compatibility concerns to be taken into account. Since ranges like ^1.0.0-rc will allow installing 1.0.0, I think we should call it 1.0 and release it in its current state and leave the breakage for 2.0.
Some non-breaking improvements:

Smarter dep optimization for deep imports. We should use es-module-lexer to scan imports in the codebase so we know exactly what deps to include in the dep optimization step (this avoids the need to manually exclude/include when using deep imports)

Error overlay (currently failed compiles often result in blank screens with errors only in the console)

Better logging (avoid spamming console with the same message over and over)

Could we make Vite helpful to library development (like storybook.js) ?
https://github.com/vitejs/vite/issues/330
https://github.com/vitejs/vite/issues/725

[ ] https://github.com/vitejs/vite/issues/257, Multi-page

I want to refactor into a plugin structure that allows better reuse of logic between the dev server and the production build (similar to WMR's universal Rollup plugin interface).

Skeptical whether it's worth the plugin churn. Is there an example where the current design makes plugin development unbearable, or at least makes code reuse impossible?

We may also want to rethink the file aliasing/resolver handling to make it simpler (e.g. using resolveId from the unified rollup plugin interface instead)

Which parts of the resolver API could be simplified? What are the benefits of using resolveId-style API?

Smarter dep optimization for deep imports. We should use es-module-lexer to scan imports in the codebase so we know exactly what deps to include in the dep optimization step

Vite currently lazy-loads all modules, and this idea goes against that. Is the dent on startup time worth it? Maybe it could be an option (eg: optimizeDeps: { deepScan: true }).

Would it suffice if we take parts of WMR that already works great (rollup plugin driver, css chunking on build, etc.) and make it usable for Vue and any other uses?
Some Vite plugins are already wrappers around their respective Rollup plugins (svite for example), and I think it would be a good idea if Vite would follow what Rollup plugin API has to offer, instead of the other way around, but still allowing any additional Vite-specific hooks if it comes down to it.

The proposed improvements sound great.
I don't think the breaking changes proposed would take more than a few hours to fix in any particular project. Additionally, there aren't many highly usable plugins in the wild so you shouldn't worry about breakage too much.
My guess is that the things that have been frustrating will be addressed by your changes (SSR features and aliasing quirks).

I want to refactor into a plugin structure that allows better reuse of logic between the dev server and the production build (similar to WMR's universal Rollup plugin interface).

That is very important for prevent ecosystems are fragmented between dev and  build.  I remember that the user often encounter the inconsistent behavior between dev and build when project is growing, and also the project test is complex for some edge case.

Smarter dep optimization for deep imports. We should use es-module-lexer to scan imports in the codebase so we know exactly what deps to include in the dep optimization step (this avoids the need to manually exclude/include when using deep imports)

My opinion as same as @aleclarson. The cost is expensive for scan imports in the codebase, we should retain the option for users manually optimize their porject.

We may also want to rethink the file aliasing/resolver handling to make it simpler (e.g. using resolveId from the unified rollup plugin interface instead)

For this, we should consider the css @import alasing (https://github.com/vitejs/vite/issues/650) and the asset alasing inside template and css(https://github.com/vitejs/vite/issues/913).

@csr632 I think it can be improved if has a new plugin system. For now the vite internal maintainer a html plugin of build and also the html used inside dev, it is can be separate into single plugin.

#1229, resolve node_modules as normal paths and support importing from outside root (../..)

@yyx990803 How do you feel about Snowpack now, as opposed to when Vite started?
In the Why and How? doc you highlighted differences when you started Vite, but it seems to me that over time, those differences vanished... or could vanish.
Snowpack also supports HMR nowadays, and Vue works out of the box. In v3, building for production is a plugin, so you could use rollup if you prefer that to webpack or esbuild (their new default).
v3 has cool new features like npm install-less development.
Snowpack is also built on a plugin model, so it really makes me wonder if there shouldn't be some synergy here. Why duplicate efforts?
Seeing how both projects evolved, don't you think it may make more sense to merge Vite into Snowpack 3 contributions? You could improve their Vue support with what you learnt when building Vite and they have all the other "generic web server" stuff figured out.

@jods4 interesting points. The SSR approach they've outlined really sounds awesome to me. I've mentioned this before as Vite seems to have an unnecessarily verbose approach currently.

@jods4 re Snowpack:

Vue works out of the box

It works, but there's no real Vue HMR. Snowpack 's "Vue HMR" actually remounts the entire Vue app on every update. Not to mention fine-grained style/template HMR without blowing away component state. We could probably figure out how to get the same level of HMR support via Snowpack's API, but it's duplicated effort and is most likely going to be less efficient than what is already available in Vite.

building for production is a plugin, so you could use rollup if you prefer that to webpack or esbuild (their new default).

Since Vite's goal is to provide a full toolchain that includes an opinionated build setup and that Snowpack does not actually do that, we still need to absorb the complexity of the production bundling. Splitting dev-time special logic in Snowpack and build-specific logic in a custom plugin (which is constrained by how Snowpack outputs its build assets) actually would result in more complexity than having a single system that unifies both.

Snowpack is also built on a plugin model

Snowpack plugins are not compatible with Rollup plugins. One of the goals of Vite v2 is to actually support a superset of Rollup plugins that works for both dev and build (e.g. I already got rollup-plugin-vue, @rollup/plugin-node-resolve and @rollup/plugin-alias working without modification in the local prototype).

v3 has cool new features like npm install-less development.

I'm actually not sure if this is even a good feature to have. Looking from their docs I have a number of questions:

How do you specify version ranges? If you put it inline, you'll have to make sure to use the same version everywhere you import that dep. If not, you still need to use an explicit dependency config file. This is the same problem with Deno.

This model requires you to all-in on Skypack, because Skypack packages are pre-compiled with all peer dep package cross-imports pointing to their Skypack URLs as well. That is to say, you can't mix this model with traditional local npm installs. It's Skypack or nothing. And if one of your deps doesn't work on Skypack (which happens more than you think), your have to bail out. This also touches on something that bothers me a bit with Snowpack: that it's owned by a startup that is using it as a strategy to promote its paid product. I don't feel comfortable betting the future of Vue tooling on Snowpack.

@arpowers rest assured you can do something similar in Vite 2.0.

@yyx990803  Is there a release schedule for the v2 version? Am looking forward to

@yyx990803 very interesting insight, thanks!

I think the plan sounds about right.
Putting out v1 for those who have already put things out in production, with the caveat the limitations of further development/support.
The focus should be on v2 based on lessons learnt from v1.
Even VueJS had changes from v1 to v2, with v2 gaining traction very well over time.

https://github.com/vitejs/vite/tree/2.0

Looks much improved Evan. In particular, the organization is easier to follow. WIll be looking forward to the breakdown of changes; I can already tell this will solve many of the early issues my team has had to work around.

Awesome! Would it be too hard to make v2 compatible with ESM projects (those that include "type": "module" in their package.json) without patches?

I also wish to request taking care of some security concerns https://github.com/vitejs/vite/issues/537

Don't forget about PostCSS 8 support (for tailwind) ...  https://tailwindcss.com/docs/guides/vue-3-vite

As https://github.com/vitejs/vite/issues/1253 mention, Here hasn't plateform of dicussion at now and hasn't offical docment.It is very important for vite communtiy, it should be listed on the vite2.x.

Smarter dep optimization for deep imports. We should use es-module-lexer to scan imports in the codebase so we know exactly what deps to include in the dep optimization step (this avoids the need to manually exclude/include when using deep imports)

I'm not sure if that would be addressed, but the only pain point with vite right now to me is that the initial page load can be slow (5+ seconds in my case) if there's a lot of modules loaded right away. I could ease the issue by doing more imports async but I don't want to code split more just for the sake of better DX. I'll try to experiment with something like: async import in dev / sync import in production for page components in the router. But it would be awesome if this issue improved in general... in some way:))

Closing this now that 2.0 is in beta. Some of the todos like SSR is tracked in their own dedicated issues. New docs available at http://vitejs.dev/
Re @MartinMalinda - I think we can open another issue specifically dedicated to improving first load speed. I think Vite 2's strong caching of dependencies should already improve that to some extent - for user source code, the possible solution is fs-based persistent cache. We can dump the cached module transform results to disk on server close and reuse it on the next server start.

Closing this now that 2.0 is in beta. Some of the todos like SSR is tracked in their own dedicated issues. New docs available at http://vitejs.dev/
Re @MartinMalinda - I think we can open another issue specifically dedicated to improving first load speed. I think Vite 2's strong caching of dependencies should already improve that to some extent - for user source code, the possible solution is fs-based persistent cache. We can dump the cached module transform results to disk on server close and reuse it on the next server start.


cider-quit times out

When I do an M-x cider-quit in Emacs, HyREPL says on the console:
in: {'op': 'close', 'session': '42bf318e-3be5-4b93-a773-6cdbcf6945f8', 'id': '8'}
Client gone

Yet, in Emacs, after confirming that I want to quit CIDER, I get a message that the connection was broken by the remote peer, then Emacs hangs for a few seconds until it times out, and I get a message about that too:
Are you sure you want to quit CIDER? (y or n) y
nREPL: Connection closed (connection broken by remote peer
)
nrepl-send-sync-request: Sync nREPL request timed out (op close session 42bf318e-3be5-4b93-a773-6cdbcf6945f8 id 8)

I suppose the close op wants some kind of reply too.

Solved with 74aa4c053d009aedf06231d34b6b96d358b000a9.


How does spend limit duration work?

I would assume setting this to TRANSACTION would mean that I could only spend up to the limit on a single transaction - but this is not what happens. As you can see in the screenshot above, the limit is set to $50, but I'm able to make multiple transactions after each-other as long as they're under $50

Nvm, I thought it corresponded to a single transaction - it's actually any transaction under the limit :)


Update sbt-sonatype to 3.9.5

Updates org.xerial.sbt:sbt-sonatype from 3.9.1 to 3.9.5.
GitHub Release Notes - Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.xerial.sbt", artifactId = "sbt-sonatype" } ]

labels: sbt-plugin-update, semver-patch

Superseded by #142.


Fix use_auth_token with ORTModel

This broke in https://github.com/huggingface/optimum/pull/1578 cc @mht-sharma
Fixes https://github.com/huggingface/optimum/issues/1737

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


[Hub Generated] Review request for Microsoft.DocumentDB to add version stable/2023-11-15

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see Getting help section below.
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!

[x] New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix swagger quality issues in S360.
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[ ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[ ] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason.
Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

/azp run

@Maya-painter can you review this PR again?
We changed an enum to string in this API version based on the recommendations from Java SDK reviewers. We do see that it's triggering a bunch of breaking change gates. Can we get this approved?

@ms-zhenhua anything on this?

@rkmanda Can we get this reviewed?
We changed an enum to string in this API version based on the recommendations from Java SDK reviewers. We do see that it's triggering a bunch of breaking change gates. Other than that the previous changes were already approved by another reviewer.

@rkmanda Can we get this reviewed? We changed an enum to string in this API version based on the recommendations from Java SDK reviewers. We do see that it's triggering a bunch of breaking change gates. Other than that the previous changes were already approved by another reviewer.

Can you please get approval from the breaking change board ? You are currently in Step 1 in the diagram above so ARM review has not started yet. Please get the approval before starting the ARM review again (Step 2)

@raosuhas I have created a breaking change item here: https://msazure.visualstudio.com/One/_workitems/edit/26005662
The breaking change is a simple fix for an incorrect change that was propagated in last stable swagger. The SDK release team has blocked the release of SDKs due to that change, and no customers have been impacted because of that. Let me know if I need to do anything else to get this approved.

@rkmanda We got the ARM signoff. Could you please merge the PR?

/azp run


feat: clean up v2 module

Further adjustment to #12 .
While the README guidance will focus on binary download as the primary way to install (because it's faster, and this tool is CI-focused), the goal here is for go install to work predictably.  It's a bit of a climb and there's some non-obvious ways in which Go handles this, particularly in later versions (and in their own way, intending to maintain backwards compatibility for Go itself)
https://go.dev/blog/v2-go-modules

There's a very complicated (golang) history to unpack, and unclear guidance about best practice (at least, considering a cobracli application).  There are some opinions about backward compatibility that Golang has, which i do not necessarily share.
There are a pair of very well-informed discussions (although with relatively different conclusions) that I'm using as a point of reference, to conclude myself:  this PR will not move forward.
https://stackoverflow.com/questions/55041915/multiple-modules-within-the-same-project
https://www.reddit.com/r/golang/comments/ipwea6/go_modules_have_a_v2_problem/
Looking to the next breaking change this project will probably introduce; the overhead of managing this is too high, the probability of failure too great.  instead I will follow a "semver first" approach, managing primarily go.mod version in main branch (as demonstrated in the go-github package).
As a CLI tool, there are different objectives for backwards compatibility and user experience.  There is a worse user experience associated with supporting go install as a mechanism for install.  PR closed.


Op Support: aten.fill.Tensor

Add aten converter.
Affected models:
Torchbench: pyhpc_turbulent_kinetic_energy

MIGraphX does not yet have a GPU fill operator. Would need to implement it to complete this issue.

We might be able to partially resolve this in cases where the fill input is a constant. There are some passes that do this for torch.zeros, torch.full, torch.arange etc

This seems similar to #146


chore: add slither config

This is so we can run slither . in any of our projects.

I realized this misses an update in README.md will update this PR accordingly.

This is now updated.