Code Review

Set up the repository.

Create the rails app.

Set up the initial configuration of the app.

Create a data model.

Create models, relations, and validations

Install RSpec.

Config bullet.

Install and configure the devise gem.

Install and configure the  CanCanCan gem.

Create a home.

Add data to show (seed database).

Create a landing page.

Create and config controllers.

Create and config views.

Add fonts and logo.

Add style based in Template.

Create integration specs.

Create model specs.

Deploy the app with Heroku.

Create a README file.

Descriptive Loom video

Hi Antonio,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that has incorrect gitflow/ GitHub flow. Kindly note that capstone projects worked on by a single contributor should have merge request from feature into development. Kindly use the correct gitflow and request another code review.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.

Hello, @rloterh
Can you please send me, WHERE in the git flow instructions says this?

Hi @AntonioHincapie
I'm not sure if you're not informed this as a student. This has however been discussed among the code reviewers.
Cheers!


SetAllowedVehiclesForIndex not working with initial_routes

I'm using or-tools with Python to solve a Vehicle Routing Problem (VRP).
When I use SetAllowedVehiclesForIndex to allow only some vehicles to some cities, it works fine. But when I add the initial_routes, the constraint added by SetAllowedVehiclesForIndex  doesn't work anymore. I get the result but the vehicles did not visit the allowed cities.
Here is the code:
"""Vehicles Routing Problem (VRP)."""

from ortools.constraint_solver import pywrapcp

def create_data_model():
    """Stores the data for the problem."""
    data = {}
    data['distance_matrix'] = [
        [
            0, 548, 776, 696, 582, 274, 502, 194, 308, 194, 536, 502, 388, 354,
            468, 776, 662
        ],
        [
            548, 0, 684, 308, 194, 502, 730, 354, 696, 742, 1084, 594, 480, 674,
            1016, 868, 1210
        ],
        [
            776, 684, 0, 992, 878, 502, 274, 810, 468, 742, 400, 1278, 1164,
            1130, 788, 1552, 754
        ],
        [
            696, 308, 992, 0, 114, 650, 878, 502, 844, 890, 1232, 514, 628, 822,
            1164, 560, 1358
        ],
        [
            582, 194, 878, 114, 0, 536, 764, 388, 730, 776, 1118, 400, 514, 708,
            1050, 674, 1244
        ],
        [
            274, 502, 502, 650, 536, 0, 228, 308, 194, 240, 582, 776, 662, 628,
            514, 1050, 708
        ],
        [
            502, 730, 274, 878, 764, 228, 0, 536, 194, 468, 354, 1004, 890, 856,
            514, 1278, 480
        ],
        [
            194, 354, 810, 502, 388, 308, 536, 0, 342, 388, 730, 468, 354, 320,
            662, 742, 856
        ],
        [
            308, 696, 468, 844, 730, 194, 194, 342, 0, 274, 388, 810, 696, 662,
            320, 1084, 514
        ],
        [
            194, 742, 742, 890, 776, 240, 468, 388, 274, 0, 342, 536, 422, 388,
            274, 810, 468
        ],
        [
            536, 1084, 400, 1232, 1118, 582, 354, 730, 388, 342, 0, 878, 764,
            730, 388, 1152, 354
        ],
        [
            502, 594, 1278, 514, 400, 776, 1004, 468, 810, 536, 878, 0, 114,
            308, 650, 274, 844
        ],
        [
            388, 480, 1164, 628, 514, 662, 890, 354, 696, 422, 764, 114, 0, 194,
            536, 388, 730
        ],
        [
            354, 674, 1130, 822, 708, 628, 856, 320, 662, 388, 730, 308, 194, 0,
            342, 422, 536
        ],
        [
            468, 1016, 788, 1164, 1050, 514, 514, 662, 320, 274, 388, 650, 536,
            342, 0, 764, 194
        ],
        [
            776, 868, 1552, 560, 674, 1050, 1278, 742, 1084, 810, 1152, 274,
            388, 422, 764, 0, 798
        ],
        [
            662, 1210, 754, 1358, 1244, 708, 480, 856, 514, 468, 354, 844, 730,
            536, 194, 798, 0
        ],
    ]
    data['initial_routes'] = [
        [8, 16, 14, 13, 12, 11],
        [3, 4, 9, 10],
        [15, 1],
        [7, 5, 2, 6],
    ]
    data['num_vehicles'] = 4
    data['starts'] = [0, 0, 0, 0]
    data['ends'] = [0, 0, 0, 0]
    return data

def print_solution(data, manager, routing, solution):
    """Prints solution on console."""
    print(f'Objective: {solution.ObjectiveValue()}')
    max_route_distance = 0
    for vehicle_id in range(data['num_vehicles']):
        index = routing.Start(vehicle_id)
        plan_output = 'Route for vehicle {}:\n'.format(vehicle_id)
        route_distance = 0
        while not routing.IsEnd(index):
            plan_output += ' {} -> '.format(manager.IndexToNode(index))
            previous_index = index
            index = solution.Value(routing.NextVar(index))
            route_distance += routing.GetArcCostForVehicle(
                previous_index, index, vehicle_id)
        plan_output += '{}\n'.format(manager.IndexToNode(index))
        plan_output += 'Distance of the route: {}m\n'.format(route_distance)
        print(plan_output)
        max_route_distance = max(route_distance, max_route_distance)
    print('Maximum of the route distances: {}m'.format(max_route_distance))

def main():
    """Solve the CVRP problem."""
    # Instantiate the data problem.
    data = create_data_model()

    # Create the routing index manager.
    manager = pywrapcp.RoutingIndexManager(len(data['distance_matrix']),
                                           data['num_vehicles'], data['starts'],
                                           data['ends'])

    # Create Routing Model.
    routing = pywrapcp.RoutingModel(manager)

    # Create and register a transit callback.
    def distance_callback(from_index, to_index):
        """Returns the distance between the two nodes."""
        # Convert from routing variable Index to distance matrix NodeIndex.
        from_node = manager.IndexToNode(from_index)
        to_node = manager.IndexToNode(to_index)
        return data['distance_matrix'][from_node][to_node]

    transit_callback_index = routing.RegisterTransitCallback(distance_callback)

    # Define cost of each arc.
    routing.SetArcCostEvaluatorOfAllVehicles(transit_callback_index)

    # Add Distance constraint.
    dimension_name = 'Distance'
    routing.AddDimension(
        transit_callback_index,
        0,  # no slack
        3000,  # vehicle maximum travel distance
        True,  # start cumul to zero
        dimension_name)
    distance_dimension = routing.GetDimensionOrDie(dimension_name)
    distance_dimension.SetGlobalSpanCostCoefficient(100)

    initial_solution = routing.ReadAssignmentFromRoutes(data['initial_routes'], True)
    print('Initial solution:')
    print_solution(data, manager, routing, initial_solution)

    # Set default search parameters.
    search_parameters = pywrapcp.DefaultRoutingSearchParameters()

    routing.SetAllowedVehiclesForIndex([0], 8)
    routing.SetAllowedVehiclesForIndex([1], 3)
    routing.SetAllowedVehiclesForIndex([2], 15)
    routing.SetAllowedVehiclesForIndex([3], 7)

    # Solve the problem.
    solution = routing.SolveFromAssignmentWithParameters(initial_solution, search_parameters)

    # Print solution on console.
    if solution:
        print('Solution after search:')
        print_solution(data, manager, routing, solution)

if __name__ == '__main__':
    main()

And here is what is printed:
Initial solution:
Objective: 255004
Route for vehicle 0:
 0 ->  8 ->  16 ->  14 ->  13 ->  12 ->  11 -> 0
Distance of the route: 2168m

Route for vehicle 1:
 0 ->  3 ->  4 ->  9 ->  10 -> 0
Distance of the route: 2464m

Route for vehicle 2:
 0 ->  15 ->  1 -> 0
Distance of the route: 2192m

Route for vehicle 3:
 0 ->  7 ->  5 ->  2 ->  6 -> 0
Distance of the route: 1780m

Maximum of the route distances: 2464m

Solution after search:
Objective: 161408
Route for vehicle 0:
 0 ->  9 ->  10 ->  16 ->  14 -> 0
Distance of the route: 1552m

Route for vehicle 1:
 0 ->  12 ->  11 ->  15 ->  13 -> 0
Distance of the route: 1552m

Route for vehicle 2:
 0 ->  3 ->  4 ->  1 ->  7 -> 0
Distance of the route: 1552m

Route for vehicle 3:
 0 ->  5 ->  2 ->  6 ->  8 -> 0
Distance of the route: 1552m

Maximum of the route distances: 1552m

As we can see index 8 is not present in vehicle route 0. Index 3 is not present in route 1 and the same for indexes 15 and 7 which are not present in routes 2 and 3.

when calling routing.ReadAssignmentFromRoutes(data['initial_routes'], True) this will "close" the model aka all subsequent constraint are ignored.
so you need to move your constraint above this call
    routing.SetAllowedVehiclesForIndex([0], 8)
    routing.SetAllowedVehiclesForIndex([1], 3)
    routing.SetAllowedVehiclesForIndex([2], 15)
    routing.SetAllowedVehiclesForIndex([3], 7)

    initial_solution = routing.ReadAssignmentFromRoutes(data['initial_routes'], True)

possible output:
[*v*]─corentinl@corentinl %./plop.py
Initial solution:
Objective: 255004
Route for vehicle 0:
 0 ->  8 ->  16 ->  14 ->  13 ->  12 ->  11 -> 0
Distance of the route: 2168m

Route for vehicle 1:
 0 ->  3 ->  4 ->  9 ->  10 -> 0
Distance of the route: 2464m

Route for vehicle 2:
 0 ->  15 ->  1 -> 0
Distance of the route: 2192m

Route for vehicle 3:
 0 ->  7 ->  5 ->  2 ->  6 -> 0
Distance of the route: 1780m

Maximum of the route distances: 2464m
Solution after search:
Objective: 184596
Route for vehicle 0:
 0 ->  8 ->  10 ->  16 ->  14 ->  9 -> 0
Distance of the route: 1712m

Route for vehicle 1:
 0 ->  1 ->  3 ->  4 -> 0
Distance of the route: 1552m

Route for vehicle 2:
 0 ->  12 ->  11 ->  15 ->  13 -> 0
Distance of the route: 1552m

Route for vehicle 3:
 0 ->  7 ->  5 ->  2 ->  6 -> 0
Distance of the route: 1780m

Maximum of the route distances: 1780m


Fixes 1369 - 1979 - 1757: apoc.export.csv.graph incorrectly exports properties with datatype 'float'

Fixes 1369
Fixes 1979
Fixes 1757
Currently append propType to propName, so in collectProps() get the wrong prop.

removed cleanPoint(): this always removes quotes
testFailsIfDelimAndArrayDelimAreEquals
roundtrip example (issue 1979)
Added support to all neo4j-admin-tool types
Added array support with bulkImport mode
Added boolean config importToolArrays (default: false) to maintain current behavior. With false the array will be parsed using ObjectMapper.writeValueAsString(), with true will be exported a neo4j-admin import compatible value (that is, with header like nameProp:dataType[] and with properties like a;b;c instead of [a,b,c]

Will this fix be merged to apoc v4.4 ?
We are using apoc v.<IP_ADDRESS> and are having issues with apoc.csv.export.all and neo4j-admin import since arrays are not exported correctly with useTypes: true.
Sounds like this fix is exactly what we need, specifically:
Added array support with bulkImport mode and the importToolArrays config


Replaced fwlinks in csharp\programming-guide\concepts\linq folder

Replaced fwlinks in csharp\programming-guide\concepts\linq and csharp\programming-guide\concepts\expression-trees folders. Related to #3424
The www.openxmldeveloper.org site is shutting down with content being moved to www.ericwhite.com, that's why I've replaced actual links as well.

@rpetrusha thank you for feedback. The GitHub link to Open XML SDK looks very useful, so I've added it to the docs.

Thanks for adding the additional links, @pkulikov. We'll merge your PR now. Your changes should appear live in the next day or two.


Support semicolon in EmailOptions MailRecipient.

Hi,
Can you add support for semicolon in EmailOptions MailRecipient and MailCopyRecipient.
someone<EMAIL_ADDRESS>Thanks

Release 1.2.3


doc: Update release_process to clarify about GitHub tagging

Add a note in the tagging section of the release process that explains
why using GitHub release process for tags should NOT be done.
Fixes #14985
Signed-off-by: Kumar Gala<EMAIL_ADDRESS>

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@cb26591). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #14990   +/-   ##
=========================================
  Coverage          ?   52.92%
=========================================
  Files             ?      309
  Lines             ?    45266
  Branches          ?    10451
=========================================
  Hits              ?    23955
  Misses            ?    16543
  Partials          ?     4768

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb26591...ed88807. Read the comment docs.

Are you sure this issue affects pre-releases only? This page seems to tell github creates light-weight tags always: https://help.github.com/en/articles/working-with-tags

I looked at all tags with git for-each-ref refs/tags. I don't know how they were created but they're all annotated tags except these five light-weight tags:
v1.14.0-rc2
v1.9.1
v1.9.2
zephyr-v1.9.1
zephyr-v1.9.2

Are you sure this issue affects pre-releases only? This page seems to tell github creates light-weight tags always: help.github.com/en/articles/working-with-tags

Looks like all github tags, will update the note.


"Small" formatting for bulleted lists got lost

Many cards that relied on the "small" formatting in the ol or ul now don't fit on the card. And some of the things in the small text got weird inner styles
The formatting was presumably stripped by the style stripping stuff in content editable normalization

... But wasn't that machinery only on style, not on class field?

The reason is because the zombie span removal removes how the actual styling is applied (spans inside the li with a class)


fix a typo in perceptron.ipynb

Add the missing right parenthesis and reverse the direction of inequality in the line 274.

fix #338


Suggestion: ability to change amazon url

Hi, i'm using another S3 services which is not s3.amazonaws.com
so an ability for changing that domain is appreciated

Is there any plan to roll out an update to AWSOptions to allow for an endpoint change?


502 Proxy error

On both Beta and Test 3 (Saturday 2nd October 21)

Is this the same issue that you faced on Friday 1st October @Vino-S ?

Hi @DeniseColbert ,
Yes, I got the same error yesterday.
I think the server is re-started but I am not sure

Fixed.


Test Python 3.11 compatibility

Might be blocked by this: https://github.com/vyperlang/vyper/pull/3129

Hey, if I have just to test and show the result, assign me this.

Hey, if I have just to test and show the result, assign me this.

OK!  Basically what we need is someone to pip install the package under 3.11 and put it through the paces, e.g. output some results for several pools (regular stableswap and metapool), and then compare them against the results from an earlier python version (3.8, 3.9, or 3.10).
You can commit the results to a PR branch and we'll take a look!

I have some error when I am trying to install curvesim with pip:
Running setup.py install for lru-dict ... error
error: subprocess-exited-with-error
× Running setup.py install for lru-dict did not run successfully.
│ exit code: 1
╰─> [7 lines of output]
running install
C:\Users\death\OneDrive\u0420\u0430\u0431\u043e\u0442\u0435\u043d \u043f\u043b\u043e\u0442\Development\Contribution\curvit.venv\Lib\site-packages\setuptools\command\install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
warnings.warn(
running build
running build_ext
building 'lru' extension
error: Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools": https://visualstudio.microsoft.com/visual-cpp-build-tools/
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: legacy-install-failure
× Encountered error while trying to install package.
╰─> lru-dict
note: This is an issue with the package mentioned above, not pip.
I have Microsoft Visual C++ 14.0 or greater installed.

Yes, still I have an issue:
Running setup.py install for lru-dict ... error
error: subprocess-exited-with-error
× Running setup.py install for lru-dict did not run successfully.
│ exit code: 1
╰─> [7 lines of output]
running install
C:\Users\ddimitr\OneDrive - SoftServe, Inc\Desktop\Testova papka\proba-py-3-11.venv\Lib\site-packages\setuptools\command\install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
warnings.warn(
running build
running build_ext
building 'lru' extension
error: Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools": https://visualstudio.microsoft.com/visual-cpp-build-tools/
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: legacy-install-failure
× Encountered error while trying to install package.
╰─> lru-dict
note: This is an issue with the package mentioned above, not pip.
hint: See above for output from the failure.

I think lru-dict do not have support for Python 3.11

Yeah, looks like: https://stackoverflow.com/a/75901434/1175053
I think it's coming from web3.py: https://github.com/ethereum/web3.py/issues/2884
We might not actually even need web3.py.  Maybe we should look into removing that.


German translations

PLEASE DO NOT MERGE - Not ready yet

Also idk if the arabic translation for the word "german" is correct, it is from google translate

    <data name="YouSeemToBeIn" xml:space="preserve">
        <value>You seem to be in</value> <!--TODO: This can't be easily translated, since in mot sentences you say the place, then the verb -->
    </data>

Also I am having a bit of issues translating this because it would need to be Du scheinst in LOCATION zu leben (zu leben goes after)
German sentence order is more like "You seem in location to live" AFAIK

It doesn't have to be exactly like the English's version, is there anything close to it in German?


fix(npm/rxjs_v5.0.x/flow_v0.34.x): mixin Observer with Observable for Subject

This extends the RxJS Subject to mixin RxJS Observer while also adding the correct definition of Subject.create.
The mentioned issue, https://phabricator.babeljs.io/T6821, now lives at https://github.com/babel/babel/issues/3871 and was fixed in https://github.com/facebook/flow/commit/b72d1c61487f9e95ddbe68c4f994d9699b7b71c9 as referenced in https://github.com/babel/babel/issues/3871.
/cc @samwgoldman @jayphelps

Something odd noticed while writing this -- prettier will delete the mixins. See https://github.com/prettier/prettier/issues/3390.

Hey, what are the needed updates (I see the tag)? The prettier issue is no more.
Just in case, I went ahead and rebased this. Let me know how I can help, I'm happy to keep getting the RxJS and redux-observable type defs updated.

Oh cool is this fixed now?

Just opened a PR for it at #1876

Thank you!


agent_handle : gevent module issue not fixed in 0.9

Rasa Core version: 0.9
Python version:  3.6
Operating system (windows, osx, ...): Windows 10 x64
Issue:
`from future import absolute_import
from future import division
from future import print_function
from future import unicode_literals
import logging
from rasa_core.channels import HttpInputChannel
from rasa_core import utils
from rasa_core.agent import Agent
from rasa_core.interpreter import RasaNLUInterpreter
from rasa_core.channels.channel import UserMessage
from rasa_core.channels.direct import CollectingOutputChannel
from rasa_core.channels.rest import HttpInputComponent
from flask import Blueprint, request, jsonify
logger = logging.getLogger(name)
class SimpleWebBot(HttpInputComponent):
def blueprint(self, on_new_message):
    custom_webhook = Blueprint('custom_webhook', __name__)

    @custom_webhook.route("/status", methods=['GET'])
    def health():
        return jsonify({"status": "ok"})

    @custom_webhook.route("/", methods=['POST'])
    def receive():
        payload = request.json
        sender_id = payload.get("sender", None)
        text = payload.get("message", None)
        out = CollectingOutputChannel()
        on_new_message(UserMessage(text, out, sender_id))
        responses = [m["text"] for m in out.messages]
        return jsonify(responses)

    return custom_webhook

def run(serve_forever=True):
#path to your NLU model
interpreter = RasaNLUInterpreter("models/nlu/default/current")
# path to your dialogues models
agent = Agent.load("models/dialogue", interpreter=interpreter)
#http api endpoint for responses
input_channel = SimpleWebBot()
if serve_forever:
agent.handle_channel(HttpInputChannel(5004, "/chat", input_channel))
return agent
if name == 'main':
utils.configure_colored_logging(loglevel="INFO")
run()`
when trying to run flask am getting following error. ** Even downgraded gevent from 1.3 to 1.2  ** but no use. @tmbo  as you guys mentioned https://github.com/RasaHQ/rasa_core/commit/93ff38333935354b1e4f01d74bbf6f7dce4242e0
if it fixed. why am still getting the error.

** please help to fix this, 2 days am looking for the solution for this issue**
Content of domain file (if used & relevant):

@tmbo  @akelad @tupac56

You are most certainly not using version 0.9 because it uses from gevent.pywsgi import WSGIServer at that location.

So please double check your version, but most likely you've installed an unsupported version of gevent  with an older rasa core version.

@tmbo

You are probably in a different env there. I took another look at the code that is tagged with 0.9.0 and this is the code at that location https://github.com/RasaHQ/rasa_core/blob/0.9.0/rasa_core/channels/rest.py#L57 and it contains the correct import (pywsgi instead of wsgi). So really make sure your code in your anaconda env is really running 0.9.0

yep, my bad. Created new Conda environment working now. I have installed 0.9.0a3 global and 0.9 in old environment , but i dont why it didnt take environment package.  Any how thanks.

:+1:


Minor bug in bankruptcy code

Found a small bug in the bankruptcy code on line 402.
if(game.nextBankruptcyBonus.val() >= game.stats()[this.currentBankruptcyStatsIndex].val() * this.bankruptcyResetFraction) {
  this.currProcess = 0;
  game.restartGame();
}

Was getting an error that game.stats was not a function. removed the () in live 402 after stats and it works fine.

Thanks @felenish ! I'm too busy to do real dev and I'm sorry I missed this for so long but I fixed it with the website editor.
I'm thinking that maybe trying to access it as a function was more tolerated in the past, or something. Not sure why I wouldn't have caught this, if it was throwing errors at the time.


Always run security recipe in fullstack

Previously, we includes the security recipe conditional on the configuration. However, it's also quite valid to have this configuration property be empty, using CDAP's pre-defined default. Instead, always running the security recipe from fullstack, which should always install the full CDAP stack, regardless of configuration, as the default start state on services is stopped.

👍 lgtm


20 filter warnings

Linked to #20

@chrichri17 could you tell me the status of this branch?

Hi @akouete-kpakpo ! This branch should have been merged a while ago.

ok @chrichri17 so I'll leave you the task to rebase the branch and merge this MR.


etcd: fix embedded etcd custom port

The port used by the client if no
server list was provided was hard coded
and not using the listen port.

run skydive-functional-tests-backend-elasticsearch

run skydive-functional-tests-backend-elasticsearch


[Bug] CI_Input get_request_header always returning null

Line 806 of the Input.php file of CodeIgniter v3.0.1
The line checks if $this->headers is empty : if not empty, it calls $this->request_headers().
It misses a negation on the emptiness check, you want to fill the $this->header array if it is empty, so the line should be :
! empty($this->headers) OR $this->request_headers();

The result of this bug is that, when calling get_request_header() without calling request_headers() beforehand, the function will always return null because the headers array of the class is never filled.

Yet another duplicate of #4056 ... please use the search bar people.


Feature request: Bedrock Knowledge Bases Connector

Use case
Integrate Bedrock Knowledge Bases with Lakechain to allow customers to publish their documents in a Bedrock Knowledge Base
Solution/User Experience
No response
Alternative solutions
No response

While reading the docs I expected this to be one of the integrations and was quite surprised that it was not there. In fact, I kept looking for it, and even checked the code base to see if perhaps it was just undocumented.

Bedrock Knowledge Base takes its input documents from S3, it is a managed end-to-end service. We created this feature request as a mean to later integrate with Bedrock KB, but I don't think it is immediately possible today.
If you need to process documents before they get indexed into Bedrock KB, you can do so with Lakechain using the S3 Connector and store your processed documents into the S3 bucket associated with your knowledge base.
But if we're missing something, let us know your exact use-case and the Bedrock KB API you'd like Lakechain to create an integration with.

Makes sense. We will provide an example for an integration with Bedrock Knowledge Bases.


Following/Followers always says you

When I am viewing another users profile
and I click on followers/following
and I have zero followers/following
Then It should not say "No One is following/follows YOU"
It should say No One is following/follows Joseph Peter

"

This will be fixed in Sufia via this PR https://github.com/projecthydra/sufia/pull/1034

Has been fixed by the latest sufia


Transparent & Blur causes highlighted text to become unreadable

Hi guys -
Steps to reproduce
1-  Settings -> Select any default extraterm theme
2-  Settings -> Interface -> Window Background:  Transparent and Blur activated
Notice you cannot read highlighted text in the terminal (e.g. man page )
3- Settings -> Interface -> Window Background:  Opaque
Notice you can now read highlighted text
Please see this demonstrated in this gif

Which git tool and operating system you using in that gif?

That's WSL2 ubuntu 20.04/Windows 10
And I'm using ZIM/ZSH - anyway the issues isn't just with Git - but even selecting text within VIM or even just mouse selection of text.

I was just able to reproduce this problem on Windows + WSL2 with and without the background blur. In vim, selected text has a background colour which matches the the normal text colour exactly. Other terminals don't do this. This also happens on plain Linux.

The problem in vim appears to be vim using colours for selection which are very close to each other. Using a different terminal theme may help. You might be able configure vim's colours too.
The problem with that git tool in the gif you attached seems to be something different because it is changes so much when transparent background is on/off. Can you tell me which git tool that is and maybe also attach the 'Jellybean' theme you're using. Then I can try to reproduce the problem locally.

Hi @sedwards2009 - Happy new year to you and the terrific exaterm development efforts.   Honestly - I had given up on that.  I ended up switching to ZINIT & ZSH using https://github.com/wfxr/forgit where exaterm behaves itself

However, I'm curious - if you try to paste to terminal from clipboard do you continue to experience the highlighted unreadability issue, like I do?

Hi @sedwards2009 - Happy new year to you and the terrific exaterm development efforts.   Honestly - I had given up on that.  I ended up switching to ZINIT & ZSH using https://github.com/wfxr/forgit where exaterm behaves itself

However, I'm curious - if you try to paste to terminal from clipboard do you continue to experience the highlighted unreadability issue, like I do?

Fixed in v0.57.1

Fixed in v0.57.1


[language][move] Added typing tests [part 2]

Motivation

Added tests for typing pass.
Tried to cover +/- cases for each check. Covers:

blocks
if
loops
while
subtype assignment
mutate
deref

Test Plan
ran em

@bors-libra r=tzakian

:pushpin: Commit 232b2f5 has been approved by tzakian

:hourglass: Testing commit 232b2f5285131c9cfeed1e8de648908d9dd1f928 with merge 6ffb7a04383270b534bd09fa39e4cd2602d7567a...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: tzakian
Pushing 6ffb7a04383270b534bd09fa39e4cd2602d7567a to master...


Optimize affine tranformation and bind it to testing

combine some operations and optimize speed

transformed = cv2.warpAffine(image1, transformation_func(image1.shape, value1, value2), image1.shape[1::-1], borderValue=image2_border)
transformed = np.clip(transformed + mask, 0, 255).astype("uint8")
current_similarity = np.abs(euclidean_distance(transformed, anchor_embedding))

use binary search instead of brute force search

#44


Add minikube support for the deploy script.

Little bug: Kruize deployment should be only done after prometheus service starts running.
On minikube, it takes a minute or two for prometheus to start running, and if kruize is deployed before it starts, the deployment fails.

Thanks for catching that ... have updated now.


self contained executable does not show all the handler options

As per documentation supported handler options are , but self container exe only show fewer options, See the attached image

network   - to receive network events
loader    - to receive assembly loader events
gc        - to receive GC events
aspnet    - to receive ASP.NET Core events
efcore    - to receive EF Core events

Other question  , if I have to build the Alpine Linux specific binary , should I run the following command ?
dotnet publish -c release -r linux-musl-x64 --self-contained -p:PublishTrimmed=true -p:PublishSingleFile=true

What you see in the screenshot is just the default set of handlers. Please run dotnet-wtrace --help to see all the available handler (I need to show help when you start dotnet-wtrace with invalid parameters). By using the --handlers switch you may decide which handlers to enable. For example, to collect only efcore events in a process with PID 1234 you could run dotnet-wtrace --handlers efcore 1234.


update stable deps and add yarn lock

Coverage remained the same at 100.0% when pulling 4debd31e81e8f36b8d2e9ce45570dc6f97241c8e on update-dep into e9dda70dbf8a5e3479bddafc69afc2d0a6905d7a on master.


Discuss: don't allow not() param is Literal

Describe the bug
I'm working for type coercion. I find
now
tests/sqllogictests/test_files/scalar.slt:914

query BB
SELECT not(1), not(0)
----
-2 -1

I don't know whether we should allow it. it break type system.
pg
psql:commands.sql:15: ERROR:  argument of NOT must be type boolean, not type integer
LINE 1: SELECT not(1), not(0);

To Reproduce
No response
Expected behavior
No response
Additional context
No response

cc @liukun4515 @alamb @Dandandan

FYI @izveigor  who I think added this feature
I think not(int) means the same as bitwisenot -- aka ~ int in postgres: https://www.postgresql.org/docs/9.4/functions-bitstring.html
I don't have any strong opinoion about supporting not(int) vs only ~.

if we let not(int) same with bitwisenot, there will be incompatibility at the point of processing NULL.

not(null) is true
~(NULL:int) is null

SELECT ~(NULL::int) is NULL;
-
t

SELECT not(NULL) is true;
-
t

cc @liukun4515 @alamb @Dandandan

I need more time to look at the current implementation.

related PR #5902


⚠ Bofrost.lu has degraded performance

In c16c2bc, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 916 ms

Resolved: Bofrost.lu performance has improved in e33b472 after 13 minutes.


remove internal FillX86BrandString usage

get rid of deprecated funciton usage warning (though FillX86BrandString still available - let's not use it by ourself)
add MSVC deprecation mark support

Thx a lot @ajax16384 !


Controller vibration not working when emulating xbox360 to ds4

Hey, not sure if this is a bug/deficiency of ucr, vigem or sharpdx.
Anyway I was able to bind all the buttons and everything except vibration is working correctly. It is working natively when testing, but not when emulating ds4 controller.
I was using https://html5gamepad.com/ to test the emulation and the native feedback. When using the vibration test in native mode it works, but not in emulated mode as expected.
I noticed that the wiki page says that force feedback is not supported, but wasn't sure if it was referring to the vibration or force feedback of wheels.

Vibration/Force feedback passthrough is a wish list feature which is missing to many pieces to be implemented any time soon, unfortunately. Support in drivers and providers might make this feasible in the future

ViGEm now has added rumble
controller.FeedbackReceived += new Xbox360FeedbackReceivedEventHandler(FeedbackEventHandler);

If I place a bounty on this can we expedite this or can I collaborate?

Hi, any update on FFB forwarding from UCR to vJoy, please?

Hello!
Any news about FFB forwarding?


Colors are rendered incorrectly

I modify colos in the config.py so that they match the colors of base16-monokai which I use in all of my environment. However, I noticed that some of the color values are shown differently from the way they are shown for any other (shell) program or even in the same shell outside of ptipython. Thus, it seems to me that color values are modified incorrectly somewhere albeit I don't really know what the reason is.

In this example blue and green show up correctly (folder color in shell - command color  in ptipython; command color in shell - "In [1]" color in ptipython). However, the color in the type signature which looks like light red/pink has the same color value and thus should look the same way as the yellow user/host line in the shell ("cutuchiqueno … sputnik3arch)
The same happens with some other but not all colors.

Hi @Cutuchiqueno,
Could you share the relevant section of the config.py file?
Sometimes it happens that colors are displayed incorrectly when the terminal has been set up to use custom colors. (Especially if colors are chosen from the 16 color palette.)
What terminal and operating system are you using? And does it happen in all terminal applications?
Jonathan

The example case from above is defined by:
# Signature toolbar.
Token.Toolbar.Signature:                      'bg:#272822 #f4bf75',
Token.Toolbar.Signature.CurrentName:          'bg:#272822 #fd971f bold',
Token.Toolbar.Signature.Operator:             '#a1efe4 bold',
The color value I was talking about is #f4bf75
There are some other colors from the theme which work particualarly bad, mostly grayish color values (from .Xresources):
! Grau 1
#define base01 #383830
! Grau 2
#define base02 #49483e
! Beige 1
#define base03 #75715e
! Beige 2
#define base04 #a59f85

I am on Arch Linux with zsh in termite.

This is weird. Thanks a lot for submitting this issue, but I still don't have any idea what's going on.
It's the Terminal256Formatter from Pygments that we use to generate color codes.
It happens on this line: https://github.com/jonathanslenders/python-prompt-toolkit/blob/master/prompt_toolkit/terminal/vt100_output.py#L121

Thanks much for communicating on this issue.
I now made a weired experience which shows that every color is kind of modified in a certain probably the same way. It's just that you see it more with some colors than with others. The color0 for base16-monokai is #272822. It's the background color which you see in the screenshot. When I use #272822 for some color in ´config.pythis should make the Token invisible because it has the same color as the background. However, it's becoming even darker than the background. When I set this token to#000000´ THEN it is rendered like the background which means rendered like #272822. I think during the generation process every color modified incorrectly in the same way not jus some.
For the purpose to exclude some config issues in my environment as much as possible I now also tried it with xterm + bash. The result is the same.

This sounds like a bug. I will try to find some time to reproduce and fix it. Thanks for the info!

Thx, for getting on this. In case you need more help from me please tell me.
By the way, this also happens with the syntax highlighting and the monokai theme provided by pygments: repl.use_code_colorscheme('monokai')

Hi @Cutuchiqueno,
Could it be that this is caused because we use the 256 color palette. Currently, we use the Terminal256Formatter from Pygments. (https://bitbucket.org/birkenfeld/pygments-main/src/cb583a0e37c776b77e3c49200c1658c920e9845a/pygments/formatters/terminal256.py?at=default&fileviewer=file-view-default#terminal256.py-82). This means that if a color does not exist on that palette, we will look for the closed matching color.
We could use true colors (24bit), but the difficulties are that not all terminals support that, and secondly, it will need more memory. If I figure out a good way to tell the renderer which color palette he needs to use, I could probably support true colors.
Jonathan

I added support for 24bit full color to prompt_toolkit and ptpython. I hope this works for you.
https://github.com/jonathanslenders/python-prompt-toolkit/commit/70855c996d66a196339b129520eff8c1200c2bec
https://github.com/jonathanslenders/ptpython/commit/94f6c9c48c9189177d50ba785faba9b6ca389d32
By default, 24bit colors are disabled. You can enable it from the menu. (Press CtrL after changing, in order to redraw everything.) Or change it from the configuration file.
https://github.com/jonathanslenders/ptpython/blob/94f6c9c48c9189177d50ba785faba9b6ca389d32/examples/ptpython_config/config.py#L100
Jonathan

Dear Jonathan,
thank you very much for this. It's true that it relates to the 24bit support. With this support activated the user interface is rendered correctly.  As hallI mentioned before I use the setting repl.use_code_colorscheme('monokai'). Thing is that the colors (which should be the same as the once I use for the user interface) are not only rendered in the same way as it was rendered without 24bit support (thus, mostly incorrectly) but that colors also match differently. For instance functions which were blue before are no white. Blue, Green and Red which are used when an error message is dropped are now incorrectly rendered but before they were rendered correctly.
Anyhow, I am really greatful, and maybe it's just changing some more options I was not aware about.


Enable running crossdock tests in travis

Coverage remained the same at 77.58% when pulling 6181c2e207a4dd80a71f602c9df910c4c4426733 on enable-crossdock-in-travis into cbd5d9221dd34fadcec2ca07bfb2e2ecf9f66f73 on master.


Missing turbolinks gem

Seems like the application js file is sourcing turbolinks, but the gem is missing from the Gemfile. (I didn't have the turbolinks gem installed before, since this is a new machine.) Adding gem "turbolinks" fixed it for me locally -- not sure if this is something needed in Suspenders.

Right. suspenders didn't include turbolinks for long (https://github.com/thoughtbot/suspenders/pull/225). @derekprior I know lately you've been using turbolinks with success. Should we revisit our stance on suspenders?

Thanks for reporting, Loren!


[enhancement] Option for Walled Templates to exclude "volume" of walled section from the template drawn.

This would be in order to facilitate spells like Fireball which RAW should wrap around corners.
I imagine an extra settings checkbox in the Item's details, alongside the Blocked by Walls already added.
In a way, an option to invert what happens to a walled template if you place it inside a fully enclosed/walled space 🤔
Does the request make sense and/or sound doable?
I could take a look at the code when I have time and check if I can make a PR for this too

I was discussing something similar with someone about the PF1e rule for spread. https://legacy.aonprd.com/corerulebook/magic.html#spread. I think something could be done by rerunning the sweep at wall corners. It is a bit tricky to pull off, but the idea is to figure out how much distance has been "spent" when the effect reaches a corner, then build a new shape using the remaining distance as the radius with the origin at the corner.
You would end up with a smaller template shape originating at each corner. This is a recursive approach that could work well with complicated wall setups, but would cost a bit of performance.
Relatedly, you could probably make rays bounce off walls using a similar approach.
I will be traveling and unable to look into this for awhile. Feel free to play with it on your own if you want; I will give it some thought and look into it when I get back.

Thanks for the info 👍
I will take a look after the weekend probably as I will be AFK

I started playing around with this a bit; you can see the code in the develop branch. I got a basic spread to work with a circle template. Doesn't really work with other templates at the moment. I also want to implement a "bounce" for rays and cones, which currently is WIP. The primary code is in getShape.js and ClockwiseSweepShape.js.
Single recursion:

Multiple recursions:

Got bounce to work, sort of. Cannot do recursions; something about the calc is off. But proof-of-concept!
I won't be able to work on this for about a month but will revisit later.

OK that looks sick!
I will take a look at the develop branch this coming week


Sprites using deleted image files are still visible in the editor until project is reopened

Godot version:
3.0.2.stable.official
OS/device including version:
Windows 10
Issue description:
When a sprite has its texture image file deleted, using either external file explorer or Godot's file manager, the sprite is still displayed as normal even though the resource image file no longer exists.
Sometimes even after closing and reopening the scene file it still shows the sprite's image.
However closing the whole project or quitting Godot and reopening the scene will trigger the popup for missing dependencies.
This is a problem because the editor view doesn't represent the reality that the image file is missing. You could look at a scene and everything looks ok, but the next time you open it up lots of images are missing because you messed something up and didn't know about it at the time.
This probably also applies to other resource types (not just Sprites and images).
Steps to reproduce:

Create a scene with a sprite.
Choose a texture image file for the sprite.
Delete the texture image file.
See that the sprite is still displayed as normal as if everything was ok
Close the scene and reopen it
See that everything opens fine. Sprite is displayed as normal as if everything was ok
Quit Godot and reopen the project and the scene
NOW see the missing dependency popup

Can anyone still reproduce this bug in Godot 3.2.1 or 3.2.2beta4?

Closing due to lack of response. Please comment if you can still reproduce this bug.
PS: If no minimal reproduction project was included in the original bug report, please upload one as well to ease troubleshooting.


Batch processing with re-submit when validation errors

I have a complex input file of semi structured data that I want to re-structure using instructor. It does a great job with the direct chat completion calls, returning my Parsed Pydantic model just fine.
But when I create a BatchJob, it seems that it simply runs one job and let Pydantic model validate the model and just returns the failed instances, but does not attempt to re-ask the job, sending it back as another job.
Are there any plans to implement re-ask mechanisms for batch jobs? Batch jobs are soo much faster and cheaper for me, but the pydantic validation errors are holding me back...
Maybe someone has some hints for me on re-using some of the code already used for the regular chat completion?

how would that work, 30 out of 500 fail, do you want us to then make 30 more requests when you load and notice they failed? 30 requests now, or submit a second batch job?

Yup, exactly how I have implemented it now myself. I collect the invalid lines from the BatchJob and re-submit those until they work (or when max-try is exhaustive.


Pausing the consumer doesn't work in 2.x versions as before

Describe the bug
Calling consumer.pause inside eachMessage or eachBatch and breaking the consumption flow, does not pause the consumption from a given topic-partition. The same message batch is received again, however, the consumption from that topic-partition is paused.
To Reproduce

Create a new consumer instance.
Connect and subscribe to a given topic.
Create a handler function that pauses consumption from the received topic-partition, sets a timer for the consumption, and throws an error.
Register a runner with the created handler function.
The paused topic-partitions are ignored and messages are still received

  await consumer.connect();
  await consumer.subscribe({ topic });

  await consumer.run({ eachMessage: async ({ topic, partition, message }) => {
      try {
        doWork(message);
      } catch (e) {
        consumer.pause([{ topic, partitions: [partition] }])
        setTimeout(() => consumer.resume([{ topic, partitions: [partition] }]), 1000)

        throw e
      }
  }})

Expected behavior
When pausing consumption from a particular topic-partition and breaking the consumer (throwing an error inside eachMessage, eachBatch), the consumer should not receive messages from that topic-partition, until it's resumed.
Observed behavior
When pausing consumption from a particular topic-partition and breaking the consumer (throwing an error inside eachMessage, eachBatch), the consumer receives the same message batch even if the consumption is not resumed for that topic-partition.
Environment:

OS: [e.g. Windows 10]
KafkaJS version [e.g. 2.0.0] (It works with version 1.4.0)
NodeJS version [e.g. 14.16.0]

Additional context:
I did some research. As I can see in the fetch phase the topic-partitions are filtered from where the messages should be fetched, and then the processing phase begins.
Before 2.0.0 both phases were wrapped inside a retry strategy. After 2.0.0 only the message processing phase is wrapped inside a retry strategy, and because of that on a retry, the active partitions are not checked.

This has been released as part of 2.1.0. Thank you for your contribution! ⭐


RNG schema is incorrect for a valid RNG schema in Oxygen

Hello, I use regularly Scholarly XML for TEI and never met this problem before : I try to valid my file with a RNG schema that is valid in Oxygen, and the association does not work in VSCode, the error message "RNG schema is incorrect" appears, with mention "could not parse schema".
The schema is valid in Oxygen validator, so it means that there is something that trigger Scholarly XML validation and that is not related to RNG syntax. Is there any internal constraint that could explain this behaviour ?

Could you share your schema and XML please.

schema_validation_truble.zip
hello, sorry I did'nt find your answer till today. Here are the files we have worked with in June.


Update to support Smash 13.0

See smash 12.0 porting for context: https://github.com/jam1garner/smash-minecraft-skins/commit/88e9d299851a4c38db9ef9310dc2c933b467307e
should just require a single offset update. I haven't dumped version 13.0 myself, so I'm not planning on updating this personally. Will accept PRs if anyone grabs the updated offset.

Fixed (cc @GlossyCoin15 )
https://github.com/jam1garner/smash-minecraft-skins/releases/tag/v1.2.3


Add CI workflow for Github Actions

This pull request adds a CI workflow with Github Actions. Tests pass in my fork (see here). I think it is ready for merging.
I will create a separate pull-request to remove travis and add a Github Actions badge in the README that can be merged when Github Actions performs satisfactory.

Very happy with this PR and happy to merge your first contribution in this project.


Upgrade to Babel6

This is my attempt to fix this issue on https://github.com/facebook/react-native/issues/4674.
Upgraded to babel6 builds and tests run successfully.

i'm on it

You should update package.json and .babelrc in all examples too to make build passed

boris, yeah I realize now. May take a little time. There is also the babel-polyfill issue

todos reducer
    ✓ should handle initial state
    ✓ should handle ADD_TODO
    ✓ should handle DELETE_TODO
    ✓ should handle EDIT_TODO
    ✓ should handle COMPLETE_TODO
    ✓ should handle COMPLETE_ALL
    ✓ should handle CLEAR_COMPLETED
    1) should not generate duplicate ids after CLEAR_COMPLETED

  49 passing (99ms)
  1 failing

  1) todos reducer should not generate duplicate ids after CLEAR_COMPLETED:

      Error: Expected [ { completed: false, id: 2, text: 'Write more tests' }, { completed: false, id: 1, text: 'Write tests' } ] to equal [ { completed: false, id: 2, text: 'Write more tests' }, { completed: false, id: 1, text: 'Write tests' } ]
      + expected - actual

      at Object.assert [as default] (node_modules/expect/lib/assert.js:20:9)
      at Expectation.toEqual (node_modules/expect/lib/Expectation.js:69:26)
      at Context.<anonymous> (todos.spec.js:273:7)

I am not sure that this test would pass if i didn't update babel.

So all the builds pass. it seems that the example's tests are failing. This appears to be a problem that is currently merged into master.

Here is a build of master and it is failing: https://travis-ci.org/rackt/redux/jobs/96114270

is this something that I need to fix before this PR is accepted? Personally, I think that test is unnecessary since normally an application like that would be storing data on a DB that has auto-increment.

I think the build is failing due to one of our testing dependencies. It's been reported and they are looking into it.

https://github.com/rackt/redux/blob/master/examples/todomvc/test/reducers/todos.spec.js#L250-L285
This is what failing for me.

Yep, thats the one. This should start passing again without any changes needed on our end when the dependency is fixed (which seems like it is going to be soon).

:rocket:

would like to get this merged too:
https://github.com/rackt/react-redux/pull/212/commits

@gaearon Is there any reason I should hold off on this? I will have some time to test it out over the weekend.

Proceed by all means!

@gaearon When you get a moment...
I am hoping to get Redux, React-Redux and Redux-Devtools ready to go at the same time. These PRs constitute a breaking change I think, so with regards to versioning...

Redux: Should be v5.0.0
React-Redux: Again v5.0.0, but what about the React Native people stuck with the v3.0.0 branch? It would be nice to release a fix for them but how do we version it?
Redux-Devtools: Another beta? A v3 release candidate? v3 proper?

What's a breaking change? Version of Babel we use internally shouldn't matter.

Ah ok, I think I've got it now. I assumed from the original comment that this PR is necessary to fix the issue with React Native 0.16 (which did seem weird), but it seems like that is not the case—if we simply remove the .babelrc from the current npm package it will build with Babel 5 or 6. That has already been done and will be going out in the next release, so we won't be breaking anyone who is still using Babel 5.
So everything is fine, and I can stop worrying.

Yep! I just released<EMAIL_ADDRESS>without .babelrc and will do the same for react-redux (3.x and 4.x). Though if you could take a look at updating the README for DevTools v3 so we could release it, that would be swell.

Cool, sounds good.

Couldn't hurt to upgrade to Babel 6 anyways yeah?

Sure.

@pr1ntr Just went through all the examples and its mostly looking good!
The Universal example is broken. Babel 5 is in the dependencies and babel/register is being required in server/index.js, but I've not looked into it any further than that.
Also, isparta needs to be upgraded to v4.0.0 in the main package.json so the test coverage still works.

regarding the universal example. I couldn't get that to work with Babel 5 or 6. Are you sure its working on the main branch?

i updated isparta, and i got universal running. One thing about universal however is that the webpack config doesn't use HMR when running from the repo (../../src exists) I did my best to set it up with babel6 the same way it was with babel5. Let me know if its still not right.

:+1: for merge.

@pr1ntr Thanks for updating. I'm super busy, so I don't have any time to look at this right now. I'll have some spare time at the start of next week, so if no-one beats me to it I'll look to get it merged then.

no problemo!

fixed whitespace

Note: please don't merge this yet.
We're having some problems with Babel behavior: it no longer includes ES3 transforms necessary for IE8 by default, and there seems to be a bug with those transforms which breaks them anyway.
Because of this we can't ship Redux that uses Babel 6 internally until either

that bug is fixed and we add ES3 transforms to the pipeline
or we increment major and tell consumers to ES3ify code on their end

The examples still use babel5 also. I really like these as "boilerplate" but I always have to manually update babel dependencies --> Can we update the examples and leave only main redux with babel5?

I really like these as "boilerplate" but I always have to manually update babel dependencies

The examples were never meant as a boilerplate. They are meant as Redux usage examples. I understand people will use them as boilerplate but this is a shame because they lack important aspects such as compiling for production. Having two different Babel versions in one repo would be confusing.

This is now in. Thanks again!


fixing typo in Readme

Signed-off-by:  mhmohona<EMAIL_ADDRESS>
Kind
/kind documentation

looks good to me. could you DCO sign the commits? You will have change the commit message of your previous commits and then force-push to this PR.


Fix Object#def_hash when passing Symbols

When passing Symbol to Object#def_hash macro it'll hash that instead of resolving it, this PR fixes this behaviour.
Relevant spec - https://carc.in/#/r/4q0k

Why don't you include that spec in the PR?


add ncaq packages: haskell-import-graph uniq-deep

Oh, I forgot setup stack for haskell-import-graph.
I fixed this bug.
I close this PR, and open new PR.


Prepare comments in literate programming style in script checks/json_check.py

Prepare comments in literate programming style in script checks/json_check.py

Added via https://github.com/RedHatInsights/insights-results-aggregator-utils/commit/6e412af666195ca09fe90f7a0c811ba5c3ee27b4


Feature php 8 support

@CasperLaiTW
Sorry. I've somehow messed something up with your permission. I've sent you an admin invite again.
I've also updated PHP 8.0 support.
Cheers
Sebastian

Codecov Report

Merging #22 (48717a8) into master (0950f57) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #22   +/-   ##
=========================================
  Coverage     81.60%   81.60%
  Complexity       38       38
=========================================
  Files             2        2
  Lines            87       87
=========================================
  Hits             71       71
  Misses           16       16

Flag
Coverage Δ
Complexity Δ

L6
81.60% <ø> (ø)
0.00 <ø> (ø)

L7
81.60% <ø> (ø)
0.00 <ø> (ø)

L8
81.60% <ø> (ø)
0.00 <ø> (ø)

P7.2
81.60% <ø> (ø)
0.00 <ø> (ø)

P7.3
81.60% <ø> (ø)
0.00 <ø> (ø)

P7.4
81.60% <ø> (ø)
0.00 <ø> (ø)

prefer-lowest
81.60% <ø> (ø)
0.00 <ø> (ø)

prefer-stable
81.60% <ø> (ø)
0.00 <ø> (ø)

ubuntu-latest
81.60% <ø> (ø)
0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0950f57...dfb585f. Read the comment docs.

easy!


cannot use these steps if using SharedRuntime?

[Enter feedback here]
These steps do not work to test our add-in on old versions of Office for IE 11 / Legacy Edge support as our add-in uses SharedRuntime and these versions of Office do not support it. So we cannot install our add-in on these old versions.
Is there any other set of steps to make this easier to test? Otherwise it seems we need to have a perpetual use version of Office 2019 that supports both IE 11 and SharedRuntime?
Not sure what to do here....

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 47b7b417-12e6-193f-6b89-37e088b31dbc
Version Independent ID: df705bd2-5f2f-2c84-0519-fca9a3c45d71
Content: Internet Explorer 11 testing - Office Add-ins
Content Source: docs/testing/ie-11-testing.md
Product: non-product-specific
Technology: add-ins
GitHub Login: @o365devx
Microsoft Alias: o365devx

The information I have gotten internally is that AppSource should not be testing your add-in on versions <16.0.11629. I see that you have created a ticket with them. So, I'll close this issue for now, but you can still add comments to it and, if needed, ask that it be reopened.


Persist a completed wf after resuming fails

Due to changes made during last couple of months. Prior to that, it used to work. The PersistableIdle fails if returns PersistableIdleAction.Persist when reaching end of flow.

A PR is welcome. With a fix or at least a failing test. The existing tests pass.

@zehavibarak Can you give a bit more detail?
I think i ran into the same issue.
A stack trace / exception etc. would be really helpful.

@LunicLynx think the issue was you have to manually call workflowApplication Unload() in order to the store to persist - or call Persist() returning PersistableIdleAction.None on PersistableIdle.


change limit to 1-5

calculation matrix should not be 0

We might as well update the implementation in alternatives and criterias components to create a new array with 1 as default value


feat(iam-policy): add CreateDate property

Implements https://github.com/rebuy-de/aws-nuke/pull/1095

:tada: This PR is included in version 3.23.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add code of conduct

This pull request introduces a Code of Conduct (CODE_OF_CONDUCT.md) to the repository. The purpose of this addition is to establish clear guidelines for expected behavior and interactions within the community, promoting a welcoming and inclusive environment for all contributors.
Closes  #11   — this pull request resolves the issue for adding a Code of Conduct to the repository.

Sorry but cannot merge changes,, too many commits.
I can see that only the last commit contains relevant changes.
I am closing this PR , you can create new one with only  required changes/commits.
You can cherry pick commits from this branch to the new one which you will use for new PR.
If you want to learn more about cherry-picking refer this:
https://www.atlassian.com/git/tutorials/cherry-pick


Load Docker image from Azure Container Registry

Good morning,
hopefully it's ok to ask for help here, because I struggle with getting my idea to run.
I have a docker image stored and build in the azurecr.io container registry and I want to use this image with testcontainers to test my application.
This means that my test should look up for the newest version of the image, download it if a newer version is available and use it for my test.
But I try to manage this since three days and can't make it.
I also did a huge google research and read a lot of already existing issues in this project, but nothing really fitted to my problem.
Can anybody please give me a hint or example code, how I can get this running?
I tried to use GenericContainer, RemoteDockerImage, FixedHostPortGenericContainer and so on, but nothing worked for me.
A big sorry if this is the wrong place to ask for help, but I don't know what to do otherwise.

Hi @aTTraX, it should be pretty simple:
new GenericContainer("yourregistry.azurecr.io/yourimage:yourtag")

You'll need to be logged in to the registry for authentication, but Testcontainers/docker-java should pick up your local auth details and use those.
You could use a latest tag to get the latest version, but:

we generally discourage that, as it makes the tests less repeatable
you may notice that the image is cached

In general, it's always better to modify the tag name that you give to Testcontainers whenever a newer version is available (i.e. change the string). Unfortunately we don't have anything right now to help with that, but it's something I'd like to implement some time.
For now, could you try using the latest tag and see if that works well enough for you?

Hi @rnorth,
thank you for the quick response.
I tried this already many times, but I always get huge Exceptions.
Maybe my system configuration is wrong or something.
Thanks anyway

I finally made it, but I don't know why at the moment. Probably cause of authorization.
Thanks anyway


[BUG] onOff Switch disappeared

As you can see in the screenshot, the on/off button disappeared in the latest Chrome Canary. It seems it has to do with this error message:
Uncaught TypeError: document.registerElement is not a function
    at onOffSwitch.js:8
    at onOffSwitch.js:37

https://github.com/kylepaulsen/ResourceOverride/blob/master/src/ui/onOffSwitch.js#L8
I don't really know about this API, but it seems it's deprecated and should be replace with this: https://developer.mozilla.org/en-US/docs/Web/API/CustomElementRegistry/define

Thank you for reporting this. I went ahead and published a fix plus some other changes I had on hand. Not sure when it will go live in the store.
I would greatly appreciate any other bug reports after the new version is live ( v1.1.0 ).

Ah yes, I see the button is back.
Awesome and thanks for the quick work. With some investigation, I might have been able to fix it myself, but this is surely better.
I quite like your extension and would have been sad, if it would have stayed unusable. :)


seaborn is not importing

import seaborn as sns
no module named as seaborn
/
this error even after installing in conda install seaborn
can anybody fix this

You can try installing seaborn library in your python script using following code:
import conda.cli
conda.cli.main('conda', 'install',  '-y', 'seaborn')
You can also do it by using pip but ensure that the version of pip is not 10.0.0 as the new version doesn't support pip.main() any more.For installing seaborn library using pip you can write the following code in your python script.
import pip
pip.main(['install','seaborn'])
One more thing for installing seaborn library it is a mandatory requirement that numpy,pandas,matplotlib and scipy libraries are already installed in your computer.
You can also check following link for more information
https://seaborn.pydata.org/installing.html

run on jupyter notebook !pip install seaborn  or !pip3 install seaborn (if you use python3.X)


entering code and run in the interactive window is extremely slow

Version: 2020.1.58038 (13 January 2020)
I have a dataframe with shape of (810103, 26). If I type code and run a cell from the editor, everything is fine. But it will be extremely slow if I run code from the interactive window directly such as df.head(), df.columns. I can even make a screenshot without shortcut😂

Hi, @rchiodo. just wondering... will this be fixed any time soon?

Not likely. We have no idea what causes it. It's jupyter that's taking all the time (not our code), so we'd have to debug the jupyter kernel.

@rchiodo I don't know what the advantage of this jupyter kernel thing but it adds some env I don't want:

I feel like I prefer the old extension approach better.

Those two new 'kernels' represent the environment you're running your python code in. They are an exact match for an environment generated by conda.
The advantage is that they will load all of the same packages that the associated conda environment loads.
There is no disadvantage other than they are listed there. They have nothing to do with the slowdown you're seeing.
The slowdown is in the IPython code itself (which is what I meant by we had to debug the jupyter kernel). The slowdown is not in the code we ship with the ms-python extension.

@rchiodo any process on this buddy? This happens so frequently and even with small datasets from time to time.

Do you have the variables list open when this issue occurs?

not at all I never used that thing

Sorry but we are not actively investigating this. I believe this is an issue in the IPython code itself and not our own. We don't do anything special to send code to the kernel.

Could you guys please take a look. This is so weird and really interrupt my workflow.

I have noticed if I interrupt the kernel when this is taking a long time it comes back immediately. At least for df.head()

Some of the advice here seems to alleviate the problem:
https://github.com/jupyter/notebook/issues/3224
I typed this in to the interactive window:
%config Completer.use_jedi = False

and now it responds immediately. At least with the csv you mentioned above.

That config line causes Jupyter to stop giving us autocomplete information. So you won't get column names with autocomplete anymore, but that's probably worth it for the speedup

I don't even use Jedi but only Microsoft language server

This setting is not for us. It's for jupyter. They use jedi as well for autocomplete.

If I encounter this issue and try to Interrupt the kernel, the kernel will be forced to restart.
This is really annoying since sometimes it will take a long time to clean some data and you have to re-run everything.

So you're saying the config setting doesn't work?
%config Completer.use_jedi = False

And interrupting the kernel doesn't always reset the kernel. Depends upon the thing being interrupted.

So you're saying the config setting doesn't work?

I'm a little bit confused about it. Should I set use_jedi to False? Because based on your comments, it seems like you later found an issue with it. Is there any side effects of it?

And interrupting the kernel doesn't always reset the kernel. Depends upon the thing being interrupted.

This is why I don't expect to restart the kernel and now it always does.

Did you mean this comment?

That config line causes Jupyter to stop giving us autocomplete information. So you won't get column names with autocomplete anymore, but that's probably worth it for the speedup

I take that back, it still seems to work. Not sure what the turning off of Jedi does then.

Sorry that was confusing.
I was worried turning of jedi support in jupyter would prevent jupyter from returning autocompletions, but it does not.
%config Completer.use_jedi = False

So I don't see any side effects to this setting:

But this will turn off all the autocompletion while I enter code in the interactive window right?

No. It doesn't. That's why I said this:

I was worried turning of jedi support in jupyter would prevent jupyter from returning autocompletions, but it does not.

After changing that setting I was still able to get column names from panda dataframes. This data is not provided the python extension and explicitly comes from jupyter. So Jupyter still seems to provide autocomplete data even after its jedi usage is turned off.

You should be able to put this in your startup commands:

Finally had a chance to profile the IPython kernel. The autocomplete from typing is hanging the kernel and preventing the execution of a cell. We should be able to fix this by interrupting the kernel if it's in the middle of autocompletion.


Argoverse v1 and / or v2

I was looking for Argoverse dataset support in the README, but didn't find it.
Is it supported or planned in a future version?

@Leon0402 I figured I should ping someone, notifications don't always get through.

Hi, I saw your issue before as I enabled notifications for the whole repo (I assume @BorisIvanovic has them enabled automatically as the owner of this repo, but pinging him might help sometimes. But you be a little bit more patient than a day. I think he is a little bit busy right now with releasing a new paper).
I'm not owner or part of the team behind trajdata, I just contributed a few patches / issues, so I'm not the correct one to answer your question. I don't know if support is planned (It's not supported yet as far as I can tell).
Having said that implementing it yourself is always an option. I wrote support for another dataset, which is only for my company though and therefore I didn't upstream it. If you're willing to put time and effort in this yourself, I can support you with some instructions regarding the trajdata side. I cannot (!) help you with Argoverse though. I never used it and I don't have time to invest it.
How much effort this really is depends on argoverse. Basically you would need to convert agent data and map data in a specific format. This can be challanging or easy depending on the original format of argoverse and the provided apis.
Argoverse seems like a more complex dataset (like nuScenes), but also offers an api. Some examples for the map can be found here: https://github.com/argoai/argoverse-api/blob/master/demo_usage/argoverse_map_tutorial.ipyn
So it should probably be not too hard depending on your knowledge of the dataset, python, trajectory prediction and general.
Let me know if you want to go down that road then I can give you some instructions on how to do it.

Hey @Leon0402 thanks for the swift reply!
OK, I understand the situation, thanks for a detailed intro!
Regarding Argoverse v1 -- I started working with it and its API a month ago and I feel sufficiently comfortable to be able to answer which map features required by trajdata are going to be difficult to produce, and which are going to be easy. I just need to familiarize myself with trajdata.
But I wouldn't want to duplicate work that is (potentially) already been done. If @BorisIvanovic (or anyone) could give me a green light or any other indication that it might make sense for me to add this feature, I can start working on it.

Hi @MTDzi ! Thanks for the question, and for your interest! I actually plan to release a pretty big update to trajdata soon (e.g., sometime next week, after the ICRA deadline :stuck_out_tongue: ). One of the updates will be the use of a canonical map format internally (so that different datasets don't have such a disparity when it comes to things like maps), as well as general speedups and other features.
If you're interested in contributing Argoverse back to trajdata, I'd be happy to review your pull request and green-light such a merge, but if I were you I would personally wait to start doing this until next week after I update trajdata. How does that sound?
Also, I wasn't personally planning on supporting Argoverse, so it would be a definite positive if you were to do that!

Ah, awesome, thanks for the heads up!
Yes, I'd be very much interested in contributing the Argoverse dataloader (or loaders), and I agree that it makes more sense for me to wait if there's a large update incoming soon.
In the meantime, I'll familiarize myself with the nuScenes dataset and identify key differences with Argoverse.
In particular, I'll need to sort out if the overlap between these two datasets even justifies having a common format. You might already have some thoughts on this, but I don't want to take up much more of your time. I'll post any updates I might have here, in this issue.
Good luck with the ICRA submissions!

The new update (v1.0.7) has been released!

Awesome!
And thanks for letting me know.


tests fail inside nginx template folder

I am getting this output when running the tests inside of ingress/controllers/nginx/pkg/template
$ go test -v
# ingress/controllers/nginx/pkg/template
./template.go:278: backend.SessionAffinity.CookieSessionAffinity.Locations undefined (type ingress.CookieSessionAffinity has no field or method Locations)
./template.go:431: backend.SessionAffinity.CookieSessionAffinity.Locations undefined (type ingress.CookieSessionAffinity has no field or method Locations)
FAIL	projects/ingress/controllers/nginx/pkg/template [build failed]

@RemingtonReackhof I cannot reproduce from current master
aledbf@me:~/go/src/k8s.io/ingress$ cd controllers/nginx/pkg/template
aledbf@me:~/go/src/k8s.io/ingress/controllers/nginx/pkg/template$ go test -v
=== RUN   TestFilterErrors
--- PASS: TestFilterErrors (0.00s)
=== RUN   TestMergeConfigMapToStruct
--- PASS: TestMergeConfigMapToStruct (0.00s)
=== RUN   TestDefaultLoadBalance
--- PASS: TestDefaultLoadBalance (0.00s)
=== RUN   TestFormatIP
--- PASS: TestFormatIP (0.00s)
=== RUN   TestBuildLocation
--- PASS: TestBuildLocation (0.00s)
=== RUN   TestBuildProxyPass
--- PASS: TestBuildProxyPass (0.00s)
=== RUN   TestBuildAuthResponseHeaders
--- PASS: TestBuildAuthResponseHeaders (0.00s)
=== RUN   TestTemplateWithData
--- PASS: TestTemplateWithData (0.09s)
=== RUN   TestBuildDenyVariable
--- PASS: TestBuildDenyVariable (0.00s)
PASS
ok  	k8s.io/ingress/controllers/nginx/pkg/template	0.145s
aledbf@me:~/go/src/k8s.io/ingress/controllers/nginx/pkg/template$ git log
commit 05e460012d967c84a62123219b027da6c67c1570
Merge: 1468fcb1 5f028586
Author: Manuel Alejandro de Brito Fontes<EMAIL_ADDRESS>Date:   Tue Jun 27 12:43:59 2017 -0400

    Merge pull request #911 from aledbf/fix-forwarder-host

    Improve X-Forwarded-Host support

My apologies, I was running the project in a different source directory. It works as expected.


(maint) - Update Hiera Example

Update the woefully outdated hiera example noted in https://github.com/puppetlabs/puppet/issues/9340

This is great, thanks @garrettrowell!


Fix tag detection issue for image replacement in k8s-deploy

This is the fix for the issue https://github.com/Azure/k8s-deploy/issues

Raised a PR for handling different issues related to the replacement logic here #13


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_343z_o79wq/clone/recipe/meta.yaml:14: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_343z_o79wq/clone/recipe/meta.yaml:19: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_343z_o79wq/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_343z_o79wq/clone/recipe/meta.yaml:39: missing_documentation: The recipe is missing a doc_url or doc_source_url
ERROR: /tmp/abs_343z_o79wq/clone/recipe/meta.yaml:39: missing_dev_url: The recipe is missing a dev_url
ERROR: /tmp/abs_343z_o79wq/clone/recipe/meta.yaml:39: missing_license_family: The recipe is missing the about/license_family key.
WARNING: /tmp/abs_343z_o79wq/clone/recipe/meta.yaml:39: missing_description: The recipe is missing a description
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_134sgbmi7_/clone/recipe/meta.yaml:14: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_134sgbmi7_/clone/recipe/meta.yaml:19: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_134sgbmi7_/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_134sgbmi7_/clone/recipe/meta.yaml:39: missing_documentation: The recipe is missing a doc_url or doc_source_url
WARNING: /tmp/abs_134sgbmi7_/clone/recipe/meta.yaml:39: missing_description: The recipe is missing a description
ERROR: /tmp/abs_134sgbmi7_/clone/recipe/meta.yaml:39: missing_dev_url: The recipe is missing a dev_url
ERROR: /tmp/abs_134sgbmi7_/clone/recipe/meta.yaml:39: missing_license_family: The recipe is missing the about/license_family key.
Errors were found


Use yt-dlp instead of youtube-dl

youtube-dl is so slow, so it's better to use yt-dlp, which is much faster.

was implemented in https://github.com/SinusBot/docker/commit/48ad92aaffd8d4dce613adf5dc0a5bcffab9cdcb.


Suppress the error from unsupported anki-connect storeMediaFile method

Using the latest release of yomitan generates an AnkiConnect method storeMediaFile. Returning an error would cause annoying error messages to be emitted in the extension UI, even though the vocab is successfully mined to jpdb. This pretends that the operation completed successfully even though no media is uploaded to jpdb.

Hmm I can't reproduce the problem on master with yomitan <IP_ADDRESS> and jmdict
Not sure what causes yomitan to send that request

https://github.com/themoeway/yomitan/blob/5e429508e6837d04ae99b3429976a3bd7ef0331e/ext/js/background/backend.js
storeMediaFile is called for images in dictionaries, audio, browser screenshots, and clipboard images.


Fix Typo

Codecov Report

Merging #185 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #185   +/-   ##
=======================================
  Coverage   86.97%   86.97%
=======================================
  Files           6        6
  Lines         192      192
=======================================
  Hits          167      167
  Misses         19       19
  Partials        6        6

Impacted Files
Coverage Δ

negroni.go
92.98% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b14679c...1c64e7d. Read the comment docs.


Allow 'final' for implementations, fields and params

Let's allow the final keyword for implementations, fields and params, even though that's the default behaviour. Many devs will write it out of habit and it is annoying to get a compilation error because of it.
The transpiler/compiler should show a warning stating that it's useless to have it, similar to abstract in the case of an interface.

@amihaiemil this is your task now, please go ahead. Deadline (when this ticket should be closed) is 2023-06-28T15:19:52.605792.
Estimation here is 60 minutes, that's how much you will be paid.
Remember, you don't have to solve everything in this ticket - you can solve it partially and leave todo markers in the code, which will become future tasks.
If you have any questions don't ask me, I'm not a technical person. Open new tickets instead.
If you don't have time or simply don't want to work on this, you can always resign.

@amihaiemil please keep in mind that manual assignment of tickets is a bad practice and it is discouraged. Next time, please let me elect the assignee.


Building on Windows 10 procedure

I had to change the process as described in the Readme as follows:
installed Miniconda3 in ~/Miniconda3/
Started git bash:
Ran
~/Miniconda3/Scripts/conda.exe update -n base conda
~/Miniconda3/Scripts/conda config --add channels conda-forge
~/Miniconda3/Scripts/conda install -y cmake flang clangdev perl
~/Miniconda3/Scripts/conda install -y -c isuruf kitware-ninja

Ran
/c/Program\ Files\ \(x86\)/Microsoft\ Visual\ Studio/2017/Community/VC/Auxiliary/Build/vcvars64.bat

Then
export LIB=~/Miniconda3/Library/lib
export CPATH=~/Miniconda3/Library/include

Finally
cmake ..
cmake --build . --config Release

This successfully built libraries in ~/OpenBLAS\build\lib\RELEASE.
The procedure described in the Readme file failed. In particular this command failed:
cmake .. -G "Ninja" -DCMAKE_CXX_COMPILER=clang-cl -DCMAKE_C_COMPILER=clang-cl -DCMAKE_Fortran_COMPILER=flang -DBUILD_WITHOUT_LAPACK=no -DNOFORTRAN=0 -DDYNAMIC_ARCH=ON -DCMAKE_BUILD_TYPE=Release

Ninja was not found.

If I understand you correctly, the execution of vcvars64.bat would appear to replace the somewhat unclear step 5. in the wiki ?
Activate the MSVC environment for 64 bits with vcvarsall x64.
Search on the web for the particular steps for your version of MSVC

In view of issue #1424 it is good to know that building with VS2017 can actually work.

Yes. What I described worked.

@PetrKryslUCSD, can you send me the output of the cmake command?

@isuruf, any idea what happened here w.r.t the extremely stealthy ninja ?

ninja.exe might not have been on the PATH.


Setup benchmarks between Spack, ESBuild

Consider setting up a benchmark between Spack and ESBuild

I looked into this briefly but I can't get it to run. Here's what I tried:
$ npm install @swc/core @swc/cli
$ npx spack
Bus error: 10

This is on macOS 10.14.6. Am I doing this right?

@evanw I think it's related with #872.

As seen in the minification benchmark here SWC is slow compared to ESBuild

As seen in the minification benchmark here SWC is slow compared to ESBuild

@kaushalyap swc does not do minification at the moment. The only minification is skipping comments and some whitespaces.
But I'm sure they are running transforms unrelated to minification because there's no option to disable transforms :)

@kaushalyap swc does not do minification at the moment. The only minification is skipping comments and some whitespaces.
But I'm sure they are running transforms unrelated to minification because there's no option to disable transforms :)

Sibling issue at https://github.com/evanw/esbuild/issues/762


Updated Travis CI link in README

Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement and we don't seem to have CLAs on file for these contributors to the Pull Request: (@maoo). In order for your PR to be reviewed and merged, please follow the directions at the link above.
Project team: please do not merge this Pull Request until Foundation staff have confirmed that a CLA is in place for the new contributor(s) listed above.
If there are any questions, please don't hesitate to get in touch with our Infrastructure Support team. /CC @finos/finos-staff

@finos-cla-bot[bot] check

The cla-bot has been summoned, and re-checked this pull request!

@finos-cla-bot[bot] check

Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement and we don't seem to have CLAs on file for these contributors to the Pull Request: (@maoo). In order for your PR to be reviewed and merged, please follow the directions at the link above.
Project team: please do not merge this Pull Request until Foundation staff have confirmed that a CLA is in place for the new contributor(s) listed above.
If there are any questions, please don't hesitate to get in touch with our Infrastructure Support team. /CC @finos/finos-staff

The cla-bot has been summoned, and re-checked this pull request!

@finos-cla-bot[bot] check

@finos-cla-bot[bot] check

Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement and we don't seem to have CLAs on file for these contributors to the Pull Request: (@maoo). In order for your PR to be reviewed and merged, please follow the directions at the link above.
Project team: please do not merge this Pull Request until Foundation staff have confirmed that a CLA is in place for the new contributor(s) listed above.
If there are any questions, please don't hesitate to get in touch with our Infrastructure Support team. /CC @finos-admin

The cla-bot has been summoned, and re-checked this pull request!

@pmonks @copiesofcopies - above is a test of failed PR submission due to CLA violations. I'm going to replicate this configuration across all our GitHub Program-specific orgs.
Feel free to remove this PR after you review.

Is there any way to improve the formatting of the error page linked to by the "Details" link next to verification/cla-signed?

@finos-cla-bot[bot] check

The cla-bot has been summoned, and re-checked this pull request!

@copiesofcopies - logs improved! https://x0s3qmmi81.execute-api.us-east-1.amazonaws.com/logs?correlationKey=a206c985-7872-4b9c-a552-5283c8c86fa5
You like it?


update this program

it hasnt been updated since 2016

Thank you for your interest. Out of curiosity, what are you using this tool for? What exactly would you like to see in an updated version?

I would like to see the abillity to export and replace stuff in pri files, also it looks like the program does not work well with newer pri files

Export should be possible today by right-clicking on a resource candidate in PRIExplorer and clicking "Save as...". Editing/saving of PRI files is indeed not supported at the moment.

also it looks like the program does not work well with newer pri files

Do you have some sample files that demonstrate the problem? Will these files not open at all or is there a problem with some resources inside the file? Do you maybe refer to decompilation of XBF files inside PRI files?

Microsoft.Windows.FileExplorer_cw5n1h2txyewy.zip
some resources have only the name and nothing in them (idk if this is supposed to happen) and for the decomplication of xbf files it shows an error

Thanks!

some resources have only the name and nothing in them (idk if this is supposed to happen)

I think this is not a bug. In your example, the main resources.pri contains just an index of localized resources while the actual (language-specific) values are contained in pris\resources.en-US.pri.

the decomplication of xbf files it shows an error

Yes, the XBF2 decompiler which I took from https://github.com/misenhower/XbfAnalyzer seems to have issues with newer XBF files.

I have pushed a number of changes that should fix the XBF2 decompilation issues for most files. There are still some issues remaining for more exotic files but those should be rare.

the xbf decompiler doesn't show anything

I think you are referring to the XbfAnalyzer application? That is primarily meant as a development tool for analzing the XBF file structure, therefore it lacks a proper UI. Files need to be dragged and dropped onto the application window to load them.
The functionality of XbfAnalyzer is integrated in PRIExplorer. In case you are seeing no output in PRIExplorer, can you share the specific files where you are seeing this problem?

I don't see any output in the xbf analyzer. does it show anything for you?

calc.zip

Thanks for sharing the file and screenshot. The behavior you see on the screenshot is most certainly not a bug. Sometimes PRI files only contain a "table of contents" but not the actual resources. I've seen this most often with PRI files containing localized resources. You likely opened a file like resources.en-US.pri. Try opening the corresponding resources.pri which should contain all non-localized resources, including app.xbf.
Regarding the calculator sample you shared: some of the XBF files in there still lead to decompilation issues. Those are a known limitation at the moment.

I tried it again and it works, it can decompile some xbf but some others it can't
you show add the ability to set resource root path when no pri files are loaded(the button is greyed out when no pri files are loaded), maybe also publish a new release on the github repo as well.
and if you want to, you can add editing functions.


Authentication for AWS

We need to setup AWS authentication. I could use some help determining how to map the following gcloud cli functions to AWS:
gcloud auth activate-service-account --key-file ${KEY_FILE}
gcloud auth configure-docker
gcloud container clusters --zone=${zone} --project=${project} get-credentials ${cluster}

cc @apawloski, @amanda-tan, @jonahjoughin

The two things that need to happen here are:

Authenticate to ECR to push images.
Authenticate to kubernetes

2 probably differs based on how your cluster is set up. You might just have a generic KubeConfig file you can put in secrets/, in which case you should have a pointer in hubploy to that instead of anything AWS specific.

2 probably differs based on how your cluster is set up. You might just have a generic KubeConfig file you can put in secrets/, in which case you should have a pointer in hubploy to that instead of anything AWS specific.

This is how @dsludwig setup https://github.com/dsludwig/aws.pangeo.io-deploy, we could certainly go that route.

@apawloski - do you want to pick this back up or should we pass it off to someone else?

Made some progress and we're getting further, but looks like the permissions aren't being picked up or aren't set correctly (https://circleci.com/gh/pangeo-data/pangeo-cloud-federation/168):
#!/bin/bash -eo pipefail
hubploy deploy nasa pangeo-deploy ${CIRCLE_BRANCH}

An error occurred (AccessDeniedException) when calling the DescribeCluster operation: User: arn:aws:iam::783380859522:user/circle-ci-deploy is not authorized to perform: eks:DescribeCluster on resource: arn:aws:eks:us-east-1:783380859522:cluster/pangeo
Traceback (most recent call last):
  File "/root/repo/venv/bin/hubploy", line 11, in <module>
    load_entry_point('hubploy==0.1.0', 'console_scripts', 'hubploy')()
  File "/root/repo/venv/lib/python3.6/site-packages/hubploy/__main__.py", line 56, in main
    auth.cluster_auth(args.deployment)
  File "/root/repo/venv/lib/python3.6/site-packages/hubploy/auth.py", line 88, in cluster_auth
    deployment, **cluster['aws']
  File "/root/repo/venv/lib/python3.6/site-packages/hubploy/auth.py", line 137, in cluster_auth_aws
    ], env=aws_env)
  File "/usr/lib/python3.6/subprocess.py", line 291, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['aws', 'eks', 'update-kubeconfig', '--name', 'pangeo']' returned non-zero exit status 255.
Exited with code 1

@apawloski and @scottyhq - I reworked this again. I think we're in a pretty good spot. Mind giving this a review?

This is still erroring: https://circleci.com/gh/pangeo-data/pangeo-cloud-federation/243
However, I'm going to merge this since I'm going to try fix https://github.com/pangeo-data/pangeo-cloud-federation/issues/120


content: Bold spans aren't bolder than surrounding text in spoiler headers or h1/h2/etc.

Bold spans should be bolder than surrounding text, even when that surrounding text is bold because it's in a spoiler header or an h1/h2/etc. (or column headings in tables, with #360).

Current
Better

In fact, in the spoiler header, the bold text is less bold. That's because, following web, we hard-code bold spans to weight 600 but spoiler headers to weight 700.

In fact, web also fails with this. Here are the same messages screenshotted on web: