Indexed mode for VertexArray ? Or new class VertexArrayIndexed ?

I noticed there is no way to use indexed vertex arrays in SFML.
(by that I mean have a vertex array and another int array telling which vertices to draw)
I looked at the code a little, and it seems it would involve some big code change in RenderTarget::draw().
So, has it it already been a concern, or should I start looking into trying out some patch?

Before writing an implementation for it, please open a discussion on the forum ("Feature requests"), to see if it is relevant, what design would fit the best, etc.
All this stuff is explained in the contribution guideline.


Hide the left nav & message popup automatically after user click one item

After user click the item on the left nav or the alarm popup message, Is there any way to close the left nav and the popup layout automatically.
Because I am trying to use it in the mobile Application. every time when user click the menu item, he has to hide the nav manually.
Thank you very much.

Have you tried one of the following Methods?
toggleDrawer( )
openDrawer( )
closeDrawerIfNotPersistent( )
closeDrawer( )

Reopen if you still have problems


Add support for unpackArchive to http

Describe the problem/challenge you have
http method can download file, but it wont archive it automatically. Some binaries are distributed in archives, like https://www.terraform.io/downloads.html and these are currently not very usable with vendir
Describe the solution you'd like
Add support for an optional http.unpackArchive similar to how it works in githubRelease

Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.

still relevant


Restructured assets and rewrote gulp tasks

I'm afraid I can't break it further than this.
Changes

Moved non-assets like gulp helper and Dockerfile to lib/.
Splitted js into js for distribution files and _js for source scripts to be concatenated and uglified.
Splitted img into img and _img for source images to be optimized. #250
Rewrote gulpfile.js entirely providing a non-destructive incremental optimization flow. #250
Updated README.md.

Requested changes were made.

Since the #253 is still a draft, I will hold onto this one.
There are good stuff there and some linked to the #253 to stop gulp to re-minimize image.
So I will put it on hold, and may cherry pick from it.

I only discovered this today. It does the composing menial tasks that we started to automate with Gulp.
https://github.com/jekyll/jekyll-compose

Not a priority for now


As a lifecycle consumer, I can use a directory to cache builds

Acceptance Criteria
Case 1
When I pass a path to cacher via the path parameter while executing a full lifecycle sequence
And The build completes successfully
Then The cache from that build is available to the next build (via path parameter to the restorer) that uses the same cache path
Case 2
When I pass a path to cacher via the path parameter while executing a full lifecycle sequence
And The build fails or is otherwise interrupted at any point
The cache from that build is not available to the next build (via path parameter to the restorer) that uses the same cache path
(edited 4/16 by @ameyer-pivotal. See buildpack/knative-integration#3 for Knative case)

fixed on master, will ship in v0.2.0

Needs @sclevine


Implement L1Fetcher that works on block finalization state

@palango can you please update "Time elapsed (hours)"?


Make volume into a setting

Volume can currently only be set through configuration. This should be a setting so that it is persisted across restarts.
Mentoring Instructions
Note that this would require a setting per player:

player/spotify/volume
player/youtube/volume

You have to add a schema for it here:
https://github.com/udoprog/setmod/blob/master/bot/src/settings.yaml
Calling !song volume should only manipulate the setting of the currently active player. This is tracked here:
https://github.com/udoprog/setmod/blob/master/bot/src/player.rs#L1490
!song volume translate to the Command::Volume command defined here following :
https://github.com/udoprog/setmod/blob/master/bot/src/player.rs#L179
Which is processed here:
https://github.com/udoprog/setmod/blob/master/bot/src/player.rs#L1735
The trickiest part here is that we would have to subscribe to a stream of updates. This is done through the init_and_stream function, and there are a few examples of it in the codebase.

Done.


Orin NX won't boot scarthgap build

Hi all,
I'm starting a project on an Orin NX 16GB (reComputer j4012).
I have a basic image built with the nanbield branches of meta-tegra, meta-openembedded and poky, and this works fine. But when I update all the metas to scarthgap, the target won't boot at all.
When I connect to a monitor I will see the NVIDIA logo and UEFI menu, and then it will reboot and fails to go further than that.
I have a very basic distro based on poky, with just a few distro features enabled. Image is very basic as well.
I am using the tegraflash image:
IMAGE_FSTYPES = "tegraflash"
IMAGES_CLASSES += "image_types_tegra"

In both cases I am using the p3768-0000-p3767-0000 machine that I flash with the ./doflash.sh script.
You will find uart logs attached.
Any help would be greatly appreciated.
Thanks
To Reproduce
Steps to reproduce the behavior:

Build meta-tegra scarthgap with MACHINE based on p3768-0000-p3767-0000
Build with bitbake argument image-name
Deploy to hardware with method ./doflash.sh

logs.txt

I have a very basic distro based on poky, with just a few distro features enabled. Image is very basic as well.

If you are just attempting to see a working implementation distribution as opposed to setting up your own you may want to look at https://github.com/OE4T/tegra-demo-distro.  Or if you reproduce a problem there it will be easier for others to reproduce as well.

Duh, very sorry about that. I have 2 different jetsons and mixed up the install scripts.
Thanks for pointing out my mistake!


Authorship requires position

Authorship model validates that position is present
Collection API now accepts the position parameter
Service object to migrate old data

To run the service object:
# rails console

AuthorshipMigration::CollectionAuthorshipPositionFix.call
# => true if success, false if errors and errors will be printed to the stdout

Once the service object has been run and our old data is ported correctly on production, we should follow this up with a second release/deployment that makes the authorships.position field in the database schema non-nullable
Fixes #928

This has been deployed to a test branch, and I've run the script. No errors. You can check it out here:
https://scholarsphere-positions.dsrd.libraries.psu.edu/dashboard

I've updated the description with a list of todos


[Wayang-36] Adding benchmarks

Addition of the benchmark from the old repository rheem-benchmark.
The code is rebranding as wayang and add old the header missing.
Validate that everything it procesed well

The changes seem to be correctly implemented.

+1, tests passed

All looks good for merge.


Cleanup exception handling in provisioning services

The removed try-catch blocks are handling exceptions, that will never
bubble up to them. They also hide sever errors of the persistence layer,
by handling them as "resource not found" errors.

It's way better this way. Thank you!


How to incorporate docs earlier into the PR review process

Notes from an earlier discussion with @JeffSchering

See this excerpt from http://contentstrategy101.com/contents/creating-useful-information/
Content is an afterthought. Technical content is seen as a necessary evil and not a strategic asset.
Documentation is created at the last minute, content creators are not full members of the product teams, and the “just get something out there” mentality prevails.
When a writer is involved early on, he can advise you on how to create a design that requires no recourse to documentation.
The last thing you want is a user looking at the modal and wondering what to do, and maybe thinking of looking in the docs. Every minute spent using the docs is a minute spent not using the product.
Help text and other clues in the UI can prevent a lot of frustration for end users.

Creating an issue to discuss openly with anyone interested.

Our design principle is "fast, obvious, forgiving" and great documentation is vital to a great product.
We need to bring in great people to the team that care more about documentation than about other priorities. If people care, and they are great, they will influence the team to create great docs.

Here is what it looks like when a developer is working with someone who cares about documentation.
Here is the result in 5 days of working together after hours:

Install Guide
Verification Guide
README

I'm happy to confirm that this issue has been solved by the addition of two technical writers. :)


How to use fitBounds, panTo, etc

Could you provide some more documentation on how to use these <GoogleMaps /> helper methods?

You can access them directly through refs, as it's shown here: https://github.com/tomchentw/react-google-maps/issues/17

I took a day to rewrite the module from scratch on #88 . However, I remove these method from the component APIs. Do you guys think it's a good idea to remove it or keep it?

I have a use case for using fitBounds. Do you expose the google map object so that it would be possible to act directly on it? Or is that philosophically improper?

It's not a easy design decision and I certainly believe exposing it is philosophically improper. But I cannot come up with a better way other than exposing getter though ...

I would be in favor of exposing it recognizing that even though it may be improper it may be the only way to achieve something that would otherwise require scrapping the use of the project altogether. :)

Released v2.0.0 and v2.0.1.

Now with the rewrite, I'm pretty confused on what the correct way to use these is... especially fitBounds. I assume that panBounds is useless to set since I assume a new map is created every time state changes (is that right?). But setting fitBounds doesn't seem to actually work. Could you give us an example of how we should be setting the bounds? Thanks for this great project!

State changes will only be applied when you have controlled properties. Try calling fitBounds in your cDU?

isn't fitbounds a controlled property?

@outdooricon it's public APIs from the ref: http://git.io/vGc4H

Ok, I think i understand. I'm really curious what the use case of even exposing the these other properties that @LarryEitel has. It's pretty confusing to expose these if they don't really work.

@tomchentw could you explain how to use fitBounds now? In the last link you posted, it is only for getters (which don't seem to work at all for me, they are missing this context).
There does not appear to be a fitBounds method exposed anywhere that I can see.


Known markdown parser crashers

This might be a good place to collect markdown/markup FAQs to be documented in the readme.
To start, I've noticed that unclosed
 tags will crash the parser. Self-closed tags work as expected:
.

That's because the parser is based on JSX and JSX doesn't allow non closed tags.

Errors like '"gatsby-plugin-mdx" threw an error while running the onCreatePage lifecycle:' are probably helpful to Gatsby developers with the source code, but are not helpful to content writers trying to figure out why things are failing. Putting the offending .md file (or config file) into the error message would be super helpful.

Hey @chuckweger, I'm working on a solution to this issue now. As @icaraps said, when you have HTML tags that are not closed within your markdown files (such as,
,
, <image>), the parser will not recognize these tags as proper JSX, which will throw the error. Where are the docs (what repo) you are parsing? I can take a look and let you know which tags and files are causing the problem.
@ashryanbeats, yes, along with my fix, I'll create documentation about which tags the fix closes so writers can get in the habit of not including open HTML tags in their markdown.

Hi @bdenham, thanks for the quick reply. I fixed this one myself. It turned out that I had used the old something syntax, which Gatsby for sure does not like. Changing it to something worked.

Wow, I should have quoted parts of that reply (forgot this uses markdown). Let's try again.
I formerly used:
something

but am now using
**something**

Yeah, making sure everything in a markdown file is actually markdown is definitely a process. Takes time when working through legacy markdown to ensure that the loose HTML tags are either replaced by their markdown equivalents, closed, or removed.

Gatsby does not like local URLs with dashes.
For example:

throws this error:
TypeError: undefined is not an object (evaluating '_allSitePage$nodes$fi.componentPath')
Changing this to
[look here](../code_samples/

Makes everything fine again.

Sheesh. I will never get the hang of posting comments in markdown syntax. Sorry!
OLD code that throws the error:
[look here](../code-samples/)

NEW CODE THAT WORKS:
look here](../code_samples/)

Great. Keep them coming. I'm creating a markdown file for testing that will have your examples as well as several tags I know to check for. So your input here is a good a place as any to note your problem markdown. Thanks!

<InlineAlert variant="info" slots="text"/>
While this documentation...

The parser is parsing the above markdown as [InlineAlert, String].
If you add a linebreak before the text:
<InlineAlert variant="info" slots="text"/>

While this documentation...

The parser is parsing it as [InlineAlert, Paragraph] which is what InlineAlert is expecting.

Thanks, @icaraps. Yes, this applies for any JSX tag within an .mdx file or an .md file processed as MDX. That's what makes cleaning up an .md file that has
 and
 tags so difficult. Because even if you close the invalid tags that break the build (using
,
, etc), you still have to add line breaks to make the MDX parser render then as anything other than test strings.
For example, if you have a second-level heading immediately following a closed break tag in your markdown:

## Heading level 2

The MDX parser will treat the heading (## Heading level 2) -- or anything else! -- as text that is a part of the closed
 tag:
"type": "jsx",
"value": "
\n## Heading level 2",

So in this case, the HTML output looks like this (with no tag wrapping the heading):

## Heading level 2

Instead what it should be:

Heading level 2

I've got a draft PR for a new gatsby plugin in the parliament-client-template that fixes tags which cause know MDX/JSX parsing errors: adobe/parliament-client-template#36.
I can also create a node CLI for this as well, which could be run locally and committed to your docs repo on GitHub to fix the issues. Is there any interest in such a CLI?

@bdenham sure we have a CLI so maybe just add it there https://github.com/adobe/aio-cli-plugin-doc ? Maybe as part of https://github.com/adobe/aio-cli-plugin-doc/issues/8 ?

@icaraps Cool. I'll check it out. Thanks.

https://github.com/AdobeDocs/dev-site-documentation-template/pull/81 should help to prevent these issues


[#752] refactor: replace RuntimeException with RssException

What changes were proposed in this pull request?
Replace raw use of RuntimeException with RssException in src/main.
Enable spotbugs check: THROWS_METHOD_THROWS_RUNTIMEEXCEPTION
Why are the changes needed?
Fix: #752
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Tested by spotbugs and existing tests.

Codecov Report

Merging #753 (370e509) into master (5fd6876) will increase coverage by 2.08%.
The diff coverage is 29.41%.

@@             Coverage Diff              @@
##             master     #753      +/-   ##
============================================
+ Coverage     60.72%   62.81%   +2.08%
- Complexity     1901     1902       +1
============================================
  Files           238      225      -13
  Lines         13017    11067    -1950
  Branches       1091     1091
============================================
- Hits           7905     6952     -953
+ Misses         4674     3737     -937
+ Partials        438      378      -60

Impacted Files
Coverage Δ

...g/apache/hadoop/mapred/SortWriteBufferManager.java
79.89% <0.00%> (ø)

...n/java/org/apache/hadoop/mapreduce/RssMRUtils.java
48.24% <0.00%> (ø)

...preduce/task/reduce/RssRemoteMergeManagerImpl.java
82.43% <0.00%> (ø)

...apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java
0.00% <0.00%> (ø)

...che/spark/shuffle/writer/BufferManagerOptions.java
75.67% <0.00%> (ø)

...java/org/apache/spark/network/util/NettyUtils.java
40.00% <0.00%> (ø)

...rometheus/PrometheusPushGatewayMetricReporter.java
74.46% <0.00%> (ø)

...niffle/common/security/SecurityContextFactory.java
84.21% <0.00%> (ø)

.../apache/uniffle/coordinator/CoordinatorServer.java
59.23% <0.00%> (ø)

...ache/uniffle/coordinator/SimpleClusterManager.java
75.31% <0.00%> (ø)

... and 22 more

... and 20 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Unexpected server response (401) while retrieving PDF

Attach (recommended) or Link to PDF file here:
Configuration:

Web browser and its version: Version 53.0.2785.116 m
Operating system and its version: windows server 2008 R2 standard
PDF.js version:
Is a browser extension: pdf viewer Version: 2.0.301

Steps to reproduce the problem:
click on a link to a pdf attachment
What is the expected behavior? (add screenshot) to see a pdf preview
What went wrong? (add screenshot) i got the following error:
PDF.js v2.0.301 (build: fd242ad2)
Message: Unexpected server response (401) while retrieving PDF "http://localhost:8081/Miracle/ViewAttachment.aspx?guid=29b7899e15f144b5af1473b4ca91e6d8".
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):
thank you

Response status 401 happens when the request in unauthorized. It's a problem in your local configuration, either your application that requires authentication or CORS is not configured properly. Since there is no more information provided, I'm closing this as answered.


How to upload NQuad RDF

I dont see any mention of it.  Does anyone have a guide on this?
I was going to use Sail, but I noticed thats no longer supported in TinkerPop3, so Janus wouldn't support it.

I dont think its supported so going to close for now.


chore(deps): update terraform-module

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/icd-postgresql/ibm (source)
module
patch
3.19.6 -> 3.19.8

terraform-ibm-modules/landing-zone-vpc/ibm (source)
module
minor
7.5.0 -> 7.19.0

terraform-ibm-modules/resource-group/ibm (source)
module
minor
1.0.6 -> 1.1.6

terraform-ibm-modules/security-group/ibm (source)
module
minor
2.0.0 -> 2.6.2

Release Notes

terraform-ibm-modules/terraform-ibm-icd-postgresql (terraform-ibm-modules/icd-postgresql/ibm)
v3.19.8
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/kms-all-inclusive/ibm to v4.16.10 (#532) (6985f24)

v3.19.7
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/cbr/ibm to v1.29.0 (#531) (1434fd6)

terraform-ibm-modules/terraform-ibm-landing-zone-vpc (terraform-ibm-modules/landing-zone-vpc/ibm)
v7.19.0
Compare Source
Features

added new outputs dns_instance_id and dns_custom_resolver_id (#817) (b84f23a)

v7.18.3
Compare Source
Bug Fixes

remove upper limit for required terraform version (#800) (0bf01d7)

v7.18.2
Compare Source
Bug Fixes

vpc data lookup (#798) (fe27e6f)

v7.18.1
Compare Source
Bug Fixes

added fix to ensure vpc_data is always output after initial apply (#781) (069d418)

v7.18.0
Compare Source
Features

add authorization policy for spoke -> hub DNS access (#775) (2a5932f)

v7.17.1
Compare Source
Bug Fixes

extend the required terraform version to < 1.7 (#742) (f1747b2)

v7.17.0
Compare Source
Features

Added a new property to the subnet input variable map, no_addr_prefix, that if set to "true" will not automatically create a new matching address prefix for the subnet, no matter the condition. (#741) (cad676e)

v7.16.2
Compare Source
Bug Fixes

updates required provider version constraints to prevent major updates (#733) (da75636)

v7.16.1
Compare Source
Bug Fixes

change acl for_each conditional to fix bug (#725) (60867f4)

v7.16.0
Compare Source
Features

moved the management-vpc and workload-vpc submodule from the submodules directory to the modules directory to confirm with Hashicorp practises. See updated usage blocks on how to consume. (#694) (f583bbb)

v7.15.0
Compare Source
Features  (#709) (3dc79b8)

Allow existing subnets to be attached to public gateways.
input variable existing_subnet_ids renamed to existing_subnets
type of input changed from list(string) to list(object)
existing subnet object contains ID of subnet and boolean for public gateway attachment

v7.14.0
Compare Source
Features

added new input variables to give full flexibility over VPC resource naming. New variables include: vpc_flow_logs_name, public_gateway_name, routing_table_name, dns_custom_resolver_name, dns_instance_name, and dns_binding_name. (#697) (760689b)

v7.13.3
Compare Source
Bug Fixes

Resolve the issue where the VPC stack continues to auto-generate address prefixes, despite having subnet address prefixes explicitly passed to the module. (#679) (e3640c6)

IMPORTANT NOTE:
If you are using the module in a previous version, and passing only subnets as inputs with address_prefixes set to null or not set, upgrading to this version may cause the VPC to be deleted and recreated because the VPC configuration will change from address_prefix_management being set to "auto" to being set to "manual":
~ address_prefix_management = "auto" -> "manual" # forces replacement .
v7.13.2
Compare Source
Bug Fixes

fix outputs for VPC and Subnets to support new or existing (#688) (1dc057f)

v7.13.1
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/resource-group/ibm to v1.1.4 (#671) (f03b300)

v7.13.0
Compare Source
Features

cleanup, updated variables and basic example (#670) (b1a38d0)

v7.12.0
Compare Source
Features

added support to create resources in existing VPC and use existing subnets. See Existing VPC and subnets Example (#638) (f0c5b08)

v7.11.0
Compare Source
Features

surface additional hub-spoke dns sharing outputs (#668) (4228427)

v7.10.0
Compare Source
Features

introduce support for manual resolver resolver (#663) (13b7d08)
introduce hub-spoke examples (using manual and delegated resolver)

v7.9.0
Compare Source
Features

expose hub vpc inputs (#662) (1c15668)

v7.8.0
Compare Source
Features

expose enable_hub variable (#661) (c659a93)

v7.7.0
Compare Source
Features

added new vpc_data output (#641) (33d2c73)

v7.6.0
Compare Source
Features

updated required terraform version range to >= 1.3.0, <1.6.0 (#637) (badc1e8)

terraform-ibm-modules/terraform-ibm-resource-group (terraform-ibm-modules/resource-group/ibm)
v1.1.6
Compare Source
Bug Fixes

remove upper limit for required terraform version (#624) (0c4a55a)

v1.1.5
Compare Source
Bug Fixes

extend the required terraform version to < 1.7 (#581) (5552c65)

v1.1.4
Compare Source
Bug Fixes

fix variable name in catalog validation json template (#535) (6cadceb)

v1.1.3
Compare Source
Bug Fixes

fix typo in catalog validation json template (#534) (c4eb24f)

v1.1.2
Compare Source
Bug Fixes

cleanup for catalog onboarding (#533) (ec38fcc)

v1.1.1
Compare Source
Bug Fixes

create ibm catalog manifest which will be used for onboarding to the IBM catalog module registry (#528) (87bd79c)

v1.1.0
Compare Source
Features

update terraform version constraints to >= 1.0.0, <1.6.0 (#508) (0a10be9)

terraform-ibm-modules/terraform-ibm-security-group (terraform-ibm-modules/security-group/ibm)
v2.6.2
Compare Source
Bug Fixes

remove upper limit for required terraform version (#286) (ccd2d6f)

v2.6.1
Compare Source
Bug Fixes

extend the required terraform version to < 1.7 (#245) (877a544)

v2.6.0
Compare Source
Features

Adding a new output for Security Group ID, security_group_id_for_ref, which now gives two options for output of ID:1. security_group_id, original output, and will not be available until all rules have been applied for this group. Continue to use this value when implicit dependencies depend on a fully deployed security group, including the rules.2. security_group_id_for_ref, new output, will be available as soon as group is created and before all rules are deployed. Use this value when the rules you are supplying to the module block need a self-reference to the group being created in the same block. (#243) (b322a7b)

v2.5.1
Compare Source
Bug Fixes

updated required provider version constraints to prevent major version updates  (#240) (cc42f92)

v2.5.0
Compare Source
Features

added the ability to attach tags and/or access_tags to security groups (#239) (50c0b2e)

v2.4.0
Compare Source
Features

Allow to pass an existing security group id through the existing_security_group_id input  (#234) (fc0d147)

v2.3.2
Compare Source
Bug Fixes

direction is now optional in the security_group_rules input variable. If not specified, it defaults to "inbound" (#230) (ae11e20)

v2.3.1
Compare Source
Bug Fixes

allow underscores in security group rule name (#221) (452820d)

v2.3.0
Compare Source
Features

add an example for manipulating kube sgs (#197) (fa97d48)

v2.2.0
Compare Source
Features

Surface the ability to add security group rules to an existing security group using new boolean variable use_existing_security_group (#180) (432f418)

v2.1.0
Compare Source
Features

update terraform version constraints to >= 1.3.0, <1.6.0 (#166) (89ebdd5)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline


New version - 0.3.0

Hello!
I've been working on this set of patches for some time, and now, it' ready.
The original intention was just to refactor things a bit, but i ended up refactoring quite a lot to improve usability, compile times and code organization. Here's a little summary of what has been done:

Build scripts improvements;
Move out downloads from build script to runtime;
Better example structure + a new example;
Small documentation update (i intend on doing more set patches to finish this sometime.);
Feature flags reorganization;
A lot more;

The intention behind the changes in the feature flags was because it made no sense for embed-all to also enable native builds, besides, that was a very messy code.
Instead of removing the flag, i opted to make it opt-in instead of opt-out (same for embed-all).
Embed-all flag didn't change a lot, the only modification was that the code and logic for downloading files was moved to runtime instead of compile time, and it's easier to disable/remove these if needed.
Therefore, with this refactoring, both feature flags (native-build and embed-all) have been decoupled, and turned into opt-in.
These changes have been documented in the root Readme file.
As i disabled the default opt-out behavior of the build-native flag, i considered this a breaking change, so i bumped the major version of the library.
This PR improves Compile times quite a lot.
Please do review these patches however desired. I hope these changes are good enough :D

@kerryeon Review please.

Thanks for the wonderful contribution!
I will try to reflect the revision to crates.io asap.


Maybe an error for GT_split_lists

I noticed in jhmdb_data_preprocessing.ipynb this snippet
GT_lists_1 = []
GT_lists_2 = []
GT_lists_3 = []
for file in GT_split_lists:
    if file.split('/')[-1].split('.')[0].split('_')[2] == 'split1':
        GT_lists_1.append(file)
    elif file.split('/')[-1].split('.')[0].split('_')[2] == 'split2':
        GT_lists_2.append(file)
    elif file.split('/')[-1].split('.')[0].split('_')[2] == 'split3':
        GT_lists_3.append(file)

fetches just 1 word labels (e.g. catch, stand, push, etc.) and skipped 2 word labels (e.g. climb_stairs, kick_ball, shoot_gun, etc.). Therefore, the pickled dataset contains just 14 actions out of 21 actions of the JHMDB dataset. If this is intentional then you can close this issue but otherwise I made changes as follow to preprocess data of all 21 actions.
GT_lists_1 = []
GT_lists_2 = []
GT_lists_3 = []
for file in GT_split_lists:
    if file.split('/')[-1].split('.')[0].split('_')[-1] == 'split1':
        GT_lists_1.append(file)
    elif file.split('/')[-1].split('.')[0].split('_')[-1] == 'split2':
        GT_lists_2.append(file)
    elif file.split('/')[-1].split('.')[0].split('_')[-1] == 'split3':
        GT_lists_3.append(file)

Thanks very much for pointing this error. I rerun the experiments and report the new performance. The best performance is achieved by 1.82 M parameters other than 0.5M parameters, and the best accuracy is 77.2 other than 78.0. Besides, the performance of 0.15M model drops significantly. I will also correct my paper based on the new results.


Add support for Daitch-Mokotoff algorithm

Fixes #3174

Added additional settings

backported to 6.x in 27b8813662690446c3053b71faa9b5ea6b113fbe
backported to 5.x in 773875fd7ee061cec79776ee3c70261eef7ac125


[Table] When predicate should evaluate on each data emit

The table uses the row when predicate to determine which row template to use for a piece of data, but only once when inserting a new row.
This should be evaluated on each emit to confirm that data objects match to the right row template.
https://stackblitz.com/edit/angular-bgzmrf-tbx3dm?file=app%2Ftable-basic-example.ts

Any progress on this one? As a workaround I re-assign my datasource

Would like to know this as well. Currently experiencing that bug

Any update on this one? It might be an idea to either let the when - function return a boolean (which is not re-evaluated, as it is implemented right now), or return an observable, which will trigger changes in the table if the observable emits a boolean change.

Is this to be resolved in the upcoming version 8?

In my case I wanted to implement an infinite scroll, adding new rows at the bottom, but because because of this bug the new rows get broken indexes.
Is there any workaround?

A workaround for this issue is to declare:
@ViewChild(MatTable, {static: false} table: MatTable<any>;
And then use:
this.table.renderRows()
whenever you update the property that when depends on.

Bump.
NgFor does the same trackBy, but it does not stop there, it checks if the item itself has changed. This would be the desired behavior for MatTable too.
My problem is, if I change the value of a row after it has been rendered:
a) if trackBy is set, ids match, no update is shown
b) if not using trackBy, and all row DOM elements will be thrown away and recreated (also I cannot use animations without retriggering them)


Add French translation

Translate "FILES" into french.

thanks a lot.
i will not directly merge this pr because i'm doing several changes and the pr will not apply on my current code. but while it is simple, i will translate it. thanks.

done without the merge.


403 on https://packages.microsoft.com/ubuntu/22.04/prod

Describe the issue
Suddenly getting 403 on packages.microsoft.com within Github Actions Workflow:
Err:12 https://packages.microsoft.com/ubuntu/22.04/prod jammy/main amd64 mssql-tools18 amd64 <IP_ADDRESS>-1 403  Forbidden [IP: *.*.*.* 443]

When did the issue occur?
This step within our Github Actions Workflow installs the prerequisites we need for setting up our automated testing, we're installing mssql-tools18 to execute MSSQL commands from CLI
      - name: Install Prerequisites
        run: |
          sudo rpm --import https://packages.microsoft.com/keys/microsoft.asc
          curl -sSL -O https://packages.microsoft.com/config/ubuntu/22.04/packages-microsoft-prod.deb
          sudo dpkg -i packages-microsoft-prod.deb
          rm packages-microsoft-prod.deb
          sudo apt-get update && sudo apt-get install -y mssql-tools18 unixodbc-dev libonig-dev libmcrypt-dev mcrypt liblz4-dev liblzf-dev libzstd-dev gconf-service libstdc++6 ca-certificates libnss3 lsb-release wget libgbm-dev

Steps to Reproduce

Actual Result
Err:12 https://packages.microsoft.com/ubuntu/22.04/prod jammy/main amd64 mssql-tools18 amd64 <IP_ADDRESS>-1 403  Forbidden [IP: *.*.*.* 443]

E: Failed to fetch https://pmc-geofence.trafficmanager.net/ubuntu/22.04/prod/pool/main/m/mssql-tools18/mssql-tools18_<IP_ADDRESS>-1_amd64.deb?geofence=true  403  Forbidden [IP: *.*.*.* 443]

Expected Result
mssql-tools18 successfully installs and continues with the rest of out workflow.
Screenshots

Additional context

We are also experiencing this in our Github Actions Workflow.

I too am experiencing these issues today.
It's happening from my local machine, GitHub Actions and ADO pipelines.

+1

Though I suspect this is all very related, don't want to just be a "+1":
Get:1 https://packages.microsoft.com/ubuntu/18.04/prod bionic/main amd64 msodbcsql17 amd64 <IP_ADDRESS>-1 [749 kB]
Err:2 https://packages.microsoft.com/ubuntu/18.04/prod bionic/main amd64 mssql-tools amd64 <IP_ADDRESS>-1
403  Forbidden [IP: <IP_ADDRESS> 443]
Fetched 749 kB in 1s (938 kB/s)
E: Failed to fetch https://pmc-geofence.trafficmanager.net/ubuntu/18.04/prod/pool/main/m/mssql-tools/mssql-tools_<IP_ADDRESS>-1_amd64.deb?geofence=true  403  Forbidden [IP: <IP_ADDRESS> 443]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

Also affects https://packages.microsoft.com/ubuntu/22.04/mssql-server-2022/pool/main/m/mssql-server/ packages.

We're investigating the issue. Over the past several weeks we've updated our infrastructure, which includes a Web Application Firewall (WAF) to meet emerging security requirements. It's likely that the WAF is rejecting some requests based on its ruleset. We're looking into mitigation now.

Just chiming in here, this has blocked all our deployments, including production. I hope you can resolve this quickly @mbearup and please reach out to me if we can help with testing.

This should now be mitigated. There was an issue with the WAF rules preventing download of these files. If anyone is still seeing this symptom let us know.

That resolved the issue for us. Thanks!

@mbearup I am seeing a similar issue https://github.com/microsoft/linux-package-repositories/issues/120

@mbearup I'm still seeing this issue on https://packages.microsoft.com/config/rhel/8/mssql-server-2019
Status code: 403 for https://pmc-geofence.trafficmanager.net/rhel/8/mssql-server-2019/Packages/m/mssql-server-15.0.4355.3-4.x86_64.rpm?geofence=true
Let me know if you want me to create a new issue for this package.

Yep looks like a firewall issue on our side to the new domain, we'll update that. I'll follow up if I have any other issues with this.
Thanks @mbearup


Added Footer tests

Added simple Footer tests.
Run npm run test:unit

Looks good just do not overwrite changes done on DC-35 branch


Upload the file into S3

Description
This file takes the parameters from the user and gives the JSON output file to the class where the conversion to HTML occurs. It gets a HTML string which is converted to a HTML file either containing an output or an error message. This file is given to the S3 class having the upload function.
Issues Resolved
This PR resolves a part of the conversion of JSON output to HTML file and uploading it to the S3 bucket.
Check List

Signed-off-by: Megha Sai Kavikondala<EMAIL_ADDRESS>
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The name has to be changed, it is a little misleading. This tool basically calls the  method which put the files into S3. This methods are basically being used in the code for the Issue no 260.

Happy to re-review when there's end-to-end working code with tests.

This was done as part of https://github.com/opensearch-project/opensearch-build/pull/367 I believe, closing.


Confirmation before starting after move?

Would it be possible/a good idea to have a confirmation before starting the package after the move?

I've been working an update for the script which actually now includes asking before starting ContainerManager/Docker or PlexMediaServer.
I could easily change it so it asks for all packages.

ContainerManager was the one that caused a problem earlier so I'm glad to hear that's in hand 🙂

I've released a new version that asks if you want to start the package after moving it.
https://github.com/007revad/Synology_app_mover/releases/tag/v2.0.6


Feature: refresh/update status periodically when not printing

If the printer is not printing, then it doesn't send status updates itself.
Therefore, add a feature that will get the status from the printer every 5 seconds, if the status wasn't updated in the last 5 seconds.

implemented in https://github.com/jeroenwalter/SdcpMonitor/commit/22255c8891826e9c24b5c6813655c82acb01b726


Offload ligand post-processing to idle CPU cores

Fixes #53

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

25 of 34 (73.53%)  changed or added relevant lines in 3 files are covered.
26 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-1.6%) to 40.742%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

mofa/assembly/validate.py
22
25
88.0%

mofa/hpc/colmena.py
0
6
0.0%

Files with Coverage Reduction
New Missed Lines
%

mofa/utils/src/edm.py
26
58.46%

Totals

Change from base Build<PHONE_NUMBER>:
-1.6%

Covered Lines:
4009

Relevant Lines:
9840

💛  - Coveralls


README-ko.md

Hi @lovebaby979 .
This PR is a duplicate of #23539 . I am closing this PR.
Feel free to reopen this PR if you have questions.
/close


Financials Extraction from XBRL

Version 3 of XBRL financials

Rewrite Financial extraction from XBRL
Create a comprehensive test harness
Document Financials V3

Progress so far

Note from a user
Hey,
If this helps, here are the entry points from the FASB taxonomy that group the line items in the mandatory filing statements:
https://xbrlview.fasb.org/yeti/resources/yeti-gwt/Yeti.jsp#tax~(id~174*v~10231)!con~(id~5267870)!net~(a~3474*l~832)!lang~(code~en-us)!path~(g~99043*p~0)!rg~(rg~32*p~12)

@emestee what do you know about standardized statements vs as-reported statements? Do you know what defines the standard concepts that all companies include in their statements?

circling back here as ive been playing with the new upgrades.  Thanks for this - looks like a lot of work went into the rewrite.
Were you able to pull in the productMembers as referenced here https://github.com/dgunning/edgartools/issues/66#issuecomment-2243569825
I have been trying to pull in the concepts that feed into the Revenue Sales, but still can't figure that out correctly.
The is the code snippet I have (eg for the AAPL XBRL instance)
# ----
                # Extract detailed revenue items
                # ----
                revenue_sources = []

                rev_dimensions = instance.dimensions
                rev_dimension_value = rev_dimensions['srt:ProductOrServiceAxis']
                facts = rev_dimension_value.get_facts()

                period_date_str = latest_date.strftime('%Y-%m-%d')

                # get the facts for this latest period
                latest_period_facts = facts[facts['end_date'] == period_date_str][facts["duration"] == "3 months"]

                for index, row in latest_period_facts.iterrows():
                    if row.concept.startswith("us-gaap:Revenue"):
                        print(row.value, row.concept, row.dimensions)

Running this against AAPL Q2 10Q, I get the following facts:
61564000000 us-gaap:RevenueFromContractWithCustomerExcludingAssessedTax {'srt:ProductOrServiceAxis': 'us-gaap:ProductMember'}
24213000000 us-gaap:RevenueFromContractWithCustomerExcludingAssessedTax {'srt:ProductOrServiceAxis': 'us-gaap:ServiceMember'}
39296000000 us-gaap:RevenueFromContractWithCustomerExcludingAssessedTax {'srt:ProductOrServiceAxis': 'aapl:IPhoneMember'}
7009000000 us-gaap:RevenueFromContractWithCustomerExcludingAssessedTax {'srt:ProductOrServiceAxis': 'aapl:MacMember'}
7162000000 us-gaap:RevenueFromContractWithCustomerExcludingAssessedTax {'srt:ProductOrServiceAxis': 'aapl:IPadMember'}
8097000000 us-gaap:RevenueFromContractWithCustomerExcludingAssessedTax {'srt:ProductOrServiceAxis': 'aapl:WearablesHomeandAccessoriesMember'}

The problem is that the us-gaap:ProductMember actually represents the total of all the individual product lines, so I end up double counting the product values.
Like, how do you determine that the apple:* members are part of the productMember, while the serviceMember is on its own without any nesting?
I want this product breakdown to work for any 10-Q so I can present where a companies incoming revenue comes from.

You can see the  dimensions using the dimensions attribute

And you can query by dimensions

@emestee what do you know about standardized statements vs as-reported statements? Do you know what defines the standard concepts that all companies include in their statements?

I actually don't know, I imagine it is SEC regulation derived from federal law and incorporating FASB rules. I also don't think it should matter. SEC filings are validated upon submission and can be assumed to be compliant with technical requirements (otherwise the SEC parser will reject the filing). You should not assign any specific meaning to any items in the statement, other than their relationships to parent items, if any.

thats kind of what im doing where I use this library to pull in the data but then standardize things into my own fields.
You prev had a version of that in your old income statement code, but the challenge is getting a mapping of all the fields into something.

You can see the dimensions using the dimensions attribute
And you can query by dimensions

So with this, I am already getting the aapl:* dimensions.  But see how there is also the 'us-gaap: ProductMember' in the srt:ProductOrServiceAxis.  This ProductMember happens to be the sum of all the aapl dimensions.  Meanwhile the ServicesMember in this example doesn't have sub items.  Is there a way to know if a dimension is a total of other sub items (when you pull up the xbrl viewer on the sec site the items get indented so I assume the info is somewhere).
My use case is to be able to pull the product revenue sources generically for all 10K/10Q imports, so not necessarily Apple specific.

thats kind of what im doing where I use this library to pull in the data but then standardize things into my own fields.
You prev had a version of that in your old income statement code, but the challenge is getting a mapping of all the fields into something.

I'm struggling in this standardization now, would you please share the approach or some code to give me an idea? --I'm new to financial data and SEC but want to standardize financial statements for many companies. @amitgandhinz

The new version is working much better on the financials statements! Thanks a lot for that!
I think there is a small thing that could be highly improved in the cash flow statement. If I look at Apple, it seems like a lot of the lines are positive instead of being negative (like Share repurchases).

@Colem19 @dgunning The statements are great; Dwight has done a great job. You are right though, good eye on identifying this issue. As an example I pulled (ULTA)'s most recent 10-Q via the TENQ-Class and I have identified a few more line items that either should have a negative output , positive output or its in reverse order (meaning 2024 should be positive and 2023 should be a negative). @dgunning do you anticipate that this will be fixed or is something that is fixable?

@Colem19 @dgunning To be clear I highlighted in yellow what should be negative for both years. And I commented what should be reversed and what should be positive.

I verified and most values are in the right direction

Deferred Income Tax does not match the Filing table in the HTML.
The raw value does not match in the XBRL instance file but I suspect that there seems to be a bug in the XBRL calculation file.

The calculation files usually have weights of -1 for negative values but it is missing in this case.

Not much the code can do in this case

Closing as fixed


[FLINK-15668][tests] Remove travis test stages for legacy scheduler

What is the purpose of the change
AlsoRunWithLegacyScheduler is used to enable IT cases for legacy scheduler.
This task is to remove it as well as the related test stages from travis.
Brief change log

Removed AlsoRunWithLegacyScheduler
Removed test stages for legacy scheduler

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Failing e2e test case is unrelated. Merging this PR now.


Some issues related to amt event logs

Hello there.
I have a few things to point out about the api/v1/amt/log/event/{guid} API call and documentation.
First of all I would like to ask if I am following the correct documentation (because some of the issues to be pointed out can be explained if not)
The initial link provided on the toolkit doc it this:
https://software.intel.com/sites/manageability/AMT_Implementation_and_Reference_Guide/default.htm?turl=HTMLDocuments%2FWS-Management_Class_Reference%2FAMT_EventLogEntry.htm
And following the docs and looking for the PET specs to translate the fields I got this:
https://www.intel.com/content/dam/www/public/us/en/documents/product-briefs/platform-event-trap.pdf
It seems to be an old document but I did not found anything newer related to this. Is this the right place I should be looking for to translate those event fields?
Anyway putting that aside there are a few issues I would like to point out here:

The API documentation: https://open-amt-cloud-toolkit.github.io/docs/2.7/APIs/indexMPS/ have a few key points that are misleading
1.1 All result event fields on the doc are lowercase but when we call the API all those fields starts with a Uppercase letter.
1.2 The field time is actually TimeStamp when calling the API
1.3 This is only a issue if the PET document pdf I pointed out is the right one but on the sample value and also calling the API the entity: 34 is returning the entityStr: "BIOS", but looking at the documentation BIOS should be 35.
As I checked on the code for this it seems that the part that does not match between that doc and the current enum used is actually the number 19 (it was marked as reserved on the doc). On the current code we can find it here:
https://github.com/open-amt-cloud-toolkit/mps/blob/88a14f4b67385f922a48570fada901d257bd9e71/src/utils/constants.ts
Checking for SystemEntityTypes

Note: For the first two issues I don't know if the right place to post would be here or on the sample UI repo.

Hi @bberbel1-lenovo,
1.1 and 1.2 definitely seem to be documentation issues. Typically we log documentation issues under https://github.com/open-amt-cloud-toolkit/docs but no problem, we will work on getting these issues fixed.
I've reached out to our firmware team internally to see if this is the latest PET specification document.
Regarding 1.3, this seems like a bug too (acc to PET spec document) but will update this thread once I hear from the firmware team.

Hello @graikhel-intel
Thank you for the fast response. I will be waiting for further updates on this issue them.

Docs have been updated for 1.1 and 1.2. Also, noticed AuditLogResponse needs to be fixed. Will update that too.

Here is the link to the specification https://www.dmtf.org/sites/default/files/standards/documents/DSP0136.pdf. Check the table on page number 85 (A.7 IPMI 1.0 Entity IDs)
I noticed one discrepancy between the spec and our code with respect to Entity, seems like 35 should be 'Operating system' and not Intel(r) ME. Will work on fixing it.

Great! Thank you for providing the documentation as well.


fix: ensure isr conditional 404 fix works for next 11

Summary
A previous PR that fixed an issue with fallback: false also patched the Next server so that 404 pages could return a SWR header and so ISR pages that conditionally 404 will still have a TTL. However, it seems this patch was not compatible with Next 11. This PR addresses that.
Test plan
Tests have been added as a new Next 11 demo site and should run and pass.
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
https://github.com/netlify/next-runtime/pull/1541

Going to go ahead and close this for now as we've done other work for 404s in relation to ISR.


'removed' is not defined error

I'm getting the following error in Google Chrome (and IE9):
Uncaught ReferenceError: removed is not defined on line 4443 of raphael.js
Switching the code from:
this[i] = removed(i)
to:
this[i] = null;
Makes the problem go away, but clearly isn't the 'proper' solution.

I have experienced this as well. The problem occurs when .remove() is called on the Raphael paper. The second instance of the problem (VML version of R.prototype.remove) is on line 5420.
Specifically, in a cleanup effort both VML and SVG implementations of the canvas try to call the removed(methodName) function to replace their methods with an error throwing proxy stub. However in Raphael 2.0 removed is no longer visible in the function's closure - it's defined privately in the common code partition and used only in the VML and SVG code partitions, which cannot see it.
While I would be happy to see the 'removed' method changed so as to not throw an Error (having had problems with the animation engine trashing IE 7/8 by calling paper.safari() after the paper has been removed), if the behavior is to remain the same as before, I believe the correct fix would be to just inline it in the two instances:
        this[i] = function () {
            throw new Error("Rapha\xebl: you are calling to method \u201c" + i + "\u201d of removed object");
        };

Also experiencing this problem

mind that you really should bind the i since it's in a loop :

for (var i in this) {
this[i] = (function(i) {
function () {
throw new Error("Rapha\xebl: you are calling to method \u201c" + i + "\u201d of removed object");
};
})(i);
}

This issue is also breaking the Spinner demo on raphaeljs.com.


Test: Complementary unit tests for new features

Describe the feature

We need to add more unit tests for new features
Motivation
We have added some new features in recent versions, but currently there is not enough test coverage, we need some tests to clarify the behavior of these features in the driver, and to avoid being broken.
The following tasks are open (welcome to add more)

[ ] Test for ErrDuplicatedKey
[ ] Test for TableType
[ ] Test for ErrForeignKeyViolated (Incomplete, need to add driver implementation)

If anyone is interested in the above tasks, please leave a message in the comments

Related Issues

I will be able to add the tests on drivers for https://github.com/go-gorm/gorm/pull/6004 and https://github.com/go-gorm/gorm/pull/6329 as well as the implementation for https://github.com/go-gorm/gorm/pull/6329.

@saeidee thank you

@a631807682 shall we write the tests in each driver repository or gorm repository?

shall we write the tests in each driver repository or gorm repository?
Also, you can assign the TableType test to me as well.

You can test in gorm to avoid a lot of repetitive testing code

@a631807682 shall we close this issue?


Fixed code-server not mounting codebase

Error Fixed

Enabling code server service causes Drupal container to be recreated and unlinked from the codebase folder

Change

Modified docker-compose.code-server.yml such that drupal container is set to mount the codebase folder on recreate

Close this PR, Made this PR upstream https://github.com/Islandora-Devops/isle-dc/pull/407 instead


Parameterize apt's "cache_valid_time" when installing "fail2ban"

Why do you want to change the cache_valid_time?

Hi @tersmitten,
I want to parameterize the cache_valid_time in order to help speed up our Ansible playbook runs. We have many nodes which, in-turn, have many apt repos that they pull from. Despite local apt caching proxies, the process of running "apt-get update" on these nodes is extremely time consuming.
Ultimately, these "apt-get update"s are usually completely unnecessary for our needs. For our infra we don't need up to the hour/minute metadata about the latest apt packages. Daily "apt-get update"s are just fine for our needs. Parameterizing this gives us the ability to control that. (We're using a Jenkins job with a string parameter to override via Ansible's --extra-args="..." flag)
Ex: After going through all of our "apt" commands and removing the unnecessary "apt-get update"s from our playbooks and 3rdparty modules, we have our playbook run down from ~60 mins -> 7 mins (!!)
I've had similar pull requests accepted to other Ansible modules. Ex: https://github.com/angstwad/docker.ubuntu/commit/9a23673dd793f984850079a08cc2ae505fa2eaf6
Thanks!
Dan

I understand. ~60 mins -> 7 mins is a real time saver. The problem is that we have a lot of roles and I rather have one place to override cache_valid_time.
I was thinking of using this variable from our apt role and when that variable is undefined defaulting to 3600. What do you think about that? Or do you have any other recommendations?

Hi @tersmitten ,
Sure, using that variable name instead works for me. Want me to send a new PR?
Thanks.

I added some notes. Please update your pull request so I can merge it (and apply it to all our other roles:-))

Closing this in favor of the change in #14.
Thanks,
Dan


Consider alternative api that is less "Erlang"-like

This would be nice, but is it necessary?

Going with JSONRPC like most of the other projects in the space.


PRJ Treeview, ProjectNode & LspFileNode Updates

Objective/Abstraction
The primary goal was to add ReadonlyDocument references to the PRJ LispFileNode's for the upcoming document management system. I expanded this to a Project Treeview feature update that allows users to close open projects. I did this because the future definitionProvider is intended to search PRJ's and open documents first when applicable. If it can't find what it was looking for there, then it will search the entire workspace. This new behavior means that both opening and closing a PRJ's to set a different baseline context can be a valuable behavioral tool for the users. A good example of this would be if (many do) users have "archive" folders and they don't want false positives from them, then they can simply dump all their core LSP's into a PRJ. If they are wanting to drudge through their history, they can easily do that too by closing the active PRJ.
Implementation
Added a close command to the PRJ Treeview's context menu and button bar. You'll notice that the icons on the Treeview button bar now support dynamic visibility contextual to the presence of a PRJ. Everything user-facing should have been localized. PRJ's now automatically create their ReadonlyDocument reference to be used for searching. The upcoming document manager will have a get projectDocuments() that finds/returns a vscode.TextDocument[] from those LspFileNode's if available.
Tests Passed/Screenshots

@Sen-real Please help to review this PR.

Now that a project can be closed, are you open to the idea of hiding the New/Open project buttons while one is open. I noticed those two options weren't in the project right click and I am always a fan of minimizing button clutter.

Now that a project can be closed, are you open to the idea of hiding the New/Open project buttons while one is open. I noticed those two options weren't in the project right click and I am always a fan of minimizing button clutter.

Well when a solution is open in Visual Studio, I can open another one. Visual Studio will automatically close the first.
Anyway if we want to add this feature, I think we can do it in a different PR.

@szilvaa-adsk please help to merge this PR.


Add new attributes to Financial API responses

Bug Report
Describe the bug
Currently the cashflowStatementHistory, cashflowStatementHistoryQuarterly, incomeStatementHistory and incomeStatementHistoryQuarterly modules does not contain all attributes which are available on the yahoo finance website.
For example the free cash flow attribute is missing in the cashflowStatementHistory module:

Another example are the earnings per share, eps, in the incomeStatementHistory module:

Maybe the response types of the modules need to be refreshed to meet the new attributes which are able to be returned by the finance api?
Minimal Reproduction
      await yahooFinance.quoteSummary('AAPL', {
        modules: [
          'incomeStatementHistory',
          'incomeStatementHistoryQuarterly',
          'cashflowStatementHistory',
          'cashflowStatementHistoryQuarterly'
        ]
      })

Environment
Browser or Node: node
Node version (if applicable): v16.13.0
Npm version: 8.1.2
Library version (e.g. 1.10.1): 2.3.3

Thanks for the great report as usual.  Will advise once I've had more time to look at this.


Projects that rely on BOSL exceptions should say that they do

This is important licensing information since it affects how those projects can be forked.

zcash_script depends on orchard via zcash_primitives:

https://github.com/ZcashFoundation/zcash_script/blob/c9fbc441efd78593ba6a9828be45baf2d6469757/Cargo.toml#L57-L58
https://github.com/ZcashFoundation/zcash_script/issues/36

zcash_chain depends on orchard directly and via zcash_primitives and zcash_note_encryption:

https://github.com/ZcashFoundation/zebra/blob/97fb85dca9d00a717661ea0cbab7ce66b8d23977/zebra-chain/Cargo.toml#L52-L56

zcash_consensus directly and via zcash_proofs and other Zebra crates:

https://github.com/ZcashFoundation/zebra/blob/97fb85dca9d00a717661ea0cbab7ce66b8d23977/zebra-consensus/Cargo.toml#L37-L48

zebra_network via zebra_chain:

https://github.com/ZcashFoundation/zebra/blob/97fb85dca9d00a717661ea0cbab7ce66b8d23977/zebra-network/Cargo.toml#L50

zebra_node_services via zebra_chain:

https://github.com/ZcashFoundation/zebra/blob/97fb85dca9d00a717661ea0cbab7ce66b8d23977/zebra-node-services/Cargo.toml#L10

zebra_rpc via zebra_chain and zebra_state:

https://github.com/ZcashFoundation/zebra/blob/97fb85dca9d00a717661ea0cbab7ce66b8d23977/zebra-rpc/Cargo.toml#L54-L55

zebra_state via zebra_chain:

https://github.com/ZcashFoundation/zebra/blob/97fb85dca9d00a717661ea0cbab7ce66b8d23977/zebra-state/Cargo.toml#L35

zebrad via all of the above:

https://github.com/ZcashFoundation/zebra/blob/97fb85dca9d00a717661ea0cbab7ce66b8d23977/zebrad/Cargo.toml#L71-L76

A copy of the notice is needed for each potentially reusable crate or component.
Suggested wording is:

Downstream code forks should note that the code in this repository depends on
the 'orchard' crate, which is licensed under the Bootstrap Open Source License.
A license exception is provided allowing some derived works that are linked or
combined with the 'orchard' crate to be copied or distributed under the original
licenses (in this case MIT / Apache 2.0), provided that the included portions of
the 'orchard' code remain subject to BOSL.
See https://github.com/zcash/orchard/blob/main/COPYING for details of which
derived works can make use of this exception.

See also:

https://forum.zcashcommunity.com/t/bosl-or-mit-orchard/41439/118
https://github.com/zcash/zcash/issues/5931 (similar issue for zcashd)
https://github.com/zcash/librustzcash/pull/577 (PR for librustzcash)

The orchard crate has now been relicensed to MIT OR Apache 2.0: https://github.com/zcash/orchard/pull/405. Strictly speaking, this issue is still valid until Zebra depends on an orchard release that includes the relicensing, probably 0.7.0: https://github.com/zcash/orchard/issues/407

this would have been resolved by #8201 but we're waiting for zcash_primitives to be upgraded to orchard 0.7.0

depends-on: #8541 and #8540

I think we can close this now as zebra no longer depends on BOSL licensed versions of any crates.


Remove rude bot

Having issues being closed just because can't keep up or maintain this repo is just rude. 🤬🤬🤬🤬
Remove the bots and start maintain this repo properly instead!

Agreed

Related

The above comment is proof that this is still an issue!

Please comment if it is not actually stale

We did, so stop making us do it again and again.

@DmitriiBobreshev Could you revert 1f6349e3193e46485404b1b3a43f87900e9a71b9 / #2775
And if not, who can deal with issues in a timely manner instead of having to write "Still a real issue" ever x days !?

This issue has had no activity in 180 days. Please comment if it is not actually stale

Thanks for once again proving the point! 😡🤬

@DenisNikulin5 who is responsible for this?
The lack of comments from maintainers on issues proves the points made in the original post.


Add some basic codeowners

References and relevant issues
#5224
Description
In my infite quest for procrastination, I keep looking at github notifications to find something else to do other than write my thesis... Turns out, I get too many notifications where my help isn't needed/requested, or that I'm not interested in. So I thought to revisit the CODEOWNERS talk we had a while back.
To get a starting rough configuration, I used git summary --line <path> (from git-extras) on each submodule to see who of the currenty active core devs is working most on each, and combined it with my personal experience.
This is meant as a starting point: please add/remove yourself from wherever you please.
Things to note:

I don't think the tool above accounts for review contributions, so that's for sure biased
too much of poor @czaki :P I'm sure you want to remove yourself from a few of these!
layers/tracks it seems was mostly written by @quantumjot so I'm not sure who among core devs is more on top of it.
We can go more granular than this
a few folks are missing, but I'll leave it to them to pick their poison!

Ok so one question I have is how we have or intend to set up the repo. I like the idea of ownership in general, but I'd like to be able to bypass it in certain situations (ie, unresponsive owners).
One possibility is to list @napari/steering-council as code owner of everything? But does that mean we get pinged for everything? Cos that could get old. 😂

Only other thought are that napari/components is a big important sub-package without specific assignments. But may then hitting all core devs is the right move.

Yep, I thought the same, then when I looked at the submodules I didn't know what to do ^^' It's easy to update this afterwards if we notice specifics.
Actually, I can definitely put myself only for the overlays.

Sorry @jni I missed this comment:

Ok so one question I have is how we have or intend to set up the repo. I like the idea of ownership in general, but I'd like to be able to bypass it in certain situations (ie, unresponsive owners).

I think we can just set it up as "automatically request review", and not as "blocked without review". No need to make it so that without owner we cannot continue.

Would it make sense to have docs people pinged for the examples?

Would it make sense to have docs people pinged for the examples?
EDIT: And probably the build & deploy docs action?

Yep, good idea! Feel free to suggest changes as you like :)

@melissawm added to core-devs

@kephale: would be good to add you to points/image layers probably?

This works for me.

Done @kephale; I also added a few lines for docs stuff with @melissawm and @psobolewskiPhD for now!

I guess this can go in like this as a starting point!

@jni or who else has access: reminder to check how codeowners are treated in the settings of the repo!


LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20230318154256685 to main

LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20230318154256685 to main with localized lcls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.005%) to 41.914%

Files with Coverage Reduction
New Missed Lines
%

extensions/sql-database-projects/src/common/httpClient.ts
1
66.18%

extensions/sql-database-projects/src/dialogs/publishDatabaseDialog.ts
2
52.88%

Totals

Change from base Build<PHONE_NUMBER>:
-0.005%

Covered Lines:
28824

Relevant Lines:
63834

💛  - Coveralls


Handling a bot that can view events on a different channel (2 different twitch accounts)

So this is more of a request/discussion than a bug, but I was attempting to create a bot that would sit in my channel and have responses as the bot name but also respond to events like point redeems and follows to my channel.  It seems like the only way to do this is to have 2 different authentications: one from my twitch, and one from the bot's twitch.  The follow notifications worked by having the bot as a moderator, but it seems like other events don't have that functionality.
So I effectively, I set up 2 different scopes and 2 different authorizations.  It was kind of a pain, because, since it opens the browser which is logged into my main twitch account, it would automatically authenticate.  I ended up having the 2nd one just copy to the clipboard instead of open a browser window from the shell.  That way I could paste it into a different browser that was logged into my bot account.
I'm not sure if this is the intended approach -- seems like a real hot mess, but I did get it technically working.  Not sure the best way to handle the UX for this due to needing 2 different logins.  I guess an "authenticate channel" button and "authenticate bot account" button that would copy the URLs to be pasted in appropriate browser windows?
I just wanted my bot to respond to point redeems! 😭
Side note, the refresh_tokens() function seems like it might not be entirely correct?  Maybe I just don't understand it.
func refresh_token() -> void:
	await(get_tree().create_timer(3600).timeout)
	if (await(is_token_valid(token_user["access_token"])) == ""):
		user_token_invalid.emit()
		return
	else:
		refresh_token()
	var to_remove : Array[String] = []
	for entry in eventsub_messages.keys():
		if (Time.get_ticks_msec() - eventsub_messages[entry] > 600000):
			to_remove.append(entry)
	for n in to_remove:
		eventsub_messages.erase(n)

It seems it waits 1 hour, then, if the token is invalid, it emits a signal and returns.  If it's still valid, it calls refresh_token() recursively, which waits 1 hour, etc.  So if, after the first hour, the token is invalid, the signal emits (does anything listen to this?) and returns without clearing the eventsub messages (though now that I'm looking at it closer, I guess it only cares about removing old stuff, so maybe that's fine?)
For my thing, I rewrote it like this, but I'm not 100% sure if that's correct, either:
func refresh_token() -> void:
	var tokens_valid := true
	while (tokens_valid):
		await(get_tree().create_timer(3600).timeout)
		if (await(validate_token_and_set_id(token_user["access_token"], ScopeType.SCOPE_TYPE_USER)) == ""):
			tokens_valid = false
		if (await(validate_token_and_set_id(token_channel["access_token"], ScopeType.SCOPE_TYPE_CHANNEL)) == ""):
			tokens_valid = false

		if (!tokens_valid):
			user_token_invalid.emit()
			var to_remove : Array[String] = []
			for entry in eventsub_messages.keys():
				if (Time.get_ticks_msec() - eventsub_messages[entry] > 600000):
					to_remove.append(entry)
			for n in to_remove:
				eventsub_messages.erase(n)
			print("TOKENS INVALID!!!!!")

I did eventually run into the token becoming invalid after a few hours, and I'm not sure what to do after that -- just completely reconnect everything?  Doesn't look like the original code handles that case either.
I can share more of my code if you'd like, but it's kind of a hot mess...

Currently, it is intended that you handle invalid tokens yourself - for example by requesting a new one, I unfortunately did not find the time yet to add handling all cases and error messages. It is not important for the EventSub messages to be cleared, so I didn't bother with that because clearing after 1h if you decide to reconnect is fine too ^^
Receiving channel point redemption events should work in theory from the bot account by adding the channel:read:redemptions or channel:manage:redemptions scope, but I've also heard from issues with that approach which I couldn't find anything about in the documentation. My guess for one of the issues was that only the app that created the reward may receive notifications of its redemption.

Gotcha, so I'm supposed to connect to the invalid token event and get a new token?  Also, if the token goes invalid, is there any down time between when the token went invalid and when the check happens that could result in lost events?  Sorry, I'm new to all this twitch event stuff, and it's super confusing. 😅
The problem with the scopes is it gives it the scope to read the channel points on the bot's channel, not my channel.  At least, I couldn't figure out how to do it -- either I had to be 100% on my account or the bot's account with a single token, so I made 2.

The event subscription has a 'condition' parameter, make sure to pass in a dictionary with a broadcaster_user_id: <your_broadcaster_user_id> as an entry. (see https://dev.twitch.tv/docs/eventsub/eventsub-subscription-types/#channelchannel_points_custom_reward_redemptionadd)
I think there is a downtime, but I'm not 100% sure.

Took another look, Twitch does some guessing and sometimes resends events, but it's not guaranteed - so better take into account that an event might've been lost. Maybe by requesting reward redemptions from the regular API upon reconnect? (would also require you to create the rewards with the app itself)

Just an update on this issue - I am currently rewriting the entire plugin and in the coming release multiple bot accounts will be possible by using the "force_verify" parameter, which will forcefully show the login window again on which you can change the account to be used.


Audio volume and spoopy music

SoundManager now takes individual sources' volume into account.
Also added some spoopy music.

SonarQube analysis reported 8 issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ScriptManager.cpp#L654: Memory leak: value
 ScriptManager.cpp#L658: Memory leak: value
 ScriptManager.cpp#L662: Memory leak: value
 AncientFungus:LGEPR: Cppcheck cannot find all the include files (use --check-config for details)
 ScriptManager.cpp#L676: The function 'GetScripts' is never used.
 ScriptManager.cpp#L684: The function 'ExecuteScriptMethod' is never used.
 SoundManager.cpp#L158: The function 'GetListeners' is never used.
 EntityEditor.cpp#L443: keyword 'if' not followed by a single space

SonarQube analysis reported 8 issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ScriptManager.cpp#L654: Memory leak: value
 ScriptManager.cpp#L658: Memory leak: value
 ScriptManager.cpp#L662: Memory leak: value
 AncientFungus:LGEPR: Cppcheck cannot find all the include files (use --check-config for details)
 ScriptManager.cpp#L676: The function 'GetScripts' is never used.
 ScriptManager.cpp#L684: The function 'ExecuteScriptMethod' is never used.
 SoundManager.cpp#L158: The function 'GetListeners' is never used.
 EntityEditor.cpp#L443: keyword 'if' not followed by a single space

SonarQube analysis reported 8 issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ScriptManager.cpp#L654: Memory leak: value
 ScriptManager.cpp#L658: Memory leak: value
 ScriptManager.cpp#L662: Memory leak: value
 AncientFungus:LGEPR: Cppcheck cannot find all the include files (use --check-config for details)
 ScriptManager.cpp#L676: The function 'GetScripts' is never used.
 ScriptManager.cpp#L684: The function 'ExecuteScriptMethod' is never used.
 SoundManager.cpp#L158: The function 'GetListeners' is never used.
 EntityEditor.cpp#L443: keyword 'if' not followed by a single space

SonarQube analysis reported 8 issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ScriptManager.cpp#L659: Memory leak: value
 ScriptManager.cpp#L663: Memory leak: value
 ScriptManager.cpp#L667: Memory leak: value
 AncientFungus:LGEPR: Cppcheck cannot find all the include files (use --check-config for details)
 ScriptManager.cpp#L681: The function 'GetScripts' is never used.
 ScriptManager.cpp#L689: The function 'ExecuteScriptMethod' is never used.
 SoundManager.cpp#L158: The function 'GetListeners' is never used.
 EntityEditor.cpp#L443: keyword 'if' not followed by a single space

SonarQube analysis reported 8 issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ScriptManager.cpp#L659: Memory leak: value
 ScriptManager.cpp#L663: Memory leak: value
 ScriptManager.cpp#L667: Memory leak: value
 AncientFungus:LGEPR: Cppcheck cannot find all the include files (use --check-config for details)
 ScriptManager.cpp#L681: The function 'GetScripts' is never used.
 ScriptManager.cpp#L689: The function 'ExecuteScriptMethod' is never used.
 SoundManager.cpp#L159: The function 'GetListeners' is never used.
 EntityEditor.cpp#L443: keyword 'if' not followed by a single space

SonarQube analysis reported 8 issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 ScriptManager.cpp#L659: Memory leak: value
 ScriptManager.cpp#L663: Memory leak: value
 ScriptManager.cpp#L667: Memory leak: value
 AncientFungus:LGEPR: Cppcheck cannot find all the include files (use --check-config for details)
 ScriptManager.cpp#L681: The function 'GetScripts' is never used.
 ScriptManager.cpp#L689: The function 'ExecuteScriptMethod' is never used.
 SoundManager.cpp#L159: The function 'GetListeners' is never used.
 EntityEditor.cpp#L443: keyword 'if' not followed by a single space


FITC methods are included in the BSD-only Shogun

@karlnapf

Thanks for cleaning this up.
NOTE: travis currently does not cover the BSD build. You will have to test this by hand.
@vigsterkr can we add a USE_GPL_SHOGUN=OFF build to travis? Or at least the buildbot (more important)

@yorkerlin feel free to merge this if tested locally

all related unit tests are passed.
merging

Great.
Please keep an eye on both the buildbot and the local build with USE_GPL_SHOGUN set to ON and to OFF


Fixed the header rendering to match that of GFM

Removed an extraneous ? from the header regex. GFM does not render headers if there's no space between the hash(es) and the text. In other words:
#header
is rendered as:
#header
Whereas:
# header
is rendered as:
header
With this change vmd complies with the GFM also in this regard.

Cool! It appears that GitHub changed how it renders the headings. In issue #90 we actually added support for headings without spaces after the hashes because GitHub supported it even though it wasn't totally correct markdown.
I added a comment. Maybe you can take a look at it.


project delete

#922  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


allow override of gateway inside subnet restriction

sometimes /32 gets assigned (dynamically) and we still need to set another gateway

still needs routes setup, see https://github.com/pfsense/pfsense/commit/de34f1fc12f29db0


template x-if support

Hi there, just checking out your plugin. Nice! I've been working on something similar recently (though without user configurable templates) and have found that setting x-init with next tick seems to work for getting transitions working within an x-if/for.
Is that something you might consider adding as it seems that I can't get the transitions working within the template with yours.
The trick that worked for me was doing this when applying transition attributes:
element.setAttribute('x-init', $nextTick(() => {${showString} = true}));

Hi, sorry for the late reply, been busy recently.
That made me realize that I didn't test the plugin within a template x-if/for, I apologize for the inconvenience.
I think that's a viable workaround until we come up with a proper fix. I will try to debug it when I'm free next month, or you can make a PR for this issue. I would appreciate that.


issue 537.1: backport from iresearch upstream: ensure key is cached too

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/4164/


ANP CSS_Modify_public_IP_Update tutorial-alias-rr.md

Public DNS server IP was mentioned in the doc. Changing the public IP to a private DNS server IP <IP_ADDRESS>

Do not change public to private. You can change to mock public. For example <IP_ADDRESS> but this also needs to be changed in all screenshots. #please-close


Typing ERROR Contributed to Can't build

Version
3.3.4
Platform
macOS arm64
JDK
Zulu OpenJDK 21.0.4
Module
LWJGL Croe
Bug description

You Typed double ":" ,and one ":" is enough
on the official website download
Stacktrace or crash log output
No response

Hi @yuxiangll,
Without more information, I won't be able to comment on the error you were having.
However, the snippet in question is correct:
The string notation for dependencies looks roughly like this:
<group>:<artifact>(:<version>(:<classifier>)?)?

We don't need to declare the versions for the individual dependencies because they are resolved from the BOM platform dependency. However, the dependencies for the native artifacts use classifiers for the different supported platforms. Thus, to include the correct natives dependency, we must declare the classifier, but we can still omit the version by simply using the empty string instead of a version number. This effectively leaves us with the syntax:
<group>:<artifact>::<classifier>

If still believe, you were facing an error related to this issue specifically, please provide us with more information (such as a stacktrace, logs, and, ideally, an MCVE).


Factor gets really slow with larger image files

I noticed that startup times get a lot slower with load-all, more so than the file size would indicate...
After bootstrap with 100MB fresh image:
$ time ./factor -i=factor.image.fresh -run=none

real	0m0.615s
user	0m0.102s
sys   	0m0.122s

After load-all with 300MB image:
$ time ./factor -i=factor.image -run=none

real	0m3.396s
user	0m0.642s
sys  	0m0.488s

I see some redundant mmap's:

mmap(0x0, 0x42000, 0x3, 0x1002, 0xFFFFFFFF, 0x14)»··»··· = 0xFF5F000 0
mprotect(0x10FF5F000, 0x1000, 0x0)»·»··· = 0 0
mprotect(0x10FFA0000, 0x1000, 0x0)»·»··· = 0 0
mmap(0x0, 0x42000, 0x3, 0x1002, 0xFFFFFFFF, 0x14)»··»··· = 0xFFA1000 0
mprotect(0x10FFA1000, 0x1000, 0x0)»·»··· = 0 0
mprotect(0x10FFE2000, 0x1000, 0x0)»·»··· = 0 0
mmap(0x0, 0x102000, 0x3, 0x1002, 0xFFFFFFFF, 0x14)»·»··· = 0xFFE3000 0
mprotect(0x10FFE3000, 0x1000, 0x0)»·»··· = 0 0
mprotect(0x1100E4000, 0x1000, 0x0)»·»··· = 0 0
mmap(0x0, 0x42000, 0x7, 0x1002, 0xFFFFFFFF, 0x14)»··»··· = 0x100E5000 0
mprotect(0x1100E5000, 0x1000, 0x0)»·»··· = 0 0
mprotect(0x110126000, 0x1000, 0x0)»·»··· = 0 0

mmap(0x0, 0x2000, 0x3, 0x1002, 0x1000000, 0x4)»·»··· = 0xFCF8000 0
mprotect(0x10FCF8000, 0x88, 0x1)»···»··· = 0 0
mmap(0x0, 0x17000, 0x3, 0x1002, 0x1000000, 0x6)»»··· = 0xFCFA000 0
mprotect(0x10FCFA000, 0x1000, 0x0)»·»··· = 0 0
mprotect(0x10FD10000, 0x1000, 0x0)»·»··· = 0 0
mmap(0x0, 0x17000, 0x3, 0x1002, 0x1000000, 0x6)»»··· = 0xFD11000 0
mprotect(0x10FD11000, 0x1000, 0x0)»·»··· = 0 0
mprotect(0x10FD27000, 0x1000, 0x0)»·»··· = 0 0
mmap(0x0, 0x1000, 0x3, 0x1002, 0x1000000, 0x6)»·»··· = 0xFD28000 0
mprotect(0x10FD28000, 0x1000, 0x1)»·»··· = 0 0
mprotect(0x10FCF8000, 0x88, 0x3)»···»··· = 0 0

mmap(0x0, 0x2000, 0x3, 0x1002, 0x1000000, 0x14)»»··· = 0xFD29000 0
mprotect(0x10FD29000, 0x88, 0x1)»···»··· = 0 0
mmap(0x0, 0x17000, 0x3, 0x1002, 0x1000000, 0x6)»»··· = 0xFD2B000 0
mprotect(0x10FD2B000, 0x1000, 0x0)»·»··· = 0 0
mprotect(0x10FD41000, 0x1000, 0x0)»·»··· = 0 0
mmap(0x0, 0x17000, 0x3, 0x1002, 0x1000000, 0x6)»»··· = 0xFD42000 0
mprotect(0x10FD42000, 0x1000, 0x0)»·»··· = 0 0
mprotect(0x10FD58000, 0x1000, 0x0)»·»··· = 0 0
mprotect(0x10FD28000, 0x1000, 0x3)»·»··· = 0 0

mmap(0x0, 0x2000, 0x3, 0x1002, 0x1000000, 0x6)»·»··· = 0xFDE4000 0
mprotect(0x10FDE4000, 0x88, 0x1)»···»··· = 0 0
mmap(0x0, 0x17000, 0x3, 0x1002, 0x1000000, 0x6)»»··· = 0xFDE6000 0
mprotect(0x10FDE6000, 0x1000, 0x0)»·»··· = 0 0
mprotect(0x10FDFC000, 0x1000, 0x0)»·»··· = 0 0
mmap(0x0, 0x17000, 0x3, 0x1002, 0x1000000, 0x6)»»··· = 0xFF00000 0
mprotect(0x10FF00000, 0x1000, 0x0)»·»··· = 0 0
mprotect(0x10FF16000, 0x1000, 0x0)»·»··· = 0 0
mprotect(0x10FD28000, 0x1000, 0x3)»·»··· = 0 0
mprotect(0x10FD28000, 0x1000, 0x1)»·»··· = 0 0
mprotect(0x10FDE4000, 0x88, 0x3)»···»··· = 0 0

mmap(0x0, 0x42000, 0x3, 0x1002, 0xFFFFFFFF, 0x6)         = 0x2D99F000 0
mprotect(0x12D99F000, 0x1000, 0x0)         = 0 0
mprotect(0x12D9E0000, 0x1000, 0x0)         = 0 0
mmap(0x0, 0x42000, 0x3, 0x1002, 0xFFFFFFFF, 0x6)         = 0x2D9E1000 0
mprotect(0x12D9E1000, 0x1000, 0x0)         = 0 0
mprotect(0x12DA22000, 0x1000, 0x0)         = 0 0
mmap(0x0, 0x102000, 0x3, 0x1002, 0xFFFFFFFF, 0x6)         = 0x2DA23000 0
mprotect(0x12DA23000, 0x1000, 0x0)         = 0 0
mprotect(0x12DB24000, 0x1000, 0x0)         = 0 0

mmap(0x0, 0x20000, 0x3, 0x1002, 0x3000000, 0x4)         = 0x2DB25000 0
mmap(0x0, 0x20000, 0x3, 0x1002, 0x3000000, 0x6)         = 0x2DB45000 0

I did while :; factor -run=none; done for a while under Instruments and the profile looked pretty flat. safe_fread is the only noticeable blip at about 2%, and the redundant mmaps you're seeing are probably from the fread implementation. Maybe we should use read or ReadFile directly, and look into compressing images to reduce IO time.

Some comments on startup time, running time ./factor -e="" gives me 0.140 seconds on a fresh Factor image.
Of that, 75% is load_image(), which is basically:

40% ``load_data_heap()
15% ``load_code_heap()
40% fixup_heaps()

I wonder if we can make improvements to those algorithms or cache data differently to speed that up.


Windows: No file or directory cl.exe

(base) C:\WINDOWS\system32>pip install --verbose --no-cache-dir torch-scatter
Created temporary directory: C:\Users\user\AppData\Local\Temp\pip-ephem-wheel-
cache-ngmmj5o1
Created temporary directory: C:\Users\user\AppData\Local\Temp\pip-req-tracker-
9x2esplb
Created requirements tracker 'C:\Users\user\AppData\Local\Temp\pip-req-t
racker-9x2esplb'
Created temporary directory: C:\Users\user\AppData\Local\Temp\pip-install-52vk
92ny
Collecting torch-scatter
1 location(s) to search for versions of torch-scatter:

https://pypi.org/simple/torch-scatter/
Getting page https://pypi.org/simple/torch-scatter/
Found index url https://pypi.org/simple
Getting credentials from keyring for https://pypi.org/simple
Getting credentials from keyring for pypi.org
Starting new HTTPS connection (1): pypi.org:443
https://pypi.org:443 "GET /simple/torch-scatter/ HTTP/1.1" 200 1373
Analyzing links from page https://pypi.org/simple/torch-scatter/
Found link https://files.pythonhosted.org/packages/29/96/566ac314e796d4b0720
9a3b88cc7a8d2e8582d55819e33f72e6c0e8d8216/torch_scatter-0.3.0.tar.gz#sha256=9e5e
5a6efa4ef45f584e8611f83690d799370dd122b862646751ae112b685b50 (from https://pypi.
org/simple/torch-scatter/), version: 0.3.0
Found link https://files.pythonhosted.org/packages/6a/b0/ecffacddf573c147c70
c6e43ce05d24f007155ce3fb436959d3d2a24da46/torch_scatter-1.0.2.tar.gz#sha256=ccda
794c25265b3450206b7fb0bf74f16a0b45f3f72d9547a42e44648a32faee (from https://pypi.
org/simple/torch-scatter/), version: 1.0.2
Found link https://files.pythonhosted.org/packages/08/09/07b106f3e74246f4ecf
6517013a053b6dd7486c4f889d81f39adc662431f/torch_scatter-1.0.3.tar.gz#sha256=e626
993194819ba65cdf89a52fbbb7780569d9e157bc63dbef13ead6b7a33930 (from https://pypi.
org/simple/torch-scatter/), version: 1.0.3
Found link https://files.pythonhosted.org/packages/2d/70/df2bc259d9606f00854
ca43b6839f9047ec44900563435e0067584c93864/torch_scatter-1.0.4.tar.gz#sha256=ec00
4d687e47da9d5477407849d815629fc8b571ee87aeeebf6af8ed6f16defc (from https://pypi.
org/simple/torch-scatter/), version: 1.0.4
Found link https://files.pythonhosted.org/packages/2f/97/c50a6aeaedc6924180c
6f5810d2a7405ce11aa9b82ba4284badad549d665/torch_scatter-1.1.0.tar.gz#sha256=e534
cc2ecb2f9d9b559b1513cd411737d26ea5585d1d65ff571fec55f42a49de (from https://pypi.
org/simple/torch-scatter/), version: 1.1.0
Found link https://files.pythonhosted.org/packages/91/5f/eb1d3ef3810cb116585
9d40db4d9ee6d7f1dfef97d7e5c34010055f43d95/torch_scatter-1.1.1.tar.gz#sha256=9db7
f2c0a5cddf6cfde633e33db7c2c94eaab163e9f8edb46460d6414cc97917 (from https://pypi.
org/simple/torch-scatter/), version: 1.1.1
Found link https://files.pythonhosted.org/packages/d4/83/67eeea00c2db1959e2f
f95d8680dbd756977bfab254bda8658f09dc3bc11/torch_scatter-1.1.2.tar.gz#sha256=766c
2476f5da5ffc25fa8e249ccf50f594031cdce3922abb23559e8e3b14337a (from https://pypi.
org/simple/torch-scatter/), version: 1.1.2
Found link https://files.pythonhosted.org/packages/07/c0/f7ac424496f4a3bcb31
aa993fba29077a6d42fc2624c66e90b58a566a98e/torch_scatter-1.2.0.tar.gz#sha256=3a02
59105d07d264c740eec8e4267260a5c144cf55472abd26022fff4fd73281 (from https://pypi.
org/simple/torch-scatter/), version: 1.2.0
Found link https://files.pythonhosted.org/packages/24/b7/680c3b392a4b55a0ebf
b480aabb0d5c188e94bb21790104175c8cd614947/torch_scatter-1.3.0.tar.gz#sha256=bf7d
561b8ef12b39a99f5797c90b989a0ce2c3ee4de74dff3b170f2d8566e1d4 (from https://pypi.
org/simple/torch-scatter/), version: 1.3.0
Found link https://files.pythonhosted.org/packages/35/d4/750403a8aa32cdb3d2d
05849c6a10e4e0604de5e0cc94b81a0d0d69a75f3/torch_scatter-1.3.1.tar.gz#sha256=54cb
ad248350165ddc921ded3fe7a69be5d30c6536273a1a3282e375289f86ec (from https://pypi.
org/simple/torch-scatter/), version: 1.3.1
Found link https://files.pythonhosted.org/packages/30/d9/1d5fd4d183dabd9e0a1
f7008ecf83318432359f4cc27480e3f2212f44d9c/torch_scatter-1.3.2.tar.gz#sha256=890e
8f9da2d57431912182960b71bf6c56397de42c2464907a6e9c583164bf06 (from https://pypi.
org/simple/torch-scatter/), version: 1.3.2
Found link https://files.pythonhosted.org/packages/b8/c3/8bad887ffa55c86f120
ef5ae252dc0e357b3bd956d9fbf45242bacc46290/torch_scatter-1.4.0.tar.gz#sha256=5999
ef256154e5a99445118c1a53f95cf0f95ef7b5cd8d3b256101125479cc2e (from https://pypi.
org/simple/torch-scatter/), version: 1.4.0
Found link https://files.pythonhosted.org/packages/28/f7/fa4e61587169924203a
32416f7835939fdd79994eaa429b4f8ef8f0e07e2/torch_scatter-2.0.2.tar.gz#sha256=49d3
059b7be93d3f2c328fdc6daa3a8479e3dc4a50c8247aef913177122db671 (from https://pypi.
org/simple/torch-scatter/), version: 2.0.2
Config variable 'Py_DEBUG' is unset, Python ABI tag may be incorrect
Config variable 'WITH_PYMALLOC' is unset, Python ABI tag may be incorrect
Given no hashes to check 13 links for project 'torch-scatter': discarding no c
andidates
Using version 2.0.2 (newest of versions: 0.3.0, 1.0.2, 1.0.3, 1.0.4, 1.1.0, 1.
1.1, 1.1.2, 1.2.0, 1.3.0, 1.3.1, 1.3.2, 1.4.0, 2.0.2)
Created temporary directory: C:\Users\user\AppData\Local\Temp\pip-unpack-jir
ugdmm
Getting credentials from keyring for files.pythonhosted.org
Starting new HTTPS connection (1): files.pythonhosted.org:443
https://files.pythonhosted.org:443 "GET /packages/28/f7/fa4e61587169924203a324
16f7835939fdd79994eaa429b4f8ef8f0e07e2/torch_scatter-2.0.2.tar.gz HTTP/1.1" 200
22431
Downloading https://files.pythonhosted.org/packages/28/f7/fa4e61587169924203a3
2416f7835939fdd79994eaa429b4f8ef8f0e07e2/torch_scatter-2.0.2.tar.gz
Downloading from URL https://files.pythonhosted.org/packages/28/f7/fa4e6158716
9924203a32416f7835939fdd79994eaa429b4f8ef8f0e07e2/torch_scatter-2.0.2.tar.gz#sha
256=49d3059b7be93d3f2c328fdc6daa3a8479e3dc4a50c8247aef913177122db671 (from https
://pypi.org/simple/torch-scatter/)
Added torch-scatter from https://files.pythonhosted.org/packages/28/f7/fa4e615
87169924203a32416f7835939fdd79994eaa429b4f8ef8f0e07e2/torch_scatter-2.0.2.tar.gz
#sha256=49d3059b7be93d3f2c328fdc6daa3a8479e3dc4a50c8247aef913177122db671 to buil
d tracker 'C:\Users\user\AppData\Local\Temp\pip-req-tracker-9x2esplb'
Running setup.py (path:C:\Users\user\AppData\Local\Temp\pip-install-52vk92
ny\torch-scatter\setup.py) egg_info for package torch-scatter
Running command python setup.py egg_info
running egg_info
creating pip-egg-info\torch_scatter.egg-info
writing pip-egg-info\torch_scatter.egg-info\PKG-INFO
writing dependency_links to pip-egg-info\torch_scatter.egg-info\dependency_l
inks.txt
writing top-level names to pip-egg-info\torch_scatter.egg-info\top_level.txt
writing manifest file 'pip-egg-info\torch_scatter.egg-info\SOURCES.txt'
reading manifest file 'pip-egg-info\torch_scatter.egg-info\SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'pip-egg-info\torch_scatter.egg-info\SOURCES.txt'
Source in c:\users\user\appdata\local\temp\pip-install-52vk92ny\torch-scatte
r has version 2.0.2, which satisfies requirement torch-scatter from https://file
s.pythonhosted.org/packages/28/f7/fa4e61587169924203a32416f7835939fdd79994eaa429
b4f8ef8f0e07e2/torch_scatter-2.0.2.tar.gz#sha256=49d3059b7be93d3f2c328fdc6daa3a8
479e3dc4a50c8247aef913177122db671
Removed torch-scatter from https://files.pythonhosted.org/packages/28/f7/fa4e6
1587169924203a32416f7835939fdd79994eaa429b4f8ef8f0e07e2/torch_scatter-2.0.2.tar.
gz#sha256=49d3059b7be93d3f2c328fdc6daa3a8479e3dc4a50c8247aef913177122db671 from
build tracker 'C:\Users\user\AppData\Local\Temp\pip-req-tracker-9x2esplb
'
Building wheels for collected packages: torch-scatter
Created temporary directory: C:\Users\user\AppData\Local\Temp\pip-wheel-ilyg
ru5u
Building wheel for torch-scatter (setup.py) ...   Destination directory: C:\Us
ers\user\AppData\Local\Temp\pip-wheel-ilygru5u
Running command 'C:\Users\user\Anaconda3\python.exe' -u -c 'import sys, setu
ptools, tokenize; sys.argv[0] = '"'"'C:\Users\user\AppData\Local\Temp\pi
p-install-52vk92ny\torch-scatter\setup.py'"'"'; file='"'"'C:\Users\Ismai
l\AppData\Local\Temp\pip-install-52vk92ny\torch-scatter\setup.py'"'"';f=ge
tattr(tokenize, '"'"'open'"'"', open)(file);code=f.read().replace('"'"'\r\n'
"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' bdi
st_wheel -d 'C:\Users\user\AppData\Local\Temp\pip-wheel-ilygru5u' --python-tag
cp37
running bdist_wheel
running build
running build_py
creating build
creating build\lib.win-amd64-3.7
creating build\lib.win-amd64-3.7\test
copying test\test_broadcasting.py -> build\lib.win-amd64-3.7\test
copying test\test_gather.py -> build\lib.win-amd64-3.7\test
copying test\test_multi_gpu.py -> build\lib.win-amd64-3.7\test
copying test\test_scatter.py -> build\lib.win-amd64-3.7\test
copying test\test_segment.py -> build\lib.win-amd64-3.7\test
copying test\test_zero_tensors.py -> build\lib.win-amd64-3.7\test
copying test\utils.py -> build\lib.win-amd64-3.7\test
copying test_init_.py -> build\lib.win-amd64-3.7\test
creating build\lib.win-amd64-3.7\torch_scatter
copying torch_scatter\scatter.py -> build\lib.win-amd64-3.7\torch_scatter
copying torch_scatter\segment_coo.py -> build\lib.win-amd64-3.7\torch_scatter
copying torch_scatter\segment_csr.py -> build\lib.win-amd64-3.7\torch_scatter
copying torch_scatter\utils.py -> build\lib.win-amd64-3.7\torch_scatter
copying torch_scatter_init_.py -> build\lib.win-amd64-3.7\torch_scatter
creating build\lib.win-amd64-3.7\torch_scatter\composite
copying torch_scatter\composite\logsumexp.py -> build\lib.win-amd64-3.7\torch_
scatter\composite
copying torch_scatter\composite\softmax.py -> build\lib.win-amd64-3.7\torch_sc
atter\composite
copying torch_scatter\composite\std.py -> build\lib.win-amd64-3.7\torch_scatte
r\composite
copying torch_scatter\composite_init_.py -> build\lib.win-amd64-3.7\torch_s
catter\composite
running build_ext
C:\Users\user\Anaconda3\lib\site-packages\torch\utils\cpp_extension.py:209:
UserWarning: Error checking compiler version for cl: [WinError 2] The system can
not find the file specified
warnings.warn('Error checking compiler version for {}: {}'.format(compiler,
error))
building 'torch_scatter._scatter' extension
creating build\temp.win-amd64-3.7
creating build\temp.win-amd64-3.7\Release
creating build\temp.win-amd64-3.7\Release\Users
creating build\temp.win-amd64-3.7\Release\Users\user
creating build\temp.win-amd64-3.7\Release\Users\user\AppData
creating build\temp.win-amd64-3.7\Release\Users\user\AppData\Local
creating build\temp.win-amd64-3.7\Release\Users\user\AppData\Local\Temp
creating build\temp.win-amd64-3.7\Release\Users\user\AppData\Local\Temp\pip-
install-52vk92ny
creating build\temp.win-amd64-3.7\Release\Users\user\AppData\Local\Temp\pip-
install-52vk92ny\torch-scatter
creating build\temp.win-amd64-3.7\Release\Users\user\AppData\Local\Temp\pip-
install-52vk92ny\torch-scatter\csrc
creating build\temp.win-amd64-3.7\Release\Users\user\AppData\Local\Temp\pip-
install-52vk92ny\torch-scatter\csrc\cpu
creating build\temp.win-amd64-3.7\Release\Users\user\AppData\Local\Temp\pip-
install-52vk92ny\torch-scatter\csrc\cuda
cl.exe /c /nologo /Ox /W3 /GL /DNDEBUG /MD -DWITH_CUDA -IC:\Users\user\AppDa
ta\Local\Temp\pip-install-52vk92ny\torch-scatter\csrc -IC:\Users\user\Anaconda
3\lib\site-packages\torch\include -IC:\Users\user\Anaconda3\lib\site-packages
torch\include\torch\csrc\api\include -IC:\Users\user\Anaconda3\lib\site-packag
es\torch\include\TH -IC:\Users\user\Anaconda3\lib\site-packages\torch\include
THC "-IC:\Program Files\NVIDIA GPU Computing Toolkit\include" -IC:\Users\user
Anaconda3\include -IC:\Users\user\Anaconda3\include /EHsc /TpC:\Users\user\A
ppData\Local\Temp\pip-install-52vk92ny\torch-scatter\csrc\scatter.cpp /Fobuild\t
emp.win-amd64-3.7\Release\Users\user\AppData\Local\Temp\pip-install-52vk92ny\t
orch-scatter\csrc\scatter.obj /MD /wd4819 /EHsc -O0 /MP -DTORCH_API_INCLUDE_EXTE
NSION_H -DTORCH_EXTENSION_NAME=_scatter -D_GLIBCXX_USE_CXX11_ABI=0
error: command 'cl.exe' failed: No such file or directory
error
ERROR: Failed building wheel for torch-scatter
Running setup.py clean for torch-scatter
Running command 'C:\Users\user\Anaconda3\python.exe' -u -c 'import sys, setu
ptools, tokenize; sys.argv[0] = '"'"'C:\Users\user\AppData\Local\Temp\pi
p-install-52vk92ny\torch-scatter\setup.py'"'"'; file='"'"'C:\Users\Ismai
l\AppData\Local\Temp\pip-install-52vk92ny\torch-scatter\setup.py'"'"';f=ge
tattr(tokenize, '"'"'open'"'"', open)(file);code=f.read().replace('"'"'\r\n'
"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' cle
an --all
Cleaning up...
Removing source in C:\Users\user\AppData\Local\Temp\pip-install-52vk92ny\tor
ch-scatter
Removed build tracker 'C:\Users\user\AppData\Local\Temp\pip-req-tracker-
9x2esplb'

****** Note: *********
I have:
Python --version= 3.7.4
Pytorch version = 1.4.0
conda --version = 4.8.2
cuda --version = 10.1
windows = 8.1
Before this installation,  I also tried with visual studio 2019 and it couldn't find stddef.h because it is located in the Windows kit. After adding the appropriate environment variables (Include, bin, Lib), it caused cl.exe error.
Any suggestions?

Further to my previous issue, I have downloaded torch-scatter, torch-sparse from amazon cloud wheels links provided by @rusty1s  , It works fine and I still need to download torch-cluster.
Is there any link for building wheel for torch-cluster?

Not yet, I am working on it! PyG on master does not require torch-cluster though with the latest commit. It is now an optional dependency.

Based on your reply, Data function will not work anymore, however PyG works fine.
from torch_geometric.data import Data: this is not going to work?

Are you in the pytorch_geometric dictionary when running the command? This may lead to this strange error.

import torch
import torch_geometric
 in
4
5 import torch
----> 6 import torch_geometric
7 from torch_sparse import coalesce
8
1 from .debug import is_debug_enabled, debug, set_debug
----> 2 import torch_geometric.nn
3 import torch_geometric.data
4 import torch_geometric.datasets
5 import torch_geometric.transforms
1 from .meta import MetaLayer
----> 2 from .data_parallel import DataParallel
3 from .reshape import Reshape
4 from .conv import *  # noqa
5 from .norm import *  # noqa
3
4 import torch
----> 5 from torch_geometric.data import Batch
6
7

4 from .in_memory_dataset import InMemoryDataset
5 from .dataloader import DataLoader, DataListLoader, DenseDataLoader
----> 6 from .sampler import NeighborSampler
7 from .download import download_url
8 from .extract import extract_tar, extract_zip, extract_bz2, extract_gz
3
4 import torch
----> 5 from torch_cluster import neighbor_sampler
6 import torch_geometric
7 from torch_geometric.data import Data
ModuleNotFoundError: No module named 'torch_cluster'

You need to install PyG from source. Did you do that? Just clone the repo and runpython setup.py install inside of it.

Thank you a lot, Very appreciated.
After cloning the repo from source and running python setup.py instead of (pip install torch-geometric), everything works fine


TKMM won't open

I have tried removing tkmm from my computer and re-installing it several times, but every time I can only open the program once, and then when I click on the shortcut I get this error

Duplicate of https://github.com/TKMM-Team/Tkmm/issues/29.
Delete %localappdata%\tkmm\Config.json to resolve the issue until the next TKMM release.