Bash script containing examples of tower-cli use

This bash script generates fake data. Several things are necessary in order to use it:

Config variables are set to a valid host, username, and password
You have fake user accounts user1 and user2, as described in the docs

There is also a script to attempt to remote the same data that was created.
It is hoped that this will be a good addition to the examples in the README file, giving much more complete examples of using tower-cli.

Looks good, thanks!  Please merge at your convenience.


Node does not exist for SceneGroupItemBlock: None

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/local/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/app/remarks/__main__.py", line 151, in <module>
    main()
  File "/app/remarks/__main__.py", line 147, in main
    run_remarks(input_dir, output_dir, **args_dict)
  File "/app/remarks/remarks.py", line 96, in run_remarks
    process_document(metadata_path, out_path, doc_type, **kwargs)
  File "/app/remarks/remarks.py", line 271, in process_document
    (ann_data, has_ann_hl), version = parse_rm_file(ann_rm_file)
  File "/app/remarks/conversion/parsing.py", line 259, in parse_rm_file
    return parse_v6(file_path), "V6"
  File "/app/remarks/conversion/parsing.py", line 128, in parse_v6
    dims = determine_document_dimensions(file_path)
  File "/app/remarks/conversion/parsing.py", line 183, in determine_document_dimensions
    build_tree(tree, blocks)
  File "/app/.venv/lib/python3.10/site-packages/rmscene/scene_stream.py", line 773, in build_tree
    raise ValueError(
    ValueError: Node does not exist for SceneGroupItemBlock: None`

def build_tree(tree: SceneTree, blocks: Iterable[Block]):
    for b in block:
        if ...:
            ...
        elif isinstance(b, SceneGroupItemBlock):
            # Add this entry to children of parent_id
            node_id = b.item.value
            # if node_id == None:
                # continue
            if node_id not in tree:
                raise ValueError(
                    "Node does not exist for SceneGroupItemBlock: %s" % node_id
                )
            item = replace(b.item, value=tree[node_id])
            tree.add_item(item, b.parent_id)

Given that the value in the SceneGroupItemBlock is a tp.Optional[CrdtId] it's defined that it's ok to be None?
I added the commented continue if None code and there are no further errors in the document.
Am I correct in assuming it's ok to just skip it if it's None given that the value is optionally typed?

@ricklupton I'm learning :smile:

I'd expect in this case that the b.item.deleted_length was nonzero, and this was a deleted group that is no longer part of the drawing? If so it makes sense that node_id could be None and your fix would be good.


Add "script" setting to commands that runs as a bash script

We should add a new setting to the commands struct called script that accepts a bash script as a string that we run. When running the script, we can set the $NAMESPACE and $KUBECONFIG variables. This will allow users to more easily write scripts inline when necessary.
apiVersion: kudo.dev/v1alpha1
kind: TestStep
commands:
- script: until ! kubectl get pod --namespace $NAMESPACE my-pod; do sleep 1; done

note the example there can be achieved using kubectl wait --for=delete pod --namespace $NAMESPACE my-pod

I have the following questions:

currently Commands []Command json:"commands" is an array of Command I don't know how to union a type in an array (is that possible)...
we could keep it of type Command and add a "Script string " to the Command struct.. but that feels slightly awkward.. we to do if a command and a script is supplied?  we could some validation to error on it... or ignore one... but then I'm not sure if Background makes senses.
What do you think of replacing script: for a specific script shell... I think I prefer to impl bash: instread... if we go that route perhaps we have a separate collections of scripts: like:

scripts:
  - bash: until ! kubectl get pod --namespace $NAMESPACE my-pod; do sleep 1; done

thoughts?

the unfortunate part of a separate collection is ordering... you may want to run a command before a script or vise versa 🤔


Force closed channel stuck in Limbo past maturity

Background
Since the last update to v0.16.3 I have a peculiar issue on two of my nodes, where force closed channels are stuck in Limbo. I checked previous issues like this, but suggested resolutions don't work.
Your environment

version of lnd v0.16.3
which operating system (uname -a on *Nix) Debian 11 (Host) - golang:1.19.2-alpine (Docker)
version of btcd, bitcoind, or other backend - bitcoind via Neutrino
any other relevant environment details

Steps to reproduce
After upgrade to new version, from 0.16.2
Expected behaviour
Channels are recognized as past maturity, so sats should be in onchain wallet, channels should not be in Limbo.
Actual behaviour
Channels are stuck in Limbo, even though closing transaction and maturity are detected correctly, here is one example:
"pending_force_closing_channels": [
{
"channel": {
"remote_node_pub": "03d58a9b39eaa2edc19ed2a98e74887e538e5dd3694d9580419bfac839d993f358",
"channel_point": "83ad47a6e0db46a7ef164044f04fe285ff10c38715889769b2b6816048afa765:1",
"capacity": "1500000",
"local_balance": "840",
"remote_balance": "1495690",
"local_chan_reserve_sat": "0",
"remote_chan_reserve_sat": "0",
"initiator": "INITIATOR_REMOTE",
"commitment_type": "ANCHORS",
"num_forwarding_packages": "0",
"chan_status_flags": "",
"private": false
},
"closing_txid": "435d1f952eb5de010be18d14be2b1b7a0e6124423a8d31a8e0f628628f8d0ef4",
"limbo_balance": "1170",
"maturity_height": 794465,
"blocks_til_maturity": -1686,
"recovered_balance": "0",
"pending_htlcs": [
],
"anchor": "LIMBO"
}
],
"waiting_close_channels": [
]
}
Already tried rescanning the chain, didn't help.

"local_balance": "840",

You have a very small amount pending to be swept. At the current fee rate, lnd won't automatically sweep it as we may pay more in fees than the actual channel amount. Once fees come down, then this can be swept eventually, or you can force it to be swept (likely paying more than the amt for it to be swept).

That cannot be the reason. The transaction was confirmed over 2016 blocks ago. Also one of the other stuck channels has 4 Mio. of my sats in Limbo.

Lnd will only move the channel from pending_force_closing_channels  to the final closedchannels if all contract which belong to you are resolved. In your shown case as Roasbeef pointed out there is the to_local output of 840 sats which are not economical to sweep at current fee-conditions so the contract remains open therefore the channel still appears in the pending_force_closing_channels  list. Could you show the problem with the other channel where you say that 4 mio are still in limbo ?

The other channel has in the meantime switched to closed state, but my node still shows the Sats as pending and unspendable.
https://mempool.space/address/bc1qyf9grjjptcgs888ttl2nwx7nf04t0v7fwc4qq4n4dy9cn4lgsvaqpxlpsj
Can you please clarify if I fundamentally misunderstand how Lightning works… I had understood that the sweep of Sats is when the channel transaction is broadcast to the miners.
You make it sound like a second on-chain transaction was necessary for that.

The other channel has in the meantime switched to closed state, but my node still shows the Sats as pending and unspendable.

Not sure why they are shown unspendable in your situation. You do not see this utxo (3e603255556e2debed1b2de4005090ea884eff292f31b107719b850ab09c24ac:0) in your lncli listunspent output? The chain makes it clear that the funds are already in a wallet (using a p2tr address which lnd currently uses for its user-controlled wallet)

Can you please clarify if I fundamentally misunderstand how Lightning works… I had understood that the sweep of Sats is when the channel transaction is broadcast to the miners.

So there are plenty of resources out there, I try to make a short explanation. In case a contract (channel) has to be resolved onchain alias "force closed" there are different set of outputs (alias contracts) on the commitment transaction which have different requirements when these can be taken (swept by the owner). When you force-close the channel your funds on the commitment tx are locked. They need a second sweep transaction when the lock expires to take it back into your normal wallet. HTLC outputs on the commitment tx which belong to you have a 2-stage locking meaning that you will have to sweep them 2 times until they are available to your wallet. For detailed infos see Bolt3. Until all those outputs which belong to you are still not swept, this channel is in a pending state.
In regards of your 4 mio output tx, these funds should. be available. So there we need more info why they seem to be unspendable in your case.

Closing this issue based on the explanations provided above, if you still have questions, feel free to reopen.

@ziggie1984 I was hoping for this to resolve itself, aber even after restarting and rescanning the chain I still have this issue that two transactions totaling over 5 million Sats are flagged as pending, cannot be spent.
I checked lncli listunspent they are listed, here the 4mio:
"address_type": 4,
"address": "bc1pw58xdf247wrv7jzt94c9avrf3j2zurvckpcalahdwvc33lvemdysqjctsh",
"amount_sat": 4523226,
"pk_script": "5120750e66a555f386cf484b2d705eb0698c942e0d98b071dff6ed733118fd99db49",
"outpoint": "b31aa27944dd3d6d12c8905b40d24775d1dafd467fc24116488b4c1141ad0329:0",
"confirmations": 0

@ziggie1984 I was hoping for this to resolve itself, but even after restarting and rescanning the chain I still have this issue that two transactions totaling over 5 million Sats are flagged as pending, cannot be spent.

I think you ran most likely in this problem: #7790
Could you change the backend and let it resolve itself for you?  I think this transaction blocks one of your inputs as described in the linked issue. Backend switch is the only solution here for now,  because then this invalid transaction will be rebroadcasted but immediately removed because a full-node gives you an error when broadcasting a transaction without a valid (unkown) previous output. Neutrino however will mark it as orphan and will be just fine.

Thanks for the response, the current setup on this node doesn't give me the option to directly connect a full bitcoin node. Any other ideas?

One other solution: Setup a pruned node maybe that would suffice as well, you just need a mempool for the fix.
If that's not available there is still another method.
So this other method involves psbts which is not super easy but if you are a technical person should be doable as well:

You need to know which input is locked by this never confirming transaction, normally when restarting lnd look for the transaction with this txid: b31aa27944dd3d6d12c8905b40d24775d1dafd467fc24116488b4c1141ad0329  and check the logs there must be also the hex-tx logged somewhere.

When you were able to fish this transaction you need someone with a running bitcoin node (pruned or normal does not matter). And run bitcoin-cli decoderawtransaction <hex transaction>. There we can extract the input which you would like to spend but is currently locked. When you have this txid of the input the psbt creating process begins.

You or someone with a btc node creates a psbt with the inputs and outputs you want. Use the following command

bitcoin-cli  createpsbt "[{\"txid\":\"310468bfa056cc7fec627aea2040b3c198445af7c191d5df74633f9cabc9b3b6\",\"vout\":1}]" "[{\"bcrt1pdrhytxncrlpuafn67uu5p8d2748n2uk2kgaq3tqn53ldj653rejsrw4q6d\":0.97993080}]"
=> Result: cHNidP8BAF4CAAAAAbazyaucP2N039WRwfdaRJjBs0Ag6npi7H/MVqC/aAQxAQAAAAD9////AXhB1wUAAAAAIlEgaO5Fmngfw86mevc5QJ2q9U81csqyOgisE6R+2WqRHmUAAAAAAAAA
Here the locked input is: 310468bfa056cc7fec627aea2040b3c198445af7c191d5df74633f9cabc9b3b6:1
the address is the output I want to receive funds to. Make sure you substract fees from the amount and they have to be sufficient to confirm soon. A tx with 1 input and 1 output has around 130 vbytes. So depending on your Inputs and outputs you create you have to account for sufficient fees.
Now you need to update the resulting psbt with information use the following command:
` bitcoin-cli  utxoupdatepsbt cHNidP8BAF4CAAAAAbazyaucP2N039WRwfdaRJjBs0Ag6npi7H/MVqC/aAQxAQAAAAD9////AXhB1wUAAAAAIlEgaO5Fmngfw86mevc5QJ2q9U81csqyOgisE6R+2WqRHmUAAAAAAAAA``
=> Result: cHNidP8BAF4CAAAAAbazyaucP2N039WRwfdaRJjBs0Ag6npi7H/MVqC/aAQxAQAAAAD9////AXhB1wUAAAAAIlEgaO5Fmngfw86mevc5QJ2q9U81csqyOgisE6R+2WqRHmUAAAAAAAEBK9lC1wUAAAAAIlEg+edkbYkKUOZIEwiRDoEgjJIVRIsYaUa3sGEB7QwlHOkAAA==
Almost done now:
Now you need to sign this transaction for this switch to your lightning node:
Signing the tx with the following command:
rlncli wallet psbt finalize cHNidP8BAF4CAAAAAbazyaucP2N039WRwfdaRJjBs0Ag6npi7H/MVqC/aAQxAQAAAAD9////AXhB1wUAAAAAIlEgaO5Fmngfw86mevc5QJ2q9U81csqyOgisE6R+2WqRHmUAAAAAAAEBK9lC1wUAAAAAIlEg+edkbYkKUOZIEwiRDoEgjJIVRIsYaUa3sGEB7QwlHOkAAA==

=> Result: { 	"psbt": "cHNidP8BAF4CAAAAAbazyaucP2N039WRwfdaRJjBs0Ag6npi7H/MVqC/aAQxAQAAAAD9////AXhB1wUAAAAAIlEgaO5Fmngfw86mevc5QJ2q9U81csqyOgisE6R+2WqRHmUAAAAAAAEBK9lC1wUAAAAAIlEg+edkbYkKUOZIEwiRDoEgjJIVRIsYaUa3sGEB7QwlHOkBCEIBQP1LH3LKGV8glMjDDwBfV6X8N2SBA0Ag4VgTprYHoVwb4HwnB+1/wH0d0huA2qQGzyN4+VcOwRuKU6u4BSIp5zkAAA==", 	"final_tx": "02000000000101b6b3c9ab9c3f6374dfd591c1f75a4498c1b34020ea7a62ec7fcc56a0bf6804310100000000fdffffff017841d7050000000022512068ee459a781fc3cea67af739409daaf54f3572cab23a08ac13a47ed96a911e650140fd4b1f72ca195f2094c8c30f005f57a5fc376481034020e15813a6b607a15c1be07c2707ed7fc07d1dd21b80daa406cf2378f9570ec11b8a53abb8052229e73900000000" }
Now you are done, you have the tx, double check the tx with the command: bitcoin-cli decoderawtransaction ...
If it is good broadcast it:
rlncli wallet publishtx --label "own-sweep"<PHONE_NUMBER>0101b6b3c9ab9c3f6374dfd591c1f75a4498c1b34020ea7a62ec7fcc56a0bf6804310100000000fdffffff017841d7050000000022512068ee459a781fc3cea67af739409daaf54f3572cab23a08ac13a47ed96a911e650140fd4b1f72ca195f2094c8c30f005f57a5fc376481034020e15813a6b607a15c1be07c2707ed7fc07d1dd21b80daa406cf2378f9570ec11b8a53abb8052229e73900000000

Now wait until a block is found and your balance should be resolved.

For questions, you can write me on the lnd slack ;)

One other solution: Setup a pruned node maybe that would suffice as well, you just need a mempool for the fix.
If that's not available there is still another method.
So this other method involves psbts which is not super easy but if you are a technical person should be doable as well:
1. You need to know which input is locked by this never confirming transaction, normally when restarting lnd look for the transaction with this txid: `b31aa27944dd3d6d12c8905b40d24775d1dafd467fc24116488b4c1141ad0329 ` and check the logs there must be also the hex-tx logged somewhere.

2. When you were able to fish this transaction you need someone with a running bitcoin node (pruned or normal does not matter). And run `bitcoin-cli decoderawtransaction <hex transaction>`. There we can extract the input which you would like to spend but is currently locked. When you have this txid of the input the psbt creating process begins.

3. You or someone with a btc node creates a psbt with the inputs and outputs you want. Use the following command

bitcoin-cli createpsbt "[{\"txid\":\"310468bfa056cc7fec627aea2040b3c198445af7c191d5df74633f9cabc9b3b6\",\"vout\":1}]" "[{\"bcrt1pdrhytxncrlpuafn67uu5p8d2748n2uk2kgaq3tqn53ldj653rejsrw4q6d\":0.97993080}]"
=> Result: cHNidP8BAF4CAAAAAbazyaucP2N039WRwfdaRJjBs0Ag6npi7H/MVqC/aAQxAQAAAAD9////AXhB1wUAAAAAIlEgaO5Fmngfw86mevc5QJ2q9U81csqyOgisE6R+2WqRHmUAAAAAAAAA
Here the locked input is: 310468bfa056cc7fec627aea2040b3c198445af7c191d5df74633f9cabc9b3b6:1
the address is the output I want to receive funds to. Make sure you substract fees from the amount and they have to be sufficient to confirm soon. A tx with 1 input and 1 output has around 130 vbytes. So depending on your Inputs and outputs you create you have to account for sufficient fees.
Now you need to update the resulting psbt with information use the following command:
` bitcoin-cli utxoupdatepsbt cHNidP8BAF4CAAAAAbazyaucP2N039WRwfdaRJjBs0Ag6npi7H/MVqC/aAQxAQAAAAD9////AXhB1wUAAAAAIlEgaO5Fmngfw86mevc5QJ2q9U81csqyOgisE6R+2WqRHmUAAAAAAAAA``
=> Result: cHNidP8BAF4CAAAAAbazyaucP2N039WRwfdaRJjBs0Ag6npi7H/MVqC/aAQxAQAAAAD9////AXhB1wUAAAAAIlEgaO5Fmngfw86mevc5QJ2q9U81csqyOgisE6R+2WqRHmUAAAAAAAEBK9lC1wUAAAAAIlEg+edkbYkKUOZIEwiRDoEgjJIVRIsYaUa3sGEB7QwlHOkAAA==
Almost done now:
Now you need to sign this transaction for this switch to your lightning node:
Signing the tx with the following command:
rlncli wallet psbt finalize cHNidP8BAF4CAAAAAbazyaucP2N039WRwfdaRJjBs0Ag6npi7H/MVqC/aAQxAQAAAAD9////AXhB1wUAAAAAIlEgaO5Fmngfw86mevc5QJ2q9U81csqyOgisE6R+2WqRHmUAAAAAAAEBK9lC1wUAAAAAIlEg+edkbYkKUOZIEwiRDoEgjJIVRIsYaUa3sGEB7QwlHOkAAA==

=> Result: { "psbt": "cHNidP8BAF4CAAAAAbazyaucP2N039WRwfdaRJjBs0Ag6npi7H/MVqC/aAQxAQAAAAD9////AXhB1wUAAAAAIlEgaO5Fmngfw86mevc5QJ2q9U81csqyOgisE6R+2WqRHmUAAAAAAAEBK9lC1wUAAAAAIlEg+edkbYkKUOZIEwiRDoEgjJIVRIsYaUa3sGEB7QwlHOkBCEIBQP1LH3LKGV8glMjDDwBfV6X8N2SBA0Ag4VgTprYHoVwb4HwnB+1/wH0d0huA2qQGzyN4+VcOwRuKU6u4BSIp5zkAAA==", "final_tx": "02000000000101b6b3c9ab9c3f6374dfd591c1f75a4498c1b34020ea7a62ec7fcc56a0bf6804310100000000fdffffff017841d7050000000022512068ee459a781fc3cea67af739409daaf54f3572cab23a08ac13a47ed96a911e650140fd4b1f72ca195f2094c8c30f005f57a5fc376481034020e15813a6b607a15c1be07c2707ed7fc07d1dd21b80daa406cf2378f9570ec11b8a53abb8052229e73900000000" }
Now you are done, you have the tx, double check the tx with the command: bitcoin-cli decoderawtransaction ...
If it is good broadcast it:
rlncli wallet publishtx --label "own-sweep"<PHONE_NUMBER>0101b6b3c9ab9c3f6374dfd591c1f75a4498c1b34020ea7a62ec7fcc56a0bf6804310100000000fdffffff017841d7050000000022512068ee459a781fc3cea67af739409daaf54f3572cab23a08ac13a47ed96a911e650140fd4b1f72ca195f2094c8c30f005f57a5fc376481034020e15813a6b607a15c1be07c2707ed7fc07d1dd21b80daa406cf2378f9570ec11b8a53abb8052229e73900000000

Now wait until a block is found and your balance should be resolved.

I have a comment on #7790. I am trying to understand issues here too because they correlate with my problem. If I have questions I will continuing to post here...


[#477] feat(spark): support getShuffleResult throws FetchFailedException.

What changes were proposed in this pull request?
feat #477
Why are the changes needed?
support getShuffleResult throws FetchFailedException.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Exiting UTs, Already added getShuffleResult failed, see MockedShuffleServerGrpcService.

cc @advancedxy  @jerqi  PTAL.

I try to shutdown a ShuffleServer during app running, it will throws FetchFailed, you can see here Fetch Failed image.

Codecov Report

Merging #1004 (f453b5b) into master (b759588) will increase coverage by 2.35%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #1004      +/-   ##
============================================
+ Coverage     53.57%   55.92%   +2.35%
+ Complexity     2511     2077     -434
============================================
  Files           378      307      -71
  Lines         20528    13262    -7266
  Branches       1773     1240     -533
============================================
- Hits          10997     7417    -3580
+ Misses         8835     5430    -3405
+ Partials        696      415     -281

Impacted Files
Coverage Δ

...he/uniffle/client/impl/ShuffleWriteClientImpl.java
34.55% <0.00%> (-0.09%)
:arrow_down:

... and 73 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Seems flaky test.

I will raise sub PRs to address the following problem:

Create a new rpc interface to report failures in batch
move getShuffleResult into ShuffleReadClient
get result part move to RssShuffleReader

Flaky test.

LGTM, except one minor comment. Thanks for your work.

cc @smallzhongfeng   , Can you help review plz?

you can run this command to fix spotless issues.
mvn spotless:apply -Pspark3 -Pspark2 -Ptez -Pmr -Phadoop2.8

mvn spotless:apply -Pspark3 -Pspark2 -Ptez -Pmr -Phadoop2.8

Thank you. Already fixed.

Merged to master.


when producing documents and using projections, recycle a velocypack::Builder

Scope & Purpose
When producing documents and using projections, recycle a velocypack::Builder
Additionally, use an optimized method for storing data in the target AqlItemBlock

[x] Strictly new functionality (i.e. a new feature / new option, no need for porting)
[x] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
[x] The behavior change can be verified via automatic tests

Testing & Verification
This change is already covered by existing tests, such as shell_server_aql.
http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/10284/

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/10298/

Tests blue


Watch all namespaces by default

What type of PR is this?

/kind feature

What this PR does / why we need it:
We decided that the operator should watch every namespace, therefore we can deploy profiles from every namespace.
Which issue(s) this PR fixes:
Fixes #40
Special notes for your reviewer:
Different to what we discussed by opted for not pushing the profiles of the "seccomp-operator" namespace in to the top-level directory. They'll end up in a namespace dir just as any other profile. IMO handling the "seccomp-operator" differently would just make the implementation more difficult without adding too much value.
Does this PR introduce a user-facing change?
seccomp profiles can be created in any namespace now.  Profiles end up in different subdirectories per namespace.

/ok-to-test

Marked this as a Draft for now as I'll be afk for some time. @saschagrunert  will hopefully take over from here :wink: otherwise I'll followup when I am back.

Marked this as a Draft for now as I'll be afk for some time. @saschagrunert will hopefully take over from here 😉 otherwise I'll followup when I am back.

Sure thing. 👍

Ready for review, PTAL @pjbgf @hasheddan

/kind feature

The go mod download seems to flake from time to time
/retest

/retest

/retest

/approve


The first date is always missing in the x axis

Any idea how to fix this?

Hi @sf-wind
Unfortunately due to the nature of financetime, it requires at least 2 points in order for it to calculate the ticks. I haven't specifically catered for this scenario of elements displayed <= max ticks. It's not something i generally do, only when zoomed in. In that case I am generally displaying a small portion of a much wider dataset, giving financetime enough data to calculate the ticks.
To work around it for the moment until the feature is implemented, you would need is to add another datapoint before your charted data start (off chart).
andre

Unfortunately this issue not only happens for the first date with small dataset, but also happens whenever the retrieved date is a bit smaller than the calculated tick date.
For example, in an intraday plot, the calculated intervalRange is:
[Tue Nov 17 2015 07:00:00 GMT-0800 (PST), Tue Nov 17 2015 07:30:00 GMT-0800 (PST), Tue Nov 17 2015 08:00:00 GMT-0800 (PST), ...

However, the retrieved data from Yahoo around 7:00am are:
28: Tue Nov 17 2015 06:58:59 GMT-0800 (PST)
29: Tue Nov 17 2015 06:59:59 GMT-0800 (PST)
30: Tue Nov 17 2015 07:00:59 GMT-0800 (PST)
31: Tue Nov 17 2015 07:01:00 GMT-0800 (PST)
32: Tue Nov 17 2015 07:02:02 GMT-0800 (PST)

Note the dates are not aligned nicely with intervalRange, the current behavior would return the date for
 30: Tue Nov 17 2015 07:00:59 GMT-0800 (PST)

But it should return the date for
29: Tue Nov 17 2015 06:59:59 GMT-0800 (PST)

Because d3_bisect function is used, which always returns the next greater value than the tick date, but that is not the closest.


Setting customized sdk url and sdk resource as non customized ignores the sdk resource value #2097

Sign out: Yee Lin
Date: Jan 22nd, 2022
Issue: #2097

Cannot pass Grinder tests if set SDK_URL = nightly and CUSTOMIZED_SDK_URL is not empty. Here is the link to Grinder test: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/3188/console

We need to clarify what behaviours we expect to happen in this code:

SDK_RESOURCE value
CUSTOMIZED_SDK_URL value
JDK_IMPL
Expected behaviour

nightly
""
hotspot
Fetch the latest nightly EA binary from the adoptium API

nightly
""
openj9
Fetch the latest nightly binary from the adoptium API - this is a very old build, we should probably just print a warning

nightly
Top-level link to OpenJ9 artifactory
openj9
Fetch nightly build from OpenJ9 artifactory

releases
""
hotspot
Fetch the latest release GA binary from the adoptium API

releases
""
openj9

customized
""
hotspot or openj9
Print the newly added error added in this PR

customized
A link to a binary ending in tar.gz or zip
hotspot or openj9
Try to fetch the binary defined in the CUSTOMIZED_SDK_URL

| SDK_RESOURCE value  | CUSTOMIZED_SDK_URL value | JDK_IMPL | Grinder to verify |
| ------------- | ------------- |
| Content Cell  | Content Cell  |
| Content Cell  | Content Cell  |

For SDK_RESOURCE=upstream, need to also provide UPSTREAM_JOB_NAME=build-scripts/jobs/jdk8u/jdk8u-linux-x64-hotspot and UPSTREAM_JOB_ID=1151
https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-linux-x64-hotspot/1151/

For SDK_RESOURCE=upstream, need to also provide UPSTREAM_JOB_NAME=build-scripts/jobs/jdk8u/jdk8u-linux-x64-hotspot and UPSTREAM_JOB_NUMBER=1151 to the Grinder
https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-linux-x64-hotspot/1151/

Thx for clarification!

Could you also check the following case:

SDK_RESOURCE value
CUSTOMIZED_SDK_URL value
JDK_IMPL
Grinder to verify

releases
"any non empty url  "
hotspot

which can rerun Grinder/3203 with non empty CUSTOMIZED_SDK_URL. This is the case this PR is fixing.

@YeeSkywalker - can you please run the one additional Grinder that @sophia-guo suggests in https://github.com/adoptium/aqa-tests/pull/3266#issuecomment-1020379675 ?

Could you also check the following case:
SDK_RESOURCE value	CUSTOMIZED_SDK_URL value	JDK_IMPL	Grinder to verify
releases	"any non empty url "	hotspot
which can rerun Grinder/3203 with non empty CUSTOMIZED_SDK_URL. This is the case this PR is fixing.

Hi Sophia, I have updagted the test table and the Grinder link to the new test is Grinder/3294

SDK_RESOURCE value
CUSTOMIZED_SDK_URL value
JDK_IMPL
Grinder to verify

nightly
""
hotspot
Grinder/3198

nightly
""
openj9
Grinder/3201

nightly
Top-level link to OpenJ9 artifactory
openj9
Grinder/3230

releases
""
hotspot
Grinder/3203

releases
Any non empty url
hotspot
Grinder/3294

releases
""
openj9
Grinder/3207

customized
""
hotspot or openj9
Grinder/3192

customized
A link to a binary ending in tar.gz or zip
hotspot or openj9
Grinder/3226

upstream
""
hotspot or openj9
Grinder/3218

@YeeSkywalker - can you please run the one additional Grinder that @sophia-guo suggests in #3266 (comment) ?

Hi Shelley, I have updated the test table and the Grinder link to the new test is Grinder/3294

SDK_RESOURCE value
CUSTOMIZED_SDK_URL value
JDK_IMPL
Grinder to verify

nightly
""
hotspot
Grinder/3198

nightly
""
openj9
Grinder/3201

nightly
Top-level link to OpenJ9 artifactory
openj9
Grinder/3230

releases
""
hotspot
Grinder/3203

releases
Any non empty url
hotspot
Grinder/3294

releases
""
openj9
Grinder/3207

customized
""
hotspot or openj9
Grinder/3192

customized
A link to a binary ending in tar.gz or zip
hotspot or openj9
Grinder/3226

upstream
""
hotspot or openj9
Grinder/3218


Blog archive

Blog archive issues

there is not restriction that the current used has to be the author of the blog.
And blog was not saved but API is returning success.

Fixed PR


Fixed color picker crashes the engine on Linux

Operating system or device - Godot version:
Arch Linux 64 - Latest build, master branch
Issue description (what happened, and what was expected):
The fixed color picker (from pull request #7431) crashes the engine when being used:

ERROR: get_child: Index p_index out of size (data.children.size()).
At: scene/main/node.cpp:1521.

This also happens immediately when I try to open an old project. A new empty poject can be opened, but it crashes as soon as I try to use the color picker (in project settings, for example).
I reverted that commit, recompiled and it worked again. So it is definitely caused by it.
Steps to reproduce:
Create empty project. Open it. Go to project settings/Render. Click on the default background color to pick a new one.
Link to minimal example project (optional but very welcome):

It seems to work now (no crash anymore). However, the color picker doesn't look like it should:

And the crosshairs don't move at all when I'm clicking.

Yep, i have been testing this and want to fix it, but for some reason drawing colored polygons (non textured) is not working at all so it's a different issue, not sure if i can fix it.

I can't reproduce this crash (Linux, Godot 3.0 master), but I opened a new issue for the color picker glitch #8372

I'm closing this issue since the glitch has moved to #8372


Reload repository config while the bot is running

The bot loads configuration from a rust-bors.toml file, located in the root of the repositories attached to the bot. Currently, it only reloads them when the bot itself is restarted.
It should be able to reload them without restarting itself. Either periodically (e.g. every 30 minutes or so), or it should react to pushes to the main branch on the repository, and reload the config after each push (or if it finds out that the rust-bors.toml file was modified).

We should probably aim to match triagebot's behavior. I think that does a periodic refresh, but with a lower TTL (5 minutes?).

Yeah, it's probably for the best, as GH push webhooks can be lost.


Update to omniscidb 5.2.2

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Replaces #31.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender


[BACKLOG-27839] Replace In String Metadata Injection Boolean Values E…

…rror
Updated Replace in String Step, changing the following fields from int arrays to boolean arrays:

use_regex
whole_world
case_sensitive
is_unicode

Update fixes Metadata injection as well as, accepts "Y", "yes", "true" from the .ktr where previously only "yes" worked. Output of XML uses "yes" / "no" for backwards compatibility.

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'ui,engine' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'ui,engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/trans/steps/replacestring/ReplaceString.java
  engine/src/main/java/org/pentaho/di/trans/steps/replacestring/ReplaceStringData.java
  engine/src/main/java/org/pentaho/di/trans/steps/replacestring/ReplaceStringMeta.java
  engine/src/test/java/org/pentaho/di/trans/steps/replacestring/ReplaceStringMetaInjectionTest.java
  engine/src/test/java/org/pentaho/di/trans/steps/replacestring/ReplaceStringMetaTest.java
  engine/src/test/java/org/pentaho/di/trans/steps/replacestring/ReplaceStringTest.java
  ui/src/main/java/org/pentaho/di/ui/trans/steps/replacestring/ReplaceStringDialog.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes.  It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'ui,engine' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'ui,engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/trans/steps/replacestring/ReplaceString.java
  engine/src/main/java/org/pentaho/di/trans/steps/replacestring/ReplaceStringData.java
  engine/src/main/java/org/pentaho/di/trans/steps/replacestring/ReplaceStringMeta.java
  engine/src/test/java/org/pentaho/di/trans/steps/replacestring/ReplaceStringMetaInjectionTest.java
  engine/src/test/java/org/pentaho/di/trans/steps/replacestring/ReplaceStringMetaTest.java
  engine/src/test/java/org/pentaho/di/trans/steps/replacestring/ReplaceStringTest.java
  ui/src/main/java/org/pentaho/di/ui/trans/steps/replacestring/ReplaceStringDialog.java

Newly Fixed Tests:
org.pentaho.di.trans.step.mqtt.MQTTStreamSourceTest.testMultipleTopics:
:large_blue_circle: junit.framework.AssertionFailedError
junit.framework.AssertionFailedError
	at org.pentaho.di.trans.step.mqtt.MQTTStreamSourceTest.getQuickly(MQTTStreamSourceTest.java:276)
	at org.pentaho.di.trans.step.mqtt.MQTTStreamSourceTest.testMultipleTopics(MQTTStreamSourceTest.java:164)

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.trans.steps.checksum.CheckSumMeta

Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.core.injection.bean.BeanInjector

Branch Change: -0.6% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:

org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change: -0.4% :small_red_triangle_down:
Complexity Change: -0.5% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.step.BaseStep

Branch Change: -0.6% :small_red_triangle_down:
Complexity Change: -0.5% :small_red_triangle_down:
Instruction Change: -0.7% :small_red_triangle_down:
Line Change: -0.8% :small_red_triangle_down:
Method Change: -0.9% :small_red_triangle_down:

org.pentaho.di.trans.step.StepStatus

Branch Change: -3.3% :small_red_triangle_down:
Complexity Change: -1.6% :small_red_triangle_down:
Instruction Change: -1.5% :small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -1.1% :small_red_triangle_down:
Complexity Change: -1.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.replacestring.ReplaceString

Branch Change: -0.6% :small_red_triangle_down:
Instruction Change: -0.6% :small_red_triangle_down:
Line Change: -2.4% :small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceinsert.SalesforceInsertMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

Instruction Change: -0.2% :small_red_triangle_down:


[REQUEST] - Setup husky to run eslint and fix linter errors on pre-commit

Start Date
No response
Implementation PR
No response
Reference Issues
No response
Summary
We have a linter setup that should be run on the pre-commit hooks to automatically fix the issues or fail, if it can't.
Let's use husky for this.
Basic Example
N/A
Drawbacks
N/A
Unresolved questions
No response

can you assign this to me ?

go ahead @yhoungdev :)

ok thanks

ok thanks

@yhoungdev any news on the issue? I'm trying to solve quick things, so I just wanted to know how this is going 🙏
PS: did a PR that introduces husky already: https://github.com/comoser/baby-food-intro-api/pull/35

@yhoungdev will mark this as unassigned if I don't get an answer until end of day, today GMT. I appreciate the effort, but there are more people interested in performing this task, and the more actual contributions, the better


Code Review for [4pt] - Display number of likes for each item on the Homepage - Student A #12

Description
In this project, a tasks list structure was generated using javascript bundledthrough webpack.
General requirements

[x] There are no linter errors.
[x] Followed the Github flow.
[x] The documentation is professional.

HTML/CSS/JS requirements

[x] We followed the list of best practices for HTML & CSS.
[x] We followed the list of best practices for JavaScript.

Project requirements

Home page
The Involvement API to show the item likes.

Thank you for taking the time to review this pull request.

I am starting the review!


[web3torrent] Setup sample files

We should provide some real sample files to the app for users to try out our integration without having to explicitly upload a file of their own.

@spersico found this: https://github.com/webtorrent/webtorrent/blob/master/docs/free-torrents.md

And this: https://www.frostwire.com/featured-downloads


Misconfigured Discovery Service Provider

Describe the bug
DiscoveryV2 service provider is in the wrong META-INF file.  Hasn't appeared to cause any issues as all are loaded by the application ClassLoader.  This will cause problems for OSGi's service loader.

Need to update the bnd annotations to the official OSGi annotations also.


Passing JSON does not seem to work

GET functions work fine, but for POST functions, it does not seem that we can pass JSON objects.

Moved to #14 for a detailed issue


Lazily create the canvas element

Images are pretty rare at least in my usage patterns, we would save a bunch of work by not creating/attaching/resizing the canvas until the first time it's needed
I know I'm blocking on https://github.com/xtermjs/xterm.js/pull/4577 and will move this over when that goes in, trying to catch up 😅

Yes thats a good idea and should also help with https://github.com/microsoft/vscode/issues/187460.
We could even go one step further and remove the canvas for long living terminals, once the storage gets emptied (thus all image notions got finally removed from scrollback etc). Ofc this would create a tiny burden for canvas recreation upon the next image (which is a rather rare use case). Not sure if this helps much, it would at least save some resources on very big terminals.

:+1: good idea, I was thinking about that with a timeout but when it scrolls off is even better


Duplicate Warning Display in mainloop Function of main.c

Description
In the mainloop function of main.c, warning-level problems are currently being displayed twice, which may lead to redundant output and potential confusion for users.
Current Behavior

Warnings are first displayed immediately after starting playback (lines 30-33):

if (error->level == AUDIO_ERROR_LEVEL_WARNING) {
    const char *errorString = audioGetErrorString(error);
    fprintf(stderr, "Warning: %s\n", errorString);
}

The same warnings are displayed again at the end of each loop iteration (lines 91-94):

if (error->level == AUDIO_ERROR_LEVEL_WARNING) {
    const char *errorString = audioGetErrorString(error);
    fprintf(stderr, "Warning: %s\n", errorString);
}

Expected Behavior
Warnings should be displayed only once per occurrence, either at the beginning of playback or at the end of each loop iteration, but not both.
Proposed Solution
To fix this issue, we should choose only one location to display warnings and remove the other one

Thank you for pointing that out. I chose one location to display warning. Fixed with 9233f5836774153e486bd8b3b2bf8c9ac5c0f6d0


Feature: PCA plots are missing

PCA plots are commented out.
https://github.com/CCBR/RENEE/blob/10ace58d79f42a9b85e58500e117cba7db271aa2/workflow/Snakefile#L146 Why?

rules exist in separate smk file. Need R docker to run.

This will be available via reneeTools


Add snackbar for consistent app wide notifications

Proposed solution
Show notifications in snackbar instead of rendering them inside components. However, if notification type is closely related to that component (e.g. field errors in forms), keep those notifications rendered in components.
See material ui snackbar info https://material-ui.com/components/snackbars/
DoD (Definition of Done)
Snackbar implemented
Testing
unit test & end to end

This is somewhat done already but we can improve current codebase with few adjustments.
We have component for status message handling which shows errors in snackbar. We could modify this component to take parameter that indicates if message needs to be shown in snackbar.
I think we could use a redux state to trigger and add content for snackbar in status message handler and place the component in root of NewDraftWizard.


Crashes while trying to add a new service to an existing environment

Describe the bug
kam crashes while trying to add a new service to an existing environment
To Reproduce
Steps to reproduce the behavior:

Bootstrapped https://github.com/sbose78/graphtuitous using interactive mode

Tried adding a service to an existing env.

kam service add --env-name stage --app-name app-graphtuitous --service-name graphtuitous --sealed-secrets-ns sealed-secrets --sealed-secrets-svc sealed-secrets-controller --image-repo=quay.io/shbose/graphtuitous
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x220ad2a]

goroutine 1 [running]:
github.com/redhat-developer/kam/pkg/pipelines.serviceResources(0xc0008f0780, 0x28ac100, 0xc0008fd110, 0xc00089bc20, 0xc0008f0780, 0x0, 0x0)
	/Users/sbose/kam/pkg/pipelines/service.go:112 +0x91a
github.com/redhat-developer/kam/pkg/pipelines.AddService(0xc00089bc20, 0x28ac100, 0xc0008fd110, 0xc0008fd110, 0xc000571ce0)
	/Users/sbose/kam/pkg/pipelines/service.go:42 +0xb4
github.com/redhat-developer/kam/pkg/cmd/service.(*AddServiceOptions).Run(0xc0000cb578, 0x0, 0x0)
	/Users/sbose/kam/pkg/cmd/service/add.go:49 +0x83
github.com/redhat-developer/kam/pkg/cmd/genericclioptions.GenericRun(0x2879d00, 0xc0000cb578, 0xc0009182c0, 0xc0008d24d0, 0x0, 0xb)
	/Users/sbose/kam/pkg/cmd/genericclioptions/runnable.go:25 +0xf2
github.com/redhat-developer/kam/pkg/cmd/service.newCmdAdd.func1(0xc0009182c0, 0xc0008d24d0, 0x0, 0xb)
	/Users/sbose/kam/pkg/cmd/service/add.go:67 +0x5e
github.com/spf13/cobra.(*Command).execute(0xc0009182c0, 0xc0008d2420, 0xb, 0xb, 0xc0009182c0, 0xc0008d2420)
	/Users/sbose/go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:846 +0x29d
github.com/spf13/cobra.(*Command).ExecuteC(0xc0008b5600, 0x1007abf, 0xc0000a8058, 0x0)
	/Users/sbose/go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:950 +0x349
github.com/spf13/cobra.(*Command).Execute(...)
	/Users/sbose/go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:887
github.com/redhat-developer/kam/pkg/cmd.Execute()
	/Users/sbose/kam/pkg/cmd/kam.go:42 +0x27
main.main()
	/Users/sbose/kam/cmd/kam/kam.go:8 +0x20

kam version v0.0.14-11-g337dae1
sbose-mac:~ sbose$ which kam

Expected behavior
 ✓  Created Service graphtuitous successfully at environment stage.

Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

/kind bug

This is because you're adding it to an environment with no defined pipelines, but with an image.
What should it do? Our current default pipelines are for building the image.
Should we assume that you want the same pipeline across all environments?
It's definitely possible that you might want to execute a pipeline for a repo on push.

Here's how I am thinking, if I'm adding a new service to an env, I would either

Add a service with no code repo to build ( no "image build" pipelines needed )
Add a service a code repo ( "image Build" pipelines would be needed )

Just to be clear, you added it to the "stage" environment, you expected to rebuild the image in stage before going to the next stage?

Correct

What's going to trigger the pipeline?
Is this for manual processes?
Do we just duplicate the "previous" stage's pipelines if there aren't any?

What's going to trigger the pipeline?

If the service includes a new application source code repo, PRs to the application source code repo should trigger the pipeline.
If the service doesn't include any new application source code repo, then we don't need any new pipelines ( other than dry run pipelines for gitops repo which already exists ).

What do you think? 🤔

It doesn't cover the rebuild the image part?

The problem I can see, is that we'll receive a push notification, we can trigger in multiple pipelines, which will trigger images being built in each stage, while this will sort of rebuild, it's not clear the benefit of the rebuild at this point, because it would trigger the build on the trunk branch too?

yeah image from the application source code repo needs to be built 'once'.

but then, we are effectively starting to talk like applications/services as a top-level constructs instead of environments being the top-level construct :)

Just to be clear, you added it to the "stage" environment, you expected to rebuild the image in stage before going to the next stage?

So, we rebuild it, but only once? Are we basing that on a specific branch?
i.e. in your application code, are we talking about building the "production" branch into production?


Table value parameters in Microsoft.Data.SqlClient

Table value parameters
I've historically used table valued parameter to bulk insert data into SqlServer databases. The approach that I've used doesn't seem to work against Microsoft.Data.SqlClient. The same code (different using statements) compiles against System.Data.SqlClient (SDS) and Microsoft.Data.SqlClient (MDS), but when run against MDS it throws an exception trying to invoke a command that uses a SqlDbType.Structured parameter with a value of IEnumerable<Microsoft.SqlServer.Server.SqlDataRecord>.
Exception message:
   Failed to convert parameter value from a <GetDataRecords>d__1 to a IEnumerable`1.
Stack trace:
   at Microsoft.Data.SqlClient.SqlParameter.CoerceValue(Object value, MetaType destinationType, Boolean& coercedToDataFeed, Boolean& typeChanged, Boolean allowStreaming)
   at Microsoft.Data.SqlClient.SqlParameter.GetCoercedValue()
   at Microsoft.Data.SqlClient.SqlParameter.Validate(Int32 index, Boolean isCommandProc)
   at Microsoft.Data.SqlClient.SqlCommand.SetUpRPCParameters(_SqlRPC rpc, Int32 startCount, Boolean inSchema, SqlParameterCollection parameters)
   at Microsoft.Data.SqlClient.SqlCommand.BuildRPC(Boolean inSchema, SqlParameterCollection parameters, _SqlRPC& rpc)
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, Boolean isAsync, Int32 timeout, Task& task, Boolean asyncWrite, Boolean inRetry, SqlDataReader ds, Boolean describeParameterEncryptionRequest)
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, TaskCompletionSource`1 completion, Int32 timeout, Task& task, Boolean& usedCache, Boolean asyncWrite, Boolean inRetry, String method)
   at Microsoft.Data.SqlClient.SqlCommand.InternalExecuteNonQuery(TaskCompletionSource`1 completion, Boolean sendToPipe, Int32 timeout, Boolean& usedCache, Boolean asyncWrite, Boolean inRetry, String methodName)
   at Microsoft.Data.SqlClient.SqlCommand.ExecuteNonQuery()
   at Program.Main() in C:\Users\Mark\source\SqlTvpTest\SqlTvpTest\Program.cs:line 53

To reproduce
Clone https://github.com/MarkPflug/SqlTvpTest
The solution has two configurations: one to run against SDS and one to run against MDS. The SDS configuration works, and the MDS configuration produces an exception.
Note, that the code will expect a running sql server instance on the local machine, and will create a new database in it to operate against.
Expected behavior
I guess I don't know if this is expected to be supported or not. However, if this particular approach
of using TVPs is not supported, I'd like to know if there is a supported workaround. Preferably one that would work against both SDS and MDS.
Further technical details
Microsoft.Data.SqlClient version: nuget 1.1.0
.NET target: netcoreapp3.0
SQL Server version: 14.0.2027.2 (developer)
Operating system: Windows 10 (1903)

Hi @MarkPflug
You need to use below classes with Microsoft.Data.SqlClient:

Microsoft.Data.SqlClient.Server.SqlDataRecord
Microsoft.Data.SqlClient.Server.SqlMetaData

Also to add, your comment in the repro provided also needs correction:
<!-- this reference is needed by both configurations, because SqlDataRecord is forwarded to it in the Microsoft.Data.SqlClient-->
<PackageReference Include="System.Data.SqlClient" Version="4.7.0" />

You can use Microsoft.Data.SqlClient.Server.SqlDataRecord from Microsoft.Data.SqlClient itself and need not need additional reference to System.Data.SqlClient.

Thanks. That fixed it.
I think I was thrown off, because without the using Microsoft.Data.SqlClient.Server; statement, the MDS configuration will produce the following error:
The type name 'SqlDataRecord' could not be found in the namespace 'Microsoft.SqlServer.Server'. This type has been forwarded to assembly 'System.Data.SqlClient, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' Consider adding a reference to that assembly.

Where is this coming from? System.Data.dll in ProgramFiles/dotnet/shared/Microsoft.NETCore.App/3.0.0 reports this type as forwarded:
[assembly: TypeForwardedTo(typeof(SqlDataRecord))]. I'm assuming it is forwarded to System.Data.SqlClient, to which System.Data has a reported reference (ilspy doesn't make that clear). However, there is no System.Data.SqlClient in the shared framework, so where is System.Data.SqlClient 4.6.0 supposed to come from? It seems really strange to me that the shared framework would forward a type to a nuget package. Is that what's happening here?

Hi @MarkPflug
Please check you might be having using Microsoft.SqlServer.Server; declared in imports. Removing that rightly suggests importing SqlDataRecord from Microsoft.Data.SqlClient.Server.

Indeed, I have that using statement. This is because I was trying to port code from SDS to MDS, and there was no indication that the Microsoft.SqlServer.Server namespace was moved to Microsoft.Data.SqlClient.Server. Why was it necessary to move that ns, and if it was moved, why not dump everything into Microsoft.Data.SqlClient so that it would be more obvious that those types had moved. Honestly, the Server sub-ns doesn't really mean anything to me. What does "Server" have to do with SqlDataRecord? I understand at this point that nothing can be done about it, but I want you to understand how this ns choice makes it easy to fall into this error when porting code that uses these types.
Anyway, thanks for the help in figuring this out. Much appreciated.

In order to highlight the namespace changes better, we're considering to document the same in a guideline to port from System.Data.SqlClient to Microsoft.Data.SqlClient.


feat: support for installation-only attributes

Description

Implement the onlyInstall argument to ignore files when uninstalling.
Related Issue

#372

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

I will consider adding a note to the package description rather than as code.


bcachefs-tools: 1.3.5 -> 1.4.1

Description of changes
Mainly bugfixes.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Tested the binary, which fixes a SIGSEGV from the previous version when changing attributes of a directory with a non-root user.

Taken from here:
https://github.com/koverstreet/bcachefs-tools/blob/master/build.nix#L49
Won't build without.
On Mon, Jan 15, 2024, at 10:14 PM, Will Fancher wrote:

@.**** commented on this pull request.
In pkgs/tools/filesystems/bcachefs-tools/default.nix https://github.com/NixOS/nixpkgs/pull/281216#discussion_r1452746926:

"PREFIX=${placeholder "out"}"

"DESTDIR=${placeholder "out"}"
"PREFIX="

What's the deal with this change?
—
Reply to this email directly, view it on GitHub https://github.com/NixOS/nixpkgs/pull/281216#pullrequestreview-1822259917, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAIRF4QPXUVIGHPSJRQUPDYOWL3FAVCNFSM6AAAAABB3Y6BCCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMRSGI2TSOJRG4.
You are receiving this because you authored the thread.Message ID: @.***>

Perhaps the changes from #279852 should have been considered here?
There are other changes such as the systemd service and udev.

Didn't notice that PR, I'll take a look later today. In the meantime, could you please rebase?


Fix WebsiteBaker URL, add version detection

Also added a few alternative detection methods

The cookie name doesn't support RegEx, right? Otherwise the following would work:
wb[\\-_]\\d{4}[\\-_]sid

Oops, 20K changes. Mind fixing that up? :)


Fix generation when no configuration file is specified

This needs a BC fix because it breaks for people using the default .jane configuration file without specifying the configuration file path through the CLI


Fix encoding of static files

When serving a .txt.gz file, mimetypes correctly reports encoding
'gzip'. This lets browsers treat compressed files properly.

Please add a test also.

Where would the test fit best? I was thinking about test_urldispatch - but there seems to be no test that actually downloads a file from the static server afaict. Should it create a file on the fly, or should I add a small .gz file?

There are functional tests for static file: https://github.com/KeepSafe/aiohttp/blob/master/tests/test_web_functional.py#L251
Please add another one for your case.
You may push tiny .gz file in ./tests folder -- we already have data file here.

Thanks for contribution!


The Disk Size section is redundant

Describe the bug
The Disk Size section is redundant or to me more specific add extra disk.

To Reproduce
When creating a DO target SIZE section should be used and disk size completely removed

Desktop (please complete the following information):

Daytona Version: [e.g. v0.26]
Provider Version: [e.g. v0.1.0]

I can not reproduce the issue on the latest version of the provider (0.1.3).


Use void in all function defenitions that do not take any arguments

This changes the function definitions.  Shouldn't you also change the declarations?

If there is a declaration without void, it already produce an error when building with --strict-warnings that there is no prototype.

I was able to find 1 where it did have () in the header, but that seems to be because it's an assembler function.

I wonder if there's a -W flag we can use to catch f() which should be f(void) ?

man gcc:
       -Wstrict-prototypes (C and Objective-C only)
           Warn if a function is declared or defined without specifying the
           argument types.  (An old-style function definition is permitted
           without a warning if preceded by a declaration that specifies the
           argument types.)

That's what we already have.

Yes, and that flag does not catch this situation that Kurt fixed.


Enable client users to specify an absolute URL for webhooks etc

@mjaschen I think this is what @Geovanek was alluding to in #25
New feature in API is documented here.  They've made a new endpoint, but it sits at a different subdomain, which makes the client inflexible for absolute URL changes.
Example (contrived) usage:
$webhookResponse = $stravaApi->post('https://api.strava.com/api/v3/push_subscriptions', []);

Aha! That makes sense :-)

Com esta atualização eu consigo receber um trigger quando uma pessoa cadastrada no meu app carregar uma nova atividade?
With this update, can I get a trigger when a person registered in my app loads a new activity?

Hi @Geovanek,
According to the documentation, you'll need to ask permission by emailing the Strava dev team.  In theory this update should allow you to call the webhook endpoints, but the restrictions in access mean I haven't made a successful request, but the request does return an error response for me, which makes me think this should work :)

Merged + tagged 1.3.0
composer update will fetch the new version - have fun :-)


Update Makefile to match ponylang standard

I left a coverage target that was present in the old Makefile. I don't have kcov installed and it doesn't seem to be well supported in macOS, so I wasn't able to test that it works.
I don't think this should block the PR, but @Trundle do you think that you could verify that coverage still works for you?
Fixes #4

Since the kvoc target is not used by any other Pony project, I'm going to go ahead and merge this.
If @Trundle or anyone else tries kcov with this new Makefile and finds any problems, let's open an issue about it.


Doc addition. is_nil - show not is_nil

There have been a couple requests on Slack where people were confused about how to do IS NOT NULL. This adds to is_nil doc to point out how to do that.

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:


Drone .deb package requires lsb_release to install cleanly on Debian 8

When installing Drone with the .deb package on a completely fresh Debian 8 install, the user is prompted with the following message:
$ dpkg -i drone.deb
Selecting previously unselected package drone.
(Reading database ... 13553 files and directories currently installed.)
Preparing to unpack drone.deb ...
Unpacking drone (0.3.0-alpha-1438588567) ...
Setting up drone (0.3.0-alpha-1438588567) ...
/var/lib/dpkg/info/drone.postinst: 20: /var/lib/dpkg/info/drone.postinst: lsb_release: not found
/var/lib/dpkg/info/drone.postinst: 20: /var/lib/dpkg/info/drone.postinst: lsb_release: not found
/var/lib/dpkg/info/drone.postinst: 24: /var/lib/dpkg/info/drone.postinst: lsb_release: not found
 Your system
 This system is not supported, you can install service manually

Installing the lsb-release package and trying again features no errors, so adding to the Depends should fix this.

starting with 0.4 release we're distributing Drone as a Docker image only. It eliminates a lot of distro-specific issues we are seeing with regards to packaging and dependencies.
for reference, new installation instructions:
http://readme.drone.io/docs/setup/index.html


Failed syntax tree validation reported, but input and output code look OK

Csharpier version 0.30.1
Input:
using System.Text.Json;

namespace Microsoft.Azure.HybridCompute.Shared.DataModel.Entities.NetworkSecurityPerimeter;

public class NSPValidationData
{
    public NSPValidationData()
    {
        var accessRulesResponsePayload = new Dictionary<string, List<int>? >
        {
            { "value", accessRulesResponseModel } // NSP data plane library expects this format
        };
    }

}

Command line Output:
> dotnet csharpier test.cs
Error ./test.cs - Failed syntax tree validation.
  ----------------------------- Original: Around Line 10 -----------------------------
          var accessRulesResponsePayload = new Dictionary<string, List<int>? >
          {
              { "value", accessRulesResponseModel } // NSP data plane library expects this format
          };
      }

  }
  ----------------------------- Formatted: Around Line 0 -----------------------------
  using System.Text.Json;

  namespace Microsoft.Azure.HybridCompute.Shared.DataModel.Entities.NetworkSecurityPerimeter;

  public class NSPValidationData
  {
      public NSPValidationData()
      {
Formatted 1 files in 213ms.

file output
using System.Text.Json;

namespace Microsoft.Azure.HybridCompute.Shared.DataModel.Entities.NetworkSecurityPerimeter;

public class NSPValidationData
{
    public NSPValidationData()
    {
        var accessRulesResponsePayload = new Dictionary<string, List<int>?>
        {
            { "value", accessRulesResponseModel }, // NSP data plane library expects this format
        };
    }
}

Expected behavior:
There doesn't seem to be an issue with the syntax tree, so I don't expect to see an error reported.
If I remove the comment, and change the input to the file below, I don't see any error.
using System.Text.Json;

namespace Microsoft.Azure.HybridCompute.Shared.DataModel.Entities.NetworkSecurityPerimeter;

public class NSPValidationData
{
    public NSPValidationData()
    {
        var accessRulesResponsePayload = new Dictionary<string, List<int>? >
        {
            { "value", accessRulesResponseModel }
        };
    }

}

The syntax tree validation logic doesn't account for the edge case I fixed in 0.30.0 where the trailing comma needs to be added before the trailing comment. I'm hoping this will be a quick fix that I can get out today, but if not it is safe to ignore. It'll only fail the validation when it first adds the comma.

Thanks a lot!


Fixed issue no.#665 ML Fusion Labs Logo in Navbar Should Be Centered

Issues Identification
Closes: #665
Description
Summary
Website logo in navbar was not in aligned now its centered.
Details
Include any detailed information about the changes in this pull request.
Types of Changes
Please check the boxes that apply

[x] Bugfix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (Documentation content changed)
[ ] Other (please describe):

Checklist
Please check the boxes that apply

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] My changes do not break the current system and pass all existing test cases
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Screenshots
If applicable, please attach screenshots of the changes made to the user interface.

Additional Information
Please provide any other information that is relevant to this pull request.

Please accept my pr and merge it.

@Adityadhiman0 this issue was assigned to some other contributor, you have created the pull request.
i didn't assigned you the issue, and you have created direct Pull Request.
This is not a Good Open Source Practice.
So I am Closing the Pull Request.
Until I assign the issue no one should create or commit the pull request.
please understand.
Please follow the gssoc guidelines properly
This is an open source and Everyone deserves equal opportunity.


Create non-blocking SpringDecoder.

spring-boot-autoconfigure 2.2.0 change HttpMessageConverters auto configure with condition "NoReativeWebApplicationCondition", so when use openfeign to decode response, there will throws HttpMessageConverters not available exception, could you please add a HttpMessageConverters bean auto configure in openfeign configuration?

It's happended when I update spring cloud version to Hoxton.RELEASE. And Greenwich.SR4 is ok.

I am faced with the same problem with you
@Configuration
public class FeignResponseDecoderConfig {
    @Bean
    public Decoder feignDecoder() {

        ObjectFactory<HttpMessageConverters> messageConverters = () -> {
            HttpMessageConverters converters = new HttpMessageConverters();
            return converters;
        };
        return new SpringDecoder(messageConverters);
    }
}

I am unable to reproduce the error.
Can you provide a complete, minimal, verifiable sample that reproduces the problem?  It should be available as a GitHub (or similar) project or attached to this issue as a zip file.

The above is a workaround. HttpMessageConverter's are blocking and will cause a webflux application to break. HttpMessageReader is the non-blocking equivalent.

5 months passed. any progress?

No

Using above workaround would cause performance issue: response time increase from 7ms to 30ms on the same FeignClient request path.

Ah ok, @vicliu624 code does work but I have to declare both Encoder and Decoder like this
private ObjectFactory<HttpMessageConverters> messageConverters = HttpMessageConverters::new;

    @Bean
    Encoder feignFormEncoder() {
        return new SpringFormEncoder(new SpringEncoder(messageConverters));
    }

    @Bean
    Decoder feignFormDecoder() {
        return new SpringDecoder(messageConverters);
    }
}

I use the following code to solve "feign.codec.EncodeException: "：
`    private ObjectFactory messageConverters = HttpMessageConverters::new;
/**
 * @return
 */
@Bean
Encoder feignEncoder() {
    return new SpringEncoder(messageConverters);
}

/**
 * @return
 */
@Bean
Decoder feignDecoder() {
    return new SpringDecoder(messageConverters);
}`

5 months passed. any progress?

I have replaced the openfeign for reactive feign which is not blocking, it's working fine for me.

WebFlux support in SC OF is not planned. For reactive stack, we suggest using Spring Interface Clients instead. See docs: https://docs.spring.io/spring-cloud-openfeign/reference/4.2-SNAPSHOT/spring-cloud-openfeign.html#reactive-support . Closing as not planned.


codemirror want to disaplay loader on dragover

I want to display the loader once user dragover the file on the codemirror editor.
I have added the webhook for that with below code
const options = {
matchBrackets: true,
autoCloseBrackets: true,
mode: "application/json",
gutters: ["CodeMirror-lint-markers"],
lineWrapping: true,
lineNumbers: true,
dragdrop:true
};
editor = CodeMirror.fromTextArea(container, options);
editor.on("dragover",function(editor,e){
$("#file-loading").addClass("is-active");
console.log("dragover");
e.preventDefault();
});
editor.on("drop",function(editor,e){
$("#file-loading").removeClass("is-active");
console.log("drop");
e.preventDefault();
});
When I am going to drop the file it will directly open that file into the browser once I added the javascript/Jquery code into the dragover webhook.
Please help me to resolve this issue.

This is not an issue that belongs in the issue tracker. Try the forum for help requests (as the issue template that showed up when you created this clearly asked you to).


Support SciPy 1.11

Tasks

[ ] Read Release Notes.
[ ] Fix code and CI to support the new vesrion.

FlexCI: Update .pfnci/schema.yaml and .pfnci/matirx.yaml.
Update Requirements: For NumPy/SciPy, bump the pinned minimum/maximum version in setup.py (see #4773.)

[ ] Backport the above PR.
[ ] For NumPy update, reflect the changes in numpy.array_api to cupy.array_api.
[ ] Backport the above PR.
[ ] Fix documentation.

Update Requirements section in the Installation Guide (note: the baseline version must be updated only in the development branch).
Update docs/requirements.txt to use the latest versions.

[ ] Backport the above PR.
[ ] Apply fixes needed to follow the specification changes.

The failure of tests/cupyx_tests/scipy_tests/sparse_tests/test_base.py is related to this SciPy update: https://github.com/scipy/scipy/commit/d87d90095e4661aed0613f1a74b7aa1eca5decc2
v1.10.1: https://github.com/scipy/scipy/blob/v1.10.1/scipy/sparse/_base.py#L60
v1.11.3: https://github.com/scipy/scipy/blob/v1.11.3/scipy/sparse/_matrix.py#L4


Feat/summit slides

Change the wording on the summit page slightly to indicate we know it's over.
State that we keep the page around to document the event and have slides and videos collected here.
Link to slides and videos can just be added to the yaml talks data file (_data/summit2023-talks.yml) and should then just appear.
Note: The staging page does not load the .css ... assets and does not allow to test this completely.

Hmmm, on the staging page, the assets are being loaded from /website/assets/... but in reality they are in /assets/....
I added a symlink on the webserver as workaround, but this is likely not the ideal solution. For now, it makes the staging web site work again.


Home page added

PR Description 📜
I have implemented a dedicated homepage for Squard-line, the flagship game. This homepage will serve as a central hub for players to access essential game information, interesting facts, a high scores leaderboard, and a section redirecting to the main game page for further exploration.
Fixes # 82

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for review.

## Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

This task requires significantly more effort and complexity than other issues assigned to GSSoC Level 2. Could you please assign it to GSSoC Level 3? Thank you!

@Ayushvishwakarma04 Make it resposive & add some animations

I have added responsiveness and animation to the homepage of Squard-lines and removed the screenshots as discussed. The homepage now adjusts seamlessly to different screen sizes, providing a better user experience across devices. Additionally, the animations enhance the visual appeal and interactivity of the page. Let me know if there are any further changes or improvements needed!


Allow errors and description to be undefined

Regression introduced by faaff6e and fix similar to e42725a.
For an example of what this fixes, see the TypeError being raised here.

Thanks!