Problems setting xticks

Consider the following modification of the basic example
import random

import matplotlib.pyplot as plt
import nc_time_axis
import cftime, numpy as np

calendar = "360_day"

d_time = [cftime.datetime(y,1,1,0,0,0) for y in range(1850, 2001)]
c_d_time = [nc_time_axis.CalendarDateTime(item, calendar) for item in d_time]
temperatures = [round(random.uniform(0, 12), 3) for _ in range(len(c_d_time))]

t0 = nc_time_axis.CalendarDateTime(cftime.datetime(1850,1,1,0,0,0),calendar)
t1 = nc_time_axis.CalendarDateTime(cftime.datetime(2000,1,1,0,0,0),calendar)

plt.plot(c_d_time, temperatures)
plt.margins(0.1)
plt.ylim(0, 12)
plt.xlim(t0,t1)
plt.xlabel("Year")
plt.ylabel("Temperature")
plt.show()

This works, but the tick marks are slightly oddly located. If I try to add ticks with
ticks = [nc_time_axis.CalendarDateTime(cftime.datetime(y,1,1,0,0,0),calendar) for y in range(1850,2001,25)]
plt.xticks(ticks)

I get an error
  File "/.../miniconda3/lib/python3.6/site-packages/nc_time_axis/__init__.py", line 270, in convert
    raise ValueError('The values must be numbers or instances of '
ValueError: The values must be numbers or instances of "nc_time_axis.CalendarDateTime".

This seems to be because convert checks whether its argument is a numpy array but doesn't handle lists properly.
Using
ticks = nparray([nc_time_axis.CalendarDateTime(cftime.datetime(y,1,1,0,0,0),calendar) for y in range(1850,2001,25)])
plt.xticks(ticks)

fails with
  File "/.../miniconda3/lib/python3.6/site-packages/nc_time_axis/__init__.py", line 83, in __call__
    format_string = self.pick_format(ndays=self.locator.ndays)
AttributeError: 'NetCDFTimeDateLocator' object has no attribute 'ndays'

It seems that ndays is needed for working out the formatting of tick labels but isn't set when using explicit locations.
 E.g,
import random

import matplotlib.pyplot as plt
import nc_time_axis
import cftime, numpy as np

calendar = "360_day"

d_time = [cftime.datetime(y,1,1,0,0,0) for y in range(1850, 2001)]
c_d_time = [nc_time_axis.CalendarDateTime(item, calendar) for item in d_time]
temperatures = [round(random.uniform(0, 12), 3) for _ in range(len(c_d_time))]

t0 = nc_time_axis.CalendarDateTime(cftime.datetime(1850,1,1,0,0,0),calendar)
t1 = nc_time_axis.CalendarDateTime(cftime.datetime(2000,1,1,0,0,0),calendar)
ticks = np.array([nc_time_axis.CalendarDateTime(cftime.datetime(y,1,1,0,0,0),calendar) for y in range(1850,2001,25)])

plt.plot(c_d_time, temperatures)
plt.margins(0.1)
plt.ylim(0, 12)
plt.xlim(t0,t1)
axes = plt.gca()
locator = axes.xaxis.get_major_locator()
locator.ndays = 365*150
plt.xticks(ticks)
plt.xlabel("Year")
plt.ylabel("Temperature")
plt.show()

Versions are  matplotlib 3.0.2, cftime <IP_ADDRESS>, nc_time_axis 1.1.0.

I have a similar problem. A minimal example is that,
import matplotlib.pyplot as plt
import nc_time_axis
import numpy
import cftime

x = [nc_time_axis.CalendarDateTime(cftime.datetime(y, 1, 1), "360_day")
     for y in range(2000, 2010)]
y = numpy.arange(10)
plt.scatter(x, y)
plt.show()

only works if numpy.array is wrapped around the definition of x.
I believe the solution is to put the following here,
        if isinstance(value, np.ndarray) or isinstance(value, list):

I think I'm having a similar problem here. There is an incompatibility between nc-time-axis and native matplotlib datetime locators. See my issue at https://github.com/lukelbd/proplot/issues/126.
With a numpy datetime axis:
import matplotlib.pyplot as plt
import matplotlib.dates as mdates
import numpy as np
import xarray as xr

times = np.arange('1990', '2000', dtype='datetime64[M]')
data = xr.DataArray(
    np.random.rand(len(times)),
    dims=['time'],
    coords=[times]
)

f, ax = plt.subplots()

ax.plot(data.time, data)
ax.xaxis.set_major_locator(mdates.YearLocator(2))

With a cftime axis:
import matplotlib.pyplot as plt
import matplotlib.dates as mdates
import numpy as np
import xarray as xr

times = xr.cftime_range('1990', '2000', freq='M')
data = xr.DataArray(
    np.random.rand(len(times)),
    dims=['time'],
    coords=[times]
)

f, ax = plt.subplots()

ax.plot(data.time, data)
ax.xaxis.set_major_locator(mdates.YearLocator(1))

@lukelbd, do you think this would be a relatively quick fix? This looks like a somewhat dead repo given how old this issue is. I am very unfamiliar with these locators. Would it just require a few lines of code in __init__? Any thoughts?

This might be a pretty big PR unfortunately, but shouldn't be very conceptually complicated. You basically need to copy + modify YearLocator, MonthLocator, etc. in matplotlib/dates.py, and that section of code is ~300 lines long. You'd have to go through each line and convert the datetime64 syntax to nc-time-axis syntax -- e.g. wherever they get integer year from a datetime64 array, change that to how you'd get the integer year from a cftime array, etc.
If you have time go for it, but otherwise it might make more sense to convert your nc-time-axis times to datetime64 if possible, even if the calendars don't technically match (my understanding is the main difference between these two formats is that nc-time-axis can work with different calendar types?). Also if you don't get a response to a PR submitted to this repo, I can add your locators directly to proplot just like I add some fixes for currently active cartopy/matplotlib issues.

Oh, now I see the specific issue at the top is different and possibly easier to fix.
The user was trying to manually set the tick locations by sending a cftime array to set_xticks, which results in matplotlib applying a FixedLocator as the axis locator. However, nc-time-axis evidently expects the axis locator to be its own special locator, and raises an error otherwise (at least this is what I suspect is happening; you should try to print(self.locator) in that example). I don't think there is an issue when using FixedLocator with datetime64 coordinates, so this appears to be an unfortunate limitation of nc-time-axis. Might be simple to fix or might be complicated, depends on how this was designed. But you'll need to play round.
Since this repo has had no commits for >1 year I'd be open to just adding the entire repo's codebase to proplot. Definitely fits within proplot's scope of easier plotting/xarray integration. But that's a long term goal... maybe this summer.

The issue in @MartinDix's initial comment is a symptom of the issue identified in https://github.com/SciTools/nc-time-axis/pull/79#discussion_r686307591: the ndays attribute -- now the resolution attribute -- cannot be computed without knowing the range of the axis, which is not known at the time the locator is constructed.  In the case of setting the ticks it seems that matplotlib creates a new locator and so any axis range information is lost.
This is OK.  I propose working around this in nc-time-axis in the following way:

Set a default date format in NetCDFTimeDateFormatter if the locator does not have a resolution attribute.  I would suggest "%Y-%m-%d" to be consistent with matplotlib.  Note that when a user explicitly sets the ticks for a datetime axis, matplotlib also uses a default format.
Create another formatter class that will let users set their own date formats to override this default format if they desire.  Matplotlib does this with their DateFormatter class (see for example here).  I think this would be a useful feature regardless.

To make the analogy with matplotlib clear, I might suggest renaming NetCDFTimeDateFormatter to AutoCFTimeFormatter -- possibly after a deprecation cycle, though I think it is unlikely anyone is using it outside nc-time-axis -- and naming the new formatter proposed in (2) CFTimeFormatter.
Does anyone in @SciTools/nc-time-axis-devs or this issue have any thoughts on this proposal?

See #84 for a proof of concept.

The proposal in https://github.com/SciTools/nc-time-axis/issues/41#issuecomment-898895834 has been implemented in #84.  See the PR description for an example of using the new CFTimeFormatter.


Delay messages "timeshift" for live sports watching

A feature to delay channel output by a set amount of time could be nice for sports channels, to prevent spoilers when watching TV simultaenously.

What time would server-time say in that case?

Basically a bad connection simulator where channel messages could be delayed by 30 seconds


Add https-portal

I added the following feature to the system.

https://github.com/SteveLTN/https-portal

According to https://qiita.com/kuboon/items/f424b84c718619460c6f, it can make a web site be an https one. Please switch the following lines and test the site.
      STAGE: local
      #STAGE: production
      DOMAINS: 'localhost -> http://nginx:80'
      #DOMAINS: 'shellgei-web.net -> http://nginx:80'

If there are some problems, don't hesitate to discard this request.
Regards

It looks working!
Thank you ;D


Switching to JSONPath-Plus

As promised/threatened on Twitter I've looked into replacing jsonpath with JSONPath-Plus in order to get access to some more query options, namely

Convenient additions or elaborations not provided in the original spec:

^ for grabbing the parent of a matching item
~ for grabbing property names of matching items (as array)
Type selectors for obtaining:

Basic JSON types: @null(), @boolean(), @number(), @string(), @array(), @object()
@integer()
The compound type @scalar() (which also accepts undefined and
non-finite numbers when querying JavaScript objects as well as all of the basic non-object/non-function types)
@other() usable in conjunction with a user-defined otherTypeCallback
Non-JSON types that can nevertheless be used when querying
non-JSON JavaScript objects (@undefined(), @function(), @nonFinite())

@path/@parent/@property/@parentProperty/@root shorthand selectors within filters
Escaping

` for escaping remaining sequence
<EMAIL_ADDRESS>syntax for escaping special characters within
property names in filters

Documents $.. (getting all parent components)

It's actually working great, things like $.*~ now work (endpoint is https://data.octoprint.org/export/plugin_stats_30d.json):

I'm marking this as WIP however since I've encountered a small issue with the fallback field name... While the API docs of the JPP package talk about const paths = JSONPath.toPathArray(field.jsonPath);, I cannot for the life of me get TypeScript to not cry foul at a corresponding use. I have no idea if I'm doing something wrong here or if there's something wrong with JPP's TypeScript bindings maybe, so any hint would be greatly appreciated!
edit This is the error I get from yarn dev when I uncomment the toPathArray line:
$ yarn dev
yarn run v1.22.5
$ grafana-toolkit plugin:dev
√ Linting
- Bundling plugin in dev mode  Starting type checking service...
  Using 1 worker with 2048MB memory limit
| Bundling plugin in dev mode  ERROR in D:/Code/grafana-plugins/grafana-jsonapi-datasource/src/DataSource.ts(38,34):
  TS2339: Property 'toPathArray' does not exist on type 'JSONPathType'.

   Hash: 886f57ef93f391b92b96
  Version: webpack 4.41.5
  Time: 5999ms
  Built at: 2020-09-22 19:27:47
               Asset      Size  Chunks                          Chunk Names
             LICENSE  11.1 KiB          [emitted]
           README.md  1.01 KiB          [emitted]
        img/logo.svg  1.55 KiB          [emitted]
  img/screenshot.png   732 KiB          [emitted]        [big]
    img/variable.png   719 KiB          [emitted]        [big]
           module.js   962 KiB  module  [emitted]        [big]  module
       module.js.map   776 KiB  module  [emitted] [dev]         module
         plugin.json   1.2 KiB          [emitted]
  Entrypoint module [big] = module.js module.js.map
  [../node_modules/date-fns/esm/index.js] 13.2 KiB {module} [built]
  [../node_modules/jsonpath-plus/dist/index-es.js] 31.2 KiB {module} [built]
  [../node_modules/lodash/defaults.js] 1.71 KiB {module} [built]
  [../node_modules/tslib/tslib.es6.js] 10 KiB {module} [built]
  [./ConfigEditor.tsx] 1.5 KiB {module} [built]
  [./DataSource.ts] 6.67 KiB {module} [built]
  [./JsonPathQueryField.tsx] 492 bytes {module} [built]
  [./QueryEditor.tsx] 4.11 KiB {module} [built]
  [./VariableQueryEditor.tsx] 1.08 KiB {module} [built]
  [./api.ts] 2.7 KiB {module} [built]
  [./module.ts] 401 bytes {module} [built]
  [./types.ts] 108 bytes {module} [built]
  [@grafana/data] external "@grafana/data" 42 bytes {module} [built]
  [@grafana/ui] external "@grafana/ui" 42 bytes {module} [built]
  [emotion] external "emotion" 42 bytes {module} [built]
      + 282 hidden modules

  ERROR in D:/Code/grafana-plugins/grafana-jsonapi-datasource/src/DataSource.ts
  ERROR in D:/Code/grafana-plugins/grafana-jsonapi-datasource/src/DataSource.ts(38,34):
  TS2339: Property 'toPathArray' does not exist on type 'JSONPathType'.

  Trace: Build failed
      at D:\Code\grafana-plugins\grafana-jsonapi-datasource\node_modules\@grafana\toolkit\src\cli\utils\useSpinner.js:25:29
      at step (D:\Code\grafana-plugins\grafana-jsonapi-datasource\node_modules\@grafana\toolkit\node_modules\tslib\tslib.js:136:27)
      at Object.throw (D:\Code\grafana-plugins\grafana-jsonapi-datasource\node_modules\@grafana\toolkit\node_modules\tslib\tslib.js:117:57)
      at rejected (D:\Code\grafana-plugins\grafana-jsonapi-datasource\node_modules\@grafana\toolkit\node_modules\tslib\tslib.js:108:69)
      at processTicksAndRejections (internal/process/task_queues.js:97:5)
× Build failed
error Command failed with exit code 1.

Hm. Indeed none of the static functions seems to be available on the type. I'll continue digging, but in the meantime, you can override the type system with this:
const paths = (JSONPath as any).toPathArray(field.jsonPath);

Looks great! Thanks for adding this! ❤

Happy to contribute :)


GCE VM Power Ops

Adds ability to start/stop existing Google VMs.
@agrare @blomquisg @chessbyte

Nice!
My first three commits were PRs that were modified in review before being merged.  I rebased them out if you want to pull from my fork of your branch so we have a cleaner history.

@agrare, I ran $ git reset agrare/initial_google_cloud_platform_support on top of my branch, so they should be in sync, I will rebase to clean up the history.

@chessbyte @agrare @blomquisg Ready to merge?

@lwander looks like still need to take out the instance logging from get_instances.

@agrare I just removed it

@lwander when github says the page is out of date I should listen
:+1: looks good to me


Add translation key for time ago

⚠⚠⚠ Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:

[x] I have read and understand the pull request rules.

Description
Add translation keys
Originally, this was raised in https://github.com/louislam/uptime-kuma/pull/4400 but said PR had a bad rebase.
Doing this one cleanly is simpler
Type of change
Please delete any options that are not relevant.

Other

Checklist

[x] My code follows the style guidelines of this project
[x] I ran ESLint and other linters for modified files
[x] I have performed a self-review of my own code and tested it
[x] I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
[x] My changes generates no new warnings

Screenshots (if any)

The main reason the heartbeat time indication was not translated, is because "the minimum width of heartbeats where the time indication should be displayed" is a fixed value. If the text can be translated, this width becomes variable. I don't see an easy way of handling this.

Although I suppose we could just increase the value to be much larger than necessary to be safe.

This is the closest i can push the values and the longest that they can be (after that, they merge into one long string):

=> I don't think this will actually be an issue or am I missing something @chakflying

Given that this is just a translation, I am going to skip a review for this one.
A self-review is likely fine for this ^^


ccd and character controller

This should be using axis locking to get a correct capsule simulation: https://gameworksdocs.nvidia.com/PhysX/4.1/documentation/physxguide/Manual/RigidBodyDynamics.html#axis-locking

ok ser will fix


Fix Memory leak in SSR

The global ERROR object keeps references to the errors objects.
This prevent the garbage collector from freeing the memory.
This fix simply check if a window exists (if yes we are running in the browser) else we are in SSR.
Do not add the error object to the ERROR const global variable to allow GC cleanup.

Created, never Garbage collected.

With this fix.

No more ErrorBag being holded in memory.

This correct issue #1162


Python script automating build process

This script automates the build process, starting from cloning this repo, setting up required python envs and packages, to building the SpearSim executable and packing it into a zip file.

I just realized that the arguments are ordered as follows throughout our code: required args, args where we provide a default, optional args. We should order things in the same way in this latest batch of PRs.

I think it would be less confusing if this script only executed Python code from the "outer" repo, i.e., not the repo that gets cloned at the beginning of build_executable.py.
Yes, the outer repo could potentially get out-of-sync with respect to the C++ code being built from the inner repo. But that is already an issue, regardless of which copy of build_third_party_libs.py we decide to execute. No matter what, when you import spear, even if you do so from path/to/inner_repo/build_third_party_libs.py, you'll be executing the code from the outer repo.
I think a simpler mental model to keep track of in our minds would be: "all python code comes from the outer repo; the only thing that comes from the inner repo is the C++ code being built"
In contrast, the current mental model implied by this PR is more complicated: "build_executable.py is from the outer repo; the python scripts it invokes like build_third_party_libs.py are from the inner repo; import spear and spear.get_config() are from the outer repo; the C++ code is from the inner repo"

Hmmm, I think it's a bit more complicated/tricky. If we execute all python scripts from "outer" repo, our create_symbolic_links.py script links unreal_plugins from the "outer" repo to the "inner" repo's unreal_projects. This would be mixing C++ code from "outer" and "inner" repo. This shouldn't happen.
One way I can think of is to modify create_symbolic_links.py to take unreal_plugins_dir, third_party_dir as inputs in addition to unreal_project_dir, and set defaults as in the current script. This way, we avoid this mixing of C++ code.

I like that solution.

I made a few notes but otherwise this looks great.

Note: since we removed the creation of the final zip file out of build_executable.py, we need to create a simple archive_executable.py script that will create the final zip file for each platform. We might need to call ditto on macOS in case that is needed for some reason, but I'm not sure.

Note: since we removed the creation of the final zip file out of build_executable.py, we need to create a simple archive_executable.py script that will create the final zip file for each platform. We might need to call ditto on macOS in case that is needed for some reason, but I'm not sure.

Yes, I'll create this script.


fix doc comments, remove warnings when running cargo doc

Escape brackets
The docs for nrf-hal-common::timer reported a lot of warnings when running :
cargo doc

This PR aims to resolve these warnings by escaping all of the brackets in that file.

@bors


Empty tiles at zoomlevel 16 or greater

When I request tiles at zoomlevel 16, the coordinates of the Y-ax are way off. Below are 2 examples at level 15 and 16:
Zoomlevel 15: /15/16973/10716.pbf
DEBUG executing statement s5 with parameters: [720342.554559499, 6930698.228673499,<PHONE_NUMBER>120609, 6931921.221126061, 4.777314267823516, 18055.990933506204]

Zoomlevel 16: 16/33948/21433.pbf
DEBUG executing statement s4 with parameters: [721565.5470120609, -20037508.342789248,<PHONE_NUMBER>383418, -20036896.846562967, 2.388657133911758, 9027.995466753102]

Your'e working with v0.6.1? Maybe this is fixed in the current master branch.
Will check that anyway, thanks for the feedback!

Hi,
I'm using the master branch. Also checked with 0.6.1, and is giving the same results.
Thanks for looking into it!

Thanks a lot for fixing it!

My first lines in Rust ;-)
Happy to contribute, I think it's a great tool!


Fix conditional in CentOS 7 check

This should let our srvadmin-storage fix take effect.
@musl @bowiesaurus @gnarg

Closing because we're no longer maintaining the repo.


Tab Control Underline Position

What changed?
A dependency property was added to the tabcontrolhelper class that allows a person to set the underline position in the various tab controls. The property is a Dock type and can be set to Left,Right,Top, or Bottom respectively. Not very well tested but it was tested and appeared to be functioning as it should. Would like a second person to verify if possible.

@jammerxd your changes have been merged, thanks for your contribution 👍

Wow! I didn't know this was something that would make it in!


Adding QueueType and json tags

Adding missing QueueType and json tags to the QueueMessage type.

Coverage increased (+0.4%) to 67.433% when pulling d4fd066d21998ad99f588097777600c17674e238 on vitarb:queue-json-tags into e1f509e338babb29f2f1141393c69da8ddfb3034 on uber:master.


the README example imports css from wrong location

https://github.com/hyjiacan/vue-slideout/blob/master/README.md?plain=1#L75
The example in the README should import the css file from 'dist' rather than 'lib'
- import<EMAIL_ADDRESS>+ import<EMAIL_ADDRESS>

Got it! Thanks.


Add Licence

Hi Craig,
Can you please add an appropriate license to your library? This will let others like me know whether or not we can use your library in our code.
May I add that a permissive license would be much appreciated!
Thanks!

I've added the MIT license to the code. That's the license I normally use for code I've written and shared with the public.

Awesome, thanks!


kernel: update kernel version to v4.19.213-cip60

Purpose of pull request
Update kernel version to v4.19.213-cip60.
Test
How to test
Build and run core-image-minimal.
Test result
v4.19.213-cip60 works fine.

Thanks!


Issue 55 rename zoom out tranformer

Fixes #55
renamed ZoomOutTranformer to ZoomOutTransformer
updating gradle plugin to 2.2.3 (can drop this before Pull if you like)

Thank you for the PR. I cherry picked the change and pushed a new PR in #58


Anchor Events not working

Read some documentation and came across Anchor Events but that CPI Events
It requires one to opt into it, like so anchor-lang = { version = "0.29.0", features = ["event-cpi"] }
I am using Anchor version 0.30.1. My instruction has the required #[event_cpi] above it,  and it is supposed to emit the event "TestEvent"
emit_cpi!(TestEvent { random: 32332522 });
On my NodeJs server, I import the idl and set up the Program alongside AnchorProvider, so that I can subscribe to the event like so
 const subscriptionId3 = program.addEventListener("TestEvent", (event) => {     console.log("event");   });
My transactions go through successfully, but I never get the events. I look at the transaction details on Solana Explorer, and I do indeed see that the event_authority was passed as an account for the transaction, and an interaction occured.
I am using a Helius RPC endpoint for devnet. What could be the issue? Is it because I am using devnet?

This is because program.addEventListener doesn't work with CPI events currently. You need to get the transaction and parse the event that way. There is an existing issue https://github.com/coral-xyz/anchor/issues/2609, let's track it there.

This is because program.addEventListener doesn't work with CPI events currently. You need to get the transaction and parse the event that way. There is an existing issue #2609, let's track it there.

Thank you so much!
If I could bother you with one quick question: I am fetching transaction data and iterating through its inner instructions to decode instruction data until I find my event. I am able to decode it using const event = program.coder.events.decode(eventData); but I am curious, is there anyway for a malicious actor to forge this by adding their own custom instructions to another account? How can I verify this came from the event authority?

A malicious actor cannot forge this because the event authority needs to sign the transaction for event CPI to work. We have a test for this:
https://github.com/coral-xyz/anchor/blob/51b21cebca7a8672550a9f0349485d920eac8602/tests/events/tests/events.ts#L69-L102


Facets not available in response

#When I make the following request:
oneDriveClient.getDrive()                         .getItems(itemId)                         .getChildren()                         .buildRequest<EMAIL_ADDRESS>                        .expand("thumbnails")                         .get(callback)
I cannot find in the IItemCollectionPage.getCurrentPage() the various Facets properties like item.folder , item.file , item.image, ie. they are all null.
Is this by design, or is there a way to retrieve file/folder/image facets for an Item?

Ok, figured out the answer:
oneDriveClient.getDrive() .getItems(itemId) .getChildren() .buildRequest<EMAIL_ADDRESS>.expand("thumbnails") .get(callback)

Yup, that would be a way to get only the facets your application is interested in

Please reopen if you are still having issues, thanks!


[QQ Music Controls] fix keywork in script text

Description
The apple script control menu item has been updated from  "喜欢歌" with "喜欢歌曲".
Now it works well.
Screencast

I have no idea which branch should I PR to.
So I submit this to the master.
If there is any specific requrement pls let me know. :)


Switch out logrus for klog

Currently when logrus and klog are used together they can cause panics. With the CRD implementation some of the core libs like client-go/rest.BuildForConfig will try to use klog to return which will fail.

/remove-lifecycle rotten


Unit tests for metasync's transport

@alex-aizman @VladimirMarkelov @liangdrew @sasanap

diff updated

thank you


Browse Datasets: Sorting by relevance suddenly disappears

Describe the bug
After entering something in the searchfield, suddenly the Sorting By relevance dissappears in the dropdown.
To Reproduce
Steps to reproduce the behavior:

Go to 'test.visualize.ch'
Click on the Sorting Dropdown in the Browse Dataset view and see all 3 Sorting options
Search for a keyword in the Search field
Delete the keyword in the searchfield
Click on the Sorting Dropdown in the Browse Dataset view and see suddenly only 2 Sorting options

Expected behavior
Sorting by Relevance should always be visible
Screenshots or video
https://user-images.githubusercontent.com/59613691/203264074-6efbb276-eaab-429d-b828-a80dc38c353e.mp4
Environment (please complete the following information):

Visualize environment and version: INT v3.13.0
Browser and version Safari, 15.6.1

So the bug is more that relevance is displayed when we have not searched anything right ?

I thought the "By relevance" is showing the datasets ordered according to the most search datasets in general and not only according to what I have searched as an individual? Or am I wrong? So if the first one is the case, I'd assumed that the By relevance is always visible. If the second one is the case, then yes, it shouldn't be displayed if I haven't searched for anything yet.

There is no mechanism of popular searches, or popular datasets. The "relevance" keyword is only meaningful when there is a search term entered.

Ah ok, got it! Thanks for clarifying!


[BUG] [ESP32-C3] light-switch-app : General error: 0xc3 (UNSUPPORTED_CLUSTER)

Reproduction steps
1. commissioning light-switch-app
./chip-tool pairing ble-wifi 43211234 $SSID $PASS 20202021 3840

2. commissioning lighting-app
./chip-tool pairing ble-wifi 12344321 $SSID $PASS 20202021 3840

3. set to access light-switch-app and lighting-app
./chip-tool accesscontrol write acl '[{"fabricIndex": 1, "privilege": 5, "authMode": 2, "subjects": [112233], "targets": null },{"fabricIndex": 1, "privilege": 3, "authMode": 2, "subjects": [43211234], "targets": null }]' 12344321 0

4. bind lighting-switch
./chip-tool binding write binding '[{"fabricIndex": 1, "node":43211234, "endpoint":1, "cluster":6}]' 12344321 1

then, chip-tool finish with UNSUPPORTED_CLUSTER
[1665981016.080906][24926:24926] CHIP:TOO: Run command failure: IM Error 0x000005C3: General error: 0xc3 (UNSUPPORTED_CLUSTER)

Bug prevalence
everytime
GitHub hash of the SDK that was being used
commit 3897c9b12f4f16a8ad6bf73aa8f8d2272b60124a (HEAD -> v1.0-branch, origin/v1.0-branch)
Platform
esp32
Platform Version(s)
No response
Anything else?
I try to bind lighting-app device and light-switch-app device.
I followed below README.md.
https://github.com/project-chip/connectedhomeip/tree/v1.0-branch/examples/light-switch-app/esp32
However, it cannot success because chip-tool shows below error.

CHIP:TOO: Run command failure: IM Error 0x000005C3: General error: 0xc3 (UNSUPPORTED_CLUSTER)

Environment
OS : Ubuntu 20.04
ESP-IDF : v4.4.1
Cluster Module : ESP32-C3-devKitM-1 (2pcs)
examples:
light-switch-app
lighting-app
Logs
light-switch ID is named 43211234.
lighting ID is named 12344321.

./chip-tool pairing ble-wifi 43211234 $SSID $PASS 20202021 3840
chip-tool-0.txt
light-switch-0.txt

./chip-tool pairing ble-wifi 12344321 $SSID $PASS 20202021 3840
chip-tool-1.txt
lighting-app-1.txt

./chip-tool accesscontrol write acl '[{"fabricIndex": 1, "privilege": 5, "authMode": 2, "subjects": [112233], "targets": null },{"fabricIndex": 1, "privilege": 3, "authMode": 2, "subjects": [43211234], "targets": null }]' 12344321 0
chip-tool-2.txt
lighting-app-2.txt

./chip-tool binding write binding '[{"fabricIndex": 1, "node":43211234, "endpoint":1, "cluster":6}]' 12344321 1
chip-tool-3.txt
lighting-app-3.txt

./chip-tool binding write binding '[{"fabricIndex": 1, "node":43211234, "endpoint":1, "cluster":6}]' 12344321 1

@mmt-10 You are sending binding command to the lighting-app but it is supposed to be sent to light-switch, and lighting-app do not have binding service it is failing with error: UNSUPPORTED_CLUSTER.
Try the following command:
./chip-tool binding write binding '[{"fabricIndex": 1, "node":12344321, "endpoint":1, "cluster":6}]' 43211234 1

@shubhamdp
Thank you very much!
I misunderstand node ID.


[IOTDB-6072] Load: workaround to CPU 100% after loading tsfile when using JDK8 runtime

Description
After loading tsfile, it causes 100% load on one CPU core.
Reason
it was a bug in JDK1.8.
JDK-8129861
JDK-8022642
Solution

set corePoolSize to 1 to avoid high processor load
lazy initialization: init loadTsFileManager  on first call

LGTM :)


Fixes issue #43

Allows for a custom view id to be specified, if one isn't then it uses R.id.card_container so it doesn't break the library.

MyEngineer13,
Thank you for the input. Version 2.0 absorbed SuperCardToast functionality into the SuperActivityToast class and in doing so I added this functionality.

John


Update cart design

Use our main theme of white, green and red and update cart design to something smooth and better looking.

I'll do this


clarifying that for the common case of a partitioned index on a parti…

…tioned Clustered Index, the partition column is already an index key column

@davidbaxterbrowne : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@davidbaxterbrowne : Thanks for your contribution! The author(s) have been notified to review your proposed change.

[ ] https://github.com/MicrosoftDocs/sql-docs-pr/pull/18249/files

[ ] https://github.com/MicrosoftDocs/sql-docs-pr/pull/18249/files

#please-close

#please-close

Update made in separate PR,

[ ] https://github.com/MicrosoftDocs/sql-docs-pr/pull/18249/files

Update made in separate PR,

[ ] https://github.com/MicrosoftDocs/sql-docs-pr/pull/18249/files

But that information is not documented on the page you refer to.  It says that the clustered index key columns are included in the non-clustered index, but it does not clarify that they are stored as key columns for non-unique indexes and as row values for unique non-clustered indexes.  It's not really relevant in that context to clarify.
But in this context it determines whether or not the partitioning column is added to the index, and clarifies that for all partitioned nonclustered indexes on clustered index tables, the partition key is already a non-clustered index key column.  For unique non-clustered indexes it's a requirement, and for non-unique non-clustered indexes the partitioning column is already there because the partitioning column is always a clustered index key column.
And so partitioning a non-clustered index on a clustered index table never adds any additional size to the index.

But that information is not documented on the page you refer to.  It says that the clustered index key columns are included in the non-clustered index, but it does not clarify that they are stored as key columns for non-unique indexes and as row values for unique non-clustered indexes.  It's not really relevant in that context to clarify.
But in this context it determines whether or not the partitioning column is added to the index, and clarifies that for all partitioned nonclustered indexes on clustered index tables, the partition key is already a non-clustered index key column.  For unique non-clustered indexes it's a requirement, and for non-unique non-clustered indexes the partitioning column is already there because the partitioning column is always a clustered index key column.
And so partitioning a non-clustered index on a clustered index table never adds any additional size to the index.


All Zones isn't showing up in the Status web part

I have configured 3 zones.
Zone0 = mqttClient
Zone1 = wallClock
Zone2 = Weather Icon
But on the start webpage only Zone 0 and 1 is shown. Is this behavior because Weather Icon isn't defined as a work mode?

I do not see your question. It does show 3 zones not in manual import mode in your screenshot.

Thanks, I see it now.  Yea, the code is not there. I sure he will fix it in the next  build.
Good catch
It needs this after line 103....

                       <h7 class="my-0">Zone2</h7>                       Work mode
                     %workModeZone2%


Fill _kwargs attribute

Problem description
When the labels method is called a new instance of Summary is created inside and this new instance uses default values for invariants, max_age_seconds and age_buckets instead of those were passed for the "parent" Summary instance initialization.
Here is a snippet from the labels method where new Summary instance is created. self._kwargs here is empty, so no invariants, max_age_seconds and age_buckets are passed to __init__:
if labelvalues not in self._metrics:
    self._metrics[labelvalues] = self.__class__(
        self._name,
        documentation=self._documentation,
        labelnames=self._labelnames,
        unit=self._unit,
        _labelvalues=labelvalues,
        **self._kwargs
    )

Example
s = Summary(
    "request_latency_seconds",
    "Description of summary",
    invariants=((0.95, 0.005), (0.99, 0.001))
)
s.labels(method="GET", endpoint="/profile").observe(1.2)
s.labels(method="POST", endpoint="/login").observe(3.4)

In this example both observations are done with the DEFAULT_INVARIANTS.
Solution
The way it's handled for example in the Histogram class is just to put buckets in self._kwargs after the super class initialization. Apparently for the Summary the same should be done for the invariants, max_age_seconds and age_buckets:
def __init__(
    ...
) -> None:
    self._invariants = invariants
    self._max_age_seconds = max_age_seconds
    self._age_buckets = age_buckets
    self._lock = Lock()
    super().__init__(
        name,
        documentation,
        labelnames=labelnames,
        namespace=namespace,
        subsystem=subsystem,
        unit=unit,
        registry=registry,
        _labelvalues=_labelvalues,
    )
    self._kwargs['invariants'] = invariants
    self._kwargs['max_age_seconds'] = max_age_seconds
    self._kwargs['age_buckets'] = age_buckets

Thank you for contribution!
Released: https://pypi.org/project/prometheus-summary/0.1.3/

Thank you for contribution!
Released: https://pypi.org/project/prometheus-summary/0.1.3/

Awesome! Thank's for the fast merge


fix error with source language autodetect

Issue #, if available:
Description of changes:
Fix this error in start_transcribe for when user enables source language auto detection:
Configuration': {'MediaType': 'Audio', 'Enabled': True, 'TranscribeLanguage': 'auto'}, 'Status': 'Error', 'MetaData': {'transcribe_error': "An error occurred (BadRequestException) when calling the StartTranscriptionJob operation: 1 validation error detected: Value 'auto' at 'languageCode' failed to satisfy constraint: Member must satisfy enum value set: [en-IE, ar-AE, te-IN, zh-TW, en-US, ta-IN, en-AB, en-IN, zh-CN, ar-SA, en-ZA, gd-GB, th-TH, tr-TR, ru-RU, pt-PT, nl-NL, it-IT, id-ID, fr-FR, es-ES, de-DE, ga-IE, af-ZA, en-NZ, ko-KR, hi-IN, de-CH, cy-GB, ms-MY, he-IL, da-DK, en-AU, pt-BR, en-WL, fa-IR, ja-JP, es-US, fr-CA, en-GB]"}, 'Media': {}}

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

skipping code review for this trivial change


Include event triggers in results metadata

Is your feature request related to a problem? Please describe.
When going through results of a poutine scan (particularly with injections, untrusted_checkout_exec and know_vulnerability_in_component) I would like to know the event triggers for the workflow. Currently I have to open the file on the GitHub UI to check for each one.
Describe the solution you'd like
I would like to request a event_triggers field included in the metadata object returned for relevant results (results that are for a particular workflow)

Thanks for your feature request. Should be pretty easy to add to the JSON output.
@SUSTAPLE117 lets review tomorrow.

Closed by #233


show edit view when creator

currently going to a topic you own doesn't default to the edit view, have to type in /edit.

solved


Zotero: support for superscript/subscript in references

Zotero supports the insertion of sub/superscripts in references using ... and ... markups.
Unfortunately, OnlyOffice does not support this feature.
The markups are skipped, but the text format is not sub/superscript.

Hello @parrenin
Unfortunately, I didn't quite understand what you meant. Could you please provide more details about what you're asking for, or share an excerpt describing the requested feature from the Zotero website?

Sorry Vladimir, my message was unclear since the markups were actually used by github to make my text subscript/superscript...
I did correct the original message, so please have a look.
Zotero supports superscripts/subscript, in particular for title of articles.
I use it quite often because we often mention isotopes in our titles in my scientific field (e.g., 10Be).
The problem is that this superscript/subscript formatting is "lost" by OnlyOffice when one inserts a bibliography.

An example with OnlyOffice :

The same example with Word :

Note the superscript formatting in Word which does not exist in OnlyOffice.

@parrenin, I can confirm - this is bug, issue #66380.
Thanks for the report!

Hi Vladimir and Rita, I think there is a problem here.
This issue is NOT a duplicate of #197.
Prefix/suffix in citation and superscripts/subscripts in references are two different problems.
Please re-open this issue.

Yes, of course I can provide an explanation.
Prefix/suffix for a citation is as the following example: "as demonstrated (e.g., Prokoviev et al., 2024 and references therein)".
Here, "e.g., " is a prefix and " and references therein" is a suffix.
Superscript/subscript in a reference is as in the following example:
"Raisbeck, G. M., Cauquoin, A., Jouzel, J., Landais, A., Petit, J.-R., Lipenkov, V. Y., Beer, J., Synal, H.-A., Oerter, H., Johnsen, S. J., Steffensen, J. P., Svensson, A., and Yiou, F.: An improved north–south synchronization of ice core records around the 41 kyr 10Be peak, Climate of the Past, 13, 217–229, https://doi.org/10.5194/cp-13-217-2017, 2017."
Here, we use the superscripted "10" to mean one of the Beryllium isotope.

We apologize and appreciate your explanation.
We have found the features you requested in the Zotero application. We will reopen this issue.
Thank you very much for your report!

You are welcome @VladimirProkofiev52, and thanks for your work on this!


<EMAIL_ADDRESS>

Release: https://github.com/bazelbuild/rules_fuzzing/releases/tag/v0.5.1
Closes #1728

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (rules_fuzzing) have been updated in this PR. Please review the changes.

If it requires a new version, this one can be added or am I missing something ?

That's true, but we need to ensure that the next release is API compatible. That's why I would at least want to wait for @stefanbucur's approval.

@meteorcloudy Would he be okay with me becoming the BCR maintainer?

Yes, that's definitely fine!

+1, I think Fabian would be most qualified to maintain rules_fuzzing moving forward. Nowadays I have very little time on my end and I often am the bottleneck in reviewing & approving PRs too.

@mmorel-35 Could you add my contact info (you can get it from rules_go) here instead of Stefan's? You also have to exclude the replay test as it pulls in googletest. Then we can merge this, thanks for working on it!

would be great if we could merge this so i could use it in https://github.com/bazelbuild/bazel-central-registry/pull/1807

would be great if we could merge this so i could use it in #1807

@fmeum Is there something on my end that you folks are blocked on?

@stefanbucur No, I just didn't realize that this was updated and the checks were failing.
Bazel 6 support is lacking due to a bug fixed by https://github.com/bazelbuild/rules_fuzzing/pull/248, but this can wait for a new release. Testing the main repo itself was buggy for various reasons, but that's to be expected. Just testing the test module makes more sense and that works.

thanks!


Exit with access error if rebase container cannot access images

This prevents opaque errors where the rebase would fail trying to read labels on a inaccessible image:

ERROR: rebase working image: rebase: could not find base layer in image

Codecov Report

Merging #427 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #427   +/-   ##
=======================================
  Coverage   67.33%   67.33%
=======================================
  Files          85       85
  Lines        3612     3612
=======================================
  Hits         2432     2432
  Misses        894      894
  Partials      286      286

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e075180...2998cdf. Read the comment docs.


websocket_proxy.go should support lower case http_proxy

As there is no real standard for the proxy environment variable, systems can have either HTTP_PROXY or http_proxy.
websocket_proxy.go should handle both cases.

https://github.com/nlopes/slack/pull/204

easily fixed in your application:
os.Setenv('HTTP_PROXY', os.Getenv('http_proxy'))


Chart does not render unless options.labels contains at least one element

Expected Behavior
A chart should render whether labels have been assigned or not. At the very least, having to explicitly add a labels array with at least one empty element should not be required in order to get a chart to render.

Current Behavior
Currently, a stacked bar chart (and maybe others) will not render if options.labels is omitted or if options.labels is set to an empty array. If labels is even given a single, empty element, all datasets then render.
Note that this seems to be a regressive bug. The same chart definition renders in 2.1.x.

Possible Solution
Do not make rendering dependent upon labels.

Steps to Reproduce (for bugs)
See example here. http://plnkr.co/edit/0aUi8XZDf27EYKDDEZ4f?p=preview

Observe there is no chart.
Add a single, empty element to options.labels.
Observer there is now a chart.

Context
I was seeing a chart render in 2.1.x in an online site (https://codepen.io/jamiecalder/pen/NrROeB). I tried using a similar definition on my 2.6 Chart.JS application and was not seeing any results. After 30 minutes or so of piddling around I tried adding labels and after adding only a single label, all datasets rendered in the 2.6 chart.

Environment

Chart.js version: 2.6.0
Browser name and version: Chrome 60
Link to your project: http://plnkr.co/edit/0aUi8XZDf27EYKDDEZ4f?p=preview

This problem is caused by the function determineDataLimits in the file scale.category.js.
It only checks the labels to determine the minIndex and maxIndex.
A solution could be to add the following code before the other checks:
helpers.each(chart.data.datasets, function(dataset, datasetIndex) {
    // prevent errors when only Scale Constructor is called
    var isVisible = typeof chart.isDatasetVisible === 'function'
        ? chart.isDatasetVisible(datasetIndex)
        : true;
    if (isVisible) {
        if (dataset.data.length - 1 > me.maxIndex) {
            me.maxIndex = dataset.data.length - 1;
        }
    }
});

This would work, however a fixed max option would still only check the labels.
Are there any documented behavioral specs for the scales?

This seems to have been fixed in 2.7.0 already: http://plnkr.co/edit/3Bue4TgScDgydS657obJ?p=preview

Great find @kurkle!


Running notes on TGO

I have to create a new TGO for each call of #runBoard in bb-main. Without this it doesn't seem to create a new run and the graph data is stale.
There's no TGO created for a serializedrun. I think we might need one so we can show values on the wire?

cc @dglazkov

Ref #2993

The activity entries in topGraphResult.log are something like  {type: 'node', description: 'Model Input'}, which means they can't currently be used to show in-depth debug info

Our inputs come through as "user", but that means they don't align with the graph.

We don't currently carry the previous run or configured value for a given edge. If we have that we can pre-populate the Activity Log's inputs

Some edges don't ever light up, because the activity log does not contain information about them.

Show different icons for different types of wire data, and for LLM Content Array in particular, show the number of items in the array.

Asking for unknown secrets doesn't work anymore.


evaluation tracker implementation

This PR introduces enhanced evaluation tracking by adding a dedicated class responsible for storing, saving and pushing data to the Hugging Face Hub. It includes several improvements for reproducibility such as saving model and data sha, adding saving times to file names or directory based on the model name.

No additional packages required
Backward compatibility

@clefourrier @NathanHB

Thanks for spotting these! Should be good now

Test failures unrelated, as far as I can tell!

Hi, facing the error:
File "/content/lm-evaluation-harness/lm_eval/main.py", line 266, in cli_evaluate
evaluation_tracker_args.push_results_to_hub
AttributeError: 'Namespace' object has no attribute 'push_results_to_hub'
as far as I understand, this might relate to the latest updates.
the lm-evaluation harness is installed via cloning the repository and running !pip install -e .

@KonradSzafer is investigating, thanks for the report!

Can you given an example of what an eval looks like when it is pushed to the hub? A link to some eval on the hub would be really helpful to understand what this really looks likel.

Can you given an example of what an eval looks like when it is pushed to the hub? A link to some eval on the hub would be really helpful to understand what this really looks likel.

Hi @eitanturok, sure, here is the sample output from the phi-2 evaluation on the arc_easy task. Note that the structure of the samples file may differ from task to task. :)
@haileyschoelkopf Can I add a link to this demo output to the readme/docstring?

@KonradSzafer yes, a link in the docs to this would be appreciated!

@KonradSzafer
Can you please elaborate on issues https://github.com/EleutherAI/lm-evaluation-harness/issues/1842 and https://github.com/EleutherAI/lm-evaluation-harness/issues/1918 (at least these, may be more with less descriptive names). This PR with changing log storing structure is actually not backward compatible, and may be marked as "breaking changes".
Is there a solution to use best from both worlds (old directory structure of logs and samples, and this new one, currently causing issues here and there)?

I like the new one with dates in directory/file names, so nothing is accidentally overwritten. And I am using results from the most recent file.

@LSinev I created #1926 where I fixed these issues and answered them, please take a look.
I don't think there's any way to go back to the old naming convention. As @djstrong mentioned, it was intentionally created to make it harder to accidentally overwrite your costly results, and to make it easier to manage multiple runs by including datetimes and task/model names. I think the new PR should make it much easier to develop new parts of the library that need to use result files.


Add cop to check for ActiveModel errors hash direct manipulation

This cop checks direct manipulation of ActiveModel#errors as hash.
These operations are deprecated in Rails 6.1 and will not work in Rails 7.
This was recently added to GitLab codebase and doesn't seem to create too much noise, but any advice is welcomed.
It's my first time using the parser so if there is a more elegant way to write the checker please let me know ^^.
# bad
user.errors[:name] << 'msg'
user.errors.messages[:name] << 'msg'

# good
user.errors.add(:name, 'msg')

# bad
user.errors[:name].clear
user.errors.messages[:name].clear

# good
user.errors.delete(:name)

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
[ ] If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@lulalala Is there any guidance on how to migrate away from direct Hash access when testing? Not sure if it fits better as an rubocop-rspec check, but I can imagine there are lots of codebases using these patterns:
expect(model.errors).to have_key(:name)
expect(model.errors[:name]).to include("cannot be blank")

@lulalala Is there any guidance on how to migrate away from direct Hash access when testing? Not sure if it fits better as an rubocop-rspec check, but I can imagine there are lots of codebases using these patterns:

@swanson This cop will only dealt with manipulation, not reading(accessing), but to answer your questions:

expect(model.errors).to have_key(:name)

For this, we will be moving to:
expect(model.errors.attribute_names).to include(:name)

expect(model.errors[:name]).to include("cannot be blank")

My preferred way would be:
expect(model.errors.added?(:name, :blank)

Hi @koic I've made some changes and replied to your questions. Could you check please? Thanks! 🏓

Hi @koic could you recheck please? Thanks!

Hi @koic could you recheck please? I've rebased and everything is passing now. Thanks!

Hi @koic could you recheck please? I've rebased and everything is passing now. Thanks!

Thanks @pirj I've pushed some changes up (except the last one because it's not working).
This is extracted from gitlab, which is quite large already, but I still went ahead and tried "real-world-rails". Would you happen to know how to rubocop into git submodules' content?

I guess the failure is due to
expected "add_active_model_errors_direct_manipulation.md" to match /\A(new|fix|change)_.+/

it should start with "new_".

Looks good to me!

@pirj great! Should I ask you or @koic to merge?

I'm wondering about false positives for many of the methods defined in MANIPULATIVE_METHODS.
Maybe it seems better useful to add auto-correction with a cop called DeprecatedActiveModelErrorsMethods that is limited to the following three deprecated methods.
% cd path/to/github.com/rails/rails
% git checkout v6.1.4
% g grep 'ActiveModel::Errors message'
activemodel/lib/active_model/errors.rb:617:      ActiveSupport::Deprecation.warn("Calling `delete` to an ActiveModel::Errors messages hash is deprecated. Please call `ActiveModel::Errors#delete` instead.")
activemodel/lib/active_model/errors.rb:646:      ActiveSupport::Deprecation.warn("Calling `<<` to an ActiveModel::Errors message array in order to add an error is deprecated. Please call `ActiveModel::Errors#add` instead.")
activemodel/lib/active_model/errors.rb:654:      ActiveSupport::Deprecation.warn("Calling `clear` to an ActiveModel::Errors message array in order to delete all errors is deprecated. Please call `ActiveModel::Errors#delete` instead.")

Well, I will merge this cop after the next bug fix release.
Before that, please add @safety directive and that description to the doc and squash your commits into one.
e.g. https://github.com/rubocop/rubocop-rails/pull/575/files#diff-55131ec8d7f289891ec6c20ab3d87bdf66c4c9da7bb29bc9a5482abf6e1ba2ed
Apart from that, I may have a look at what to do with (unsafe) auto-correction later. Anyway, it will not covered in this PR :-)

@koic I've added @safety now. Thanks.
You already mentioned that you will review this after the next bug release though (which was 2.12.3). I was hoping we can speed up the process if there is nothing blocking the way, please?

@koic I've renamed the cop. Thanks.

This looks good to me. Can you squash your commits into one?

@koic OK I've squashed them. Thanks.

@lulalala Thank you!

[] by itself is not deprecated, but []<< is. I think in rails 7 we
still want to prevent these kind of direct manipulation since they will not
have a lasting effect.
Bohdan Schepansky @.***> 於 2022年11月25日 週五 20:48 寫道：

Looks like this cop has been made obsolete by this commit
https://github.com/rails/rails/commit/ef40a92c1c4d2ddb88158058ac7a28fee554a958,
and [] is no longer deprecated. What's interesting, though, is that this
has actually happened before this PR was even merged...
—
Reply to this email directly, view it on GitHub
https://github.com/rubocop/rubocop-rails/pull/491#issuecomment-1327434224,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACZSPQKFOO5ICG4AY2I67LWKCYTRANCNFSM45G6GWOQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Self-reference dependency has unused export name when imported inside of a web worker

Bug report

What is the current behavior?
When a web worker imports a CommonJS module with a self reference dependency, webpack throws Error: Self-reference dependency has unused export name: This should not happen.
This happens when usedExports is set to "global".
I think this is related:
https://github.com/webpack/webpack/issues/12646 / https://github.com/webpack/webpack/pull/12648
It seems like that fix works when usedExports is not set to "global", but it doesn't work when usedExports: "global" is set.
If the current behavior is a bug, please provide the steps to reproduce.
Repro: https://github.com/pgoldberg/webpack-self-reference-dependency-worker-bug

What is the expected behavior?
Webpack should not throw an error
Other relevant information:
webpack version:  5.91.0
Node.js version: any
Operating System: any
Additional tools:

Hello, I did so work in this issue, and find out the process of bug occurrence， but I got no clue how to solve it,  could anyone please give some suggestion
Should I just ignore this error in CommonJsSelfReferenceDependency when config 'usedExports'?
@alexander-akait

Hm, you can send a PR and we will look our tests

Please keep open

Create a Webpack configuration with the usedExports: "global" option set.
Import a CommonJS module that has a self-reference or circular dependency inside a Web Worker.
Webpack will throw the error: Self-reference dependency has unused export name: This should not happen.
Expected Behavior
Webpack should handle self-referencing or circular dependencies correctly without throwing an error, even with usedExports: "global" set.
The usedExports: "global" optimization should work without causing issues in such cases.
Potential Workaround
Since this issue might be related to the specific optimizations when usedExports is set to "global", you could try the following:
Use a different optimization setting: Instead of "global", try using "false" or "true" for usedExports, as this could bypass the issue by not triggering the optimization that causes the error.
optimization: {
usedExports: "false", // or "true"
}
Ensure the module structure is not self-referencing: If possible, refactor the CommonJS module to avoid circular dependencies or self-referencing exports, though this might not always be feasible depending on your codebase.
Use a different bundling strategy: Depending on your setup, consider testing alternative bundlers or adjusting your worker-related configurations to avoid relying on usedExports: "global" if that is causing the issue.
Update Webpack or Patch: Since the issue is potentially related to a Webpack bug (#12646, #12648), check if there are any newer Webpack versions or patches that address this problem. If not, you might need to apply a custom fix or rollback to a version where the issue isn't present.
Additional Resources
Review the issues on Webpack's GitHub related to circular dependencies and self-referencing modules.
Check Webpack's documentation for any updates on usedExports optimization and its behavior with CommonJS and web workers.
If you're able to isolate the issue in a minimal example (as you did in your repo), it can be helpful to provide it to the Webpack team for further investigation.


no css?

the project has no css? the table class exist where?

@shshk8384 exactly. This plugin doesn't use css. You can use your custom CSS.


Webpack Installing Bootstrap

I followed the instructions in  https://getbootstrap.com/docs/4.0/getting-started/webpack/ and also  I installed jquery and popper.js with npm.
Still when I use the output bundle.js, the browser keeps on sending GET requests for popper.js.map, which of course is missing in the sever.
I searched a lot for the proper answer but none that explains whats wrong with the instructions mentioned above, exists.
Please help.

Sorry, but we cannot help with how-to or general troubleshooting issues here; only bug reports and feature requests. You'll want to ask around in the official Slack team or Stack Overflow. See our readme for more details.

@jonathan-se It's been a while but I was finally able to fix this issue myself by excluding source maps for Popper.js.
https://stackoverflow.com/a/49946403/3446655
I wanted to add this here for anyone else who might land here looking for a solution.


Wrap Slack web API methods?

I made a small wrapper for the Slack web API methods, and I figure it might be useful functionality for the adapter itself (it'd help with #202, for example.) Should I work on a PR for this, or does it make more sense to keep hubot-slack-api separate?
 That's a bit silly.

The adapter has an instance of a node-slack client as client. You should be able access it at robot.adapter.client.
Possible relevant, but I'm experimenting with a custom response object over in https://github.com/slackhq/hubot-slack/pull/234 so a script can do a Slack-specific response in scripts. There's only attachment, but some API commands might be relevant.

Closing, since there is a way to call the API. I'm going to make a note to include documentation though.


Why is polling used?

Isn't it possible to subscribe to push notification without the need of polling S3 for updates?

S3 notifications can go to SNS, which can be consumed by something server-side. This is updating entirely on the client-side.
To update the client side properly would require a websocket for each client, something Lambda doesn't support as it has a max 5 minute operating window.

@pas256 I was intrigued by this idea too.
BTW I've just come across your project, glad I did because I was just about to code it myself!
I had a nearly-identitical architecture in mind, differing only by storing messages in SQS.  Which may not be a good idea if your chat supports >2 chatters (mine doesn't).
I've seen references to SQS supporting long-polling JS clients, such as here: https://github.com/lg/lambda-job
Just a thought!

Nice. I didn't know about that project. Thanks.


Show Crashlytics logs in Xcode

Feature proposal

Firebase Component: Crashlytics

Would be neat to provide a way to output the crashlytics logs to Xcode as well, when debugging on a device or simulator.

I think that the crashes in Xcode are symbolicated using the dSYMs you upload to App Store Connect.
I don’t think Apple is uploading crashes when running locally, even if that happens you will need a way to upload the dSYMs
Nothing to do with Firebase Crashlytics IMO

It's not about the crashes, but as the title says about the logs that you get with Crashlytics.crashlytics().log(message).


*: 'ignore_value' to detach lease with PutRequest

Fix https://github.com/coreos/etcd/issues/6848.

@xiang90 Please review. Thanks.

/cc @sinsharat
I think @sinsharat is working on the similar thing. Can you look through this?

@gyuho thanks for working on this as i am stuck with travel. Please give me some time to review this as i am still on travel for another 4days and don't have my laptop or internet connection with me to review it properly.
Thanks!

missing grpcproxy support?

i am not convinced about putting a new key with an empty value when preserve-value is passed and the key doesn't exist. I feel it should return an error instead, since the main purpose of this flag is to detach lease for an existing key without passing value to it.

i am not convinced about putting a new key with an empty value when preserve-value is passed and the key doesn't exist. I feel it should return an error instead

@sinsharat Actually this PR returns error here https://github.com/coreos/etcd/pull/6894/commits/a8104dd309b0d6ae6ea1f29bd78c55a411de5a9a?
But we need better documentation on that case.

@gyuho if that's the case we probably need to work on correcting comments as well.
Thanks!

@heyitsanthony @sinsharat All fixed. PTAL.

@gyuho Do we support lease flag along with preserver value? Have you tested it?

@sinsharat Yeah I added a test case for that. Write with key and empty value with preserve-value flag and lease id will overwrite the previous key-value pair with the previous value and specified lease.

@heyitsanthony All addressed. PTAL. Thanks!
Please note that applyUnion method signature changed.
/cc @sinsharat

@xiang90 @heyitsanthony @sinsharat I kept the error to be consistent with that we return error in put command if value is specified. And changed the field name to ignore_value.
PTLA.
Thanks.

@gyuho LGTM except for the doc desc i still feel some info about its usage should be provided. May be @xiang90  and @heyitsanthony can take a call on it. Also the abd is not clear to me.
Thank you!

@gyuho i cannot find the test case of ignore_value flag with lease flag and also ignore_value flag with prev_kv flag. Can you let me know where its added.
Thanks!

@sinsharat @heyitsanthony Just added more lease-related test cases to integration. PTAL. Thanks.

LGTM. Defer @heyitsanthony .
Thank you!

lgtm after fixing rpctypes nits

defer merge until after cutting 3.1, though?

@heyitsanthony Yeah sure. Let's hold this until after 3.1
And did you mean we should define etcdserver.ErrKeyNotFound in rpctypes pkg instead?
Thanks!

@gyuho yeah, shouldn't need to import etcdserver; the tests are already using rpctypes

This has been reviewed. Just rebased on master branch. Merging in greens. Thanks.

@gyuho I put a release note on this.

Ok ack (for v3.2)


CPU jump to 400% , too much battery drain + the solution ( iPhone 11 Pro Max 13.3)

Lately noticed that my battery drains too much , when i checked the processes i saw that the CPU usage was always around 300 to 400% checked and found that it was caused by Accountsd, Securityd and Cloudd, tried eveything even disabled all the Tweaks but with no luck , signed out of icloud and the CPU came back to normal but when i signed in again the CPU jumped back to high usage, the only solution was “LDrestart” after using it everything went back to normal, so it means that its caused by ur new userspace reboot technique, hope u fix it soon

Have you considered Restore RootFS as an option to remedy your issue?

As i said when u LDrestart after the jailbreak it fixes it until u reboot and rejailbreak

What version of unc0ver are you on?

4.3.1 , now even LDrestart doesnt help ,i even restored rootFS

list your tweaks
You can use Flame to get the list.

@blackray88 make sure you are using unc0ver v4.3.1. Please post your unc0ver diagnostics.

He has already stated that he is using 4.3.1
You need to list your tweaks before we can go from here.

@Hamlock-Maneuver this reply is redundant. I said everything that needs to be done.

No response


[ WIP ][ layer ] Custom Multi Head Attention layer on GPU

Changes made in this PR:

Added CustomMultiHeadAttentionLayerCl class with GPU implementation of custom MHA from FELICE repo.
Added API endpoint CustomMultiHeadAttention and required enums.
Modified cl_context to register custom MHA.

Work In Progress:

Add BiQGEMM OpenCL kernel

Signed-off-by: Debadri Samaddar<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2671. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

:octocat: cibot: @s-debadri, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2671-202407091646050.6778450012207-e52ce376986fd72e74aa009b4e9aaf6e261426a5/.

:octocat: cibot: @s-debadri, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2671-202407111442090.92210292816162-f14b95828c6e0168178dfa53341744ceb41294a5/.

Closing as it is a custom implementation which is being used separately.


fix: added additional matrix1 test case for different arguments to fix hard code issue #43050

Checklist:

[X] I have read freeCodeCamp's contribution guidelines.
[X] My pull request has a descriptive title (not a vague title like Update index.md)
[X] My pull request targets the main branch of freeCodeCamp.
[X] I have tested these changes either locally on my machine, or GitPod.

Closes #43050

This is my first time contributing! Thank you for leaving this issue for first timers!
I tested manually from localhost with the provided hardcoded method.
it correctly makes it fail.
I was running into issue while in developing.
After I changed the code, it would not replace the page.
it says something like error attempting to replace '...md' cannot find '1' something like that.
also, not sure if it's my computer, but starting takes it 5 mins or more to get ready to start building pages.

I think it would be best to add a new test, without changing the seed or the solution, that say something like "zeroArray(4, 3) should return [[0, 0, 0],[0, 0, 0], [0, 0, 0], [0, 0, 0]]"

@julschong about the issue when developing. Are you developing on Windows? I see your fork on github is about month behind main branch of https://github.com/freeCodeCamp/freeCodeCamp. If your local version also has such age, it could be the reason. Around that time there was bug, affecting Windows, that wasn't allowing to update pages in curriculum without restart. Updating local fork should make the problem go away.

I'll give it a try now!

@julschong about the issue when developing. Are you developing on Windows?

I'm using windows and gitbash.

I see your fork on github is about month behind main branch of https://github.com/freeCodeCamp/freeCodeCamp. If your local version also has such age, it could be the reason. Around that time there was bug, affecting Windows, that wasn't allowing to update pages in curriculum without restart. Updating local fork should make the problem go away.

this fixed the issue! it successfully replaced changed file when I saved 💯
thank you!

I'm using windows surface  2021 but this is what I'm looking at on my end
as for as issue goes 😎 thanks
On Sat, Jul 31, 2021, 11:49 AM gikf @.***> wrote:

@julschong https://github.com/julschong about the issue when
developing. Are you developing on Windows? I see your fork on github is
about month behind main branch of
https://github.com/freeCodeCamp/freeCodeCamp. If your local version also
has such age, it could be the reason. Around that time there was bug,
affecting Windows, that wasn't allowing to update pages in curriculum
without restart. Updating local fork should make the problem go away.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/freeCodeCamp/freeCodeCamp/pull/43086#issuecomment-890373811,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUDDHOWUT2WCVQN77JT2QKDT2QSQZANCNFSM5BJZ43JQ
.

what a mess I've made :(
but now there is no extra seed and solution variable.
additional test case just test using zeroArray(4,3)
I thought to add it to other languages and had to revert that commit.

Thank you!


Change mDL scope name and remove trustbloc from contents

user’s won’t understand the abbreviation “mDL” on the consent page - is there a way to make the UI show a user friendly version?
The “here is your generated credential” page has degree: null (and seems to be the degree schema rather than DL
Fix the DL data

The abbreviation "mDL" on the consent page is due to the fact that the OAuth2 scope is tightly coupled to the VC generation: https://github.com/trustbloc/edge-sandbox/blob/e1ca29b3cbb25cc6497979f0181c24e7244fbfb8/pkg/restapi/issuer/operation/operations.go#L637.

It would be nice if we could get rid of that consent screen altogether... why is the user consenting so many times? Should only be once (in their wallet, when the RP asks for credentials).


[Bug]Deploy Preview - Table Widget - Table Data - Clicking on table data field and expanding/clicking on any of the expected property types 'ReferenceError: fetch_users not defined' error occurs

Description
Deploy Preview - https://deploy-preview-5270--appsmith-editor-ce.netlify.app/applications
It is observed that by clicking on the table data and expanding any of the expected property type - 'ReferenceError: fetch_users is not defined' error occurs
Expected Result:
User should be able to expand any of the expected property types without any errors
Steps to reproduce the behaviour:

Launch Appmsith app in the Deploy Preview -  https://deploy-preview-5270--appsmith-editor-ce.netlify.app/applications
Drag and Drop table widget
Click on Table data
Try to click or expand any of the expected property types and observe

Screenshot:

Important Details

Version: [Version 11.3]
OS: [MacOS big Sur]
Browser [chrome, safari]
Environment [deploy preview]

@YogeshJayaseelan This has been fixed. Closing this issue.


added support for ops mgr 1.12 & migration from 1.11.x

added migration logic from 1.11.x to 1.12. The migration preserves all new relic services and service instances which were created with the older version of the tile.

@shahramk Thanks!


Update FIPS logic to include Canadian FIPS codes

FYSA: @Adrian-Brewster @anshulkumar-usds @mlighdc @emmastephenson @LGFranklin

We don't need to do this one. VT has said they don't need this value, and it seems incredibly complex. Closing out.


Besu doesn't handle test filenames longer than 77 chars?

https://twitter.com/vdWijden/status/1414618299585925120/photo/1

Looks like already logged as #2532

After discussion with Marius we can close this ticket. it changed the name of the files and it doesn't seem related to Besu


Strawdraft of a Vision and Mission, for discussion

Intended for discussion in the pull request so the first landed version draft for discussion has more brains on it than mine.
Discussions can happen in the changed file area or as comment below.

@just noticed had not merged - I will skip it till we discuss since it looks like it did not pass checks


Can not create service on postgres if default.json already has the connection string

https://stackoverflow.com/questions/44814788/how-to-create-feathersjs-services-with-knex-postgres/44815184#44815184
Steps to reproduce
While trying out FeathersJS, i tried to create two services following the docs. The first is called x and the other y.
When I create x with
~/r/feathers-chat ❯❯❯ feathers generate service
? What kind of service is it? KnexJS
? What is the name of the service? x
? Which path should the service be registered on? /x
? Which database are you connecting to? PostgreSQL
? What is the database connection string?
  postgres://user:password@localhost:5432/feathers_chat

Everything works perfectly.
When I create y
~/r/feathers-chat ❯❯❯ feathers generate service
? What kind of service is it? KnexJS
? What is the name of the service? y
? Which path should the service be registered on? /y
? Which database are you connecting to? PostgreSQL

The following error is thrown.
events.js:160
  throw er; // Unhandled 'error' event
  ^

TypeError: Parameter "url" must be a string, not object
at Url.parse (url.js:88:11)
at Object.urlParse [as parse] (url.js:82:5)
at ConnectionGenerator._getConfiguration (/Users/user/.nvm/versions/node/v6.10.2/lib/node_modules/feathers-cli/node_modules/generator-feathers/generators/connection/index.js:46:24)
at ConnectionGenerator._writeConfiguration (/Users/user/.nvm/versions/node/v6.10.2/lib/node_modules/feathers-cli/node_modules/generator-feathers/generators/connection/index.js:103:32)
at ConnectionGenerator.writing (/Users/user/.nvm/versions/node/v6.10.2/lib/node_modules/feathers-cli/node_modules/generator-feathers/generators/connection/index.js:293:10)
at Object.<anonymous> (/Users/user/.nvm/versions/node/v6.10.2/lib/node_modules/feathers-cli/node_modules/yeoman-generator/lib/index.js:417:23)
at /Users/user/.nvm/versions/node/v6.10.2/lib/node_modules/feathers-cli/node_modules/run-async/index.js:25:25
at /Users/user/.nvm/versions/node/v6.10.2/lib/node_modules/feathers-cli/node_modules/run-async/index.js:24:19
at /Users/user/.nvm/versions/node/v6.10.2/lib/node_modules/feathers-cli/node_modules/yeoman-generator/lib/index.js:418:9
at runCallback (timers.js:666:20)

It seems that the feathersJS client crashes when there a postgres connection defined in the default.js
So if i create the connection before hand, the client crashes upon creating the first service with the same exact error.
I uninstalled<EMAIL_ADDRESS>and installed version 2.1.1 and I had no more problems.
System configuration
Module versions (especially the part that's not working):
<EMAIL_ADDRESS>NodeJS version:
v6.10.2
Operating System:
MAC OS  10.12.4

So it worked in a previous version? I think this regression might be caused by https://github.com/feathersjs/generator-feathers/pull/229

Yes, it worked just fine in the previous version. l will give it a look

I just submitted a PR that should resolve the issue.

Closed via #240, thank you @jdziat!

I'm seeing this issue while using cli v2.3.5 - could I be missing something? Again, reverting to 2.1.1 solves it for me.

@alzab Can you create a new issue with the steps to reproduce to keep track of this?

@daffl sure thing - https://github.com/feathersjs/generator-feathers/issues/274 - in my case I was using a custom connection object


Error: access violation accessing 0x1f380000

wechaty-puppet-xp版本：1.11.13
微信版本：<IP_ADDRESS>
运行时偶尔会崩溃
Error: access violation accessing 0x1f380000
at sendAtMsgNativeFunction (/script1.js:1122)
at __sidecar__sendAtMsg_Function_wrapper (/script1.js:1661)
at apply (native)
at  (frida/runtime/message-dispatcher.js:13)
at c (frida/runtime/message-dispatcher.js:23) {
type: 'access-violation',
address: '0x5e79a195',
memory: { operation: 'read', address: '0x1f380000' },
context: {
pc: '0x5e79a195',
sp: '0x195aebac',
eax: '0x1f37ff00',
ecx: '0x1a7876a8',
edx: '0x80',
ebx: '0x1f180701',
esp: '0x195aebac',
ebp: '0x195aee84',
esi: '0xa',
edi: '0x1a7876a8',
eip: '0x5e79a195'
},
nativeContext: '0x0',
fileName: '/script1.js',
lineNumber: 1122
}

@cixingguangming55555 Please help confirm this bug. It is suspected that there is an address access conflict.


remove reviewapp

ref: https://github.com/cloudnativedaysjp/dreamkast-infra/pull/1035

Review app
https://dreamkast-dk-920.dev.cloudnativedays.jp


error getting AWS credentials from environment

I followed this tutorial
I have communication between all hosts containers working fine, but I still getting the following error at flanneld.service
Jul 05 03:53:43 ip-10-10-10-127.us-west-1.compute.internal systemd[1]: flanneld.service holdoff time over, scheduling restart.
Jul 05 03:53:43 ip-10-10-10-127.us-west-1.compute.internal systemd[1]: Starting Network fabric for containers...
Jul 05 03:53:43 ip-10-10-10-127.us-west-1.compute.internal etcdctl[18469]: { "Network": "<IP_ADDRESS>/16", "Backend": { "Type": "aws-vpc" } }
Jul 05 03:53:43 ip-10-10-10-127.us-west-1.compute.internal sdnotify-proxy[18474]: I0705 03:53:43.671582 00001 main.go:278] Installing signal handlers
Jul 05 03:53:43 ip-10-10-10-127.us-west-1.compute.internal sdnotify-proxy[18474]: I0705 03:53:43.672760 00001 main.go:228] Using <IP_ADDRESS> as external interface
Jul 05 03:53:43 ip-10-10-10-127.us-west-1.compute.internal sdnotify-proxy[18474]: I0705 03:53:43.852589 00001 subnet.go:97] Subnet lease acquired: <IP_ADDRESS>/24
Jul 05 03:53:43 ip-10-10-10-127.us-west-1.compute.internal sdnotify-proxy[18474]: E0705 03:53:43.854286 00001 main.go:213] error getting AWS credentials from environment: AWS_SECRET_ACCESS_KEY or AWS_SECRET_KEY not found in environment
Jul 05 03:53:43 ip-10-10-10-127.us-west-1.compute.internal sdnotify-proxy[18474]: I0705 03:53:43.854795 00001 main.go:295] aws-vpc mode exited
Jul 05 03:53:43 ip-10-10-10-127.us-west-1.compute.internal systemd[1]: flanneld.service: main process exited, code=exited, status=1/FAILURE
Jul 05 03:53:43 ip-10-10-10-127.us-west-1.compute.internal systemd[1]: Failed to start Network fabric for containers.
Jul 05 03:53:43 ip-10-10-10-127.us-west-1.compute.internal systemd[1]: Unit flanneld.service entered failed state.
Jul 05 03:53:43 ip-10-10-10-127.us-west-1.compute.internal systemd[1]: flanneld.service failed.

I'm using the following cloud-config:
#cloud-config

write_files:
- path: /etc/systemd/system/docker.service.d/increase-ulimit.conf
  owner: core:core
  permissions: 0644
  content: |
    [Service]
    LimitSIGPENDING=481114
    LimitNOFILE=65535
    LimitNPROC=481114

coreos:
  etcd2:
    advertise-client-urls: http://$private_ipv4:2379
    initial-advertise-peer-urls: http://$private_ipv4:2380
    listen-client-urls: http://<IP_ADDRESS>:2379,http://<IP_ADDRESS>:4001
    listen-peer-urls: http://$private_ipv4:2380
    initial-cluster: node1=http://<IP_ADDRESS>:2380,node2=http://<IP_ADDRESS>:2380,node3=http://<IP_ADDRESS>:2380
    initial-cluster-state: new
  fleet:
    public-ip: $private_ipv4
    metadata: region=us-west-1,public_ip=$public_ipv4
  flannel:
    interface: $private_ipv4
  units:
  - name: etcd2.service
    command: start
  - name: fleet.service
    command: start
  - name: docker-tcp.socket
    command: start
    enable: true
    content: |
      [Unit]
      Description=Docker Socket for the API

      [Socket]
      ListenStream=2375
      Service=docker.service
      BindIPv6Only=both

      [Install]
      WantedBy=sockets.target
  - name: docker.service
    command: restart
  - name: flanneld.service
    command: start
    drop-ins:
    - name: 50-network-config.conf
      content: |
        [Service]
        ExecStartPre=/usr/bin/etcdctl set /coreos.com/network/config '{ "Network": "<IP_ADDRESS>/16", "Backend": { "Type": "aws-vpc" } }'

Looks like when flannel run from inside a docker container it can't auto-discovery aws metadata.
If I manually specify AWS environment variables and route table id, like example below, it works fine.
#cloud-config

write_files:
- path: /etc/systemd/system/docker.service.d/increase-ulimit.conf
  owner: core:core
  permissions: 0644
  content: |
    [Service]
    LimitSIGPENDING=481114
    LimitNOFILE=65535
    LimitNPROC=481114

coreos:
  etcd2:
    advertise-client-urls: http://$private_ipv4:2379
    initial-advertise-peer-urls: http://$private_ipv4:2380
    listen-client-urls: http://<IP_ADDRESS>:2379,http://<IP_ADDRESS>:4001
    listen-peer-urls: http://$private_ipv4:2380
    initial-cluster: 8e7efe97ba82470e8d6e26dfbbdc3604=http://<IP_ADDRESS>:2380,1c77cb5484ec4542b83493a4dd0fbebe=http://<IP_ADDRESS>:2380,da2e027b248f4f63adf3d3efb4238e8d=http://<IP_ADDRESS>:2380
    initial-cluster-state: new
  fleet:
    public-ip: $private_ipv4
    metadata: region=us-west-1,public_ip=$public_ipv4
  flannel:
    interface: $private_ipv4
  units:
  - name: etcd2.service
    command: start
  - name: fleet.service
    command: start
  - name: docker-tcp.socket
    command: start
    enable: true
    content: |
      [Unit]
      Description=Docker Socket for the API

      [Socket]
      ListenStream=2375
      Service=docker.service
      BindIPv6Only=both

      [Install]
      WantedBy=sockets.target
  - name: docker.service
    command: restart
  - name: flanneld.service
    command: start
    drop-ins:
    - name: 50-network-config.conf
      content: |
        [Service]
        Environment="AWS_ACCESS_KEY_ID=MY_KEY_ID"
        Environment="AWS_SECRET_ACCESS_KEY= MY_KEY_SECRET"
        ExecStartPre=/usr/bin/etcdctl set /coreos.com/network/config '{ "Network": "<IP_ADDRESS>/16", "Backend": { "Type": "aws-vpc", "RouteTableID": "MY_VPC_ROUTE_TABLE_ID" } }'

@diegomarangoni Thanks for pointing this out.
Did you try this using IAM roles as well? And once you set the AWS_ACCESS_KEY_ID and the AWS_SECRET_ACCESS_KEY was flannel still unable to discover the route table id?

Hi @MohdAhmad
Yes, I tried with IAM roles as well but didn't worked.
Works perfectly when I set AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY and RouteTableID.
My guess is that using IAM roles only works when flannel runs natively (from outside a docker container).
I'm using the cloud-init below, and its working fine:
#cloud-config

coreos:
  etcd2:
    advertise-client-urls: http://$private_ipv4:2379
    initial-advertise-peer-urls: http://$private_ipv4:2380
    listen-client-urls: http://<IP_ADDRESS>:2379,http://<IP_ADDRESS>:4001
    listen-peer-urls: http://$private_ipv4:2380
    initial-cluster: node1=http://<IP_ADDRESS>:2380,node2=http://<IP_ADDRESS>:2380,node3=http://<IP_ADDRESS>:2380
    initial-cluster-state: existing

  fleet:
    public-ip: $private_ipv4
    metadata: region=us-west-1,public_ip=$public_ipv4

  flannel:
    interface: $private_ipv4

  units:
  - name: flanneld.service
    drop-ins:
    - name: 50-network-config.conf
      content: |
        [Unit]
        After=clickwings.service

        [Service]
        Environment="AWS_ACCESS_KEY_ID=my_aws_access_key_id"
        Environment="AWS_SECRET_ACCESS_KEY=my_aws_secret_access_key"
        ExecStartPre=/usr/bin/etcdctl set /coreos.com/network/config '{ "Network": "<IP_ADDRESS>/16", "Backend": { "Type": "aws-vpc", "RouteTableID": "my-rtb-id" } }'
    command: start

  - name: etcd2.service
    command: start

  - name: fleet.service
    command: start

  - name: docker-tcp.socket
    content: |
      [Unit]
      Description=Docker Socket for the API

      [Socket]
      ListenStream=2375
      Service=docker.service
      BindIPv6Only=both

      [Install]
      WantedBy=sockets.target
    command: start
    enable: true

  - name: docker.service
    drop-ins:
    - name: 60-wait-for-flannel.conf
      content: |
        [Unit]
        After=flanneld.service
        Requires=flanneld.service
        Restart=always
    command: restart

Hi @diegomarangoni, can you please share which coreos release you are using? Since this functionality was added in flannel v0.5 which only recently made it to coreos release, I am concerned that this may be an older version.

Hi, @MohdAhmad, I'm running the AMI CoreOS-stable-681.2.0-hvm (ami-c967938d) and the flannel version is v0.4.
According with this blog post at CoreOS official blog:
... Amazon Virtual Private Cloud (Amazon VPC) backend introduced in flannel v0.4 and the newly added GCE backend.
 Should I reopen?
Anyway, I doing a new test with coreos-alpha, and I let you know.
Thanks

Ok, now I saw the v0.5 changelog:
* AWS-VPC: Auto-detect route table ID if DescribeInstances permission is granted. Thank you, @MohdAhmad

But anyway, the error contested about getting AWS credentials from environment: AWS_SECRET_ACCESS_KEY or AWS_SECRET_KEY not found in environment

@diegomarangoni Thanks for sharing again.
With flannel v0.5 if you define an IAM role, as shown in the tutorial, then you do not need to specify the credentials or the route table id in the cloud config. But if you use AWS_SECRET_ACCESS_KEY and the AWS_SECRET_KEY then you will need to specify them in the cloud config. Running flannel inside a docker container or running it natively should not make a difference in this case. Hope this helps.

@MohdAhmad, I've just made a test by upgrading to v0.5 and works perfectly!
Thanks :)

@diegomarangoni great news!


add logger

Custom logger for LemLib.
Untested: Colors may or may not work
Todo: Log things in actual LemLib implementations
Due to git issues, it is re-committing the doxygen pr.

This should be implemented in existing functions (for example, throwing an error when trying to move the chassis before it has been calibrated). I'll take a closer look this afternoon and do some testing

yeah that was part of the todo, the logger itself is implemented but it needs to be called in functions.
will work on this later


How do I prepopulate with existing  data

If I have an update form that I wish to prepopulate with data which method should be called. Or is there a need to create the setData equivalent of getData on FormState?

Hi @andre-artus
Sorry for the late replies. At the moment, only the TextFieldState has that provision using the initial parameter. You can pass in the initial value of that specific state. We will work on adding this to all other states then close this issue. 😃

Thanks.

We found a bug with the quoted implementation. We have made a fix and added the initial state
parameter to all the form states.
Please refer to the new implementation.

https://github.com/jkuatdsc/form-builder/blob/9ce799cf377a24872cb7459ae70bd24a83f695e3/example/src/main/java/com/dsc/formbuilder/MainViewModel.kt#L13-L46

Thank you. I've been a bit busy with other tasks, but I am keen to try this out.

Is there an integration with autocomplete planned?


/usr/share/sbt/bin/sbt-launch-lib.bash: line 58:   405 Killed  "$@" | subprocess installed post-installation script returned error exit status 137

steps
docker build --no-cache -t docker-play .
Dockerfile:
###########################################################
# Dockerfile to build PLAY Installed Containers
# Based on Ubuntu
############################################################

# Set the base image to Ubuntu
FROM ubuntu:latest

# File Author / Maintainer
MAINTAINER sfergusonvolute

# RUN apt-get install -y apt-transport-https

# Update the apt repository
RUN apt-get update

# Install necessary tools
RUN apt-get install -y apt-transport-https
RUN apt-get install -y apt-utils
RUN apt-get install -y docker
RUN apt-get install -y vim
RUN apt-get install -y ssh
RUN apt-get install -y dialog
RUN apt-get install -y net-tools

# Add sources
RUN echo "deb https://dl.bintray.com/sbt/debian /" | tee -a /etc/apt/sources.list.d/sbt.list
RUN apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv 2EE0EA64E40A89B84B2DF73499E82A75642AC823
RUN apt-get update

# Upgrade the distro
#RUN apt-get dist-upgrade -y

# Install the requirements for the application
RUN apt-get install openjdk-8-jdk-headless -y
RUN apt-get install sbt -y

problem
I had no problems using docker to build my containers on Monday, but today I receive this error:
[warn] No sbt.version set in project/build.properties, base directory: /
/usr/share/sbt/bin/sbt-launch-lib.bash: line 58:   405 Killed                  "$@"
dpkg: error processing package sbt (--configure):
subprocess installed post-installation script returned error exit status 137
Processing triggers for libc-bin (2.23-0ubuntu9) ...
Processing triggers for systemd (229-4ubuntu19) ...
Errors were encountered while processing:
sbt
E: Sub-process /usr/bin/dpkg returned an error code (1)
The command '/bin/sh -c apt-get install sbt -y' returned a non-zero code: 100
expectation
A successful unattended installation of sbt.
notes
sbt version: 0.13.16

In my Docker builds, I was able to do a work around to pull and install certain older versions of .deb files using a different technique, but whenever I get to the sbt update step of my process I still get an error.
RUN curl -L -o sbt.deb http://dl.bintray.com/sbt/debian/sbt-0.13.11.deb
RUN dpkg -i sbt.deb
[SUCCESSFUL ] org.fusesource.jansi#jansi;1.4!jansi.jar (18ms)

:: retrieving :: org.scala-sbt#boot-scala
confs: [default]
5 artifacts copied, 0 already retrieved (24494kB/2791ms)
/usr/share/sbt-launcher-packaging/bin/sbt-launch-lib.bash: line 41:    64 Killed                  "$@"
The command '/bin/sh -c sbt update' returned a non-zero code: 137
Thankfully, my existing stand alone servers are not having issues when I run an sbt update. I am only having this issue with new builds/installs. (Same application code set.)
Take care,
Sarah Ann Ferguson

I solved this issue I had with sbt-1.1.5.deb version by:
sudo dpkg -r sbt
sudo dpkg --purge sbt
wget https://dl.bintray.com/sbt/debian/sbt-0.13.0.deb
sudo dpkg -i sbt-0.13.0.deb

As a note, watching memory consumption in htop, it was lower with 0.13.0 version.

@milnomada I tried doing what you have done. Unfortunately, it doesn't solve my issue. When I try to do a sbt compile for my play application on a EC2 console, I still keep getting the following error.
/usr/share/sbt/bin/sbt-launch-lib.bash: line 46:  5523 Killed                  "$@"
Any help would be much much appreciated. I have invested more than a day in this and now it is kinda nerve breaking.

@SwapnilBorse123 I was running in a container in ECS. I noticed my CPU Utilization was really high. So I increased the number of CPUs being used by the container and it fixed the error.

I had same thing (exact message was like @SwapnilBorse123.
Based on above suggestions, i just increased allowable memory for docker (was at 2GiB before), and that worked fine.


schema: add checkPlatform

Fixes https://github.com/opencontainers/image-tools/pull/39
Signed-off-by: zhouhao<EMAIL_ADDRESS>

LGTM

acf4adc37 looks good to me, although this is not really about
validating descendants (especially for the config platform check).  It
would be nice to have something like #403 land soonish so we had a
generic name for this sort of media-type-map-based verification.

@philips @vbatts @jonboulle @stevvooe  PTAL

These are SHOULDs, not MUSTs. Why should we validate them?
https://github.com/opencontainers/image-spec/blame/master/config.md#L63

i'm okay with them being checked, but not to FAIL a validation.

On Wed, Nov 30, 2016 at 01:42:16PM -0800, Vincent Batts wrote:

i'm okay with them being checked, but not to FAIL a validation.

+1.  We should probably table this until we settle on strict handling
(see the discussion in opencontainers/image-spec#452 and me trying to
outline the issue in opencontainers/image-tools#66).

These are SHOULDs, not MUSTs. Why should we validate them?

Because these two are required attributes, and as the specification says: The name of the operating system which the image is built to run on.  If it is the verification of the system, only by JSON to restrict the type is not rigorous, it should be the value of its specific judgment.

Due to my mistakes, resulting in this PR can not be updated, I will close this, and then open a new PR.


refactor: multiple targets

This PR is about refactoring the codebase to support multiple target platforms. Currently there are two platforms; web and native through expo. Not sure what future platforms could end up being, but provides a nice abstraction for allowing different WebGLContext's.
Notes

useLayoutEffect is now conditionally used if browser flag is set.
useCanvas is a hook that abstracts most of the shared <Canvas /> logic  away
reconceiler is untouched
hooks are untouched
In general, each platform has to provide three things: renderer, size and pixelRatio.
Refactored the ready check to make sure all three things ^^ are available, its good to assume that the initialization can take some time in different platforms and for example renderer (or gl) is yet to be initialized.

Todo

[x] Move non-platform specific canvas logic to one hook
[x] Add lazy initialization check of THREE.Renderer
[x] Update rollup config to emit multiple bundles
[x] Implement react-native via expo-gl and expo-three
[ ] Testing (It sure would be nice to have a testing platform now 😎)
[x] Re-implement pointer events without any dependencies or platform specific code. Each platform implementation will have to follow specific API (will use current api, onPointer...)
[ ] Provide a way to hook OrbitControls into pointer events easily, because React Native events won't bubble up like web does.
[ ] Update examples for react native
[ ] How should we do dependencies? peerDependency react-dom vs react-native.

Because the PR is pretty big, here is an example of a Canvas target:
export const Canvas = (props) => {
  const [gl] = useState() // instance of THREE.Renderer
  const [pixelRatio] = useState()
  const [size] = useState()

  // the hook will await all three to be set before starting renderLoop
  useCanvas({
    gl,
    pixelRatio,
    size,
    ...props,
  });

  return <whatYouNeedToRender />
};

this looks great. to get a feel for it - is there any way i could test this with the crna emulator, expo etc? and are events for RN already in this?

Yes, here is an example: https://snack.expo.io/@birkir/728f26
Pointer events are now working well on both platforms. I added a section in the readme, but there isn't much to it.
@drcmda can you verify that the examples work like you anticipated. I have done a pass of them all and they seem good to me compared to master.
How do you usually roll out refactors like this? pre-releases or?

this is looking so good 😊
could you go into the how you get it to go through expo-three a little? does this really run on native open gl now? it looks like magic, crazy to see this is working from just so little code (in the snack example).
sure we could run some betas, i publish them under the beta tag normally. i make one tomorrow or at the latest monday.

Haha sure, and oh... it's running on native GL!
expo-gl is a javascript bridge for native bindings to their own EXGL library (iOS/Android), which uses OpenGLES behind the scenes. They've successfully ported all WebGL 1.0 functions and some 2.0 functions. There are lots of functions missing though, here is the list.
expo-three is a utility library for THREE.js that also polyfills all browser specific things like canvas etc. and allow some unimplemented functions to fail gracefully. They provide their own asset loaders and such.
And, well, react-three-fiber now leverages this. The only native call we do is here: https://github.com/react-spring/react-three-fiber/pull/182/files#diff-2b1ec5a6413926436f928a4077c492b8R65-R70 (dare you to read those lines out loud).
PS. This is also possible

i get this error when trying it out btw,
Device: (920:881) Unable to resolve module<EMAIL_ADDRESS>  Evaluating<EMAIL_ADDRESS>  Evaluating module://react-three-fiber.js.js
  Evaluating module://App.js.js
  Loading module://App.js

when i load the snack it asks if i want to add some libs to package json, i clicked yes but doesn't seem to do much. anything i am overlooking?

dare you to read those lines out loud

you were trying to go for a tongue breaker? 😅

There seem to be some minor problems, these demos that are broken are:
Hud.js (something with useRender, did the order change?)
Suspense.js (... beats me, wouldn't know what could cause it to fail)

Okay great. I was worried that this would just work. I'll take a look 👍

Ok fixed the Hud example.
I left a flag where I was testing how many times context was rendering.

Suspense fixed

it's in 🎉
in the readme you wrote "Be aware that performance is limited compared to ThreeJS in the browser." i don't understand, does this mean it runs slower than three in the browsers webview? shouldn't opengl be faster?