Cleanup and unify keyboard input.

Unify keycode values (secondary label printed on a key), remove unused hard-coded Latin-1 codes.
Unify IME behavior, add inline composition string display on Windows and X11.
Add main_key_label (primary label printed on a key) value to the key events, and allow mapping actions to the main_key_label events.
Add support for physical keyboard (Bluetooth, USB or Sidecar) handling on iOS.
Remove LineEdit/TextEdit selected text when IME input begin.
Add support for media key handling on macOS.

Physical keyboard should always have keycode, unshifted_unicode and physical_keycode set, and unicode set on key press only when it's relevant.
IME only sends unicode key down evens, all other keys are ignored while it's active.
Virtual keyboards send everything physical do, except physical_keycode.

Supported input modes:

Android
iOS
Linux/X11
macOS
Windows
Web

Physical Keyboard
Yes [^2]
Yes [^3]
Yes
Yes
Yes
Yes [^5]

Virtual Keyboard
Yes
Yes
No [^4]
No [^4]
No [^4]
No

IME
[^1]
[^1]
Yes (inline)
Yes (inline)
Yes (inline)
No

[^1]: Using custom virtual keyboard layout.
[^2]: Tested with Bluetooth and USB-OTG keyboards.
[^3]: Tested with Bluetooth and USB-OTG keyboards and Sidecar.
[^4]: OS on-screen keyboards emulate physical keyboard.
[^5]: unshifted_unicode values aren't supported (generated from unicode and keycode as fallback).
Fixes https://github.com/godotengine/godot/issues/69830
Fixes https://github.com/godotengine/godot/issues/54797
Supersede https://github.com/godotengine/godot/pull/53682

Can that picture go into official Godot docs?

Can that picture go into official Godot docs?

In some form, I definitely plan to add it (https://github.com/godotengine/godot/pull/69751).

Handle IME composition start / end to suppress key events (ideally I will try to make Implement on-the-spot IME support for X11 #53682 work).

Seems like position of the candidate window is determined by focus window, no client window, so creating subwindow will require it to be focused for IME to work. Candidate window position sometimes is off on the Windows as well.
So I guess the proper solution is to draw a custom candidate window as well.

The term unshifted unicode in an input event makes it look like it has something to do with pressing Shift. Can we come up with an alternative, that is both correct and clear to laymen?

The term unshifted unicode in an input event makes it look like it has something to do with pressing Shift

Well, it has something to do with Shift, as in "not affected by Shift (or other modifiers)", but I agree it's not the best name.
I would rename unshifted_unicode to primary_label and keycode to secondary_label, but the second part is a breaking change of a widely used API, and it probably is too late to do it for 4.0.

Well, keycode is a pretty widely accepted outside of Godot too, so that would be confusing.
Maybe I'm missing what unshifted_unicode does in practice. It maps to Key, but our enum doesn't have definitions for every unicode character. So what does that new property hold? Is it actually a numeric Unicode value? And how do we expect people to use it? Maybe that'll lead us to a better name.

It maps to Key, but our enum doesn't have definitions for every unicode character.

Key can hold any Unicode value, all defined special key enum values (with exception for ASCII values) are outside of Unicode range (shifted by 22 bits for this purpose, and it was always like this). And OS.get_keycode_string() will work with Unicode values.

Thanks a lot for implementing inline IME support for X11 :bow:, don't forget to add "Fixes https://github.com/godotengine/godot/issues/53658".
I'm getting this message in the console when deleting characters from a LineEdit:
Unicode parsing error, some characters were replaced with spaces: Invalid UTF-8 leading byte (83)

Unicode parsing error, some characters were replaced with spaces: Invalid UTF-8 leading byte (83)
Also the caret seems to always stay at the beginning during IME composition.

Which IME engine are you using, I suspect the issue is in _xim_preedit_draw_callback which assumes chg_first and chg_length are a number of full Unicode characters, but in some cases it probably might be a number of UTF-8 code points instead.

I'm using Fcitx5 (5.0.14).

I'm using Fcitx5 (5.0.14).

And which input method? I have not found any difference between ibus and fcitx behavior, all input methods I have tested seems to use UTF-8 and always update the whole string, I was not able to reproduce "Invalid UTF-8 leading byte" error.

Also the caret seems to always stay at the beginning during IME composition.

Caret should be fixed.

And which input method? I have not found any difference between ibus and fcitx behavior, all input methods I have tested seems to use UTF-8 and always update the whole string, I was not able to reproduce "Invalid UTF-8 leading byte" error.

Testing with the latest artifact from CI, I seem to be getting it less often. It used to be on every deletion but now it's only happening every now and then. It happens even when IME is not active, both when using English (US) and Mozc.

Caret should be fixed.

It is :tada:

It happens even when IME is not active, both when using English (US) and Mozc.

Hm, that's strange, if it's happening in non-IME mode it's probably something else. Just to be sure, is it reproducible with empty project, or only in the editor (for example, I usually test input with the project manager filter LineEdit, which have a lot of unrelated code attached to the text change event)?

I usually test input with the project manager filter LineEdit

Oh, that's what I was using to test it too :smile:
I tried other LineEdits in the editor and it happened too, but I was unable to reproduce in a running project.

Looks fantastic, great work!

Unicode parsing error, some characters were replaced with spaces: Invalid UTF-8 leading byte (83)

I have checked it again, seems like XLookupString can return any garbage not UTF-8, so I have no idea how to get key_label on X11 properly. Removed it from X11 DisplayServer for now.

Removed it from X11 DisplayServer for now.

Reimplemented it in another way, additionally use xkbcommon library (optionally), but should work with any system encoding.

Linux CI likely needs this change:
diff --git a/.github/workflows/linux_builds.yml b/.github/workflows/linux_builds.yml
index 84fdb2180b..ce4f757a19 100644
--- a/.github/workflows/linux_builds.yml
+++ b/.github/workflows/linux_builds.yml
@@ -85,7 +85,7 @@ jobs:
           sudo apt-get install build-essential pkg-config libx11-dev libxcursor-dev \
               libxinerama-dev libgl1-mesa-dev libglu-dev libasound2-dev libpulse-dev \
               libdbus-1-dev libudev-dev libxi-dev libxrandr-dev yasm xvfb wget unzip \
-              llvm libspeechd-dev speech-dispatcher fontconfig libfontconfig-dev
+              llvm libspeechd-dev speech-dispatcher fontconfig libfontconfig-dev libxkbcommon-dev

       - name: Setup Godot build cache
         uses: ./.github/actions/godot-cache

This might also be needed for NixOS which puts its includes in non-standard directories:

Added. I guess I should do https://github.com/godotengine/godot/pull/71263 for the X11 libs to avoid this kind of issues.

Tested on Linux with en_US, fr_FR and da_DK keyboard layouts, seems to work great! Some tests with event.as_text_key_label():

French AZERTY, pressing all keys from top to bottom (remapping, on a physical US QWERTY):
²
Ampersand
É
QuoteDbl
Apostrophe
ParenLeft
Minus
È
UnderScore
Ç
À
ParenRight
Equal
A
Z
E
R
T
Y
U
I
O
P
BraceLeft
Dollar
Asterisk
Q
S
D
F
G
H
J
K
L
M
Ù
W
X
C
V
B
N
Comma
Semicolon
Colon
Exclam

The same on Danish keyboard layout:
½
1
2
3
4
5
6
7
8
9
0
Plus
Equal
Q
W
E
R
T
Y
U
I
O
P
Å
BraceRight
Apostrophe
A
S
D
F
G
H
J
K
L
Æ
Ø
Z
X
C
V
B
N
M
Comma
Period
Minus

I noticed a difference in the way modifiers are handled, but this may be intentional. Testing on French AZERTY, where:

Physical key "2" has key label "É", and "2" is the "shifted" key.
Physical key "E" has key label "E", and "€" is accessible via Alt Gr + E (on Linux with the default fr mapping).

Pressing Shift+É to get "2" prints:
Shift
Shift+É

Pressing Alt Gr+E to get "€" prints:
Alt
€

Thanks!

I'm sorry but I think the change in of SUPER_* and HYPER_* constants is a bit weird here.
From a X11/Wayland perspective the old situation makes more sense? Like, at least the left and right SUPER ("windows") key are really separate keys. I'm not sure about HYPER.
Also there's a stale SUPER_R/SUPER_L in core/keyboard.h, if you really intend to remove them.

I'm sorry but I think the change in of SUPER_* and HYPER_* constants is a bit weird here.

None of the other platforms distinguish L/R Super, all use META, and no other key have Left/Right variant. It is possible to get L/R variants on other platforms, but if it's done it should be done for all keys (Ctrl, Alt, etc.) not just for Super/Meta and essentially nonexistent Hyper. There was PR to do it, but it was rejected.

Also there's a stale SUPER_R/SUPER_L in core/keyboard.h, if you really intend to remove them.

Indeed, missed them, should be removed.

Ok, thanks, it wasn't clear to me that META was the same thing. I thought the key was entirely removed. Makes more sense then.

I noticed a difference in the way modifiers are handled, but this may be intentional. Testing on French AZERTY, where:

Physical key "2" has key label "É", and "2" is the "shifted" key.

Yes, this is intentional. All numbers on French keyboards are accessed using shift.

InputEventKey does not necessarily have the key_label set, such as when it has been retrieved from InputMap.action_get_events(). In that case, how do we obtain the localized key label of an unicode char that has no keycode representation (if it had, we could use DisplayServer.keyboard_get_keycode_from_physical()). Example: umlauts.
apologies if that is not within the scope of this PR. didn't find any other place related to key_label.


Resume play not working with release 1.0

Has somebody also discovered problems with the resume play in the release 1.0?
I'm using a Pi Zero with pHat BEAT and am not be able to adjust the resume play function over the web player.

Hi @MalteHST
any progress on this? Worked for me :/

Hi @MiczFlor ,
unfortunately not. Is there anything else to do after a fresh clean installation of the phoniebox except to switch resume play on in the web player for a specific folder?
The file folder.conf in this audiofolder is always up to date.

What iFace are you using for the soundcard? This needs to be added in the settings folder file and in /etc/mpd.conf. (On my mobile, apologies for typos and shorthand)

On my mobile so only reporting frommemory: there is a line in the conf, commented put, which contains PCM by default. The install script changes that to what you add during install. In other words: see the config file for details

Master as audio output was already set. Also if I set everything to PCM and disconnect the pHat BEAT the resume play switch in the web player has no function for me.
Did I get it right that resume play also should work for controlling the music just over the web player, without an RFID Reader connected?

Resume play works for control with RFID and web app.
Could you switch resume play on for some folder and start playing. Please post the content of the folder.conf of that folder here.  Then press stop and check the content of that file again.

Here is the content of my folder.conf while playing with resume switch on:
CURRENTFILENAME="Only by the Night/01 Closer.mp3"
ELAPSED="58.990"
PLAYSTATUS="Playing"
RESUME="ON"
SHUFFLE="OFF"
LOOP="OFF"
And after stoping the playlist over the web player:
CURRENTFILENAME="Only by the Night/01 Closer.mp3"
ELAPSED="96.240"
PLAYSTATUS="Stopped"
RESUME="ON"
SHUFFLE="OFF"
LOOP="OFF"
If I press afterwards 'PLAY' the music resumes at the point where I stopped it before. But if I switch to another playlist/folder and then go back to the folder with resume switch on, the music starts always from the beginning. This is also happening if I reboot the raspberry.
I hope that I get the intended use-case of the resume play right. Or is this feature not able to resume a playlist after another one was played in between?
(my setup for this test is a bare Pi Zero without any devices connected. Fresh install of stretch-lite and phoniebox with default values. Controlling only with the web player.)

You got the use case of resume play right.
Can you please check for the file
 /settings/Latest_Folder_Played
and if the content changes if you start different playlists (folders).

You could try to replace the files:
scripts/playout_controls.sh
scripts/resume_play.sh
scripts/rfid_trigger_play.sh
with these of my branch https://github.com/zxa/RPi-Jukebox-RFID/tree/clean-up?files=1

Interesting. Works perfectly. Many thanks for you help.
I don't know exactly where the difference is to the master branch, but is it planned to take over these adaptions to the master branch of @MiczFlor ?
Thanks.

The pull request #155 is pending.
In case it is merged, you have to revert the manual changes with:
git stash

Hi,
Thanks for the feedback. Please don‘t close this thread, I am on holidays and will work this into the script an web app in the coming days
All the best, micz

I merged the pull request(s):
https://github.com/MiczFlor/RPi-Jukebox-RFID/commit/f026461d3009b82b6f938c76f0c57d9e0f178595


Photoshop failed

I used this application to patch Photoshop ，however ，my Photoshop flashback. Then I reinstall the Photoshop without patch , it works well. How can I solve this problem?

OK ,I solve the problem. Don't select Photoshop.exe when you are patching the app.


Add missing Callback class import

Fix https://github.com/davodesign84/react-native-mixpanel/issues/67 (android can't build currently)

Wait for https://github.com/davodesign84/react-native-mixpanel/pull/72 to be merged


Make linker configurable on Windows

On POSIX platforms, the linker can be configured via the CC environment variable. This does not work on Windows currently, neither does the equivalent of CL.
It should be possible to configure the linker on Windows as well.

%CL% is reserved by MSVC to pass extra command-line options to the compiler, i.e. it is essentially a different %CFLAGS%. So we should use %CC% even on Windows

Related: https://github.com/crystal-lang/crystal/issues/5430#issuecomment-1256240890

OK so how does this work? here is still says visual studio is required:
https://crystal-lang.org/install/on_windows/
but if this issue works as advertised, that should no longer be the case

https://github.com/crystal-lang/crystal/issues/14236


Datastore: hangs instead of throwing exception

Two example:

when I set DATASTORE_EMULATOR_HOST to "http://<IP_ADDRESS>:3001" as it was with DATASTORE_HOST, and invokead datastore operation I've got the following message in terminal

E0512 06:54:20.906399472    9828 resolve_address_posix.c:126] getaddrinfo: Name or service not known

After which ruby process just hanged and could not be interrupted by Ctrl-C, only kill -9 did the job

When I fixed  DATASTORE_EMULATOR_HOST to "<IP_ADDRESS>:3001" but did not start the actual emulator I've got enless loop of

E0512 07:00:34.884748956    9918 tcp_client_posix.c:173]     failed to connect to 'ipv4:<IP_ADDRESS>:3001': socket error: connection refused
E0512 07:00:35.886550255    9918 tcp_client_posix.c:173]     failed to connect to 'ipv4:<IP_ADDRESS>:3001': socket error: connection refused

Again with only kill -9 to help.
Something wrong with network stack

@timanovsky What if you try localhost without the http:// like this?
ENV['DATASTORE_EMULATOR_HOST'] = 'localhost:3001'

Are you running the gcd.sh grpc emulator linked to in the docs? Or are you running the emulator by using $ gcloud beta emulators start?

@blowmage I am able to see the same thing using the new gcd.sh grpc emulator. If I initialize my cloud datastore dataset like this:
ENV['DATASTORE_EMULATOR_HOST'] = 'http://localhost:8180'
The first time I interact with the gcd emulator I receive the following:
E0512 08:14:03.713381000<PHONE_NUMBER>59200 resolve_address_posix.c:126] getaddrinfo: nodename nor servname provided, or not known
and I have to manually kill the gcd process.
However if I remove the http:// and initialize it like this:
ENV['DATASTORE_EMULATOR_HOST'] = 'localhost:8180'
the emulator seems to run OK but I do see this output:
E0512 08:23:25.219103000<PHONE_NUMBER>35712 tcp_client_posix.c:173] failed to connect to 'ipv6:[::1]:8180': socket error: connection refused

We have verified that setting the host to an invalid value will hang the ruby client. This is an upstream issue and have opened grpc/grpc#6559 for it.
When starting the emulator you are given the following message:
If you are using a library that supports the DATASTORE_EMULATOR_HOST environment variable, run:

export DATASTORE_EMULATOR_HOST=localhost:8978

It is important to properly set the environment variable name and value to get the integration to work.

@blowmage I missed that part about gcd.sh, I was using beta emulators. So the second part of the ticket is probably not relevant

@timanovsky Okay. For the first part of the issue you should set the environment variable to the value the emulator provides. If you do that you should have no problems.
I'm going to close this issue. The issue filed against GRPC remains still open, and hopefully we see the GRPC client stop hanging when set with an invalid host soon.

What about second part? If host is not there it also hangs. This may happen
in real set up to due to network problems. (Sorry, at the moment I don't
have time to simulate this)
Best regards,
Alexey Timanovsky.
On 12 May 2016 at 19:31, Mike Moore<EMAIL_ADDRESS>wrote:

@timanovsky https://github.com/timanovsky Okay. For the first part of
the issue you should set the environment variable to the value the emulator
provides. If you do that you should have no problems.
I'm going to close this issue. The issue filed against GRPC remains still
open, and hopefully we see the GRPC client stop hanging when set with an
invalid host soon.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/gcloud-ruby/issues/688#issuecomment-218812300

In both cases the host provided was invalid. When you provide a valid host (pointing to a working service) the emulator connectivity works. The hanging on an invalid host is an upstream issue with GRPC and there isn't much gcloud-ruby can do about it other than raise the issue to them, which we have done.


Breaking Symmetry in UHF with Custom Hamiltonian

Dear All,
When running UHF for a molecule with a predetermined basis set, breaking the spin symmetry of the initial guess is fairly straightforward, as seen in Issue #167. However, when I try to do the same with a custom Hamiltonian for the 1-D Hubbard model, I run into the following error:

IndexError: index 0 is out of bounds for axis 0 with size 0

This seems quite close to Issue #923, although there is no mention of symmetry breaking in that issue. Here is my script:
import numpy as np
from numpy import zeros, matrix
from pyscf import gto, scf, ao2mo, cc, tools

hubbard_U = 4.
hubbard_t = 1.

mol = gto.M(verbose=4)
n = n_basis = 8
mol.nelectron = n_basis # half-filling
mol.verbose = 0
# Setting incore_anyway=True to ensure the customized Hamiltonian (the _eri
# attribute) to be used in the post-HF calculations.  Without this parameter,
# some post-HF method (particularly in the MO integral transformation) may
# ignore the customized Hamiltonian if memory is not enough.
mol.incore_anyway = True

h1 = np.zeros((n,n))
for i in range(n-1):
    h1[i,i+1] = h1[i+1,i] = -hubbard_t
h1[n-1,0] = h1[0,n-1] = -hubbard_t # periodicity

eri = np.zeros((n,n,n,n))
for i in range(n):
    eri[i,i,i,i] = hubbard_U

mf = scf.UHF(mol)
mf.conv_tol = 1e-8
mf.get_hcore = lambda *args: h1
mf.get_ovlp = lambda *args: np.eye(n)
mf._eri = ao2mo.restore(8, eri, n)
dm_alpha, dm_beta = mf.get_init_guess() # See this Github issue: https://github.com/pyscf/pyscf/issues/167
dm_beta[:2, :2] = 0                     # Here is the solution: https://github.com/sunqm/pyscf/blob/master/examples/scf/32-break_spin_symm.py
dm = (dm_alpha, dm_beta)

print(mf.kernel(dm)/n)

Based on my understanding, this is because it is inappropriate to use get_init_guess() here since no atoms are defined. I have tried other things, for example, passing the core Hamiltonian h1 and a slightly perturbed version as arguments to mf.kernel(). This doesn't work because kernel() only accepts one argument, so, seemingly, there is no way to break symmetry here. If I avoid the symmetry-breaking step altogether, I see oscillating convergence to the energy in the infinite-size limit, which is identical to just using RHF, whereas I expect the UHF energy to have already converged with a chain length of 8, based on certain benchmarks that I am trying to reproduce.
Any help would be appreciated!

Not tested this myself but have you tried specifying a key keyword in get_init_guess? i.e. get_init_guess(key="XXX") where you fill in "XXX" with your method of getting an initial guess which does not involve atoms?

For example, see pyscf/scf/hf.py get_init_guess function for keys are possible.

I tested it with key = 'hcore', 'minao',, and '1e'. All of these give the same error. However, it works for RHF even without an argument.

UHF get_init_guess function supports systems with no atoms. Except very old pyscf versions, it's unlikely the program would get the error IndexError: index 0 is out of bounds for axis 0 with size 0.  The default UHF initial guess, if the system does not have any atoms, is one half of RHF hcore density matrix for alpha spin and zeros for beta spin ('hcore'/2, 0). In my preliminary tests, this initial guess can break the spin symmetry in this hubbard model. If the problem is SCF convergence, you can try the second order SCF driver
mf.newton().run()
print(mf.e_tot / n)

I updated my PySCF to 2.0.0a. The UHF does succeed in breaking symmetry but now it leads to a strange issue. The normalized energy seems to be near the correct value of -0.47t for smaller chain lengths (L <= 16) but settles to a different, incorrect value (~-0.27t) for longer chains (L >= 18). I am attaching a plot here.

(My script is exactly the same as before, except for different values of n_basis for different chain lengths.) It looks like symmetry-breaking works for systems below a chain length and not for others. Have I missed something?

For larger L, have you tried stability checking the SCF solution? See e.g. examples/scf/17-stability.py.

Using newton solver helps (e.g. when L=20), although it doesn't guarantee converging to the symmetry broken solution. You probably need better initial guesses.

Agreed, thank you all for the responses. Closing this issue now.


Deprecate app.locals.logger

What's this PR do?
Updates the Winston package and refactors Gambit to use its preconfigured instance.
How should this be reviewed?
Test every endpoint 😬
Any background context you want to provide?
https://github.com/DoSomething/gambit/issues/837#issuecomment-292563373
Relevant tickets
Fixes #848
Checklist

[ ] Tested on staging

Getting chatbot responses back, but seeing a UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 259): MongoError: quota exceeded in our logs on staging.

Removed all documents from the log collection on staging to avoid

This is awesome. On thing: are you sure that you don't need to create logger category, like @rapala61 mentioned in the example: winston.loggers.get('category')? Or is it using default category when simply required with const logger = require('winston');?

Yeah, categories aren't required. This is logging into our logs collection and to the console -- we'd want to use categories if we wanted to do something like sending logs of different types to different locations: https://github.com/winstonjs/winston#working-with-multiple-loggers-in-winston


Adding rubygems for on-premise mirror

As same of PR https://github.com/chef/knife-windows/pull/418
Signed-off-by: Juan Carlos Alonso Holmström<EMAIL_ADDRESS>

on behalf of https://discourse.chef.io/t/pre-release-announcement-chef-13-0/10723 Chef::Config[:rubygems_uri] from Chef::Config[:rubygems_url] on chef 13 usage

I think you will want to clean up the PR. It should just include your rubygems commit.

Works well on chef 12, it was tested on https://travis-ci.org/chef/chef-provisioning/builds/219832457

I don't think the travis failure is related to this pr

Hey guys,
any update on this?
Thanks


Add missing parentheses to US_TO_TICKS and TICKS_TO_US macros.

Spent an hour trying to figure out why my timestamps were all wrong. Turns out it was only converting part of the expression.
Might I suggest using inline functions for this instead?

Thanks for the PR. Makes totally sense.


Spectral library integration

How about hyphenating a spectral library search as first pass before going on to database searching? with so much data available today, it's almost a crime not to combine it into a search pipeline...
yet there is none  that allow good LFQ and search engine coupled to it...
Cheers,
David.

Delightful idea. We'll huddle the team and discuss. I love it.

I'm not too familiar with spectral libraries so I'm going to ask some rather ignorant questions to get started.

Are you asking that we accept spectral libraries as input instead of a database in the first-pass GPTMD search to annotate possible PTMs, followed by a second-pass search with the annotated protein database? If so, what is the advantage of replacing the database search with a spectral library search? Is it to match fragment peak intensities in addition to mass? or is it mainly for DIA searches?
I assume also that you want to be able to output search results as a spectral library? What is a typical pipeline for this, and what should we output? I think you mentioned pepXML before; if we output pepXML, is this easily convertible to a spectral library? Do you use spectraST?
I've very briefly looked into using metabolomics spectral libraries to see if we can do metabolomics in MetaMorpheus, but I only really saw low-resolution MS/MS information. The libraries are also dependent on fragmentation energy, fragmentation type, ionization mode, etc. This is kind of where my ignorance catches up to me. I don't really understand where you go to download the specific type of spectral library you want; is there some repository of spectral libraries somewhere that I can find, like if I'm studying Jurkat cell phosphoproteomics with HCD and 32 normalized collision energy and ESI+?

https://www.biorxiv.org/content/early/2018/03/07/277822

Hi,
I think I might be as ignorant :)

my suggestion is to run a spectral library search, followed by GPTMD and regular search on those ions that were not identified by the spectral library searches. I think that for model animals, the precentage of PSMs that have been already ID'd in the past will become very dominant quickly. this should allow more complex GPTMD searches on smaller number of MS2 scans that were not ID'd in the first pass. I think spectral libraries should improve several factors: 1. search speed 2. improve search speed significantly on complex data, such as glycoproteomics and top-down 3. building consensus spectra from multiple IDs that will improve the confidence of the ID (via fragmentation intensity too). All of this is more important when considering larger peptide, glycopeptides and other labile and difficult modifications.
I'm actually not interested in DIA.

Ideally, I would like to have an option to concatenate the results to a consensus spectral library. for example, if I search human data, i would like to have the strong IDs incorporated back to the spectral library automatically. Currently only SpectraST does it and not automatically, but via command line.
I am playing a bit currently with SpectraST, but it is not very easy for me, mainly since the generation of libraries is difficult, performing the search (and FDR) is difficult and data visualization is difficult...  I was actually trying to generate libraries for analysis in PD2.2, combining MSPepSearch with MSAmandata for sequential analysis. doesn't work (yet...). The output of interest, assuming you can combine it into the FDR and quantification pipeline, is both TSV and a format that can be viewed somehow (another sore point, I know...). My interest in pepXML was mainly since it can be view in Scaffold and Batmass (http://www.batmass.org/tutorial/overlay-peptide-ids-on-map2d/). If you plan on making a viewer of your own... :) i would say that the lack of a viewing option is a deterrent to some degree, especially with mods.

you can check with NIST: http://chemdata.nist.gov/dokuwiki/doku.php?id=peptidew:cdownload, and divided between instruments and organisms. I think most of the Orbitrap HCD data should be HiHi, but I'm not sure.

see #1124


[M+] Model Management And Version Tracking.

Model lineage and versioning to track the history of a model natively in CRD:  when the model is trained using which data and which image,  each version of the model,  which version is runnng etc.

model and model version is added


feat: add IdResponse on addEntry API

What this PR changes/adds
Returns IdResponse in the  POST /v2/dataplanes  API.
Why it does that
consistency
Linked Issue(s)
Closes #3352
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.02% :tada:

Comparison is base (f467cff) 71.95% compared to head (356f52d) 71.97%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3449      +/-   ##
==========================================
+ Coverage   71.95%   71.97%   +0.02%
==========================================
  Files         837      837
  Lines       17012    17018       +6
  Branches      948      948
==========================================
+ Hits        12241    12249       +8
+ Misses       4366     4364       -2
  Partials      405      405

Files Changed
Coverage Δ

...aplane/selector/DataPlaneSelectorApiExtension.java
100.00% <100.00%> (ø)

...elector/api/v2/DataplaneSelectorApiController.java
100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat(authors): add author entity

Current dependencies on/for this PR:

main

PR #63   👈

This comment was auto-generated by Graphite.


Delay calibration fixes

add option for either loading calibration data from file or from config
Closes #521

I also removed the double pytest and coverage report in pull requests, as it prevents coverage reports in some cases apparently.


fix: preserve order of readContracts contracts

Description
This PR fixes an issue where the ordering of the contracts passed to useContractReads would not be preserved (they were grouped by chain id instead).
Fixes #999

Any chance of releasing as a patch for 0.6.x? Currently blocked on this and RainbowKit/ConnectKit haven't updated to 0.7.x yet.


[Bug] fav pull downloads nothing even though fav status -r -t shows the resources as tracked but not saved

Describe the bug
fav pull ends after successfully fetching the set without downloading anything. This happened to 3 of my 4 sets.
To Reproduce
Steps to reproduce the behavior, or a Minimal Reproducible Code Snippet.
fav init
fav auth login
fav status -s # to find the set id
fav track <set_id>
fav fetch
fav pull

Expected behavior
fav pull downloads the files correctly and if there is an error encountered when downloading a resource, log it somewhere.
Screenshots

Information (please complete the following information):
OS: TrueNAS Scale Cobia
Output of rustc -V: N/A, didn't compile fav from scratch
Additional context
None

Could you please show me the result of fav status -lt? I wonder how you tracked the sets to locate the bug.
I notice that you said 4 sets are tracked, but the result of fav fetch shows only 1 set was fetched.

fav status -st

That's because fav doesn't preserve directory structure, so I have create one directory for each set.

I tried my best, but I still cannot reproduce this bug.
 ~/Downloads  mkdir 1                                                                           Thu Feb 29 12:46:39 2024
 ~/Downloads  mkdir 2                                                                           Thu Feb 29 12:53:23 2024
 ~/Downloads  cd 1                                                                              Thu Feb 29 12:53:25 2024
 ~/D/1  ls                                                                                Thu Feb 29 12:53:27 2024
 ~/D/1  fav init                                                                                Thu Feb 29 12:53:28 2024
 ~/D/1  fav auth login                                                                          Thu Feb 29 12:53:32 2024
 INFO Scan the QR code to login.

█████████████████████████████████████████████████████
█████████████████████████████████████████████████████
████ ▄▄▄▄▄ █▀█▄ ▄█ █▄█▀▀▄ ▄ ▀▀ ▄█▀▄▀▀ █▀▄█ ▄▄▄▄▄ ████
████ █   █ █ █▀█ ▄█▀ █ ████▀▄▄█  ▄ ▀  █ ▀█ █   █ ████
████ █▄▄▄█ ██▄▄ █▀█▄▄▀█▄ ▄▄▄  ▀█▀█▄███▄▄▄█ █▄▄▄█ ████
████▄▄▄▄▄▄▄█ █ ▀ ▀▄▀ █▄▀ █▄█ ▀ █ ▀ █ █▄▀ █▄▄▄▄▄▄▄████
████ █▀▀█▀▄█  ▀ ▄ ▄▄▄▄▀ ▄▄ ▄ ▀▀▀▀   █ ▀▀▀▄ ▀█   █████
█████ ▄▀ ▄▄▀▀██▀▄ ▄ █ ▀▄██ ▀ ▀ ▄ ▄▀▀ ▄▄▄▀▄▄ ▀▄ ▄█████
████▀  ▀ ▀▄██▄▄█▀███▀▄▄█▄ ▀█▀▄██ █ █ ▀█▀▀▄▄█▄ ▀▄█████
████ ▀▀██ ▄▄██▀  ▄  ▀▄▄█▄ ▄█▄█ ▀█▄▀██▀▄▄ ▀ █▄▀ ▀ ████
████▀██ ██▄█ █ ▄ █ █ ▄▄▄ ▄▀█▄█▀ ▀▀▀▄█▀▄ ▀▀▄ ██▀█▀████
████▄ ▄▄ █▄▄▄ ▀▀█▄▄▀  ▄ ██▄▀▄▄▄█ ▀█  ▄█▀███  █▀▀▄████
████▀▄██ ▄▄▄ █ ▀▄▀▄ █▀ ▀ ▄▄▄ ▀ ▀█ ▀▀█▀▀▀ ▄▄▄   ▀▄████
████ ▀▄█ █▄█ █▀  ▀█▄ ▀   █▄█ █ █▀███▀▄▄▄ █▄█ ▀ ██████
████  ▀█ ▄▄▄▄ ▀█▄▄██▄    ▄ ▄ ▀▄█ █ ▀ ▀▄▄ ▄▄ ▄▀█▄▀████
████▄█▀  ▀▄▄█▄ ▀▄ █▀ ▀▄▀ █▄▀▀▀▄▄█▄█ ▄█ ▀▄█ ▄▀  ▄█████
███████▄▄█▄ ██▀ ▄█▀ ▀▀▄█▀ ▀▄▄ ▄ ▀█  ▀▀▄▀ █ ▀▄▀▀▄▄████
████▀ ▄▀██▄  █▄▀▄  ▀▀▀▀▀ ▀██▀██ ▄▀▀▀▀▀█ ▄▄ ▄▄█  █████
████▀  █▄▄▄▀██▀ █▄ ▀ ▄█ ▀ █ ▄█▀▄▀█  █ ▀█  ▄▄▄▄██▄████
█████▀▀▀ █▄ ▄▄█▀▄▄▀█▀  ▄█ █▀▄▀ ▄▀▀█▀▀▄▄▀  ▀▄██▄▄█████
████▄██▄▄█▄█▀▀▀██ █▀  ▀▄ ▄▄▄ ▀█▀    ▄▀▄  ▄▄▄   ▄▀████
████ ▄▄▄▄▄ ██▄ ▄▀ █  █▄  █▄█ █ █▄▀█▀▀▄   █▄█ ▀  █████
████ █   █ ███▀ ▀███▀██▀ ▄▄▄ ▀▄█▀▄  █▀▄  ▄▄  ▄▀▄▄████
████ █▄▄▄█ ███▄▀▄█▄█  ▀█▀▀ ██▄█▀▀▀ █ ██▄ ▀▄ ▄▀ █▄████
████▄▄▄▄▄▄▄█▄█▄██▄▄█▄█▄▄█▄▄▄▄▄▄▄███▄█▄█▄▄▄▄█▄▄█▄█████
█████████████████████████████████████████████████████
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
 INFO Login successfully.
 ~/D/1  cd ..                                                                            9.3s  Thu Feb 29 12:54:02 2024
 ~/Downloads  cd 2                                                                              Thu Feb 29 12:54:07 2024
 ~/D/2  fav auth reuse ../1/.fav                                                                Thu Feb 29 12:54:08 2024
ERROR IOErr: No such file or directory (os error 2); Maybe you didn't run `fav init`
 ~/D/2  fav init                                                                                Thu Feb 29 12:54:17 2024
 ~/D/2  fav auth reuse ../1/.fav                                                                Thu Feb 29 12:54:27 2024
 ~/D/2  fav fetch                                                                               Thu Feb 29 12:54:29 2024
 INFO Fetching sets...

 INFO Fetch sets successfully.
 INFO Fetching set<2329351088>
 INFO Fetch set<2329351088> successfully.
【重返未来1 ⠒ [00:00:06] [##########>---------------------------------------------] 16.72 MiB/85.40 MiB (2.79 MiB/s, 25s)
 WARN Ctrl-C cancelled
 ~/D/2  cd ../1                                                                          7.4s  Thu Feb 29 12:55:02 2024
 ~/D/1  fav fetch && fav track<PHONE_NUMBER>                                                       Thu Feb 29 12:55:07 2024
 INFO Fetching sets...
 INFO Fetch sets successfully.
 ~/D/1  fav pull                                                                        134ms  Thu Feb 29 12:55:38 2024
 INFO Fetching sets...
 INFO Fetch sets successfully.
 INFO Fetching set<1844042288>
 INFO Fetch set<1844042288> successfully.
从头实现Rust ⠉ [00:00:05] [>-------------------------------------------------------] 4.35 MiB/392.42 MiB (1.26 MiB/s, 5m)
Rust Axum  ⠈ [00:00:05] [>-------------------------------------------------------] 2.94 MiB/423.72 MiB (938.06 KiB/s, 8m)
使用 Rust 开发 ⠠ [00:00:04] [#>-------------------------------------------------] 670.79 KiB/23.64 MiB (177.06 KiB/s, 2m)
 ~/D/1  fav pull                                                                         7.3s  Thu Feb 29 12:55:49 2024
 INFO Fetching sets...
 INFO Fetch sets successfully.
 INFO Fetching set<1844042288>
 INFO Fetch set<1844042288> successfully.
Rust新手开发 ⠂ [00:00:04] [###>----------------------------------------------------] 2.67 MiB/47.69 MiB (1.09 MiB/s, 41s)
Rust新手开发 ⠂ [00:00:04] [###>----------------------------------------------------] 2.67 MiB/47.69 MiB (1.09 MiB/s, 41s)
Rust Async ⠤ [00:00:03] [>------------------------------------------------------] 606.79 KiB/65.49 MiB (243.43 KiB/s, 5m)
 ~/D/1  cd ../2                                                                          5.6s  Thu Feb 29 12:56:01 2024
 ~/D/2  fav pull                                                                                Thu Feb 29 12:56:07 2024
 INFO Fetching sets...
 INFO Fetch sets successfully.
 INFO Fetching set<2329351088>
 INFO Fetch set<2329351088> successfully.
【重返未来1 ⠴ [00:00:03] [#####>---------------------------------------------------] 8.69 MiB/85.40 MiB (2.85 MiB/s, 27s)
 WARN Ctrl-C cancelled

I add fav auth reuse just now, so there's no need to scan code multiple times.

A bit of digression, but isn't there a switch to turn on verbose logging? In the set which fav pull does work, it doesn't warn me of resources that it fails to download.

NO, there is no such a switch. But only expired resource will fail without any hint since its info became useless. Otherwise, network or auth errors will be showed.

I just tested on my roommate's computer, all work well and no bug.

I add fav auth reuse just now, so there's no need to scan code multiple times.

Doesn't seem to work.

In fact, the new release cannot even login and list the sets properly.

end with .fav.
You can find the example with fav auth reuse -h

And your first picture even did not fetch first.

And your first picture even did not fetch first.

My bad. The sets do show up after fetching first. This set pulls correctly as well.

end with .fav. You can find the example with fav auth reuse -h

However, even with .fav appended to the end, I still cannot reuse the authentication from another directory. The error is different though.

I will test the other two sets later. If they also pull correctly, I will close this issue. If the problem with reuse persist, I will open a separate issue for it.

fav auth reuse actually equals to cp ../Fitness/.fav/bili .fav/bili, you can easily run this instead.
I guess you don't have enough permission to do this job, and this may lead to unexpected behivior when using fav.
May be you could run with sudo or use chmod +rw xxx to enable write and read permission.

I reproduced Operation not permitted on arch Linux just mow.
This is leading by mounting filesystem with sudo, the owner of the files is root.
You should mount your disk with udisksctl instead, other method here.
Anyway, just ensure you have the permission to modify files under .fav.

I reproduced Operation not permitted on arch Linux just mow.
This is leading by mounting filesystem with sudo, the owner of the files is root.
You should mount your disk with udisksctl instead, other method here.
Anyway, just ensure you have the permission to modify files under .fav.

I reproduced Operation not permitted on arch Linux just now.
This is leading by mounting filesystem with sudo, the owner of the files is root.
You should mount your disk with udisksctl instead, other methods are here.
Anyway, just ensure you have the permission to modify files under .fav.

我试一下把复制改成链接


[Paper] Add entries to bib (https://github.com/google/BIG-bench/issues/713)

Partially tackles https://github.com/google/BIG-bench/issues/713

Thank you for these additions, and careful corrections, to the bibliography!!


dependency "github.com/ulikunitz/xz @0.5.6" has govuln GO-2020-0016, CVE-2021-29482

The upstream issue is https://github.com/ulikunitz/xz/issues/35 and the issue is resolved in ulikunitz/xz @0.5.8 and above.
The advisory at https://github.com/ulikunitz/xz/security/advisories/GHSA-25xm-hr59-7c27 reads:

The function readUvarint used to read the xz container format may not terminate a loop provide malicous input.

Found with deps.dev at https://deps.dev/go/github.com%2Fdiskfs%2Fgo-diskfs/v1.2.0
The most likely recommendation is to bring the dependency up to the current release. Risk seems low, as this fix has already been implemented by hashicorp/go-getter#279 and rhysd/go-github-selfupdate#36

see https://github.com/diskfs/go-diskfs/blob/8a6b8b88d14a164cb914108d3cd829d9a67595a0/go.mod#L17 for the go.mod import line.

Open a PR? It is a pretty simple change.

PR submitted. I updated the go.mod file and did go mod tidy to refresh everything.
The piece of the system that should be tested as a consequence of this PR is the squashfs section.


Repacking of firmware after extraction

Feature Request:
Is it possible to add a repack option so that after running an extraction and modifying the contents we can repack the image back together?
General Question:
How could this be done manually? For instance if I have the signature output of:

DECIMAL       HEXADECIMAL     DESCRIPTION
--------------------------------------------------------------------------------
13632         0x3540          U-Boot version string, "U-Boot 1.1.4 (Aug 17 2012 - 15:21:07)"
13680         0x3570          CRC32 polynomial table, big endian
14976         0x3A80          uImage header, header size: 64 bytes, header CRC: 0x71A58DBE, created: 2012-08-17 07:21:08, image size: 32798 bytes, Data Address: 0x80010000, Entry Point: 0x80010000, data CRC: 0xF13C6F0C, OS: Linux, CPU: MIPS, image type: Firmware Image, compression type: lzma, image name: "u-boot image"
15040         0x3AC0          LZMA compressed data, properties: 0x5D, dictionary size: 33554432 bytes, uncompressed size: 93688 bytes
131584        0x20200         LZMA compressed data, properties: 0x6D, dictionary size: 8388608 bytes, uncompressed size: 2753096 bytes
1039828       0xFDDD4         Squashfs filesystem, little endian, version 4.0, compression:xz, size: 2684880 bytes, 786 inodes, blocksize: 262144 bytes, created: 2014-02-04 10:24:21
3735552       0x390000        JFFS2 filesystem, big endian

And I wish to extract, modify, and repack the Squashfs filesystem where my data resides, what would be the steps in doing so?
Should I split the binary in three parts: 1) 0x000000 -> 0xFDDD4, 2) 0xFDDD4 -> 0x390000 3) 0x390000 -> end of binary. Proceed to extract the 2nd part (the squashfs file system), modify it, and resquash it with the same settings. Then finally merge the 3 parts back together again?
Or is that not the right way to go about this?
My objective is to modify some configuration files in the squashfs portion of the binary to open up a way into the device since all other options are closed.
Thanks.

I would also like some more info on how to repack an image.
I extracted a squashfs, modified some config files and then repacked it with the same settings as the original.
I padded the resulting squashfs with 0xff to make it the same length as the original.
To get it back together again I used dd to copy the squashfs back into the bin.
I used:
cat modified.squashfs | dd conv=notrunc of=original.bin bs=1 seek=$((0x2A0000))
where 0x2A0000 was the start of my Squashfs (so 0xFDDD4 in your case).
However, the resulting binary would not boot on my device. Still debugging

@benjaminlevine would you mind explaining to me how you "padded the resulting squashfs with 0xff to make it the same length as the original"?
Apart from that, I also tried the same method. Upon using binwalk -e firmware.bin on the final, modified firmware binary, in the /_firmware.bin.extracted/ directory, I saw that all the files (including the modified files) that were previously neatly organized into different folders like etc, tmp, var, www, bin, usr in the stock firmware were present inside the _firmware.bin.extracted directory with no order whatsoever. There was also a squashfs-root directory present which had the same files (including the modified ones) in perfect order like in the stock firmware binary.
I believe that appending the modified filesystem on the stock binary seems to create this mess and have two copies of each file.

@ArionMiles I am not sure how @benjaminlevine padded their firmware, but I wrote a quick script to do it for me:
original_file_size = File.size '/home/original/firmware/location/blob'
repacked_file_size = File.size '/home/repacked/firmware/location/blob'

File.open('/home/repacked/firmware/location/blob', 'ab') do |file|
  (original_file_size - repacked_file_size).times do
    file.write "\xFF"
  end
end

puts "Padded the repacked binary with (#{original_file_size - repacked_file_size}) bytes of 0xFF"

I haven't worked on this much as of late, but I've still been unsuccessful with repacking a modified firmware and loading it back onto the device via flashing with an external programmer.
Any more tips or advice would be appreciated.

This isn't a binwalk related question, as binwalk does not re-build binary images. However, you might want to take a look at the firmware mod kit, which uses binwalk for extraction and can re-build many router firmware images automatically (it may even work on this particular firmware): https://code.google.com/archive/p/firmware-mod-kit/

So I take it you refuse this feature request as mentioned in the first post?

Firmware mod kit has long been abandoned. It doesn't work for me, and I can't even submit an issue to anyone. Would be nice if someone created a new firmware mod kit, possibly forking the previous one and adding more features on it.

@abduct Correct. Unfortunately what you're asking is not a trivial undertaking; IMHO there are too many oddball firmwares and edge cases to make such a tool generic and reliable. If one were to attempt such a utility, it would best to make it a completely separate project.
The only tool that I'm aware of that has attempted this is the firmware-mod-kit; as @ArionMiles mentioned it has not been updated for some time, but if you're looking for something that can handle just the most common/simple/generic cases it may be just what you're looking for.

This problem isn't directly binwalk related but please give it a read and if you can help, please reply.
The only problem I'm facing at this point is when I extract the filesystem with binwalk into a squashfs-root directory and squash it back into a filesys.squashfs using mksquashfs squasfs-root filesys.squashfs with lzma compression (as the original filesystem also uses lzma)
Now, I put this modified filesystem by two methods with same results:
#Method 1:
dd if=filesys.squashfs of=firmware.bin bs=1 seek=1180160 conv=notrunc where 1180160 is the starting point of filesystem.
#Method 2:
I use the tpl-tool included in firmware mod kit for tp-link firmwares (this is a tp-link firmware I'm trying to modify)
I get a firmware.bin-rootfs file along with -bootloader -kernel -header files. I rename my filesys.squashfs to firmware.bin-rootfs and replace it with the firmware.bin-rootfs originally extracted by tpl-tool and run the tpl-tool -b firmware.bin and get a modifed firmware.bin-new file.
#RESULT:
Extracting the modifed firmware with binwalk in both the results gets me a squashfs-root folder where all the files previously arranged into bin usr tmp var sbin www and the likes are directly placed into the squashfs-root folder with no arrangement whatsoever. There are also the bin, usr, www, etc. folders inside this directory with same files. So my question is.... WHAT IS GOING ON?


Remove out sequence from simple rest api example

Purpose
$subject

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Rm3Reranker: Construct query manually instead of using Lucene's Query…

…Parser.
Fixes #429

@lintool I've confirmed with core17 that that the experimental results are the same as before.

Can you run on our standard battery of regression tests?
nohup python src/main/python/run_regression.py --collection disk12 >& log.disk12 &
nohup python src/main/python/run_regression.py --collection robust04 >& log.robust04 &
nohup python src/main/python/run_regression.py --collection robust05 >& log.robust05 &
nohup python src/main/python/run_regression.py --collection core17 >& log.core17 &

nohup python src/main/python/run_regression.py --collection car17 >& log.car17 &

nohup python src/main/python/run_regression.py --collection mb11 >& log.mb11 &
nohup python src/main/python/run_regression.py --collection mb13 >& log.mb13 &

nohup python src/main/python/run_regression.py --collection wt10g >& log.wt10g &
nohup python src/main/python/run_regression.py --collection gov2 >& log.gov2 &
nohup python src/main/python/run_regression.py --collection cw09b >& log.cw09b &
nohup python src/main/python/run_regression.py --collection cw12b13 >& log.cw12b13 &
nohup python src/main/python/run_regression.py --collection cw12 >& log.cw12 &

This is just a matter of cut and paste and wait... see if your new code trips a corner case.

@lintool I'm not getting the expected results, I'll have to take a deeper look at it.

@lintool
I've taken a deep look into the results - it appears that the old query parser method had an error when handling small (or large, I suppose) floating point numbers.
When the query was parsed, a space was added between the number and "E" - this meant that the letter "E" was part of the query. See the image below for a diff between the old parser generated query (left) and new manually constructed BoostQuery (right).

I've submitted another PR with the updated values for the regression tests - I'm running the regressions once more as a sanity check and will follow-up once they've finished.

Great!
@Peilin-Yang I told you that using the query parser was janky and bug-prone! :)
@r-clancy One more set of regressions - just copy and paste and verify:
https://github.com/castorini/Anserini/blob/master/docs/experiments-jdiq2018.md

@lintool All the regressions look good, no failures.


Add missing config backup when adding github status checks

I missed committing one local update for #4456

/check-enforcer override


Geometry dash 2.206 Not Working

Geode Issue

[X] I confirm that this bug is NOT related to a mod but directly to Geode Loader itself.

Platform
MacOS
SDK commit
No response
Geode Version
v.2.0.0
Mods Installed
41 (i dont remember)
Expected Behavior
Load it in the bottom
Actual Behavior
Not Loading
Steps to Reproduce
New Geometry Dash Update
Additional Information

In the Additional Informations there is no:
Image 1: No Geode's Resources Loading Thing
Image 2: No Geode/Globed Button

Wait for geode to be updated for 2.206

The Geode Team (or other people) have to commit bindings for Geometry Dash version 2.206 for each platform, also making Geode work for Windows as now RobTop has made the program with the 64-bit architecture, as well as making Geode available for Macs on Apple Silicon as now that's released. (I can't remember if the last one is true but whatever.)


Add a Codacy badge to README.md

Coverage remained the same at 100.0% when pulling 13ae062b10f4f2d792bef8c8b246914907366b99 on codacy-badger:codacy-badge-1 into c1cc1fcbfeeec62e6abb70c3e3a7e8bac84285ed on Travix-International:master.


react-router-dom

I noticed that you used the react-dom in the project, but since it is a web project, it is best to use the react-router-dom, which provides specific components for web development and re-exports all the functions of the react-router.
You can check this on a issue with the react-router's own design: https://github.com/ReactTraining/react-router/issues/4648

@FannyVieira Could you help to improve this within hacktoberfest? :)

of course I'll try


Tag jobs

Ideally, you should be able to get to all of the relevant information about a job by looking at its page in DIGITS, and you should be able to filter and sort by any attribute you like in the results browser (#195).
However, at the moment a lot of that information is buried in .prototxt files, etc. As a temporary solution and as an overall enhancement, DIGITS could let you attach arbitrary tags to jobs like luke's jobs (but see #201), weekend batch, batch size=100, foo, etc.
We could restrict it to only tags which have been explicitly created like GitHub does (look over there -->), but it might be better to just allow any arbitrary string.

@lukeyeager ,  I am interested in working on this enhancement. Can you explain that what type of tags should be added to a particular job ? Are these tags similar to the #283 ?

@DESHRAJ, that's great thanks!
Tags would be a list of strings that go along with a job. For example:
>>> job.tags()
['luke-jobs', 'new-caffe', 'benchmarking']

I'd like to see:

An interface for adding tags while creating the job
An interface for adding/removing tags once the job is created
The ability to sort/filter by tags in the results browser (#195)

Ok great, that sounds cool. I have started working on it. Will get back to you if I need some help.
Thanks for explaining :)


TypeError: Cannot read property 'match' of undefined

https://sentry.io/apisis/apisis/issues/370601869/
TypeError: Cannot read property 'match' of undefined
  File "/apis/releases/29233938/endpoints/cinema/index.js", line 65, in Object.<anonymous>
    .match(/\/images\/poster\/.+\.(jpg|jpeg|png)/ig) || []
  File "/apis/releases/29233938/endpoints/cinema/index.js", line 35, in Request.request [as _callback]
    movies.each(function () {
...
(11 additional frame(s) were not displayed)

TypeError: Cannot read property 'match' of undefined

https://sentry.io/apisis/apisis/issues/242018001/

How can I get access to the project on sentry.io?

@MiniGod I can invite you, I was going to setup a thing where new issues in sentry would open up github issues for them so we didn't need to all have access to it but didn't finish that idea.


[AIRFLOW-727] try_number is not increased

Dear Airflow Maintainers,
Please accept this PR that addresses the following issues:

AIRFLOW-727

Per Apache guidelines you need to create a Jira issue.
Testing Done:

new unit test added

A dag that has retries enabled will retry indefinitely
as try_number gets reset to 0 in LocalTaskJob as
task_instance is not fully populated, but nevertheless
saved to the databases.
This was caused by a commit in
https://github.com/apache/incubator-airflow/pull/1939
@saguziel @aoen

Current coverage is 66.98% (diff: 100%)

Merging #1969 into master will decrease coverage by <.01%

@@             master      #1969   diff @@
==========================================
  Files           135        135
  Lines         10248      10255     +7
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           6865       6869     +4
- Misses         3383       3386     +3
  Partials          0          0

Powered by Codecov. Last update 937142d...6948e40

LGTM, and extra thanks for adding the tests

Thanks @bolkedebruin


Speed up advancing within a block, take 2.

PR #13692 tried to speed up advancing by using branchless binary search, but while this yielded a speedup on my machine, this yielded a slowdown on nightly benchmarks.
This PR tries a different approach using vectorization. Experimentation suggests that it slows down a bit queries when advancing often goes to the very next doc ID, such as term queries and OrHighNotXXX tasks. But it speeds up queries that advance to the next few doc IDs, such as AndHighHigh. I think that this is a good trade-off since it slows down some plenty fast queries in exchange for a speedup with some more expensive queries.
Here is a luceneutil run on wikibigall with -searchConcurrency 0:
                            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
                   OrHighNotHigh      302.78      (2.4%)      283.75      (2.9%)   -6.3% ( -11% -   -1%) 0.000
                    OrHighNotMed      384.69      (3.0%)      363.33      (2.8%)   -5.6% ( -10% -    0%) 0.000
                         MedTerm      564.86      (2.2%)      537.04      (3.5%)   -4.9% ( -10% -    0%) 0.000
                         LowTerm     1014.02      (2.2%)      967.37      (3.6%)   -4.6% ( -10% -    1%) 0.000
                    OrHighNotLow      446.38      (3.4%)      427.10      (3.3%)   -4.3% ( -10% -    2%) 0.000
                        HighTerm      485.41      (1.9%)      464.49      (3.2%)   -4.3% (  -9% -    0%) 0.000
                   OrNotHighHigh      229.78      (2.4%)      221.51      (3.1%)   -3.6% (  -8% -    1%) 0.000
                    OrNotHighMed      396.63      (2.7%)      382.41      (3.1%)   -3.6% (  -9% -    2%) 0.000
                         Prefix3      145.65      (3.6%)      142.39      (3.7%)   -2.2% (  -9% -    5%) 0.051
                          IntNRQ      158.04      (4.7%)      154.77      (5.6%)   -2.1% ( -11% -    8%) 0.205
                       CountTerm     8320.96      (3.2%)     8198.56      (4.7%)   -1.5% (  -9% -    6%) 0.246
                        PKLookup      273.35      (3.6%)      269.71      (5.2%)   -1.3% (  -9% -    7%) 0.345
                        Wildcard       83.30      (3.4%)       82.28      (3.1%)   -1.2% (  -7% -    5%) 0.234
               HighTermMonthSort     3235.98      (3.1%)     3198.04      (2.9%)   -1.2% (  -6% -    4%) 0.215
               HighTermTitleSort      148.94      (2.5%)      148.38      (2.6%)   -0.4% (  -5% -    4%) 0.638
                  CountOrHighMed      104.51      (2.0%)      104.22      (1.7%)   -0.3% (  -3% -    3%) 0.640
            HighTermTitleBDVSort       14.67      (5.3%)       14.64      (5.9%)   -0.2% ( -10% -   11%) 0.899
                    AndStopWords       30.68      (3.0%)       30.66      (2.7%)   -0.1% (  -5% -    5%) 0.941
                 CountOrHighHigh       50.17      (2.0%)       50.19      (1.9%)    0.0% (  -3% -    3%) 0.947
                      OrHighRare      273.82      (4.5%)      273.96      (3.8%)    0.0% (  -7% -    8%) 0.971
                      TermDTSort      353.37      (6.4%)      354.23      (6.7%)    0.2% ( -12% -   14%) 0.907
                          Fuzzy1       77.85      (2.6%)       78.12      (2.0%)    0.3% (  -4% -    4%) 0.633
                          Fuzzy2       73.23      (2.5%)       73.50      (1.9%)    0.4% (  -3% -    4%) 0.594
           HighTermDayOfYearSort      836.62      (3.1%)      841.07      (4.0%)    0.5% (  -6% -    7%) 0.639
             And2Terms2StopWords      154.49      (1.8%)      155.41      (2.1%)    0.6% (  -3% -    4%) 0.340
                       OrHighLow      771.90      (2.0%)      778.20      (2.2%)    0.8% (  -3% -    5%) 0.217
                       And3Terms      167.63      (2.3%)      169.23      (2.2%)    1.0% (  -3% -    5%) 0.176
                     OrStopWords       33.99      (4.6%)       34.39      (4.1%)    1.2% (  -7% -   10%) 0.388
                 CountAndHighMed      148.01      (2.4%)      149.91      (1.0%)    1.3% (  -2% -    4%) 0.025
              Or2Terms2StopWords      156.93      (2.8%)      159.21      (3.0%)    1.5% (  -4% -    7%) 0.117
                     AndHighHigh       67.06      (1.3%)       68.07      (1.6%)    1.5% (  -1% -    4%) 0.001
                          OrMany       18.67      (2.9%)       18.96      (2.9%)    1.5% (  -4% -    7%) 0.089
                      AndHighMed      185.02      (1.6%)      189.06      (1.3%)    2.2% (   0% -    5%) 0.000
                      AndHighLow      948.34      (2.6%)      970.47      (2.6%)    2.3% (  -2% -    7%) 0.004
                      OrHighHigh       68.42      (1.4%)       70.08      (1.3%)    2.4% (   0% -    5%) 0.000
                        Or3Terms      166.47      (2.7%)      171.10      (3.1%)    2.8% (  -2% -    8%) 0.003
                    OrNotHighLow      964.69      (3.1%)      994.46      (3.3%)    3.1% (  -3% -    9%) 0.002
                       OrHighMed      222.32      (2.1%)      230.93      (1.5%)    3.9% (   0% -    7%) 0.000
                CountAndHighHigh       48.88      (2.4%)       52.87      (1.3%)    8.2% (   4% -   12%) 0.000

Specializing ImpactsDISI#nextDoc() helped get rid of the slowdown:
                            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
                    AndStopWords       31.34      (1.8%)       30.84      (4.0%)   -1.6% (  -7% -    4%) 0.105
                       CountTerm     8573.12      (3.8%)     8449.05      (4.7%)   -1.4% (  -9% -    7%) 0.284
                  CountOrHighMed      105.75      (2.1%)      104.50      (1.4%)   -1.2% (  -4% -    2%) 0.039
                      TermDTSort      363.06      (6.4%)      358.98      (6.6%)   -1.1% ( -13% -   12%) 0.585
                 CountOrHighHigh       50.62      (2.4%)       50.28      (1.7%)   -0.7% (  -4% -    3%) 0.305
                          IntNRQ      453.67      (4.7%)      451.13      (4.5%)   -0.6% (  -9% -    9%) 0.700
                      OrHighRare      283.32      (3.8%)      282.52      (3.8%)   -0.3% (  -7% -    7%) 0.813
                          Fuzzy1       78.58      (2.1%)       78.42      (3.0%)   -0.2% (  -5% -    5%) 0.812
           HighTermDayOfYearSort      850.86      (4.4%)      849.52      (3.0%)   -0.2% (  -7% -    7%) 0.895
            HighTermTitleBDVSort       13.97      (6.3%)       13.96      (5.5%)   -0.1% ( -11% -   12%) 0.974
             And2Terms2StopWords      157.31      (1.3%)      157.27      (2.2%)   -0.0% (  -3% -    3%) 0.965
                         LowTerm      985.67      (3.0%)      986.01      (1.8%)    0.0% (  -4% -    4%) 0.964
               HighTermMonthSort     3216.69      (2.2%)     3217.92      (3.9%)    0.0% (  -5% -    6%) 0.969
                          Fuzzy2       73.69      (2.0%)       73.74      (2.4%)    0.1% (  -4% -    4%) 0.910
                     AndHighHigh       65.88      (2.1%)       66.18      (2.0%)    0.5% (  -3% -    4%) 0.472
                       And3Terms      169.85      (2.0%)      170.81      (2.4%)    0.6% (  -3% -    5%) 0.424
                          OrMany       19.10      (1.7%)       19.22      (1.7%)    0.6% (  -2% -    4%) 0.237
              Or2Terms2StopWords      160.88      (1.4%)      161.91      (2.0%)    0.6% (  -2% -    4%) 0.241
                     OrStopWords       34.90      (1.4%)       35.15      (3.9%)    0.7% (  -4% -    6%) 0.450
                       OrHighLow      799.18      (1.6%)      805.33      (1.5%)    0.8% (  -2% -    3%) 0.117
                 CountAndHighMed      149.99      (3.1%)      151.23      (1.1%)    0.8% (  -3% -    5%) 0.261
                        Wildcard       88.47      (2.7%)       89.32      (3.2%)    1.0% (  -4% -    7%) 0.309
                        PKLookup      270.87      (3.8%)      273.47      (1.7%)    1.0% (  -4% -    6%) 0.307
                         Prefix3       93.00      (8.2%)       94.14      (6.3%)    1.2% ( -12% -   17%) 0.599
                         MedTerm      690.05      (2.6%)      701.55      (1.3%)    1.7% (  -2% -    5%) 0.010
                    OrHighNotMed      359.57      (2.7%)      366.02      (1.9%)    1.8% (  -2% -    6%) 0.014
                        Or3Terms      170.81      (1.3%)      173.98      (2.1%)    1.9% (  -1% -    5%) 0.001
                    OrHighNotLow      432.25      (3.4%)      440.76      (2.4%)    2.0% (  -3% -    8%) 0.035
               HighTermTitleSort      159.15      (4.8%)      162.44      (2.9%)    2.1% (  -5% -   10%) 0.096
                      AndHighMed      225.25      (2.6%)      229.93      (1.4%)    2.1% (  -1% -    6%) 0.002
                        HighTerm      455.45      (2.4%)      465.69      (2.1%)    2.2% (  -2% -    6%) 0.002
                      OrHighHigh       78.87      (1.5%)       80.64      (1.5%)    2.3% (   0% -    5%) 0.000
                   OrHighNotHigh      218.32      (2.7%)      224.10      (2.0%)    2.6% (  -2% -    7%) 0.000
                    OrNotHighLow     1111.11      (2.8%)     1144.28      (2.5%)    3.0% (  -2% -    8%) 0.000
                       OrHighMed      267.13      (1.8%)      275.57      (1.3%)    3.2% (   0% -    6%) 0.000
                    OrNotHighMed      303.24      (3.0%)      313.56      (2.5%)    3.4% (  -2% -    9%) 0.000
                   OrNotHighHigh      230.18      (2.8%)      238.62      (2.2%)    3.7% (  -1% -    8%) 0.000
                      AndHighLow      866.39      (2.7%)      903.54      (2.4%)    4.3% (   0% -    9%) 0.000
                CountAndHighHigh       49.60      (3.1%)       53.54      (0.9%)    7.9% (   3% -   12%) 0.000

And I seem to be getting a better speedup by using trueCount() instead of firstTrue():
                            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
                       CountTerm     8621.82      (5.6%)     8504.44      (4.6%)   -1.4% ( -10% -    9%) 0.401
                    AndStopWords       31.14      (1.4%)       30.83      (4.6%)   -1.0% (  -6% -    5%) 0.363
                         Prefix3       96.42      (5.7%)       95.50      (4.4%)   -1.0% ( -10% -    9%) 0.557
            HighTermTitleBDVSort       15.80      (6.0%)       15.65      (5.0%)   -0.9% ( -11% -   10%) 0.587
                     OrStopWords       34.67      (2.9%)       34.45      (5.7%)   -0.6% (  -8% -    8%) 0.657
                    OrNotHighMed      385.71      (4.2%)      384.12      (3.2%)   -0.4% (  -7% -    7%) 0.725
                      TermDTSort      346.51      (5.7%)      345.26      (6.2%)   -0.4% ( -11% -   12%) 0.847
               HighTermTitleSort      153.13      (1.7%)      152.59      (3.3%)   -0.4% (  -5% -    4%) 0.670
                          OrMany       19.06      (1.6%)       18.99      (3.2%)   -0.3% (  -5% -    4%) 0.671
               HighTermMonthSort     3126.69      (2.9%)     3117.99      (3.7%)   -0.3% (  -6% -    6%) 0.791
                 CountOrHighHigh       50.32      (1.6%)       50.26      (2.1%)   -0.1% (  -3% -    3%) 0.862
                  CountOrHighMed      104.69      (1.7%)      104.70      (2.0%)    0.0% (  -3% -    3%) 0.981
                        PKLookup      270.86      (2.7%)      270.98      (2.7%)    0.0% (  -5% -    5%) 0.960
                      OrHighRare      281.93      (3.4%)      282.35      (4.8%)    0.1% (  -7% -    8%) 0.911
                        Wildcard       49.07      (3.7%)       49.15      (4.2%)    0.2% (  -7% -    8%) 0.893
              Or2Terms2StopWords      160.10      (1.5%)      160.52      (3.5%)    0.3% (  -4% -    5%) 0.756
             And2Terms2StopWords      156.75      (1.5%)      157.35      (2.8%)    0.4% (  -3% -    4%) 0.586
                       OrHighLow      855.65      (2.4%)      859.93      (2.7%)    0.5% (  -4% -    5%) 0.542
           HighTermDayOfYearSort      800.87      (2.8%)      805.06      (2.9%)    0.5% (  -5% -    6%) 0.562
                       And3Terms      169.90      (1.5%)      170.87      (3.1%)    0.6% (  -3% -    5%) 0.455
                          Fuzzy1       77.88      (3.3%)       78.52      (2.9%)    0.8% (  -5% -    7%) 0.409
                          Fuzzy2       73.27      (3.0%)       73.93      (2.4%)    0.9% (  -4% -    6%) 0.295
                    OrNotHighLow     1099.84      (3.7%)     1114.61      (3.8%)    1.3% (  -5% -    9%) 0.260
                        Or3Terms      169.45      (1.5%)      171.80      (3.7%)    1.4% (  -3% -    6%) 0.118
                 CountAndHighMed      148.89      (2.5%)      151.58      (3.0%)    1.8% (  -3% -    7%) 0.040
                         LowTerm     1033.62      (3.6%)     1052.61      (2.8%)    1.8% (  -4% -    8%) 0.075
                    OrHighNotMed      371.62      (3.1%)      378.74      (3.5%)    1.9% (  -4% -    8%) 0.066
                   OrHighNotHigh      296.15      (3.1%)      302.30      (3.1%)    2.1% (  -4% -    8%) 0.036
                     AndHighHigh       70.55      (1.6%)       72.20      (2.4%)    2.3% (  -1% -    6%) 0.000
                      OrHighHigh       94.03      (1.6%)       96.25      (2.0%)    2.4% (  -1% -    6%) 0.000
                    OrHighNotLow      442.74      (3.0%)      454.42      (3.6%)    2.6% (  -3% -    9%) 0.011
                       OrHighMed      232.09      (2.5%)      238.43      (2.5%)    2.7% (  -2% -    7%) 0.001
                          IntNRQ      110.25     (15.4%)      113.35     (17.9%)    2.8% ( -26% -   42%) 0.594
                         MedTerm      601.09      (3.7%)      619.19      (2.2%)    3.0% (  -2% -    9%) 0.002
                      AndHighMed      221.49      (1.9%)      228.33      (2.4%)    3.1% (  -1% -    7%) 0.000
                        HighTerm      520.52      (3.4%)      537.37      (2.6%)    3.2% (  -2% -    9%) 0.001
                      AndHighLow     1047.38      (2.8%)     1082.62      (2.7%)    3.4% (  -2% -    9%) 0.000
                   OrNotHighHigh      276.13      (3.5%)      286.23      (3.4%)    3.7% (  -3% -   10%) 0.001
                CountAndHighHigh       49.28      (2.3%)       54.98      (2.4%)   11.6% (   6% -   16%) 0.000

I ran this PR on my Mac laptop (M3), where this gives a massive slowdown, I imagine because some of the vector operations I'm using are emulated. I need to find what to check against in order to avoid this like we did for vectors with PanamaVectorConstants.HAS_FAST_INTEGER_VECTORS.

you are using VectorMask, only use this where implemented in HW (AVX-512 and ARM SVE).

https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/aarch64/aarch64_vector.ad#L280-L283

For these uses of vectormask you are ok with AVX2 (so just use existing FAST_INTEGER_VECTORS check):
https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/x86.ad#L1597-L1603
So if you want to add this one without slowdowns: i would check: FAST_INTEGER_VECTORS && amd64

maybe its a bug that it doesnt work on your mac either. because elsewhere they have code that looks like it is supposed to be doing this stuff: https://github.com/openjdk/jdk/blob/f1a9a8d25b2e1f9b5dbe8719abb66ec4cd9057dc/src/hotspot/cpu/aarch64/aarch64_vector_ad.m4#L3782

I did more digging: vectorization actually worked on my Mac! So my best guess is that I got a ~20% slowdown because I only have 2 lanes on it, so the trueCount != LONG_SPECIES.length() is much less likely on my Mac than on my Linux desktop which has 4 lanes, and this hurts more than it helps compared to the naive linear scan. (See https://github.com/apache/lucene/pull/13692#issuecomment-2324658146 for some stats about how far advance() needs to go within a block.)
For now I disabled the optimization on machines which have less than 4 lanes, I'll try to run benchmarks on more CPUs to confirm it's not only helpful on my desktop CPU (AMD Ryzen 9 3900X).

Here's wikimediumall on a c7i.2xlarge instance that supports AVX512:
                            TaskQPS baseline      StdDevQPS my_modified_version      StdDev                Pct diff p-value
                          IntNRQ       28.57     (13.8%)       27.57     (14.7%)   -3.5% ( -28% -   28%) 0.437
            HighTermTitleBDVSort        4.59      (5.9%)        4.50      (3.8%)   -1.9% ( -10% -    8%) 0.212
                       OrHighMed      104.54      (3.5%)      102.60      (4.4%)   -1.9% (  -9% -    6%) 0.137
                 CountOrHighHigh       27.80      (4.6%)       27.40      (6.6%)   -1.4% ( -12% -   10%) 0.425
                       CountTerm     3894.27      (9.2%)     3851.05      (9.8%)   -1.1% ( -18% -   19%) 0.711
                    OrHighNotLow      466.67      (5.3%)      462.00      (6.2%)   -1.0% ( -11% -   11%) 0.582
                       OrHighLow      351.91      (4.0%)      348.61      (6.2%)   -0.9% ( -10% -    9%) 0.570
           HighTermDayOfYearSort      662.01      (4.6%)      657.47      (5.7%)   -0.7% ( -10% -   10%) 0.674
                    OrHighNotMed      398.60      (3.7%)      396.54      (6.5%)   -0.5% ( -10% -   10%) 0.759
                          OrMany        5.93      (4.9%)        5.91      (5.5%)   -0.4% ( -10% -   10%) 0.802
                  CountOrHighMed       56.55      (4.3%)       56.43      (4.6%)   -0.2% (  -8% -    9%) 0.877
                      OrHighRare      128.24      (4.4%)      128.13      (5.0%)   -0.1% (  -9% -    9%) 0.956
               HighTermMonthSort     1227.54      (5.3%)     1227.05      (5.9%)   -0.0% ( -10% -   11%) 0.982
                        Wildcard       63.11      (4.6%)       63.12      (5.1%)    0.0% (  -9% -   10%) 0.991
               HighTermTitleSort      102.24      (6.1%)      102.44      (5.0%)    0.2% ( -10% -   12%) 0.912
                    OrNotHighLow      375.52      (4.2%)      377.10      (5.8%)    0.4% (  -9% -   10%) 0.794
                         Prefix3      279.44      (4.1%)      280.66      (5.4%)    0.4% (  -8% -   10%) 0.773
                        Or3Terms       71.44      (3.5%)       71.86      (4.7%)    0.6% (  -7% -    9%) 0.654
                        HighTerm      520.73      (4.8%)      523.93      (5.7%)    0.6% (  -9% -   11%) 0.712
                        PKLookup      133.95      (3.7%)      134.86      (4.8%)    0.7% (  -7% -    9%) 0.619
              Or2Terms2StopWords       62.90      (3.7%)       63.49      (3.9%)    0.9% (  -6% -    8%) 0.431
                     OrStopWords       10.04     (10.1%)       10.15      (7.3%)    1.1% ( -14% -   20%) 0.693
                    OrNotHighMed      255.32      (5.0%)      258.31      (5.4%)    1.2% (  -8% -   12%) 0.479
                         LowTerm      466.43      (4.9%)      472.54      (5.9%)    1.3% (  -9% -   12%) 0.444
             And2Terms2StopWords       62.80      (3.6%)       63.92      (6.0%)    1.8% (  -7% -   11%) 0.251
                      TermDTSort      286.00      (3.2%)      291.35      (4.9%)    1.9% (  -6% -   10%) 0.157
                      AndHighLow      528.23      (4.0%)      538.88      (5.6%)    2.0% (  -7% -   12%) 0.191
                   OrHighNotHigh      275.41      (4.7%)      282.18      (6.1%)    2.5% (  -8% -   14%) 0.157
                      OrHighHigh       37.26      (7.6%)       38.33      (6.5%)    2.9% ( -10% -   18%) 0.201
                         MedTerm      509.40      (4.7%)      524.29      (6.6%)    2.9% (  -8% -   14%) 0.107
                    AndStopWords        8.97      (4.9%)        9.27      (6.5%)    3.4% (  -7% -   15%) 0.064
                      AndHighMed       85.68      (4.6%)       89.16      (5.8%)    4.1% (  -6% -   15%) 0.014
                       And3Terms       79.84      (3.8%)       83.53      (5.3%)    4.6% (  -4% -   14%) 0.001
                   OrNotHighHigh      256.91      (4.5%)      268.87      (6.6%)    4.7% (  -6% -   16%) 0.009
                     AndHighHigh       28.73      (6.2%)       31.71      (7.5%)   10.4% (  -3% -   25%) 0.000
                 CountAndHighMed       66.60      (3.9%)       78.40      (5.2%)   17.7% (   8% -   27%) 0.000
                CountAndHighHigh       16.96      (3.5%)       21.67      (6.1%)   27.8% (  17% -   38%) 0.000

I plan on merging this change soon, and looking into moving postings back to int[] arrays next to hopefully get benefits from having 2x more lanes that can be compared at once.

Nightly benchmarks just picked up the change with a mix of speedups and slowdowns: https://benchmarks.mikemccandless.com/2<IP_ADDRESS>.12.23.html. Here are the main ones I'm seeing:
Speedups:

CountAndHighHigh: +5%
CountAndHighMed: +2.5%

Slowdowns:

Phrase -3.5%
AndHighOrMedMed: -3%
OrHighRare: -3%
AndHighHigh: -3%
AndHighMed: -2.5%

I'm a bit surprised/disappointed at the AndHighHigh/AndHighMed slowdown since this change is supposed to help conjunctions, and the counting queries proved it helps. I'll look into it.

If you check out data at https://github.com/apache/lucene/pull/13692#issuecomment-2324658146, AndHighHigh and AndHighMed tend to advance a bit further than CountAndHighHigh and CountAndHighMed, so that might be the issue. I am tempted to not touch anything yet and see how nightlies react to https://github.com/apache/lucene/pull/13968, which should allow to check 2x more values at once.


Build fails on 3.1.0 and following without any clear error

First of all my project was mainly build using Dart 1.0 quite a while ago and I almost only migrated first to Dart 2.0 and recently to 3.0. With Dart 3.0.7 the project builds fine, but I had an issue with 3.2.4 on my server. I used asdf to test different Dart versions and switching from Dart 3.0.7 to 3.1.0 produces the following error. There are no obvious webdev or build_web_compilers changes switching between these versions, so I'm not quite sure where this error is coming from and what even might be the problem. The output is generated using webdev build -v -o bin:build:
[INFO] Connecting to the build daemon...
[INFO] Generating build script...
[INFO] Generating build script completed, took 805ms
[INFO]
[INFO] Starting daemon...
[INFO] BuildDefinition: Initializing inputs
[INFO] BuildDefinition: Reading cached asset graph...
[INFO] BuildDefinition: Reading cached asset graph completed, took 412ms

[INFO] BuildDefinition: Checking for updates since last build...
[INFO] BuildDefinition: Checking for updates since last build completed, took 1.3s

[SEVERE] Initializing inputs
[SEVERE] Reading cached asset graph...
[SEVERE] Reading cached asset graph completed, took 412ms
[SEVERE]
[SEVERE] Checking for updates since last build...
[SEVERE] Checking for updates since last build completed, took 1.3s
[SEVERE]
[SEVERE] Setting up file watchers...
[SEVERE] Setting up file watchers completed, took 12ms
[SEVERE]
[INFO] About to build [bin]...
[INFO] Build: Running build...
[INFO] Build: Running build completed, took 228ms

[INFO] Build: Caching finalized dependency graph...
[INFO] Build: Caching finalized dependency graph completed, took 265ms

[SEVERE] build_web_compilers:entrypoint on bin/main.dart (cached): ExitCode:0
StdOut:
Compiled 10,006,579 input bytes (5,219,522 characters source) to 238,243 characters JavaScript in 3.45 seconds using 264.230 MB of memory

StdErr:

[SEVERE] Build: Failed after 505ms
[SEVERE] FailureType: 1

The project is public. Checking out the master branch and either executing make release or without Make do a simple dart pub get followed by the above command should reproduce the error.
Project: https://github.com/gerritwalther/sg2o
My dart info response using Dart 3.1.0 :
$ dart info

If providing this information as part of reporting a bug, please review the information
below to ensure it only contains things you're comfortable posting publicly.

#### General info

- Dart 3.1.0 (stable) (Tue Aug 15 21:33:36 2023 +0000) on "linux_x64"
- on linux / Linux 6.6.24-1-MANJARO #1 SMP PREEMPT_DYNAMIC Thu Apr  4 04:33:21 UTC 2024
- locale is en_GB.UTF-8

#### Project info

- sdk constraint: '>=3.0.0 <4.0.0'
- dependencies: html, path
- dev_dependencies: build_runner, build_web_compilers

#### Process info

No Dart processes found.

I see you are passing a -o argument to dart2js in your build.yaml file - can you try removing that? There is already an implicit -o flag being passed, and we require it to go to a specific place. I think maybe it is failing because it doesn't see the expected output.

I see you are passing a -o argument to dart2js in your build.yaml file - can you try removing that? There is already an implicit -o flag being passed, and we require it to go to a specific place. I think maybe it is failing because it doesn't see the expected output.

Yes, that solved my issue, thank you very much for your help. I guess you changed the behavior in 3.1.0?
I'm still getting the SEVERE errors/warnings, but those don't interfere with my build. The output also looks fine to me.
[SEVERE] Initializing inputs
[SEVERE] Building new asset graph...
[SEVERE] Building new asset graph completed, took 1.3s
[SEVERE]
[SEVERE] Checking for unexpected pre-existing outputs....
[SEVERE] Checking for unexpected pre-existing outputs. completed, took 0ms
[SEVERE]
[SEVERE] Setting up file watchers...
[SEVERE] Setting up file watchers completed, took 4ms
[SEVERE]

Yes, that solved my issue, thank you very much for your help. I guess you changed the behavior in 3.1.0?

I don't remember any particular change here, it was never intended to be supported at least (in build_runner). The flag is supported by dart2js itself still, it just doesn't make sense to use in this context.

I don't remember any particular change here, it was never intended to be supported at least (in build_runner). The flag is supported by dart2js itself still, it just doesn't make sense to use in this context.

I guess I just moved it along when migrating from Dart 1 to 2 and never changed it while it was working. Thank you again for your help.


GitHub api retrieve commits

That was left from my previous try to find suitable lib to integrate with Github.
Turns out, in our case we don't need to be authenticated at all.
org.kohsuke.github.GitHub is not needed anymore, I've removed it.


[Android]: scrollView scrollTo doesn't do anything

componentWillMount() {
const updateListener = Platform.OS === 'android' ? 'keyboardDidShow' : 'keyboardWillShow';
const resetListener = Platform.OS === 'android' ? 'keyboardDidHide' : 'keyboardWillHide';
DeviceEventEmitter.addListener(updateListener, this.keyboardDidShow.bind(this));
DeviceEventEmitter.addListener(resetListener, this.keyboardDidHide.bind(this));
}
keyboardDidShow(){
this.refs.mainScrollView.scrollTo(
{y:100,x:160, animated:true}
);
}

Looks good for a Stackoverflow post. But if you want help from anyone, please style the code properly, fill the issue template and write down which versions of React Native you've tested with on which devices.

thx，okay，I will do these in the furture, I have solved the question

https://github.com/facebook/react-native/issues/11693


Add Glossary

I think a preliminary section mentioning some jargon and commonly used acronyms (e.g. LSB, MSB) could be helpful. It could also introduce some of the standards and rules we adopt in the document, adding some clarifications (e.g. units, bases)

As per #287, "dots" is introduced twice.

@avivace requested that I make a new issue, but I'll just hijack this one.
I think a glossary with links to each section the terms appear in would be great. It could additionally include definitions that appear on mouse-over of the term (maybe with a delay).

I can try adding markup for that as part of #292.

I can try adding markup for that as part of #292.

Nice. If you have a plaintext release of pandoc, I can get a list of words that aren’t typically in an english dictionary for you

Does this Markdown render do the job?

That’s great. If this works, we might even be able to integrate the glossary generation into the build.

To add: "CGB mode"

Markup possibilities:
https://github.com/commonmark/commonmark-spec/wiki/Deployed-Extensions#abbreviation
https://github.com/commonmark/commonmark-spec/wiki/Deployed-Extensions#definition-list

Needs to be added to the Glossary: https://github.com/gbdev/pandocs/pull/350#discussion_r979296228

Needs to be added to the Glossary: https://github.com/gbdev/pandocs/pull/534#pullrequestreview-1819981650


Landing page

user name and password on the corner
gallery photo of the image
title
a general description
top 4 plants ( pictures, navigate to the login page on the plant is selected)

Note: To see and add comments, the user needs to log into the website

Things that need to be built:
Sever.js
Session storage
landing HTML
basic CSS


Add text box for email input + clean up UI

@jaeminlee0515 I assume this is a daft PR?

@chrisvire yeah, I can remove this PR as it was a test.


nixos/borgbackup: Add option for inhibiting sleep

Description of changes
Adds a new option for backup jobs inhibitsSleep which prevents the system from going to sleep while a backup is in progress. Uses systemd-inhibit, which holds a "lock" that prevents the system from sleeping while the process it invokes is running.
This did require wrapping the existing backup script using writeShellScript so that it could be run by systemd-inhibit.
This is the recommended solution from borgbackup upstream:

My machine goes to sleep causing Broken pipe
When backing up your data over the network, your machine should not go to sleep. On macOS you can use caffeinate to avoid that.

This is also the default of borgmatic, a wrapper around borgbackup.
I'm open to making the default true rather than false, however it may not be preferable to all users, as inhibiting sleep implicates battery life of laptops among other things, and users can already set the checkpoint interval to be lower and/or increase the frequency of backup attempts if needed.
Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Could I bother you with a message in release notes as this is a notable change? @jacobgreenleaf

Could I bother you with a message in release notes as this is a notable change? @jacobgreenleaf

Done! Thank you. 👍


Training time

Hi,
Thanks for the great work and for uplaoding the training code.
Can you share the time it took to train the model room.ckpt and the device it was trained on so that I can have a reference for reproducing/ training for other scenes?
Thanks

Hi, I don't remember the exact time for training the model. But for all experiments, I train for at most 5000 epochs on at most 4 A6000 GPUs and they take less than a day. For LLFF/room the time to converge is much less and it takes about 3000 epochs to obtain pretty good results. However, also note that NeRF training is sensitive to the initialization. So if you observe a very large loss after several epochs (e.g. depth loss > 10), you might want to restart the training.


Flocq source dependency for Ergo 0.21  doesn't build on recent MacOS

Bug Report 🐛
The Ergo 0.21 compiler depends on the Flocq IEEE floating point library for Coq (using version 3.6.1 of coq-flocq). That version of the library doesn't compile on recent clang versions used in MacOS. See https://gitlab.inria.fr/flocq/flocq/-/issues/13
This makes it difficult to build the Ergo compiler from source at the moment if you have a recent version of MacOS.

For anyone bumping into this issue, the attached patched version of flocq should work on recent versions of clang.
flocq-2.6.1-fix.tar.gz
To install:
cat flocq-2.6.1-fix.tar.gz | gunzip | tar xvd -
cd flocq-2.6.1
opam install .

With Ergo 0.22 being released and removing the flocq dependency, I'm closing this issue.


custom road network

Updates how we initialize a simulation to support injection of a custom road network at the highest level.
Now, an extension to the core library could call run_sim() and pass a set of custom initialization functions.

@nreinicke hey, actually, should an init function be also allowed to update the Environment?


Add message to remove SwapRoutes in pool router

If you want to report a security issue, please follow our security policy: https://github.com/White-Whale-Defi-Platform/migaloo-core/blob/main/SECURITY.md

Improvement description

We have a message to add SwapRoutes to the pool router, but not to remove them. Would be good to have such message.

Additional context
Add any other context here, code snippets, json responses, screenshots and so on.

Code sample

Logs

Screenshots

done


2.8.0 and above: MySQL, 'tinyint unsigned' field considered as 'boolean'

Hello and thanks for the awesome work 🙏
Bug description
A field named dataName in the database is a tinyint unsigned with only values such as 0 and 1
When trying to query this table:
prisma.myTable.findOne({
      where: {
        id: 666,
      },
    });

this error occurs:
 Attempted to serialize scalar 'false' with incompatible type 'Int'

If you don't select the dataName field, there is no error:
prisma.myTable.findOne({
      where: {
        id: 666,
      },
      select: {
        id: true,
        dataName: false,
      }
    });

Introspecting and querying with 2.7.1 works flawlessly
Expected behavior
No bug 😄
Prisma information
Versions
Starting form 2.8.0
Schema
model myTable {
  id                                          Int                   @id @default(autoincrement())
  dataName                               Int                   @default(0)
}

Client debug output
  prisma-client Prisma Client call: +27ms
  prisma-client prisma.myTable.findOne({
  prisma-client   where: {
  prisma-client     id: 666
  prisma-client   }
  prisma-client }) +0ms
  prisma-client Generated request: +0ms
  prisma-client query {
  prisma-client   findOnemyTable(where: {
  prisma-client     id: 666
  prisma-client   }) {
  prisma-client     id
  prisma-client     dataName
  prisma-client   }
  prisma-client }
  prisma-client  +0ms
  engine {
  engine   error: zf [Error]: Attempted to serialize scalar 'false' with incompatible type 'Int'
  engine       at yw.graphQLToJSError (xxx/node_modules/@prisma/client/runtime/index.js:129:4637)
  engine       at xxx/node_modules/@prisma/client/runtime/index.js:129:2977
  engine       at processTicksAndRejections (internal/process/task_queues.js:97:5) {
  engine     clientVersion: '2.9.0'
  engine   }
  engine } +257ms
  prisma-client Error: Attempted to serialize scalar 'false' with incompatible type 'Int'
  prisma-client     at yw.graphQLToJSError (xxx/node_modules/@prisma/client/runtime/index.js:129:4637)
  prisma-client     at xxx/node_modules/@prisma/client/runtime/index.js:129:2977

Environment & setup

OS : Mac OS
Database: MySQL 8
Node.js version: 12.18.3
Prisma Version: starting from 2.8.0 to 2.9.0

Here is the output from prisma -v
@prisma/cli          : 2.9.0
@prisma/client       : Not found
Current platform     : darwin
Query Engine         : query-engine 369b3694b7edb869fad14827a33ad3f3f49bbc20 (at ../../.nvm/versions/node/v12.18.3/lib/node_modules/@prisma/cli/query-engine-darwin)
Migration Engine     : migration-engine-cli 369b3694b7edb869fad14827a33ad3f3f49bbc20 (at ../../.nvm/versions/node/v12.18.3/lib/node_modules/@prisma/cli/migration-engine-darwin)
Introspection Engine : introspection-core 369b3694b7edb869fad14827a33ad3f3f49bbc20 (at ../../.nvm/versions/node/v12.18.3/lib/node_modules/@prisma/cli/introspection-engine-darwin)
Format Binary        : prisma-fmt 369b3694b7edb869fad14827a33ad3f3f49bbc20 (at ../../.nvm/versions/node/v12.18.3/lib/node_modules/@prisma/cli/prisma-fmt-darwin)
Studio               : 0.296.0

Prisma client version installed in the project: 2.9.0

Summary
Prisma version: 2.9.0
Database type: MySLQ 8
Name of the table: myTable
Name of the field: dataName
Type of the field: tinyint unsigned
All the values in the field are either 0 or 1
Used to work with 2.7.1
Failing query:
prisma.myTable.findOne({
      where: {
        id: 666,
      },
    });

Error:
Attempted to serialize scalar 'false' with incompatible type 'Int'

Succeeding query:
prisma.myTable.findOne({
      where: {
        id: 666,
      },
      select: {
        id: true,
        dataName: false,
      }
    });

They are actively working on it and it should be fixed in 2.10.0 apparently: https://github.com/prisma/prisma-engines/issues/1257

Indeed this is a known problem and it is being worked on for native types support.
Still, thanks for opening the issue in the main repository for other people.

Hey @FredericEspiau, this issue appears to no longer be reproducible. I'm closing now, feel free to re-open/chime in again if you're still experiencing the problem.

Yes thank you!


Ustream issue...

Guys im a noob in this, im trying to get the m3u8 of this link http://www.ustream.tv/channel/20159472
in streamlink cmd show this
C:\Program Files (x86)\Streamlink\bin>streamlink "http://www.ustream.tv/channel/20159472" best
[cli][info] Found matching plugin ustreamtv for URL http://www.ustream.tv/channel/20159472
[plugin.ustreamtv][warning] python-librtmp is not installed, but is needed to access the desktop streams error: No playable streams found on this URL: http://www.ustream.tv/channel/20159472
i don't know how installe python-librtmp, can you help me please?
i was getting the m3u8 of the channel with this link
http://iphone-streaming.ustream.tv/uhls/20159472/streams/live/iphone/playlist.m3u8
but now show Access Forbidden

Please use https://github.com/streamlink/streamlink
@chrippa has abandoned the project and we're unable to contact him through GitHub / email / his work  or twitter


Edits to Child Listing Report

1.) The days before placement is not calculating accurately.  Should be the difference between the registration date and placement date, in days.
2.) Ideally the age of placement would include numeric value of months.  ex: child placed at 10 yr. 6 months old would be value 10.5.  Currently it computes as 10.00

captured in 485.


Update tests in Fhi.HelseId.Testsupport

This package adds tests that an application developer can add to their test projects.
It ensure that the config files are correct, and may check other aspects to make sure the package is properly added and configured.

@OsirisTerje Could you provide some suggestions on what needs to be updated?


Raidboss: Emanation (Lakshmi normal mode) timeline and triggers

I modified the trigger names in EX so as to avoid any possibility of collisions. I didn't think this was a problem since it's a necessary disambiguation, but I can revert those changes and submit them separately if necessary.
One of the patterns involving stack markers combined with other markers does technically give people enough time to stack, but it's probably best to keep them away so puddle people don't clip the stack. This is particularly important during Chanchala phases, since the puddles expand significantly.
There are a lot of abilities that have different IDs at different points in the timeline. This is because all her skills are empowered under Chanchala, and Square implements this by just using different skills.
This doesn't attempt to check for whether a non-tank has the cleave (the Path of Light,) so that we can warn them specifically to use Vril. It can be done, but the weekend is over and I won't have a lot of time to look at this until next weekend at the earliest.

Thanks for catching those. I think we're probably ready for this one to merge now. Oopsy will be forthcoming in 6 to 8 weeks.