[PE-D][Tester E] Adding of a task with weird description shows that it was successfully added but does not reflect in the task list

Your browser does not support the video tag.video:https://raw.githubusercontent.com/rionshocker/ped/main/files/35d22312-760a-43b3-9e72-8c7f7c7abef5.mov

Labels: type.FunctionalityBug severity.Medium
original: rionshocker/ped#11

This issue is a duplicate of #256. Closing.


refactor(follow): use follow button from palette

This PR resolves PHIRE-895
Description
Follow up of https://github.com/artsy/palette-mobile/pull/226

[x] deletes followbutton from eigen
[x] replaces followbutton with the one from palette-mobile
[x] bumps palette

Screenshots

Before
After

ArtistHeaderNavRight

ArtistListItem

GeneHeader

PartnerHeader

ArtistCard

ArtQuizResults

PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

use follow button from palette - gkartalis

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Cross-platform user-facing changes (use follow button from palette - gkartalis)

  Generated by :no_entry_sign: dangerJS against 3d7b838eb3837a4a3922ab4f7426b577c22f46cd


[Android] lib tests fail on CI with what:MEDIA_ERROR_UNKNOWN {what:1} extra:MEDIA_ERROR_SYSTEM

Checklist

[x] I read the troubleshooting guide before raising this issue
[x] I made sure that the issue I am raising doesn't already exist

Lib tests fail with what:MEDIA_ERROR_UNKNOWN {what:1} extra:MEDIA_ERROR_SYSTEM, but only on the CI. If testing locally with several machines and emulators, everything is working fine.
Current bug behaviour
Test play multiple sources simultaneously fails with Unexpected platform error: MediaPlayer error with what:MEDIA_ERROR_UNKNOWN {what:1} extra:MEDIA_ERROR_SYSTEM.
Expected behaviour
The tests should not fail.
Steps to reproduce
Execute lib tests play multiple sources simultaneously of #1333 in the Github CI

Code sample

import 'dart:io';

import 'package:audioplayers/audioplayers.dart';
import 'package:audioplayers_example/tabs/sources.dart';
import 'package:flutter/foundation.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:integration_test/integration_test.dart';

import 'platform_features.dart';
import 'source_test_data.dart';

void main() {
  final features = PlatformFeatures.instance();

  IntegrationTestWidgetsFlutterBinding.ensureInitialized();

  group('play multiple sources', () {
    final audioTestDataList = [
      if (features.hasUrlSource)
        LibSourceTestData(
          source: UrlSource(wavUrl1),
          duration: const Duration(milliseconds: 451),
        ),
      if (features.hasUrlSource)
        LibSourceTestData(
          source: UrlSource(wavUrl2),
          duration: const Duration(seconds: 1, milliseconds: 068),
        ),
      if (features.hasUrlSource)
        LibSourceTestData(
          source: UrlSource(mp3Url1),
          duration: const Duration(minutes: 3, seconds: 30, milliseconds: 77),
        ),
      if (features.hasUrlSource)
        LibSourceTestData(
          source: UrlSource(mp3Url2),
          duration: const Duration(minutes: 1, seconds: 34, milliseconds: 119),
        ),
      if (features.hasUrlSource && features.hasPlaylistSourceType)
        LibSourceTestData(
          source: UrlSource(m3u8StreamUrl),
          duration: Duration.zero,
          isLiveStream: true,
        ),
      if (features.hasUrlSource)
        LibSourceTestData(
          source: UrlSource(mpgaStreamUrl),
          duration: Duration.zero,
          isLiveStream: true,
        ),
      if (features.hasAssetSource)
        LibSourceTestData(
          source: AssetSource(asset1),
          duration: const Duration(seconds: 1, milliseconds: 068),
        ),
      if (features.hasAssetSource)
        LibSourceTestData(
          source: AssetSource(asset2),
          duration: const Duration(minutes: 1, seconds: 34, milliseconds: 119),
        ),
    ];

    testWidgets(
      'play multiple sources simultaneously',
      (WidgetTester tester) async {
        final players =
            List.generate(audioTestDataList.length, (_) => AudioPlayer());

        // Start all players simultaneously
        final iterator = List<int>.generate(audioTestDataList.length, (i) => i);
        await Future.wait<void>(
          iterator.map((i) => players[i].play(audioTestDataList[i].source)),
        );
        await tester.pumpAndSettle();
        // Sources take some time to get initialized
        await tester.pump(const Duration(seconds: 8));
        for (var i = 0; i < audioTestDataList.length; i++) {
          final td = audioTestDataList[i];
          if (td.isLiveStream || td.duration > const Duration(seconds: 10)) {
            await tester.pump();
            final position = await players[i].getCurrentPosition();
            printOnFailure('Test position: $td');
            expect(position, greaterThan(Duration.zero));
          }
          await players[i].stop();
        }
      },
    );
  });
}

Logs
https://github.com/bluefireteam/audioplayers/actions/runs/3750597674/jobs/6370516969#step:11:182
Audio Files/URLs/Sources

Different sources of example

Screenshots

Environment information

audioplayers version: 1.1.1 / current master

Platform 1: android

OS name and version: Android API 30
Device: Emulator

build mode: debug

error peculiarities (optional):

Platforms tested without any issue (optional):

test peculiarities:

More information

I got the same error when I played the sound rapidly and simultaneously about 100ms delay with a 300ms duration sound, I use AudioPool from flame_audio btw
https://user-images.githubusercontent.com/31397565/228910533-3d35f578-a2fc-4833-a8cf-6269a0becff0.mp4
Minimal reproducible code
import 'package:flame_audio/audio_pool.dart';
import 'package:flame_audio/flame_audio.dart';
import 'package:gunslinger/utils/extensions.dart';

 import '../r.dart';

 class AudioController {
   late AudioPool _bulletShot;

   AudioController() {
     _loadShootSfxAudio();
   }

   void _loadShootSfxAudio() async {
     _bulletShot = await FlameAudio.createPool(
       AssetAudio.bulletShot.fileName,
       minPlayers: 3,
       maxPlayers: 4,
     );
   }

   Future<void> playBulletShotSfx() {
     return _bulletShot.start(
       volume: 0.8,
     );
   }
 }

And this is the crash log I got from my android phone crash log dialog
E/AndroidRuntime(21426): FATAL EXCEPTION: main
E/AndroidRuntime(21426): Process: com.example.gunslinger, PID: 21426
E/AndroidRuntime(21426): java.lang.IllegalStateException
E/AndroidRuntime(21426):        at android.media.MediaPlayer._prepare(Native Method)
E/AndroidRuntime(21426):        at android.media.MediaPlayer.prepare(MediaPlayer.java:1315)
E/AndroidRuntime(21426):        at z0.i.j(Unknown Source:2)
E/AndroidRuntime(21426):        at z0.o.J(Unknown Source:52)
E/AndroidRuntime(21426):        at z0.o.v(Unknown Source:6)
E/AndroidRuntime(21426):        at z0.i.x(Unknown Source:5)
E/AndroidRuntime(21426):        at z0.i.r(Unknown Source:0)
E/AndroidRuntime(21426):        at z0.e.onCompletion(Unknown Source:2)
E/AndroidRuntime(21426):        at android.media.MediaPlayer$EventHandler.handleMessage(MediaPlayer.java:3556)
E/AndroidRuntime(21426):        at android.os.Handler.dispatchMessage(Handler.java:106)
E/AndroidRuntime(21426):        at android.os.Looper.loopOnce(Looper.java:210)
E/AndroidRuntime(21426):        at android.os.Looper.loop(Looper.java:299)
E/AndroidRuntime(21426):        at android.app.ActivityThread.main(ActivityThread.java:8116)
E/AndroidRuntime(21426):        at java.lang.reflect.Method.invoke(Native Method)
E/AndroidRuntime(21426):        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:559)
E/AndroidRuntime(21426):        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:950)
I/flutter (21426): Unexpected platform error: MediaPlayer error with what:MEDIA_ERROR_UNKNOWN {what:1} extra:MEDIA_ERROR_UNKNOWN {extra:-19}

What I already tried :

Use different audio format such as like .mp3 .ogg .wav
Trim the duration of the audio
Compress the file size of the audio file (in case if it is a memory problem)
Add more player to AudioPool around 24 and more

@yasfdany Are you sure this isn't fixed with #1425
This fix isn't released yet, but can be tried with this in pubspec file: https://github.com/bluefireteam/audioplayers/pull/1425#issuecomment-1433639294
Note the difference in the extra code: extra:MEDIA_ERROR_UNKNOWN {extra:-19} vs extra:MEDIA_ERROR_SYSTEM . Probably you use an audio file which is not supported by android, despite its file extension.

@Gustl22 i tried the above solution and change format of audio to m4a, and the crash still happen, but the difference is the audio more stable not slow down when there're so many object on the sceeen.

I too am receiving this issue and the latest fixes in #1425 haven't helped.
Now, I'm no expert on Kotlin or this library, however:
I have been doing some digging and can see the  _createNewAudioPlayer() in audioplayers/lib/src/audio_pool.dart does not specify playerMode.lowLatency which defaults the AudioPool to a standard MediaPlayerPlayer rather than a SoundPoolPlayer which would be more suited to a rapid fire sfx succession.
Adding the following to _createNewAudioPlayer() seems to solve the issue for me:
await player.setPlayerMode(PlayerMode.lowLatency);

@cameronbatty yes, that would be a good addition, to be also able to set the playerMode in the AudioPool. Wanna make a PR?


Option to enable/disable the plugin in settings

To turn off this plugin, each & every I have to remove it from my app.yml and rebuild.
Please add a plugin setting to enable/disable the whole plugin.

Thanks @GokulNC!  Yeah, any improvements to the development experience would be super welcome.  This isn't something I know about or will be working on myself, but if you put something together and wrote it out I could take a look, or other interested folks might be able to help as well.


The WithVolumeMount extension method doesn't work with Azurite

If you want to persist your Azurite table/queue/blob data between app restarts you need to mount a volume from the host (see the docs on how to do that).
With other container options you can use the extension method WithVolumeMount, like so:
IResourceBuilder<PostgresContainerResource> postgresContainerDefinition = builder
    .AddPostgresContainer("db")
    .WithEnvironment("POSTGRES_DB", "my_data")
    // Mount the database scripts into the container that will configure pgvector
    .WithVolumeMount("./database", "/docker-entrypoint-initdb.d", VolumeMountType.Bind);

But the extension method doesn't work for Azurite because it's signature is:
public static IResourceBuilder<T> WithVolumeMount<T>(this IResourceBuilder<T> builder, string source, string target, VolumeMountType type = default, bool isReadOnly = false) where T : ContainerResource

And AzureStorageResource, which is the type when working with Azure Storage, isn't ContainerResource.
To solve this the UseEmulator method should return a type that can support WithVolumeMount while not accidentally supporting it if you're deploying to Azure Storage without the emulator.
Workaround
The workaround is to write out the full WithAnnontation call, like so:
storage.UseEmulator()
.WithAnnotation(new VolumeMountAnnotation("./data/azurite", "/data", VolumeMountType.Bind));

I think the way to handle this is to give access to customize the container based resources in a callback:
storage.UseEmulator(container => container.WithVolumeMount(...))

Providing a callback to configure emulator-specific options would be a good idea.

@aaronpowell would you like to send a PR?

Should be able to get a PR up for review

PR #1631 opened for it. I ended up providing a new argument to the UseEmulator that takes the path for the emulator data rather than a callback function to configure it because the callback wouldn't have added any additional functionality to address the problem.
Since AzureStorageResource doesn't inherit ContainerResource, which WithVolumeMount is tied to, we'd still need to introduce a new type like AzureStorageEmulatorResource to have an extension method made available via. This seemed overly complex for the solution required when an argument would address the needs just as well.


Ldc fix

Modifies the LDC so that the closest model from a grid is selected with a simple function instead of interpolating a heavy precomputed grid.

Hey @hover2pi I just took a look at the files you updated. It looks like you are adding code that uses the older version of the jwst_gtvt (get_table). I am thinking, and let me know what you think, that if we can get #574 we can update this PR with calls to the updated version of the GTVT that way we won't have to go back and update it later!

Hey @hover2pi I see some movement here. Let me know when you are ready for a review!

Hello @hover2pi, Thank you for updating !

In the file exoctk/contam_visibility/contamination_figure.py:

Line 209:9: E265 block comment should start with '# '
Line 275:5: E265 block comment should start with '# '
Line 297:93: E226 missing whitespace around arithmetic operator

In the file exoctk/contam_visibility/field_simulator.py:

Line 40:46: E261 at least two spaces before inline comment
Line 43:1: E402 module level import not at top of file
Line 45:162: E231 missing whitespace after ':'
Line 46:164: E231 missing whitespace after ':'
Line 47:165: E231 missing whitespace after ':'
Line 57:1: E302 expected 2 blank lines, found 1
Line 129:32: E226 missing whitespace around arithmetic operator
Line 176:94: E231 missing whitespace after ','
Line 419:51: E261 at least two spaces before inline comment
Line 462:64: E261 at least two spaces before inline comment
Line 463:64: E261 at least two spaces before inline comment
Line 464:64: E261 at least two spaces before inline comment
Line 554:161: E241 multiple spaces after ','
Line 733:16: E261 at least two spaces before inline comment
Line 743:59: E226 missing whitespace around arithmetic operator
Line 1021:9: E303 too many blank lines (2)
Line 1083:18: E261 at least two spaces before inline comment
Line 1083:18: E262 inline comment should start with '# '

In the file exoctk/contam_visibility/new_vis_plot.py:

Line 20:59: E225 missing whitespace around operator
Line 46:5: E122 continuation line missing indentation or outdented
Line 47:5: E122 continuation line missing indentation or outdented
Line 48:5: E122 continuation line missing indentation or outdented
Line 49:5: E122 continuation line missing indentation or outdented
Line 49:61: E231 missing whitespace after ','
Line 63:121: W291 trailing whitespace
Line 67:47: E226 missing whitespace around arithmetic operator
Line 71:13: W292 no newline at end of file

In the file exoctk/contam_visibility/visibilityPA.py:

Line 143:26: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 401:28: E261 at least two spaces before inline comment
Line 401:29: E262 inline comment should start with '# '
Line 433:41: W292 no newline at end of file

In the file exoctk/exoctk_app/app_exoctk.py:

Line 20:1: E265 block comment should start with '# '
Line 406:1: W293 blank line contains whitespace
Line 776:21: W605 invalid escape sequence '('
Line 776:25: W605 invalid escape sequence ')'
Line 776:57: W605 invalid escape sequence '\c'
Line 776:74: W605 invalid escape sequence '\e'
Line 782:46: W605 invalid escape sequence '('
Line 782:48: W605 invalid escape sequence '\l'
Line 782:56: W605 invalid escape sequence '\m'
Line 782:66: W605 invalid escape sequence '\h'
Line 782:79: W605 invalid escape sequence '\m'
Line 782:85: W605 invalid escape sequence ')'
Line 783:46: W605 invalid escape sequence '('
Line 783:48: W605 invalid escape sequence '\l'
Line 783:56: W605 invalid escape sequence '\m'
Line 783:66: W605 invalid escape sequence '\h'
Line 783:79: W605 invalid escape sequence '\m'
Line 783:85: W605 invalid escape sequence ')'
Line 784:46: W605 invalid escape sequence '('
Line 784:48: W605 invalid escape sequence '\l'
Line 784:56: W605 invalid escape sequence '\m'
Line 784:66: W605 invalid escape sequence '\h'
Line 784:79: W605 invalid escape sequence '\m'
Line 784:85: W605 invalid escape sequence ')'
Line 790:58: W605 invalid escape sequence '('
Line 790:62: W605 invalid escape sequence '\m'
Line 790:69: W605 invalid escape sequence '\m'
Line 790:75: W605 invalid escape sequence ')'
Line 815:25: W605 invalid escape sequence '('
Line 815:29: W605 invalid escape sequence ')'
Line 815:61: W605 invalid escape sequence '\c'
Line 815:78: W605 invalid escape sequence '\e'
Line 821:50: W605 invalid escape sequence '('
Line 821:52: W605 invalid escape sequence '\l'
Line 821:60: W605 invalid escape sequence '\m'
Line 821:70: W605 invalid escape sequence '\h'
Line 821:83: W605 invalid escape sequence '\m'
Line 821:89: W605 invalid escape sequence ')'
Line 822:50: W605 invalid escape sequence '('
Line 822:52: W605 invalid escape sequence '\l'
Line 822:60: W605 invalid escape sequence '\m'
Line 822:70: W605 invalid escape sequence '\h'
Line 822:83: W605 invalid escape sequence '\m'
Line 822:89: W605 invalid escape sequence ')'
Line 823:50: W605 invalid escape sequence '('
Line 823:52: W605 invalid escape sequence '\l'
Line 823:60: W605 invalid escape sequence '\m'
Line 823:70: W605 invalid escape sequence '\h'
Line 823:83: W605 invalid escape sequence '\m'
Line 823:89: W605 invalid escape sequence ')'
Line 829:62: W605 invalid escape sequence '('
Line 829:66: W605 invalid escape sequence '\m'
Line 829:73: W605 invalid escape sequence '\m'
Line 829:79: W605 invalid escape sequence ')'

In the file exoctk/forward_models/forward_models.py:

Line 74:5: E722 do not use bare 'except'

In the file exoctk/limb_darkening/limb_darkening_fit.py:

Line 104:46: W605 invalid escape sequence '\m'
Line 504:30: W605 invalid escape sequence '\m'
Line 505:32: W605 invalid escape sequence '\m'
Line 505:39: W605 invalid escape sequence '\m'
Line 549:31: E222 multiple spaces after operator

In the file exoctk/modelgrid.py:

Line 74:43: E226 missing whitespace around arithmetic operator
Line 83:52: E226 missing whitespace around arithmetic operator
Line 83:68: E226 missing whitespace around arithmetic operator
Line 104:23: E226 missing whitespace around arithmetic operator
Line 105:46: E221 multiple spaces before operator
Line 117:38: E261 at least two spaces before inline comment
Line 370:57: W504 line break after binary operator
Line 371:57: W504 line break after binary operator
Line 372:57: W504 line break after binary operator
Line 373:57: W504 line break after binary operator
Line 374:55: W504 line break after binary operator
Line 394:63: W504 line break after binary operator
Line 396:63: W504 line break after binary operator
Line 398:61: W504 line break after binary operator
Line 484:54: W504 line break after binary operator
Line 485:54: W504 line break after binary operator
Line 486:54: W504 line break after binary operator
Line 487:54: W504 line break after binary operator
Line 488:52: W504 line break after binary operator
Line 494:61: W504 line break after binary operator
Line 495:61: W504 line break after binary operator
Line 502:61: W504 line break after binary operator
Line 503:61: W504 line break after binary operator

In the file exoctk/tests/test_contam_visibility.py:

Line 39:42: E261 at least two spaces before inline comment


Rendering of guideposts

ref aren't rendered, only name and ele.
According to zoom levels and tags, ref — name, name or ref could be rendered (± ele below) ?
 Will update.

ref is rendered after name in parenthesis.


OnBlur not firing causing double tap for actionSheets

###Environment

React-Native 0.59
Redux-Form 8.3.2

Steps to reproduce
Redux Action Timeline

tap input field - redux-form/FOCUS(on the input field)
tap actionSheet field - no action registered
tap option on the presented actionSheet - redux-form/BLUR(on the previous input field)
tap option again - redux-form/FOCUS(on actionSheet field) followed by redux-form/CHANGE and a redux-form/FOCUS back on the input field it came from

Expected behaviour
I should be able to select an option on the actionSheet on the first tap
Actual behaviour
I must tap twice, once to blur the previous input field, and then once to actually select something
Other information
When I focus on an input field, and then focus on a actionSheet field the action sheet appears but the redux-form/BLUR event for the input field hasn't fired yet. When I press an option it is not selected by then the blur event happens for the input field it was previously on. Since it has been blurred, I'm able to press the action sheet again and have my option be selected.
I have attempted to manually blur the previous input field and focused on the actionSheet field. The action timeline adds those in IE a blur is called on the input field and a focus on the actionSheet but that doesn't change the form behavior AND a blur still occurs on the input field after the first tap on the actionSheet options.
If there is any action that is taken between focusing on the input field and the actionSheet(like pressing return on the keyboard or tapping in a random location on the screen) the onBlur works as it should and so does the interaction with the actionSheet

Please provide a https://codesandbox.com example!

I am seeing similar behavior on our desktop web app, where a Field with the autoFocus property (a search text field in a nav bar) was causing any initial click in the content pane to be handled as a blur event (so links required clicking twice). When I add an onBlur={event => event.preventDefault()} property on the field, the blur event does not clobber other DOM events.


get all tiles that are in viewspace

i need to get all tiles that are in viewspace.  Where can i safe them to an array, if there not already safed somewhere?
thanks in advance:
leo

You can get all the visible tiles by traversing the map object.
Check the method https://threejs.org/docs/#api/en/core/Object3D.traverse
All visible children objects will be the visible tiles. Something like this:
let tiles = [];
map.traverse((obj) => {
	if (obj.visible) {
		tiles.push(obj);
	}
});


Add clarity to the EDM fonts

To support EDM on RHEL8, we needed to update the font RPMs so that they could be correctly installed via satellite. These are now with SciComp.
With these deployed, there should be significantly less people looking to install the fonts on their machine. However, in the event that they still need them, the installation here will work locally.
Because of this, I have made the following changes:

Updated the README to explain the current state of the fonts
Added spec files generated by rpmrebuild for the three original fonts (which were modified to create the new RPMs SciComp has). Hopefully this will provide clarity of their behavior in future.

What's wrong with them:
The symlink is created in the %post scriptlet and uninstalled in the %postun step. When reinstalling or upgrading a package the %post of the new package is run before %postun of the old package. In short, when reinstalling the package the symlinks were being created then immediately removed.

Looks good. Thanks!


Using functions returns Bad Gateway

Hi!
I wanted to test functions in ChatCompletions but the requests takes long time and then returns Bad Gateway. Running exampleTwo as it is gives me the same behaviour.
However it works fine if I remove the functions from my ChatCompletionRequest.
Can someone else test example two to check if there is any restriction to my API token?

Hi! any news for this?


Wrong name case in query

Is that expected behavior?
Describe the bug
The query that is constructed from my code does not have the right case for the name. They are always lower case.
Expected behavior
The constructed query uses the real type not the lower case one.
var response = await client
.Query(static c => c.QueryClient(null, null, null, null, c => new { c.Name , cars = c.Cars(null, null, null, c => c.Brand) }));

Schema
type Client {
  id: ID!
  name: String! // for testing if making it lowercase in the schema work
  Cars(filter: CarFilter first: Int offset: Int): [Car!]
  CarsAggregate(filter: CarFilter): CarAggregateResult
}

type Car {
  id: ID!
  Brand: CarBrand!
  Owners(filter: ClientFilter order: ClientOrder first: Int offset: Int): [Client!]
  OwnersAggregate(filter: ClientFilter): ClientAggregateResult
}

query { queryClient(filter: null, order: null, first: null, offset: null) { name cars(filter: null, first: null, offset: null) { brand }  } }
Error: Cannot query field "cars" on type "Client". Did you mean "Cars"?

Environment (please complete the following information):

Nuget version [3.5.0]
IDE: [VS]
.Net Version [7.0.103]

Additional context
I'm using Dgraph cloud as my GraphQL provider.

It is a bug. During the generation, it converts everything to a lowercase. I will have a look.

@TheJemy191 checkout v3.5.1-preview.1 the issue should be fixed.


Input fields for style attributes with value "0" are blank

Example: tts:origin has the vaule `0% 100%" the following is shown:

Dynamic positioning for regions is also not working if values for extent or region are 0.


Remove ␤ characters from example outputs

I noticed that a few of our example CLI outputs had ␤ characters at the
end of each line. I think this is a just display artifact from an older
version of the Cockroach CLI, so I removed them.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e4460dc2ec393d3299a237f0bc5883b123141a0e/
Edited pages:

v1.0/add-constraint.md
v1.0/column-families.md
v1.0/create-table-as.md
v1.0/create-table.md
v1.0/show-create-table.md
v1.1/add-constraint.md
v1.1/column-families.md
v1.1/create-table-as.md
v1.1/create-table.md
v1.1/show-create-table.md
v1.1/show-trace.md
v19.1/column-families.md
v19.1/create-table-as.md
v19.1/show-trace.md
v19.2/column-families.md
v19.2/show-trace.md
v2.0/add-constraint.md
v2.0/column-families.md
v2.0/create-table-as.md
v2.0/create-table.md
v2.0/show-create-table.md
v2.0/show-trace.md
v2.1/add-constraint.md
v2.1/column-families.md
v2.1/create-table-as.md
v2.1/show-trace.md


SimpleDateFormat - Unparseable date when parsing time

So, let have the following code:
DateFormat sdf = new SimpleDateFormat("HH:mm:ss");

Now we are using this formatter
String timeString = "00:00:23";
sdf.setTimeZone(TimeZone.getTimeZone("UTC"));
Date d = sdf.parse(timeString);

In the Objective-C translated code an "Unparseable date" exception is thrown, at char number 0.
Probably a date without the time part is parsed properly, only the time part is not.
Any ideas?

The problem turned out to be in NativeDecimalFormat parsing, which returned an incorrect parse position when zeroes were followed by a non-numeric character, such as the third character of your "00:00:23" time string. Fix is pending review.

Fixed in current source.


Card: Fallen Star, Land Purchase, Fannin' the Hammer

Please also test some of the changed cards:

Fannin' the Hammer
Run 'Em Down
Mugging
Hydro-puncher
one of the techniques

Land Purchase: After the job succeeds, Land purchase does not end up in the discard pile. It vanishes from the game.

fallen star lets you chose an already booted dude as replacement target. that should not be the case, you cannot boot a dude that's already booted

This is one thing I was not so sure about. According to rules (or at least new rules regarding the requirements), only required targets are those that are formulated as: Boot X to do Y, or Choose X to do Y and so on.
I guess I will have to check with the rules guys.

After the job succeeds, Land purchase does not end up in the discard pile. It vanishes from the game. Otherwise, this card works fine

Haha, did not notice at all it disappeared 😄

Answer is that Fallen Star redirects are required to boot since older cards still has the first sentence requirement. Another thing is that Land Purchase should not be able to choose itself from the discard pile 😄 Fixes pushed.

The combo problem was fixed on the master, but the fallen star branch was not updated so that is why it does not work. I have updated the branch so it should be also fixed here. It was a different problem.


make configbinder resolve placeholder in  propertySources for #300

#300

It has been resolved in Dubbo, thus it will be updated, thanks for your contribution, please check Dubbo 2.6.5 .


Bug with returning True from while

reported by @hal0x2328
The following code is wonky when compiled
from boa.blockchain.vm.Neo.Runtime import GetTrigger
from boa.blockchain.vm.Neo.TriggerType import Application,Verification

def Main(bytes):

    trigger = GetTrigger()

    if trigger == Verification():
        print("Verification!")
        return False

    elif trigger == Application():
        print("Application!")
        i = 0
        l = len(bytes)
        while i < l:
            c = substr(bytes,i,1)
            i = i + 1
            if c == 0:
                print("Null")
            else:
                print("Not null")
                return True

I believe this now works on the development branch with the following command:
build ../neo-boa/boa/tests/src/bugs/Hal9000WhileBug.py test 05 01 False bytearray(b'\x00\x00\x01\x02\x00')
Outputs the following:
LOADING AND SAVING! ../neo-boa/boa/tests/src/bugs/Hal9000WhileBug.py
Saved output to ../neo-boa/boa/tests/src/bugs/Hal9000WhileBug.avm
[I 171209 19:56:11 EventHub:98] [test_mode][SmartContract.Runtime.Log] [a6a57d36ec7c56d62077ba755400e3ec259afac3] b'Application!'
[I 171209 19:56:11 EventHub:98] [test_mode][SmartContract.Runtime.Log] [a6a57d36ec7c56d62077ba755400e3ec259afac3] b'Null'
[I 171209 19:56:11 EventHub:98] [test_mode][SmartContract.Runtime.Log] [a6a57d36ec7c56d62077ba755400e3ec259afac3] b'Null'
[I 171209 19:56:11 EventHub:98] [test_mode][SmartContract.Runtime.Log] [a6a57d36ec7c56d62077ba755400e3ec259afac3] b'Not null'
[I 171209 19:56:11 EventHub:98] [test_mode][SmartContract.Execution.Success] [a6a57d36ec7c56d62077ba755400e3ec259afac3] [1]

-----------------------------------------------------------
Calling ../neo-boa/boa/tests/src/bugs/Hal9000WhileBug.py with arguments ["bytearray(b'\\x00\\x00\\x01\\x02\\x00')"]
Test deploy invoke successful
Used total of 265 operations
Result True
Invoke TX gas cost: 0.001
-------------------------------------------------------------

@hal0x2328 is that the output you would expect? Or am I missing something

note, the test referenced above is in fe08686921e7a86c63463b5722bc20916c1940fb

Yes, it seems to be fixed, I even tried another variation that was failing before even when not returning True from inside the while loop, and it works now.

👍


how to set up this on loaclhost for testing?

Can you please tell how to set this thing on localhost.

Have node.js installed, mongodb installed and running, and nothing blocking ports 25 or 587.
git clone https://github.com/ruffrey/mailsac
cd mailsac
npm install
npm start

sudo may be required to bind to ports 25 and 587.


Story visualization slots

Proposed changes:

fixes https://github.com/RasaHQ/rasa/issues/4132 (broken story visualization in Rasa X when stories had slots
add more tests to io module
add constant for default encoding (utf-8)
add function write_text_file to io module
move dump_obj_as_json_to_file to io module

Status (please check what you already did):

[x] made PR ready for code review
[x] added some tests for the functionality
[ ] updated the documentation
[x] updated the changelog
[x] reformat files using black (please check Readme for instructions)

Just as a note: as quite a lot files changed, maybe consider to open a new PR for the additional stuff (e.g. moving stuff to io utils) to keep the PR small and clean. Also, the review can focus more on the actual change if you do so

Sorry, you're totally right! Will split it up the next time. 👍


HDDS-9341. om-roles.robot is not part of any test runs

What changes were proposed in this pull request?
The om-roles.robot test added in HDDS-9305 is not executed in any of the acceptance test. Aim is to add it in ozone-ha and ozonesecure-ha environments.
What is the link to the Apache JIRA
HDDS-9341
How was this patch tested?
Acceptance test CI, passing in local fork.
ha-secure: https://github.com/LZD-PratyushBhatt/ozone/actions/runs/6277586606/job/17050342303
Om-Roles :: Smoke test for listing om roles.
==============================================================================
List om roles with OM service ID passed                               | PASS |
------------------------------------------------------------------------------
List om roles without OM service ID passed                            | PASS |
------------------------------------------------------------------------------
List om roles as JSON with OM service ID passed                       | PASS |
------------------------------------------------------------------------------
List om roles as JSON without OM service ID passed                    | PASS |
------------------------------------------------------------------------------
Om-Roles :: Smoke test for listing om roles.                          | PASS |
4 tests, 4 passed, 0 failed

ha-unsecure: https://github.com/LZD-PratyushBhatt/ozone/actions/runs/6277586606/job/17050342650
Om-Roles :: Smoke test for listing om roles.
==============================================================================
List om roles with OM service ID passed                               | PASS |
------------------------------------------------------------------------------
List om roles without OM service ID passed                            | PASS |
------------------------------------------------------------------------------
List om roles as JSON with OM service ID passed                       | PASS |
------------------------------------------------------------------------------
List om roles as JSON without OM service ID passed                    | PASS |
------------------------------------------------------------------------------
Om-Roles :: Smoke test for listing om roles.                          | PASS |
4 tests, 4 passed, 0 failed
==============================================================================
Output:  /tmp/smoketest/ozone-ha/result/robot-7.xml

Hi @adoroszlai , can you please review this? Thanks!


Match mature content tags with lbry-redux

https://github.com/lbryio/lbry-redux/blob/master/src/constants/tags.js#L16

This was on the CQ / search side.


Consistency of package names

Some of the package names are presented differently across the code, e.g.,

PyTorch – Pytorch – pytorch – pyTorch
Torch Script – TorchScript

It would be better to make these consistent.

Please do tackle if you wish.
I suggest consolidating on PyTorch and TorchScript as per the Torch docs.


feat/sac and clubs info page

Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.

[x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your default branch!
[x] Make sure you are making a pull request against the default branch (left side). Also you should start your branch off default branch.
[x] Check the commit's or even all commits' message styles matches our requested structure.
[x] Check your code additions will fail neither code linting checks nor unit test.
[x] I have added necessary documentation (if appropriate)

Linked Issues
Fixes #271
Description

please describe your pull request.
❤Thank you!
Post merge checklist

[x] Follow steps from the guidelines for contributing to this repository.
[x] If you are a new contributor, ping in the thread and one of the maintainers will add you to all-contributors list.

@Anish-Sarawgi please change title of the PR and rebase with the main branch.

@anish-patro please resolve all conversations, if required changes are done.

@120EE0692 @anish-patro what is up with this?

@120EE0692 @anish-patro what is up with this?

@rutajdash mostly done, only few club content is left. After that good to go.


Add time taken for request to the http server logs

This will add a field to the end of the http log for time that it took to execute the request.  This is helpful for debugging.
[http] 2015/03/16 12:40:58 <IP_ADDRESS> - - [16/Mar/2015:12:40:58 -0600] GET /query?db=foo&q=show+databases HTTP/1.1 200 62 - InfluxDBShell/0.9 fcc9cc32-cc0b-11e4-919b-60f81dab26ba 1.864595ms

@corylanou rad! this is a nice one.

@corylanou -- is this about showing the user how long the operation took? If so I think it would be better if it came back in the response body. That way we can include lots of useful information for the user like how long it took to process the query, the number of shards hit, etc etc.

@otoolep I would look at that as a separate feature request to this one.

:+1:


Add Gitter rooms and badge.

Add a gitter rooms -

[ ] https://gitter.im/scikit-optimize/user (public room)
[ ] https://gitter.im/scikit-optimize/dev (invite only, private room)
[ ] A gitter badge to the user channel on README.md ;)

Do we need a private room?
And because I am feeling old: do we need a chat? Not sure what I think, just wanted to throw this out there because it seems number of comms channels always increase, a bit like the universe's entropy :)

+0 for gitter.
-1 for a private chat room

Not sure, I've hardly used these.


fix: change var.gcf_location to region

Fix b/288898474

LGTM, can you lint and follow conventionalcommits?

LGTM, can you lint and follow conventionalcommits?

done


Technically {**/}*.rb is more correct/flexible.

Require models within the models directory, and any sub-directories.

Could you please point at documentation where this difference is explained or illustrated? I can't find any mention about {} in this context in path pattern (Dir.glob, File.fnmatch)

https://www.thoughtco.com/using-glob-with-directories-2907832

– Match zero or more characters. A glob consisting of only the asterisk and no other characters or wildcards will match all files in the current directory. The asterisk is usually combined with a file extension if not more characters to narrow down the search.
** – Match all directories recursively. This is used to descend into the directory tree and find all files in sub-directories of the current directory, rather than just files in the current directory. This wildcard is explored in the example code below.
? – Match any one character. This is useful for finding files whose name are in a particular format. For example, 5 characters and a .xml extension could be expressed as ?????.xml.
[a-z] – Match any character in the character set. The set can be either a list of characters or a range separated with the hyphen character. Character sets follow the same syntax as and behave in the same manner as character sets in regular expressions.
{a,b} – Match pattern a or b. Though this looks like a regular expression quantifier, it isn't. For example, in regular expression, the pattern a{1,2} will match 1 or 2 'a' characters. In globbing, it will match the string a1 or a2. Other patterns can be nested inside of this construct.

So if you wanted to search in . and all sub-directories, you'd use {.,**/}*.rb, which can then be further simplified to {**/}*.rb.

Er wait, I made a mistake. It should be {,**/}*.rb...


Dash app for morphometrics analysis

Pre-planning stage

[x] Attend live Plotly session on the topic

https://go.plotly.com/dash-image-processing/
Registration required.

[ ] Explore examples of similar features already available on the web

https://eoss-image-processing.github.io/2020/11/10/region-properties-exploration.html

[ ] Follow tutorials to get an idea of how to properly plan app.

https://www.youtube.com/playlist?list=PLCDERj-IUIFCaELQ2i7AwgD2M6Xvc4Slf
Documentation page https://dash.plotly.com/

Planning stage

[ ] Draw a rough design of the app
[ ] Draw logic for expected callbacks of the apps
...

Implementation stage
...

2020-11-18 Plotly Webinar notes

New feature/doc: http://dash.plotly.com/annotations
JupyterDash package
Demo apps: https://github.com/plotly/dash-sample-apps

Stale


Add resource group based LTR APIs + tests to azure sdk

Let's aim to publish this and https://github.com/Azure/azure-sdk-for-net/pull/6934 together

Done


Migrate flag enablePropIteratorSetter to new system (re-land)

Summary:
Changelog: [internal]
This feature flag is accessed through CoreFeatures but it's initialized a few different ways:

Android: assigned via ReactFeatureFlags, which is overridden by apps.
iOS: ReactNativeConfig that's mapped to a dynamic configuration.

This migrates the flag to the new feature flag system.
Differential Revision: D53755840

ced499424740b9f06956e6312ae8a95f53ab2989


package should be named "avs", not "vmware"

The package should be named "avs", not "vmware". #10454 was merged before I had a chance to review. Please rename the package. See also https://github.com/Azure/sdk-release-request/issues/496.
Current location:
https://github.com/Azure/azure-sdk-for-go/tree/master/services/preview/vmware/mgmt/2019-08-09-preview/vmware
Should be:
https://github.com/Azure/azure-sdk-for-go/tree/master/services/preview/avs/mgmt/2019-08-09-preview/avs

Hi @ctaggart sorry for that... I will change it, release it and remove the wrong-named package in the next major version release (at the end of this month)

Should be resolved in v44.0.0

thank you @ArcturusZhang ! ❤


Rename core.Item → core.Field

Also renamed Container.attributes → Container.fields

superseded by #453


Feature Request: display image attachments larger

Hello!
I recieve thousands of security camera emails from several systems, and it is a great help to me to be able to go through those queues on my android device. Tricky thing is, the way that image attachments are displayed only shows a tiiiiiiiny thumbnail.
I'd like to submit a feature request where the image can be displayed in 'large mode', where perhaps it scales to the width of the display, or maybe have a "large thumbnail" option made available.
been using k9 for years, bought the paid version, I love it!

Duplicate of #2009


Generalise to N threads in the parallel property

Currently only two parallel workers are used in the parallel property, some bugs might require more things to happen in parallel...

One idea I have for this is to replace Fork with the following:
data Fork t a = Fork {
  prefix :: a
  suffix :: t a
}

Where we would often require t to be Traversable. To get back the current behaviour we would use:
data Pair a = Pair a a

instance Traversable Pair where
  traverse f (Pair x y) = Pair <$> f x <*> f y

type OldFork a = Fork Pair a

In general we could have Fork (Vec N) to have N threads.

I noticed that Erlang uses a list of suffices, i.e. ParallelProg = { prefix: Prog, suffixes : [Prog] }...

I remember John Hughes quoting a paper that shows that empirically most concurrency bugs can be triggered with two threads.
It can become more important to have more threads when doing fault injection though. For example, Jepsen uses 5 threads.

@stevana, as another generalisation, I think the type  of these threads could be extended. For example forking unbound vs bound threads could make a difference at the result, when testing some frameworks. It would be nice if the user had this option.
Thoughts?

Nice idea!
(Having a user-land scheduler that we could deterministically control would be great, but that's much more work.)

I've found the quote again:

"Almost all (96%) of the examined concurrency
bugs are guaranteed to manifest if certain partial order between 2
threads is enforced."

From the end of the "Parallelism in test cases" section in the paper "Finding Race Conditions in Erlang with QuickCheck and PULSE" which is linked to from the README. This section also talks about performance issues with multiple threads.


[FMS-9] Implement storage strategy - FILE_PER_YEAR_MONTH_DATE

Storage strategy - FILE_PER_YEAR_MONTH_DATE (no storage into database)
File storage based on the following rule: ${file.db.location} / ${tenant} / ${year}/ ${month}/ ${date} /${file_id}
To storage the file, the request will contains: tenant. To return the file_id and date (when file was created).
To receive the file, the request will contains: tenant / year / month / date / file_id.

implemented, available release 1.0.3


ignore case support?

A to a
B to b
..

You can do 'ABC'.lower() before calling.

Closing issue ;)


Initial onboarding DO is referring to an Azure module file that no longer exists

Spotted during testing; startup-script.tpl is downloading a DO template from Azure module that no longer exists in HEAD. During boot, the startup-script will try to download from https://raw.githubusercontent.com/f5devcentral/terraform-azure-bigip-module/dev_saketha_runtimeinit/config/onboard_do.json which no longer exists.
Suggest that a similar onboard_do.json is added to this module too.

Fixed in the latest master branch


example for instance segmentation.

Again, thanks for opensourcing cvpod. I wonder how to use it for instance segmentation. I have seen there are some instance segmentation code like solo and tensormask. Could you give some example config files? @FateScript @Maycbj  Thanks!

I'm sorry for not providing such a example file for you.
We will opensource all the model in a time, and borderdet is just borderdet.

Thanks for your reply !  I just simply try some methods like mask-rcnn. It can ahiceves the same results as det2.


Remove current_time prefetch

Sanic server has a mechanism to prefetch current time, basically to prevent unnecessary time.time() calls. With certain installations this leads to leaking TimerHandle instances.
Visible at least in Kubernetes installations with continuous health check GET calls.
Fixes https://github.com/huge-success/sanic/issues/1500.

Thanks, @langma , this was one of the things in my list to remove for good in Sanic. I think it might be a good idea to backport it to version 18.12 as well. @sjsadowski , what do you think?

Created #1505 to track against 18.12


SAK-30964 Edit content modal is covering left hand menu

It would be ideal if the css here were moved over to the library SASS tool location as many of these viewports are declared there and can be leveraged.


Add registerClient method and update docs

update p5.serialserver and p5.serialport

@vanevery could you take a look and let me know what you think of this?


Add int8 and uint8t to CTypes template

Fix for https://github.com/eProsima/Micro-XRCE-DDS-Gen/issues/54
Tiny integer types were missing on CTypes template.

According to Fast DDS documentation, unit8 is an octet and int8 is a char. If these types are included, another PR to the documentation is required.

int8 and uint8 are already supported as aliases

They are, but only on the idlTypes.st template, which is used for C++ code generation:
https://github.com/eProsima/IDL-Parser/blob/0f9fe63620e234f00c1c4b45faab3112f2165c0c/src/main/resources/com/eprosima/idl/templates/idlTypes.stg#L67-L69
We also need this aliases on the CTypes.stg template for C code generated by Micro-XRCE-DDS-Gen.

int8 and uint8 are already supported as aliases

They are, but only on the idlTypes.st template, which is used for C++ code generation:
https://github.com/eProsima/IDL-Parser/blob/0f9fe63620e234f00c1c4b45faab3112f2165c0c/src/main/resources/com/eprosima/idl/templates/idlTypes.stg#L67-L69
We also need this aliases on the CTypes.stg template for C code generated by Micro-XRCE-DDS-Gen.

Agree, this bug report was for the C-code generation, and it's also in the IDL standard as a supported type.


E2g for cell cluster

The new branch enables users to conduct E2G predictions for each cell cluster. Before running this workflow, users should define cell clusters through regular single-cell analysis (such as Seurat & Signac). The input data requirements are:

Combined meta_data, with columns for cell_name, sample, cluster, and barcode.
Combined RNA matrix, normalized by the total UMI count per cell. This can include log transformation or not.
Indexed fragment files for each sample.

Example data has been generated using Xu et al.’s K562 10x multiome dataset (chr22, 250 cells X 2 clusters X 2 samples, located in the “example_chr22_multiome” folder).

Create “config/config_multiome_samples.tsv” and “config/config_cell_clusters.tsv” for managing settings related to samples and cell clusters, respectively.

A new rule, “generate_frag_file,” has been developed to convert sample-specific fragment files into cell cluster-specific fragment files. Another rule, “frag_to_tagAlign,” has been added to change cell cluster fragment files into tagAlign files. Each cell cluster is then processed as an independent biosample within the ABC pipeline.

Move the make_paths_absolute and get_e2g_config functions from the workflow/Snakefile to workflow/rules/utils.smk. Moreover, all rules, except the “all” rule, are now defined within workflow/rules/*smk.

Update the “Apply model” section in the README document.

Additionally, I noticed that our current code is not compatible with snakemake version 8.X.X. Also, snakemake version 7.X.X introduces extra spaces in strings when using f-strings with Python 12, leading to path errors. Therefore, I have added a restriction for snakemake=7 and python=3.11 in the README.

@mayasheth can you merge your PR (https://github.com/EngreitzLab/sc-E2G/pull/5) to main so that when looking at the diff, we only see Wei-Lin's changes?

@mayasheth can you merge your PR (#5) to main so that when looking at the diff, we only see Wei-Lin's changes?

@atancoder Setting PR (#5) to main seems not work well. You can also choose "Changes from commit 2144aa2".

@mayasheth can you merge your PR (#5) to main so that when looking at the diff, we only see Wei-Lin's changes?

@atancoder Setting PR (#5) to main seems not work well. You can also choose "Changes from commit 2144aa2".

You would probably have to rebase your branch on top of main and then push again for things to work cleanly


Updated copyright to 2016

Hi! Thank you for your pull request. Unfortunately we won't be accepting it. You can find previous discussions on pull requests for just updating the copyright year in #2482

Hi! Thank you for your pull request. Unfortunately we won't be accepting it. You can find previous discussions on pull requests for just updating the copyright year in #2482


Memory retention of DOM objects in dom-if when restamp is true

Description
Right now I'm analysing my app in terms of memory usage because I have a suspicion of a memory leak somewhere in the app.
While I was investigating the detached DOM nodes I noticed that some elements that are children of the dom-if template (with restamp property set) as still in the memory. They are not active (don't receive data binding or perform any operation) but they exists and take memory.
This is a screenshot of the profile snapshot:

The HTMLElement in the Object pane is the element that was wrapped with the dom-if template.
As far as I understand how the dom-if should work, the element shouldn't be retained in the memory.
I'm wondering if that might be caused by data binding. In this particular case the removed element is activated in the app, then, after app settings initialisation, it should be removed (wherever the reason). But during the initialisation time element receives an object via data binding which it's properties are later propagated to child elements. So my guess is that this object keeps the removed element alive. Passed object is referenced in the main script and other elements uses it.
This is the code:
<template is="dom-if" if="[[!usePouchDb]]" restamp="true">
                <arc-request-controller on-iron-deselect="_cancelEvent" on-iron-select="_cancelEvent" request-loading="{{requestLoading}}" has-response="{{hasResponse}}" opened="{{requestOpened}}" request="{{request}}" response="{{response}}" active-request="{{activeRequest}}" route-params="[[params]]">
                  <arc-request-view on-iron-deselect="_cancelEvent" on-iron-select="_cancelEvent" request-loading="[[requestLoading]]" opened="{{requestOpened}}" request="{{request}}"></arc-request-view>
                  <template is="dom-if" if="[[hasResponse]]">
                    <arc-response-view opened="[[requestOpened]]" response="[[response]]" request="[[activeRequest]]"></arc-response-view>
                  </template>
                  <arc-save-dialog-view on-iron-deselect="_cancelEvent" on-iron-select="_cancelEvent" id="saveRequestUi"></arc-save-dialog-view>
                </arc-request-controller>
              </template>

Steps to Reproduce

Add any element that is wrapped with template dom-if and restamp property set.
In Chrome DevTools go to Profiles > Check Take Heap Snapshot > Take snapshot
In the snapshot, filter by Detached
Try to find an element that matches tested element. It should be one of the detached elements.

Versions

Polymer: v1.7.0
webcomponents: v0.7.23

there is not workaround for it? :(

I cannot believe that no one of Polymer team write a correct procedure to remove leak memory for polymer components (on detach for example ) :(
There is a memory leak study on polymer 2.0 ?

I am unable to reproduce this issue in http://jsbin.com/xevafukaxe/edit?html,console,output Performing a memory snapshot shows that at most one span is kept in memory, but that's because it originates from the document-fragment from the dom-if template. Could you elaborate on this issue?

I can't reproduce it with current version of the Polymer either. Possibly this was fixed.


Treating scalars implicitly as collections doesn't work with all objects - some lack a .Count property

#3671 discussed the issue with respect to [pscustomobject] instances, for which a fix was attempted in #5756 (but the fix is not in v6.0.2 - @iSazonov, should it be?).
However, there are instances of other types where the problem persists.
It would be good to clarity on the generic issue, so that it can be fixed for any (current and future) type.
Steps to reproduce
([System.Data.DataTable]::new()).Count
([pscustomobject] @{}).Count

Expected behavior
1
1

Actual behavior
The output is $null, because there is no .Count property.
Environment data
PowerShell Core v6.0.2 on macOS 10.13.3
PowerShell Core v6.0.2 on Ubuntu 16.04.3 LTS
PowerShell Core v6.0.2 on Microsoft Windows 10 Pro (64-bit; v10.0.15063)
Windows PowerShell v5.1.15063.674 on Microsoft Windows 10 Pro (64-bit; v10.0.15063)

DataTable is defined as enumerable in PowerShell.
I think
([System.Data.DataTable]::new()).Count

should retruns 0.
but this expression returns nothing currently...
I think it is a bug.

workaround?
([System.Data.DataTable]::new().Rows).Count

returns 0 as expected.

@stknohg: Thanks, good point about [System.Data.DataTable] being enumerable (though seemingly not in all contexts (anymore) - I've updated the original post.
Yes, it should  return 0 in this case (or, generally, however many rows the .Rows property contains) which, as you state, doesn't work.

v6.0.2 is only security update.

Is the Issue for ForEach and Where too?

@iSazonov: Thanks; your [pscustomobject] fixes were indeed effective in all respects (.Count, [0], .ForEach(), .Where()), I checked with the latest code. The issue with [DataTable] is a different one that I'll address in a new issue.


"plot_duplicates" display results from previous item when repeatedly used

I tried to get duplicated results from a directory and save them into image file in a for loop.
My Code
`
phasher = PHash()
tag = 'Cloud'
thr=1
resultfile = os.path.join(duplicate_detection_results_dir,tag+'.json')
encodings = phasher.encode_images(image_dir=target_dir)
duplicates = phasher.find_duplicates(encoding_map=encodings,
max_distance_threshold=thr,
scores=True,
outfile=resultfile)
for k,v in duplicates.items():
if v:
result_img_file= os.path.join(visual_result_dir,'dup_result_'+k)
plot_duplicates(image_dir=target_dir,
duplicate_map= duplicates,
filename=k,
outfile=result_img_file)
`
After this image is saved,

The other image also contains second item of the previous one.
I resolved this error by simply adding plt.clf() below plt.show() here
https://github.com/idealo/imagededup/blob/master/imagededup/utils/plotter.py#L71

@zacurr I haven't been able to reproduce the issue, but closing the figure seems like a good idea anyway. Although, using plt.close() seems to be a slightly better solution instead of plt.clf()here.

Addressed by #111


Provisioning with example Vagrantfile fails

warning: Could not retrieve fact fqdn
warning: Host is missing hostname and/or domain: graphite
info: Applying configuration version '1409333312'
notice: /Stage[main]/Graphite::Deps/Package[python-cairo]/ensure: ensure changed 'purged' to 'present'
notice: /Stage[main]/Python::Install/Package[python-pip]/ensure: ensure changed 'purged' to 'present'
notice: /Stage[main]/Python::Install/Package[python-virtualenv]/ensure: ensure changed 'purged' to 'present'
notice: /Stage[main]/Python::Install/Package[python-dev]/ensure: ensure changed 'purged' to 'present'
notice: /Stage[main]/Graphite::Deps/Python::Virtualenv[/var/lib/graphite]/File[/var/lib/graphite]/ensure: created
notice: /Stage[main]/Graphite::Deps/Python::Virtualenv[/var/lib/graphite]/Exec[python_virtualenv_/var/lib/graphite]/returns: executed successfully
notice: /Stage[main]/Graphite::Deps/Python::Pip[twisted==11.1.0]/Exec[pip_install_twisted==11.1.0]/returns: executed successfully
notice: /Stage[main]/Graphite::Deps/Python::Pip[python-memcached==1.47]/Exec[pip_install_python-memcached==1.47]/returns: executed successfully
notice: /Stage[main]/Graphite::Deps/Python::Pip[django==1.4.10]/Exec[pip_install_django==1.4.10]/returns: executed successfully
notice: /Stage[main]/Graphite::Deps/Python::Pip[django-tagging==0.3.1]/Exec[pip_install_django-tagging==0.3.1]/returns: executed successfully
notice: /Stage[main]/Graphite::Deps/Python::Pip[gunicorn]/Exec[pip_install_gunicorn]/returns: executed successfully
notice: /Stage[main]/Graphite::Deps/Python::Pip[simplejson==2.1.6]/Exec[pip_install_simplejson==2.1.6]/returns: executed successfully
notice: /Stage[main]/Graphite::Deps/File[/var/lib/graphite/lib/python2.7/site-packages/cairo]/ensure: created
notice: /Stage[main]/Graphite::Install/Python::Pip[graphite-web==0.9.12]/Exec[pip_install_graphite-web==0.9.12]/returns: executed successfully
notice: /Stage[main]/Graphite::Install/Python::Pip[whisper==0.9.12]/Exec[pip_install_whisper==0.9.12]/returns: executed successfully
notice: /Stage[main]/Graphite::Install/Python::Pip[carbon==0.9.12]/Exec[pip_install_carbon==0.9.12]/returns: executed successfully
notice: /Stage[main]/Graphite::Config/File[/etc/init.d/carbon-aggregator]/ensure: created
err: /Stage[main]/Graphite::Config/File[/var/lib/graphite/conf/storage-aggregation.conf]/ensure: change from absent to file failed: Could not set 'file on ensure: No such file or directory - /var/lib/graphite/conf/storage-aggregation.conf.puppettmp_5202 at /etc/puppet/modules/graphite/manifests/config.pp:90
err: /Stage[main]/Graphite::Config/File[/var/lib/graphite/conf/storage-schemas.conf]/ensure: change from absent to file failed: Could not set 'file on ensure: No such file or directory - /var/lib/graphite/conf/storage-schemas.conf.puppettmp_2641 at /etc/puppet/modules/graphite/manifests/config.pp:96
notice: /Stage[main]/Graphite::Config/File[/etc/init/carbon-aggregator.conf]/ensure: created
notice: /Stage[main]/Graphite::Config/File[/etc/init/graphite-web.conf]/ensure: created
err: /Stage[main]/Graphite::Config/File[/var/lib/graphite/storage/log/webapp/]/ensure: change from absent to directory failed: Cannot create /var/lib/graphite/storage/log/webapp; parent directory /var/lib/graphite/storage/log does not exist
err: /Stage[main]/Graphite::Config/File[/var/lib/graphite/conf/carbon.conf]/ensure: change from absent to present failed: Could not set 'present on ensure: No such file or directory - /var/lib/graphite/conf/carbon.conf.puppettmp_274 at /etc/puppet/modules/graphite/manifests/config.pp:78
err: /Stage[main]/Graphite::Config/File[/var/lib/graphite/webapp/graphite/local_settings.py]/ensure: change from absent to file failed: Could not set 'file on ensure: No such file or directory - /var/lib/graphite/webapp/graphite/local_settings.py.puppettmp_6721 at /etc/puppet/modules/graphite/manifests/config.pp:133
err: /Stage[main]/Graphite::Config/File[/var/lib/graphite/webapp/graphite/initial_data.json]/ensure: change from absent to present failed: Could not set 'present on ensure: No such file or directory - /var/lib/graphite/webapp/graphite/initial_data.json.puppettmp_1812 at /etc/puppet/modules/graphite/manifests/config.pp:115
notice: /Stage[main]/Graphite::Config/Exec[init-db]: Dependency File[/var/lib/graphite/webapp/graphite/initial_data.json] has failures: true
warning: /Stage[main]/Graphite::Config/Exec[init-db]: Skipping because of failed dependencies
notice: /Stage[main]/Graphite::Config/File[/var/lib/graphite/storage/graphite.db]: Dependency File[/var/lib/graphite/webapp/graphite/initial_data.json] has failures: true
warning: /Stage[main]/Graphite::Config/File[/var/lib/graphite/storage/graphite.db]: Skipping because of failed dependencies
notice: /Stage[main]/Graphite::Config/File[/etc/init.d/graphite-web]/ensure: created
notice: /Stage[main]/Graphite::Config/File[/etc/init.d/carbon-cache]/ensure: created
notice: /Stage[main]/Graphite::Config/File[/etc/init/carbon-cache.conf]/ensure: created
info: Class[Graphite::Config]: Scheduling refresh of Class[Graphite::Service]
info: Class[Graphite::Service]: Scheduling refresh of Service[carbon-aggregator]
info: Class[Graphite::Service]: Scheduling refresh of Service[carbon-cache]
info: Class[Graphite::Service]: Scheduling refresh of Service[graphite-web]
notice: /Stage[main]/Graphite::Service/Service[carbon-aggregator]: Dependency File[/var/lib/graphite/webapp/graphite/initial_data.json] has failures: true
notice: /Stage[main]/Graphite::Service/Service[carbon-aggregator]: Dependency File[/var/lib/graphite/conf/storage-aggregation.conf] has failures: true
notice: /Stage[main]/Graphite::Service/Service[carbon-aggregator]: Dependency File[/var/lib/graphite/storage/log/webapp/] has failures: true
notice: /Stage[main]/Graphite::Service/Service[carbon-aggregator]: Dependency File[/var/lib/graphite/webapp/graphite/local_settings.py] has failures: true
notice: /Stage[main]/Graphite::Service/Service[carbon-aggregator]: Dependency File[/var/lib/graphite/conf/storage-schemas.conf] has failures: true
notice: /Stage[main]/Graphite::Service/Service[carbon-aggregator]: Dependency File[/var/lib/graphite/conf/carbon.conf] has failures: true
warning: /Stage[main]/Graphite::Service/Service[carbon-aggregator]: Skipping because of failed dependencies
notice: /Stage[main]/Graphite::Service/Service[carbon-aggregator]: Triggered 'refresh' from 1 events
notice: /Stage[main]/Graphite::Service/Service[carbon-cache]: Dependency File[/var/lib/graphite/webapp/graphite/initial_data.json] has failures: true
notice: /Stage[main]/Graphite::Service/Service[carbon-cache]: Dependency File[/var/lib/graphite/conf/storage-aggregation.conf] has failures: true
notice: /Stage[main]/Graphite::Service/Service[carbon-cache]: Dependency File[/var/lib/graphite/storage/log/webapp/] has failures: true
notice: /Stage[main]/Graphite::Service/Service[carbon-cache]: Dependency File[/var/lib/graphite/webapp/graphite/local_settings.py] has failures: true
notice: /Stage[main]/Graphite::Service/Service[carbon-cache]: Dependency File[/var/lib/graphite/conf/storage-schemas.conf] has failures: true
notice: /Stage[main]/Graphite::Service/Service[carbon-cache]: Dependency File[/var/lib/graphite/conf/carbon.conf] has failures: true
warning: /Stage[main]/Graphite::Service/Service[carbon-cache]: Skipping because of failed dependencies
notice: /Stage[main]/Graphite::Service/Service[carbon-cache]: Triggered 'refresh' from 1 events
notice: /Stage[main]/Graphite::Service/Service[graphite-web]: Dependency File[/var/lib/graphite/webapp/graphite/initial_data.json] has failures: true
notice: /Stage[main]/Graphite::Service/Service[graphite-web]: Dependency File[/var/lib/graphite/conf/storage-aggregation.conf] has failures: true
notice: /Stage[main]/Graphite::Service/Service[graphite-web]: Dependency File[/var/lib/graphite/storage/log/webapp/] has failures: true
notice: /Stage[main]/Graphite::Service/Service[graphite-web]: Dependency File[/var/lib/graphite/webapp/graphite/local_settings.py] has failures: true
notice: /Stage[main]/Graphite::Service/Service[graphite-web]: Dependency File[/var/lib/graphite/conf/storage-schemas.conf] has failures: true
notice: /Stage[main]/Graphite::Service/Service[graphite-web]: Dependency File[/var/lib/graphite/conf/carbon.conf] has failures: true
warning: /Stage[main]/Graphite::Service/Service[graphite-web]: Skipping because of failed dependencies
notice: /Stage[main]/Graphite::Service/Service[graphite-web]: Triggered 'refresh' from 1 events
info: Creating state file /var/lib/puppet/state/state.yaml
notice: Finished catalog run in 188.16 seconds

Hi @jhoblitt,
Firstly apologies for not getting around to this issue sooner.
We've tested the vagrant image under vagrant 1.7.4 and we've been unable to reproduce the issue. We're planning on moving to Trusty in the very near future so hopefully this problem is resolved and won't return. If it does please feel free to reopen the issue and we can take another look.


Fixes for Visual Studio builds and gitignore output

Output conflicted from test and tinyxml2 projects because they shared output directories. Fixed by adding project name as a part of the path and standardized across all platforms/configs.

Been driving me crazy and I didn't know how to fix - thanks.


[request] Wake up the device on push

Hello.
Is there a way to wake up the device on received push notification, and vibrate each time ?
( Android specifically / Android Native )

You mean to vibrate when push is received?

Yes, and turn on the screen if possible.
On 31 May 2018 at 07:08, Rendy Del Rosario<EMAIL_ADDRESS>wrote:

You mean to vibrate when push is received?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CrossGeeks/FirebasePushNotificationPlugin/issues/145#issuecomment-393395553,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGO0N9lOGDhb0vH2HiSLWZxW7my3c8SRks5t32zKgaJpZM4UKTID
.

--
Yordan Yanakiev
design & software architectures

So, is there?  One of the most important aspects of receiving a notification is to be notified about it via vibration, sound and screen lights coming on. On iOS this works fine, but on Android the notification just stacks to the system tray and I can only see it if I open the tray.


directories with "." appear to break the parser.

Loading /home/foo/Github/mediawiki/resources/src/mediawiki.less …                                                                                index.py:51
Traceback (most recent call last):
  File /home/foo/may15venv/lib64/python3.11/site-packages/langchain/document_loaders/text.py, line 40, in load
    with open(self.file_path, encoding=self.encoding) as f:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
IsADirectoryError: [Errno 21] Is a directory: '/home/foo/Github/mediawiki/resources/src/mediawiki.less'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File /home/foo/may15venv/bin/clara, line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File /home/foo/may15venv/lib64/python3.11/site-packages/clara/cli.py, line 177, in main
    fire.Fire(Clara())
  File /home/foo/may15venv/lib64/python3.11/site-packages/fire/core.py, line 141, in Fire
    component_trace = _Fire(component, args, parsed_flag_args, context, name)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File /home/foo/may15venv/lib64/python3.11/site-packages/fire/core.py, line 475, in _Fire
    component, remaining_args = _CallAndUpdateTrace(
                                ^^^^^^^^^^^^^^^^^^^^
  File /home/foo/may15venv/lib64/python3.11/site-packages/fire/core.py, line 691, in _CallAndUpdateTrace
    component = fn(*varargs, **kwargs)
                ^^^^^^^^^^^^^^^^^^^^^^
  File /home/foo/may15venv/lib64/python3.11/site-packages/clara/cli.py, line 105, in chat
    index, chat = setup(path, memory_storage)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File /home/foo/may15venv/lib64/python3.11/site-packages/clara/cli.py, line 30, in setup
    index.ingest()
  File /home/foo/may15venv/lib64/python3.11/site-packages/clara/index.py, line 73, in ingest
    texts = self._get_texts()
            ^^^^^^^^^^^^^^^^^
  File /home/foo/may15venv/lib64/python3.11/site-packages/clara/index.py, line 53, in _get_texts
    documents.extend(loader.load_and_split())
                     ^^^^^^^^^^^^^^^^^^^^^^^
  File /home/foo/may15venv/lib64/python3.11/site-packages/langchain/document_loaders/base.py, line 43, in load_and_split
    docs = self.load()
           ^^^^^^^^^^^
  File /home/foo/may15venv/lib64/python3.11/site-packages/langchain/document_loaders/text.py, line 56, in load
    raise RuntimeError(fError loading {self.file_path}) from e
RuntimeError: Error loading /home/foo/Github/mediawiki/resources/src/mediawiki.less

fyi
I have a program that is trying to create a vecotrdb, it reads all the files of a codebase and seperates the functions out into the vectordb.
generally it works, but for the wikimedia codebase i get an error
>>> Loading /home/foo/Github/mediawiki/resources/src/mediawiki.less …                                                                                index.py:51
Traceback (most recent call last):
  File /home/foo/may15venv/lib64/python3.11/site-packages/langchain/document_loaders/text.py, line 40, in load
    with open(self.file_path, encoding=self.encoding) as f:
IsADirectoryError: [Errno 21] Is a directory: '/home/foo/Github/mediawiki/resources/src/mediawiki.less'

my reading of this is its trying to open mediawiki.less as a file but it is infact a directory.
The code related to reading files and walking over the directory to create the vector database is located in the _get_texts method of the RepositoryIndex class. Here is the code snippet:
 def _get_texts(self):
     def get_files_by_wildcards(path: str, wildcards: List[str]) -> List[str]:
         matched_files = []

         for wc in wildcards:
             pattern = os.path.join(path, "**", wc)
             matched_files.extend(glob.glob(pattern, recursive=True))

         return matched_files

     if not os.path.exists(self.path):
         raise Exception(f"Path does not exists: {self.path}")

     documents = []
     for file_path in get_files_by_wildcards(self.path, WILDCARDS):
         console.log(f"Loading [blue underline]{file_path}", "…")
         if CodeLoader.has_loader(file_path):
             loader = CodeLoader(file_path, encoding="utf-8")
         else:
             loader = TextLoader(file_path, encoding="utf-8")
         documents.extend(loader.load_and_split())

     text_splitter = CharacterTextSplitter.from_tiktoken_encoder(
         chunk_size=config["index"]["chunk_size"],
         chunk_overlap=config["index"]["chunk_overlap"],
         disallowed_special=(),
     )
     return text_splitter.split_documents(documents)

can you see the error? or perhaps you need to see more code ?
ChatGPT
Your code currently does not differentiate between files and directories. Both are being handled in the same way, which is leading to the IsADirectoryError.
You could modify your code to ensure that it only attempts to open and read from a path if that path is a file, not a directory. You can use os.path.isfile(path) to check if a path points to a file.
Here's a suggestion of how you can modify your _get_texts function:
python
def _get_texts(self):
     def get_files_by_wildcards(path: str, wildcards: List[str]) -> List[str]:
         matched_files = []

         for wc in wildcards:
             pattern = os.path.join(path, "**", wc)
             matched_files.extend(glob.glob(pattern, recursive=True))

         return matched_files

     if not os.path.exists(self.path):
         raise Exception(f"Path does not exists: {self.path}")

     documents = []
     for file_path in get_files_by_wildcards(self.path, WILDCARDS):
         # Skip if the path is a directory
         if not os.path.isfile(file_path):
             continue

         console.log(f"Loading [blue underline]{file_path}", "…")
         if CodeLoader.has_loader(file_path):
             loader = CodeLoader(file_path, encoding="utf-8")
         else:
             loader = TextLoader(file_path, encoding="utf-8")
         documents.extend(loader.load_and_split())

     text_splitter = CharacterTextSplitter.from_tiktoken_encoder(
         chunk_size=config["index"]["chunk_size"],
         chunk_overlap=config["index"]["chunk_overlap"],
         disallowed_special=(),
     )
     return text_splitter.split_documents(documents)

This code checks each file path, and if it's not a file (meaning it could be a directory, or perhaps a symbolic link), it just skips to the next iteration of the loop without trying to load the non-file path.
This is a quick fix. For a more sophisticated solution, you might want to design your application in a way that it could also read files inside directories if required. But the above solution should solve your immediate problem.

Good catch :+1:
Yes, I wanted to change all that code. It worked for the PoC but it's so inefficient. Maybe I simply use your patch for the moment though.

works, thanks!


Update scalatestplus-scalacheck to <IP_ADDRESS>-RC2

Updates org.scalatestplus:scalatestplus-scalacheck from 1.0.0-SNAP8 to <IP_ADDRESS>-RC2.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalatestplus", artifactId = "scalatestplus-scalacheck" } ]

Codecov Report

Merging #1247 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1247   +/-   ##
=======================================
  Coverage   86.44%   86.44%
=======================================
  Files          92       92
  Lines        2863     2863
  Branches      119      119
=======================================
  Hits         2475     2475
  Misses        388      388

Impacted Files
Coverage Δ

...rc/main/scala/io/circe/shapes/SizedInstances.scala
78.57% <0%> (-14.29%)
:arrow_down:

...d/src/main/scala/io/circe/NonEmptySeqDecoder.scala
91.66% <0%> (-8.34%)
:arrow_down:

...rc/main/scala/io/circe/numbers/BiggerDecimal.scala
84.79% <0%> (-1.76%)
:arrow_down:

...les/core/shared/src/main/scala/io/circe/Json.scala
78.18% <0%> (ø)
:arrow_up:

...re/shared/src/main/scala/io/circe/JsonNumber.scala
95.18% <0%> (+1.2%)
:arrow_up:

.../core/shared/src/main/scala/io/circe/Decoder.scala
86.06% <0%> (+1.24%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3edf83c...1d26d10. Read the comment docs.


Getting issue in connecting with locally hosted poxa

Hi,
i have configured this on my localhost and trying to connect with https://github.com/pusher-community/pusher-presence-dem app with below config in pusher_init.rb-
# Get some free Pusher credential for development use:
Pusher.app_id = '1234'
Pusher.key    = 'app_key'
Pusher.secret = 'secret'

# not strictly necessary, but referenced in views
PUSHER_JS_DOMAIN = 'https://js.pusher.com'
PUSHER_SOCKET_HOST = 'localhost'
PUSHER_WS_PORT = 8080

And below config in config.exs:-
import Config
if Mix.env == :test do
  config :logger, backends: []
end

import System
config :poxa,
  port: get_env("PORT", "8080") |> String.to_integer(),
  app_key: get_env("POXA_APP_KEY", "app_key"),
  app_secret: get_env("POXA_SECRET", "secret"),
  app_id: get_env("POXA_APP_ID", "1234"),
  registry_adapter: get_env("POXA_REGISTRY_ADAPTER", "gproc"),
  web_hook: get_env("WEB_HOOK", nil),
  payload_limit: get_env("PAYLOAD_LIMIT") || 10_000

config :poxa, :ssl,
  enabled: get_env("POXA_SSL", "false") == "true",
  port: get_env("SSL_PORT", "8443") |> String.to_integer(),
  cacertfile: get_env("SSL_CACERTFILE", ""),
  certfile: get_env("SSL_CERTFILE", ""),
  keyfile: get_env("SSL_KEYFILE", "")

After this configurations i m getting below response in app

Please help me to find what di i missed
Thanks in advance

Hey @AnkitRathore175, this ruby project is really really old. I would suggest you to upgrade the dependencies first or use some other example app.

Hi @edgurgel
yes i resolved it, i was not using correct config,
However i wanted to know why i m able to use any numbers for app_id?
thanks


Core Python Documentation returns a 404 error

When trying to visit the Python reference for the core class the documentation website returns a 404 error.
https://lab-cosmo.github.io/metatensor/latest/core/reference/python/index.html
This also causes problems for downstream packages and their intersphinx links i.e https://github.com/Luthaf/rascaline/pull/275

I have no idea what is going wrong. The files are not on gh-pages, but they where successfully generated in the latest build: https://github.com/lab-cosmo/metatensor/actions/runs/7759491847/job/21163626972
And then they are missing from the job taking gh-pages and creating the website (this is automatically done by github): https://github.com/lab-cosmo/metatensor/actions/runs/7759555481/job/21163844037
I'll try removing latest in gh-pages and re-triggering a build.

Oh, right. We have python/ in the .gitignore. Should be an easy fix.
Might be interesting to change the way we deploy docs to not have to push to a branch, with https://docs.github.com/en/pages/getting-started-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site#publishing-with-a-custom-github-actions-workflow.

Should be fixed now!

Wonderful. Thanks!


Add PyPI publishing CD workflow

Add GitHub continuous delivery workflow which is triggered on library-vX.X.X tag. The workflow

Creates a GitHub release.
Pushes the package to PyPI using trusted publisher flow (no token in secrets necessary).

Add noxfile.py that can format, lint, and make a release commit (writes towncrier log items to /compute_horde/CHANGELOG.md).
Change Docker image build scripts to use additional context to copy compute_horde package instead or relying on copying (as far as I can tell, docker-compose would not work before running ./build-image.sh before this because it needed a compute_horde subdirectory within /validator, /miner, /executor).

Note that while this implements publishing, miner, validator and executor projects still use path ../compute_horde as a dependency. Changing this would have some effects on DX that I'd like discuss more first.

To be fair, this needs more documentation, a proper /compute_horde/README.md and a /CONTRIBUTING.md.


Working with Windows

Refer to https://github.com/singapore/renovate/issues/1148
Like this, prettier works well and jest also!
For tests, I found this way of mocking path.join.

I think the spyOn solution will make tests harder to maintain in future and so I would like to make sure there aren't any "cleaner" solutions available before we merge this one.

I agree with you, I'm not a big fan of spyOn like this.
It's the only way I found.
Maybe other test should be sufficient? Like split by '/' and '\' should be the same.

What if you just remove the snapshots for those tests instead of adding spyOn? None of them look essential as we check other things anyway

Fully agree! :)

@jycouet I've made the edits myself, can you git pull and try the tests locally?

Thx @rarkins, it's working.
I updated  snapshots, now it working well 👍

lgtm once CircleCI tests pass


Throws error for correct regex: unknown meta-character

regex:

[\.\-\_](\w+)[\.\-\_]

error message:

unknown meta-character: _ (pos 6)

it's a valid regex and matched by all engines: https://regex101.com/r/v74T2Y/1

@Alexey-T

@Alexey-T

Maybe add this regex also to the testcases

Maybe add this regex also to the testcases

what other chars must be handled ok here? besides of _. let's collect them, for my fix.

what other chars must be handled ok here? besides of _. let's collect them, for my fix.

The usual metacharacters are {}[]()^$.|*+? and \.
The usual characters that become metacharacters when escaped are dswDSW and N

https://en.wikipedia.org/wiki/Regular_expression#Syntax

The usual metacharacters are {}[]()^$.|*+? and \.
The usual characters that become metacharacters when escaped are dswDSW and N

https://en.wikipedia.org/wiki/Regular_expression#Syntax

Looks like you can escape every character and as long as it doesn't have a regex meaning it works fine
(\q) matches
qq_qq-qq
qq12qq

see https://regex101.com/r/slGUfp/1

Looks like you can escape every character and as long as it doesn't have a regex meaning it works fine
(\q) matches
qq_qq-qq
qq12qq

see https://regex101.com/r/slGUfp/1

okay; I will make the fix.

okay; I will make the fix.

@andgineer pls apply the PR. I didnt allow other word-chars to be escaped. its possible hole: e.g. \q - better show that it's an error.

@andgineer pls apply the PR. I didnt allow other word-chars to be escaped. its possible hole: e.g. \q - better show that it's an error.

thanks
Maybe add some test cases for this to be sure it never get broken again?

thanks
Maybe add some test cases for this to be sure it never get broken again?

doesnt worth it; i tested it in the dialog-demo.

doesnt worth it; i tested it in the dialog-demo.

Are we sure that will do better than before?
For me better to let escape any "suspicious" symbol. And I do not want to remember is this symbol have any special meaning in this version of regex.
Like ".,". So If I want just symbol "," I will escape it and I do not want to remember if "," has any special role. I just want to be sure in this case it will be just ",". So I add "" without any research if I really have to do that.
And what the harm if "\q" will be treated as plain "q"?

Are we sure that will do better than before?
For me better to let escape any "suspicious" symbol. And I do not want to remember is this symbol have any special meaning in this version of regex.
Like ".,". So If I want just symbol "," I will escape it and I do not want to remember if "," has any special role. I just want to be sure in this case it will be just ",". So I add "" without any research if I really have to do that.
And what the harm if "\q" will be treated as plain "q"?

IMO its ok to show errors for \q (all unknown letters). users never write \q meaning "q", but yes they write . , ~ % @ for symbol chars.

IMO its ok to show errors for \q (all unknown letters). users never write \q meaning "q", but yes they write . , ~ % @ for symbol chars.


Make a release

The current HEAD works with GHC 8.2. The latest release does not. A new release would help people trying out Intero with GHC 8.2.

Would love a release too. There are a couple of fixes in master I would be happy to try out.
It is a bit peculiar,  22 releases in 2016 and none so far in 2017.

Version 0.1.21 should be on melpa and hackage now. Let me know if anything else needs doing for the release!

Thanks Anthony ! Do you know what needs to be done to get intero back in Stackage Nightly ?

@pepeiborra I think a PR to stackage is needed. I probably won't be able to do so today, so if you're desperate you can make the PR re-adding intero and link back to this thread. Otherwise I will get to it as soon as I have some keyboard time.

I've sent a PR.

Thanks @acowley


Support SMPL-X estimation?

Nice work! I am wondering if the method can supprot reconstructing world 3D SMPL-X motions?
Thank you!

Hello @michaelliyunhao ,
I received an answer that the result will have the SMPL parameters in january, and following these instructions you can convert SMPL to SMPL-X
https://github.com/vchoutas/smplx/tree/main/transfer_model#smpl-to-smpl-x
(I actually didnt try it yet, I just know that it existis)

Thanks @carlosedubarreto ! Yes, you can simply convert SMPL to SMPL-X model through the optimization process. This is the simple solution, but this won't allow reconstructing facial expression and hand pose.

Thanks @carlosedubarreto ! Yes, you can simply convert SMPL to SMPL-X model through the optimization process. This is the simple solution, but this won't allow reconstructing facial expression and hand pose.
Thanks for your quick reply! I think it is a reasonable strategy to converted the final estimated SMPL to SMPL-X without hand pose and expression, but I am wondering if I can resonstruct global whole body motions with hand and face using monocular 3D mesh recovery methods of SMPL-X such as hybrik-x. Since SHAM seems focusing on optimizing the global root translation which is nothing to do with hands and faces, I am wondering if I can just add the estimated SMPL-X hand and face parameters in camera coordinate on the converted SMPL-X parameters obtained from  SHAM?

@michaelliyunhao
Yes, get global body motion of SMPL-X from WHAM estimation (convert SMPL to SMPL-X) and add hand pose / facial expression from Hybrik-x sounds like a solid way to recover full-body motion. But I guess converting SMPL to SMPL-X runs a bit slowly, won't be real-time in this case.

@michaelliyunhao
Yes, get global body motion of SMPL-X from WHAM estimation (convert SMPL to SMPL-X) and add hand pose / facial expression from Hybrik-x sounds like a solid way to recover full-body motion. But I guess converting SMPL to SMPL-X runs a bit slowly, won't be real-time in this case.

Great! Thanks for your reply!


url prop

Hi,
I have a doubt about the URL PROP.
Question:

Can I set the URL Prop to send post/file to a Vue method before I send it to API endpoint? I'm using StrongLoop Loopback for the API.

For example, that is I need:
<dropzone ref="file" id="file" url="VueMethod()" v-on:vdropzone-success="showSuccess">
        <input type="hidden" name="token1" value="xxx">
</dropzone>

Anybody can help?

@grimpa Right now you can't pass method to url prop. Because behind the scenes url prop is used as action for form.

Hi @grimpa
You should be able to use the setOption method
something like
<template>
    <div>
      <dropzone id="myVueDropzone" url="https://httpbin.org/post" v-on:vdropzone-sending="sendingEvent"></dropzone>
  </div>
</template>

<script>
  import Dropzone from 'vue2-dropzone'

  export default {
    name: 'MainApp',
    components: {
      Dropzone
    },
    methods: {
      'sendingEvent': function (file, xhr, formData) {
        vm.$refs.file.setOption('url', 'http://somethingorother')
      }
    }
  }
</script>

Alternatively you might be able to hijack the xhr object...
I haven't tested either approach but one of them should work I think.

Works.
In my case (using loopback for backend), I created a custom remote method in my API to receive the file, and then, in this method I manipulated everything that I needed. And then I called the upload method.
It solved my problem perfectly.


pids: treat DOI according to access changes

A record might get a DOI reserved when creating a draft. However, then the access rules might change. The use cases are the following:

[ ] A draft gets a reserved DOI, but then it changes access to embargoed.
[ ] A record gets a reserved DOI, but then it changes access to embargoed. Can this happen, the record access cannot changed, when published?
[ ] A drafts gets a reserved DOI, but then it changes to access to restricted
[ ] Once the embargo is lifted how does the DOI gets registered?

I think we want embargoed records to have published DOIs. Embargoed record metadata is public so there is no risk in sending metadata to DataCite. For our common embargo use case (files under review for a publication) you need the DOI to be registered so editors and reviewers can see that the DOI works.
For records where access is "restricted", I think there is very limited risk in having a reserved DOI. Reserved DOIs don't show up in any public system and aren't even in the handle system. I guess it depends on your level of concern about restricting access to the metadata, since you are putting information on another system. But the access levels do match between restricted and draft.
The only state change I think we have to worry about is:

[ ] Record is published, then user changes access to restricted. In this case we'd want to use the private_doi call to make sure metadata doesn't appear in the DataCite public interface.

@tmorrell I see your point about embargoed, thanks. In terms of restricted... I think I would still not send the metadata out... For Zenodo/similar use cases is Ok I guess.  In that case I guess the question is "why have a DOI provider?"... Maybe @lnielsen  can clarify on this use case.

Add this test:
@pytest.mark.skip("PIDS-FIXME: re-enable when tackling permissions")
def test_reserve_pid_without_login(
    app, location, es_clear, headers, client, minimal_record
):
    """Test the reserve function" without client log in."""
    # Create the draft
    response = client.post(
        "/records", data=json.dumps(minimal_record), headers=headers)

    assert response.status_code == 201
    recid = response.json['id']

    response = client.get(
        f"/records/{recid}/draft/pids/doi", headers=headers)
    assert response.status_code == 403

Among others, just not in the test suite at the moment...

 In that case I guess the question is "why have a DOI provider?"... Maybe @lnielsen can clarify on this use case.

People who want a DOI should be aware that the metadata is always public (even CC0?), so if you want your metadata to be hidden, don't get a DOI.

Discussion from the coffee break at the InvenioRDM workshop with Werner, Nico, Martin, Karolina and Christoph.
Proposed solution:

Restricted records: DOIs are not created, and hence also not registered.
Restricted records with embargo: DOIs are not created, and hence also not registered.
Public with restricted records (w/wo embargo): DOIs are created and registered when published.
Public: DOIs are created and registered when published.

State changes:

Restricted -> Public (e.g. user changes the setting or embargo expire): No DOI is created automatically.
Public -> Restricted (e.g. user changes visibility setting): A general warning is displayed to the user that they should be aware that a DOI is registered and metadata may have been harvested by several systems and there's no control of what happens.


Doesn't compile with  BUILD_LIBRARY_FOR_DISTRIBUTION=YES

Hi,
I am using AsyncBluetooth as a dependency for a Framework I am building
when I am trying to build the framework archive with
xcodebuild archive \
    SKIP_INSTALL=NO \
    BUILD_LIBRARY_FOR_DISTRIBUTION=YES \
    -workspace Cube.xcworkspace \
    -scheme CubeReader \
    -destination "generic/platform=iOS" \
    -archivePath "build/CubeReader"

I get Errors like this:
/Xcode/DerivedData/Cube-gebyvdjvuxpdpwhdrptryrgycpdm/Build/Intermediates.noindex/ArchiveIntermediates/CubeReader/IntermediateBuildFilesPath/AsyncBluetooth.build/Release-iphoneos/AsyncBluetooth.build/Objects-normal/arm64/AsyncBluetooth.swiftinterface:140:26: error: 'Characteristic' is not a member type of struct 'AsyncBluetooth.AsyncBluetooth'
extension AsyncBluetooth.Characteristic {
          ~~~~~~~~~~~~~~ ^

and the build fails.
without the BUILD_LIBRARY_FOR_DISTRIBUTION flag the build runs fine.
Any help appreciated.
buildlog.txt

Hi! You're seeing this issue because AsyncBluetooth doesn't support library evolution. Instead of providing a binary, AsyncBluetooth distributes the sources. And since clients will need to compile it every time, there's no need to guarantee ABI stability.
In order to use the package in one that supports package evolution (one built with the BUILD_LIBRARY_FOR_DISTRIBUTION flag on), you'll need to hide the use of this framework by doing @_implementationOnly import AsyncBluetooth. Note this will work as long as you aren't exposing any of the types from this library in your public API.
Let me know if this works for you.

Hi Manuel,
thx for your quick response and sorry for my late reply - had do do my homework.
As you suggested I prepended every import of AsyncBluetooth with @_implementationOnly and I don't expose any types from AsyncBluetooth publicly.
To build an xcframework I need one (or multiple) archives and I have two possibilities to make one: via CLI or via XCode GUI. I also have two possibilities to set the BUILD_LIBRARY_FOR_DISTRIBUTION flag: either in the Build Settings of the Target or as a build flag when invoking xcodebuild archive on the commandline.
My tests so far showed the following outcome:
GUI:

Build Settings Build Libraries for Distribution: Yes
Menu Product/Archive: Build succeeds

CLI:

Build Settings Build Libraries for Distribution: Yes
xcodebuild archive BUILD_LIBRARY_FOR_DISTRIBUTION=YES: Build fails
xcodebuild archive: Build succeeds

both archives have different sizes, but when I pack them with xcodebuild -create-xcframework they both generate the same xcFramework (at least diff -qr found no difference) and both work when I embed them in an app.
My understanding so far is that build library for distribution has two purposes:

library evolution support: enables the possibility to update the library without the need to rebuild an app that uses it.
module stability: possibility to build an app with  different compiler versions than the lib was build.

I think I don't need library evolution, but I am certain that I need module stability.
So right now it puzzles me:

when I set Build Libraries for Distribution: Yes in Build Settings why do I need to set the flag again on the commandline (seems like a duplication to me) and why does the build fails when I do?
how can I confirm that the lib was build with module stability?

I am pretty aware that these questions exceed the scope of an issue of your lib - which btw was a great timesaver for me - by far but any insight in this stuff is greatly appreciated.

fixed my problem by coding the async/await wrappers around the delegate methods myself and by this refactoring out the AsyncBluetooth Library.
Obviously AsyncBluetooth wasn't a match for my use case.
A short note that the lib doesn't support Library Evolution in the Readme would be great - but anyway thanks for your effort!
Issue can be closed.

Apologies for coming back to this so late. Glad you were able to figure out a solution! I'll update the README to include a note about Library Evolution.


Update .travis.yml

Also run the tests on nodejs v0.12 / v4 / v6

I'm going to close this PR, not because the changes are bad, but because they don't directly affect Select2. The Node version specified in the Travis file is for the Node version used for local development, not for the version that is necessary to run Select2 without any issues.
We do have plans to update PRs so they build against a newer version of Node, but this isn't a super high priority.


Add success messages for each command that needs one

The idl command was originally designed to be silent on success in the tradition of unix command line utilities. Too many people are confused by this behavior.
closes #56
mitigates confusion due to #52
@Raynos @kriskowal

👍


FileDrop: collect multiple files dropped at once

Changes the file drop event to store a list of strings/paths.
The event handler "collects" all the files dropped between BEGIN and
COMPLETE and sends the populated list out
Example:

@glennsl my latest commits address all your previous comments I think -- let me know if I missed anything! I'm curious to know what you think of how I restructured the drop state API.
Thanks for all the notes!

Alright I've updated to use<EMAIL_ADDRESS>It was a single line change to the new API, which is always nice :). Once this passes CI I can merge this into the other PR, and merge that PR into master 🎆🎆🎆

@zbaylin - if you want, since this is going in the other PR anyway - we can just merge this now, and let the CI run on the 'main' PR. Might be more streamlined than having to wait twice 😄
I think you have permission to override for this PR, but if not let me know 👍

@bryphe I realized the same thing after I posted that 😆. Sounds good - I can do that now ✅


GH-41085: [CI][Java] Add Spark integration tests to "java" group in Crossbow tasks

Rationale for this change
Spark integration tests to related to our Java implementation.
What changes are included in this PR?
Add test-*spark* task to java group.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.

GitHub Issue: #41085

@github-actions crossbow submit -g java

The following Spark integration tests are included:

test-conda-python-3.10-spark-v3.5.0
test-conda-python-3.11-spark-master
test-conda-python-3.8-spark-v3.5.0

@kou one crossbow fails. It's not viewable for me to see why it is failing. Could you please check?

https://github.com/ursacomputing/crossbow/actions/runs/8606378683/workflow
Workflow has a syntax error...
Could you open a new issue for this. This is not related to this PR.

https://github.com/ursacomputing/crossbow/actions/runs/8606378683/workflow
Workflow has a syntax error...
Could you open a new issue for this. This is not related to this PR.

@kou issue created: https://github.com/apache/arrow/issues/41088

Thanks.
I'll merge this.


Script bucket/queue resources

We want these resources to be namespaced per developer. Create these resources on demand?
Resources that need to be created:

S3 bucket
SQS for worker pipeline
SQS dead letter queue

Along with the appropriate group policy permissions configuration.

The config should be templated json so we can handled this dynamically.

Updated the description with more details about which resources need to be scripted.


Object.defineProperties throws in IE11

The error is: SCRIPT28: Out of stack space.
Here is a reproduction: https://jsfiddle.net/1wkaom61/

what a silly bug I had there, fixed in 0.9.2 for every IE, thanks.