API no response

Hi,
first of all thanks for this project. I don't use HA but openHab, but wanted to check if I can integrate it somehow.
Started with checking if AristonThermal at least answers to API, so I run below script.
from aristonremotethermo.ariston import AristonHandler

ApiInstance = AristonHandler(
<EMAIL_ADDRESS>            password='mypassword'
        )

ApiInstance.start()
print(ApiInstance.version)
print(ApiInstance.available)
ApiInstance.stop()

Unfortunately answer is always False.
smarthomepcj@raspberry:~/ariston $ python3 ariston.py
1.0.28
False

Do you have any idea what could be the reason?
User and password are absolutely correct as I can login via webpage without any problems.
TIA

Hard to say for sure. Is it Aqua Ariston NET or Ariston NET application used in your case?
There are 2 classes and Ariston Aqua requires dedicated boiler type being specified. Incorrect integration selected would never be available. Also in case of Aqua Ariston it turned out that boiler have unique requests and incorrect type selected would also not work.
For example boilers with Ariston Aqua do support logging to the website but they only list the boiler with no data provided. While Ariston fetches and parses data from website, where different water and climate data is in fact provided. For Aqua Ariston requests from Android phone were replicated instead and requests turned out to be unique per 3 models that people supplied access to.

Hard to say for sure. Is it Aqua Ariston NET or Ariston NET application used in your case?
There are 2 classes and Ariston Aqua requires dedicated boiler type being specified. Incorrect integration selected would never be available. Also in case of Aqua Ariston it turned out that boiler have unique requests and incorrect type selected would also not work.
For example boilers with Ariston Aqua do support logging to the website but they only list the boiler with no data provided. While Ariston fetches and parses data from website, where different water and climate data is in fact provided. For Aqua Ariston requests from Android phone were replicated instead and requests turned out to be unique per 3 models that people supplied access to.

Thx for prompt answer.
My boiler is  GENUS ONE SYSTEM 24 so I used Ariston NET (no aqua).
Maybe I created the script wrongly? :(

Thx for prompt answer.
My boiler is  GENUS ONE SYSTEM 24 so I used Ariston NET (no aqua).
Maybe I created the script wrongly? :(

is it the whole code that you are using?
Note that it takes usually around 20 seconds just for the first request (possible more in case of timeouts), so for initial tests I used 10 minutes time span and checked the data periodically (sensor_values for example). Occasionally I used store_file as input parameter to generate and check interchangeable data for example which requests were generated and which values were provided by the server.
Unlike Android application or website for monitoring purposes I use periodic requests and it often takes time to fetch (shortening delay between requests causes server to generate many errors). Available flag will be set only if login was successful (there is one flag) and if main data was fetched (first page on website with CH and DHW data), so you may also print _ariston_data.
For example in Home Assistant integration during setup I initiate and start the integration and it works constantly, stop is actually never executed there. Home Assistant integration simply fetches generated sensors every few seconds and represents them.
By the way, are you trying to apply if for some home automation environment like Home Assistant or Domoticz?

is it the whole code that you are using?
Note that it takes usually around 20 seconds just for the first request (possible more in case of timeouts), so for initial tests I used 10 minutes time span and checked the data periodically (sensor_values for example). Occasionally I used store_file as input parameter to generate and check interchangeable data for example which requests were generated and which values were provided by the server.
Unlike Android application or website for monitoring purposes I use periodic requests and it often takes time to fetch (shortening delay between requests causes server to generate many errors). Available flag will be set only if login was successful (there is one flag) and if main data was fetched (first page on website with CH and DHW data), so you may also print _ariston_data.
For example in Home Assistant integration during setup I initiate and start the integration and it works constantly, stop is actually never executed there. Home Assistant integration simply fetches generated sensors every few seconds and represents them.
By the way, are you trying to apply if for some home automation environment like Home Assistant or Domoticz?

Note that it takes usually around 20 seconds just for the first request ...
This was the point!
I have added _ariston_data + the loop with time.sleep(60) and 2nd iteration was already successful!

1.0.28
False
False
{}
1.0.28
True
True
{'__tmpEm20': {'HydraulicScheme': 0, 'HvInputConfig': 0, 'HvInput': 0, 'DhwStorageTemperature': 0.0, 'HpSystemResistor1': False, 'HpSystemBoostDhw': False, 'AuxOutput1': 0, 'AuxOutput2': 0, 'DhwTimeProgComfortTemp': {'min': 0.0, 'max': 0.0, 'value': 0.0, 'prevValue': 0.0, 'step': 0.0}, 'DhwTimeProgEconomyTemp': {'min': 0.0, 'max': 0.0, 'value': 0.0, 'prevValue': 0.0, 'step': 0.0}, 'DhwModeStandard': 0, 'DhwModeAdvanced': 0, 'DhwMode': 0, 'AuxOutput3': 0, 'AuxOutput4': 0}, 'isEm20': False, 'hasTwoCoolingTemp': False, 'mode': 1, 'allowedModes': [0, 1, 2, 5], 'outsideTemp': 2.0, 'holidayEnabled': False, 'holidayUntil': '0001-01-01T00:00:00', 'dhwTemp': {'min': 40.0, 'max': 65.0, 'value': 45.0, 'prevValue': 0.0, 'step': 0.0}, 'flameSensor': False, 'dhwDisabled': False, 'zone': {'setpoints': {'comfort': 0.0, 'reduced': 0.0, 'coolComfort': 0.0, 'coolReduced': 0.0}, 'mode': {'allowedOptions': [0, 2, 3], 'value': 3}, 'comfortTemp': {'min': 10.0, 'max': 30.0, 'value': 20.5, 'prevValue': 0.0, 'step': 0.0}, 'desiredTemp': 20.5, 'roomTemp': 20.6, 'derogaTemp': {'min': 10.0, 'max': 30.0, 'value': 0.0, 'prevValue': 0.0, 'step': 0.0}, 'derogaEnabled': False, 'derogaUntil': None, 'heatRequest': False, 'heatRequestAir': False, 'antiFreezeTemp': 5.0, 'fireplaceEnabled': False, 'fireplaceUntil': None, 'pilotOn': False}, 'isCoolingSupported': False, 'isCoolingOnlySupported': False, 'isHeatingSupported': True, 'isHpSystem': False, 'isHybridSystem': False, 'heatingPumpResistorOn': False, 'dhwStorageTemp': 48.0, 'dhwBoilerPresent': True, 'heatingPumpOn': False, 'heatingPumpBoostDhw': False, 'quietMode': False, 'dhwReadOnly': False, 'hasDhwStorageProbe': True, 'weather': 4, 'remoteControl': {'requestedOn': 0, 'isAccepted': False, 'expiresAfterMinutes': 0}, 'flameForDhw': False, 'isVmcOn': False, 'isBoostVmcOn': False, 'dehumidifyRequest': False, 'extraVentilationRequest': False, 'dhwTimeProgComfortTemp': {'min': 40.0, 'max': 65.0, 'value': 45.0, 'prevValue': 0.0, 'step': 0.0}, 'dhwTimeProgEconomyTemp': {'min': 10.0, 'max': 45.0, 'value': 40.0, 'prevValue': 0.0, 'step': 0.0}, 'dhwMode': 1, 'dhwTimeProgSupported': True, 'dhwTimeProgComfortActive': True, 'isHvInputOff': False, 'completionToken': '', 'bmsActive': False, 'pilotSupported': True, 'cascadeSystemType': 0, 'dhwModeNotChangeable': False}

Yes, I would like to intergate it somehow with openhHab.
Firstly I will start with presentation data as read only. Next step could be to send some commands :)

Note that it takes usually around 20 seconds just for the first request ...
This was the point!
I have added _ariston_data + the loop with time.sleep(60) and 2nd iteration was already successful!

1.0.28
False
False
{}
1.0.28
True
True
{'__tmpEm20': {'HydraulicScheme': 0, 'HvInputConfig': 0, 'HvInput': 0, 'DhwStorageTemperature': 0.0, 'HpSystemResistor1': False, 'HpSystemBoostDhw': False, 'AuxOutput1': 0, 'AuxOutput2': 0, 'DhwTimeProgComfortTemp': {'min': 0.0, 'max': 0.0, 'value': 0.0, 'prevValue': 0.0, 'step': 0.0}, 'DhwTimeProgEconomyTemp': {'min': 0.0, 'max': 0.0, 'value': 0.0, 'prevValue': 0.0, 'step': 0.0}, 'DhwModeStandard': 0, 'DhwModeAdvanced': 0, 'DhwMode': 0, 'AuxOutput3': 0, 'AuxOutput4': 0}, 'isEm20': False, 'hasTwoCoolingTemp': False, 'mode': 1, 'allowedModes': [0, 1, 2, 5], 'outsideTemp': 2.0, 'holidayEnabled': False, 'holidayUntil': '0001-01-01T00:00:00', 'dhwTemp': {'min': 40.0, 'max': 65.0, 'value': 45.0, 'prevValue': 0.0, 'step': 0.0}, 'flameSensor': False, 'dhwDisabled': False, 'zone': {'setpoints': {'comfort': 0.0, 'reduced': 0.0, 'coolComfort': 0.0, 'coolReduced': 0.0}, 'mode': {'allowedOptions': [0, 2, 3], 'value': 3}, 'comfortTemp': {'min': 10.0, 'max': 30.0, 'value': 20.5, 'prevValue': 0.0, 'step': 0.0}, 'desiredTemp': 20.5, 'roomTemp': 20.6, 'derogaTemp': {'min': 10.0, 'max': 30.0, 'value': 0.0, 'prevValue': 0.0, 'step': 0.0}, 'derogaEnabled': False, 'derogaUntil': None, 'heatRequest': False, 'heatRequestAir': False, 'antiFreezeTemp': 5.0, 'fireplaceEnabled': False, 'fireplaceUntil': None, 'pilotOn': False}, 'isCoolingSupported': False, 'isCoolingOnlySupported': False, 'isHeatingSupported': True, 'isHpSystem': False, 'isHybridSystem': False, 'heatingPumpResistorOn': False, 'dhwStorageTemp': 48.0, 'dhwBoilerPresent': True, 'heatingPumpOn': False, 'heatingPumpBoostDhw': False, 'quietMode': False, 'dhwReadOnly': False, 'hasDhwStorageProbe': True, 'weather': 4, 'remoteControl': {'requestedOn': 0, 'isAccepted': False, 'expiresAfterMinutes': 0}, 'flameForDhw': False, 'isVmcOn': False, 'isBoostVmcOn': False, 'dehumidifyRequest': False, 'extraVentilationRequest': False, 'dhwTimeProgComfortTemp': {'min': 40.0, 'max': 65.0, 'value': 45.0, 'prevValue': 0.0, 'step': 0.0}, 'dhwTimeProgEconomyTemp': {'min': 10.0, 'max': 45.0, 'value': 40.0, 'prevValue': 0.0, 'step': 0.0}, 'dhwMode': 1, 'dhwTimeProgSupported': True, 'dhwTimeProgComfortActive': True, 'isHvInputOff': False, 'completionToken': '', 'bmsActive': False, 'pilotSupported': True, 'cascadeSystemType': 0, 'dhwModeNotChangeable': False}

Yes, I would like to intergate it somehow with openhHab.
Firstly I will start with presentation data as read only. Next step could be to send some commands :)

Integration was written to constantly attempt to restore the connection (if too many connection errors it will reattempt login, after few connection issues it increases delays between retries to reduce overload chances). It is common to get events due to boiler network issues, Ariston server issues, if whole chain is "overloaded" (can result in response codes in 500 and above). For the third I have created polling rate used during initiation. If it is increased (e.g. 1.2) all waiting timers and delays to reduce stress on the system.

Integration was written to constantly attempt to restore the connection (if too many connection errors it will reattempt login, after few connection issues it increases delays between retries to reduce overload chances). It is common to get events due to boiler network issues, Ariston server issues, if whole chain is "overloaded" (can result in response codes in 500 and above). For the third I have created polling rate used during initiation. If it is increased (e.g. 1.2) all waiting timers and delays to reduce stress on the system.


fix(setuptools): support build type set in toml

Fix for #496.

Now that you are at it, could you fix "-" -> "_" in the documentation? [link]

Fixed, thanks. Turns out it was a bug in our sphinx extension for making the tabs.


az k8s-extension create fails with error: ModuleNotFoundError: No module named 'azure.mgmt.relay'

If the az k8s-extension create ... command fails with the following error:
ModuleNotFoundError: No module named 'azure.mgmt.relay'
Then check and update k8s-extension:
az extension list
az extension add --upgrade --name k8s-extension
Ref: https://github.com/Azure/azure-cli/issues/27357
[I started seeing this error several months after my first successful AP5GC install.  I checked my k8s-extension version and it was running  1.3.3.  After updating to 1.5.2, the az k8s-extension create command started working again].
@robswain - can we add this command to section 3 "Prepare your shell environment":
az extension add --upgrade --name k8s-extension
Thanks
Rob

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 510df50e-7159-fc3c-54a2-3ac53548198c
Version Independent ID: 1ef7e35d-0cb4-9b03-868f-8dce0cfbbda5
Content: Commission an AKS cluster - Azure Private 5G Core
Content Source: articles/private-5g-core/commission-cluster.md
Service: private-5g-core
GitHub Login: @robswain
Microsoft Alias: robswain

@robertstarling
I've delegated this to @robswain, a content author, to review and share their valuable insights.

Thanks for raising this Rob. There's currently a note that you'll be prompted to add this and the customlocation extension if they're not already installed, but it seems a good idea to make sure users are on the latest versions. I think it's also just simpler to include the commands in the procedure. So I've added the add/upgrade command for both extensions and deleted the note. Should be live later today.
Thanks,
Rob
#please-close

Excellent, thanks Rob!


Add setup documentation for Alpine Linux

Adds documentation for setting up bevy on Alpine Linux and its derivatives.
It contains instructions on installing the required packages and also fixing runtime errors.

Added the blank lines, as requested.


Run rustfmt

/cc @nrc
Some of this is better, some of this is worse, but a 38k loc codebase is a good test for rustfmt.

First, thanks a lot for doing this, @steveklabnik ! I've been meaning to do it, but never got round to it.

HOWEVER, the bigger problem is that I have #53 almost ready and it would conflict with this PR all over the place. Would you possibly have the patience to re-run rustfmt after I merge #53 ? It would make my life a lot easier and I'd be happy to go through it  again.
If that would be too time consuming for you, could you at least drop src/game/level.rs and src/game/light.rs from this PR since those would probably be the biggest conflicts.
I'm hoping to get to #53 when I get back from work today, there's just one last niggling bug (the world is darker throughout) that I wasn't able to squash yesterday.

So, I'm totally fine with running it again after. However, you'd have to review again... I'm okay with that if you are.
Rustfmt is also configurable, so changing those settings might help too?
I'm willing to do whatever.

Great, thanks a lot! Definitely happy to review again.
I'd like rust-doom to be formatted in whatever way is "standard" rather than configuring it to my own tastes. If it's good enough for rustc, then it's good enough for me :)

Cool, I'll just give this a close, and ping me after that PR lands.

Hey @steveklabnik ! #53 is merged, so whenever you feel like redoing the rustfmt, I'll be happy to review it, thanks!


Fix pagination

Problem:
Pagination is not showing up
Solution:
Pagination was being created properly but then dropped in favor of an
empty version. Save the pagination on the context so it can be accessed
later and not reset.
Issue: https://github.com/rancher/rancher/issues/13817

LGTM


Spent an hour trying to figure out why the Twig example returns an empty array:

{% set sizes = [34, 36, 38, 40, 42] %}
{{ sizes|filter(v => v > 38) }}

Any workarounds (other than editing the package code)?

https://twitter.com/TimberWP/status/1204121465903300608

Related: https://github.com/timber/timber/issues/2010, with a suggested solution in https://github.com/timber/timber/issues/2010#issuecomment-502896508.


Feature request: support for file path

Right now, when doing a new file or new folder we cannot add a full path.
I think it would be a very neat to allow a full path (probably just supporting the "/" would be enough) when creating a new file.
For example:

the  src/ folder would be created if it does not exist and used as the path of the file. (This was one of my favorite Sublime plugins)
Also, creating a folder seems to have another command to have new new file, which might not be needed. For example, the following "new item" could create a folder (as it ends with "/")

Merging the "new file" and "new folder" with this feature will really make creating new file structure much more efficient. This will only save some few seconds per operation, but will bring much satisfaction.
(This was one of my top Sublime Text plugins, and would fit perfectly in the current default VSCode new file UI)

This issue has already been reported. Please use the search function next time before reporting an issue and/or this time if you are curious about the progress of the issue.

@bpasero Sorry, I did try to search multiple time, but did not manage to find the one about this specific feature. Glad to hear it has been already recorded.


Update dependencies and github workflows

Description
If implemented workflows will use go1.20.x.
Update of all needed dependencies. There is a breaking change on go-github which introduce its own timeStamp struct.

"github.com/google/go-github/v52/github"

Test results

Codecov Report
Patch coverage: 100.00% and project coverage change: -3.42 :warning:

Comparison is base (f57ef5c) 59.48% compared to head (6063f55) 56.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   59.48%   56.07%   -3.42%
==========================================
  Files          44       52       +8
  Lines        3019     4535    +1516
==========================================
+ Hits         1796     2543     +747
- Misses       1038     1569     +531
- Partials      185      423     +238

Impacted Files
Coverage Δ

github/auth.go
70.96% <ø> (ø)

github/client.go
76.08% <ø> (ø)

github/client_organization_teams.go
0.00% <ø> (ø)

github/client_repositories_org.go
70.23% <ø> (ø)

github/client_repository_branch.go
100.00% <ø> (ø)

github/client_repository_commit.go
70.00% <ø> (ø)

github/client_repository_deploykey.go
0.00% <ø> (ø)

github/client_repository_file.go
59.45% <ø> (ø)

github/client_repository_pullrequest.go
71.69% <ø> (ø)

github/githubclient.go
40.88% <ø> (ø)

... and 6 more

... and 54 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Transformationsv2 docs

Description
Added transformations module to docs.
Added docstrings with examples to all transformations except HeighToVolume - need input to explain details of what this transformation does
Checklist:

[ ] Tests added/updated.
[ ] Documentation updated.
[ ] Changelog updated in CHANGELOG.md.
[ ] Version bumped. If triggering a new release is desired, bump the version number in pyproject.toml per semantic versioning.

How can I define a CogniteClient in examples without getting this error in the build tests?
https://github.com/cognitedata/power-ops-sdk/actions/runs/6421038797/job/17434484083?pr=223#step:5:177


action: prevent globbing with double quotes

This patch adds double quotes on variables to prevent globbing and prevent evaluation errors such as:
line 1: [: =: unary operator expected

It also add consistency on bash string equality comparison by using ==
operator instead of =.
Signed-off-by: Luís Ferreira<EMAIL_ADDRESS>
Since this is behaving "good" by accident, please double check if this doesn't break any specific use-case of this action. I recommend changing this to standalone scripts and passing GitHub variables by argument and parse them using something like POSIX getopt. See https://man7.org/linux/man-pages/man1/getopts.1p.html

CC @lolgab

@ljmf00: "==" is not POSIX compliant and also it won't make any difference in single brackets.
Still to be usefull it should be inside [[ ]] instead of [ ]

@ljmf00: "==" is not POSIX compliant and also it won't make any difference in single brackets. Still to be usefull it should be inside [[ ]] instead of [ ]

The usage of non-POSIX complaint features is not a problem here, since the action uses the bash shell, and that feature is specified in bash. I can't also see that as an argument since the existing code uses bash-specific features after all.
As the commit message suggested, these changes were to improve consistency in one way or another and not about the usefulness of equality/pattern matching in bash, as a feature. Arguing about the decision of making it consistent with == instead of = is that it makes it more readable/less strange among other languages syntax.

#68

What do you mean?


content_types field missing from extras/tags serializer

Environment

Nautobot version: 1.5.1-py3.9 (Docker)
Python version: 3.9
Database platform, version: Postgres 14
Middleware(s):

Steps to Reproduce

requests.post("https://nautobot/api/extras/tags/", headers=headers, json=data, verify=False)
data =

{
    "name": "phx-dc-access",
    "color": "c7ea80",
    "content_types": [
        "dcim.device",
        "ipam.vlan"
    ],
    "slug": "phx-dc-access"
}

Expected Behavior
Tag is created with content types limited to dcim|device & ipam|vlan

Observed Behavior
Tag is created with all content types.
First noticed this using the Nautobot Ansible Collection, confirmed using requests.
Also I don't see the content_types attribute in the swagger schema documentation for extras/tags

The content_types are only supported when using the REST API version 1.3 and later, and if no API version is specified (as appears to be the case above) the API defaults to version 1.2 in all Nautobot 1.x versions. Unfortunately Django REST Framework just silently discards data that it doesn't understand/support - the content_types field doesn't exist in API version 1.2, so it's being ignored in the above case.
See https://docs.nautobot.com/projects/core/en/stable/rest-api/overview/#versioning for more details, but in short - please try adding an Accept: application/json; version=1.5 header to your request and see if it resolves this issue. (Similarly, try adding ?api_version=1.5 to the URL for the Swagger docs and the content_types field should then appear.)

Woops, I missed that, thanks


Could not find a connection between 'odom' and 'base_link'

Robot Model
Turtlebot4 Standard
ROS distro
Humble
Networking Configuration
I do not know
OS
Ubuntu 22.04
Built from source or installed?
Built from Source
Package version
le-turtlebot4-simulator
Package: ros-humble-turtlebot4-simulator
Status: install ok installed
Priority: optional
Section: misc
Installed-Size: 41
Maintainer: rkreinin<EMAIL_ADDRESS>Architecture: amd64
Version: 1.0.2-1jammy.20240518.065938
Depends: ros-humble-turtlebot4-ignition-bringup, ros-humble-turtlebot4-ignition-gui-plugins, ros-humble-turtlebot4-ignition-toolbox, ros-humble-ros-workspace
Description: TODO: Package description
Expected behaviour
I want to run the simulation described in https://turtlebot.github.io/turtlebot4-user-manual/software/turtlebot4_simulator.html. I start the simulation with the command "ros2 launch turtlebot4_ignition_bringup turtlebot4_ignition.launch.py nav2:=true rviz:=true world:=maze". This will open an ignition simulation window and an Rviz window. When I hit the play button I should see a map in Rviz and the Lidar measurements.
Actual behaviour
As I go through the process, the windows open as expected. Then I click play on the simulator and nothing happens in Rviz. There is no map or lidar readings.
Error messages
[controller_server-47] [INFO] [1717445412.870737451] [local_costmap.local_costmap]: Timed out waiting for transform from base_link to odom to become available, tf error: Could not find a connection between 'odom' and 'base_link' because they are not part of the same tree.Tf has two or more unconnected trees.

To Reproduce
Follow in instructions in the tutorial for the simulator. Specifically, those that install from source. Then run the simulator as instructed.
Other notes
No response

Hello @neubej01 ,
Thank you for reaching out on the Turtlebot4 Simulator Github page. With regards to this matter we have a couple questions we would like clarified:

Since you have built from source, would it be possible to provide the hash that you have built. You can use the command git rev-parse HEAD command to determine the hash.
Would it be possible to provide the motivation for installing the simulation from source?
Are you able to switch/test out a debian installation of the simulator? If so, please do so and let us know if the same error occurs.
Looking forward to hearing from you soon.
Best Regards,
Saif

Hello,
This issue is being closed due to inactivity. If you are still experiencing the issue, feel free to reopen this ticket when you are ready to continue the troubleshooting process.
Best Regards,
Saif


Removed peer dependency's rule

closes #9

Thanks for the fix

This is usefull, but we need to bump the version number, as npm i phosphor-vue@next, still pulls the old version i think.
Can we bump and push to npm please?


Limit EC2 instance choices based on region and AZ

Generally, not all instance types, particularly GPU instances, are available in each AZ. As such, when a user creates a queue, there is no check to confirm if a selected EC2 instance class is available in the selected subnet.
Also, there is no check to see if instances are available at a region level. Example: create a cluster in us-east-1, but HPC6a is listed as an option.

https://github.com/aws-samples/pcluster-manager/pull/78

Resolved in latest deploy.


Session Initialization Error

Even tough I have 64 characters in the session-auth-key.txt-file, I get the following error:

I deploy locally with goapp serve, but that shouldn't be a problem?!

Make sure you do not have any whitespace or newlines at the end of the string in this file.  Aka, make sure there isn't a newline entered automatically by your text editor.  The file should be one line long.  Make sure you check the "session-encrypt-key.txt" as well.  Let me know what happens.
I should probably put a strings.TrimSpace() in the code when the keys are read from file to remove this issue from occuring.

That's funny, I wanted to show you the files over a gist, downloaded them, copied them into the config folder and they worked. Seems a problem with vim. But why?! No idea. Vim shouldn't add something to the file that doesn't belong there...

I've seen that same thing happen before but with other editors.  I think the editors "add" the extra blank line to signify EOF.  I have updated the code to add the strings.TrimSpace() so this doesn't occur in the future.


Bothside

The person joined can aslo send files

@sankarvinayak Hey! I'll take a look at this ASAP! :D


Question

Hello
I've chosen to develop a library utilizing the provided source code, aiming for compatibility with Node.js and JavaScript. Before proceeding, I'd like to confirm whether I have the necessary permissions to create this library.
thank you for your answer
With regards

See https://github.com/tdlib/td/blob/master/LICENSE_1_0.txt.


Fix typo in Form.handlePasswordChange().

In options.js the handlePasswordChange method had a typo causing the password input to be set as the desk. The PR fixes the typo.

Great catch. Thanks @carlbaron!


Changing return types for DeleteIfExists to Boolean

Description
Changing return types from Void to Boolean for DeleteIfExists methods and some CreateIfNotExists methods that are returning Response.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

/azp run java - storage - ci

/azp run java - storage - ci

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-storage-blob


Fabulously Optimized Incompatablity

A mod in FO modifies chunk rendering which disables the block render modification at https://github.com/DFOnline/CodeClient/blob/v86/src/main/java/dev/dfonline/codeclient/mixin/render/MChunkRendererRegion.java

Automatic plot sizing is also in this, so that also breaks.

Fabulously Optimized is just a modpack so it has nothing to do with this

The actual affecting mod should be searched

I don't know which mod, it's just one in FO

The issue is sodium

I think you added the label to the wrong issue :)

Fixed automatic plot sizing. Might drop the hiding. I can't find a point before sodium which I can mixin to any get block.

stale and all incompatible features are gone


Exception on PHP 7.2.19 Sf4.4.40 C4.9.28 post-update-cmd

hello I've got an exception after install the bundle in a new fresh contao 4.9 environment:
Parse error: syntax error, unexpected 'fn' (T_STRING), expecting :: (T_PAAMAYIM_NEKUDOTAYIM) in C:\laragon\www\contao409\vendor\markocupic\contao-bundle-creator-bundle\src\Subscri
ber\Maker\AddStandardTagsMaker.php on line 62

at the given location there is a statement that php 7.2 obviously can't execute. a closure with static fn and an arrow statement , if i hack that everything works correctly. Is this an oversight?

https://github.com/markocupic/contao-bundle-creator-bundle/blob/0f6cafbbdaee2036175bc898b309060ddea5caa8/composer.json#L28


Bleuscore from torchmetric give different results compare to NLTK

🐛 Bug

To Reproduce
Bleu's score from torchmetric and nltk is different.
I can only get the same result if k = 1. Otherwise, it returns a different Bleu score
Code sample

from nltk.translate.bleu_score import sentence_bleu
from torchmetrics.functional import bleu_score

k = 3
predictions = "I am handsome and i love animals"
truth = "pad I am smart and i love animals pad"

def compute_blue(preds: str, answers, k: int):

    weights = [0] * 4
    weights[k - 1] = 1
    # need to tokenize sentence first for nltk bleu
    preds = preds.split(" ")
    answers = [a.split(" ") for a in answers]
    return sentence_bleu(references=answers, hypothesis=preds, weights=weights)

# torchmetric bleu
print("Bleu from torchmetrics: ", bleu_score(preds=predictions, target=[truth], n_gram=k))
# nltk bleu
print("Bleu from nltk: ", compute_blue(predictions, [truth], k=k))

#  output k=3
# Bleu from torchmetrics:  tensor(0.4595)
# Bleu from nltk:  0.3005909172301144
# output k=1
# Bleu from torchmetrics:  tensor(0.6441)
# Bleu from nltk:  0.6441233940645307

Expected behavior
I would expect the same bleu score from torchmetric and nltk
Environment

TorchMetrics version: 0.9.0
nltk: 3.4.5
Python: 3.7
Linux

Additional context

cc: @stancld is probably the best to answer this but from out code I can tell this is the comparison function we use for our implementation:
https://github.com/PyTorchLightning/metrics/blob/3856db48f65c8c7cd17bda4fceaa3584ceeab593/tests/text/test_bleu.py#L30-L35
where corpus_bleu comes from:
from nltk.translate.bleu_score import corpus_bleu

Hello @icedpanda, thanks for raising this issue. The difference lies in the fact that torchmetrics uses a uniform weights 1/n for weighting n-gram BLEU score. That means if you set weights for nltk like [1/3, 1/3, 1/3, 0], you obtain the same results.
Question for @Borda & @SkafteNicki -> Don't we wanna allow to set weights manually, with the default behaviour following the current implementation?

@stancld I would be fine with adding a new argument:
weights: Optional[List[float]] = None

where None is uniform weight or else the user can provide a list of floats.


Calendar-Events-patch not documented and

The functions that control patching of calender events do not seem to be complete / documented. Can you update the documentation on this?

I'm not exactly sure what you're referring to. The calendar patch is supported (see here and here). We don't have specific documentation for every single call, but the API is formulaic. You should be able to call it like this:
$client = new Google_Client;
$client->useApplicationDefaultCredentials();
$event = new Google_Service_Calendar_Event;
$event->setEtag('foo'); // presumably make some change to patch
$calendar = new Google_Service_Calendar($client);
$response = $calendar->events->patch($calendarId, $eventId, $event);

Also, if you want to just make an authenticated HTTP request to the API directly (without using the generated classes) this is always possible as well:
$client = new Google_Client;
$client->useApplicationDefaultCredentials();
$http = $client->authorize();
$url = sprintf('https://www.googleapis.com/calendar/v3/calendars/%s/events/%s', $calendarId, $eventId);
$patchBody = [
   'etag' => 'foo'
];
$response = $http->patch($url, ['body' => $patchBody]);

Where can i find the google calendar documentation for googleapis php, i can't find this


metrics: Fix FIO test to remove the volume created

Currently while running the Fio test creates a volume in the host,
however, the script should remove the volume at the end of the test.
Fixes #930
Signed-off-by: Gabriela Cervantes<EMAIL_ADDRESS>

@grahamwhaley the ci-metrics failed because of network-bwd-host-contr-receiver as it says that CVS file not found

@grahamwhaley changes applied


fix($browser): prevent infinite $digest from no trailing slash in IE9

fix($browser): prevent infinite $digest from no trailing slash in IE9
This fix prevents IE9 from throwing an infinite $digest error when the user accesses the base
URL of the site without a trailing slash. Suppose you owned http://www.mysite.com/app
and had an Angular app hosted in a subdirectory "app". If an IE9 user accessed
http://www.mysite.com/app infinite $digest errors would be thrown on the console, but the app
itself would eventually resolve properly and work fine. Now the infinite $digest errors will
not be thrown.
Closes #11439

Is there anything I need to do to aid in the lifecycle of this issue, @Narretz?  It'd really be preferable if this was included in a 1.3.x release (you'll notice the changes are actually to the v1.3.x branch) due to the overhead of retesting our entire app to move to 1.4, if the powers that be are even okay with moving to something that's not yet marked as the stable branch. :)

Ok, so it would be good if this applies to 1.4.x, too. Do you think you could apply the tests to 1.4.x and see if they pass?

I'm moderately certain that the codepath hasn't changed significantly, but
I can certainly give it a try.
On Tue, Apr 28, 2015 at 3:56 PM, Martin Staffa<EMAIL_ADDRESS>wrote:

Ok, so it would be good if this applies to 1.4.x, too. Do you think you
could apply the tests to 1.4.x and see if they pass?
—
Reply to this email directly or view it on GitHub
https://github.com/angular/angular.js/pull/11675#issuecomment-97204110.

With just the new tests in place, 1.4.x fails the 6 tests I would expect it to fail, and it succeeds in the 6 tests I would expect it to succeed.  So this issue definitely persists into 1.4.x.

And with merged identical changes made in 1.4.x, the new tests all pass.

At the risk of potentially being annoying here, is there a possible ETA for this fix to land (or be reviewed, fixed up, and then land)?  I'm trying to figure out if I should be forking from 1.3.15 locally for our app since we have a public release coming up in about 5 weeks.  Ah, corporate life... :)

I am working on it @hamfastgamgee - sorry about the delay. Give me a few days.

No worries at all.  Let me know if there's anything I can help with.  (I did do the local fork for our app, just in case. :) )

Anything more I can help with here?  Looking at some other checkins, I'm wondering if the $browser helper function I added should be $$ prefixed and get a no-op entry in angular-mocks, but I don't really want to do that until I get feedback about the overall approach (which is basically creating an end condition to break out of an infinite loop).

Agh, I got pulled into ng2 doc generation stuff and haven't had a chance to look at this yet. It is the first item after we get the next RC release out.

Now that rc.2 is out, anything I can do to assist here?  (Let me know if I need to just give this a while.  Like I said, I have my local workaround, but I know my management would prefer us not to be forked if possible. :) )

Thursday morning (GMT). It's in the diary

Looking at this now.
My first comment is that this bug is not really related to ngRoute, so the tests should be inside $locationSpec.js and not require ngRoute to display the problem.

I don't disagree in principle, but I have been entirely unable to find a way to trigger it without ngRoute coming into play.  The only thing I can think of is maybe wiring up a manual $locationChangeSuccess watcher that basically emulates ngRoute.  Thoughts?

OK, I really want to get a reproduction (in unit test) of this without ngRoute. I guess it will involve setting up a $locationChangedSucess event that changes the path right?

While I'm working on that: Do you want the new $browser method to use the $$ prefix?

Okay, tests that are relevant have been moved to locationSpec.js.  (I removed four tests because they were really just exercising different possible ngRoute configurations, but that's not, as you said, the real issue.)  Let me know if you need me to change to use the $$ prefixing, but I think this should be more in line with what you were hoping for.

$browser is a private service anyway so we don't need to prefix the methods.
A few random thoughts:

Why do we need to mock out the "mock" browser?
I am a bit concerned that commenting out the fix doesn't actually trigger an infinite digest which suggests that we are testing the fix rather than the problem.
Finally, my last worry is that I feel that there is something fundamentally wrong with the way that $browser and $location interact and that while this fix might work, it might not be getting to the root cause.

Commenting out the changes to $locationWatch do cause the infinite $digest bug to fire again.  I specifically tested that while I was porting the code.
The existing mock browser actually doesn't expose the bug, since it doesn't use that caching variable in $browser.url() that is the real problem.
And yes, I completely agree that this is a band-aid rather than a real root cause fix.

I initially tried just setting that caching variable more often, and a bunch of other tests started failing.  This was the only way I could find to "solve" the issue that always succeeded.  I suppose potentially we could check before/after values inside the $evalAsync in $locationWatch and fire off the reset function if we detect that a watcher of $locationChangeSuccess has changed the value.

@hamfastgamgee - thanks for all this work. I am going to take another look today.

And thank you for taking a look at it.  And of course, "correct" always
beats "fast".
On Fri, May 22, 2015 at 6:25 AM, Pete Bacon Darwin<EMAIL_ADDRESS>
wrote:

@hamfastgamgee https://github.com/hamfastgamgee - thanks for all this
work. I am going to take another look today.
—
Reply to this email directly or view it on GitHub
https://github.com/angular/angular.js/pull/11675#issuecomment-104627391.

I'm currently trying to see if I can update angular-mocks to have its mock browser act more like the actual $browser, and while it's certainly possible that I am messing something up, the volume of tests that seem to be throwing infinite $digest errors from just making the mock more like the real one is a bit concerning.  Makes me think there are a lot more edge cases currently in the code that suffer from infinite $digest problems than just the ones I was targeting.  I'm trying to see if I can clear all of that up, because if I can, I think the fix is likely to make this substantially more robust than it was.  (Which doesn't mean what I have currently submitted here is "wrong".)

@hamfastgamgee - I have provided a unit test in here #11935. Please take a look

Okay, in this latest version, angular-mocks is updated to have the mock browser's url setter actually act like the real $browser.url().  This includes use of the caching variable and setting it only when the sameBase check is false, which is the actual underlying root cause of this issue.  That caused a bunch of other tests to break with the original "targeted only at HTML5 non-history mode" check, so I have made the code run in more circumstances.  All of the tests succeed now, running through a mock browser that actually mocks $browser. :)
I also included the unit test from #11935 at the bottom, porting it to use the existing initBrowser() function that is already in locationSpec.  (Curiously, if I didn't do that and just pulled over the mockBrowser() function, it threw an error trying to set the length of Browser.pollFns[].  Don't know why.)  I'm totally cool with removing my tests, or maybe expanding your test to cover more cases just to make sure we have coverage of all the cases (HTML5 vs not, and history browser vs not).  But all of them pass at the moment, which is the important thing.
@petebacondarwin - Can you take another look?

Or it'll bomb on IE9 for some reason.  Ugh...

Well, I have a version that satisfies all the tests, but I'm not entirely sure if I'm happy with the mock browser, so I absolutely welcome feedback.  In particular, passing self.$$url into the listener() callback in onUrlChange is not what the actual $browser does (it would pass what I call "currUrl"), but if I don't pass self.$$url there, 3-5 tests bomb that I'm pretty sure would not actually bomb in real world scenarios.  In any case, I think it's ready for re-review (and possibly more fixes from @petebacondarwin). :)

@hamfastgamgee - thanks again for the work you are doing on this. Unfortunately, by mocking out the browser like this we are back to the situation where we are not actually testing the invalid behaviour. If you comment out the "fix" in $location, the last test in locationSpec.js, i.e. the one that I wrote passes, which it should not, given that in real life this would fail. So somewhere in the mock browser we are hiding the real functionality that needs to be tested.

But, if we include the version from my PR as-is then this does indeed fail with infinite-digest error.
I think for the time-being I would be happy with this fix and the tests from your PR and mine to cover ourselves. I would like to dig further into a cleaner way for $browser and $location to ensure that they don't get trapped like this.

Works for me. I really only care about my original case anyway.
Sent using Boxer
On May 24, 2015 3:10 PM, Pete Bacon Darwin<EMAIL_ADDRESS>wrote:But, if we include the version from my PR as-is then this does indeed fail with infinite-digest error.
I think for the time-being I would be happy with this fix and the tests from your PR and mine to cover ourselves. I would like to dig further into a cleaner way for $browser and $location to ensure that they don't get trapped like this.
—Reply to this email directly or view it on GitHub.

I spoke with @IgorMinar last night about this. We feel that we really ought to be able to fix this at the root rather than just catching the start of an infinite digest. I am going to look into it again this week. Sorry @hamfastgamgee. Also we should have an E2E test that checks the fix against real browsers on top of any unit tests.

I'm totally okay with a real root cause fix.  (Like I said at one point, I tried that originally and couldn't riddle it out without breaking a bunch of other tests, which is why I arrived at this "good and working is better than 'perfect' and potentially broken" solution.)  We already had to work around the issue by using my patch in our release last weekend, so the immediate urgency for me is lessened.

I do wonder, though, from what I found when trying to update the mock browser to reflect what the real $browser was actually doing using the reloadLocation variable, whether there are a bunch of other potential infinite digest scenarios there.  I still think having a mock browser that's more reality-based would be a good thing. :)

@hamfastgamgee - I am sorry that this is taking so long and that you had to patch your release. We will get to the bottom of this.

No worries. :)  Let me know if there's anything I can do to help.
On Wed, Jun 10, 2015 at 6:40 AM, Pete Bacon Darwin<EMAIL_ADDRESS>
wrote:

@hamfastgamgee https://github.com/hamfastgamgee - I am sorry that this
is taking so long and that you had to patch your release. We will get to
the bottom of this.
—
Reply to this email directly or view it on GitHub
https://github.com/angular/angular.js/pull/11675#issuecomment-110712180.

I think I have a better solution...
The problem appears to occur when we have triggered a reload (via replace()) that updates the reloadLocation but then before the reload happens we trigger another change to the URL that would not have triggered a reload if we had already reloaded. In this case, the $browser is cancelling its reloadLocation because it thinks that we will no longer reload.
So to be more explicit:

Navigate to http://my.server.com/Home
Because we are on IE9 this get rewritten (with replace()) to http://my.server.com/#/Home, which would cause a reload on IE9
The SuccessChangeHandler kicks in and then changes the $location.path to /, i.e. the URL gets changed to http://my.server.com/#/`.
Since http://my.server.com/#/Home -> http://my.server.com/#/ would not normally trigger a reload we don't update the reloadLocation, which gets stuck at http://my.server.com/#/Home
We get stuck in an infinite digest as the $location keeps trying to update the URL to http://my.server.com/#/ but failing because the reloadLocation is stuck at http://my.server.com/#/Home

This is why @hamfastgamgee's fix appears to work. When we see that we are in an infinite loop and there is a reloadLocation then we force it to change to the proper URL.
A better solution is simply to realize that we are updating a URL in $browser that is expected to cause a reload by changing the line at https://github.com/angular/angular.js/blob/v1.4.0/src/ng/browser.js#L150:
      if ($sniffer.history && (!sameBase || !sameState)) {
        history[replace ? 'replaceState' : 'pushState'](state, '', url);
        cacheState();
        // Do the assignment again so that those two variables are referentially identical.
        lastHistoryState = cachedState;
      } else {
        if (!sameBase) {
          reloadLocation = url;
        }
        if (replace) {
          location.replace(url);
        } else if (!sameBase) {
          location.href = url;
        } else {
          location.hash = getHash(url);
        }
      }

to
      if ($sniffer.history && (!sameBase || !sameState)) {
        history[replace ? 'replaceState' : 'pushState'](state, '', url);
        cacheState();
        // Do the assignment again so that those two variables are referentially identical.
        lastHistoryState = cachedState;
      } else {
        if (!sameBase || reloadLocation) {
          reloadLocation = url;
        }
        if (replace) {
          location.replace(url);
        } else if (!sameBase) {
          location.href = url;
        } else {
          location.hash = getHash(url);
        }
      }


Don't fail on ConfigMap

Addresses https://github.com/redhat-documentation/vale-at-red-hat/issues/326
This rule catches Camel and Pascal case terms in body text and suggests wrapping them in backticks mark up.

Won't pass until https://github.com/redhat-documentation/vale-at-red-hat/pull/330 gets merged.

I've totally reworked this, dropping all the Pascal case changes. This is more straightforward.


Stream data through Socket instead of serial

Hi, thanks for the nice program.
How about using it for plotting live data streamed through a socket connection?
The socket connection is between python and processing IDE.
Would you suggest on how to modify the code so that it can used for data received through socket?
Thanks...

Hi, pkr97.
I wrote a little web socket  client utility to connect to a web socket server and then stream whatever it receives to a serial port. You could use this with the Arduino serial monitor / plotter or sebnil's plotter with a few modifications. All you need is an ESP32 dev board to run this code. Maybe your python code could act as a web socket server for this little utility.
https://github.com/digamesystems/test_websocket_client
Cheers.


NVIDIA copyright?

Some files (in src/nv* folders) have

Copyright NVIDIA Corporation 2006 -- Ignacio Castano<EMAIL_ADDRESS>Copyright NVIDIA Corporation 2007 -- Denis Kovacs<EMAIL_ADDRESS>Copyright NVIDIA Corporation 2008 -- Ignacio Castano<EMAIL_ADDRESS>
and the similar. The files do not appear to have a separate license in them, nor instructions to reproduce those copyright notices in any other form.
Are those an external dependence from
https://github.com/castano/nvidia-texture-tools
https://github.com/castano/nvidia-mesh-tools
? Should I comply with the respective licenses of those projects in addition to the thekla_atlas' license or are those files re-licensed under the current thekla_atlas' license with the permission of NVIDIA?
The main problem is that while all of them appear to fall under the MIT license, but thekla_atlas asks only to include

Copyright (c) 2013 Thekla, Inc

, while nvidia-texture-tools asks to include:

Copyright (c) 2009-2017 Ignacio Castaño
Copyright (c) 2007-2009 NVIDIA Corporation

and the license file for the nvidia-mesh-tools is missing (the old location on code.google.com suggests MIT license, but doesn't specify the copyright notice in a separate file).
There was a brief mention of it in #2: "licensing information for... nv libs...", but the topicstarter didn't elaborate on that.

Both of the nvidia libraries are licensed under the MIT License that you can find here:
https://github.com/castano/nvidia-texture-tools/blob/master/LICENSE
Looks like the LICENSE file for the mesh tools was missing, the google code site used to specify that and provide a link to it, but that was lost on the migration. I've added it to the github project.
thekla_atlas is under the same MIT license. I've also added an ATTRIBUTION file that lists the projects that it depends on and their respective licenses.


Long error messages are displayed outside screen in console

Godot version:

Built from f11a1385054376bdc4cc01e6aa20d63508a5e6d4 with PR #15136.
OS/device including version:

Majaro Linux 17.1-rc2
Issue description:

When a long error message is logged to the console, it is impossible to read the whole content since the displayed tooltip is bigger than the screen size, as shown below:

Ideally, console should show the detailed content in a separate view, when the user selects a message from the list. It is especially important when the message contains a stacktrace information.
Steps to reproduce:
Write a code that throws a runtime exception. I tried it with C# project, so I'm not too sure if the problem persists with a GDScript project.

[x] I searched the existing GitHub issues for potential duplicates.

A new PR was proposed to fix this in #15272, but couldn't be merged eventually due to merge conflicts and the PR getting stale. It's up for a rebase if any contributor is interested.


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-30-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4841

Questions ?
Please refer to the Backport tool documentation


wezterm is syncing and shipping Gogh themes in nightly builds

I recently added some automation to sync the Gogh data and make all of the schemes available to wezterm.
That same automation generates previews of the schemes in wezterm's docs; you can see the _bash scheme at the top of this page as an example:
https://wezfurlong.org/wezterm/colorschemes/b/index.html
The schemes are available in nightly builds of wezterm and will be part of the next stable release.
Just letting you know in case you want to keep track of who is using what and where!

I believe that the new adjustments and standardization that have been made with the names and stuffs will be much better.
The following adjustments were made:

Now the source of truth is the "themes" folder, where each theme is in a .yml file.
All theme names should be in title case.
All colors are in uppercase for all themes.
One repeated theme was eliminated, and the names of a couple of Homebrew themes were adjusted.
A JSON file was created, which also serves as a source.

Additionally, each theme now has a hash which will not change. The hash is generated based on the colors used in the theme, so if a color is changed, the hash will also change accordingly. This hash can be used as an ID that will remain consistent over time.
The hashes are generated from the .yml files and included in the JSON file.
Thank you very much for considering this repository and including it in your project. I wish you the best of luck with it, and I truly hope it is a great success (I love programs made in RUST, too bad I am not a programmer myself :disappointed: ).


Can we get rid of the dependency on typecheck-decorator?

ciao, polypie does exactly what i'm looking for. unfortunately it doesn't with Python3.6:
Traceback (most recent call last):
  File "/home/user/dev/polypie/test_polypie.py", line 101, in test_typing_annotations
    self.assertEqual(f(120, [1, 2, 3]), 'Any, Sequence')
  File "/home/user/dev/polypie/polypie.py", line 62, in wrapper
    return _call_func(func_key, args, kwargs)
  File "/home/user/dev/polypie/polypie.py", line 44, in _call_func
    return typecheck(func)(*args, **kwargs)
  File "/home/user/dev/polypie/.tox/py36/lib/python3.6/site-packages/typecheck/decorators.py", line 26, in typecheck
    checker = fw.Checker.create(v)
  File "/home/user/dev/polypie/.tox/py36/lib/python3.6/site-packages/typecheck/framework.py", line 154, in create
    if predicate(annotation):
  File "/home/user/dev/polypie/.tox/py36/lib/python3.6/site-packages/typecheck/typing_predicates.py", line 155, in _is_tg_union
    return issubclass(annotation, tg.Union)
  File "/usr/lib/python3.6/typing.py", line 799, in __subclasscheck__
    raise TypeError("Unions cannot be used with issubclass().")
TypeError: Unions cannot be used with issubclass().

looking at the repo-activity and the code of typecheck-decorator, i'd say it'd be better if polypie implemented  the needed functionality itself.
i'd dig into this, but a short hint what polypie essentially expects from calling typecheck in _call_func would be very helpful.

Hi! Thanks for reporting the issue.
typecheck is only used to check typing annotations (e.g., def f(a: typing.Tuple[int, str])). This is a lazy and expensive solution. I'll see later what I can do.

It took a long time, but we finally got rid of typecheck-decorator… sort of. I've just released version 0.2.0 where typecheck-decorator has been replaced with typeguard. Yeah, just another external dependency, but at least it works fine with the latest Python versions (3.5-3.7).
In case you're still interested in the project, I've opened another issue to remove any external typechecker completely: https://github.com/un-def/polypie/issues/3


feat: improved error reporting for Kafka create command

This is a potential fix for #1057 . @wtrocki , @craicoverflow let me know if there are other ways to implement the error handling for this specific situation.

This is a problem which requires a global fix as opposed to just one command. let's chat about it in the issue.

@alexal I think we need to chat with the team about this as we need a good strategy for SDK's and CLI. I will put this PR on hold as we need more time to discuss that.

@wtrocki sure, keep me posted.

Closing this for now as there is no current solution.


RFC: adds e2e testing for 1-hello-world

DO NOT MERGE - this will need refactoring once we turn branches into directories
@remi @jeffmendoza PTAL

and see the passing travis build!!

closed in favor of #20


Starting with the latest version Midea Smart AC is not seeing my air conditioner

Hi,
Starting with this version of HA and  Midea Smart AC integration i can't see the air conditioner or his sensor

Core - 2024.9.1
Supervisor - 2024.09.1
Operating System- 13.1
Frontend- 20240906.0
Midea AC version - 2024.9.2
Can you please help with some ideas to fix it?

raised in error


chore: increase polling intervals

Codecov Report

Merging #48 (2d78665) into main (1555447) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #48   +/-   ##
=======================================
  Coverage   85.06%   85.06%
=======================================
  Files           9        9
  Lines         154      154
  Branches       26       26
=======================================
  Hits          131      131
  Misses         23       23

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1555447...2d78665. Read the comment docs.


config-linux: RFC 2119 wording for disableOOMKiller

The previous wording tiptoes between background docs about kernel behavior and runtime requirements, so it's not clear what the runtime is required to do or how you'd compliance-test runtimes.  The new wording uses MUST (NOT) wording for the various cases, so the runtime responsibilities are clear.
The implementation-defined case avoids specifying when:

The parent memory cgroup may have different values of oom_kill_disable, and
The runtime may or may not create a new memory cgroup for the controller (because of the “MAY attach the container process to additional cgroup controllers” language).

LGTM

while this is more direct, I feel the reason the tip-toeing was accomplishing the ambiguity of whether that means failing the runtime if the feature isn't present.

On Wed, Apr 05, 2017 at 07:08:33AM -0700, Vincent Batts wrote:

while this is more direct, I feel the reason the tip-toeing was
accomplishing the ambiguity of whether that means failing the
runtime if the feature isn't present.

My reading of the current compliance wording 1 is that there are
three cases:

compliant: satisfies all the MUST, REQUIRED, and SHALL requirements
for the platforms it implements.
non compliant: fails to satisfy one or more of the MUST, REQUIRED,
or SHALL requirements for the platforms it implements.
neither (we don't have a compact name for this): does not fail a
MUST-level requirement, but takes advantage of a legal out,
e.g. erroring out of ‘create’ with “I can't do that” 2 which makes
it impossible to test whether a deeper requirement (e.g. a
disableOOMKiller support MUST) is satisfied or not.

If that is also how the compliance folks read our compliance language,
then with this PR would mean that runtimes which did not support
disableOOMKiller would have to error out at ‘create’ with “I don't
support disableOOMKiller” and that such a runtime would fall into the
‘neither’ compliance case (assuming it didn't fail any other
MUST-level requirements).  I think that's appropriate (e.g. see
similar discussion in #472 and #476, where we decided against
“silently don't support”).  If, on the other hand, we want to allow
completely compliant runtimes which don't support disableOOMKiller, I
think the proper approach would be to pull that component out into a
separate protocol/platform 3.  So a runtime would get badged as:
Compliant with runtime-spec 1.0 protocols ‘linux’ and
‘disableOOMkiller’ on amd64.

The part of this I find irritating while reading it is that it re-references cgroupsPath over and over again.  IMO it's an OK change if we drop the last two lines.
I think if a config.json includes "disableOOMKiller": true and the kernel doesn't support it, that runtime should fail, which is exactly what If disableOOMKilleris set, the runtime MUST setoom_kill_disable to the appropriate value. will ensure (since the kernel will error out, causing the runtime to be unable to fulfill the requirement specified by the config).
I also don't think this is worth holding up 1.0 for -- this seems like a fine clarification to make in 1.1.0.

On Wed, May 10, 2017 at 09:33:17PM -0700, Tianon Gravi wrote:

The part of this I find irritating while reading it is that it
re-references cgroupsPath over and over again.

I think this is the wording that @crosbymichael and @mrunalp were
considering pulling out into some central location.  I'm happy to
rebase this PR after they land the generic wording for that.

I also don't think this is worth holding up 1.0 for -- this seems
like a fine clarification to make in 1.1.0.

Without something like this PR, there is no compliance testing for
disableOOMKiller.  So if we don't land it by 1.0, runtimes which
silently ignore disableOOMKiller could still be certified compliant.
I mentioned this (but maybe not for this PR?) in the meeting, and
remember @mrunalp saying something like “I think the certifiers will
take a closer look in cases like that” (although I didn't even get a
paraphrased form in the log 1 and may be misremembering who said
what).  However, we're currently very clear about tying “compliance”
to the RFC 2119 language 2, so I'm not sure what the certifiers
would do (badge the runtime compliant with a “seems to ignore
disableOOMKiller” note)?  Or is the idea that the functionality of
this property so obvious that it doesn't need compliance testing (and
runtimes will take care of testing this property on their own)?

On Wed, May 10, 2017 at 11:50:35PM -0700, W. Trevor King wrote:

Wed, May 10, 2017 at 09:33:17PM -0700, Tianon Gravi:

The part of this I find irritating while reading it is that it
re-references cgroupsPath over and over again.

I think this is the wording that @crosbymichael and @mrunalp were
considering pulling out into some central location.  I'm happy to
rebase this PR after they land the generic wording for that.

While digging through issue I'd marked unresolved, I came across #576.
It's pretty old, but still rebases cleanly onto master and it looks
like what folks want.  At least, I think it covers the “If
disableOOMKiller is not set and the cgroupsPath value would not
result in a new cgroup being created” case generically.  It does not
have wording for the “If disableOOMKiller is not set and the
cgroupsPath value would result in a new cgroup being created” case,
so that still needs to be worked out.  If #576 is close, but not quite
what you're looking for, then maybe it will help the maintainers while
they draft their own language.

i'm closing this. we'll follow the discussion of #834

On Wed, May 24, 2017 at 08:51:58AM -0700, v1.0.0.batts wrote:

i'm closing this. we'll follow the discussion of #834

Is #834 going to say anything about 1?  I thought it was just
covering lines 255 and 256 from this PR.


CI build for Linux, Windows, MacOS and Android (master)

Ah, I accidentally forgot to change the base branch before merging this the first time.
Also, we need to change the branch protection rules.

--> Blocks https://github.com/Jigsaw-Code/outline-client/pull/1109

OK, this is a verbatim respin of #1096, which is already approved, so feel free to merge once CI passes.

OK, this is a verbatim respin of #1096, which is already approved, so feel free to merge once CI passes.

Ah, it did pass, we just need to change the Required branch protection checks as they've been split out into the various builds. Do you have permission to do so?

OK, this is a verbatim respin of #1096, which is already approved, so feel free to merge once CI passes.

Ah, it did pass, we just need to change the Required branch protection checks as they've been split out into the various builds. Do you have permission to do so?

I think so.  What do you want to be Required?

OK, this is a verbatim respin of #1096, which is already approved, so feel free to merge once CI passes.

Ah, it did pass, we just need to change the Required branch protection checks as they've been split out into the various builds. Do you have permission to do so?

I think so. What do you want to be Required?

Either Build and Test / Linux as that also runs the tests (I split these concerns up in a later PR) or all of them: Build and Test / Linux Build and Test / Windows Build and Test / MacOS Build and Test / Android. Your choice


docs: add a lint to not have missing docs and allow(missing_docs) where nessesary

This PR is more for discussion which of these two approches you would like to prefer:

deny missing docs now, work on the allows for a while
work on the allows for a while, deny missing docs later

the advantage of denying now is that regressions (new modules being added without docs) is not possible anymore.

Okay, lint-reasons were only stabilised in 1.81 (not 1.75)
=> they cannot be used.
Will switch to comments