Add support for trailing text after the closing quote, and EOF without a final closing quote, for Excel compatibility. Fix a unit test and add a RAT exclude for the sample CSV file.

Continued from PR 295.
The test was failing because the test was wrong, not because my patches were wrong.
The test should match Excel's interpretation of the CSV file. Excel fuses lines 3 and 4 together, because the last field on line 3 doesn't end in a quote, so it continues into the next line. There, it stops at the initial quote, unquoting that portion, then also adds everything up to the comma, and all this becomes field 2 of line 3. The remaining fields on line 4 are interpreted as successive line 3 fields, and because the last field doesn't have a terminating quote, and the file ends in a new line, the last field also ends in a new line.
Once these corrections are made, the test passes.
Also add a RAT exclude for the sample file, which was missed out in commit 1269c133ff4637ed658fb8ab5d78a8671ecfed4a, and breaks the build.

Codecov Report

Merging #303 (930f561) into master (b1bdb99) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #303   +/-   ##
=========================================
  Coverage     97.91%   97.91%
  Complexity      553      553
=========================================
  Files            11       11
  Lines          1200     1200
  Branches        206      206
=========================================
  Hits           1175     1175
  Misses           13       13
  Partials         12       12

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

"The test was failing because the test was wrong"
This is why I kept asking (twice) for file-based tests... please add file-based tests that cover use cases for these two new options beyond the one you changed. Let's make sure there are actual files that cover what Excel allows.

@DamjanJovanovic

This functionality is now in git master, you are credited in changes.xml.
The name of the new properties are different though: setTrailingData(boolean) and setLenientEof(boolean).
Closing this PR.

TY!


Using 'data' for key during posts

[ ] Need to include type attribute.

can you rebase, I moved all the legacy stuff into json_api_client-legacy

will do.

On Apr 24, 2015, at 6:37 AM, Jeff Ching<EMAIL_ADDRESS>wrote:
can you rebase, I moved all the legacy stuff into json_api_client-legacy
—
Reply to this email directly or view it on GitHub.

Closing this - I'm going to send a different PR.


Geowave 343

Coverage increased (+0.03%) to 57.21% when pulling 1b2964217a0aad92be0d15519b0bb5fc3101652b on GEOWAVE-343 into 50f31b5ca4e661a2f904629e662c2bf8d20ca3a0 on master.

looks reasonable to me, waiting for travis...

Coverage increased (+0.04%) to 57.22% when pulling 1b2964217a0aad92be0d15519b0bb5fc3101652b on GEOWAVE-343 into 50f31b5ca4e661a2f904629e662c2bf8d20ca3a0 on master.

Coverage increased (+0.04%) to 57.22% when pulling 1b2964217a0aad92be0d15519b0bb5fc3101652b on GEOWAVE-343 into 50f31b5ca4e661a2f904629e662c2bf8d20ca3a0 on master.


No show email template and template prepopulating

This is a duplicate. The requirement had been resolved already. Closing.


[AIFlow] Support database version migration.

What is the purpose of the change
[AIFlow] Support database version migration.

Codecov Report

Merging #175 (374ec02) into master (723afa8) will increase coverage by 0.79%.
The diff coverage is 79.56%.

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   59.37%   60.17%   +0.79%
==========================================
  Files         169      180      +11
  Lines       13027    13340     +313
  Branches     1684     1704      +20
==========================================
+ Hits         7735     8027     +292
- Misses       4868     4893      +25
+ Partials      424      420       -4

Impacted Files
Coverage Δ

ai_flow/cli/configuration.py
0.00% <0.00%> (ø)

...ations/versions/de1c96ef582a_add_ai_flow_tables.py
62.85% <62.85%> (ø)

ai_flow/endpoint/server/server_config.py
60.91% <63.63%> (+0.39%)
:arrow_up:

ai_flow/migrations/env.py
72.72% <72.72%> (ø)

ai_flow/endpoint/server/server.py
57.48% <80.00%> (+1.53%)
:arrow_up:

ai_flow/cli/commands/db_command.py
91.30% <91.30%> (ø)

ai_flow/cli/cli_parser.py
94.44% <100.00%> (+13.49%)
:arrow_up:

...ons/versions/0e8fefcce376_add_workflow_snapshot.py
100.00% <100.00%> (ø)

...rations/versions/de045f309236_add_aiflow_member.py
100.00% <100.00%> (ø)

ai_flow/store/db/db_util.py
59.42% <100.00%> (+1.84%)
:arrow_up:

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 723afa8...374ec02. Read the comment docs.


Add wpf SimpleExample

#4

I am very sorry for leaving this pull request unmerged for such a long long time. Thank you for your contribution!


add "name" to /etc/cni/net.d/99-loopback.conf

For the latest cni version, name is mandatory, otherwise cni will
complain "missing network name".

Fixed on master.


updating component.tsx to fix issue with anchor sub links not working…

#1645 … on Props and Theming tabs

https://github.com/chakra-ui/chakra-ui-docs/issues/1645
📝 Description
The anchor links on the "Props" and "Theming" tabs aren't working properly in the "On This Page" side bar.

Add a brief description

⛳ Current behavior (updates)
When clicking on the anchor links on the right sidebar in the Props and Theming tabs, the view doesn't scroll into the correct section.
After digging into this, here's what I found:
When switching to Props and Theming tabs in the doc, the inner html of the Usage tab gets updated with the data for the Props or Theming tabs
The problem lies in the Component.tsx file. There's a condition in the map iteration that displays children when index === 0 (which is the "Usage" tab), causing unexpected behavior.
  {tabsData.map((item, index) => (
    <Box key={index} id={item.id} hidden={!tabsData[index].match}>

      {index === 0 ? children : <MDXContent doc={item.doc} />}

    </Box>
  ))}

🚀 New behavior
To fix this, I've modified the code to remove the MDXContent component from the conditional. This ensures that the "Usage" Tab only receives the doc that corresponds to it.
  {tabsData.map((item, index) => (
    <Box key={index} id={item.id} hidden={!tabsData[index].match}>

      {index === 0 ?? children}

      <MDXContent doc={item.doc} />

    </Box>
  ))}

💣 Is this a breaking change (Yes/No):
NO

Thanks mate but there are still some issues with your suggested solution. I will have a closer look once we moved the docs repo into the chakra ui mono repo.


Question in complie graphvite from source: external/faiss/configure not found

Sorry to bother you! I want to compile graphvite from source. And I just follow the instructions which you give in the readme. But I encounter a problem, here is the result when i did cd build && cmake .. && make && cd -.

-- The CXX compiler identification is GNU 7.3.0
-- The CUDA compiler identification is NVIDIA 10.0.130
-- Check for working CXX compiler: /home/user/miniconda3/envs/graphvite/bin/x86_64-conda_cos6-linux-gnu-c++
-- Check for working CXX compiler: /home/user/miniconda3/envs/graphvite/bin/x86_64-conda_cos6-linux-gnu-c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Check for working CUDA compiler: /usr/local/cuda/bin/nvcc
-- Check for working CUDA compiler: /usr/local/cuda/bin/nvcc -- works
-- Detecting CUDA compiler ABI info
-- Detecting CUDA compiler ABI info - done
-- Looking for C++ include pthread.h
-- Looking for C++ include pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Found CUDA: /usr/local/cuda (found version "10.0")
-- Found Glog: /home/user/miniconda3/envs/graphvite/include
-- Found glog    (include: /home/user/miniconda3/envs/graphvite/include, library: /home/user/miniconda3/envs/graphvite/lib/libglog.so)
-- Found GFlags: /home/user/miniconda3/envs/graphvite/include
-- Found gflags  (include: /home/user/miniconda3/envs/graphvite/include, library: /home/user/miniconda3/envs/graphvite/lib/libgflags.so)
-- Found PythonInterp: /home/user/miniconda3/envs/graphvite/bin/python (found version "3.7.9")
-- Found PythonLibs: /home/user/miniconda3/envs/graphvite/lib/libpython3.7m.so
-- Performing Test HAS_CPP14_FLAG
-- Performing Test HAS_CPP14_FLAG - Success
-- Autodetected CUDA architecture(s):  7.5
-- Configuring done
-- Generating done
-- Build files have been written to: /home/user/LGY/graphvite/build
Scanning dependencies of target faiss
[  9%] Creating directories for 'faiss'
[ 18%] Performing download step (git clone) for 'faiss'
Cloning into 'faiss'...
Already on 'master'
Your branch is up to date with 'origin/master'.
[ 27%] No patch step for 'faiss'
[ 36%] Skipping update step for 'faiss'
[ 45%] Performing configure step for 'faiss'
/bin/sh: 1: /home/user/LGY/graphvite/external/faiss/configure: not found
CMakeFiles/faiss.dir/build.make:100: recipe for target 'faiss/src/faiss-stamp/faiss-configure' failed
make[2]: *** [faiss/src/faiss-stamp/faiss-configure] Error 127
CMakeFiles/Makefile2:72: recipe for target 'CMakeFiles/faiss.dir/all' failed
make[1]: *** [CMakeFiles/faiss.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2

As you can see that the main problem is that external/faiss/configure is not found. And I also find that there is no configure file in faiss project, so I think that maybe graphvite/CMakeLists.txt is not compatible with different versions of faiss (I think the version of faiss which you used is different from the current version of faiss). This is just my assumption, I don't know how to fix the problem.
I look forward to your reply. Thanks!

You are right. FAISS interface often changes.
A simple workaround is to use a fixed version of FAISS, e.g. v1.5.1 or v1.6.1 have been tested ok in #36. You can specify FAISS version in CMakeLists.txt as
GIT_TAG v1.6.1
Or manually checkout the corresponding git commit in external/faiss/.

Thanks for your patience!


Implement the footer

Refer to screenshots in epic
Logos in the footer do not link out to anything
Figma with assets and CSS details here - https://www.figma.com/design/rgzEYTpnGl6l68moRSVwYg/Phase-1-UI-Details?node-id=149-1572&node-type=frame&m=dev
Acceptance criteria

[ ] Logos are added to the footer (four logo images, merge image and text for Office of the Dean for Research into one graphic, and also merge image and text for Research Computing into one graphic)
[ ] Additional footer information is styled to match the prototype

Hey team! Please add your planning poker estimate with Zenhub @bess @hectorcorrea @JaymeeH @jrgriffiniii


Delete uopz

If this thing was needed when 6123643 , now we do not need it.

Just for future reference, quoting from PHP docs:

The uopz - User Operations for Zend - extension exposes Zend Engine functionality normally used at compilation and execution time in order to allow modification of the internal structures that represent PHP code, and for user code to interact with the VM.

I don't see any valid reason we need this here, so I approve the change

Maybe this was the time when nightly PHP didn't build without it

@ste93cry please approve this one and then merge it. So we can test code again

I don't see any valid reason we need this here, maybe @remicollet can explain us why he added this extension to the build?

uopz is an optional PHPUnit which is required in some case (don't remember exactly which test were failing without) btw, everything seems ok now.

It's needed to create partial mocks that alter the structure of the mocked class. Probably the tests that used that are gone now (luckily!).


Accommodate change of empty vector representation in nightly libstd.

This change is

@bors-servo r+

:pushpin: Commit cd5f46e has been approved by nox

:hourglass: Testing commit cd5f46e9996eee71a4e66102768d65c82a700f72 with merge 2cbc81c0970bccef8aede661502e08005e33bdcc...

:sunny: Test successful - status-travis
Approved by: nox
Pushing 2cbc81c0970bccef8aede661502e08005e33bdcc to master...

What was the number of the change in libstd?

https://github.com/rust-lang/rust/pull/41064

Specifically the changes to src/liballoc/heap.rs in that PR. (So it affects all zero-size heap "allocations", not just Vec.)


[WIP] Adding in a MultiplexTcpTransport

There is a an issue where the WiProProtocol class tries to immediately connect to a secondary transport after being informed of their existence. This should only happen after the protocol has been requested to start a service that can only take place on a secondary transport. Essentially when a sart service request method is called, WiProProtocol needs to check if the desired transport for that service type, if it is secondary and that transport is not yet connected, that is when the sequence should be kicked off.

Codecov Report

:exclamation: No coverage uploaded for pull request base (feature/multiplexing_only@23e10d6). Click here to learn what that means.
The diff coverage is 4.3%.

@@                     Coverage Diff                      @@
##             feature/multiplexing_only     #788   +/-   ##
============================================================
  Coverage                             ?   39.28%
  Complexity                           ?     2690
============================================================
  Files                                ?      367
  Lines                                ?    17075
  Branches                             ?     1932
============================================================
  Hits                                 ?     6708
  Misses                               ?    10022
  Partials                             ?      345

Impacted Files
Coverage Δ
Complexity Δ

.../smartdevicelink/transport/TransportConstants.java
0% <ø> (ø)
0 <0> (?)

...n/java/com/smartdevicelink/proxy/SdlProxyBase.java
7.92% <ø> (ø)
15 <0> (?)

...n/java/com/smartdevicelink/protocol/SdlPacket.java
34.14% <ø> (ø)
17 <0> (?)

...artdevicelink/transport/MultiplexTcpTransport.java
0% <0%> (ø)
0 <0> (?)

...m/smartdevicelink/SdlConnection/SdlConnection.java
17.76% <0%> (ø)
17 <0> (?)

...icelink/transport/utl/ByteArrayMessageSpliter.java
0% <0%> (ø)
0 <0> (?)

...com/smartdevicelink/transport/TransportBroker.java
19.38% <0%> (ø)
15 <0> (?)

...artdevicelink/protocol/enums/ControlFrameTags.java
0% <0%> (ø)
0 <0> (?)

...com/smartdevicelink/protocol/SdlPacketFactory.java
42.85% <0%> (ø)
4 <0> (?)

...com/smartdevicelink/protocol/AbstractProtocol.java
40.9% <0%> (ø)
6 <0> (?)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e10d6...6bc4fcb. Read the comment docs.


Generate RSS feed

Can we add support for RSS feeds using the @astrojs/rss integration?
I'm happy to submit a PR if this is something you'd like.

Hey @acherunilam thanks for the suggestion. I've made a quick pass at the integration. Feel free to add anything to #33, and I'll get it merged.
Thanks again

Done via #33. Thanks again @acherunilam


Git: "Open File" from context menu of an outgoing change opens the diff editor

And not the file anymore.

Actually the repro is:

Open the context menu on the resource
Escape

The git.openResource action runs, which is the default click action for git resources.

Bisect told me this caused it: https://github.com/Microsoft/vscode/commit/d2fd388ba42b22d8bbb4618549dc9c9140ef764f


digital envelope routines:EVP_DecryptFinal_ex:bad decrypt

Hi,
After creating pub/priv pub files with command from README.md and running chekc command got this:
$ bin/console lexik:jwt:check-config
Failed to load private key "/Users/anton/Projects/pro/back/app/../var/jwt/private.pem":
 0906D06C:PEM routines:PEM_read_bio:no start line
 06065064:digital envelope routines:EVP_DecryptFinal_ex:bad decrypt
 0906A065:PEM routines:PEM_do_header:bad decrypt

What am I going wrong? :)

It looks like your private key is encrypted. Save it unencrypted and try again

Closing as solved, that's a key generation issue. Thanks @Spomky for helping out.

If someone have the same problem, make sure that the pass use to generate the private is the same in the config files


There are some problems on Debian 8.1.0

TASK: [Stouts.supervisor | Ensure the supervisor is started] ******************
<<IP_ADDRESS>> REMOTE_MODULE service name=supervisor state=started
failed: [default] => {"failed": true}
msg: Failed to start supervisor.service: Unit supervisor.service failed to load: No such file or directory.

I have fixed it and made a pull request.


Add "Use pattern-matching in if let" to commonly_proposed.md.

Since it just came up again recently.
@DougGregor or @lattner, okay to merge?

Adding this makes sense, but please include some points about why it doesn't work out well in practice:

Most devs don't think about things in "pattern matching" terms, they think about "destructuring".
The most common use case for "if let" is actually for optional matching.
Thus, going with this proposal punishes the common case syntactically, and also makes the learning curve for swift better.
The current design of "if case" unifies "pattern matching" around the 'case' keyword, which is googlable.

pre approved with changes to bulk up the reason why it is a bad idea :-)

104cdde addresses this.

Thanks, Chris; sorry for not getting back to this.


added myself to the roster

Okay I believe this is correct, I added myself similar to Martin's section.

Manually incorporated changes


CkEditor Instance value not cleared when i call form.reset()

After i submitting my form data, i'll clear form for new input. but the ckeditor instance value not cleared! how can i do that?

i use model driven form
i use angular 4

my template code is:
<ckeditor formControlName="content"></ckeditor>

Hi, did you try to set the value to an empty string? Look at: how to reset value;
In HTML part:
                <ckeditor
                    [config]="ckeConfig"
                    #ckeditor
                    debounce="500">
                  </ckeditor>

In typescript part:
@ViewChild("ckeditor") ckeditor: any;

onEventOrRequest(event: any)
{
this.ckeditor.instance.setData('');
}

@mekramy : is your problem solved? Can the task be closed?

@kzimny thnaks. i move to vuejs and not work with angular any more!
other people may have same issue! any way you can close my issue if you want.

If other people identify the same problem, please report and the task will be reopen.

Hi What I got this workaround. But I have validation message applied to theCKEditor and it happens that whenever I am trying to reset the form. I am able to reset the CKEditor but not the message. Anything that can be helpful here?

Did you try to set the form to pristine?
<form role="form" class="form-horizontal" (ngSubmit)="save(basedataForm)" #basedataForm="ngForm"></form>

and in ts file
save(myForm: NgForm) {
	myForm.form.markAsPristine();
	myForm.form.markAsUntouched();
}

.ckeditor.instance.setData('');
this.ckeditor.instance.updateElement();

**Fuck Off Dear

[ ] @**


url /{label}/{application}-{profile}.properties stopped working in spring boot 2.6.1 and config 3.1.0

I upgraded spring cloud to 2021.0.0 and spring boot to 2.6.1 and it stopped working for URL in format /{label}/{application}-{profile}.properties.
It ends with this response:
{"name":"master","profiles":["app-devt.properties"],"label":null,"version":null,"state":null,"propertySources":[]}

I tried to debug it and it goes to this method in the controller instead of the correct one.
https://github.com/spring-cloud/spring-cloud-config/blob/v3.1.0/spring-cloud-config-server/src/main/java/org/springframework/cloud/config/server/environment/EnvironmentController.java#L109

Can you provide a complete, minimal, verifiable sample that reproduces the problem? It should be available as a GitHub (or similar) project or attached to this issue as a zip file.

I think the old behavior should return if the property spring.mvc.pathmatch.matching-strategy: ant_path_matcher is set.

I can confirm that spring.mvc.pathmatch.matching-strategy=ant_path_matcher fixed the issue
however,
/{application}-{profile}.properties
/{application}-{profile}.yml

always have a null label when using jdbc

Change in boot https://github.com/spring-projects/spring-boot/issues/24805


Why is the API so verbose?

I'm not sure whether this is a question about the library design or a feature request for simplifying the read/modify/write API.
Why do we need to write
peripheral.register.write(|w| w.field().set_bit())
peripheral.register.write(|w| w.field().clear_bit())
peripheral.register.write(|w| w.field().bit(bool_val))

instead of
peripheral.register.write(|w| w.set_field())
peripheral.register.write(|w| w.clear_field())
peripheral.register.write(|w| w.field(bool_val))

?
All those field-R and field-W types seem to considerably blow up the API (and file size). The mentioning of "bit" or "bits" in the method call seems to be superfluous clutter, not making the API more fluent. I know the type of the register fields that I work with, or I can infer it from passing either a boolean or a number to the method.
What is the advantage of these additional types?
(Regarding changing or extending the API, I have not enough experience with the ecosystem to judge how to best proceed with this in terms of backwards compatibility and at the same time not bloating the API further).

Also there are quite a few registers that hold only a single field anyway. Would it be possible to allow syntax like
peripheral.register.read_field()
peripheral.register.write_field(num)
peripheral.register.modify(|val| val)

for them instead of having to deal with .bits() everywhere?
Or am I mistaken about the scope of svd2rust and it is the job of the HAL crates to provide these abstractions methods?

HAL is used to abstract over the different resources of the chip and make ease of use better. The api svd2rust generates is used as a "low-level" interface. To answer your question it's correct that HAL is supposed to provide abstractions, but not in that exact fashion of shortening field access, but to handle resources in a more convenient way.
Regarding why we use R and W, or specifically why we use
peripheral.register.write(|w| w.field().set_bit())

and not
peripheral.register.write(|w| w.set_field())

Consider this call and how it would be used with the second variant
peripheral.register.write(|w| w.field().open())

To transform enumerated values we'd have to do
peripheral.register.write(|w| w.set_field_as_open())

Which to me doesn't seem like a good idea.

Eitherway I do agree with you that it is a bit superfluous, but I think that it is fine because the api generated is supposed to be as low-level as possible/convenient.

Ah, thanks for the insight. I have not yet worked with enumerated values yet, I guess the API is more fluent with those. I would have thought of
use per::reg::Field::*
peripheral.register.write(|w| w.field(Open))

only, which indeed isn't as nice as the convenience methods.

No problem! 👍
Feel free to close the issue if you feel like it's been resolved.


Serving operator interferes with serving updates to MutatingWebhookConfiguration

When using the 0.10 serving operator, I've run into issues where after bringing up serving via the CR and trying to deploy a ksvc, the ksvc never comes up. The Revision stays at ready status=Unknown, reason=Deploying.
It appears that the reason that the revision isn't coming up is because the webhook isn't configured properly. After coming up, serving (the webhook controller, I believe) writes necessary configuration to the MutatingWebhookConfiguration webhook.serving.knative.dev in the top level webhooks key. Shortly after writing the configuration, the operator reconcile loop re-applies it's own configuration for this object, wiping out the configuration needed by the webhook controller. When watching the MutatingWebhookConfiguration, I do see it eventually get fixed up after some period of time, but my revision still doesn't come up automatically. However, once the MutatingWebhookConfiguration gets into the correct state, I can deploy services successfully.
I did verify that if I update the operator to not touch existing resources (create them only), that I am able to bring up a ksvc as expected. This obviously ins't a long-term solution, but does seem to indicate we may need to be more selective about what or how the operator updates serving resources.
This relates to #163

FWIW, I agree with you. The logic that determines whether a resource needs to be updated needs to be improved. At the time, I didn't even know there was a Patch command. ;)

It looks like the reason this didn't show up until 0.10 is that for 0.9, the MutatingWebhookConfiguration wasn't part of the release yaml manifest that the operator applies, but rather created by the webhook controller. It was added here: https://github.com/knative/serving/pull/5871.
I happen to like that the operator enforces the configuration is in the state it expects (so long as it doesn't break things). However, if this pattern of serving mutating objects that the operator creates is common or something that we expect to happen more in the future, I might have to re-evaluate my viewpoint. If it's not a pattern that we expect to continue in serving, I'd prefer to treat these cases (e.g. serving updating MutatingWebhookConfiguation) as special cases that the operator copes with.
@mattmoor Do you have any thoughts on how the operator should treat the MutatingWebhookConfiguration? Do you happen to know if this behavior where serving mutates the resources that were originally created by the serving release yaml happens elsewhere?

On some level, I'm wondering if this is a bug in the operator or a bug in serving. It seems like a human running "kubectl apply" with the serving yaml multiple time might also have the ability to break the MutatingWebhookConfiguration, although I haven't tested that. Or maybe it's just that kubectl does more work to merge things.

It happens to at least the secret as well.  I believe it will also happen with gateway resources when auto-TLS is enabled.
If the semantics aren’t three-way merge then folks are going to have loads of fun migrating to the Operator 😬
-M(obile)

On Nov 22, 2019, at 4:55 PM, Garron Moore<EMAIL_ADDRESS>wrote:
It looks like the reason this didn't show up until 0.10 is that for 0.9, the MutatingWebhookConfiguration wasn't part of the release yaml manifest that the operator applies, but rather created by the webhook controller. It was added here: knative/serving#5871.
I happen to like that the operator enforces the configuration is in the state it expects (so long as it doesn't break things). However, if this pattern of serving mutating objects that the operator creates is common or something that we expect to happen more in the future, I might have to re-evaluate my viewpoint. If it's not a pattern that we expect to continue in serving, I'd prefer to treat these cases (e.g. serving updating MutatingWebhookConfiguation) as special cases that the operator copes with.
@mattmoor Do you have any thoughts on how the operator should treat the MutatingWebhookConfiguration? Do you happen to know if this behavior where serving mutates the resources that were originally created by the serving release yaml happens elsewhere?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

To follow up on my last comment: I was not able to reproduce this using "kubectl apply" repeatedly. It appears to not attempt any changes to the webhook configuration in subsequent invocations of apply. Even if I manually tweak the MutatingWebhookConfiguration slightly to force kubectl to make changes, it undoes my changes using a patch and leaves the configuration that was put in by the webhook controller alone.

@garron If the three-way merge gets mature in 1.16 of Kubernetes, will this issue be fixed automatically if we upgrade the Kube to the 1.16 version?
Or we still need to implement some patching mechanism with lastOperatorAppliedValue for the objects?

As noted in the discussion in Slack: I'm leaning towards hot-fixing this at least for the WebhookConfiguration by configuring Manifestival to ignore a set list of types and use "Ensure exists" semantics for those types. We can potentially even extend that to GroupVersionKind + NamespacedName so we could ignore the colliding resources for now.
It sure is a workaround but feels enough to me to get us to 1.16 until we have a better way of fixing it?

Regarding "configuring Manifestival to ignore a set list of types", do we leave it an open option to users, or use the fixed rules implemented by Manifestival?

@houshengbo It'd be down to the client of the library, so our operator can be very specific about when to apply the other strategy.

However, if this pattern of serving mutating objects that the operator creates is common or something that we expect to happen more in the future, I might have to re-evaluate my viewpoint.

Yep - whether it's knServing itself making the modifications or an admin of KnServing I think it's the same high-level issue...  where is the source of truth? If sometimes it's in Serving and sometimes it's in the operator then I think this issue will continue to pop up.

I'd say the source is the operator's CRD. Knative munging it's own resources could be seen as a bug (I think it is) and we only chose this route for upgradeability reasons. We should eradicate all instances of the Knative controllers munging stuff in the release.yaml IMO.

@markusthoemmes If eradicating all instances of the Knative controllers munging stuff in the release.yamls is technically feasible, it seems like a great direction to go from the perspective of the operator. It keeps the ownership model clear and makes the behavior of the operator much easier to reason about (and hopefully document).
The doc that I put together around this basically assumes that the behavior of serving mutating things is necessary. However, I'd be happy to have that not be the case.
The workaround that you're suggesting around Ensure Exists semantics is something that I've tried out and works. However, in trying it out, I added serving-specific concepts to manifestival (specific object types to ignore and the release label name), which doesn't seem appropriate to land. Landing it would likely require abstracting the concepts and allowing hooks of some kind into manifestival.

@garron right, but I feel like a configuration for Manifestival that allows that and then encoding the serving specific bits in the operator is the quickest way forward to unblock 0.10.
I think the operations WG should push for such a state in Knative Serving. Do we have a list of things were Serving currently munges with stuff from its own manifest?


Review and refine documentation, schema and tools in light of csolution.yml being mandatory

The Project has agreed to make the csolution.yml file the mandatory entry point and no longer support the specification of a "self-contained" cproject.yml file.
This has implications on:
a) documentation / examples
b) schema files - items already sufficiently specified in the csolution shall be removed from the cproject.yml
c) csolution tool shall deprecate support for -p and -s instead myproject.csolution.yml is specified without a flag being required.
Review for other required changes.

Documentation got updated accordingly.


Add electra version of AggregateAndProof

For Electra, we need to extend AggregateAndProof (and SignedAggregateAndProof) to use the new Attestation type.

nice catch!
for consistency, I'd prefer these in the electra/validator.md file
e.g. https://github.com/ethereum/consensus-specs/blob/dev/specs/phase0/validator.md#aggregateandproof


🪐 Allow for Jupyter execution (including inline) directly in mystmd CLI

This PR adds execution support to the mystmd CLI. A sketch at some docs below from @rowanc1!

[ ] add health testing to Jupyter Server selection logic
[ ] prewarm kernels?

Getting a test failure on my machine:

Figured out my problem, there was a dead server hanging about that could not be removed. I went into the runtime  using jupyter --paths and deleted it manually.
As part of that testing I went through and changed a few things:

improved some of the logging
For errors: I made things that were happening (jupyter starting) be in log and things that were node/execution errors part of the fileError. The logs trigger immediately, while the ones in the vfile don't get logged for a while and are stored. I think this is a decent pattern, and a bit of a nuance on the advice I gave earlier.
You now need to pass the --execute flag from the CLI, the default is false.
You can clean the execution cache using myst clean --execute

Things I noticed:

[ ] The jupyter server stays around and isn't shut down when running myst build --execute. Or myst build --execute --html this means that the process doesn't stop and just hangs. Need to investigate how to kill the server.
[ ] I put the execute flag in, but this should maybe also be in the myst.yml?
[ ] I don't think we are passing the minification flags around anymore? This needs to come back.

There's something wacky going on with Node - it refuses to quit even when the child process has been killed. There are tools to ask node why it's not quitting, but I don't have time right now to dig into it. It might be that we want to remove the use of closures and move this logic into a class. That might be less opaque to node, if refcycles are the problem.

@fwkoch I changed the Python package from using setuptools to using the Hatch build backend. The benefits of this are fewer config files, more declarative config, and the ability to use plugins to pull metadata from mystmd's package.json. Are you comfortable with this change?

@rowanc1 I've updated the cache key struct to include the raises-exception tag that allows notebooks to ignore errors. I haven't included a cache-version in the key; my rationale is that this is implicitly part of the hash - if we change the structure, the hash will change.

Ah -- we didn't add changesets @agoose77! :)


search controller

search controller is broken on either ios8 or ios9 - I feel best is to just replace it with 3rd party search controller ...

for now - there's an if checking for iOS8/9 and changes the search bar center accordingly


Start refactoring scheme sketcher code, before moving to a library

I want to move the bulk of the scheme sketcher code into a new git repo, exposed as a Sveltekit library. The goal is to more easily use pieces of this from other projects, such as the inspectorate tools. It's not an easy refactor; the bulk of the core drawing logic is already in maplibre-draw-polygon and route-snapper, but the code here manages the toolbox, switches modes, manages the store with the GeoJSON features, etc.
Roughly the split of responsibility I picture is like this. The sketch library will handle lib/draw/ and parts of lib/sidebar -- giving people the mode switching logic, multi layer (scheme) management, sidebar controls, etc. What will remain in this repo (and have a new, much simpler variation in inspectorate tools) is per-schema forms, backfilling logic, etc. So the library shouldn't really care about feature properties beyond a few of the truly common ones.
This PR is a first step that makes lib/draw/ much more self-contained and starts teasing apart the types. I think even as a standalone refactor without doing the rest, it has some value. It's not complete -- the code still pulls in repo-wide map and userSetings stores, and I need to think through how to make the SchemeCollection type more generic. Assuming tests pass and there are no comments, I'll merge next time I work on this. A next step will probably be starting the new repo and discovering more tricky complications.

This sounds great to me and should make it easier for others to use the very useful functionality, in UK and beyond!


Can we add ffprobe?

scikit-video requires ffmpeg that come with ffprobe. Could/Should the next ffmpeg from conda-forge include it?
some error msg. When run scikit-video
import skvideo.io
import skvideo.datasets
videodata = skvideo.io.vread(skvideo.datasets.bigbuckbunny())
print(videodata.shape)

---------------------------------------------------------------------------
AssertionError                            Traceback (most recent call last)
<ipython-input-114-e52d2e13d561> in <module>()
      1 import skvideo.io
      2 import skvideo.datasets
----> 3 videodata = skvideo.io.vread(skvideo.datasets.bigbuckbunny())
      4 print(videodata.shape)

~/miniconda3/lib/python3.6/site-packages/skvideo/io/io.py in vread(fname, height, width, num_frames, as_grey, inputdict, outputdict, backend, verbosity)
    131     if backend == "ffmpeg":
    132         # check if FFMPEG exists in the path
--> 133         assert _HAS_FFMPEG, "Cannot find installation of real FFmpeg (which comes with ffprobe)."
    134
    135         if ((height != 0) and (width != 0)):

AssertionError: Cannot find installation of real FFmpeg (which comes with ffprobe).

We already compile ffprobe, so the problem should be somewhere else.

Yeah ffprobe is definitely in the package. Expect there is some way to tell scikit-video about ffprobe's location, but having not used it, I wouldn't know. Maybe raise an issue with scikit-video and see if they have any advice. For now am closing as a non-issue (at least with this package). Happy to revisit should that change.


pubsub: fix potential deadlock in startConnections

If a subscriber connection fails, awaitRunning will throw
IllegalStateException.
We must make sure that we count down the latch in either case;
otherwise startup will deadlock.
Also move the call to addListener above startAsync.
Otherwise, the listener might not see the connection failing
if it fails too quickly.
cc @davidtorres @mdietz94

Makes sense to me - @davidtorres can you take a look?


Parse error when encountering JSDoc style types in declaration files

Describe the bug
dprint-plugin-typescript version: 0.88.7
dprint can't handle declaration files which contain unusual types that aren't valid in normal TS files.
I wish TS didn't allow this, but it does, so I have a testcase for it in TypeDoc... and dprint doesn't like it.
Input Code
// skipNullChecks.d.ts
export function nullable(opt: ?string): void;
export function nonNullable(opt: !string): void;

Expected Output
// skipNullChecks.d.ts
export function nullable(opt: ?string): void;
export function nonNullable(opt: !string): void;

Actual Output
Error:
Error formatting /home/gerrit/Desktop/typedoc_master/src/test/converter2/issues/gh1524.d.ts. Message: Unexpected token `?`. Expected an identifier, void, yield, null, await, break, a string literal, a numeric literal, true, false, `, -, import, this, typeof, {, [, ( at /home/gerrit/Desktop/typedoc_master/src/test/converter2/issues/gh1524.d.ts:1:31

  export function nullable(opt: ?string): void;
                                ~
Had 1 error formatting.

Does TS actually allow it? I get errors for both:

It does -- if and only if skipLibCheck is turned on, sorry, I could have sworn I included that in the original issue!

In this case, the diagnostic is suppressed because TypeScript does it's best to parse the file and then doesn't surface these errors because of skipLibCheck being off. I'm going to categorize this one as "wont fix" because it's not valid TypeScript code.
In this case, people should manually change their code from opt: ?string to the equivalent opt: string | null. That will also make the TypeScript code work in cases where people don't have skipLibCheck enabled.
In your case of having it as a test file, I recommend adding a // dprint-ignore-file statement at the top of the file, or exclude it in the dprint.json config.


Don't use padding in base32 helpers

The base32 variant NSEC3 uses doesn't have padding. This hasn't been a
problem in practice because SHA1 is the only current NSEC3 hash algorithm
and its output doesn't require padding.
No-pad support was introduced in Go 1.9 which is the oldest release this
package supports.

This is a follow up to the discussion in #426.

Codecov Report

Merging #683 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #683      +/-   ##
==========================================
+ Coverage   58.18%   58.23%   +0.04%
==========================================
  Files          37       37
  Lines       10119    10121       +2
==========================================
+ Hits         5888     5894       +6
+ Misses       3174     3171       -3
+ Partials     1057     1056       -1

Impacted Files
Coverage Δ

msg_helpers.go
48.68% <100%> (+0.24%)
:arrow_up:

msg.go
79.96% <0%> (+0.62%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f8c771...3e7e4d5. Read the comment docs.

I threw together a simple benchmark and the call to WithPadding has overhead:
name        old time/op    new time/op    delta
ToBase32-8     242ns ± 6%     501ns ± 7%  +106.80%  (p=0.000 n=10+8)

name        old alloc/op   new alloc/op   delta
ToBase32-8      128B ± 0%      416B ± 0%  +225.00%  (p=0.000 n=10+10)

name        old allocs/op  new allocs/op  delta
ToBase32-8      2.00 ± 0%      3.00 ± 0%   +50.00%  (p=0.000 n=10+10)

The performance overhead goes away entirely if you extract base32.HexEncoding.WithPadding(base32.NoPadding) into a global variable.


Return success status of grpc_byte_buffer_reader_init

grpc_byte_buffer_reader_init now returns an int (effectively a bool) indicating errors.
I've changed the wrapping code in objective-c, node, ruby and php to the best of my knowledge. Changes are still needed for Python and C# to consider grpc_byte_buffer_reader_init and react to failures appropriately. I've added a TODO for those two languages.
@apolcyn for C#
@murgatroid99 for Ruby and Node.
@makdharma / @jcanizales for obj-c
@nathanielmanistaatgoogle / @soltanmm for Python.
@yang-g for C++
@stanley-cheung for PHP
@ctiller for core.
Fixes #7149

LGTM

LGTM

LGTM

ObjC change LGTM

LGTM
On Fri, Jul 1, 2016 at 10:57 AM, Jorge Canizales<EMAIL_ADDRESS>wrote:

ObjC change LGTM
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/grpc/grpc/pull/7190#issuecomment-230010222, or mute
the thread
https://github.com/notifications/unsubscribe/AJH4LpOiTvx-SOjZKKwD9o6T2G1tUwvTks5qRVUggaJpZM4JCtsa
.

@ctiller & @nathanielmanistaatgoogle PTAL.

If you wanted to just fold @soltanmm's code from his follow-up pull request into this pull request, that would be fine.
What hope is there of test coverage?

Ack. We are trying to be fancy and have @soltanmm commit against my branch, but github is hard. Failing that I'll just replicate his changes manually.
All the hope. Will do.

Oh. I was expecting you to say "none", and then I was going to say "well that's okay, please describe the impossibility of test coverage very thoroughly in your commit log message". But actual test coverage would be even better.

Well, it's a matter of creating a corrupted byte buffer and feeding it to the function. Were you referring to something other than a C unit test for the newly add functionality in byte_buffer_reader.c?

Yeah, I was specifically referring to test coverage of the changed Python code.

I think the same principle would apply to Python. I'll write the C test and then @soltanmm could perhaps update https://github.com/grpc/grpc/pull/7213 with the corresponding test, which if I'm not mistaken would be very similar to the C one.

See https://github.com/grpc/grpc/pull/7190/commits/ecbe2d52853ee70716479f0eaaef8564667255ec#diff-fd7344b886003cac58aafbbc4bdacb54R118 for the test. I presume replicating this in Python is feasible? @soltanmm :grimacing: ?


Possible to adapt to pandas dataframes

Hello,
I've been trying to adapt the pipeline based on the example code (ICP_Regression) to my own datasets, however I encounter issues at the following lines. I am working mostly with pandas data-frame and split my data with sci-kit function according to conformal predictions framework.
#Example Dataframe
new_host   split  	   sequence	       expression (target)
FALSE	      train       AQVPYGVS	        0.039267878
FALSE	      train	    ASVPYGVSI      	0.039267878
FALSE	      train	    STNLYGSGR	        0.261456561
FALSE	      test	    NLYGSGLVR	        0.265188519
FALSE	      test	    SLGPSNLYG	        0.419680588
FALSE	      test        ATSLGTTNG	         0.145710993

#DataSplit
X_train, X_cal, y_train, y_cal = train_test_split(X_train, y_train, test_size =0.2)

icp.fit(X_train, y_train)
icp.calibrate(X_cal, y_cal)
icp.predict(X_test, significance=0.1))

I managed to make line 1 and 2 work properly by just converting the feature set to a numpy array such as :
y_cal = y_cal.to_numpy()
However line 3 produces an error even when I do this when making the predictions, I've tried multiple ways to adjust my pandas dataframe.
I was wondering if it would be possible to adapt these functions to be used with pandas dataframe.
Best,
John

It's unlikely that there will be any adaptation specifically to pandas in the near future, as it's quite a lot of work (that makes the code base messier) for relatively little benefit.
If you could provide some extra information about what errors you're getting with pandas dataframes, I might be able to help you pinpoing the problem.


Remove header Links

Fixes #818
The header contents are getting mixed-up in mobile view. Removing the links in the header is one of the easier options to fix it. Anyway, these links are already there in the footer.

Here is the result of the first commit:

This alone won't fix the issue. To avoid the overlapping between the version drop-down and searchbar, we need to reduce the image width.

Right. And also, PR has to be raised against staging branch, that is where CI is setup to build and publish at staging-docs.litmuschaos.io

FYI, the branding / images are available at https://github.com/litmuschaos/litmus/tree/master/images.
While you upgrade to latest docusaurus and fix the mobile view, feel free to use an icon there or if you require a new one with a particular dimension.

I'm closing this PR as I've submitted another PR to upgrade Docusaurus version, which will resolve this issue.


CONHOST fonts problem

Not only the unicode fonts don't show all characters but look at this:

Can anyone tell me what can cause this?
I am even using another version of conhost (the original of 2019 in the windows recovery disk)
The problem is NOT conhost itself but something in the system that has been modified by some recent update.
Can someone please help me understand this?
In CONHOST in the image above the font is wrong and the size is like it has a different dpi
Look at this... again: putty and notepad are correct.

And also in microsoft edge.

Can someone please help me?

It’s the weekend for us Microsoft folks. Most of my team doesn’t work weekends!
You appear to be having a systemwide problem that isn’t directly associated with the console. Can you roll back the update and file feedback in the Feedback Hub?

As a note: conhost currently-and pretty much always has–measures font sizes in pixels (cell height) whereas almost all other applications measure font sizes in points. 16 in conhost will be smaller than 16 in Notepad and Edge, as 16 in conhost means “make the cell height 16 pixels”
This is a fairly well-known quirk of the console on Windows that we aren’t planning on changing.

Size difference aside (see the next comment for details), you appear to be having a systemwide font problem that isn’t directly associated with the console. Can you roll back the update and file feedback in the Feedback Hub?

No problem for the size.. glad to know isn't related to my  problem. But I hace no font issue. At least I am pretty sure something else prevent the fonts to work correctly in SOME but not all programs.
But I don't see any relevant log in event viewer nor in process monitor (I posted it in another issue) perhaps I can't see it.
I wish to dig the cause instead of performing an in-place upgrade/repair. My system is quite customized and I don't want to set everything up again. Also I am on a metered connection and I will have to reupdate everything. I wish to find a fix. I bet is some permission or some other program interfering.

I fixed one of the TWO problems, now unicode works in chrome and anywhere except conhost running bash.exe.

Second update: also openconsole bash.exe now works!

The windows 10 conhost.exe instead still works only with cascadia.
Any Idea what it can be?
if YOU do: c:\windows\system32\conhost.exe bash ~  does unicode works with all unicode fonts?

I'm happy to hear that you could resolve your font issue, although it's unclear to me why it broke in the first place. I was under the impression that it still worked when you filed #18024. That aside...

The problem is NOT conhost itself but something in the system that has been modified by some recent update.

We know, because we maintain conhost and told you that we didn't ship any conhost updates. I'm not sure why you continue to not believe us.

The windows 10 conhost.exe instead still works only with cascadia.

To repeat what I said in #18024:

Braille glyphs are U+2800..U+28FF

Consolas does NOT contain braille glyphs: https://www.fileformat.info/info/unicode/font/consolas/list.htm
Source Code Pro does NOT contain braille glyphs: https://www.fileformat.info/info/unicode/font/source_code_pro/list.htm
Lucida Console does NOT contain braille glyphs: https://www.fileformat.info/info/unicode/font/lucida_console/list.htm
DejaVu Sans Mono does NOT contain braille glyphs: https://www.fileformat.info/info/unicode/font/dejavu_sans_mono/list.htm
Cascadia DOES contain braille glyphs: https://github.com/microsoft/cascadia-code/blob/a0f40c6fcae6440d6b6b063b2c16c23051fb056e/sources/CascadiaCode-Regular.ufo/glyphs/blank-braille.glif

"Font fallback" is required if a font does not contain a glyph

conhost does NOT support font fallback (on Windows 10)
OpenConsole DOES support font fallback
Putty DOES support font fallback
Notepad DOES support font fallback

Conclusion: If you use Windows 10 conhost with braille glyphs but your font does not support braille glyphs they will shop us as ? symbols.
Do you have any other questions that aren't related to font fallback and those ? symbols?

I should add: We are just roughly ~2 developers on this project right now and have >100M users to support. If your issue is not caused by conhost then we must close it to focus on those people that have an issue that is caused by it.
Currently it appears you don't have an issue caused by conhost, because the lack of font fallback is known and has been fixed in Windows 11.

Conclusion: If you use Windows 10 conhost with braille glyphs but your font does not support braille glyphs they will shop us as ? symbols.
Do you have any other questions that aren't related to font fallback and those ? symbols?

Yes. But just so you know, NPM uses braille unicode for the loading animation.
And NPM is quite spread.
The dots in the braille unicode are useful for many thing (but also a lot of other characters are missing without the fallback.
IMHO conhost should support font fallback as even NOTEPAD does.

I'm happy to hear that you could resolve your font issue, although it's unclear to me why it broke in the first place.

No Idea.. I noticed last week, what I was busy on a project... yesterday I dug in the problem and finally solved it.
Now all fonts are ok (there were no missing fonts before, but some registry keys got corrupted/missing somehow).
So I checked a few font related keys in registry then copied from another system, then reinstalled all fonts and finally did an sfc /scannow and dism  restorehealth...

@lhecker   after some more testing, everything is "sort of" working in OpenConsole.exe.
The only things I dont understand are:

Why SF Mono does not show up (it does in other apps including mintty and pterm)

why the cursor sometimes "ghosts" on previous lines (expecially when using openconsole.exe to run bash.exe)

Why SF Mono does not show up (it does in other apps including mintty and pterm)

I suspect you may still have a corrupted font database. You should make sure that your font exists in C:\Windows\Fonts. The %LOCALAPPDATA%\Microsoft\Windows\Fonts folder should be entirely empty. Afterwards, I'd uninstall the affected fonts and reinstall them.

why the cursor sometimes "ghosts" on previous lines (expecially when using openconsole.exe to run bash.exe)

That's probably a legitimate bug in our text renderer. We can continue talking about it over in #18038.
I'll be closing this issue for now, as there's nothing we can do about font fallback on Windows 10 at the moment. We can continue talking in #18038 about the cursor ghosting, and in #18044 about replacing conhost with OpenConsole.


Error reading .cfg file

Hi I have an issue on Linux, trying to create db files in an alternative directory
(system drive is 250gb nvme, so ~/.qgrep is no good for large datasets).
I specify the init and update commands with explicit pathways instead of a project name, as suggested in README.md.
Files are indexed/created, it seems to run without issue.
When trying to run a search (again using explicit pathway to .cfg file), I get error "Unable to read file.cfg".
I have created test directories on mounted internal drives, set permissions to 777 for pathway and all files to rule out permissions.
Are you able to replicate this?

Seems to work fine for me. Note that you need to specify the file path as relative (starting with ./) or absolute (starting with /) - this is consistent between different commands, so eg
qgrep init ./file.cfg folder
qgrep update ./file.cfg
qgrep search ./file.cfg term

should work.

Hi thank you for responding - and, also thank you for an amazing app, after trying multiple commercial tools, I came across yours and it's proven the potential to be a fantastic fix for me, once I iron out this issue - really nice work... :)
Interesting. I am specifying absolute paths.
I wonder - I downloaded the ubuntu performance release zip, so I have to do 'dot slash qgrep':
./qgrep init /mnt/etc.
...whereas you don't.

Maybe this is because you've compiled/installed and I haven't?
If so, which version of Ubuntu are you running, and how did you install? (when I tried to do git clone and run 'make' command, I got a gcc error about a missing file, which is why tried downloading the quick release zip).

I was actually using ./qgrep, I simplified above. Can you post the full command line and the error message?

Apologies for delay - vacation.
My commands are the same as yours.
Curious, I noticed that the cfg file was being appended with an underscore, which is why it errored. file.cfg_ was being created, which caused the error. I've rebuilt my system (needed doing anyway), and it seems to be working just fine now :-/


Specific View causes bug when hidden

Hi,
[Edit] "auto" in viewname causes bug.
Custom Header Installed: 1.1.7
HomeAssistant: 0.103.5
my config:
custom_header:
  hide_tabs: 'alex, alexauto'

The bug causes the header to appear twice, normal at the top and on the bottom again:

This only happens with this view, other views (multible) work fine
Do you need further information?
EDIT: Found the problem: If you include "auto" in viewname, this will cause the bug. Maybe a problem by parsing the config

I also ran into this issue when using the word touch. Looked at the code and found that the issue has to do with just two letters to. If your tab contains those two letters it will not work. So auto or touch were creating problems with the build range function.
Since currently the code is keying in on the letters to https://github.com/maykar/custom-header/blob/7397624a047cac77e80afe23a410b7a9b5b9ffd1/src/helpers.js#L51
Most likely the best option would be to search for to with spaces on either side instead of just to.
I am on Home Assistant 0.103.4, HACS 0.20.4, Custom Header 1.1.7

Ah, thats the source of problem. I didnt find any trim function in the js code. But changing https://github.com/maykar/custom-header/blob/7397624a047cac77e80afe23a410b7a9b5b9ffd1/src/helpers.js#L52
to
if (string.includes(' to ')) {
might solve the problem?

Yup, i just need to change the detection of includes 'to' to make sure that it is surrounded by numbers. Thanks for finding this one, will be fixed in the next release.

Please try the latest pre-release 1.1.9 and let me know if it helps. If using HACS you will need to "show beta" in order to see the release and install it. Thanks.

Should be fixed in latest release, if not please reopen.


Request: add a search bar

I think it would be nice to be able to search for things on website. These days I was thinking what courses related to The Graph exist, my first thought was to search it on on useWeb3, so I went to google: 'site:useweb3.xyz the graph'.

Great suggestion! Will definitely look into this

Added with the latest design update
E.g. https://www.useweb3.xyz/search?q=Security


Update harness-platform-faqs.md

Updated 5 Faqs to Platform page
Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ ] Issue
[ X] Feature

@deepanshuHarness Can you review and merge these

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


Added wildcard matching on MAC addresses.

It would be a nice feature to be able to wildcard match on mac adresses for interfaces. This is eg. useful for bonding where you would like all nics of a certain make or model to be added to the bond.
Using this feature you could do the following:
#cloud-config
rancher:
  network:
    interfaces:
      bond0:
        dhcp: true
        bond_opts:
          mode: 802.3ad
          lacp_rate: fast
          miimon: 100
        post_up:
          - ip route add <IP_ADDRESS>/0 via <IP_ADDRESS>
      # Add all Mellanox adapters to bond
      "mac=98:03:9b*":
        bond: bond0

Btw. I couldn't find anywhere to include a test for this. I'll be happy to add it.

Related to issue https://github.com/rancher/os/issues/2707

I've added a test for mac matching both wildcard and normal.

@mmriis  On my rancheros machine, bond0 can't be up, as the following:

I can only manually execute dhcpcd -MA4 bond0 to up bond0
Can bond0 be started automatically on your machine? cloud config file is ？
Here are my steps:
[root@rancher ~]# cat network.yml
#cloud-config
rancher:
  network:
    interfaces:
      bond0:
        dhcp: true
        bond_opts:
          downdelay: "200"
          lacp_rate: "1"
          miimon: "100"
          mode: "2"
          updelay: "200"
          xmit_hash_policy: layer3+4
      mac=08:00:27*:
        bond: bond0
        dhcp: false

[root@rancher ~]# ros install -d /dev/sda -c network.yml --append "rancher.network.interfaces.eth*.dhcp=false"
INFO[0000] No install type specified...defaulting to generic
Installing from rancher/os:v1.6.0
Continue [y/N]: y

I made a mistake. This is fixed by #2735


110 Form: Launch Plan March 10

As a program area team, we want to ensure we have connected all the requirements from the workstreams: technical, communications, security, privacy.
Technical

[ ] functional
[ ] tested
[ ] ready for launch

testing*

test will LDB before March 17

Communications

[ ] Careers & MyHR content
[ ] Log in Page
[ ]  service desk Comms for service BC (Document C)
[ ]  Digital Journeys mail box standard text for BCCS/BCeID (Document D)
[ ]  Review DS comm plan

Security

[ ] STRA
[ ] SOAR

Privacy

[ ] PIA

Technical
-[ ] functional
-[ ] tested
-[ ] ready for launch
Communications
-[ ] Careers & MyHR content
-[ ] Log in Page
-[ ]  service desk Comms for service BC (Document C)
-[ ]  Digital Journeys mail box standard text for BCCS/BCeID (Document D)
-[ ]  Review DS comm plan
Security
-[ ] STRA
-[ ] SOAR
Privacy
-[ ] PIA

Alison confirmed with form owner that LDB team will be ready to launch for March 17. We will need to build in testing access with LDB" into our launch plan. Perhaps the after March 10 and before March 17.

We will lock down changes to content, new functionality on March 3 to have enough time to deploy, test, etc.

At Feb 28
Technical

[ TBD ] functional - part 2 deployment for March 3
[ ] tested TBD
[ ] ready for launch

TO DO: Send LDB Lindsey/Don S/Stephanie (Writer) prod link after Friday
testing*

test with LDB before March 17
TO DO: End to end test with all authentication methods and user groups (PEA, LDB, regular employees
Date: March 3 start
Involved: Andrew, Chris, Fazil Ayush, writer
Meeting booked for Friday March 3 10 .am. to 12
Bug testing reported/tickets etc.

Communications

[X ]IN PROGRESS  Careers & MyHR content (Meghan/Stephanie has this in progress and will be ready for Thursday)
[ X] Log in Page (Complete)
[X ] DONE service desk Comms for service BC (Document C)
[X ]  DONE Digital Journeys mail box standard text for BCCS/BCeID (Document D)
[ X]  DONE Review DS comm plan (approved by BCID services team

Security

[DONE ] STRA - Security vulnerabilities complete and approved
[] SOAR - Ask Igor

**Privacy

[ ] PIA** BceID - Question for Nass

	Add/link the permanent URL for the 1.10 form on PROD:
https://digital-journeys.apps.silver.devops.gov.bc.ca/form/6402aeb21268f904ebba2c5d
Added to Careers & MyHR content

PIA signed with all signatures and sent to files

@Stella-Archer we will need to clear the environment before launch. I have created two tickets for regular ongoing maintenance, although this task will need to be done before March 17 launch. Let's connect about best timing for this

@Iman let's decide a time to make these pieces live on Friday morning.


[BUG]: http://localhost:3001/settings/embedding-preference , white page

How are you running AnythingLLM?
Docker (local)
What happened?
click embedder, then will become a white page
Are there known steps to reproduce?
I use docker compose  started anything-llm.
click  open setttings -> AI Providers -> embedder, then will become a white page

You probably have an invalid setting from whatever your docker-compose has set for the ENV. What embedder do you have set? This is a config issue as unable to replicate on current production build.

I have no .env file. just use compose.yaml to run it.
I want to know which is the default embedder.
I could not set embedder.

native is. In your compose YAML, you have to specify some ENVIRONMENT VARS and EMBEDDING_ENGINE: "native" needs to be one.


Check that adaptor exists before trying to use dbc

Please could this go onto release/83 branch also.

yes, we'll add that in, thanks

Thanks!

on branch as well now


problem after update

Dear all,
after the last upgrade, I am not able to perform variant2 pipeline, because it stops after the alignment step.
from the log
[2017-01-22T02:03Z] Timing: variant calling
Traceback (most recent call last):
  File "/usr/local/bin/bcbio_nextgen.py", line 234, in <module>
    main(**kwargs)
  File "/usr/local/bin/bcbio_nextgen.py", line 43, in main
    run_main(**kwargs)
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/bcbio/pipeline/main.py", line 43, in run_main
    fc_dir, run_info_yaml)
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/bcbio/pipeline/main.py", line 87, in _run_toplevel
    for xs in pipeline(config, run_info_yaml, parallel, dirs, samples):
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/bcbio/pipeline/main.py", line 150, in variant2pipeline
    samples = genotype.parallel_variantcall_region(samples, run_parallel)
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/bcbio/variation/genotype.py", line 175, in parallel_variantcall_region
    to_process, extras = _dup_samples_by_variantcaller(samples)
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/bcbio/variation/genotype.py", line 159, in _dup_samples_by_variantcaller
    samples = germline.split_somatic(samples)
  File "/usr/local/share/bcbio-nextgen/anaconda/lib/python2.7/site-packages/bcbio/variation/germline.py", line 29, in split_somatic
    if paired.normal_data:
AttributeError: 'NoneType' object has no attribute 'normal_data'
 returned non-zero exit status 1

ad the configuration:
details:
- algorithm:
    aligner: bwa
    mark_duplicates: false
    realign: false
    recalibrate: false
    variant_regions: /media/silvano/Disk1/install/bcbio-vm/data/bed/MODY_6_FINAL_1_Regions_Export_cleanfile.bed
    variantcaller: [freebayes, gatk-haplotype, samtools]
    ensemble:
     numpass: 2
  analysis: variant2
  description: 1_S1_L001
  files:
  - /media/silvano/Disk1/data/batch_004/data/data_ALL/1_S1_L001_R1_001.fastq.gz
  - /media/silvano/Disk1/data/batch_004/data/data_ALL/1_S1_L001_R2_001.fastq.gz
  genome_build: GRCh37
  metadata:
    batch: batch4
    phenotype: normal
    sex: male

some could please have any suggestion? I already perform again all update steps again.
Best
Silvano

Silvano;
Thanks for the report and sorry about the issue. The underlying problem is that you have a batch, batch4 with a single sample labelled as phenotype: normal. normal and tumor are used for tumor/normal pairs so having a batch with a single normal confuses the logic that deals with these pairs. If this isn't a cancer sample where you need somatic calling, the right thing to do is to remove phenotype: normal, then it should proceed as intended. I also pushed a fix to avoid the confusing error to the latest development. Hope this gets it running smoothly for you.


Update README.md

Updated header levels; removed unnecessary installs: git-core is already installed on latest Raspbian image (May 2016), sqlite3 is installed during Ruby upgrade, and arduino will be installed during farmbot-arduino-firmware installation.

Whoops! Did not see this one- sorry @gabrielburnworth . Merging now.


VelocityJS Meteor package will not install in Docker within a Circle CI build

You can recreate the issue easily by SSHing into any circle ci build (that has Docker) and executing these commands.
docker run -a stdin -a stdout -a stderr -i -t ubuntu /bin/bash
apt-get install curl
curl https://install.meteor.com/ | sh
apt-get install vim
cd /home/
meteor create app
cd app/
vim .meteor/packages

Once in VI, append a newline with velocityjs:velocityjs. Then exit VIM and run this command to execute the installation:
meteor update

You will get this error:
Error: EINVAL, chown '/tmp/<random dir>/<package you added>'

Running this in docker on my machine (Mac OS X) works correctly, but in CI, it always throws the error.
Questions I am trying to answer:

Why does it happens on a circle box, even though it's all within a docker container?
Why do certain packages (like velocityjs:velocityjs) trigger the error? bjwiley2:server-watch does as well.

What I've tried with no success:

Switching the directories that the meteor app is created in
Using sudo to try and fix the chown issue
chown nobody:nogroup /tmp
Cloning bjwiley2:server-watch into my projects packages directory to see if it would run locally (it did)
Installing package dependencies directly (like http and jquery) to see if one of those was the problem
Tried to recreate problem on Ubuntu Server to see if it was working locally only because I was on OS X. It worked. the problem is still only on circle boxes.

@benwiley you should post this in the Meteor package.

Please follow up if this wasn't fixed. Velocity now has no dependencies (such as jQuery), but Meteor / Docker are pretty specialised subjects to know about.
This sort of question often works better on StackOverflow - though bugs / changes relating directly to Velocity should always end up back here :-)


Pipette Gen2: Alert User in Modal if Pipette Incompatible

As a robot user, I would like to be alerted if the pipettes attached to my robot are incompatible with the pipettes attached to my robot, even though they appear to be the same model.
Acceptance Criteria

[ ] If pipette specified in protocol and pipette attached to robot are incompatible:

[ ] Display an error message below the "Go To Pipette Setup" on Pipettes card on File Info page
[ ] Display an alert modal warning them of the incompatibility

[ ] If pipette is a 1st generation pipette, add 'older' before name (see design).
[ ] If robot and protocol both have two incompatible pipettes, list all pipette names in modal
[ ] If robot and protocol have one incompatible and one mismatched pipette, display incompatibility modal.

Note full compatibility table is here:
https://docs.google.com/spreadsheets/d/1M6azQXZocWTqnEZDQ1Bpp9V1F9Fn86otdd4Go_LTIlQ/edit#gid=0
Implementation Note

[ ] Need to track pipette generation as a variable

Design
Single pipette incompatibility:
https://app.zeplin.io/project/5aa97729db58a2192f10d0d6/screen/5d0217088ac43c5dd4da8ef9
Two pipette incompatibility:
https://app.zeplin.io/project/5aa97729db58a2192f10d0d6/screen/5d0323f7ade24819ee212941
Implementation Notes

Use this story to add generic warning framework (handle warnings from robot in run app)?

Decided in estimation to display an alert modal for all protocol <> robot pipette incompatibilities, not just gen2/gen1 issues.
FYI @pantslakz

@umbhau @pantslakz I have a few questions about this ticket:

Why are we adding yet another modal instead of augmenting our existing warning section for pipette incompatibilities?
Why are we allowing the user to continue if we know the pipettes are not compatible?

Closed by #4185


fix: fixes side effects between calls when a file does not exist in parser

Currently parser mutates its state in order to resolve relative imports, however when an import file, it keeps the reference of the current directory relatively to the failing file, leading to an error in the next file (because the currentDir reference is stuck in the previous one).

Codecov Report
Base: 77.49% // Head: 77.53% // Increases project coverage by +0.03% :tada:

Coverage data is based on head (66bc4cf) compared to base (9d77c5a).
Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           v3/dev     #584      +/-   ##
==========================================
+ Coverage   77.49%   77.53%   +0.03%
==========================================
  Files         145      145
  Lines        7358     7362       +4
==========================================
+ Hits         5702     5708       +6
+ Misses       1418     1416       -2
  Partials      238      238

Flag
Coverage Δ

default
72.98% <85.71%> (+0.08%)
:arrow_up:

examples
26.12% <57.14%> (+0.04%)
:arrow_up:

ftw
54.88% <57.14%> (+0.02%)
:arrow_up:

ftw-multiphase
54.98% <57.14%> (+0.02%)
:arrow_up:

tinygo
71.01% <85.71%> (+0.09%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

internal/seclang/parser.go
92.62% <85.71%> (+0.25%)
:arrow_up:

internal/io/file.go
17.39% <0.00%> (+8.69%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


remove deprecated uses of SASS division operator via sass-migrator

Description
Closes https://github.com/nhsuk/nhsuk-frontend/issues/752
Checklist

[ ] Tested against our testing policy (Resolution, Browser & Accessibility)
[ ] Follows our coding standards and style guide
[ ] CHANGELOG entry

Hey @britannio thanks for opening this pull request and sorry for the delay in the response, we've had a bit of annual leave and people moving around within the team recently.
I will take a look at this sometime this week.

Hey @britannio this all looks good, are you to OK to bump the package.json and package-json.lock versions to 5.1.1 and add a new entry to the CHANGELOG under the heading 5.1.1 - Unreleased?

We may need to review the impact on projects still using compilers (eg. Ruby Sass, Dart Sass and Ruby Sass) before we progress any further than this. The support for those compilers is still non existent so we have to weigh up the trade off between a modern compiler giving a warning about very recently deprecated functionality compared to breaking some compilers all together.

Hey @britannio this all looks good, are you to OK to bump the package.json and package-lock.json versions to 6.0.0 and add a new entry to the CHANGELOG under the heading 6.0.0 - Unreleased?

Done!

@chrimesdev Anything else I need to do here?

Hey @britannio see my comment above, this will be quite a big breaking change for people using other compilers. I'm not sure we are quite ready to make the switch.

@chrimesdev are you still considering this for a v6 release?  And if so, do you have a timeframe for that?
We're seeing lots of noise in the CI since we upgraded to the latest sass.  Whilst I agree you don't want to break other consumers of the lib, major version bumps are always the time to do it.

This would be a great change to have, as node-sass has some security issues, and switching to latest sass would fix this.  But in tryin the switch, I hit this error.
Sass 1.33 is now 5 months old, so this would be a reasonable time to make the upgrade.  If people don't want to upgrade, they can just not upgrade to the lastest nhsuk-frontend for a while.

Closing this as we're updating the version of sass required in our v7 alpha


Eureka client using vulnerable version of apache commons-configuration.

Hey, one of our internal security scans reported Apache commons-configuration version 1.10 used in eureka client library, this version has the following vulnerabilities : CVE-2024-29133, BDSA-2024-0705.
Any particular reason we are not considering an upgrade for this dependency?

Closing since on further internal analysis, the vulnerability is only applicable for versions 2.0 -> 2.10

@Gautham-JS It looks like this vulnerability was actually brought in from commons-configuration:commons-configuration:1.8 . The recommendation is currently to upgrade to the 2.10.1 version.

[Vendor] team discovered that [CVE-2024-29131] was also introduced in version 1.8 of the predecessor package commons-configuration instead of only affecting versions from 2.0 before 2.10.1 as stated in the advisory.

https://github.com/ESAPI/esapi-java-legacy/discussions/843
I have raised this as a new issue: https://github.com/Netflix/eureka/issues/1556


Upload and Download of Prometheus configuration file

What this PR does / why we need it:
This PR enables us to

Upload a configuration file to Prometheus
Download the configuration file from Prometheus

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
NA
Special notes for your reviewer:
The similar API is going to be used to upload and download configuration files for all telemetry 3rd party components, like Prometheus, Alert manager, Node exporter etc. The general flow is as below
Upload

Backup the current configuration file with extension .bak
Upload the configuration file to the server, in the right location
Call some API or POST request to reload the configuration (if the 3rd party supports it)

Release note:

Upload API
http://localhost:50040/v1beta/metrics/uploadconf?conftype=prometheus
// the value of the conftype determines the component, like 'prometheus', 'nodeexporter' etc.

Download API
http://localhost:50040/v1beta/metrics/downloadconf?conftype=prometheus
// the value of the conftype determines the component, like 'prometheus', 'nodeexporter' etc.

@skdwriting @wisererik @xing-yang Please review

This is tested for Prometheus, am now extending it to the other 3rd party components too...that is a WIP

Coverage decreased (-0.1%) to 29.969% when pulling 94fe1b2ed501306815774b3f2b56cccd70ac7d53 on rhsakarpos:updownload into 548f718411749229eca17c75a0126d5119be1c54 on opensds:development.

I mean can you move the code in fileops.go to metrics.go. Because downloadconf and uploadconf is subpath under metrics.

refactored, moved into metrics.go

Please rebase it.

Please rebase it.

Done

Also need a rebase.

@wisererik Please take a look at this PR.


housekeeping: Use GitHub Actions

What kind of change does this PR introduce?

Migrates away from Azure Devops to GitHub Actions
What is the current behavior?

Building on Azure Pipelines
What is the new behavior?

building on GitHub Actions
What might this PR break?
The build
Please check if the PR fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:

Update to your test to be against .net core 3.1 and it should fix one of your build issues.

[ ] You'll need to add coverlet msbuild
[ ] Delete cake files
[ ] Delete azure pipelines file
[ ] Remove shouldly
[ ] Update stylecop analyser

In a separate pr

[ ] Change GitHub actions badge to readme
[ ] remove azure DevOps from branch pr required actions for approval.
[ ] Add GitHub action build to the branch pr requirements


[bug] Codestral update

Issue
Using mistral/codestral-latest leads to this bug:
Unexpected error: litellm.AuthenticationError: AuthenticationError: MistralException - Error code: 401 - {'message': 'Unauthorized', ...}
The codestral api has changed and the codestral keys are separate from the main mistral keys:
https://docs.mistral.ai/capabilities/code_generation/
LiteLLM has updated it:
https://litellm.vercel.app/docs/providers/codestral
The new model name in LiteLLM is "codestral/codestral-latest" and the key is sotred in "CODESTRAL_API_KEY".
Moreover, in my experience, codestral often abbreviates big chunks of code with "// Rest of the code...". Is there a way maybe to change the prompt to avoid this behavior?
Thank you for this great tool! It really changed my way to think about AI augmented programming.
Version and model info
Aider: v0.39.0
Model: mistral/codestral-latest --> should be changed to codestral/codetral-latest

Thanks for trying aider and filing this issue.
I'm not aware that aider has any hard coded config for codestral. Whatever litellm supports should work with aider.

I just upgraded to v.040.0 and it works now, thanks. I still get warning though and indeed, it seems that the codestral variables are not updated on litellm:
https://github.com/BerriAI/litellm/blob/main/model_prices_and_context_window.json
I'll update the bug on the litellm project.
> aider --model codestral/codestral-latest --message "test"
Model codestral/codestral-latest: Unknown model, context window size and token costs unavailable.
Did you mean one of these?
- mistral/codestral-latest
https://aider.chat/docs/llms/warnings.html
Aider v0.40.0
Model: codestral/codestral-latest with whole edit format
Git repo: .git with 9 files
Repo-map: disabled

I'm going to close this issue for now, but feel free to add a comment here and I will re-open or file a new issue any time.

@guyomes have you found a fix for the "rest of code" response? Codestral seems to be getting it from the prompt, where it should explicitly avoid doing that. Maybe putting it lower in the stack would help?


Forms - Number Field (min/maxDigits + precision)

Issue Description
For clinical documentation, the number field is missing three props that will need to be added:

Precision (show a given number of decimal places)
minDigits (require minimum number of digits)
maxDigits (limit digits like a max character count)

Issue Type

[ ] New Feature
[X] Enhancement
[ ] Bug
[ ] Other

Expected Behavior

minDigits/maxDigits - similar to maxLength and minLength for Text Field.

Current Behavior
Not existing - new properties to add.

Orion JIRA created

@neilpfeiffer, I have couple of questions regarding this enhancement:

If maxDigits is specified, does it apply to just the integers(numbers before the decimal point) 'or' the entire number(all numbers both before and after the decimal point).
If precision is specified, do we always show the value with the specified number of decimal points 'or' or just keep the precision value as a limit.
eg. precision=3 and values=12.3, so in this case do we display the value as 12.300 'or' leave it as 12.3
If maxDigits does include the entire number and also precision is specified then which gets preference in the scenario where maxDigits < precision.
Also should these properties be applied actively or passively.
eg. If maxDigits=3 then do we prevent the user from entering the value after the limit is reached 'or' Do we just accept the input and process the value on onBlur/onChange or just throw an error?


Loading spinner while uploading attached Image

While on slower connections the user flow for attaching an Image to a message is sub-optimal. Often what happens if you've typed in text and then attached an Image to the message. The text shows up as sent but the image takes a few seconds to upload. A couple of times now I've actually re-uploaded the image and sent another message only to have the post then duplicated.
To solve this I think we should show a loading spinner along with the name of the file being uploaded which is then replaced by the actual image thumbnail once its done.

Will be fixed by #2887


Wrongly handled request errors without response from Freebox

Hi,
in function request, we have:
} catch (error) {
    const {status, data} = error.response;

But in some cases, axios can return an error without a response field
cf. example at https://www.npmjs.com/package/axios#handling-errors
axios.get('/user/12345')
  .catch(function (error) {
    if (error.response) {
      // CASE 1: The request was made and the server responded with a status code
      // that falls out of the range of 2xx
    } else if (error.request) {
      // CASE 2: The request was made but no response was received
    } else {
      // CASE 3: Something happened in setting up the request that triggered an Error
    }

CASE 2 happened on my side (because freebox was completely down).
The Case 2 is not handled and leads to an unexpected exception: TypeError: Cannot destructure property 'status' of 'error.response' as it is undefined.

Really interesting use-cases ! Thanks a lot !!
I will fix it asap :)

Now available in<EMAIL_ADDRESS>

Superb, thanks !


Research Telemetry

Need to research how to handle telemetry.

This will be put on hold until the update for Xbox telemetry changes are complete.


[T6A1][W14-B4] Loh Zi Bin Robin

Apply Dependency Inversion Principle [LO-DIP]

Use Dependency Injection [LO-DI]

Apply Open-Closed Principle [LO-OCP]


[stable/grafana] Allow for full updateStrategy customisation and align naming.

What this PR does / why we need it:
We want to be able to customise the rollingUpdate strategy, i.e. set maxSurge and maxUnavailable parameters.
Also I made the naming of the value match what nginx-ingress has, I know it is still inconsistent between charts but I thought I could at least reduce the inconsistencies. Let me know what you think about that.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
Special notes for your reviewer: This is a breaking change for the values, should that bump the major version or is minor fine?
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

Please fix conflicts.

Will try and fix in the next few days.


💡 [FEATURE] - Add Godly UI/UX Design Inspiration

Idea Contribution

[X] I have read all the feature request issues.
[X] I'm interested in working on this issue
[X] I'm part of GSSOC organization

Explain feature request
Godly is a website dedicated to providing top-tier web design inspiration. It features a curated collection of exemplary web designs from various categories such as AI, Web3, portfolios, startups, e-commerce, and more.
Explain your solution
The platform aims to showcase the best in web design to inspire designers and developers, highlighting innovative and aesthetically pleasing projects across multiple industries.
Any alternative approaches/features
No response
Additional Context
No response

I would like to work on the issue, kindly help me add label

Please Assign this to me under GSSOC'24.


Fix chain controller pending queue

Updated ChainController.on_block_validated() to properly manage the pending blocks queue based upon the result of the block validation.
To test this fix:

In validator/sawtooth_validator/execution/executor.py line 230, replace:

self._executing_threadpool = ThreadPoolExecutor(max_workers=5)
with
self._executing_threadpool = ThreadPoolExecutor(max_workers=100)

In integration/sawtooth_integration/docker/poet-smoke.yaml, after the line:

sawtooth.consensus.algorithm=poet \
add the following lines:
sawtooth.poet.target_wait_time=5 \
sawtooth.poet.initial_wait_time=0 \

Run the PoET smoke test:

cd integration/sawtooth_integration/docker
run_docker_test poet-smoke.yaml
Hopefully test will pass.

To test this fix:

In validator/sawtooth_validator/execution/executor.py line 230, replace:

self._executing_threadpool = ThreadPoolExecutor(max_workers=5)
with
self._executing_threadpool = ThreadPoolExecutor(max_workers=100)

In integration/sawtooth_integration/docker/poet-smoke.yaml, after the line:

sawtooth.consensus.algorithm=poet \
add the following lines:
sawtooth.poet.target_wait_time=5 \
sawtooth.poet.initial_wait_time=0 \

Run the PoET smoke test:

cd integration/sawtooth_integration/docker
run_docker_test poet-smoke.yaml
Hopefully test will pass.

Anyone know why this didn't kick off a build?

PR pushed addressing @cintel comments.

Updated PR with code for another bug @nick-drozd found and addressing @peterschwarz comments.


Multiple Tree Node Drag and drop

What problem does this feature solve?
Our Tree involves Drag and drop of multiple tree nodes, not only selection of multiple nodes.
What does the proposed API look like?

This issue has been closed due to inactivity.
Please file a new issue if you are encountering a similar or related problem.


[Request]: Can I edit in shopify Backstage

Operating system
mac m1
Node.js version
14.18.0
Shopify CLI version
2.7.1
Browsers
Chrome
Version
4 (Current)
Modifications
No response
Details
At present, my store uses shopify-theme-lab, but I found a problem, because the vue file is packaged and then published online. If I want to change a picture in the shopify background after publishing, then this The structure does not seem to be established, I need to pull it down and repackage it before pushing，I would like to ask if there is any solution
Notice

[X] I read the notice

thank you very much!🙏🏻

I am not sure this is a bug.
After you have set an image on Shopify (using Shopify's image_picker), The image settings will be updated on the templates/[your-page].json
When you are in development mode, I am sure you can open the Shopify code editor on the editor/customize page. Copy the settings with image links, and put them in your .json file.
In short:
In development mode, remember to download your settings from Shopify first before you deploy the theme.

thank，At first I thought it would not be updated, but later found out that it would be updated @haotan19


Fix flaky testRelocatedClosedIndexIssue

Summary of the changes / Why this improves CrateDB
855033d6afae73fd6e958db31a466369103bbf22 fixed one issue, but introduced
another 🤦
Checklist

[x] Added an entry in CHANGES.txt for user facing changes
[x] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

retest this please
fastly hiccup


Frame Experimental, novelty and innovation as important part of technology market cycle

We often as humans are stuck with something usually widely popular, good to use and mainstream, because might be good and not need to seek or explore new stuff, that's what's called the stagnation phase.
In technology, it's quite dangerous.
I can briefly draft, that hence introduction facebook in 2004 or twitter in 2006, it changed how we interact on Internet, from one-to-many (radio, television, newspaper) to ability people to express their mood, psychological needs, intents &c through write, that's where we marked up web2
Within web3 we have introduced two new primitives, called ownership or trust, depending on perspective.
Within web3 people, we are bit in stagnation from the perspective of recent DeFi 1.0 ponzinomics and rug pulls, JPEG summer 2021 also felt like static pictures with zero utility nor accounting for virtue signalling.
What should be put into writing?
The important part would be to highlight the methodologic how experiments are being born, why novelty drives product adoption, and why keeping the innovation bar high is more important than anytime before.
This writing could be potential help https://metaprime.network thrive based on your storyline :)
Ref

https://www.goodreads.com/book/show/11797471-the-idea-factory?ac=1&from_search=true&qid=ILUol2af4L&rank=1
https://twitter.com/yangWao/status/1516550604289716235

Is this issue Open to work on?
I'd like to take a look at it


ERC20 tokens

ERC20 tokens ( eg ETH, BAT, ZRX, REP) are not displayed in Verus Desktop 0.6.4 beta. The balance is empty and there is no transaction history.
It looks like something has changed on the ETH electrum servers, since the unsupported Verus Agama displays similar issues, showing NaN for balance.
Behaviour is consistent on Linux, MacOS and Windows versions.

Auch ChainLink ist betroffen

An update for ERC20 tokens is in prospect soon?

Can some progress with this issue be made?

Können mit diesem Problem einige Fortschritte erzielt werden?

Concerns, VerusWallet Desktop:
Unfortunately no progress in this matter, ERC20 tokens (chainlink) NaN are not synced.

Should be fixed here, and released in the upcoming release. If anyone still has troubles with this issue after that feel free to re-open.

Installation Verus-Desktop v 0.5.2 ín the folder of the previous version.
Leave the current wallet dat in VRSC.
Message:
Unexpected token < in JSON at position 0

Same here.... OSX version.
On Thu, May 21, 2020 at 4:48 AM cryptopoli<EMAIL_ADDRESS>wrote:

Installation Verus-Desktop v 0.5.2 ín the folder of the previous version.
Leave the current wallet dat in VRSC.
Message:
Unexpected token < in JSON at position 0
[image: vrsC_V6 5 2_2020 05 21_09h43m27s_002_]
https://user-images.githubusercontent.com/38912635/82535902-e084bc00-9b47-11ea-92e3-d8c844b7c275.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/VerusCoin/Verus-Desktop/issues/25#issuecomment-631940298,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQC7YRNT4XMJYPYXT3XEELRSTMF5ANCNFSM4LC6ETFQ
.

ETH/ERC20 Token problem behoben.

@cryptopoli @crackfoo Both the ERC20 issue and the Unexpected token issue should be resolved in 0.6.5-3, please download here and if an issue persists, feel free a new GitHub issue, rather than commenting on an unrelated one. (regarding the unexpected token problem, not the last comment by @cryptopoli)

yes, all is working as expected now, thanks!
On Wed, May 27, 2020 at 2:06 PM Michael Toutonghi<EMAIL_ADDRESS>wrote:

@cryptopoli https://github.com/cryptopoli @crackfoo
https://github.com/crackfoo Both the ERC20 issue and the Unexpected
token issue should be resolved in 0.6.5-3, please download here
https://github.com/VerusCoin/Verus-Desktop/releases/tag/v0.6.5-3 and if
an issue persists, feel free a new GitHub issue, rather than commenting on
an unrelated one. (regarding the unexpected token problem, not the last
comment by @cryptopoli https://github.com/cryptopoli)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/VerusCoin/Verus-Desktop/issues/25#issuecomment-634807252,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQC7YU3CA65NGOQKJSOVXLRTVCCXANCNFSM4LC6ETFQ
.

@michaeltout   ERC20 token new problem!   VerusDesk v 6.5-3  token will send with message:  "gas required exceeds allowance (999991) or allways faling transaction"   Acknowledged?    ETH: Receive no result visible?


Use Crawly.Engine.list_know_spiders instead of Crowly.running_spiders

According to this comment here
Crawly.Engine.list_know_spiders()

should be used instead of
Crowly.running_spiders()

Thanks, @cmnstmntmn, This is interesting. I'm giving it a try.

Yes, it seems Crawly.Engine.list_know_spiders() hangs

Sorry, I was on another project for quite a bit of time. I have rebased your PR and will merge it as a part of https://github.com/elixir-crawly/crawly/pull/291


Bug - codeunit 7301 "Whse. Jnl.-Register Line" - InsertToBinContent

With Issue 17142 the Procedure InsertToBinContent  in codeunit 7301 "Whse. Jnl.-Register Line" was changed from local to global
(https://github.com/microsoft/ALAppExtensions/issues/17142).
When this procedure is now called from external code the Location Variable (global Variable) which is used in the Function is not set which can lead to incorrect Bin Content Data if a Location with "Directed Put-Away and Pick" is used.
A Call of the procedure GetLocation is missing before the marked Line: GetLocation("Location Code")

Already fixed

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: .


Add new batch of surveys for dec 12th onwards

4 new surveys that start on December 12th
Trello:

https://trello.com/c/v331EZLi/75-gov-uk-survey-2nd-user-research-panel-sign-up-1-of-2
https://trello.com/c/yVAzaUsY/76-gov-uk-survey-2nd-user-research-panel-sign-up-2-of-2
https://trello.com/c/q0lvlpxP/77-gov-uk-education-content-survey
https://trello.com/c/kvnN8tfW/79-gov-uk-survey-1st-family-in-uk

Merging this without a 2nd pair of eyes because my team is down to one and this needs to go out today.  I've pushed this to integration for testing and had the ok from the product owner.


Avoid allocation when deserializing Timestamp

Description of change
This PR is a performance improvement.
Deserialization of Timestamp will now go via TryFrom::&str instead of TryFrom::String. Benchmarks show that this makes Timestamp deserialization between 7% and 13% faster.
Links to any relevant issues
Be sure to reference any related issues by adding fixes issue #.
Type of change
Add an x to the boxes that are relevant to your changes.

[ ] Bug fix (a non-breaking change which fixes an issue)
[ ] Enhancement (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Fix

How the change has been tested
All tests run locally. Performance improvements have been tested with cargo bench (using criterion) locally.
Change checklist
Add an x to the boxes that are relevant to your changes.

[x] I have followed the contribution guidelines for this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

This breaks the Stronghold bindings:
[Example] Error: javascript function threw an exception: JsValue(Error: invalid type: string "2022-05-09T13:23:17Z", expected a borrowed string
Error: invalid type: string "2022-05-09T13:23:17Z", expected a borrowed string

Will look into this now. If it causes too much trouble I will close the PR (thought this should be a very simple change).

If datetime parsing performance is important we could also consider humantime.

If datetime parsing performance is important we could also consider humantime.

This PR is not related to any issues on our roadmap and can therefore not be considered important at this point. The only reason I started working on this is that I initially thought it would be as simple as a one line changing (changing #[serde(try_from =String)to#[serde(try_from = &str)]`) which would have been a very easy win with almost no overhead had that been the case. When that turned out to not be the case I was curious why and wanted to see how it could be fixed which is what this PR now does.
For now I would suggest not going further down the rabbit hole. Hence we should either merge this or simply close this PR. I would personally be fine with either.