Apply recent changes from pipeline.process to pipeline.process_batch

We changed output folder structure in order to have one output folder for every pipeline run. We also add the json file to this folder.
These changes have to be applied on the pipeline.process_batch method as well.

95522806e359c1bdbfa153e76fdf3894c711a73a


Turned react component from class to function

As the title states, the react component became a function component to respect modern react patterns.

@jbicker I have updated the test as discussed offline. Please have a look.
I also moved isReInitRequired to utils and did not make it deprecated for now.


Missing Chibi

Summary
There is no chibi at the bottom righthand corner of android studio
...
Expected behavior
A chibi to be present in the bottom right hand corner when chibi is enabled
...
Actual behavior

...
You can also add Screenshots for a better understanding.
Environment
Android Studio 3.3.2
Build #AI-182.5<IP_ADDRESS>14842, built on February 15, 2019
JRE: 1.8.0_152-release-1248-b01 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Linux 4.15.0-46-generic

 ddlc-jetbrains-theme Missing Chibi

I fixed it by updating Android Studio.


Changing the credentials for mysql

Hi, this looks like a great app.
I'm getting java.sql.SQLException: Access denied for user 'root'@'localhost' (using password: YES).
Where can I change this in your code? Where can I alter the values of the db.* properties in the application.yml? Thanks.

Thanks.
You can change the DB configuration in the application.yaml (src/main/resources/application.yml).
spring:
  datasource:
    url: jdbc:mysql://${db.host:YOUR_HOST}:${db.port:YOUR_PORT}/${db.name:YOUR_DB_NAME}?useSSL=false
    username: ${db.uid:YOUR_DB_USER}
    password: ${db.pwd:YOUR_DB_PASS}
    driver-class-name: com.mysql.jdbc.Driver


Added manifest.json to enable support for LPM.

Thanks!

Opened a PR in the plugins repo to point to the latest commit lite-xl/lite-xl-plugins#329.
Let me know if there's anything else you want to add before 0.1.1 is "released" there.

Use that commit, I don't anything new to add.


GeoJSON crashes in Cesium

This is a regression where it used to work in 1.53. In this Sandcastle, a GeoJSON is loaded and crashes with:
DeveloperError: EllipsoidRhumbLine must have distinct start and end set.

I'm not sure if it's related to https://github.com/AnalyticalGraphicsInc/cesium/issues/7550. But you can fix this by forcing the arcType to be Cesium.ArcType.GEODESIC (by uncommenting line 18 in the Sandcastle).
Should this be a case where we handle this error and make it a warning, and attempt to draw the GeoJSON anyway? Or was this never a valid GeoJSON to begin with?

@shehzan10 do you have any insight here? I believe it broke with the rhumb line PR we added.

@shehzan10 @OmarShehata Any chance this will get looked at by Monday?

Thoughts from Shezhan over Slack:

I think only circular polygons are valid. And I do think we handle them. Not sure why in this case its failing. Maybe some 2 other points are the same.
Maybe we need to check the point before creating the geometry

It's still unclear if the GeoJSON itself is valid or not. I'm still hoping look at it myself to try doing this check to at least make it not crash.

There are problems with polygons that intersect the antimeridian as seen in QGIS.

Thanks for looking into it @GatorScott. I've removed the priority - next release because it sounds like the GeoJSON may have some problems, and there is an easy workaround the user can do to get it working.


/feature adds codebuild

The changes across a large part of the repo shouldn't be merged with the addition of a dashboard. We also haven't been able to make steady progress in needed changes to merge codebuild dashboard. I'm closing to move us towards a fresh start on the codebuild PR.


feat(instrumentation-pg): implementation of metric operation duration

Which problem is this PR solving?

Part Of #2348

Short description of the changes

This PR implements part of the Semantic Conventions for Database Metrics. I will break down the implementation on different PRs to facilitate the review process.
This PR focus on the metrics:

db.client.operation.duration

This PR does not contain all attributes, because all the ones that require parsing of the query will be more complex and need dedicated testing for performance and be opt-in, so I will leave those for the next PR
Note for reviewers: I still need to add tests to this PR

@pichlermarc friendly ping if this can be merged

Failing tests are actually caused by #2445 - I'm not sure how to fix that yet. :disappointed:

The test failures now seem related to the previous PR https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2349 which seems to have introduced some flakiness in the tests.
I've re-started, but it's something that we need to address.


Backport: Enable serial console on ttyS0

Combine login getty logic with IPMI serial over LAN, adding all serial
consoles to the kernel command line.
Backporting for upgrades to existing customers with serial consoles.
Conflicts:
roles/common/tasks/main.yml

Jenkins run passed, but callback failed.


Restart openshift-apiserver only if aggregator-client-ca is expired

This cert is eventually renewed at startup. If it is renewed, we need to
wait for it and restart openshift-apiserver. Since this cert is located
both in a configmap and on the disk, we prefer to read it from the disk:
it is faster to access and more reliable.
If the cert is not expired, openshift-apiserver will correctly start.
crc start will take less time when the bundle is fresh (< 30 days).
follow up of https://github.com/code-ready/crc/pull/1532

Any thoughts on this @praveenkumar ? Should we get that in ?

/lgtm


<time tooltip broken in Drafts

The <time widget tooltip is broken inside Drafts. Ideally, the tooltip should show up properly. If that is somehow not possible, the tooltip could be turned off.

@zulipbot claim

@zulipbot abandon

@alya you might want to close this issue since it has been fixed!

Ah, great, thanks! (confirmed in dev)

@timabbott do we know how this was fixed?

Yes, a PR from last year that addressed this for both drafts and message edit history was merged a few weeks ago; for some reason I'm having a hard time finding the PR ID but it was by @m-e-l-u-h-a-n.

It was https://github.com/zulip/zulip/pull/18234.


Fix the getserver information

The information is encoded twice by the server, so it needs to be parsed twice. It's been like this for a while, but I never got around to pulling a fix to it until you commented the stuff out.

@sirDonovan
I, Isaac Bruce (Mystifi), license all my contributions to The-Scribe, past and future, under the MIT license, reproduced below.
The MIT License (MIT)
Robin Vandenbrande and other contributors
For some parts of the code taken from Pokemon Showdown:
Copyright (c) 2015 Guangcong Luo and other Pokemon Showdown contributors
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.
 IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

Thanks @Mystifi


Fix non-standard keyword "function" in package script

Ref:
The warning from ShellCheck:

SC2113: 'function' keyword is non-standard. Use 'foo()' instead of 'function foo'.

@PeterDaveHello thanks!


Added support for an @online/@here

Closes #2183

Automated message from Dropbox CLA bot
@TigorC, it looks like you've already signed the Dropbox CLA. Thanks!

Rebased and now present in #4110.


Create interface for security Part1

What changes are proposed in this pull request?
Create interface for security
Why are the changes needed?
Create interface for security
Does this PR introduce any user facing changes?
NA

alluxio-bot, merge this please

alluxio-bot, merge this please


Add Spring Data Meilisearch to community integrations

Pull Request
Related issue
None
What does this PR do?
Spring Data Meilisearch provides the integration of meilisearch with the Spring framework.
An abstract layer called Repository in Spring Data allows for easy data processing.
PR checklist
Please check if your PR fulfills the following requirements:

[ ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
[x] Have you read the contributing guidelines?
[ ] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Hi @junghoon-vans 👋
Thanks for opening a PR. I've merged it. 🙌


add docs for dvc metrics diff

Fixes #921 (to reflect iterative/dvc/pull/3051)

OK I think https://github.com/iterative/dvc.org/pull/933#discussion_r378681324 was the only pending thing here actually – now addressed in the latest regular updates PR.
The rest was extracted to #959


OOM

airflow-init_1       | WARNING!!!: Not enough memory available for Docker.
airflow-init_1       | At least 4GB of memory required. You have 2.0G
airflow-init_1       |
airflow-init_1       |
airflow-init_1       | WARNING!!!: You have not enough resources to run Airflow (see above)!

Docker 기본용량 2G -> 4G 증설로 이슈 해결


Add light_write_interface_block

Add light_write_interface_block

Codecov Report

Merging #19 (ac331cd) into master (68a8bef) will increase coverage by 1.60%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   72.96%   74.56%   +1.60%
==========================================
  Files          17       17
  Lines        1080     1148      +68
==========================================
+ Hits          788      856      +68
  Misses        292      292

Impacted Files
Coverage Δ

src/light_pcapng_ext.c
77.58% <100.00%> (+0.24%)
:arrow_up:

tests/test_write_pcapng.c
97.82% <100.00%> (+5.23%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68a8bef...ac331cd. Read the comment docs.


Integrate with Mailtrain

In addition to #8, it would be nice to integrate also with Mailtrain.

https://github.com/andris9/mailtrain

What do you envisage this integration looking like? Do you want apostello emails to go through mailtrain or something else?
It looks like you need to bring your own smtp server (or service like mailgun) to use mailtrain. Could you not just use the same smtp server with apostello?
Also, the list of cons, makes me wary of spending any time on an integration.

@monty5811 I think Mailtrain will survive as pretty much there are no other open-source alternatives. I think, if integration is made, it should be done via a plugin so that Apostello can be integrated with Mailchimp, etc. The idea would be to abstract to Address Book so that it can be mounted from external sources as well, and possibly just cached locally for performance. So, this is not so much about using Mailtrain to send emails.
For example, this is how I envision the perfect system:

People sign up in one place and elect how to get notified for different types of message - email, text message, maybe other means in the future, too.
When I message needs to be relayed to a group of people, it honors their communication preference.

That would be cool.
I think the best way to do it would be to expose the apostello contacts list via an api. What do you think?
This should be fairly easy to do, too as all the groundwork is already there - the tables are all loaded via API views that we just need to expose so other services could access them.

The next release will allow access to the API so I am going to close this issue.
Docs: https://apostello.readthedocs.io/en/latest/api.html


ValloxMV going stable

added vallox mv release
got some positive feedback already:
https://forum.iobroker.net/topic/21897/aufruf-valloxmv-adapter

1.0.0 is installed by noone according to stats ... any very new ... what was the change compared to 0.1.3 which is most installed so far?

Just a small fix, changes are documented here https://github.com/hacki11/ioBroker.valloxmv/blob/master/README.md
i do not want to go stable with a 0.x version, it is just a version bump and a small bugfix.


add schema entities and mappings to process set node operational status protobuf message

required for https://github.com/Joystream/joystream/issues/4765

@zeeshanakram3 build fails


Start fixing 216 tests

I started fixing some of the INSERT FROM SELECT + JOIN test cases for mssql with prefixing table columns, but I hit a snag on one final test. @danrzeppa would you be able to check this one out?

awesome! thanks @danrzeppa


Hidden fields in Model

Is there a way to leave some hidden fields at the time of consultation?
For example, I would like to hide the password field, but I would not want to do this every time in every query.
In the Lucid documentation, there is the hidden () method, which returns the fields to be hidden, is there anything similar that I can use with mongoose?

Maybe this is what you want: https://www.npmjs.com/package/mongoose-hidden
You'd install this plugin using something like this
'use strict'

const BaseModel = use('Model')
let mongooseHidden = require('mongoose-hidden')()

/**
 * @class Foo
 */
class Foo extends BaseModel {
  static boot ({ schema }) {
    schema.plugin(mongooseHidden);
  }
  /**
   * Foo's schema
   */
  static get schema () {
    return {
      name: String,
      password: { type: String, hide: true },
      email: String
    }
  }
}

module.exports = Foo.buildModel('Foo')


V1.4 fix minor bugs

Summary of changes made

added line break for deletefriend's error message
fix email's regex such that domain must have a . . 1eg alex@gmail` is not allowed

fixes #189
fixes #200

Codecov Report

Merging #225 (f47ac1a) into master (6d3946f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #225   +/-   ##
=========================================
  Coverage     69.20%   69.20%
  Complexity      817      817
=========================================
  Files           121      121
  Lines          2939     2939
  Branches        431      431
=========================================
  Hits           2034     2034
  Misses          723      723
  Partials        182      182

Impacted Files
Coverage Δ

...va/seedu/address/logic/commands/DeleteCommand.java
80.00% <ø> (ø)

...rc/main/java/seedu/address/model/person/Email.java
94.44% <ø> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

LGTM


unable to publish

Environment
Ubuntu 14.04 LTS
- VerneMQ Version:
Latest from master.
- OS:

Erlang/OTP version (if building from source):
[{release,"Erlang/OTP","19","8.3",
[{kernel,"5.2","/usr/lib/erlang/lib/kernel-5.2"},
{stdlib,"3.3","/usr/lib/erlang/lib/stdlib-3.3"},
{sasl,"3.0.3","/usr/lib/erlang/lib/sasl-3.0.3"}],
permanent}].

Configuration is Default out of the box with minor changes:
listener.tcp.default = <IP_ADDRESS>:1883
(otherwise no connections was made at all)
Expected behavior
Client should be able to publish since not ACL and
all auth is set to off
using malaria to test the broker:
malaria subscribe -n 1000 -N 20 --host vernemqhost -q 0
Actual behaviour
Getting This:
2017-06-29 16:04:20.371 [warning] <0.401.0>@vmq_ranch:teardown:127 session stopped abnormally due to 'publish_not_authorized_3_1_1'
2017-06-29 16:04:21.212 [error] <0.477.0>@vmq_mqtt_fsm:auth_on_publish:658 can't auth publish [undefined,{[],<<"beem.loadr-MacBook-Pro.local-36272-17">>},0,[<<"mqtt-malaria">>,<<"beem.

From a fresh VerneMQ installation all you need to do is to set allow_anonymous = on in the vernemq.conf file.

In VerneMQ the allow_anonymous = on only affects the authentication part NOT the authorization part. Default authorization is done using the vmq_acl plugin which is enabled out of the box and configured with an allow-everything ACL.
For this reason all you have to do when starting with a freshly installed VerneMQ (and you want to allow any connecting client publishing and subscribing to any topic) is to set allow_anonymous = on in vernemq.conf(as correctly commented by @larshesel).
Hope this helps.

The first thing I did was allow_anonymous = on  :)
It has no effect....
here is a copy paste from my vernemq.conf:
## Allow anonymous users to connect, default is 'off'
##
## Default: off
##
## Acceptable values:
##   - on or off
allow_anonymous = on

Ok I got it, the reason it failed was that
i too quickly set  plugins.vmq_acl = off
Now I switched it back to plugins.vmq_acl = on  and it works :)

Perfect!


Bumping package version to 1.23.0

Tested locally.
Description of changes
Upgrade to 1.23.0 incorporating these changes.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

CC maintainer @0x4A6F and @kalbasit

Thanks for trying to contribute to nixpkgs.
First off, some info about package bumps to nixpkgs:

there is a bot to bump them automatically: r-ryantm
buildGoModules and other build helpers also need to update their respective checksums (see my PR for comparison)
for package bumps the commit message and thus pr title should be formatted like described in CONTRIBUTING.md

@0x4A6F thanks for the kind intro. I see you opened a PR with the package bump now, so I'll close this one. Thanks again, I misunderstood the checksum since my local build passed, I also see that I could have saved both me and you some time by looking it up on the discourse.

No problem.
The local build uses the old version sources (if already fetched and checksums match).
ldflags are overwriting the version and this might be confusing.
You can also use lib.fakeSha256 in sha256 and  vendorSha256 invocations or nix-prefetch tooling to get to new checksums. Or use tooling for updating like nix-update.


Upgraded memory & added flexibility for dependency version

Upgraded memory limit & added flexibility for dependency version especially for larger projects.

Also forgot to mention the commit desc, I also added the report summary arg

@jojobudiman  Thank you so much for this incredible work! These are great changes.
Feel free to check over https://github.com/fossbarrow incase you look for more repositories to contribute to! 😄

No worries @PatricNox , will do despite with limited knowledge, I'll do my best! 😊


Any support for testIDs or accessibility labels for the initial menu open?

It doesn't seem to work with mobile.dev's Maestro, because we can't pass testIDs or accessibilityLabels into the views.

I’d accept a PR for this

Btw, for Maestro on native, I'm not exactly sure how this would work with the menu items.


Revert "collate code"

Reverts CS2103AUG2017-F10-B2/main#56
These collations should be on individual repo not on team repo

Coverage remained the same at 85.63% when pulling 0bd388901d8dbcb8e97e8da7e8df8c4cae4ff313 on revert-56-collate_1.4 into 530847ab603d7946dc18293e68104af626376c50 on master.


nixos/nextcloud: add extraConfig

Motivation for this change
Fixes #103320 cc @nivadis
I had this laying around, but never got around to upstreaming it.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

I am using Nextcloud for a while now and newer saw this use case.

user_external
requires config modifications. I would love to do them declaratively.

I am using Nextcloud for a while now and newer saw this use case.
user_external requires config modifications. I would love to do them declaratively.

Do you require them to be dynamic? Otherwise you could generate them with the help of nix.

Do you require them to be dynamic? Otherwise you could generate them with the help of nix.

If the users could be generated from Nix-created user accounts with
isNormalUser = true, I would love to adopt such a
solution. Additionally ensuring that if I add an account later, it will
get access to Nextcloud.
Passwords may be set later or just reset - I have a mail server on my
machine, so I'm able to send and accept mail, including securely
resetting passwords. So I guess to enter for the first time the user has
to log in to shell and look in their Maildir for the password reset
link?

Sincerely,
Vika

I'm not gonna implement any of the suggestions here, so if anyone wants this, just open a new PR.

I'm not gonna implement any of the suggestions here, so if anyone wants this, just open a new PR.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/how-to-configure-nextcloud-to-use-s3-object-storage/15180/2


Keyboard Manager: Remap shortcuts into keys

I would love to be able to use the Keyboard Manager to map a custom shortcut to a specific key.
I'm using an ANSI keyboard but when I'm typing in Italian I would like to use accented letters with shortcuts.
eg: ctrl+alt+e = é

This is currently being tracked at #3290. Closing this issue as a duplicate.


feature/mx-1455-document-ldap-extractor

This adds general documentation for the ldap extractor.
While reviewing the tests I noticed that they cover none of the convenience functions (ldap.extract). Should I create a ticket for that?

I think there should be tests for ldap.extract convenience functions. yes, please create a ticket.

I think there should be tests for ldap.extract convenience functions. yes, please create a ticket.

See https://jira.rki.local/browse/MX-1477

That is indeed a point. I noticed that, too while writing the docs but did not know how to address this.  Regarding the helper functions: In the organigram extractor these also reside in extract.py, hence I'd like to leave that in sync, too. One idea might be to add a new utils.py module and move any helper functionality in there. What do you think?

yes, sound good to me

I created a ticket: https://jira.rki.local/browse/MX-1479


Make dest NATIVE_URI compatible with source CAMERA

When using the camera in iOS, UIImagePickerControllerReferenceURL does not exist because the image only exists in memory immediately after taking a photo. This waits for the image to be written to disk before firing the JS callback when Camera.SourceType.CAMERA, Camera.DestinationType.NATIVE_URI, and saveToPhotoAlbum=true are used together in iOS.

My apologies, the code has been refactored to be testable, so it doesn't merge cleanly anymore. It should be an easy rebase from your patch (I hope).

Any news on this? This has been bugging me for a while

bump
Any update on this? Running into issues because of it. Thanks

My apologies, I'm not doing active development with Cordova at the moment and don't have time to setup a dev environment to work on this. Can someone please take over this PR and make the final changes to bring it across the finish line?

The issue is fixed now in https://github.com/apache/cordova-plugin-camera/pull/122 This PR seems not actual anymore.


POST requests via reverse proxy fail

1. What version of Caddy are you running (caddy -version)?
Caddy (untracked dev build)
2. What are you trying to do?
Upload files to a reverse proxy
3. What is your entire Caddyfile?
site.com {
  proxy / <IP_ADDRESS>:1333 {
    max_fails 0
  }
}

4.  What did you expect to see?
Proxied requests and responses
6. What did you see instead (give full error messages and/or log)?
Requests were either not sent to the proxy server and responses were only partially sent (just the headers). Usually requests either end up hanging on the client side and never reach the proxy or the responses return the headers with a protocol exception (net::ERR_SPDY_PROTOCOL_ERROR)
This occurs when the proxy returns a status code outside the range of 200-399 despite having max_fails 0 set to prevent the backend from being marked as down. Even if this were the case, then this would not be expected behavior
No error messages are reported by Caddy when adding -log stdout to the command or anywhere else.

Code to reproduce (use the network inspector to view details)

Hi, thanks for the report.
Can you please build Caddy with the build.bash script and then re-run the -version flag? We need to know precise build info. Please ensure it is the same one with which you're encountering the problem.
Also, there is not enough details here to reproduce the error. Can you please provide the upstream server's source code so that we can run it and see the same results? As simple as possible would be good.

Sure, the output for $caddy -version is Caddy 0.8.2 (+3c578df Fri Apr 22 21:58:13 UTC 2016)

Thanks for the build information!
Okay, so the JS has an error on line 20: Uncaught ReferenceError: res is not defined -- when I changed it to req the error went away.
Your upstream server is sending a 413 to all POST requests which is why you're getting the 413 error.

Sorry, my mistake! I guess I didn't catch it because requests never finished. The issue isn't about it returning 413s, but rather not returning anything at all, or sending anything to the upstream server for that matter. I have no idea what's causing it.

Hmm, it seems that this can only be reproduced on an HTTPS connection as I have tried HTTP and it works fine.

This seems to have to do with the fact that it's a multipart-form request, for some reason. POSTing an empty request works fine.

This seems to have to do with the fact that it's a multipart-form request, for some reason. POSTing an empty request works fine. @nemothekid have you experienced this before? I can't quite figure out what's going on.

I was able to reproduce this pretty reliably without going https.
(Stream of thought here...)
Adding this to the backend server "fixes" the issue.
diff --git a/c.go b/b.go
index 417aea3..bd1d613 100644
--- a/c.go
+++ b/b.go
@@ -10,6 +10,7 @@ import (
 func handler(w http.ResponseWriter, r *http.Request) {
        if r.Method == "POST" {
                log.Println("Received post request")
+               io.Copy(ioutil.Discard, r.Body)
                http.Error(w, http.StatusText(http.StatusRequestEntityTooLarge), http.StatusRequestEntityTooLarge)
                return
        }

Reading the entire body, before closing the request causes everything to go smoothly. This isn't a "fix" because the upstream server should be able to close the connection anytime it likes, regardless of the fact that Caddy hasn't finished sending the request to it. It looks like Caddy doesn't like that fact that the connection is being closed before all the data is sent and is hanging.
My guess is (didn't debug to find out) https://github.com/mholt/caddy/blob/master/middleware/proxy/reverseproxy.go#L205 returns a ErrConnectionClosed or something like that, and we see that error and decide to mark the backend as down.
Tangentially, I was checking out the reverseproxy.go in golang (where Caddy's reverseproxy.go is copied from) and saw they are using a CloseNotifier. I was wondering why that is, but it seems like this issue is the case.
Looking into requestCanceler, the docs say transport.CancelRequest is deprecated as it can't be used on http/2 connection so I'm not sure how useful copying the code, as is, is. Secondly I'm not sure is CancelRequest will give us an error on RoundTrip @ https://github.com/mholt/caddy/blob/master/middleware/proxy/reverseproxy.go#L205 leading us back to square one.
tl;dr reverseproxy.go has to detect that the backend server has decided to close the connection and decide how to communicate that back to the client.

My hypothesis on copying the "requestcanceler" code didn't work.

Changing the round tripped to a http client straight up worked fine for me. Not sure if there are any disadvantages though.

Looks as if https://github.com/golang/go/issues/14061 might be related.

@nemothekid Very helpful -- thanks for looking into this! I also was wondering if the upstream was misbehaving but as you said, that shouldn't matter. Hmm, this is tricky!
Ah, and it's interesting that Firefox has a slightly different behavior. Still sporadic, but definitely different from Chrome, as at least one connection seems to succeed regularly:

Indeed some connections still hang.
Update: While writing this post, I am no longer able to reproduce the behavior locally. I'm serving over a test domain over HTTPS with a real certificate, hosted on my local computer. I'm accessing the endpoint exposed by Caddy, added some extra log.Print lines to see more of what is going on, and even tried messing with the payload: first removing the body entirely, then adding the multipart stuff, then re-enabling the content (the 5 MB of zeroes).
All I did was step away for a few hours, came back (both the servers were running the whole time, but I closed the computer), and it was working. I then restarted the servers and things are still working. Firefox and Chrome both show the % values going up until the upload is complete, after which they show a 413 error as expected.

The only changes I made were adding a few log lines. Strange, some?

Oh wait.
@nemothekid It's because, in adding logging to the upstream instance, I'm consuming the response body with ioutil.ReadAll, which is the same as the workaround you suggested. * facepalm *
I will disable that logging for future debugging.

I was running my tests without setting max_fails  0 like in @6f7262's instructions. When I did use that, I have discovered by outputting the outreq that the value of the X-Forwarded-For header very quickly becomes:
"X-Forwarded-For":[]string{"66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>..", 66.<my IP>.."

times like a bajillion.
It essentially tries requests infinitely for a minute, as Caddy is programmed to do when it's told to never assume a backend goes down.
That's gotta increase memory usage. Whoops.

(I don't know why it fails under Firefox, http/1.1)
AFAICT, It looks like a data race. I'm checking out a simpler case where var reqs = 1; in the JS code as that doesn't properly work either and is less complex than trying to debug 3 requests at once.
When var reqs = 1, the status code (413) is retrieved, but the body (which should be "Request Entity Too Large") never seems to be sent to the browser.

Speaking of things happening a bajillion times, I noted that when logging the error return from RoundTrip, it would be stream error: stream ID 5; CANCEL over and over, not sure if this is related.

@nemothekid That is exactly what I was experiencing too. I found that it would do that for the first request (just the headers and no body) and from that point onward all requests would be void and just hang.
This can also be seen on the sample in which the very first upload gets more done than any of the subsequent uploads.

^ Now we're getting somewhere. That is exactly consistent with my tests too.

@nemothekid With regards to a possible data race:
==================
WARNING: DATA RACE
Write by goroutine 71:
  sync/atomic.AddInt32()
      /usr/local/go/src/runtime/race_amd64.s:255 +0xb
  github.com/mholt/caddy/middleware/proxy.Proxy.ServeHTTP.func1()
      /Users/matt/Dev/src/github.com/mholt/caddy/middleware/proxy/proxy.go:139 +0x50

Previous read by goroutine 108:
  github.com/mholt/caddy/middleware/proxy.(*staticUpstream).NewHost.func1.1()
      /Users/matt/Dev/src/github.com/mholt/caddy/middleware/proxy/upstream.go:111 +0x6b
  github.com/mholt/caddy/middleware/proxy.(*UpstreamHost).Down()
      /Users/matt/Dev/src/github.com/mholt/caddy/middleware/proxy/proxy.go:59 +0xb2
  github.com/mholt/caddy/middleware/proxy.(*UpstreamHost).Available()
      /Users/matt/Dev/src/github.com/mholt/caddy/middleware/proxy/proxy.go:69 +0x32
  github.com/mholt/caddy/middleware/proxy.(*staticUpstream).Select()
      /Users/matt/Dev/src/github.com/mholt/caddy/middleware/proxy/upstream.go:244 +0xa8
  github.com/mholt/caddy/middleware/proxy.Proxy.ServeHTTP()
      /Users/matt/Dev/src/github.com/mholt/caddy/middleware/proxy/proxy.go:88 +0x460
  github.com/mholt/caddy/middleware/proxy.(*Proxy).ServeHTTP()
      <autogenerated>:5 +0xf2
  github.com/mholt/caddy/server.(*Server).ServeHTTP()
      /Users/matt/Dev/src/github.com/mholt/caddy/server/server.go:359 +0x596
  net/http.serverHandler.ServeHTTP()
      /usr/local/go/src/net/http/server.go:2081 +0x206
  net/http.initNPNRequest.ServeHTTP()
      /usr/local/go/src/net/http/server.go:2489 +0x350
  net/http.(*initNPNRequest).ServeHTTP()
      <autogenerated>:253 +0xda
  net/http.(Handler).ServeHTTP-fm()
      /usr/local/go/src/net/http/h2_bundle.go:3847 +0x5d
  net/http.(*http2serverConn).runHandler()
      /usr/local/go/src/net/http/h2_bundle.go:4060 +0xac

Goroutine 71 (running) created at:
  github.com/mholt/caddy/middleware/proxy.Proxy.ServeHTTP()
      /Users/matt/Dev/src/github.com/mholt/caddy/middleware/proxy/proxy.go:140 +0xdf6
  github.com/mholt/caddy/middleware/proxy.(*Proxy).ServeHTTP()
      <autogenerated>:5 +0xf2
  github.com/mholt/caddy/server.(*Server).ServeHTTP()
      /Users/matt/Dev/src/github.com/mholt/caddy/server/server.go:359 +0x596
  net/http.serverHandler.ServeHTTP()
      /usr/local/go/src/net/http/server.go:2081 +0x206
  net/http.initNPNRequest.ServeHTTP()
      /usr/local/go/src/net/http/server.go:2489 +0x350
  net/http.(*initNPNRequest).ServeHTTP()
      <autogenerated>:253 +0xda
  net/http.(Handler).ServeHTTP-fm()
      /usr/local/go/src/net/http/h2_bundle.go:3847 +0x5d
  net/http.(*http2serverConn).runHandler()
      /usr/local/go/src/net/http/h2_bundle.go:4060 +0xac

Goroutine 108 (running) created at:
  net/http.(*http2serverConn).processHeaderBlockFragment()
      /usr/local/go/src/net/http/h2_bundle.go:3853 +0x7c2
  net/http.(*http2serverConn).processHeaders()
      /usr/local/go/src/net/http/h2_bundle.go:3788 +0xb75
  net/http.(*http2serverConn).processFrame()
      /usr/local/go/src/net/http/h2_bundle.go:3515 +0x5fc
  net/http.(*http2serverConn).processFrameFromReader()
      /usr/local/go/src/net/http/h2_bundle.go:3474 +0xb85
  net/http.(*http2serverConn).serve()
      /usr/local/go/src/net/http/h2_bundle.go:3169 +0xd46
  net/http.(*http2Server).ServeConn()
      /usr/local/go/src/net/http/h2_bundle.go:2711 +0x101f
  net/http.http2ConfigureServer.func1()
      /usr/local/go/src/net/http/h2_bundle.go:2603 +0x115
  net/http.(*conn).serve()
      /usr/local/go/src/net/http/server.go:1414 +0xa32
==================

Note that my line numbers might be slightly different since I've added a few log lines. proxy.go:139 says atomic.AddInt32(&host.Fails, -1) - upstream.go:111 reads if uh.Fails >= u.MaxFails &&
But I imagine this is unrelated to the issue at hand. (Still, maybe the read in upstream.go should be an atomic operation instead.)

Looks like a bug in golang's http2 library.
My guess is if in a http2 server, a request's Body is closed before it is fully read, for some reason the responsewriter's body is discarded.

I still see similar behavior with http2 disabled (run caddy with -http2=false), though.

That's odd - what would be the difference between a http 1.1 TLS request and a unencrypted one?
With var req = 1; and http/2 disabled, I see the 413 error and the response body. I believe this bug explains why we don't see data.
Chain

The upstream server sends a response without reading the request body.
transport.go:1285 Closes the body (not sure what the error returned here is)
The request tries to write to the body in h2_bundle.go:3880 (and fails)
As a result of this failure, the stream is closed in h2_bundle.go:3667. Because this http2 stream is closed, any attempt to write back to response fails.

I'm trying to tie this back to why var req = 3 fails and why it fails in http/1.1. My only guess now is that net/http was written with the assumption that the request would always be fully read?

When using http2 and var reqs = 3 (in the JS) and refreshing the page once, Caddy tries the request infinitely many times over and over again, but no infinite looping happens using http/1.1.
This is getting weird...

Also, I know that Nimi acknowledged this, but for those following along at home, I want to re-emphasize that this whole scenario works just fine over HTTP; this problem only seems manifest when using HTTPS.
Over plain HTTP I consistently see

Sending 3 requests...
Done. Got 413
Done. Got 413
Done. Got 413

as one would expect. So, for some reason, maybe HTTPS is the culprit somehow?

So it could potentially be an issue with the TLS? Interesting.

I just amended my last comment, apparently Firefox still exhibits the behavior. Chrome doesn't though!

Likewise, all requests to any previous versions of the server work just fine, including one I wrote in node quickly. This might be a browser issue, or more specifically an issue with the way http2 handles multiple connections.

I believe one half of this issue is caused by a bug in golang/go#15425. Note in my bug report, I can reproduce the issue without even using caddy just the original script @6f7262 provided.
However, this really only explains why it doesn't work on http/2, the other failures are interesting..

I agree, all of the b

Whoops. Misclick.
I agree, all of the behaviors in this are bizarre. I also noticed that it's not even about proxying anymore, but rather just about Go's responses.

According to https://github.com/golang/go/issues/15425#issuecomment-214173796 this looks like an issue with the JavaScript provided, not Go or Caddy.
@6f7262 confirm?

Completely false @nemothekid

@nemothekid I do agree this is less and less becoming a bug with Caddy.

I think that endlessly pinging the backend server upon fail is a bad idea however. Rather than using a time window, maybe a certain amount of tries would be better?

@6f7262 This only happens if you set max_fails 0, because you're telling Caddy, "Even if there is a failure communicating with upstream, it is never down." But Nimi had a good idea in another issue, he suggested:

The default behavior is to try backends for 60 seconds (essentially infinite loop for 60 seconds). If max_tries is set to 0, it might make most sense to not bother with retrying connections and just return GatewayUnavailable once the backend fails.

So we could do that, although I don't consider the current behavior a "bug".

I didn't say it was a bug, I'm just saying that it could potentially make situations far worse if it's getting hammered for 60 seconds straight per request if it doesn't respond. I think Nimi's suggestion would work fairly well. Should it be configurable though? As in, retry a max of 4 times in 60 seconds or something.

As in, retry a max of 4 times in 60 seconds or something.

That's the equivalent of setting max_fails to 4. When max_fails is 0, it means to mark the backend as never down, and as long as there exists non-down backends, Caddy will keep trying for 60s.
In fact the "fix" I suggested is "equivalent" (it's racy) to
max_fails 1
fail_duration 1ms

I see. The reason I was using max_fails 0 is because even if the backend did return an error, then I didn't want it to be marked as down for 60 seconds. The 1ms idea seems a little tight still, maybe include a none option? Just to note, I encountered these errors because of this http2 bug which is kinda how I got here.

Looks like this is an issue in Chrome. An nginx developer posted a similar bug report to Chromium (https://bugs.chromium.org/p/chromium/issues/detail?id=603182), thats similar to this issue.
nginx decided to write a patch in their http2 code, however I think the equivalent would be forking net/http2 in go to make this work.

Oops, I didn't realize my PR that doesn't fix this issue closed the issue anyway :smile: I guess GitHub got a little excited there...
@nemothekid Thank you for your extensive work on this. I'll need to decide if a fork of net/http is something we want to maintain... thing is, I bet Chrome can roll out a fix through their automatic updates more quickly than we can get people to update their web servers.

Did we miss anything here in this issue, @nemothekid? Your issue on the Go repo was closed and looks like a fix made it into 1.7.


ArrayDeque inaccessable (2.0.0)

I'm not sure why and I might be wrong, but the following fails to compile:
public class ThingA {
  void somefunc() {
    new ArrayDeque<String>();
  }
}

produces the error property 'ArrayDeque' does not exist on type 'typeof util' from
/* Generated from Java with JSweet 2.4.0-SNAPSHOT - http://www.jsweet.org */
namespace jsweettest.moda {
    export class ThingA {
        somefunc() {
            new java.util.ArrayDeque<string>();
        }
    }
    ThingA["__class"] = "jsweettest.moda.ThingA";

}

I see ArrayDeque in the source jar bundle, so I don't think I'm using the wrong version.
I'm not sure of a workaround.

Please ensure your J4TS dependency is scope compile. The j4ts.d.ts should be included in TypeScript compilation command by JSweet

Note : please try with updated JSweet 3.1.0 / j4ts 2.1.0 (snapshots for now)


Fix Elm extensions

@HaoK
I noticed that Entropy has a sample using these extensions. Will send out a PR later for it.

Hi @kichalla, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Kiran Challa). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla2.msopentech.com.

TTYL, MSOTBOT;

:shipit:


linter: eslint/no-undef fails on ts type NodeListOf

What version of Oxlint are you using?
0.10.3
What command did you run?
oxlint -c .oxlint.json
What does your .oxlint.json config file look like?
{
  "env": {
    "browser": true
  },
  "categories": {
    "correctness": "off"
  },
  "rules": {
    "no-undef": "error"
  }
}

What happened?
It does not know about this specific types:
  × eslint(no-undef): 'NodeListOf' is not defined.
    ╭─[src/index.ts:11:12]
 10 │
 11 │ const xyz: NodeListOf<HTMLElement> = document.querySelectorAll('.xxxx');
    ·            ──────────
 12 │
    ╰────

Others lines like: const abc: Element | null = document.querySelector('.xxx'); are working

no-undef is still under nurser, PRs welcome!
The fix should be checking for symbol flags.

Actually, this will also report an error, and I think this is expected behavior? See typescript-eslint
  ⚠ eslint(no-undef): 'Element' is not defined.
   ╭─[no_undef.tsx:1:12]
 1 │ const abc: Element | null = document.querySelector('.xxx');
   ·            ───────
   ╰────

  ⚠ eslint(no-undef): 'document' is not defined.
   ╭─[no_undef.tsx:1:29]
 1 │ const abc: Element | null = document.querySelector('.xxx');
   ·                             ────────
   ╰────

I think the issue here is that NodeListOf is a typescript-only type, it's not a runtime global. Oxlint also warns on standard Typescript helper types like Partial:
  ⚠ eslint(no-undef): 'Partial' is not defined.
   ╭─[test.ts:5:10]
 4 │
 5 │ const a: Partial<Name> = {}
   ·          ───────
   ╰────

So I think the options are:

Add support for TypeScript globals, not just JS ones
Skip TS types completely for this lint rule


Fix parse issue when genericClass of array is NSURL

fixed #190
问题根本原因在于，数组解析时，json 数据格式与目标模型格式不匹配

Codecov Report

Merging #281 into master will decrease coverage by 5.44%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
- Coverage   99.28%   93.84%   -5.45%
==========================================
  Files           2        2
  Lines        1540     1559      +19
  Branches        0      429     +429
==========================================
- Hits         1529     1463      -66
+ Misses         11        9       -2
- Partials        0       87      +87

Impacted Files
Coverage Δ

YYModel/NSObject+YYModel.m
93.22% <89.47%> (-6%)
:arrow_down:

YYModel/YYClassInfo.m
96.92% <0%> (-2.7%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1230e60...ec8b817. Read the comment docs.


Change in service principle display name

The display name of principle with id 00000009-0000-0000-c000-000000000000 is no longer 'Microsoft.Azure.AnalysisServices', it's Power BI Service

Thanks for your comment, @thereverand. I’ll add this request to our docs backlog.

Hi @thereverand,
Can you please let me know where in the documentation this string appears?
Thanks,
Kesem

powerbi-docs/powerbi-docs/admin/service-encryption-byok.md
Under Configure Azure Key Vault > Add Service Principal

Hi @thereverand,
When I search Key Vaults > Create key vault for the string 00000009-0000-0000-c000-000000000000 (as per the instructions in Add the service principal), I get Microsoft.Azure.AnalysisServices which is the expected result according to the article.

Can you please post a screenshot with the information you're getting?
Thanks,
Kesem


MIENS compliance on sample IDs

See the discussion on the forum here. The sample IDs allowed by QIIME2 are not currently assured to be MIENS complaint. This was discovered in biocore/deblur#157, subsequently qiime2/q2-deblur#48 where the check (and subsequent exception) was thrown. This is a MIENS compliance issue as noted in QIIME1 (e.g., check_id_map.py).

We intentionally aren't forcing MIENS-compliant sample IDs (this is part of relaxing the QIIME metadata format requirements). See my followup on that forum post for details and examples.
Additionally, there's a good amount of QIIME 2 .qza files containing IDs that violate MIENS standards, so it would be tough on our users if we backtrack at this point (their data would be unusable with QIIME 2, something we've worked hard to avoid).

Is there a resource to learn more about MIENS? I'm pretty unfamiliar with it.

@ebolyen http://precedings.nature.com/documents/5252/version/2
@jairideout, that is not a good reason to disregard an established community standard that QIIME used to abide by. The potential for silent bugs is high which makes the cost of user pain (of alpha software) worth it.

@wasade, thanks for the reference link, I was also having a hard time finding something.
Sorry for any confusion here, but it looks like we might not all be on the same page --- what @jairideout is proposing isn't to disregard this established community standard, I think he is advocating for a per-plugin/per-action approach. The reasoning is that while any one standard might work well for some tools (e.g. deblur), there is a (sometimes pretty likely) chance that those standards aren't applicable for another tool (e.g. PHYLIP). This per-plugin / per-action approach was actually why I had opened https://github.com/qiime2/q2-deblur/issues/48 - because we have already generally been approaching these problems on a per-plugin / per-action basis. Personally I don't think that the per-plugin / per-action approach is incompatible with supporting established community standards, I just think it might need to happen at a different tier (instead of framework-wide). I might still be misunderstanding your view (apologies if I am!), and if that is the case, maybe we can chat about it on an upcoming weekly dev call. Thanks!

which makes the cost of user pain (of alpha software) worth it.

@wasade, QIIME 2 is no longer in alpha status, so we can't really backtrack on this. We've taken great pains to support existing user data in a backwards-compatible way -- if we hadn't, we would have been able to focus much more of our efforts on project implementation, but we've been prioritizing user-experience (which is paying off in practice).

The potential for silent bugs is high

Please read my forum post. I provided a logical argument for why adopting MIENS-compliant sample IDs does not solve the problem you brought up.

that is not a good reason to disregard an established community standard that QIIME used to abide by.

There are many things that have changed between QIIME 1 and 2. In QIIME 2 we strive to be backwards-compatible with QIIME 1, and that includes being backwards-compatible with MIENS-compliant sample IDs. If a plugin/method/tool only works with MIENS-compliant IDs, the plugin developer can remap IDs as necessary. I think your statement about disregarding established community standards is unfair.

I read the post before I responded. We've always deferred identifier remapping to as close to the tool as necessary (e.g., the app controllers); the plugins are a new take on an old problem. The sample information is not a plugin though. QIIME either is or is not MIENS complaint and I really don't feel that there is a grey area there. If it is not MIENS compliant, then it disregards a widely accepted community standard and we're just scratching the surface of interoperability issues that this introduces.

Note that MIENS was superseded by MIMARKS, reference pub here:
https://www.ncbi.nlm.nih.gov/m/pubmed/21552244/
And curr info on GSC site. A lot of funding agencies care that QIIME is GSC standards compliant so I urge you to reconsider this in the strongest possible terms.
On Sep 13, 2017, at 8:37 PM, Daniel McDonald <notifications<EMAIL_ADDRESS>wrote:
I read the post before I responded. We've always deferred identifier remapping to as close to the tool as necessary (e.g., the app controllers); the plugins are a new take on an old problem. The sample information is not a plugin though. QIIME either is or is not MIENS complaint and I really don't feel that there is a grey area there. If it is not MIENS compliant, then it disregards a widely accepted community standard and we're just scratching the surface of interoperability issues that this introduces.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/qiime2/qiime2/issues/334#issuecomment-329335341, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AB69KVl-JYBMHcXCQejC6pxpbbiSGCS9ks5siHTmgaJpZM4PWwiB.

Thanks for the links everyone!
Supplement 3 of the MIMARKS paper uses underscores for the sample identifiers (unless I am completely mistaken). One of the example sheets also uses a dash character (pmoA) , and another fails to name the sample at all (dsrA).
Futhermore, QIIME 2 can have sample IDs that are both compliant and a superset. Reiterating @jairideout's point, there is nothing in QIIME 2 that prevents you from using MIMARKS (you should use it!).

Just to have it the thread, are there any restrictions for the Qiime2 sample names? My concern is special characters or spaces, when thinking in writing per sample FASTQs for deposition (SRA/EBI). In general, when you submit (which is always per sample, per experiment, per sequencing run) you name your files as your sample name and having those special chars could become problematic.

are there any restrictions for the Qiime2 sample names?

There's certain special characters that are restricted in sample IDs and column names, see this section of the metadata tutorial for details.

Thanks, perhaps worth expanding what etc means, cause based on that description I'm not sure if "my_sample_name\t" or "my_sample%$@~&|" are valid. In fact, perhaps it will be easier to say what's expected like [a-A][z-Z][?????] .

Users likely want to do things outside of QIIME2

...misclick, my apologies

As you can imagine finding tools that have sample restrictions is pretty hard but found some:

RDP via phyloseq doc, see 4.8, specifically 4.8.3 - honestly, I think RDP is the source of this "rule".
Galaxy tool ids are underscore aware. They use underscores to separate their tools.
TruSeq Amplicon
split_libraries_fastq.py - QIIME, this still needed for anyone that has non EMP primers/wet-lab work and wants to run QC and demultiplexing. Important for Qiita.
redbiom
deblur - what triggered this discussion
Not a tool but this caught my eye - way more results in Google that I would had expected: all the documentation and tutorial surrounding how to create valid mapping files for QIIME. In other words, this is a really spread "rule".
Have to also add it :| here

Thanks, Antonio. I heard back from Pelin as well, who indicated that sample_name in MIENS/MIMARKS/MIxS does not have character restrictions. #SampleID is not a required attribute (thus no character restrictions). Unfortunately, QIIME was wrong on these points for years

Thanks; that is unfortunate and clearly this time around we should document where information about standards compliance comes from.
So in the light of this new information, the main things we should care about with respect to users are:

Will they be able to deposit their data easily in a standards-compliant way? This is important because otherwise their life is hell at the end of the analysis, and we need to support analysis end-to-end including data archiving. Antonio is testing what EBI will accept in terms of special characters for a deposition now.

Will they be able to export to other tools that have long made assumptions about the identifiers that QIIME is documented to emit?

Of these, 1. is much more important.
Since the identifier issue is not a standards issue, contrary to the QIIME 1 documentation, I agree that it should be handled via remap but both this and checking that the metadata are standards compliant for deposition are high priority as the decision to change the identifier spec will cause all sorts of pain for developers and users.
On Sep 22, 2017, at 7:15 AM, Daniel McDonald <notifications<EMAIL_ADDRESS>wrote:
Thanks, Antonio. I heard back from Pelin as well, who indicated that sample_name in MIENS/MIMARKS/MIxS does not have character restrictions. #SampleID is not a required attribute (thus no character restrictions). Unfortunately, QIIME was wrong on these points for years
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/qiime2/qiime2/issues/334#issuecomment-331459280, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AB69KYNwCfCPnVkBL4gM9Nh-yyEjQIjBks5sk8ECgaJpZM4PWwiB.

For 1. I underestimated how hard testing this can be. The problem is that all our code relies on the sample names being the file names for deposition (sample1, file deposition sample1.fastq.gz). Thus, actually testing this, will mean that I would have to rewrite those sections, so perhaps it's better to wait to have the remap ready (BTW is there an issue for this and do you need help with the solution?). Anyway, as @wasade mentioned, sample_name (and any other metadata field) have basically no restrictions so if we have a remap and the submission code uses that remap value for the sample names, we should be fine for submissions.

I agree that if it will take more time to verify that the remap is needed than to implement the remap, it would be a good idea to focus on the latter…
On Sep 27, 2017, at 5:39 AM, Antonio Gonzalez <notifications<EMAIL_ADDRESS>wrote:
For 1. I underestimated how hard testing this can be. The problem is that all our code relies on the sample names being the file names for deposition (sample1, file deposition sample1.fastq.gz). Thus, actually testing this, will mean that I would have to rewrite those sections, so perhaps it's better to wait to have the remap ready (BTW is there an issue for this and do you need help with the solution?). Anyway, as @wasadehttps://github.com/wasade mentioned, sample_name (and any other metadata field) have basically no restrictions so if we have a remap and the submission code uses that remap value for the sample names, we should be fine for submissions.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/qiime2/qiime2/issues/334#issuecomment-332507307, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AB69KUvuUg8fNMqN9oqiOZSBgR7BabcYks5smkH9gaJpZM4PWwiB.


Allow multiple elasticsearch hosts in config

This allows mutiple elasticsearch hosts to be configured if a cluster is being used. Existing single-node configurations will continue to work with no changes.
The local environment check was removed because it unnecessarily defines Elasticsearch::Client's default configuration. If no hosts are configured, Elasticsearch::Client defaults to localhost:9200.

@johnsja I'm going to close this. I've since learned that Elasticsearch::Client will do this parsing for us. You can just hand it a comma-delimited string of hosts.


Emoji function.

It needs a emoji function so we can use it daily

I object. Please never do it.
From Reddit:

I think that both emojis and even acronyms would count as Newspeak. Both types of communication we use everyday through technology (we even are starting to use some acronyms in our speech). We use emojis to make communication through text simpler and more visual. They often generate different feelings and thoughts to different people. This makes the meaning slightly different for most people. The way emojis would act like Newspeak is you can't use them to argue anything. You might be able to make a statement using one or multiple emojis, but never actually make an argument. This was the entire intention of Newspeak. It was invented so that eventually everyone in Oceania would speak it. It would take the impossibility of doubting, hating or arguing against Big Brother to a whole new level. This new level would be to the point where someone couldn't even think of anything argumentative, only statements, making any sort of thought against Big Brother or the party impossible.

It takes a millisecond to switch to gboard, pick your emoji, and another millisecond to switch back to Hacker's.
That hasn't stopped me from using it daily since its first release!

I disagree. Everybody (or, a big lot of people atleast) uses emojis everydays. I really enjoy them because I think they are really useful, making some communications really shorter and efficient.
So, what about the people part also enjoying Hacker's Keyboard ? Like me ? It's a really good project, I love it and use it everyday since 2 or 3 years ago. But I also use emojis everydays.
To me, it's just a non sense to not implemente a little and very useful tiny button with all emojis. I respect your choice, but we are 2019 ! No offense. It is just a point of view in the middle of a lot of others ones. Sorry for my approximative english. Have a nice day

If adding emoji is staightforward, it would be a great enhancement.

I object. Please never do it.
From Reddit:
[...]

This argument sounds specific to usage on reddit, and less about a powerful keyboard app.  I appreciate the power of the app.  I use it because I prefer Dvorak layout.  Hacker's keyboard has applications far beyond a glorified usenet site.  💥

Like @LinuxRunsTheWorld, I switch keyboards to send emojis, but I find it annoying. I would love if there was an option to add them (or other Unicode characters) to Hacker's Keyboard, instead

Duplicates #376

Sorry, I happened to have seen this one on the front of the issues page. Please close this duplicate


Some Themes are breaking when trying to use them

Several of the themes are throwing an error.
For example, NightOwl and MaterialThemePalenight
{!! str($content)->markdown(extensions: [new PhikiExtension(Theme::NightOwl)]) !!}

https://flareapp.io/share/x5M1KeM5

Fixed in v0.2.9 @awcodes 👍


The token always is invalid

Hello,
Happy to see there is a client lib to communicate with app store server API. Thanks for your contribution.
Today, I have tried with this library, but I always got the 401 error.
The code I tested is
const KEY = `-----BEGIN PRIVATE KEY-----
xxxxxxx
-----END PRIVATE KEY-----`

const KEY_ID = "xxx";
const ISSUER_ID = "xxxx";
const APP_BUNDLE_ID = "xxx";

const ServerApi = new AppStoreServerAPI(
  KEY, KEY_ID, ISSUER_ID, APP_BUNDLE_ID, Environment.Sandbox
);
let results = await ServerApi.getTransactionHistory(1000000944298944);

I have debugged the code, it seems that the jwt lib jose return an invalid token. After replace with jsonwebtoken, the token is valid.
Could you kindly help double-check if this is an existing issue? Thanks! And hope there will be a correction. Thanks!

Hi,
I'm not sure what you mean by an invalid token. Could you point to where in the code this happens and provide an example of what an invalid token looks like?

Hi,
The invalid token that I mentioned is in the response got from App Store Server when invoking an API method(like api.getTransactionHistory()). And the HTTP status is 401
The request is unauthorized; the JSON Web Token (JWT) is invalid.

There is currently a bug in the API. If the purchase belongs to an Apple ID that has been deleted, the API will return the error that you've encountered (HTTP 401) when it should be returning  AccountNotFoundError.
I've reported this to Apple and they're working on a fix.

I am afraid it is not the root cause. I tested in postman. The API is working well with a token that generated with [jsonwebtoken](https://www.npmjs.com/package/jsonwebtoken) manually.

Could you try inspecting the token that the library generates? See getToken
Also, is there a possibility that you somehow have an older version of jose installed? You could try deleting your node_modules and reinstalling.

I have tried with some old versions<EMAIL_ADDRESS>Unfortunately, all failed.

I'll gladly look into any issue but you're going to have to make an effort and help me figure things out. As far is I know you're the only one seeing this. I use this library in production on multiple projects and haven't encountered the problem you've described.
Opening issues all across GitHub is not going to allow people to solve this issue for you.

Upgrade node version. The issue is resolved. Thanks for your support!

Same issue

Ok on my end I had an in-app-purchase token instead of an app store connect api token

@yuanpli - jose generates mangled signatures for ES256 (used for the App Store Server API) on Node 12.15 and prior, because it uses a feature only added in Node 12.16, without checking it's available. You can switch to jsonwebtoken instead, which works correctly on Node 12.15.

Node 15.6.0 was chosen as the minimum required version because it introduces X509Certificate, which this package uses. Node 12 never was (and never will be) supported.

@agisboye - my apologies! My comment (albeit true) is therefore not relevant here.


Dev

panel with multi-languages
panel with creativity
chat history is the revival of chat GPT
clear history
regenerate functionality
python code checking
connection to openai chatgpt

TODO: optimising the flow of openai flow

LGTM


Update otherplugins.py

Before submitting your pull request be sure that:

You haven't touched any file in the spyder/defaults directory.

There is absolutely no need to touch those files.
If you want to add new configuration options, please go to
spyder/config/main.py.

You haven't eliminated unnecessary blank lines or spaces during your work.
That makes our reviewing work harder and it could introduce unnecessary
conflicts with other pull requests.
You haven't added new icons to Spyder. Please leave decisions about what
icons to use to us :)

Note: You can safely remove this text before submitting your work.

Sorry for messing this up - Hope I did the right thing


Custom done action

Can I set custom function on buttonNext click when last slide active?

You can override onDestroy() in your IntroActivity or use a combination of startActivityForResult() and onActivityResult() in your calling activity to perform actions at the moment the intro finishes and the IntroActivity closes.
To block finishing the intro use a NavigationPolicy.

OK, thank you for quick response.


Subscription for periodic ticks

Like Elm's every, based on setInterval.
It doesn't look difficult to add and would be especially nice for tutorials and simple examples.

every :: Int -> (Double -> action) -> Sub action model
every n f _ = \sink -> forever $ do
  threadDelay (secs n)
  sink (f =<< Time <$> now)

threadDelay is equivalent to setInterval

Thanks, I guess I should have asked on irc first.

@lbonn, it's no problem, we have a slack too. Do you think a Miso.Subscription.Time module would be necessary?

It probably depends if you'd prefer to keep a really small (but composable) base library. I suppose your goal is not to do an Elm clone anyway...
As a newcomer, perhaps I would have appreciated seeing it somewhere in the docs/tutorial as an example. Another radical approach: including it in the Sub type's haddock.

@lbonn I'll be sure to add this to the docs when they are written. Closing due to completion.


No DATA section causes panic

Currently the library is set to panic when there is no DATA section found. Come up with a better way to report this problem and no issue a panic.
Moved over from libmailslurper

Seeing this on a network that uses Qualys network security scanner


Documentation

Write some documentation including:

What is bakker and why does it exist.
How to use bakker

CLI
Installation via pypi / github / package managers
Setup for developers

How does bakker work

Hey, I'd like to help out with the documentation. Where should I reach you about it?

That sounds great. Your help is very much appreciated.
Docstrings for the click CLI would be great for a start.
Since yesterday there is a completely working version of bakker on the master branch.
All available commands are listed in issue #12.
If you have further questions just ask here.

Hey, is there any established communication channel for Bakker?


Freeze and syslog flood

Describe the bug
When I clicked the clipboard icon the UI completely froze up without showing any clipboard entries.
I connected with a shell (Ctrl+Alt+3) and saw that /var/log/syslog was being flooded (over 4GB!) with these logs:
gnome-shell[4864]: (../clutter/clutter/clutter-actor.c:12430):clutter_actor_event: runtime check failed: (retval == CLUTTER_EVENT_PROPAGATE)
gnome-shell[4864]: Attempting to call back into JSAPI during the sweeping phase of GC. This is most likely caused by not destroying a Clutter actor or Gtk+ widget with ::destroy signals connected, but can also be caused by using the destroy(), dispose(), or remove() vfuncs. Because it would crash the application, it has been blocked and the JS callback not invoked.
gnome-shell[4864]: The offending signal was notify on Gjs_ui_popupMenu_PopupMenuItem 0x5588f01f29b0.
gnome-shell[4864]: == Stack trace for context 0x5588c887e190 ==
gnome-shell[4864]: message repeated 2 times: [ == Stack trace for context 0x5588c887e190 ==]
gnome-shell[4864]: Attempting to call back into JSAPI during the sweeping phase of GC. This is most likely caused by not destroying a Clutter actor or Gtk+ widget with ::destroy signals connected, but can also be caused by using the destroy(), dispose(), or remove() vfuncs. Because it would crash the application, it has been blocked and the JS callback not invoked.
gnome-shell[4864]: The offending signal was captured-event on Gjs_ui_boxpointer_BoxPointer 0x5588f1d3e7c0.
gnome-shell[4864]: Attempting to run a JS callback during garbage collection. This is most likely caused by destroying a Clutter actor or GTK widget with ::destroy signal connected, or using the destroy(), dispose(), or remove() vfuncs. Because it would crash the application, it has been blocked.
gnome-shell[4864]: The offending callback was captured_event(), a vfunc.

How To Reproduce
It may have to do with saving a lot of clipboard history entries. I had it set to 10000 and a limit of 100MB.
To fix it I restarted and cleared the history. Have now lowered the history to 1000 entries, in case it was that.
Versions
GNOME Shell 42.1
GCH   Version: 16
org.gnome.shell.extensions.clipboard-history cache-only-favorites false
org.gnome.shell.extensions.clipboard-history cache-size 100
org.gnome.shell.extensions.clipboard-history clear-history @as []
org.gnome.shell.extensions.clipboard-history confirm-clear true
org.gnome.shell.extensions.clipboard-history disable-down-arrow true
org.gnome.shell.extensions.clipboard-history display-mode 0
org.gnome.shell.extensions.clipboard-history enable-keybindings true
org.gnome.shell.extensions.clipboard-history history-size 1000
org.gnome.shell.extensions.clipboard-history move-item-first true
org.gnome.shell.extensions.clipboard-history next-entry @as []
org.gnome.shell.extensions.clipboard-history notify-on-copy false
org.gnome.shell.extensions.clipboard-history paste-on-selection true
org.gnome.shell.extensions.clipboard-history prev-entry @as []
org.gnome.shell.extensions.clipboard-history private-mode false
org.gnome.shell.extensions.clipboard-history process-primary-selection false
org.gnome.shell.extensions.clipboard-history strip-text false
org.gnome.shell.extensions.clipboard-history toggle-menu ['<Super><Shift>V']
org.gnome.shell.extensions.clipboard-history toggle-private-mode ['<Super><Shift>P']
org.gnome.shell.extensions.clipboard-history topbar-preview-size 10
org.gnome.shell.extensions.clipboard-history window-width-percentage 33

Yup, that's the issue. That said, I've been able to hit 60K items before running into GC failures, so if I had to guess you had one really huge item. In any case, this is a fundamental JS scalability issue paired with a missing mutex on the gjs side.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/1868#note_1466737

@SUPERCILEX Ok, glad it's just that. Honestly 10000 is way overkill anyway :sweat_smile:


Bug: Issue reading sqlite tables with datetimes

Description
I think what's happening is that there's a sqlite table with string datetimes, and we recognize them as datetimes, but can't cast them for some reason. Error is: Execution error: Cannot convert Text("2016-07-04") to Timestamp(Microsecond, None)
To reproduce:
CREATE EXTERNAL DATABASE my_sqlite
	FROM sqlite
	OPTIONS (
		location = 'https://github.com/jpwhite3/northwind-SQLite3/raw/main/dist/northwind.db',
	);

SELECT * FROM my_sqlite.default.Orders;

It looks like the schema specifies a datetime or a timestamp, but the value is in the form we expect for a date/.
The function that does the type conversion is a bit gnarly, and we can definitely define some kind of fallback behavior, using some kind of complicated logic. The other fallback option is that we can just use this function for dates and timestamps that are strings, and hope that it will do the right thing?

I'm pretty convinced that we should just assume that dates are all RFC-3339 and use that function. I'll write this up later today or tomorrow.


Release 0.4.0

Coverage remained the same at 97.945% when pulling ad2e542144408fee17e28b925963a3f859a7d2c4 on release-0.4.0 into 7bea208c7005fd5126ac64927be78372d6cac02c on master.


Update communism.plugin.zsh

It is more friendly if it actually says the right name :-)

Thank you! Nice tweak


Updated repo to TypeScript 2.3

Removes deprecated TSD package and installs type definitions from @types packages.
Updates from TypeScript 2.0 to 2.3 to support keyof syntax. I've tested it against Angular repo and it uncovered another broken public API in platform-browser (see here). This error is fixed when ts-api-guardian from this PR is used.
Added a test that keyof syntax actually works.

Fixes #23
Most of the changes are from clang-format...

Closing in favor of #25.


Question: How to merge two json objects?

Is there a merge function that can merge two or more json object into one? Using SQL's terms, the "merge" can be either inner, outer, left, or right join.
A possible use case may be: Two json objects represent default settings and user settings, the user's json object may be a subset of the default json object (as there may be "invalid" fields and/or comments). For any field appears in both jsons, accept user's one; only in the user's json, reject; only in default json, accept default one.
A demonstrative image from Wikipedia

No, there isn't and I don't plan on adding this, sorry.


Cannot find module 'react-toolbox'

Doesn't work out of the box with Typescript 2.3.3.
I keep getting Cannot find module 'react-toolbox' error even though webpack compiles and the components work.
My tsconfig:
{
    "compilerOptions": {
        "outDir": "./dist/",
        "sourceMap": true,
        "noImplicitAny": true,
        "module": "es6",
        "target": "es6",
        "jsx": "react"
    },
    "include": [
        "./src/**/*"
    ]
}

My webpack.config.js:
var { resolve } = require('path');
const HtmlWebpackPlugin = require('html-webpack-plugin');
const { CheckerPlugin } = require('awesome-typescript-loader')

module.exports = {
    entry: './src/index.tsx',
    output: {
        filename: 'bundle.js',
        path: resolve(__dirname, 'dist')
    },

    resolve: {
        extensions: ['.ts', '.tsx', '.js', '.jsx']
    },

    devtool: 'source-map',

    module: {
        rules: [
            {
                test: /\.tsx?$/,
                use: ['babel-loader', 'awesome-typescript-loader'],
                exclude: /node_modules/
            },
            {
                enforce: 'pre',
                test: /\.js$/,
                loader: "source-map-loader"
            },
            {
                enforce: 'pre',
                test: /\.tsx?$/,
                use: "source-map-loader"
            },
            {
                test: /\.css$/,
                use: [
                    'style-loader',
                    'css-loader?sourceMap&modules&importLoaders=1&localIdentName=[name]__[local]___[hash:base64:5]',
                    {loader: 'postcss-loader', options: {sourceMap: true, sourceComments: true}}
                ],
            }
        ]
    },
    plugins: [
        new HtmlWebpackPlugin(
            {
                hash: true,
                template: resolve(__dirname, 'src/index.html'),
                minify: {
                    collapseWhitespace: true
                }
            }
        ),
        new CheckerPlugin()
    ]
};

I've just released beta.12 that fixes the issue

It didnt fix it for me, I had to change to moduleResolution: "node" in my tsconfig.json and then move the index.d.ts file from node_modules/react_toolbox/src/ to node_modules/react_toolbox/.

Will check it again, the issue was that ts files were not being copied, now they are but maybe I missed something

That's very weird. Please ensure you removed node_modules and installed again. I've just check it and it doesn't make sense that you had to move index.d.ts since I've made a fresh install and it is there. If anybody else can confirm the issue that would be helpful

Ok it works now, my fault. Thanks for the help :smile:


switches from alpine to scratch in provisioner

Description
Changes proposed in this pull request:

switches from alpine to scratch
...
...

Related issue(s)

/retest


workbench.view.connections command disappeared

Azure Data Studio version: Insiders.
Steps to Reproduce:

Install SSMSKeymap extension and run F8. This used to open the Server Explorer viewlet
Get error workbench.view.connections command is missing

@anthonydresser where did this go? it's a feature people are using. What replaces it or did we just delete the feature?

Looks like view.dataexplorer replaces it. This is confusing from a back compat perspective, but if needed I can produce a new version of the extension that uses this instead? Will this be constant, and are there other things that might have regressed?

Yeah, I think "Data Explorer' should be in-place of the current "Servers" viewlet so that all the current dependencies continue to work.  It's probably a reasonable time now to pull out the old Servers and Azure Explorer viewlets and switch over.

OK, so then it should continue to support the old command syntax of workbench.view.connections?

workbench.view.connections isn't consistant with the rest of our naming schemes. It's always workbench.view.${name of view} I.E it would be workbench.view.dataExplorer

don't we have a backcompat issue here?  is there any reason the viewlet's need to follow that naming scheme?  I don't recall reviewing that decision in a design meeting or doc, IIRC.

This is the naming scheme we adopted from vscode, they use that naming scheme for all the views.

I'm not sure consistency with VS Code's viewlet naming convention is more important than maintaining backcompat.  Is there any practical reason that we should follow this convention besides it's what VS Code is doing?  It seems like we should minimize breaking changes for seemingly arbitrary reasons, unless I'm missing something.

Consistency? This view is no longer just connections, so it would be misleading naming

Can you determine the impact of the breaking change?  And make a plan how we can notify and help upgrade anyone impacted?  Also, do we need to have a mitigation in place such that extension aren't broken in April?  For example, should we support both and then remove connections once extensions have time to be updated?
In general, we need to stage breaking changes over multiple releases to give partners time to make and publish required changes.

If SSMSKeymap is the only thing dependent on it, I can just update this and push the update to the insiders channel? I only found this because I'll add a new keymapping for F8 to handle the powershell extension's value being in conflict with view ~object~ data explorer keybinding in SSMS.

Yeah, I'm not too concerned with this particular change.  It's more that we need to be deliberate with our breaking change process.  (i.e., assume we had a robust partner ecosystem that depends on the features we're building).  It's better to start following a well-defined process as soon as possible so that it's in-place before we need it.
In terms of feature design, I'm not sure "Data Explorer" is the name we want to go forward with in user facing strings\commands in any case.  We should discuss in the scenario review which will hopefully be scheduled for tomorrow or early next week.

Cool. Agree with you on this being another example where we make breaking changes without thinking about the impact. Let's chat in the scenario review and decide what to do.


configure tests and husky

ts-jest does not working with jest 28.
Wait for resolving this issue:
https://github.com/kulshekhar/ts-jest/issues/3453


vDVS plugin for Windows should be running as a Windows service

Currently the vDVS plugin for Windows (vdvs.exe) can be run in interactive mode only in cmd session. As a Windows daemon, we should change it to run as a Windows service.

Fixed with PR #1624


Address metadata

What I'm trying to achieve
It's useful to store address category, address type, or any other custom field with address. Currently, there is no way to do that. It has already been discussed here for another use case: https://github.com/saleor/saleor/issues/6705
Describe a proposed solution
Add private and public metadata field to Address model.
A (great) PR has already been pushed with the feature : https://github.com/saleor/saleor/pull/6785 and currently need a rebase (see https://github.com/saleor/saleor/pull/6785#issuecomment-1243012807)
Other solutions I've tried and won't work
None that I know.
Other
It would be great if Saleor team could state on this issue so PR can be rebased, cleaned and merged.

Addresses do support metadata now 🎉


Collapsible-Modern-Chat-Plugin

how badly did i mess this up... the plugin is fine but new to github shenanigans

You need to create your plugin file in the plugins/ directory, not pluginhub/, and include the full 40-character hash, not just the short hash.

Also, please push changes to this branch instead of closing and re-opening PRs.

ah okay ty ill try fixing

is this okay or do i still have to make the the file in plugins/ area cause im not sure how to do that without creating another pull request :/

Delete the pluginhub/plugin file you've created and create a file with the same contents in a plugins/resizable-modern-chat file


Allow setting timeout on the ClientSession

Currently the default timeout on ClientSession per aiohttp is 300 seconds, which is incredibly long. While the default can be kept, this should be user changable.

Added this to the latest release. Check it out here.

solved


How to create multiline label for pie chart with arrow mark?

Need to create 2 line text for pie labels, which can show key on first line and value in second line.

is it possible to get any answer? i also need this feature

As there is no response from anyone, I tried the following, got success some extend. I am able to create multiline label only, and not the arrow mark.
As i am using typescript following code will helps to create multiline label:
I have created component for the pie chart -
In its controller injected the $scope like below:
static $inject = ['$scope', '$timeout'];
and in constructed calling the insertLinebreaks method.
constructor looks like below -
constructor($scope: ng.IScope, $timeout: ng.ITimeoutService) {
super($scope);
$timeout(() => {
d3.selectAll('.nvd3.nv-pie .nv-label text').each(this.insertLinebreaks);
}, 500);
}
private insertLinebreaks(d: any, i: number): void {
var el = d3.select(this);
// console.log('el is :' + el);
var words = [];
words.push(d.data.key.toUpperCase());
words.push(d.data.value);
  el.text('');
  el.style("fill", d.data.color);

  for (var i = 0; i < words.length; i++) {
    var tspan = el.append('tspan').text(words[i]);
    if (i > 0) {
      tspan.attr('x', 0).attr('dy', '15').style("fill", "black");
    }
  }
}

It helps to create multiline label for pie chart.
If anyone found better solution then they can comment.
Thanks.

Created plunker.
http://plnkr.co/edit/ftXnRYd4STfYyitTNMa1?p=preview

I just used a custom label (concanated values) but it is of course not inline.. so your solution seems to be much better :)

But there is a bug - if you hide or show something on the legend, multiline labels disappear becoming standard

Didn't get u.

Just click on the legend circles


css-compilers fails when there is an empty scss file

Related to:
https://github.com/Urigo/angular2-meteor/issues/430
https://github.com/Urigo/angular2-meteor/issues/427
If there is an empty .scss file, or a file with empty definitions (which probably removed in the SASS compiler) - the compilers fails and throws an error.
In order to reproduce again the bug - must meteor reset and run again.
@barbatus

I'm getting this error even without any scss/css files. i tried meteor deploy and meteor --production

Note that for me the offending file was actually in node_modules, and an important file for using angular2 with meteor: node_modules/meteor-rxjs/examples/angular2/client/imports/app/app.component.scss

Thanks @sdarnell . I released a new version of meteor-rxjs (0.4.4, a clean publish without any examples or other unnecessary files) and updated the boilerplate to use the new version.

Thanks Dotan for the fast turn-around! Just tested it and it solves the problem.

Please try now. Run meteor update in order to update css-compilers

I am using the latest boilerplate version, with Meteor <IP_ADDRESS>. Updated all packages:
Changes to your project's package version selections from updating package
versions:

babel-runtime*         upgraded from 0.1.13 to 1.0.0
barbatus:css-compiler  upgraded from 0.3.4 to 0.3.5
caching-compiler       upgraded from 1.1.8 to 1.1.9
coffeescript           upgraded from 1.11.1_2 to 1.11.1_3
ddp-common             upgraded from 1.2.7 to 1.2.8
ddp-server             upgraded from 1.3.11 to 1.3.12
ecmascript             upgraded from 0.5.9 to 0.6.0

Then tried to run meteor run --production and got the same error:
Dotans-MacBook-Pro:angular2-meteor-base dotansimha$ meteor run --production
Warning: The --production flag should only be used to simulate production
bundling for testing purposes. Use meteor build to create a bundle for
production deployment. See: https://guide.meteor.com/deployment.html
[[[[[ ~/Dev/angular2-meteor-base ]]]]]

=> Started proxy.
=> Started MongoDB.
=> Errors prevented startup:

   While processing files with angular2-compilers (for target web.browser):
   /tools/isobuild/compiler-plugin.js:717:15: 'data' option to addAsset must be
   a Buffer or String.
   at ResourceSlot.addAsset (/tools/isobuild/compiler-plugin.js:717:15)
   at InputFile.addAsset (/tools/isobuild/compiler-plugin.js:482:24)
   at SassCompilerExtended.addCompileResult
   (packages/barbatus:css-compiler/compilers/basic_compiler.js:32:15)
   at packages/caching-compiler/multi-file-caching-compiler.js:144:14
   at packages/caching-compiler/multi-file-caching-compiler.js:97:11
   at
   /Users/dotansimha/.meteor/packages/angular2-compilers/.<IP_ADDRESS>t7l1hu++os+web.browser+web.cordova/plugin.Angular2Compilers.os/npm/node_modules/meteor/caching-compiler/node_modules/async/lib/async.js:182:20
   at replenish
   (/Users/dotansimha/.meteor/packages/angular2-compilers/.<IP_ADDRESS>t7l1hu++os+web.browser+web.cordova/plugin.Angular2Compilers.os/npm/node_modules/meteor/caching-compiler/node_modules/async/lib/async.js:317:21)
   at
   /Users/dotansimha/.meteor/packages/angular2-compilers/.<IP_ADDRESS>t7l1hu++os+web.browser+web.cordova/plugin.Angular2Compilers.os/npm/node_modules/meteor/caching-compiler/node_modules/async/lib/async.js:328:15
   at Object.async.forEachLimit.async.eachLimit
   (/Users/dotansimha/.meteor/packages/angular2-compilers/.<IP_ADDRESS>t7l1hu++os+web.browser+web.cordova/plugin.Angular2Compilers.os/npm/node_modules/meteor/caching-compiler/node_modules/async/lib/async.js:221:35)
   at SassCompilerExtended.processFilesForTarget
   (packages/caching-compiler/multi-file-caching-compiler.js:95:11)
   at _loop
   (packages/barbatus:css-compiler/compilers/style_compiler.js:20:26)
   at StyleCompiler.processFilesForTarget
   (packages/barbatus:css-compiler/compilers/style_compiler.js:18:36)

=> Your application has errors. Waiting for file change.

Tried meteor reset - got the same.
@barbatus

Ok, it was css minifier to blame. It removes empty classes and returns null.
@dotansimha  angular2-meteor-base has app.component.scss with just .app {}, dunno why. Try pls meteor update one more.

updated to 0.3.5_1, meteor reset, deleted all the css/scss, even html , I don't even have style in Components.

I tried barbatus:css-compiler 0.3.5_1 with meteor 1.4.2 and it still has the issue (when empty styles present).

seems new version is picked up again (there was similar issue before) since I tested locally and it works. @Urigo can we try to publish angular2-compiler with new version of css-compiler (everything is in the PR already)?

I've published<EMAIL_ADDRESS>with @barbatus latest changes.
@ayazhussein @sdarnell can you please try it out?

Now it's working great! Tested with the latest boilerplate.

Working..thanks @barbatus @urigo

Yup, fixes the issue for me.

Beautiful! working for me too after running 'meteor update'
Thanks all for your help!

Yesterday I left my desktop with strange error messages though I removed every single (s)css file and when I returned just now I was surprised by this bug fix. What should I say: it works! What a nice start of the day ;-)


Binocular Armor Whitelist

About the PR
Added the binocular tag to RMCBaseMarineArmor
Why / Balance
Fixes #3999
Requirements

[x] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

add: Binoculars can now be put in armor.

i hope i did it correct, never made a pull request before


Store property tables separately in subtree JSON

This PR implements the changes in the 3D Tiles repository merged in #642. Property tables are now stored under their own property in the subtree JSON. tileMetadata and contentMetadata are now an index and array of indices respectively.
cc @ptrgags

@j9liu thanks, merged!


Missing images when using download.py

There are errors while retrieving the images as the urls are giving 404. Will this affect coding examples in the book further?

This won't affect coding examples, no. It's a random sample from ImageNet and missing a few images through 404 shouldn't affect coding examples.


Pie chart custom tooltip model body callback

I've created a custom tooltip following the example that renders the tooltip body the following way:
    function getBody(bodyItem) {
        return bodyItem.lines;
    }
    var bodyLines = model.body.map(getBody);
    bodyLines.forEach(function(body, i) {
        ...
    }

Then I try to modify the tooltip body content with the following callback:
    callbacks: {
        label: function(item, data) { ... }
    }

Everything works like a charm for line and bar charts BUT pie charts. Looks like the label callback is not called at all for pie charts, same for the title callback. Is there any other way to modify pie charts custom tooltip body content?

Resolved it by adding callback inside defaults.doughtnut instead of defaults.global.

@etimberg I'm not sure if this should be closed.
This is a bug that has affected me as well, the solution proposed by @Simpleqode is a way to overcome this bug but  the bug still exists.


SwiftyJSON use throws for error handling

Since SwiftyJSON updated and uses throwable JSON(data:), the following files should be updated.
YTLiveRequest
GooglePlusRequest
use JSON(data:) without try

Sorry that I didn't update the pod... I got the new release you uploaded 13 days ago.


add revoke item API. #2856

What's the purpose of this PR
add revoke item API.
Which issue(s) this PR fixes:
Fixes #2856 #2595

Codecov Report

Merging #2952 into master will decrease coverage by 0.16%.
The diff coverage is 4.54%.

@@             Coverage Diff              @@
##             master    #2952      +/-   ##
============================================
- Coverage     51.24%   51.07%   -0.17%
+ Complexity     2217     2216       -1
============================================
  Files           431      431
  Lines         13296    13340      +44
  Branches       1366     1370       +4
============================================
  Hits           6813     6813
- Misses         6007     6050      +43
- Partials        476      477       +1

Impacted Files
Coverage Δ
Complexity Δ

...ework/apollo/portal/controller/ItemController.java
7.14% <0%> (-0.18%)
1 <0> (ø)

...p/framework/apollo/portal/service/ItemService.java
47.85% <4.76%> (-14.96%)
16 <1> (ø)

.../apollo/internals/RemoteConfigLongPollService.java
79.51% <0%> (-1.21%)
28% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0769c80...0739a62. Read the comment docs.

Coverage decreased (-0.2%) to 54.648% when pulling 0739a624f44012cb01f4edde670d6e2fa87342d3 on Accelerater:#2856 into 0769c80f661d82af3f0b53802fb25dc77f7d09a8 on ctripcorp:master.

感谢 @bigflybrother  提供Portal页面支持。


Make DismissibleBanner persistently dismissed

Feature Suggestion
Use the new storage API to save the dismissed state permanently, so that the same dialog is not shown more than once.
import { useApi, storageApiRef } from '@backstage/core';

Possible Implementation
Example of usage in https://github.com/spotify/backstage/pull/1143/files#diff-6dba8b9dac99065b066d81e6e8e22a98R17
Context
Clicking this button currently does not permanently dismiss the banner.

@stefanalund happy to have a go at this one.

@benjaminr great! I’ve assigned you.

Closed in https://github.com/spotify/backstage/pull/1168

Hey guys!
Do you know how I can make it so that even if the user closes the banner, it appears every time the user logs in again?

@stefanalund @benjaminr @aizatto @chap


feat (DAL): timestamp support

@kevin-dp what's the relation between this PR and #537?

This is the predecessor of #537 and is now made obsolete by it.
Closing this one.


Beaconised VP API Specification

Overview
This pull request suggests changes to Beaconise the specification. Changes include:

Adding informational endpoints.
Defining schemas for responses.
Updated documentation to reflect changes.

Further Discussion

Define the ontologies used in an implementation - should the complete Ontology URI be used?
Filter alignment with Beacon v2 spec - to be compliant with Beacon, align the current custom filters to be more standardised by making CDE terms as concepts instead of filter types (see below).
AnyOf option for disease/ontology terms - the need for the ability to send multiple terms, rather than multiple queries using either:

an array of 'id' elements as an OR query, or,
create a custom filter using an array.

The above topics have been addressed in PR #11; hence closing this issue.


Rename the Julia TagBot.yml file to TagBot.yml

In order for the General registry to be able to trigger TagBot on your repo, the TagBot configuration file cannot have any spaces in its filename.
Would you mind merging this PR? It simply renames the file with no other changes.
cc: @ThummeTo

cc: @ThummeTo @JoKircher

Thank you!


REALMC-10671: Use remote app id for push command success message

close this as it had the wrong JIRA information included


 I will run CI in another PR.

CI here: https://github.com/pachyderm/pachyderm/pull/2555


Deploy Your Node.js App with the Cloud Foundry CLI

Tutorial URL: https://developers.sap.com/tutorials/cp-node-deploy-cf-cli.html
Please specify the step you are referring to Step 2: Push the app to your SAP Cloud Platform Cloud Foundry space
Hi,
I've tried to execute the command cf push manifest.yaml but I got this message:
Please, how could I know the space?

Thanks!
Best regards,
Dotta

hey @mfdotta,
please change your app name in the manifest.yaml. Somebody else is already using the app name and thus the route is already taken. But that shouldn't happen if you have set random_route to true.
can you post a screenshot of your manifest.yaml?
Thanks,
Max