New Azure Hybrid DNS Guidance

Scope, and intent of this PR:
Learnings from the field and customer interactions.  Customers struggle adopting DNS in a Hybrid approach and require guidance and possibilities. This guideline is to help customers understand the possibilities in a Hybrid DNS scenario and expands upon our existing document, containing additional architectures and DNS Flows to help customers understand how the target DNS will look like.
Insert links(s) to any related work item(s) or supporting detail:
https://learn.microsoft.com/en-us/azure/architecture/hybrid/hybrid-dns-infra
AFTER YOUR PR HAS BEEN CREATED, expand this section for tips and additional instructions.
These are common guidelines for contributions across the repos managed by the Cloud Architecture Content Team (CACT). Some repositories may have additional specific requirements that are not listed here.
Guidance for all contributors

Topic
Guidance

Draft PR
If your PR will be a work-in-progress for more than a day or two, select the Convert to draft link in the upper right of the page (under Reviewers) to change it to a draft. For future reference, you can also do this using the Create pull request button drop-down during PR creation.

ms.date metadata
Don't update an article's "ms.date" metadata property unless you've done a full freshness review of the content. A full freshness review includes changes required to correct or improve the full technical accuracy of the article.Don't update "ms.date" if you're doing targeted changes to improve non-technical aspects of the article, such as editorial quality, art improvements, article template alignment, etc.If you've changed any "ms.date" properties for work that wasn't part of full review for freshness, please reset them to their previous value.

Placement and linking
If you're creating a new article or articles, include updates to the related TOC.yml file to propose where the article(s) should be placed. Also consider other places within the document set where it would be beneficial to cross-reference and link to your new article(s).

PR build
After you open your PR, and for each successive commit that you push to your branch, the publishing platform will run validation on the files in your pull request. A summary of the build results for each file will be inserted inline into your pull request, which includes any build suggestions/warnings/errors. PRs cannot be merged until all build errors and most warnings are resolved.

Publishing
Following a successful merge, most repos publish to the live site at least once per (business) day, usually around 10am Pacific.

Additional resources
Learn.Microsoft.Com contributor guide

Additional guidance for private repos and internal contributors

Topic
Guidance

PR size
If your PR is more than ~5 lines of changes, or you'd like for the changes to go through editorial or larger review, open a contribution request at https://aka.ms/Contribution and include a link to the PR in response #8. Once it's processed, you'll be notified of the next steps.

PR title prefix
Select the Edit button to the right of the PR title if you need to revise it. The following prefixes are reserved for specific contribution types:[Quality Check] - maintenance work related to content quality (edit passes, art improvements, template alignment)[LinkFix] - recurring/adhoc PRs to correct link URLs[Pipeline] - new/updated contributor success pipeline content[WIP] - a work-in-progress draft requiring several days/weeks

PR preview
Following successful build of your PR, publishable files will also include Preview URL links to staged previews of your new/updated articles. Be sure to review these for verification of your intended contributions, or to send to other internal contributors for review.

PR sign-off (public repo)
If an article you own is updated in a public repo PR, you are responsible for sign-off. You will be automatically notified via email. The PR will not be merged until you've had a chance to review and sign-off.

PR sign-off (private repo)
After you've completed your proposed changes, addressed build warnings, and completed all review work, you can begin the sign-off process for review and merge:If your PR is in draft mode, remove "[WIP]" from the title and select Ready for review button at the bottom of the PR.Enter "#sign-off" in a new comment. This comment indicates that you're confident the work meets or exceeds Microsoft's standards for publication, and will trigger the review process.Your PR may be selected for initial review by the CACT. Following CACT review, you may receive questions or requests for additional changes. You should have initial feedback from CACT review within a few business days. If you have an urgent request or need to contact the team, please mention @MicrosoftDocs/cloud-architecture-content-team-pr-reviewers in your PR and someone will get back to you. After CACT review is complete, a CACT #sign-off will be added.Final review/merge is done by the PR review team. The PR team may also respond with feedback, categorized as "Blocking" (requires action from you), or "Non-blocking" (to be addressed in a future PR).

Additional resources
Learn.Microsoft.Com internal contributor guideAuthoring templates: architecture-center-pr, well-architected-prTo contact the CACT use e-mail, or @mention our GitHub team in your PR comments using: @MicrosoftDocs/cloud-architecture-content-team-pr-reviewers

@infobozk please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement
Contribution License Agreement
This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”), and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below.

Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.
Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
Licenses.

Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

@microsoft-github-policy-service agree company="Microsoft"

@MicrosoftDocs/cloud-architecture-content-team-pr-reviewers - Please review the proposed content. If you want to move forward with the content, the commits should be moved into the private repo for staging and automated checks. Let us know if you'd like the PR review team's help with that.
#label:"aq-pr-triaged"
#label:"pending-content-team/business-approval"
Cc: @MicrosoftDocs/public-repo-pr-review-team

#label:"cact-review-in-progress"

@infobozk  - thanks very much for this contribution!
For large contributions like this we'll also need a couple more steps. This process augments our standard PR review process, to allow for appropriate technical/editorial review:

A PR opened into our private repo to enable internal staging of articles and facilitate internal PR review. If you have questions or need assistance refer to this article in our contributor guide.
A request filed at https://aka.ms/contributions. Be sure to check "Azure Architecture Center" for question # 5, and paste your private repo PR URL in question # 7.

Please drop a comment here once you've filed the request.
I've also converted your PR to draft state for now. Once the private repo PR is opened this PR can be closed. Please let me know if you have questions on any of this.

@infobozk - thanks very much for this contribution!
For large contributions like this we'll also need a couple more steps. This process augments our standard PR review process, to allow for appropriate technical/editorial review:

A PR opened into our private repo (architecture-center-pr) to enable internal staging of articles and facilitate internal PR review. If you have questions or need assistance refer to this article in our contributor guide.
A request filed at https://aka.ms/contributions. Be sure to check "Azure Architecture Center" for question # 5, and paste your private repo PR URL in question # 7.

Please drop a comment here once you've filed the request.
I've also converted your PR to draft state for now. Once the private repo PR is opened this PR can be closed. Please let me know if you have questions on any of this.

Hi Bryan,
Thank you for the swift response. I followed the instructions, new PR has been opened and I've also submitted the form. If there are indeed no further actions required I will close this PR.

@infobozk - can you reference the new PR so we can track it from here as well? thanks!

@infobozk - can you reference the new PR so we can track it from here as well? thanks!

Sure, here it is:
https://github.com/MicrosoftDocs/architecture-center-pr/pull/11510
If no information is further required, please let me know and I’ll close this PR.


refactor: improve code

Save on${capitalize(event)}  as a variable to avoid multiple execute

It's inside the __DEV__ branch so it should not be evaluated out of the branch.


Make Creator Interface a Functional so it can be treated like that in the code by the time that it needs to create the entity

Or even remove it... because it is function

Creator will remains but annotated with the Functional Interface and modify the DSL to accept a function.


The results on the GQA-OOD dataset.

Dear chojw,
Hello,
I noticed in your paper that your method achieved a result of 49.43 on GQA-OOD, which is an impressive outcome! However, I have a question: is this result obtained on the GQA-OOD validation set or on the GQA-OOD test-dev set?
Thank you and I look forward to your response!
Best regards,
yswness

Hi, as I recall, we followed the protocol listed here https://github.com/gqa-ood/GQA-OOD
I believe the results should be the GQA-OOD test .
Thanks!


notification

Subject: notification
Description:
nothing
Results:
when someone text me back I don't receive a notification from the website, both e-mail or web
Backend version: develop-7c33e18d
Frontend version:
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:105.0) Gecko/20100101 Firefox/105.0
Page: https://couchers.org/messages/chats
User: nico00 (19276)

Too vague to reproduce


Respect mach timebase when computing latencies.

Fix for bug 1665243
This fixes a bug where incorrect position information would be returned
when compiling for Apple Silicon, where mach time values do not map 1:1
to nanoseconds.
See https://developer.apple.com/documentation/apple_silicon/addressing_architectural_differences_in_your_macos_code#3616875

I think there's a typo in that last link and it should be https://developer.apple.com/documentation/apple_silicon/addressing_architectural_differences_in_your_macos_code#3616875

Thanks, fixed.


Feature: Check server health in the background

Optional feature (disabled by default in server management panel). Periodically check server health in the background with a periodic worker (run every 30 minutes when there's network). Shows the server connection error notification when health check fails, clears it when it comes back.

Abandoned?


agent-cypress will only use the branch-name from cypress.json and not recognize changes to the config

We have set a default branch in cypress.json for VRT.
When we change the cypress config as documented from the /cypress/plugins/index.js file (and afterwards initialize VRT with the updated config), these changes are not recognized. VRT still uses the default branch name.
Here is our plugins index.js:
const {
  addVisualRegressionTrackerPlugin,
} = require('@visual-regression-tracker/agent-cypress/dist/plugin');

module.exports = async (on, config) => {
  // eslint-disable-next-line no-param-reassign
  config.env.visualRegressionTracker.branch = 'test1234';
  addVisualRegressionTrackerPlugin(on, config);
  return config;
};

should be fixed in version 3.0.3

thanks for report!


Add on option to support all languages

Until now only FR languages are supported.
Let's make it accept all languages via a nice "language option"

+1


Add API proxy (close #65)

This change is

Reviewed 4 of 5 files at r1.
Review status: 3 of 5 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 1 of 5 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

I suggest a slight reordering of the steps, basically getting all setup out of the way first, then discussing how to configure kubectl, then deploying the example app. So,

Configuration
1.1. Weave stuff
1.2. docker run ... setup-single-node && compose -p ...
1.3. docker run ... kube-system-namespace.yaml ...
1.4. docker run ... skydns-addon-secure-v1.2 ...
Various ways to set up kubectl
2.1. alias kubectl docker run ... kubectl
2.2. Use kubectl --server=http://localhost:8001
2.3. Save the print-apiproxy-config output to localcluster file and use kubectl --kubeconfig
Deploy the guestbook app
3.1. Just use plain kubectl in all the examples here

Possible enhancement: Have print-apiproxy-config print the kubectl config commands to add the weave context.
Folks may have more than one K8s cluster - so they will not want to blow away their .kube/config

@wstrange good point, also that's exactly the reason I've explicitly given > ./local-cluster as the first option. I'll think of adding what you said also.

Reviewed 1 of 2 files at r4, 1 of 1 files at r5.
Review status: 4 of 5 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 1 of 2 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Difficulty in inspecting code of imported packages in another package

Currently, it is difficult to execute a function declared in another package as a goroutine or to validate the code used as the CustomRecover function.
e.g
// github.com/Buzzvil/recovergoroutine/otherpkg
func Run() {
    defer recover()
}

func Recover() {
    if r := recover(); r != nil { // ... }
}

// github.com/Buzzvil/recovergoroutine
import "github.com/Buzzvil/recovergoroutine/otherpkg"

func main() {
    go otherpkg.Run() // fail
    go func() {
        defer otherpkg.Recover() // fail
    }()
}

Due to #7 work, this issue is closed.


ByteArrayAssert with Hex-Strings

Summary
Hi i am using a lot of hexadecimal strings in my byte[] Tests. I think the code and the dependency tree could be nicer.
What do you think about this method?
I will write a pull request if this improvement is welcome.
Example
Usage of the new method:
 assertThat(new byte[] { (byte) 255 , 2  }).asHexString().isEqualTo("FF02");

 assertThat(new byte[] { (byte) 255 , 2  }).asHexString().isEqualTo("AF02");
org.opentest4j.AssertionFailedError:
Expecting:
 <"FF02">
to be equal to:
 <"AF02">
but was not.

Implementation suggestion:
public abstract class AbstractByteArrayAssert<SELF extends AbstractByteArrayAssert<SELF>>
    extends AbstractArrayAssert<SELF, byte[], Byte> {
....
  public AbstractStringAssert<?> asHexString() {
    objects.assertNotNull(info, actual);
    return Assertions.assertThat(Hexadecimals.toHexString(actual));
  }

asHexString looks useful, fine by me.
The implementation would need to cater for soft assertions.


Changelog

As requested by @oleg-nenashev and @daniel-beck for PR https://github.com/jenkinsci/jenkins/pull/2593#issuecomment-268729145.

As I wrote in the other PR, it…

updates from 1.243 to 1.246, not from 1.244. Full list:
https://github.com/stapler/stapler/pull/73
https://github.com/stapler/stapler/pull/75
https://github.com/stapler/stapler/pull/77
https://github.com/stapler/stapler/pull/78
https://github.com/stapler/stapler/pull/79
https://github.com/stapler/stapler/pull/80

Also, that merge introduced a regression which resulted in 1.247 and 1.248.
So whatever this PR does, it's not even close to a recent changelog.

@daniel-beck Added change logs from 1.243 till 1.248. Please take a look.

I doubt the rendering is an expected one. It's hard to understand it

Go thru linked PRs and issues to get full understanding. This is summry it's unreasonable to expect to get full understanding of each or just from a sentence or two.

I just say the layout is barely readable, I do not request more details in the changelog itself

@oleg-nenashev Made some adjustments, please take a look.

LGTM 👍

@oleg-nenashev process wise, I wait for another LGTM or its good for merging? CI is failing but thats unrelated, this PR has no code changes.

I think it's fine to merge since the current changelog provides valuable information. If there any additional fixes, we can add changes in follow-up PRs.


refactor: make StreamingRpcMetadata public

This type is used to return the per-request metadata on streaming RPCs. So far it was only used in non-public APIs. I am planning to now use it in google::cloud::AsyncStreamingReadWriteStreamingRpc<> which is public and therefore the type must now become public too.

This change is

Ping


Update unified-signatures to be like the one for tslint

Since palantir/tslint#1944 made some improvements, adding them here.
We no longer consider static foo() and foo() to be overloads. This should fix the lint error in DefinitelyTyped/DefinitelyTyped#13628.

No longer needed as we now use the one from tslint. #271


i18n(es): Update google-firebase & heroku

Description (required)
Updated google-firebase & heroku based on these commits:

39720c940acc44cc19b2216106c28c75b5758b3d
2b5c5a36b7e43d89e446bfdf36b1360bd730b46d
d0e247728ab7ea95f28d3b8871573e4b01ca6296

Related issues & labels (optional)

Suggested label: i18n

Thank you @VoxelMC and @Waxer59 for your reviews 😁


Update Template issue with target date

Which area/kind this issue is related to?
/area api
Issue Description
As a process for our GitHub issues, every assignee should add a "target date" to the issue after they are assigned to it. This helps everyone involved in the issue to know when we are expected to be completed.
I think it would be useful to have a target date field in specific issue templates. This will stand as a reminder for the assignee in order not to forget to add a target date for the issue.

Closing at the moment as it might not be the optimal solution


Ignore AutoMod Messages

Automod messages are sent with the original user as the author, which means they are recorded as that user's messages in metricity. Messages with the automod type should be ignored.

This was solved in https://github.com/python-discord/metricity/pull/18


resolve network instance switch creation problem

Resolving the problem of networkInstance switch creation #589. Removing the redundant code.
Signed-off-by: Petr Fedchenkov<EMAIL_ADDRESS>

Seems we still have problems:
$ eden network create --type switch -n direct
$ eden pod deploy -v debug -n eclient docker://itmoeve/eclient:0.4 -p 2223:22 --networks=direct --memory=512MB
$ eden pod ps
NAME    IMAGE                   UUID                                    INTERNAL        EXTERNAL        MEMORY  STATE(ADAM)     LAST_STATE(EVE)
eclient itmoeve/eclient:0.4     2de3a82a-b984-4ce6-b255-45190f7bb23c    -:22            <IP_ADDRESS>:2223  0 B/0 B IN_CONFIG       INSTALLED: [description:"createACL: PortMap without appIP for lport 2223/protocol tcp: {Matches:[{Type:protocol Value:tcp} {Type:lport Value:2223}] Actions:[{Drop:false Limit:false LimitRate:0 LimitUnit: LimitBurst:0 PortMap:true TargetPort:22}] Name: RuleID:2 Dir:0}\n\n"  timestamp:{seconds:1619173782  nanos:514268897}]

Hi, @sadov.
I can see in ./eden pod deploy --help
Flags:
      --acl strings           Allow access only to defined hosts/ips/subnets

So, what is your expected behavior in case of --acl='[]'?

Hi @giggsoff,
It would actually be great to have some combination of arguments to convert from this application's interface configuration:
                {
                    "name": "direct",
                    "networkId": "72a14885-73c4-4fe7-a4b2-f919c05bf065",
                    "addr": "",
                    "hostname": "",
                    "cryptoEid": "",
                    "lispsignature": "",
                    "pemcert": null,
                    "pemprivatekey": null,
                    "macAddress": "",
                    "acls": [
                        {
                            "matches": [
                                {
                                    "type": "ip",
                                    "value": "<IP_ADDRESS>/0"
                                }
                            ],
                            "actions": [],
                            "name": "",
                            "id": 3,
                            "dir": "BOTH"
                        }
                    ]
                }

to config with empty acl array:
                {
                    "name": "direct",
                    "networkId": "72a14885-73c4-4fe7-a4b2-f919c05bf065",
                    "addr": "",
                    "hostname": "",
                    "cryptoEid": "",
                    "lispsignature": "",
                    "pemcert": null,
                    "pemprivatekey": null,
                    "macAddress": "",
                    "acls": []


Getting list of instances modified by Resize

Hi,
Is there a way of knowing which instances were modified by resize command ?
I would like to print it to the log file
Thanks

There is no way to do that currently and I expect it would make for a large log file.  You could just dump def before and after to compare.

There is no way to do that currently and I expect it would make for a large log file.  You could just dump def before and after to compare.

stale


Add React 18 to peerDependencies

Closes https://github.com/jaketrent/react-social-icons/issues/119

Please approve this PR

Thank you for your contribution, released in v5.14.0 https://www.npmjs.com/package/react-social-icons/v/5.14.0


switch to less and add a web server with gulp for local development

tut tut no approval 😉

you admitted you didnt know


Add config variable for max sesssions

Describe the bug
after select time period,then chose export csv and use matching items  option,I cannot get all sessions in this period when it was downloaded, I check the file and found the number of sessions is 2000001,the filesize is 202MB
Elasticsearch version:
7.10.2
Arkime/Moloch version:
v5.0.1
OS name and version:
CentOS 7 x86_64
How was Arkime/Moloch built/installed: (rpm, deb, easybutton, ...)
rpm

We currently hardcode the max number of sessions to 2000000, add a new config variable


Refactor commondb Package

Describe the chore that needs to be addressed.
In the models/commondb package, each of the existing models needs to be refactored into it's own sub-package with a record class and a table class.  See the models/commondb/site_info sub-package for example.

[ ] This issue subsumes the following issues:

See PR #933

Subcategory implemented in PR #937

Condition implemented in PR #990


PSG-4840 openapi client import error

What's New?
Fix in generate.sh to have openapi_client.rb to replace require with require_relative. This ensures that there does not have to be dev intervention whenever a new sdk is generated.
Type of change

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have manually tested my code thoroughly
[ ] I have added/updated inline documentation for public facing interfaces if relevant
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing integration and unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Additional context
Generated sdk locally to test

Are we going to publish this change or wait to publish with the other backend sdk improvements?

Are we going to publish this change or wait to publish with the other backend sdk improvements?

Since this change isn't included in the build artifact it can be merged without worrying about a version bump or anything


ci: update azd validation workflow

Purpose
Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[x] Other... Please describe: CI

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

@anfibiacreativa @manekinekko could you have a look?


Add NSX-T support in change_vm_vif.py

This PR adds support for providing VMware NSX-T Logical Switch when changing vNIC of a VM.
I also did a minor change to provide VM name instead of VM uuid.

New Sample will be created with NSX-T changes.
Closing this PR.


404 when using CDN version suggested in documentation

I'm following the documentation here, but get the following error message when loading the page:
Source map error: Error: request failed with status 404
Resource URL<EMAIL_ADDRESS>Source Map URL: index.browser.min.js.map

Tried Firefox and Chromium, same result.
Relevant line:
    <script<EMAIL_ADDRESS>

Hi @tmalsburg,
this is your browser trying to load the source map file that belongs to<EMAIL_ADDRESS>(which is https://unpkg.com/jspsych@7.3.3/dist/index.browser.min.js.map), failing to find it at https://unpkg.com/index.browser.min.js.map. The source maps are not required to run jsPsych, but they can help you debugging it. You can work around the error by using the canonical script URL:
js```

I found a workaround for this issue in the build chain of my v8 draft, but didn't bother to look for a way to backport it yet. I'm planning to do so, so let's keep this issue open until I get to it.

Cheers!


Computed attribute as property

Hello!
Thanks for the package and the implementation.
However, it seems that computed field are not updated when attributes are changed as for a property. Example:
from pydantic import BaseModel
from pydantic_computed import Computed, computed

class ComputedModelInt(BaseModel):
    a: int
    b: int
    c: Computed[int]
    @computed('c')
    def calculate_c(a: int, b: int):
        return a + b

def test_changes_value():
    model = ComputedModelInt(a=1, b=2)
    model.a = 5
    assert model.c == 7

test_changes_value()

When the class is constructed, value of attribute model.c is computed and is 3. When we change model.a to 5, if attribute behaves like a property, then we expect to have model.c == 7.
Are you considering adding this as a new feature?

Thanks for the issue, i'll have a look into it :)

Found a solution. This will be added in the next update :)

Thanks a lot! I've just tested it, and it perfectly works. I will definitly use it in my project.
Here my test cases.
class ComputedModelInt(BaseModel):
    a: int
    b: int
    c: Computed[int]
    @computed('c')
    def calculate_c(a: int, b: int, **kwargs):
        return a + b

class ComputedModelStr(BaseModel):
    a: str
    b: str
    c: Computed[str]
    @computed('c')
    def calculate_c(a: str, b: str, **kwargs):
        return a + b

def test_simple():
    model = ComputedModelInt(a=1, b=2)
    assert model.c == 3

def test_to_dict():
    model = ComputedModelInt(a=1, b=2)
    assert model.dict().get('c') == 3

def test_to_json():
    model = ComputedModelInt(a=1, b=2)
    assert json.loads(model.json()).get('c') == 3

def test_overwrites_value():
    model = ComputedModelInt(a=1, b=2, c=5)
    assert model.c == 3

def test_datatype_conversion():
    model = ComputedModelStr(a=1, b=2)
    assert model.c == '12'

def test_changes_value():
    model = ComputedModelInt(a=1, b=2)
    model.a = 5
    assert model.c == 7

test_simple()
test_to_dict()
test_to_json()
test_overwrites_value()
test_datatype_conversion()
test_changes_value()


Add X-Forwarded-Proto header for ssl proxy

Backend application usualy use this header to determine protocal being
used at browser. Althought it's not part of the standard but it's a
defactor practise already.

WikiPedia: https://en.wikipedia.org/wiki/X-Forwarded-For ( sorry that's a wrong link,  https://en.wikipedia.org/wiki/List_of_HTTP_header_fields )
Ruby on Rails: https://github.com/josh/rack-ssl/blob/master/lib/rack/ssl.rb

Without this patch setting force_ssl = true in a Rails application will cause infinite redirection loop

Thank you 👍

@typicode  any chance a release could be cut for this? I just hit this issue as well

yes, will release it today

just published v0.5.5 with @layerssss's fix :tada:


Update README.md

This is to add a dependency dbus-python to the installation in Fedora, and to add instructions to install it in RHEL 7. On RHEL 7, it is not recommended to add a kernel parameter by editing /boot/config-$(uname -r) directly. Suggestions on how to correctly set CONFIG_DEVMEM=y is welcome.

Since you already have a PR open, could I ask you to add sudo just before dnf install? I spent a good few minutes confused why the packages didn't install.


perf: minor optimizations

Thank you. I'll apply the map size hinting in the https://github.com/pocketbase/pocketbase/tree/filter-enhancements branch, but I don't think the buffered channel is needed.


10/08 PM Publishing

Build.Reason:Manual by APEX VSS Service Account
Build.Url:https://apidrop.visualstudio.com/Content CI/_build/results?buildId=166830&view=results
source_repo.branch:master
source_repo.url:https://github.com/Azure/azure-cli

Docs Build status updates of commit 904534f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

latest/docs-ref-autogen/acr/scope-map.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/acr/token.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/ams/asset.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/mysql/flexible-server.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

latest/docs-ref-autogen/postgres/flexible-server.yml
:white_check_mark:Succeeded
View (azure-cli-latest)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Let's make ffuf smarter

Yo!
When I'm scanning hosts with ffuf like:
ffuf -w wordlists/wordlist.txt -u https://host.com/FUZZ
with big wordlist (50k+ lines), I usually get same responses like:
GET https://host.com/word1 - Response: blabla
GET https://host.com/word2 - Response: blabla
...
because of host "404 page" with not 404 status code.
And  I need to stop my scan and add a size filter to put aside non informative ("404") responses:
ffuf -w wordlists/wordlist.txt -u https://host.com/FUZZ  -fs 6 (blabla length is 6)
So, I offer a feature - ffuf makes 10 test requests like
GET https://host.com/word1 - Response: blabla ... GET https://host.com/word10 - Response: blabla
and, if response length is same (for example, all responses have length 6), ffuf should not display all responses with length 6 as results.
This may work like a flag:
ffuf -w wordlists/wordlist.txt -u https://host.com/FUZZ  --filter-same-len
This feature looks a little dumb, because we just can add correct -fs flag always, but, in situation, when we want to scan many hosts, it would be impossible to put correct flag for each host.
Example:
ffuf -u W2/W1 -w wordlists/wordlist.txt:W1,hosts.txt:W2
Cheers,
Ivan

Cheers, have you checked out -ac ? It's currently doing a bit greedy filtering, but I'm reworking it to filter based on the lowest common denominator.

Hello. Thanks for response.
I've checked out this flag and it works in most of cases.
But, sometimes, server responses look like:
GET /any_non_existent_dir - Response: 200, length 123 - 1st
GET /any_non_existent_file.html - Response 200, length 322 - 2nd
And ffuf with flag -ac still track 2nd responses as results.
Example. I created a wordlist:
file1.html
file2.html
file3.html
file4.html
file5.html
dir1
dir2
dir3

It'll be at test/wordlists/test.txt
And let's run ffuf against such host:
ffuf -w test/wordlists/test.txt -u https://<IP_ADDRESS>/FUZZ -v

        /'___\  /'___\           /'___\
       /\ \__/ /\ \__/  __  __  /\ \__/
       \ \ ,__\\ \ ,__\/\ \/\ \ \ \ ,__\
        \ \ \_/ \ \ \_/\ \ \_\ \ \ \ \_/
         \ \_\   \ \_\  \ \____/  \ \_\
          \/_/    \/_/   \/___/    \/_/

       v1.2.0-git
________________________________________________

 :: Method           : GET
 :: URL              : https://<IP_ADDRESS>/FUZZ
 :: Wordlist         : FUZZ: test/wordlists/test.txt
 :: Follow redirects : false
 :: Calibration      : false
 :: Timeout          : 10
 :: Threads          : 40
 :: Matcher          : Response status: 200,204,301,302,307,401,403
________________________________________________

[Status: 200, Size: 1527, Words: 219, Lines: 58]
| URL | https://<IP_ADDRESS>/file2.html
    * FUZZ: file2.html

[Status: 200, Size: 1527, Words: 219, Lines: 58]
| URL | https://<IP_ADDRESS>/file1.html
    * FUZZ: file1.html

[Status: 200, Size: 1527, Words: 219, Lines: 58]
| URL | https://<IP_ADDRESS>/file4.html
    * FUZZ: file4.html

[Status: 200, Size: 1527, Words: 219, Lines: 58]
| URL | https://<IP_ADDRESS>/file5.html
    * FUZZ: file5.html

[Status: 200, Size: 1527, Words: 219, Lines: 58]
| URL | https://<IP_ADDRESS>/file3.html
    * FUZZ: file3.html

:: Progress: [8/8] :: Job [1/1] :: 0 req/sec :: Duration: [0:00:00] :: Errors: 0 ::

So, without -ac flag all non existing html files tracked.

So, this case is a bit tricky. And maybe extra pre-check with different random files is needed.

By default -ac works in a way that it generates random requests towards the target. In your example above, I think the "default" responses would be something else than the matches found and reported.
In this case you can use the flag -acc which allows you to specify the known targets (as I think the rationale here is), that you want to use for examples to filter on, like so:
ffuf -w test/wordlists/test.txt -u https://<IP_ADDRESS>/FUZZ -v -ac -acc 'something_random_to_catch_default_404' -acc 'dir1' -acc 'file2.html'

As noted, the logic with this will be refined in the future, but I think that the feature you are suggesting is already implemented with the functionality above.

Hello. Got it. Agree with you about case with single host.
But when I try to use -ac flag with many hosts scan, I got an error:
ffuf -u W2/W1 -w test/wordlists/test.txt:W1,test/wordlists/hosts.txt:W2 -ac -v
Error in autocalibration, exiting: Get adminKowKHfwFWbNTWURO//adminKowKHfwFWbNTWURO/: unsupported protocol scheme ""

Where hosts.txt looks like:
https://example.com
https://example1.com
https://example2.com

Without -ac flag all works normally.
And it is strange.

在进行 -r  or -recursion 扫描时候 -ac无效

@joohoi , Is this still in progress or something like this is out?

I think this kind of filtering could have a disadvantage of missing valid endpoints.
Often I see in the wild this kind of endpoints.

I you would use you smart filtering then you would lose let's say
action4
action5
action6
However it would be reasonable to use this smart filtering with a ±1000 same responses threshold.


[SPARK-23496][CORE] Locality of coalesced partitions can be severely skewed by the order of input partitions

What changes were proposed in this pull request?
The algorithm in DefaultPartitionCoalescer.setupGroups is responsible for picking preferred locations for coalesced partitions. It analyzes the preferred locations of input partitions. It starts by trying to create one partition for each unique location in the input. However, if the the requested number of coalesced partitions is higher that the number of unique locations, it has to pick duplicate locations.
Previously, the duplicate locations would be picked by iterating over the input partitions in order, and copying their preferred locations to coalesced partitions. If the input partitions were clustered by location, this could result in severe skew.
With the fix, instead of iterating over the list of input partitions in order, we pick them at random. It's not perfectly balanced, but it's much better.
How was this patch tested?
Unit test reproducing the behavior was added.

@hvanhovell

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1019/
Test PASSed.

Test build #87632 has started for PR 20664 at commit 6d67dfc.

Thanks for the comments.
I don't think the users should be impacted by changing execution time. If the parameters of the job are constant, then the partition allocation should also be deterministic, since the seed is fixed in CoalescedRDD.scala. There was already a degree of randomization in DefaultPartitionCoalescer.pickBin() which could lead to some fluctuation, so it's not a big difference.
TBH, I'm just trying to merge upstream a fix we've implemented for the client. I agree much more could be done to improve coalesce, and if someone would be interested in looking into it, I'm all for it.

Test build #87632 has finished for PR 20664 at commit 6d67dfc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87632/
Test PASSed.

This LGTM overall, just some nits.

Test build #87672 has started for PR 20664 at commit 0512736.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1059/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87672/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1085/
Test PASSed.

Test build #87697 has started for PR 20664 at commit 0512736.

Test build #87697 has finished for PR 20664 at commit 0512736.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87697/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1100/
Test PASSed.

Test build #87715 has started for PR 20664 at commit 0512736.

Test build #87715 has finished for PR 20664 at commit 0512736.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87715/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1143/
Test PASSed.

Test build #87771 has started for PR 20664 at commit 0512736.

Test build #87771 has finished for PR 20664 at commit 0512736.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87771/
Test FAILed.

retest this please

Test build #87827 has started for PR 20664 at commit 0512736.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1183/
Test PASSed.

Test build #87827 has finished for PR 20664 at commit 0512736.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87827/
Test FAILed.

retest this please

Test build #87954 has started for PR 20664 at commit 0512736.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1270/
Test PASSed.

Test build #87954 has finished for PR 20664 at commit 0512736.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87954/
Test PASSed.

Merged build finished. Test PASSed.

Merging to master. Thanks!
@mgaido91 if you feel this should be different, feel free to open a follow-up.


Correcting the example given in jobs/rabbitmq

Fixes #15651

/assign @chenopis

@vishakhanihore can you explain why this commit is the right change to make?
(I looked at the commit message, and I still wasn't sure I understood).

Going by the comments in the parent issue,  I don't think this should actually be changed. sys.stdin.readlines() is valid python3 (tested it quick myself).

Should it be closed @mrbobbytables

@vishakhanihore I think so. Sorry for the confusion on the issue.

@vishakhanihore I think so. Sorry for the confusion on the issue.

No worries, I will be back with a new PR. Thanks


[docs] create a diagram image that explains the hf:// paths

On the same type of https://huggingface.co/docs/hub/gguf

I also did something similar for the converted Parquet files: https://www.linkedin.com/feed/update/urn:li:activity:7092975830020075520

Figma here: https://www.figma.com/file/Njhkk9wVE5E9tYlXrpSjo5/ParquetURL?type=design&node-id=0%3A1&mode=design&t=m82D8BqyKh2jhtak-1

cc @julien-c  (https://huggingface.slack.com/archives/C04BP5S7858/p1710583335439119)

the parquet one looks nice!

Nice idea, yes!

Another Parquet diagram:

from https://twitter.com/andy_pavlo/status/1790524064995688660

maybe re-do the parquet one but for DuckDB hf:// paths and display it inside the DuckDB related docs?

wdyt?
https://www.figma.com/design/D0S8By7C8Use8ZDdVZZj8P/hf%3A%2F%2F-URLs

maybe do a branch example with a simpler branch name like @main?

and i think i would remove spaces and models to keep things focused on datasets

and mention that refs/convert/parquet is auto-conversion

cc @cfahlgren1 might be interesting to you!

This is great, maybe for the parquet branch, a mention of partial conversions up to 5gb might be helpful.

Not sure if it would clutter the graphic, but an auth example is good to know for users querying their private datasets.
CREATE SECRET hf_token (
   TYPE HUGGINGFACE,
   TOKEN 'your_hf_token'
);

OK. Version A, for huggingface_hub hf:// docs:

neat!

https://github.com/huggingface/hub-docs/pull/1319 and https://github.com/huggingface/huggingface_hub/pull/2358

https://huggingface.co/docs/hub/datasets-duckdb
https://huggingface.co/docs/huggingface_hub/main/en/guides/hf_file_system#integrations


Cleanup NetBeans license header for module web.webkit.debugging

Review and cleanup the license header in web.webkit.debugging
Oracle donated NetBeans to the Apache Software Foundation.
Your task now is to replace the old license header that has Oracle (and/or Sun Microsystems
and/or NetBeans) in it with the standard Apache Software Foundation license header.
For an empty file that supports headers you must add the Apache license header.
Note that you have to use the proper license header for Java, .properties or HTML files.
Look at the nearby files for templates and copy-paste the license header.
When done commit the changes with a commit message that starts with first line
"[NETBEANS-54] Module Review " and a message body describing your review.
See a longer explanation about what we are doing here: https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review
Please announce in a comment when you have started work.
Files that need to be looked at in web.webkit.debugging:
web.webkit.debugging/src/org/netbeans/modules/web/webkit/debugging/api/css/Longhands.txt

Working on

This file currently does not have a license header in it. I can add the Short Form if you think it is needed.

Hm, seems like it should be excluded. Not sure how it's parsed.

Thanks for looking into it, closing.


coracle: internal error, uncaught exception: File "raft/state.ml", line 82, characters 2-7: Pattern matching failed

JSON config is here
http://coracle-test2.cloudapp.net:3000/requests/2015-08-08-21-53-08-9030.json

fixes


Blacklist novellus alone

"Novellus Skin" was blacklisted but it occurs in spam with a lot of other words, like "Novellus Face Cream", "Novellus Naturals", etc.

Uh, sorry, I seem to have crashed into another branch somehow.  I'll submit a separate pull request with just this change.

Codecov Report

Merging #666 into master will increase coverage by 0.21%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
+ Coverage   61.36%   61.58%   +0.21%
==========================================
  Files           5        5
  Lines        1069     1075       +6
==========================================
+ Hits          656      662       +6
  Misses        413      413

Impacted Files
Coverage Δ

findspam.py
81.48% <100%> (+0.32%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee2acaf...b5a2659. Read the comment docs.


0.0.9 install broken

Collecting sacrud-deform>=0.0.8 (from pyramid-sacrud->-r requirements/base.txt (line 14))
  Downloading sacrud_deform-0.0.9.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 20, in <module>
      File "/private/var/folders/bq/31skcq4168v9zcyv364zqpp00000gn/T/pip-build-dIuQ2u/sacrud-deform/setup.py", line 27, in <module>
        tests_require=read('requirements.txt') + read('requirements-test.txt'),
      File "/private/var/folders/bq/31skcq4168v9zcyv364zqpp00000gn/T/pip-build-dIuQ2u/sacrud-deform/setup.py", line 8, in read
        with open(os.path.join(here, name)) as f:
    IOError: [Errno 2] No such file or directory: '/private/var/folders/bq/31skcq4168v9zcyv364zqpp00000gn/T/pip-build-dIuQ2u/sacrud-deform/requirements-test.txt'

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /private/var/folders/bq/31skcq4168v9zcyv364zqpp00000gn/T/pip-build-dIuQ2u/sacrud-deform

Thank you, I fixed it on PyPi.


Support additional search page translations

 Mundo site translations needed

@Shinsina - have you spun up this new version against a site other than Mundo? Just want to confirm the English versions of everything remain unaffected.

@Shinsina - have you spun up this new version against a site other than Mundo? Just want to confirm the English versions of everything remain unaffected.

I had run this against both PackWorld and Automation World as my English Test sites and everything was unaffected. Under the hood the i18n function on the Marko side just falls back to the value passed into it if no translation and/or translation function are provided.

Screenshots from BLP (A site without an i18n function definition):

Screenshots from AW (A site with an i18n function definition but is not translated (remains the same as before)):


Crash in CSS class selector when document contains empty class attributes

CSS class selectors crash if the document contains HTML tags with empty-values class attributes.
Background: I tried to parse a website that turned out to be a text file filled with URLs in angle brackets, of which one contains the word class. The file looks a little like this:
... Lots of stuff here ...

<http://experiment.worldcat.org/entity/work/data/2865052259#Person/cicero_marcus_tullius> <http://schema.org/name> "Marcus Tullius Cicero" .
<http://dewey.info/class/937.05092/e21/> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <http://schema.org/Intangible> .
<http://experiment.worldcat.org/entity/work/data/2865052259#Topic/hommes_d_etat_rome> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <http://schema.org/Intangible> .
<http://experiment.worldcat.org/entity/work/data/2865052259#Topic/hommes_d_etat_rome> <http://schema.org/name> "Hommes d'État--Rome"@fr .

... Lots of more stuff here ...

This is not valid HTML, but it shouldn't crash. The crash happens because of this part:
<http://dewey.info/class/937.05092/e21/>

The issue is reproducible also with valid HTML such as
<foo class>

No matter which class selector I use or whether it matches any element or not, I get a segfault with the following code:
int main(void) {
    static const lxb_char_t html[] = "<http://dewey.info/class/937.05092/e21/> ";     // Crash
//    static const lxb_char_t html[] = "<foo class>";                                 // Crash
//    static const lxb_char_t html[] = "<foo class='bar'>";                           // Works

    lxb_html_document_t* html_document = lxb_html_document_create();
    lxb_html_document_parse(html_document, html, sizeof(html) - 1);
    lxb_dom_document_t* document = &html_document->dom_document;

    lxb_css_parser_t* css_parser = lxb_css_parser_create();
    lxb_css_parser_init(css_parser, NULL, NULL);

    lxb_css_selectors_t* css_selectors = lxb_css_selectors_create();
    lxb_css_selectors_init(css_selectors, 32);
    lxb_css_parser_selectors_set(css_parser, css_selectors);

    lxb_selectors_t* selectors = lxb_selectors_create();
    lxb_selectors_init(selectors);

    static const lxb_char_t selector[] = ".class-selector";
    lxb_css_selector_list_t* sel_list = lxb_css_selectors_parse(css_parser, selector, sizeof(selector));

    // SEGFAULT HERE
    lxb_selectors_find(selectors, lxb_dom_interface_node(document), sel_list, (lxb_selectors_cb_f)css_cb, NULL);

    return 0;
}

This may already be fixed with your CSS rework, but it is reproducible on the master branch at least.

Any new on this or the release?

Ping. Any idea what may be wrong? This literally prevents me from using an CSS class selectors whatsoever.

@phoerious
A thousand apologies for not answering for a long time.
I will fix this bug in the near future.
Thanks for the report!

I've had more crashes and they can all be traced back to this bug. The error isn't limited to CSS selectors, but can be reproduced with lxb_dom_elements_by_class_name() and, more generally, with lxb_dom_elements_by_attr() as well. Any null-valued attribute will crash Lexbor.
Here's a minimal Resiliparse example:
from resiliparse.parse.html import HTMLTree

tree = HTMLTree.parse('<div role></div>')
print(tree.body.get_elements_by_attr('role', 'main'))

Process finished with exit code -1073741819 (0xC0000005)

Here's the internal implementation, which simply uses lxb_dom_elements_by_attr(): https://github.com/chatnoir-eu/chatnoir-resiliparse/blob/develop/resiliparse/resiliparse/parse/html.pyx#L231

FYI: I have a PR in progress that will fix this issue.


A minor correction on simplescheduler.go

hi @jiwq
Thanks for the PR. Could you pls follow instructions in https://github.com/cloudera/yunikorn-core/blob/master/docs/how-to-contribute.md to send us ICLA? Otherwise, we cannot accept your contribution.
Thanks!

@yangwwei Thanks for your help. I had signed the ICLA and submitted to<EMAIL_ADDRESS>

Thank you. Our legal will notify us once they received the ICLA.
BTW, the change is fine, we can merge once we got the notification.

LGTM, merging this now.


[OCaml] Idempotency errors on PPX tags in records' last field

As of 73f3995, which in particular is after #223 which closes #220, the following:
type t =
  { foo : bool;
    bar : float [@default false] [@key "baaar"] }

yields an idempotency check failure caused by a parsing error in the second round. With --skip-idempotency, the result is
type t = {
  foo: bool;
  bar: float [@default false]; [@key "baaar"];
}

This does not happen when the last field is also terminated by a semi-colon. For instance
type t =
  { foo : bool;
    bar : float [@default false] [@key "baaar"]; }

is formatted just fine.

Ah, so
(
  (field_declaration)
  .
  (attribute)+ @append_delimiter
  .
  ";"* @do_nothing
  (#delimiter! ";")
)

appends a delimiter after each attribute, not the group as a whole. Well, TIL.

Yep 😄
(I should have caught that in review.)


sendMessageLocation

Hello,
thank you for your work. But I need a function that is not implemented until now:
sendMessageLocation($to, $long, $lat, $name = null, $url = null)

is not implemented
Here is my code. It works but I am not sure if it is correct
        public void sendMessageLocation(string to, double g_long, double g_lat, string name = null, string url = null)
        {
            var tmpMessage = new FMessage(GetJID(to), true) {longitude=g_long, latitude = g_lat, media_wa_type = FMessage.Type.Location, location_details = name, location_url = url };
            this.SendMessage(tmpMessage, this.hidden);
        }

@ffwblueshadow please quote code properly next time
Test it, and if it works, send a pull request.
Regards


Is there a way to align the text from an insert node inside a block?

Hi @L3MON4D3 !
First of all, thanks for this amazing plugin!
I am trying to achieve the following effect:

Type a string to trigger a snippet.
Get the user input in an insert node.
Add a text node with the following format:

############################################################################################
#                                  This is the user input                                  #
############################################################################################

I can easily do this using an insert node and a dynamic node. The problem is that when the snippet expansion is finished, the text in the insert mode remains on the buffer, leading to:
This is the user input
############################################################################################
#                                  This is the user input                                  #
############################################################################################

Is there any way to remove this node after the expansion is finished?

Hey!
Oh, exactly how you want it is hard to achieve :/
Have you considered letting the user type into the box directly? (which is much simpler, check this example
If you set your update_events (check DOC.md) to TextChangedI, the box-characters will even update immediately :)

@L3MON4D3
Adding the range of text rendered to the leave event of the snippet should make this doable. Another user case will be to implement something like this with luasnip:
https://github.com/jceb/emmet.snippets#usage

Hi @L3MON4D3 and @leiserfg
Thanks!

Have you considered letting the user type into the box directly?

This behavior is waaaay better :D

@L3MON4D3 Adding the range of text rendered to the leave event of the snippet should make this doable. Another user case will be to implement something like this with luasnip: https://github.com/jceb/emmet.snippets#usage

Oh right, yeah that would produce the exact behavior
That emmet-stuff is really cool, and almost easily implemented via dynamicNode, the only annoying bit is removing the text of the insertNode.

This behavior is waaaay better :D

Was kind of hoping for that :D
Happy it works for you :)

Just for the reference, I am using this snipper:
--- Return the comment box line considering the string `str`.
function M.comment_box_line(str)
  local cur_pos   = vim.api.nvim_win_get_cursor(0)
  local str_width = vim.fn.strdisplaywidth(str)
  local tw        = vim.o.textwidth

  local ind = vim.fn.indent(cur_pos[1])
  local cbw = tw - ind

  if ((cbw >= 0) and (str_width < cbw - 4)) then
    return string.rep("#", cbw)
  else
    return string.rep("#", str_width + 4)
  end
end

--- Return the left padding of the comment box text line considering the string `str`.
function M.comment_box_left_padding(str)
  local cur_pos   = vim.api.nvim_win_get_cursor(0)
  local str_width = vim.fn.strdisplaywidth(str)
  local tw        = vim.o.textwidth

  local ind = vim.fn.indent(cur_pos[1])
  local cbw = tw - ind

  if ((cbw >= 0) and (str_width < cbw - 4)) then
    local lpad = math.floor((cbw - 2 - str_width) / 2)
    local lstr = string.rep(" ", lpad)

    return "#" .. lstr
  else
    return "# "
  end
end

--- Return the right padding of the comment box text line considering the string `str`.
function M.comment_box_right_padding(str)
  local tw        = vim.o.textwidth
  local str_width = vim.fn.strdisplaywidth(str)
  local cur_pos   = vim.api.nvim_win_get_cursor(0)

  local ind = vim.fn.indent(cur_pos[1])
  local cbw = tw - ind

  if ((cbw >= 0) and (str_width < cbw - 4)) then
    local lpad = math.floor((cbw - 2 - str_width) / 2)
    local rpad = cbw - 2 - str_width - lpad

    local rstr = string.rep(" ", rpad)

    return rstr .. "#"
  else
    return " #"
  end
end

...

      ls.snippet({
        trig = "jlcblk",
        dscr = "Julia Comment Block",
        docstring = {
          "###############################",
          "#            Comment          #",
          "###############################",
        },
      }, {
          ls.function_node(function (args)
            return M.comment_box_line(args[1][1])
          end, { 1 }),
          ls.text_node({ "", ""}),
          ls.function_node(function (args)
            return M.comment_box_left_padding(args[1][1])
          end, { 1 }),
          ls.insert_node(1, "Box"),
          ls.function_node(function (args)
            return M.comment_box_right_padding(args[1][1])
          end, { 1 }),
          ls.text_node({ "", ""}),
          ls.function_node(function (args)
            return M.comment_box_line(args[1][1])
          end, { 1 }),
        }),

...

leading to this amazing effect:
https://github.com/L3MON4D3/LuaSnip/assets/1068295/5bc8d9db-8392-411a-b06f-36310a1c129b
It even works inside a function where the indentation is higher than 0 :)
Thanks @L3MON4D3 ! Every day I am positively surprised by how configurable LuaSnip is :)


Allow emphasizing portion of values

What problem does this feature solve?
I am implementing a charting framework that should support interactivity between charts. For example, if a user selects (clicks) a specific value on a bar chart, the action should result in that value being emphasized, and any other chart on a dashboard that relies on a series that is itself based on the selected value (though the value might be groupped/displayed differently), should empahsise the corresponding portion of the series.
The image below shows two charts, a bar chart and a pie chart, that both rely on a series of values. The bar charts displays the values stacked by category against months, the pie chart sums the categories and shows a percentage total.

Selecting a specific value on the bar chart should emphasize that bar component, as well as emphasize the corresponding portion of the series on the pie.

This should work when multiple values are selected also, as shown below.

Note: It sholud work analogously on a bar chart.
Edit: I'm not expecting echarts to support this kind of interactivity out of the box, but IMO it would be desirable to allow highlighting/emphasizing a portion of values to allow the implemention of it.
What does the proposed API look like?
let options = {
  ...
  series: [
    {
      data: [100, 50, 50],
      emphasizedData: [15, 0, 0], // New: This is the data that will be emphasized against the original data above
    }
  ]
}

That's Microsoft's Power BI.
I consider echarts one of the best (if not the best) charting libraries available. Keen to help bring that feature to life, if there's interest. I just fear that it would be too big an intervention and before I get my hands dirty, I'd like to hear from someone from the core maintainers regarding the direction of my idea and align on a reasonable api.


[#6018] Move Dotnet generators from Samples to "generators" - Delete VSIX projects

Addresses # 6018
Description
This PR deletes the generators/vsix-vs-win folder as it was moved to the BotBuilder-dotnet repository.
Detailed Changes

Deleted generators/vsix-vs-win folder with all its files and projects.

Testing
These images show the before and after of the generators folder.

Promoted to MS in PR# 3624


How to adopt Guided Anchoring in Fast R-CNN?

Thank you for sharing such an amazing model. I successfully trained Faster R-CNN with own dataset in less training time. And I got good results.
I am confused about how to adopt Guided Anchoring in Fast R-CNN. I mean, in Faster R-CNN we will set a lot of fixed anchor boxes. But in Fast R-CNN we use selective search to get our proposals. And we did not use anchor boxes in Fast R-CNN. So, I don't know how to use Guided Anchoring in Fast R-CNN to improve mAP.
Could anyone help me, please? Not sure if it is suitable for asking here. If not, please let me know. I will close this issue.
Thanks!

You may train a GA-RPN model on your own dataset and extract the proposals.
You need to change the proposal_file parameter in the GA-FastRCNN config to your proposal file.
Train this GA-FastRCNN config.
The performance gain comes from high-quality proposals provided by GA-RPN

I see. Thank you for your kind reply.
I will try to train GA-FastRCNN followed by your instructions.


consolidate guidance on avoiding full scans; update session vars

DOC-9629

Added a section to SQL Performance Best Practices that summarizes how to prevent the optimizer from planning full scans. Preview
This also consolidates existing guidance across the docs into several includes.
Updated descriptions of the disallow_full_table_scans and large_full_scan_rows settings (for the past 3 docs versions) as it looked like the behavior of these settings was updated in https://github.com/cockroachdb/cockroach/pull/71317 but this wasn't documented.

This looks great, thanks! Sorry for the delay.
There was another support issue where the customer was tuning their queries and was concerned that the EXPLAIN output showed some full table scans. However, this was expected since the customer was testing with empty tables, and therefore the stats did not represent the production environment.
Do you think it makes sense to update this section of the docs to mention that most of the time the optimizer makes the right decision, and if you see a full scan you should (a) make sure that it's actually causing a performance problem, and (b) confirm that the optimizer would actually choose a full scan in the production environment (with correct stats, cluster topology, etc)? Only then should a customer try to use one of these tools to override the optimizer's decision.
If you think that should be a different PR, I'm happy to file a separate docs issue. Let me know what you think. Thanks!

TFTR @rytaft! I had a follow-up question (above).
I do think that a separate docs issue with some more details would make sense for the other recommendations you describe.

This looks great, thanks! Sorry for the delay.
There was another support issue where the customer was tuning their queries and was concerned that the EXPLAIN output showed some full table scans. However, this was expected since the customer was testing with empty tables, and therefore the stats did not represent the production environment.
Do you think it makes sense to update this section of the docs to mention that most of the time the optimizer makes the right decision, and if you see a full scan you should (a) make sure that it's actually causing a performance problem, and (b) confirm that the optimizer would actually choose a full scan in the production environment (with correct stats, cluster topology, etc)? Only then should a customer try to use one of these tools to override the optimizer's decision.
If you think that should be a different PR, I'm happy to file a separate docs issue. Let me know what you think. Thanks!

TFTR @rytaft! I had a follow-up question (above).
I do think that a separate docs issue with some more details would make sense for the other recommendations you describe.

Done: #18428


List commit doesn’t respect ancestry syntax

What happened?:
List commit doesn’t respect ancestry syntax
$ pachctl list commit data
REPO BRANCH COMMIT                           FINISHED       SIZE ORIGIN DESCRIPTION
data master 55589fe63b3b46b19d4e8362a24e6d60 3 seconds ago  364B USER
data master 2b8b243b5a654985a1ef6d22c6f6af72 8 seconds ago  0B   USER
data master 619517fbf86f42a7a70c708679b89673 14 seconds ago 364B USER

When you reference the previous commit, it still returns the same output.
$ pachctl list commit data@master^
REPO BRANCH COMMIT                           FINISHED       SIZE ORIGIN DESCRIPTION
data master 55589fe63b3b46b19d4e8362a24e6d60 3 seconds ago  364B USER
data master 2b8b243b5a654985a1ef6d22c6f6af72 8 seconds ago  0B   USER
data master 619517fbf86f42a7a70c708679b89673 14 seconds ago 364B USER

What you expected to happen?:
It should return the commits list for the commit referenced.
How to reproduce it (as minimally and precisely as possible)?:
pachctl create repo data
touch file.txt
pachctl put file data@master -f file.txt
pachctl delete file data@master:/file.txt
pachctl put file data@master -f file.txt
pachctl list commit data@master
pachctl list commit data@master^

Environment?:
Pachyderm Hub
COMPONENT           VERSION
pachctl             2.0.0-beta.5
pachd               2.0.0-beta.5

AB#110

What do you expect the output of this command to be? It seems like you want to use the --from flag, as the help text doesn't list pachctl list commit <fully-specified-commit>  as an option, just pachctl list commit <branch> and pachctl list commit <commit-id>.

I believe that's correct. I would expect the ID to resolve to the commit ID before passing it to the command. Otherwise we end up with some pretty gnarly pipe commands for examples.
The behavior in 1.12.5 is:
$ pachctl list commit data
REPO BRANCH COMMIT                           FINISHED       SIZE ORIGIN DESCRIPTION
data master 55589fe63b3b46b19d4e8362a24e6d60 3 seconds ago  364B USER
data master 2b8b243b5a654985a1ef6d22c6f6af72 8 seconds ago  0B   USER
data master 619517fbf86f42a7a70c708679b89673 14 seconds ago 364B USER

And for the ancestry syntax it's:
$ pachctl list commit data@master^
REPO BRANCH COMMIT                           FINISHED       SIZE PROGRESS DESCRIPTION
data master 44e71eeb040e4453a13014c22c9a80ed 17 minutes ago 0B   -
data master 4670ab8ce78e4306a5789144f30b4afd 21 minutes ago 364B -

This is the same if I use any form of data<EMAIL_ADDRESS>

Ahh, I see, the actual change is that we're expecting a branch and then creating a commit. In 1.x this was all done with strings so the distinction wasn't important. It seems like we should just make this take a commit and everything should match the previous behavior.

The linked PR (#6785) restores the functionality in 1.x, which might not quite match what you're requesting here.


activity_id - add DCPP to Earth3-CC

The EC-Earth consortium (institution_id is EC-Earth-Consortium) kindly asks for the following changes in the CMIP6_CV.json:
Please add for EC-Earth3-CC another activity_participation: DCPP
Thanks a lot,
Thomas
(tagging also @shutingdk)

Sorry, this is a duplicate to #1063.

Closing this issue because it is a duplicate of https://github.com/WCRP-CMIP/CMIP6_CVs/issues/1063.


Fix initializing mentat with a --diff argument

Crashing currently if you run e.g. mentat --diff HEAD~1

Oops. Should have checked if anyone else had a PR before making mine.

Thanks for catching this @granawkins, sorry it took a couple days to review!


Is there a way to get around the MSFT_texture_dds not available with this addon?

Current Behavior
Whenever I use the addon and I try to import a file (787-10) it says MSFT_texture_dds not available with this addon. I do not care about the textures. I JUST WANT THE MODEL. I don't want a fix to make it import textures, I just want the model. That's all I care about.
Expected Behavior
Import 3D gltf model
Steps To Reproduce
Install addon as per instructions
Enable addon
Choose File / Import / gltf
Choose gltf file, Import fails (even the stock c152 LOD0 fails)
Environment
- OS: Windows 11
- Blender: 3.4
- glTF-Blender-IO-MSFS: 1.3.1

Anything else?
No response

This Addon does not allow for imports.  Documentation and here states it does not import models of any kind.

Hello,
This plugin cannot import glTF files that have been built into a Microsoft Flight Simulator package through the Sim's Package Builder. You can import only gltf that has been exported by this Blender exporter or the 3dsmax flightsim exporter.
Thank you for your report

This Addon does not allow for imports. Documentation and here states: it does not import models of any kind.

Just wanted to ask if there's a way to actually import the glTF files that have been built into a MSFS package in Blender?

Hello !
⚠ This plugin cannot import glTF files that have been built into a Microsoft Flight Simulator package through the Sim's Package Builder.

This Addon does not allow for imports. Documentation and here states: it does not import models of any kind.

Just wanted to ask if there's a way to actually import the glTF files that have been built into a MSFS package in Blender?

⚠ This plugin cannot import glTF files that have been built into a Microsoft Flight Simulator package through the Sim's Package Builder.

Sure @y-khodja
I saw your previous comment.
I was asking for different packages & solutions; If anyone would know any...
I actually found one:
https://github.com/bestdani/msfs2blend/releases/tag/v0.4
and it worked for me.

⚠ This plugin cannot import glTF files that have been built into a Microsoft Flight Simulator package through the Sim's Package Builder.

Sure @y-khodja I had seen your previous comment.
I was asking for different packages & solutions; If anyone would know any...
I actually found one: https://github.com/bestdani/msfs2blend/releases/tag/v0.4 and it worked for me.

As far as i know, this one works fine. I don't know any other tool that has been updated since.


Adding Functionality to HTML using JS

Problem
I've made a number of sections using HTML & Liquid but now I'm looking to add dynamic functionality to those sections and snippets. At the moment, it seems my only option is Javascript but the wiring between Javascript and HTML with Shopify is extremely unclear to me.
At the moment, I'm just trying to implement some simple scroll, CSS changes alongside some jQuery onClick triggers but I can't seem to link it all together.
I've attempted to use section-js but I keep getting an error saying sections.register is not a function
I feel that what I am doing right now is wrong but I'm not keen on using inline javascript .i.e. <script> or {% javascript %} as I'd much rather have it in separate files as it should be.
I would like for this topic to be explained to me so I can continue developing my themes!
More Information
I think it would be good to include a sample of this in the documentation as for developers such as me, we could save tremendous amounts of time.

Might this be raised on Stack Overflow instead?

I think what i was aiming was clearer documentation on this topic as it would help alot of people

As you mentioned, @shopify/theme-sections lives inside the https://github.com/Shopify/theme-scripts repo. Please keep issues in their respectively repos.
As for the sections.register is not a function, this sounds like a general Theme development/ JS development problem and not something specific to Slate.


Define Attribute Data for Shapefile Export

[ ] Define attribute data for shapefiles (similar to BCGW data export) and re-implement for public and internal users
[ ] Re-implement ability to export shapefiles

Most of the work required will be in defining the attributes by the business. At this point it might be a similar process to adding help text. If this was completed at the same time as the help text update, the development effort may be shared between this and the help text issue.

@bferguso I've updated the ticket to include the attributes and their names. Can you please instruct how you would like this to be updated? In Test or Prod? Should this be done before our other updates this release?

@emjohnst  - Can we leave this issue to be part of the 7.6.0 Arches Core release?

@bferguso we are really hoping to get this functionality soon, what is the reason for waiting for the release?

Some of these settings may be able to be updated directly in the database. Need to figure out how we log those changes, and how to keep the resource models and the database in sync if we do a stright DB update.

@bferguso I'm noticing the CSV export for Internal Users in Test is different than the CSV export for Internal Users in Delivery. Are these different because of the changes I applied to define the shapefile export or were the environments different before? Excels attached below
Heritage Site Delivery Internal User.csv
Heritage Site Test Internal User.csv

@emjohnst - The custom CSV export for Heritage Site is only configured to be used by anonymous users, so internal CSV export of Heritage Site resources is driven by the Export via Search Results switch you've been updating.
I believe the original CSV export requirement was for internal users to have a larger set of fields than anonymous users which is why the custom export is only implemented for anonymous users.

Updated the JSON file using the extracted Resource Model from DLVR. Created a script to update the database NODES table with the values in DLVR, using the current TEST state for rollback values (which matches PROD).
Enabled the Shapefile export option in the Export Search Results page. NB - still have the Tile Excel and GeoJSON URL export options commented out.

Updated the CSV export for internal (authenticated) users so that all of the Heritage Site attributes are exported.

@bferguso Internal CSV is not exporting on all Heritage Site attributes, can you try again? Shapefile is working - I've realized it would probably best to flatten the data like how we send it out to DataBC because the shapefiles with multiple data points under the attributes is difficult to read - I will make a new ticket for this to address later as the functionality is fine as is.

I just tried TEST and it seems like they're all exporting. Can you please tell me which fields are missing?

@bferguso There are 41 attributes missing
CSVINTERNALPRODTEST.xlsx


System IO exception, when launching

After installation. Can't get it to work.
Before, it sais can't find the TQ vault path, and loading up defualt one, but well.. it's not

3.8.0 works just fine. Glad i made a backup lol


Build and push Docker image

Hello,
I get this PR was open by mistake but I checked out what you did and I noticed two things.

You are using the jar for keycloak 25 while using Keycloak 24: https://github.com/african-pathogen-archive/keycloak-themes/blob/2466bf96506a16034c09f54e81ccdee333a5db8e/Dockerfile#L13, you should use keycloak-theme-for-kc-24.jar.
You might want to build only the jar for keycloak 24: https://docs.keycloakify.dev/targetting-specific-keycloak-versions
For devlopement puposes you cans spin a test Docker container with npx keycloakify start-keycloak you don't need to setup your local Dockerfile: https://docs.keycloakify.dev/testing-your-theme/in-a-keycloak-docker-container

Hope it helps


workaround -Wassign-enum warnings

There are a number of cases where we use 0 or macro definitions for
values to enumerated types.  When building for Windows, these cause a
warning due to the value not being part of the enumeration.  This change
silences the warnings and identifies the various places where this
occurs.  Ideally, the values would be part of the enumerations.

@das @MadCoder I don't know of a better way to deal with these.  If you have a suggestion on how to handle this better, I'd love to hear about it.

I dislike this patch strongly, enums have been used for "flags" for times imemorial, clang has to provide a way to make it clear that's what we're doing. I'd rather disable -Wassign-enum that clutter the code with this

The problem isn't that the enum is being used for flags, but rather than there are values being used that are not in that enumeration.  It just wants the rest of the flags to be part of the enumeration.

we should disable the warning, I don't understand what value it adds

Sure, I don't have a complaint against that.  I'm not sure that this would add much value.  I'll upload a different change.


Allow to define a custom tag for the modal container?

It would be super handy to be able to define a custom tag for the modal container element. So that I can set it as:
<ReactModal tag="form">

This would make easy to manage modals used as forms.

Hi @FezVrasta, yeah, it's convenient, but maybe it's not a good idea give to react-modal this responsibility. A snippet like this (below) should be "the best" approach:
<Modal ...>
   <MyForm {...props} /> {/* -> <form ....>....</form> */}
</Modal>

This way you can use MyForm on other places.

But then you get the focus on the modal that's different from the form element 🤔 wouldn't this be a problem?

@FezVrasta hmm, this is something we need to find a solution. There is onAfterOpen, you can use this callback to move the focus to you component.
Of course, ideas/suggestions are welcome.


run tests against node-fetch@3 beta

Coverage remained the same at 96.346% when pulling 152387294c1ff88f06ac96cb6d89143a08f1edd7 on node-fetch-3 into 3d10a0e43f667e7259e9fe77c3486bd3cea8378f on master.


Introduction to LXD Container Manager

Proposed title of article
Introduction to LXD Container Manager
Introduction paragraph(s):
LXD is a next-generation system container manager. It uses Linux containers to provide individuals with a unique experience.  LXD is image-based and supported by numerous Linux distributions. Furthermore, it is powerful, intuitive, and scalable. The LXD project was founded and is currently led by Canonical Ltd with contributions from other developers.
LXD's key features include advanced resource control, network management, storage management, device passthrough, and support for cross-host containers. This article provides a detailed overview of LXD technology.
Key takeaways:

Understand what LXD entails
Key features of LXD
Benefits of LXD
LXD's releases.

References:
N/A

Thank you for the topic suggestion @domiwanja. Could you please expand upon how your content will differ from what is already available through the LXD website and documentation? We lean towards content that offers an original viewpoint/approach around programming-centric topics.

I will provide a step by step guide  on how to use LXD container manager.

@ninjaginja can I go ahead and write about the topic?

@domiwanja
👍  a step by step guide is always welcome - it may be more appealing to the community if it was used in a real use case along with your guide.
topic approved.


tegra-minimal-initramfs: Bind DTB/DTBO extra dependencies via DTB_EXT…

…RA_DEPS
When installing new DTBOs with OVERLAY_DTB_FILE:append = ",some-overlay.dtbo", you will find that do_image_tegraflash sorts intertasks dependencies with do_image_tegraflash[depends] += "${DTB_EXTRA_DEPS}". This is not the case with tegra-minimal-initramfs, and it actually collects the DTBOs into OVERLAY_DTB_FILE the same way as do_image_tegraflash does. With this dependency definition we tell it to wait for a given dependency's do_deploy definition. User will do DTB_EXTRA_DEPS:append = " some-overlay-recipe:do_deploy" so it works sucessfully.
Signed-off-by: Daniel Chaves<EMAIL_ADDRESS>

Can you describe the problem you're seeing a bit more?  For the initramfs recipe, the overlays in OVERLAY_DTB_FILE should only be getting applied during BUP generation, and the DTB_EXTRA_DEPS variable is already present in CONVERSION_DEPENDS_bup_payload to handle that case.

The tegra-minimal-initramfs' do_image_cpio task failed to find a DTBO that comes from a different provider other than the Kernel (another recipe). Added the mentioned definitions to resolve:
@ .conf
DTB_EXTRA_DEPS:append = " some-overlay-recipe:do_deploy"

@ tegra-minimal-initramfs.bbappend
do_rootfs[depends] += " ${DTB_EXTRA_DEPS}"

But testing again it seems that DTB_EXTRA_DEPS:append = " some-overlay-recipe:do_deploy" it's actually enough.

@dchvs That means the addition you proposed here is not needed, right?

Yes correct, please close the PR.


suah.dev/protect no-op under Linux?

Just to clarify things, suah.dev/protect is a no-op under Linux?
Is it expected?

I see, thank you, would have been nice to have this also in Linux :)


Keep gtk::DialogExt::run() as async variant

When looking at my usage of dialog.run() I decided to just implement an async run().
The only solution I see is to connect to the "response" event and send the result through a channel. But I can also check how gtk3 implemented this.
Any thoughts?

Dialog::run() should also really be removed from the GTK3 bindings. A recursive mainloop is only causing problems, and I think we also moved away all examples from run() to using the response signal.
So yes, using the response would the right approach :) And wrapping an async fn around that with a oneshot channel would be even nicer usability-wise, I guess.

Dialog::run() should also really be removed from the GTK3 bindings. A recursive mainloop is only causing problems, and I think we also moved away all examples from run() to using the response signal.
So yes, using the response would the right approach :) And wrapping an async fn around that with a oneshot channel would be even nicer usability-wise, I guess.

I think what I want is completely impossible. In the end awaiting the future will always be blocking, because it is not Send.

I think what I want is completely impossible. In the end awaiting the future will always be blocking, because it is not Send.

The thread can continue doing other things in the meantime

The thread can continue doing other things in the meantime

This is a minimal example of my problem. Maybe glib::MainContext::default().spawn_local() is the wrong approach. But I don't see any other way this could be done.
    async fn recv_future() {
        // omitted gtk code which makes this none Send

        // create a fake channel
        let (_tx, rx) = std::sync::mpsc::channel::<()>();
        let _result = rx.recv();
    }

    // only function that I know of that can spawn recv_future
    glib::MainContext::default().spawn_local(recv_future());

(I also have a complete implementation, which also can only be spawned via spawn_local)
#[async_trait(?Send)]
pub trait DialogExtFuture {
    async fn run_future(&self) -> gtk::ResponseType;
}

#[async_trait(?Send)]
impl DialogExtFuture for gtk::Dialog {
    async fn run_future(&self) -> gtk::ResponseType {
        let (sender, receiver) = std::sync::mpsc::channel();
        let response_handler = self.connect_response(move |_, response_type| {
            let _result = sender.send(response_type);
        });

        self.set_modal(true);
        self.show();

        let result = receiver.recv().unwrap_or(gtk::ResponseType::None);
        self.disconnect(response_handler);

        result
    }
}

This is a minimal example of my problem. Maybe glib::MainContext::default().spawn_local() is the wrong approach. But I don't see any other way this could be done.
    async fn recv_future() {
        // omitted gtk code which makes this none Send

        // create a fake channel
        let (_tx, rx) = std::sync::mpsc::channel::<()>();
        let _result = rx.recv();
    }

    // only function that I know of that can spawn recv_future
    glib::MainContext::default().spawn_local(recv_future());

(I also have a complete implementation, which also can only be spawned via spawn_local)
#[async_trait(?Send)]
pub trait DialogExtFuture {
    async fn run_future(&self) -> gtk::ResponseType;
}

#[async_trait(?Send)]
impl DialogExtFuture for gtk::Dialog {
    async fn run_future(&self) -> gtk::ResponseType {
        let (sender, receiver) = std::sync::mpsc::channel();
        let response_handler = self.connect_response(move |_, response_type| {
            let _result = sender.send(response_type);
        });

        self.set_modal(true);
        self.show();

        let result = receiver.recv().unwrap_or(gtk::ResponseType::None);
        self.disconnect(response_handler);

        result
    }
}

That channel is not async but will block on recv(). You need this one and then recv.await for getting the value out of the channel.

That channel is not async but will block on recv(). You need this one and then recv.await for getting the value out of the channel.


forgot to reinstate an index incr

@bob, plz -- THIS is the correcterest one.

Wrong Bob, @Bobfrat


Add remix-params-helper package

This adds a helper package that makes it simple to use Zod with standard URLSearchParams and FormData which are typically used in Remix apps.

Sorry. I should have aware of the PR earlier. It should be up in the site in a few minutes.

Thanks!


Java packages: Use callPackages

Issue description
In order to make derivations inside the javaPackages overridable, the entry in all-packages.nix should be callPackages, not callPackage.
See #20444 for more details.

What about the following interface:
{ fetchMaven }:
let
    artifactId = "commons-cli";
    groupId = "commons-cli";

in {
  commonsCli_1_0 = buildFetchMavenPackage rec {
    version = "1.0";
    inherit artifactId groupId;
    pom.sha512 = 1pm5ba95viabcgpjhsqw21iwis9ajn8hwpyc6rzs9frr5k62hs7lj8darxmmp21hf14mxrs37a8swayhagq6i6g8js4nl4r8mmwjlvp;
    jar.sha512 = 0ybdbpfzadkncwcmnzkscbp2fhmcsqmpy60qppz7s8hs00hgqy64jr4qpdyz5bj0l4bc434vn0pv4gzxzi7y1lhh7b2rk4zv1mgs3ff;
  };
  commonsCli_1_2 = buildFetchMavenPackage rec {
    version = "1.2";
    inherit artifactId groupId;
    pom.sha512 = 3lrjnrkq0vq1mjp1z6zbi6x0x45hj20yvs74aqnpzayd0prwv22hyfyadgrj343is54s6m2p5mx2kpziqz9wcih5hmwg5f80ni8mxp7;
    jar.sha512 = 2mdzpng0cybpnw5dw1q4dmpn2i89zhg13m8xjv8pdbn5q28zsf8m3m7w0y8irbjyplwrfdrxipkxxvnz5f61bxi4s85hnm0sc84d3qb;
  };
}

jar and pom should be created as multiple outputs.

Are there any updates to this issue, please?

still important to moi


Added definitions to match the Makecode effects parameters

As per the title, just a set of definitions for downstream languages to use.

Yes, this should work for MicroPython.

Added to MakeCode in:

https://github.com/microsoft/pxt-microbit/pull/5768

Actually, this doesn't work for MicroPython because we use C and can't include a C++ header in C code...


Usage of utf8_encode() in \yii\web\Request::resolvePathInfo() makes Yii depend on the php-xml extension

What steps will reproduce the problem?
Just try to route on something like /test%F2%FB without mentioned extension.
What is the expected result?
Well, 404
What do you get instead?
Ta-daaa, 500
Additional info
https://github.com/yiisoft/yii2/blob/572e5f6655f279df574fe4937406ec04a6852cbc/framework/web/Request.php#L902-L926
It happens because utf8_encode() moved in core only in PHP 7.2.
I was intrigued, so I open https://yiipowered.com, and start to test :)
First catch: https://craftcms.com/test��

Q
A

Yii version
any (catched in 2.0.14)

PHP version
up to 7.1 (catched in 7.1)

Operating system
catched in CentOS 7 with PHP from remi repo

P.S.: Perhaps I did a lot of grammar mistakes in my sentences. Sorry.)

We can instead use something like https://github.com/symfony/polyfill-php72/blob/master/Php72.php#L24

Clear installation. Why don't I get 500?

Clear installation of PHP from package manager?


Arrow function not working on IE11

Hi,
You should change the JS code on the examples page, especially the one showing the use of the 'dismiss' parameter
Indeed, the arrow functions are not supported by IE11, which makes the whole page inoperable on this browser

Hi @Macfly60
The plugin works in IE11, you can ensure that with this jsfiddle: https://jsfiddle.net/ad3quksn/250/
The examples page doesn't work with IE11, the reason is that we want to demonstrate how to use the plugin in a modern way. Read more about the reasoning: https://github.com/limonte/sweetalert2/issues/711#issuecomment-344089223


admin: Use a map for home geography filter instead of textbox

The textbox was the easy way to get the feature in, but the nicer way would be to have a map to draw a polygon directly.
This can be done after #668 if we introduce deck.gl in the mix.

But being able to import a polygon from a file (to have a repeatable filter) would also be desirable, so the filter should be able to support both approaches.