setting default Data Type while setting type in Add Schema dialog

Description
For Dimension, STRING data type is being set by default on the UI dropdown.
For Metric, LONG data type is being set by default.
For DateTime, LONG as datatype, MILLISECONDS EPOCH as unit format, and 1 MILLISECONDS as the Granularity, is being set by default.

Codecov Report

Merging #6452 (28617c2) into master (1beaab5) will decrease coverage by 22.56%.
The diff coverage is 38.51%.

@@             Coverage Diff             @@
##           master    #6452       +/-   ##
===========================================
- Coverage   66.44%   43.88%   -22.57%
===========================================
  Files        1075     1330      +255
  Lines       54773    64932    +10159
  Branches     8168     9470     +1302
===========================================
- Hits        36396    28494     -7902
- Misses      15700    34059    +18359
+ Partials     2677     2379      -298

Flag
Coverage Δ

integration
43.88% <38.51%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ot/broker/broker/AllowAllAccessControlFactory.java
100.00% <ø> (ø)

.../helix/BrokerUserDefinedMessageHandlerFactory.java
52.83% <0.00%> (-13.84%)
:arrow_down:

...org/apache/pinot/broker/queryquota/HitCounter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...che/pinot/broker/queryquota/MaxHitRateTracker.java
0.00% <0.00%> (ø)

...ache/pinot/broker/queryquota/QueryQuotaEntity.java
0.00% <0.00%> (-50.00%)
:arrow_down:

...ker/routing/instanceselector/InstanceSelector.java
100.00% <ø> (ø)

...ceselector/StrictReplicaGroupInstanceSelector.java
0.00% <0.00%> (ø)

...roker/routing/segmentpruner/TimeSegmentPruner.java
0.00% <0.00%> (ø)

...roker/routing/segmentpruner/interval/Interval.java
0.00% <0.00%> (ø)

...r/routing/segmentpruner/interval/IntervalTree.java
0.00% <0.00%> (ø)

... and 1321 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28882ba...28617c2. Read the comment docs.

Codecov Report

Merging #6452 (28617c2) into master (1beaab5) will decrease coverage by 22.56%.
The diff coverage is 38.51%.

@@             Coverage Diff             @@
##           master    #6452       +/-   ##
===========================================
- Coverage   66.44%   43.88%   -22.57%
===========================================
  Files        1075     1330      +255
  Lines       54773    64932    +10159
  Branches     8168     9470     +1302
===========================================
- Hits        36396    28494     -7902
- Misses      15700    34059    +18359
+ Partials     2677     2379      -298

Flag
Coverage Δ

integration
43.88% <38.51%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ot/broker/broker/AllowAllAccessControlFactory.java
100.00% <ø> (ø)

.../helix/BrokerUserDefinedMessageHandlerFactory.java
52.83% <0.00%> (-13.84%)
:arrow_down:

...org/apache/pinot/broker/queryquota/HitCounter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...che/pinot/broker/queryquota/MaxHitRateTracker.java
0.00% <0.00%> (ø)

...ache/pinot/broker/queryquota/QueryQuotaEntity.java
0.00% <0.00%> (-50.00%)
:arrow_down:

...ker/routing/instanceselector/InstanceSelector.java
100.00% <ø> (ø)

...ceselector/StrictReplicaGroupInstanceSelector.java
0.00% <0.00%> (ø)

...roker/routing/segmentpruner/TimeSegmentPruner.java
0.00% <0.00%> (ø)

...roker/routing/segmentpruner/interval/Interval.java
0.00% <0.00%> (ø)

...r/routing/segmentpruner/interval/IntervalTree.java
0.00% <0.00%> (ø)

... and 1321 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28882ba...28617c2. Read the comment docs.


change scrollType to .none, change header (date)

Hi, I have a few questions:

Can I change the scrollType to .none?
How to change header (date) with my custom cell?

Thanks

why do you need scrollType to .none? If you don't want to scroll, you can set the scrollableRangeDate
If you want to change the date, refer to the customView CustomWeekView and HourRowHeader. It's just changing the row header to column header


ruff: 0.6.6 -> 0.6.7

Description of changes
Changelog: https://github.com/astral-sh/ruff/releases/tag/0.6.7

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

 Do you have the sandbox enabled?
error: builder for '/nix/store/46bvqvj54gz21bpvq1mvzsbxpnxr69c0-ruff-0.6.7.drv' failed with exit code 101;
       last 10 log lines:
       > snapshot assertion for 'E902_E902.py' failed in line 300
       > note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
       >
       >
       > failures:
       >     commands::check::test::unreadable_files
       >
       > test result: FAILED. 15 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.27s
       >
       > error: test failed, to rerun pass `-p ruff --lib`
       For full logs, run 'nix log /nix/store/46bvqvj54gz21bpvq1mvzsbxpnxr69c0-ruff-0.6.7.drv'.

system: "aarch64-darwin"
host os: Darwin 24.0.0, macOS 15.0
multi-user?: no
sandbox: yes
version: nix-env (Nix) 2.18.5
channels(n8henrie): ""
channels(root): ""
nixpkgs: /nix/store/iqr1c8jgic7r8l4zrbgs38li3a23hxjr-source

Thanks for the report. I have only access to the nix-community darwin builder and was able to build it twice there.
Not sure why it is failing for you...

I was going to try seeing what the error was locally, but I just built it on my laptop.

I was going to try seeing what the error was locally, but I just built it on my laptop.

Hmm interesting. It could definitely be a sandbox issue.

Huh, no I'm still failing even with sandbox false. I'll keep digging.

Of note, it seems to succeed due to the cached build if I try to run the build step again, but if I run with --rebuild, the test fails again.


Added ForceTorque Python interface

Signed-off-by: ahcorde<EMAIL_ADDRESS>🎉 New feature
This PR is part of this mete ticket https://github.com/ignitionrobotics/sdformat/issues/931
Require

https://github.com/ignitionrobotics/sdformat/pull/969

Summary
Added ForceTorque Python interface
Test it
from sdformat import ForceTorque

ft = ForceTorque()

Checklist

[x] Signed all commits for DCO
[x] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[x] codecheck passed (See contributing)
[x] All tests passed (See test coverage)
[x] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Codecov Report

Merging #983 (8147857) into main (a3560f3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #983   +/-   ##
=======================================
  Coverage   66.66%   66.66%
=======================================
  Files           2        2
  Lines          27       27
=======================================
  Hits           18       18
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3560f3...8147857. Read the comment docs.


Remove duplicated code in logic.cc

Ready for #7143.

Wrote some comments, could you take a look?

Jenkins, test this please.

Jenkins, test this please.

Jenkins CI test (for commit 734a41337056c6e873850a9a4c60fd613f7eda03, target branch master) failed with status FAILURE.

Jenkins, test this please.

Jenkins CI test (for commit 734a41337056c6e873850a9a4c60fd613f7eda03, target branch master) failed with status FAILURE.

Jenkins, test this please.

Jenkins CI test (for commit 05deb2de16f307134bbc5e0a1777a64b826b475f, target branch master) failed with status FAILURE.

Failure seems unrelated, LGTM!


[Feature] Object wrapping send

Hello!
I've just written this in my project to work around the send method being async
#![cfg_attr(feature = "nightly", feature(type_alias_impl_trait))]

#[cfg(not(feature = "nightly"))]
type Quiet = Pin<Box<dyn Future<Output = ()> + 'static + Send>>;

#[cfg(not(feature = "nightly"))]
pin_project! {
    pub struct Sending<T> {
        #[pin]
        inner: Quiet,
        _phantom: PhantomData<T>,
    }
}

#[cfg(not(feature = "nightly"))]
impl<T: 'static + Send> Sending<T> {
    #[allow(unused_must_use)]
    pub fn new(sender: Sender<T>, value: T) -> Sending<T> {
        Sending {
            inner: Box::pin(async move {
                sender.send(value).await;
            }),
            _phantom: PhantomData,
        }
    }
}

#[cfg(feature = "nightly")]
type Quiet<T> = impl Future<Output=()>;

#[allow(unused_must_use)]
#[cfg(feature = "nightly")]
fn quiet<T: 'static + Send>(sender: Sender<T>, value: T) -> Quiet<T> {
    async move { sender.send(value).await; }
}

#[cfg(feature = "nightly")]
pin_project! {
    pub struct Sending<T> {
        #[pin]
        inner: Quiet<T>,
    }
}

#[cfg(feature = "nightly")]
impl<T: 'static + Send> Sending<T> {
    pub fn new(sender: Sender<T>, value: T) -> Sending<T> {
        Sending { inner: quiet(sender, value) }
    }
}

impl<T: 'static + Send> Future for Sending<T> {
    type Output = ();
    fn poll(self: Pin<&mut Self>, ctx: &mut Context) -> Poll<()> {
        let this = self.project();
        Quiet::poll(this.inner, ctx)
    }
}

Is this (or a version that returns the send result, doesn't use nightly and always boxes) something you might be interested in a PR for?

Hmm. So I never needed this feature but I'm curious: why not do the following?
let future = sender.send(value).boxed();

Because it had never occurred to me? :)

:)


Fix typo in CLI message

Thanks, this typo has been fixed, and will be reflected in the next update.


Database errors when running tests

When I run tests I am getting various db errors such as:
(DBConnection.ConnectionError) connection is closed because of an error, disconnect or timeout

MyXQL.Connection (#PID<0.522.0>) disconnected: ** (DBConnection.ConnectionError) owner #PID<0.661.0> exited

Client #PID<0.579.0> is still using a connection from owner at location:

The connection itself was checked out by #PID<0.579.0> at location:

(DBConnection.OwnershipError) cannot find ownership process for #PID<0.579.0>.

When using ownership, you must manage connections in one
of the four ways:
...

From inspecting, I am getting messages after the test has already reported failed and that the process mailbox is empty.
Is there something else I need to do for the test or config for this to work?
Here is my test config
    def start_link(_opts) do
      Broadway.start_link(__MODULE__,
        name: __MODULE__,
        producers: [default: [module: {Broadway.DummyProducer, []}]],
        processors: [
          default: []
        ],
        batchers: [
          default: [ ]
        ]
      )
    end

Looks like you're using Ecto Sandbox, are you using allowances or shared mode?

I think in both cases you would have this error. What is happening is most
likely that the test process, which owns the database connection, is
pushing something to Broadway and then the test terminates, leaving
Broadway without a DB connection. Is this your scenario? If so the solution
is to make sure you assert_receive all messages you push to Broadway during
tests.
Another possible scenario is that your app is putting things on RabbitMQ as
it runs and then Broadway is getting those out of RabbitMQ as it goes. If
this is the case, there are some solutions available. Let us know too.
José Valim
www.plataformatec.com.br
Skype: jv.ptec
Founder and Director of R&D

I don't believe I am running in shared mode as this is in test_helper.ex Ecto.Adapters.SQL.Sandbox.mode(ZB.Repo, :manual). The test is also not running with async.
I push 4 messages and put an inspect on handle message.
ref = Broadway.test_messages(ZB.Integrations.Divvy.Broadway, [..., ..., ..., ...])
assert_receive {:ack, ^ref, [_, _, _, _] = successful, failed}

  def handle_message(_processor_name, message, _context) do
    message
    |> Broadway.Message.update_data(&process_message/1)
    |> IO.inspect()
  end

Only the first message goes through before this and then I see all of the db errors after.
No message matching {:ack, ^ref, [_, _, _, _] = successful, failed} after 100ms.
     The following variables were pinned:
       ref = #Reference<0.952757760.3435921409.190614>
     The process mailbox is empty.
     code: assert_receive {:ack, ^ref, [_, _, _, _] = successful, failed}

So that is rather the root cause: all Broadway processes need to have
access to a connection. You need to share the connection by enabling shared
mode. :)

Actually, ignore me. The original error message says the connection was being shared. If the test is not async, then it is shared by default.
Can you please post the full log for the test run? I am assuming something else is happening before the DBConnection error.

So I did try that, but I get this error no match of right hand side value: {:already, :owner}

Ok looks like it is something happening in this code. If I take it out then the it fixes those errors. Taking out just the transaction didn't do fix it, I had to remove everything.
    ZB.Repo.transaction(fn ->
      account =
        %ZB.Account{}
        |> ZB.Account.changeset(account_params)
        |> Ecto.Changeset.validate_required([:name, :default_bcc_address, :default_currency_code])
        |> ZB.Repo.insert!()
        |> ZB.Repo.preload(primary_location: :page)

      account.primary_location
      |> ZB.Location.changeset(location_params)
      |> ZB.Repo.update!()

      account
    end)

To get around this I created a new simpler changeset specifically for broadway. You can go ahead and close unless you want to look into it more.

Oh, I think I know what is happening. Are you using batches? It can be that
we are waiting for the batch to get full or for the timeout and then we
raise because no message gets in time? This is supposedly fix in a more
recent Broadway version. Not sure if master or it was released. It is
called batch_mode. I will investigate when I am back at the computer.
José Valim
www.plataformatec.com.br
Skype: jv.ptec
Founder and Director of R&D

So something is definitely up because we were supposed to send a Broadway
failure message even if we could not process the messages themselves but
the test says the inbox is empty. Can you increase the timeout in
assert_receive?

Increassing the timeout fixed it.

What is your Broadway version? This should have been fixed on v0.4.0.
José Valimwww.plataformatec.com.br
http://www.plataformatec.com.br/Founder and Director of R&D

  "broadway": {:hex, :broadway, "0.4.0", "b8daf580baed44347a9690449f9d8d7a308c1ca086648397d1a88eea893d047e", [:mix], [{:gen_stage, "~> 0.14", [hex: :gen_stage, repo: "hexpm", optional: false]}], "hexpm"},
  "broadway_sqs": {:hex, :broadway_sqs, "0.3.0", "ddac90ee0ea68573281793623d6dc1129709a832fb2b03effbf596e1f3616cad", [:mix], [{:broadway, "~> 0.4.0", [hex: :broadway, repo: "hexpm", optional: false]}, {:ex_aws_sqs, "~> 3.0", [hex: :ex_aws_sqs, repo: "hexpm", optional: false]}, {:sweet_xml, "~> 0.6", [hex: :sweet_xml, repo: "hexpm", optional: false]}], "hexpm"},

I see. And How much did you increase the timeout? :)
José Valimwww.plataformatec.com.br
http://www.plataformatec.com.br/Founder and Director of R&D

I increased it to 200

Oh, ok. So everything is working as expected, it was just a low timeout. We
will improve the docs to let people aware of it. Thanks for replying
promptly!
José Valimwww.plataformatec.com.br
http://www.plataformatec.com.br/Founder and Director of R&D


Pin participant

So this is the initial raw version of "pin participant" feature.
It includes all the code from https://github.com/jitsi/jitsi-meet-react/pull/22, so the number of changed files is really big.
While it's not yet complete (e.g. selecting a local participant doesn't work for now), it can be started to be reviewed.
Code follows the new feature-based structure and introduces two new "features" - filmStrip and largeVideo. Also it has a huge refactoring of "participants" and "tracks" Redux states, which are now in "features/base/participants" and "features/base/tracks" state tree leaves respectively.
Also PR has some work on refactoring Video component for web to prevent multiple re-rendering.

I'm closing this PR on behalf of @legastero who said that he rebased this PR into https://github.com/jitsi/jitsi-meet-react/pull/26 .


gradlew.bat error firebase

I have issues with a classpath com.google.gms:google-services:4.3.0.
When I added it to the dependencies in android/build.gradle to get the Firebase Authentication and Google Sign-in working, this classpath started to tell me some things are deprecated and returned the error below:
* Error running Gradle:
ProcessException: Process "C:\Users\QSERVERS\Desktop\FlutterApps\FlutterGrocery-ShoppingAppUI\android\gradlew.bat" exited abnormally:

FAILURE: Build failed with an exception.

* Where:
Build file 'C:\Users\QSERVERS\Desktop\FlutterApps\FlutterGrocery-ShoppingAppUI\android\app\build.gradle' line: 24

* What went wrong:
A problem occurred evaluating project ':app'.
> ASCII

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 52s
  Command: C:\Users\QSERVERS\Desktop\FlutterApps\FlutterGrocery-ShoppingAppUI\android\gradlew.bat app:properties

Finished with error: Please review your Gradle project setup in the android/ folder.

Hello @tejasbs44 !
Thank you for posting an issue.
Seems like this problem has been reported already here: #38163. The solution was also found: https://github.com/flutter/flutter/issues/38163#issuecomment-520429066
Lowering the google-services version from the 4.3.0 to 4.2.0 should help.
Closing this issue. If proposed solution won't work for you, please, feel free to open a new issue.
Thank you.

@tejasbs44
This issue has been moved to https://github.com/FirebaseExtended/flutterfire/issues/328. Any further collaboration will be done there.

Ok , hello guys, i've lowered it, its working , but raises new problem , it fire-store error and ect .. so ? how to solve it ?


Allow custom link to be applied to private note links

Please select if your request is either something new or an enhancement

[x] Enhancement of an existing Feature.
[ ] Request of a new feature.

Please select the area your request applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

[ ] Workspace - VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
[ ] Lookup - Dendron's Lookup Command
[ ] Views - Dendron Preview, Tree View, Side Panels in the UI
[ ] Schema - Dendron Schemas
[ ] Pod - Data import from / export to Dendron
[x] Publish - External Site Publish
[ ] Markdown - Markdown features, such as syntax support and features

Is your feature request related to a problem? Please describe
All links to private notes are currently linked to the dendron explanation of a private note (wiki.dendron.so/notes/hfyvYGJZQiUwQaaxQO27q.html). It would be useful to have a way to configure what this links to.
Describe the solution you'd like
A config option in the publishing section of the yaml to define what private note links link to.
Describe alternatives you've considered
Additional context
Extension of the request in #3007

To have the possibility of configuring the link it's great too... the original unpublished page (the one on dendron site) can be the default one, but inside of the published result

Thanks @rlh1994 for the suggestion


GroupBy subdocument

If I try something like
$t = Sessions::groupBy('subdoc.id')->get();
I get
RuntimeException in Aggregate.php line 168:
exception: the group aggregate field name 'affiliate.affId' cannot be used because $group's field names cannot contain '.'
I saw this was fixed for the sum functions but apparently not for groupBy.
Thanks

+1, really need this to work.


[Snyk] Security upgrade python from 3.7 to 3.14.0a1

Snyk has created this PR to fix 2 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):

samples/contrib/versioned-pipeline-ci-samples/kaggle-ci-sample/submit_result/Dockerfile

We recommend upgrading to python:3.14.0a1, as this image has only 178 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Out-of-bounds Write SNYK-DEBIAN12-GLIBC-5927132
  829

Out-of-bounds Write SNYK-DEBIAN12-GLIBC-5927132
  829

Out-of-bounds Write SNYK-DEBIAN12-GLIBC-5927132
  829

Out-of-bounds Write SNYK-DEBIAN12-GLIBC-5927132
  829

CVE-2023-44487 SNYK-DEBIAN12-NGHTTP2-5953379
  829

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Commit Checker results:
**NOTE**: These are the results of the commit checker scans.
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between e27b68731776c35efe5e363295c3cc4a782cec4f...cb79a0c4d8cd0cdd365d7ece50b3144de3b6367b

UPSTREAM commit cb79a0c has invalid summary fix: samples/contrib/versioned-pipeline-ci-samples/kaggle-ci-sample/submit_result/Dockerfile to reduce vulnerabilities.

The Data Science Pipelines team recommends testing this using the Data Science Pipelines Operator.  Check here for more information on using the DSPO.
To use and deploy a DSP stack with these images (assuming the DSPO is deployed), first save the following YAML to a file named dspa.pr-114.yaml:
apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
  name: pr-114
spec:
  dspVersion: v2
  apiServer:
    image: "quay.io/opendatahub/ds-pipelines-api-server:pr-114"
    argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-114"
    argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-114"
  persistenceAgent:
    image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-114"
  scheduledWorkflow:
    image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-114"
  mlmd:
    deploy: true  # Optional component
    grpc:
      image: "quay.io/opendatahub/mlmd-grpc-server:latest"
    envoy:
      image: "registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2"
  mlpipelineUI:
    deploy: true  # Optional component
    image: "quay.io/opendatahub/ds-pipelines-frontend:pr-114"
  objectStorage:
    minio:
      deploy: true
      image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance'

Then run the following:
cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines.git
cd data-science-pipelines/
git fetch origin pull/114/head
git checkout -b pullrequest cb79a0c4d8cd0cdd365d7ece50b3144de3b6367b
oc apply -f dspa.pr-114.yaml

More instructions here on how to deploy and test a Data Science Pipelines Application.


Varnish probe fails with PROXY v2

Hi,
we use go-proxyproto for some stub backends for testing purpose and it fails when we tell Varnish to use v2 while v1 works.
The connection between Varnish and HAProxy works fine so I suspect something's wrong within go-proxyproto.
Here's anything required for a testcase:
package main
import (
	"fmt"
	"net"
	"net/http"
	"github.com/pires/go-proxyproto"
)
func main() {
    handler := func(w http.ResponseWriter, r *http.Request) {
        w.WriteHeader(http.StatusOK)
    }
    srv := &http.Server{
        Handler: http.HandlerFunc(handler),
        Addr:    fmt.Sprintf("<IP_ADDRESS>:%d", 14240),
    }
    ln, err := net.Listen("tcp", srv.Addr)
    if err != nil {
        fmt.Println(err)
    }

    policyFunc := func(upstream net.Addr) (proxyproto.Policy, error) { return proxyproto.REQUIRE, nil }
    proxyListener := &proxyproto.Listener{Listener: ln, Policy: policyFunc}
    srv.Serve(proxyListener) //nolint:errcheck
}

go build test.go
./test

Varnish 6.4.0 (or later):
example.vcl:
vcl 4.1;
backend default {
    .host = "<IP_ADDRESS>";
    .port = "14240";
    .proxy_header = 1;

            .probe = {
                .request =
                        "GET /test HTTP/1.1"
                        "Host: www.example.com"
                        "User-Agent: varnish"
                        "Connection: close";
                .interval = 5s;
                .timeout = 3s;
                .window = 8;
                .threshold = 3;
                .expected_response = 200;
        }

}

varnishd -f /etc/varnish/example.vcl -F

varnishlog -n /var/lib/varnish/$(hostname) -g raw -i Backend_health

Now varnishlog should report:
0 Backend_health - default Still healthy 4---X-RH 4 3 8 0.000505 0.000226 "HTTP/1.1 200 OK"

Now change .proxy_header from 1 to 2 in example.vcl:
    .proxy_header = 2;

And re-run the above testcase.
varnishlog will now log:
0 Backend_health - default Still sick 4---X-R- 0 3 8 0.000322 0.000000 "HTTP/1.1 400 Bad Request"

So the probe fails. Looking into a tcpdump what it does is to send a QUIT via PROXYv2 before doing the probe request and I suspected that's the reason for the 400.
This might be related: https://github.com/kubernetes/kubernetes/issues/57250#issuecomment-475081213

What version of the lib are you using?

Also, have you tried different policies? Right now you're setting REQUIRE:
	// REQUIRE connection to send PROXY header, reject if not present
	// Note: even though the first read on the connection returns an error if
	// a PROXY header is not present, subsequent reads do not. It is the task
	// of the code using the connection to handle that case properly.

0.3.2. We tried without REQUIRE at first.

Can you share more about this QUIT message? I can't find references to this in the spec.

I have no idea to be honest. That's just what I found by googling for similar issues.

Can you please try with v0.4.0 and let me know? It addresses #60 (HAProxy) but maybe addresses your use-case as well.

Can you please try with v0.4.0 and let me know? It addresses #60 (HAProxy) but maybe addresses your use-case as well.

It still fails. Are you able to reproduce it the way I described above?

It still fails. Are you able to reproduce it the way I described above?

Haven't tried, yet, I'm sorry. Maybe during the weekend.

Haven't tried, yet, I'm sorry. Maybe during the weekend.

I haven't checked yet, sorry. Lots of other things taking priority. Anyways, I did a bit more research and it all comes back to this. Whatever this QUIT message is, it's an invalid HTTP request and/or PROXY header so HTTP 400 sounds about right.
I'm still leaving this open for others' reference and maybe I'll find time to reproduce and investigate.

I'm not sure where it comes from and if that really is the problem. I couldn't find it within the Varnish sources so far. So I might be wrong.

I just tested it again with Varnish 6.5.1 and 6.4.0 and it seems to work now.
As of 0.4.1 it works. It's probably related to 70665b5dc439d3894d793050feec5331c4ea608f

Sweet! Can we close then?

Yup. Thanks!


Add missing argument dashboard_uid to get_annotation method

Description
I added missing arguments for /annotaions endpoint
Checklist

[X] The patch has appropriate test coverage
[X] The patch follows the style guidelines of this project
[X] The patch has appropriate comments, particularly in hard-to-understand areas
[X] The documentation was updated corresponding to the patch
[X] I have performed a self-review of this patch

Thank you very much for your contribution. I've squashed your commits, and added a corresponding changelog item.

Your improvement has been released with 3.6.0. Thanks again.


Add Export Values Example

Export Values from All Data Streams of a Device: this example should first make a call to Export All Values then it should call the View Job Results endpoint until the export job is completed. Then when the Job is complete the example should get the result.url which is the URL where the CSV export can be downloaded.

@kristinpeterson - https://github.com/attm2x/m2x-php/pull/30 has resolved this issue.


Check the scheduling logic if a job fails (i.e. is not set as the active job)

It seems like when a job fails on a monthly schedule (for example), then it is not retried for another month.
Example: https://data.open-contracting.org/admin/data_registry/job/629/change/

Nevermind - monthly is the minimum frequency.


Implement user-defined job resource constraints

Ensure that all user-defined job resource constraints (such as kubernetes_memory_limit) are well supported also when using the Kueue submission technique. E.g. test job limits vs requests and how they are passed through via Kueue.

I have created a script that generates a yaml file for kueue depending on the resources constraints you define through a CLI interaction. Next step would be to:

[ ] 1. Implement CLI script into REANA
[ ] 2. Test it in REANA while Kueue deployed
[ ] 3. Improve usability
[ ] 4. Ensure that all user-defined job resource constraints (such as kubernetes_memory_limit) are well supported
[ ] 5. Test job limits vs requests and how they are passed through via Kueue.

Running Workflows on Different Backends
REANA offers flexibility in running workflows. By default, workflows utilize Kubernetes for job execution. However, you can also choose HTCondor or Slurm as alternatives.
Specifying the Compute Backend
Each step within your workflow can have a dedicated compute_backend property in its specification. If this property is omitted, the default backend (Kubernetes) will be used.
Customizing Memory Limits
Exceeding cluster memory limits can lead to "Out of Memory" (OOM) errors, causing jobs to be terminated. To avoid this, you can adjust the memory allocated per workflow step, optimizing resource utilization.
Increasing vs. Decreasing Memory Limits

Increasing memory: This allows your jobs to utilize more resources, potentially improving performance.
Decreasing memory: This can improve scheduling chances for your jobs in a busy cluster by allowing more jobs to fit within available resources.

Setting Job Memory Limits
For each workflow step, you can specify the desired memory limit using the kubernetes_memory_limit property within its configuration. Refer to the official Kubernetes documentation for guidance on appropriate memory values.
Configuring Steps in Different Workflow Engines
Serial, Yadage, CWL, and Snakemake workflow engines all allow configuration of steps within their respective specifications.
Example: Creating a Serial Workflow with Memory Constraints
By defining a memory limit in your workflow's serial step configuration, you can trigger a specific error message if insufficient memory is available.

Visualizing Errors in REANA UI
The REANA user interface also allows you to visualize these errors, providing valuable feedback for resource management.

Custom Job Timeouts
If a job exceeds its specified time limit, Kubernetes automatically terminates it and marks it as failed.
Setting Job Timeouts
For each workflow step, you can declare a timeout using the kubernetes_job_timeout property in its specification. Timeouts are measured in seconds.
Kubernetes Job Timeout Documentation
Refer to the official Kubernetes documentation here for more details on job execution timeout limitations.
Configuring Steps for Timeouts
Similar to memory limits, you can configure job timeouts within the specifications of different workflow engines (Serial, Yadage, CWL, and Snakemake).
Example: Creating a Serial Workflow with Job Timeouts
By defining a timeout value in your serial workflow step, you can test expected behavior if a job's execution exceeds the specified limit. The job will be terminated with a "DeadlineExceeded" error message.

Verifying Timeouts in REANA UI
The REANA UI also provides functionalities to verify job terminations due to timeouts.

For more detailed guidance and examples, refer to the official documentation of your chosen workflow engine and Kubernetes.


Feature request: fallback action

Currently my preferred completion workflow (with 'completion-nvim') is to look at some "complex" sources (like LSP and snippets) but fall back to Vim's completion (triggered by <C-n>) if there are no items there. This is a simple variant of chain completion, which you said you won't implement. However, maybe adding a setting for fallback action is more aligned with your views on this plugin? This should be a function which will be triggered if 'compe sources' returned no result.
I managed to implement this functionality with the following:

Added these lines here:

if Completion._is_completing(context) then
  Config.get().fallback_action()
end

Defined custom (almost one-to-one copy from 'completion-nvim') fallback action in setup:

fallback_action = function()
  local timer = vim.loop.new_timer()
  timer:start(80, 0, vim.schedule_wrap(function()
    mode_keys = vim.api.nvim_replace_termcodes('<c-g><c-g><c-n>', true, false, true)
    vim.api.nvim_feedkeys(mode_keys, 'n', true)
    timer:stop()
    timer:close()
  end))
end;

This seems to work as expected. Arguably, this functionality might be better as a different source, but I didn't manage to create one replicating Vim's <C-n> funcionality (with its completion from opened buffers, tags, dictionary, etc.). Also it might be difficult to implement in async fashion.

I think it would be useful but probably it's very difficult.
Because nvim-compe is async completion engine so it will be show completion-menu even if all sources doesn't finish completion.
For example, if the user enables buffer source and lsp source.

Type keyword lo|
Invoke buffer and lsp source
First, the buffer source completed and completion-menu shown
Second, the lsp source completed and completion-menu redrawn

I think we should call fallback action on 4 in steps.

Yeah, any asynchronous execution is not easy.
Could you please help clarifying why the following change in Completion._display() seems to work (Vim's completion is shown only if no other source has candidate)? And when it can break?
diff --git a/lua/compe/completion.lua b/lua/compe/completion.lua
index e39c48b..b10b6c2 100644
--- a/lua/compe/completion.lua
+++ b/lua/compe/completion.lua
@@ -236,6 +236,9 @@ Completion._display = guard(function(context)

     if #items == 0 then
       Completion._show(0, {})
+      if Completion._is_completing(context) then
+        Config.get().fallback_action()
+      end
     else
       Completion._show(start_offset, items)
     end

Here is an example of how it works. I enabled buffer and nvim_lua compe sources, added C-n fallback action, and enabled Vim's spelling (detailed init.vim below):

Gif is created with this 'init.vim'
call plug#begin('~/.config/nvim/autoload/plugged')
  Plug 'hrsh7th/nvim-compe'
call plug#end()

set spell
set spelllang=en
set complete+=kspell

set completeopt=menuone,noselect

lua << EOF
compe = require'compe'

compe.setup {
  enabled = true;
  autocomplete = true;
  debug = false;
  min_length = 1;
  preselect = 'enable';
  throttle_time = 80;
  source_timeout = 200;
  incomplete_delay = 400;
  max_abbr_width = 100;
  max_kind_width = 100;
  max_menu_width = 100;
  documentation = true;

  fallback_action = function()
    local timer = vim.loop.new_timer()
    timer:start(80, 0, vim.schedule_wrap(function()
      mode_keys = vim.api.nvim_replace_termcodes('<c-g><c-g><c-n>', true, false, true)
      vim.api.nvim_feedkeys(mode_keys, 'n', true)
      timer:stop()
      timer:close()
    end))
  end;

  source = {
    buffer = true;
    nvim_lua = true;
  };
}

vim.api.nvim_set_keymap(
  'i', '<CR>', [[compe#confirm('<CR>')]],
  {silent = true, expr = true, noremap = true}
)
EOF

I will consider it.
I think your patch is not enough about some corner cases.

We should check if all sources completed or not.
We should fallback only if the completion invoked manually.


Add support to ClassExpressions in the prop-types rule

I'm not super happy with the solution, perhaps others have a better idea?
It turns out that ESLint visits ClassExpression before it visits TypeParameterDeclaration, but I want it the other way around.
I tried using the ClassExpression:exit key, but it doesn't change anything.
Therefore, I needed a way to defer class expressions evaluations util after TypeParameterDeclaration has been visited, by storing the nodes in an array and looping through it in Program:exit.
This fixes https://github.com/yannickcr/eslint-plugin-react/issues/1376#issuecomment-325166909 and several other cases which we didn't catch before.
I'm not sure it will cover all of the issues related to Flow Props yet.
I'll add the same support to no-unused-prop-types  in https://github.com/yannickcr/eslint-plugin-react/issues/1393

@jseminck I just tested this out in my code and it's working great!


Test ISM rollover + alias initialization update

Description
Test the new wazuh-indexer packages for 4.8.0 containing the fix for the rollover + alias initialization bug found in #79.
The packages have been generated by @wazuh/qa team and their links are available here:

https://packages-dev.wazuh.com/warehouse/test/4.8/rpm/wazuh-indexer-4.8.0-wp2697.x86_64.rpm
https://packages-dev.wazuh.com/warehouse/test/4.8/deb/wazuh-indexer_4.8.0-wp2697_amd64.deb

We need to test these packages following the installation and upgrade guides for 4.8.0 (master branch contains latest code).

Upgrade
Vagrantfile

Vagrant.configure("2") do |config|

    config.vm.provider "virtualbox" do |vb|
        vb.memory = "4096"
        vb.cpus = "4"
    end

    config.vm.box = "generic/rhel7"
    config.vm.synced_folder ".", "/vagrant"
    config.vm.network "private_network", ip: "<IP_ADDRESS>"

    config.vm.provision "shell", inline: <<-SHELL
        # Disable firewall
        systemctl stop firewalld
        systemctl disable firewalld

        curl -sO https://packages.wazuh.com/4.7/wazuh-install.sh && bash ./wazuh-install.sh
    SHELL
end

Install<EMAIL_ADDRESS>using the installation assistant: vagrant up
Follow the upgrade guide, but using a local RPM package for wazuh-indexer:
Clone wazuh-documentation repo. Prepare python's virtual env and build with make: git clone git@github.com:wazuh/wazuh-documentation.git
 cd wazuh-documentation
 python3 -m venv venv
 source venv/bin/activate
 pip -r install requirements.txt
 make html
 # Open build/html/index.html in your browser

Download new RPM package for wazuh-indexer. Place it inside the folder with the Vagrantfile.
Follow the upgrade guide:
Continued in the next comment.

Upgrade
Procedure (commands)
wazuh-indexer

rpm --import https://packages-dev.wazuh.com/key/GPG-KEY-WAZUH
echo -e '[wazuh]\ngpgcheck=1\ngpgkey=https://packages-dev.wazuh.com/key/GPG-KEY-WAZUH\nenabled=1\nname=EL-$releasever - Wazuh\nbaseurl=https://packages-dev.wazuh.com/pre-release/yum/\nprotect=1' | tee /etc/yum.repos.d/wazuh.repo

systemctl stop filebeat
systemctl stop wazuh-dashboard

curl -X PUT "https://<IP_ADDRESS>:9200/_cluster/settings"  -u admin:wiarUF8dnrUCiY*yHVIk*J+Z4bDIJdcH -k -H 'Content-Type: application/json' -d'
{
  "persistent": {
    "cluster.routing.allocation.enable": "primaries"
  }
}
'
curl -X POST "https://<IP_ADDRESS>:9200/_flush/synced" -u admin:wiarUF8dnrUCiY*yHVIk*J+Z4bDIJdcH -k

systemctl stop wazuh-indexer
yum localinstall /vagrant/wazuh-indexer-4.8.0-wp2697.x86_64.rpm

systemctl daemon-reload
systemctl enable wazuh-indexer
systemctl start wazuh-indexer

curl -k -u admin:wiarUF8dnrUCiY*yHVIk*J+Z4bDIJdcH https://<IP_ADDRESS>:9200/_cat/nodes?v
curl -X PUT "https://<IP_ADDRESS>:9200/_cluster/settings"  -u admin:wiarUF8dnrUCiY*yHVIk*J+Z4bDIJdcH -k -H 'Content-Type: application/json' -d'
{
  "persistent": {
    "cluster.routing.allocation.enable": "all"
  }
}
'
curl -k -u admin:wiarUF8dnrUCiY*yHVIk*J+Z4bDIJdcH https://<IP_ADDRESS>:9200/_cat/nodes?v
bash /usr/share/wazuh-indexer/bin/indexer-init.sh -i <IP_ADDRESS> -p wiarUF8dnrUCiY*yHVIk*J+Z4bDIJdcH

wazuh-server
yum upgrade wazuh-manager
curl -s https://packages-dev.wazuh.com/pre-release/filebeat/wazuh-filebeat-0.4.tar.gz | sudo tar -xvz -C /usr/share/filebeat/module
curl -so /etc/filebeat/wazuh-template.json https://raw.githubusercontent.com/wazuh/wazuh/4.8.0/extensions/elasticsearch/7.x/wazuh-template.json
chmod go+r /etc/filebeat/wazuh-template.json
systemctl daemon-reload
systemctl enable filebeat
systemctl start filebeat
filebeat setup --index-management -E output.logstash.enabled=false

wazuh-dashboard
yum upgrade wazuh-dashboard
systemctl daemon-reload
systemctl enable wazuh-dashboard
systemctl start wazuh-dashboard

Logs
[root@rhel7 vagrant]# yum localinstall /vagrant/wazuh-indexer-4.8.0-wp2697.x86_64.rpm
Failed to set locale, defaulting to C
Loaded plugins: product-id, search-disabled-repos
Examining /vagrant/wazuh-indexer-4.8.0-wp2697.x86_64.rpm: wazuh-indexer-4.8.0-wp2697.x86_64
Marking /vagrant/wazuh-indexer-4.8.0-wp2697.x86_64.rpm as an update to wazuh-indexer-4.7.1-1.x86_64
Resolving Dependencies
--> Running transaction check
---> Package wazuh-indexer.x86_64 0:4.7.1-1 will be updated
---> Package wazuh-indexer.x86_64 0:4.8.0-wp2697 will be an update
--> Finished Dependency Resolution

Dependencies Resolved

=====================================================================================================================================================================================================
 Package                                     Arch                                 Version                                     Repository                                                        Size
=====================================================================================================================================================================================================
Updating:
 wazuh-indexer                               x86_64                               4.8.0-wp2697                                /wazuh-indexer-4.8.0-wp2697.x86_64                               1.0 G

Transaction Summary
=====================================================================================================================================================================================================
Upgrade  1 Package

Total size: 1.0 G
Is this ok [y/d/N]: y

Updated:
  wazuh-indexer.x86_64 0:4.8.0-wp2697

Complete!
[root@rhel7 vagrant]# cat /usr/share/wazuh-indexer/VERSION
4.8.0

[root@rhel7 vagrant]# bash /usr/share/wazuh-indexer/bin/indexer-init.sh -i <IP_ADDRESS> -p wiarUF8dnrUCiY*yHVIk*J+Z4bDIJdcH
Executing Wazuh indexer security init script...
**************************************************************************
** This tool will be deprecated in the next major release of OpenSearch **
** https://github.com/opensearch-project/security/issues/1755           **
**************************************************************************
Security Admin v7
Will connect to <IP_ADDRESS>:9200 ... done
Connected as "CN=admin,OU=Wazuh,O=Wazuh,L=California,C=US"
OpenSearch Version: 2.10.0
Contacting opensearch cluster 'opensearch' and wait for YELLOW clusterstate ...
Clustername: wazuh-cluster
Clusterstate: GREEN
Number of nodes: 1
Number of data nodes: 1
.opendistro_security index already exists, so we do not need to create one.
Populate config from /etc/wazuh-indexer/opensearch-security/
Will update '/config' with /etc/wazuh-indexer/opensearch-security/config.yml
   SUCC: Configuration for 'config' created or updated
Will update '/roles' with /etc/wazuh-indexer/opensearch-security/roles.yml
   SUCC: Configuration for 'roles' created or updated
Will update '/rolesmapping' with /etc/wazuh-indexer/opensearch-security/roles_mapping.yml
   SUCC: Configuration for 'rolesmapping' created or updated
Will update '/internalusers' with /etc/wazuh-indexer/opensearch-security/internal_users.yml
   SUCC: Configuration for 'internalusers' created or updated
Will update '/actiongroups' with /etc/wazuh-indexer/opensearch-security/action_groups.yml
   SUCC: Configuration for 'actiongroups' created or updated
Will update '/tenants' with /etc/wazuh-indexer/opensearch-security/tenants.yml
   SUCC: Configuration for 'tenants' created or updated
Will update '/nodesdn' with /etc/wazuh-indexer/opensearch-security/nodes_dn.yml
   SUCC: Configuration for 'nodesdn' created or updated
Will update '/whitelist' with /etc/wazuh-indexer/opensearch-security/whitelist.yml
   SUCC: Configuration for 'whitelist' created or updated
Will update '/audit' with /etc/wazuh-indexer/opensearch-security/audit.yml
   SUCC: Configuration for 'audit' created or updated
Will update '/allowlist' with /etc/wazuh-indexer/opensearch-security/allowlist.yml
   SUCC: Configuration for 'allowlist' created or updated
SUCC: Expected 10 config types for node {"updated_config_types":["allowlist","tenants","rolesmapping","nodesdn","audit","roles","whitelist","internalusers","actiongroups","config"],"updated_config_size":10,"message":null} is 10 (["allowlist","tenants","rolesmapping","nodesdn","audit","roles","whitelist","internalusers","actiongroups","config"]) due to: null
Done with success
Executing Wazuh indexer ISM init script...
Will create 'wazuh' index template
 SUCC: 'wazuh' template created or updated
Will create index templates to configure the alias
 SUCC: 'wazuh-alerts' template created or updated
 SUCC: 'wazuh-archives' template created or updated
Will create the 'rollover_policy' policy
  SUCC: 'rollover_policy' policy created
Will create initial indices for the aliases
  SUCC: 'wazuh-alerts' write index created
  SUCC: 'wazuh-archives' write index created
SUCC: Indexer ISM initialization finished successfully.

The initial indices are created properly, using all the settings from the templates.

However, there are 2 problems:

Missing step in the upgrade guide to refresh Filebeat's ingest pipelines
The rollover policy is applied to wazuh-alerts-4.x-sample indices, but shouldn't.

Although the second one doesn't present any major issue, the first one does, as Filebeat continues to send events to the old indices (wazuh-alerts-4.x-2023.12.21), instead of the new ones (wazuh-alerts-4.x-2023.12.21-000001). The ingest pipelines must be reloaded with filebeat setup pipelines. This step is missing in the upgrade guide.

Checking the DEB package
Having successfully completed an upgrade using the RPM package, there is no point on repeating the process for the deb package, as the process is the same. Instead, we'll check that the template is at the expected path /etc/wazuh-indexer/wazuh-template.json
To extract the package, use:
ar x wazuh-indexer_4.8.0-wp2697_amd64.deb
tar xvf data.tar.xz

It's verified that the template is at the expected path.
./etc/
./etc/wazuh-indexer/
./etc/wazuh-indexer/opensearch-reports-scheduler/
./etc/wazuh-indexer/opensearch-reports-scheduler/reports-scheduler.yml
./etc/wazuh-indexer/wazuh-template.json
./etc/wazuh-indexer/log4j2.properties
./etc/wazuh-indexer/opensearch-notifications/
[...]

Testing completed. As a result, new issues have been opened.


Ajout du domaine moov.mg pour IT University

J'ai ajouté le domaine moov.mg pour l'université IT University de Madagascar dans le dépôt.

@RazafindramananaYaris I have to close this request without merging, because you requested to add a non-existent domain to this repository: `` Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


Improves the documentation of RequireAcceptingAccountMatchInvitedAccount

This pull request improves the documentation of "-RequireAcceptingAccountMatchInvitedAccount" switch for Set-SPOTenant cmdlet. Adds notes to clarify when to use it and how quickly it's applied.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOTenant.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@koskila - thanks for taking the time to improve the content! Much appreciated!
@VesaJuvonen - ok to merge?

thx @koskila, appreciated.

It worked good, so no issues on formatting. Thx.

My pleasure! Happy to hear it worked out ok.


Create tests for MultisigWallet

4 tests failing, can you check if it's related to: https://github.com/OpenZeppelin/zeppelin-solidity/pull/106/files ?

It is, adding a payable modifier to MultisigWalletMock should probably already resolve some of your issues

please rebase or squash (lots of unwanted commits in the PR)

ACK


Example: Simple Universe

Description:
This example aims to help users get familiar with catalyst API's to collect and handle data.
Features:

How to create a universe
How to Filter a universe
Collect ohlcv data
Update function daily
Update function every 30 minutes

Test
source activate catalyst
python simple_universe.py

Currently, it throws errors due to catalyst bugs but it should not throw errors in the future.
A similar version can be used for unit testing ALL currency pairs for all exchanges
Feel free to update/upgrade to your needs.

@lacabra
This example is fully tested on v0.3.3 and ready to be merged.
Test instructions are provided, so please ensure it works on your computer before merging.

This PR I believe is ready to be merged. Feel free to suggest improvements before merging and I'll do my best to comply.

Merged into the develop branch.

Thanks @abnera for this submission, this is great! 👍


Propose Logo

Hi. I'm graphic disigner. I would like to know if you are interested that I make a logo for your project? If you allowed me, i"ll make logo for your project and it's free.

Sounds good to me. I can't guarantee we'll use it. But, we'll at least give it proper consideration. Thank you! 🙏

Hi sir @analogcode Sorry for late reply, I've designed a logo for you, if you like it, you can use it. i'll send you files. Tell me if you need some change or anything.

If you dont like it you can close this issues. Thank you


Wheel support

http://pythonwheels.com/
Right now, only the tar.gz file is being distributed on PyPI for oauthlib, which isn't that much of an issue, but it does add some time to installing the package.
This package should be compatible with the Wheel format, considering it doesn't appear to have any C dependencies and it is compatible with both Python 2 and 3. As a result, you should only need to generate a universal wheel and then everyone (on all systems) will get the ability to install oauthlib with just the wheel, without having to do any extra work.

This is fixed in https://github.com/idan/oauthlib/commit/06c7c58bac102838c46a5bef47e3d1758f7095c0


Feature/add Japanese support

Hello.
I added code to the places that I thought were necessary to add Japanese, referring to #184  and the Korean language section.
I haven't actually built it yet, and I haven't generated the .ndjson file yet. (Sorry, I don't know how)

Thank you for taking the time to add all this! This will actually save me quite a bit of time! I'll try and get to this later today


feat: add cspell

https://github.com/graphql/graphiql/issues/2135
added cspell

thank you @kupuma-ru21 !

thank you @kupuma-ru21 !

@acao
I'm not very good at English.
So there were many words that I couldn't decide if they were typos or not.
I fixed the words that were obviously typos, but I defined the other words in "custom-words.txt".
I would appreciate it if you could give me feedback.

awesome, thank you!

@kupuma-ru21 i have your branch updated and ready to go if you can allow me to push to it!

I rebased the branch, fixed some more typos and pushed everything to #2512. Closing this PR in favour of the new one. Thanks a lot @kupuma-ru21 for this! 🙏
@acao if you have more changes that are still valid you should be able to easily rebase them on top of main (I reused the same commits as this PR)


Add a Prefs for Unicode fallback font

Currently there is a hard-coded fallback to "Arial Unicode" on mac, and "Arial" on windows.  The latter does not have much actual coverage.  It is unclear if windows has a standard font with much actual coverage -- it used to ship with Arial Unicode but no longer apparently: https://en.wikipedia.org/wiki/Unicode_font
Anyway, with the pref, anyone who needs better unicode coverage can install a suitable font (Noto perhaps -- does it come in a single mega file or only sub-files for different locales?) and set that in the pref.
Alternatively, we may need to compile a map from rune to font that has support for it -- but that would be expensive, in terms number of fonts open at a time.

The latter is clearly the best solution: have a stack of fonts (e.g., the Noto series) and the map[rune]*Font -- really not a problem to compile the map...


[Feature request]: tuono-router - remove zustand and use React Context API

Is your feature request related to a problem? Please describe.
Remove zustand and use React.context API instead
Describe the solution you'd like
Right now zustand is used to keep track of the router state but all the logic can be moved inside a
new InternalRouterContext.
Data of RouterContext

router: it will be the router instance
state:
https://github.com/tuono-labs/tuono/blob/77e22c40b6a0bb949e411e7e2ec26c70433c94f2/packages/router/src/hooks/useRouterStore.tsx#L14-L24
All this properties will have their dedicated state (probably using React.useState)
We might use a reducer but I think it might be add more overhead.

Context interactions (read and update data)

[!NOTE]
After a search I noticed that only location and updateLocation are used

[!NOTE]
The context itself will not be exported from the file.
To interact with this context we will have to go through specific hooks (listed below)

Name
Current name
Description
Exported

useRouterInstance
useInternalRouter
provides the router instance
❌

useRouterLocation
useRouter
provides the router location and the setter method and additional methods (push)
✅

With this refactor all router logic will be moved in a single place instead of be around different files:

packages/router/src/hooks/useRouterStore.tsx
packages/router/src/hooks/useInternalRouter.tsx
packages/router/src/components/RouterContext.tsx
packages/router/src/components/RouterProvider.tsx

Describe alternatives you've considered
No response
Additional context
eslint-plugin-react-hooks is not present in the project and I found some violations about the rules of hooks:

useMemo is conditional here: https://github.com/tuono-labs/tuono/blob/77e22c40b6a0bb949e411e7e2ec26c70433c94f2/packages/router/src/components/RouteMatch.tsx#L60-L68
This layout effect should have updateLocation, the function should be stable so it should not change hence it can be safely added to the dependencies https://github.com/tuono-labs/tuono/blob/77e22c40b6a0bb949e411e7e2ec26c70433c94f2/packages/router/src/hooks/useRouterStore.tsx#L43-L52

The code is probably working in the current state but, without rule of Hooks static check and the absence of unit tests, performing this kind of refactor looks very error prone to me.

What do next?
From my point of view we should:

add eslint-plugin-react-hooks  and fix all reported warning and errors
add some unit test on packages/router/src/components/RouterProvider.tsx
This is highest components and is likely to not change with this refactor so having some test on it might be helpful.
(I don't know how much this is feasible)
Start implementing this issue proposal

Proposal update: added "Context interactions (read and update data)" section


Game freezes when new dialogue character.

Describe your bug here.
After 3 dialogue characters once a new one is introduced the game just freezes on that frame. I can still press buttons and hear sound effects but it just stuck on the frame with the new dialouge character coming in. All of the animations are correct and I get no errors in the terminal. Might be because of my bad computer.
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
Yeah I added 3 new dialogue characters and kinda added a working ending dialogue system

a


[help] Unable to request post sellorder?

Below is my example request in sellorder, it always return null
$data = [
			'payment_outlet' => 'load-globe',
			'amount' => 10,
			'currency_amount_locked' => 10,
			'currency' => 'PHP',
			'pay_with_wallet' => 'PBTC',
			'phone_number_load' => '+639xxxxxxxx',
			'btc_amount' => 0.00016969
		];
$so = $this->coins->post_sellorder($data);

Having the same problem with my requests to sellorder.


Jenkinsfile fixes for multiple unnecessary PRs

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-31/1/. :white_check_mark:

You can check this PRs instance in https://5479965e8f5668d403bbe47ea848f0fe6e8ccc7f-chi-pr.enterprise.ctl.io


Multiple Paths

I want to setup authentication on multiple paths for my API. In most cases I'll need authentication but in others I definitely don't want authentication (i.e. registration). I know I can create separate instances of \Slim\Middleware\HttpBasicAuthentication but is there a way to create a single instance that includes multiple paths?

Instead of using default "easy" mode for initializing middleware you have to pass all the rules as parameters. This is not properly doumented yet but code below would authenticate everything except /token and /hello. CORS preflight OPTIONS requests are not authenticated by default.
$auth = new \Slim\Middleware\HttpBasicAuthentication([
    "users" => [
        "root" => "t00r",
        "user" => "passw0rd"
    ]
]);

$auth->addRule(new \Slim\Middleware\RequestPathRule([
    "path" => "/",
    "passthrough" => ["/token", "/hello"]
]);

$app->add();

You could achieve the same with:
$app->add(new \Slim\Middleware\HttpBasicAuthentication([
    "users" => [
        "root" => "t00r",
        "user" => "passw0rd"
    ],
    "rules" => [
        new \Slim\Middleware\RequestPathRule([
            "path" => "/",
            "passthrough" => ["/token", "/hello"]
        ]),
        new \Slim\Middleware\RequestMethodRule([
            "passthrough" => ["OPTIONS"]
        ])
    ]
]));

You can also write you own rules. They are just callables. If callable returns false middleware will not authenticate. With below example nothing will be authenticated.
$app->add(new \Slim\Middleware\HttpBasicAuthentication([
    "users" => [
        "root" => "t00r",
        "user" => "passw0rd"
    ],
    "rules" => [
        function ($app) {
            /* Receives current Slim app as parameter. */
            return false;
        }
    ]
]));

Thanks!
Works great with some minor adjustments. I had to change the class path to:
$app->add(new \Slim\Middleware\HttpBasicAuthentication([
"users" => [
    "root" => "t00r",
    "user" => "passw0rd"
],
"rules" => [
    new \Slim\Middleware\HttpBasicAuthentication\RequestPathRule([
        "path" => "/",
        "passthrough" => ["/token", "/hello"]
    ]),
    new \Slim\Middleware\HttpBasicAuthentication\RequestMethodRule([
        "passthrough" => ["OPTIONS"]
    ])
]
]));

Ooops. Bad copy paste. I updated the code in my previous post for future reference.

I think you could add new field: paths, and if is not empty, before line: https://github.com/tuupola/slim-basic-auth/blob/master/src/HttpBasicAuthentication/RequestPathRule.php#L42  add new for with same check as you have for path, and if at least one condition give true - return it, otherwise check path
I'll write the code for this, next weekend, and maybe you could add it to the main repo.
Thanks for your effort!

Good idea. Although I prefer not to introduce too many parameters. One way to do it is if you could pass both string and array as path parameter. Then you could do both:
    new \Slim\Middleware\HttpBasicAuthentication\RequestPathRule([
        "path" => "/api",
        "passthrough" => ["/api/ping", "/api/hello"]
    ])

and
    new \Slim\Middleware\HttpBasicAuthentication\RequestPathRule([
        "path" => ["/api", "/secret"],
        "passthrough" => ["/api/ping", "/api/hello", "/secret/hello"]
    ])

agree, array is a nice option, we also can make a specific RuleClass for multiple paths
I'll make tests to see how it looks and what is simplier

Hello, here is my modified version of the file, if you think is ok, I could create a pull request for it
    public function __invoke(\Slim\Slim $app)
    {
        /* If request path matches passthrough should not authenticate. */
        foreach ($this->options["passthrough"] as $passthrough) {
            $passthrough = rtrim($passthrough, "/");
            if (!!preg_match("@^{$passthrough}(/.*)?$@", $app->request->getResourceUri())) {
                return false;
            }
        }

        /* Otherwise check if path matches and we should authenticate. */

        $paths = $this->options["path"];

        if(is_array($paths))
        {
            foreach ($paths as &$value) {
                $result = $this->shouldAuth($value, $app);

                if($result)
                {
                    return true;
                }
            }

            return false;
        }

        return $this->shouldAuth($paths, $app);
    }

    private function shouldAuth($path, \Slim\Slim $app)
    {
        $path = rtrim($path, "/");
        return !!preg_match("@^{$path}(/.*)?$@", $app->request->getResourceUri());
    }

Actually already implemented in https://github.com/tuupola/slim-jwt-auth/commit/08757347c44f31243a860788f49bd9d83e22d910. I just need to sync the rule from JWT Auth to Basic Auth.

wonderfull, thanks.


Cannot flatten and rename a field

I am having an issue where I want to flatten a field of a struct and rename it
I have found a solution but I'm trying to understand why flattening and renaming the field doesn't work
#[derive(Debug, Deserialize, Serialize, Default)]
pub struct Tags {
    pub tags: Vec<String>, // Doing serde(rename = "tagList") here fixes the problem tho
}

#[derive(Deserialize, Serialize, Debug)]
pub struct CreateArticleRequest {
    pub title: String,
    pub description: String,
    pub body: String,
    #[serde(flatten, rename = "tagList")] // Doing this causes the issue
    pub tag_list: Option<Tags>,
}

#[cfg(test)]
mod test {
    #[test]
    fn test() {
        let test_string = r#"
             {
                "title": "How to train your dragon",
                "description": "Ever wonder how?",
                "body": "It takes a Jacobian",
                "tagList": ["dragons", "training"]
            }
        "#;
        let create_article_request = serde_json::from_str::<super::CreateArticleRequest>(test_string);
        assert!(create_article_request.is_ok());
        println!("{:?}", create_article_request.unwrap()); // tag_list returns None when flattening and renaming the field instead of ["dragons", "training"]
    }
}

I think this is behaving correctly. flatten literally means use the field's contents but not its name. The field's contents are inlined as if they were field of the outer struct.

IMO the library could be improved by returning an error in case such contradicting attributes are applied on the same field.


Relative path doesn't work

Hi.
Can I put Trunk.toml in sub directory like this?
❯ tree configs/ entries/
configs/
├── postcss.config.js
├── tailwind.config.js
└── Trunk.toml
entries/
└── index.html

0 directories, 4 files

I tried:
[build]
target = "entries/index.html"
dist = "dist"

[build]
target = "../entries/index.html"
dist = "dist"

I always get:
❯ trunk --config configs/Trunk.toml build
Error: error getting canonical path to source HTML file "index.html"

Caused by:
    No such file or directory (os error 2)

or Error: error getting canonical path to source HTML file "/home/user/project/configs/entries/index.html"

I tried with more ... This is the result of `config show
[build]
target = "../entries/index.html"
dist = "dist"

❯ trunk --config configs/Trunk.toml config show
ConfigOpts {
    build: Some(
        ConfigOptsBuild {
            target: Some(
                "/home/user/aswm-prject/configs/../entries/index.html",
            ),
            release: false,
            dist: Some(
                "/home/user/aswm-prject/configs/dist",
            ),

I don't think Trunk understand ../ it still gives me /home/user/aswm-prject/configs/../entries/index.html. It should be /home/user/awsm-project/entries/index.html

I think this also affected:
<head>
    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
    <link data-trunk rel="css" href="../css/compiled.css" />
    <base data-trunk-public-url />
</head>

❯ trunk build
Mar 22 21:41:22.808  INFO 📦 starting build
Mar 22 21:41:22.810  INFO spawning asset pipelines
Mar 22 21:41:22.811 ERROR ❌ error
error from HTML pipeline

Caused by:
    0: error getting canonical path for "/home/user/awsm-project/entries/../css/compiled.css"
    1: could not canonicalize `/home/user/awsm-project/entries/../css/compiled.css`
    2: No such file or directory (os error 2)
Error: error from HTML pipeline

Caused by:
    0: error getting canonical path for "/home/user/awsm-project/entries/../css/compiled.css"
    1: could not canonicalize `/home/user/awsm-project/entries/../css/compiled.css`
    2: No such file or directory (os error 2)

I can't use relative path in index.html. Even if I have put Trunk.toml in top directory.

Thanks for opening this issue @azzamsa! I should be able to knock this out pretty quickly, and I'll be sure to add some tests around the config system so that we don't get any regressions on this front.

@azzamsa actually, looks like perhaps the error was on your end for the first issue. I tried to reproduce this in one of the examples by putting the Trunk.toml under a configs dir, and then pointing up one dir to the index.html file using a relative path and everything worked as expected. However, due to the fact that trunk config show is not doing any processing on the loaded config, it gives the appearance as though Trunk is not processing at runtime, where in reality it is.
Do you mind perhaps verifying the above once again? Perhaps attempt to reproduce this in one of our examples, but only the first part about relative paths in the Trunk.toml.
Finally, relative paths in the index.html is definitely not working as expected. I am going to address that as part of this bug fix.

@azzamsa yea ... actually, Trunk appears to be doing the correct thing. This appears to be an issue with your setup.
I've opened #152 ... but there was not actually any bug being fixed. I just added a few tests. The CSS pipeline has clearly stated that it attempted to take a canonical path:
Caused by:
    0: error getting canonical path for "/home/user/awsm-project/entries/../css/compiled.css"
    1: could not canonicalize `/home/user/awsm-project/entries/../css/compiled.css`
    2: No such file or directory (os error 2)
Error: error from HTML pipeline

So this appears to be an issue with your paths themselves. As a matter of fact, if I update the examples/yew project in this repo to follow a similar pattern as you've described with relative paths in the Trunk.toml & the index.html, everything works as expected.
Let me know what you think. I'm still going to merge the new tests I've added.

wrong (first) experiment
# command
rm -rf dist && trunk serve

# works
head configs/Trunk.toml -n 2
[build]
target = "index.html"

# works
head configs/Trunk.toml -n 2
[build]
target = "../index.html"

# works. How? It means if trunk doesn't find its config
# it will fallback to default. So in the above demo
# trunk never find any config. That's why it works all.
head configs/Trunk.toml -n 2
[build]
target = "./index.html"

first experiment
Pass --config to trunk
# command
rm -rf dist && trunk --config configs/Trunk.toml serve

No change to config.
# no
head configs/Trunk.toml -n 2
[build]
target = "index.html"

Error: error getting canonical path to source HTML file "/tmp/trunk/examples/seed/configs/index.html"

Caused by:
    No such file or directory (os error 2)

Add ../ to target.
# works!
head configs/Trunk.toml -n 2
[build]
target = "../index.html"

Add ./ to target.
# no
head configs/Trunk.toml -n 2
[build]
target = "./index.html"

Error: error getting canonical path to source HTML file "/tmp/trunk/examples/seed/configs/./index.html"

Caused by:
    No such file or directory (os error 2)

second experiment
move index.html to sub-directory entries/
# command
rm -rf dist && trunk --config configs/Trunk.toml serve

No change to index.html
# trunk config
head configs/Trunk.toml -n 3
[build]
target = "../entries/index.html"
dist = "../dist"

# index.html
head entries/index.html | grep css
    <link data-trunk rel="css" href="public/index.css" />

# result
Mar 24 12:05:34.892 ERROR ❌ error
error from HTML pipeline

Caused by:
    0: error getting canonical path for "/tmp/trunk/examples/seed/entries/public/index.css"
    1: could not canonicalize `/tmp/trunk/examples/seed/entries/public/index.css`
    2: No such file or directory (os error 2)
Mar 24 12:05:34.892  INFO 📡 server running at http://<IP_ADDRESS>:8080/

Add ../ to CSS href.
# trunk config
head configs/Trunk.toml -n 3
[build]
target = "../entries/index.html"
dist = "../dist"

# index.html
head entries/index.html | grep css
    <link data-trunk rel="css" href="../public/index.css" />

# result (different from the first)
Mar 24 12:07:32.660 ERROR ❌ error
error from HTML pipeline

Caused by:
    0: error getting cargo metadata
    1: `cargo metadata` exited with an error: error: manifest path `/tmp/trunk/examples/seed/entries/Cargo.toml` does not exist
Mar 24 12:07:32.660  INFO 📡 server running at http://<IP_ADDRESS>:8080/

Third experiment
move public/index.css to entries/
# command
rm -rf dist && trunk --config configs/Trunk.toml serve

No change to index.html
# trunk config
head configs/Trunk.toml -n 3
[build]
target = "../entries/index.html"
dist = "../dist"

# index.html
❯ head entries/index.html | grep css
    <link data-trunk rel="css" href="public/index.css" />

# result
Mar 24 12:11:45.055 ERROR ❌ error
error from HTML pipeline

Caused by:
    0: error getting cargo metadata
    1: `cargo metadata` exited with an error: error: manifest path `/tmp/trunk/examples/seed/entries/Cargo.toml` does not exist
Mar 24 12:11:45.055  INFO 📡 server running at http://<IP_ADDRESS>:8080/
^C⏎

❯ trunk --version
trunk 0.10.0

Summary
Yes. It works if I only move Trunk.toml to the sub-directory and add ../ to each target.
It doesn't for second experiment (relative path) in href. which you acknowledge.
I thought that the root cause lies in the integration between trunk and the html parser. So I remove ../ in index.html and move public/index.css to entries/. Turns out it also doesn't work.

In my project:
I have move Trunk.toml to congfigs/. with the content:
❯ head configs/Trunk.toml -n 3
[build]
target = "../index.html"
dist = "../dist"

and it works. as long as the index.html in the top directory. and the href doesn't contain ../ (relative path).

So actually, all cases work, it is just that your experiment has mistakes in a few locations.
Second Experiment
Your second experiment is mistaken because you didn't address the last issue which Trunk was telling you about :). As you can see here:

✅ rel="rust": Trunk will compile the specified Cargo project as the main WASM application. This is optional. If not specified, Trunk will look for a Cargo.toml in the parent directory of the source HTML file.
https://trunkrs.dev/assets/#rust

Specifically: Trunk will look for a Cargo.toml in the parent directory of the source HTML file. So to fix your second experiment, simply add the line <link data-trunk rel="rust" href="../Cargo.toml"/> to the bottom of your html.body and everything will work as advertised :).
Third Experiment
Also, in your third experiment, it is failing for the same reason as the second. You need to tell Trunk where your Cargo.toml is.
Summary

It doesn't for second experiment (relative path) in href. which you acknowledge.

I acknowledged prematurely. It works just fine with relative paths in the HTML, exactly as would be expected. Sorry for misleading you there.
PRO TIP: read the error output, and go with that. There will certainly be times where Trunk does not give the most helpful error output, and in such cases definitely open a bug so that we can fix that. However in all of these cases, Trunk was communicating what the issue was.

I hope that info helps. Keep me posted! Happy to dig in further if needed.

Yes, thanks!
I  will put my index.html file into sub-directory when the second issue is solved.

@azzamsa there is no issue to resolve in Trunk :). That is my point. Trunk is working as it should. You need to tell Trunk where your Cargo.toml is, and the way you do that is by adding the <link data-trunk rel="rust" href="../Cargo.toml"/> line to your html.body.
If you do not add that line to your html.body, then Trunk will assume that your Cargo.toml is in the same dir as your index.html. Make sense? Here is an example of doing so from our yew example: https://github.com/thedodd/trunk/blob/master/examples/yew/index.html#L17
Let me just emphasize: there is no bug/problem with Trunk. It is working as expected.
PS
I'm sorry if this sounds brash, I'm just trying to communicate as clearly as possible. Cheers!

Oh I see. So the second case is not a bug. I never know about <link data-trunk rel="rust" before.
Okay. It works now.
❯ exa -T configs/ entries/ -L 1 crate/
configs
└── Trunk.toml
crate
├── Cargo.toml
├── Makefile.toml
├── src
entries
└── index.html

❯ trunk --config configs/Trunk.toml build
Mar 25 10:59:59.873  INFO 📦 starting build
Mar 25 10:59:59.875  INFO spawning asset pipelines
Mar 25 10:59:59.996  INFO building crabtail
Mar 25 10:59:59.996  INFO compiling sass/scss path="sass/compiled.scss"
    Finished dev [unoptimized + debuginfo] target(s) in 0.04s
Mar 25 11:00:00.108  INFO fetching cargo artifacts
Mar 25 11:00:00.218  INFO processing WASM
Mar 25 11:00:00.230  INFO calling wasm-bindgen
Mar 25 11:00:00.446  INFO copying generated wasm-bindgen artifacts
Mar 25 11:00:01.406  INFO finished compiling sass/scss path="sass/compiled.scss"
Mar 25 11:00:01.406  INFO applying new distribution
Mar 25 11:00:01.409  INFO ✅ success

Should I close this issue now?
Thanks a lot for Trunk!


Label domains, select domains from entropy plot

It would be very helpful to have labeled domains on the AA/NT SNV frequency plot, so we can see at a glance what mutations are in what domains, i.e., mutations in the RBD of the Spike protein
I was thinking we could do something similar to this example plot: https://vega.github.io/editor/#/examples/vega/wheat-and-wages
The data about domains in genes/proteins is in the static_data/genes.json and static_data/proteins.json file. We should probably add an additional field to those entries, since we don't necessarily want to show all domains (especially the very short ones)

For reference:
Existing plot file is in src/vega_specs/entropy_standalone.vg.json. You can copy that directly into the Vega Editor and it should run.
Reference entropy viewer is on NextStrain
To start with, let's try to label the domains: Receptor binding domain (RBD) and S2 subunit in the Spike gene. Next, we can add the overlapping domains (S1 subunit, N-terminal domain (NTD)) to develop the overlapping tech.


map leap-forward/backward-till will cause u map to undo, but I map other key to undo

install leap.nvim

-- To set alternative keys for "exclusive" selection:
vim.keymap.set({'x', 'o'}, <some-other-key>, '<Plug>(leap-forward-till)')
vim.keymap.set({'x', 'o'}, <some-other-key>, '<Plug>(leap-backward-till)')

or just call require("leap").add_default_mapping(true)
3. type dx.., just use leap-forward/backward-till,
will cause map u to undo.

Solved?

It's not leap bug, actually it's dot-repeat default configures.


miniz_zip: fix mz_zip_reader_extract_to_heap to read correct sizes

Fixes: https://github.com/richgel999/miniz/issues/218

As I noted in the merge commit, I seem to have made a mistake in a return value.
Here is the trivial fix:
diff --git a/miniz_zip.c b/miniz_zip.c
index 3b88d7d..f9559e2 100644
--- a/miniz_zip.c
+++ b/miniz_zip.c
@@ -1636,7 +1636,7 @@ void *mz_zip_reader_extract_to_heap(mz_zip_archive *pZip, mz_uint file_index, si
         *pSize = 0;

     if (!mz_zip_reader_file_stat(pZip, file_index, &file_stat))
-        return MZ_FALSE;
+        return NULL;

     alloc_size = (flags & MZ_ZIP_FLAG_COMPRESSED_DATA) ? file_stat.m_comp_size : file_stat.m_uncomp_size;
     if (((sizeof(size_t) == sizeof(mz_uint32))) && (alloc_size > 0x7FFFFFFF))


Remove filtersApplied from image-spec

See https://github.com/opencontainers/distribution-spec/pull/380 which proposes changing how the registry communicates that it applied filters to be "out-of-band" of the image manifest response, so this doesn't need to be documented in image-spec at all.
Signed-off-by: Jason Hall<EMAIL_ADDRESS>

I feel this is a good change and as pointed out keeps the request semantics out of content/index. I feel we should merge this after  distribution spec changes have merged.


code style: naming convention

@steve0511 - current code uses cameCasing for most of the variables and function names. Most of the openresty/lua projects are using snake_case.
If you are ok, I can submit PR to refactor code to use snake_case consistently.

Sure, please submit anytime you are free

thanks - will submit soon!


log-collector-script Improvement

EKS Log collector - Improvement
What would you like to be added:

Include list of unused containers
Include list of unused images
Include checks for layers occupying most storage

Why is this needed:
To help in troubleshooting DIsk Pressure and Garbage Collection Issues

@berry2012 if you have an implementation in mind, feel free to open a PR. 😄

I'm going to close this; we shouldn't track feature requests for the log collection script without an implementation plan. Please open a PR if want. 👍


Update the twitter logo to X

This PR Closes Issue
closes #
Description
I updated the Twitter logo to "X," which is included in the latest PrimeIcons version. Therefore, I updated the package.json file to the latest versions of PrimeNG and PrimeIcons. This is my first time contributing to an open-source project, and I enjoyed working on these issues. However, for this particular issue , there was no defined issue type, so I couldn't follow the contributing guidelines exactly in the branch name
What type of PR is this? (check all applicable)

[ ] 🅰 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Mobile & Desktop Screenshots/Recordings
Mobile Version Screenshot :

Desktop Version Screenshot :

Steps to QA
Added to documentation?

[ ] 📜 README.md
[ ] 🙅 no documentation needed

[Optional] Post-deployment tasks
[Specify any post-deployment tasks that need to be performed]
[Optional] What gif best describes this PR or how it makes you feel?
[Embed gif or describe the feeling in plain text]

@MestiriBaha I have mentioned your PR in the closing PR #73 because I wanted to note your involvement and acknowledge that you have worked on the issue

@cleancodecraft , Thank you for clarifying !  about not noticing that the issue has already an assignee , I just was so excited to contribute and I felt it was an easy task so I just rush for it ! next time , I will be more attentive about the labels , I appreciate your efforts and I won't hesitate to ask you for any information before submitting a PR 🙂


fix: CTRL+C to terminate run

Fixes https://github.com/vitest-dev/vitest/issues/3569

Instead of listening for SIGINT, let's listen for keypress and decide how to handle CTRL + c. The process.on("SIGINT") seems to be too difficult to handle: https://github.com/vitest-dev/vitest/issues/3569#issuecomment-1600330892.
https://github.com/vitest-dev/vitest/assets/14806298/51099026-4727-44e7-96e1-6620da7a6a09
Windows + Powershell:
https://github.com/vitest-dev/vitest/assets/14806298/8c884681-2b03-40d1-9e08-9f286c02359d

Looks like this makes exiting run-mode stuck now... It's not visible on CI since it's not TTY. No idea how I missed that. @sheremet-va I'll need to fix this before next release. Looking into this now.
~/x/vitest/test/watch (main) $ pnpm run test --root fixtures --run

> @vitest/test-watch@ test /x/y/vitest/test/watch
> vitest "--root" "fixtures" "--run"

 RUN  v0.32.2 /x/y/vitest/test/watch/fixtures

 ✓ example.test.ts (1)
   ✓ getHello
 ✓ math.test.ts (1)
   ✓ sum

 Test Files  2 passed (2)
      Tests  2 passed (2)
   Start at  10:49:44
   Duration  162ms (transform 19ms, setup 0ms, collect 27ms, tests 2ms, environment 0ms, prepare 86ms)

close timed out after 10000ms
Tests closed successfully but something prevents Vite server from exiting
You can try to identify the cause by enabling "hanging-process" reporter. See https://vitest.dev/config/#reporters


Class names can't contain spaces

Describe the bug
You can't add multiple classes and separate them with spaces. This is what you get:
Uncaught (in promise) DOMException: Failed to execute 'add' on 'DOMTokenList': The token provided ('bg-gray-200 p-1') contains HTML space characters, which are not valid in tokens

So you can't style this with tailwind. Or keep the original class and add a bootstrap class to it. The strange thing is you can do this for container and containerOuter but nothing else.
To Reproduce
Steps to reproduce the behavior:
new Choices(element, {
  itemSelectText: '',
  removeItemButton: true,
  classNames: {
    containerOuter: 'choices bg-gray-200 focus:bg-gray-100 focus:shadow shadow-inner appearance-none rounded w-full text-gray-700 leading-tight',
    containerInner: 'py-1 px-3',
    input: 'bg-gray-200 p-1',
  },
});

Can confirm.

Can confirm as well (using tailwind).

Anyone found a workaround for this?

anybody gave a fix for this. It looks like this issue is for only certain classes and not all of them.
I face this issue when I add multiple classes to list, itemSelectable.

Is this still a bug? Bcz I try to add class with space to placeholder but it return a same error as the question


Add MO & Lazy Props to Accordion

@robdodson @devnook PTAL! Esp. at the architecture around MO!
When merged, set a checkmark in #55 & #85

I think it looks ok but I'm not a mutation observer expert. @azakus I'm sure your'e super busy but if you have any spare cycles to review this mutation observer implementation for an accordion that would be 🎂


Proxy server occasionally fails to flag regions as unallocated

The proxy server occasionally fails to flag a region as unallocated when a character located in that region connects to it. Even though a game server is polling for work in the background, it never is told that it should claim this region.

This should be fixed as part of the work around cleaning up region claim lifecycle; it's now behind a test.


Skeleton placeholder to be shown when loading content

Added the skeleton component with options based on https://flowbite.com/docs/components/skeleton/ as discussed.
Looking forward to your feedback :smiley:

Nice.. just one comment.


linera-core: simplify notification handling

Motivation
In order to refactor the ChainClient into a multi-chain Client and ChainClients that reference it, we need to have better control over the various notification-processing steps.

Proposal
Notifications from the LocalChainClient are in fact only ever generated by the ChainClients, so this PR removes the notification channel interface from LocalChainClient and moves responsibility for handling and dispatching notifications to chain clients into the client struct itself.
Currently this work is still duplicated per chain client, but a future PR will centralize it.

Test Plan
CI.

Release Plan
No user-visible changes.
Links

reviewer checklist

I don't understand the motivation: Conceptually, we want to make sure we send notifications whenever there's a new message, round or block for any chain. So I'd say we want that at the lowest level possible, which is in the local node.

Thanks for making me clarify my intuition! :grin:


Can't use expression as record to update

This doesn't work:
rec = {a = {b = 3}}
rec2 = {rec.a | b <- 4}
main = asText rec2
Parse error at (line 3, column 12):
unexpected "."
expecting whitespace, pattern or "="
The workaround I found is to use a let expression to declare a variable for rec.a.

Alright, I am closing in favor of https://github.com/elm-lang/elm-plans/issues/16 which will track a couple things along these lines. It's good to have them all in one place. Furthermore, I think it's not making sense to have proposals in the elm-compiler repo anymore, so I am laying the groundwork for doing this in a better way. For now, please let me manage elm-plans, no new stuff there!
If there is more to say about this, we should continue the discussion here, not in the elm-plans issue!

Oops, sorry. I looked there, but I guess I didn't parse the ticket properly. My bad.

I wish for this frequently. What's the argument against it?


Support "importing" resourceType and apiVersion mappings for specific resource types

can we allow for import of resourceType and/or apiVersion combinations for end users to declare resources without worrying as much about those details? essentially modules for types & apiVersions

Need more clarity on how important this is and how much modules could potentially help with this problem

Made suggestion in #413 that might be related to this.

Closing and tracking with #622