Restore service monitoring in all pypi based images

Impact of the bug
I discovered that when we moved to use pypi images we did not propagate process_export process within a pod. This leads to lost of service's specific metrics which Prometheus should scrape for service dashboards.
Describe the bug
In RPM based images we had monitor.sh script in docker images, e.g.

reqmgr2ms/monitor.sh
reqmgr2ms-unmerged/monitor.sh
etc.
Each monitor.sh script provides process_exporter process on service specific port which are used by Prometheus to scrape service metrics, e.g. see services/reqmgr2ms-unmerged.yaml for how we set Promethues scrapes (other services have similar line and dedicated port).

How to reproduce it
All pypi docker files does not have monitor.sh script and/or process_exporter executable.
Expected behavior
We should put back either monitor.sh script or process_exporter into pypi based images and use them at run.sh and manage. Therefore, the fix will require the following:

put back monitor.sh script and adjust it accordingly for each service Dockerfile
COPY process_exporter from exporters image to dmwm-base image such that each service image will have it
adjust run.sh and manage scripts to start monitor.sh one within a pod

Additional context and error message

The fix PR can be found here: https://github.com/dmwm/CMSKubernetes/pull/1301
I built and uploaded new dmwm-base image with these changes. The new tag is registry.cern.ch/cmsweb/dmwm-base:pypi-20230125.

The PR for using new dmwm-base image tag can be found here: https://github.com/dmwm/CMSKubernetes/pull/1302

I suggest to keep this issue open until we'll deploy and verify monitoring part of pypi based images in testbed or production.

@vkuznet Valentin, all the WMCore central services have just been upgraded to 2.1.8rc2, which uses the latest dmwm-base docker image.
The new image brings in the monitor.sh script, but I failed to find its process in a couple of pods that I connected. Could you please double-check this?

I checked and we still have a problem due to order in logic of run.sh script, see https://github.com/dmwm/CMSKubernetes/blob/master/docker/pypi/dmwm-base/run.sh#L77-L83, i.e. we start monitor.sh script before we start the wmc-httpd daemon. And, according to monitor.sh logic, https://github.com/dmwm/CMSKubernetes/blob/master/docker/pypi/dmwm-base/monitor.sh#L7, we first check presence of wmc-httd daemon. Therefore, to make monitor.sh to start the appropriate exporter we should change the order in run.sh script to first start wmc-http daemon and then start the monitor script. The current order came from original RPM based design which start monitor script after we call the manage script. I made necessary changes over here: https://github.com/dmwm/CMSKubernetes/pull/1328 Please review and we'll need to rebuild base image one more time to fix the problem.

We have good and bad news :)

the good news, the process exporter has started in dmwm pods and monitor.sh script runs fine, but
the bad news, since many MS services uses - in their app name, the process exporter fails with the following error:

panic: descriptor Desc{fqName: "process_exporter_ms-monitor_process_cpu_seconds_total", help: "Total user and system CPU time spent in seconds (process collector)", constLabels: {}, variableLabels: []} is invalid: "process_exporter_ms-monitor_process_cpu_seconds_total" is not a valid metric name
....

which means that dashes are not allowed in metric names (since dash is interpreted as minus sign). I fixed issue with this PR https://github.com/dmwm/CMSKubernetes/pull/1331 and it means we'll need once again after its merge rebuild base image, and then use another PR to rebuild all MS images with new base image tag.

Finally, I"m happy to report that after deploying 2.2.0rc3 release version images to testbed we got back MS service monitoring plots. All of them can be found in this dashboard:
https://monit-grafana.cern.ch/d/JIz-EqvVz/wmcore-ms-services?orgId=11&refresh=1m&var-env=k8s-preprod&var-service=All&var-app=All&from=now-15m&to=now
where you'll need to select proper env (e.g. k8s-preprod) and your service (you may select multiple or all). I can see now metrics for testbed and when we put this into production they will appear as well.
@amaltaro , please have a look and we may close this ticket.

Yes, it looks like this issue has finally been resolved. I noticed that the "service" drop down menu starts with "process_exporter_*" though. One can clearly still see to which service each of those relate to, but if we had an alias/renaming to map to the actual service, that would be better. I think we can close this ticket though, doing so.

Yes, it should be fixed at CMS monitoring side, I created appropriate ticket CMSMONIT-530

As discussed in this ticket:
https://its.cern.ch/jira/browse/CMSMONIT-540
the reason for some of the alerts for ReqMgr2 is apparently associated to the fact that not all of the ReqMgr2 PODs are actually running process_exporter. Out of all the 6 reqmgr2-* PODs, I found one that didn't have it running (not clear to me why not!)
On what concerns reqmon, I confirm that process_exporter is not running and there is an error message when looking into the kubernetes logs. I will provide a fix to the dmwm-base image later today/tomorrow.

I have just created some test containers with tag pypi-20230525-alan and tested it with reqmgr2/reqmon/global-workqueue and they are now all starting the process_exporter and the prefix is correctly using the app name.

Hopefully this was the last fix on this topic, provided with:
https://github.com/dmwm/CMSKubernetes/pull/1381
and the PR mentioned in it.


Enable GOPROXY default in Makefile

/kind bug
We are forcing GOPROXY=https://proxy.golang.org in the Makefile but really we should first, default to go env GOPROXY and use that if it's set. If that's not set then use https://proxy.golang.org
/priority important-longterm
/milestone v0.1

/assign


ModuleNotFoundError: No module named 'azure.confidentialledger.certificate'

[Enter feedback here]
Following the quick start and install the ACL data plane client library
pip install azure.confidentialledger
it will install the version 1.0.0b1
azure-confidentialledger      1.0.0b1
which will raise the error when I run the example.
from azure.confidentialledger.certificate import ConfidentialLedgerCertificateClient
ModuleNotFoundError: No module named 'azure.confidentialledger.certificate'
After uninstall 1.0.0b1 and install 1.0.0 the error is gone.
pip install azure-confidentialledger==1.0.0
Please update the quick start document with the specified version. or please make sure the 1.0.0b1 is compatible with 1.0.0

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ffba32ba-d527-419f-ae4f-7984625843e5
Version Independent ID: eb3c659d-380f-579e-1b83-8913e03e81af
Content: Quickstart – Microsoft Azure confidential ledger Python client library
Content Source: articles/confidential-ledger/quickstart-python.md
Service: confidential-ledger
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@clin4
Thanks for your feedback! We have assigned the issue to author and will provide further updates..


Add support for specifying the UI testing screenshot behavior in a scheme test action

Resolves #941

I'm guessing that the Xcode 12 job was recently added? The failure looks unrelated to this PR.


editor.rangeHighlightBackground appears then disappears when stepping through search results

Type: Bug
When stepping through search results the line highlight disappears sometimes. It happens when the next result is in a different file from the previous result and a different editor has to be brought into view. It also depends on the text in the file. Despite the fairly specific circumstances, this happens essentially 100% of the time in real world scenarios. I see it for basically any non trivial file and it's obviously extremely common to have search results across many files.
It appears to be a "race" of some sort. It always happens ~200 ms after the new editor is brought into view, even if you've stepped through multiple results in the file by then.
I have a hard time seeing which search result is being focused when stepping through the list due to the way highlights are blended and the lack of line highlights. I'm trying to poke at some settings to improve the situation for myself and I tracked this down as part of the cause of the missing line highlights.
In this gif I'm only pressing up and down, nothing else.

VS Code version: Code - Insiders 1.76.0-insider (c7930ca55d072608625ba76c13b5f9baaf9a2136, 2023-02-10T16:22:19.445Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Sandboxed: Yes

System Info

Item
Value

CPUs
AMD Ryzen 9 5950X 16-Core Processor             (32 x 3400)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
31.92GB (19.97GB free)

Process Argv
--crash-reporter-id 22cf4e37-a96e-4ad9-82f0-8715f8e2bf6e

Screen Reader
no

VM
0%

Extensions: none
A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30422396
pythontb:30258533
pythonptprofiler:30281269
vsdfh931cf:30280410
vshan820:30294714
pythondataviewer:30285072
vscod805cf:30301675
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30404738
cppdebug:30492333
vsclangdf:30492506
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30618038
pylantcb52:30590116
pyindex848:30611229
nodejswelcome1:30587009
pyind779:30611226
pythonsymbol12:30651887
2i9eh265:30646982
showlangstatbar:30659908
pythonb192cf:30661257

I haven't found a minimal repro yet, but I'm also seeing this happen any time an editor has to scroll to reveal the position of the next result.


构建N_body数据集时system.py文件的报错

尊敬的作者，您好！
最近我在复现您有关GMN论文的相关代码，在克隆代码进行运行后，构建初始n_body数据集时：
GMN-main/spatial_graph/n_body_system/dataset/system.py文件的第89行出现代码错误：
l2_dist_power3 = np.power(
self._l2(X, X), 3. / 2.)
错误信息为：
py:89: RuntimeWarning: invalid value encountered in power
初步排查时power函数并不支持基数为负数，不知道这个问题是我这边的操作不当问题还是原有的代码问题？不知您是否有空解答我的问题，万分感谢！

Hi coastes!
First of all, please note that the "error information":
py:89: RuntimeWarning: invalid value encountered in power
is only a RuntimeWarning and does not interrupt the running of the dataset generation script. That is to say, you can continue to run the script and obtain the generated dataset.
The reason why there is such a warning is that line 89 in system.py is basically computing the interaction strength of the Columbian force,  which is proportional to  $\frac{\vec{r}}{r^3}$,
where $r$ is the relative position between two nodes.
Therefore, when computing the matrix $\frac{1}{r^3}$,
the diagonal (accounting for the distance between the same node) will be $\frac{1}{0}$, which automatically triggers the warning. However, this does not affect the correctness since afterward the diagonal will be refilled by zeros (see line 95 of dataset.py), and the nans will eventually become zeros in the following computation.
Summary: This is only an expected warning which does not terminate the program, and there's no bug in the code here. You can still safely run the script for data generation.

Thanks for your answer, it solved my question successfully!

Glad to hear about that!
I am closing the issue for now since it has been resolved.


fix: bug on resource that is not deployed

Prototyping of atomicity property on create / update resource

Closing this as it is not needed will be taken care as part of resource bounded context.


Curate top level exports

Blocked by #44.
It should be possible to use Argo simply by importing Argo. That means defining HasCodec instances, encoding JSON, and decoding JSON. Potentially also using pointers, but perhaps that should be a separate import.

I would be nice to include something like (<|>) in order to combine codecs together.

It might be useful to look at what I re-export here: https://github.com/tfausak/rattletrap/blob/6660ace7b6bae60ecd56a9350cab9e7f3bb4cdc6/src/lib/Rattletrap/Vendor/Argo.hs#L1


My first revup bar

Topic: bar

Reviews in this chain:
└https://github.com/aurimas-balciunas-skydio/revup_clone/pull/2 My first revup bar

#
head
base
diff
date
summary

0
ce8f8627
740c5cdb
diff
Jul 11 15:54 PM
1 file changed, 1 insertion(+)


Write a C++ program to calculate the permutation of n objects taken r at a time

Description
Write a C++ program to calculate the permutation of n objects taken r at a time
Permutation is an arrangement of objects in a particular order. The number of permutations on n objects taken r at a time is given by the formula n!/(n-r)!
Input  : 5, 2
Output : 20

How to contribute

Save the solution in program/CalculateThePermutationOfNObjectsTakenRAtATime.cpp file
Add CalculateThePermutationOfNObjectsTakenRAtATime.cpp file in calculate-the-permutation-of-n-objects-taken-r-at-a-time folder

!assign


Redundancy should be 2 by default

When we set redundancy 1 in examples all users also end up burning themselves by redundancy 1.
@jobergum fyi

Seems like most of the non-cloud sample apps have just one node, I think you need to add a node to those as well

@hmusum I tested https://docs.vespa.ai/en/vespa-quick-start.html with redundancy=2 and no other changes - it worked, so will merge this now


Improve new chat notification highlighting

See pink circles:

Ok, now I've got it. The green colored tab is the indication. So this is not a bug.

So what do you thing needs to be done...?

We could add a badge or at least a (1) to the channel tab, I always wanted that. Let's rename the issue accordingly

I suggest to remove the green color or change it to another color at least. It's very confusing because the active tab also uses green as indication, just as an underline. Better would be to either add (count) in red to the bell or to the chat tab as micheljung already commented :smile: .

Color confusion no longer applicable


fc-date parsing for timeline span/div tags

Resolves #97
Given a Timeline span or div with attributes:
<span
    class='ob-timelines'          // ignored (obsidian timelines plugin format)
    data-type='range'             // ignored (obsidian timelines plugin format)
    data-date='144-43-49-00'      // ignored (obsidian timelines plugin format)
    data-end='2000-10-20-00'      // ignored (obsidian timelines plugin format)
    data-fc-date='144-Ches'       // FC: short/mixed (day, hour assumed 0)
    data-fc-end='144-Ches-03-07'  // FC: long/mixed
    data-title='Another Event'
    data-class='orange'
    data-img = 'Timeline Example/Timeline_2.jpg'>
    Event description
</span>

FC Timeline date form has at most 4 segments. THey always starts with the year: yyyy-(mm|mmm)-dd-hh.

closed to retarget timelines branch


Playlist autoplay next video - possible to default off?

Every time I open a video from a playlist (including my Youtube favorites) I have to manually turn off the autoplay so it doesn't jump to the next video when the current one ends. Would it be possible to add an option to force this to default to off? (If it already exists, I can't find it in the current dev version.)

@clst The script won't work anymore. :(
If you guys have a solution...

Yes, my script is broken, but YouTubeCenter worked here yesterday.
I don't know if Youtube broke it again though.


Implement multiple blit pipeline to support multiple target formats

@TheSpydog is this conflicting with #162 ?

Yeah, unfortunately this is incompatible with the approach we'll need to take for #162.
Rather than using a fixed array of pre-populated pipelines, we'll need to use a dynamic cache of pipelines, like we do for the Metal driver. Creating 1 pipeline for every texture format upfront is overkill since most applications will likely only use a very small handful of possible formats, so multiplying that by 3 additional permutations (2D, 2DArray, Cube) is definitely more time/memory than we need to spend.
Additionally, we won't need to have a dedicated function for determining "blittability" since we can just check if the format is supported as a sampler and color target. That should cut down on the amount of bespoke code for blits, and the validation can take place in SDL_gpu.c rather than in the backends.

Alright, closing in favor of #162.


Fixed misprint

SCWDP stays for Sitecore web deploy package.
I think it is a misprint in the folder name.

Thanks for the fix @Antonytm , should indeed be wdp for web deploy package.... typo it is.


Export aggregate raid status

Is your feature request related to a problem? Please describe.
It would be ideal if harvest would export aggregate raid status, currently there's no way to tell if an aggregate is in a degraded or reconstructing state.
Describe the solution you'd like
https://github.com/NetApp/harvest/blob/ff83da0f1e38cc5f5502c806ba307b8333ec345f/conf/zapi/cdot/9.8.0/aggr.yaml#L12 currently only exports state . The SDK doesn't report degradation under the state attribute, attribute raid-status is used to summarise overall plex status in an aggregate if its rebuilding or degraded.
Using this value is a bit tricky as the values reported by that attribute can appear by themselves or comma separated, generally they are reported as
"raid type, hybrid?, status"
(I am not sure if the order of the comma separated values is always the same, on my infrastructure I have always noticed the return value is raid_type, hybrid?, raid_status)
Example Hybrid aggregate with normal raid status:
raid-status            : raid_dp, hybrid, normal
Example standard aggregate with normal raid status:
raid-status            : raid_dp, normal
Reference from sdk

Describe alternatives you've considered
I looked at using the split plugin but I don't think it would work since then number of values is not always constant.
Possible to use split_regex if raid-status is included (example below assumes raid-status is renamed to raid_status)?
split_regex: raid_status (normal|copying|degraded|foreign|growing|mirror_degraded|parity|out-of-date|reconstruct|resyncing) raid_status. Not a very elegant solution but might get around it.

I managed to get this working by copying the existing zapi aggregate template and exporting the raid-status attribute
I added the following to the custom template
plugins:
  LabelAgent:
    value_mapping: status state online `1`
    # metric label zapi_value rest_value `default_value`
    value_to_num: new_status state online online `0`
    split_regex: raid_status `(normal|copying|degraded|foreign|growing|mirror_degraded|parity|out-of-date|reconstruct|resyncing)` raid_status
    value_to_num: raid_status raid_status normal normal `0`

export_options:
  instance_keys:
    - aggr
    - node
  instance_labels:
    - type
    - state
    - raid_status

This added a new raid_status label to aggr_labels with the regex value and a new time series aggr_raid_status with the value to num mapping for raid_status
I found that with harvest version 21.08.0 that custom templates just override the existing ones, so I had to copy all the contents from the default aggr.yaml instead of being able to just extend it with some extra attributes.

@hashi825 awesome! glad you got it working. we're going to improve the template override and extension behavior.
@rahulguptajss is working on updating the documentation for how we want it to work and we'll review with you to make sure it better covers your use-case.

@hashi825 I have created a new feature request for handling template merging @ https://github.com/NetApp/harvest/issues/493

@hashi825 does #493 cover what you need?


[Feature Request] Componentless named routes

As per the docs

Each route should map to a component.

Use case: I have an a link tag which has a v-on:click event handler. I don't want to omit the href attribute though, so I have to add the v-link attribute as well. But I think it's good practice to not hardcode URLs into links. So what I did was to create a named route. Since named routes are all defined in one place it's very easy to refactor if the URLs might change in the future. The names of the routes should be permanent anyway.
As a quick workaround I did this:
'/auth/register': {
  name: 'auth.register',
  component: {}
}

If I were to omit the component: {} property, it would throw warnings. Is it intended to have named routes without components, and is there a better way of doing this than I did? If not, is this a feature that's going to be added?

Not sure if that's a proper use case - technically this is not what vue-router is for. Component-less routes will make your router-view empty, is that what you want? If not, then you should not be using v-link for this purpose. You can treat this path as global state if you want to avoid hard coding URLs.

... technically this is not what vue-router is for ...

Oh, ok? Can I elaborate on the use case? Lets assume you would create this example with static pages (or php or whatever)... for example:
I have a list of tasks (task: id, name, date, 'done by'). This list is reachable under /tasks. A task defines a link to a GET method on the server /task/:taskId/select, that updates the 'done by' field to the current user, and then sends a redirect to show the task on /task/:taskId.
Using vue-router, the router-view would contain my list. When I click on the link an ajax request is sent to the method, and on success I redirect the client to the task itself. In this particular use case it wouldn't matter if the router-view is empty or not. I could of course hardcode the link into the href attribute of the a tag but that just feels wrong.
Also, I don't quite understand what you mean by:

You can treat this path as global state if you want to avoid hard coding URLs.

Are you using redirects to send GET requests?
My understanding of your steps:

Open /tasks, it maps to a component that lists tasks
Click one task, you need the router to redirect to /task/:taskId/select (which doesn't map to a component), and then redirect to /task/:taskId

The problem is you shouldn't be sending GET requests by manipulating url. We normally use an http client (fetch, vue-resource, etc.)
It shouldn't work in the first place because when you use front-end routing, it doesn't send a GET request to the server when the url change.
If you actually use an http client, that would be a non-issue:

Open /tasks, it maps to a component that lists tasks
Click one task, send a GET request (/task/:taskId/select) to the API, redirect to /task/:taskId on the callback (or promise.then()).


org.neo4j.ogm.exception.core.MappingException: Error mapping GraphModel

I have a blocking problem, which occurs erratically with neo4j and ogm.
Expected Behavior
For example load a node entity by it's ID : using the load method of NeoSession class.
But problem occurs also in function query of NeoSession class .
Current Behavior
Exception occured  with root cause
java.lang.NullPointerException: null
       at org.neo4j.ogm.session.Utils.coerceTypes(Utils.java:79)
       at org.neo4j.ogm.metadata.FieldInfo.write(FieldInfo.java:463)
       at org.neo4j.ogm.context.GraphEntityMapper.mapOneToMany(GraphEntityMapper.java:478)
       at org.neo4j.ogm.context.GraphEntityMapper.mapRelationships(GraphEntityMapper.java:334)
       at org.neo4j.ogm.context.GraphEntityMapper.mapContentOf(GraphEntityMapper.java:154)
       at org.neo4j.ogm.context.GraphEntityMapper.lambda$map$1(GraphEntityMapper.java:106)
       at org.neo4j.ogm.context.GraphEntityMapper.map(GraphEntityMapper.java:111)
       at org.neo4j.ogm.context.GraphRowModelMapper.map(GraphRowModelMapper.java:55)
       at org.neo4j.ogm.session.delegates.LoadOneDelegate.lambda$load$0(LoadOneDelegate.java:90)
       at org.neo4j.ogm.session.Neo4jSession.doInTransaction(Neo4jSession.java:584)
       at org.neo4j.ogm.session.Neo4jSession.doInTransaction(Neo4jSession.java:558)
       at org.neo4j.ogm.session.delegates.LoadOneDelegate.load(LoadOneDelegate.java:87)
       at org.neo4j.ogm.session.Neo4jSession.load(Neo4jSession.java:183)
       at com.oxway.store.neo4j.Neo4jOGMDao.findOne(Neo4jOGMDao.java:387)

Context
On the same data, the method works the x first times and then failed every times. It's a strange behavior, has no reproducible.
After the problem occurs a first time other function using ogm have null pointer exception errors.
Your Environment

Java version: openjdk version "11.0.13" 2021-10-19
Neo4j version (The version of the database): 3.5.14
OGM Version (The version of this software): 3.2.37
OGM Transport used (One of Bolt, HTTP or embedded): 3.2.37
Neo4j Java Driver version (in case of Bolt transport): 4.0.3

Thanks for your help

With more investigation I found the problem is due to the class org.neo4j.ogm.metadata.DescriptorMappings. For a reason I ignore in the method getType() :
`  public static Class<?> getType(String descriptor) {
    Optional<Class<?>> optionalType = descriptorsToTypeMappingCache
        .computeIfAbsent(descriptor, k -> Optional.ofNullable(computeType(descriptor)));

    // Recompute type when it has not been computed or the cached version was loaded with a different classloader.
    boolean needsRecomputation = optionalType
        .map(type -> type.getClassLoader() != null && !isLoadedInSameHierarchy(type))
        .orElse(false);

    if (needsRecomputation) {
        optionalType = Optional.ofNullable(computeType(descriptor));
        descriptorsToTypeMappingCache.put(descriptor, optionalType);
    }
    return optionalType.orElse(null);
}`

during execution needRecomputation is true and the new computed optionalType is empty. So the introspection failed and the type of my object is not return correctly.
Any idea to how resolve this problem ?

Thanks for reporting this. And your observation is spot on and quite interesting because we have just fixed the error you are reporting by enforcing checking the class loader chain before needsRecomputation will be true. Reason for this was that we had a strict class loader check in place that would run into this problem on deployments.
This check was just introduced.
Two questions come up (simple and more complex ;) ):

Are you 100% sure that also the deployment uses 3.2.37? Yes, the class you are referring to in the second comment is definitely the current version, but what about the error producing application?
If you are sure about (1): Could you debug into the isLoadedInSameHierarchy method to figure out why this returns false? Also in this case it would be good to get a little bit of background about your deployment of the application (e.g. Spring or Quarkus application or other things that give us a picture of how to possible reproduce your issue).


iOS SDK Version

Hi,
I'm currently trying to use this library in our React Native app, and seems to have successfully implemented receiving notifications and inbox on iOS.
However, when releasing on testflight, on the dashboard the SDK Version is incorrect, showing our App Version Number instead, e.g. my app version is 2.6.1, SDK version shows 2.6.1 as well, and if I change the app version to 3.0.0, it will show as 3.0.0
Any ideas on how I could fix this?
Thanks.

Hi @j-cheung,
As mentioned in the support channel, we were able to reproduce the issue and will let you know when it's available.

Hi @j-cheung,
As mentioned in the support channel, we were able to reproduce the issue and will let you know when it's available.

Thanks, do you reckon it would affect the functionalities though?

Depending on your app version this may cause some functionality to misbehave.
Considering your version is 2.6.1 you're safe.
Anyhow, we have a patch released planned for Monday which will fix this.
You should update it once available.

I see, thank you for your quick response!

Hi @j-cheung,
v3.0.1 has been released containing a fix for this issue on the native side.
I'm closing this issue.

thanks i will check it out!


Add files via upload

add afro asian institute

added

@shehrozjaved546 First stage of verification passed, official domain is afroasian.edu.pk as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@shehrozjaved546 The website of the Institute lacks significant information about the offered courses.
Thus, we cannot verify whether the institute qualifies for the trusted list in this repository.
I have to close the request without merging.
Please apply for free educational license with an official document which proves that you are a student. You can do it using "OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students.
Thank you for your understanding!


feat:check endpoint effective & prevent recursive forwarding

Codecov Report

Merging #127 (0c79a07) into main (99cdb31) will decrease coverage by 0.28%.
The diff coverage is 23.80%.

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   37.75%   37.47%   -0.29%
==========================================
  Files          12       12
  Lines         829      862      +33
==========================================
+ Hits          313      323      +10
- Misses        473      494      +21
- Partials       43       45       +2

Impacted Files
Coverage Δ

client/target.go
0.00% <0.00%> (ø)

cmd/gateway/main.go
10.60% <0.00%> (ø)

client/factory.go
15.62% <45.45%> (+15.62%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99cdb31...0c79a07. Read the comment docs.


Relocation(?) incorrect on MOV.W and RCALL instructions

In the module sqrt.eo from the xc16 library libm-elf.a, there are a couple of disassembly problems that I think might have something to do with relocation entries that aren't handled correctly--but I could be wrong about that.

Where the source file sqrt.s has the following mov instructions:

     mov.w   #WREG11,w13             ; (w13) = &t
     mov.w   #WREG3,w14              ; (w14) = &q

and the Microchip assembly listing has:
 136 000044  0D 00 20 	        mov.w   #WREG11,w13             ; (w13) = &t
 137 000046  0E 00 20 	        mov.w   #WREG3,w14              ; (w14) = &q

Ghidra's disassembler listing shows an immediate value for the source operands:
                    rom:010044 1d 80 20 00     mov.w                          #0x801,W13
                    rom:010046 2e 80 20 00     mov.w                          #0x802,W14

Where the source file has

    rcall   __dpack

(dpack is an external symbol), and the Microchip assembly listing has:
 191 00008e  00 00 07 	        rcall   __dpack                 ; Round and pack

Ghidra has:
                    rom:01008e b9 03 07 00     rcall                          WREG3             undefined WREG3()

I'm attaching the source file as it comes from Microchip, the object module extracted from the library, and an archive of the sample Ghidra project (with the extension changed from .gar to .zip to please github.)
sqrt.s.txt
sqrt.eo.zip
GhidraSupport-sqrt.o-20210419.zip

have you looked at the Window->Relocation Table to check if there's an entry for that address?  It has the location/type/value/original bytes (also has the new bytes, but not default)

That's a good idea, @mumbel. It would help to isolate the problem, and having relocation entries would probably make it easier to write a script to repair the errors.

There are relocations for both of the MOV instructions
Location       | Type | Values | Original Bytes | Name
rom:010044     | 0x8   | 0xdd   | 0d 00 20 00    | WREG11
rom:010046     | 0x8   | 0xde   | 0e 00 20 00    | WREG3
rom:00108e     | 0x1c  | 0xdf   | 00 00 07 00    | __dpack

So, I think Ghidra is getting these relocations wrong. Note that the entries in the "Name" column are what they should be.

My first guess is that the WREG11 and WREG3 symbols have been defined improperly.   I would think these should be register locations defined by the language (but we name them differently (W0..W15 instead of WREG0..WREG15).  Since they are not found as registers, they are treated like external symbols at an unknown location and placed in the  EXTERNAL block at arbitrary locations - which apparently are too large for the instructions to handle properly.  I will have to look into this further when I have more time.  Hopefully we can specify these names as an alias within the psec.

While I have a possible solution which can get the correct constant value for relocation processing.  Markup of the instruction is another matter.   Result:
      rom:010044 6d 01 20 00     mov.w      #0x16,W13
      rom:010046 6e 00 20 00     mov.w      #0x6,W14

This was accomplished by allowing the WREG names to be assigned as an alias for the W named registers (e.g., WREG11 alias for W11).

After running the script I wrote (CreateRelocationBasedOperandReferences) the code gets an appropriate reference applied to the operands:
      rom:010044 6d 01 20 00     mov.w      #WREG11,W13
      rom:010046 6e 00 20 00     mov.w      #WREG3,W14

Does this also take care of the anomalous rcall WREG3 which should be rcall __dpack?

I am working on that now.  This may stem from an alignment issue for fabricated addresses within the EXTERNAL block.


feat: add commitmsgfmt

formatters_by_ft = {
    ...
    gitcommit = {"commitmsgfmt"},
}

Thanks for the PR!


[SPARK-42960] Add await_termination() and exception() API for Streaming Query

What changes were proposed in this pull request?

Add the await_termination() and exception() to streaming query class.
For exception, only pass the message the same way in SparkConnectService, and construct the error the same way as the convert_exception method in _handle_rpc_error in client.py.
For await_termination, send the command multiple times instead of waiting to prevent RPC timeout. <-- I'm definitely open to any discussion on its implementation!
Why are the changes needed?

Add missing APIs.
Does this PR introduce any user-facing change?

Yes but part of ongoing developing of Streaming Spark Connect.
How was this patch tested?

Existing unit tests. Note that the unit tests for them are still skipped because of 1. queryManager is not implemented. 2. Allow access to stopped query is not implemented.
I was able to test them manually by

For test_stream_await_termination(), comment out the

for q in self.spark.streams.active:
    q.stop()

For test_stream_exception(), comment out unregistering terminated query:
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala#L411

@HyukjinKwon @rangadi @pengzhon-db

@WweiL mind rebasing this one please?

Merged with master. I noticed stack trace was added. I'll create a SPARK ticket to include it

@hvanhovell or @grundprinzip actually mind taking a look please when you find some time?

I see .. sorry for a bit of back and forth:
python/pyspark/sql/connect/streaming/query.py:72: error: Missing return statement  [return]
python/pyspark/sql/connect/streaming/query.py:108: error: Missing return statement  [return]
python/pyspark/sql/connect/streaming/query.py:140: error: Missing return statement  [return]

Let's add them back :-) ..

@HyukjinKwon Can you merge this : ) Thanks!

Merged to master.


413 Request Entity Too Large

Julian just tried to upload a leaflet to electionleaflet.org from his Samsung Galaxy S5 phone.
Worked well (preview and camera button stuff was good) until hitting submit. Then it paused for ages and said:
413 Request Entity Too Large
It's an nginx error message. I think it is the setting client_max_body_size which appears to default to 1Mb http://nginx.org/en/docs/http/ngx_http_core_module.html - Julian says the file is about 5Mb.
He reckons you should anyway be downscaling it for fast upload anyway - phones are too high resolution these days. Can you just tell the browser that?

5000 by 3000 pixels is the camera setting!

It's set to HUGE VALUE on old site, so it must be the new version you're testing?   I think most of the mobile work is happening at https://github.com/DemocracyClub/electionleaflets


Bug

Microsoft PowerToys version
<IP_ADDRESS>
Running as admin

[X] Yes

Area(s) with issue?
General
Steps to reproduce
Version: <IP_ADDRESS>
OS Version: Microsoft Windows NT 10.0.19044.0
IntPtr Length: 8
x64: True
Date: 23-Nov-21 8:18:27 PM
Exception:
System.OperationCanceledException: The operation was canceled.
at System.Threading.CancellationToken.ThrowOperationCanceledException()
at PowerLauncher.ViewModel.ResultsViewModel.AddResults(List`1 newRawResults, CancellationToken ct)
at PowerLauncher.ViewModel.MainViewModel.ColdStartFix()
at PowerLauncher.App.<>c__DisplayClass14_0.b__0()
at Wox.Infrastructure.Stopwatch.Normal(String message, Action action)
at PowerLauncher.App.OnStartup(Object sender, StartupEventArgs e)
at System.Windows.Application.OnStartup(StartupEventArgs e)
at System.Windows.Application.<.ctor>b__1_0(Object unused)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
✔ Expected Behavior
To get this fixed
❌ Actual Behavior
It basically showed this bug report
Other Software
No response

Could you attach a full bug report file?
Right-click on the tray icon and click Report Bug. Then drag-and-drop the generated file into the GitHub comment to upload it. Thanks!


devicelab win arm machines having OS issues

@kentnguyen99 please check the new windows arm bots.
win-7 seems to be functioning correctly. Example, run command to find location of cmd.exe:
where cmd.exe
and it returns as expected. Other new bots (e.g. win-10) is having problems:
where cmd.exe
'where' is not recognized as an internal or external command,
operable program or batch file.

Please check the windows version information of win-11 and paste here. Win-7 version info:
>systeminfo | findstr /i "OS Version"
Host Name:                 FLUTTER-WIN-7
OS Name:                   Microsoft Windows 11 Pro
OS Version:                10.0.22621 N/A Build 22621
OS Manufacturer:           Microsoft Corporation
OS Configuration:          Standalone Workstation
OS Build Type:             Multiprocessor Free
System Manufacturer:       Microsoft Corporation
BIOS Version:              Microsoft Corporation 7.31.139, 1/1/1601

@kentnguyen99 during setup of the devices, was there anything that you performed differently between the initial win-7 machine and the others?

All Arm Windows has been resolved and fixed, it was "Windows Environment  Path" missing %SystemRoot%\system32.


CANT RUN BOT errors  pokecli.py and others

Expected Behavior
start bot
Actual Behavior
(PokemonGo-Bot) root@oldtimes:~/PokemonGo-Bot# ./run.sh
2016-08-08 12:21:03,129 [       cli] [INFO] PokemonGO Bot v1.0
2016-08-08 12:21:03,132 [       cli] [INFO] Configuration initialized
2016-08-08 12:21:03,132 [pokemongo_bot.health_record.bot_event] [INFO] Health check is enabled. For more information:
2016-08-08 12:21:03,132 [pokemongo_bot.health_record.bot_event] [INFO] https://github.com/PokemonGoF/PokemonGo-Bot/tree/dev#analytics
2016-08-08 12:21:03,136 [requests.packages.urllib3.connectionpool] [INFO] Starting new HTTP connection (1): www.google-analytics.com
2016-08-08 12:21:03,232 [PokemonGoBot] [INFO] [set_start_location] Setting start location.
Traceback (most recent call last):
File "pokecli.py", line 503, in
main()
File "pokecli.py", line 131, in main
report_summary(bot)
File "pokecli.py", line 140, in report_summary
metrics.capture_stats()
File "/root/PokemonGo-Bot/pokemongo_bot/metrics.py", line 76, in capture_stats
response_dict = request.call()
File "/root/PokemonGo-Bot/pokemongo_bot/api_wrapper.py", line 90, in call
if not self.can_call():
File "/root/PokemonGo-Bot/pokemongo_bot/api_wrapper.py", line 54, in can_call
raise NoPlayerPositionSetException()
pgoapi.exceptions.NoPlayerPositionSetException
2016-08-08 12:21:03,369 [sentry.errors] [ERROR] Sentry responded with an error: 'ascii' codec can't decode byte 0x9c in position 1: ordinal not in range(128) (url: https://app.getsentry.com/api/90254/store/)
Traceback (most recent call last):
File "/root/PokemonGo-Bot/local/lib/python2.7/site-packages/raven/transport/threaded.py", line 174, in send_sync
super(ThreadedHTTPTransport, self).send(data, headers)
File "/root/PokemonGo-Bot/local/lib/python2.7/site-packages/raven/transport/http.py", line 47, in send
ca_certs=self.ca_certs,
File "/root/PokemonGo-Bot/local/lib/python2.7/site-packages/raven/utils/http.py", line 66, in urlopen
return opener.open(url, data, timeout)
File "/root/PokemonGo-Bot/local/lib/python2.7/site-packages/future/backports/urllib/request.py", line 494, in open
response = self._open(req, data)
File "/root/PokemonGo-Bot/local/lib/python2.7/site-packages/future/backports/urllib/request.py", line 512, in _open
'_open', req)
File "/root/PokemonGo-Bot/local/lib/python2.7/site-packages/future/backports/urllib/request.py", line 466, in _call_chain
result = func(*args)
File "/root/PokemonGo-Bot/local/lib/python2.7/site-packages/raven/utils/http.py", line 46, in https_open
return self.do_open(ValidHTTPSConnection, req)
File "/root/PokemonGo-Bot/local/lib/python2.7/site-packages/future/backports/urllib/request.py", line 1284, in do_open
h.request(req.get_method(), req.selector, req.data, headers)
File "/usr/lib/python2.7/httplib.py", line 1048, in request
self._send_request(method, url, body, headers)
File "/usr/lib/python2.7/httplib.py", line 1088, in _send_request
self.endheaders(body)
File "/usr/lib/python2.7/httplib.py", line 1044, in endheaders
self._send_output(message_body)
File "/usr/lib/python2.7/httplib.py", line 886, in _send_output
msg += message_body
UnicodeDecodeError: 'ascii' codec can't decode byte 0x9c in position 1: ordinal not in range(128)
2016-08-08 12:21:03,371 [sentry.errors.uncaught] [ERROR] [u'NoPlayerPositionSetException', u'  File "pokecli.py", line 503, in ', u'  File "pokecli.py", line 131, in main', u'  File "pokecli.py", line 140, in report_summary', u'  File "pokemongo_bot/metrics.py", line 76, in capture_stats', u'  File "pokemongo_bot/api_wrapper.py", line 90, in call', u'  File "pokemongo_bot/api_wrapper.py", line 54, in can_call']
(PokemonGo-Bot) root@oldtimes:~/PokemonGo-Bot#
Steps to Reproduce
./run.sh
normal use
Other Information
OS:  Ubuntu 15.04 (GNU/Linux 3.19.0-49-generic x86_64)
Git Commit: (run 'git log -n 1 --pretty=format:"%H"' and paste it here)
ff380cd0e07f225ad1ae2c739bea9f9f80e2f8ce
Python Version: (run 'python -V' and paste it here)
Python 2.7.9

Have you set your config.json with location?
Wipe out sensitive data and paste your config.json if you can.

2016-08-08 12:21:03,371 [sentry.errors.uncaught] [ERROR] u'NoPlayerPositionSetException

{
"auth_service": "google",
"username"<EMAIL_ADDRESS>"password": "GMAILpassword",
"location": "country??",
"gmapkey": "AIzaSyBbaDXLl8KtKy79CFcbA4VnY9FrRbVm7iI",
"libencrypt_location": "",
"tasks": [
{
"type": "HandleSoftBan"
},
{
"type": "CollectLevelUpReward"
},
{
"type": "IncubateEggs",
"config": {
"longer_eggs_first": true
}
},
{
"type": "TransferPokemon"
},
{
"type": "EvolvePokemon",
"config": {
"evolve_all": "none",
"first_evolve_by": "cp",
"evolve_above_cp": 500,
"evolve_above_iv": 0.8,
"logic": "or",
"evolve_speed": 20,
"use_lucky_egg": false
}
},
{
"type": "RecycleItems",
"config": {
"item_filter": {
"Pokeball":       { "keep" : 100 },
"Potion":         { "keep" : 10 },
"Super Potion":   { "keep" : 20 },
"Hyper Potion":   { "keep" : 30 },
"Revive":         { "keep" : 30 },
"Razz Berry":     { "keep" : 100 }
}
}
},
{
"type": "CatchVisiblePokemon"
},
{
"type": "CatchLuredPokemon"
},
{
"type": "SpinFort"
},
{
"type": "MoveToFort",
"config": {
"lure_attraction": true,
"lure_max_distance": 2000
}
},
{
"type": "FollowSpiral",
"config": {
"diameter": 4,
"step_size": 70
}
}
],
"map_object_cache_time": 5,
"forts": {
"avoid_circles": true,
"max_circle_size": 50
},
"websocket_server": false,
"walk": 4.16,
"action_wait_min": 1,
"action_wait_max": 4,
"debug": false,
"test": false,
"health_record": true,
"location_cache": true,
"distance_unit": "km",
"reconnecting_timeout": 15,
"evolve_captured": "NONE",
"catch_randomize_reticle_factor": 1.0,
"catch_randomize_spin_factor": 1.0,
"catch": {
"any": {"catch_above_cp": 0, "catch_above_iv": 0, "logic": "or"},
"// Example of always catching Rattata:": {},
"// Rattata": { "always_catch" : true }
},
"release": {
"any": {"release_below_cp": 0, "release_below_iv": 0, "logic": "or"},
"// Example of always releasing Rattata:": {},
"// Rattata": {"always_release": true},
"// Example of keeping 3 stronger (based on CP) Pidgey:": {},
"// Pidgey": {"keep_best_cp": 3},
"// Example of keeping 2 stronger (based on IV) Zubat:": {},
"// Zubat": {"keep_best_iv": 2},
"// Also, it is working with any": {},
"// any": {"keep_best_iv": 3},
"// Example of keeping the 2 strongest (based on CP) and 3 best (based on IV) Zubat:": {},
"// Zubat": {"keep_best_cp": 2, "keep_best_iv": 3}
},
"vips" : {
"Any pokemon put here directly force to use Berry & Best Ball to capture, to secure the capture rate!": {},
"any": {"catch_above_cp": 1200, "catch_above_iv": 0.9, "logic": "or" },
"Lapras": {},
"Moltres": {},
"Zapdos": {},
"Articuno": {},
    "// S-Tier pokemons (if pokemon can be evolved into tier, list the representative)": {},
    "Mewtwo": {},
    "Dragonite": {},
    "Snorlax": {},
    "// Mew evolves to Mewtwo": {},
    "Mew": {},
    "Arcanine": {},
    "Vaporeon": {},
    "Gyarados": {},
    "Exeggutor": {},
    "Muk": {},
    "Weezing": {},
    "Flareon": {}

}

}

hklcf
2016-08-08 12:21:03,371 [sentry.errors.uncaught] [ERROR] u'NoPlayerPositionSetException

what does it mean??

@ponytails check you api or location setting, it seem the bot can't set the location

@hklcf
what u used on this ?
please see image
https://snag.gy/tsQzF2.jpg

@ponytails im using Maps JavaScript API

@hklcf
what type of key ? server / ios / android /  browser?

browser

check the json file using jsonlint

@hklcf  i run pokemon bot on
linux ubuntu
and what should i type on this
"libencrypt_location": "",

@ponytails just leave it blank

https://github.com/PokemonGoF/PokemonGo-Bot/wiki/Installation#get-encryptso-windows-part-writing-need-fine-tune

(PokemonGo-Bot) root@oldtimes:~/PokemonGo-Bot# ./run.sh
2016-08-08 13:09:13,397 [       cli] [INFO] PokemonGO Bot v1.0
2016-08-08 13:09:13,399 [       cli] [INFO] Configuration initialized
2016-08-08 13:09:13,400 [pokemongo_bot.health_record.bot_event] [INFO] Health check is enabled. For more information:
2016-08-08 13:09:13,400 [pokemongo_bot.health_record.bot_event] [INFO] https://github.com/PokemonGoF/PokemonGo-Bot/tree/dev#analytics
2016-08-08 13:09:13,404 [requests.packages.urllib3.connectionpool] [INFO] Starting new HTTP connection (1): www.google-analytics.com
2016-08-08 13:09:13,499 [PokemonGoBot] [INFO] [set_start_location] Setting start location.
Traceback (most recent call last):
File "pokecli.py", line 503, in
main()
File "pokecli.py", line 131, in main
report_summary(bot)
File "pokecli.py", line 140, in report_summary
metrics.capture_stats()
File "/root/PokemonGo-Bot/pokemongo_bot/metrics.py", line 76, in capture_stats
response_dict = request.call()
File "/root/PokemonGo-Bot/pokemongo_bot/api_wrapper.py", line 90, in call
if not self.can_call():
File "/root/PokemonGo-Bot/pokemongo_bot/api_wrapper.py", line 54, in can_call
raise NoPlayerPositionSetException()
pgoapi.exceptions.NoPlayerPositionSetException
2016-08-08 13:09:13,654 [sentry.errors] [ERROR] Sentry responded with an error: 'ascii' codec can't decode byte 0x9c in position 1: ordinal not in range(128) (url: https://app.getsentry.com/api/90254/store/)
Traceback (most recent call last):
File "/root/PokemonGo-Bot/local/lib/python2.7/site-packages/raven/transport/threaded.py", line 174, in send_sync
super(ThreadedHTTPTransport, self).send(data, headers)
File "/root/PokemonGo-Bot/local/lib/python2.7/site-packages/raven/transport/http.py", line 47, in send
ca_certs=self.ca_certs,
File "/root/PokemonGo-Bot/local/lib/python2.7/site-packages/raven/utils/http.py", line 66, in urlopen
return opener.open(url, data, timeout)
File "/root/PokemonGo-Bot/local/lib/python2.7/site-packages/future/backports/urllib/request.py", line 494, in open
response = self._open(req, data)
File "/root/PokemonGo-Bot/local/lib/python2.7/site-packages/future/backports/urllib/request.py", line 512, in _open
'_open', req)
File "/root/PokemonGo-Bot/local/lib/python2.7/site-packages/future/backports/urllib/request.py", line 466, in _call_chain
result = func(*args)
File "/root/PokemonGo-Bot/local/lib/python2.7/site-packages/raven/utils/http.py", line 46, in https_open
return self.do_open(ValidHTTPSConnection, req)
File "/root/PokemonGo-Bot/local/lib/python2.7/site-packages/future/backports/urllib/request.py", line 1284, in do_open
h.request(req.get_method(), req.selector, req.data, headers)
File "/usr/lib/python2.7/httplib.py", line 1048, in request
self._send_request(method, url, body, headers)
File "/usr/lib/python2.7/httplib.py", line 1088, in _send_request
self.endheaders(body)
File "/usr/lib/python2.7/httplib.py", line 1044, in endheaders
self._send_output(message_body)
File "/usr/lib/python2.7/httplib.py", line 886, in _send_output
msg += message_body
UnicodeDecodeError: 'ascii' codec can't decode byte 0x9c in position 1: ordinal not in range(128)
2016-08-08 13:09:13,656 [sentry.errors.uncaught] [ERROR] [u'NoPlayerPositionSetException', u'  File "pokecli.py", line 503, in ', u'  File "pokecli.py", line 131, in main', u'  File "pokecli.py", line 140, in report_summary', u'  File "pokemongo_bot/metrics.py", line 76, in capture_stats', u'  File "pokemongo_bot/api_wrapper.py", line 90, in call', u'  File "pokemongo_bot/api_wrapper.py", line 54, in can_call']
(PokemonGo-Bot) root@oldtimes:~/PokemonGo-Bot#

validate your config.json please

@hklcf  yes its valid

Example Installation for Ubuntu
(change dev to master for the lastest master version) http://pastebin.com/pzPjXT65

@hklcf
it works now but im getting invalid user/pass from google

@ponytails https://github.com/PokemonGoF/PokemonGo-Bot/wiki/FAQ#google-login-issues-login-error-server-busy

@hklcf
where will i put this ?
-p "" on configs/config.json?

@ponytails simply replace your password with the app password in the config.json file

thanks

Location is usually in the format
"40.758895, -73.985131"
Last time i checked it would not work if you didn't have a lot of decimal places.

How can I get app password?


Does replacing a key decrements the reference count ?

Hello,
I am currently writing an application using jansson, and I would like to avoid any memory issues.
Let's say I have added a key to a json object
json_object_set_new(my_json, "key", my_value);
And then later decide to replace the value
json_object_set(my_json, "key", my_new_value);
What happens to the old json object ? Is it decremented and destroyed ? Or should I manage this myself ?

Yep, it will be decremented and destroyed. Stacktrace:

hashtable_set https://github.com/akheron/jansson/blob/4c9018cc4c372f33013806ce7914fda965e3f9aa/src/hashtable.c#L209-L212
json_object_set_new_nocheck https://github.com/akheron/jansson/blob/4c9018cc4c372f33013806ce7914fda965e3f9aa/src/value.c#L117
json_object_set_new https://github.com/akheron/jansson/blob/4c9018cc4c372f33013806ce7914fda965e3f9aa/src/value.c#L131
json_object_set https://github.com/akheron/jansson/blob/4c9018cc4c372f33013806ce7914fda965e3f9aa/src/jansson.h#L225-L226

Perfect, thanks


Integrate the new Common Crawl News dataset

http://commoncrawl.org/2016/10/news-dataset-available/
We should make sure it works with the current common crawl source

The CC news dataset currently has some formatting issues, and the team is fixing it: https://github.com/commoncrawl/news-crawl/issues/11


Payment Sheets & Manually Confirmed Intents

Hello! Thanks for the library! Apologies for opening an issue for a question - I would be happy to open a discussion instead but they are not enabled for the repo.
I am finally performing a migration to this lib from tipsi and I am taking advantage of the beautiful payment sheet integration.
I am however hitting a couple roadblocks with what I used to have and what I now have to have.
My previous flow was:

User views checkout page
User selects payment method (card/native)
A payment method or payment method token is created
User's order is sent to server where a manual intent is created with appropriate fees etc
Server attempts to confirm/charge the intent, and tells the app if further (SCA) auth is required
If approved/not required then another request to the server is made to confirm the intent again
The user's order is considered "paid" at this point and out-of-scope things happen

Now with the payment sheets setup I am unable to replicate this behaviour and appear to have to rely on webhooks - but I'd like to keep the old behaviour if at all possible (if it ain't broke, don't fix it) as this means I can guarantee payment will be taken at the time of purchase and not have to handle sending events from the server back to the app to sync states.
After many hours of combing through code/documentation (some props do not match e.g. presentPaymentSheet does not say that it needs clientSecret second code block L5) I found this PR https://github.com/stripe/stripe-react-native/pull/514 (which, to confuse matters more, removes clientSecret from presentPaymentSheet in the examples).
514 suggests that customFlow must be used if one needs to manually confirm intents - however I cannot figure for the life of me how this can be done whilst retaining the UI journey from a customFlow: false option. The confirmPayment option would appear to do what I need!
I hope this makes sense and please ask if you need some code examples.

So apologies for immediately commenting after posting an issue...I had spent a while writing that out before trying some other stuff out:
Amending server side intent creation code like so:
    const paymentIntent = await stripeService.paymentIntents.create({
      amount: 1099,
      currency: 'gbp',
      customer: customer.id,
+     confirmation_method: 'manual',
+     confirm: false
    })

And continuing with the paymentsheet stuff like in the example, I get this in my app logs after attempting presentPaymentSheet:
 LOG  {"result": {"error": {"code": "Failed", "declineCode": null, "localizedMessage": "PaymentIntent with confirmation_method='automatic' is required.
The current PaymentIntent has confirmation_method Manual.
See https://stripe.com/docs/api/payment_intents/object#payment_intent_object-confirmation_method.", "message": "PaymentIntent with confirmation_method='automatic' is required.```

😢

Gunna triple comment on my own issue now - I wanted to clarify the payment methods that I'll be using will only ever be card or native pay (Apple/Google Pay). I am unsure and cannot get from the docs whether or not these payments will always be relatively instant.
If this is the case, I should think this flow may be acceptable:

On checkout screen load, send request to server to obtain correctly structured payment intent (with appropriate fees etc)
Show "Pay" button to trigger payment flow
On complete (resolution from presentPaymentSheet() promise), trigger another server request to update state server side, which will check payment intent status with stripe API
Update order server side and return updated state

With an additional edge case handling via webhooks to ensure payments that do happen to take longer than that round trip time are correctly updated. Luckily, I had planned integration with firebase to synchronise order state within my app so this should be suitable.
I would still like to ask the question (with the additional one of if the above ☝🏻 is suitable/correct) if manually confirmed payment intents are possible.

Any ideas with this one?

514 suggests that customFlow must be used if one needs to manually confirm intents - however I cannot figure for the life of me how this can be done whilst retaining the UI journey from a customFlow: false option. The confirmPayment option would appear to do what I need!

this change was about only simplifying payment flow from technical POV, which means that if you provided customFlow flag in initPaymentSheet then you don't need to again specify if it should confirm payment intent or not, because we know it based on this flag.
@paulasjes-stripe would you mind to help answer to the rest of questions?

It sounds like what you're trying to do is manual server-side confirmation so you can immediately verify that a payment completed without relying on webhooks. This manual server-side confirmation is possible, but not with the payment sheet unfortunately: https://stripe.com/docs/payments/accept-a-payment-synchronously?platform=react-native
We don't really recommend this flow as it can result in dropped payments. If your user closes the browser or quits the app after doing the 3DS step but before they can be redirected back to your app, you'd never know that the payment is ready to be confirmed again on your server. Hence why we recommend using webhooks, so there's no chance that you miss any important information.
If you don't want to set up a webhook process however, you could immediately check the status of the PaymentIntent after the payment has completed by calling retrievePaymentIntent and checking the resulting PaymentIntent's status. This still leaves you vulnerable to the edge case of users quitting before being redirected, but it saves you a roundtrip to your server to check on the PaymentIntent status.

Sorry about that. Been a little busy and my project fell off my radar. I'll look to have a check at this and what has been said and will get back to you hopefully before this weekend.
Have a great week and thanks again for your patience! (and the library)

@jack828  I'm trying to solve this too this weekend.
I'm trying to reserve a timeslot for my students & take their card details...I only want to charge them once a teacher has confirmed their availability.
If you make any progress do share. Likewise I will :)

hey @jack828 - just checking in to see if you were able to get things working either with the non-Payment Sheet && no-webhooks flow, or with the Payment Sheet && webhooks flow?

Hey @charliecruzan-stripe unfortunately the project ended up dying, and it was so long ago I find it hard to remember exactly what I did. I'm pretty sure it never went anywhere since my previous comment.
The ability to do this would be greatly beneficial still though. I appreciate you checking in on this!

Got it, I think if you (or someone else) is trying to do this in the future, they should follow this comment here, but lmk if you have issues or questions!


systematise what to do with PV prefixes

In general, PV prefixes belong where devices are instantiated, in the beamline files
Sometimes this is not possible because multiple prefixes are needed (https://github.com/DiamondLightSource/dodal/issues/73)

Devices which take more than one prefix for different components should accept these as additional kwargs so that the root PV prefix should always be in the beamline files, for improved reusability of devices. E.g. use of -EA- and -MO- differs between beamlines and this should not prevent device reuse.

applicable to the pressure cell - the one with separate ADC prefixes.
Might be of interest to: @barnettwilliam


Easier code highlighting of non-supported/dark styles by highlight.js

Margins for dark themes
Right now when using highlight = true and a dark style by https://cdnjs.cloudflare.com like dracula, one only gets a coloured output with margins. (The dracula style shown here is not supported by cdnjs and was inserted in highlight.min.css. )

I modified bootstrap.min.css so that the padding is set to zero:
from pre{display:block;padding:9.5px to pre{display:block;padding:0px

Could this be the default or don't you want to modify the original bootstrap.css?
Easier 'non-common' language support?
Also, I need to explicitly add and initialise highlight.pack.js (custom file under static/js) in header.html to get highlighting for R code chunks:
<link rel="stylesheet" href="{{ .Site.BaseURL }}css/highlight.min.css">
<script src="{{ .Site.BaseURL }}js/highlight.pack.js"></script>
<script>
  hljs.initHighlightingOnLoad();
</script>

Otherwise, R is not recognised as a language and not coloured. This is because cdnjs only supports 'common' languages (https://highlightjs.org/download/). R is classified as 'other'.

Could Hugo-Academic ship with a highlight.pack.js under themes/academic/static/js which provides support for all languages? There could also be one folder containing all styles which are missing by cdnjs. The code snippet I posted above could then be interactively use the style file which is specified in config.toml.

highlight.min.css here is overwritten by dracula.css.
highlight.pack.js contains styles download specifically with "R" checked as a language

@pat-s thanks for the images, makes it easy to understand your points.

I will definitely consider either removing the code block margin or introducing an option for a dark alternative :)

Did you take a look at the HighlightJS customization options that were added to Academic? I think perhaps most or all of what you are trying to do can be achieved with it: https://gcushen.github.io/hugo-academic-demo/post/writing-markdown-latex/#highlighting-options ?

@gcushen I did take a look and also tried it - however, R as a language is not within the "common" languages imported by cloudfare. Hence, I get no syntax highlighting for the language at all.
And I also needed to add dracula as a style css in my static/css to get it working.
Also, Dracula is not within the supported languages (https://highlightjs.org/static/demo/).
What do you think about implementing my fix as the default? I think an update of the highlight pack.js file once a year would be sufficient. You can also create a folder within static/css named 'highlight.js' which contains all theme .css files so that all styles are supported.
I would send a PR if you agree :)

@pat-s an official dark theme has now been added (see #299) and this issue is completely resolved.

Nice, I like it!
(However, the issue was initially about dark highlighting style for code blocks :sheep:)

The dark highlighting style is integrated into the dark theme and the issue of the padding being a different color is fixed :smile:


The experimental data of the paper cannot be reproduced

hi, guo
I have tried many times. The following results are always the same, which is far from the results in the paper. Is there any difference between the results in the paper and the code?
Can you add a wechat private chat?
dataset: hdfs
git branch: main
==================== logbert ====================
best threshold: 0, best threshold ratio: 0.0
TP: 7602, TN: 549880, FP: 3488, FN: 3045
Precision: 68.55%, Recall: 71.40%, F1-measure: 69.95%

Can you share your email?
Thanks

<EMAIL_ADDRESS>

Can you share your email?
Thanks

<EMAIL_ADDRESS>

Thanks for reaching out!! My email is @.***
Best,
Nick
On Sat, Oct 22, 2022 at 10:03 AM chinahappyking @.***>
wrote:

Can you share your email?
Thanks
@.***
—
Reply to this email directly, view it on GitHub
https://github.com/HelenGuohx/logbert/issues/24#issuecomment-1287802717,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHVRJ64AIAB6RFL3CSG6RJTWEPX4VANCNFSM5QBCFMLQ
.
You are receiving this because you commented.Message ID:
@.***>

I just tried and have the same:

best threshold: 0, best threshold ratio: 0.0
TP: 7643, TN: 549806, FP: 3562, FN: 3004
Precision: 68.21%, Recall: 71.79%, F1-measure: 69.95%

I haven't looked (deeply) into the code so far, but is the training data really limited to n=4855, as the code in line 122 in file data_process.py seems to indicate?
generate_train_test(log_sequence_file, n=4855)
How can I train for better results?

I removed n=4855 from the described code line in the previous comment and now I have a lot more training data available.
I‘ll post about the results again.

Here are my results after applying the above changes:

best threshold: 0, best threshold ratio: 0.0
TP: 6996, TN: 390662, FP: 95, FN: 3651
Precision: 98.66%, Recall: 65.71%, F1-measure: 78.88%

Recall and F1 are still lower than in the paper, which were P=87.02, R=78.10, and F1=82.32
Caveat> I stopped training after 60 epochs, so this could be a reason for the underperforming values.

One more, after finishing training with a batch size of 512 with HDFS, val loss=0.183, train loss=0.178, 135 epochs, takes about 35 minutes on a RTX 3090.

best threshold: 0, best threshold ratio: 0.0
TP: 7583, TN: 390484, FP: 273, FN: 3064
Precision: 96.52%, Recall: 71.22%, F1-measure: 81.97%

Here is my result, training with a batch size of 512 with HDFS, val loss=0.537, train loss=0.451, 87 epochs, takes about 39 minutes on a RTX 3090.
best threshold: 0, best threshold ratio: 0.0
TP: 7908, TN: 389836, FP: 921, FN: 2739
Precision: 89.57%, Recall: 74.27%, F1-measure: 81.21%
elapsed_time:<PHONE_NUMBER>239288


Wrong units of network bandwidth in some virtual machine categories above

Hi team,
I moved this issue from here: https://github.com/MicrosoftDocs/azure-docs.de-de/issues/592
@mikerobyn commented 12 hours ago — with docs.microsoft.com
Some examples how the bandwidth is decalred in some specs of virtual machine categories:
DC-Series: Mbps (e.g. DC2s 1500Mbps)
Dav4-series: MBps (e.g. D2as_v4 1000MBps)
Dv3-series: No unit declared.
I guess D2as_v5 does not support 8Gbit/s? Even if this should be correct, inconsistent declaration of units should be avoided.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9bb1d37c-6337-0906-42ff-b5dbc6afdc8b
Version Independent ID: 72a96e16-1d2d-4c01-45be-3caf82470592
Content: Azure Windows VM sizes - General purpose
Content Source: articles/virtual-machines/windows/sizes-general.md
Service: virtual-machines-windows
GitHub Login: @jonbeck7
Microsoft Alias: jonbeck

Thanks for the feedback! We are currently investigating and will update you shortly.

@mikerobyn I corrected the Dv3 series. Thanks for pointing that out :)
As per the v5 series, I assume you meant to type v4 as there is not a v5 in this doc.
The Das_v4 series are in preview so we will continue to update the doc as they move to GA and we have more precise numbers that we can grantee


gleam: 1.2.0 -> 1.2.1

Description of changes

GitHub compare of changes: https://github.com/gleam-lang/gleam/compare/v1.2.0...v1.2.1

Looks like mostly bugfixes
## v1.2.1 - 2024-05-30

### Bug Fixes

- Fixed a bug where the compiler could fail to detect modules that would clash
  with Erlang modules.
  ([Louis Pilfold](https://github.com/lpil))

- Fixed a bug where dependency version resolution could crash for certain
  release candidate versions.
  ([Marshall Bowers](https://github.com/maxdeviant))

- Fixed a bug where trailing comments would be moved out of a bit array.
  ([Giacomo Cavalieri](https://github.com/giacomocavalieri))

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 317231 run on x86_64-linux 1

1 package built:

gleam


fix: add aria-selected to selected tree node link

Signed-off-by: stsogoo<EMAIL_ADDRESS>PR Checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type
What kind of change does this PR introduce?
The PR adds aria-selected attribute and sets its value depending on whether the tree node-link belongs to the currently activated page or not. There are two types of node links: one that depends on RouterLinkActive and the other one doesn't. If it depends on RouterLinkActive, tree-node-link automatically handles aria-selected. If it doesn't, a user needs to manually set aria-selected which is reflected in the document.

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: https://github.com/vmware/clarity/issues/3571
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Closing this PR as we are planning to offer a different solution to the issue.


Refactor board.js

Board.js needs to be rewritten so that the charts are individual components. As is, one change to any one chart breaks the rest.
I think that this is very important. Not only should we signifcant gains in rendering, but it will be much more solid.

[x] Each chart in separate svg tag
[x] make charts out of an Ember.Object
[x] move d3 logic to separate file
[ ] move actions out of the controller and into routes where they belong
[x] remove legacy code from original code that was moved over from previous project
[ ] merge makeTimeSeries with makeBarChart
[x] remove all '.observes' to prevent multiple renderings
[ ] move button logic to it's own object and/or helper
[ ] clean up actions

I will be working on this over the 24 hours and hope to have it done before Wednesday.

This is all but done. I need to test it more just to be comfortable. I should be merging this with dev tomorrow (8/17) morning.


:art: formatting + linting in CI-CD

This PR adds the following CI-CD checks:

[x] linting with ruff
[x] formatting with black (line-length = 88)
[x] sorting imports with isort

:robot: added a Makefile to, uhm, make it more convenient to call the lint & formatting commands

Formatting the code: make lint
Linting the code: make lint

Codecov Report

Merging #143 (3561cdd) into main (17913ed) will decrease coverage by 0.40%.
The diff coverage is 100.00%.

:exclamation: Current head 3561cdd differs from pull request most recent head 893b02f. Consider uploading reports for the commit 893b02f to get more accurate results

@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   97.49%   97.08%   -0.41%
==========================================
  Files          11       12       +1
  Lines         878      892      +14
==========================================
+ Hits          856      866      +10
- Misses         22       26       +4

Impacted Files
Coverage Δ

...tly_resampler/aggregation/aggregation_interface.py
98.46% <ø> (ø)

plotly_resampler/aggregation/algorithms/lttb_c.py
100.00% <ø> (ø)

plotly_resampler/figure_resampler/__init__.py
100.00% <ø> (ø)

...sampler/figure_resampler/figurewidget_resampler.py
99.03% <ø> (ø)

plotly_resampler/aggregation/aggregators.py
91.66% <100.00%> (ø)

...tly_resampler/figure_resampler/figure_resampler.py
90.35% <100.00%> (ø)

...ler/figure_resampler/figure_resampler_interface.py
99.73% <100.00%> (ø)

plotly_resampler/figure_resampler/utils.py
96.29% <100.00%> (ø)

plotly_resampler/registering.py
100.00% <100.00%> (ø)

plotly_resampler/__init__.py
71.42% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Seems good!
Some questions:

which commands should somebody use to run this locally?
maybe add some information about this in the contirbuting.md

When I get these answers, I will continue my review.

To run locally, just perform poetry install in the plotly_resampler cloned repo - this will install the dev dependencies from the poetry.lock file.
Once all (new) dev dependencies are installed, you can use the Makefile to

format the code: make format
lint the code: make lint
and test the code (with coverage): make test

-> I updated the CONTRIBUTING.md with how you should run the formatting & linting (& testing) locally
Hope this answers your questions @jonasvdd

Does the CONTRIBUTING.md  solve / answer your comments @jonasvdd ?


Add StorPool to Storage

Pre-submission checklist:
Please check each of these after submitting your pull request:

[x] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[x] Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
[x] Have you picked the single best (existing) category for your project?
[x] Does it follow the other guidelines from the new entries section?
[x] Have you included a URL for your SVG or added it to hosted_logos and referenced it there?
[x] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[x] Does your project/product name match the text on the logo?
[x] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[ ] ~15 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

StorPool requested to be added to the cloud native storage category

Deploy preview for landscape ready!
Built with commit 639deb440892eb4cf2e2de066c5b740920b7d21f
https://deploy-preview-1761--landscape.netlify.app

LGTM


Added EnaSupport=True for Elastic Network Adapter

I kept getting this error every time I tried to launch an instance from the automatic AMI. "An error occurred (InvalidParameterCombination) when calling the RunInstances operation: Enhanced networking with the Elastic Network Adapter (ENA) is required for the 'g4dn.xlarge' instance type. Ensure that you are using an AMI that is enabled for ENA."
Since g4dn.xlarge or greater requires Elastic Network Adapter enhanced networking we need to use EnaSupport=True instead of SriovNetSupport='simple'.
https://docs.aws.amazon.com/AWSEC2/latest/WindowsGuide/enhanced-networking.html
EnaSupport=True Supported instance types: current generation instance type, other than C4, D2, M4 instances smaller than m4.16xlarge, or T2. https://docs.aws.amazon.com/AWSEC2/latest/WindowsGuide/enhanced-networking-ena.html
SriovNetSupport='simple'  Supported instance types: C3, C4, D2, I2, M4 (excluding m4.16xlarge), and R3. https://docs.aws.amazon.com/AWSEC2/latest/WindowsGuide/sriov-networking.html

Thanks for this! I tested it and it works fine. Wasn't having this particular issue on my setup but I see from the documentation links you provided that this is the correct way to do it. @Cookie-Monster-Coder thanks!


MELODIC fails but returns with exit code zero

This error has surfaced with MRIQC only this far, but I expect it to appear also for fMRIPrep with --ica-aroma.
Command line:
singularity exec /home/groups/russpold/singularity_images/poldracklab_mriqc_0.15.0-2019-04-05-a4441b87badc.simg melodic -i /scratch/users/oesteban/mphagen/work-1105/workflow_enumerator/funcMRIQC/_in_file_..oak..stanford..groups..russpold..data..uh2_aim2..BIDS_scans..sub-1105..func..sub-1105_task-motorSelectiveStop_run-1_bold.nii.gz/sanitize/sub-1105_task-motorSelectiveStop_run-1_bold_valid.nii.gz --nobet --nomask --no_mm -o /scratch/users/oesteban/mphagen/work-1105/melodic-ica -v --debug

This is the standard output (with both -v and --debug, empty otherwise):
Melodic Version 3.14
Melodic results will be in /scratch/users/oesteban/mphagen/work-1105/melodic-ica
START: setup
START: setup_misc
END: setup_misc
 after setup_misc START: setup_classic
START: process_file
 before reading file /scratch/users/oesteban/mphagen/work-1105/workflow_enumerator/funcMRIQC/_in_file_..oak..stanford..groups..russpold..data..uh2_aim2..BIDS_scans..sub-1105..func..sub-1105_task-motorSelectiveStop_run-1_bold.nii.gz/sanitize/sub-1105_task-motorSelectiveStop_run-1_b
old_validReading data file /scratch/users/oesteban/mphagen/work-1105/workflow_enumerator/funcMRIQC/_in_file_..oak..stanford..groups..russpold..data..uh2_aim2..BIDS_scans..sub-1105..func..sub-1105_task-motorSelectiveStop_run-1_bold.nii.gz/sanitize/sub-1105_task-motorSelectiveStop_r
un-1_bold_valid  ...  done
 after reading file /scratch/users/oesteban/mphagen/work-1105/workflow_enumerator/funcMRIQC/_in_file_..oak..stanford..groups..russpold..data..uh2_aim2..BIDS_scans..sub-1105..func..sub-1105_task-motorSelectiveStop_run-1_bold.nii.gz/sanitize/sub-1105_task-motorSelectiveStop_run-1_bo
ld_valid before est smoothness   Estimating data smoothness ...  done
 after smoothness  before reshape  after reshape   Removing mean image ... before remmean  after remmean  done
 before VN   Normalising by voxel-wise variance ... in VN  done
END: process_file
 after process_file Excluding voxels with constant value ... done
  /scratch/users/oesteban/mphagen/work-1105/melodic-ica/alldat
Finished with exit code 0

Standard error:
     stdDev  0 x 0
An exception has been thrown
Logic error:- detected by Newmat: index error: requested index = 0
MatrixType = Rect   # Rows = 1; # Cols = 982

And finally, log.txt:
Melodic Version 3.14
melodic -i /scratch/users/oesteban/mphagen/work-1105/workflow_enumerator/funcMRIQC/_in_file_..oak..stanford..groups..russpold..data..uh2_aim2..BIDS_scans..sub-1105..func..sub-1105_task-motorSelectiveStop_run-1_bold.nii.gz/sanitize/sub-1105_task-motorSelectiveStop_run-1_bold_valid.
nii.gz --nobet --nomask --no_mm -o /scratch/users/oesteban/mphagen/work-1105/melodic-ica
---------------------------------------------
Melodic results will be in /scratch/users/oesteban/mphagen/work-1105/melodic-ica
Reading data file /scratch/users/oesteban/mphagen/work-1105/workflow_enumerator/funcMRIQC/_in_file_..oak..stanford..groups..russpold..data..uh2_aim2..BIDS_scans..sub-1105..func..sub-1105_task-motorSelectiveStop_run-1_bold.nii.gz/sanitize/sub-1105_task-motorSelectiveStop_run-1_bold
_valid  ...  done
  Estimating data smoothness ...  done
  Removing mean image ... done
  Normalising by voxel-wise variance ... done
Excluding voxels with constant value ... done
Melodic Version 3.14
melodic -i /scratch/users/oesteban/mphagen/work-1105/workflow_enumerator/funcMRIQC/_in_file_..oak..stanford..groups..russpold..data..uh2_aim2..BIDS_scans..sub-1105..func..sub-1105_task-motorSelectiveStop_run-1_bold.nii.gz/sanitize/sub-1105_task-motorSelectiveStop_run-1_bold_valid.
nii.gz --nobet --nomask --no_mm -o /scratch/users/oesteban/mphagen/work-1105/melodic-ica -v --debug
---------------------------------------------
Melodic results will be in /scratch/users/oesteban/mphagen/work-1105/melodic-ica
Reading data file /scratch/users/oesteban/mphagen/work-1105/workflow_enumerator/funcMRIQC/_in_file_..oak..stanford..groups..russpold..data..uh2_aim2..BIDS_scans..sub-1105..func..sub-1105_task-motorSelectiveStop_run-1_bold.nii.gz/sanitize/sub-1105_task-motorSelectiveStop_run-1_bold
_valid  ...  done
  Estimating data smoothness ...  done
  Removing mean image ... done
  Normalising by voxel-wise variance ... done
Excluding voxels with constant value ... done
  /scratch/users/oesteban/mphagen/work-1105/melodic-ica/alldat

Some other people seem to have hit this issue and MELODIC 3.15 might solve the issue.

I've checked that #381 fixes this issue on the dataset provided on top.
Although it'd be nice to provide more clear feedback about why MELODIC did not converge, I feel that is too much effort for little outcome in this case (and probably pertains to nipype).


idrisPackages: Progress reporting

Motivation for this change
Before this change, Idris would silently build all files of a package without indicating any progress until everything is done, because it doesn't seem to flush on newlines when the output isn't a tty. This is especially frustrating because Idris can take a very long time to compile things.
Ping @brainrape @mpickering @shlevy
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

I'll close this because this PR fixes it: https://github.com/idris-lang/Idris-dev/pull/4498


add initial icon pack for percussion tinymce theme

Initial checkin still needs testing

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Yashdeep2001  Thanks! Is it still missing some of the plugin icons?  Like should there be 6 icons or are we using some default icons for some plugins?


chore: use latest libp2p release

It is important pointing out that getMsgId function might return a Promise per https://github.com/libp2p/js-libp2p-interfaces/blob/master/packages/interfaces/src/pubsub/index.js#L479 We were having issues in browser tests thanks to it, so I needed to make it accept promises too.
Also updates uint8arrays

Codecov Report

Merging #156 (95b6adf) into master (350ed5f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #156   +/-   ##
=======================================
  Coverage   76.58%   76.58%
=======================================
  Files           2        2
  Lines        1905     1905
  Branches      140      140
=======================================
  Hits         1459     1459
  Misses        446      446

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 350ed5f...95b6adf. Read the comment docs.

@wemeetagain @mpetrunic it would be really helpful if this could be merged & released

@wemeetagain @mpetrunic it would be really helpful if this could be merged & released

Is this safe to merge as is? I can trigger the release now

Is this safe to merge as is? I can trigger the release now

Yes, it is good to go


TargetFramework

Why do you use netcoreapp3.0 instead of the newer one: netcoreapp3.1 or the newest: net5.0?

To be honest, version 3.0 I choose last year for AoC 2019 and just continue with the same strategy for this one. Also, I don't see any benefit of using 3.1 and how it will help me with solving puzzles.


cloudevent are published in structured mode now

Fixes #597
cloudevent are published in structured mode now, fixed cluster roles.

🐛 Fix bug

/assign @Cali0707

fixed by https://github.com/knative-extensions/eventing-natss/pull/587


Dropout not used correctly in machine_translation example

In this example, dropout is effectively ignored because:

The cost used in GradientDescent should be cg.outputs[0] rather than 'cost':
https://github.com/mila-udem/blocks-examples/blob/12013e6c737171ce285b27381f0f5aacfdff7cab/machine_translation/__init__.py#L160

Also the cost used in TrainingDataMonitoring:
https://github.com/mila-udem/blocks-examples/blob/12013e6c737171ce285b27381f0f5aacfdff7cab/machine_translation/__init__.py#L112
is not the dropped out one, so instead one should use here cg.outputs[0].

@orhanf thoughts on this?

The first item should definitely be fixed, but for the second one, there are some differences between implementations. What we usually monitor is the bleu score or log-prob of the validation set or a subset of the training set. And for both, we use models without any regularization. So, I think, the first item should be fixed, the second can be optional.

in which part of the code, do you monitor log-prob of the validation set?


Running 3rd party schematics should be possible using both : and --collection  syntax

🐞 Bug report
Command (mark with an x)
- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ X] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?
Hard to say
Description
Following the upcoming Angular Schematics guide there seems to be an issue with the support for --collection flag when trying to specify 3rd party schematics collection in ng generate.
The command ng generate my-schematic-name --collection collection-name should be equivalent to ng generate collection-name:schematics-name but only the second works in my case.
To be more specific, I can run ng g @angular-extensions/model:model feature/user but if I try to run ng g model feature/user --collection @angular-extensions/model then it fails as it doesn't recognize the passed collection and the @schematics/angular doesn't contain any model...
Any ideas why that could be? I am working on the windows machine ( with cygwin ) could it be paths or ?
🔬 Minimal Reproduction

ng add @angular-extensions.model (or any other 3rd party library which contains schematics, eg: @angular/material or @ngrx/store)

ng generate model examples/user --collection @angular-extensions/model

This results in a error where model schematics is not found in the @schematics/angular which is a default collection in Angular CLI so that means the --collection was ignored.
On the other hand, everything works just fine when using ng generate @angular-extensions/model:model examples/user.
🔥 Exception or Error

Schematic "model" not found in collection "@schematics/angular".
Error: Schematic "model" not found in collection "@schematics/angular".
    at SchematicEngine.createSchematic (C:\projects\meetup\schematics-example-workspace\node_modules\@angular-devkit\schematics\src\engine\engine.js:232:23)

🌍 Your Environment

Angular CLI: 7.3.3
Node: 10.11.0
OS: win32 x64
Angular: 7.2.6
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.13.3
@angular-devkit/build-angular      0.13.3
@angular-devkit/build-ng-packagr   0.13.3
@angular-devkit/build-optimizer    0.13.3
@angular-devkit/build-webpack      0.13.3
@angular-devkit/core               7.3.3
@angular-devkit/schematics         7.3.3
@angular/cdk                       7.3.3
@angular/cli                       7.3.3
@angular/material                  7.3.3
@ngtools/json-schema               1.1.0
@ngtools/webpack                   7.3.3
@schematics/angular                7.3.3
@schematics/update                 0.13.3
ng-packagr                         4.7.1
rxjs                               6.3.3
typescript                         3.2.4
webpack                            4.29.0

Hi @tomastrajan,
To provide use a different schematics collection via command line you need you use the --schematic option or first positional argument.
ng g --schematic @angular-extensions/model:model feature/user
ng g @angular-extensions/model:model feature/user

There is no such option called --collection, see: https://angular.io/cli/generate#schematic-commands for more information.


sink(ticdc): add limit to storage ddl sink

What problem does this PR solve?

Issue Number: close https://github.com/pingcap/tiflow/issues/9602
What is changed and how it works?
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
`Fix the issue of gcs write limit caused by frequent metadata updates in the storage sink`.

/retest


quick shell script for developers to run in order to setup their dev branch for a given github issue

Describe the solution you'd like
Everytime we write a github issue, we want developers to work off of a dev branch for protection of the mainline.
However, in each issue description, we end up having to repeat the same steps on how to create a dev branch (see the Setup Instructions (what branch to work off of)).
To alleviate this problem, we should setup a quick shell script that takes the name of a proposed dev branch and automatically setup the development branch with one run of the script.
Additional context
Test that the script works on creating a dummy branch and tracking local/remote properly
Setup Instructions (what branch to work off of)
Run the following commands
git checkout nextjs
git pull origin nextjs
git checkout -b branch-setup-sh-script

FYI: If you are not able to immediately run git checkout nextjs, make sure you commit your changes in the current branch or run git stash and then execute the above commands

Extension idea (Could be overengineering. If so, let @karkir0003 know): If you are able to get the basic shell script working, a followup item (as a stretch goal) could be to see if we can adapt the script to be able to enter an issue id (eg: #786) and parse the data to identify the name of the development branch and use that as input to setting up the development branch
AKA: issue id/number --> proper setup of development branch for the given task

clarification on what to do:
suppose we had a shell script named create-branch.sh. i want to run the script as such ./create-branch.sh hello where hello is the name of the branch. the desired behavior of the shell script should be executing the following
git stash
git checkout nextjs
git pull origin nextjs
git checkout -b hello

@yeaitsurya

hey i just pushed the code. Let me know if u see it and if its feasible.

@karkir0003

hey. taking a look :eyes


Register fold import action

Close #130678
https://github.com/user-attachments/assets/0a73fe12-db69-4f33-ad21-998c21ed7561

The folding model already knows which ranges are import ranges: type === FoldingRangeKind.Imports
See here as an example:
https://github.com/microsoft/vscode/blob/c95571667318a8ff30e27e7302f29cc6318a4001/src/vs/editor/contrib/folding/browser/folding.ts#L877
Of course this only works for languages that have a provider. Your PR also has the same problem.

The folding model already knows which ranges are import ranges: type === FoldingRangeKind.Imports
See here as an example:
https://github.com/microsoft/vscode/blob/c95571667318a8ff30e27e7302f29cc6318a4001/src/vs/editor/contrib/folding/browser/folding.ts#L877
Of course this only works for languages that have a provider. Your PR also has the same problem.

I have update the code get regions from folding model.

Of course this only works for languages that have a provider. Your PR also has the same problem.

That seems to make sense to have a provider figure out what range is import range in different language?

You can use the already existing function setCollapseStateForType: https://github.com/microsoft/vscode/blob/c95571667318a8ff30e27e7302f29cc6318a4001/src/vs/editor/contrib/folding/browser/foldingModel.ts#L436
Depending on what extensions are installed, some language have rich language support and a folding provider, some don't.
For the languages that do not have a folding provider, folding ranges are computed using the indentation.
That might match the import sections, but must not.

You can use the already existing function setCollapseStateForType

If we reuse the function we might need to know if the import range is collapsed or expanded.
Maybe we need a new function name toggleCollapseStateForType?

That might match the import sections, but must not.

If I understand right we should toggle fold import when there are provider provided? Like getFoldingRangeProviders here?

If we reuse the function we might need to know if the import range is collapsed or expanded.
Maybe we need a new function name toggleCollapseStateForType?

Do you want to toggle or set? I assumed from the name of the command fold import it is about setting the state to folded.
The command will just be a no-op if there's fodling provider that knows about imports. That's fine.

If we reuse the function we might need to know if the import range is collapsed or expanded.
Maybe we need a new function name toggleCollapseStateForType?

Do you want to toggle or set? I assumed from the name of the command fold import it is about setting the state to folded.
The command will just be a no-op if there's fodling provider that knows about imports. That's fine.

Maybe toggle is better? Only fold import seems quite limited. Separating the two commands fold and unfold seems to give the user more flexibility. What do you think?

Toggle is probably more useful.

Thanks @BABA983 !


Spring Cloud Stream Kafka Streams produces complicated topologies when using Scs serializer/deserializers

The context for this issue can be found in this SO question and in the lattest comments of this issue in the samples repository.
Summing up, Scs Kafka Streams applications generate complex topologies in contrast with the ones generated by native Kafka Streams applications.
Check this comment that shows an example from one of the spring-cloud-stream-samples, pointing at some strange processors that are added to the topology.

@codependent With native decoding being the default starting with version 3.0, the complicated topologies generated is now reduced. There was one unnecessary step that was generating an extra processor which got addressed the commit mentioned ^^. At this point, if you are on the latest snapshot, and are not changing the default native decoding, then you should get the same exact topology generated by a native Kafka Streams applications.

Awesome, thanks @sobychacko !


Bug: "Share your solution" feature is bugged AF

Buttons here are hidden for some reason:

The view is completely broken, probably due to event from comments.js not being fired (we should fire it manually when is_shared)

Fixed by #390


[LIVY-763][SERVER] Fix File Descriptor leak from DirectoryStream

What changes were proposed in this pull request?
Took separate handle for directory stream. Closed directory stream handle in finally block. Code changes done in InteractiveSession.scala.
JIRA: https://issues.apache.org/jira/browse/LIVY-763
How was this patch tested?
Ran lsof | grep python command to see the Directory FDs for {SPARK_HOME}/python/lib. Tested by creating interactive session for pyspark and verified FDs are not created.

Thank you for your contribution, @RajshekharMuchandi!


Batch response

Fixes batch response to include the resource for requests that return a resource, correct type (batch-response) and timestamp.
Includes latest changes from master

@7opf I merged master into Asymmetrik:feat/batch, can you merge Asymmetrik:feat/batch back into 7opf:batch-response, resolving conflicts, and re-raise this PR?

@7opf I merged master into Asymmetrik:feat/batch, can you merge Asymmetrik:feat/batch back into 7opf:batch-response, resolving conflicts, and re-raise this PR?

Ok, please see https://github.com/Asymmetrik/node-fhir-server-core/pull/219


Feature Request: ASG filter by image

EC2 has the filter image in addition to image-age while ASG only has image-age. To implement a Cloud Custodian policy involving custom AMIs with ASGs, I need this filter since you are checking the tag "AMIExpiration" in the custom AMI, not the AMI's actual age. Should be a quick implementation as would mirror EC2's InstanceImage class and ASG's ImageAgeFilter class already properly gets the AMI attached to ASG launch config.

yeah, it could base of launch config as a base filter. currently launch config limits to image id check, having full image attributes as an asg filter sounds good.

First pull request #1646 has been uploaded for review. Tested locally using tox

Closed by PR #1646