[lexical-selection] Bug Fix  /  Fixes text formatting with segmented and token nodes #6059

Description
It is currently only possible to format token or segmented nodes by selecting them entirely. They won't be formatted if they are in the middle of the range selection. Also, if the selection offset is in the middle of the node, it will split the node.
This PR ensures middle nodes are formated, just like when selecting them entirely. Also, it prevents breaking segmented or token nodes in the middle of the text where they shouldn't be allowed.
https://github.com/facebook/lexical/issues/6059
Test plan
Added unit tests to the PR. See LexicalSelection.test.tsx.
Before

Formatting text in the middle of a segmented or token text node was splitting the node.
Formatting range selection with a segmented or token node in the middle was not formatting the node.

After

Formatting text in the middle of a segmented or token text node is not splitting the node anymore. It is formatting the whole node.
Formatting range selection with a segmented or token node in the middle now formats the node.

This looks interesting, never stumbled upon this issue. For @Sahejkm @zurfyx and @potatowagon to comment,

@lacroixdavid1 could you help explain this scenario via a video recording ? Thanks!

It's pretty easy to repro the issue on the playground by just inserting a mention, selecting it partially, and applying bold format.

I think these are actually probably the correct semantics for token/segmented nodes. The whole point of these is that they are a single "unit" and are interacted with as such from a creation/deletion standpoint.
The only other way I could think to deal with this would be to treat the styled portion of the node as and additional segment, rather than splitting the node and removing the token/segmented characteristics entirely.

Formatting range selection with a segmented or token node in the middle was not formatting the node. @lacroixdavid1 could you help explain this scenario via a video recording ? Thanks!

For the following example, the MentionNode was changed from segmented to token.
Before

After

Any progress on this one? Seems like a great improvement. Thanks!

Any chances of getting this one merged into 0.15.1? :pray: pls

Thank you, guys. Lexical is very solid and has a bright future.

Thank you for this change!
It works very well, I found only one issue regarding:
Formatting range selection with a segmented or token node in the middle now formats the node.
This doesn't work when formatting text color


Are blinds working in latest version 1.0.5

Hi Rayan. Been a long time. How are you? Was wondering if you managed to get the blinds working in latest version 1.0.5. Thanks.

Hey @Lestercity, I haven't gotten any direct progress, but I have added some test blinds in V2 Bx. A new seed should be out soon (hopefully). But I can't really debug further since I have looked at every approach possible, and may have to wait for when the official Tuya Api is in a hb dev's hands.


tests: drivers: spi: spi_loopback: became skipped whereas it used to be passed

Describe the bug
tests/drivers/spi/spi_loopback used to be passed on some STM32 boards.
It requires some harness/fixture which where implemented on automatic bench (map.yaml).
Some time ago, this test became systematically skipped for all boards
When removing fixture requirement in the test, it is passed.
So it looks like fixture mechanism has changed.
Is it bugging or something to change in harness/fixture declaration ?
Note: it seems this test is also skipped for other manufacturer (but I don't know whether it uses to be passed):
https://testing.zephyrproject.org/daily_tests/v2.5.0-rc1-190-g0ab1372b7c87/report/index.html
To Reproduce
Steps to reproduce the behavior:
0. be sure that map.yaml contains fixture spi_llopback for the board used

sanitycheck -N --device-testing --hardware-map ../map.yaml -c -p nucleo_f429zi -T tests/drivers/spi/spi_loopback/
see twister logs

Expected behavior
Test Passed
Logs and console output
$ cat twister-out/twister_discard.csv
test,arch,platform,reason
tests/drivers/spi/spi_loopback/drivers.spi.loopback,arm,nucleo_f429zi,Not runnable on device

Environment (please complete the following information):

OS:  Linux
Toolchain Zephyr SDK
Commit SHA: 0ab1372b7c87

@ABOSTM what does the contents of your ../map.yaml look like?

If I do scripts/twister --device-testing  -c -p nucleo_f429zi -T tests/drivers/spi/spi_loopback/ -X spi_loopback -v -v
That seems to build and try and run drivers.spi.loopback.  So maybe something w/regards to the map.yaml and specifying the FIXTURE.

@galak
here is an extract of my map.yaml
- available: true
  connected: true
  fixtures:
  - gpio_loopback
  - spi_loopback
  id: 067AFF323535474B43094111
  platform: nucleo_f429zi
  product: STM32 STLink
  runner: openocd
  serial: /dev/ttyACM12

I guess it is good as it used to work some time ago.
I agree with you, when adding fixture directly on the command line, it is working fine
scripts/twister --device-testing -c -p nucleo_f429zi -T tests/drivers/spi/spi_loopback/ -X spi_loopback
but not with map.yaml


Feat(dep): migrate to pnpm

Description
yarn is ok. But pnpm is better.

it saves disk space by only ever saving a single copy of a version of a package, and using hard links to reference the package in a project. Also, this enables it to resolve dependency trees much faster than its peers.

Screenshots
No response
Additional Information
No response

@sboy99 please check it.


MultiLevel Schema

Hi all, Im needing to create a multi level schema like:
Item1 | Item2 | Item3 |                Item4           |
      |       |       | subitem1 | subitem2 | subitem3 |

Im looking the schema object but Its seems its only defer an array. If there any way to create something like this?
Thanks!

Flat data structure
You are correct: Our data model currently only works with (an array of) flat objects (one per row).
Core dependences
Furthermore, there are a few spots in the Hypergrid core that depend on this flat data structure.
New data model in development
However, we are currently isolating and simplifying the data model and removing those dependencies. This means you could conceivably write your own data model module to accommodate your use case (hierarchical data structure).
Workaround
In the meantime, you might be able to work around this limitation by:

flattening your data, perhaps using dot syntax, before sending
use the grouped headers plugin to get the kind of output suggested by your data diagram

Flatten your data
Before PUTing your data, transform to a flat structure, perhaps using dot syntax.
For example, rather than sending (where "..." represents data):
[
    {
        "Item1": ...,
        "Item2": ...,
        "Item3": ...,
        "Item4": {
            "subitem1": ...,
            "subitem2": ...,
            "subitem3": ...
        }
    },
    ...
]

send this instead:
[
    {
        "Item1": ...,
        "Item2": ...,
        "Item3": ...,
        "Item4.subitem1": ...,
        "Item4.subitem2": ...,
        "Item4.subitem3": ...
    },
    ...
]

Use the grouped headers plugin
This plugin renders grouped column headers (to any depth). There are several options, but the only requirement is a map, which for the above example would look like this:
grid.behavior.getActiveColumn[0].header = "Name|First";
grid.behavior.getActiveColumn[1].header = "Name|Last";

Hypergrid plugins are currently being moved to a new home (repo). See the readme for plugin for a link to the API docs and for installation and usage details. (If this link is not working yet, download this zip file. You'll have to wait for the wiki and the associated docs. In the meantime you can read the jsdoc comments.)

You are awesome!!! thanks a lot!


Documentation for Revery.UI

I cloned and built revery-quick-start and started looking through App.re to see how it all works. I noticed it opens Revery.UI but there didn't seem to be any documentation for things like Opacity and View on https://www.outrunlabs.com/revery/api/revery/. Poking around I managed to guess the URL and found them at https://www.outrunlabs.com/revery/api/revery/revery_ui/ and https://www.outrunlabs.com/revery/api/revery/revery_ui_primitives/
Looks like https://github.com/revery-ui/revery/blob/master/src/index.mld needs to be updated. I've got the docs building locally now. I can open a PR with them added if you like.

Thanks for reporting :) We use odoc to generate documentation. Their is some work to allow to generate programmatically the .mld (and the whole website) so our docs pages will stay up to date. I don't know the state/branch where we can see the progress done.
We can add it manually for now. Do you want I do ?
In case we have forgotten some other modules you can just have the list of argument by peeking inside the source. We respect the rule: "One component per file" so the Opacity component is defined here https://github.com/revery-ui/revery/blob/master/src/UI_Primitives/Opacity.re#L4 You can use the "find file" feature of GitHub to help you :)

We can add it manually for now. Do you want I do ?

I'm happy to do it if that's what you mean. I worked out how to build the docs already.

Ok open a PR then :) I will review and merge if it is ok :)


FALCON-1928 Updating default startup.properties to add FalconJPAService

👍

+1 . Looks good.

Merging the patch.


FBC-255 - Revise the MIC codes per the latest release (June 2020)

Signed-off-by: Elisa Kendall<EMAIL_ADDRESS>Description
Updated the business centers and MIC codes to reflect the latest June 2020 release from ISO
Fixes: #1054 / FBC-255
Checklist:

[x] I'm familiar with the FIBO developer quide. My contribution meets all the requirements described there.
[x] My contribution follows the principles of best practices for FIBO.
[x] My changes have been reconciled with latest master and no merge conflicts remain.
[x] This PR is related to exactly one issue. The issue is referenced by using a GitHub keyword such as "fixes", "closes", or "resolves".
[x] Hygiene tests have been applied by a PR with "(WIP)" in title.
[x] The issue has been tested locally using a reasoner (for ontology changes).

@ElisaKendall if you get a chance please push an update to BusinessCentersIndividuals as I requested to change the rdfs:labels to Boca Raton (with a space) and Bryanston, Sandton (with a space and comma) so that they will match the names downloaded from ISO.

@rivettp done


Check whether the RPi OS works on Raspberry Pi 3 Model B+

I expect everything to work fine, though I don't have this device.

I accidentally bought a Raspberry Pi 3 Model B+ instead of the 3 Model B. I could give it a try :P

@evopen mentioned that he works with RPi 3 b+ https://github.com/s-matyukevich/raspberry-pi-os/issues/40 I think I can close this issue now.

I didn't speak up because I only went through two lessons. I thought that's not gonna be enough. Never mind~

I follow the given instructions but fail to see 'hello world' on RPi 3b+.
:(
Any suggestion?@s-matyukevich

I meet the same problem on my PI 3b+, @lche Can you run it on your 3b+?

@zijian-z Sorry, it's been a while since I've touched this. I'll have to confirm later when I have the spare cycles :(

Recently, I successfully boot a custom OS on 3b+.
If you want to boot RPi OS on 3b+, maybe you can have a try with adding 'enable_uart=1' in the config.txt.


Prop.exists fails when used with ScalaTest matchers

Hi,
I sent this to the ScalaCheck mailing list at google groups but it doesn't get published.
I have a problem about using ScalaTest matchers inside a Prop.exists property. When the property runs and a value is generated such that the matcher fails, it throws a TestFailedException and the property fails, instead of trying with the next generated value until reaching the limit in the number of tests. I guess this is because ScalaTest is designed around TestFailedExceptions, while ScalaCheck is designed around Prop objects. I have devised the following workaround, and I wanted to you what you think about it:
import org.scalacheck.{Properties, Gen}
import org.scalacheck.Prop.{forAll, exists, AnyOperators}
import org.scalacheck.Prop
import org.scalatest._
import org.scalatest.Matchers._
import scala.util.{Try, Success, Failure}
import org.scalacheck.util.Pretty

object ExistsBrokeTest extends Properties("Breaking Prop.exists with ScalaTest matchers") {
  property("forAll works ok with ScalaTest matchers, for successful tests") =
    forAll { x : Int =>
      x + x should be (2 * x)
      true
    }

  property("forAll works ok with ScalaTest matchers, for failing tests") =
    forAll { x : Int =>
      x + x should be (2 * x + 1)
      true
    }

  property("exists works ok without ScalaTest matchers") =
    exists ("x" |: Gen.choose(1, 20)) { x : Int =>
      x ?= 1
    }

  property("exists fails with ScalaTest matchers, for otherwise successful tests") =
    exists ("x" |: Gen.choose(0, 10)) { x : Int =>
      x should be (1)
      true
    }

  property("exists works ok with ScalaTest matchers wrapped by Try") =
    exists ("x" |: Gen.choose(0, 10)) { x : Int =>
      Try(x should be (1)).isSuccess
  }

  def safeProp[P <% Prop](p : => P) : Prop = {
    Try(p) match {
      case Success(pVal) => pVal
      case Failure(t) => t match {
        case _: TestFailedException => Prop.falsified
        case _ => Prop.exception(t)
      }
    }
  }

  def safeExists[A, P](g: Gen[A])(f: (A) => P)
                      (implicit pv: (P) => Prop, pp: (A) => Pretty): Prop = {
    exists(g)((x : A) => safeProp(pv(f(x))))(identity[Prop], pp)
    // This doesn't work for reasons unknown
    // exists(g)((x : A) => Prop.secure(pv(f(x))))(identity[Prop], pp)
  }

  property("safeExists works ok with ScalaTest matchers, for successful tests") =
   safeExists("x" |: Gen.choose(0, 10)) { x : Int =>
     x should be (1)
     true
   }

  property("safeExists works ok with ScalaTest matchers, for failing tests") =
   safeExists("x" |: Gen.choose(0, 10)) { x : Int =>
     x should be (1000)
     true
   }
}

+ Breaking Prop.exists with ScalaTest matchers.forAll works ok with ScalaTe
  st matchers, for successful tests: OK, passed 100 tests.

! Breaking Prop.exists with ScalaTest matchers.forAll works ok with ScalaTe
  st matchers, for failing tests: Exception raised on property evaluation.
> ARG_0: -2147483648
> Exception: org.scalatest.exceptions.TestFailedException: 0 was not equal
  to 1
org.scalatest.MatchersHelper$.newTestFailedException(MatchersHelper.scala:1
  60)
org.scalatest.Matchers$ShouldMethodHelper$.shouldMatcher(Matchers.scala:623
  1)
org.scalatest.Matchers$AnyShouldWrapper.should(Matchers.scala:6265)
es.ucm.fdi.sscheck.ExistsBrokeTest$$anonfun$2.apply$mcZI$sp(ExistsBrokeTest
  .scala:20)
es.ucm.fdi.sscheck.ExistsBrokeTest$$anonfun$2.apply(ExistsBrokeTest.scala:1
  9)

+ Breaking Prop.exists with ScalaTest matchers.exists works ok without Scal
  aTest matchers: OK, proved property.
> x: 1

! Breaking Prop.exists with ScalaTest matchers.exists fails with ScalaTest
  matchers, for otherwise successful tests: Exception raised on property ev
  aluation.
> x: 3
> Exception: org.scalatest.exceptions.TestFailedException: 3 was not equal
  to 1
org.scalatest.MatchersHelper$.newTestFailedException(MatchersHelper.scala:1
  60)
org.scalatest.Matchers$ShouldMethodHelper$.shouldMatcher(Matchers.scala:623
  1)
org.scalatest.Matchers$AnyShouldWrapper.should(Matchers.scala:6265)
es.ucm.fdi.sscheck.ExistsBrokeTest$$anonfun$3.apply$mcZI$sp(ExistsBrokeTest
  .scala:31)
es.ucm.fdi.sscheck.ExistsBrokeTest$$anonfun$3.apply(ExistsBrokeTest.scala:3
  0)

+ Breaking Prop.exists with ScalaTest matchers.exists works ok with ScalaTe
  st matchers wrapped by Try: OK, proved property.
> x: 1

+ Breaking Prop.exists with ScalaTest matchers.safeExists works ok with Sca
  laTest matchers, for successful tests: OK, proved property.
> x: 1

! Breaking Prop.exists with ScalaTest matchers.safeExists works ok with Sca
  laTest matchers, for failing tests: Gave up after only 0 passed tests. 10
  1 tests were discarded.

Also, I have noticed that org.scalatest.prop.GeneratorDrivenProperyChecks doesn't define exists, is there any technical reason for that?  I would be glad to work on it if you think it is possible,
Thanks a lot in advance.
Greetings,
Juan Rodriguez Hortala

Hi,
It's been almost a moth, any thoughts on this?

@juanrh Did you see Bill's reply in https://groups.google.com/d/msg/scalacheck/Ped7joQLhnY/gNH0SSWkKUgJ?

Hi,
I hadn't seen that, thank you for the pointer. I'll close the issue then.
Thanks a lot for your help.
Greetings,
Juan


Issue with NimBLERemoteCharacteristic::writeValue (for std::string) - strings with nulls get truncated

In the overload for NimBLERemoteCharacteristic::writeValue that takes a std::string as an argument, if a string is passed that contains nulls, it gets truncated. The reason is it's using strlen(newValue.c_str()) to determine the length, but that will stop at the first null. A safer way to do this (and I tested) is to instead use newValue.length() which is made for std::string and uses the actual string length instead of looking for a null termination in a C string.
From NimBLERemoteCharacteristic.cpp:
Original:
bool NimBLERemoteCharacteristic::writeValue(const std::string &newValue, bool response) {
    return writeValue((uint8_t*)newValue.c_str(), strlen(newValue.c_str()), response);
} // writeValue

Corrected:
bool NimBLERemoteCharacteristic::writeValue(const std::string &newValue, bool response) {
    return writeValue((uint8_t*)newValue.c_str(), newValue.length(), response);
} // writeValue

Here's a quck test I did to demonstrate the issue:
const std::string testStr = { 0x41, 0x42, 0x43, 0x00, 0x44, 0x45 };
const byte testStrB[6] = { 0x41, 0x42, 0x43, 0x00, 0x44, 0x45 };

void hexPrint(const uint8_t* s, size_t len) {
  for (int n = 0; n < len; n++) {
    Serial.printf("%02X ", s[n]);
  }
  Serial.println();
}

void hexPrint2(const std::string &s) {
  hexPrint((uint8_t*)s.c_str(), strlen(s.c_str()));
}

void hexPrint3(const std::string &s) {
  hexPrint((uint8_t*)s.c_str(), s.length());
}

void setup() {
  Serial.begin(115200);
  delay(500);
  Serial.print("uint8_t passed directly, with length specified: "); //No issue
  hexPrint(testStrB, 6);
  Serial.print("string converted to c_str cast to uint8_t*, with length specified: "); //No issue
  hexPrint((uint8_t*)testStr.c_str(), 6);
  Serial.print("string sent, converted in helper function using c_str and cast, and using strlen on c_str: "); //Truncated
  hexPrint2(testStr);
  Serial.print("string sent, converted in helper function using c_str and cast, and using string::length: "); //No issue
  hexPrint3(testStr);
}

void loop() {
}

Thanks, no idea how that went unnoticed for this long, good catch. Would you like to PR that change?

Sure - I've never done one before but doesn't seem too hard - I'll do that tonight. Thanks!

Thanks, no idea how that went unnoticed for this long, good catch. Would you like to PR that change?

Just guessing, but i think that most people is using std::string as null terminated strings, just like C strings and uint8_t* function in case when you are sending bytes.

I submitted a PR - thanks!

Just guessing, but i think that most people is using std::string as null terminated strings, just like C strings and uint8_t* function in case when you are sending bytes.

Probably, but there have been a few places where this behavior was noted and never even thought about that code haha.


quic: turn off GRO in client connection

Signed-off-by: Dan Zhang<EMAIL_ADDRESS>Commit Message: hard code prefer_gro to false. The performance of GRO hasn't been evaluated yet, so it shouldn't be default on.
Risk Level: low
Testing: existing tests pass

/assign @RyanTheOptimist

This change looks good. Should we consider making this configurable?

Eventually yes, we probably want to add a client side config knob somewhere. But right now the GRO implementation has some issues already and its performance hasn't been measured. So I think not exposing it is the best way.

This change looks good. Should we consider making this configurable?

Eventually yes, we probably want to add a client side config knob somewhere. But right now the GRO implementation has some issues already and its performance hasn't been measured. So I think not exposing it is the best way.

Sounds good. Would you mind filing an issue about this so we have it recorded?


Hardcoded ProjectVersion

Currently uTinyRipper hardcodes ProjectVersion.txt to be:
m_EditorVersion: 2017.3.0f3
I believe this should be the version of Unity that was last used to open the project, which AFAIK isn't stored in asset files and thus can't be retrieved.
Should the version of Unity that built the asset files (BuildingSettings->m_Version) be used as a proxy, rather than this hardcoding?

It is funny that there are people who are interested in this version. Recently, there was a pull request that tried to change it.
This version tell unity what is the version of assets in this project. If this version doesn't match to editor version, unity will update assets. Otherwise it can't work with them. Ripper exports most of the assets as 2017.3.0f3. You need to inform unity about that, so it can convert those assets into appropriate format. That's why this version is hardcoded.

Ah, I wasn't aware that there was a specific asset format version that uTinyRipper is using.
People are interested in it because it's confusing. Most docs/help on introspecting Unity project version refer to ProjectSettings.txt (for Unity 5+). When I opened ProjectVersion.txt up and saw its version did not match expected versions for old asset files (like those created in Unity 4 or 5) vs later ones (like those created in Unity 2019), I was perplexed.
The actual Unity build version (BuildingSettings->m_Version) isn't actually extracted anywhere, right?

Actual build version is used only by ripper to properly read assets. Ripper convert all read assets into 2017.3 version format. Then, when you open extracted project in editor, unity convert all assets (exported by ripper in 2017.3 format) into its version. That is obviously not ideal way of how this tools should work, but for now this is the only way.


Why are not reflecting my verus coin in my account

Please help on this matter

Please help

Your issue is unrelated to this library.
I assume you're talking about mining.
You can check the faqs here.
https://pangz-lab.github.io/verusminer/


Next suggested route is sometimes a bit illogical

Sometimes the suggestion chooses 90 degree angle instead of straight line

Has been fixed (now 100% consistent)


"Check For Updates..." feature

Or at least, add link to this repository in the "About" window, so it will be possible to go and check manually, is new version available :)

@victordidenko
Implemented, will be available in v0.0.9!


Revert "attempt to fix the _a.destroy is not a function error"

Reverts backstage/backstage#24992
Maybe the build errors that happened because of this can give some insight into where the "leak" happens, something is going on between tests I think https://github.com/backstage/backstage/actions/runs/9309084380/job/25623928502?pr=24997#step:10:10246

Quick merge to unbreak master


Force menu to open below

Hi,
Is it possible to force the menu to open below ?
When there's no much vertical space, the menu open above and first options aren't visible :

I tried position property without luck.
Thanks!

@pvictor I will check the possibilities and fix it if it is an issue.

It seems that, the decision to open upwards does not take into account how much space is available above.
That is, if there's not enough space to open downwards (b/c of lack of space) it always opens upwards.
Preferrably, it should check if there's enough space in both directions, and select the one with most space.
I've been trying to utilize the beforeOpen event to do the necessary space checks and then set the position property based on that. But it does not seem possible to set the option? :(
It would also be nice if the menu could be resized to available space (if less than optionsCount fit). This should probably be an option, though.

And yeah, maybe more on topic, setting position to bottom still opens the menu upwards if there's not enough space below.

Any update on that issue ? It's a l ittle frustrating on small screens, here's an exagerated example with the demo site :

Still an issue for me :pray:

I looked into this issue and it seems it is an issue in js code that https://sa-si-dev.github.io/popover/ generates.
I managed to fix it by manually editing the js code there, although this is probably not the proper way, and only fixes the issue if you set the default behavior to the bottom.
The normal code looks if there is enough space below to draw the option list, if not it draws above.
If you change this line
{var L=G[n];"top"===(C=n)||"bottom"===C?E=L.top:"left"!==C&&"right"!==C||(k=L.left)}

into this
{if(n==="top"&&u>x) {} else {var L=G[n];"top"===(C=n)||"bottom"===C?E=L.top:"left"!==C&&"right"!==C||(k=L.left)}}

it will also check if the there enough space above (x) for the option list (u), if so it will draw above otherwise if falls back to drawing below. I hope it helps

Any update on that issue?


Update google-cloud-bigquery to 2.7.1

Updates com.google.cloud:google-cloud-bigquery from 2.6.2 to 2.7.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.google.cloud", artifactId = "google-cloud-bigquery" } ]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Codecov Report

Merging #141 (2a5bc51) into master (aead83c) will decrease coverage by 4.95%.
The diff coverage is 43.51%.

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   67.75%   62.79%   -4.96%
==========================================
  Files         123      125       +2
  Lines        5266     5368     +102
  Branches      278      257      -21
==========================================
- Hits         3568     3371     -197
- Misses       1698     1997     +299

Flag
Coverage Δ

unittests
62.79% <43.51%> (-4.96%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...c/main/scala/ai/starlake/job/ingest/AuditLog.scala
46.15% <ø> (ø)

...i/starlake/job/sink/bigquery/BigQueryJobBase.scala
21.80% <ø> (ø)

...tarlake/job/sink/bigquery/BigQueryLoadConfig.scala
88.88% <ø> (ø)

...starlake/job/sink/bigquery/BigQueryNativeJob.scala
0.00% <ø> (ø)

.../starlake/job/sink/bigquery/BigQuerySparkJob.scala
18.75% <ø> (ø)

...n/scala/ai/starlake/job/sink/es/ESLoadConfig.scala
70.37% <ø> (ø)

...main/scala/ai/starlake/job/sink/es/ESLoadJob.scala
83.05% <ø> (ø)

...ala/ai/starlake/job/sink/http/HttpSinkClient.scala
0.00% <0.00%> (ø)

.../starlake/job/sink/jdbc/ConnectionLoadConfig.scala
97.43% <ø> (ø)

.../ai/starlake/job/sink/jdbc/ConnectionLoadJob.scala
93.33% <ø> (ø)

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1697b9a...2a5bc51. Read the comment docs.


⚠ GitLab Server has degraded performance

In 555cb5b, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 6732 ms

Resolved: GitLab Server performance has improved in a7f9ef2.


Add proper shutdown for TokenizerWorker

Hello @jorgeantonio21, I would like to know more details about this issue to start working on it now. I hope to be assigned.

I’d like to help with this.

Can I handle this task?


Change MSD size to match real flash size

Currently, the total size of the mass storage device shows 116MB, from which 115MB are free (according Windows Explorer).
It would be better to display the actual sizes:

Total Memory = DEV_FLASH_SIZE
Free Memory = APP_SIZE

Furthermore, it would be better to define a new compiler constant for the bootloader size and use it for calculating APP_ADDR and APP_SIZE in btldr_config.h

The minimum FAT32 disk size is 32MB, it cannot indicated 64KB flash capacity.

You are right about the minimum capacity.
Then could we at least have a total volume of 32MB where only 64KB minus BOOTLOADER_SIZE is free and the rest is occupied?

Do you have the information how e.g. Windows calculates the free space of a FAT32 partition?
Unfortunately I can't find anything in the internet, so I don't know how to realize it.

http://elm-chan.org/fsw/ff/doc/getfree.html

No, I did not succeed. I tried different configuration parameters for the FAT32 partition, but this did not lead to the intended change. Unfortunately, I'm not deep enough into the FAT32 internals. I would appreciate if anybody could help.


Dependencies

Hello.
I've opened an issue on ducks-modular-redux about it, but I would like to open it here too because I would like to know the opinions from Redux developers.

Is a bad practice importing "third-party" actions inside a module? Example:

// users.js

import { callAPI } from '../helpers';
import { showNotification } from './notifications';

export default function reducer(...) {}

export function login(username, password) {
  return dispatch => {
    return callAPI('post', '/auth/login', { username, password })
    .catch(() => dispatch(showNotification('error', 'Invalid username or password'));
  };
}

Is a bad practice handling "third-party" actions inside a reducer? Example:

// notifications.js

import _ from 'lodash';

const initialState = { notifications: [] };

export default function reducer(state = initialState, action) {
  if (action.type === 'SHOW_NOTIFICATION') {
    return _.assign({}, state, {
      notifications: [...state.notifications, {
        id: new Date().toISOString(),
        type: action.payload.type,
        message: action.payload.message
      }]
    });
  }
  if (action.type === 'HIDE_NOTIFICATION') {
    return _.assign({}, state, {
      notifications: _.reject(state.notifications, { id: action.payload.id })
    });
  }
  // It's what I call "third-party" action, this action belongs to another module
  // Of course it should be an imported constant, but it's just an example
  if (action.type === 'LOGOUT_SUCCESS') {
    return initialState;
  }
  return state;
}

export function showNotification(type, message) {
  return { type: 'SHOW_NOTIFICATION', payload: { type, message } };
}

export function hideNotification(id) {
  return { type: 'HIDE_NOTIFICATION', payload: { id } };
}

It looks just fine to me.
This is exactly why we don't encourage the “ducks” approach in the official docs (although we don't discourage it either—use what works best for you).
It should be very clear that having many reducers handle the same action is fine, and in fact the very reason why you'd want to use Redux—if you don't need to do this, you might as well not use actions to decouple state mutations from components, and instead use cursors to operate on the tree directly.

Thank you for the quick answer ;)

@gaearon https://github.com/erikras/ducks-modular-redux/issues/27 toughts?


 Can you try current master and I think you will get an error?

I'lll try that , thanks


add-trapti77

What does this PR do?
Fixes #(issue)
Type of change

Bug fix (non-breaking change which fixes an issue)
Chore (refactoring code, technical debt, workflow improvements)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How should this be tested?

[ ] Test A
[ ] Test B

Mandatory Tasks

[ ] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

I haven't read the contributing guide
My code doesn't follow the style guidelines of this project
I haven't commented my code, particularly in hard-to-understand areas
I haven't checked if my PR needs changes to the documentation
I haven't checked if my changes generate no new warnings
I haven't added tests that prove my fix is effective or that my feature works
I haven't checked if new and existing unit tests pass locally with my changes

Everything seems alright. Make sure to drop a star ⭐ to the repository


fix lint warnings

Signed-off-by: Taras Drozdovskyi<EMAIL_ADDRESS>Description
PR fixes the golint warnings, except one: type name will be used as verifier.VerifierConf by other packages, and that stutters; consider calling this Conf. Replacing this name can lead to confusion, in addition, the staticcheck does not take into account this as a warning
Related to #353
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] Code cleanup/refactoring

How Has This Been Tested?
$ golint ./internal/restinterface/route/tlsserver/...
$ golint ./internal/controller/securemgr/...

Test Configuration:

Firmware version: Ubuntu 18.04, etc.)
Hardware: x86-64
Edge Orchestration Release: v1.0.0

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Are you going to exclude the golint job from workflows?
If not, it would be nice to address the warning "type name will be used as verifier.VerifierConf by other packages, and that stutters; consider calling this Conf"

Are you going to exclude the golint job from workflows?

I have not yet exclude the golint since still many warnings is detected from it and warnings are detected using the Go report (inside is using golint).

If not, it would be nice to address the warning "type name will be used as verifier.VerifierConf by other packages, and that stutters; consider calling this Conf".

I will think how it can be done!

Are you going to exclude the golint job from workflows?

I have not yet exclude the golint since still many warnings is detected from it and warnings are detected using the Go report (inside is using golint).

If not, it would be nice to address the warning "type name will be used as verifier.VerifierConf by other packages, and that stutters; consider calling this Conf".

I will think how it can be done!

If we do not exclude golint, we will get this warning continuously.
I'd like to exclude golint (after fixing #353) or fix this warning.
What do you think?

If we do not exclude golint, we will get this warning continuously.
I'd like to exclude golint (after fixing #353) or fix this warning.
What do you think?

I think that after fixing we can exclude the golint from workflow. But it should be noted that we use the golint in mode where it always returns a successful result.


test-bot: use --eval-all.

Needed due to https://github.com/Homebrew/brew/pull/13790

This is needed in tap-syntax too, no? Had a different approach: #829


CI failures after adding a gccgo test environment

After PR #1071 was merged we started seeing failures such as this. That PR was based on the master branch plus a trivial comment. The error in each case looks like this:
/usr/bin/ld: $WORK/b057/_pkg_.a(_go_.o): in function `github.x2ecom..z2felves..z2felvish..z2fpkg..z2fcli..z2faddons..z2fhistwalk.Prev':
/tmp/cirrus-ci-build/pkg/edit/ /tmp/cirrus-ci-build/pkg/cli/addons/histwalk/histwalk.go:86: undefined reference to `github.x2ecom..z2felves..z2felvish..z2fpkg..z2fcli..z2faddons..z2fhistwalk.github.x2ecom..z2felves..z2felvish..z2fpkg..z2fcli..z2faddons..z2fhistwalk..thunk1..f'
/usr/bin/ld: /tmp/cirrus-ci-build/pkg/edit/ /tmp/cirrus-ci-build/pkg/cli/addons/histwalk/histwalk.go:86: undefined reference to `github.x2ecom..z2felves..z2felvish..z2fpkg..z2fcli..z2faddons..z2fhistwalk.github.x2ecom..z2felves..z2felvish..z2fpkg..z2fcli..z2faddons..z2fhistwalk..thunk0..f'
/usr/bin/ld: warning: creating DT_TEXTREL in a PIE
collect2: error: ld returned 1 exit status

@zhsj, Since you authored the change to the CI configuration that added support for testing builds using gccgo you're probably the person in the best position to debug this problem.

This is caused by https://github.com/elves/elvish/commit/3501b945aa9f41a4c27d1695a51eb720a60ebaf3 which triggers a gcc bug https://github.com/golang/go/issues/40252

Thanks for being proactive, @zhsj, in already reporting this to the Go team. Does this mean that building elvish from git master now fails on Debian using gccgo? That is, not just in the CI test environment? If so should the problematic commit be reverted in whole or part? If not is there something we can do to make this work on the CI gccgo environment? Otherwise I think the CI gccgo environment needs to be disabled until the underlying problem is resolved. People contributing changes shouldn't have to wonder if their change broke the build.


Adding team to readme

Added class, team name, and team to the readme

Good work.
On Sep 4, 2016 22:35, "jamran7"<EMAIL_ADDRESS>wrote:

Added class, team name, and team to the readme
You can view, comment on, or merge this pull request online at:
https://github.com/ChainsawFist/brackets/pull/1
Commit Summary

Added the team and teamname to the readme
Fixing readme so that my name is not a heading
Fixing team plack on readme
Teamnames: Chris' name didn't match the rest
Added instructors
removed extra comma
Added back the second name reference

File Changes

M README.md
https://github.com/ChainsawFist/brackets/pull/1/files#diff-0 (18)
A ~$README.md
https://github.com/ChainsawFist/brackets/pull/1/files#diff-1 (0)

Patch Links:

https://github.com/ChainsawFist/brackets/pull/1.patch
https://github.com/ChainsawFist/brackets/pull/1.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ChainsawFist/brackets/pull/1, or mute the thread
https://github.com/notifications/unsubscribe-auth/AQOnkzLd733fSvz4ezU5kwfwcnahmAE6ks5qm3_VgaJpZM4J0smQ
.


chore: remove experimentalGlobalPassThroughEnv from schema

Description
Remove this from the schema as we currently don't respect it and globalPassThroughEnv has been around for some time.
Testing Instructions
👀 + a quick rg -F 'experimentalGlobalPassThroughEnv' to verify we never actually read this.
Closes TURBO-2678

Closing as it looks like our codemods require that this field exist to help update people. Not worth uncoupling at this moment.

Believe this is done now!


Things to fix from initially shared file

Leaving a list of items to adjust from the first draft file shared

[ ]  Pupil tracking, eye tracking, and treadmill velocity all have negative timestamps - I'd usually say it's best to align the session start time with the earliest timestamp in the file (currently seems aligned to the visual stimulus timestamps which are also sync'd with the timestamps for the ROI responses?) to avoid confusion
[ ] First 20 values (of both data and timestamps) of the treadmill velocity are NaN - feel free to clip those out (other files may have different # of NaN's, or none at all)
[ ] Similarly, for pupil and eye tracking, the data (but not the timestamps) start off as NaN's; no reason to include these at the start, feel free to clip and start the series at the first non-NaN value
[ ] Would love to get a reference frame for the eye tracking
[x] Would like units on the treadmill velocity (in distance over time)
[ ] Would also love units on the pupil and eye tracking (though this could maybe be judged from the scale of the data range relative to the subject species)
[ ] units on origin_coords for imaging planes is in meters but based on values I'm guessing should be micrometers or less?
[ ] The first ImagingPlane and ROIResponseSeries in each group does not start with an integer index on the end; for consistency, I'd recommend adding that
[ ] Also the ROIResponseSeries and plane segmentations seem to count from 1-based index whereas the ImagingPlanes seem to start from 0-based index. I'd pick one to be consistent (preference for 0-based but doesn't really matter)

Otherwise looking really good so far

Pupil tracking, eye tracking, and treadmill velocity all have negative timestamps - I'd usually say it's best to align the session start time with the earliest timestamp in the file (currently seems aligned to the visual stimulus timestamps which are also sync'd with the timestamps for the ROI responses?) to avoid confusion

We are currently using the "raw" data for them, however they also have them synchronised with field 1 frame times (and low-pass filtered). Can we use those tables instead of raw? The stimulus timestamps are also aligned to those same frame times.

We are currently using the "raw" data for them, however they also have them synchronised with field 1 frame times (and low-pass filtered).

Sorry, can you clarify? Are the raw data timestamps for pupil, eye, and treadmill 'synchronized' with the other data in the file in the sense that they are all currently within the same time basis? My point was that the relative start time of all time references in the file was not itself shifted to be the earliest time stamp.
If there are additional processed forms of that data that they also have available, such as filtered, then yes we might as well include it. When you say the processed data is 'synchronized', do you just mean they just clipped off all the time before the recording started?

When you say the processed data is 'synchronized', do you just mean they just clipped off all the time before the recording started?

I have to verify that from the actual data, I saw this in the technical documentation  for instance :

2.5 ManualPupil
Traces from RawManualPupil were low-pass filtered with a hamming window to the scan frame rate and linearly interpolated to field 1 scan frame times.


k-branch-1

Pull Request Description
Title: k-branch-1
Description:
This pull request includes the following changes:
. Dependency Updates:
Updated React and Emotion to their latest versions to ensure compatibility and take advantage of the latest features and improvements.

Feature Enhancement:

Refactored the company creation logic within the SideBar component for better maintainability and performance.
Introduced a new Company component to encapsulate company-related functionalities, improving the overall structure of the codebase.

These changes aim to enhance the application's performance and maintainability while providing a better foundation for future development. Please review the modifications and provide any feedback.


cant convert form 1.15 back to older versions

i wish to converty 1.15 to older version so i got new texures in older version of mc.

I plan on forking this and doing this

https://github.com/jsdevv/ResourcePackConverter
@jsdevv i see you forked it, gotta work on it i guess lmao

https://github.com/jsdevv/ResourcePackConverter
@jsdevv i see you forked it, gotta work on it i guess lmao


The onUIRefreshPrepare will called twice when I use setEnabledNextPtrAtOnce

The onUIRefreshPrepare will called twice when I use setEnabledNextPtrAtOnce,this call some mistake when I use UIRefreshPrepare to change same text in header.

I have the same problem!


[BUG/Feature Request]: Reusing a step overwrites artifact names

Contact Details [Optional]
No response
System Information
N/A
What happened?
(Issue already discussed in this slack thread, logging here for easier tracking)
Currently, the names used for saving artifacts in a step are determined by the type annotation in the function definition.
This works great when a step is only used once in a pipeline, but not so much when the same step needs to be called multiple times with different inputs, and the resulting artifacts need to later be used in a different pipeline. When that happens, the output artifacts get saved with the same name and a bumped version number, which makes it really hard to track the specific one needed later down the road.
Typical example of this: training some preprocessor that later needs to be used three different times for transforming train, validation, and test data, and I end up with three versions of an object called transformed_data and need to keep track of which is which.
Returning outputs from pipelines quickly gets out of control and is very hard to maintain when there are lots of artifacts that might potentially be reused later.
Suggested solution: Similar to how a step name (usually the function name) can be overriden at run time by the id parameter when calling the step, introduce an optional parameter to step calls (something like output_names: Optional[Dict[str, str]] where the dict must contain the names defined in the function type annotations as keys and the desired saved names as values) overriding the saved names of the outputs. If that parameter is not passed, things should behave as they currently do, but when passed the produced artifacts should be saved with the passed names.
Reproduction steps
No response
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hey @jlopezpena , thanks for reporting, and sorry about the delay in responding to this!
This is indeed not possible in the current setting and to overcome this in our LLM finetuning project, I have used this trick: https://github.com/zenml-io/zenml-projects/blob/main/llm-lora-finetuning/steps/evaluate_model.py#L112
Aside from the workaround, I'll create a ticket to look into what we can do to improve this UX piece. Stay tuned!

Hey @jlopezpena! This just caught my attention. Thanks for bringing up this issue about dynamically naming artifacts in ZenML. It's definitely a tricky situation when you're reusing steps with different inputs. Your idea for an output_names parameter is pretty solid.
While we wait for an official feature to be implemented, I've got a couple of workarounds that might help you out. These use the current ZenML capabilities to tackle the problem:

Using a factory function to cook up steps with custom artifact names:

This approach lets you create dynamically named artifacts by whipping up step functions on the fly:
from typing import Any, Dict
from typing_extensions import Annotated
from zenml import step, ArtifactConfig

def create_dynamic_step(prefix: str):
    @step
    def dynamic_step(data: Any) -> Annotated[Dict[str, Any], ArtifactConfig(name=f"{prefix}_artifact")]:
        # Do your data processing magic here
        result = {"processed_data": data}
        return result

    return dynamic_step

# Here's how you'd use it
train_step = create_dynamic_step("train")
val_step = create_dynamic_step("validation")
test_step = create_dynamic_step("test")

@pipeline
def dynamic_artifact_pipeline(train_data, val_data, test_data):
    train_step(train_data)
    val_step(val_data)
    test_step(test_data)

This way, you get unique artifact names for each step, making it a breeze to track and grab specific artifacts later.

Using metadata to slap a custom identifier on your artifacts:

If you'd rather stick with a single step and use metadata to tell your artifacts apart, try this:
from typing import Any, Dict
from typing_extensions import Annotated
from zenml import step, get_step_context

@step
def generic_step(data: Any, prefix: str) -> Annotated[Dict[str, Any], "generic_artifact"]:
    result = {"processed_data": data}

    # Sprinkle in some custom metadata
    step_context = get_step_context()
    step_context.add_output_metadata(
        output_name="generic_artifact",
        metadata={"custom_prefix": prefix}
    )

    return result

@pipeline
def metadata_artifact_pipeline(train_data, val_data, test_data):
    generic_step(train_data, prefix="train")
    generic_step(val_data, prefix="validation")
    generic_step(test_data, prefix="test")

With this approach, we're using a single generic_step but adding custom metadata to each artifact. The prefix gets stored in the metadata, so you can use it later to identify and differentiate between artifacts:
from zenml.client import Client

client = Client()
artifacts = client.list_artifact_versions("generic_artifact")
for artifact in artifacts:
    prefix = artifact.run_metadata.get("custom_prefix")
    if prefix == "train":
        train_data = artifact.load()
    elif prefix == "validation":
        val_data = artifact.load()
    elif prefix == "test":
        test_data = artifact.load()

Both of these approaches let you custom-identify your artifacts without messing with ZenML's core functionality. The first option gives you more control over the artifact name itself, while the second keeps the artifact name the same but adds custom metadata for identification.
These solutions should work as temporary fixes while we wait for a more integrated solution like your suggested output_names parameter. They give you some flexibility in naming and identifying artifacts, especially when you're reusing steps with different inputs.
Give these a shot and let me know how they work for you! And hey, if you come up with any other cool workarounds, definitely share them with the community. We're all in this together!

Tested these out and this code works for the two approaches. Posting it here in case someone else reads this thread and wants working code:
Approach 1
from typing import Any, Dict
from typing_extensions import Annotated
from zenml import step, pipeline, get_step_context, ArtifactConfig

def create_step(prefix: str):
    def _entrypoint(data: Any) -> Annotated[Dict[str, Any], ArtifactConfig(name=f"{prefix}_artifact")]:
        context = get_step_context()
        return {"processed_data": data, "step_name": context.step_name}

    step_name = f"dynamic_step_{prefix}"
    _entrypoint.__name__ = step_name
    s = step(_entrypoint)
    globals()[step_name] = s
    return s

# Create the dynamic steps
train_step = create_step(prefix="train")
validation_step = create_step(prefix="validation")
test_step = create_step(prefix="test")

# Resolve the steps
train_step.resolve()
validation_step.resolve()
test_step.resolve()

@pipeline
def dynamic_artifact_pipeline(train_data, val_data, test_data):
    train_result = train_step(train_data)
    validation_result = validation_step(val_data)
    test_result = test_step(test_data)

dynamic_artifact_pipeline(train_data=1, val_data=2, test_data=3)

One caveat applies to this first method which is that either of the following
two things must be true:

The factory must be in the same file as where the steps are defined -> This is
so the logic with globals() works
The user must have use the same variable name for the step as the __name__
of the entrypoint function

As you can see, this is not always possible or desirable and you should probably use
the second method if you can.
Approach 2
from typing import Any, Dict
from typing_extensions import Annotated
from zenml import step, get_step_context, pipeline

@step
def generic_step(data: Any, prefix: str) -> Annotated[Dict[str, Any], "dataset"]:
    result = {"processed_data": data}

    # Add custom metadata
    step_context = get_step_context()
    step_context.add_output_metadata(
        output_name="dataset",
        metadata={"custom_prefix": prefix}
    )

    return result

@pipeline
def metadata_artifact_pipeline(train_data, val_data, test_data):
    generic_step(train_data, prefix="train")
    generic_step(val_data, prefix="validation")
    generic_step(test_data, prefix="test")

metadata_artifact_pipeline(train_data=1, val_data=2, test_data=3)

In the latest ZenML version, we have dynamic artifact naming: https://docs.zenml.io/how-to/data-artifact-management/handle-data-artifacts/artifacts-naming#dynamic-naming. This now resolves this issue so I'll close!


Godot 4-alpha 1 - New Tilemap - Creating tiles with different sizes makes the offset show the texture correctly on the tileset editor, but with the offset axis signs inverted on the tilemap editor.

Godot version
Godot 4 - Alpha 1
System information
Windows 8 and 10
Issue description
Creating tiles with different sizes makes the offset show the texture correctly in the tileset editor, but with the offset axis  signs inverted in the tilemap editor. Making -y offset be y and the -x offset be x.

Probably also affect the painting of bitmasks. Maybe related with 54587
Maybe this sign inversion is happening with tiles of just one unity too, but it doesn't show up because it's a single tile (default 0,0 offset).

Everything ok on the tileset editor, but this offset texture:

Will bring this on the tilemap editor:

And this offset on the tileset editor:

Brings this correctly on the tilemap editor:

Steps to reproduce
Create tiles of different sizes on the tilset editor, set the offset property correctly in the the tileset editor, and make large tiles with this tileset on the tilemap editor. This should happens with terrains too.
Minimal reproduction project
diff_sizes_tiles_bug.zip

Maybe it is somehow flipping the tile position of the texture on the tilemap editor.

I am pretty sure this is the expected behavior. I suppose that you selected all tiles at once in the TileMap selector, and try to paint them all at once.
If this is the case, then this is expected. You wrongly assumed that the tiles would be packed together when painted on the TileMap, but this not how it works. To paint a pack of tiles, the TileMap editor uses the base coordinate (the top-left corner) of the most top-left tile, then it copies the pattern keeping the same space between each tiles. This kind of means it tries to copy the pattern as close to the original as possible, while not considering the texture offset at all.
So basically that mean that, in your case, the pattern is copied somehow like that:
:blue_square: :black_square_button: :blue_square: :blue_square:
:black_square_button: :black_square_button: :black_square_button: :black_square_button:
:blue_square: :black_square_button: :blue_square: :blue_square:
:blue_square: :black_square_button: :blue_square: :blue_square:
and not packed together.
This was implemented to avoid packing together tiles that are not supposed to, and try to respect the spacing between the tiles. I guess it could maybe be improved by trying to consider texture_offset, but that's an improvement.
Until then, I suggest you use the pattern palette or copy-pasting on the TileMap to deal with such patterns.


Define the pinned CPU and memory during the container creation

Signed-off-by: Artyom Lukianov<EMAIL_ADDRESS>
What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Closing in favor of https://github.com/kubernetes/kubernetes/pull/98924


proposal: karate.repeat() API

based on observing Stack Overflow, it looks like besides looping over an existing array (which is what karate.map() is for), a lot of the time people want to do something (like add to an array) X times
example: https://stackoverflow.com/q/55652931/143475
today everyone gets into JS which does cause some pain as seen above.
how about:
* def fun = function(i){ return i * 2 }
* def foo = karate.repeat(5, fun)
* match foo == [0, 2, 4, 6, 8]

* def foo = []
* def fun = function(i){ foo.add(i) }
* eval karate.repeat(5, fun)
* match foo == [0, 1, 2, 3, 4]

@ptrthomas Thanks for taking this issue to closest milestone!

released 0.9.3


Errors while building

After cloning this project I have build errors.  It looks like these following imports don't exist on my machine.
import org.json.simple.JSONObject;
import static com.google.common.collect.Maps.newHashMap;
Should these dependencies be added in the pom?  I've forked a copy and plan on adding these to my pom file to fix my local build but wanted to bring this to your attention.
Below is the maven build error.
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] \development\workspace\javabank\javabank-core\src\main\java\org\mbtest\javabank\http\predicates\Predicate.java:[24,21] error: cannot find symbol
[ERROR] \development\workspace\javabank\javabank-core\src\main\java\org\mbtest\javabank\http\predicates\Predicate.java:[62,19] error: cannot find symbol

Sorry i spoke too soon, i see them in the pom of core .. but i'm still getting those build errors.  Walking through now to see what the problem is

Looks like a proxy issue on my end, sorry.


[Migrated] Zappa requires "future" package under Python 3.x

Originally from: https://github.com/Miserlou/Zappa/issues/1966 by rudyryk
Trying to minify uploaded installation ZIP. Noticed that future package is more than 1.5Mb size, this is far larger than many. But it should not be necessary under Python 3.
Expected Behavior
Don't install and don't require "future" package for Python 3.
Actual Behavior
Zappa CLI can't ZIP package without "future" installed.
Steps to Reproduce

Initialize Zappa project
Uninstall "future" with pip uninstall future
Run zappa --help and get error

Your Environment

Zappa version used: 0.48.2
Operating System and Python version: Python 3.7.4, macOS 10.13.6
pip freeze result

argcomplete==1.9.3
boto3==1.10.25
botocore==1.13.25
certifi==2019.9.11
cfn-flip==1.2.2
chardet==3.0.4
Click==7.0
docutils==0.15.2
durationpy==0.5
Flask==1.1.1
future==0.16.0
hjson==3.0.1
idna==2.8
itsdangerous==1.1.0
Jinja2==2.10.3
jmespath==0.9.3
kappa==0.6.0
lambda-packages==0.20.0
MarkupSafe==1.1.1
peewee==3.11.2
placebo==0.9.0
psycopg2-binary==2.8.4
PyJWT==1.7.1
python-dateutil==2.6.1
python-slugify==1.2.4
PyYAML==5.1.2
requests==2.22.0
s3transfer==0.2.1
sentry-sdk==0.13.2
signa==0.2.1
six==1.13.0
structlog==19.2.0
toml==0.10.0
tqdm==4.19.1
troposphere==2.5.2
Unidecode==1.1.1
urllib3==1.25.7
Werkzeug==0.16.0
wsgi-request-logger==0.4.6
zappa==0.48.2

released, closing


feat: crowdfunding withdrawal card

plus a few touches for bugs and visual adjustments

Do we really need to display the withdrawal card for plain readers (no connected account)? I think it's not necessary @0xferit


Error: undefined method `path' for Hbc::Caskroom:Module

$ brew cu
Error: undefined method `path' for Hbc::Caskroom:Module
/usr/local/Homebrew/Library/Taps/buo/homebrew-cask-upgrade/lib/extend/hbc.rb:1:in `<top (required)>'
/System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Taps/buo/homebrew-cask-upgrade/lib/bcu.rb:6:in `<top (required)>'
/System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Taps/buo/homebrew-cask-upgrade/cmd/brew-cu.rb:32:in `<top (required)>'
/System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Homebrew/Library/Homebrew/utils.rb:18:in `require?'
/usr/local/Homebrew/Library/Homebrew/brew.rb:101:in `<main>'

$ brew --version
Homebrew 1.6.7
Homebrew/homebrew-core (git revision c207e; last commit 2018-06-11)

$ brew cask --version
Homebrew-Cask 1.6.7

Okay there was someone 5 minutes faster than me. ;)


#BI Office(bureau affaire intelligent)with analytics sophisticated depth

BI Office https://apps.microsoft.com/store/detail/bi-office/9WZDNCRDQW99

@tmamb Closing. Open a new issue and describe the question or problem you are having with our product documentation, and include a link to the doc page.


Whether it can be destroyed？

Can you add a destruction mechanism to prevent memory leakage？
Multiple uses occur with the current memory leak

Can you add a destruction mechanism to prevent memory leakage？
Multiple uses occur with the current memory leak

how to reproduce？

Cannot reproduce

Can you add a destruction mechanism to prevent memory leakage？
Multiple uses occur with the current memory leak

how to reproduce？

Cannot reproduce


Doc tweaks

@thomnico I'm confused -- you marked this PR approved, but then closed it. Did you mean to merge it? Or do you want me to make some changes?


fixing concurrent dispatcher test

Changes

🧹 Fixing concurrent dispatcher test adding a Prefetch count > 1, since the default was changed to 1 it was not dispatching concurrently (our CI didn't noticed it but locally and in the CNR tests was failling)

/cherrypick release-1.2

/cherrypick release-1.3


feat: error if divisor is zero

Closes partially #543
Summary of Changes
Show an error if we know that the divisor of a division is zero. Once the partial evaluator gets fully implemented, this will work in more cases.

:tada: This PR is included in version 0.2.0 :tada:
The release is available on:

Visual Studio Marketplace
GitHub release

Your semantic-release bot :package::rocket:


[cxx-interop] Synthesize read accessors to represent C++ [] operators

Previously, C++ [] operators were imported into Swift
by synthesizing a subscript containing a getter and a
setter. Both these produce unnecessary copies. A read
accessor instead yields a borrowed reference, rather
than performing a copy. This change attempts to, when appropriate,
synthesize a read accessor instead of a getter.

@swift-ci Please smoke test

@swift-ci Please smoke test macOS platform

Not sure if this is the case for all return types, but in a small experiment I've discovered while the read accessor is shown in the generated sil (read vs get), the generated llvm ir and assembly are identical. Perhaps this change has been optimized out?

@swift-ci Please smoke test.

@swift-ci Please smoke test.

@swift-ci Please smoke test.

@swift-ci Please smoke test.

@swift-ci Please smoke test.

@swift-ci Please smoke test.

This looks good to me.
Before you land it, can we get either @rjmccall or @gottesmm to look over this?

@swift-ci Please smoke test.

@NuriAmari just a thought: it would be cool to apply this to Omar's patch as well (synthesized computed properties).

(In another patch. And someone else can do it if you don't want to.)

Ok, I'll take a look after I land this and the benchmark.

@swift-ci Please smoke test.

@swift-ci Please smoke test Linux platform

This LGTM. Feel free to land once we get the benchmarks.

@swift-ci please benchmark.

@swift-ci please benchmark

Performance (x86_64): -O

Improvement
OLD
NEW
DELTA
RATIO

FlattenListFlatMap
4118
3299
-19.9%
1.25x (?)

Code size: -O
Performance (x86_64): -Osize
Code size: -Osize
Performance (x86_64): -Onone

Regression
OLD
NEW
DELTA
RATIO

DataReplaceLargeBuffer
11
12
+9.1%
0.92x (?)

Code size: -swiftlibs

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: 6-Core Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 32 GB

Let's see if we can figure out why std::vector is still getting copied here.

The copy seems to be properly removed from within the synthesized subscript operator itself, but the caller makes a copy from the returned pointer anyways:
%96 = function_ref @$sSo3stdO3__1O051__CxxTemplateInstNSt3__16vectorINS0_IiNS_9allocatorH16EEEENS1_IS3_EEEEVyAD02__bcde4__16fhi2_9jhM0VSicir : $@yield_once @convention(method) (Int, @in_guaranteed std.__1.__CxxTemplateInstNSt3__16vectorINS0_IiNS_9allocatorIiEEEENS1_IS3_EEEE) -> @yields @in_guaranteed std.__1.__CxxTemplateInstNSt3__16vectorIiNS_9allocatorIiEEEE, loc "/Users/nuriamari/Git/swift-project/swift/benchmark/cxx-source/ReadAccessor.swift":40:21, scope 9 // user: %97
(%97, %98) = begin_apply %96(%76, %94) : $@yield_once @convention(method) (Int, @in_guaranteed std.__1.__CxxTemplateInstNSt3__16vectorINS0_IiNS_9allocatorIiEEEENS1_IS3_EEEE) -> @yields @in_guaranteed std.__1.__CxxTemplateInstNSt3__16vectorIiNS_9allocatorIiEEEE, loc "/Users/nuriamari/Git/swift-project/swift/benchmark/cxx-source/ReadAccessor.swift":40:21, scope 9 // users: %99, %100
copy_addr %97 to [initialization] %78 : $*std.__1.__CxxTemplateInstNSt3__16vectorIiNS_9allocatorIiEEEE, loc "/Users/nuriamari/Git/swift-project/swift/benchmark/cxx-source/ReadAccessor.swift":40:21, scope 9 // id: %99

Still investigating exactly why, but for some reason type checking replaces the AST representation of this initialization
 in the benchmark:
let row = vec![j];

It introduces a load_expr node, which as far as I can tell introduces the additional copy_addr instruction.
Original init:
(subscript_expr type='<null>'
    (force_value_expr type='@lvalue TwoDimensionalVector' location=/Users/nuriamari/Git/swift-project/swift/benchmark/cxx-source/ReadAccessor.swift:44:20 range=[/Users/nuriamari/Git/swift-project/swift/benchmark/cxx-source/ReadAccessor.swift:44:17 - line:44:20]
    (declref_expr type='@lvalue TwoDimensionalVector?' location=/Users/nuriamari/Git/swift-project/swift/benchmark/cxx-source/ReadAccessor.swift:44:17 range=[/Users/nuriamari/Git/swift-project/swift/benchmark/cxx-source/ReadAccessor.swift:44:17 - line:44:17] decl=ReadAccessor.(file).vec@/Users/nuriamari/Git/swift-project/swift/benchmark/cxx-source/ReadAccessor.swift:21:5 function_ref=unapplied))
    (argument_list
    (argument
        (declref_expr type='Int' location=/Users/nuriamari/Git/swift-project/swift/benchmark/cxx-source/ReadAccessor.swift:44:22 range=[/Users/nuriamari/Git/swift-project/swift/benchmark/cxx-source/ReadAccessor.swift:44:22 - line:44:22] decl=ReadAccessor.(file).run_ReadAccessor(_:).j@/Users/nuriamari/Git/swift-project/swift/benchmark/cxx-source/ReadAccessor.swift:36:9 function_ref=unapplied))
    ))
Processed init:
(load_expr implicit type='std.__1.__CxxTemplateInstNSt3__16vectorIiNS_9allocatorIiEEEE' location=/Users/nuriamari/Git/swift-project/swift/benchmark/cxx-source/ReadAccessor.swift:44:21 range=[/Users/nuriamari/Git/swift-project/swift/benchmark/cxx-source/ReadAccessor.swift:44:17 - line:44:23]
    (subscript_expr type='@lvalue std.__1.__CxxTemplateInstNSt3__16vectorIiNS_9allocatorIiEEEE' location=/Users/nuriamari/Git/swift-project/swift/benchmark/cxx-source/ReadAccessor.swift:44:21 range=[/Users/nuriamari/Git/swift-project/swift/benchmark/cxx-source/ReadAccessor.swift:44:17 - line:44:23] decl=__ObjC.(file).std.__1.__CxxTemplateInstNSt3__16vectorINS0_IiNS_9allocatorIiEEEENS1_IS3_EEEE.subscript(_:)
    (inout_expr implicit type='inout std.__1.__CxxTemplateInstNSt3__16vectorINS0_IiNS_9allocatorIiEEEENS1_IS3_EEEE' location=/Users/nuriamari/Git/swift-project/swift/benchmark/cxx-source/ReadAccessor.swift:44:17 range=[/Users/nuriamari/Git/swift-project/swift/benchmark/cxx-source/ReadAccessor.swift:44:17 - line:44:20]
        (force_value_expr type='@lvalue TwoDimensionalVector' location=/Users/nuriamari/Git/swift-project/swift/benchmark/cxx-source/ReadAccessor.swift:44:20 range=[/Users/nuriamari/Git/swift-project/swift/benchmark/cxx-source/ReadAccessor.swift:44:17 - line:44:20]
        (declref_expr type='@lvalue TwoDimensionalVector?' location=/Users/nuriamari/Git/swift-project/swift/benchmark/cxx-source/ReadAccessor.swift:44:17 range=[/Users/nuriamari/Git/swift-project/swift/benchmark/cxx-source/ReadAccessor.swift:44:17 - line:44:17] decl=ReadAccessor.(file).vec@/Users/nuriamari/Git/swift-project/swift/benchmark/cxx-source/ReadAccessor.swift:21:5 function_ref=unapplied)))
    (argument_list
        (argument
        (declref_expr type='Int' location=/Users/nuriamari/Git/swift-project/swift/benchmark/cxx-source/ReadAccessor.swift:44:22 range=[/Users/nuriamari/Git/swift-project/swift/benchmark/cxx-source/ReadAccessor.swift:44:22 - line:44:22] decl=ReadAccessor.(file).run_ReadAccessor(_:).j@/Users/nuriamari/Git/swift-project/swift/benchmark/cxx-source/ReadAccessor.swift:36:9 function_ref=unapplied))
    ))))

It introduces a load_expr node, which as far as I can tell introduces the additional copy_addr instruction.

The load_expr is introduced, but I'm no longer convinced this is the issue, nor am I convinced that this issue is specific to std::vector. Will keep looking.


Support direct bundle installation

After #596 goes in, we can implement support for installing a bundle from a URL instead of resolving it from a catalog. To do this, we'll have a very strict set of guardrails:

The bundle must be a registry+v1 bundle
We will do minimal or no constraint/dependency checking - a direct bundle installation is considered "satisfied"

FYI @varshaprasad96

A candidate brief started (but not reviewable) here


fix: resolve audit issues 1

Description:

Missing Addr Validation 192
Check against host Timestamp 191
Authenticate Capability Missing in Send Packet 182
Reentry via Reply in Receive Packet 185
Duplicate Signatures Check Missing 188
Add Client State Frozen check 190

Commit Message
fix: remove callback data and reply always

see the guidelines for commit messages.
Changelog Entry
version: <log entry>

Checklist:

[ ] I have performed a self-review of my own code
[ ] I have documented my code in accordance with the documentation guidelines
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have run the unit tests
[ ] I only have one commit (if not, squash them into one commit).
[ ] I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Codecov Report

Merging #633 (310ebab) into main (7da1f7b) will decrease coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #633      +/-   ##
============================================
- Coverage     69.02%   68.97%   -0.06%
  Complexity      408      408
============================================
  Files           151      151
  Lines         14016    13975      -41
  Branches        294      294
============================================
- Hits           9675     9639      -36
+ Misses         4185     4180       -5
  Partials        156      156

Flag
Coverage Δ

java
80.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

contracts/cosmwasm-vm/cw-common/src/client_msg.rs
94.02% <ø> (ø)

contracts/cosmwasm-vm/cw-ibc-core/src/context.rs
93.84% <ø> (-0.10%)
:arrow_down:

contracts/cosmwasm-vm/cw-ibc-core/src/contract.rs
45.04% <ø> (-0.02%)
:arrow_down:

contracts/cosmwasm-vm/cw-ibc-core/src/error.rs
34.14% <ø> (ø)

...osmwasm-vm/cw-ibc-core/src/ics02_client/handler.rs
96.39% <ø> (-0.03%)
:arrow_down:

...smwasm-vm/cw-ibc-core/src/ics04_channel/handler.rs
93.39% <ø> (ø)

...cw-ibc-core/src/ics04_channel/handler/open_init.rs
91.42% <ø> (-0.13%)
:arrow_down:

...c-core/src/ics04_channel/packet/acknowledgement.rs
84.21% <ø> (-0.07%)
:arrow_down:

...bc-core/src/ics04_channel/packet/receive_packet.rs
80.83% <ø> (-0.18%)
:arrow_down:

...w-ibc-core/src/ics04_channel/packet/send_packet.rs
73.58% <ø> (-0.06%)
:arrow_down:

... and 7 more

Split into other PRs


add about page

This adds a simple about page with basic infos (taken verbatim from the readme, feel free to adjust/modify) and a link to this github repository.

Sir, that was quick 🙇 And great idea. Thanks for the PR.


Markdown CI lint action

And some typos fixed along the way :nerd_face:

Depends on #5 for Green :heavy_check_mark:

I rebased and pushed. that mixed the commit author thing a bit. sorry for that @photonbit . But the action is not running anyway at the moment.

Now it is working, I added conditions so the action will be triggered on pushing to master and also when a pull request has been updated. Also the netiquette post has been formatted.


Model generation for failed action with outputs

Description
TablesQuery and Process have output(s) fields that are set only once the action succeeds. If it fails it is still possible for the user to continue the discussion but the conversation rendering for the model would throw.
Instead render failed action by letting know the model that the action failed.
Context: https://dust4ai.slack.com/archives/C05F84CFP0E/p1716370378105129
Risk
-N/A
Deploy Plan

deploy front

PMRR


Avg Nonzero Triplets

Hi, I'm relatively new to the concept of triplet loss and I was just curious about the "Average Nonzero Triplets" metric. What exactly is this measuring? And is this something that should be going down/up/neither during training?
Thanks in advance for the help!

In case of online triplet selection, many triplets are generated per batch. For each triplet a triplet loss function is computed. What the metric does is measure for how many triplets in a batch a condition for triplet loss to be zero is not satisfied (i.e., the distance between an anchor and a positive is greater than the distance between an anchor a negative with margin m).
If this value goes down, it means that fewer and fewer triplets violate triplet loss - the network is learning properly

Excuse me. Can this value be less than 1.0? The minimum value I observed during training was 1.0. I read the code, but still can't understand. thanks.


Adds support for mariadb-connector-j 1.8.x

Mariadb-connector-j 1.8.0 has been released and with it, class name changes introduced in 2.4.0 have been backported similar to #5215.
org.mariadb.jdbc.MariaDbPreparedStatementServer -> org.mariadb.jdbc.ServerSidePreparedStatement
org.mariadb.jdbc.MariaDbPreparedStatementClient -> org.mariadb.jdbc.ClientSidePreparedStatement

Codecov Report

Merging #5225 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5225      +/-   ##
==========================================
- Coverage    40.5%   40.49%   -0.02%
==========================================
  Files        2671     2671
  Lines       80303    80303
  Branches    10700    10700
==========================================
- Hits        32530    32520      -10
- Misses      44882    44890       +8
- Partials     2891     2893       +2

Impacted Files
Coverage Δ

...rp/pinpoint/plugin/jdbc/mariadb/MariaDBPlugin.java
0% <ø> (ø)
:arrow_up:

...rp/pinpoint/rpc/packet/ControlHandshakePacket.java
51.51% <0%> (-24.25%)
:arrow_down:

...ofiler/sender/StandbySpanStreamDataSendWorker.java
80.59% <0%> (-2.99%)
:arrow_down:

...cluster/zookeeper/ZookeeperClusterDataManager.java
62.5% <0%> (-2.21%)
:arrow_down:

...corp/pinpoint/rpc/stream/StreamChannelManager.java
70.68% <0%> (-1.73%)
:arrow_down:

.../pinpoint/rpc/client/PinpointClientHandshaker.java
65% <0%> (-1.43%)
:arrow_down:

...rc/main/java/com/navercorp/pinpoint/test/Item.java
70% <0%> (ø)
:arrow_up:

...point/rpc/client/DefaultPinpointClientHandler.java
73.56% <0%> (+1.27%)
:arrow_up:

...om/navercorp/pinpoint/rpc/codec/PacketDecoder.java
63.82% <0%> (+2.12%)
:arrow_up:

...vercorp/pinpoint/web/vo/ApplicationAgentsList.java
69.23% <0%> (+2.56%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 084f483...943e425. Read the comment docs.


Wrongly counted PIN errors

When entering a wrong PIN twice and then a valid one, NK3 still returns PinAuthBlocked, even though it should succeed and reset the internal counter.
Looking here, it seems the counter is decremented every time, no matter if the current PIN is correct or not (assuming I'm looking in the right place).
Shouldn't it be decremented only here?

Looking here, it seems the counter is decremented every time, no matter if the current PIN is correct or not (assuming I'm looking in the right place).

Hi!
Always decrementing is by design. It covers timing attacks with power analysis.
Certainly this should not behave as you have encountered though.

Should be fixed by https://github.com/Nitrokey/fido-authenticator/pull/28.


Render to texture, then apply post-processing shaders 🤦♂

For the screen effect shaders I was using, I applied them directly in the render-to-screen step which is causing some epic artifacting when the thing being drawn isn't a full-screen texture already (ie: anything that isn't the videos/animations).  I really should be rendering everything first to a texture, then applying those screen effect shaders to that texture when it goes to the screen, oops 🤦♂

This is done now and implemented as a 'rendering pipeline'.  The only thing I'd really like to do now is make that pipeline more configurable.


Added SlurmTree

Changed lua/Tree.lua to automatically distribute nodeIndexes if they are not specified.

Changed lua/Tree.lua to take an optional argument for the function that builds the tree connections (defaults to "rcsvAllPairs")

Added lua/SlurmTree.lua a tree implementation based on using slurm workload manager. (can also provide example of how to make use of SlurmTree with slurm jobs)

@Gruek Can you update the Tree docs?

@nicholas-leonard Do you just mean the README docs? Should I write a new paragraph specific to SlurmTree?

@Gruek Yes. It doesn't have to be long, but just to clarify why there's a new thing and when it should be used or not.

@mirandaconrado @nicholas-leonard Done! :)

@Gruek Thanks!

@Gruek docs and example? It must be my birthday. Thanks for the changes!


llvm34 fails to build under El Capitan

https://gist.github.com/dc7570d10700e69d78be
Here is the end of the log:
llvm[4]: ======= Finished Linking Release+Asserts Unit test Tooling (without symbols)
make: *** [all] Error 1

ScheduleOptimizer.cpp:399:13: error: use of undeclared identifier 'isl_band_member_is_zero_distance'
        if (isl_band_member_is_zero_distance(Band, j)) {
            ^

There have been some recent compatibility issues with isl and gcc, but I don't know what's going on here.

I also get this:
llvm[4]: ======= Finished Linking Release+Asserts Unit test Tooling (without symbols)
make: *** [all] Error 1
couldn't understand kern.osversion `15.0.0'

I take it there are no fixes for this?

I'm not hugely surprised this broke. Your best bet is poking around upstream for fixes in either their bug tracker or head.

Has anyone tried this? https://gist.github.com/i-kiwamu/4833d8f22130ee179291#file-scheduleoptimizer_patch-diff

@camargo does LLVM 3.4 build with that patch, and has it been submitted upstream?

Not sure I have not tried it yet. Also not sure if it has been submitted upstream.

Is there any progress on this issue? I'm running into trouble building llvm34 as well: https://gist.github.com/eturk/901b110e83e259e9d64770b978239cba

We'll accept PRs for this but we're not actively working on it at this time.


GStreamer issue: using an HTTP streaming as input

Hi,
I was working with Demo #5: YOLOv4 on my Jetson AGX Xavier, and it worked flawlessly when I used an MP4 video file as input.
But now, I need to use HTTP streaming as the input. So I tried the open_cam_gstr, and passed the argument as:
python3 trt_yolo.py --gstr 'souphttpsrc location=http://{username}:{passwd}@{IP_address}:{port}/stream.mjpg ! jpegdec ! xvimagesink' -m {model}
Then I got this error:
[ WARN:0] global /home/nvidia/host/build_opencv/nv_opencv/modules/videoio/src/cap_gstreamer.cpp (801) open OpenCV | GStreamer warning: cannot find appsink in manual pipeline
[ WARN:0] global /home/nvidia/host/build_opencv/nv_opencv/modules/videoio/src/cap_gstreamer.cpp (480) isPipelinePlaying OpenCV | GStreamer warning: GStreamer: pipeline have not been created
WARNING:root:Camera: starting while cap is not opened!
ERROR: failed to open camera!
I'm not sure how this error occurred, but I went ahead and tried opening the streaming directly with GStreamer:
gst-launch-1.0 souphttpsrc location=http://{username}:{passwd}@{IP_address}:{port}/stream.mjpg ! jpegdec ! xvimagesink
And it worked. I'm sure the steaming address is correct.
I'm new to this and I don't know where the problem is.
Any help would be appreciated.

Try this instead:

python3 trt_yolo.py --gstr 'souphttpsrc location=http://{username}:{passwd}@{IP_address}:{port}/stream.mjpg ! videoconvert ! appsink' -m {model}

Thank you for the quick reply. So I tried:

python3 trt_yolo.py --gstr 'souphttpsrc location=http://{username}:{passwd}@{IP_address}:{port}/stream.mjpg ! videoconvert ! appsink' -m {model}

And now I got this:
[ WARN:0] global /home/nvidia/host/build_opencv/nv_opencv/modules/videoio/src/cap_gstreamer.cpp (1757) handleMessage OpenCV | GStreamer warning: Embedded video playback halted; module souphttpsrc0 reported: Internal data stream error.
[ WARN:0] global /home/nvidia/host/build_opencv/nv_opencv/modules/videoio/src/cap_gstreamer.cpp (886) open OpenCV | GStreamer warning: unable to start pipeline
[ WARN:0] global /home/nvidia/host/build_opencv/nv_opencv/modules/videoio/src/cap_gstreamer.cpp (480) isPipelinePlaying OpenCV | GStreamer warning: GStreamer: pipeline have not been created
WARNING:root:Camera: starting while cap is not opened!
ERROR: failed to open camera!

Sorry, my bad.   Thank you very much!


Integrate multipoint connection demo as main demo application

Are there some other branch/repo that is related to this?

Are there some other branch/repo that is related to this?

Yes: https://github.com/micro-ROS/freertos_apps/pull/4 including changes for example application with dual transport communication, which have just been merged. This PR is ready for revision/integration now.


Adt for vnodes

Codecov Report

Merging #45 (cf8ff0e) into main (bcbcb33) will decrease coverage by 17.23%.
The diff coverage is 71.95%.

@@             Coverage Diff             @@
##             main      #45       +/-   ##
===========================================
- Coverage   93.02%   75.79%   -17.24%
===========================================
  Files          17       19        +2
  Lines         502      566       +64
  Branches       68       50       -18
===========================================
- Hits          467      429       -38
- Misses         35      137      +102

Impacted Files
Coverage Δ

snabbdom/src/main/scala/snabbdom/Listener.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

snabbdom/src/main/scala/snabbdom/VNodeData.scala
100.00% <ø> (ø)

...rc/main/scala/snabbdom/benchmarks/Benchmarks.scala
11.76% <11.76%> (ø)

...bdom/src/main/scala/snabbdom/modules/Dataset.scala
42.85% <41.93%> (-21.15%)
:arrow_down:

...m/src/main/scala/snabbdom/modules/Attributes.scala
79.54% <75.67%> (-13.56%)
:arrow_down:

snabbdom/src/main/scala/snabbdom/toVNode.scala
84.78% <76.47%> (-4.97%)
:arrow_down:

snabbdom/src/main/scala/snabbdom/VNode.scala
81.81% <80.00%> (+1.81%)
:arrow_up:

snabbdom/src/main/scala/snabbdom/h.scala
80.76% <80.76%> (-19.24%)
:arrow_down:

snabbdom/src/main/scala/snabbdom/init.scala
86.47% <88.00%> (-8.83%)
:arrow_down:

...c/main/scala/snabbdom/modules/EventListeners.scala
90.00% <88.88%> (-1.18%)
:arrow_down:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcbcb33...cf8ff0e. Read the comment docs.

This supersedes https://github.com/buntec/scala-js-snabbdom/pull/33


Update SHA1 fingerprint for MSI signing cert

The cert has been updated as the old one expires on 2017-07-25. The new cert has also been deployed to our build infrastructure.
Signed-off-by: Seth Chisamore<EMAIL_ADDRESS>

/cc @chef/engineering-services  @chef/community-engineering-team @chef/client-maintainers

Closing this for now as we are investigating using an EV cert which has instant reputation with Microsoft Smartscreen filter.

@thommay Ditto on the Appveyor failure here...we OK to merge?


TypeError: 'Lambda' object does not support item assignment

Hi, I tried to load a simple two layered ONNX model  exported with pytorch:
k_model = onnx2keras.onnx_to_keras("simple_cnn.txt", ["input.1"])

but, i got the following output and error:
2021-04-19 17:53:04.793268: W tensorflow/stream_executor/platform/default/dso_loader.cc:60] Could not load dynamic library 'libcudart.so.11.0'; dlerror: libcudart.so.11.0: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /home/user/torch/install/lib::/usr/local/cuda:/usr/local/cuda-10.0/lib64
2021-04-19 17:53:04.793300: I tensorflow/stream_executor/cuda/cudart_stub.cc:29] Ignore above cudart dlerror if you do not have a GPU set up on your machine.
INFO:onnx2keras:Converter is called.
DEBUG:onnx2keras:List input shapes:
DEBUG:onnx2keras:None
DEBUG:onnx2keras:List inputs:
DEBUG:onnx2keras:Input 0 -> input.1.
DEBUG:onnx2keras:List outputs:
DEBUG:onnx2keras:Output 0 -> 9.
DEBUG:onnx2keras:Gathering weights to dictionary.
DEBUG:onnx2keras:Found weight conv.weight with shape (8, 5, 3).
DEBUG:onnx2keras:Found weight conv.bias with shape (8,).
DEBUG:onnx2keras:Found weight fc.weight with shape (2, 80).
DEBUG:onnx2keras:Found weight fc.bias with shape (2,).
DEBUG:onnx2keras:Found input input.1 with shape [5, 10]
DEBUG:onnx2keras:######
DEBUG:onnx2keras:...
DEBUG:onnx2keras:Converting ONNX operation
DEBUG:onnx2keras:type: Conv
DEBUG:onnx2keras:node_name: 5
DEBUG:onnx2keras:node_params: {'dilations': [1], 'group': 1, 'kernel_shape': [3], 'pads': [1, 1], 'strides': [1], 'change_ordering': False, 'name_policy': None}
DEBUG:onnx2keras:...
DEBUG:onnx2keras:Check if all inputs are available:
DEBUG:onnx2keras:Check input 0 (name input.1).
DEBUG:onnx2keras:Check input 1 (name conv.weight).
DEBUG:onnx2keras:The input not found in layers / model inputs.
DEBUG:onnx2keras:Found in weights, add as a numpy constant.
DEBUG:onnx2keras:Check input 2 (name conv.bias).
DEBUG:onnx2keras:The input not found in layers / model inputs.
DEBUG:onnx2keras:Found in weights, add as a numpy constant.
DEBUG:onnx2keras:... found all, continue
DEBUG:onnx2keras:conv:Conv with bias
3 5 8 True
Traceback (most recent call last):
  File "onnx_2_keras.py", line 19, in <module>
    k_model = onnx2keras.onnx_to_keras(onnx_model, input_all)
  File "/home/user/.local/lib/python3.6/site-packages/onnx2keras/converter.py", line 181, in onnx_to_keras
    keras_names
  File "/home/user/.local/lib/python3.6/site-packages/onnx2keras/convolution_layers.py", line 197, in convert_conv
    lambda_layer[keras_name] = target_layer
TypeError: 'Lambda' object does not support item assignment

I have tensorflow 2.4.1, keras 2.4.3 and no CUDA.
Edit: The problem occurs because of the use of Conv1D

At line 197 on file onnx2keras/convolution_layers.py, you change lambda_layer[keras_name] = target_layer to lambda_func[keras_name] = target_layer.

@KietHoang2212 It seems to work, why not writing a PR ?

@KietHoang2212, actually I think it does not solve it, it simply removes the layer.
A simple model.summary() shows no parameters
Model: "functional_3"
_________________________________________________________________
Layer (type)                 Output Shape              Param #
=================================================================
input_0 (InputLayer)         [(None, 10, 32)]          0
_________________________________________________________________
output_0 (Lambda)            (None, 16, 32)            0
=================================================================
Total params: 0
Trainable params: 0
Non-trainable params: 0
_________________________________________________________________

@londumas , actually it replaces Conv1d in PyTorch by Lambda layer with fixed weights in Keras, so it has no prams. But the result is still the same. If their results are different, you can replace the code from line 179 in the file onnx2keras/convolution_layers.py with the following code:
`
1D conv
    W = W.transpose(2, 1, 0)
    width, channels, n_filters = W.shape
    print(width, channels, n_filters, has_bias)

    # if has_bias:
    #     weights = [W, bias]
    # else:
    #     weights = [W]

    weights = [W]
    def target_layer(x, w=weights, stride=strides[0]):
        import tensorflow as tf
        w = tf.convert_to_tensor(w[0])
        x = tf.transpose(x, [0, 2, 1])
        #Note: padding='VALID' if padding==0, else: padding='SAME
        x = tf.nn.conv1d(x, w, stride=stride, padding='VALID', data_format='NWC')
        if has_bias:
          x = tf.nn.bias_add(x, bias, data_format='N...C')
        return tf.transpose(x, [0, 2, 1])

    lambda_layer = keras.layers.Lambda(target_layer, name=keras_name)
    lambda_func[keras_name] = target_layer
    layers[node_name] = lambda_layer(input_0)

`

@KietHoang2212, indeed the code you gave there works. Why not writing a PR ?

hi, I'm having this same issue, also with a Conv1D layer originally from a PyTorch model. @KietHoang2212 if this fix works for you, any chance you could write a PR? thank you :)


DOC: Avoid documenting ivar default values in SpatialFunction class

Avoid documenting ivar default values in
itk::ConicShellInteriorExteriorSpatialFunction since:

All ivar values should be initialized to some default value.
When default values are changed, it is easy to forget about updating the documentation and making it inconsistent with the actual value in the code.

PR Checklist

[X] No API changes were made (or the changes have been approved)
[X] No major design changes were made (or the changes have been approved)
[X] Updated API documentation (or API not changed)

Not sure there is another way to show ivar default values through the Doxygen documentation, but I do think that we should avoid documenting explicitly for the above reasons.
Cross-referencing: https://github.com/InsightSoftwareConsortium/ITK/pull/4115

Looks like the badges in the README and the Azure build status are not in sync. Not sure why. Badges are all green

but Azure builds are not

Also, badges are pointing at different commits across builds, e.g. f602b3c1 for ITK.Windows, 3c20912e for ITK.macOS.
@thewtex @tbirdso would you be able to investigate this, please? Thanks.


Can I somehow specify auto-precision ?

Can I somehow specify auto-precision, since I have 8 characters allowed in one currency, 3 in the second, and so on, i.e. allow the user to put a dot and determine the number after it?

Thank you for the suggestion! This could be implemented, but it would likely require changes to the internal behavior and might need a flag to activate it. Since I don't currently need this feature in my projects, you're welcome to open a pull request if you'd like to contribute.


Fix Large CI annotation error on GitHub Actions

Large CI suffers from #418 already, but even when all jobs succeed, another error appears in the runner's annotations section (see https://github.com/Kong/ngx_wasm_module/actions/runs/6429661251):
Large CI: .github#L1
The template is not valid. (Line: 149, Col: 11): A sequence was not expected

Fixed in 88ec9b9.


ClassNotFoundException when adding jobs through QuartzSchedulerMBean API

QuartzSchedulerMBeanImpl.addJob method invokes JobDetailSupport.newJobDetail to create a JobDetail instance before the job detail is registered with the scheduler. JobDetailSupport.newJobDetail uses Class.forName to load the job implementation class. This works only if the job implementation class can be loaded by the class loader that loaded the JobDetailSupport class and this is not always the case. For example, this is a very common Quartz deployment scenario:
App.ear
 |
 +--- lib
 |    |
 |    +--- quartz-x.y.z.jar
 |
 +--- App1.war
 |      |
 |      +--- WEB-INF/classes or WEB-INF/lib /* possibly contains Quartz job impl classes */
 |
 +--- EJBJar.jar /* possibly contains Quartz job impl classes */

In this scenario, when you attempt to add a new job through the QuartzSchedulerMBean API, it fails, because the Quartz class loader cannot see classes in WAR and EJB JAR modules.
Various Quartz components consistently use the ClassLoadHelper to load job implementation classes as well as other classes that may not reside on the Quartz scheduler's classpath. JobDetailSupport does not make use of the ClassLoadHelper. This severly limits the use of the Quartz MBean API to only one Quartz deployment scenario where Quartz API and job implementation classes are all loaded through the Quartz API class loader (or any of its parent class loaders).
I have implemented a fix for Quartz 2.2.1 and I am attaching the relevant patches for the modified classes in the picture below.
Please consider including the patch in Quartz 2.2.4. Thank you.
Thank you,
Jan
quartz-2.2.1-patches.zip

Could you please submit the patch as a PR for review?


3rd vax cert is hard to find

<!--

* [x] Bug is not mentioned in the [FAQ](https://www.coronawarn.app/en/faq/)
* [x] Bug is specific for iOS only
* [x] Bug is not already reported in another issue

## Technical details

- Device name: iPhone 13
- iOS version: iOS 15.2
- App version: 2.15

## Describe the bug
The location of the 3. booster vaccination certificate is very confusing.
While this is not a technical bug, I do think this is an interface design bug :-)

## Steps to reproduce the issue
After scanning the certificate for the third vaccination,
the certificates list still only shows 2 certificates:
The top certificate is the 2.  vaccination,
the lower certificate looks like the 1. vaccination.
the third vaccination only becomes visible after you select
and double click the bottom certificate

## Expected behaviour
IMHO, the clearest design for the vax certificates is:
- all vax certificates in the certificates list show their date already
 (i.e. no need to click on it to see from when it is)
- all vax certificates are shown on the same level (no nesting)
- vax certificates are sorted by date, newest certificate is always on top of the list

## Additional context
After scanning my 3rd vax certificate, I could not find it in the app;
trying to re-scan it gave me a "VC_ALREADY_REGISTERED" error;
then I scanned the FAQ to figure out how to delete a registered-but-invisible vax cert;
eventually following the few github issues that mention VC_ALREADY_REGISTERED,
I found out that you need to look in the _older_ vax cert to see the newest one - ???

So, it cost me more than an hour of time to figure out where the app put my booster vax cert...
and to show it, e.g. when going in to work IRL, I need to remember how to access it.
- I think this could and should be be much more intuitive.

hope this is helpful?
best adc

Hi @adcxyz
Could you provide some details, please?

Ah sorry, I had written it all up, and apparently did not save the issue properly!
I'll write it again now.

iphone 13, current iOS, cwa also current 2.15
I find the way the iOS app shows the 3rd vax cert quite confusing,
and believe this could be both simpler and clearer.
Background:
After scanning my 3rd vax cert, the certif. panel showed me 2 certif. entries,
just like it was before with two vax dates.
the two entries look exactly the same, just the QR code.
I expected to see 3 entries now, so it seemed the scan of the 3rd cert had failed.
On the upper entry of the two,
clicking on the details showed my second vax date (6/2021);
all the way at the bottom, it has entries for
vax cert 2 (6/2021) and
vax 1 (5/2 021) .
The lower certif. entry actually shows only the third vaccination;
because I expected this to be the older cert of my 1st vax, I did not
read this patiently enough, and spent some time trying to repeat the scanning,
which failed with "VC_ALREADY_REGISTERED" ...
Crosschechkin on the android caw app 2.15.1:
this shows only a single top vax certificate, also without date,
and clicking for details shows indiv. vax. dates with newest on top:
vax 3 11/2021,
vax 2 6/2021,
vax 1 5/2021
This is already clearer, and I think it could be even clearer:
The top level entries in the certificates panel should also show
the date of the newest vax (of the series captured) in that entry,
so users know immediately which QR code to show on entering offices etc.
Thanks!

iOS should actually behave the same way as Android does and I can confirm that this is the case on my iPhone XR:

(I have only stored 2/2 and 3/3 cert in the app).
A new tile on the certificates tab is only created if the names or date of births differ from the other certificate.


Default page improvements

Shows a quick list of commands

Pull Request Test Coverage Report for Build 325

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 74.804%

Totals

Change from base Build 322:
0.0%

Covered Lines:
1906

Relevant Lines:
2548

💛  - Coveralls