Include collectCoverage=true by default for testing

Current Behavior
tsdx test does not collect coverage by default
Desired Behavior
tsdx test should collect coverage by default (I think)
Suggested Solution

Include collectCoverage: true in createJestConfig.ts (permalink)
Who does this impact? Who is this for?

I expect this to be for all users. I find code coverage to help understand parts of a library/application which does not have test coverage. It does not present a perfect metric, but all teams on which I've worked value it.
Describe alternatives you've considered

I currently just include collectCoverage: true in my own jest.config.js file as described in customization.
Additional context

Using my own jest.config.js totally works for me, but I wanted to understand why this was not the default. Especially given the TSDX Jest config includes the collectCoverageFrom option. Am I missing something maybe? The Jest docs suggest this value defaults to false.

Because this retrofits all executed files with coverage collection statements, it may significantly slow down your tests.

Jest does call out the performance impact, but I'd like to understand if TSDX has an explicit opinion on whether coverage falls into "best practice" category.

Am I missing something maybe?

I think you're misremembering or misinterpreting how coverage is normally used.
During a development session, one may run tests anywhere from a few times to hundreds of times. Sometimes with --watch mode on where coverage reporting is only partial and is obtrusive. Coverage isn't going to be useful for a large portion of those runs, but it may be useful in the middle or toward the end. It's also best practice to run coverage also good to run in CI.
You generally don't want to run coverage for every test run, but every once in a while or toward the end of a session and in CI.

The Jest docs suggest this value defaults to false.

Yes, Jest defaults coverage reporting to false as do most, if not all, test frameworks. In JS world, many test runners don't even have coverage built-in and require separate tools like nyc. CRA also does not have coverage turned on by default.

Jest does call out the performance impact

Jest runs babel-plugin-istanbul over your code to instrument it, which can indeed be incredibly CPU and memory intensive, taking potentially several times longer than a plain test run (something I've personally experienced in https://github.com/facebook/jest/issues/9233). So it actually could be a quite detrimental DX to turn it on by default.

Especially given the TSDX Jest config includes the collectCoverageFrom option.

Yes, this is specified to make it easier to just run --coverage without needing to configure anything else for the default file structure. Per the above link, CRA similarly sets this option.

I'd like to understand if TSDX has an explicit opinion on whether coverage falls into "best practice" category.

You should definitely use code coverage, but there's no need to run it for every single test run, and doing so could be detrimental to DX for several reasons mentioned above (perf, watch mode, etc).
You should also run coverage in CI. I've been looking to add it to the templates' GitHub Actions but need to look at what the latest historical coverage providers/bots/Actions are. I've used CodeCov in my TS/JS and Python libraries but that was before Actions were a thing and as a GitHub App it can't be added to a default template, that has to be manually authorized.

Thanks so much for the in-depth reply/explanation. I'll dive deeper into understanding how to run this only in our CI environment. Thanks!

@connorjs I would suggest not setting collectCoverage in jest.config.js and instead running with --coverage in CI (--coverage is an alias for --collectCoverage). Similarly can do so in local development occasionally.
For GitHub Actions you can see this in the templates. For Travis CI, here's a line from one of my libraries.


More vello graphics primitives

Creating animations typically requires more primitives to work with.
A good reference point of what we are lacking at the moment is the motion canvas API docs.
Personally below are some of the must have components for creating a motion graphics video:

[x] Rect
[x] Circle
[x] Bezier Curves
[ ] #32
[ ] #33
[ ] #36
[ ] #34
[ ] #35
[ ] Custom Shader

Up priority for Video/Audio integration. May be worth to have integration with touying.

Would love to see polygons too, but I guess this should be handled upstream (https://github.com/linebender/kurbo/issues/335)?

Would love to see polygons too, but I guess this should be handled upstream (linebender/kurbo#335)?

@musjj It's actually doable using the Bezier Curve, it supports, line, quadratic curve, and cubic curve. Right now it's just that it may be a little tedious to do it, and might need a better interface.

A huge chunk of this issue is blocked by #39 and #30

should this be moved to bevy_vello_graphics?

@aymey not really, at least not all of them, some of them are not related to vector graphics. I think we will move the individual issues into their respective repo and keep this issue here to track all of them.


Bug: Folders with whitespace breaks filelisting

Create a folder called "Finance Dept".
Observe that no files within the folder can be listed

I think this might be the frontend encoding the file name twice – because it looks like the backend handles it correctly:


Add version: GoLang.Go version 1.21.12

Pull request has been created with komac v2.3.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

/azp run

/azp run


Suggestion: PONMsg

Hi there Armel!
In the next release, would you consider adding the option "All + Sound" in the PowerOn Message (Menu Option 33)..?
Thanks in advance, good job! 👍

You're correct - please disregard.


🐛 [google_sign_in][firebase_auth] MissingPluginException(No implementation found for method init on channel plugins.flutter.io/google_sign_in)

I have exactly the same issue as detailed here https://github.com/FirebaseExtended/flutterfire/issues/5444#issue-839217332. I am not sure how the author @bwobst solved it as the issue was closed without any further comment, and I cannot comment on it. I have followed the instructions on integrating the Google Auth into a macOS step by step and am facing the exact same error. Thanks for your help.

The reason you are getting this error message is that google_sign_in is not supported on macOS (https://github.com/flutter/flutter/issues/46157).

@markusaksli-nc I found that out now after debugging for hours. However, this is impossible to know from reading the documentation of Flutterfire if I didn't miss anything?

Well google sign-in isn't really a part of FlutterFire since it can be used separately. Thus why it has it's own documentation on https://pub.dev/packages/google_sign_in
The missing platform method channel implementation error message is actually common for plugins when you try to use them on an unsupported platform but the message could be improved.
However, issues about google sign in belong on flutter/flutter

Ok, thanks for your reply @markusaksli-nc!


First draft of schema

Schema is certainly not yet ready. This is more to have sth to start from.
See also #18
Try the MetaConfigurator like this:  https://metaconfigurator.github.io/meta-configurator/?schema=https://github.com/precice/preeco-orga/blob/add-schema-draftz/guidelines/adapter_schema.json&settings=https://github.com/precice/preeco-orga/blob/add-schema-draftz/guidelines/meta_configurator_settings.json

Very nice linking to the MetaConfigurator as well, but shouldn't we document at least this part somewhere?
Should we maybe have these files in a separate directory adapter-config-schema with a README.md file explaining what this is about and linking to the MetaConfigurator?
Just think of the people that will end up on this file through a search engine.

I now created a folder adapter-config-schema at the root of the repo. Is this what you had in mind?
Together with a README.

I now created a folder adapter-config-schema at the root of the repo. Is this what you had in mind? Together with a README.

Yes, exactly


Seeing non-zero ACT value for a technology without any commodity linked to it

I have a strange observation, which I want to clarify.
By mistake, I didn't put any 'renewable_potential' values for the historical hydro tec I defined ("hydro_hist") for the entire time horizon, which means its input commodity ("hydro_c_hist") dedicated to the tec has no ground. And input and output parameters were defined only from 1965 and on. But there was historical_new_capacity starting from 1950.
Then in the result, I found that ACT has a value for 2020 for the hydro capacity of year_vtg 1960. (lifetime 60 years). I guess there is a loophole where ACT can still show up when all the input/output/renewable_potential are not defined.
Shouldn't it still give zero ACT if there is no potential defined for modeling years?

Thanks @Jihoon for spotting this issue. But because this issue is MESSAGE-specific, it should go to https://github.com/iiasa/message_ix. The ixmp repository should only be used for issues related to the database connection and generic data management topics.

Oops, I thought I was in message_ix. I'll reopen it there.


P-extension PR RISCV-ISAC

Hello Neel,
I’m the Andes engineer working on the “P” extension support for RISCV-CTG and RISCV-ISAC. We are ready to submit our initial pull request for the modification.
AS P-extension divides a register into 8/16-bit subfields for packed SIMD operations, the dataset and coverpoints become more complicated. Our first pull request will contain modifications for three instructions from the P extension only: ADD8, ADD16, and SCLIP8. We would like to seek your review first before proceed into the rest of the instructions. Please kindly review our pull request and give us guidance on how to proceed next.
Reference for P-extension, ADD8, ADD16 on pages 83-84, and SCLIP8 on page 263.
https://github.com/riscv/riscv-p-spec
Hsueh-Liang

Also an entry in the Changelog.md and a bumpversion is required.


We can use the idea of Linux slub in aggregation module

Feature Request
Is your feature request related to a problem? Please describe:
In aggregation module, in most of time we handle row by row, for each row we will new some objects like Datum. This will cause memory allocation.
Describe the feature you'd like:
We can reuse these objects. Because for each row the number and type of these objects are the same.

I guess the situation will be eased once we are executed by chunk. @AndreMouche @zz-jason


chore: introduce Submodule interface

Description
Introduces the Submodule interface and applies it to the P2P module's peerstore provider.
Issue
Deliverables 1, 2, 3, & 5:

#810

Type of change
Please mark the relevant option(s):

[ ] New feature, functionality or library
[ ] Bug fix
[x] Code health or cleanup
[ ] Major breaking change
[x] Documentation
[ ] Other

List of changes

fixed typo; renamee IntegratableModule to IntegrableModule
renamed InitializableModule to InjectableModule
removed InjectableModule#Create() as Moudle also embeds ModuleFactoryWithConfig
added Submodule interface type
refactored peerstore providers as submodules
updated module README

Testing

[x] make develop_test; if any code changes were made
[x] make test_e2e on k8s LocalNet; if any code changes were made
[x] e2e-devnet-test passes tests on DevNet; if any code was changed
[ ] Docker Compose LocalNet; if any major functionality was changed or introduced
[x] k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
[ ] I have tested my changes using the available tooling
[ ] I have updated the corresponding CHANGELOG

If Applicable Checklist

[x] I have updated the corresponding README(s); local and/or global
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have added, or updated, mermaid.js diagrams in the corresponding README(s)
[ ] I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

Everything looks good to me, I saw the comments about potentially unrelated hunks. Will they remain in this PR or move?

I think I force pushed over the commits that I referenced, my apologies. The changes I was referencing are still in this branch. I was just trying to point out that parts of those changes didn't necessarily fit with the rest.

Linking the mindmap from this comment in #844 for additional context.

LGTM +1 Replacing providers with submodules seems worth an ADR, if you want help writing that up let's take a look at it @bryanchriswhite

@dylanlott it's more like the providers need to become submodules.

:rotating_light: Please don't delete this branch! I will do so when all downstream branches have been rebased, thank you! :rotating_light:


fix(validation) allow null/empty and equal values in min/max validation

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fix
What is the current behavior? (You can also link to an open issue here)
Currently formly doesn't allow you to have optional fields with min/max. It also doesn't allow you to have equal values
What is the new behavior (if this is a feature change)?
The new behavior allows you to have optional fields and equal values

This change is

Codecov Report

Merging #449 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #449      +/-   ##
=========================================
+ Coverage   92.38%   92.4%   +0.01%
=========================================
  Files          16      16
  Lines         775     777       +2
  Branches      209     210       +1
=========================================
+ Hits          716     718       +2
  Misses         59      59

Impacted Files
Coverage Δ

src/core/services/formly.form.builder.ts
96.47% <100%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c781437...a85cca5. Read the comment docs.


Disallow naked returns

As previously discussed, be aggressive about disallowing naked return statements.

Yay! Thank you for following through on this!


"Cuzăplac" is listed in the drop-down menu

Description:
"Cuzăplac" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Cuzăplac" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Cuzăplac, SĂLAJ".


⚠ Samsung has degraded performance

In 24f50f0, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 1691 ms

Resolved: Samsung performance has improved in 1a0ce57.


@Ahk2Exe-AddResource

Docs http://fincs.ahk4.net/Ahk2ExeDirectives.htm say to use asterisk to specify resource type before file name but the code does not consider this and it works only without asterix: https://github.com/fincs/Ahk2Exe/blob/edge/Directives.ahk#L111

By asterisk you mean * or @???

Joe DF | Administrator at ahkscript.org
Manager at AutoHotkey Foundation LLC |<EMAIL_ADDRESS>http://ahkscript.org/joedf | https://www.linkedin.com/in/joedf

From: HotKeyIt<EMAIL_ADDRESS>Sent: May 24, 2017 4:01:26 PM
To: fincs/Ahk2Exe
Cc: Subscribed
Subject: [fincs/Ahk2Exe] @Ahk2Exe-AddResource (#50)
Docs http://fincs.ahk4.net/Ahk2ExeDirectives.htm say to use asterisk but the code does not consider this and it works only without asterix: https://github.com/fincs/Ahk2Exe/blob/edge/Directives.ahk#L111
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/fincs/Ahk2Exe/issues/50, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADq4GwU4I5-wsGBpDwPsIfJ5zX8Ys4tIks5r9IyWgaJpZM4NlmSZ.

'*', see docs :)

Whoops! I looked at the wrong section :b

Seems to be working as of at least https://github.com/AutoHotkey/Ahk2Exe/commit/33d35b9112b8b397f01a1ed8725b094726c4af40 👍


Swaps Journal need to include swap commands error.

Now journal will log all errors that occur during the processing stage.
-------- Trade Journal --------
August 14 14:02:19  Swap offer is created
August 14 14:03:03  Offer message was sent
August 14 14:05:38  Processing error: Swap Error , Swap generic error, Please define '--message_file_name' value if you you are processing income message from the file
Journal length will be capped on 1000 messages because we might get too many errors.

Closing this ticket.


Bug: Quad+Tailsitter (AutoStart ID 13004) Not work

the Quad+Tail-sitter can not be found and set in QGC Airframe page, only Quad_X_Tail-sitter is available.

No signal on output ports, if I manually set SYS_AUTOSTART to 13004 in Parameter list.

We need to test all of these configs.

@dagar the problem is that this config is excluded from the build due to flash space

@jingego which version of firmware is this? Did you flash through QGC?
@RomanBapst In that case I'm wondering if we need to do a better job forcing QGC metadata to update. I've found the airframes get stuck and don't necessarily update after a flash even after you restart QGC. @DonLakeFlyer @dogmaphobic FYI

I flashed it through both QGC and make px4fmu-v3_default upload. The version is 1.7.3 dev. I tested two boards but both are hobbyking pixhawk.

@RomanBapst I saw the code. board px4fmu-v2 is excluded.
it's seems that px4fmu-v3 use same config file with px4fmu-v2, so this airframe is not available on px4fmu-v3 either?
But px4fmu-v3 don't have flash size problem.


forbidden error when not signed in and trying to view opportunity detail

Behaviour should be:
Given
A user is not signed in
And on the opportunity list page
When the user clicks an opportunity to view the detail
They should see the opportunity detail page
And they should see the ‘Apply’ button
And when they click the 'Apply' buttonm the user should be presented with a modal which asks
them to sign in or sign up - with links to the sign up page.

Fixed! 👍
BDD slightly modified to this (but I'm good with it):
Given
A user is not signed in
And on the opportunity list page
When the user clicks an opportunity to view the detail
They should see the opportunity detail page
And they should see a well at the top of the page that says "Want to apply on this opportunity? Sign In or Sign Up."
And those link to the Sign Up page.


[AutoPR servicebus/resource-manager] Service Bus: Revert PR 4245 from 2017

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4323

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/3633


Store Update?

Is there any reason why this app isn't receiving updates on the Microsoft Store? It's still on an old pre-rewrite build.

@matthew4850 I was enjoying testing all the new features but there hasn't been a new insider build since the 2nd, will this be changing any time soon?


First Story Wanderluster

modified:   projects/wanderluster.md

This commit looks exactly right
Your first story on https://trello.com/b/OzWnuC0M/wanderluster is not sufficient yet - it speaks to need.... but not what you are actually going to demo on Weds!

Hi Adam,
Is first story a user story? or just one-week goal? I m quite confuse about
what we should put in first story. Thanks.
Shimiao
On Mon, Sep 21, 2015 at 4:38 PM, Adam Fleming<EMAIL_ADDRESS>wrote:

This commit looks exactly right
Your first story on https://trello.com/b/OzWnuC0M/wanderluster is not
sufficient yet - it speaks to need.... but not what you are actually going
to demo on Weds!
—
Reply to this email directly or view it on GitHub
https://github.com/Cornell-CS5356-Fall2015/cs5356/pull/211#issuecomment-142101842
.

--
Liudan Xiao
MS in Connective Media - Class of 2017
Cornell Tech
Cornell University |<EMAIL_ADDRESS>|<PHONE_NUMBER> |
www.linkedin.com/in/liudanCT

Hi Adam,
I just fixed that. If there any further questions, please contact me.
Best,
Liudan
On Mon, Sep 21, 2015 at 4:38 PM, Adam Fleming<EMAIL_ADDRESS>wrote:

This commit looks exactly right
Your first story on https://trello.com/b/OzWnuC0M/wanderluster is not
sufficient yet - it speaks to need.... but not what you are actually going
to demo on Weds!
—
Reply to this email directly or view it on GitHub
https://github.com/Cornell-CS5356-Fall2015/cs5356/pull/211#issuecomment-142101842
.

--
Liudan Xiao
MS in Connective Media - Class of 2017
Cornell Tech
Cornell University |<EMAIL_ADDRESS>|<PHONE_NUMBER> |
www.linkedin.com/in/liudanCT


 Supersedes #1607
Fixes #1636
Test Steps

[ ] npm run serve
[ ] Run through demos

General Tests for Every PR

[ ] npm run serve:prod still works.
[ ] npm run tslint passes.
[ ] npm run stylelint passes.
[ ] npm test passes and code coverage is not lower.
[ ] npm run build:lib still works.

Screenshots or link to StackBlitz/Plunker

Anchor jumping makes the docs jump

Anchor jumping makes the docs jump

Yes working as expected. But... I could shove the demo in a window to avoid the page jump.

Anchor jumping makes the docs jump

Yes working as expected. But... I could shove the demo in a window to avoid the page jump.

From an experience standpoint if I don't know anything about this I don't know what just happened.

In the 'live editor' example, when 'open Window' toggle is off and if we do any changes in editor & click 'Apply', it opens the window. Shouldnt it just apply the changes at right hand side navigation and should not open the window?

In the 'live editor' example, when 'open Window' toggle is off and if we do any changes in editor & click 'Apply', it opens the window. Shouldnt it just apply the changes at right hand side navigation and should not open the window?

Good catch! Fixed @aqupriyanka


[WIP] Joining offers form (fixes 982)

I had some git problems in PR #1034 so I closed it and recovered it here.
This PR contains form that user uses in order to join offers.
In order to test it you have to pull also #981 as it contains endpoint this code needs to hit

Codecov Report

Merging #1066 into master will decrease coverage by 0.06%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #1066      +/-   ##
==========================================
- Coverage   90.69%   90.63%   -0.07%
==========================================
  Files         115      115
  Lines        2731     2733       +2
  Branches       31       31
==========================================
  Hits         2477     2477
- Misses        250      252       +2
  Partials        4        4

Impacted Files
Coverage Δ

frontend/src/app/homepage-offer/offers.service.ts
56.52% <50%> (-0.63%)
:arrow_down:

backend/apps/volontulo/models.py
96.66% <0%> (-1.12%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e32f8b0...4d2e85a. Read the comment docs.


Automated Package Upgrade

:tada: This PR is included in version 7.7.158 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Ruby interpreter(CUI) 1.9.2p180 [i386-mingw32] has stopped working

The webserver happens to crash alot of times when I reload the browser when developing on a project.
Then it shuts down the server and I have to start it again.
Problem details:
Problem Event Name:	APPCRASH
Application Name:	ruby.exe
Application Version:	<IP_ADDRESS>
Application Timestamp:	4d5ee5ed
Fault Module Name:	msvcrt-ruby191.dll
Fault Module Version:	<IP_ADDRESS>
Fault Module Timestamp:	4d5ee5ec
Exception Code:	c0000005
Exception Offset:	0011a00e
OS Version:	6.1.76<IP_ADDRESS>.256.48
Locale ID:	1030
Additional Information 1:	5e16
Additional Information 2:	5e16ced789fd81d8061f8a695be3ace3
Additional Information 3:	0e79
Additional Information 4:	0e7991227df0e55ae57238673024a5df

I have this problem in 1.9.2p290 , it randomly crush on page refresh and sometime just crush on its own ; it is not repeatable in a QA repeat steps I can do i.e. I can't find a pattern that crush it, it just does it when it wants to.
environment:

windows 7
Rails 3.1.1
WEBrick 1.3.1
ruby 1.9.2 (2011-07-09) [i386-mingw32]
Thanks for looking into it.
Amnon

Please see my previous answer, see also #39 and http://yourbugreportneedsmore.info/

I was having exactly the same problem as asarig, also 1.9.2p290 version on windows7, rails 3.1.1, etc. Upgraded to 1.9.3p0 about 5 minutes ago, and this version seems a lot more stable at first sight


[terraform-resources] introduce terraformProviderResources

replaces #86
this PR adds support for a new way to define terraform resources, which is future compatible with adding additional providers, except for AWS. this is backwards compatible with the option to define AWS resources only under terraformResources.
the new section looks like this:
terraformProviderResources:
- provider: aws
  provisioner:
    $ref: /aws/example/account.yml
  resources:
  - provider: dns-zone
    identifier: zone1-example-com
    name: zone1.example.com
    output_resource_name: aws-dns-creds
- provider: gcp-project
  provisioner:
    $ref: /gcp/example/project.yml
  resources:
  - provider: dns-zone
    identifier: zone2-example-com
    name: zone2.example.com
    output_resource_name: google-dns-creds

this approach follows the provider pattern as described here: https://gitlab.cee.redhat.com/service/app-interface/-/blob/master/docs/app-interface/qontract-reconcile-patterns.md#the-provider-pattern

In this pattern, we allow defining items in a similar way while handling them differently behind the scenes.
Each item is handled a bit differently in our integrations, while allowing users to define all resources in a similar way or even in a single location.

this PR also adds some example schemas for GCP resources, to help make things clear (or confuse :))

+1 Nice

Taking into account the providers we are going to use work quite different, I think it's better to maintain the providers just at the resource level and not group them by a cloud provider.
e,g:
resources:
- provider: aws-route53
  provisioner:
   $ref: /aws/account.yml
  attr: ...
  attr: ...

- provider: gcp-cloud-dns
  provisioner:
    $ref: /gcp/myorg/gcp-project-1.yml
  attr: ...
  attr: ...

- provider: gcp-iam-group
  provisioner:
    $ref: /gcp/myorg/folder.yml
  attr: ...
  attr: ...

GCP and AWS have completely separated terraform resource names and the features, way to configure the components differs a lot. I think it's better to just have different providers at the resource level and not share them in a cloud provider spec. This way we have all the freedom to set just the real and required attributes by each component and not have mixed schemas and logic for different cloud providers.
Additional notes:

In GCP, not all resources are bound to a project. The provisioner could have a reference to the account where it belongs.
Maybe the DNS is the service that have more similarities, but If we consider the Network, compute, compute managed groups, etc. The differences are much more accentuated.
Maybe it implies more code, but the maintainability and safety to change code of a single resource it's worth the effort IMO.

i added a design document in https://gitlab.cee.redhat.com/service/app-interface/-/merge_requests/34377
just to answer some things here:

grouping is an implementation detail IMO. I think it's good because in many namespace files we have many resources provisioned in the same account, so this approach will reduce some duplication. how is this grouping changing our ability to "set just the real and required attributes by each component and not have mixed schemas and logic for different cloud providers"?
about gcp projects vs accounts, indeed, this is one of the things this approach solves. we can have a provider called gcp-project and one called gcp-account.
not sure i understand how the last 2 comments are related.

OK, after reading the design doc it's more clear to me. I was concerned about the dns-zone on your example. I thought you were suggesting to share providers across both cloud providers. Reading the doc it seems that it's not the case and it's just a grouping change.

indeed!
i do plan to later "expose" both route53 zone and gcp managed zone as dns-zone, but due to the connection to the provisioner, the implementation will be completely different. it's about abstraction, and not about reusing code or anything.

Now that the design doc has been approved and the interface has settled it is a god moment to say this. I know asking this is trying to fix a schema documentation debt of almost three years in some cases, but some documentation at least in the new fields wouldn't hurt at all 😬
LGTM otherwise


Crash on target sdk 30

Crash on target sdk 30

youtube_player_flutter: ^8.1.0 & youtube_player_iframe: ^2.3.0 are available now.


Button Download entry functionality

It would be ice if the button Download would actually call the usual download window .. to make life easier for us now.

Depending on the file type it should work correct now (try with a non text file as your browser might show text files directly)


URL rewrite doesn't work for non-regex

From @lonix1 on August 10, 2018 16:10
ASP.NET Core 2.1 (2.1.302)
I want to rewrite /favicon.ico to /images/favico.ico.
So I followed the docs and did this in Startup.cs at the end of Configure() (after app.UseMvc(), I hope that's correct?):
app.UseRewriter(new RewriteOptions()
  .AddRewrite("favicon.ico", "images/favicon.ico", skipRemainingRules:true));

But that gave me a 404.
So I thought maybe I need to use a dummy regex:
app.UseRewriter(new RewriteOptions()
  .AddRewrite("^(favicon.ico)$", "images/favicon.ico", skipRemainingRules:true));

And that also gave me a 404.
This was confirmed by other people on SO, so it's either a bug, or the documentation is wrong (in which case please correct me).
Copied from original issue: aspnet/Mvc#8254

Thanks for contacting us, @lonix1.
Please provide us with a minimalistic repro project so we can investigate the issue.

From @kichalla on August 10, 2018 18:30
cc @jkotalik

From @jkotalik on August 10, 2018 18:32
Seems like a bug, will look into it in the 2.2 timeframe.

From @jkotalik on August 10, 2018 23:16
Oops: just BasicMiddleware: https://github.com/aspnet/BasicMiddleware

@jkotalik, should this be moved to a different repo?

From @gsdnano on August 11, 2018 3:28
This can be reproduced by taking the example at https://docs.microsoft.com/en-us/aspnet/core/fundamentals/url-rewriting?view=aspnetcore-2.1&tabs=aspnetcore2x and commenting out the app.Run command at the end of the Configure function. The url rewrite example will then 404 no matter the replacement url. This is using core 2.1 and Microsoft.AspNetCore.Rewrite 2.1.1.

From @lonix1 on August 11, 2018 6:0
Once this bug is resolved, please also give us some guidance (or better yet, update the docs) about the implications of putting this before/after/between app.UseStaticFiles() and app.UseMvc(), or whether it should be at the beginning/end of Configure() i.e. the beginning/end of the pipeline.

@muratg FYI

So I followed the docs and did this in Startup.cs at the end of Configure() (after app.UseMvc(), I hope that's correct?):

Rewrite must come early in the pipeline, not at the end. In your case it needs to come before UseStaticFiles.

@lonix1 I assume this solved your issue. Closing. You may reopen if you are still having issues.


Improve readme with component features and examples

Right now the readme contains a code snippet that doesn't compile.
My suggestion is to provide examples at least for:

use of the NImageFetchView
use of the lib using an UIImageView
cache/memory cleanup
task cancellation

Thanks

updated readme pr


rename script

we need a script to change file names to use underscores and add .py extension

This issue was resolved by 589d180cebb136f1e8e4deec467d666feb0f0a03


json: cannot unmarshal object into Go value of type []devcontainer.Configuration

Daytona version v0.46.1
https://github.com/johnnypea/devcontainer-php
 Opening the workspace in VS Code ...

Setting up IDE customizations...
FATA[0057] json: cannot unmarshal object into Go value of type []devcontainer.Configuration

VS Code opens up and it seems like I can interact with the workspace.

@johnnypea please add the version of Daytona that you're using.
(I know it's v0.46.1 but other contributors might not)

This Issue has been automatically marked as "stale" because it has not had recent activity (for 14 days). It will be closed if no further activity occurs. Thanks for the feedback.

More info here: https://github.com/daytonaio/daytona/issues/1430#issue-2726357946

On several checks this is happening when we are giving Dockerfile in the devcontainer.json

@Abiji-2020 I'll push up the priority on this. Do you have a repo example of where this is happening to you?

https://github.com/Abiji-2020/Go_CRUD_Application
This was created for the sample go while running this i got the same error

https://github.com/daytonaio/daytona/blob/57347d0763e0ef5c28aaff7beea5b4e8c7f16201/pkg/build/devcontainer/types.go#L6-L14
@Tpuljak in here the json file has dockerFile but in general we are giving it as dockerfile thats the reason for the unmarshall error

@Tpuljak in this we can solve this by giving the standard details in the devcontainer.json or need a way to serialize these values ?

@Abiji-2020 I believe the only issue here is that we expect that "devcontainer.metadata" is an array when it can be a single object sometimes.

@johnnypea apologies for this taking so long to fix. The fix will be released today with https://github.com/daytonaio/daytona/pull/1516


--network none (--net=none) emits logs of DNS-related operations

Using Docker 18.09.7, when launching a container with docker run --network none ..., logs like these are generated:
dockerd[1768]: time="2020-03-17T14:00:52.808585281-07:00" level=info msg="No non-localhost DNS nameservers are left in resolv.conf. Using default external servers: [nameserver <IP_ADDRESS> nameserver <IP_ADDRESS>]"
dockerd[1768]: time="2020-03-17T14:00:52.808612717-07:00" level=info msg="IPv6 enabled; Adding default IPv6 external servers: [nameserver 2001:4860:4860::8888 nameserver 2001:4860:4860::8844]"

I dug through the Go code as best I could, but it seems to me that FilterResolvDNS is getting called by setupDNS nearly unconditionally (i.e. no check to see if networking is enabled or not), and updateDNS semi-conditionally (--network host seems to bypass this).  I couldn't figure out what to add if-wise, nor where to add it, to essentially do nothing in the case --network none is used; I'm not familiar with the code to know what's needed.
This issue is indirectly touched on/referenced via #1063 and #1928 .
Use case justification: we have applications and infrastructure that launches Docker containers for single-command usage, so having thousands of these log messages when using containers launched with --network none (and containers which truly do no network I/O of any kind) seems very wasteful.

@jchadwick-smug do you see this in the latest version as well (19.03.7)

Yes.

should be the same @jchadwick-smug .
I'm  running docker run --net none nginx and I can't seem to generate the logs you have shared


"Parent node is busy setting up children" on focus loss when save_on_focus_loss option is enabled

Bugsquad note: This issue has been confirmed several times already. No need to confirm it further.

Godot version
4.0.rc (5f3dee5988391deffcc0de1039dd50e05e266913)
System information
Mageia 9, Linux
Issue description
When interface/editor/save_on_focus_loss is enabled in the Editor Settings, focus loss triggers a save as expected, but also these errors:
ERROR: Parent node is busy setting up children, `add_child()` failed. Consider using `add_child.call_deferred(child)` instead.
   at: add_child (scene/main/node.cpp:1136)
ERROR: Condition "!is_inside_tree()" is true.
   at: popup_centered (scene/main/window.cpp:1456)

Steps to reproduce

Enable interface/editor/save_on_focus_loss
Alt tab to desktop and back

Minimal reproduction project
Happens on an empty project.
Production edit (keywords for easier searching): Task 'save' already exists.

https://github.com/godotengine/godot/blob/84a80721c5308df36c7295949c76a622c5e0edb9/scene/main/scene_tree.cpp#L643-L647
https://github.com/godotengine/godot/blob/84a80721c5308df36c7295949c76a622c5e0edb9/scene/main/node.cpp#L1924-L1932
https://github.com/godotengine/godot/blob/84a80721c5308df36c7295949c76a622c5e0edb9/editor/progress_dialog.cpp#L158-L168
propagate_notification(NOTIFICATION_APPLICATION_FOCUS_OUT) causes data.blocked to be greater than 0, and finally the root window fails to add the ProgressDialog as a child node.

The error is also present in v4.2-dev5

Also encountering this issue - frustrating

I have the same issue in v4.1.2.
Do you think this will be prioritized any time soon?

Disabling Save on Focus Lost is a workaround, of course you lose the ability to save on focus lost.

Disabling Save on Focus Lost is a workaround, of course you lose the ability to save on focus lost.

That's not a workaround, it's just a broken feature.

I have the same issue in v4.1.2.
Do you think this will be prioritized any time soon?

i don't think so unless some big shot on twitter or youtube spread it and its not really a big deal for some people so i dont think this will be fixed anytime soon

Disabling Save on Focus Lost is a workaround, of course you lose the ability to save on focus lost.

That's not a workaround, it's just a broken feature.

It works around the error, which automated testing would flag as an error.
It surely doesn't fix the cause.

propagate_notification(NOTIFICATION_APPLICATION_FOCUS_OUT) causes data.blocked to be greater than 0, and finally the root window fails to add the ProgressDialog as a child node.

The solution is likely to add a way to save without displaying a progress dialog, and use this when Save on Focus Loss is triggered.

This error is still occurring as of Godot v4.1.3-stable in the exact same manner, I agree with Calinou that a different way to show saving would be great, I also have found the dialog to be quite distracting but this error makes my output log ridiculously noisy over-time as I work on my project, I have had to disable Save on Focus Lost due to this issue as it has become frustrating to debug while this is occurring.
An option to temporarily hide internal editor errors during playtesting would be great so that my output is not cluttered by errors like this.

I've encountered the same issue in Godot 4.2.1 stable...

Also encountering this on EndeavourOS with Godot 4.2.1.
Thankfully this issue told me what's going on, as without a debug build of the editor you just get this error message without further detail:
ERROR: Task 'save' already exists.
   at: add_task (editor/progress_dialog.cpp:167)
WARNING: ObjectDB instances leaked at exit (run with --verbose for details).
     at: cleanup (core/object/object.cpp:2208)
ERROR: Resources still in use at exit (run with --verbose for details).
   at: clear (core/io/resource.cpp:493)
[1]    3340289 segmentation fault (core dumped)  ~/Tools/Godot_v4.2.1-stable_linux.x86_64 --editor

With the first two lines being repeated a lot. Would be helpful to either flag this as broken on linux with a warning on the settings or at least have more helpful error output. I was wondering for half an hour or so why my editor always crashed when I launched the game - turns out it's the save on focus loss instead of anything related to my code.

Any progress on this bug, it still available on version 4.2.1

Still an issue on 4.2.2 stable. While a fix would be appreciated, it should probably add to the log that the issue is from save on Focus Lost, that way we have less wasted time debugging code that is not relevant.


Add purge of old logs file

It seems that currently nothing purge old logs file. Which means that after a while a lots of files may be present in /var/log/jmxtrans and consume disk space.
I'm not sure logs older that few weeks are still useful.
The PR add a daily cron script that remove all archived logs older than 32 days.

Thanks for the PR! For log rotation, I'd much prefer have this managed by the logging framework (log4j / logback, yes, there is a mess there). That's one less system dependency...

I'm not a Java developer, so I've a very little knowledge of log4j 1.x/log4j 2.x/logback and co.
But I initially tried to look at handling this on logging framework (currently log4j 1.x) and it seems that it does only support it with size based rotation.
With a time based rotation logback seems to support it. And (I'm not sure about this one) log4j 2.x.
So for me, if we want to support this in logging framework, we need to add logback and/or upgrade to log4j 2.x.
Should I try to look at upgrading log4j or add logback ?

Since you seem to be managing Java application, some knowledge of the standard logging framework will probably help you in the long run :) (sorry I could not resist).
The situation is a bit complex... We have a mess of both logback and log4j. The way to go is definitely logback, but there are some OutputWriters that depend directly on log4j, which makes removing it (or upgrading it) a giant pain. Not that there is a time based rolling policy in log4j-extra, which is already bundled with jmxtrans. This could be a short term approach.

From my search the logger that support deletion of history are:

log4j 1.2 but with size based rotation: http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/RollingFileAppender.html => maxBackupIndex
log4j 2.8, using DefaultRolloverStrategy that has delete policy. Here we can keep a time based rotation and compressed archive
logback that has TimeBasedRollingPolicy with rolling policy.

For the last solution, I don't see how to do it. jmxtrans-output-log4j use SLF4F and its log4j12 binding. From SLF4J documentation we should "drop one and only one binding [...] onto the [...] class path". Therefor I can't add logback binding without providing two binding.
The second solution means dropping usage of SLF4J (or we have the same problem as described above). It should be much more than just changing all logger creation. It also means that SLF4J + log4j 1.2 will still be used but jmxtrans-output-log4j. But since log4j 2 use another package namespace (org.apache.logging.log4j vs org.apache.log4j it should be conflict).
The first solution is just configuration change. But it means that rotation will be size based and no longer time based.

Another solution would be to use https://logging.apache.org/log4j/extras/apidocs/org/apache/log4j/rolling/TimeBasedRollingPolicy.html with log4j. The class is already on the classpath.

I don't see how it help. It should already be used by log4j.xml and don't seem to have any option to limit history size.
If you are thinking to https://logging.apache.org/log4j/extras/apidocs/org/apache/log4j/rolling/RollingFileAppender.html (which is also used by log4j.xml config) and its MaxBackupIndex option, it's a unused option. Code confirm that it's only a JavaDoc comment.

(closed my mistake, sry)

In any case, the "right" solution would be to deprecate the log4j based output writers (keep them as an optional module) and move all logging to logback...

I also tried to replace the Log4J1 dependency by a Log4J2 dependency for similar need.
But the jmxtrans-output-log4j module has a strong dependency on Log4J1.

Yeah, those log4j appenders are a mess. We should deprecate them and replace them by slf4j output writer, which can do the same things, but driven by logging configuration. This would require writing some docs on how to use it, remove the log4j appender from the final build (we could keep them around, just in case someone really likes them). My preference would be to migrate to logback more than log4j2, but I'm open to alternatives.

Since  v270 (maybe v269), JMXTrans uses Logback library. Its RollingFileAppender supports a TimeBasedRollingPolicy which supports both time and size rotation.


Consider the lichess command line /

Lichess has the option of pressing / and you get to write a command like a command line. What UI hating dev doesn't love that?!
Only I have yet to know what to add there.
Also, it has the /help option to which LiChess Tools must add its own options if so developed.

it's a nice idea, but the potential for use is very limited. Discoverability is much more important. Closing this.


[Powershell] Missing cmdlets needed for creating new VMs

Reported by user @pollardsg
Following seem to be missing cmdlets in my App Service powershell function:
New-AzureRmDiskConfig
New-AzureRmDisk
New-AzureRmVirtualNetwork
New-AzureRmVirtualNetworkSubnetConfig
New-AzureRmNetworkSecurityRuleConfig
New-AzureRmNetworkSecurityGroup
New-AzureRmPublicIpAddress
New-AzureRmNetworkInterface
Is there a reason they are not available?
For example I'm getting the following error:
New-AzureRmDisk : The term 'New-AzureRmDisk' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
at run.ps1: line 74

moved from templates repo
https://github.com/Azure/azure-webjobs-sdk-templates/issues/614


stationarity and invertibility checks in auto-arima

does pmdarima auto-arima check for invertibility and stationarity of the selected model? does it also check for almost-non-invertibility and almost-non-stationarity like in the R implementation?

just to clarify - by almost-non-invertibility I'm referring to this code:
https://github.com/robjhyndman/forecast/blob/master/R/newarima2.R
    if (minroot < 1 + 1e-2) { # Previously 1+1e-3
      fit$ic <- Inf
} # Don't like this model

We don't currently have the polyroot test implemented, which is what this would require


[GOBBLIN-912]Enable TTL caching on Hive Metastore client connection

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-912] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-912

Description

[x] Here are some details about my PR, including screenshots (if applicable):
Enable TTL catche for HMS client and change one logic to determine whether need update table in hive to reduce one call to update table

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Test on parallel pipeline to make sure the connect will be destroyed after being idle for some time.

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

@sv2000 Can you take a look at this simple change? Thx!

Codecov Report

Merging #2766 into master will decrease coverage by 41.13%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #2766       +/-   ##
============================================
- Coverage     45.29%   4.15%   -41.14%
+ Complexity     8848     744     -8104
============================================
  Files          1892    1892
  Lines         70739   70750       +11
  Branches       7771    7773        +2
============================================
- Hits          32043    2942    -29101
- Misses        35739   67495    +31756
+ Partials       2957     313     -2644

Impacted Files
Coverage Δ
Complexity Δ

...che/gobblin/writer/HiveWritableHdfsDataWriter.java
0% <0%> (-73.53%)
0 <0> (-8)

...lin/source/extractor/hadoop/AvroFileExtractor.java
0% <0%> (-20%)
0 <0> (-2)

...lin/hive/metastore/HiveMetaStoreBasedRegister.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...g/apache/gobblin/hive/HiveMetastoreClientPool.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...n/converter/AvroStringFieldDecryptorConverter.java
0% <0%> (-100%)
0% <0%> (-2%)

...he/gobblin/cluster/TaskRunnerSuiteThreadModel.java
0% <0%> (-100%)
0% <0%> (-5%)

...n/mapreduce/avro/AvroKeyCompactorOutputFormat.java
0% <0%> (-100%)
0% <0%> (-3%)

...apache/gobblin/fork/CopyNotSupportedException.java
0% <0%> (-100%)
0% <0%> (-1%)

.../gobblin/kafka/writer/KafkaWriterCommonConfig.java
0% <0%> (-100%)
0% <0%> (-7%)

...ker/task/TaskLevelPolicyCheckerBuilderFactory.java
0% <0%> (-100%)
0% <0%> (-2%)

... and 1088 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e2ecf0...31ea232. Read the comment docs.


Add interface for application to load and modify rules of proxy's urlfilter.

Need to discuss how to do it. We are already have interface of NativeUrlFilter in Java, so it may be enough to export urlfilter_t pointer.

Don't forget that there are also cssfilter and jsfilter.
I suppose that at the moment we'd better have a simple interface:
setRules(String rules)

Which will parse the rules string, detect the rules type and add them to the corresponding filter.

Merged, core/pull-requests/42


Sitemap index will have duplicated sitemap urls if you have more than one channel

This is due to the SitemapIndexBuilder, the indexProvider::providers array will never be cleared after one channel, so it will continue to add providers to them, this will so generate duplicated references to the same sitemap URL provider.

Hi @lruozzi9 Hasn't this been solved in https://github.com/stefandoorn/sitemap-plugin/pull/198? That should be part of one of the last releases also.

Whops, it just looks like the same problem! I will try to upgrade the plugin.

It works! Thanks, @stefandoorn.

Great!


$$ escaping of dollar signs breaks

example:
prom2teams:
    image: idealista/prom2teams:3.3.0
    entrypoint: /bin/sh -c "python /opt/prom2teams/replace_config.py && exec prom2teams --loglevel $$PROM2TEAMS_LOGLEVEL"

causes:
Traceback (most recent call last):
  File "/home/martinb/.local/bin/docker-sdp", line 4, in <module>
    deployer.main()
  File "/home/martinb/.local/lib/python3.8/site-packages/docker_stack_deploy/cli/deployer.py", line 229, in main
    docker_stack_deploy()
  File "/home/martinb/.local/lib/python3.8/site-packages/docker_stack_deploy/cli/deployer.py", line 146, in docker_stack_deploy
    parsed = yaml.load(stack_yml.read(), yaml.FullLoader)
  File "/home/martinb/.local/lib/python3.8/site-packages/yaml/__init__.py", line 81, in load
    return loader.get_single_data()
  File "/home/martinb/.local/lib/python3.8/site-packages/yaml/constructor.py", line 49, in get_single_data
    node = self.get_single_node()
  File "/home/martinb/.local/lib/python3.8/site-packages/yaml/composer.py", line 36, in get_single_node
    document = self.compose_document()
  File "/home/martinb/.local/lib/python3.8/site-packages/yaml/composer.py", line 55, in compose_document
    node = self.compose_node(None, None)
  File "/home/martinb/.local/lib/python3.8/site-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/home/martinb/.local/lib/python3.8/site-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/home/martinb/.local/lib/python3.8/site-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/home/martinb/.local/lib/python3.8/site-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/home/martinb/.local/lib/python3.8/site-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/home/martinb/.local/lib/python3.8/site-packages/yaml/composer.py", line 133, in compose_mapping_node
    item_value = self.compose_node(node, item_key)
  File "/home/martinb/.local/lib/python3.8/site-packages/yaml/composer.py", line 84, in compose_node
    node = self.compose_mapping_node(anchor)
  File "/home/martinb/.local/lib/python3.8/site-packages/yaml/composer.py", line 127, in compose_mapping_node
    while not self.check_event(MappingEndEvent):
  File "/home/martinb/.local/lib/python3.8/site-packages/yaml/parser.py", line 98, in check_event
    self.current_event = self.state()
  File "/home/martinb/.local/lib/python3.8/site-packages/yaml/parser.py", line 428, in parse_block_mapping_key
    if self.check_token(KeyToken):
  File "/home/martinb/.local/lib/python3.8/site-packages/yaml/scanner.py", line 115, in check_token
    while self.need_more_tokens():
  File "/home/martinb/.local/lib/python3.8/site-packages/yaml/scanner.py", line 152, in need_more_tokens
    self.stale_possible_simple_keys()
  File "/home/martinb/.local/lib/python3.8/site-packages/yaml/scanner.py", line 291, in stale_possible_simple_keys
    raise ScannerError("while scanning a simple key", key.mark,
yaml.scanner.ScannerError: while scanning a simple key
  in "<unicode string>", line 265, column 7:
          PROM2TEAMS_LOGLEVEL="INFO"
          ^
could not find expected ':'
  in "<unicode string>", line 266, column 5:
        deploy:
        ^

error came from other part of the deployment, can be closed


OR logic for policies

currently in policies configuration file, we can only got AND logic for all policies.
But in many cases, we need an OR logic for these policies.
let we think about this case.
A door allows only dog.
A door allows only cat.
A door allows only  pig.
A door allows only rabbit.
A door allows both dog and cat.
A door allows both dog and rabbit.
A door allows both cat and rabbit.
A door allows both cat and pig.
A door allows both rabbit and pig.
A door allows both rabbit and pig and dog.
...
we can see that there are only four animals for we will write more policies for these simple or logic combination of them.
policies can be in AND logic.
But it seems OR logic is far more general than AND logic.
Still I haven't had any requirements for AND logic but OR logic.
so I think OR logic is much general logic in policies and should be supported.

You could check if your policy applies to a request, and if not skip it. This means that the next policy has to either allow or deny the request (the final choice).
An alternative approach, is creating a policy which you require yourself in a different policy and call yourself. So you write your own or policy.

@RWOverdijk
do you mean this will not be officially supported?

@calidion That's not up to me to decide, but I think it already is. Currently, when your policy is called, you get a response object. If you call res.forbidden() for instance, the response itself will be finished.
You have all the utilities needed to make your own OR policy. You could even call next() with an argument (or use options) for a assessment policy.

As @RWOverdijk said, you can implement this yourself--in any case, there's already an issue open for it as feature request.


Expand file format to include those supported by frictionless data

Frictionless framework has these supported formats: https://v4.framework.frictionlessdata.io/docs/references/plugins-reference

@lwjohnst86 Wasn't this done in #592 ?


[Android] Add support for card-level selectActions

https://github.com/Microsoft/AdaptiveCards/pull/1470


Operation: ( remove ) failed on key: [(a shard in) DECISION ]

Hello.
I have a lot of tasks running on Conductor. When my workers are trying to execute them on polling, conductor responds with that kind of error
 {"code":"INTERNAL_ERROR","message":"INTERNAL_ERROR - Operation: ( remove ) failed on key: [(a shard in) DECISION ].","retryable":false,"instance":"18eb47ff475b"}

What is the meaning of this error?

The above errors could likely be due to a failure in achieving quorum or the dynomite server node(s) are unreachable temporarily (you would see other related errors in the logs if this is the case).
If you have no other information in the logs, the best way to figure out the actual error would be to attach a debugger to your java process and add breakpoints in remove() and step in to see what's going on.
Also, please see the updated README for the project status.

Hi @smukil , I see that if we revert the commit then it is working fine. But commit says it fixes the removal part. I see that every time removed is 0 so it won't take if condiction path and a message from the queue will not get removed and it just gets piled up.


feat: Support Schema type in the Launch form

TL;DR
Adds Launch form support for the Schema input type. The Schema structure will be pulled from the Task or Workflow closure. The user only needs to provide a uri indicating the location of the schema to load.
Type

[ ] Bug Fix
[x] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[x] Unit tests added
[x] Code documentation added
[x] Any pending items have an associated Issue

Complete description
Adding an input was fairly straightforward. Since the only input we need is a string value, I reused all of the Simple input code paths to render a single text field. Parsing a Literal to an input value just requires reading the uri field off of the incoming Literal value.
The complication is in converting the input string to the final Literal value. The type value of the resulting Literal needs to be the schema value from the type definition in the source Task/Workflow closure. But the code for doing the parsing only had access to our mapped InputType enum and the input's value. To address this, I extended the InputTypeDefinition interface to also include the source literalType taken from the Variable we read out of the closure. This allows the conversion code to copy over the necessary information. This also has the advantage of allowing nested types such as collections to just work, since they will also pass down the nested variable types.
The majority of the changes ended up being all of the unit test cases, which previously only passed an InputType and now must pass a full InputTypeDefinition
Tracking Issue
https://github.com/lyft/flyte/issues/405
Follow-up issue
NA

Codecov Report

Merging #110 into master will increase coverage by 0.40%.
The diff coverage is 82.85%.

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   70.04%   70.45%   +0.40%
==========================================
  Files         383      384       +1
  Lines        6337     6431      +94
  Branches      997     1024      +27
==========================================
+ Hits         4439     4531      +92
- Misses       1898     1900       +2

Impacted Files
Coverage Δ

.../components/Launch/LaunchForm/LaunchFormInputs.tsx
84.21% <ø> (+2.15%)
:arrow_up:

src/components/Launch/LaunchForm/SimpleInput.tsx
93.33% <0.00%> (-3.22%)
:arrow_down:

src/components/Launch/LaunchForm/constants.ts
100.00% <ø> (ø)

src/components/Launch/LaunchForm/types.ts
100.00% <ø> (ø)

src/components/Launch/LaunchForm/utils.ts
82.75% <64.28%> (-0.58%)
:arrow_down:

...onents/Launch/LaunchForm/inputHelpers/constants.ts
100.00% <100.00%> (ø)

...aunch/LaunchForm/inputHelpers/getHelperForInput.ts
100.00% <100.00%> (ø)

...omponents/Launch/LaunchForm/inputHelpers/schema.ts
100.00% <100.00%> (ø)

...s/Launch/LaunchForm/inputHelpers/test/testCases.ts
100.00% <100.00%> (ø)

...components/Launch/LaunchForm/inputHelpers/utils.ts
86.36% <100.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0209f9...9ba2be4. Read the comment docs.

:tada: This PR is included in version 0.16.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update config filename

I noticed https://github.com/gohugoio/hugo/pull/10621 when updating risotto today, you would probably want to update this. I did not touch exampleSite/config.toml in case you still use that in risotto demo and simply renaming would break it somehow.
Also, I wrote a Development section for quick setup of development site but did not commit as I'm not sure if you want that. Anyway I'll leave it below:
# Clone repo
hugo new site test && cd test/
# New config file still conflict with theme config
# https://github.com/gohugoio/hugo/pull/10621
rm hugo.toml
git clone https://github.com/joeroe/risotto themes/risotto
# Replicate exampleSite
cp -r themes/risotto/exampleSite/* ./
cp -r themes/risotto/layouts/* layouts/
# Fix symlink path
cd content && ln -sf ../themes/risotto/README.md _index.md && cd ../
# Start server
hugo server --disableFastRender --buildDrafts

Thanks for this.
As for the development section, it's a good idea. I usually work within the repo and preview changes with:
cd exampleSite && hugo serve --themesDir ../..

Which has the benefit of not requiring copying or moving any files around.

Wow, good to know that!


Need to document browser compatibility

Preferably on the homepage. I struggle to remember exactly how far back IE is supported every time it gets asked.

@tivac Back to (and including) IE 9.

Added


Query replace lazy highlight delay

For some reason, even though both lazy-highlight-initial-delay and lazy-highlight-interval are set to 0, there is approximately a 1/4-second delay before lazy highlighting starts up for query replaces (but not, curiously, for Isearches!). This difference in functionality is contrary to the documentation of query-replace-lazy-highlight:
(defcustom query-replace-lazy-highlight t
  "Controls the lazy-highlighting during query replacements.
When non-nil, all text in the buffer matching the current match
is highlighted lazily using isearch lazy highlighting (see
`lazy-highlight-initial-delay' and `lazy-highlight-interval')."
  :type 'boolean
  :group 'lazy-highlight
  :group 'matching
  :version "22.1")

I played around with the following code in isearch.el:
      (unless (equal isearch-string "")
	(setq isearch-lazy-highlight-timer
	      (run-with-idle-timer lazy-highlight-initial-delay nil
				   'isearch-lazy-highlight-update)))))

Very curiously, this produced flaky behavior. Without actually changing any behavior (just inserting a progn wrapper, for instance, or reloading the file) I was able to get both instant highlighting and delayed highlighting with the same code!

Likely this is just a delay for large files while Emacs tries to figure out what should be highlighted. I can't reproduce it (lazy highlight for query replace is instant).


[VTA][Chisel] Change Scala Linter scalafmt => scalastyle

As scalafmt changes the code even with --test argument in the latest version, this PR switches scala linter for Chisel VTA from scalafmt to scalastyle.
@tmoreau89 @vegaluisjose Please review.

vta/apps still need to be updated.

Thanks @liangfu ; let us know when it's ready for a merge.

@tmoreau89 @vegaluisjose Thanks for the review. I think this is now ready for a merge, and let's wait for the CI testing results.

In addition, I made some final changes in fixing indentation errors, here is a typical example:
diff --git a/vta/hardware/chisel/src/main/scala/core/Load.scala b/vta/hardware/chisel/src/main/scala/core/Load.scala
index 7c79498bd..50c26bb8e 100644
--- a/vta/hardware/chisel/src/main/scala/core/Load.scala
+++ b/vta/hardware/chisel/src/main/scala/core/Load.scala
@@ -25,12 +25,12 @@ import vta.util.config._
 import vta.shell._

 /** Load.
-  *
-  * Load inputs and weights from memory (DRAM) into scratchpads (SRAMs).
-  * This module instantiate the TensorLoad unit which is in charge of
-  * loading 1D and 2D tensors to scratchpads, so it can be used by
-  * other modules such as Compute.
-  */
+ *
+ * Load inputs and weights from memory (DRAM) into scratchpads (SRAMs).
+ * This module instantiate the TensorLoad unit which is in charge of
+ * loading 1D and 2D tensors to scratchpads, so it can be used by
+ * other modules such as Compute.
+ */
 class Load(debug: Boolean = false)(implicit p: Parameters) extends Module {
   val mp = p(ShellKey).memParams
   val io = IO(new Bundle {
@@ -110,11 +110,10 @@ class Load(debug: Boolean = false)(implicit p: Parameters) extends Module {
       when(dec.io.isSync) {
         printf("[Load] start sync\n")
       }.elsewhen(dec.io.isInput) {
-          printf("[Load] start input\n")
-        }
-        .elsewhen(dec.io.isWeight) {
-          printf("[Load] start weight\n")
-        }
+        printf("[Load] start input\n")
+      }.elsewhen(dec.io.isWeight) {
+        printf("[Load] start weight\n")
+      }
     }
     // done
     when(state === sSync) {

Please take another look.

Thanks for the diff @liangfu ; this looks great.

Looks like CI failed on one of the unit tests

I think it might related to #4901 , let me trigger the testing pipeline again.

Thanks @liangfu, @vegaluisjose the PR has been merged!


Proposal: GraphQL support

Hi! Don't know if this is the right place to propose new features, please tell me if otherwise.
It would be great if Everest supported writing GraphQL queries and browsing a schema documentation, similar to how GraphiQL works.
I can work on the feature, but I was a backend Java developer and never worked with JFX (but I'm willing to learn) so I would much appreciate some help on the front-end side of things.
Basic features:

Fetch and parse a schema from a GraphQL endpoint so that it can be displayed in a graphical, browsable way
Write and send queries and mutations (with autocomplete based on the fetched schema) with validations and variables support
Customize request headers (same as the standard HTTP Everest section)

Nice to have:

WebSocket support to enable GraphQL subscriptions

Feel free to add your thoughts and suggestions if you have any, I'd like to throw in a little more brainstorming on this since it's a pretty huge feature to develop.

Hello again, Matteo! I remember you had the same suggestion for Everest a few months back on dev.to. I've had this in the back of mind but was planning on implementing it post stable release as a feature update. But since you're willing to build this, by all means!
I can definitely help with the front end stuff. However, I don't have any knowledge of GraphQL. I'll research and learn a bit and get back to you.
In the meanwhile, could you provide any mock-ups for this feature?

Hi Rowit!
I can start working on the backend stuff (implementing the GraphQL client and internal service classes that will be used in controllers) so that you or any other contributor can plug the frontend in at a later stage.

That sounds great! Let me know what you need from my end to get started.

I have a little experience with graphql and javafx.  I don't mind joining in contributing to this feature...
How do i begin to contribute?
I have a demanding day job so i might not have much hours per week to work on this project. I have been waiting for this for a long time.


🐛 [GitPod] Network error in graphiql when trying to load schema

Bug description

How to reproduce

https://gitpod.io/#https://github.com/wundergraph/wundergraph
go to gitpod /app/main/graphql
try to open the docs explorer

Expected behavior
docs explorer should show the schema
WunderGraph information
https://gitpod.io/#https://github.com/wundergraph/wundergraph
Environment & setup
https://gitpod.io/#https://github.com/wundergraph/wundergraph
WunderCtl Version
https://gitpod.io/#https://github.com/wundergraph/wundergraph

@hinogi, please retry. The examples have been involved a lot. It works on my end.


TELEGRAF-3: Wireless stats input plugins for HiveOS

Creating an input plugin to retrieve wireless stats [rf stats and client stats] from driver and send
to http server/output plugins.

extr_version needs to be incremented

Added Marian who handles Telegraf on FabricEngine (VOSS) platform.


Enabling hmr for parcel

Description
Fixes https://github.com/adobe/aio-cli-plugin-app/issues/410

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

I get this error during aio  app run on a fresh project with the react template. But this is even without your PR yet:
To view your local application:
  -> https://localhost:9080
To view your deployed application in the Experience Cloud shell:
  -> https://experience.adobe.com/?devMode=true#/custom-apps/?localDevUrl=https://localhost:9080
press CTRL+C to terminate dev environment
 Building react-refresh-runtime.development.js...
The above error occurred in the <UI> component:
    in UI
    in App

React will try to recreate this component tree from scratch using the error boundary you provided, App.
Warning: App: Error boundaries should implement getDerivedStateFromError(). In that method, return a state update to display an error message or fallback UI.
(node:90444) UnhandledPromiseRejectionWarning: Error: Got unexpected null
    at nullthrows (/Users/shazron/Documents/git/adobe/aio-cli-plugin-app/node_modules/nullthrows/nullthrows.js:7:15)
    at PackagedBundle.get filePath [as filePath] (/Users/shazron/Documents/git/adobe/aio-cli-plugin-app/node_modules/@parcel/core/lib/public/Bundle.js:373:38)
    at getProgressMessage (/Users/shazron/Documents/git/adobe/aio-cli-plugin-app/node_modules/@parcel/reporter-cli/lib/utils.js:21:63)
    at reducer (/Users/shazron/Documents/git/adobe/aio-cli-plugin-app/node_modules/@parcel/reporter-cli/lib/UI.js:85:53)
    at /Users/shazron/Documents/git/adobe/aio-cli-plugin-app/node_modules/@parcel/reporter-cli/lib/UI.js:44:68
    at updateReducer (/Users/shazron/Documents/git/adobe/aio-cli-plugin-app/node_modules/react-reconciler/cjs/react-reconciler.development.js:6367:23)
    at Object.useReducer (/Users/shazron/Documents/git/adobe/aio-cli-plugin-app/node_modules/react-reconciler/cjs/react-reconciler.development.js:7122:16)
    at useReducer (/Users/shazron/Documents/git/adobe/aio-cli-plugin-app/node_modules/react/cjs/react.development.js:1501:21)
    at UI (/Users/shazron/Documents/git/adobe/aio-cli-plugin-app/node_modules/@parcel/reporter-cli/lib/UI.js:44:49)
    at renderWithHooks (/Users/shazron/Documents/git/adobe/aio-cli-plugin-app/node_modules/react-reconciler/cjs/react-reconciler.development.js:6036:18)
(node:90444) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:90444) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

sorry I did a re-test, those errors show now because of the newly added parcel-reporter. Doesn't seem to affect things, but we should clean it up nonetheless

repro steps:
mkdir test
cd test
git clone https://github.com/adobe/aio-cli-plugin-app
cd aio-cli-plugin-app
git checkout hmr
npm i
aio plugins link .
# create a new FF project, react template, web-assets, actions
aio app init react-test
cd react-test
aio app run --verbose

thx @shazron . Fixed it.

thx @shazron . Fixed it.

thanks Hima, verified that the warning does not occur anymore and HMR works.


Error happen trying to export.

I've trained with my own model, And tried to export the model, But an error ocurred.
I put...
python3 export_graph.py --checkpoint_dir checkpoints/20191202-1127
--XtoY_model apple2orange.pb
--YtoX_model orange2apple.pb
--image_size 256
Error saids...
"Can't load save_path when it is None"

Oh, I solved.
The checkpoint file was saved as checkpoint.dms
After changing it into just checkpoint , It did work!


http port already in use - how to change port?

Govee Device SKU
H6110, H6199
Govee2MQTT Version
2024.04.29-30cf7732
Describe the issue
Hi there,
when I try to start this, the connection will be established to Govee.
The devices will be found, but cannot be stored.
The port use by this addon is already in use by another application. If I stop that, it surely will work, but this is not a possible option right now.
Is it possible to change the port, manually?
Maybe you can add a config field to specify a http-port if someone has the same case.
Startup Diagnostics
s6-rc: info: service s6rc-oneshot-runner: starting
s6-rc: info: service s6rc-oneshot-runner successfully started
s6-rc: info: service fix-attrs: starting
s6-rc: info: service fix-attrs successfully started
s6-rc: info: service legacy-cont-init: starting
s6-rc: info: service legacy-cont-init successfully started
s6-rc: info: service legacy-services: starting
s6-rc: info: service legacy-services successfully started
GOVEE_API_KEY=REDACTED
GOVEE_MQTT_HOST=core-mosquitto
GOVEE_TEMPERATURE_SCALE=C
GOVEE_EMAIL=REDACTED
GOVEE_PASSWORD=REDACTED
GOVEE_MQTT_PASSWORD=REDACTED
GOVEE_MQTT_USER=myuser
GOVEE_MQTT_PORT=1883
++ cd /app
++ exec /app/govee serve
[2024-05-22T02:29:54 INFO  govee::commands::serve] Starting service. version 2024.04.29-30cf7732
[2024-05-22T02:29:54 INFO  govee::commands::serve] Querying platform API for device list
[2024-05-22T02:29:55 INFO  govee::commands::serve] Querying undocumented API for device + room list
[2024-05-22T02:29:57 INFO  govee::service::iot] Connected to IoT: CONNACK code 0: Connection Accepted.
[2024-05-22T02:29:57 INFO  govee::service::iot] IoT (re)connected with status CONNACK code 0: Connection Accepted.
[2024-05-22T02:29:57 INFO  govee::commands::serve] Starting LAN discovery
[2024-05-22T02:29:57 INFO  govee::commands::serve] Waiting 10 seconds for LAN API discovery
[2024-05-22T02:30:07 INFO  govee::commands::serve] Devices returned from Govee's APIs
[2024-05-22T02:30:07 INFO  govee::commands::serve] Licht Sofa (3C:62:A4:C1:22:F7:11:E9 H6110)
[2024-05-22T02:30:07 INFO  govee::commands::serve]   Platform API: devices.types.light. supports_rgb=true supports_brightness=true
[2024-05-22T02:30:07 INFO  govee::commands::serve]                 color_temp=Some((2000, 9000)) segment_rgb=None
[2024-05-22T02:30:07 INFO  govee::commands::serve]   Undoc: room=None supports_iot=true ble_only=false
[2024-05-22T02:30:07 INFO  govee::commands::serve]
[2024-05-22T02:30:07 INFO  govee::commands::serve] Licht Fernseher (9C:EC:44:C1:38:4D:33:04 H6110)
[2024-05-22T02:30:07 INFO  govee::commands::serve]   Platform API: devices.types.light. supports_rgb=true supports_brightness=true
[2024-05-22T02:30:07 INFO  govee::commands::serve]                 color_temp=Some((2000, 9000)) segment_rgb=None
[2024-05-22T02:30:07 INFO  govee::commands::serve]   Undoc: room=None supports_iot=true ble_only=false
[2024-05-22T02:30:07 INFO  govee::commands::serve]
[2024-05-22T02:30:07 INFO  govee::commands::serve] DreamView (24:88:D9:32:37:99:71:25 H6199)
[2024-05-22T02:30:07 INFO  govee::commands::serve]   Platform API: devices.types.light. supports_rgb=true supports_brightness=true
[2024-05-22T02:30:07 INFO  govee::commands::serve]                 color_temp=Some((2000, 9000)) segment_rgb=Some(0..15)
[2024-05-22T02:30:07 INFO  govee::commands::serve]   Undoc: room=None supports_iot=true ble_only=false
[2024-05-22T02:30:07 INFO  govee::commands::serve]
Error: Starting HTTP service on port 8056
Caused by:
0: run_http_server: binding to port 8056
1: Address in use (os error 98)
Stack backtrace:
0: anyhow::context::<impl anyhow::Context<T,E> for core::result::Result<T,E>>::with_context
1: govee::commands::serve::ServeCommand::run::{{closure}}
2: govee::Args::run::{{closure}}
3: tokio::runtime::park::CachedParkThread::block_on
4: tokio::runtime::context::runtime::enter_runtime
5: tokio::runtime::runtime::Runtime::block_on
6: govee::main
7: std::sys_common::backtrace::__rust_begin_short_backtrace
8: std::rt::lang_start::{{closure}}
9: core::ops::function::impls::<impl core::ops::function::FnOnce for &F>::call_once
at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/core/src/ops/function.rs:284:13
10: std::panicking::try::do_call
at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/std/src/panicking.rs:554:40
11: std::panicking::try
at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/std/src/panicking.rs:518:19
12: std::panic::catch_unwind
at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/std/src/panic.rs:142:14
13: std::rt::lang_start_internal::{{closure}}
at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/std/src/rt.rs:148:48
14: std::panicking::try::do_call
at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/std/src/panicking.rs:554:40
15: std::panicking::try
at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/std/src/panicking.rs:518:19
16: std::panic::catch_unwind
at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/std/src/panic.rs:142:14
17: std::rt::lang_start_internal
at /rustc/25ef9e3d85d934b27d9dada2f9dd52b1dc63bb04/library/std/src/rt.rs:148:20
18: main
s6-rc: info: service legacy-services: stopping
s6-rc: info: service legacy-services successfully stopped
s6-rc: info: service legacy-cont-init: stopping
s6-rc: info: service legacy-cont-init successfully stopped
s6-rc: info: service fix-attrs: stopping
s6-rc: info: service fix-attrs successfully stopped
s6-rc: info: service s6rc-oneshot-runner: stopping
s6-rc: info: service s6rc-oneshot-runner successfully stopped
Additional Logs
No response
Home Assistant Logs
No response
Anything else?
No response

Hi there, are you running it on docker?


Fix job-master gRPC context cascading

gRPC requires io.grpc.Context instance to be forked if an RPC implementation calls another RPC. Because termination of first call will invalidate context of the cascaded calls. Even if calls are contained within each other, with authentication long polling, authentication stream opened for the second call will be canceled after first call returns. That means every call to first RPC will cause tearing up of channel used for the second RPC.
This PR forks gRPC context inside JobMaster:run RPC call since some job definitions require RPC calls during initialization.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4299/
Test FAILed.

Jenkins, test this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4303/
Test FAILed.

Jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4306/
Test PASSed.

@bf8086 PTAL. Thanks!

@calvinjia PTAL.

alluxio-bot, merge this please.

alluxio-bot, cherry-pick this to branch-2.0 please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4328/
Test PASSed.


fix: Use AWS SDK Instrument spec for common attributes

Description
Update the opentelmetry-instrumentation-aws-sdk package to follow the common attributes in the specification for instrumentation of the AWS SDK, specifically, this PR only address the issues with the "common attributes".
Updates

rpc.service uses the unmodified service.serviceIdentifier instead of converting it to lower case
rpc.method uses the unmodified awsV2Request.operation instead of converting it to CamelCase

Fixes #160

Did you take a look at why tests are failing?
If you need help running them or understanding what's going on let me know :)

Did you take a look at why tests are failing? If you need help running them or understanding what's going on let me know :)

Thanks for your help with this! 🙂 I seem to be failing some of the SQS tests.. I can't tell why because I already updated the hook into the ServicesExtensions.ts file to be SQS not sqs... do you have any guesses as to what I may have missed? 😓
    custom service behavior
      SQS
        ✓ sqs send add messaging attributes
        1) sqs receive add messaging attributes and context

  DynamoDB
    receive context
      ✓ should add db attributes to dynamodb request

  SQS
    receive context
      2) should set parent context in sqs receive callback
      3) should set parent context in sqs receive 'send' callback
      4) should set parent context in sqs receive promise then
      - should set parent context in sqs receive after await
      - should set parent context in sqs receive from async function
    process spans
      5) should create processing child with forEach
      6) should create processing child with map
      ✓ should not fail when mapping to non-object type
      ✓ should not fail when mapping to undefined type
      ✓ should create one processing child when throws in map
      7) should create processing child with two forEach
      ✓ should forward all parameters to forEach callback
      ✓ should create one processing child with forEach that throws
      - should create processing child with array index access
      8) should create processing child with map and forEach calls
      9) should create processing child with filter and forEach
      - should create processing child with for(msg of messages)
      - should create processing child with array.values() for loop
      - should create processing child with array.values() for loop and awaits in process
      ✓ should propagate the context of the receive call in process spans loop

Thanks for your help with this! 🙂 I seem to be failing some of the SQS tests.. I can't tell why because I already updated the hook into the ServicesExtensions.ts file to be SQS not sqs... do you have any guesses as to what I may have missed? 😓

The service extensions also apply some logic based on the operation name. since these now have different casing, they need to be updated as well. See here for an example

@blumamir

The service extensions also apply some logic based on the operation name. since these now have different casing, they need to be updated as well. See here for an example

Awesome thank you this was exactly what I needed! I'm happy to see that pattern for SQS because that is exactly the pattern that PRs like #166 will benefit from 😄
I updated those names and now all the tests all pass, but the command yarn:test:ci:changed just keeps looping on the tests instead of exiting. (The 6 skipped tests are marked as "pending"). Maybe I need to be using a different command?
Please run the tests again when you have a chance!
Also side note: I updated the name of V3 spans to match the name of V2 spans, since this naming is also in the spec

The span name MUST be of the format Service.Operation as per the AWS HTTP API, e.g., DynamoDB.GetItem, S3.ListBuckets. This is equivalent to concatenating rpc.service and rpc.method with . and consistent with the naming guidelines for RPC client spans.

@blumamir
Thank you for helping me run the tests again! I can see now that the tests are failing specifically on "<EMAIL_ADDRESS>but they work fine for the later versions of client-sqs 😅.
If we still want to support this version 3.0.0, I think the best solution is to switch on the serviceName in normalizeV3Request and simply map to the right value:
https://github.com/aspecto-io/opentelemetry-ext-js/blob/f9d08fb8dd95cfad7658ed979c154cf75c979262/packages/instrumentation-aws-sdk/src/utils.ts#L25-L34
i.e.
switch(serviceName) {
    case 'sqs':
        return 'SQS';
    default:
        return serviceName;
}

Just as an FYI, I printed out the values of clientConfig.serviceId and removeSuffixFromStringIfExists(awsExecutionContext.clientName, 'Client') again from this line:
https://github.com/aspecto-io/opentelemetry-ext-js/blob/f9d08fb8dd95cfad7658ed979c154cf75c979262/packages/instrumentation-aws-sdk/src/aws-sdk.ts#L313-L314
and it looks like for<EMAIL_ADDRESS>the values are sqs and SQS respectively. But in later versions this is fixed and they are both SQS. I think the precedence order is still correct as a follow up from our previous discussion hence why I suggest the solution above.

but the command yarn:test:ci:changed just keeps looping on the tests instead of exiting

As you probably figured out, this command runs the test on various versions of the package to make sure it works for all supported versions

I can see now that the tests are failing specifically on "<EMAIL_ADDRESS>but they work fine for the later versions of client-sqs

It's hard for me to believe someone is using this old version for anything. let's just drop support for it. you can change this file to fix make tests run only for >=3.0.1
Thanks again for all the great work and the research you put into this :)

Also side note: I updated the name of V3 spans to match the name of V2 spans, since this naming is also in the spec

Great, thank you :)

It's hard for me to believe someone is using this old version for anything. let's just drop support for it. you can change this file to make tests run only for >=3.0.1

Thanks! I agree 🙂 I changed .tav.yml and the tests completed successfully on my local machine! Should be good for a re-run 🤞
Just to confirm, this means people using client-sqs or client-s3 in V3 will still get tracing, they just won't have the attributes set by the sqs.ts ServiceExtension (which adds attributes based on the operation). Further, their rpc.service will be sqs not SQS. But I think it's find because if you are using 3.0.0 you can most likely afford to use 3.1.0 which ^3.0.0 will do anyways and is the normal as far as I'm aware for JS package.json dependencies 🙂

Thanks again for all the great work and the research you put into this :)

Absolutely! Thank you for being so helpful and quick to respond! It's made contributing fun and easy 😄

Just to confirm, this means people using client-sqs or client-s3 in V3 will still get tracing, they just won't have the attributes set by the sqs.ts ServiceExtension (which adds attributes based on the operation). Further, their rpc.service will be sqs not SQS. But I think it's find because if you are using 3.0.0 you can most likely afford to use 3.1.0 which ^3.0.0 will do anyways and is the normal as far as I'm aware for JS package.json dependencies 🙂

Actually, since the functionality is not expected to work correctly for v3.0.0, I think it might be a good idea to not patch it as well. which means - updating the supportedVersion here. WDYT?

the tests completed successfully on my local machine! Should be good for a re-run 🤞

There is still an open discussion on your issue regarding the spec and what values should be used for the rpc attributes. Do you prefer to wait few days and see if it converges? or are you waiting for this fix for something urgent?
I'm ok with both options (waiting or releasing). Let me know what you prefer.

I think it might be a good idea to not patch it as well. which means - updating the supportedVersion here. WDYT?

Yeah I agree! I checked the releases and it looks like the next release after 3.0.0 is 3.1.0. 3.0.1 does not exist, so I updated that everywhere in this PR to be 3.1.0 so that the compatibility is hopefully clear.

There is still an open discussion on your issue regarding the spec and what values should be used for the rpc attributes. Do you prefer to wait few days and see if it converges? or are you waiting for this fix for something urgent?
I'm ok with both options (waiting or releasing). Let me know what you prefer.

Thanks for being flexible while the spec evolves 🙂 I would prefer to merge this one now if that's okay with you?
I saw that the spec has a PR to update the examples to include Route53 explicitly instead of Route 53. So, in this PR I updated the README.md with the same description and added a .replace('/s+/g', '') on the service name so we are still up to date with them.
If the spec evolves such that there is anything else we need to change in the future hopefully it will be a smaller PR than this one and I can follow up quickly! The goal in merging early now is that it would help us towards getting consistent values across the instrumentations. 😄
Finally, I'll remove the "Fixes #160" keyword from the PR description so we can close that ourselves when when the spec PR goes in and changes don't occur for a couple of days.

merged, thanks again

released as<EMAIL_ADDRESS>


Fixes to support CS2

Still 3 broken tests, 1 test is due to possibly to bug described here: jashkenas/coffeescript#4463

https://github.com/jashkenas/coffeescript/issues/4463 has been fixed in https://github.com/jashkenas/coffeescript/issues/4485

The brand new JSX syntax in CS2 also needs to be handled.

The JSX syntax is especially important for a linter to handle. In the docs I recommend people always put spaces on either side of < and >, e.g. i < 1 rather than i<1, to disambiguate comparisons from JSX tags. In the compiler we tried to be as lenient as possible about this, to minimize the breaking change for people who have e.g. i<1 in their code, by doing what we can to detect when < is being used to compare instead of delimit a JSX tag; in this example, the 1 is a tip-off, because JSX tags can’t begin with numbers. But while the compiler tries to be forgiving, the linter should be the opposite, throwing warnings wherever a < or > appears to be used in a comparison (such as when there’s no matching closing < or > symbol).

Is this being merged?

Coffeescript 2 is now released: http://coffeescript.org/announcing-coffeescript-2/
It would be awesome to have support for it in coffeelint soon :)

All test pass. If you want to try out CS2 support feel free to point to this branch. It is late here, so I want to wait until I have time to monitor when the library before publishing to npm.

@swang - thank you for the support. As I wrote here: https://github.com/clutchski/coffeelint/issues/595 - I'm getting an error when installing the cs2 branch. The same error happens with your new commits. Any ideas what's going on?

Sorry it's a bit late here so I'm not going to be able to look at this until tomorrow. I'm guessing npm installing a branch was never viable.

No problem, good night, we can wait a bit more. :) Thanks again for the support, we all appreciate it!
It's kind of strange because this file IS there. Also I've npm-installed packages from GitHub branches before... not sure what the issue is.

I also ran into errors trying to install with npm using their git:user/repo#branch syntax.
Although I happen to already have a local clone from contributing other PRs, so I checked out the cs2 branch and have been using that via npm link, so far with no errors, and all tests pass for me also. So hopefully @swang, this should be good to go?

@swang - could you merge this and release a new version please? :)


Acceptance/Integration Tests introduction

Acceptance/Integration tests are really important because they ensure that multiple components can still work together. In the past, we did this manually which had a negativ impact on our feature development time as well as it opened the door to introduce misterious side effects into Gaia.
This PR is the start of implementing an Acceptance/Integration test framework (we just use go tests) which also requires some refactoring.

One job is failing because of the race condition which should be fixed with my other PR. Once #132 has been merged and the job doesn't crash it should be ready to get merged! 🤗

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a1cbf49). Click here to learn what that means.
The diff coverage is 33.33%.

@@            Coverage Diff            @@
##             master     #133   +/-   ##
=========================================
  Coverage          ?   64.02%
=========================================
  Files             ?       25
  Lines             ?     2171
  Branches          ?        0
=========================================
  Hits              ?     1390
  Misses            ?      626
  Partials          ?      155

Impacted Files
Coverage Δ

services/service_provider.go
77.77% <ø> (ø)

workers/pipeline/create_pipeline.go
50% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1cbf49...abf69f8. Read the comment docs.


Inference Gradio error

@Vikr-182 @RudeNinja  Thanks a lot for sharing ur codebase and wonderful work , i had the following error when i try to run gradio with the given input below i am getting an error

Please let me knw if u have face any errors like this
THanks in advance

@Vikr-182  nope it did not work for the first time also , i did the suggestions u mentioned but still getting the same error , i have made the changes suggested in two places of the code
https://github.com/llmbev/talk2bev/blob/e9313f79fd7ec17ce61625f54c1c065ecd638edb/click2chat/click2chat_llava.py#L195
https://github.com/llmbev/talk2bev/blob/e9313f79fd7ec17ce61625f54c1c065ecd638edb/data/utils.py#L100
Please let me knw if i have to do anything else


Hanna mb 8084 success fail alert edit move contact info

Description
GIVEN I am a services counselor
When I have made changes to service member contact info
Then I’m greeted with a success message if the update was successful and an error message if it was not

Add onUpdate prop to <CustomerInfo /> that is called with either 'success' or 'error' string
Add customerEditAlert state to <ServicesCounselingMoveInfo /> that updates this state on the update callback. It also listens to route changes so the alert is cleared on page navigation. I figured just moving this state up to the parent made the most sense. State can be passed via the router, but it's not easily cleared. I didn't think adding a separate context made sense, either, as this state is only being passed down/up one level.
Add customerEditAlert prop to ` to display the alert

Reviewer Notes
Setup
Add any steps or code to run in this section to help others prepare to run your code:
make server_run
make client_run

Save move customer info to view the success alert.
Return a rejected promise from updateCustomerInfo in ghcApi.js to test the error state.
Code Review Verification Steps

[ ] If the change is risky, it has been tested in experimental before merging.
[ ] Code follows the guidelines for Logging
[ ] The requirements listed in Querying the Database Safely have been satisfied.
Any new migrations/schema changes:

[ ] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Screenshots

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against 35021ee2c8ae92aa9c071130141997f0efe33079

Hmm, I merged master in and my tests are failing, I think because of this being added:
  const handleClose = () => {
    history.push(generatePath(servicesCounselingRoutes.MOVE_VIEW_PATH, { moveCode }));
  };

Which now depends on moveCode being defined, but it's not in the test. Is there something with the MockProviders setup we are doing wrong? Tagging @felipe-lee because you might have familiarity with this.

Hmm, I merged master in and my tests are failing, I think because of this being added:
  const handleClose = () => {
    history.push(generatePath(servicesCounselingRoutes.MOVE_VIEW_PATH, { moveCode }));
  };

Which now depends on moveCode being defined, but it's not in the test. Is there something with the MockProviders setup we are doing wrong, something that doesn't make useParams work? Tagging @felipe-lee because you might have familiarity with this.

I think it might be because of the way the initialEntries are being defined currently. In another test file we define the url based on how it would be generated, which i guess sets it up to be pulled out in params as expected:
https://github.com/transcom/mymove/blob/35021ee2c8ae92aa9c071130141997f0efe33079/src/pages/Office/ServicesCounselingMoveDetails/ServicesCounselingMoveDetails.test.jsx#L179-L187

@felipe-lee, ah, I should have mentioned, I did try to set the test up that way locally but it still failed. I will keep looking at this today.

@felipe-lee, ah, I should have mentioned, I did try to set the test up that way locally but it still failed. I will keep looking at this today.

Sorry I didn't get back to this sooner. Just figured it out, you need something like this:
https://github.com/transcom/mymove/blob/35021ee2c8ae92aa9c071130141997f0efe33079/src/pages/Office/ServicesCounselingMoveDetails/ServicesCounselingMoveDetails.test.jsx#L18-L21
With the move code you want


Update dependencies and GitRepository to v1

Keeping this in hold until we're ready to cut a Flux release and associated docs.