adds types to exports to resolve tsc error

Helps to resolve the following build error:
$ tsc && vite build
src/hooks/auth.ts:1:31 - error TS7016: Could not find a declaration file for module 'react-query-auth'. '/path/to/project/node_modules/react-query-auth/dist/index.mjs' implicitly has an 'any' type.
  There are types at '/path/to/project/node_modules/react-query-auth/dist/index.d.ts', but this result could not be resolved when respecting package.json "exports". The 'react-query-auth' library may need to update its package.json or typings.

1 import { configureAuth } from "react-query-auth";
                                ~~~~~~~~~~~~~~~~~~

Found 1 error in src/hooks/auth.ts:1

Will this be merged anytime soon?

Can you merge this bud? @alan2207

Hey folks, latest updates published with the latest version - 2.4.0

@alan2207 hi sorry for bother again but im currently facing with strange issue. im currently updating version to 2.4.0. i deleted package-lock.json and node_modules then i did npm install.
{   "name": "test-app",   "private": true,   "version": "0.0.0",   "type": "module",   "scripts": {     "dev": "vite",     "build": "tsc -b && vite build",     "lint": "eslint .",     "preview": "vite preview"   },   "dependencies": {     "@hookform/resolvers": "^3.9.0",     "@radix-ui/react-icons": "^1.3.0",     "@radix-ui/react-label": "^2.1.0",     "@radix-ui/react-select": "^2.1.1",     "@radix-ui/react-slot": "^1.1.0",     "@tanstack/react-query": "^5.52.1",     "axios": "^1.7.5",     "class-variance-authority": "^0.7.0",     "clsx": "^2.1.1",     "framer-motion": "^11.3.30",     "lucide-react": "^0.435.0",     "react": "^18.3.1",     "react-dom": "^18.3.1",     "react-error-boundary": "^4.0.13",     "react-hook-form": "^7.53.0",     "react-query-auth": "^2.4.0",     "react-router-dom": "^6.26.1",     "tailwind-merge": "^2.5.2",     "tailwindcss-animate": "^1.0.7",     "zod": "^3.23.8"   },   "devDependencies": {     "@eslint/js": "^9.9.0",     "@types/node": "^22.5.0",     "@types/react": "^18.3.3",     "@types/react-dom": "^18.3.0",     "@vitejs/plugin-react": "^4.3.1",     "autoprefixer": "^10.4.20",     "eslint": "^9.9.0",     "eslint-plugin-react-hooks": "^5.1.0-rc.0",     "eslint-plugin-react-refresh": "^0.4.9",     "globals": "^15.9.0",     "postcss": "^8.4.41",     "tailwindcss": "^3.4.10",     "typescript": "^5.5.3",     "typescript-eslint": "^8.0.1",     "vite": "^5.4.1"   } }
however it still give error. i checked package.json for your package.
{   "name": "react-query-auth",   "version": "2.4.0",   "author": "alan2207",   "license": "MIT",   "repository": "alan2207/react-query-auth",   "main": "./dist/index.mjs",   "module": "./dist/index.mjs",   "types": "./dist/index.d.ts",   "files": [     "dist",     "src"   ],   "exports": {     "require": "./dist/index.js",     "import": "./dist/index.mjs"   },   "engines": {     "node": ">=16"   },   "scripts": {     "dev": "tsup src/index.tsx --watch",     "build": "tsup src/index.tsx",     "test": "jest",     "lint": "eslint --fix ./src",     "size": "size-limit"   },   "peerDependencies": {     "@tanstack/react-query": ">=4.24.6",     "react": ">=16.8.0"   },   "husky": {     "hooks": {       "pre-commit": "npm run lint"     }   },   "size-limit": [     {       "path": "dist/index.mjs",       "limit": "10 KB"     },     {       "path": "dist/index.js",       "limit": "10 KB"     }   ],   "devDependencies": {     "@size-limit/preset-small-lib": "^8.2.4",     "@tanstack/react-query": "^5.7.2",     "@testing-library/jest-dom": "^5.16.5",     "@testing-library/react": "^13.4.0",     "@testing-library/react-hooks": "^8.0.1",     "@types/react": "^18.0.28",     "@types/react-dom": "^18.0.11",     "@typescript-eslint/eslint-plugin": "^5.52.0",     "@typescript-eslint/parser": "^5.52.0",     "eslint": "^8.34.0",     "eslint-config-prettier": "^8.6.0",     "eslint-plugin-react": "^7.32.2",     "husky": "^8.0.3",     "jest": "^29.4.3",     "jest-environment-jsdom": "^29.4.3",     "react": "^18.2.0",     "react-dom": "^18.2.0",     "size-limit": "^8.2.4",     "ts-jest": "^29.0.5",     "tsup": "^6.6.3",     "typescript": "^4.9.5"   } }
as you can see version is changed but exports still not updated. do you know why?

@goktugs , can you share your tsconfig.json here?

@goktugs , can you share your tsconfig.json here?

Sorry for late reply

@goktugs Can you try changing jsx to preserve?

@goktugs Can you try changing jsx to preserve?

i changed jsx at tsconfig.app.json to preserve. then i deleted package.lock and node_modules theen npm install. nothing changed

@goktugs can you share a repro?

@alan2207 , seems like this change didn't make it to npm package.

Can you try again with 2.4.1?

Can you try again with 2.4.1?

Thank you so much its working now


Fix import to Postgres when value types are bad

If a feed has a value that isn't an integer in a field that requires an integer, the import would fail when importing the data into postgres. Non-integers (and non-dates for date fields, and non-yes/no for boolean fields) will no longer throw an exception and instead insert nil into the database. An error is already logged for the type mismatch.
Pivotal bug 99541752

Nice. This looks great to me.


MeWe Returns Artifact

Artifact script for processing warrant returns from MeWe chat app. Point RLEAPP to the root folder above "mewe-content" folder provided by the vendor.

This is awesome!!! Thank you so much!!!!


Offline pilots still show up

Hi,
had an issue with 1.5.0. where offline still show up even after days/weeks. Today I updated to 1.5.3 and the problem remains.
As far as I understood the online pilot list is maintained by a cron job. In one of the issue posts you suggested a
php index.php "/cron/deleteLogData"
with addidtional debug data. But that function crashes unmodified with a 500:
mk@seat:/var/www/pathfinder/pathfinder$ php index.php "/cron/deleteLogData"
Call to undefined method Cron\CharacterUpdate::isOnline() [/var/www/pathfinder/pathfinder/app/main/cron/characterupdate.php:68]
[app/lib/cron.php:129] Cron\CharacterUpdate->deleteLogData()
[app/lib/cron.php:162] Cron->execute()
[index.php:20] Base->run()
[10:37:00] ───────────────────────────
  type:     error
  code:     500
  status:   Call to undefined method Cron\CharacterUpdate::isOnline() [/var/www/pathfinder/pathfinder/app/main/cron/characterupdate.php:68]
  message:  Internal Server Error

Any hints ?
Thank you and keep rolling this - Pathfinder rocks !!!
-Micky

:heavy_check_mark: Issue resolved
This issue was resolved by the commit(s) and/or the comments above.
It will be auto-closed with the upcoming release ( merge into master branch). Please check the attached Milestone information.
Many thanks to all participants/contributors for the helpful comments! :+1:
:information_source: You may reopen this issue if it has been closed in error.

Auto-generated response


In a $everything return, the bundle entry for Patient has no fullUrl set

In the response to http://fhir2.healthintersections.com.au/open/Patient/1511/$everything
The patient entry looks like this:

it should have fullUrl set

fixed


HAL_I2C_Mem_Write_IT does not correctly initialize hi2c->XferSize

Describe the bug
If an I2C write transaction fails, the hi2c->XferCount may be left set to a non zero value. Subsequent calls to HAL_I2C_Mem_Write_IT  will then ALWAYS fail because the condition hi2c->XferSize == 0U is not met in the interrupt handler
I2C_Master_ISR_IT
  else if ((I2C_CHECK_FLAG(tmpITFlags, I2C_FLAG_TCR) != RESET) && \
           (I2C_CHECK_IT_SOURCE(ITSources, I2C_IT_TCI) != RESET))
  {
    if ((hi2c->XferCount != 0U) && (hi2c->XferSize == 0U))

this causes HAL_I2C_ERROR_SIZE to be returned.
     {
        /* Wrong size Status regarding TCR flag event */
        /* Call the corresponding callback to inform upper layer of End of Transfer */
        I2C_ITError(hi2c, HAL_I2C_ERROR_SIZE);

}

A clear and concise description of what the bug is.
How To Reproduce
Perform a failing I2C transaction, then call HAL_I2C_Mem_Write_IT.
Additional context
To fix, unconditionally set hi2c->XferSize =0u  in HAL_I2C_Mem_Write_IT.
Screenshots
If applicable, add screenshots to help explain your problem.

Hello @thealastair,
Thank you for this report. We will get back to you as soon as we analyze it further. This may take some time. Thank you for your comprehension.
With regards,

Hello @thealastair ,
Thank you for this contribution, this point has been reported to our development teams. I will get back to you as soon as I have any updates.
Best Regards,

ST Internal Reference:  152242


Specify how to read no URL proprietary license

Related Issue(s): #664
Proposed Changes:

Explicitly state the interpretation of absence of URL when license on collections is proprietary

PR Checklist:

[x] This PR has no breaking changes.
[ ] I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
~API only: I have run npm run generate-all to update the generated OpenAPI files.~

Thanks for the PR @jisantuc , can you update it to be against the dev branch rather than master?

It is done -- I went looking for previous chatter about the default branch, is there any particular reason to keep it master instead of dev, if dev is what PRs should target?

Looks good, with the exception that in the Collection the addition is in the link rel types. In the Item it is in the Field Description and in the Collection it should also be described there instead of in the link rel type, I think.

@jisantuc the idea is that the master branch is the last released version, so is the branch that people see when they come to the page, while dev is the current (under development) version.  PRs should always target dev.

Looks good, thanks. I added a Changelog entry for you.


[release-v1.12] Adjust project.yaml to v1.12

Adjust project.yaml after branch renaming.

/retest

/retest


Add OGM harvest to CLI commands

Purpose and background context
This PR fills out the stubbed OGM harvest command in click CLI commands, making the CLI ready when records normalization is complete for OGM harvests.
How can a reviewer manually see the effects of these changes?
Set env vars:
WORKSPACE=dev
SENTRY_DSN=None
S3_RESTRICTED_CDN_ROOT=s3://cdn-origin-dev-222053980223/cdn/geo/restricted/
S3_PUBLIC_CDN_ROOT=s3://cdn-origin-dev-222053980223/cdn/geo/public/
GEOHARVESTER_SQS_TOPIC_NAME=geo-harvester-input-dev

It is now possible to run an OGM harvest via the CLI, that should produce some output indicating it has started:
pipenv run harvester --verbose harvest \
--harvest-type=incremental \
--from-date=2024-01-10 \
ogm

This will throw some errors, as the normalization logic is not complete, but it can be seen the harvest has started, with arguments like --from-date getting used as expected.
Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?

https://mitlibraries.atlassian.net/browse/GDT-109

Developer

[ ] All new ENV is documented in README
[ ] All new ENV has been added to staging and production environments
[ ] All related Jira tickets are linked in commit message(s)
[ ] Stakeholder approval has been confirmed (or is not needed)

Code Reviewer(s)

[ ] The commit message is clear and follows our guidelines (not just this PR message)
[ ] There are appropriate tests covering any new functionality
[ ] The provided documentation is sufficient for understanding any new functionality introduced
[ ] Any manual tests have been performed and verified
[ ] New dependencies are appropriate or there were no changes

Looks good but needs to be rebased with main! :)

@jonavellecuerdo - Rebased!  This was an interesting one... I'm pretty confident the code would have been okay without that step, but you're right, that doing so might result in a cleaner shared git history.


Error running two saved migrations

What
Error running two saved migrations in a new project
Version
<EMAIL_ADDRESS>binary version: 3c4da1d6caa0c40a0210a346ec982c77f74e18c7
Error output
https://gist.github.com/2color/e12242b2491a391fd2fcc7455b3087a2
Workaround
Run prisma2 lift up after every prisma save
Steps to reproduce

prisma init
Choose Blank project
Choose Postgres
Set database details
Create postgres schema with CLI
Choose JavaScript
Choose just the Prisma schema

At this point the schema looks like this:
datasource db {
  provider = "postgresql"
  url      = "postgresql://postgres@localhost/woot?schema=woot"
}

generator photon {
  provider = "photonjs"
}

model User {
  id    String  @default(cuid()) @id @unique
  email String  @unique
  name  String?
  posts Post[]
}

model Post {
  id        String   @default(cuid()) @id @unique
  createdAt DateTime @default(now())
  updatedAt DateTime @updatedAt
  published Boolean
  title     String
  content   String?
  author    User?
}

Run prisma2 lift save
Add the Comment model to schema:

model Comment {
  id String @default(cuid()) @id @unique
  createdAt DateTime @default(now())
  updatedAt DateTime @updatedAt
  comment String
  author User?
}

Run prisma2 lift up - This step fails:

Response: {
  "jsonrpc": "2.0",
  "error": {
    "code": 4466,
    "message": "The migration engine panicked while handling the request. Check the data field for details.",
    "data": {
      "message": "Failure during a migration command: Generic error. (error: The model User already exists in this Datamodel. It is not possible to create it once more.)",
      "backtrace": null
    }
  },
  "id": 3
}
The migration engine panicked while handling the request. Check the data field for details.

Getting this as well


Formatting of numbers

Hey, I tested your formatter, and discovered the number rounding, wondering if that is intended feature:
5317062322949193729 becomes<PHONE_NUMBER>949194000

This is because your number is greater than Number.MAX_SAFE_INTEGER.
You could present your numbers only as strings and use a library like bignumber.js to work with them, or you could use the BigInt number-type and suffix your numbers with n.

Interesting.  This is happening because the JavaScript version reads the document as JS data, before trying to produce output.  In other word, it relies on JSON.parse.  All numbers in JavaScript are double-precision floats, and therefore limited to 52 bits of precision (roughly 16 decimal digits).
Based on some quick tests, it looks like the .NET version does not exhibit this behavior.
The JSON spec doesn't put any limit on the size or precision of a number in a document.  In theory you could have a JSON number with 1,000 digits.  (It does warn about interoperability problems outside the range of doubles, though.)  The correct behavior would be to preserve the number exactly, no matter how many digits it has.  So I think it's fair to say this is a bug in the JavaScript/Browser implementations.
As a practical matter, I can't fix this without rewriting the JavaScript version using a more powerful JSON parsing library, which would more closely follow how the C# code works.  I might do that at some point, since it would open up a few other requested features.  But that's a rewrite, not a patch.  In the short term I think I need to flag this as a known issue.  Hopefully it doesn't impact too many people.

@j-brooke I did wonder if the JSON.parse "reviver" callback could help, but you're quite right - I ram quick test and the number is indeed clobbered before it reaches the callback.
Also, it seems that BigInt isn't a supported JSON number type? At least it wasn't working for me. 🤔

@shuckster Good thought.  I hadn't known that the "reviver" parameter existed.  Pity it doesn't look like it helps in this case.

Version 3 of the Web Formatter is up, and this problem is fixed there.  (The JS and VSCode versions haven't been updated yet though.)


dc predict

add reviewers later.
reorganized the mock interface for code reuse.
mY mANIFEST

[x] perform_infernece
[x] predict
[x] predict_topk

My Summary

[x] provide unittest.

[x] perfrom_inference
[x] predict
[x] predict topk

[x] pass the test pipeline.

@abhishekpratapa this is helpful for you to test style. @jakesabathia2 worked on this before, add him as a reviewer.

This contains my cherry-pick from #2511

Could we resolve merge conflicts first?

resolved.


Global Policy in 0.11

It seems as though the global wildcard is overriding all of the lower rules. For example:
module.exports.policies = {
  '*': false,
  'AuthController:': {
    '*': true
  },
  'MainController': {
    '*': 'isAuthenticated',
    'admin': ['isAuthenticated', 'isAdmin']
  }
};

The above snippet is causing a post to AuthController.login to return with a forbidden response. If I remove the wildcard policy then everything works properly. Is this a bug or am I missing something here?

It seems to me that the name of your AuthController policy is wrong. The colon at the end probably shouldn't be there
module.exports.policies = {
  '*': false,
  'AuthController': {
    '*': true
  },
  'MainController': {
    '*': 'isAuthenticated',
    'admin': ['isAuthenticated', 'isAdmin']
  }
};

Thanks, I completely missed that!


[1.0.2-bp][ec] match built-in curves on EC_GROUP_new_from_ecparameters

This is a backport of #9808 for 1.0.2-stable.
See the description in #9808 for a full report.
This PR includes a partial backport of #8555 (commit 8402cd5)
for which the main author is @slontis .
This also depends on merging #9799 as it uses the backported bn_bn2binpad function.
I had to drop the new tests already at 1.1.0 as porting them to the older test architecture seems like a major effort.
I did manually spot check that the expected new behavior is happening, but not as extensively as the original testing.
I am triggering the extended tests for good measure.
Checklist

[x] documentation is added or updated
[ ] tests are added or updated

Rebased now that #9799 is merged

@mattcaswell I see Appveyor has some failures due to inline, but in 1.0.2 there is no ossl_inline macro to work around this.
What is the recommended solution?

@romen - just to confirm is this good to go in now?

@romen - just to confirm is this good to go in now?

Now it is! I had editorial changes to the commit message to do!
It is now rebased on latest 1.0.2-stable and sqaushed into a single commit.

Pushed to 1.0.2. Thanks!!

Hello! 👋
Just upgraded to openssl 1.0.2t that includes this change and noticed a change in a regression test. I work on a system that identifies trusted public keys by the SHA-512 hash of their DER encoding. We have some old EC keys that were generated with explicit parameters but were actually NID_secp521r1, and so fall under this change.
The unfortunate thing is that this change results in a different SHA-512 hash for these public keys.
Questions:

Is there a way to avoid this functionality when using d2i_PUBKEY_bio / ``PEM_read_bio_PUBKEY` to read public keys?
Is there a more stable identifier for EVP_PKEY's that I should think about using instead of SHA-512(DER)?

Thanks @matthauck for reporting this!
I have to look deeper into this and it could take some time. Do you have a public key pem file that shows this behavior to share?

@slontis and I discussed this briefly today.  We're wondering what exactly you are doing?
We came up with a couple of possibilities but they seemed a little obtuse.  We could have easily missed something however.

My guess is that in the original explicit parameters somehow the cofactor was set to zero and the change in behavior does not come from this PR but from the one that guesses the cofactor

In that case, my recommendation would be to either generate a new key pair or reencode the existing one, possibly using named_curve encoding or, if explicit parameters is a strong requirement, to reencode with the correct cofactor

This was the best that @slontis and I could come up with.  However, it is quite possible that we missed something significant.

Here is a sample of a test public key that parses differently on 1.0.2t.
-----BEGIN PUBLIC KEY-----
MIICRjCCAbkGByqGSM49AgEwggGsAgEBME0GByqGSM49AQECQgH/////////////
////////////////////////////////////////////////////////////////
/////////zCBiARCAf//////////////////////////////////////////////
///////////////////////////////////////8BEIAUZU+uWGOHJofkpohoLaF
QO6i2nJbmbMV87i0iZGO8QnhVhk5Uex+k3sWUsC9O7G/BzVz34g9LDTx70Uf1GtQ
PwAEgYUEAMaFjga3BATpzZ4+y2YjlbRCnGSBOQU/tSH4KK9ga009uqFLXnfv51ko
/h3BJ6L/qN4zSLPBhWpCm/l+fjHC5b1mARg5KWp4mjvABFyKX7QsfRvZmPVESVeb
RGgXr70XJz5mLJfucple9CZAxVC5AT+tB2E1PHCGonLCQIi+lHaf0WZQAkIB////
///////////////////////////////////////6UYaHg78vlmt/zAFI9wml0Du1
ybiJnEeuu2+3HpE4ZAkCAQEDgYYABACKnYs6ZaOCVqd1Cte0ttmeq11sSxmrBEz+
rWQKBMcNK/l4kUYYewncFAUZzmrGckeS2+QXbY0nxFZ9dxeEHShV+gCt0Ka+7LI+
z6DPF9bfojirUDnn7wkAZb8ETk7DE8BruXnAal7Bcp2gQaWb/a3BxQuk+YsZ2xBu
glcNKvdAvNaF9Q==
-----END PUBLIC KEY-----

Thanks @matthauck
So the issue is indeed due to this PR: matching with the builtin curves we also include the Seed field from the internal table in the external parameters.
I am trying to figure out a proper workaround. I am not sure if calling EC_GROUP_set_seed(group, NULL, 0) would have any benefit and I am on a very limited ssh terminal from the phone and far from a proper computer to test things out more efficiently.
@pauli @slontis ideas?

Any updates here? Should we accept this and trust that public key serialization will never change again? Or are you saying that this change actually broke something and you are planning to revert?

@matthauck I have a potential patch for your issue: 0001-ec_asn1.c-Avoid-injecting-seed-when-built-in-matches.patch.txt
But I'd like to ask @mattcaswell opinion about this kind of fix (both for 1.0.2 and for the other branches).
I see it as a regression introduced by a recent security fix, so in my view it should be added to 1.0.2, 1.1.0 (even if it will not be part of a release), 1.1.1 and master.
On the other hand, it seems a minor regression, and I am not even sure how this kind of PEM file was even created by openssl in the first place, because even in versions where "explicit parameters encoding" is the default I believe the seed parameter is not omitted on key generation (but I might easily be mistaken given the long history of the project).
No matter if this patch gets into released versions, @matthauck you could easily use this approach to write a sort of "filter" program that reads the PEM file, makes sure the seed parameter is omitted and then outputs the DER encoding you use for fingerprinting.

@mattcaswell @matthauck I opened PR #10140 to properly discuss this as its own issue, rather than on this closed PR.


Replace / in badge labels and values

Jekyll is currently failing on master for make annotate for badge creation. Indeed, if there is a \ in the tutorial title, it will be added in the path where to create the badge:
badges/cache/Annotating%20a%20protein%20list%20identified%20by%20LC--MS/MS%20experiments-Supported-green.svg: No such file or directory

Traceback (most recent call last):

  File "bin/add_galaxy_instance_badges.py", line 175, in <module>

    CACHE_DIR, (instance, topic, training), args.output

  File "bin/add_galaxy_instance_badges.py", line 77, in badge_it

    ), CACHE_DIR)

  File "bin/add_galaxy_instance_badges.py", line 65, in realise_badge

    subprocess.check_call(cmd)

  File "/home/travis/miniconda3/envs/galaxy_training_material/lib/python3.6/subprocess.py", line 291, in check_call

    raise CalledProcessError(retcode, cmd)

subprocess.CalledProcessError: Command '['wget', 'https://img.shields.io/badge/Annotating%20a%20protein%20list%20identified%20by%20LC--MS/MS%20experiments-Supported-green.svg', '--quiet', '-O', 'badges/cache/Annotating%20a%20protein%20list%20identified%20by%20LC--MS/MS%20experiments-Supported-green.svg']' returned non-zero exit status 1.

We have our 1st case for such title with #1354.
This PR should fix that by replacing the \ in the label of the badge.

Ah super weird, I should have expected someone would use a /. looks good to me.


Update testing.md

@m1kola PRs should be created from your fork

@nilsanderselde I did't notice I had permissions to create branches here. I was using GItHub UI. When there are no permissions - github creates a branch in a fork. I'll remove after merge.


Nox auto restart for farming biometrics

Which version of nox supports this feature?

It's a default warning message and has nothing to do with Nox version:
https://github.com/tmarenko/mff_auto/blob/master/lib/game/game.py#L403-L404
You should make Nox restartable via menu:

and then restart bot & emulator to apply changes.
You can try older Nox (<IP_ADDRESS>) if it didn't help.

Thanks, unfortunately nox <IP_ADDRESS> isn't working. Switch back to nox <IP_ADDRESS> and the bot works well right now. Thanks for your help.


899 add gamma distribution and other parameters to state_age_function

Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:

added the parameters location and scale to StateAgeFunction
added three state age functions
extended the boost archive of memilio (necessary for the state age functions)
added tests

Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author

[x] Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
[x] New code adheres to coding guidelines
[ ] No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
[x] Tests are added for new functionality and a local test run was successful
[x] Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
[x] Proper attention to licenses, especially no new third-party software with conflicting license has been added
[ ] (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

[ ] Corresponding issue(s) is/are linked and addressed
[ ] Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
[ ] Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
[ ] No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
[ ] On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #899.

Attention: this PR should be recreated without the new boost file in the history.

@lenaploetzke Could you recreate a fresh branch and push all your changes except the boost file to the new branch and also create a new PR?

@lenaploetzke Could you recreate a fresh branch and push all your changes except the boost file to the new branch and also create a new PR?

Yes, see comment above.

Moved to #1004


Re-implemented locking schemes for paths needing multiple locks

Primarily bi-modal requests (but also Rename) often require obtaining
multiple locks. As locking order may not always be easily deterministic,
avoiding deadlocks requires a "try-lock" approach. Many of these fs
APIs had unique implementations making it challenging to undertstand
interactions with other multi-locking APIs.
A key ingredient of several of these APIs was the fs.resolvePath() helper
func. This helper has now been significantly generalized to be useful
across the entire spectrum of fs APIs. Each of the "try-lock'ing" fs APIs
has also now been re-worked to leverage fs.resolvePath() as well.
Finally, a notable omission in fs.Rename() has been corrected. A code
review revealed that the target path of a Rename() that pre-exists
was not locked. Hence, if one has two files A and B... and Rename()'s
A to B, what happens is that the LinkCount on B's inode is decremented
without holding on to an Exclusive Lock at the time. Indeed, if the
LinkCount now drops to zero, code will be invoked to actually delete
the inode... all while a potentially 2nd thread of execution is
acting on it. The simplest example of conflict might be this 2nd thread
doing a Link() mapping C to B's inode... in the process incrementing
the LinkCount. These two LinkCount modifications are not atomic, hence
the resultant LinkCount could be correct, one too low, or one too high.
The new generalized fs.resolvePath() is now used to obtain all locks
during fs.Rename() to avoid this race condition.
A notable impact of this change involves the fs.MiddlewareGetContainer()
logic. Given the need to "flatten" the directory tree underneath a
Container (i.e. underneath a subdirectory of '/'), the necesssary
treewalk must descend into encountered subdirectories. The point at
which it does this is just after recording the existence of each
subdirectory. Hence, a subdirectory (of the selected Container) named
foo that contains a file named bar will be listed as:
foo
foo/bar

Now suppose there is a file named foo.suffix in the same Container
adjacent to the subdirectory foo. In this case, the treewalk
algorithm will encounter foo.suffix AFTER it has already descended
into subdirectory foo. Hence, the Container listing will be:
foo
foo/bar
foo.suffix

Note that '.' should sort BEFORE '/'. Indeed a non-bimodal Swift
Container having three Objects named "foo", "foo/bar", and "foo.suffix"
would instead be listed:
foo
foo.suffix
foo/bar

While it is somewhat feasible to avoid this deviation from sort order,
it is very problematic when considering the impact to the implementation
supporting prefix, marker, and endmarker (options available for a GET
on a Swift Container).
This change does not attempt to avoid this anomaly.

copying in a comment i posted on Slack ...
the question of "/" sort order is interesting.  there are only  a small number of characters that sort before "/" in ASCII, though "." and "," (comma) are the most problematic.  aside from that, there are 32 control characters (^A, ^B, ... etc.), the 15 printable characters are [ !#$%&' ()*+,-.] (space is the first character, also bang, sharp, dollar, percent, and, single quote, left and right parent, splat, plus, comma, dash, period).
as long as we are consistent about the sort order, then markers used for directory (container) traversal should work OK.  will this bug any clients?
i'm not sure there's a problem with prefix, other than the order of entries.  if the client says prefix="bar/foo" then they it gets everything in the container that starts with "foo" (with the sort order issue intact).  if the client says prefix="bar/foo/" then it gets everything under the directory "foo", but not "bar.suffix".
where does Unicode fit into this question?  are we sorting by byte values or Unicode code points?
curiously (actually, i'm sure it was by design), if two byte arrays represent two different unicode characters, a byte by byte comparison will always sort the arrays by code point order.

Awaiting a cleaner run thru Ci Swift/Swift3 functional tests before merging this in...


Extend lwip compatibility with sys sockets (IDFGH-2551)

Hi,
I found that some compatibility headers were missing, and some symbols could not be found in places where they are expected to be.
In particular, trying to compile newest version of azure-iot-sdk-c would fail (in AMQP module) with errors.

Header netinet/tcp.h was not found
symbol SOMAXCONN was not defined

wrapping lwip/tcp.h with netinet/tcp.h and including net/if.h in sys/socket.h solved those issues.

Hi @projectgus ,
I am closing the pull request as it has been merged already.
Thanks!


Fix podman login lying problem

podman login lied when it doesn't login successfully
$ podman logout -a docker.io
Removed login credentials for all registries
$ podman login docker.io
Authenticating with existing credentials...
Existing credentials are valid. Already logged in to docker.io
$ podman logout docker.io
Error: error logging out of "docker.io": error updating "/run/user/1000/containers/auth.json": not logged in

docker.CheckAuth doesn't return error if userFromAuthFile, passFromAuthFile are ""can lead to this always successful problem.
https://github.com/containers/libpod/blob/ae8cc41295c4ff6f6f82372221c66c250691e4f6/cmd/podman/login.go#L115
Signed-off-by: Qi Wang<EMAIL_ADDRESS>

LGTM
@TomSweeneyRedHat PTAL

Does this fix a logged issue?  I'm able to see this error against docker.io, but I'm not seeing the error when I login to a local registry:
# podman login --cert-dir /root/auth localhost:5000
Authenticating with existing credentials...
Existing credentials are invalid, please enter valid username and password
Username:

Still testing.

@TomSweeneyRedHat  there's no logged issue about this :eyes:

LGTM
FWIW, I figured out the discrepancy.   Apparently a value username/password combo for docker.io is ""/"".  That's not at all valid for a local registry unless you go through some hoops.  I'm not sure why they have theirs set up like that.  Anywho, the change cleans stuff up, nice catch/fix @QiWang19

/lgtm

/approve


[Bug]: FilePicker Widget data is not loaded after uploading

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Upload Works fine . But when when the file size is more than 5mb, data field is populated with string blob:d63fa3b8-a590-4185-b391-af9c95cfb9c6?type=Text

Steps To Reproduce

Upload the attached file 1 using FilePicker widget
On successful upload try to display the data on a text widget and see the data would be like - blob:
Repeat 1 & 2 for the file 2 and it works fine.

Environment
Production
Version
Cloud

generated.txt
generated_2.txt

Should we bypass this limit for text files? It will be a non breaking change.

But the issue will still be there for non text files right ?

But the issue will still be there for non text files right ?
Only use case for binary files is upload, and that is handled in the actions.

Hey! I am having this same problem. My scenario involves using the FilePicker widget with any set of files of any type, but with a size limit of 100 MB.
Any solution coming soon or would I be better off looking for workarounds?

@Michael-sr What are you doing with these files? Uploading them somewhere? or reading and processing on client?
If you are uploading, then it should work fine.

@Michael-sr What are you doing with these files? Uploading them somewhere? or reading and processing on client? If you are uploading, then it should work fine.

I am uploading files to the n8n webhook endpoint, but I receive file data that is less than 5MB in size. The rest come with the following data structure: {"data": "blob: ....}.

@Nikhil-Nandagopal , thanks for clarifying the situation!

@SatishGandham is this already working, Can we close the issue

@somangshu remember the issue we were discussing where base64 uploads of even 2MB were crashing the app when referenced in any other widget? Can this part of the same bug or do we create a new bug?

@dilippitchika Could you mention the issue you are referring to here?

Upload a file which is >2MB to the file picker and reference the filepicker.files to a text widget. If the file picker type is set to Base 64, it ends up crashing the whole app.

@AnaghHegde we don't allow file size more than 5mb in cloud. We will work on communicating this to appsmith developers in this issue.

@Tooluloope can you find out the problems listed above, take a note and start work on this

@somangshu

Upload a file which is >2MB to the file picker and reference the filepicker.files to a text widget. If the file picker type is set to Base 64, it ends up crashing the whole app.

Is this the only issue still hanging?

@Tooluloope I think as pointed above we can also check for what data is returned.

@dilippitchika https://www.loom.com/share/fa9a4b7a2aa1449c8f43aa56e1bf1dd7
Could you confirm if it crashes

The main issue seems fixed.
The other issue is continued here https://github.com/appsmithorg/appsmith/issues/10379


Error while insert item in MySql

Hello,
I have a problem when I try to get data from a MongodbMixin to insert in a MysqlMixin. I'm getting the error:
Error in pump (root): Error: ER_DUP_ENTRY: Duplicate entry<EMAIL_ADDRESS>for key 'UQ_Contat_contact_email'
Unhandled rejection PumpingFailedError: Pumping failed. See .errorBuffer() contents for error messages
I don't understanding the error message "Unhandled rejection PumpingFailedError: Pumping failed. See .errorBuffer() contents for error messages".
Can you help me?
Follow my code:
var
    mysql = require('mysql'),
    datapumps = require('datapumps'),
    Pump = datapumps.Pump,
    MongodbMixin = datapumps.mixin.MongodbMixin,
    MysqlMixin = datapumps.mixin.MysqlMixin,
    pump = new Pump();

var connection = mysql.createConnection({
    host: 'localhost',
    user: 'database',
    password: 'user',
    database: 'password'
})

pump
    .mixin(MongodbMixin('mongodb://localhost/database'))
    .useCollection('client')
    .from(pump.find({}))

    .mixin(MysqlMixin(connection))

    .process(function (client) {
        return this.query(`INSERT INTO contact \
            (contact_name,contact_email) VALUES (?)`,
            [client.name, client.contact.email]);
    })
    .logErrorsToConsole()
    .run()
    .then(function () {
        console.log("Done writing contacts to file");
    });

Hello @rafaneri
The error message just wants to say that the pump failed, and the error messages are available in pump.errorBuffer().getContents(). However, as .logErrorsToConsole() was called, error messages are also printed to the stdout. So in fact the only error is the mysql duplicate key error, which came from the mysql driver (seems like you have unique constraint in mysql but not in mongo).


[Loc] change to resource deployment

This PR fixes #

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 42.242%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
28174

Relevant Lines:
62331

💛  - Coveralls


Exclude emojis from embedded image rules

Hi Jarodise,
I have created an emoji plugin that is clashing with some themes that center images as I also use the <img> tag to customise the appearance of emojis. Do you mind considering this fix providing you require images to always be centered as part of your theme.
With Bug

Without Bug

Thanks for fixing this!


Fix cliConfig nil pointer

Issue #, if available:
Description of changes:
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/LGTM

/cherrypick release-0.11


add alert manager doc

cherry-picked from #1107 .
@YanjieGao please add links to this doc from https://github.com/Microsoft/pai/blob/master/pai-management/doc/how-to-write-pai-service-configuration.md

di, iIf convenient could refer the doc above format and directly add link at monitor part. This will make the pr more complete.
https://github.com/Microsoft/pai/blob/master/pai-management/doc/how-to-write-pai-service-configuration.md

Coverage decreased (-6.006%) to 45.889% when pulling 1feb11ce54400e9665c540e9d4675663bcc331f0 on dixu/alert-manager-doc into 36ec012c8396c1b6441182e894cb6743556e389a on master.

@YanjieGao added


Remove sandbox related code (Part II)

There is still a lot of sandbox related code in Core Data Editor...
startAccessingSecurityScopedResource:
et.al.

done


Avoid hardcoded host names and protocol

I've installed respond cms and it took quite a while and quite some struggling to do it. Mostly because I cannot install it using the "real" host/domain, secondly because I'm serving the site behind a reverse proxy (on another port than port 80) and third since we serve content over https.
I think Respond cms looks promising, but the setup is based on a few not well thought-through things:

When creating a product, you should never generate absolute URL:s with host/domain and protocol.  Will also allow you users to serve the site using any port number.
Never, ever link to external CDN items using "http". Instead use https or more preferrably on the format "//your.cdn.com/resource.css". This approach will allow the browser to use http or https depending on the current protocol. Using "http://" if the site is using https will be prevented by most browsers.

Thanks for the comments. We have merged pull request #409 into dev branch for replacing 'http and https' with // for resources. Assume comment 2 it is resolved.
We should mark this as a bug as it prevent the application working when port is supplied in URL.

Closing issues not related to R6.


Different parsing behaviour between prepared and unprepared queries

What type of bug is this?
Incorrect result
What subsystems are affected?
Query Engine
Minimal reproduce step
use sqlx::mysql::MySqlPoolOptions;
use sqlx::Executor;

let conn = MySqlPoolOptions::new()
    .connect("mysql://localhost:4002/public")
    .await
    .unwrap();

conn.execute("CREATE TABLE t (ts timestamp time index);")
    .await
    .unwrap();

let insert_expr = "INSERT INTO t VALUES ('-202168-11-16 18:40:39.918853+0000');";

// unprepared query, passed
let res = conn.execute(insert_expr).await.unwrap();
assert_eq!(res.rows_affected(), 1);

// prepared query, failed
let res = sqlx::query(insert_expr).execute(&conn).await;
assert!(res.is_err());

conn.execute("DROP TABLE t;").await.unwrap();
conn.close().await;

What did you expect to see?
insert successfully for both
What did you see instead?
the unprepared one succeeded but the prepared one failed
What operating system did you use?
Ubuntu 22.04
What version of GreptimeDB did you use?
0.7.0
Relevant log output and stack trace
2024-03-13T08:16:48.536464Z ERROR servers::mysql::writer: Failed to handle mysql query err=0: Failed to execute plan, at /home/zhongzc/work/rust/greptimedb-0/src/servers/src/query_handler/sql.rs:99:14
1: Failed to execute logical plan, at src/frontend/src/instance.rs:346:14
2: Failed to create RecordBatch, at src/query/src/datafusion.rs:132:31
3: , at src/common/recordbatch/src/adapter.rs:250:55
4: ArrowError(ParseError("Error parsing timestamp from '-202168-11-16 18:40:39.918853+0000': error parsing date"))

The root cause is that "prepare execute" uses DataFusion to convert SQL value while direct insert uses our logic. We should unify these two paths.


Vault-env is injecting secrets from two different calls to the same dynamic credentials endpoint

Describe the bug:
When injecting secrets from dynamic credential endpoints into pods via environment variables, it looks like vault-env is calling the endpoint twice (generating two different sets of dynamic credentials) and setting variables from different calls, resulting in mismatched credentials. For example, if I have the following:
        env:
        - name: DB_USERNAME
          value: "vault:database/creds/demo#username"
        - name: DB_PASSWORD
          value: "vault:database/creds/demo#password"

Then the DB_USERNAME will be set to the username field of one call to the database/creds/demo endpoint, and DB_PASSWORD will be set to the password field of a second call to the same endpoint. Trying to authenticate to a database using that combination of username and password will fail. It also fails if I copy/paste the credentials and try to connect directly to the database.
I can't reproduce this behavior on vault-secrets-webhook/vault-env 1.4.2, so it must've been introduced in 1.5.0.
Expected behaviour:
That vault-env will use secret caching as mentioned in the documentation, so the secrets being injected from a dynamic endpoint will match one another.
Steps to reproduce the bug:
Assuming you have an environment with a database, Vault correctly configured to generate credentials for that database, and vault-secrets-webhook running version 1.5.0, you can do a test deployment that prints out the environment variables, and/or tries to connect to the database. Something like:
apiVersion: v1
kind: ServiceAccount
metadata:
  name: demo
  namespace: demo

---

apiVersion: apps/v1
kind: Deployment
metadata:
  name: demo
  namespace: demo
spec:
  selector:
    matchLabels:
      app: demo
  template:
    metadata:
      labels:
        app: demo
      annotations:
        vault.security.banzaicloud.io/vault-addr: https://vault.vault:8200
        vault.security.banzaicloud.io/vault-tls-secret: vault-tls
        vault.security.banzaicloud.io/vault-env-daemon: "true"
    spec:
      serviceAccountName: demo
      containers:
      - name: demo
        image: alpine:3.10.3
        command:
        - "sh"
        - "-c"
        - "apk add curl jq mysql-client; \
            while true; do \
            echo $DB_USERNAME; \
            echo $DB_USERNAME_TWO; \
            echo $DB_PASSWORD; \
            mysql -hmysql.mysql -u${DB_USERNAME} -P3306 -p${DB_PASSWORD} -e 'show databases;'; \
            sleep 15; \
          done"
        env:
        - name: DB_USERNAME
          value: "vault:database/creds/demo#username"
        - name: DB_USERNAME_TWO
          value: "vault:database/creds/demo#username"
        - name: DB_PASSWORD
          value: "vault:database/creds/demo#password"

Notice that I'm injecting a second username environment variable called DB_USERNAME_TWO and printing it out. The mysql connection will fail, and the values printed for DB_USERNAME and DB_USERNAME_TWO will be different, suggesting that the endpoint is invoked twice.
By contrast, if I downgrade vault-secrets-webhook/vault-env to 1.4.2 and I restart this application, the mysql connection now succeeds, and the printed values for DB_USERNAME and DB_USERNAME_TWO are now the same.
Environment details:

Kubernetes 1.18
Vault 1.5.0 (deployed with vault-operator 1.5.0)
Vault-secrets-webhook/vault-env 1.5.0, installed with Helm

/kind bug

The issue is totally valid, yes I checked the changes since 1.4.2 and yes, it was introduced in 1.5.0. I'm trying to write a test for this help to avoid this issue getting introduced again.


Anaconda.Anaconda3 version 2023.03-1

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/109436&drop=dogfoodAlpha

There is version 2023.03-0 and 2023.03-1. the version 2023.03-0 has a non-numeric version number. I mentioned that on this: https://github.com/ContinuumIO/anaconda-issues/issues/13161. This pull request will sove the issue at #108663

wingtcreate changed architecture type. I will update it with YamlCreate.ps1

@wingetbot run


[iOS] Firebase headers error when building project

Hi, I'm installed react-native-fcm, like described in README, (npm install, rnpm link, created pod file and runned pod install)
Pods installed fine, my Podfile contains:
# Uncomment this line to define a global platform for your project
# platform :ios, '6.0'
pod 'Firebase'
pod 'Firebase/Core'
pod 'Firebase/Analytics'
pod 'Firebase/Messaging'

target 'MyApp' do
end

target 'MyAppTests' do
end

I'm using .xcworkspace file to open the project, but I get this error:
/Users/me/Projects/MyApp/ios/Pods/Firebase/Headers/Firebase.h:1:9: 'FirebaseAnalytics/FirebaseAnalytics.h' file not found and cannot build my project.
$(inherited) added to Header Search Path and to Other Linker Flags
Any suggestions?

is your pod folder under ios folder?

Directory Pods and Podfile are in MyApp/ios directory

I removed all pods data from my project  and made this steps for install:

Create Podsfile with content described in first comment
Run pod install (my pod version is 0.37.2), no errors was here only

dyld: warning, LC_RPATH @executable_path/../../../../../../../SharedFrameworks in /Applications/Xcode.app/Contents/SharedFrameworks/DVTFoundation.framework/Versions/A/../../..//DVTInstrumentsFoundation.framework/Versions/A/DVTInstrumentsFoundation being ignored in restricted program because of @executable_path

Open xcworkspace instead of xcodeproj
Add RNFIRMessaging.xcodeproj to my project
Add #import "RNFIRMessaging.h" and

- (void)application:(UIApplication *)application didReceiveRemoteNotification:(NSDictionary *)notification fetchCompletionHandler:(void (^)(UIBackgroundFetchResult))handler {
  [[NSNotificationCenter defaultCenter] postNotificationName:FCMNotificationReceived object:self userInfo:notification];
  handler(UIBackgroundFetchResultNoData);
}

to AppDelegate.m
6) Add libRNFIRMessaging.a to Link binary with libraries (libPods.a was there)
7) Run project, but got the same errors like in first comment
FirebaseAnalytics/FirebaseAnalytics.h not found, but FirebaseAnalytics listed in Pods group

FCM doesn't import FirebaseAnalytics.h. The error looks like is thrown by the pod project itself.
my pod file looks simpler, can you try this?
pod 'Firebase/Messaging'

I removed all pods data, create Podfile with pod init, add to generated Podfile
pod 'Firebase/Messaging'
and still having
MyApp/node_modules/react-native-fcm/ios/RNFIRMessaging.h:4:9: Could not build module 'Firebase'```
Firebase Analytics goes with in firebase module by default.
Now, my Pods group looks like:
![2016-06-19 23 58 37](https://cloud.githubusercontent.com/assets/781366/16179805/ed5f2302-3679-11e6-8627-e383ae14f5f0.png)

Podfile:
![2016-06-20 0 00 59](https://cloud.githubusercontent.com/assets/781366/16179812/1bf73a06-367a-11e6-8534-204c652eb56f.png)
The error screenshot:
![2016-06-20 0 01 45](https://cloud.githubusercontent.com/assets/781366/16179821/734c80c2-367a-11e6-84da-916470b47e43.png)

I think, the problem may be in headers search path or in some pods settings. Tomorrow will try to update pod CLI and try again

awesome! readme updated. There shouldn't be any changes to $(inherited) manually though.

Interesting, this did not work for me.  The only way i could get it to build was to change "Allow Non-Modular includes in Framework Modules" on the node_module itself.

This is obviously not correct as it will get overwritten if i reinstall the node module.

I'm getting the same error.  Perhaps this has been resolved but I had to use @tarr11 fix but my build server is going to nuke this without special configuration.

This is the fix:
https://github.com/evollu/react-native-fcm/issues/143#issuecomment-252178914

Thanks for the reference.  It did work.  Thank you!
On Wed, Oct 12, 2016 at 8:03 AM Douglas Tarr<EMAIL_ADDRESS>wrote:

This is the fix:
#143 (comment)
https://github.com/evollu/react-native-fcm/issues/143#issuecomment-252178914
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/evollu/react-native-fcm/issues/17#issuecomment-253239817,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARl5OZASr486FzRlLyR_7ycANcQyVwyRks5qzPbLgaJpZM4I4ijJ
.

--
*michael gilmore jr. *director of production
(714) 222-2119 <%28714%29%20609-1799>
www.medlmobile.com
Hello future!
http://www.facebook.com/medlmobile
http://www.facebook.com/medlmobile http://www.twitter.com/medlmobile
http://www.youtube.com/shinymedlobjects
http://pinterest.com/medlmobilenow http://instagram.com/medlmobile
http://www.medlmobile.com/blog
http://www.facebook.com/medlmobile
Confidentiality Notice: The information contained in this electronic e-mail
and any accompanying attachment(s) is intended only for the use of the
intended recipient and may be confidential and/or privileged. If any reader
of this communication is not the intended recipient, unauthorized use,
disclosure or copying is strictly prohibited, and may be unlawful. If you
have received this communication in error, please immediately notify the
sender by return e-mail, and delete the original message and all copies
from your system. Thank you.

FYI. I received also hundreds of errors for FirebaseAnalytics file missing. git add . resolved this for me.

Yay pods! They conveniently make you have to do more work!!!


Updated the Underscore.JS

Updated the URL. This fixes issue #155... :)

Thanks @djhvscf! :smile:


InspectIt Ocelot Agent has a huge JVM impact.

I compare InspectIt Ocelot other APM solutions and InspectIT Ocelot Agent has the most impact on the Heap. While testing an embedded Tomcat Application for 2 hours, Elastic APM record around 170mb of the heap used and 270mb committed memory. Pinpoint APM recorded similar results. Ocelot recorded 450mb of the heap used and 620mb of committed memory. I use the Version 1.0 with Zipkin and Prometheus.

Hi @Maxpur12,
Thanks for your insights!
We would be very interested in more details.
Would you be willing to share mor edetails on your measurements, so we can better understand what causes the huge memory overhead?
Thanks!

My test application is the SpringBoot Petclinic with an embedded Tomcat and an embedded database with  OpenJDK11 on a CentOS7 system. I create load with JMeter on a seperate system. Prometheus an Zipkin are on another system. For JMeter I use a predefined test plan from SpringBoot. It starts 100 threads within 10 seconds. Before I start any tests, i reboot the system. First I tested with the agent version 0.5. The heap remains relatively constant at under 200 MB for about 1 hour. After one hour the memory increases very strongly and with peaks up to 700 MB.

With the agent version 1.0 this behaviour can be reconstructed. Here, too, the memory remains at 200 MB at the beginning, but increases strongly after one hour with peaks up to 700 MB.

With Elastic APM or Pinpoint I have never reached these values. Of course I do not use the APM agents at the same time.

Hi @Maxpur12
thanks for your feedback.
Just to make sure I got this right:

You use the ocelot configuration files which are included in the demo, right? Are you using a configuration server for delivering the configuration to the agent?
As demo application you use SpringBoot's Petclinic. Are you using the (distributed) inspectIT Ocelot demo version of it, or the "normal", monolithic one provided by Spring?
Can you also share your JMeter test (or a link to it) so we can analyse this behavior?
How do you add the agent to your demo system?

All the best,
Marius

I use the config server to deliver the configuration of the demo to the agent, but i think thats not the problem because yesterday I started a 12 hour test without any configuration and i have the same result.

I build Petclinic from Source as JAR and started it with
java -javaagent:"../../inspectit-ocelot-agent-1.0.jar" -Dinspectit.config.http.url=http://<configserver_ip>:8090/api/v1/agent/configuration -Dinspectit.exporters.tracing.zipkin.url=http://<zipkin_ip>:9411/api/v2/spans -Dinspectit.exporters.tracing.zipkin.service-name=PetClinic -jar spring-petclinic-2.2.0.BUILD-SNAPSHOT.jar
Here is the testfile and the aggregation report:
petclinic_jmeter.zip

And here is my petclinic .JAR
https://mega.nz/#!TUBXVY6T!jJgozIXKp2AowHd1igLlPGEA0dXmInP2uy0HtR08KpU

@Maxpur12 Thanks a lot for sharing the details!
We will try to reproduce and analyze this behaviour.
One last question: Are you using just the default configuration for the agent, or do you have additional custom configuration files in the config server? If yes, could also provide the custom configuration?
Thanks!

I have no custom configuration.

I experimented a bit with Grafana and found out that the agent also captures the heap in more detail. The OldGen of the heap is increasing significantly. Apparently, objects (possibly from the agent) are not sorted out by the garbage collector.

Hey @Maxpur12 ,
Thank you for your effort and the details you have provided to us!
I have tried to recreate the bug with openJDK 11, 11.0.1  and 11.0.2, the jar you provided us as well as your JMeter test and our default agent configuration. Unfortunatly i was not able to recreate the bug with each test for the mentioned java versions running for more than 3 hours.
However, we are still interested in why this behaviour occurs. Would you like to share some more details about your setup? Maybe which exact openjdk version you used and if you only used this openjdk for compiling or also for running the jars? Does this behaviour occur every single test run or just from time to time? Each hint would be hepful!
Cheers and thanks for your efforts,
Marius

openjdk version "11.0.5" 2019-10-15 LTS
OpenJDK Runtime Environment 18.9 (build 11.0.5+10-LTS)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.5+10-LTS, mixed mode, sharing)
VMWare Virtualisation
CentOS Linux release 7.7.1908 (Core)
2 vCPU Intel(R) Xeon(R) CPU E5-2680 0 @ 2.70GHz
4 GB Ram

I'm not shure on which system i compiled the jar. It could be on the same machine or a Windows 10 with AdoptOpenJDK 11.
openjdk version "11.0.4" 2019-07-16
OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.4+11)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.4+11, mixed mode)

This behavior happens every time after about 1 hour.

I tested "Petclinic" again with "openjdk version 11.0.1 2018-10-16
OpenJDK Runtime Environment 18.9 (build 11.0.1+13)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.1+13, mixed mode)"
And again, the heap rises after one hour.

Hi @Maxpur12
we've reproduce your problem and currently analysing the data.
We have a suspicion on what might be causing the problem, but would like to verify this one more time.

Hey @Maxpur12
First of all, please excuse us for letting you wait so long. As my colleague @mariusoe already told you we have been able to reproduce the error, which took us quite some time. The key issue for us to reproduce the error was the amount of cores on which the whole setup ran.
A small look at the heap dump we took during the runtime of the application made us suspect Finalizer class for causing this memory problem:

As you see, the finalizer class took 232,6mb of 291,1mb (about 80%) of the heap space. So we dug deeper into that. We found out that the finalizer that eats up so much space references to an object from the OpenCensus library.

Upon a closer look at the OpenCensus source code, we found that OpenCensus uses an overwritten finalize method in the RecordEventSpanImpl class you see in the screenshot above. This method uses a synchronize block, which causes this method to need a good amout of computing time to finish. This results in the garbage collector of the JVM to need more time than it actually gets to collect the object during the garbage colelction and therefore, the garbage collection cannot finish. This is why the used heap remains on a higher baseline after the peak in your screenshot.
This is apparently is only a problem on systems with fewer cores, thus we needed to reduce the number of cores the project runs on to 2.
The good news is, that we have been able to build a test version of our agent, in which we have fixed that very problem.
So the bug will be fixed in the next release of our agent!
So thank you again for your help and all the information you have provided to us!
If you have any more questions, please feel free to ask!
Greetings
Marius

Does version 1.2.1 really solve the memory leak problem already? I did several test runs with the same setup yesterday and I see that the problem is still not solved.

It should have solved it, if the issue was related to the finalizer we removed.
With the Span-finalizer included we were able to reproduce your issue, while it on our side disappeared after removing it.
Could you maybe generate a JVM Heap Dump in the phase were the old gen starts ramping up and provide it to us? This should help us locate the issue, as we so far are not able to reproduce it anymore.

I created the Heap Dump with jcmd.
https://mega.nz/file/Td5nUYJY#Kai0RLw7nA3Oy38_tH9zaIb8dsvDK_OScz1CcdKXAnc

Okay, thats strange now. I did another test run, but i did not reboot the system. I restarted the application only and now,  i dont have the memory leak after 1 hour. I'll run the test longer and see what happens.

I took a closer look at your most recent screenshot: The actual memory leak also is fixed there:
In your pre 1.2.1 screenshots, after the ramp up the old gen stayed at a higher level (200mb).
This was caused by the finalizer, as explained by @mbrill-nt .
In your most recent screenshot, the old gen increases until a Major-GC occurs.
Then however, the old gen is back to the normal Level (<100mb).
The ramp up of the old gen and the resulting increase in committed memory seems to be normal behaviour. Basically with only 2 CPU cores, the application is under heavy load. The G1 GC does it's best to keep up the collection throughput with it's default settings, but apparently can't keep up.
When the old gen starts growing, the tipping point for the G1 GC is reached: it decides to increase the committed memory in order to improve it's throughput. More committed memory means less frequent garbage collection, which results in a better throughput for the GC.
There is a certain allocation rate the application has to reach for this tipping over to occur. In our experiments, this also happened with other APM agent we tried out (see the last post of @mbrill-nt ).
In order to find out how much inspectIT Ocelot increases the allocation rate I built a dashboard for visualizing the allocation rate.
You can use this dashboard to analyze the memory allocation rate of the application.
I played around with various Ocelot settings (disabling all rules regarding tracing and metrics) and the allocation rate did barely change. If this finding is correct, it means that Ocelot should have a rather low memory allocation rate overhead.
I would suggest you to use this dashboard and selectively enable / disable the features of inspectIT Ocelot while monitoring the allocation rate. For example this configuration file will disable all instrumentation performed by inspectIT normally. These instrumentations capture HTTP metrics as well as the metrics required for the service graph. In addition you can remove all files provided with the docker-demo from your configuration server, as these enable tracing.

I also took a look at your heap-dump:
JCMD triggers a major GC before doing the dump. Your dump therefore only has a total size of about 50mb, indicating that there is no memory leak. There are also no contents taking up a large amount of space belonging to inspectIT Ocelot or OpenCensus anymore.

I started a testrun after rebooting the system and now i dont have any memory leak. Maybe it was just a read-out error. I will start another test over night and if there are no problems, you can close the thread.

Hi @Maxpur12 , anything new here? Or can I close this issue?


Improve data augmentation with shifted images

Here is a great example: https://chatbotslife.com/using-augmentation-to-mimic-human-driving-496b569760a9#.b6jyrypqu

I don't know if this improves things, or if this augmentation is quite right, but you can do a lot of it with one call:
         X_train, X_validation, y_train, y_validation = train_test_split(X, Y, test_size=0.20, random_state=42)
         datagen = ImageDataGenerator(
            rotation_range=1,
                width_shift_range=0.2,
                height_shift_range=0.2,
                shear_range=0.2,
                zoom_range=0.02,
                horizontal_flip=False)

         # compute quantities required for featurewise normalization
         # (std, mean, and principal components if ZCA whitening is applied)
         datagen.fit(X_train)

         # fits the model on batches with real-time data augmentation:
         m.fit_generator(datagen.flow(X_train, y_train, batch_size=32, shuffle=True),
                samples_per_epoch=len(X_train)*3, nb_epoch=20,callbacks=callbacks_list,
                validation_data=(X_validation, y_validation)
                )

Parts of that will work. We'll want to validate on non-augmented data.

That snippet does validate on non-augmented data. (I believe)

You're right @alanswx but it doesn't switch the steering angles when you flip the image horizontally.

that is why i turned off the flipping code -- once i get my car driving i will check in a class that does all the augmentation

I've moved the augmentation code to the donkeybarn repo. https://github.com/autorope/donkeybarn/blob/master/donkeybarn/cv/augment.py


load_external_modules works not as a global-only option

Describe the bug
Docs state that load_external_modules is a global-only option:
plugins:
  - mkdocstrings:
      handlers:
        python:
          load_external_modules: true

In fact, it makes effect only when used inside options key:
plugins:
  - mkdocstrings:
      handlers:
        python:
          options:
            load_external_modules: true

System (please complete the following information):

mkdocstrings-python version: 1.2.0
Python version: 3.11.3
OS: Arch Linux

Thanks for the report, and good catch! Will fix asap


SQLite connect to memory database

Investigate: https://github.com/sfu-db/connector-x/discussions/171

https://github.com/sfu-db/connector-x/discussions/171#discussioncomment-1803025


Add Bluetooth Support for iOS, extend support for Android

Greetings @gordol
With this update, I've been able to add Bluetooth printing support for iOS.  On both platforms, in order for a printer to show up in the lists returned by findBluetoothPrinters and findPrinters, the printer must first be paired.  On iOS this spawns a modal window that we don't really have control over, or the ability to interact with. Unfortunately, this means we can't guarantee a meaningful callback for a user cancelling the pairing process.  As such, I've added a new method called pairBluetoothPrinters to help facilitate this.
On Android pairBluetoothPrinters just opens the Bluetooth Settings area, on iOS it spawns the aforementioned modal.  The callback returns immediately and doesn't reflect any selection, pairing result, or cancellation.
As an aside, I've been thinking about adding a function that can be registered to get informed about Bluetooth Accessory connections.  (Perhaps one for disconnections too), but I haven't needed it for now.
I've also taken the opportunity to add failure callbacks for most of the printing methods.  I figure this will make it more consistent and easier to chain off of when it comes to failures as well as successes.
I have created an Error system that allows for an Error namespace, code, and message.  I haven't really finalized any of these things, and perhaps it's something we can agree on before forcing it.
I have adjusted the Readme accordingly, and cleaned it up a little bit as well.  I added a TODO section and put two things in it at the moment.  I added the USB into the TODO because I'm not really familiar with it, and I know it's kind of hard-coded for your situation at the moment.  However, it should probably be configured to allow for others to be able to use it with other printers as well.
Likely one of the next things I'll be working on is a way to select the device's printing paper type.
Please let me know if you have any questions,
Thanks,
~ Ayiga

Thanks, I'll review this soon... I'll try to get to it this week; I need to dust off, and charge my old iPad and update Xcode probably.

I added the USB into the TODO because I'm not really familiar with it, and I know it's kind of hard-coded for your situation at the moment.

The only thing that's hard-coded is the model configuration... We should be able to make that configurable, I think.

Please hold off on any potential merge. I have a crash on iOS right now.

for sure... no worries. i haven't even tested yet :)

Okay I was able to fix the issue and able to print on iOS again... I had a hell of a time chasing this down, all because I changed the name of a variable :.

good to hear. i have my ipad charged, but i need to get my xcode environment sorted out... my ipad is running ios9 too. do you know if this is only compatible with specific IOS versions?
anyway... looks good. i skimmed the IOS bits... need to brush up on my objc a little, but it looks okay from a high level. proper use of background threads and what-not. however, should pairBluetoothPrinters run in the foreground?

I was playing with the Background thread stuff yesterday.  Honestly, findNetPrinters on iOS doesn't work unless it's on a foreground thread.
pairBluetoothPrinters just spawns a modal, so it's not actually long running.
findBluetoothPrinters just returns the current list of paired printers on both platforms, so that's not long running either.  However, it could be made to run on a background thread on iOS without any issue.
The other thing that is able to run in a background thread is printViaSDK on iOS.  Running that in a background thread causes no issues.  Although the print operation itself is running in an NSOperationQueue that is using the main thread.  That could be tested to see if it has to be in the main queue or not.  But, as of now I haven't quite tested that portion.

Good to know, thanks!


Document HTTP endpoints in query and collector services

We don't really define our API anywhere, and we should do so. This is probably a good issue to bring up the idea of using swagger for self-documentation.

[ ] update documentation in deployment.md

Do you have any preference for the framework? What is the most used/mature one in Go?
I found this https://github.com/go-swagger/go-swagger

When you say framework, it implies not just documenting but refactoring the endpoints to use that framework so that documentation and code are in sync. I'd agree swagger is the way to go. However, we first need to investigate how it will work with graphql, because we certainly need graphql to streamline interactions with UI. I don't know if graphql frameworks also help with auto documenting the API.

Related discussion https://groups.google.com/forum/#!topic/jaeger-tracing/L27aTD9kXRc

Duplicate of #456


Fix the failed revert.

Before we merge, read this including the suggestion for homework at the end.
I started from the HEAD at 129ad55f, merge of PR 167 and revert 5 commits, including two merge commits, to get back to the head after the merge of PR 165 (SHA 5c530a99) .  The commands were
git revert -m 2 129ad55fb56012ef6cc63ac267721f5c3297b305
git revert      21372f90975d187462190eb3b3b06eb4f3c4a5dd
git revert -m 2 2ac3d7a07bdd51db6d40b516c4e73e016246f152
git revert      969b751fc12837eabb4e8558abc1cbd72a083ed9
git revert      b575741faf97d6bdf3af2f4d3c3b7ee5c84cb7c4

Following this I did:
git diff 5c530a99
Which gave an exact match.
I did a trial merge which I think did the right thing but I am not 100% sure.
Suggestion for Dave;

clone the head of Mu2e/REve
merge in this PR
merge in your PR
Let us know if it is correct.

If all goes we merge this and you reopen your PR (or make a new one).

On my first attempt I put the -m 2 after the SHA, not before.  I tried it both ways and it gives the same result.


chore: Show OHIs in infrastructure category

Adding keywords so OHIs show up in "infrastructure" category
Change title of MSSQL to match name in docs https://docs.newrelic.com/docs/infrastructure/host-integrations/get-started/introduction-host-integrations/

Summary
This docs page links to I/O with the infrastructure category selected, but many OHIs weren't showing up (or in the case of MSSQL, the title didn't match the expected OHI name.
This commit adds the infrastructure keyword to existing keyword lists, and adds keyword lists to quickstarts that were missing them. It also changes the title of MSSQL.

Pre merge checklist

[ ] Did you check you NRQL syntax? - Does it work?
[ ] Did you check your dashboard image quality? -  Do they look good?
[ ] Did you check that your alerts actually work?
[ ] Did you include an InstallPlan and Documentation reference?
[ ] Did you check your descriptive content for voice, tone, spelling and grammar errors?
[ ] Did you attach images of your dashboards to the PR so we can see them working?

Screenshots
Attach images of any visual changes, such as a dashboard here.

Changed to use conventional commit standards in #678


The request failed.Host name does not match the certificate subject provided by the peer

String url = "https://<IP_ADDRESS>/EWS/Exchange.asmx";
String account = "*****@**.com";//
String password = "****";//
ExchangeCredentials credentials = new WebCredentials(account, password);
ExchangeService service = new ExchangeService(ExchangeVersion.Exchange2010_SP2);
service.setCredentials(credentials);
service.setTraceEnabled(true);
service.setUrl(new URI(url));//
service.setPreAuthenticate(true);
service.setTimeout(10*60*1000);

the result:
com.wafersystems.exchange.core.exception.service.remote.ServiceRequestException: The request failed. The request failed. Host name '<IP_ADDRESS>' does not match the certificate subject provided by the peer (CN=exchange)
    at com.wafersystems.exchange.core.request.SimpleServiceRequestBase.internalExecute(SimpleServiceRequestBase.java:74)
    at com.wafersystems.exchange.core.request.MultiResponseServiceRequest.execute(MultiResponseServiceRequest.java:158)
    at com.wafersystems.exchange.core.ExchangeService.findItems(ExchangeService.java:981)
    at com.wafersystems.exchange.core.ExchangeService.findItems(ExchangeService.java:1025)
    at com.wafersystems.exchange.core.ExchangeService.findItems(ExchangeService.java:1100)
    at com.wafersystems.ExchangeAPI.main(ExchangeAPI.java:53)
Caused by: com.wafersystems.exchange.core.exception.service.remote.ServiceRequestException: The request failed. Host name '<IP_ADDRESS>' does not match the certificate subject provided by the peer (CN=exchange)
    at com.wafersystems.exchange.core.request.ServiceRequestBase.getEwsHttpWebResponse(ServiceRequestBase.java:729)
    at com.wafersystems.exchange.core.request.ServiceRequestBase.validateAndEmitRequest(ServiceRequestBase.java:639)
    at com.wafersystems.exchange.core.request.SimpleServiceRequestBase.internalExecute(SimpleServiceRequestBase.java:62)
    ... 5 more
Caused by: javax.net.ssl.SSLPeerUnverifiedException: Host name '<IP_ADDRESS>' does not match the certificate subject provided by the peer (CN=exchange)
    at org.apache.http.conn.ssl.SSLConnectionSocketFactory.verifyHostname(SSLConnectionSocketFactory.java:465)
    at org.apache.http.conn.ssl.SSLConnectionSocketFactory.createLayeredSocket(SSLConnectionSocketFactory.java:395)
    at org.apache.http.conn.ssl.SSLConnectionSocketFactory.connectSocket(SSLConnectionSocketFactory.java:353)
    at org.apache.http.impl.conn.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:134)
    at org.apache.http.impl.conn.BasicHttpClientConnectionManager.connect(BasicHttpClientConnectionManager.java:338)
    at org.apache.http.impl.execchain.MainClientExec.establishRoute(MainClientExec.java:380)
    at org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:236)
    at org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:184)
    at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:88)
    at org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:110)
    at org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:184)
    at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:82)
    at com.wafersystems.exchange.core.request.HttpClientWebRequest.executeRequest(HttpClientWebRequest.java:292)
    at com.wafersystems.exchange.core.request.ServiceRequestBase.getEwsHttpWebResponse(ServiceRequestBase.java:720)
    ... 7 more

some notes found on the net: stackoverflow

I  have downloaded separately:

Apache Commons HttpClient 4.5 (httpclient-4.5.jar)
Apache Commons HttpCore 4.4.1 (httpcore-4.4.1.jar)
Apache Commons lang3     3.4 (commons-lang3-3.4.jar)
Apache Commons Codec 1.10 (commons-codec-1.10.jar)
Apache Commons Logging 1.2 (commons-logging-1.2.jar)
Joda Time  2.8(joda-time-2.8.jar)

but it found the same error , why?

Maybe try using your own hostname verifier. Can be seen on the wiki

Is this problem solved?


Error while updating the custom role using az cli

Getting the below error while updating the custom role using az cli 2.0.57
"Please provide the unique logic name of an existing role"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: eac44e5e-65e1-d989-4afe-0463e8ff51d0
Version Independent ID: 5665dd03-d06e-ca29-668f-7cb91e5f9ffd
Content: Custom roles for Azure resources
Content Source: articles/role-based-access-control/custom-roles.md
Service: role-based-access-control
GitHub Login: @rolyon
Microsoft Alias: rolyon

the trouble happens when you add 2 or more scopes,

It seems that this might be a bug with the Azure CLI but I'm not certain. https://github.com/Azure/azure-cli/issues/6304
Can you try deleting and recreating the definition?
@rloutlaw and @yugangw-msft , did the bug ever get resolved?

@way2arun I confirmed with the product team and they are still working to fix this bug.

Hi @way2arun ,
Thanks for reporting this and apologies for the inconvenience. This bug will be addressed in the upcoming month.

@MarileeTurscak-MSFT
if we delete the custom role, which are already in use, will interrupt the services, work around cannot be applied in this case. please keep us posted, hope the fix will be released in the next az cli version

upgraded to 2.0.60, now getting new error - WARNING: Role "id" is missing. Look for the role in the current subscription...


Ubuntu build fails

Describe the bug
I had to do a little bit of hunting to find the relevant dependencies - however after getting cmake to recognize that the dependencies where there, I still got this error at 64% build completion
To Reproduce
Steps to reproduce the behavior:
Follow build instructions on a Ubuntu 18 machine provisioned via AWS.
Expected behavior
Was hoping it would build properly.
[ 64%] Building CXX object Projects/CoX/Common/Messages/Map/CMakeFiles/MapServer                               _interface.dir/MapServerEvents.gen.cpp.o
In file included from /home/ubuntu/Segs/bld/Projects/CoX/Common/Messages/Map/Map                               ServerEvents.gen.cpp:2:0:
/home/ubuntu/Segs/Projects/CoX/Common/Messages/Map/MapXferWait.h: In member func                               tion ‘virtual void SEGSEvents::MapXferWait::serializeto(BitStream&) const’:
/home/ubuntu/Segs/Projects/CoX/Common/Messages/Map/MapXferWait.h:30:9: error: in                               valid use of incomplete type ‘class BitStream’
bs.StorePackedBits(1, 10);  // opcode
^~
In file included from /home/ubuntu/Segs/Projects/CoX/Common/Messages/Map/MapXfer                               Wait.h:9:0,
from /home/ubuntu/Segs/bld/Projects/CoX/Common/Messages/Map/Map                               ServerEvents.gen.cpp:2:
/home/ubuntu/Segs/Projects/CoX/Common/Messages/Map/GameCommand.h:13:7: note: for                               ward declaration of ‘class BitStream’
class BitStream;
^~~~~~~~~
In file included from /home/ubuntu/Segs/bld/Projects/CoX/Common/Messages/Map/Map                               ServerEvents.gen.cpp:2:0:
/home/ubuntu/Segs/Projects/CoX/Common/Messages/Map/MapXferWait.h:31:9: error: in                               valid use of incomplete type ‘class BitStream’
bs.StoreString(m_map_name);
^~
In file included from /home/ubuntu/Segs/Projects/CoX/Common/Messages/Map/MapXfer                               Wait.h:9:0,
from /home/ubuntu/Segs/bld/Projects/CoX/Common/Messages/Map/Map                               ServerEvents.gen.cpp:2:
/home/ubuntu/Segs/Projects/CoX/Common/Messages/Map/GameCommand.h:13:7: note: for                               ward declaration of ‘class BitStream’
class BitStream;
^~~~~~~~~
In file included from /home/ubuntu/Segs/Projects/CoX/Common/Messages/Map/GameCom                               mandList.h:28:0,
from /home/ubuntu/Segs/Projects/CoX/Common/Messages/Map/Browser                               .h:9,
from /home/ubuntu/Segs/Projects/CoX/Common/Messages/Map/MapEven                               ts.h:611,
from /home/ubuntu/Segs/Projects/CoX/Common/Messages/Map/TradeWa                               sCancelledMessage.h:9,
from /home/ubuntu/Segs/bld/Projects/CoX/Common/Messages/Map/Map                               ServerEvents.gen.cpp:4:
/home/ubuntu/Segs/Projects/CoX/Common/Messages/Map/LevelUp.h: In member function                                ‘virtual void SEGSEvents::LevelUpResponse::serializefrom(BitStream&)’:
/home/ubuntu/Segs/Projects/CoX/Common/Messages/Map/LevelUp.h:51:38: warning: unu                               sed parameter ‘bs’ [-Wunused-parameter]
void    serializefrom(BitStream &bs) override
^~
In file included from /home/ubuntu/Segs/bld/Projects/CoX/Common/Messages/Map/Map                               ServerEvents.gen.cpp:98:0:
/home/ubuntu/Segs/Projects/CoX/Common/Messages/Map/ForceLogout.h: In member func                               tion ‘virtual void SEGSEvents::ForceLogout::serializefrom(BitStream&)’:
/home/ubuntu/Segs/Projects/CoX/Common/Messages/Map/ForceLogout.h:30:35: warning:                                unused parameter ‘bs’ [-Wunused-parameter]
void serializefrom(BitStream &bs) override
^~
Projects/CoX/Common/Messages/Map/CMakeFiles/MapServer_interface.dir/build.make:1                               32: recipe for target 'Projects/CoX/Common/Messages/Map/CMakeFiles/MapServer_int                               erface.dir/MapServerEvents.gen.cpp.o' failed
make[2]: *** [Projects/CoX/Common/Messages/Map/CMakeFiles/MapServer_interface.di                               r/MapServerEvents.gen.cpp.o] Error 1
CMakeFiles/Makefile2:1363: recipe for target 'Projects/CoX/Common/Messages/Map/C                               MakeFiles/MapServer_interface.dir/all' failed
make[1]: *** [Projects/CoX/Common/Messages/Map/CMakeFiles/MapServer_interface.di                               r/all] Error 2
Makefile:129: recipe for target 'all' failed

If you immediately retry the build, does this continue to happen? Perhaps it's just the order of dependencies. What toolchain is being used? QTCreator + GCC?

I can't replicate this on Fedora, and it looks very much like a swap memory issue. Recommendation is to try to rebuild again immediately to see if it succeeds on the second pass.
@Baaleos please reopen if you're still experiencing issues.

Following the instructions on the headless Ubuntu 18.04 page, and provisioning a tiny virtual server using Linode, I also was unable to get a successful compilation. Unfortunately, I only got to 28% built. Last few messages are below.
The previous suggestions to immediately try building (by running make?) yielded no change.
[ 27%] Built target cox_server_common
[ 28%] Automatic MOC for target gameData
[ 28%] Built target gameData_autogen
[ 28%] Building CXX object Projects/CoX/Common/GameData/CMakeFiles/gameData.dir/bodypart_definitions.cpp.o
/usr/src/Segs/Projects/CoX/Common/GameData/bodypart_definitions.cpp: In member function ‘void BodyPartsStorage::postProcess()’:
/usr/src/Segs/Projects/CoX/Common/GameData/bodypart_definitions.cpp:98:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for (int i = 0; i < m_parts.size(); ++i )
^~~~~~~~~~~~~~
/usr/src/Segs/Projects/CoX/Common/GameData/bodypart_definitions.cpp: In member function ‘BodyPart_Data* BodyPartsStorage::getBodyPartFromName(const QByteArray&)’:
/usr/src/Segs/Projects/CoX/Common/GameData/bodypart_definitions.cpp:120:27: error: ‘class QByteArray’ has no member named ‘compare’
if ( 0==bp.m_Name.compare(name,Qt::CaseInsensitive) )
^~~~~~~
Projects/CoX/Common/GameData/CMakeFiles/gameData.dir/build.make:830: recipe for target 'Projects/CoX/Common/GameData/CMakeFiles/gameData.dir/bodypart_definitions.cpp.o' failed
make[2]: *** [Projects/CoX/Common/GameData/CMakeFiles/gameData.dir/bodypart_definitions.cpp.o] Error 1
CMakeFiles/Makefile2:783: recipe for target 'Projects/CoX/Common/GameData/CMakeFiles/gameData.dir/all' failed
make[1]: *** [Projects/CoX/Common/GameData/CMakeFiles/gameData.dir/all] Error 2
Makefile:129: recipe for target 'all' failed
make: *** [all] Error 2

Okay, my error was not associated with the initial bug report. Following the installation guide, I ended up on the development branch.
I'll submit a PR to edit the guide to include:
git fetch origin refs/tags/v0.7.0:refs/tags/v0.7.0
git checkout v0.7.0

Thanks!

@fourgot For future reference, your error stems from using an old version of Qt5. A version check should probably be added in the CMake scripts.

How do I unsubscribe to all this?
On Sat, Jul 6, 2019, 4:06 PM Andrew Kubiak<EMAIL_ADDRESS>wrote:

Following the instructions on the headless Ubuntu 18.04 page
https://github.com/Segs/Segs/blob/develop/docs/SEGS-COMPILE_AND_INSTALL-UBUNTU.md,
and provisioning a tiny virtual server using Linode
https://www.linode.com, I also was unable to get a successful
compilation. Unfortunately, I only got to 28% built. Last few messages are
below.
The previous suggestions to immediately try building (by running make?)
yielded no change.
[ 27%] Built target cox_server_common
[ 28%] Automatic MOC for target gameData
[ 28%] Built target gameData_autogen
[ 28%] Building CXX object
Projects/CoX/Common/GameData/CMakeFiles/gameData.dir/bodypart_definitions.cpp.o
/usr/src/Segs/Projects/CoX/Common/GameData/bodypart_definitions.cpp: In
member function ‘void BodyPartsStorage::postProcess()’:
/usr/src/Segs/Projects/CoX/Common/GameData/bodypart_definitions.cpp:98:23:
warning: comparison between signed and unsigned integer expressions
[-Wsign-compare]
for (int i = 0; i < m_parts.size(); ++i )
^~~~~~~~~~~~~~
/usr/src/Segs/Projects/CoX/Common/GameData/bodypart_definitions.cpp: In
member function ‘BodyPart_Data* BodyPartsStorage::getBodyPartFromName(const
QByteArray&)’:
/usr/src/Segs/Projects/CoX/Common/GameData/bodypart_definitions.cpp:120:27:
error: ‘class QByteArray’ has no member named ‘compare’
if ( 0==bp.m_Name.compare(name,Qt::CaseInsensitive) )
^~~~~~~
Projects/CoX/Common/GameData/CMakeFiles/gameData.dir/build.make:830:
recipe for target
'Projects/CoX/Common/GameData/CMakeFiles/gameData.dir/bodypart_definitions.cpp.o'
failed
make[2]: ***
[Projects/CoX/Common/GameData/CMakeFiles/gameData.dir/bodypart_definitions.cpp.o]
Error 1
CMakeFiles/Makefile2:783: recipe for target
'Projects/CoX/Common/GameData/CMakeFiles/gameData.dir/all' failed
make[1]: *** [Projects/CoX/Common/GameData/CMakeFiles/gameData.dir/all]
Error 2
Makefile:129: recipe for target 'all' failed
make: *** [all] Error 2
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Segs/Segs/issues/728?email_source=notifications&email_token=ALFLEOJKS2RJFKXAECU3L6DP6D3MJA5CNFSM4GMT3MVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZK7QRI#issuecomment-508950597,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALFLEOP73NBWWOUVKQVKIILP6D3MJANCNFSM4GMT3MVA
.

@CR-DESIGN-Solutions Most likely You'll want to switch Github's 'watch mode' to less verbose one. The option to do this is in the first button here.


Refactor Makefile to utilize different set of targets for Nix and Poetry

[x] I have searched the issues of this repo and believe that this is not a duplicate.

Feature Request

Since this project is getting many more Nix-related implementations (environment, package, image, CI, etc), and personally for me, Nix has become something I use on daily basis. It would be nice to have the same set of make targets as one entry point to do a certain job regardless of the environment (From Nix or Linux + Poetry). Among others, this would help avoid implementation like this:
https://github.com/rszamszur/fastapi-mvc/blob/0aadd34a5472a71d8a90d0a3c89dbf904c4c576c/.github/workflows/nix.yml#L59-L84
Even though the logic for metrics target (calling flake8 and black) is the same. It differs in the way it's executed from a given environment:
# Environment from given Linux os packages + Poetry:
poetry run flake8 ...
# vs Nix
nix-shell shell.nix --run "flake8 ..."

Not only would this make life easier for those that would decide to use Nix (like me :smile: ). Moreover, it can be an excellent opportunity to play/experiment with Nix for newcomers. Especially since Nix expressions and Nix CI are included in the project generated by fastapi-mvc new ... aswell.
Lastly, while at it, I might add a few improvements to the Makefile and its scripts. It's long due.
This issue will apply to both fastapi-mvc and the project template.

Because of: #146. Changes regarding the project template will be done already in its separate repository.


Add example of simulating a pendulum

The goal is to add to the models available in the simulator the model of a pendulum.
Such model could then be the first simple showcase model of the simulator that a non expert user could run on a local machine or on MATLAB online.
The model shall be fix based. This probably requires tweaking either the simulator either the model (refer to https://github.com/dic-iit/matlab-whole-body-simulator/issues/18#issuecomment-804023901).
For this reason, it might also make sense to implement this after #19 .

Add to the models available in the simulator the model of a pendulum.

Add to the models available in the simulator the model of a pendulum.

Implemented in #22 .

Remaining issues are...

[ ] Fix issue with the meshes: convert from dae to stl.
[ ] Fix meshes location such that specifying the meshes prefix is not required.

Detailed steps
Fix issue with the meshes: convert from dae to stl.

[ ] Converting Collada (.dae) to URDF (.stl)
Collada URDF contains packages for converting from collada files to URDF. Collada to urdf command-line tool:
rosrun collada_urdf collada_to_urdf <input.dae> <output.urdf>

collada_urdf package has to be built and installed...

[ ] Create a Catkin workspace, build catkin package and install in workspace (https://wiki.ros.org/catkin/Tutorials).

Creating a workspace for catkin

This tutorial covers how to setup a catkin workspace in which one or more catkin packages can be built.
Creating a ROS Package

How to create a new ROS package using catkin.
Building and using catkin packages in a workspace

How to use catkin_make to build and install packages from source in a catkin workspace.
Overlaying with catkin workspaces

Describes how to overlay a catkin workspace on to an existing system for development and testing.

[ ] Install catkin tools, from ROS packages (e.g. robostack).
Install robostack:conda create -n robostackenv python=3.8
conda activate robostackenv
conda config --env --add channels conda-forge
conda config --env --add channels robostack
conda config --env --set channel_priority strict
mamba install ros-noetic-desktop
mamba install compilers cmake pkg-config make ninja catkin_tools
conda deactivate
conda activate robostackenv

Fix meshes location such that specifying the meshes prefix is not required.
...

All completed. Closing.

Could it make sense to add some documentation in the README or linked from the readme on how to try this example? Otherwise it could be a bit difficult for users to find it.

Could it make sense to add some documentation in the README or linked from the readme on how to try this example? Otherwise it could be a bit difficult for users to find it.

Fixed in #33 .


Reduce left padding - FIND A SERVICE on Search Page

Too much padding on the left of "FIND A SERVICE" title on the Search page, especially for the non-English version on Staging V1.25.0.  See the English and Korean examples on the screenshots below.

Acceptance Criteria

[ ]

Steps for QA:

Staging version 1.32.0 - passes


Broken Link of Variational Algorithm on Documentation Page

Description of the issue
Under the Advanced Tutorials section on documentation page, Variational Algorithm link is broken
How to reproduce the issue
Go to this page and check for the link of Variational Algorithm

Thank you for letting us know @shadab-entrepreneur! Would you be open to fix it? We are open for PRs! :)

Sure @balopat
I'm new to the documentation of Cirq, can you please point me to the file from where these notebooks are getting rendered?

Sure @balopat

Fixed in #3178


How to navigate from drawer navigator to another with nested navigators ?

Navigator Structure
DrawerNavigators

TimelineNavigators

Screen1 (initialRoute)
Screen2

SettingsScreen

Current Behavior
When click button (onPress={() => { navigation.navigate('Screen2') }) on SettingsScreen, nothing happens. Screen was not changed. is it bug ?
Expected Behavior
When click button (onPress={() => { navigation.navigate('Screen2') }) on SettingsScreen , have to open Screen2.
Your Environment

software
version

react-navigation
1.0.0-beta.19

react-native
0.49.5

node
6.11.2

npm or yarn
5.5.1

is it bug? @spencercarli

Please never ping directly maintainers
It may not be a bug and it depends on how you structured your code. Without a Snack or repo reproducing this issue we can't really help.

@kelset
TimeLine Navigator
export const TimelineNavigators = StackNavigator({
    'screen1': { screen: Timeline, navigationOptions:Screen1NavigatorOptions() },
    'screen2': { screen: LiveMap,  navigationOptions:Screen2NavigatorOptions() },
},{initialRoute: 'screen1'});

Drawer
const routeConfiguration = {
    'TimelineNavigators': { screen: TimelineNavigation, navigationOptions: timeLineDrawerOptions },
    'SettingsScreen': { screen: SettingsScreen , navigationOptions: settingsDrawerOptions },
};

export const NavigatorAuth = DrawerNavigator(routeConfiguration, drawerOptions());

Setting Screen
import { View, Text, Button } from 'react-native';
import { NavigationActions } from 'react-navigation'

class Settings extends Component {
    render() {
        return (
            <View>
                <Button onPress={()=> this.props.navigation.navigate('screen2')}  title="Go to Screen 2"/>
            </View>
        );
    }
}

export default Settings;

I click 'Go to Screen 2 ' button , then not go to Screen 2.

@kelset
Setting Screen
import { View, Text, Button } from 'react-native';
import { NavigationActions } from 'react-navigation'

class Settings extends Component {
    render() {
        return (
            <View>
                <Button onPress={()=> this.props.navigation.navigate('screen2')}  title="Go to Screen 2"/>
            </View>
        );
    }
}

export default Settings;

There is one solution but it is not good.
Solution:
import { View, Text, Button } from 'react-native';
import { NavigationActions } from 'react-navigation'

class Settings extends Component {

//solution
 navigateScreen(navigation){
     navigation.navigate('TimelineNavigators');
     navigation.navigate('screen2');
}
    render() {
        return (
            <View>
                <Button onPress={()=> this.navigateScreen(this.props.navigation)  title="Go to Screen 2"/>
            </View>
        );
    }
}

export default Settings;

@kelset  There is more information. I add repo link. Could you help me?

hi @kelset  :)
is there any improvement?

@kelset

Please never ping directly maintainers

I guess it's really hard to understand. Looks to me like you expect that maintainers are a customer support service, so let le extremely clear:
maintainers !== customer support service

I know @kelset  :)

this is resolved in 2.0 with https://github.com/react-navigation/rfcs/blob/master/text/0004-less-pushy-navigate.md


[OCaml] Line breaks in module types

Describe the bug
In interface files, we are too eager to put line breaks before the sig keyword. For instance, this common piece of code:
module Foo: sig
  val foo : int
end

gets formatted as
module Foo:
sig
  val foo : int
end

Expected behavior
I expect the original formatting to be kept as is.
Environment

Ubuntu 22.04
main on 2023-01-24 (https://github.com/tweag/topiary/commit/3eefa610bab865a25adaf93a1046937b85836657)

How easy is it to fix this?

This is likely easy. In short, drop the current line break, then put back a more specific line break where the tests fail.


Fix memory leak in X509_REQ / propq is never freed

The propq is strdup'ed in X509_REQ_new_ex, but never freed. I guess it shall be freed in X509_REQ_free.
The strdup is here:
https://github.com/openssl/openssl/blob/44c75ba67df9588636649416e6fb120a9fc27489/crypto/x509/x_req.c#L115-L129

This pull request is ready to merge

Merged to master. Thank you for the contribution!


"This app is blocked"

This app is blocked

 This app tried to access sensitive info in your Google Account. To keep your account safe, Google blocked this access.

I started seeing this exact issue recently as well. I'm not sure what changed.


Windows Service App Center support for Crashes/Errors

Describe the solution you'd like
Windows Service App Center support for Crashes/Errors. Basically we have a windows service that does a few different actions. Such as e-mailing reports on a schedule. the errors for this are currently entered into event log, but as this is often installed on a server, it can be hard to know there have been any errors.
Describe alternatives you've considered
Currently get logged in Event Viewer for our background service.
Additional context
If this worked we would be aware of current errors, versions etc and be able to fix them sooner.

Hey @james1301 which SDK are you currently using for your Service app? We don't currently support "services" but I'd be interested in learning more about your scenario. We can chat more in our call or via this thread. Thanks!

Hi @winnieli1208 we are created a c# Console Application essentially. Using the Visual Studio 'Windows Service' Template. If that answers your question?

But yeah can discuss more on our call.

With your coming support for windows WPF, i would also like to have support for windows service app's. Our client/server (service) solution for internal use will then have full diagnostic and analytics support.

Hi @winnie, It would be nice to have this feature. As I have many c# Console Application

Any more feedback on this issue would be hgood

Has there been any further updates on how to add the app center for .net Windows services please, I could really use this
thanx