Auto-Reconnect Loop

Describe the bug
Connecting with +auto-reconnect loops infinitely when the RDP session cannot initialize.
To Reproduce
Steps to reproduce the behavior:

Use a build affected by #5960. A similar issue should also do, so long as a TCP connection is made but some flavour of protocol error happens before any user input.

The command I used was xfreerdp +clipboard +compression +heartbeat /compression-level:2 /sec:rdp /h:900 /w:1450 /u:[user] /v:[hostname] +auto-reconnect.

The reconnect attempt will loop infinitely, reporting that we are attempting reconnect number 1 out of the maximum number of retries (default 20).

Expected behavior
The RDP credential prompt is expected to appear.
Example Output
[11:32:11:209] [695106:695134] [INFO][com.freerdp.core] - freerdp_connect:freerdp_set_last_error_ex resetting error state
[11:32:11:209] [695106:695134] [INFO][com.freerdp.client.common.cmdline] - loading channelEx rdpdr
[11:32:11:209] [695106:695134] [INFO][com.freerdp.client.common.cmdline] - loading channelEx rdpsnd
[11:32:11:209] [695106:695134] [INFO][com.freerdp.client.common.cmdline] - loading channelEx cliprdr
[11:32:11:518] [695106:695134] [INFO][com.freerdp.primitives] - primitives autodetect, using optimized
[11:32:11:519] [695106:695134] [INFO][com.freerdp.core] - freerdp_tcp_is_hostname_resolvable:freerdp_set_last_error_ex resetting error state
[11:32:11:519] [695106:695134] [INFO][com.freerdp.core] - freerdp_tcp_connect:freerdp_set_last_error_ex resetting error state
[11:32:12:635] [695106:695134] [INFO][com.freerdp.gdi] - Local framebuffer format  PIXEL_FORMAT_BGRX32
[11:32:12:635] [695106:695134] [INFO][com.freerdp.gdi] - Remote framebuffer format PIXEL_FORMAT_RGB16
[11:32:12:642] [695106:695134] [INFO][com.winpr.clipboard] - initialized POSIX local file subsystem
[11:32:12:653] [695106:695134] [INFO][com.freerdp.channels.rdpsnd.client] - [static] Loaded fake backend for rdpsnd
[11:32:13:797] [695106:695134] [ERROR][com.freerdp.core.channels] - Header length 20 != actual length 12
[11:32:13:797] [695106:695134] [ERROR][com.freerdp.core.transport] - transport_check_fds: transport->ReceiveCallback() - -1
[11:32:13:797] [695106:695134] [ERROR][com.freerdp.core] - freerdp_check_fds() failed - 0
[11:32:13:797] [695106:695134] [INFO][com.freerdp.client.common] - Network disconnect!
[11:32:13:797] [695106:695134] [INFO][com.freerdp.client.common] - Attempting reconnect (1 of 20)
[11:32:13:799] [695106:695134] [INFO][com.freerdp.core] - freerdp_tcp_is_hostname_resolvable:freerdp_set_last_error_ex resetting error state
[11:32:13:799] [695106:695134] [INFO][com.freerdp.core] - freerdp_tcp_connect:freerdp_set_last_error_ex resetting error state
[11:32:14:033] [695106:695134] [INFO][com.freerdp.channels.rdpsnd.client] - [static] Loaded fake backend for rdpsnd
[11:32:14:189] [695106:695134] [ERROR][com.freerdp.core.channels] - Header length 20 != actual length 12
[11:32:14:189] [695106:695134] [ERROR][com.freerdp.core.transport] - transport_check_fds: transport->ReceiveCallback() - -1
[11:32:14:189] [695106:695134] [ERROR][com.freerdp.core] - freerdp_check_fds() failed - 0
[11:32:14:189] [695106:695134] [INFO][com.freerdp.client.common] - Network disconnect!
[11:32:14:189] [695106:695134] [INFO][com.freerdp.client.common] - Attempting reconnect (1 of 20)

Application details

Version: FreeRDP version 2.0.0-dev5 (5690780bd)
OS version connecting to: Windows 10

/buildconfig output:
Build configuration: BUILD_TESTING=OFF BUILTIN_CHANNELS=ON HAVE_AIO_H=1 HAVE_EXECINFO_H=1 HAVE_FCNTL_H=1 HAVE_INTTYPES_H=1 HAVE_JOURNALD_H=TRUE HAVE_MATH_C99_LONG_DOUBLE=1 HAVE_POLL_H=1 HAVE_PTHREAD_MUTEX_TIMEDLOCK=ON HAVE_PTHREAD_MUTEX_TIMEDLOCK_LIB=1 HAVE_PTHREAD_MUTEX_TIMEDLOCK_SYMBOL= HAVE_SYSLOG_H=1 HAVE_SYS_EVENTFD_H=1 HAVE_SYS_FILIO_H= HAVE_SYS_MODEM_H= HAVE_SYS_SELECT_H=1 HAVE_SYS_SOCKIO_H= HAVE_SYS_STRTIO_H= HAVE_SYS_TIMERFD_H=1 HAVE_TM_GMTOFF=1 HAVE_UNISTD_H=1 HAVE_XI_TOUCH_CLASS=1 WITH_ALSA=ON WITH_CAIRO=ON WITH_CCACHE=ON WITH_CHANNELS=ON WITH_CLANG_FORMAT=ON WITH_CLIENT=ON WITH_CLIENT_AVAILABLE=1 WITH_CLIENT_CHANNELS=ON WITH_CLIENT_CHANNELS_AVAILABLE=1 WITH_CLIENT_COMMON=ON WITH_CLIENT_INTERFACE=OFF WITH_CUPS=ON WITH_DEBUG_ALL=OFF WITH_DEBUG_CAPABILITIES=OFF WITH_DEBUG_CERTIFICATE=OFF WITH_DEBUG_CHANNELS=OFF WITH_DEBUG_CLIPRDR=OFF WITH_DEBUG_DVC=OFF WITH_DEBUG_KBD=OFF WITH_DEBUG_LICENSE=OFF WITH_DEBUG_MUTEX=OFF WITH_DEBUG_NEGO=OFF WITH_DEBUG_NLA=OFF WITH_DEBUG_NTLM=OFF WITH_DEBUG_RAIL=OFF WITH_DEBUG_RDP=OFF WITH_DEBUG_RDPDR=OFF WITH_DEBUG_RDPEI=OFF WITH_DEBUG_RDPGFX=OFF WITH_DEBUG_REDIR=OFF WITH_DEBUG_RFX=OFF WITH_DEBUG_RINGBUFFER=OFF WITH_DEBUG_SCARD=OFF WITH_DEBUG_SND=OFF WITH_DEBUG_SVC=OFF WITH_DEBUG_SYMBOLS=OFF WITH_DEBUG_THREADS=OFF WITH_DEBUG_TIMEZONE=OFF WITH_DEBUG_TRANSPORT=OFF WITH_DEBUG_TSG=OFF WITH_DEBUG_TSMF=OFF WITH_DEBUG_TSMF=OFF WITH_DEBUG_TSMF_AVAILABLE=0 WITH_DEBUG_WND=OFF WITH_DEBUG_X11=OFF WITH_DEBUG_X11_CLIPRDR=OFF WITH_DEBUG_X11_LOCAL_MOVESIZE=OFF WITH_DEBUG_XV=OFF WITH_DSP_EXPERIMENTAL=OFF WITH_EVENTFD_READ_WRITE=1 WITH_FAAC=OFF WITH_FAAD2=OFF WITH_FFMPEG=FALSE WITH_FFMPEG=FALSE WITH_GFX_H264=OFF WITH_GPROF=OFF WITH_GSM=OFF WITH_GSSAPI=OFF WITH_ICU=OFF WITH_IPP=OFF WITH_JPEG=ON WITH_LAME=OFF WITH_LIBRARY_VERSIONING=ON WITH_LIBSYSTEMD=ON WITH_MACAUDIO=OFF WITH_MACAUDIO=OFF WITH_MACAUDIO_AVAILABLE=0 WITH_MANPAGES=ON WITH_MBEDTLS=OFF WITH_OPENCL=OFF WITH_OPENH264=OFF WITH_OPENSLES=OFF WITH_OPENSSL=ON WITH_OSS=ON WITH_PAM=ON WITH_PCSC=ON WITH_PROFILER=OFF WITH_PROXY_MODULES=OFF WITH_PULSE=ON WITH_SAMPLE=OFF WITH_SANITIZE_ADDRESS=ON WITH_SANITIZE_ADDRESS_AVAILABLE=1 WITH_SANITIZE_MEMORY=OFF WITH_SANITIZE_MEMORY=OFF WITH_SANITIZE_MEMORY_AVAILABLE=0 WITH_SANITIZE_THREAD=OFF WITH_SANITIZE_THREAD=OFF WITH_SANITIZE_THREAD_AVAILABLE=0 WITH_SERVER=ON WITH_SERVER_CHANNELS=ON WITH_SERVER_INTERFACE=ON WITH_SMARTCARD_INSPECT=OFF WITH_SOXR=OFF WITH_SSE2=ON WITH_SWSCALE=OFF WITH_THIRD_PARTY=OFF WITH_VALGRIND_MEMCHECK=OFF WITH_VALGRIND_MEMCHECK=OFF WITH_VALGRIND_MEMCHECK_AVAILABLE=0 WITH_WAYLAND=OFF WITH_WINPR_TOOLS=ON WITH_X11=ON WITH_X264=OFF WITH_XCURSOR=ON WITH_XDAMAGE=ON WITH_XEXT=ON WITH_XFIXES=ON WITH_XI=ON WITH_XINERAMA=ON WITH_XKBFILE=ON WITH_XRANDR=ON WITH_XRENDER=ON WITH_XSHM=ON WITH_XTEST=ON WITH_XV=ON WITH_ZLIB=ON
Build type:          RelWithDebInfo
CFLAGS:              -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fPIC -Wall -Wno-unused-result -Wno-unused-but-set-variable -Wno-deprecated-declarations -fvisibility=hidden -Wimplicit-function-declaration -Wredundant-decls -g -fno-omit-frame-pointer -DWINPR_DLL
Compiler:            GNU, 9.2.1
Target architecture: x64

Desktop (please complete the following information):

OS: Linux (Fedora 31)

Duplicates #5960

@akallabeth Sorry for what ended up as a duplicate. In my head, I viewed #5960 as "specific protocol error causing disconnect", while this issue was related but separate as "if any protocol error exists, then loop forever".

@adeutscher you're right, missed the never increasing loop counter.

Ok, rechecked.
This is desired behaviour of auto-reconnect. (yes, it looks weired)
Thing is, the connection succeeds, but is aborted after a new connection was established, so auto-reconnect starts anew.


new lexer request: apex (salesforce)

(Original issue 1029 created by samdavyson on 2014-09-15T14:55:05.612073+00:00)
There is currently no highlighting for Apex code which is used in Salesforce.com development.
The syntax is very similar to Java. I raised this initially on Github and it was suggested that I report this here.
(From: https://github.com/github/linguist/issues/1526#issuecomment-55595939)

(Original comment by birkenfeld on 2014-09-15T18:18:33.988677+00:00)
Would you be willing to make a patch for it?

(Original comment by samdavyson on 2014-09-16T07:05:59.105947+00:00)
Yes I would be willing. I will submit a pull request when done.

(Original comment by birkenfeld on 2014-09-16T07:25:58.287463+00:00)
Great!

(Original comment by shawalli on 2018-07-21T12:12:28.505766+00:00)
I've created an Apex lexer. I modified the Java lexer within items specific to Apex. It is nowhere near complete, but it is a starting point. Please feel free to submit updates as you use it and find gaps. https://github.com/shawalli/pygments-lexer-apex


st.experimental_data_editor vs st.data_editor

Link to doc page in question (if any):
https://github.com/streamlit/docs/blob/main/content/library/advanced-features/dataframes.md
Name of the Streamlit feature whose docs need improvement:
st.experimental_data_editor
What you think the docs should say:
There are references in the sample code blocks and text to st.data_editor where they probably should be st.experimental_data_editor.

Thank you for reporting this issue, @asehmi! 🔍


I can't press run button

When i try to solve the exercise, i can't press run button, neither in the mobile browser nor in the computer browser.
That could be happening?

In which exercice ?
All ?
Perhabs your browser. Do you use google chrome ? IE ?

All exercises, im using google chrome.

The button appears disable

Ok, have you enter some value in blank fields ?

Yes, of course, i am trying in firefox and showed the same problem.

Send screen shots please.

Don't know what to tell you. I have to probleme to submit exercices ...
Sorry.

Thanks

Are you logged? You must be logged to run exercises

Ho yes sorry I think that wasn't required.
90% sure this will resolv issuel

Yes, yesterday i tried to login and it showed an error. Today i tried and everything works correctly!
Thanks!!!

I have the same issue, I can't press buttons after filling blank fields because it is disabled. I already logged in via GitHub.


Implement shareInfoToResourceInfo

https://github.com/pondersource/nc-sciencemesh/blob/f48c933/lib/Controller/RevaController.php#L243
2022-11-01 12:28:50.264 INF ../../reva/pkg/ocm/share/manager/nextcloud/nextcloud.go:212 > am.do response 201 {"todo":"compile this info from various database tables"} pid=7 pkg=rgrpc traceid=94d2b8b1b559653b398275880d470c35
2022-11-01 12:28:50.634 DBG ../../reva/internal/grpc/interceptors/log/log.go:66 > unary code=OK end="01/Nov/2022:12:28:50 +0000" from=tcp://<IP_ADDRESS>:52202 pid=7 pkg=rgrpc start="01/Nov/2022:12:28:50 +0000" time_ns=575027101 traceid=94d2b8b1b559653b398275880d470c35 uri=/cs3.sharing.ocm.v1beta1.OcmAPI/CreateOCMShare user-agent=grpc-go/1.49.0
2022-11-01 12:28:50.635 DBG ../../reva/internal/grpc/interceptors/log/log.go:66 > unary code=OK end="01/Nov/2022:12:28:50 +0000" from=tcp://<IP_ADDRESS>:51590 pid=7 pkg=rgrpc start="01/Nov/2022:12:28:50 +0000" time_ns=577984245 traceid=7abf12e35115a51d921c3a8f05530c10 uri=/cs3.gateway.v1beta1.GatewayAPI/CreateOCMShare user-agent=grpc-go/1.49.0
2022-11-01 12:28:50.635 WRN ../../reva/internal/http/services/ocmd/ocmd.go:132 > request not handled pid=7 pkg=rhttp traceid=95b31bb50c5d0314952a08966acd66ca
2022-11-01 12:28:50.636 WRN ../../reva/internal/http/interceptors/log/log.go:112 > http end="01/Nov/2022:12:28:50 +0000" host=<IP_ADDRESS> method=POST pid=7 pkg=rhttp proto=HTTP/2.0 size=0 start="01/Nov/2022:12:28:49 +0000" status=404 time_ns=1391885727 traceid=95b31bb50c5d0314952a08966acd66ca uri=/ocm/send url=/ocm/send

Info available from the share:
node.path /einstein/files/welcome.txt
nodeType file
shareType 1000
shareOwner einstein
sharedWith<EMAIL_ADDRESS>

Indeed it ends up as the remote_id in nc2.docker:
MariaDB [nextcloud]> select * from oc_share_external;
+----+--------+------------+-------------------------+-----------------------------------------------------------+-------------+----------+--------------+----------+-------+------------------------------------------+----------------------------------+----------+
| id | parent | share_type | remote                  | remote_id                                                 | share_token | password | name         | owner    | user  | mountpoint                               | mountpoint_hash                  | accepted |
+----+--------+------------+-------------------------+-----------------------------------------------------------+-------------+----------+--------------+----------+-------+------------------------------------------+----------------------------------+----------+
|  1 |     -1 |       1000 | https://revanc1.docker/ | {"todo":"compile this info from various database tables"} | yJRVQGPyUK  |          | /welcome.txt | einstein | marie | {{TemporaryMountPointName#/welcome.txt}} | 32021e94fecfcd644f9a5666263732f5 |        0 |
+----+--------+------------+-------------------------+-----------------------------------------------------------+-------------+----------+--------------+----------+-------+------------------------------------------+----------------------------------+----------+
1 row in set (0.001 sec)

The share gets created in oc_share on the sending side, but I'm not sure at which point.
So I don't know where to get its id.
https://github.com/nextcloud/server/blob/06627c800c45672d57a255f494c5d47efd160aff/lib/private/Share20/Manager.php#L1781

So SAH-createShare calls RHC-createShare
and then later SSP-create triggers addition to the database
I don't actually see a call coming from Reva? I would expect Reva to create the share in its share backend.
Will test what happens when we create the share from reva-cli!

I think this was done.


Fix identity_type

Google provider supports empty string for identity_type. Even if IDENTITY_TYPE_UNSPECIFIED is used as the value, Terraform state stores empty string as the value instead. Hence it make sense to support empty string as a value in the module.
Also ANY_USER_ACCOUNT is the correct value for ingress identity_type.

Checklist

I applicable, I acknowledge that I have:

[X] Read the contributing guide
[X] Ran terraform fmt on all modified files
[X] Regenerated the relevant README.md files using tools/tfdoc.py
[X] Made sure all relevant tests pass

Can you provide a use case? We initially defaulted to empty and the effect was not what users intended, unless an actual value was passed. Unless behaviour changed, I don't think we should default to something that has no actual use.

@ludoo The issue is not with the default value. The issue is that when you use IDENTITY_TYPE_UNSPECIFIED value for identity_type in your Terraform code, then after terraform apply, Terraform state will store empty string for identity_type instead. The new run of terraform plan/apply will show a difference between your Terraform code and state, so you will end up with infinite diff. It is better to allow and use empty string instead of IDENTITY_TYPE_UNSPECIFIED.


Show custom icons in autocompletion suggestions

Fixes #91721

get_class_icon() does not have cache, only get_script_icon() in EditorData does.
We're missing a method that uses cache and would return an icon for anything 🤔

BTW something to look into potentially:
Ref<Texture2D> ReplicationEditor::_get_class_icon(const Node *p_node) {
        if (!p_node || !has_theme_icon(p_node->get_class(), EditorStringName(EditorIcons))) {
                return get_theme_icon(SNAME("ImportFail"), EditorStringName(EditorIcons));
        }
        return get_theme_icon(p_node->get_class(), EditorStringName(EditorIcons));
}

We seem to use get_class_icon a lot already throughout the editor, so I guess one more use case shouldn't have dramatic impact if the rest of the editor behaves.

Thanks!


Merging duplicated sections leaves whitespace

Example:
# Changelog

All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## 0.1.0 - 2022-08-10

### Added

- Initial version.

### Changed

- Something changed.

### Added

- Another added item.

becomes
# Changelog

All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## 0.1.0 - 2022-08-10

### Added

- Initial version.
- Another added item.

### Changed

- Something changed.

Thanks for reporting this!


experiment: try to declare virtual css modules sideeffect free

unfortunately the only thing that seems to work is using the sideEffects field in package.json.
using annotation comments isn't working for import/export and both returning moduleSideEffects: false from the load hook or a custom rollup.treeshake function does not lead to the magenta css being omitted in the testcase :(

Looks like it's being overridden at  https://github.com/vitejs/vite/blob/22bd67d70a1390daae19ca33d7de162140d533d6/packages/vite/src/node/plugins/css.ts#L515
If I add a post Vite plugin to force it to moduleSideEffects: false, the CSS are all gone as Vite is unable to retrieve them in renderChunk (as the linked code comment showed). The package.json sideEffects trick worked because it sets *.svelte files as no side-effects instead, which covers the CSS treeshaking one level higher, so it doesn't hit the Vite caveat.
This seems a little tricky. Maybe Vite needs to handle CSS moduleSideEffects: false specifically.


setCatchHandler only works offline

Using Workbox version: 4.3.1
I'm testing out the code snippet found here: https://developers.google.com/web/tools/workbox/guides/advanced-recipes#provide_a_fallback_response_to_a_route
I have a test web page that has several 404 missing images.
When I load the web page (online) I see the image alt-text and an  error.
When I load the web page (offline) I see the fallback image.
Is there a way to display the fallback images both online and offline using the setCatchHandler.
Thanks.

Hello!
I think that the advice at https://github.com/GoogleChrome/workbox/issues/2084#issuecomment-506457979 should apply to your situation.
Please let us know if that's not the case and we can investigate further.

@jeffposnick Thanks for your reply, yes that fixes the issue.
Would it be a good idea to add your comment to the doc's (to the fallback image):

A 4xx or 5xx response from the network isn't consider a failure, so falling back to the cache won't happen automatically. (This matches the general behavior you get from using fetch() directly).

@jeffposnick Thanks for your comment, I did the following, but it doesn't seem to work, here is my code:
 workbox.routing.registerRoute(
   /\.(?:png|jpg|jpeg|webp)$/,
   new workbox.strategies.CacheFirst({
     cacheName: 'images',
     plugins: [
       new workbox.expiration.Plugin({
         maxAgeSeconds: 30 * 24 * 60 * 60, // 30 Days
       }),
       new workbox.cacheableResponse.Plugin({
         statuses: [0, 200],
       }),
       /* Handle 4xx or 5xx response from the network */
       {
         // respond with cached content if there's an HTTP error
         fetchDidSucceed: async ({ request, response }) => {
           if (response.ok) {
             return response;
           }
           throw new Error(`${response.status} ${response.statusText}`);
         },
         // Add a Fallback Image
         cacheKeyWillBeUsed: async function({ request, mode }) {
           return "/storage/app/media/fallback.png";
         }
       }
     ],
   }),
 );

Thanks for your help.

Thanks for your help. 😃


Unity 2017.3.1 Compatibility

Thanks for this. Great learning project.
Is there a reason for using Unity 2018.
I have tried using 2017.3 and am running into some issues.

There's a couple reasons why this is built on 2018.2:

The access to the Speech SDK is done over native WebSocket classes in .NET 4.6. Support for .NET 4.6 was experimental in 2017.x, now released as stable in 2018.x.
Most Azure cloud services require secure SSL/TLS connections. Unity 2018.1 and before doesn't support TLS since it has no way to verify certificates using local certificate stores. This was finally fixed in 2018.2. This sample also requires a secure TLS connection, hence why it won't work in 2018.1 or 2017.x even if you have a valid API key. There is a hack to get around this in these older versions, but it is not secure or production-ready, which is why we don't advocate using it now that 2018.2 is out.

I thought it had to do with TLS but could not get up and running. Time to upgrade to 2018.2! Thanks for explaining.


Fix _get_virtualenv_hash function

The issue
There is a related issue #2919.
Case-sensitive filesystems are handled like case-insensitive and vice versa.
This bug was introduced in #2513 and it affects only master branch and does not affect previous release.
I didn't find any related issue.
The fix
This PR adds not  before the related condition.
Additional changes

add PyCharm's config directory to .gitignore

CC

@uranusjr
@techalchemy

The checklist

[x] Associated issue
[ ] A news fragment in the news/ directory to describe this fix with the extension .bugfix, .feature, .behavior, .doc. .vendor. or .trivial (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

Hi @uranusjr,
I believe you can help me fix _get_virtualenv_hash for Windows as well.
Thank you!

@kennethreitz, @uranusjr, @techalchemy
Does anyone care that there is bug which should be fixed?

Hello @Jamim -- of course we care about the library we maintain, but I would suggest that the phrasing is probably not the most effective way to have a positive interaction.
I appreciate your contribution, however, the pr template is there to suggest that you should open and report an issue if there is not yet one on the topic, which is how we typically triage problems.  This helps to avoid contributing a fix before it has been determined that it is necessary.  This way, we can assess that the fix indeed is desired before you put effort into attempting it.
Before we merge any PR related to this, I would need to see a failing test and an issue explaining the problem. Thanks for your efforts

Thank you for the feedback, @techalchemy!
I understand that you have some workflow that you prefer to follow, but meanwhile I believe there is too much effort required for a single-line fix.
I'll create an issue a bit later today, but I strongly recommend you to just look at the patch and realize how redundant this discussion around one little not is.

I still need to know exactly what is broken, preferably via a test case (prevents regression) but if you don't feel like it at least I need to see an example of what you're saying doesn't work properly, because it's hard to decipher that just from reading over the text provided
I.e. what do I need to type in to have a problem?

I.e. what do I need to type in to have a problem?

I found that since I submitted this PR the problem was "fixed" by #2877, but I believe it doesn't work properly. So, you need to revert one commit to see what exactly goes wrong.
git checkout master
git pull origin master
git checkout -b tmp
git revert 65ccd765b6d0b78e602d4b233ca8e31e1a6b8adb
docker rm pipenv_pipenv-tests_1  # you must delete cached image
docker-compose up

@techalchemy By the way, you asked me for some suitable test, but the main goal of this PR (and this one as well) was make the tests works.

Hi @techalchemy,
I created a corresponding issue and I need you to confirm that I should not create any news fragment, since the bug is in master branch only and it's not presented in the release.
And please feel free to ask me anything to clarify the issue.
Thank you!

ping @uranusjr

ping @techalchemy

will look this over again before i cut the next release, sorry about that

Based on the commit you referenced it seems like we just need to call normalize() on the path we create to avoid the issue, no?
And we should be normalizing it before checking as well?

Based on the commit you referenced it seems like we just need to call normalize() on the path we create to avoid the issue, no?

And we should be normalizing it before checking as well?

To be honest, I have no idea. Sorry, I didn't investigate this issue deeper.
By the way, did you read the Solution section of the related issue #2919?

The root cause of the issue is that os.name != "nt" condition was mistakenly converted to fnmatch.fnmatch('A', 'a') when it should have been converted to not fnmatch.fnmatch('A', 'a').

That's it. I just know that the condition was inverted by mistake and it causes the problem for me.

That's it. I just know that the condition was inverted by mistake and it causes the problem for me.

Look, you opened a PR with code changes and you keep telling me a solution, but honestly it is not possible for me to assess a solution until I know the problem.
  The commit you showed me just looks for the virtualenv directory but doesn't do any case normalization.
Ultimately, I really don't know how to ask for this differently, I need you to show me what is wrong by showing me an example of something that is currently behaving incorrectly.  Telling me that someone forgot to put a not somewhere doesn't help me, this is just increasing my cognitive burden when trying to understand the issue.
Here is an example of what I am looking for:
Hi. I am a user of pipenv, and I ran this command:
> some command
...
some output

But as you can see, that directory should really have been found because it exists here:
> ls some_directory

It's going to be hard to move forward on this until I can see something showing me why the current code is wrong.

@techalchemy Should I explain why does it happen?


BigQuery connector

Description:
Feature request. BigQuery connector for sending to / retrieving from BigQuery.

This is added with https://github.com/wso2-ballerina/module-bigquery. Please report any issues/further improvements required in that repo


BUG: Reset password email

I'm currently using the docker version of 4minitz v1.5.2 behind an Nginx reverse proxy.
I did set ROOT_URL in the json setting file correctly, using the proper domain name.
Settings for the SMTP server are also working except for the password reset.
Emails are being sent but the From email account, the subject and the link are incorrect.
Here's an email example when asking for a password reset:
From: Accounts Example<EMAIL_ADDRESS>Sent: Thursday, August 15, 2019 3:44 PM
To: John Doe
Subject: How to reset your password on localhost:3100

Hello John Doe,

To reset your password, simply click the link below.

http://localhost:3100/#/reset-password/zj3RnfxZgXHkdjBg9kwTEyOoi-w4UR5B8-PMfzECvI8

Thanks.

Is this an issue or maybe I'm missing an email template somewhere I have to configure?

Same issue here. The localhost:3100 should be replaced with our domain.

I'm guessing this might be a bug:)?

Can you maybe mark the title to BUG? So that the developers will see this instantly. @joeydc

I have the same problem. And it also happens to the verification mails.
Hello xxx,

To verify your account email, simply click the link below.

http://localhost:3100/#/verify-email/qHw4llTSrg5V4QItaBoxMn21569nqNbKTgUcGkOWn31

Thanks.

Strange issue. Could you plz. state if you use docker build or own build?
Could you check the console / log file server side for this line:
*** ROOT_URL: https://xxx.yyy.zzz

I followed the admin installation guide here: https://github.com/4minitz/4minitz/blob/develop/doc/admin/adminguide.md#docker-setup-on-linux-and-mac to install 4minitz to my docker setup. (There is an openproject docker running as well without any problems.)
The docker vm is not accessable directly from the internet. It is behind a proxy which uses an url something like https://xxx.yyy.de which points to the 4minitz docker installation.
I checked the console / log file server side for the mentioned line (*** ROOT_URL: https://xxx.yyy.zzz). It shows the correct (publicly accessable) url https://xxx.yyy.de that was set up in the settings by me.

OK. Thats interesting.
Could you please try 2 things:

With a user that has a valid eMail address: login to 4Minitz. Then create a meeting series, inside create a meeting, in the meeting create 1 topic. Then press "Send Agenda" button. Inside the EMail - at the very bottom there should be two links where also absolute URLs shall be in. Check if these URLs are correct? Or also with localhost?

2.) There is a second way to specify the ROOT_URL: From outside on your docker commandline like so:
docker run -e "ROOT_URL=https://4minitz.mydomain.com" -it --rm -v $(pwd)/4minitz_storage:/4minitz_storage -p 3100:3333 4minitz/4minitz

Could you give that a shot and report results from step 1.) and 2.)?
Thx. WOK

I can report the same issue in my personal docker setup for 4minitz. Unfortunately step 2.) proposed by @derwok did not solve it in my case.
Additionally, I could reproduce this issue in our development environment by defining a custom ROOT_URL in our test settings and requesting a password by the login user interface.
The good news is that I could find a solution 👍
See 98fb5545433a2d106dcc35d6ac71678bbdf77c31 for details 😉 I made the changes directly on develop.
@derwok or @migerh could one of you please have a short look at the commit 98fb5545433a2d106dcc35d6ac71678bbdf77c31 and verify that is solves this issue? I think you can close it afterwards. Thanks!

Hi Felix! Thanx for stepping in!
The code looks convincing to me. But only "eye review", no runtime checking.
So, have you tried that fix inside a real docker image? And does it solve the issue there?
Or should I build and push a docker-develop image so you can try?

Hi @derwok :-)
With my changes I could not reproduce this issue in my local dev environment anymore. So I assume it will fix it in the docker image, too. But I haven't verified this assumption yet.
It would be great if you could push a docker-develop image. With that I can try it tomorrow.

OK, just built & pushed an unstable/develop image to github.
Launch with:
docker run -it --rm -v $(pwd)/4minitz_storage:/4minitz_storage -p 3100:3333 4minitz/4minitz:develop
or - to be very precise:
docker run -it --rm -v $(pwd)/4minitz_storage:/4minitz_storage -p 3100:3333  4minitz/4minitz:gitcommit-98fb5545

I just updated my docker 4minitz instance to use the latest develop image. With this version I cannot reproduce this bug anymore 👍

Yeij! Thx for fixing and testing!
🙏🏻

For reporters: we currently plan to release the next version in April/May.
For non mission critical usage you might consider going with the develop image just pushed to docker yesterday.

Is this still an issue - I am getting the same problem - users cannot verify accounts or recover passwords even if the localhost part is changed to the correct URL.

Thanks for this chain! I was able to poke around with the same issue, and ended up finding that setting my image to image: 4minitz/4minitz:gitcommit-1202f41f (to avoid issues with develop updating) also worked, and that's marvelous. This is a cool project. Thank you!


Crashing upon leaveBreadcrumb completion block/crumb.metadata

Description
I'm adding a breadcrumb from my Swift code and upon calling Bugsnag.leaveBreadCrumb { crumb in ... }, it crashes.
Issue
Bugsnag's BugsnagBreadcrumb.m (line 89) in - (NSDictionary *)objectValue crashes due to an unrecognized selector for the object's copy functionality not being present.
Environment
iPhone 11 Pro Max (13.3) simulator
iOS 13.3
Bugsnag 5.23.0
Library versions:

Bugsnag version (from your Podfile, Podfile.lock, or elsewhere): 5.23.0
CocoaPods version (if any) (pod -v): 1.7.3
Carthage version (if any): N/A
iOS/tvOS/macOS version(s) 13.3
debug mode or production?: Debug
How are you initializing Bugsnag? Can you share a snippet of your
AppDelegate where Bugsnag is configured?

didFinishLaunchingWithOptions:  Bugsnag.start(withApiKey: "e634d27b23743f20f55395024778520d")
Example code snippet
import Bugsnag

        var values = [Model.Value]()

        values.append(Model.Value("apple", value: 1, type: .primary))
        values.append(Model.Value("banana", value: 2, type: .secondary))

        let model = Model(name: "test", values: values, type: .head)

        guard let value = model.values.first else { return }

        Bugsnag.leaveBreadcrumb { crumb in

            crumb.name = "\(#file)::\(#function)"
            crumb.type = .log
            crumb.metadata = ["model": model,
                              "value": value,
                              "type": value.type]
        }

        Bugsnag.notifyError(NSError(domain: "Test", code: -1, userInfo: nil))

Error messages:
WARN : BSG_KSCrashSentry.c (103): BSG_KSCrashType bsg_kscrashsentry_installWithContext(BSG_KSCrash_SentryContext *, BSG_KSCrashType, void (*)(void *)): KSCrash: App is running in a debugger. Only user reported events will be handled.
2020-01-14 13:50:12.612260-0500 BugsnagCrash[36231:4800765] *** NSForwarding: warning: object 0x6000007a82d0 of class '_TtCV12BugsnagCrash5Model5Value' does not implement methodSignatureForSelector: -- trouble ahead
Unrecognized selector -[_TtCV12BugsnagCrash5Model5Value copy]
2020-01-14 13:50:12.612519-0500 BugsnagCrash[36231:4800765] Unrecognized selector -[_TtCV12BugsnagCrash5Model5Value copy]
(lldb)

Attached project that will reproduce this:
BugsnagCrash.zip

Fixed in v6.1.0 / PLAT-3862


Add Bitcoin Core v0.20.0 release

https://bitcoincore.org/en/2020/06/03/release-0.20.0/

#8 closes this


Add instructions for indicating SLA level

Add to this document

Following up on this to confirm whether you've had a chance to add this content, @icelander. Let me know if I can help with it. :)

@svelle - Do we have SLA levels documented somewhere publicly as well as internally?

Documented via https://mattermost.com/support-terms/


The 'push' type of monitoring is like freezing

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

Description
Thank you for creating this project; it has been immensely helpful. I attempted to build the latest version, 1.23.6, using MariaDB mode with MySQL version 5.7. However, I encountered an issue with the 'push' monitoring type, which seems to be frozen and not checking at the specified intervals. It appears that the heartbeat isn't functioning correctly. Additionally, when the heartbeat time is exceeded, it does not indicate a 'down' status. As in this picture, it has been more than 20 seconds without pushing data, but the status is still UP, which should be DOWN

👟 Reproduction steps
...
👀 Expected behavior
...
😓 Actual Behavior
...
🐻 Uptime-Kuma Version
1.23.6
💻 Operating System and Arch
Macos 14.1.1
🌐 Browser
...
🐋 Docker Version
...
🟩 NodeJS Version
v18.15.0
📝 Relevant log output
...

using MariaDB mode with MySQL version 5.7.

What do you mean by this statement?
using mariadb as a database is not yet released, this is only in the v2 milestone release
Are you sure that you are using 1.23.6 and not the master branch (v2 development happens here, bugs are expected)
To better narrow this issue down:

please fill out all fields (including what is written in the log)
what have you set as Heartbeat Interval (Check every ... seconds), Retry and Heartbeat Retry Interval?

I'll try to make sure to clone the current master repo again. Maybe I did something wrong when building the repo.

git clone https://github.com/louislam/uptime-kuma.git && \ cd uptime-kuma && \ npm install && \ npm ci --production && \ npm install vite --save-dev && \ npm run build

This is a known bug that will be fixed by #3756.
@louislam we should set the version on master branch to 2.0.0-dev or something to prevent confusion.

I'll try to make sure to clone the current master repo again. Maybe I did something wrong when building the repo.

Please see https://github.com/louislam/uptime-kuma/wiki/🔧-How-to-Install

This is a known bug that will be fixed by #3756.
@louislam we should set the version on master branch to 2.0.0-dev or something to prevent confusion.

Ok thank you

Duplicate of #3723


Remove old speed tests

Motivation
@Saksham20 It's fine by me if you want to just remove these old functions; the new progress bar feature in the Iterators basically fulfills the same function without the extra infrastructure here.
Checklist

[X] Have you checked our Contributing document?
[X] Have you ensured the PR description clearly describes the problem and solutions?
[X] Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?

@CodyCBakerPhD can you point me to the progress bar features?

https://github.com/hdmf-dev/hdmf/pull/672 and https://github.com/catalystneuro/nwb-conversion-tools/pull/323


Client Allocation Request for: Estuary

Client Allocation Questions
Core Information

Name: Estuary
Website / Social Media: https://estuary.tech
Region: North America
DataCap Requested: 5TiB
Addresses to be Notarized: f3vnq2cmwig3qjisnx5hobxvsd4drn4f54xfxnv4tciw6vnjdsf5xipgafreprh5riwmgtcirpcdmi3urbg36a
Notary Requested: neogeweb3

@whyrusleeping Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

Hey @whyrusleeping, thanks for the request. I hope this would help you get through the gap in the LDN application.

Request Approved
Your Datacap Allocation Request has been approved by the Notary
Message sent to Filecoin Network

bafy2bzaceak5ueay7ecm4hg4kn5zk4vmxsxbvxm6unxygoxdo5d4wf3thbdqe

Address

f3vnq2cmwig3qjisnx5hobxvsd4drn4f54xfxnv4tciw6vnjdsf5xipgafreprh5riwmgtcirpcdmi3urbg36a

Datacap Allocated

5TiB

You can check the status of the message here: https://filfox.info/en/message/bafy2bzaceak5ueay7ecm4hg4kn5zk4vmxsxbvxm6unxygoxdo5d4wf3thbdqe


GoogleStackdriverAppender doesn't allow for custom credentials

There is a CredentialFile property but please consider something like CredentialJson or a more generic Credential. That would be useful for loading the credential data for example from encrypted storage, DPAPI, or some vault rather than from a plain file on disk.
Thanks!
https://github.com/GoogleCloudPlatform/google-cloud-dotnet/blob/master/apis/Google.Cloud.Logging.Log4Net/Google.Cloud.Logging.Log4Net/GoogleStackdriverAppender.cs#L204

Not including support for the more generic GoogleCredential, as we don't want to have any direct dependencies from libraries in this repo to auth in the Google.Apis.Auth package.

Now release to nuget.org as 2.3.0-beta01


Can not find "word_embeds.glove42b.th"

Hi Shizhe,
Thanks for your great work! I noticed in the training script, it needs to load a pre-train model:
--resume_file $resdir/../../word_embeds.glove42b.th
This leads to initialize the text embedding module？
Besides, I can not find this file from "MSRVTT/results/RET.released/" and can only find one "MSRVTT/results/RET/word_embeds.glove32b.th". Is there any difference between word_embeds.glove42b.th and word_embeds.glove32b.th? Could you please share the "word_embeds.glove42b.th"?

By using "MSRVTT/results/RET/word_embeds.glove32b.th" as --resume_file, I obtain following results. The results on MSRVTT are much lower than those in the paper, especially for R@1 for video-to-text retrieval. Could please help on this issue. Thanks!

Full output log is as follows:

Hi Shizhe,
Thanks for your great work! I noticed in the training script, it needs to load a pre-train model:
--resume_file $resdir/../../word_embeds.glove42b.th
This leads to initialize the text embedding module？
Besides, I can not find this file from "MSRVTT/results/RET.released/" and can only find one "MSRVTT/results/RET/word_embeds.glove32b.th". Is there any difference between word_embeds.glove42b.th and word_embeds.glove32b.th? Could you please share the "word_embeds.glove42b.th"?

Sorry, this is a typo. This file is the glove42b embedding for word initialization.
According to my experiments, it is normal to have performance variances with  ±2 points on the rsum metric.
I am not sure why the performance you reproduced was lower than expected.
I uploaded my configuration files and a trained model in this link (code: f2hm) on MSRVTT dataset. The performance is as follows:
ir1,ir5,ir10,imedr,imeanr,cr1,cr5,cr10,cmedr,cmeanr,rsum,geoavgt2v
ir1-rsum-geoavgt2v,epoch.22.th,9.00,25.93,37.01,22.00,150.65,14.58,37.29,49.30,11.00,88.58,173.12,20.52

You could compare with the configurations of this model. Hope it helps.

Got it. Thanks for the reply and the pre-trained model. I have checked the configurations are the same. By training one more time, I could be able to obtain better results.
number of resumed variables: 27
ir1,ir5,ir10,imedr,imeanr,cr1,cr5,cr10,cmedr,cmeanr,rsum
cr5-cmedr-rsum,epoch.21.th,8.88,25.98,36.65,22.00,148.33,14.28,36.62,48.73,11.00,87.82,171.14
Therefore, it seems need to run multiple times for training to obtain the best results.


Use llvm-objcopy to package Windows binaries

Description
Changes the packaging script to use LLVM binutils. This fixes object files corrupted by using objcopy by using llvm-objcopy instead. While the corrupted files were working fine when using the Visual Studio toolchain they were leading to errors when using the LLVM toolchain.
See https://github.com/firebase/firebase-cpp-sdk/issues/793#issuecomment-1676632194 for details.

Testing
Needs to be run as part of the GitHub actions packaging. I will test builds once they are available.

Type of Change
Place an x the applicable box:

[ ] Bug fix. Add the issue # below if applicable.
[ ] New feature. A non-breaking change which adds functionality.
[x] Other, such as a build process or documentation change.

Notes

Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
Read the contribution guidelines CONTRIBUTING.md.
Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov I hope I made the right changes based on your feedback - if not please let me know. Any chance you could trigger the CI to run with this branch?

I'll go ahead and test the packaging process with these changes. To do that I believe I'll have to copy these changes into a branch within this repo.

Invalid workflow file: .github/workflows/cpp-packaging.yml#L130
The workflow is not valid. .github/workflows/cpp-packaging.yml (Line: 130, Col: 16): Unexpected symbol: '['. Located at position 43 within expression: matrix.tools_platform == 'darwin' && join(['-', env.xcodeVersion]) || ''

Thanks for checking – can you try again with the latest changes now please?

OK, here goes: https://github.com/firebase/firebase-cpp-sdk/actions/runs/6190110457

Fixed a missing quote, round 2: https://github.com/firebase/firebase-cpp-sdk/actions/runs/6190946332

Thanks @jonsimantov! I tried the build and it works great for me using the LLVM toolchain.
One thing I noticed is that the firebase_cpp_sdk_windows.zip artifact itself contains another ZIP file, but I don’t think that stems from these changes?

Unfortunately, the integration tests failed to build against the newly packaged SDK on Windows.
I've attached the log file.
8_Build integration tests.txt

Hmm ok, so the issue here is all these error LNK2001: unresolved external symbol errors, right? Any idea how they could be caused by this change?
Is this also a new issue: Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed?

@aganea would you be able to take a look at these errors? Unfortunately I’m a bit lost about how this change might be causing them.

I rebased the branch onto the latest main.
@jonsimantov could you please run the tests once more to see if these linker errors are still happening? 🙏

It's still failing to link. Log attached:
8_Build integration tests.txt

Thank you @jonsimantov! It seems like the packaged library is missing a bunch of symbols.
Since the -L flag we’re adding in this patch is also making the packaging script use llvm-nm and llvm-ar (in addition to llvm-objcopy), I’m wondering if those are somehow behaving differently to cause this. Do they require some extra flags maybe – any idea @aganea?
Here is the same log without timestamps as well as the one from the latest run off the main branch for comparison:

8_Build.integration.tests-llvm.txt
8_Build integration tests-main.txt

The Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed is also present in the latest run and thus not a new issue.


Write checks for each thing listed in a spreadsheet

This is the list;

[ ] Col C is out of date - Mikhail made a 2nd tab, but I didn't review which things are implemented, As you look at the test code, please bring col C up to date.
[ ] write python checks for all tests listed in the lint tool document
[ ] write python checks for all tests listed in the lint tool spreadsheet
[ ] https://github.com/xen/fontbakery/issues/69 has a test in it to be brought into the codebase

Next action is for me to check on status of this

I think that is still the case.

@davelab6 Should we drop this one as deprecated? Or move it to a future milestone (waiting feedback) ?

Moving to a future milestone.

This issue is 5 years old. Is it still relevant, @davelab6 ?

Seems no real desire for it. ;-)


Reporter cannot be consumed from an env var

When using MARATHON_REPORTER_GRAPHITE... in the environment file, we could not get the reporter to start sending data. When we changed to a command-line flag, the reporting started working.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-1719. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


adding kdb to languages.yml and samples/kdb

for a collection of kdb repositories see:
http://kxsystems.github.io
http://code.kx.com/q/github/
sample search for in the wild repositories:
user:AquaQAnalytics extension:q
user:psaris extension:q
the colour choice is used on kx.com and code.kx.com, we've used it or a similar dark blue since the early '90's.

Thanks for the new PR, though you could have carried on in the original 😃
Your test failure is due to your colour choice:
  1) Failure:
TestColorProximity#test_color_proximity
[/home/travis/build/github/linguist/test/test_color_proximity.rb:21]:
The following 1 languages have failing color thresholds. Please modify the hex color.
- kdb (#0070CD) is too close to ["4A76B8", "3572A5", "0070CD"]

You've been pipped on the colour choice by other languages.  You're going to need to tweak the colour choice to make it more distinct.
My only other concern with this PR is the prevalence of the .q and .k extensions (there are tons of 'em) which are not currently classified are most definitely not kdb and this could result in those being incorrectly identified.

that’s pretty difficult - there are 214 unique colours in languages.yml
already
couple that with this test complaining about ”color proximity” and I could
be here for a while
trying to find one of the last remaining dark blues that’s not also ”near”
one in use.
(existing duplicates: color:"#28431f” and color:"#e4cc98”)
Do you have a list of unused colours that are also not near any existing?
If so I could pick one of the last
remaining dark blues from there
the .k and .q extension frequency - I can see that could be a problem. How
have you dealt with this in the
past? Quite a lot of them may well be ours - but for sure not all. There’s
no other easy test I can think
of - we don’t, for example start every file with a hash-bang, or have some
common construct like #include
On 25 May 2017 at 10:41, Colin Seymour<EMAIL_ADDRESS>wrote:

Thanks for the new PR, though you could have carried on in the original 😃
Your test failure is due to your colour choice:

Failure:
TestColorProximity#test_color_proximity
[/home/travis/build/github/linguist/test/test_color_proximity.rb:21]:
The following 1 languages have failing color thresholds. Please modify the hex color.

kdb (#0070CD) is too close to ["4A76B8", "3572A5", "0070CD"]

You've been pipped on the colour choice by other languages. You're going
to need to tweak the colour choice to make it more distinct.
My only other concern with this PR is the prevalence of the .q and .k
extensions (there are tons of 'em) which are not currently classified
are most definitely not kdb and this could result in those being
incorrectly identified.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/github/linguist/pull/3638#issuecomment-303956438, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA1FQiuvJl7THN2NF8JXNaxS1H1K-tehks5r9T6kgaJpZM4Nk0QG
.

Sorry about the delay in getting back to you @simongarland.
I understand your frustration surrounding picking a colour... how about using the colour proposed in
https://github.com/github/linguist/pull/3659 which has since been opened for "q" which appears to be the same as what you're including here. (I've suggested that PR be closed in favour of this one).

the .k and .q extension frequency - I can see that could be a problem. How
have you dealt with this in the
past?

I'm not sure, but have raised the same concern, and a possible solution (use a heuristic with a fallback to "Text") in https://github.com/github/linguist/pull/3689#pullrequestreview-47059649. Will see what others suggest.
If we do go this route, we'll need to come up with a good reliable way of identifying kdb files.

that colour choice in #3659 would be fine
recognising kdb files isn’t easy as there’s nothing like a hash-bang at the
beginning, but there is something
easy to do that would pick up 99.x% of the files. Any .k or .q file is
going to contain function definitions and
that means almost all of them will match the string ”:{[” - that’s assign a
value ”:”, followed by open
function definition ”{”, followed by open argument definition ”[”
an example being:
plus:{[x;y] x+y}
I’m not sure how that’d fit in with your framework, but it should be
easier/faster than a regex to match
On 30 June 2017 at 10:44, Colin Seymour<EMAIL_ADDRESS>wrote:

Sorry about the delay in getting back to you @simongarland
https://github.com/simongarland.
I understand your frustration surrounding picking a colour... how about
using the colour proposed in
#3659 https://github.com/github/linguist/pull/3659 which has since been
opened for "q" which appears to be the same as what you're including here.
(I've suggested that PR be closed in favour of this one).
the .k and .q extension frequency - I can see that could be a problem. How
have you dealt with this in the
past?
I'm not sure, but have raised the same concern, and a possible solution
(use a heuristic with a fallback to "Text") in #3689 (review)
https://github.com/github/linguist/pull/3689#pullrequestreview-47059649.
Will see what others suggest.
If we do go this route, we'll need to come up with a good reliable way of
identifying kdb files.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/github/linguist/pull/3638#issuecomment-312211693, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA1FQiiSg7m8q3bIgpJg26ZK08l-vAGuks5sJLV3gaJpZM4Nk0QG
.

Sorry for fueling a trivial discussion, but as an author of PyQ (Python for kdb+), I have a project that will be affected by a conflict between q and Python color codes.
While 0040cd passes test/test_color_proximity.rb, it is still fairly close to Python's #3572A5 color:

I would propose using something like #050cb5 instead:

I checked that #050cb5 passes the proximity test by running
$ bundle exec rake test TEST=test/test_color_proximity.rb
Run options: --seed 16421
# Running:
.
Finished in 0.792886s, 1.2612 runs/s, 1.2612 assertions/s.
1 runs, 1 assertions, 0 failures, 0 errors, 0 skips

With respect to language detection issue, I don't see why resolving it should be a blocker for accepting this PR. Can we start by registering .kdb extension for the k language and .kdb+ for q?  Individual projects can always add *.k and *.q to custom overrides.  See  #3792.

@simongarland...

easy to do that would pick up 99.x% of the files. Any .k or .q file is
going to contain function definitions and
that means almost all of them will match the string ”:{[” - that’s assign a
value ”:”, followed by open
function definition ”{”, followed by open argument definition ”[”
an example being:
plus:{[x;y] x+y}
I’m not sure how that’d fit in with your framework, but it should be
easier/faster than a regex to match

Ooo, you might be onto something here. Looking at the examples in this PR,  https://github.com/github/linguist/pull/3659 and https://github.com/github/linguist/pull/3820, I can see that basic format in all of them, except your sudoku.k sample. This is definitely something that can be used for a heuristic.
A quick bit of testing with /^\w+:{[^\[]+\[/ matches all the .k and .q files, except your sudoku.k sample, included in the three PRs with only one false positive being samples/JavaScript/jquery-1.4.2.min.js which wouldn't ever get to the heuristic for .k or .q files.
This is definitely "close enough" and you can easily override your sudoku.k once this lands.
Wanna have a go at implementing a heuristic using this?
@abalkin...

Sorry for fueling a trivial discussion, but as an author of PyQ (Python for kdb+), I have a project that will be affected by a conflict between q and Python color codes.

Hmmm, I'm not sure this is going to have that much of an impact; the colours are quite distinct and there are already several other languages with colours closer than this project. As I mentioned in https://github.com/github/linguist/pull/3815, blue is incredibly popular so conflicts will happen and whilst we may be able to accommodate you now (it's up to @simongarland and @dstrachan) we almost certainly won't be able to in future as the availability of shades of blue dwindles.

Not sure where my mind was yesterday but don't worry about the heuristics I suggested... this isn't going to help as they only come into play when there are two or more identified languages with the same extension.

closing, superseded by psaris' request #3820


feat: added new user flag

Please describe the changes this PR makes and why it should be merged:
Reference Discord API Docs PRs or commits:

https://github.com/discord/discord-api-docs/pull/3903

The upstream pull request has landed


[powershell] 7.3.0 released

Not listed here: https://learn.microsoft.com/en-us/lifecycle/products/powershell
But released on GitHub: https://github.com/PowerShell/PowerShell/releases?after=v7.1.3
Keeping in draft till EOL is confirmed.

@captn3m0 can we also add correct archor links for changelogtemplate ?
looks like they are using
https://github.com/PowerShell/PowerShell/blob/master/CHANGELOG/`releaseCycle`.md#`latest(withoutDots)`---`latestReleaseDate`
format, For example :
https://github.com/PowerShell/PowerShell/blob/master/CHANGELOG/7.3.md#730---2022-11-08
https://github.com/PowerShell/PowerShell/blob/master/CHANGELOG/7.2.md#727---2022-10-20

I am merging this and will open a new pr to fix changelogtemplate @captn3m0


This package is breaking our production build

I'll try to explain this the best I can.
When we build/deploy our app in "production" environment, somehow a webpack minification of our entire app gets triggered (essentially minifying our app twice along with ember-cli-uglify and causing severe bugs in production). The only dependency we have in our app that pulls in webpack is this one. So if I remove this dependency from our app everything works great (except auth obviously).
Not sure what this addon needs webpack for ideally it'd just be removed and that would be handled like every other ember-cli addon gets handled.
I tried forking the repo and doing that myself but running into some other issues with that so maybe someone here knows better how I can solve that or how to provide a solution to this.

Webpack is used to bundle Auth0.js and Lock (neither of which are ember-cli addons) -- we're using ember-auto-import to do that, which certainly shouldn't be doing what you're seeing*.
I'm not sure how much help I'm going to be on this -- this repo basically ties a couple of black boxes together and hopes they play well together -- but at the very least, which version do you have installed? There's been a few changes in the 4.2.0 alphas, so it may be worth trying that, just in case.
(*By that, I mean "something's buggy," not "you're seeing things." :P )

I've been on 4.2.0-beta1. I think this bug was introduced in 4.2.0. This has been happening for us ever since I updated this package last fall and I just realized and figured out this was the issue 😬 so I'm sure this must be happening to others who also may not have noticed yet either. I'll have some more time this week to play around with it and really see where it's coming from. In the meantime I've just set my ember-build settings to run the uglify for dev builds and build development always.
Just so I understand though how this is intended to work, is that webpack build supposed to run when I run ember build on my project? and it's only supposed to build auth0.js and Lock right?

I know this is a relatively stale issue and I'm not really sure how to go about tracking it down/figuring it out. I notified there's definitely some issues after upgrading ember-auto-import (in the host app) past 1.3.0 and upgrading this package beyond 4.2.0-beta.4.
I'm sure there's probably some configuration stuff that I can try to dig into shortly.


Support Neo4j 4.x

[x] build (without tests) passes
[x] tests pass
[x] CI pipeline is up-to-date
[x] manually tested against an actual Neo4j 4.x instance
[x] documentation for Liquigraph 4.x is ready (including the start page version matrix)

Note this won't be released before the JDBC driver is.

@sey FYI, I got the build to pass (without running tests) on my fork's 4.x branch: https://github.com/fbiville/liquigraph/tree/4.x
It uses the latest JDBC Driver 4.x "snapshot", Neo4j 4.0 and JDK 11 as baseline.
I haven't checked the test failures yet and not ran Liquigraph against a Neo4j 4.x DB yet either.

4.x branch created.
We'll do the following changes once Liquigraph 4 goes GA:

master -> 3.x
4.x -> master

http://www.liquigraph.org/4.x/index.html is published.

And 4.0.0 is out.


Include only necessary fonts for target environment specified by Browserslist

Fixes #1667.
+ Allow WOFF and WOFF2 to be controlled using environment variables like TTF (USE_TTF)
Environment variables will override target environment.
Uses caniuse data to detect support. No additional dependencies are required, as they are already included in other dependencies.

Test failures are due to the same issue in #1648, which'll be fixed by #1658.

@kevinbarabash There was a bug in #1595, where Browserslist config is not read even if isESMBuild is false. Also, I've upgraded uglifyjs-webpack-plugin to terser-webpack-plugin, to be able to minify ES6 output.

Codecov Report

Merging #1674 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1674   +/-   ##
=======================================
  Coverage   93.66%   93.66%
=======================================
  Files          80       80
  Lines        4653     4653
  Branches      807      807
=======================================
  Hits         4358     4358
  Misses        261      261
  Partials       34       34

Flag
Coverage Δ

#screenshotter
88.85% <ø> (ø)
:arrow_up:

#test
84.99% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64745b5...e388fdd. Read the comment docs.


Point Cloud Extension

Define metadata extension for point cloud data.

Consider adding the following as point-cloud specific metadata:

System Identifier | usually the name of the sensor   used
Generating Software | (part of provenance?)
HasRGB | each point has an RGB value
Classification Codes | list of classes that the points are assigned to (ground,   vegetation etc.) - does each class have additonal metadata (akin to bands)?

Renamed issue title to 'extension' to be in line with https://github.com/radiantearth/stac-spec/pull/189 (OGC people define 'profile' as a subset, so it was even more confusing than I had thought).

@hobu - we'd like to get at least a placeholder for a STAC content extension for point clouds, to start to garner some expert feedback to evolve it. Any advice on additional point cloud metadata we should start with?

@hgs-msmith - would be great to make a PR for this. It does occur to me that for extensions we should maybe have some 'maturity' classification. Can perhaps be self selected, but would be good to make it clear that this extension isn't as fleshed out as the EO one in some obvious way...

We'll get some content for you on this in a few days. To be clear, this extension is about point cloud -specific content, not generics like SRS, BBOX, processing lineage, etc? Those are all taken care of by STAC, correct?
Here's a pdal info --all dump of a file for some metadata flavor of ASPRS LAS content.
autzen.json.txt

Awesome.
I wouldn't say all of those are taken care of by STAC yet. BBOX certainly, and we're putting in a very basic provenance thing in #179 For SRS we have an EPSG code in the EO profile, which we're going to make satellite specific. Idea is to get #156 and this and #149 and then pull up the common ones.
So do whatever is easier for you - put in everything and we can make recommendations for our 'common' ones. Or just assume some common stuff and let us know what they are.
I'll also try to check out the pdal dump.

@hobu Also, if you haven't already it's good to take a look at the EO extension, https://github.com/radiantearth/stac-spec/blob/master/extensions/stac-eo-spec.md and use the smae terms here where they are applicable to point clouds.

heres an attempt I made. I looked at the eo: extension pattern - but more or less dumped most of the point cloud stuff into ‘properties’, without thinking too hard about what could be extracted as ‘point cloud specific’; or ‘what point cloud extension attributes should exist that I don’t use'
{'id': 'somerandomisedID',
 'bbox': {'X': {'max': 661999.99, 'min': 660000},
  'Y': {'max': 6055999.99, 'min': 6054000.01},
  'Z': {'max': 1751.554, 'min': 1314.028}},
 'geometry': {'type': 'MultiPolygon',
  'coordinates': [[[[660016.09887684, 6053987.12779143],
     [662008.76960815, 6053992.85151772],
     [662008.76960815, 6056007.60317026],
     [659999.57590229, 6056007.60317026],
     [659996.27130738, 6053998.575244],
     [660016.09887684, 6053987.12779143]]]]},
 'crs': 'somerandomisedID',
 'type': 'feature',
 'properties': {'srs': {'horizontalCRS': 'PROJCS["GDA94 / MGA zone 55",GEOGCS["GDA94",DATUM["Geocentric_Datum_of_Australia_1994",SPHEROID["GRS 1980",6378137,298.257222101,AUTHORITY["EPSG","7019"]],TOWGS84[0,0,0,0,0,0,0],AUTHORITY["EPSG","6283"]],PRIMEM["Greenwich",0,AUTHORITY["EPSG","8901"]],UNIT["degree",0.01745329251994328,AUTHORITY["EPSG","9122"]],AUTHORITY["EPSG","4283"]],UNIT["metre",1,AUTHORITY["EPSG","9001"]],PROJECTION["Transverse_Mercator"],PARAMETER["latitude_of_origin",0],PARAMETER["central_meridian",147],PARAMETER["scale_factor",0.9996],PARAMETER["false_easting",500000],PARAMETER["false_northing",10000000],AUTHORITY["EPSG","28355"],AXIS["Easting",EAST],AXIS["Northing",NORTH]]',
   'verticalCRS': '',
   'units': {'horizontal': 'metre', 'vertical': ''}},
  'ASPRSclasses': ['1.000000/25149',
   '2.000000/5014547',
   '3.000000/7792544',
   '4.000000/9477524',
   '5.000000/23191982',
   '7.000000/958',
   '18.000000/309'],
  'datetime': 'LASdateTime',
  'LASformat': {'majorVersion': 1, 'minorVersion': 4, 'dataformatID': 3},
  'numberOfPoints': 45503013,
  'area': 4054684.277,
  'density': 11.22233197},
 'assets': {'sourceFile': '/Volumes/Antares/ACT-lidar/all_rgb/ACT2015_4ppm-C3-AHD_6606054_55.laz',
  'waveformFile': 'pathToWaveformDataIfExisting',
  'octree': 'pathToOctree',
  'sourceMetadata': 'pathToSourceMetadata’}}

Looking at what might become a pc: attribute here, there are a bunch of candidates to consider  -point density, number of points, vertical CRS,ASPRSclasses. I’m sure many more exist.
I made this with a catalogue of LAS/LAZ tiles in mind - and using the asset:octree attribute to point at where, say, an entwine index or potree containing this tile might exist. I haven’t considered the inverse case - I suppose an array of tile paths could be listed as assets if the entry here described an entwine index, as something like assets:tilepaths
This is mashed together from bunch of PDAL metadata calls and pretty ugly working parts ( https://gist.github.com/adamsteer/67feb3f4c34310be65154b5fcd7a24f7 ) - I haven’t looked at the case of ‘not using PDAL to extract metadata’ yet.
Hope that helps! I’ll be more or less ticking away at this over the next month and hoping to mint something we can commit to indexing lots of tiles (or a few octrees, or some mix of both) pretty soon!

I took another swing at this. Thanks for the inspiration @adamsteer.
It raises the following questions:

I see https://github.com/radiantearth/stac-spec/blob/master/extensions/stac-eo-spec.md has an eo:epsg entry. For point clouds we need both horizontal and vertical coordinate system information. I have expressed this as pc:compound_srs, but I wonder if we should have a higher-level SRS information. Also, not all EO has EPSG codes cough Mars cough

The document makes it clear that thumbnails are really useful. These are creatable for point clouds too, as long as we're talking about 2D rasterizations. Is there a standard thumbnail size/resolution?

Why is id and description under the c namespace but provider and license are not (or vice versa)?
  "c:id": "L1T",
  "c:description": "Landat 8 imagery that is ...",
  "provider": "USGS",
  "license": "PDDL-1.0",

Here's my python that takes a pdal info --all response and emits STAC:
#!/usr/bin/env python

import sys
import json
import os

data = sys.stdin.read()
#with open('ak.json','rb') as d:
#    data = d.read()

j = json.loads(data)

def capture_date(pdalinfo):
    import datetime
    year = pdalinfo['metadata']['creation_year']
    day = pdalinfo['metadata']['creation_doy']
    date = datetime.datetime(int(year), 1, 1) + datetime.timedelta(int(day) - 1)
    return date.isoformat('T')

def convertGeometry(geom, srs):
    import ogr
    import osr
    in_ref = osr.SpatialReference()
    in_ref.SetFromUserInput(srs)
    out_ref = osr.SpatialReference()
    out_ref.SetFromUserInput('EPSG:4326')

    g = ogr.CreateGeometryFromJson(json.dumps(geom))
    g.AssignSpatialReference(in_ref)
    g.TransformTo(out_ref)
    return json.loads(g.ExportToJson())

output = {}

try:
    output['geometry'] = convertGeometry(j['boundary']['boundary_json'],j['metadata']['comp_spatialreference'])
except KeyError:
    output['geometry'] = j['stats']['bbox']['EPSG:4326']['boundary']

output['bbox'] = j['stats']['bbox']['EPSG:4326']['bbox']
output['id'] = os.path.basename(j['filename'])
output['type'] = 'Feature'

assets = {}
#assets['thumbnail'] =
properties = {}

properties['pc:schema'] = j['schema']
properties['c:id'] = j['metadata']['system_id']
properties['c:description'] = "USGS 3DEP LiDAR"
properties['provider'] = "USGS"
properties['license'] = 'LICENSE'
properties['pc:schema']['statistics'] = j['stats']['statistic']
properties['pc:type'] = 'lidar' # matched-imagery, lidar, radar,
properties['pc:avg_pt_per_sq_unit'] = j['boundary']['avg_pt_per_sq_unit']
properties['pc:density'] = j['boundary']['density']
properties['pc:compound_srs'] = j['metadata']['comp_spatialreference']
properties['pc:count'] = j['metadata']['count']
properties['pc:software_id'] = j['metadata']['software_id'].strip()

properties['pc:encoding'] = 'LASzip' if bool(j['metadata']['compressed']) else 'None'

properties['pc:units'] = j['metadata']["srs"]["units"]

properties['datetime'] = capture_date(j)

output['properties'] = properties
output['assets'] = assets

sys.stdout.write(json.dumps(output,sort_keys=True,
                  indent=4, separators=(',', ': ')))

This ends up looking like:
{
    "assets": {},
    "bbox": {
        "maxx": -149.2527639,
        "maxy": 61.78936655,
        "maxz": 1981.200833,
        "minx": -149.3006585,
        "miny": 61.76668361,
        "minz": 11.48480563
    },
    "geometry": {
        "coordinates": [
            [
                [
                    [
                        -149.30045496703195,
                        61.76682620765713
                    ],
                    [
                        -149.25327277445712,
                        61.76657763000873
                    ],
                    [
                        -149.25272374552367,
                        61.78921108684322
                    ],
                    [
                        -149.30023535632952,
                        61.7894132390075
                    ],
                    [
                        -149.30080489041393,
                        61.766924315502195
                    ],
                    [
                        -149.30045496703195,
                        61.76682620765713
                    ]
                ]
            ]
        ],
        "type": "MultiPolygon"
    },
    "id": "AK_MatanuskaSusitna-Lot2_2011_000227.laz",
    "properties": {
        "c:description": "USGS 3DEP LiDAR",
        "c:id": "MODIFICATION                   ",
        "datetime": "2013-05-14T00:00:00",
        "license": "LICENSE",
        "pc:avg_pt_per_sq_unit": 3.163692583,
        "pc:compound_srs": "COMPD_CS[\"unknown\",PROJCS[\"NAD83 / Alaska zone 4\",GEOGCS[\"NAD83\",DATUM[\"North_American_Datum_1983\",SPHEROID[\"GRS 1980\",6378137,298.2572221010042,AUTHORITY[\"EPSG\",\"7019\"]],AUTHORITY[\"EPSG\",\"6269\"]],PRIMEM[\"Greenwich\",0],UNIT[\"degree\",0.0174532925199433],AUTHORITY[\"EPSG\",\"4269\"]],PROJECTION[\"Transverse_Mercator\"],PARAMETER[\"latitude_of_origin\",54],PARAMETER[\"central_meridian\",-150],PARAMETER[\"scale_factor\",0.9999],PARAMETER[\"false_easting\",1640416.666666667],PARAMETER[\"false_northing\",0],UNIT[\"US survey foot\",0.3048006096012192,AUTHORITY[\"EPSG\",\"9003\"]],AUTHORITY[\"EPSG\",\"26934\"]],VERT_CS[\"NAVD88 - Geoid09 (Alaska only) (Feet)\",VERT_DATUM[\"unknown\",2005],UNIT[\"US survey foot\",0.3048006096012192,AUTHORITY[\"EPSG\",\"9003\"]],AXIS[\"Up\",UP]]]",
        "pc:count": 64473760,
        "pc:density": 0.9482590115,
        "pc:encoding": "LASzip",
        "pc:schema": {
            "dimensions": [
                {
                    "name": "X",
                    "size": 8,
                    "type": "floating"
                },
                {
                    "name": "Y",
                    "size": 8,
                    "type": "floating"
                },
                {
                    "name": "Z",
                    "size": 8,
                    "type": "floating"
                },
                {
                    "name": "Intensity",
                    "size": 2,
                    "type": "unsigned"
                },
                {
                    "name": "ReturnNumber",
                    "size": 1,
                    "type": "unsigned"
                },
                {
                    "name": "NumberOfReturns",
                    "size": 1,
                    "type": "unsigned"
                },
                {
                    "name": "ScanDirectionFlag",
                    "size": 1,
                    "type": "unsigned"
                },
                {
                    "name": "EdgeOfFlightLine",
                    "size": 1,
                    "type": "unsigned"
                },
                {
                    "name": "Classification",
                    "size": 1,
                    "type": "unsigned"
                },
                {
                    "name": "ScanAngleRank",
                    "size": 4,
                    "type": "floating"
                },
                {
                    "name": "UserData",
                    "size": 1,
                    "type": "unsigned"
                },
                {
                    "name": "PointSourceId",
                    "size": 2,
                    "type": "unsigned"
                },
                {
                    "name": "GpsTime",
                    "size": 8,
                    "type": "floating"
                }
            ],
            "statistics": [
                {
                    "average": 1765797.419,
                    "count": 64473760,
                    "maximum": 1769746,
                    "minimum": 1761544.01,
                    "name": "X",
                    "position": 0,
                    "stddev": 2340.346622,
                    "variance": 5477222.31
                },
                {
                    "average": 2842320.787,
                    "count": 64473760,
                    "maximum": 2846625,
                    "minimum": 2838423.01,
                    "name": "Y",
                    "position": 1,
                    "stddev": 2446.005498,
                    "variance": 5982942.898
                },
                {
                    "average": 3760.301515,
                    "count": 64473760,
                    "maximum": 6499.99,
                    "minimum": 37.68,
                    "name": "Z",
                    "position": 2,
                    "stddev":<PHONE_NUMBER>,
                    "variance": 909205.062
                },
                {
                    "average":<PHONE_NUMBER>,
                    "count": 64473760,
                    "maximum": 255,
                    "minimum": 0,
                    "name": "Intensity",
                    "position": 3,
                    "stddev": 92.00839536,
                    "variance": 8465.544817
                },
                {
                    "average": 1.214258343,
                    "count": 64473760,
                    "maximum": 5,
                    "minimum": 1,
                    "name": "ReturnNumber",
                    "position": 4,
                    "stddev": 0.7263398082,
                    "variance": 0.527569517
                },
                {
                    "average": 1.376616394,
                    "count": 64473760,
                    "maximum": 5,
                    "minimum": 1,
                    "name": "NumberOfReturns",
                    "position": 5,
                    "stddev": 1.070825579,
                    "variance": 1.146667421
                },
                {
                    "average": 0.5003097849,
                    "count": 64473760,
                    "maximum": 1,
                    "minimum": 0,
                    "name": "ScanDirectionFlag",
                    "position": 6,
                    "stddev": 0.4999999683,
                    "variance": 0.2499999683
                },
                {
                    "average": 0.000881211209,
                    "count": 64473760,
                    "maximum": 1,
                    "minimum": 0,
                    "name": "EdgeOfFlightLine",
                    "position": 7,
                    "stddev": 0.02967213003,
                    "variance": 0.0008804353008
                },
                {
                    "average": 17.21186159,
                    "count": 64473760,
                    "maximum": 129,
                    "minimum": 2,
                    "name": "Classification",
                    "position": 8,
                    "stddev": 31.34383656,
                    "variance":<PHONE_NUMBER>
                },
                {
                    "average": 0.3183486119,
                    "count": 64473760,
                    "maximum": 24,
                    "minimum": -22,
                    "name": "ScanAngleRank",
                    "position": 9,
                    "stddev": 9.934022398,
                    "variance": 98.684801
                },
                {
                    "average": 0,
                    "count": 64473760,
                    "maximum": 0,
                    "minimum": 0,
                    "name": "UserData",
                    "position": 10,
                    "stddev": 0,
                    "variance": 0
                },
                {
                    "average": 10733.9377,
                    "count": 64473760,
                    "maximum": 12042,
                    "minimum": 1084,
                    "name": "PointSourceId",
                    "position": 11,
                    "stddev": 3522.808499,
                    "variance": 12410179.72
                },
                {
                    "average": 26389458.29,
                    "count": 64473760,
                    "maximum": 30299322.58,
                    "minimum": -2450342.801,
                    "name": "GpsTime",
                    "position": 12,
                    "stddev": 10532949.21,
                    "variance":<PHONE_NUMBER>00000.0
                }
            ]
        },
        "pc:software_id": "Aero-Metric LASLib",
        "pc:type": "lidar",
        "pc:units": {
            "horizontal": "US survey foot",
            "vertical": "US survey foot"
        },
        "provider": "USGS"
    },
    "type": "Feature"
}

HI @hobu - thanks! I reconfigured my own code to use pdal info —all rather than repeated calls, and will likely borrow some of yours ;)
I need to think harder about how we need the collection/datasets thing to work (thanks @matthewhanson ) - ie what is the logical unit of which all things are children - for example a ‘survey’ (collection/dataset); which has ‘assets’ in STAC parlance of ‘LAS files’; ‘metadata records’; and ‘products’ (for example entwine or Potree derivative datasets, which represent a complete ’survey’ made of all the component files belonging to that survey)
clear as mud, right?

I started on the extension definition at https://github.com/hobu/stac-spec/tree/dev and pared down my fields for Item to the essentials.

Hey @hobu,
thanks, that is a great start. It seems nobody really noticed it so far
I would suggest (updating your branch and) opening a PR so that more people get aware of the extension and can review it. Maybe we can even ask our networks and Twitter folks to comment on it, similar to the SAR extension.
Thanks, Matthias
cc @cholmes

PR made at https://github.com/radiantearth/stac-spec/pull/369

Thanks @hobu - I still think an optional field containing class/label information should be included in the pc: extension. it’s currently an extra pdal info query to get it (pdal info —filters.stats.dimensions=Classification —filters.stats.count=Classification), but IMO worth it. Could be conditional on more than one class appearing in stats.statistics[8], if that item appears at all...

@adamsteer but will you actually search on the classification label information/histogram? That information is slightly expensive to get and not every data source has it.
About your point in chat in regard to a full boundary, PDAL 1.9 pdal info --all will output --metadata, --boundary, and --stats output all at once, and when I make a pdal stac kernel, it will also output the filters.hexbin boundary of the data source.

@hobu yes - anytime I make a point cloud metadata set I will want to search for classifications.
For an example - if I want to make a map of all the tree heights in a region, I want to know whether the source points have appropriate labels and decide whether to use cheaper functions to do the task using existing labels; or develop more expensive processes to label all the points then make a tree height map. Sure, not all datasets have labelled/classified points - but where they do it’s really convenient (IMO) to be able to find out what classes exist and decide what to do next before pulling down data.
The point counts per class are less important (hopefully they’re non-zero) - maybe pc:statistics.labels (or pc:statistics.classes) could contain something like:
{
 “reference”: “ASPRS”
“labels”: [ 0,2,6,7,18,...]
}

...or
{
“reference”:”linktodocument”,
“labels”: [“road”, “cat”, “stopsign”,...]
}

Closing this, as we have the proposal extension merged in dev.


Remove getter/setter methods of statusCode in RouterResponse and instead use a computed property

https://github.com/IBM-Swift/Kitura/tree/develop/Sources/Kitura/RouterResponse.swift#L240-279

Question for this: currently we have code like router.status(.OK).send("foo") all over the place. With this change we'd need to break this up into router.status = .OK; router.send("foo"). Are we ok in making this more verbose?

Oh, good point. I guess not.

Ok well maybe we can do the other changes but keep the status method (although it should probably be renamed to setStatus)

@shmuelk Can you validate this?

Reviewed code. Looks OK.


support iam simulate on iam resources

Clarification:

Is the simulate for custom policies, principal policies, or both?

primary intent was for user, groups, roles. ie can x do y.


"Maximum call stack exceeded" error on iOS Safari

Version: 6.0.7
Steps to reproduce:

open demo on iOS Safari (I'm using an iPhone 6 with iOS 11.4.1)
upload an image
click "Change to 16/9 aspect" button
play around with the resize
notice that page starts freezing up

Using USB debugging on macOS Safari I was able to identify the error as:

RangeError: Maximum call stack size exceeded.

I'm not exactly sure what could be the cause of this, but it seems to me like a classic React infinite render loop so it might be related to componentDidUpdate.

Thanks @tudorpavel, I was afraid of this after I made the update there. I will see if I can see why but otherwise I have an idea to change that code to make it safer.

Indeed, it's most likely a regression caused by the fix for #206. I cannot reproduce this issue on version 6.0.4.

Fixed in 6.0.8


Stream mode causes ERROR 500 - Internal Server Error!

Hello, I've noticed there's a problem when using STREAM mode. I receive HTTP 500 ERROR when activating STREAM mode.
Debian version 11.3
PHP version : 7.4.29
Crowdsec version :  1.4.3
WP Crowdsec plugin :  1.10.0
Wordpress version : 6.1.1
I've changed the port for crowdsec in /etc/crowdsec/config.yaml in 8888 because 8080 is already used.
This issue is happening with / without the option "Use cURL to call Local API"
With Use cURL to call Local API enabled I have this in my logs.
The Crowdec WP plugin debug.log is:
==> ../../../debug.log <==
[14-Dec-2022 21:46:13 UTC] PHP Fatal error:  Uncaught CrowdSecBouncer\BouncerException: Unexpected CURL call failure: Operation timed out after 1000 milliseconds with 0 bytes received in /var/www/clients/client0/web24/web/blog/wp-content/plugins/crowdsec/vendor/crowdsec/bouncer/src/RestClient/Curl.php:35
Stack trace:
#0 /var/www/clients/client0/web24/web/blog/wp-content/plugins/crowdsec/vendor/crowdsec/bouncer/src/ApiClient.php(94): CrowdSecBouncer\RestClient\Curl->request()
#1 /var/www/clients/client0/web24/web/blog/wp-content/plugins/crowdsec/vendor/crowdsec/bouncer/src/ApiCache.php(181): CrowdSecBouncer\ApiClient->getStreamedDecisions()
#2 /var/www/clients/client0/web24/web/blog/wp-content/plugins/crowdsec/vendor/crowdsec/bouncer/src/Bouncer.php(299): CrowdSecBouncer\ApiCache->warmUp()
#3 /var/www/clients/client0/web24/web/blog/wp-content/plugins/crowdsec/inc/admin/advanced-settings.php(21): CrowdSecBouncer\Bouncer->warmBlocklistCacheUp()
#4 /var/www/clients/client0/web24/web/blog/wp-content/plugins/crowdsec/inc/admin/init.php(248): {closure}()
#5 /v in /var/www/clients/client0/web24/web/blog/wp-content/plugins/crowdsec/vendor/crowdsec/bouncer/src/RestClient/Curl.php on line 35

The /var/log/crowdsec.log show:
==> /var/log/crowdsec.log <==
time="14-12-2022 23:46:13" level=warning msg="client <IP_ADDRESS> disconnected : write tcp <IP_ADDRESS>:8888-><IP_ADDRESS>:51036: write: broken pipe"

The /var/log/crowdsec_api.log shows:
==> /var/log/crowdsec_api.log <==
time="14-12-2022 23:46:13" level=info msg="<IP_ADDRESS> - [Wed, 14 Dec 2022 23:46:13 EET] \"GET /v1/decisions/stream?startup=true&scopes=Ip%2CRange HTTP/1.1 200 1.316249051s \"WordPress CrowdSec Bouncer/v1.10.0\" \""

With With Use cURL to call Local API disabled I have this in my logs:
The Crowdec WP plugin debug.log is:
==> ../../../debug.log <==
[14-Dec-2022 21:54:58 UTC] PHP Warning:  file_get_contents(http://<IP_ADDRESS>:8888/v1/decisions/stream?startup=true&scopes=Ip%2CRange): failed to open stream: HTTP request failed! in /var/www/clients/client0/web24/web/blog/wp-content/plugins/crowdsec/vendor/crowdsec/bouncer/src/RestClient/FileGetContents.php on line 50
[14-Dec-2022 21:54:58 UTC] PHP Fatal error:  Uncaught CrowdSecBouncer\BouncerException: Unexpected HTTP call failure. in /var/www/clients/client0/web24/web/blog/wp-content/plugins/crowdsec/vendor/crowdsec/bouncer/src/RestClient/FileGetContents.php:52
Stack trace:
#0 /var/www/clients/client0/web24/web/blog/wp-content/plugins/crowdsec/vendor/crowdsec/bouncer/src/ApiClient.php(94): CrowdSecBouncer\RestClient\FileGetContents->request()
#1 /var/www/clients/client0/web24/web/blog/wp-content/plugins/crowdsec/vendor/crowdsec/bouncer/src/ApiCache.php(181): CrowdSecBouncer\ApiClient->getStreamedDecisions()
#2 /var/www/clients/client0/web24/web/blog/wp-content/plugins/crowdsec/vendor/crowdsec/bouncer/src/Bouncer.php(299): CrowdSecBouncer\ApiCache->warmUp()
#3 /var/www/clients/client0/web24/web/blog/wp-content/plugins/crowdsec/inc/admin/advanced-settings.php(21): CrowdSecBouncer\Bouncer->warmBlocklistCacheUp()
#4 /var/www/clients/client0/web24/web/blog/wp-content/plugins/crowdsec/inc/admin/init.php(248): {closure}()
#5 /var/www/clients/client0/web24/web/blog/wp-inc in /var/www/clients/client0/web24/web/blog/wp-content/plugins/crowdsec/vendor/crowdsec/bouncer/src/RestClient/FileGetContents.php on line 52

curl on http://<IP_ADDRESS>:8888 shows:
curl "http://<IP_ADDRESS>:8888/v1/decisions/stream?startup=true&scopes=Ip%2CRange"
{"message":"access forbidden"}

I assume it's normal, because it's expecting a header with the bouncer key.
Can you give me an example of a curl request with all the needed headers to query in STREAM mode ?
I assume the response it gets is different from what is expected.
Test your settings -> Test bouncing works.
I've tried Bouncing level Normal / Flex, no change.
I've tried caching with Filesystem / Redis, still no change.
I've deleted and recreated the bouncer API key, still no change.

I've tested older versions of the plugin 1.9.0 and 1.8.0, they behave the same, with 500 Error.
I think the response for the GET /v1/decisions/stream?startup=true&scopes=Ip%2CRange is different now (or maybe bigger)
I found in the documentation how to query the API, this is the response header
curl  -s -H "X-Api-Key: ***"  http://localhost:8888/v1/decisions/stream\?startup\=true | jq . | more
{
  "deleted": [
    {
      "duration": "-165h28m44.900234679s",
      "id": 40293718,
      "origin": "CAPI",
      "scenario": "crowdsecurity/http-open-proxy",
      "scope": "Ip",
      "type": "ban",
      "value": "<IP_ADDRESS>"
    },
    {
      "duration": "-165h28m44.900255228s",
      "id": 40293719,
      "origin": "CAPI",
      "scenario": "crowdsecurity/http-backdoors-attempts",
      "scope": "Ip",
      "type": "ban",
      "value": "<IP_ADDRESS>"
    },
...

Hi,
Thanks for your message.
I just tested with quite the same conditions (php 7.4, crowdsec 1.4.3, WP 6.1.1 and plugin 1.1.10) and was unable to reproduce.
I guess there is something with the custom port, but we'll have to investigate a little bit. (I did not try with a custom port for now)
Just for information, when you activate the stream mode, the cache has to be warm up : this is why there is an automatic call to the
v1/decisions/stream\?startup=true URI. But in your case, it seems that this call fails, and we have to find out why ...
First thing I notice is that your direct curl test use the http://localhost URL, while it seems that the URL in the plugin is set to http://<IP_ADDRESS> : Could you please try to set http://localhost in the plugin too ? I see no reason why it could be an issue, but it is worth checking, I guess.
The other question I have would be ; does it work when the Stream mode is NOT enabled (a.k.a. live mode) ? (you could look the debug.log to see is all works as expected). It would be very strange if it works in live mode but not in stream mode as the same kind of call are made.
Last thing, I see a strange line in your /var/log/crowdsec.log : write tcp <IP_ADDRESS>:8888-><IP_ADDRESS>:51036 : does it mean that you have some kind of redirect from port 8888 to port 51036 ? Maybe this is not important, but I am just trying to understand.
Thanks
p.s :

Test your settings -> Test bouncing works.

Please be sure to save the settings before clicking the 'Test' button, as only the saved settings are tested.

Hi,
I just found that you maybe have to modify 2 files if you need a custom port :  https://github.com/crowdsecurity/crowdsec/issues/552#issuecomment-1185361489
I am not sure if this comment is up-to-date, but maybe your bug is related. Could you check if the /etc/crowdsec/local_api_credentials.yaml is also modified ?
Thanks

Hi,
If you remember, i am the one that tested crowdsec with multiple wordpress sites and the same redis DB, with stream mode. This is the same server, that received only Debian / ISPConfig updates.
First :/etc/crowdsec/local_api_credentials.yamlhas also port 8888 changed in it.
Second : changing localhost with <IP_ADDRESS> makes no difference.
Third : /var/log/crowdsec.log : write tcp <IP_ADDRESS>:8888-><IP_ADDRESS>:51036. 51036 is the source port for the request. It's made from localhost:51036 to localhost:8888. Because of the error, I assume PHP tries to respond but the connection is now closed. I can see port numbers in the logs, in netstat briefly.
Fourth : In LIVE mode, all works OK. I can see it in the logs.
I have outputed the result of the curl in a file, it it 5.2MB large. I assume it's normal.
curl  -s -H "X-Api-Key: ********"  http://localhost:8888/v1/decisions/stream\?startup\=true\&scopes\=Ip,Range  > out.txt
I also changed 8080 that ISPConfig uses to another port and used 8888 in the 2 crowdsec config files. Still the same.
Indeed something happens when it needs to warm the cache. I remember that the initial warm took 35 seconds (i had to increase the PHP timeout beyond 30sec). Now it dies after ~2 seconds.

Hi,
thanks for your answers (yes, I remember :) ).
Ok, so it seems that your issue is due to the size of the decisions you retrieve on warm up : maybe it takes too much time (timeout issue) or this is really a response size issue.
Considering the timeout, could you please try to edit manually a file in the plugin sources ?
We will try to increase the timeout value for Curl (so you will have to test with Use Curl set to true).
To do that, please look at the file vendor/crowdsec/bouncer/src/RestClient/Curl.php and, starting at line 109, replace :
if ($this->timeout > 0) {
    $options[\CURLOPT_TIMEOUT] = $this->timeout;
}

by
//if ($this->timeout > 0) {
      $options[\CURLOPT_TIMEOUT] = XX;
//}

where XX could be 30, or 60, or more (this the timeout value in seconds).
Hope it could resolve your issue : if yes, I will add a configuration setting for a custom timeout. If not, I will have to manage how to handle response with big size like (e.g > 5MB)
Please, let me know.
Thanks

Nice,
Can you tell me with which value of timeout you succeed ? And maybe how many times it takes between the "START_CACHE_WARMUP" and "CACHE_WARMED_UP" if you look at the debug.log file (just before the 2 lines you pasted).
To test without Use Curl, you should modify another file : vendor/crowdsec/bouncer/src/RestClient/FileGetContents.php
At line 92, you could replace
'timeout' => $timeout ?: $this->timeout,

by
'timeout' => XX,

Well, what I will do now is working on a way to add a new setting lapi_timeout, so that you could modify the value directly in the WordPress admin. I will try to add this in a next release asap.
Thanks

I used 100 as a number of seconds.
It take about 33 seconds.
2022-12-15T12:44:57.900764+00:00|100|{"type":"START_CACHE_WARMUP"}
2022-12-15T12:45:30.005004+00:00|200|{"type":"CACHE_WARMED_UP","added_decisions":28619}
You could add "Warming up the cache took X seconds, after As the stream mode is enabled, the cache has just been warmed up, there are now 28584 decisions in cache."

Hi,
I just released a new 1.11.0 version of the plugin : the timeout can now be modified in settings and the default timeout value has been increased from 1 second to 120 seconds.
Thanks


Portal read + write

@ashley-hebler Obviously still a work in progress, but feel free to poke around at your convenience to see if you hate any of my code.

This is so much work and it's looking super slick. I didn't test functionality a whole lot, but that saved state is a nice solve. I like that the loader pauses you for a bit so you interpret the change.
Anyway I left a few notes, but I didn't speak to any of the Vue commits since you are a wizard in that, while I'm a mere muggle ⚡


Use committed docker.service instead of copying/patching default.

Previously the docker role copied the distributed /usr/lib/systemd/system/docker.service into /etc/systemd/system/ (which overrides the distributed files), then patched it. The intention was to keep abreast of any upstream changes in docker.service.
In practice this just adds complexity, so this commit bundles the full docker.service file to be used. Be aware that if docker is upgraded and /usr/lib/systemd/system/docker.service is changed you will need to merge in changes into roles/docker/files/docker.service.
One consequence of this was that the systemd startup timeout was not modified after an upgrade (TimeoutStartSec=0 in docker.service), which caused the docker daemon startup to timeout on a heavily used system.

Testing based https://github.com/openmicroscopy/infrastructure/pull/58 -- :thumbsup:


List on Artifacthub: add initial artifacthub-repo.yml to claim repository ownership

Part of https://github.com/openzipkin/zipkin-helm/issues/21

approve despite CI unrelated fail

Thanks @codefromthecrypt , I will try to fix the CI shortly, if you don't mind, I will merge this one but there would be more changes (repositoryID, etc), thanks!

thanks for the help and follow-up @reta!


Create a file with an overview of all badge components

Create a Figma file with an overview of all badge components we already have within our products

https://www.figma.com/file/PGb66fVN325tu0IngRka66/Component-Research?type=design&node-id=0%3A1&mode=design&t=bGzvyfUCEodTvI8y-1


Add SSCEP NetKAN metadata to the index

I think the NetKAN file I have remotely hosted is correct. If not, please let me know here and I'll rectify it before this merge.
https://raw.githubusercontent.com/Poodmund/Stock-Scatter-Collider-Enabler-Patch/master/CKAN/SSCEP.netkan

I usually advocate for meaningful identifiers so I can remember them and tell what they are.
Any chance you could call this EnableScatterColliders?

Don't need this for a new mod. Its purpose is to work around versioning hiccups, usually with mods with lots of releases.
    "x_netkan_epoch": "2",

Changed the identifer to 'StockScatterColliderEnablerPatch'. Its important to be explicit in that it ONLY enables the collider meshes for the vanilla instances of ground scatter for the vanilla planets, hence the name.

Works now, thanks for the submission! Merging...

Thanks for the help. :D