Complete conversion of ANTLR Kotlin into ANTLR5

As part of this PR, I updated the copyright notices for all files coming from ANTLR Kotlin. I also updated the files coming from ANTLR4 to specify that the Copyright is extended to the present time.
I then renamed the directory containing the files imported by ANTLR Kotlin but not used, into antlr-kotlin-runtime-remnanets.
Then I renamed the packages used by the ANTLR Kotlin runtime into org.antlr.v5.kotlinruntime.
This PR fix #14 .

The php target seems to fail, but I do not see how I could have caused that

The php target seems to fail, but I do not see how I could have caused that

It couldn't find "composer: command not found". https://github.com/antlr/antlr5/actions/runs/7709758501/job/21011740363#step:4:8
I always put basic sanity checks into the Github Action workflow file after every single toolchain install. I don't trust anything, anyone, ...., nothing at all, forever. So, after https://github.com/antlr/antlr5/blob/79211eaea4dfe74db7b59a851d30696ef76bee23/.github/workflows/hosted.yml#L267, add a step to execute php and composer, do a "whereis", etc., crash on failure. Also, I'm not sure it's best to use version 2.22.0 for the PHP plugin, https://github.com/antlr/antlr5/blob/79211eaea4dfe74db7b59a851d30696ef76bee23/.github/workflows/hosted.yml#L269C13-L269C35 , when it says in the release notes for version 2.23.0 "PHP 8.2 is now stable on setup-php".

Thank you Ken, but I do not understand how my changes caused that specific task to fail, as it seems it was passing before

Thank you Ken, but I do not understand how my changes caused that specific task to fail, as it seems it was passing before

This can happen when something in the GH Actions changes. Happens all the time over in grammars-v4, and it's a pain to understand why. Again, just add some basic sanity check to the workflow file, like this: https://github.com/antlr/grammars-v4/blob/1d96a08da2f5c2b00c3d7f025e8370f7118bbd3f/.github/workflows/main.yml#L69-L72 You'll need to add in a call to composer.
$ composer --version
Composer version 2.4.4 2022-10-27 14:39:29
01/30-07:22:48 ~/antlr5
$ which composer
/c/ProgramData/ComposerSetup/bin/composer
01/30-07:23:02 ~/antlr5
$ whereis composer
composer: /c/ProgramData/ComposerSetup/bin/composer /c/ProgramData/ComposerSetup/bin/composer.bat /c/ProgramData/ComposerSetup/bin/composer.phar
01/30-07:23:07 ~/antlr5
$

Thank you Ken, but I do not understand how my changes caused that specific task to fail, as it seems it was passing before

This can happen when something in the GH Actions changes. Happens all the time over in grammars-v4, and it's a pain to understand why. Again, just add some basic sanity check to the workflow file, like this: https://github.com/antlr/grammars-v4/blob/1d96a08da2f5c2b00c3d7f025e8370f7118bbd3f/.github/workflows/main.yml#L69-L72 You'll need to add in a call to composer.
$ composer --version
Composer version 2.4.4 2022-10-27 14:39:29
01/30-07:22:48 ~/antlr5
$ which composer
/c/ProgramData/ComposerSetup/bin/composer
01/30-07:23:02 ~/antlr5
$ whereis composer
composer: /c/ProgramData/ComposerSetup/bin/composer /c/ProgramData/ComposerSetup/bin/composer.bat /c/ProgramData/ComposerSetup/bin/composer.phar
01/30-07:23:07 ~/antlr5
$

Ok, I just tried doing that. Thank you for the suggestion

Now we have two failures:

the C# tests on MacOs 11 failed: Error:  The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
the PHP tests on MacOs 11 failed (but the PHP tests on other platforms passed). Apparently because composer was not installed. I tried updating the actions used

I am also wondering if we could just remove all these tests for all these targets, as we are not using them anyway

The php target seems to fail, but I do not see how I could have caused that

Let's remove other targets at first (https://github.com/antlr/antlr5/issues/2) to get rid of issues like that.

Legacy targets have been removed, I suggest you rebase this PR.

@ftomassetti  now that legacy targets have been removed, rebasing should eliminate issues unrelated to this PR (except maybe kotlin on mac which seems to frequently fail @KvanTTT ?)

except maybe kotlin on mac which seems to frequently fail @KvanTTT ?

I think it's a problem of GitHub MacOS server, I'm not sure if we can fix it in someway (maybe just turn off testing on MacOS). Also, I'll try to improve Kotlin tests performance later, maybe it will help.

Ok, the tests seems to pass (some of them still running), however there has been some interactions with changes occurred in the meantime, and this PR is doing several things: that and the number of files committed make it very hard to review. So I would rather close this PR and do 2 or 3 separate PRs that get easier to review

First step in replacing this PR: #19


Investigate TravisCI Flakiness

Our CI seems to be flaky yet again. Once we finish up the alpha milestone, we should prioritize diagnosing and fixing this issue so we can handle PR submissions reliably. Possible diagnosis off the top of my head would be that the karma tap reporter is streaming out more than TravisCI or SauceLabs can handle. The tests seem to have gotten flakier as we've added more. We may have to investigate either sharding our tests and running them via a CI matrix, figuring out how to suppress console output without losing vital information such as info on test failures, or - at worst - switching over to a different test framework which can scale out better.

Superceded by https://github.com/material-components/material-components-web/issues/5


feat: Retrieve more info from servers

Any plans to query the servers for info like the player count?
A project for that already exists but it is kinda old and broken. (python-valve)

Not within this project, no. It's really just about collecting and maintaining servers lists.
You can use the library used by GameserverLister directly if you want to query each individual server, see https://github.com/cetteup/pyvpsq. That will give you player numbers etc.

Thx


dyld: Library not loaded: @rpath/Async.framework/Async

  Referenced from: /var/containers/Bundle/Application/
DFF##40C5-DCB0-4554-AF73-559E0947932A/
xxxxxxxxxMarket dev.app/xxxxxxxxxMarket dev
  Reason: image not found
(lldb)

Have you figured this out @sirvon?
Else, reopen and try to provide some actual information on what caused this.

I'm going to have to come back to this in a few days...i'm back on a few Android projects...will update. Thanks!

Have the same issue but only on Simulator with iOS 8 and iPhone 4s (on iOS 8 and iPhone 6 works as expected)
dyld: Library not loaded: @rpath/Async.framework/Async
  Referenced from: /Users/me/Library/Developer/CoreSimulator/Devices/D660734D-BA74-4D38-A896-7DDFF7309048/data/Containers/Bundle/Application/C41D1E76-0249-487D-993C-8092DE1F05AB/MyApp.app/MyApp
  Reason: no suitable image found.  Did find:
	/Users/me/Library/Developer/CoreSimulator/Devices/D660734D-BA74-4D38-A896-7DDFF7309048/data/Containers/Bundle/Application/C41D1E76-0249-487D-993C-8092DE1F05AB/MyApp.app/Frameworks/Async.framework/Async: mach-o, but wrong architecture
	/Users/me/Library/Developer/CoreSimulator/Devices/D660734D-BA74-4D38-A896-7DDFF7309048/data/Containers/Bundle/Application/C41D1E76-0249-487D-993C-8092DE1F05AB/MyApp.app/Frameworks/Async.framework/Async: mach-o, but wrong architecture
	/Users/dmitrysazanovich/Library/Developer/CoreSimulator/Devices/D660734D-BA74-4D38-A896-7DDFF7309048/data/Containers/Bundle/Application/C41D1E76-0249-487D-993C-8092DE1F05AB/MyApp.app/Frameworks/Async.framework/Async: mach-o, but wrong architecture

version about 2.0.2 has same problem, but version about 2.0.1 is ok , the error is image not found , so can you solve the bug ?

@luoganzhi
Sorry about that🙏
I'll submit a fix.

yeah , thank you about that


make entries with legacy class names backwards compatible

fixes the issue where features of akka / pekko that are dependent on the persistence module and will potentially store the class name of an akka / pekko class as a part of the persisted data.

I cleaned it up and followed your suggestion good catch there to replaceFirst. I also realized we need to backport this to the old plugin to support roll backs, see this comment on the issue https://github.com/scullxbones/pekko-persistence-mongo/issues/10

Thanks for the contribution @bdoyle0182 👍
Will release a 1.0.2 containing this fix.

PSA for anyone that might hit the same issue as me: this fix unfortunately doesn't seem to address a similar issue with PersistentFSM snapshots. Here is the interesting part of the stacktrace that shows up in logs:
java.util.NoSuchElementException: None.get
     at scala.None$.get(Option.scala:627)
     at scala.None$.get(Option.scala:626)
     at pekko.contrib.persistence.mongodb.driver.ScalaDriverPersistenceSnapshotter$.deserializeSnapshot(ScalaDriverPersistenceSnapshotter.scala:43)
     at pekko.contrib.persistence.mongodb.driver.ScalaDriverPersistenceSnapshotter.$anonfun$findYoungestSnapshotByMaxSequence$5(ScalaDriverPersistenceSnapshotter.scala:82)

After digging deeper I found out that deserialize call here:
https://github.com/scullxbones/pekko-persistence-mongo/blob/b8127da3598eab0581d4f77cfc57b5c4b4ba6809/scala/src/main/scala/pekko/contrib/persistence/mongodb/driver/ScalaDriverPersistenceSnapshotter.scala#L44
returns:
Failure(java.io.NotSerializableException: Cannot find manifest class [akka.persistence.fsm.PersistentFSM$PersistentFSMSnapshot] for serializer with id [7].)

Which is thrown from https://github.com/apache/incubator-pekko/blob/main/actor/src/main/scala/org/apache/pekko/serialization/Serialization.scala#L246
I will share a workaround if I find one :wink:

Ok, a hacky workaround that I came up with:

Make a copy of org.apache.pekko.persistence.serialization.SnapshotSerializer class from pekko persistence (here called CustomSnapshotSerializer)
In snapshotFromBinary replace the last line with:

    serialization
      .deserialize(snapshotBytes, serializerId, manifest)
      .recover {
        case _: NotSerializableException if manifest.startsWith("akka") =>
          serialization.deserialize(snapshotBytes, serializerId, manifest.replaceFirst("akka", "org.apache.pekko"))
      }
      .get

Register the serializer in the config, something like this:

pekko.actor {
  serialization-identifiers {
    "org.apache.pekko.persistence.serialization.SnapshotSerializer" = -8
    "org.apache.pekko.persistence.serialization.CustomSnapshotSerializer" = 8
  }
  serializers.customSnapshotSerializer = "org.apache.pekko.persistence.serialization.CustomSnapshotSerializer"
  serialization-bindings {
    "org.apache.pekko.persistence.serialization.Snapshot" = customSnapshotSerializer
  }
}

I'm not sure if it makes sense to propose the change from point 2. to the main pekko repo :thinking:


[BOT PR] to update dependencies of istio

This PR will be merged automatically once checks are successful.
none

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: istio-testing
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
b6dbcd8898574f60c800cabb9c5d2f45f8aaa3ff
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
b6dbcd8898574f60c800cabb9c5d2f45f8aaa3ff
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
b6dbcd8898574f60c800cabb9c5d2f45f8aaa3ff
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
b6dbcd8898574f60c800cabb9c5d2f45f8aaa3ff
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
b6dbcd8898574f60c800cabb9c5d2f45f8aaa3ff
link
/test istio-pilot-multicluster-e2e

prow/e2e_pilotv2_auth_sds.sh
b6dbcd8898574f60c800cabb9c5d2f45f8aaa3ff
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Add command to focus and snap at the same time

it's sometimes handy to focus and snap to split two applications side by side

Seems like a cool idea. I wonder if we should just make it more powerful right away though? Something like:
focus [snap] <user.running_applications> <user.window_snap_position> [and]  <user.running_applications> <user.window_snap_position>
I don't entirely like the idea that atm you'd have to remember which of the windows ends up on left vs right, but that said I guess also having simple to say defaults that don't need explicit direction could still be good.
Also I guess this would behave strangely if the focus results in flipping between desktops for the second app. Not sure the existing apis are good enough to deal with that. Not a big deal imo, but just came to mind.

Here is an alternative that I think might be nicer: https://github.com/talonhub/community/pull/1465

Closing in favor of the alternative.


Pre-trained conv layers weight

Could you upload a pre-trained conv layer weights (without fc layer)? Thanks.

You can add an expression self.restorer = tf.saver(self.net.collection[:-6]) before self.saver, and then change self.saver.restore(self.sess, self.weights_file) into self.restorer.restore(self.sess, self.weights_file) to avoid restoring weights from fc layers.

Really thanks for your help.

I met the same problem. But adding these two expressions don't work for the recently updated version of the training code, how to restore the weight file without fc layers now? Thanks!

Just change expression self.restorer = tf.saver(self.net.collection[:-6]) into self.restorer = tf.saver(self.variable_to_restore[:-6]) in the new version of training code.

Thanks for your help. I have successfully trained the model with my own dataset.

@hizhangp I understand , it is answer I need , and , if I just change the some layer ,eg 8th conv layer ,what I should modify  for train from the scratch

@hizhangp  Hello, why hasn't my loss changed from the beginning to the end of training? Do you know what the reason is? Thank you very much!

@hizhangp Hello, why hasn't my loss changed from the beginning to the end of training? Do you know what the reason is? Thank you very much!


Dismissing a dialog by clicking outside inconsistently triggers links outside

Provide a general summary of the issue here
This is likely the same underlying issue as #1513 (and duplicates), but having read that issue and the workaround in #7026 that closed it, I still think there's an open issue with closing popovers by pressing on the overlay (outside the popover).
Basically, if you display a popover in a dialog, and then press a link outside the popover/dialog, you will click the link on Android (and Chrome and Firefox with touch simulation). This is not the same behavior as seen on desktop or iOS, where clicking/pressing outside the popover/dialog first dismisses it.
That is, even without Modal to provide an explicit underlay, there seems to be a modality built into popover/dialog on desktop and iOS, that's not present on Android. The desktop and iOS behavior matches native elements (and IMO, user expectations).
I technically think this is a separate issue from #1513, because #1513 is about elements behind a popup being triggered and the comment by @devongovett about #7026 refers to "the element inside the overlay". This issue is about elements (links) outside the popup and behind the underlay.
🤔 Expected Behavior?
I'm not entirely sure what the expected behavior is.

The native popover element is not modal. If a popover is open, pressing an element outside it triggers a click on that element (see e.g. this basic example from MDN: https://mdn.github.io/dom-examples/popover-api/basic-declarative/).
In many cases though, the popover/dialog is actually modal, especially when it's used as a popout menu. For example, this is the behavior of the native select element.

In React Aria Components, popovers alone or dialogs inside popovers are often demonstrated for popout menus, and you'd expect them to behave like the native versions. For example, the examples on the following pages.

https://react-spectrum.adobe.com/react-aria/Popover.html
https://react-spectrum.adobe.com/react-aria/Select.html
https://react-spectrum.adobe.com/react-aria/DatePicker.html
https://react-spectrum.adobe.com/react-aria/Dialog.html

In these cases, there seems to be a built-in modality to the popover. I think that's expected. It's also how it works on iOS – but not on Android.
(Actually, I just noticed that when I open the ComboBox example on Chrome on Desktop, I can click on the links outside the combo box without dismissing it).
For what it's worth, when you expand the left-hand navigation bar on mobile, there's an underlay covering the rest of the page. Pressing a link behind that underlay will click it, on all devices
😯 Current Behavior
The behavior is easily seen on the component pages for React Aria Components, where there are links on the same page. These are therefore simpler demos than the Storybook.

Select. Try opening the first "Favorite Animal" example, with a link in view (e.g. the the <select> link in the following section). Press the link with the menu open. On Android, the link will trigger.
DatePicker. Again, click on a link with the date picker open. Same behavior.
Dialog. The popover example demonstrates the same behavior.
Popover. The Settings example demonstrates the same behavior.

Different behaviors:

ComboBox. Do the same thing. In this case, the link will actually trigger on all browsers I tested (might be related to #6512?).
Modal. The dismissable modal will NOT trigger a click when you click outside the dialog (it's best to try and click the link to Tailwind CSS above here).

💁 Possible Solution
A popover/dialog should not necessarily be "modal" just because it's dismissed when you click outside it. But the behavior is inconsistent and sometimes magically "modal", except on Android, for some inputs.
If wrapping everything in Modal is required for true modality, the documentation should be updated to include it.
🔦 Context
No response
🖥 Steps to Reproduce
Please refer to the links above. But, in general:

Trigger a popover in a dialog.
Press on a link outside the popover to dismiss it.
Sometimes this will trigger a click on that link.

Version
3.37.0 (September 30, 2024 release)
What browsers are you seeing the problem on?
Firefox, Chrome
If other, please specify.
No response
What operating system are you using?
Android
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

same here

I think we can apply the same idea as in #7542 here. Instead of triggering onInteractOutside during the onPointerUp event, we could wait until onClick. What happens is the DOM gets mutated between onPointerUp and onClick and the browser ends up clicking the wrong element: https://issues.chromium.org/issues/40732224
It's in this file if someone wants to give it a shot: https://github.com/adobe/react-spectrum/blob/main/packages/%40react-aria/interactions/src/useInteractOutside.ts


Add take_while experimental dataset op

Addresses #24105

Still need to add test cases, but any changes required in the current commits?
@jsimsa @mrry Most other dataset op that take in a function as a parameter, check for short circuits using ComputeShortCircuitIndices, will I need to do that here as well?
Also, right now take_while is state-less, similar to map. Do I need to also build the scan equivalent for take_while, i.e. take_while with a state?

I've made the required changes. Adding tests in the next couple of hours.

@jsimsa I've added tests and made the changes mentioned. Take a look, and let me know if further changes are required.

@jsimsa Made the changes and fixed whatever was failing on the tests. I wasn't exactly sure what the api_def should look like for this, so I copied and edited api_def_FilterDataset, so can you take a look and tell me whether it's right or wrong?
Question: Also, what's the difference between base_api and python_api?

@jsimsa Made the changes you asked and fixed whatever was causing the CI to fail. I think it should be good to go unless I've overlooked something.


Gradle 7.3.3 -> 7.4

Already updated.
Note: Do not forget to update gradle wrapper version in build.gradle.kts in future


Minor Updates to Example 1 for GFS datasource

Earth-2 MIP Pull Request
Description

Checklist

[ ] I am familiar with the Contributing Guidelines.
[ ] New or existing tests cover these changes.
[ ] The documentation is up to date with these changes.
[ ] The CHANGELOG.md is up to date with these changes.
[ ] An issue is linked to this pull request.

Dependencies

/blossom-ci


add Joe Bew

I added all the information about my Twitch channel :+1:
Awesome initiative folks!

Looks good! Thanks for the PR - merging 💥


Show input lines in the scene

add basegraph in diagram(datastructure: compas mesh), it has no force attribute, but is very similar to formdiagram. it's only used to hint user the input lines, and could be shown to compare with the new Formdiagram after right-to-left modification.
add basegraph related object, artist.
the base graph could be turned on/off in form_displaysettings

futher implement:

anchor, could move together with the FormDiagram
display layer (don't know how to move it to the back... )

why not just assign the original graph to the form diagram instance and display that one? this would also solve the problem of letting the user know about changes that have been made to the input graph because of invalid input. furthermore, it is a network and not a mesh and thus more lightweight...

perhaps we can briefly discuss when @ricardoavelino wakes up because i like the idea but i am not sure that duplicating the form diagram makes sense...

Hi Tom. Thanks for having a look. I was also thinking about just adding the graph to the scene. but the DiagramObejct is a mesh if I understand correctly but the graph is a network. I'm a bit unsure whether it's possible to add it directly to the scene. Thus, instead of messing up everything I create a new mesh.... (yeah maybe not ideal...)
Let's definitely wait for @ricardoavelino

Hi @brgcode I think it is ok to store only the graph. Also simpler. In this case, I guess we can store the graph as a ags.FormGraph and we create a GraphObject and Graphrtist? That draw based on networks? Other option would be to just store it "inside" the form diagram at self._graph, what do you think about it?
Just as a note: the idea is not update this graph with modifications from the user, we thought on keeping this original input to compare with the modifications done during the exploration...

i would store it as an attribute of the diagram...

and "yes" to all of the other stuff

So, after creating the form diagram:
form = FormDiagram.from_graph(graph)
we should assign the graph to the attribute self._graph
form._graph = graph
Then this form._graph can be nicely displayed with a new class GraphArtist based on the NetworkArtist @compas_rhino.artists
But how are we going to add this to the scene? And how are we creating a GraphObject ? We noted that @compas_rhino.objects we have only a MeshObject.
We are a bit confused here...

i'll take care of it...


Find more recent papers to cite

If you are able to download the ATUS survey you can put it on dropbox so I can check it. Or if you find any other solution how can we get access to the micro data that would be great. We are only interested in a few questions besides the occupation codes, we need: JF_10-JF_14
I didn't find any survey about the USA but found two papers that might be interesting from other countries.
To make comparison with other countries we might want to take a look at this webpage that compares how strict are the regulation worldwide: https://www.bsg.ox.ac.uk/research/research-projects/coronavirus-government-response-tracker
Baert et al. The COVID-19 Crisis and Telework: A Research Survey on Experiences, Expectations and Hopes
https://www.iza.org/publications/dp/13229/the-covid-19-crisis-and-telework-a-research-survey-on-experiences-expectations-and-hopes
Table 1: we can compare the results of the survey about increased teleworking to our expectations by sectors. (in my understanding we can calculate the number of people working in the given sector and the number of those who are able to work from home also by sector)
Gaudecker et al.: Labour Supply in the Early Stages of the COVID-19 Pandemic: Empirical Evidence on Hours, Home Office, and Expectations
https://papers.ssrn.com/sol3/papers.cfm?abstract_id=3579251
Table 2 looks interesting to us, it compares the share of workers working from home before Covid and in late March by industry (they distinguish only 12 industries).


fixed horizontal overflow

PR Description 📜
On switching to light mode, there was horizontal overflow. Fixed that.
Fixes #3790

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] My changes generates no new warnings.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @rahul-p19 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Also, I couldn't fix the light mode background because it's been done by using invert. To fix that, I believe we can use CSS variables to toggle between dark and light mode, but that would need some effort. Let me know if you want me to do so.

Thank you  @rahul-p19 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


MapStyle.FromJson not changing anything

BUG / PROBREM REPORT
SUMMARY
I'm trying to define map style usin json, map is working ok but the style is not changing.
What could be the problem ? I tried on visual studio emulator and Nokia 8, same problem.
Even tried with very simple style from sample application but no success.
VERSIONS

Xamarin.Forms.GoogleMaps - 2.3.1-beta1
Xamarin.Forms - <IP_ADDRESS>0555

PLATFORMS

[ x] Android
[] iOS
[ ] UWP

In my case, works fine with "Official" Android Emulator.

I tried on visual studio emulator and Nokia 8, same problem.

I suspects, Google Play services is too old in your devices.
Is there anyone who has same issue?

I'm using Xamarin.GooglePlayServices.Maps nuget version 42.1021.1 in Android platform project,
Nokia 8 device is running Android 8.1.0.
Custom markers, drawing circles etc. works nicely so I'm confused why styling is not.

Sorry I don't know why?
If you make map apps using Xamarin.Android(not using Xamarin.Forms) to still doesn't work, then the reason is depends on your device or develop environment.

I can confirm that this feature works for me with the latest (and latest beta) of GoogleMaps.
I've a file under the resources called 'GoogleMapsStyle.json':

[

   {
      "featureType": "administrative",
      "elementType": "all",
      "stylers": [
         {
            "visibility": "simplified"
         }
      ]
   },

   {
      "featureType": "administrative",
      "elementType": "geometry.fill",
      "stylers": [
         {
            "visibility": "off"
         }
      ]
   },
   {
      "featureType": "administrative",
      "elementType": "geometry.stroke",
      "stylers": [
         {
            "visibility": "on"
         }
      ]
   },
   {
      "featureType": "administrative",
      "elementType": "labels",
      "stylers": [
         {
            "visibility": "off"
         }
      ]
   },
   {
      "featureType": "administrative",
      "elementType": "labels.text",
      "stylers": [
         {
            "visibility": "off"
         }
      ]
   },
   {
      "featureType": "administrative",
      "elementType": "labels.text.fill",
      "stylers": [
         {
            "visibility": "off"
         },
         {
            "hue": "#ff0000"
         }
      ]
   },
   {
      "featureType": "administrative",
      "elementType": "labels.icon",
      "stylers": [
         {
            "visibility": "on"
         }
      ]
   },
   {
      "featureType": "administrative.country",
      "elementType": "all",
      "stylers": [
         {
            "visibility": "on"
         }
      ]
   },
   {
      "featureType": "administrative.country",
      "elementType": "geometry.stroke",
      "stylers": [
         {
            "visibility": "on"
         },
         {
            "lightness": 60
         }
      ]
   },
   {
      "featureType": "administrative.province",
      "elementType": "all",
      "stylers": [
         {
            "visibility": "off"
         }
      ]
   },
   {
      "featureType": "administrative.province",
      "elementType": "labels.text",
      "stylers": [
         {
            "visibility": "off"
         }
      ]
   },
   {
      "featureType": "administrative.locality",
      "elementType": "all",
      "stylers": [
         {
            "visibility": "off"
         }
      ]
   },
   {
      "featureType": "administrative.neighborhood",
      "elementType": "all",
      "stylers": [
         {
            "visibility": "off"
         }
      ]
   },
   {
      "featureType": "administrative.land_parcel",
      "elementType": "all",
      "stylers": [
         {
            "visibility": "off"
         }
      ]
   },
   {
      "featureType": "landscape",
      "elementType": "all",
      "stylers": [
         {
            "color": "#fff"
         },
         {
            "visibility": "on"
         }
      ]
   },
   {
      "featureType": "landscape.man_made",
      "elementType": "all",
      "stylers": [
         {
            "visibility": "on"
         }
      ]
   },
   {
      "featureType": "landscape.natural",
      "elementType": "all",
      "stylers": [
         { "color": "#FDFFF0" },
         {
            "visibility": "on"
         }
      ]
   },
   {
      "featureType": "poi",
      "elementType": "all",
      "stylers": [

         {
            "visibility": "on"
         }
      ]
   },
   {
      "featureType": "road",
      "elementType": "all",
      "stylers": [
         {
            "saturation": -100
         },
         {
            "lightness": 75
         }
      ]
   },
   {
      "featureType": "road.highway",
      "elementType": "all",
      "stylers": [
         {
            "visibility": "simplified"
         }
      ]
   },
   {
      "featureType": "road.arterial",
      "elementType": "labels.icon",
      "stylers": [
         {
            "visibility": "off"
         }
      ]
   },
   {
      "featureType": "transit",
      "elementType": "all",
      "stylers": [
         {
            "visibility": "off"
         }
      ]
   },
   {
      "featureType": "water",
      "elementType": "all",
      "stylers": [
         {
            "color": "#87D6F3"
         },
         {
            "visibility": "on"
         }
      ]
   },
   {
      "elementType": "labels.text.stroke",
      "stylers": [
         {
            "visibility": "off"
         }
      ]
   },
   {
      "featureType": "administrative.province",
      "elementType": "labels",
      "stylers": [

         {
            "visibility": "off"
         }
      ]
   }
]

and load that resource file in my map:

      /// <summary>
      /// Load map style
      /// </summary>
      private void LoadMapStyle()
      {
         var assembly = IntrospectionExtensions.GetTypeInfo(typeof(MyClassName)).Assembly;
         using (Stream stream = assembly.GetManifestResourceStream("MyNameSpace.Resources.GoogleMapsStyle.json"))
         {
            if (stream == null)
               return; //use default

            string text = "";
            using (var reader = new StreamReader(stream))
            {
               text = reader.ReadToEnd();
            }
            this.MapStyle = MapStyle.FromJson(text);
         }
      }

We have not received the requested information.
If you are still experiencing this issue please provide all the requested information and re-open the issue report.
Thanks!

i bet you set your map to a certain maptype? like hybrid or terrain? just remove that in xaml and put jason file as embedded reousrce.


Generated method names based on description rather than the API path

Question
Seems that the name of the method is by API path. Would be nice if it could be by the description of the method instead.
Example (based on Binance spec)
Description of method is:
Compressed/Aggregate Trades List
and the API spec is:
GET /api/v3/aggTrades
The generated method I get is:
get_sol_api_sol_v3_sol_aggTrades
Would like it to be similar to the description instead, i.e.:
get_compressed_aggregate_trade_list
Here is the generated code:
/// Compressed/Aggregate Trades List
    ///
    /// Get compressed, aggregate trades. Trades that fill at the time, from the same order, with the same price will have the quantity aggregated.
    /// - If `fromId`, `startTime`, and `endTime` are not sent, the most recent aggregate trades will be returned.
    /// - Note that if a trade has the following values, this was a duplicate aggregate trade and marked as invalid:
    ///
    ///   p = '0' // price
    ///
    ///   q = '0' // qty
    ///
    ///   f = -1 // ﬁrst_trade_id
    ///
    ///   l = -1 // last_trade_id
    ///
    /// Weight(IP): 2
    ///
    /// - Remark: HTTP `GET /api/v3/aggTrades`.
    /// - Remark: Generated from `#/paths//api/v3/aggTrades/get`.
    internal func get_sol_api_sol_v3_sol_aggTrades(_ input: Operations.get_sol_api_sol_v3_sol_aggTrades.Input) async throws -> Operations.get_sol_api_sol_v3_sol_aggTrades.Output {

Hi @avnerbarr,
as mentioned in #516, the issue here is that the OpenAPI document didn't specify the operationId field for each operation. Either ask the vendor to provide it, or edit the OpenAPI document yourself and add that field to each operation, at which point you'll see exactly those names in the generated code, as long as you keep to the character set recommended by the OpenAPI specification in: https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.1.0.md#fixed-fields-8
A safe character set to use for operationId is [a-zA-Z0-9_].

Thanks for the explanation!
I see that the / characters in the API path are replaced with sol , for example here:
/// - Remark: HTTP `GET /api/v3/ticker/price`.
    /// - Remark: Generated from `#/paths//api/v3/ticker/price/get`.

get_sol_api_sol_v3_sol_ticker_sol_price
What does sol stand for? Is there a simple way (the spec is a few thousand lines long) to remove that? Is is prolific all over.
Thanks!

The sol is the replacement word for the / character, since a slash isn't a legal character in a Swift identifier. Details here: https://swiftpackageindex.com/apple/swift-openapi-generator/1.2.0/documentation/swift-openapi-generator/soar-0001
You could use some custom automation that preprocesses your OpenAPI document, but you might also consider opening a PR to the upstream OpenAPI document and adding well thought-out operationId for each operation, that way everyone can benefit.
In either case, Swift OpenAPI Generator is a tool that generates Swift code from an OpenAPI document, so processing of OpenAPI documents themselves is out of scope of this tool.
You might also check out the filtering feature, if you're only using a small subset of the OpenAPI document in your project: https://swiftpackageindex.com/apple/swift-openapi-generator/1.2.0/documentation/swift-openapi-generator/configuring-the-generator#Document-filtering

Yes I am filtering. I have a new question now :) will open a separate topic


Provide a tool tip for root branch

No tool tip for root branch looks strange (like a bug) in comparision to the other (non-root) branches.
It would be good to show a simple "everything is fine - this is a root branch" tool tip in this case.

[ ] provide a tool tip for roots
[ ] ensure that some tooltip is being provided in the all other cases

I would be happy to help with this issue.
I have even created PR already, with some simple tooltips, but if you have some ideas how to change their text for better, just let me know, as it is only suggestion.


Still relevant

Is it still relevant now that FastImage is compatible with EAS build and managed ?
(even though fast image precache is not working well)

I think it's still relevant. It's pure react-native implementation and no platform specific code in it. Very simple, light weight, still offers flexibility for loading indicator and cache expiration etc... So, yes -- it still holds it's value :)

But feel free to share your thoughts.

Yeah, it's pure JS that is true and nice.
I ended up here reading your article about https://www.echowaves.com/post/expo-filesystem-cachedirectory-has-to-be-cleaned
And browsing this library give me some nice advice for such a use case. For now, I was using fast-images but I'm looking for the caching mechanism because i Also need to cache video assets and this looks great.


Several Links on this page don't work

Several Links on this page don't work. E.g. Create and Submit Sales VAT Advance Notifications, ELSTER Transmission Overview, Error Messages of the Elster Transfer Handler and more.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b02a3bed-10c6-d6cd-6a60-61a01be70db6
Version Independent ID: 04afd3c0-bf14-b6d7-ea87-c43d253bb16a
Content: Germany Local Functionality - Business Central
Content Source: business-central/LocalFunctionality/Germany/germany-local-functionality.md
Service: dynamics365-business-central
GitHub Login: @SorenGP
Microsoft Alias: sgroespe

Thank you for telling us. All broken links are now fixed. The update will be available within one week.


separate definitions and gradients

Fixes the gradient failures reported by @andydotxyz
Also separates the IDs into Defs and Grads so no more need to use interface{} ^_^!

Seems great to me :) with this on top of the defsTest branch things work as expected.


Implement package traits

Motivation
Packages often want to conditionally compile code or add optional dependencies. This is the PR implementing the proposed package traits functionality.
TODOs:

[ ] Workspace support for multi root workspaces
[ ] Availability

@swift-ci please test


x/tools/godoc: packages missing from golang.org/pkg/

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
er, this is for the https://golang.org/pkg/
Does this issue reproduce with the latest release?
tip.golang.org/pkg seems to be working
What operating system and processor architecture are you using (go env)?
firefox
What did you do?
Go to https://golang.org/pkg/
What did you expect to see?
The packages for the std library.
What did you see instead?
Empty space.

Fixed.


consider mentioning API-Security-Checklist

what do you think about https://github.com/shieldfy/API-Security-Checklist

Yeah, why not. You can make a PR and add a bullet point at the end of security section, promoting the need for having a checklist and link that repo as an example. Something short, 1 or 2 lines maybe?


ui-sref-active with non-url parameters

Hi everyone,
It seems that the ui-sref-active directive is not working when using a non-url parameters.
I have a state defined like this:
.state('edit_adv.overview', {
            url: '/overview/:name',
            templateUrl: 'app/adv/overview/overview.html',
            controller: 'OverviewController',
            params: {campaign: null}
})

I'm calling it with:
<button ui-sref="edit_adv.overview({ name: campaign.name, campaign: campaign })" ui-sref-active='button-active'>Overview</button>

If I remove 'campaign: campaign', the ui-sref-active is working, otherwise it's not ....
Any idea ?

Put this in a plunker please

@lucaskerdoncuff ^^

@christopherthielen Here you go: http://plnkr.co/edit/J0MOeu

Yeah, we have at least one or two other issues that refer to the same problem(s).

Do you know how to fix this? I'd gladly give a hand if possible :)

closing as duplicate.
@Kordonme can you try this in the feature-1.0 branch and see if its still occurring there? If so, we could use some help in that area

Well, I fetched and built the new 1.0 branch and added that js file to the plunkr. Still not working:
http://plnkr.co/edit/J0MOeu?p=preview

For anyone still falling into this, you can workaround the issue by passing $state to your template and use .includes() on ng-class instead of ui-sref-active:
// in your controller, pass $state to your scope or other view model:
function ($scope, $state) {
  $scope.$state = $state;
}

// in your template, use ng-class and $state.includes():
Orders

Using includes function with params is most generic I guess.
Documentation mentions includes
This use case fits well for me https://github.com/angular-ui/ui-router/wiki/Quick-Reference#params-v03

This seems to work with latest ui-router http://plnkr.co/edit/kUEEWE?p=preview

@christopherthielen It is not working when you load the "contact" state initially.
See http://run.plnkr.co/preview/cja14lypk0004315s1w9rjuh3/#/about/contact

Issue: ui-sref-active='active', always the first tab is active along with the selected tab
Code snippet:
uib-tabset(active='activeJustified', justified='true')
uib-tab(ng-repeat='bucket in $ctrl.buckets' ui-sref-active="active" ui-sref='packages1.index1({ bucket: bucket })' heading='{{bucket}}')
uib-tab-heading
span(ng-bind='$ctrl.replaceCharWithSpace(bucket, "_")')


Option 'useKeyboard: false' doesn't work

It seems the 'useKeyboard' option cannot be deactivate. I'm using the following:
<div ng-scrollable="{useKeyboard: false}">

I looked up in the js source and I think this option is never handled, I cannot find any reference to 'config.useKeyboard'.
Regards,
-- Alexandre

Thanks for pointing that out Alexandre, I simply missed implementing that option.

Thank you for your fix, that was fast!


Uservalues are poisoned now

When I fixed #1047, I reduced the amount of uservalues available to 0. This mean that the luasetuservalue call actually fails. This is important, because "dependency" tables are stored in the userdata's user value. Pre-allocating a space of 0 means there is no uservalue to use anymore, so the function call fails with a bad return code.
We need a different "keep alive" mechanism in 5.4, and maybe we will have to figure out how to backport it to 5.3 and below....

I'm going to revert and keep using 1 as the value. This adds a lot of memory bloat but prevents dependency issues.
I will keep using this issue to track better ways to do the optimization.


server/proxy: Add multimon support

This PR adds basic multimon support. Note that we do not forward the server's MonitorLayoutPDU yet.

we should sync Monitor Layout Pdu

what about syncing the client and server?

irrelevant, see #19


Mixed content endpoints or self-signed certs?

I've noticed an issue where by using Goad to test an internal HTTPS endpoint (one that has mixed content), Goad will fail every request made to it.
I then tested Goad with an HTTP endpoint which proxies to our original HTTPS endpoint with mixed content, and this worked fine (the requests didn't immediately fail). Which means it seems likely the 'mixed content' warning the browser is displaying is becoming an issue for Goad somehow?

It's worth clarifying that we use self-signed certificates internally and so I've noticed this issue with other load test tools where by they error because of errors such as x509: certificate signed by unknown authority <- so I assume a similar issue here is occurring.
I then also assume that being able to disable verification of CA would solve that issue

Vegeta passes the insecure flag, to ignore invalid server TLS certificates: https://github.com/tsenart/vegeta/commit/afc01fe98673b1f62508db96532aac2c98881d6c

I've tried to fix this locally but it seems ignoring the verification step doesn't work (unless I'm doing something wrong):
diff --git a/cli/Godeps/_workspace/src/github.com/gophergala2016/goad/lambda/lambda.go b/cli/Godeps/_workspace/src/github.com/gophergala2016/goad/lambda/lambda.go
index 7e9bae9..18bcc1a 100644
--- a/cli/Godeps/_workspace/src/github.com/gophergala2016/goad/lambda/lambda.go
+++ b/cli/Godeps/_workspace/src/github.com/gophergala2016/goad/lambda/lambda.go
@@ -1,10 +1,9 @@
 package main

 import (
+	"crypto/tls"
 	"errors"
 	"fmt"
-	"github.com/gophergala2016/goad/cli/Godeps/_workspace/src/github.com/aws/aws-sdk-go/aws"
-	"github.com/gophergala2016/goad/cli/Godeps/_workspace/src/github.com/gophergala2016/goad/queue"
 	"io/ioutil"
 	"net"
 	"net/http"
@@ -14,6 +13,9 @@ import (
 	"strings"
 	"sync"
 	"time"
+
+	"github.com/gophergala2016/goad/cli/Godeps/_workspace/src/github.com/aws/aws-sdk-go/aws"
+	"github.com/gophergala2016/goad/cli/Godeps/_workspace/src/github.com/gophergala2016/goad/queue"
 )

 func main() {
@@ -49,7 +51,10 @@ func main() {
 	}
 	fmt.Printf("Using a reporting frequency of %s\n", reportingFrequency)

-	client := &http.Client{}
+	tr := &http.Transport{
+		TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
+	}
+	client := &http.Client{Transport: tr}
 	client.Timeout = clientTimeout
 	client.CheckRedirect = func(req *http.Request, via []*http.Request) error {
 		return errors.New("redirect")
diff --git a/cli/cli.go b/cli/cli.go
index 8f2829a..f716d64 100644
--- a/cli/cli.go
+++ b/cli/cli.go
@@ -25,6 +25,7 @@ var (
 	regions     string
 	method      string
 	body        string
+	insecure    bool
 )

 const coldef = termbox.ColorDefault
@@ -38,6 +39,7 @@ func main() {
 	flag.UintVar(&requests, "n", 1000, "number of total requests to make")
 	flag.UintVar(&timeout, "t", 15, "request timeout in seconds")
 	flag.StringVar(&regions, "r", "us-east-1,eu-west-1,ap-northeast-1", "AWS regions to run in (comma separated, no spaces)")
+	flag.BoolVar(&insecure, "i", false, "Ignore invalid server TLS certificates")
 	flag.Parse()

 	if url == "" {
@@ -53,6 +55,7 @@ func main() {
 		Regions:        strings.Split(regions, ","),
 		Method:         method,
 		Body:           body,
+		Insecure:       insecure,
 	})
 	if testerr != nil {
 		fmt.Println(testerr)
diff --git a/goad.go b/goad.go
index be5e561..7234684 100644
--- a/goad.go
+++ b/goad.go
@@ -27,6 +27,7 @@ type TestConfig struct {
 	Regions        []string
 	Method         string
 	Body           string
+	Insecure       bool
 }

 type invokeArgs struct {
diff --git a/lambda/lambda.go b/lambda/lambda.go
index 68ffbed..adb6ca8 100644
--- a/lambda/lambda.go
+++ b/lambda/lambda.go
@@ -1,7 +1,8 @@
 package main

 import (
-    "bytes"
+	"bytes"
+	"crypto/tls"
 	"fmt"
 	"io/ioutil"
 	"net"
@@ -36,7 +37,10 @@ func main() {
 	requestMethod := os.Args[9]
 	requestBody := os.Args[10]

-	client := &http.Client{}
+	tr := &http.Transport{
+		TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
+	}
+	client := &http.Client{Transport: tr}
 	client.Timeout = clientTimeout

 	fmt.Printf("Will spawn %d workers making %d requests to %s\n", concurrencycount, maxRequestCount, address)

In the above diff I started to implement a new flag and then decided I would just try out forcing InsecureSkipVerify but that didn't work.
The following steps I took was:

make osx
build/osx/x86-64/goad -c 5 -n 100 -r "eu-west-1" -u $url_with_self_signed_cert

Note that you would have to delete the lambda function to force it to update (but we are looking at versioning it in future).
It may be that you did fix the problem, but the lambda just wasn't updated.
Anyway, we'll have a look at this.


Documentation on the principles of virtual actors & comparison to Akka

It seems that in https://github.com/orbit/orbit/issues/102 some explanation regarding the distinction between virtual actors and the actor model (as implemented by Akka) was added to the documentation at http://orbit.bioware.com/orbit-actor-overview.html ; however, that page is no longer available. The new documentation website at https://www.orbit.cloud/orbit/ doesn't have much in the way of explanation about virtual actors specifically, instead linking to Microsoft Orleans.

Orbit is a framework to write distributed systems using virtual actors on the JVM. A virtual actor is an object that interacts with the world using asynchronous messages.

This describes non-virtual actors as well.

At any time an actor may be active or inactive. Usually the state of an inactive actor will reside in the database. When a message is sent to an inactive actor it will be activated somewhere in the pool of backend servers. During the activation process the actor’s state is read from the database.

Based on this, it seems that the key difference is persistence, although again the text does not make explicit the distinction between actor and virtual actor.

It is heavily inspired by the Microsoft Orleans project.

Of course, one could go read the Orleans documentation to learn more about virtual actors - but since that is a .NET project and Orbit is merely "inspired" by it, one wouldn't be able to tell which parts are applicable here and which perhaps are not.
On the whole, there isn't much information on the web regarding the differences between Akka and Orbit other than a couple old discussions on github (linked below). In the context of the JVM world, and this being the lesser known of the two projects, it would perhaps help to increase awareness of the Orbit project if the documentation included a more robust introduction, written with the experienced JVM developer in mind (who is likely already familiar with Akka).
https://github.com/akkadotnet/akka.net/issues/756
https://github.com/akka/akka-meta/pull/8

Thank you for the suggestion. This was definitely a first pass to get some useful information out there, focusing more on getting people already familiar started with some specifics. I can definitely see getting some more theoretical/ conceptual information included to help adoption.
You do point out a key distinction between Orbit 1 and 2, that persistence is no longer an explicit concern of Orbit. It made sense rather to give a hook into the activation and deactivation flow, removing the assumption that an addressable involves persistence at all. A virtual actor pattern can be built within this framework, but it's no longer the only pattern available. Abstracting a level up by removing the assumption that an addressable is an actor opens up more scenarios, for example a non-persistent service spun up new on activation.
Hopefully we can get some time to make that a little more clear. We can migrate and update some old docs around the virtual actor pattern for guidance.


SDK requests from browser to envd blocked via CORS

Envd seems to be blocking requests from browser because of CORS. The first OPTIONS request is successful but the next (start process) request fails on cors with no response headers.
We are setting CORS in envd server, but it looks like there still might be a problem.

This might be a problem with the SDK and not the envd server because a direct fetch call to the envd server seems to work.


feat(blog): Discover Kubernetes Resources

Description

To-Dos

[x] Format with yarn format
[x] Lint with yarn lint
[x] Build successfully with yarn build

Code of Conduct
By submitting this pull request, I agree to follow the code of conduct.

Not quite done editing, but I've pushed my changes thus far for your review @aquamatthias. I should wrap things up today and we can get this published! Some really cool stuff in there :)


Update cloud-cli-installation.md

per @greg-mckeon , update alpha docs with new changes. shipping asap

merging this now per PM since this applies to alpha group right now. current page is out of date with recent changes.


fix: don't use string.replaceAll

Fixes #569

@patak-dev We don't have tests for any reporter. Will try adding snapshot tests.


Fix/define artifacts before/issue 3032

Motivation/Description of the PR

When error happens in Before with Playwright, video and trace will be assigned to test.artifacts
Resolves #3032

Applicable helpers:

[ ] WebDriver
[ ] Puppeteer
[ ] Nightmare
[ ] REST
[ ] FileHelper
[ ] Appium
[ ] Protractor
[ ] TestCafe
[x] Playwright

Applicable plugins:

[ ] allure
[ ] autoDelay
[ ] autoLogin
[ ] customLocator
[ ] pauseOnFail
[ ] coverage
[ ] retryFailedStep
[ ] screenshotOnFail
[ ] selenoid
[ ] stepByStepReport
[ ] wdio
[ ] subtitles

Type of change

[ ] :fire: Breaking changes
[ ] :rocket: New functionality
[x] :bug: Bug fix
[ ] :clipboard: Documentation changes/updates
[ ] :hotsprings: Hot fix
[ ] :hammer: Markdown files fix - not related to source code
[ ] :nail_care: Polish code

Checklist:

[ ] Tests have been added
[ ] Documentation has been added (Run npm run docs)
[x] Lint checking (Run npm run lint)
[x] Local tests are passed (Run npm test)

Thanks. We need somehow to ensure that artifcacts exist everywhere in test object
But let's take this as an additional check here.


Rename Source Dataset to Source Study

Need
Need to make room for actual source datasets (AnnData Files)
Approach
Rename source dataset to source study.

Database table and queries
Service
APIs
FE

Complete, and epic!


[Howto]: PHP custom extension not loading. Help Needed!!!

Have you already checked elsewhere?

[ ] I have read the Devilbox documentation
[X] I have checked the Devilbox Troubleshooting Guide
[ ] I have checked the Devilbox FAQ
[ ] I have checked the Devilbox Howto
[X] I have checked the Devilbox Forum
[ ] I have checked existing issues
[X] I have googled already with no luck
[ ] I have not done any of the above

What are you struggling with?
Hi i am trying to add "dbase" extension from PECL.
Link:- "https://pecl.php.net/package/dbase'
commands:
sudo pecl install dbase-7.1.1

Success:
Build process completed successfully
Installing '/usr/local/lib/php/extensions/no-debug-non-zts-20190902/dbase.so'
install ok: channel://pecl.php.net/dbase-7.1.1
configuration option "php_ini" is not set to php.ini location
You should add "extension=dbase.so" to php.ini

commands
echo "extension=/usr/local/lib/php/extensions/no-debug-non-zts-20190902/dbase.so" >> cfg/php-ini-7.4/00-dbase.ini

But not loading extension.
Here is Screenshot.

And i UPDATE "env" file set to "PHP_MODULES_ENABLE=dbase"
I got error.
Here is Screenshot.

What have you tried already?
i tried  https://github.com/cytopia/devilbox/issues/263
What is your goal?
nil

it works. same command.


Add documentation on how to run recipes locally

TFW when you're sharing docs PR links because they're the closest thing we've got to a good tutorial on the public internet 😅

Going to go ahead and merge as this looks plenty good for now!


1.18 Support for altoclef

#135 mentioned it first, 1.18 came out and this is the pull request for 1.18 altoclef.
This is my second pull request (the first is on gaucho-matrero/baritone).

Do you got an artifact for me?

@Bluscream latest release
It worked for me, tell me if something went wrong.

@Bluscream my latest release link It worked for me, tell me if something went wrong.

thanks :) sadly my mc didn't like it: https://paste.ee/p/nRtb1

Please open an issue here, everything should have its place 😄 But i think i can already help you, I think you have baritone in the mods folder, altoclef delivers baritone within, so there's an conflict

Please open an issue here, everything should have its place 😄 Altoclef delivers baritone within, so there's no need for an extra baritone installation.

OHHH, thanks for letting me know

Got a crash without baritone now, https://paste.ee/p/wVbXw
I wonder if it still belongs in the baritone repo, since the stacktrace says
[02:43:29] [Render thread/FATAL]: Unreported exception thrown!
java.lang.NullPointerException: Cannot invoke "net.minecraft.class_2680.method_26204()" because "current" is null
	at baritone.process.BuilderProcess.valid(BuilderProcess.java:829) ~[baritone-1.18-SNAPSHOT-98b3823201e5a8a9.jar:?]
	at baritone.process.BuilderProcess.onTick(BuilderProcess.java:485) ~[baritone-1.18-SNAPSHOT-98b3823201e5a8a9.jar:?]
	at baritone.utils.PathingControlManager.executeProcesses(PathingControlManager.java:200) ~[baritone-1.18-SNAPSHOT-98b3823201e5a8a9.jar:?]
	at baritone.utils.PathingControlManager.preTick(PathingControlManager.java:89) ~[baritone-1.18-SNAPSHOT-98b3823201e5a8a9.jar:?]
	at baritone.behavior.PathingBehavior.onTick(PathingBehavior.java:98) ~[baritone-1.18-SNAPSHOT-98b3823201e5a8a9.jar:?]
	at baritone.event.GameEventHandler.lambda$onTick$0(GameEventHandler.java:59) ~[baritone-1.18-SNAPSHOT-98b3823201e5a8a9.jar:?]
	at java.util.concurrent.CopyOnWriteArrayList.forEach(CopyOnWriteArrayList.java:807) ~[?:?]
	at baritone.event.GameEventHandler.onTick(GameEventHandler.java:59) ~[baritone-1.18-SNAPSHOT-98b3823201e5a8a9.jar:?]
	at net.minecraft.class_310.handler$zbe000$runTick(class_310.java:4036) ~[intermediary-minecraft-1.18-client.jar:?]
	at net.minecraft.class_310.method_1574(class_310.java:1720) ~[intermediary-minecraft-1.18-client.jar:?]
	at net.minecraft.class_310.method_1523(class_310.java:1086) ~[intermediary-minecraft-1.18-client.jar:?]
	at net.minecraft.class_310.method_1514(class_310.java:733) [intermediary-minecraft-1.18-client.jar:?]
	at net.minecraft.client.main.Main.main(Main.java:236) [intermediary-minecraft-1.18-client.jar:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
	at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:599) [fabric-loader-0.12.8.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:77) [fabric-loader-0.12.8.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.12.8.jar:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
	at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
	at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:210) [NewLaunch.jar:?]
	at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:245) [NewLaunch.jar:?]
	at org.multimc.EntryPoint.listen(EntryPoint.java:143) [NewLaunch.jar:?]
	at org.multimc.EntryPoint.main(EntryPoint.java:34) [NewLaunch.jar:?]

Again, open an issue if you have one.
I tried with the mods you have installed, but everything works fine for me. Steps to reproduce? Try maybe without Multimc?

https://github.com/wagyourtail/baritone/actions

This is fixed


Can't open the pock in the system Touch Bar

After tap the exit round button,I can't open the pock on the right side  in the Touch Bar .
Screenshots

Versions:

macOS version: [10.15]
Pock version:  [0.6.2]

It's not happened every time,but sometimes

same here.

Did you try using the double ctrl key shortcut to bring Pock back?

I have a similar problem. When I open pock app in my macbook (macOS 10.15.1), the touchbar cannot showing any dock icon. I try using the double ctrl key shortcut, the issue also exists.
I wanna konw

how to solve the issue.

the same. And pock cannot unable to switch with other apps' custom touch bar

Did you try using the double ctrl key shortcut to bring Pock back?

I have tried，It also can‘t work sometimes

if you have bettertouchtool with Touch Bar support turned on, the "pock button" in control panel (standard) won't appear its being overridden


VirgilCard not found app crash

Everytime when im trying to create a new conversation and send message I get this error.

Can you provide more info about the issue, please?
At least - have you created the user you trying to start conversation with?

Hi, @gra1w! I think that your issue is already resolved, can you check it out please?


Convert subtitles to lrc?

This one is simple: Youtube-dl gives an option to convert subtitles to a desired format, but lrc isn't one of the provided options. Adding support for it would be trivial (Ffmpeg already does it on it's own) and, I think, it'd be a great help when downloading music from such channels which add subtitles to all their songs.
I already checked out --exec to do this, but that runs commands with the file's full name, while the subtitle always differs slightly from the video. Embedding the subtitle into the file and converting that could also work I guess, but my experience is that sometimes (I think when multiple formats are mixed into a mkv container?) subtitle embedding just fails.

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.09.15. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2017.09.15

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[x] Feature request (request for a new functionality)
[ ] Question
[ ] Other

Ffmpeg already does it on it's own

Good to know that! lrc will be accepted as a subtitle conversion target in the next version.


Schneems/error match

I'm not sure why the tests didn't catch this:
  /Users/rschneeman/Documents/projects/work/minimal-ruby/spec/unit/toml_spec.rb:18: syntax error, unexpected end-of-input, expecting `end'

It seems circle's error message is different for some reason:
/usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:92:in `require': /tmp/d20201111-79-lhlcok/script.rb:10: syntax error, unexpected `end', expecting end-of-input (SyntaxError)
	from /usr/local/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:92:in `require'
	from /home/circleci/project/lib/syntax_search/auto.rb:26:in `require_relative'
	from /tmp/d20201111-79-lhlcok/require.rb:1:in `<main>'
/tmp/d20201111-79-lhlcok/script.rb:10: syntax error, unexpected `end', expecting end-of-input

https://app.circleci.com/pipelines/github/zombocom/syntax_search/28/workflows/8bb184c9-7f04-49ef-8d01-12c0cbc1a810

The reason that wasn't caught is because it's a different error message. Removing an end produces an "unexpected end-of-input" versus removing a do produces an "unexpected end"
Missing do
         1  # frozen_string_literal: true
         2
         3  require_relative "../spec_helper.rb"
         4
         5  module HerokuBuildpackRuby
         6    RSpec.describe "toml" do
      ❯  7      it "parses toml correctly"
      ❯ 17      end
        18    end
        19  end

    An error occurred while loading ./spec/unit/toml_spec.rb.
    Failure/Error: Kernel.load(path, wrap)

    SyntaxError:
      /Users/rschneeman/Documents/projects/work/minimal-ruby/spec/unit/toml_spec.rb:19: syntax error, unexpected `end', expecting end-of-input
    # /Users/rschneeman/.gem/ruby/2.7.1/gems/syntax_search-0.1.1/lib/syntax_search/auto.rb:40:in `load'

Missing end:
file: /Users/rschneeman/Documents/projects/work/minimal-ruby/spec/unit/toml_spec.rb
simplified:

     1  # frozen_string_literal: true
     2
     3  require_relative "../spec_helper.rb"
     4
     5  module HerokuBuildpackRuby
     6    RSpec.describe "toml" do
  ❯  7      it "parses toml correctly" do
    17    end
    18  end

An error occurred while loading ./spec/unit/toml_spec.rb.
Failure/Error: Kernel.load(path, wrap)

SyntaxError:
  /Users/rschneeman/Documents/projects/work/minimal-ruby/spec/unit/toml_spec.rb:18: syntax error, unexpected end-of-input, expecting `end'
# /Users/rschneeman/.gem/ruby/2.7.1/gems/syntax_search-0.1.1/lib/syntax_search/auto.rb:40:in `load'

Fin
It turns out that the same search looks helpful for both cases so it's fine to expand the scope of the gem.


[KOGITO-5677] ProcessInstanceMarshallTest - incorrect marshaller chosen for some types

Jira: https://issues.redhat.com/browse/KOGITO-5677

The (build) Runtimes check has failed. Please check the logs.

The (build) Runtimes check has failed. Please check the logs.

The (build) Apps check has failed. Please check the logs.

The (build) Apps check has failed. Please check the logs.

The (build) Examples check has failed. Please check the logs.

The (build) Examples check has failed. Please check the logs.

jenkins please retest this


New version: RuneLite.RuneLite version 2.6.10

Pull request has been created with WinGet Automation :rocket:
Microsoft Reviewers: Open in CodeFlow

Merge conflict - reset PR.

@stephengillie It looks like the changes in this PR were already implemented by #128761

@ stephengillie It looks like the changes in this PR were already implemented by #128761

Hi @Felanbird,
Yes - vedantmgoyal2009 had previously requested these be set as draft, to avoid GitHub rate limits and reuse the PR. But from this ticket's closure, I'm guessing he might have changed his plans.


Include upgraded deps versions in CHANGELOG

Incredibly minor.
However, when auditing library changes, it's very convenient to see the exact upgraded deps versions in the changelogs of the libraries instead of "Update deps to including latest clojure, clojurescript & shadow-cljs".
Listing the upgraded deps versions on the changelog would also be consistent with other re-frame libraries.
I can provide a PR to the changelog later today if I get time.

Will include in future changes. Thanks. See 0.4.0


Fix pilot_cli debug tool to work with EDS

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
Assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@diemtvu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
7793e12df54b03a239afbd7a8f9943daa2c60e14
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
7793e12df54b03a239afbd7a8f9943daa2c60e14
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
7793e12df54b03a239afbd7a8f9943daa2c60e14
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
7793e12df54b03a239afbd7a8f9943daa2c60e14
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
7793e12df54b03a239afbd7a8f9943daa2c60e14
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
7793e12df54b03a239afbd7a8f9943daa2c60e14
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
7793e12df54b03a239afbd7a8f9943daa2c60e14
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
7793e12df54b03a239afbd7a8f9943daa2c60e14
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
7793e12df54b03a239afbd7a8f9943daa2c60e14
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
7793e12df54b03a239afbd7a8f9943daa2c60e14
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-bookInfo

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
7793e12df54b03a239afbd7a8f9943daa2c60e14
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
7793e12df54b03a239afbd7a8f9943daa2c60e14
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
7793e12df54b03a239afbd7a8f9943daa2c60e14
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
7793e12df54b03a239afbd7a8f9943daa2c60e14
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
7793e12df54b03a239afbd7a8f9943daa2c60e14
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
7793e12df54b03a239afbd7a8f9943daa2c60e14
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
7793e12df54b03a239afbd7a8f9943daa2c60e14
link
/test e2e-bookInfo

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d12324148f7f7a2434795943c4a0d9d85ce8ff51
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
7793e12df54b03a239afbd7a8f9943daa2c60e14
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
7793e12df54b03a239afbd7a8f9943daa2c60e14
link
/test e2e-bookInfo

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d12324148f7f7a2434795943c4a0d9d85ce8ff51
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
d12324148f7f7a2434795943c4a0d9d85ce8ff51
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
7793e12df54b03a239afbd7a8f9943daa2c60e14
link
/test e2e-bookInfo

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d12324148f7f7a2434795943c4a0d9d85ce8ff51
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
d12324148f7f7a2434795943c4a0d9d85ce8ff51
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
d12324148f7f7a2434795943c4a0d9d85ce8ff51
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d12324148f7f7a2434795943c4a0d9d85ce8ff51
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
d12324148f7f7a2434795943c4a0d9d85ce8ff51
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
d12324148f7f7a2434795943c4a0d9d85ce8ff51
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
d12324148f7f7a2434795943c4a0d9d85ce8ff51
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: diemtvu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
Assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
d12324148f7f7a2434795943c4a0d9d85ce8ff51
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
d12324148f7f7a2434795943c4a0d9d85ce8ff51
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
d12324148f7f7a2434795943c4a0d9d85ce8ff51
link
/test e2e-bookInfo

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
76110fbd1b8e2af2bae32e5574d76dd5fa5bdcd5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
d12324148f7f7a2434795943c4a0d9d85ce8ff51
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
d12324148f7f7a2434795943c4a0d9d85ce8ff51
link
/test e2e-bookInfo

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
76110fbd1b8e2af2bae32e5574d76dd5fa5bdcd5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
76110fbd1b8e2af2bae32e5574d76dd5fa5bdcd5
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
d12324148f7f7a2434795943c4a0d9d85ce8ff51
link
/test e2e-bookInfo

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
76110fbd1b8e2af2bae32e5574d76dd5fa5bdcd5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
76110fbd1b8e2af2bae32e5574d76dd5fa5bdcd5
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
76110fbd1b8e2af2bae32e5574d76dd5fa5bdcd5
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
76110fbd1b8e2af2bae32e5574d76dd5fa5bdcd5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
76110fbd1b8e2af2bae32e5574d76dd5fa5bdcd5
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
76110fbd1b8e2af2bae32e5574d76dd5fa5bdcd5
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
76110fbd1b8e2af2bae32e5574d76dd5fa5bdcd5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
76110fbd1b8e2af2bae32e5574d76dd5fa5bdcd5
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
76110fbd1b8e2af2bae32e5574d76dd5fa5bdcd5
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
76110fbd1b8e2af2bae32e5574d76dd5fa5bdcd5
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
76110fbd1b8e2af2bae32e5574d76dd5fa5bdcd5
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
76110fbd1b8e2af2bae32e5574d76dd5fa5bdcd5
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
76110fbd1b8e2af2bae32e5574d76dd5fa5bdcd5
link
/test e2e-bookInfo

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
76110fbd1b8e2af2bae32e5574d76dd5fa5bdcd5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
76110fbd1b8e2af2bae32e5574d76dd5fa5bdcd5
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-bookInfoTests.sh
76110fbd1b8e2af2bae32e5574d76dd5fa5bdcd5
link
/test e2e-bookInfo

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
76110fbd1b8e2af2bae32e5574d76dd5fa5bdcd5
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
76110fbd1b8e2af2bae32e5574d76dd5fa5bdcd5
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu is there any functionality here that is missing from istioctl proxy-config? https://preliminary.istio.io/docs/reference/commands/istioctl.html#istioctl proxy-config

If I understand correctly, istioctl proxy-config is not able to get
listeners/clusters config for a sidecar/proxy. I'll merge this tool to
istioctl at some point, but if you have other plan, please let me know.
On Wed, May 23, 2018 at 12:49 PM Liam White<EMAIL_ADDRESS>wrote:

@diemtvu https://github.com/diemtvu is there any functionality here
that is missing from istioctl proxy-config?
https://preliminary.istio.io/docs/reference/commands/istioctl.html#istioctl proxy-config
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/5531#issuecomment-391474167, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AX99cR-cbO8QhR8AXVBu7k30tLlYbc-fks5t1b1NgaJpZM4T5Mn8
.

--
Diem Vu | Software Engineer |<EMAIL_ADDRESS>| +1<PHONE_NUMBER>

Also, this tool simulate proxy grpc request to get configs, so it can be used with local pilot for testing (i.e during development)


feat(SliceGwReconciler): Add PodDisruptionBudget logic to SliceGwReconciler (#308)

Description
A PodDisruptionBedget is required that matches the slice gateway pods, and to specify a minimum availability of 1 pod in case of disruptions.
The SliceGwReconciler handles the lifecycle of this PodDisruptionBudget object.
Added RBAC permissions for SliceGwReconciler to maintain PodDisruptionBudget.
Fixes #308
How Has This Been Tested?
Checklist:

[x] The title of the PR states what changed and the related issues number (used for the release note).
[x] Does this PR requires documentation updates?

Since the change is user facing, i.e., the PDB is one extra resource that will be visible to users, I think it is better to a add some explanation in the documentation.

[ ] I've updated documentation as required by this PR.
[x] I have ran go fmt
[x] I have updated the helm chart as required by this PR.

Updated the RBAC permissions for CRUD on PodDisruptionBudget objects. However, a PR for the same has to be created once this is approved.

[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have tested it for all user roles.
[ ] I have added all the required unit test cases.
[x] I have verified the E2E test cases with new code changes.
[x] I have added all the required E2E test cases.

Added 3 subtest cases under spoke tests.

Does this PR introduce a breaking change?

Steps to test

Deploy the whole setup controller and 2 workers. Check if there are slice gateway pods similar to this in both the worker clusters:

water-kind-kubeslice-worker-2-kind-kubeslice-worker-1-0-0-6tqrk   3/3     Running   0          61m
water-kind-kubeslice-worker-2-kind-kubeslice-worker-1-1-0-h4vsp   3/3     Running   0          61m

With this change, there should also be a PodDisruptionBudget created in the same namespace

water-kind-kubeslice-worker-2-kind-kubeslice-worker-1-pdb   1               N/A               1                     62m

with labels similar to:
labels:
  kubeslice.io/slice: water
  kubeslice.io/slice-gw: water-kind-kubeslice-worker-2-kind-kubeslice-worker-1

When trying to disrupt the node, say one of the worker cluster's worker nodes (if having multi-node setup), using the command:

kubectl drain --ignore-daemonsets --delete-emptydir-data <worker-node-name-here>

it should be able to evict one pod but fail to evict the other:
pod/water-kind-kubeslice-worker-2-kind-kubeslice-worker-1-0-0-6tqrk evicted

error when evicting pods/"water-kind-kubeslice-worker-2-kind-kubeslice-worker-1-1-0-h4vsp" -n "kubeslice-system" (will retry after 5s): Cannot evict pod as it would violate the pod's disruption budget.

The issue #335 impacts this PR. Hence holding this until it is resolved.

Thanks for bringing this to our attention @Bhargav-InfraCloud . The issue #335 has been resolved.

Thanks @mridulgain! Changes in this PR are now based on the latest master.

The E2E is failing as the image is missing in the Docker hub:
Unable to find image 'aveshadev/kubeslice-e2e:latest' locally
docker: Error response from daemon: pull access denied for aveshadev/kubeslice-e2e, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.

Was it moved to somewhere else?

@narmidm @bharath-avesha @gourishkb Can you please review this PR? Thanks!

The E2E is failing as the image is missing in the Docker hub:
Unable to find image 'aveshadev/kubeslice-e2e:latest' locally
docker: Error response from daemon: pull access denied for aveshadev/kubeslice-e2e, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.

Was it moved to somewhere else?

@Bhargav-InfraCloud  we have resolved the e2e test image issue & re triggered the pipeline.

@mridulgain Great! Thanks for the update.
I've rebased with the latest master. Please trigger the E2E again.

report link  'https://kubeslice.github.io/e2e-allure-reports/Kind-worker-operator-2024-03-08T08:57:25-master-437/index.html'

started E2E pipeline - https://github.com/kubeslice/worker-operator/actions/runs/8244374883/job/22546499751?pr=334

report link  'https://kubeslice.github.io/e2e-allure-reports/Kind-worker-operator-2024-03-12T07:43:01-master-439/index.html'

Thanks, all! 😊


Replace IdCard by VerifiableId

VerifiableId is the EU EBSI model of the ID card

replace card image in wallet (See Hugo / Figma)
new type  for passbase package (type = VerifiableId)
use new endpoint for an individual download  https://issuer.talao.co//passbase/endpoint/VerifiableId

Size: M


Fix period retrival for timers

Fix get_period for timers

Oh, that's a sneaky bug, good catch! :)
Would you mind also adding a changelog entry to CHANGELOG.md?

Oh, that's a sneaky bug, good catch! :)
Would you mind also adding a changelog entry to CHANGELOG.md?

Done.


Add A2C

I didn't use ActionNormaliezr and Gaussian distribution. Because It hurts performance and stability. These are my experiments for comparing performance. But I don't know what affects this. You can see this code in Colab.
With ActionNormalizer, with Gaussian distribution

With ActionNormalizer, with normal distribution

Without ActionNormalizer, with normal distribution

mu * 2
action clip -2, 2
The activation function of log_std is softplus

Please add a direct link to Colab so as to easily review.

Ok, give me a second(actually 5 minute)

오후 11:30, Jinwoo Park (Curt<EMAIL_ADDRESS>작성:

Please add a direct link to Colab so as to easily review.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub https://github.com/MrSyee/pg-is-all-you-need/pull/3?email_source=notifications&email_token=AKJZKMJK7YM4TR53GOWUN63QGU27VA5CNFSM4IPJFEC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5H55HI#issuecomment-525328029, or mute the thread https://github.com/notifications/unsubscribe-auth/AKJZKMOS7EYEILG57B7RVZLQGU27VANCNFSM4IPJFECQ.

@mclearning2 Don't be hurry. Take your time.

@Curt-Park I added colab

The link is read-only. I cannot run.

Please link colab to your feature branch but the file on your Google drive.

Is this correct?

@mclearning2 Yes it is

align the imports. (isort plugin)
Cannot run on GPU

/usr/local/lib/python3.6/dist-packages/torch/nn/functional.py:1374: UserWarning: nn.functional.tanh is deprecated. Use torch.tanh instead.
warnings.warn("nn.functional.tanh is deprecated. Use torch.tanh instead.")
AttributeError                            Traceback (most recent call last)
/usr/local/lib/python3.6/dist-packages/numpy/core/fromnumeric.py in _wrapfunc(obj, method, *args, **kwds)
55     try:
---> 56         return getattr(obj, method)(*args, **kwds)
57
AttributeError: 'Tensor' object has no attribute 'clip'
During handling of the above exception, another exception occurred:
TypeError                                 Traceback (most recent call last)
7 frames
/usr/local/lib/python3.6/dist-packages/torch/tensor.py in array(self, dtype)
456     def array(self, dtype=None):
457         if dtype is None:
--> 458             return self.numpy()
459         else:
460             return self.numpy().astype(dtype, copy=False)
TypeError: c1. align the imports. (isort plugin)
2. an't convert CUDA tensor to numpy. Use Tensor.cpu() to copy the tensor to host memory first.

Offline review is done. Please update

@Curt-Park @MrSyee I added a description of the advantage and the entropy. please check it and approve this PR

Italic is better than bold when you write in English.
Lastly, We call the policy Actor, which predicts probabilities of actions in each state, and call the value function is Critic, which predicts values of all state-action pairs.
It would be better to use two subtitles (Actor-Critic, Advantage Function, Maximization Entropy) for the description of A2C. Plus, remove As mentioned above
Passive sentences are not so proper, especially in academic writing.
The advantage function is used for reducing effectively reduces the variance of values . It's and is defined like this as follows.
Don't use conjunctions like conjunctive adverbs (But / So).
But => However,
So => As a result,
Too tedious.
~~But There is a problem that we need to implement two models for action value  𝑄  and state value  𝑉 . Fortunately, we can use the TD error by replacing  𝑄  with ~~
=> From this formula, we can replace Q with 𝑟+𝛾𝑉(𝑠′) and redefine Advantage function without using Action-Value function.
The Entropy is a measure of unpredictability or a measure of randomness.
When we have actions with almost equal probabilities, the entropy over actions will be high.
=> If we have actions with equal probabilities, the entropy over the actions will be the largest because it's completely unpredictable which action will be chosen.
So, It can be used to encourage exploration by adding the entropy to the loss.
In view of the fact, we can encourage exploration by adding entropy maximization term to the loss function.
The entropy  𝐻  respect to a probability  𝑝(𝑎)  of an action  𝑎  is
The entropy 𝐻 with respect to the probability p over actions is

I suggest this regarding updating.
def update_model(self) -> Tuple[torch.Tensor, torch.Tensor]:
        state, log_prob, next_state, reward, done = self.transition

        # Q_t   = r + gamma * V(s_{t+1})  if state != Terminal
        #       = r                       otherwise
        mask = 1 - done
        next_state = torch.FloatTensor(next_state).to(self.device)
        next_value = self.critic(next_state).detach()
        targ_value = reward + self.gamma * next_value * mask
        value_loss = F.smooth_l1_loss(pred_value, targ_value)

        # update value
        self.critic_optimizer.zero_grad()
        value_loss.backward()
        self.critic_optimizer.step()

        # advantage = Q_t - V(s_t)
        pred_value = self.critic(state)
        advantage = targ_value - pred_value

        # advantage is not backpropagated
        policy_loss = -advantage.detach() * log_prob
        # entropy maximization
        policy_loss += self.entropy_weight * -log_prob

        # update policy
        self.actor_optimizer.zero_grad()
        policy_loss.backward()
        self.actor_optimizer.step()

        return policy_loss.item(), value_loss.item()

During testing, the following error occurs a lot. Please check.
---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)
<ipython-input-17-8888c83ca256> in <module>()
----> 1 frames = agent.test()

4 frames
/usr/local/lib/python3.6/dist-packages/pyglet/gl/__init__.py in <module>()
    225     else:
    226         from .carbon import CarbonConfig as Config
--> 227 del base
    228
    229 # XXX remove

NameError: name 'base' is not defined

@Curt-Park I tried to run the colab in other develope environments. But It didn't happen to me.

@mclearning2 I will test again after you modify it.

Thank you(@Curt-Park), for your detailed review. I edited the descriptions you mentioned and run the agent one more time to compare. As a result, it looks similar but I changed the code without a single line of code because your suggestions are easier to read.
def update_model(self) -> Tuple[torch.Tensor, torch.Tensor]:
        state, log_prob, next_state, reward, done = self.transition

        # Q_t   = r + gamma * V(s_{t+1})  if state != Terminal
        #       = r                       otherwise
        mask = 1 - done
        next_state = torch.FloatTensor(next_state).to(self.device)
        pred_value = self.critic(state)
        targ_value = reward + self.gamma * self.critic(next_state) * mask
        value_loss = F.smooth_l1_loss(pred_value, targ_value.detach())

        # update value
        self.critic_optimizer.zero_grad()
        value_loss.backward()
        self.critic_optimizer.step()

        # advantage = Q_t - V(s_t)
        ~~pred_value = self.critic(state)~~
        advantage = (targ_value - pred_value).detach()  # not backpropagated
        policy_loss = -advantage * log_prob
        policy_loss += self.entropy_weight * -log_prob  # entropy maximization

        # update policy
        self.actor_optimizer.zero_grad()
        policy_loss.backward()
        self.actor_optimizer.step()

        return policy_loss.item(), value_loss.item()

Before

After

Check this

---------------------------------------------------------------------------
UnboundLocalError                         Traceback (most recent call last)
<ipython-input-18-4326fee8443c> in <module>()
----> 1 agent.train(num_frames)

1 frames
<ipython-input-14-64d9ebe62916> in update_model(self)
     76         next_state = torch.FloatTensor(next_state).to(self.device)
     77         targ_value = reward + self.gamma * self.critic(next_state) * mask
---> 78         value_loss = F.smooth_l1_loss(pred_value, targ_value.detach())
     79
     80         # update value

UnboundLocalError: local variable 'pred_value' referenced before assignment

I hope you change the bold words to italic.

update method looks like this on my execution.
    def update_model(self) -> Tuple[torch.Tensor, torch.Tensor]:
        state, log_prob, next_state, reward, done = self.transition

        # Q_t   = r + gamma * V(s_{t+1})  if state != Terminal
        #       = r                       otherwise
        mask = 1 - done
        next_state = torch.FloatTensor(next_state).to(self.device)
        targ_value = reward + self.gamma * self.critic(next_state) * mask
        value_loss = F.smooth_l1_loss(pred_value, targ_value.detach())

        # update value
        self.critic_optimizer.zero_grad()
        value_loss.backward()
        self.critic_optimizer.step()

        # advantage = Q_t - V(s_t)
        pred_value = self.critic(state)
        advantage = (targ_value - pred_value).detach()  # not backpropagated
        policy_loss = -advantage * log_prob
        policy_loss += self.entropy_weight * -log_prob  # entropy maximization

        # update policy
        self.actor_optimizer.zero_grad()
        policy_loss.backward()
        self.actor_optimizer.step()

        return policy_loss.item(), value_loss.item()

@Curt-Park Oh! It was my mistake! prev_value must be up like this. And I misunderstand to change ~italic~ to bold. I'll fix it.
def update_model(self) -> Tuple[torch.Tensor, torch.Tensor]:
    state, log_prob, next_state, reward, done = self.transition

    # Q_t   = r + gamma * V(s_{t+1})  if state != Terminal
    #       = r                       otherwise
    mask = 1 - done
    **pred_value = self.critic(state)**
    next_state = torch.FloatTensor(next_state).to(self.device)
    targ_value = reward + self.gamma * self.critic(next_state) * mask
    value_loss = F.smooth_l1_loss(pred_value, targ_value.detach())

    # update value
    self.critic_optimizer.zero_grad()
    value_loss.backward()
    self.critic_optimizer.step()

    # advantage = Q_t - V(s_t)
    ~~pred_value = self.critic(state)~~
    advantage = (targ_value - pred_value).detach()  # not backpropagated
    policy_loss = -advantage * log_prob
    policy_loss += self.entropy_weight * -log_prob  # entropy maximization

    # update policy
    self.actor_optimizer.zero_grad()
    policy_loss.backward()
    self.actor_optimizer.step()

    return policy_loss.item(), value_loss.item()

minor comment in the following table.

Method
Note

select_action
select an action from the input state.

step
take an action and return the response of the env.

update_model
update the model by gradient descent.

train
train the agent during num_frames.

test
test the agent (1 episode).

_plot
plot the training progresses.

I check complete.