App with target SDK 31+ crashes on Android 12+

Expected Behaviour
App does not crash when starting location monitoring.
Actual Behaviour
App crashes when starting location monitoring.
Reproduce Scenario (including but not limited to)
Start location monitoring in build targeting SDK 31+ on Android 12+ device.
Google are now requiring all apps to target at least SDK 31.
places-monitor-android does not support SDK 31+, because it doesn't use the correct flags for pending intents.
Steps to Reproduce

Build Android app with target SDK 31+
Call FlutterACPPlacesMonitor.start() on Android 12+ device.

Platform and Version
Flutter 3.3.9, flutter_acpplaces_monitor 2.0.1, Android 12
Sample Code that illustrates the problem
FlutterACPPlacesMonitor.start()
Logs taken while reproducing problem
E/AndroidRuntime(13768): java.lang.IllegalArgumentException: <redacted>: Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent.
E/AndroidRuntime(13768): Strongly consider using FLAG_IMMUTABLE, only use FLAG_MUTABLE if some functionality depends on the PendingIntent being mutable, e.g. if it needs to be used with inline replies or bubbles.
E/AndroidRuntime(13768):        at android.app.PendingIntent.checkFlags(PendingIntent.java:375)
E/AndroidRuntime(13768):        at android.app.PendingIntent.getBroadcastAsUser(PendingIntent.java:645)
E/AndroidRuntime(13768):        at android.app.PendingIntent.getBroadcast(PendingIntent.java:632)
E/AndroidRuntime(13768):        at com.adobe.marketing.mobile.PlacesLocationManager.getPendingIntent(PlacesLocationManager.java:375)
E/AndroidRuntime(13768):        at com.adobe.marketing.mobile.PlacesLocationManager.access$100(PlacesLocationManager.java:45)
E/AndroidRuntime(13768):        at com.adobe.marketing.mobile.PlacesLocationManager$1.onSuccess(PlacesLocationManager.java:139)
E/AndroidRuntime(13768):        at com.adobe.marketing.mobile.PlacesLocationManager$1.onSuccess(PlacesLocationManager.java:127)
E/AndroidRuntime(13768):        at com.google.android.gms.tasks.zzm.run(com.google.android.gms:play-services-tasks@@18.0.2:1)
E/AndroidRuntime(13768):        at android.os.Handler.handleCallback(Handler.java:938)
E/AndroidRuntime(13768):        at android.os.Handler.dispatchMessage(Handler.java:99)
E/AndroidRuntime(13768):        at android.os.Looper.loopOnce(Looper.java:201)
E/AndroidRuntime(13768):        at android.os.Looper.loop(Looper.java:288)
E/AndroidRuntime(13768):        at android.app.ActivityThread.main(ActivityThread.java:7839)
E/AndroidRuntime(13768):        at java.lang.reflect.Method.invoke(Native Method)
E/AndroidRuntime(13768):        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
E/AndroidRuntime(13768):        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

??

Places monitor is no longer supported, it is deprecated in August 2021.

@cacheung Yes, I know. I had to create my own fork of it to make it work. Why are you using it in this package, and why is there no mention of that in the documentation for this package?

@peter-nilsson-scotts Thanks for the feedback.  We added the deprecation message in the readme.
Thanks,
Calise

@cacheung Thanks. Don't forget to update https://pub.dev/packages/flutter_acpplaces_monitor as well. :-)

We won't be able to update the readme there without a release. We marked the package DISCOUNTIUED.
Thanks,
Calise


Doesn't work with jsdom >= 10.0.0

jsdom changed the API in version 10.0.0
https://github.com/tmpvar/jsdom/blob/master/Changelog.md#1000
Newer versions show the following error:
Message:
    jsdom is not a function
Stack:
TypeError: jsdom is not a function
    at Object.<anonymous> (/home/atd/dev/cartodb.js/node_modules/simple-jsdom/index.js:4:16)
    at Module._compile (module.js:570:32)

Thanks @atd , I'll take a look. Also, it's worth noting that this lib seems to work with jsdom 10.0.0 and had better marketing than this lib, so everyone is usin' that these days! :)

Thank you for the pointer @jmeas ! Very considerate from you.
I ended up switching libraries because of another issue: it seems to be a race condition and tests are passed before the global namespace is modified


Can you guys make the Escape/Pause Menu Togglable?

Some might prefer having the default escape/pause menu and keep the loading screen that the mod provides.
So a toggle in the mod settings would be nice..
That's just a suggestion, Thank you!

This is mentioned in #2 actually and my anwser is yes but not now because im still working on other features and when those features are finished, config will be added.

done in 0.0.3-beta


perf: try harder to operate on new data

With gzip the buffer can grow a lot, leading to a lot more work when
counting newlines. To improve performance we discard everything up to the
previous document when preparing the buffer for the next document.
Depends on https://github.com/elastic/go-docappender/pull/123

Is there anything you would change about #129? afaics it is safer, more performant and more concise. I didn't mean to step on your toes with this - apologies if it feels that way! I mostly did it because I'm already knee-deep in this code at the moment and I needed to understand the code closely :) I'd be happy to merge it if it works with you.

No worries 😄 I don't see any problem with #129 but I think error handling should be added separately from buffer reuse. Some of the changes also make the code harder to follow IMO, e.g. the continue statement of the change of the loop statement to len(buff) == 0

Sounds good - question of style choices - I find continue more readable as it reduces the context relevant to code below. But it's good either way :)
And you will laugh but I had added len(buff) == 0 for readability only, because the code doesn't quite behave as the comments say otherwise. Now that our implementations are similar, your code has the same problem too - I'll explain it in a separate comment.


README is in bad shape

There is some vital info missing in the README, config and aliases etc.
@skorokithakis, I'll look into this at some point.

Ah, good call, thanks.


Update README.md to add "Work in progress" tag to the test-net environment

Temporal prevention because of #7.

Note: If accepted, commits should be merged into one. It was my fault to use two commits for such a little change.


Supporting int32 value type in TextFileInitializer.

Click to expand!
Issue Type
Feature Request
Source
source
Tensorflow Version
tf 2.9
Custom Code
No
OS Platform and Distribution
Linux
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
In [TextFileInitializer](https://github.com/tensorflow/tensorflow/blob/359c3cdfc5fabac82b3c70b3b6de2b0a8c16874f/tensorflow/python/ops/lookup_ops.py#L731) we have a validation to check whether the value_dtype is of type tf.int64, wondering why do we have such constraints?

The context is that, we are trying to initialize a vocabulary lookup table in the TensorFlow model and would like to save memory for the HashTable, both the key and value type can be of int32 type, but seems that the value type is restricted to int64.

Standalone code to reproduce the issue
initializer = tf.lookup.TextFileInitializer(
                    vocab_file,
                    key_dtype=tf.int64, key_index=0,
                    value_dtype=tf.int32, value_index=1,
                    delimiter=" ")

Relevant log output
[0]<stderr>:    vocab_table = tf.lookup.StaticVocabularyTable(initializer=initializer, num_oov_buckets=1)
[0]<stderr>:  File "/home/coder/ads-ai-offline/build/scin-azkaban/environments/development-venv/lib/python3.7/site-packages/tensorflow/python/ops/lookup_ops.py", line 1235, in __init__
[0]<stderr>:    (dtypes.int64, initializer.value_dtype))
[0]<stderr>:TypeError: Invalid value dtype, expected <dtype: 'int64'> but got <dtype: 'int32'>.

@supercharleszhu
I was able to execute the code without any error on Colab using TF v2.10. Please find the gist here for reference.
Thank you!


Revert "Moved Royal Hackaway v3 to Past Events"

Reverts HHEU/wiki#131. The event isn’t over yet! @wrussell1999 @ksouthern

The GitHub webpage didn’t work! I swear I pressed draft....


table()->update fails in php 5.3

Using the mass update feature as currently documented does not work in PHP 5.3..
PHP 5.3 deprecated call-time pass by reference..
As documented:
Blarg::table()->update(array(...), array(...))
will throw an error that the parameter cannot be passed by reference.
If you do
$a = array( ... );
$b = array( ... );
Blarg::table()->update($a,$b);
Then it is ok..
I would suggest we just remove the pass by reference:
--- a/lib/Table.php
+++ b/lib/Table.php
@@ -341,7 +341,7 @@ class Table
return $this->conn->query(($this->last_sql = $sql->to_s()),$values);
}

  public function update(&$data, $where)

  public function update($data, $where)
  {
          $data = $this->process_data($data);

+1


node: documentation for code supporting answer, ask, and vote

DOCUMENT the following:
In contributor/index.js:
patchReputation()
In qnaDoc/index.js:
getUniqueContent()
post()
In qnaDoc/patch.js:
votePatch()
patchQuestionVote()
xpathAnswerSelect()
patchAnswerVote()
patchQuestionAddAnswer()
In routing/question.js:
notAlreadyVoted()
Also REMOVE, in contributor/index.js:
patchVoteCount() (Not used. Functionality is handled by votePatch() in patch.js.)

This PR replaces https://github.com/laurelnaiad/marklogic-samplestack/pull/74 and https://github.com/laurelnaiad/marklogic-samplestack/pull/76


openssh 7.3p1: sshd won't take connections, @PREFIX@ in binary

With OpenSSH 7.3p1 installed from bottle, sshd will start and accept connections but kill all children; running sudo /usr/local/sbin/sshd -D -d we see:
debug1: Local version string SSH-2.0-OpenSSH_7.3
ssh_sandbox_child: sandbox_init<EMAIL_ADDRESS>profile not found [preauth]

That @PREFIX@ comes from the patch patch-sandbox-darwin.c-apple-sandbox-named-external.diff and makes it through to the binary.
Making the sshd writable and running hexedit on it, to change the path to /usr/local/etc/ssh/org.openssh.sshd.sb without changing anything else, the bottled binary works and accepts connections without dying.

We'll accept PRs for this but we're not actively working on it at this time.

Try brew reinstall openssh. I wasn't able to reproduce this locally, so maybe the bottle poured oddly for you locally or something.

A Bottle is a binary package. It can't be "poured oddly" to change the contents of the binary (without being a major security issue).
I do see that I neglected to provide platform information: 10.10.5 Yosemite; I did not review all bottles to determine if this flaw only affected some, as I (naively?) assumed that the same build process would be used on all platforms, so that what's a bug on one is a bug on all.
I will put a PR on my backlog burner of tasks, thanks.

Sorry, I didn't realise you'd been maintaining Homebrew for quite some time now. Must have missed you in the team chat.
Homebrew performs relocation on some strings so that bottles are not always limited to the prefix they were built for. This has caused the occasional issue before. Forgetting temporarily that we use @@HOMEBREW_PREFIX@@ as our marker rather than @PREFIX@ I wondered if this was related.
As I said above, I cannot reproduce your issue. I look forwards to your PR.

I have also had to hack the binary to make this work on Yosemite (10.10.5).  Any chance there's a fix forth coming?

Any chance there's a fix forth coming?

There is not unless someone creates a PR.

I am seeing the same issue on Yosemite 10.10.5, sshd version OpenSSH_7.3, OpenSSL 1.0.2j  26 Sep 2016.  Any incoming connection causes:
debug1: Local version string SSH-2.0-OpenSSH_7.3
ssh_sandbox_child: sandbox_init<EMAIL_ADDRESS>profile not found [preauth]

I just submitted a pull request that fixes this issue.
https://github.com/Homebrew/homebrew-dupes/pull/665

Just upgraded to OpenSSH 7.4p1 and this issue is back!?  Figured you'd at least fix it in the new version even if you didn't want to fix the old version.

I have this issue.
Sierra 10.12.3 - homebrew  OpenSSH 7.4p1 compiled against LibreSSL:
ssh_sandbox_child: sandbox_init<EMAIL_ADDRESS>profile not found [preauth]


Bug in WithUnknownContent for elements with attribute name

Hey,
I've found a bug which drives me crazy. First of all I haven't known the Feature WithUnknownContent. After model change my object was partly null. After setting WithUnknownContent().Continue() this was gone. JM2C: Perhaps it will make the library more robust with Continue as default.
After setting WithUnknownContent in some cases the object still was partly null. The reason I've found was a scenario where the Unknown content lies in root object and has name of a valid attribute. Then the Continue behavior will not work.
This TestCase can be used for reproducing the issue:
namespace Test.XmlSerializer
{
    using System.Diagnostics;
    using System.Xml.Serialization;
    using ExtendedXmlSerializer.Configuration;
    using ExtendedXmlSerializer;
    using Microsoft.VisualStudio.TestTools.UnitTesting;

    [TestClass]
    public class BugAttributeInsteadOfElement
    {
        [TestMethod]
        public void Test()
        {
            var serializer = new ConfigurationContainer().WithUnknownContent().Continue().Create();

            // Create an object which have its Id as attribute
            var obj1 = new RootObjectIdAttribute() {Id = 1, Name = "RootObjectId 1"};
            var text1 = serializer.Serialize(obj1);
            Trace.WriteLine(text1);
            // <?xml version="1.0" encoding="utf-8"?><BugAttributeInsteadOfElement-RootObjectIdAttribute Id="1" xmlns="clr-namespace:Test.XmlSerializer;assembly=Test"><Name>RootObjectId 1</Name></BugAttributeInsteadOfElement-RootObjectIdAttribute>

            // Create an object which have its Id as element
            var obj2 = new RootObjectIdElement() {Id = 2, Name = "RootObjectId 2"};
            var text2 = serializer.Serialize(obj2);
            Trace.WriteLine(text2);
            // <?xml version="1.0" encoding="utf-8"?><BugAttributeInsteadOfElement-RootObjectIdElement xmlns="clr-namespace:Test.XmlSerializer;assembly=Test"><Id>2</Id><Name>RootObjectId 2</Name></BugAttributeInsteadOfElement-RootObjectIdElement>

            // TEST 1: Change object types which allows deserialize type
            var bugText1 = text2.Replace("RootObjectIdElement", "RootObjectIdAttribute");
            var bugObj1 = serializer.Deserialize<RootObjectIdAttribute>(bugText1);
            // RESULT 1: BUG encountered! Name is null although WithUnknownContent().Continue() is enabled
            Assert.IsNull(bugObj1.Name);

            // TEST 2: Set Id as Attribute and parallel as unknown element
            var bugText2 = bugText1.Replace("-RootObjectIdAttribute", "-RootObjectIdAttribute Id=\"1\"");;
            var bugObj2 = serializer.Deserialize<RootObjectIdAttribute>(bugText2);
            // RESULT 2: BUG also exists in case the attribute is set too
            Assert.IsNull(bugObj2.Name);

            // TEST 3: Rename element Id to Id2 - therefore it has not the same name as expected attribute
            var bugText3 = bugText1.Replace("<Id>", "<Id2>").Replace("</Id>", "</Id2>");
            var bugObj3 = serializer.Deserialize<RootObjectIdAttribute>(bugText3);
            // RESULT 3: Works just fine
            Assert.IsNotNull(bugObj3.Name);

            // => BUG happens only if an unknown content is determined which has same name as an expected attribute!
        }

        public class RootObjectIdAttribute
        {
            [XmlAttribute]
            public int Id { get; set; }

            public string Name { get; set; }
        }

        public class RootObjectIdElement
        {
            public int Id { get; set; }

            public string Name { get; set; }
        }
    }
}

The scenario above is very commen in case the annotation for a property changes to XmlAttribute and Migration is not used.
Regards
Thomas

WHEW you are giving me a run for my money on this extension @thomasjoscht 😅  It is good though.  I will always try to put my time due diligence-wise to see if a bug can be squashed.  As I mentioned anything, involving the reader makes me want to curl up into fetal position and cry myself to sleep.  This was no exception as it has to do with guts (and I mean that in all meaning of the term!) of the reader.
I think I managed a way to crawl through the muck and fix this particular issue, however. 🤞  Please check it out here and let me know if it works for you:
https://github.com/ExtendedXmlSerializer/home/pull/492#issuecomment-739323794

Hey @Mike-E-angelo, thx for your incredible good work! I've tested it with my application and it seems that bug is fixed. Everything runs nicely. I'm waiting for a new nuget release where this and #483 is integrated. I wish you have a nice advent.

Thank you for the kind words @thomasjoscht.  You can find that NuGet package here:
https://www.nuget.org/packages/ExtendedXmlSerializer/
Please do let me know of any issues you encounter and I will look into them for you.  Closing for now.


Correction for raw affiliation Schulich School of Medicine and Dentistry, Western University, London, ON.

Correction needed for raw affiliation Schulich School of Medicine and Dentistry, Western University, London, ON.
raw_affiliation_name: Schulich School of Medicine and Dentistry, Western University, London, ON.
new_rors: 02grkyz14
previous_rors: 05cgtjz78
works_examples: W4322101891;W4381383432;W4388206358;W4381893195
contact: 3fdc03aab95510818e9da23583abdc87:7ec30d7e4ca1b59e @ uwo.ca

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


Frontend fixes for react-bootstrap and a11y

Hello,
Sorry for merging multiple small fixes in one PR.
a11y fixes
font-size changes
Accessibility fixes related to color contrast turned out to be a little challenging, as bootstrap purposely sacrifices a11y for their preferred color palette.  So instead of trying to change the colors, I made everything a little bigger to pass the WCAG tests. Font sizes have been bumped a little.
svg color changes
Updated the thumbnail svg background fill color to be more readable and pass the WCAG color contrast test.
Frontend  fixes
Usage of react-bootstrap components
Replaced divs and bootstrap layout / component classes with react bootstrap components like Container, Row, Col and Card. Most of the components are drop in replacement for the bootstrap classes previously being used in the project.
Fixed grid layout
Using the Grid layout with Rows and Columns fixed the issue of columns not properly displaying 4 items in all the rows as it should for >1200px vw.
It still follows the same responsive column count from the earlier custom CSS.

The home page grid items are a little too nested but I couldn't think of better way to implement the Cards without adding a Col for each.
Replaced custom CSS
Replaced most off the  custom CSS with responsive bootstrap classes
Other minor fixes

Capitalized title text for item page
Fixed some text to remove extra whitespaces and
Removed unused custom CSS. This  should help with maintaining the project with just bootstrap and react-bootstrap components.

Let me know if  any of the changes need to be rolled back or need some more fixing.
Thank you.

Thanks @vimode, all looks good to me!


Sync WSL Leap15.4

https://progress.opensuse.org/issues/103392

https://app.circleci.com/pipelines/github/os-autoinst/openqa-trigger-from-obs/466/workflows/fe349896-fda8-443f-8125-82832ecd7d94/jobs/824 says that openSUSE:Leap:15.2:WSL/read_files.sh does not exist anymore so I guess there is still a reference to 15.2:WSL somewhere that you need to adapt

https://app.circleci.com/pipelines/github/os-autoinst/openqa-trigger-from-obs/466/workflows/fe349896-fda8-443f-8125-82832ecd7d94/jobs/824 says that openSUSE:Leap:15.2:WSL/read_files.sh does not exist anymore so I guess there is still a reference to 15.2:WSL somewhere that you need to adapt

Yup, unfortunately there is a different dist_path. Thanks!

LGTM!


Fluid-Fluid-Solid simulations?

Hello,
Is it currently possible to do triple-phase simulations involving two fluid phases and a solid phase?

I see. Thanks for the update!


feat(dep-check): add migration message

Description
Tell users to migrate to @rnx-kit/align-deps.
Test plan
cd packages/dep-check
yarn build --dependencies

What are your plans for the dep-check package going forward?

I'm thinking we should remove it and add a notice on npm that this package has been deprecated. I will check on usage numbers some time next month (or after new years) before proceeding. We can probably already add the deprecation notice after this change has been published. What are your thoughts?

What are your plans for the dep-check package going forward?

I'm thinking we should remove it and add a notice on npm that this package has been deprecated. I will check on usage numbers some time next month (or after new years) before proceeding. We can probably already add the deprecation notice after this change has been published. What are your thoughts?

This makes sense.
People will start seeing this warning message when they run it, and soon after, when you mark is deprecated on npm, they'll see warnings when they install it too.
After that, I think you can delete the package from the repo. We won't service it anymore. align-deps was done very carefully so that it can support migrating users easily. I don't think we should try to continue maintaining dep-check at all. People can always stay on the last working copy of it until they are ready to upgrade.
Great work!

After that, I think you can delete the package from the repo. We won't service it anymore. align-deps was done very carefully so that it can support migrating users easily. I don't think we should try to continue maintaining dep-check at all. People can always stay on the last working copy of it until they are ready to upgrade.

This may be too aggressive, actually. There are links out there which point to the dep-check package. So maybe just reduce it down to a mostly-empty placeholder package.json file and a README, since I suspect most links are to the root of the package or the README.


George/grinder enum perf01

updated grinder properties files for the various environments;
the staging props now use the grinder endpoints which bypass the repose endpoints

+1

+1


If two different handlers are used in one document, the jinja env is not updated

Found another issue/question with what I was trying to do with a custom handler.
If one document has two identifiers that use different handlers; only the first one's env is updated.  My templates error out because the default mkdocstring filters are missing (highlight, heading or convert_markdown) don't exist in the second handler yet and instead I only have the built-in jinja filters and the any filter that is added when the env is initialized.
::: mkdocstrings_handlers.custom_handler.other_module.AccessTypes
    handler: python

::: demo.custom_identifier.stuff
    handler: custom_handler

It looks like these few lines are the offenders and I'm curious if there is a drawback to updating it every time, updating the env on init or make the _updated_env a part of the handler and not the extension?  Commenting out self._updated_env = True is enough to resolve this issue.
        if not self._updated_env:
            log.debug("Updating renderer's env")
            handler._update_env(self.md, self._config)  # noqa: WPS437 (protected member OK)
            self._updated_env = True

Hey, nice catch! Indeed it does make sense to hold that _updated_env boolean at the processor level. Instead, each handler should have its own (or none). Do you want to open a PR?

Yup, I can do that!

Introduced in #201


how to use sass files

Kindly suggest how to use sass files for creating application

Currently sass/scss support is not implemented in the project. But webpack makes it easy to do so.
Install sass-loader via npm and register the loader for *.scss files. Add the following somewhere in the module loaders, e.g. below this line:
    {
        test: /\.scss$/,
        exclude: /node_modules/,
        loader: 'style-loader!css-loader!sass-loader'
      },

The sass-loader transformes your scss files into valid css code, which are then consumed by the css-loader and style-loader. For more details see also: https://github.com/jtangelder/sass-loader

Still don't get it, @dotcs can you provide an example? I have a 'styles' folder under app. Something like this
app
|-styles
|-main.scss
After installing sass-loader and put above config code at webpack.config. I don't see main.scss gets mapped to css and be loaded in browser.

In webpack:
{
        test: /\.scss$/,
        exclude: /node_modules/,
        loader: 'raw-loader!sass-loader'
}

Then in your component:
@Component({
  styles: [ require('./filename.scss') ],
})

Angular2 expects a string in the styles array, because it modifies the string to encapsulate the styling. Using style-loader/css-loader loads the css and inject to the html, without encapsulating, and doesn't return a string, raw-loader just load the file as string and pass it to sass-loader, which also return a string.

What about global styles, ones not tied to components?
Using loaders: ["style", "css", "sass"] works but throws errors preventing the app to run.

If anyone else was a little confused to what @gdi2290 suggested:
import {ViewEncapsulation} from 'angular2/core';
@Component({
  encapsulation: ViewEncapsulation.None,
})

Opened #199 to consolidate these issues.

@liampmccabe thanks for the heads-up. I was confused ;)

I created a scss wiki page if anyone wants to update it to be more clear
https://github.com/AngularClass/angular2-webpack-starter/wiki/How-to-include-SCSS-in-components

@gdi2290 - Is it possible to override bootstrap variables along with the implementation from your wiki?

@gdi2290 your wiki page works fine,
but my problem is, my SASS file imports my other CSS files which load images with URL, and so my reference to this images are now wrong.
Is there a possibility to save the compiled SASS file under a folder and then include in manually in index.html?
something like that?
thx
Michael

@mburger81 you can import it as you normally would using the embedded stylesheets(see https://webpack.github.io/docs/stylesheets.html) then in your app.ts you would have
require("./app.scss");

@Component({
  selector: 'app',
  template:``
})

There are cases where you need global styles and also enjoy the benefits of encapsulated components. I have adopted a policy of naming component files so they end with component.scss. Webpack can then choose the right loader chain like this:
{ test: /^(?!.*component).*\.scss$/, loaders: ['style', 'css', 'resolve-url', 'sass'] },
{ test: /\.component\.scss$/, loaders: ['raw', 'resolve-url', 'sass'] },

Of course, be sure to create a common or global entryPoint with the applicable require statements and load it in  before your bundle containing angular.

@akeating  Can you explain what you mean, in a different way? I don't quite understand what the benefit of having both of those loaders is. I would like to use global styles as well as encapsulated styles too.

Hey guys, my sass is working perfectly with my components, but I can't make it work with karma. what should I do?

@mburger81 that doesn't works, and 'resolve-url' should go before sass-loader, webpack loaders are loaded from right to left, so resolve-url fail with sass rules (however after change it to the correct way it doesn't work), the builded css leaves the url like the sass and file-loader (I use it) don't copy the assets.

I have sass working. I have a bootstrap.scss that I load as a global style, and then other styles for each component. The only issue now is that when I put variables in my component style sheets that I define in my global style they don't work.
Any ideas about how to get it all to work?
Thanks!
Scott

@scottmahr perhaps break your variables into a separate common file _variables.scss and import it as needed at the top of your component similarly to the way bootstrap does (obviously the path will be different):
// Core variables and mixins
@import "variables";
@import "mixins";

raw!sass pipe works fine for me but when I use UglifyJS plugin it breaks the styles...
I have opened a question on stack overflow, you can see more details there.

@akeating I've tried using your proposal for encapsulate styles in components
{ test: /\.component\.scss$/, loaders: ['raw', 'resolve-url', 'sass'] }
However, it's not resolving my url() paths. The final CSS simply has the same path as defined in the component's sass code.
Is there some additional config to go along with this?

@rjmarques check that your sass loader is configured to generate source maps (details https://github.com/bholloway/resolve-url-loader).

Changed it to
{ test: /\.component\.scss$/, loaders: ['raw', 'resolve-url', 'sass?sourceMap'] }
Still not working.
So far the only way I've been able to have the *url()*s working correctly was with
{ test: /\.component\.scss$/, loaders: ['exports-loader?module.exports.toString()', 'css', 'sass'] }
Sourced from here.

It's hard to say what your issue is exactly. I use resolve-url in conjunction with url-loader to setup my assets (file-loader would be fine too). The assets are emitted into the output directory or embedded right in the css file. Any urls are resolved relative to the output directory, which becomes your webroot. Obviously modify to suit your particular circumstances and build.
{ test: /.(png|woff(2)?|eot|ttf|svg)(\?[a-z0-9=\.]+)?$/, loader: 'url-loader?limit=100000' }.

@rjmarques I reproduced this issue too. It looks like resolve-url-loader had problems with sass-loader#4.0.0, so upgrade to latest resolve-url-loader#1.6.0. This variation including resolve-url, worked as well:
{ test: /\.component\.scss$/, loaders: ['exports-loader?module.exports.toString()', 'css', 'resolve-url', 'sass?sourceMap'] }

Thanks for taking the time to follow up on this @akeating =)
Hopefully people will stumble upon this thread if they run into the same problems I, and others, did!

I've implemented https://github.com/AngularClass/angular2-webpack-starter/wiki/How-to-include-SCSS-in-components already.
import { Component } from '@angular/core';
require('../../public/css/styles.scss');

@Component({
    selector: 'my-app',
    templateUrl: './app.component.html',
    styles: [require('./app.component.scss')]
})
export class AppComponent { }

The app.component.scss is parsed correctly but styles.scss is still failed to load.

What about:
import { Component } from '@angular/core';
import '../../public/scss/styles.scss';

 @Component({
    selector: 'my-app',
    templateUrl: './app.component.html',
    styles: [require('./app.component.scss')]
 })

 export class AppComponent { }
```

This is how I made mine work: https://github.com/rjmarques/angular2-typescript-recipe

@rjmarques I copied your webpack settings, it solves my issue. Thank you. The key is the following
{
        test: /\.scss$/,
        exclude: helpers.root('src', 'app'),
        loader: ExtractTextPlugin.extract('style', 'css?sourceMap!resolve-url!sass?sourceMap')
      },
      {
        test: /\.scss$/,
        include: helpers.root('src', 'app'),
        loaders: ['exports-loader?module.exports.toString()', 'css', 'sass']
}

@rjmarques I use your method
  {         test: /\.scss$/,         exclude: /node_modules/,         loaders: ['exports-loader?module.exports.toString()', 'css', 'sass?sourceMap']       }
It work well but file are renamed and put at the root of the dist folder:
Exemple
//file name src/app/HomePage/HomePageComponent.scss div {     background-image: url('./images/header.png'); }
Will take the './images/header.png' and copy it to 'dist/1dba29a2fdaef4bf64aaa025742982d7.png'.
I was wondering if there is way to configure this so the file are copied to something like:
dist/app-assets/HomePage/images/header.png
I am sure there is a way but I am fairly new to all this (all the frontend tools, I am a PHP/Symfony backend developer).
Thanks !
p.s. Best thing would be to have the md5 file value in the name file caching (cdn) would not need to be purge
dist/app-assets/HomePage/images/header.{md5FileValue}.png

@mpoiriert
When defining your webpack loaders:
{
    test: /\.(png|jpe?g|gif|svg|woff|woff2|ttf|eot|ico)$/,
    loader: 'file?name=app-assets/[path][name].[hash].[ext]'
}

Note this will copy the full path of the image. So you'll have:
dist/app-assets/src/app/HomePage/images/header.hash12345.png
If you don't want the hash remove the [hash] param.
For more info, have a look at: https://www.npmjs.com/package/file-loader
Hope this helps!

I have an issue when I use sass files and use the @extend to extend a class from a library (materialize-css). I extend the classes of the libraries in many components and because of the raw-loader it gets copied to each and every component in the bundle. It blows my bundle file from 1MB to 5MB just when I use the styles. I don't want to use the classes of the external library on my html and would like to use the @extend syntax. I opened a question on stack overflow as well: angular2 webpack large bundle size with sass
Do i miss something? can anyone help ?

@MFateen - did you fix the issue with running karma? I have the same issue - would appreciate any help or pointers

@kingsleyh in a matter of fact yes, I only needed to add to my module: { preLoaders: [    in webpack.test.js
{
    test: /\.scss$/,
    exclude: /node_modules/,
    loaders: ['raw-loader', 'sass-loader']
  }

hmm still not working for me - anyone know what this issue might be?
23 08 2016 16:38:12.947:INFO [karma]: Karma v1.2.0 server started at http://localhost:9876/
23 08 2016 16:38:12.951:INFO [launcher]: Launching browser PhantomJS with unlimited concurrency
23 08 2016 16:38:13.084:INFO [launcher]: Starting browser PhantomJS
23 08 2016 16:38:14.511:INFO [PhantomJS 2.1.1 (Mac OS X 0.0.0)]: Connected on socket /#ncsROZnaHSN1IIn3AAAA with id 83441766
23 08 2016 16:38:15.172:WARN [web-server]: 404: /assets/scss/styles.scss
PhantomJS 2.1.1 (Mac OS X 0.0.0) AppComponent should have a title FAILED
       	Failed: Uncaught (in promise): Failed to load assets/scss/styles.scss
       	invoke@spec-bundle.js:6807:35
       	run@spec-bundle.js:6700:51
       	spec-bundle.js:7055:62
       	invokeTask@spec-bundle.js:6840:44
       	runTask@spec-bundle.js:6740:59
       	drainMicroTaskQueue@spec-bundle.js:6958:44
       	run@spec-bundle.js:4087:30
       	spec-bundle.js:4100:32
       	flush@spec-bundle.js:4455:12
       	TypeError: undefined is not an object (evaluating 'fixture.componentInstance') in spec-bundle.js (line 58282)
       	spec-bundle.js:58282:30
       	spec-bundle.js:22544:29
       	invoke@spec-bundle.js:6807:35
       	run@spec-bundle.js:6700:51
       	spec-bundle.js:7055:62
       	invokeTask@spec-bundle.js:6840:44
       	runTask@spec-bundle.js:6740:59
       	drainMicroTaskQueue@spec-bundle.js:6958:44
       	run@spec-bundle.js:4087:30
       	spec-bundle.js:4100:32
       	flush@spec-bundle.js:4455:12
PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 1 of 1 (1 FAILED) ERROR (0.103 secs / 0.128 secs)

its like its missing some of the test dependencies - this is my test:
import {
  describe,
  it,
  expect,
  inject,
  injectAsync,
  beforeEach,
  TestComponentBuilder,
  ComponentFixture
} from 'angular2/testing';

import { AppComponent } from './app';

describe('AppComponent', () => {
  let fixture: ComponentFixture;

  beforeEach(injectAsync([TestComponentBuilder], tcb => {
    return tcb.createAsync(AppComponent)
      .then(f => fixture = f);
  }));

  it('should have a title', () => {
    // given a component instance
    let appCmp = fixture.componentInstance;

    // when we trigger the change detection
    fixture.detectChanges();

    // then we should have a name
    let element = fixture.nativeElement;
    expect(element.querySelector('h1')).toHaveText('Team Chemistry');
  });
});

if I comment out fixture.componentInstance - it errors on the fixture.detectChanges() and if I comment that out to - it errors on fixture.nativeElement

@kingsleyh check the angular2 version you are  using because in the latest releases you don't write these imports anymore

@kingsleyh you're on RC-5 right? I had to change a few things when migrating from RC-4.
Have a look at:

https://github.com/rjmarques/angular2-typescript-recipe/blob/master/src/app/app.component.spec.ts

I'm using: "angular2": "^2.0.0-beta.17" - not sure how old that is.
I think the problem is that the scss is not being found when running the test with Karma. I'm not sure if the scss files need to be somehow moved into place.
The tests pass if I comment out the styleUrls:
import { Component, ViewEncapsulation } from 'angular2/core';

@Component({
    selector: 'app',
    styleUrls: ['./assets/scss/styles.scss'],
    encapsulation: ViewEncapsulation.None,
    template: require('./app.html'),
})

export class AppComponent {
}

I'm my main webpack.conf.js I copy the assets into place:
plugins: [
    // Copy static assets to the build folder
    new CopyWebpackPlugin([{from: 'src/assets', to: 'assets'}]),
    // Generate the index.html
    new HtmlWebpackPlugin({template: 'src/index.html'})
]

I tried putting that in to the webpack.test.config.js but doesnt seem to help

@rjmarques thanks - the 2.0.0-beta.17 seems to be the latest available npm package for angualr2 - so I guess i'm on the bleeding edge. It doesn't seem to have any of the TestBed support you have in your version.

@kingsleyh the 2.0.0-rc.5 (2016-08-09) is the latest available.
please see https://github.com/angular/angular/blob/master/CHANGELOG.md

@kingsleyh
https://github.com/angular/angular/blob/master/CHANGELOG.md
Isn't 2.0.0-beta.17 from back in April?
Here's my package.json
What specific package are we talking about?

hmm - I'm a bit lost :( - I think I must have done npm install angular2 - which has given me the latest available npm package of angular2 - which is the beta.17 - which is from back in April. why has your package.json got so many different parts of angular some at rc4 and some at rc5 - isn't there a single npm for the rc versions? - and should I just copy your dependencies to get mine working?

Maybe follow the Tour Of Heroes?
On Tue, Aug 23, 2016, 13:31 Kingsley Hendrickse<EMAIL_ADDRESS>wrote:

hmm - I'm a bit lost :( - I think I must have done npm install angular2 -
which has given me the latest available npm package of angular2 - which is
the beta.17 - which is from back in April. why has your package.json got so
many different parts of angular some at rc4 and some at rc5 - isn't there a
single npm for the rc versions? - and should I just copy your dependencies
to get mine working?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/AngularClass/angular2-webpack-starter/issues/136#issuecomment-241792534,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABeg9FLlLBdQLBVtb-p_ZqiAeICRxVuvks5qiyBHgaJpZM4GsPDM
.

Building on the previous comment:
https://angular.io/docs/ts/latest/quickstart.html

hmm - so far I'm completely underwhelmed with Angular2 - it's so hard to get going and confusing with so much change going on. I think I might go back to Angular1 or React and come back to Angular2 next year when it's more stable

@kingsleyh I can pair with you this Saturday to update your project to the latest version so you're not discouraged about Angular2

@rjmarques thanks for the link
@gdi2290  - the main issue I'm struggling with is the testing. Thanks for the offer - If you don't mind that would be awesome.

Thanks to @akeating and @gdi2290 for all the advice above.  Works great.
Has anyone been able to get scss files loaded this way through styleUrls to work with HMR so only the CSS gets reloaded?  (In my testing this works with scss files included at a global scope, but not with ones included with components)

Hey, I am on the initial release version with the following returned from ng -v
angular-cli: 1.0.0-beta.14 node: 6.6.0 os: darwin x64
I am creating my project with
ng new projectname
The only webpack.config.js files I am seeing are under ./node-modules/... I am a little slow to touch those files.  Should I be seeing a copy of this file somewhere else?  Do i need to create it?  Any help appreciated.

With<EMAIL_ADDRESS>it just works out of the box:
@Component({   selector: "semi-automatic-overview",   styleUrls: ["./semiAutomaticOverview.scss"],   templateUrl: "./semiAutomaticOverview.view.html" })
.semiAutomaticOverview {   color: green;   .dropdown-menu {     background-color: green;     color: yellow;   } }
scss Styling ends up being written to main.bundle.js as a string of css :-)

Have any one use scss with ngc? All the @imports in component scss, reports Resource not found error. Any suggestion?

Nice!  Thanks.  Absolutely loving Angular2 so far.

@teeSee I think all you need for .scss (instead of .sass) is
1st rename styles.sass to styles.scss
Update angular-cli.json
  "styles": [
    "styles.scss"
  ],

  "defaults": {
    "styleExt": "scss",
    "prefixInterfaces": false
  }

I am not able to use variables in my scss file. I have done all configurations as discussed above. Please see my issue here: #1152 TIA

@VishalGulati it will be easier to narrow down the problem if you post the error you're getting
I didn't exactly follow the same config as you posted. However I'm able to use variables: https://github.com/rjmarques/angular2-typescript-recipe/blob/master/public/scss/globals.scss

hi. I'm wondering if i can use sass variables in an agular 2 component. something like:
@Component({

  selector: 'my-component',

  template: `
    <div>
      <div class="test-div">test div 1</div>
    </div>
  `,

  styles: [
    `
    @import "variables";

    .test-div{
      border: 1px solid $test-color;
    }
  `]

})

my file _variables.scss:
$test-color: green !default;
it seems whatever I try the sass variables arent recognised.
Any help much appreciated.

Hey @tim-csaky-qhr =)
The sass used in my simple nav component uses a variable: $sideSpace
The variable is defined in the global's file.
At first glance your example looks fine. I'm not using inline component styling, however. I have files for everything.
What error(s) are you getting? Is your webpack sass loader definition the same/similar to mine?

Angular assumes your style is CSS, so it won't work. You need to import it
so you trigger thew underlying webpack loading mechanism that compiles your
SASS.
On Thu, Nov 24, 2016 at 4:39 PM rjmarques<EMAIL_ADDRESS>wrote:

Hey @tim-csaky-qhr https://github.com/tim-csaky-qhr =)
The sass used in my simple nav component
https://github.com/rjmarques/angular2-typescript-recipe/blob/master/src/app/shared/header/app-header.component.scss
uses a variable: $sideSpace
The variable is defined in the global's
https://github.com/rjmarques/angular2-typescript-recipe/blob/master/public/scss/globals.scss
file.
At first glance your example looks fine. I'm not using inline component
styling, however. I have files for everything.
What error(s) are you getting? Is your webpack sass loader definition the
same/similar to mine?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/AngularClass/angular2-webpack-starter/issues/136#issuecomment-262836376,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABeg9Nq-qYy_0As_4KxjOH6Jz4eVu4LNks5rBef8gaJpZM4GsPDM
.

hi there @rjmarques and @tinchou
Ahhh I see now!
that sounds like a good set-up.
i need to link to the variables from a sass file. so use the styleUrl[].
@Component({

  selector: 'my-component',

  template: `
    <div>
      <div class="test-div">test div 1</div>
    </div>
  `,
  styleUrls: ['local_sass_file.scss'],

})

local_sass_file.scss contains:
// variables:
@import "../../assets/css/variables";

my file global _variables.scss contains:
$test-color: green !default;
now if i can understand the rest of angular2 i'll be all set!

@kingsleyh , @gdi2290 have you be able fix the issue? I have exact issue with the test like you. Thanks

I'm not sure if it's possible, but I wonder if anyone success combined SASS SourceMaps and Angular 2 and ViewEncapsulation together

I followed the exact steps outlined in the Wiki entry (https://github.com/AngularClass/angular2-webpack-starter/wiki/How-to-include-SCSS-in-components) and I just get an error like the compiler is trying to reading comments like they're CSS:
ERROR in ./src/styles/styles.scss
Module build failed:
/* this file will be extracted to main dist folder and is imported in index.html */
^
      Invalid CSS after "...load the styles": expected 1 selector or at-rule, was "var content = requi"
      in /Users/stephen/repos/chanel-elevator-web/src/ipad/src/styles/styles.scss (line 1, column 1)
 @ ./src/app/app.module.ts 16:0-31
 @ ./src/app/index.ts
 @ ./src/main.browser.ts
 @ multi (webpack)-dev-server/client?http://localhost:3000 ./src/main.browser.ts

I'm trying to apply this globally, so my app.component.ts looks like this: (extract)
@Component({
  selector: 'app',
  encapsulation: ViewEncapsulation.None,
  styleUrls: [
    '../styles/styles.scss'
  ],

Am I doing something wrong?

"var content = requi" looks like JavaScript..
Use "//" for comments in scss
Best regards,
Kieran

From: Stephen Buchanan<EMAIL_ADDRESS>Sent: Wednesday, February 22, 2017 11:01:57 AM
To: AngularClass/angular2-webpack-starter
Cc: Kieran Ryan; Comment
Subject: Re: [AngularClass/angular2-webpack-starter] how to use sass files (#136)
I followed the exact steps outlined in the Wiki entry (https://github.com/AngularClass/angular2-webpack-starter/wiki/How-to-include-SCSS-in-components) and I just get an error like the compiler is trying to reading comments like they're CSS:
ERROR in ./src/styles/styles.scss
Module build failed:
/* this file will be extracted to main dist folder and is imported in index.html */
^
Invalid CSS after "...load the styles": expected 1 selector or at-rule, was "var content = requi"
in /Users/stephen/repos/chanel-elevator-web/src/ipad/src/styles/styles.scss (line 1, column 1)
@ ./src/app/app.module.ts 16:0-31
@ ./src/app/index.ts
@ ./src/main.browser.ts
@ multi (webpack)-dev-server/client?http://localhost:3000 ./src/main.browser.ts
I'm trying to apply this globally, so my app.component.ts looks like this: (extract)
@Component({
selector: 'app',
encapsulation: ViewEncapsulation.None,
styleUrls: [
'../styles/styles.scss'
],
Am I doing something wrong?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/AngularClass/angular2-webpack-starter/issues/136#issuecomment-281623573, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AB_CQsUT0WmlyE_9bdmC3ZlUY41MIaUfks5rfAeVgaJpZM4GsPDM.

Ah, I think I resolved it. The starter project includes an additional rule (in webpack.common.js) for scss files:
```
/*
* to string and sass loader support for *.scss files (from Angular components)
* Returns compiled css content as string
*
*/
{
test: /.scss$/,
use: ['to-string-loader', 'css-loader', 'sass-loader'],
exclude: [helpers.root('src', 'styles')]
},
Removing this rule made it work again. Perhaps the Wiki should include mention of this?

Someone needs to update the wiki entry again since it's no longer working with the current version


Refactor artichoke-backend build to use bindgen executable instead of dev-dependency

This PR updates the artichoke-backend build.rs to invoke bindgen via its CLI instead of as a library.
This change removes 10+ deps from Cargo.lock and is a workaround for bugs like https://github.com/rust-lang/cargo/issues/9756 which prevent production dependencies from upgrading to their most recent versions.
This PR translates the existing library invocation of bindgen to a command line invocation.
The build script first attempts to use a globally-installed (and available in $PATH) bindgen (such as is the case on @lopopolo's devbox and GitHub Actions runners). If this fails, the build scripts cargo install bindgens to the OUT_DIR and tries again.

Before:
$ rg '^name = "' Cargo.lock | cut -d' ' -f3 | wc -l
     101

After:
$ rg '^name = "' Cargo.lock | cut -d' ' -f3 | wc -l
      85

Excluding workspace-local packages, Artichoke is down to 68 deps.
$ rg '^name = "' Cargo.lock | grep -v artichoke | grep -v mezzaluna | grep -v scolapasta | grep -v spinoso | cut -d' ' -f3 | wc -l
      68


Package Compatibility, Umbraco 8.6.x

Hi, I'm staring a new project using Umbraco 8.6 (The last one), but I've seen that Doc Type Grid Editor isn't 100% compatible whit that version.
What are the compatibility problems?
Are you working to solve this?
Grate package btw, thanks.

It is compatible with 8.6 AFAIK. I have a few solutions running DTGE with 8.6


Support IPv4-compatible + IPv4-mapped

Add support for IPv4-compatible address and IPv4-mapped address
Code cleanup and small speedup

Before merging this needs unit tests and docs.

Sorry for the multiple commits... :s

Squash the commits and fix the flake8 code styling issues (see travis CI for details), otherwise this seems good.

Done. You can squash the commits directly here on github when merging them, bye. 😄


Year filter: typing a year doesn't update the slider

Fixed by switching to @vueform/slider in 97178fc


GM long pitch compensation

Part of PR stack, but I don't know how to submit a PR to commaai/openpilot that's comparing two branches in the opgm repo, so the layers of the PR stack will include the commits from the previous.
Description
Adds longitudinal pitch compensation to be used in cars that use gas/brake control, where the command specifies an amount of acceleration force rather than an amount of acceleration relative to the road.
To allow this to account for longitudinal actuator delay to allow for smoothing of the pitch signal, future model pitch is used to create a smoothed, predictive pitch.
Though not shown here, another benefit of this improvement is that if more than ACCEL_MAX acceleration is required to maintain speed up a steep hill, stock will not be able to maintain speed. With this improvement that is no longer the case.
actuators.accelPitchCompensated is used to determine the gas command, which specifies an acceleration force. The brake command on gm specifies acceleration relative to the ground, so the actuators.accel value is the correct value for friction brakes, even when going downhill.
To support this assertion, see that gas command does not match up with aEgo:

While brake command does match with aEgo

I also verified this extensively (though not with proper documentation) when developing "one pedal mode" in my openpilot fork, which involved artificially sending a constant brake command and observing the car's braking behavior. I found that the same brake command produces far more braking force on a decline, and far less (or none) on an incline.
However, when openpilot requests negative acceleration in order to stop behind a lead when going uphill, it would engage the friction brakes sooner (at the same time it would now, without this improvement), despite the negative gravitational acceleration, and resulting in more braking than in necessary, since it's being assisted by gravity.
Instead, actuators.accelPitchCompensated is only used to determine the braking command when on an incline, where brakes should be engaged later.
On a decline, actuators.accel is used.
What this means is that, when going downhill, openpilot will use more engine/regen braking force in response to the negative road pitch, but not engage friction brakes sooner or harder in response to negative road pitch.
It also means that, when stopping behind a lead on an incline, the positive road pitch will result in less regen/engine braking being used, and instead openpilot will rely on negative gravitational acceleration, engaging friction brakes later, when they become necessary.
This should also be used on other makes that specify acceleration force with gas or brake commands
Verification
The result is a complete elimination of long error due to pitch changes. In the following image the plots on the left are without pitch compensation, and on the right with pitch compensation.

See that as I climb up the stepped hill (pitch changing between 0 and ~12% grade), the pitchFutureLone (right side, second plot from top, orange line) predicts the liveParams pitch by ~0.4s, which is the value set for longitudinalActuatorDelayLowerBound (and upper bound), so it's predicting by the correct amount.
While there are large deviations between target and actual acceleration (fourth plot from top, left side) without pitch compensation, the pitch-induced error is completely removed on the right (error stays within ±0.05m/s^2 vs ±0.25m/s^2).
Also the with pitch compensation speed stays within 0±0.1m/s^2 compared to ±0.4m/s^2 (top plot).
Here's another image showing data where I descend down the same stepped hill. Again, with pitch compensation, the speed and acceleration oscillations due to changing pitch are completely removed.

This PR includes three other PRs to 1) add liveParams pitch, 2) add liveParams future predicted pitch based on long actuator delay, and 3) to add calculation of pitch-compensated acceleration, saved to actuators.accelPitchCompensated.
Route: c11fcb510a549332|2022-08-17--13-58-51--0

Need to record routes on each PR in the stack. Will be ready for review after that

Routes recorded for other three PRs in the stack (not a real stack), so they're ready for review. Need to record a final route for this PR

Generally when proposing a large change, it's best to open a single PR with all your changes so we can see what it would look like. Then if it's a wanted PR and it could be split out into smaller PRs, we'd do that at that time.

Route: c11fcb510a549332|2022-08-18--07-27-30--5

As I mention in the related pull requests. Future pitch is necessary in order to account for long actuator and other delays. Humans don't wait for the speed to drop before apply more gas when climbing a hill. They do it proactively, which avoids the error, avoids overcorrecting for the error, and improves efficiency and passenger comfort.
I've been driving on this logic for close to 1000 miles. It works great, consistently.

I'll reimplement a standalone carcontroller version without using model pitch.


dnsperf.py supply list of openresolvers on comandline instead of file

Wouldn't it be nicer if you could supply a list of openresolvers on comandline than having that dnsperf.list file which had to be placed in the same directory as dnsperf.py
Or maybe to put the content of dnsperf.list into dnsperf.py?

Thank you for the idea. I removed the default dnsperf.list file and now use internal list of DNS servers as default. However you can still define your list of DNS servers as a file using -f switch.


Add ProfitBricks API url to whitelist

Add the ProfitBricks API URL to the default whitelist

@vincent99 Could you please take a look at this PR so we can move ahead with releasing our UI skeleton.
Thanks


Apa remove moderated messages v2

Not sure if this way of doing it is better.
see #998

There is probably an even better way of doing this


Auto-import not working for extra node modules with expo project

VSCode Version:1.43.2
OS Version: 5.4.30-1-MANJARO

Steps to Reproduce:

Clone the branch learn-expo of this project: https://gitlab.com/soullivaneuh/react-native-sandbox/-/tree/learn-expo (it's a fresh expo TS project with some views)
Open App.tsx
Remove the line: import { Icon } from 'react-native-elements'
Try Ctrl+space at the end of the <Icon tag. No correct import proposed.

Please note that auto-import from react-native package works, but none of the others.

Does this issue occur when all extensions are disabled?: Yes

Looks like it's working for interface extends completion:

But not for component usage on templates.

Well, sometimes the completion auto-import works, sometimes not.
I didn't change anything on the settings, that's weird.
Please give me instructions to do so I can help debugging this issue.

Thanks for the example. This looks like a duplicate of #37812 to me


Map info not appearing for Site

DhRs-1396 record isn't appearing with map info in Arches, but is mapped in HRIA. Can you look into why this site's location info might not have transferred into Arches?

@emjohnst - If it was registered relatively recently it's probably because I haven't refreshed the BCRHP map from the BCGW recently.

Yes it was, end of December 2022. Thanks for clarifying - was just confused why the site was in there but not map info.


Blue Skies

Hey the side bars of blue skies currently overlap JEI

Support for BlueSkies tab will be added in the next release.
And I wanna ask a question, are there any other BlueSkies GUIs that will overlap with JEI? I didn't found any in my test, but it can be me missing something

i'll go ingame and check, and while i am checking i'll check all the mods in my pack and see if i find any issues.

blue skies does not have any other overlaps

1.6.0 is released now
https://github.com/user-attachments/assets/6e6c83a4-1912-4814-b91b-dc0108e38aa9


Fix build break in .NET Native for UWP

smcb and etcb expect the thread id as uint32_t.

@janvorli PTLA

LGTM, thanks for fixing it!


Added current committee members to About Us page

I agree with any other alphabetizing recommendations, and request one change.

Done!

This is great, thanks for adding this @clyne. Do we want to add previous leadership members here? It could be a nice way to acknowledge the efforts of Deepak, Heather, Matt, Max, Kevin and others...

Great idea! Can you think of who the "others" are?

This is great, thanks for adding this @clyne. Do we want to add previous leadership members here? It could be a nice way to acknowledge the efforts of Deepak, Heather, Matt, Max, Kevin and others...

Great idea! Can you think of who the "others" are?

Here is everyone I can think of who is not already listed under the current committee membership (others feel free to chime in if I missed anyone):
Anderson Banihirwe (CISL), Deepak Cherian (CGD), Heather Craker (CISL), Max Grover (CGD), Thomas Hauser (CISL), Matt Long (CGD), Kevin Paul (CISL)

This is great, thanks for adding this @clyne. Do we want to add previous leadership members here? It could be a nice way to acknowledge the efforts of Deepak, Heather, Matt, Max, Kevin and others...

Great idea! Can you think of who the "others" are?

Here is everyone I can think of who is not already listed under the current committee membership (others feel free to chime in if I missed anyone): Anderson Banihirwe (CISL), Deepak Cherian (CGD), Heather Craker (CISL), Max Grover (CGD), Thomas Hauser (CISL), Matt Long (CGD), Kevin Paul (CISL)

I've added the above members. Feel free to add others.


Handle UnicodeDecodeError when sending pull requests

Catching this error here to not fail submitting a PR or push a branch in case reading the file being processed fails - fixes #198

🤦 let me add the import


Attempt to fix issue 43 alternative

Expansion up on PR #46, but using fs_err instead where possible and also covering not only delete operations, but all filesystem operations.

Already fixed in #46.


Added Korean translations

Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!

[x] There's a clear use-case for this code change, explained below
[x] Commit message has a short title & references relevant issues
[ ] The build will pass (run yarn test:all and yarn lint)

We appreciate your contribution!

After confirming the modification with the wrong key, we request PR again.
Thank you as always.

🤖 Generated by Copilot at 1f3039d
This pull request adds Korean translations for the email and portal messages used by Ghost. This will help Korean users interact with Ghost sites and enhance the localization of the platform.

Thanks @jshsakura! 🕺🏻


Train on Pascal VOC

Is it possible to train it on dataset VOC

Yes, you will need to register the VOC dataset following: https://detectron2.readthedocs.io/en/latest/tutorials/datasets.html

For the semantic segmentation task, should I include the background category when using the VOC dataset?


refactor!: Use latest SDK for flattened config stem

Signed-off-by: Valina Li<EMAIL_ADDRESS>

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-mqtt-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[ ] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[x] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?)
[x] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[ ] I have opened a PR for the related docs change (if not, why?)

Testing Instructions
v@v-desktop:~/source/repos/device-mqtt-go$ make build
v@v-desktop:~/source/repos/device-mqtt-go$ make test
v@v-desktop:~/source/repos/edgex-compose/compose-builder$ make run no-secty mqtt-broker
v@v-desktop:~/source/repos/device-mqtt-go/cmd$ export EDGEX_SECURITY_SECRET_STORE=false; ./device-mqtt -cp
verify service's config is in Consul at edgex/v3/device-mqtt
New Dependency Instructions (If applicable)

duplicated to https://github.com/edgexfoundry/device-mqtt-go/pull/440...


How can you convert onnx file to keras and change the ordering from CHW to HWC?

Hi,
I am trying to convert the ONNX models from the official insightface repo into keras with onnx2keras lib. However, I got an error when setting the parameter "change_ordering" to True which raise the error "ValueError: Layer weight shape (1, 1, 112) not compatible with provided weight shape (64, 1, 1)" in the PreLu layer.

I‘m not using onnx2keras, which is not easy to control. Mine is converted technically like define a same model architecture like pytorch one -> match layers in order or define same layer name like pytorch model -> convert pytorch weights NCHW to NHWC by permute or transform layer by layer -> load weights and save keras model.
I've tried converting the ONNX models earlier, but they fused the Conv2d and BatchNorm layers, which makes it not able for training, not sure if their latest model still fused.

I‘m not using onnx2keras, which is not easy to control. Mine is converted technically like define a same model architecture like pytorch one -> match layers in order or define same layer name like pytorch model -> convert pytorch weights NCHW to NHWC by permute or transform layer by layer -> load weights and save keras model.
I've tried converting the ONNX models earlier, but they fused the Conv2d and BatchNorm layers, which makes it not able for training, not sure if their latest model still fused.

can you share with us the code and guide for converting from onnx model (r18-r50) of insightface to keras?
Yes they still fuse Conv2d with BatchNorm and raise the error I mentioned above.

Wait, I've just tested onnx2keras, follow this:
# Install onnx2keras from source, with a little modify
$ git clone https://github.com/gmalivenko/onnx2keras.git
$ cd onnx2keras
$ vi onnx2keras/converter.py
- 203             1: 3,
+ 203             1: -1,

$ pip install .

I actually once tried creating a PR about this Fix an axis issue for Concatenate layer #111. but may not work well for all common cases.
# Convert to channel last keras model
import onnx
from onnx2keras import onnx_to_keras

# Load ONNX model
onnx_model_file = 'glint360k_cosface_r50_fp16_0.1.onnx'
onnx_model = onnx.load(onnx_model_file)
k_model = onnx_to_keras(onnx_model, [onnx_model.graph.input[0].name], name_policy="renumerate", change_ordering=True)

save_name = os.path.splitext(onnx_model_file)[0] + "_channel_last.h5"
k_model.save(save_name)
mm = keras.models.load_model(save_name)
print(mm(tf.ones([1, 112, 112, 3])).shape)
# TensorShape([1, 512])

Wait, I've just tested onnx2keras, follow this:
# Install onnx2keras from source, with a little modify
$ git clone https://github.com/gmalivenko/onnx2keras.git
$ cd onnx2keras
$ vi onnx2keras/converter.py
- 203             1: 3,
+ 203             1: -1,

$ pip install .

I actually once tried creating a PR about this Fix an axis issue for Concatenate layer #111. but may not work well for all common cases.
# Convert to channel last keras model
import onnx
from onnx2keras import onnx_to_keras

# Load ONNX model
onnx_model_file = 'glint360k_cosface_r50_fp16_0.1.onnx'
onnx_model = onnx.load(onnx_model_file)
k_model = onnx_to_keras(onnx_model, [onnx_model.graph.input[0].name], name_policy="renumerate", change_ordering=True)

save_name = os.path.splitext(onnx_model_file)[0] + "_channel_last.h5"
k_model.save(save_name)
mm = keras.models.load_model(save_name)
print(mm(tf.ones([1, 112, 112, 3])).shape)
# TensorShape([1, 512])

I worked! thank you so much!


core1 takes over 100us to start executing code using multicore_launch_core1()

Testing the 'multicore_runner_queue' example, I found out that calling multicore_launch_core1(), it seems to take over 100µs for core1 to actually start executing the code in the entry function passed as an argument.
I'm not saying this is a bug or an issue - but I wanted to know if that was "normal", as I could not find this documented. I think this could be interesting to know.

most of this is because you are running from flash and none of that code path is going to be in the cache on first use (you can build using no_flash to confirm).
That said I did notice one function which could be optimized which took it down to about 40us from flash

merged into develop


Reconsider adding type hints

I've read https://github.com/pallets/flask-sqlalchemy/issues/999, and I think it's worth adding. It's currently not possible to automatically hint anything that uses db.Model, which means most interesting Flask applications. SQLAlchemy has started adding typing to the main library now.
From trying to write a stub, https://github.com/pallets/flask-sqlalchemy/blob/818c947/src/flask_sqlalchemy/init.py#L99-L103 is the fiddly bit. I'm not really sure how to fix that in a concise way that a type checker will understand.
Did you have a plan for this? Happy to help out if possible.

See previous linked response, I might do it eventually but don't want to keep an issue open about it.


Setting up SwiftLint on Travis CI

Setting up SwiftLint on Travis CI

Configured Travis to install SwiftLint & lint all files (including playgrounds)

Installed from precompiled pkg file. See: install_swiftlint.sh.

This is the fastest way to install SwiftLint on TravisCI according to https://alexplescan.com/posts/2016/03/03/setting-up-swiftlint-on-travis-ci/

Added basic .swiftlint.yml configuration file we can expand/change as we go
Fixed all linting errors (e.g. removed brackets around if statement conditions)
Added instructions for running SwiftLint when making a contribution.

Example of linting errors on build server:

I've created a separate PR for this, on a separate branch with the merge conflicts resolved. Will merge that one in once Travis confirms it's good to go :) Thanks @chris-pilcher!

Hi!
That is just a quick note to say thank  you, you may find my  whole message  here http://luck.20-years-later.com/e4bov
Best, jp


Tweak bond curves specification

Put the configurable settings up front in a table.
Fix some whitespace errors and other typos.

Should this be directed at spring2024-tokenomics? @xrchz

Apparently this was covered here https://github.com/rocket-pool/RPIPs/pull/240/commits/50bc4ed32e6c74d020a429499cb8da527bca2184 instead


Addition to #601 - removed redundant type casting

I am accepting this PR, but will revert the code changes made on the sync method. It has also affecting the majority of the Integration Tests.


breaking(ModuleInterface): Update the module interface to allow for a range of tenantId appId pairs.

Break the interface.

:tada: This PR is included in version 3.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add golden tests for the compiler

Problem
These tests will allow us to test compiler error messages as they would be to the user
Happy Case
.
Alternatives Considered
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response

Have you considered this good framework for it? https://github.com/oli-obk/ui_test


[spacing-mark-glyphs] suggests u+09CD is a spacing character

(NOTE: Please include the check-id in the issue's title.)
Observed behaviour
WARN The following spacing glyphs may be in the GDEF mark glyph class by mistake:
u09cd (U+09CD)
Expected behaviour
U+09CD Benngali Sign Virama should be classified as a mark for its proper positioning with Ligature by GPOS table blwm - so there should not be any such warning
Resources and steps needed to reproduce
Font: Dakkhinee ( under production- UFO
Uploading Dakkhinee-Regular.ufo.zip…
file attached )
Font Bakery Version 0.12.9
Python (venv) version   Python 3.10.12
OS UBUNTU 22.04 LTS

This is a duplicate of #4824 and a fix was released on FontBakery v0.13.0a1


use postera ID as identifier throughout docking workflow

Manifold downloads now include a vc_id_postera (both in .csv and .sdf): we'll want to use this as the main identifier throughout the docking workflow (or at least keep it as a tag on docking output) as we'll want to use it for downstream methods (FE calcs and subsequent communication with MedChem).

We do this now.


Fix small logic issue with feature_set

Small bug I found while working on multilabel classifications. Multilabel tests will regression-test it.

Ticket number please!

And a test please.


Unable to overwrite request header with application/json content

Issue
Portman doesn't seem to be able to inject application/json content in header
How to test
You have to download the stackblitz https://stackblitz.com/edit/node-rq2nbx?file=README.md repo because Portman doesn't seem to work on stackblitz.
Then, open two terminals.
In the first :
npm ci && npm start
Then, in the second :
npx portman --cliOptionsFile ./options.json --runNewman --newmanRunOptions '{"insecure": true, "abortOnFailure": false}' -b http://localhost:3000
Expected behavior
View in express logs the header x-my-json the value "{\"type\": \"foo\", \"color\": \"white\"}"
{
    "x-my-header": "test2",
    "x-my-json": "{\"type\": \"foo\", \"color\": \"white\"}",
    "user-agent": "PostmanRuntime/7.29.0",
    "accept": "*/*",
    "cache-control": "no-cache",
    "postman-token": "8c7c6e23-990e-4b08-bf4f-cfaa1d5ec530",
    "host": "localhost:3000",
    "accept-encoding": "gzip, deflate, br",
    "connection": "keep-alive"
}

Current behavior
The header x-my-json doesn't have any value.
{
    "x-my-header": "test2",
    "x-my-json": "",
    "user-agent": "PostmanRuntime/7.29.0",
    "accept": "*/*",
    "cache-control": "no-cache",
    "postman-token": "8c7c6e23-990e-4b08-bf4f-cfaa1d5ec530",
    "host": "localhost:3000",
    "accept-encoding": "gzip, deflate, br",
    "connection": "keep-alive"
}

Part of explanation
My guess is that Portman is not able to fulfill an example value when we describe a json content instead of a string schema.
Then, in the portman source code (https://github.com/apideck-libraries/portman/blob/main/src/application/overwrites/overwriteRequestHeaders.ts#L35), we overwrite request header value only if we already have a value in the header.
What should I do ? (using object schema instead of application/json content is not an option)

hi @cguy
That is a good catch.
For the other overwrite methods, we do support the "insert" option.
It seems we didn't align this across the headers.
I'll tag this as a bug and try to pick it up, once we find some time.

Hi @thim81,
Actually, I think I saw the insert flag for request headers. But since my header is defined in my open api spec, it won't be inserted. (maybe you're talking about something else ?).
Is there something I can do?

There is a Portman config property for overwriteRequestHeaders:

insert (Boolean true/false | Default: true) : Insert the additional request header in Postman that are not present in OpenAPI.

Which does not seem to do what it is supposed to do, hence that is why it seems like a bug.
In https://github.com/apideck-libraries/portman/blob/76b44230e836d12102855e03fe25c0d46d1ddbf9/src/application/overwrites/overwriteRequestHeaders.ts#L70 Portman should insert any headers

Oh, in your opinion this is an insert issue, not an overwrite issue?
Maybe I can start a PR and we iterate about the technical solution? What do you think?

I'm not 100% sure, but looking at your config, I think the reason will mostly be related to the header having a JSON value
- in: header
          name: x-my-json
          required: true
          content:
            application/json:
              schema:
                example: "{\"type\": \"foo\", \"color\": \"white\"}"
                type: object
                required:
                  - "color"
                properties:
                  type:
                    type: string
                  color:
                    type: string
                    pattern: "(black|white)"

Yeah, but I am not sure to understand why it can be an issue.
The open API specification allow this use case : https://swagger.io/specification/v3/#parameter-object

For more complex scenarios, the content property can define the media type and schema of the parameter. A parameter MUST contain either a schema property, or a content property, but not both. When example or examples are provided in conjunction with the schema object, the example MUST follow the prescribed serialization strategy for the parameter.

But, where I agree with you is that the open api parser may not be able to parse content attribute in JSON, leading the issue with a header with empty string value "". This behavior explains why portman is not able to overwrite header value.
So, in my opinion there are some options (non exhaustive, could be cumulative):

investigate the open api parser and probably fix it to let it fulfill the header value
fix portman to let the possibility to overwrite a header that contains an empty string value (the if statement in https://github.com/apideck-libraries/portman/blob/main/src/application/overwrites/overwriteRequestHeaders.ts#L35 could be as followed:

Before
if (overwriteItem?.value !== undefined && pmHeader?.value) {
      const orgValue = pmHeader.value
      let newValue = overwriteItem.value

      if (overwriteItem.overwrite === false) {
        newValue = orgValue + newValue
      }
      pmHeader.value = newValue || 'boolean' === typeof newValue ? `${newValue}`.toString() : ''
    }

After
if (overwriteItem?.value !== undefined) {
      const orgValue = pmHeader.value
      let newValue = overwriteItem.value

      if (overwriteItem.overwrite === false && orgValue) {
        newValue = orgValue + newValue
      }
      pmHeader.value = newValue || 'boolean' === typeof newValue ? `${newValue}`.toString() : ''
    }

Hello @thim81, do you know when the next version of portman will be released (in a few days, in a few weeks, in a few months...)?

hi @cguy
I have it on my agenda for this, to bump some dependencies and create a new release with all the changes.

hi @cguy
We just released Portman 1.21.0, which includes your fix.
Thanks again for taking the time to report the issue with all the details and creating the PR that fixed it.

Thank you for your reactivity!


Error in InvalidConversionCodeFixProvider

Reported by Aleksey.N on Visual Studio Gallery page:
Some error? How remake: Add label on form. Add method mousemove for form. And edit code. If code wrong:
label1.Text = MousePosition.X;//(i am beginner)
your extension got error. This is happen only Russian language Visual Studio. When i set English it's not happen. Screenshot http://savepic.org/7596977.png

This issue got out of sight somehow...
I assume that happens because this code fix tries to parse involved type names from the error message generated by corresponding (built-in) analyzer. It assumes that the types are surrounded by single quotes in that message. In Russian localization the message contains double quotes instead, which the code fix isn't able to handle.


Should streets_per_node be a node-level attribute rather than a graph-level attribute?

Should streets_per_node be a node-level attribute (called something like street_count) rather than the graph-level attribute it currently is? I think so. Currently it is accessed via G.graph['streets_per_node'], but this change would entail making it accessible instead via nx.get_node_attributes(G, 'street_count'). Thus, each node would be assigned a street_count attribute with value of how many "undirected streets" are incident to it.

Resolved in #603


moveMouse() Apply values incorrectly

Expected Behavior
robot.moveMouse() apply values correctly.
Current Behavior
robot.moveMouse() add offset to passed values
Steps to Reproduce (for bugs)
Precondition
You should have two displays.
Issue is reproduced when your opened window is on the second display.

Clone or download sample from https://github.com/Sergey-Churilin/robot-sample
Perform all the steps from Readme.
Run the app and move the window to the secondary display
During app running, change position of displays in Display Settings of the OS

In the sample I just apply values from mouse position on click event.
I don't think that it is reproducible only in connection with Electron
Your Environment

RobotJS version: 0.6.0
Node.js version:12.16.1
npm version: 6.13.7
Operating System: Window 10

Hi, i actually run into this issue as well. You can call .updateScreenMetrics() to update the cached system metrics prior moving the mouse. This seems to get cached once here.

Hi @Kyusung4698 , thanks for idea, it solves my problem!


[PROG]Permutation of a String.

Program Description
Write a program to print all permutations of a String.
Additional context
Update documentation ('DOC.md' in 'strings' folder).
Checklist

[x] This issue has not been mentioned in existing issues.

interested in writing the code for printing all permutations of the string, please assign


[RFR] Refresh by extern information and not timers

follow #3
follow also PR of Quarto-symfony :
[RFR] Calling isomorphic when a game is modified #15
There is no more timers for refreshing of games pages
API inform us when to refresh

:+1: Remove the two commits from the other PR (git rebase -i) and I can merge it


Suggestion for translation in Korean

Hello I'm eeeclipse, a big fan of rust in South Korea.
Also I'm working in the field of data something now.
I just started Rust and my tiny little "Hello Rust" project as been closed last few weeks ago.
My suggestion is translation of The Rust and WebAssembly Book .
In Korea, there are only a few Rust users here.
rust-kr is the only Rust user community in Korea.
Students and engineers are interested in learning Rust, but what people can do is only googling "The Rust Programming Language first".
To build a fluent Rust development environment, we need more practice and great resources to share, learn and try.
Hence, when I had reached the end of the book, I decided to translate this awesome book in my mother language.
I want to know any restrictions or guidance for the translation.
Thanks!!

오오 잘 부탁드립니다..! >ㅂ<


add rbac content and a candidate for more versioning information

Signed-off-by: JENNIFER RONDEAU<EMAIL_ADDRESS>
fixes #350
fixes #931
fixes #387
fixes #839

Also cleans up a fewe other small usability/style issues not reported separately

New commit adds draft content for issue #387 (can break content out into PRs/branches per issue, but it's getting cumbersome.)

@Bradamant3 if merging this PR will close out various issues, please update this PR's description so that each issue is listed individually as "fixes #xyz" or "closes #xyz". This has to be done once per issue - you can't write "fixes #abc #def #ghi", unfortunately.

This should also close #839

@Bradamant3 if merging this PR will close out various issues, please update this PR's description so that each issue is listed individually as "fixes #xyz" or "closes #xyz". This has to be done once per issue - you can't write "fixes #abc #def #ghi", unfortunately.

See changes in description -- is this what you mean?

@Bradamant3 perfect, thanks (you'll also notice that GitHub underlines the word "fixes" to indicate it's picking up on it).

latest commit pushed as candidate for merge but also for discussion (get-started.md)

Pushed a variation on your approach, @skriss, with some SOMETHINGSOMTHING placeholders where I'm not sure what to say about why you'd find a particular config or approach the right choice.

With s3, we assume the s3 endpoint is accessible from both inside the cluster and from wherever you're running the ark CLI.
I know we've had a lot of users run into the Minio accessibility issue. How important do we think it is to add this publicUrl support? Could/should we instead make it a requirement that Minio be accessible in the same manner as s3? I know I wrote the pending publicUrl code, but is this an example where we're being too accommodating? Or should we just merge it because it's helpful?

I think it's helpful and solves short-term pain, so I'd opt to move ahead for now.  We could look at more significantly revamping our get-started guide to use something besides an in-cluster Minio, in which case we might be able to avoid the issue altogether, but IMHO we can do that later.

Works for me

Responded to @skriss's latest comments. We can revisit after release, too. Might ultimately be better to put all the "make external access happen with the getting started example" in its own topic/section, but not until after release ;)

No further comments. Thanks!


Cannot Install FSLogix

The error is:
"The Security ID may not be assigned as the owner of this object"
I cannot modify security permissions as well

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: eb001371-1df6-d412-0de5-3c71047a1774
Version Independent ID: aa2c6d81-169d-55d3-f8f3-33af9b006448
Content: Install FSLogix Agent - FSLogix
Content Source: fslogix-docs/install-ht.md
Product: fslogix
GitHub Login: @DougCoombs
Microsoft Alias: docoombs

Unclear as to appropriate documentation change to address this item.  No change made.  Please enter another item with specific suggested docs changes.


Transaction Error

Hi! It seems dropbox.com was banned along with Hola API endpoint. Which country it is? Can you please try to open https://www.dropbox.com in your browser without any VPN?

Yes, I can open https://www.dropbox.com/ in your browser

@vpn28 maybe there is a case of bad internet connection? try to increase timeout with option -timeout 30s. Command will look like this: hola-proxy.windows-amd64.exe -list-countries -timeout 30s. Also you might want to try to use encrypted DNS option: -resolver quic://dns.adguard.com

@Snawoot Thank you. Its success.


An implementation for 0168-multi-line-string-literals.md

A prototype implementation for the proposal 0168 as discussed on the swift evolution thread over the last week. It has been tested inside the Xcode source editor is completely functional as a reference implementation bar any changes that would be need to be made to other parts of the toolchain which seem to be minimal. There is a new test file.
Resolves SR-170.

Compiled toolchain: http://johnholdsworth.com/swift-LOCAL-2017-04-17-a-osx.tar.gz

Hi, @johnno1962, thanks for sending this patch!  Do you think you'll have time to address the review comments?  I'd like to get this into Swift 4, and we're getting close to the deadline for it.

Thanks @xwu  and @kubamracek for the comments which I have endevoured to address with this last commit. This should be compliant with the core teams decision except that it includes a small amount of code to implement a new proposal https://github.com/johnno1962c/swift-evolution/blob/master/proposals/0173-newline-escape-in-strings.md to allow escaping of newlines in all strings. This code is around line 1212 of Lexer.cpp if you want to remove it.
There are limitations to the implementation in that while it will normalise end-of-line to \n for sources that use \n, \r\n, \r as the line separator they can not be mixed withing a literal and have this work.

@johnno1962, could you extract the newline escaping feature into a separate pull request?  Since it's a separate proposal that wasn't accepted yet, we shouldn't block merging this PR on the other feature.

@johnno1962 Thanks for updating the PR and for addressing the comments.  What I'd like to see improved still is the test:  We should have testcases for the error cases, where the compiler is supposed to print an error.  Do you think you can add these tests?

@kubamracek, there is a bit of a long story about adding another test file to check for errors at the moment. I’m finding it breaks the swift build when it goes to run the tests giving the and error about the line being too long. This is because I have quite long home directory path /Users/johnholdsworth/Swift9/swift. I can add a test for you but I don’t want to break the build for others.

let str = """

   ABC
   """
print("<\(str)>")

results
<

ABC>

Shouldn't it be
<
ABC>

I’ve rewritten how the indentation is stripped and newline normalisation is now comprehensive so this should be good to go except I’ve not been able to perform a full test run due to the problem I mention above:
/Users/johnholdsworth/S9/swift/utils/build-script-impl: line 2897: /bin/sh: Argument list too long
*** Failed while running tests for swift (check-swift-all-macosx-x86_64)
I have run the relevant individual tests and they seem to be fine including a new one for the problem @rintaro mentions.

@swift-ci Please test

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 4691cb2e6572f5b60ddd709249422f95a11687e9
Test requested by - @airspeedswift

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 4691cb2e6572f5b60ddd709249422f95a11687e9
Test requested by - @airspeedswift

👍

Updated toolchain: http://johnholdsworth.com/swift-LOCAL-2017-04-24-a-osx.tar.gz

@kubamracek I’ve made most of the changes you requested but I’ll have to push back on Modifiers being changed into a boolean. The advantage of it being a bitflag is that its extensible. There was talk last year of other modifiers for string literal such as regex escaping at some point in the future so this leaves this open in the code. I’ve added your extra tests except multiline strings inside an interpolation which is not addressed in this proposal.

If regex piggybacks on string literals, there's no reason to think that additional flags could not be added later, right? Why try to use one flag for two unrelated features, one of them currently non-existent?

It will be easier to add regex escaping if we keep the modifier as a bitflag rather than progressively complicate the signature and structure of StringSegment::getLiteral etc.

There's a few places in the patch where unsigned Modifiers is used, but we're restricting the possible values to only indicate whether it's a multiline string or not.  In those cases, use bool MultilineString (or IsMultilineString or MultilineLiteralString or something like that).  Specifically, in lexStringLiteral, lexCharacter, formToken and the StringModifiers field of Token in Token.h.  All of these already assume that we're only passing 0 or 1.  These should be bool.
As for the remaining uses of Modifiers, we should use the actual type OptionSet<StringLiteralModifiers>.  But I'd still prefer to get rid of the enum, because it's too vague.

I’m sorry, but I can’t bring myself to move away from the use of “Modifiers" in the code the way I see its future. Modifiers is a convenient way to move about any specialisations of the string all the way from Lexer::lexImpl through Token.h down to Lexer::getEncodedStringSegment where they affect processing in a single consistent type. I can see bit flags may be a bit passe’ but it while it’s my choice I’d like to keep it that way. Feel free to change this any way you like later.

Woah, you'd rather not have multiline strings at all than use a bool?!

Who’s saying that? Seeing as it’s two on one I’ll give it a try.. commit to follow.

Tests seem ok.

@swift-ci please smoke test

@johnno1962 the failure is:
/Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/swift/test/Parse/multiline_errors.swift:55:31: error: incorrect message found
  """)" // expected-error@-2{{mult-iline string literals are not allowed inside an interpolation}}
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                              multi-line string literals are not allowed inside an interpolation

Adjust the error message and it should work.

Erp. Apologies, sorted.

@swift-ci please smoke test

@johnno1962 I'll be doing a squash-and-merge (after CI passes). What do you want the commit message to be?

“Lexer changes for multi-line string implementation”?

Bah, you're too modest. I'll use that as a starting point ;-)

Can it wait until tomorrow? I have a better diagnostic on the way for "invalid end of multi-line string literal” (small change I’ve committed it but it is untested)

@johnno1962 let me know when you're ready for a final test and then merge

Sure, sounds good

If what I’ve just committed builds then we’re good to go - can you run the test?

@swift-ci please smoke test

One more time 🙄

@johnno1962
/Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/swift/lib/Parse/Lexer.cpp:1365:25: error: use of undeclared identifier 'getSourceLoc'; did you mean 'swift::Lexer::getSourceLoc'?
        Diags->diagnose(getSourceLoc(start),
                        ^~~~~~~~~~~~
                        swift::Lexer::getSourceLoc
/Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/swift/include/swift/Parse/Lexer.h:433:20: note: 'swift::Lexer::getSourceLoc' declared here
  static SourceLoc getSourceLoc(const char *Loc) {
                   ^
1 error generated.

BTW, you can get a quicker turn around time by running "ninja swift" in your local swift build directory to just build the compiler (without the standard library).

@swift-ci please smoke test

Thanks for the tip. I’ve been building toolchains. Is there an easy way to build a toolchain without building all architectures?

Nothing supported that I know of. Of course, you can intercept the commands and hack something together for yourself, but that's pretty dirty.
If you're just iterating fast on a .cpp file, "ninja swift" will turn around in about 20 seconds or so. You can then use e.g. ./bin/swift -frontend -parse -verify foo.swift for the error message checking for a test.

Toolchains weren't so bad. it’s just that if the day changes you have to rebuild llvm + clang.  Looks like tests are ok. Merge away 👍

🍾

SR for diagnostics improvements: https://bugs.swift.org/browse/SR-4701
@kubamracek do you have an SR for multi-line literals inside of interpolations?

Big thanks to @milseman, @kubamracek and particularly @xwu for all your help. Final toolchain:
http://johnholdsworth.com/swift-LOCAL-2017-04-26-a-osx.tar.gz

https://bugs.swift.org/browse/SR-4708: Add support for multiline strings inside string interpolations

@kubamracek I’ve just opened PR https://github.com/apple/swift/pull/9049 for multiline inside interpolations

Was the warning about trailing whitespaces removed? 😞
let s = """
	abc
	"""

print(s.characters.count) // prints 66

What would be the workaround if trailing whitespace is desired?

@milseman https://github.com/apple/swift-evolution/pull/695

The example from above is actually this:
let s = """
	abc                                                               \("")
	"""

print(s.characters.count) // prints 66

which has a visible indication that trailing whitespaces are involved. Ideally we still need the trailing backslash.

As already discussed on swift-evolution, the accepted proposal does not include warnings about trailing whitespace. This PR correctly implements the proposal as accepted.

@xwu I bet you've included all the points the core team mentioned in the accepted thread, which cases should be errors and which should be allowed, like for instance the blank line without any indent, but you seem exclusively pick things that you like and silently ignore things that you don't like the same way you did during the discussion thread. I'm not being offensive by any means, but I' highly critical about that.
https://lists.swift.org/pipermail/swift-evolution/Week-of-Mon-20170417/035931.html

That seems like a reasonable thing to warn about. [...]
-Joe

https://lists.swift.org/pipermail/swift-evolution/Week-of-Mon-20170417/035934.html
I don't want to sit around and watch how we'll introduce a half baked multi-line string literal.

In case you insist for a bug issue: https://bugs.swift.org/browse/SR-4874

Adrian, you have a subjective opinion that trailing whitespace is critical that didn’t win over the majority of the thread on this proposal. It seems like you're a bit confused as to the idea behind my follow up proposal about newline escapes (elided newlines) I'd not intended it to have anything to do with helping make explicit trailing whitespace.


Optionally remove all class attributes

Problem
Since everything is inlined, classes are useless and likely won't bring any benefits but occupy some space in the output. Hence I believe we can safely remove them.
Implementation

Add the keep_classes configuration option (everywhere, including CLI and all bindings). The default should be false.
Pass this config option down to the serializer and check it before writing classes to the output buffer here.

Hi there, would it be feasible to just remove the selectors that have been successfully inlined instead? From both the CSS and the HTML class attrs - ideally you'd only want to purge selectors that you know have been inlined and are no longer needed.
This would solve a massive paint point for us in Maizzle too (selector matching and purging is limited by PostHTML capabilities, so we can't inline or remove some more complex selectors) and I think we could switch over from Juice 🙈

Hi @cossssmin !
I think it is feasible + #265 notes a similar idea of keeping some subset of the original CSS.
The implementation does not look too complex - in this block, it is possible to track what selectors are applied and build a new CSS buffer from selectors without matches. I'm not sure if splitting those by the original source (right now it is an optimization to minimize allocations), but it could also be done. And some config option to enable this behavior will be also nice to have. I don't have much capacity to work on this myself right now, but will be happy to review a PR and provide any guidance needed.
P.S. Please, let me know if there is anything else that is missing in css-inline, so you can benefit from it :)


Password settings for user management are not verified

When creating a new user, the user password was not verified. For example, when I set a 3-digit password, the new creation was successful, and then when I log in to the new account, it prompts that the password cannot be less than 4 digits.

This problem has been fixed in version  dgiot-dashboard 4.4.0. Please update the front end to 4.4.0