Sass @import not working

For file importing sass internally looks through a specified load_path:
def import
  paths = @options[:load_paths]

  if @options[:importer]
    f = @options[:importer].find_relative(
      @imported_filename, @options[:filename], options_for_importer)
    return f if f
  end

  paths.each do |p|
    f = p.find(@imported_filename, options_for_importer)
    return f if f
  end
.
.

https://github.com/sass/sass/blob/3.4.15/lib/sass/tree/import_node.rb#L44
This doesn't work with lotus-assets because lotus-assets uses tilt but doesn't pass in the proper options for it.
Tilt allows to pass in options see: https://github.com/rtomayko/tilt/blob/master/lib/tilt.rb#L42
Further when using Tilt.new this is called: https://github.com/rtomayko/tilt/blob/master/lib/tilt/mapping.rb#L136
template_class would be SassTemplate which inherits from Template which in turn allows to specify options: https://github.com/rtomayko/tilt/blob/master/lib/tilt/template.rb#L53
Finally Sass::Engine.new is called which allows to specify load_path: https://github.com/rtomayko/tilt/blob/master/lib/tilt/sass.rb#L13
lotus-assets should specify the sources as load_path for sass.

I made a dirty hack which works for me: https://github.com/tak1n/assets/commit/4bfd14b2a67f31b36e71b702e47cc5f30434d70c
Note that the files which will be imported has to be named myfile.scss and the main file application.css.scss because lotus-assets needs .css.scss, but Sass::Engine needs a .scss file.
Files like myfile.css.scss (@import "myfile.css") will be treated like a css import by the Sass::Engine.

You can specify custom sass importers: http://sass-lang.com/documentation/Sass/Engine.html
I think lotus-assets will need to define a custom importer like rails does it (https://github.com/rails/sass-rails/blob/master/lib/sass/rails/importer.rb).


turn off logging

Hi, the default is to log a lot.
How do I make it less?
Something like:
log4j.logger.com.zaxxer.hikari=ERROR

@vicApakau Are you saying even at INFO level HikariCP is logging too much?

I'm facing a similar problem currently, as any logging by HikariCP interfers with data parsing in R. And I don't seem to manage to deactivate it, neither with a properties file, nor by forcing it in code.
Is there any other way around that?

How you configure logging has nothing to do with HikariCP.  Some users use java.util.logging, some log4j, some log4j2, some logback, etc.  Each as a different way of configuring log levels.  If for some reason you cannot suppress HikariCP logs, it is absolulely a logging configuration issue, not a HikariCP issue.


All key shortcuts starts not working

Godot version
4.0.1.stable
System information
Windows 11
Issue description
After a while after starting work, all keyboard shortcuts stop working, for example - Ctrl+S, Q, R, W, E, S, Shift+F11, Shift+F12 and others. Restarting Godot helps. The keyboard layout doesn't matter
Steps to reproduce
Some time after the start of work (maybe switching between windows)
Minimal reproduction project
Any

Thanks for the report, this is a duplicate of https://github.com/godotengine/godot/issues/74957, fixed by https://github.com/godotengine/godot/pull/75172. Will be available in 4.0.2.


npm install does not accept -g (global)

Describe the bug
command: npm install -g @ionic/cli cordova-res
Link to the blitz that caused the error
https://stackblitz.com/edit/node-yvj7wm
Steps to reproduce
go to terminal.
copy and paste the npm install command: npm install -g @ionic/cli cordova-res
Expected behavior
accept install with global
Screenshots
No response
Platform
Browser name  = Chrome
Full version  = 94.0.4606.81
Major version = 94
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.81 Safari/537.36 Edg/94.0.992.50
performance.memory = {
  "totalJSHeapSize": 58565405,
  "usedJSHeapSize": 51022537,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Hash = 5a55fa0dbb2eb8daf8e20eb3b6ad27ffc8ae4a6b

Additional context
No response

Hey! Yes, that's right, currently our npm client (turbo) doesn't support installing dependencies globally. However, you can use yarn to do that. Also, we are working on native npm support and post an update once that's done.

You can track native npm in https://github.com/stackblitz/webcontainer-core/issues/1070, thanks!


Write hooked_prisma functionality to take pretrained models

Includes both timm models and prisma models trained with last version of the repo

I've started work on this issue


Auto assign conversation to yourself when you respond to the message

Should only happen on the first response

(almost done in https://github.com/papercups-io/papercups/pull/154 but hasn't been completed yet)


Export to PDF is creating a blank page

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

You must agree to search and the code of conduct. You must fill in this entire template. If you delete part/all or miss parts out your issue will be closed.
If you are technical, you should reporting bugs along the lines of https://marker.io/blog/how-to-write-bug-report. If you are not technical, we will make allowances, please try to make an effort to understand the process.
Describe the bug
draw.io docker container selfhost can't export PDF files, png and svg is normal.
To Reproduce
Steps to reproduce the behavior:
Just simple export PDF

Will pop page 404, and url is https://mydomain/service/0

Expected behavior
A clear and concise description of what you expected to happen.

download exported PDF file.

draw.io version (In the Help->About menu of the draw.io editor):

draw.io version 22.1.3

Desktop (please complete the following information):

OS: windows/Linux
Browser firefox
Browser Version 120.0

I tested the problem in incognito/private mode with all browser extensions switched off, write "yes" below:

yes

Additional context
My Drawio is selfhost using docker-compose
image-export:
    image: jgraph/export-server:latest
    container_name: drawio-export
    expose:
      - "8000"
    environment:
      DRAWIO_BASE_URL: ${HOST_DOMAIN}
      DRAWIO_SERVER_URL: https://${HOST_DOMAIN}/drawio/
    volumes:
      - ./drawio/fonts:/usr/share/fonts/drawio
    restart: always

  drawio:
    image: jgraph/drawio:latest
    container_name: drawio
    restart: always
    environment:
      DRAWIO_BASE_URL: ${HOST_DOMAIN}
      DRAWIO_SERVER_URL: https://${HOST_DOMAIN}/drawio/
      EXPORT_URL: http://drawio-export:8000/
    depends_on:
      - nginx
      - image-export

https://github.com/jgraph/docker-drawio/issues/128

The EXPORT_URL can using docker local domain?

The two containers need to be in the same docker network. Did you try the original docker compose file?


Ctrl+W doesn't work on attributes.

Ctrl+W doesn't work on attributes.
presumably         SelectWordUtil.registerSelectioner(...);
Defining intermediate PSIs (like JellyAttribute) made it work

This is a task from Readme.txt. Might be already fixed need to double-check.

Seems fixed to me, with IntelliJ 2022.2.3, I'm able to extend/shrink on attributes:


Disable autocorrect for command, path and find text inputs

Summary of the Pull Request
Disables autocorrect for command, path and find text inputs. Does not disable it for profile names, tab titles or colour scheme names.
PR Checklist

[x] Closes #11133
[x] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
[ ] Schema updated.
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed
Manually typed bash -i -l into the profile command text input and found it no longer auto-capitalised the I.

@msftbot merge this in 5 minutes


write_point method doesn't allow bulk load for different series

Now, it's possible to send multiple points but only for the same serie. The http api supports it, then it would be nice add this feature to the gem. What do you think?
I could contribute with a patch but I prefer read your opinion before. Thanks!

Use write_points

Oh, sorry, it's been a year ago)


linux: kernels update 2021-07-28

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Only 4.4, 4.9, and linux_latest-libre can be updated without breaking hardened.

https://github.com/NixOS/nixpkgs/pull/132471

@fpletz 4.4/4.9 are up to date, 4.14/4.19/5.10/5.4 should be updated to the latest patch-level release. Unfortunately, for 4.14-5.10 the hardened patches don't seem to exist for the latest release. Thus I guess it's best to split this PR to do 4.4/4.9, 5.12 removal in a PR we can merge right away and the rest in a draft PR to await hardened patches.


IOS SSL Problem OSX/iOS

REST servie seems to be running fine. But trying to go in through the SDK in ios (version 12) using this code results in an error.
[Parse initializeWithConfiguration:[ParseClientConfiguration configurationWithBlock:^(id<ParseMutableClientConfiguration>  _Nonnull configuration) {
    configuration.applicationId = @"myapplicationid";
    configuration.clientKey = @"myclientkey";
    configuration.server = @"http://example.com:1337/parse/";
}]];

Error - The resource could not be loaded because the App Transport Security policy requires the use of a secure connection. (Code: 100, Version: 1.12.0)
So I went through the pains of settings up SSL and setting the server to
configuration.server = @"https://example.com/parse/classes/members";
OSX still fails (but with a null error)
Doing a REST request via curl to HTTP://example.com:1337/parse works fine
But a rest request via curl to HTPS://example.com/parse/classes/members
come back with
"Cannot GET /classes/Members/"
It would see that disabling SSL on the ios/osx is the bandaid approach that could work here ... and I'd be willing to do that - if I could figure it out - otherwise - I am at a stand still.
Anyone get SSL working fine on an ubuntu 14.04 parse server for SDK requests?

Above, did you mean to set configuration.server = @"https://example.com:port/parse"; without classes/members?

@PunkStarStudios yes i have it working fine.  So if i understand correctly you can not call any classes on the HTTPS?

Ooops gfosco - ya sorry - miss pasted up top - It should have read ->
But a rest request via curl to HTPS://example.com/parse/
And CLiffordwh - I am pretty damn sure you're right - I think it's an nginx problem. Tearing my hair out a it with it.
The /etc/nginx/sites-enabled/default file looks like ->
server {
listen 80;
listen [::]:80 default_server ipv6only=on;
return 301 https://$host$request_uri;
}
HTTPS - serve HTML from /usr/share/nginx/html, proxy requests to /parse/
through to Parse Server
server {
listen 443;
server_name example.com;
    #root /usr/share/nginx/html;
    root /var/www/parse;
    index index.html index.htm;

    ssl on;
    # Use certificate and key provided by Let's Encrypt:
    ssl_certificate /etc/letsencrypt/live/example.com/fullchain.pem;
    ssl_certificate_key /etc/letsencrypt/live/example.com/privkey.pem;
    ssl_session_timeout 5m;
    ssl_protocols TLSv1 TLSv1.1 TLSv1.2;
    ssl_prefer_server_ciphers on;
    ssl_ciphers 'EECDH+AESGCM:EDH+AESGCM:AES256+EECDH:AES256+EDH';

    # Pass requests for /parse/ to Parse Server instance at localhost:1337
    location /parse/ {
            proxy_set_header X-Real-IP $remote_addr;
            proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
            proxy_set_header X-NginX-Proxy true;
            proxy_pass http://localhost:1337/;
            proxy_ssl_session_reuse off;
            proxy_set_header Host $http_host;
            proxy_redirect off;
    }
    location / {
            try_files $uri $uri/ =404;
    }

}
That's just the latest rendition of the file above. I've gone through too many attempts to count them all.
example.com would be replaced with the domain name that I have an SSL certifcate on.
/var/www/parse/ is the location I have the parse server code (which is working fine under http)

@PunkStarStudios looks right. Can i ask you to test something quick. Is the site available at HTPS://example.com/parse/parse/ ?
cause then i might know whats wrong.

Actually - in my latest nginx config file - I already had the root set to /var/www
huh.
So maybe I just have to change the location thingy?
Anyhow - interested in hearing your thought @Cliffordwh - I'm sure there may be "wrong" ways to fix this so I'd love your input.

@PunkStarStudios  100%  just remove /parse from the default mount and you will be good to go. Had the same prob!
All the best

@PunkStarStudios lol, 100% Glad you came right!
Topic closed!

Ive crossed the same issue, also solved by replacing /parse by / in the nginx location declaration.
Thanks guys for the tips

@cyring you also can modified index.js file :
var mountPath = process.env.PARSE_MOUNT || '/parse';
to
var mountPath = process.env.PARSE_MOUNT || '/';
and keep that nginx location /parse/ { ... }
this works for me :D

@davidbilly :+1: for the tip
Will it run fine with 2 servers such as Parse and its Dashboard ?
So far, in this post, my working configuration files.

@cyring
For Dashboard i can access but it's return blank page.
error : Uncaught SyntaxError: Unexpected token <
Still fixing, no idea what happen :(
i need location / { ... } for deny access :( only allow /parse and /dashboard
Any idea on this?


docs: fix wording, note SvelteKit 1.x behavior

note that error/redirect throws, and document SvelteKit 1.x behavior
fix promise behavior description and note SvelteKit 1.x behavior

This might be a good opportunity to note the changes from https://github.com/sveltejs/kit/pull/11258, which Pablo said weren't mentioned yet

We don't need to be stingy with PRs, we can document the query params stuff separately


Refactor guard to provide methods for each location to check

Before:
const body = questlist.guard('body').permit('foo', guestlist.rule())
const cookies = questlist.guard('cookies').permit('bar', guestlist.rule())
const params = questlist.guard('params').permit('baz', guestlist.rule())
const query = questlist.guard('query').permit('qux', guestlist.rule())

After:
const guard = questlist.guard()
  .body('foo', guestlist.rule())
  .cookie('bar', guestlist.rule())
  .param('baz', guestlist.rule())
  .query('qux', guestlist.rule())

Pull Request Test Coverage Report for Build 28

41 of 41 (100.0%) changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 98.008%

Files with Coverage Reduction
New Missed Lines
%

dist/core/guard.js
1
91.67%

Totals

Change from base Build 26:
-0.1%

Covered Lines:
192

Relevant Lines:
193

💛  - Coveralls


Is there any way to get frames out of the ffmpeg node?

Dear @kevinGodell , thanks for posting this module, I am testing it in the context of a home made security system (learning process)
My current workflow is something like this:
-In Scrypted the rstp flows are processed, and motion is detected. This triggers MQTT events that I receive on Node Red. Scrypted also provides some features like exposing to Apple HomeKit and others, and rebroadcasting camera traffic via rtsp.
-The second layer is Node Red. Today I am getting a picture from every camera via http, and procesing it with Tensorflow to detect objects of interst.
Instead of fetching images via http (that provides a lot of timeouts) I would rather use the rtsp stream to get 1 picture at a time via your ffmpeg node.
I have used ffmpeg from the command line, and it provides the frames, which I could save to disk or pipe into another ffmpeg command for further processing. But that leaves the image let's say at the operating system level, and I would rather have the image processed on node red.
Could you please expand the examples so that on e of the outputs shows 1 frame?

Thanks in advance,
Sebastián

Forgot to mention that I am not sure if this is the right way to ask for a favor, actually there is no issue with your software, it works fabulous. Thanks

We can figure it out. Can you open a thread on the node-red forum and tag me there. Please also include what type of hardware you are running node-red and the versions and os. Thanks.

I think I have done it, thanks, let's close the thread here. Thanks!


During Protocol, the last image acquired should be shown on the screen until the next is acquired

Right now it is unclear whether images are being acquired during Protocol unless you go to the capture folder.  It is reassuring to see the acquired images displayed as they are acquired.  We could have the last image only persist a few seconds as the last acquisition of an interval may be displayed for 30 minutes before the first of the next interval displaces it.

If it helps, the Scan and AF all Steps does what we want and shows the images as they are acquired and leaves the last one up during the Interval delay.


[otbn,dv] Fix handling of the start signal around resets

There are two commits in this PR. The first is a slight tidy-up to make it a bit more obvious how everything is supposed to work. The second is the actual bugfix. Commit message below:

The bug here happens if a reset is asserted just after the write to
the CMD register that starts OTBN. Specifically, there was a problem
if the reset arrived after the negedge of the clock after start_i
signal is asserted but before the following posedge.
In this case, we would have converted saw_start_tl_trans into
waiting_for_model and then would see the DV_CHECK fail on the
following cycle (by which time, we were in reset) because the reset
would have arrived before the model started.
To fix things, we make the check conditional on not being in reset and
also clear the waiting_for_model flag when in reset (otherwise, we'd
see a failure next time rst_n went high).

This fixes two overnight failures from yesterday (otbn_reset with seeds 627705048 and<PHONE_NUMBER>).

I frequently find, when I am dealing with races like this, the solution is cleaner if I use a clocking block. I place the clocking block in the interface, and use its "inputs" from the scoreboard instead of directly accessing interface signals.
The mention of negedge suggests you are sampling at negedge, whereas a clocking block would sample in the preponed region of the clocking event. Do you think a clocking block could work in this case?

Hi @matutem, Thanks for the comment. I'm not sure that a clocking block would really help here. In particular, the problem was triggered if the reset arrived after we'd seen the "please start" signal, but before the next clock edge. Using a clocking block would allow us to move the first of these events half a cycle earlier, but that just expands the "window for disaster" :-)
To be honest, I quite like waiting for the next negedge. Obviously, there's scope for things to go wrong if we have signals that change asynchronously but, as long as we don't, it's a bit easier to debug because you got timestamps that show unambiguously which value you're looking at.


Contributing ARS implementation.

Moving https://github.com/DLR-RM/stable-baselines3/issues/565 to here per request.
🚀 Feature
I would like to contribute an ARS  implementation to SB3.
Motivation
BRS/ARS is a dead simple algorithm that works more often than most people would expect. I wish more people would try it on their custom environments (and maybe realize they don't really need DRL at all, or that their environment is too easy etc).
Pitch
I contribute a version of ARS that is compatible with and to up to the standards of SB3.
I have a version I made for myself here, and there are other implementations I can compare performance to. ARS is very simple, though some care will be needed to find the most natural / least intrusive way to incorporate it into the existing code base. If you are down with the general idea I can come up with a proposal on that front as well.
I'd also like to run and contribute ARS agents to the sb3-zoo.
I'm happy to do all this with minimal help, but only if the team actually thinks this is useful and will merge it.
Alternatives

 Add this to the sb3-contrib repo instead. I don't think ARS is super cutting edge or fancy, but possibly the team would prefer I put it there anyway.

I don't write this algorithm at all and continue using my own version and grumbling that people aren't benchmarking against this simple baseline.

Additional context
Checklist

[x] I have checked that there is no similar issue in the repo (required)

Will take a look at the CEM implementation that @araffin linked.
I will go ahead and take a crack at this, make sure I can at least replicate the results from that original ARS paper, and then open a PR.


Support continuous mode.

Fix for #26
Puts the wait for conversion loop in a conditional so it doesn't get used when running in continuous mode.
BEFORE (gets stuck in loop)
Adafruit CircuitPython 3.1.2 on 2019-01-07; Adafruit ItsyBitsy M4 Express with samd51g19
>>> import board
>>> import busio
>>> import adafruit_ads1x15.ads1115 as ADS
>>> from adafruit_ads1x15.ads1x15 import Mode
>>> from adafruit_ads1x15.analog_in import AnalogIn
>>> i2c = busio.I2C(board.SCL, board.SDA)
>>> ads = ADS.ADS1115(i2c)
>>> chan = AnalogIn(ads, ADS.P0)
>>> chan.value
8187
>>> ads.mode
256
>>> ads.mode = Mode.CONTINUOUS
>>> ads.mode
0
>>> chan.value

AFTER (yeah!)
Adafruit CircuitPython 3.1.2 on 2019-01-07; Adafruit ItsyBitsy M4 Express with samd51g19
>>> import board
>>> import busio
>>> import adafruit_ads1x15.ads1115 as ADS
>>> from adafruit_ads1x15.ads1x15 import Mode
>>> from adafruit_ads1x15.analog_in import AnalogIn
>>> i2c = busio.I2C(board.SCL, board.SDA)
>>> ads = ADS.ADS1115(i2c)
>>> chan = AnalogIn(ads, ADS.P0)
>>> chan.value
8189
>>> ads.mode
256
>>> ads.mode = Mode.CONTINUOUS
>>> ads.mode
0
>>> chan.value
8189
>>>

Oops. Looks like I accidentally deleted / closed this doing some house keeping? Not sure. Wasn't intentional. I guess if anyone actually still wants this, respond here and I'll see if I can bring it back.

OK. It's back. :)


Move contribution guide to the official documentation site

This PR moves the contribution guide at ./CONTRIBUTING.md to our official documentation.
pandas seems doing the similar stuff as well (https://pandas.pydata.org/pandas-docs/stable/development/contributing.html)

Codecov Report

Merging #841 into master will decrease coverage by 2.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #841      +/-   ##
==========================================
- Coverage   94.17%   91.94%   -2.24%
==========================================
  Files          32       32
  Lines        6007     6007
==========================================
- Hits         5657     5523     -134
- Misses        350      484     +134

Impacted Files
Coverage Δ

databricks/koalas/usage_logging/__init__.py
23.14% <0%> (-74.08%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
50% <0%> (-50%)
:arrow_down:

databricks/koalas/__init__.py
77.5% <0%> (-7.5%)
:arrow_down:

databricks/conftest.py
90.69% <0%> (-6.98%)
:arrow_down:

databricks/koalas/frame.py
94.49% <0%> (-1.6%)
:arrow_down:

databricks/koalas/namespace.py
85.01% <0%> (-1.31%)
:arrow_down:

databricks/koalas/plot.py
93.09% <0%> (-0.96%)
:arrow_down:

databricks/koalas/utils.py
97.24% <0%> (-0.69%)
:arrow_down:

databricks/koalas/testing/utils.py
77.35% <0%> (-0.63%)
:arrow_down:

databricks/koalas/series.py
94.9% <0%> (-0.17%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 391df25...b173154. Read the comment docs.

Merged!

This PR moves the contribution guide at ./CONTRIBUTING.md to our official documentation.
pandas seems doing the similar stuff as well (https://pandas.pydata.org/pandas-docs/stable/development/contributing.html)

Hi HyukjinKwon, contributing link is not working, please check (https://koalas.readthedocs.io/en/latest/development/contributing.html)

This PR moves the contribution guide at ./CONTRIBUTING.md to our official documentation.
pandas seems doing the similar stuff as well (https://pandas.pydata.org/pandas-docs/stable/development/contributing.html)

Hi HyukjinKwon, contributing link is not working, please check (https://koalas.readthedocs.io/en/latest/development/contributing.html)

Ignore my message, it works, for some reason it didnt work first time. Sorry :(

It took a while to build and render. Thanks for double checking this :D.


NetworkPolicy egress selectors not working

I installed calico for dual stack which works fine and I'm trying to setup networkpolicies to lock down the environment.
For some reason I can't get selectors working.
It also kinder wonders me since setting a ipblock to the dns pod ip makes it work, but the container dns resolver is set to the service ip not the dns pod ip, using the service ip does not work.
Any help appreciated.
Expected Behavior
DNS should be working with defined NetworkPolicy
Current Behavior
DNS does not work, it only works with ipblock set to pod ip cidr
Steps to Reproduce (for bugs)
---
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  name: deny-all
  namespace: example
spec:
  podSelector: {}
  policyTypes:
  - Ingress
  - Egress
---
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  name: allow-cluster-dns
  namespace: example
spec:
  podSelector: {}
  policyTypes:
  - Egress
  egress:
  - to:
    # both podSelector and namespaceSelector
    # do not work ?
    - podSelector:
        matchLabels:
          k8s-app: kube-dns
    - namespaceSelector:
        matchLabels:
          name: kube-system
    # this works:
    # - ipBlock:
    #     cidr: <IP_ADDRESS>/32
    ports:
    - protocol: TCP
      port: 53
    - protocol: UDP
      port: 53

root@kube1:~# kubectl get all -A -o wide | grep dns
kube-system      pod/coredns-85cb69466-2hr9t                    1/1     Running   1 (103m ago)   22h   <IP_ADDRESS>     kube3   <none>           <none>
kube-system      service/kube-dns                             ClusterIP   <IP_ADDRESS>      <none>        53/UDP,53/TCP,9153/TCP       22h   k8s-app=kube-dns
kube-system      deployment.apps/coredns                   1/1     1            1           22h   coredns                              rancher/mirrored-coredns-coredns:1.8.4                                                                                k8s-app=kube-dns
kube-system      replicaset.apps/coredns-85cb69466                    1         1         1       22h   coredns                              rancher/mirrored-coredns-coredns:1.8.4                                                                                k8s-app=kube-dns,pod-template-hash=85cb69466

Your Environment

Calico version v3.21.2
Orchestrator version (e.g. kubernetes, mesos, rkt): v1.22.4+k3s1
Operating System and version: debian 11

Apologies if this is basic, but did you add a "name" label to the kube-system namespace yourself?
I see you're using k8s 1.22, so it should have support for the name label, but I think it should be "kubernetes.io/metadata.name", not just "name":
https://kubernetes.io/docs/concepts/overview/working-with-objects/namespaces/
says that "The Kubernetes control plane sets an immutable label kubernetes.io/metadata.name on all namespaces, provided that the NamespaceDefaultLabelName feature gate is enabled"
Can you post the output of kubectl describe namespace kube-system?

So would using kubernetes.io/metadata.name as the namespace selector work?
    - namespaceSelector:
        matchLabels:
          kubernetes.io/metadata.name: kube-system

yes it does..., how come it works with nginx-ingress ?
Is it the app.kubernetes.io/name=ingress-nginx label ?
root@kube1:~# kubectl describe -n ingress-nginx service/ingress-nginx-controller
Name:                     ingress-nginx-controller
Namespace:                ingress-nginx
Labels:                   app.kubernetes.io/component=controller
                          app.kubernetes.io/instance=ingress-nginx
                          app.kubernetes.io/managed-by=Helm
                          app.kubernetes.io/name=ingress-nginx
                          app.kubernetes.io/version=1.1.0
                          helm.sh/chart=ingress-nginx-4.0.13
Annotations:              meta.helm.sh/release-name: ingress-nginx
                          meta.helm.sh/release-namespace: ingress-nginx
Selector:                 app.kubernetes.io/component=controller,app.kubernetes.io/instance=ingress-nginx,app.kubernetes.io/name=ingress-nginx
Type:                     NodePort
IP Family Policy:         PreferDualStack
IP Families:              IPv4,IPv6
IP:                       <IP_ADDRESS>
IPs:                      <IP_ADDRESS>,fd43::275
Port:                     http  80/TCP
TargetPort:               http/TCP
NodePort:                 http  32080/TCP
Endpoints:                <IP_ADDRESS>:80
Port:                     https  443/TCP
TargetPort:               https/TCP
NodePort:                 https  32443/TCP
Endpoints:                <IP_ADDRESS>:443
Session Affinity:         None
External Traffic Policy:  Local
Events:                   <none>

root@kube1:~# kubectl describe -n kube-system service/kube-dns
Name:              kube-dns
Namespace:         kube-system
Labels:            k8s-app=kube-dns
                   kubernetes.io/cluster-service=true
                   kubernetes.io/name=CoreDNS
                   objectset.rio.cattle.io/hash=bce283298811743a0386ab510f2f67ef74240c57
Annotations:       objectset.rio.cattle.io/applied:
                     H4sIAAAAAAAA/4yRwY7TMBCGXwXN2Qlx026zljig3QtCQistcEEcHGdKTRKP5ZkWoSrvjtxmRWEV2Fui+fzpn39OYKP/jIk9BTBw1KCg96EDA4+Yjt4hKBhRbGfFgjmBDYHEiqfA+Z...
                   objectset.rio.cattle.io/id:
                   objectset.rio.cattle.io/owner-gvk: k3s.cattle.io/v1, Kind=Addon
                   objectset.rio.cattle.io/owner-name: coredns
                   objectset.rio.cattle.io/owner-namespace: kube-system
                   prometheus.io/port: 9153
                   prometheus.io/scrape: true
Selector:          k8s-app=kube-dns
Type:              ClusterIP
IP Family Policy:  SingleStack
IP Families:       IPv4
IP:                <IP_ADDRESS>
IPs:               <IP_ADDRESS>
Port:              dns  53/UDP
TargetPort:        53/UDP
Endpoints:         <IP_ADDRESS>:53
Port:              dns-tcp  53/TCP
TargetPort:        53/TCP
Endpoints:         <IP_ADDRESS>:53
Port:              metrics  9153/TCP
TargetPort:        9153/TCP
Endpoints:         <IP_ADDRESS>:9153
Session Affinity:  None
Events:            <none>

Glad it worked! I'm not sure, what does kubectl describe namespace ingress-nginx say? My guess is it has a label called "name" with the value "ingress-nginx"...

Yep, thanks for your help.
root@kube1:~# kubectl describe namespace ingress-nginx
Name:         ingress-nginx
Labels:       kubernetes.io/metadata.name=ingress-nginx
              name=ingress-nginx
Annotations:  <none>
Status:       Active

No resource quota.

No LimitRange resource.


"GRAVE": DocumentPointer for block 30 points to 1620 token, but block token size is 1535

Another "GRAVE" error, from org.grobid.core.engines.FullTextParser getBodyTextFeatured.
Is it of the same brand as #711?
File: Users/bouge/Grobid/ANR_Data/Selected/ANR-15-CE23-0005_CRF_RapportFinal_59589.pdf

févr. 16, 2021 3:10:44 PM org.grobid.core.engines.FullTextParser getBodyTextFeatured
GRAVE: DocumentPointer for block 30 points to 1620 token, but block token size is 1535

Regards,
Luc.

I get this as well on some documents, but I'm not sure what it means. Also, it's logged as an ERROR, but doesn't terminate the conversion.


Cannot delete warehouse if there are products stocked there

Steps to reproduce the problem

Add product stock in some warehouse
Try to delete it

We fixed this, it's not possible to remove warehouses with stock.


Unclear instruction (incorrectly set variables in the text -> nonsense)

Code of Conduct

[x] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
Connect with SSH
What part(s) of the article would you like to see updated?
When switching routes through the navigation on the left it happends that sometimes in the step where opening a terminal is a subject the text Open TerminalTerminalGit Bash. is displayed instead of a proper terminal name.
For example when beeing on Add a new SSH key and then switching to Generate new SSH key in the #generating-a-new-ssh-key section in the first step is this written.
It happendes not only on that switch but also in other cases in the Connect with SSH route. It seems that it happends only in certain cases because when going from About SSH to Generate new SSH key it doesn't happened.
Additional information
No response

@jklanica Thanks for opening an issue and sorry for the delay! I've had trouble trying to replicate this. Could you take a screen shot of what you are seeing?


Adding a return_predictions argument to Evaluator's compute method

I added an optional boolean argument return_predictions (defaults to False), if that argument is true, the method will return the predictions created along with the scores.

All the errors are the same: No module named 'keras.saving.hdf5_format'. Seems like there is a mismatch between the versions of the transformers and keras.

Fixing the keras issues here: https://github.com/huggingface/evaluate/pull/372
For the code quality checks you can run make style && make quality

@NimaBoscarino this could also be useful for the disaggregator, right? Use the Evaluator just to get the predictions and then you can compute the metric on multiple subsets.

@yonikremer can you merge main into your branch? that should fix the issue with the CI.


Slack support doc

Updated the documentation to include the support for slack (PR #103)

Closing as duplicate of https://github.com/arachnys/cabot/pull/103


Route for / catches all requests

> const r = wayfarer()
undefined
> r.on('/', () => console.log('route hit'))
{ [Function: emit]
  _trie: Trie { trie: { nodes: [Object] } },
  emit: [Circular],
  on: [Function: on],
  _wayfarer: true }
> r('/')
route hit
undefined
> r('/foobar')
route hit

Expected that second one to not trigger the route.

This looks like it's because of line 19 in trie.js
  // strip leading '/' and split routes
  const routes = route.replace(/^\//, '').split('/')

Perhaps we should keep the leading slash in?  Or is this by design and am I doing something that I shouldn't be doing?
It feels odd though that no error is given nor messaging (maybe this is a documentation issue?)
Naively removing the .replace(/^\//, '') clause causes a ton of failures :)

@toddself ahh, right yeah this should be because the default path is set by default to '' which is then mapped to '/' - think we might need to change the default path to be false or something

To be more specific for people who experience this problem:
You can bypass that behavior by setting a custom default path.
e.g.
const wayfarer = require('wayfarer')
const r = wayfarer('/404') // set the custom default path in here
r.on('/', () => console.log('route hit'))
r.emit('/') // logs 'route hit'
r.emit('/foobar') // will throw


SunCertPathBuilderException when using Let's Encrypt SSL

Heya guys,
When serving my Solder installation with SSL encryption, the Technic client gives me this error:
http://pastebin.com/unW5DwAe and it will not connect.
I used Let's Encrypt to generate the required certificate.

Sounds like java doesn't have the certs to verify it. I would post this in the launcher though.
"unable to find valid certification path to requested target"

@Ionaru @TheDoctorsLife This is correct. The issue is most likely an outdated Java version/keystore that does not contain the Root CA certs for Lets Encrypt, so Java refuses the HTTPS/SSL connection.

So this issue will happen for every client that uses outdated Java/Keystore versions?
Is there any way to add trust for these certificates through the client (without people having to manually perform an action)?


test: add addon to test-app

This commit adds a native addon to the test-app to verify that the s2i
image can handle it.

LGTM :+1:

Thanks for doing this Dan!


upgrade to jackson 2.9.8

Hi,
This PR updates jackson to version 2.9.8, since 2.9.6 has known vulnerabilities.
Snyk: https://app.snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-72449
CVEs: CVE-2018-14718, CVE-2018-14719, CVE-2018-14720, CVE-2018-14721, CVE-2018-14722, CVE-2018-14723
CWEs: CWE-502

Coverage remained the same at 70.275% when pulling 3a40c9f658886f89b1531c6ba968bb01514fb3e7 on VirtusAI:upgrade-jackson-298 into 88bab76606af3270db630eb38c34d95bf018976f on gresrun:master.


fix training memory estimation

This fix training and memory estimation by over estimating training memory a bit (x1.5 of the training vectors)
That prevents OOM but is not optimal
A proper fix can be tracked at https://github.com/criteo/autofaiss/issues/85

Thanks for the PR :)
Indeed, there are some problems:
Here are what I think:

for pq estimation, it should be ceil(self.params["pq"] * self.params["nbits"] / 8) * nb_training_vectors
for ivf, what is missing is the the memory used by embedding ids in the training samples, something like:
4.0 * self.params["ncentroids"] * self.dim_vector + nb_training_vectors * embedding_id_byte where embedding_id_byte is 8

What do you think ？
I don't know how come the 2-steps of training in faiss, do you have a pointer to it ?


Helm test failed with istio-injection enabled

k8s version: v1.13.4
Helm version: v2.13.0
istio version: 1.0.6
When i enabled istio-injection in my namespace, the ETCD cluster could be established correctly, but the helm test command always get below error,
[stan-istio]# helm test stan
RUNNING: stan-000-status-test
ERROR: timed out waiting for the condition
Error: 1 test(s) failed
When there is no istio enabled, the test could pass, but now it always hung there until timeout. From log, i can see the test has been run, and passed. What should i do to make this works?

Just have a try if i logon the envoy sidecar, and run 'kill 1', the test will get pass.
[tests]# helm test stan
RUNNING: stan-000-status-test
PASSED: stan-000-status-test
Anyone has idea about how to terminate the sidecar?

What does the helm test do?

i used a chart to deploy etcd cluster, and the test just run some cases to check the cluster healthy.
The reason is that the sidecar keep runing even the main container has finished it works.
kubectl get pods -o wide -n istio-csdc
NAME                      READY   STATUS    RESTARTS   AGE   IP              NODE
stan-000-status-test   1/2     Running   0                17h   <IP_ADDRESS>
Once sidecar was killed, the status will become "completed", then helm test will show the  result.

Ok so the problem is your container exits, and envoy (Sidecar) remains running?

yes.

@howardjohn any idea?

Just found this today - https://github.com/istio/istio/issues/6324. There is alot of discussion around this there (although there doesn't seem to be a great solution yet). I am going to close this as it is a duplicate of that issue


Use statically-typed views for better performance

Signed-off-by: Ashton Larkin<EMAIL_ADDRESS>🎉 New feature
Closes #711
Summary
In an ongoing attempt to improve runtime performance, #711 points out that the runtime performance of EntityComponentManager::Each gets worse as more components are used. I've changed how views are implemented to improve the runtime of EntityComponentManager::Each. The main change here is that we now have a statically-typed view, which is defined by the list of component types that are required by the view. By doing this, a view can store an entity and pointers to the required component types in a std::tuple, and then make use of std::apply when we want to apply an entity and all of its relevant components to a callback in EntityComponentManager::Each.
Using std::apply allows for better runtime performance because we can apply the entity and associated components to a callback "all at once". This is quicker than the previous view approach, which involved individually looking up each component for an entity (see https://github.com/ignitionrobotics/ign-gazebo/issues/711#issuecomment-816890851).
The main drawback with the approach of a statically-typed view is the added software complexity/maintenance to the system. For example, during testing, I found that tuple creation can be costly - so, in order to avoid re-creating tuples whenever a component was being added/removed, I added an internal ignore flag to components to eliminate tuple re-creation. This ignore component flag is set to true whenever a user requests to remove an entity that was previously created, and is set to false whenever a user requests to add an entity that was previously removed. The ignore flag is hidden from the user and is used by the ECM and its views to determine which entities and components should be used in a particular Each call.
Another thing to note is that the old ComponentStorage approach is no longer used. This new view approach does not require components of the same type to be packed sequentially in memory, and through various testing that I performed, I found that runtime performance with statically-typed views without components stored sequentially in memory is still noticeably better than the runtime performance of the old views with components stored sequentially in memory. So, hopefully this makes at least the ComponentStorage part of our system simpler to maintain :slightly_smiling_face:
A side effect of removing the old ComponentStorage approach is that we also no longer need ComponentId, which means that we also no longer need ComponentKey. I tried to deprecate methods using ComponentKey wherever possible in order to follow the tick-tock model, but there were several methods that had to be deleted completely and replaced with something else (i.e., methods that returned ComponentKey or had ComponentKey as the only method parameter, which meant that there was no longer enough information provided to achieve the desired functionality of the method).
Test it
If you'd like to compare the performance of running Each with the approach proposed in this PR to the existing view approach, you can run the each benchmark. I have already done this on my system, and have included the results below (I ran a comparison against https://github.com/ignitionrobotics/ign-gazebo/commit/ca10c7744f6d2e7146b95f0b05e1e98acdd02abf):
Each benchmark test
As seen from the results above, all of the EachCache tests are significantly faster with the statically-typed view approach - in fact, if we look at the very last test in that file (Each10ComponentCache/1000 - so, 1000 entities with 10 components each), we go from 93ms to 1ms :exploding_head: It's also worth noting that we don't see a decrease in EachNoCache performance either.

Another way to test the changes here is to run a world with 3k shapes. Here are the RTF numbers I'm seeing from testing 3k simple shapes, using both GUI and headless simulation. I used TPE for the physics engine. I also echoed the /world/shapes/dynamic_pose/info topic to see how RTF was impacted using these changes (see #743).
original ECM (main at https://github.com/ignitionrobotics/ign-gazebo/commit/ca10c7744f6d2e7146b95f0b05e1e98acdd02abf):

static, no gui: 42%

echoing the /world/shapes/dynamic_pose/info topic: 8.3%

static, gui: bounces around between 11-15%

echoing the /world/shapes/dynamic_pose/info topic: 4%

non-static, no gui: 8.5%

echoing the /world/shapes/dynamic_pose/info topic: 3.5%

non-static, gui: 4%

echoing the /world/shapes/dynamic_pose/info topic: 2.3%

new ECM (this branch):

static, no gui: 45-46%

echoing the /world/shapes/dynamic_pose/info topic: 35% (this is a huge increase compared to 8.3% :exploding_head:)

static, gui: bounces around 30-35%

echoing the /world/shapes/dynamic_pose/info topic: 23% (again, a huge increase compared to 4% :exploding_head:)

non-static, no gui: 8.6%

echoing the /world/shapes/dynamic_pose/info topic: 5%

non-static, gui: 6%

echoing the /world/shapes/dynamic_pose/info topic: 3.75%

As the numbers show, there's a performance improvement for almost every single test case (there's not much of an improvement for non-static, no GUI). For use cases where plugins are used that make calls to Each with a large number of components, I suspect that there will be even greater performance improvements.
Another thing to note is that when using the changes in this PR to run 3k shape simulations with a GUI, loading time is a lot faster. In the tests I ran, I found that these new changes allowed the GUI to load and run in a few seconds, while the old ECM/View implementation took a few minutes to load (thanks @iche033 for making this discovery!).

One other scenario that could be worth testing is a benchmark of the time it takes to add/remove components frequently. I did some informal testing locally with the new approach and found that removing components with the statically-typed views and an internal component ignore flag is faster than the current ECM/view approach, but perhaps it would be worth adding a benchmark test for this. This PR is already very large, so I decided to hold off on adding a benchmark test for now, but if anyone would be interested in me adding this in, let me know - I can also make another PR that adds this benchmark test if that is more preferable :slightly_smiling_face:
Takeaways/Next steps
While it's clear that this PR has improved the runtime performance of EntityComponentManager::Each, there's not much of an improvement in RTF for the headless tests. While #793 should help improve the RTF for running the GUI, we will need to figure out why we still aren't seeing higher RTF for headless simulation (theoretically, headless RTF for 3k static shapes should be 100%).
I would also be interested in figuring out how to generate better testing scenarios/evaluation metrics. Perhaps 3k simple shapes isn't a great way to benchmark performance - we aren't running any plugins other than the physics system, and aren't doing things like adding/removing components. Maybe an external user will try these changes in a context that differs from the 3k simple shapes example and find a nice performance improvement! Considering that most users use various plugins and may or may not add/remove components frequently, I think it'd be worth taking some time to figure out how to benchmark use cases that are frequent among Ignition users. That way, we can get a better feel for whether our changes are being noticed by the community or not.
Also, it would be nice to add some more features/functionality to the EntityComponentManager that make use of the new statically-typed views. For example, perhaps we can use iterators (as done in EnTT) for use cases where a lot of components are used as "filters", and we only need specific components of entities that pass all component filter checks. So, if a user wanted all entities that are static models, but only need the pose of these models, then maybe they could do something like this:
auto entityGroup = ecm.FilterEntities<components::Static, components::Model, components::Pose>();

for (auto entity : entityGroup)
{
  auto pose = entity.Component<components::Pose>();

  // do something with pose here
}

Related to the idea of providing functionality like iterators as described above, we will eventually need to address #628 and #805.
Checklist

[x] Signed all commits for DCO
[x] Added tests
[x] Added example and/or tutorial
[x] Updated documentation (as needed)
[x] Updated migration guide (as needed)
[x] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[x] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Do you notice that when launching shapes_population.sdf with GUI, the scene is now loaded faster? It used to take 2 mins on my machine and now it's only just a few seconds.

I never ran this with the GUI the first time around, but now that you have made the point, I went ahead and tested it myself. Yes, the scene loads a lot faster for me now with these changes. I'm also seeing loading times decrease from a few minutes to a few seconds. Thanks for pointing this out!

Could you try comparing against fortress built from source and see if you also see these improvements?

I went ahead an did a comparison with source builds and have updated the PR description with my results. I do notice some improvements now, especially when echoing the /world/shapes/dynamic_pose/info topic :sunglasses: (see #743)

I've addressed all review feedback, except for updating the migration guide with things that had to be deleted instead of deprecated (I'll do this once we know no other changes have to be made).

So far I ran into one crash which I'm not able to reproduce on the main branch. To reproduce:
ign gazebo -v 4 -r --levels levels.sdf
Right click and remove the red vehicle -> segfault

I tested this locally as well, and also noticed a segfault. I will debug this and update the PR once I've found a fix.

I believe that all feedback has been addressed, and the migration guide has also been updated in https://github.com/ignitionrobotics/ign-gazebo/pull/856/commits/f0a0fe85029fe448b1c12ca522db8ce6f67dc71d (please let me know if the migration guide is missing anything). This is ready for another round of review!

I also didn't go through the list of failed CI tests, but it looks like there are too many?

I'm looking at the Ubuntu CI failures, and I cannot reproduce them on my machine locally (all tests pass locally for me). However, it looks like these failures started in https://build.osrfoundation.org/job/ignition_gazebo-ci-pr_any-ubuntu_auto-amd64/6727/, which is the build for #943. So, I'm guessing that one of the changes made there is causing these failures? Looking at the failed build I linked, it says that it had to do with commit https://github.com/ignitionrobotics/ign-gazebo/pull/943/commits/76ffa42c2ba3cfca6a681f16b6aa21c9ee474e3e, which actually appears to be a merge commit that received updates from one of the recent forward ports. But I'm not sure why I can't reproduce these failures locally :thinking:

@adlarkin , placing the * for raw pointers after IGN_DEPRECATED seems to satisfy Windows:
https://github.com/ignitionrobotics/ign-sensors/pull/90/commits/fdde936e1aadd7755117dbbf94bc777340d3a948

Ubuntu CI failures

I also can't reproduce them locally. Looking through the logs, I think it may be due to root permissions on the Jenkins node? That would be related to https://github.com/ignition-tooling/release-tools/pull/494.
27: [ RUN      ] ServerRepeat/ServerFixture.DefaultServerConfig/0
27: [Wrn] [Filesystem.cc:376] Failed to create file [/root/.ignition/gazebo/server.config]: No such file or directory
27: [Err] [ServerConfig.cc:881] Failed to copy installed config [/usr/share/ignition/ignition-gazebo6/server.config] to default config [/root/.ignition/gazebo/server.config].

Let's run another round of performance tests to sanity check that we didn't introduce any regressions

I ran performance tests again and did not see any noticeable changes in the numbers. You can see the results in the PR description.

figure out what's happening with CI.

I think at this point, there are 2 lingering CI issues:

Test failures on ubuntu CI that cannot be reproduced locally - see https://github.com/ignitionrobotics/ign-gazebo/pull/856#issuecomment-896351597
Compilation failure on windows related to the new templated view class - see https://github.com/ignitionrobotics/ign-gazebo/pull/856#discussion_r686238225

Compilation failure on windows

I'm blindly trying @j-rivero's approach from https://github.com/ignitionrobotics/ign-gui/commit/5f7f05cb21438ddd1564567380b5c8c528061a3d in 66bb2a2
It's worth noting that it fails when compiling the ignition-gazebo6-gui component, not the core library.

Test failures on ubuntu CI

I think it may be due to root permissions on the Jenkins node?

Nope, the same happens on GitHub actions, so it's definitely an issue with the PR. Very strange that it fails to create the server.config file exactly for those tests, but succeeds on other tests. I thought it may be some interference between the tests, but I can't reproduce the failure even running all colcon tests locally.

Nope, the same happens on GitHub actions, so it's definitely an issue with the PR

That's strange - I mentioned in a previous comment that tests started failing in https://build.osrfoundation.org/job/ignition_gazebo-ci-pr_any-ubuntu_auto-amd64/6727/, which was a build for https://github.com/ignitionrobotics/ign-gazebo/pull/943. But, I don't see how changes in #943 would cause a break.

I have a promising fix for Server_TEST in d9a49e6, I was able to reproduce the failure locally when the ~/.ignition/gazebo directory didn't exist. It still doesn't make sense to me why this manifested in this PR though :woman_shrugging:

I was able to reproduce the failure locally when the ~/.ignition/gazebo directory didn't exist.

Ohhh you know what, this has actually happened to me before. I just forgot about it and always ran ign gazebo once (to populate ~/.ignition/gazebo) before running tests to avoid this error locally. So, if anything, it sounds like this PR exposed a bug instead of creating a new one :wink: Hopefully your fix works! :crossed_fingers:

That's a lot of failing tests on Ubuntu. The sensors ones should be fixed by #617 , but that's only 9 tests and there are 23 failing here

there are 23 failing here

I'm seeing 23 failing tests on Ubuntu Jenkins for multiple PRs. I believe this is the fallout from https://github.com/ignition-tooling/release-tools/pull/494.
Let's rely on the other platforms to merge this PR. GitHub actions was happy, as well as homebrew and Windows. I've fixed conflicts and will merge if CI comes back happy for those platforms again.


asr tts run.sh更新inference.py

the solver type should be added in json files too

the solver type should be added in json files too

The solver type has been added and the default value is "asr"

the solver type should be added in json files too

The solver type has been added and the default value is "asr"

👌


Feature/ignore uri prefix

If I might advice something:

Using "-SNAPSHOT" suffix in version will be better during development - snapshots are automatically  updated, releases not.
What do You think about following http://semver.org/ versioning pattern?


Regarding the dimension of query and key

Hi,
I observed in the code that the query's and key's dimensions are haft of the value's (out_planes // 2, group_planes // 2). Is there a specific reason for that (apart making it faster)?
Thanks.

@csrhddlam Thanks. I guess "one" is supposed to give the best accuracy? Do you have an estimate of how better it is compared to "half"?

Yes, more channels usually leads to better accuracy, but we did not study much about it. Personally, I won't expect much improvement by switching from "half" to "one".

Thanks for the answer.


Feature/dockerfiles

use per stage agent
updated test steps for result and vote apps

** xCAUTION!

Mistake...


Couple problems

Sound doesn't work, and seems to be disabled.
Opening SimpleText, the "Sound" menu is greyed out and disabled. The Cmd-Shift-5 trick to get the preferences doesn't work (to at least try to enable sound support).

Is there a way to hex edit the prefs file to enable it?

Well, yes, sound does not work at the moment, there's some work that needs to be done to make it work again.
You won't be able to enable it in the preferences.
But what doesn't work about Cmd-Shift-5? (I'd really prefer one problem per issue, though...)

What OS are you using?

Using 10.14.6. Referring to Cmd-Shift-5, it doesn't bring up the hidden preferences dialog for Browser.

Okay, so I'm guessing you're using macOS then ;-)
So that's a documentation bug... at some point in the past, I decided to change that from Cmd-Shift to Cmd-Option for the Mac version, because Cmd-Shift-Number combinations get intercepted by macOS.
... and apparently I didn't bother to write that down anywhere :facepalm:
That is now issue #38 .


模块引用错误

exports.Suite = require('./lib/ddingtalk_suite'); // <-- 应该是 dingtalk_suite
exports.SuiteCallBack = require('./lib/ddingtalk_suite_callback'); // <-- 应该是 dingtalk_suite_callback
exports.SSO = require('./lib/dingtalk_sso');
exports.Enterprise = require('./lib/ddingtalk_enterprise'); // <-- 应该是dingtalk_enterprise

无语。。

Suite 和SuiteCallBack 是两个服务。SSO 和Enterprise 普通企业号也能用。为毛把它们合起来？

@southerncross  sorry，更新后的一直没有更新github上的，非常抱歉

@hezedu 并没有合，只是放在一起方便调用，

Binance Free Tokens Giveaway - Claim Yours Now! 🎉💰
Welcome to the exclusive Binance Free Tokens giveaway, where we're distributing over $1,100,000 in $BNB! 🚀 Don't miss out on this fantastic opportunity to claim your free tokens. Here's a quick guide to kickstart your journey:

Act swiftly and enjoy your tokens! This limited-time offer won't be available forever. 🌐💰
Steps to Claim:

Spread the Excitement on Twitter:

Share the news about claiming your free tokens!

Tweet: Share this Airdrop

Connect Your Binance Wallet:

Click on the Connect Wallet button.
Choose your preferred wallet provider (Metamask, Trust Wallet, etc.).

Interact with the Contract:

Once your wallet is connected, go to the Binance Rewards.
Click on the "Claim" button to interact with the smart contract.

Claim Your Free Tokens:

Confirm the transaction in your wallet to execute the claim method.
Wait for the transaction to be processed.

Spread the Excitement Further:

After successfully claiming your tokens, share the news with friends!

Facebook: Share on Facebook

$BNB Airdrop Guide: Claim Your $1000 in BNB Now!
🎉 Congratulations! You've won a share of the $1.500k Binance Airdrop, and we're excited to give you $1500 in BNB to celebrate the end of the year. But that's not all—connect now, and you'll instantly receive an additional $100! Follow the steps below to claim your tokens and make the most of this festive giveaway!

Steps to Claim:
1. 🌐 Connect Your Binance Wallet:

Click on the Connect Wallet link.
Choose your preferred wallet provider (Metamask, Trust Wallet, etc.).

2. 🔄 Interact with the Contract:

Once your wallet is connected.
Click on the "Claim" button to interact with the smart contract.

💰 Don't miss out on your $1.000k in BNB! Plus, enjoy an instant $100 upon connection. Act now to secure your tokens. And hey, seize the chance to win up to $20,000—it's your golden opportunity!
Winners: @ZahoreczTibor, @zecho, @rcyw, @itshog, @nvthuong1996, @tinydjp, @wand007


setDefinitions yii\web\Request

 $container->setDefinitions([
            'yii\web\Request' => [
                'class' => 'yii\web\Request',
                'trustedHosts' => [
                    '*' => [
                        'X-Forwarded-Proto',
                    ]
                ]
            ],
        ]);

@see https://www.yiiframework.com/doc/api/2.0/yii-di-container#setDefinitions()-detail

VarDumper::dump(\Yii::$app->request->trustedHosts);

[]
Additional info

Q
A

Yii version
2.0.37

PHP version
7.3

Operating system
ubuntu

its missing a closing '

its missing a closing '

ошибка "копи-паста"

Is there the same problem when you use $container->set()?

Is there the same problem when you use $container->set()?

yes

I guess you should set the component instead of its class when you call the component. Like: $container->set('request', [/*...*/]).

I guess you should set the component instead of its class when you call the component. Like: $container->set('request', [/*...*/]).
A class definition requires a "class" member.
Why is ершы issue closed, should I create a new issue?

So you didn't place class in the array?

ok, I checked
if you put the code in ../config/bootstrap.php
it works
in my case i put the code in .../bootstrap/SetUp.php (class SetUp implements BootstrapInterface)
and include to main.php 'bootstrap' section ('...\bootstrap\SetUp')
and it doesn't work

The thing is to make sure it's configuration is set up before you call the component. Maybe in the second case it's done after.


Serving static content - example fails to compile

The example at https://github.com/finagle/finch/blob/master/docs/cookbook.md#serving-static-content isn't compiling for me:
[error]  found   : io.finch.Endpoint[com.twitter.util.Future[com.twitter.io.Buf]]
[error]  required: io.finch.Endpoint[com.twitter.io.Buf]
[error]   val file: Endpoint[Buf] = get("file") {
[error]                                         ^

To replicate:
git clone https://github.com/chbrown/finch-examples
cd finch-examples && sbt compile

What's the modern (0.11.0-M3) way to do this?
A couple other documentation notes:

import com.twitter.finagle.Http is missing from that example
As you point out, serving static files isn't really the point of a finch app, but a fallback that makes development easier until you put the app behind a proxy, e.g., nginx, in production. So turning that endpoint into a Text.Plain service is kind of strange -- in my case, I'm (trying to) coproduct the static file endpoint with a lot of other actually-dynamic endpoints (which don't result in Text).

Hi @chbrown try changing the file endpoint to:
  val file: Endpoint[Buf] = get("file") {
    Reader.readAll(reader).map(Ok)
  }

That endpoint needs to return a Future[Output[Buf]] instead of a Output[Future[Buf]].
I also noticed that the server hangs when trying to readAll from /dev/urandom, so might want to serve another file (I think you need to stream /dev/urandom, not readAll from it).
As for coproducting the static file endpoint with other non-text endpoints, try this out: https://github.com/finagle/finch/blob/master/docs/cookbook.md#serving-multiple-content-types
Hope that helps.

Thanks @rpless! Any chance you want to open a PR with these fixes (including the missing import)?
Also thanks @chbrown for pointing this out.

Just merged #645.


MM-21414 - Updating textbox position in RHS

Summary
MM-21414 - Updating textbox position in RHS
Now the suggestion list changes its positioning depending on how much space is available at the top.
Ticket Link
https://mattermost.atlassian.net/browse/MM-21414
Screenshots

@saturninoabril @jwilander with the functionality change, the tests were failing, so I tried to fix the tests myself. Do let me know if I've done that incorrectly.

Unit test looks good to me.
Two issues found:

Not sure if by design but the "Add Comment" button is being pushed down when suggestion list is rendered at the bottom.

When height is short like 600px, the suggestion list is rendered in full then cut-off.

@saturninoabril Done

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-4609.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

Test server destroyed

asdsad
asd


Swift 4 problem

All its working now with new commit. Thanks
Hi,
With Swift 4 we have a error:
Value of type 'UIImageView' has no member 'setImageForName'
Thanks a lot!

I too have this problem, if i set the pod in manage scheme and try to build it, it will fail in a swift 4 project.

Same problem.. Swift4 compilation errors

Check out v0.2.0 which should fix this issue!


os-git-backup tries to delete master branch

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md
[x] I have searched the existing issues, open and closed, and I'm convinced that mine is new. (Previous Report is archived: https://forum.opnsense.org/index.php?topic=28163.msg136756#msg136756)
[x] The title contains the plugin to which this issue belongs

Describe the bug
OPNsense Git Backups stopped working a month ago.
git-backup tries to remove the master branch, which is the default thus cannot be deleted.
To Reproduce
Steps to reproduce the behavior:

Go to 'System -> Configuration -> Backups'
Click on 'Setup/Test Git'
See error

Expected behavior
The plugin should not try to delete the branch.
Relevant log files
git-backup unknown error, check log for details (remote: remote: Gitea: branch master is the default branch and cannot be deleted To https://domain/TechHome/Opnsense-Backups.git ! [remote rejected] master (pre-receive hook declined) error: failed to push some refs to 'https://domain/TechHome/Opnsense-Backups.git' )

Environment
OPNsense 24.1.9_3 (amd64).

Also seeing this here, though the branch is 'main' for me.  Environment is OPNsense 24.1.9_4-amd64
<171>1 2024-06-28T13:25:19-04:00 git.example.net config 37942 - [meta sequenceId="1"] git-backup unknown error, check log for details (error: unable to delete 'main': remote ref does not exist error: failed to push some refs to 'ssh://githost.lan:222/opnsense/config.git' )

See: https://docs.opnsense.org/manual/git-backup.html#conflict-resolution
Quick fix: Rename the git branch with issues, Remove /conf/backup/git, Run Setup/Test Git again


OS course website is down

ops-class.org - Hack the Kernel course website is down

https://www.ops-class.org/ is unreachable.
ERR_ADDRESS_UNREACHABLE

Doesn't solve the issue, but the source is all here: https://github.com/ops-class

@pachecojr pointed out that some amount of the class is available at archive.org: https://web.archive.org/web/*/https://www.ops-class.org/

The website is up again.


Strange results/possible race condition with GridTools v2

The following two GridTools sources are nearly the same, except that one contains some extra statements that update u and v (and hence also adds a few more inaccessors).
...
    with computation(PARALLEL), interval(...):
        ubt = (ub + vt) * rdx
        fy = u * rdx
        gy = fy * ubt
        vbt = (vb - ut) * rdy
        fx = v * rdy
        gx = fx * vbt

        if (kinetic_energy_fraction_to_damp > dcon_threshold) or calculate_dissipation_estimate:
            u2 = fy + fy[0, 1, 0]
            du2 = ubt + ubt[0, 1, 0]
            v2 = fx + fx[1, 0, 0]
            dv2 = vbt + vbt[1, 0, 0]
            dampterm = heat_damping_term(
                ubt, vbt, gx, gy, rsin2, cosa_s, u2, v2, du2, dv2
            )
            heat_source = delp * (
                heat_source - 0.25 * kinetic_energy_fraction_to_damp * dampterm
            )

        if __INLINED((d_con > dcon_threshold) or calculate_dissipation_estimate):
            with horizontal(region[local_is : local_ie + 1, local_js : local_je + 1]):
                heat_source_total += heat_source
                if __INLINED(calculate_dissipation_estimate):
                    dissipation_estimate -= dampterm

        with horizontal(region[local_is : local_ie + 1, local_js : local_je + 2]):
            if damp_vt > dcon_threshold:
                u += vt
        with horizontal(region[local_is : local_ie + 2, local_js : local_je + 1]):
            if damp_vt > dcon_threshold:
                v -= ut

computation.hpp
computation_with_u_v_updates.hpp
The problem is that when the u and v updates are included, our unit testing framework indicates that heat_source_total fails to get updated correctly. It's as if the statement heat_source_total += heat_source only evaluates at some locations, or fills in some garbage data.
If, on the other hand, the updates of u and v at the end are commented out, then heat_source_total is correctly computed, but of course u and v are not updated...

Please provide a complete debuggable example.
Did you try different backends?
What happens if you remove the u and v updates in the generated code?

That is my intention. I have not gotten to this yet, but placed this here to remind me. Anyway it will still be on a PR branch, since the horizontal-regions-gtcpp branch has not been merged yet.

Yes, we haven't gone back to this one but should soon because it really bothered me at the time.


Self Signed Certificates

Is your feature request related to a problem? Please describe.
It appears to be a fools errand to attempt self-signed certificates in chromium today, which makes certain setups very difficult to support. For example, a code-server on Tailscale, that can't be signed in a traditional manner, and cannot be installed as a PWA due to its lack of SSL.
Describe the solution you'd like, including relevant patches or source
Either the ability to automatically install self-signed certificates or to allow PWA installs on HTTP sites.
Additional Notes
I'm on Windows, and have spent an hour tinkering around with different guides and stackoverflow posts.

Is this resolved in the next release?

doesn't look like it, has Alex denied this request? it's pretty annoying that you can't install self-hosted webapps as PWA

This is a batch closing operation (can also be regarded as a ping), I will reopen the issues that still have new responses

@MulverineX OK, you may need to use a 2048 bit encrypted certificate. One of the patches I added makes that the minimum length accepted. You may also try the chrome://flags/#disable-web-security flag.

@Alex313031 thank you! Is there any resource you can link me to to help guide me?


Error retrieving function keys on generation of gvalues file

On running .\Generate-Config.ps1 to auto-generate my gvalues file, I receive the following error:
Not Found({"error":{"code":"NotFound","message":"Error retrieving function keys."}})
The command that invokes the error is:
az rest --method post --uri "https://management.azure.com$($funcapp.id)/functions/$funcname/listKeys?api-version=2018-02-01" -o json --subscription $subscription

At https://github.com/microsoft/RockPaperScissorsLizardSpock/blob/04180aca9bdc01929a80a1b947443c796fcdf565/Deploy/powershell/Generate-Config.ps1#L174
I suspect an incorrect uri format is the reason, as in this related thread on Stack Overflow. I tried again after updating the api-version to 2018-11-01, but this did not help.
Any thoughts?

Changing the rest call in line 174 to:
az rest --method post --uri "https://management.azure.com$($funcapp.id)/host/default/listKeys?api-version=2018-02-01" -o json --subscription $subscription
gets me past the error, with a JSON result like this (keys are fakes):
PS C:\work\source\RockPaperScissorsLizardSpock\Deploy\powershell> echo $funckeys
{
  "functionKeys": {
    "default": "fhUkfjRP/F9FIRJJ889590505/qUi526gnkssRSfCTiTgDeF8aGg4EbHw=="
  },
  "masterKey": "8UUjfhyr79/aS98fhkjeRXvRCNSIRI8UgqTyjjtQjEFJw9khV0WXe9oQ==",
  "systemKeys": {}
}

However, the ConvertFrom-Json cmdlet fails. My guess is that the "/" special characters are a problem.
For now, I'm going to hardcode the predictor apiurl in gvalues.yaml.

The issue is fixed in PR #11

A note if someone has the same issue.
The problem with the gvalues generator is that it assumes that azure function is already deployed, hence it can recover the key. If the azure function is not deployed gives the "Not Found" error.
This indeed was an error not being noted on the deployment steps or in the unified deployment script.

@OriolBonjoch - how did you get past it?

Creating the azure functions for the predictor service before executing the Generate-Config.ps1 script. If the azure function is already published in the same resource group and at azure you have the azure key.
If the azure function was deployed with the code and you can see the NextMove function key in the azure portal the reason might be another.
Side note: in case you don't deploy the predictor azure function just remove the whole inf.apiurls.predictor value from the global properties file while doing it without the Generate-Config script (or comment out the following lines:
https://github.com/microsoft/RockPaperScissorsLizardSpock/blob/fb6e8cbee2b9eaeeb208661783d74719bb01ce6b/Deploy/powershell/Generate-Config.ps1#L176-L177
and set $token.predictorbaseurl = "".


Implement Arcane Armor

(could be a magically crafted armor or a status to an existing equipped armor, similar to Pact of the Blade). Container should allow selection of 2 effects:

[ ] Guardian Armor gives 2 skills: Thunder Gauntlets and Defensive Field. Thunder Gauntlets is an unarmed strike attack that's basically 1d8 Thunder Distracting Strike. Defensive Field is just temp hit points passive added to the armor.
[ ] Infiltrator Armor gives 3 skills/passives: Lightning Launcher, Powered Steps and Dampening Field. Lightning Launcher is similar to Which Bolt, but the extra cast doesn't cost an action, Powered Steps and Dampening Field are easy passive bonuses.

Maybe create an item that can combine with mundane armor using the in-game creation system?  It would require the creation of light, medium, and heavy types of armor.

Arcane Armor Shout skeleton added to Armorer Push #65

@G-Vie any news?


Add mramonleon to apache-httpcomponents-client-4-api plugin

Description
Add M. Ramón León (mramonleon) as a developer for the apache-httpcomponents-client-4-api plugin
@dwnusbaum
Submitter checklist for changing permissions

Always

[x] Add link to plugin/component Git repository in description above

When adding new uploaders (this includes newly created permissions files)

[x] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[x] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[x] All newly added users have logged in to Artifactory at least once

@dwnusbaum this is a new PR, I closed the one which failed.


DOT graph generation

The first task related to visualisation will be to get the server generating simple DOT graphs for the steps in the workflow and including these in the page

Do we want to expose this also as a downloadable resource, e.g. /dot or .dot?
SVG could then later be done as .svg (that would have to call dot installed on the server, which we can add to the Dockerfile with an apt-get install graphviz)


Fix: select option text colour

Overriding normalize.css to fix the invisible select text.

My build is not working locally, but since I was only changing CSS it is hopefully safe.


x/tools/gopls: provide function that gives list of candidate imports matching pattern

What version of Go are you using (go version)?

$ go version
go version devel +44c9354c5a Fri Jun 21 05:21:30 2019 +0000 linux/amd64
$ go list -m golang.org/x/tools
golang.org/x/tools v0.0.0-20190620191750-1fa568393b23
$ go list -m golang.org/x/tools/gopls
golang.org/x/tools/gopls v0.0.0-20190620191750-1fa568393b23

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN="/home/myitcv/gostuff/src/github.com/myitcv/govim/cmd/govim/.bin"
GOCACHE="/home/myitcv/.cache/go-build"
GOENV="/home/myitcv/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/myitcv/gostuff"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/myitcv/gos"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/myitcv/gostuff/src/github.com/myitcv/govim/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build670036660=/tmp/go-build -gno-record-gcc-switches"

What did you do?
Much like gopls offers completion candidates, it should provide a function that allows editors to tab-complete/fuzzy match/whatever packages to import.
For example, in govim we want to provide the command GOVIMAddImport such that when we type:
:GOVIMAddImport en<Tab>

(where <Tab> is us looking to complete the import), we should be able to call gopls and get a list of import candidates matching en (according to some algorithm)
Reference: https://github.com/myitcv/govim/issues/317

cc @stamblerre @ianthehat

I think this fits into the functionality covered by https://github.com/golang/go/issues/31906, or is there anything else that we should add to that issue?

@stamblerre - I think they're different. In this case I'm looking to provide a command that can be run in normal mode (which is the mode in which you can issue commands to Vim).
:GOVIMAddImport en<Tab>

Reason being, not everyone does/will think that completion is the way to add an import.
But also because this will likely become the primary way of adding named imports, e.g.:
import qt "github.com/frankban/quicktest"

Would be added via:
:GOVIMAddImport github.com/frankban/quicktest=qt

or similar.

What LSP request would this command map to?

That's really part of the reason for me raising the issue. The short answer is: I don't know 😄
Is there not any scope for an LSP implementation providing additional methods, beyond the spec?

Not that I'm aware of, though we can certainly raise this with https://github.com/microsoft/language-server-protocol. What's the justification behind users wanting to manually add imports rather than using goimports-type behavior?

As i mentioned in https://github.com/golang/go/issues/32749#issuecomment-505129525, because this will be the primary (only?) way of adding a named import.

My best guess for how this could work with the current state of gopls is that you automatically add an import using a quick fix, and then you rename it (I believe @suzmue intends to support that behavior, but it hasn't been added yet). govim would have to do the task of combining those 2 together.

But this won't work where you already have an identifier in scope which has the name of the package being imported, which is exactly why I'd be looking to have a named import.

Another case where this is required (just stumbled across it again, which reminded me): where you import a package for its side effects.

It seems like it would require a change to the lsp spec to provide the exact function you are looking for, but there are a few ways I could see something similar potentially fitting in to gopls:

autocomplete in import spec (import qt "gith<>)
try to resolve imports by ignoring package name and provide the renamed package import (fix: Add import qt "github.com/pkg")
Provide multiple quick fixes to choose from that would satisfy the missing import.

With finer control about what import fixes are applied, which we are working on supporting, these seem like things that would be possible.

@suzmue - the description talks about providing a Vim command. Vim operates in different modes. Completion is possible in insert mode, at the point of the cursor. Commands operate in normal mode: the cursor position is not within document for such commands.
In any case, the intention is to call such a command when elsewhere in the code; i.e.
Making a request to the LSP spec team sounds like a big step for something that I would think is better suited to an experiment for now. Is there a means by which we can extend the API of gopls for experimental methods such as this?

@myitcv vim-go provides this kind of functionality. I can help you understand how it works if needed.

Thanks @bhcleek - understanding how to do this is not where I'm stuck 😄. It's that I think this logic belongs in gopls, which is ultimately the source of truth for questions about syntax, types, packages, modules etc.
Of course each editor (plugin) could implement this sort of thing, but that kind of defeats the point of a language server to my mind.
As I mentioned in https://github.com/golang/go/issues/32749#issuecomment-508566031, there are likely to be ideas/requirements like this that fall outside of the LSP spec. It makes sense to experiment with these at different levels:

in editor (plugins), if possible
gopls via a side-API, not part of the LSP spec
proposing changes to the LSP spec

For this particular requirement, because it is not covered by the LSP spec, I'm suggesting we explore avenue 2, as a test case if you will.

We have not yet considered a plan for features outside of LSP in gopls, and I don't expect that will be a high priority for us in the near future. However, this is definitely a possibility we should consider.
Still, I'm not convinced that this feature is necessarily one that we need to provide separately from existing gopls features, since it is effectively a combination of quick fix import + rename.
In the meantime, I would definitely consider filing an issue against the LSP specification, as other languages may also be interested in this type of feature. It takes a while to make changes in the LSP spec, so definitely worth filing the issue, even if its not something they're interested in doing.

On the back of some work to add Symbol support to govim (which incidentally gave rise to #38273 and #37237) it just struck me that the Symbol method can give us exactly what we need here.
e.g. using the proposed advanced query syntax:
kind::4 ^encoding

where:

SymbolKind=4 is package
^ is a prefix exact match for the token that follows

would return the results:
json
hex
...


Add java 8 and async usage helpers

Codecov Report

Merging #39 into master will increase coverage by 0.34%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master      #39      +/-   ##
============================================
+ Coverage     98.63%   98.98%   +0.34%
- Complexity      256      390     +134
============================================
  Files            12       23      +11
  Lines           734      987     +253
  Branches        105      128      +23
============================================
+ Hits            724      977     +253
  Misses            3        3
  Partials          7        7

Impacted Files
Coverage Δ
Complexity Δ

...elperwrapper/ConsumerWithTracingAndMdcSupport.java
100% <100%> (ø)
7 <7> (?)

...elperwrapper/CallableWithTracingAndMdcSupport.java
100% <100%> (ø)
7 <7> (?)

...elperwrapper/SupplierWithTracingAndMdcSupport.java
100% <100%> (ø)
7 <7> (?)

...lperwrapper/PredicateWithTracingAndMdcSupport.java
100% <100%> (ø)
7 <7> (?)

...elperwrapper/FunctionWithTracingAndMdcSupport.java
100% <100%> (ø)
7 <7> (?)

...perwrapper/BiFunctionWithTracingAndMdcSupport.java
100% <100%> (ø)
7 <7> (?)

.../nike/wingtips/util/AsyncWingtipsHelperStatic.java
100% <100%> (ø)
32 <32> (?)

...elperwrapper/RunnableWithTracingAndMdcSupport.java
100% <100%> (ø)
7 <7> (?)

...perwrapper/BiConsumerWithTracingAndMdcSupport.java
100% <100%> (ø)
7 <7> (?)

...erwrapper/BiPredicateWithTracingAndMdcSupport.java
100% <100%> (ø)
7 <7> (?)

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2ded77...cb7997e. Read the comment docs.


Add PartiallyFailed phase for backups, don't exit on first error

rel #1371
This PR adds the PartiallyFailed phase for backups.  It modifies the backup execution logic so that rather than immediately exiting when the first error is encountered, the error is logged and execution continues. At the end, the number of errors logged is counted, and a >0 result moves the backup to PartiallyFailed.
Still a WIP, but the basic functionality is working. An easy way to see what it looks like is to create a cluster role binding for a cluster role that doesn't exist, to a service account in the namespace you're backing up -- this will create a "partial failure" error.
@nrb @carlisia appreciate any input at this point!

output of velero backup get:
NAME             STATUS            CREATED                         EXPIRES   STORAGE LOCATION   SELECTOR
partial-fail     PartiallyFailed   2019-04-19 08:40:53 -0600 MDT   29d       default            <none>
partial-fail-2   PartiallyFailed   2019-04-19 08:52:02 -0600 MDT   29d       default            <none>

output of velero backup logs partial-fail-2 | grep error:
time="2019-04-19T14:52:16Z" level=info msg="1 errors encountered backup up item" backup=velero/partial-fail-2 group=v1 logSource="pkg/backup/resource_backupper.go:265" name=velero namespace=velero resource=serviceaccounts
time="2019-04-19T14:52:16Z" level=error msg="Error backing up item" backup=velero/partial-fail-2 error="clusterroles.rbac.authorization.k8s.io \"non-existent\" not found" error.file="/go/src/github.com/heptio/velero/pkg/backup/item_backupper.go:328" error.function="github.com/heptio/velero/pkg/backup.(*defaultItemBackupper).executeActions" group=v1 logSource="pkg/backup/resource_backupper.go:267" name=velero namespace=velero resource=serviceaccounts

Made a few more updates - this is ready for review. Still testing.

addressed comments in latest commits

rebased/squashed/changelogged


GDCMImageIO in master branch crash at ultrasound files after PR 1306

Try any lossy JPEG YBR_FULL_422 file, e.g. from www.creatis.insa-lyon.fr CLIP0001
WARNING: In /home/r/itk/myITK/ITK/Modules/IO/GDCM/src/itkGDCMImageIO.cxx, line 314
GDCMImageIO (0x55fe83dc09b0): Converting from integer YBR to integer RGB is a lossy operation.

Not a JPEG file: starts with 0x00 0x00
itk::ERROR: GDCMImageIO(0x55fe83dc09b0): Failed to get the buffer!

There are two solutions currently available. Closed.

The issue should be closed after a fix has been merged.

That bug was mentioned here and here.

CC @seanm @vfonov

Fixed by #1309.


WIP on revamping the docs for new CP and Vault developments

Hmm docusaurus doesn't like links to static files, even if I use HTML <a.. instead of markdown.
https://app.netlify.com/sites/iiif-canvas-panel/deploys/620f8fe33aa28700079138d6#L87

Also CP does odd things in this demo
https://deploy-preview-137--iiif-canvas-panel.netlify.app/demos/simplest-viewer.html

(merge any time and we'll carry on from there)


proposal for stable 0.16.1

The jruby build marked back as allowed failure as it's the same case in celluloid-master.

@niamster when I merge this, is it ready to cut? It seems so.

@digitalextremist yes, I think so. Need then push the gem and put the tag

@niamster I cut & tagged 0.16.1, feel free to describe the release:

https://github.com/celluloid/celluloid-zmq/releases/new?tag=v0.16.1


screenshot file name by EBITENGINE_SCREENSHOT_KEY is wrong in the afternoon

Ebitengine Version
9cd7f827f418cf955add8d183c751c4e84498bbe (2.6)
Operating System

[ ] Windows
[ ] macOS
[ ] Linux
[ ] FreeBSD
[ ] OpenBSD
[ ] Android
[ ] iOS
[ ] Nintendo Switch
[ ] PlayStation 5
[ ] Xbox
[ ] Web Browsers

Go Version (go version)
go version go1.21.1 darwin/amd64
What steps will reproduce the problem?

Run an Ebitengine application with setting an environment variable EBITENGINE_SCREENSHOT_KEY a key name
Press the specified key in the afternoon and dump an image
Confirme the image filename

What is the expected result?
The image filename includes 12-23 for the hour part
What happens instead?
The image filename includes 00-12 for the hour part
Anything else you feel useful to add?
No response

The same thing happens with EBITEN_INTERNAL_IMAGES_KEY.


Negated Boolean Prop Shorthand

JSX has a shorthand boolean prop notation, which sets prop to true.
<input disabled />
<Button small primary ghost disabled block>Click me!</Button>

But this feature allows to set props only to true. What do you think about a shorthand
for setting a prop to false? Like, this is my use case:
<Markdown !escapeHtml source={/*...*/} />

It is useful for components which have props that default to true.

@streamich Optional prop is falsy by default. If you want strict comparison add defaultProps flag. There's no need in syntax noise.

@TrySound

Optional prop is falsy by default.

Yes, that's why I wrote:

It is useful for components which have props that default to true.

Syntax noise is this:
<Markdown escapeHtml={false} />

This is syntax sugar:
<Markdown !escapeHtml />

Syntax noise is irregular cases. This syntax covers more cases.
<Markdown escapeHtml={false} />

Less special syntax means less noise. That's why lisp is the simplest language from point of syntax.

Would be a more fitting discussion for the JSX repo instead https://github.com/facebook/jsx

I agree with @TrySound.
And when you have that prop default to truthy then it is good practice to be explicit. In that way you visually distinct the default behavior from that special case. When you have the existing syntax you see in instant the meaning but in your case it's easy to overlook the ! mark.

I'm not a huge fan of syntaxic sugar. When teaching React (and JSX) to beginners, I've observed that the boolean shorthand syntax was already in itself confusing. It's the same thing for the string syntax (prop="value" instead of prop={"value"}).
So I would abstain from adding more syntax for non necessary things.

https://github.com/facebook/jsx would be the better place to file this proposal, though I agree it's very unlikely we'd do it.


The C# extension for Visual Studio Code (powered by OmniSharp) is incompatiable on linux aarch64

Hi Just getting started with VS Code latest 1.5.2 on a Unbuntu20.4 OS on ARM64 RasberryPI and get this message when have C# for Visual Studio Code (powered by OmniSharp) ext-installed
Did have 1.5.1 VS code installed and same issue ?
Is this a no support for ARM ? only supports x86 ? Or am I missing a configuration, environment issue ?

Linux ARM is currently not supported.

This is a dupe of https://github.com/OmniSharp/omnisharp-vscode/issues/2771

This is a dupe of https://github.com/OmniSharp/omnisharp-vscode/issues/2771

See https://github.com/OmniSharp/omnisharp-vscode/wiki/Remote-Debugging-On-Linux-Arm for instructions.

See https://github.com/OmniSharp/omnisharp-vscode/wiki/Remote-Debugging-On-Linux-Arm for instructions.

@gregg-miskelly
hi I think I missed something , I want to debug aarch64  program in my macOS , I follow your instruction :
https://github.com/OmniSharp/omnisharp-vscode/wiki/Remote-Debugging-On-Linux-Arm
but it show me .........

@gregg-miskelly
hi I think I missed something , I want to debug aarch64  program in my macOS , I follow your instruction :
https://github.com/OmniSharp/omnisharp-vscode/wiki/Remote-Debugging-On-Linux-Arm
but it show me .........

@lokinfey You asked about Linux. arm64 macOS is not yet supported.

@lokinfey You asked about Linux. arm64 macOS is not yet supported.

@lokinfey You asked about Linux. arm64 macOS is not yet supported.

@gregg-miskelly  I want to know when I can using C# extension in local aarch64  dev env .  I build linux arm64 vm in my apple silicon mbp . I know C# for apple silicon not ready , but linux arm64 local debug can publish ......

@lokinfey You asked about Linux. arm64 macOS is not yet supported.

@gregg-miskelly  I want to know when I can using C# extension in local aarch64  dev env .  I build linux arm64 vm in my apple silicon mbp . I know C# for apple silicon not ready , but linux arm64 local debug can publish ......

@lokinfey Since your issue is fairly unrelated to this original issue, please open a new issue. Nothing on Apple Silicon is tested/supported yet. So I am not sure if we will really be able to help. But we can try.

@lokinfey Since your issue is fairly unrelated to this original issue, please open a new issue. Nothing on Apple Silicon is tested/supported yet. So I am not sure if we will really be able to help. But we can try.


Image placement randomly skips spaces on certain resources

Seems to happen randomly. See example

Finally figured this out. The height of each block is variable, based on how long the text blurbs under the images were. The first item in the second row tries being placed as high on the page as possible, prioritizing that over being as far left as possible. If the first item in the first row is the tallest, then it gets bumped to the right to accomplish this, leaving that blank space.
The solution was setting these blocks to a fixed height so they're all the same, which has the added benefit of making sure all images in each row are aligned (I think that looks nicer).


Export functions

Added three functions to export
-- a list of labelled coefficients
-- a pure python function for model.predict
-- a string defining a pure python function for model.predict

@ColCarroll This is great stuff.  Here is my feedback so far.  I think it still needs the following things before merge:

Make func_factory private or change func_factory to be methods of BasisFunction subclasses (change _basis.pyx).
Support SmoothedHingeBasisFunction (for smoothed models) - see section 3.7 (Degree of continuity) of Friedman, 1991(see README.md for reference) for details.
Unit test for export_labelled_coefficients
Match names for unit tests and the functions they test
Update doc string for export_python_string to indicate it returns a string
Maybe change name of export_python_model to export_python_function?
Does this support the constant term?
Add function_name argument to export_python_model
Move all this export related code into its own module, export.py.  I think it will be easier to read and think about that way.

Thanks so much for all this work!

Closing this.  I believe it was actually included in another later pull request that has already been merged.


Add lock rotation feature to spatial editor viewport

This PR adds a menu option to the spatial editor viewport for locking the current viewport rotation. This is incredibly useful to prevent accidentally rotating your orthogonal top/side views in a multi-viewport setup.

When the rotation is locked, should rotation events be transformed into panning events like in Blender?

@Calinou Would this functionality apply to all navigation styles, or only the godot style?

Thanks, looks great!


Support for BaseViewHolder.setLayoutManager

Great work folks.
it would be nice to have viewHolder method like setLayoutManager to set Layout Manager to inner RecycleView.

There are two ways to：

Through viewHolder.getView(R.id.iv) access RecycleView set Layout Manager

2.Custom BaseViewHolder

Yeah,
i'm already using viewHolder.getView(R.id.iv). Though i think it may initialise layout manager every time.


Add stats to header links

Add http://stats.danielstrunk.me to the header links (after about), via https://gyrosco.pe.
Also add this link to the improved about page #8

Closed by PR #15

Closed by #15


Remove unnecessary cloning of str

Instead of cloning the stdout and stderr several times, we can use references. This should in theory make it faster.

@barskern Hey, thanks for the initiative.
Unfortunately Travis build fails:
error: this argument is passed by value, but not consumed in the function body
   --> src/reactor.rs:149:19
    |
149 | fn notify(report: Report) {
    |                   ^^^^^^
    |
    = note: `-D needless-pass-by-value` implied by `-D warnings`
    = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.212/index.html#needless_pass_by_value
help: consider taking a reference instead
    |
149 | fn notify(report: &Report) {
150 |     let icon = *match report.outcome {
151 |         Outcome::TestsPassed => "face-angel",
152 |         Outcome::TestsFailed | Outcome::CompileError => "face-angry",
153 |     };
154 |     let icon = match *report.outcome {
  ...
error: aborting due to previous error

When I run clippy locally on the nightly branch I do not get the same results. I realize that Travis is testing the stable, but clippy-preview is not avaliable (atleast for me) on the stable branch.
$ rustup component add clippy-preview
error: toolchain 'stable-x86_64-unknown-linux-gnu' does not contain
component 'clippy-preview' for target 'x86_64-unknown-linux-gnu'

@barskern You need to update to the latest version of stable (1.29).
Try to run
rustup update stable

I've also recorded a screencast about this:)
https://www.youtube.com/watch?v=SNpJ3h8R4ks

Perfect! Thank you :smiley:

@barskern Takk! =)