XamarinAndroidV1 does not yet surface the new Android App Bundle publishing format option

Required Information
Question, Bug, or Feature?
Type: Feature
Enter Task Name: Xamarin.Android
https://github.com/microsoft/azure-pipelines-tasks/blob/master/Tasks/XamarinAndroidV1/
Environment

Server - Azure Pipelines.

Issue Description
Current behavior
The Xamarin.Android task has a dedicated boolean input for createAppPackage, described as Passes the target (/t:PackageForAndroid) during build to generate an APK:

New feature to add
As of the recent Xamarin.Android SDK 10.0 and 10.1 releases, the Xamarin.Android SDK supports a new AndroidPackageFormat MSBuild property that allows creating packages that follow the Android App Bundle publishing format.
Currently, users can select this packaging format by adding an argument like -p:AndroidPackageFormat=aab to the msbuildArguments input. But since createAppPackage is its own input separate from the target input, it would be nice to surface the Android App Bundle packaging format similarly.
One option could be to make the createAppPackage a multiple choice option instead of a boolean option so that users would have a list of choices similar to:

Do not create app package.
Create APK.
Create Android App Bundle.

Depending on opinions about best practices, another option might be to encourage users to set the AndroidPackageFormat MSBuild property per-configuration within their .csproj file instead of via the Xamarin.Android task configuration. In that case, maybe the best change would be to reword the createAppPackage description to say something like:
Passes the target (/t:PackageForAndroid) during build to generate either an APK or Android App Bundle, depending on the AndroidPackageFormat property for the selected configuration.

@brendanzagaeski  hi there. I have been looking for a solution to this issue . Yes VS2019 16.4 gives us the option to select aab without editing the csproj file.
However it is still not clear to me what we should do in the pipeline.

AAB i guess is build by the proj.
what is there todo since now also the msbuild task that we manually added is redundant too...

Am I missing the obvious.
It would be nice to have a walkthrough step.

Hi @developer9969, I'm afraid I don't quite understand the question.
It sounds like you are working on modifying a step that happens after the XamarinAndroidV1 task completes its work? I'm not too familiar with what other steps users tend to use in their pipelines after the XamarinAndroidV1 task builds the .apk or .aab file (via the PackageForAndroid MSBuild target).
What are you trying do with the .aab file that isn't working for you yet? Note that .aab files do need to be signed to be submitted to Google Play. Is the signing step the part you're wondering about?

Hi there,
many thanks for your time and reply.
All I want to do is to move away from apk and use aab using azure devops.
APK

Build Android using xamarin android task
Sign APK using  Task
DONE

AAB
I need some clarification whether the android task will build the aab for me without using msbuild as outlined below.
I am planning to:

Select aab in visual studio android project.
MSBUILD task as  outlined in this blog very clearly.
No longer a need to use the android task

https://www.linkedin.com/pulse/android-app-bundle-xamarinandroid-apps-using-azure-devops-popovska/
Do I still need to write an msbuild task with various params as outlined in the blog or  will the android task have a check box eg AAB and nothing for me todo?
many thanks for your time

To followup on this conversation about building Android Bundles mostly because it's been a little bit of a battle to get this to work for me. @brendanzagaeski At this point in time I've not seen any of this info integrated into the docs, though I may have missed it.
I didn't find the LinkedIn blog post that @developer9969 posted above, but I did find this one from James Montemagno very useful and in the end was able to make it all work from what he wrote. However, I learned a few things that I thought I'd share here.

You don't need to enable any of the apk/aab output options in the Android project settings (under the Android Options tab) unless you'd like them to be built on your desktop.
Using the "Additional arguments" as both articles suggest works. Making sure to upload your .keystore to the Secure Files tab of the Library and define a variable group using protected variables for your passwords/alias.
If, as James M. suggests, you want both output types, you need to perform the XamarinAndroid@1 task 2 times in your pipeline. The first task should produce the .aab (Bundle) output, followed immediately with a second task to create the .apk. You can then archive your output once as both the .apk/.aab will be in the output dir. The order of these two tasks is important as production of the .aab will delete the .apk file in the output dir. (The order wasn't clear in his article and took a bit of trial and error to figure out)
-Signing of either output can occur in between/or after.
-Remember to disable the Clean option on the 2nd XamarinAndroid@1 task to avoid deleting the previous task outputs.


maint(core): Remove extra CLI tasks

Purpose
Removes some CLI tasks which are only needed by managed service users. We will later replicate these features in the UI instead. They include:

add proposer
approve
fund
list proposers
monitor
withdraw

Command/find "monitor" in the repo. Is there a reason to keep any of this?

I noticed that the functions successfulProposalMessage and alreadyProposedMessage mention approving and funding the bundle via the CLI

It looks like monitorExecution mentions the chugsplash-fund task. If you don't want to remove this function, we should at least change that error message.

We should remove the relevant variables here

@sam-goldman
So I've been working on the gas estimation PR and I've realized that we've introduced a lot of changes that make it quite difficult to test the remote executor. So I've decided to put this PR on hold until after we've resolved that issue since quite a bit of this logic may turn out to be necessary for that.


Generating implementations for imported types

This currently fails:
import "math/big"

is := []int64{1, 2, 3}.morph(big.NewInt)

It fails for two reasons:

big.NewInt is printed as *math/big.Int, causing a syntax error
math/big is not imported in ply-impls.go, causing a type error

The former doesn't seem too bad, but the latter might be a pain to fix.

Hmm. Thinking more about this, it seems to bump into the same ugliness as #13. Specifically, if we have two files with imports like:
import "fmt"

import fmt "math/big"

How do we reconcile those when compiling a single ply-impls.go?
Perhaps this means that, at least for now, we need a separate ply-impls for each file. At that point, we may as well tack the impls on to the end of each compiled .go file. If #13 is eventually implemented, it shouldn't be hard to merge the combined files together.


Code clean up

I removed the reposViewModel variable from:

func reposViewModel(_ reposViewModel: ReposViewModel, isLoading: Bool)
func reposViewModel(_ reposViewModel: ReposViewModel, didReceiveRepos repos:)
func reposViewModel(_ reposViewModel: ReposViewModel, didSelectId id: Int)

Delegate methods

@tailec this implementation of the MVVM is really close to the MVP. I cannot tell the difference between this implementation and MVP.

MVP just create a layer of abstraction to the view. So, the view communicate to the presenter by the protocol. But, the presenter should not have references to the UIKit. The ideia is to be able to test the view without a device (simulator). Like run the tests on macOS

I'm gonna close it


Rename modules. Add prefixes.

For: https://bugs.swift.org/browse/SR-11151
Basic -> SPMBasic
SourceControl -> SPMSourceControl
Build -> SPMBuild
Workspace -> SPMWorkspace

Thanks. Seems good but can you revert the whitespace diffs?

gosh, I don't even know how it happened (VSCode magic I guess)

@aciidb0mb3r updated.

@swift-ci smoke test

We'll probably need changes in sourcekit-lsp too /cc @benlangmuir

And https://github.com/apple/swift-stress-tester /cc @nathawes

stress tester seems to be using exact version of SwiftPM

👍

@swift-ci smoke test

never happened. closing.


DBeaver CE and Microsoft Store: syncing versions & dates

DBeaver Team,
First: EXCELLENT TOOL to work in heterogeneous environments where multiple types of DB Vendors and versions are used!
And that matrix of usage would be huge !
Next:
In somewhat strict environments where software installations are limited and controlled by SysAdmins/NetworkAdmins and others that new method of using Microsoft Store is viable alternative to "local" bureaucracy. However, it would be helpful that versions, dates , release and other all would match.
I have DBeaver version   Version <IP_ADDRESS>106032102 that was released May 31, 2021 however, Microsoft Store signature says otherwise... (see attached). Not sure if it is in your "control" or Microsoft "control", but it has to be in sync.

@YuriDude Thank you for the suggestion. This date is in Microsoft control and it states the day when an app was added to the Microsoft Store and is irrelevant to the last update date.


Require Limits and Requests

I'd like to have a policy that checks for a match between resource requests and limits. Since there doesn't appear to be any kind of == operator, I tried making use of variables like so:
            containers:
              - resources:
                  requests:
                    memory: "?*"
                  limits:
                    memory: "$(./../../requests/memory)"

To my surprise though, my newly created pod (with non-matching memory requests/limits) passed validation. I suspect the variable is not interpolating what was set for requests.memory and is just using "?*". Am I thinking about this correctly? Is there another method I can use to evaluate?

Hi, @windowsrefund.
Yes, your suspicion is correct. $() notation takes the part of policy by provided path and places it instead of itself.
So your policy is equivalent to:
containers:
- resources:
    limits:
      memory: "?*"
    requests:
      memory: "?*"

Which allows all the policies with both memory fields specified.
I wrote a simple policy that denies not matching memory fields in requests and limits:
apiVersion: kyverno.io/v1
kind: ClusterPolicy
metadata:
  name: all-containers-need-requests-and-limits
spec:
  validationFailureAction: enforce
  background: false
  rules:
  - name: check-container-resources
    match:
      resources:
        kinds:
        - Pod
    validate:
      message: "resources.resquests.memory must be equal to resources.limits.memory"
      deny:
        conditions:
        - key: "{{ request.object.spec.containers[?resources.requests.memory!=resources.limits.memory] | length(@) }}"
          operator: NotEquals
          value: 0

It uses JMESPath notation and traverses the containers list to check memory fields in each element. If it found any, the condition will fail.

Nice idea here, @kacejot ! I've taken it and expanded upon it to be applicable to all Pod controllers. I will get this added to the policy library so @windowsrefund and others can benefit.
apiVersion: kyverno.io/v1
kind: ClusterPolicy
metadata:
  name: memory-requests-equal-limits
  annotations:
    pod-policies.kyverno.io/autogen-controllers: none
spec:
  validationFailureAction: enforce
  background: false
  rules:
  - name: memory-requests-equal-limits-deployment
    match:
      resources:
        kinds:
        - Deployment
        - DaemonSet
        - StatefulSet
        - Job
    validate:
      message: "resources.requests.memory must be equal to resources.limits.memory"
      deny:
        conditions:
        - key: "{{ request.object.spec.template.spec.containers[?resources.requests.memory!=resources.limits.memory] | length(@) }}"
          operator: NotEquals
          value: 0
  - name: memory-requests-equal-limits-pod
    match:
      resources:
        kinds:
        - Pod
    validate:
      message: "resources.requests.memory must be equal to resources.limits.memory"
      deny:
        conditions:
        - key: "{{ request.object.spec.containers[?resources.requests.memory!=resources.limits.memory] | length(@) }}"
          operator: NotEquals
          value: 0
  - name: memory-requests-equal-limits-cronjob
    match:
      resources:
        kinds:
        - CronJob
    validate:
      message: "resources.requests.memory must be equal to resources.limits.memory"
      deny:
        conditions:
        - key: "{{ request.object.spec.jobTemplate.spec.template.spec.containers[?resources.requests.memory!=resources.limits.memory] | length(@) }}"
          operator: NotEquals
          value: 0


Broaden Unicode range for domains

Expanded the domain Unicode to sys.maxunicode

Bump

If it is preferred to only store ASCII or IDNA, that could be done.

We'll merge it into this interim branch and do testing on the dev branch before we merge to master.


mssql-docker pricing model for production use

We want to use mssql-docker for our Database in container in production.
Currently we have Dbs using Azure Sql (as PAAS).
Where can I find the detailed licensing (and pricing) documentation about mssql-docker use in production.

SQL Server container pricing is based on SQL Server core based licensing model. Please see the SQL Server Licensing Guide for more details about how container licensing works.


Fix missing service instance name in trace command

When I trying to add skywalking-intra-e2e into skywalking-satellite, I found the cli could not get serviceInstanceName property in the trace command.
So this PR fix this.

Codecov Report

Merging #100 (bad8255) into master (8898c9c) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head bad8255 differs from pull request most recent head f25602b. Consider uploading reports for the commit f25602b to get more accurate results

@@           Coverage Diff           @@
##           master     #100   +/-   ##
=======================================
  Coverage   47.12%   47.12%
=======================================
  Files          11       11
  Lines         191      191
=======================================
  Hits           90       90
  Misses         93       93
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8898c9c...f25602b. Read the comment docs.


Add new Style/StringConcatenation cop

https://rubystyle.guide/#string-interpolation
# bad
email_with_name = user.name + ' <' + user.email + '>'

# good
email_with_name = "#{user.name} <#{user.email}>"

Closes #5067

Another good name for this cop, I think, is StringConcatenation.
Made it Safe: false, because there can be very rare cases where it can give false positives.
It may be also a good idea to add some config that indicates after which amount of terms to add an offense.

Great PR (as usual 😆)

Another good name for this cop, I think, is StringConcatenation.

I think I like this name better. Might also be a good idea to have the ability to autocorrect using format, but that's not a big deal.

Changed name to Style/StringConcatenation.

Would be nice to drop these outer () too, but maybe a different cop should do this?

Yes, to not complicate the actual implementation and also this is needed in many other cops, so I think it should be better handled by a different cop (named like Style/RedundantParentheses, for example). I will try to create one in the future, if no one gets ahead of me.

Changed name to Style/StringConcatenation.

Would be nice to drop these outer () too, but maybe a different cop should do this?

Yes, to not complicate the actual implementation and also this is needed in many other cops, so I think it should be better handled by a different cop (named like Style/RedundantParentheses, for example). I will try to create one in the future, if no one gets ahead of me.

Agreed. I created #8379 to be sure we don't forget :+1:


HINT: We don't support broadcasting, please use expand yourself before calling memory_efficient_attention

ValueError: Incompatible shapes for attention inputs:
query.shape: torch.Size([32, 14400, 8, 40])
key.shape  : torch.Size([2, 77, 8, 40])
value.shape: torch.Size([2, 77, 8, 40])
HINT: We don't support broadcasting, please use expand yourself before calling memory_efficient_attention if you need to
When i use animatediff ,it occur above quesiton.what does it mens?

I also have the same problem when i use "Reference" in ControlNet v1.1.443.
ValueError: Incompatible shapes for attention inputs: query.shape: torch.Size([2, 7225, 8, 40]) key.shape : torch.Size([1, 77, 8, 40]) value.shape: torch.Size([1, 77, 8, 40]) HINT: We don't support broadcasting, please use expand yourself before calling memory_efficient_attention if you need to

Same problem for me with Tiled Diffusion & VAE extension. :(

Same problem for me with Tiled Diffusion & VAE extension. :(

Have you solve the problem in the multidiffusion webui extension?

I solve this issue by setting drop_last=False in the dataloder.

有同样的疑问。

当我在 ControlNet v1.1.443 中使用“参考”时，我也遇到了同样的问题。
ValueError：注意力输入的形状不兼容：query.shape：torch。size（[2， 7225， 8， 40]） key.shape ： 火把。size（[1， 77， 8， 40]） value.shape： 火炬。Size（[1， 77， 8， 40]）提示：我们不支持广播，如果需要，请在致电前自行使用expand``memory_efficient_attention

In optimization Settings :[PR] reverse cue word leads to minimum sigma (when the image is close to completion...) Just change the value to 0


Config

Hi there.
I have a problem with config file. (used version 1.9r-12)
The changes keeps returning to "original" values every time i close my server.
My changed config should be like this.
auto-update: false
show-enchants: true
show-enchant-descriptions: true
abbreviate-large-numbers: true
use-roman-numerals: false
open-enchant-gui-on-right-click: false
anvil-combining-enabled: true
use-vault-economy: false
use-action-bar-instead-of-chat-when-inventory-full: true
global-cost:
enabled: false
cost: 69420*%lvl%
enchant-lore-color: '&9'
apply-fortune-on:

COAL

LAPIS_LAZULI

REDSTONE

DIAMOND

EMERALD

QUARTZ
player-kill-reward:
enabled: false
min: 25
max: 50
mob-kill-reward:
enabled: true
min: 10
max: 25
mining-reward:
enabled: false
min: 10
max: 15
blockstobreak: 15
enchant-specific-lore-color: {}
do-not-add-lore-to:

an item e.g. BEDROCK that you do not want lore added to due to plugin interference
disabled-enchants:

an enchant you don't like
playerkilltokens:
enabled: false
min: 25
max: 50
mobkilltokens:
enabled: true
min: 10
max: 25
miningtokens:
enabled: false
min: 10
max: 15
blockstobreak: 15
Showed config runs untill the session ends and values are correct. But with every restart it keeps going back to original values and again enable everything.
Is there anything i can do with this to make it permanent change?

oops i left debug code..

So after pligin reinstall everything seems to work just fine. No more config changes. Thank you!


error in displaying visuals in built in webapp

Error
module 'vanna' has no attribute 'run_sql_is_set'

It appears that you’re using an old tutorial. Could you provide the rest of the code and I can show you how to change it


layers: block members do not express extra array level in member type

Fixes GH #377.

cherry-picked and pushed to master


Question about USE_GHOST_POINTS.

Hi, I see the USE_GHOST_POINTS is use to select whether use mesh point cloud or not.
If I use scannet dataset, and set USE_GHOST_POINTS= False, where to get the instance label for each frame? I only find you get segments from segment = Image.open(segment_file_names[frame_idx]). But instance is a little weird.
It is not very clear in your dataloader file.
I see for all ScanNet dataset training, you always set USE_GHOST_POINTS= True.
Thank you.

Hi,
Yes, we always USE_GHOST_POINTS=True for ScanNet (and all other datasets except Ai2Thor). Maybe the confusion is why we say our method is using "sensor" point cloud when we use the USE_GHOST_POINTS=True -- when we say we use sensor point cloud, we mean that we produce features on the sensor RGB-D point clouds. We then use "USE_GHOST_POINTS" to transfer these features to mesh point cloud via trilinear interpolation and segment and label there (Page 5, Sensor depth to mesh point cloud feature transfer). This is what we do for baseline methods as well, like Mask3D on sensor point cloud.
ScanNet only provides instances annotations on the mesh point cloud. They then project these annotations to RGB-D frames, however these labels are sparse and have holes. So they use some 2D post-processing like dilations and closing to fill up the holes. They release some of these annotations on their website -- however, if you visualize these labels in 3D, you will see a lot of noise due to these 2D closing operations and noisy depth. Instead of using those labels, we tried transfering the labels via KNN from mesh to sensor point cloud, and only supervise points which are sufficiently close to the mesh. Then at test time, we transfered predictions from sensor to mesh pointcloud. This gives similar accuracy as the USE_GHOST_POINTS -- but we decided to prefer USE_GHOST_POINTS method since it skips the RGB-D label generation and careful loss supervison complexities.
Let me know if you have any follow up questions, or if the script for generating labels on RGB-D point clouds would be useful to you.

Thanks for your explanation. I know you transfer features to mesh point cloud.
Yes, the RGB labels have a lot of noise. But I see in your paper, you mentioned that using RGB labels to train also have similar performance, right?
So I also want to use RGB labels to train the model, not mesh point cloud labels. Could you tell me how to use that on ScanNet dataset? Because I see you didn't provide the preprocess code for ScanNet on RGB labels training.

Its not super trivial, but here are some steps which might help:

generate_mask3d_gt_instance_new.txt: You can refer and use this file to generate GT instance labels, segments and valids on sensor RGB-D images. "segments" is super-voxels of scannet but per image, valids indicate the points which are near a mesh point and thus are safe to supervise.
Modify scannet2coco.py to also save the masks, valids and segments in the json
I believe the dataloader should work as it is, set USE_GHOST_POINTS=False and also use the flags MODEL.SUPERVISE_SPARSE = True to only supervise on valid pixels.
At test time, trilinearly interpolate mask predictions from sensor point cloud to mesh point cloud. you can use something like: https://github.com/ayushjain1144/odin/blob/main/odin/odin_model.py#L630-L638

I do not plan to support this functionality in main code, and I am sorry I would not be able to provide a code that you can run, but happy to help debug if you face any issue / answer any question that may pop up.

Thank you. The ScanNet already provide the GT instance labels, segments on RGB-D images. You mean I need to get the valids to make sure which points are safe to supervise?
For testing, have you tried directly predict on the RGB-D point cloud? Not interpolate to mesh point cloud?

I think ScanNet doesn't provide segments: these segments is not "segmentation" but they call super-voxelization or cluster of points as segments (like the segments loaded from mesh point cloud here: https://github.com/ayushjain1144/odin/blob/main/odin/data_video/dataset_mapper_scannet.py#L679).
I think you should be able to use their provided instance labels with the valids from this script, but I haven't tried it myself. If you run that script, I would suggest to consider using the labels saved by the script too.

For testing, have you tried directly predict on the RGB-D point cloud? Not interpolate to mesh point cloud?

Yes, and I typically used the flag TEST.EVAL_SPARSE = True to only evaluate on valid points. Those numbers though are not at all comparable to benchmark numbers because the density/number of points are very different between sensor and mesh point clouds. I don't have any meaningful numbers on sensor point cloud without interpolation since I was trying those  evaluations quite some time back.

I see. Thank you. Really? I thought ScanNet provide 2d labels here:
|-- <scanId>_2d-label.zip
    Updated raw 2d projections of aggregated annotation labels as 16-bit pngs with ScanNet label ids
|-- <scanId>_2d-instance.zip
    Updated raw 2d projections of aggregated annotation instances as 8-bit pngs
|-- <scanId>_2d-label-filt.zip
    Updated filtered 2d projections of aggregated annotation labels as 16-bit pngs with ScanNet label ids
|-- <scanId>_2d-instance-filt.zip
    Updated filtered 2d projections of aggregated annotation instances as 8-bit pngs

Yeah, they provide 2D instance labels but not "segments" (https://github.com/ScanNet/ScanNet/tree/master/Segmentator)

I see. What is that means? So these are only the instance segmentation labels, not semantic segmentation labels?
I didn't realize that.

the "segments" are neither semantic or instance labels. they are simply a bunch of points which are close to each other and have similar normals. For eg., see the attached figure.
A relevant writeup from ScanNet paper which describes "segments"

I see. Thanks for the details. So you mean if I used the code link you send me to get the segment, I will get a better performance, right?
If I used the link you provide for me:generate_mask3d_gt_instance_new.txt

yep, that's right.

Hi, I checked this function before. But it seems not exactly same as backprojector in generate_mask3d_gt_instance_new.txt:
In the txt file, rgb_coords = backprojector([rgb_coords.permute(0, 3, 1, 2)], depths[None].float(), poses[None].float())[0][0]. The inputs are rgb_coords, depths, and poses.
But in https://github.com/ayushjain1144/odin/blob/main/odin/modeling/backproject/backproject.py#L131-L139, the inputs are depths, poses, intrinsics

backproject.txt
Sure, here is the original file.

Thank you. It is very useful!

Hi, I have more questions, this is the files saved using generate_mask3d_gt_instance_new.txt
instance_sep.png, valids.png, segments.png
So, when I use scannet2coco.py file to save them in the json,
coco_output = {
        "info": INFO,
        "licenses": LICENSES,
        "categories": CATEGORIES if not scannet200 else CATEGORIES_200,
        "images": [],
        "depths": [],
        "poses": [],
        "valids": [],
        "segments": [],
        "annotations": []
    }

"valids" is valids.png, "segments" is segments.png, how about instance_sep.png? Should be put in "annotations"?

scannet2coco_new.txt
Zip of the branch where I tried running these experiments if that helps:
Mask2Former3D-segment_ghost.zip
I haven't touched this code for an year now, I would just use it for reference but wouldn't really try running this code as it can have bugs.

Thank you. I already mimic ai2thor2coco.py. It didn't work because I don't use LEARNING_MAP20. Thanks for your new code.
I think your training code can directly support 2d labels training (USE_GHOST_POINTS=False), right?

I see, yes, i think the segments are currently returned as None. You can modify load_3d_data function to also load the segments (the zip I sent you should help).
But unfortunately, I wouldn't be able to allocate time to actively debug and push a working code, since I don't intend to support no ghost_point version in the public code. But if you get stuck, please don't hesitate to message, and I will try to help in whatever way possible for me.

Okay. Thank you. I have checked .zip file. It also didn't load segments, it directly give None to segments. It seems that I need to write one by my self. But I am not sure the shape/format used in segments. Directly follow the valids shape/format? (bs, v, h, w)

Mask2Former3D-new_segments.zip
You're right, i rechecked, i added the segments functionality in another branch that i am attaching (you will also see something related to "VALID_FEATURE" flag, that didn't help and you can ignore).
But, in anycase, i would recommend running first without segments and get some reasonable performance; then add segments.

Thank you. I have tried to add segments, but it still takes errors in odin_transformer_decoder.py:
 # voxelize (mask features are already voxelized)
 assert mask_features_xyz.shape[-2] == mask_features.shape[-1]

I have checked the code, I don't think mask features are already voxelized before the odin_transformer_decoder.py.

Hi, I also have a question in the load_3d_data function. Why you downsample the segments?
# downsample the segments
segments = F.interpolate(
                    segments.float(), scale_factor=0.25, mode="nearest"
                )

In the code you give me.

Hi, I have a question about using 2d labels to train.
I see you use supervise sparseto train the model on ai2thor dataset. So for this dataset, you train using 2d labels and also evaluate on 2d labels?

Yes! (But they are not "really" 2D labels, they are 3D labels since the same 3D chair has a consistent instance ID across the RGB frames. Its just that instance labels are now of shape N X V X H X W where N=number of instances, V=number of views, H, W = height and width of images; instead of scannet where the labels are some N X M where M=number of points on ScanNet point cloud)

I see. So for ai2thor dataset, you train it using the 2d labels projected from 3d labels and with supervise sparse.
And for testing, you also evaluate using the 2d labels projected from 3d labels, it is like evaluate on each image, and also evaluate sparse?

No, both the supervision and evaluation is in 3D: i.e. on a point cloud of shape (VHW), 3 (i.e flattening the multiview RGB-D instances)
Some of the depth locations are invalid, so more precisely the supervision and evaluation is only on valid points out of total VHW points (by simply indexing the points with valids: https://github.com/ayushjain1144/odin/blob/main/odin/data_video/scannet_3d_eval.py#L122)

I see. Thank you. I can think that is 3d projection from all multiview RGB-D frames.
Did you evaluate on all points? not only valid points.

only on valid points for both our method and baselines. (However, i didn't notice much difference in absolute numbers)

Thank you. I see when you train on ai2thor, you set HIGH_RES_SUBSAMPLE True and HIGH_RES_INPUT True. Do you think I need this when I train use RGB-D points labels on ScanNet?

It saves some GPU memory, I would use it if the INPUT.IMAGE_SIZE is 512. I don't think it would benefit much when the size is 256

Thank you. RGBD points cloud supervise work.

Amazing! Glad to hear that 🙂


chore: remove TS SwitchBoard class + purge navRef pattern

Description
Follow up from #3771
PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a CHANGELOG.yml entry or my changes do not require one.

I haven't done a comprehensive review of all changes (I'll leave that to Mounir) but I've reviewed enough to get the gist. Really nice cleanup, so many fewer navRefs!

🕺🕺🕺 one step closer in the right direction 🎉

#squashongreen


Responsive contextual menu

What

Added utility hooks to observe height and width of containers of CallControlBar and CallWithChatControlBar in CallComposite and CallWithChatComposite, respectively.
Added ContainerRectProps to props of  CallControlBar and CallWithChatControlBar so that changes to container height and width will cause a rerender to buttons with contextual menus.
Why

https://skype.visualstudio.com/SPOOL/_workitems/edit/2794403
How Tested

Tested local samples
CallWithChat:
https://user-images.githubusercontent.com/79475487/163097116-74c826cf-aff1-4bc4-b3ce-86de85a7af8b.mp4
Calling:
https://user-images.githubusercontent.com/79475487/163097149-d1b04d2f-91ef-4e10-b9b9-b431e6f97011.mp4
Process & policy checklist

[ ] I have updated the project documentation to reflect my changes if necessary.
[ ] I have read the CONTRIBUTING documentation.

Is this a breaking change?

[ ] This change causes current functionality to break.

I don't understand what's happening in the demo video attached. Since it doesn't relate with the logic in this PR.
How is this piece of code making contextual menu responsive?


Remove un-needed constraint on time

Why is it unneded? a downstream consumer needs toknow what versions of time are compatible with cardano-slotting.

ledger had allows-newer: cardano-slotting:time so its not needed.

ledger had allows-newer: cardano-slotting:time so its not needed.

That tells me that ledger is ignoring that constraint but what about other users?
We are publishing cardano-slotting to CHaP so that more people can use our libraries. If anything we need to put back all the bounds that are currently missing.

That tells me that ledger is ignoring that constraint but what about other users?

Other users can set whatever time constraint they want and it will JustWOrk(tm). This is a vastly better solution than what we had which was setting an un-necessarily narrow constraint which could clash with upstream constraints requiring hacks like allow-newer.

Other users can set whatever time constraint they want and it will probably JustWork(tm).

It will not. The time package will have new major releases with breaking changes, which will break our code.

If we do that to all our packages we will likely end up spending 100 hours a week just maintaining version constraints in out bazillion packages.

Without constraints, it will be our users spending 100 hours a week trying to figure out what set dependencies work together. Even if we won't see it.

We should encourage the use if index-state statements in the cabal.project file.
Using index-state like this means that a new version of time cannot break anything unless index-state is changed.

We should encourage the use of index-state statements in the cabal.project file.

plutus uses index-state: 2022-09-26T00:00:00Z
ouroboros-network uses index-state: 2022-07-01T00:00:00Z
Which one should I use?
Also this means that downstream consumers will never be able to release a library, since using that new library would require bumping the index-state.
The critical information (i.e. what works with what) is in the dependency version bounds. It's not stored anywhere else (perhaps other than the mind of the release manager). Even making CHaP @michaelpj and I are pulling our hair trying to figure out the missing "what works with what" information.

Which one should I use?

The latest one that works.

Also this means that downstream consumers will never be able to release a library, since using that new library would require bumping the index-state.

They can bump and if they run into trouble with something like time they can add constraints: time < <newest-version>.
Per-project constraints in the <project>.cabal file worked reasonably well for quite some time, but IMO they have become increasing painful over time.

I think bounds is a big topic. For now I think what is uncontroversial is adding bounds that we know exclude breakage. Clearly we didn't know that the upper-bound on time was necessary, so it got ignored. The lower-bound may well be necessary. If we discover that we need an upper-bound we can put it in or revise it.
I'll start a discussion about the bigger topic elsewhere.

index-state is not part of the package description and doesn't get propagated to the consumers of the library. I had to spend a few hours trying to figure out why cardano-crypto-class wasn't compiling "anymore", where "anymore" meant someone had a different index-state. The culprit was a lacking of upper bound on vector.


endpoint: factor out duplicate code into helper function

There were two locations in which policy enforcement was set based off of the
enforcement mode of the policy repository. Factor this out into a function, and
remove functions that are now unused as a result of this refactor.
Signed-off by: Ian Vernon<EMAIL_ADDRESS>

This change is

test-me-please

test-me-please

Coverage decreased (-0.02%) to 44.133% when pulling d7adffb22fd87d69659e1e5ead47ecee69a2257b on pr/ianvernon/hide-policy-enablement-functionality into 42229305fd2e24cf6ece5e9411539341f23852ff on master.

test-me-please


Django 1.8 support

Hello there,
It saddens me that Django does not support post 1.8 versions. :(

Mezzanine supports Django 1.11 which will receive long term support until April 2020.
At the moment Mezzanine is not compatible with any supported Django 2.x version though (master branch on github can run on Django 2.0.x but support for that has ended three months ago).

See also #1934 and #1928.

Support for Django 2.2 has been added on #1956


Externalize hint_to_hint_params

This change is

Current dependencies on/for this PR:

main

PR #3127   👈

This comment was auto-generated by Graphite.


system_tests_tcp_adaptor AddressSanitizer: use-after-poison in plog_latency_start

https://github.com/jiridanek/skupper-router/runs/5976545736?check_suite_focus=true#step:26:3560
58: ==2712==ERROR: AddressSanitizer: use-after-poison on address 0x61300008d498 at pc 0x000000579789 bp 0x7f242c116800 sp 0x7f242c1167f8
58: WRITE of size 8 at 0x61300008d498 thread T4
58:     #0 0x579788 in plog_latency_start /home/runner/work/skupper-router/skupper-router/skupper-router/src/
58:     #1 0x4a2e96 in qdr_tcp_connection_egress /home/runner/work/skupper-router/skupper-router/skupper-router/src/adaptors/tcp_adaptor.c:1138
58:     #2 0x4b52f1 in qdr_tcp_deliver /home/runner/work/skupper-router/skupper-router/skupper-router/src/adaptors/tcp_adaptor.c:1671
58:     #3 0x6284c6 in qdr_link_process_deliveries /home/runner/work/skupper-router/skupper-router/skupper-router/src/router_core/transfer.c:180
58:     #4 0x59f8a1 in qdr_connection_process /home/runner/work/skupper-router/skupper-router/skupper-router/src/router_core/connections.c:407
58:     #5 0x4ab731 in on_activate /home/runner/work/skupper-router/skupper-router/skupper-router/src/adaptors/tcp_adaptor.c:201
58:     #6 0x689216 in qd_timer_visit /home/runner/work/skupper-router/skupper-router/skupper-router/src/timer.c:320
58:     #7 0x679ea6 in handle /home/runner/work/skupper-router/skupper-router/skupper-router/src/server.c:980
58:     #8 0x6817a5 in thread_run /home/runner/work/skupper-router/skupper-router/skupper-router/src/server.c:1095
58:     #9 0x7f24373e6b19 in start_thread (/lib64/libc.so.6+0x8db19)
58:     #10 0x7f243746b65f in __GI___clone3 (/lib64/libc.so.6+0x11265f)
58:
58: 0x61300008d498 is located 280 bytes inside of 320-byte region [0x61300008d380,0x61300008d4c0)
58: allocated by thread T4 here:
58:     #0 0x7f24389be4fc in __interceptor_posix_memalign (/lib64/libasan.so.6+0xaf4fc)
58:     #1 0x4bfc7d in qd_alloc /home/runner/work/skupper-router/skupper-router/skupper-router/src/alloc_pool.c:396
58:     #2 0x57673c in new_plog_record_t /home/runner/work/skupper-router/skupper-router/skupper-router/src/protocol_log.c:81
58:     #3 0x57673c in plog_start_record /home/runner/work/skupper-router/skupper-router/skupper-router/src/protocol_log.c:1136
58:     #4 0x4a2fbc in qdr_tcp_connection_egress /home/runner/work/skupper-router/skupper-router/skupper-router/src/adaptors/tcp_adaptor.c:1113
58:     #5 0x4b52f1 in qdr_tcp_deliver /home/runner/work/skupper-router/skupper-router/skupper-router/src/adaptors/tcp_adaptor.c:1671
58:     #6 0x6284c6 in qdr_link_process_deliveries /home/runner/work/skupper-router/skupper-router/skupper-router/src/router_core/transfer.c:180
58:     #7 0x59f8a1 in qdr_connection_process /home/runner/work/skupper-router/skupper-router/skupper-router/src/router_core/connections.c:407
58:     #8 0x4ab731 in on_activate /home/runner/work/skupper-router/skupper-router/skupper-router/src/adaptors/tcp_adaptor.c:201
58:     #9 0x689216 in qd_timer_visit /home/runner/work/skupper-router/skupper-router/skupper-router/src/timer.c:320
58:     #10 0x679ea6 in handle /home/runner/work/skupper-router/skupper-router/skupper-router/src/server.c:980
58:     #11 0x6817a5 in thread_run /home/runner/work/skupper-router/skupper-router/skupper-router/src/server.c:1095
58:     #12 0x7f24373e6b19 in start_thread (/lib64/libc.so.6+0x8db19)
58:
58: Thread T4 created by T0 here:
58:     #0 0x7f2438965866 in pthread_create (/lib64/libasan.so.6+0x56866)
58:     #1 0x564465 in sys_thread /home/runner/work/skupper-router/skupper-router/skupper-router/src/posix/threading.c:181
58:     #2 0x683d1c in qd_server_run /home/runner/work/skupper-router/skupper-router/skupper-router/src/server.c:1489
58:     #3 0x43325d in main_process /home/runner/work/skupper-router/skupper-router/skupper-router/router/src/main.c:105
58:     #4 0x432112 in main /home/runner/work/skupper-router/skupper-router/skupper-router/router/src/main.c:359
58:     #5 0x7f243738655f in __libc_start_call_main (/lib64/libc.so.6+0x2d55f)

This has been fixed by https://github.com/skupperproject/skupper-router/pull/291


Changed name of of apply_rf to apply_m

The 'm' is for method. This was in my code at some point, but must have gotten lost in a merge.

Thanks


Form validation callback function in helpers

Validating common things like dates submitted in a form across a large application would be easier if the callback function could leave in helpers. Currently a callback function is not recognized if stored in a helper file, but works if moved direct into the controller that does validation.

There was an off-topic discussion on #3904 related to this. You can read it to get the details, but TL;DR: a callback and a regular function are different things.


[Bitcoin] Chain stopped to advance due to invalid script in block

syncing on bitcoin testnet ... chain stopped to advance
======Connection======
Peer:::ffff:<IP_ADDRESS>:18333,        connected (outbound),      agent /Satoshi:0.15.1/,  height=1256546
Peer:::ffff:<IP_ADDRESS>:18333,          connected (outbound),      agent /Satoshi:0.14.2/,  height=1256546
Peer:::ffff:<IP_ADDRESS>:18333,       connected (outbound),      agent /Satoshi:0.15.1/,  height=1256546
Peer:::ffff:<IP_ADDRESS>:18333,        connected (outbound),      agent /Satoshi:0.14.1/,  height=1256546
Peer:::ffff:<IP_ADDRESS>:18333,         connected (outbound),      agent /Satoshi:0.13.2/,  height=1256546
Peer:::ffff:<IP_ADDRESS>:8333,          connected (outbound),      agent /Satoshi:0.15.99/[B.A.N.],  height=1256546
Peer:::ffff:<IP_ADDRESS>:18333,        connected (outbound),      agent /Satoshi:0.14.0/,  height=1256546
Peer:::ffff:<IP_ADDRESS>:18333,          connected (outbound),      agent /Satoshi:0.15.99/,  height=1256546

[2017-12-28 20:47:50.3696 30] ERROR: Stratis.Bitcoin.Features.Consensus.ConsensusLoop+<AcceptBlockAsync>d__40.MoveNext Block '000000000000049c5ed3eb8d92036e7b8270ba4c9c44850cc73218a39b7b45d8' rejected: a script failed
[2017-12-28 20:47:50.3696 30] ERROR: Stratis.Bitcoin.Features.Consensus.ConsensusLoop+<AcceptBlockAsync>d__40.MoveNext Marking block '000000000000049c5ed3eb8d92036e7b8270ba4c9c44850cc73218a39b7b45d8' as invalid.
[2017-12-28 20:47:50.8035 7] ERROR: Stratis.Bitcoin.Features.Consensus.ConsensusLoop+<AcceptBlockAsync>d__40.MoveNext Block '000000000000049c5ed3eb8d92036e7b8270ba4c9c44850cc73218a39b7b45d8' rejected: a script failed
[2017-12-28 20:47:50.8035 7] ERROR: Stratis.Bitcoin.Features.Consensus.ConsensusLoop+<AcceptBlockAsync>d__40.MoveNext Marking block '000000000000049c5ed3eb8d92036e7b8270ba4c9c44850cc73218a39b7b45d8' as invalid.
[2017-12-28 20:47:51.2400 12] INFO: Stratis.Bitcoin.FullNode.<StartPeriodicLog>b__73_0 ======Node stats====== 12/28/2017 20:47:51 agent StratisBitcoin:1.0.7
Headers.Height:      1256143  Headers.Hash:<PHONE_NUMBER>00003ccd7f23d03d49ba007f34645ca57d42f0ba0fc8496cb7f9fb
Consensus.Height:    1256143  Consensus.Hash:<PHONE_NUMBER>00003ccd7f23d03d49ba007f34645ca57d42f0ba0fc8496cb7f9fb
BlockStore.Height:   1256139  BlockStore.Hash:<PHONE_NUMBER>0004a25339c7a3f7eb4c8fddb0fafefd955b706b0b1877bedc0874
Wallet.Height:       No Wallet

@nicolasdorier might be interested in this

ha this is interesting, taking a look

this is a consensus bug of NBitcoin... will release fix soon

Ok I fixed it 7fd1c358b920fdc6c75417f9f2646f2fc0f59585 needless to say, you better need to update! This is on <IP_ADDRESS>

Thank you @nicolasdorier for the quick reaction.

I will take a look at the history... I basically copy pasted this code from C++ if I remember... this mean there might have been an unintended hardfork in the past. (maybe I copy/pasted wrong?)

it seems my bug, this code originates from satoshi apparently...


importError

Hi, it looks like I installed it successfully. But when I import, it shows 'ImportError: libc10.so: cannot open shared object file: No such file or directory' , Do you know why this happens? Thank you very much.

$ python setup.py install

running install
running bdist_egg
running egg_info
writing ctlib.egg-info/PKG-INFO
writing dependency_links to ctlib.egg-info/dependency_links.txt
writing top-level names to ctlib.egg-info/top_level.txt
/home/hrr/anaconda3/envs/pytorch/lib/python3.7/site-packages/torch/utils/cpp_extension.py:352: UserWarning: Attempted to use ninja as the BuildExtension backend but we could not find ninja.. Falling back to using the slow distutils backend.
warnings.warn(msg.format('we could not find ninja.'))
reading manifest file 'ctlib.egg-info/SOURCES.txt'
writing manifest file 'ctlib.egg-info/SOURCES.txt'
installing library code to build/bdist.linux-x86_64/egg
running install_lib
running build_ext
creating build/bdist.linux-x86_64/egg
copying build/lib.linux-x86_64-3.7/ctlib.cpython-37m-x86_64-linux-gnu.so -> build/bdist.linux-x86_64/egg
creating stub loader for ctlib.cpython-37m-x86_64-linux-gnu.so
byte-compiling build/bdist.linux-x86_64/egg/ctlib.py to ctlib.cpython-37.pyc
creating build/bdist.linux-x86_64/egg/EGG-INFO
copying ctlib.egg-info/PKG-INFO -> build/bdist.linux-x86_64/egg/EGG-INFO
copying ctlib.egg-info/SOURCES.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
copying ctlib.egg-info/dependency_links.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
copying ctlib.egg-info/top_level.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
writing build/bdist.linux-x86_64/egg/EGG-INFO/native_libs.txt
zip_safe flag not set; analyzing archive contents...
pycache.ctlib.cpython-37: module references file
creating 'dist/ctlib-0.2.0-py3.7-linux-x86_64.egg' and adding 'build/bdist.linux-x86_64/egg' to it
removing 'build/bdist.linux-x86_64/egg' (and everything under it)
Processing ctlib-0.2.0-py3.7-linux-x86_64.egg
removing '/home/hrr/anaconda3/envs/pytorch/lib/python3.7/site-packages/ctlib-0.2.0-py3.7-linux-x86_64.egg' (and everything under it)
creating /home/hrr/anaconda3/envs/pytorch/lib/python3.7/site-packages/ctlib-0.2.0-py3.7-linux-x86_64.egg
Extracting ctlib-0.2.0-py3.7-linux-x86_64.egg to /home/hrr/anaconda3/envs/pytorch/lib/python3.7/site-packages
ctlib 0.2.0 is already the active version in easy-install.pth

Installed /home/hrr/anaconda3/envs/pytorch/lib/python3.7/site-packages/ctlib-0.2.0-py3.7-linux-x86_64.egg
Processing dependencies for ctlib==0.2.0
Finished processing dependencies for ctlib==0.2.0

(pytorch) hrr@hzhp-Z10PE-D8-WS:~/Proj/ctlib$ python
Python 3.7.6 (default, Jan  8 2020, 19:59:22)
[GCC 7.3.0] :: Anaconda, Inc. on linux
Type "help", "copyright", "credits" or "license" for more information.

import ctlib
Traceback (most recent call last):
File "", line 1, in
ImportError: libc10.so: cannot open shared object file: No such file or directory`

Hi,
Before import ctlib, import torch first
Best Regards
Wenjun
Rui Hu @.***> 于2022年6月13日周一 11:04写道：

Hi, it looks like I installed it successfully. But when I import, it shows
'ImportError: libc10.so: cannot open shared object file: No such file or
directory , Do you know why this happens? Thank you very much.
$ python setup.py install
running install
running bdist_egg
running egg_info
writing ctlib.egg-info/PKG-INFO
writing dependency_links to ctlib.egg-info/dependency_links.txt
writing top-level names to ctlib.egg-info/top_level.txt
/home/hrr/anaconda3/envs/pytorch/lib/python3.7/site-packages/torch/utils/cpp_extension.py:352:
UserWarning: Attempted to use ninja as the BuildExtension backend but we
could not find ninja.. Falling back to using the slow distutils backend.
warnings.warn(msg.format('we could not find ninja.'))
reading manifest file 'ctlib.egg-info/SOURCES.txt'
writing manifest file 'ctlib.egg-info/SOURCES.txt'
installing library code to build/bdist.linux-x86_64/egg
running install_lib
running build_ext
creating build/bdist.linux-x86_64/egg
copying build/lib.linux-x86_64-3.7/ctlib.cpython-37m-x86_64-linux-gnu.so
-> build/bdist.linux-x86_64/egg
creating stub loader for ctlib.cpython-37m-x86_64-linux-gnu.so
byte-compiling build/bdist.linux-x86_64/egg/ctlib.py to
ctlib.cpython-37.pyc
creating build/bdist.linux-x86_64/egg/EGG-INFO
copying ctlib.egg-info/PKG-INFO -> build/bdist.linux-x86_64/egg/EGG-INFO
copying ctlib.egg-info/SOURCES.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
copying ctlib.egg-info/dependency_links.txt ->
build/bdist.linux-x86_64/egg/EGG-INFO
copying ctlib.egg-info/top_level.txt ->
build/bdist.linux-x86_64/egg/EGG-INFO
writing build/bdist.linux-x86_64/egg/EGG-INFO/native_libs.txt
zip_safe flag not set; analyzing archive contents...
pycache.ctlib.cpython-37: module references file
creating 'dist/ctlib-0.2.0-py3.7-linux-x86_64.egg' and adding
'build/bdist.linux-x86_64/egg' to it
removing 'build/bdist.linux-x86_64/egg' (and everything under it)
Processing ctlib-0.2.0-py3.7-linux-x86_64.egg
removing
'/home/hrr/anaconda3/envs/pytorch/lib/python3.7/site-packages/ctlib-0.2.0-py3.7-linux-x86_64.egg'
(and everything under it)
creating
/home/hrr/anaconda3/envs/pytorch/lib/python3.7/site-packages/ctlib-0.2.0-py3.7-linux-x86_64.egg
Extracting ctlib-0.2.0-py3.7-linux-x86_64.egg to
/home/hrr/anaconda3/envs/pytorch/lib/python3.7/site-packages
ctlib 0.2.0 is already the active version in easy-install.pth
Installed
/home/hrr/anaconda3/envs/pytorch/lib/python3.7/site-packages/ctlib-0.2.0-py3.7-linux-x86_64.egg
Processing dependencies for ctlib==0.2.0
Finished processing dependencies for ctlib==0.2.0
(pytorch) @.***:~/Proj/ctlib$ python
Python 3.7.6 (default, Jan 8 2020, 19:59:22)
[GCC 7.3.0] :: Anaconda, Inc. on linux
Type "help", "copyright", "credits" or "license" for more information.
import ctlib
Traceback (most recent call last):
File "", line 1, in
ImportError: libc10.so: cannot open shared object file: No such file or
directory`
—
Reply to this email directly, view it on GitHub
https://github.com/xwj01/CTLIB/issues/5, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJRVWQK3MP76KYFPW5LDBQDVO2QNJANCNFSM5YSYAYQQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hi Wenjun,
it works, thanks very much
Best
Rui

Hi Wenjun,
it works, thanks very much
Best Rui

Hi ! I meet some errors. Can you give a simple example ? Thank you very much .

Please see this repository https://github.com/Deep-Imaging-Group/Physics-Model-Data-Driven-Review
Best,
Wenjun
From: ZeliangM @.>
Sent: Monday, September 19, 2022 08:26
To: xwj01/CTLIB @.>
Cc: xwj01 @.>; Comment @.>
Subject: Re: [xwj01/CTLIB] importError (Issue #5)
Hi Wenjun,
it works, thanks very much
Best Rui
Hi ! I meet some errors. Can you give a simple example ? Thank you very much .
—
Reply to this email directly, view it on GitHub https://github.com/xwj01/CTLIB/issues/5#issuecomment-1250952166 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AJRVWQJVJSCIJERPGC5WXHLV7BLXJANCNFSM5YSYAYQQ .
You are receiving this because you commented.  https://github.com/notifications/beacon/AJRVWQP3VPCYJUXV4XBWRODV7BLXJA5CNFSM5YSYAYQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJKIAHZQ.gif Message ID: @.*** @.***> >

Please see this repository https://github.com/Deep-Imaging-Group/Physics-Model-Data-Driven-Review Best, Wenjun From: ZeliangM @.> Sent: Monday, September 19, 2022 08:26 To: xwj01/CTLIB @.> Cc: xwj01 @.>; Comment @.> Subject: Re: [xwj01/CTLIB] importError (Issue #5) Hi Wenjun, it works, thanks very much Best Rui Hi ! I meet some errors. Can you give a simple example ? Thank you very much . — Reply to this email directly, view it on GitHub <#5 (comment)> , or unsubscribe https://github.com/notifications/unsubscribe-auth/AJRVWQJVJSCIJERPGC5WXHLV7BLXJANCNFSM5YSYAYQQ . You are receiving this because you commented. https://github.com/notifications/beacon/AJRVWQP3VPCYJUXV4XBWRODV7BLXJA5CNFSM5YSYAYQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJKIAHZQ.gif Message ID: @.*** @.***> >

Thanks for your reply ！
Although I have solved my error , your reply is meaningful for me. I am interested in your work  , thanks for your recommendation.
Best Regards

You are welcome. Wenjun
From: ZeliangM @.>
Sent: Monday, September 19, 2022 23:56
To: xwj01/CTLIB @.>
Cc: xwj01 @.>; Comment @.>
Subject: Re: [xwj01/CTLIB] importError (Issue #5)
Please see this repository https://github.com/Deep-Imaging-Group/Physics-Model-Data-Driven-Review Best, Wenjun From: ZeliangM @.> Sent: Monday, September 19, 2022 08:26 To: xwj01/CTLIB @.> Cc: xwj01 @.>; Comment @.> Subject: Re: [xwj01/CTLIB] importError (Issue #5 https://github.com/xwj01/CTLIB/issues/5 ) Hi Wenjun, it works, thanks very much Best Rui Hi ! I meet some errors. Can you give a simple example ? Thank you very much . — Reply to this email directly, view it on GitHub <#5 (comment) https://github.com/xwj01/CTLIB/issues/5#issuecomment-1250952166 > , or unsubscribe https://github.com/notifications/unsubscribe-auth/AJRVWQJVJSCIJERPGC5WXHLV7BLXJANCNFSM5YSYAYQQ . You are receiving this because you commented. https://github.com/notifications/beacon/AJRVWQP3VPCYJUXV4XBWRODV7BLXJA5CNFSM5YSYAYQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJKIAHZQ.gif Message ID: @.*** @.***> >
Thanks for your reply ！
Although I have solved my error , your reply is meaningful for me. I am interested in your work , thanks for your recommendation.
Best Regards
—
Reply to this email directly, view it on GitHub https://github.com/xwj01/CTLIB/issues/5#issuecomment-1251804423 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AJRVWQK2U66DIU2FNGX25Z3V7EYV3ANCNFSM5YSYAYQQ .
You are receiving this because you commented.  https://github.com/notifications/beacon/AJRVWQO2UQ7OXOK322HOIATV7EYV3A5CNFSM5YSYAYQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJKOQKBY.gif Message ID: @.*** @.***> >


Move trends plots inside of "Custom" section

1/3 main <= this <= #3466 <= #3491
Demo
https://user-images.githubusercontent.com/43496356/224517013-fbc554e8-8c81-43c6-91b2-d8b5412e960c.mov
Part of #3373

@julieg18 @sroy3
Moving between having a custom checkpoint trend plot in the custom section on this branch and main caused plots to be completely broken for me until I ran Reset Persisted State and Reload Window... beware, I thought this was a P0.

Not sure if it's just because my demo project was not properly set up when I opened the branch, but I can only see custom plots when there is an experiment running and all plots look the same.
https://user-images.githubusercontent.com/3683420/224716434-381248ff-d1ac-439f-9b46-76721911d7a5.mov

Not sure if it's just because my demo project was not properly set up when I opened the branch, but I can only see custom plots when there is an experiment running and all plots look the same.

@sroy3, I'm a little confused by your statement since looking at your demo, I see the custom plots the entire time... What am I misunderstanding?
I do notice that the trends plots don't seem to be live updating but I think that is due to the running experiment not getting selected to the very end... Looks like that happens on main as well on my end.

Not sure if it's just because my demo project was not properly set up when I opened the branch, but I can only see custom plots when there is an experiment running and all plots look the same.

@sroy3, I'm a little confused by your statement since looking at your demo, I see the custom plots the entire time... What am I misunderstanding?

They are there, but they are empty. No matter what metric or param I choose, all plots are the same inside.

Ok, thanks for the reviews everyone! I've resolved most of the comments.
What's left:

[ ] Delete old Persistance metrics state (https://github.com/iterative/vscode-dvc/pull/3404#discussion_r1133350817)
[ ] Adjust custom plots order state (https://github.com/iterative/vscode-dvc/pull/3404#discussion_r1133350999)
[ ] Investigate test (https://github.com/iterative/vscode-dvc/pull/3404#discussion_r1133370484)
[ ] Simplify metric and param path logic (https://github.com/iterative/vscode-dvc/pull/3404#discussion_r1133905101)

They are there, but they are empty. No matter what metric or param I choose, all plots are the same inside.

Weird, things look correct on my end:
https://user-images.githubusercontent.com/43496356/224848463-0cf9f71f-2888-4527-880b-dc62e8e609cb.mov
@mattseddon, are the plots rendering correctly for you?

They are there, but they are empty. No matter what metric or param I choose, all plots are the same inside.

Weird, things look correct on my end:
@mattseddon, are the plots rendering correctly for you?

From the original screenshot:

They aren't empty. I think they just contain the same data for each of the experiments. Try updating params before running experiments?
Changing LR:

I am ok to merge this if the checkboxes directly above get addressed before the merge. The checkboxes below need to be added to the issue and the issue should remain open/get worked on until they are all finished.

Resolved the checkboxes above (one ended up getting merged in a secondary pr). I'll look over the code one final time tomorrow morning and, if there are no objections, merge this pr.

https://github.com/iterative/vscode-dvc/pull/3404#discussion_r1135538551 has been resolved with #3466 and #3491 (both approved and ready to be merged into this pr)!
Here's a (hopefully complete) list of what's left:

[ ] Delete old Persistance metrics state (https://github.com/iterative/vscode-dvc/pull/3404#discussion_r1133350817)
[ ] Adjust custom plots order state (https://github.com/iterative/vscode-dvc/pull/3404#discussion_r1133350999)
[ ] Investigate test (https://github.com/iterative/vscode-dvc/pull/3404#discussion_r1133370484)
[ ] Update walkthrough images after other PRs are merged (https://github.com/iterative/vscode-dvc/pull/3404/files#r1133343393)
[ ] Check if spec creation can be moved to extension (https://github.com/iterative/vscode-dvc/pull/3404#discussion_r1134686640)
[ ] Consolidate type checking to the smallest space/amount of functions (https://github.com/iterative/vscode-dvc/pull/3404#discussion_r1134686640) (Most of this has been done already but more to do)
[ ] Add code to add 1 trend and 1 metric vs param custom plot to e2e test (https://github.com/iterative/vscode-dvc/pull/3404/files#r1133364032)

Anything else that should get taken care of before we merge this? Or did I miss anything when I took care of merge conflicts?

I think you used to have something that blocked the following from happening before:
Could be easy to just show the available choice from the list. (Can be a follow-up)

Thanks for spotting that! Simple bug in the quick pick logic/tests that I missed earlier. Will fix it before merging since I'd prefer to keep users' custom plot state to not have copies of the same plot in it :) Will keep current logic for now and save choosing available choices for a followup.

Code climate seems to be failing with
ERROR: Coverage for lines (94.9%) does not meet global threshold (95%)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
ERROR: "cover:report" exited with 1.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: The process '/usr/bin/xvfb-run' failed with exit code 1
/home/runner/work/_actions/paambaati/codeclimate-action/v3.2.0/node_modules/@actions/exec/lib/toolrunner.js:592
                error = new Error(`The process '${this.toolPath}' failed with exit code ${this.processExitCode}`);
                        ^

Error: The process '/usr/bin/xvfb-run' failed with exit code 1
    at ExecState._setResult (/home/runner/work/_actions/paambaati/codeclimate-action/v3.2.0/node_modules/@actions/exec/lib/toolrunner.js:592:25)
    at ExecState.CheckComplete (/home/runner/work/_actions/paambaati/codeclimate-action/v3.2.0/node_modules/@actions/exec/lib/toolrunner.js:575:18)
    at ChildProcess.<anonymous> (/home/runner/work/_actions/paambaati/codeclimate-action/v3.2.0/node_modules/@actions/exec/lib/toolrunner.js:469:27)
    at ChildProcess.emit (node:events:527:28)
    at maybeClose (node:internal/child_process:1092:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5)
Error: 🚨 Coverage run failed!

First guess is the issue is amount of lines being covered:
ERROR: Coverage for lines (94.9%) does not meet global threshold (95%)

Will see if upping the code coverage fixes the issue!

Updated the tests based of code reviews and looking over things myself:

fixed pickMetric not being 100% covered
added tests for addCustomPlot and removeCustomPlot ending early due to user not selecting things
added additional tests for functions in custom.test.ts that appeared to be missing coverage

But code coverage is still failing:
ERROR: Coverage for lines (94.96%) does not meet global threshold (95%)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
ERROR: "cover:report" exited with 1.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
/home/runner/work/_actions/paambaati/codeclimate-action/v3.2.0/node_modules/@actions/exec/lib/toolrunner.js:592
Error: The process '/usr/bin/xvfb-run' failed with exit code 1
                error = new Error(`The process '${this.toolPath}' failed with exit code ${this.processExitCode}`);
                        ^
Error: The process '/usr/bin/xvfb-run' failed with exit code 1
    at ExecState._setResult (/home/runner/work/_actions/paambaati/codeclimate-action/v3.2.0/node_modules/@actions/exec/lib/toolrunner.js:592:25)
    at ExecState.CheckComplete (/home/runner/work/_actions/paambaati/codeclimate-action/v3.2.0/node_modules/@actions/exec/lib/toolrunner.js:575:18)
    at ChildProcess.<anonymous> (/home/runner/work/_actions/paambaati/codeclimate-action/v3.2.0/node_modules/@actions/exec/lib/toolrunner.js:469:27)
    at ChildProcess.emit (node:events:527:28)
    at maybeClose (node:internal/child_process:1092:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5)
Error: 🚨 Coverage run failed!

Last things I'm seeing regarding testing is:

[ ] Add tests for lines like this in collect.test.ts: exp.name || exp.label
[ ] Add tests for when user recreates the same custom plot

I'll start working on the followup on stopping a user from recreating custom plots since I think it will take about the same time as just creating tests for our current solution. But is there something else that could be going on with CodeClimate that I'm missing? cc @sroy3, @mattseddon


how to install?

im new and have no idea how to install. could someone please write a thorough tutorial? line by line?
cd ~/MagicMirror/modules
git clone https://github.com/Txukie/MMM-LCDControl.git
then what?
do i have to install MMM-TelegramBot and MMM-Assistant ?  i just want the PIR to turn lcd on/off. i dont need anything else. thanks!

im new and have no idea how to install. could someone please write a thorough tutorial? line by line?
cd ~/MagicMirror/modules
git clone https://github.com/Txukie/MMM-LCDControl.git
then what?
do i have to install MMM-TelegramBot and MMM-Assistant ? i just want the PIR to turn lcd on/off. i dont need anything else. thanks!

hi tung. I want to do exactly the same. Did you get anywhere?

https://forum.magicmirror.builders/topic/4231/how-to-add-modules-for-absolute-beginners


fixed : #1515

Pull Request Type
What kind of change does this PR introduce?
[ ] Solved an issue/task
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
What is the current behavior?

Issue Number: #1515
What is the new behavior?
fibonacci serieis from 1 up to 10

its my first contibution if i do some wrong then please guid me 😊

its my first contibution if i do some wrong then please guid me 😊

Everything looks good!

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out our forkcommitmerge.io website repository. The repository contain real issues that you can help to resolve or create some of your own if you see any bugs or want to add new features to the site, etc. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


UnknownZodTypeError mongo ObjectId

When generating the document, I'm receiving an UnknownZodTypeError.
import { extendZodWithOpenApi } from '@asteasolutions/zod-to-openapi';
import { ObjectId } from 'mongoist';
import { z } from 'zod';

extendZodWithOpenApi(z);

const Schema = z.object({
  _id: z.string().or(z.instanceof(mongoist.ObjectId).openapi({example: "test"})).nullable(),
});

Not sure what I'm missing here. In the documentation it says that I can provide a type via the .openapi but not sure what it means.
Thanks in advance.

@adborroto yes, z.instanceof is not supported. Not sure that rhere is anything we can do about it either. Will check. The way to provide an OpenApi type is to do z.instanceof(mongoist.ObjectId).openapi({ type: <your-type-here> }).
Basically the .openapi method allows you to provide any OpenApi specific information - type/examples/patterns etc.
I am not familiar with mongois.ObjectId but it sounds like it is a type: 'string'.
Please, let me know if that helps.

tl;dr - we don't have a mapping to represent every possible type in Javascript -> openapi.
In this case you have amongoist.ObjectId (class/object?) but there's no way for us to know what datatype to assign to that field so you have to tell us what type you want in your doc.


Display messageStoreSender messagelog in gui

Closes #2659

The DummyMessageLog can now be deprecated as the GUI displays the log automatically
Related: https://github.com/ibissource/frank-doc/issues/61

Will be improved further with #3031


Added a shift admin button

Added a shift admin button on the frontend shift admin page.
Closes #23

Nice! I would only rephrase it to something like “go to more detailed settings” with a settings icon

Should I also implement a button on the Django admin side to switch to the frontend admin side? If so, the easiest way is at the bottom but that might be weird as the save buttons are there, what do you think @JobDoesburg?

Yeah, that is also an issue that’s open. The native way would be to place it in the object tools. There is some way to do this nicely in django by specifying some field I know but not sure how. Concrexit has it for events


How to show current compiler after file type or at the end of the airline?

Please describe exactly what your problem is and how it is reproducible. Also state what terminal you use.

Sorry, not actual anymore.


Unknown database, mysql database and user does not exist...?

Info:

Docker version ($ docker --version): Docker version 17.03.1-ce, build c6d412e
Laradock commit ($ git rev-parse HEAD): ab464d93d3bfe0808257dbece36c18e3474d761f
System info (Mac, PC, Linux): Mac
System info disto/version: macOS Sierra

Issue:
What seems to be going wrong?
It seems like there is no database nor user created for the mysql server.
The server is up and running but there are no database called "homestead" or what ever i add in my .env

Expected behavior:
What should be happening instead?
A database and a user should be created

Reproduce:
How might we be able to reproduce the error?
I follow basic getting started instrucitons, add laradock as an git submodule.
I run: docker-compose up -d nginx mysql

Relevant Code:
Laravel .env (changed DB_HOST to mysql
DB_CONNECTION=mysql
DB_HOST=mysql
DB_PORT=3306
DB_DATABASE=homestead
DB_USERNAME=homestead
DB_PASSWORD=secret

Laradock .env (default)
MYSQL_DATABASE=default
MYSQL_USER=default
MYSQL_PASSWORD=secret
MYSQL_PORT=3306
MYSQL_ROOT_PASSWORD=root

Can you post your Docker logs from the MySQL container?

I'm noticing that i can change this ONLY on the first run. Subsequent builds/runs fail to update with these new values, and retain the first run (regardless of removing volumes, containers, images).

@ItaloBC @iredmedia I am having the same problem, it seems that one of the commits removed all the ENV commands from the mysql Dockerfile:
8820501644bdfd7b763ce135b6381590cc7ea212

The issue in my case is that CHANGING after FIRST run, the DB still exists on the host OS and isn't modified as per #1028. Need to manually change info, or delete ~/.laradock/data/[mysql/postgres] etc.
in the .env file
### Data Path:
# For all storage systems.
DATA_SAVE_PATH=~/.laradock/data


0.6.0rc1 doesn't seem to actually be published to PyPi

According to the docs, 0.6.0rc1 is published to PyPi:

This README is about the soon-to-be released magika 0.6.0 (currently published as 0.6.0rc1 on pypi) …

But I don't see it listed: https://pypi.org/project/magika/#history
And running the documented pip install command doesn't work:
$ pip install magika==0.6.0rc1

Thanks for reporting! We were about to push the rc but we hit some unexpected issues with manylinux (see #752). We are closed to solve the problems, but in the meantime I've updated the README to reflect that the rc is not there yet.

Got it thanks!


Added a translateable Linux AppData file

This will get you listed in Linux app stores. Compare https://people.freedesktop.org/~hughsient/appdata/

I guess you somehow need to "initialize" it or the translation to get some output.


MH-10560 Live Scheduler Service

This service creates/updates a LIVE media package in the search index so that a student can watch a lecture while it's happening.
The service listens to Scheduler / Asset Manager messages and updates the live media package accordingly.
The admin UI shows the Engage Live publication channel and allows launching the player while the capture is happening.
The capture agent used needs to be capable of streaming and the player needs to be capable of playing the format streamed.
Harvard DCE has been using the 1.x version of this code for years. We use Epiphan Pearls streaming rtmp and Paella (rtmp support via Flash). We haven't tested it with other capture agents, streaming formats, or players. Suggestions are welcome!
UI changes:
When event is scheduled and before start time, playing is disabled:

While event is being captured, player can be launched:

And in the Media Module:

Hello Rute,
we're (WWU Münster) very interested in this feature. At a first glance I couldn't find any documentation on what the capture agent needs to implement to support this feature, i.e. some API documentation and workflow explanation. Can you point me to the information, or maybe add this to the PR?
Regards,
Jan

Hi Jan,
This feature can only be used if the capture agent is already capable of streaming and the CA configuration will be different for each one. The idea is that the capture agent will stream to a server and the LiveSchedulerService will be configured to use the same url in the tracks. You also need to use  the Paella player. Which capture agent do you currently use?
Thanks,
Rute

Hello @rute-santos, yes, that's obvious, but I am specifically interested in which API the capture agent needs to implement, so I can add this feature to pyCA, or develop a stand alone program for this.
Just wanted to ask if there is any documentation about this at all, or people wanting to implement this have to read the entire code and figure it out for themselves (possibly missing intended behaviour).
Regards

Hi @JanKoppe,
The capture agent doesn't need to implement a specific api if the service is configured with the same url as the capture agent streams to.
But evidently this is not ideal because the configuration in both places need to match and all capture agents need to follow the same pattern so here at Harvard-DCE our capture agents pass the streaming urls when they register to Opencast and the LIveSchedulerService uses those urls when building the live tracks.
I've just added that to the documentation. Please refer to docs/guides/admin/docs/modules/liveschedule.md and make suggestions for improvements.
I also hope you don't need to read the code! :)
Thanks for your comments!
Rute

Ah, I think that clears it up a bit - I was thinking that the livestreaming is handled over a new API endpoint, but instead it extends the existing recording calendars endpoint.
Will take a look if we can extend pyCA to include this (would need to parse the attachments which we don't do yet), but one could just go ahead and push the stream every time a recording starts, but Opencast would only publish the event to engage when it actually has been marked with "publishLive", correct?
Lookin forward to playing with this, thank you! 👍

I'm not seeing anything show up under Publications in the event popup dialog under General before or during the live event.
The publications column is correct in the events table, and it shows the correct status before and during the live event.

Hi @smarquard, the activemq configuration was changed by this PR. Do you updated your activemq config and restarted the service? Sorry for the question, just to be sure.

@rute-santos, were you able to reproduce the issue in the Admin UI not showing the publication in the event popup modal?

Hi @smarquard, I was on vacation last week and I will take a look this week.

Hi @smarquard, I've fixed the bug. Thanks!

Fixed the code that got broken because of PR #43. This was tested with PR #103 and PR #129 applied so it may not work without them.

Hi @smarquard, Just checking: is this going to be merged into the new release or do I have to do anything else? Thanks!

@rute-santos, I will give it another test now and certainly hope to merge before feature freeze.
Could you look through the comments from a while back which I added, specifically some wording changes suggested for documentation. Also a couple of code comments.

@smarquard, I cannot find the comments you mentioned.

Sorry, it seems github kept them all as pending until I submitted a complete review which I've done now. I didn't realize that made them invisible to anyone else.

Hi @smarquard,
I am glad I am not crazy :)
I believe I addressed all your comments now. Please let me know if other changes are needed and thank you so much for reviewing!
Rute

After testing the latest build:

The mediapackage is published as expected to the media module on scheduling
In the media module, the event shows up as "Live (in progress)" before the scheduled start date. Not sure why, as the code looks ok to me. Maybe something wrong with the date calculations or comparison.
When the event ends, the event is retracted from the media module as expected.
Nothing is showing up in the Admin UI related to the live event, i.e. it's not shown with a live publication at all either in the events table or in the event popup under Publications.

All of these events are coming up, but some are shown as in progress and one not.
Also in the Admin UI, the publication status for a forthcoming live event shows up if you edit the metadata after the initial creation, but not otherwise.

Hi @smarquard, I think the publication is not showing up because PR #129 is missing. I made a comment that it was needed, but it got lost among all the other comments. I will include it with this PR and make sure all works.

Hi @smarquard,
I addressed everything, except the media module issue. The issue is happening because, when the event is scheduled, the media package 'start' field is set to the creation date/time and not the capture start date/time. The live scheduler service gets the media package from the asset manager, which has the incorrect 'start' date/time. I don't know if I will be able to fix that before the release cut date, but I can provide a bug fix after that if you decide to merge.
Thanks!

Thanks @rute-santos
github is reporting a conflict in AbstractAssetManager.java; can you resolve that?

I've merged the current develop and resolved the conflict.

Merged - thank you for the contribution!
Please create a follow-up JIRA and PR for the issue in the media module where the mediapackage start date is incorrect: appears to be the creation date/time of the item, and should be the capture start date/time which I assume could differ from dcCreated as the 'descriptive' start date/time. The live stream should follow the schedule start/date time.
Please also look at the behaviour when rebuilding the Admin UI index; it looks like the live schedule service is trying to do something for past live scheduled events when a reindex event is received.


[Proposal] Include way to handle 404 pages

Not sure if I'm just overlooking the section in the documentation or through my trials through the code, but would be cool to handle missing pages with a 404.blade.php file or something when those errors occur.
Was thinking along the lines of how Laravel uses the errors folder for those views, though not entirely certain how to implement it yet at this point.

Hey David! I wish this was that easy, but since it's a static site it has to be handled at the webserver level. If you use GitHub Pages, you can just create a 404.html file in your root and it will work automatically, otherwise have to configure it in the webserver, and point whatever errors you want to whatever error pages 👍

Duh. Was way over thinking this one. Thanks!

Hi i tried ot crate a 404.html in the source folder, but it is not copy over during the build process. Any idea on how to copy this file ?
thanks

I think that's probably an issue of pretty URLs being enabled by default so your file is ending up at /build_github/404/index.html
Might be a way to disable that per page if you're clever 🤔

@chrisvidal Make sure that .copy line in your gulpfile falls after the .exec line, or else the file that gulp just copied will get deleted at the .exec step. Otherwise, using .copy as you have it should work.
One thing you might change is to append a _ before the filename in source, if you don't need end up with a 404/index.html file in build_github:
.copy( elixir.config.publicPath + '/_404.html', 'build_github/404.html')

thank @damiani
yes I did this, but the file is not copied neither

Another way you can do it, if you have pretty URLs enabled, is to name your source file 404.html.blade.php. Jigsaw will process it as a normal Blade file (allowing you to use a parent template, for example, just like with any Jigsaw file) and output it to build_github/404.html/index.html, which will be accessible in the browser at 404.html.

Another way you can do it, if you have pretty URLs enabled, is to name your source file 404.html.blade.php. Jigsaw will process it as a normal Blade file (allowing you to use a parent template, for example, just like with any Jigsaw file) and output it to build_github/404.html/index.html, which will be accessible in the browser at 404.html.

Interesting idea, I am using github pages, let's see if it can support this


[FER] docs: Switch from 'breathe' to 'docleaf' for API documentation generation

Is your enhancement proposal related to a problem? Please describe.
Following the Zephyr upstream PR zephyrproject-rtos/zephyr#59570 and switches the Bridle documentation from using Breathe to using Docleaf for generating API documentation from Doxygen XML output. For more details, see the referred Zephyr upstream PR above.
Describe the solution you'd like
The switch should be done in two separated steps:

Stay on Breath for the time being. Extend Bridle's Python requirements for documentation with the latest Breath version that Zephyr has used.
Switch from Breath to Docleaf in same way as Zephyr has done.

Describe alternatives you've considered
Non.
Additional context
Non.

We don't do that.
With zephyrproject-rtos/zephyr#61339 Zephyr rolls back to Breathe because of license issues with Docleaf. For more details see: zephyrproject-rtos/zephyr#61284


CORGI-857 cpe per component

I did this hoping that it would help with CORGI-602 but unfortunately I didn't help. However this does extend the work we did in CORGI-872 to work with streams which don't use errata_info to define which builds make them up.

@RedHatProductSecurity/corgi-devs please review

I'm not sure I understand the change, it seems incomplete. Right now we only report CPEs for root components, but I thought in the ticket we wanted to report CPEs for all components.
If that's correct, you can just add the {% for cpe in component.cpes %} logic to the externalRefs key for provided and upstream components as well. Right now this for-loop only exists for root components. This should be enough to start reporting CPEs for all components, changes to the Component model's "cpes" property shouldn't be needed.
Your changes to the "cpes" property will mostly work fine I think, but I'm not sure what edge-case you're trying to handle. I say "mostly" because self.software_build is only set for root components, and again I thought we were trying to report CPEs for all components.

You misunderstood the modivation for this change. The change to assist in determining which CPE a root component relates to when there are no linked ProductVariants for the component, for example, for openshift-4.x streams which use brew_tag relations to determine which builds make up the product.

CORGI-857 is fixed by the changes merged in PR#723, verified in: PR#732


Update ingest-data-no-code.md

Fixes #25083

@Potapy4 : Thanks for your contribution! The author, @orspod, has been notified to review your proposed change.

#sign-off

@Potapy4 Thank you for this correction! I'm merging now.


[TUBEMQ-121] Modify the maven jdk compilation version

Modify the maven jdk compilation version to solve the syntax error during development and compilation
Add maven jdk compilation version comment

Thanks @viviel


make table scrollable and fixed height

Small GUI change with big effect on huge tables.
Tables from https://github.com/gnosis/safe-react-components do not support sticky headers yet. I might open a PR there some time beause Material-UI supports those already and is used there.
So I hacked the CSS for now to make em sticky, fixed height and scrollable.

I'm cool with this if it is better than before. Although I have not tried it out personally.

Here is a tiny gif showing the improved behavior I think its much much better for big transactions as the submit button is always visible.

My only suggestion at this point would be to show at least 10 or maybe even 20 records by default with the static height of the box.

My only suggestion at this point would be to show at least 10 or maybe even 20 records by default with the static height of the box. So that many of the "smallish" use cases wouldn't need the scrolling.

done.


TEMPLATES.md: add number of stars of each template

What do you think about putting a badge like  next to each template in the TEMPLATES file?
![GitHub Repo stars](https://img.shields.io/github/stars/rust-github/template?style=social)

In this way the reader can have additional info about the templates without opening all of them.

A nice idea.
But it might be that we want to favor the suggestion of in #405 to lower the entry barrier to provide templates.
Then the question is if this improvement still is worth the effort.

I'd say #405 makes this issue irrelevant.
No we can just locate templates on github.

Agree!


Add a new post in the Octant blog

What this PR does / why we need it:
Content creation to provide more context to new features
Which issue(s) this PR fixes
N/A

Fixes #

Special notes for your reviewer:
Not sure if the order of the steps is right because i had to run a git pull to be able to push. Hope the end result is not that the blog content remains the same. Feel free to correct me please
Release note:
release-note

In order to fix the multiple old commits issue, i'm re forking the repo, add the new content there and sent a -hopefully- clean new PR then


Updated Terms.yml

Updated term swapping suggestions in Terms.yml. Removed and updated tokens that are duplicated, unclear, or not meaningful. For details please see changed files.
Fixes #48

One of the removed swapping suggestion is bps (basis points). I don't think it makes sense to suggest against the use of the shorthand form bps.

Please cite the style guide for removals or additions -- it's not about what you or I deem meaningful.
For example, the guide explicitly states to not use "alphanumerical" which you've removed.

the guide explicitly states to not use "alphanumerical" which you've removed.

First of all, I believe the following means to swap A for B?
swap:
    A:B

If that's true, the previous rule around alphanumerical was:
swap:
    alphanumerical: alphanumeric

which means to use alphanumerical over alphanumeric, the exact opposite of what it supposed to be?

Thanks for the resource. Weirdly interesting to learn that Drive C is recommended over C Drive...
I went through the relevant docs for my changes.

For artificial intelligence: AI:

To refer to the technology itself, use AI for all audiences and in most content, including blogs, websites, and email. Don't spell out artificial intelligence. "

https://learn.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/term-collections/ai-bot-terms

For '(?:assembler|machine language)': assembly language:

https://learn.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/a/assembly-language

For bps and bpp:

Didn't find any doc supporting if they should be in other forms. Did not even find what bpp stands for.

Also, any recommended way to add a link (or with any other way) to let new users know term rules here are defined based off the microsoft style guide a-z word lists?
I see reference could be provided using link:, such as
link: https://learn.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/a/adapter
Perhaps we can add something like this with a comment saying rules for other terms could be found in the same guide?

Also, any recommended way to add a link (or with any other way) to let new users know term rules here are defined based off the microsoft style guide a-z word lists?
I see reference could be provided using link:, such as link: https://learn.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/a/adapter
Perhaps we can add something like this with a comment saying rules for other terms could be found in the same guide?

👍

Looks good. Thanks!


Crash with snapshot

Not sure if this is the correct place for this as it's a snapshot issue, but I thought I'd share anyway.
Currently when I try to draw more than one icon to a surface, I'm getting a crash relating to buffer elements in openGL. This only occurs when syncing, I can create as many icons as I like, it's only after syncing that I get the full exit crash.
I know you've been doing a lot of work around these recently so thought you may want to be aware.
Obligatory crash log: http://pastebin.com/kyRr5Tws

Fixed in 1a97a3d7538547f8d2f0fa1bd6650c5be50c75f7


Made whole Website a single Page Application.. No Reloading on click of links.

Description
PR Title: Making this website a single page application.. No Reloading of website on click of links
I have made a fully optimized React Application which doesn't reload on click of NavLinks.
This PR fixes #

Made whole application in React.
Made this application a single page (No reloading on click of Links)

Notes for Reviewers

Hi @pjoshi999 , we are thankful for your effort.  There are few conflicts in your commit through which we won't be able to merge. Can you pls resolve it ..


Move firebase keys from json to config file

Description
LEARNER-7585

Move google-services.json content to configs.
Generate google-services.json file using the configs at build time at the time of build before the keys validation task firebase.

Following flags are used to create the google-services.json
PROJECT_NUMBER: "DUMMY_VALUE_REPLACE_with_PROJECT_NUMBER"
PROJECT_ID: "DUMMY_VALUE_REPLACE_with_PROJECT_ID"
OAUTH_CLIENT_ID: "DUMMY_VALUE_REPLACE_with_OAUTH_CLIENT_ID"
CURRENT_KEY: "DUMMY_VALUE_REPLACE_with_CURRENT_KEY"
OTHER_PLATFORM_OAUTH_CLIENT_ID: "DUMMY_VALUE_REPLACE_with_OTHER_PLATFORM_OAUTH_CLIENT_ID"
APP_STORE_ID: "DUMMY_VALUE_REPLACE_with_APP_STORE_ID"

Note: Flags should be place under the Firebase Configurations
For more details see Jira Story

@farhan-arshad-dev  You should also create a corresponding PR for config repo as well


Using dinit instead of s6

The Dinit Init system is only 123kb, compared to the ~200kb of s6-rc, while seemingly providing more features.
Here is the Blog and Github Repo:
https://davmac.wordpress.com/category/dinit/
https://github.com/davmac314/dinit

@linux-leo dinit is impressive, and I'm actually considering providing it as an option alongside s6.


Please merge revisions 3fa0cae & b837d63 into stable channel

@whesse @mit-mit @kasperl
This is to fix a crash in dart2js related to js-interop (issue #24974)
This requires 2 cherry-picks:

https://github.com/dart-lang/sdk/commit/3fa0cae192dce46aef1c9040e8782702aa1e2d9c (most of the change)
https://github.com/dart-lang/sdk/commit/b837d63d47aed38ceae39b78ba4d04048475d0e5 (a follow up fix)

Note this doesn't merge cleanly. I created CL<PHONE_NUMBER> with all the necessary changes. In particular,

the first merge has a conflict, to resolve I had to delete the conflicting lines (conflict was a modify-vs-delete)
Some APIs changed since the stable channel was cut, I changed the code where the API was different. These API changes are the diff between patchset 1 and patchset 2 of the attached CL.

It seems we need this merged to the dev channel as well. I haven't tested if it merges cleanly yet, if it doesn't, most likely the fixes are the same than those needed in the stable channel.

We are still doing full pushes to dev channel, so it won't need a merge.
On Dec 3, 2015 6:56 PM, "sigmundch"<EMAIL_ADDRESS>wrote:

It seems we need this merged to the dev channel as well. I haven't tested
if it merges cleanly yet, if it doesn't, most likely the fixes are the same
than those needed in the stable channel.
—
Reply to this email directly or view it on GitHub
https://github.com/dart-lang/sdk/issues/25068#issuecomment-161828137.

ah ok - FWIW, there was no conflict for dev channel: I was able to cherry-pick both changes without a problem.

Merged in 1.13.1


You get file not found error when no game exists

When trying to load a game from an empty directory of if the game directory is missing it should give you the correct error telling you to make a new game.

Looks like the engine is trying to load the info.json file before validating that the game directory has the right files so it isn't showing the correct error.

This is now showing the correct error message.


Regression with  biobricks-0.2.0: file not found error for missing directory data/

Introduced in commit https://github.com/biobricks-ai/biobricks/commit/3d039fcdeb8087544a3f63d58040909776f0cf88. Seems that find_allowed_files() does not check for the existence of dir_path first.
Also, is it only supposed to look in data/ (seems that searching brick/ got dropped)?
$ biobricks install ice
2023-11-26 01:55:48 | INFO: getting latest version of https://github.com/biobricks-ai/ice
2023-11-26 01:55:49 | INFO: running checks on brick
2023-11-26 01:55:49 | INFO: git clone https://github.com/biobricks-ai/ice biobricks-ai/ice/f247c13d1e93feb5e8d7b46a4036f4485a8b5a43 in /mnt/ssd/biobricks
2023-11-26 01:55:49 | INFO: adding brick to dvc cache
2023-11-26 01:55:50 | INFO: setting up credentials for dvc.biobricks.ai
2023-11-26 01:55:51 | INFO: discovering brick assets dvc.biobricks.ai
Traceback (most recent call last):
  File "/path/to/.local/bin/biobricks", line 8, in <module>
    sys.exit(cli())
  File "/path/to/.local/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/path/to/.local/lib/python3.10/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/path/to/.local/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/path/to/.local/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/path/to/.local/lib/python3.10/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/path/to/.local/lib/python3.10/site-packages/biobricks/cli.py", line 71, in install
    return Brick.Resolve(ref, force_remote=True).install()
  File "/path/to/.local/lib/python3.10/site-packages/biobricks/brick.py", line 159, in install
    allowed_paths = find_allowed_files(fs, "data", Brick.ALLOWED_FILETYPES)
  File "/path/to/.local/lib/python3.10/site-packages/biobricks/brick.py", line 151, in find_allowed_files
    for file_path in fs.listdir(dir_path):
  File "/path/to/.local/lib/python3.10/site-packages/fsspec/spec.py", line 1514, in listdir
    return self.ls(path, detail=detail, **kwargs)
  File "/path/to/.local/lib/python3.10/site-packages/dvc/fs/dvc.py", line 336, in ls
    raise FileNotFoundError(errno.ENOENT, os.strerror(errno.ENOENT), path)
FileNotFoundError: [Errno 2] No such file or directory: 'data'

Work around: downgrade biobricks:
pip3 install biobricks==0.1.66

fixed. We really ought to normalize on using the brick dir though.


Vickel: Watch expressglobaldocs.com

Vickel requests the watch of the watch_keyword expressglobaldocs\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

expressglobaldocs\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Makyen in Charcoal HQ


/island leave - doesnt delete anything? XD

title

https://github.com/kozennnn/simple-skyblock/blob/dev/src/main/java/fr/kozen/skyrama/commands/subcommands/LeaveCommand.java
"You left your island and it was deleted."

iirc was there a config aption
(may look into it later) (if ... doesn't write anything before that)


@index not working

Reproduce by doing following:

Go to client/templates/app-body.html and add  {{@index}} on line 38
See on site that index is being output
Add peerlibrary:blaze-components
Go back to site and the index is not being output anymore

has been reported here https://github.com/matteodem/meteor-easy-search/issues/366

Have you updated Blaze Components to 0.15.1, which is the latest version?

This is duplicate of this ticket.
You still haven't upgraded to 0.15.1.


Use Join-Path in Powershell script

Use Join-Path to produce the file path in the PowerShell script instead of string concatenation.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@kalamajka Thank you for your contribution!
#sign-off


add conditional for ES2015 modules not transpiled with Babel

Fixes https://github.com/markdalgleish/static-site-generator-webpack-plugin/issues/46
See https://github.com/markdalgleish/static-site-generator-webpack-plugin/issues/46#issuecomment-241088084

Coverage remained the same at 100.0% when pulling a728ad711d0deec78c9fa2e08b289cd71596d280 on sidjain26:master into 997318a3fccc765dfdf77bed6891bd1be20b0ed5 on markdalgleish:master.

Coverage remained the same at 100.0% when pulling 8a8fbe842147928e0a6675d81abec90599cf8129 on sidjain26:master into 997318a3fccc765dfdf77bed6891bd1be20b0ed5 on markdalgleish:master.

Thank you so much for this :+1:


Q: Depth camera tranformation?

Hello,
I'm having a hard time relating the output of the depth camera to real world coordinate space (x,y,z in meters)?
Could you help me out interpreting the 8Bit image a bit by explaining the transformations under the hood.
For example does the depth scale linearly, is the value a projected line onto the camera plane or straight towards the camera position etc.
Thank you,
Fuda

This is the few references I have seen in the flightmare docs that have todo with depth images.
Depth is not linear
Depth has information loss
The terrain does not show in the depth image


Throttle config is not applied because handleDragging is defined before prop initialization.

Describe the bug
The throttle prop is exposed but does not take effect.
This is because handleDragging is defined before props have been initialized.
To Reproduce
Bind any value to throttle, and notice that it does not take effect.
For example:
<carousel
  ...
  :throttle=0>
  ...
</carousel>

Expected behavior
Mouse/touch drag on carousel should no longer be throttled.
Screenshots
N.A.
Desktop (please complete the following information):
All versions
Smartphone (please complete the following information):
All versions

The carousel now uses RequestAnimationFrame to throttle the dragging, as seen here: https://github.com/ismail9k/vue3-carousel/pull/422. This improves performance. The throttle property wasn't documented since I was planning to deprecate it anyway.