[FEATURE] Add zipObject

Description
Add zipObject from #100 as it is one of the functions that is simple and easy to make more understandable
What does your PR belong to?

[ ] Website
[x] Snippets
[ ] General / Things regarding the repository (like CI Integration)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (non-breaking improvement of a snippet)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have checked that the changes are working properly
[x] I have checked that there isn't any PR doing the same
[x] I have read the CONTRIBUTING document.

@Pl4gue Are we really writing Array(capitalized because it's a specific type) lower case? huh okay I'll update

although if that were the case why didn't I do it with object...


ui: view who reacted on mobile

currently the only way to view who reacted to a msg is by hovering the button on desktop. need to design an affordance to view this info on mobile

Closing in favor of #1661


adding my profile

Fixes #
Proposed Changes
-adding my profile

Screenshots

@RagibAjmal thank you for the PR, there are some small suggested changes, if you can update, then we can get your PR merged :)


Convert to markdown README for pypi

See https://dustingram.com/articles/2018/03/16/markdown-descriptions-on-pypi for more info.
This will get rid of having to convert to rst!

Done with 3.0


Added Combine support

The PR adds support for Apples Combine framework.

@Prince2k3
Hi, thanks for the PR.
You already could use Combine and Guava without any additions to its core.
For example:
class MultiplierTestDoublePublisher: MultiplierPublisher {

     var multiplyMethod = TestDoubleFactory<AnyPublisher<Int, Error>>()

     func multiply(_ left: Int, _ right: Int) -> AnyPublisher<Int, Error> {
         multiplyMethod.invoke(arguments: [left, right])
     }
 }

Usage:
let just = Just<Int>(5)

testDouble.multiplyMethod.stub(just)

// Rest of the test suite
// ......

@merindorium Well then....nevermind 😄


Feature/orchestrator

Description
This is the full local e2e flow for Orchestrator.
Includes these major pull requests:
4852
4384
Validating E2E, UTs and CI tests before doing full PR

Coverage decreased (-0.1%) to 54.359% when pulling ad266b77fa29d6e28bb99132f8298f8b33f5005d on feature/orchestrator into abce2a74a098c1c1c8b22ae1c679ff3c98ee0f24 on main.


Restore python3 support

This restore python3 support, wich was dropped in this commit.
Please, check code before merge to master for support both python versions, because it hard to use this library when it can suddenly break.

Thanks


Update sio_core library with new fee endpoints

Overview
There is a new way of handeling calls between chains, explorers and client. Regarding these new changes we need to update our library with new type of communication.
Outcome
sio_core library will be using new endpoints for getting fees from Bitcoin, Binance Smart Chain and Solana
Requirements

Get proper ID of asset with /assets/system-assets endpoint
Change Fee endpoints in sio_core

This will be done in simplio-app directly.


Mapper::unmap should be unsafe

I noticed that unmap and now clear are both safe functions. Shouldn't they be marked as unsafe? After all using unmap or clear can invalidate any existing reference and rust safety guarantees require all references to be valid? In any case that should probably be a second PR/issue

We don't consider page faults to be UB so unmapping memory by itself isn't unsafe.

I'm not sure i agree with that, but it doesn't matter for this pr anyways

Feel free to open an issue, if you want to discuss this more!

Originally posted by @Freax13 in https://github.com/rust-osdev/x86_64/issues/484#issuecomment-2124509620
I agree that page faults by themself are not UB, unmapping a page while a ptr into that page still exists can still lead to UB.

map a page
create a reference to a value in that page
unmap the page
map the page again
now accessing the original ptr breaks rust aliasing rules

This would also effect Mapper::clear after #484 is merged.

Also if I read the Rustonmicon correctly they probably consider page faults as something that should be marked as unsafe.

A reference cannot outlive its referent

https://doc.rust-lang.org/nomicon/references.html

4. map the page again

This would require an unsafe operation in our current API.

Maybe your right. That said I personally am not sure about the idea that page faults are not UB, but I guess it's not that big of a deal.
I just found #202 and I understand where you're coming from on this point. Would you be willing to accept a PR that adds some reasoning for this in the documentation for unmap. Looks like I'm not the only one who thinks that way.

Page faults are often handled transparently by the operating system, e.g. when swapping out pages to disk. When the CPU tries to access the referenced value, the OS can handle the page fault by reading the original page back from disk and restoring the original mapping. So the referenced value still exists and is still alive, it's just is no longer in RAM.
Another example are pages that are marked as copy-on-write during fork. Once the CPU tries to modify a value (e.g. referenced by a &mut) a page fault occurs. The OS typically reacts by copying the page to a new physical frame so that it can safely modified.
Of course this all depends on the correct behavior of the OS. When it maps the wrong page on a page fault, it's definitely undefined behavior. We model this in our API by making the map_to method unsafe because that's the place where you need to ensure that no mutable aliasing etc occurs.
So I guess the question is: Is there a way to cause UB using unmap without using any other unsafe method such as map_to? Is it UB to abort a user program on such a page fault?
I'm happy to discuss this further and I'm not strongly opposed to make unmap unsafe if there is a good reason. We just try to only define methods as unsafe if absolutely needed because otherwise the whole crate would consist of unsafe methods.


'Preview' button on creating a page is missing button style

Presumably missed in #2524:

I'm concerned there may be others that were missed - I think we'll need to systematically step through all templates to be sure.

I can't reproduce issues with preview button on current master, but I found another issue with "Save" button for snippets. I'm working on fix.
modeladmin, probably have the same issues as snippets.

#2611 should fix issues with preview button on page create view and with save buttion for snippets (create and edit view).
Now I'm going to check modeladmin.

Sorry, I forgot to leave comment here. PR #2611 was updated: issue with buttons in modeladmin were fixed.

I'm pretty confident that #2622 has now caught all remaining unstyled buttons.


Complexity: rethink how complexity scores are calculated

Description
Complexity scores (now calculated offline) but based on previous core waltz calculations need updating. Could have a scheduled job for community to use to populate basic complexity kinds
Resourcing
We intend to contribute this feature

Doodles:

select * from measurable_category;

-- max depths
select mc.name, max(descendant_level)
from entity_hierarchy eh
inner join measurable m on m.id = eh.id and eh.kind = 'MEASURABLE'
inner join measurable_category mc on m.measurable_category_id = mc.id
group by mc.name;

-- distinct pairs
with functions as (
        select m.id
        from measurable m
        inner join measurable_category mc on mc.id = m.measurable_category_id
        where mc.external_id = 'CAPABILITY'),
    rating_pairs as (
        select mr1.entity_id, mr1.measurable_id m1, mr2.measurable_id m2
        from measurable_rating mr1
        inner join measurable_rating mr2 on mr1.entity_id = mr2.entity_id
        where mr1.measurable_id in (select id from functions)
        and mr2.measurable_id in (select id from functions)
        and mr2.measurable_id <> mr1.measurable_id),
    uniq_pairs as (
        select distinct rp.entity_id,
                        least(rp.m1, rp.m2) as m1,
                        greatest(rp.m1, rp.m2) as m2
        from rating_pairs rp),
    common_ancestors as (
        select entity_id,
               m1,
               m2,
               coalesce(max(eh2.level), 0) common_parent_level
        from uniq_pairs
        left join entity_hierarchy eh1 on eh1.id = m1 and eh1.kind = 'MEASURABLE'
        left join entity_hierarchy eh2 on eh2.id = m2 and eh2.kind = 'MEASURABLE' and eh1.ancestor_id = eh2.ancestor_id
        group by entity_id, m1, m2),
    squished as (
        select entity_id,
               count(*) num_pairs,
               sum(common_parent_level) similarity,
               cast(sum(common_parent_level) as float) / count(*),
               count(*) * 1.5 - sum(common_parent_level)
        from common_ancestors
        group by entity_id)
select * from squished;
-- select entity_id, level similarity, m_a.id, m_b.id, m_a.name, m_b.name
-- from common_ancestors
-- inner join measurable m_a on m_a.id = m1
-- inner join measurable m_b on m_b.id = m2
-- where entity_id = 100;
--select * from uniq_pairs where entity_id = 100 order by entity_id, m1, m2 ;

select * from entity_hierarchy where id = 95 and kind = 'MEASURABLE';
select * from entity_hierarchy where id = 94 and kind = 'MEASURABLE';

SQL Server variant:
with functions as (
    select m.id
    from measurable m
             inner join measurable_category mc on mc.id = m.measurable_category_id
    where mc.external_id = 'CAPABILITY_TAXONOMY'),
     rating_pairs as (
         select mr1.entity_id, mr1.measurable_id m1, mr2.measurable_id m2
         from measurable_rating mr1
                  inner join measurable_rating mr2 on mr1.entity_id = mr2.entity_id
         where mr1.measurable_id in (select id from functions)
           and mr2.measurable_id in (select id from functions)
           and mr2.measurable_id <> mr1.measurable_id),
     uniq_pairs as (
         select distinct rp.entity_id,
                         case when rp.m1 < rp.m2 then rp.m1 else rp.m2 end as m1,
                         case when rp.m1 > rp.m2 then rp.m1 else rp.m2 end as m2
         from rating_pairs rp),
     common_ancestors as (
         select entity_id,
                m1,
                m2,
                coalesce(max(eh2.level), 0) common_parent_level
         from uniq_pairs
                  left join entity_hierarchy eh1 on eh1.id = m1 and eh1.kind = 'MEASURABLE'
                  left join entity_hierarchy eh2 on eh2.id = m2 and eh2.kind = 'MEASURABLE' and eh1.ancestor_id = eh2.ancestor_id
         group by entity_id, m1, m2),
     squished as (
         select entity_id,
                count(*) num_pairs,
                sum(common_parent_level) similarity,
                cast(sum(common_parent_level) as float) / count(*) dunno,
                count(*) * 1.5 - sum(common_parent_level) also_dunno
         from common_ancestors
         group by entity_id)
select * from squished;

Doodle part 2
with functions as (
        select m.id
        from measurable m
                 inner join measurable_category mc on mc.id = m.measurable_category_id
        where mc.external_id = 'CAPABILITY_TAXONOMY'),
     rating_pairs as (
         select mr1.entity_id, mr1.measurable_id m1, mr2.measurable_id m2
         from measurable_rating mr1
                  inner join measurable_rating mr2 on mr1.entity_id = mr2.entity_id
         where mr1.measurable_id in (select id from functions)
           and mr2.measurable_id in (select id from functions)),
           --and mr2.measurable_id <> mr1.measurable_id),
     uniq_pairs as (
         select distinct rp.entity_id,
                         case when rp.m1 < rp.m2 then rp.m1 else rp.m2 end as m1,
                         case when rp.m1 > rp.m2 then rp.m1 else rp.m2 end as m2
         from rating_pairs rp),
     common_ancestors as (
         select entity_id,
                m1,
                m2,
                coalesce(max(eh2.level), 0) common_parent_level
         from uniq_pairs
                  left join entity_hierarchy eh1 on eh1.id = m1 and eh1.kind = 'MEASURABLE'
                  left join entity_hierarchy eh2 on eh2.id = m2 and eh2.kind = 'MEASURABLE' and eh1.ancestor_id = eh2.ancestor_id
         group by entity_id, m1, m2),
     squished as (
         select entity_id,
--                 count(*) num_pairs,
--                 sum(common_parent_level) similarity,
                1 / (cast(sum(common_parent_level) as float)/ count(*)) raw_complexity
         from common_ancestors
         group by entity_id),
    test_data as (
        select * from (values(138594001, '1 rating'),
                             (17365, '2 ratings, same l2'),
                             (151296001, '3 ratings, same l2'),
                             (120236001, '2 ratings, same l1'),
                             (1426039, '3 ratings, 2xl1 + another l1'),
                             (169981001, '4 rating all different, same l1'),
                             (15955, 'bad'),
                             (17769, 'very bad')) test_data(entity_id, descr)
    )
select app.name, app.asset_code, raw_complexity / (select max(raw_complexity) from squished)
from squished
inner join application app on app.id = entity_id
order by 3 desc
;

To turn this into a deliverable we need to:

[ ] Create a core waltz scheduled job which can be given a list of categories specified in the setting table (see example below)
[ ] Register a new scheduled job (key = COMPLEXITY_REBUILD_MEASURABLE)
[ ] Document this
[ ] Integration test (setup 'n' apps, add them to a group, rebuild complexity, assert correct order)

Job configuration in settings table
job.COMPLEXITY_REBUILD_MEASURABLE.params= [{ complexity_kind: 'CAPABILITY', measurable_category: 'CAPABILITY_TAXONOMY' }, ...]


E2E: fix pinning/unpinning a post

Summary

Fixed pinning/unpinning a post
Moved specs to respective folder
Cleaned up based on style/guide

Note: This is submitted on top of https://github.com/mattermost/mattermost-webapp/pull/3647.  See https://github.com/mattermost/mattermost-webapp/commit/4f022d50eb8806b4a908513fa5c0523692576526 for specific change of this PR.  Will update this once the said PR is merged into master.
Ticket Link
none

@saturninoabril Can't merge it quite yet because of conflicts.

Thanks @prapti, I'll update.


Custom hosted nadeko not displaying text for some commands

Hello,
A server that I moderate in has a custom version of nadekobot hosted by somebody in another server that we've been using with their permission. We're having an issue with it not displaying responses for all commands - the server greeting message works, .avatar works, .checkperms works; however, .uinfo and .sinfo don't display anything, .listperms doesn't work (server owner/admin tried it and nothing happened).
Commands like .iam and .iamnot do add/remove roles properly, but the bot doesn't display a message confirming the addition or removal. Any ideas on how we can fix this on our end?
Thank you

Thanks! We weren't able to find a solution; the bot is working as normal on the owner's server. In the end we just decided to use the public Nadeko instead, since the only thing the custom one had that was much different was the avatar and name

Yea it's either a bot, or server permission issue.


Make better use of i18n

Previously, we relied on performing numerous expensive map lookups and storing each parsed ini file in memory.
As we add more translations and languages, this strategy won't scale and has become visible and measurable in memory utilization. All parsed ini currently uses about 20-30Mb of memory, which is nothing on modern computers. Every bit counts when running Gitea on low-powered devices like Raspberry Pis and Android phones. This PR fixes that by using a new data structure that don't require more memory than is necessary and is scalable for the future.
Startup memory is now closer to 60Mb than 90Mb, making it easier to stay under 100Mb. The new implementation needs 1.4Mb to hold all raw translation values and 5Mb for the map that maps translationKey -> index in translation values slice.
The lookup for translation values may be greatly improved, leading to faster performance overall, even though I haven't performed any tests or benchmarks comparing the current and earlier implementations. Additionally, the language struct, which contains the important offset variable, will passed around rather just language names, which resulted in a small speed improvement as it avoids lookup this language struct.
So how does it more effectively store translation keys and values? We begin by acknowledging that all translation values are kept in one large slice. The default language's values would be the first ones. Additionally, it stores the language's parts and keys. The procedure then moves on to the other languages, only using the sections and keys that the default language has. Since the default language's value would be used in the absence of any sections or keys, we also forgo testing for situations in which the language doesn't have a translation value. The Map now enters the picture. First, we perform a relatively quick O(1) index query for the translation key. Next, we use the language's offset to obtain the right index; otherwise, the default language would be used.

To visualize it a bit:
The raw data:
Languages: [en-US, nl-NL]
DefaultLang: en-US
Keys: [explore, pull_request, issues]
KeysLen: 3
Values: [Explore, Pull Requests, Issues, Verkennen, Pull requests, Kwesties]
Offset of en-US: 0
Offset of nl-NL: 1
Situation:
Now the Keys would be given the perfect hash function builder Imagine that we are an English-speaking user who requests a page that uses the issues translation key. Gitea will supply the translation key—in this case, "issues"—to the map query and it will return "2," which is the right index. Gitea will now add to that index, "Offset of en-US * KeysLen = 0 * 3." Now executing Values[2] indeed gives us the right value.
Let's pretend for a moment that we speak Dutch. The technique is the same, but because nl-NL has an offset of 1, it will add 1 * 3 to the results, in which case the index becomes 5, which is the correct translation value for nl-NL.

Before:

25Mb to initialize the locales(After Go's GC)

After:

5.6Mb to initialize the locales(After Go's GC)

As usual, goodluck reviewing this piece of beauty and mess.

I think it's on the correct direction for the i18n refactoring.
The only question in my mind is: is the perfect hash map necessary? If the simple map can still save the memory and works fine, I would prefer to use a simple map (like map[string][]string =>  map[key][offset]) to reduce maintenance work.

is the perfect hash map necessary? If the simple map can still save the memory and works fine, I would prefer to use a simple map (like map[string][]string => map[key][offset]) to reduce maintenance work.

So, I'd preferred the perfect hash as it was made for these kind of situations, need fast query and the keys are known before-hand. Thereby there was no really good quality perfect hash library(so that's why I crafted one and included in the PR). I've pushed a commit(https://github.com/go-gitea/gitea/pull/20096/commits/d498472fa0a616492c2abab9a7456327c2cf75ba) that utilized the same concept of the language offset and then instead use golang's Map feature. The memory is bit more on the heap(it says 10Mb) but the overall memory usage still seems to be around the same levels of what the previous implementation had.

L-G-T-M (except CI failure is related)
And, could the translationKeys be set to nil to save some memory? It seems that it's not used after the loop IIRC.

--- FAIL: TestLDAPUserSigninFailed (0.30s)
testlogger.go:78: 2022/06/24 01:51:14 modules/git/git.go:133:checkInit() [W] git module has been initialized already, duplicate init should be fixed

That issue once again...

So did the memory testing, seems like to use map for each locale doesn't have a big impact.

So IMO this is approved. One thing we could to improve is textMap and move it to slice, but then we need to introduce the base language concept back in. Given the memory & performance is already near-perfect(relative to the perfect hash function implementation) I don't see the justification to over complicate it. Many thanks @wxiaoguang!

Updated the PR comment to reflect the new situation.

Attached is a patch that would allow auto reloading of i18n files in dev
dev-prod-i18n.patch.txt

Pushed commits to separate dev and production localestores(so it's easier to implement live-reloading etc.). Provided by @zeripath

I think some code can be simplified, will try on it later.

I think some code can be simplified, will try on it later.

Even more refactors 😄 I will mark this PR for 1.19 already

I believe 1.18 is fine (will try on it later means several hours later, I am going outside soon 😂) .

I proposed a PR about my idea.  https://github.com/Gusted/gitea/pull/5
Major benefits:

more simple (+185 −509)
no more go-routine, no need to close (in case it's forgotten ...)
no duplicate code, only one Tr / reloadLocaleByIni function, more easier to be maintained
works fine for dev mode, the reload delay is (at most) 1 second, it won't affect development in real life: change locale files -> refresh page to see the result -> more than 1 second has been elapsed.


Documentation change to fix #1862

Clarified that the mdl-layout classes cannot be put on the body element.
You can preview the changes at https://github.com/The4thLaw/material-design-lite/tree/issue-1862/src/layout (changes are on the documentation only).

I don't like the way this is going to display. It is a specific call-out note, so it shouldn't be a part of the primary content flow like it is. Instead it should be a blockquote to call out this note in particular to a developers attention. Further, no extra code examples are needed.

I like code samples, but I have no strong feelings against removing them. It's your call :)
I've committed a new change, following the style of the badge component documentation.
Note that step 1 is still split in two compared to the current documentation. I found it consistent with the documentation for badge, button and card at least.

Note that step 1 is still split in two compared to the current documentation. I found it consistent with the documentation for badge, button and card at least.

Best address that in its own PR. Keep modifications as specific as possible. This keeps the commit history clean and discussion on changes direct.

I would usually agree to keep the modifications specific, but I also think that not doing this now will make the rest of the change more confusing. The additional note would feel out of place, with little context.

I actually do not mind the new format, I think that it is somewhat reasonable for a user to expect to be able to apply the "layout" to the body
just my 2 cents :)

@samccone The problem is, if we document every pitfall developers hit we will slowly accumulate a mountain of notes. What is documented works and if developers deviate it is on them. We can't add safeguard notes across everything for every issue developers bring up that they hit, it will become un-maintainable. And yes, right now it is just this one. But that one becomes precedent for many more to be added.
I'm not saying our documentation is perfect by any means, but it is at least clear if you follow the instructions.

No, we can’t document every pitfall, but I agree with @samccone that I can totally see people expecting layout to work on <body>, so it’s sensible to warn as our JS does rather unexpected things. :+1: for merge.
Waiting for @sgomes and/or @addyosmani.

+1, I don't think adding a small note documenting this is an issue.


KAFKA-4493: Throw InvalidTransportLayerException when a plaintext client receives a TLS response

Currently, if a client if misconfigured to not use ssl and conencts to a broker with SSL listeners, the broker responds with a TLS Alert response.
The client interprets the first 4 TLS alert response bytes as the size of the response, resulting in it trying to allocate 352518912 bytes.
This either raises an OutOfMemory exception or stalls on the allocate() call. Either way, we should fatally throw a more clear exception so the user can know what is wrong.
I personally spent more time than I'm comfortable sharing debugging this issue and I'd like to see it improved.
Implementation
On the first read of a PlaintextTransportLayer channel, we check against the pre-defined TLS alert headers, which consist of the alert byte 0x15 and the TLS version 0301,0302, 0303.
I believe that it should be alright to close such responses since we would never expect to receive a 3mb response on the first response in a newly-established connection since we should at least verify API_VERSIONS first.
I'm not entirely certain whether this warrants creation of a KIP since we are raising a new exception - InvalidTransportLayerException. That is not publicly exposed, right?
cc @rajinisivaram for review

It would be better if the broker did the right thing here. Have we considered that? Given the client upgrades take forever, any fix on the client side is less effective in the short/medium term.

I had not considered that. Thanks for the suggestion @ijuma.
After some digging around I find that the first place where we the server detects that something is wrong is from a raised SSLException. As the docstring of maybeProcessHandshakeFailure (https://github.com/apache/kafka/blob/4e90af34c6c2eff8e164a7d3fafb1ae8b744784c/clients/src/main/java/org/apache/kafka/common/network/SslTransportLayer.java#L863) says:

// SSL handshake failures are typically thrown as SSLHandshakeException, SSLProtocolException,
// SSLPeerUnverifiedException or SSLKeyException if the cause is known. These exceptions indicate
// authentication failures (e.g. configuration errors) which should not be retried. But the SSL engine
// may also throw exceptions using the base class SSLException in a few cases:
//   a) If there are no matching ciphers or TLS version or the private key is invalid, client will be
//      unable to process the server message and an SSLException is thrown:
//      javax.net.ssl.SSLException: Unrecognized SSL message, plaintext connection?
//   b) If server closes the connection gracefully during handshake, client may receive close_notify
//      and and an SSLException is thrown:
//      javax.net.ssl.SSLException: Received close_notify during handshake
// We want to handle a) as a non-retriable SslAuthenticationException and b) as a retriable IOException.
// To do this we need to rely on the exception string. Since it is safer to throw a retriable exception
// when we are not sure, we will treat only the first exception string as a handshake exception.

javax.net.ssl.SSLException: Unrecognized SSL message, plaintext connection? is exactly what gets raised here. Since we do not know the core cause of the issue (and there doesn't seem to be a way to find out), we flush whatever bytes we have down the wire to the client. These bytes happen to represent a TLS alert message (any one of https://www.gnutls.org/manual/html_node/The-TLS-Alert-Protocol.html) (I could not get Java to print out the whole bytes and decode what type of message the SSLEngine produced.
It seems like we want to preserve the behavior of flushing the bytes to the client. For example, if the client's private key is invalid, we would want to send the alert message back.

Thanks for the investigation. My concern is that this is a bit of a layering violation. The plaintext code now has to know about TLS. What about other protocols that can cause the same issue? It would be better if the plaintext code could validate based on what it knows about its own protocol.

That could work, but the current code is checking all reads, right? Not just the first response.

No, the current code checks only the very first read due to the completedRead flag. Since we store one TransportLayer per connecition (KafkaChannel), this should only catch the very first read

@ijuma From reading the code and quickly testing locally, I believe that inter-broker communication starts with either

UPDATE_METADTA request when it's from a controller to another broker, which contains all the partitions present in the cluster

[2019-07-13 23:08:32,238] ERROR [KafkaApi-0] Handling request:RequestHeader(apiKey=UPDATE_METADATA, apiVersion=4, clientId=0, correlationId=32) -- {controller_id=0,controller_epoch=3,partition_states=[{topic=test,partition=0,controller_epoch=3,leader=2,leader_epoch=6,isr=[2],zk_version=8,replicas=[1,2],offline_replicas=[1]}],live_brokers=[{id=2,end_points=[{port=9094,host=localhost,listener_name=PLAINTEXT,security_protocol_type=0}],rack=null},{id=0,end_points=[{port=9092,host=stanislozlovski,listener_name=PLAINTEXT,security_protocol_type=0}],rack=null}]} from connection <IP_ADDRESS>:9092-<IP_ADDRESS>:61588-0;securityProtocol:PLAINTEXT,principal:User:ANONYMOUS (kafka.server.KafkaApis)

OFFSET_FOR_LEADER_EPOCH request when it's from a follower to a leader. In both cases. It contains all the partitions the follower is interested in

[2019-07-13 23:07:35,463] ERROR [KafkaApi-0] Handling request:RequestHeader(apiKey=OFFSET_FOR_LEADER_EPOCH, apiVersion=2, clientId=broker-2-fetcher-0, correlationId=161) -- {topics=[{topic=test,partitions=[{partition=0,current_leader_epoch=3,leader_epoch=0}]}]} from connection <IP_ADDRESS>:9092-<IP_ADDRESS>:61715-4;securityProtocol:PLAINTEXT,principal:User:ANONYMOUS (kafka.server.KafkaApis)

It seems like the UpdateMetadataRequest is likely to go over 1MB in size. From a very rough calculation (basically multiplying the most frequently-variable piece of that request - UpdateMetadataPartitionState), I estimate that we will go over the 1MB threshold of UpdateMetadataRequest size once we reach around 20k partitions for the entire cluster.
Perhaps we could raise the MB check limit here? My initial message had said that in such a misconfiguration, the broker thinks it needs to allocate 352MB for the request. A simple 100MB check should suffice I think

cc @ijuma thoughts on this?

test this please


Set Up CI/CD Pipeline in IBM Cloud

As a [role]
I need [function]
So that [benefit]
Details and Assumptions

[document what you know]

Acceptance Criteria
Given [some context]
When [action taken]
Then [outcome observed]

More detail:

Set up the DevOps Continuous Delivery Pipeline in IBM Cloud to build and deploy your project when the master branch changes.
Connect this DevOps pipeline to the GitHub repository for your project via a webhook. The owner of the repo must do this.

Closed without points because it is duplicate to other stories


Windows key in default keybindings on Windows

I don't think we shouldn't be doing this, it's reserved for OS-level actions unlike cmd on mac.
{ "key": "ctrl+win+w",            "command": "workbench.action.toggleTabsVisibility" }
{ "key": "win+l",                 "command": "workbench.debug.panel.action.clearReplAction",
                                     "when": "inDebugRepl" }

editor.action.autoFix is also, tracked in https://github.com/Microsoft/vscode/issues/67411

@alexandrudima thoughts on using the Windows key on Win?

@bpasero I think it's just asking for trouble. No application I've ever used on Windows tries to bind with that modifier, and even if we find a free one, new Windows versions sometimes bind new ones to the Win+ key combination... Moreover, if you press Win+ and change your mind after a split second, you get the start menu popping up, which is kind of horrible, imagine if that would happen when pressing Ctrl+...

Removed one: https://github.com/Microsoft/vscode/commit/1ad028dfa956522dbd4ddabf5551092ca40fac19

Removing it. Also it now overlaps with repl filtering
Sorry @octref you can still customise it

@isidorn @octref you could only enable it just for Mac, there are a bunch of terminal commands that only work on mac.


Update full package repository structure

The current repository has a lot of redundant directories and has no Go code in the project root. This can most likely be updated to be more easy to work with, as well as easier to go install.

Should we move /pkg/* to top level ?
We might as well move templates to top level too, and make them customizable.
xo has taken this a step further, and enables users to dump their templates, such that they can update/configure them by hand themselves, and then use them directly with the tool.
This refactor would also make it far easier to decouple the runtime package, and we might as well do #68 in the same way.


Fix broken getLocalAddresses

On some locked-down systems (Docker in QEMU in my case), os.networkInterfaces() can throw an EAFNOSUPPORT error.
root@8e3c8f0809de:/npmconf# npm test
npm info it worked if it ends with ok
npm info using<EMAIL_ADDRESS>npm info using<EMAIL_ADDRESS>npm info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>npm info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>
><EMAIL_ADDRESS>test /npmconf
> tap test/*.js

test/00-setup.js ...................................... 1/1 2s
/npmconf/config-defs.js:332
  Object.keys(os.networkInterfaces()).map(function (nic) {
                 ^

Error: EAFNOSUPPORT: address family not supported, uv_interface_addresses
    at Error (native)
    at getLocalAddresses (/npmconf/config-defs.js:332:18)
    at Object.<anonymous> (/npmconf/config-defs.js:281:23)
    at Module._compile (module.js:425:26)
    at Object.Module._extensions..js (module.js:432:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:313:12)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at Object.<anonymous> (/npmconf/npmconf.js:4:18)
test/basic.js ......................................... 0/1

This was addressed in npm with https://github.com/npm/npm/commit/a4b62387b41848818973eeed056fd5c6570274f3 but not in npmconf.
This patch apply the same fix to npmconf.
With the fix:
root@8e3c8f0809de:/npmconf# npm test
npm info it worked if it ends with ok
npm info using<EMAIL_ADDRESS>npm info using<EMAIL_ADDRESS>npm info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>npm info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>
><EMAIL_ADDRESS>test /npmconf
> tap test/*.js

test/00-setup.js ...................................... 1/1 2s
test/basic.js ......................................... 7/7 3s
test/builtin.js ....................................... 7/7 3s
test/certfile.js ...................................... 2/2 3s
test/credentials.js ................................. 29/29
test/project.js ....................................... 7/7 3s
test/save.js .......................................... 3/3 3s
test/semver-tag.js .................................... 2/2 3s
total ............................................... 58/58

  58 passing (25s)

  ok
npm info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>npm info ok
root@8e3c8f0809de:/npmconf#

Since npm doesn't use npmconf anymore (it having been assimilated back into the project because the factoring made little sense), it should be considered deprecated. The npm team isn't maintaining it anymore, and any work done on it won't be reflected downstream in npm. Therefore, it doesn't make sense to accept any changes to it. If you want to use it for whatever reason, feel free to fork it. Thanks for taking the time to put this together, though!

Hi, thanks for the information, and for having marked it as deprecated in npm :)

@othiym23 what's the recommended way to query for npm's config now?
We use this in node-sass to query npm proxy config to apply to subsequent fetching of node-pre-gyp binaries.

@xzyfer run npm get proxy and npm get https-proxy as child processes. If that feels kind of clunky and heavyweight, I agree, but that's the most robust way to do it.

@othiym23 thanks for the advice.

ouch we not only have to figure out the path to a proper node engine (not so easy, see https://github.com/libuv/libuv/pull/652), now we need to figure out which npm did call us.

@saper the alternatives are to load npm and use it as an API (which the team would really rather you not, as that API isn't versioned, subject to change at any time, and also terrible), or duplicate all of the configuration bootstrapping npm does (tying together nopt, config-chain, etc). By comparison, calling npm as a child process is way simpler.
You're welcome to keep using npmconf for as long as it's useful to you, but it hasn't been kep up to date with npm ever since we incorporated it back into the CLI, about 16 months ago. There's work on the horizon that's likely to have a major impact on proxy configuration (we're planning to replace request with a purpose-built npm download manager), but npmconf should work well enough until then.
Also, if you want to fork npmconf and / or use it for a stripped-down proxy configurator, you're welcome to pilfer whatever bits of source are useful. The npm team is just done with it, is all. ;)

@saper we should fork this and cut it down the just the proxy config we need.

@othiym23 can you please confirm whether this documentation is still accurate in a post-npmconf world, with regards to lifecycle scripts?

Configuration parameters are put in the environment with the npm_config_ prefix.

https://docs.npmjs.com/misc/scripts#configuration


Remove Slack Icon and Slack Icon Emoji

Due to changes implemented by Slack, "You can't override...icon when you're using Incoming Webhooks to post messages" from https://api.slack.com/messaging/webhooks#advanced_message_formatting

[x] update README
[x] remove attributes from Webhook struct
[x] remove constants representing environment variable keys and their usages
[x] remote SLACK_ICON usage from main.sh, used by Dockerfile and entrypoint.sh

Closes #90

Thanks for the PR. Putting it temporarily on hold. Ref: https://github.com/rtCamp/action-slack-notify/issues/90#issuecomment-850064016


poppler: apply patch for CVE-2024-6239

Description of changes
https://access.redhat.com/security/cve/CVE-2024-6239
I preferred to pull the patch instead of bumping to the latest version. It seems to requires multiple compatibility patches (not released yet) to make inkscape happy.

Things done

Built on platform(s)

[x] x86_64-linux (with poppler.tests)
[x] aarch64-linux (with poppler.tests)
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

It's just about 700 dependents, we usually merge it to master.


IconButton's splash radius is too large on an AppBar

The IconButton does follow the default material specs and has a splash radius of about 24px. This is definitely not suitable for auto generated icons like the back button and the scaffold drawer button.
Though the material design does specify a set splash radius, an overflow is definitely not intended. The icon button's splash always overflows in AppBars.
Possible solutions -

Allow setting the default splash radius for all auto generated icon buttons in AppBars.

Set the default splash radius so that it doesnt overflow atleast  - in the defaul AppBar

Possibly related to inactive issue - #31194

Hi @sidrao2006,
Can you provide a screenshot of the splash effect that overflows the app bar ?
Also, provide flutter doctor -v.
Thanks.

It was easier to use a dartpad for this as there were very few changes needed.
Link to dartpad

Changes made
actions: [
        IconButton(
          icon: Icon(Icons.ac_unit),
          onPressed: () => print('Click'),
        ),
      ],

Why not just set the splashSize property to your desired value?

Why not just set the splashSize property to your desired value?

@dnfield it is not possible to the splashRadius in auto generated IconButtons like the back button and the open drawer button.

Ahh, ok. It sounds like appBar may need to have some extra property to pass through to iconButtons it creates.
I did check on some other Android apps and it looks ike the splash does not typically overflow the bar.
That said, app bars can be different sizes, and some people may want the overflow, so whatever is done here shouldn't be a change to defaults on IconButton.
/cc @willlarche  @rami-a who might know the right person on the Material team to look at this.

Also, based on a quick look at this code: https://github.com/flutter/flutter/blob/f2c2b02893fe8e099d03f43dc12fb777b00ab962/packages/flutter/lib/src/material/ink_highlight.dart#L122
Seems a little fishy to me - I wonder if there's some way we should be making sure that the highlight is drawn as a percentage of the constraints rather than as a fixed amount.

Thanks for bringing this up @sidrao2006. I think that there's definitely an improvement we can make here to allow for the out-of-the-box IconButtons inside app bars (Back button, menu button) to use a smaller splash radius. I've reached out to our designers to get some additional guidance on this and I'll report back once I have some.

I think I was able to fix it, taking @dnfield 's suggestion in mind. Now, I just need to run some tests

The IconButton does follow the default material specs and has a splash radius of about 24px.

I thought we did follow the specs... they may have changed, though. Do you have a link to the spec we should follow?

As far as how to control the splash size, that seems like something that we should put in the theme. cc @HansMuller

@Hixie , thanks for replying, as I have mentioned, flutter does indeed follow the material spec.
Amazing, I look into the themes and open a pr. But I am still confused whether to apply that to all the IconButtons (which is a more predictable behaviour) or apply it only to the IconButtons generated by autoImplyLeading

This is how it looks on latest stable (1.20.2) when we tap on iconButton in appbar:

flutter doctor -v
Flutter 1.20.2 • channel stable • https://github.com/flutter/flutter.git
Framework • revision bbfbf1770c (15 hours ago) • 2020-08-13 08:33:09 -0700
Engine • revision 9d5b21729f
Tools • Dart 2.9.1

Running flutter doctor...
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 1.20.2, on Mac OS X 10.15.2 19C57, locale en-US)
[!] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    ✗ Android license status unknown.
      Try re-installing or updating your Android SDK Manager.
      See https://developer.android.com/studio/#downloads or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions.
[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
[✓] Android Studio (version 3.6)
[✓] Connected device (1 available)

! Doctor found issues in 1 category.

@darshankawar , this problem existed even before v1.20.0

@HansMuller, @dnfield , @Hixie can you please review my solution plan

Create a property named iconButtonSplashRadius in ThemeData and then set the default value to overflow by following the material spec.

Add this property to AppBarTheme as well so that it can be customized only for the app bar too.

Set IconButton.splashRadius to Theme.of(context).iconButtonSplashRadius in icon_button.dart.

On approval, I will add these to my PR's TODO.

@rami-a is working with designers to confirm the spec. The specs change and what's published isn't always the latest guidance. We're proud that on Flutter we often get the latest guidance before it's even published so our clients can have the benefit of new features and improvements.
Also, sometimes the spec does change without alerting us that we need to make a code change. This happens much less often these days but happened a lot in earlier years.
Either way, we need to confirm what the designers want us to do here. And @rami-a is working on that. So, sit tight and we'll get back to you when this information request comes up in the queue!

Thanks a lot @willlarche

Waiting for #64789 to be merged

Any solution for this? The current size is definitely inadequate. I believe that allowing this property to be set by the application's theme would be enough.

Any update on this?

IconButton's splashRadius variable is 35.0(Because default set is Material.defaultSplashRadius attribute).
So when I use IconButton in actions at AppBar. I use it like this.
actions: [
        IconButton(
          onPressed: () {},
          icon: const Icon(Icons.add),
          splashRadius: Material.defaultSplashRadius / 2,
        )
],

When will we be able to control splashRadius from theme (including having the button themes for the appBar theme)?

Material.defaultSplashRadius / 2

Doing that doesn't help when we're using widgets that include IconButton inside of it. We need something to control splashRadius OUTSIDE of a given widget

IconButton's splashRadius variable is 35.0(Because default set is Material.defaultSplashRadius attribute).
So when I use IconButton in actions at AppBar. I use it like this.actions: [         IconButton(           onPressed: () {},           icon: const Icon(Icons.add),           splashRadius: Material.defaultSplashRadius / 2,         ) ],

Doing that doesn't help when we're using widgets that include IconButton inside of it. We need something to control splashRadius OUTSIDE of a given widget

Use splashRadius in IconButton

This will be fixed by https://github.com/flutter/flutter/pull/93478

https://github.com/flutter/flutter/issues/64702 landed

https://github.com/flutter/flutter/pull/93478 is reverted, I am working on reimplementation

What is the status of this? Thanks

The icon splashRadius look this so

I try to do this -
splashRadius: Material.defaultSplashRadius / 2
then it dosen't show any click moment on that app bar

How I deal with this?

Hi! The IconButton component is recently updated to the Material Design 3 spec, so the splash radius issue will no longer exist. Here's the issue link which contains the related PRs: https://github.com/flutter/flutter/issues/103528
Please let me know if there are any questions:) Thanks!

Is it by design that IconButton in AppBar is not having a round splash now?

The PR is reverted, so I re-opened this issue. Will add a reland soon.


Nui fixes

I fixed these yesterday but hadn't committed them back yet
https://github.com/scrapinghub/portia/pull/393/files


Add files via upload

Updated-Twenty-Twenty-One

not ready yet didn't build the lights

not ready yet didn't build the lights


Conditional formatting

I'd like to have the ability to change the format section depending on certain criterias.
For example, in the sway/workspaces module, I want to have:

format: "{name}" in general
format: "{icon}" if the workspace's name is slack or spotify

Is something like that already possible?

Oh do I have the project for you: https://github.com/Lyr-7D1h/swayest_workstyle


Clean up issues

Jon can you clean up any issues you have already addressed (usually by pasting in a link to the pull request (even if closed) where those changes were added
Then once done can you also clean this issue

PR here: https://github.com/kylemath/mne-python/pull/11


hyper brand

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

found on [this site]
(https://mic.com/articles/157365/pokemon-go-nest-location-updates-and-changes-players-tip-off-new-migration#.aJr8PFHCa)
it's an app for video things

⁉⁉⁉


Close active elements on state change

Overview
This PR:

Closes modals / lightboxes when a user swipes back in browser

Known issues:

beforeRemove event not fired on browser back button
Modals and lightboxes precede introduction of react-navigation into the codebase, hence going back from a modal does not return the user to what is, by their definition, the previous screen. This is likely the desired approach moving forward but the changes in this PR are sufficient for now.

@classicrob here's a happy path GIF. That said, this PR does not address that modals and lightboxes do not have routes tied to them. I linked the corresponding documentation which should help the team get there moving forward.


Win32 builds

Use llvm-mingw to support x86, x86_64, arm, aarch64

I wish I had enough knowledge to help build but a Win32 build sounds absolutely awesome.
Maybe it was just me but KrKrSDL2 felt quite a bit smoother and faster and KrKrZ.


Adding dotnet/core 🧚🏼  v2

Reasons for making this change:
I always need it and it is not there, that's why my contribution.
Links to documentation supporting these rule changes:
Dotnet/core
If this is a new template:
gitignore of dotnet/core

Ready @bdougie, I made the changes

@F34th3R your description is still lacking context and doesn't seem like a justifiable reason for this contribution.
Linking your previous PR https://github.com/github/gitignore/pull/3915
Please point your contribution to this DotNet folder for discoverability.


React Playing is playing another video other than the requested video

Current Behavior
React player is playing another video however the image of the light prop is correct
Expected Behavior
When I click on the play button over the image of the light, the react player should open the requested video but it is opening another video
My code
<ReactPlayer
                className='react-player'
                url={"https://youtu.be/W-jvyGyEifQ?list=RDze1pC-4mhfY"}
                width='100%'
                height='100%'
                controls
                light
            />

Environment

URL attempting to play: https://youtu.be/W-jvyGyEifQ?list=RDze1pC-4mhfY
Browser: Chrome
Operating system: Windows and Android

Other Information
I found that this issue is solved when I remove the text after the video ID in the Url.

What video are you expecting to play? It plays this for me, which is the same video that plays when I visit https://youtu.be/W-jvyGyEifQ?list=RDze1pC-4mhfY directly:

What video are you expecting to play? It plays this for me, which is the same video that plays when I visit https://youtu.be/W-jvyGyEifQ?list=RDze1pC-4mhfY directly:

@cookpete  Yess, In the demo project it's working well, but when using it in a react project, this bug is appearing!

@cookpete  Yess, In the demo project it's working well, but when using it in a react project, this bug is appearing!

The demo project is just a standard React project. There must be something specific in your implementation that is causing this.
The same thing in jsFiddle seems to work fine too: https://jsfiddle.net/t9qga4zy

The demo project is just a standard React project. There must be something specific in your implementation that is causing this.
The same thing in jsFiddle seems to work fine too: https://jsfiddle.net/t9qga4zy

@cookpete Unfortunately, it is not working fine in the JSFiddle
Open the URL and notice the name of the video, and then click on it in the JSFiddle project and notice that the opened video is something else, but the thumbnail that appears is for the correct video.

@cookpete Unfortunately, it is not working fine in the JSFiddle
Open the URL and notice the name of the video, and then click on it in the JSFiddle project and notice that the opened video is something else, but the thumbnail that appears is for the correct video.

I'm really sorry – I still don't see a problem.
When I open the link directly I get this:

When I play the link in the demo page I get this:

And when I play the jsFiddle example I get this:

All seems fine to me?

I'm really sorry – I still don't see a problem.
When I open the link directly I get this:

When I play the link in the demo page I get this:

And when I play the jsFiddle example I get this:

All seems fine to me?

This is so strange. I really can't understand what is going on.
I tried it with several browsers on several machines, desktops, and mobiles, and I am having the same result. I did not change anything with the jsFiddle project just open it and I am seeing this screen:

Then click on the video to play and another video is playing other than the price tag video.

Please, try to clear your cache and logout from youtube, and try another machine.
@cookpete I am sorry for that confusing problem! 😅

This is so strange. I really can't understand what is going on.
I tried it with several browsers on several machines, desktops, and mobiles, and I am having the same result. I did not change anything with the jsFiddle project just open it and I am seeing this screen:

Then click on the video to play and another video is playing other than the price tag video.

Please, try to clear your cache and logout from youtube, and try another machine.
@cookpete I am sorry for that confusing problem! 😅

I can partially confirm @AmmarMohamadIsmaeel, when you click on the video it is playing the first video from the playlist.  This is a playlist url and the video in the picture is the 23rd video in the playlist. So when you click it does not play the 23rd video but the first video from the playlist.
And please keep in mind that if you just put a single video link it is working as expected.

I can partially confirm @AmmarMohamadIsmaeel, when you click on the video it is playing the first video from the playlist.  This is a playlist url and the video in the picture is the 23rd video in the playlist. So when you click it does not play the 23rd video but the first video from the playlist.
And please keep in mind that if you just put a single video link it is working as expected.

Yeah I've now seen this too. Opening in incognito (not signed in to youtube) plays a completely different playlist (with 26 videos instead of 19). I have no idea why the youtube player does this.

Yeah I've now seen this too. Opening in incognito (not signed in to youtube) plays a completely different playlist (with 26 videos instead of 19). I have no idea why the youtube player does this.


Completion block runs twice for larger image sizes

When selecting an image using the following image picker, the completion block executes twice:
let controller = DKImagePickerController()
controller.assetType = .allPhotos
controller.sourceType = .photo
controller.didSelectAssets = { assets in
	let imageSize = 150
	let size = CGSize(width: imageSize, height: imageSize)
	for (index, asset) in assets.enumerated() {
		print("Fetching asset for image \(index)")
		asset.fetchImageWithSize(size) { _ in
			print("Image \(index) fetched, executing completion block.")
		}
	}
}
present(controller, animated: true, completion: nil)

The expected output would be:
Fetching asset for image 0
Image 0 fetched, executing completion block.

But the actual output is:
Fetching asset for image 0
Image 0 fetched, executing completion block.
Image 0 fetched, executing completion block.

Curiously, when changing imageSize to from 150 to 100, the issue does not occur.
For this test, I used the iOS 7 simulator and selected one of the default images from the camera roll.

Some additional info - it appears that the first time the completion block fires, it returns the image at the thumbnail size. The second time it returns the larger requested image.
Additionally, the second image does not actually match the requested size in my experience. Instead, it returns the original size I believe (I used a size of 1200x1200 but received back 1668.0 x 2500.0). I could add this as a separate issue but perhaps it is related.

This issue happens because the internal manager uses a default PHImageRequestOptions, which deliveryMode is opportunistic and resizeMode is none(client may get several image results when the call is asynchronous or will get one result when the call is synchronous).
You can call fetchImageWithSize with specific PHImageRequestOptions:
let options = PHImageRequestOptions()
options.resizeMode = .exact

asset.fetchImageWithSize(layout.itemSize.toPixel(), options: options, completeBlock: { _ in
})

This usage may not be convenient, and may give the caller ambiguity. I'll try to simplify these API more in the next version.

Feel free to reopen it if not solved.

same thing

I get the same bug ,when I do it like this:
let options = PHImageRequestOptions()
options.resizeMode = .exact

asset.fetchImageWithSize(size, options: options, completeBlock: { _ in
})

It does not work, the completionBlock is still called twice.
I did not find the synchronous API.

I'm adding
options.deliveryMode = .highQualityFormat

I found the solution if this issue and it calls only one time with high quality image
    let asset = images[indexPath.row]
    let manager = PHImageManager.default()

    var imageRequestOptions: PHImageRequestOptions{
        let options = PHImageRequestOptions()
        options.version = .current
        options.resizeMode = .exact
        options.deliveryMode = .highQualityFormat
        options.isNetworkAccessAllowed = true
        options.isSynchronous = true
        return options
    }

    manager.requestImage(for: asset,
                         targetSize: PHImageManagerMaximumSize,
                         contentMode: .aspectFit,
                         options: imageRequestOptions) { (thumbnail, info) in
                               print("High Quality Image thumbnail ! " )
                            }


Broken on 10.7.0?

Seems to be broken on 10.7.0
james@ubuntu:~/node/Gzemnid$ node gzemnid.js meta
Reading meta directory...
Package list version: Mon Aug 13 2018 13:37:48 GMT-0700 (Pacific Daylight Time).
Reading: 50000...
Reading: 100000...
Reading: 150000...
Reading: 200000...
Reading: 250000...
Reading: 300000...
Reading: 350000...
Reading: 400000...
Reading: 450000...
Reading: 500000...
Reading: 550000...
Reading: 600000...
Reading: 650000...
Total packages: 677518.
To download: 677518.
Downloading: 0-0.0.0.json...
Downloading: 0--0.0.1.json...
Downloading: 0-_-0-1.0.0.json...
Downloading: 0-----1.0.0.json...
Downloading: 0-100-0.0.2.json...
Downloading: 0-9-0.0.1.json...
Downloading: 0.-1.0.0.json...
Downloading: 0.0-0.0.0.json...
Downloading: 0.0.1-1.0.1.json...
Downloading: 0.0.168-0.0.170.json...
RSS:<PHONE_NUMBER>5 MiB
internal/buffer.js:35
    throw new ERR_OUT_OF_RANGE('value', `>= ${min} and <= ${max}`, value);
    ^

RangeError [ERR_OUT_OF_RANGE]: The value of "value" is out of range. It must be >= -2147483648 and <=<PHONE_NUMBER>. Received<PHONE_NUMBER>
    at checkInt (internal/buffer.js:35:11)
    at writeU_Int32LE (internal/buffer.js:515:3)
    at Buffer.writeInt32LE (internal/buffer.js:684:10)
    at Encoder._flush (/home/james/node/Gzemnid/node_modules/lz4/lib/encoder_stream.js:215:7)
    at Encoder.prefinish (_stream_transform.js:141:10)
    at Encoder.emit (events.js:182:13)
    at prefinish (_stream_writable.js:630:14)
    at finishMaybe (_stream_writable.js:638:5)
    at endWritable (_stream_writable.js:649:3)
    at Encoder.Writable.end (_stream_writable.js:589:5)
james@ubuntu:~/node/Gzemnid$

@jasnell This is caused by node-lz4, see https://github.com/pierrec/node-lz4/issues/62 and my PR at https://github.com/pierrec/node-lz4/pull/65.
The work-around would be to either:

Use Node.js 8.x LTS
Disable compression in config.local.json
Manually apply one-line patch from https://github.com/pierrec/node-lz4/pull/65 to the lz4 dependency in node_modules.

lz4 PR landed in master, but it has not been released yet.

@jasnell Should be fixed in a620ec9 now.


SSH task fails to delete script after execution

Troubleshooting
Checkout how to troubleshoot failures and collect debug logs: https://docs.microsoft.com/en-us/vsts/build-release/actions/troubleshooting
Environment

Server - Azure Pipelines
Account Name: nationalrestaurantassociation
Team Project Name: NRA
Release: Ping Kentico Sync - Dev (Release-1)

Agent - Private:
Agent running on Azure VM (Windows Server 2016), Agent Version: 2.144.0

Issue Description
At the end of a " Run shell commands or a script on a remote machine using SSH" task, the task issues a warning of "##[warning]Failed to delete the script file copied to the remote machine. Error = Error: Not connected." this happens a full seven hours after the task starts. The shell script gets executed correctly on the target machine, but the release stays in "active" status for hours.
Task logs
2019-01-08T21:49:26.7517058Z ##[section]Starting: Run shell inline on remote machine
2019-01-08T21:49:26.7522745Z ==============================================================================
2019-01-08T21:49:26.7522837Z Task         : SSH
2019-01-08T21:49:26.7522921Z Description  : Run shell commands or a script on a remote machine using SSH
2019-01-08T21:49:26.7523003Z Version      : 0.142.2
2019-01-08T21:49:26.7523058Z Author       : Microsoft Corporation
2019-01-08T21:49:26.7523138Z Help         : More Information
2019-01-08T21:49:26.7523200Z ==============================================================================
2019-01-08T21:49:28.1320142Z /opt/pingdir/syncdev1/bin/manage-extension --update /opt/pingdir/software/com.ctiglobal.services.sync.nra-kentico-sync-1.0.0.zip --no-prompt
2019-01-08T21:49:28.1470679Z Trying to establish an SSH connection to ***@devpingdirds1:22
2019-01-08T21:49:28.2920711Z Successfully connected.
2019-01-08T21:49:29.2556673Z tr -d '\015' <"./sshscript_1546984168130" > "./sshscript_1546984168130._unix"
2019-01-08T21:49:29.3038321Z chmod +x "./sshscript_1546984168130._unix"
2019-01-08T21:49:29.3507825Z "./sshscript_1546984168130._unix"
2019-01-09T05:30:21.7534161Z ##[warning]Failed to delete the script file copied to the remote machine. Error = Error: Not connected.
2019-01-09T05:30:21.7566743Z ##[section]Finishing: Run shell inline on remote machine
Error logs

This issue is stale because it has been open for a year with no activity. Remove the stale label or comment on the issue otherwise this will be closed in 5 days


bug: queue search is broken

I've updated to the latest version but when I type anything in the queue search bar, every queue disappears, even when the name matches exactly.

Wow, what a silly mistake I've made :/
UpperCase & lowerCase match...
I'm away from a keyboard for 2 weeks... Sorry for this.

sure, no problem :) we use ctrl + f for now.

fixed in v4.3.2


Project detection not working in PHPStorm

The plugin is working great in IntelliJ, however one of our devs uses PHPStorm, which AFAIK is Webstorm + PHP support.
When he attempts to create a new PHPStorm project from existing files, the ember project detection doesn't work.

File -> "New Project from existing files" leads to this dialog:

Select an existing ember project in the file dialog
It is detected as a Web project, but the ember.js framework is not detected.

result: no ember plugin features are enabled
Also using File -> Open and selecting the folder does not work.
Apparently this used to work at some point in the past, but it no longer does. I suspect it used to work when the plugin was using a Ember project type, before the switch to the framework.

@Ramblurr tl;dr is that we've replaced our previous framework detection with an FrameworkDetector implementation. this means that you can just open the folder of an Ember app in the IDE and it will detect Ember projects and offer to reconfigure the IDE for you.
What PHPStorm version is your dev using?

Hey,
I'm using the latest version, PhpStrom 2016.3.2, and the latest version of the Ember.js plugin.
I just tried again, just opening an ember app/addon in the IDE does not trigger the Ember.js plugin.

@mydea thanks for the feedback. I'll see if I can find out what's going on.

Oh, and as a note, I'm running Windows 10, not sure if that can have anything to do with it.

I was able to reproduce this in PHPStorm 2016.3.2

I can't seem to get the FrameworkDetector working. Maybe it's not supported in PHPStorm? I would test how the angular plugin works in PHPStorm if I had more time.
What I can do for you right now is fix our ProjectConfigurator. This would let you open an ember app in the root project folder but not detect ember projects in subdirectories.

That would be awesome and absolutely good enough.
As a side note, I've seen that e.g. Laravel has a setting that you can toggle the plugin manually, Enable this plugin for this project. Not sure if that would be an option, but it seems nice (and also makes it quite easy to check if the project detection has actually worked).

Can confirm this is is not working in PhpStorm 2016.3.2 for our devs as well. I'll try out the fork and see if that fixes it!

this should be fixed as best as we can by #127 and will be released as v2016.3.5 soon


[Bug] Failure to unmarshal some transactions from API

🐛 Bug Description
When querying transactions from the API, I occasionally get json unmarshal errors using the SDK.
In the reproduction case below, it seems the issue is related to this case:
{
  "version": "996270881",
  ...
  "changes": [
    {
      "address": "0x307401f7dd9ca5371ed820070dabaff6cf2196b500c0e359c0e388897987ca6a",
      "state_key_hash": "0x3775f4dbd6900b26cf6c833b112fdfda084f84ef4e562678ca6b54a4791063fd",
      "resource": "0x1::object::ObjectGroup",
      "type": "delete_resource"
    },
    ...
  ],
  ...
}

It looks like in the type definition, resource is defined as a MoveResource, but is returned as a string in this case
https://github.com/aptos-labs/aptos-go-sdk/blob/91228a383a9e59b313e9ba3886dd6c99c8a57b19/api/writeSet.go#L127-L132
How to reproduce
Code snippet to reproduce
package main

import (
	"log"

	aptossdk "github.com/aptos-labs/aptos-go-sdk"
)

func main() {
	client, err := aptossdk.NewClient(aptossdk.MainnetConfig)
	if err != nil {
		log.Fatalf("error connecting to api: %v", err)
	}

	start := uint64(996270881)
	limit := uint64(1)
	_, err = client.Transactions(&start, &limit)
	if err != nil {
		log.Fatalf("err: %v", err)
	}
}

Stack trace / error message
get transactions api err: json: cannot unmarshal string into Go struct field inner.changes of type api.MoveResource

Expected Behavior
The SDK should be able to parse all data returned from the official API
System information
System details:

Golang SDK Version: v0.5.0
Golang Version: v1.22.4

Additional context
Add any other context about the problem here.

Interesting, looks like it was improperly handled.  Will fix

For reference, you're talking about this transaction https://fullnode.mainnet.aptoslabs.com/v1/transactions/by_version/996270881


[Github] Additions to the README

Potentially, there is a reason for the README being almost blank. But if not, I'd suggest we start giving some more context to the open source community.

Imported from Github. Please see: https://github.com/shopware/SwagPayPal/pull/40

[public] Shopware automated response: This issue is linked to the internal issue https://shopware.atlassian.net/browse/PPI-976.
This link is only intended for Shopware employees and for internal use only.
[created from PPI-976, comment 490255]


cancel set up a new account, reopen the app will cause app crash

Expected behavior
App should open Welcome Activity.
Actual behavior
App crashed at first time, then reopen it, it will show Welcome Activity.
Steps to reproduce
1.Set up email account.
2.Cancel progress will checking incoming server.
3.Exit the app.
4.Reopen app, then app crashed.
5.Reopen app, show Welcome Activity
Environment
K-9 Mail version: master brach
Android version: API LEVEL 27
Account type (IMAP, POP3, WebDAV/Exchange):IMAP

Similar problem here (I suppose same issue?): installed K-9 (v 5.403) from F-Droid, set up account (IMAP) via wizard using default options. As soon as I click "Done" after filling out my name for outgoing messages, the app crashes. Restarting, I get "K-9 Mail keeps stopping". This is a new install on a new Android 8.0.0 phone.

Duplicate of #922


feat: include net7 in the test suit

Since .net 7 was released this week, we should also run our test suite across it

We're on the bleeding edge.


Endpoint "Not Found"

Once I configure the Endpoint, let's say as your example, using /geronimo, should I access using:
https://xxxx.herokuapp.com/geronimo
I get a "Not found" error.
Thanks!

any idea, @mushishi78?

Sorry for not replying. I was going to look into this at some point, but to be honest I haven't really looked at this stuff for a long time. I'll have to install ruby, get a heroku account, re-familiarise myself with how this project does. If it continues to be a problem for people, I totally will get round to it, but I can't promise a fast turn around, sorry.
In the meantime, if you work it out yourself, please let me know :)


Feature request: Framework support Clarity

Issue type
I'm submitting a (check one):
[ ] Bug report
[x] Feature request
[ ] Regression (something that used to work, but stopped working in a newer version)
[ ] Support request
[ ] Documentation issue or request
Prerequisites
Before posting, make sure you do the following (check all):
[x] Confirm you are using the latest versions of all necessary packages (or if not, explain why not)
[x] Search GitHub for a similar issue or PR
[x] If submitting a Support request, also search [Stack Overflow][stack-overflow] for similar issues
Note: Please cross-post GitHub support requests to [Stack Overflow][stack-overflow], and include a link in your GitHub issue to your Stack Overflow question. We do currently respond to support requests on GitHub, but we eventually expect to stop, and will then refer all support questions exclusively to Stack Overflow.
Feature description
Support for the clarity framework.
https://vmware.github.io/clarity/

I'm currently using the bootstrap framework 4  module because clarity is based on bootstrap.
With some simple css tweaks i can make it workable.
But they have plans to change it in the future see:
https://github.com/vmware/clarity/issues/1531

Hi @RobArbor, I am interested to add clarity to my Angular project. However how did you manage to achieve this? Did you just import the JS files and css files to the angular-cli json or there is still a need to import { ClarityModule } from '@clr/angular'?

@RobArbor @EricsG95
My repo supports Angular 6+, and removed support for Material Design.
Not a clean solution, but it reduces the dependencies.

I see thank you so much @RobArbor and @catull, really apprecitae your advices! Now I am also considering ngx-formly, https://github.com/formly-js/ngx-formly as a solution and then add a converter from json-schema to ngx formly defined schema. Ng6 support I think is critical, especially with the new clarity ui 0.12.

You might want to try this version https://github.com/hamzahamidi/Angular6-json-schema-form
The import however changed, you import for example Bootstrap4FrameworkModule like this, note that you shouldn't import JsonSchemaFormModule :
import { BrowserModule } from '@angular/platform-browser';
import { NgModule } from '@angular/core';

import { Bootstrap4FrameworkModule } from 'angular6-json-schema-form';

import { AppComponent } from './app.component';

@NgModule({
  declarations: [ AppComponent ],
  imports: [
    BrowserModule
    Bootstrap4FrameworkModule
  ],
  providers: [],
  bootstrap: [ AppComponent ]
})
export class AppModule { }

And you use the component like the following:
<json-schema-form
loadExternalAssets="true"
[schema]="schema"
framework="bootstrap-4"
(onSubmit)="submit($event)">
</json-schema-form>


Fix/persistence refactor fixes

fixes for comments in https://github.com/Open-MBEE/exec-mms/pull/259

still need to fix cameo tests to take out childViews


menu mod stuffs

What feature do you want to get added on the base engine?
when you are selecting a mod song in freeplay that has a custom menu BG, it switches from the base game menu BG, to the mods one. same with the mod menu.
To test your sight, and reliability, please select the option of what should NOT be requested.
Stage Editor, 6K+ support, and winning icons.

Dat sounds nice


Documentation link on google is wrong

When googling for datamol, the link given by google is
https://doc.datamol.io/
Which is missing an s in docs. It should be:
https://docs.datamol.io/
Not sure where google gets this link, but if you can make sure that all docs link are correct, it might help

ping @mercuryseries

@DomInvivo doc. has been renamed to docs. a few weeks ago so I guess it's a question of waiting for google to update its datamol index?
@mercuryseries if you can do something here, let us know.

I manually requested a reindex and removed the one with doc without the "s" at the end.
This has already taken effect in my search results.
cc @hadim @DomInvivo

Thanks Honore. Dom or manu please close if you see a fix,


Configuring a proxy for a WAMP Component not possible

Hi, I'm using a asyncio WAMP Component like described in https://autobahn.readthedocs.io/en/latest/wamp/programming.html#running-components but I can't find a way to connect via a proxy server.
It looks like the ApplicationRunner gets a proxy parameter but writing WAMP components via subclassing it is discouraged and I like the new interface better than the subclassing approach.
Is there a way to get a connection through a proxy via the "new" way?

Hi, just to fully understand the issue, could you document your 'use-case' for this? i.e. why you want or need to connect via a proxy?

@meejah FWIW, Autobahn has proxy support at the WebSocket layer via proxy argument to WebSocketClientFactory: https://github.com/crossbario/autobahn-python/blob/master/autobahn/websocket/protocol.py#L3796
We should expose that feature at the WAMP layer for both "old API" and "new API" (component). Not sure what the current status is ..

could you document your 'use-case' for this?

I'm behind a corporate firewall and the only way to connect to the internet is through a proxy. Therefore I can't connect a service running locally to a router running on AWS right now.

We should expose that feature at the WAMP layer for both "old API" and "new API" (component). Not sure what the current status is ..

In the "old API" the ApplicationRunner takes a proxy kwarg but I couldn't find anything like that in the Component API.

It probably doesn't look too hard to expose some proxy configuration via Component -- but yes currently that is not done. This is an HTTP proxy right? (Not SOCKS?)

Autobahn only supports HTTP proxies for WebSocket (so no SOCKS)

I don't see anything in the asyncio side for proxy stuff -- is this also missing currently? (i.e. is proxy support twisted-only?)

I added asyncio support in component too..


SplitButton CornerRadius

What steps will reproduce this issue?
Creating a custom-styled SplitButton and applying CornerRadius does not have any effect:
<Style x:Key="SplitButtonStyle" TargetType="{x:Type Controls:SplitButton}">
  <Setter Property="Foreground" Value="{DynamicResource TextBrush}" />
  <Setter Property="Background" Value="{DynamicResource GrayBrush10}" />
  <Setter Property="BorderBrush" Value="{DynamicResource TextBoxBorderBrush}" />
  <Setter Property="BorderThickness" Value="1" />
  <Setter Property="Controls:ControlsHelper.ContentCharacterCasing" Value="Upper" />
  <Setter Property="Controls:ControlsHelper.CornerRadius" Value="3" />
  <Setter Property="FontFamily" Value="{DynamicResource DefaultFont}" />
  <Setter Property="FontSize" Value="{DynamicResource UpperCaseContentFontSize}" />
  <Setter Property="FontWeight" Value="Bold" />
  <Setter Property="MinHeight" Value="25" />
  <Setter Property="Padding" Value="2 3" />
</Style>

...

<Controls:SplitButton Style="{StaticResource SplitButtonStyle}" />

Expected outcome
CornerRadius should be set for all corners to a value of "3"
Repo
_https://github.com/amkuchta/Vulnerator/tree/code_cleanup_
Environment

MahApps.Metro v<IP_ADDRESS>
Windows OS 10
Visual Studio 2015
.NET Framework 4.5.2

This will be available in 1.5.0

@punker76 Thanks!  Did this make the cut for 1.5.0_alpha006, or do I need to wait for 007?  Just updated to 006, and it still isn't working, which is why I am asking.


AdvDupe2 creating strange (invisible) props when duping some objects (like wire hydraulics)

Here is an example (on the left, the normal prop before being duped, on the right, the ghosted one just copied). Under the chair there is a wire hydraulic. As long as you paste the duplication, there will be that prop (but invisible) which will prevent the hydraulic to work, until you grab the invisible prop with the physgun (and it will disappear).

It happens also with other wiremod and non-wiremod stuff (like WAC entities or some vehicles).
Sorry for posting if this is an already-known bug.

Seems like an addon conflict. I've never seen this before.

I have tried disabling all the addons and activating only AdvDupe2 and Wiremod, the "prop" is still there:

Steps to reproduce (for the example above):

Freeze a prop in mid air (better a flat surface, like a plate)
Pick the Hydraulic tool from the Physics/Constraints Wiremod menu
Right-click the bottom part of the plate, so that it "places an hydraulic along the hit normal"
Pick the Advanced Duplicator 2 tool
Shift + right-click and then right-click to area copy the plate with the hydraulic

(Before)

As you can see, the prop is there and it also has collisions; just after you select it with the physgun, it disappears.
(After)

I followed your steps and still didn't get the bug.

Found it! It happens when the hydraulic is "Fixed".

Yeah, I tried with 'fixed' hydraulics and it still didn't happen.

Seems like there's something weird with your slider constraint. Maybe some mod in your lua folder or something.

Maybe check if a script modified your slider function?
>lua_run PrintTable(debug.getinfo(constraint.Slider))

What's this print?

Here is the print:
currentline	=	-1
func	=	function: 0x00c49468
isvararg	=	false
lastlinedefined	=	778
linedefined	=	698
namewhat	=
nparams	=	8
nups	=	2
short_src	=	lua/includes/modules/constraint.lua
source	=	@lua/includes/modules/constraint.lua
what	=	Lua

However, this is my AdvDupe2+Hydraulic settings, maybe it can help reproducing the problem.
Advanced Duplicator 2:

[ ] Paste at original position
[X] Paste with constraints
[X] Paste with parenting
[ ] Unfreeze all after paste
[ ] Preserve frozen state after paste
[ ] Area copy constrained props outside of box
[X] World/Area copy only your own props

Ghost percentage: 100
Area Copy Size: 300

Experimental:

[ ] Disable parented props physics interaction
[X] Disable dupe spawn protection
[X] Open file after Saving

Wire hydraulic:
(Model: nano)

[ ] Winch Mode (Stretch Only)
[X] Fixed

In/Out Speed Mul: 4
Width: 1

Can you copy the thing, then tell me what this prints?
>lua_run PrintTable(Entity(1).AdvDupe2.Entities)

Can you also paste your contraption, copy it again with that glitched prop, and tell me what they print.

First duplication
Print 1
184:
		BuildDupeInfo:
				IsNPC	=	false
				IsVehicle	=	false
		Class	=	gmod_anchor
		CollisionGroup	=	0
		Model	=	models/combine_helicopter/helicopter_bomb01.mdl
		PhysicsObjects:
				0:
						Angle	=	0.000 0.000 360.000
						Pos	=	8.101334 -3.623474 -97.302811
185:
		Class	=	prop_physics
		CollisionGroup	=	0
		Model	=	models/props_phx/construct/glass/glass_angle360.mdl
		PhysicsObjects:
				0:
						Angle	=	0.000 -45.000 -0.000
						Pos	=	0.000000 0.000000 0.000000
187:
		BuildDupeInfo:
				IsNPC	=	false
				IsVehicle	=	false
		Class	=	gmod_wire_hydraulic
		CollisionGroup	=	20
		EntityMods:
				WireDupeInfo:
						Wires:
		Model	=	models/beer/wiremod/hydraulic_nano.mdl
		MyId	=	187
		PhysicsObjects:
				0:
						Angle	=	0.000 0.000 360.000
						Pos	=	19.914688 -6.416962 -97.052841

Print 2
1:
		BuildDupeInfo:
				Ent1Ang	=	0.000 -45.000 -0.000
		Entity:
				1:
						Bone	=	0
						Index	=	185
						LPos	=	8.290695 3.166316 0.223148
				2:
						Bone	=	0
						Index	=	0
						LPos	=	8.101334 -3.623474 -97.302811
						World	=	true
		LPos1	=	8.290695 3.166316 0.223148
		LPos2	=	8.101334 -3.623474 -97.302811
		MyCrtl	=	187
		Type	=	WireHydraulic
		fixed	=	1
		material	=	cable/cable2
		speed	=	4
		stretchonly	=	false
		width	=	1

Second duplication
(Copy of the already duped one)
Print 1
186:
		BuildDupeInfo:
				IsNPC	=	false
				IsVehicle	=	false
		Class	=	gmod_anchor
		CollisionGroup	=	0
		Model	=	models/combine_helicopter/helicopter_bomb01.mdl
		PhysicsObjects:
				0:
						Angle	=	0.000 0.000 0.000
						Pos	=	0.000000 0.000000 0.000000
188:
		Class	=	prop_physics
		CollisionGroup	=	0
		Model	=	models/props_phx/construct/glass/glass_angle360.mdl
		PhysicsObjects:
				0:
						Angle	=	0.000 -45.000 360.000
						Pos	=	-8.101334 3.623474 97.302811
189:
		BuildDupeInfo:
				IsNPC	=	false
				IsVehicle	=	false
		Class	=	gmod_wire_hydraulic
		CollisionGroup	=	20
		EntityMods:
				WireDupeInfo:
						Wires:
		Model	=	models/beer/wiremod/hydraulic_nano.mdl
		MyId	=	189
		PhysicsObjects:
				0:
						Angle	=	0.000 0.000 0.000
						Pos	=	11.813354 -2.793488 0.249969
192:
		BuildDupeInfo:
				IsNPC	=	false
				IsVehicle	=	false
		Class	=	gmod_anchor
		CollisionGroup	=	0
		Model	=	models/combine_helicopter/helicopter_bomb01.mdl
		PhysicsObjects:
				0:
						Angle	=	0.000 0.000 360.000
						Pos	=	0.000000 0.000000 0.000000

Print 2
1:
		BuildDupeInfo:
				Ent1Ang	=	0.000 -45.000 -0.000
		Entity:
				1:
						Bone	=	0
						Index	=	188
						LPos	=	8.290695 3.166316 0.223148
				2:
						Bone	=	0
						Index	=	0
						LPos	=	8.101334 -3.623474 -97.302811
						World	=	true
		LPos1	=	8.290695 3.166316 0.223148
		LPos2	=	8.101334 -3.623474 -97.302811
		MyCrtl	=	189
		Type	=	WireHydraulic
		fixed	=	1
		material	=	cable/cable2
		speed	=	4
		stretchonly	=	false
		width	=	1

As you can see, it continuously keeps recreating the helicopter_bomb01 model, right where the start of the hydraulic is.

Okay, now I can see the problem. The prop protection I was using was preventing me from copying the gmod_anchor. Let me look at that entity and see what can be done.

You can add ENT.DoNotDuplicate = true to gamemodes/sandbox/entities/entities/gmod_anchor.lua to fix this. Or use a prop protection that has that entity blacklisted (most do). I'll make a PR to garrysmod to add that fix.

Ok, thanks for your support.

That fix works for fixed hydraulics but breaks normal sliders, I gotta find another fix.

If you copy the code from here https://github.com/Facepunch/garrysmod/pull/1476/files , it should fix the problem. You can also use a prop protection to keep from area copying the gmod_anchor.


MigrateStatusTest::testMigrateAllWithWithTwoNamespaces fails

Rarely fails.
1) CodeIgniter\Commands\Database\MigrateStatusTest::testMigrateAllWithWithTwoNamespaces
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 '+---------------+-------------------+--------------------+-------+---------------------+-------+
 | Namespace     | Version           | Filename           | Group | Migrated On         | Batch |
 +---------------+-------------------+--------------------+-------+---------------------+-------+
-| App           | 2018-01-24-102301 | Some_migration     | tests | YYYY-MM-DD HH:MM:SS | 1     |
+| App           | 2018-01-24-102301 | Some_migration     | tests | YYYY-MM-DD HH:MM:SS | 2     |
 | Tests\Support |<PHONE_NUMBER>2500    | Create_test_tables | tests | YYYY-MM-DD HH:MM:SS | 1     |
 +---------------+-------------------+--------------------+-------+---------------------+-------+

 '

/Users/kenji/work/codeigniter/CodeIgniter4/tests/system/Commands/Database/MigrateStatusTest.php:87

I can't reproduce this issue, this issue can be passed now.

I was able to reproduce.
$ ./phpunit tests/system/Session/
...
ERRORS!
Tests: 61, Assertions: 101, Errors: 4, Skipped: 6.

I don't have Redis server, so 4 errors occur.
$ ./phpunit tests/system/Commands/Database/MigrateStatusTest.php
PHPUnit 9.5.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.1.13
Configuration: /Users/kenji/work/codeigniter/official/CodeIgniter4/phpunit.xml

F.                                                                                2 / 2 (100%)

Time: 00:00.229, Memory: 16.00 MB

There was 1 failure:

1) CodeIgniter\Commands\Database\MigrateStatusTest::testMigrateAllWithWithTwoNamespaces
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 '+---------------+-------------------+--------------------+-------+---------------------+-------+
 | Namespace     | Version           | Filename           | Group | Migrated On         | Batch |
 +---------------+-------------------+--------------------+-------+---------------------+-------+
-| App           | 2018-01-24-102301 | Some_migration     | tests | YYYY-MM-DD HH:MM:SS | 1     |
+| App           | 2018-01-24-102301 | Some_migration     | tests | YYYY-MM-DD HH:MM:SS | 2     |
 | Tests\Support |<PHONE_NUMBER>2500    | Create_test_tables | tests | YYYY-MM-DD HH:MM:SS | 1     |
 +---------------+-------------------+--------------------+-------+---------------------+-------+

 '

/Users/kenji/work/codeigniter/official/CodeIgniter4/tests/system/Commands/Database/MigrateStatusTest.php:100

FAILURES!
Tests: 2, Assertions: 2, Failures: 1.

I cannot replicate this on Windows, even repeating the test 100 times.
$ vendor/bin/phpunit --filter MigrateStatusTest --repeat 100
PHPUnit 9.6.9 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.2.6 with Xdebug 3.2.0
Configuration: C:\Users\P\Desktop\Web Dev\CodeIgniter4\phpunit.xml

...................................................................................................................................... 134 / 300 ( 44%)
...................................................................................................................................... 268 / 300 ( 89%)
................................                                                                                300 / 300 (100%)

Time: 00:54.344, Memory: 72.00 MB

OK (300 tests, 500 assertions)

Generating code coverage report in Clover XML format ... done [00:00.623]

Generating code coverage report in HTML format ... done [00:07.242]

Certainly, I can't reproduce it now.
$ ./phpunit tests/system/Session/
...
$ ./phpunit tests/system/Commands/Database/MigrateStatusTest.php
PHPUnit 9.6.9 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.1.20
Configuration: /Users/kenji/work/codeigniter/official/CodeIgniter4/phpunit.xml

..                                                                                2 / 2 (100%)

Time: 00:00.126, Memory: 18.00 MB

OK (2 tests, 2 assertions)

This does not seem to be a timing issue, but rather an error caused by a change in state due to a previous test.
However, since it is not reproduced, I close it for now.


runtime: make the page allocator scale

Over the course of the last year, we've seen several cases where making relatively minor changes to the allocator slow path, which allocates pages from the heap, caused serious performance issues (#32828, #31678). The problem stemmed largely from contention on the heap lock: a central m-based spinlock (so we can't schedule another g while it's waiting!) which guards nearly all operations on the page heap. Since Go 1.11, (and likely earlier) we've observed barging behavior on this lock in applications which allocate larger objects (~1K) frequently, which indicates a collapsing lock. Furthermore, these applications tend to stay the same or worsen in performance as the number of available cores on the machine increases. This represents a fundamental scalability bottleneck in the runtime.
Currently the page allocator is based on a treap (and formerly had a small linked-list based cache for smaller free spans), but I propose we rethink it and rewrite to something that:

Is more cache-friendly, branch-predictor friendly, etc. on the whole.
Has a lockless fast path.

The former just makes the page allocator faster and less likely to fall into bad paths in the microarchitecture, while the latter directly reduces contention on the lock.
While increased performance across the board is what we want, what we're most interested in solving here is the scalability bottleneck: when we increase the number of cores available to a Go application, we want to see a performance improvement.
Edit: Design doc
I've already built both an out-of-tree and in-tree prototype of a solution which is based on a bitmap representing the whole heap and a radix tree over that bitmap. The key idea with bitmaps here being that we may "land grab" several pages at once and cache them in a P. Two RPC benchmarks, a Google internal one, and one based on Tile38, show up to a 30% increase in throughput and up to a 40% drop in tail latencies (90th, 99th percentile) on a 48-core machine, with the benefit increasing with the number of cores available to the benchmark.

Gopherbot isn't updating the issue with this, but the design doc is at @ https://go-review.googlesource.com/c/proposal/+/202857. I'll update the first post in the issue once it lands.
CC: @aclements @randall77 @cherrymui

https://github.com/golang/go/issues/31222
May be relative

@un000 It's possible but unlikely this will help.
Let's assume that the problem in that issue is fully that a long allocation blocks STW for 43 ms. Firstly, 100 MB allocations don't really get any faster with this proposal. In that issue, asking for 100 MB is definitely going to go to the OS and map pages in. No matter what we're bound by how quickly we can get 100 MB worth of committed address space from the OS.

@un000 Well, it helps maxWait at least and brings it down to 1.0s vs. 1.3s on my machine, so perhaps I spoke too soon.
But I'm having hitting stalls trying to copy the traces to verify whether there's an improvement in the STW delay. I'll try again later and let you know what I found.

Thank you, Michael! ~25% performance is awesome too.

@mknyszek Anything else to do for this issue?

Nope! Closing.


nixpkgs docs: breakout functions

Motivation for this change
Extracts the massive functions.xml in to topic files.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

Backported to 18.09 in 3b739c0daf1b8e14ead8b16199b6913c9c16616c b66df5c45d70590745eec407742e3f81bfbd7642 05519f21fc1f845d9ebf60f0ac0d44cdbea74d38 191745989c1c51f4ceba7e00606d12c47c2cba0f 7413dce611edebcd41cdcacbb254d0902635b0a3 5954454dd1da9be8d7791bd8ebede3beee99a3d9 ce5e6466b62d7d3803463c5a17e52aaf49dab8b3 4a0da7f3ac5632b2ad3ebcb97dd329663f195f2b e13c2086659b5ec02fcc3286507705bccbab34a1.


Feature: Pick/Take Video and Photo at same time

Hi James,
thank you very much for your great work! We like it very much and really reduce many repeative Jobs.
I wonder if it is possible to pick Video and Photo at same time.
As long as i know if the Mime type is set as "image/* video/*" it is OK in android OS.
I have no Idea how they are in iOS and other platform.
But at least just for Android will be a great help. ( A simple Galary menu as 2 separate "Pick video" "Pick Image" menu is already reduce some Redundanz)
Further if the library can give a chance to Take Video and Video with one action(function) will be perfect!
Best regards!

@fasihi-zhuoxiu

Further if the library can give a chance to Take Video and Video with one action(function) will be perfect!

Could you elaborate this feature request? How it should work?
What are the use cases where you want to access Video and Photo at the same time?

@prashantvc
Hi, i have only idea about this in Android Platform:
Intent intent = new Intent(Intent.ACTION_PICK, Media.EXTERNAL_CONTENT_URI);     intent.setType("video/*,image/*");
With this intent it give user a chance to pick image and video together(if there are app support this feature).
In this way we could reduce 1 button in UI.

Will not implement as the default controls don't work this way.


Enable MacOS, WatchOS and tvOS platforms

Hi.
So I was wondering if there is a chance to enable this in the library.
From a look into the library I believe your iOS code doesn't need any change and there is just the need to add this platforms to your build.gradle.kts.
watchOS | watchosArm32, watchosArm64, watchosX86, watchosX64, watchosSimulatorArm64
tvOS | tvosArm64, tvosX64, tvosSimulatorArm64
macOS | macosX64, macosArm64
Have you tried this and is there an issue?

We haven't tried yet, but we would need to make https://github.com/ACINQ/secp256k1-kmp available on these platforms and there may be issues with arm targets.

Oh I see. Well iOS is arm64 since a long time, just the iOS simulator was x86_64.
Mac is actually playing catch up at this point with the new M1's.
So if you guys have problems with macosx64 just activating the macosArm64 should work I think (same for Apple TV and Watch OS).
FYI you can also enable the iosSimulatorArm64. As apparently it's not added when you just target 'ios'. I went to do some digging.

If that's a feature that's useful to you, feel free to open a PR for it!

Perfect will do so :)

Perfect will do so :)

Did you have any luck with iosSimulatorArm64 yet?
I have the same issue, converted my KMM project to support it, but now I am stuck being unable to use this project. Not quite sure what the issue is. But probably related to me not understanding the nitty gritty of gradle plays a large role :)

We support macos (x64 and arm64) and iosSimulatorArm64, but we don't have plans to support WatchOS and tvOS.


SerialPortStream.ReadLine() stops reading data

My software reads from a device that permanently sends ASCII lines (CR+LF) at 4800,8N1 no flow control.
So it basically executes a loop calling SerialPortStream.ReadLine() which works fine most of the time.
However, sometimes ReadLine() fails and throws TimeoutException. This may be caused by the device and is not the actual problem. Is is also no problem if some lines get lost. The problem is that afterwards ReadLine() never returns data but always throws TimeoutException although the device continues to send (btw, the read timeout = 500ms). I found a workaround which 'fixes the stream' by reading some bytes via SerialPortStream.Read(byte[] buffer, int offset, int count) in case of TimeoutException. This call returns data and afterwards ReadLine() works as expected again.
So I'd expect ReadLine() to return the next available line after it timed out.

Thankyou. To get further to the root cause of the problem, could you please provide .NET traces enabling the ReadTo and the serial port traces? This may help me to identify where it's getting blocked.

Hello, are you able to capture .NET traces of the error and attach them to the ticket?

Thanks for your dedicate reply. I did not yet find the time to do so but I will check as soon as possible.

Hello, have you found the time since reporting the issue to reproduce and to capture logs?

My team is running into a similar problem. After a while (usually weeks),  our process stops reading from devices. We're working on a repro, but it's difficult given how long it takes for the issue to manifest. Will report back as soon as we have something.

Experiencing a long-running issue on Linux as well... seems to work fine and then several days later reads start failing.
2018-12-17 17:11:26.3045 Error reading from serial port: System.ArgumentException: offset and count exceed buffer boundaries
at RJCP.IO.Ports.SerialPortStream.ReadCheck(Byte[] buffer, Int32 offset, Int32 count)
at RJCP.IO.Ports.SerialPortStream.Read(Byte[] buffer, Int32 offset, Int32 count

Do you have logs captured that you can post?


Aurora shows an error (crash) message when opened

What are you experiencing an issue with?

[x] Aurora
[ ] Aurora supported game, (Fill in the game)
[ ] Aurora Wrapper
[ ] Aurora Profile
[ ] Aurora supported device, (Fill in problematic devices)
[ ] Aurora Scripts
[ ] Aurora Updater
[ ] Aurora Lighting issue
[ ] Other, (Fill in another issue here)

What kind of an issue is it?

[x] Crash
[ ] Performance problems
[ ] Visual bug
[ ] Localization issue
[ ] Enhancement suggestion
[ ] Device issue
[ ] Other, (Fill in another type of issue here)

Expected behavior:
Aurora starts
Actual behavior:
A crash message shows
How often does this problem occur?

This problem occurs... (everytime I start Aurora)
Please describe the steps to reproduce this issue:
The issue can be reproduced by doing following steps:

Open Aurora

What is the version of Aurora you are experiencing this issue with?

My version is... (0.6.0b but shows in all versions)
Does the previous version of Aurora have this issue?
The previous version, (0.6.0), did have this issue.
Please include any logs, screenshots, or files that are related to this issue:

For logs, you can use: https://pastebin.com/fWyQseL9
For screenshots, you can use: http://imgur.com/a/7SDI9

I deleted 2 files from %appdata%/roaming/aurora and now it works


REALMC-12640: Parse app meta config

REALMC-12640
Tasks Completed

Defined .mdb/app_meta.json schema
Modified FindApp to search for .mdb/app_meta.json when looking for root directory/config files
Skipped group ID/app ID resolve calls whenever AppMeta is populated by a command
Stubbed out /push command.

Note: I'm not sure what to do beyond just creating the Push and DoPush methods in import.go. We use empty interface to pass the POST body to the endpoint so I can't validate that config version is one of those fields, and because the endpoint isn't live yet I wasn't sure how to go about testing. I'd appreciate some input on this part of the PR.

fyi @jandersongo ... I spoke with nathan offline and I'll be stealing his branch here to get this across the finish line.
I'll do my best to incorporate your latest review before I push up to my fork for another round of reviews!

closing in favor of #292