Add CORS headers to http responses

This adds CORS headers to HTTP responses.
This closes #638
@tiero @altafan please review.

what about grpc-web requests? Are them already responding with cors headers?

Also what about max-age @altafan ? could that be important to be set with Tor deployment that can take more than 5 second to respond? (I think here is just to avoid to much preflight request in case of latency)

what about grpc-web requests? Are them already responding with cors headers?

grpcweb pjg already takes care of cors headers

what about Access-Control-Allow-Methods

it's actually missing.. we should allow only GET, POST?

what about Access-Control-Allow-Methods

Added


Incorrect documentation example for client-server test

Version
4.0.3
Context
I recently encountered some occasional issues with testing client-server communication. I used the the test setup from the documentation like:
    Checkpoint serverStarted = testContext.checkpoint();
    Checkpoint requestsServed = testContext.checkpoint(10);
    Checkpoint responsesReceived = testContext.checkpoint(10);

    vertx.createHttpServer()
      .requestHandler(req -> {
        req.response().end("Ok");
        requestsServed.flag();
      })
      .listen(8888)
      .onComplete(testContext.succeeding(httpServer -> serverStarted.flag()));

    HttpClient client = vertx.createHttpClient();
    for (int i = 0; i < 10; i++) {
      client.request(HttpMethod.GET, 8888, "localhost", "/")
        .compose(req -> req.send().compose(HttpClientResponse::body))
        .onComplete(testContext.succeeding(buffer -> testContext.verify(() -> {
          assertThat(buffer.toString()).isEqualTo("Ok");
          responsesReceived.flag();
        })));
    }

When running those test there were some occasional failures with stack traces like:
io.netty.channel.AbstractChannel$AnnotatedConnectException: Connection refused: localhost/<IP_ADDRESS>:41057
Caused by: java.net.ConnectException: Connection refused

Unfortunately, most of the time those failures happened only on our CI system and I first assumed some firewall configuration problems. However, I think the code snippet above is wrong. The clients may send requests to the server while it is still starting up and cause the above mentioned stack trace. Moving all client calls in the onComplete of the server creation fixed the problem and I haven't encountered it since then (I assume that our CI system is just slower in processing events from the event loop). Therefore I propose to change the example above to the following:
    Checkpoint serverStarted = testContext.checkpoint();
    Checkpoint requestsServed = testContext.checkpoint(10);
    Checkpoint responsesReceived = testContext.checkpoint(10);

    vertx.createHttpServer()
      .requestHandler(req -> {
        req.response().end("Ok");
        requestsServed.flag();
      })
      .listen(8888)
      .onComplete(testContext.succeeding(httpServer -> {
        serverStarted.flag();

        HttpClient client = vertx.createHttpClient();
        for (int i = 0; i < 10; i++) {
          client.request(HttpMethod.GET, 8888, "localhost", "/")
            .compose(req -> req.send().compose(HttpClientResponse::body))
            .onComplete(testContext.succeeding(buffer -> testContext.verify(() -> {
          assertThat(buffer.toString()).isEqualTo("Ok");
          responsesReceived.flag();
        })));
    }
       }));

Do you have a reproducer?
Vertx Junit5 Examples
I think this might be related to https://github.com/vert-x3/vertx-junit5/issues/96 in a sense that the http server, started in BeforeEach hooks, are not yet up when the clients may already send requests. I assume this might occur more frequently on CI system that are slower in processing events in the event loop.
Steps to reproduce

run those tests multiple times until a failure occurs (while [ $? -eq 0 ]; do mvn clean test; done).

Extra
I offer to submit a PR if this proposal is accepted
~ java -version
openjdk version "11.0.10" 2021-01-19
OpenJDK Runtime Environment (build 11.0.10+9-Ubuntu-0ubuntu1.20.04)
OpenJDK 64-Bit Server VM (build 11.0.10+9-Ubuntu-0ubuntu1.20.04, mixed mode, sharing)
~ uname -a
Linux Colter 5.8.0-50-generic #56~20.04.1-Ubuntu SMP Mon Apr 12 21:46:35 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Could you please open pull-request?


ColumnChart with MergeMode.Grouped does not receive callback for all the series added through CartesianMarkerVisibilityListener

How to reproduce
Create a ColumnChart with two series, add a marker and CartesianMarkerVisibilityListener. Drag across all the columns/bars
Observed behavior
We are getting a single callback for both entries in the series.
Expected behavior
I expect a callback for both the columns...even with the same x value.
Vico version(s)
alpha19
Android version(s)
14
Additional information
No response

Hello! When a stack is marked, a single CartesianMarker is shown a single time, and so CartesianMarkerVisibilityListener#onShown is called once (which is in agreement with its documentation). However, information on both marked columns is provided. Specifically, targets contains one ColumnCartesianLayerMarkerTarget with two ColumnCartesianLayerMarkerTarget.Columns, one for each column. Each ColumnCartesianLayerMarkerTarget.Column contains its corresponding column’s ColumnCartesianLayerModel.Entry. You can confirm the number of ColumnCartesianLayerMarkerTarget.Columns by evaluating the following:
(targets[0] as ColumnCartesianLayerMarkerTarget).columns.size

I’ll thus be closing this issue. If you have any questions, let me know. Cheers!

Hello! Thanks for the report. We’ll look into it.
I previously misread the issue and thought that it referred to expected behavior, leading me to close it. I’ve now reopened the issue. Apologies for the confusion.

Hello, Vico 2.0.0-alpha.21 fixes this. Remember to override both onShown and onUpdated to receive all of the required callbacks.


Fix namespace conflict after addition of recent OIIO::debug()

never mind. I think this just shows I need a better name on the other side.
ignore this.


python310Packages.Cython: 0.29.34 -> 0.29.36

https://github.com/cython/cython/blob/0.29.x/CHANGES.rst
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

The changelog link should be https://github.com/cython/cython/blob/0.29.36/CHANGES.rst.

I updated that extra for you


Added output to acknowledge invalid commands

CHANGELOG :memo:

PRINTS(OPTIONAL)

LABELS
enhancement

Example: enhancement, wip etc

Fixes: Issue #7

Thank you for allowing me to contribute! I am very new to working with TypeScript, so please let me know if there are any further changes that could me made.

Hello @krisstee !! Thank you about your contribution! Let me review it

@krisstee You did it! I'll merge in! Thank you! :tada: :tada: :tada:


Add positive_score_impact support for rank_features

Description
Added support for positive_score_impact parameter for rank_features
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

start gradle check

Admins please restart build... since failed test completed ok locally and changes also works good here https://github.com/opensearch-project/OpenSearch/pull/2725

Please fold the above PR feedback into #2725. We will not be merging this into 1.x since there will be no 1.4 release.

I'll close this and leave https://github.com/opensearch-project/OpenSearch/pull/2725. Once in main we can talk about how far we want to backport it.


Add Feature: Read Integer

I was recently reading a file and wanted to read one column as an integer as follows:
data= read_excel("", sheet = 1,col_names = TRUE,col_types = c("text","integer","numeric","blank"),na="N/A")
It seems to me, that their is no way of reading integers. When I specify the column as "numeric" the data is cast to a double. It would be nice to read data as integer.
If this is already and I am just not implementing it correctly I apologize.

Covered by #198


Sprite frame buffer question

Hi!
It's not really an issue, but a question: is there any reason why a line buffer cannot be used for the sprite layer? I'm sure the original arcade machine didn't use a buffer for the whole frame (as non of the sprite machines used that). It consumes huge BRAM resources, makes your otherwise great core porting to other platforms hard.

@gyurco I'm really sorry, I don't know how I missed this issue.
Are you sure about this?
I own a Rygar PCB and from what I can tell there is a dual frame buffer used for the sprites.
If these were only used as line buffers, then why would they need so much RAM?

@gyurco I'm really sorry, I don't know how I missed this issue.
Are you sure about this?
I own a Rygar PCB and from what I can tell there is a dual frame buffer used for the sprites.
If these were only used as line buffers, then why would they need so much RAM?

That's an interesting and unusual (and probably an expensive for its time) design. But I'm still not sure if LREAD and RREAD is toggling by every line or every frame (as these select between the two banks). The clock for the flip-flop which generates them is disabled in VBL (clk = ~vbl & h_v_cont), thus it can be toggled only in the active area (by H.V.CONT, which I don't know what it is).

That's an interesting and unusual (and probably an expensive for its time) design. But I'm still not sure if LREAD and RREAD is toggling by every line or every frame (as these select between the two banks). The clock for the flip-flop which generates them is disabled in VBL (clk = ~vbl & h_v_cont), thus it can be toggled only in the active area (by H.V.CONT, which I don't know what it is).

I found the full schematics, looks like the H.V.CONT is the BLANK (composite) clocked by the SP.CONT (or SP.COUNT in the first page, where the counters are) signal.
SP.COUNT is zero when {HC,HB,HA}=5, thus in every 8th pixel. That means H.V.COUNT is basically composite BLANK synced to a certain position in the horizontal counter (when HC goes from 5 to 6).
If it's the composte BLANK, then LREAD and RREAD are toggled in every line - DRAMs (for read at least) used as a dual-line buffer.
More interesting is the address generator for these DRAMs (CR0-7 and CL0-7).
The address generator seems to feed Y and X (either from the HV counters or the sprite RAM logic), selected again by LREAD and RREAD (so the mode toggles in every line).
Prbably Y used for the RAS address, and X for the CAS address. So the DRAMs are storing the sprites for the whole frame, but really used as a dual-line buffer.

I found the full schematics, looks like the H.V.CONT is the BLANK (composite) clocked by the SP.CONT (or SP.COUNT in the first page, where the counters are) signal.
SP.COUNT is zero when {HC,HB,HA}=5, thus in every 8th pixel. That means H.V.COUNT is basically composite BLANK synced to a certain position in the horizontal counter (when HC goes from 5 to 6).
If it's the composte BLANK, then LREAD and RREAD are toggled in every line - DRAMs (for read at least) used as a dual-line buffer.
More interesting is the address generator for these DRAMs (CR0-7 and CL0-7).
The address generator seems to feed Y and X (either from the HV counters or the sprite RAM logic), selected again by LREAD and RREAD (so the mode toggles in every line).
Prbably Y used for the RAS address, and X for the CAS address. So the DRAMs are storing the sprites for the whole frame, but really used as a dual-line buffer.


Updated document-generator Socket

Codecov Report

Merging #2 into master will decrease coverage by 4.16%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
- Coverage    37.5%   33.33%   -4.17%
==========================================
  Files           2        2
  Lines          24       24
  Branches        8        8
==========================================
- Hits            9        8       -1
- Misses         15       16       +1

Impacted Files
Coverage Δ

src/generate.ts
83.33% <100%> (-16.67%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fb6b5e...a2c111d. Read the comment docs.

Changes applied.


Fixed issue with html on AboutDialog.java

I opened an issue, like advised in some other projects, #1290.
Now, here is my fix. it uses the deprecated method for older versions of android (tested on Samsung Galaxy Nexus (API 18)), and uses the new method for android N and higher (tested on ZTE Axon 7 (API 24)).

Refer to this: http://stackoverflow.com/a/37905107/4276951 for more information

This isn't necessary, just pass true as the second parameter of .content(...)


[flow] unused suppression in beta 6

Problem description
I have the following error related to flow:
Error: node_modules/material-ui/Card/Card.js.flow:21
 21: // $FlowFixMe - invalid error? claims raised prop is missing
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error suppressing comment. Unused suppression

Steps to reproduce

Install version beta.6.
Enter the command flow.

Versions

Material-UI: 1.0.0-beta.6,
Flow-bin: 0.52.0

You need to suppress this comment:
https://github.com/callemall/material-ui/blob/099920cc0e14a2ff44c5e925ddb28c376fecd599/.flowconfig#L32

@oliviertassinari that's not the issue here. Flow checks when a suppression comment exists that's unnecessary. What the error is saying is that it found a suppression comment ($FlowFixMe), but it's above a line that doesn't actually throw an error in the first place.

Could that be a flow missmatch version issue or we can simply remove the comment?

Flow may have fixed a bug, which means the suppression is now unnecessary, so we just remove it.
Regardless, this will probably get fixed as #7788 is fixed (in progress today).


how to create an audio stream

I want to construct an audio input stream with a sampling rate of 48000，apkt is an audio generator packet with a sampling rate of 44100，how to specify pts?
......
auto aframe = apkt.get<bmf_sdk::AudioFrame>();
bmf_sdk::AudioFrame af(aframe.planes(), aframe.layout(), aframe.planer());
af.set_sample_rate(aframe.sample_rate());
af.set_time_base(aframe.time_base());
af.set_pts(_video_time_stamp);
auto pkt_audio = Packet(af);
_video_time_stamp += 1024;
_main_pipeline->FillPacket(_audio_enc_in_stream->GetName(), pkt_audio);
......
The result of the above operation is wrong
af.set_pts(_video_time_stamp);->af.set_pts(frame.pts()); is ok in single audio stream，but i need to maintain time stamp for multi input audio stream

To implement the resample functionality, you can resample the audio stream using FFmpeg's aresample filter, with a command like audio_stream.ff_filter('aresample', '48000').
If you choose not to use this approach, you would need to implement resampling internally. In this case, the AVFrame PTS should be adjusted based on the number of samples in the frame, and the AVPacket PTS is typically calculated as the number of samples divided by the sample rate, multiplied by 1e6 to convert it to microseconds.

To implement the resample functionality, you can resample the audio stream using FFmpeg's aresample filter, with a command like audio_stream.ff_filter('aresample', '48000').
If you choose not to use this approach, you would need to implement resampling internally. In this case, the AVFrame PTS should be adjusted based on the number of samples in the frame, and the AVPacket PTS is typically calculated as the number of samples divided by the sample rate, multiplied by 1e6 to convert it to microseconds.

Thank you for your answer. In my case, pts should be set to the value of nsamples()


Ref master cannot be resolved

Description
It's been a while since github changes 'master' branch name to 'main'. It seems like whatever I try config server tries to pull from branch name 'master' so that we get the error message 'Ref master cannot be resolved'. I put spring.cloud.config.server.git.default-label: main, I got no success.
Sample
spring:
  cloud:
    config:
      server:
        git:
          uri: private-repo-url
          default-label: main
          username: uname
          password: pwd
          clone-on-start: true

I have registry.yml on my repo. When I try to URL/registry/default/main, or either URL/registry/default I get the above exceptions.

It's just printing a warning message most likely.  Does the config server still work, can it serve the configuration?

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Doc.test.2

missing files needed for doc.test.1.
doc.test.1 and doc.test.2 include all changes. all previous pull  requests should be ignored.
I would delete previous pull requests but i do not think i have permissions. if i do, i shouldn't as i am not a comitter for steppy.
Regards Bruce Cottman
p.s. I am going to work on more .py contributions to steppy-tools now.

nevermind.. i just closed previous pull requests .

Hi @bcottman,
I can see that you closed #24 with Scalers. So what is the current state of scalers and their docs? Are all the changes in scalers included in this PR?
Best,
Kamil

Yes. Look at rather long winded PR doc.test.1 and test.doc.2. They include closed PR. Also Pr I Steppy-tools
Regard bruce

On Oct 4, 2018, at 11:42 AM, Kamil A. Kaczmarek<EMAIL_ADDRESS>wrote:
Hi @bcottman,
I can see that you closed #24 with Scalers. So what is the current state of scalers and their docs? Are all the changes in scalers included in this PR?
Best,
Kamil
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Map on loading page doesn't show any Energy Plus Files anymore

Displays all the OneBuilding.org files!

Doesn't show any Energy Plus Files anymore....

are issues with memes allowed?

yes, they are allowed 🙂 .
@giobetti I have removed them since they were overlapping and the user could only select one anyway. Is this a problem? Aren't the file Energy Plus data and the One Building the same?
If it is a problem we will need to change a bit the lat and long of the latter so the two dots do not overlap for the locations where both files are available.

great, I will re-enable them tomorrow. I will color them one in red and one in blue. Please let me know if you would like me to use other colors

I would use 2 tones of the same color (to indicate slight variation, not opposition)
maybe 2 of the blues that we use already in the main theme?
the strongest one for the EP files rgb(0,50,98)
the softer one for the one building ones rgb(204,229,254)
?


Display nil results

By some reason, when expression evaluates to nil, it isn't printed.

This works for queries. Shall we close it?

Yes.


CORS - Proxy or oVirt config

Recently the UserPortal needs to be downloaded from the same domain as ovirt REST API to deal with CORS (cross-site scripting).
Recently, the API is accessed via relative URL like '/api/vms'.
Provide proxy and it's install instructions, so the UserPortal can be served independently.
Nice to have: connect to multiple oVirt API providers

oVirt REST API seems to have configurable CORS support. Worth to try.
If working:

write down config instructions
allow user to enter REST API URL, consider in context of Login/SSO

https://bugzilla.redhat.com/show_bug.cgi?id=1380626

https://github.com/mareklibra/userportal/pull/56

No more relevant, since the ovirt-web-ui is deployed as part of the ovirt-engine.ear.
See https://github.com/mareklibra/userportal/pull/56 and https://github.com/mareklibra/userportal/pull/62
Please reopen, if self-standing deployment is needed.


Failed to initialise  Tessearct Engine when multiple initializations  performed

I try to initialize tesseract ocr in a custom exe. When I start exe instance and initialize Tesseract it works well. However, when I open another exe and initialize Tesseract again I got the error message below. Is there a limitation for number of Tesseract instances initialized ?

No there's no limit like this that I'm aware of.
On Mon, 1 Nov 2021, 20:23 esraince1, @.***> wrote:

I try to initialize tesseract ocr in a custom exe. When I start exe
instance and initialize Tesseract it works well. However, when I open
another exe and initialize Tesseract again I got the error message below.
Is there a limitation for number of Tesseract instances initialized ?
[image: image]
https://user-images.githubusercontent.com/17276798/139650273-06080228-2b1f-4637-b48e-fb85c92308a2.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/charlesw/tesseract/issues/578, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAB7HSDBT6Y45GJUFPJ4SCLUJZL7ZANCNFSM5HDSX62A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Hi,
Thank you for your response. I call Tesseract .Net wrapper from an exe. Within that exe, there is a dll which has a reference to Tesseract. I added
<system.diagnostics>

			<add name="file" />

		</listeners>
	</source>
</sources>
<sharedListeners>
	<!--<add name="console" type="System.Diagnostics.ConsoleTraceListener" />-->

	<add name="file"
	   type="System.Diagnostics.TextWriterTraceListener"
	   initializeData="D:\Log\tesseract.log.txt" />

</sharedListeners>

</system.diagnostics>
to the exe config. However, there is no log info about the reason of why  tesseract is not initialized.  Also, I do not get that  initialization error all the time. Am I missing something ?


Update manifest: DuckStudio.FufuTools version 1.3.3

Checklist for Pull Requests

[ ] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Hi @DuckDuckStudio,
Do you approve of these changes?
(Automated response - build 896.)


Crash when Capitalizing "O"

When I try to type "O" in it's capital form, it crashes.

I'm going to need more details than this.

What do you need ? It happens every time I type O, non-capital is fine..

What keybinds did you set in the config? How are you typing "O"? Is there any other letter for which this occurs? Do you have any other addon loaded (e.g. arcdps, ReShade)? What OS are you running?

I've tried to reproduce this in the current dev build and everything works fine. I'd try to test without TacO or GW2PAO (yes, they can cause crashes too) or any other addon, then re-add just the mounts addon.
If that still doesn't work, the new version should be out shortly. Maybe that'll fix your issue. I'll leave this open for now, but it doesn't sound like it's a problem with this addon right now.

Version 1.0 Fixed the issue, Thanks...


Update README.md

Added a specific Windows (not WSL2) subsection under Troubleshooting.
Added solution for Livebook server not starting [Windows] (not WSL2)
#212

I took the opportunity to add some recently found troubleshooting steps. I've also slightly changed some wording and updated the curriculum breakdown.
Looks awesome! Thank you for the great work!


VScode will not permit long file names

Using VScode Version 1.27.1 (1.27.1), on MacOS High Sierra (10.3.6), with a HFS+ formatted volume:
VScode reports that my filenames need to be less than 31 characters long.
This is not a restriction inherent in MacOS, or other systems being interacted with (eg github; other Linux platforms).
Ideally, VScode would permit whatever the underlying OS/filesystem permits.

This works for me. Can you please add some reporducable steps
Can you repro with vscode insiders https://code.visualstudio.com/insiders/


fix/kuma.config can hmr

This PR is intended to reflect the contents of kuma.config.ts on the screen with hmr.

I have tested it locally, but it seems that changes to the theme are not being applied. Please check and confirm.
https://github.com/kuma-ui/kuma-ui/assets/12913947/6fcfa801-4562-4bd5-ad4d-2a7cb407083a

@kotarella1110

I have tested it locally, but it seems that changes to the theme are not being applied. Please check and confirm.

To reproduce it locally, I think you need to specify it in the relative path of "transform,compile, StyleGenerator".

To reproduce it locally, I think you need to specify it in the relative path of "transform,compile, StyleGenerator".

Could you provide more detailed explanation about this a bit further?
If possible, it would be appreciated if you could also provide the code that runs on CodeSandbox.

@kotarella1110

Could you provide more detailed explanation about this a bit further?
If possible, it would be appreciated if you could also provide the code that runs on CodeSandbox.

Can you check it out on Github?
https://github.com/nojiritakeshi/kuma-ui/commit/154de4ffae309d8adc22693411502368b7c6d0f8

@nojiritakeshi

Can you check it out on Github?

Thanks for providing the code to reproduce it.
I tried changing to a relative path, but the theme changes were not reflected in the browser.
Even the CodeSandbox CI example doesn't seem to work. You can check the CodeSandbox CI example at the following link.

@kotarella1110
hmm...
Can I confirm on discord?

@nojiritakeshi Of course 👍

@kotarella1110 @poteboy
Committed with modifications.
Please check back when you are available.


storage: add/fix revision/generation description

This adds some struct descriptions to revision/generation structs and corrects
some spelling errors.

lgtm

Thanks. Will merge after test pass.

@xiang90 Just fixed them. PTAL. Thanks,

@xiang90 Just fixed. PTAL. Thanks!

LGTM

Thanks, will merge after test pass.


(#8) Remove unnecessary CustomArgsEnabled option

Not necessary, check if CustomArgs is not nil instead.

nice, thanks


DSA 3.2.16 Dijkstra’s Algorithm for Adjacency List

Description
Discuss in detail - Dijkstra’s Algorithm for Adjacency List
Important: Do not use assign command for this issue.
Task

[ ] Documentation

Note

After completion of your task, add your file in this folder as its readme.md
While requesting the issue to be assigned, please mention your NAME & BATCH NUMBER.
Kindly refer to Issue Guidelines.
Changes should be made inside the DSA/directory & DSA branch.
This issue is only for 'GWOC' contributors of 'DSA' Domain.

please /assign me this issue.
My name is khushi sharma , and i am from DSA batch 2.

@nimisha-yadav Can I work on this issue ???

@nimisha-yadav Can I work on this issue ???

Go ahead @priyanshu688

https://github.com/priyanshu688/winter-of-contributing/pull/24 @nimisha-yadav Please review this PR

@nimisha-yadav mam if this issue is pending plz assign to me
Name - Jai Gora
Batch - 7


Error when running the exemple in the README

Describe the bug
I'm trying to run the example in the README but instead of retrieving a xarray a got the following message
Eodag does not support getting data from distant sources by now. Falling back to first downloading the product and then getting the data...

Code To Reproduce
By using exactly the same code as the README:
from eodag import EODataAccessGateway
from rasterio.crs import CRS

dag = EODataAccessGateway()
product_type = 'S2_MSI_L1C'
footprint = {'lonmin': 1, 'latmin': 43.5, 'lonmax': 2, 'latmax': 44}
start, end = '2020-06-04', '2020-06-05'
search_results, _ = dag.search(productType=product_type, geom=footprint, start=start, end=end)
data = search_results[0].get_data(
    crs=CRS.from_epsg(4326),
    resolution=0.0006,
    band="B01",
    extent=footprint
)
print(data)

Output
Eodag does not support getting data from distant sources by now. Falling back to first downloading the product and then getting the data...
---------------------------------------------------------------------------
UnsupportedDatasetAddressScheme           Traceback (most recent call last)
~/opt/miniconda3/envs/eodag/lib/python3.9/site-packages/eodag_cube/api/product/_product.py in get_data(self, crs, resolution, band, extent)
     79         try:
---> 80             dataset_address = self.driver.get_data_address(self, band)
     81         except UnsupportedDatasetAddressScheme:

~/opt/miniconda3/envs/eodag/lib/python3.9/site-packages/eodag_cube/api/product/drivers/sentinel2_l1c.py in get_data_address(self, eo_product, band)
     96             raise AddressNotFound
---> 97         raise UnsupportedDatasetAddressScheme(
     98             "eo product {} is accessible through a location scheme that is not yet "

UnsupportedDatasetAddressScheme: eo product EOProduct(id=S2B_MSIL1C_20200604T104619_N0209_R051_T31TCJ_20200604T125433, provider=peps) is accessible through a location scheme that is not yet supported by eodag: https

Environment:

Python version: Python 3.9.5
EODAG version: eodag (Earth Observation Data Access Gateway): version 2.3.0
I run : python -m pip install eodag-cube (10mn ago)

Additional context
If I need a specific provider I would be pleased to know which one.
Thanks again for all this work!
That is clearly helping to democratize earth observation data
Best

@BasileGoussard thanks again for the report, and the postive feedback!
I do not manage to reproduce this issue. Can you please run the example again with more verbosity, using:
from eodag import setup_logging
setup_logging(3) # DEBUG level

and post the output here. Thanks

Hello
I have also tried to run the example code and I am getting some issues, despite looking different than the ones described by @BasileGoussard
Describe the bug
The example in the README does not work
Code To Reproduce
`from eodag import setup_logging, EODataAccessGateway
from rasterio.crs import CRS
setup_logging(3)  # DEBUG level
dag = EODataAccessGateway()
product_type = 'S2_MSI_L1C'
footprint = {'lonmin': 1, 'latmin': 43.5, 'lonmax': 2, 'latmax': 44}
start, end = '2020-06-04', '2020-06-05'
search_results, _ = dag.search(productType=product_type, geom=footprint, start=start, end=end)
data = search_results[0].get_data(
crs=CRS.from_epsg(4326),
resolution=0.0006,
band="B01",
extent=footprint
)
print(data)`
Output
2021-07-22 10:21:13,216-15s eodag.config                     [INFO    ] (config           ) Loading user configuration from: C:\Users\lherreroc\.config\eodag\eodag.yml 2021-07-22 10:21:14,968-15s eodag.core                       [DEBUG   ] (core             ) Opening product types index in C:\Users\lherreroc\.config\eodag\.index 2021-07-22 10:21:15,158-15s eodag.core                       [INFO    ] (core             ) Locations configuration loaded from C:\Users\lherreroc\.config\eodag\locations.yml 2021-07-22 10:21:23,242-15s eodag.core                       [INFO    ] (core             ) Searching product type 'S2_MSI_L1C' on provider: peps 2021-07-22 10:21:23,242-15s eodag.core                       [DEBUG   ] (core             ) Using plugin class for search: QueryStringSearch 2021-07-22 10:21:23,242-15s eodag.plugins.search.qssearch    [DEBUG   ] (qssearch         ) Mapping eodag product type to provider product type 2021-07-22 10:21:23,242-15s eodag.plugins.search.qssearch    [DEBUG   ] (qssearch         ) Getting provider product type definition parameters for S2_MSI_L1C 2021-07-22 10:21:23,242-15s eodag.plugins.search.qssearch    [DEBUG   ] (qssearch         ) Getting provider product type definition parameters for S2_MSI_L1C 2021-07-22 10:21:23,242-15s eodag.plugins.search.qssearch    [DEBUG   ] (qssearch         ) Building the query string that will be used for search 2021-07-22 10:21:23,244-15s eodag.plugins.search.qssearch    [DEBUG   ] (qssearch         ) Retrieving queryable metadata from metadata_mapping 2021-07-22 10:21:23,245-15s eodag.plugins.search.qssearch    [INFO    ] (qssearch         ) Sending count request: https://peps.cnes.fr/resto/api/collections/S2ST/search.json?startDate=2020-06-04&completionDate=2020-06-05&geometry=POLYGON ((1.0000 43.5000, 1.0000 44.0000, 2.0000 44.0000, 2.0000 43.5000, 1.0000 43.5000))&productType=S2MSI1C&maxRecords=1&page=1 2021-07-22 10:21:24,248-15s eodag.plugins.search.qssearch    [INFO    ] (qssearch         ) Sending search request: https://peps.cnes.fr/resto/api/collections/S2ST/search.json?startDate=2020-06-04&completionDate=2020-06-05&geometry=POLYGON ((1.0000 43.5000, 1.0000 44.0000, 2.0000 44.0000, 2.0000 43.5000, 1.0000 43.5000))&productType=S2MSI1C&maxRecords=20&page=1 2021-07-22 10:21:24,944-15s eodag.plugins.search.qssearch    [DEBUG   ] (qssearch         ) Adapting 2 plugin results to eodag product representation 2021-07-22 10:21:25,271-15s eodag.api.product                [WARNING ] (_product         ) Drivers definition seems out-of-date, please update eodag-cube 2021-07-22 10:21:25,390-15s eodag.api.product                [WARNING ] (_product         ) Drivers definition seems out-of-date, please update eodag-cube 2021-07-22 10:21:25,390-15s eodag.core                       [INFO    ] (core             ) Found 2 result(s) on provider 'peps' Traceback (most recent call last):   File "C:\Users\xxxxxx\Miniconda3\envs\yyyyyy\lib\site-packages\eodag_cube\api\product\_product.py", line 80, in get_data     dataset_address = self.driver.get_data_address(self, band)   File "C:\Users\xxxxxx\Miniconda3\envs\yyyyyy\lib\site-packages\eodag\api\product\drivers\base.py", line 35, in get_data_address     raise NotImplementedError NotImplementedError
Environment

Python 3.7
eodag 2.3.1, installed with conda
eodag-cube 0.1.2, installed with pip

Additional context
The driver is NoDriver, and a message telling to update the package appears.
search_results[0].get_driver() 2021-07-22 10:25:34,111-15s eodag.api.product                [WARNING ] (_product         ) Drivers definition seems out-of-date, please update eodag-cube <eodag.api.product.drivers.base.NoDriver object at 0x0000021496C59148>
However, conda-cube is up to date
Thank you!!

2021-07-22 10:21:25,271-15s eodag.api.product                [WARNING ] (_product         ) Drivers definition seems out-of-date, please update eodag-cube

Environment
* Python 3.7

* eodag 2.3.1, installed with conda

* eodag-cube 0.1.2, installed with pip

Hello @lhcorralo,
please update eodag and eodag-cube. Regarding your logs, updating eodag-cube to 0.2.0 minimum should be enough.

@BasileGoussard, your issue may be related to missing/wrong credentials, or maybe a temporary server issue (peps had some during June & July). Did you post the full output ?
I tried running the example using the same versions as yours.
If credentials are missing I get the following output:
Eodag does not support getting data from distant sources by now. Falling back to first downloading the product and then getting the data...
Traceback (most recent call last):
  File "/opt/conda/envs/eodag/lib/python3.9/site-packages/eodag_cube/api/product/_product.py", line 80, in get_data
    dataset_address = self.driver.get_data_address(self, band)
  File "/opt/conda/envs/eodag/lib/python3.9/site-packages/eodag_cube/api/product/drivers/sentinel2_l1c.py", line 97, in get_data_address
    raise UnsupportedDatasetAddressScheme(
eodag.utils.exceptions.UnsupportedDatasetAddressScheme: eo product EOProduct(id=S2B_MSIL1C_20200604T104619_N0209_R051_T31TCJ_20200604T125433, provider=peps) is accessible through a location scheme that is not yet supported by eodag: https

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/opt/conda/envs/eodag/lib/python3.9/site-packages/eodag_cube/api/product/_product.py", line 88, in get_data
    path_of_downloaded_file = self.download()
  File "/opt/conda/envs/eodag/lib/python3.9/site-packages/eodag/api/product/_product.py", line 270, in download
    self.downloader_auth.authenticate()
  File "/opt/conda/envs/eodag/lib/python3.9/site-packages/eodag/plugins/authentication/generic.py", line 29, in authenticate
    self.validate_config_credentials()
  File "/opt/conda/envs/eodag/lib/python3.9/site-packages/eodag/plugins/authentication/base.py", line 50, in validate_config_credentials
    raise MisconfiguredError(
eodag.utils.exceptions.MisconfiguredError: The following credentials are missing for provider peps: username, password

Can you please run the example again with more verbosity, and post the full output:

from eodag import setup_logging
setup_logging(3) # DEBUG level

Or update eodag + eodag-cube:

conda update eodag
# or
pip install -U eodag

pip install -U eodag-cube

Thanks

Hi @sbrunato,
Thanks for your reply.
Indeed I got a temporary issue with the peps server.
Know the readme example is running without any trouble.
Have a nice week-end,
Basile


Avoid collisions between similar game objects

Avoid collisions between ghosts
Avoid collisions between ghosts and handholds
Only the skeleton should collide with either

maybe we need to figure out how to abstract our colliders so it's easy to tell them which things to collide with and which things they shouldn't

David here. I agree a more general abstraction would be nice. Currently, we prevent hold-hold collision by looking at the tag on the collider and if it 'Hold', ignoring the collision. This approach is simple with one type of game object but probably wouldn't scale well with many types of game objects.

#257
still just doing a check to see if the collider has tag "hold"
since there's only one ghost i'm closing this issue


DropShadows + System Chrome + Phone graphics driver problems

For starters, here's a video demonstrating the problem:
https://1drv.ms/v/s!Am6tzicbkkfemfEskMdOLHBZ_Ljfhw
Background: I have multiple text elements on the screen. These text elements have brushes with DropShadows added to them. On mouse over, I animate the shadows to become visible.
Problem: On the phone, having these shadow visuals seems to make the phone's display driver go nuts - when system chrome is overlaying a shadowed element! See video - all system chrome (navigation bar at the bottom, banner notifications, notification center etc.) flicker when overlayed on top of the app. For these demo purposes, I'm using a Lumia 950XL.
Super annoying! It's worth noting that when system chrome isn't overlaying a shadow, it's fine.
(Having seen quite a few similar issues over time using DirectX & Win2D on the phone and it's always been related to layers, so I'm guessing it's a driver / DX issue)
Here's a sample app that uses the same button code I'm using an exhibits the same problem. It's worth noting that the constant flickering only occurs when the progress bar updates. Take out code to do that, and flickering only happens at the start of the animation.
To repro: run on a phone, click all the text items a few times so you've seen the shadows on them, and then pull and hold down the notification tray and notice madness.
ShadowTest.zip
Additional Problem: In the same app on PC, try moving your mouse really quickly between the two buttons constantly. You'll crash your display driver. On the PC, this is annoying, but not usually terrible (though occasionally it could take your whole system down). On the phone however, it restarts the entire device when the display driver crashes, which is less livable!
(Part of this is down I think to the StopAnimation call in the code, but being able to crash the entire phone's display driver and causing it to restart is a bit of an issue the platform should be preventing us from doing and handling a bit more gracefully!).
To repro on the phone, just tap between the two buttons really quickly, and then watch as your device dies and restarts!

For ref, Lumia 950XL is running: OS 10.0.14393.0, Firmware 01078.00038.16025.39013

@JohnnyWestlake  Thank you for the detailed write up and all the information.  I wanted to let you know we are taking a look at this.  At this point we can reproduce your app flickering on device but we will need to do some debugging. "We" being the effects team here in composition - this may as you suggest be a an issue that is independent of shadows.

I also can reproduce this in my app, as shown at https://1drv.ms/v/s!Arstk3P49tmim9Qdp9vta1b5yC4u3w
What I do is only cast a dropshadow on rectangles and it works just fine on my desktop.
Runnign on Lumia 640, SO 10.0.14393.67, Firmware 02117.00000.15184.36001

Thanks for the repro app @JohnnyWestlake! I've tracked down the issue and have a fix that resolves both the issue you're seeing in the ShadowTest app and the flickering that @rpedretti is reporting. We'll get back to you soon as to when you can expect the fix to be available.

This fix should be available in the latest insider build. Closing the issue.


HTML entities are garbled in output

I used the ★ HTML entity to display stars. This was displayed correctly in tclssg 0.9. In 2.0-beta-2 as well as the newlines branch, this displays as garbled fonts.

Is this a Tclssg pipeline or a Bootstrap/browser issue?  I can't reproduce it with the following input file.
{
    title test
    blogPost 1
}
★★★

It is transformed into the following HTML and renders correctly for me with font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;.
...

test

★★★

...

Please attach an input file (foo.md) that gets corrupted and its output HTML file and preferably screenshot.

Found the problem. It only happens if the tidy option is enabled. If tidy is disabled, it shows up fine.
So not sure if this should be logged as a bug or not.

I've pushed a possible fix to the dev branch.

Tell me when you're done upgrading and I'll publish a new beta release.

All seems fine now. No obvious errors in output that I can see.


[WIP]: handel invalid polygons when computing the weight table

Coverage decreased (-0.3%) to 80.878% when pulling 7ff0a3e9fa268428e0097a04c0c2655f8e48a570 on sdc50:bugfix/handel-invalid-polygons into 1235b48453b7b2a150c8848ba08c297c7c8bb14d on erdc-cm:master.


Allow for unix socket connections

In a deployment with a highly available MySQL databsae, the slurmdbd service will use a socket connection to connect to the mysql-router. This requires that the StorageHost and StoragePort are not set in the slurmdbd.conf file as the MySQL connection uses the MYSQL_UNIX_PORT environment variable in order to use a unix socket.

Good question - its actually picked up by the mysql library internally. What happens is that this reads in from the environment variable. PR#15 in the slurmdbd-operator shows how this is updated. Essentially, the /etc/default/slurmdbd file contains environment variables to pass through to the slurmdbd process and that charm just adds it to the env file.

Good question - its actually picked up by the mysql library internally. What happens is that this reads in from the environment variable. PR#15 in the slurmdbd-operator shows how this is updated. Essentially, the /etc/default/slurmdbd file contains environment variables to pass through to the slurmdbd process and that charm just adds it to the env file.

Spectacular! Thanks!


Refine the Kwalite dashboard requirements regarding projects tab

Describe the feature you'd like
We need a clear idea about the next steps regarding the projects tab of the kwalite dashboard.
kwalite dashboard consists of thee tabs: Projects, Workflows and Processors. We agreed that we should focus on the projects tab first, because:

this is Konstantins starting point, when he implemented the tool...it is easy to go on here.
as koordination project we need to check our repos/projects for quality cireria, to enable us to decide which projects/repos belong to our product.

Is your feature request related to a problem? Please describe.
We currently have no clear requirements list.
We need

[ ]  digging deeper into the code of the current implementation to get an better understanding of the code base to enable us to generate an idea about how to go on with further implementation;  AC: first next steps regarding implementation
[ ] a list of requirements, a prioritisation, a definition of mvp. AC: self explaining
[ ] a mock up of the projects tab as discussion basis AC: self explaining
[ ] clone or move the kwalite tool to the official ocr-d organisation in github

User story
As a a koord developer I need clearer requirements in order to start implementing helpful features in the sense of code quality and in view of our product definition.
Additional context
This feature helps us meeting our requirements regarding code quality and product definition

https://pad.gwdg.de/y41n80-BR3yq2LtUsBl-8w?both


Admin user does not have access to Docker socket

This is due to the admin user not being part of the Docker group. I don't know why this is happening: the Ansible script looks OK.

Seems to work now.


Failed to execute 'dispatchEvent' on 'EventTarget': parameter 1 is not of type 'Event' in Page.select()

Puppeteer version: 0.12.0
Platform / OS version: Ubuntu 16.04.3

When I do:
page.select('[name="resource_id"]', '25');

I get an error:
TypeError: Failed to execute 'dispatchEvent' on 'EventTarget': parameter 1 is not of type 'Event'.

If I comment both dispatchEvent lines in select(), I get no error. Both fail.
The element exists and is a <select> and the selection works. Only the event dispatching does not work.

@rudiedirkx do you have a code snippet so that I can repro this?

It's https://github.com/rudiedirkx/puppeteer-demo/blob/94d078af7c3c2ba60afb83c0642d756ec89e6de8/br.js#L82 but it's really only the one line: the page.select(...)

@rudiedirkx any chance you can share the URL that causes this bug?

No, but this is the relevant HTML:
<form method="post" action="/blockreservations/insert" autocomplete="off" onsubmit="return postForm(this, OorA, true)">

				Blokreservering maken

				Baan
				<select name="resource_id" onchange="checkFormValues(this.form);"><option value="">--</option><option value="2113">Lane 1 (30 min)</option><option value="24">Squash 3 (EMS) (15 min)</option><option value="25">Squash 4 (15 min)</option><option value="26">Squash 5 (15 min)</option><option value="27">Squash 6 (15 min)</option></select>

				Dag
				<select name="on_day" onchange="checkFormValues(this.form);"><option value="">--</option><option value="1">Maandag</option><option value="2">Dinsdag</option><option value="3">Woensdag</option><option value="4">Donderdag</option><option value="5">Vrijdag</option><option value="6">Zaterdag</option><option value="0">Zondag</option></select>

				Begintijd
				<input name="start_time" class="time replace-with-select" />

... etc ...

Maybe the onchange ? That's what I'm trying to trigger.

Any idea what's happening?
Page.select() does a
element.dispatchEvent(new Event('input', { 'bubbles': true }));

which seems like an Event in parameter 1.
Can I try another version or something?

@rudiedirkx I can't reproduce this; without a repro this is not actionable. If you can come up with a sharable snippet, I'd be happy to look into this.
cc @alixaxel who implemented original Page.select.

@rudiedirkx I suspect the culprit is the checkFormValues function on the onchange trigger.
Could you share that function? Along with the HTML doctype of the page?

If I remove the onchange attribute, or empty the callback, the exact same happens, so that can't be it.
If I remove the entire inline script block, it still happens.
If I remove ALL JS, it doesn't happen. There's no callback to be fired, but the Puppeteer part works..... Is my JS too hacky? It's possible.

Ooooooh, I might know what it is, but that's unexpected (for me, for you it's obvious). My very old JS lib overrides window.Event, so it's not a native Event anymore. This is unexpected for me, and obvious for you, because I didn't know the stringified version of the this.$eval callback function is called inside the page's context, not in Puppeteer/node context.
element.dispatchEvent(new Event('input', { 'bubbles': true }));

That's browser JS, not NodeJS.... Ah.
I now see I can reproduce this exact error in Real Chrome:
$0.dispatchEvent(new Event('input', { 'bubbles': true }));

VM1042:1 Uncaught TypeError: Failed to execute 'dispatchEvent' on 'EventTarget': parameter 1 is not of type 'Event'.
    at <anonymous>:1:4
(anonymous) @ VM1042:1

So, yes, my JS is definitely too hacky. Sorry!

Hey guys, I have a a question regarding this:
I'm trying to use [Puppeteer][1] to attempt to get the direct link for a google drive video. To do that, I first navigate to the drive embed-video URL, then click on the play button (There are many of them), then wait for the iframe containing a video element to appear, then get the video element in the iframe, then I'm trying to get the source of the video, but it appears to be null, so I tried getting the outerHTML, and this is what I got in the console:
<video tabindex="-1" class="video-stream html5-main-video" controlslist="nodownload" style="width: 800px; height: 450px; left: 0px; top: 75px;"></video>

Seemingly it hasn't been loaded yet, but I'm not sure what event to wait for, I waited for a timeout of 15 seconds but still got the same result, here's my code:
var puppeteer = require("puppeteer");

    (async() => {
        var browser = await puppeteer.launch();
        console.log("Got browser", browser);
        var page = await browser.newPage();
        console.log(page,"got page");

        await page.goto("https://docs.google.com/file/d/1Cyuh41yNfYZU_zL-MHLf_EPJCYnlT7oJ/preview?enablejsapi=1&playerapiid=player4");
        console.log("went to page..");

        var clickEl = ".ndfHFb-c4YZDc-aTv5jf-bVEB4e-RJLb9c";
        var newClickID = ".ndfHFb-c4YZDc-aTv5jf-NziyQe-LgbsSe";
        var clicker = await page.waitForSelector(newClickID);
        console.log(clicker,"got clicker");

        await page.click(clickEl);
        console.log("clicked")

        var frame = await page.waitForSelector("iframe[id=drive-viewer-video-player-object-0]");
        console.log(frame, "got video frame");

        var cf = await frame.contentFrame();
        console.log(cf, "got content frame");
        await cf.waitFor(15000);
        var video = await cf.$("video");
        var src = await cf.evaluate(
            v => v.outerHTML,
            video
        );
        console.log("$$###VIDEO SOURCE::", src);
        await browser.close();
    })();

Any ideas, am I doing something wron? why is the "src" attribute not showing up on the video element?
[1]: https://github.com/GoogleChrome/puppeteer/blob/v1.13.0/docs/api.md#elementhandleselector-1


Chrome extension creates blank FN opening then syncs this note even if empty

Using FN via Mac Chrome extension. When I open the extension a blank note is create by default. Even if left blank this note syncs with Obsidian (and does not delete - see previous issue logged).

As an update, this will be fixed in the upcoming release

fixed in v0.7.0


feat: add anhmoe image hosting

feat: add anhmoe image hosting
build(aur): update PKGBUILD
chore: adjust --notify help msg
chore: update some error messages

@CodiumAI-Agent /review

PR Analysis

🎯 Main theme: Adding a new image hosting service and updating error messages
📝 PR summary: This PR introduces a new image hosting service, anhmoe, to the existing list of services. It also includes updates to the PKGBUILD file and error messages to improve clarity. The --notify help message has been adjusted as well.
📌 Type of PR: Enhancement
🧪 Relevant tests added: No
⏱ Estimated effort to review [1-5]: 2, because the PR is relatively small and straightforward, with clear changes. However, it lacks tests for the new functionality.
🔒 Security concerns: Yes, because the API key for the new image hosting service is hardcoded in the code, which could potentially expose it to unauthorized users.

PR Feedback
💡 General suggestions: The PR is well-structured and the changes are clear. However, it would be beneficial to add tests for the new image hosting service to ensure it works as expected. Additionally, consider handling the API key for the new service in a more secure way, such as using environment variables or a configuration file, instead of hardcoding it.
 🤖 Code feedback:relevant filesrc/images_upload_cli/upload.pysuggestion
Consider moving the hardcoded API key to a more secure location, such as an environment variable or a configuration file. This will make the code more secure and flexible. [important]
relevant linekey = "anh.moe_public_api"relevant filesrc/images_upload_cli/upload.pysuggestion
It would be beneficial to handle exceptions that may occur when making the HTTP request. This can provide more detailed error messages and make debugging easier. [medium]
relevant lineresponse = await client.post(

 ✨ Usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:
[pr_reviewer]
some_config1=...
some_config2=...

  Utilizing extra instructions
The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.
Examples for extra instructions:
[pr_reviewer] # /review #
extra_instructions="""
In the code feedback section, emphasize the following:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  How to enable\disable automation

When you first install PR-Agent app, the default mode for the review tool is:

pr_commands = ["/review", ...]

meaning the review tool will run automatically on every PR, with the default configuration.
Edit this field to enable/disable the tool, or to change the used configurations

  About the 'Code feedback' section
The review tool provides several type of feedbacks, one of them is code suggestions.
If you are interested only in the code suggestions, it is recommended to use the improve feature instead, since it dedicated only to code suggestions, and usually gives better results.
Use the review tool if you want to get a more comprehensive feedback, which includes code suggestions as well.

  Auto-labels
The review tool can auto-generate two specific types of labels for a PR:

a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

  Extra sub-tools
The review tool provides a collection of possible feedbacks about a PR.
It is recommended to review the possible options, and choose the ones relevant for your use case.
Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
require_score_review, require_soc2_review, enable_review_labels_effort, and more.

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.

PR Review

      PR feedback                       ⏱ Estimated effort to review [1-5]
3, because the PR includes both feature additions and updates across multiple files, including new functionality, dependency updates, and changes in user messages. Reviewing the new image hosting feature and its integration requires understanding of asynchronous HTTP requests and error handling, as well as verifying the correctness of the updated user messages and dependencies.

 🧪 Relevant tests
No

 🔍 Possible issues

The hardcoded API key "anh.moe_public_api" in anhmoe_upload function might be a placeholder, but if it's intended to be used as is, it could lead to security concerns or misuse.
The error message customization in fastpic_upload and imagebin_upload functions improves clarity, but it's important to ensure that including the response URL in error messages does not inadvertently expose sensitive information.

 🔒 Security concerns
Yes, because the hardcoded API key in the anhmoe_upload function could potentially expose the service to unauthorized use if it's a valid key intended for private use. It's recommended to manage such keys via environment variables or configuration files that are not checked into version control.

 Code feedback:
relevant filesrc/images_upload_cli/upload.py
suggestion

Consider externalizing the API key for anhmoe_upload to an environment variable or a configuration file. This approach enhances security by not hardcoding sensitive information in the source code. You can use the get_env utility function already present in your codebase to retrieve the API key. [important]

relevant linekey = "anh.moe_public_api"
relevant filesrc/images_upload_cli/cli.py
suggestion

There's a typo in the help message for the --notify option ("Requared" should be "Required"). Correcting this typo will improve the clarity of the help message. [medium]

relevant linehelp="Send desktop notification on completion. Requared libnotify.",
relevant filePKGBUILD
suggestion

Since libnotify is now an optional dependency for desktop notifications, ensure that the application gracefully handles the absence of libnotify when the user enables notification functionality. This might involve checking for the presence of libnotify at runtime and providing a clear error message if it's not installed. [medium]

relevant line"libnotify: sending desktop notifications"
relevant fileREADME.md
suggestion

Update the documentation to include instructions or a note on how to set up or obtain the API key required for anhmoe image hosting. This will help users to correctly use the new hosting option without running into authentication issues. [important]

relevant line| [anhmoe

 ✨ Usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:
[pr_reviewer]
some_config1=...
some_config2=...

  Utilizing extra instructions
The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.
Examples for extra instructions:
[pr_reviewer] # /review #
extra_instructions="""
In the 'possible issues' section, emphasize the following:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  How to enable\disable automation

When you first install PR-Agent app, the default mode for the review tool is:

pr_commands = ["/review", ...]

meaning the review tool will run automatically on every PR, with the default configuration.
Edit this field to enable/disable the tool, or to change the used configurations

  Auto-labels
The review tool can auto-generate two specific types of labels for a PR:

a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

  Extra sub-tools
The review tool provides a collection of possible feedbacks about a PR.
It is recommended to review the possible options, and choose the ones relevant for your use case.
Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
require_score_review, require_soc2_ticket, and more.

  Auto-approve PRs
By invoking:
/review auto_approve

The tool will automatically approve the PR, and add a comment with the approval.
To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following:
[pr_reviewer]
enable_auto_approval = true

(this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository)
You can also enable auto-approval only if the PR meets certain requirements, such as that the estimated_review_effort is equal or below a certain threshold, by adjusting the flag:
[pr_reviewer]
maximal_review_effort = 5

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.


Avoid seaborn API import warning

Since seaborn 0.8.0 the apionly import is the default and trying to import seaborn.apionly as sns raises a deprecation warning.

Happy to merge when the tests go green.


#162240009 Connect login web page with the  backend API

What does this PR do?
Connects the login UI to the login endpoint
Description of Task to be completed?

Add the POST request using fetch API
Redirect the user to the Profile Page after a successful login

How should this be manually tested?

Clone the repository
Edit the .env file with different credentials of postgress, mailgun
Start your postgress server
Install ppm packages by running : npm install
Start the api witth npm run dev
Start the UI with npm run ui
Try to login with the following credentials email<EMAIL_ADDRESS>and password: user@user

What are the relevant pivotal tracker stories?
#162240009

Codecov Report

Merging #18 into develop will increase coverage by 0.61%.
The diff coverage is 68.75%.

@@             Coverage Diff             @@
##           develop      #18      +/-   ##
===========================================
+ Coverage    81.05%   81.66%   +0.61%
===========================================
  Files           31       31
  Lines          475      480       +5
===========================================
+ Hits           385      392       +7
+ Misses          90       88       -2

Impacted Files
Coverage Δ

server/src/controllers/mailers.js
100% <ø> (ø)
:arrow_up:

server/src/controllers/auth.js
93.75% <ø> (ø)
:arrow_up:

server/src/db/index.js
56.25% <0%> (ø)
:arrow_up:

server/src/controllers/parcels.js
100% <100%> (ø)
:arrow_up:

server/src/routes/auth.js
100% <100%> (ø)
:arrow_up:

server/src/db/queries/parcels.js
100% <100%> (ø)
:arrow_up:

server/src/controllers/users.js
71.05% <50%> (+6.76%)
:arrow_up:

server/src/models/Parcel.js
63.15% <62.5%> (+0.65%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0672ef...56ab883. Read the comment docs.


batch navigation updates

simple change here to make history updates atomic.
this is especially useful when doing navigation based on state. e.g.:
let hash_memo = use_location().hash;
let state_signal = use_location().state;

let location_signal = create_memo(move |_| {
    let hash = hash_memo.get();
    let state = state_signal.get()

    let path = todo!(); // some processing
    (path)
});

making the nav updates atomic ensures that this memo doesn't get updated twice for a single navigation event

Thanks!


Patient quick start sample

Description

Created New Unit Test Case Project.
Removed the TenantID, ClientId, ClientSecret .
-Change the Authenticator logic in Program.cs file.

Related issues
Addresses [issue #94608,#94609].
Testing

Created Unit Test project with all Methods.

Reviewer Checklist

[ ] PR for Quick Start Sample-94231 of the PR to be succinct and less than 50 characters
[ ] Bug, New-Sample, Enhancement
[ ] CI is green before merge

Some comments - you should be using the Binding to actually call the FHIR service. I also splitted up the filters as well.
https://github.com/microsoft/azure-health-data-services-sdk/compare/PatientQuickStartSample...PatientQuickStartSample-Updates


Fix fail to add multiple preUsrLibl/postUsrLibl

Fixes #111

@TongkunZhang I'm gonna need this before Edmund can make a review. Do you mind if I do some testing on this? Any chance you can build me a .rpm for this branch?

@TongkunZhang I'm gonna need this before Edmund can make a review. Do you mind if I do some testing on this? Any chance you can build me a .rpm for this branch?
Hi Liam, I just created the rpm for you. Github does not allow uploading .rpm format here so I put it in the zip.

bob-2.3.10-1.ibmi7.3.ppc64.rpm.zip


Add separable_circuits method to DAGCircuit class

Summary
There is currently no easy way to retrieve all of the disconnected subsets of qubits in a given circuit, even though this information is easily accessible in the graph representation of a quantum circuit.
Create an instance method, DAGCircuit.separable_circuits, that returns a list of DAGCircuits -- one for each set of disconnected qubits in the quantum circuit.
Closes #9459

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 21 (4.76%)  changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.06%) to 84.922%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit/dagcircuit/dagcircuit.py
1
21
4.76%

Files with Coverage Reduction
New Missed Lines
%

src/sabre_swap/mod.rs
2
99.54%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
66756

Relevant Lines:
78609

💛  - Coveralls

This looks great now Caleb, thanks. I'd still like to put in the output sorting/normalisation into the test if possible - let me know if you're working on it, or I can add it - but beyond that, this is ready to go.

Thanks a lot for the help getting this in. Let me know if you'd like any last minute tweaks

This looks great Caleb, thanks for sticking with it, for the quick updates, and for indulging my paranoia about test outputs changing from underneath us!

I was a bit sloppy here picking this back up after so much time. Thanks to you for sticking it out as well, hah :D

(Don't worry, but there's no need to press "update branch" in 95% of cases when there's no merge conflict - the automerge queue will automatically do it when this PR joins the queue.)


[Error] - Fail to run whispers scan in a React project

Context
I am manually running the CLI to find sensitive data in my project and I hope to automate it in a pipeline later. In the /code folder I have the structure of a react project
Problem
After running the command I find a problem similar to the issue #33.
whispers --rules aws-id,aws-secret,apikey,file-contains-password,file-contains-secret ./code

Prints
Python Version:

Command error output:

Hey @lpmatos, thanks for raising!
Would you be able to provide an example string from your code that is causing it to fail?
This issue should have been addressed by https://github.com/Skyscanner/whispers/blob/6ff59c984300fdbb32552bcb63f053579cf99da4/whispers/cli.py#L12
I am surprised to see it come up again..

Is there a possibility that the analysis is reading files that are being ignored in .gitignore?


don't force downscale factor to 1 for nerfacto-huge

Fixes #2087.

@SharkWipf can you try using this and ns-train nerfacto-lesshuge ?
@kerrj did you find that forcing downscale factor to 1 was necessary for better results?  if not, would be better for me to modify nerfacto-huge instead of making yet another config

Yep, can confirm this fixed it for me, thanks!


Financing

Hi :wave:,
I'm Romuald from the Lsos, an organization that develops financial solutions for open source, and we are currently reaching out to projects we like.
We have several solutions depending on your financial goals and we can help with:

Increasing donations
Starting/increasing consulting work for your users
Earning a living from your open source work
Remunerating and hiring a small engineering team for your open source projects

For example, we can increase donations with the Lsos Donation Reminder and the Lsos Donation Fund.
We can also leverage a license clause if you are interested in receiving a substantial remuneration from your open source work. Our license clauses are designed to keep code:

Accessible: everything stays free for individuals and small companies — only large companies pay a small fee.
Open: anyone can fork the code and remove the license clause.

Large companies want two things: open source and a way to pay for software. They prefer paying for well-maintained tools rather than using free but unreliable tools. At the end of the day, a license clause can be a win for everyone.
We are focusing on solving the financials of a handful of projects first to then eventually tackle the open source financing problem at large. Let me know if you are interested.
Rom

Thanks for reaching out.
I won't be able to explore this at the moment.

Ok and thanks for the reply. Sorry for the cold outreach. Rom :)


segmented object dimensions

Hi,
How to measure the segmented object dimensions inside bounding box? Is it possible to include point cloud library inorder to extract 3D information?
Any idea would be appreciated.

By dimensions do you mean just the height and width? If so, that's easy, just get that from the predicted boxes here:
https://github.com/dbolya/yolact/blob/bd51ec9ef42389f60178fe729dfda3ad0f370f2f/eval.py#L149
The boxes are in point form, so to get the width and height do
w, h = boxes[:, 2:] - boxes[:, :2]

Then I have no idea what you mean by incorporating point cloud data, so you'll have to do that yourself.

This width and height values are not real object size. Since this is based on 2D information, it will not provide real object size. I'm trying to measure object size it is present. Thanks for your details, i will check this soon

Yeah if you need 3d dimensions of an object, then YOLACT is probably not the method for you (since it's only operating on 2d images. You could probably incorporate 3d information for everything inside of a mask to discover 3d extents, but that's a research question in its own right, so I can't help you there.
Since this is out of the scope of YOLACT, I'm going to close the issue.

@dbolya A similar issue. How can I get the predicted masks x,y coordinates? I had gone through the code of eval.py and you are already generating a mask_detection.json and bbox_detection.json file of it. But, I am not able to generate this file.

@sainatarajan The mask x,y coordinates are just the box detection. If you want to create those files you mention, simple run evaluation with --output_coco_json.

@dbolya I tried to run eval.py with that argument. But it does not generate any JSON file. It returns after calling the evalimages() function after this line: line

@sainatarajan Oh, that command only works when using a dataset (the 'has_gt' parameter can be False though).
For the case of an image-by-image basis, you can follow the call here: https://github.com/dbolya/yolact/blob/bd51ec9ef42389f60178fe729dfda3ad0f370f2f/eval.py#L565 and modify this line: https://github.com/dbolya/yolact/blob/bd51ec9ef42389f60178fe729dfda3ad0f370f2f/eval.py#L149 to save the boxes / masks like I suggested above.

@dbolya Yes. It's working now. I am able to get the bounding box, classes, and scores information. Is it also possible to get the points of the predicted mask rather than the bounding box? If not, do you have any idea how can I get them?

@sainatarajan The masks come as binary images. Under that line I gave you, simply put
masks_out = masks.cpu().numpy()

and you have them on the cpu. If you still want to do computations to them on the GPU with torch, you can just use masks.

@dbolya That's good. Thanks. I will use some OpenCV techniques to get information about its coordinates.

This width and height values are not real object size. Since this is based on 2D information, it will not provide real object size. I'm trying to measure object size it is present. Thanks for your details, i will check this soon

Hi,
you can refer to :
https://github.com/dbolya/yolact/issues/606#issuecomment-829857227


OADP-612: Check VSB status conditions for failure

Related: https://github.com/openshift/velero/pull/192

/cherry-pick oadp-1.1


argument of type <int/float> is not iterable

Venus OS: V3.51
Pi4
Sensor: ESP32 and INA219 for testing purposes
I followed the install sequence as written. The service is running ok, as it seems.
My sensor is publishing mtqq to Venus OS broker and I can successfully see messages coming in using Mqtt Explorer.

Setting logging level to DEBUG gives me:

In Venus GUI I cannot see any sensors - either in the settings or in the overview. What am I missing?

Please try the nightly version. It will be released shortly as stable.

I have the same error even on the nightly version:
2024-11-19 21:07:20.804738500 INFO:root:Waiting 5 seconds for receiving first data...
2024-11-19 21:07:21.594367500 ERROR:root:Received message is not valid. Check the README and sample payload. argument of type 'float' is not iterable
2024-11-19 21:07:21.595132500 DEBUG:root:MQTT payload: '13.600000381469727'
2024-11-19 21:07:21.597506500 ERROR:root:Received message is not valid. Check the README and sample payload. argument of type 'float' is not iterable
2024-11-19 21:07:21.598193500 DEBUG:root:MQTT payload: '13.600000381469727'
2024-11-19 21:07:22.081899500 ERROR:root:Received message is not valid. Check the README and sample payload. argument of type 'float' is not iterable
2024-11-19 21:07:22.082882500 DEBUG:root:MQTT payload: '13.609999656677246'
2024-11-19 21:07:22.097212500 ERROR:root:Received message is not valid. Check the README and sample payload. argument of type 'float' is not iterable
2024-11-19 21:07:22.097223500 DEBUG:root:MQTT payload: '13.609999656677246'
^C

When trying just with payload 12 it also doesn't work, now no 'float' error but 'int' error
2024-11-19 21:19:01.758736500 INFO:root:Waiting 5 seconds for receiving first data...
2024-11-19 21:19:06.762087500 INFO:root:Waiting 5 seconds for receiving first data...
2024-11-19 21:19:09.958013500 ERROR:root:Received message is not valid. Check the README and sample payload. argument of type 'int' is not iterable
2024-11-19 21:19:09.959692500 DEBUG:root:MQTT payload: '12'

Did you reboot once, just to be sure?

Yes I did, did it twice now. Doesn't help.

The problem was now solved.


Fix issue where is wasnt showing youtube if no variables are set

Change-type: minor
Signed-off-by: Daniel Andrade<EMAIL_ADDRESS>

I think this still contradicts the README where it states that YouTube TV is the default? Here nothing will be displayed as default.

Hey @edorgeville, you are correct.
Since we moved to marhoy/balena-wpe image it doesn't open youtube anymore.
I will also fix the README file now.
Thanks ;)


Avafanasev/qd 9162.242

Pull Request Details

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] I have read the CONTRIBUTING document.
[ ] My code follows the code style of this project.
[ ] My commit messages are styled with gitmoji
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

We are lucky for now thar it's not a separate endpoint


Enable protobuf's --with-pic option

This PR only applies to contrib/makefile project.
libtensorflow-core.a static library is built with position independent code (i.e., -fPIC option), however, libprotobuf.a static library is not. This MR enables the protobuf's --with-pic option in order to be able to use libprotobuf.a when building a shared library.

Can one of the admins verify this patch?

Jenkins, test this please.


Dommel basin profile

With this branch we can create de dommel model version 2024.8.4 from 2024.6.3
All code used is updated to function with current ribasim-version (main)

Made some changes so this Dommel-workflow produces a running (initalizing) ribasim-model with ribasim-main-version after PR #1798


Sourcemaps pointing to missing source files

Describe the bug
Apologies if this is not related to remix-utils but after upgrading to 8.0.0 I noticed these errors appearing when I start dev mode.
Sourcemap for "D:/path-to/node_modules/remix-utils/build/react/honeypot.js" points to missing source files
Sourcemap for "D:/path-to/node_modules/remix-utils/build/react/server-only.js" points to missing source files
Sourcemap for "D:/path-to/node_modules/remix-utils/build/react/use-hydrated.js" points to missing source files

I basically have two questions:

Are these warning safe to ignore?
Is there an upgrade step that I missed or could I be doing something wrong?

Your Example Website or App
private repo
Steps to Reproduce the Bug or Issue
N/A
Expected behavior
I would expect these warning not to be there when starting dev.
Screenshots or Videos
No response
Platform

OS: Windows
Browser: Chrome
Version: 131.0.6778.205 (Official Build) (64-bit)
React-router 7
React 19
Node 22
Using remix-tools HoneyPot and ServerOnly

Additional context
No response

Ohw, just as I pressed submit I remember this entry in tsconfig.ts:
  ssr: {
    noExternal: ["remix-utils"],
  },

I am not sure why it was there because I do not see it in the remix-utils documentation but... commenting out these lines solves the issue.

Apparently that was needed before I switched to RR7 and ESM. Apologies for the noise. Much ♥

If you're using Vite, but still building to CJS, you will need to add this package to noExternal, so it's bundled with your server code. Therefore, add the following to defineConfig() in vite.config.ts:


Feat: cli enhancement and improved deal validation

Allows to express lower and upper bounds for each assets on each network, used when validating maker/taker deals.

Local tests shows for now some weird behavior, do not merge yet.

This is now good for a review.  cc @TheCharlatan

Thanks for the review @TheCharlatan, the result is now better (I took the opportunity to add more doc and fix my mistake in 19108957e3a642767237f7b8552faccac950a70a)


v6 tunneling: cannot ping remote cilium_host ip

(Not related to nodeport, just plain tunneling mode.)

Behavior is exactly the same as in 1.5, no regression. cilium_host gets the public v6 addr as /128 assigned, so cannot be pinged via tunnel at the moment.


How to get list of user's followers from user or Follow all followers from user??

How to get a list of all followers from username and make txt file with this information ?
Is it possible?
example
bot.get_user_followers("danbilzerian")

output from bot.get_user_followers("danbilzerian") is a lists, you can write it into file


rez-suite broken in 2.104.7- cannot add second context

The following fails for me:
generate two contexts from two different packages
rez env sgq_schema -o sgqschema.rxt
rez env am_query -o amquery.rxt
create the suite
rez suite --create ./misc_suite
add the first context
rez suite --add ./sgqschema.rxt --context sqgschema
attempt to add the second context per the documentation
rez suite --add ./amquery.rxt --context amquery
Traceback (most recent call last):
  File "/laika/depts/prod_tech/rez/lib/python/linux/rez/bin/rez/rez-suite", line 8, in <module>
    sys.exit(run_rez_suite())
  File "/net/ent-prod.nfs.laika.com/ifs/laika/depts/prod_tech/rez/lib/python/linux/rez-2.104.7/lib/python2.7/site-packages/rez/cli/_entry_points.py", line 239, in run_rez_suite
    return run("suite")
  File "/net/ent-prod.nfs.laika.com/ifs/laika/depts/prod_tech/rez/lib/python/linux/rez-2.104.7/lib/python2.7/site-packages/rez/cli/_main.py", line 191, in run
    returncode = run_cmd()
  File "/net/ent-prod.nfs.laika.com/ifs/laika/depts/prod_tech/rez/lib/python/linux/rez-2.104.7/lib/python2.7/site-packages/rez/cli/_main.py", line 183, in run_cmd
    return func(opts, opts.parser, extra_arg_groups)
  File "/net/ent-prod.nfs.laika.com/ifs/laika/depts/prod_tech/rez/lib/python/linux/rez-2.104.7/lib/python2.7/site-packages/rez/cli/suite.py", line 200, in command
    suite.save(opts.DIR)
  File "/net/ent-prod.nfs.laika.com/ifs/laika/depts/prod_tech/rez/lib/python/linux/rez-2.104.7/lib/python2.7/site-packages/rez/suite.py", line 442, in save
    shutil.rmtree(path)
  File "/net/ent-prod.nfs.laika.com/ifs/laika/home/j/jgerber/packages/python/2.7.18/platform-linux/arch-x86_64/os-CentOS-7.7.1908/lib/python2.7/shutil.py", line 270, in rmtree
    rmtree(fullname, ignore_errors, onerror)
  File "/net/ent-prod.nfs.laika.com/ifs/laika/home/j/jgerber/packages/python/2.7.18/platform-linux/arch-x86_64/os-CentOS-7.7.1908/lib/python2.7/shutil.py", line 279, in rmtree
    onerror(os.rmdir, path, sys.exc_info())
  File "/net/ent-prod.nfs.laika.com/ifs/laika/home/j/jgerber/packages/python/2.7.18/platform-linux/arch-x86_64/os-CentOS-7.7.1908/lib/python2.7/shutil.py", line 277, in rmtree
    os.rmdir(path)
OSError: [Errno 39] Directory not empty: '/net/ent-prod.nfs.laika.com/ifs/laika/dist/rel/packages/rez-suites/linux/cli_utils/contexts'

At the point of failure, the bin directory and suite.yaml have both been removed. (why?)
I know that this used to work with previous versions.

this is on Centos 7 and the location in question is mounted over NFS.
Interestingly enough, when I inspect the directory in question, it appears empty ( ls -a yields nothing).
I will give this a try on local disk to rule out issues around shared storage

This works locally. So i suppose it is related to NFS. Interestingly, this just started happening for us. This appears to be a known outcome when using shutil.rmtree on nfs mounted directories.... I wonder if it would be reasonable to add ignore_errors=True to the shutil.rmtree call in save....

I patched our code to see if this approach fixed our issue and it did.

Ah righto, could you add some more info so I can follow this up and
potentially fix in rez also? So you're saying there's a known issue with
shutil.rmtree over nfs..? Do you know how that's specifically then
manifesting in the second 'context add' failing?
Cheers
A
On Thu, Feb 24, 2022 at 11:32 AM jlgerber @.***> wrote:

I patched our code to see if this approach fixed our issue and it did.
—
Reply to this email directly, view it on GitHub
https://github.com/nerdvegas/rez/issues/1222#issuecomment-1049363212,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMOUSQKOHTOWOUIZFNV4FDU4V4DNANCNFSM5OY36PGQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

sure thing.
I based the comment on a cursory google search of "shutil.rmtree nfs". I will instrument the call to see if I can determine what is triggering the failure. By the time the exception is thrown, the directory is in fact empty.


onSnapToItem not called if loop={false}

Hi. Cool component.
I was able to fix the above changing the following, but I didn't do a PR as I didn't take the time to check what the knock-on effects could be. Hope it helps.
useAnimatedReaction(
        () => index.value,
        (i) => {
            if (loop) {
                switch (_data.length) {
                    case 1:
                        i = 0;
                        break;
                    case 2:
                        i = i % 2;
                        break;
                }
                onSnapToItem && runOnJS(onSnapToItem)(i);
            } else {
                onSnapToItem && runOnJS(onSnapToItem)(i);
            }
        },
        [onSnapToItem, loop, _data]
    );

cool I'll try it

v5.0


Documentation for Kafka/Pulsar client wrapper

Motivation
Added documentation for the Kafka compatible wrapper on top of Pulsar client API introduced in #761

ping @rdhabalia


gen2 creating wrong type for timestamp GSI Input

Environment information
System:
  OS: macOS 14.4.1
  CPU: (12) x64 Apple M2 Max
  Memory: 2.85 GB / 96.00 GB
  Shell: /bin/zsh
Binaries:
  Node: 20.5.0 - ~/.nvm/versions/node/v20.5.0/bin/node
  Yarn: undefined - undefined
  npm: 9.8.0 - ~/.nvm/versions/node/v20.5.0/bin/npm
  pnpm: undefined - undefined
NPM Packages:
  @aws-amplify/backend: 1.0.0
  @aws-amplify/backend-cli: 1.0.1
  aws-amplify: 6.2.0
  aws-cdk: 2.140.0
  aws-cdk-lib: 2.140.0
  typescript: 5.4.5
AWS environment variables:
  AWS_STS_REGIONAL_ENDPOINTS = regional
  AWS_NODEJS_CONNECTION_REUSE_ENABLED = 1
  AWS_SDK_LOAD_CONFIG = 1
No CDK environment variables

Description
Gen 2 is creating the wrong type for an AWSTimestamp sortkey Input in GSI - Schema is created with a timestamp as a sort key on secondary index.
Schema
const schema = a.schema({
  Post: a
    .model({
      content: a.string(),
      isDone: a.boolean(),
      timestamp: a.timestamp(),
    })
    .authorization((allow) => [allow.owner(), allow.authenticated().to(['read'])]),
  PostLikes: a
    .model({
      postId: a.string().required(),
      userId: a.string().required(),
      timestamp: a.timestamp(),
    })
    .identifier(['postId', 'userId'])
    .secondaryIndexes((index) => [index('userId').sortKeys(['timestamp']), index('postId')])
    .authorization((allow) => [
      allow.owner().to(['create', 'read', 'update', 'delete']),
      allow.authenticated().to(['create', 'read']),
      allow.groups(['admin']).to(['read', 'delete']),
    ]),
})

Initially I saw this breaking on a list call to the index
const { data: postLikes, errors } = await client.models.PostLikes.listPostLikesByUserIdAndTimestamp(
          {
            userId: user,
          },
          {
            authMode: 'userPool',
          }
        )

with Error
TypeError: Cannot convert undefined or null to object
root cause
"Validation error of type UnknownType: Unknown type ModelAWSTimestampKeyConditionInput"
Further investigation -
The generated schema created for the index timestamp type is ModelIntKeyConditionInput and not  ModelAWSTimestampKeyConditionInput
input ModelIntKeyConditionInput {
    eq: Int
    le: Int
    lt: Int
    ge: Int
    gt: Int
    between: [Int]
}

Manually changing this in the console to corrected values fixes the issue - also type on query
input ModelAWSTimestampKeyConditionInput {
    eq: AWSTimestamp
    le: AWSTimestamp
    lt: AWSTimestamp
    ge: AWSTimestamp
    gt: AWSTimestamp
    between: [AWSTimestamp]
}

unsure where this type inference for AWSTimestamp on GSI sort key input happens but having it as Int is breaking.

Hi @riacoding, thanks for reaching out. I am able to reproduce this with the given schema and marked it as a bug. I have noticed that this issue exists in Gen-1 as well.

Hi @riacoding, we just released a fix for this issue in Gen 2 with @aws-amplify/data-schema v1.3.5. Please upgrade your amplify backend and data-schema packages to the latest versions.
npm install @aws-amplify/backend@latest @aws-amplify/backend-cli@latest

npm update @aws-amplify/data-schema

Closing this as fixed for Gen 2. I'm not sure if this issue is present in Gen 1, from what I can tell the types are generated correctly for timestamp inputs.
transformed schema:
listPostLikesByUserIdAndTimestamp(userId: String!, timestamp: ModelIntKeyConditionInput, sortDirection: ModelSortDirection, filter: ModelPostLikesFilterInput, limit: Int, nextToken: String): ModelPostLikesConnection @aws_iam @aws_cognito_user_pools

graphql client code:
query ListPostLikesByUserIdAndTimestamp(
  $filter: ModelPostLikesFilterInput
  $limit: Int
  $nextToken: String
  $sortDirection: ModelSortDirection
  $timestamp: ModelIntKeyConditionInput
  $userId: String!
) {
  # ...
}

But, if I'm mistaken, we can create a separate issue for Gen 1.


Refactor Tock to an OO implementation

This refactor fixes misuse of this inside _tick() which contaminated global namespace.
This implementation is much more memory efficient since it's not redefining the inner functions of Tock on every instance generation. Instead they reuse all the module's private functions via closure and Tock's public methods on its prototype.
Note that everything should remain the same, except for passing reference to a method of a Tock's instance. This should be done with care since state is now managed in an OO way via this.

@mrchimp should I resolve these conflicts? Are you even considering this PR?
BTW, I've found bugs in the tick mechanism and fixed it for the regular Tock, i.e. not countdown.
If this PR is of any interest I can also fix it for countdown mode and send updates on this PR.

Hi Yehonatan
Sorry, been busy over the holidays. Back to work today. Definitely
considering merging this. If you could resolve the conflicts and update the
PR that would be ideal.
Cheers!
On 5 January 2015 at 08:35, Yehonatan Daniv<EMAIL_ADDRESS>wrote:

@mrchimp https://github.com/mrchimp should I resolve these conflicts?
Are you even considering this PR?
BTW, I've found bugs in the tick mechanism and fixed it for the regular
Tock, i.e. not countdown.
If this PR is of any interest I can also fix it for countdown mode and
send updates on this PR.
—
Reply to this email directly or view it on GitHub
https://github.com/mrchimp/tock/pull/21#issuecomment-68680205.

Sure thing :+1:

Closing, see resolved and updated PR #22