optimising "from_scanpy" function

PR Checklist

[x] Referenced issue is linked isse: 438
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] Documentation in docs is updated

Description of changes
Have removed "for" loop for optimising and even used set operations for curation of covariate_obs list.
Technical details
Created a temp_df variable for storing the groupby generated data frame and then filtered the columns of the newly generated data frame to remove inconsistent covariate_obs.
Also covariate_obs += [i for i in sample_identifier if i not in covariate_obs] is changed into covariate_obs = list(set(covariate_obs + sample_identifier))
Additional context
Needed a test database where I can compare the speed.  I used a very small dataset, thus can't be tested properly.

Thanks!

It needs to be tested properly. We cannot merge code that has not been tested. You will need to create a proper AnnData object then.
Please create a quick reproducible script that shows how you timed it.
Show the before and after numbers.
No uncommented code please. It has to be removed.

This task probably takes a tiny bit more time so don't be confused if you're working on this for a bit longer.

import pandas as pd
import scanpy as sc
import pertpy as pt

adata = pt.dt.haber_2017_regions() #Reading the dataset
sccoda = pt.tl.Sccoda()

sample_identifier = "batch"
cell_type_identifier = "cell_label"
covariate_df = None
covariate_obs = ["condition"]
covariate_uns = None

#Updated version

if isinstance(sample_identifier, str):
    sample_identifier = [sample_identifier]

start = time.time() #Starting the timer
if covariate_obs:
    covariate_obs = list(set(covariate_obs + sample_identifier)) #Unique element list
else:
    covariate_obs = sample_identifier  # type: ignore
end = time.time()
time1 = end-start #Time taken to run the above code

# join sample identifiers
if isinstance(sample_identifier, list):
    adata.obs["scCODA_sample_id"] = adata.obs[sample_identifier].agg("-".join, axis=1)
    sample_identifier = "scCODA_sample_id"

# get cell type counts
groups = adata.obs.value_counts([sample_identifier, cell_type_identifier])
count_data = groups.unstack(level=cell_type_identifier)
count_data = count_data.fillna(0)

# get covariates from different sources
covariate_df_ = pd.DataFrame(index=count_data.index)

if covariate_df is None and covariate_obs is None and covariate_uns is None:
    print("No covariate information specified!")

if covariate_uns is not None:
    covariate_df_uns = pd.DataFrame(adata.uns[covariate_uns])
    covariate_df_ = pd.concat((covariate_df_, covariate_df_uns), axis=1)

start = time.time()
if covariate_obs is not None:
    temp_df = adata.obs.groupby(sample_identifier).nunique()[covariate_obs] # grouped dataset with columns from covariate_obs and rows are the unique values of sample across covariate_obs
    covariate_obs = temp_df.columns[temp_df.nunique() == 1] # columsn which will have values other than 1 will be removed
    covariate_df_obs = adata.obs.groupby(sample_identifier).first()[covariate_obs]
    covariate_df_ = pd.concat((covariate_df_, covariate_df_obs), axis=1)
end = time.time()
time2 = end-start #Time taken to run the above code
print(f"Updated code takes {time1+time2} seconds")
print("The datasete will look like: ")
print(covariate_df_)

#Older version
adata = pt.dt.haber_2017_regions()
adata = sc.read_h5ad("haber_count.h5ad")
sccoda = pt.tl.Sccoda()

sample_identifier = "batch"
cell_type_identifier = "cell_label"
covariate_df = None
covariate_obs = ["condition"]
covariate_uns = None

if isinstance(sample_identifier, str):
    sample_identifier = [sample_identifier]

start = time.time()
if covariate_obs is not None:
    covariate_obs += [i for i in sample_identifier if i not in covariate_obs]
else:
    covariate_obs = sample_identifier  # type: ignore
end = time.time()
time1 = end-start

# join sample identifiers
if isinstance(sample_identifier, list):
    adata.obs["scCODA_sample_id"] = adata.obs[sample_identifier].agg("-".join, axis=1)
    sample_identifier = "scCODA_sample_id"

# get cell type counts
groups = adata.obs.value_counts([sample_identifier, cell_type_identifier])
count_data = groups.unstack(level=cell_type_identifier)
count_data = count_data.fillna(0)

# get covariates from different sources
covariate_df_ = pd.DataFrame(index=count_data.index)

if covariate_df is None and covariate_obs is None and covariate_uns is None:
    print("No covariate information specified!")

if covariate_uns is not None:
    covariate_df_uns = pd.DataFrame(adata.uns[covariate_uns])
    covariate_df_ = pd.concat((covariate_df_, covariate_df_uns), axis=1)

start = time.time()
if covariate_obs is not None:
    for c in covariate_obs:
        if any(adata.obs.groupby(sample_identifier).nunique()[c] != 1):
            print(f"Covariate {c} has non-unique values! Skipping...")
            covariate_obs.remove(c)

    covariate_df_obs = adata.obs.groupby(sample_identifier).first()[covariate_obs]
    covariate_df_ = pd.concat((covariate_df_, covariate_df_obs), axis=1)
end = time.time()
time2 = end-start
print(f"old code takes {time1+time2} seconds")
print("The datasete will look like: ")
print(covariate_df_)```

script for testing the execution time and the output code for updated and older version.

Good! Now, please use this script to

The behavior of before and after is NOT allowed to change. Consider all possible if cases. Test this well.
The new solution must run ~10-100 times faster.
Use https://github.com/nschloe/tuna to profile code if necessary
Don't forget to update the code in this PR with your new solution then :)

Superseded by https://github.com/theislab/pertpy/pull/473


Support AdonisJS v6

I read on https://v6-migration.adonisjs.com/guides/introduction#official-packages-not-yet-compatible-with-v6 that @adonisjs/drive is one of the official packages that yet has to be migrated to work with v6.
Is there any ETA for it? It keeps us from being able to finish the upgrade completely.

Hey @mcmxcdev! 👋🏻
As of now, we don't have a specific ETA for this project. We're aiming to kick things off in early March, though please note that this timeline isn't set in stone.

Any updates on this pls?

Moved to Insiders program roadmap.

Shipped. https://docs.adonisjs.com/guides/digging-deeper/drive

Shipped. https://docs.adonisjs.com/guides/digging-deeper/drive

Thank yo so much!


Laravel 8.x is supported now

Description
Changed

Laravel 8.x is supported now
Minimal Laravel version now is 6.0 (Laravel 5.5 LTS got last security update August 30th, 2020)

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made changes in CHANGELOG.md file

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              master       #11   +/-   ##
===========================================
  Coverage     100.00%   100.00%
  Complexity        56        56
===========================================
  Files             10        10
  Lines            124       125    +1
===========================================
+ Hits             124       125    +1

Flag
Coverage Δ
Complexity Δ

#php
100.00% <ø> (ø)
56.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ
Complexity Δ

src/ServiceProvider.php
100.00% <0.00%> (ø)
8.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6469123...0774f0b. Read the comment docs.


To many things are colored blue

Github rolled out a change to this tree-sitter grammar yesterday and since that the highlighting of nix files is mostly shades of blue eg https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/misc/hello/default.nix
I think before at least attr keys where colored yellow and there were probably some other differences I can't recall right now.
I think we should compare color coding with the grammar github used before https://github.com/sambacha/nix-linguist to make this one a bit more colorful and helpful to the eye.

https://github.com/NixOS/nixpkgs/issues/135678#issuecomment-906320848
Old ss

New ss


Mobile Responsive form for subscription Buttons

The "Buy Now" button has an awesome mobile UX.  Looking for the exact same experience with the subscription button.  Would be so awesome!

Bueller?  Bueller?  ........Bueller?
As of today there still seems to be no responsive checkout page for the PayPal subscription button.  PayPal says it has been progressively rolling out responsive button-instigated pages but not for subscriptions or donations yet.

Any updates on this?

Paypal ?

Please can we have an update.

Any updates?

Any progress?

Wow... 2017 and still not responsive. WTF?


fixed typos in help output

Hi, awesome tool and video series with Stök. I just saw the typo in the video and thought i fix it. ✌

Good spot, thanks for fixing!


Build Instructions

Hi, I'm looking to statically link this loader into MinGW project, but I can't find any instructions on how to build it.
Trying to build WebView2Loader.cpp, I get fatal error: 'appmodel.h' file not found.
I would love some help here

Sorry about that. I didn't set this up for MinGW yet, I'll try to take a look at it this weekend.

That would be great, thank you!

Oops, this turned out to be not as straightforward as I hoped due to the lack of proper WRL support in MinGW. With some amendments made, I now have a Makefile that makes it possible to compile with MSys2 MinGW 64. I can't guarantee too much about how well it works, though it seems to be doing roughly the same thing as the MSVC version.
This probably requires fairly cutting edge MinGW, so you would want to use an up-to-date MSys2 installation. Once you have one, the WebView2Loader.cpp file should just compile.


Introduction and Induction to Design Innovation

Introduction and Induction to Design Innovation
Abstract
Learn all about Design Odyssey’s DRIVE programme, and Entrepreneurship Centre’s IDEATEsomething. Session includes a Design Innovation exercise using Makey Makey!
Student Organisation organising this session
DO EXCO and DO team
Session intent (what to expect)
•	Participants will learn about Design Odyssey’s Drive program, and the opportunities available to them to Discover, Define, Develop and Deliver their self-initiated Social Innovations from Ideation to Business Pitching.
•	Participants will learn about the program offered by Entrepreneurship Centre, which will expose them to entrepreneurship, be informed on the Singapore startup landscape, and be equip from the ideation workshop with an opportunity to receive funding to further explore their ideas.
•	Sharing with Past Participants and their startup success!
•	Students will get a chance to participate in a 90 min Design Innovation and Makey Makey workshop.
Session details
Venue: Cohort Classroom 14 (Building 2, Level 5, 2.507)
Date: 24 May 2019 (Friday)
Time: 3pm to 6pm (Registration starts at 2.45pm)
Up to 50 participants only
Speakers/Workshop facilitators
•	Ms. Sio Lim, Associate Program Director, Design Odyssey, SUTD-MIT International Design Centre (IDC)
•	Mr. Arifin Chia, Manager, SUTD Entrepreneurship Centre
Logistical details
Please bring your own laptop, water bottle and a jacket if you find the classrooms cold!

Hi, I recommend shortening the title haha.
But anyway:
https://discover.sutd.dev/events.html#intro-design-innov
Please verify the details

Dear Sir,
The details are correct. Thank you.
Regards,
Loh Zhi Xuan
Get Outlook for Androidhttps://aka.ms/ghei36

From: Timothy Liu<EMAIL_ADDRESS>Sent: Friday, May 17, 2019 2:44:56 PM
To: OpenSUTD/discovery-week-working-title
Cc: beazt123; Author
Subject: Re: [OpenSUTD/discovery-week-working-title] Introduction and Induction to Design Innovation (#17)
Hi, I recommend shortening the title haha.
But anyway:
https://discover.sutd.dev/events.html#intro-design-innov
Please verify the details
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/OpenSUTD/discovery-week-working-title/issues/17?email_source=notifications&email_token=AMAH3ZMHCP3JLTCFZGUFBODPVZH6RA5CNFSM4HL4L7GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVT4QUQ#issuecomment-493340754, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMAH3ZOGXI6UQZVEGPICYYDPVZH6RANCNFSM4HL4L7GA.


R1.10

hey, thanks for the PR but I think something must have gone wrong. There are a lot of unrelated commits from another branch in here.
What were you trying to push and lets see how we can get it fixed up?

I've already merged back r1.10 into master


refact: Faster makefile

I've been studying C again recently and I found those changes improves the compile/test time a lot.

Codecov Report

Merging #53 (f382f8c) into main (cb48714) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   89.38%   89.38%
=======================================
  Files           4        4
  Lines         678      678
  Branches       57       57
=======================================
  Hits          606      606
  Misses         43       43
  Partials       29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb48714...f382f8c. Read the comment docs.


[Parser] Simplify sequence expression parsing

(Depends on https://github.com/apple/swift/pull/60731)
SequenceExprSyntax now gurantees that it has odd number elements using UnresolvedTernaryExpr/UnresolvedAsExpr/UnresolvedIsExpr.
Factored out the operator parsing into parseSequenceExpressionOperator() which returns the operator expresssion, and optionally the RHS, so we can avoid nested loops.
Also, parseSequenceExprssion() now has a performance optimization that avoids heap Array construction unless the expression is actually sequenced.

https://github.com/apple/swift/pull/60731
@swift-ci Please test


find files

find by

pattern
extension
name of file or folder
exclude certain names or folders
apply an operation to the finded file or folder

search for files or folders by extension, name has been added to the repo


Please check all of the platforms you are having the issue on (if platform is not listed, it is not supported)

[ ] iOS
[x] Android
[ ] UWP
[ ] .NET Standard

Version of Library
<IP_ADDRESS>0
Version of OS(s) listed above with issue
Android API 28
Steps to Reproduce

I have a bug after updating the plugin when I want to use the progress dialog. It does not appear and in debug nothing happens after using (IProgressDialog progressDialog = UserDialogs.Instance.Progress(Strings.messageUnzipAlertView, null, null, true, MaskType.Black))

Here is my function which allows you to unzip a zip file and display a progress dialog :
`public async static Task UnzipFileInDirectory(int currentVersion)
{
Assembly assembly = Assembly.GetExecutingAssembly();
Stream stream = assembly.GetManifestResourceStream(Strings.fileRessourcesName);
        // Create folder version
        IFolder rootFolder = await PCLHelper.CreateFolder((currentVersion + 1).ToString());

        ZipFile zipFile = null;

        try
        {
            zipFile = new ZipFile(stream);

            int filesOk = 0;

            using (IProgressDialog progressDialog = UserDialogs.Instance.Progress(Strings.messageUnzipAlertView, null, null, true, MaskType.Black))
            {
                foreach (ZipEntry zipEntry in zipFile)
                {
                    Stream zipEntryStream = zipFile.GetInputStream(zipEntry);
                    IFolder folder;

                    if (zipEntry.Name.EndsWith("/", StringComparison.Ordinal))
                    {
                        folder = await PCLHelper.CreateFolder(zipEntry.Name, rootFolder);
                        System.Diagnostics.Debug.WriteLine("Directory created : " + folder.Path);
                    }
                    else
                    {
                        folder = rootFolder;

                        // Create the file in file system and copy entry stream to it
                        IFile zipEntryFile = await rootFolder.CreateFileAsync(zipEntry.Name, CreationCollisionOption.FailIfExists);
                        using (Stream outPutFileStream = await zipEntryFile.OpenAsync(PCLStorage.FileAccess.ReadAndWrite))
                        {
                            await zipEntryStream.CopyToAsync(outPutFileStream);
                            System.Diagnostics.Debug.WriteLine("File created : " + zipEntryFile.Path);
                        }
                    }

                    filesOk++;

                    int percentage = unchecked((int)((filesOk * 100) / zipFile.Count) + 1);

                    // Update progress loader
                    progressDialog.PercentComplete = percentage;
                }

                await Task.Delay(1000);
            }

            return true;
        }
        catch (Exception ex)
        {
            System.Diagnostics.Debug.WriteLine("Error unzip file : " + ex);

            return false;
        }
        finally
        {
            if (zipFile != null)
            {
                zipFile.IsStreamOwner = true;
                zipFile.Close();
            }
        }
    }`

Expected Behavior
Actual Behavior
Version 7.0.1 works perfectly so I don't really understand why the progress dialog no longer appears and blocks the rest of the code...

It works fine for me.  Nothing has changed in this area in quite some time


Bluetooth: BAP: Shell: Add better checks for bis_sync

Since the BIS indexes start at 0x01, then BIT(0) is a invalid BIS sync value and shall not be sent by the broadcast assistant.

I guess this is post-3.5, since it's just for shell input. That said, wouldn't it be useful to be able to test another peer device's handling of invalid values by allowing such input in the shell?

I guess this is post-3.5, since it's just for shell input. That said, wouldn't it be useful to be able to test another peer device's handling of invalid values by allowing such input in the shell?

Hmm, arguably yes, but the shell (at least the audio shell) has not been designed to be a lower tester, and the this check for valid bis_sync is also present the Broadcast Assistant API as well.


Link list, interactive background should extend to edge of rules

Detailed description
Describe in detail the issue you're having.
When hovering or clicking on the link list, the interactive background does not extend to the same width as the rules.
Current:

Is this a feature request (new component, new icon), a bug, or a general issue?
Design defect
Is this issue related to a specific component?
Card
What did you expect to happen? What happened instead? What would you like to see changed?
On hover/click, the full width of the link list should have a background change and should be clickable.
Desired:

What browser are you working in?
Chrome
What offering/product do you work on? Any pressing ship or release dates we should be aware of?
Web simplification
Steps to reproduce the issue
Open the pattern in Storybook and hover/click on either of the links.

Is this same bug as https://github.com/carbon-design-system/ibm-dotcom-library/issues/1579


tags with spaces do not correctly show related entities

Describe the bug
when you create a tag with spaces, say "my tag" and then navigate to its profile page, it does not correctly show the assets it is associated with.
To Reproduce
Steps to reproduce the behavior:

navigate to dataset page
click add tag
create new tag with spaces
navigate to tag profile
see "no enities" linked to the tag

think this may have to do with name encoding? also doesn't work for search filtering.
Expected behavior
tag should clearly point back to the asset

This has also been reported with Glossary Terms

I there! I believe this should have been fixed.


Conditional @mention in PRs

I'd like to have an option that I am not notified unless a reviewer @ me. Telling me that my pr needs to be approved is redundant since I manually allowed msftbot to make PRs on my behalf, so I know what will occur. A year or two ago, I would release multiple updates in a single day, so imagine the notifications I'd get then.
Originally posted by @elibroftw in https://github.com/microsoft/winget-pkgs/issues/62956#issuecomment-1147981479

I need to look and see if there is a good way to make the @mention configurable in bot messages.
Some users might need the notification while others may not.

blocking the bot or unsubbing from prs?

I want to be auto-unsubbed from PRs and I don't want the bot mentioning me when things are going according to plan. There will always be a) manual approval required b) merging after approval.
Developers should only be mentioned when things fail. Otherwise, a habit of deleting winget related notifications will end up with someone missing an important email about a failure.

I guess @vedantmgoyal2009's bot should also allow auto-unsubbing from the PR

Yes, I was talking about a fix from both you and the microsoft bot. If you unsub from from the start, and the bot never mentions me, then all is well.

The microsoft bot shouldn't need to @ anyways, since subscribed users would have gotten an email anyways.

I believe @Trenly has gone through the bot mentions and helped scrub the @ mentions unless there is a failure. The comments from the bots also contain a "Template/foo/bar" type of text in the body so e-mail rules can be built around specific comments.
Is that sufficient to consider this issue closed?

I guess so thanks.


Improvements to qx publish support for multiple libraries in a repository

create index file with --create-index
all Manifest.json files are updated with new version number
ability to select main library which determines version (so that version numbers in the libraries do not have to be manually updated)

merging, thank you @cboulanger


Implement GetByMember function in PMS project manager

Coverage decreased (-0.1%) to 53.465% when pulling 016af6bc785affd23d4c1b0445616b12c189afd0 on ywk253100:170627_service_account into a64926231d075918b07a703ee1cacc6eebd56b12 on vmware:master.


Preview is going to black when try to add photo on instagram using scrcpy

Hello folks,
I recently installed scrcpy 1.12.1 64 on Windows 10 and I am using it with Mi9 over USB 3.0 port. It works almost flawlessy except one moment when I try to add a new photo over official Instagram app. Instagram works ok all the time, but when I hit this + button then Instagram is going black.
Upper and lower part of the phone screen are available.

I noticed a weird thing that when I try dropdown upper bar then I can see this upload new image to Instagram form.

Do you have same issue?
Thanks for this amazing peace of software anyway.

Probably some kind of hardware acceleration, where the image cannot be captured.

I'm facing exactly the same issue. I have a Xiomi device.

Any workaround found for that? How do we disable hardware acceleration?

I'm having the exact same issue with my Xiaomi Mi9. Is this device related?

Me too. (Device Mi)


ci(workflow): Add workflow for copying necessary files to Zephyr HAL repo

Mirror MSDK files used by Zephyr port
Description
The Zephyr port for the MAX32xxx devices uses files from this repo.  The port will not be accepted by the Zephyr review committee if it contains too many extraneous files.  This workflow will copy only the files that Zephyr needs into a stand-alone, slimmed down repository.

Really hoping the org allows for multi-repo access with workflows.


Add sendable conformance when available

Currently, using SemanticVersion in a Sendable context emits a compiler warning (and I assume an error in the future). Importing as @preconcurrency or adding an @unchecked conformance will resolve it but it would be preferable for that to be unnecessary.
This PR resolves that warning and the need to add conformance in downstream projects.

CLA signed and returned

Thanks so much @roanutil! Your CLA is all received and updated!

I'm not sure I can refresh the @cla-bot status, but if you push a commit or maybe even just force push the same commit, it should re-check and tag it @roanutil.

That got it!

Re-opened

Thanks a lot, @roanutil !


Update docs.min.js

[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/my-test/docs/

[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/my-test/docs/

[CI] Staging environment is at http://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/my-test/docs/

[CI] Staging environment is at http://cap-staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/my-test/docs/


Issues with iOS delaying rendering

Using your demo at https://mozilla.github.io/pdf.js/web/viewer.html and its included demo pdf, iOS 9 takes up to 10 seconds to start rendering, while iOS 8 seems to render immediately and then on subsequent refreshes of the page it never seems to render.  Sometimes on iOS 9, an orientation change seems to immediately start the rendering.  In web development tools (for the iOS 9 device), I'm seeing a pending xhr request for locale.properties and pdf.worker.js for the whole "delay" and only after this delay does it start loading the actual pdf document.
I'm starting to see these issues in my custom application for a client on his iOS devices as well so wondering if something has changed in an iOS or browser update.

Just as a note, disabling the worker seems to stop the issue.

WFM on iPhone 5S w/ iOS 9.3. What hardware and specific version of iOS are you testing on?


AttributeError: module 'tez' has no attribute 'Model'

updating to 0.6.0 will fix this error. please note that tez.Model will be deprecated soon and will no longer be supported.

If anyone having issue just first uninstall tez and then install 0.6.0 version.
pip uninstall tez
pip install -Iv tez==0.6.0


Add KeyInfo for Polish (Programmers) layout

Add KeyInfo for Polish (Programmers) layout on Windows and Linux
Notes:
On Windows Alt+Spacebar is hijacked by Windows
On Linux any Alt+F1-12 combination was not detected

Thanks for the help.


No Windows wheels on PyPI?

The master branch README says there are wheels on PyPI. But I look at PyPI and it looks like there aren't any. What gives?

The next release will have wheels for Windows. I want to add one or two more features before releasing the next version.

Alternatively, you can use the beta of the next version, https://github.com/wasmerio/python-ext-wasm/releases, if it's urgent. Or you can compile with just build on Windows to get it work. I hope it helps!
The release will come very soon.

No rush! I was just wondering if that's another mistake in README.

I did that to solve #29 (closed by #100), but it still lands on the master.

Next release will provide them. Closing this issue.


potential bugs and questions

Describe the Bug
1)url dismatch
2) replace_more (limit=None) makes the len(comments) bigger than original
3) could you make clear about what is difference between limit = 0 and None in replace_more
Desired Result

question 1
when inputing submission = reddit.submission(url = "https://www.reddit.com/r/funny/comments/3g1jfi/buttons/")
and expecting the output of print(submission.url)

is the outcome is  http://41.media.tumblr.com/a353323397c0aa0b4cfbc21eead3d48f/tumblr_ns7d7t7F6H1rvcmlco1_1280.jpg

question 2

the len() of toplevel of  reddit.submission.comments are different when replace_more  is 0 , None or no replace_more
the len(reddit.submission.comments ) is 198 when replace_more (limit=0)
the len(reddit.submission.comments ) is 218 when replace_more (limit=None)
the len(reddit.submission.comments ) is 199 when no replace_more
Code to reproduce the bug
import praw

reddit = praw.Reddit(
    "bot1"
)

submission = reddit.submission(url="https://www.reddit.com/r/funny/comments/3g1jfi/buttons/")
print(submission.url)
submission.comments.replace_more(limit=None)
print(len(submission.comments))

submission = reddit.submission(url="https://www.reddit.com/r/funny/comments/3g1jfi/buttons/")
submission.comments.replace_more(limit=0)
print(len(submission.comments))

submission = reddit.submission(url="https://www.reddit.com/r/funny/comments/3g1jfi/buttons/")
print(len(submission.comments))

My code does not include sensitive credentials

[X] Yes, I have removed sensitive credentials from my code.

Relevant Logs
http://41.media.tumblr.com/a353323397c0aa0b4cfbc21eead3d48f/tumblr_ns7d7t7F6H1rvcmlco1_1280.jpg
218
198
199

This code has previously worked as intended
Yes
Operating System/Environment
Windows
Python Version
3.10.13
PRAW Version
7.7.2.
Links, references, and/or additional comments?
No response

Historically, Reddit is a place to post links. The url attribute refers to the url that is posted not the oral of the post on Reddit. That would be post.shortlink or post.permalink.
limit=None means there is not a limit to how many more_comments PRAW will replace. limit=0 means no more_comments get replaced. This is explained in the docs.


Url computation issue

Hi,
in net.jawr.web.resource.bundle.css.CssImageUrlRewriter#getUrlPath
at line // Check if the URL is absolute, if it is return it as is.
If the url is something like url("/blablabla.css?ou=dfdf")
the return url is url("/blablabla.css")
Is it a normal behaviour?

Hi diocerty,
Sorry for the late reply.
This is the current behaviour.
The point is that the URL is rewritten to use  the hash of the CSS file.
Can you explain me what is the purpose of the parameter?
Does it make sense to keep it with the rewritten URL.
Cheers,

Hi,
I understand your question, but i don't see why this is a correct behavior to remove the parameter, especially regarding the comment just before "// Check if the URL is absolute, if it is return it as is."
Which is not the case actually

Hi diorcety
You're totally right.
I've missed the fact that it was a absolute path URL so it will not be rewritten.
I've created the JIRA JAWR-380 to follow this issue.
Thanks for the pull request.
Cheers,
icefox

Hi
This issue has been fixed in the main repository.
Thanks for reporting this issue and providing the patch.
Cheers,


"Component: Sl-Menu: Menu selection fires proper selection event" test passes in browser but not CLI

    actual: >
        2
    expected: >
        3
    Log: >

Resolved via https://github.com/softlayer/sl-ember-components/pull/197


Hotfix: Changed readme: added Python version

corrected the link for pip install
Recreated PR

@Ren22 what about the branch, do you still need it?

@intsco nope, I'll delete it


Should sshd-13 check for INFO instead of VERBOSE?

Hi,
I've been running the ssh-baseline for sometime and recently ran the CentOS 7 CIS-1 baseline and the xccdf_org.cisecurity.benchmarks_rule_5.2.3_Ensure_SSH_LogLevel_is_set_to_INFO control fails:
×  xccdf_org.cisecurity.benchmarks_rule_5.2.3_Ensure_SSH_LogLevel_is_set_to_INFO: Ensure SSH LogLevel is set to INFO
   ×  SSHD Configuration LogLevel should eq "INFO"

   expected: "INFO"
        got: "VERBOSE"

   (compared using ==)

This baseline recommends setting it to VERBOSE; should sshd-13 be updated to check for INFO instead?
Stephen

@atomic111 What do you think? At this point we set this to VERBOSE https://github.com/dev-sec/ssh-baseline/blob/d2e1fe01ad88b0990081f9eb6a3884f3dff11baa/controls/sshd_spec.rb#L166 to track potential attacks later. I agree with @shoekstra to align this baseline with CIS and STIG?

@shoekstra you are right the CIS recommends to set it Info, but from a security point of view, it is better to set it to verbose, because then you see more possible attacks on ssh. I prefer checking for Verbose

as far I can remember one of important differences was related to the fingerprints of logged-in keys: none in info but in verbose. Can somebody confirm that?
We can also accept both options in the baseline...

yeah: https://unix.stackexchange.com/questions/15575/can-i-find-out-which-ssh-key-was-used-to-access-an-account#15586

We could make this an attribute and leave the default to verbose. This would allow other users to change their default if they need to.

@chris-rock sounds good to me as well.
Another option might be like:
its('LogLevel') { should match(/^VERBOSE|INFO$/) }

I think a common attribute between the 2 profiles should do the trick. The default value is set on VERBOSE for this profile and INFO for the CIS one.
That way, there is no regression on any profile and a user can make them compatible by just setting the attribute.


Missing source variable in path

https://github.com/cfpb/generator-cf/blob/master/app/templates/_Gruntfile.js#L89 has 'src/vendor/*'listed, but it looks like it should be '<%%= loc.src %>/vendor/*'

This has been updated.


MFA QR Code blocked by CORS

unfortunately, the Google QR Chart service is deprecated, and this isn't a CORS issue, the image just doesn't exist
https://developers.google.com/chart/infographics/docs/qr_codes


Wider spacing on umlaut over ä

Love the font! I found the spacing over the ä a tiny bit too close (and it stuck out next to the other umlauted characters often used in german) so I made it a bit wider. It was a bit less clear in the pixelated fonts especially.
I do not fully understand why there are three äs in the latin file, so, please let me know if I've done something strange there, but it was so easy to patch I figured I'd submit it.
Before

After

I guess this is not interesting so I will close it. Thanks for the font, I love it otherwise!


Play 2.4 support

It would be great to have this useful plugin running for 2.4 ;)
Thanks!

I created a bountysource here for this issue: https://www.bountysource.com/issues/9748618-play-2-4-support
Or, if someone else wants to make a pull request I would be happy to merge it.

FYI For those searching, there is a working 2.4.x fork here (https://github.com/Enalmada/play-jsonp-filter) if you don't need custom codec or callback parameter name.  The only thing stopping that fork from being merged is being able to pass custom parameter and codec to the filter so someone please try and figure that out!


fix(all): References to esm type declarations

In all the package.json files for the packages there were lines like these
"exports": {
    ".": {
      "import": {
        "types": "./dist/index.d.ts",
        "default": "./dist/index.mjs"
      },
      "require": {
        "types": "./dist/index.d.ts",
        "default": "./dist/index.js"
      }
    }
  },

This would break when importing from ESM.
Example of error:

tsup emits .d.mts files so in this PR i just fixed the package.json files to include them and it fixes this issue.

Thanks @janek515 for noticing the detail and helping out!


Allow tagging

Allow tagging when adding a new entry.
Suggestion: -t for as flag for tags.
Example:
memb "tar -xzf" -t "unzip,tar,gzip,"

Not needed for now. Closed.


test(e2e-tests): updated Planning Application Number submission feature

Ticket Number
UCD-1037
Description of change
Updated feature file to include max character constraint example

Simon told me that as we are just changing the test code we should put
chore(e2e-tests): message
instead of feat or fix

Simon told me that as we are just changing the test code we should put
chore(e2e-tests): message
instead of feat or fix

Thanks for approval. Interesting point about chore or test. In this case it is looks to me like a test commit.


Backend edits

added the hello world function to the backend section

This seems to be a PR that should have been made to the fork instead.


Avoid generating wires for function args which are constant

Resolves #2296. Any feedback is greatly appreciated!

Hi @zachjs we noticed one thing that is not working any more (worked before this change), please try next case
module test (
  input [7:0] a,
  output [7:0] b
);
  function [7:0] f;
    input [7:0] v;
    input off;
    integer off;
    begin
      f = v + off;
    end
  endfunction
  assign b = f(a, 42);
endmodule

Just use yosys test.v  and it will produce error. Verific and other tools (iverilog and verilator) works just fine.
For reference error text is :
test.v:13: ERROR: Incompatible re-declaration of wire \off


Fix boost build error

@ximinez

:+1: contingent on Travis success.

"Fix Travis compile"

Merged as 6a8d24372ea33c35facfd4a329e3946b43309c01.


Figure out what to do with Anopheles amhaicus

Original VBcv term:
[Term]
id: VBsp:0000067
name: Anopheles amhaicus
alt_id: NCBITaxon:193510
def: "A member species of the species complex Anopheles gambiae sensu lato. All populations found in Ethiopia." [PT:PT]
synonym: "Anopheles quadriannualtus B " EXACT []
synonym: "Anopheles quadriannulatus sp. B" EXACT []
xref: NCBITaxon:193510
is_a: VBsp:0003480 ! Anopheles gambiae sensu lato
created_by: Topito
creation_date: 2013-05-30T22:57:53Z

Not in NCBI
No results found for "Anopheles amhaicus" in Google
Only seen in VBP0000794 - pubmed ID 35030201
Sarah, please could you figure out if this really is Anopheles quadriannualtus B...

Oh, looks like it was a typo.
Anopheles amharicus seems more correct. Not in NCBI still though.

@bobular What is the parent term of 'Anopheles amharicus'? Is it Anopheles quadriannulatus B or a kind of it?
Besides, I cannot find 'Anopheles gambiae sensu lato' in NCBITaxon.

So I found this paper!
https://pubmed.ncbi.nlm.nih.gov/26131476/
and this
https://www.wrbu.si.edu/vectorspecies/mosquitoes/amharicus
Showing that Anopheles amharicus parent term should be Anopheles gambiae sensu lato which I think in NCBItaxon (which seems confusing to me)! It would be the gambiae complex term.
I hope that helps!

@SAK22 Thanks for finding the reference paper. I cannot find 'Anopheles gambiae sensu lato' in NCBITaxon but in MIRO. The similar label I found in NCBITaxon is Anopheles letifer sensu lato. I don't think it is correct. Could you please help with it? Thanks!

No that is not correct you are right, in NCBITaxon it is as I confirm above. It would be the 'gambiae complex'. Hope that helps!

Thanks! @SAK22

Thanks both.  Should Anopheles quadriannulatus B be a synonym, @SAK22 ?

@bobular @zhengj2007 I found papers that state these two things below, so YES I think it should be a synonym.
Two new species within the Anopheles gambiae complex are here described and named. Based on molecular and bionomical evidence, the An. gambiae molecular "M form" is named Anopheles coluzzii Coetzee & Wilkerson sp. n., while the "S form" retains the nominotypical name Anopheles gambiae Giles. Anopheles quadriannulatus is retained for the southern African populations of this species, while the Ethiopian species is named Anopheles amharicus Hunt, Wilkerson & Coetzee sp. n., based on chromosomal, cross-mating and molecular evidence.
Sibling species A and B of Anopheles quadriannulatus (Theobald) are recognized as allopatric members of the Anopheles gambiae Giles complex of Afrotropical mosquitoes (Diptera: Culicidae). Species A represents An. quadriannulatus sensu stricto, widespread in southern Africa, whereas An. quadriannulatus species B occurs in Ethiopia.

Since 'Anopheles quadriannulatus B' is a NCBITaxon term, how about we import the term in the VEuPathDB ontology?
Add Anopheles quadriannulatus B in the VEuPathDB ontology

synonym: 'Anopheles amharicus' and 'Anopheles quadriannulatus sp. B' as synonym
parent gambiae species complex

@bobular @SAK22 Does it work?

Works for me, @bobular does that work for you?

Yes that's great @zhengj2007 @SAK22  Thanks!

@johnwjudkins Do you want to work on the issue or you'd prefer I take care of it?


[Feature request]: Run on startup  from windows apps

Version

[X] I'm using version 1.15.1

Existing requests

[X] I've checked Existing requests

Advanced Preferences

[X] I've checked Advanced Preferences

What operating system are you using?
Windows
Operating System Version
10
Problem description
please add run on startup automaticly
Possible solution
please add run on startup automaticly
Alternative solutions
please add run on startup automaticly
Additional information
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi, how did you install? Regular installer has this functionality. If you installed from Windows Store, unfortunatelly there is a bug in library I use and I am waiting for fix

you are right the regular installer is working normally i saw this problem because i installed it from Windows apps


WIP: Move cors from macaron to chi and also apply cors to all routers from only /api

This maybe a break change

Codecov Report

Merging #13621 (9cbb2f4) into master (5a991ec) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #13621      +/-   ##
==========================================
- Coverage   42.21%   42.20%   -0.02%
==========================================
  Files         697      697
  Lines       76563    76561       -2
==========================================
- Hits        32320    32310      -10
- Misses      38945    38952       +7
- Partials     5298     5299       +1

Impacted Files
Coverage Δ

routers/routes/chi.go
34.33% <0.00%> (-1.52%)
:arrow_down:

routers/routes/macaron.go
93.64% <ø> (+1.10%)
:arrow_up:

modules/util/timer.go
42.85% <0.00%> (-42.86%)
:arrow_down:

modules/process/manager.go
72.50% <0.00%> (-2.50%)
:arrow_down:

modules/log/event.go
59.90% <0.00%> (-1.89%)
:arrow_down:

modules/queue/workerpool.go
58.77% <0.00%> (-1.23%)
:arrow_down:

services/pull/pull.go
41.27% <0.00%> (+0.49%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a991ec...9cbb2f4. Read the comment docs.

Can we maybe consolidate our CORS setting here too? We have the cors category and then there's the sole repository.ACCESS_CONTROL_ALLOW_ORIGIN.

blocked by #13857

replaced by #14293

replaced by #14293


meteor up deployment failed

Hi ,
Im facing issue when going to deploy my meteor up with AWS.
Its showing following error:
$mupx setup
Meteor Up: Production Quality Meteor Deployments
Configuration file : mup.json
Settings file      : settings.json
“ Checkout Kadira!
It's the best way to monitor performance of your app.
Visit: https://kadira.io/mup ”
Started TaskList: Setup (linux)
[ec2-xxxxxxxxxxxxxxxxxxxxxxxx.compute.amazonaws.com] - Installing Docker
[ec2-xxxxxxxxxxxxxxxxxxxxxxxx.compute.amazonaws.com] - Installing Docker: SUCCESS
[ec2-xxxxxxxxxxxxxxxxxxxxxxxx.compute.amazonaws.com] - Setting up Environment
[ec2-xxxxxxxxxxxxxxxxxxxxxxxx.compute.amazonaws.com] - Setting up Environment: SUCCESS
[ec2-xxxxxxxxxxxxxxxxxxxxxxxx.compute.amazonaws.com] - Copying MongoDB configuration
[ec2-xxxxxxxxxxxxxxxxxxxxxxxx.compute.amazonaws.com] - Copying MongoDB configuration: SUCCESS
[ec2-xxxxxxxxxxxxxxxxxxxxxxxx.compute.amazonaws.com] - Installing MongoDB
[ec2-xxxxxxxxxxxxxxxxxxxxxxxx.compute.amazonaws.com] - Installing MongoDB: SUCCESS
D:\working\15march\qxmedics\myDevelopment>mupx deploy
Meteor Up: Production Quality Meteor Deployments
Configuration file : mup.json
Settings file      : settings.json
“ Checkout Kadira!
It's the best way to monitor performance of your app.
Visit: https://kadira.io/mup ”
Meteor app path    : D:\working\version1
Using buildOptions : {}
Started TaskList: Deploy app 'Qxmedics' (linux)
[ec2-xxxxxxxxxxxxxxxxxxxxxxxx.compute.amazonaws.com] - Uploading bundle
[ec2-xxxxxxxxxxxxxxxxxxxxxxxx.compute.amazonaws.com] - Uploading bundle: SUCCESS
[ec2-xxxxxxxxxxxxxxxxxxxxxxxx.compute.amazonaws.com] - Sending environment variables
[ec2-xxxxxxxxxxxxxxxxxxxxxxxx.compute.amazonaws.com] - Sending environment variables: SUCCESS
[ec2-xxxxxxxxxxxxxxxxxxxxxxxx.compute.amazonaws.com] - Initializing start script
[ec2-xxxxxxxxxxxxxxxxxxxxxxxx.compute.amazonaws.com] - Initializing start script: SUCCESS
[ec2-xxxxxxxxxxxxxxxxxxxxxxxx.compute.amazonaws.com] - Invoking deployment process
[ec2-xxxxxxxxxxxxxxxxxxxxxxxx.compute.amazonaws.com] - Invoking deployment process: SUCCESS
[ec2-xxxxxxxxxxxxxxxxxxxxxxxx.compute.amazonaws.com] - Verifying deployment
[ec2-xxxxxxxxxxxxxxxxxxxxxxxx.compute.amazonaws.com] x Verifying deployment: FAILED
    -----------------------------------STDERR-----------------------------------
     WARN deprecated   npm -g install npm@latest
    npm WARN deprecated
    npm WARN deprecated (Depending on how Node.js was installed on your system, you
    npm WARN deprecated may need to prefix the preceding commands with `sudo`, or if
    npm WARN deprecated on Windows, run them from an Administrator prompt.)
    npm WARN deprecated
    npm WARN deprecated If you're running the version of npm bundled with
    npm WARN deprecated Node.js 0.10 LTS, be aware that the next version of 0.10 LTS
    npm WARN deprecated will be bundled with a version of npm@2, which has some small
    npm WARN deprecated backwards-incompatible changes made to `npm run-script` and
    npm WARN deprecated semver behavior.
    npm WARN package.json<EMAIL_ADDRESS>No description
    npm WARN package.json<EMAIL_ADDRESS>No repository field.
    npm WARN package.json<EMAIL_ADDRESS>No README data

    ><EMAIL_ADDRESS>install /bundle/bundle/programs/server/node_modules/fibers
    > node ./build.js

    => Redeploying previous version of the app

    -----------------------------------STDOUT-----------------------------------

    To see more logs type 'mup logs --tail=50'

    ----------------------------------------------------------------------------`

Please help me out

Extending the deploy wait time usually helps here in the verify phase try 120
Otherwise please post your settings file contents Mayne that will reveal something.
Ubuntu 14+ is the only supported target platform.
Stick to mupx not mup unless you want to try the new version at kadirahq/meteor-up
Use setting node 0.10.40 and potentially update everything.

Hi James,
I tried  wait time 60, 120 and then 600 ... but its not working.
My last updated mup.json is
`{
// Server authentication info
"servers": [
{
"host": "ec2-XXXXXXXXXXX.us-west-2.compute.amazonaws.com",
"username": "ubuntu",
//"password": "password"
// or pem file (ssh based authentication)
"pem": "D:/Ubuntu.pem"
}
],
// Install MongoDB in the server, does not destroy local MongoDB on future setup
"setupMongo": true,
// WARNING: Node.js is required! Only skip if you already have Node.js installed on server.
"setupNode": true,
// WARNING: If nodeVersion omitted will setup 0.10.36 by default. Do not use v, only version number.
"nodeVersion": "0.10.40",
// Install PhantomJS in the server
"setupPhantom": true,
// Show a progress bar during the upload of the bundle to the server.
// Might cause an error in some rare cases if set to true, for instance in Shippable CI
"enableUploadProgressBar": true,
// Application name (No spaces)
"appName": "abc",
// Location of app (local directory)
"app": "D:/working/version1",
// Configure environment
"env": {
"PORT":80,
"ROOT_URL": "ec2-XXXXXXXXXXXXX.us-west-2.compute.amazonaws.com",
"MONGO_URL": "mongodb://localhost:27017/meteor"
},
// Meteor Up checks if the app comes online just after the deployment
// before mup checks that, it will wait for no. of seconds configured below
"deployCheckWaitTime": 600
}
`

Are you using the latest version of meteor?
Maybe some odd packages?
If you SSH into the machine can you tell if there's meteor running etc.
There's also an extended DEBUG=* mupx deploy command (careful with spacing) that gets extra log https://github.com/arunoda/meteor-up/tree/mupx#verbose-output

Im using<EMAIL_ADDRESS>

I'm using Meteor <IP_ADDRESS> got the same error here

Meteor Up: Production Quality Meteor Deployments
------------------------------------------------
Configuration file : mup.json
Settings file      : settings.json

Meteor app path    : /Users/tom/web/trusu
Using buildOptions : {}

Started TaskList: Deploy app 'trusu' (linux)
[<IP_ADDRESS>] - Uploading bundle
[<IP_ADDRESS>] - Uploading bundle: SUCCESS
[<IP_ADDRESS>] - Sending environment variables
[<IP_ADDRESS>] - Sending environment variables: SUCCESS
[<IP_ADDRESS>] - Initializing start script
[<IP_ADDRESS>] - Initializing start script: SUCCESS
[<IP_ADDRESS>] - Invoking deployment process
[<IP_ADDRESS>] - Invoking deployment process: SUCCESS
[<IP_ADDRESS>] - Verifying deployment
[<IP_ADDRESS>] x Verifying deployment: FAILED

	-----------------------------------STDERR-----------------------------------
	  npm -g install npm@latest
	npm WARN deprecated
	npm WARN deprecated (Depending on how Node.js was installed on your system, you
	npm WARN deprecated may need to prefix the preceding commands with `sudo`, or if
	npm WARN deprecated on Windows, run them from an Administrator prompt.)
	npm WARN deprecated
	npm WARN deprecated If you're running the version of npm bundled with
	npm WARN deprecated Node.js 0.10 LTS, be aware that the next version of 0.10 LTS
	npm WARN deprecated will be bundled with a version of npm@2, which has some small
	npm WARN deprecated backwards-incompatible changes made to `npm run-script` and
	npm WARN deprecated semver behavior.
	npm WARN package.json<EMAIL_ADDRESS>No description
	npm WARN package.json<EMAIL_ADDRESS>No repository field.
	npm WARN package.json<EMAIL_ADDRESS>No README data

	><EMAIL_ADDRESS>install /bundle/bundle/programs/server/node_modules/fibers
	> node build.js || nodejs build.js

	=> Redeploying previous version of the app

	-----------------------------------STDOUT-----------------------------------

	To see more logs type 'mup logs --tail=50'

	----------------------------------------------------------------------------

Found this from here
I use mupx for deploys on DigitalOcean's Ubuntu 14.04_64 without problems.
This shouldn't be a problem: npm -g install npm@latest unless node installed wrong.
Maybe your app is really broken?  Have you tried deploying the todo app?  What happens?

Hi,
this "npm WARN deprecated" error is reported pretty often. I am facing that issue now too.
Mostly the recommendation is to increase the "deployCheckWaitTime".
I did the same, but it was not working. After analyzing the issue further I found a simple reason on our side: the server does not have a connection to the internet.
Probably increasing the deployCheckWaitTime is helpfull for slow internet connections. But if your server does not have a internet connection the error is thrown for sure. I simple double checked that by plugin in and out the wire of our server.
Does somebody have a solution to deploy with mupx for ubuntu servers which are completely offline?
Thanks


Potential Refactoring

Hi,
I am currently doing some research on Estimating Time Taken for Software Refactoring. Redisson is one of my case studies being a highly popular project.
I have identified some packages with refactoring potential and their estimated time to refactor. Would appreciate your kind feedback on the appropriateness of the estimated time to refactor.

org.redisson.api - 354 hours
org.redisson - 274 hours
org.redisson.transaction - 94 hours
org.redisson.client.protocol.decoder - 92 hours
org.redisson.rx - 91 hours

I am specifically looking at potential for refactoring, such as breaking functions that are too long into shorter functions, or to remove code duplication.
Would you agree that there could be some modification to the code to make it better in the listed packages? And if so, is the estimated time appropriate to carry out the improvement? I will be grateful for any help you can provide.
Thank you.
Regards,
Alvin

I usually refactor code time to time. I would be grateful if you find code which needs to be refactored.

Hi @mrniko,
Thanks for your reply! I would greatly appreciate if you would allow me to capitalize on your previous refactoring experiences.
Developer's Experience
Can I trouble you to get a sample list of refactoring operations that you have previously carried out?

Commit hash which the refactoring was carried out.
Estimated time needed for the refactoring operation.

Suggestions for code to be refactored
I am probably not qualified and experienced enough to point out the exact code needs to be refactored, given my limited knowledge of the project and codebase. Using org.redisson.api as an example, my model detects high coupling between org.redison.api and other packages.
Some suggestions based off the results from my model for org.redisson.api :

org.redisson.api to be further broken down into smaller packages

e.g. 1 smaller package RList, 1 smaller package RMap

To shift the api code back within the package, having each individual package manage its own api

Moving RListRxJava back within io.reactivex.rxjava3.core to remove some dependencies

Once again, these are just suggestions based off the results from my model, which may not be contextually accurate. Would appreciate if you could provide some feedback.
Thank you very much in advance for your help!
Regards,
Alvin


Receive apiKey through a secure header

Hi, I'd like to point that passing the apiKey through the url might not be too safe, maybe its a good idea to receive it optionally by a safe header instead. What do you think?

If using HTTPS if it completely safe to pass query string arguments, but it is a good point in general, we will look into it. Thank you!

@mtsbarbosa Done, added 'x-api-key' header support - it is used if no apiKey query string provided.


feat(cli): new pixi global list display format

Implement https://github.com/prefix-dev/pixi/issues/708#issuecomment-1914375643 Close #708
example output
❯ .\target\debug\pixi.exe global list
C:\pixi:
├──<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ ├──[bin] unpigz.bat
│ └──[bin] pigz.bat
├─┬<EMAIL_ADDRESS>│ ├──[bin] idle.bat
│ ├──[bin] 2to3.bat
│ ├──[bin] python.bat
│ ├──[bin] pydoc.bat
│ └──[bin] pythonw.bat
└─┬<EMAIL_ADDRESS>  └──[bin] rattler-build.bat

It already looks good but the tree view makes it a look like this is the structure of the folder. Which is not really true.
Maybe something like this would be better:
➜ pixi global list
Gobal install location: /home/rarts/.pixi:
├── starship 1.17.1
│   └─ bin: starship
├── pre-commit 3.6.0
│   └─ bin: pre-commit
├── grayskull 2.5.3
│   └─ bin: grayskull, greyskull, conda-greyskull, conda-grayskull
├── zsh 5.8
│   └─ bin: zsh, zsh-5.8 # lists to avoid extremely long output
├── gh 2.40.1
│   └─ bin: gh
└── ruff 0.1.15
    └─ bin: ruff

Color the name and version in different colors to make them easy to parse visually
Make the bin a color
List the binaries in a line instead of below each other to avoid super long output
Possibly color the background of a command to give the feeling of inline code blocks to give the idea of a command.

Please give it your own twirl, it shouln't become a disco but I think it could be easier on the eyes.
A future idea could be to color the version based on how outdated it is. (green = latest, yellow = minor version difference, red = major version difference)

He @chawyehsu, would you want to continue the work on this PR?

@ruben-arts Yes but I may be slow on this at the moment. Will make some time on trying to get it accpeted before next weekend.
The aforementioned format looks good to me, I will update the PR to use it. However, there may be predictable line wrap breaking the format when listing binaries in a line if there are many bins or names of bins are longer than terminal width. I don't know if it should be compromised.
Suggested colors output sounds good, too. Coloring version based on how outdated it is may require another network querying? Will try but may not in this branch if the complexity is high.

Thanks @chawyehsu
Good though on the line wrap, I think it should be okay for now.
I think its better to leave the outdated feature out for now to get this pr in sooner.

I just pushed the updated format, this is how it currently looks:

Make the bin a color
Possibly color the background of a command to give the feeling of inline code blocks to give the idea of a command.

After a few tries, I found instead of coloring bin and giving a background to name of executable, highlighting the name with color and a * suffix, inspired from the "ls" command, makes it much feeling to me.


Update for CUDA 12.4.1

xref: https://github.com/conda-forge/cuda-feedstock/issues/23

@conda-forge-admin, please rerender

Travis was hung, restart went through.


add imports of re and mcolors

@Jchaffer787 quick add of import of libraries for uns_functions.py. Sample processed matrix file: LATDF622OJJ

I'm getting the following error when I run LATDF622OJJ:
  File "/Users/jchaffer/Desktop/Curation/lattice-tools/scripts/flattener.py", line 1153, in <module>     main(args.file)   File "/Users/jchaffer/Desktop/Curation/lattice-tools/scripts/flattener.py", line 1062, in main     glob.mfinal_adata.var_names_make_unique()   File "/Users/jchaffer/opt/anaconda3/envs/cxg/lib/python3.9/site-packages/anndata/_core/anndata.py", line 1806, in var_names_make_unique     self.var_names = utils.make_index_unique(self.var.index, join)   File "/Users/jchaffer/opt/anaconda3/envs/cxg/lib/python3.9/site-packages/anndata/utils.py", line 253, in make_index_unique     values_dup[i] = tentative_new_name   File "/Users/jchaffer/opt/anaconda3/envs/cxg/lib/python3.9/site-packages/pandas/core/arrays/_mixins.py", line 261, in __setitem__     value = self._validate_setitem_value(value)   File "/Users/jchaffer/opt/anaconda3/envs/cxg/lib/python3.9/site-packages/pandas/core/arrays/categorical.py", line 1589, in _validate_setitem_value     return self._validate_scalar(value)   File "/Users/jchaffer/opt/anaconda3/envs/cxg/lib/python3.9/site-packages/pandas/core/arrays/categorical.py", line 1614, in _validate_scalar     raise TypeError( TypeError: Cannot setitem on a Categorical with a new category (NPIPA9-1), set the categories first

@Jchaffer787 Hm.. that's an odd line to be erroring on. Did you try running from python 3.11 environment?

My bad. Have set up a 3.11 environment, now getting this error:
  File "/Users/jchaffer/Desktop/Curation/lattice-tools/scripts/flattener.py", line 1153, in <module>
    main(args.file)
  File "/Users/jchaffer/Desktop/Curation/lattice-tools/scripts/flattener.py", line 1123, in main
    warnings = fm.copy_over_uns(glob, reserved_uns)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jchaffer/Desktop/Curation/lattice-tools/scripts/flattener_mods/uns_functions.py", line 121, in copy_over_uns
    if check_not_empty(v):
       ^^^^^^^^^^^^^^^^^^
  File "/Users/jchaffer/Desktop/Curation/lattice-tools/scripts/flattener_mods/uns_functions.py", line 86, in check_not_empty
    and not (isinstance(value, (np.bool_, np.bool)))
                                          ^^^^^^^
  File "/Users/jchaffer/opt/anaconda3/envs/cxg_new/lib/python3.11/site-packages/numpy/__init__.py", line 324, in __getattr__
    raise AttributeError(__former_attrs__[attr])
AttributeError: module 'numpy' has no attribute 'bool'.
`np.bool` was a deprecated alias for the builtin `bool`. To avoid this error in existing code, use `bool` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.bool_` here.
The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at:
    https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations. Did you mean: 'bool_'?

@jychien Works now! Took a look at the imports and it looks good to me!


docker: compile TE

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?

What does this PR do?
Fixes #196
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
cc @borda

any hint on how to set the CUDNN path? https://dev.azure.com/Lightning-AI/lightning/_build/results?buildId=199551&view=log[…]c2d0-7f7286b3996d&t=3cfa2d55-62a7-5f49-36ea-726d310411c0&l=204

pending on #243

Should git+https://github.com/NVIDIA/TransformerEngine.git@stable be added to the devel.txt requirements?
https://github.com/NVIDIA/TransformerEngine?tab=readme-ov-file#pip

Should git+https://github.com/NVIDIA/TransformerEngine.git@stable be added to the devel.txt requirements? NVIDIA/TransformerEngine#pip

well, in another form, it could be but not be re-installed once it exists
anyway, I still have some difficulty in compiling/installing it

I think we should pursue PR this once we have GPU with compute capability 8.9 or above.
See comment: https://github.com/Lightning-AI/lightning-thunder/issues/196#issuecomment-2077507187

Closing for now, labeled as "later"


Can't pull chart, 403 permission denied

Preflight Checklist

[X] I have searched the issue tracker for an issue that matches the one I want to file, without success.
[X] I am not looking for support or already pursued the available support channels without success.
[X] I agree to follow the Code of Conduct.

Vault Secrets Webhook Version
1.21.1
Installation Type
None
Bank-Vaults Version
No response
Kubernetes Version
1.29
Kubernetes Distribution/Provisioner
EKS
Expected Behavior
Pulling this chart as a dependency succeeds.
Actual Behavior
Fails with 403.
Steps To Reproduce
❯ helm upgrade --install --wait vault-secrets-webhook oci://ghcr.io/bank-vaults/helm-charts/vault-secrets-webhook --namespace vault-infra

Release "vault-secrets-webhook" does not exist. Installing it now.
Error: GET "https://ghcr.io/v2/bank-vaults/helm-charts/vault-secrets-webhook/tags/list": GET "https://ghcr.io/token?scope=repository%3Abank-vaults%2Fhelm-charts%2Fvault-secrets-webhook%3Apull&service=ghcr.io": unexpected status code 403: denied: denied

❯ helm pull oci://ghcr.io/bank-vaults/helm-charts/vault-secrets-webhook/vault-secrets-webhook --version 1.21.1
Error: failed to authorize: failed to fetch oauth token: unexpected status from GET request to https://ghcr.io/token?scope=repository%3Abank-vaults%2Fhelm-charts%2Fvault-secrets-webhook%2Fvault-secrets-webhook%3Apull&service=ghcr.io: 403 Forbidden

❯ tail Chart.yaml

# Version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: "1.0"

dependencies:
  - name: vault-secrets-webhook
    version: 1.21.1
    repository: oci://ghcr.io/bank-vaults/helm-charts/vault-secrets-webhook

❯ helm dependency update
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "eks" chart repository
...Successfully got an update from the "localstack-repo" chart repository
...Successfully got an update from the "strimzi" chart repository
...Successfully got an update from the "hashicorp" chart repository
...Successfully got an update from the "jetstack" chart repository
...Successfully got an update from the "crossplane-stable" chart repository
...Successfully got an update from the "project-calico" chart repository
...Successfully got an update from the "bitnami" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 1 charts
Downloading vault-secrets-webhook from repo oci://ghcr.io/bank-vaults/helm-charts/vault-secrets-webhook
Save error occurred:  could not download oci://ghcr.io/bank-vaults/helm-charts/vault-secrets-webhook/vault-secrets-webhook: failed to authorize: failed to fetch oauth token: unexpected status from GET request to https://ghcr.io/token?scope=repository%3Abank-vaults%2Fhelm-charts%2Fvault-secrets-webhook%2Fvault-secrets-webhook%3Apull&service=ghcr.io: 403 Forbidden
Error: could not download oci://ghcr.io/bank-vaults/helm-charts/vault-secrets-webhook/vault-secrets-webhook: failed to authorize: failed to fetch oauth token: unexpected status from GET request to https://ghcr.io/token?scope=repository%3Abank-vaults%2Fhelm-charts%2Fvault-secrets-webhook%2Fvault-secrets-webhook%3Apull&service=ghcr.io: 403 Forbidden

Configuration
No response
Logs
No response
Additional Information
No response

We would like to have the latest version of the chart as a dependency to take advantage of new features and remove bugs.
Thanks!

Hi @caiofralmeida, which Helm version do you use? There is a known issue with version 3.13.0. Let me know if you managed to fix the issue!


Remain third character(z) of listchars'tab(tab:xy[z]) on breakindenting first line

to reproduce
>gvim -N -u NONE
:set breakindent list listchars=tab:<-> showbreak=+++
:call setline(1, "\t" . repeat('a', 300))

before

after

I'll add this test. Please wait marging this PR.

Codecov Report

Merging #5165 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5165      +/-   ##
==========================================
- Coverage   81.98%   81.97%   -0.02%
==========================================
  Files         134      134
  Lines      147168   147169       +1
==========================================
- Hits       120662   120648      -14
- Misses      26506    26521      +15

Impacted Files
Coverage Δ

src/drawline.c
85.14% <100%> (-0.13%)
:arrow_down:

src/ui.c
69.06% <0%> (-1.26%)
:arrow_down:

src/os_unix.c
63.45% <0%> (-0.18%)
:arrow_down:

src/terminal.c
81.7% <0%> (-0.08%)
:arrow_down:

src/window.c
88.27% <0%> (+0.03%)
:arrow_up:

src/gui_gtk_x11.c
58.16% <0%> (+0.04%)
:arrow_up:

src/channel.c
84.25% <0%> (+0.07%)
:arrow_up:

src/if_xcmdsrv.c
86.17% <0%> (+0.17%)
:arrow_up:

src/gui_beval.c
63.36% <0%> (+0.86%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82cf7f6...a598158. Read the comment docs.

It is ready. Please check it.

I assume the "if 0" before  Test_breakindent01() can be removed?

I forgot to remove it which is debug codes.
Please do not worry.


fix(github): regex

Closes #422
https://regexr.com/7pqa8

I'd prefer being explicit over composition with \/foo|\/bar vs \/(foo|bar), the 2nd gets super messy

I'd prefer being explicit over composition with \/foo|\/bar vs \/(foo|bar), the 2nd gets super messy

This makes sense to me.


Use ng-plural for cart item count text

use ng-plural for cart item count text; remove unnecessary cart-item selector
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features) --actually unnecessary tests have been removed
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
Cart item count text is managed by a selector
Issue Number: https://github.com/graycoreio/daffodil/issues/128
What is the new behavior?
Cart item count text is managed by ngPlural
Does this PR introduce a breaking change?
[ ] Yes
[x] No

I'll hold off until the factory PR gets merge, because testing this will cause a conflict


Fix reset

Seems like witht he older ghw, we were not receiving all the proper partitions and mountpoints and such, so on reset we could blindily try to unmount all partitions and call it a day.
But now we get info about all of them, so doing so will even unmount the current recovery partition, where the reset source is at, thus failing the reset copy.
This patch fixes it by instead of going crazy, making sure we have an order mount/unmount of the proper places at the proper times and we restore everything as is once we are done with it

These errors would have helped us fixing it. Can we print those errors too?
diff --git a/pkg/utils/common.go b/pkg/utils/common.go
index abc11b5..9262fcb 100644
--- a/pkg/utils/common.go
+++ b/pkg/utils/common.go
@@ -106,14 +106,17 @@ func ConcatFiles(fs v1.FS, sources []string, target string) (err error) {
        for _, source := range sources {
                sourceFile, err := fs.Open(source)
                if err != nil {
+                       fmt.Printf("err.Error() = %+v\n", err.Error())
                        break
                }
                _, err = io.Copy(targetFile, sourceFile)
                if err != nil {
+                       fmt.Printf("err.Error() = %+v\n", err.Error())
                        break
                }
                err = sourceFile.Close()
                if err != nil {
+                       fmt.Printf("err.Error() = %+v\n", err.Error())
                        break
                }
        }

These errors would have helped us fixing it. Can we print those errors too?
diff --git a/pkg/utils/common.go b/pkg/utils/common.go
index abc11b5..9262fcb 100644
--- a/pkg/utils/common.go
+++ b/pkg/utils/common.go
@@ -106,14 +106,17 @@ func ConcatFiles(fs v1.FS, sources []string, target string) (err error) {
        for _, source := range sources {
                sourceFile, err := fs.Open(source)
                if err != nil {
+                       fmt.Printf("err.Error() = %+v\n", err.Error())
                        break
                }
                _, err = io.Copy(targetFile, sourceFile)
                if err != nil {
+                       fmt.Printf("err.Error() = %+v\n", err.Error())
                        break
                }
                err = sourceFile.Close()
                if err != nil {
+                       fmt.Printf("err.Error() = %+v\n", err.Error())
                        break
                }
        }

using some logger preferably

actually, just return the error (wrapped or not).

These errors would have helped us fixing it. Can we print those errors too?
diff --git a/pkg/utils/common.go b/pkg/utils/common.go
index abc11b5..9262fcb 100644
--- a/pkg/utils/common.go
+++ b/pkg/utils/common.go
@@ -106,14 +106,17 @@ func ConcatFiles(fs v1.FS, sources []string, target string) (err error) {
        for _, source := range sources {
                sourceFile, err := fs.Open(source)
                if err != nil {
+                       fmt.Printf("err.Error() = %+v\n", err.Error())
                        break
                }
                _, err = io.Copy(targetFile, sourceFile)
                if err != nil {
+                       fmt.Printf("err.Error() = %+v\n", err.Error())
                        break
                }
                err = sourceFile.Close()
                if err != nil {
+                       fmt.Printf("err.Error() = %+v\n", err.Error())
                        break
                }
        }

using some logger preferably

actually, just return the error (wrapped or not).

tbh, I would like to do this in a different PR if possible> As it can introduce new errors and I want this to fix the actual reset issue before breaking it further lol


Move charts/Makefile targets to root Makefile and third_party

This PR moves targets from charts/Makefile as follows:

cert-manager moves to third_party/ directory
vault and related targets move to third_party/ directory
m4d moves to root Makefile
run-integration-tests is removed

this pr also removes unused files from third_part/vault directory.
Closes #515

@roee88  Thanks for the comments. I addressed them in the second commit.


installing try-reflex on Windows 7/Cygwin 64

When trying to install try-reflex on cygwin, under Windows 7, I got error message:  sorry, there is no binary distribution of Nix for your platform
It looks like a problem occurred..
Is there an installation for windows or Cygwin?  I am somewhat of a newbie in Haskell environment, so please excuse if this is an obvious/dumb question.

You can still install reflex - just not using this repository, unfortunately!  Since the Nix package manager doesn't support Windows, you'll have to install ghcjs, reflex, and reflex-dom from Hackage directly.  Once you get them installed, you should be able to proceed just as you would with try-reflex.
I hope the Nix folks will be able to support Windows at some point in the future, and when they do, I'll make sure try-reflex works with it, too!

Thanks, Ryan, I'll give it a try!  Thanks very much for the quick response!
Date: Mon, 22 Jun 2015 15:52:27 -0700
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [try-reflex] installing try-reflex on Windows 7/Cygwin 64 (#19)
You can still install reflex - just not using this repository, unfortunately!  Since the Nix package manager doesn't support Windows, you'll have to install ghcjs, reflex, and reflex-dom from Hackage directly.  Once you get them installed, you should be able to proceed just as you would with try-reflex.
I hope the Nix folks will be able to support Windows at some point in the future, and when they do, I'll make sure try-reflex works with it, too!
—
Reply to this email directly or view it on GitHub.

@briannolan45 did you manage to get it running on windows?

Hi guys,
You might be able to use stack to get things going.  See #35.

Still wont help for Windows due to: https://github.com/ghcjs/ghcjs-dom/issues/19 , as ghcjs-dom is a dependency of reflex-dom.
Linux + Virtual Box is the only way I can compile on a Windows OS at the moment.

Closing this since it isn't an issue with reflex-platform.


Pratham Rastogi

This is Pratham Rastogi. And I will be adding my data to do my first contribution as well as get a card on the website.

Where is your PR?

Sorry i just contributed to contributor.js and not to contributor.md . I am fixing that and opening a Pull Request

Okay sure make sure to take the latest pull from main @Pratham-R

Sure.


(docs): Missing parameter in API reference

http://angular-meteor.com/api/meteorCollection
The API usage is showing 2 params but there are 3 in the arguments list.
Not sure how to resolve.

The third parameter is for CollectionFS, maybe we should add an explanation and example

OK. You may want also to note that the collectionFS usage example is also showing just 2 params.
$meteorCollection(Images, false);
If not sending a function as first param - then the 3rd one is not required?


Update api version of istio's manifests to v1beta1

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

/lgtm

/approve


Update uses of FakeBackends to be compatible with 0.45 and 1.0

Summary
I just naively modified all the fake backends I found in the code, but I see that #804 removes some of these files, I can prune the changes in this PR to match #804 if necessary.
Related to #804.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 51.534%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3476

Relevant Lines:
6745

💛  - Coveralls

LGTM, I can handle the merge conflicts in #804


Unable to obtain Windows 10 Enterprise 18362.418

Hello,
I'm working on setting up some Surface devices for our teams room consoles and we're having difficulties finding the versions of Windows the CreateSrsMedia.ps1 script is requiring. I was able to get a Surface Pro 4 image created but we are now working with a Surface Pro (2017) and the version it requires is 10.0.18362.418. I have downloaded the predecessor and successor builds in hopes that one of them worked and neither one satisfied the requirements for the teams room image. Logs are below, please advise.
Edit: CreateSrsMedia.ps1 is from the teams room console setup website provided by Microsoft (Link Below).
https://docs.microsoft.com/en-us/microsoftteams/rooms/console
Thanks
Script version 1.6.0
Downloading CreateSrsMedia...
done
Validating signature for update.ps1...
success.
D17C72A691D49A186B9F3F63645F5350F12AD90128FB037DCB693DAE010756B13C27599207AFDD9EAE34DEBE886AB36D77A0D6B6061763CDABE70D82816E6121
73191
What type of customer are you?
Please make sure you have all of the following available:

A USB drive with sufficient space (16GB+).
The contents of this drive WILL BE LOST!
Windows 10 Enterprise media that matches your SRSv2 deployment kit.
Enterprise customers can access Windows 10 Enterprise media from the Volume Licensing Service Center:
http://www.microsoft.com/licensing/servicecenter
Any language pack (LP and/or LIP) files to be included.
MPSA customers:         http://go.microsoft.com/fwlink/?LinkId=125893
Other volume licensees: http://www.microsoft.com/licensing/servicecenter

Please do not continue until you have all these items in order.
Found deployment kit already downloaded.
Validating signature for SRSDeploymentKit-<IP_ADDRESS>.msi...
success.
Extracting the deployment kit...
done.
This deployment kit is built for Windows build 10.0.18362.418.
This deployment kit draws its drivers from %configsetroot%\AutoUnattend_Files\DistShare\Out-of-Box Drivers.
Please indicate what drivers you wish to use with this installation.
[ 0] Logitech SmartDock
[ 1] Crestron SR
[ 2] Polycom MSR
[ 3] Lenovo Hub 500
[ 4] LRS
[ 5] HP Slice 2.0
[ 6] Crestron Flex
[ 7] None
Selected option 0.
[ 0] Surface Pro 4
[ 1] Surface Pro (2017)
[ 2] Surface Pro 6
Selected option 1.
Downloading driver...
done
Validating signature for SurfacePro_Win10_16299_1806007_3.msi...
success.
Extracting SurfacePro_Win10_16299_1806007_3.msi...
done.
Identifying language packs...
... done identifying language packs.
Reminder: all data on the drive you select will be lost!
[ 0] Samsung Flash Drive
Selected option 0.
Your Windows installation media is version 10.0.18362.356. Your SRSv2 kit requires version 10.0.18362.418.
Your Windows installation media is version 10.0.18362.778. Your SRSv2 kit requires version 10.0.18362.418.

@Pikkon06 Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.

hi
did you find any solution ? I have the same prob. Unable to obtain the required version of the media.
modifying the script result on an error on installing: "window could not... [offline servicing]"

I ended up never finding a solution for this. I tried installing the surface pro 4 version on a pro 5 and it worked fine. There was some minor firmware differences but the surface would self-install the firmware that was needed.
From: rizzon<EMAIL_ADDRESS>Sent: Monday, October 12, 2020 7:32 AM
To: MicrosoftDocs/OfficeDocs-SkypeForBusiness<EMAIL_ADDRESS>Cc: Bowen, Terryl<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/OfficeDocs-SkypeForBusiness] Unable to obtain Windows 10 Enterprise 18362.418 (#5487)
hi
did you find any solution ? I have the same prob. Unable to obtain the required version of the media.
modifying the script result on an error on installing: "window could not... [offline servicing]"
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-SkypeForBusiness%2Fissues%2F5487%23issuecomment-707091747&data=02|01|terryl.bowen%40producealliance.com|ca9976c59248410ac78908d86eaaddac|ce1d7c447faa4fd2bae03d35e7de0d68|1|0|637381027439623424&sdata=3Gcqu9NkOiwFi%2Fnu97EOdr4rPdyzarrk3hwUabad4Mo%3D&reserved=0, or unsubscribehttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQPWPSTPQ7LI3O7B5HUW3ZTSKLZNJANCNFSM4PTVRSZQ&data=02|01|terryl.bowen%40producealliance.com|ca9976c59248410ac78908d86eaaddac|ce1d7c447faa4fd2bae03d35e7de0d68|1|0|637381027439633419&sdata=OSksjxP0xZGqB30xmGf6kIjZ3kIJmYf6qu0GT%2B%2BkyXM%3D&reserved=0.
[PA Logo] http://www.producealliance.com
Terryl Bowen
IT Support Technician
Office:<PHONE_NUMBER>
Cell:<PHONE_NUMBER>
[http://www.pamarketingsolutions.com/wp-content/uploads/2016/03/l.png]https://www.linkedin.com/company/produce-alliance-llc.  [http://www.pamarketingsolutions.com/wp-content/uploads/2016/03/i.png] http://www.instagram.com/producealliance       [http://www.pamarketingsolutions.com/wp-content/uploads/2016/03/t.png] http://www.twitter.com/producealliance         [http://www.pamarketingsolutions.com/wp-content/uploads/2016/03/f.png] http://www.facebook.com/producealliance
The information contained in this communication is privileged, confidential and exempt from disclosure under applicable law. If the reader of this communication is not the intended recipient, you are hereby notified that any dissemination or distribution of this communication to other than the intended recipient is strictly prohibited. If you have received this communication in error, please notify us immediately, including a copy of the original communication, and delete all incidences of this communication from your system.


[Environment] A way to add test env. values via code.

Issue
Currently (v1.4.19) one can set test environment values via the environment.xml or environment.properties only. So, those files should be predefined or generated on the fly and placed in proper locations. That could be inconvenient in case of different test environments, specific CI approaches etc.
Suggestion
Introduce an ability to set env. values via test code (e.g. inside some initialization piece). That way one can easily set/add info which is specific to a particular test run.
As for the implementation  - it could be done by implementing some env. values provider interface. Or by injecting the values via some AllureConfigurer.

It would be great add env. variables via system properties (or this already implemented?)

@L-Evg @dimand58 hi, sorry for the delay!
How to handle the situation when you run your tests at different runtime? For an example using different JVM for Java-tests? In this case you will get the few results folders, each folder contains different environment.xml. How to merge the environments?
The main idea that your runtime (Jenkins, Teamcity, Maven, your own super cool build system) knows all about test run. Knows what you gonna test, which browser you are using etc. So runtime can provide the environment for the tests.
So noone says that you can not simply write a dummy test (or script) that will provide an environment during tests execution.

@baev thanks for answer. In my case this problem was resolved via button "Include build environment" in  Allure Jenkins Plugin

I guess I can close this one. Feel free to reopen


Cannot install due to compiler error

All I know:
Building native extensions.  This could take a while...
sh: warning: setlocale: LC_ALL: cannot change locale (en)
sh: warning: setlocale: LC_ALL: cannot change locale (en)
sh: warning: setlocale: LC_ALL: cannot change locale (en)
ERROR:  Error installing taskwarrior-web:
        ERROR: Failed to build gem native extension.

    /usr/bin/ruby -r ./siteconf20150125-5532-pv2yw5.rb extconf.rb
creating Makefile

make "DESTDIR=" clean
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (en)

make "DESTDIR="
compiling generator.c
In file included from /usr/include/stdio.h:27:0,
                 from /usr/include/ruby-2.2.0/ruby/defines.h:26,
                 from /usr/include/ruby-2.2.0/ruby/ruby.h:29,
                 from /usr/include/ruby-2.2.0/ruby.h:33,
                 from ../fbuffer/fbuffer.h:5,
                 from generator.c:1:
/usr/include/features.h:328:4: warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp]
 #  warning _FORTIFY_SOURCE requires compiling with optimization (-O)
    ^
In file included from generator.c:1:0:
../fbuffer/fbuffer.h: In function 'fbuffer_to_s':
../fbuffer/fbuffer.h:175:47: error: macro "rb_str_new" requires 2 arguments, but only 1 given
     VALUE result = rb_str_new(FBUFFER_PAIR(fb));
                                               ^
../fbuffer/fbuffer.h:175:20: warning: initialization makes integer from pointer without a cast
     VALUE result = rb_str_new(FBUFFER_PAIR(fb));
                    ^
Makefile:237: recipe for target 'generator.o' failed
make: *** [generator.o] Error 1

make failed, exit code 2

Gem files will remain installed in /home/m/.gem/ruby/2.2.0/gems/json-1.7.7 for inspection.
Results logged to /home/m/.gem/ruby/2.2.0/extensions/x86_64-linux/2.2.0/json-1.7.7/gem_make.out

$  ruby --version
ruby 2.2.0p0 (2014-12-25 revision 49005) [x86_64-linux]

Ask me for more information if you need them.

Same issue with ruby 2.2. I tried rolling back to ruby 1.9.3-dev and was able to install it, but then ran into #69 (probably due to incompatibility with newer versions of taskwarrior). Bummer - I wonder how difficult these would be to tackle? Looks like the main contributers here haven't worked on it in a while.

Same problem with ruby 2.2 here.
This is due to some double macro expansion weirdness.
It can be solved by manually fixing the culprit in ~/.gem/ruby/2.2.0/gems/json-1.7.7/ext/json/ext/fbuffer/fbuffer.h:175:
-    VALUE result = rb_str_new(FBUFFER_PAIR(fb));
+    VALUE result = rb_str_new(FBUFFER_PTR(fb), FBUFFER_LEN(fb));

Then:
cd ~/.gem/ruby/2.2.0
make -C gems/json-1.7.7/ext/json/ext/generator
gem spec cache/json-1.7.7.gem --ruby > specifications/json-1.7.7.gemspec

Hope that helps.

This seems like an issue in the json library. Closing for now.

@laomaiweng Thank you thank you thank you! This is my first time using ruby and I don't understand anything about it, but with your answer I located the problem and fixed it with vim :) Btw, I had to manually navigate because some things weren't the same but it worked! Thanks again!!


Support for Positions History & Audit

Any plans to support these endpoints?
https://docs.bitfinex.com/v2/reference#positions-history
https://docs.bitfinex.com/v2/reference#positions-audit

closed with #41


Unable to delete/clean plugins with use of lazy

Was trying to remove plugins that not planing to use, though have stumbled on such issue
nvim version 0.9.4
Windows wsl2 Ubuntu latest(22.04)

What did you do to remove them? Did you go into the filesystem and delete them?

You probably already deleted them on the filesystem while Neovim was open?
I just fixed that error message, but it would only show if the plugin's directory no longer exists.


@kanaabe => More articles bug

Closes https://github.com/artsy/force/issues/480

Adds fetchWith params to Fair article pages, fixing a bug where loading more was loosing the fair id
ArticlesFeedView looks for 'featured', and increments the offset to account for articles rendered outside the component.

ha nice! easy peasy as craig would say


Neomake only covers part of a long file

Hi. I'm new to neovim (0.1.3) && neomake (installed via Vundle) and I'm trying to migrate from vim && syntastic. It works really fine (kudos to you) apart from one problem.
When I'm dealing with long files with lots of errors or warnings, only part of a file is covered.
The signs (those gitgutter-like) are displayed fine to some line, and starting from that line there's nothing more. I encountered it for JS (eslint) and PHP (phpcs). Actually, it happens every time with big, full-of-mistakes files. Never happened to me with Python, but I don't deal with projects with so many errors and so long files there.
It's not just about displaying signs. When I run :Neomake and then :lopen the last error line displayed there is the exact line where the last sign is displayed.
There doesn't seem to be any fixed line / percentage starting from which neomake stops working. Sometimes it's working OK for 300 / 700 lines, sometimes 2300 / 3000. For comparison, syntastic in vim or neovim shows errors correctly for all the content (of course, there are lags).
Am I missing something? Is it a bug? Some configuration issue on my side?

I'm not sure if it's not an issue of neovim itself, or rather the way the job output is processed. It vim with neomake this issue does not exist.

Do you only see the error markers in the gutter for what is currently in the window, then when you scroll up or down you don't see any more error markers even though there should be?
If so, have you tried to save the file after you scroll? If the error markers show up after scrolling when you save, check out this PR.

It's not really about the markers. This is most likely neovim's issue, which should potentially be fixed by this PR: https://github.com/neovim/neovim/pull/4646

This should be fixed in neovim HEAD now. Thanks for providing clear repro steps @radoslawroszkowiak.

Thanks, closing the issue in neomake then.
Please re-open if this still happens with the latest neovim.


make is_local return False by default, with real implementation on filesystem resources

since is_local is defined by whether or not it is found in the "local packages path", it seems a concept that really only makes sense for filesystem resources.  As source, made the default implementation of is_local always return False, and override this on the filesystem resources.
This is a potential fix to this issue: https://github.com/nerdvegas/rez/issues/162
...and it touches on some of the issues in this thread: https://groups.google.com/forum/#!topic/rez-config/5q1k0iJFGEs
However, it's still not an ideal solution, as it still makes the assumption that pkg.root is a directory (and runs os.path.exists on it).
Perhaps a better / more generic approach would be allow resources to provide aritrary "tags" with additional information about that particular resource, and then rez-context could display these tags.  In this particular case, filesystem resources could attach a "local" tag to packages it finds within the local packages path.
The "NOT FOUND" information could also be implemented as a tag... or, alternatively, we could provide resources with the ability to perform validation, in some way appropriate for that resource type, and return brief descriptions if problems are found.

Hey elrond79,
Just to clear things up - local packages aren't restricted to filesystem package repositories - although I don't see this being common (but who knows) theoretically the local package repository could be any repository type.
The fact that env-vars such as REZ_PACKAGES_PATH and LOCAL_PACKAGES_PATH refer to 'paths' at all is historical. REZ_PACKAGES_PATH is now able to contain package repository uri-type strings as well as file paths - for example, a theoretical database backend might have a location string "mongodb:host=svr,namespace=central", and this value could be listed in REZ_PACKAGES_PATH. I think LOCAL_PACKAGES_PATH hasn't been updated to behave the same way yet. Off the top of my head, is_local() implementation should be changed so that it simply checks that the location identifier string of its associated package repository matches the value of LOCAL_PACKAGES_PATH.
I'll take your PR though, and make the associated fixes at the same time.
Thx
A

Hmm... yeah, makes sense. I like the idea of using the repository to check whether the package is local.
You can go ahead and just reject this PR if you want - I actually just noticed a mistake anyway (packages_.py, PackageBaseResourceWrapper now has two definitions for "is_local").  Or, if you want, I can break out the changes to resolved_context.py into a separate pull request...

Hey elrond79,
I'm going to close this PR, but I'll incorporate your ResolvedContext changes separately, thx.

Cool, the changes made in your local_repo_fix branch do the trick! Deleted the branch from our repo in favor of your changes...
Was thinking about making a test for this - but not sure where that would go in the existing test structure.  What do you think of a new test_cli.py module?


Add syntax __rule that inlines during grammar preprocessing

Suggestion
Right now inlined rules (_rule) are inlined after parsing.
It is sometimes desirable to have them inlined during grammar preprocessing, to reduce that amount of REDUCE actions (which are computationally expensive), and possibly also avoid some shift/reduce errors.
That's especially handy for templates, which often aren't designed to be rules on their own.
Describe alternatives you've considered
Starting a rule or templates with two underscores (__rule) will inline it when preprocessing the grammar.

+1

Rules whose name begins with an underscore will be inlined into their containing rule

My intuition says that it’s going to be done when lark constructs a parser from the grammar. But for “?rule”, I think that sort of inlining should be done after parsing input.

We need to distinguish between two kinds of inlining

At the grammar level, before building the parser

At the parse tree level, while parsing

_rules and the like should be grammar level
?rules should be during/after parsing

@ThatXliner
No, _rules should not be at grammar level, otherwise stuff like below has terrible performance
start: options options

options: a | b | c | d | e | f | g | h

Currently that's a total of 1 + 8 = 9 rules. If _rules does inlining, that's 8 * 8 = 64 rules.

Also, then recursion within _rule would be impossible.

Oh right. My bad.
I was thinking about the _templates{}. I think those should be non-recursive for most use cases.
If that may break some people’s code, why not an inline keyword?

If that may break some people’s code, why not an inline keyword?

That's what the __rule / __template syntax is for.

I just think that might break something… 🤷♂


Tabs component

added tabs component, in the next release i try to put icons

i update the PR, i remove other components i added except tabs, i hope it will be clear in this way

That's great but in components.json the other 3 components are referenced and they don't exist in this PR which makes impossible to run locally this PR. I will have to start with the other PRs first


Problem with MirroredStrategy (Single Machine Multi GPU) on demo/movielens-100k-estimator

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):

CentOS 7

TensorFlow version and how it was installed (source or binary):

$ pip list | grep tensorflow
tensorflow                     2.4.1
tensorflow-addons              0.13.0
tensorflow-datasets            4.4.0
tensorflow-estimator           2.4.0
tensorflow-gpu                 2.4.1
tensorflow-metadata            1.2.0
tensorflow-recommenders-addons 0.2.0

TensorFlow-Recommenders-Addons version and how it was installed (source or binary):

see above

Python version:

Python 3.6.8

Is GPU used? (yes/no):
yes

Describe the bug
Hi,
I was able to run the demo (demo/movielens-100k-estimator) as it is, with no distributed strategy.
However when I have tried to make it compatible with tf.distribute.MirroredStrategy() on GPU, I was not able to run through the program.
Code to reproduce the issue
Only 3 places I have changed within the code:

the loss function (in func def model_fn()):

loss_obj = tf.keras.losses.MeanSquaredError(reduction=tf.keras.losses.Reduction.NONE)
loss = tf.reduce_sum(loss_obj(labels, predictions)) * (1. / GLOBAL_BATCH_SIZE)
# GLOBAL_BATCH_SIZE = 256

adding the distribute strategy in Estimator run_config (in func def train(model_dir, ps_num)):

def train(model_dir, ps_num):
  mirrored_strategy = tf.distribute.MirroredStrategy()
  run_config = tf.estimator.RunConfig(log_step_count_steps=100,
                                      save_summary_steps=100,
                                      save_checkpoints_steps=100,
                                      save_checkpoints_secs=None,
                                      keep_checkpoint_max=2,
                                      train_distribute=mirrored_strategy,
                                      eval_distribute=mirrored_strategy)

I removed the TF_CONFIG settings in main as it is not need in MirroredStrategy

Log shows error in Add_N op with dimension mismatch:
(from personal debugging process I guess the problem is at optimizer apply gradients)
.local/lib/python3.6/site-packages/tensorflow/python/framework/ops.py", line 1856, in _create_c_op
    raise ValueError(str(e))
ValueError: Dimension 0 in both shapes must be equal, but are 64 and 256. Shapes are [64,256] and [256,64].
        From merging shape 0 with other shapes. for '{{node AddN_2}} = AddN[N=2, T=DT_FLOAT](gradients/dense/MatMul_grad/tuple/control_dependency_1, replica_1/gradients/replica_1/dense_4/MatMul_grad/tuple/control_dependency_1)' with input shapes: [64,256], [256,64].

Provide a reproducible test case that is the bare minimum necessary to generate the problem.
Other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

Hi @ivanml,  I believe the Dynamic Embedding can't support MirroredStrategy for different size of IDs in different work, you know, different batch can contain different number of features, isn't it?

Mirrored Strategy is now supported in TF2 Keras. But it has some performance problem, which cause by lacking of all-to-all communication operator.

This issue is solved for the time being, I will close this issue. Turn it back on if necessary.


sometimes relay-selector UI truncated

the relay-selector should be 100% width, sometime it is shorted maybe some css bugs

It seems that RelaySelector is using antd. I would like to refactor this component to improve its UX/UI. What do you think?

It seems that RelaySelector is using antd. I would like to refactor this component to improve its UX/UI. What do you think?

cool, I think it is good idea since the antd is not very ideal to this component's design here

@ahonn  do you want to refactor this item this week? Shall I move this task into our v0.2.8 plan?

@ahonn do you want to refactor this item this week? Shall I move this task into our v0.2.8 plan?

Yes, I plan to refactor this this week.

https://github.com/digi-monkey/flycat-web/pull/408


Update redbean to 2.0.17

Committed in https://github.com/ProducerMatt/redbean-template/commit/8367654e6a023b866eaec4f6db866ae42373ec10