qemu-vm: remove bootDisk, refactor using make-disk-image with better EFI support

Description of changes
This PR does multiple things :
####### make-disk-image refactoring in QEMU test infrastructure
As per https://github.com/NixOS/nixpkgs/issues/23052 — QEMU test infrastructure do not use ad-hoc code to build the boot disk image but reuse make-disk-image which was improved to support use-cases.
Doing this consolidates make-disk-image as one place to do these changes, it seems like the boot disk production code was doing old stuff with GRUB 0.97, I'm uncertain whether that should be cleaned up.
####### UEFI firmware infrastructure
As part of https://github.com/NixOS/nixpkgs/pull/187887 ; this uses consolidated UEFI firmware and variables and expose their variables to end users.
It also adds SecureBoot and System Management Mode enforcement support in the test infrastructure and the make-disk-image function.
EFIVARS can be modified as part of the disk image build process, enabling people to build a disk image with specific authenticated UEFI variables, e.g. SecureBoot keys.
####### Documentation
This PR adds documentation on what are the breaking changes in regard to the disk layout (storeImage is used only if needed at all.)
TODO/notes:

[x] Cleanup UEFI firmware infrastructure: done in
[x] Cleanup the /dev/vdb2 stuff in QEMU code.
[x] Some tests such as installer depends on bootDevice being vdb or second drive.
[x] GRUB version 1 may have some subtleties.
[x] Assert touchEFIVars only if partition table type is hybrid or efi.
[ ] Use a better error message for assert.
[ ] Refactor in make-disk-image the EFI firmware infrastructure using #187887.
[x] Simple tests:

[x] Legacy boot without any EFI stuff should still work.
[x] EFI/Hybrid boot without touching EFI vars should still work.
[x] EFI/Hybrid boot with touching EFI vars should still work AND we should be able to write/read in EFIVARS.
[x] Over {systemd-boot, GRUB1, GRUB2} cartesian product.

[ ] Documentation:

[ ] How to test this kind of changes? What to look for?
[ ] Where are the breaking changes? Everything that relies on /dev/vdb2 is now incorrect.
[ ] Compatibility layer? Deprecation notice?

[ ] Prevent users to shoot their foot: increase the number of assertions & warnings accordingly in the module.

For a future PR

[ ] makeEc2Test is useful to initialize using an image, it would be good to extract it as a lower level primitive to start test off an already existing disk image, maybe put it directly into makeTest machinery or makeTestFromImage

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@edolstra I think you wrote the initial qemu-vm module and the boot disk generation code.
It included a provision to support GRUB v0.97: https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/virtualisation/qemu-vm.nix#L274-L275 — am I right this is not needed anymore and can be dropped in this PR?

cc @roberth @lheckemann as this may affect the installer (which I tested but I think it's a touchy PR).

@GrahamcOfBorg test installer.simple
@GrahamcOfBorg test simple
@GrahamcOfBorg test non-default-filesystems
@GrahamcOfBorg test swap-partition
@GrahamcOfBorg test systemd-boot.basic
@GrahamcOfBorg test systemd-boot.update
@GrahamcOfBorg test systemd-boot.switch-test

@NixOS/ofborg test installer.simple
@NixOS/ofborg test simple
@NixOS/ofborg test non-default-filesystems
@NixOS/ofborg test swap-partition
@NixOS/ofborg test systemd-boot.basic
@NixOS/ofborg test systemd-boot.update
@NixOS/ofborg test systemd-boot.switch-test

We can run the tests on hydra before merging.

@ofborg test installer.simple
@ofborg test simple
@ofborg test non-default-filesystems
@ofborg test swap-partition
@ofborg test systemd-boot.basic
@ofborg test systemd-boot.update
@ofborg test systemd-boot.switch-test

We can run the tests on hydra before merging.

That would be great, should I ping you to ask you for this?

I've picked the best recent commit from trunk-combined to run as a baseline. I've pushed this commit as python-test-refactoring-baseline for reference, as well as python-test-refactoring for evaluation (which is in progress right now). Could you base this branch on that commit as well?
If that leads to conflicts, we can reconsider the choice of baseline commit.

I've picked the best recent commit from trunk-combined to run as a baseline. I've pushed this commit as python-test-refactoring-baseline for reference, as well as python-test-refactoring for evaluation (which is in progress right now). Could you base this branch on that commit as well?
If that leads to conflicts, we can reconsider the choice of baseline commit.

I only need to rebase on python-test-refactoring branch or? I did not understand exactly what was needed for Hydra to pick up this. Should I also change the target of this PR?

https://github.com/ofborg test secureboot.basic

I only need to rebase on python-test-refactoring branch

:+1:

I did not understand exactly what was needed for Hydra to pick up this.

Push to python-test-refactoring, but let's do it after we have a baseline eval.

Should I also change the target of this PR?

This isn't needed. We're going to merge it into master when ok. We only use the branch for ad hoc evals on hydra. We don't have a merge train like staging, because these aren't mass-rebuilds.

Looks like systemd-boot.update fails, apart from whatever is wrong on aarch64

Yeah, it fails on master too, I think these are systemd breaking changes.
Le ven. 9 sept. 2022 à 19:01, Robert Hensing @.***> a
écrit :

Looks like systemd-boot.update fails, apart from whatever is wrong on
aarch64
—
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/187639#issuecomment-1242228437,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACMZRDIQCB2ID4UXTD3TJDV5NUNDANCNFSM57DY35KA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Looks like systemd-boot.update fails, apart from whatever is wrong on aarch64

That one is on me. It's the SMM commit that wrecks havoc in the make-disk-image builds. I was at least missing the overall enabling of smm in qemu (-machine qc35,smm=on,accel=tcg) but looks like there is something else missing. I guess I'll need to get a debug build of ovmf and get the debug console wired in.

I only need to rebase on python-test-refactoring branch

+1

Done, but now, I do have… conflicts :C ?

I did not understand exactly what was needed for Hydra to pick up this.

Push to python-test-refactoring, but let's do it after we have a baseline eval.

Alright!

Should I also change the target of this PR?

This isn't needed. We're going to merge it into master when ok. We only use the branch for ad hoc evals on hydra. We don't have a merge train like staging, because these aren't mass-rebuilds.

Alright.

Ah… It mass pinged everyone. :')


Add a missed word in stakeholder-access.md

The word "to" is missing in "Add tasks to a sprint backlog"

@dregimbal - thanks for this fix.


ctypes IntelliSense/Autocomplete

Describe the feature you are requesting
Python has by far the best support for binary structured data of any scripting language I'm familiar with in ctypes - better even than many compiled languages. PTVS supports IS/AC for classes, named tuples, and probably others I'm not familiar with. However, it does not appear to support ctypes structures et al, instead only showing the members of the metaclass. This issue requests IS/AC support for ctypes structures/unions/etc. in at least Visual Studio 2022+.

Hi @TheRealQuantam, thanks for the suggestion. Could you please provide a code example that illustrates the problem you mentioned about PTVS not supporting ctypes structures and instead only displaying the members of the metaclass. By providing this code snippet, we will be able to have a clearer understanding of the specific feature you'd like to see in PTVS. Thank you!

Oddly enough while getting a screen shot I got two very similar but slightly different behaviors:

from ctypes import *

class NsfHeader(LittleEndianStructure):
	_pack_ = True
	_fields_ = (
		("magic", c_char * 5),
		("version", c_uint8),
		("num_tracks", c_uint8),
		("start_track", c_uint8), # 1-based
		("load_addr", c_uint16),
		("init_addr", c_uint16),
		("play_addr", c_uint16),
		("game_name", c_char * 32),
		("artist_name", c_char * 32),
		("copyright_name", c_char * 32),
		("ntsc_speed", c_uint16),
		("start_banks", c_uint8 * 8),
		("pal_speed", c_uint16),
		("machine_flags", c_uint8),
		("expansion_chips", c_uint8),
		("_reserved", c_uint8),
		("prg_size_lo", c_uint16),
		("prg_size_hi", c_uint8),
	)

hdr = NsfHeader()

hdr.

In either case, it's showing inherited members but not the fields of the structure itself (no, they're not further scrolled down in the list).
This is on:
Microsoft Visual Studio Community 2022
Version 17.6.2
VisualStudio.17.Release/17.6.2+33723.286
Python with Pylance   17.0.23087.1


[BUG]

Reproduction steps
Dear all i facing failure while commissioning the esp 32 with chip-tool through mobile hotspot. i would also need to know when i try using data card the communication will established or i should use a typical router for matter commissioning ?  please comment @dhrishi @bzbarsky-apple
mobile hotspot failure.txt
Bug prevalence
every time
GitHub hash of the SDK that was being used
bfa05804ac3c224c9e70921a857ffcac32ccc7f4
Platform
esp32
Platform Version(s)
No response
Anything else?
No response

@aravindone ConnectNetworkResponse received a status response 5 i.e NetworkNotFound Cannot find AP: SSID Not found.
Are you using 5GHz WiFi network? ESP32 only works with 2.4GHz wifi network. Can you try with any 2.4GHz network?

@shubhamdp  the hot spot bandwidth i provided is 2.4GHz and i even given try giving the ssid and password in hex.
the clarification i need is whether this problem will exist in data card i mean some portable modems or we should move with router ?

Nothing in Matter cares about where your network is coming from, really, as long as the network exists and can handle DNS-SD.
But in this case the esp32 is unable to join the network involved, and you should probably investigate why.

The issue was resolving after matter communication established over Datacard


The columns will be mixed where using "usecols" in pd.read_csv()

import modin.pandas as pd
col = ['name', 'idcard', 'phone', 'loan_dt']
cur_data_old_1 = pd.read_csv(os.path.join(path, 'train'), sep='\t', usecols=col)

Hi @excitingx thanks for posting!
Would you be able provide an "expected output" and a "actual output"? The column order should match the pandas behavior. Thanks!

Closing this. Feel free to reopen if the discussion should continue or if issue was not resolved.


iconCreateFunction prop not working

I'm using iconCreateFunction prop for customizing the cluster icon but is not wrking. This is the code I'm using

The icon is not renderer as expected an nothing is outputed in the console.

Probably that is because opening <span> tag has been missed from html key in new DivIcon({}).

It is not that, the function is not called. There is nothing logged in then console.

Here is CodeSandbox:
https://codesandbox.io/s/react-leaflet-markercluster-issues102-7fsz8
iconCreateFunction works well.
Please, try to move require('leaflet') outside the scope of clusterIconCreateFunction

@Sokal21
NOTE: divIcon from 'leaflet' - first letter is lower case.


Remove Underscore dependency from Area Chart

Underscore is not really necessary and it's weighting on that file and the whole bundle

Expected Behavior

No underscore in the bundle
Current Behavior

Possible Solution

Refactor our underscore

You might want to check Lodash Modularized.
It has practically the same API as Underscore and you could import single functions in the bundle like for example sortBy by installing/importing only want you need like:
var sortBy = require('lodash.sortby');
I can pick this ticket if you're up for it.

Hi @nobitagit , thanks for the suggestion!
Actually, I have a branch where I am trying to get rid of underscore completely, but I am finding some difficulties.
If you could move it into Lodash, that would be awesome! Later I could take care of removing the dependency.

Sure, let me get a PR going for this 👍 I will post here in case I need some help or I have doubts


Added Gin and Martini frameworks.

Added Gin and Martini frameworks.

Could anyone please advise me what to do in this case?


syslog or stdout/stderr configurability

I'd like to see out going to stdout/stderr since we run this in a Docker container and it would be more convenient when troubleshooting to simply look in one place for errors, thanks!

If this has any relation to FieldWorks writing to log files in /tmp/SIL with information that is not also written to stdout/stderr, I would be glad for these logs to (also) be written to stdout/stderr to make it easier to debug, spot problems, and help users supply problem report information.
If this issue has nothing to do with the above, then never mind :)

@marksvc the logging facility would be specific to LFMerge, which consumes fdo and liblcm.  So no actual impact on FW as far as I understand.

#134 and #135 implement this feature (on the master and fieldworks8-master branches respectively). Note that currently, the log output will not be visible in the container logs, because the LfMerge process runs as user www-data and therefore does not have access to the stdout and stderr of PID 1 (which runs as root). Once we move the LfMerge process to its own container so it's running as PID 1 in its own container then this shouldn't be as much of an issue. I'm currently looking into a way to make it work, but it looks like we would have to disable some Linux security features to give the LfMerge process write access to PID 1's stdout. So once this is merged, we'll want to have the Language Forge container set the environment variable LFMERGE_LOGGING_DEST=syslog, then change the LF entrypoint to run tail -f /var/log/syslog in the background so that syslog gets output to stdout.

I was trying to troubleshoot an issue on Language Forge today and had to go to /var/log/messages to see this LfMerge[1866]:    standerr: abort: repository is unrelated and the over to /var/lib/languageforge/lexicon/sendreceive/state/ to find "ErrorMessage": "Putting project 'project_name' on hold due to unhandled exception: \nChorus.VcsDrivers.Mercurial.UnrelatedRepositoryErrorException: The repository(a.k.a 'project' or 'collection') that you tried to synchronize with has the same name as yours, but it does not have the same heritage, so it cannot be synchronized. In order to Send/Receive projects, you have to start with a single project/collection, then copy that around. Don't feel bad if this is confusing, just ask for some technical help.
Troubleshooting would be much easier if errors were more consolidated into the _LOGGING_DEST.  If you all think this would be better captured as a separate issue I can create it but I wanted to see whether this was something that should even be done in the first place.

The primary way I troubleshoot send receive errors is to look for the error in the state file.  You can now use the copy-state script I recently checked in to capture all state files to your local machine :). Then you can open the Json file and look at the message.
Lots of improvements we could make in the process, but that's where things are currently

Related to #201
@longrunningprocess what would you say the status is on this issue?

I'd prefer those errors make it into the same place rather than knowing we have to check multiple places to get the whole story. If you agree, we can open another issue for that. Either way I do believe this can be closed.

As far as I understand, the errors you mention and had to find in the state file and in /var/log/messages should all be going into the STDOUT and the container logs now.  So we should be good there.  The state file can be used to see just the actual exception, if you find it difficult to wade through all the container output for the actual error message / exception.

As a side note, I notice the following message in the lfmerge logs on qa.languageforge.org (and presumably production)
WARNING: syslog logging no longer available, logging to console instead
Something somewhere in LFMerge is still trying to write to syslog, but it's probably not there anymore (hence the warning)


Infographic on why you should use qbraid

10 reasons why you should use qBraid1

Alberto:

superconduction, neutral atoms, trapped ion, etc. so using those you can obtain different outputs why, or what is better in a specific problem

This is a cool idea! I hope we can find someone to take a lead on this!


Added support for OH color type command OnOffType and PercentType

The mapping of the OH color type to IOB RGB string type supports now the OnOffType and PercentType, which can be send by OH.
Furthermore the OnOffType support for OH dimmers has been added.
Bugfix for issue #14.

Unfortunately, I can't check if it work.
But I will merge :) Thank you!


Webhook: Move all extended resources into one file

Description
When applying the webhook extended resources, make it so we only need to apply the one file rather than run a script.
This can be done by combining:

ext-res-rbac.yaml
ext-res-cm.yaml
ext-res-ds.yaml

Into one file called extended-resources.yaml or ext-res.yaml. This will then ensure that the applied yaml will be in the correct order and allow the user to apply the yaml without the need to run a script.
By doing something like:
kubectl apply -f github.com/confidential-containers/cloud-api-adaptor/webhook/hack/extended-resources

Ref: https://github.com/confidential-containers/cloud-api-adaptor/issues/1976


🚧 Remove govuk_toolkit shims

What
Removing the shims that static loads in from toolkit.
There were two shims mixing coming in from toolkit.
One was for display: inline-block which wasn't being used, so hasn't been moved across.
The other was for elements that contain floated elements - a clearfix. Where possible, this has been replaced with the govuk-clearfix class on the element. In two places, the styles weren't affecting anything in the templates in static - so the class couldn't be added in static. In those places I've imported the shim specifically into those stylesheets rather than into the base stylesheet.
Why
A step along the road towards the complete removal of toolkit from static - and turning off of the compatibility mode.
Visual differences
None

Looks like the two places where you've kept the %contain-floats shim for are multi-step and info-notice. As far as multi-step goes it looks like only licence-finder uses that class. I'm going to take a look and see if I can remove it from there/componentise it, can this PR wait a bit for that? It would be good to remove %contain-floats entirely, if possible.

Looks like the two places where you've kept the %contain-floats shim for are multi-step and info-notice. As far as multi-step goes it looks like only licence-finder uses that class. I'm going to take a look and see if I can remove it from there/componentise it, can this PR wait a bit for that? It would be good to remove %contain-floats entirely, if possible.

Super! Yep, I'll add a do-not-merge label so it can wait for those bits to be removed.

@injms licence finder updated: https://github.com/alphagov/licence-finder/pull/678
I'm going to do a second check for other instances now.

I think it'll soon be safe to remove this entire chunk from static: https://github.com/alphagov/static/blob/master/app/assets/stylesheets/helpers/_multi-step.scss#L148-L191
The last thing using %contain-floats in static will then be .info-notice in _text.scss. This seems to be quite widely in use, so my suggestion would be to remove the new shim file and put the code from it directly into _text.scss i.e.
  .info-notice {
    background: none;
    border-left: 10px solid $border-colour;
    margin-bottom: 1em;

    &:after {
        clear: both;
        content: "";
        display: block;
    }
  }

Super - thanks @andysellick. I've made the suggested changes and pushed them up. To prevent any mishaps I'll keep it labelled as 🚧 and 'do not merge' until the licence finder pull request has been deployed to production.


reverse_adoc: Fix regression: empty list items generated in nested lists

This fixes #96
Metanorma PR checklist

[ ] Breaking changes (list related PRs)
[ ] Documentation update required (create task for this)
[ ] External dependency introduced (documentation update need)
[ ] Gem with native library introduced

This does not affect the incoming document, but I found it while working on lists.


[Python] pyarrow.parquet.read_table either returns FileNotFound or ArrowInvalid

running below results in "GetFileIno() yielded path 'myBucket/features/MyParquet.parquet/year=2022/part-0019.snappy.parquet' which is outside base dir 'gs://myBucket/features/MyParquet.parquet/' "

import pyarrow.parquet as pq
import gcsfs
file_path="gs://myBucket/features/MyParquet.parquet/"
fs=gcsfs.GCSFileSystem()
table=pq.read_table(file_path,filesystem=fs)

Removing the gs:// from file_path results in a FileNotFoundError. Any variation of / or // at the beginning of the path gives me the 'outside base dir' error.
I also ran the below and got valid results using both file_path patterns, so I know it finds the path just fine.

from pyarrow.fs import FileSelector, PyFileSystem, FSSpecHandler
filesys = PyFileSystem(FSSpecHandler(fs))
selector = FileSelector(file_path, recursive=True)
filesys.get_file_info(selector)

Environment: GCP JupyterLab notebooks
Reporter: Callista Rogers
Note: This issue was originally created as ARROW-15910. Please see the migration documentation for further details.

I think these are related -- https://github.com/starburstdata/dbt-trino/issues/226
is there a way for pyarrow to ignore the '0' (i.e s3 dir files) of a directory


expand api documentation

Describe the feature
Please describe what each function does and is meant to be used for (and ideally an example), in the api documentation.

As well as when context is filled / how long it is persistent.

useSession - data does not seem to be persistent, please add a note how this could be changed (a usage example)

... having to read the source files to get a clue on what a function does, because the documentation does not contain an explanation seems to me to be very cumbersome.
Additional information

[ ] Would you be willing to help implement this feature?

We are working with @manniL to add more detailed docs both as guide and better API docs in jsdocs/readme.

related to #595
Hello @BananaAcid, do not hesitate to provide some feedbacks on the PR!


python312Packages.pytapo: 3.3.32 -> 3.3.37

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.pytapo is: Python library for communication with Tapo Cameras
meta.homepage for python312Packages.pytapo is: https://github.com/JurajNyiri/pytapo
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.3.36 with grep in /nix/store/52892vf1xgai7bfn5jzdmg8vcxc6bkck-python3.12-pytapo-3.3.36
found 3.3.36 in filename of file in /nix/store/52892vf1xgai7bfn5jzdmg8vcxc6bkck-python3.12-pytapo-3.3.36

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

python311Packages.pytapo
python312Packages.pytapo

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/52892vf1xgai7bfn5jzdmg8vcxc6bkck-python3.12-pytapo-3.3.36 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.pytapo https://github.com/r-ryantm/nixpkgs/archive/1416168982b73383e1f099018a7c1fdfc03ec559.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/1416168982b73383e1f099018a7c1fdfc03ec559#python312Packages.pytapo

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/52892vf1xgai7bfn5jzdmg8vcxc6bkck-python3.12-pytapo-3.3.36
ls -la /nix/store/52892vf1xgai7bfn5jzdmg8vcxc6bkck-python3.12-pytapo-3.3.36/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 4 packages built:

python311Packages.pytapo
python311Packages.pytapo.dist
python312Packages.pytapo
python312Packages.pytapo.dist

Maintainer pings
cc @fleaz for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Build and deployed on my home-assistant machine. Works ✅

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.pytapo is: Python library for communication with Tapo Cameras
meta.homepage for python312Packages.pytapo is: https://github.com/JurajNyiri/pytapo
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.3.37 with grep in /nix/store/kbkp2qv13ry8b42wjw2mqq83safyg950-python3.12-pytapo-3.3.37
found 3.3.37 in filename of file in /nix/store/kbkp2qv13ry8b42wjw2mqq83safyg950-python3.12-pytapo-3.3.37

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

python311Packages.pytapo
python312Packages.pytapo

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/kbkp2qv13ry8b42wjw2mqq83safyg950-python3.12-pytapo-3.3.37 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.pytapo https://github.com/r-ryantm/nixpkgs/archive/88a702963c3788ec12c6d714b86a5d561c0cca59.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/88a702963c3788ec12c6d714b86a5d561c0cca59#python312Packages.pytapo

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/kbkp2qv13ry8b42wjw2mqq83safyg950-python3.12-pytapo-3.3.37
ls -la /nix/store/kbkp2qv13ry8b42wjw2mqq83safyg950-python3.12-pytapo-3.3.37/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 4 packages built:

python311Packages.pytapo
python311Packages.pytapo.dist
python312Packages.pytapo
python312Packages.pytapo.dist

Maintainer pings
cc @fleaz for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 361333

aarch64-darwin

:white_check_mark: 4 packages built:

python311Packages.pytapo
python311Packages.pytapo.dist
python312Packages.pytapo
python312Packages.pytapo.dist


Make MSStore Developer CLI installation easier on CI/CD environments.

There is no simple way of installing the Microsoft Store Developer CLI in Azure DevOps or GitHub Actions.
We need to provide either a native GH Action and extension to install it, or at least scripts to help with this.

Solved for GitHub Actions. Still need to work on a more generic solution (powershell script maybe?).
https://github.com/microsoft/setup-msstore-cli

Just published the ADO extension:
https://marketplace.visualstudio.com/items?itemName=ms-aps-msstorecli.microsoft-store-developer-cli-task


ImportError: cannot import name 'tracing_enabled' from 'langchain_core.tracers.context'

Did a fresh installation on my M1 MBP and failed as below:
silviu@Silvius-MBP IdeaProjects % gpte project
Traceback (most recent call last):
  File "/opt/homebrew/bin/gpte", line 5, in <module>
    from gpt_engineer.applications.cli.main import app
  File "/opt/homebrew/lib/python3.11/site-packages/gpt_engineer/applications/cli/main.py", line 38, in <module>
    from gpt_engineer.applications.cli.cli_agent import CliAgent
  File "/opt/homebrew/lib/python3.11/site-packages/gpt_engineer/applications/cli/cli_agent.py", line 4, in <module>
    from gpt_engineer.core.ai import AI
  File "/opt/homebrew/lib/python3.11/site-packages/gpt_engineer/core/ai.py", line 12, in <module>
    from langchain.callbacks.streaming_stdout import StreamingStdOutCallbackHandler
  File "/opt/homebrew/lib/python3.11/site-packages/langchain/callbacks/__init__.py", line 45, in <module>
    from langchain_core.tracers.context import (
ImportError: cannot import name 'tracing_enabled' from 'langchain_core.tracers.context' (/opt/homebrew/lib/python3.11/site-packages/langchain_core/tracers/context.py)

So it seems https://github.com/langchain-ai/langchain/issues/15491

Possible solution, as suggested in above is to lock the version of core:
langchain-core==0.1.4
To fix, I changed my pyproject.toml to:
langchain = ">0.0.335, <0.1.5"
langchain-core = ">0.0.335, <0.1.5"

this bug was introduced in langchain 0.0349, 0.0.348 works just fine

Just encountered this issue and resolved it with @greenpau 's recommended fix. The key was to specify the exact versions in the requirements.txt file prior to installing gpt-researcher. Here are the steps I followed for a smooth setup:
Resolved Issue: Specifying Versions in requirements.txt for GPT-Researcher Installation
Steps for Setting up GPTResearcher

Prepare a Fresh Folder for GPTResearcher

Optional: Create a conda environment for isolation of dependency variables (conda create --name gptresearcher). This helps in minimizing any interference from other installations.

Navigate to the Folder in Command Prompt

Use the command cd /D D:/YourGPTResearcherFolder/itwillgohereas(gpt-researcher) to change your directory to the folder where you plan to clone gpt-researcher.

Clone the GPT-Researcher Repository

Execute git clone https://github.com/assafelovic/gpt-researcher.git in Command Prompt to clone the repository into your folder.

Change Directory to the Cloned Repository

Once cloned, switch to the directory using cd gpt-researcher.

Edit requirements.txt File

Open D:/YourGPTResearcherFolder/gpt-researcher/requirements.txt in a text editor.
Modify the file to include the following versions:langchain==0.0.350
langchain-community==0.0.2
langchain-core==0.1.0

In my experience, langchain was already there, but community and core were missing.

Install the Requirements

Run pip install -r requirements.txt in Command Prompt to install the specified dependencies.

Note: After these steps, ensure that your .env keys (e.g., OPENAI_API_KEY and TAVILY_API_KEY) are set correctly. In my case, it worked well with the default settings.
This process resolved the issue for me, hope it helps others!

Now that you have been reading up on this and playing  around @greenpau, @collinsomniac , @s1lviu @infinitelos @aguara-guazu
Are there any drawbacks with raising the langchain requirement in gpt-engineer to:
langchain = ">=0.0.350"
Are there any known compatibility losses associated with this? I suppose that may (partly?) solve this

@ATheorell for people like me who used the production installation method I think this is still an issue?

@s1lviu
I'm not sure what you mean. We haven't done anything to fix this, so unless you are using gpt-researcher and the instructions by  @collinsomniac

I've installed the software using python -m pip install gpt-engineer and was not sure requirements.txt can be provided with this method, as I'm not so familiar with python.
But the issue seems to be fixed now. I have run pip install --upgrade gpt_engineer langchain_core and it disappeared.
Thanks!


Do not recommend customizing an unsafe setting for local testing

Fixes #17961.

Please also propagate this change up to 23.2. Thanks for making the docs more safe. :)

Done.


Fold stellar/horizon into stellar/go/services/horizon

Notes for the current commit:

stellar/go/services/horizon/scripts/run_tests.bash passes, and the horizon server builds and serves on localhost:8000

I've updated stellar/go/services/horizon/README.md to link to the stellar/go/releases page so these download links are currently broken. We should backfill these links by creating new releases, or update these links to point to the old files in stellar/horizon/releases until we decide to push out a new horizon release.

The horizon docs now point to filing all issues to the “go” monorepo (stellar/go/issues) so we should expect that change in behavior from the community down the road.

The only bash script I've updated is stellar/go/services/horizon/scripts/run_tests.bash; all other scripts in stellar/go/services/horizon/scripts are currently broken because they depend on gb. We should work on fixing these scripts as a separate commit if we can tolerate having them broken for a short window — I can work on fixing them after this commit.

Changes needed in other repos to support this move:

Need to update https://github.com/stellar/developers/blob/master/repos.json to point to the new url — I will work on this after this commit.

I need to add a deprecated message to the old HORIZON repo’s README.md with a pointer to the new location — I can work on this after this commit.

had not included the /tree/master portion for web-based github urls so fixed that in commit no. 4

Looks like we're getting failures in Travis when running the test suite.

fixed a dependency issue (in commit 5) by picking the older option between stellar/go and stellar/horizon for goji.io, will address the remaining test failures to resolve the build.

Looks like the build is passing. This leaves the following changes which I plan to make once this PR is merged to fully complete the changes needed in this repo:

clean up the bash scripts in services/horizon/scripts -- this will unblock deployments for horizon since build_artifacts.bash is one of those scripts
port any changes that were made since I started my port (1 change)
convert tests to use the Postgres() call instead of the Start() call to parallelize the horizon tests and use the existing test script in .travis.yml

These are a lot of commits. Do you want me to clean them up into a fewer number of commits (or one commit) and re-submit with this finalized version?
@nullstyle

updated the scripts. let me know if there's anything else. I'm looking into any changes needed in the stellar/docs repo.


[Fix typo] Go is Deterministic.

"Go is Non-deterministic" has been corrected to Deterministic.
See also: #374

Thank you! It is imported, so will get merged in the next update (next year).

I found another typo in docs/developer_guide.md, can I include it in this pull request?
If it's not good, I'd be happy to fix it on your side.
docs/developer_guide.md#L17
*   `open_spiel/games`: Contains the games ++ implementations.

This should be C++, not ++.
docs/developer_guide.md#L27
## CPP and Python implementations.

It may be a matter of preference, but for consistency in notation, this might be C++, not CPP

Nice catches. I already imported your other one, so please make a separate PR for this.

@lanctot  I just created a pull request #468.
Thank you for taking your time to make these minor correction.


Remove Viper and duplicated config from Prometheus receiver

Follow up of https://github.com/open-telemetry/opentelemetry-service/pull/329.

Codecov Report

Merging #331 into master will increase coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
+ Coverage   73.87%   73.89%   +0.01%
==========================================
  Files         115      115
  Lines        6738     6711      -27
==========================================
- Hits         4978     4959      -19
+ Misses       1505     1499       -6
+ Partials      255      253       -2

Impacted Files
Coverage Δ

receiver/prometheusreceiver/metrics_receiver.go
68.51% <66.66%> (+1.41%)
:arrow_up:

receiver/prometheusreceiver/factory.go
69.44% <66.66%> (-3.73%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce36a89...fa3424b. Read the comment docs.

PTAL - should be a straightforward cleanup.


Don't show Await

As follow up to Roland's comment, that we likely shouldn't show Await in example snippets.

LGTM

Fixed and merging


Second and next tracks play without audio

Hello @bors-ltd, another audio issue :-(
From<EMAIL_ADDRESS>
I start an Album and the first Track runs normal with Audio. After that
when he goes on second Track, i did not hear anything but it still runs.
When go back with "<<" at the beginning of this track, Audio comes back.
This happens on every Track.

It sounds like our issue #2. Can you ask them if it happened with the FLAC format and if they can try again with the MP3 format ? Also to pay attention if a song of the playlist was indeed skipped.

Also, what album or playlist, for me to try and reproduce it.

Hello,
i told Jiri this Problem.
I run Qobuz on Ubuntu 18.04. With MP3 it seems to be ok. It happens only with CD 16Bit/44.1 KHz. Albums for Example: Diana Krall "Turn up the Quiet" or Still Euge "Euge Groove". It seems to be on all Albums. With Playlists i did not test it until now.
Hires 24bit is not possible in the Quality Dropdown like in the Windows Version.
Thank You!
Klaus

Yes indeed it looks like issue #2.
Can you confirm that a song is skipping? E.g. you're listening to track 1, when it ends the player is switching to track 2 for like a second, and immediately switch to track 3. The buffer is filling up but the playing never start (time still at 00:00).
Or do you see the time increasing and the position cursor moving to the right, just like if the song was playing?

Hello Herve,
when Track 1 ends, it switch to Track 2 an the time increasing just like the song is playing.
Sorry for the delay , i was out today.
Thank You
Klaus

So if the song is playing and you don't hear any sound, that's a new bug. :cry:
But it probably has a common cause with #2 (and #1 I'll bet), so when we tackle it, your bug will be fixed.
In the meantime, you can listen in MP3 format if you want to keep using this application.


[Doc] Add missing <?php open tag in config example

Avoid copy paste and got error like in issue:

https://github.com/rectorphp/rector/issues/8480

Looks good :+1:


Automatic calculation of LQR controller that includes yaw angle as a state.

This hopes to solve two things: 1) drive yaw angle to zero and 2) automatically find the control gains for whatever parameter set and speed we supply.
TODO

[ ] Load parameters from BicycleParameters as the benchmark set and then convert to the Moore values for use in the model (we currently just load the Moore parameters). Another option would be to write a function that converts benchmark parameters to moore parameters.

If you weight the yaw state more, this actually works (although there is lots more lateral motion than we see in the real experiments):

@GabrieleDello fyi

I guess the rider is not only driving heading to zero but also driving lateral position to zero (or near zero). So I could add that feedback loop also.


fix: KClass qualified name is sanitized when generating Type

The following changes add previously available sanitization to Type generation via extension method on KClass inside TypeUtils.kt.
Solves https://github.com/raamcosta/compose-destinations/issues/288

Hi @hrafnthor 👋
Thank you for this.
However, I would not like to mess with Type package names as we can be comparing them and sanitizing them could lead to some bugs when that happens.
Instead, I would like to fix this only for when using the qualified name in the final source code generated (like we do for imports already).
I was reproducing the issue and thinking of how to fix, and it's actually pretty simple, so, if you don't mind, I would be closing this PR (alternatively, I could tell you how I think we should do, and you can check on your side if you agree and we could continue with the PR 🙂 ).
Also, do check issue #288 as I'd like to know more about your specific case!
Let me know! Thanks!

Absolutely, if there is a better way of solving the issue then by all means close this PR :+1:

Closing then, thank you so much regardless! 🙇


[Gekidou] Set lastFetchAt when fetching posts for a channel

Summary
Set lastFetchAt to MyChannel when fetching posts and use that value when fetching posts since
NONE

lol ok need to resolve conflicts, then I'll merge.
@larkox should I merge the base branch to gekidou as well or you want to give it another pass ?


backport: adding example and clarification (#357)

adding example and clarification

miscalculation

precision

clarification readme

Update readme.rst

indentation

deletion of size indications

adding example for option 4

bad unit

Update readme.rst

clarification

clarification, correction, change command

Update readme.rst

Update roles/addons/diskless/readme.rst

Co-authored-by: Bruno Travouillon<EMAIL_ADDRESS>
Update readme.rst

a blank line is missing => ok
5G is more user-friendly. => ok

Update readme.rst

Co-authored-by: Bruno Travouillon<EMAIL_ADDRESS>(cherry picked from commit 14c445719e871b5fbb8d7908fdad742e47063a18)

Please backport also https://github.com/bluebanquise/bluebanquise/commit/03484641b8b26ed588201d006b8d9e0fe9e40c8e in this PR.


Add support for immutable cache header attribute

Adding an immutable attribute to the Cache-Control header ensures no requests have to be done to revalidate the cache when reloading a page, see: https://hacks.mozilla.org/2017/01/using-immutable-caching-to-speed-up-the-web/.
ImageProcessor already supports cache buster variables: https://github.com/JimBobSquarePants/ImageProcessor/blob/31a8c46a8556e3635273e025d435dbf593d093d3/src/ImageProcessor.Web/HttpModules/ImageProcessingModule.cs#L700-L713
So should ImageProcessor add immutable to all responses when it detects a cache buster variable? Adding the attribute can be done using:
cache.AppendCacheExtension("immutable");

As a workaround, IIS outbound rewrite rules can be used:
<configuration>
  <system.webServer>
    <rewrite>
      <outboundRules>
        <rule name="AddCacheControlImmutable">
          <match serverVariable="RESPONSE_Cache_Control" pattern=".*" />
          <conditions logicalGrouping="MatchAny" trackAllCaptures="false">
            <add input="{QUERY_STRING}" pattern="(\?|&)rnd=" />
            <add input="{QUERY_STRING}" pattern="(\?|&)v=" />
          </conditions>
          <action type="Rewrite" value="public,max-age=31536000,immutable" />
        </rule>
      </outboundRules>
    </rewrite>
  </system.webServer>
</configuration>

This however overwrites the configured browserMaxDays, so it would be nice if it played well with the ImageProcessor configuration...

I like this. Adds a feature without adding extra maintenance responsibility. 👍

I've improved the outbound IIS rewrite rule, so it only matches the exact Cache-Control header from ImageProcessor (seems to always be public, must-revalidate, max-age=*).
This also makes sure it only rewrites the header if the request is already publicly cachable and allows capturing the max-age value (so the configured browserMaxDays is honored and is kept in-sync with the Expires header). The query string conditions now also correctly match the cache buster value on the beginning of the string (because {QUERY_STRING} does not start with ?).
<rule name="AddCacheControlImmutable">
  <match serverVariable="RESPONSE_Cache_Control" pattern="public, must-revalidate, max-age=([0-9]+)" />
    <conditions logicalGrouping="MatchAny" trackAllCaptures="false">
      <add input="{QUERY_STRING}" pattern="(^|&)rnd=" />
      <add input="{QUERY_STRING}" pattern="(^|&)v=" />
    </conditions>
  <action type="Rewrite" value="public, immutable, max-age={R:1}" />
</rule>

Although I get your point on the maintenance responsibility, because it can indeed be fixed without changing ImageProcessor, it still feels like a hack and doesn't make ImageProcessor use best-performance cache headers by default.
I'm even willing to create a PR for this, just let me know whether you're prepared to merge it 😉

Although I get your point on the maintenance responsibility, because it can indeed be fixed without changing ImageProcessor, it still feels like a hack and doesn't make ImageProcessor use best-performance cache headers by default.

I actually meant that adding this would mean no extra maintenance responsibility.
cache.AppendCacheExtension("immutable");
It's such a small change, so yeah, happy to add it.

Ah, I thought you were referring to the rewrite rule ;-)
Adding it was indeed a small change: I just had to change ParseCacheBuster to a static method and change the SetHeaders method to add the immutable extension when cache busting variables are used 👍

Just for reference:

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control#Revalidation_and_reloading
https://bitsup.blogspot.com/2016/05/cache-control-immutable.html

Merged


Update retention.md

Fixed typo/missing words

@juliakm
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Thanks @lonevvolf!
#sign-off


Preview of markdown is not working

This seems to be duplicate of https://github.com/Microsoft/vscode/issues/68912
I tried to disable all extension, restart VSCode and markdown seems to work. But as soon as I enabled one extension (no matter which) it seems to stop working again.
In developer console I found this error
[Embedded Page] Uncaught TypeError: Cannot read property 'body' of null

It appears everytime I try to open preview.
Issue Type: Bug
After upgrading to  1.32.3 I tried Ctrl+K V to see preview of my markdown file but the preview window stays clear with no text whatsoever.

Does this reproduce in the latest VS Code insiders build with all extensions disabled?

No, I didn't test it. Nevertheless, on my second computer (same system, the latest version of VsCode) I was not able to reproduce it either. This one works as expected with my extensions enabled.

Please test on the latest insiders build

OK I will try. Meanwhile I should inform you I have completely uninstalled the not-functional VS Code  and installed new downloaded one for system installation. Now it is working again.

OK, so insider build downloaded and extracted from zip with no installed extension doesn't work!

Does it work for any markdown files?

Sometimes yes, sometimes no. I saw even problem with md files from extension description.

Based on the error, this sounds like the same issue as #70790
It seems there's something goofy going on with webviews and window's firewall or security settings. Will keep tracking this issue in #70790


Vagrant vmware_fusion not starting up

Description
I want to try out flatcar. I have vagrant and the vmware_fusion plugin.
Impact
I cannot explore flatcar
Environment and steps to reproduce
(base) chaimkrause@macmini flatcar % vagrant box add --name flatcar-alpha https://alpha.release.flatcar-linux.net/amd64-usr/current/flatcar_production_vagrant_vmware_fusion.box
==> box: Box file was not detected as metadata. Adding it directly...
==> box: Adding box 'flatcar-alpha' (v0) for provider:
    box: Downloading: https://alpha.release.flatcar-linux.net/amd64-usr/current/flatcar_production_vagrant_vmware_fusion.box
==> box: Successfully added box 'flatcar-alpha' (v0) for 'vmware_fusion'!
(base) chaimkrause@macmini flatcar % rm Vagrantfile
(base) chaimkrause@macmini flatcar % vagrant init flatcar-alpha
A `Vagrantfile` has been placed in this directory.  Please read
the comments in the Vagrantfile as well as documentation on
`vagrantup.com` for more information on using Vagrant.
(base) chaimkrause@macmini flatcar % vagrant up
Bringing machine 'default' up with 'vmware_desktop' provider...
There are errors in the configuration of this machine. Please fix
the following errors and try again:

VMware Desktop Provider:
* The MAC address provided for `base_mac` is invalid. Ensure the MAC
address provided is valid and begins with the VMware Organizationally
Unique Identifier (00:50:56).

(base) chaimkrause@macmini flatcar %

Expected behavior
smooth start up
Additional information
Please add any information here that does not fit the above format.

Hi @tinjaw and sorry for the delay. I think there are two issues:

MAC address should match this format: https://github.com/hashicorp/vagrant-vmware-desktop/blob/5cb6a81a166ca6adaa109e816c5aeae8ccb9b752/lib/vagrant-vmware-desktop/config.rb#L16
MAC address should start with 00:50:56

Currently, generated MAC address is something like: 080027E87F12 - we should patch this file here: https://github.com/flatcar-linux/scripts/blob/392ce4089b4da662bcd13c7b82cf753cb8289abd/build_library/virtualbox_ovf.sh#L37-L42


[62] OpenAPI/Swagger integration skeleton

@swaroopar it's WIP for OpenAPI/Swagger UI integration. I will push new updates soon.

Here's the URL to get OpenAPI: http://localhost:8080/openapi
All good :)
We can load the OpenAPI json in Swagger UI. I will add Swagger UI as optional module in the runtime.

Just added Swagger UI (via unpkg) on http://localhost:8080/swagger by default, loading OSC OpenAPI.
I will update the documentation now as part of this PR :)


Add service token cross stack reference

Closes #51. Rather than namespace the export I've made so you can over-ride the name of the export with a parameter.

Released under version 2.2.0 (2.1.0 was accidentally scrapped)


Bug in tutorial_cifar10_tfrecords.py

There seems to be a bug in the examples/tutorials_cifar10_tfrecords.py
Using tensorflow 0.12.1 I get the following error:
File "tutorial_cifar10_tfrecord.py", line 116, in read_and_decode
img = tf.image.per_image_whitening(img)
AttributeError: 'module' object has no attribute 'per_image_whitening'
[deepmind@deepmind tensorlayer]$

@JoelKronander  Oh... TF 0.12 removes tf.image.per_image_whitening()  ..
It works well under TF 0.11


Is it possible to parse a log that contains a java stacktrace?

I looked over the source code and couldn't figure out if it is possible to read/parse a java stacktrace. Is it possible? Or customizable?
Thanks
p.s. great work by the way!

Thanks for your nice words and a great question.
To be completely frank I have never tried it, and it was not really ment for it. Any suggestions for a specific use case?

I would like to analize tomcat's server error with and without exceptions. In the end of the day I would like to have a summary of exceptions that happened in a timeframe.

Well it is worth looking into.
Finding data in a timeframe is included in the latest version. The tricky part may be how exceptions are logged in tomcat. I'll give it a try.
The log-parser will not be be able to to treat both errors and stack traces in the same time. I'll prepare an example, and we can agree on the outcome.
Would that work for you?

Hi @tmoreira2020 as a starting point I have created a small example:
branch: tomcat
Test: com.adobe.campaign.tests.logparser.core.LogDataTest#testHelloTomcat
Test file: src/test/resources/logTests.tomcat/catalina.example.log
The outout I get is:
20-Sep-2024 06:01:02.946#|;20-Sep-2024 06:01:02.946;|;main;org.apache.tomcat.util.net.Acceptor.stopMillis The acceptor thread [http-nio-1234-Acceptor] did not stop cleanly;1
29-Oct-2024 09:15:01.048#|;29-Oct-2024 09:15:01.048;|;http-nio-1234-exec-3;org.apache.catalina.core.StandardWrapperValve.invoke Servlet.service() for servlet [neolanejsp] in context with path [/nl/jsp] threw exception [An exception occurred processing [uploadFile.jsp] at line [82];1
29-Oct-2024 09:15:01.050#|;29-Oct-2024 09:15:01.050;|;http-nio-1234-exec-11;org.apache.catalina.core.StandardWrapperValve.invoke Servlet.service() for servlet [neolanejsp] in context with path [/nl/jsp] threw exception [An exception occurred processing [uploadFile.jsp] at line [82];1

hey @baubakg , thanks for the quick follow up and sample.
The sample that you provided is halfway of what I'm looking for. The second half would be a way to retrieve the stacktrace of the exception via LogData<GenericEntry> object. Makes sense?

Ok good.
Is that correct?

Yes, correct!

Ok I think we have a design limitation, as the log-parser in its current form, works with only one line at a time. Even multiple parsings will have the issue of deducing the relationship between the findings.
I think we should consider a future feature where we accept that a log entry can be multilined.
It is a bit tricky though, as there are two options:

Instead of using the EOLN as a log entry ending, we store everything between two findings
We define a multiline repeatable pattern. Instead of one parse definition, we pass a series of parse definitions. This will represent a multi-line pattern.

We will need to also to have a repetitive storage, that for a stacktrace pattern we fetch all the stacktraces.


Open source the Quill project

As the Quill project is built using the CRA and the Trill  library which are now both open source projects, please consider open sourcing the Quill project.
Links

Distributed Trill support

Good timing for the ask, actually. Our collaborator and former intern @ibrahimsabek has been working on a prototype port of Quill to work on CRA. He should have the sample here in the next few weeks to play with.

Hi! Is there any progress now?


VSCode Plugin

RbSyn is non-interactive at the moment---there are specs and then the synthesizer finds some code that satisfies it without any further human input. However, the core of RbSyn supports partial programs in the form of holes, but that functionality is not exposed anywhere. A VSCode plugin will be the best way to write programs (partial/full) and let RbSyn do the completion. This involves the following steps:

[ ] Add surface syntax support to write type and/or effect holes
[ ] Investigate possible ways to integrate type inference of the holes so that types need not be written at the holes
[ ] Refactor RbSyn core into a background server that searches for program candidates
[ ] A VSCode plugin that takes the surface syntax passes that to a server and displays possible solutions
[ ] Investigate with a user study if program synthesis with a human in the loop actually aids in faster and correct programming?

#26 describes a better DSL for tests, which might be helpful for users who do not want to learn the pre/post syntax of RbSyn.


leaking AWS credentials in pytest suite

In a project with a large pytest suite that uses random test orders and several different AWS profiles, the test suite has become fragile and flaky.  Every instance of the failure lies in s3fs, no matter whether it is pyarrow or pandas that is using it.
Since https://github.com/dask/s3fs/pull/244 - 0.4 - is there a persistent cache of AWS credentials somewhere in s3fs that is not cleared when a pytest fixture changes some env-vars for AWS credentials (using monkeypatch.setenv and monkeypatch.delenv)?  When the flaky tests are run in isolation, they use the AWS env-var mock-credentials, but when they are mixed in with a full random test suite that could run a different test with different credentials first, the flaky tests fail due to credential failures.
The code under test is usually vanilla pyarrow or pandas, with no explicit use of s3fs or any kwargs that would pass any explicit credentials.  In every case, it is assumed that env-vars will be read by a default botocore (aiobotocore) session init.
Example pytest fixtures that set AWS env-vars:

import boto3
import pytest

AWS_REGION = "us-west-2"
AWS_ACCESS_KEY_ID = "test_AWS_ACCESS_KEY_ID"
AWS_SECRET_ACCESS_KEY = "test_AWS_SECRET_ACCESS_KEY"

@pytest.fixture
def aws_region(monkeypatch) -> str:
    monkeypatch.setenv("AWS_DEFAULT_REGION", AWS_REGION)
    yield AWS_REGION
    monkeypatch.delenv("AWS_DEFAULT_REGION", raising=False)

@pytest.fixture
def aws_credentials(aws_region, monkeypatch):
    """Mocked AWS Credentials for moto."""
    boto3.DEFAULT_SESSION = None
    monkeypatch.delenv("AWS_DEFAULT_PROFILE", raising=False)
    monkeypatch.delenv("AWS_PROFILE", raising=False)
    monkeypatch.setenv("AWS_ACCESS_KEY_ID", AWS_ACCESS_KEY_ID)
    monkeypatch.setenv("AWS_SECRET_ACCESS_KEY", AWS_SECRET_ACCESS_KEY)
    monkeypatch.setenv("AWS_SECURITY_TOKEN", "testing")
    monkeypatch.setenv("AWS_SESSION_TOKEN", "testing")

    yield

    monkeypatch.delenv("AWS_DEFAULT_PROFILE", raising=False)
    monkeypatch.delenv("AWS_DEFAULT_REGION", raising=False)
    monkeypatch.delenv("AWS_ACCOUNT", raising=False)
    monkeypatch.delenv("AWS_ACCESS_KEY_ID", raising=False)
    monkeypatch.delenv("AWS_SECRET_ACCESS_KEY", raising=False)

Any given pytest can use that fixture to manipulate the credentials available for the test.  While most tests use mocks with moto, some tests use actual AWS-live credentials on an account dedicated to AWS-live unit tests.  The AWS-live tests need to switch the credentials, so they use a similar fixture that manipulates env-vars.  With randomized tests, the use of pyarrow and pandas with s3 objects is flaky because it seems like s3fs is caching a session or something under the hood.
Could a test fixture like this somehow reset or clear any cached session anywhere in s3fs?  The API docs don't say much about how clear_instance_cache works.  Are there any class methods on S3FileSystem that could clear any cached sessions?  How would a test fixture like the above clear s3fs sessions, like boto3.DEFAULT_SESSION = None?
 In this case, you are not passing the key/secret/etc explicitly, so a new instance is not being made - the case where the environment variables change in the meantime is not accounted for (this is not normal usage).
For the sake of your tests you could call S3FileSystem(..., skip_instance_cache=True) every time, or S3FileSystem.clear_instance_cache() between uses.

Is there a useful place in the tests for this project to try this?  The errors arise when pyarrow or pandas is using s3fs; there may be no direct access to any instances that pyarrow or pandas might cache.

Yes, that looks fine. Without passing explicit parameters to the storage backend (storage_options=) in read_csv, the instance would be the equivalent of S3FileSystem() without kwargs - if you wanted to examine its state for some reason.

After a few runs of the test suite, with random test order, there are no flaky tests.  This could be working.  For reference, the test fixture for AWS live tests uses a named profile to change the credentials:
@pytest.fixture
def aws_live_session(monkeypatch):
    # The credentials for this AWS profile are not widely distributed and
    # are not likely to work for everyone trying to run this test, so they
    # will need to get them or rely on CI to apply them.

    boto3.DEFAULT_SESSION = None
    S3FileSystem.clear_instance_cache()
    monkeypatch.delenv("AWS_ACCOUNT", raising=False)
    monkeypatch.delenv("AWS_ACCESS_KEY_ID", raising=False)
    monkeypatch.delenv("AWS_SECRET_ACCESS_KEY", raising=False)
    monkeypatch.delenv("AWS_SECURITY_TOKEN", raising=False)
    monkeypatch.delenv("AWS_SESSION_TOKEN", raising=False)

    try:
        monkeypatch.setenv("AWS_DEFAULT_PROFILE", LIVE_PROFILE)
        monkeypatch.setenv("AWS_DEFAULT_REGION", LIVE_REGION)
        # Any clients created from this session will use credentials
        # from the [jupiter-test] section of ~/.aws/credentials.
        session = boto3.Session(profile_name=LIVE_PROFILE, region_name=LIVE_REGION)
        credentials = session.get_credentials().get_frozen_credentials()

    except botocore.exceptions.ProfileNotFound:
        # Exit for users without the jupiter-csg credentials
        monkeypatch.delenv("AWS_DEFAULT_PROFILE", raising=False)
        monkeypatch.delenv("AWS_DEFAULT_REGION", raising=False)
        LOGGER.error("Missing AWS credentials (%s), skipping AWS live test", LIVE_PROFILE)
        return

    monkeypatch.setenv("AWS_PROFILE", session.profile_name)  # GDAL >= 3.2
    monkeypatch.setenv("AWS_DEFAULT_PROFILE", session.profile_name)
    monkeypatch.setenv("AWS_DEFAULT_REGION", session.region_name)
    monkeypatch.setenv("AWS_ACCESS_KEY_ID", credentials.access_key)
    monkeypatch.setenv("AWS_SECRET_ACCESS_KEY", credentials.secret_key)

    yield session

    monkeypatch.delenv("AWS_PROFILE", raising=False)  # GDAL >= 3.2
    monkeypatch.delenv("AWS_DEFAULT_PROFILE", raising=False)
    monkeypatch.delenv("AWS_DEFAULT_REGION", raising=False)
    monkeypatch.delenv("AWS_ACCOUNT", raising=False)
    monkeypatch.delenv("AWS_ACCESS_KEY_ID", raising=False)
    monkeypatch.delenv("AWS_SECRET_ACCESS_KEY", raising=False)
    monkeypatch.delenv("AWS_SECURITY_TOKEN", raising=False)
    monkeypatch.delenv("AWS_SESSION_TOKEN", raising=False)
    boto3.DEFAULT_SESSION = None
    S3FileSystem.clear_instance_cache()

OK to close this?


Add a progress bar to load_cfb_pbp

Obviously, this function takes quite a while to bring in, long enough that it leaves the user uncertain if it's still working properly or if something has frozen.


Bug: invalid utf-8 sequence of 1 bytes from index 52

What happened?
Trying to transcribe youtube video.
Steps to reproduce

Put link
Click "Download Audio"

What OS are you seeing the problem on?
Windows 11
Relevant log output
invalid utf-8 sequence of 1 bytes from index 52

Location:
    desktop\src-tauri\src\cmd\ytdlp.rs:72:22
App Version: vibe 2.6.3
Commit Hash: d24ffccb0d05ea822ff1a3a6edb3b9871be9f368
Arch: x86_64
Platform: windows
Kernel Version: 10.0.22631
OS: windows
OS Version: 10.0.22631
Cuda Version: n/a
Models: ggml-medium.bin
Default Model: "C:\\Users\\Matvey\\AppData\\Local\\github.com.thewh1teagle.vibe\\ggml-medium.bin"
Cargo features: vulkan

{
    "avx": {
        "enabled": true,
        "support": true
    },
    "avx2": {
        "enabled": true,
        "support": true
    },
    "f16c": {
        "enabled": true,
        "support": true
    },
    "fma": {
        "enabled": true,
        "support": true
    }
}

Dup https://github.com/thewh1teagle/vibe/issues/341


Fetch & Process FORE-SCE

Plan to use this dataset for land cover change scenarios
Data source: https://www.sciencebase.gov/catalog/item/605c987fd34ec5fa65eb6a74
Visuals:

Initial description of data:

tif format
Extent: drb
A dataset per decade from 1680 to 2010

Task:

Import 1960-2010 datasets (n = 5)
Convert to raster df with xy coords (terra package)

check that xy = T in terra::as.data.frame() is the pixel centroid or a diff coord

Create a change index between the decades and aggregate (something to figure out)

Initial approach - [1] Spread/melt df to make LULC type a specific attribute, run a diff per decade

Match flowline segment with raster class it intersects with
Calculate proportion of raster class

Secondary process of fore-sce in the works in this branch in my forked repo: https://github.com/msleckman/drb-inland-salinity-ml/tree/aggregate_FORESCE_PRMS


chore: bump api category to 4.1.9

Description of changes
https://github.com/aws-amplify/amplify-category-api/releases/tag/%40aws-amplify%2Famplify-category-api%404.1.9

Issue #, if available

Description of how you validated changes
Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
[ ] Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Are you running the e2e flows?

Update with cloud e2e https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli?branch=run-e2e/lizeyu/update-data-packages

Update with cloud e2e https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli?branch=run-e2e/lizeyu/update-data-packages

Are you running the e2e flows?

Update with cloud e2e https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli?branch=run-e2e/lizeyu/update-data-packages


Equinix Metal BGP peer routing issue when using a BGP password

Describe the bug
There seems to be an issue with kube-vip not being able to reach BGP peers on Equinix Metal when using a BGP password.
To Reproduce
Steps to reproduce the behavior:

Enable Equinix Metal project BGP with a BGP password.
Deploy a k8s cluster with kubeadm
Deploy CPEM and define kube-vip as the load balancer integration: https://github.com/equinix/cloud-provider-equinix-metal
Deploy kube-vip v0.3.7 with debug level 5.
Expose a service of type LoadBalancer
Kube-vip logs will show the following route errors:

time="2021-08-19T16:35:37Z" level=debug msg="try to connect" Key=<IP_ADDRESS> Topic=Peer
time="2021-08-19T16:35:37Z" level=debug msg="try to connect" Key=<IP_ADDRESS> Topic=Peer
time="2021-08-19T16:35:41Z" level=debug msg="failed to connect: dial tcp <IP_ADDRESS>:0-><IP_ADDRESS>:179: i/o timeout" Key=<IP_ADDRESS> Topic=Peer
time="2021-08-19T16:35:41Z" level=debug msg="failed to connect: dial tcp <IP_ADDRESS>:0-><IP_ADDRESS>:179: i/o timeout" Key=<IP_ADDRESS> Topic=Peer
time="2021-08-19T16:35:58Z" level=debug msg="try to connect" Key=<IP_ADDRESS> Topic=Peer
time="2021-08-19T16:35:59Z" level=debug msg="try to connect" Key=<IP_ADDRESS> Topic=Peer
time="2021-08-19T16:35:59Z" level=debug msg="failed to connect: dial tcp <IP_ADDRESS>:0-><IP_ADDRESS>:179: connect: no route to host" Key=<IP_ADDRESS> Topic=Peer
time="2021-08-19T16:36:07Z" level=debug msg="failed to connect: dial tcp <IP_ADDRESS>:0-><IP_ADDRESS>:179: i/o timeout" Key=<IP_ADDRESS> Topic=Peer
time="2021-08-19T16:36:12Z" level=debug msg="try to connect" Key=<IP_ADDRESS> Topic=Peer
time="2021-08-19T16:36:12Z" level=debug msg="failed to connect: dial tcp <IP_ADDRESS>:0-><IP_ADDRESS>:179: connect: no route to host" Key=<IP_ADDRESS> Topic=Peer
time="2021-08-19T16:36:21Z" level=debug msg="try to connect" Key=<IP_ADDRESS> Topic=Peer
time="2021-08-19T16:36:21Z" level=debug msg="failed to connect: dial tcp <IP_ADDRESS>:0-><IP_ADDRESS>:179: connect: no route to host" Key=<IP_ADDRESS> Topic=Peer

Expected behavior
BGP peering established.
Screenshots
Logs shown above.
Environment:

OS/Distro: [Ubuntu 20.04]
Kubernetes Version: [v.1.22.0]
Kube-vip Version: [v0.3.7]

Kube-vip.yaml:
apiVersion: apps/v1
kind: DaemonSet
metadata:
  creationTimestamp: null
  name: kube-vip-ds
  namespace: kube-system
spec:
  selector:
    matchLabels:
      name: kube-vip-ds
  template:
    metadata:
      creationTimestamp: null
      labels:
        name: kube-vip-ds
    spec:
      containers:
      - args:
        - manager
        env:
        - name: vip_arp
          value: "false"
        - name: vip_interface
          value: lo
        - name: port
          value: "6443"
        - name: vip_cidr
          value: "32"
        - name: svc_enable
          value: "true"
        - name: vip_startleader
          value: "false"
        - name: vip_addpeerstolb
          value: "true"
        - name: vip_localpeer
          value: controller-node:<IP_ADDRESS>:10000
        - name: annotation
          value: metal.equinix.com
        - name: bgp_enable
          value: "true"
        - name: bgp_routerid
        - name: bgp_as
          value: "65000"
        - name: bgp_peeraddress
        - name: bgp_peerpass
        - name: bgp_peeras
          value: "65000"
        - name: vip_address
        - name: vip_loglevel
          value: "5"
        image: plndr/kube-vip:v0.3.7
        imagePullPolicy: Always
        name: kube-vip
        resources: {}
        securityContext:
          capabilities:
            add:
            - NET_ADMIN
            - NET_RAW
            - SYS_TIME
      hostNetwork: true
      serviceAccountName: kube-vip
  updateStrategy: {}
status:
  currentNumberScheduled: 0
  desiredNumberScheduled: 0
  numberMisscheduled: 0
  numberReady: 0

Additional context
This issue happens on older kube-vip releases as well. I tried kube-vip v0.3.3 and v0.3.7.

@enkelprifti98 has https://github.com/kube-vip/kube-vip/issues/250 been ruled out? (could you include a dump of the relevant route output, if available)

Also, were there any warnings during install, as in https://github.com/kube-vip/kube-vip/issues/242?

@displague I've updated the original title and post to reflect my findings. The root cause for this issue seems to be setting a BGP password for Metal project BGP.

It looks like - name: bgp_peerpass is not defined in the config (or was omitted without a comment suggesting as much)

It looks like - name: bgp_peerpass is not defined in the config (or was omitted without a comment suggesting as much)

I believe that always stays that way since kube-vip pulls the BGP info from the node annotations. I could be wrong though.

Kubevip is supposed to pull it from the annotations, it is interesting that setting the password causes it to fail.
I haven't kept entirely on top of it, but I'm pretty sure that the annotations all work. Perhaps the password breaks something?
We never really liked having the password in the annotations, as it is insecure. But given that it's there, it should work.

@deitch Yeah the CCM is working properly and adding the node annotations including the BGP password albeit base64 encoded.

https://github.com/kube-vip/kube-vip/pull/227
Presumably down to this. Doh

Hmm, @enkelprifti98 can you guarantee that the CCM populated the bgp-pass field?
I just tried the CCM and the password field was left blank.
Annotations:        kubeadm.alpha.kubernetes.io/cri-socket: /var/run/dockershim.sock
                    metal.equinix.com/bgp-pass:
                    metal.equinix.com/network-4-private: <IP_ADDRESS>/25
                    metal.equinix.com/node-asn: 65000

@thebsdbox yeah on my end the CCM updates the bgp-pass annotation properly. It also updates it in real time as I change the BGP password.
I'm using the latest version of the CCM.

Odd!
        - name: bgp_peerpass
          value: <PWD>

Fixes the issue, I'm not sure why the password isn't propagating to the BGP configuration from annotations.


Move the login logic from the upgrade request to an independent login request after the WebSocket connection established

Motivation
It's very common for users to input the wrong login authentication information. So the steps to establish a WebSocket connection should look like this:
A user input the userId and password; 2. Establish a TCP(+TLS) connection; 3. It's wrong login authentication information, so the server declines the upgrade request; 4. The TCP connection is closed;
So the problem is the TCP connection will be established and closed for wrong login information again and again.


teams: fix source hash of <IP_ADDRESS>53 on Darwin

Description of changes

Teams was upgraded to <IP_ADDRESS>53 in #170863 but that PR missed the update of the hash of the source package on Darwin platforms.
I am unable to build and test this but the hash should be correct.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 171295 run on aarch64-darwin 1

1 package built:

teams

Thanks!


Rename crds

Description
Check each of the following when appropriate to help reviewers verify work is complete.
Modifying an existing version

[ ] I modified operator permissions in the OLM CSV and operator.yml
[ ] I modified the operator deployment in the OLM CSV and operator.yml
[ ] I modified operand permissions in the OLM CSV and ansible role
[ ] I modified CRDS in the OLM CSV and ansible role

Adding a new release version

[ ] I created a new z release directory in deploy/olm-catalog/konveyor-operator
[ ] I updated channels in the konveyor-operator.package.yaml
[ ] I created a new release directory in deploy/non-olm
[ ] I created or updated the major.minor link in deploy/non-olm
[ ] I updated the spec.skips parameter in the CSV
[ ] I updated downstream-prep.sh to only update the latest CSV patch version in the channel

Addresses https://github.com/konveyor/mig-operator/issues/284

\test

\test

@jmontleon so this is just using generated CRD names? What's the reason for the switch?

@djwhatle Just to make it easier to copy/overwrite them without renaming in the process since it's bad enough already having to copy them to multiple locations.

\test


Create middleware for file upload

Create a file upload in common/middlewares.
Create a multer upload function middleware.

You can assign this issue to me.

Boss, where are the uploaded files going to be saved.  I want to point multer to this destination.

We're saving in memory for multer.

All right boss.


tokenizeLine is not a function

Hello,
I'm Denis, an Italian developer !
I'm trying to craft an advanced postfix completion helper for vscode :
https://github.com/Denis-net/vscode-definitive-postfix
I wanted to activate my suggestions only when not inside comment blocks (tokens),
I tried regexs but I didn't manage to distinguish strings from comment or line comment to block comment etc.
( for example:
var x=5; // /*
x++;
// */
var aString = "//"; x++;

)
I discovered that I need a syntax analyzer/tokenizer and after a long search i came across this intresting project.
But I missed something important, because I can't make it working.
I read about tmLanguage and plist, I found them on vscode.env.appRoot/extensions/*/syntaxes and on
textmate repo.
In extension.ts.loadParser(:110) method I call the parseRawGrammar, then I store the result in my global singleton(SnippetCollector.Current) field.
In completionProvider.ts.isInsideComment(:46) method I tried to use the parser, but It raises an exception :

"parser.tokenizeLine is not a function"

so it didn't create the expected object.
Furthermore, in the loadGrammar.then()(extension.ts:137) the grammar arg is null, while inside the promise I can load a rawGrammar object.
Could you help me ?
Maybe you know what I'm doing wrong,
or if there is another way of doing it.
Thanks

Have you looked at the inspect.js script for an example?   Also, are you looking at the console.log for errors (or other relevant location)?
'tokenizeLine' from grammar.ts is a method from the 'Grammar' class, not a function.
I've never built anything using this repository, but I use the 'inspect.js' script to use this repository to help debug grammars.

Hey @msftrncs ! 😄👋
Many Thanks for your help !
I followed the readme.md on the main page, so :

I installed the module through npm install vscode-textmate
I called new vsctm.Registry (same code of the main page, the only diffrent things are grammarPaths and a breakpoint)
In the registry.loadgrammar(langId).then([...]) I store the grammar object (and I use the code for parsing multiple lines).

I went in debug so I placed breakpoints and I discovered this :
The parseRawGrammar method returns me this object (RawGrammar, I guess)

Calling c(rawGrammar) the corresponding loadGrammar.then is invoked,

but the resulting grammar is empty.
So I stored the rawGrammar, because is my only available instance, but using this Grammar object when I call the tokenizeLine method

the only error I get on debug.console is this

No other messages from the then or other parts.
Hope images will clarify the issue.
using npm I didn't know about inspect.js.
Is it possible that the npm version isn't working ?
So I need to download the repo and use it through (inspect.js)[https://github.com/Microsoft/vscode-textmate/blob/master/scripts/inspect.js] ?
I'll give it a try.
👍

Intresting :
I discovered that the code used in the main window is incorrect.
So I changed it based on what I understood from inspect.js and now my code is:

In Debug I can finally get a valid Grammar object, but when I try to call tokenizeLine method, now I get:

I don't know what looking for.
But I'm happy, because I got another error, that means: a little step forward ! 🎊🎉
Have you an idea about this dll ?

"Error: A dynamic link library (DLL) initialization routine failed.?\c:\Progetti\Visual Studio Code Extensions\vscode-definitive-postfix\node_modules\oniguruma\build\Release\onig_scanner.node at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:166:20) at

Have you compiled the Atom Node-Origuruma libraries?   These need to be compiled.  This should have been done as part of the dependencies of vscode-textmate.

I think so,
Sorry, I never did this things before (new to dependency Inception: dependency in dependency 😂😅), Still learning 💪🏻
The strange thing is npm view oniguruma version showed oniguruma v7.1.0 package installed (in npm_modules);
I tried to re-install oniguruma, through npm install oniguruma,
then I also tried to add all the dependencies in package.json (same of the vscode-textmate's package.json), but without luck...
I'll try to rebuild it, somehow 👍🏻.
Btw : will every vscode instance using the extension have to rebuild oniguruma package for being able to use it ?
Or I'll need to build 2(x64, x86) versions of the package and choose one of them at runtime ?

I tried to compile it but I had issues with node/electron environment (not understood well)...
anyway.
I found a compiled version in C:\Users\User\AppData\Local\Programs\Microsoft VS Code\resources\app\node_modules.asar.unpacked\oniguruma\build\Release
So I copied it into my folder and...
the good news is : It works ✨
the bad news is : don't work as I expected 😔
Using plist:

Using tmLanguage I can get more information:

But what I would really like to have are the built-in scope inspector's data :
With It i could understand exactly where I am (more specifically if user cursor is in a comment)
I think I had misunderstood the vscode-textmate plugin.
Or I didn't make it working ...
Anyway Thank you @msftrncs  for the great help !
For patching the doc (Readme.md) what can we do ?
Because isn't specified that developers need the Registry and that the addGrammar().then() will return the real Grammar object.
Not speaking about this oniguruma build dependency.
Or can i just close this issue for posterity ?

Ok, The best I can do is this:
I opened this pull request.
Hope this could help in fixing the Readme so other developers could save time.
Thanks again !


Open up a little the RegisteredServiceThemeResolver

For customisations.

Backported to the 6.6 branch: https://github.com/apereo/cas/pull/5823


Move lapack and libblas to the correct path

Lapack and libblas is not in the correct path for Numpy to find them.
See discussion here: https://forum.freecadweb.org/viewtopic.php?f=4&t=25942
This solution is borrowed from the Octave.yml Receipe.
https://github.com/AppImage/AppImages/blob/master/recipes/Octave.yml
Is this the preferred solution to this problem from AppImage perspective or do you recommend something else?

At the moment this is the best solution. Thanks.

Hey @probonopd,
On my native Trusty I have symlinks. I haven't been able to determine where they come from but I didn't crate them manually.  I don't understand how AppImage satisfies the dependencies, apt? Can the AppImage use trusty-updates.? I can force a newer version of numpy in the control file.
Should I make a pull request for the other 2 FreeCAD repos? I'm sure they could both benitit from this fix.
Thanks again for your interest in the FreeCAD project.

I don't understand how AppImage satisfies the dependencies, apt? Can the AppImage use trusty-updates?

Yes, just add them like
https://github.com/gntech/AppImages/blob/e0852f4dd4cbd65e09bf21b192c0481207480a2b/recipes/FreeCAD-nightly.yml#L7

In "sources" I get it.
Do you have any clue where the symlinks come from? I'm not saying AppImage can/should do this. Again on my native Trusty they were magically created. Is it just luck that some other package created the links?

Do you have any clue where the symlinks come from?

Which symlinks?

On my native Trusty system
I have
/usr/lib/liblapack.so.3 which is a symlink to
/etc/alternatives/liblapack.so.3 which is a symlink to
/usr/lib/lapack/liblapack.so.3
Similar links exist for libblas and the .gf versions that you experienced in the Qctave thread.
On Travis-Ci FreeCAD's selftests pass when importing numpy. So I assume these symlinks exist in the Travis environment. I haven't been able to determine when/how these symlinks are created and whether it is reasonable or not that AppImage should know about them.

The /etc/alternatives/ system is something suitable for Debian but not for inside an AppImage. So the proper cause of action is to move the libraries in place, as is done in this PR. Thank you.


make_cells method calls Cell.make without options.

Hi, We are using Asciidoctor-pdf to make raspberry-pi tech book.
When we use description list with horizontal block, it come with like this.

We would like to have like this.(with applying our change to make_cells method.)

Without our changes, we get this. (font is not applied)

Our use case needs customize description list style with applying font and font-style to cell, but it not works as we expected.
We found make_cells method calls Cell.make without options.

prawn-table-0.2.2/lib/prawn/table/cell.rb l.22 cell method make cell with options param.
cell = Table::Cell.make(self, options.delete(:content), options)
prawn-table-0.2.2/lib/prawn/table.rb l.528 make_cells method call make method without options param.
cell = Cell.make(@pdf, cell_data)

I'm not sure there are reason to call Cell.make without options, but if it options just dropped on make_cells method on table.rb, we wish to add options param to make method like below.
cell = Cell.make(@pdf, cell_data.delete(:content), cell_data)
thank you.

sorry, this one is prawn-table issue..
I'll close this.
thank you.


Display what user just clicked for filtering

it could be like this;

good call.

added highlighting - https://github.com/near-sighted/news-site/commit/fbc3d34f26bbb2e0c1c0368509973c0db49eac8b


docs(flutterfire_ui): fix readme link

typo in the link url
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[ ] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] The analyzer (melos run analyze) does not report any problems on my PR.
[ ] I read and followed the Flutter Style Guide.
[ ] I signed the CLA.
[ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change.
[ ] No, this is not a breaking change.

Hey @kleeb, you'll need to sign the CLA before we can merge this PR, please.

???

???

I think this message came because @russellwheatley added manually the cla: yes label.

let's merge it then

Woops, sorry for switching the label, I thought it was erroneously applied.


Added view to create related assignment and motion items. Updated ser…

…ializers. Fixes #1559.

See my comment in #1559

@ostcar This pull request was still in discussion (see my last comment also in #1559) and was not ready to merge! For future please look carefully.

@emanuelschuetze ok, lets try the revert button...
We should stop creating pull requests for branches we do not want to be merged. Any Idea how we can discuss core which is not a pull request?

We should stop creating pull requests for branches we do not want to be merged.

No, this was a real pull request from Norman. But before merge we have to note all comments! And my comment was not answered by Norman.

Any Idea how we can discuss core which is not a pull request?

For non-core code discussion we should wrote an explicit initial comment and title that this PR is not for merge.

@normanjaeckel Again: Let's discuss my comment in #1559


remove unused codes

看下有用么, 没用去掉了...

LGTM

Codecov Report

Merging #502 into master will decrease coverage by 0.95%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #502      +/-   ##
=========================================
- Coverage   42.86%   41.9%   -0.96%
=========================================
  Files          49      49
  Lines       12683   12683
=========================================
- Hits         5436    5315     -121
- Misses       5920    6040     +120
- Partials     1327    1328       +1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5816c58...554ea2a. Read the comment docs.

👍


Intermediate snapping points do not seem to be working on SlidingSheetDialog

When using more than 2 snapping points on SlidingSheetDialog, e.g [0.3, 0.7, 1], intermediate snapping is not working.

Hi! Thank you for your message. Can you please provide more detailed information that makes you think that intermediate snapping is not working?

When smoothly expanded and compressed, our widget can remain at any intermediate snap value, but in the case of a sudden scroll, as you can see in the attached GIF, the widget will expand to the values you specified (in this example, snappings are [0.3, 0.7, 1.0]).

However, the exception you've received seems to indicate that there may be issues with properly configuring our widget. Please recheck our example and ensure that your code is correct. Thank you for your watchfulness!


-fix(lib2): use Color classes instead of rgb int values for better readability

just a minor change to the rgb values as the int values are not that readable on first sight

outdated


TdLib GetChatMembers

I am trying to get the chat members for a given supergroup, and I was a bit confused about how the memberId is a MessageSender. This implies that it could be either a MessageSenderChat or a MessageSenderUser.
I checked the docs for ChatMember, and the explanation for this is as follows:

Identifier of the chat member. Currently, other chats can be only Left or Banned. Only supergroups and channels can have other chats as Left or Banned members and these chats must be supergroups or channels.

I have a few questions about this:

How can a chat be a member of another chat?
Why can we only see left or banned chats?
Does the use of the word 'currently' imply that in the future current members that are chats will be retrievable, an not just those that are past members?

How can a chat be a member of another chat?

If you ask for members with the filter chatMembersFilterBanned, then you definitely can receive chats in response.

Why can we only see left or banned chats?

There is no word "see" in the documentation. It states exactly that "Currently, other chats can be only Left or Banned. Only supergroups and channels can have other chats as Left or Banned members and these chats must be supergroups or channels."

Thanks for your quick response! To clarify, how can you actually ban a chat from a supergroup or channel? By the same token, how can a Telegram Chat be "left" from a supergroup/channel? Is it just if they have been blacklisted?
Also, due to the word "Currently" in the documentation, are there plans for you to be able to see current members who are chats in the future (if they can even be current members)?

Could you maybe provide an example of a chat being a member of another chat?

To clarify, how can you actually ban a chat from a supergroup or channel?
Could you maybe provide an example of a chat being a member of another chat?

You can use banChatMember to ban any channel in any supergroup if the user have the corresponding administrator right. Then it will be received in the list of banned members.


Question: why not update read models asynchronously?

For example, when we want to keep our read models in a different data storage than MySQL, we maybe want to update our read model outside of the request cycle that triggers the domain event(s). I might be incorrect but I think this is ultimately how CQRS should be implemented. What do you think?

As in 90% of the time... "It depends"
For scalability 100% async is the best way
For consistency... sync is easier.
Is up to you to balance and decide how it matches with your use cases.


Add unit tests for UniquePersonList and UniqueTagList classes #106

Fixes #106
The tests for UniqueTagList have been completed and are ready for review.
The tests for UniquePersonList are still work-in-progress.

@thenaesh Let's put this on hold till the AddressBookTest is merged. Once that one is complete, you'll be able to apply what you learned from that PR to this one (less review work for us :-p)


default hostname prevent testing though local network

If the default hostname is localhost, the server could be accessed through other ip address except <IP_ADDRESS> and localhost, which means the page can't be tested through local network.
We can't access the page though our phone on the same local network.

You can set custom hostname.


threshold tools application notebook for june working group

hi all,
created and added the notebook that i'll be walking through for the threshold tools application. let me know if you see any changes and improvements that could be made and thanks for reviewing!

A few things:

if you choose ssp 2-4.5 or ssp 5-8.5 you will end up with only one GCM, so you don't need to select just one simulation (or scenario) by name. you can just .squeeze() the DataArray to remove singleton dimensions
just noting that we do already have a card about unit conversion becoming a feature so you don't need to do it manually like this
you can set it to '˚C' with the unicode ˚
I don't think we need quite so many printouts at the end of cells for intermediate calculated quantities. That's something you'd just do while you were testing this. Ideally more of it moves to behind-the-scenes eventually, including getting the annual max series, which is an intermediate step.
when you move to the statewide version of this same thing, you don't need to initiate another new app = ck.Application. That's something we envision happening once at the top of each notebook.
make sure all of these specific choices have been tested in the official jhub in the current version of main. I was getting an error (which is fixed if PR#45 is ever merged), so that it did not work for subsetting Sacramento in the current version of main in the official jhub

@thenaomig -- made the changes requested!
still reviewing these two (if you have any comments/updates that would be great). thanks again!

if you choose ssp 2-4.5 or ssp 5-8.5 you will end up with only one GCM, so you don't need to select just one simulation (or scenario) by name. you can just .squeeze() the DataArray to remove singleton dimensions
make sure all of these specific choices have been tested in the official jhub in the current version of main. I was getting an error (which is fixed if PR#45 is ever merged), so that it did not work for subsetting Sacramento in the current version of main in the official jhub

@vicford -- made the changes requested!
also made some other updates to the notebook to further streamline. i think this should be good to go but let me know if there's any additional comments and if testing goes smoothly! @vicford @thenaomig


Can this lib convert the format audio m4a to mp3?

I have read the AKConverter file, but the format audio mp3 not be support? Could you help me to expand it?
These lines:
switch outputFormat {
case "m4a", "mp4":
format = .m4a
formatKey = kAudioFormatMPEG4AAC
case "aif":
format = .aiff
formatKey = kAudioFormatLinearPCM
case "caf":
format = .caf
formatKey = kAudioFormatLinearPCM
case "wav":
format = .wav
formatKey = kAudioFormatLinearPCM
default:
AKLog("Unsupported output format: (outputFormat)")
return
}

I could be wrong, but I think these are the supported ones because they are lossless whereas mp3 is lossy.


iron-router-compatible with Orion

Simple import.
Added simple fix that made iron:router crashing when added to Orion.

NOTE PR on current multiply:iron-router-progress haven't been accepted for months. Integrating this package is only a beginning. Some new animations are about to come. They will respect 1-div animation properties to ensure the lightest weight on mobile.

Many thanks again PEM

Nice work PEM

You're welcome. It was just a simple adaptation. I will complete it with different spinner animations: http://creativepure.meteor.com/recipes


Can't convert litematic

I tried to convert a 33 MB litematic and converter gives this error:
Error while converting terra.litematic: java.lang.OutOfMemoryError: Java heap space
I checked how much memory process took and its about 770 MB, instead of 4 gigs of ram that i have installed in pc.
Why is there this limitations?
And I checked that this litematic is not broken
fix please

Hello, sorry for the delayed response.
Litematic and schematic files are compressed files. Lite2Edit uncompresses the original file, converts it to a schematic in memory, and then compresses it back before writing to file.
The litematic you provided has an uncompressed size of 520 MB with over 430 million blocks. The default heap size Java allocates is not enough to convert this schematic. If you're on Windows you can open Command Prompt (likely called a Terminal in other OSes) and run java -Xmx3G -jar path/to/Lite2Edit.jar to allow Java to use up to 3 GB of RAM, which is enough to convert the litematic you provided.
Let me know if you need additional help.

thanks