Modifying a query column when fetching

I'm using knex-postgis to try and convert an encoded geometry table attribute to readable text. I'm trying to modify the query on the 'fetching' event, but it seems the modifications are ignored.
my code:
const bookshelf = require('./.database');
const st = require('knex-postgis')(bookshelf.knex);

const Events = bookshelf.Model.extend({
    initialize: function() {
        this.on('fetching', this._locationToText);
    },
    _locationToText: function(model, columns, options) {
        options.query.select('id', st.asText('location')).from(model);
        console.log(options.query.toString());
    }
})

This logs the expect query string to the terminal, but the fetch request still returns all attributes and the location attribute still encoded in the unreadable format. Is it possible to modify the SELECT part of the query? Am I doing something wrong?

@tayden-hakai you may want to check out #879

@tayden-hakai not sure if you ever got this working, but I tried the solution you posted and it worked for me. The only difference is that I didn't make _locationToText a separate function. Were you able to resolve?

I did abandon this temporarily, but I'll take a second look when I find some time. Thanks for the link

I honestly think the solution you provided is better than what's in the link. The solution in the link is complex and untested.

@jamesdixon I'm still having a hard time getting this to actually modify the query after hitting the fetching callback. My code looks like this:
initialize: function() {
    this.on('fetching', function(model, columns, options) {
      options.query.column(columns, st.asGeoJSON('location')).from(this.tableName);
      console.log (options.query.toString());

      return options.query;
    });
  }

And I get a nice SQL statement printed in the terminal, but the query seems to execute if the function was not even there. Are you returning anything from that callback? Perhaps it's something elsewhere in my code causing me problems

Some progress... I think it is something elsewhere in my code causing me problems

@tayden-hakai try adding this at the end of your initialize function:
return Bookshelf.Model.prototype.initialize.apply(this, arguments);

not having that was causing issues with other plugins, etc that override initialize()

I'll give that a shot. It looks like I was having issues because before my
fetchAll() call on the model, I had a query function that was also
modifying the SQL query. Playing around with that now and making progress.
Thanks for the help!
On Fri, Apr 22, 2016 at 1:46 PM, James Dixon<EMAIL_ADDRESS>wrote:

not having that was causing issues with other plugins, etc that override
initialize()
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/tgriesser/bookshelf/issues/1172#issuecomment-213583282

--
Taylor Denouden
<EMAIL_ADDRESS>

No problem! Good luck with it 👍

I actually just got this working in an even simpler way. Now doing:
  initialize: function() {
    this.on('fetching', function(model, columns, options) {
      if(columns[0] === `${this.tableName}.*` || columns.indexOf('location') >= 0) {
        columns.push(st.asGeoJSON('location'));
      }
    });

    return bookshelf.Model.prototype.initialize.apply(this, arguments);
  }

It just checks to see if the location should be returned as defined by what's in the columns parameter. If location should be returned, it just pushes st.asGeoJSON('location') to columns. Knex takes care of modifying the query after that.
Applying the initialize arguments should only be necessary if you're using some other library that also modifies the initialize function; as you stated before.

@tayden-hakai
This is very helpful as I'm trying to do the same thing.  Were you able to do the reverse ( st.geomFromGeoJSON() ) on saving?

@rogerschlachter I wasn't able to do the reverse, but didn't look into too much. I found that postgres could properly insert coordinates in EWKT format without having to do st.geomFromEWKT() first. So, in the end I just made sure I was only inserting EWKT formatted  geometry. There's probably room for improvement with this approach.

@tayden-hakai
Thanks for the quick response. I'll dig into that a little more.
This seems to work great on the table with the geometry field.  Now I need to figure out how to apply it when fetching it as related data.  I have the idea of a Site, which has many Areas.  An Area contains the geometry field. So right now if I fetch an Area, I see the geoJSON, but if I grab a Site with the related Areas, I don't get the geoJSON on those areas.

for what it's worth, I've been persisting geojson as geom postgres type by hooking into the 'saving' event:
this.on( 'saving', function ( model, columns, options ) {

            const geojson = model.get( 'geojson' );

            if ( typeof geojson === "object" ) {

                const lat   = geojson.coordinates[ 1 ],
                      lng   = geojson.coordinates[ 0 ],
                      point = St.geomFromText( `Point(${lng} ${lat})`, 4326 );
                model.set( pointColumn, point );
            }
} );

I think the last mentioned problem can be solved with parse & format. And as you do not know automatically which fields need to be parsed when fetching from and formatted when saving/updating to database, it is required to declare them in Model.
For example: I'm using MySQL 5.7 which supports JSON type. But mysql2 doesn't support it straight forward, It means it handles it as a string. So I have to parse/stringify the field every time I perform read/write operation.
For this I have made a Bookshelf plugin for myself:
'use strict';
var Promise = require('bluebird'),
    _ =    		require('lodash');

function parseJsonColumns(attrs) {
  if (attrs && this.jsonColumns) {
    this.jsonColumns.forEach(function(key) {
      if (_.isString(attrs[key])) {
        attrs[key] = JSON.parse(attrs[key]);
      }
    });
  }
  return attrs;
};

function formatJsonColumns(attrs) {
  if (attrs && this.jsonColumns) {
    this.jsonColumns.forEach(function(key) {
      if (_.isPlainObject(attrs[key])) {
        attrs[key] = JSON.stringify(attrs[key]);
      }
    });
  }
  return attrs;
};

module.exports = function(Bookshelf) {
  if (!Bookshelf) {
    throw new Error('Must pass an initialized bookshelf instance');
  }
  var ModelCtor = Bookshelf.Model;

  Bookshelf.Model = ModelCtor.extend({
    parse: function(attrs) {
      parseJsonColumns.apply(this, arguments);
      return ModelCtor.prototype.parse.apply(this, arguments);
    },
    format: function(attrs) {
      formatJsonColumns.apply(this, arguments);
      return ModelCtor.prototype.parse.format(this, arguments);
    }
  });
};

Then you shall declare jsonColumns on the model:
const Events = bookshelf.Model.extend({
    tableName: 'events',
    jsonColumns: ['someColumnName', 'otherColumnName']
})

So quick plugin refactoring for PostGIS:
'use strict';
const Promise = require('bluebird'),
      _ =    		require('lodash');

module.exports = function(Bookshelf) {
  if (!Bookshelf) {
    throw new Error('Must pass an initialized bookshelf instance');
  }
  const ModelCtor = Bookshelf.Model,
        st = Bookshelf.knex.postgis;

  function parseGISColumns(attrs) {
    if (attrs && this.GISColumns) {
      this.GISColumns.forEach(function(key) {
        if (_.isString(attrs[key])) {
          attrs[key] = JSON.parse(attrs[key])
        }
      })
    }
    return attrs
  }

  function formatGISColumns(attrs) {
    if (attrs && this.GISColumns) {
      this.GISColumns.forEach(function(key) {
        if (_.isPlainObject(attrs[key])) {
          attrs[key] = st.geomFromGeoJSON(attrs[key])
        }
      });
    }
    return attrs
  }

  Bookshelf.Model = ModelCtor.extend({
    initialize () {
      this.on('fetching', function (model, columns, options) {
        const gisColumns = _.intersection(this.GISColumns, columns)
        if (!_.isEmpty(gisColumns)) {
          gisColumns.forEach(function (column) {
						const index = columns.indexOf(column)
            columns.splice(index, 1, st.asGeoJSON(column))
          })
        } else if (_.includes(columns, `${this.tableName}.*`)) {
          columns.push.apply(columns, _this.GISColumns(st.asGeoJSON))
        }
      })
      return ModelCtor.prototype.parse.apply(this, arguments)
    }
    // Actually this may not be needed as returned value should already be in JSON format
    parse (attrs) {
      parseGISColumns.apply(this, arguments)
      return ModelCtor.prototype.parse.apply(this, arguments)
    }
    format (attrs) {
      formatGISColumns.apply(this, arguments)
      return ModelCtor.prototype.parse.format(this, arguments)
    }
  })
};

And use it jus by defining GISColumns:
const Events = bookshelf.Model.extend({
    tableName: 'events',
    gisColumns: ['location']
})


Add queryStakePoolDefaultVote state query

Description
Resolves #4663

Checklist

[x] Commit sequence broadly makes sense and commits have useful messages
[ ] New tests are added if needed and existing tests are updated
[x] All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
New section is never added with the code changes. (See RELEASING.md)
[x] When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
versioning process.
[ ] The version bounds in .cabal files for all affected packages are updated.
If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
[x] Code is formatted with fourmolu (use scripts/fourmolize.sh)
[x] Cabal files are formatted (use scripts/cabal-format.sh)
[x] hie.yaml has been updated (use scripts/gen-hie.sh)
[ ] Self-reviewed the diff

@Lucsanszky I've added one more commit that reduces duplication and reuses the same function in RATIFY rule as well as in the ledger state query.

Great addition, thanks!


v1.0 producer / log source compatibility

OCSF is a framework where the base event classes should produce the same outcome for an event regardless of the vendor generating that event. To that end, "supporting" log sources means ensuring that multiple producers confirm that the schema is robust and flexible enough to accommodate the data they produce / report on.
For example, if product A and product B both send process_activity logs, the end result after conversion to OCSF should look structurally the same, with the exception of optional attributes and any producer / vendor specific fields and objects which would be supported via an extension.
This issue aims to track the requirement for v1.0 that a minimum of 2 vendors or producers have confirmed that their data / logs can be converted into OCSF format, and as a secondary objective to confirm that two producers converting the same event data to OCSF format yield the same result.

OCSF Class
Producer / Log
Maintainers / Verifiers
Notes / Status

File Activity [1000]
- [ ] DTEX (jp-harvey)- [ ] Tanium
DTEX, Splunk

File Access Check [1001]

DTEX, Splunk

Folder Activity [1002]
- [ ] DTEX (jp-harvey)- [ ] Tanium
DTEX, Splunk

Kernel Activity [1003]

DTEX, Splunk

Memory Activity [1004]

DTEX, Splunk

Module Activity [1005]

DTEX, Splunk

Peripheral Activity [1006]
- [ ] DTEX (jp-harvey)
DTEX, Splunk

Process Activity [1007]
- [ ] DTEX (jp-harvey)- [ ] Tanium- [ ] Crowdstrike
DTEX, Splunk

Registry Key Activity [1008]
- [ ] DTEX (jp-harvey)- [ ] Tanium
DTEX, Splunk

Registry Value Activity [1009]
- [ ] DTEX (jp-harvey)- [ ] Tanium
DTEX, Splunk

Resource Activity [1010]

DTEX, Splunk

Scheduled Job Activity [1011]

DTEX, Splunk

Security Finding [2001]
- [ ] AWS- [ ] IBM- [ ] DTEX (jp-harvey)- [ ] Tanium
AWS, IBM

Account Change [3001]
- [ ] Sumo Logic
Sumo Logic

Authentication [3002]
- [ ] Sumo Logic
Sumo Logic

Authorization [3003]
- [ ] Sumo Logic
Sumo Logic

Entity Management Audit [3004]
- [ ] Sumo Logic
Sumo Logic

Network Activity [4001]
- [ ] Splunk - [ ] IronNet - [ ] IBM - [ ] DTEX (jp-harvey)- [ ] Tanium
Splunk, IronNet

HTTP Activity [4002]
- [ ] IronNet - [ ] DTEX (jp-harvey)- [ ] Tanium

DNS Activity [4003]
- [ ] IronNet
Splunk, IronNet

DHCP Activity [4004]
- [ ] IronNet
Splunk, IronNet

RDP Activity [4005]
- [ ] IronNet
Splunk, IronNet

SMB Activity [4006]
- [ ] IronNet
Splunk, IronNet

SSH Activity [4007]
- [ ] IronNet
Splunk, IronNet

FTP Activity [4008]
- [ ] IronNet
Splunk, IronNet

Cloud API [5001]
- [ ] AWS
IronNet, AWS

Cloud Storage Activity [5002]
- [ ] AWS - [ ] IronNet
IronNet, AWS

Cloud Virtual Machine [5003]
- [ ] AWS - [ ] IronNet
IronNet, AWS

Container Lifecycle Activity [6001]
- [ ] Trend Micro - [ ] IBM - [ ] AWS
Trend Micro

Database Lifecycle (example) [7000]
- [ ] IBM
IBM

Application Lifecycle (example) [8000]

Device Inventory Info [9001]
- [ ] DTEX (jp-harvey)- [ ] Tanium
Tanium

Device Config State [9002]
- [ ] Tanium
Tanium

I believe this leads to documentation and the greater question, "what does supported mean" and what does that look like.

Following discussion last week in the group call and again today, "supported log sources" is probably better described as "logs that can be supported by OCSF". @pagbabian-splunk put it well when he described OCSF as a schema that will yield the same result when logs from different products that do the same thing are converted to OCSF format. Or more precisely, that the core OCSF fields will look the same, and any differences are vendor specific and supported through an extension.
To that end, it was discussed that one approach to defining what needs to be supported for v1.0 would be to have a list of all the classes, and x (2-3?) vendors for each class certify that OCSF can accommodate their logs. I will update the title and description of this issue to reflect a list based on what was discussed, and put some vendor names in to start kick things off - either DTEX or something I know another vendor does or is working on - and we can iterate on the list.

Suggest this be matrix expanded to include

Specific product
Ingest vs Produce
Some way to specify feature/function area in the product.

Some vendors have a lot of products and will have various different aspects of OCSF support across their portfolio at different points in time, and some products even both produce and consume data and may support subsets of one but not the other at any point in time.

@JasonKeirstead - Agree those are good points and we have representation from several orgs with prioritized support lists. I'd suggest that each vendor themselves can self-select and list where they'd like to start.
Follow on question - do we want to set a goal for number of distinct log sources as confirmation of an event class's v1.0 eligibility?

@JasonKeirstead yes definitely. Because GH is a fixed width adding a lot of columns will be troublesome, it would be better done in some other collab tool, but the plan is, once we have a bit more data, to create individual issues to track each one which can have the details, and link to those issues from this table.

Also @JasonKeirstead you make a good point about ingest vs produce. My assumption was that for v1 we'd focus on producers, since producers primarily determine many of the details of the schema which is the point we're at (the main structure is done). Do you think we need to certify / verify ingest as well for v1?

@jp-harvey I don't know, but there are several OCSF members who are likely focusing primarily on consume use case right now - us for example and I have to presume Splunk... arguably AWS...

Coming in late on this one but consumers like Splunk are also Mappers, which is closer to Producers.  Both Producer and Mapper personae populate the classes and structure.  Analyst personae SHOULD be able to make sense out of the populated classes.


Build.cmd script accepts /m:x parameter and passes it to MSBuild but it is ignored when submodules are build

Testing recent source-build on Windows I have encountered problem of excessive spawning of MSVC cl instances during coreclr repo build. On my 4 core / 8 thread laptop it leads to memory consumption of up to 14 GB - for details see https://github.com/dotnet/coreclr/issues/14406.
Passing /m:x parameter to build script has no effect on submodules and seems to be ignored.

@eerhardt Do you think we need another parameter in the repo api to pass the /m:x parameter to submodule builds?

@dleeapho @eerhardt  imho it would be very useful to have 2 additional parameters: maxcpucount (m), and BuildInParallel - where both could be applied individually to every repo and globally. This would solve 14 GB memory usage in coreclr issue as passing BuildInParallel=false should switch off MSBuild parallelism but leave CL parallelism on (I am not sure about the second action but it would be handy to have such granularity of control over build of more than dozen repos).

I definitely think it is worth having some means of passing this type of information to the repo's, or if not pass it ensure the repo's have a reasonable setting when building in the larger source-build system. For this particular issue it seems like we need to solve it even for the individual repo build so perhaps it isn't something unique to source-build.

This area is likely to change with ProdCon/source-build sync.


Upgrade Ruby to 2.5.0

Context
This PR upgrades Ruby from version 2.4.2 to 2.5.0.

No changes in gemfile.lock?

No changes.

Does this mean people using the gem will need to be on this ruby version?

It does @gidsg.

Or higher.

I don't think that is true actually. The gemspec sets the "rules" for dependancy versions. .ruby-version only sets the ruby version via rvm etc in development

Actually, yes, you're right Dan.


Fixes an issue with doctrine/dbal and that the uuid package changed name

Oh, and if you merge this, please release a new tag.

Thanks ;)


[Snyk] Upgrade workbox-strategies from 6.5.4 to 6.6.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade workbox-strategies from 6.5.4 to 6.6.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released a month ago, on 2023-05-26.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Codecov Report
Patch and project coverage have no change.

Comparison is base (654ddd0) 81.53% compared to head (16c6c06) 81.53%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #723   +/-   ##
=======================================
  Coverage   81.53%   81.53%
=======================================
  Files          31       31
  Lines         352      352
  Branches       45       45
=======================================
  Hits          287      287
  Misses         60       60
  Partials        5        5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Swift 2 and Xcode 7 GM fixes

Did what I could to get ExSwift working with latest Xcode 7 GM.

This is a very important patch and should be merged asap. Now that we are on XCode 7 we can no longer compile our projects that use ExSwift. Please merge as soon as you can!

+1 for merging this asap

+1

+1

Here is an alternate project I am maintaining if others want to give it a try https://github.com/ankurp/Dollar.swift/tree/master/Cent
I am adding more extensions to this project and also keeping the library up to date with all versions of Xcode and Swift.

+1

when can this be done?

@ayn the tests are still failing for Swift 2.0 :(

still not merge?

@xinwo @xinwo
You can switch to his branch in the interim: https://github.com/ayn/ExSwift/tree/Swift-2.0

Is this project no longer maintained?

@goktugyil There were a lot of changes in Swift 2.0, so It could be that it's not or creator just took small vacation :)

The last contribution was in June 8. Thats more than 4 months.

@ankurp Dollar/Cent is a nice library. Thanks!:)

https://github.com/goktugyil/EZSwiftExtensions check this out

Sad to see that this project no longer maintained..  We just want to merge this pull request! Transfer ownership if you no longe maintain the project!


[gitignore] add default build dir of vs code to ignore list

blocked by #13722.

blocked by #13765.

/azp run

/azp run

/azp run


Step Functions - Send emails in parallel threads

Use map to send emails

Are the executions in map concurrent?
Yes, by default there is unlimited concurrency to the executions.
As per documentation

The default value is 0, which places no quota on parallelism and iterations are invoked as concurrently as possible.

This can limited using MaxConcurrency field configuration
https://docs.aws.amazon.com/step-functions/latest/dg/amazon-states-language-map-state.html

Are you trying to invoke 10 lambdas at a time to process 10 messages @arunmr1980 ?

That is the default behavior of step function loops. It spin off as many lambda invocations as there are elements in the list. This behavior can be controlled by MaxConcurrency field. Say if we set that to 5, it will process 10 messages in 5 invocations, so each lambda function will process 2 messages.
This is how lambda handles multiple events. From the doc

When a function is first invoked, the Lambda service creates an instance of the function and runs the handler method to process the event. After completion, the function remains available for a period of time to process subsequent events. If other events arrive while the function is busy, Lambda creates more instances of the function to handle these requests concurrently.

https://docs.aws.amazon.com/lambda/latest/operatorguide/scaling-concurrency.html

No, this will defeat the purpose of batch processing. What I meant by parallelization was, from python itself we can call aws send mail in separate thread instead of directly calling it inside for loop. From one lambda only that should be possible to do asynchronous API calls.

I suppose you are looking for multithreaded code. This can be done in python. Here are the pros and cons of that approach.
Pros

Single lambda invocation. Relatively less billing time of lambda.
Multiple threads process email in parallel. Reading messages and processing in single CloudWatch log.
Simpler orchestration in step functions

Cons

More resources may be required for lambda to support concurrent threads. So the cost of billed seconds may be more.
More complex code implementation.
Manual optimization may be needed for scaling. This may not be a concern as we are only processing 10 messages in one go.

Since the actual email sending code is pretty simple and not resource intensive, I think the multithreaded approach will work as good.


Add ability to get node properties

fixes #22

Just fyi I have a fix for the split partial classes ready too if you wan't to wait for that


When the first release?

There are schedule in this respect it?

There is no scheduled release date at this point. The framework is still undergoing additions/improvements and there are no user features at this point either, although you can already start using in some specific scenarios if you want to build upon the framework aspect of Orchard.
I suggest following the website for updates about Orchard 2, we've started making Orchard 2 a recurring part of the weekly meetings to announce updates and new features.
I'm closing this as it's not an issue. If you have questions, please visit the forums or chat on Gitter.


What am i doing wrong?

I am trying to run the lane detection conde simulation but I can't get it to work? Do you know what I am doing wrong? I am running it on Ros melodic and Ubuntu 18.04 on a vm.

It's looking for the ouster_description package. get that here:
https://github.com/wilselby/ouster_example/tree/master/ouster_description

I am trying to clone this package https://github.com/wilselby/diy_driverless_car_ROS.git and build the package but I am unable to do so which says unable to find two different packages named  yocs_cmd_vel_mux and ecl_exceptions. . Please help me the best way to clone this package with all the required dependencies.

Clone these if they aren't in the apt-repo
https://github.com/yujinrobot/yujin_ocs/tree/devel/yocs_cmd_vel_mux
https://github.com/stonier/ecl_core/tree/devel/ecl_exceptions

I have cloned these two packages as well but after cloning these packages I am unable to build the packages. It shows an error "Packages with unknown build type exists. Can not build workspace with packages of unknown build_type
" .Please let me know if I am missing something while cloning all these packages.

running this code $ python rosbag_to_csv.py -o output/walker/ -i data/walker/ is giving me ERROR: ['/racecar/ackermann_cmd_mux/output', '/img_node/intensity_image']
Can you tell me where am I going wrong?

While running drive_model.py node on python 2.7 it throws an error of " Require Tensorflow 2.2 or greater".  For Tensorflow 2.2 it requires python 3 but python 3 does not support ROS.
What can be done in this case?

running this code $ python rosbag_to_csv.py -o output/walker/ -i data/walker/ is giving me ERROR: ['/racecar/ackermann_cmd_mux/output', '/img_node/intensity_image']
Can you tell me where am I going wrong?

Any solution for this? I am getting the same error.

Does the ROS .bag file have those topics in it?

When I use rosbag info, i get this info

It looks like there is no topic '/img_node/intensity_image'. Also, when I see the rostopic list, there is no such topic there.
Should I change the topic to ' /openmv_cam/image/raw ' in bagutils.py file? or is there any other way?

Can you post the output when you change the camera topic to the ' /openmv_cam/image/raw ' topic? It's also odd it complained about the '/racecar/ackermann_cmd_mux/output' topic since that looks like it's in your bag. Is the bag file in the right directory of the command line argument?

The problem is solved. The solution is to change the topics in bagutils.py files and the path is given. I changed that path to an absolute path and it worked. I don't know but the relative path was not working.


Feature Request - DVD mode - A flag to dump a specified range of sectors rather than the entire disc

Is your feature request related to a problem? Please describe.
Currently, DIC provides no means of dumping a specified range of sectors for DVD (and normal CD) mode. This is a bit inconvenient as some discs we have can only be read partially in a given drive, but we'd like to just focus on dumping a specific range of sectors from the disc to retry over and over. Otherwise, DIC would have to dump the entire disc again from the beginning in order to get to the region we want to dump. Not only does it take a longer amount of time, the disc could experience errors that cause the drive to slow to a crawl making seeking to the desired range more frustrating.
Having this feature would be immensely useful for disc and data integrity analysis.
Describe the solution you'd like
I would like DIC to have a parameter for DVD mode, or maybe all modes in general since Data mode is the only mode currently able to support this, so that I can specify a range of LBAs for it to dump. I should be able to have all the parameters accessible for that given mode. Maybe something like /ra (for 'range') StartLBA EndLBA? For example:
I want to dump LBA range 123 to 175, so I run...
DiscImageCreator dvd E disc.iso 24 /ra 123 175
The resulting disc.iso should only have the user mode sectors from 123 to 175.

DiscImageCreator_test.zip

added: /ra for dvd

Works, thank you! :) I checked the dump and it hit the start and end LBA on the nose.
It doesn't work in raw mode, DIC just dumps the disc like normal from the start of the disc. Can it work in raw mode too?
Is there anything that would prevent /ra to be used for any mode (CD, Xbox, etc)?

DiscImageCreator_test.zip

added: /ra for xbox and dvd /raw (NOT TEST)

CD

Use audio or data.

DiscImageCreator_test.zip

added: /ra for xbox and dvd /raw (NOT TEST)

CD

Use audio or data.

/raw doesn't work, it keeps expecting the first PSN (30000) but the drive wants to return another sector it seems:
I have a .bat file to dump individual sectors off the disc into separate files with added numbers on them. The bat file works when reading the disc normally, but raw mode seems broke for sure. I'm not able to read anything.

DiscImageCreator.exe dvd D 1908000-!counter!.iso 24 /ra 1908000 1908001 /q /ps 0x00 /rr 10 /raw
DiscImageCreator.exe dvd D 1908001-!counter!.iso 24 /ra 1908001 1908002 /q /ps 0x00 /rr 10 /raw
DiscImageCreator.exe dvd D 1908002-!counter!.iso 24 /ra 1908002 1908003 /q /ps 0x00 /rr 10 /raw
AppVersion
32 bit, AnsiBuild, 20230520T145823
CurrentDirectory
H:\Tools\DiscImageCreator\test2
WorkingPath
Argument: 1908000-1.iso
FullPath: H:\Tools\DiscImageCreator\test2\1908000-1.iso
Drive: H:
Directory: \Tools\DiscImageCreator\test2
Filename: 1908000-1
Extension: .iso
StartTime: 2023-05-20T02:16:39-0400
Set the drive speed: 0KB/sec
DiskSize of [H:\Tools\DiscImageCreator\test2]
Total:<PHONE_NUMBER>224 bytes
Used:<PHONE_NUMBER>792 bytes
---------------------------
Space:<PHONE_NUMBER>2 bytes
=> There is enough disk space for dumping
Rawdump command [0]:0x3c [1]:0x02 [2]:0000
LBA[1908000, 0x1d1d20]: [F:ReadDVDRaw][L:936]
Opcode: 0xa8
ScsiStatus: 0x02 = CHECK_CONDITION
SenseData Key-Asc-Ascq: 03-02-80 = MEDIUM_ERROR - VENDOR UNIQUE ERROR
Read retry from 1908000 (Pass 1/10)
Expected sector num:  30000, Got sector num: 201d20 [0/1][0/1] Reread 2. LBA: 1908000
Creating raw(LBA) 1908001/1908001
EndTime: 2023-05-20T02:17:09-0400
AppVersion
32 bit, AnsiBuild, 20230520T145823
CurrentDirectory
H:\Tools\DiscImageCreator\test2
WorkingPath
Argument: 1908001-1.iso
FullPath: H:\Tools\DiscImageCreator\test2\1908001-1.iso
Drive: H:
Directory: \Tools\DiscImageCreator\test2
Filename: 1908001-1
Extension: .iso
StartTime: 2023-05-20T02:17:09-0400
Set the drive speed: 0KB/sec
DiskSize of [H:\Tools\DiscImageCreator\test2]
Total:<PHONE_NUMBER>224 bytes
Used:<PHONE_NUMBER>768 bytes
---------------------------
Space:<PHONE_NUMBER>6 bytes
=> There is enough disk space for dumping
Rawdump command [0]:0x3c [1]:0x02 [2]:0000
LBA[1908001, 0x1d1d21]: [F:ReadDVDRaw][L:936]
Opcode: 0xa8
ScsiStatus: 0x02 = CHECK_CONDITION
SenseData Key-Asc-Ascq: 03-02-80 = MEDIUM_ERROR - VENDOR UNIQUE ERROR
Read retry from 1908001 (Pass 1/10)
LBA[1908001, 0x1d1d21]: [F:ReadDVDRaw][L:936]
Opcode: 0xa8
ScsiStatus: 0x02 = CHECK_CONDITION
SenseData Key-Asc-Ascq: 03-02-80 = MEDIUM_ERROR - VENDOR UNIQUE ERROR
Read retry from 1908001 (Pass 2/10)
LBA[1908001, 0x1d1d21]: [F:ReadDVDRaw][L:936]
Opcode: 0xa8
ScsiStatus: 0x02 = CHECK_CONDITION
SenseData Key-Asc-Ascq: 03-02-80 = MEDIUM_ERROR - VENDOR UNIQUE ERROR
Read retry from 1908001 (Pass 3/10)
LBA[1908001, 0x1d1d21]: [F:ReadDVDRaw][L:936]
Opcode: 0xa8
ScsiStatus: 0x02 = CHECK_CONDITION
SenseData Key-Asc-Ascq: 03-02-80 = MEDIUM_ERROR - VENDOR UNIQUE ERROR
Read retry from 1908001 (Pass 4/10)
LBA[1908001, 0x1d1d21]: [F:ReadDVDRaw][L:936]
Opcode: 0xa8
ScsiStatus: 0x02 = CHECK_CONDITION
SenseData Key-Asc-Ascq: 03-02-80 = MEDIUM_ERROR - VENDOR UNIQUE ERROR
Read retry from 1908001 (Pass 5/10)
LBA[1908001, 0x1d1d21]: [F:ReadDVDRaw][L:936]
Opcode: 0xa8
ScsiStatus: 0x02 = CHECK_CONDITION
SenseData Key-Asc-Ascq: 03-02-80 = MEDIUM_ERROR - VENDOR UNIQUE ERROR
Read retry from 1908001 (Pass 6/10)
LBA[1908001, 0x1d1d21]: [F:ReadDVDRaw][L:936]
Opcode: 0xa8
ScsiStatus: 0x02 = CHECK_CONDITION
SenseData Key-Asc-Ascq: 03-02-80 = MEDIUM_ERROR - VENDOR UNIQUE ERROR
Read retry from 1908001 (Pass 7/10)
LBA[1908001, 0x1d1d21]: [F:ReadDVDRaw][L:936]
Opcode: 0xa8
ScsiStatus: 0x02 = CHECK_CONDITION
SenseData Key-Asc-Ascq: 03-02-80 = MEDIUM_ERROR - VENDOR UNIQUE ERROR
Read retry from 1908001 (Pass 8/10)
Expected sector num:  30000, Got sector num: 201d20 [0/1][0/1] Reread 9. LBA: 1908001
Creating raw(LBA) 1908002/1908002
EndTime: 2023-05-20T02:20:59-0400
AppVersion
32 bit, AnsiBuild, 20230520T145823
CurrentDirectory
H:\Tools\DiscImageCreator\test2
WorkingPath
Argument: 1908002-1.iso
FullPath: H:\Tools\DiscImageCreator\test2\1908002-1.iso
Drive: H:
Directory: \Tools\DiscImageCreator\test2
Filename: 1908002-1
Extension: .iso
StartTime: 2023-05-20T02:20:59-0400
Set the drive speed: 0KB/sec
DiskSize of [H:\Tools\DiscImageCreator\test2]
Total:<PHONE_NUMBER>224 bytes
Used:<PHONE_NUMBER>000 bytes
---------------------------
Space:<PHONE_NUMBER>4 bytes
=> There is enough disk space for dumping
Rawdump command [0]:0x3c [1]:0x02 [2]:0000
LBA[1908002, 0x1d1d22]: [F:ReadDVDRaw][L:936]
Opcode: 0xa8
ScsiStatus: 0x02 = CHECK_CONDITION
SenseData Key-Asc-Ascq: 03-02-80 = MEDIUM_ERROR - VENDOR UNIQUE ERROR
Read retry from 1908002 (Pass 1/10)
LBA[1908002, 0x1d1d22]: [F:ReadDVDRaw][L:936]
Opcode: 0xa8
ScsiStatus: 0x02 = CHECK_CONDITION
SenseData Key-Asc-Ascq: 03-02-80 = MEDIUM_ERROR - VENDOR UNIQUE ERROR
Read retry from 1908002 (Pass 2/10)
LBA[1908002, 0x1d1d22]: [F:ReadDVDRaw][L:936]
Opcode: 0xa8
ScsiStatus: 0x02 = CHECK_CONDITION
SenseData Key-Asc-Ascq: 03-02-80 = MEDIUM_ERROR - VENDOR UNIQUE ERROR
Read retry from 1908002 (Pass 3/10)
Expected sector num:  30000, Got sector num: 201d20 [0/1][0/1] Reread 4. LBA: 1908002
Creating raw(LBA) 1908003/1908003
EndTime: 2023-05-20T02:22:28-0400

One thing I just thought of.
DIC doesn't need to access the TOC or the directory structure, etc when /ra is used right? It seems a bit successive. Depending on the quality of the disc, for instance a disc where the TOC or lba 0 is damaged, it'll make DIC either error out completely before it even reads the specified range or at best takes a long time to just read that range.
Can you make it so DIC doesn't have to do as much before it gets right into dumping the range? If you think about it, since you're looking at just the range you don't really need to get the data for the disc or vol logs. So getting rid of those as well as the data fetch for those logs when /ra is used would be beneficial. DMI and PFI files also don't necessarily need to be generated.
We're currently trying to read sectors off a disc that has this issue with the TOC, around the beginning. The sector ranges we want to read are fine, but DIC will end if it encounters errors before it dumps anything.

/raw doesn't work

Fixed it.
DiscImageCreator_test.zip

One thing I just thought of.

These are needed reading sectors. Not all files, but I don't filter it.

/raw doesn't work

Fixed it.
DiscImageCreator_test.zip

One thing I just thought of.

These are needed reading sectors. Not all files, but I don't filter it.

Works :). Xbox as well. Feel free to merge.


Fix nonzero warning

[Fix]: Fix warning of deprecated usages of nonzero during training with pytorch 1.6 (#320 )

fix warning caused by upgrade of pytorch by specifying as_tuple=Fasle

Hi @wHao-Wu！First of all, we want to express our gratitude for your significant PR in the MMDetection3D project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/raweFPmdzG
If you are Chinese or have WeChat，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution❤ @wHao-Wu


Remove Travis CI build badge

Remove Travis CI build badge because this project is not built on there anymore.

Thanks for the PR, @akirataguchi115!


Allow customisation of image inline setting

Hi,
It would be great if this library allowed users to set the inline setting for the images extension. This is required if you want to allow images to be made linkable. From what i can see there is no way to set this currently.
https://tiptap.dev/api/nodes/image

Need this.

Hey @manogi,
I'm preparing a PR for this issue, but I encounters troubles to install local dependencies because of FontAwesomePro.
Can I PR the updated sources? You'll only have to compile them.
Thanks

Yes, we can try this

IMO images should always be embed as inline. Do you agree or would you prefer a new imageSettings.inline option?
Thanks

It will take me a bit longer to answer this - I am currently not actively using Nova (or TipTap) and will have to re-install my testing environment for it.

Any updates on this ?
I will open a PR if needed

Hey, I changed the rich text editor I'm using for creditor 4. I'll share what I already have.

Hey @alexgilbertDG, I have this https://github.com/shaffe-fr/nova-tiptap/tree/inline-image

@manogi  Any update about this issue....


Subs for text using dub

Love the app, is there a way to have subtitles for on screen text while using dub. Like English subs for Japanese text on screen.
Thanks

use source 3/4, select sub language and enable use dub stream

I don't have source 3/4

Go to sidebar and select source (HiAnime or AnimeWatch), or just update to latest nightly 5.2.6


eslint.codeActionsOnSave.rules not working with "editor.formatOnSave": true for ts and tsx files

Bug Report

This issue occurs only when .eslintrc.json extends plugin:@typescript-eslint/recommended.
🔎 Search Terms

eslint.codeActionsOnSave.rules
related issue: 1431
🕗 Version & Regression Information

VSCode: 1.66.1
dbaeumer.vscode-eslint: 2.2.3 (pre-release)
Node.js: 16.13.0
eslint: 8.13.0
@typescript-eslint/parser: 5.18.0
@typescript-eslint/eslint-plugin: 5.18.0

💻 code
test.ts
var test = 2

.vscode/settings.json
{
  "[typescript]": {
    "editor.defaultFormatter": "dbaeumer.vscode-eslint",
  },
  "[typescriptreact]": {
    "editor.defaultFormatter": "dbaeumer.vscode-eslint",
  },
  "editor.formatOnSave": true,
  "editor.formatOnPaste": false,
  "editor.formatOnType": false,
  "editor.codeActionsOnSave": {
    "source.fixAll.eslint": true,
  },
  "eslint.format.enable": true,
  "eslint.useESLintClass": true,
  "eslint.codeActionsOnSave.rules": [
    "*semi*",
  ],
}

.eslintrc.json
{
  "env": {
    "browser": true,
    "es2021": true,
    "node": true
  },
  "extends": [
    "eslint:recommended",
    "plugin:@typescript-eslint/recommended"
  ],
  "parser": "@typescript-eslint/parser",
  "parserOptions": {
    "ecmaFeatures": {
      "jsx": true
    },
    "ecmaVersion": "latest",
    "sourceType": "module"
  },
  "plugins": [
    "@typescript-eslint"
  ],
  "rules": {
    "semi-style": 2,
    "semi-spacing": 2,
    "semi": 2
  }
}

🙁 Actual behavior
On save, the test.ts gets formatted:
const test = 2;

🙂 Expected behavior
On save, the test.ts gets formatted:
var test = 2;

(because I declared to opt-in only *semi* rules in eslint.codeActionsOnSave.rules)

You also need to enable ESLint as a formatter using eslint.format.enable

@dbaeumer In my .vscode/settings.json, eslint.format.enable has always been true, yet it hasn't properly worked.

I am also having this issue. @cdpark0530 did you ever get this resolved or is this still occurring?

@samlythemanly Without formatOnSave, yes I found a solution satisfying at least to me.

@cdpark0530 could you please provide me with a GitHub repository I can clone that demos that. That ensure that we are using the exact same setup.

This issue has been closed because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Small Typo: "to do" should be "to"

https://github.com/CEVE-421-521/lab-02/blob/6b413cda102f0ee5a464898426383fd749ec5356/index.qmd#L332
"use the @select function to do select the columns we want" should be "use the @select function to select the columns we want"

Pull request is visible in the Lab 2 repository along with an issue identical to this one that I made in that repository.  It took me a minute to figure out how the separate repositories for labs thing works.

Great work

Thank you!
On Thu, Jan 25, 2024 at 10:47 James Doss-Gollin @.***>
wrote:

Great work
—
Reply to this email directly, view it on GitHub
https://urldefense.com/v3/__https://github.com/CEVE-421-521/ceve-421-521.github.io/issues/1*issuecomment-1910595054__;Iw!!BuQPrrmRaQ!iSwBOJLMrxszqAIkkc7JNZPm6g_LKkuph7BA5MUA2lRym921SZjwmFe85YYZ-HlP73OUN_dC4DXTgqfF2KRit66I0k3ydSJu$,
or unsubscribe
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/BFIC234EKCR4DZ32O6CW2VDYQKEDFAVCNFSM6AAAAABCDSAIF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJQGU4TKMBVGQ__;!!BuQPrrmRaQ!iSwBOJLMrxszqAIkkc7JNZPm6g_LKkuph7BA5MUA2lRym921SZjwmFe85YYZ-HlP73OUN_dC4DXTgqfF2KRit66I0i2qnMRL$
.
You are receiving this because you authored the thread.Message ID:
@.***>


Add databases arg to ExportRDSSnapshotToLocation function

Change Overview
This PR adds support to take backup of specific dbs using ExportRDSSnapshotToLocation function
Pull request type
Please check the type of change your PR introduces:

[ ] :construction: Work in Progress
[ ] :rainbow: Refactoring (no functional changes, no api changes)
[ ] :hamster: Trivial/Minor
[ ] :bug: Bugfix
[ ] :sunflower: Feature
[ ] :world_map: Documentation
[ ] :robot: Test

Issues

#XXX

Test Plan

[x] :muscle: Manual
[ ] :zap: Unit test
[x] :green_heart: E2E

Test cases

Sr.
Test case
Expected
Result

1.
databases arg not set
Takes backup of all the databases
PASS

2.
databases arg set with valid database list
Only specific databases are restored
PASS

3.
databases arg set with invalid database list
Backup fails
PASS


New Mitsuba Loader

Need to support names on Elements that are not tied to elements (there's both an id and name attribute).


Feature requests:

Thank you for this excellent tool! It makes a huge difference in how I'm able to use display entities.
I have some feature suggestions:
-Mirror selection
-Pick save name and save location (currently saves under a generic name in my downloads)
-Don't include non-block entities (like beds, signs and item frames) since they don't render, or allow them to render
-Undo/redo or some sort (please)

Thank you for your suggestions!
I tried to address most of your suggestions in an upcoming version I'm releasing this weekend:

There's no easy way to mirror block display entities in Minecraft. The most obvious solution would be to just set the scale to a negative value along a selected axis, but unfortunately that doesn't work in-game, as it doesn't render properly.  But I'm thinking about a workaround.
Now you can name your project, and the downloaded file will have the same name.
The editor will now alert the user if it can't load a block model. I will try to come up with a better solution.
Added Undo / Redo functionality.

I created a separate repo for Block Display Studio. Future issues and suggestions should go there.
https://github.com/eszesbalint/bdstudio


Upgrade protobuf-java to 0.48.2

To include a recursion fix: https://github.com/protocolbuffers/protobuf/commit/ac9fb5b4c71b0dd80985b27684e265d1f03abf46

@davidjgoss just curious - was this in response to an issue that you ran into, or was this something that you just noticed and pushed? What was the issue?


Date Format for creation

Hey,
really appreciate the Bot so far, a little feature would make it a lot more usable for me:
Choose your Date Format, since I'm from Germany I would write 04.05.2020 for today but the bot needs 05.04.2020 which is quite confusing

Text processing for adding events is done entirely through Google Calendar, and it seems to do datetime in YYYY-MM-DD-"T"HH:MM:SS, the format defined by ISO8601


R45: Monitor Window: Monitor window shall have selection icons for Install Notes, Release Notes, and Help Files

Tools: JQuery

Glyphicons no longer needed for install notes, release notes and help files. Will keep it as simply links at the top nav bar.

Completed.
SQA


Create real-time patient-flow optimization system.py

This program uses simplified models for patient arrivals, resource allocation, and discharge prediction

create a folder on that push the file


Package does not work with trpc 10

I would love to help to get this updated

Yes pleaseeeee

I got you bro

if you need any support, I'd love to help out. I just haven't really gotten around to updating the repo in a while

I made great progress here the other day: https://github.com/nicholasoxford/trpc-remix, let me pull it down and work at it again today

@nicholasoxford That would be great!

Any plans to get it updated? @nicholasoxford ?

All you actually need to do is use the fetch adapter from trpc, my team has a boilerplate that uses it, check https://github.com/NoQuarterTeam/boilerplate
Look at the trpc file in remix api route folder


Compiling ouroboros-consensus on Windows

This might be just specific to my setup (I am using git-bash command line on Windows10)
Failed to build cryptonite-openssl-0.7. The failure occurred during the
configure step.
Build log (
C:\Users\mszam\AppData\Roaming\cabal\logs\ghc-8.6.5\cryptonite-op_-0.7-b4e2df2f3fb6950220cf7ba4da569
0ca0ffa9962.log
):
Configuring library for cryptonite-openssl-0.7..
cabal.exe: Missing dependencies on foreign libraries:
* Missing (or bad) C libraries: eay32, ssl32
This problem can usually be solved by installing the system packages that
provide these libraries (you may need the "-dev" versions). If the libraries
are already installed but in a non-standard location then you can use the
flags --extra-include-dirs= and --extra-lib-dirs= to specify where they are.If
the library files do exist, it may contain errors that are caught by the C
compiler at the preprocessing stage. In this case you can re-run configure
with the verbosity flag -v3 to see the error messages.

cabal.exe: Failed to build cryptonite-openssl-0.7 (which is required by
test:test-consensus from ouroboros-consensus-<IP_ADDRESS>, exe:byron-db-converter
from ouroboros-consensus-<IP_ADDRESS> and others). See the build log above for
details.

@coot do you have OpenSSL for Windows? I downloaded mine from here http://slproweb.com/products/Win32OpenSSL.html.
(I use msys2 and I can build locally).

@dcoutts did we get rid of the dependency on cryptonite-openssl-0.7 already? I vaguely remember that you had problems with it when trying to compile on Raspberry Pi.

See #285.
1.1.0 because the exchanges are not using Windows.

The scrypt dependency in cardano-ledger was recently removed: https://github.com/input-output-hk/cardano-ledger/pull/675/
@kderme @coot Can you check again whether ouroboros-consensus compiles on Windows? (Not mingw32, but real Windows)

@mrBliss
We got this PR merged: https://github.com/input-output-hk/cardano-crypto/pull/64, which is a replacement for PR #62.
With having RP 64 merged, I guess this issue should be unblocked.
cc: @dcoutts

Thanks @vhulchenko-iohk! @kderme and/or @coot can you propagate this change?

That's great, I can take care of towards end of the week.  After propagating it and merging #1499 whole ouroboros-network will compile on windows, hopefully we will be able to test cardano-node on windows.

That's great, I can take care of towards end of the week. After propagating it and merging #1499 whole ouroboros-network will compile on windows, hopefully we will be able to test cardano-node on windows.

@coot What's the status of this?

I did had time yet to look do it. We first need to finish the byron tickets and then I'll return to work Windows issues.

@coot When do you think we can close this issue? After #1774 or is there more to do?

ouroboros-netowrk compiles on Windows, so it's only to fix ouroboros-consensus issues.
There is this in cardano-node which will help to track and resolve all the issues for compiling the node on windows.

Lets also make windows required for the CI in this repo, just like in https://github.com/input-output-hk/cardano-node/pull/669.

ouroboros-netowrk compiles on Windows, so it's only to fix ouroboros-consensus issues.

@coot are there any known issues for  ouroboros-consensus (apart from stack related)? Are there still plans to use Win32-<IP_ADDRESS>?

When https://github.com/input-output-hk/ouroboros-network/pull/1808/ is merged, we should try to get consensus included in there too.

So we know it works overall, but we need CI to stop regressions. This should be enough once it passes and is merged.
https://github.com/input-output-hk/ouroboros-network/pull/1814

I tried to build cardano-node on Windows 10 and got the following error:
 [ 21 of 120] Compiling Ouroboros.Consensus.Storage.IO ( src-win32\Ouroboros\Consensus\Storage\IO.hs, .stack-work\dist\e626a42b\build\Ouroboros\Consensus\Storage\IO.o )
    src-win32\Ouroboros\Consensus\Storage\IO.hs:47:30: error:
        Variable not in scope:
          setFilePointerEx :: HANDLE -> Integer -> FilePtrDirection -> IO a4
       |
    47 |       AppendMode{} -> void $ setFilePointerEx h 0 fILE_END
       |                              ^^^^^^^^^^^^^^^^
    src-win32\Ouroboros\Consensus\Storage\IO.hs:65:3: error:
        Variable not in scope:
          setFilePointerEx :: Ptr () -> Int64 -> FilePtrDirection -> IO a3
       |
    65 |   setFilePointerEx h size (fromSeekMode seekMode)
       |   ^^^^^^^^^^^^^^^^
    src-win32\Ouroboros\Consensus\Storage\IO.hs:78:26: error:
        Variable not in scope:
          setFilePointerEx
            :: HANDLE -> Integer -> FilePtrDirection -> IO Int64
       |
    78 | getCurrentFileOffset h = setFilePointerEx h 0 fILE_CURRENT
       |                          ^^^^^^^^^^^^^^^^
    src-win32\Ouroboros\Consensus\Storage\IO.hs:84:10: error:
        Variable not in scope:
          setFilePointerEx :: HANDLE -> Integer -> FilePtrDirection -> IO a0
       |
    84 |     _ <- setFilePointerEx h (fromIntegral pos) fILE_BEGIN
       |          ^^^^^^^^^^^^^^^^
    src-win32\Ouroboros\Consensus\Storage\IO.hs:86:10: error:
        Variable not in scope:
          setFilePointerEx :: HANDLE -> Int64 -> FilePtrDirection -> IO a1
       |
    86 |     _ <- setFilePointerEx h initialOffset fILE_BEGIN
       |          ^^^^^^^^^^^^^^^^
    src-win32\Ouroboros\Consensus\Storage\IO.hs:93:8: error:
        Variable not in scope:
          setFilePointerEx :: HANDLE -> Integer -> FilePtrDirection -> IO a2
       |
    93 |   _ <- setFilePointerEx h (fromIntegral size) (fromSeekMode AbsoluteSeek)
       |

Related thread on Slack: https://input-output-rnd.slack.com/archives/C819S481Y/p1584555182036500

The problem @oneEdoubleD encountered is only a problem in cardano-node and has to be fixed there. It's caused by Stack's allow-newer: true setting. See https://github.com/input-output-hk/cardano-node/pull/706 (which is closed, but a proper fix is on the way).
Moreover, as of #1835, CI builds and tests on Windows using Wine (mingw32), which gives us some confidence consensus works on Windows. cardano-node, which uses consensus, has been reported to run successfully on Windows.
I think the only thing left to do is: let CI build and test on Windows (real Windows, not using Wine). @coot has a PR open for this (#1808), when that's merged, we can simply add the consensus tests to it. At that point we'll notice any remaining Windows problems and it will also make sure we don't regress.

Can we move discussion of this additional requirement "test on real windows as part of CI" into a new ticket please.
This ticket is "Compiling ouroboros-consensus on Windows". We are already doing that. It is also now a required build target in CI. We even run most tests on wine (bonus).

Closing, remaining CI work moved to #1847.

"test on real windows as part of CI" is fixed by #1808 now right?

"test on real windows as part of CI" is fixed by #1808 now right?

No, @coot only enabled the network tests, not the consensus tests. I'll try adding them to the workflow today.


[MXNET-338] Fix symbol boolean evaluation

Description
(Brief description on what this PR is about)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[x] Fix symbol boolean evaluation

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

Thanks for fixing the bug.


upgrade guide

Expected behaviour
I have installed  Stefan Petre's original code library in my template which I got,however I want to upgrade to this library. When I have old library it works fine, but after i Change datepicker doesn't show.
Actual behaviour
Tell us what happens instead.
Datepicker version used
Last version is used.
ex. 1.6.1.
Example code
$('.datepicker').datepicker({                 format: 'mm/dd/yyyy'             });
Please let me know what could possibly gone wrong while upgrade?

I really can't say what went wrong but I'm sure a simple upgrade from stefan's code to this code base is not possible as there is years code changes in this repository.
The example code should work. Closing this issue for now, please comment with a jsfiddle example that has the same problem you are experiencing.


Set up Kanban board

Please click here to visit Kanban board.
There are four team members in this group project. Team members and their tasks are listed below:

Team member 1: @MAleemH
Team member 2: @EmekaEmmanuel
Team member 3: @Fene-87
Team member 4: @shasherazi

Hi, Team👋,

Highlights💡

A link to the Kanban board is specified.✔
The team member size is stated.✔
All required columns are present.✔
Cards are distributed fairly.✔

STATUS: APPROVED 🕺🥳
Congratulations🍾🥳!! Your project is ready for presentation!  There is nothing else to say other than... it's time to merge it :shipit:

Optional Suggestions:

N/A

Good luck! 🎉

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @brytebee in your question so I can receive the notification.
Use @brytebee on slack for faster responses.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


[BUG] Stripping required generics parameters produces a compile time error

When running leptosfmt with these options:
max_width = 80
tab_spaces = 4
indentation_style = "Spaces"
newline_style = "Unix"
attr_value_brace_style = "WhenRequired"

It removes generics parameters that are required for the code to compile:
-                        </I18nRoute<Locale, _, _>>
+                        </I18nRoute>

Which bails out with a compile time error:
error: close tag generics missmatch
  --> src/app.rs:56:25
   |
56 |                         </I18nRoute>
   |                         ^^^^^^^^^^^^
   |
help: open tag generics should match close tag generics
  --> src/app.rs:52:25
   |
52 |                         <I18nRoute<Locale, _, _> view=Outlet>
   |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: could not compile `website` (lib) due to 1 previous error
Error: Failed to build website

The I18nRoute component comes from leptos_i18n and it's supposed to be used as follows:
        <I18nContextProvider>
            <Router>
                <main>
                    <Routes fallback=|| "Page not found.".into_view()>
                        <I18nRoute<Locale, _, _> view=Outlet>
                            <Route path=path!("") view=HomePage />
                        </I18nRoute<Locale, _, _>>
                    </Routes>
                </main>
            </Router>
        </I18nContextProvider>

IMO, leptosfmt should preserve these generics.

This was fixed in #159 but hasn't been released yet. I will do a new release soon, but meanwhile you can install the unreleased version (instructions in the readme).


[ASP.NET SignalR Service]Update the negotiate response

ProtocolVersion up to 2.0
Use RedirectUrl instead of already in-use Url

Why 2.0? Isn't the current version 1.4?


_content/doc/tutorial/greetings-multiple-people.html: Add missing Indication of changes

In line 162 the argument of Hellos changes from "Gladys" into names. The indication of a change was missing in the code block.

@googlebot I signed it!

I just saw that there are 3 other pull requests concerning this issue:
https://github.com/golang/website/pull/49
https://github.com/golang/website/pull/121
https://github.com/golang/website/pull/135
@sethbattin is waiting since April to get approved...


Bottom nav bar font could be lighter in dark mode

Was this addressed in #375 ?

Closing; obsolete.


Cria/Rose-2: my results are way worse than the paper's

I ran your code's first- and second stage and I am confused why I get such worse results than are described in the paper.
I ran the first stage with the resnest50-528c19ca.pth and I linked for my second stage with the [...]best-fusion.pth, [...]best-thick.pth and the [...]best-thin.pth models, generated by the first stage, to the suffix-variables.
Quantitative results for the fusion step:

AUC and ACC are fairly close, but DICE, the metric I find the most relevant, caps at around 0.41, which is way worse than what you wrote in your paper (0.7077)
Qualitative results for the fusion step:

We were interested in this paper because of the prospect of filtering out artifacts on OCTA images. These images above are probably the most extreme examples on the test set, but I don't see the models that I have trained, as acceptable enough to use.
Conclusion:
I have no trouble believing that I messed up somewhere, which would explain why I get such bad results. I just don't know where.
I have not used the front_model-189-0.9019971996250081.pth for the second stage, that you linked here. The download doesn't give me the file that I want but an .exe called BaiduNetdisk_<IP_ADDRESS>. I don't know what to do with that and I have no administrative rights here, so I can't launch the installation that it is trying to launch.
Could you maybe upload the  front_model-189-0.9019971996250081.pth - like you did for resnest50-528c19ca.pth (https://github.com/iMED-Lab/OCTA-Net-OCTA-Vessel-Segmentation-Network/issues/2) - on a drive? I would like to know if I can reproduce the results of your paper with that model.
Also concerning the front_model-189-0.9019971996250081.pth: Is this a fusion-, thin- or thick-model?

Okay so what I have reported in my first comment still holds true. I was not able to reproduce your results.
Accordingly, it would be great if you could upload the front_model-189-0.9019971996250081.pth on a google drive - like you did for the resnest50-528c19ca.pth -  and explain what variable to set to its path.

@BenjaminBo Would you please rephrase how you run this code, I'm facing with this error when it's trying to load resnest50-528c19ca.pth from url_format variable indicated in resnest.py
_url_format = 'https://hangzh.s3.amazonaws.com/encoding/models/{}-{}.pth'
request.py", line 649, in http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 403: Forbidden

I downloaded the resnest50-528c19ca.pth as described in #2. It's the second link I believe. I then ised the downloaded .pth in the repos.
I'm not sure what this error is, that you're showing me, but you seem to download it at runtime? Maybe that's the problem.

@BenjaminBo Thank you so much for the contribution 🙏🏻

No problem. If you get to reproduce the results from the paper or get better results than I did, tell me how you did it :)

@BenjaminBo Sure, I will keep you posted about my running, Could I have your email address to be able get in touch rather than here? Mine is<EMAIL_ADDRESS>

@BenjaminBo  after downloading resnest50-528c19ca.pth, I ran program, but I faced with this error:
File "/Users/miniforge3/envs/torch-gpu/lib/python3.8/multiprocessing/spawn.py", line 134, in _check_not_importing_main
raise RuntimeError('''
RuntimeError:
An attempt has been made to start a new process before the
current process has finished its bootstrapping phase.
    This probably means that you are not using fork to start your
    child processes and you have forgotten to use the proper idiom
    in the main module:

        if __name__ == '__main__':
            freeze_support()
            ...

    The "freeze_support()" line can be omitted if the program
    is not going to be frozen to produce an executable.

Start training...
Epoch 1 / 300
Traceback (most recent call last):
File "", line 1, in
There is something wrong with dataloader I think. I was wondering did you change some lines in options.py inside your code?
I just changed data_dir to load the image dataset, what else I need to change? That would be greatly appreciated if you help me with this issue,

@BenjaminBo How was your results on front_main step? I got the results on that step almost like the paper


Microsoft/IIS Image Container error while downloading through Kitematic

Expected behavior
successfully downloaded
Actual behavior
Error:"unknown blob"
Information about the Issue
Steps to reproduce the behavior

run Docker on MacOS X Sierra
try to download Microsoft/IIS image with Kitematic

This is a Windows Container image only - Please see the documentation for this image and the requirements.
To learn more about Windows Containers, please see this post:
https://blog.docker.com/2016/09/build-your-first-docker-windows-server-container/


fix(analytics): add types and missing slug

The type of this PR is: fix

This PR is a follow-up for CX-2076
Description
just adding some types that were missing, and adding the slug that the type caught missing.

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests/stories for my changes, or my changes don't require testing/stories, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

types for analytics - pavlos

This PR contains the following changes:

Dev changes (types for analytics - pavlos)

  Generated by :no_entry_sign: dangerJS against 965b7014b1ed2b97997a59778162d32ed440d362


Create settings for features optional

Hi, I really like this plugin. However, I'd like to keep some features, such as tooltip or keep users starring/forking your repos from the newsfeed. In my case I don't have as many and I appreciate it when happend :smile:
Despite it would need a big refactor, every user could set as they would like to.
Something like:

[x] Linkifies branch references in pull requests
[x] Linkifies issue/PR references in issue/PR titles
[x] Adds a 'Releases' tab to repos (g r hotkey)
[x] Adds a quick edit button to the readme
[x] Shows current filename in the sticky pull request header
[x] Adds blame links for parent commits in blame view
[x] Improves readability of tab indented code
[x] Adds a shortcut to quickly delete a forked repo
[x] Adds ability to minimize/maximize files in a pull request diff
[x] Adds links to patch and diff for each commit
[x] Differentiates merge commits from regular commits
[x] Hides :+1: :-1: comments and shows their count in the sidebar
[x] Supports indenting with the tab key in textareas like the comment box
[x] Automagically expands the news feed when you scroll down
[ ] Hides other users starring/forking your repos from the newsfeed
[x] Prompts you when pressing Cancel on an inline comment in case it was a mistake
[x] Moves the dashboard organization switcher to the right column
[x] Removes annoying hover effect in the repo file browser
[x] Removes the comment box toolbar
[ ] Removes tooltips

Asked and answered:
https://github.com/sindresorhus/refined-github/issues/57
https://github.com/sindresorhus/refined-github/issues/10

Just going to mention these previous issues.
While I realise as this extension is getting more and more popular there would be more desire to opt-out of the more opinionated changes. Probably we could make it possible to opt-out of the different CSS changes in the future, but not right now. If ever go that way we could do it like Modernizr, based on options to put some classes in the body and then activate CSS changes only when the class for that change is present.

I've seen the request for wanting to keep the stars many times. We might add a limited amount of options in the future, but right now we want to focus on getting everything right Using https://devspace.io/ might be a better way to keep up on when your projects gets starred btw.
I'm curious though why you want the tooltips back? Any specific ones?

I also like https://gitnotifier.io/ which keeps tabs on follows/unfollows and stars of your projects. It can also send you weekly digests.

@hkdobrev Maybe we should create an FAQ section where we recommend gitnotifier and devspaces for people wanting to see vanity stuff?

Just saw #70 answer...never mind.

The tooltip as for participants name specially

That can indeed be useful. We can add that back.


Add JAX to iree-frontends CI

Renames all cmake-bazel-tensorflow-* images to cmake-bazel-frontends-*.
Adds jax, jaxlib and flax dependencies to these images (the last is future-looking).
Adds CTest configuration for bindings/python/pyiree/jax/frontend_test.py.

Eventually we likely want to separate out individual frontends, but currently the JAX frontend relies on building XLA with Bazel, and it is natural to bundle it with TensorFlow.

After this lands, you're going to need to update the name of the image cached by Kokoro, not just the image that's pointed to by the prod tag (requires an internal CL).

Thanks for the reminder!

After this lands, you're going to need to update the name of the image cached by Kokoro, not just the image that's pointed to by the prod tag (requires an internal CL).

Thanks for the reminder!


fix: Negative time reported for "time label applied" measurement

Pull Request
Address case where negative time for "time label applied" is reported for labels that have at some point been both "labeled" and "unlabeled" on a given issue (https://github.com/github/issue-metrics/issues/282)
Proposed Changes
Readiness Checklist
Author/Contributor

[x] If documentation is needed for this change, has that been included in this pull request
[x] run make lint and fix any issues that you have introduced
[x] run make test and ensure you have test coverage for the lines you are introducing

Reviewer

[x] Label as either fix, documentation, enhancement, infrastructure, maintenance, or breaking

Thanks for finding and fixing this bug! I'm able to take a look at this on Tuesday and plan to review then unless @jmeridth has time before then.

Tested locally and confirmed fix works.  Thank you @smstone
On latest

Originally labelled:

Title
URL
Author
Time to first response
Time to close
Time to answer
Time spent in bug

[bug] test bug
https://github.com/redacted/issues/6
jmeridth
None
None
None
0:02:05.862071

Unlabelled:

Title
URL
Author
Time to first response
Time to close
Time to answer
Time spent in bug

[bug] test bug
https://github.com/redacted/issues/6
jmeridth
None
None
None
0:02:28

Relabelled:

Title
URL
Author
Time to first response
Time to close
Time to answer
Time spent in bug

[bug] test bug
https://github.com/redacted/issues/6
jmeridth
None
None
None
-1 day, 23:59:01

With fix

Title
URL
Author
Time to first response
Time to close
Time to answer
Time spent in bug

[bug] test bug
https://github.com/redacted/issues/6
jmeridth
None
None
None
0:07:25.845498


Added Javascript Minifier

This pull request adds Javascript minifier and fixes #42

Please also add some options to configure minification

Can you add UI elements so that the user can control how minification is done
Checkout the options supported by uglifyjs here
For example you can add a checkbox for the following:

Perserve Annotations,
Compress,
Support IE,
Keep fnames,
Mangle names


[BUG] Tabbing out with the Windows key not working

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
I can't tab out normally, I always have to do Alt + Tab and it's getting really annoying. I tried searching about this problem but couldn't really find a fix

Are you using exclusive fullscreen?

Tbh i have no idea, but now that you mention it that might be it. Which one do I disable exclusive full screen? (Bloxstrap menu, Play Bloxstrap or the Roblox client?)

Fast flags menu, there should be a button.

but now that you mention it that might be it

If you don't know what it is, then you're certainly not using it, so forget I asked. Though, it does sound like you are using fullscreen. Does this happen in windows mode too?

It's always in full screen, when I go to the roblox settings and turn fullscreen off it's still fullscreen. And another thing, when i try to record with OBS, the screen will record a single frame of roblox and then freeze. Screenshotting is buggy too, idk how to explain it but it's like the photo capture GUI is on another layer, i can still take the photo but the GUI doesn't appear, idk tbh

I can record a video of it if you want

Ohhh wait, I know what you are talking about.
It's Roblox's problem not bloxstrap. I also get the issue, I know what you mean.

It's always in full screen, when I go to the roblox settings and turn fullscreen off it's still fullscreen. And another thing, when i try to record with OBS, the screen will record a single frame of roblox and then freeze. Screenshotting is buggy too, idk how to explain it but it's like the photo capture GUI is on another layer, i can still take the photo but the GUI doesn't appear, idk tbh

Does pressing Alt+Enter bring you out of fullscreen? What FastFlags do you have configured?

I tried alt+enter but it did nothing, and the FastFlags I have are just a bunch of optimization thingies I found on YT: FFlagDebugGraphicsDisableDirect3D11
FFlagDebugGraphicsPreferOpenGL
FIntDebugFRMOptionalMSAALevelOverride
FStringPartTexturePackTablePre2022

What if you remove the first two flags?

Permit me to announce with an air of utmost refinement and sophistication, that within my esteemed possession lie two meticulously chosen FastFlags which were in actuality the ones causing said error.
Yeah those two fastflags were the problem. Thanks!


p2os: 2.2.1-2 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository p2os to 2.2.1-2:

upstream repository: https://github.com/allenh1/p2os
release repository: https://github.com/allenh1/p2os-release.git
distro file: noetic/distribution.yaml
bloom version: 0.9.7
previous version for package: null

p2os_doc
* Prepare release 2.2.0 (#59 <https://github.com/allenh1/p2os/issues/59>)
  * Update changelog
  * 2.2.0
* Update email address (#58 <https://github.com/allenh1/p2os/issues/58>)
* Contributors: Hunter L. Allen

p2os_driver
* Two fixes for Melodic. (#62 <https://github.com/allenh1/p2os/issues/62>)
  In p2os_driver, the p2os_msgs_gencpp doesn't exist (and, as
  far as I can tell, never existed).  It worked up until recently
  because older versions of CMake would complain but not fail,
  while more recent cmake versions actually fail.  Just remove
  the dependency.
  The second fix is a cosmetic issue, where CMake would spew a
  bunch of warnings on the command line.  Increase the version
  to 3.9.5 to match other CMakeLists.txt and to get rid of the
  warnings.
* Prepare release 2.2.0 (#59 <https://github.com/allenh1/p2os/issues/59>)
  * Update changelog
  * 2.2.0
* Update email address (#58 <https://github.com/allenh1/p2os/issues/58>)
* Fix driver license (#56 <https://github.com/allenh1/p2os/issues/56>)
  * Upon further inspection, this p2os_driver is GPL 2
  * Fix kinecalc license line
  * Update p2os_ptz license
  * Fix robot_params license
* Add CI (#54 <https://github.com/allenh1/p2os/issues/54>)
  * Add .travis.yml
  * Add .gitignore
  * Add test script
  * Rename *.h to *.hpp
  * Rename *.cc to *.cpp
  * Apply change to CMakeLists.txt
  * Fix copyright line(s), as well as fix header guard style
  * Default standard to C++14, and bump CMake minimum to 3.9.5
  * Remove unused boost include
  * Make headers pass CI
  * Add build status to the README
* Contributors: Chris Lalancette, Hunter L. Allen

p2os_launch
* Prepare release 2.2.0 (#59 <https://github.com/allenh1/p2os/issues/59>)
  * Update changelog
  * 2.2.0
* Update email address (#58 <https://github.com/allenh1/p2os/issues/58>)
* Contributors: Hunter L. Allen

p2os_msgs
* Prepare release 2.2.0 (#59 <https://github.com/allenh1/p2os/issues/59>)
  * Update changelog
  * 2.2.0
* Update email address (#58 <https://github.com/allenh1/p2os/issues/58>)
* Contributors: Hunter L. Allen

p2os_teleop
* Two fixes for Melodic. (#62 <https://github.com/allenh1/p2os/issues/62>)
  In p2os_driver, the p2os_msgs_gencpp doesn't exist (and, as
  far as I can tell, never existed).  It worked up until recently
  because older versions of CMake would complain but not fail,
  while more recent cmake versions actually fail.  Just remove
  the dependency.
  The second fix is a cosmetic issue, where CMake would spew a
  bunch of warnings on the command line.  Increase the version
  to 3.9.5 to match other CMakeLists.txt and to get rid of the
  warnings.
* Prepare release 2.2.0 (#59 <https://github.com/allenh1/p2os/issues/59>)
  * Update changelog
  * 2.2.0
* Update email address (#58 <https://github.com/allenh1/p2os/issues/58>)
* Contributors: Chris Lalancette, Hunter L. Allen

p2os_urdf
* Prepare release 2.2.0 (#59 <https://github.com/allenh1/p2os/issues/59>)
  * Update changelog
  * 2.2.0
* Update email address (#58 <https://github.com/allenh1/p2os/issues/58>)
* Fixed color in gazebo with 3at. (#57 <https://github.com/allenh1/p2os/issues/57>)
* Contributors: Alberto, Hunter L. Allen

holding for the upcoming Noetic sync


Do not force a reload when navigating out of the app base

This fix https://github.com/angular/angular.js/commit/9e492c358c19549696577c86c2c61b93f50ab356 in fact introduced a breaking change.
I have an application, where on top of angular modals are opened with usage of browser history API. Now, the page gets reloaded because of the bugfix, which does more than necessary.
There was a suitable workaround that I enclosed in the original issue, which did not break anything. https://github.com/angular/angular.js/issues/4776
It would be great if it was at least possible to disable the reload in configuration. Btw. magically reloading the page without logging any info anywhere for the developer is a bit unfair. He just finds his page being reloaded with no good reason.
Moreover, workarounds we already had does not work anymore, since the new code does not use $location.$$parse.

@jirihelmich - can you provide a runnable example of the problem? I believe that patching the $location services caused other use cases to fail. Perhaps you could show how your solution would work in a PR?

Well, in fact, I don't have a running example after more than three months. In fact, I don't have the app either as our company decided to migrate it to React-ish stack.
The problem/use case was:

you run the app inside of a page at /some/folder/view (no angular router, server-side routing, container for ng app rendered on the server, ng app bootstrapped)
then from an angular app, you open a pop-up/lightbox/modal/.. and push its url to history, let's say /different/folder/view

URL changed, angular detected that it's base URL is not in location anymore -> reload.

@jirihelmich - thanks for the extra information. It seems strange to push an entirely new URL to the history for a modal pop-up. What if the user did a manual refresh themselves? This would take you to completely different page, outside the original angular app, right?
I would expect that such a modal URL should be a sub-URL of the angular app at least. Otherwise I would consider putting the popup in an iframe or something to give it its own context.
What were the reasons for doing it the way you describe?

So, the bigger picture. We are a PMS solution and in order to support user needs, we have a custom window manager. That means that we have stackable windows in our app. In the beginning, you get a "normal" page, when you click on something which goes more into detail, we open another layer on top of the previous one, you can go back.
We have a window manager that tracks URL changes, takes care of AJAX requests and if user presses refresh, it reconstructs the stack of windows from the window history.

On the left, you could see the stack of windows to make it more real for you.
Those are rendered mostly on server, downloaded via HTTP using XHR, links and forms are bound by jQuery to behave as expected. If user would press refresh now, the page would reload, the topmost window would be rendered on the server in the layout, then the manager requests the underlying windows and swaps the content to make it as it was.
But we had (and still have) some Angular apps that were injected into this. Meaning user clicked, the content of the window rendered on the server was a container for an angular app. We bootstrapped it manually, everything was running fine. The problem came, when we opened another layer above the angular app, which was some partial rendered fully on the server again. With all the previous angular releases, we were fine, but this broke it for us.
I know that our use case is out of the scope of pure Angular world and is rather complicated. But still, it`s a real world scenario broken by the commit. And I would not create an issue for it, if it wasn't because of the fact that someone decided to refresh a page if some condition fails. I don't find that fix very convenient, since refreshing a page is a brutal thing to do when some internal check fails.
The problem is, that we were trying to combine Angular with non-Angular world, which simply does not work very well. So far, we have overcome everything we had an issue with, but releasing refresh of a page as a part of bugfix revision was a very unpleasant experience.

We ran into this issue recently and also agree with @jirihelmich that the introduction of the "feature" as part of a bugfix was unpleasant.  I'm wondering why this is even needed as part of the core, it seems as if this would be more appropriately placed in angular-route.
We have created a somewhat contrived sample showing the problem, highlighting the differences between 1.4.3 and 1.4.4 (and onward).  The basic premise is that an angular app exists inside a page with non-angular paradigms for updating content on the page.  The user clicks thumbnails causing an area of the page to show new content and updating the URL with a slug appropriate for bookmarking.  This sample is in no way comprehensive but I hope it illustrates the problem we're facing.
Without having this rolled back in angular.js, we'll likely have to decorate it out of the service which is undersireable from a maintenance perspective.

Is there a temporary workaround for this problem?


Add config to options

If config object passed to gulp-jest doesn't have a top-level config property, the config will be silently ignored.

Actually, this seems to only works in jest-cli 20.0.4 and below.


Update test for src/ride-hailing/MissionParams.test.ts

first-timers-only
This issue is tagged :octocat: first-timers-only. It is only for people who have never contributed to open source before, and are looking for an easy way take their first steps.
Consider this your chance to dip your toe into the world of open-source, and get some bragging rights for writing code that makes drones fly, lets cars find charging stations, helps people and goods get from place to place, and more.
Find more first-timers-only issues from DAV Foundation here.
Thank you for your help :heart:
What is this project?
DAV (Decentralized Autonomous Vehicles) is a new foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.
As an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.
dav-js
This repo contains the DAV JavaScript SDK. This SDK allows developers to build applications and servers that connect to the DAV network. For example, allowing a drone to find charging stations, or an autonomous car to ask for traffic data.
How you can help
In order to foster a community that is welcoming for open source contributions, it is important for us to have good test coverage. And good tests are simple, readable tests.
Here is a good opportunity to simplify one of our tests.
The Issue
In src/ride-hailing/MissionParams.test.ts we defined the following parameters at the beginning of the describe() block.
const missionParams = new MissionParams({});

const serializedMissionParams: any = {
    ttl: undefined,
    protocol: 'ride_hailing',
    type: 'mission',
    price: undefined,
    vehicleId: undefined,
};

These parameters will need to accommodate additional unit tests.
Please update these parameters to be more dynamic by defining them to be mutable similar to src/vessel-charging/MissionParams.test.ts.

Contributing to dav-js

[ ] Make sure this issue is labeled up-for-grabs and not labeled claimed, to verify no one else is working on it.
[ ] Comment in this issue that you would like to do it.
[ ] Open dav-js GitHub page and click the ★ Star and then ⑂ Fork buttons.
[ ] Clone a copy to your local machine with $ git clone git@github.com:YOUR-GITHUB-USER-NAME/dav-js.git
[ ] Install dependencies by running npm install
[ ] Code Code Code
[ ] Once you've made sure all your changes work correctly and committed all your changes, push your local changes back to github with $ git push -u origin master
[ ] Visit your fork on GitHub.com (https://github.com/YOUR-USER-NAME/dav-js) and create a pull request for your changes.
[ ] Make sure your pull request describes exactly what you changed and references this issue (include the issue number in the title like this: #7)
[ ] Please do not fix more than one issue at a time. Your pull request should only fix what is described in this issue.

Asking for help
We appreciate your effort in taking the time to work on this issue and help out the open source community and the foundation. If you need any help, feel free to ask below or in our gitter channel. We are always happy to help 😄

Hi! New around here. Could I grab this issue if it's still up for grabs?
Thanks!

Welcome @leeyspaul 😄  yes please go right ahead. Let me know if you have any questions.

Thanks. I think I made the changes correctly and did the PR as it should be done but if I've made a mistake please do let me know!

Nice PR @leeyspaul! Great description. Nicely done. Merged 🕺
Thanks for your help. I hope to see more contributions from you 👐
We have plenty of issues open https://github.com/issues?utf8=✓&q=is%3Aopen+is%3Aissue+archived%3Afalse+label%3A"good+first+issue"+user%3ADAVFoundation+

That is great I do hope to contribute more and I'll try my best as a rookie!


Static folders are included in lambda artifacts

I've seen that /static directiory in considered in labmda artifacts. We've vidoes which are there for static pages and ideally it should not be there in artifacts. It should be served directly with some static serve method of zeit.
As artifacts size is limited to 50mb. I am unable to deploy it to the zeit.

Is this a duplicate of #3?

Feels like duplicate, but don't show how to resolve.
Looking into your PR.

I think this is now closed by #106.


Refactor Todo settings, offer pre-defined list of Todo apps

Description

As per #418, in Todo Server setting, I substituted the field where users had to enter the url of the todo app they use with a dropdown menu displaying a list of todo apps:

Todoist
Franz Todo
TickTick
Microsoft To Do
Habitica
Nozbe
Remember The Milk
Any.do (the log in page isn't responsing in Ferdi todo's webview)

Please let me know if you want to delete any of the above, or add any.
Motivation and Context

The change adds convenience for users.
Now, users can select the todo app they use instead of fetching and copying/pasting the url of the todo app they use.
How Has This Been Tested?

I tested in Electron. I am not sure how to test it in as a new user cc @kytwb
Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

That is a refactoring.
Checklist:

[ ] My code follows the code style of this project (run $ yarn lint).

@kytwb @vantezzen does my refactoring require a change to the documentation?

Thanks for picking this one up @yourcontact 💪
Looking forward to the rest and happy to assist again whenever 🙏

Looks great.
A suggestion would be to add another option "Other service" that displays a text input box below the select-element so users can use any service they want.
This would need to be implemented similar to how the darkmode setting displays more sub-settings when you activate it (Component, Container).
This would also require a change to the webview to use that custom value istead if selected.

Thank you @vantezzen.
I would like to share an update on where I am with the refactoring Ferdi Todo setting:

added "Other service" to the drop down menu
added a field that appears when "Otherservice" is selected in the dropdown menu

Next step is to fix the field for users to input URL of the todo service/app they use. The field currently collapse when I try to input data.

@vantezzen I resolved your comments https://github.com/getferdi/ferdi/pull/477#pullrequestreview-378435525 and updated my initial PR comment https://github.com/getferdi/ferdi/pull/477#issue-390407136 with latest change.
I am not sure how to fix this (cc @kytwb):

@yourcontact can you try removing these files?

@yourcontact feel free to post updates in new comments instead of editing past comments, it's less confusing for the thread history 🙏 no big deal though

We will still need a migration from the old settings to the new ones in https://github.com/getferdi/ferdi/blob/develop/src/stores/SettingsStore.js#L185. I had a custom Todo server set but the settings screen says that I selected Todoist:

@vantezzen Good catch!
Regarding the errors, we should probably try to load the Custom Todo URL only once it's a valid URL.

@yourcontact can you try removing these files?

I removed those files.

@kytwb and I added a regex to validate the URL when a user select Other service.

We will still need a migration from the old settings to the new ones in https://github.com/getferdi/ferdi/blob/develop/src/stores/SettingsStore.js#L185.

@kytwb will take over this pull request and set a migration from old settings.

@vantezzen I will work on the migration of old settings with @kytwb tomorrow.

I had to get going with my day, so we only worked on https://github.com/getferdi/ferdi/pull/506; we're pairing again tomorrow at 9am (my local time) to address the missing migration.

I resolved conflicts in src/containers/settings/EditSettingsScreen.js.
For the conflicts in the two following files:

src/i18n/locales/defaultMessages.json;
src/i18n/messages/src/containers/settings/EditSettingsScreen.json;

It looks like there are conflicts due to code style changes.
Shall I apply what is in the "refactor/settings-todo" branch and delete what is on the "develop" branch?

I am not sure myself what's the best thing to do right now. Can you try keeping your changes and re-running npm run manage-translations?

I am not sure myself what's the best thing to do right now. Can you try keeping your changes and re-running npm run manage-translations?

@kytwb I ran npm run manage-translations on the "refactor/settings-todo" branch.
Below is a screenshot of what I got. I am not sure what to do next.

Check if the diff looks good to you (git diff), then you can finalize the merge with git commit --no-edit.

Not sure what's the best way to handle this given the restrictions enforced (scenario where we need to help in pull requests from external contributors), but I think it's best for the long term if we figure it out.

Closed by #527.


Title not updating when refreshing, adding or readding the entry

Steps to reproduce

Find ExHentai entry with ongoing updates in library e.g. [Ahemaru] NTR na Sekai | NTR World Ch 1-5
When entry gets new chapters, refreshing should pull the latest update OR when readding the new entry from source
Remove the previous entry from library and add the new one, then pull for refresh
Migrating from the old entry to the new one still results in the old title (it does crash the app and in the library at first seems like the new title it's there but as soon as you requery the title via sort, search or other means, it will show the old title again)

Expected behavior
After updating, migrating, adding the updated entry to the library or removing the old entry from library and readding the new updated entry to the library from source, the title should be updated
Actual behavior
Does not update the title
Crash logs
No response
Tachiyomi version
preview r464
Android version
Android 10
Device
OnePlus 7 Pro
Other details
Refresh video
I can record the other examples in the steps to reproduce if needed
Acknowledgements

[X] This is a TachiyomiSY specific issue that does not happen in Tachiyomi Preview.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to version 1.8.4.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Found the cause of this, will be fixed for the next build 👍


Bots Not Respecting Blacklist Filenames

When I set blacklist filename it is still downloading the image. Would I need to add the filename plus the format (blank.png)?

Make sure you're doing "blockedFilenames" within a "filters" group and nothing else, it should be working.
It doesn't need to be a complete match, it checks to see if the filename contains any of your phrases within "blockedFilenames".


Unable to fetch namespaces if metrics service is unavailable at this moment

Which project are you reporting a bug for?
kr8s
What happened?
kr8s==0.12.3
I am not able to fetch all namespaces, if some API are not working at this moment i.e. metrics.
At this moment, kubectl returns me this error: E1205 15:53:39.605236   31092 memcache.go:287] couldn't get resource list for metrics.k8s.io/v1beta1: the server is currently unable to handle the request but still able to return namespaces.
But, kr8s itself cannot fetch namespaces, if metrics service is unavailable. The same happened to me in another environment, where linkerd doesn't work.
Anything else?
No response

@jacobtomlinson I installed a dev version of kr8s. pip list confirmed I am on a dev version 0.12.4.dev1+g95e5d49.
Then, I ran my code again, and it failed. I chose environment, where linkerd is not functioning properly and got the same exception. Here it is:
Traceback (most recent call last):
  File "/Users/stanislav.hordiyenko/Desktop/sandbox/k8s-resource-audit/main.py", line 9, in <module>
    for ns in kr8s.get("namespaces"):
              ^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/stanislav.hordiyenko/Desktop/sandbox/k8s-resource-audit/venv/lib/python3.11/site-packages/kr8s/__init__.py", line 90, in get
    return _run_sync(partial(_get, _asyncio=False))(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/stanislav.hordiyenko/Desktop/sandbox/k8s-resource-audit/venv/lib/python3.11/site-packages/kr8s/_io.py", line 75, in wrapped
    return portal.call(wrapped)
           ^^^^^^^^^^^^^^^^^^^^
  File "/Users/stanislav.hordiyenko/Desktop/sandbox/k8s-resource-audit/venv/lib/python3.11/site-packages/kr8s/_io.py", line 50, in call
    return self._portal.call(func, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/stanislav.hordiyenko/Desktop/sandbox/k8s-resource-audit/venv/lib/python3.11/site-packages/anyio/from_thread.py", line 266, in call
    return cast(T_Retval, self.start_task_soon(func, *args).result())
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 456, in result
    return self.__get_result()
           ^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 401, in __get_result
    raise self._exception
  File "/Users/stanislav.hordiyenko/Desktop/sandbox/k8s-resource-audit/venv/lib/python3.11/site-packages/anyio/from_thread.py", line 203, in _call_func
    retval = await retval
             ^^^^^^^^^^^^
  File "/Users/stanislav.hordiyenko/Desktop/sandbox/k8s-resource-audit/venv/lib/python3.11/site-packages/kr8s/asyncio/_helpers.py", line 65, in get
    return await api._get(
           ^^^^^^^^^^^^^^^
  File "/Users/stanislav.hordiyenko/Desktop/sandbox/k8s-resource-audit/venv/lib/python3.11/site-packages/kr8s/_api.py", line 337, in _get
    async with self._get_kind(
  File<EMAIL_ADDRESS>line 204, in __aenter__
    return await anext(self.gen)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/Users/stanislav.hordiyenko/Desktop/sandbox/k8s-resource-audit/venv/lib/python3.11/site-packages/kr8s/_api.py", line 257, in _get_kind
    resources = await self._api_resources()
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/stanislav.hordiyenko/Desktop/sandbox/k8s-resource-audit/venv/lib/python3.11/site-packages/kr8s/_api.py", line 427, in _api_resources
    async with self.call_api(
  File<EMAIL_ADDRESS>line 204, in __aenter__
    return await anext(self.gen)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/Users/stanislav.hordiyenko/Desktop/sandbox/k8s-resource-audit/venv/lib/python3.11/site-packages/kr8s/_api.py", line 136, in call_api
    response.raise_for_status()
  File "/Users/stanislav.hordiyenko/Desktop/sandbox/k8s-resource-audit/venv/lib/python3.11/site-packages/httpx/_models.py", line 758, in raise_for_status
    raise HTTPStatusError(message, request=request, response=self)
httpx.HTTPStatusError: Server error '503 Service Unavailable' for url 'https://<IP_ADDRESS>/apis/tap.linkerd.io/v1alpha1'
For more information check: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/503

kubectl returns me this information before returning actual results:
E1206 08:42:53.228971   34750 memcache.go:287] couldn't get resource list for tap.linkerd.io/v1alpha1: the server is currently unable to handle the request

Ah I missed something, mind installing from that branch again and trying again?

One moment..

Now, it works. I can see that it also reports about the issue in the beginning like kubectl:
/Users/stanislav.hordiyenko/Desktop/sandbox/k8s-resource-audit/venv/lib/python3.11/site-packages/kr8s/_api.py:267: UserWarning: Server error '503 Service Unavailable' for url 'https://<IP_ADDRESS>/apis/tap.linkerd.io/v1alpha1'
For more information check: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/503
  warnings.warn(str(e))

Script completed successfully, thank you @jacobtomlinson . Much appreciated. That was a quick fix :-)

Sweet, glad that worked. Let me merge and release so you can move back off the dev branch.

@stanislavhordiyenko 0.12.4 is now on PyPI with this fix in.
If you have a minute I'd love to hear a little more about what you're using kr8s for. Knowing what problems people are trying to solve, and why they chose kr8s over other Python libraries or kubectl really helps me build out examples, docs and generally prioritise work here.

Much appreciated.

Where do you want me to write the feedback? I am glad to share what I am using it for and my plans for the future.