Pin docker images

Pin versions of the docker images being used
Closes #459

I agree that we need to do something along those lines, but I'd wager we go a step further and do it the ocaml-ci way:

Have a specific hash of a docker image so we're sure it's stable
Have a specific hash of the opam repository, so we know what versions of ocaml packages we're running on
(example here https://github.com/ocurrent/ocaml-ci/blob/master/Dockerfile#L1-L3)

And I think it's important that we put a note somewhere (I don't know where though) explaining the whole thing: "This hash was the latest when we modified this file, and we tested it to make sure it runs fine. Update this in X months."
And then actually follow through with it

Thanks these suggestions are great. I'll work on updating the PR.
I think having a simple tool to change these hashes might be helpful in making sure that we actually do the updates, every so often. It might be a useful thing for other teams like the CI team too. Maybe there's already something like this out there, otherwise might be a good Hacking days project.

Self-merging since this has been manually tested by @shakthimaan a couple of times at least.


ec2_instance does not allow array of security_groups

The documentation states that you should be able to specify multiple security groups when using ec2_instance, however, it will throw an error if an array is specified.
There are no examples showing multiple security groups works.
On line 48 of ec2_instance.rb the security_groups property has the following validation:
fail 'security_groups should be a String' unless value.is_a?(String)

Working for me in the lat st version.


Jobs waiting to lock resource could be searching for newly created resources

FEATURE REQUEST
It would be nice feature if we could on the fly add resources, while jobs are already waiting for resources with specified label to lock.
So, if a new resource added, (after the jobs started to run), matches the requirements, the resource should be acquired normally.
CURRENT BEHAVIOR
Resources added after job started polling for resources to lock, are not visible to the job.

Opened in Jira


Anyway to disable animation temporarily?

I would like to show animation of horizontal progress bar any time the user lands on a screen. Every time user opens screen I first reset progress state to 0 and then set it to required number to show it's moving from 0 to say 50%. The problem is that it shows animation twice when I first reset it to 0 and then when setting back to 50%. Is there a way to disable the animation in the first case when I reset it to 0?

I was going to suggest changing settings in animationConfig, but then I realized you can't access the progress object to get the next value the bar will be added to without componentWillReceive, so I've added the animateReset prop. Changes present in pull request #121. Hoping @oblador sees this!
With animateReset set to true

With animateReset set to false

@pedrojor2, thank you very much sir! Will be waiting for @oblador to incorporate this into next release.


Not working with JSX by default

I love this package, thanks so much for building! I hope the below comment helps anyone else with the same issue:
I wasn't able to get auto close to work with JSX files until modifying the atom key map file to include:
 'atom-text-editor':    '>': 'autoclose-html:close-and-complete'

atom-text-editor[data-grammar~="jsx"] would be more appropriate I think

Might this be related to the "no more grammars" commits from 0.22?
https://github.com/mattberkowitz/autoclose-html/commit/73cdb1292978c3b491ef5adc24bb108001aebce3
If we need to re-add each of the grammars by assigning a "new" keyboard shortcut that mirrors the default one I almost wonder if this is a superior solution to the grammar list from before 0.22…

I can't seem to get this to work even after copying 'atom-text-editor': '>': 'autoclose-html:close-and-complete' into keymaps.cson... is this fix still working for others?


how to feed model  batch inputs ?

hi,  how can i feed the model batch inputs ? i just know how to feed one audio to the model,but if i want to feed batch?can you tell me ? thanks.

+1

hi bros, I feed model batch inputs through the following steps.

just save the results of vggish_input.wavfile_to_examples() on your dataset.

finetune model
`class FintuneModel(nn.Module):
def init(self):
super(FintuneModel, self).init()
urls = {
'vggish': "https://github.com/harritaylor/torchvggish/releases/download/v0.1/vggish-10086976.pth"
}
self.pretrain = vggish.VGGish(urls, preprocess=False, postprocess=False)
self.classifier = classifier()
def forward(self, x):
"""
:param x: [bs, num_frames, 96, 64]
:return:
"""
bs, num_frames, _, _ = x.size()
x = x.view(bsnum_frames, 1, x.size(2), x.size(3))
x = self.pretrain(x) # [bsnum_frames, 128]
x = x.view(bs, x.size(1), num_frames)
x = self.classifier(x)
return x
`

@Chevalier1024 Is x.size(0) the bz?

@Chevalier1024 so each batch has a different number of samples?

@Chevalier1024 I tried this but inference time doesn't improve at all.


Failed to DBDelete(): java.lang.NullPointerException:

php ./example.php
Deleting DB...
Failed to DBDelete(): java.lang.NullPointerException:

Hi.
Could you please provide more information about version of OrientDB and OrientDB-PHP.

AntonTerekhov-OrientDB-PHP-07b69f4
orientdb-graphed-1.0rc8
PHP 5.3.5-1ubuntu7.4 with Suhosin-Patch (cli) (built: Dec 13 2011 18:30:11)
php ./example.php (use cli )
2012/2/10 Anton Terekhov
<EMAIL_ADDRESS>
Hi.
Could you please provide more information about version of OrientDB and OrientDB-PHP.

Reply to this email directly or view it on GitHub:
https://github.com/AntonTerekhov/OrientDB-PHP/issues/8#issuecomment-3902693

Ok, I'll take a look..

Thank you!
2012/2/10 Anton Terekhov
<EMAIL_ADDRESS>
Ok, I'll take a look..

Reply to this email directly or view it on GitHub:
https://github.com/AntonTerekhov/OrientDB-PHP/issues/8#issuecomment-3902796

Seems its Orient related issue. Will wait them to fix it


test(kernels::grisubal): add coverage using basic geometries

add basic tests for capturing steps of the algorithm
Scope

[x] Code: if relevant, add affected target

Type of change

[x] Testing

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.86%. Comparing base (80fc822) to head (312d5a5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   74.35%   79.86%   +5.50%
==========================================
  Files          31       31
  Lines        3744     3873     +129
==========================================
+ Hits         2784     3093     +309
+ Misses        960      780     -180

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Convert into a pfSense package

Hello,
I really like this installer, but I would love to see it as a real pfSense package.  It would be very useful for myself (and I suspect others) to be able to manage Unifi via the pfSense web UI and leverage the provided functionality from the UI and package manager.  I would be happy to contribute to making this happen, but I'd first like to ask if the maintainers and users of this project would be interested in this goal as well?
Cheers!

Something like such a package exists:
https://www.freshports.org/net-mgmt/unifi5/
It likely meets many needs.


LocksmithError Code=3 "The operation couldn’t be completed.

Hello,
I'm using the 2.0 branch and I'm receiving this error:
Error Domain=Focused_on_Training.LocksmithError Code=3 "The operation couldn’t be completed.
do {
        try Locksmith.saveData(["password": "\(pwd)"], forUserAccount: "\(currentUser.username)", inService: "FocusedOnTraining")

    } catch let error as NSError {
        print("\(error)")
    }

Thanks for your assistance.

Hmm not sure sorry. Does it work if you hard-code some strings in for pwd and currentUser.username? What are the types of these values? In particular, you might get strange results if they are optionals.

They are strings, I have tried hardcoding some strings and receive the same result. Does code 3 mean anything?

What OS/device/SDK version?

Also if possible could you please attach a sample project that shows the issue? :)

I didn't realize that there is an .updateData method. I'm saving the data after the user signs in. Hitting this after deleting/installing during testing. Keychain entry already exists the second time! Closing.. Thank you!

I got stuck on this too. Would be helpful if you could add a quick note to the readme explaining the difference between updateData and saveData :smile:

@adrianmacneil great idea! Just added this, but let me know if you think the issue could be expressed more clearly (I wasn't super happy with what I came up with). Thanks for the suggestion! :)


Metrics Documentation Outdated Re: /cookie_sync endpoint metrics

The "/cookie_sync endpoint metrics" section of the Metrics documentation seems to be out of date.
It lists cookie_sync.<bidder-name>.gen and cookie_sync.<bidder-name>.matches as available metrics, but neither seems to be available anymore, and it looks like they were removed:

https://github.com/prebid/prebid-server-java/issues/2114
https://github.com/prebid/prebid-server-java/pull/2065

In particular, https://github.com/prebid/prebid-server-java/pull/2065/files#diff-fcd88b249295823c1877f78f5e06d5c8119384d522032b15eecca80b7bb24d55L80-L81

Submitted PR for adjusting the documentation at: https://github.com/prebid/prebid-server-java/pull/3016

Closing this issue as the PR with the update was merged. Thanks for your contribution, @kuleszaj


WIP implementation of better cross joins

This PR implements a new way to perform "complex" joins where the joining condition is not in the form a = b or a = b AND c = d AND ... but can have any form.
In general, there is no other way than to perform a full cross join and test the condition on each resulting row. Before this PR, this was done by copying all data to the same machine (bad!) - this PR introduces a distributed cross join by joining every partition with every other partition. After that, the join condition is applied as a filter.
Maybe this solves the issue #148
This still has the big problem of first producing many output rows and then (hopefully) filtering down, but I do not see any other way to do this.

Codecov Report

Merging #150 (288dd01) into main (d576109) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              main     #150      +/-   ##
===========================================
- Coverage   100.00%   99.89%   -0.11%
===========================================
  Files           52       52
  Lines         1953     1965      +12
  Branches       266      267       +1
===========================================
+ Hits          1953     1963      +10
- Misses           0        2       +2

Impacted Files
Coverage Δ

dask_sql/physical/rel/logical/join.py
100.00% <100.00%> (ø)

dask_sql/input_utils/hive.py
90.00% <0.00%> (-10.00%)
:arrow_down:

dask_sql/utils.py
100.00% <0.00%> (ø)

dask_sql/physical/rel/custom/predict.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d576109...288dd01. Read the comment docs.


Nil compilation error when dividing even though checking for Nil

Hey,
I get an undefined method '/' for Nil (compile-time type is (Int32 | Nil)) at day/7 when trying to divide a variable by an Integer, even though I am explicitly doing a Nil check beforehand.
class MyClass
  property day : (Nil | Int32)

  def initialize(@day = nil)
  end

  def some_method
    # no matter what check I add, doesn't work
    return if day.nil?
    unless day.nil?
      if day
        day/7
      end
    end
  end
end
puts MyClass.new(13).some_method

Same thing if I remove the property and use the instance variable directly. def initialize(@day : (Nil | Int32) = nil)
Any thoughts on this?
Crystal 0.22.0 (2017-04-20) LLVM 4.0.0

try this way
class MyClass
property day : (Nil | Int32)
def initialize(@day = nil)
end
def some_method
# no matter what check I add, doesn't work
return if day.nil?
unless day.nil?
if tday = day
tday/7
end
end
end
end
puts MyClass.new(13).some_method

The behaviour is described in docs: https://crystal-lang.org/docs/syntax_and_semantics/if_var.html
Of course, any check will work - return, unless, not just if,  just assign to local variable instead of checking a property.

Ah, interesting, I wasn't aware of the difference between instance and local variables in this case. Thanks!

You were not even using an instance var (at least not directly), but an instance method.

Shorter code:
class MyClass
  property day : Int32?

  def initialize(@day = nil)
  end

  def some_method
    return unless day = @day
    day / 7 # it will use the variable defined above
  end
end

puts MyClass.new(13).some_method

@bew You made my stream rainbow-ish, thanks! :)


laravel-mix-polyfill require statements not handled by babel

Laravel Mix Version: 4.1.4
Node Version: v12.10.0
NPM Version: 6.10.3
OS: macOS Mojave 10.14.6 (18G84)

Description:
laravel-mix-polyfill inserts require statements for all core-js packages needed according to our browserlist, but these are not handled by babel, and show up in the compiled es5 code, throwing errors in the browser.
The compiled code looks like the following:
"use strict";

require("core-js/modules/es.symbol");

// a lot more requires omitted...

require("core-js/modules/web.url.to-json");

function _typeof(obj) { if (typeof Symbol === "function" && typeof Symbol.iterator === "symbol") { _typeof = function _typeof(obj) { return typeof obj; }; } else { _typeof = function _typeof(obj) { return obj && typeof Symbol === "function" && obj.constructor === Symbol && obj !== Symbol.prototype ? "symbol" : typeof obj; }; } return _typeof(obj); }

/******/
(function (modules) {
  // webpackBootstrap

// etc...

This of course throws the following error:

coffeescript:3 Uncaught ReferenceError: require is not defined

It feels like things are happening in the wrong order, since babel has no issue handling both import and require statements in our code, but the inserted require statements (that according to the babel docs should be inserted as imports) are ignored by babel when transpiling.
Steps To Reproduce:
package.json
{
  "name": "test",
  "version": "1.0.0",
  "scripts": {
    "dev": "yarn run development",
    "development": "cross-env NODE_ENV=development node_modules/webpack/bin/webpack.js --progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js",
    "watch": "yarn run development --watch",
    "prod": "yarn run production",
    "production": "cross-env NODE_ENV=production node_modules/webpack/bin/webpack.js --no-progress --hide-modules --config=node_modules/laravel-mix/setup/webpack.config.js"
  },
  "devDependencies": {
    "@babel/core": "^7.6.0",
    "@babel/plugin-transform-runtime": "^7.6.0",
    "@babel/preset-env": "^7.6.0",
    "babel-loader": "^8.0.6",
    "core-js": "^3.2.1",
    "cross-env": "^5.2.1",
    "css-loader": "^3.2.0",
    "laravel-mix": "^4.1.4",
    "laravel-mix-polyfill": "^1.1.0",
    "sass": "^1.22.12",
    "sass-loader": "^7.3.1",
    "vue-template-compiler": "^2.6.10",
    "webpack": "^4.40.2",
    "webpack-cli": "^3.3.9"
  }
}

webpack.mix.js
let mix = require('laravel-mix');

require('laravel-mix-polyfill');

mix.options({
        processCssUrls: false,
        uglify: false
    })
    .polyfill({
        enabled: true,
        useBuiltIns: "usage",
        targets: "> 0.05%, not ie < 10, safari >= 8",
        corejs: 3
    })
    .js('src/js/app.js', 'public/js/app.js')
    .babel('public/js/app.js', 'public/js/app.js')
    .sass('src/scss/style.scss', 'public/css/style.css')
    .copyDirectory('src/fonts', 'public/fonts')
    .copyDirectory('src/images', 'public/images')
    .disableNotifications();

Has anyone else experienced this issue?
Any help is greatly appreciated!

This question has an open bounty worth +50 reputation on Stack Overflow, ending in 4 days


Make sticky menu

Set sticky menu on mobile
design-1
design-2
design-3

Fix menu jumping on search opening


Fix password recovery for shops with urls like /de

1. Why is this change necessary?
Passwort recovery don't works for domains like "https://www.my-shop.at/de".
2. What does this change do, exactly?
Fix missing /de for validating the form data of the password recovery.
3. Describe each step to reproduce the issue or behaviour.
Our domain setup of our sales channel:

https://www.my-shop.at/de
https://www.my-shop.at/en

-> No domain with https://www.my-shop.at is set!
Now when we try the password recovery on one of the domains - it don't works because it validates the storefrontUrl "https://www.my-shop.at" to that non existing domain.
We changed it, that it sets the storefrontUrl as "https://www.my-shop.at/de" and not "https://www.my-shop.at".
4. Please link to the relevant issues (if any).
5. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Upsi my fault :see_no_evil:
Can you fix it for all occurrences?
https://github.com/shopware/platform/search?q=attributes->get('sw-sales-channel-absolute-base-url')&unscoped_q=attributes->get('sw-sales-channel-absolute-base-url')
Also pls update your fork. You still use travis, we are on Github Actions :)

@shyim this is because the PR is targeting the master branch :wink:
we haven't merged back the 6.2 branch yet

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-9326
Please use this issue to track the state of your pull request.

Thanks! @acris-cp
I've refactored and documented it a bit, to hopefully prevent theses issues in the future.


Target .NET MAUI instead of Xamarin

As a developer, I want ReactNative for macOS + .NET to target .NET MAUI instead of Xamarin so that it will continue to build after Visual Studio for Mac disappears.

Targeted .NET 8 and React Native 0.71.


Add out-of-order sample support in TSDB

This is a placeholder PR to see how can we break down into smaller PRs.
DO NOT MERGE
cc @jesusvazquez

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 3 committers have signed the CLA.:white_check_mark: jesusvazquez:x: Dieterbe:x: codesomeYou have signed the CLA already but the status is still pending? Let us recheck it.

https://github.com/grafana/mimir-prometheus/pull/269 replaces this


Crash going to the Space Station from Planet.

Minecraft Version: 1.12.2
Forge Version:  2555
Advanced Rocketry Version:   ...-45
LibVulpes Version:  0.2.7-24
Is this the latest curseforge build?**  Yes
Crash Report:  https://pastebin.com/uNGs8Uvn
Explain issue in detail:
I built a second space station.
Its ID chip and package are in my inventory.
I built two rockets.
I copied my used space station ID chip.
Put a copy in each rocket.
Launched the first rocket and let it fly off without me.
I got in the second rocket and rode it to orbit.
Crash occurs when I reach orbit.
Relog has me land on the pad I took off form.
I think the first rocket is on the only docking pad on the station (that has a linker in it) and the second rocket won't fly to the origin area as the documentation claims.
Edit:
First rocket sent landed in the default area.
The docking pad on the station has a linker in it.
Successfully got the second rocket to the station after removing the ID chip and putting a linker set to the docking pad on the station in the docking pad under the rocket.
IMarv
PS, I added a video to #1031 showing that the issue does not appear to be fixed, at least for me.

Is this still a issue? Please comment if it is and i will reopen if if you are unable? We are closing old issues to see what is still relevant and needs to be fixed.


[Event Hubs] Send/Receive Quickstart Tweaks

Summary
The purpose of these changes is to adjust some verbiage to better reflect the prerequisites needed for the quickstart, clarifying that the SDK tooling is
being discussed and not the target framework of the output.  Additionally, updated mentions of .NET Core to .NET to reflect that the library may be used to build both .NET Core and .NET framework applications and is the recommended Event Hubs library for both.
Last Upstream Rebase
Wednesday, May 20, 4:54pm (EDT)

@jsquire : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@spelluru:  For context, this was surfaced by the Azure CXP team in response to customer feedback.   A similar set of tweaks was made to the Event Hubs README in #11651.

#sign-off


timeout support for guild members

What type of pull request is this?

[x] Non-breaking code change
[ ] Breaking code change
[ ] Documentation change/addition

Description

Added a function to timeout a member and added communication_disabled_until to the Member class
Example of features:
@slash_command("timeout", "mute someone", scopes=[780435741650059264])
@slash_option("member", "person", opt_type=OptionTypes.USER)
@slash_option("unix_timestamp", "unixtimestamp.com", opt_type=OptionTypes.INTEGER)
async def mute(ctx: InteractionContext, member: Member, unix_timestamp: int):
    await member.timeout(unix_timestamp)
    await ctx.send(
        f"{member.mention} will be able to chat again {member.communication_disabled_until.format(TimestampStyles.RelativeTime)}"
    )

Changes

Timeout support

Checklist

[x] I've formatted my code with Black
[x] I've ensured my code works on Python 3.10.x
[x] I've tested my code

Ok, that was the last commit lol. I meant to rename a commit that I misspelled, but I wound up merging and stuff. Oops.

🎉 Excited for this. Thanks @Wolfhound905


feat: scroll tests docs

Created docs over Scroll unit and integration tests.
Also added happy paths over Scroll unit tests.

Resolved conflicts and pushed


Added parallelTraverse and filteredParallelTraverse to SceneAlgo

Reimplemented GafferScene::matchingPaths and GafferSceneTest::traverseScene using them.
This is the latest version of these changes, hopefully all of John's feedback is addressed.

Nice one - thanks...

I spotted a couple of minor issues after merging, which I've addressed in https://github.com/ImageEngine/gaffer/commit/33fa0df193e33f61514f4f24cc14c357135ca05a.


The active state is not cleared when releasing space key

Thanks for the report. Fixed 4e974dc

Released in 0.10.


Fix Fix some parquet readers bugs which introduced by #19758 'replace the single pointer with an array of 'conjuncts' in ExecNode'.

Proposed changes
Fix some parquet reader bugs which introduced by #19758 'replace the single pointer with an array of 'conjuncts' in ExecNode'.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Urgent: Exception

Hi,
This is very urgent. I am getting this exception on rendering gantt randomly.
Uncaught TypeError: Converting circular structure to JSON
at Object.stringify (native)
at eval (eval at evaluate (unknown source), :1:6)
at Object.InjectedScript._evaluateOn (:904:55)
at Object.InjectedScript._evaluateAndWrap (:837:34)
at Object.InjectedScript.evaluateOnCallFrame (:963:21)
at http://localhost:8080/lib/lib.js:122:267
at http://localhost:8080/lib/lib.js:351:172
at Object.fn (http://localhost:8080/lib/lib.js:239:30)
at m.$digest (http://localhost:8080/lib/lib.js:240:114)
at m.$apply (http://localhost:8080/lib/lib.js:243:12)
I can see $scope inside row which again has row object.
e.$scope.row.$scope.row.$scope

Did you solved this error ? I think you have a circular reference in your model (a loop in row child/parent).

it was because of duplicate row ids


Update chromium.br

Hello, it seems that current version of chromium.br file doesn't support node 16.x version. (eg. String.prototype.replaceAll is not supported in this version)
is there any official support for updating version of chromium?

I am not sure if it helps, but I am also getting this error

path: '/var/task/bin/chromium.br'7729e-a8a4-4127-8be1-67b69426b626    ERROR   [Error: ENOENT: no such file or directory, open '/var/task/bin/chromium.br']


Extract audio in PHP

Hello, when i use --extract-audio --audio-format mp3, the extensionof downloaded file is .webm always.
In terminal work's fine.Extract MP3, but in PHP not working.
Code: <?php echo exec("youtube-dl --extract-audio --audio-format mp3 https://www.youtube.com/watch?v=VIDEO_ID "); ?>
THANK YOU.

Carefully read new issue template and provide all requested information.


Fix failed receipt.

We noticed a few evm-tests failing (such as Create2OOGFromCallRefunds_{16, 17}) when the logs are non-empty and the status of the transaction is 0. This is because we set the length of the logs to 0 but not their payload's length, which is later used for encoding the receipts. This PR fixes this by setting the logs' payload length to 0 when the status is 0.

Also fixes the similar variants for Create, and the failing CreateOOGFromEOARefunds ones :)


How to calculate fid score with label

when I try to test a model with label condition inside with fid_score, it throws:
`  File "fid_test.py", line 40, in
a, b = pytorch_fid.fid_score.calculate_activation_statistics(fid_files, G, 4, 1024, 'cuda')

File "/home/lbh/anaconda3/envs/torch_py3.7/lib/python3.7/site-packages/pytorch_fid/fid_score.py", line 228, in calculate_activation_statistics
act = get_activations(files, model, batch_size, dims, device, num_workers)

File "/home/lbh/anaconda3/envs/torch_py3.7/lib/python3.7/site-packages/pytorch_fid/fid_score.py", line 136, in get_activations
pred = model(batch)[0]

File "/home/lbh/anaconda3/envs/torch_py3.7/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1194, in _call_impl
return forward_call(*input, **kwargs)

TypeError: forward() missing 1 required positional argument: 'y'`
I am wondering where I can input my label inside.

FID score does not use or need labels to compute, so I don't quite understand the question.


SPM support

hello, any plans to support SPM?

Hi, recently I was studying the SPM and Carthage manager in my spare time, and planning to support them in a few weeks. Feel free to submit PRs if you could help me implement it!


7996: Always on Top setting does not persist

Summary of the Pull Request

References

PR Checklist

[x] Closes https://github.com/microsoft/terminal/issues/7996
[x] CLA signed.
[ ] Documentation updated - irrelevant
[ ] Schema updated - irrelevant
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments
Currently the value of AlwaysOnTop is read by the AppHost from AppLogic that takes this value from the root TerminalPage. However at this stage neither AppLogic nor TerminalPage are initialized, and thus the return value is always false.
This PR introduces a "GetInitialAlwaysOnTop" method to AppLogic that returns a value that is configured in the settings.
In addition, the TerminalPage creation was fixed to read the configuration value upon creation (and not just after settings reload).

Validation Steps Performed

Only manual testing
Starting the system with both initial value set to true and false
Verifying that dynamic toggling on / off is not affected

This approach introduces an additional method to the AppLogic. I have another PR in my repository, where I don't introduce a new method but rather change the behavior of the existing one to fallback to the default setting if the root page is not initialized yet. I didn't push this change here, since I liked the explicit one more :smile:.
Yet please take a look there if you like the second approach more: https://github.com/Don-Vito/terminal/pull/2


Hope it can support Vue3 and Nuxt3

Thankyou for supporting Vuesimple.
I am currently working on migrating Vuesimple to support vue3.
Thankyou for your patience! 🙏

Vuesimple is available for Vue3.
Branch:  Vue 3 - v3/next Version: 3.0.5+
Closing this! 🙏


Feature/revision requests

I have added SugestedEdit and Revision including all related requests

I fixed the parts you mentioned. There are some more problems (documentation of completion handlers), but let's fix them in an other branch


Product page refactoring for theme 2.0

This is the initial plan to refactor the Product.vue page accordingly to #2696 and after the initial learnings we got from the Category.vue refactoring (#2890)
The goal is to prepare the Product.vue for Theme 2.0 - based on Storefront UI but without dramatic changes, keeping the business logic as is (it's very important assumption) and share it between product and product-next modules. The same time: improving the Vuex readability, preparing the Product page data interface for the 2.0
Stage 1: to be finished till end of July (preferred date: 3rd week of July)

Create the product-next module for the consistency with category-next - use only those new one’s in the new Product.vue and Category.vue
We should re-use as much the original logic of product module as we can: via helpers or just via importing the actions directly from the old module (doing that way we don’t have to create additional dependencies and can just do like: import { list } from @vue-storefront/store/modules/product/actions`
Add suitable getters with the proper naming convention -and don’t use the state directly in the theme (just only thru getters)
We don’t touch the business logic: product/helpers and the actions like setupBreadcrumbs, setupAssociated, actions related with bundle etc. Maybe just some minor refactoring like:

avoiding state mutations directly in actions (move to mutations)
remove rootStore references,
limit the logic based on events

Don’t change the state much - to keep the single code base with product 1.0 module as far as we can:

we must keep current, original, parent
we must keep current_bundle_options, current_custom_options, custom_options_validators
we can remove (from both - original and new module): productLoadStart, productLoadPromise, productGallery (or if not, rename it to keep the convention which is under_scored)
remove color and size from current_options - change the theme to not access this property ditrectly but via getter
we can remove list -> but we must refactor the action product/list (extract to helper which returns the data + mutate the state after helper is executed in the original product/list; in the product-next/list (or whatever different name it will have) we can remove this state property as the list ist now in the category)

Rename getters to the proper naming convention:

getParentProduct,
getCurrentProduct
getCurrentProductConfiguration
getOriginalProduct
getCurrentProductOptions
getCurrentProductGallery
getCurrenntProductBreadcrumbs
...

Refactor Product.vue + remove the core/pages/Product.js dependency

map getters with the right getters- https://github.com/DivanteLtd/vue-storefront/blob/70543b3cfa379971220f6514348fe0386a108878/core/pages/Product.js#L25
attributesByCode and attributesByid seems to not being used anymore and can be removed
shall we have this.product or this.getProduct (as getter suggest)?
productName, productId - should be probable replaced with just product.name and productid in the theme
customAttributes ->replaced with vex getter getCurrentProductCustomAttributes or just getCustomAttributes mapped to custom_attributes (as it’s related to the page context only)
Wishlist and Compare should be moved to smart components - the one’s that uses the Vue to perform the logic, but product page shouldn’t be aware of them at all
isOptionAvailable could be moved to helper (called just from theme) or can stay here
onAfterCustomOptionsChanged, onAfterBundleOptionsChanged logic - to be moved to Vuex handler
onStateCheck to be removed - the parent check moved to the Vuex
check when onAfterPriceUpdate is called (tier prices probably) and check if we can remove it (probably we can move it to vuex + modify tier prices to call this vex action instead)
Not sure if we can move onAfterFilterChanged to vex as it replaces parts of url but probably we can
Remove onUserPricesRefreshed - I mean call asyncData or other vex method instead

Refactor the product/actions and product/helpers

replace state read operations with getters
replace state write operations with mutations
Extract network call from syncPlatformPricesOver to helper and then data resolver - remove the callback_event (it’s not used)
In the new module product-next remove the setCurrentProduct and selectDefaultVariant from product-next/single or its equivalent - the logic of product-single should be shared between old and new product modules helper or import; old action should emulate these parameters new one - should just return product data (setting current product should be in different vex action - related to the product page only)
product/list should not updateState - i mean the new version should not update the state, just return the final data + do caching the category-next current call to product/list should be replaced with the new method
related, setCurrentOption, setCustomOptions  and setCurrentErrors are not used and can be removed
fetch and fetchAsync should be merged into one call loadProduct or fetchProduct that will be used in the Product.vue

@filrak, @patzick, @lukeromanowicz - this one is for discussion next week and to start right after #2696 (from 1st of July probably) and hopefully, finish it in the 3rd week of July

update: setupBreadcrumbs can be re-used from the category-next after refactor @patzick

shall we have this.product or this.getProduct (as getter suggest)?
this.product -> getter should get product data and assign to product local var.

Also shouldn't we have a general breadcrumbs module to not limit them to product/cat? I think it'd be better for SEO

getParentProduct & getOriginalProduct seem very similar and not straightforward to understand what those getters are holding.

@patzick I've retested everything in #3217 and the product page overall:

regarding issues which you couldn't reproduce - I couldn't as well, so I think these no longer occur,
all fixes work fine,
I just found one problem related to #2733 - in the offline mode, we cannot add any product to the cart due to hanged availability check - there are loading circle and inactive button visible till we go back to the online. Should I reopen #2733?

Thanks @GabiDivante it works just fine on demo: https://demo.storefrontcloud.io/gear/gear-3/sprite-yoga-companion-kit-45.html

@pkarw I changed my endpoints to https://demo.storefrontcloud.io/api/ but I also have problem with addin a bundle product to the cart.
Error from dev console:
mutations.ts:100 Deprecated mutation CATALOG_UPD_BUNDLE_OPTION - use PRODUCT_SET_BUNDLE_OPTION instead

@alinadivante ok cool, so this will be easy to fix - @patzick


update stripe elements url

localized links are broken on https://stripe.dev/elements-examples/

seems like there's already  a pr out for this. closing.

Thanks for opening anyways! :) @colineforde


jquery bootstrap issue

Found an issue or bug? Tell me all about!
I can't add bootstrap or jquery to this.
Describe the issue / bug.
#
I've seen issue 36 here:
https://github.com/SimulatedGREG/electron-vue/issues/36
Which refers to adding a jquery link  to the webpacj.config.js like:
new webpack.ProvidePlugin({
$: "jquery",
jQuery: "jquery"
})
But there is no webpacj.config.js that I can determine. I presume I need to add something similar to one of the other webpack files - either main or renderer, but I still get the error saying that bootstrap requires jquery?
Any suggestions?
Thanks.

I haven't gotten to the root of this problem as webpack still sounds like voodoo incantations to me but here's my trick to temporarily avoid this problem:
With bootstrap and jquery files resting in app/dist, here is my index.ejs
<script src="js/jquery.js"></script>
<script>
    try {
        $ = jQuery = module.exports;
        // If you want module.exports to be empty, uncomment:
        // module.exports = {};
    } catch(e) {}
</script>
<script src="js/bootstrap.js"></script>

Not the best solution but it works for now.

Glad someone else has this problem - I don't grok web pack at all!
So adding that to the index.ejs seems to work in the sense that my content loads and I get no jquery errors. However, bootstrap tabs within a vue component are not rendering. Do I have to import the bootstrap CSS within the vue component do you know?
Thanks for your help.

It's only that weird jquery bundling issue that infests me. CSS importing works as expected in both the index.ejs or in one of your components. (Indeed I do import the bootstrap.css in my App.vue. Ideally all the js should also be imported there at App.vue but couldn't figure it out yet.)
BTW none of this is a electron-vue issue, what we're experiencing are webpack intricacies.

Embarrassingly this was my error on the bootstrap side. This has fixed it, but I am no further on understanding really how web pack is working here.
I'd like to add additional libraries but webpack seems poorly documented for noobs like me! Thanks for your help. I will leave this issue open as - to my mind - it is currently resolved with a hack, not a webpack compatible solution.

Sorry for the late reply everyone, but yes this is not a direct issue with electron-vue and more related to how webpack will handle things. The important part for bootstrap is that it needs to be able to access jQuery from the window.
@utkukaratas's recent comment is probably the closest solution to get this working with original software. But if you want a more proper Vue solution, take a look at http://yuche.github.io/vue-strap/.

Gonna go ahead and close this. Feel free to ask any other questions.

Took me quite a while to get Bootstrap working so i thought I'd share it..with Bootstrap 4 alpha 6, I added this to both webpack.render.config.js and webpack.main.config.js under "plugins:"
new webpack.ProvidePlugin({
   $: "jquery",
   jquery: "jquery",
   jQuery:"jquery",
   "Tether": 'tether',
   "window.jQuery": "jquery",
    "window.Tether": 'tether'
})

Also did what Greg suggested in issue #36 to .eslintrc.js. And adding import for jQuery and Tether in main.js before importing bootstrap.js.

Thank you guys 👍


Update tests to handle new gas values.

Description
Tests are failing with messages like:
Transaction gas limit provided '21000' is insufficient of intrinsic gas required '23176'

Steps to reproduce
Run the tests in CI.  This was discovered while cutting a release.
Additional context
No response
Hedera network
other
Version
v.0.4.0
Operating system
macOS

Closing as fixed


.NET Standard support?

Supporting platform is .NET 5, .NET 6.
README.md

I know this library currently supporting platform is .NET 5, .NET 6.
Could you have a plan to supports .NET Standard?

OK, I've released 1.3.0 that supports .NET Standard 2.0 and 2.1.


STMeta Dataset

An error occurs when I run the /UCTB/Experiments/CustomizedDemo:
that is:
{'graph': 'TopK', 'MergeIndex': '12'}
Downloading data into ~/anaconda3/envs/UCTB/lib/python3.6/site-packages/UCTB/data
HTTP Error 404: Not Found
I checked that I can't download metro_shanghai dataset, how can I obtain this dataset?

An error occurs when I run the /UCTB/Experiments/CustomizedDemo:
that is:
{'graph': 'TopK', 'MergeIndex': '12'}
Downloading data into ~/anaconda3/envs/UCTB/lib/python3.6/site-packages/UCTB/data
HTTP Error 404: Not Found
I checked that I can't download metro_shanghai dataset, how can I obtain this dataset?

Hi, Vickliet~
I'm sorry to tell you that the Metro Shanghai dataset couldn't be open since we haven't got the licenses to release it.
If you want to perform GNNs on your customized graphs, you could modify the data loader parameters and conduct experiments on the Bike datasets.
If you want to obtain metro crowd flow data, we recommend you collect it on your own. Recently, a website provides the metro crowd flow data in Beijing. See the  https://bjsubway.jinzihao.me/ for more details.


[DNM] drivers: spi: Add shim for nrfx SPIS driver

This adds a translation layer to make the nrfx driver for the nRF SPIS
(SPI Slave with EasyDMA) peripheral accessible via the Zephyr's API.
Depends on #6985, in particular on the commit bb66f3f3704ed3adcda7e46c8125fed2c54af91f.

@tbursztyka I have some doubts regarding spi_context:

In slave mode it does not automatically release the lock, you need to explicitly call spi_release before calling spi_transceive again. Is it still intented? The expected behavior is not documented. IIRC it was earlier, but it is no longer after the last update.
It returns properly the number of received frames (ctx->recv_frames) only in a synchronous operation. In an asynchronous one this value should be passed as the parameter to k_poll_signal, because when spi_transceive_async returns, it is not known yet.
When you provide both master and slave implementations, ctx->recv_frames is counted in both modes (even if they are done in separate code, like in the nRF case), and not used then for master. Wouldn't it be better to leave it to particular slave implementations to provide this value in the most convenient way for them? As you can see here, in nRF implementation I can get it from a peripheral register after the transfer is done.

@anangl

That was the intention indeed, but it's a left-over of the first slave attemps. will get rid of that behavior.
yep that's was forgotten
why not, but that was just super simple to do it in spi_context.h (and actually, it makes things easy for the previous point)

Will send patches

is this still DNM?

@nashif Now that #6985 is merged, this one is no longer a DNM.

Added one more commit that updates the default configuration for 96b_carbon_nrf51.

@anangl there's still an unanswered question from @galak about why the IRQ number is not coming from DT. I assume  you will send a PR to switch SPI to DT later?

@carlescufi I have one PR being prepared for moving all spi (controllers & devices) to DT.

@carlescufi Yes, that was the plan. And I answered the same question from @galak in #6985. I forgot about the one here.
But now I'll wait for the PR from @tbursztyka.

@anangl ok, so if you fix CI we can merge this then

Added a commit that made CI green. Ready to merge, I guess.


python311Packages.dissect: 3.8.1 -> 3.9

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 257618 run on x86_64-linux 1

50 packages built:

python310Packages.dissect-clfs
python310Packages.dissect-clfs.dist
python310Packages.dissect-cstruct
python310Packages.dissect-cstruct.dist
python311Packages.dissect-cim
python311Packages.dissect-cim.dist
python311Packages.dissect-clfs
python311Packages.dissect-clfs.dist
python311Packages.dissect-cstruct
python311Packages.dissect-cstruct.dist
python311Packages.dissect-esedb
python311Packages.dissect-esedb.dist
python311Packages.dissect-etl
python311Packages.dissect-etl.dist
python311Packages.dissect-eventlog
python311Packages.dissect-eventlog.dist
python311Packages.dissect-evidence
python311Packages.dissect-evidence.dist
python311Packages.dissect-executable
python311Packages.dissect-executable.dist
python311Packages.dissect-extfs
python311Packages.dissect-extfs.dist
python311Packages.dissect-fat
python311Packages.dissect-fat.dist
python311Packages.dissect-ffs
python311Packages.dissect-ffs.dist
python311Packages.dissect-hypervisor
python311Packages.dissect-hypervisor.dist
python311Packages.dissect-ntfs
python311Packages.dissect-ntfs.dist
python311Packages.dissect-ole
python311Packages.dissect-ole.dist
python311Packages.dissect-regf
python311Packages.dissect-regf.dist
python311Packages.dissect-shellitem
python311Packages.dissect-shellitem.dist
python311Packages.dissect-sql
python311Packages.dissect-sql.dist
python311Packages.dissect-squashfs
python311Packages.dissect-squashfs.dist
python311Packages.dissect-thumbcache
python311Packages.dissect-thumbcache.dist
python311Packages.dissect-util
python311Packages.dissect-util.dist
python311Packages.dissect-vmfs
python311Packages.dissect-vmfs.dist
python311Packages.dissect-volume
python311Packages.dissect-volume.dist
python311Packages.dissect-xfs
python311Packages.dissect-xfs.dist


Fix :unfly command not working when SignalBehavior is set to Deferred

Resolves #1435
When the :unfly command deletes the flying script and related values, the flying script relies on the DescendantRemoving event to detect when the script and related values are being destroyed by the command.
Because of how the Deferred SignalBehavior works, the DescendantRemoving event will be deferred and will not fire before the script is destroyed and all of it's connections disconnected, meaning the event is disconnected before it is fired. A solution, as the one I've committed to the script, is to use RBXScriptSignal:Wait() which will continue to fire immediately instead of being deferred.
The linked video below records three play tests, which in order demonstrate:

The current implementation of the code running with Deferred SignalBehavior, to provide evidence of the bug's existence.
The new implementation of the code running with Deferred SignalBehavior, to demonstrate that the fix works.
The new implementation of the code running with Immediate SignalBehavior, to demonstrate that this fix does not break Immediate SignalBehavior for games that may still be using it.

Video Demonstration:
https://streamable.com/o7ckds

very nice demonstration. 10/10


buildStackProject: Set __noChroot to make it fail without sandbox

Motivation for this change
Currently buildStackProject doesn't have any indication that it needs the sandbox to be disabled, leading to a hard-to-decipher error, see https://github.com/NixOS/nixpkgs/issues/32005
With this change, doing a buildStackProject will result in
error: derivation '/nix/store/nk4wms3hk4mp9lc86k30vc8w44fcq0rj-foo.drv' has
  '__noChroot' set, but that's not allowed when 'sandbox' is 'true'

when attempting to build it without --option sandbox false
Fixes #32005
Things done

[x] Made sure this error happens without disabling the sandbox

@Infinisil Thanks for this change.  I was actually thinking of doing this myself.
I think this is okay as-is, if you'd like to go ahead and merge it.
However, if possible, I think it would be nice to add a little more documentation.  For example, either linking to the nix manual where it talks about __noChroot, or alternatively just adding a small example of running nix-build with sandbox set to relaxed.
As a new user, at one point I came across __noChroot and had no idea what it meant or where I could find more information about it.

Added a bit more comment and docs

Thanks! Looks really good!


Debounced Search for Better Responsiveness

Hey @neurosnap,
I've made a tweak to the search input. Instead of updating the search every single time a user types, I've added a short delay of 150ms. This means the search will only update once the user has paused for a tiny bit. It's a small change, but it really helps in cutting down the lag, especially when the search has some heavy lifting to do on the client side.
Thanks!

Hi!  Thanks so much for your contribution.
What do you think about a throttle instead of a debounce?


Code Folding behavior

Please see the GIF

RAD can fold from INTERFACE keyword to the non-empty line right before IMPLEMENTATION keyword.

Fixed Object Pascal highlighter and painting.


go version
go version devel +3cab476 Sun Jun 21 03:11:01 2015 +0000 windows/amd64

go env
set GOARCH=amd64
set GOBIN=
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=d:\apps\go\gopkg
set GORACE=
set GOROOT=d:\apps\Go\gotip
set GOTOOLDIR=d:\apps\Go\gotip\pkg\tool\windows_amd64
set CC=gcc
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0
set CXX=g++
set CGO_ENABLED=1

This is patch will fix the issue:
https://go-review.googlesource.com/#/c/11316/

go get github.com\chai2010\tiff
cd github.com\chai2010\tiff\testdata\issues
go run issues-10596.go

invalid vendoredImportPath: dir="C:\\go\\gopkg.stable\\src\\github.com\\chai2010\\tiff\\testdata\\issues" root="." separator="\\"

Leaving this here for anyone else who comes across this issue.
I had to set this in system.env:
GO15VENDOREXPERIMENT=1
Commenting that line and saving system.env however produces this output:
C:/Go/bin/go.exe env [C:\Go]
set GOARCH=amd64
set GOBIN=
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=c:\work\code\go
set GORACE=
set GOROOT=C:\Go
set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64
set GO15VENDOREXPERIMENT=1
set CC=gcc
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0
set CXX=g++
set CGO_ENABLED=1
Command exited with code 0.
Notice that
set GO15VENDOREXPERIMENT=1
is still set.
You have to change the line in system.env:
GO15VENDOREXPERIMENT=0
This fixes the problem for me on Windows 10.


introduce concept of extra_dirs so some assumptions can be relaxed

currently the test dir is special cased in a couple places in the code so that you can have module source that is compiled and available but not included in the application itself. this makes {src_dirs, ["src", "test"]} work differently than {src_dirs, ["src", "any_other_dir"]} and leads to user confusion
i propose a new extra_dirs config value that has the default value of "test" and works exactly like it does currently but allows additional directories to be added and also allows "test" to be removed if the user wishes
i can get this done this weekend but i'd like feedback on what to do if a directory appears in both src_dirs and extra_dirs. i'm leaning towards it being an error that terminates execution but it might be better to have src_dirs take precedence over extra_dirs. would a warning be generated in the latter case?

Given directories like priv/ get automatically added to compiled applications, where would it fit? Is it neither source nor extra?

it's neither. extra_dirs would be for source files that you want compiled and available in path but do not want considered part of the application

extra_src_dirs might make more sense then, even if it's more verbose. I see nothing bad about the plan so far.

extra_src_dirs is a better name, agreed. i'll work up an initial pr and we can discuss the details

#439 has some basic tests and a working implementation for discussion

#439 got merged so closing this


I want to install microk8s by snap, but met this problem.

root@ubuntu:/etc/systemd/system# snap install microk8s --classic
error: cannot install "microk8s": Post https://api.snapcraft.io/v2/snaps/refresh: x509: certificate
signed by unknown authority
How can set the right certificate?

Hi @andyzheung
This like a snapd installation problem. I suspect you cannot install any snap. Could you ask at https://forum.snapcraft.io ? Here is a similar issue: https://forum.snapcraft.io/t/solved-cant-install-snaps-ubuntucore16-x509-certificate-has-expired/13470

thank you, I have solve the problem, by put our ca.crt  to /usr/local/share/ca-certificates/
and
#update-ca-certificates..
@ktsakalozos


Please merge revision 60c7a3d0abb5df3e833e15b279a0c0ff0fd39083 into dev channel

@ricowind @whesse @kasperl
Changes some async tests to improve stability.
60c7a3d0abb5df3e833e15b279a0c0ff0fd39083
This merged cleanly

Merged in version 1.12.0-dev.5.1


Confusing end of file error when I try to update files locally and have them sync with Shopify

What happened
Working within the Atom IDE, when I make a change to any file within the theme, I get output similar to the following and no update occurs:

What I expected to happen
For the desired file to be updated and the change reflected both locally within the browser and on Shopify within the admin section.
Steps to reproduce

Run slate via "npm run start:dev".
Make a local change in your favorite IDE.
Slate/Themekit attempts to sync and outputs failure.

My Environment
OS (including version): macOS High Sierra 10.13.6
Themekit version: slate and slate-tools v0.14.0
Ignore Files(if any): node_modules, dist, deploy.log

If you use another editor, this does not happen? This happens on all file?

It doesn't seem to matter what editor I use. I have been using Atom but also tried just manual changes with vi. Regardless of the file changed, the error is always the same - it complains about "themes/[theme_id]/assets.json".

What is assets.json anyway? It's not a file within the theme code itself, so I'm not sure where it is coming from. The theme seems to build just fine locally.

I am not sure, that seems more related to slate and not themekit. Maybe you should open an issue on https://github.com/Shopify/slate

Okay, thanks! I'll give that a try.

I think this will be taken care of by the Slate team and will have to be addressed when they update slate to the current version of themekit.


chore(ci): add prettier git commit hook

chore: :broom: format ymls with prettier
fix(ci): don't point to a rev

Badge doesn't seem to want to render. Issued opened: https://github.com/pre-commit-ci/issues/issues/19


Replace current_timestamp macro when a core functionality is implemented in dbt core

See https://github.com/elementary-data/dbt-data-reliability/blob/dd7d40b36937e012b62df07182160b1a5a02dd88/macros/utils/cross_db_utils/current_timestamp.sql#L3
It will prevent this warning
the `current_timestamp` macro is deprecated and will be removed in a future version of the package,
once equivalent functionality is implemented in dbt Core.
The elementary.metrics_anomaly_score model triggered this warning.

Thanks @rloredo !
I think it is now in dbt core (wasn't yet when @IDoneShaveIt made that change):
https://github.com/dbt-labs/dbt-core/blob/main/core/dbt/include/global_project/macros/adapters/timestamps.sql
I do see that there is some issue there with the old implementation (we are using) on Snowflake.
@oravi you worked on timestamps recently, can you say if we can make the change?

Hi @rloredo, just updating that we opened a PR that fixes it here and it should be released today

This is fixed and deployed already, closing this issue!


undefined on NavigationComponent

What kind of Issue is this?

(x) Bug Report
() Question / Problem
() Discussion / Feature Request

How are you using the Bottom Navigation?

(x) I use the Bottom Navigation together with react-navigation; the Issue is not appearing when I'm using react-navigation's TabBar instead.
() I use the standalone version.

Expected behavior
Will show tabbar with icons
Actual behavior
getting error undefined on render method of navigationComponent

Additional description and resources
export const SignedIn = TabNavigator(
  {
    Home: {
      screen: Home,
      navigationOptions: {
        tabBarLabel: "Home",
        tabBarIcon: ({ tintColor }) =>
          <FontAwesome name="home" size={30} color={tintColor} />
      }
    },
    Profile: {
      screen: Profile,
      navigationOptions: {
        tabBarLabel: "Profile",
        tabBarIcon: ({ tintColor }) =>
          <FontAwesome name="user" size={30} color={tintColor} />
      }
    }
  },
  {
    tabBarComponent: NavigationComponent,
    tabBarPosition: 'bottom',
    tabBarOptions: {
      bottomNavigationOptions: {
        labelColor: 'white',
        rippleColor: 'white',
        tabs: {
          Home: {
            barBackgroundColor: '#37474F'
          },
          Profile: {
            barBackgroundColor: '#00796B'
          },
        }
      },
      style: {
        paddingTop: Platform.OS === "android" ? StatusBar.currentHeight : 0
      }
    }
  }
);

export const createRootNavigator = (signedIn = false) => {
  return StackNavigator(
    {
      SignedIn: {
        screen: SignedIn,
        navigationOptions: {
          gesturesEnabled: false
        }
      },
      SignedOut: {
        screen: SignedOut,
        navigationOptions: {
          gesturesEnabled: false
        }
      }
    },
    {
      headerMode: "none",
      mode: "modal",
      initialRouteName: signedIn ? "SignedIn" : "SignedOut"
    }
  );
};

What did you do to find a solution?
I tried the example but this also happens

Environment

React Native versions: 0.49.5
react-native-material-bottom-navigation version: 0.5.2
react-navigation version: {1.0.0-beta.15}
I tested this with: {Android}

The BottomNavigation can't find your icon definitions, or rather your navigationOptions.
Are you sure you can put navigationOptions inside the RouteConfigs? To my knowledge, the navigationOptions have to be a static inside your screen class, cf.:
https://github.com/timomeh/react-native-material-bottom-navigation/blob/87adbe633b61260e77cfd4865e603c03aff939ae/example/ReactNavigationBottomNavigation.js#L12-L16
Try moving navigationOptions to your screens.
Also I'm a bit curious: you stated you tried it with react-navigation's own TabBar. Did it work with the TabBar? Using navigationOptions inside the RouteConfig sounds new to me.

@timomeh Yes, it was working with TabBar and actually its working now. I’m using functional components. I don’t know what happened. I might have done something wrong. Anyway, its fine now. Thanks for your awesome work.


Add wire target to login button

Can you explain what this PR improves?

Loading state on loading button

This PR is not needed as the loading indicator target is already grabbed from the form attribute of the button.


Unable to login in 2FA enabled account

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.63-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jasperhuangg
Slack conversation (hyperlinked to channel name): Expensify Bug
Action Performed:

Enter an email of the account for which 2FA enabled
Enter the magic code
Click on "Sign in"

Expected Result:
User taken to 2FA screen
Actual Result:
Nothing happens
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/06167f1b-7af1-4e0b-a800-170a57fdc14a
https://github.com/user-attachments/assets/4970f6e2-8034-4512-9010-e9ab2d2a7bfd
View all open jobs on GitHub

This is a BE issue, something is wrong with the SignInUser response

Yeah, was looking at the same:

@aldo-expensify Was caused by https://github.com/Expensify/Web-Expensify/pull/44422, namely because this block wasn't updated since instead of doing $response['onyxData'] = UserAPI::signInUser we're doing $response = UserAPI::signInUser.
cc @Julesssss @deetergp

@aldo-expensify Was caused by https://github.com/Expensify/Web-Expensify/pull/44422, namely because this block wasn't updated since instead of doing $response['onyxData'] = UserAPI::signInUser we're now doing $response = UserAPI::signInUser in api.php.

Nice, thanks @jasperhuangg . I think we should add DeployBlocker and remove DeployeBlockerCash

@aldo-expensify already did that :) PR incoming will request you for review

Feel free to ping me for the review. I assigned you to this issue.

@aldo-expensify https://github.com/Expensify/Web-Expensify/pull/44478 ready for review!

tested on staging, works well


Eventshub

Changes

/kind

Switch to using reconciler-test eventshub instead of the old recordevents from knative/eventing.

Release Note

Docs

this looks good, I wonder if it will pass now since #147 went in.

this looks good, I wonder if it will pass now since #147 went in.

/lgtm
/approve

/lgtm
/approve

/hold
watching the e2e tests.

/hold
watching the e2e tests.

hmm, still failing on the ko step

ko publish -B knative.dev/reconciler-test/cmd/eventshub
error attempting to ko publish: exit status 1
--- FAIL: TestKoPublish (0.06s)
panic: failed to produce images, exit status 1 [recovered]
	panic: failed to produce images, exit status 1

hmm, still failing on the ko step

ko publish -B knative.dev/reconciler-test/cmd/eventshub
error attempting to ko publish: exit status 1
--- FAIL: TestKoPublish (0.06s)
panic: failed to produce images, exit status 1 [recovered]
	panic: failed to produce images, exit status 1

/unhold
gonna try to fix

/unhold
gonna try to fix


Upgrade to latest OpenTracing API (v.0.13)

cc @oibe

approved, i don't see any other issues.

lgtm


list out of index error

its due to Cloudflare protection in store.rg.adguard site to fix this follow instruction from issue #6

added fallback api so no longer an issue


Sharing Findings Regarding HUD Fix

I have been following your work for a long while and I would be very glad to help you out with the HUD issues. Last week, I pulled the repo and tried a few things myself. The main issue I encountered was the health bar not showing the right value. I found that the red bar seems to be hidden unless overlayed with the actual health bar. By offsetting the hpmp_gauge by roughly 100 pixels the lost health bar reappeared.
Let me know if you have any further information that could help me with that, I'll continue researching if I find anything worthwhile.
Good luck on your future projects :)

This is helpful thanks. I think the issue is with the approach, at the moment I think the edits are happening too early and this is causing a cascading series of issues further down the chain of HUD processing. In that manner, I actually ended up gutting all the HUD fix code and rethinking things. I've added some WIP HUD work to the debug build, if you want to play around with it and see, just switch to the debug build and compile it.
So far, this new approach seems promising. There's no values being adjusted mid-load or anything like what was happening before. That was the part that was really flummoxing me before and I think it stemmed from changing things too early on. So far the major issue with this approach is that there is some clipping going on. I suspect that is probably a shared function so if I can find that and account for the HUD offset, I think it might solve that.
As you can see in this shot, there's way less overall issues (other than the clipping).

Thanks a lot for the info, I'll take a look at that build tonight!
Indeed, I see the clipping on 2D world elements like the sand effects. Have you tried using a graphics debugger like RenderDoc? It could be helpful in figuring out how the HUD and 2D elements are drawn with what parameters. If not, I can try it out.
If you have any general function offsets for IDA/Ghidra it would definitely help in finding out the functions that cause the issues.
Finally, if you have a public discord or something like to more easily share info I'll gladly join. I can even help for future projects :)
No worries about the salad ;)

Yeah I've used NSight to actually address the shadow resolution in the game. It was pretty helpful for finding out that the CSMs actually use a texture position offset that's hardcoded for 2048x2048 shadowmaps. So if you bump up the resolution of the shadowmaps, they look offset and blurry. I haven't found it too useful for 2D stuff in this game. In fact it seems like most of the UI rendering happens bit-by-bit instead of in batches, which seems untypical based on other games I've looked at.
I don't have any stuff mapped out in Ghidra or IDA. I've kind of skipped over using them since it's easier to rapidly prototype stuff with Cheat Engine and it's powerful auto-assembler. That said, once the full game is out, it probably would be a good idea to start working on an IDA database for the game. I have made note of some useful functions at least. I think a few of the ones I looked at previously for adjusting the HUD will prove useful later on when it comes to more granular HUD edits. Like I've seen people requesting to have the vignette at the edges of some elements removed.
I don't have my own Discord server, though I have thought about starting one! I do tend to hang about on the WSGF Discord though, so that's where I'm usually found.
I went back by the way and I was able to find where the HUD was being clipped. I'll push that commit in a bit once I polish it up. It's looking quite a bit better now.

By the time I finish work you'll be done with the HUD :P Great job on all that it looks very promising


ui-view autoscrolling issues (again...)

The behavior I'd like is that anytime a state is changed, the initial scroll position should be at the very top. From all the issues/support forums I've read, the proper solution is:

add autoscroll="true" to all ui-view
set $uiViewScrollProvider.useAnchorScroll();

However, even when I implement both of these, this only partially solves the problem. If the following sequence occurs:

Scroll down Page 1
Click link to Page 2
Click browser's back button to Page 1
Click on Page 3 from Page 1

The result is that Page 3 is scrolled down.
Here is an example: https://ovidlife.com/sell-my-policy - Scroll down to the orange buttons, click the first "Learn More", click browser back button, click second "Learn More". You will see the issue.
Any clue on how to fix this issue?

:+1:

Your example seems to work okay for me. If you need extra flexibility, you can replace $uiViewScroll with a custom implementation using $provide. We try to keep the issue tracker reserved for bugs and features only. Please take support issues to StackOverflow. Thanks. http://bit.ly/UIR-SOF

i also encountered this issue, just works for some pages, not all, even i have added autoscroll="true" to all ui-view and set $uiViewScrollProvider.useAnchorScroll();


Fix VS 2022 17.8 warnings/errors by defining _SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING

Longer term, we should upgrade fmt. Our copy is included in spdlog.
https://github.com/fmtlib/fmt/issues/3540

I'm merging this because every branch is broken without it after upgrading to VS 2022 17.8.


Drop rustc-serialize dependency

It has been deprecated: announcement.
Is there any functionality you would require from Serde or another library before this would be possible?

Off the top of my head no, I mostly use it for base64 & http encoding only.
I had in mind to update the dependencies anyway (url and hyper have changed a lot since I've used them) so I'll switch to serde at the same time.
Thank you for the heads up!

Done in https://github.com/MindFlavor/AzureSDKForRust/pull/14.


Move the file

...because?

Hey @bnoordhuis! The fact is that this folder may contain several template files, and one of them is: BUG_REPORT.md.


HSEARCH-1893 Fix and re-enable the performante integration tests

The missing task for HSEARCH-1893

I had to add the hibernate-search-testing dependencies to the Arquillian deployed performante test. It's using it, so I'm not sure why it would work before.
We had other cases in which WildFly10 shows to be much stricter than 8 and 9 with classloading, I guess it's one of those cases.

Seems it's not working correctly on Gunnar's machine:
org.hibernate.search.exception.SearchException: Unable to create index directory: /path/to/Development/hibernate-search/integrationtest/performance/./org.hibernate.search.test.jpa.Bretzel for index org.hibernate.search.test.jpa.Bretzel"

@gunnarmorling turns out this seems to be a rather nasty bug we had and nobody noticed!

This is now https://hibernate.atlassian.net/browse/HSEARCH-1945


does this engine use 100% original code?

i want to make my own standalone games and like upload on steam and stuff, and i like half-life styled engines because of their level editor and stuff, so does this use 100% original code which would mean possible to do that? not related to this is im wondering what is BSS that shaders use, i wanna make my own custom shaders and im familiar with opengl that it seems to be based on but i have never heard of BSS, hoping for an answer and thanks for making this

i looked in readme.txt and it says "Valve Software for the code referenced from the Half-Life SDK while developing this project." however half-life sdk doesnt allow anything to be used out of the half-life engine and is one of the main reasons why another project called xash3d isnt legal mostly

Referenced != copied - I looked at some SDK code to see how they were doing some things, but I did not copy any code from the Half-Life SDK, basically having used Clean room design to recreate the functionality of Half-Life features I depended on with my own game.
BSS is explained under the docs folder, it's a proprietary scripting language used to define a single ubershader that is then split into multiple unique shaders along the $if branches. This means that a specific rendering module uses a single BSS ubershader script to compile all it's unique shaders it needs.

Referenced != copied - I looked at some SDK code to see how they were doing some things, but I did not copy any code from the Half-Life SDK, basically having used Clean room design to recreate the functionality of Half-Life features I depended on with my own game. This means it's 100% original code that behaves mostly the same as some Half-Life code did, but it does not in any way infringe upon the SDK license or copyright.
BSS is explained under the docs folder, it's a proprietary scripting language used to define a single ubershader that is then split into multiple unique shaders along the $if branches. This means that a specific rendering module uses a single BSS ubershader script to compile all it's unique shaders it needs.

ok i understand, guess i will close this as complete

forgot to ask this but im wondering what about compilers? they seem to be based on vhlt but im guessing the compilers arent written from scratch, wouldnt that cause an issue or probably not as long as i dont put the compilers in the game

i also see that some studio stuff does use valve stuff, are these temporary till studiomdl is rewritten or something? (at least thats what i saw in readme something related to studiomdl being from sdk)

The file in question is still 100% custom code, I just kept the header, as the studiomdl format is not my invention. I kept studiomdl, as it is needed for VHE and Jack. There is no patent on the model format, so it is free to use by anyone. There are no plans to strip it out.

forgot to ask this but im wondering what about compilers? they seem to be based on vhlt but im guessing the compilers arent written from scratch, wouldnt that cause an issue? or probably not as long as i dont put the compilers in the game

The compilers are VHLT based yes, but as far as I am aware, there's no limiting factor that prevents their use outside of Half-Life, as they sre not part of the HLSDK nor do they contain any original HLSDK code.

The file in question is still 100% custom code, I just kept the header, as the studiomdl format is not my invention. I kept studiomdl, as it is needed for VHE and Jack. There is no patent on the model format, so it is free to use by anyone. There are no plans to strip it out.

im just a tiny bit worried about this, like i dont understand if it means original code from hl sdk was taken or just that studiomdl format isnt your invention so that was placed there @TheOverfloater

@valina354 It means the studiomdl format is not my invention so I don't have any ownership of it. Otherwise no code was taken from the HLSDK. I will clarify this in the file.

@TheOverfloater

qrad.cpp,qcsg.cpp,qbsp.cpp,vis.cpp mentions being based on valve original code due to being based on vhlt which probably doesnt matter much as long as they arent provided with final game but still its probably worrying

VHLT is separate from the Pathos repository, which was partly done to avoid any issues due to copyright or licenses, in case some Valve/Id Software code did remain. There's currently no plans to write my own level compilers for Pathos, so they just won't be distributed with the game itself.

VHLT is separate from the Pathos repository, which was partly done to avoid any issues due to copyright or licenses, in case some Valve/Id Software code did remain. There's currently no plans to write my own level compilers for Pathos, so they just won't be distributed with the game itself.

i have been doing some investigation into the compilers and comparing functions and as of now i have found a bunch of valve/idtech code so the compilers should stay seperate from pathos repo as it is now


Support python lint for the automated builds.

Install pylint in the docker image, Invoke lint on esx_service/Makefile.

As #721 indicates, we drift from good state pretty fast. Elevating priority and assigning to myself, will do ASAP

There are a lot of errors reported by pylint on syntax. Possibly, this needs to be a make target and a checklist in a PR to have pylint verified for at least new code.

I plan to make build fail if pylint returns errors. We will start adding more checks and warning after that

Fixed by #739


Add secondary action to dragcontext and use it for circlemenu

This should make a fast 'rightclick' possible for touch, but that needs testing on the big screen.

Has been tested on the big screen.

Merged, thanks!


Why AR(2) model is used on Lagrangian persistence component instead of original data?

For line 204, why images are backward  extrapolated first before autoregression?
https://github.com/pySTEPS/pysteps/blob/df090c0a6e7df69596543d9bb739eb927a482395/pysteps/nowcasts/sprog.py#L190-L207

Precisely because we seek at quantifying the Lagrangian persistence, since this is the framework used for the advection forecast.
You can find more details in, for example, Seed (2003).
Hope this helps.

@dnerini Thanks, I have read the paper and know why to do so.
By the way, I am a bit confused by the combination of the auto-regression and advection(advecting each level with same displacement).
From my understanding, auto regression on lagrangian persistence component has achieved the effect of advection, why we need advection again?

in Seed (2003)

I knew the reason. Without advection, some areas will always be no-rain days.


included ffmpeg unable to restream to wowza

So, I'm trying to re-stream to a wowza rtmp server that utilizes authentication.
I tried both these forms:
-f flv "rtmp://[username:password@]server[:port][/app][/instance][/playpath]"

Which results in: Problem accessing the DNS. (addr: [username])
And:
-f flv "rtmp://serveraddress[:port][/app][/streamname] flashver=FMLE/3.0\20(compatible;\20FMSc/1.0) live=true pubUser=myuser pubPasswd=mypassword"

Which does: RTMP_ReadPacket, failed to read RTMP packet header
I see your ffmpeg build is missing a lot of flags, which is probably why this isn't working (?), perhaps lets expand it to include more capabilities?
ffmpeg version 4.2.1 Copyright (c) 2000-2019 the FFmpeg developers
  built with gcc 6.4.0 (Alpine 6.4.0)
  configuration: --prefix=/usr/local --enable-version3 --enable-gpl --enable-nonfree --enable-small --enable-libmp3lame --enable-libx264 --enable-libx265 --enable-libvpx --enable-libtheora --enable-libvorbis --enable-libopus --enable-libfdk-aac --enable-libass --enable-libwebp --enable-librtmp --enable-postproc --enable-avresample --enable-libfreetype --enable-openssl --disable-debug --disable-doc --disable-ffplay --extra-libs='-lpthread -lm'

As comparison my local ffmpeg:
ffmpeg version 4.1.5 Copyright (c) 2000-2020 the FFmpeg developers
  built with gcc 8 (Debian 8.3.0-6)
  configuration: --disable-decoder=amrnb --disable-decoder=libopenjpeg --disable-libopencv --disable-outdev=sdl2 --disable-podpages --disable-sndio --disable-stripping --enable-libaom --enable-avfilter --enable-avresample --enable-gcrypt --disable-gnutls --enable-openssl --enable-gpl --enable-libass --enable-libbluray --enable-libbs2b --enable-libcaca --enable-libcdio --enable-libcodec2 --enable-libfdk-aac --enable-libfontconfig --enable-libfreetype --enable-libfribidi --enable-libgme --enable-libgsm --enable-libilbc --enable-libkvazaar --enable-libmp3lame --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libopenh264 --enable-libopenjpeg --enable-libopenmpt --enable-libopus --enable-libpulse --enable-librubberband --enable-libshine --enable-libsnappy --enable-libsoxr --enable-libspeex --enable-libtesseract --enable-libtheora --enable-libvidstab --enable-libvo-amrwbenc --enable-libvorbis --enable-libvpx --enable-libx265 --enable-libzimg --enable-libxvid --enable-libzvbi --enable-nonfree --enable-opencl --enable-opengl --enable-postproc --enable-pthreads --enable-shared --enable-version3 --enable-libwebp --incdir=/usr/include/x86_64-linux-gnu --libdir=/usr/lib/x86_64-linux-gnu --prefix=/usr --toolchain=hardened --enable-frei0r --enable-chromaprint --enable-libx264 --enable-libiec61883 --enable-libdc1394 --enable-vaapi --enable-libmfx --enable-libvmaf --disable-altivec --shlibdir=/usr/lib/x86_64-linux-gnu

(or I'm overlooking something, like some options not available on alpine?)

Interestingly the package from debian does not include --enable-librtmp even though it seems better and streaming rtmp o.O
I tried switching to ffmpeg 4.1.5 in the container to see if this was a regression, but it has the same issue. Will try to investigate further (looking at the different compile flags, but haven't found anything that I think could be related ..)

So, it seems indeed --enable-librtmp is the culprit here:
https://www.ffmpeg.org/ffmpeg-protocols.html#librtmp-rtmp_002c-rtmpe_002c-rtmps_002c-rtmpt_002c-rtmpte
Whereas the default rtmp implementation does support user:pass:
https://www.ffmpeg.org/ffmpeg-protocols.html#rtmp
I now built the container with alpine:3.11, FFMPEG_VERSION=4.2.2 and no --enable-librtmp and get the result I want.
Can imagine you wanted librtmp to have all the extra fancy rtmp variants, but in my case I'd rather have a working authenticated re-stream going. ;)
Closing this issue for now.

Good find. I never considered this and realized there was a default rtmp implementation. Thanks for checking into this.

I actually ran into an old gstreamer post of mine where I had the same issue:
https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/869
They ended up making their own implementation as well :P
https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/292


What is the correct way to type a "Dictionary" (Record/Object does not work)

I'm trying to find the correct way to type a logical Dictionary object in TypeScript. The Record and Partial types combined do not work the way I want them to -- my "want" is to behave like a common dictionary/map available in other languages.
Given a dict: Dictionary<K,V> I want:

dict.key / dict[key] to have the type undefined|V since the key may not exist
Object.values(dict) to have the type Iterable<V>
Object.entries(dict) to have the type Iterable<[K, V]>
Object.keys(dict) to have the type Iterable<K>

Record<K,V> does not work, since accessing by key always yields the value type V, even though the key may not exist.
Partial<Record<K,V>> does not work, since then Object.values returns a type of Iterable<V|undefined>
How can I properly define a Dictionary type that works with standard JS objects?
It's fine if I have to override definitions of Object.values/entries/keys for a Dictionary type. I'm not clear on how I override Object functions for specific types only.
Note: I'm aware of a lot of the history of these types here. I'm interested in finding a solution that works. The above Dictionary is a common typing paradigm available in many languages, so I would like it to be possible in TypeScript.

I've migrated this from my Stack Overflow Post since I believe it's a critical issue with TypeScript. It repeatedly comes up in code I work on, and I'm unable to give answers to new TypeScript users as to what the solution is. We're constantly required to make type assertions on type-correct record code.

You can use Record<K,V> with noUncheckedIndexedAccess: true.
See: https://www.typescriptlang.org/tsconfig#noUncheckedIndexedAccess

It looks like this is a question rather than a bug report. This issue tracker is for tracking bugs and active work on TypeScript itself, rather than a general forum for programmers using TypeScript to get help or ask questions.
You can ask questions on sites like Stack Overflow. We are not able to provide one-on-one support on the issue tracker. Please read the issue template carefully - it has important information on what kinds of reports can be acted on here, as well as links to useful TypeScript resources. Thanks!

@RyanCavanaugh The reason I posted it here is because it feels more like a bug in the way Record and Object are handled and despite lots of searching I've been unable to find any solution. I've left the question phrasing to be clear in the intent, but underlying it I still feel as though there is a deficiency here that needs to be "officially" addressed.

@edaqa-uncountable Being unable to find a satisfactory solution to a particular pattern is not a bug, or even per se deficit. Please note that we have templates here that attempt to steer you toward actionable issue reports.

You can use Record<K,V> with noUncheckedIndexedAccess: true.
See: https://www.typescriptlang.org/tsconfig#noUncheckedIndexedAccess

This unfortunately goes well beyond unchecked access for records, applying to all arrays as well (even in situations where the length is properly checked).

I think Type Script needs something like this. I'm trying to implement a
Record<string, string | undefined>

type for a field where it is likely that keys will be missing, so the user has to check for undefined when using this certain field. Other Records in my program are unlikely to return undefined, it's just one that needs special treatment.

I think it would be more correct if there were different options for Objects/records vs Arrays rather than just having noUncheckedIndexAccess apply to everything that can be accessed by index, as the patterns for each are distinct enough  (due to type limitations) that I would argue the existing behavior is wrong.
For instance, I don't think this example should result in any type errors, but it does.
// noUncheckedIndexAccess: true

const myString = "something without a dollar sign in it"

const newString = myString.split("$")[0]

const lastLetterBeforeDollarSign = newString[newString.length - 1]

newString is never actually undefined, but the compiler tells me it might be. I don't want errors like this in my code, but I would like to see instances where I am accessing an object by index and assuming it is defined even if it may not be.


Sesson id that is inserted is different than what is initially logged.

Session id logged when session is created plw3dgqfw75qsxa09bktfidd663dk8xveojg0u2h
Session id logged from session inserted in db
[ { id: '1.0', expiresAt: 2024-04-25T18:20:01.912Z, userId: 1 } ]

My table definitions
const User = defineTable({
  columns: {
    id: column.number({ primaryKey: true }),
    email: column.text(),
    name: column.text(),
    password: column.text(),
    role: column.text(),
    createdAt: column.date(),
    updatedAt: column.date(),
  },
});

const Session = defineTable({
  columns: {
    id: column.text({
      primaryKey: true
    }),
    expiresAt: column.date(),
    userId: column.number({
      references: () => User.columns.id
    })
  }
});

I'm also getting type errors as I'm not using text ids for the User table.

My mistake when creating the session I thought the attributes param was the user attributed so I was passing in the userId there.