Release 2.3.1

Fixed #2571.
I don't think we need to wait any PRs as this release is mainly a hotfix (refer to https://github.com/microsoft/LightGBM/pull/2565#issuecomment-553289377).
v2.3.1 is a draft now: https://github.com/microsoft/LightGBM/releases.
@guolinke @chivee @henry0312 @jameslamb @Laurae2

PR merged, Draft mark from GitHub release removed.
@guolinke Please help with stable tag and PyPI release.

@guolinke Can you also update PyPI release?

the pypi is updated

Thank you for your quick work!!!!

PR for Homebrew has been proposed: https://github.com/Homebrew/homebrew-core/pull/47314.

@guolinke Seems that we forgot about Nuget

@guolinke Can you please help to update https://www.nuget.org/packages/LightGBM/ to 2.3.1? Or do you think that it's not needed and we should wait for the next release and update only then?

@StrikerRUS sorry, I forgot it. will update it now.

@guolinke Thank you!


RHEL-07-020110 does not reference rhel_07_020110_autofs_service_status.stdout

Describe the Issue
The conditional check for the RHEL-07-020110 task for ansible.builtin.service (line number 1353 in tasks/fix-cat2.yml) does not reference the registered variable rhel_07_020110_autofs_service_status.stdout.  The variable is referenced directly, and thus will not equal the string "loaded"
Expected Behavior
rhel_07_020110_autofs_service_status.stdout is referenced by the task, and the string "loaded" is properly matched or not.
Actual Behavior
rhel_07_020110_autofs_service_status is referenced without checking .stdout sub item in the returned dictionary, and thus the string comparison for "loaded" will never match.
Control(s) Affected
RHEL-07-020110
Environment (please complete the following information):

Ansible Version: >= 2.9
Host Python Version: >= 2.7 or 3.8
Ansible Server Python Version: 3.8
Additional Details:

Additional Notes
Possible Solution
Ammend line 1353 as follows:
remove:  rhel_07_020110_autofs_service_status == "loaded"
add: rhel_07_020110_autofs_service_status.stdout == "loaded"
I will also submit a pull request to amend as described above.

PR 430 opened, includes commit to resolve this issue.


JsonSerializer.Deserialize reads outside buffer with Stream with malformed json

var stream1 = new MemoryStream(Encoding.UTF8.GetBytes("[1]"));
var result1 = JsonSerializer.Deserialize<int[]>(stream1);

var stream2 = new MemoryStream(Encoding.UTF8.GetBytes("["));
var result2 = JsonSerializer.Deserialize<int[]>(stream2);

result1 is now int[] { 1} as expected.
However, result2 is now also int[] { 1}, but I expected to get an exception because of invalid json.
The reason is that Deserialize<T>(Stream, IJsonFormatterResolver) will call MemoryPool.GetBuffer() which returns an unclean buffer. This buffer is then filled based on the stream in FillFromStream(). In our case, the second broken json is shorter than the first one, so our new buffer contains a mix of the new and the old json.
The buffer is then just passed on to the parser without any length field, so the whole buffer is potentially read if it contains garbage.

Is there a work around for this issue?

Is there a work around for this issue?

Manually copy the content of the stream to a byte[] and deserialize the json from there

Does this affect the JsonSerializer.NonGeneric.Deserialize ?

Does this affect the JsonSerializer.NonGeneric.Deserialize ?

Yes, if you use the overload with Stream.

Yes we do use the overload with stream since we are creating our own mediaformatter for asp.net web api. How about for serializing? JsonSerializer.NonGeneric.SerializeAsync ?


add Bytes to ObjHashable

str is bytes in python2, and is the most common dict key, so it's necessary to support bytes as hashable when processing old data.

Maybe I should add some tests? Anyway this works for me.

Ok sure, I guess that's fine with me. Having some at least one test for this would be good; whatever you used to check if it works is probably good enough; if you're not sure whether to put a test in crate::test, crate::util::test, or crate::read::test, feel free to ask. Since this only changes something that used to be an error, I think a minor version bump should be fine, so please rebase onto master (because I merged #8) and then change the crate version to 0.4.2.
For proper Python 2 support, see #1 and https://github.com/landaire/py-marshal.

No problem, I have added one test for dict and one test for set.
Thanks for the reminder! Currently I only need to decode some basic types, no user defined classes, so this would be enough for me.

Done! https://crates.io/crates/py-marshal/0.4.2


The benchmark should use the same random seed to split train, valid and test data

As we know, the random seed in splitting the dataset has a large impact on the final performance of test set, So all of these dataset should be evaluate as same as the test set in deepchem/molnet, namely, you should split your dataset as deepchem does! not just by yourself

This repo is deprecated, we did compare with molnet on the EXACTLY the same train/valid/test split on our new repo here: https://github.com/swansonk14/chemprop#results


Simplify Driver Interface by removing read/write commands

Now that I have pushed commit 8a21b1a947b875779d876897ca0942825dd8b037, Orient uses sql batch scripts for all operations. That eliminates the need for different read/write commands. We also have runReadCommand() which just doesn't make any sense at all, lol.
I propose we simplify the Drivers and Interface to simply runCommand() and executeCommand()
Any reason not to?

None that I can think of. This will automatically fix some satellite issues with passing Command to Query as well.

Closing this since the PR was merged.


Upgrade kramdown to version 2.3.0 or later

Upgrade kramdown to version 2.3.0 or later

#5 Solved


Add support for M1 Mac

As reported by @natalie-perlin of NOAA, using ESMA_cmake on a M1 Mac throws a failure due to unsupported processor.

Any thoughts on this? @climbfuji created this patch for use in Spack, so that ESMA_CMake picks up x86 on an M1 Mac when running in emulator mode. Shouldn't be necessary if you natively compile for aarch64, but we've (@climbfuji) compiling in Rosetta 2.
https://github.com/kgerheiser/spack/blob/03d13512833de2a5e5618e8f5c31e6a7b68b65de/var/spack/repos/jcsda-emc/packages/mapl/esma_cmake_apple_m1_rosetta.patch

Any thoughts on this? @climbfuji created this patch for use in Spack, so that ESMA_CMake picks up x86 on an M1 Mac when running in emulator mode. Shouldn't be necessary if you natively compile for aarch64, but we've (@climbfuji) compiling in Rosetta 2.
https://github.com/kgerheiser/spack/blob/03d13512833de2a5e5618e8f5c31e6a7b68b65de/var/spack/repos/jcsda-emc/packages/mapl/esma_cmake_apple_m1_rosetta.patch

@kgerheiser Huh. I only just recently got access to an M1 Mac and have been doing native tests (see https://github.com/GEOS-ESM/GEOSgcm/issues/417). That said, I could probably take that update into ESMA_cmake pretty easily as it's essentially a codepath I don't hit. I'll look at adding that in.
PS: How do you build on M1 as an x86? I never thought to try it out (not sure how to get compilers, etc.). Do you have to cross-compile GCC?

@climbfuji Ahh. Okay. You use Homebrew. I don't allow Homebrew to install any compilers or MPI stacks on my Macs. I like to control that myself. I'm always afraid that one day gcc-11 will "magically" move from 11.2 to 11.3. Not on my watch! 😄
And, of course, my laptop won't allow installs to /opt or /usr without admin rights, so that's another fun thing.
Of course, this means I have to bother the GCC devs at times when I have issues (as I've done with GCC 11.3 and GCC 12.1 native M1). But I suppose those updates are fed up to Homebrew so others get the help! (I started my GEOS M1 trials basing it off of the M1 GCC recipe Homebrew used at the time, but I quickly learned it wasn't up to snuff. But luckily the GCC devs were nice enough to put up with me!)


Add openAPI changes

Description
This is a sample PR showing the requested changes on open API tool.

@SkNuwanTissera Let's close this if this PR is not required anymore

Closing as per the offline discussion I had with @LakshanSS, as we are working on cleaning up outdated PRs in the Ballerina platform repositories and this PR is not needed anymore.


protect against mutual edit of object in admin

PR https://code.djangoproject.com/ticket/32867

Closing per ticket.


IPD VR settings request

Greetings!
Do you think a parameter in the vr_settings file that scales the IPD rate-of-change when the ('alt'+'+') and ('alt'+'-') shortcuts are used would be possible (i.e. new_parameter=0.5 would halve the rate-of-change)? Could there also be an option to set these buttons to be a toggle, so they don't need to be held down as well?
I ask because I am presently trying to make a POV video involving the Incredible Hulk (you know that sex scene where Bruce Banner says they have to stop before he gets too excited? What if they didn't? :P).
Moreover, I think VR provides possibilities never before seen in POV media related to changing scale (growing/shrinking), so it might be worth expanding a little on customizing IPD changes, if it isn't too hard to implement.
Regardless, I also just want to say thank you for doing such amazing work; I've been a fan for a long time, and am constantly surprised at how your work is so far ahead of the curve. It's simply astounding.

You should be able to change the way the buttons work by changing <EnlargeWorld on="Press"> to <EnlargeWorld on="PressUp">.
Adding an additional setting for the rate of change should be trivial. I'll add it to my list. "The way to go" for scaling the scene are motion controls, though, since they're a lot more intuitive to use and allow for more fine-grained control.

I see, I look forward to it! Thanks!
I've browsed through the code and message boards, but I can't seem to find any reference to the  you mentioned. It doesn't seem to be generated in the vr_setting.xml, nor anywhere else I've looked.
If you have a moment, could you point me in the right direction, or a resource that would lead me there? I have (computational) coding experience, but admit this is quite a different beast than what I usually work with, so I apologize if this should have been obvious.
Thanks again for your hard work!

There should be a block with configurable shortcuts in the settings. Are you using the latest version? This was added with 0.6.

I spent some time messing with the my install, and now have the the settings file generating in full as you say. I had already updated to 0.6, and the blacklist, RotationMultiplier, and other features added in 0.51 were showing up in the settings, so I thought everything was working properly.
I first tried just recopying all the 0.6 files into my install folder and doing the IPA update on the .exe files again, but this actually caused running the VR .exe to load the game on my desktop, and left the headset (VIVE) viewing a weird blurry environment of white and browns.
I'm not entirely sure, but what might have been the problem was still having the old VR files from the 0.42 version in the "HoneySelect_data" folder (placed there from the previous 0.42 installation). I deleted these from the data folder as well as all other VR related files, did another clean install of 0.6, reiterated the IPA update on the Honey*64.exe files, and that seemed to get it to generate the settings file correctly as well as run in VR successfully.
This HS install is modded out the butt so take my case with a grain of salt, but there it is in case it's useful. Let me know if any particular details would be useful, and I'll do my best to help.
Thanks for letting me know something was amiss; now I see what you meant by adding configurable shortcuts in the recent updates. Very nice!


Add documentation describing the message formats

Can you add documentation describing the extended format and the standard format?
For extended, even just adding a link to
http://aprs.gids.nl/nmea/#rmc
would help.  Obviously, programmer can look at the source at https://github.com/tananaev/traccar-client-android/blob/master/traccar-client/src/main/java/org/traccar/client/Protocol.java, but a quick explanation of each field would be much easier.

Documentation for old format:
https://www.traccar.org/traccar-client-protocol/
Documentation for new format:
https://www.traccar.org/osmand/


refresh missing after circles setting has been changed

If you enable/disable the circles around caches from the options menu of a map, then a refresh is missing. The change only gets visible on next interaction with the map.

This problem is back in the Release Candidate 26.10.2011.

Yep, I also noticed this.

@rsudev: Could you please look at this one? It is OSM specific. We call invalidate (for both Google or OSM) after switching the circles. For Google that immediately changes the map, while for OSM it does only work on moving the map the next time.

I'll take a look.

The problem was that the method mapView.invalidate works differently for mapsforge and google. I eypanded the method repaintRequired to cover all cases where mapview.invalidate was called and removed said method from the MapViewImpl interface so it can not lure someone again.

Verified.


SqlSetup: Add missing properties: Service Startup Type (SQLENGINE/AGT,AS,IS,RS)

Pull Request (PR) description
Added new parameters to allow to define the Startup Types of the services while installing them
This Pull Request (PR) fixes the following issues
Fixes #1165
Task list

[x] Added an entry under the Unreleased section in the CHANGELOG.md? Entry
should say what was changed, and how that affects users (if applicable).
[x] Resource documentation added/updated in README.md?
[x] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help?
[x] Comment-based help added/updated?
[x] Localization strings added/updated in all localization files as appropriate?
[x] Examples appropriately added/updated?
[x] Unit tests added/updated?
See DSC Resource Testing Guidelines.
[x] Integration tests added/updated (where possible)?
See DSC Resource Testing Guidelines.
[x] New/changed code adheres to
DSC Resource Style Guidelines
and Best Practices?

This change is

Codecov Report

Merging #1184 into dev will increase coverage by <1%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##            dev   #1184    +/-   ##
=====================================
+ Coverage    97%     97%   +<1%
=====================================
  Files        33      33
  Lines      4016    4026    +10
=====================================
+ Hits       3929    3939    +10
  Misses       87      87

Two errors ...
Well, there are tabs here and there that I can modify.
For the markdown, to be honest I don't see where are the three problems...

Awesome!! I will review this one after the weekend :)

a discussion (no related file):
Previously, johlju (Johan Ljunggren) wrote…
Can we add the once that are possible to the integration test as well? Not all services are installed in the tests yet, so at least test those that can.
SQL Engine, SQL Agent, Browser
Config: https://github.com/PowerShell/SqlServerDsc/blob/dev/Tests/Integration/MSFT_SqlSetup.config.ps1#L193
Tests: https://github.com/PowerShell/SqlServerDsc/blob/dev/Tests/Integration/MSFT_SqlSetup.Integration.Tests.ps1#L244

I don't feel comfortable touching all these integration stuff. Let me first handle all the other comments and I will have a look at this.
To be honest, I spend 10x more time working on the test part then actually updating the DSC script.

@mdaniou I know, it's the same for me - the tests take a lot of work - but it is worth the time in the end 🙂

@mdaniou Just a gentle reminder to write 'Done' on the review comments when you are finished, so I know I should review again. No hurry though, take the time you need. :)

@johlju not yet. This is holiday time so I will handle that in August.
I have asked some questions you can answer though. If you could have a look. :)
I need to work on the integration improvements.

yes I know I need to handle this ! :)

@mdaniou great if we can get this over the finish line. The abandoned label should be removed once you push next time.

I forgot to add a 😃, so updated previous comment 😄

README.md, line 1636 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
I agree with what you say here. I also agree that Automatic value should not be default if that parameter is left out.
Can you please submit a new issue to track this? That could be another PR that introduces a breaking change for this.

Cool thanks, Issue #1198 created

@mdaniou Apologies that you waited so long! 😞 I will continue the review now! 🙂

Tests/Integration/MSFT_SqlSetup.Integration.Tests.ps1, line 251 at r4 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Can we add the properties to be tested for 'Automatic' here (the value you set them to in the configuration file).
AgtSvcStartupType
AsSvcStartupType
SqlSvcStartupType

This would only work if I modify the Get-TargetResource function right. My understanding is that this function is run by Get-DscConfiguration.
Could you please confirm that ?

Tests/Integration/MSFT_SqlSetup.Integration.Tests.ps1, line 251 at r4 (raw file):
Previously, mdaniou (Maxime Daniou) wrote…
This would only work if I modify the Get-TargetResource function right. My understanding is that this function is run by Get-DscConfiguration.
Could you please confirm that ?

I have done some tests and got the answer. :)

@mdaniou Great that you found the answer. 🙂

Tests/Integration/MSFT_SqlSetup.Integration.Tests.ps1, line 251 at r4 (raw file):
Previously, mdaniou (Maxime Daniou) wrote…
I have done some tests and got the answer. :)

Done.

All good here I think 👍

DSCResources/MSFT_SqlSetup/MSFT_SqlSetup.psm1, line 2340 at r8 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This one wasn't changed, should be .PARAMETER StartMode.

Yes indeed ...

@mdaniou Awesome work on this one! Just waiting for the tests to pass, then I merge.

👍
Awesome ! The test/integration part is quite tough ! :)

@johlju : It seems like the the entry for this change in the CHANGE.LOG is not in UNRELEASED. Instead it is under  <IP_ADDRESS>.
Not sure it is intended.
https://github.com/PowerShell/SqlServerDsc/blob/dev/CHANGELOG.md#11400

Yes, tests are a hill to climb over until you get hang of it, but they are well worth the effort!
Yes, I saw that the change log merged into wrong place. I does that after a release. I have a PR open to fix it. Waiting for the test to pass and then I will merge that PR. Thanks for noticing and reporting it!

Btw, I usually see that the change log will act up when I review, and ask for a rebase against dev, this time I missed it. :)


Rename multiple layers with a data source (i.e. JSON or CSV)

I need some way to rename 1.7K layers using a data source such as a JSON or CSV file. It seems there is no Sketch plugin anywhere that is capable of doing this. I find this quite strange given the disciplines of UI and UX Design moving increasingly towards the role of Design System Management. So, while is is not as much an issue as it is a feature request, I think many a designer would find it valuable.
In user story format, as a Design System Manager I need the ability to rename hundreds or thousands of layers from a data source such as a JSON file or CSV so that I can keep the enterprise design system I manage organized.

I also requested something similar to this here :
https://github.com/rodi01/RenameIt/issues/131#issue-581820012


Multiple occurences of labels on y-axis with two charts on graph

Hi,
I have two Line Charts on a graph and generally there are no issues with each of them.
But sometimes when one goes above the other I get this weird thing happening where the axis seems to reset its value and displays multiple occurences of the same labels, sort of.
Here is a picture of the problem.

As you can see we go from 0 to 7.5 and then we go back to 1.0...
How can I fix this? Or does anyone knows how to recreate the issue ?

That's interesting, I've never seen that before. Which version are you using? How are you configuring the labels for the y Axis? If you have 2 full charts, that could explain it since there are two scales being drawn each with different labels. You could try adding your data on the same chart with 2 datasets. An alternative thought that comes to mind is that the custom formatting is formatting the wrong values somehow, but that's just a wild guess.

Nevermind that, I forgot to update this, it was an error on my part in how I customize the scale. This can be closed.

Thanks for letting us know @AKFourSeven


A11y_Azure Tools Storage Explorer_Queues_QueueTable_ScreenReader: NVDA is announcing whole table data in one go after navigating to each cell of the table.

GitHubTags: #C&AI_Aug2020_BMAzure Tools Storage Explorer;#A11yMAS;#A11YTCS;#DesktopApp;#Azure Tools Storage Explorer;#WCAG1.3.1;#Win32;#A11ySev2;#Benchmark;#NVDA;#JAWS;#FTP;#STP;
Environment Details:
Application Name: Azure Tool Storage Explorer
Application version: 1.14.2
Windows Version - Windows10
Screen Reader : JAWS(2020.2006.12ILM),NVDA(2020.2)
Repro Steps:

Launch Storage Explorer
Navigate to "Open Connect dialog" pane and Sign in to Azure.
Go to "Manage Accounts" pane and Select the subscriptions you will use. Once selected, click on "Apply" button.
Navigate to "Queues" of the selected subscription and expand it.
Navigate to any queue and click on it.
Navigate to queue table cell.
Check if NVDA is announcing whole table data in one go after navigating to each cell of the table after navigating using arrow key.

Actual:
NVDA is announcing whole table data in one go after navigating to each cell of the table.
This issue is also observed with JAWS
Similar issue also observed for following scenarios:

Disk-->DiskInfoTable

Expected:
NVDA should announce only the cell value of the table along with associated row and column after navigating to each cell of the table.
User Impact:
Screen reader users will not get the correct value of the cell and get confused.
Attachment:
https://microsoftapc-my.sharepoint.com/:v:/g/personal/v-prraha_microsoft_com/EQ5hD11vS_9OgzqfM_KiQ7gBi8RDAhrOqF9iJSM0StmCPA?e=Hj6GGW

@pranshu512 I am unable to reproduce the issue with NVDA or VoiceOver. The screen reader does not announce the entire contents of the table, just the contents of the currently selected cell as well as the number of items displayed. Please verify again. If the bug is still reproducing, please update the bug with more details.

I verified this issue on version 1.16.0-dev and it is not repro. Hence, Closing this bug
3479_Closed.zip

Github Tags:#Closed;


Matrix (5000x5000) inverse takes 25 minutes to compute

Hi all,
I'm trying to calculate the inverse of a 5000 by 5000 matrix with MathNet Numerics in F#. The same calculation in Python using numpy takes about 10 seconds. Using MathNet.Numerics.LinearAlgebra.Matrix.Inverse it took me 28 minutes. Probably, this is partly because my matrix is "almost singular" (as a cleaner matrix "only" takes 5 minutes to calculate). Using PsuedoInverse didn't make it much faster (25 minutes).
Am I missing something or is this an actual flaw?
Thanks,
Leon

I gave up after 15min but I confirm that I am seeing the same behavior.

Thanks for trying @Evangelink!


Adds gates_overtopped to dsmflow to use in models

I added the gates_overtoped.rda in the data folder. I used inputs from the bypass_overtopped.csv from the cvpiaflow package and added this in data-raw/delta-cross-channel-gates . I checked to make sure that these values matched what was present as gate.top in the OG models.

@ErinCain can you add this to the load_baseline_data() for the winter run and spring run models?


[Feature Request] Is there a plan to implement Animation via ReactNative Animated API?

Current animation on ReactNative has some performance issue. ex: frame loss

This is not in the works. I'll leave this issue open for further evaluation.

Gotta +1 that, imo it's an important issue, as animations performance is really bad currently.


Add support for modular use of custom graphics

Currently the only way to use custom graphics is to customize a graphics class and inherit the mojs.CustomShape class, and then add it to mojs using the mojs.addShape() method. Then you can set and use custom graphics in the shape attribute.
One disadvantage of this method is that the added custom graphics class is global, and sometimes the added custom graphics will only be used in a certain module. My feeling is'this pollutes the global attributes'. For example, I want to use custom graphics menu and close in the Menu component. But in other components, I don't want to use the two custom graphics menu and close.
So one way I recommend is to support the use of the class type attribute value for the shape attribute. e.g. new mojs.Shape({ shape: MyCustomShapeClass })
Of course, my thinking is not complete, because I don't know much about the source code of mojs, and there is a better way that would be better. Hope Add support for modular use of custom graphics

You can always separate your custom class with a separate name, but I understand your point.
I guess the philosophy here is that mojs is a library, and that you can extend the library with your own shapes. It's not mean to be used as a way of animating a single SVG, rather create animated interactive illustrations build by different shapes. If you just want to animate a hamburger icon from an open to a close state, I would use CSS animation and transitions, or a dedicated UI animations library, like Popmotion (understand it's just an example, but still).
Note that you can always change properties in a shape, like color, line-width etc directly from mojs, without to create a new custom shape.
What's your thoughts on this @xavierfoucrier? Maybe we could have both a global shape delcaration and a local one? (I also need to dig into the core of the custom Shape generation to see if it would be a big hassle to fix that)

Hi all,
From my point of view, that would be probably a big changes in the code, because the structure was not designed like this at the beginning...
As of today, you can do this very simply:

extend the class: class Bubble extends mojs.CustomShape { ... }
add the shape: mojs.addShape('bubble', Bubble);
use the shape: new mojs.Shape({ shape: 'bubble' });

See https://mojs.github.io/tutorials/shape-swirl/#custom-shapes.

I guess the problem here was that the class Bubble is attached to the global namespace, so if you in another file, creates another Bubble class, this would override the previous one. But as I said before, this is easily solved by having a unique name. Or nest the extended class in a functional scope.

@Sandstedt @xavierfoucrier In fact, my idea is the same as ESM modularization, because the life cycle of global data is at the application level (GC is only performed after the application exits), so I think the more global data, the more it affects the performance of the application (consumption of more memory).
Therefore, I am more inclined to the idea of modularity, load when used, unload when not in use. That’s why I hope that Add support for modular use of custom graphics.
Ideally, a module is imported into mojs. When this module is unloaded, all things created during this module will be GC. Of course, the global data generated by deliberate operations is not in this range. In fact, @Sandstedt said at the beginning what I wanted,'Maybe we could have both a global shape delcaration and a local one?'
But if I use mojs in a module like this
mojs.addShape( 'bubble', Bubble ); // passing name and Bubble class

// now it is avaliable on mojs.Shape constructor as usual
new mojs.Shape({ shape: 'bubble' });`

This will add a CustomShape to the global of mojs, which means that when the module is now uninstalled, the CustomShape will not be uninstalled (GC). I think this will take up more global resources.


vmaGetBudget unusably slow

We have an application which is consistently allocating and freeing memory buffers. The reason we need this is because the total size of our data is practically unknown, so we load data in "chunks" based on proximity to the view point.
Before allocating additional memory, we query vmaGetBudget in order to determine the percentage of DEVICE_LOCAL memory that has been used. When this reaches a certain limit, we free up old chunks and retry the allocations. We are working with very large datasets with many chunks. I am mentioning this to illustrate that we need to call vmaGetBudget many times in total i.e. before each chunk allocation.
We have done timings and calling vmaGetBudget is unusably slow. We are not sure if we are doing something wrong or not. On average, each call takes around 4 to 5 ms. For a small area, we get 1977ms for 419 calls. For a large area (1.1 million triangles) we get 19154ms for 2473 calls. Of course 20 seconds just for querying memory budget is unusable.
We are using the vulkan memory budget extension, and are calling vmaSetCurrentFrameIndex for each imageIndex acquired from vkAcquireNextImageKHR (not sure if this is the correct usage as docs are slightly unclear?).
Is 4ms expected from this function? I can't imagine that it is.
Help on this would be appreciated. Not sure if this is a bug or not! Thanks a lot.

I'm closing this ticket due to inactivity. Please let me know if you meet any further problems with this.


updating inconsistency in custom output description (different from c…

From file: evcxr_jupyter/README.md
Section: Custom output
last sentence in the 1st paragraph:
Each block starts with a line containing BEGIN_EVCXR_OUTPUT followed by the mime type, then a newline, the content then ends with a line containing EVCXR_END_CONTENT.

So it says block starts with BEGIN_EVCXR_OUTPUT, and from the code example below, it should be EVCXR_BEGIN_CONTENT
I haven't tested whether BEGIN_EVCXR_OUTPUT will do the work, but there's an inconsistency between the description and the example and I think it should be fixed.

Thanks for the fix @lisanhu!


[Add  a car] The "Save" button enabled if all fields are empty.

Reproducible: always,
Build found: build 1.0.65
Preconditions
The "Car" app is opened
The "My Profile" page is opened
Steps to reproduce

Go to the 'Your Cars' page
Observe the 'Save' button

Actual result
The "Save" button enabled if all fields are empty.
Expected result
The "Save" button is disabled if all fields are empty.
User story and test case links
E.g.: "User story #33
Labels to be added
"Bug" ("bug"), Priority ("pri: high

")

The issue is resolved only partially. This button is not clickable, but has a style of active button which is misleading.
Disabled button should have following colour: #B8B8B8.
Please make changes accordingly.


[Bug]: Found  CVE-2022-21944 in one of your dependencies library

Version
28.1.0
Steps to reproduce
Use dependency check plugin to check your CVEs for your package
Expected behavior
Should use the non-vulnerable package of dependency non-vulnerable
Actual behavior
Found  CVE-2022-21944 in one of your dependencies library
Reference: https://ossindex.sonatype.org/component/pkg:npm/fb-watchman@2.0.1?utm_source=dependency-check&utm_medium=integration&utm_content=7.0.4
Additional context
No response
Environment
System:
    OS: macOS 12.4
    CPU: (8) x64 Intel(R) Core(TM) i7-1068NG7 CPU @ 2.30GHz
  Binaries:
    Node: 12.22.12 - ~/.nvm/versions/node/v12.22.12/bin/node
    npm: 6.14.16 - ~/.nvm/versions/node/v12.22.12/bin/npm
  npmPackages:
    jest: ^28.1.0 => 28.1.0

Checking the CVE itself that looks very much like a false match.

Should be reported to https://github.com/facebook/watchman


Issue in getting response from Dialogflow

This is the URL( https://dialogflow.googleapis.com/v2/{parent=projects/}/agent) in my case( https://dialogflow.googleapis.com/v2/{parent=projects/chatagent-yrwptu}/agent) which I want to access from the POSTMAN tool to check its response whether it is working or not. But every time it is giving me an error
The requested URL /v2/%7Bparent=projects/chatagent-yrwptu%7D/agent was not found on this server.
That’s all we know.
I seriously don't know what to do
What I wanted to get the response from the dialogflow and saves into my salesforce org.

When you see {parents=projects/chatagent-yrwptu} it does not mean literally parents=. It's meant to signify that the URL path for the v2 API is agent, but it needs to be prepended by a parent so that the API knows which project specifically to use.
So you should be using the URL https://dialogflow.googleapis.com/v2/projects/chatagent-yrwptu/agent

Yes I was using this URL from Salesforce org but it was not giving me any response, so what should I do to get the response in my salesforcr org

I have tried this code but I was confused in this curl query
Http http = new Http(); HttpRequest request = new HttpRequest(); request.setHeader() request.setEndpoint('curl\-H "Authorization: Bearer 2041141a7ad34f45ae12654480ac0c98"\"https://dialogflow.googleapis.com/v2/{parent=projects/chatagent-yrwptu}/agent/query?v=20150910&contexts=shop&lang=en&query=apple&sessionId=12345&timezone=America/New_York"'); request.setMethod('Get'); HttpResponse response = http.send(request); String body = response.get(body); System.debug(body);

Your cURL command has the same issue where you're passing parent=. If you use the standard URL you will get a different answer. However, I also am not seeing any documentation for the approach you're taking in the request.

Thanku @Fleker for your quick response on this issue


HypergraphPlot: "HyperedgeLayout" option

Changes

Implements "HyperedgeLayout" option of HypergraphPlot.
This determines embedding of vertices (which are part of hyperedges) only, drawing stays the same.
Possible values are "Ordered" (sequence), "Cyclic" (last vertex connect to first), and "Unordered" (all vertices in a hyperedge form a complete graph).
Specification is per-pattern, i.e., {"Ordered", {_, _, _} -> "Cyclic"} will make hyperedges "Ordered", except for 3-edges, which will be "Cyclic".

Context
The idea is to have three options: "HyperedgeLayout" (responsible for vertex coordinates), "HyperedgeStyle" (responsible for colors), and "HyperedgeShapeFunction" (responsible for drawing).
Then we can have different themes, for instance,
HypergraphPlot[..., "HyperedgeLayout" -> "Ordered",
  "HyperedgeStyle" -> Automatic, "HyperedgeShapeFunction" -> "Normal"]

would correspond to previous "colored" plot.
HypergraphPlot[..., "HyperedgeLayout" -> "Cyclic",
  "HyperedgeStyle" -> LightBlue,
  "HyperedgeShapeFunction" -> "Regions"]

would make regions all colored the same way, etc.
Tests

Run unit tests: ./build.wls && ./install.wls && ./test.wls.
Try different layouts:

In[] := HypergraphPlot[{{1, 2, 3, 4, 5}, {5, 6, 7, 8, 9}},
   VertexLabels -> Automatic, "HyperedgeLayout" -> #] & /@ {"Ordered",
   "Cyclic", "Unordered"}

In[] := HypergraphPlot[{{1, 2, 3, 4, 5, 6, 7, 8, 9}, {1, 4, 7}},
   VertexLabels -> Automatic, "HyperedgeLayout" -> #] & /@ {"Ordered",
   "Cyclic", "Unordered"}

Use different layouts for different hyperedges:

In[] := HypergraphPlot[{{1, 2, 3, 4, 5, 6}, {1, 2, 3, 4}},
 VertexLabels -> Automatic,
 "HyperedgeLayout" -> {"Ordered", {_, _, _, _} -> "Cyclic"}]

This approach is not actually going to work, because "HyperedgeShapeFunction" will need to have information from all edges in order to make a sensible layout. Further, what is implemented here is actually a "VertexLayout" part of "GraphLayout", so it should be called such.


Add events and API changes for invitations and Magic Auth

Description
Adds events and API changes to support sending your own emails for invitations and Magic Auth.

Adds acceptInvitationUrl to invitation object returned by API
Adds new endpoints for the Magic Auth API: getMagicAuth and createMagicAuth
Deprecates current sendMagicAuthCode method in favor of createMagicAuth
Adds new events for invitation.created and magic_auth.created

Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
[x] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.
https://github.com/workos/workos/pull/26691

Should this PR be based off of the beta branch since it contains UM additions? Some context here.

Should this PR be based off of the beta branch since it contains UM additions? Some context here.

Ah that's my bad - I meant to do that and messed up when creating the PR

Ok I selected the correct branch now


[ Don't merge!!! ] Add Test-Json cmdlet

Resolve #4220.
The cmdlet is based on Newtonsoft.Json.Schema.
It allow to check:

Json by only parsing
Json against Schema
implicitly check Schema by parsing (based on previous line check)

Please see license of the framework (GNU Affero General Public License). /cc @joeyaiello @SteveL-MSFT

I’ll check if we can accept this license.  For now, you’ll need to add it to https://github.com/PowerShell/PowerShell/blob/master/ThirdPartyNotices.txt as part of this PR

@SteveL-MSFT I can not pull changes in ThirdPartyNotices.txt - it is excluded file.

@iSazonov ok, I'll take care of that file then once I get approval.  We should not merge this PR until the license is approved for this project.

To set expectation, since this depends on a component that has a non-permissive license, it may take some time to get this approved.  Also, since the Ignite conference is this week, many of the approvers are not here.

FYI, there are merge conflicts.

Rebased to resolve merge conflicts.

@SteveL-MSFT Could you ping license approvers? Also can we ask the author of the package to change/add MIT license?

@iSazonov since it appears that Json.Net Schema is how NewtonSoft makes money, I doubt they will change the license.  Still waiting on the approval, but to be honest with a non-permissive license, this will likely not be approved as I don't think it's compatible with the MIT license.  Your best option might be to publish this as a separate module on the PowerShellGallery as long as it adheres to the AGPL.

@SteveL-MSFT Thanks. I hope that if they offer AGPL for open source projects, they don't lose anything with adding MIT.

@iSazonov so after talking to legal, the end result is that if we accept this PR which will pull in the AGPL assembly and we distribute that package, then we would have to re-license PSCore6 under the AGPL to comply with the AGPL.  I think the alternate path is for you to publish this code under AGPL in your own repo and publish the resulting module on PowerShellGallery and then there is no issue with someone using a AGPL module with our MIT PSCore6.

@SteveL-MSFT I've made a request to obtain a suitable license.
If the answer will be no, I guess we have to find another way, because Json is very desirable to have inside.

Because of the licensing problem, I closed the PR and I'll open a new PR with another library.


Regards

Hej @mseln,
(I just got an update via Daniel Duberg Github activity and wanted to say hi. Feel free to close this issue)
This package is great! Congrats. Hope everything is going well :D
(I'll test tagging @kholdcro @danielduberg)
Kind regards,
Yoshua

Hey Yoshua!
Thanks! :D
Hope everything is going well in Zürich! :)
Best
Magnus


Make it compatible with the newest http.rb version (3.0.0)

http.rb 3.0.0 have introduced HTTP::Request::Body abstraction (https://github.com/httprb/http/pull/412) - let's make webmock compatible with it.

Excellent. Thank you!

Released as version 3.1.0


Simplify proto gen

Summary
Trying a different approach to generating protobuf code.
Advantages are:

No submodules or copying proto files
Simpler build.rs config with no special overrides needed for serialization.
Uses buf schema registry for our protos

Notes
Some things to watch out for:

Includes a generated .serde.rs file for all the protos. One side effect of this is that zero'd proto fields are no longer present in JSON output. I had to update one of your tests to accomodate the change.
I changed the grpc port for the tests to :5556, which may break your local setup
There may be subtle differences in serialization I'm not aware of. The only thing I checked is that bytes fields are serialized as base64 strings, which this generated Serde setup seems to do by default. But there may be other less desirable changes that I haven't noticed yet.
I have no idea why I can only make this work as a separate crate. I tried a bunch of ways to make it work inside xmtp-networking, but my knowledge of Rust modules is just not there to debug the issue. If you can make it work, that's probably better.

Wow awesome I'll take a look!

Feel free to merge whenever!


Include community meetings info in the resources page

As community meetings are starting I would like to find that info in the resources webpage:

Calendar
zoom link
regularity

/assign

https://github.com/metal3-io/metal3-docs/pull/58

Closed by metal3-io/metal3-docs#58


Remove unnecessary scrolling activating

isScrollEnabled is true by default

open var isScrollEnabled: Bool // default YES. turn off any dragging temporarily

Hey,
fixed this in v2.4.3, thank you for the suggestion.

Hey,
fixed this in v2.4.3, thank you for the suggestion.


Add tooltip to data-table column

Overview of the problem
Buefy version: 0.4.6
Vuejs version: 2.3.3
OS/Browser: Any
Description
I'm trying to add a tooltip to a b-table column, to better describe what it means.
Steps to reproduce
Add a b-tooltip tag before b-table-column inside a template(scope="props") on a b-table.
Expected behavior
Tooltip added in table column
Actual behavior
Error since we cant add anything but a b-table-column.

In other words it would be nice to have ability to customize table headers


Reduce the number of frameworks targeted

Currently the projects are build against all existing desktop frameworks: net40, net45, ... until net48.
It is not necessary, since the code do not use any specific features from the frameworks, and an app compiled against the 4.8 framework can reference a library compiled against the 4.0 framework.
Additionally, it will greatly decrease the size of the nuget package, since only one version of the dll for all desktop frameworks will be shipped (instead of 11).
So I suggest:

to remove all target frameworks to only keep netcoreapp3.1 and net40 for libraries
add a specific target framework only if we require some feature specific after a certain framework version (eg hidpi support), and protect this feature with #define statements
for demo apps and utility apps, target netcoreapp3.1 and net472 by default. net48 is still not mainstream enough, and useful only if testing hi dpi features. But targeting net48 could be discussed.

@Smurf-IV .Net45, 46 and 47 are not needed, as they don't add any value to the libraries. It's the exact same code. Or I missed something ?
In my view, any library consumer on any framework version could consume the .net40 version of the library without suffering any downside. Don't you agree ?

.net 4.0 still needs a special version and this is no longer installed by default(Only for legacy app development)
The lowest "we" could support is 4.5 for Win 7 native,
Win 7 and 8 with updates will have at lowest 4.6
Win 10 will be 4.8 (So is mainstream!)
So as the package will be smaller, I disagree with the removal of them from the build.
Remember, if a framework is native (i.e. highest installed version for the app), then the the JIT can perform better on multiple passes.
I do agree with reducing the impact on the test apps to be just .etcoreapp3.1, 48 and 40

Any app developed on .net 4.8 is able to consume a library build on .net 4.0 (even on .net)
The .net version installed on the OS does not dictate the minimum version a library must be build against.
Please also note that since .net 4, .net versions are installed on top of the previous version. So the .net 4.8 is only the .net 4.0 version with some changes.
It seems you think that if the OS as a newer version of the .net framework, then all libraries must be build targeting this framework to perform better. To my knowledge, it's wrong: a .net library is optimized the same way without depending on the framework it is targeting.

Based on my first review, I have seen no major difference in between minor releases (eg 45 vs 452 or 47 vs 472) which could justify the reason of publishing binaries for these minor versions.

This, I would have expected.
I look forward to the analysis between the major versions, and if that could be publishable to have as a front page item to explain where the other versions have gone.


Fixes for iOS-Bugs, Code Modernization & lowercase enum-members in dart

Changes
1. Bug-fix iOS
There was mismatch of value and path in the Swift Sharing-code. This resulted in a crash. I fixed this.
Since I have only iOS 16 to test with, I am now supporting both keys in incoming data from iOS, i.e. path and value when converting the data to JSON.
Then, if there is anything in path, I still use it.
2. Modernize Swift-Code
Also modernized the Swift-Code.

Move to guard
Early Return whenever possible
Implement all editor suggestions

3. dart

Convert to camel-Case (lowercase) enum members

Comment
There is one warning left in Swift-code due to new SDK. This can be fixed by implementing the corresponding function as async as that only works with Swift 5.5

Thank you @imdatsolak !! Your changes worked for me \o/

Hi, any updates on this PR acception? How can i test your latest suggestions, @imdatsolak ?

You can just use my repo. Put this in your pubspec.yaml:
flutter_sharing_intent:
   git:
      url: git@github.com:imdatsolak/flutter_sharing_intent.git
      ref: imdatsolak/ios-fix

Hi, I'm trying to try your fix but I'm getting this error:
<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Could not read from remote repository.
any help?

Hi, I'm trying to try your fix but I'm getting this error:
<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Could not read from remote repository.
any help?

If you are talking to me: you need to have access to github using your SSH key, otherwise access via SSH won't work.
If you can't use an SSH key, you might need to go to my repo and get the HTTPs-clone URL and replace git:github.com... with that URL.

Hello @imdatsolak, may you synchronize your branch with bhagat-techind/flutter_sharing_intent and update the PR ? I hope this will help for the PR. And also, you should remove from your PR the team ID changes from XCode project, and keep that only locally on your computer; this will reduce the changes.
I'll work on a merge of both branch for the moment.
Thanks

@kristofb made the necessary changes (I hope). Please check.
Also, the Team ID is done automatically by Xcode and required for testing purposes. Since this is a share-extension, it is actually a lot of changes to revert before sending a PR.
I see the problem, I have atm, no idea how to make that easier for the maintainer and contributors.
I did make the changes manually with a text-editor. You probably still need to check them.

Thank you sir @imdatsolak  you saved my time after 4 days i found this helpful. worked for me.

@bhagat-techind Hi man! why this pr not merged?)

Thank you @imdatsolak for the solution!

Hello @imdatsolak  , it gives me this error , any help ?
Swift Compiler Error (Xcode): Cannot find type 'SharingFile' in scope
/..Share%20Extension/ShareViewController.swift:14:26
ShareViewController.swift:14
Swift Compiler Error (Xcode): Cannot find type 'SharingFileType' in scope
/..e/ios/Share%20Extension/ShareViewController.swift:248:47

Thank you sir @imdatsolak you saved my time after 4 days i found this helpful. worked for me. now i can receive text/url and images in my app

hello @Firooz-Smart could you tell me what steps you follow?

Hello @imdatsolak , it gives me this error , any help ?
Swift Compiler Error (Xcode): Cannot find type 'SharingFile' in scope /..Share%20Extension/ShareViewController.swift:14:26 ShareViewController.swift:14
Swift Compiler Error (Xcode): Cannot find type 'SharingFileType' in scope /..e/ios/Share%20Extension/ShareViewController.swift:248:47

I can't really reproduce what you are doing. If you get my fork as described here you shouldn't have any problems.
I don't know what @bhagat-techind is currently doing with merging since it created merge conflicts compared to their changes, but I am actively using my fork in my projects and I don't see any problems there.

Hello @imdatsolak , it gives me this error , any help ?
Swift Compiler Error (Xcode): Cannot find type 'SharingFile' in scope /..Share%20Extension/ShareViewController.swift:14:26 ShareViewController.swift:14
Swift Compiler Error (Xcode): Cannot find type 'SharingFileType' in scope /..e/ios/Share%20Extension/ShareViewController.swift:248:47

I can't really reproduce what you are doing. If you get my fork as described here you shouldn't have any problems.
I don't know what @bhagat-techind is currently doing with merging since it created merge conflicts compared to their changes, but I am actively using my fork in my projects and I don't see any problems there.

thank you it works now , thanks for the effort


Printing \n?

The boost::nowide::cout implementation appears to skip doing conversion of \n to \r\n on Windows, which I believe is how std::cout normally does it (when not a binary stream). This makes it tricker to get correct line endings on Windows.

Nevermind. This may be a peculiarity of running Windows under Docker.

Ok, this does seem to deviate from std::cout behavior on Microsoft Nano Server under Docker (see https://github.com/Microsoft/Virtualization-Documentation/blob/live/virtualization/windowscontainers/quick_start/quick_start_windows_10.md for instructions if you're interested in trying that out). It seems to behave correctly in Windows 10 however, so I'm not exactly sure what might need fixing.

Fixed in 9b3c367868a1efa7caa953f27af5eaccd7db8b68


Test against new Node.js versions

Adding Node.js versions to CI

Coverage remained the same at 92.727% when pulling 6734c20935603750ed0eb97457f1c74dca4f75f1 on MarkHerhold:patch-1 into 4547099fb972af6c793519a2550fcee9c8b1c063 on Qix-:master.

This doesn't work on Node.js v7. :/

Node 7 fixed in #7. Kinda funny how that worked out.
Thanks!


conformance: GatewayInvalidTLSConfiguration test

Problem Statement
KIC ControlPlane is already HTTP core conformant; the test GatewayInvalidTLSConfiguration is part of it. We need to run such a core test successfully.
Acceptance Criteria

[ ] The core test GatewayInvalidTLSConfiguration is successfully run.

@mlavacca was there any specific reason to remove this from 1.3?

@mlavacca was there any specific reason to remove this from 1.3?

my bad, it should be in the 1.3 milestone


Error: Deprecated FCM Endpoint During Migration to v1 API When Using send_to_topic

The request endpoint has been changed from /fcm/send to /v1/projects/project-id/messages:send
Now, when use the send_to_topic method got a error
{
  :body=>"{"error":"Deprecated endpoint, see https://firebase.google.com/docs/cloud-messaging/migrate-v1"}",
  :headers=>{...},
  :status_code=>301
}

However, the fcm gem is still using the old sending method:
send_to_topic -> send_with_notification_key -> execute_notification

In the execute_notification method, the old endpoint (/fcm/send) and parameters are still in use
You must rewrite the function or add new methods for sending messages to a topic to work properly.
Here is a class where I added new methods for send topic to work again.
1, Firstly add the connection headers confign
# remove old headers
faraday.headers["Authorization"] = "key=#{api_key}"

# add new headers
faraday.headers['Authorization'] = "Bearer #{jwt_token}"
faraday.headers['access_token_auth'] = 'true'

2, The next define the method execute_notification_v1
# This function can be used for send_notification_v1
def execute_notification_v1(message)
  post_body = { message: }
  for_uri(BASE_URI_V1) do |connection|
    response = connection.post("#{@project_name}/messages:send", post_body.to_json)
    build_response(response)
  end
end

3, The last define the method send_to_topic_v1

The old method use the payload body = { to: notification_key }.merge(options) but on new method keyword to deprecate, using topic in message
Information here: https://firebase.google.com/docs/cloud-messaging/migrate-v1#update-the-payload-of-send-requests

def send_to_topic_v1(topic, options = {})
  return unless topic.gsub(TOPIC_REGEX, '').length.zero?

  body = { topic: }.merge(options)
  execute_notification_v1(body)
end

These changes got my project working properly again. Hope they help you.

Implement class FcmV1
class FcmV1 < FCM
  attr_accessor :json_key_path, :project_name

  def initialize(json_key_path:, project_name:)
    super(nil)
    @json_key_path = json_key_path
    @project_name = project_name
  end

  def send_to_topic_v1(topic, options = {})
    return unless topic.gsub(TOPIC_REGEX, '').length.zero?

    body = { topic: }.merge(options)
    execute_notification_v1(body)
  end

  private

  def for_uri(uri, extra_headers = {})
    connection = ::Faraday.new(
      url: uri,
      request: { timeout: DEFAULT_TIMEOUT }
    ) do |faraday|
      faraday.adapter Faraday.default_adapter
      faraday.headers['Content-Type'] = 'application/json'
      faraday.headers['Authorization'] = "Bearer #{jwt_token}"
      faraday.headers['access_token_auth'] = 'true'
      extra_headers.each do |key, value|
        faraday.headers[key] = value
      end
    end
    yield connection
  end

  def execute_notification_v1(message)
    post_body = { message: }
    for_uri(BASE_URI_V1) do |connection|
      response = connection.post("#{@project_name}/messages:send", post_body.to_json)
      build_response(response)
    end
  end
end

I forked the lib and made bug fix, while pull request is not accepted
https://github.com/aap17/fcm_v1


fix: Palette V3 text

The type of this PR is: Bugfix

This PR resolves CX-1917
Description
This PR fixes the Palette V3 text in sevaral places according to the Figma design.
PR Checklist (tick all before merging)

[ ] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[ ] I have tested my changes on iOS and Android.
[ ] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[ ] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added an app state migration, or my changes do not require one. (What are migrations?)
[ ] I have added a changelog entry below or my changes do not require one.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Warnings

:warning:

❌ An error occurred while validating your changelog, please make sure you provided a valid changelog.

  Generated by :no_entry_sign: dangerJS against 334132de1c223eab2b728ebb303b1fa2f26e6343


Error generating certificate with challenge

Checklist

Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?

Yes

Are you sure you're not using someone else's docker image?

Yes

Have you searched for similar issues (both open and closed)?

Yes

Describe the bug
Trying to generate a new certificate with DuckDNS.
Using the domain name and DuckDns token as credentials, I am consistently reaching this error:
Error: Command failed: certbot certonly --config "/etc/letsencrypt.ini" --work-dir "/tmp/letsencrypt-lib" --logs-dir "/tmp/letsencrypt-log" --cert-name "npm-22" --agree-tos --email "[EMAIL]" --domains "*.[DOMAIN].org,[DOMAIN].org" --authenticator dns-duckdns --dns-duckdns-credentials "/etc/letsencrypt/credentials/credentials-22"
Saving debug log to /tmp/letsencrypt-log/letsencrypt.log
The DNS response does not contain an answer to the question: [DOMAIN]. IN TXT
Ask for help or search for solutions at https://community.letsencrypt.org. See the logfile /tmp/letsencrypt-log/letsencrypt.log or re-run Certbot with -v for more details.
at ChildProcess.exithandler (node:child_process:402:12)
at ChildProcess.emit (node:events:513:28)
at maybeClose (node:internal/child_process:1100:16)
at Process.ChildProcess._handle.onexit (node:internal/child_process:304:5)

[DOMAIN] is mapped to a private/local IP.
The [DOMAIN] does resolve correctly on the DNS (checked on https://dnschecker.org/)
[DOMAIN] does resolve if I use Cloudflare as DNS
[DOMAIN] does resolve if I use my usual DNS (NextDNS).
I reach the same error regardless of whether I use Cloudflare or NextDNS though.
Nginx Proxy Manager Version
v2.10.4
Operating System
Ubuntu Server 22.04.3 LTS
Additional context
Nging Proxy manager is running through Docker with the following docker-compose file declaration:
nginx-proxy-manager:
container_name: nginx-proxy-manager
image: 'jc21/nginx-proxy-manager:latest'
environment:
PUID: 1000
PGID: 1000
restart: unless-stopped
ports:
- '80:80'
- '81:81'
- '443:443'
volumes:
- /srv/containers/nginx-proxy-manager/data:/data
- /srv/containers/letsencrypt:/etc/letsencrypt
The same error is achieved through Firefox or Chrome.

i liked nginxproxymanager for couple of years but since last year, something went wrong, and certs are borken. Move to caddy and never looked back. Yes you loose the webUI but its much simpler, faster, no bs. IT JUST WORKS and certs autorenew.


Inheritance (again)

Could we reconsider supporting inheritance in behaviors (e.g. custom elements, custom attributes)?
This was brought up (and closed) several times in the past, e.g. #84, #249.
@EisenbergEffect said

I don't think we're going to add this for now. I'm not sure it's a good idea. However, we have provided some options to use mixins to share behavior.

Could you provide more guidance regarding mixins support?
Motivation
In our codebase, several times we define a common base class for similar custom elements or custom attributes, with just slightly different configuration choices.
For example, we have a better <select> control as a custom element, that is instantiated in two flavours: with a local list of items and with an AJAX lookup. The base class defines some common behaviour and options.
This works for us, except that the metadata is not inherited. For example, the base class defines
@bindable
valueField = 'id';
@bindable
labelField = 'name';

But the @bindable annotation is lost on descendants and we have to copy-paste them on both the local and AJAX variations.
An analysis of the code shows that the problem in this specific case is that all CustomElement-related metadata is stored in a single object with key metadata.resource.
Because this dictionary exists in the derived class, properties of the base class are totally ignored.
I think that at least this part could be fixed by merging metadata.resource objects from derived to base class before usage by Aurelia.

@jods4 would a solution that lifts the @bindable properties from the base class to the derived class fulfill the need or are you looking for something more advanced? For example, reconciling the class-level attributes such as @inject, etc could be difficult/ambiguous. I'm trying to get a handle on the scope.

@jdanyow Somehow, @autoinject / @inject is already working fine for us in derived scenarios.
In our codebase, the only thing that we would need at the moment is have @bindable properties from base class discovered. I guess other people might have more complex needs, but @bindable is the main culprit for us.

@bindable is the main culprit for us.

same here.
@EisenbergEffect has suggested using decorators, but that takes much more effort compared to base class and if You happen to use TypeScript, then You really start to hate that approach (as TS compiler can't know at compile time what might be added at runtime to the class - so You either need to cast this to any before each use of properties/functions added by the decorator, or mess with interfaces to get type safety...).

I'm really apposed to inheritance. That doesn't mean we can't do this. It's likely to take a lower priority for the team though since there are other ways to handle the solution and other features/fixes that are more critical. However...if someone were to submit a PR that made inheritance work...with tests...then there's a good likely hood it would get in pretty quickly.

@EisenbergEffect Can you link some doc regarding the better ways? Thanks!

I don't have a doc specifically on that subject. Perhaps search the internet for "using decorators for composition" or something like that.

@jdanyow @EisenbergEffect I think the bindables from the base not being visible is the main issue and headache.
Can you point us in the right direction to where to start for this change?

Ok I commented on issue 210 but seems this is a more up to date ticket
Having @bindable work using inheritance I think is very important the only alternative is lots of copy and paste code
If there are some other options could a code example be provided

@Infuser I found this decorate in one of the ui bridges. Maybe it can help us in some way?
https://github.com/aurelia-ui-toolkits/aurelia-kendoui-bridge/blob/master/src/common/decorators.js

Thanks interesting I see people talking about it in this post not sure how to use it yet though need more time
https://github.com/aurelia-ui-toolkits/aurelia-kendoui-bridge/issues/232

I highly recommend to use decorators. You can basically use them to meta-program your JS classes. They can dynamically add shared behavior. Because they are decorators, you can have as many as you need as opposed to inheritance which only allows for one base class. Decorators favor the composition style of OO which gives you a better set of options than inheritance usually.

Hi Rob
Thanks for the response I am sure you are correct using decorators is a better approach sadly not sure what you mean could please provide a code example for this in relation to the @bindable issue
Thanks in advance

Well I gave it a try and had no luck using this web site as a guide
https://medium.com/google-developers/exploring-es7-decorators-76ecb65fb841#.g0voh5lni
I get inputbase is not a function

Ok here is a basic decorator that works with esnext I will try putting some bindables on it later
export function superhero(isSuperHero)
{
return function(target){
target.prototype.isSuperHero = isSuperHero;
}
}

Finally got a chance to have another look at this ended up with code below seems to work would appreciate any comments/constructive criticism's
import {inject, bindable, bindingMode} from 'aurelia-framework';
export function inputbase()
{
return function(target){
target.prototype.itemIdChanged1 = function itemIdChanged1() {debugger};
 let deco = bindable({
            name: 'itemId1',
            attribute: 'item-id1',
            changeHandler: 'itemIdChanged1',
            defaultBindingMode: bindingMode.oneWay
            }).bind(target);

     deco(target.prototype.constructor, undefined, undefined);

}
}

I have code ready for this, I'll prepare a PR with some explanations.
It's not trivial and although the change is rather small there is one part that will require a bit of review.

@EisenbergEffect I was testing my code and I banged my head again on the metadata inheritance in ES5 code transpiled by TS: aurelia/polyfills#34, Microsoft/typescript#4266.
TL;DR: if you want to mix class inheritance and metadata in ES5 code generated by TS:

it won't work at all in IE 10-, don't bother.
if your browser has native Reflect you are fine.
if your browser has native WeakMap, you can include CoreJS Reflect polyfill, which is based on it and it will work (unlike Aurelia's own polyfill).
if your browser has Object.setPrototypeOf, you can replace __extends TS helper method, e.g. with Babel equivalent helper, and it will work.

This is not directly-related to the upcoming PR but it is prominently showcased. ☹
Thoughts?

Is there some way that we could create a plugin for Aurelia that enabled inheritance. Things the plugin could do are: provide an alternate Reflect.metadata implementation, replace the __extends helper method if present, etc.

@EisenbergEffect The best thing we could do is try to convince TypeScript guys (again) that in 2017 having an ES6 compliant code-gen in 90% of the browsers and have an unfixable edge-case in 10% is better than being consistently incorrect. Or ask them to provide an easy opt-in (or better opt-out!) flag to turn on/off compliance. This is even worse now with --importHelpers as overriding __extends just got harder Microsoft/tslib#14. It is also similarly hard with webpack, which doesn't expose globals in this object.
Other than that, Aurelia could change its Reflect.metadata implementation to use WeakMap aurelia/polyfills#34. It would fix the problem for IE11+ (unfixable in IE 10- anyway).
Replacing __extends is not reliably doable.

@EisenbergEffect Great news, it seems MS might finally change their mind and have an ES-compliant __extends in capable browsers (IE11+), while retaining the current (but slightly different) behavior in IE10-.
See Microsoft/Typescript#12488

It's 6 months down the line, this feature is still not implemented. I agree on the flexibility of composition > inheritance, and understand that by using composition one can achieve essentially the same result.
I however do not agree with the complexity required to create simple components that could get away with inheritance. If I understand that my model is really a case that doesn't require composition, I wouldn't want to have to deal with the complexity of creating annotations and composing my components with these decorators. Like why use a scoped rifle when shooting close range?
@jods4 What ever came of your "Great news"

@tjad Agreed, it is a real headache to keep stumbling into this. As nice as it is to have a preferred approach  for how to model the components, we should have the ability to use inheritance for our own tastes.

I see, @jods4 has created a PR which is active
https://github.com/aurelia/templating/pull/507
Perhaps this should be closed.

I guess it can be closed when the PR is merged! The PR has been open for a long time now.

You and I need to chat so I can get a full rundown on this and current
transpiler limitations, if any. I'll try to catch you online in the next
couple of days.
On May 23, 2017 12:13 PM, "jods"<EMAIL_ADDRESS>wrote:

I guess it can be closed when the PR is merged! The PR has been open for a
long time now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aurelia/templating/issues/463#issuecomment-303502334,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIBnSdn87qf7qw8G1mhCQFq_k-MTfH2ks5r8y-1gaJpZM4J992I
.

This can be closed. I've just tested it working in the latest release!

Ran into a situation a few days ago where an easy solution was to bind to a base class in my custom components. Was pleasantly surprised to see such a long standing issue solved just in time for me to utilize this functionality. Great work!


add Arduino-CI + prepare unit tests

Based upon - https://github.com/marketplace/actions/arduino_ci
Goal
The goal of continuous integration and unit testing is to have a set of automated actions to improve the quality and consistency of the code and its interface. To reach this goal two major steps exist

Automatic compilation of all examples on different platforms  this PR
Automatic unit tests  disabled

The automatic build of examples shows

the library compiles
the examples compile

The automatic compilation is done for (to be expanded in the future)

uno
leonardo
due
zero

Unit Tests disabled
The unit test is disabled by altering its extension. The reason is that the mocking / including of the complete Arduino environment is not complete yet. An issue has been raised for this and equivalent libraries - https://github.com/Arduino-CI/arduino_ci/issues/251
Notes

Code of library has not changed.
Option to add badges in the readme.md file  like below to show status of library

(these are just an example)

update
This PR solves #182  a new issue for updating the unit tests could be made.

update
This PR solves #182  a new issue for updating the unit tests could be made.

Let me know if you're ready to merge, looks like a good initial addition

I'm ready,
already preparing the next step today, the Arduino-lint workflow .
I have about 40 fails in 120 libraries so I'm busy for a few days 😎  (also means ~80 are OK)

Got some first feedback from the Arduino-lint action for the Dallas Temp lib
See - https://github.com/RobTillaart/Arduino-Temperature-Control-Library/runs/2686896760?check_suite_focus=true

Easy fix is adding a license file

Created an issue (question)  about the filename - https://github.com/arduino/arduino-lint/issues/178


[BUG] The description of throttlingPercent in the documentation is incorrect

What happened:
文档中关于throttlingPercent的描述没有更新，和代码实现不一致。

What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

App version:
Kubernetes version (use kubectl version):
Install details (e.g. helm install args):
Node environment (for koordlet/runtime-proxy issue):

Containerd/Docker version:
OS version:
Kernal version:
Cgroup driver: cgroupfs/systemd

Others:

Nice catch. The memory.high calculation is upgraded following the K8S 1.27 (see #1455), so the documentation is outdated.

it will be great if you can update the website

/assign @j4ckstraw
https://github.com/koordinator-sh/website

To be fixed by https://github.com/koordinator-sh/website/pull/180


Mention that you need to have Inventory keybind set to "B"

Title's self-explanatory, didn't work for me at first. That or open inventory by clicking on the icon, which I guess should be harder.

Hi there, this step is outlined in the readme for the project.

This README's way more specified than the instructions in the program though, not everyone will read the GitHub one.


Not encrypting fields

Hello,
I have a problem with field encryption. My project creates database per tenant, so I have multiple databases and each database has it's own encryption key. I connect to the databases using this function:
export const prismaClientSingleton = async (
  connectionString: string,
  encryptionKey: string,
): Promise<PrismaClient> => {
  const client = new PrismaClient({
    datasources: {
      client_db: {
        url: connectionString,
      },
    },
  });

  client.$extends(
    fieldEncryptionExtension({
      encryptionKey,
      dmmf: Prisma.dmmf,
    }),
  );

  return client;
};

declare const globalThis: {
  clientDb: Awaited<ReturnType<typeof prismaClientSingleton>>;
} & typeof global;

export async function instantiateClientDb() {
  let db;

  if (globalThis.clientDb) {
    db = globalThis.clientDb;
  } else {
    db = await prismaClientSingleton(
      getEnv('DATABASE_URL', { required: true })!,
      getEnv('PRISMA_FIELD_ENCRYPTION_KEY', { required: true })!,
    );

    globalThis.clientDb = db;
  }

  return {
    organization: organizationApi(db),
  };
}

Also I am using prismaSchemaFolder, where I have multiple schema files, so maybe because I am using preview features it does not work properly?
previewFeatures = ["prismaSchemaFolder"]

I run my app with DEBUG="prisma-field-encryption:*"
and I only get prisma-field-encryption:setup which shows me models and fields that should be encrypted. But when I do an insert to database or anything else it does not show anything and data in database is not encrypted.
Example:
 prisma-field-encryption:setup   Employee: {
  prisma-field-encryption:setup     cursor: 'id',
  prisma-field-encryption:setup     fields: {
  prisma-field-encryption:setup       personalId: [Object],
  prisma-field-encryption:setup       taxId: [Object],
  prisma-field-encryption:setup       bankAccount: [Object],
  prisma-field-encryption:setup       workEmail: [Object],
  prisma-field-encryption:setup       phone: [Object],
  prisma-field-encryption:setup       address: [Object],
  prisma-field-encryption:setup       iceName: [Object],
  prisma-field-encryption:setup       icePhone: [Object]
  prisma-field-encryption:setup     },
  prisma-field-encryption:setup     connections: {
  prisma-field-encryption:setup       avatar: [Object],
  prisma-field-encryption:setup       children: [Object],
  prisma-field-encryption:setup       photos: [Object],
  prisma-field-encryption:setup       employmentHistory: [Object],
  prisma-field-encryption:setup       education: [Object],
  prisma-field-encryption:setup       projects: [Object],
  prisma-field-encryption:setup       languages: [Object],
  prisma-field-encryption:setup       courses: [Object],
  prisma-field-encryption:setup       earnings: [Object],
  prisma-field-encryption:setup       documents: [Object]
  prisma-field-encryption:setup     }
  prisma-field-encryption:setup   },

What am I doing wrong here?

Could you try and set the DEBUG_DEPTH environment variable to 10 or something larger, to show the contents of those setup field objects?
I haven't tried the prismaSchemaFolder feature yet, though as long as the DMMF resolves to your whole schema, I don't think it should matter much where the schema files are located.

debug log:
prisma-field-encryption:setup   Employee: {
  prisma-field-encryption:setup     cursor: 'id',
  prisma-field-encryption:setup     fields: {
  prisma-field-encryption:setup       personalId: { encrypt: true, strictDecryption: false },
  prisma-field-encryption:setup       taxId: { encrypt: true, strictDecryption: false },
  prisma-field-encryption:setup       bankAccount: { encrypt: true, strictDecryption: false },
  prisma-field-encryption:setup       workEmail: {
  prisma-field-encryption:setup         encrypt: true,
  prisma-field-encryption:setup         strictDecryption: false,
  prisma-field-encryption:setup         hash: {
  prisma-field-encryption:setup           targetField: 'workEmailHash',
  prisma-field-encryption:setup           algorithm: 'sha256',
  prisma-field-encryption:setup           salt: undefined,
  prisma-field-encryption:setup           inputEncoding: 'utf8',
  prisma-field-encryption:setup           outputEncoding: 'hex'
  prisma-field-encryption:setup         }
  prisma-field-encryption:setup       },
  prisma-field-encryption:setup       phone: { encrypt: true, strictDecryption: false },
  prisma-field-encryption:setup       address: { encrypt: true, strictDecryption: false },
  prisma-field-encryption:setup       iceName: { encrypt: true, strictDecryption: false },
  prisma-field-encryption:setup       icePhone: { encrypt: true, strictDecryption: false }
  prisma-field-encryption:setup     },
  prisma-field-encryption:setup     connections: {
  prisma-field-encryption:setup       avatar: { modelName: 'EmployeePhoto', isList: false },
  prisma-field-encryption:setup       children: { modelName: 'EmployeeChild', isList: true },
  prisma-field-encryption:setup       photos: { modelName: 'EmployeePhoto', isList: true },
  prisma-field-encryption:setup       employmentHistory: { modelName: 'EmployeeEmploymentHistory', isList: true },
  prisma-field-encryption:setup       education: { modelName: 'EmployeeEducation', isList: true },
  prisma-field-encryption:setup       projects: { modelName: 'EmployeeProject', isList: true },
  prisma-field-encryption:setup       languages: { modelName: 'EmployeeLanguage', isList: true },
  prisma-field-encryption:setup       courses: { modelName: 'EmployeeCourse', isList: true },
  prisma-field-encryption:setup       earnings: { modelName: 'EmployeeEarnings', isList: true },
  prisma-field-encryption:setup       documents: { modelName: 'EmployeeDocument', isList: true }
  prisma-field-encryption:setup     }
  prisma-field-encryption:setup   },

Ah wait I found the issue, $extends returns the extended client, it's not like the previous middleware approach.
So your Prisma client singleton creation function should look like this (assuming you're not doing anything else in there, you could also drop the async):
export const prismaClientSingleton = async (
  connectionString: string,
  encryptionKey: string,
): Promise<PrismaClient> => {
  const client = new PrismaClient({
    datasources: {
      client_db: {
        url: connectionString,
      },
    },
  });

  return client.$extends(
    fieldEncryptionExtension({
      encryptionKey,
      dmmf: Prisma.dmmf,
    }),
  );
};

The logs showed the setup step as it runs when the client is created, but indeed the extension was not used, as the unextended client was returned.

Oh! I will check it and let you know!

@franky47 that helped! Everything works now. Thanks!


Feature Request and Update

Hi Drakonian,
From my OnPrem Point of view:
I have update the permission to the base Page, so that only super user can use this page as it is to powerfull to be used by any normal user (maybe special Permission should be obsolete? ). So I add a trigger on init like this:
trigger OnInit()
var
UserPermissions: Codeunit "User Permissions";
begin
if not UserPermissions.IsSuper(UserSecurityId()) then
Error('Only Super User can load this please contact Admins.');
end;
if you do not like the changes or think they are bad pelase simply clos the issue, as I cannot find a topic feature request I always open it under issue.
br wikrie

Hi,
I agree with you, it's bad idea give everyone access to data editor.
Now only Super user or user with Data Editor Tool permission set will be able to use DataEditor
see:
https://github.com/Drakonian/data-editor-for-bc/commit/efe67d5089e3ecfdc617c1edf96a332a4e28af5b


[Bug] serving benchmark would be hung if samples 1500 prompts

Checklist

[x] 1. I have searched related issues but cannot get the expected help.
[x] 2. The bug has not been fixed in the latest version.

Describe the bug
serving benchmark would be hung if samples were 1500 prompts and 48 concurrent requests.
Reproduction
python profile_serving.py ***
Error traceback
4 mins passed and nothing returned.

08/28 16:37:50 - service.ft - INFO - session 25, pre seq_len 0, cur seq_len 1434, diff 1434
08/28 16:37:54 - service.ft - INFO - session 9, pre seq_len 0, cur seq_len 732, diff 732
08/28 16:37:55 - service.ft - INFO - session 22, pre seq_len 0, cur seq_len 1165, diff 1165
08/28 16:38:01 - service.ft - INFO - session 15, pre seq_len 0, cur seq_len 1163, diff 1163
08/28 16:38:02 - service.ft - INFO - session 4, pre seq_len 0, cur seq_len 996, diff 996

^CProcess Process-88:
Process Process-70:
Process Process-73:
Process Process-57:
Process Process-63:
Process Process-52:
Traceback (most recent call last):

Fixed in PR #344


Sentinel - change author on whats-new-archive.md (to retire)

Change author so I can retire topic

Learn Build status updates of commit f26f237:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: GitBranchDeletedOrForcePushed]

Cannot sync git repo to specified commit because ref +refs/pull/100892/merge has been deleted or has been force pushed.
 If this is pull request, please ensure it is mergeable (no merge conflict) and open (not closed).

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


No credit field

Need to add <field name="credit" type="string" indexed="true" stored="true" multiValued="true"/> to the ckan_registry and ckan_portal cores. Match https://github.com/open-data/ckanext-canada/blob/master/conf/solr/schema.xml

Added credit field in https://github.com/open-data/docker-og-solr/commit/da0a224f2fc6f2a4d04eb2ded7cd9db170a69b67
Did a docker build, commit, and push to https://hub.docker.com/r/opendatacanada/solr. Just need to confirm that the new build commit worked.

Confirmed that the new image on docker hub containers the multi-valued credit field for the two cores.


[ENH] Add Lags kwarg in chainopy.MarkovSwitchingModel

Currently, the Internal Auto-Regressive Model doesn't take Lags into Account.

As completed.


Fix ports in Ingress backend specification

When using non-numerical port settings, such as use-annotation (which is used by the AWS Load Balancer Controller), we need to use name field instead of number field.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


Embedding and related structs should derive Clone

https://github.com/pgvector/pgvector-rust/blob/v0.2.1/src/vector.rs#L10
Vector does not derive Clone and it's quite inconvenient.

Hi @deavid, added in the commit above. What do you mean by "related structs"?


[text analytics] Modification of grapheme to deal with service changes

Hold off until service has made changes, verify how it works once they add text to Text Analytics

Merged into feature branch, ended up removing mentions of grapheme for v3.0


Adding one global Exception Handler

Let's say I have 5 different exceptions that I want to handle. I want to create 5 different files, and then apply them once in main.py (like for router) how can I do that?
I want in main.py something like this:
app.add_exception_handler(my_global_handler)

and in my folder I have 5 files with different exception, here's the example of one:
@app.exception_handler(ParamValidationError)
@app.exception_handler(ClientError)
async def boto_param_validation_error(request: Request, exc: ParamValidationError):
    logger.error("[boto_param_validation_error] Error. %s", exc)
    return JSONResponse(
        status_code=400,
        content={"message": "Bad request."},
    )

in case with router I did
api_router = APIRouter()
api_router.include_router(login.router, prefix="/login", tags=["login"])
...
...

and then in main.py app.include_router(api_router) is there anything similar that I can do with exception handlers?

You could just write a function that takes app as a parameter:
def add_exception_handlers(app: FastAPI) -> None:
    @app.exception_handler(ClientError)
    async def boto_param_validation_error():
        ...

    @app.exception_handler(AnotherException)
    async def another handler():
        ...

And then call it like
add_exception_handlers(app)

@nzig yeah, I thought about that, I was wondering if passing the app is a good practice. Well, if there's no way of doing it in a fancy way, will do that.

Hi @PetrShchukin , I was also checking how to do this in a fancy elegant way. It turns out that FastAPI has a method called add_exception_handler that you can use to do this.
Your exception handler must accept request and exception
Here is an example of my exception handlers definitions:
from fastapi import Request, status
from fastapi.responses import JSONResponse

from api.core.log.caishen_logger import logger

from .authentication import AuthenticationProviderException
from .authorization import UnAuthorizedUser

async def unauthorized_user_handler(
    request: Request, exc: UnAuthorizedUser
) -> JSONResponse:
    logger.warning(**exc.log.dict())
    headers = getattr(exc, "headers", None)
    if headers:
        return JSONResponse(
            {"detail": exc.log.msg},
            status_code=exc.log.status_code,
            headers=headers,
        )
    else:
        return JSONResponse(
            {"detail": exc.log.msg},
            status_code=exc.log.status_code,
        )

async def authentication_provider_error_handler(
    request: Request,
    exc: AuthenticationProviderException,
) -> JSONResponse:
    logger.error(**exc.log.dict())
    headers = getattr(exc, "headers", None)
    if headers:
        return JSONResponse(
            {"detail": exc.log.msg},
            status_code=exc.log.status_code,
            headers=headers,
        )
    else:
        return JSONResponse(
            {"detail": exc.log.msg},
            status_code=exc.log.status_code,
        )

And how I'm using it on the main.py file:
from fastapi import FastAPI
from fastapi.middleware.cors import CORSMiddleware

from api.core import exceptions
from api.core.exceptions.handlers import (
    authentication_provider_error_handler,
    unauthorized_user_handler,
)
from api.utils.database import create_super_user

from .routers import login, users
from .settings import settings

app = FastAPI(
    title=settings.PROJECT_NAME,
    description="This API handles User Accounts for the Caishen App",
)

# Add Custom Exception Handlers
app.add_exception_handler(
    exceptions.UnAuthorizedUser, handler=unauthorized_user_handler
)

app.add_exception_handler(
    exceptions.AuthenticationProviderMissmatch,
    handler=authentication_provider_error_handler,
)
 ...


docker buildx not working with default settings

I'm using the docker/setup-buildx-action@v1 step to setup buildx but for some reason this fails. I'm using the default runner and settings. What might be the issue here?

https://github.com/docker/setup-buildx-action/issues/16 give it a context

@callum-tait-pbx just giving it a context didn't work for me. What ended up working was adding these steps:
      - name: setup docker context for buildx
        id: buildx-context
        run: |
          docker context create builders
      - name: setup docker buildx
        uses: docker/setup-buildx-action@v1
        with:
          endpoint: builders

@ToonvanStrijp Thanks for sharing!
Probably we'd better enhancing README to include various tips for setting up common things?

Let me move this to Discussion for easy reference.


Allow custom Mustache template use

Actually, the lib doesn't allow to use custom Mustache template. It would add a lot of flexibility if we could optionally provide our own custom template path in options.

@mrgnou It's absolutely possible to use custom templates, please read about rendering configurations.


Specify specific SQLite version?

Hello,
It seems such hasn't been asked before and perhaps as such, I am unsure about interest and likelihood of such being possible or added. Is there a way to specify and pin a specific SQLite version, or version greater than/equal, etc.? It seems such can't be done at the moment; might you someday consider it? For testing purposes, I believe such can be downloaded and there is a specific format for the archive URL, using specific branches such as trunk would be nice too.

Hi,
specifying/locking versions is already possible in CocoaPods: https://guides.cocoapods.org/using/the-podfile.html
For example, to stay on 3.30.0, you just have to specify pod 'sqlite3', '3.30.0' in your Podfile.

What you can always do is, make your own podspec file based on sqlite3.podspec and in your Podfile, reference it via the podspec argument, e.g. pod 'sqlite3', podspec: '~/foo/mysqlite3pod'. Then you can just modify it, e.g. s.source = { git: '...', branch: '...' } in your sqlite3.podspec.

Good idea, thank you. Perhaps such may make it into this pod itself though unsure if any others would use it. who knows.


readme: fixed cli table

Fixed cli flags.
Cli flags are given to the generally accepted syntax and added some commands.
List added flags: --time, --pb
Changed syntax: For example,
--p  -->  -p

Thanks for your contribution!


Allow building & comparing output from old D compilers for the editor

When watching CyberShadow's Bugzilla I spotted this amazing tool dreg and hey it's not that hard to build a docker image for it and make it available for everyone, s.t. no setup is required.
N.B.: Currently the docker image doesn't build all versions (it takes too long to execute everything), but auto-deploy is already configured & we can easily add more versions.
It already works nicely on the CLI:

As dreg runs multiple compilers in parallel, it requires more memory as well. For my tests increasing it from 128M to 256M seems to work well, but just to be sure I would increase it to 512M for dreg (the machine only allows 10 compilations in parallel anyways).
Things TODO

[x] Disable all coloring for the web output (not perfect yet)
[x] Figure out how many versions can be run, s.t. the experience is "smooth"

Preview

CC @CyberShadow

There is only one way to find out whether this works -> let's try this live :)

Hmm while it still works fine locally:

We still run into timeouts on the server:

@CyberShadow it's working nicely online now :tada:
Have a look at these examples:

https://is.gd/ckNT9i
https://is.gd/UZhQDh

Cool :) Why is "Success" in red?

Why is "Success" in red?

Because I am stupid:
https://github.com/dlang-tour/core/pull/601
(Should be deployed soon)


Mobile devices?

Hi!
Here is an Idea for future releases:
Need create responsive layout for mobiles & tables based on screen width:
-mobiles
-tablets
-desktops
So mail can be accessed from anywhere, not just PC
Thanks:)

Support for mobile devices is one of the applications long term goals and a planned feature (including PWA implementation)
Currently is not a prioritary goal and most probably will be tackled in the long term.
As of now, the application is responsive but unusable in mobile devices (probably not so bad in a tablet or surface device).


Restore After Dark

This story could be different... https://habd.as/code/after-dark/

Why would the Hugo Themes showcase feature a theme that has documentation about enabling a crypto miner module? https://git.habd.as/comfusion/after-dark/src/branch/master/docs/content/module/toxic-swamp.md
Don't know if cryptocurrency mining is considered mainstream in your parts of the planet, but at least in Europe this is a rather controversial topic and we are not going to discuss the nature of cryptocurrencies here.
The Hugo Themes Showcase is not meant as a directory to enable cryptocurrency mining.
I cannot possibly see how we could re-add your theme to the website given the above development on top of not allowing self-hosted repositories for themes.
cc: @digitalcraftsman @bep

There's nothing mainstream about innovation.

Because After-Dark is a kick-ass theme for Hugo, maximizing the potential of a static site on Hugo.

optional (and opensource) mining module, the user can disable it and the website owner can even not include it to begin with... an interesting and modern alternative to annoying ads popping up everywhere, being not only unintrusive but also disabled if the website using it is not opened and being read by the user (aka if the tab is open but not focused, it doesn't do anything)
anyway, the thing is optional, please don't make a unnecessary fuss over it

@guitmz @tkalpakidis The fuss is not unnecessary. We know that it is an optional module embedded in After Dark but to be honest there is nothing innovative about crypto-mining on unsuspecting website visitors. Also there are other kick-ass themes in the repo that do not promote cryptocurrencies.
The Hugo Themes showcase does not accept promotions of any kind.
Also there is the matter of the self hosted git repository that was implemented for security reasons. This hasn't changed since this theme was removed a year ago.
Theme submission rules need to be respected or themes are removed from the list.

I will close this.

Scmuck

@onedrawingperday What are these security reasons?
You are using git submodules. I don't see the point how GitHub would make that more secure. Care to explain?

@einzelgaenger
GitHub, GitLab etc. are reputable git providers that have dedicated security teams to deal with the latest vulnerabilities etc.
We cannot trust self hosted git repositories because we really cannot tell if such repos are secured properly and we cannot know what might get pushed down the line to a user's computer.
So that's why this requirement was put in the theme submission guidelines a year ago.


bug: CoreAvatarGroup is not working properly in mobile

Describe the bug
There is a bug in CoreAvatarGroup related to no of item to show.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Stack Trace
The stack trace of the bug if any.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

CoreAvatarGroup is not working properly in mobile (max props)


Add stream support

Hope this looks good I tried to follow your code format as close as possible and managed to make do without adding any new dependencies.
There are some "smart" things we could add in later like auto-reconnect but for right now this is a solid  implementation we can use as building blocks for more advanced features later.

Hey @tylerbuchea thanks so much!!!
Sorry I was out of town this weekend. Taking a look right now!

No worries hope you had a good weekend 😄

Closes #1


Reduce log verbosity in etcd client set method.

Avoids log spam in Felix when writing status reports.

cool - didn't know you could do context logs like that 👍
LGTM


Arma plots

After completing this one I've realized that the last segment of plotting could be somewhat simplified. Potentially this simplification could be performed later?

I guess it depends on how much they would be simplified.  If you think that it would make the code much more clear, then it may be worth doing sooner rather than later.  My main worry would be forgetting about it.
Can you create a new issue (or add to the existing metaissue) with a checklist of the ones you want to review, and a note on the change you would intend to make?

@ajozefiak Just want to confirm that you're not proposing structural changes to code (for example, a lot of our plots are wrapped inside kind of opaque plotting functions like gen_plots, and maybe it would be clearer to take them out). Because I think that kind of stuff we can hold off on until we start refactoring in earnest.
But, like @jlperla said, I don't see any reason not to make any other quick fixes.

@arnavs The last snippet of code has functions like plot_simulation and these seem a bit excessive for this one lecture. I can hold off on any such structural changes, but this was one particular lecture that stood out to me.

For sure. I think that kind of excessive complexity will be fixed in the rewriting pass

Plots look great, merging now.


Android Basics: ViewModel - Score and wordCount textViews are not updated throughout the game

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-training-viewmodel?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-kotlin-unit-3-pathway-3%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-training-viewmodel#12
In which task and step of the codelab can this issue be found?
13
Describe the problem
While it's easy to implement, the text views for wordcount and score are never updated throughout the game/lesson.
These values are initialized in onViewcreated, and never updated again.
binding.score.text = getString(R.string.score, 0)
binding.wordCount.text = getString(
        R.string.word_count, 0, MAX_NO_OF_WORDS)

I resolved this by adding 2 new functions to update these values based on the data in the viewModel, and calling these functions in onViewCreated, onSubmitWord, and onSkipWord.
    private fun updateWordCount() {
        binding.wordCount.text = getString(
            R.string.word_count, viewModel.currentWordCount, MAX_NO_OF_WORDS
        )
    }

    private fun updateScore() {
        binding.score.text = getString(R.string.score, viewModel.score)
        updateWordCount()
    }

Looks like this is addressed immediately in the next section. 🤦


Windows improved support (meson)

this PR is an improvement of #352, managing to compile statically and run unit tests successfully on windows.
a summary of the changes in this PR:

Meson file

use c++14 on windows(due to an error with xstddef)
add a preprocessor definition ('NON_AMBIGOUS_OVERLOAD') to use int instead of long to prevent ambiguous overload when compiling with clang++, it does not affect cmake and it only is enabled on meson

Unit tests

tests/Statement_test.cpp -> use "int64_t"(supported on c++11) instead of "long long" to prevent ambiguous overload errors (tested both on Arch Linux & Windows w clang)
tests/Statement_test.cpp -> check if NON_AMBIGOUS_OVERLOAD is defined and use int instead of long if is the case (to prevent ambiguous overload on windows)

the library still does not compile dynamically (as windows does not export the functions by default), so that should be fixed on an 3rd PR potentially fixing #280 and #53 for both meson and cmake, but this is a start before working on adding a macro for that feature.
after the dynamic compilation on windows is fixed, we could put the package on wrapdb so more users can use it easily.

Thanks a lot for this contribution.
Cheers!


Change: Fix invalid filename parsing

The filename of zip archives were compared using .ends_with.
However, this led to invalid parsing case like matching "README.chromedriver" as "chromedriver" binary.
This PR properly implements filename matching using std::path::Path::file_name().

This should fix #50.


fix fix unstable pk uk case (#23390)

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Train script for face landmark model

Can you open Training script for the face landmark model?
I just want to make sure this is Open Source Project, not only Open Binary.
Thank you.

I guess it's a dulplication of https://github.com/google/mediapipe/issues/11. Let's add mgyong@ to see if he has more comments on this.

Hi @whatisor, You can refer here.