Error : ng build -prod => The Broccoli Plugin: [BundlePlugin] failed

When i want build my project in production mode (ng build -prod), The Broccoli Plugin can't found a file. However, the command ng build work normaly.

OS => Windows 7

Versions :

angular-cli: 1.0.0-beta.1
node: 6.1.0
os: win32 x64

Repro steps. Was this an app that wasn't created using the CLI? What change did you
do on your code?
I update my project from angular cli v0.37 to 1.0.0 beta. 1 . My current project work fine.

Logs:
D:\projects\PocNewBad\src\new-bad\aix\base-project-angular-cli>ng build -prod
(node:8768) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent
version.
| Building(node:8768) DeprecationWarning: 'root' is deprecated, use 'global'
(node:8768) DeprecationWarning: 'GLOBAL' is deprecated, use 'global'
Build failed.
The Broccoli Plugin: [BundlePlugin] failed with:
Error on fetch for app/index.js at file:///D:/base-project-angular-cli/tmp/bundle_plugin-input_base_path-KQb5d
Vmu.tmp/0/app/index.js
Error: ENOENT: no such file or directory, open 'D:\base-project-angular-cli\tmp\bundle_plugin-input_ba
se_path-KQb5dVmu.tmp\0\app\index.js'
at Error (native)

The broccoli plugin was instantiated at:
at BundlePlugin.Plugin (D:\base-project-angular-cli\node_modules\broccoli-plugin\index.js:10:31)
at BundlePlugin.CachingWriter [as constructor] (D:\base-project-angular-cli\node_modules\broccoli-caching-
writer\index.js:21:10)
at BundlePlugin (D:\base-project-angular-cli\node_modules\angular-cli\lib\broccoli\angular-broccoli-bundle
.js:11:5)
at Angular2App._getBundleTree (D:\base-project-angular-cli\node_modules\angular-cli\lib\broccoli\angular2-
app.js:375:55)
at Angular2App._buildTree (D:\projects\PocNewBad\src\new-bad\aix\base-project-angular-cli\node_modules\angular-cli\lib\broccoli\angular2-app.
js:137:21)
at new Angular2App (D:\projects\PocNewBad\src\new-bad\aix\base-project-angular-cli\node_modules\angular-cli\lib\broccoli\angular2-app.js:42:2
3)
at module.exports (D:\projects\PocNewBad\src\new-bad\aix\base-project-angular-cli\angular-cli-build.js:6:10)
at Class.module.exports.Task.extend.setupBroccoliBuilder (D:\projects\PocNewBad\src\new-bad\aix\base-project-angular-cli\node_modules\angular
-cli\lib\models\builder.js:55:19)
at Class.module.exports.Task.extend.init (D:\projects\PocNewBad\src\new-bad\aix\base-project-angular-cli\node_modules\angular-cli\lib\models
builder.js:89:10)
at new Class (D:\projects\PocNewBad\src\new-bad\aix\base-project-angular-cli\node_modules\core-object\core-object.js:18:12)
at Class.module.exports.Task.extend.run (D:\projects\PocNewBad\src\new-bad\aix\base-project-angular-cli\node_modules\angular-cli\lib\tasks\bu
ild.js:15:19)
at D:\projects\PocNewBad\src\new-bad\aix\base-project-angular-cli\node_modules\angular-cli\lib\commands\build.js:32:24
at lib$rsvp$$internal$$tryCatch (D:\projects\PocNewBad\src\new-bad\aix\base-project-angular-cli\node_modules\rsvp\dist\rsvp.js:1036:16)
at lib$rsvp$$internal$$invokeCallback (D:\projects\PocNewBad\src\new-bad\aix\base-project-angular-cli\node_modules\rsvp\dist\rsvp.js:1048:17)
at lib$rsvp$$internal$$publish (D:\\base-project-angular-cli\node_modules\rsvp\dist\rsvp.js:1019:11)
at lib$rsvp$asap$$flush (D:\\base-project-angular-cli\node_modules\rsvp\dist\rsvp.js:1198:9)

I will check if i found something, I post my solve.
Thank a lot :-)

We have solve the problem by init all project :-)

ng build -prod
Could not start watchman; falling back to NodeWatcher for file system events.
Visit http://ember-cli.com/user-guide/#watchman for more info.
Build failed.
Same here. Nothing helps.
without -prod everything works fine. But with -prod I get:
Error on fetch for ng2-bootstrap/ng2-bootstrap at file:///Users/arunassmaliukas/Projects/angularattack2016-smala/tmp/bundle_plugin-input_base_path-swarpJzu.tmp/0/ng2-bootstrap/ng2-bootstrap
	Loading app/template-builder.component.js
	Loading app/index.js
	Loading main.js
	Error: ENOENT: no such file or directory, open '/Users/arunassmaliukas/Projects/angularattack2016-smala/tmp/bundle_plugin-input_base_path-swarpJzu.tmp/0/ng2-bootstrap/ng2-bootstrap'
    at Error (native)```

Have tried remove node_modules dist tmp folders, `ng init`, etc.. nothing helps :(

Is this a known issue? ng build works fine and my package file gets created inside the vendor folder. However, ng build -prod does not work. It seems weird as it works with one command and not with the other. Hope someone can enlighten us about this :smile:

Yes, I can also reproduce this with beta 4. ng build works fine whereas ng build -prod gives [BundlePlugin] error.

Same problem with the newest rc1

Facing the same issue.. +1
Build failed.
The Broccoli Plugin: [BundlePlugin] failed with:
Error on fetch for main.js at file:///Projects/wanna-web/tmp/bundle_plugin-input_base_path-fvVJG6ng.tmp/0/main.js
Error: ENOENT: no such file or directory, open '/Projects/wanna-web/tmp/bundle_plugin-input_base_path-fvVJG6ng.tmp/0/main.js.map'
at Error (native)

You get this error only when you change the default ng-cli structure .
src/app/main.ts will work fine
src/new-folder/app/main.ts you will get that error while build -prod
Hope this can help to slove it.

I left the original structure alone and it does not work :(
my main.ts is under projectname/frontend/src/maint.ts and underneath src there is /app. That is how the ng init created the structure. I might moved the whole folder around, but that should not be a problem, right?

can you make it  projectname/src/maint.ts
that will fix it.
if you want to compile it to a different location "ng build -prod --output-path dist/frontend-app"

@ifaouibadi I have kept the original structure and it doesn't work :)

Same problem is happening for me too. I've not changed the structure, the only thing I've done is added angular2-google-maps. It works fine when just using build but the -prod flag gice the error of
The Broccoli Plugin: [BundlePlugin] failed with:
Error on fetch for angular2-google-maps/core.js at file:///Users/marcuswilliams/Hosts/bailey_hunt/tmp/bundle_plugin-input_base_path-6rPioF0w.tmp/0/angular2-google-maps/core.js
	Loading main.js
	Error: ENOENT: no such file or directory, open '/Users/marcuswilliams/Hosts/bailey_hunt/tmp/bundle_plugin-input_base_path-6rPioF0w.tmp/0/angular2-google-maps/core.js'
    at Error (native)

The broccoli plugin was instantiated at:
    at BundlePlugin.Plugin (/Users/marcuswilliams/Hosts/bailey_hunt/node_modules/angular-cli/node_modules/broccoli-caching-writer/node_modules/broccoli-plugin/index.js:10:31)
    at BundlePlugin.CachingWriter [as constructor] (/Users/marcuswilliams/Hosts/bailey_hunt/node_modules/angular-cli/node_modules/broccoli-caching-writer/index.js:21:10)
    at BundlePlugin (/Users/marcuswilliams/Hosts/bailey_hunt/node_modules/angular-cli/lib/broccoli/angular-broccoli-bundle.js:11:10)
    at Angular2App._getBundleTree (/Users/marcuswilliams/Hosts/bailey_hunt/node_modules/angular-cli/lib/broccoli/angular2-app.js:421:22)
    at Angular2App._buildTree (/Users/marcuswilliams/Hosts/bailey_hunt/node_modules/angular-cli/lib/broccoli/angular2-app.js:159:21)
    at new Angular2App (/Users/marcuswilliams/Hosts/bailey_hunt/node_modules/angular-cli/lib/broccoli/angular2-app.js:53:23)
    at module.exports (/Users/marcuswilliams/Hosts/bailey_hunt/angular-cli-build.js:6:10)
    at Class.module.exports.Task.extend.setupBroccoliBuilder (/Users/marcuswilliams/Hosts/bailey_hunt/node_modules/angular-cli/node_modules/angular-cli/lib/models/builder.js:55:19)
    at Class.module.exports.Task.extend.init (/Users/marcuswilliams/Hosts/bailey_hunt/node_modules/angular-cli/node_modules/angular-cli/lib/models/builder.js:89:10)
    at new Class (/Users/marcuswilliams/Hosts/bailey_hunt/node_modules/angular-cli/node_modules/angular-cli/node_modules/core-object/core-object.js:18:12)
    at Class.module.exports.Task.extend.run (/Users/marcuswilliams/Hosts/bailey_hunt/node_modules/angular-cli/node_modules/angular-cli/lib/tasks/serve.js:15:19)
    at /Users/marcuswilliams/Hosts/bailey_hunt/node_modules/angular-cli/node_modules/angular-cli/lib/commands/serve.js:64:24
    at lib$rsvp$$internal$$tryCatch (/Users/marcuswilliams/Hosts/bailey_hunt/node_modules/angular-cli/node_modules/angular-cli/node_modules/rsvp/dist/rsvp.js:1036:16)
    at lib$rsvp$$internal$$invokeCallback (/Users/marcuswilliams/Hosts/bailey_hunt/node_modules/angular-cli/node_modules/angular-cli/node_modules/rsvp/dist/rsvp.js:1048:17)
    at /Users/marcuswilliams/Hosts/bailey_hunt/node_modules/angular-cli/node_modules/angular-cli/node_modules/rsvp/dist/rsvp.js:331:11
    at lib$rsvp$asap$$flush (/Users/marcuswilliams/Hosts/bailey_hunt/node_modules/angular-cli/node_modules/angular-cli/node_modules/rsvp/dist/rsvp.js:1198:9)

This seems to be https://github.com/angular/angular-cli/issues/847#issuecomment-220944072, isn't it?

The version I'm using already has those changes

Same issue with angular2-material :
Error on fetch for<EMAIL_ADDRESS>at<EMAIL_ADDRESS>        Loading main.js
        Error: ENOENT: no such file or directory, open<EMAIL_ADDRESS>    at Error (native)

The broccoli plugin was instantiated at:
    at BundlePlugin.Plugin (/home/jboulay/Projets/MoiChef/easynov-web/node_modules/angular-cli/node_modules/broccoli-caching-writer/node_modules/broccoli-plugin/index.js:10:31)
    at BundlePlugin.CachingWriter [as constructor] (/home/jboulay/Projets/MoiChef/easynov-web/node_modules/angular-cli/node_modules/broccoli-caching-writer/index.js:21:10)
    at BundlePlugin (/home/jboulay/Projets/MoiChef/easynov-web/node_modules/angular-cli/lib/broccoli/angular-broccoli-bundle.js:10:36)
    at Angular2App._getBundleTree (/home/jboulay/Projets/MoiChef/easynov-web/node_modules/angular-cli/lib/broccoli/angular2-app.js:421:22)
    at Angular2App._buildTree (/home/jboulay/Projets/MoiChef/easynov-web/node_modules/angular-cli/lib/broccoli/angular2-app.js:159:21)
    at new Angular2App (/home/jboulay/Projets/MoiChef/easynov-web/node_modules/angular-cli/lib/broccoli/angular2-app.js:53:23)
    at module.exports (/home/jboulay/Projets/MoiChef/easynov-web/angular-cli-build.js:6:10)
    at Class.module.exports.Task.extend.setupBroccoliBuilder (/home/jboulay/Projets/MoiChef/easynov-web/node_modules/angular-cli/node_modules/angular-cli/lib/models/builder.js:55:19)
    at Class.module.exports.Task.extend.init (/home/jboulay/Projets/MoiChef/easynov-web/node_modules/angular-cli/node_modules/angular-cli/lib/models/builder.js:89:10)
    at new Class (/home/jboulay/Projets/MoiChef/easynov-web/node_modules/angular-cli/node_modules/angular-cli/node_modules/core-object/core-object.js:18:12)
    at Class.module.exports.Task.extend.run (/home/jboulay/Projets/MoiChef/easynov-web/node_modules/angular-cli/node_modules/angular-cli/lib/tasks/build.js:15:19)
    at /home/jboulay/Projets/MoiChef/easynov-web/node_modules/angular-cli/node_modules/angular-cli/lib/commands/build.js:32:24
    at lib$rsvp$$internal$$tryCatch (/home/jboulay/Projets/MoiChef/easynov-web/node_modules/angular-cli/node_modules/angular-cli/node_modules/rsvp/dist/rsvp.js:1036:16)
    at lib$rsvp$$internal$$invokeCallback (/home/jboulay/Projets/MoiChef/easynov-web/node_modules/angular-cli/node_modules/angular-cli/node_modules/rsvp/dist/rsvp.js:1048:17)
    at /home/jboulay/Projets/MoiChef/easynov-web/node_modules/angular-cli/node_modules/angular-cli/node_modules/rsvp/dist/rsvp.js:331:11
    at lib$rsvp$asap$$flush (/home/jboulay/Projets/MoiChef/easynov-web/node_modules/angular-cli/node_modules/angular-cli/node_modules/rsvp/dist/rsvp.js:1198:9)

I've found many issues regarding build failing with -prod option.
One of them gives a fix for issues with angular2-material lib : https://github.com/angular/angular-cli/issues/940#issuecomment-222265264

I still have the same issue with RC1. Why is this closed?
angular-cli: 1.0.0-beta.5
node: 5.4.1
os: darwin x64 (OS X)

@datrinh this issue is closed because it was already solved and the solution was found. In your case, it looks like you upgraded a project, see https://github.com/angular/angular-cli/issues/847#issuecomment-220944072 .

Seemingly the same issue here.
I'm using Angular Rc 1
angular-cli: 1.0.0-beta.5
node: 6.2.1
os: win32 x64

"make sourcemaps relative in tsconfig.json by removing mapRoot:" my tsconfid didn't include mapRoot
"configure angular-cli-build.js to also copy vendor map files:" it was also there already.
"update local project angular-cli version to 1.0.0-beta.5." It's already that version

Try deleting tmp and dist before trying again
How does your system-config.ts look?

Thnx. I deleted tmp and dist.
You gave me an idea to test: I'll try to remove theinternal packages.
My system-config.ts is:
`/***********************************************************************************************

User Configuration.
********************************************************************************************/
/ Map relative paths to URLs. */
const map: any = {
"changedName": "node_modules/changedName"
};

/** User packages configuration. */
const packages: any = {
"changedName": {
format: "cjs",
defaultExtension: "js"
}
};
////////////////////////////////////////////////////////////////////////////////////////////////
/***********************************************************************************************

Everything underneath this line is managed by the CLI.
**********************************************************************************************/
const barrels: string[] = [
// Angular specific barrels.
'@angular/core',
'@angular/common',
'@angular/compiler',
'@angular/http',
'@angular/router',
'@angular/router-deprecated',
'@angular/platform-browser',
'@angular/platform-browser-dynamic',

// Thirdparty barrels.
'rxjs',
// App specific barrels.
'app',
'app/shared',
/** @cli-barrel */
];
const cliSystemConfigPackages: any = {
"node_modules/changedName/":"node_modules/changedName//dist/index.js"
};
barrels.forEach((barrelName: string) => {
cliSystemConfigPackages[barrelName] = { main: 'index' };
});
/** Type declaration for ambient System. */
declare var System: any;
// Apply the CLI SystemJS configuration.
System.config({
map: {
'@angular': 'vendor/@angular',
'rxjs': 'vendor/rxjs',
'main': 'main.js',
"changedName": "node_modules/changedName"
},
packages: cliSystemConfigPackages
});
// Apply the user's configuration.
System.config({ map, packages });`

I removed the internal packages (I referenced them by 'changedName' above).
ng build --prod still fails for me.

Just installed angular-cli 2 days ago and have the same/similar problem
Error on fetch for app/models/IArtist.js at file:///C:/Data/PlayMeExtension/tmp/bundle_plugin-input_base_path-VZeniFqQ.tmp/0/app/models/IArtist.js
Loading app/models/index.js
Error: ENOENT: no such file or directory, open 'C:\Data\PlayMeExtension\tmp\bundle_plugin-input_base_path-VZeniFqQ.tmp\0\app\models\IArtist.js'
However, IArtist is a definition file (IArtist.d.ts) - i wonder if that has something to do with it?
build without -prod works file

I had a lot of problems with the prod built. My angular-cli project was built with beta 4 and the first thing I did was to migrate all the blueprinted-files manually. Since I am using external libraries like ng2-bootstrap or regular ones like chart.js it was even more difficult to get the prod-built running. A good thing to start is to create the simplest angular-cli project you can imagine and test the prod-built. Then add something you added in your real project and try the prod built again until it breaks. You can also try figuring out the difference between the "simplest angular-cli" project and your project by comparing them in an editor. With this technique I could upgrade my project files pretty easy from v4 to v5
Right now I am looking through my file changes in git, that I did after this in order to get the prod-built working. I hope you will find the solution for your problem:
angular-cli.build.js
Make sure, that all the needed libraries include the .map files, especially for your custom added ones.(like this:  @angular/**/*.+(ts|js|js.map) ). Also make sure, that you choose the right folder of the package. In my case of "chart.js" I had to include every folder and subfolder to make it work ( chart.js/**/*.+(js|js.map) ). Well, this does not seem right, but it works for right now
system-config.ts
Make sure to set the right format for the package. An example of my system-config is here:
/***********************************************************************************************
 * User Configuration.
 **********************************************************************************************/
/** Map relative paths to URLs. */
const map: any = {
  "ng2-bootstrap" : "vendor/ng2-bootstrap",
  "moment"        : "vendor/moment/moment.js",
  "ng2-table"     : "vendor/ng2-table",
  "ng2-charts"    : "vendor/ng2-charts",
  "ng2-uploader"  : "vendor/ng2-uploader",
  'chartjs'       : 'vendor/chart.js/dist/Chart.bundle.js',
  "dragula"       : "vendor/dragula/dist/dragula.js",
  "ng2-dragula"   : "vendor/ng2-dragula"
};

/** User packages configuration. */
const packages: any = {
  'ng2-bootstrap':{ format: "cjs", main: 'ng2-bootstrap.js',"defaultExtension": "js" },
  'ng2-table':{ format: "cjs", main: 'ng2-table.js',"defaultExtension": "js" },
  'ng2-charts':{ format: "cjs", main: 'ng2-charts.js',"defaultExtension": "js" },
  'ng2-uploader':{ format: "register", main: 'ng2-uploader.js',"defaultExtension": "js" },
  'dragula':{ format: "global" },
  'ng2-dragula':{ format: "cjs", main: "ng2-dragula", "defaultExtension": "js" },
  'chartjs':{ format: "global" },
  'moment':{ format: "cjs", defaultExtension: "js" }

};

////////////////////////////////////////////////////////////////////////////////////////////////
/***********************************************************************************************
 * Everything underneath this line is managed by the CLI.
 **********************************************************************************************/
const barrels: string[] = [
  // Angular specific barrels.
  '@angular/core',
  '@angular/common',
  '@angular/compiler',
  '@angular/http',
  '@angular/platform-browser',
  '@angular/platform-browser-dynamic',
  '@angular/router',
  // Thirdparty barrels.
  'rxjs',

  // App specific barrels.
  'app',
  'app/shared',
  'app/dashboard',
  'app/folio',
  'app/folio/foliodetail',
  'app/competence',
  'app/export',
  'app/product',
  'app/system',
  'app/appcontent',
  'app/competence/competencedetail',
  'app/folio/foliolist',
  'app/appcontent/appcontent-tab',
  'app/listboxes',
  /** @cli-barrel */
];

const cliSystemConfigPackages: any = {};
barrels.forEach((barrelName: string) => {
  cliSystemConfigPackages[barrelName] = { main: 'index' };
});

/** Type declaration for ambient System. */
declare var System: any;

// Apply the CLI SystemJS configuration.
System.config({
  map: {
    '@angular': 'vendor/@angular',
    'rxjs': 'vendor/rxjs',
    'main': 'main.js'
  },
  packages: cliSystemConfigPackages
});

// Apply the user's configuration.
System.config({ map, packages });

** main component ts **
In my main component file I had to add an import for chartjs and dragula so that the SystemJS-Builder knows about them
import 'chartjs';
import  'dragula';

I also added the typings for those Standard/Global libraries, but I guess this is more important for the IDE.

@hmrc87 I've done all the changes you suggested - still no luck :-(
Build failed.
The Broccoli Plugin: [BundlePlugin] failed with:
Error on fetch for main.js at file:///C:/my-folder/tmp/bundle_plugin-input_base_path-YFP4tyEM.tmp/0/main.js
        Error: ENOENT: no such file or directory, open 'C:\my-folder\tmp\bundle_plugin-input_base_path-YFP4tyEM.tmp\0\main.js.map'
    at Error (native)

The broccoli plugin was instantiated at:
    at BundlePlugin.Plugin (C:\my-folder\node_modules\broccoli-plugin\index.js:10:31)
    at BundlePlugin.CachingWriter [as constructor] (C:\my-folder\node_modules\broccoli-caching-writer\index.js:21:10)
    at BundlePlugin (C:\my-folder\node_modules\angular-cli\lib\broccoli\angular-broccoli-bundle.js:10:36)
    at Angular2App._getBundleTree (C:\my-folder\node_modules\angular-cli\lib\broccoli\angular2-app.js:375:55)
    at Angular2App._buildTree (C:\my-folder\node_modules\angular-cli\lib\broccoli\angular2-app.js:137:21)
    at new Angular2App (C:\my-folder\node_modules\angular-cli\lib\broccoli\angular2-app.js:42:23)
    at module.exports (C:\my-folder\angular-cli-build.js:6:10)
    at Class.module.exports.Task.extend.setupBroccoliBuilder (C:\my-folder\node_modules\angular-cli\lib\models\builder.js:55:19)
    at Class.module.exports.Task.extend.init (C:\my-folder\node_modules\angular-cli\lib\models\builder.js:89:10)
    at new Class (C:\my-folder\node_modules\core-object\core-object.js:18:12)
    at Class.module.exports.Task.extend.run (C:\my-folder\node_modules\angular-cli\lib\tasks\build.js:15:19)
    at C:\my-folder\node_modules\angular-cli\lib\commands\build.js:32:24
    at lib$rsvp$$internal$$tryCatch (C:\my-folder\node_modules\rsvp\dist\rsvp.js:1036:16)
    at lib$rsvp$$internal$$invokeCallback (C:\my-folder\node_modules\rsvp\dist\rsvp.js:1048:17)
    at lib$rsvp$$internal$$publish (C:\my-folder\node_modules\rsvp\dist\rsvp.js:1019:11)
    at lib$rsvp$asap$$flush (C:\my-folder\node_modules\rsvp\dist\rsvp.js:1198:9)

@ghpabs it looks like your project was created with an old version of the CLI. See https://github.com/angular/angular-cli#updating-angular-cli for a way to upgrade your local files.

@filipesilva you're absolutely right. Updating angular-cli to @latest did the trick.

Hi,
i'm able to serve the files with http server, ng serve. But I want to deploy to tomcat server, I ran the command ng build -prod and got the dist folder created. I need to place the dist folder content inside project folder of webapps. Let say, sampleapp is my project folder, I copied all the contents ,generated in dist folder to sampleapp folder. When i access the application in getting lot of 404 error(
http://localhost:8080/vendor/systemjs/dist/system.src.js). It seems Angular is looking in root direectory. How can i customize the build to read it from my project directory?
like
http://localhost:8080/sampleapp/vendor/systemjs/dist/system.src.js
I tried editing the index.html tag ,  and then built. No luck
Which file I have to look out for the ng-build command. Please help me out in finding the solution


Added a missing apostrophe

I tried to upload my thesis but couldn't, so I made this pull request instead.

Coverage decreased (-13.1%) to 30.839% when pulling 3a97b77f6da662e0a21ce4d6c34b441c33efc6dd on itron:master into 3988c3a6f6bfa84e0c0caa4901890c595eee170c on ultra-hyper-storm-ohtuprojekti:master.

Sorry about not seeing this earlier but it really took me off guard to see a pull request 😃 . Much appreciated to have a little help once in a while. This time though I got notified about the problem other way and I fixed this minor bug on #113 so I'll be closing this pull request unmerged.


New Installers Fail Under System Account - Which is Used by Azure Custom Script Extension for running instance scripts

Please fill out all the sections below for bug issues, otherwise it'll be closed as it won't be actionable for us to address.
Describe the bug
When run under the system account by the terraform provider azurerm_virtual_machine_extension, the script errors out when trying to add the scheduled task.
To Reproduce
Steps to reproduce the behavior:

Use azurerm_virtual_machine_extension to run this script which simply uses the Azure Custom Script Extension.
Observe errors in file: C:\Packages\Plugins\Microsoft.Compute.CustomScriptExtension*\Status\0.status

Expected behavior
To be able to orchestrate the installation from the SYSTEM account.
The official docs for these scripts talk about the Azure Custom Script Extension as though it is supported: https://learn.microsoft.com/en-us/virtualization/windowscontainers/quick-start/set-up-environment?tabs=containerd#custom-script-extensions - but I'm wondering if it has been tested with this code because I'm not having success.
Configuration:

Edition: [e.g. Windows 11, Windows Server]
Base Image being used: [e.g. Windows Server Core]
Container engine: [e.g. docker]
Container Engine version [e.g. 22]

Additional context
Add any other context about the problem here.

FYI - in my scenario I did not need the hyper-v feature - maybe that could be controlled by a switch since it seems to be the reason for a mid-install reboot?

Hi, thanks for bringing this issue to our attention! Would you mind attaching a file or pasting the errors you saw in file C:\Packages\Plugins\Microsoft.Compute.CustomScriptExtension*\Status\0.status so we can identify whether we encounter the same ones?

I ended up using just the containers install and using chocolatey to install the docker cli.
The code was part of a blog for Microsoft and is here: https://gitlab.com/guided-explorations/microsoft/azure-aks/aks-windows/-/blob/master/gitlab-infra/aks-terraform/shell-runner-with-docker-install.ps1?ref_type=heads

Ah interesting. I wonder if there was an Issue with not having Docker on the system or configured improperly. Just to make sure I understand, where you trying to set up a GitLab Runner on an Azure virtual machine using the Azure Custom Script Extension?

I'll close this for now but please let us know if you encounter any other issues. Thanks.


Aditional carto layers

lidar
ortophoto
another openlayers with more details (something like opentopo or similar)

this was implemented. for now we only added lidar and ortophoto layers. others wil be added in the future


Installing submodules

I want to install the "history" type file from react-router: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/react-router/history.d.ts
So I try this:
typings install --ambient --save react-router/history

The module is found, but I get this error:
 ENOENT: no such file or directory, open '<project-dir>/typings/main/ambient/react-router/history/react-router/history.d.ts'

I could create that directory, but the error makes me wonder if I am doings something wrong?

Sadly a known issue and needs to be fixed. I'll patch it ASAP. Duplicate of https://github.com/typings/typings/issues/221.


[occm] Do not create HTTP monitors for UDP on old Octavia

What this PR does / why we need it:
Octavia API before 2.16 doesn't support HTTP monitors on UDP pools. It will however allow creation of such if all-in-one LB creation call is used. This is a problem for UDP ETP=Local Services, where healthCheckNodePort is allocated and CCM will try to create HTTP monitor there. This monitor will be completely not functional.
This commit fixes that by making sure we're checking Octavia API version and if it's lower than 2.16 we fall back to creating UDP-CONNECT health monitors on a regular port instead.
Which issue this PR fixes(if applicable):
fixes #1999
NONE

@dulek Sorry if offtopic, but how did you manage to make the loadbalancer work on UDP?
I'm getting the same error in the OCCM logs each time saying that UDP is not supported:
failed to ensure load balancer: only TCP LoadBalancer is supported for openstack load balancers
thanks

@dulek Sorry if offtopic, but how did you manage to make the loadbalancer work on UDP? I'm getting the same error in the OCCM logs each time saying that UDP is not supported:
failed to ensure load balancer: only TCP LoadBalancer is supported for openstack load balancers

It's offtopic, but you're setting use-octavia: false and that's why you see this. Neutron-lbaas doesn't support anything else than TCP.

/ok-to-test

@jichenjc: Can you help me here? Seems like there's some vendoring issue that can be fixed by go mod vendor, but running it doesn't produce anything commitable, so I'm pretty confused here.

Can you help me here? Seems like there's some vendoring issue that can be fixed by go mod vendor, but running it doesn't produce anything commitable, so I'm pretty confused here.

I think we don't use vendor any more?
https://maelvls.dev/go111module-everywhere/
maybe go mod tidy can help or with GO111MODULE=on  ?

Can you help me here? Seems like there's some vendoring issue that can be fixed by go mod vendor, but running it doesn't produce anything commitable, so I'm pretty confused here.

I think we don't use vendor any more? https://maelvls.dev/go111module-everywhere/ maybe go mod tidy can help or with GO111MODULE=on  ?

Okay, it was so simple, I just had to remove vendor directory. Thank you!

/override openstack-cloud-csi-cinder-e2e-test

/lgtm
/approve


A python program to create your own Cryptocurrency

I have made a solution for creating your own crypto Currency  using python . So kindly merge my PR. And assign this task to  me.

Hi, Can you assign this issue to me. I wanted to create a PR.


Basic Rendering branch not rendering or throwing any errors

Appreciate the book. I have also purchased your previous SDL2 game engine book.
After completing the basic rendering chapter I was unable to render anything onto the window. I am not receiving any errors.  2 days of troubleshooting I decided to download the "basic_rendering" branch as was recommended in the book and run my project with that. However I am still not able to render to the window nor am I receiving any error messages .  Much more strange, to troubleshoot I change glClearColorValue(0, 0, 0, 1) to glClearColor(1, 0, 0, 1) to see if I could at least see red. The window remains black.
I am doing the course on a 64 bit linux machine. KDE Neon.

Hum!! This is weird. I don't know; maybe it has to do with your Linux distro. Since you are not getting any error messages, it's quite difficult to pinpoint the problem.

I understand the book was released a few months ago, but is there a forum or discord or something? I just want to see if there's anyone else who came across this on linux.


Terminates and Rollback on Route 53 setup

Hello,
I've tried to utilise this stack twice without success. As soon as it tries to set up the Route 53 section it fails, terminates and rolls back. I'm trying to set it up in ap-southeast-2 using the launch button. Whilst I'm no AWS expert I can't see what I might be doing wrong.
Also, I note whilst ap-southeast-2 is listed as supported in the description here, it is not listed in the CloudFormation stack description, only the other regions are. Any advice is appreciated.
Nathan
Stack Detail.pdf

Nathan,
I had a Route53 rollback due to not creating a Hosted Zone  prior to running the template as the template creates the record set, not the Hosted Zone itself--in my case, I was just trying to test the CloudFormation template on test.mysite.com and realized the template rolls back if the test.mysite.com Hosted Zone is not created ahead of time  and fails if run just on mysite.com as it does not create my desired test.mysite.com Hosted Zone.
If you are trying to just run this on mysite.com, know the template desires to create an A-Record of www.mysite.com... so, if this record already exists in Route53, it can't create another one and I would expect the template to fail/rollback.
Just sharing a couple of my experiences for your consideration...
Regards, Mike

Nathan,
Mike is right.  Create the hosted zone first using Route 53 then include the domain name as the WPDomain parameter.
It is fully supported in ap-southeast-2.
Let us know if this resolves your issue.
Darryl

Hello Mike & Darryl,
Thanks for the prompt response, much appreciated.
Yes, I was going to try setting up the record framework and running the script though wasn't such how much needed to be entered without interrupting the script. I may use white label nameservers in the future so I'll consider options in terms of when I set the Route 53 records up. Thanks again for your assistance.
Regards
Nathan


[DocumentIntelligence] GetClassifiers response headers exceeding limit

After upgrading the service version to 2024-07-31-preview, the GetClassifiers test started failing with the following error:
Azure.RequestFailedException : The HTTP response headers length exceeded the set limit of 65536 bytes.

We need to investigate whether this issue can be reproduced with the REST API and report it to the service team with necessary.
The test is currently being ignored but must be re-enabled once it's fixed.

The issue seems to be fixed now. It seemed to be a transient issue.


[Enhancement] MaxCompute Catalog to Utilize Partition Filter During Partition Fetch

Why I'm doing:
Currently, when fetching partition information from the MaxCompute Catalog, the system retrieves all partitions without the ability to filter based on certain criteria. This can result in unnecessary I/O and processing overhead, especially when dealing with large datasets with numerous partitions. The goal of this enhancement is to introduce partition filtering to improve efficiency.
What I'm doing:
Implement partition filtering within the MaxCompute Catalog's logic that fetches partition information. This would allow users to specify conditions such as a partition key, range, or other attributes, and only retrieve the partitions that match these criteria.
Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

please rebase main and retry FE UT


Azure Pipeline task goes to time out then crashes when running Visual Studio 2022 from windows-2022 env

Please check our current Issues to see if someone already reported this https://github.com/Microsoft/azure-pipelines-task-lib/issues
Environment
azure-pipelines-task-lib version:
Issue Description
When running windows-2022 env to run Visual Studio 2022 with Azure DevOps CmdLine@2 task, the task runs fine but does not detect that Visual Studio 2022 finished the work.
After 58 min, the task timeout, code raises an exception, and job fails.
I call this task to build a MSI based on a Microsoft Installer Project in the solution, for a .NET 6 application.
Microsoft Installer Project is in windows-2022 env.
Issue initially created in https://github.com/actions/virtual-environments/issues/4880.
Issue occurs in the ToolFunctions.ps1 file.
Expected behaviour
Task should no timeout and crashes.
Actual behaviour
Task does not detect that Visual Studio finished to execute.
After 58 min, an exception is raised

2022-01-11T21:28:43.9707538Z Updating the Control table...
2022-01-11T21:28:43.9716755Z Updating the ControlEvent table...
2022-01-11T21:28:43.9718617Z Updating the CustomAction table...
2022-01-11T21:28:43.9720316Z Updating the Property table...
2022-01-11T21:28:43.9720854Z
2022-01-11T21:28:43.9722779Z Post-build events finished
2022-01-11T21:28:43.9926453Z ========== Rebuild All: 2 succeeded, 0 failed, 0 skipped ==========
2022-01-11T22:23:29.7358977Z ##[debug]Re-evaluate condition on job cancellation for step: 'CmdLine'.
2022-01-11T22:23:37.3714210Z Terminate batch job (Y/N)?
2022-01-11T22:23:37.5307904Z Entering debug mode. Use h or ? for help.
2022-01-11T22:23:37.5308679Z
2022-01-11T22:23:37.5630910Z At D:\a_tasks\CmdLine_d9bafed4-0b18-4f58-968d-86655b4d2ce9\2.182.0\ps_modules\VstsTaskSdk\ToolFunctions.ps1:113
2022-01-11T22:23:37.5632056Z char:13
2022-01-11T22:23:37.5632349Z
2022-01-11T22:23:37.5632851Z + if ($originalEncoding) {
2022-01-11T22:23:37.5633211Z
2022-01-11T22:23:37.5633733Z + ~~~~~~~~~~~~~~~~~
2022-01-11T22:23:37.8131767Z ##[debug]Leaving Invoke-VstsTool.
2022-01-11T22:23:37.8475086Z ##[debug]Leaving D:\a_tasks\CmdLine_d9bafed4-0b18-4f58-968d-86655b4d2ce9\2.182.0\cmdline.ps1.
2022-01-11T22:23:37.9330128Z ##[error]The operation was canceled.
2022-01-11T22:23:37.9349411Z ##[debug]System.OperationCanceledException: The operation was canceled.
at System.Threading.CancellationToken.ThrowOperationCanceledException()
at Microsoft.VisualStudio.Services.Agent.Util.ProcessInvoker.ExecuteAsync(String workingDirectory, String fileName, String arguments, IDictionary2 environment, Boolean requireExitCodeZero, Encoding outputEncoding, Boolean killProcessOnCancel, InputQueue1 redirectStandardIn, Boolean inheritConsoleHandler, Boolean keepStandardInOpen, Boolean highPriorityProcess, CancellationToken cancellationToken)
at Microsoft.VisualStudio.Services.Agent.ProcessInvokerWrapper.ExecuteAsync(String workingDirectory, String fileName, String arguments, IDictionary2 environment, Boolean requireExitCodeZero, Encoding outputEncoding, Boolean killProcessOnCancel, InputQueue1 redirectStandardIn, Boolean inheritConsoleHandler, Boolean keepStandardInOpen, Boolean highPriorityProcess, CancellationToken cancellationToken)
at Microsoft.VisualStudio.Services.Agent.Worker.Handlers.DefaultStepHost.ExecuteAsync(String workingDirectory, String fileName, String arguments, IDictionary`2 environment, Boolean requireExitCodeZero, Encoding outputEncoding, Boolean killProcessOnCancel, Boolean inheritConsoleHandler, CancellationToken cancellationToken)
at Microsoft.VisualStudio.Services.Agent.Worker.Handlers.PowerShell3Handler.RunAsync()
at Microsoft.VisualStudio.Services.Agent.Worker.TaskRunner.RunAsync()
at Microsoft.VisualStudio.Services.Agent.Worker.StepsRunner.RunStepAsync(IStep step, CancellationToken jobCancellationToken)
2022-01-11T22:23:37.9359065Z ##[section]Finishing: CmdLine

Pipeline YML
# .NET Desktop

# Build and run tests for .NET Desktop or Windows classic desktop solutions.
# Add steps that publish symbols, save build artifacts, and more:
# https://docs.microsoft.com/azure/devops/pipelines/apps/windows/dot-net

trigger:
- master

pool:
  vmImage: 'windows-2022'

variables:
  solution: '**/*.sln'
  buildPlatform: 'Any CPU'
  buildConfiguration: 'Release'

steps:
- task: NuGetToolInstaller@1

- task: NuGetCommand@2
  inputs:
    restoreSolution: '**\AMSExplorer\AMSExplorer.csproj'

- task: CmdLine@2
  inputs:
    script: '"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\devenv.com" AMSExplorer.sln /Rebuild Release'
    workingDirectory: '$(System.DefaultWorkingDirectory)'

- task: PublishPipelineArtifact@1
  inputs:
    targetPath: '$(System.DefaultWorkingDirectory)\Setup\Release'
    artifact: 'Setup'
    publishLocation: 'pipeline'

Steps to reproduce

Use Azure DevOps and setup a pipeline to build an app
YML for the pipeline and simple sample Visual Studio Solution is provided in this zip :
project-with-yml.zip
Run the pipeline

Logs
6_CmdLine.zip

Try adding my agent screenshot task, my guess is that visual studio has a
modal dialog preventing it from closing.
https://marketplace.visualstudio.com/items?itemName=jessehouwing.agent-screenshot
On Tue, 18 Jan 2022, 14:11 Xavier Pouyat, @.***> wrote:

Please check our current Issues to see if someone already reported this
https://github.com/Microsoft/azure-pipelines-task-lib/issues
Environment
azure-pipelines-task-lib version:
Issue Description
When running windows-2022 env to run Visual Studio 2022 with Azure DevOps
@.*** task, the task runs fine but does not detect that Visual Studio
2022 finished the work.
After 58 min, the task timeout, code raises an exception, and job fails.
I call this task to build a MSI based on a Microsoft Installer Project in
the solution, for a .NET 6 application.
Microsoft Installer Project is in windows-2022 env.
Issue initially created in actions/virtual-environments#4880
https://github.com/actions/virtual-environments/issues/4880.
Issue occurs in the ToolFunctions.ps1
https://github.com/microsoft/azure-pipelines-task-lib/blob/b901effb8eaf6455b3044d57b0e0b4121aa7aa30/powershell/VstsTaskSdk/ToolFunctions.ps1#L112
file.
Expected behaviour
Task should no timeout and crashes.
Actual behaviour
Task does not detect that Visual Studio finished to execute.
After 58 min, an exception is raised
[image: 2022-01-12_10h17_48]
https://user-images.githubusercontent.com/8104205/149942190-e71a855b-bf8e-4245-a929-7e49df0967a0.png
2022-01-11T21:28:43.9707538Z Updating the Control table...
2022-01-11T21:28:43.9716755Z Updating the ControlEvent table...
2022-01-11T21:28:43.9718617Z Updating the CustomAction table...
2022-01-11T21:28:43.9720316Z Updating the Property table...
2022-01-11T21:28:43.9720854Z
2022-01-11T21:28:43.9722779Z Post-build events finished
2022-01-11T21:28:43.9926453Z ========== Rebuild All: 2 succeeded, 0 failed, 0 skipped ==========
2022-01-11T22:23:29.7358977Z ##[debug]Re-evaluate condition on job cancellation for step: 'CmdLine'.
2022-01-11T22:23:37.3714210Z Terminate batch job (Y/N)?
2022-01-11T22:23:37.5307904Z Entering debug mode. Use h or ? for help.
2022-01-11T22:23:37.5308679Z
2022-01-11T22:23:37.5630910Z At D:\a_tasks\CmdLine_d9bafed4-0b18-4f58-968d-86655b4d2ce9\2.182.0\ps_modules\VstsTaskSdk\ToolFunctions.ps1:113
2022-01-11T22:23:37.5632056Z char:13
2022-01-11T22:23:37.5632349Z
2022-01-11T22:23:37.5632851Z + if ($originalEncoding) {
2022-01-11T22:23:37.5633211Z
2022-01-11T22:23:37.5633733Z + ~~~~~~~~~~~~~~~~~
2022-01-11T22:23:37.8131767Z ##[debug]Leaving Invoke-VstsTool.
2022-01-11T22:23:37.8475086Z ##[debug]Leaving D:\a_tasks\CmdLine_d9bafed4-0b18-4f58-968d-86655b4d2ce9\2.182.0\cmdline.ps1.
2022-01-11T22:23:37.9330128Z ##[error]The operation was canceled.
2022-01-11T22:23:37.9349411Z ##[debug]System.OperationCanceledException: The operation was canceled.
at System.Threading.CancellationToken.ThrowOperationCanceledException()
at Microsoft.VisualStudio.Services.Agent.Util.ProcessInvoker.ExecuteAsync(String workingDirectory, String fileName, String arguments, IDictionary2 environment, Boolean requireExitCodeZero, Encoding outputEncoding, Boolean killProcessOnCancel, InputQueue1 redirectStandardIn, Boolean inheritConsoleHandler, Boolean keepStandardInOpen, Boolean highPriorityProcess, CancellationToken cancellationToken)
at Microsoft.VisualStudio.Services.Agent.ProcessInvokerWrapper.ExecuteAsync(String workingDirectory, String fileName, String arguments, IDictionary2 environment, Boolean requireExitCodeZero, Encoding outputEncoding, Boolean killProcessOnCancel, InputQueue1 redirectStandardIn, Boolean inheritConsoleHandler, Boolean keepStandardInOpen, Boolean highPriorityProcess, CancellationToken cancellationToken)
at Microsoft.VisualStudio.Services.Agent.Worker.Handlers.DefaultStepHost.ExecuteAsync(String workingDirectory, String fileName, String arguments, IDictionary`2 environment, Boolean requireExitCodeZero, Encoding outputEncoding, Boolean killProcessOnCancel, Boolean inheritConsoleHandler, CancellationToken cancellationToken)
at Microsoft.VisualStudio.Services.Agent.Worker.Handlers.PowerShell3Handler.RunAsync()
at Microsoft.VisualStudio.Services.Agent.Worker.TaskRunner.RunAsync()
at Microsoft.VisualStudio.Services.Agent.Worker.StepsRunner.RunStepAsync(IStep step, CancellationToken jobCancellationToken)
2022-01-11T22:23:37.9359065Z ##[section]Finishing: CmdLine
Pipeline YML
.NET Desktop
Build and run tests for .NET Desktop or Windows classic desktop solutions.
Add steps that publish symbols, save build artifacts, and more:
https://docs.microsoft.com/azure/devops/pipelines/apps/windows/dot-net
trigger:

master

pool:
vmImage: 'windows-2022'
variables:
solution: '**/*.sln'
buildPlatform: 'Any CPU'
buildConfiguration: 'Release'
steps:

task: @.***

task: @.***
inputs:
restoreSolution: '**\AMSExplorer\AMSExplorer.csproj'

task: @.***
inputs:
script: '"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\IDE\devenv.com" AMSExplorer.sln /Rebuild Release'
workingDirectory: '$(System.DefaultWorkingDirectory)'

task: @.***
inputs:
targetPath: '$(System.DefaultWorkingDirectory)\Setup\Release'
artifact: 'Setup'
publishLocation: 'pipeline'

Steps to reproduce

Use Azure DevOps and setup a pipeline to build an app
YML for the pipeline and simple sample Visual Studio Solution is
provided in this zip :
project-with-yml.zip
https://github.com/microsoft/azure-pipelines-task-lib/files/7889216/project-with-yml.zip
Run the pipeline

Logs
6_CmdLine.zip
https://github.com/microsoft/azure-pipelines-task-lib/files/7889227/6_CmdLine.zip
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/azure-pipelines-task-lib/issues/813, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AA724S4HTBPKBQVWQS5RGQDUWVRHHANCNFSM5MHEHVMQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

That's one of the dangers of running devenv.com to build the project instead of relying on msbuild.

I modified the YML and this is the screenshot I get. Please note that I manually canceled the job when the Visual Studio task was completed (I did not wait for the task to timeout naturally after 58 min. I will post another new screenshot later today when the task timesout)

Screenshot is the same if I wait for the task to timeout naturally.

Looks like visual studio is properly killed prior to the screenshot being taken, that's unfortunate.

I've read the history of the other issues you mention and can definitely tell that the issue is not related to this repository. Thanks!

I have this same exact issue.  Has a solution been found?   I am incorporating MSI builds into on-prem Azure DevOps build.  All online blogs indicate you have to use 'devenv.com' to get something to remotely work.....but the task hangs until the timeout fires and the build step indicates failure even though the MSI is actually built.  @xpouyat @jessehouwing

The best solution is to migrate to Wix. The visual studio installer projects are just not and have never really been stable in a CI/CD environment.

Thanks for the reply.


Add person awarding the win to the leaderboard

Along with showing the person that received the most wins, show a list of who has given the most wins out as well. This will incentivize use.
Original issue (bitovi internal)

From @traitano

I always thought it would be a great addition to Hey Emoji to have a points "given" leaderboard in addition to the existing points received board


Worked on issue 18 #hacktober

I corrected a very little error in contribution.md. Please check and merge it if ok.

Sorry, It isn't encouraged to fix a small typo or tiny problem. Better, you could just report to us. We would have fixed in the next major changes to this or these files.
I can't accept your PR. You could pick any other available issue and fix it.
Thanks


Structure check at read-in of schema-config.yaml

When we read in a new graph representation from the schema-config, we could run a completeness check of the graph structure: are all sources and targets of the relationships present in the graph as nodes, is the spelling of nodes correct (compare with Biolink model), etc.

closed by 12f6c17


fix: improve package.json lookup for root name

compileProtos seeks for package.json one directory above the one it accepts as input (typically src).
Running gapic-generator-typescript with --format=esm, generates the the sources in esm/src, then compileProtos can't find package.json.
When package.json is not found, the root name falls back to default and all the packages have the same root.
Use walk-up-path, which is also used by npm[1].
Fixes #1529.
[1] https://github.com/npm/config/blob/77a48dbe22/lib/index.js#L632
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[X] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[X] Ensure the tests and linter pass
[X] Code coverage does not decrease (if any source code was changed)
[X] Appropriate docs were updated (if necessary)

Rebased.

@sofisl Please review.


iox-#2282 Prepare v2.0.6 release

Notes for Reviewer

Pre-Review Checklist for the PR Author

[x] Code follows the coding style of CONTRIBUTING.md
[x] Tests follow the best practice for testing
[x] Changelog updated in the unreleased section including API breaking changes
[x] Branch follows the naming format (iox-123-this-is-a-branch)
[x] Commits messages are according to this guideline

[x] Commit messages have the issue ID (iox-#123 commit text)
[x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)

[x] Update the PR title

Follow the same conventions as for commit messages
Link to the relevant issue

[x] Relevant issues are linked
[x] Add sensible notes for the reviewer
[x] All checks have passed (except task-list-completed)
[x] Assign PR to reviewer

Checklist for the PR Reviewer

[x] Consider a second reviewer for complex new features or larger refactorings
[x] Commits are properly organized and messages are according to the guideline
[x] Code according to our coding style and naming conventions
[x] Unit tests have been written for new behavior
[x] Public API changes are documented via doxygen
[x] Copyright owner are updated in the changed files
[x] All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
[x] PR title describes the changes

Post-review Checklist for the PR Author

[x] All open points are addressed and tracked via issues

References

Closes #2282
Closes #2284

ROS2 CI

Linux
Linux-aarch64
Windows

@clalancette the aarch64 builds are marked as unstable. I'm quite sure it is not related to the changes of this PR and would create the release nevertheless

@clalancette all the failed tests on aarch64 yesterday had this error message
mimick: Initialization error: could not find definitions for vital function(s): 'abort' 'vfprintf'

This is not related in any way to iceoryx and if the current run will have the same failures I'll merge this branch and create the release

This is not related in any way to iceoryx and if the current run will have the same failures I'll merge this branch and create the release

Yes, that's correct.  That's a known issue that we are tracking separately: https://github.com/ros2/Mimick/issues/35


[Bug] Shadow properties like shadowBlur removes the line on the SVG graph

Version
5.2.2
Link to Minimal Reproduction
https://codesandbox.io/s/smoothed-line-chart-forked-fsv8pp?file=/index.js
Steps to Reproduce

Open the link to minimal reproduction
See the comment there

Current Behavior
The SVG graph hides the line when the series.data have all the same value and when it has shadow* properties like shadowBlur
Expected Behavior
The SVG graph should display the line when the series.data have all the same value and when it has shadow* properties like shadowBlur
Environment
- OS: Windows 10
- Browser: MS Edge 104.0.1293.47

Any additional comments?
It works when using the canvas as the renderer

This is a known issue. See also ecomfe/zrender#792


How can i get the total number of files after deletion?

Hi,
I want to upload the files only after the user deleted the unwanted ones from the chosen files.
How can I make this?
thank you..!

onRemove: function(){
var input = arguments[6], //input file
fileList = input.get(0).fliles, //file list
filesLength = fileList.length; //number of files
},

thank you..
On Mon, Feb 16, 2015 at 4:46 PM, CreativeDream<EMAIL_ADDRESS>wrote:

Closed #3 https://github.com/CreativeDream/jquery.filer/issues/3.
--
Reply to this email directly or view it on GitHub
https://github.com/CreativeDream/jquery.filer/issues/3#event-236252923.


Fix: calculate genesis id properly

It closes #1377

Okay, I just realized that if we will merge and deploy it as is — we will break UX for all Users.
Because Smapp will search for another network, another config file, etc.
We need some more code that will smoothly migrate to the new genesis id.
Like,
const oldGenesisId = legacyFalsyGenesisId(nodeConfig);
if (oldGenesisId === wallet.meta.genesisID) {
  const newGenesisId = genGenesisId(nodeConfig);
  updateWallet({ ..., genesisId: newGenesisId });
  saveCustomNodeConfig(newGenesisId, loadCustomNodeConfig(oldGenesisId));
}

It is ready for review.
Please, check it out carefully, because it's a supercritical change! 🙏
How it works:

when the User opens a wallet pointing to the network using old-wrong genesis id, it will...
"migrate" custom node config and node data dir, but keep PoS data as is
it also adds one line in the spacemesh-log just to reference previous logs
update the wallet file and change the genesis id to the new one
shows Wallet screen as usually

In case you are unlocking such a wallet, while you already have node-config.NEW_ID.json or node-data/NEW_ID — then it won't rename anything and just switch the wallet on proper genesis id.
--
P.S.
The easiest way to test it well — is to back up your Spacemesh/Electron directory every time before you want to check the migration stuff.

Tested on macOS only:

Wallet files and wallet screen ok,
Logs files ok,
POS location and generation ok
node-config.GENESIS_ID.json migrated except the "smeshing-proving-opts"

Switching between smapp versions, pausing and resuming POS generation caused (checking otherversions):

@monikasmolarek This is another issue, reproducible in develop and does not related to genesis id.
So we will need to fix it in a separate PR.

It was decided to revert changes and make them backward compatible (support case when User downgrades to v1.0.4 from the newer Smapp with new genesis id, and everything keeps working).
Probably by using symlinks.


Add NetApp Storage server as the backend for Manila (no-ssl and ssl-insecure scenarios)

The deployment was tested here. For now, we will run all manila-related tempest tests manually.

The deployment was tested here


fix(planning_evaluator): fix crashes with empty trajectories

Description

Crashes were caused by subtracting 1 from unsigned integer (size_t), causing crashes with empty trajectories (where the size = 0).
Tests performed

PSim
Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[X] I've confirmed the contribution guidelines.
[X] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@maxime-clem
Thanks!
How did you detect this bug?

@maxime-clem Thanks! How did you detect this bug?

@TakaHoribe found this bug (https://github.com/autowarefoundation/autoware.universe/pull/6126).
I added instructions on how to reproduce the crash in the PR description.


Adding start of Brightspace Extensions postman collection

Now that we have merged the API work, I wanted to add this into the Postman_Collections. This will make it easily accessible, and easy to change as we continue through the project

The parent folder is misspelled Brightspace Extentions instead of Brightspace Extensions


Fix console error

Removed a console error.
Image

:

I've pushed a cleaned up version of this PR as:
commit cc545efa498f16d94c21a062e5a59f684c95243b
Author: Kevin Greer<EMAIL_ADDRESS>Date:   Fri Jun 17 10:15:08 2022 -0400
Fix possibility of NPE in IsClassOf mlang.


CRASHING OTHER TWEAKS

As it happens, Little11 is causing other tweaks such as Spotilife and Appstore ++ to crash, after i reopen the app the app starts without launching the tweaks. Also when i tried to rejailbreak my iPhone with a newer version of unc0ver the jailbreak used to crash on respring and only worked when i disabled all tweaks and then removed little11 from cydia! Please fix asap

As it happens, Little11 is causing other tweaks such as Spotilife and Appstore ++ to crash, after i reopen the app the app starts without launching the tweaks. Also when i tried to rejailbreak my iPhone with a newer version of unc0ver the jailbreak used to crash on respring and only worked when i disabled all tweaks and then removed little11 from cydia! Please fix asap

Yo
You should try using the 5.2.1 version of uncover and go into the unc0ver settings and toggle off "LOAD TWEAKS"
Then open up iCleaner and just do the stock setting "CLEAN UP"
and boom, you've just learned howto bypassed 'Jailbreak-Bullshit' (repeat that process everytime youre iPhone turns off or you restart iPhone🤭)


fix: disable extractCSS when parallel loaders are in effect

Types of changes

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (perhaps, it is a breaking change for the people who are broke with this before)

Description
Fixes https://github.com/nuxt/nuxt.js/issues/4965#issuecomment-462375082, details can be seen in the comments
Checklist:

[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[ ] I have added tests to cover my changes (if not applicable, please state why)
[ ] All new and existing tests are passing.

@stevefan1999-personal Thank you for the pr.
About the thread-loader context issue, I actually met the similar one which is solved by adding properties to thread-loader context, how do you think fix it in same way ?
https://github.com/webpack-contrib/thread-loader/pull/25

Please fix the lint issues ☺

@clarkdo Nope, you still cannot access the rest of the webpack context:
https://github.com/faceyspacey/extract-css-chunks-webpack-plugin/blob/43e1672cd231301581df929a4159c7b716e64065/src/loader.js#L43-L46
So, unless thread-loader did an architectural change which allows master-worker communication, this will be philosophically impossible to fix.

@stevefan1999-personal Could you fix the broken code shown in failed test ?

Actually error is here https://github.com/nuxt/nuxt.js/blob/master/packages/config/src/options.js#L285 since extractCSS is deleted

@clarkdo what are the reasons those typeof ... === 'undefined' are needed instead of boolean coerce?

@stevefan1999-personal There is no much difference in this case, you can use both.
Performance is only slightly different https://jsperf.com/type-of-undefined-vs-undefined/30

Now the issue is that this pr changed a little bit allchunks warn message in test/fixtures/with-config since it's using parallel build and extactCSS, maybe we should move the allchunks warn message test to extractcss fixtures.

Sorry for the so many comments 🤖

Okay. So I squashed those commits in hope to restore the CI test and it fails me again and again. I don't know why are there 503s and 500s. I'm completely speechless now.

The test error is because extractcss is turned off in parallel mode.
But in with-config, it’s built with parallel mode and extractcss, so the expected warning message disappeared with your pr change, I’ve suggested that move this part test to extractcss fixture😺

No worries, I’ll do the test chages for you, the current change LGTM

Just my 2 cents
Shouldn't extractCSS be kept and parallel be disabled instead?
css affects the end product, and parallel just affects build time performance
Should we prefer to keep what user expect to get as a result, instead of a performance setting?

Codecov Report

Merging #5004 into dev will decrease coverage by 0.07%.
The diff coverage is 33.33%.

@@           Coverage Diff            @@
##            dev    #5004      +/-   ##
========================================
- Coverage    95%   94.92%   -0.08%
========================================
  Files        72       72
  Lines      2400     2403       +3
  Branches    607      608       +1
========================================
+ Hits       2280     2281       +1
- Misses      100      102       +2
  Partials     20       20

Impacted Files
Coverage Δ

packages/config/src/options.js
98.54% <33.33%> (-1.46%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21e7936...ce5b649. Read the comment docs.

@williamchong007 Good idea, I agree with you


Package proposal: autopsy.vm

Package Name
autopsy.vm
Tool Name
Autopsy
Package type
GITHUB_REPO
Is the tool a console application?
false
Tool's version number
4.21.0
Category
Forensic
Tool's authors
Sleuthkit
Tool's description
Autopsy is a digital forensics platform and graphical interface to The Sleuth Kit and other digital forensics tools.
Download URL
https://github.com/sleuthkit/autopsy/releases/download/autopsy-4.21.0/autopsy-4.21.0-64bit.msi
Download SHA256 Hash
abcdef1234567890
Why is this tool a good addition?
Requested by a Commando VM user

I would like to pass the decision for this one onto @mandiant/flare-vm, I'm not familiar with the tool

It's a great tool for forensics, but I don't necessarily see it as part of FLARE VM (in the context of malware/binary analysis).

Ok yeah that would probably make more sense for commando then, since we would want to inspect the system for forensics after payload detonation or some ttp testing.. Sounds good, I will look into it then :)

This issue can be closed (see #782)


Test cases for validating lifecyle of Digitial Ocean hosts

@will-chan , @cloudnautique - please review

@cjellick , Could you please review ?

@sangeethah You'll need to talk with @cloudnautique  about getting the DIGITALOCEAN_KEY into the automation validation test runs so that these tests execute.

Having these tests is great and we definitely need them. But, here are some potential issues I see that I don't have a good solution for:
We know that there is flakiness between docker-machine and the cloud providers...the "waiting for SSH" issue being the main one. This will ultimately lead to the validation tests randomly failing. Will this cause too much noise and/or false-failures in our automated validation test runs?

I will work with @cloudnautique to get the DIGITALOCEAN_KEY into the automated validation test runs. It takes ~10 -12 minutes to execute the test cases. So not sure if we will want to do execute these cases  on a regular basis or just execute them on demand by setting the DIGITALOCEAN_KEY explicitly.

@sangeethah RE: "It takes ~10 -12 minutes to execute the test cases. So not sure if we will want to do execute these cases on a regular basis"
@cloudnautique and I were just talking about that actually. He and I both agree that running these tests all the time would not be good. In particular, when he's validating a release build, he'd prefer they didn't run, but they should run every time the tests are executed against latest.rancher.com.
We could just depend on the absense/presence of DIGITALOCEAN_KEY to determine if these tests run. For release builds, the token won't be there and the tests would get skipped. For daily runs, it would be there.

@sangeethah This is more-or-less my personal preference, but I think it is better to commit additional changes after a review as separate commits (as opposed to ammending or squashing). It let's the reviewer see what has changed between commits.
Once the PR gets the necessary approvals, you can squash.

LGTM

@alena1108 or @sonchang would you want to give these tests a review?

I made some minor suggestions but otherwise, LGTM

LGTM


refactor(map_projection_loader)!: prefix package and namespace with autoware

Description
This PR will add the autoware_ prefix to map_projection_loader.
This PR will affect

autoware_tools: https://github.com/autowarefoundation/autoware_tools/pull/93

Related links
Parent Issue:

https://github.com/autowarefoundation/autoware/issues/4569

How was this PR tested?
Confirmed with running sample-map.
Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

@SakodaShintaro Sorry for overlooking the tier4_map_launch, I fixed it at 4f95dfa .

@a-maumau Sorry, could you resolve some conflicts?

@SakodaShintaro I have resolved the conflicts.

@kosuke55 @takayuki5168
Could you review this pull request?


feat: allow custom extractors

I'm building a ui library using Tailwind which relies heavily on a custom purge extractor, which means I wouldn't be able to leverage tailwindcss-jit 😿 .
This PR aims to support custom extractors as defined in the purge config options if any, falling back to the default one from tailwindcss-jit.
I tried to make as few modifications as I could to the code
I'm hoping you're on board with the general idea 🙏

This is great thanks so much! Going to play with it a bit and hopefully get it out in a release today for people to play with 👍🏻


Split up /call and /logs.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1152  👈
#1151
#1150
#1149
#1144 : 1 other dependent PR (#1145 )
#1140
#1138
#1137
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rohinb2 and the rest of your teammates on  Graphite

Merge activity

Oct 18, 6:58 PM EDT: A user started a stack merge that includes this pull request via Graphite.


Missing short form delegate instantiantion

These options are missing and an explanation on the difference between these and the presented ones:
D cd1 = new C.M1;        // static method
D cd2 = new t.M2;        // instance method
D cd3 = new cd2;         // another delegate

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6d5a9d5f-36b3-be69-bbf8-93fb75237d1e
Version Independent ID: 02628e27-dd25-fb6b-89a9-21c5e900120f
Content: Delegates - C# language specification
Content Source: spec/delegates.md
Product: dotnet-csharp
Technology: csharp-spec
GitHub Login: @dotnet-bot
Microsoft Alias: wiwagn

@paulomorgado I'm confused, that's not valid C#.
If you meant this:
D cd1 = C.M1;        // static method
D cd2 = t.M2;        // instance method
D cd3 = cd2;         // another delegate

Then the first two are method group conversions. Though since they are specified elsewhere, maybe a link from the Delegates section would be useful. (Not sure a further explanation is needed here, since this is a specification, not language reference.)
If you meant this:
D cd1 = new(C.M1);        // static method
D cd2 = new(t.M2);        // instance method
D cd3 = new(cd2);         // another delegate

Then that's target-typed new, which is a C# 9.0 feature, so it makes sense it's missing from the draft C# 6.0 spec. (The ECMA committee is updating the spec in this repo to newer language versions, but it's currently at C# 6/7.)

You're correct, @svick.
I copied+pasted the code and removed the parenthesis and forgot to remove the new  part.
I meant to refer to delegate instantiation by implicit method group conversion.


Uvvis calibration

With this pull request, uvvis calibration curves of the CE-NOME group can be saved. For uvvis data that is saved without concentration, the concentration of the desired material is to be determined using the existing calibration curves.
Things that still need to be discussed/resolved:

[x] With M. we agreed on the area of the uvvis curve for calibration. However, G. and Y. always refer to a specific peak (see: example)
[ ] The peak mentioned above is not necessarily the highest peak in the uvvis curve. For NH3, for example, the peak is always at approx. 650 nm. How should this be included in a paek finding algorithm? In test data, the peak with the maximum width often (but not always!) provides the peak we are looking for. For low concentrations of NH3, the peak is sometimes calculated incorrectly. Should the user be able to specify a range in which the peak is searched for? (The corresponding code area is marked with 2 TODOs in the uvvismeasurementconcentration.py file.)
[x] For the UVvisConcentrationDetection I have inherited from analysis. Should the resulting linear function (slope, intercept, r2) be stored in outputs? At the moment I store these values in individual quantities and leave the output of the analysis empty.

Hey @carla-terboven using peak or area is something they should decide. Peak is fine for me. If there are other peaks then it is anyhow better.
For finding the peak, how about finding the maximum around 650nm +- 20nm? or 30nm or sth like this? the range and the center can be a setting value with a default of 20 and 650?
It is probably helpful to plot the fit in the analysis entry so that one can verify the fit :).
Yeah you can store it in outputs but this is not so important.

I have included the comments we talked about.
Things I'm still unsure about:

[ ] What did you mean by removing the UVvisMeasurement baseclass? (Sub)sections should be used instead. Should this also affect the UVvisDataConcentration?
[ ] It is no longer possible to define a separate peak search area for NH3. Instead, default values are automatically entered. Is this the desired behavior?
[ ] I don't understand how you can display a unit on the axis label for the plotly plots. I am generally unsure whether it works for every unit due to the use of .magnitude
[ ] Is uvvis data always sorted by wavelength? I am currently sorting the data, maybe this step can be skipped.

* [ ]  What did you mean by removing the UVvisMeasurement baseclass? (Sub)sections should be used instead. Should this also affect the UVvisDataConcentration?

UVvisDataConcentration is a data transformation subclass of analysis this is fine as it is now.

* [ ]  It is no longer possible to define a separate peak search area for NH3. Instead, default values are automatically entered. Is this the desired behavior?

default values are fine but they should be adapted manually

* [ ]  I don't understand how you can display a unit on the axis label for the plotly plots. I am generally unsure whether it works for every unit due to the use of .magnitude

we talked about it use .unit to access

* [ ]  Is uvvis data always sorted by wavelength? I am currently sorting the data, maybe this step can be skipped.

it should be but sorting might be ok to be sure

@carla-terboven i added the some comments it looks really nice. i am amazed to see what kind of nomad functions you use :) very nice thanks i will soon check it out and test it for now i just read the code :)

Thank you for the feedback @RoteKekse. I now added the extrapolation for the measurements outside the calibration data. Somehow the logger warnings are only displayed in my private console but not in the nomad logs area. Do you know why?

Hey @carla-terboven all fine so far, just one small usability feature, let me know if you have questions.

hey @carla-terboven is there something left can we test and merge?

hey @RoteKekse, I feel like everythink is discussed for this PR


Design: New Scan QR feature

Designs
https://www.figma.com/design/cvV48t0f7O2znT6QBxK0Zj/Tonomy-ID?node-id=9187-8806&t=2dVPEE0heREkPxD5-1

list in the epic flows to test


[GH-5449] Add Step to see 'import process' status

Summary
The Migrating from Slack section is improved with one new step to view the status mmctl import process job. This extra step allows the user to determine success/error of the slack migration import before returning to the webapp. If there was an error message, it is shown to assist debugging.
Tested with:

Ubuntu 20.04 developer environment. release-6.4
Ubuntu 20.04 self hosted. release-6.4

Ticket Link
Fixes #5449

Hello @glennschler,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.


label for app 5 footprints

The text for the contours in app 5 for footprints should read % of individuals, not % of area or volume.

@jmerkle1 - This should be fixed.. Can you confirm at the line linked below?
https://github.com/jmerkle1/Migration-Mapper/blob/main/app5_merging/app5.R#L86


fix disable compact when tablet version discontinuous to avoid engine clone task failure

fix disable compact when tablet version discontinuous to avoid engine clone task failure
Fix the Error case：

if a version incomplete tablet's local version: 0-10, 12-12 (missed version 11-11)
engine_clone task starts to snapshot and download from src be, the cloned version is 0-12, 13-13
During download, local be accept data write and triggered compaction, now the local version is 0-10, 12-15
after clone download finished, local version 12-15 report error: version cross src latest(max cloned version 13) the engine clone task failed

To solve this, we diable compact when tablet version exist holes

after clone download finished：
local version  :        0-10, 12-12, 13-13, 14-14, 15-15
cloned version :        0-12, 13-13
local repaired result:  0-12, 13-13, 14-14, 15-15

For more details and logs：https://github.com/apache/doris/issues/16424
Proposed changes
Issue Number: close #16424
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[x] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.22 seconds
stream load tsv:          478 seconds loaded<PHONE_NUMBER>9 Bytes, about 149 MB/s
stream load json:         39 seconds loaded<PHONE_NUMBER> Bytes, about 57 MB/s
stream load orc:          69 seconds loaded<PHONE_NUMBER> Bytes, about 15 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230210164109_clickbench_pr_93925.html

LGTM

run buildall

run buildall

run clickbench

run clickbench

run P0 Regression

run buildall

run buildall


Middleware-based compression and decompression

Provides compression middleware for outgoing HTTP responses and decompression middleware for incoming HTTP requests.
Description

These two middlewares do the following:

Automatically handle incoming request decompression for Content-Encoding headers that contain one or more applications of gzip, deflate, br, or zstd.
Encode outgoing responses with preferred encoding behavior for any incoming request with a valid Accept-Encoding header.
Allow one to define compression levels for each compression algorithm available.

Motivation and Context

Such a middleware would address https://github.com/rustasync/tide/issues/26.
Tide currently has no way of handling encoded requests or handling outgoing request compression. This middleware is one approach to solve that problem, although there exist a multitude of approaches that may work. This middleware may also serve as a point of discussion for https://github.com/rustasync/team/issues/52.
Another PR that seeks to do the same is https://github.com/rustasync/tide/pull/117, but it's currently outdated as it relies on an older version of Tide (pre-revamp and other changes).
How Has This Been Tested?

Tests are written! They're not very thorough, but that's because it's only to test their functionality. More rigorous tests for each of the stream encoders/decoders are in the async-compression-rs crate.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

The entire middleware here is feature-gated behind "compression" because it imports a number of new crates exclusive to itself. I can remove the feature gate and optional dependencies later if we decide to make it a core part of the framework, but as Tide is still very much in development and this being only one approach to the issue, I'd like to keep things lightweight.
Current implementation issues probably revolve around how to set a new body on a mutable request. As seen here: https://github.com/fairingrey/tide/blob/52d40d04ca5b45337753ad51d298576440ffbac9/src/middleware/compression.rs#L127-L139 I'm currently having a problem trying to figure out how one would allow a new body to bind to the response passed into encode. The 'static lifetime bound in https://docs.rs/http-service/0.1.5/http_service/struct.Body.html#method.from_stream makes this especially difficult, but maybe my approach is flawed somewhere?

So just some thoughts on this if you'll allow me. This is going to be a long comment.
After messing around with possible approaches, I don't think this is going to work unless one consumes the entire stream of bytes into memory and then returns the entire encoded body in a stream that either yields it immediately in a single future or re-chunks it on the way back out through multiple futures each yielding some amount of bytes until it finishes. Both seem pretty inefficient.
I was talking with @Nemo157 in the Rust community discord about possible ways to do this, but other than the above, I don't think anything else is going to work. Each of the raw, in-memory compression handling objects for both flate2 and brotli2 require they basically stay alive for the length that the stream is alive so it understands how to chunk each piece of memory given how it read all the previous chunks.
However that likely can't happen because as mentioned in our discussion, part of the issue is that I might not consume the entire incoming bytes without blocking the stream (thus making async kind of pointless) and if not that, I would be producing multiple output blocks for each input block (so streams within streams) which would then require flat_map... which then runs into lifetime/ownerships issues because the Compress objects still have to be passed around since Stream is poll-based.
With all that considered, I don't think in its current state, Tide should be responsible for handling compression/decompression, as it may be handled more smoothly at either the hyper or http-service layer. But it does bring up a good point of discussion (and this may be related to changing/revamping what constitutes our response Body).
FWIW, it would be significantly easier to write an adapter that takes a streaming-like body that impl's AsyncBufRead and applies the necessary transforms to provide another body AsyncRead, or something similar to that approach. Trying to write a Stream<Item = Bytes> -> Stream<Item = Bytes> adapter to create a new streaming body efficiently seems impossible to me at the moment, especially given that the Compress object(s) depends on previous blocks to encode new blocks.

Thanks to everyone here for helping review this PR, however, but I think this can speak for a larger, related discussion to what a tide response's body ought to look like. Although I do understand such a recommended change would necessitate newer breaking changes in related crates http-service and the like.
I'll try to bring it up during the next async WG meeting, and maybe we can discuss possible approaches there.

Updated my comments to reflect my current status. Once https://github.com/rustasync/tide/pull/193 gets merged, I can start writing some tests for compressing Tide request bodies.

One other concern I also had was if the request should also upsert the vary header with value Accept-Encoding as following https://developer.mozilla.org/en-US/docs/Web/HTTP/Compression#End-to-end_compression. Might be a necessary detail if we're going by what it says there.

Phew... Finished all of the logic for compression and decompression handling over streams, but both implementations aren't tested yet because of current blockers over the outdated futures API on the latest nightly (deny warnings).
One other concern I had (and this is mentioned in my commit message) is that there is currently no way to get a &mut Request handle from the Context. This is another blocker since to decompress the request into plain data it's necessary to alter the incoming request being passed in.
I'll try to bring this concern up during the next meeting, but otherwise I think I've made a lot of progress! It would be good to get more review now while it's appropriate, I think.

This could be due to my lack of experience with futures, but when I try to use this with hyper 0.12, I can only ever get it to spit out the first 8000 bytes. Even if I try to block and concat/collect the stream, it still only returns the first 8000 bytes.
Here is how I'm using it in hyper:
use std::io;
use async_compression::stream::deflate;
use futures::{future, stream::Stream};
use futures03::{compat::Stream01CompatExt, stream::TryStreamExt};

let (mut parts, mut body) = response.into_parts();
let compressed = deflate::DeflateStream::new(
  body
    .map(|v| v.into_bytes())
    .map_err(|e| io::Error::new(io::ErrorKind::Other, e))
    .compat(),
  flate2::Compression::default(),
);

body = Body::wrap_stream(compressed.compat());
let response = hyper::Response::from_parts(parts, body);

This ends up setting transfer-encoding to chunked, and only returning 8000 bytes.
I then tried this craziness to see if I could just grab everything from the stream and put it into a bytes::Bytes, but it still only returned 8000 bytes.
use futures03::executor::block_on;
use futures03::stream::StreamExt;
use hyper::body::Payload;
let payload: Vec<_> = block_on(compressed.map(|v| v.unwrap()).collect());
let mut fin: Vec<_> = vec![];
for b in payload {
  fin.put(b);
}
body = Body::from(fin);

I just want to confirm whether this is my issue or not.

@kdar I'd recommend you open an issue in the async-compression repo and provide your code or steps to reproduce, and I can try helping you there. While this PR is sort of related, this is mostly for tracking progress on this middleware. But perhaps I can figure out a bug from what you're doing.
8000 bytes is the size of the internal buffer for those compression streams though, so if something weird is happening it's likely related to that.

I'll be writing tests for the compression middleware in the meantime I'm looking to get the issue I'm having unblocked. Will likely start tomorrow, since I have some stuff to do today.

I'll be moving some of my Accept-Encoding parsing logic to https://github.com/rustasync/accept-encoding under the recommendation of yoshua -- hopefully shouldn't take too long :sweat_smile:

Currently waiting on both https://github.com/rustasync/accept-encoding/pull/2 and https://github.com/rustasync/async-compression-rs/pull/13 until I continue progress.

How do you think about using Encoding and Option<Encoding> accordingly? Currently we have Encoding::Any (or Encoding::None) to indicate "no specific preference", but it seems like Encoding::Any is often special-cased.

Oh, that's a good approach. Using Option<Encoding> actually hadn't crossed my mind while writing it, but I think it'd look pretty decent.
I can rewrite that part in the Accept-Encoding crate such that when its' re-exported here I don't have to special-case it. I'll try it in a moment.

One thing I should note, by the way -- Travis will likely have to be updated unless the feature gate is removed. Cargo doesn't check/test/clippy all the features if the --all-features flag isn't included.

This PR is ready for final review, by the way. Feel free to make any final notes or suggestions. I'm looking to get it merged probably before Thursday (5/16, the next meeting).

@fairingrey - This is great! Thank you for all the hard work! :)
Some thoughts:

One tiny little thing I'd have done is do this as a separate PR: https://github.com/rustasync/tide/pull/194/files#diff-e0934bb6f70a4f8c3baf22a773c14ec7
The git dependencies - I think in the long run, whichever can make it into the main Cargo.toml as patch-crate.io as git master on rustasync org owned reasonably stable libs should be fine. Other than that, I think a good way to move forward for early deps would be to use a pinned branch (say tide), rather than master - so code doesn't inadvertently get changed -- I say this since git deps will pass through the tide CI/CD, and there would be no way catch these, since they can be updated separately and end up wreaking havoc depending on when the user actually downloads the cargo crates.

@prasannavl Thank you!
On the topic of Cargo.toml, I could have, probably -- but it was just a small thing and I was including new dependencies anyway :sweat_smile:
As for the git dependencies, I agree. The async-compression-rs and accept-encoding crates likely won't be changed for a while (aside from non-breaking changes that Nemo or I am making), but it would be in our best interests to pin a stable branch we know won't be changing without the necessary PRs to update them.

Actually, lemme make one tiny new change to decrease compilation time (since this middleware doesn't use the bufread features in async-compression).

Since #219 was merged, looks like I'll be doing a rebase now.
Thanks for all the review and feedback!

Actually, I'll probably move the example out to the examples folder, thanks for the suggestion :+1:

@tirr-c Sorry about that! How about now?

Indeed... There's a lot of stuff here, and this is a fairly large component -- it's good to get lots of review in so we won't have to double over it so much when it's integrated :sweat_smile:
But I think this is good now! It should be good to merge tomorrow, hopefully :sweat_drops:

Thanks for all the review, everyone! I'll get this merged now since it looks like we have not much else to change.
If anything else needs to be sharpened up, we can do it through a future PR, I imagine.


date() expects parameter 2 to be integer, float given

Hello,
I get a Warning when using this extension:
date() expects parameter 2 to be integer, float given
This warning occurs in vendor/kmielke/calendar-extended-bundle/src/Resources/contao/classes/EventsExt.php (line 175)
I catch this on FE when using Debug Mode.
Contao Version 4.8.4

Our module was configured with "next_all" and the Contao function getDatesFromFormat returns an float instead an integer.
Probably because of https://github.com/contao/contao/issues/811 and furthermore https://github.com/contao/contao/pull/814
We solved our problem by changing it to the next two-year option.

It has to be fixed in Contao I think, because Typecasting returns -1.

Contao Bug


Added Filter and pic makeover.

Related Issuse or bug

Added Snapchat Filters using OpenCV and Virtual Makeover of a face by facial landmark detection and

Fixes: #66 SnapChat Filter using OpenCV
Fixes: #68 Virtual Makeover of a face by facial landmark detection.
Proposed Changes

Added Virtual makeover using dlib and opencv, which can also be used as snapchat filter. It supports both real time frame and pre-clicked image, even user can click picture and can use it to make changes.

Screenshots

Original
Updated

@akshitagupta15june Mam, Please my review my PR as a SWOC2021 participant:)

@akshitagupta15june Mam, Please my review my PR as a SWOC2021 participant:)

hi there is no filter

hi there is no filter

snapchat filters are different

snapchat filters are different

@akshitagupta15june Okay Mam, Sorry for that. Can I know is my PR solving isuue no. #68 ?

@akshitagupta15june Okay Mam, Sorry for that. Can I know is my PR solving isuue no. #68 ?

@akshitagupta15june Sorry mam, for the inconveniencecaused my me, will update my PR:)

@akshitagupta15june Sorry mam, for the inconveniencecaused my me, will update my PR:)


fuzz console log & test cases

Motivation
As discussed in  #3844 , when using fuzz test, console.log doesn't work as expected(display console log info). This PR added a new fuzz config show_execution_logs, with which user could decide if the full console log should be displayed. by defaut, the value is false, so it won't affect any fuzz test prior to this change will be made.
Solution
A logs field is added to CaseOutcome to keep track of logs that generated in a single fuzz test. And collect logs in all fuzz tests. then use the config show_execution_logs to decide if full console log output should be displayed. if not, the console.log behavior is the same as what it is now.
Also, you can use /// forge-config: default.fuzz.show-execution-logs = true to enable fuzz test console log per test.
4 test cases is added, to test if the new config works as expected.

hi @grandizzy ,  please review this, there's a failed test case in test integration, and i believe it has nothing to do with my pr. btw, I think the docs should be updated if the pr is merged. but I didn't find where to update the docs. please tell me if this work needs to be done, and i'll update it.

Thank you, nice progress!
I was thinking more along the lines of #3844 requirement, that is to print logs during the test rather than after the test is completed (good for long campaigns where one would like to get feedback during execution). So instead storing logs for all fuzz cases (which would also require more resources for executing these test) we can print logs right after the executor call (if show-execution-logs enabled), smth like adding
        if self.config.show_execution_logs {
            for log in decode_console_logs(&call.logs) {
                println!("  {log}");
            }
        }

right after
https://github.com/foundry-rs/foundry/blob/15652dc9ac56fa12310a901a37489e550ebb133c/crates/evm/evm/src/executors/fuzz/mod.rs#L213-L222
Would be nice to extend this to invariant testing as well (would probably require the config to be a general one like show_fuzz_logs and apply to both fuzz and invariant) but can be handled in a separate PR.

ok, I got your points. Although show-execution-logs is under fuzz config section, it's clearer to use show_fuzz_logs and this convention could also be applied to invariant tests. I'm on this.

Thank you, nice progress!
I was thinking more along the lines of #3844 requirement, that is to print logs during the test rather than after the test is completed (good for long campaigns where one would like to get feedback during execution). So instead storing logs for all fuzz cases (which would also require more resources for executing these test) we can print logs right after the executor call (if show-execution-logs enabled), smth like adding
        if self.config.show_execution_logs {
            for log in decode_console_logs(&call.logs) {
                println!("  {log}");
            }
        }

right after
https://github.com/foundry-rs/foundry/blob/15652dc9ac56fa12310a901a37489e550ebb133c/crates/evm/evm/src/executors/fuzz/mod.rs#L213-L222
Would be nice to extend this to invariant testing as well (would probably require the config to be a general one like show_fuzz_logs and apply to both fuzz and invariant) but can be handled in a separate PR.

hi @grandizzy
After walking though the execution process. I don't think we could print the fuzz console logs right after  the executor call. here's why:

the console.log should also be controlled by verbosity, only verbosity >= 2 is allowed to display logs.
all logs should be printed under respective test results, which means that we have to keep the logs until it should be displayed.

related code:
https://github.com/foundry-rs/foundry/blob/8b694bbcabaedffc0337bf8dea9a135da5694ef9/crates/forge/bin/cmd/test/mod.rs#L455-L465
wdyt

hi @grandizzy After walking though the execution process. I don't think we could print the fuzz console logs right after the executor call. here's why:
1. the console.log should also be controlled by `verbosity`, only `verbosity >= 2` is allowed to display logs.

Yeah, I think the show fuzz logs config could supersede the verbosity, so don't think this is a biggie

2. all logs should be printed under respective test results, which means that we have to keep the logs until it should be displayed.

Good point, if we're not displaying under their own test then running multiple fuzz tests at the same time could become a mess. So let's stick with the impl of gather logs and displaying them at the end, let's keep for fuzz only for now and extend to invariants after. There's FuzzTestData that's already ref celled, so pls add that to it https://github.com/foundry-rs/foundry/blob/15652dc9ac56fa12310a901a37489e550ebb133c/crates/evm/evm/src/executors/fuzz/mod.rs#L25-L40

hi @grandizzy After walking though the execution process. I don't think we could print the fuzz console logs right after the executor call. here's why:
1. the console.log should also be controlled by `verbosity`, only `verbosity >= 2` is allowed to display logs.

Yeah, I think the show fuzz logs config could supersede the verbosity, so don't think this is a biggie

2. all logs should be printed under respective test results, which means that we have to keep the logs until it should be displayed.

Good point, if we're not displaying under their own test then running multiple fuzz tests at the same time could become a mess. So let's stick with the impl of gather logs and displaying them at the end, let's keep for fuzz only for now and extend to invariants after. There's FuzzTestData that's already ref celled, so pls add that to it (instead declaring the logs: RefCell<Vec<Log>>)
https://github.com/foundry-rs/foundry/blob/15652dc9ac56fa12310a901a37489e550ebb133c/crates/evm/evm/src/executors/fuzz/mod.rs#L25-L40

do you mean that I should define a new field like logs in FuzzTestData to store logs, or I could make use of logs in counterexample or traces?

hi @grandizzy After walking though the execution process. I don't think we could print the fuzz console logs right after the executor call. here's why:
1. the console.log should also be controlled by `verbosity`, only `verbosity >= 2` is allowed to display logs.

Yeah, I think the show fuzz logs config could supersede the verbosity, so don't think this is a biggie

2. all logs should be printed under respective test results, which means that we have to keep the logs until it should be displayed.

Good point, if we're not displaying under their own test then running multiple fuzz tests at the same time could become a mess. So let's stick with the impl of gather logs and displaying them at the end, let's keep for fuzz only for now and extend to invariants after. There's FuzzTestData that's already ref celled, so pls add that to it (instead declaring the logs: RefCell<Vec<Log>>)
https://github.com/foundry-rs/foundry/blob/15652dc9ac56fa12310a901a37489e550ebb133c/crates/evm/evm/src/executors/fuzz/mod.rs#L25-L40

do you mean that I should define a new field like logs in FuzzTestData to store logs, or I could make use of logs in counterexample or traces?

Yeah, I mean new field in struct instead https://github.com/foundry-rs/foundry/pull/8387/files#diff-12784ea10f5753f595ab88ff54a8d09ecdd044d6a19676229f601a1bffe702e6R93

Thank you, nice progress!
I was thinking more along the lines of #3844 requirement, that is to print logs during the test rather than after the test is completed (good for long campaigns where one would like to get feedback during execution). So instead storing logs for all fuzz cases (which would also require more resources for executing these test) we can print logs right after the executor call (if show-execution-logs enabled), smth like adding
        if self.config.show_execution_logs {
            for log in decode_console_logs(&call.logs) {
                println!("  {log}");
            }
        }

right after
https://github.com/foundry-rs/foundry/blob/15652dc9ac56fa12310a901a37489e550ebb133c/crates/evm/evm/src/executors/fuzz/mod.rs#L213-L222
Would be nice to extend this to invariant testing as well (would probably require the config to be a general one like show_fuzz_logs and apply to both fuzz and invariant) but can be handled in a separate PR.

@grandizzy Can we just use show_logs in FuzzConfig? Because I noticed that, there are runs in both FuzzConfig and InvariantConfig, and share the same meaning as runs for fuzz test or invariants test. wdyt
And do I need to add something like fuzz_show_logs here👇🏻 for users to use environment FOUNDRY_FUZZ_SHOW_LOGS?
https://github.com/foundry-rs/foundry/blob/0116be1bb3f73a6365290ba2894813815d02159d/crates/forge/bin/cmd/test/mod.rs#L105-L114

@grandizzy Can we just use show_logs in FuzzConfig? Because I noticed that, there are runs in both FuzzConfig and InvariantConfig, and share the same meaning as runs for fuzz test or invariants test. wdyt

yes, that should work

And do I need to add something like fuzz_show_logs here👇🏻 for users to use environment FOUNDRY_FUZZ_SHOW_LOGS?

nope, that's not needed

@grandizzy Can we just use show_logs in FuzzConfig? Because I noticed that, there are runs in both FuzzConfig and InvariantConfig, and share the same meaning as runs for fuzz test or invariants test. wdyt

yes, that should work

well, I think this is my final commit. please review this to see if any change should be made. @grandizzy

lgtm, thank you! clippy failure not related

Thank you @grandizzy for your patience and guidance along this PR and you're very meticulous,

lgtm, thank you! clippy failure not related

Thank you, @grandizzy, for your patience and guidance throughout this PR. You're so meticulous. I'm new to Rust, and every time I thought there was nothing to optimize, your review showed me a better way. 😄👍🏻
Hopefully, this PR will not be reverted again.


Seive of Eratosthenes

Is your feature request related to a problem? Please describe.
It is an algorithm to find prime number between two ranges
Describe the solution you'd like
I will be using this algorithm which says mark all non prime and print prime.
Do you want to work on it
CPP

@rudrakshi#2361  @vatsal kesarwani#2606  @Tanyx#7069  @Raksha#9246  @tarun_10#1663  @Nakul#7751  @shrey#7147

I would like to contribute to the above problem in java as I am a participant of GSSOC'21. Kindly assign this to me.

**@tarun26091999 @rudrakshi99 @plazzy99 @nakul-19 **, i would like to contribute to the above problem in CPP. am a GSSoC'21 participant. kindly assign this to me.

@raksha009 @nakul-19
@nakul-19

Hello, @shubhidua @Simi06 @Op-panda @aaadddiii @anubhavitis  I think this is an important question and this should definitely be added in the Algo-Tree and I will start working on it as soon as I get assigned!! as I am a part of GSSoC'21, so I would like to implement this in c++.

present at #47