Gujian 3 corrupted graphics on Nvdia

As can be seen in attached images, in some areas, graphics get corrupted on my Nvidia card, In particular on characters (main or NPC). This also happens near water, not sure if it is lighting related or something.
Also, it does not happen on my integrated intel card, only on Nvidia card. Does not happen on Geforce now either.
I attached log, and ran with vk validation layers already, did not see any particularly meaningul errors.
API trace makes the game freeze at launch so can't provide one seems. If I can add anything to help don't hesitate.

Images of the issue:

Software information
Game: Gujian3
API: dx11
Settings: any (tried from lowest to highest)
System information

GPU: GTX 1070
Driver: 450.66
Wine version: proton 5.09
DXVK version: 1.7.8

Apitrace file(s)
Freeze game at launch
Log files

d3d9.log: empty
d3d11.log: Gujian3_d3d11.log
dxgi.log: empty
Gujian3_dxvk_config.log

Does this work with wined3d?

I attached wined3d images, there are other bugs (like no hair and kinda broken clothes), but not this one indeed.

How exactly do you reproduce this bug? The game seems to look fine on the latest Nvidia Vulkan beta driver:

Oh yeah sorry for not being precise enough: The bug only happens in some areas. The one I showed you is when going outside of the village later in the story - when switching protagonist - At that time, it happens at multiple times in the village too, notably during a fight included in the story, and almost directly after switching characted while teaching martial arts to children, and near the a river with a boat. Otherwise, it also happens near the fountain in the capital (nearer in the story for you). I can send more screenshots if it helps.
In the very first parts I did not have any issues, need to at least go until the capital - is half an hour of playing I'd say to get there.
I will also try latest beta drivers just in case.

Please provide a savegame if possible, I don't really have the time to play through the entire game to (maybe) find a spot where the bug appears.

Online game, syncs against the server so that's going to be a problem and while offline was considered the game appears to be done with patches and nothing like this was implemented.
There's the config file in the game folder but I think that's about all you can find locally, shame as once the game is finished it's possible to do chapter replays which would have aided with hopping around to later areas (It's a lengthy game even without the grind for levels/items and the usual.) even just getting through the prologue part and getting to the chapters after is a couple of areas and one dungeon so a few hours minus what might be possible to do by skipping through cutscenes and dialogue.

Okay, as @LordJBeckman said, no way to transfer saves ... But, I managed to get an apitrace, turns out, load time is tied to framerate .... So it was just excruciatingly slow. With DXVK_ASYNC=1 I ended up managing to get to a state where I could get it done. There goes the link: https://we.tl/t-Lif4srxNYK (on wetransfer since firefox send is dead and github won't take such large files...)

@3kinox thanks, but the trace file is broken since it does not contain any DXGI calls, and I can therefore not replay it.
Did you copy both dxgi.dll and dxgitrace.dll from apitrace next to the game, and did you also set the DLL override for dxgi to native? (WINEDLLOVERRIDES=dxgi=n)

@doitsujin I did copy both but indeed, I did not put the override. I'm on proton, and I've added the WINEDLLOVERRIDES=dxgi=n in launch option now. Here's the result: https://we.tl/t-HACeB5xUD8
I stayed at bug position at the end - you can ignore the few first tries, hard to control anything at sub 1 fps ;p

Thanks, that one works. Seems like an Nvidia-only problem, it works fine on RADV but I can reproduce the bug on NV.

Just chiming in to say the bug is still present with latest driver/dxvk (in proton ge). Any other thing I can do to help ?

@3kinox Friendly ping. Could i get you to try this again with latest dxvk and drivers?

@Blisto91 I tried with latest dxvk git and nvidia 515.57, no luck bug is still there.

Made a trace so just adding it to the issue here. https://mega.nz/file/MpYW2ByB#Eq4bO7kfyx5yPbn3luhKLFXDSNSZYBKJruTe07PtYb8
It is a bit cursed since it doesn't show the main menu or loading screen so you can see the world blinking and everything loading in. The actual ingame time is at the end when you see the main character.

Does the above PR fix the issue?


HowTos: DerivedAtom from the field

Is your feature request related to a problem? Please describe.
Hello @jaredLunde , I have usecase that
{
a: fieldAtom('this-binds-to-input-in-form')
b:  get(fieldAtomA) => 'messageWithData-nd-not-bound-to-any-input-in-form'
}
Like dependent atom, I have to create a field dependent on another field or simple atom if not binding the field anywhere.
I would still want form submit output as { a: 'inputA', b:'dervied-from-inputA'}
Describe the solution you'd like

Like Dependent Atom, we should have mechanism to create field by listerning to other field as above.
can Value expect the atom as initial Value?
If B is not used in form , can we just create simple atom and not fail form if other fields are valid.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Can't you just use a plain Jotai atom to derive state from the value atom in the field?

Can't you just use a plain Jotai atom to derive state from the value atom in the field?

I can use. Needed to know if it will automatically do walkField for that atom too, meaning.
{
fieldA: fieldAtom(['string']),
atomB: atom(get(fieldAtom).value)
}

Would it automatically submit the atomB and resolve as being non field ? I can give it a try and see I can put into code-sandbox

@jaredLunde : here you go :
code-sandbox-example-produce

Noticed couple of things:

I was not able to add non-field fixed value say status: "complete" for a form step so dont want to create that as a field instead I should just set value and rest of the keys can be linked to form component (UI binding)
I also tried atom, may be some silly mistake. Please leme know.

THanks in advance !!

One more attempt :
code-sandbox-produce-2
Additionally , based on learning from this , I can make some progress in https://github.com/form-atoms/list-atom/issues/7

No, the derived state doesn't belong in your form if it's not a form value. You should just need a plain atom that uses the same Jotai store as the form.

No, the derived state doesn't belong in your form if it's not a form value. You should just need a plain atom that uses the same Jotai store as the form.

Is it possible to see the example changed what I sent by forking? I would really appreciate it.

No, the derived state doesn't belong in your form if it's not a form value. You should just need a plain atom that uses the same Jotai store as the form.

Is it possible to see the example changed what I sent by forking? I would really appreciate it.

@jaredLunde : Gentle reminder if you got chance to look at it


Migrate organisation logos to asset manager

This PR introduces a rake task asset_manager:migrate_organisation_logos which creates a sidekiq job for each file under system/uploads/organisation/logo/ (organisation logos) to create an asset in the Asset Manager API (if one doesn't already exist for this logo).
There are around 60 such files in production in the moment and the jobs will be created on a low-priority queue when this rake task is run.
Fixes: https://github.com/alphagov/asset-manager/issues/276

Force pushing to fix rubocop violations.

Thanks @chrisroos - rebasing and force-pushing before merging.


ignoreContact, ignoreGrasping, ignoreHover need to be properties

InteractionBehaviour.ignoreContact/ignoreHover/ignoreGrasping should be properties that immediately cause EndContact, etc. callbacks to occur.

serialized attributes must remain for specifying and changing these values at runtime, but they should hook into properties (ignoreContact, ignoreGrasping, ignoreHover) instead of these values being mere variables that are checked every fixed frame.
if e.g. ignoreContact is set to false mid-frame, EndContact must be called immediately

This is fixed now!


feat: generate unified error dispatcher

Currently, output deserializers generate one "Error Dispatcher" per operation output. This may mean hundreds of these dispatcher functions (given that many commands) when the set of modeled errors tends to only be 5 to 10 in number.
This PR merges all error dispatchers into one function per service.
Comparison Metrics:

Web: bundle size of S3 is ~400 bytes larger when fully gzipped/minified as in a production environment. Total of ~160kb -> ~161kb.

Node.js: install size of dist-cjs

S3, 1020kb -> 976kb
Lambda, 784kb -> 700kb
EC2, 6.5mb -> 5.8mb
SageMaker, 3.1mb -> 2.6mb

What are the outlier AWS services with the highest count of distinct modeled exceptions? and what is the average count of modeled exceptions per service?

cloudtrail, 83

codecommit, 188 (600 line de_CommandError fn)

regardless of that, codecommit dist-cjs also gets smaller 1.1mb -> 896kb

codedeploy, 110

config-server, 53

a few services have between 20 and 50, (about 20 services)

the vast majority have less than 20 distinct exceptions (300+ services)

it is further possible to convert the syntax of the dispatcher from
switch (code) {
  case 'A':
  case 'B':
      throw await de_ExceptionRes(output, context);
  case 'C':
  case 'D':
      throw await de_Exception2Res(output, context);
  default:
    throwDefaultError(...)
}

to
const exceptions = {
  A: 1, // look up the index of the deser fn
  B: 1,
  C: 2,
  D: 2,
};
const deser = [
  de_ExceptionRes,
  de_Exception2Res
];
if (exceptions[code]) {
  throw await deser[exceptions[code]](output, context);
}
throwDefaultError(...)

But this is a very incremental reduction


cannot use tabs for ident code snippet

Don't know if bug or feature, but why it's there white-space: pre-line; on pre element?
( https://github.com/andybrewer/mvp/blob/566a4242b998cb818a6b859f68828c1d78b7d245/mvp.css#L217 )
With that i cannot format code snippet like this:
( () =>
{
	let counter = ( a, b ) =>
	{
		return a + b;
	}
} )();

and always got only:
( () =>
{
let counter = ( a, b ) =>
{
return a + b;
}
} )();

@iiic Thank you!! This has been a tricky one to get just right, but I think the next version will fix this. Much appreciated :)


fixed the messed policies

https://github.com/MicrosoftDocs/windows-itpro-docs/issues/8019

Dear @JohanFreelancer9,
kindly do the copy editor review for this PR.
Dear @e0i, for your information
Thank you


SQL "show config XXX" doesn't show the full config of tiflash

Enhancement
Some default config items are not displayed in the result of SQL "show config XXX".

for example：
profiles.default.max_memory_usage_for_all_queries


Can display the swipe path when run cypress using cy.realSwipe

As a topic, i would like to see simulating real user interactions when swipe from start point to end point, anyone have any idea to show swipe path please?

Ohh I actually think this is too much for this plugin. It only means to be used as the last hope for people who failed to use original cypress.
Alternatively when you click the command it displays a dot of starting the touch. Just add there the length to the side and it will be a path :D


Client Side Upload too slow

When doing Images.insert() from the client, the upload often causes so much lag that it crashes the browser (when doing simultaneous uploads). This is especially the case when files are 10 to 15 mbs+ uploaded simultaneously.
Is it somehow possible to reduce the lag? I would like try attempting the file upload with smaller chunks but I don't see anywhere in the docs on changing the chunk size.

You can set FS.config.uploadChunkSize to chunk size in bytes in client code.

@aldeed this doesn't seem to do anything to the massive delay before uploading files.. The entire UI blocks for like ten seconds here before beginning the XHR requests. Even for a 20KB image...

Might need a clean example repo to demonstrate this @jakobdamjensen

@rhyslbw it turned out to be just my machine doing it (on all file fields on all websites). A restart fixed it..


Game Crash - Activating piston w/ Mods installed

Describe the bug
While trying to activate a modded piston with a remote control the game crashed.  I am no longer able to get into this specific world.  However we were able to recreate the crash on a dummy world, after deleting the session.lock file to clear the running instance on the dummy world we were able to get back into that one and noticed the inventory was now reset but the base parts of the structure that caused the crash were still there.  We believe if we can reset the inventory on the good world (or another dummy  one for testing) that this may solve getting into the world.  Much of the below information requested can be found in the linked crash log.
Desktop (please complete the following information):
OS & version [e.g. Windows 10, 1822]:
Windows 10
MSFT Build of OpenJDK Version:
Please see crash log linked below
The output from java --version
To Reproduce:
Steps to reproduce the behavior:
Video of reproducing the crash and any other supporting video(s) link(s)
https://drive.google.com/file/d/1ZUzU7wpxSnjaNs7FE8n1raav4occ5Ryg/view?usp=sharing
https://drive.google.com/file/d/1T1yeHKoskfeCHH7TOD5Hn_xKQwsyQ1nx/view?usp=sharing
Expected behavior
Game should not crash
Screenshots, Logs etc
The crash log link is as follows https://drive.google.com/file/d/1ec0ptB8dM34omT935k2WdsQ0iAYF2Bkh/view?usp=sharing
Additional context
Add any other context about the problem here.

Thank you for the report!
Please submit this issue over at the Mojang bug tracker. Please search for existing reports first; in case you do not find any, create a new report and let us know about the issue number here (e.g. MC-123456). The Mojang team will take the first look. If an OpenJDK bug is identified, the Mojang team will contact the Microsoft Build of OpenJDK team to address the issue.


Reorganize local component metadata

This is a conglomeration of changes all bundled with the intent to simplify the way local component state and metadata are constructed. In particular, these changes update local components to no longer expose configuration metadata, but only variant metadata. In practice, this means it is much easier to keep track of state internally, as it only exposes variants of a single type.
We accomplish this by merging much of the logic that calculates outgoing variants from the local component metadata to the local component state. This way, we avoid two layers of caching that makes it difficult to implement proper thread-safe locking between projects.
Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test apt

I've triggered the following builds for you. Click here to see all build failures.

AllPerformanceTestsReadyForRelease build

@bot-gradle test apt

I've triggered the following builds for you. Click here to see all build failures.

AllPerformanceTestsReadyForRelease build

@bot-gradle test apt

I've triggered the following builds for you. Click here to see all build failures.

AllPerformanceTestsReadyForRelease build

Superseded by https://github.com/gradle/gradle/pull/29387


tempfile.SpooledTemporaryFile.encoding is None when the encoding parameter is utf-8

Code: https://github.com/fyntex/lib-cl-sii-python/blob/267c1a55423c7ed6ced718810bb4bd8164b65014/cl_sii/libs/io_utils.py#L61-L63
Test: https://github.com/fyntex/lib-cl-sii-python/blob/267c1a55423c7ed6ced718810bb4bd8164b65014/tests/test_libs_io_utils.py#L70-L73
This issue affects Python 3.7.2, but versions starting from 3.7.6 are not affected.

@glarrain The cause of https://github.com/fyntex/lib-cl-sii-python/blob/267c1a55423c7ed6ced718810bb4bd8164b65014/cl_sii/libs/io_utils.py#L61-L63 is bpo-26730.

Fixed in https://github.com/python/cpython/pull/17400.

Wow! How did you figure this one out?

Wow! How did you figure this one out?

When testing support for Python 3.8 I noticed that the bug wasn't there, and I knew that the bug was present in 3.7.2, so I concluded that the bug was fixed somewhere between those versions. A review of the VCS history of file tempfile.py, focused on class SpooledTemporaryFile, did the rest.

In which CPython versions (full) was it fixed?

The bug was fixed in Python 3.7.6, and is still fixed in 3.8.2.

Excellent! Expected no less of you ;)


Infinite recursion error in one to many with inversion

Laravel Version: 5.x (We are using 5.4 but it should also fail in 5.8)
PHP Version: 7.x
Database Driver & Version: irrelevant

Description:
$model->push() can create infinite recursions when the related entity has a relation to itself.
Steps To Reproduce:
Assume you have an Article with many comments. The comment also defines a "belongsTo" Article.
// first we load an article with at least one comment
$article = Article::query()->has('comments')->first();
// now we load the comments and remember the first one
$comment = $article->comments->first();
// we load the article of the comment - for what ever reason; could be a trigger somewhere
$comment->article;

// we duplicate this comment and push it to save also the article
$duplicate = $comment->replicate();
$duplicate->push();

In https://github.com/laravel/framework/blob/5.8/src/Illuminate/Database/Eloquent/Model.php#L610 is defined the push method will save the comment and then iterate over all relations and push them too. One of the relations is the article and the article has the comment in its relations and the comment has the article in its relations and the article has the comment in its relation and .. you see that is a bad idea.
Solution
When we pass all parents that are already pushed we can check that we don't run into a recursion.
public function push($parents = []) {
  $this->save();
  foreach ($this->relations as $models) {
    foreach ((array)$models as $model) {
      if (in_array($model, $parents)) {
        continue;
      }
      $model->push(array_merge($parents, [$this]));
    }
  }
}

Please verify this on 5.8 first. Thanks.

I don't see a reason to verify it on laravel 5.8. I can't update my application because of too much breaking changes. You will have to verify it on your own. The code has not changed since them.
There is a method that calls itself on another object without any checks for recursion. For sure this fails. If you don't want to fix it, fine! All models in our application have a parent class in our namespace - and laravel 5.4 will not be fixed anyway. So if I want to fix it in our application I have to do it anyway on our behalf.
It's the 3rd or 4th issue that just got closed without a solution or anything else. :confused:

@tflori we don't support 5.4 anymore so please verify this on 5.8 first.

I'll be happy to have a look and work on this, but probably not in time for 5.8 but rather something like 6.0.x.
@tflori If you need that fix and currently can't update to a higher version I may have a workaround for you. You could clone this repo, use it instead and then back-port the (to be provided) fix to version 5.4.
Hope that helps for now.


[RIP-9]Delete the Introduction and underlines

What is the purpose of the change
Delete the Introduction and underline
Brief changelog
Delete the Introduction and underlines
Verifying this change
Delete the Introduction and underlines
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+0.06%) to 49.1% when pulling 94634fbbd5c7f0e87c0933cb0afa1ca388dd0ba7 on dust6174:develop into 84552bd2d26d710035b1b25c931450dbd13f6015 on apache:develop.


name error

I'm having some difficulty with your app:
models.py
from sitecats.models import ModelWithCategory  # this was just a guess on my part
...
class Entry(sitecats.models.ModelWithCategory):
NameError: name 'sitecats' is not defined
urls
url(r'^sitecats/', include('sitecats.urls')),
settings
INSTALLED_APPS = [
'django.contrib.admin',
...
'sitecats',
]
I used pip install and the app is in site packages inside a venv. What's wrong?

You're misinterpreting import machinery.
Make you class definition either
from sitecats.models import ModelWithCategor
class Entry(ModelWithCategory):

or
import sitecats
class Entry(sitecats.models.ModelWithCategory):

Considered closed.
Feel free to reopen if required.


[BUG] Helm uninstall stuck

Describe the bug
Longhorn helm chart uninstall can't remove longhorn-ui deployment
To Reproduce
Steps to reproduce the behavior:

helm install longhorn
helm uninstall longhorn
uninstall can't remove UI deploy, the uninstall process stuck

Expected behavior
Should remove the UI deployment, and finish the whole uninstall process.
Environment

Longhorn version:  1.2.4
Installation method (e.g. Rancher Catalog App/Helm/Kubectl): helm
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: k3s 1.23.4

Number of management node in the cluster: 3
Number of worker node in the cluster: 8

Node config

OS type and version: debian

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): baremetal
Number of Longhorn volumes in the cluster: 1

Hi @dyipon did you use any parameters with your helm installation?
Attaching my command history for reference:
$ helm repo add longhorn https://charts.longhorn.io
$ helm repo update
$ helm install longhorn longhorn/longhorn -n longhorn-system --create-namespace
# Open Longhorn UI via nodeport
# Create volume from the UI
$ helm uninstall longhorn -n longhorn-system

@kaxing I tried your commands, and works fine, but i don't know why my settings cause uninstall issues.
Here are my values, nothing special I just setup a backuptarget on installing:

defaultSettings.backupTarget: s3://longhorn@us-east-1/
defaultSettings.backupTargetCredentialSecret: minio-longhorn
defaultSettings.allowRecurringJobWhileVolumeDetached: true

I am also facing the same issue on RKE2. I have deployed longhorn 1.2.4 on RKE2 and the longhorn-manager pods are stuck in CrashLoopBackOff state.
Longhorn Installation using helm:
helm install -f longhorn/values.yaml longhorn/ --generate-name

longhorn uninstallation using helm:
helm uninstall  longhorn-1665382587

Pod are not in Running state,
[kubenode@master ~]$ kubectl get all -n longhorn-system
NAME                                            READY   STATUS             RESTARTS         AGE
pod/longhorn-driver-deployer-78985f4cf7-x69sh   0/1     Init:0/1           0                8h
pod/longhorn-manager-f4954                      0/1     CrashLoopBackOff   99 (4m21s ago)   8h
pod/longhorn-manager-gmfqx                      0/1     CrashLoopBackOff   99 (2m35s ago)   8h
pod/longhorn-manager-lfmwq                      0/1     CrashLoopBackOff   99 (3m25s ago)   8h
pod/longhorn-manager-mr92d                      0/1     CrashLoopBackOff   99 (3m7s ago)    8h
pod/longhorn-manager-qldq4                      0/1     CrashLoopBackOff   99 (4m ago)      8h
pod/longhorn-manager-sggpx                      0/1     CrashLoopBackOff   99 (3m25s ago)   8h
pod/longhorn-manager-tgxfw                      0/1     CrashLoopBackOff   99 (4m20s ago)   8h
pod/longhorn-ui-65d698b889-fh94t                1/1     Running            0                8h
pod/longhorn-uninstall-wpfc8                    1/1     Running            0                107s

NAME                               TYPE        CLUSTER-IP    EXTERNAL-IP   PORT(S)    AGE
service/longhorn-backend           ClusterIP   <IP_ADDRESS>   <none>        9500/TCP   8h
service/longhorn-engine-manager    ClusterIP   None          <none>        <none>     8h
service/longhorn-frontend          ClusterIP   <IP_ADDRESS>   <none>        80/TCP     8h
service/longhorn-replica-manager   ClusterIP   None          <none>        <none>     8h

NAME                              DESIRED   CURRENT   READY   UP-TO-DATE   AVAILABLE   NODE SELECTOR   AGE
daemonset.apps/longhorn-manager   7         7         0       7            0           <none>          8h

NAME                                       READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/longhorn-driver-deployer   0/1     1            0           8h
deployment.apps/longhorn-ui                1/1     1            1           8h

NAME                                                  DESIRED   CURRENT   READY   AGE
replicaset.apps/longhorn-driver-deployer-78985f4cf7   1         1         0       8h
replicaset.apps/longhorn-ui-65d698b889                1         1         1       8h

NAME                           COMPLETIONS   DURATION   AGE
job.batch/longhorn-uninstall   0/1           107s       107s

Same issue with v1.4.  Had over 300 restarts on the csi plugin and could not uninstall.  Set all deployments to 0 replica and daemonsets to 0, still no luck.  Keeps on timing out.  Prefer to not manually delete if I can avoid it.

I had a similar issue, and noticed all the uninstall pods had errors with
$ k logs longhorn-uninstall-dqw4s -n longhorn-system
W0204 15:00:11.044194       1 client_config.go:617] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
I0204 15:00:12.252485       1 shared_informer.go:240] Waiting for caches to sync for longhorn uninstall
I0204 15:00:13.453485       1 request.go:665] Waited for 1.196222513s due to client-side throttling, not priority and fairness, request: GET:https://<IP_ADDRESS>:443/apis/longhorn.io/v1beta2/snapshots?limit=500&resourceVersion=0
I0204 15:00:14.353495       1 shared_informer.go:247] Caches are synced for longhorn uninstall
time="2023-02-04T15:00:14Z" level=fatal msg="cannot uninstall Longhorn because deleting-confirmation-flag is set to `false`. Please set it to `true` using Longhorn UI or kubectl -n longhorn-system edit settings.longhorn.io deleting-confirmation-flag "

After running the edit, it worked.

thank you @jfmatth ran into the same problem. I am confirming that running the suggested command by the logs in the uninstall pod worked

For me longhorn is stuck in installing, it can't get the images from our private registry, so when trying to uninstall it creates longhorn-uninstall-wknpl pod which stuck in getting the image from private registry too. So not installing and not uninstalling.

you tried my advice above?  I haven't used it in the newest version, but that above always worked for me

you tried my advice above? I haven't used it in the newest version, but that above always worked for me

Yes I tried your advice. But it did not work for me.

For 1.4.2 i dont see that setting 'deleting-confirmation-flag'...
❯ kubectl -n longhorn-system patch -p '{"value": "true"}' --type=merge lhs deleting-confirmation-flag Error from server (NotFound): settings.longhorn.io "deleting-confirmation-flag" not found
Installed from helm.

Done that also, edit is with no failure, but my change has no effect.
Once again editing shows there was no stanza previously inserted...

This issue is old and the info might no longhorn be relevant. Please create a new issue when encountering this issue again, providing environment details, and the steps to reproduce.


HTTP/2 2020

Part [Num] Chapter [Num]: HTTP/2
Content team

Authors
Reviewers
Analysts
Draft
Queries
Results

TBD
TBD
TBD
Doc
*.sql
Sheet

Content team lead: TBD
Welcome chapter contributors! You'll be using this issue throughout the chapter lifecycle to coordinate on the content planning, analysis, and writing stages.
The content team is made up of the following contributors:

Authors
Reviewers
Analysts

New contributors: If you're interested in joining the content team for this chapter, just leave a comment below and the content team lead will loop you in.
Note: To ensure that you get notifications when tagged, you must be "watching" this repository.
Milestones
0. Form the content team

[x] Jul 6th: Project owners have selected an author to be the content team lead
[x] Jul 13th: The content team has at least one author, reviewer, and analyst (minimally viable team formed)

1. Plan content

[x] Jul 20th: The content team has completed the chapter outline in the draft doc
[x] Jul 27th: Analysts have triaged the feasibility of all proposed metrics

2. Gather data

[ ] Jul 27th: Analysts have prepared all feasible metrics for testing and added queries to the sql directory

Aug 1 - 31: August crawl

[ ] Sep 7th: Analysts have queried all metrics and saved the output to the results sheet

3. Validate results

[ ] Sep 14th: The content team has reviewed the results sheet

4. Draft content

[ ] Oct 12th: Authors have completed the first draft in the doc
[ ] Oct 26th: The content team has prototyped all data visualizations

5. Publication

[ ] Oct 26th: The content team has reviewed the final draft, converted to markdown, and filed a PR to add it to the 2020 content directory

Nov 9th: Target launch date

Testing


Tomhaile/ch11149/not all initial liquidity is added

Clubhouse Story
Because this issue came up by three different people, I'm going to fix it.
Submitter checklist

[x] Test covering functionality added/fixed in
Check the linked story includes the following:

[ ] Steps to reproduce
[ ] Screenshot (If applicable)

Reviewer Checklist

[ ] Test/lint pass

John has a larger PR to fix multiple issues. closing PR.


Make it really zero dependencies

Shall we move babel-plugin-add-module-exports to devDependencies?

In fact, laravel-mix installs babel-preset-env, so that we can simply remove babel-plugin-add-module-exports.


Posting data malfunction

I'm simply trying to post json data to an express server. I know the post function in the server works because I've tested it in git bash
Here's the fetch code:
   addBug(bug) {
    let bugsModified = this.state.bugs.slice()
    bug.id = this.state.bugs.length + 1
    bugsModified.push(bug)

    fetch('http://localhost:3000/api/bugs', {method: 'POST', body: 'test'})
      .then(res => res.status === 200 && this.setState({bugs: bugsModified}))
  }

The {body: bugsModified} doesn't seem to send the server anything. Here's the code from the server:
app.use(bodyParser.json())

app.post('/api/bugs', (req, res) => {
  const bug = req.body
  console.log(bug) //returns undefined
  bugs.push(bug)
  res.json(bug)
})

app.listen(3000, () => console.log('connected...'))

What is your bugsModified? I doubt it's a string/buffer/stream.
There is no JSON type in JS, just string or object. And we definitely don't take arbitrary object (nor do Fetch Spec support that).
ref:

https://github.com/bitinn/node-fetch/blob/master/index.js#L231-L242
https://fetch.spec.whatwg.org/#concept-body

(As a side-note, you should reduce your code to minimal test case, in this case you are not getting proper help because you fail to make it readable for developers not familiar with your codebase)

In the example code, I'm actually just sending a string.
body: 'test'}
It doesn't matter what I send, it doesn't work. I've tried sending all types of data.

It doesn't matter what I send, it doesn't work. I've tried sending all types of data.

This is your friend, test your code: http://httpbin.org/


chore: clarify uc outage details

WDYT @daniel-beck ?

🤷 Would just have deleted it because references exist, but as long as we're not unnecessarily duplicating content, it's fine.


Distributed store

Data structure that allows generators to access observations from multiple data sets stored on disk.

h5ad is most likely a good solution locally, zarr's advantage is that it also has remote store backings, such as for S3.


ci: Add coverage reports

This adds codecov to track test coverage.

Current dependencies on/for this PR:

main

PR #58

PR #59

PR #60   👈

This comment was auto-generated by Graphite.


Invalid or missing 'value' in get_af_vertical_num_dir response

System Health details
System Information

version
core-2024.9.2

installation_type
Home Assistant OS

dev
false

hassio
true

docker
true

user
root

virtualenv
false

python_version
3.12.4

os_name
Linux

os_version
6.6.46-haos

arch
x86_64

timezone
Europe/Rome

config_dir
/config

Home Assistant Community Store

GitHub API
ok

GitHub Content
ok

GitHub Web
ok

HACS Data
ok

GitHub API Calls Remaining
4994

Installed Version
2.0.1

Stage
running

Available Repositories
1409

Downloaded Repositories
25

Home Assistant Cloud

logged_in
false

can_reach_cert_server
ok

can_reach_cloud_auth
ok

can_reach_cloud
ok

Home Assistant Supervisor

host_os
Home Assistant OS 13.1

update_channel
stable

supervisor_version
supervisor-2024.09.1

agent_version
1.6.0

docker_version
26.1.4

disk_total
439.4 GB

disk_used
16.9 GB

healthy
true

supported
true

host_connectivity
true

supervisor_connectivity
true

ntp_synchronized
true

virtualization

board
generic-x86-64

supervisor_api
ok

version_api
ok

installed_addons
Advanced SSH & Web Terminal (19.0.0), File editor (5.8.0), Duck DNS (1.18.0), NGINX Home Assistant SSL proxy (3.10.1), Home Assistant Google Drive Backup (0.112.1), GoSungrow (3.0.7), Mosquitto broker (6.4.1), Network UPS Tools (0.13.1), Firefox (1.2.0), Whatsapp (1.3.5)

Dashboards

dashboards
7

resources
19

views
27

mode
storage

Recorder

oldest_recorder_run
September 9, 2024 at 16:44

current_recorder_run
September 18, 2024 at 14:25

estimated_db_size
1056.97 MiB

database_engine
sqlite

database_version
3.45.3

Xiaomi Miot Auto

component_version
0.7.20

can_reach_server
ok

can_reach_spec
ok

logged_accounts
1

total_devices
0

Checklist

[X] I have enabled debug logging for my installation.
[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of currently previous issues..

Describe the issue
System Logs full of this ERROR messages:
Invalid or missing 'value' in get_af_vertical_num_dir response: {'value': 0, 'key': 142922390}
Invalid or missing 'value' in get_af_vertical_num_dir response: {'value': 0, 'key': 142919124}
It seems they are not impacting basic functionalities.
This is my Fujitsu clima: ARXG24KMLA
Reproduction steps
errors in logs
Debug logs
This error originated from a custom integration.

Logger: pyfujitsugeneral.splitAC
Source: custom_components/fglair_heatpump_controller/climate.py:534
integration: FGLair heat pump controller integration (documentation, issues)
First occurred: 14:26:00 (1361 occurrences)
Last logged: 18:13:04

Invalid or missing 'value' in get_af_vertical_num_dir response: {'value': 0, 'key': 142922390}
Invalid or missing 'value' in get_af_vertical_num_dir response: {'value': 0, 'key': 142919124}

Diagnostics dump
No response

Hi @skydado ,
please if you want to try with: https://github.com/bigmoby/fglair_for_homeassistant/releases/tag/v0.3.22

Hi @bigmoby, unfortunately it does the same:

Hi, same problem for me but with Horizontal (get_af_horizontal_num_dir response)
core-2024.9.3 and integration v0.3.22

Hi guys,
please have a check with this release: https://github.com/bigmoby/fglair_for_homeassistant/releases/tag/v0.3.23


Return tuple as expected by encode_from_hooked call

Closing this, another PR contains this exact solution: #248


lsmem: Add lsmem

Thanks, and feel free to add some functionality ;-)

thank you! I will do it right after


[wasm-metadata] warn on missing docs and Debug impls

Submitting as a draft since this depends on https://github.com/bytecodealliance/wasm-tools/pull/1917 landing first. This provides some additional tidying up, ensuring everything is documented and we can't accidentally forget any Debug impls. Thanks!

https://github.com/bytecodealliance/wasm-tools/pull/1917 has landed, this should be ready for review now!


Infinite block placing + incorrect block placing

I've searched existing issues and couldn't find a duplicate.

[X] I confirm this is not a duplicate.

Operating System
Windows 11, Minecraft Version 1.21.3 (Latest)
Server Software Version/Commit
87aa5ec
What happened?
The server copies the first placed block by the player and infinitely places it, regardless of what the player has in their hand or if they have enough of that item to place. This works with an empty inventory and in survival.
I have seen the server be 'fine' for ~15 seconds and then remove all blocks (regen the chunk?) and then do this bug. Clearly the server is preserving the first block the player interacts with and not updating, should be an easy fix.
To Reproduce
git clone (this repo)
cargo build -r
cargo run -r

Join server running on localhost, use the server console to change gamemode to creative and add blocks to inventory. Place any block, then switch to a different block. The first placed block will be placed instead of the selected block.
Expected behavior
The server should verify if the player has an item in hand and place the appropriate block.

Found the issue here. When set item_allowed_override is set to false the server behaves normally. Leaving this issue open as this is likely not intended behavior.

Currently the item count is not decreased when a block is being placed by a player in survival mode. I will take a look on this tomorrow


Localize new feature for Japanese and Simplified Chinese

What's this PR do?

[x] Localize new feature for Japanese
[x] Localize new feature for Simplified Chinese

What are the relevant Git tickets?
https://github.com/dwarvesf/hidden/pull/68#issuecomment-850279797
Screenshots (if appropriate)
Japanese:

Simplified Chinese:

Any background context you want to provide? (if appropriate)

@C-uo thanks 🙏


manual cell classification (signalSorter) support for larger than RAM movie files

Improved signalSorter.m to add support for large movies that can't be loaded into RAM.
HDF5 files should be chunked when saved to improve read speed (see writeHDF5Data or createHdf5File).
Changes to allow readHDF5Subset to efficiently read requests for individual frames or [x y z] movie chunks that contain overlapping or duplicate segments (as is the case when using signalSorter).
See comments for details on use.

Merging for now.


Stable release

netcdf4 version 1.4.0 uses cftime and it will be released soon on PyPI. (It is already available on GitHub and conda-forge is shipping it.)
It would be nice if we could have a stable release of cftime to accompany netcdf4 1.4.0.

Yes, I think we're ready for this. I'd like to get some doc related issues tied up. If someone has time to take care of #31, I think that plus #44 should be all we need to get the final release done.

release is up on pypi and github. conda-forge is pending tests/builds.


Feature: Set custom headers

Have you RTFM'd?

[X] I have done proper research

Feature Request
when I add a custom action, I want to see a hint for it, but the function to customize headers does not exist from my search.
can I optionally do something like:
require('fzf-lua').git_branches {
  actions = {
    ['ctrl-r'] = {
      fn = function(selected)
        -- some logic
      end,
      reload = true,
      header = 'to rename branch',
    },
    ['ctrl-d'] = {
      fn = function(selected)
        -- some logic
      end,
      reload = true,
      header = 'to delete branch',
    },
  },
}

thanks!

You can add any header with header = …, for example :FzfLua files header=foo.
If you’re looking for custom header generation for actions that would require some work as I need to refactor how the toggle actions headers are generated.

the thing is I use some custom functions and a different cmd on my git_branches so I cannot call :Fzflua git_branches unfortunately.
Since I add these extra actions, I want to show them on the hint/header bar

https://github.com/ibhagwan/fzf-lua/commit/81e7345697d65f6083c681995d230b2d73492233
@mosheavni, you can now add custom headers exactly as you specified in the OP.
:lua require("fzf-lua").files({
  actions={ ["alt-G"] = { fn=function(sel) print("sel",sel[1]) end, header="print"} }
})

For more complex headers (e.g. live_grep to grep) you can also provide a function and pass an object in the opts (or test against any known option/variable):
:lua require("fzf-lua").files({
  _myvar="foo", -- if you need to pass custom data
  actions={
    ["alt-G"] = {
      fn=function(sel) print("sel",sel[1]) end,
      header=function(o) return o._myvar end
    }
  },
})

awesome @ibhagwan !!!
I have a long header, any chance to break it into 2 lines?

awesome @ibhagwan !!! I have a long header, any chance to break it into 2 lines?

Yes, you need to supply --header-lines to tell fzf how many lines to set as header, you can send \n as part of the action header, just make sure to set the correct number of header lines:
:lua require("fzf-lua").files({ header="line1\nline2", fzf_opts={["--header-lines"]=2} })

I forgot you can utilize header_separator as \n and header_ prefix to remove the ::, you don’t need to manually define anything:
require("fzf-lua").files({
  header_prefix =  "",
  header_separator = "\n",
  actions = {
    ["alt-G"] = { fn = function(sel) print("sel", sel[1]) end, header = "peform G" },
    ["alt-g"] = { fn = function(sel) print("sel", sel[1]) end, header = "peform g" },
    ["alt-y"] = { fn = function(sel) print("sel", sel[1]) end, header = "peform y" }
  }
})

@mhogeveen, I didn't take that into account as fzf_exec does the bare minimal setup of the options (highlights, headers, etc), for the time being you'd have to manually call the set_header func:
local opts = {
  path = "~/.config/nvim",
  prompt = 'Projects > ',
  actions = {
    ['default'] = function(selected)
      vim.cmd("cd " .. selected[1])
    end,
    ['ctrl-d'] = {
      fn = function()
        vim.cmd "cd ~/.dotfiles"
      end,
      header = "open dotfiles",
    },
  }
}

opts = require("fzf-lua").config.normalize_opts(opts, {})  -- Inherit global opts (highlights, etc)
opts = require("fzf-lua").core.set_header(opts, { "actions" })  -- Setup header string from actions tbl

require('fzf-lua').fzf_exec("ls " .. opts.path,
  vim.tbl_deep_extend("force", opts, {
    fn_transform = function(option)
      return opts.path .. '/' .. option
    end
  })
)

@ibhagwan Works like a charm! Thanks a bunch

@ibhagwan Works like a charm! Thanks a bunch

I should probably make that work directly as you first posted, I’ll think about it :)


populate: Using a function for schema

Steps to reproduce
I was trying to use a function for schema (see https://auk.docs.feathersjs.com/api/hooks-common.html#selecting-schema-based-on-ui-needs)
const schemas = {
  'bar': {
    schema: {
      include: [
        {
          service: 'bar',
          nameAs: 'bar',
          parentField: 'barId',
          childField: '_id',
        }
      ]
    }
  }
};
...
before: {
    all: [client('schema')]
  },

  after: {
    all: [populate(() => schemas[hook.params.schema])]
  },

But I get this Error, when starting the app
Error: Options.schema is not an object. (populate)
at exports.default (/home/torge/src/feathers-sandbox/node_modules/feathers-hooks-common/lib/services/populate.js:23:11)
    at Object.<anonymous> (/home/torge/src/feathers-sandbox/src/services/foo/foo.hooks.js:25:11)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/home/torge/src/feathers-sandbox/src/services/foo/foo.service.js:4:15)

Expected behavior
In the docs it says that the populate hook accepts a function for shema, but it doesn't.
System configuration
Module versions (especially the part that's not working):
"feathers": "^2.1.3",
"feathers-hooks-common": "^3.5.1",
NodeJS version:
v7.7.2
Operating System:
ubuntu 16.10
Module Loader:
npm 4.1.2

The docs say schema may be a function, you however are making object a function. Use populate({ schema: () => {} }).

Thanks for the reply.
I got confused, because of this example in the docu:
purchaseOrders.after({
  all: populate(() => poSchemas[hook.params.schema])
});

Shouldn't it look like this:
purchaseOrders.after({
  all: populate({ schema: () => poSchemas[hook.params.schema] })
});

I guess that depends on what's in hook.params.schema but, at a minimum, the name is confusing.

I just found this old issue of mine, but it is already resolved, so i'm closing it. Thanks


HBASE-28174

See https://issues.apache.org/jira/browse/HBASE-28174
Very much a draft. I'm yet to test this. Testing checklist (hopefully I've caught everything here):

[x] GET b64-encoded row/column (specify encoding via query string)
[x] GET b64-encoded row/column (specify encoding via header)
[x] GET plain row/column
[x] multi-GET b64-encoded row/column (specify encoding via query string)
[x] multi-GET b64-encoded row/column (specify encoding via header)
[x] multi-GET plain row/column
[x] DELETE b64-encodedrow/column (specify encoding via query string)
[x] DELETE b64-encoded row/column (specify encoding via header)
[x] DELETE plain row/column

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 59s
master passed

+1 :green_heart:
compile
0m 24s
master passed

+1 :green_heart:
checkstyle
0m 10s
master passed

+1 :green_heart:
spotless
0m 42s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 26s
master passed

_ Patch Compile Tests _

-1 :x:
mvninstall
2m 38s
root in the patch failed.

-1 :x:
compile
0m 14s
hbase-rest in the patch failed.

-0 :warning:
javac
0m 14s
hbase-rest in the patch failed.

-0 :warning:
checkstyle
0m  8s
hbase-rest: The patch generated 4 new + 3 unchanged - 0 fixed = 7 total (was 3)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

-1 :x:
hadoopcheck
2m 23s
The patch causes 20 errors with Hadoop v3.2.4.

-1 :x:
hadoopcheck
4m 52s
The patch causes 20 errors with Hadoop v3.3.6.

-1 :x:
spotless
0m 38s
patch has 62 errors when running spotless:check, run spotless:apply to fix.

-1 :x:
spotbugs
0m 13s
hbase-rest in the patch failed.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m  1s
master passed

+1 :green_heart:
compile
0m 25s
master passed

+1 :green_heart:
checkstyle
0m  8s
master passed

+1 :green_heart:
spotless
0m 41s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 27s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 38s
the patch passed

+1 :green_heart:
compile
0m 23s
the patch passed

-0 :warning:
javac
0m 23s
hbase-rest generated 1 new + 153 unchanged - 1 fixed = 154 total (was 154)

-0 :warning:
checkstyle
0m  8s
hbase-rest: The patch generated 4 new + 3 unchanged - 0 fixed = 7 total (was 3)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
9m 57s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

-1 :x:
spotless
0m 38s
patch has 62 errors when running spotless:check, run spotless:apply to fix.

-1 :x:
spotbugs
0m 34s
hbase-rest generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
asflicense
0m  9s
The patch does not generate ASF License warnings.

25m 42s

Reason
Tests

FindBugs
module:hbase-rest

Comparison of String parameter using == or != in new org.apache.hadoop.hbase.rest.RowSpec(String, String)  At RowSpec.java:== or != in new org.apache.hadoop.hbase.rest.RowSpec(String, String)  At RowSpec.java:[line 64]

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5501

JIRA Issue
HBASE-28174

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux ef461a3716bd 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / fa4c8960e5

Default Java
Eclipse Adoptium-11.0.17+8

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-rest.txt

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-rest.txt

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/2/artifact/yetus-general-check/output/patch-spotless.txt

spotbugs
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/2/artifact/yetus-general-check/output/new-spotbugs-hbase-rest.html

Max. process+thread count
77 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 52s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 32s
master passed

+1 :green_heart:
compile
0m 31s
master passed

+1 :green_heart:
shadedjars
8m 23s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 23s
the patch passed

+1 :green_heart:
compile
0m 32s
the patch passed

+1 :green_heart:
javac
0m 32s
the patch passed

+1 :green_heart:
shadedjars
7m 39s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 17s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
5m  0s
hbase-rest in the patch passed.

33m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5501

JIRA Issue
HBASE-28174

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e5969d9b7522 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / fa4c8960e5

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/2/testReport/

Max. process+thread count
1540 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 58s
master passed

+1 :green_heart:
compile
0m 18s
master passed

+1 :green_heart:
shadedjars
4m 58s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 16s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 42s
the patch passed

+1 :green_heart:
compile
0m 18s
the patch passed

+1 :green_heart:
javac
0m 18s
the patch passed

+1 :green_heart:
shadedjars
5m  2s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 15s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
3m 55s
hbase-rest in the patch passed.

22m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5501

JIRA Issue
HBASE-28174

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 05a1374cea99 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 027a119bcf

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/3/testReport/

Max. process+thread count
1524 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m  5s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 33s
master passed

+1 :green_heart:
compile
0m 17s
master passed

+1 :green_heart:
shadedjars
4m 50s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 15s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 18s
the patch passed

+1 :green_heart:
compile
0m 18s
the patch passed

+1 :green_heart:
javac
0m 18s
the patch passed

+1 :green_heart:
shadedjars
4m 54s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
3m 16s
hbase-rest in the patch passed.

23m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5501

JIRA Issue
HBASE-28174

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7168fabc2d93 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 027a119bcf

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/3/testReport/

Max. process+thread count
1533 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

Actioned. I've never used JUnit before, so the test code might not be particularly idiomatic.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 24s
master passed

+1 :green_heart:
compile
0m 17s
master passed

+1 :green_heart:
shadedjars
4m 51s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 13s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 22s
the patch passed

+1 :green_heart:
compile
0m 16s
the patch passed

+1 :green_heart:
javac
0m 16s
the patch passed

+1 :green_heart:
shadedjars
4m 49s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 14s
the patch passed

_ Other Tests _

-1 :x:
unit
3m 23s
hbase-rest in the patch failed.

20m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5501

JIRA Issue
HBASE-28174

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 8ecbb9d33020 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4b5db21f3f

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-rest.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/5/testReport/

Max. process+thread count
1588 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/5/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 48s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m  7s
master passed

+1 :green_heart:
compile
0m 19s
master passed

+1 :green_heart:
shadedjars
5m 14s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 14s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 56s
the patch passed

+1 :green_heart:
compile
0m 18s
the patch passed

+1 :green_heart:
javac
0m 18s
the patch passed

+1 :green_heart:
shadedjars
5m 22s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 14s
the patch passed

_ Other Tests _

-1 :x:
unit
4m  3s
hbase-rest in the patch failed.

23m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5501

JIRA Issue
HBASE-28174

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 774b3d5c1765 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4b5db21f3f

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-rest.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/5/testReport/

Max. process+thread count
1557 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/5/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 24s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m  5s
master passed

+1 :green_heart:
compile
0m 25s
master passed

+1 :green_heart:
checkstyle
0m  8s
master passed

+1 :green_heart:
spotless
0m 39s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 25s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 35s
the patch passed

+1 :green_heart:
compile
0m 23s
the patch passed

-0 :warning:
javac
0m 23s
hbase-rest generated 11 new + 154 unchanged - 0 fixed = 165 total (was 154)

-0 :warning:
checkstyle
0m  7s
hbase-rest: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
9m 49s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
spotless
0m 39s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 32s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m  8s
The patch does not generate ASF License warnings.

25m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5501

JIRA Issue
HBASE-28174

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 509b044d91ca 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4b5db21f3f

Default Java
Eclipse Adoptium-11.0.17+8

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-rest.txt

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-rest.txt

Max. process+thread count
81 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/5/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Test failure log:
[ERROR] Tests run: 29, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 46.271 s <<< FAILURE! - in org.apache.hadoop.hbase.rest.TestGetAndPutResource
[ERROR] org.apache.hadoop.hbase.rest.TestGetAndPutResource.testUrlB64EncodedKeyHeader  Time elapsed: 1.225 s  <<< ERROR!
javax.xml.bind.UnmarshalException
 - with linked exception:
[org.xml.sax.SAXParseException; lineNumber: 1; columnNumber: 1; Content is not allowed in prolog.]
	at javax.xml.bind.helpers.AbstractUnmarshallerImpl.createUnmarshalException(AbstractUnmarshallerImpl.java:340)
	at com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallerImpl.createUnmarshalException(UnmarshallerImpl.java:523)
	at com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallerImpl.unmarshal0(UnmarshallerImpl.java:220)
	at com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallerImpl.unmarshal(UnmarshallerImpl.java:189)
	at javax.xml.bind.helpers.AbstractUnmarshallerImpl.unmarshal(AbstractUnmarshallerImpl.java:170)
	at javax.xml.bind.helpers.AbstractUnmarshallerImpl.unmarshal(AbstractUnmarshallerImpl.java:209)
	at org.apache.hadoop.hbase.rest.TestGetAndPutResource.checkValue1(TestGetAndPutResource.java:352)
	at org.apache.hadoop.hbase.rest.TestGetAndPutResource.testUrlB64EncodedKeyHeader(TestGetAndPutResource.java:399)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: org.xml.sax.SAXParseException; lineNumber: 1; columnNumber: 1; Content is not allowed in prolog.
	at java.xml/com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.createSAXParseException(ErrorHandlerWrapper.java:204)
	at java.xml/com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.fatalError(ErrorHandlerWrapper.java:178)
	at java.xml/com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:400)
	at java.xml/com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:327)
	at java.xml/com.sun.org.apache.xerces.internal.impl.XMLScanner.reportFatalError(XMLScanner.java:1465)
	at java.xml/com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl$PrologDriver.next(XMLDocumentScannerImpl.java:978)
	at java.xml/com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:605)
	at java.xml/com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:112)
	at java.xml/com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:534)
	at java.xml/com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:888)
	at java.xml/com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:824)
	at java.xml/com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141)
	at java.xml/com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1216)
	at java.xml/com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:635)
	at com.sun.xml.bind.v2.runtime.unmarshaller.UnmarshallerImpl.unmarshal0(UnmarshallerImpl.java:216)
	... 31 more

It's a similar stack trace for the second test failure.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 41s
master passed

+1 :green_heart:
compile
0m 23s
master passed

+1 :green_heart:
checkstyle
0m  8s
master passed

+1 :green_heart:
spotless
0m 40s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 24s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 39s
the patch passed

+1 :green_heart:
compile
0m 23s
the patch passed

-0 :warning:
javac
0m 23s
hbase-rest generated 11 new + 154 unchanged - 0 fixed = 165 total (was 154)

-0 :warning:
checkstyle
0m  7s
hbase-rest: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
9m 45s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
spotless
0m 38s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 32s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m  7s
The patch does not generate ASF License warnings.

24m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5501

JIRA Issue
HBASE-28174

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 34817033ce5e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4b5db21f3f

Default Java
Eclipse Adoptium-11.0.17+8

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/6/artifact/yetus-general-check/output/diff-compile-javac-hbase-rest.txt

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-rest.txt

Max. process+thread count
78 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/6/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[ERROR] org.apache.hadoop.hbase.rest.TestGetAndPutResource.testUrlB64EncodedKeyHeader  Time elapsed: 1.214 s  <<< FAILURE!
org.junit.ComparisonFailure: expected:<[text/xml]> but was:<[application/octet-stream]>
	at org.junit.Assert.assertEquals(Assert.java:117)
	at org.junit.Assert.assertEquals(Assert.java:146)
	at org.apache.hadoop.hbase.rest.TestGetAndPutResource.checkValue1(TestGetAndPutResource.java:351)
	at org.apache.hadoop.hbase.rest.TestGetAndPutResource.testUrlB64EncodedKeyHeader(TestGetAndPutResource.java:401)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.lang.Thread.run(Thread.java:829)

That's a bit more of a clue. Will keep digging tomorrow.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 23s
master passed

+1 :green_heart:
compile
0m 17s
master passed

+1 :green_heart:
shadedjars
4m 52s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 13s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 19s
the patch passed

+1 :green_heart:
compile
0m 17s
the patch passed

+1 :green_heart:
javac
0m 17s
the patch passed

+1 :green_heart:
shadedjars
4m 49s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
3m 19s
hbase-rest in the patch passed.

20m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5501

JIRA Issue
HBASE-28174

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d0f18b290560 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7f3921ae40

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/7/testReport/

Max. process+thread count
1621 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/7/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 50s
master passed

+1 :green_heart:
compile
0m 24s
master passed

+1 :green_heart:
checkstyle
0m  8s
master passed

+1 :green_heart:
spotless
0m 39s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 28s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 38s
the patch passed

+1 :green_heart:
compile
0m 24s
the patch passed

-0 :warning:
javac
0m 24s
hbase-rest generated 11 new + 154 unchanged - 0 fixed = 165 total (was 154)

-0 :warning:
checkstyle
0m  7s
hbase-rest: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
9m 53s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
spotless
0m 40s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 31s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m  7s
The patch does not generate ASF License warnings.

25m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5501

JIRA Issue
HBASE-28174

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 8e7ddd655d8a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7f3921ae40

Default Java
Eclipse Adoptium-11.0.17+8

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/7/artifact/yetus-general-check/output/diff-compile-javac-hbase-rest.txt

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/7/artifact/yetus-general-check/output/diff-checkstyle-hbase-rest.txt

Max. process+thread count
78 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/7/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  2s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 32s
master passed

+1 :green_heart:
compile
0m 24s
master passed

+1 :green_heart:
shadedjars
6m  7s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 16s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 25s
the patch passed

+1 :green_heart:
compile
0m 21s
the patch passed

+1 :green_heart:
javac
0m 21s
the patch passed

+1 :green_heart:
shadedjars
6m 18s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 16s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
4m 36s
hbase-rest in the patch passed.

27m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5501

JIRA Issue
HBASE-28174

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 10324b3607bc 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7f3921ae40

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/7/testReport/

Max. process+thread count
1594 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/7/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Thanks for providing UTs, @judilsteve ! One last ask I have before merging this is to also update the ref guide to explain this extra param. You can find the REST section under /src/main/asciidoc/_chapters/external_apis.adoc.

Documentation has been added. The base DELETE and multi-get endpoints were not documented at all, so I added examples for both the plaintext and base64 encoded versions. The examples are not exhaustive, but readers can combine multiple examples to get what they need (e.g. there is no example for placing a row-level delete marker with base64 encoding, but there is an example for deleting an entire row via plaintext row-key and an example for deleting a specific column via a base64-encoded row-key/column).

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 13s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 39s
master passed

+1 :green_heart:
compile
4m 48s
master passed

+1 :green_heart:
checkstyle
1m  9s
master passed

+0 :ok:
refguide
2m 24s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotless
0m 40s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
7m 14s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 38s
the patch passed

+1 :green_heart:
compile
4m 45s
the patch passed

-0 :warning:
javac
4m 45s
root generated 11 new + 910 unchanged - 0 fixed = 921 total (was 910)

-0 :warning:
checkstyle
1m 12s
root: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
1m 51s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
9m 44s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
spotless
0m 39s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
7m 33s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s
The patch does not generate ASF License warnings.

56m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/8/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5501

JIRA Issue
HBASE-28174

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile refguide

uname
Linux 896a47fe1ecb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e806350bd0

Default Java
Eclipse Adoptium-11.0.17+8

refguide
https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5501/8/yetus-general-check/output/branch-site/book.html

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/8/artifact/yetus-general-check/output/diff-compile-javac-root.txt

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/8/artifact/yetus-general-check/output/diff-checkstyle-root.txt

refguide
https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5501/8/yetus-general-check/output/patch-site/book.html

Max. process+thread count
177 (vs. ulimit of 30000)

modules
C: hbase-rest . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/8/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 50s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 31s
master passed

+1 :green_heart:
compile
2m 30s
master passed

+1 :green_heart:
shadedjars
6m 27s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 45s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 57s
the patch passed

+1 :green_heart:
compile
2m 47s
the patch passed

+1 :green_heart:
javac
2m 47s
the patch passed

+1 :green_heart:
shadedjars
7m 29s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 17s
the patch passed

_ Other Tests _

-1 :x:
unit
263m 48s
root in the patch failed.

303m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5501

JIRA Issue
HBASE-28174

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux df2206e5d926 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e806350bd0

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/8/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/8/testReport/

Max. process+thread count
5346 (vs. ulimit of 30000)

modules
C: hbase-rest . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/8/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  9s
master passed

+1 :green_heart:
compile
2m 21s
master passed

+1 :green_heart:
shadedjars
6m 29s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 48s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 34s
the patch passed

+1 :green_heart:
compile
2m 30s
the patch passed

+1 :green_heart:
javac
2m 30s
the patch passed

+1 :green_heart:
shadedjars
6m 18s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 12s
the patch passed

_ Other Tests _

-1 :x:
unit
382m 36s
root in the patch failed.

418m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/8/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5501

JIRA Issue
HBASE-28174

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux cb26a1ee8d8d 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e806350bd0

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/8/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/8/testReport/

Max. process+thread count
5899 (vs. ulimit of 30000)

modules
C: hbase-rest . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5501/8/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil I am not sure what to do about the test failure above. The logs show a timeout, which makes me suspicious of an issue on the build server, since none of the previous builds had this problem. The failing test is listed as "org.apache.hadoop.hbase.TestAcidGuaranteesWithBasicPolicy.(?)" which is even weirder.
I ran mvn test -Dtest=org.apache.hadoop.hbase.TestAcidGuaranteesWithBasicPolicy on my machine (which is running JDK11, same as the build server's failure scenario) and it ran 6 tests with 0 failures/errors.


Show us the best practices to optimize pages according to Google's Core Web Vitals

Google introduced Web Vitals 1-2 years ago to improve the quality of apps and sites presented to the users. Obviously this applies to rendered ICM store pages as well. What are the best practices that we should apply to our installation?