File "/config/custom_components/reolink_dev/binary_sensor.py", line 122, in handle_event

Reolink RLC-520A. Hardware IPC_523128M5MP, fw v<IP_ADDRESS>4_21121700, fwestenberg/reolink_dev v0.47, HACS v1.19.3, HA  v2021.12.10, RTSP and ONVIF options are enabled.
Strange situation. When I disabled HTTPS, leaving only HTTP, entries with errors immediately appeared in the log. Is this how it should be?
`2022-01-22 15:51:55 ERROR (MainThread) [custom_components.reolink_dev.binary_sensor] Motion states could not be queried from API
2022-01-22 15:51:55 ERROR (MainThread) [custom_components.reolink_dev.binary_sensor] Traceback (most recent call last):
File "/config/custom_components/reolink_dev/binary_sensor.py", line 122, in handle_event
await self._base.api.get_all_motion_states()
File "/usr/local/lib/python3.9/site-packages/reolink/camera_api.py", line 598, in get_all_motion_states
json_data = json.loads(response)
File "/usr/local/lib/python3.9/json/init.py", line 346, in loads
return _default_decoder.decode(s)
File "/usr/local/lib/python3.9/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/local/lib/python3.9/json/decoder.py", line 355, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
2022-01-22 15:52:26 ERROR (MainThread) [custom_components.reolink_dev.binary_sensor] Motion states could not be queried from API
2022-01-22 15:52:26 ERROR (MainThread) [custom_components.reolink_dev.binary_sensor] Traceback (most recent call last):
File "/config/custom_components/reolink_dev/binary_sensor.py", line 122, in handle_event
await self._base.api.get_all_motion_states()
File "/usr/local/lib/python3.9/site-packages/reolink/camera_api.py", line 598, in get_all_motion_states
json_data = json.loads(response)
File "/usr/local/lib/python3.9/json/init.py", line 339, in loads
raise TypeError(f'the JSON object must be str, bytes or bytearray, '
TypeError: the JSON object must be str, bytes or bytearray, not bool
2022-01-22 15:52:57 ERROR (MainThread) [custom_components.reolink_dev.binary_sensor] Motion states could not be queried from API
2022-01-22 15:52:57 ERROR (MainThread) [custom_components.reolink_dev.binary_sensor] Traceback (most recent call last):
File "/config/custom_components/reolink_dev/binary_sensor.py", line 122, in handle_event
await self._base.api.get_all_motion_states()
File "/usr/local/lib/python3.9/site-packages/reolink/camera_api.py", line 598, in get_all_motion_states
json_data = json.loads(response)
File "/usr/local/lib/python3.9/json/init.py", line 339, in loads
raise TypeError(f'the JSON object must be str, bytes or bytearray, '
TypeError: the JSON object must be str, bytes or bytearray, not bool
2022-01-22 15:53:28 ERROR (MainThread) [custom_components.reolink_dev.binary_sensor] Motion states could not be queried from API
2022-01-22 15:53:29 ERROR (MainThread) [custom_components.reolink_dev.binary_sensor] Traceback (most recent call last):
File "/config/custom_components/reolink_dev/binary_sensor.py", line 122, in handle_event
await self._base.api.get_all_motion_states()
File "/usr/local/lib/python3.9/site-packages/reolink/camera_api.py", line 598, in get_all_motion_states
json_data = json.loads(response)
File "/usr/local/lib/python3.9/json/init.py", line 339, in loads
raise TypeError(f'the JSON object must be str, bytes or bytearray, '
TypeError: the JSON object must be str, bytes or bytearray, not bool
2022-01-22 15:54:00 ERROR (MainThread) [custom_components.reolink_dev.binary_sensor] Motion states could not be queried from API
2022-01-22 15:54:00 ERROR (MainThread) [custom_components.reolink_dev.binary_sensor] Traceback (most recent call last):
File "/config/custom_components/reolink_dev/binary_sensor.py", line 122, in handle_event
await self._base.api.get_all_motion_states()
File "/usr/local/lib/python3.9/site-packages/reolink/camera_api.py", line 598, in get_all_motion_states
json_data = json.loads(response)
File "/usr/local/lib/python3.9/json/init.py", line 339, in loads
raise TypeError(f'the JSON object must be str, bytes or bytearray, '
TypeError: the JSON object must be str, bytes or bytearray, not bool
`

Same issue here...rolling back to previous version for now.

Hi @garry0garry ,
With firmware 3.1.0-XXXX HTTP is disabled by default and will not work unless you re-enable it.
Please enable extra logging (https://github.com/fwestenberg/reolink_dev/blob/master/TSHOOT.md) and provide the big chunks of logs here.

Web IF of camera was also unavailable, so a reboot of my camera fixed it for me.

Web IF of camera was also unavailable, so a reboot of my camera fixed it for me.

I am having same issue since release of (beta) 3.1.XXX software, I do reboot my camera once a day

Hi @garry0garry ,
With firmware 3.1.0-XXXX HTTP is disabled by default and will not work unless you re-enable it.
Please enable extra logging (https://github.com/fwestenberg/reolink_dev/blob/master/TSHOOT.md) and provide the big chunks of logs here.

home-assistant.zip
See <IP_ADDRESS>

2022-01-25 18:45:42 DEBUG (MainThread) [reolink.camera_api] cam2/<IP_ADDRESS>::send() HTTP Request params ={'token': 'f35c69e4945a940'}
2022-01-25 18:45:42 DEBUG (MainThread) [reolink.camera_api] cam2/<IP_ADDRESS>::send() HTTP Request body =[{'cmd': 'GetMdState', 'action': 0, 'param': {'channel': 0}}, {'cmd': 'GetAiState', 'action': 0, 'param': {'channel': 0}}]
2022-01-25 18:45:42 DEBUG (MainThread) [reolink.camera_api] cam2/<IP_ADDRESS>::send() HTTP Response status=500 content-type=(text/html)
2022-01-25 18:45:42 DEBUG (MainThread) [reolink.camera_api.data] cam2/<IP_ADDRESS>::send() HTTP Response data:
500 Internal Server Error

500 Internal Server Error
nginx

2022-01-25 18:45:42 ERROR (MainThread) [custom_components.reolink_dev.binary_sensor] Motion states could not be queried from API
2022-01-25 18:45:42 ERROR (MainThread) [custom_components.reolink_dev.binary_sensor] Traceback (most recent call last):
File "/config/custom_components/reolink_dev/binary_sensor.py", line 122, in handle_event
await self._base.api.get_all_motion_states()
File "/usr/local/lib/python3.9/site-packages/reolink/camera_api.py", line 602, in get_all_motion_states
json_data = json.loads(response)
File "/usr/local/lib/python3.9/json/init.py", line 346, in loads
return _default_decoder.decode(s)
File "/usr/local/lib/python3.9/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/local/lib/python3.9/json/decoder.py", line 355, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

The following command should work and provide a token number , if not, open a ticket at Reolink:
curl -H 'Content-Type: application/json' -k -X POST "https://CAM_IP/cgi-bin/api.cgi?cmd=Login&token=" --data '[{"cmd": "Login", "action": 0, "param": {"User": {"userName": "admin", "password": "PASSWORD"}}}]'

well you have mismatched USE_HTTPS and your port then ....

There is no option to specify http or https in the integration settings. There is no way to specify a port. In addition, there is a suspicion that you can do exception handling when the port is unavailable. If you think this is not an error, then I can close the ticket.

You need to enable HTTPS in your camera based on previous output you shared

+1 on this one. Also getting something similar like that in my logs.
2022-01-26 12:10:14 ERROR (MainThread) [custom_components.reolink_dev] Timeout fetching reolink.Balkon Kamera.motion_states data
2022-01-26 12:11:14 ERROR (MainThread) [custom_components.reolink_dev.binary_sensor] Motion states could not be queried from API
2022-01-26 12:11:14 ERROR (MainThread) [custom_components.reolink_dev.binary_sensor] Traceback (most recent call last):
  File "/config/custom_components/reolink_dev/binary_sensor.py", line 122, in handle_event
    await self._base.api.get_all_motion_states()
  File "/usr/local/lib/python3.9/site-packages/reolink/camera_api.py", line 601, in get_all_motion_states
    response = await self.send(body)
  File "/usr/local/lib/python3.9/site-packages/reolink/camera_api.py", line 1685, in send
    async with self._aiohttp_session.post(
  File "/usr/local/lib/python3.9/site-packages/aiohttp/client.py", line 1138, in __aenter__
    self._resp = await self._coro
  File "/usr/local/lib/python3.9/site-packages/aiohttp/client.py", line 535, in _request
    conn = await self._connector.connect(
  File "/usr/local/lib/python3.9/site-packages/aiohttp/connector.py", line 542, in connect
    proto = await self._create_connection(req, traces, timeout)
  File "/usr/local/lib/python3.9/site-packages/aiohttp/connector.py", line 907, in _create_connection
    _, proto = await self._create_direct_connection(req, traces, timeout)
  File "/usr/local/lib/python3.9/site-packages/aiohttp/connector.py", line 1175, in _create_direct_connection
    transp, proto = await self._wrap_create_connection(
  File "/usr/local/lib/python3.9/site-packages/aiohttp/connector.py", line 986, in _wrap_create_connection
    return await self._loop.create_connection(*args, **kwargs)  # type: ignore[return-value]  # noqa
  File "/usr/local/lib/python3.9/asyncio/base_events.py", line 1081, in create_connection
    transport, protocol = await self._create_connection_transport(
  File "/usr/local/lib/python3.9/asyncio/base_events.py", line 1111, in _create_connection_transport
    await waiter
asyncio.exceptions.CancelledError

@Wibias  I don't see where the similarity is....

In order to exclude such questions from users, I suggest to create exception handling for connection timeout and HTTP 500. And automatically connect to HTTP. If HTTP is not available, connect to HTTPS.

The similarity I saw was both times its trying to query the motion state from the api and both time its File "/config/custom_components/reolink_dev/binary_sensor.py", line 122, in handle_event and after that get_all_motion_states. If there is no similarity I can also create a new Issue.

The similarity I saw was both times its trying to query the motion state from the api and both time its File "/config/custom_components/reolink_dev/binary_sensor.py", line 122, in handle_event and after that get_all_motion_states. If there is no similarity I can also create a new Issue.

yeah there is no similarity, please open a case


Feature to clear all caches

Welcome! Please use this template for reporting bugs or requesting features. For questions about using Workbox, the best place to ask is Stack Overflow, tagged with [workbox]: https://stackoverflow.com/questions/ask?tags=workbox
Library Affected:
not sure
Browser & Platform:
all browsers
Issue or Feature Request Description:
I would like to request a feature to clear all workbox cache, IndexedDB and any other storage. I came across https://stackoverflow.com/questions/54376355/clear-workbox-cache-of-all-content but this only clears caches.
When reporting bugs, please include relevant JavaScript Console logs and links to public URLs at which the issue could be reproduced.

@jeffposnick

also read https://github.com/GoogleChrome/workbox/issues/2080 but it relies on the name of indexDB always being "workbox-expiration" which might change in future

If you want to clear everything, you might want https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Clear-Site-Data (which unfortunately isn't widely supported outside of Chromium browsers at the moment).
I do think this is basically the same request as #2080, and while there isn't a built-in solution for Workbox, I'd like to keep that other issue open to track it.


Live agent hand-off sample

Is your feature request related to a problem? Please describe.
There are no official samples for how to implement live agent hand-off with Bot V4.
Describe the solution you'd like
I would like this page to be updated with a sample from Microsoft that shows the recommended way of how to do this.

The scenario around handoff is a frequently requested scenario. Assigning to @yochay to scope this and determine timing for the team looking into this in more detail.

We are actively looking to standardize this pattern.

Is there any sample for this using the latest version of the framework? Where can I find it?

@tdurnford 	has a really nice handoff sample I'd recommend taking a look at if you're looking for something a little more recent.

Only for javascript unfortunately. I think a C# example would be more
interesting.
On Fri, Jul 19, 2019, 00:01 Michael Richardson<EMAIL_ADDRESS>wrote:

@tdurnford https://github.com/tdurnford has a really nice handoff sample
https://github.com/tdurnford/botframework-human-handoff I'd recommend
taking a look at if you're looking for something a little more recent.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/BotBuilder-Samples/issues/1133?email_source=notifications&email_token=AACXCQG6VRNVZZTBMDEE7W3QADR4JA5CNFSM4GOKRZ22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2J5P5A#issuecomment-513005556,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACXCQE4G7MPTAZ62XHXKETQADR4JANCNFSM4GOKRZ2Q
.

@diruuo mentioned @tompaana’s C# handover sample in his comment above.
https://github.com/tompaana/intermediator-bot-sample

I have implemented the "tompaana" solution for bot-agent-handoff (1 to 1 conversation), but how can I establish a "1 to n" scenario (i.e. one agent handling multiple users after bot escalation)?

assigning to @arturl, who is driving this work on our end.

Take a look at our documentation here: https://github.com/microsoft/BotBuilder-Samples/tree/master/experimental/handoff-library.
The APIs will be in SDK 4.8, C# and JS. Note that the APIs are just the "lingua franca" for initiating and acknowledging handoff, the actual integrations must be built for specific agent hub providers.
For an example of such integration, check out LivePerson Bot Framework connector: https://developers.liveperson.com/third-party-bots-microsoft-bot-framework.html

Has anyone found a good sample that works? I am trying to implement this now

Take a look at our documentation here: https://github.com/microsoft/BotBuilder-Samples/tree/master/experimental/handoff-library.
The APIs will be in SDK 4.8, C# and JS. Note that the APIs are just the "lingua franca" for initiating and acknowledging handoff, the actual integrations must be built for specific agent hub providers.
For an example of such integration, check out LivePerson Bot Framework connector: https://developers.liveperson.com/third-party-bots-microsoft-bot-framework.html

@arturl is there no plan for providing built in support for agent hub? samples stated here looks outdated and not using handoff protocol described in official document. Also checked closed issues on this topic but none of them leads to proper direction. @FreddieK01 Let me know if you find any direction.

thanks @AshishMoradiya I am trying to work it now. Its given me a good starting point. I guess with the handoff sample, I need to configure it to go to my own agent etc... (I'm using liveperson)

@AshishMoradiya, @FreddieK01,
We have LivePerson and Omnichannel samples here: https://github.com/microsoft/BotBuilder-Samples/tree/master/experimental/handoff-library/csharp_dotnetcore/samples
All samples are up to date.
Some customer already used them to build their own integrations, for example ServiceNow.

@arturl Thanks, I see now. I want to have a bot where it can handoff to LivePerson. To do this, using those samples, do I just use the LivePersonAgentBot, or do I need to use that in conjunction with the live person connector?

@AshishMoradiya, @FreddieK01,
We have LivePerson and Omnichannel samples here: https://github.com/microsoft/BotBuilder-Samples/tree/master/experimental/handoff-library/csharp_dotnetcore/samples
All samples are up to date.
Some customer already used them to build their own integrations, for example ServiceNow.

@arturl Thank you for your response, Could you please throw some light on how to build own agent hub and integration? I could not find much information on it, I want to develop user waiting queue and 1 agent chat with multiple user scenario.

Hi @AshishMoradiya, we're focusing on providing integrations with existing party agent hubs, and this is our recommended approach. To build your own hub, you can take inspiration from the work mentioned above in this thread (https://github.com/tompaana/intermediator-bot-sample) in which both users and agents are connected to the same bot, and the bot serves as the dispatcher.


Fixing UI Building

Description
Between sprints 2 and 3, there was a break in the building UI pop-up. In Sprint 4, we will hopefully fix this break, but also make the pop-up juicier and apply some of the feedback we got in sprint 2.
Milestones

[x] Find what broke the UI building pop-up (5th of Sept)
[x] Fix the pop-up - having it appear back on screen on click (8th of Sept)
[ ] Ensuring that all data is being loaded into the pop-up (9th of Sept)
[ ] Increase juiciness in pop-up through button hover aspects (10th of Sept)
[ ] Enusre that upgrade and sell buttons are working (12th of Sept)

Completion Deadline: October 12th
Documentation
Member
Olivia Leighton (@Olivialeighton)
Bagus Prabowo Reksoprodjo (@baguspr)
Tara-Jade Garnsworthy (@tgarnsworthy)
Syed Muhammad Zahir (@ChevScore)

Hey! This is just a message to summarise the fixes we went over today for the buildingUI: reformatting the class to use the new UGS functions and ensuring that there is a flag to indicate whether the UI is currently loaded!


FilmNow

Hello. Would it be possible to grab filmnow dash links.?

Yeah, sure, I'll make it available in JSON format so you receive an object
with the manifest & widevine proxy URLs
On Sat, 27 Feb 2021, 14:08 the-poor-gamer-124<EMAIL_ADDRESS>wrote:

Hello. Would it be possible to grab filmnow dash links.?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/redmusicxd/iptv_ro/issues/9, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHAX5VFM4QEFSDK5P5GRRRTTBDODRANCNFSM4YJ4CX4Q
.

super cool

but the widevine is static

Doesn’t matter.
On Sat, 27 Feb 2021 at 20:11, the-poor-gamer-124<EMAIL_ADDRESS>wrote:

but the widevine is static
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/redmusicxd/iptv_ro/issues/9#issuecomment-787112942,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHAX5VAI7W2R7R32ZGA4V4TTBEYTTANCNFSM4YJ4CX4Q
.

Yes since it can change at any time
2021-02-27 22:18 GMT+02:00, Dan Negru<EMAIL_ADDRESS>
Doesn’t matter.

On Sat, 27 Feb 2021 at 20:11, the-poor-gamer-124
<EMAIL_ADDRESS>

wrote:

but the widevine is static

—

You are receiving this because you commented.

Reply to this email directly, view it on GitHub

https://github.com/redmusicxd/iptv_ro/issues/9#issuecomment-787112942,

or unsubscribe

https://github.com/notifications/unsubscribe-auth/AHAX5VAI7W2R7R32ZGA4V4TTBEYTTANCNFSM4YJ4CX4Q

.

--

You are receiving this because you authored the thread.

Reply to this email directly or view it on GitHub:

https://github.com/redmusicxd/iptv_ro/issues/9#issuecomment-787129452

solved by ab443bc40d248b86aa41b191b64f670066108b9c


Improve help

Hello guys,
Colorize h[elp].
Write category with h[elp] using arguments the same way is already done with h[elp] without arguments.
Thank you very much.

I also think the help input should be colorized 👍 However, the approaches taken in this PR is not the best solution IMO. I think the baseline for this PR is:
1. The comment's format, whether it's the way it's written or how it is printed, shouldn't be changed. If you do want to change them, that's out of the scope of this PR.

2. Requiring files and extending modules in method definitions should generally be avoided, especially when they'll be called multiple times.

Hello @st0012 ,
I think I covered everything were asked.
This time the script is analyzing if the description starts with an instruction, and if it does colorizes the line.
There is just one workaround I had to make for the step back description. That is because the description starts with an instruction.
Thank you very much.


Host Event Listener Controls

Expand the host socket functionality into event listeners. Only allow the host to control event listeners. This should stop the bugs occurring with event listeners.

Now only the host can use event listeners


OFIV v3 stable set up

Can anyone assist me with this question: how do I set up Ohif  v3 on the Google Cloud Platform with Orthan? Are there any examples of Dockerfile and configuration?  Or  can someone send me link where i can check step by step how to set up it. Thx.

see https://docs.ohif.org/deployment/docker


perf: Remove unnecessary allocation and construction of a HashMap in Signature::parse

Summary

I noticed Signature::parse constructs a temporary HashMap for some reason. I removed this allocation and weird construction to speed up the parsing. I see no need for the wasteful temporary.
Checklist

[x] ran cargo make fmt
[x] using conventional commits to hightlight user-facing fixes and features

Thanks for the pr, this looks good to me! Is pretty similar to the implementation in the next branch, but good to get in sooner.
Only semantic difference looks like missing = in signature chunk is ignored here, vs errored in next branch implementation.

I was unaware of the ongoing effort on the next branch when I made this pull request. I could copy over its code into this pull request or just close it and wait for next.

I am ok with backporting it, running CI

Hello, @mennovf, I have recently merged some changes to bump msrv and fix the CI issues. Please rebase when you have the chance :)


ESP8266  WIFI attempts

(This issue was created with "Everbody knew it could not be done, then there was someone who didn't know that" in mind.)
Hello esp-rs,
Which advice is available for next attempts on getting WIFI available for the ESP8266?
Hoping this issue will bring fresh ideas, regards Geert Stappers

The most important thing is probably to have a pre-emptive scheduler like we have here: https://github.com/esp-rs/esp-wifi/tree/main/esp-wifi/src/preempt
Task switching is probably a bit easier since 8266 doesn't include the windowed registers feature.
Next would be to port https://github.com/espressif/ESP8266_RTOS_SDK/blob/master/components/esp8266/source/esp_wifi.c and https://github.com/espressif/ESP8266_RTOS_SDK/blob/master/components/esp8266/source/esp_wifi_os_adapter.c and see what the linker will complain about - probably there will be a lot of missing functions which just need to be implemented like we do here: https://github.com/esp-rs/esp-wifi/tree/main/esp-wifi/src/compat


withered demon

It is recommended to let the withered demon spawn in all biomes in the Nether, because when I add the Better Nether mod, the crimson forest biome will become very rare, making it difficult to find the withered demon

I'll see if I can add that option to the config.

I'll see if I can add that option to the config.

thx


Incompatible Swift version - framework was built with 3.1and the local version is 4.1

New Issue Checklist

[x] I have tried with the latest version of OHHTTPStubs
[x] I have read the README
[x] I have read the Using the right Swift Version of OHHTTPStubs for your project section
[x] I have searched in the existing issues
[x] I have read the OHHTTPStubs wiki to see if there wasn't a detailed page talking about my issue

Environment

version of OHHTTPStubs: [3.1]
integration method you are using:

[ ] Cocoapods
[x] Carthage
[ ] submodule
[ ] other

version of the tool you use: [0.29.0]

Issue Description
I updated to Xcode 9.3 and Swift 4.1 and then removed Carthage folder and ran carthage update --platform IOS. I expected it to download and install the dependency but it came back with the following error.
*** Skipped installing OHHTTPStubs.framework binary due to the error: 	"Incompatible Swift version - framework was built with 3.1 (swiftlang-802.0.53 clang-802.0.42) and the local version is 4.1 (swiftlang-9<IP_ADDRESS> clang-9<IP_ADDRESS>)."

When installing any library with Carthage, OHHTTPStubs included, you'll have to use the --no-use-binary flag of Carthage in order to be able to have the same ABI / Swift Version as your project.
This is because Carthage otherwise doesn't consider the fact that Swift isn't ABI-stable yet, and it's impossible to make pre-build binaries of libraries (like OHHTTPStubs or any other) ABI-stable yet, so when Carthage tries to download a pre-build binary there's no guarantee to download the pre-build binary of the right Swift ABI version. Allowing to do that would require us to re-publish a new pre-build binary every time a new Swift version is out, including beta versions, while Carthage only allows to publish one pre-build binary for each version of each lib. Even if we had the bandwidth to do that and decide to publish the pre-build binary of the latest version every time, that would mean that other users potentially not ready to update to the latest Xcode for other reasons would have the same problem and we wouldn't be able to content everybody anyway.
Using the --no-use-binary flag of Carthage will force Carthage to not use the pre-build binary (which will almost never be the right Swift ABI version for everybody anyway) and instead re-build the library from source using your own current Swift version, ensuring it's ABI-compatible just for that current version. This tip is valid for any library integrated with Carthage, not just OHHTTPStubs.

And also the message is just an info or warning, not an error. Carthage automatically falls back to build the framework.


Many threads

Simplified

Current coverage is 72.91%

Merging #1055 into master will decrease coverage by -0.01% as of 009f432

@@            master   #1055   diff @@
======================================
  Files          263     263
  Stmts        14875   14873     -2
  Branches      1618    1617     -1
  Methods          0       0
======================================
- Hit          10847   10845     -2
  Partial        416     416
  Missed        3612    3612

Review entire Coverage Diff as of 009f432

Uncovered Suggestions

+0.09% via ...argets/FileTarget.cs#1918...1930
+0.09% via ...argets/FileTarget.cs#1555...1567
+0.08% via ...c/NLog/LogFactory.cs#180...191
See 7 more...

Powered by Codecov. Updated on successful CI builds.


filesListFolder: TypeError "dimensions is undefined" if invalid image file in dropbox folder and "include_media_info: true"

When trying to use "filesListFolder" with the option "include_media_info: true" on a folder that contains an invalid image file (e.g. a file that simply has been renamed to have .jpg extension but is some PDF file for example) the client sdk throws an TypeError and fails to process the the response any further, even though the response itself contains more files and is, except for the missing dimensions object, syntactically correct.
Code called:
    dbx.filesListFolder({path: dropboxPath, recursive: true, include_media_info: true})         .then(readFolderContentsRecursive)         .catch(dropboxError);
Results in "dropboxError" callback being called from catch clause, and making it impossible for the client to ever retrieve the response.
The ErrorType handed to dropboxError contains a message saying "dimensions is undefined" and a stack trace as follows:
isSupportedFile@test.js:199:1
displayPreflight/</<@test.js:156:27.each@jquery.min.js:2:2813
displayPreflight/<@test.js:154:9.each@jquery.min.js:2:2863
displayPreflight@test.js:152:5
readFolderContentsRecursive@test.js:136:9M
@https://unpkg.com/dropbox/dist/Dropbox-sdk.min.js:8:2380P
@https://unpkg.com/dropbox/dist/Dropbox-sdk.min.js:8:2466F
@https://unpkg.com/dropbox/dist/Dropbox-sdk.min.js:8:2283_
@https://unpkg.com/dropbox/dist/Dropbox-sdk.min.js:8:592traverseTreeRecursive
@test.js:122:1startPreflight
@test.js:114:9checkForm
@test.js:88:5onsubmit
@index.php:1:1

The response from the dropbox server for this request is as follows:
{
    "entries":
    [{
        ".tag": "folder",
        "name": "invalid batch",
        "path_lower": "/test/invalid batch",
        "path_display": "/test/invalid batch",
        "id": "id:Wz595HW61xAAAAAAAAADDw"
    }, {
        ".tag": "file",
        "name": "invalid.jpg",
        "path_lower": "/test/invalid batch/invalid.jpg",
        "path_display": "/test/invalid batch/invalid.jpg",
        "id": "id:Wz595HW61xAAAAAAAAADCw",
        "client_modified": "2016-12-17T02:35:09Z",
        "server_modified": "2017-01-05T16:13:21Z",
        "rev": "64a3c1b875a",
        "size": 131129,
        "media_info": {".tag": "metadata", "metadata": {".tag": "photo"}},
        "content_hash": "56c15fb98e4ed9bd5303276be9ff9540f77117321145f295892b584a4bb0bbd2"
    }, {
        ".tag": "file",
        "name": "valid.jpg",
        "path_lower": "/test/invalid batch/valid.jpg",
        "path_display": "/test/invalid batch/valid.jpg",
        "id": "id:Wz595HW61xAAAAAAAAADFC",
        "client_modified": "2016-10-20T20:06:18Z",
        "server_modified": "2017-01-05T16:13:21Z",
        "rev": "64c3c1b875a",
        "size": 79739,
        "media_info": {
            ".tag": "metadata",
            "metadata": {
                ".tag": "photo",
                "dimensions": {"height": 714, "width": 1000},
                "time_taken": "2016-10-20T12:25:22Z"
            }
        },
        "content_hash": "8cd7d01b0bf71e58d939f04324b11a5afac71b386d46797e32f85d62d1d652d7"
    }],
    "cursor":"AAEd8iAUPgcDGhcffSxbJSoyhuelvXySD7kpeC-5dJkKIR5gFufo-j_8Quhug9gZPtSVONUbJ90bA8KofE0a0wBKLt2fkOVw8uCl6rpKwK_4lQmO8f9CQP51wUdSX8ym3RLAuLbBoORSI6tdCVL_5eOkPFpvuKAdr65PthrpJXfGO86TpU1fcvPIwg8CbRNk4g8",
    "has_more":false
}

You can see that the file called "invalid.jpg" which is simply a non-image file renamed to ".jpg" does not contain the expected dimensions object, thus the client sdk fails to parse the response.
Imho this is not a desired behaviour. Clearly the file is not a correct image file, but still I should be able to use the returned result in the client code and determine myself that the dimensions object is missing instead of getting no usable result out of the API.
Am I missing some parameter to supress this kind of validation and simply get the parsed response without an exception thrown or is this realy a wanted behaviour in the API? If so, how am I supposed to get the result of the folder list call without removing the option parameter "include_media_info: true" (if the parameter is ommitted the response is obviously parsed correctly, but I need the dimensions of the files for a preflight check of folder contents without downloading each and every image file to get this information or without sending individual media info requests for each file.
Tested in latest 2.5.0 release

Thanks for the report! I can't seem to reproduce this error from the SDK itself though. Based on the stack, it looks like the error is coming from your readFolderContentsRecursive method. The SDK should (and does in my testing), successfully return all of the objects, with the invalid one omitting dimensions.
Can you share your readFolderContentsRecursive method? You may just need an extra call to hasOwnProperty or something to that effect.

Greg, thanks a lot for your prompt reply. Actually you are all correct with you assumption, indeed I was missing a hasOwnProperty call on the metadata property before reading its dimensions property. So it was indeed an issue in my own code.
Sorry for wasting your time. Closing issue


Refactoring: review dockerpool module fields.

Now that all args are being stored in RepairnatorConfig, we might be able to clean some stuff like fields and parameter passing, e.g. the field skipDelete seems to be not necessary anymore in RunnablePipelineContainer and AbstractPoolManager.

Yes!


chore/spell checked

Description
spell checked
Platform Affected : NA

[ ] iOS
[ ] Android

Checklist : NA

[ ] Necessary comments have been made.
[ ] I have tested this change on:

[ ] iOS Simulator/Device
[ ] Android Emulator/Device

[ ] Unit tests and integration tests pass locally.

Hi 👋, Thanks for the updates! To keep each PR focused, could we limit this one to just the typo fix and leave the color change to the other pr #59  you oppend?

I am closing this. But feel free to reopen for the typo fix again.


[META] Update near-wallet.js to latest version on all examples

All our examples use the same near-wallet file that abstracts away the complexity of using the near-wallet-selector. We need to make sure all canonical examples have the methods used here:
https://github.com/near/near-discovery/blob/9b6332176e7fb6e1495a9f077ef4d4fdc42573e8/src/components/WalletSelector.ts
Notice that in the examples we use Javascript and JSDocs

[x] Hello World: https://github.com/near-examples/hello-near-examples
[ ] Guest Book: https://github.com/near-examples/guest-book-examples
[ ] Counters: https://github.com/near-examples/counters
[ ] Coin Flip: https://github.com/near-examples/coin-flip-examples
[ ] Donations: https://github.com/near-examples/donation-examples
[ ] Multiple Contracts: https://github.com/near-examples/frontend-multiple-contracts
etc

@gagdiez I think I should also add ethereum wallets to all examples, but I see you need this project ID. Did you set it up under a near account or your personal, we should probably have all the examples registered in the same place. https://docs.near.org/tools/ethereum-wallets#get-projectid


Add reverse resolver encoder

Add ReverseResolver
Fix string type description

Codecov Report

Merging #10 into master will increase coverage by 1.39%.
The diff coverage is 98.43%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   84.03%   85.43%   +1.39%
==========================================
  Files          23       26       +3
  Lines         946      982      +36
==========================================
+ Hits          795      839      +44
+ Misses        151      143       -8

Impacted Files
Coverage Δ

Sources/Solidity/ENS/ENSEncoder.swift
100% <ø> (ø)

Tests/Solidity/ENS/NamehashTests.swift
100% <100%> (ø)

Sources/Solidity/ABIType.swift
78.57% <100%> (+3.57%)
:arrow_up:

Sources/Solidity/ENS/ReverseResolverEncoder.swift
100% <100%> (ø)

Tests/Solidity/ENS/ENSEncoderTests.swift
100% <100%> (ø)

...sts/Solidity/ENS/ReverseResolverEncoderTests.swift
100% <100%> (ø)

Sources/Solidity/ENS/Namehash.swift
91.66% <91.66%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53bb60c...2d8838b. Read the comment docs.


[SPARK-28483][FOLLOW-UP] Fix flaky test in BarrierTaskContextSuite

What changes were proposed in this pull request?
I fix the test "barrier task killed" which is flaky:

Split interrupt/no interrupt test into separate sparkContext. Prevent them to influence each other.
only check exception on partiton-0. partition-1 is hang on sleep which may throw other exception.

Why are the changes needed?
Make test robust.

Does this PR introduce any user-facing change?
No.

How was this patch tested?
N/A

Jenkins, retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15609/
Test PASSed.

Test build #4869 has started for PR 25799 at commit 9dbdcb8.

Test build #110634 has started for PR 25799 at commit 9dbdcb8.

Test build #110634 has finished for PR 25799 at commit 9dbdcb8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110634/
Test FAILed.

Test build #4869 has finished for PR 25799 at commit 9dbdcb8.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15858/
Test PASSed.

Test build #110703 has started for PR 25799 at commit 9dbdcb8.

Test build #110703 has finished for PR 25799 at commit 9dbdcb8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110703/
Test FAILed.

Test build #110732 has started for PR 25799 at commit c8dcf42.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15879/
Test PASSed.

Test build #110732 has finished for PR 25799 at commit c8dcf42.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110732/
Test FAILed.

retest this please

Test build #110739 has started for PR 25799 at commit c8dcf42.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15882/
Test PASSed.

Test build #110739 has finished for PR 25799 at commit c8dcf42.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110739/
Test FAILed.

Retest this please.

Test build #110750 has started for PR 25799 at commit c8dcf42.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15894/
Test PASSed.

Test build #110750 has finished for PR 25799 at commit c8dcf42.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110750/
Test PASSed.

@WeichenXu123, while it seems fine, please make sure you have a sign-off or an approval from another committer, which is a standard approach. At least, you can wait for some positive comments.
Or, please clarify the reason why you're merging it without any sign-off from other people. In this way, you can a) avoid unexpected mistakes, and b) have another person who can take over your change, say, if you happen to leave this project; otherwise, no one can take over if most of changes are just merged without peer-review.
Although it is legitimate to merge as a committer as far as I know, practically we should better stick to this practice.

Also, please clarify which branch you merged to avoid the overhead for people to check commit history to see which branch it was merged.

For the record looks like this was merged to master


Ordered Bullets are getting changed to unordered bullets after copy and pasting within the editor

Jodit Version:  3.4.xxxxx
Browser:  Chrome
OS:  Windows/Mac/Linux
Is React App:  True
If we are creating an ordered list and trying to copy and paste it in the editor, the bullets are getting changed to unordered bullets.
Expected behavior:
Bullets format should be same after copy and paste

Actual behavior:
Bullets format is not maintained

Here it is probably necessary to correct not the copying logic, but the selection logic. If all UL/OL elements are selected, then the entire list must be selected there as well. I'll try to write a plugin for this

I'm willing to be a contributor in this project. Please let me know if I can help in anyway.


Add issue template for bug reports

Help both the community and ourselves by describing what
information is required in a bug report.
JerryScript-DCO-1.0-Signed-off-by: Akos Kiss<EMAIL_ADDRESS>

I know that the template is a bit verbose, but hopefully not frighteningly long. I hope that it will save us from repeating the same info requirements in issue discussions over and over again by showing those requirements upfront.

@akosthekiss I highly support this idea. In my opinion the fact that the issue reporter wants / is planning to submit a PR for the reported issue not a rare thing. So I would suggest to include this "willingness to contribute" somehow to the template. What do you think about it?

According to our history, I think that issue reporters fixing the reported bug is actually a rare thing. (Feature requests might be statistically different, but this PR wants to add a template for bugs only.)


ui: Add guest IP ranges

Description
Fixes https://github.com/apache/cloudstack/issues/4697

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[x] Minor
[ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@blueorangutan ui

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4716 (JID-3839)

@blueorangutan ui

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4716 (JID-3841)

@utchoang can you address:

Fix the tab to be only shown for shared networks, it's showing for L2 as well (ex. http://qa.cloudstack.cloud:8080/client/pr/4716/#/guestnetwork/6463e120-c36a-4569-aaa7-729922a55825?tab=guest.ip.range)
When we go to Infra -> zones -> phy network -> traffic type -> add router-link in the network name (for ex. http://qa.cloudstack.cloud:8080/client/pr/4716/#/physicalnetwork/d3249fba-8282-4ede-823c-2c1393bff05b?tab=traffic.types)

@rhtyd In the traffic type tab, if guest network is a Isolated | L2 then will not have router-link?

@blueorangutan ui

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4716 (JID-3842)

@blueorangutan ui

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4716 (JID-3844)

@blueorangutan ui

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4716 (SL-JID-14)

LGTM tested the live URL


Pow 0 to 0 should be 1 or error

One interesting edge case is what is the value of: 0^0. It can be only 1 or undefined ...
https://www.cuemath.com/questions/what-is-0-to-the-0-power/
udecimal returns 0 (I see comment but I don't understand why avoid 1?):
https://github.com/quagmt/udecimal/blob/master/decimal.go#L1151
print(udecimal.Zero.PowInt(0).String())

Returns 1:
https://github.com/govalues/decimal/blob/main/decimal.go#L1270
Returns error
https://github.com/shopspring/decimal/blob/master/decimal.go#L861

Because 0^0 and 0.Pow(negaive integer) are undefined, I want to make the behavior consistent: zero pow any number will return 0. Also from my experience, this is what I usually do (and I think some people will do the same):
func calcSomething(a decimal, e int) decimal {
      if a.IsZero() {
            // return 0 immediately if the input number is 0
           return Zero
      }

     // do pow calculation
     a.Pow(e)
     ....
}

I agree that the approach doesn't follow the standard as you mentioned. However the PowInt function only return decimal. To fix this, I'm thinking of deprecating the PowInt function and replace it by PowInt32(e int32) (decimal,error) to handle 0^0 and 0 pow negative correctly.


Add documentation for customising StreamField validation

Final part of #7250 - document how to add custom validation logic on StreamField blocks by overriding the clean method.

Merged with suggested wording tweak in a07fe20ceb7a7729a35ed67a2423cd973ba1b9c4.


Node-red crashes after a while

Currently have the add-on served via a reverse proxy with SSL termination. Seems to be running fine from a serving point of view and can connect to my HA API, but it will crash after 10 mins or so. Log is as follows:
[INFO] Disabling SSL
[INFO] Updating IDE Users
[INFO] Adding IDE User admin
[INFO] Disabling HTTP Node Authentication
[INFO] Disabling Projects
npm info it worked if it ends with ok
npm info using<EMAIL_ADDRESS>npm info using<EMAIL_ADDRESS>npm info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>npm info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>><EMAIL_ADDRESS>start /usr/src/node-red
> node $NODE_OPTIONS node_modules/node-red/red.js -v $FLOWS "--userDir" "/share/node-red"
15 May 01:45:44 - [info]
Welcome to Node-RED
===================
15 May 01:45:44 - [info] Node-RED version: v0.18.5
15 May 01:45:44 - [info] Node.js  version: v10.0.0
15 May 01:45:44 - [info] Linux 4.4.50 arm LE
15 May 01:45:46 - [info] Loading palette nodes
15 May 01:45:53 - [info] Settings file  : /share/node-red/settings.js
15 May 01:45:53 - [info] User directory : /share/node-red
15 May 01:45:53 - [warn] Projects disabled : set editorTheme.projects.enabled=true to enable
15 May 01:45:53 - [info] Flows file     : /share/node-red/flows.json
15 May 01:45:53 - [warn]
---------------------------------------------------------------------
Your flow credentials file is encrypted using a system-generated key.
If the system-generated key is lost for any reason, your credentials
file will not be recoverable, you will have to delete it and re-enter
your credentials.
You should set your own key using the 'credentialSecret' option in
your settings file. Node-RED will then re-encrypt your credentials
file using your chosen key the next time you deploy a change.
---------------------------------------------------------------------
15 May 01:45:53 - [info] Starting flows
15 May 01:45:54 - [info] Started flows
15 May 01:45:54 - [info] Server now running at http://<IP_ADDRESS>:1880/
15 May 01:58:40 - [red] Uncaught Exception:
15 May 01:58:40 - TypeError: flatten.depth is not a function
    at /share/node-red/node_modules/bonjour/lib/mdns-server.js:54:17
    at Array.forEach (<anonymous>)
    at Server._respondToQuery (/share/node-red/node_modules/bonjour/lib/mdns-server.js:48:19)
    at EventEmitter.emit (events.js:182:13)
    at Socket.<anonymous> (/share/node-red/node_modules/multicast-dns/index.js:48:40)
    at Socket.emit (events.js:182:13)
    at UDP.onMessage [as onmessage] (dgram.js:670:8)
npm info lifecycle<EMAIL_ADDRESS>Failed to exec start script
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: `node $NODE_OPTIONS node_modules/node-red/red.js -v $FLOWS "--userDir" "/share/node-red"`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2018-05-15T00_58_40_753Z-debug.log

Any thoughts anyone? I only had the one test flow in at the time. Simple input to a HA service call

That doesn't look related to the addon.  https://github.com/webpack/webpack-dev-server/issues/989 looks similar.


Remove all local table of contents

🚀 Pull Request
Description

Remove all local table of contents in the documentation.  This aligns with the latest.rst approach.  Users can use the side bar for navigation instead.

Consult Iris pull request check list

thanks @bjlittle


Can't get all available buckets.

I try to use s4cmd as a s3cmd, something like this:
./s4cmd -p /home/user/.s3cfg ls s3
i see my bucket's list
./s4cmd -p /home/user/.s3cfg-n ls s3
[Invalid Argument] Invalid parameter: s3, s3 path expected
./s4cmd -p /home/user/.s3cfg-n ls s3://*
[Errno -2] Name or service not known
[Errno -2] Name or service not known thread(s)]
[Errno -2] Name or service not known thread(s)]
How can I get all my buckets?

Yeah, this is a good observation. The reason is that bucket is actually like "domain" in a URL. So it is not part of "path". The API to get all buckets are different than the one that recursive through all keys. This needs special hacks in order to achieve this.


bin: add usage switch

It might be possible to extend it similar to how hub extends git -h once we get wrapping down. Figured it'd be nice to have it show some information in the meantime until we get the more finicky features in. Thanks!
Edit: I believe it's standard to return a 1 statuscode on -h? Not sure / not sure it matters.
Changes

bin: add usage flat that's triggered on no args / -h flag

Nice! re the status-code: When someone invokes foo -h I always exit with 0, because it’s not really an error. But when someone omits an argument or does something invalid, I do ensure a 1 is used.
But then I have no idea if invoking man-n is invalid... :confused:

Cool, I'll just leave it as-is then and merge. Don't think -h will be called programmatically that often, haha.

:+1:


Report datetime columns(begining and end of resource's existence) in metering report of VMs

New columns are named:
Beginning Of Resource Existence In Report Interval
End Of Resource Existence In Report Interval

Maybe we can find better names. @Loicavenel  @gtanzillo

Links

part of https://bugzilla.redhat.com/show_bug.cgi?id=1505115

@miq-bot assign @gtanzillo
@miq-bot add_label gaprindashvili/yes, enhancement

Gaprindashvili backport details:
$ git log -1
commit 99b16d77ed9ee2cfc5bd6993bcba7c5dc385d75c
Author: Gregg Tanzillo<EMAIL_ADDRESS>Date:   Tue Mar 13 10:43:53 2018 -0400

    Merge pull request #17100 from lpichler/add_beginning_start_of_resource_existence_in_report_interval

    Report datetime columns(begining and end of resource's existence) in metering report of VMs
    (cherry picked from commit 4d5a75301ccb360748345d1a74bd211e3ce56184)

    https://bugzilla.redhat.com/show_bug.cgi?id=1559543


Harmonise AvaloniaObject equality comparison

AvaloniaObject.Equals and GetHashCode are overridden, but only to seal the methods and prevent derived types from overriding them. This is fine at runtime, but causes static code analysis tools to think that the type has special equality logic. In my project this leads to annoying compile warnings every time we use == to compare two controls.
To Reproduce
Steps to reproduce the behavior:

Compare two AvaloniaObject variables with ==
Run Resharper on your solution with PossibleUnintendedReferenceComparison enabled
Resharper will warn about the comparison

Expected behavior
There are two options:

AvaloniaObject should stop overriding Equals and GetHashCode. An analyzer diagnostic can be emitted to warn anyone who tries to override those methods in a derived type.
AvaloniaObject should also provide operator == and operator !=, so that code analysis tools think that everything is customised and stops warning about it.

I think option 1 is preferable, because sealing the methods does not stop users from defining their own static equality operators.
Desktop

OS: N/A
Version 11 RC 1.1

Since ReSharper doesn't complain about System.Windows.DependencyObject, I believe that the issue is on the Resharper side, so we should open an issue at youtrack.jetbrains.com

Indeed, ReSharper added an hardcoded exception for DependencyObject. The warning was present for many years before. See https://youtrack.jetbrains.com/issue/RSRP-301767/Possible-unintended-reference-comparison-for-DependencyObject (I can't believe I reported that 11 years ago, time flies!). An external annotation would have been better...

https://youtrack.jetbrains.com/issue/RSRP-492562/Possible-unintended-reference-comparison-for-AvaloniaObject

Note that WPF's DependencyObject doesn't override == operator. I suppose there is a perf penalty for doing so.

Is it really a problem with modern runtime? I am pretty sure if will be inlined to the same code nowadays.

I've recently measured method call vs operator call = 0 difference in benchmark. You can check this also.

Fixed in rider


Integrated knife-opc into Chef

Signed-off-by: snehaldwivedi<EMAIL_ADDRESS>
Description

Merge this knife plugin into Chef.
Moved user password command to core chef

Related Issue
https://github.com/chef/knife-opc/issues/48
https://github.com/chef/knife-opc/issues/57
https://github.com/chef/chef/issues/3517
https://github.com/chef/chef/issues/3514 (covers knife user create should check file permissions), https://github.com/chef/chef/issues/3515, https://github.com/chef/chef/issues/3516
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[ ] I have read the CONTRIBUTING document.
[x] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

NOTE: this test is failing due to changes in gem chef/.bundle/ruby/2.7.0/gems/tty-prompt-0.21.0/lib/tty/prompt/question.rb
attr_accessor :echo  need to be added here

I am working on all review comments also I found that both knife user and knife opc user commands don't match completely, like for example knife opc user list also provide list of user associated with organisations which is not available in knife user list  command. So I think we need to merge that too and started working on that too.

@snehaldwivedi if knife org edit survives into core, please test it to see that it opens the editor? https://github.com/chef/knife-opc/issues/57

Regarding https://chefio.slack.com/archives/G08912B8E/p1600190312027500. For explanation,I have used used V2 tested all the commands and they are working fine. I have created an common class Userable and moved common codes of  user.rb & userv1.rb into it, which was required in my commands and used that like this https://github.com/chef/chef/pull/10187/files#diff-b6a20c4a70b8b7a50778c9747fd78c9eL38
https://github.com/chef/chef/pull/10187/files#diff-ebda7b27eff28ff699ce69fe7ba6e8b1R21. So this PR is currently using v2 objects.
Now currently, I working on naming convention comments and will update the PR once completed with that.

This still needs:

remove the userable mixin, that has nothing to do with this PR and it is complicating the issues

write the plugin using the userv1 object with the standard knife rest object.

don't change the api of the existing knife plugins

So the knife commands should all just use this rest object:
https://github.com/chef/chef/blob/master/lib/chef/knife.rb#L640-L645
All the knife commands inherit that for free, and that can be injected into the constructor.
Inside of chef-client everything should be getting this rest object injected into the constructor:
https://github.com/chef/chef/blob/master/lib/chef/run_context.rb#L50-L55
Most of the objects have a signature like this and allow injecting the rest client:
def initialize(chef_server_rest: nil, logger: nil)

It looks like client_v1 does not do that, but that is fine, just use the client_v1 object and please ignore the issue.  There needs to be some thought around cleaning that up.  Most likely what needs to happen is NOT any cleanup around the rest objects directly but that the users_v1 object needs to be converted to use ./mixin/versioned_api.rb like the cookbook_manifest.rb object does (users_v1 precedes the creation of the versioned_api mixin and was never converted), but that is WELL outside of the scope of this PR.

I have removed abstract_user as we are not covering cleanup #10458 on this PR. Updated API version back to 1 and used user_v1 for commands that require any helper methods else used directly  rest objects.

@tas50 Can you please have a look into the PR for merge or if any more changes required form my side?

You should be able to eliminate the @root_rest API object entirely and just use the default knife rest object.  That is a v2 REST object but it should work fine with the users_v1 object.  They don't have to match the rest object just needs to be a higher version, which it should be.  It would break with users_v0 which is deprecated at this point.

Hi @lamont-granquist
As per my analysis, I cannot use the default rest object as its uses chef_server_url which will not provide us the exact result required or the opc commands. Because chef_server_url is URL for the specific organizations which will not provide the proper result like if we need a list of all organization, global user requirement in this ticket.
If we can change chef_server_url to chef_server_root in rest object then we can use it. Please let me know if you have any suggestions on this or any other way to do this?

Okay the communication failure is now a bit more obvious.  You can do that, but you need to remove { api_version: "1" } off of the arguments, that's the problem that I'm having with it.


[ Binary Protocol - Enhancement ] Error codes with the Exception

I will report a question and a possibile enhancement to the binary protocol:
https://github.com/Ostico/PhpOrient/issues/18

Hi,
In 3.0 we introduced error codes in the protocol, anyway the server still send too generic errors, It's fixed but I leave this open for when we start to give back proper error codes.
Regards


Are Dashboards and Dashboard-related metadata encrypted at rest via CMK

According the note in blue at the top of the page, "Dashboards and dashboard-related metadata about users is encrypted at rest." If our ADX cluster is configured to encrypt data at rest using a CMK as described on this page, would this CMK also be used for the Dashboard and related metadata encryption as well?
It is unclear from the documentation on this page as well as the cluster encryption overview page if CMK applies for dashboards and related metadata as well.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a4be1640-3699-8fdf-07a2-c9b922499c90
Version Independent ID: 55027537-6af4-541d-da8d-e2cdc2b5fa92
Content: Visualize data with the Azure Data Explorer dashboard
Content Source: data-explorer/azure-data-explorer-dashboards.md
Service: data-explorer
GitHub Login: @shsagir
Microsoft Alias: shsagir

@pnarsi Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

@pnarsi Thanks for contacting us with feedback about our product documentation. Depending on the complexity, it could take from a few business days to a few weeks to look further into your question, issue, or suggestion. We'll contact you if we need further information, and you'll receive an email message each time we "@mention" you in a comment.
Thanks again for submitting your feedback. Your suggestions help improve our documentation.

Updated in  Pull Request #3267
#please-close


Toggl Button Extension Not Working With Salesforce Lightning

The button is not showing up in Salesforce Lightning, most likely needs to be optimised for it.

#1271 🚀


ServerFnError<T> should impl From<E: std::error::Error> for any T

Currently, ServerFnError has a blanket From impl to convert from E, but only with the default NoCustomError type:
impl<E: std::error::Error> From<E> for ServerFnError {
    fn from(value: E) -> Self {
        ServerFnError::ServerError(value.to_string())
    }
}

This means we can't easily use ? to convert other errors into a ServerFnError<MyCustomError>.
Instead I think we should provide a blanket impl for any T:
impl<T, E: std::error::Error> From<E> for ServerFnError<T> {
    fn from(value: E) -> Self {
        ServerFnError::ServerError(value.to_string())
    }
}

Feel free to make a PR.

That trait implementation interferes with the one in core, so Rust won't let that happen. I'm also not sure people want to convert their E into a String instead of using our WrappedError variant. Closing this as well.


After changing the association between tag and commit, the next version determination does not work.

https://github.com/k1LoW/octocov/pull/193
After changing the association between tag and commit, the next version determination does not work.
I believe my git manipulation is the problem. Please provide me with a workaround if possible.
What happened
v0.43.2...v0.43.1
What you expected to happened
v0.43.2...v0.43.3

The reason was that the version file had not been updated.
It is probably not a tagpr problem 🙏


Handle "user_properties" data in Ibutsu

Some teams have started to put user/test case specific metadata into a user_properties field that shows up in a test case's metadata in Ibutsu. The user_properties field is the correct field for metadata in the junit xml file.
The user properties data from these teams has a lot of data that we would normally consider to just be "metadata" (e.g. component, importance, assignee, etc). I think we have 3 options:

Advise these teams to push the data into metadata on the test result object
Add support for filtering on user_properties in ibutsu
Promote these fields into metadata in the result controller (like we do for component/env but only promoting to the "metadata" level)

@rsnyman What do you think? Do you think we need to support user_properties?
cc @mshriver

I think it would be best for ibutsu to leverage the standard that junit has established for defining user_properties, instead of forcing teams that want to upload results to ibutsu to add a hook to add the data that they've already put in user_properties into an ibutsu metadata dictionary too.
user_properties are already filterable through metadata.user_properties, but promoting those fields into metadata, or using the fields in user_properties to populate/select filter dropdowns on result/classify views would make the data that much more useful in the UI.   This is building on @john-dupuy enhancement in #207.

A high level design decision was reached in a recent discussion with @john-dupuy, @rsnyman, and @jjaquish.
Ibutsu will process user_properties on test result ingest and promote the fields to top level metadata.


Fix dnd/resize action on events which state has changed to draggable/resizable

This fix refers to this issue #1105 the problem happens when we are using draggable or resizable accessors, and events initially aren't draggable or resizable but after this state changes, they become and are rendered with onMouseDown  and onTouchStart . And this causes a problem because these events are bubbled by react (binded to document) after Selection initialization and Selection listeners are called before Event component.
The hack is to make possible for react bubble this events before Selection listeners are initialized.
I've also described this behaviour in react repo issue https://github.com/facebook/react/issues/17877 but to be honest I don't think its react bug because of how events are managed in react there is no option to manage custom events which are set in cDM or useEffect.

@jquense any chance to take a look on this one?


LD E n implementation and tests

Coverage increased (+0.01%) to 98.997% when pulling 86297f8df20f085b0338a050dce3675b442694f1 on lden-implementation into 7f7e07f4648d4cef027db9b9fa13949935fe1711 on master.


4.2.0 compability bug again?

Hi guys,
I just stumbled upon the ensure in with_devise_exclusive_scope': undefined method merge!' error.
As I could see this was fixed with the pull request of the branch 'lm-rails-4-2' .
However after including devise in the Gemfile, installing it, generating the views and the user model I got this error on running rake db:migrate.
Did I overlook something?

Which Devise version are you using? Are you sure the version you are using includes the fix you mention? Can you link to the commit?

Hi José,
Thanks for your fast answer!
I am using Devise 3.4.1 and as far as I can see it, a fix should have been merged with this commit: https://github.com/plataformatec/devise/pull/3153, no?
As far as I can see, the branch was merged on Oct. 3rd 2014, while 3.4.1 was released on Oct. 29 2014.

same here.
/vendor/ruby/2.1.0/gems/devise-3.2.4/lib/devise/rails/routes.rb:455:in ensure in with_devise_exclusive_scope': undefined method merge!' for #ActionDispatch::Routing::Mapper::Scope:0x007ffa22271c20 (NoMethodError)
from /Users/sergio/work/xx/sofa2/vendor/ruby/2.1.0/gems/devise-3.2.4/lib/devise/rails/routes.rb:455:in `with_devise_exclusive_scope'

Can you provide a sample application that reproduces the error? I am unable to reproduce it locally.


Add Compatibility for Cisco Jabber

In our Cisco Jabber Environment, v.Remote contains the Users eMail Address.
e.g:
v.Remote:
ictxbridge16452221619216<EMAIL_ADDRESS>This PR will fix the extraction of the correct Channel Name

Thanks!


Fix shapely.vectorized install by adding a pyproject.toml

Added a pyproject.toml to install cython and numpy at build time

Fix #1127

Coverage increased (+0.09%) to 85.221% when pulling 0b31b02aba3f558f7ee1451e605f48f32594fc97 on remy-phelipot:1127-add-pyproject-toml into 9667fe86b6668deb319e6eb0479bc84e5f6e73ee on Toblerity:master.

Thanks @remy-phelipot. I suppose there is no way to let the build-system requires depend on the extras you want to install? (meaning, if you don't install [vectorized], you in principle don't need to install numpy in the build environment)

Thanks @remy-phelipot. I suppose there is no way to let the build-system requires depend on the extras you want to install? (meaning, if you don't install [vectorized], you in principle don't need to install numpy in the build environment)

It's an interesting question. Actually there may be a way if a custom build_backend (of pyproject.toml) is defined. There is a hook function get_requires_for_build_wheel that can filter the build dependencies but I'm not sure the config_settings input parameter contains enabled extras.
I'll try that and keep you informed!


How to hook up the Wyze sensor bridge?

I want to use my Wyze sensors with HassIO with the HA-Wyzesense plugin. I plugged in the sensor bridge into my Proxmox machine and verified that the device is recognized by running lsusb on my Proxmox host.
Output of lsusb:
Bus 002 Device 002: ID 8087:8000 Intel Corp.
Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 001 Device 002: ID 8087:8008 Intel Corp.
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 004 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 003 Device 003: ID 1a86:e024 QinHeng Electronics
Bus 003 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub

Next, I ran this command outlined in the Readme to update the device hooks:  bash -c "$(wget -qLO - https://github.com/whiskerz007/proxmox_hassio_lxc/raw/master/set_autodev_hook.sh)" -s 100
When I rebooted HassIO, I went into the shell and checked the /dev directory, but I couldn't find a hidraw0 device.
Did I miss a step somewhere?

hmm for me i do find the hidraw0 but for some reasons can't set wyze sensor
root@homeassistant:/usr/share/hassio# dmesg | grep hidraw [    1.451477] hidraw: raw HID events driver (C) Jiri Kosina [    1.548144] hid-generic 0018:045E:0914.0001: hidraw0: I2C HID v1.00 Device [MSHW0030:00 045E:0914] on i2c-MSHW0030:00 [    2.094338] hid-generic 0003:1A86:E024.0002: hiddev0,hidraw0: USB HID v1.00 Device [HID 1a86:e024] on usb-0000:00:14.0-1.2/input0 [    2.347135] hid-generic 0003:045E:07CD.0003: input,hiddev1,hidraw1: USB HID v1.11 Keyboard [Microsoft Surface Keyboard] on usb-0000:00:14.0-1.4/input0 [    5.502710] hid-multitouch 0003:045E:07CD.0003: input,hiddev1,hidraw1: USB HID v1.11 Keyboard [Microsoft Surface Keyboard] on usb-0000:00:14.0-1.4/input0 [  702.270731] hid-generic 0003:1A86:E024.0004: hiddev0,hidraw0: USB HID v1.00 Device [HID 1a86:e024] on usb-0000:00:14.0-1.2/input0 root@homeassistant:/usr/share/hassio#

@pi642s Interesting, how did you get your container to mount /dev/hidraw0? Did you have to put something in the container's configuration file manually?

yup, same here!

I have recently push a change to set_autodev_hook.sh that might resolve you problem. Please follow the instructions here and report back if this did, or did not, resolve the problem.

Thanks @whiskerz007, I'll try it and report back!

What is the results from running ls -l /dev/hidraw*?

Output: ls: cannot access '/dev/hidraw*': No such file or directory

@rakeshdas1 Was that reply from running the command in the LXC or from Proxmox shell. The response that is needed is from Proxmox shell.

My bad, the output above is from the container, the Proxmox shell outputs the following:
crw------- 1 root root 242, 0 May 27 11:35 /dev/hidraw0

@rakeshdas1 Please verify that you have followed the instructions here (making sure to change the 100 at the end of the script to the ID of your LXC), rebooted the container, and are still having the problem?

@whiskerz007 Another run of the script solved the issue, thanks for helping me debug!


Pushes partial work related to JSON tour guide

Partial work related to https://github.com/vintasoftware/django-ai-assistant/issues/28
OSMAPI was tentatively being used, but it's highly likely you'll need to use https://github.com/mvexel/overpass-api-python-wrapper instead.

https://github.com/user-attachments/assets/00c35953-0aeb-4317-bf7a-8b960006036c


Will you publish the code?

In the paper you mention a "model-agnostic plugin" - will you open source the code for your approach?

yes, we will

yes, we will

Do you have a rough estimate of when that will be? :)

@djangogo When?

@finngaida @bhyzhao
Hi, the code is released now.

Will you release pre-trained models?


fix: remove curl_download_request_integration_test

This fixes #3003.
This test tests a curl download. Occasionally, it times out. It is never
retried because it's a test for the lowest layer of communication.
It is no longer needed because other, higher level tests with retries
are testing this path.

This change is

I think I like #3035 better as a fix, thoughts?

@dopiera FYI, I can restart just one build if that is all we need to do.

I think I like #3035 better as a fix, thoughts?

Certainly, I'm closing this one.


Call setDisplayGeometry after Session is resumed

I tested the changes with the modified Augmented Faces and AR model viewer samples.

Merged here: https://github.com/SceneView/sceneview-android/commit/8985f5061c69a6eff0e6e32b768f0a1356b3e098

Also merged in sceneview-android/dev: https://github.com/SceneView/sceneview-android/commit/e00704eb477ecad57b9c5ed66291d6ad88e607a7


Black empire Unit and buildings, some upgrades

Need to remove all references to lumber! So check Black Empire's Town Halls, workers, and Blacksmith.

I presume this should be "Unworldly" rather than "Unwordly"?

I think you probably want their damage type to start off as Hero since they're elites:

This cheeky tentacle on the left attacked me:

Should just be Far Sight!

Should be Obliterate (mechanically identical):

 Need to remove all references to lumber! So check Black Empire's Town Halls, workers, and Blacksmith.

Also missing the F building

These Obelisk models are funky, it takes like 10 seconds to show anything!

Costs lumber:

 These Obelisk models are funky, it takes like 10 seconds to show anything!

https://github.com/AzerothWarsLR/WarcraftLegacies/issues/3007

Shouldn't mention destroying trees

This guy disappears as soon as I train him

These two buildings have the same hotkey:

The tooltip here is "Research Accelerated Cycle" but the research name is actually Cursed Flesh.
You don't need to do anything here because I'll just automate it, but this is an FYI

What's "Old Scroll of Teleportation"? I imagine we need to delete that? Other shops have a different version.

Need to move these units to Q and W positions:

Button positions here are all kinds of screwy:

Need to capitalize One here:

Looks like the buff tooltip here got cut off. I imagine you were caught out by the fact that WC3 cuts off tooltips after the first comma!

These two buildings have the same icon:

Weird hotkey here:

Might automate hotkeys at some point, but not sure if I should automate hotkey from button position or button position from hotkey...

Images aren't uploading right now so this is just a comment.

Herald's Chaos Siphon says it can raise the caster's mana above its maximum value, but it actually can't. Need to update the tooltip or fix the spell.
Remove the first sentence from Chaos Siphon; "transfers Chaotic Energy" implies that Chaotic Energy is a mechanic.
I can't figure out how to increase the level of Heal. Need to either add a way to upgrade it or remove the "Level 1" bit from the tooltip.


notifyOffsetChanged ambiguous offset

When my widget's notifyOffsetChanged function is called, all I get is an offset. If a user has more than one tab open, there's no way to tell which BinaryView that offset belongs to.
If the intent is for the widget to track the BinaryView itself, the notifyViewChanged function segfaults on view_frame.getCurrentWidget().getData() with an invalid pointer (or am I misusing that?).

self.current_view_frame.actionContext().binaryView

Thank you, that should work for me. I'll give it a try once I'm back at my desk.
I feel like offset on its own isn't enough though. If multiple views is a first-class feature, and can be implemented by third parties, there's no telling what that offset might refer to, or if the view has changed again before the plugin has gotten around to processing the event. Just my $0.02.

Yes the intent is to stash a reference to the BinaryView in your dock widget. You will want to use something like 			view = view_frame.getCurrentViewInterface() 			self.data = view.getData() in your notifyViewChanged method. Make sure you don't combine the statements as the temporary object is necessary.

Here is the example plugin posted in slack.
`from binaryninja import log
from binaryninjaui import DockHandler, DockContextHandler, UIActionHandler
from PySide2 import QtCore
from PySide2.QtCore import Qt
from PySide2.QtWidgets import QApplication, QHBoxLayout, QVBoxLayout, QLabel, QWidget
instance_id = 0
class HelloDockWidget(QWidget, DockContextHandler):
def init(self, parent, name):
global instance_id
QWidget.init(self, parent)
DockContextHandler.init(self, self, name)
self.actionHandler = UIActionHandler()
self.actionHandler.setupActionHandler(self)
offset_layout = QHBoxLayout()
offset_layout.addWidget(QLabel("Offset: "))
self.offset = QLabel(hex(0))
offset_layout.addWidget(self.offset)
offset_layout.setAlignment(QtCore.Qt.AlignCenter)
datatype_layout = QHBoxLayout()
datatype_layout.addWidget(QLabel("Data Type: "))
self.datatype = QLabel("")
datatype_layout.addWidget(self.datatype)
datatype_layout.setAlignment(QtCore.Qt.AlignCenter)
layout = QVBoxLayout()
title = QLabel(name, self)
title.setAlignment(QtCore.Qt.AlignCenter)
instance = QLabel("Instance: " + str(instance_id), self)
instance.setAlignment(QtCore.Qt.AlignCenter)
layout.addStretch()
layout.addWidget(title)
layout.addWidget(instance)
layout.addLayout(datatype_layout)
layout.addLayout(offset_layout)
layout.addStretch()
self.setLayout(layout)
instance_id += 1
self.data = None
def notifyOffsetChanged(self, offset):
	self.offset.setText(hex(offset))

def shouldBeVisible(self, view_frame):
	if view_frame is None:
		return False
	else:
		return True

def notifyViewChanged(self, view_frame):
	if view_frame is None:
		self.datatype.setText("None")
		self.data = None
	else:
		self.datatype.setText(view_frame.getCurrentDataType())
		view = view_frame.getCurrentViewInterface()
		self.data = view.getData()

def contextMenuEvent(self, event):
	self.m_contextMenuManager.show(self.m_menu, self.actionHandler)

@staticmethod
def create_widget(name, parent, data = None):
	return HelloDockWidget(parent, name)

def addStaticDockWidget():
mw = QApplication.allWidgets()[0].window()
dock_handler = mw.findChild(DockHandler, '__DockHandler')
dock_widget = HelloDockWidget.create_widget("HelloDockWidget (Static Dock)", dock_handler.parent())
dock_handler.addDockWidget(dock_widget, Qt.BottomDockWidgetArea, Qt.Horizontal, True)
def addDynamicDockWidget():
mw = QApplication.allWidgets()[0].window()
dock_handler = mw.findChild(DockHandler, '__DockHandler')
dock_handler.addDockWidget("HelloDockWidget (Dynamic Dock)", HelloDockWidget.create_widget, Qt.BottomDockWidgetArea, Qt.Horizontal, True)
addStaticDockWidget()
addDynamicDockWidget()
`

Looking forward to this all going stable and digging through the docs. Appreciate the examples!


The Clockwork Tool

A GMod Tool for Clockwork.
Tools will be registered like this:
myTool = Clockwork.tool:New("Area Tool");
myTool.access = "a";
function myTool:OnDeploy() end;
function myTool:OnHolster() end;
Any hooks will be run so long as the player has the tool out.
You can use these for rendering, etc.
function myTool:OnLeftClick() end;
function myTool:OnRightClick() end;
function myTool:OnReload() end;
Tools will be able to do self:Call(data) to call a function with parameters on the client or the server.
Initial tools with release will include:

Area Tool
3D Text Tool
Door Commands Tool

You should also add Static Prop Tool.

@SomeSortOfDuck

Currently I have created a addon version without Clockwork Framework implementation, if your really desperate.
https://github.com/trurascalz/clockworkplugins/tree/master/Clockwork/clockworktoolguns Other than that, It is on my todo list at some point but not priority.

I'll see what I can whip up @skarphet @trurascalz

Check recent GitLab commits.


Multiple birefringence overlays

Implements https://github.com/mehta-lab/recOrder/pull/357#issuecomment-1526522379.
This works on a best-effort basis. If the user deletes part of the layer list (e.g. keeping orientation but not retardance) and loads another dataset, this will produce wrong overlays.
Also this treats any layer whose name starts with 'Retardance' and 'Orientation' as a birefringence layer. So layers with names like 'Retardance-mask' and 'Orientation of the fish body axis' will also be treated as birefringence layers and cause errors.


Generalise system properties type check

Currently the type checks in the AtomsBase interface are a little too strict.
Note, however, that for some reason the leading dimension needs to be 3 otherwise there is a segfault when reading back in the data (could be a bug ?).

Looks good, thanks!


API Authentication

TODO

@erfanio Context? Do you mean adding authentication to endpoints that need it?

@hugomd yes, mainly I want to if we can have role based auth or not?

closed by #40


Colors used at diagrams

For red-green-blind person, arrow colors (Data pathway, Log pathway) at https://docs.microsoft.com/en-us/azure/sql-database/sql-database-service-tier-hyperscale#distributed-functions-architecture section diagram are almost same color. So, it's hard to see directly, which one is which.
You should use "stronger" green (0,255,0) and red (255,0,0) on those diagrams.
I can see "pure" red and green. Problem is colors where green or red are mixed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 80e91c6d-6b32-5f29-a604-9a7857ed920c
Version Independent ID: bd7b284c-9cc5-c656-875b-d9b72568cb2e
Content: Azure SQL Database Hyperscale Overview
Content Source: articles/sql-database/sql-database-service-tier-hyperscale.md
Service: sql-database
Sub-service: service
GitHub Login: @stevestein
Microsoft Alias: sstein

@JJussi Thank you for the detailed feedback.
This is being assigned to the content author to evaluate and update as appropriate.

@JJussi - Thanks for the feedback. Yes, those colors did look very similar. I updated the green arrows to be much lighter. Hopefully that eliminates this issue so add another comment if not. The updated article should go live sometime tomorrow.
Thanks!
#please-close


fully_connected_preloaded example: Attempting to use uninitialized value input/input_producer/input_producer/fraction_of_32_full/limit_epochs/epochs

I have the error Attempting to use uninitialized value input/input_producer/input_producer/fraction_of_32_full/limit_epochs/epochs when I load data in my code. I have found the same issue on the fully_connected_preloaded example, so I think it may be a regression.
Environment info
Operating System: Ubuntu 16.04
Installed version of CUDA and cuDNN: Cuda 8.0 and CuDnn 8.0
$ ls -l /path/to/cuda/lib*/libcud*
-rw-r--r-- 1 root root   560184 juin  30 00:45 /usr/local/cuda/lib64/libcudadevrt.a
lrwxrwxrwx 1 root root       16 juin  30 00:45 /usr/local/cuda/lib64/libcudart.so -> libcudart.so.8.0
lrwxrwxrwx 1 root root       19 juin  30 00:45 /usr/local/cuda/lib64/libcudart.so.8.0 -> libcudart.so.8.0.27
-rwxr-xr-x 1 root root   394472 juin  30 00:45 /usr/local/cuda/lib64/libcudart.so.8.0.27
-rw-r--r-- 1 root root   737516 juin  30 00:45 /usr/local/cuda/lib64/libcudart_static.a
-rwxr-xr-x 1 root root 78065952 juin  30 01:08 /usr/local/cuda/lib64/libcudnn.so
-rwxr-xr-x 1 root root 78065952 juin  30 01:08 /usr/local/cuda/lib64/libcudnn.so.5
-rwxr-xr-x 1 root root 78065952 juin  30 01:08 /usr/local/cuda/lib64/libcudnn.so.5.0.5
-rw-r--r-- 1 root root 68709594 juin  30 01:08 /usr/local/cuda/lib64/libcudnn_static.a

If installed from sources, provide the commit hash: db90885e9f27b1e069dd689ddd2dd3b743ed1cb7
Steps to reproduce

cd tensorflow/examples/how_tos/reading_data
python fully_connected_preloaded.py

What have you tried?

`bazel run -c opt tensorflow/examples/how_tos/reading_data:fully_connected_preloaded``
python fully_connected_preloaded.py
My code, which is similar

Logs or other output that would be helpful
(If logs are large, please upload as attachment).
python fully_connected_preloaded.py
I tensorflow/stream_executor/dso_loader.cc:108] successfully opened CUDA library libcublas.so locally
I tensorflow/stream_executor/dso_loader.cc:108] successfully opened CUDA library libcudnn.so locally
I tensorflow/stream_executor/dso_loader.cc:108] successfully opened CUDA library libcufft.so locally
I tensorflow/stream_executor/dso_loader.cc:108] successfully opened CUDA library libcuda.so.1 locally
I tensorflow/stream_executor/dso_loader.cc:108] successfully opened CUDA library libcurand.so locally
Extracting /tmp/data/train-images-idx3-ubyte.gz
Extracting /tmp/data/train-labels-idx1-ubyte.gz
Extracting /tmp/data/t10k-images-idx3-ubyte.gz
Extracting /tmp/data/t10k-labels-idx1-ubyte.gz
I tensorflow/core/common_runtime/gpu/gpu_init.cc:102] Found device 0 with properties:
name: GeForce GTX 1080
major: 6 minor: 1 memoryClockRate (GHz) 1.7335
pciBusID 0000:02:00.0
Total memory: 7.92GiB
Free memory: 7.52GiB
I tensorflow/core/common_runtime/gpu/gpu_init.cc:126] DMA: 0
I tensorflow/core/common_runtime/gpu/gpu_init.cc:136] 0:   Y
I tensorflow/core/common_runtime/gpu/gpu_device.cc:838] Creating TensorFlow device (/gpu:0) -> (device: 0, name: GeForce GTX 1080, pci bus id: 0000:02:00.0)
Saving
W tensorflow/core/framework/op_kernel.cc:936] Out of range: FIFOQueue '_1_input/input_producer/input_producer/fraction_of_32_full/fraction_of_32_full' is closed and has insufficient elements (requested 1, current size 0)
	 [[Node: input/input_producer/fraction_of_32_full_Dequeue = QueueDequeue[_class=["loc:@input/input_producer/input_producer/fraction_of_32_full/fraction_of_32_full"], component_types=[DT_INT32], timeout_ms=-1, _device="/job:localhost/replica:0/task:0/cpu:0"](input/input_producer/input_producer/fraction_of_32_full/fraction_of_32_full)]]
Done training for 2 epochs, 0 steps.
Traceback (most recent call last):
  File "fully_connected_preloaded.py", line 157, in <module>
    tf.app.run()
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/platform/app.py", line 30, in run
    sys.exit(main(sys.argv))
  File "fully_connected_preloaded.py", line 153, in main
    run_training()
  File "fully_connected_preloaded.py", line 148, in run_training
    coord.join(threads)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/training/coordinator.py", line 333, in join
    six.reraise(*self._exc_info_to_raise)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/training/queue_runner.py", line 185, in _run
    sess.run(enqueue_op)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/client/session.py", line 382, in run
    run_metadata_ptr)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/client/session.py", line 655, in _run
    feed_dict_string, options, run_metadata)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/client/session.py", line 723, in _do_run
    target_list, options, run_metadata)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/client/session.py", line 743, in _do_call
    raise type(e)(node_def, op, message)
tensorflow.python.framework.errors.FailedPreconditionError: Attempting to use uninitialized value input/input_producer/input_producer/fraction_of_32_full/limit_epochs/epochs
	 [[Node: input/input_producer/input_producer/fraction_of_32_full/limit_epochs/CountUpTo = CountUpTo[T=DT_INT64, _class=["loc:@input/input_producer/input_producer/fraction_of_32_full/limit_epochs/epochs"], limit=2, _device="/job:localhost/replica:0/task:0/cpu:0"](input/input_producer/input_producer/fraction_of_32_full/limit_epochs/epochs)]]
Caused by op u'input/input_producer/input_producer/fraction_of_32_full/limit_epochs/CountUpTo', defined at:
  File "fully_connected_preloaded.py", line 157, in <module>
    tf.app.run()
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/platform/app.py", line 30, in run
    sys.exit(main(sys.argv))
  File "fully_connected_preloaded.py", line 153, in main
    run_training()
  File "fully_connected_preloaded.py", line 73, in run_training
    [input_images, input_labels], num_epochs=FLAGS.num_epochs)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/training/input.py", line 266, in slice_input_producer
    shared_name=shared_name)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/training/input.py", line 223, in range_input_producer
    shared_name, name, "fraction_of_%d_full" % capacity)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/training/input.py", line 133, in input_producer
    input_tensor = limit_epochs(input_tensor, num_epochs)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/training/input.py", line 84, in limit_epochs
    counter = epochs.count_up_to(num_epochs)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/ops/variables.py", line 573, in count_up_to
    return state_ops.count_up_to(self._variable, limit=limit)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/ops/gen_state_ops.py", line 127, in count_up_to
    result = _op_def_lib.apply_op("CountUpTo", ref=ref, limit=limit, name=name)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/framework/op_def_library.py", line 703, in apply_op
    op_def=op_def)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/framework/ops.py", line 2297, in create_op
    original_op=self._default_original_op, op_def=op_def)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/framework/ops.py", line 1231, in __init__
    self._traceback = _extract_stack()

This appears to be a regression since r0.9. Can you try r0.9 and see if it works for you?

Assigning @josh11b as he is the original author of fully_connected_preloaded.py

Same issue with cuda-7.0 cudnn v4 and tesla k40c.

init_op = tf.group(tf.initialize_all_variables(),                            tf.initialize_local_variables())
solves the issue

usage of num_epochs means you apparently have to use initialize_local_variables()

@MatthieuBizien, could you confirm that your issue is resolved by using initialize_local_variables so we can close hte issue?

This issue is already closed though.

The issue resolved in my case by calling initialize_local_variables(). It's a regression compared with r0.9.

Thanks for the update.


Windows build broken on master (awslogs)

Signed-off-by: John Howard<EMAIL_ADDRESS>This fixes awslogs after the version changes. Master on Windows doesn't currently build otherwise.

userns build is also broken without this

Bad merge was https://github.com/docker/docker/pull/16640 @tiborvass

LGTM

Ugh. Got to put the same fix in the unit test. Push coming shortly.

@jhowardmsft sorry about that

@tiborvass np. Test updated too. Passes locally. Fingers crossed :)

LGTM

thanks @jhowardmsft

Thanks @jhowardmsft, my apologies for breaking the build!


Disable default version bumping on auto tag

For some reason, it automatically bumped the tag to 1.5.2 when I merge into master, even if custom_tag was 1.5.1 which existed already. custom_tag should override defaults according to docs. This behavior didn't happen in PR. I will try this option to see if it will disable auto.

I forgot to parse the version 🤦

LGTM ✔


[curl] Debug libraries are incorrectly embedding vsnprintf and other functions

Describe the bug
Using the latest vcpkg (git clone --depth 1 https://github.com/microsoft/vcpkg.git) the Debug build exports the following symbols that should not be present:
                  LongToHandle
                  __local_stdio_printf_options
                  __local_stdio_scanf_options
                  _vsscanf_l

                  snprintf
                  sscanf
                  vsnprintf

That causes errors for consumers of curl:
error LNK2005: vsnprintf already defined in libcurl-d.lib(libcurl-d.dll)

In fact, the Debug build seems to import many more symbols that are not present in the Release build, although these extra symbols are prefixed with Curl_ or curlx_ so they won't cause problems:
                  Curl_GetFTPResponse
                  Curl_HMAC_final
                  Curl_HMAC_init
                  Curl_HMAC_update
                  Curl_MD5_final
...
                  Curl_xfer_setup1
                  Curl_xfer_setup2
                  Curl_xfer_setup_nop
                  Curl_xfer_write_done
                  Curl_xfer_write_resp
                  Curl_xfer_write_resp_hd

                  curlx_convert_UTF8_to_wchar
                  curlx_convert_wchar_to_UTF8
                  curlx_mstotv
...
                  curlx_uztoui
                  curlx_uztoul
                  curlx_verify_windows_version
                  curlx_win32_fopen
                  curlx_win32_open
                  curlx_win32_stat
                  curlx_write

Environment

OS: Windows
Compiler: VS 2022. Y:\VS\VC\Tools\MSVC\14.38.33130\bin\Hostx64\x64\cl.exe

To Reproduce
Steps to reproduce the behavior:

$env:VCPKG_BINARY_SOURCES="clear;files,$PWD/vcpkg/archive,readwrite"; .\vcpkg\vcpkg install --Triplet=x64-windows curl
dumpbin /EXPORTS vcpkg\buildtrees\curl\x64-windows-dbg\lib\libcurl-d.lib > libcurl-d.lib.EXPORTS.txt
dumpbin /EXPORTS vcpkg\buildtrees\curl\x64-windows-rel\lib\libcurl.lib > libcurl.lib.EXPORTS.txt

Failure logs

See the good Release exports libcurl.lib.EXPORTS.txt (attached).
Compare it to the problematic Debug exports libcurl-d.lib.EXPORTS.txt(attached)

Additional context
After some research, it looks like exporting all the symbols is something done upstream in curl/curl:
https://github.com/curl/curl/blob/b8c12634fce509673f8eda657e9a2222890707c1/CMake/CurlSymbolHiding.cmake#L27-L32

... disable symbol hiding for debug builds and for memory tracking.

Regardless, re-exporting C runtime functions is a problem.
I can mitigate it with the following patch added to portfile.cmake: symbol-hiding.patch
I think it should be enabled only through a vcpkg feature? I'm not an expert in vcpkg.

The CURL debug build is configured with ENABLE_DEBUG=ON.
Since CURL 8.4.0, this option unconditionally enables CURL_HIDDEN_SYMBOLS on WIN32.
https://github.com/curl/curl/commit/a8ebde99f7beffb8df33f797180da077eac169db#diff-31dbcd75744281bc2bbeb464df9949e67246eabbd8adfbafe20a87f86fa7eb2fR32
For MSVC, CURL_HIDDEN_SYMBOLS leads to the infamous CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS:
https://github.com/curl/curl/blob/b8c12634fce509673f8eda657e9a2222890707c1/CMake/CurlSymbolHiding.cmake#L58-L60
@vszakats Are you aware of the MSVC symbol issue?
Possible mitigation: Remove ENABLE_DEBUG from the port's debug configuration.

I wasn't aware, thanks for the heads up.
First thought: Is it intended to use ENABLE_DEBUG=ON?
It's a 100% insecure option meant for developing curl itself and running
its tests suites.
To obtain a build with debug info and asserts, it's enough to use
-DCMAKE_BUILD_TYPE=Debug or any other Debug config.
Such build is safe for "normal" use and/or by dependents.
This aside, what's interesting is that curl isn't supposed to be defining
these functions (snprintf, sscanf, vsnprintf, _vsscanf_l, LongToHandle),
and according to a quick grep: they are not defined anywhere in the source.
I don't have MSVC to test it locally, but a similar MinGW build is not
producing these symbols in libcurl.dll, with ENABLE_DEBUG=ON.
Which specific objects are exporting these symbols?

Perhaps CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS=ON is the
culprit, and perhaps it's an option to avoid?
In any case this issue applies to all -DURL_HIDDEN_SYMBOLS=OFF
MSVC build, not just ENABLE_DEBUG=ON, so it'd be nice to find the
root cause.

In vcpkg, port authors are not allowed to add CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS because it is known to cause problems. However, it is not required to remove it from upstreams.
IIUC the port should simply remove -DENABLE_DEBUG=ON. People interested in digging deeper into CURL can add it in other ways.

I don't have MSVC to test it locally

Neither do I ;-)

This aside, what's interesting is that curl isn't supposed to be defining
these functions (snprintf, sscanf, vsnprintf, _vsscanf_l, LongToHandle),
and according to grep: they are not defined anywhere in the curl source.

That's the problem of CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS: it may unexpectedly export symbols which actually belong to other libs.

In vcpkg, port authors are not allowed to add CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS because it is known to cause problems. However, it is not required to remove it from upstreams.
IIUC the port should simply remove -DENABLE_DEBUG=ON. People interested in digging deeper into CURL can add it in other ways.

Yes, that'd be sensible.

I don't have MSVC to test it locally

Neither do I ;-)

:)

This aside, what's interesting is that curl isn't supposed to be defining
these functions (snprintf, sscanf, vsnprintf, _vsscanf_l, LongToHandle),
and according to grep: they are not defined anywhere in the curl source.

That's the problem of CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS: it may unexpectedly export symbols which actually belong to other libs.

Nice! I'll make some experiments with it, and see if there is a way to avoid it in curl.

That's the problem of CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS: it may unexpectedly export symbols which actually belong to other libs.

Nice! I'll make some experiments with it, and see if there is a way to avoid it in curl.

It seems without this option, MSVC doesn't export symbols. There is no
implib generated.
According to the documentation, there is no option to export all declared symbols.
(or if there is, I did not find it)
The methods offered are variations of explicitly listing symbols to be exported.
That needs a list, which isn't practical to maintain or generate. CMake goes
with the latter, ending up with extra symbols. It's extracting them from .obj files.
This leaves the option to decorate every function with a macro and set that macro
accordingly, which is in turn an excessive change and hard to justify for this.
Keeping ENABLE_DEBUG disabled seems like the best fix IMO.

@jonahbeckford. I can mitigate it with the following patch added to portfile.cmake: symbol-hiding.patch

@vszakats. Keeping ENABLE_DEBUG disabled seems like the best fix IMO.

Is there anything wrong with keeping the approach used in curl's Release mode? The Release mode makes use of lib/libcurl.def, so my tiny patch gets you the Debug build with the correct symbols.

@jonahbeckford. I can mitigate it with the following patch added to portfile.cmake: symbol-hiding.patch

@vszakats. Keeping ENABLE_DEBUG disabled seems like the best fix IMO.

Is there anything wrong with keeping the approach used in curl's Release mode? The Release mode makes use of lib/libcurl.def, so my tiny patch gets you the Debug build with the correct symbols.

It could work, but with the complexity of idenfiying each symbol necessary
for tests, then maintaining a second copy of libcurl.def with an up-to-date
list of these symbols and the official ones.
ENABLE_DEBUG's purpose is to enable hooks and other internal debug
things for curl's own tests, via an internal DEBUGBUILD macro. It also
enables memory tracing by default, and effectively nils security features.
It's independent from the Debug preset offered by CMake.
I wonder, what would be the use-case for consuming an ENABLE_DEBUG libcurl?
Would a normal libcurl built in Debug mode work instead?

I wonder, what would be the use-case for consuming an ENABLE_DEBUG libcurl?

There is no use case

Would a normal libcurl built in Debug mode work instead?

I thought that was what my patch did, but perhaps I was mistaken. I'll defer to your analysis!