Make fields on supertype usable for subtype?

Hello all, I have a supertype/subtype schema configured with a shared primary key where the shared metadata (like author id, created date, etc) lives in the supertype and the unique fields live in the subtypes.
What's the recommended method to make the supertype's metadata fields visible to the subtype so that they can be recognized by postgraphile and used in filters and conditions for requests to allSubtype?  I can provide more information on request, TIA!

You could mean a number of things, please provide an SQL snippet indicating what you are doing.

Right.  Here's a minimal example (based loosely on the excellent forum_example):
create schema workspace;
create schema workspace_private;

create table workspace.person (
  id               serial primary key,
  first_name       text not null check (char_length(first_name) < 80),
  last_name        text check (char_length(last_name) < 80),
  about            text,
  created_at       timestamp default now()
);

create type workspace.itemtype as enum (
  'blog',
  'forum'
);

create table workspace.item (
  id                serial8 primary key,
  -- type specified on creation
  type              workspace.itemtype not null,
  created_at        timestamp default now(),
  modified_at       timestamp default now(),
  author_id         integer not null references workspace.person(id)
);

create function workspace.get_type_for(id bigint) returns workspace.itemtype as $$
  select type from workspace.item
  where (id = workspace.item.id)
$$ language sql stable;

create function workspace.get_author_for(id bigint) returns workspace.person as $$
  select person.*
  from workspace.person as person
  where person.id = (
    select author_id from workspace.item
    where (id = workspace.item.id)
  );
$$ language sql stable;

create table workspace.blog (
  id              serial8 primary key references workspace.item(id),
  content         text not null,
  CHECK (workspace.get_type_for(id) IN ('blog'))
);

create table workspace.forum (
  id              serial8 primary key references workspace.item(id),
  content         text not null,
  a_unique_field  text,
  CHECK (workspace.get_type_for(id) IN ('forum'))
);

The queries that Postgraphile creates has allItems allowed to be ordered by author_id/etc, but I'd really like allBlogs to be ordered/filtered by author_id/etc as well.  I think I want to generate something like this:
create table workspace.forum (
  id              serial8 primary key references workspace.item(id),
  content         text not null,
  a_unique_field  text,
  created_at        timestamp default now(),
  modified_at       timestamp default now(),
  author_id         integer not null references workspace.person(id)
  CHECK (workspace.get_type_for(id) IN ('forum'))
);

or maybe a representation of a query like this (not sure if this query works, I'm pretty rusty with SQL):
select item.*, forum.* from item, forum
where item.id = forum.id;

I've written get_author_for as a stop-gap for the author but I'd want it automated as if it were a built-in field.  As a separate issue, I'm thinking I have to write a custom function to mutate both item and forum when creating a new item, but maybe this can be automated too?  I hope I've explained enough of the issue.

Okay, so your request has a few parts.
First, the primary key references thing is a limitation I have felt myself: https://github.com/postgraphql/postgraphql/issues/432
I definitely plan to build that feature at some point, but haven't had time yet.
Second you want to filter based on a different table that shares the same ID; this also has been discussed before (I can't find the issue for it right now). This can be done in v4 by adding another plugin that extends the default filters, but will require a subquery for each column to be checked until we support https://github.com/graphile/graphile-build/issues/2 - another feature that I've not yet had time to implement yet.
A potential way around this for now would be to use a view; however that would drop support for relations currently (see #376).
At the moment I don't think there's a "perfect" way of implementing what you want without getting deep into writing your own plugins. Sorry 😞
You might want to look into table inheritance, but it comes with a long list of caveats.

Thanks for outlining the issues!  I thought about my data requirements a bit more and I think views for each subtype is probably the way for me to go, at the cost of another network request for referenced items (I also will have an itemref references item(id) for the subtypes).  Because of the itemref, table inheritance is less suitable for my use case.  Ideally, I want graphql inheritance to represent a schema like:
scalar Date

interface Item {
  id: ID!
  author: Person!
  created_at: Date!
  modified_at: Date!
}

type Post implements Item {
  id: ID!
  author: Person!
  created_at: Date!
  modified_at: Date!
  content: String!
  a_unique_field: String
  itemref:  Item
}

type Blog implements Item {
  id: ID!
  author: Person!
  created_at: Date!
  modified_at: Date!
  content: String!
  itemref:  Item
}

so that I can use the ...on Post { __typename created_at content a_unique_field } ...on Blog {...} graphql fragments to return a set of Items, and the client can inspect __typename to determine the type and react accordingly.  As it is, I can only return a set of either Blogs xor Posts, so a view can let me return the referenced item's id and type, and afaict the extra network request makes up for the lack of references in the view - I can work with that. :)

Another option is to create a type to represent the union; e.g.
create type SearchResult (
  blog blogs,
  post posts,
);

Then you just set non-null the one that you need.

[semi-automated message] Hi, there has been no activity in this issue for over 8 weeks so I'm closing it to keep the issues/pull request manageable. If this is still an issue, please re-open with a comment explaining why.


$everything operation on patient types do not return resources referenced by related resources (recursively related resources)

Create a transaction bundle that includes a Patient, Observations on that Patient, and Practitioners related to those Observations.
call /Patient/{patientId}/$everything
call /Patient/{patientId}/$everything?_types=Practitioner,Observation,Patient

Note that the second call does not return the same resources as the first (Practitioners are omitted)

4844-patient-everything-with-type-filter-fix has been merged


minor fix

Codecov Report

Merging #953 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #953      +/-   ##
============================================
- Coverage     46.99%   46.94%   -0.06%
+ Complexity     1557     1555       -2
============================================
  Files           354      354
  Lines          9755     9755
  Branches        968      968
============================================
- Hits           4584     4579       -5
- Misses         4829     4834       +5
  Partials        342      342

Impacted Files
Coverage Δ
Complexity Δ

...pring/boot/ApolloSpringApplicationRunListener.java
85.71% <100%> (ø)
9 <0> (ø)
:arrow_down:

...work/apollo/biz/message/DatabaseMessageSender.java
56.25% <0%> (-10.42%)
6% <0%> (-2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a9555c...293dbd1. Read the comment docs.

Coverage decreased (-0.05%) to 50.446% when pulling 293dbd1c0882b4acf56abf5c6525b4002670b0df on nobodyiam:minor-fix into 3a9555c37ebbde009b6bb8f8a12b5716d30f89ed on ctripcorp:master.


Ferdi Account log out after upgrade to 5.6.1-nightly.29 30 or 32

Bug description:
When i upgrade 5.6.1-nightly.28 to 5.6.1-nightly.29 or 5.6.1-nightly.30 or 5.6.1-nightly.32

my Ferdi account is not logged in
In settings Services, Workspaces and Account panel is disabled (Screenshot)
I can't log in, when i try to login i have purple screen, i reload Ferdi, he show me the login screen and when try to log with my email and password it fail.

I rollback to 5.6.1-nightly.28 and the log in works good with same email and password. (And i rollback to 5.6.1-nightly.27 because 28 have regression)
Steps to reproduce:

Install 5.6.1-nightly.28 and log you to a Ferdi account
Upgrade 5.6.1-nightly.28 to 5.6.1-nightly.29
Try to log in your Ferdi account

Expected behavior
Upgrade should not log out my Ferdi Account
Screenshots

Environment:
Version: 5.6.1-nightly.29
Electron: 13.1.9
Chrome: 91.0.4472.164
Node.js: 14.16.0
Platform: macOS Big Sur
Arch: x64
Build date: Tue Aug 17 2021 03:30:24 GMT+0200 (Central European Summer Time)
Git SHA: 6ad52a6
Git branch: nightly

Server: Ferdi

Debug information:

After the upgrade : debug_after_upgrade.txt
When i try to login after the upgrade: debug_after_try_login.txt

Thanks for logging this @sad270 . We suspect this PR to be the culprit - and I am reverting that at this time. Please downgrade to v27, and then upgrade to the next nightly (v33). Sorry for the inconvenience.

@sad270 - I just released v33 - please try it out and confirm if the issue has been fixed.

I also experienced this, v33 works again fine. Sorry for the broken version!

@vraravam i upgrade v33 and it's works goof for me too :)
Thank you.
And @mhatvan no problem it's nightly version, not beta or stable so it can have some issues don't worry :)

@vraravam you can remove the regression message on 5.6.1-nightly.28 in nightly releases page. The v28 haven't this issue, it's start from v29 to v32


clarify wamt help and fix the typo ...

WAMT also has help and I believe that the rule help may in fact be the same in both.
There is also a type in the text "coming" => coming

However, the Migration Toolkit for Application Binaries Analyze report has the advantage of comming with an explanation of the rule being applied so that the user can better understand the reason why a warning or error has been reported:

Added information about WAMT help in #13


Split up functions into multiple modules

Closes: #5
Signed-off-by: Christian Heimes<EMAIL_ADDRESS>Depends on #20 for JoseOperationError exception.

You could have changed the PR yourself. I left the "Allow edits from maintainers" feature on for trivial and nit-picky changes. :)


Move ansible-runner related file into it's own folder

Move ansible-runner related logic out on action folder
at the top level as runner API's can be invoked outside
of action
Modify relevant changes in explore

GH won't let me re-open this because forks got deleted earlier when perms were adjusted. I just wanted to close + reopen to get GHA to pick it up and run tests. :(


Prevent NPE in CommentMustAsDiff if no hunk header (#15199)

Backport #15199
I do not understand how this can happen or why.
There is an apparent possibility for a comment.Patch to be missing a hunk header

this should not happen and I do not understand how. But it appears to happen on
1.13 at least in some case.

This PR will simply add a new section if the cursection is empty
thus preventing the NPE.
Fix #15198
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

:rocket:


Support for async/await in the database layer

I was trying to use a MongoDB with the HierarchicalUserAccount and custom database samples over here. The current MongoDB driver ditched IQueryable in favor of async/await, so that resulted in some trouble. Since as a result there can be no IQueryable<CustomUser> Queryable, QueryableUserAccountRepository is off the table.
I though of doing it the hard way, however IUserAccountRepository (and fellows) as well don't support the paradigm of returning a Task<CustomUser> instead of a CustomUser. Did I miss something or is there any way around that?
That said, I'm using ASP.NET "vNext" (beta 7).

No plans right now to update this to async/await -- I'm just too busy.

Closing as dup of #568


Add C++ Solution for Problem Of The Day | 23 November 2022

I want to solve this issue.

Hi @akshay290202 ,
You have been assigned this issue! Pull request to contributor branch!

Hi @akshay290202 ,
Since you haven't submitted a pull request and it is the next day, I'm removing you from this issue. However, you can follow my earlier instructions and contribute in the future!


add mesagge from Zambrano to _slides

I change a single line in the slides

I guess I have a typo, it should be: "I changed a single line" not "I change" lol. In any case, the line was changed


suthesh/general-terms-pdf

Changes:

updated general terms pdf file

Type of change

[ ] Bug fix
[ ] New feature
[x] Update feature
[ ] Refactor code
[ ] Translation to code
[ ] Translation to crowdin
[ ] Script configuration
[ ] Improve performance
[ ] Style only
[ ] Dependency update
[ ] Documentation update
[ ] Release

Closing this as it is no longer relevant.


[feature request] output combinatorial results

if I have the prompt {A | B} with {C | D}, I know I need to iterate 2 x 2 = 4 times to get the combinatorial complete result.
But if I have wildcards, I have no idea how many iterations are needed without going into each txt file (and there can be many!) and counting the entries, then doing the math.
It would be nice to either a) have a loop node that totals the combinatorial requirements for a prompt and queues that many to be processed or b) at least a string output/dynamic field somewhere that tells me what the combinatorial result would be.
In the A1111 implimentation, option A is done automatically when "combinatorial mode" is checked, so every iteration is done with a click of a button.

This would be helpful. In A1111 there's a checkbox to iterate through all options. I have to do the math every time I want to iterate in ComfyUI.


Validation Rules Result Screen - valid (EXPOSUREAPP-8031)

This PR addresses EXPOSUREAPP-8031 (validation Result Screen - valid)
PR will be set to DRAFT because Button & Date - Wiring needed after Repo and Screens before this one are completed/merged (see EXPOSUREAPP-7738 for the flow)
Screenshot (scrolled down a little):

@harambasicluka @ChristinaTsigganos
I'd suggest a small text enhancement for the 4th bullet point (even the text might also still be draft):
Ob die im Zertifikat eingetragenen Daten richtig sind, wird von der Corona-Warn-App nicht geprüft.
It's because the first three bullet points deal "with things outside the scope" of CWA. Especially the 3rd point is handling with "a verifier app". Hence, at least for me, the last bullet sounds like the verifier app won't check the contents of the certificate. Adding "von der Corona-Warn-App" clears it up imho, and hopefully all users get it right then...

@harambasicluka @ChristinaTsigganos
I'd suggest a small text enhancement for the 4th bullet point (even the text might also still be draft):
Ob die im Zertifikat eingetragenen Daten richtig sind, wird von der Corona-Warn-App nicht geprüft.
It's because the first three bullet points deal "with things outside the scope" of CWA. Especially the 3rd point is handling with "a verifier app". Hence, at least for me, the last bullet sounds like the verifier app won't check the contents of the certificate. Adding "von der Corona-Warn-App" clears it up imho, and hopefully all users get it right then...
Edit: Or move the 4th bullet to the beginning as first bullet, and write as
Ob die im Zertifikat eingetragenen Daten richtig sind, wird hier nicht geprüft. Then the coherence of the following three bullets fits also well.

Thanks @vaubaehn we are looking into this 👍

@harambasicluka @ChristinaTsigganos
I'd suggest a small text enhancement for the 4th bullet point (even the text might also still be draft):
Ob die im Zertifikat eingetragenen Daten richtig sind, wird von der Corona-Warn-App nicht geprüft.
It's because the first three bullet points deal "with things outside the scope" of CWA. Especially the 3rd point is handling with "a verifier app". Hence, at least for me, the last bullet sounds like the verifier app won't check the contents of the certificate. Adding "von der Corona-Warn-App" clears it up imho, and hopefully all users get it right then...
Edit: Or move the 4th bullet to the beginning as first bullet, and write as
Ob die im Zertifikat eingetragenen Daten richtig sind, wird hier nicht geprüft. Then the coherence of the following three bullets fits also well.

Thanks a lot, @vaubaehn. We checked and decided to consider your first suggestion to add the information  "von der Corona-Warn-App" to the last bullet point. Thanks a lot for your valuable contribution to the CWA.

This PR will probably be closed and replaces by another due new Common-Model (new Base Branch).
Will clean it when its done.
No more review required here.

Follow UP: https://github.com/corona-warn-app/cwa-app-android/pull/3678


how to build

hello i have been trying to build my website using the zzo theme . I followed the guide on the zzo page: https://zzodocs.netlify.com/docs/gettingstarted/quickstart/
when launching hugo server, everything works as expected but when i just run hugo and build the website and click public/index.html there is no theme displayed.just a page saying Example domain.
wha ti would like to do is use the default example site and modify on top of it

I think it may be related to your directory structure and where you run the command

Wow I was having the exact same issue. I don't think the index.html in the root folder is setup or there is some tweaking that still needs to be done (and it is not in the quickstart)
When I deploy the site using hugo -d public, it runs fine locally @ https://localhost/1313
When I deployed in gihub pages, I had to access the site via https://kfrajer.github.io/en/index.html.
Then reading your post made me realized that there is a setting for the url set as default to be "example.com". This is the url in the config.toml file inside the /config/_default folder.

As mentioned above,
It seems you need to set baseURL param in config/_default/config.toml file


New Mode Settings Synonyms Request for Italian

Hi, I would like to have mode_synonyms added for the Mode Setting "Away" for the Italian language: away,assente,in vacanza,in ferie,modalità vacanza,modalità ferie.
Thanks

This was added.

Thank you.


Pledge Grammar corrected

Summary
Pledge Grammar corrected

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@hutchic can you check this out?


excel - set_row check on label length needs factor

Currently the check is based default cell size and not label cell size

merged #1117


Description field missing from LetterEditable class

Summary
The LetterEditable class does not have a description field, as is available in all other Lob SDKs.
Expected Behavior
I should be able to add a description field as part of my letter which will populate the description field on Lob
Current Behavior
There is no description field available.
Possible Solution
Add the description field in, and add it to the SDKs internal API call.
Steps to Reproduce
N/A
Context (Environment)
My company requires me to add descriptions to the letters in order for our OPs team to be able to differentiate them in the portal.

We'll get on this. I'll let you know when we have new release that has this fix.

Also, as an FYI, you can search for metadata attached to your Letters in the searchbox on the Dashboard. If you want even finer results than what the description field can hold.

Ok, so your issue with the description has been fixed up. Take look at the newest version of the SDK https://www.npmjs.com/package/@lob/lob-typescript-sdk.

Awesome! I really appreciate your quick response on this.

I'm getting some errors trying to install the latest version 0.0.6 . Both Yarn and NPM are saying that the package file doesn't exist in their registry, despite it appearing on the npmjs website. Here is the specific NPM error I get:
29103 error 404 Not Found - GET<EMAIL_ADDRESS>29104 error 404
29105 error 404 '<EMAIL_ADDRESS>is not in the npm registry.

Have you been able to download it from NPM on your own machines?

Great, works on my end, thanks for your help! Feel free to close this issue

Glad we could fix this up for you!


Fatal error on outdated xcode

Bug reports:
A recent commit (https://github.com/Homebrew/brew/commit/a124680b189f50ebeb550845e3c0efd34db66247) now causes running an outdated Xcode to raise a fatal error. On Travis CI this results in any image other than xcode8 (presumably) failing. Choosing which version of macOS you get on Travis is based on xcode versioning (see: https://blog.travis-ci.com/2016-09-15-new-default-osx-image-coming/) so this change is problematic.

Just great. Great great great. Fantastic.
Give me a short while.

FWIW I would be fine with having a flag to bypass the check. This would result in breakage for Travis projects, but they'd be able to add --no-xcode-check and proceed, while normal desktop users would continue to receive the fatal error and be asked to upgrade.
Thanks for the quick action @DomT4!

I've just reverted it for now before people start noticing this & I have to deal with 50 unique issues 😕. We'll want to keep the check, but yeah, we'll want to be smarter about it since there's nothing people relying on Travis can do to force Travis to update.
I believe Travis sets TRAVIS or something similar in the environment, so maybe I can sniff that out & skip over when it exists.

They do (https://docs.travis-ci.com/user/environment-variables/#Default-Environment-Variables), although I'd personally prefer a flag rather than it trying to sniff the env. I completely understand why you may not want to go that route due to the avalanche of bug reports you'd receive, although maybe that can be mitigated by using the env detection to just print a message suggesting that they add the flag?
Either way, I appreciate the hard work you do here! 👍

I'd rather people never need to worry about brew (plus people can't read), so I'd vote for env var detection, although that means only the most popular service(s) get special treatment.

I'll probably re-add it with a couching that allows TRAVIS and HOMEBREW_DEVELOPER to not suffer fatal failures on this. That's maybe not a bad compromise.
Given we soft-fail if you try to force link OpenSSL and almost nobody seems to have noticed or tweaked their Travis builds accordingly I'd take a rough guess that a lot of people aren't regularly reading the logs particularly deeply.

Given we soft-fail if you try to force link OpenSSL

That one definitely broke SO though, lol.

https://github.com/Homebrew/brew/pull/1097

@DomT4 Hey, sorry for commenting on a closed issue, but I think this may need a slightly more complex solution. We're having similar problems over at CircleCI, and can't force users to upgrade their formulae or Xcode versions.
A potential solution would be the discussed explicit --no-xcode-check, or adding a generic CI env var check, but this could break users local workflows (Especially for Swift Formulae that may not work on latest Xcode yet, like SwiftLint).
I'm more than happy to contribute a PR for this, but I'm not sure which approach the team would rather see.

@DanToml Do you set an env in the same way Travis does by any chance? I might just scope this to 10.12 temporarily until we can iron this out a bit more 😕.
The primary point of the change was to stop 10.12 users running Xcode 7.x, which flat out breaks almost everything on 10.12 in fun and interesting ways, so if we have to tone it down a touch whilst considering how to move forwards I can live with that.

@DomT4 Yeah, we set CIRCLECI and CI to true on every build.
Yeah I've seen some pretty weird issues from people running 7.x on 10.12 with some of my repos, but also the same types of issue with Xcode 8.0 running on 10.11 for more complex dependencies.
I threw up a branch with a check for our env for a quick test https://github.com/DanToml/brew/tree/dani_circleci_xcode_version, but can PR a toned down check now.

@DomT4 FYI Travis sets CI as well, so you could just use that instead of both TRAVIS and CIRCLECI`.

Give me a sec, I'll push something directly to solve the problem. We protect our master branch but I can turn it off temporarily. Otherwise you'll be waiting 40+ minutes for a solution as our CI tests on core code are fairly extensive and our CI resources fairly limited.

Double opt-out in https://github.com/Homebrew/brew/commit/12aad5c65fee39c5f044e39ca1efcbed58aebd39. If you're running ENV["CI"] anywhere you won't get nagged at, even if you're running Sierra. If you're running any OS X version prior to Sierra you won't get nagged at. If you're running Sierra and your installed development tools are outdated and you're not a robot, you'll get nagged at 😄.
Hopefully that's a decent short-term compromise until we can iron out the kinks in a way that works for everyone.

@DomT4 💖 thanks for this!

Hi,
@DomT4 Since a recent brew update, I am running into the reported error.

Error: Your Xcode (6.4) is outdated
Please update to Xcode 8.0.

My environment is El Capitan (OS X 10.11), I tried updating brew just now, without success. I also reinstalled it (just to make sure).
 ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/uninstall)"
/usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"

Without any more success.
From your latest comment:

If you're running any OS X version prior to Sierra you won't get nagged at.
I understood that and up-to-date version of brew should not raise this error anymore. Is there something obvious I missed ?

Thank you for reading

@Adnn

It thus seems an up-to-date version of brew on El Capitan should not raise this error anymore. Is there something obvious I missed ?

Only if you're on the master branch. But apparently you're on the 1.0.3 branch, and you should wait for the 1.0.4 release.
In the meantime the workaround is export TRAVIS=1, but seriously, Xcode 6.4 on El Capitan? We can't guarantee that won't be blocked again in the near future. No way are we going to support this configuration. Please at least update to Xcode 7.3.

@zmwangx Thank you for the workaround, it works!
Then, Xcode 6.4 ships with llvm 3.6 based compiler. Appart from Boost, not so many projects are C++ enough to go beyond the limit of this compiler ;)

@Adnn A major Xcode release is much more than better coverage of newer C++ specs (think about Swift for a very basic example). Keep in mind that if you run into problems with Xcode 6.4 we cannot provide support for you, and we may block Xcode 6.4 on El Capitan in the future.

Yeah. I tweaked the change, which will land in the next tag which likely won't be too long, but realistically at some point in the future we will likely be enforcing a minimum supported Xcode version, which for 10.11 is likely to be 7.2.1 or such rather than 8.0.
This offers people some flexibility but also will quite drastically reduce the level of bugs users see & the level of bugs our reply has to be "Upgrade your Xcode" to. We have diagnostic warnings in place already, but too many people ignore them and it creates unnecessary hassle for them & increases the maintenance burden on us not insignificantly.


Bad flash from Linux

Prerequisites
Please check the following before posting an issue / bug report.

[x] I am running the latest version of the firmware found HERE
[x] I have checked the documentation HERE and found no answer
[x] I checked to make sure that this issue has not already been filed HERE
[x] I am reporting the issue to the correct repository

Context
Please provide all relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Firmware Version: 0.7.3
Name of device: Flatbox rev 5
Link to where you purchased the device: Built from various parts myself following the guide
Is this a custom build?: Yes
Operating System: Guix System GNU/Linux
Browser: Qutebrowser

Expected Behavior

mount microcontroller in bootsel mode
copy .uf2 file to storage
unmount
controller works

Current Behavior

mount mcu in bootsel mode
copy .uf2 file to storage
unmount
controller does not work, can't get web configurator or bootsel shortcut to work on GNU/Linux or macOS after flashing

Steps to Reproduce
Please provide detailed steps for reproducing the issue.

Hold Start+Select+Up and insert cable connecting to computer
sudo tail /var/log/messages, note /dev/sdX used by new drive
sudo mount /dev/sdc1 /mnt/usb -o umask=000 (allows non-root users to write to the drive)
ranger /mnt/usb ~/Downloads
find .uf2 file, yy to copy, tab back to /mnt/usb, pp to paste
sudo umount /dev/sdc

I was going to try redoing it with rsync in case something was weird with ranger but haven't been able to get it to show up as storage again so far. Going to test on a Windows PC in a bit as I tend to have better luck flashing there for whatever reason. I have flashed many versions of GP2040-CE before to this and other Flatboxes but at some point it stopped working from my main machine for some reason. I don't have auto mount/unmount like I would on the Windows PC so I wonder if something weird is happening with that. Maybe some sync operation is happening that actually causes issues when I unmount.

Is there a reason you don't just cp the file?

I unscrewed the case to get at BOOTSEL directly and was able to flash it with Windows after that.
I have a one-liner in my shell history to mount sdc1 and open those commonly used dirs in ranger, so it's just more convenient that way. I'd probably use rsync over cp otherwise as it's more reliable and can resume interrupted transfers and such, but maybe cp would be fine here.

cp simply works is my point. ranger and/or rsync might do something unexpected by BOOTSEL. for example the RP2040 reboots once writing is "over", so resuming an interrupted transfer wouldn't be possible anyway, and it probably doesn't like e.g. temp files.
In any event, we are not reaponsible for the BOOTSEL mode anyway (rather it's a core RP2040 boot ROM thing), so if it does something odd, there's nothing we can do.

Yeah, this is maybe more of a Pico problem, but I thought someone here might have experience with this, and now next time it happens to someone, they'll hopefully find this issue. I will test updating a different Flatbox with cp later and report back.

Sounds good. If you do have advanced use cases beyond cp, there is always picotool, or what I've been working on in https://github.com/OpenStickCommunity/gp2040ce-binary-tools

Okay, I upgraded two in a row without issues using cp, so I guess that confirms that. Thank you for the help. Still did manual mount + unmount the same so I guess that wasn't the problem. Closing the issue now.


memory raise rapidly while my dataSourceName is invalid

memory raise rapidly while my dataSourceName is invalid,but no problems when my dataSourceName is correct
I use the same code pattern in my mysql project using "github.com/go-sql-driver/mysql",and no such problem
following is my testing code

package main

import (
	"database/sql"
	"net/http"
	_ "net/http/pprof"

	"github.com/prometheus/common/log"
	_ "gopkg.in/rana/ora.v4"
)

func main() {
	connStr := `system/oracle@(DESCRIPTION=(ADDRESS_LIST=(ADDRESS=(PROTOCOL=TCP)(HOST=<IP_ADDRESS>)(PORT=1521)))(CONNECT_DATA=(sid=xe)))`
	db, _ := sql.Open("ora", connStr)
	defer db.Close()
	http.HandleFunc("/", func(writer http.ResponseWriter, request *http.Request) {
		if err := db.Ping(); err != nil {
			log.Errorln(err)
		}
	})
	http.ListenAndServe(":9103", nil)
}

Just check your errors, as everywhere, everytime - or take the consequences.

But how can I prevent it just through check errors

In your example you skip checking  the error returned by sql.Open.
You have to check and handle it:
import "github.com/pkg/errors"

...

db, err := sql.Open("ora", connStr)
if err != nil {
    log.Fatal(errors.Wrap(err, connStr))
}

Thank you for your patience
but just like i said, nil error returns in sql.Open, I saw it in my previous sample which is different from
the list one
Do you mean even if the sql.Open returns non-nil error, as long as my dataSourceName is incorrect ,everytime I try to Ping it will open a new connection, but Pings will share one connection when the dataSourceName is correct

Yes. database/sql.Open returns a connection pool, which reuses connections as possible, but opens new connections when required - for example if there's no successful connections, it will open a new one - for each ping, or each use in case of bad connStr.

😩  crying...
Is there any way to release the memory caused by connections with bad connStr except restarting my main process  ? ?

Have you tried db.Close ?
I mean, Ping the new connStr, and Close on error.

Hi, @tgulacsi the db close is already used. and we test the code with mysql driver and no memory leak occur

Can you tweak TestOpenBadMemoryIssue207 in z_environment_test.go at e52c26d to reproduce the issue?

Thanks
Here is my running test based on z_environment_text.go
--- FAIL: TestOpenBadMemoryIssue207 (0.04s)
z_environment_test.go:21: Allocated 0: 121856
z_environment_test.go:32: Allocated 1: 122448
z_environment_test.go:32: Allocated 2: 123264
z_environment_test.go:32: Allocated 3: 124256
z_environment_test.go:32: Allocated 4: 125024
z_environment_test.go:32: Allocated 5: 125632
...
z_environment_test.go:32: Allocated 95: 159872
z_environment_test.go:32: Allocated 96: 159872
z_environment_test.go:32: Allocated 97: 160224
z_environment_test.go:32: Allocated 98: 159520
z_environment_test.go:32: Allocated 99: 159872
z_environment_test.go:32: Allocated 100: 159872
z_environment_test.go:35: atlast: 38016
z_environment_test.go:37: Consumed more than 32KiB of memory: 38016
FAIL
FAIL	command-line-arguments	0.053s
But I till don't know the relationship between this test and my issue, what I care is that memory stay high even if I tried db.Close after  pinging the bad connStr

I don't know your issue in detail, that's why I presented a test (skeleton), and asked you to fill in whatever you want, to reproduce your problem.
Open & Close is not enough - I've added a Ping, but that locked me out, so I had to modify the test to alter the user name, too.
That's because you haven't detailed what kind of connection string you're using which is "bad".
Please see 95d4c1f and try again!
The questions we need to answer:

can your memory problem be inspected with runtime.ReadMemStats, or just by "top" ?
Is Open, Ping, Close enough to enforce the error?
how much memory is leaking by each cycle?

Here is the final str to open, I picked a wrong sid
system/oracle@(DESCRIPTION=(ADDRESS_LIST=(ADDRESS=(PROTOCOL=TCP)(HOST=<IP_ADDRESS>)(PORT=1521)))(CONNECT_DATA=(sid=x)))
following is the testing log, It seems nothing weird
--- FAIL: TestOpenBadMemoryIssue207 (0.25s)
z_environment_test.go:21: Allocated 0: 122272
z_environment_test.go:30: Env.OpenCon Env.OpenSrv Env.ociError ORA-12505: TNS:listener does not currently know of SID given in connect descriptor

z_environment_test.go:35: Allocated 1: 123456
z_environment_test.go:30: Env.OpenCon Env.OpenSrv Env.ociError ORA-12505: TNS:listener does not currently know of SID given in connect descriptor

z_environment_test.go:35: Allocated 2: 124512
z_environment_test.go:30: Env.OpenCon Env.OpenSrv Env.ociError ORA-12505: TNS:listener does not currently know of SID given in connect descriptor

z_environment_test.go:35: Allocated 3: 125536
z_environment_test.go:30: Env.OpenCon Env.OpenSrv Env.ociError ORA-12505: TNS:listener does not currently know of SID given in connect descriptor

   . . . .

z_environment_test.go:35: Allocated 98: 180960
z_environment_test.go:30: Env.OpenCon Env.OpenSrv Env.ociError ORA-12505: TNS:listener does not currently know of SID given in connect descriptor

z_environment_test.go:35: Allocated 99: 181024
z_environment_test.go:30: Env.OpenCon Env.OpenSrv Env.ociError ORA-12505: TNS:listener does not currently know of SID given in connect descriptor

z_environment_test.go:35: Allocated 100: 181792
z_environment_test.go:38: atlast: 59520
z_environment_test.go:40: Consumed more than 32KiB of memory: 59520

FAIL
FAIL	command-line-arguments	0.270s

Here is the thing, when I use top command to watch the res of this process, it raised 0.1-0.3m each Open-Ping-Close circle.

Can you try & post the results of
go test -c && /usr/bin/time ora.v4.test -run=Issue207 -test.v

both with 95d4c1f and a3970f1 ?
In the latter I've tried to free all allocated OCI handles on error in OpenSrv (env.go)

Hi dude !!!!
I both use 95d4c1f and a3970f1.  95d4c1f won't help, res stay going high. But when I use  a3970f1 , I  found that res memory just raise a little at the begain of my bad connStr test, and stay stable after that, thinking my issue is resolved in  a3970f1.
I will add more test case to ensure there is no more hidden trouble, once I found it, I will come here again..
Thanks..

I've released it as v4.1.10.


Failed validation exists with 0

A failed validation of an openair file exists with an exit code of 0 when it should exit with 1
This would help integrate an automated validation in a github workflow for instance

I'm currently looking into this any I'm trying to understand the exact use case here. The current parser behavior is to throw a validation error and give information on the found (mostly geometry related) issues, if one or more airspaces are invalid. To have this behavior, the config parameters must be set the following:

validateGeometry: true
fixGeometry: false

From what I understand this is wht you are looking for or did I get it wrong? If so, can you explain your exact use-case / what you are trying to achieve?

Hi
I'm using the program inside a github action (shell script) to validate the change that has just been pushed inside an airspace file.
Currently I'm doing this:
node ./cli.js -f ../france.txt -V -o delete_me.geojson
Regardless of the validation success or error, the program ends with the exit code 0.
So I can't just just check for $? in order to find out if the validation was ok or not: I have to check the output for a the keyword "Error" in order to find out if the validation was successful or not.
It would be better if the program exit code was following the convention of returning 0 if successful, and a value >0 if not.

I adjusted the CLI script accordingly. Should now work for your use-case. Fixed in v1.10.0.

Please note the changed default behavior of the CLI script options. They are all set to "false" now by default.

OK, I've just given it a try, it's now exiting with the correct exit code, but it looks like it's not printing anything on the output anymore ?
I think it's still usefull to know why validation failed or have the information it used to display...

use it with the debug flag -D. does this work?Am 12.11.2022 um 17:51 schrieb Ludovic @.***>:
OK, I've just given it a try, it's now exiting with the correct exit code, but it looks like it's not printing anything on the output anymore ?
I think it's still usefull to know why validation failed or have the information it used to display...
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: @.***>

Yes...it's' fine now, sorry I didn't see the --debug option.
Thanks !


gopls: need a theory of URls

Recently we finally got rid of almost everything in the golang.org/x/tools/gopls/internal/span package. Only span.URI remains, and I would like to get rid of it too, either by deleting it, moving it to a sensible location, or fusing it with something else. The question is: what does the span.URI abstraction represent? The disappointing current answer is: "just a URI"; it needn't be a "file:" URI, nor need it be non-empty. Calling URI.Filename on an invalid or non-file-scheme span.URI panics.
The protocol.DocumentURI type represents a URI of an editor document. In practice it is always a "file:" scheme URI (though this isn't required by the LSP docs). However, according to those docs, it may be URL-encoded, so colons in Windows drive letters do not appear literally, and there is evidence in the code that it may contain "file://" URIs with only 2 slashes (not 3, and no hostname). So, there is a logical need to convert DocumentURIs as they arrive in requests into some kind of processed internal form, such as span.URI, and this operation is fallible, so its errors must be handled.
This suggests that we should retain the distinction between URI types and audit the codebase (possibly with the help of a static analysis in the style of the safetoken tests) for conversions of DocumentURI to span.URI without validation. Should span.URI, renamed to something suitable like protocol.FileURI, be made stricter about the invariant that it represents a valid "file:" URL? It's a large change, and the status quo doesn't currently cause any obvious problems, but currently there is little rhyme or reason to when we validate DocumentURIs.
@findleyr

A few little helpers (like filepath.Dir and Base and Join) for URLs would also go a long way to avoiding the need for conversions.

Yes, this has come up in the past (I thought we had an issue for a 'uripath' library). (Aside: I suppose it's not fair to say "this has come up in the past", because it feels like everything has come up in the past!).
It's a good idea. I just never had the patience to convince myself of the algorithmic correctness.

A few little helpers (like filepath.Dir and Base and Join) for URLs would also go a long way to avoiding the need for conversions.

Yes, this has come up in the past (I thought we had an issue for a 'uripath' library). (Aside: I suppose it's not fair to say "this has come up in the past", because it feels like everything has come up in the past!).
It's a good idea. I just never had the patience to convince myself of the algorithmic correctness.

The implementations can convert to and from strings and call filepath, just like we do today. At least it'll centralize any existing bugs in one place.

See also #32456.


Write-DbaDataTable iterating row by row; not inserting input as a set

Verified issue does not already exist?
Yes
What error did you receive?
No Error, but poor INSERT performance. Instead of inserting the input as a set, it is inserting to the target table row by row. This can be verified with a SQL trace, and running a count on the target table while the PS1 script executes.
I first found this with dbatools version 1.0.164, but also repro'd with version 1.1.6.
RABR_POC.ps1.txt
Get-DBAToolsLog.txt
Sorry, not including New-DbatoolsSupportPackage - I don't have the wherewithal to scrub this output.
Steps to Reproduce
# provide your command(s) executed pertaining to dbatools
# please include variable values (redacted or fake if needed) for reference

Set up a target SQL server database.

set up this query if you want to run COUNT while the script runs:
SELECT COUNT(*)
FROM dbo.RowByRow_POC WITH (NOLOCK)
Set up a SQL trace if you like.

Clean up the extension of the attached ps1 script.

Run it.  This script tries two different syntax schemes. Both insert one record at a time

Are you running the latest release?
Yes
Other details or mentions
No response
What PowerShell host was used when producing this error
Windows PowerShell ISE (powershell_ise.exe)
PowerShell Host Version
$PSVersionTable
Name                           Value

PSVersion                      5.1.19041.610
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.610
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
SQL Server Edition and Build number
Microsoft SQL Server 2017 (RTM-CU25) (KB5003830) - 14.0.3401.7 (X64)   Jun 25 2021 14:02:48   Copyright (C) 2017 Microsoft Corporation  Standard Edition (64-bit) on Windows Server 2016 Datacenter 10.0  (Build 14393: ) (Hypervisor)

Hey Ken,
Thanks for taking the time to file this issue. I noticed that you used AutoCreateTable which uses varchar(max) galore. Here's ah example for piping Get-ChildItem -File

This ensures you can write with no issue but is really slow. Nevertheless, I'll take a look to see what could be the problem.

When I run the following with a SQL trace:
Write-DbaDataTable -SqlInstance localhost -Database tempdb -Table files -InputObject $files
I only get two insert bulk hits for 2k rows -- starting and completing.

It is a bit slow to convert to a datatable (before it hits the db) but we've optimized that to the best of our ability.

Thanks for the updates!  I'm aware of the issue with autocreate; in our case we already have the tables instantiated.
What kind of conversion time are you seeing for the marshaling and prep for the insert?  Still, that doesn't get at why we are seeing our process create a bulk insert for each record.
Did the ps1 script I attached work as a single batch for you?

It makes sense that it does it row by row if you pipe it in, we do document that it's convenient but slow. The best way to improve speed is by using -InputObject which you did in the second command. Since the batch size is 50000, I imagine it'll make a bulk insert call every 50k rows.

gonna close this issue as i cannot repro with the recommended method, all others are slow as expected. happy to continue talking about it, however.

Did find a resolution for this in the documentation: https://docs.dbatools.io/Write-DbaDbTableData  example 2.  It show the extraction of the data using Invoke-Query -As DataSet.  To get this to work I set the column names and datatypes delivered by Invoke-Query to match EXACTLY (including case sensitivity of column names) those of the target table.
Thanks for your help with this!


Clean up Adds board saving to localStorage PR

Cleans up #1 a bit

@PersonalPalimpsest Mind checking out this branch and testing it to make sure I didn't break anything?
Thanks!

@bradp thanks for the formatting. I did keep on working on it after your branch as I realized I missed a couple chunks and I fixed a few more bugs with creating almost-duplicate logs in the meantime as well.
Think it would be best to merge this PR in first and then I can figure out where my new stuff slots in, hopefully with minimal formatting changes needed.

Going to work on a simple display of the stored data as well, that way it doesn't require someone having to grab it out of local storage. 👍


KNOX-931:asType will not work for body filter when using IdentityAsse…

…rterFilter

Closing since file related changes don't match PR title.


Fix focus and blur events emission

/cc @Tyriar could you please take a look at this PR and make a brief test? I removed the debounceRefresh method and embedded its functionality straight into refresh. CPU usage should still not be going crazy with huge streams of data.

It seems to perform around the same, my main test for this was that selection of the h1 was still smooth while ls -lR /usr/share ran. It's still pretty slow in vscode, refresh seems to still 100% CPU, this happened before and after this change though.
Before:

After:


devcontainer rebuild fail after upgrade to vscode 1.91.0

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.91.0
OS Version: Sonoma 14.4.1

Steps to Reproduce:

Rebuild Devcontainer

If I remove the contents of customizations.vscode.extensions array in devcontainer.json - it works

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.91.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

I use 1.91.0

Continuing in https://github.com/microsoft/vscode-remote-release/issues/10029


Switched to manual code signing

Changes

JIRA Ticket
@VerizonAdPlatforms/mobile-sdk-developers: Please review.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Replace README.md with an archival announcement.

cc @hicksjoseph

Thanks for handling this!

Actually, I just realize that I should go through AOSP for this, too. Closing this in favor of https://android-review.googlesource.com/c/platform/build/blueprint/+/1655694/ .


Custom Error Logging

Description
Implement the functionality of custom errors for frontend.

hey @DhairyaBahl can you please assign this issue to me?

Can I work on it @DhairyaBahl . And I need some pointers on it as well


Create Event “dt/list-2023/test”

Automatically generated by Netlify CMS

👷 Deploy Preview for 9fukops processing.

Name
Link

🔨 Latest commit
ba89fdcd6dbf44ddb361cb24a48ee3cf49c7f8b3

🔍 Latest deploy log
https://app.netlify.com/sites/9fukops/deploys/64a082c30e4ef5000800c166


'Test' button produces error when validating Fluentd logging endpoint settings

rancher/rancher:master 5d74988c

Create a fluentd server
Configure fluentd endpoint for cluster logging
Click Test

Error returns:
couldn't read data from fluentd forwarder <server:port>: read data timeout

The test statement does show correctly in fluentd server:
2019-05-08 18:23:01.000000000 +0000 rancher: {"message":"Rancher logging target setting validated"}

After saving, logging functions normally -- logs are forwarded and viewable from fluentd.

rancher/rancher:master-head bad6400a

Deploy Fluentd server configured for forwarding
Deploy Rancher
Create Cluster
Configure Fluentd logging endpoint
Test button works without error
Test statement seen in Fluentd logs


Fix more gulp.dests to use the relative path of the tsconfig instead of .

gulp runtests-parallel was broken because a few of these were missed last time in #14384.

(Thanks for finding the ref.)


Set-Location preserves case instead of matching filesystem on case-insensitive/preserving system

Steps to reproduce
mkdir Foo
cd foo

Expected behavior
    Working directory ends in `\Foo`.

Actual behavior
    Working directory ends in `\foo`. (note the difference in case)

Remarks
I originally thought this issue belonged with #1273, but that is about tab completion and globbing on non-Windows platforms, whereas this does not involve tabbing or globbing, and is on Windows.
This problem can cause problems with git and other things.
If I use cmd.exe instead, it gives the expected/desired results.
On case-sensitive systems, I don't know what the correct behavior should be (reject it if the path doesn't exist, or automagically switch to the fs-matching case)... perhaps it should be controlled by the same settings as in #1273.
Environment data
PS C:\Users\danthom> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.17047.1000
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.17047.1000
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Unfortunately, this has turned out to be much more complicated than I anticipated.  [DirectoryInfo]::GetFiles() and GetDirectories() aren't working correctly on macOS.  I'll need to open a issue for corefx.

DotNet Issue was closed without resolution. :confused:

Maybe we need to follow C# as discussed in #6833 and develop language means for creating portable scripts.

@jazzdelightsme:

On case-sensitive systems, I don't know what the correct behavior should be (reject it if the path doesn't exist, or automagically switch to the fs-matching case)...

There's at least one case in which the path should be rejected:
If there's ambiguity due to the presence of more than 1 case-variant folder: e.g, if you specify test and both TEST and Test exist.
If there is no ambiguity - just 1 case-variant match - I suppose targeting that automatically is an option, but note that for consistency we'd then have to implement the same logic wherever file/directory paths are accepted, such as Get-Content.
I suspect that that behavior would ultimately be too obscure and I suggest we keep a clean separation between:

literal names that must be case-exact on case-sensitive filesystems.

(possibly opt-in) case-insensitive tab-completion and wildcard matching, where ambiguity can be resolved by cycling through / returning multiple matches.

As for the issue at hand:
macOS:
https://github.com/dotnet/corefx/issues/26797 is indeed resolved, but the issue at hand persists, and it is PowerShell that is the culprit (in the following examples, a Test directory is created, and it is accessed via its all-lowercase variant, test):
PS> mkdir -p /tmp/Test; Set-Location /tmp/test; $PWD.Path
/tmp/test # !! *input* case was preserved, even though the actual name is a case variant

Using .NET Core does NOT exhibit this behavior:
PS> mkdir -p /tmp/Test; [Environment]::CurrentDirectory = '/tmp/test'; [Environment]::CurrentDirectory
/private/tmp/Test  # OK: actual dir. name is reflected in the last path component

(Note that /tmp is a symlink to /private/tmp on macOS.)
Windows:
Unlike on macOS, it is .NET itself and, I suspect, ultimately the Windows API that behaves this way, so if we want to fix this behavior, we'll have to do it in PowerShell (as cmd.exe apparently does):
PS> $null = mkdir -Force $env:TEMP\Test; [Environment]::CurrentDirectory = "$env:TEMP\test"; [Environment]::CurrentDirectory
C:\Users\jdoe\AppData\Local\Temp\test  # !! *input* case was preserved.

Note that the behavior doesn't just affect Set-Location (cd), but also other cmdlets such as Get-Item.

@mklement0 Thanks! I agree that it is PowerShell issue.
Perhaps we should ask a more general question -see #1273 and #7221 last comment) - how much should we be case-sensitive/-insensitive on every platform?

on Windows, API preserves case but all comparisions is case-insensitive. PowerShell follow this.
on MacOs, API preserves case but all comparisions is case-insensitive. Currently PowerShell doesn't follow this. Bug? Should? I think yes.
on Linux, API preserves case and all comparisions is case-sensitive. PowerShell follow this. Here is the quesion - how much should we be case-sensitive on Linux taking #1273 into consideration? Perhaps we could be case-insensitive on Linux in other scenarios too.
For example, if a user accidentally types dir /Etc we could test that /Etc doesn't exists and then try /etc - is the behavior acceptable for Linux users? If yes, we could easily resolve the Issue and  #1273 in that way I suggested in  #7221.

@iSazonov: Please see https://github.com/PowerShell/PowerShell/issues/5678#issuecomment-418155458 above.
In short:

I think literal names should never be automatically case-corrected on case-sensitive filesystems, to avoid ambiguity.

It makes sense to offer case-insensitivity for (a) tab-completion and (b) filename globbing, but it I wonder if it should require an explicit opt-in (perhaps via preference variables), at least for globbing.

Otherwise, users may be surprised if Get-Item test doesn't find .\Test, but Get-Item test* does, for instance.

For ad-hoc use (as well as for internal use in generating completions), adding a -CaseInsensitive switch to Resolve-Path does make sense.

That said, as stated in https://github.com/PowerShell/PowerShell/issues/1273#issuecomment-324398879, the tricky thing is that a preference variable that controls globbing case-sensitivity, if set in the global scope, would potentially change the behavior of all scripts run in-process, unless they explicit set the preference variable to the default in their scope.
Given that, perhaps the answer is to:

categorically use case-insensitive globbing (and tab-completion) on all platforms, even on Linux.

offer case-sensitive globbing, if desired, only:

via the filesystem provider's -Filter parameter (though that could be confusing)
via a -CaseSensitive (sic) switch added to Resolve-Path - for consistency, that switch would then have to be honored on Windows and macOS too, however (just documenting it as being ignored on these platform may not be enough to avoid confusion).

categorically use case-insensitive globbing (and tab-completion)

I agree with tab-completion but globbing - I think users will be surprised that Copy-Item -Path $env:TEMP\T* will copy $env:TEMP\test on Linux.

There ultimately is no good solution here, but what appeals to me about the latter solution is its simplicity:

As a user, all you need to remember is that PowerShell wildcards are case-insensitive everywhere by default.

Getting case-sensitive filename globbing, if needed (probably rarely), must be requested explicitly with -Resolve-Path -CaseSensitive and perhaps also the filesystem provider's -Filter parameter.

I'm starting to think that the latter is not a good idea, though: on the one hand, there already are differences between -Filter and PS wildcards on Windows, but they are subtle and don't affect the majority use cases; on the other hand, -Filter is often used for performance reasons alone, and having it be case-sensitive is then an inconvenience at best, and a subtle source of bugs at worst.

No new preference variables and therefore no associated issues with global state ("convention over configuration").

Obviously, the behavior would need documenting in about_wildcards.


Add getter functions to SendPacket, ReceivePacket, WriteAcknowledgement, AcknowledgePacket, TimeoutPacket to get the elements of the structure

Summary

Problem Definition

Proposal

Acceptance Criteria

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate milestone (priority) applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

assign to me


Make extractors usable on their own

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/20
Originally created by @joshlambert on 2018-06-25 16:54:40

We discussed this in the past, but opted to not do this due to the increased complexity of adding capabilities for which we do not immediately need: databases other than Postgres, splitting the extractors into separate projects, etc.
Now that we have more engineering resources on board, and have addressed the near term nears of our internal data team, I think we should revisit this topic for a few reasons:

Each of these extractors has their own value, and could generate interest on their own. For example, a good SFDC, Zuora, or Netsuite extractor would be useful for the broader community.
It will take some time for us to really make the full meltano experience great, end to end.
While that is work is being done, we could start generating interest and critical mass with just the extractors themselves.
Right now however, there are a few major hurdles in driving usage of these extractors:

Our extractors only output to Postgres. There is no support for exporting to a file, or any other database type. If your EDW runs on bigquery, we can't help you.
There is no SEO for the individual extractors. If you google for "sfdc extract", you aren't going to get a good hit based on the full Meltano readme.
Further, the extractors aren't easily usable on their own. It's expected that they are used in the context of the full project. For example, there is no canned image, instead they are pulled down with a git checkout.
We currently operate as a monorepo, and it is not user friendly to work on these in isolation. Our issues, MR's, README's, etc. all cover a broader scope than the simple sharp tool of extracting from a source.

There are some downsides:

There will be some work to really "productize" these individually, if we are going with our own system.

We should accelerate the output to an intermediate format for the extractors, so we can support multiple storage engines. (PG, MySQL, Bigquery, Redshift, Snowflake, etc.) We can then build individual loaders for these.
We will need to rework the pipelines, to build a final image for each extractor. Then update the main CI pipeline.

This work may delay down the effort to productize the full meltano project, for example building the data mapping feature.

View 38 previous comments from the original issue on GitLab


Bug: TextNode in Token mode gets split when format is changed on portion of its text

Lexical version: 0.9.0
Steps To Reproduce

Open a modified MentionsPlugin example that simply uses RichTextEditor instead of PlainTextEditor
Create a mention node by entering @Ham and selecting @Hammerhead.
Select a portion of the newly created node (e.g. mer), press Cmd/Ctrl+B to bold the selected text
Observe that the node that's supposed to be a token gets incorrectly split into multiple nodes

Link to code example:
https://codesandbox.io/s/purple-river-pmc11v

The current behavior
Applying format to a range selection does not respect boundaries of text nodes in token mode.

The expected behavior
RangeSelection's formatText method (and likely other methods) should not invoke splitText on "token" text nodes.

Good one. I guess the expected behavior here would be for the formatting operation to fail? What do you think?

So since the node is supposed to be treated as a token, it feels like anything that happens to a portion of the node should happen to the entire node.
I feel like ideally that would translate to the whole node getting selected when any portion of the node is selected.  Basically I think of a token node like I would think of a ligature - it's an atomic thing, so it's weird to be able to select a portion of it.
If extending the selection is not practical for some reason, I think the next best thing would be to format the entire node when a portion of the node is formatted. Seems reasonable to assume that's what the user would intend...

I think it should fail, if you select a row of text that has a hashtag or mention node, you probably want the node to fit a specific style to indicate it's not normal text and not be bolded/italicized/etc. Maybe I'm wrong, but I don't think it's expected to be able to change such a node besides maybe its font size.

I've noticed that TextNodes in Token mode also get split with the insertion of newlines. Ideally, I believe the whole node should be replaced by a newline instead. Could this be considered as part of the fix for this issue?

This is still an issue with the latest versions of Lexical. Here is an updated sandbox link.
https://codesandbox.io/s/affectionate-microservice-r5r38c

@Maxim1saev unfortunately couldn't figure out how to make it work using text nodes.  We ended up using decorator nodes instead & writing custom (de)serializers.

@9still
and how did you get a text node to calculate its format? Deserializers for json ? That is, have you taught the decorator node to include formatting and apply it to the entire text with partial selection?


Metaclass and slots

Hello,
Thank you for this wonderful project! It totally changed (for the best) the way I write Python.
I'd like to make the following meta-class example work but I run into a RecursionError.
class MetaFoo(type):
    def __new__(cls, name, bases, attrs):
        klass = super().__new__(cls, name, bases, attrs)
        return attr.s(frozen=True, slots=True)(klass)

class Foo(metaclass=MetaFoo):
    def foo(self): ...

And then inherit from this:
class Bar(Foo):
    a = attr.ib()

However I run into the following error and have a hard time solving it. The error disappears when I disable slots. Running python 3.7 on macOs (Homebrew) and attrs (18.2.0).
I know attrs is not about metaclasses, so I would be grateful if you have the time to have a look at it.
---------------------------------------------------------------------------
RecursionError                            Traceback (most recent call last)
<ipython-input-22-7a3660d0a3d8> in <module>
      6         return attr.s(frozen=True, slots=True)(klass)
      7
----> 8 class Foo(metaclass=MetaFoo):
      9     def foo(self): ...

<ipython-input-22-7a3660d0a3d8> in __new__(cls, name, bases, attrs)
      4     def __new__(cls, name, bases, attrs):
      5         klass = super().__new__(cls, name, bases, attrs)
----> 6         return attr.s(frozen=True, slots=True)(klass)
      7
      8 class Foo(metaclass=MetaFoo):

/usr/local/lib/python3.7/site-packages/attr/_make.py in wrap(cls)
    895                 )
    896
--> 897         return builder.build_class()
    898
    899     # maybe_cls's type depends on the usage of the decorator.  It's a class

/usr/local/lib/python3.7/site-packages/attr/_make.py in build_class(self)
    501         """
    502         if self._slots is True:
--> 503             return self._create_slots_class()
    504         else:
    505             return self._patch_original_class()

/usr/local/lib/python3.7/site-packages/attr/_make.py in _create_slots_class(self)
    596
    597         # Create new class based on old class and our methods.
--> 598         cls = type(self._cls)(self._cls.__name__, self._cls.__bases__, cd)
    599
    600         # The following is a fix for

... last 4 frames repeated, from the frame below ...

<ipython-input-22-7a3660d0a3d8> in __new__(cls, name, bases, attrs)
      4     def __new__(cls, name, bases, attrs):
      5         klass = super().__new__(cls, name, bases, attrs)
----> 6         return attr.s(frozen=True, slots=True)(klass)
      7
      8 class Foo(metaclass=MetaFoo):

RecursionError: maximum recursion depth exceeded while calling a Python object

This is a bit late but if others are having the same issue, @AntoinePrv 's original code is technically correct. If you use
super().__new__(type, name, bases, attrs)

the resulting class will have the type metaclass rather than your custom metaclass. This means that the resulting class will not have any of your custom metaclass behaviors and __new__ will not be called on further subclasses.
class meta(type):
    def __new__(cls, name, bases, attrs):
        print("custom __new__ called")
        return super().__new__(type, name, bases, attrs)

class A(metaclass=meta):
    pass

# prints: custom __new__ called

class B(A):
    pass

# nothing prints

The reason for the RecursionError is that slotted attrs need to recreate the class and so recalls the metaclasse's __new__ method. This leads to the code essentially doing something like this:
def make_slotted_attrs():
    make_new_class()

def make_new_class():
    make_slotted_attrs()

make_new_class()

The best solution I have found is to add an if statement that detects if the class has already been modified by attrs
class meta(type):
    def __new__(cls, name, bases, attrs):
        print("custom __new__ called")
        if "__attrs_attrs__" in attrs:  # already modified by attrs so do not reapply
            print("already attrs")
            return super().__new__(cls, name, bases, attrs)
        else:  # not modified by attrs yet
            # add code here
            print("applying attrs")
            new_class = super().__new__(cls, name, bases, attrs)
            return define(new_class)

class A(metaclass=meta):
    pass

# prints: custom __new__ called
# prints: applying attrs
# prints: custom __new__ called
# prints: already attrs

class B(A):
    pass

# prints: custom __new__ called
# prints: applying attrs
# prints: custom __new__ called
# prints: already attrs


executive_smach_tutorials: 0.1.0-0 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository executive_smach_tutorials to 0.1.0-0:

upstream repository: https://github.com/rhaschke/executive_smach_tutorials.git
release repository: https://github.com/tork-a/executive_smach_tutorials-release.git
distro file: indigo/distribution.yaml
bloom version: 0.5.26
previous version for package: null

@rhaschke @spmaniato if you want to release this package from your repository, please let me know. I'll transfer this repo to yours.

if you want to release this package from your repository, please let me know

Nope, you're good @k-okada :+1: Thanks for releasing this :slightly_smiling_face:

Please either get @spmaniato to do the release using the existing repos or give you access to release using the existing gbp, or fork the upstream repo, add yourself explicitly as a maintainer and release the package from the fork.
See https://discourse.ros.org/t/releasing-repositories-form-other-people/1797/10

I'm fine with you, @k-okada, releasing this. I didn't touched that repo for a year...

Please make sure that @k-okada is added as a maintainer (by either adding him, giving him permission to do it himself, or moving the repo into a ROS org unit to make that easy in the future) and reuse the existing release repo (if any).

@rhaschke can you https://github.com/rhaschke/executive_smach_tutorials/pull/2 ? or  give me a permission to do this?
or move to ROS.org unit? as @dirk-thomas suggested? Best


Zend\Mail\Transport\SendMail throws wrong exceptions

It appears that SendMail is pulling exception classes from the wrong namespace.
    public function testWrongExceptionThrown()
    {
        ini_set('SMTP', '256.256.256.256');
        $transport = new Sendmail();

        $msg = new Message();
        $msg->setTo('test@localhost');

        $this->setExpectedException('Zend\Mail\Transport\Exception\RuntimeException');
        $transport->send($msg);
    }

Failed asserting that exception of type "Zend\Mail\Exception\RuntimeException" matches expected exception "Zend\Mail\Transport\Exception\RuntimeException". Message was: "Unable to send mail: mail(): Failed to connect to mailserver at "256.256.256.256" port 25, verify your "SMTP" and "smtp_port" setting in php.ini or use ini_set()" at

This causes issue with the Mail logger writer since its looking for a transport exception:
        // Finally, send the mail.  If an exception occurs, convert it into a
        // warning-level message so we can avoid an exception thrown without a
        // stack frame.
        try {
            $this->transport->send($this->mail);
//this will never be executed if using SendMail
        } catch (TransportException\ExceptionInterface $e) {
            trigger_error(
                "unable to send log entries via email; " .
                "message = {$e->getMessage()}; " .
                "code = {$e->getCode()}; " .
                "exception class = " . get_class($e),
                E_USER_WARNING
            );
        }

Could you send a PR with the fix to zend-mail component? https://github.com/zendframework/zend-mail


feat: Add var.wait_for_cluster_timeout to allow configuring the wait for cluster timeout

PR o'clock
Description
During #1359 a default timeout of 300 seconds was set for this.
We create hundreds of clusters a day and have seen many clusters take longer than 300 seconds.   Our team previously used the wait_for_cluster_cmd (NOTE: This is no longer available in this module) variable to wait 600 seconds.  Sometimes, even 5 minutes isn't even enough.  This PR will make this configurable, so our clusters are more likely to come up by the time we need to apply aws auth.
Resolves #1395
Checklist

[x] README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

@barryib I updated the code. Let me know if it looks better now.
I was not sure of the process, so I resolved the comment issues myself.  I hope that's OK.

Nice. Thanks @SNA-rh for you contribution.

@barryib We're real excited to use this. Any idea when the next release gets cut that'd include it?


fix: handle process[toString] being readonly on newer nodes

Summary
If we do not do this, Jest fails horribly on Node 12 (tested with yesterday's nightly release)

Beyond this failure, the only things that fails are the leak detector tests since weak does not compile on Node 12

Test plan
Green CI (although we don't test node 12 yet, at least avoid regressions)

yeah

This started failing on latest node with the https://nodejs.org/en/blog/release/v11.11.0/ release an hour ago. Getting this error:
    TypeError: Cannot assign to read only property 'Symbol(Symbol.toStringTag)' of object '#<process>'
https://travis-ci.org/msand/react-native-svg-e2e/jobs/502745672
Should v24.2.0-alpha.0 be used for now?

I can confirm this is broken on 10.15.4 too. This needs to be released ASAP since it's now broken on all current versions of node.

@msand I'm getting this error too

☹
You can install jest@beta for now which includes this fix

@SimenB would it be possible to also release a fix for Jest 23? Or is that discontinued now that v24 is out?

Yes, please upgrade to 24. Alternatively, you can probably use a resolution for jest-util if needed.
Why are you blocked from upgrading to 24?

@SimenB thanks for your quick response!
We have built a tool (similar to CRA or Next.js) to allow our teams to easily spin up new projects, but if we were to upgrade to Jest 24 that would be a breaking change for us (at least at a first glance - I haven't had the time yet to look deeper into this) and therefore I have currently put the upgrade on hold (https://github.com/xing/hops/pulls).
But I will try to find some time this week to look into it to see how we could upgrade to Jest 24 ;)

The breaking changes should be clearly noted as such in the readme. And they should be relatively minor. Hopefully you'll have an easy time of it! 🤞


Various updates

Major updates in Markup. Markup uses InkGenerator to generate effect now.
Improvement and bugs fixed in InkGenerator.
Updates in doc.

With this updates, now Markup uses InkGenerator and we will be able to generate Markup effect by using different inks, for example:
crossed with marker:

strikethrough with pencil:

underline with highlighter:


Make helper functions to make it easy to go between Dev and Staging/Production

Getting the base url/route for the API is a little weird right now because we are running as a separate service on development but it's pretending like it's integrated into the OSF in staging and production. So we need helper functions (probably one in JS and another in Python) to make it seamless for developers who need to use the OSF. The helper functions can grab the base url and route and construct an API based on the given route and the query parameters. This should not be a recreation of url_for; the API routes are still canonical, it's just that the starting point is different.
So, for example,
api_v2_url('/nodes/{}/contributors/'.format(node_id),
            query_params=[{'filter[fullname]': 'bob'}, {'filter[fullname]': 'smith'}])

Would return http://localhost:8000/v2/nodes/ezcuj/?filter[fullname]=bob&filter[fullname]=smith on dev and https://staging2.osf.io/api/v2/nodes/ezcuj/?filter[fullname]=bob&filter[fullname]=smith on staging and https://osf.io/api/v2/nodes/ezcuj/?filter[fullname]=bob&filter[fullname]=smith on production. There should be a similar function in javascript that works the exact same way with the same calling structure (or as close as you can get and still make it look like javascript and work properly)
apiV2Url(etc, etc);

There are settings variables for base url and the base path, so those are what you'd need to use for this.

Oh, also: the JS version of this should do CORS headers when appropriate and not do them if they aren't.

The PR for this will be sent to the 0.38 branch; this is a reminder to check for regressions in case that branch is not fully merged after the dust settles.

Updated PR for #2895; at this point perhaps it's better to send that to a different branch, though?
I'll make a separate issue for the CORS JS helpers.


Make it work in Crystal 0.20.1

In Crystal 0.20.1, argify has been renamed to splat.

bump for merge 😄

Done

Done

I have just released version 0.9.2 with that fix

I have just released version 0.9.2 with that fix


Python 3.8 not supported

Hello,
Seems like python 3.8 is not supported:

Traceback (most recent call last):
File "/mnt/tiger/osj/git_bin/diploSHIC/makeFeatureVecsForChrArmFromVcfDiploid.py", line 126, in
startTime = time.clock()
AttributeError: module 'time' has no attribute 'clock'

From the Python 3.8 doc and this post:

The function time.clock() has been removed, after having been deprecated since Python 3.3: use time.perf_counter() or time.process_time() instead, depending on your requirements, to have well-defined behavior. (Contributed by Matthias Bussonnier in bpo-36895.)

There are more than one place in diploSHIC that uses this function:

diploSHIC/diploSHIC.py:    start = time.clock()
diploSHIC/diploSHIC.py:    sys.stderr.write("total time spent fitting and evaluating: %f secs\n" %(time.clock()-start))
diploSHIC/makeFeatureVecsForChrArmFromVcfDiploid.py:startTime = time.clock()
diploSHIC/makeFeatureVecsForChrArmFromVcfDiploid.py:sys.stderr.write("completed in %g seconds\n" %(time.clock()-startTime))
diploSHIC/makeFeatureVecsForChrArmFromVcf_ogSHIC.py:    startTime = time.clock()
diploSHIC/makeFeatureVecsForChrArmFromVcf_ogSHIC.py:    sys.stderr.write("took %s seconds\n" %(time.clock()-startTime))
diploSHIC/makeFeatureVecsForChrArmFromVcf_ogSHIC.py:startTime = time.clock()
diploSHIC/makeFeatureVecsForChrArmFromVcf_ogSHIC.py:sys.stderr.write("completed in %g seconds\n" %(time.clock()-startTime))
diploSHIC/makeFeatureVecsForSingleMsDiploid.py:start = time.clock()
diploSHIC/makeFeatureVecsForSingleMsDiploid.py:    sys.stderr.write("finished %d reps after %f seconds\n" %(numInstancesDone, time.clock()-start))
diploSHIC/makeFeatureVecsForSingleMsDiploid.py:sys.stderr.write("total time spent calculating summary statistics and generating feature vectors: %f secs\n" %(time.clock()-start))
diploSHIC/makeFeatureVecsForSingleMs_ogSHIC.py:start = time.clock()
diploSHIC/makeFeatureVecsForSingleMs_ogSHIC.py:    time.clock()-start))

Specify an older python version during the installation could solve this:
conda install python=3.7.0
Best,
Shujun

Sorry, my diploSHIC was downloaded from the fall of 2018, I just saw that this bug has been fixed (https://github.com/kr-colab/diploSHIC/commit/c71074e4811413d0a9f322ec05418c346748ff7c).

Downloaded the latest version yesterday and installed with Python 3.8.3. Seems like time.clock() still exists in one script:

diploSHIC/makeFeatureVecsForChrArmFromVcfDiploid.py:163: DeprecationWarning: time.clock has been deprecated in Python 3.3 and will be removed from Python 3.8: use time.perf_counter or time.process_time instead
sys.stderr.write("completed in %g seconds\n" %(time.clock()-startTime))

This just hit me, too.  Any time line for merging a fix?

yeah definitely


Fix signedAngle

There is currently a method called signedAngle that lives in /lib/signedAngle.js.
It is incomplete and needs to be fixed!
Return the angle in degrees with the smallest possible absolute value
Acceptance Criteria:

Running yarn test <methodName> results in tests passing.
You have written a skeleton method for someone else to work on.
You have written tests surrounding your skeleton method.
Running yarn lint does not print any errors to the console!
Optional: write one or two more tests surrounding the method you are solving to account for potential edge cases.

Please include the skeleton of a new method + an accompanying test for someone else to work on at the time of creating a pull request! A pull request will most likely be denied if it does not contain a skeleton method for someone else to work on! For more information, please read the Contributing Guide.
Thank you so much for your contribution!

Hi @ltetzlaff, I want to contribute to this, can you please assign it to me?

Hi @ktilcu and @ltetzlaff, I have created a PR and linked it to that issue, please review it & let me know if it is good.


Feature/intent handling

Connection with issue(s)
Resolve issue #???

Connected to #???

Testing and Review Notes

Screenshots or Videos

To Do

[ ] double check the original issue to confirm it is fully satisfied
[ ] add testing notes and screenshots in PR description to help guide reviewers
[ ] request the "UX" team perform a design review (if/when applicable)

Not a great commit but needed to handle awkward intent formatting provided by external source


x/review/git-codereview: Change-Id hook silently doesn't run anymore when codereview.cfg is not present

This is a regression introduced in
https://go-review.googlesource.com/#/c/19560/
Before that change, if the hooks were installed for a private foobar.com Gerrit origin (i.e. not googlesource.com), they would all run. After that change, the hook code tries to figure out if Gerrit is in use, and when not, the Change-Id line is silently not added. Unfortunately, the heuristic to determine if Gerrit is in use (haveGerrit()) errs on the negative side. Consequently git-codereview mail is rejected by Gerrit because of the missing Change-Id. The failure is hard to debug because the hooks seem correctly installed, and it is especially annoying as git-codereview may have removed old working hooks in the past [1] to install its own.
One workaround is to create a codereview.cfg file in repo's root with a valid gerrit value. But it's not that great because for most installations it should be self-evident what is the Gerrit origin, it feels like a unwarranted burden on a lot of people (see: #15073) to introduce that file in many old and new gerrit repos.
The hard problem seems to be the runtime determination of what hooks should be running. Specifically, in the change above, Russ described how he wants the "issue" hook to run on non-Gerrit repo, but not the Change-Id one.
I propose to remove runtime determination of what hooks should run in favor of explicit configuration. i.e. git-codereview hooks would evolve to the following:

Like current behavior, any git-codereview sub-command would install all the hooks, if and only if a valid Gerrit is detected.
Like current behavior, if git-codereview hooks is run manually, it would force hooks installation regardless of haveGerrit() value. But, unlike current behavior it would also enable all the hook functions: issuerepo, gofmt, change-id. (See below how hooks are enabled).
If arguments are passed to git-codereview hooks, where arguments could be any sub-set of 'issuerepo', 'gofmt' and 'change-id', then it would only enable those.

The git hook script should probably stay a simple exec as it is today, because it is hard to replace and extend in the future. On the other hand, git provides a very powerful git config set of commands that git-coderereview could run on behalf of the user to set and get the different expected behaviors. https://go-review.googlesource.com/#/c/19684/ proposes something similar for reading the configuration, although I suggest we take it further and lean on the dedicated git interfaces to do the writing and reading.
I'm happy to work on a CL if that solution is deemed acceptable.

https://github.com/golang/review/blob/77ae237af753cd4f4820e67cdf058aea410bccc7/git-codereview/hook.go#L31

/cc @josharian @minux @robpike

And @adg? Not sure who maintains codereview the most these days.

I originally wanted to use git config for the config files. There were two issues. (1) Russ wanted key: value instead. (2) There was no obvious way to check in repo-level git config in a way that git config would automatically respect, and there were objections to the filename I chose. Rather than squabble/bikeshed, I acceded, and I'm not sure that reopening that particular discussion has much value.
As for having hooks accept an argument to install just a subset of hooks that seems ok. What happens if hook A is installed and hook B is requested for installation? Does A stay or go?
I'm not really the maintainer here, though, so this is just me kibitzing.

@josharian Are you referring to codereview.cfg in the first paragraph?
I'd think that the hooks command would set the config values to what's given in argument, replacing whatever was set in the past.

I just ran into this myself. Very frustrating, indeed. I feel like the proposal above is a lot of mechanism. Maybe it's worth it, but the fact that I get mildly confused and tired reading the details and thinking them through is not an auspicious sign.
In the meantime, I'm about to mail a change that should make it less painful to use codereview.cfg, which will hopefully help a little.

CL 24001

Looks like this has been merged (cherry-picked).


add artifacts

Codecov Report

Merging #30 (7dee493) into master (4c501f3) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   84.13%   84.31%   +0.17%
==========================================
  Files          73       73
  Lines        1847     1868      +21
  Branches      193      193
==========================================
+ Hits         1554     1575      +21
  Misses        269      269
  Partials       24       24

Impacted Files
Coverage Δ

vedro/core/__init__.py
100.00% <100.00%> (ø)

vedro/core/_artifacts.py
100.00% <100.00%> (ø)

vedro/core/_scenario_result.py
95.69% <100.00%> (ø)

vedro/core/_step_result.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c501f3...7dee493. Read the comment docs.


apps/whale-api: Whale Index should be versioned

What would you like to be added:
Whale Index should contain an "index version" to deterministically determine whether the current index is suitable or requires a re-index. It should be detected during service start-up and exiting if the "whale index" version is not suitable.
Why is this needed:
When we add the FutureSwap index in #1484, the index is mutated and different hence need to re-index from scratch. On JellyfishSDK/whale, we used the minor in v{major}.**{minor}**.{patch} to determine when the old index wouldn't cut it hence requires re-indexing.
/apps whale-api
/area apps
/triage accepted

/priority important-soon due to https://github.com/JellyfishSDK/jellyfish/issues/1484


zero: meta-csp: add image capture capability for scsat1

Implemented functionality to capture images (photos) using the camera on scsat1.
Modified the camera service to use libcamerify in front of the program to
ensure compatibility with libcamera.
Utilized v4l2 for direct image capture from the camera.
This adds the capability to capture images from the camera on scsat1.
Change JPEG quality from default value 75 to 90.
Currently set as a define value, not a user configuration.

Why do we encode to JPEG in the first place. Was it a requirement?

I asked @moonlight83340 to encode it to JPEG, but this is not a must requirement.
For now, I am requesting JPEG encoding from the following perspectives:

I initially tried generating a JPEG file using the Arducam sample, so I believe using the same encoding will make it easier to compare.
I thought there might be more V4L2 samples available.

I initially tried generating a JPEG file using the Arducam sample, so I believe using the same encoding will make it easier to compare.

OK. But, but to make the code easier, I'm sure it's easier to just write out the buffer to a file; No conversion needed. It is indeed easier to check the writen file though.
We should keep all images in raw format.  Format conversion should be done on either with downlink command with on-the-fly conversion, or a dedicated command, IMHO.

Just curious, do you know

What is the native (raw) format of our camera?
does the RPi Zero V4L2 driver support the exact same format? (V4L2 driver might convert to YUV or some sort)

Just curious, do you know
What is the native (raw) format of our camera?
does the RPi Zero V4L2 driver support the exact same format? (V4L2 driver might convert to YUV or some sort)

I don't have answers to these questions because I haven't investigate the Arducam camera driver.
(Especially regarding IPS)
Based on the catalog specifications, it is as follows, but I haven't looked into how the driver controls it by default.
https://www.arducam.com/product/arducam-full-hd-color-global-shutter-camera-for-raspberry-pi-2-3mp-ar0234-wide-angle-pivariety-camera-module-b0353/

ISP Output Format	Image: JPG, YUV420, RAW, DNG/Video: MJPEG, H.264
Output Format	RAW10

I would like to ask @moonlight83340  to look into these matters as well.

ISP Output Format	Image: JPG, YUV420, RAW, DNG/Video: MJPEG, H.264

:rofl:


unmanaged-cluster uses v0.10.1 TCE package repo named tce-core

What this PR does / why we need it

Bumps the package repo used by TCE to v0.10.1
Names "core" package repo tce-core instead of tkg-core-repository

Details for the Release Notes (PLEASE PROVIDE)
unmanaged-cluster uses v0.10.1 TCE package repo named tce-core

Which issue(s) this PR fixes
Fixes: #3180
Describe testing done for PR
Built and deployed a unmanaged-cluster
Package repo:
❯ tanzu package repository list -A

  NAME      REPOSITORY                                           TAG                     STATUS               DETAILS  NAMESPACE
  tce-repo  projects.registry.vmware.com/tce/main                0.10.1                  Reconcile succeeded           tanzu-package-repo-global
  tce-repo  projects.registry.vmware.com/tkg/packages/core/repo  v1.21.2_vmware.1-tkg.1  Reconcile succeeded           tkg-system

Available packages (including kpack)
 tanzu package available list

  NAME                                           DISPLAY-NAME        SHORT-DESCRIPTION                                                                                LATEST-VERSION
  cert-manager.community.tanzu.vmware.com        cert-manager        Certificate management                                                                                1.6.1
  contour.community.tanzu.vmware.com             contour             An ingress controller                                                                                1.19.1
  external-dns.community.tanzu.vmware.com        external-dns        This package provides DNS synchronization functionality.                                                                      0.10.0
  fluent-bit.community.tanzu.vmware.com          fluent-bit          Fluent Bit is a fast Log Processor and Forwarder                                                                              1.7.5
  gatekeeper.community.tanzu.vmware.com          gatekeeper          policy management                                                                                3.7.0
  grafana.community.tanzu.vmware.com             grafana             Visualization and analytics software                                                                                7.5.7
  harbor.community.tanzu.vmware.com              harbor              OCI Registry                                                                                2.3.3
  knative-serving.community.tanzu.vmware.com     knative-serving     Knative Serving builds on Kubernetes to support deploying and serving of applications and functions as serverless containers  1.0.0
  kpack.community.tanzu.vmware.com               kpack               kpack builds application source code into OCI compliant images using Cloud Native Buildpacks                                  0.5.0
  local-path-storage.community.tanzu.vmware.com  local-path-storage  This package provides local path node storage and primarily supports RWO AccessMode.                                          0.0.20
  multus-cni.community.tanzu.vmware.com          multus-cni          This package provides the ability for enabling attaching multiple network interfaces to pods in Kubernetes                    3.7.1
  prometheus.community.tanzu.vmware.com          prometheus          A time series database for your metrics                                                                                2.27.0
  velero.community.tanzu.vmware.com              velero              Disaster recovery capabilities                                                                                1.7.1
  whereabouts.community.tanzu.vmware.com         whereabouts         A CNI IPAM plugin that assigns IP addresses cluster-wide                                                                      0.5.0

Verified newer TCE repo used:
📦 Selected additional package repositories
   projects.registry.vmware.com/tce/main:0.10.1

But agree something doesn't look right with repo names.

@joshrosso - yes we must be incorrectly using it since this looks to be how v0.10.0 went out:
tanzu package repository list -A
| Retrieving repositories...
  NAME                 REPOSITORY                                           TAG                     STATUS               DETAILS  NAMESPACE
  tkg-core-repository  projects.registry.vmware.com/tce/main                0.9.1                   Reconcile succeeded           tanzu-package-repo-global
  tkg-core-repository  projects.registry.vmware.com/tkg/packages/core/repo  v1.21.2_vmware.1-tkg.1  Reconcile succeeded           tkg-system

@joshrosso - yes we must be incorrectly using it since this looks to be how v0.10.0 went out:
tanzu package repository list -A
| Retrieving repositories...
  NAME                 REPOSITORY                                           TAG                     STATUS               DETAILS  NAMESPACE
  tkg-core-repository  projects.registry.vmware.com/tce/main                0.9.1                   Reconcile succeeded           tanzu-package-repo-global
  tkg-core-repository  projects.registry.vmware.com/tkg/packages/core/repo  v1.21.2_vmware.1-tkg.1  Reconcile succeeded           tkg-system

As part of this change, let's be sure to discern the 2.

Looks like here: https://github.com/vmware-tanzu/community-edition/blob/main/cli/cmd/plugin/unmanaged-cluster/tanzu/tanzu.go#L221
Should be using tceRepoName. Though there is a problem that that code is looping through and adding potentially multiple repos all with the same name.

Pushed and updated my PR description. Should now be:
❯ tanzu package repository list -A

  NAME                  REPOSITORY                                           TAG                     STATUS               DETAILS  NAMESPACE
  community-repository  projects.registry.vmware.com/tce/main                0.10.1                  Reconciling                   tanzu-package-repo-global
  tkg-core-repository   projects.registry.vmware.com/tkg/packages/core/repo  v1.21.2_vmware.1-tkg.1  Reconcile succeeded           tkg-system

lgtm
$ k get packagerepository -A
NAMESPACE                   NAME                   AGE   DESCRIPTION
tanzu-package-repo-global   community-repository   15m   Reconcile succeeded
tkg-system                  tkg-core-repository    15m   Reconcile succeeded

Looks like here: https://github.com/vmware-tanzu/community-edition/blob/main/cli/cmd/plugin/unmanaged-cluster/tanzu/tanzu.go#L221
Should be using tceRepoName. Though there is a problem that that code is looping through and adding potentially multiple repos all with the same name.

Would be good to address this at some point, but for now, assuming we can do it out-of-band from this work.


E/IJKMEDIA: Stream ends prematurely at 79146984, should be 467805871

Good morning everyone has a problem, I hope you can give me some help please.
I have this problem:
E/IJKMEDIA: Stream ends prematurely at 79146984, should be 467805871
E/IJKMEDIA: stream 1, offset 0x4b7ba24: partial file
E/IJKMEDIA: av_read_frame error: fffffffb(�,�,�,�): unknown
E/IJKMEDIA: stream 1, offset 0x4b7bbe9: partial file
E/IJKMEDIA: av_read_frame error: fffffffb(�,�,�,�): unknown

Please, can someone help me with this problem?
Thanks from Peru!

I'm trying to do this, but there is no property, how can I do something similar?
mediaPlayer.setOption(IjkMediaPlayer.OPT_CATEGORY_FORMAT, "reconnect", 1);

Stream ends prematurely at 79146984, should be 467805871
look like video source error , or the network is unstable.


Move to supported guzzlehttp

guzzle/guzzle is abandoned and composer complains about it. guzzlehttp is a drop in replacement (no need to change code).
phpunit completes successfully with this change and composer happier.

aborting pull request now, I'm having dependencies issues. I'll reopen later.