Adding Quota APIs to Capacity RP.

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Can one of the admins verify this patch?

Automation for azure-sdk-for-go

Automation for azure-sdk-for-python

hi @ryansbenson , could you pls review this PR again? thanks.

hi @rahuls-microsoft the above error is fixed. and there's error in your operationId , pls fix the lintdiff error https://dev.azure.com/azure-sdk/public/_build/results?buildId=98261&view=logs&j=688669d0-441c-57c3-cf6d-f89a22ccfa5d.

Looks like there are these 2 potential erros:
Potential new ARM errors
========================
R2020 - RequiredPropertiesMissingInResourceModel
Model definition 'QuotaRequestDetails' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly.
at specification/reservations/resource-manager/Microsoft.Capacity/preview/2019-07-19/quota.json:550
R3006 - BodyTopLevelProperties
Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'QuotaRequestDetails' has extra properties ['value'].
at specification/reservations/resource-manager/Microsoft.Capacity/preview/2019-07-19/quota.json:553

I have Id property and other properties wrapped in an object : quotaRequestProperties. Those properties are specific for quotaRequest. So, we need it.
How do I address it?
Thanks.
Rahul.

Addressed all the errors.
Please take a look.
Is this error due to some system issue:
autoRest core      '/root/.autorest/@microsoft.azure_autorest-core<EMAIL_ADDRESS>(2.0.4390)
INFO:swaggertosdk.autorest_tools:   Installing AutoRest extension<EMAIL_ADDRESS>(~4.0.71)
INFO:swaggertosdk.autorest_tools:   Installing AutoRest extension<EMAIL_ADDRESS>(2.3.44)
INFO:swaggertosdk.autorest_tools:FATAL: System.InvalidOperationException: Sequence contains no elements
INFO:swaggertosdk.autorest_tools:   at System.Linq.Enumerable.First[TSource](IEnumerable`1 source)
INFO:swaggertosdk.autorest_tools:   at AutoRest.Python.Model.MethodPy.BuildInputMappings() in /home/vsts/work/1/s/src/vanilla/Model/MethodPy.cs:line 648
INFO:swaggertosdk.autorest_tools:   at AutoRest.Python.azure.Templates.AzureLongRunningMethodTemplate.d__1.MoveNext() in /home/vsts/work/1/s/src/obj/Razor/azure/Templates/AzureLongRunningMethodTemplate.cshtml:line 17
INFO:swaggertosdk.autorest_tools:--- End of stack trace from previous location where exception was thrown ---
Is there any action needed from my side?
Thanks.
Rahul.

@zikalino, can you have a look at the python sdk errors?
ERROR:swaggertosdk.autorest_tools:Command '['/usr/local/bin/autorest', '/git-restapi/specification/reservations/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpzdrg8__9/sdk/sdk', '--use=<EMAIL_ADDRESS>'--version=preview']' returned non-zero exit status 1.

Traceback (most recent call last):

Traceback (most recent call last):

  File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main

    "__main__", mod_spec)

  File "/usr/lib/python3.6/runpy.py", line 85, in _run_code

    exec(code, run_globals)

  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/__main__.py", line 3, in <module>

    main(sys.argv)

  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkMain.py", line 121, in main

    args.autorest_bin)

  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkMain.py", line 70, in generate_sdk

    sdk_repo, temp_dir, autorest_bin)

  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 192, in build_libraries

    autorest_bin

  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 148, in build_project

    autorest_bin)

  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/autorest_tools.py", line 117, in generate_code

    execute_simple_command(cmd_line, cwd=str(input_path))

  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/autorest_tools.py", line 143, in execute_simple_command

Is this error due to system failure-
INFO:swaggertosdk.autorest_tools:https://aka.ms/autorest
INFO:swaggertosdk.autorest_tools:   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core<EMAIL_ADDRESS>(2.0.4390)
INFO:swaggertosdk.autorest_tools:   Installing AutoRest extension<EMAIL_ADDRESS>(~4.0.71)
INFO:swaggertosdk.autorest_tools:   Installing AutoRest extension<EMAIL_ADDRESS>(2.3.44)
INFO:swaggertosdk.autorest_tools:FATAL: System.InvalidOperationException: Sequence contains no elements
INFO:swaggertosdk.autorest_tools:   at System.Linq.Enumerable.First[TSource](IEnumerable`1 source)
INFO:swaggertosdk.autorest_tools:   at AutoRest.Python.Model.MethodPy.BuildInputMappings() in /home/vsts/work/1/s/src/vanilla/Model/MethodPy.cs:line 648
INFO:swaggertosdk.autorest_tools:   at AutoRest.Python.azure.Templates.AzureLongRunningMethodTemplate.d__1.MoveNext() in /home/vsts/work/1/s/src/obj/Razor/azure/Templates/AzureLongRunningMethodTemplate.cshtml:line 17
INFO:swaggertosdk.autorest_tools:--- End of stack trace from previous location where exception was thrown ---
Please let me know, how can I address this issue?

@zikalino, @NullMDR , can you have a look at the SDK errors?

@zikalino Please help to check this autorest python error

Is there anything else outstanding, which need to be addressed?
Thanks
Rahul
Thanks.
Rahul
Sorry for fat fingers.
Sent from
Outlookhttps://aka.ms/qtex0l for iOS

From: Joel Hendrix<EMAIL_ADDRESS>Sent: Wednesday, September 4, 2019 4:07:28 PM
To: Azure/azure-rest-api-specs<EMAIL_ADDRESS>Cc: Rahul Singh<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] Adding Quota APIs to Capacity RP. (#6906)
@jhendrixMSFT commented on this pull request.

In specification/reservations/resource-manager/Microsoft.Capacity/preview/2019-07-19/quota.jsonhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F6906%23discussion_r321011410&data=02|01|rahul.singh%40microsoft.com|afd414d4a11740815a5508d7318ca8e7|72f988bf86f141af91ab2d7cd011db47|1|0|637032352508504188&sdata=57yB5rg9ZSP42gThoAiqcISEJ3%2BsQ86Yw3Iq5f3eWo0%3D&reserved=0:

                        }

                  }

          },

          "/subscriptions/{subscriptionId}/providers/Microsoft.Capacity/providers/{providerId}/locations/{location}/serviceLimits/requests": {

                  "get": {

                          "tags": [

                                  "QuotaRequests"

                          ],

                          "x-ms-examples": {

                                  "QuotaRequestHistory": {

                                          "$ref": "./examples/getQuotaRequestsHistory.json"

                                  }

                          },

                          "summary": "For the specified location and resource Provider, gets the current quota requests under the subscription over the time\n period of one year ago from now to one year back.",

                          "description": "For the specified location and Resource provider gets the current quota requests under the subscription over the time period of one year ago from now to one year back. oData filter can be used to select quota requests.",

                          "operationId": "QuotaRequests_listStatus",

I'm not sure, somebody from ARM will have to answer that I think. @KrisBashhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FKrisBash&data=02|01|rahul.singh%40microsoft.com|afd414d4a11740815a5508d7318ca8e7|72f988bf86f141af91ab2d7cd011db47|1|0|637032352508514183&sdata=w0sSAQiUKMU%2FgRuPUaldCg9is%2Bcyb%2FKWTkw5DmXfc6E%3D&reserved=0 is the next on-call and hopefully can answer/finish reviewing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F6906%3Femail_source%3Dnotifications%26email_token%3DAMYYUHDGCTSCCJC27TRW5NDQIA5TBA5CNFSM4IKOH2T2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDWJTPQ%23discussion_r321011410&data=02|01|rahul.singh%40microsoft.com|afd414d4a11740815a5508d7318ca8e7|72f988bf86f141af91ab2d7cd011db47|1|0|637032352508524181&sdata=hJtLXTMNXgEmq6UTbou9%2FqFXMmSmMn405SqLvSXlET0%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMYYUHCWQHBQCVEYJVJBRYTQIA5TBANCNFSM4IKOH2TQ&data=02|01|rahul.singh%40microsoft.com|afd414d4a11740815a5508d7318ca8e7|72f988bf86f141af91ab2d7cd011db47|1|0|637032352508524181&sdata=6MqvSOkYPV5mFYw%2BmDhXbzN04eWszDIWXVTydRrrjU0%3D&reserved=0.

Yes ARM needs to sign off on the design, once that's complete I will complete the review from the SDK perspective.

hi @rahuls-microsoft are you still on this PR?

Hi,
We would like to complete the API review soon.
I worked with @Kristopher<EMAIL_ADDRESS>to update the APIs for /ServiceLimits and /ServiceLimits and /serviceLimitsRequests.
So, that should be good.
We added AutoQuotaIncrease Request API to enable the AutoQuotaIncrease functionality, which is being added to Azure portal for a subscription.
This will be mainly used by Azure portal, as it is one time setting to enable autoQuotaIncrease or when a new subscription is created using Arm/bluePrint.
I will schedule meeting with @Gaurav<EMAIL_ADDRESS>to go over the details and questions.
Thanks.
Rahul.
From: Yunge Zhu<EMAIL_ADDRESS>Sent: Thursday, September 26, 2019 12:51 AM
To: Azure/azure-rest-api-specs<EMAIL_ADDRESS>Cc: Rahul Singh<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] Adding Quota APIs to Capacity RP. (#6906)
hi @rahuls-microsofthttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frahuls-microsoft&data=02|01|rahul.singh%40microsoft.com|9beafa4883c4401111e008d7425640b1|72f988bf86f141af91ab2d7cd011db47|1|0|637050810537436794&sdata=KROK1K5%2BTuU3u4V1Vqsi09YQhUirntMLTzvvrGIAyhw%3D&reserved=0 are you still on this PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F6906%3Femail_source%3Dnotifications%26email_token%3DAMYYUHA7AOS7STQZLSNFFY3QLRSVXA5CNFSM4IKOH2T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7UVDQQ%23issuecomment-535384514&data=02|01|rahul.singh%40microsoft.com|9beafa4883c4401111e008d7425640b1|72f988bf86f141af91ab2d7cd011db47|1|0|637050810537446791&sdata=AYr5VOxIyUiAzEMLMvhhg9gm%2FlxOgLCndB11gpC6Zj0%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMYYUHCD45CZ43P6XPHC2IDQLRSVXANCNFSM4IKOH2TQ&data=02|01|rahul.singh%40microsoft.com|9beafa4883c4401111e008d7425640b1|72f988bf86f141af91ab2d7cd011db47|1|0|637050810537446791&sdata=TSk6bOZWf8B9JlJ29XuZPt9nC3viEYvmvrtt1HVWXUg%3D&reserved=0.

thanks for the update @rahuls-microsoft . sound good.

All the open items addressed. Please review it.

@KrisBash Please review the PR and let me know, if any other changes needed. Thanks.

All comments resolved. Please take a look and give a final approval. Thanks.

@rahuls-microsoft thanks for working through all the issues.  Is this functionality live?

Not yet. We planning preview in December.
Thanks
Rahul
Thanks.
Rahul
Sorry for fat fingers.
Sent from
Outlookhttps://aka.ms/qtex0l for iOS

From: Joel Hendrix<EMAIL_ADDRESS>Sent: Thursday, October 17, 2019 12:32:46 PM
To: Azure/azure-rest-api-specs<EMAIL_ADDRESS>Cc: Rahul Singh<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] Adding Quota APIs to Capacity RP. (#6906)
@rahuls-microsofthttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frahuls-microsoft&data=02|01|rahul.singh%40microsoft.com|1658e5c85a8648d16bb808d75338ca4e|72f988bf86f141af91ab2d7cd011db47|1|0|637069375683995894&sdata=N48Ql7TZVIx%2BxFBnhNYFApWSnOfOy5jVv0jIEOr0eUk%3D&reserved=0 thanks for working through all the issues. Is this functionality live?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F6906%3Femail_source%3Dnotifications%26email_token%3DAMYYUHHXBZEMSKI6YGGFKG3QPC4V5A5CNFSM4IKOH2T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBRIJKY%23issuecomment-543327403&data=02|01|rahul.singh%40microsoft.com|1658e5c85a8648d16bb808d75338ca4e|72f988bf86f141af91ab2d7cd011db47|1|0|637069375683995894&sdata=Pg8%2BiQpDXmSTxvp1qqPGlXyzzt7ug9ObK0klL9O3XDM%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMYYUHHGXDPDXKIXQLD5AN3QPC4V5ANCNFSM4IKOH2TQ&data=02|01|rahul.singh%40microsoft.com|1658e5c85a8648d16bb808d75338ca4e|72f988bf86f141af91ab2d7cd011db47|1|0|637069375684005851&sdata=Z4xVTFw4lMaUL4nC0Se6Q54u9lEJN2gPtEBpH1Rs0Dw%3D&reserved=0.

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

When you say "private preview" does that mean only whitelisted subscriptions will have access to this API version?

That’s right. We are working with couple of internal Microsoft teams to onboard.
Thanks.
Rahul.
From: Joel Hendrix<EMAIL_ADDRESS>Sent: Wednesday, January 8, 2020 3:05 PM
To: Azure/azure-rest-api-specs<EMAIL_ADDRESS>Cc: Rahul Singh<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Azure/azure-rest-api-specs] Adding Quota APIs to Capacity RP. (#6906)
When you say "private preview" does that mean only whitelisted subscriptions will have access to this API version?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F6906%3Femail_source%3Dnotifications%26email_token%3DAMYYUHBZL5WSG4XNWHYAAXLQ4ZL2JA5CNFSM4IKOH2T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIOJ3IQ%23issuecomment-572300706&data=02|01|rahul.singh%40microsoft.com|ec7c1eb000274591f3d608d7948f35a9|72f988bf86f141af91ab2d7cd011db47|1|0|637141215114916905&sdata=Vy9XFpP3nMaaxshTw%2BVFwpxFRlz5aFmaFbgjSwwwJ9c%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMYYUHCZWFCAV62IVRIYUCDQ4ZL2JANCNFSM4IKOH2TQ&data=02|01|rahul.singh%40microsoft.com|ec7c1eb000274591f3d608d7948f35a9|72f988bf86f141af91ab2d7cd011db47|1|0|637141215114926860&sdata=SyEuo%2F1JciF%2B1OjX5qzEzWzK2ZXc%2FpQrvdzsTwOsr%2Fo%3D&reserved=0.

/azp run

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk


Danny branch

Created skeletons for my implementation & modified the .gitignore file. Check the image for details:

testing pull-request comment (im a github noob)

testing 2.0


Bugs and issues related to one-off and recurring payments

Until official hand over on Friday(30 November 2018) from Potato, it is not 100% clear which issues will remain for us to take over. I have gone over the current cards in the Backlog(https://trello.com/b/UdRlUfJg/mdn-recurring-payments-sprints), and seeing that we are already at Thursday(29 November 2018) it seems very likely that these will be the items to take over.
Below is the current list in no particular order. Once hand-over is complete, those that are relevant should be taken from here and:

A Bugzilla bug created for each item
A sprints issue created referencing the bug
Added to the epic and the sprint

@atopal @jwhitlock does this make sense? Thanks!
Payments backlog
As a developer I would like to have tests for this feature in order to have a stable feature that will work in future iterations.
Refactor: Optimise payment form event handlers and logic
An option for optimising this would be to just apply the click handler to the containing element and use event delegation to check which target has been clicked. This is slightly better for performance and also means we don't have to iterate over the elements.
Would also be good to optimise logic of the payment banner and popover by deprecating jQuery in these handlers.
Refactor: We should add form variables in the context so we're not writing confusing logic on the form
see attached image.
We have allot of conditional statements in the form.
Maybe instead we can preform this logic in the context and just pass what we need.

As a MDN developer I should enforce a max charge to prevent malicious activity

[ ] Validate in front-end
[ ] Validate in back-end

Feature: Payments API can be checked for validity
https://developer.mozilla.org/_kuma_status.json is used to verify real-time configuration of secrets. There should be a "payments" entry under "services":
{
  "services": {
    "payments": {
      "available": true (enabled and valid)
      "public_key": the public key or empty string
      "one_time": true if one-time payments are working (valid keys)
      "recurring": true if recurring payments are working (valid keys, product)
    }
  }
}

This can be used as a debug aid, or to run / skip acceptance tests
Feature: Payments views should be disabled if keys are unset

If STRIPE_PUBLIC_KEY is empty, then Stripe will fail to load, and should be equivalent to MDN_CONTRIBUTION=False (hides forms, 404views)
If STRIPE_SECRET_KEY is empty, then payments will fail on submission, and should be equivalent to MDN_CONTRIBUTION=False (hides forms, 404 views)
If STRIPE_PRODUCT_ID is empty, then recurring subscriptions will fail on form submissions. This should disable recurring subscriptions and 404 the recurring views.

As a developer, I'd like code to use "Payments" instead of "Contributions", so that I can focus on implementation instead of names.
Complete the transition from kuma/contributions to kuma/payments. These items can be done with other work when it makes sense, and completed in the down time between efforts.
Most name updates have no user impact if done correctly. Changing the name of the waffle flag from contrib_beta will reset the cohorts. This could be desirable around a change, such as 1% to 5%.
Acceptance Criteria

Flag constant is PAYMENTS_BETA_FLAG=contrib_beta (constants.py)
Template context is payments_X (for example, payments_enabled) (context_processors.py, jinja2/payments/*)
Doc strings use payments (utils.py, tests/test_views.py, etc.)
Form-handling view is payments or similar (views.py)
Background task is payment_thank_you_email (tasks.py)
Tooltip for email input says "...receipt of your payment."  (form.py)
IDs and CSS classes are payments-X or similar (jinja2/payments/payments.html, CSS rules, etc.)
Template block is payment_popup (jinja2/base.html, kuma/landing/jinja2/landing/homepage.html, ``kuma/wiki/jinja2/wiki/document.html)
Flag names are payments_X (payments_beta, etc.) (resets cohorts, be careful)
Instances of "contrib", "contribution" in the code and templates are ones we want to keep.
Context processor is global_payments_form (context_processors.py)

As a MDN developer I want a payment solution to be scalable so that I can alter the interface in the future.
We should record the stripe ID of customers during one-time payments
“Pay” button not visible after clicking it, when required fields are empty
Env:
Ubuntu 16.04, Firefox 63
Fedora 28, Firefox 63
STR:

Navigate to mdn staging homepage, not logged in
Click "Support MDN" button
Leave all the fields empty and click "Pay" button

Expected:
Error messages are displayed, Pay button is visible
Actual:
Error messages are displayed, Pay button is not visible, even after scrolling up/down. See video below.
Bug: Email confirmation for one time payments should link to the FAQ & terms pages.
Bug: keyboard navigation: The buttons for amount are not selected using Tab key
[Affected versions]:
Firefox, Chrome
[Affected Platforms]:
Windows 10
[Steps to reproduce]:
1.Go to https://developer.allizom.org/en-US/
2.Press Tab key to navigate through buttons
[Expected result]:
The navigation through the amount selection buttons should work
[Actual result]:
The buttons for amount are not selected using Tab key
Josh Jarvis comments:
"Reason for this is that the button set is a group of radio inputs.
On focusing these inputs the user can use the arrow keys to change the value https://www.w3.org/wiki/RadioButton
Maybe we should instead use a collection of buttons that activate a hidden radio selection."
Edge: The banner is displayed with delay when is expanded/compressed

As a user, I want to be able to change the payment method and amount from my MDN profile page.

As PO, I want to update the design of the MDN sign up page so that new users have a positive impression
Prototype: https://projects.invisionapp.com/d/#/projects/prototypes/16042252

Schalk, thanks for this, but the bugs are the ones in "ready for dev". The "backlog" contains a bunch of new features that we won't implement before next year, if at all. I'd add to "ready for dev" the "design QA" labeled cards in the backlog, if time permits.

Revised list based on @atopal comment above:
UI / a11y: Confirmation checkbox can't be selected by label (vs terms link can't be visited)
Before https://github.com/mozilla/kuma/pull/5101, the checkbox label could be clicked to select the checkbox, which is considered good practice for checkboxes. However, the Payment Terms link could not be clicked, and instead selected the checkbox.
As part of https://github.com/mozilla/kuma/pull/5101, the text was changed so the "visible" label doesn't select the checkbox. This allows Payment Terms to be clicked.
It is unknown if it is possible to implement the original design: a label that selects the checkbox, except for the link, which opens the link.
Acceptance Criteria

[ ] A label that selects the checkbox, except for the link, which opens the link.

Bug: Remove highlights around inputs on click.
We should remove the grey border/shadow highlight when clicking on elements and only show them when using keyboard interaction.
Acceptance Criteria

[ ] Focus only shown when user starts using keyboard

The email tooltip is wrongly displayed
Affected versions]:
Firefox, Chrome, Internet Explorer
[Affected Platforms]:
Windows 10, Ubuntu 16.04
[Steps to reproduce]:
1.Go to https://developer.allizom.org
2.Click to expand the Support MDN banner
3.Click the “?” icon located in the email field
4.Scroll the page up/down
[Actual result]:
Internet Explorer: the email tooltip is displayed at the top of the page. The tooltip is not moved while scrolling
Firefox/Chrome: The tooltip is moved with the page while scrolling

Bug: Selected state of One off payment doesn’t look good

Design QA: Thank you page

Left margins should be consistent down the side of the page: payment section copy ('Thank you for supporting MDN...") and the sections below ('Useful things') should have the same margin.
The secondary headings should align with the footer links (ask Charlie for more info)

Design QA: Banner shown and Banner open form

Banner shown: form placeholder text #9B9B9B
Banner shown: one-off payment brackets should have 16px margin between them
Banner shown: 'other amount' input should NOT be aligned right
Banner open: If user is not logged in, after clicking pay button, the white container should keep the same height as the form when showing the sign in button + copy.
Banner open: class='control-indicator' (payment terms checkbox) need 12px margin-right (currently 6px)
Banner open: class='control-indicator' (payment terms checkbox) border should be 2px (currently 3px)
Banner shown and open: Close banner 'x' should be #222222 (matching the shade of black used elsewhere in the form)
Banner shown: 'Give back to MDN' is slightly off vertical center
Banner open: all form inputs margin top should be 16px — as a rule, form spacing, be it padding or margins, should be 16px
Banner open: pay button should be Arial Bold (700)
Banner open: p.legal-copy — line height should be 20px, currently 1.35 which isn't right, my fault!)

Design QA: FAQ page and form

'FAQ' h1/2 should share the left margin of the 'Give back to MDN' above.
Anchor links should be blue with an underline
"was this useful" font-weight 700 (bold)
Pay button is not in the same place as on the banner: on banner its aligned left, on FAQ page form its kind of in the middle.
'FAQ' title should be fixed on scroll

Moved remaining issue to #929. Nice work @schalkneethling!


Error when running ldapdomaindump

Can someone shed some light what is causing the error below? Appreciate any help!
[] Connecting to host...
[] Binding to host
Traceback (most recent call last):
File "/usr/local/bin/ldapdomaindump", line 3, in
ldapdomaindump.main()
File "/usr/local/lib/python2.7/dist-packages/ldapdomaindump/init.py", line 940, in main
if not c.bind():
File "/usr/local/lib/python2.7/dist-packages/ldap3/core/connection.py", line 563, in bind
response = self.do_ntlm_bind(controls)
File "/usr/local/lib/python2.7/dist-packages/ldap3/core/connection.py", line 1302, in do_ntlm_bind
request = bind_operation(self.version, 'SICILY_RESPONSE_NTLM', ntlm_client, result['server_creds'])
File "/usr/local/lib/python2.7/dist-packages/ldap3/operation/bind.py", line 81, in bind_operation
server_creds = name.create_authenticate_message()
File "/usr/local/lib/python2.7/dist-packages/ldap3/utils/ntlm.py", line 379, in create_authenticate_message
nt_challenge_response = self.compute_nt_response()
File "/usr/local/lib/python2.7/dist-packages/ldap3/utils/ntlm.py", line 485, in compute_nt_response
response_key_nt = self.ntowf_v2()
File "/usr/local/lib/python2.7/dist-packages/ldap3/utils/ntlm.py", line 496, in ntowf_v2
password_digest = hashlib.new('MD4', self._password.encode('utf-16-le')).digest()
File "/usr/lib/python2.7/hashlib.py", line 116, in __py_new
return __get_builtin_constructor(name)(string)
File "/usr/lib/python2.7/hashlib.py", line 97, in __get_builtin_constructor
raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type MD4

I too am getting the following error
cybersoldier@cybersoldier-virtual-machine:~/Documents/marvel.local$ sudo ldapdomaindump ldaps://<IP_ADDRESS> -u 'MARVEL\fcastle' -p Password2
[*] Connecting to host...
[*] Binding to host
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/ldap3/strategy/base.py", line 823, in sending
    self.connection.socket.sendall(encoded_message)
  File "/usr/lib/python3.10/ssl.py", line 1240, in sendall
    return super().sendall(data, flags)
ConnectionResetError: [Errno 104] Connection reset by peer

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/ldapdomaindump", line 4, in <module>
    __import__('pkg_resources').run_script('ldapdomaindump==0.9.4', 'ldapdomaindump')
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 656, in run_script
    self.require(requires)[0].run_script(script_name, ns)
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 1453, in run_script
    exec(code, namespace, namespace)
  File "/usr/local/lib/python3.10/dist-packages/ldapdomaindump-0.9.4-py3.10.egg/EGG-INFO/scripts/ldapdomaindump", line 3, in <module>
    ldapdomaindump.main()
  File "/usr/local/lib/python3.10/dist-packages/ldapdomaindump-0.9.4-py3.10.egg/ldapdomaindump/__init__.py", line 940, in main
    if not c.bind():
  File "/usr/local/lib/python3.10/dist-packages/ldap3/core/connection.py", line 563, in bind
    response = self.do_ntlm_bind(controls)
  File "/usr/local/lib/python3.10/dist-packages/ldap3/core/connection.py", line 1282, in do_ntlm_bind
    response = self.post_send_single_response(self.send('bindRequest', request, controls))
  File "/usr/local/lib/python3.10/dist-packages/ldap3/strategy/base.py", line 299, in send
    self.sending(ldap_message)
  File "/usr/local/lib/python3.10/dist-packages/ldap3/strategy/base.py", line 834, in sending
    raise communication_exception_factory(LDAPSocketSendError, type(e)(str(e)))(self.connection.last_error)
ldap3.core.exceptions.LDAPSocketSendError: socket sending error[Errno 104] Connection reset by peer

@lightkun-yagami I was having this same issue. If you're running ldapdomaindump straight out of what comes preinstalled with Kali Linux, you're likely suffering from an out-of-date dependency. The error itself is happening here:
File "/usr/local/lib/python2.7/dist-packages/ldap3/utils/ntlm.py", line 496, in ntowf_v2
password_digest = hashlib.new('MD4', self._password.encode('utf-16-le')).digest()

ldap3 had a commit that expanded this functionality since MD4 is a deprecated hash that isn't covered by more modern OpenSSL. You can learn more here and here
Long story short, you can try to update your version of ldap3 by running pip install ldap3 --upgrade though you may risk breaking something else in your system.
The safest bet and what I ended up doing was copying ldapdomaindump's git, starting a virtual environment, install the new dependencies inside the venv with requirements.txt, and run ldapdomaindump.py from the venv.

 Thank you!

Was having the same issue and shaikhsabirwps comment worked for me also! thanks

Use the absolute path/usr/bin/ldapdomaindump

Worked for me also, thanks a bunch!!!

@lightkun-yagami can you close this issue if your problem is fixed?


Conflict with import/newline-after-import

I have the following set of rules:
import importPlugin from "eslint-plugin-import"
import prettierPlugin from "eslint-plugin-prettier"

export default [
  {
    plugins: {
      "import": importPlugin,
      "prettier": prettierPlugin,
    },
    rules: {
      "prettier/prettier": "error",
      "import/newline-after-import": ["error", { count: 2 }],
  }
]

Which results in an error:
Expected 2 empty lines after import statement not followed by another import  import/newline-after-import

What do you mean by conflict? prettier will not add new lines at all.

@JounQin Not sure OP came here with the same issue as I have but prettier basically overwrites 2 newlines with 1, so it doesn't respect that rule for some reason.

Sorry, but that's how prettier works that it prints codes on its own style, so two empty lines will be reprinted as one line.

Or do you mean we should disable import/newline-after-import in this config?

To me, this issue sounds like a feature request for supporting the eslint-plugin-import plugin (and its fork?). For import/newline-after-import, it looks safe to use with Prettier as long as you set it to 1 empty line (not more), so it would need a validator and “special rule” docs.


Submit Workflow: [Zothero]

Preflight

[X] The Alfred team has invited me to submit this workflow.

The submitted workflow:

[X] Was authored by me. ⓘ
[X] Uses Workflow Configuration or has no user-facing settings. ⓘ
[X] Does not have an auto-updater. ⓘ
[X] Does not contain unsigned and non-notarised binaries. ⓘ
[X] Does not download extra software. ⓘ
[X] Uses keywords with more than one character. ⓘ
[X] Has a descriptive About section. ⓘ
[X] Has an icon of at least 256x256 px. ⓘ

Homepage
https://github.com/giovannicoppola/zothero
Alfred Forum page
https://www.alfredforum.com/topic/11658-zothero-—-generate-zotero-citations-in-alfred
Gallery page content
Search and copy citations from your Zotero database
This workflow requires Zotero
Usage
Perform full-text search across your Zotero database, including only searching specific fields, via the zot keyword

↩, ⌘C or ⌘NUM: Copy one fake datum to clipboard
↩: Open the entry in Zotero
⌘↩: Copy citation to the pasteboard
⌥↩: Copy bibliography-style citation to the pasteboard
⇧↩: View entry attachments (if present)
^↩: View all citation styles
View and edit workflow configuration via the zotconf keyword
Zothero can also be triggered by typing a snippet (which you must first assign yourself in Alfred Preferences)

Credits

Forked from the original by Dean Jackson (@deanishe).

Tags
references, citations, literature, academia
Test data
demo library: Import in Zotero (File>Import) before running the workflow
DemoLibrary.rdf.zip
Homebrew dependencies
No response
Bundled libraries
workflow, zothero, cite

Thank you. Will be live soon at https://alfred.app/workflows/giovanni/zothero/.


Add member to board  POST /api/boards/boardId:/members/:memberId

Description
Endpoint to POST a new member to a board.
Fixes #80
How to test?
Test in swagger docs, under /Members
Checklist

[x] I have performed a self-review of my own code
[x] I have followed the name conventions for CSS Classnames and filenames, Components names and filenames, Style filenames, if you are in doubt check the the project README.MD and here https://github.com/HackYourFuture-CPH/curriculum/blob/master/review/review-checklist.md
[x] I have commented on my code, particularly in hard-to-understand areas, if your code was simple enough mark the box anyway
[x] I have made corresponding changes to the documentation, if you code was simple enough mark the box anyway
[x] This PR is ready to be merged and not breaking any other functionality

the feedback changes cause these build fails, not sure if that is ok 😬

@Midnighter  🙃

the feedback changes cause these build fails, not sure if that is ok 😬

@Midnighter 🙃

Just await the isOwner check and don't assign it to a constant.
You need to return 201

the feedback changes cause these build fails, not sure if that is ok 😬

@Midnighter 🙃

Just await the isOwner check and don't assign it to a constant.
You need to return 201

d'oh! Corrected, thanks @senner007  🙏🏽

Great work there Karo!
Only problem that I found is, it still returns "Only owner can add a member to a board" when I use owner's userId but a boardId that owner doesn't have like in the screenshot below :

Thanks @Rasim-Deniz !
I tested in all the ways and got the expected results.
I am not sure I follow, but maybe just some sleep is needed  today 🙈  :D
If you use a boardId (5) that userId (2) does not own - then he is not the owner and cannot add the member. Right?
And yes, the memberId is juts to distinguish every member that is to be added, I need it in the POST query ✌🏽

Great work there Karo!
Only problem that I found is, it still returns "Only owner can add a member to a board" when I use owner's userId but a boardId that owner doesn't have like in the screenshot below :

Thanks @Rasim-Deniz !
I tested in all the ways and got the expected results.
I am not sure I follow, but maybe just some sleep is needed today 🙈 :D
If you use a boardId (5) that userId (2) does not own - then he is not the owner and cannot add the member. Right?
And yes, the memberId is juts to distinguish every member that is to be added, I need it in the POST query ✌🏽

Yes, I just thought if it would be something like board doesn't exist. However it's same thing as you mentioned. So no need to take an action for this.
And yeah, I finally figured out how it works 😆

@Rasim-Deniz  now I get what you meant, sorry I did not catch it in the night : D
I did not think to check the existence of the board, as I thought we only access this endpoint from a place where we carry an ID of an existing board anyway. For the current scope, I will leave it for now like it is, so it can be merged and used.
Thanks for the review!


update dry-run metric prefix and also add e2e tests

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[x] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[x] Does not have any changes that may affect Istio users.

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/test all

@yangminzhu: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
004e437c4fededc13d6015f555361be584e4a38b
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
004e437c4fededc13d6015f555361be584e4a38b
link
/test lint_istio

gencheck_istio
004e437c4fededc13d6015f555361be584e4a38b
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
004e437c4fededc13d6015f555361be584e4a38b
link
/test lint_istio

gencheck_istio
004e437c4fededc13d6015f555361be584e4a38b
link
/test gencheck_istio

integ-telemetry-mc-k8s-tests_istio
004e437c4fededc13d6015f555361be584e4a38b
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
004e437c4fededc13d6015f555361be584e4a38b
link
/test lint_istio

gencheck_istio
004e437c4fededc13d6015f555361be584e4a38b
link
/test gencheck_istio

integ-telemetry-mc-k8s-tests_istio
004e437c4fededc13d6015f555361be584e4a38b
link
/test integ-telemetry-mc-k8s-tests_istio

integ-telemetry-k8s-tests_istio
004e437c4fededc13d6015f555361be584e4a38b
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@yangminzhu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
004e437c4fededc13d6015f555361be584e4a38b
link
/test gencheck_istio

integ-telemetry-mc-k8s-tests_istio
004e437c4fededc13d6015f555361be584e4a38b
link
/test integ-telemetry-mc-k8s-tests_istio

integ-telemetry-k8s-tests_istio
004e437c4fededc13d6015f555361be584e4a38b
link
/test integ-telemetry-k8s-tests_istio

lint_istio
0d3251d25704c018dbcf7526edd9ae5d30429380
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
004e437c4fededc13d6015f555361be584e4a38b
link
/test integ-telemetry-mc-k8s-tests_istio

integ-telemetry-k8s-tests_istio
004e437c4fededc13d6015f555361be584e4a38b
link
/test integ-telemetry-k8s-tests_istio

lint_istio
0d3251d25704c018dbcf7526edd9ae5d30429380
link
/test lint_istio

gencheck_istio
0d3251d25704c018dbcf7526edd9ae5d30429380
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
38d1ef8d41bf0327893d7e7c9eae3ac2a8833db9
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
38d1ef8d41bf0327893d7e7c9eae3ac2a8833db9
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Scrape - configure auth header scheme

Proposal
Allow Authorization header 'scheme' name and value to be configured.
Right now, I can either configure Basic authentication or Bearer authentication. Depending on which I configure, dictates the scheme name prefix in the auth header on the scrape request. For example prometheus can be configured to send either of these headers:

Authorization: BASIC hwhhejfjjjejdnwje
Authorization: BEARER hwhhejfjjjejdnwje

Each option essentialy places a constraint on the 'scheme name' portion of the authorization header, whilst allowing a static value / token to be passed as the credentials portion. This means I can configure a static value to be passed for the credentials only limited to "Basic" or "Bearer" schemes.
I have an application that uses a custom authentication scheme called API key authentication. This is also a static value that must be passed in the Authorization header. The difference is it requires a custom scheme name 'ApiKey`. I'd like prometheus to allow me to specify the scheme name, so that I am not limited to Basic or Bearer schemes and can use a custom scheme name.
Sure I could set up a custom proxy but this introduces another moving part and more complexity in the landscape so I am thinking this should be weighed against alternatives. Being able to configure the scheme name (as opposed to being restricted to Basic and Bearer) would provide for a more general purpose implementation that makes prometheus more flexible and covers more use cases without much additional complexity that I can tell..
For example right now the following two auth headers are configurable but the third is not.

Authorization: BASIC hwhhejfjjjejdnwje
Authorization: BEARER hwhhejfjjjejdnwje
Authorization: API-KEY hwhhejfjjjejdnwje

I beleive that allowing an authorization header to be configured - by specifying its components:

scheme name
value

.. would make for a more flexibile option to cover more use cases.
“Nice to have” is not a good use case. :)
We have a .net core web api we'd like to scrape that doesn't support basic auth and only supports short lived access tokens using the BEARER authentication scheme. It does support a custom Authorization scheme for api key authentication (which is a long lived value) however prometheus is currently not able to be configured to leverage that.

Hello,
It seems that API-KEY is not valid in HTTP, here are the supported authentication types: https://www.iana.org/assignments/http-authschemes/http-authschemes.xhtml
I do not think that Prometheus should promote non-official HTTP patterns.

Hello,
It seems that API-KEY is not valid in HTTP, here are the supported authentication types: https://www.iana.org/assignments/http-authschemes/http-authschemes.xhtml
I do not think that Prometheus should promote non-official HTTP patterns.
As an alternative, you could run a reverse proxy before the application or a http proxy at the client side, WDYT?

Not sure regarding the argument about promoting non standards.. I thought that the iana assignments page you linked was just a registry of reserved (well known)   scheme names - I can't see it where it says anything about prohibiting other (custom) scheme values from being used as part of the authorization header in htto protocol - but perhaps I've missed something?
Irrespective of that, it's common for that scheme name to be flexible - even if there was a strict standard somewhere that said no other scheme names are allowed aside from Basic and Bearer then I'd still argue from a pragmatism perspective that there are plenty of implementations oit there that use custom schemes names and prometheus should work with them where it 's not too much trouble.
Keep in mind prometheus isn't promoting a non standard by working with a custom scheme as if the custom scheme was already in use then the boat had already sailed on the concept - prometheus is just being configured and work with whats already there
For example look at amazon s3 they use custom scheme:
https://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-auth-using-authorization-header.html
Look at how mozzila define this:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Authorization
Then look at the framework that developes develop web api's with like asp.net core for example: in asp.net core authentication scheme names are just strings and there is no restriction on them - there are all kinds of custom authentication middlewares that people create aside from the we'll known standards - api key authentication can be fairly common for intranet based applications. I don't think asp.net core will be the only framework where this is the case and therefore as its not strictly enforced at the http protocol level in these frameworks that custom schemes cannot be used - it means custom scheme names will be and are being used.

Custom auth headers appear perfectly legitimate as per  RFC 2617

How would you see that from an end user perspective?

Thank you. This has come up in the past already: #5107 but it is not a frequent request.
I am worried that you signal sigv4, as sigv4 is not just adding a static header. I think that adding a static header is the easy part here. But sigv4 needs to know the entire request. And if we accept those non-common options, we could have more and more requests for those non-common per-request bearer tokens.
Currently, we have multiple options to change the header: basic_auth, bearer_token, bearer_token file.. and they are mutually exclusive.
I would like to avoid adding a new set of options, so should we change bearer_token with:
authorization_header_type: Bearer
authorization_header_credentials:
authorization_header_credentials_file:
Make a compatibility function, and remove them later, in Prometheus 3.x ? Would that make sense from an end user perspective?

I am worried that you signal sigv4, as sigv4 is not just adding a static header.

Sorry I am a lowly .net developer - I have no idea what sigv4 is, if I have linked to it - that was coincidence.
I was imagining for this feature that in config we'd be able to set something like:

Auth: Custom
SchemeName: apikey
Value: hdjwuiwikdkkwk

If this was specified this would equate to a header being sent:
Authorization: apikey hdjwuiwikdkkwk
One side effect of this could be that this option is more general so it could be also used to achieve basic authentication or bearer authentication  as well, for basic authentication you'd have to supply the value as the properly encoded username and password and the scheme name as basic. For bearer the scheme name would be bearer and the value would be whatever the token is.
This would just allow purely static values to be passed accross in an auth header with the scheme specified. No additional processing or signing or anything like that.


Internationalization graph.php

A few extra strings to be translated.
The scale_type code values 'up' and 'follow' need to be kept as those strings in the JS scale_type variable. The text to be translated needs to be in a different variable that can be in translated form for display. Otherwise things go wrong when in a different language.
e.g. switch to Brazilian Portuguese, then click the Autoscale. The first times it switches then gets "stuck".

The way you are implementing it will not add strings 'up' and 'down' to pot file. I couldn't see where a gettext() call to explicit strings is made.


Difference to twig-fractal?

Hey there,
Can you clarify the difference between this repo and https://github.com/WondrousLLC/twig-drupal which has been marked as deprecated and points to this repo now?
When cloning both and generating a diff, the only functional difference appears to be the following:
diff --git a/twig-drupal/src/adapter.js b/fractal-twig-drupal-adapter/src/adapter.js
index cdfb1e2..0bc443d 100644
--- a/twig-drupal/src/adapter.js
+++ b/fractal-twig-drupal-adapter/src/adapter.js
@@ -184,7 +184,7 @@ class TwigAdapter extends Fractal.Adapter {

         function AttributesObject() {
             let self = this;
-            this.classes = '';
+            this.classes = 'asdasd';
             this.attr = [];

             this.addClass = function(...str) {
@@ -213,7 +213,7 @@ class TwigAdapter extends Fractal.Adapter {

         AttributesObject.prototype.toString = function toString() {
             let attrList = [
-                this.classes !== '' ? `class="${this.classes}"`:'',
+                this.classes ? `class="${this.classes}"`:'',
                 this.attr ? this.attr.join(' ') : '',
             ];

Was the change in the first hunk intended to be committed?  It looks like a temporary debugging string?
Did you only intend to change the name of the repository?  You can do that by using the very first input field on https://github.com/WondrousLLC/twig-drupal/settings – GitHub will automatically redirect all requests to the old name to the new name.

Hi sun,
thank you for pointing out this mistake. It obviously is one. Just corrected it.
I was aware of the possibility to rename the repository hat github. The reason I did not do it: we still use the old one in various ways. I was not sure how to do a smooth transition. But point taken ;-)
Thank you again


[feature] Can this work with facebook groups / marketplace posts?

Is your feature request related to a problem? Please describe.
I'm trying to monitor changes in a Facebook group and would like to be notified of changes (eg. new posts) immediately. I assume I would need a token or a permanent cookie or something. Because this is what happens currently.

Describe the solution you'd like
I couldn't find anything related to this specifically but I assume a lot of people have similar needs. So I would like a way to monitor changes in a Facebook group.
Describe the use case and give concrete real-world examples
I would like to be notified of a post from a housing group as soon as possible so I can respond to it quickly.

Will be solved by https://github.com/dgtlmoon/changedetection.io/pull/478


[lxd] adds bash completions

Motivation for this change
Adds bash completions
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

see https://github.com/NixOS/nixpkgs/pull/64532#issuecomment-510503799


discuss: Release arrow-udf 0.2.1

Hello, everyone. I'm starting this thread to discuss the release of arrow-udf 0.2.1. This release pins the arrow version to 52 to ensure our users can build upon it.

https://github.com/arrow-udf/arrow-udf/pull/63

As discussed in https://github.com/arrow-udf/arrow-udf/pull/63, we will bump to arrow 53 to catch up the arrow train. The next release will be 0.3.0, what do you think?
cc @wangrunji0408 @sundy-li @stdrc @xxchan

I'm thinking: what about using feature flags, instead of a range to specify the arrow version?

I'm thinking: what about using feature flags, instead of a range to specify the arrow version?

Since arrow-rs is planning a stable release every three months, I believe we can simply pin the arrow version and update it every three months as well.

Only supporting latest version SGTM 😄

Great, I'll work on this release.

BTW, should we consider re-export the arrow types? So that users don't need to add arrow in their Cargo.toml.

BTW, should we consider re-export the arrow types? So that users don't need to add arrow in their Cargo.toml. This can make upgrading arrow-udf version less painful.

Personally, I don't like this idea since users rarely use arrow-udf alone. Most of the time, they already have some data from or into Arrow.

IIUC, whenever a crate uses a dependency's type in the public API, it would be better to re-export the dependency. Of course the largest benefit is ease of handling multiple versions.
Currently we have things like:
arrow-array-iceberg = { package = "arrow-array", version = "52" }
arrow-schema-iceberg = { package = "arrow-schema", version = "52" }
arrow-buffer-iceberg = { package = "arrow-buffer", version = "52" }
arrow-cast-iceberg = { package = "arrow-cast", version = "52" }
arrow-array = "50"
arrow-arith = "50"
arrow-cast = "50"
arrow-schema = "50"
arrow-buffer = "50"
arrow-flight = "50"
arrow-select = "50"
arrow-ord = "50"
arrow-row = "50"
arrow-array-deltalake = { package = "arrow-array", version = "48.0.1" }
arrow-buffer-deltalake = { package = "arrow-buffer", version = "48.0.1" }
arrow-cast-deltalake = { package = "arrow-cast", version = "48.0.1" }
arrow-schema-deltalake = { package = "arrow-schema", version = "48.0.1" }

This is quite awkward.
Some posts about this:

https://www.lurklurk.org/effective-rust/re-export.html
https://brokenco.de/2023/07/26/rust-re-export.html

Could you elaborate more on how "re-export the dependency" handling the multi-version issues? For example, I have a arrow-array = "50"'s Array, how to feed it in to iceberg's arroy?

It doesn't help in this case (i.e., when you have a specific version's type, and want to pass it to a lib using the dep).
The case it improves is: when you have code to interact with arrow-udf or iceberg, you construct it with arrow-udf::arrow::Array, or iceberg::arrow::Array. There's no inter-op between arrow-udf::arrow::Array, and iceberg::arrow::Array (or your own arrow::Array used in your code).
In our case, it's exactly like this:
RisingWave Array   --- IcebergArrowConvert --> iceberg Array

				  |--- UdfArrowConvert     --> udf Array

If each crate re-exports arrow, we don't need to improve arrow and worry about the versions.
Example in this post may be simpler to understand: https://www.lurklurk.org/effective-rust/re-export.html
It uses dep_lib::rand to construct dep_lib::rand::Rng (rand V0.7), instead of rand::Rng (rand V0.8).

Basically, the above discussion assumes that multiple versions are to some extent unavoidable.
If you want to ensure only one version is used across your project, that's orthogonal to the problem. And actually re-export doesn't hurt in any case.

TLDR is that: the whole point is things like arrow-array-iceberg doesn't make sense to me, and can be solved by re-export.

TLDR is that: the whole point is things like arrow-array-iceberg doesn't make sense to me, and can be solved by re-export.

Hi, I apologize for closing this issue by merging https://github.com/arrow-udf/arrow-udf/pull/68. Would you like to create a new issue if you believe it's worthwhile to expose arrow types?


[SPARK-45072][CONNECT] Fix outer scopes for ammonite classes

What changes were proposed in this pull request?
Ammonite places all user code inside Helper classes which are nested inside the class it creates for each command. This PR adds a custom code class wrapper for the Ammonite REPL. It makes sure the Helper classes generated by ammonite are always registered as an outer scope immediately. This way we can instantiate classes defined inside the Helper class, even when we execute Spark code as part of the Helper's constructor.
Why are the changes needed?
When you currently define a class and execute a Spark command using that class inside the same cell/line this will fail with an NullPointerException. The reason for that is that we cannot resolve the outer scope needed to instantiate the class. This PR fixes that issue. The following code will now execute successfully (include the curly braces):
{
  case class Thing(val value: String)
  val r = (0 to 10).map( value => Thing(value.toString) )
  spark.createDataFrame(r)
}

Does this PR introduce any user-facing change?
No.
How was this patch tested?
I added more tests to the ReplE2ESuite.
Was this patch authored or co-authored using generative AI tooling?
No.

cc @vsevolodstep-db

Let me fix that for you, @hvanhovell . If you don't think this is not a bug, please let me know, @hvanhovell .

I think it is a bug.


Update maxRetries

Increasing the maxRetries wrt changes in the sanger.config
PR checklist

[x] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] Make sure your code lints (nf-core lint).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).

What's the likely hood that process_high_memory processes will need 5 retries? If it does go through and ends up trying to request 1tb of mem, that will cause issues won't it? Especially as the sanger.profile caps out at 680.
Does COOLER need 200gb anyway? We get away with 100 for almost everything and even that is too large as a starting point.

What's the likely hood that process_high_memory processes will need 5 retries? If it does go through and ends up trying to request 1tb of mem, that will cause issues won't it? Especially as the sanger.profile caps out at 680.

This feature is generally only used by fastK and sort. Jobs that exceed the max.mem in sanger.config will get capped. And if they fail with max.mem, you are right they will get repeated with similar resources.

Does COOLER need 200gb anyway? We get away with 100 for almost everything and even that is too large as a starting point.

Honestly, we have not started analysing our log data. Currently it is assigning, 72GB (label: high) but I can reduce it further.


Could we standardize aspects of the sampling mechanism?

I was wondering if it would be possible to put a function or so to these APIs to allow a degree of standardization of the sampling mechanism. Here are some thoughts. Motivation:

I'm the website owner and I have a session id and a user id for every user who is logged in. Slow operations appear on the createNewWhatever() function in about 1:1000 users I have tracing sampling ratio to 1:100 so I'm getting about 1% of traces/spans that capture slowness. Let's assume that I find out that user with id 123 has slow e.g. page loads. I suspect that that's because he's doing a refresh() in another tab or something. The problem is that given that I have 100 Million (whatever) users, it's quite unlikely I also have trace for that user's refresh() method."

I believe we can enhance slightly the API to allow application developers to incorporate application knowledge to the sampling mechanism. It might be as simple as an optional sampling_id on one of the start_span() functions. This could be a user-controlled potentially uniformly distributed number ranging from 0 - 100k. It could default to a random number. This number affects traceid (or other propagated id's) generation in order to allow implementations to universally capture complete information for trace subsets across different microservices without adding any performance overhead.
For a given sampling_id number, tracing will consistently be enabled or disabled across multiple processes/servers. The property of being enabled or disabled should remain stable unless implementation's configuration changes. Different implementations are allowed to use whatever rule they want to identify if a given sampling_id is enabled for tracing or not.
What do you think?

Hi Dimitros,
The main reason sampling is not in OpenTracing API is because not all tracing systems are actually doing the traditional pre-trace sampling, because it leads to exactly the problems you describe.  However, given that many tracing implementations actually do use sampling, there is a standard tag sampling.priority that instrumentation code can set on a span to hint the tracing system that a given trace is "interesting" (or not, if set to 0). The API does not dictate how the tracing system is expected to treat that tag, however, it's up to the implementation.
If your application has a prior knowledge that a certain request is going to be "interesting", then this mechanism can help to capture more of the anomalous traces. But the main problem is that it's usually impossible to say upfront if the trace is going to be interesting, which is why some more advanced tracing systems are not using pre-trace sampling.

Nice! Those are relatively new parts of the spec. Might be just a few constants but I haven't added them yet in C++.
So the way one does it is this. If ones sees that the user with user_id==target, they set the sampling.priority to 1 which might make the system trace everything for that user. Alternatively one could define a "random" slice of the users to be traced by setting sampling.priority = 1 for e.g. user_id % 100 == 1 effectively suggesting an application-side 1:100 ratio. The latter is a bit too aggressive though since as implementer I'm left with the options either to ignore the priority or implicitly have effective sampling 1:100 or have a complex implementation that selectively ignores sampling.priority to ensure that 1:10000 is respected.

... continued at https://github.com/opentracing/specification/issues/11


Store global trending problems in a database and implement a sliding window algorithm to update it!

45 secs to 7.41 secs for trending problems page! Not bad !


New Torch multi-GPU programming model

Datapoints:
MNIST+LeNet (30 epochs)
1 GPU: 56s
2 GPUs: 2m51s
(not unexpected due to communication overhead)
Upscaled CIFAR + Alexnet (10 epochs):
1 GPU: 13m11s
2 GPUs: 13m7s
Upscaled CIFAR + Googlenet (2 epochs):
1 GPU: 16m20s
2 GPUs: 11m13s

Works for me. Scaling is similarly bad for MNIST. Here's the numbers on my old TitanZ (with NCCL):
MNIST+LeNet (30 epochs)
1 GPU: 1m28s
2 GPUs: 4m18s
Also, I have hundreds of lines like this in my logs:
BLAS : Program is Terminated. Because you tried to allocate too many memory regions.
BLAS : Program is Terminated. Because you tried to allocate too many memory regions.
BLAS : Program is Terminated. Because you tried to allocate too many memory regions.

The process keeps on trucking despite the error messages. Any ideas?

Thanks for the feedback Natalia. The wall time is similar if I remove the call to :threads(...) on Alexnet.

Also, I have hundreds of lines like this in my logs:
The process keeps on trucking despite the error messages. Any ideas?

Are you getting those error messages? That's the only thing holding me back from merging this.

If haven't seen those errors messages (neither on LeNet nor on Alexnet or GoogLeNet)

I'm not seeing the warnings now. I'll go ahead and merge this - the warnings weren't causing real problems anyway.


Do I need .graphqlconfig.yml to use the extension?

Since this extension works with gql, do I need .graphqlconfig to use it? It keeps popping this error whenever I launch a GraphQL project:

The extension kicks in when graphql config file is present. However, the extension will work with .graphql files.
We should make the extension silent about existence of graphql config file.
Closing this one as it is covered in https://github.com/prismagraphql/vscode-graphql/issues/7


hashtable formatting error

i've got a new problem with powershell formatting.
i upgraded to<EMAIL_ADDRESS>an hour or two before i noticed this problem.
it may have existed prior to the upgrade, but i never noticed it.
it's particularly scary because i didn't notice it for some time until my code started failing.
the attached zip has all the files described below plus a debug log.
the before .ps1 code is in hashtable-formatting_BEFORE.ps1
$AzureAD = (Get-Command -FullyQualifiedModule @{ModuleName = 'AzureAD'; ModuleVersion = '<IP_ADDRESS>' }).Name
$AzureADPreview = (Get-Command -FullyQualifiedModule @{ModuleName = 'AzureADPreview'; ModuleVersion = '<IP_ADDRESS>' }).Name

and the after .ps1 code is in hashtable-formatting_AFTER.ps1
$AzureAD = (Get-Command -FullyQualifiedModule @{ModuleName = '<IP_ADDRESS>' }).Name
$AzureADPreview = (Get-Command -FullyQualifiedModule @{ModuleName 'AzureADPreview'; ModuleVersion '<IP_ADDRESS>' }).Name

i tried to reproduce the problem in unaffected-hashtables.ps1 but the code here formatted correctly.
i can't explain why.
i duplicated this problem on two machines. the details are in machine-details.txt.
here's the interesting part:
machine 2 is basically win10 winver 2004 with vscode ootb plus<EMAIL_ADDRESS>on machine 2, hashtable-formatting_BEFORE.ps1 formatted correctly.
then i copied my settings.json from machine 1 (win8.1) to machine 2.
when i reformatted hashtable-formatting_BEFORE.ps1 with the new settings.json, i got hashtable-formatting_AFTER.ps1.
so take a look at settings.json.
thanks folks
powershell-preview-hashtable-format-error.zip

@elrod-johnson Thank you for taking the time to provide details. This is very likely caused by your setting powershell.codeFormatting.whitespaceBetweenParameters being set to true. This is a new setting that we recently added and its default is false. This issue has already been fixed as part of #1498 but is pending a patch release of PSScriptAnalyzer, which we plan to do in the next few weeks. In the meantime we suggest to set the setting value to its default value of false.
FYI @rjmholt @JamesWTruher @SydneyhSmith

that seems to have fixed it.
thank you


jQuery not running

I have ASP.NET application succesfully integrated Rotativa.
However I now have a page with jQuery script and it is not executed when using the ViewAsPdf action
Any solutions ? I added "--javascript-delay 10000", no difference.
If I run the page in browser, it's ok and executing jQuery.
Using Rotativa 1.7.3 from NuGet, jQuery 3.1.1

Is jquery making Ajax calls?
Il sab 23 mag 2020, 11:05 Joop Stringer<EMAIL_ADDRESS>ha
scritto:

I have ASP.NET application succesfully integrated Rotativa.
However I now have a page with jQuery script and it is not executed when
using the ViewAsPdf action
Any solutions ? I added "--javascript-delay 10000", no difference.
If I run the page in browser, it's ok and executing jQuery.
Using Rotativa 1.7.3 from NuGet, jQuery 3.1.1
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/webgio/Rotativa/issues/215, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKCTPN4PEGJYCEAJC3CIGDRS6GUJANCNFSM4NILTZMA
.

Hi Gio,
No AJAX calls. After some digging I found this post * https://github.com/wkhtmltopdf/wkhtmltopdf/issues/4341

Override jquery >= 3.3.1 functions because of wkhtml2pdf 12.5 issues

So I created an additional JS file and now it looks like it's working.
Also tried ActionAsPDF but then I end up in authentication issues -> PDF shows login screen...

Great, thanks!
Il sab 23 mag 2020, 15:50 Joop Stringer<EMAIL_ADDRESS>ha
scritto:

Hi Gio,
No AJAX calls. After some digging I found this post *
wkhtmltopdf/wkhtmltopdf#4341
https://github.com/wkhtmltopdf/wkhtmltopdf/issues/4341

Override jquery >= 3.3.1 functions because of wkhtml2pdf 12.5 issues

So I created an additional JS file and now it looks like it's working.
Also tried ActionAsPDF but then I end up in authentication issues -> PDF
shows login screen...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/webgio/Rotativa/issues/215#issuecomment-633057591,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKCTPN25YYSCASRYULMMDDRS7IB7ANCNFSM4NILTZMA
.


Added Navigation Bar animation

This is a Navigation Bar Animation done by using HTML and CSS.
It has hover effects with changing colors which helps to enhance the user experience.

@Sanchita1304
connect with me -
Github : https://github.com/Durgesh4993
LinkedIn : https://www.linkedin.com/in/durgesh4993/

Thank you


integration: Run tests with Docker master

Support for using a different CLI (set by DOCKER_BINARY)
run.sh will now extra the CLI from the docker image and use it to run tests
Updated DOCKER_IMAGE to dockerswarm/dind-master, which is automatically built on every merge of docker/docker
Added a test to verify that the client and server versions are the same

To all writing integration tests: @vieux @abronan @jimmyxian @chanwit
Please remember: Never use docker unless you are combining it with -H. If you want to talk to the host docker engine (like in zk-discovery.bats), now you have to use docker_host.

@aluzzardi ack

@vieux please take a quick look at the changes.
Some are okay (the ordering changed and I've future-proofed by checking $output instead of $lines) but inspect --format={.Node.IP} is broken because of #717

@aluzzardi OK

@vieux @abronan can you review this?

@aluzzardi overall LGTM
Just, as this clearly aims to run this on Jenkins, shouldn't we package @jimmyxian's wssh image under dockerswarm instead? Just to keep control over this instead of relying on another repository. For now it's ok but just asking.

@vieux I need to merge this. Please have a look after.
@abronan Because one can still run the tests without jenkins


Add fritzbox_callforwarding

Description:
a new component to read out and switch on/off the call forwardings of an AVM Fritzbox
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#2358
Example entry for configuration.yaml (if applicable):
switch:
  platform: fritzbox_callforwarding
  password: YOUR_PASSWORD

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

Hi @jmtatsch,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Looks like your branch got messed up and contains a lot of commits that are not yours. Please clean it up.

This PR seems to have gone stale. Closing it. You can reopen it when you're ready to finish it.


Add implementations of np.convolve & np.correlate

See also: https://github.com/google/jax/pull/1831
which isn't merged yet (still changes requested, but we took a long time to review it too.)

See also: #1831

Thanks, I hadn't seen that. I'll close this one.


Slick sans jQuery

Is there an option, perhaps a fork, that would allow me to use Slick without jQuery? I'm pretty stubborn about not using jQuery in my project, but Slick is wonderful.

Nah, but maybe v2! Search old issues for more info.

Ok, it's fine. Are there any libs with similar functionality that I could
use?
On Mon, Jul 25, 2016 at 3:21 PM leggomuhgreggo<EMAIL_ADDRESS>wrote:

Nah, but maybe v2! Search old issues for more info.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kenwheeler/slick/issues/2433#issuecomment-234950871,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ5Yry4pcOjFfswVmDR_xdOpPr2Szgvtks5qZLhNgaJpZM4JUAoT
.


CI/TST: fix tests for voronoi_diagram for latest GEOS

The return value has been changed to always be a MultiLineString, instead of either LineString or MultiLineString, depending on the number of input points -> https://github.com/libgeos/geos/pull/702
This updates the test to reflect that.

Some more errors turned up compared to what we had on the main branch. The new ones might be related to a numpy change?

See https://github.com/numpy/numpy/releases/tag/v1.24.0rc1

Yes, I suppose because of "Ragged array creation will now always raise a ValueError unless dtype=object is passed. This includes very deeply nested sequences.", this now raises with a different error (message). Will handle this in a separate PR.


[Documentation] Would like to add Alchemy's Road to Web3 under the Learning Platforms and YouTube Channels section.

Is your feature request related to a problem? Please describe.
I would like to add Alchemy's Road to Web3 as a learning resource under the Learning Platforms and YouTube Channels section.
Describe the solution you'd like
Alchemy's Road to Web3
Alchemy's Road to Web3 YouTube Playlist
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

go for it


About trajectory analysis

Congratulations for this nice work!
I wonder if it is possible to use SEDR for trajectory analysis of spatial data from merfish and starmap？
Thanks!

I am sorry that SEDR does not have function for trajectory anlaysis. But it is possible that the output of SEDR can be used as the input of trajectory analysis. You can have a try.


[AKS] az aks update: Fix the issue of NoneType error when updating the config of keyvault secret provider

Related command

az aks update
Description

Fix the NoneType error that occurs when updating the incomplete addon profile of azure keyvault secret provider. Now its config will be backfilled as
{
    "enableSecretRotation": "false",
    "rotationPollInterval": "2m"
}

A more explicit error is thrown when azure keyvault secret provider is not enabled, instructing the user to enable it via the az aks enable-addons command.
Fix issue #5056.
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

AKS


Drop consensus data

See neo-project/neo#2296 and neo-project/neo#2304.

See also neo-project/neo#2308 changes to primary index handling in header verification.

See neo-project/neo-modules#511 also.


Issue #1164 Route with parameters and sub routes fail in production

hotfix for production sub-path

@jvitor83 did this change because of an issue he had in IIS.

Further Info: https://github.com/mgechev/angular2-seed/pull/1122#discussion_r70938121


Add support for GCP Cloud Build Worker Pool

Objective
Add support for GCP Cloud Build Private Worker Pool.
Terraform resources
google_cloudbuild_worker_pool

Pricing details
https://cloud.google.com/build/pricing#private_pools_pricing

Hi @safderun ! Thank you for creating this issue! Please let us know if you’d like to contribute, otherwise we’ll open it up for the whole community (we regularly prioritize and work on them too). We usually add details about each resource listing the cost components Infracost should show. If you have ideas what this could be, you could add them to the issue. We have a guide that explains the process: Resource mapping guide.

I would like to contribute!

great @safderun, I'll assign this issue to you and set the status to in-progress in our project board. Feel free to reach out if you hit any blockers or need any help. I'd recommend joining our slack, as this is the best place to reach out to the team or other contributors directly.

How can I join slack? I can't signup for the workspace.

I wasn't able to do that. Can you unassign me please?


Using Near with PostgreSQL fails (heroku)

When deploying to Heroku, and using near, it fails. Heroku's default  PostgreSQL.
@locations = Location.all # WORKS
@locations = Location.near(params[:search], 50, :order => :distance) # FAILS
Rails 3.0.9
geocoder 1.0.2
PostgreSQL 8.4

Acknowledging this issue is closed, it is still a top Google result when searching for the error.
I'm just going to throw in my 2 cents regarding the situation I was in and what fixed it.
For me the problem was as simple as User.pluck(:id) (which caused the error) vs. User.select(:id).map(&:id)
I don't know what happens internally here and I have only appreciation for this gem which I've used multiple times. Hopefully this will help someone though.

Hi, Alex, Thanks for your great work.
I have similar problem.
My table has 'distance' column, but I don't want to change rename it.
It would be great if I could solve this problem like following:
Route.nearby([lat, lon], radius, distance_column: :nearby_distance)


Fix support for SRV record type

Fixes: #30

Hey @guessi - thank you for your contribution, but there were a few other changes that were necessary too. I've incorporated your changes into the next patch.

No problem, thanks for the update.


feat(settings): add settings management

Close #897
Introduce sub-folders inside services/ & rest/.
Also close #312

Documentation for deprecated flags updated via https://github.com/portainer/portainer-docs/commit/303d54ea0a963e804af9ac5ea39dddb709e5a6fd


document the summary of two pthread implementations

Thanks @yamt ! We are just wondering how to add the document of wasi-threads, and add an item to the Key features list of README.md. How about we adding a line in README.md after Multi-thread, pthread APIs and thread management by referring to your document:
- [wasi-threads](./doc/pthread_impls.md#wasi-threads-new), ref to [document](./doc/pthread_impls.md#wasi-threads-new) and [sample](samples/wasi-threads)
And provide more detail document about wasi-threads in the future if needed.

Thanks @yamt ! We are just wondering how to add the document of wasi-threads, and add an item to the Key features list of README.md. How about we adding a line in README.md after Multi-thread, pthread APIs and thread management by referring to your document: - [wasi-threads](./doc/pthread_impls.md#wasi-threads-new), ref to [document](./doc/pthread_impls.md#wasi-threads-new) and [sample](samples/wasi-threads)

it makes sense. do you want me to do it in this PR?

Thanks @yamt ! We are just wondering how to add the document of wasi-threads, and add an item to the Key features list of README.md. How about we adding a line in README.md after Multi-thread, pthread APIs and thread management by referring to your document: - [wasi-threads](./doc/pthread_impls.md#wasi-threads-new), ref to [document](./doc/pthread_impls.md#wasi-threads-new) and [sample](samples/wasi-threads)

it makes sense. do you want me to do it in this PR?

Yes, appreciated!

Thanks @yamt ! We are just wondering how to add the document of wasi-threads, and add an item to the Key features list of README.md. How about we adding a line in README.md after Multi-thread, pthread APIs and thread management by referring to your document: - [wasi-threads](./doc/pthread_impls.md#wasi-threads-new), ref to [document](./doc/pthread_impls.md#wasi-threads-new) and [sample](samples/wasi-threads)

it makes sense. do you want me to do it in this PR?

Yes, appreciated!

done


Ensure vagrant mongo listens on all addresses

This makes sure mongo can accept connections from <IP_ADDRESS> which is a
convention in many people's set ups.
@mgrauer this should address your issue here:
https://github.com/Kitware/minerva/pull/259#issuecomment-185916337

LGTM, thanks.


when i change the input_size,and then export to onnx,raise error

The input shape should be divisible by 32. It is because the model's max downsample stride is 32.


Changing a strategy parameter in Deployment from Recreate to RollingUpdate

Describe the solution you'd like
I want to change a strategy parameter of trident-csi deployment, which is created by Trident Operator, from Recreate to RollingUpdate.
When a trident-csi pod from deployments is updating, trident-csi from daemonset occor this error.
$ kubectl rollout restart deployment trident-csi
$ starn trident-csi
...
trident-csi-qtfjb trident-main time="2020-08-20T02:53:31Z" level=debug msg="Controller not yet ready, waiting." error="could not log into the Trident CSI Controller: error communicating with Trident CSI Controller; Put \"https://<IP_ADDRESS>:34571/trident/v1/node/demo-netapptest-master-default-e5534874-khqsw\": dial tcp <IP_ADDRESS>:34571: connect: connection refused" increment=989.409747ms
...

I think that this is correct behavior.
But I would like to reduce connection loss during trident-csi update.
Describe alternatives you've considered
In other idea, you try to change number of replicas.
Additional context
none

@ysakashita,
We've looked at this and want to know more about the use case. We do not understand the advantage of using RollingUpdate here when the Trident Controller is not yet ready during a Trident upgrade. Can you provide more information.

@gnarl We want to avoid trident-csi downtime as much as possible.
As you may know, the current strategy(Recreate) in Deployment work as follows.
https://kubernetes.io/docs/concepts/workloads/controllers/deployment/
All existing Pods are killed before new ones are created when .spec.strategy.type==Recreate.

Therefore, downtime for trident-csi is longer.
On the other hand, the strategy(RolliongUpdate) is able to control  the rolling update process. (e.g. maxUnavailable)
This will reduce downtime because the old trident-csi will not be lost until the new trident-csi is ready.

Hi @ysakashita,
I've talked to the team about this issue. Since Trident is a stateful application the running Trident deployment must be stopped before the upgraded Trident deployment can be started. That said we are looking into the performance of the Trident daemonset registering with the Trident controller. While this doesn't address the logged error you reported we may be able to improve the overall upgrade performance for a K8S cluster with a large number of worker nodes.

I am fine with any method as long as it reduces the downtime of trident-csi. 👍

This issue is fixed with commit and will be included in the Trident 21.07 release.


Missing a section abuout using dynamic configuration

[Enter feedback here]
I would like to see a section about using dynamic configuration (using Azure Application Configuration) in Typed HttpClient.
TypedHttpClient(HttpClient httpClient, IOptionsSnapshot apiConfig)
private async Task<string> GetAccessToken()
{
	var dynamicValue = apiConfig.Value.Email;
}

The value should be updated / up2date in next call (changing sentinel,  the cache timeout, etc).
Is this even possible?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 881cef77-11ef-ac11-06d0-0996a1ccfa1b
Version Independent ID: 3d356334-e672-7e8b-1fef-7944ebee99eb
Content: Make HTTP requests using IHttpClientFactory in ASP.NET Core
Content Source: aspnetcore/fundamentals/http-requests.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @stevejgordon
Microsoft Alias: scaddie

Thanks for contacting us.
We don’t have the resources to invest in this area, so we are closing the issue. Should your request generate enough  👍 responses, we’ll reconsider. We'll also reconsider this issue in the next doc update.

Thanks for contacting us.
We don’t have the resources to invest in this area, so we are closing the issue. Should your request generate enough  👍 responses, we’ll reconsider. We'll also reconsider this issue in the next doc update.


Build scaffolding, taskfiles, postgres deploy

This merge request introduces basic scaffolding for the API server and database components primarily affect the dev setup process and odr_database modules, with some minor updates to odr_core. Here's an overview of the key additions. This is mostly a stub for us to discuss if we want to in regards to how we want to deploy and do testing, however it could also serve us for early dev:
Database (odr_database module):

Added Docker Compose file for PostgreSQL and pgAdmin setup
Included Taskfile with commands for managing the PostgreSQL database

Core Updates (odr_core module):

Updated Taskfile to include additional test and migration tasks

General Updates:

Added or updated various init.py files to structure the modules
Included setup scripts for both Windows (PowerShell) and Unix-based

Merge rules changed, merging into other branch without pr


converts "0.0" to "0" after the format

jsonlint is converting a decimal field having "0.0" to a int "0", please see input output below.
I know technically 0.0 and 0 are equal but that's something my application should handle , Jsonlint should give me output after format as is without any change in its values.
input
{"Discount":0.0}
output
{
"Discount": 0
}

This issue is fixed in new version of jsonlint.com


Add secret value component

Creating SecretValue component to be used internally and externally.
Reviewer: See external plugin branch of same name

Reviewer: @daiyiwhale

i tested it out and it works great


refactor(pipettes): make all motors on the EVT 96 chan use the tmc2160

All of the motors are now using the tmc2160 motor driver. I made an executive decision to no longer support the gear motors on the L5 boards for the 96 channel because it was getting to be gross to try and support both configurations.
We will only be using the old L5 proto board for plunger testing on the 96 channel.

Let's not commit code that "builds" but doesn't do anyhting on L5s - let's remove the ability to build 96 channels on L5.

It will still move the plunger -- which we will be using for testing on the 96 chan plunger prototype. That is why I haven't removed support yet. Please see this thread.


Missing dependency on cppzmq-dev when packaging?

I've been using rosdep to install a minimal set of required dependencies, including this package. However, it would seem that the released debian's of this package for ROS2 Jazzy are missing an transitive dependency for cppzmq-dev:
$ apt show ros-jazzy-gz-transport-vendor
Package: ros-jazzy-gz-transport-vendor
Version: 0.0.4-1noble.20240702.041717
Status: install ok installed
Priority: optional
Section: misc
Maintainer: Addisu Z. Taddese<EMAIL_ADDRESS>Installed-Size: 2267 kB
Depends: libc6 (>= 2.38), libgcc-s1 (>= 3.3.1), libprotobuf32t64 (>= 3.21.12), libsqlite3-0 (>= 3.5.9), libstdc++6 (>= 13.1), libuuid1 (>= 2.16), libzmq5 (>= 4.0.1+dfsg), ros-jazzy-gz-msgs-vendor, libprotobuf-dev, libprotoc-dev, libsqlite3-dev, libzmq3-dev, pkg-config, protobuf-compiler, pybind11-dev, python3-dev, python3-psutil, python3-pytest, ros-jazzy-gz-cmake-vendor, ros-jazzy-gz-math-vendor, ros-jazzy-gz-tools-vendor, ros-jazzy-gz-utils-vendor, uuid-dev, ros-jazzy-ros-workspace
Homepage: https://github.com/gazebosim/gz-transport
Download-Size: unknown
APT-Manual-Installed: yes
APT-Sources: /var/lib/dpkg/status
Description: Vendor package for: gz-transport13 13.2.0 Gazebo Transport: Provides fast and efficient asynchronous message passing, services, and data logging.

Resulting in downstream build errors when attempting to use the provided headers:
In file included from /opt/ros/jazzy/opt/gz_transport_vendor/include/gz/transport13/gz/transport/Discovery.hh:75,
                 from /opt/ros/jazzy/opt/gz_transport_vendor/include/gz/transport13/gz/transport.hh:26,
                 from /opt/auto_ws/src/auto-sandbox/src/gazebo/auto-gazebo-sim/dexory_gazebo/src/populate_world_node.cpp:10:
/opt/ros/jazzy/opt/gz_transport_vendor/include/gz/transport13/gz/transport/Helpers.hh:21:10: fatal error: zmq.hpp: No such file or directory
   21 | #include <zmq.hpp>
      |          ^~~~~~~~~
compilation terminated.
gmake[2]: *** [CMakeFiles/populate_world_node.dir/build.make:76: CMakeFiles/populate_world_node.dir/src/populate_world_node.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:741: CMakeFiles/populate_world_node.dir/all] Error 2
gmake[1]: *** Waiting for unfinished jobs....

Related:

https://github.com/ros/rosdistro/pull/41413

cc @azeey @nuclearsandwich

Thanks for the issue @ruffsl. I'll make another release of gz-transport.

https://github.com/ros/rosdistro/pull/42099


feat: Gsheet adding sheets component

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Can you add more details in the PR description?

https://github.com/apache/superset/pull/15801/
in favor of this PR


AI-Generated Documentation Experiment for libcoro

Hi @jbaldwin,
I'm quite intrigued by libcoro and wanted to experiment with using a large language model (Gemini 1.5 Pro) to generate documentation for it.
The project seemed like a good fit for this experiment because:

It's small enough to fit entirely within Gemini's context window, allowing the AI to potentially grasp the full scope of the codebase.
The main source of documentation appears to be the README, and while there are comments in the code, it doesn't seem like there's a Doxygen setup for a detailed API reference.

My process was simple:  I fed Gemini the entirety of the libcoro source code, examples, and tests (about 170k tokens). Then, I prompted it with instructions like "propose an outline" or "write section 4.1" and let it generate content. It took about an hour of copy and paste. The requests typically finished in 1 or 2 minutes. I assembled the results into markdown files in the doc/ folder of my fork: https://github.com/plops/libcoro/tree/main/doc
My primary goal wasn't to produce production-ready documentation.  Instead, I was curious to see what the AI would come up with when given access to the entire codebase.
Here are some observations:

The generated content is surprisingly structured and coherent, including a nice PlantUML diagram.
It's likely riddled with inaccuracies and potentially useless examples.

I haven't thoroughly vetted the output, but I'm sharing it in case you find it interesting or potentially useful as a starting point for more formal documentation.
Let me know if you have any thoughts or questions about this experiment!

Hey @plops this is a really cool idea! Thanks for sharing. I will definitely dig in and see how it turned out when I get some time.
Curious to see how it compares to the hand written readme examples too.

I've got some time to try and read through some of these, I'll write up some notes / thoughts as I go through the generated docs.

31_tasks

coro::task<T> documentation is very low level and shows how to use task outside of the normal usages with sync_wait and executors (e.g. coro::thread_pool and coro:io_scheduler). This is maybe useful? But probably not how I would expect most users to end up using coro::task<T>.
The example usage of std::suspend_always{} I think should be discouraged since it doesn't work with libcoro's executors. I'm wondering if that is in my existing docs and it pulled it from there (in which case I should scrub it) or if it got that from std::coroutine code?

32_executors

coro::thread_pool awesome this is really easy to follow I think, the shutdown() isn't necessary and will be called automatically by the pool's destructor so the docs are a little off on this, its optionally available if a user wants to call it sooner. I wonder if this is in the wording I've used on the shutdown() function and should say its optional?
coro::io_scheduler the first example is pretty interesting... it makes an io_scheduler to process a task of polling an eventfd but then it resumes the task manually, probably something nobody would ever do, the io_scheduler should just drive the task from start to finish in this example.

33_syncprimitives

These examples are short and sweet and really get the point across, it seems to have done a better generation here.
Some interesting missing items in the examples thought like a comment saying Create and start the worker tasks... but doesn't show code for it.

... more to come, this is really cool though, I'm enjoying reading through what its generated...


simple_https - issue with private key insertion

BIG-IP version: v<IP_ADDRESS>
extension version: 0.1.0 b1
Description: when i put my private key in the template, it fails rendering the declaration and also fail the deployment.
To test this template, i relied on the AS3 declaration here: https://clouddocs.f5.com/products/extensions/f5-appsvcs-extension/latest/userguide/examples.html#example-2-https-application
When i fill the template until the private key, it works well and the declaration is still rendered properly:
Output:
{
"class": "ADC",
"schemaVersion": "3.0.0",
"MystiqueTest": {
"class": "Tenant",
"Simple_HTTPS": {
"class": "Application",
"template": "https",
"serviceMain": {
"class": "Service_HTTPS",
"virtualPort": 443,
"virtualAddresses": [
"<IP_ADDRESS>"
],
"pool": "web_pool",
"serverTLS": "webtls"
},
"web_pool": {
"class": "Pool",
"monitors": [
"http"
],
"members": [
{
"servicePort": 443,
"serverAddresses": [
"<IP_ADDRESS>"
]
}
]
},
"webtls": {
"class": "TLS_Server",
"certificates": [
{
"certificate": "webcert"
}
]
},
"webcert": {
"class": "Certificate",
"certificate": "-----BEGIN CERTIFICATE-----\nMIICnDCCAgWgAwIBAgIJAJ5n2b0OCEjwMA0GCSqGSIb3DQEBCwUAMGcxCzAJBgNVBAYTAlVTMRMwEQYDVQQIDApXYXNoaW5ndG9uMRAwDgYDVQQHDAdTZWF0dGxlMRQwEgYDVQQKDAtmNV9OZXR3b3JrczEbMBkGA1UEAwwSc2FtcGxlLmV4YW1wbGUubmV0MB4XDTE3MTEyNjE5NTAyNFoXDTE4MDIyNTE5NTAyNFowZzELMAkGA1UEBhMCVVMxEzARBgNVBAgMCldhc2hpbmd0b24xEDAOBgNVBAcMB1NlYXR0bGUxFDASBgNVBAoMC2Y1X05ldHdvcmtzMRswGQYDVQQDDBJzYW1wbGUuZXhhbXBsZS5uZXQwgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBALEsuXmSXVQpYjrZPW+WiTBjn491mwZYT7Q92V1HlSBtM6WdWlK1aZN5sovfKtOX7Yrm8xa+e4o/zJ2QYLyyv5O+t2EGN/4qUEjEAPY9mwJdfzRQy6Hyzm84J0QkTuUJ/EjNuPji3D0QJRALUTzu1UqqDCEtiN9OGyXEkh7uvb7BAgMBAAGjUDBOMB0GA1UdDgQWBBSVHPNrGWrjWyZvckQxFYWO59FRFjAfBgNVHSMEGDAWgBSVHPNrGWrjWyZvckQxFYWO59FRFjAMBgNVHRMEBTADAQH/MA0GCSqGSIb3DQEBCwUAA4GBAJeJ9SEckEwPhkXOm+IuqfbUS/RcziifBCTmVyE+Fa/j9pKSYTgiEBNdbJeBEa+gPMlQtbV7Y2dy8TKx/8axVBHiXC5geDML7caxOrAyHYBpnx690xJTh5OIORBBM/a/NvaR+P3CoVebr/NPRh9oRNxnntnqvqD7SW0U3ZPe3tJc\n-----END CERTIFICATE-----",
"privateKey": null
}
}
}
}
As soon as i insert the private key, the declaration isn't rendered/updated anymore and the deployment will fail (if you go to "view schema" and then go back to "View rendered", you never see the rendered definition):
here is the private key i try to insert:
-----BEGIN RSA PRIVATE KEY-----\nProc-Type: 4,ENCRYPTED\nDEK-Info: AES-256-CBC,D8FFCE6B255601587CB54EC29B737D31\n\nkv4Fc3Jn0Ujkj0yRjt+gQQfBLSNF2aRLUENXnlr7Xpzqu0Ahr3jS1bAAnd8IWnsR\nyILqVmKsYF2DoHh0tWiEAQ7/y/fe5DTFhK7N4Wml6kp2yVMkP6KC4ssyYPw27kjK\nDBwBZ5O8Ioej08A5sgsLCmglbmtSPHJUn14pQnMTmLOpEtOsu6S+2ibPgSNpdg0b\nCAJNG/KHe+Vkx59qNDyDeKb7FZOlsX30+y67zUq9GQqJEDuysPJ2BUNP0IJXAjst\nFIt1qNoZew+5KDYs7u/lPxcMGTirUhgI84Jy4WcDvSOsP/tKlxj04TbIE3epmSKy\n+TihHkwY7ngIGtcm3Sfqk5jz2RXoj1/Ac3SW8kVTYaOUogBhn7zAq4Wju6Et4hQG\nRGapsJp1aCeZ/a4RCDTxspcKoMaRa97/URQb0hBRGx3DGUhzpmX9zl7JI2Xa5D3R\nmdBXtjLKYJTdIMdd27prBEKhMUpae2rz5Mw4J907wZeBq/wu+zp8LAnecfTe2nGY\nE32x1U7gSEdYOGqnwxsOexb1jKgCa67Nw9TmcMPV8zmH7R9qdvgxAbAtwBl1F9OS\nfcGaC7epf1AjJLtaX7krWmzgASHl28Ynh9lmGMdv+5QYMZvKG0LOg/n3m8uJ6sKy\nIzzvaJswwn0j5P5+czyoV5CvvdCfKnNb+3jUEN8I0PPwjBGKr4B1ojwhogTM248V\nHR69D6TxFVMfGpyJhCPkbGEGbpEpcffpgKuC/mEtMqyDQXJNaV5HO6HgAJ9F1P6v\n5ehHHTMRvzCCFiwndHdlMXUjqSNjww6me6dr6LiAPbejdzhL2vWx1YqebOcwQx3G\n-----END RSA PRIVATE KEY-----
and here is the error message i get if i try to submit my application deployment
restnoded.log
Fri, 14 Feb 2020 12:13:30 GMT - severe: [ErrorHandlingModule] RestOperation failed: "/shared/fast/applications". {"code":500,"message":"Can't set headers after they are sent.","referer":"https://<IP_ADDRESS>:8443/iapps/f5-appsvcs-templates/index.html","originalRequestBody":"{"code":500}","errorStack":[]}
if i just use AS3 to deploy the same thing, it works well (declaration attached)
simple_https_as3_declaration.txt

Looking into this behavior, tracking internally in Jira as MYSTIQUE-85