Artifacts are no longer downloaded to a subfolder with the artifactName

When my pipeline used DownloadBuildArtifacts, those artifacts went into a new subfolder named artifactName in the downloadPath.
When switching to PublishPipelineArtifact, the artifacts go into downloadPath but not into a new subfolder.
This discrepancy should be documented. Since we have scripts looking for artifacts in a particular folder, those scripts fail to find a subfolder with the artifact name.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6d5753b5-d4e7-6696-0230-3595f632ba0e
Version Independent ID: 6d5753b5-d4e7-6696-0230-3595f632ba0e
Content: DownloadPipelineArtifact@2 - Download Pipeline Artifacts v2 task
Content Source: task-reference/download-pipeline-artifact-v2.md
Service: azure-devops-pipelines
Sub-service: azure-devops-pipelines-tasks
GitHub Login: @steved0x
Microsoft Alias: sdanie

Thank you for your feedback. We are migrating this issue to our new documentation feedback system, and closing this issue.
As we phase out GitHub issues for this repository, we encourage you to propose changes using public PRs or submit feedback through our updated control at the top of the page. For more information on our feedback systems, see https://aka.ms/contentuserfeedback.


The GrammarRecognizer of UnityEngine.Windows.Speech seems not to work within Unity 2020.3.6f1 and MRTK 2.6.1.

Describe the bug
The GrammarRecognizer of UnityEngine.Windows.Speech seems not to work within Unity 2020.3.6f1 and MRTK 2.6.1.
To reproduce
Steps to reproduce the behavior:

Make Unity Project / Switch to UWP
Add MRTK 2.6.1 , add Windows Speech Input Provider
Use XRSDK profil for HoloLens2 , Install XR Plugin
Make sure Microphone is enabled in Player Settings
TestClass:
`using UnityEngine.Windows.Speech;

public class test : MonoBehaviour
{
private GrammarRecognizer m_recognizer;
public GrammarRecognizer Recognizer { get => m_recognizer; set => m_recognizer = value; }
void Start()
{
    Recognizer = new GrammarRecognizer(Application.streamingAssetsPath + "/SRGS/test.xml");
    Recognizer.OnPhraseRecognized += Recognizer_OnPhraseRecognized;
    Recognizer.Start();
}

private void Recognizer_OnPhraseRecognized(PhraseRecognizedEventArgs args)
{
    Debug.Log("I recognized something");
}

void Update()
{
    if(Recognizer.IsRunning)
    {
        Debug.Log("Running");
    }
}

}`

Make simple SRGS XML File:

Name it test.xml and put it in the Assets/StreamingAssets/SRGS Folder
Hit Play and say "Player" .... Nothing happens
(No errors appear, the file is loaded correctly)

Expected behavior
The word player is recognized and in the Unity Editor  Debug.Log("I recognized something"); is fired
Your setup (please complete the following information)
Unity 2020.3.6f1 and MRTK 2.6.1.
Target platform (please complete the following information)

HoloLens 2

Additional context
Is it possible to register a huge amount of strings to the KeywordRecognizer? In my app the user says for example "bloodpressure 120 to 80" and other medical stuff, i need to get the numbers into TextLabels... If i have to register everything as one Keyword with all numbers that might be too much?? I don't know, if its no problem i will do it like that.

Hello, I'm also having a problem with UnityEngine.Windows.Speech namespace working with Windows Mixed Reality/OpenXR.
I'm actually not even using MRTK. Also my target platform is Standalone>Windows.  I'm building a VR training app with Unity 2020.3 and OpenXR.  I've added the Mixed Reality OpenXR plugins with the MS Mixed Reality Feature Tool.
In my app the UnityEngine.Windows.Speech KeywordRecognizer works perfectly EXCEPT when I have a WMR headset connected and WMR Portal running.
So it works in the editor, as a desktop app (without WMR headset), and it works running on Oculus Quest (via Link).
But if I use a WMR headset (test using both Reverb G1 and G2), it's as if the public event PhraseRecognizedDelegate OnPhraseRecognized from UnityEngine.Windows.Speech doesn't exist.
So I'm not sure if this is an issue with that namespace which is part of the UnityEngine.CoreModule.dll or has something to do with the Mixed Reality OpenXR plugin.  Or something else.
I've posted in the Unity Forum under the topic of VR as a potential bug.
My WMR VR OpenXR Desktop Unity App Speech Commands Don't Work on Headset

Hi @powerschaf, sorry for the delayed response. The issue you described seems to be a Unity bug. Could you file a bug with Unity by going to Help (in the Unity editor menu bar) → Report a bug... and post a link to the Unity Issue Tracker page once it's created so that the community can get updates on the bug? Thanks!
Regarding your need to register a large amount of strings for the use case you mentioned, besides using the grammar recognizer provided by Unity you could also leverage the Azure Speech SDK, which has support for Unity and pattern matching.

Hi @jasonhbartlett, looking at the link you posted the issue seems to be tracked by both the Unity forum post and a OpenXR sample repo issue, so please rest assured the issue you are seeing is being handled by the right people.

We appreciate your feedback and thank you for reporting this issue.
Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.
Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.
Please note that MRTK3 was released in August 2023. It features an all-new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visit https://www.mixedrealitytoolkit.org.
Thank you for your continued support of the Mixed Reality Toolkit!


req.path computed improperly

Describe the bug
For a route like this:
app.get ( '/:format?/:uml?', async ( req, res ) => {} );

Queried like this:
http://localhost:3000/svg/SyfFKj2rKt3CoKnELR1Io4ZDoSdd0W00

I'm getting the following path inside the route handler:
'/SyfFKj2rKt3CoKnELR1Io4ZDoSdd0W00'

Which isn't corrent, it should instead be:
'/svg/SyfFKj2rKt3CoKnELR1Io4ZDoSdd0W00'

probably that line to support subapps mounting on routes breaks the rest of routes ... I need to come up with a better solution


fix: set context of basic example to __dirname

Summary

Related issue (if exists)

Types of changes

[ ] Docs change / Dependency upgrade
[x] Bug fix
[ ] New feature / Improvement
[ ] Refactoring
[ ] Breaking change

Checklist

[ ] I have added changeset via pnpm run changeset.
[ ] I have added tests to cover my changes.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

fix #2344

can you sign the cla


enable null blob connection for public blob storage

What does this PR do?

add test for null blob connection string, interpret that to be a public account
change UI so that nothing appears in the SAS token expiration area if public account
change auth to blob storage so an empty sas token is accepted
fix the makefile target "run-plugins"
test empty sas token with the gnuradio/iqengine test
add test for existing sas token with daniel esteves container

All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you successfully ran tests with your changes locally? Including container validation.
[x] Have you lint your code locally prior to submission?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Have you labelled this PR correctly? E.G. major, milestone, breaking, breaking-change, minor, feature, enhancement, patch, fix, chore, refactor etc

Changes to Core Features:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your core changes, as applicable?

Looks great!


28.8_pprof

Added pprof
Describe your changes
Issue ticket number and link
Checklist

[ ] Is it a bug fix
[ ] Is a typo/documentation fix
[ ] Is a feature enhancement
[ ] It is a refactor
[ ] Created tests that fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: mlsmaycon:white_check_mark: hurricanehrndz:x: adam-skalickyYou have signed the CLA already but the status is still pending? Let us recheck it.


chore: remove string-format-obj

Codecov Report

Merging #75 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   98.82%   98.82%   +<.01%
==========================================
  Files          14       14
  Lines        2727     2728       +1
  Branches      156      156
==========================================
+ Hits         2695     2696       +1
  Misses         19       19
  Partials       13       13

Impacted Files
Coverage Δ

src/logger.ts
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c71afd...02df40c. Read the comment docs.


Memory usage improvements

Summary

Defer buffering objects to the GPU until they're actually used in a pending frame
Use indexed buffers to hold ordering curve
Don't draw cones when cone_scale is 0 (PrepareOrderingCurves() uses Arrow3 to draw the no-arrow curve)

With these changes, I get around 0.97GB of memory usage for the command in #236, which puts us almost at where we were at version glvis-4.0.
Things to try:

[x] Remove second texture coordinate - this should drop us down from 32 to 16 bytes/vertex when storing VertexTex due to alignment
[x] Defer generation of element/vertex/edge numberings until they're toggled on - now 0.72GB

@kanye-quest, the current failure is not due to that, but you probably want to merge master for its macos CI fixes

Should we mention it in CHANGELOG?

@v-dobrev and @tomstitt -- can you please review when you get a chance?


initial init of painting room

you can paint red!! in the paint room!! whole lotta red!!!🧛🧛🩸🩸🩸

I love PLAYBOICARTI SO MUCH XD


Incorrect skin shown for user.

Should be

https://lapitar.lapis.blue/skin/khazhyk

21:10 Aesen:
minecrell: any idea why this is happening? https://github.com/LapisBlue/Lapitar/issues/7
21:10 Aesen:
I've checked the relevant Mojang API calls and they're correct
21:10 minecrell:
Lapitar's current cache is kinda eww
21:10 minecrell:
It's working fine but I never finished it
21:10 minecrell:
It's caching skins infinitely
21:10 Aesen:
ah

[22:27:33] <@minecrell> The temporary workaround would be to restart Lapitar
Fixed.


directives and LioN Directive Language (LNDL)

director class facilitate LLM dynamic action directive composition. It render LNDL (written by LLM) translate to callable function and submit to action manager for invoke

the directive folder will contain the following:

directive -> syntax and guides on letting LLM write LNDL
director -> render LNDL to callable object
script engine -> used by director for rendering and parsing
templates -> various established abstracted rules for director to use


[iOS] Undefined symbols for architecture arm64: "_RCTSetLogFunction"

Hello,
I have this linking error:
Undefined symbols for architecture arm64:
"_RCTSetLogFunction", referenced from:
-[PropertyFinderTests testRendersWelcomeScreen] in PropertyFinderTests.o
When i try to compile the default project on iOS. (using react-native init)

If anything broke this it might have been my commit: https://github.com/facebook/react-native/commit/19f922aa806b027348d9243b0085126fe553e266
@ide @kmagiera Are you hitting this as well? My Xcode is unfortunately busted, reinstalling now.

If anything broke this it might have been my commit: https://github.com/facebook/react-native/commit/19f922aa806b027348d9243b0085126fe553e266
@kmagiera @brentvatne @ide Are you hitting this as well? My Xcode is unfortunately busted, reinstalling now.

@javache is in London and it's quite late here. Can you unblock yourself by commenting out the test code until we can repro?

@javache is with me at @scale conf in SJ, he promised to take a look

Awesome, thank you @kmagiera and @javache!

Just did react-native init MyAwesomeApp and the app builds from Xcode and runs on an iPhone 6 simulator. What device are you using?

@Javanaise - which version of Xcode? Only 6.3+ are supported

@mkonicek A real iphone 6
@brentvatne 6.4

@Javanaise - try pressing ⌘+k to clean the build and run it again

@brentvatne did a Clean and a Clean build folder, still fails

@Javanaise - have you tried in the simulator?

@brentvatne it's working in the simulator

@Javanaise - what OS?

Same problem on iphone 6 ios 8.3. It is working on the simulator.

Also what simulator? Make sure it's 5s or newer which runs the x86_64 libs.

@brentvatne os x ? 10.10.5
@ide I used iphone 6 for the simulator, and it built.
I only have a problem with both my iphone 6 (and 5) real phones.

The same problem
iPhone 6
iOS 8.4
OS X El Capitan 15A282b

Compiling fine for me (even after cleaning) w/actual iPhone 6, Xcode 7 GM, El Cap beta 8. Wonder if Xcode is the issue here...

Also same problem
iphone6 plus
ios 8.4.1
OSX 10.10.5

Same here,
Xcode 7 GM
iphone6
ios 8.4.1
OSX 10.10.5
fails only on real device.
as a quick workaround, removing tests makes this go away

I can repro this when building the SampleApp for testing for iPhone 6 using Xcode 7 GM. Investigating.

The problem seems that Xcode's dead code stripping removes the RCTSetLogFunction, since it's not being called anywhere. Disabling "Dead Code Stripping" from your main target's build settings will disable the build error.
This method was changed in https://github.com/facebook/react-native/commit/b998e5a7b74905b30b1137a02e14cd5e6f97fccc

i have some error,but only remove test target,it's ok!

The solution @javache provided worked for me after encountering this error running on a physical device from Xcode 7 after to React Native v0.11.0. Thanks for opening this issue @Javanaise!!

Disabling "Dead Code Stripping" let me run on my physical device.
Thanks @javache!

Same issue here. In my case, this is caused by missing 'libReact.a' in the AwesomeProjectTests link path.
Symptom
Fresh 'react-native init AwesomeProject'. Load it with Xcode and build failed at AwesomeProjectTest target for iphone device with the errors:
"_RCTSetLogFunction", referenced from:
-[AwesomeProjectTests testRendersWelcomeScreen] in AwesomeProjectTests.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
This is because libReact.a is not at the 'AwesomeProjectTests' target build Phases -> 'Link Binary With Libraries'
Workaround
Manually add libReact.a to 'AwesomeProjectTests' target 'Link Binary With Libraries'.

Open Xcode project page.
Select Targets->"AwesomeProjectTests"
Select 'Build Phases'-> 'Link Binary With Libraries'
Press '+' to add item.
Select 'Workspace'->libReact.a, hit 'Add'
Rebuild the project, and build succeeded.

<EMAIL_ADDRESS>Xcode Version 7.0 (7A220)
iOS: 9.0 (13A344)

same issue here,
the solution of @javache works for me too.

I didn't try the dead code stripping but the solution by @bidatacoder worked fine for me. Thanks :)

How do you disable 'Dead Code Stripping', I'm new to Xcode unfortunately, and am having the same problem.

@jonolock91, you can get to the build settings by clicking on the main xcodeproj file (the one with the blue icon) in the sidebar. There will be a search bar in the now-opened build settings pane so you can start typing "Dead code stripping" to filter out the other settings. Expand the Dead Code Stripping setting and change debug to NO.

@tealtail thanks for the help, that has now worked for me too! :)

Thanks @bidatacoder

Dead Code Stripping trick worked for me.

+1 Dead Code Stripping

Dead Code Stripping trick worked for me as well. :+1: @tealtail

Dead code stripping worked for me.

+1 Dead Code Stripping

Dead code stripping worked for me, too.

Was having the same issue. @javache's solution worked for me. Thanks, appreciate it!!

+1 here, @javache's solution worked for me too. Big thanks!

+1 on @javache solution

+1 Dead Code Stripping

meet this too

Yes, "dead strip trick" works for me too.
But, how could I give up "dead strip" which is a crucial feature for an app?
@bidatacoder  your workaround seems not working :(

checkout ur net-work, try to connect ur mac with proxy and change the localhost of jsCodeLocation to ur ip

why is this issue closed?  this is obviously still an issue.

having to do a "dead trick" or "workaround" does not constitute this issue from being resolved, at least I don't think it should be.

Setting Dead Code Stripping to no worked for me. Thx

+1 on @bidatacoder's solution, allows me to keep dead code stripping as YES and still create a successful release build.

+1  for @bidatacoder's solution. I had the exact same issue detailed above.

I'm seeing this error and I had Dead Code Stripping set to NO. Any other ideas?

+1 Thank you for @tealtail's solution. It worked.

@bidatacoder's solution worked! https://github.com/facebook/react-native/issues/2685#issuecomment-142137371
Thanks!

Is "set Dead Code Stripping to No" or @bidatacoder solution better ?

@Mokto - I believe bigdatacoder's solution is better as it allows the app to strip out unneeded code from the build.
via Apple's docs

For statically linked executables, dead-code stripping is the process of removing unreferenced code from the executable file. If the code is unreferenced, it must not be used and therefore is not needed in the executable file. Removing dead code reduces the size of your executable and can help reduce paging.

Disable Dead Code Stripping in the build setting fix my issue. Thanks @javache

'Dead code Stripping' Disabling fixes this issue, Thanks @javache.

If I remove 'Dead Code Stripping' on the release build, will I have logs when I submit my app to iTunes connect?
I tried to use @bidatacoder's method, but I do not see libReact.a as a library that I can add.

For anyone poking with this and having issues with the @bidatacoder's method:
You have to select the TESTS target (that is <AppName>Tests) and add the libReact.a there, not your actual app's target, which has the libReact.a already!

@avioli @bidatacoder Thanks! This works better than turning down dead code stripping!

Just in case someone is doesn't know how to add the extra configuration mentioned by @avioli, in Xcode:

Select your the test target <AppName>Tests

Select Build Phases

Under Link Binary with Libraries, click the + icon and then add libReact.a. Then build again.

Should work. Thanks @avioli

Could you submit a pull request that changes the project generator to do this by default? Thanks!

I had the same issue. However, it was caused by renaming the app. I fixed it by doing a project wide search and replacing all occurrences of the name. I also had to change a few directory and file names.

Same Issue here but adding libReact.a to my test target do the trick! :)

Same issue and disabling Dead Code Stripping didn't solve the problem whereas @bidatacoder solution worked fine for me 👍

I'm encountering this issue, but disabling Dead Code Stripping did not work, and libReact.a is already included in my Link Binary With Libraries. Anyone other ideas?

HI,
I have the same problem but
-it says architecture i386 instead of arm64
-it only happens when i choose iphone 5/4s simulators; other version such as 5s/6/6s don't have the problem
I tried the dead code stripping and add libReact.a to TESTS, both of them are not working for me.
Have anyone had the same problem?

For anyone having this problem, make sure you add the -lc++ flag to your <AppName>Tests target and not your normal target (where it probably already exists.)

@zdol Tests has no 'Other Linker Flags' option

In Build Settings All, I found that option, and after add -lc++ flag, it works! Thank you @zdol !

@czl1378 it's work for me thanks

Here is a screenshot, thanks @czl1378

I have been struggling with this for a while after upgrading to rn0.39, and the answer @czl1378 and @benjaminb10 is correct. you need to add other linker flags.

+1 -- Adding the flags fixed the build errors for me on 0.40.0

@benjaminb10 +1 adding that flag fixes the issue

Under Link Binary with Libraries, click the + icon and then add libReact.a. Then build again.

For me, vice versa, removing libReact.a helped me and my tests and my app runs both on simulator and device.

I'm using CocoaPods 1.2.0 and React Native 0.42.0. When I try to archive a release build, the error occurs.
It seems that your solutions won't work in my situation. Any ideas?

@bidatacoder 's solution didnt work for me :-( I don't have 'Workspace'->libReact.a ... the closest I have is libcxxreact.a
Any ideas?


Multiple cuts fail in the drawing API

Below code produces solid disk, but commenting out either .cut produces a disk with a hole.
function main({drawCircle}) {
 return drawCircle(10)
   .cut(drawCircle(2).translate(5, 5))
   .cut(drawCircle(1))
   .sketchOnPlane('XZ')
   .extrude(5)
}

Visualizer draws edges where openings are supposed to be, but they appear to be filled.
A bigger example:

  return [
    drawCircle(10),
    drawCircle(10).cut(drawCircle(2).translate(5, 5)),
    drawCircle(10).cut(drawCircle(2)).cut(drawCircle(2).translate(5, 5)),
  ].map((x, i) =>
    x
      .sketchOnPlane('XZ')
      .extrude(5)
      .translate(i * 25, 0, 25),
  )

Thanks, I found a solution, it is in a branch I will merge once I found a solution to the more complicated bug related to triangle fusion!

It should be fixed in 0.12.4 (and on the visualizer) - do you confirm?

Tested in 0.12.5 (latest as of today). Works as expected now!


load_mnist_dataset must include train_test_split

The train_test_split feature is not currently supported within the load_mnist_dataset. The user will have to call the split before calling the wrapper function.
It will be a better design to include the split within the function such that both the train and test datasets or Dataloaders are retrieved, split, and normalized with one function only. Another option could be to let load_mnist_dataset take an argument that mentions if the user is loading the train or test dataloader. To achieve this, logic inside the wrapper function must be split into two sub-functions or conditionals.
Ideas for better design are welcome.

Hey @SaashaJoshi  !
You can solve the issue by either:
Integrating train_test_split within the load_mnist_dataset function, returning both train and test datasets after splitting and normalizing.
Adding an argument to specify whether to load the train or test dataset, with the split and normalization handled accordingly.

Hi @Rajesh-1234567,
This is amazing! Feel free to open a PR whenever you are ready or ask any questions by tagging me.

Hi @Rajesh-1234567, any questions or updates?

hey @SaashaJoshi  i just wanna know is this issue still open and which all files are included(how can i recreate the bug)

Hi @sohamyedgaonkar, Sure go ahead. You can work on this since I haven't received any update on this yet.
This is not a bug per se but the wrapper load_mnist_dataset is a function that handles most of the data cleaning, including normalization and bathing. I was hoping we could also have a train_test_split in the wrapper as well so that a user doesn't have to split the dataset separately. Let me know if you have any questions.

hey @SaashaJoshi which files do you want to integrate it in ? (so that i can directly change some lines and pull a request

Hi, @sohamyedgaonkar Sorry for not looking at this message before. I would want you to integrate test_train_split as an argument in the load_mnist_dataset fucntion. I also mentioned this in the PR. Let me know if you would need any more help!


Use the Comment#generated_by_danger? method #trivial

Reduces knowledge about that particular string in the codebase

          1 Warning

:warning:
Tests were not updated

  Generated by :no_entry_sign: Danger

Cool, makes sense to me :+1:


chore: attempt to fix Example app on iOS

This PR attempt to fix iOS Example app build. So far I was able to fix XCode errors and build, however the Metro fails to build/detect the app right now. Further work and debug is required.
Changes included in this PR:

Swift bumped from 5.0 to 5.2 and target updated to iOS 11.0 (as described in Vision Camera Troubleshooting - https://mrousavy.github.io/react-native-vision-camera/docs/guides/troubleshooting/#ios)
removed tvOS targets from XCode Workspace
File.swift moved to the XCode Workspace
added missing babel-plugin-module-resolver dependency
updated used Vision Camera to fix on of XCode errors (usePixelAspecRatio)
regenerated Pods

Currently the example iOS app build correctly, but Metro fails to detect/build the React app inside.

Finally I was able to run the example app on the device. Besides the FrameProcessor error, which might be device specific, the example seems to work quite fine.
Preview

The error is now gone, here is the sample output from log:
2021-08-20 14:15:03.604379+0200 VisionCameraImageLabelerExample[11005:2264801] [javascript] 'Labels: ', [ { confidence: 0.7398267388343811, label: 'Pattern' },
  { confidence: 0.5818111896514893, label: 'Food' } ]
2021-08-20 14:15:03.967015+0200 VisionCameraImageLabelerExample[11005:2264801] [javascript] 'Labels: ', [ { confidence: 0.7398267388343811, label: 'Pattern' },
  { confidence: 0.5561060905456543, label: 'Food' },
  { confidence: 0.5026870965957642, label: 'Metal' } ]
2021-08-20 14:15:04.342708+0200 VisionCameraImageLabelerExample[11005:2264801] [javascript] 'Labels: ', [ { confidence: 0.696117103099823, label: 'Pattern' },
  { confidence: 0.6224076151847839, label: 'Metal' } ]
2021-08-20 14:15:04.669567+0200 VisionCameraImageLabelerExample[11005:2264801] [javascript] 'Labels: ', [ { confidence: 0.7111600637435913, label: 'Pattern' },
  { confidence: 0.5485353469848633, label: 'Metal' } ]

Amazing job @Simek! 🖤🖤🖤

it works pretty well if you just put a console.log but when try to set a state using runOnJS(setThing)(scannedThing);, app crashes immediately (only on IOS), it's seems to be a old bug related here https://github.com/mrousavy/react-native-multithreading/issues/21#issue-895003064


publish<EMAIL_ADDRESS>

Requested by: @bc-sentry
Merge target: (default)
Quick links:

View changes
View check runs

Assign the accepted label to this issue to approve the release.
Leave the #retract comment under this issue to retract the release (original issuer only).
Targets

[ ] docker[release]
[ ] docker[latest]
[ ] github

Targets marked with a checkbox have already been executed.  Administrators can manually tick a checkbox to force craft to skip it.

@bc-sentry Just curious, why is it being triggered?


Add dotnet MyGet package source

This should hopefully fix the restore issue we have seen with the last build attempt

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot


BAU Minor Refactoring

BAU Minor Refactoring
What

7e62443 - Usage of module.exports.<property-name> removed in favour of exports.<property-name>.
56235c0 - Usage of require(path.join(__dirname, '<file-path>')) removed in favour of require('<file-path>')

Why

The variable exports, when a module is instantiated is a shorthand reference to the exports property of the module. i.e. exports = module.exports = {}
require() in Node.js handles relative file loading by default so using `path.join(__dirname, '') is unnecessary.

More detailed why

It's generally considered better practice to:

use exports.<property-name> when assigning a property to be exported
use module.exports = <Object | Function> when exporting a single export.

Using require(path.join(__dirname, '<file-path>')) in JetBrains IDEs breaks automatic updates to file paths when moving files, meaning a developer has to manually update each instance of a file being imported into another module. This is exceptionally annoying, especially if you are attempting any sort of refactoring.

Closed as has now been assigned Jira issue


How to handle missing newline on the last line

@AlisCode writes:

My colleague and I are the original writers of aoc-runner, and we've noticed your recent release of aoc-parse. I personally love it, great work! I tried moving my parsing of this year's day 4 to it, and ended up with something like this :
#[derive(Debug)]
struct Assignment {
    one: RangeInclusive<usize>,
    two: RangeInclusive<usize>,
}

#[aoc_generator(day4)]
fn parse(input: &str) -> Vec<Assignment> {
    parser!(
        lines(
            a:usize "-" b:usize "," c:usize "-" d:usize
            => Assignment { one: (a..=b), two: (c..=d) }
        )
    )
    .parse(input)
    .unwrap()
}

I was slightly confused because it sounded to me like this should work, but I got an error saying the parser expected a \n and got an EOF instead. Reading the code, it does of course make sense : the "lines" parser fails as "incomplete" when the last line contains an EOF.
When using an automated tool such as cargo-aoc to retrieve your input, the lines parser won't work out of the box (e.g. my day 4 fails). Same thing happens when writing unit tests for the day's puzzle and copy-pasting things from the website to a static &str, e.g. for day 4 :
const INPUT: &'static str = "2-4,6-8
2-3,4-5
5-7,7-9
2-8,3-7
6-6,4-6
2-6,4-8"; // <- end of input here

Obviously I can fix this by adding a newline at the end of the input, and at the end of my downloaded input, but this doesn't feel like the right approach.
I do believe that the parsers should work out of the box when copy-pasting inputs, and I believe users of cargo-aoc, myself included, would be happy to add aoc-parse in their toolbox!
Do you see a different way of handling EOF that would make this work ?

I'm thinking about this. I should have some time to hack on it tonight, it's just a matter of deciding what to do...
The existing solution for aoc-runner users is a separate function, aoc_parse(), that re-adds the final newline if it's been stripped off (for example, aoc-runner strips trailing newlines here). The other purpose I had in mind for aoc_parse() was, once the error messages are better, I thought maybe I'd have it print pretty diagnostics and exit(), rather than return to aoc-runner.
Currently, every line(...) must end with a newline, and every non-empty lines(...), section(...) or sections(...) must end with a newline. But section(...) does have special treatment for EOF, so that it does not require an extra blank line at EOF. It might be possible to do something like that for line(), but I want to think it over carefully.
All puzzle inputs for 2021, and 2022 so far, end with a newline. I didn't check every year. Some one-line puzzle inputs for 2015 do not end with a newline.
I think the easiest thing to do would be:

Leave line() and lines() as they are.
In Parser:parse, add an extra newline to the source if there isn't one, but allow parses that don't match it.
Add #[doc(hidden)] to pub fn aoc_parse and remove all mention of it from the README for now. (But leave it there for anyone already using it.)

Now I'm thinking that it makes more sense to change line and section to support lines without '\n' at EOF, as @AlisCode suggested in the first place.

This is implemented in 0.2.11.

It was a few things.

Mostly I was worried that the change would cause bugs with line in other contexts, but it doesn't (—mostly. I think line(section(line("hello"))) now matches "hello" and "hello\n", which is nonsensical but isn't really hurting anything.)
Realizing that lots of good standard libraries are friendly, not strict, including Rust
Realizing that the problem exists because line exists, i.e. nom doesn't have to take a position on this, because it doesn't have a combinator called "line". This made it my responsibility. :)
Also the copy-and-paste use case. I think previously I had imagined the problem was limited to aoc-runner which meant not having to think too much about it.


Problems with Lexik\Bundle\TranslationBundle

Hi. When i install a2lix and Lexik\Bundle\TranslationBundle i have errors.
"The target-entity Lexik\Bundle\TranslationBundle\Model\TransUnitTranslation cannot be found in 'Lexik\Bundle\TranslationBundle\Model\TransUnit#translations'."
The problem occurs because a2lix/i18n-doctrine-bundle is injecting its own mapping information.
Is there any way to make itd compatible?

Having same issue. Did you find any workaround? @BigBazooka007

Hi all
Is this still the case ?


@keyup event fires late ONLY in iOS Safari

Reproduction
https://codesandbox.io/s/formkit-keyup-event-is-late-on-ios-tlvf0w
Describe the bug
I am building a complex currency swapping system with multiple inputs that change the values in the other inputs whenever one input is changed.
As such, I have to use @keyup to trigger methods rather than @input, or by watching data() values.
I've noticed that when firing the @keyup event in iOS Safari, it behaves differently than all other browsers.
In my CodeSandbox, you can see that a normal (non FormKit) input fires as expected and the value is shown in the alert.
FYI, I'm using the Options API inside of Vue3 for this.
EXPECTED:
When a keyup event fires, it should already have changed the data() value.
WHAT HAPPENS:
The value is not changed before the function is run, meaning data is 1 step out of phase. Again, this only happens on iOS and I haven't found it in other browsers or desktop environments.
TO REPRODUCE:
Open my CodeSandbox on iOS and input a number. For normal inputs, it will show in the alert. For FormKit inputs, it shows nothing until after the method is finished running.
https://codesandbox.io/s/formkit-keyup-event-is-late-on-ios-tlvf0w
Very bizarre.
Environment
• OS: iOS (iPhone XS)
• Browser: iOS Safari

iOS Version: 15.6.1
• FormKit Version: (I've tested on beta 9 and beta 10. Both have the issue)

Keep in mind that values are debounced in FormKit — they have a 10ms delay before the value is committed which in turn emit the v-model event. My guess is the browser/os debounce for a keypress is longer than that so you dont see this effect on desktop browsers. As a work around you could tap into the undebounced _value to get are more up to date reporting:
https://codesandbox.io/s/formkit-keyup-event-is-late-on-ios-forked-3krz9i?file=/src/App.vue
However, I want to gently push back that using @keyup is necessary for your use case. In fact, I think it might be an anti-pattern to perform state operations based on events rather than the state of your form. I wouldn't even recommend using the @input event. Ideally your entire form should be declarative, meaning the values of dependent inputs change based on the state of the form values changing rather than any particular events occurring. There are lots of things that can modify the state of a form other than keypresses and keyups that would cause your form to get out of sync if thats what it relied on.
So my suggestion would be to reconfigure the form a bit to use computed values or other reductive methods for setting dependent values.

⚡ You've got to be setting records for the fastest issue response team on GitHub. Always impresses me! ⚡
I'm definitely all ears to learn a better way of doing things, but am unsure of a way to use computed values to set inputs without it constantly overwriting them as I type.
Currently, I'm firing the event to calculate 2 of the 3 inputs at any one time, IE:
input 1 -> set 2 and 3
input 2 -> set 1 and 3
input 3 -> set 2 and 3
Do you think this is possible with computed values while also setting the inputs value at the same time
(without it overwriting as the user types a number)?
Here's the UI for reference:

FYI, I tried @input-raw (which avoids debounce) but that of course causes weird other side effects because it's firing events when its own state is changed by another event (which I think you were explaining above, but with Keyup there is no issue for the same flow).
Any possibility you'd be open to adding @keyup-raw similar to@input-raw?

I hear you, the thing is the @keyup event is the native event — we're not doing anything different there at all actually its just the the values themselves are debounced so your v-model is "slower" than a "native" v-model. Basically the existing @keyup is a @keyup raw. You can manually reduce that time by setting :delay="0". I haven't tested if that would do exactly what you need.
Maybe a computed property isn’t exactly what you need, but a watcher should be. Watch specific values individually and then update the pertinent dependency nodes (via node.input()). My concern with using @keyup for state is there are lots of other ways values can be entered that would not involve key up events being fired. Drag/drop of values, accessibility devices, direct node manipulation, initial hydrations etc etc.
To be clear, I'm 100% open to adding additional events or hooks if those make sense, but I'm not sure there is one that would directly solve your issue here, and I'm still holding out hope there's a reductive state solution to your problem 🤞

@justin-schroeder I understand completely, and I didn't know about :delay="0",
Just tested it (out of pure curiosity) and it DID in fact solve the issue, and is also in the docs so I guess I have only myself to blame.
On a side note, I thought about using watchers previously, but assumed it would trigger an infinite loop. Thinking about it again now, I can see how it should in fact work and at worst would trigger the same method twice when changing any one value (once when changed via v-model, once when the watcher catches that change, but not a third time as the second time should be the same final value, IE: no change to pick up on). I'll keep this concept in mind for the future.
Thanks again for your top level support and always-friendly comments ^^


Bug - : botCommands/points.js looking up a specific user currently broken

Complete the following REQUIRED checkboxes:

[x] I have thoroughly read and understand The Odin Project Contributing Guide

[x] The title of this issue follows the Bug - location of bug: brief description of bug format, e.g. Bug - points command: Extra whitespace causes command to not be called

The following checkbox is OPTIONAL:

[x] I would like to be assigned this issue to work on it

1. Description of the Bug:
While testing the new changes made to GET endpoints I noticed looking up a sepcific user using the !points @User and !points commands returns an error and produces no output. After further investigation i noticed that on Odon discord server that command is also broken, after digging into the code I think I know what is causing the issue and would like to fix it.
2. How To Reproduce:

use !points @User and !points commands on discord.
3. Expected Behavior:

A Points list of users or the author if no user IDs were provided.
4. Desktop/Device:

Device:
OS:
Browser:
Version:

5. Additional Information:

If it is to be done correctly, I need to make a change to the backend aswell to get a proper Query where I fetch the user's points + user's current ranking in the leaderboard.

Could anyone have a look at this from @TheOdinProject/odin-bot :) ?

As I mentioned here: https://github.com/TheOdinProject/odin-bot-v2/pull/366 I think we should consider removing this legacy command and replace it with a slash command if we proceed with having the user point retrieval as an option.
I could be a prompt like this

We have decided to keep a few legacy commands that are often used in sentences like this:

It would be best if you use the !question template

or

Below you will find some ways to share your !code

or

we don't support !windows
the below bot output should give you more information on how you can proceed

One of the good things about the slash commands is that they show up when entering a slash in the server, which is a great improvement compared to the old commands which people find out about when others use them or from scouring the bot repo.
I'd love to hear if other maintainers have some more feedback on the issue in particular. Perhaps there's a reason it's not working, or a deliberate decision made on it in the past. I've never seen that command in use to be honest.

I'm quite confident that it's not working because this particular command is very old and something about either the discord API, or the points-API changed.
it predates discord allowing us to do slash commands, which is the reason it's a legacy one.  I approve of fixing it and transitioning it to a slash command

@KevinMulhern @01zulfi I would like your opinions on this since it can potentially be an expansion of previous discussions with the API we had about fetching data. I can confirm the problem is not related to the API but the bot itself is calling a function with wrong parameters. A simple fix to the bot would fix the problem but it will only allow it to fetch the user's points which is not that powerful since all users can already see their points when anyone gives them a ++.
There are 3 approaches to the problem:

The first is I use the /api/points to fetch all the user's data and filter them in the bot to display the user's Rank + Points. The problem with this approach is that whenever the changes to /api/points ship, which limits the data received, the bot will break. Another problem is that the endpoint /api/points/{discord_id} will have no reason to exist and will just be dead code in the backend.

The second is to update the backend with a query that fetches the user's Rank in the leaderboard in addition to their points and returns it back to the calling request, here is what I came up with https://github.com/Mclilzee/theodinproject/blob/points-ranking/app/controllers/api/points_controller.rb#L9C3-L18C6

The third approach is just to fix the command to only show the user's current points. The problem with this approach is we need a better name for the command, as slash command /rank does not make sense anymore because there is no ranking involved. we could keep it as !points but that will be a clarity conflict with the new slash command /points

Thanks for detailed write-up @Mclilzee
Haven't had the chance to think things through, but here's my gut instinct.

We should definitely create & use /api/points/{discord_id}
We could leverage subcommands

/points about for general info on commands
/points rank for user's command
OR we could look at updating the leaderboard command somehow so user can get their own points easily as well

@01zulfi I like the idea of subcommands very much.
I think the best subcommand would be for leaderboard, I'm updating the leaderboard command to be a slash command as well since it going to be related.
My PR will be done shortly, then we can discuss further changes in there.


build a single packed bundle

need #37.

build a single redux-polyglot.js
make a minified version :

add minified.js at the root
build a redux-polyglot.min.js
update doc

What difference do you have in mind between minified.js and redux-polyglot.min.js ?

import { getP } from 'redux-polyglot/dist/redux-polyglot.min'

vs
import { getP } from 'redux-polyglot/minified'

same as https://github.com/Tiqa/redux-polyglot/blob/master/translate.js

Take a look here https://webpack.github.io/docs/configuration.html#output-librarytarget


Is it possible to add a multiprocessing argument?

We could split a csv into pieces of csvs and use twarc-csv for each of them. Or maybe we could use joblib's n_jobs to read CPU-thread number of blocks of Json lines. A server usually has multi-cores. Is it possible to add such a parameter?

Yes, (with an added requirement of keeping things in the same order as the json, as this helps downstream tools).
The process of generating CSVs is already "embarrassingly parallel" as it splits the data into chunks here: https://github.com/DocNow/twarc-csv/blob/main/csv_writer.py#L80 so that would be the best place for it.
Joblib would be nice. Will accept good PRs for this.


Helm Chart Example - AzureAppConfigurationProvider Resource

I'm looking to try out the AzureAppConfigurationProvider resource as part of a helm chart - does anyone have a working example that they could share please?
It would be a good example to have in the docs as well I think
Here's my scenario - I have an app in the src/MyWebApp folder, with a helm chart in src/MyWebApp/charts/my-web-app. Base settings are in the appsettings.json file, and for Dev config, a DevConfig.json file exists, and this is pushed to the Dev store via the pipeline task
I have helm overrides in each environment, so the resource will need to use the config relevant to each file/store
I hope that makes sense - I'm still trying to get my head around how this should be working
Thanks

Hi @thepaulmacca ,  you can

create a config folder and a json file like src/MyWebApp/config/appConfig.json.
add the JSON file to the configuration source by calling the AddJsonFile method. Such as builder.Configuration.AddJsonFile("config/appConfig.json");

When deploy the app in AKS, the ConfigMap generated by kubernetes provider can be mounted at the config path in a data volume and is consumable as a JSON file. More information can be found setup-the-app-configuration-kubernetes-provider.
In this way you can use helm override values for different environment, and the app will consume relevant mounted config file.
Let me know if you have any further questions or encounter any issues. Thanks.

Hi, thanks for coming back to me - something's not computing with me here. What if I have multiple files, like appConfig.Development.json, appConfig.Staging.json, appConfig.Production.json for example?

Your deployment would mostly looks like this
apiVersion: apps/v1
kind: Deployment
metadata:
  name: aspnetapp-demo
  namespace: mymapp-{{.value.label}}
  labels:
    app: aspnetapp-demo
spec:
  replicas: 1
  selector:
    matchLabels:
      app:  aspnetapp-demo
  template:
    metadata:
      labels:
        app:  aspnetapp-demo
    spec:
      containers:
      - name: aspnetapp
        image: myregistry.azurecr.io/aspnetapp:v1
        ports:
        - containerPort: 80
        volumeMounts:
        - name: config-volume
          mountPath: /app/config
      volumes:
      - name: config-volume
        configMap:
          name: configmap-created-by-appconfig-provider

Thanks for coming back to me @linglingye001 @RichardChen820 I'll give these suggestions a try - it'll click for me eventually 😅

Short answer is yes, you just ignore it.
The reason is that appsettings.json and appsettings.Development.json in the root directory could be recognized by asp.net by default. In most cases, people just leverage it, put settings in that two files. But in container (Kubernetes) case, we need to mount configuration file(s). Volume mount only supports mount entire path, means if the config file is in the root path, mount will lead to losing other files (pages, DLLs ), hence we have to create a dedicated directory for configuration and mount configuration files to that directory in container.

Got it, thanks @RichardChen820 I'm just trying this out

Sorry for not getting back to you sooner @RichardChen820 but I just cannot get this to work with a file in the config folder. I'm getting the below error
E0229 16:32:04.795531       1 appconfigurationprovider_controller.go:245] Fail to create the target ConfigMap or Secret of AzureAppConfigurationProvider 'appconfigurationprovider-example' in 'testing' namespace: ConfigMap "configmap-created-by-appconfig-provider" is invalid: data[config/appConfig.json]: Invalid value: "config/appConfig.json": a valid config key must consist of alphanumeric characters, '-', '_' or '.' (e.g. 'key.name',  or 'KEY_NAME',  or 'key-name', regex used for validation is '[-._a-zA-Z0-9]+')

Any ideas? Here's my current config if it helps
app-config.yaml template target
  target:
    configMapName: configmap-created-by-appconfig-provider
    configMapData:
         type: json
         key: appConfig.json

Helm values
volumeMounts:
  - name: config-volume
    mountPath: /app/config

volumes:
  - name: config-volume
    configMap:
      name: configmap-created-by-appconfig-provider

Any help would be appreciated - thanks

Are you sure this yaml is the one you are using when you see this error?
target:
    configMapName: configmap-created-by-appconfig-provider
    configMapData:
         type: json
         key: appConfig.json

From you error log, seems you were trying such yaml
 target:
    configMapName: configmap-created-by-appconfig-provider
    configMapData:
         type: json
         key: config/appConfig.json

Sorry for not coming back to you sooner @RichardChen820 - I seem to be halfway there with this config (my appConfig.json file is now in the root like the docs)
volumeMounts:
  - name: config-volume
    mountPath: /app/appConfig.json
    subPath: appConfig.json

volumes:
  - name: config-volume
    configMap:
      name: configmap-created-by-appconfig-provider
      items:
        - key: appConfig.json
          path: appConfig.json

My ConfigMap now mounts and I can see the correct values in it - but my screen is blank. I don't see any errors in either pod or provider logs though

Please be aware of the following two points:

appConfig.json is not default built-in configuration path of asp.net, if you'd like to follow this tutorial you need to use exactly the same configuration json file name appsettings.json
this tutorial uses subPath to mount a single file to the target directory. ButsubPath is not very recommended because a container using a ConfigMap as a subPath volume mount will not receive ConfigMap updates. (It's from Kubernetes official doc https://kubernetes.io/docs/concepts/configuration/configmap/#mounted-configmaps-are-updated-automatically).

If you don't have requirement to dynamically get updated data from ConfigMap. You can just go ahead to follow that doc. If you want your app have the ability to hot load the updated configuration data without restart, that tutorial won't help, you need to follow this doc, create a dedicated config directory for configurations, and mount configMap to that directory.

Right ok thanks - that doc must have been updated recently as there was no mention of a config file before
I'll give things another go, thanks

Feel free to let us know for any more questions.

Thanks, appreciate your help with this. I'll close and re-open if any issues


New extension HStream.moe

HStream.moe
Supported qualities 720p, 1080p and 4k

HStream.moe Supported qualities 720p, 1080p and 4k
First time using GitHub? How do I install?


(ENV200) Autoware installation on ENV200

Install our fork of Autoware on the van

@SiddyG8

11-01-2023
Van is dead. Does not want to turn on.

Latest autoware installation works with docker, Amir managed to get it working: https://github.com/Monash-Connected-Autonomous-Vehicle/autoware/issues/33#issuecomment-2101874724


Require SFML 2.6

Even though ImGui-SFML doesn't technically need SFML 2.6, we ought to update this library in lockstep with SFML for the sake of giving developers a consistent experience between this library and SFML. I tried to find all the places we're referring to 2.5 and upgrade them.
What else do we need to do before we can release v2.6?

What else do we need to do before we can release v2.6?

I guess it's good enough. Other things can be done/fixed in v2.6.x and breaking changes in 3.x.x, I guess

What else do we need to do before we can release v2.6?

I guess it's good enough. Other things can be done/fixed in v2.6.x and breaking changes in 3.x.x, I guess

Sounds good. What is the release process? Is it as simple as cutting a tag, updating the CMakeLists.txt project version, then creating a new release in GitHub? If so then I'm happy to do that myself.

This pull request just drops support for SFML 2.5. Which is a significant loss that should have strong justification. Unfortunately the justification written in the description doesn't seem sufficient to me. We really don't have to update everything in lockstep. Releases of imgui-sfml at many points supported several versions. SFML 2.5 here was more of an exception that it was the only supported version for some time. And the fact that the latest release of both sfml and imgui-sfml was named "2.5" was actually also a coincidence.
imgui-sfml received several improvements, and we really shouldn't arbitrarily gatekeep those improvements just to SFML 2.6. So if this change is decided to merged, a release of imgui-sfml should be made before that.

This is a good pull request for when we decide to drop SFML 2.5 support, but as I said I think we really don't need to do that at the moment. We should just add both 2.5 and 2.6 to CI.


Add svelte 5

Add support for svelte 5

Thanks for your work on this! We may need someone with more Svelte experience to review 😅
cc @pedroborges - do you have anytime to give this a look?

Hey @renatomoor, just giving some thoughts here. Let me know if they make sense or if I'm misunderstanding anything.
I think the goal would likely trying to get it closer in resemblance to the React or Vue versions. The biggest difference I can see is how you aren't using the resolveName in the validate method. Is there a reason for that?
Additionally, I think the submit method should be async to match other versions.
This one might be nitpicky, but I don't think the getters for the end of the form function are needed, no? The get validating() function could just be passed in as a parameter? Then in use, it would be $form.submit() or {$form.errors.name} for example.
Lastly, I think the hasErrors being the new $derived rune from Svelte 5 makes sense since it would be derived from the errors value?
Something like:
const hasErrors = $derived(Object.keys(errors).length > 0)

Let me know if that all makes sense!

Hello @joshcirre, Thanks for the feedback!
Great catch on resolveName and submit. I've fixed those.
Regarding the getters, they’re part of the new approach in Svelte 5 for getting reactive values from outside Svelte components, as the Svelte team explained here: https://svelte.dev/blog/runes#beyond-components.
I initially started using $form while working on the PR with Svelte 4. However, with Svelte 5, there’s no need to prefix reactive variables with $. My idea was to make it similar to other frameworks like Vue and React:

Validating: {form.validating}
Processing: {form.processing}
hasErrors: {form.hasErrors}

<Form.Input
    bind:value={form.data.name}
    error="{form.errors.name}"
    label="Name"
    name="name"
    on:change={() => form.validate('name')}
    placeholder="Name"
    required
    type="text"
/>

<Button on:click={() => form.submit()} type="submit">Register</Button>

As for hasErrors, the other packages for Vue and React don’t use computed properties but instead rely on a simple reactive variable. So, I kept it consistent with those frameworks.
That said, this is actually my first time working with Svelte 4 or 5, so please let me know if there’s anything else to check!
I’ve been testing it in SvelteKit, and it’s working fine, though I’m sure there could be further improvements. I considered using {form.name} instead of {form.data.name}, but I encountered multiple errors when trying to implement it, so I stuck with the React approach by using .data.

Hey @renatomoor,  makes perfect sense! I like the changes, and I agree that while it might make sense from a Svelte-ish syntax to use $derived, I do agree that keeping it as similar to the React/Vue implementations is best, and I think these changes fall in line with that.
I just tried it out in a SvelteKit project and it works great!
(I also like the .data approach just for consistency sake)

Hey @taylorotwell, I can test this out and provide a full review over the weekend. Started at a new job this week and have been pretty busy 😃
@renatomoor and @joshcirre, I have a proof of concept for the Inertia.js Svelte adapter using Svelte 5 that I'm not ready to share just yet. This PR aligns with my direction by utilizing one $state per property 💯 But instead of making the data property publicly accessible, I’ve added getters and setters for each data property on the form object, allowing usage like:
let form = useForm('post', {
    name: '',
    email: '',
    password: '',
    password_confirmation: '',
})

console.log(form.name)
console.log(form.email)
console.log(form.password)
console.log(form.password_confirmation)

This approach keeps consistency with the current Svelte adapter. If want to give it a shot:
const form = {
  data() {
    return $state.snapshot(data) as TForm
  },

  // ...
}

// Define "data" getters and setters on "form"
(Object.keys(data) as Array<keyof TForm>).forEach((key) => {
  Object.defineProperty(form, key, {
    get() {
      return data[key]
    },
    set(value: TForm[keyof TForm]) {
      data[key] = value
    },
  })
})

return form

I agree with @joshcirre on using $derived for hasErrors, that's exactly what I'm doing. I’ll test this out and share any further feedback soon. Looking forward to everyone’s thoughts 😉

I noticed Inertia.js isn’t included in this PR. @renatomoor are you familiar with Inertia.js and able to add the adapter as well? If not, no worries. I can take care of it after your PR is merged.
Thanks again for your awesome work!

@pedroborges thanks for the comments!
I'll take a look at all today.
I did not had time during the weekend but this week I should have some hours free to work on this.

hey! @pedroborges @joshcirre.
I just did the repo to test laravel precognition with svelte kit: https://github.com/renatomoor/sveltekit-precognition
Later today I'll implement the changes that you both requested.

I'd like to see the Inertia version here before we look at merging this.
The API decisions made here should be based the Inertia Svelte adapter. If we implement this version first and then find out there are inconsistencies in the Inertia version, that is gonna be annoying to maintain.

Would anyone be kind enough and have time to spin up a bare bones svelte project with a basic form for me to test this out in? Even if it is just the front-end component. I can handle the Laravel side of things if that helps.

Hello @timacdonald!
I did that already here https://github.com/laravel/precognition/pull/104#issuecomment-2459220426.
I'll see if I can do tomorrow or the day after the inertia part. 😉

You rock ❤

@timacdonald or @pedroborges, Is there a repo with inertia and svelte 5 ?
I've worked with inertia and vue + precognition in the past but never with svelte, so if you can guide me a little bit here would be nice!

@renatomoor Here you go: https://github.com/pedroborges/laravel-breeze-svelte

Thanks @pedroborges, I saw your package a few days ago, but I have not had the time yet to develop the inertia part this week.

Add svelte-inertia too, please.


Climber

DO NOT MERGE
Could I get a review please? I was told that having too many inputs will slow down the robot, but I'm not sure what the limit is. There are errors in climber java that can be ignored since I haven't worked on it yet.

closing; new PR for new climber


🐛 Fixed "Someone else is editing" errors showing when no-one else is editing

closes https://github.com/TryGhost/Ghost/issues/8969
Collision detection errors were appearing incorrectly because the save routines in the post settings menu bypass the sequential saves in the main editor controller and so are prone to having stale data if a previous save is still in progress.

added a new savePost task that is part of the saveTasks group so that all post saves are sequential
pass the savePost task to the {{gh-post-settings-menu}} component
use savePost task in gh-post-settings-menu instead of calling save() directly on the model instance

Note: See https://github.com/TryGhost/Ghost/issues/8969 for local reproduction steps.

Cool! Will review tomorrow morning 👍

Wasn't able to find a problem with this change. Feel free to self-merge for the release later 👍

Ugh, I really need to fix that test which consistently randomly fails on Travis 😞

Coverage decreased (-0.007%) to 73.134% when pulling 93b34d148f9d1ec2c995ea096b5df4216939c64e on kevinansfield:but-no-on-else-is-editing into 491b498f09e634ed98a177e95f6292d1f7482ad3 on TryGhost:master.


Increment version for attestation releases

Increment package version after release of com.azure.resourcemanager azure-resourcemanager-attestation

/azp run java -attestation - ci

/azp run java - attestation - ci


refactor(deploy): re-structure command code

:tada: This PR is included in version 4.2.2 :tada:
The release is available on:

v4.2.2
GitHub release

Your semantic-release bot :package::rocket:


Auto picked kernel after running 'Connect to Github' is .NET

Testing #150738
Was testing with a python notebook.
I pick 'Connect to Github' and it ends up picking .NET as the suggested kernel.
This is likely a jupyter-extension issue though.

The core only checks which kernel is currently the suggested/preferred one, we might need to check why it's not suggesting the right one.


MM-22874 - Updating user popover css

Summary
MM-22874 - Updating user popover css
Ticket Link
https://mattermost.atlassian.net/browse/MM-22874
Screenshots

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-5013.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

Test server destroyed


fix: postinstall echo on windows

closes  #3985
looks like echo with \n is failing in postinstall script on windows.
In windows 10 it's not crashing but it's not writing the second line:
$ npm run postinstall

><EMAIL_ADDRESS>postinstall D:\projects\swiper\package
> echo "Love Swiper? Support Vladimir's work by donating or pledging on patreon:
 > https://patreon.com/vladimirkharlampidi
"

"Love Swiper? Support Vladimir's work by donating or pledging on patreon:

On Windows NT and probably other old windows versions its crashes.
echo ** & echo ** should work fine on both platforms I think.

Don't merge this yet. Looks like this isn't solving the problem.
https://github.com/nolimits4web/swiper/issues/3985#issuecomment-742721434

As echo didn't work, I thought that the best cross-platform here is NodeJS console.log()
First I made inline script:
"postinstall": "node -e \"console.log('\u001b[35m\u001b[1m','Love Swiper? Support Vladimir\\'s work by donating or pledging on patreon:');console.log('\u001b[22m\u001b[39m\u001b[32m','> https://patreon.com/vladimirkharlampidi');\""

but that's how it looks like in output, the message kind of duplicated (echo looks the same way by the way):
><EMAIL_ADDRESS>postinstall D:\projects\swiper\package
> node -e "console.log('','Love Swiper? Support Vladimir\'s work by donating or pledging on patreon:');console.log('','> https://patreon.com/vladimirkharlampidi');"

 Love Swiper? Support Vladimir's work by donating or pledging on patreon:
 > https://patreon.com/vladimirkharlampidi

So I thought it will be cleaner to move it into postinstall.js. Looks much better as for me:
><EMAIL_ADDRESS>postinstall D:\projects\swiper\package
> node ./postinstall.js

 Love Swiper? Support Vladimir's work by donating or pledging on patreon:
 > https://patreon.com/vladimirkharlampidi

So I thought it will be cleaner to move it into postinstall.js. Looks much better as for me:

Makes sense to put postinstall.js, but will it run properly as it is installed as dependency and maybe it will try to look file in CWD (e.g. in project root that uses Swiper and not in swiper package itself), this needs to be checked

<EMAIL_ADDRESS>node-sass does the same.
Pretty sure it means its ok

Ok, let's go with this way then

@vltansky didn't we decided to go with node script here? 😄

@nolimits4web I was sure that this is what PR includes. Now I got why you didn't merge it after you told OK...
a merge from master overrode all the changes.
I'll make a new PR now with the relevant code.
Sorry about that. Will be more careful.


Hyprland Crashes on Startup When Attempting To Load split-monitor-workspaces

Hyprland Crashes With Seg Fault When being started with split-monitor-workspaces through hyprload

Crashing began after recent update
Receives "Getting Dispatcher!" and failure to start Xwayland in terminal
hyprland crash report log has  [LOG]  [hyprload] Loading plugin: split-monitor-workspaces.so as last action before crash
Hyprland launches without issue when hyprload not auto started

Should close this issue or #21
Also facing the same issue.
My Crash Report

See this issue: https://github.com/Duckonaut/split-monitor-workspaces/issues/16

I looked through the log and seem to have a similar or even same issue
This happens seemingly on the latest git release of hyprland
--------------------------------------------
   Hyprland Crash Report
--------------------------------------------
I tried so hard, and got so far...

Hyprland received signal 11 (Segmentation fault)

Version: a9b8e2159c2813a6951d0b0186fbb7f2f8554d3e
Tag: v0.27.2-54-ga9b8e215

Hyprland seems to be running with plugins. This crash might not be Hyprland's fault.
Plugins:
	 ()

System info:
	System name: Linux
	Node name: artixbox
	Release: 6.2.11-273-tkg-pds-llvm
	Version: #1 SMP PREEMPT_DYNAMIC TKG Mon, 17 Apr 2023 23:21:17 +0000

GPU:
	01:00.0 VGA compatible controller [0300]: NVIDIA Corporation TU104 [GeForce RTX 2070 SUPER] [10de:1e84] (rev a1) (prog-if 00 [VGA controller])

os-release:
	NAME="Artix Linux"
	PRETTY_NAME="Artix Linux"
	ID=artix
	BUILD_ID=rolling
	ANSI_COLOR="0;36"
	HOME_URL="https://www.artixlinux.org/"
	DOCUMENTATION_URL="https://wiki.artixlinux.org/"
	SUPPORT_URL="https://forum.artixlinux.org/"
	BUG_REPORT_URL="https://bugs.artixlinux.org/"
	PRIVACY_POLICY_URL="https://terms.artixlinux.org/docs/privacy-policy/"
	LOGO=artixlinux-logo

Backtrace:
	#0 | Hyprland(_ZN13CrashReporter18createAndSaveCrashEi+0x779) [0x557140c6cee9]
		??
		??:0
	#1 | Hyprland(_Z25handleUnrecoverableSignali+0x40) [0x557140c04c40]
		??
		??:0
	#2 | /usr/lib/libc.so.6(+0x38f50) [0x7f86be051f50]
		??
		??:0
	#3 | /home/rawhav0kk/media/builds/hypr/split-monitor-workspaces/split-monitor-workspaces.so(_ZNKSt12__shared_ptrI8CMonitorLN9__gnu_cxx12_Lock_policyE2EE3getEv+0xc) [0x7f86b4161c20]
		??
		??:0
	#4 | /home/rawhav0kk/media/builds/hypr/split-monitor-workspaces/split-monitor-workspaces.so(_ZNKSt19__shared_ptr_accessI8CMonitorLN9__gnu_cxx12_Lock_policyE2ELb0ELb0EE6_M_getEv+0x18) [0x7f86b4162cac]
		??
		??:0
	#5 | /home/rawhav0kk/media/builds/hypr/split-monitor-workspaces/split-monitor-workspaces.so(_ZNKSt19__shared_ptr_accessI8CMonitorLN9__gnu_cxx12_Lock_policyE2ELb0ELb0EEptEv+0x18) [0x7f86b4161b2e]
		??
		??:0
	#6 | /home/rawhav0kk/media/builds/hypr/split-monitor-workspaces/split-monitor-workspaces.so(_Z23mapWorkspacesToMonitorsv+0xd3) [0x7f86b415d615]
		??
		??:0
	#7 | /home/rawhav0kk/media/builds/hypr/split-monitor-workspaces/split-monitor-workspaces.so(pluginInit+0x294) [0x7f86b415df7b]
		??
		??:0
	#8 | Hyprland(_ZN13CPluginSystem10loadPluginERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE+0xadd) [0x557140d109fd]
		??
		??:0
	#9 | Hyprland(_Z14dispatchPluginNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE+0x110) [0x557140c78410]
		??
		??:0
	#10 | Hyprland(_Z8getReplyNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE+0x5b7) [0x557140c79897]
		??
		??:0
	#11 | Hyprland(_Z13hyprCtlFDTickijPv+0x165) [0x557140c7a575]
		??
		??:0
	#12 | /usr/lib/libwayland-server.so.0(wl_event_loop_dispatch+0xa2) [0x7f86be9e0ae2]
		??
		??:0
	#13 | /usr/lib/libwayland-server.so.0(wl_display_run+0x27) [0x7f86be9e12d7]
		??
		??:0
	#14 | Hyprland(main+0xab6) [0x557140bf48d6]
		??
		??:0
	#15 | /usr/lib/libc.so.6(+0x23790) [0x7f86be03c790]
		??
		??:0
	#16 | /usr/lib/libc.so.6(__libc_start_main+0x8a) [0x7f86be03c84a]
		??
		??:0
	#17 | Hyprland(_start+0x25) [0x557140c04ae5]
		??
		??:0

Log tail:
[LOG] GlobalShortcutsManager bound successfully!
[LOG] ToplevelExportManager bound successfully!
[LOG] ScreencopyProtocolManager bound successfully!
[LOG] [wl res 557143e425d0] created
[LOG] [wl res 557143e425d0] set impl to 557140d9fc20
[LOG] [wl res 557143e46ad0] created
[LOG] [wl res 557143e46ad0] set impl to 557140d9fc10
[LOG] [wl res 557143e42420] created
[LOG] [wl res 557143e42420] set impl to 557140d9fc10
[wlr] [types/wlr_compositor.c:688] New wlr_surface 0x557143e470c0 (res 0x557143e46c00)
[wlr] [types/xdg_shell/wlr_xdg_surface.c:373] new xdg_surface 0x557143e47760 (res 0x557143e47870)
[LOG] New XDG Surface created. (class: (null))
[LOG] Registered signal for owner 557143e47b10: 557143e473a0 -> 557143e47b78 (owner: XDG Window)
[LOG] Registered signal for owner 557143e47b10: 557143e47810 -> 557143e47c48 (owner: XDG Window)
[wlr] [types/wlr_compositor.c:688] New wlr_surface 0x557143e48fb0 (res 0x557143e49360)
[wlr] [types/wlr_xdg_decoration_v1.c:221] new xdg_toplevel_decoration 0x557143e49480 (res 0x557143e49560)
[LOG] Registered signal for owner 557143e47b10: 557143e4ff40 -> 557143e48128 (owner: Toplevel)
[LOG] Registered signal for owner 557143e47b10: 557143e4ff50 -> 557143e48190 (owner: Toplevel)
[LOG] Registered signal for owner 557143e47b10: 557143e4ff60 -> 557143e480c0 (owner: Toplevel)
[LOG] Registered signal for owner 557143e48330: 557143e473d0 -> 557143e48338 (owner: CWLSurface)
[LOG] CWLSurface 557143e48330 called init()
[LOG] Registered signal for owner 557143e47b10: 557143e473b0 -> 557143e47be0 (owner: CWindow)
[LOG] Searching for matching rules for Alacritty (title: Alacritty)
[LOG] Set keyboard focus to surface 557143e470c0, with window name: Alacritty
[LOG]  [hookSystem] New hook event registered: activeWindow
[LOG] Window got assigned a surfaceTreeNode 0
[LOG] Registered signal for owner 557143e47b10: 557143e47390 -> 557143e47b10 (owner: XDG Window Late)
[LOG] Registered signal for owner 557143e47b10: 557143e47a50 -> 557143e47cb0 (owner: XDG Window Late)
[LOG] Registered signal for owner 557143e47b10: 557143e47830 -> 557143e47de8 (owner: XDG Window Late)
[LOG] Registered signal for owner 557143e47b10: 557143e479e0 -> 557143e47f20 (owner: XDG Window Late)
[LOG] Registered signal for owner 557143e47b10: 557143e47a00 -> 557143e47eb8 (owner: XDG Window Late)
[LOG] Registered signal for owner 557143e47b10: 557143e47a10 -> 557143e47e50 (owner: XDG Window Late)
[LOG] Registered signal for owner 557143e47b10: 557143e47a20 -> 557143e47f88 (owner: XDG Window Late)
[LOG] Registered signal for owner 557143e47b10: 557143e479f0 -> 557143e47d80 (owner: XDG Window Late)
[LOG] Registered signal for owner 557143d5aae0: 557143e473c0 -> 557143d5ab58 (owner: SurfaceTreeNode)
[LOG] Registered signal for owner 557143d5aae0: 557143e47390 -> 557143d5abc0 (owner: SurfaceTreeNode)
[LOG] Registered signal for owner 557143d5aae0: 557143e473d0 -> 557143d5ac28 (owner: SurfaceTreeNode)
[LOG] Creating a surfaceTree Root! (pWindow: 557143e47b10)
[LOG] Map request dispatched, monitor DP-1, xywh: 3452.000000 48.000000 1896.000000 1020.000000
[LOG]  [hookSystem] New hook event registered: openWindow
[LOG] Framebuffer created, status 36053
[wlr] [GLES2] Program/shader state performance warning: Vertex shader in program 14 is being recompiled based on GL state.
[wlr] [GLES2] Program/shader state performance warning: Vertex shader in program 8 is being recompiled based on GL state.
[LOG]  [hookSystem] New hook event registered: windowTitle
[LOG] Searching for matching rules for Alacritty (title: rawhav0kk@artixbox:~)
[LOG] Window 557143e47b10 set title to rawhav0kk@artixbox:~
[LOG] Searching for matching rules for Alacritty (title: rawhav0kk@artixbox:~/media/builds/hypr/split-monitor-workspaces)
[LOG] Window 557143e47b10 set title to rawhav0kk@artixbox:~/media/builds/hypr/split-monitor-workspaces
[LOG] Searching for matching rules for Alacritty (title: rawhav0kk@artixbox:~/media/builds/hypr/split-monitor-workspaces)
[LOG] Window 557143e47b10 set title to rawhav0kk@artixbox:~/media/builds/hypr/split-monitor-workspaces

This has most likely been fixed, closing as it's a really old issue


dep panic

https://github.com/golang/dep/blob/22125cfaa6ddc71e145b1535d4b7ee9744fefff2/gps/solver.go#L945
panic: runtime error: index out of range

goroutine 1 [running]:
github.com/golang/dep/gps.(*solver).findValidVersion(0xc4201ca200, 0xc420f3e1e0, 0xc4201c3300, 0x2, 0x2, 0x0, 0xc4201c3300)
        /Users/shaun.fu/go/src/github.com/golang/dep/gps/solver.go:945 +0x4b9
github.com/golang/dep/gps.(*solver).backtrack(0xc4201ca200, 0x15fcb20, 0xc420022298, 0x0, 0x0, 0x0)
        /Users/shaun.fu/go/src/github.com/golang/dep/gps/solver.go:1079 +0xc5e
github.com/golang/dep/gps.(*solver).solve(0xc4201ca200, 0x15fcb20, 0xc420022298, 0x139a253, 0x15060e0, 0xc4202b08f0)
        /Users/shaun.fu/go/src/github.com/golang/dep/gps/solver.go:566 +0x43c
github.com/golang/dep/gps.(*solver).Solve(0xc4201ca200, 0x15fcb20, 0xc420022298, 0x1875f80, 0xc42002a01b, 0x23, 0xc420347cb0)
        /Users/shaun.fu/go/src/github.com/golang/dep/gps/solver.go:440 +0xc8
main.(*ensureCommand).runDefault(0xc420181a10, 0xc4200c2980, 0xc42019a7d0, 0x0, 0x0, 0xc4200e0090, 0x1600ac0, 0xc42008e900, 0xc42002a004, 0x3a, ...)
        /Users/shaun.fu/go/src/github.com/golang/dep/cmd/dep/ensure.go:281 +0x361
main.(*ensureCommand).Run(0xc420181a10, 0xc4200c2980, 0xc42019a7d0, 0x0, 0x0, 0x0, 0x0)
        /Users/shaun.fu/go/src/github.com/golang/dep/cmd/dep/ensure.go:218 +0x865
main.(*Config).Run(0xc42008efc0, 0x0)
        /Users/shaun.fu/go/src/github.com/golang/dep/cmd/dep/main.go:212 +0xfae
main.main()
        /Users/shaun.fu/go/src/github.com/golang/dep/cmd/dep/main.go:84 +0x54d
make: *** [dep] Error 2

Maybe we should check here?
if ds := s.sel.getDependenciesOn(q.id); len(ds) != 0 {
	s.fail(ds[0].depender.id)
}

Seems like a duplicate of #1437. Should probably be closed.

Dep was officially deprecated earlier this year, and the proposal to archive this repository was accepted. As such, I'm closing outstanding issues before archiving the repository. For any further comments, please use the proposal thread on the Go issue tracker. Thanks!


fix: markdown upload asset domain url to ctfassets.net []

We want to guarantee that new asset uploads will use ctfassets.net as a domain instead of contentful.com

@cezarsmpio Looks like hostname-transformer is a private npm package:
npm install @contentful/default-field-editors

npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@contentful%2fhostname-transformer - Not found
npm ERR! 404
npm ERR! 404  '<EMAIL_ADDRESS>is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404 It was specified as a dependency of '@contentful/field-editor-markdown'
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.


Calico installation doesn't work

Calico installation doesn't work
Hello, I have a Kubernetes cluster that I create with kubeadm.
Installing the elements of the quickstart:

kubectl create -f https://projectcalico.docs.tigera.io/master/manifests/tigera-operator.yaml
kubectl create -f https://projectcalico.docs.tigera.io/master/manifests/custom-resources.yaml

tigera-operator works as intended by creating the pods, however for custom-resources, I get the following messages:
'Warning: policy/v1beta1 PodSecurityPolicy is deprecated in v1.21+, unavailable in v1.25+\n' +
    'unable to recognize "calico/custom-resources.yaml": no matches for kind "Installation" in version "operator.tigera.io/v1"\n' +
    'unable to recognize "calico/custom-resources.yaml": no matches for kind "APIServer" in version "operator.tigera.io/v1"\n',

Expected Behavior
The pods should be created accordingly to the manifest.
Current Behavior
custom-resources doesn't work.
Steps to Reproduce (for bugs)
Basically, follow the quickstart:

kubeadm init --pod-network-cidr=<IP_ADDRESS>/24
Change custom-resources ip address to fit the one above
Apply the manifests

Context
I want to install Calico and Calicoctl to use them with MetalLB
Your Environment

Calico version: Nightly
Orchestrator version (e.g. kubernetes, mesos, rkt): kubernetes 1.23.6
Operating System and version: Centos 7

请问custom-resources在1.25.2中应该怎么写呢？


Add command report_reference

Motivate of the pull request

[x] To address an existing issue. If so, please provide a link to the issue: #1780
[x] Breaking new feature. If so, please describe details in the description part.

    During architecture exploration, the number of repeatable tiles or routing blocks are critical
    to make decisions from a physical design perspective. 	However, currently, the number of
    repeatable tiles and the number of instances for each unique tiles  can only be inferred from
    the auto-generated netlists. This requires additional effort from eye checks or scripting.

    It is fairly reasonable to create a new command in the OpenFPGA shell: report_reference
    It can report the number of instances for each unique module, under a given module.

Describe the technical details
What is currently done? (Provide issue link if applicable)

  The new command report_reference has the following options:
  --file <string> specify the file to output results
  --module <string> specify the module name, under which the references of child modules will be reported.
        The module name should be valid name. Otherwise, errors will be thrown.
  --no_time_stamp remove the time stamp from output file
  --verbose turn on verbose log

What does this pull request change?

Which part of the code base require a change

[ ] VPR
[ ] Tileable routing architecture generator
[x] OpenFPGA libraries
[ ] FPGA-Verilog
[ ] FPGA-Bitstream
[ ] FPGA-SDC
[ ] FPGA-SPICE
[ ] Flow scripts
[ ] Architecture library
[ ] Cell library
[ ] Documentation
[ ] Regression tests
[ ] Continous Integration (CI) scripts

Impact of the pull request

[ ] Require a change on Quality of Results (QoR)
[ ] Break back-compatibility. If so, please list who may be influenced.

@victorzh001 Please clean up the errors in regression tests

@tangxifan
Just to confirm, in the below comment:
https://github.com/lnis-uofu/OpenFPGA/pull/1815#pullrequestreview-2281812674
The document to update is as below or other else?
https://github.com/lnis-uofu/OpenFPGA/blame/feefc04d14fd323f864431d1e065f6fd09908502/docs/source/manual/openfpga_shell/openfpga_commands/setup_commands.rst

@tangxifan Just to confirm, in the below comment: #1815 (review) The document to update is as below or other document instead? https://github.com/lnis-uofu/OpenFPGA/blame/feefc04d14fd323f864431d1e065f6fd09908502/docs/source/manual/openfpga_shell/openfpga_commands/setup_commands.rst
I will add command description in this document as below:

This is exactly what we need.

@tangxifan Just to confirm, in the below comment: #1815 (review) The document to update is as below or other document instead? https://github.com/lnis-uofu/OpenFPGA/blame/feefc04d14fd323f864431d1e065f6fd09908502/docs/source/manual/openfpga_shell/openfpga_commands/setup_commands.rst
I will add command description in this document as below:

This is exactly what we need.

OK, thanks for .

@victorzh001 See doc format issue. But I will merge this PR as is. Please create a follow-up PR. Thanks!

OK, thank you.


az webapp up provides misleading information when invalid name is provided

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az webapp up
Errors:
Unable to retrieve details of the existing app mpae_webapp. Please check that the app is a part of the current subscription

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az webapp up --resource-group {} --name {} --html

Expected Behavior
The error that is captured is incomplete, on the screen it gives
Webapp random_webapp already exists. The command will deploy contents to the existing app.
Unable to retrieve details of the existing app random_webapp. Please check that the app is a part of the current subscription

The first portion of that output is incorrect and misleading.  The error seems to be that underscore is not allowed in the name.  However, the error says that the instance exists instead.
Environment Summary
Darwin-19.2.0-x86_64-i386-64bit
Python 3.7.4
Shell: bash

azure-cli 2.0.80
azure-cli-iot-ext 0.8.3

Extensions:
azure-cli-iot-ext 0.8.3

Additional Context

This means the app name you provided is already taken - must belong to some other subscription, so you need run with a different app name.

Should be fixed by siteName validation

@calvinsID this is the GitHub issue for checking if invalid site name is given to az webapp up.
For this please check this API https://docs.microsoft.com/en-us/rest/api/appservice/checknameavailability/checknameavailability#details
we already use this API, however we never look into the details & show a detailed error message, so check if we can make some changes here to fix this.


Implement SE-0195, which introduces "Dynamic Member Lookup" Types

This is a dusted off and updated version of PR13361,
which switches from DynamicMemberLookupProtocol to @dynamicMemberLookup as
was requested by the final review decision.  This also rebases it,
updates it for other changes in the compiler, improves diagnostics a bit, and adds new tests

@swift-ci please test

@rudkx I'd appreciate a review whenever you have a chance, thanks!

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 12f3f2241d19e0805067b652dc3ccce09891cb40

Build failed
Swift Test Linux Platform
Git Sha - 12f3f2241d19e0805067b652dc3ccce09891cb40

@swift-ci please test

@swift-ci please test

@swift-ci please test

It's getting there! My primary concerns with the implementation right now are:

Support for subscript(dynamicMember:) within generics and that is generic, because the handling of index types looks like it'll be incorrect.
Clarification on existential types (and type parameters, I guess), which I think should be supported but aren't because we're only considering nominal types.

From the peanut gallery: given the potential for this to introduce regressions, would it make sense to make sure that the source-compatibility suite is up-and-running correctly? I counted 20 targets that are currently ignored. For example, because SR-6658 wasn't fixed on time, there was a regression on Swift 4.1 that could have been caught otherwise, and I'm worried that as time goes on, there could be more of these.

@DougGregor Thanks for the feedback.  Can you give more detailed examples of the cases you're concerned about?  It isn't immediately obvious to me what cases you're concerned about, but I'm happy to make sure they work (or get fixed) if I can get the (sketch of) a testcase.
@NachoSoto This isn't particularly likely to introduce regressions since it is an additive feature.  It is much more likely that there will be some new thing that should be supported by it that isn't already.

@NachoSoto, we aren't going to hold contributions hostage because of unrelated source-compatibility failures. I'm happy to engage on a discussion of SR-6658 and SR-6797 in an appropriate forum, but on a pull request for a separate feature that was approved by the Swift Evolution process, it's noise.

@lattner , so test case sketches:
Adding a setter for the dynamicMember subscript in a derived class:
class DerivedClassWithSetter : BaseClass {
  override subscript(dynamicMember member: String) -> Int {
    get { return super[dynamicMember: member] }
    set { }
   }
}

Generics:
@dynamicMemberLookup
 struct SettableGeneric1<T> {
   subscript(dynamicMember member: StaticString) -> T? {
     get {return nil}
     set {}
   }
 }

@dynamicMemberLookup
 struct SettableGeneric2<T> {
   subscript<U: ExpressibleByStringLiteral>(dynamicMember member: U) -> T? {
     get {return nil}
     set {}
   }
 }

More existentials:
protocol SubPyVal : PyVal { }

func testMutableExistential(a : AnyObject & PyVal, b : SubPyVal)  {
 a.x.y = b
 b.x.y = b
}

More generics:
func testGeneric<T: PyVal, U: SubPyVal>(a: T, b: U) {
 a.x.y = b
 b.x.y = b
}

Awesome, thank you for the detailed feedback Doug!  I added all the test cases and I think I addressed all of your comments above.

The two open issues is "where to cache the bit" and "do you really want this in knownIdentifiers.def"?  I also owe @rudkx and answer about key paths.

I tried caching the bit in RecursiveTypeProperties which seems natural.  The problem with that is that types are formed before name lookup is done.  Instead I will actually listen to Doug for once ;-) and do what he says: try a map in ConstraintSystem.

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test

Keypath support is now implemented.
@rudkx and @DougGregor, I think I have addressed all of the concerns you've raised upthread.  Thank you for the detailed feedback, I really appreciate your effort on this.  I just kicked off a test suite check, please take another look whenever you have time and I'd like to merge it if possible.  Thanks!!

@rudkx and @DougGregor, do you have any concerns with me hitting 'squash and merge'?  I'm happy to continue improving this in subsequent PR's if anything new pops up.  Thanks!

LGTM!

Thank you!

Thanks @DougGregor, I'm improving the caching thing in PR 14697.


[5.2] Fix retrieveByCredentials in EloquentUserProvider to handle cases with empty credentials

Fix retrieveByCredentials method to handle cases where an empty credentials array is provided. It used to  return the first user in database.

The latest commit wont solve the problem, i made it specifically that way because i couldn't find more elegant way to handle situations like Auth::atempt(['password' => 'password']), credentials array is non empty


Add Gust speed to the left legend

Added and released https://github.com/wcbonner/InfluxDBWindSVG/releases/tag/2.20240112.0


Configuration factory fails to delete object

stack trace
2020-06-08 15:52:01.017 | INFO     | jumpscale.servers.gedis.server:_on_connection:268 - Executing method report from actor chatflows_chatbot to client ('<IP_ADDRESS>', 35462)
2020-06-08 15:52:01.191 | ERROR    | jumpscale.sals.chatflows.chatflows:wrapper:144 - error
Traceback (most recent call last):

> File "/home/maged/Code/js-ng/jumpscale/sals/chatflows/chatflows.py", line 137, in wrapper
    getattr(self, step_name)()
            │     └ 'network_reservation'
            └ <network_deploy.NetworkDeploy object at 0x7fb1e4137d68>

  File "/home/maged/Code/js-ng/jumpscale/sals/chatflows/chatflows.py", line 578, in wrapper
    return func(*args, **kwargs)
           │     │       └ {}
           │     └ (<network_deploy.NetworkDeploy object at 0x7fb1e4137d68>,)
           └ <function NetworkDeploy.network_reservation at 0x7fb1e41eab70>

  File "/home/maged/Code/js-sdk/jumpscale/packages/tfgrid_solutions/chats/network_deploy.py", line 36, in network_reservation
    ip_range = j.sals.reservation_chatflow.get_ip_range(self)
               │                                        └ <network_deploy.NetworkDeploy object at 0x7fb1e4137d68>
               └ <jumpscale.god.J object at 0x7fb1ecce4b70>

  File "/home/maged/Code/js-ng/jumpscale/god.py", line 109, in __getattr__
    self._load()
    │    └ <function ExportedModule._load at 0x7fb1eb42fd90>
    └ ExportedModule(__doc__=None, _exportedas=None, _loaded=False, _m=<module 'jumpscale.sals.reservation_chatflow' from '/home/ma...

  File "/home/maged/Code/js-ng/jumpscale/god.py", line 101, in _load
    self._exportedas = self._m.export_module_as()
    │    │             │    │  └ <function export_module_as at 0x7fb1eb3e2620>
    │    │             │    └ <module 'jumpscale.sals.reservation_chatflow' from '/home/maged/Code/js-ng/jumpscale/sals/reservation_chatflow/__init__.py'>
    │    │             └ ExportedModule(__doc__=None, _exportedas=None, _loaded=False, _m=<module 'jumpscale.sals.reservation_chatflow' from '/home/ma...
    │    └ None
    └ ExportedModule(__doc__=None, _exportedas=None, _loaded=False, _m=<module 'jumpscale.sals.reservation_chatflow' from '/home/ma...

  File "/home/maged/Code/js-ng/jumpscale/sals/reservation_chatflow/__init__.py", line 4, in export_module_as
    return ReservationChatflow()
           └ <class 'jumpscale.sals.reservation_chatflow.reservation_chatflow.ReservationChatflow'>

  File "/home/maged/Code/js-ng/jumpscale/sals/reservation_chatflow/reservation_chatflow.py", line 140, in __init__
    self.get_solutions_explorer()
    │    └ <function ReservationChatflow.get_solutions_explorer at 0x7fb1e40bf1e0>
    └ <jumpscale.sals.reservation_chatflow.reservation_chatflow.ReservationChatflow object at 0x7fb1e4116898>

  File "/home/maged/Code/js-ng/jumpscale/sals/reservation_chatflow/reservation_chatflow.py", line 255, in get_solutions_explorer
    self.solutions.delete(obj)
    │    │         │      └ 'testnet_460422'
    │    │         └ <function Factory.delete at 0x7fb1e8fc98c8>
    │    └ <jumpscale.core.base.factory.jumpscalesalsreservation_chatflowmodelsTfgridSolution1 object at 0x7fb1e4116860>
    └ <jumpscale.sals.reservation_chatflow.reservation_chatflow.ReservationChatflow object at 0x7fb1e4116898>

  File "/home/maged/Code/js-ng/jumpscale/core/base/factory.py", line 227, in delete
    self._delete_instance(name)
    │    │                └ 'testnet_460422'
    │    └ <function StoredFactory._delete_instance at 0x7fb1e8fcd378>
    └ <jumpscale.core.base.factory.jumpscalesalsreservation_chatflowmodelsTfgridSolution1 object at 0x7fb1e4116860>

  File "/home/maged/Code/js-ng/jumpscale/core/base/factory.py", line 479, in _delete_instance
    super()._delete_instance(name)
                             └ 'testnet_460422'

  File "/home/maged/Code/js-ng/jumpscale/core/base/factory.py", line 214, in _delete_instance
    if hasattr(self, name):
               │     └ 'testnet_460422'
               └ <jumpscale.core.base.factory.jumpscalesalsreservation_chatflowmodelsTfgridSolution1 object at 0x7fb1e4116860>

  File "/home/maged/Code/js-ng/jumpscale/core/base/factory.py", line 436, in getter
    instance._set_data(factory.store.get(name))
    │        │         │       │         └ 'testnet_460422'
    │        │         │       └ <property object at 0x7fb1e8fc6f48>
    │        │         └ <jumpscale.core.base.factory.jumpscalesalsreservation_chatflowmodelsTfgridSolution1 object at 0x7fb1e4116860>
    │        └ <function Base._set_data at 0x7fb1e8fd6f28>
    └ TfgridSolution1(_Base__instance_name='testnet_460422', _Base__parent=None, _factories={})

  File "/home/maged/Code/js-ng/jumpscale/core/base/store.py", line 218, in get
    config = json.loads(self.read(instance_name))
             │    │     │    │    └ 'testnet_460422'
             │    │     │    └ <function FileSystemStore.read at 0x7fb1e8fc7a60>
             │    │     └ <jumpscale.core.base.store.FileSystemStore object at 0x7fb1e4123da0>
             │    └ <function loads at 0x7fb1eccacd08>
             └ <module 'jumpscale.data.serializers.json' from '/home/maged/Code/js-ng/jumpscale/data/serializers/json.py'>

  File "/home/maged/Code/js-ng/jumpscale/core/base/store.py", line 313, in read
    return read_file_binary(path)
           │                └ '/home/maged/.config/jumpscale/secureconfig/jumpscale/sals/reservation_chatflow/models/TfgridSolution1/testnet_460422/data'
           └ <function read_bytes at 0x7fb1eb3b47b8>

  File "/home/maged/Code/js-ng/jumpscale/sals/fs/__init__.py", line 579, in read_bytes
    return pathlib.Path(path).read_bytes()
           │       │    └ '/home/maged/.config/jumpscale/secureconfig/jumpscale/sals/reservation_chatflow/models/TfgridSolution1/testnet_460422/data'
           │       └ <class 'pathlib.Path'>
           └ <module 'pathlib' from '/usr/lib/python3.6/pathlib.py'>

  File "/usr/lib/python3.6/pathlib.py", line 1189, in read_bytes
    with self.open(mode='rb') as f:
         │    └ <function Path.open at 0x7fb1ecce98c8>
         └ PosixPath('/home/maged/.config/jumpscale/secureconfig/jumpscale/sals/reservation_chatflow/models/TfgridSolution1/testnet_4604...
  File "/usr/lib/python3.6/pathlib.py", line 1183, in open
    opener=self._opener)
           │    └ <function Path._opener at 0x7fb1ecce91e0>
           └ PosixPath('/home/maged/.config/jumpscale/secureconfig/jumpscale/sals/reservation_chatflow/models/TfgridSolution1/testnet_4604...
  File "/usr/lib/python3.6/pathlib.py", line 1037, in _opener
    return self._accessor.open(self, flags, mode)
           │    │              │     │      └ 438
           │    │              │     └ 524288
           │    │              └ PosixPath('/home/maged/.config/jumpscale/secureconfig/jumpscale/sals/reservation_chatflow/models/TfgridSolution1/testnet_4604...
           │    └ <member '_accessor' of 'Path' objects>
           └ PosixPath('/home/maged/.config/jumpscale/secureconfig/jumpscale/sals/reservation_chatflow/models/TfgridSolution1/testnet_4604...
  File "/usr/lib/python3.6/pathlib.py", line 387, in wrapped
    return strfunc(str(pathobj), *args)
           │           │          └ (524288, 438)
           │           └ PosixPath('/home/maged/.config/jumpscale/secureconfig/jumpscale/sals/reservation_chatflow/models/TfgridSolution1/testnet_4604...
           └ <built-in function open>

FileNotFoundError: [Errno 2] No such file or directory: '/home/maged/.config/jumpscale/secureconfig/jumpscale/sals/reservation_chatflow/models/TfgridSolution1/testnet_460422/data'
<IP_ADDRESS> - - [2020-06-08 15:52:01] "POST /chatflows/chatbot/report HTTP/1.0" 200 138 0.200038

This mostly happens when an instance is lazy-loaded, when it's available as a property in the factory, but it's not actually loaded because it has not been accessed.
Trying to resolve this.

Works fine now, thanks