Async validator not triggered on every change to input field value

Expected behaviour
I expected the async validator to be fired for every change to the value of an input field.
Actual behaviour
The async validator is fired for every change to the value of the input field when the value is passing validation.  Once the value of the field no longer passes validation, the async validator looks like it's only firing for every other change to the input field.
Gist/Plunker/Demo
https://plnkr.co/edit/hdr3OFLNOXwuFuWKoQD1

@nsamarak you are correct, the way it works currently is stopping on the first error hit from tv4 and not processing further. I've added as an enhancement but it could be quite some time before it can be looked at in all honesty given limited resources.

Thanks for the response, @Anthropic.
From the documentation, it looks like $asyncValidators is built on top of ngModelController.  What does tv4 have to do with $asyncValidators?
This issue seems more like a bug than an enhancement.  Until this issue is fixed, someone that hits an error from an async validator can't submit the form.  For example, there's an async validator on the title field in the plunker.  The async validator ensures the word "test" does not appear in the title field.  Type in "chickenstest".  This will trigger the async validator.  Then delete the last "t" so you end up with "chickenstes".  Now there is valid input in that field.  The error message disappears.  However, the inline feedback icon for an error is still visible, there is still a red border around the input field, and the form can not be submitted.  What should happen is the inline feedback icon for valid input should appear, the field should have a green border, and the field should also allow the form to be submitted.
Does this explain the bug better?
Are there any workarounds to this issue?

@Anthropic @davidlgj  I might be able to help fix the issue if you guys can confirm that it is an issue, that there are no workarounds, and help me figure out a potential solution since I'm somewhat new to angular.

@nsamarak I missed this before I left for holidays, there is work being done in the webpack babel branch so that branch would be the ideal place to make changes.
It is hard to explain and I haven't finished the new version and don't have much time to update the documentation yet. But if you do think it isn't too late for you to take a look I'd be happy to try to take you through it at some point.
The main thing we need now is actually coded test cases, so that any fixes aren't broken again in future.

Hi, I seem to have the same problem.
The funny thing is, that the validation message somehow disappears when the user pressed one additional key, but the revalidation ($asynchValidator function) does not get triggered and the field stays red (=ng-invalid).
I also not understand why you think that this has to do with TV4 validation? Because I think the $asynchValidator is set on the schema form form element and not on the json schema, therefore I do not see, why this should be a bug on TV4. In my case the schema validation stays allways valid (simple string field) it is just the asynchValidator that gets not triggered on one key press after it reported invalid once.
Let me know, if I can help somehow. We need a workaround or fix in my current project and I could help to fix it, if I get some guidance, how to do so.
Thanks a lot.

A workaround is to use a tv4 key when you register your validator.
For the plunker example, if you substitute noTest with "tv4-1000" or something in script.js, the form should behave as expected.
This has a downside that this is probably not a proper usage of the tv4 error code.

not sure if this tv4 workaround would help. Maybe I check tomorrow.
I at least isolated the problem a little bit more.
Following piece of code seems to be the source of the problem:
        // But we do use one custom validator in the case of Angular 1.3 to stop the model from
        // updating if we've found an error.
        if (ngModel.$validators) {
          ngModel.$validators.schemaForm = function() {
            //console.log('validators called.')
            // Any error and we're out of here!
            return !Object.keys(ngModel.$error).some(function(e) { return e !== 'schemaForm';});
          };
        }

Problem: this code prevents the $asynchValidators to get retriggered, because it decides, that the result is invalid allready, if there is allready another error, to prevent further validation pipeline being run. But I think that this makes only sense, if this other error occured in this same validation pipeline run, which definitely is not true in case this is an error which is validated asynchronously (and might also be wrong in other circumstances, e.g. if there are other custom validators that have not been executed at this point in time yet). Therefore I think this special kind of short circuit is very bad, and when I just removed this part, everything seems to work fine and I didn't see any downsides of it so far when testing (and I have quite some complex schema forms here, that all run very well without this code). Really not understanding why one would want to stop the whole validation pipeline at this point, when not even knowing whether this error at this point, is from last run through the validation pipeline or not. Therefore I recommend to remove this code or to somehow change it to not block the asynchValidators from doing their jobs.

Aha, now I see the connection to what @shinkondo mentioned above, because there is in deed a little bit above the mentioned code another piece of code, which seems to clear any previously triggered "tv4-"-errors and then doing the tv4 validation as part of the parsers pipeline. So this kind of "tv4-"-errors are guaranteed to happen before this special piece of code (mentioned above) gets called. So I think this code should be changed to only stop validating further, in case such a tv4 error (but no other validation errors) allready occured before, which seems to be the purpose of this code? What you think about this? And this would be okay from my point of view and would not stop $asynchValidators from being called anymore.
If you agree, I could make a PR for this change.

@shinkondo san domo arigatou gozaimasu, I hadn't thought of that, interesting.
@bruderol please take a look at the code in the webpack branch as it may have already had some changes applied, I can't remember off the top of my head, I can check tonight when I get home.

@Anthropic had a look at the webpack branch (you mean feature/webpack-babel), right? Same code is still there (in schemaValidate directive, line 96-104). Should I make a PR? Should this go to this branch (when is this planned to be released?) or shouldn't this better be done on a hotfix branch to release it isolated and then merge it to the mentioned feature branch?

By the way, the workaround with "tv4-" prefix as proposed by @shinkondo seems to work. Thanks a lot!
Funny thing is that for the error message the message has to be mapped on error code without the tv4- prefix, because schemaform strips this special prefix from error codes. All in all I think that this behaviour is weird and should be fixed. Let me know if I should make a PR.

@bruderol if the same code is there (yes, in feature/webpack-babel) then a merge to develop should be fine and I can copy it across to the new branch, just wanted to check that it wasn't different to save you (and me) time! :)
The new branch is hopefully nearing readiness, just more cleanup to do and some more testing, but more importantly I need to make it easier to work with so good people like yourself can make changes to it and submit PR without getting lost. Unfortunately I am rather time-short which is why I need as much help as anyone is willing to afford on currently known issues :) The main thing I need help with is more test cases, but again much easier if they are done in the new branch to save re-work.
I am aware of the prefix issue, there is another ticket somewhere regarding textarea validations not working because of the way the code strips out the tv4 validations and doesn't replace the content appropriately. Basically if you have a text area with a max length of 20 the error only shows at 22 and only removes on deletions at 19 due to issues with angular errors vs tv4 errors.

I think the tv4 issue I mentioned was this regression #633

Hello, I also have the same problem, has anyone managed to solve it? Thanks

@emarcias I'm working to remove tv-4 at the moment, it is too old and not supported any more so long overdue, but may take a while still.
That said have you tried the proposed workaround above?

I'm also having this issue. The workaround would call the async validation on all input, but it would remove the error message "Error in title field".
Has anyone solved it?


Find StyleSheet declarations that are not variables

Fixes #214
Instead of only looking for StyleSheet declarations in VariableDeclarator nodes, we check if CallExpressions are StyleSheet.create({...}). This handles the export default StyleSheet.create({...}) case and other cases where the style sheet is not assigned to a variable.

Coverage decreased (-0.2%) to 74.903% when pulling a81ab292b5daa46ac8fa8e0fdef1d6ac6c1c59ce on draperunner:sort-styles-default-export into 89c3a11ce9e520bfae5e846c9dbe329d4413dd2f on Intellicode:master.

Coverage decreased (-0.2%) to 74.903% when pulling a81ab292b5daa46ac8fa8e0fdef1d6ac6c1c59ce on draperunner:sort-styles-default-export into 89c3a11ce9e520bfae5e846c9dbe329d4413dd2f on Intellicode:master.

Thanks for your PR! If you resolve the conflicts I think we can merge

@Intellicode I have fixed the merge conflicts.

Cheers!


Adding statusCode to error response when JSON response is malformed

In reference to issue #876, these changes will allow the client to access the http status code even when the JSON response body is malformed.
This is the same pull request as https://github.com/visionmedia/superagent/pull/877 but has been squashed into one commit instead of 6 as suggested by @pornel.

LGTM, thanks!

Perfect.
I've given travis a kick to ensure tests pass.

+1 thanks for that
Had to kick it a few times before but I have run them locally and they do pass. Seems to be the last test in Travis regularly stalls testing iphone 9.2 on Mac 10.10.

@pornel Thanks for merging!
How often do you publish to npm as I'm keen to get this into my solution as soon as possible.


calico-node and calico-kube-controllers readiness probe failures on longevity clusters

We are observing readiness probe failures with following event from both calico-node and calico-kube-controllers pods on any longevity(more than 10 days) cluster. This issue is not observed on a newly created cluster.
LAST SEEN   TYPE      REASON           OBJECT                                         MESSAGE 5m11s       Warning   Unhealthy        pod/calico-kube-controllers-5fb7d84d57-jgs8c   Readiness probe failed: 91s         Warning   Unhealthy        pod/calico-node-l5bqm                          Readiness probe failed: calico/node is not ready: BIRD is not ready: Error executing command: read unix @->/var/run/calico/bird.ctl: i/o timeout
Expected Behavior
Readiness probe should not fail on longevity
Current Behavior
Currently on any single/multi-node cluster we are observing this readiness probe failure issues on calico-node and calico-kube-controllers pods. At specific time of Readiness probe failure, we checked pod logs and no red flags are observed.
Possible Solution
Enhance readiness probe check logic to ensure stability of cluster
Steps to Reproduce (for bugs)
We see this behaviour on all dev/qa/prod clusters irrespective of size of cluster.
Context
If calico-node pod health is down, any other pod schedule/de-schedule is impacted.
Your Environment

Calico version - 3.24
Kubernetes version - 1.22.17
Operating System and version: Ubuntu 18.04

The readiness probe is just a symptom of something else going wrong, it's not causing problems itself.
It would be good to see a full kubectl describe pod output as well as kubectl logs output from the affected pods.

@caseydavenport - I will get back with kubectl describe output and kubectl logs of calico-node and calico-kube-controller pods.

@ajayudayagiri-hpe any progress here?

@caseydavenport - we have updated calico_backend to vxlan, readiness probe failures on calico-node pod are not seen.
However, will have to wait for few more days of longevity to see if calico-kube-controllers readiness probe failures will happen.

@ajayudayagiri-hpe is your issue solved now?

Closing this issue. @ajayudayagiri-hpe feel free to re-open this if you still have the same issue.

hi @mazdakn , I am having the same issue

Logs of calico kube controller


Add trigger.yml

I'll need to check the secrets is correctly present

you need something like https://github.com/PrismarineJS/node-minecraft-data/blob/master/.github/workflows/md-release.yml too


⚠ Bofrost.be has degraded performance

In 6f5336f, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1438 ms

Resolved: Bofrost.be performance has improved in 651a763 after 6 minutes.


A questions about sql

I don't know why this part of my highlight displays errors, using official website example, but splitting lines of code.
like
document.addEventListener('DOMContentLoaded', (event) => {
  document.querySelectorAll('pre code').forEach((block) => {
    hljs.highlightBlock(block);
  });
});

Hi @Godlike-meteor,
I'm not sure what do you mean by "displays errors," but PostgreSQL code looks better with  pgsql language.

Thank you, this problem has been solved according to your prompt.


Networking: Use Testify for all Networking Unit test cases

Using testify for unit test cases reduces the complexity of the unit test cases.
This reduces the cyclomatic complexity significantly.

Coverage remained the same at 42.906% when pulling 2c9cb1df2046cb7df3c8e2c84a8bb6d5f73d5536 on mcastelino/topic/cleanup into b9ccb0b6f3bdf4622567db8a494c81b5c3bffc15 on master.

The question is, should we vendor testify?  Vendoring test dependencies is a little trickier due to the way go list works but it can be done.  I can enter an issue for this.

@markdryan it may not be worth the effort to vendor test dependencies. Also when reading the documentation later I noticed that testify supports versioning. Let me check if the v1 suffices for us and use that.
* Latest version: go get github.com/stretchr/testify
* Specific version: go get gopkg.in/stretchr/testify.v1


Refactor the code!

Add all privates methods to an index in the Pin constructor, so it can be testable (also the noop repeated 3 times), as suggested by @weslleyaraujo

Refactor Pin.prototype.onWindowScroll, it is too complex.

pretty much refactored, way better then before :)


Music Mania Backend

[x] flask/music page for dict

Python:

[ ] create model_music.py
[ ] initAPI to initialize API
[ ] function that returns all ts albums
[ ] function that returns all ts songs
[ ] function that creates dictionary of likes
[ ] function that returns likes dictionary data

Create page (api.py):

[ ] make API dictionary show on local server
[ ] likes dictionary show on local server with increase in update counts

DevOps:

[ ]  deploy server


[OAuth] Granted apps API

Related to: #14986

retest this please

Acceptance 🍊
I tried to revoke an oauth_app I haven't granted before and I got this error message:
{"errors":"undefined method `destroy!' for nil:NilClass"}

Could we catch the exception and send a proper error message?

Acceptance 🍏 like a charm v2


Add hardened cluster and upgrade tests

Proposed Changes
Add very basic in-docker hardened and upgrade tests
Types of Changes
testing
Verification
Confirm that tests are running in CI
Testing
yep
Linked Issues

User-Facing Change
NONE

Further Comments

yeah @dereknola the airgap tests already have some supporting files in a subdir so it's an existing pattern, but I agree it could use some reorg.


v12 and Win7 support

ALVR v12 now crashes on Win7 (works with v11) with error "Failed to initialize CEncoder".
Can you please maintain Win7 support in v12?

ALVR v12 dropped support for Windows 7 as part of a cleanup of the codebase. The support could return in a future update but it has a very low priority.

OK, thanks.


⚠ Bofrost.be has degraded performance

In 78cee39, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2673 ms

Resolved: Bofrost.be performance has improved in 79f2c87.


Run container as different user

Hello,
I think by having the ability to run the container as a different user is beneficial from a security standpoint.
I tried to do so but encountered problems probably because the dockerfile sets a user itself.
Is there any chance that this feature be added?

The container already runs as a different (non-root) user (monero), so there isn't a reason to change it for security.
If you want to change it for some other reason, you can edit the Dockerfile yourself and build the image from there.


removed hide-che-sidebar jupyter extension

@marjo-luc I just remembered that we'll need to remove this line from the dockerfile  located at the following path too as part of this PR:
/jupyterlab3-build/docker/Dockerfile


Diamondbacks and Athletics cause empty result

Love the API, but found a small problem. When filtering mlbgame.day() by home or away team, using "Diamondbacks" or "Athletics" will result in an empty set. This is due to the MLB's XML having these listed as "D-backs" and "A's", respectively. Just wanted to let you know in case you wanted to add something to account for it, or let people know in the docs. I'm sure this causes issues in other parts of the API as well, but I've only tested with mlbgame.day().

It will also affect games() for sure. I'll add something to the documentation in the upcoming release.


ensure that layer unpacking algorithms are windows compatible

Recently, there has been a lot of activity in layer.md around the unpacking procedure. I am not sure if we've fully evaluated this in the context of windows containers and other platforms.
As a strawman, there is a lot of discussion around links. How are these correctly handled in NTFS?
@jstarks @RobDolinMS

Thanks @stevvooe.  I've sent an email ping to @jhowardmsft and @jstarks to encourage them to take a look.

@RobDolinMS ping.

@jhowardmsft @jstarks PTAL

some notes about sockets, block devices, char devices, and FIFOs seem needed
It should be clarified that the content of rootfs is extracted under the root of the %SystemDrive%?
(Is there any standard about %SystemDrive%? Is it guaranteed to be always C:?)

PTAL @jhowardmsft @jstarks

can i test this on a vm? Is windows 7 suitable enough?

like fifos, symlinks, sockets, character devices. These are platform specific.
The assumption on the current doc, that is readying for v1, is that it is unless otherwise specified targeting POSIX. As windows specific changes come in, we'll just denote those platform dependent differences, so that a post-v1 addition will not break the current POSIX expectations.
(i realize it's not strictly POSIX or the "POSIX is dead" or whatever, but it most closely matches what happens here)

POSIX is dead?? no-one told me!!

(I would also really like to hear more input from our MS friends on how the current layer specification is working out for them)

POSIX is dead?? no-one told me!!

2016 article that recently floated around
http://www.cs.columbia.edu/~vatlidak/resources/POSIXmagazine.pdf
Take it with a grain of salt ...

PTAL @RobDolinMS @jstarks @jhowardmsft

PTAL @RobDolinMS @jstarks @jhowardmsft

@RobDolinMS @jstarks @jhowardmsft This is a v1.0 blocking issue.

Thanks @Philips.  I've pinged @jstarks @jhowardmsft and a few others from their team with a reminder to look at this issue.

I'm in favor of this being post-v1.0.0, as it has been a topic since Oct 2016 with no semantics for it. If the current semantics for a layer type are found to not be compatible then we'll have to make a new layer type later.

+1 to moving to post v1.0.0 due to the lack of movement.

Essentially I don't think there are any serious problems, just missing information on Windows specifics. I can take a shot at a PR to include these specifics, but here they are in comment form first:
Windows layers cannot currently have sockets, block devices, character devices, or FIFOs (these concepts don't currently mean anything on Windows).
Windows doesn't look at uid, gid, or mode, since these concepts don't exist in Windows file systems. Instead, Windows relies on the Windows-specific metadata described below.
We don't support xattrs either; Windows extended attributes are different enough that they should use a different portion of the tar PAX metadata if we want to support them (currently they are not supported in Docker).
There are a few tar PAX extensions we added to support necessary Windows metadata. Specifically, the Windows file attribute data is stored in MSWINDOWS.fileattr. The security descriptor is stored in binary form, base64 encoded, in MSWINDOWS.rawsd. If MSWINDOWS.mountpoint is present on a symbolic link, then instead of a standard Windows symbolic link, a mount point (directory junction) should be created.
Finally, Windows images should use the LIBARCHIVE.creationtime to encode the creation time for files.

@jstarks thank you for this. The implications of this are beyond what can be covered in this spec for the time being, except for just having a comment on only what is capable currently.
I'm going to tag this as post-v1.0.0. Though given what you've said, it would likely be best to open new issues to concisely cover the points that need working toward.

@jstarks is this still needed or can we close it?

Finally, Windows images should use the LIBARCHIVE.creationtime to encode the creation time for files.

ctime is supported by several other PAX extensions, is there a reason to use LIBARCHIVE over the more common ones (SCHILY and GNU)?

This obviously did not block v1.0, and has not been an issue since. I'm guessing WSL solved a number of issues like this 😸


spurios results from time_us_64()

I was measuring the timing of ADC reading, and  saw some spurios results. Most cycles took 7usec with occasional spurious of up to 50usec.
To troubleshoot further, the code of the adc reading was replaced with a busy_wait_us_32(7) and the same behaviour was observed.
The time measured is mostly 7 or 8 usec, with similar spurious jumps.

Is there a reason why time_us_64(); would ad up to 40usec occassionally?
uint64_t start_time [200];
uint64_t end_time [200];
void __time_critical_func(Sandbox_time_us_64) (void) {
for (int i=0; i<200; i++){
start_time [i]= time_us_64();
busy_wait_us_32(7);
end_time[i] = time_us_64();
}
}
void Sandbox_time_us_64_Print (void) {
for (int i=0; i<200; i++){
printf("ADC0 %04x | ADC1 %04x |Read Time %f usecs\n",adc0_read[i], adc1_read[i], double (end_time[i]-start_time[i]));
}
}

The issue may be related to interrupts outside the code, for example the USB serial. Closing until I have more info.


Update JQuery library version used in Jaggery applications

Description:

We have been using JQuery 1.11.3 for a long time and  it's out of maintainance. No longer receving surity or functionality patches.
Because of that ,IMHO It's a must to do upgrade the JQuery library in next release (Major)

Affected Product Version:

API Manager 2.6

JQuery has not been used in APIM 3.0.0 web portals since the store/publisher apps in APIM 3.0.0 are react based.


Stop trying to connect to not responding peer

Close #301

Coverage remained the same at 46.513% when pulling 60a961288e724eb460472faa4b32ef868c571062 on i301 into d732fb04f4f0386e07f3af1170bc8b10831f853e on master.

In order to avoid repeated connections to not responding peers I propose to implement blacklist timeout and add such peers to blacklist for a 24h.
Then blacklist would look like:
val blacklist = mutable.Map[String, (TimeProvider.Time, Timeout)]()

Fixed in https://github.com/ScorexFoundation/Scorex/pull/329


Label name not showing on details view

When using the TipTap editor, the label name is not showing on the details view.
In cases when you have more than one editor field per view, it can be a bit tricky to figure out which field is which.

You are right, and this is fixed now in 0.3.6. Thanks for pointing this out.


Add throttle type definition

Base on Issue 624

Please see https://github.com/yelouafi/redux-saga/issues/619, let's make it a little more strict

I've seen that issue and create a new commit.
Hope it will be better.

Looks good now 👍

Thanks for your help and patience!


Add support for setup.cfg files

Codecov Report

Merging #10 (dad2c30) into main (47fb9be) will decrease coverage by 0.31%.
The diff coverage is 96.66%.

@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   96.19%   95.88%   -0.32%
==========================================
  Files           4        8       +4
  Lines         184      243      +59
==========================================
+ Hits          177      233      +56
- Misses          7       10       +3

Impacted Files
Coverage Δ

minimum_dependency_generator/main.py
30.76% <0.00%> (-5.60%)
:arrow_down:

minimum_dependency_generator/utils.py
97.43% <97.43%> (ø)

...pendency_generator/minimum_dependency_generator.py
100.00% <100.00%> (ø)

minimum_dependency_generator/tests/conftest.py
100.00% <100.00%> (ø)

minimum_dependency_generator/tests/test_helpers.py
100.00% <100.00%> (ø)

...cy_generator/tests/test_requirements_text_files.py
100.00% <100.00%> (ø)

...nimum_dependency_generator/tests/test_setup_cfg.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47fb9be...dad2c30. Read the comment docs.


How to add autoComplete off

Are you reporting a bug?

Please create a Codepen that demonstrates your issue. You can start from the Basic example.

Provide the steps to reproduce the issue, e.g.:

Focus on the input field
Type c, and wait for suggestions to appear
Press Escape

Observed behaviour: Suggestions stay open
Expected behaviour: Suggestions should be closed

Are you making a feature request?

Please describe your use case from user journey point of view, e.g.:

In my application, when user highlights suggestions (using the mouse or keyboard), I'd like to display additional information about the highlighted suggestion alongside the Autosuggest.

If you have ideas how to extend the Autosuggest API to support your new feature, please share!

If you know any examples online that already implement such functionality, please share a link.

Pretty sure you can just pass autoComplete to the inputProps.
<Autosuggest inputProps={{ autoComplete: 'donotsuggest' }} ...otherProps />

https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete


Doc build fails on Read the Docs

The problem is related to libgeos not being available on Read the Docs. We came across the same issue in GeoAlchemy, see https://github.com/geoalchemy/geoalchemy2/pull/115.

See https://readthedocs.org/projects/papyrus/builds/5061273/ for a failure in RTD.


Port the kernel spec fix that Don made and merge + fixup tests

For #

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[x] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
[ ] The wiki is updated with any design decisions/details.

This is just Don's fix from here:
https://github.com/microsoft/vscode-python/pull/11312
Since Don is OOF updating it by merging with master and updating unit tests so Rich and I can use the correct python path that Don fixed.

Codecov Report

Merging #11330 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #11330      +/-   ##
==========================================
+ Coverage   61.02%   61.03%   +0.01%
==========================================
  Files         604      604
  Lines       33407    33421      +14
  Branches     4730     4732       +2
==========================================
+ Hits        20387    20400      +13
+ Misses      12577    11995     -582
- Partials      443     1026     +583

Impacted Files
Coverage Δ

...client/datascience/kernel-launcher/kernelFinder.ts
79.00% <100.00%> (+0.64%)
:arrow_up:

src/client/common/utils/platform.ts
64.70% <0.00%> (-5.89%)
:arrow_down:

...pplication/diagnostics/checks/pythonInterpreter.ts
91.07% <0.00%> (-0.60%)
:arrow_down:

src/client/testing/main.ts
14.38% <0.00%> (ø)

src/client/common/editor.ts
8.25% <0.00%> (ø)

src/client/linters/flake8.ts
85.71% <0.00%> (ø)

src/client/linters/pylint.ts
98.27% <0.00%> (ø)

src/client/telemetry/index.ts
87.38% <0.00%> (ø)

src/client/language/unicode.ts
68.18% <0.00%> (ø)

src/client/sourceMapSupport.ts
80.43% <0.00%> (ø)

... and 139 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3d2252...51b95c6. Read the comment docs.


Consolidate MEP PR's for stage

Prepping a grouping of a few related MEP PR's for stage:
MWPW-140268 [MILO][MEP] Overhaul MEP Action List
Before: https://main--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmoreactions/?martech=off
After: https://mepmoreactions--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmoreactions/?martech=off
==============================================================
[MILO][MEP] Update Manifest Type and Manifest Ordering v2 (needs 2nd approval) AND [MILO][MEP] Mixed manifests use Target data instead of json file
2 manifests (1 pzn and 1 test from Target):
Before: https://stage--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/two-manifests-one-from-target
After: https://mepmoreactions--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/two-manifests-one-from-target
A bunch of additional Test URL's to test different use cases (these are all captured by unit tests as well):
3 manifests with one of each manifest type in the "wrong" execution order:
Before: https://stage--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/three-manifest-types-all-normal
After: https://mepmoreactions--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/three-manifest-types-all-normal
Same as above but one manifest using first:
Before: https://stage--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/three-manifest-types-one-first
After: https://mepmoreactions--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/three-manifest-types-one-first
Same as above but one manifest using last:
Before: https://stage--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/three-manifest-types-one-last
After: https://mepmoreactions--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/three-manifest-types-one-last
Same as above but old "Test or Promo" type being used:
Before: https://stage--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/three-manifest-types-one-test-or-promo
After: https://mepmoreactions--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/three-manifest-types-one-test-or-promo
Same as above but one has no info tab:
Before: https://stage--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/three-manifest-types-one-no-type
After: https://mepmoreactions--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/three-manifest-types-one-no-type
Improved merge also solves: https://jira.corp.adobe.com/browse/MWPW-143068
Before: https://stage--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/outdated-manifest
After: https://mepmoreactions--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q1/mepmanifestorder/outdated-manifest
===========================================================
Deconflicting for MWPW-136727 MEP: Support for simplified selectors
Before: https://stage--milo--adobecom.hlx.page/drafts/cpeyer/mep-cell/surfing-marquee?martech=off
After:
https://mepmoreactions--milo--adobecom.hlx.page/drafts/cpeyer/mep-cell/surfing-marquee?martech=off
https://mepmoreactions--milo--adobecom.hlx.page/drafts/cpeyer/mep-cell/surfing-marquee?martech=off&m-pic=shuttle
https://mepmoreactions--milo--adobecom.hlx.page/drafts/cpeyer/mep-cell/surfing-marquee?martech=off&m-pic=octopus
============================================================
[MILO][MEP] MEP parameter spoof breaks if chosen experience has a comma
check for param spoof breaking:
Before: https://stage--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q2/meppreviewdelimiter/?martech=off
After: https://mepmoreactions--milo--adobecom.hlx.page/drafts/vgoodrich/fragments/2024/q2/meppreviewdelimiter/?martech=off
=============================================================
Check that promo feature is unaltered:
Before: https://stage--milo--adobecom.hlx.page/drafts/mariia/pr/promo/promo
After: https://mepmoreactions--milo--adobecom.hlx.page/drafts/mariia/pr/promo/promo

@vgoodric why did the PSI not pass? Please get it to pass or justify it's failure; respectfully please.


quotes required around type

This should be backward compatible but we often get an error as "type": TIMESTAMP WITH TIME ZONE, isn't valid. It should be "type": "TIMESTAMP WITH TIME ZONE",

Thanks, but it was fixed in 1.0.3 by another way


Add QNX support

Support heap-profile and cpu-profile.
Stil WIP, some issues need to be resolved, see https://github.com/gperftools/gperftools/issues/1429#issuecomment-1726837434

I will split this patch

heap profile, which maybe fine to merge  now
stacktrace with  libunwind support, which still have some issues, and need some more work to fix it.
cpu profile, which unsure whether it's really needed on qnx

Compile for QNX, still need use addition CPPFLAGS mentioned https://github.com/gperftools/gperftools/issues/1147#issuecomment-1004137185
./configure --host=aarch64-unknown-nto-qnx7.1.0 --enable-frame-pointers CPPFLAGS="-D__NO_EXT_QNX -D_SC_NPROCESSORS_ONLN=91"

From the compiler log, cfree and mallopt declaration is different between QNX libc and gperftools,
src/libc_override_gcc_and_weak.h:215:8: error: conflicting declaration of C function 'void cfree(void*)'
   void cfree(void* ptr) __THROW                   ALIAS(tc_cfree);
        ^~~~~
In file included from src/debugallocation.cc:44:
target/qnx7/usr/include/malloc.h:64:12: note: previous declaration 'int cfree(void*)'
 extern int cfree(void *__ptr);

src/libc_override_gcc_and_weak.h:225:7: error: conflicting declaration of C function 'int mallopt(int, int)'
   int mallopt(int cmd, int value) __THROW         ALIAS(tc_mallopt);
target/qnx7/usr/include/malloc.h:140:12: note: previous declaration 'int mallopt(int, intptr_t)'
extern int mallopt(int __cmd, intptr_t __value);

Force alias seems also not a good idea, @alk any suggestions, or just it go.
#ifdef __QNXNTO__
  int cfree(void* ptr) __THROW                   ALIAS(tc_cfree);
#else
  void cfree(void* ptr) __THROW                   ALIAS(tc_cfree);
#endif
  void* memalign(size_t align, size_t s) __THROW  ALIAS(tc_memalign);
  void* aligned_alloc(size_t align, size_t s) __THROW ALIAS(tc_memalign);
  void* valloc(size_t size) __THROW               ALIAS(tc_valloc);
  void* pvalloc(size_t size) __THROW              ALIAS(tc_pvalloc);
  int posix_memalign(void** r, size_t a, size_t s) __THROW
      ALIAS(tc_posix_memalign);
#ifndef __UCLIBC__
  void malloc_stats(void) __THROW                 ALIAS(tc_malloc_stats);
#endif
#ifdef __QNXNTO__
  int mallopt(int cmd, intptr_t value) __THROW         ALIAS(tc_mallopt);
#else
  int mallopt(int cmd, int value) __THROW         ALIAS(tc_mallopt);
#endif

Updates: on QNX socketpair api need link socket library, weired previous compile is passed.
And stash cpu profiler and libunwind support on an seperated branch:
cpu profiler support on https://github.com/iDings/gperftools/tree/qnx_cpu_profiler,
libunwind support on https://github.com/iDings/gperftools/tree/qnx_libunwind

Have an issue:
compile is fine, but libc++.so and libsocket.so didn' t in the NEEDED shared library,  need to add this two library in
LD_PRELOAD to run the application.  Previous test can work is because the test application also link this two library and have this two library in the NEEDED library and linker can link this two library. Need some more analysis to figure out why this happened.
 $eu-readelf -Wd  libtcmalloc.so.9
Dynamic segment contains 32 entries:
 Addr: 0x000000000006e7f8  Offset: 0x05e7f8  Link to section: [ 5] '.dynstr'
  Type              Value
  NEEDED            Shared library: [libunwind.so.8]
  NEEDED            Shared library: [liblzma.so.5]
  NEEDED            Shared library: [libz.so.2]
  NEEDED            Shared library: [libm.so.3]
  NEEDED            Shared library: [libc.so.5]
  NEEDED            Shared library: [libgcc_s.so.1]
  SONAME            Library soname: [libtcmalloc.so.9]
...

Updates:

For QNX autoconfig compile, need force config CC`` and CXXtoqccandq++. otherwise the compiler didn't include libc++.so.1in outputlibtcmalloc` library.

./configure CC="qcc -Vgcc_ntoaarch64le" CXX="q++ -Vgcc_ntoaarch64le" --host=aarch64-unknown-nto-qnx7.1.0 --enable-frame-pointers CXXFLAGS="-D__NO_EXT_QNX -D_SC_NPROCESSORS_ONLN=91"

For socketpair, QNX need link an extra socket library.  Need add an sepearted m4 macro like as m4/acx_nanosleep.m4?

i am curious if this is going to be merged? Can I use this branch as it is?

@ibogosavljevic I also unsure whether it will be merged or not,  this patch is just work, not good.  I think you can use my qnx_port branch directly if you want.

What are the compilation instructions?
On Thu, Oct 5, 2023 at 6:27 AM Xiang.Lin @.***> wrote:

@ibogosavljevic https://github.com/ibogosavljevic I also unsure whether
it will be merged or not, this patch is just work, not good. I think you
can use my qnx_port https://github.com/iDings/gperftools/tree/qnx_port
branch directly if you want.
—
Reply to this email directly, view it on GitHub
https://github.com/gperftools/gperftools/pull/1443#issuecomment-1748013485,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACAJBL56NEM4SAAAKDKUFSDX5YZLPAVCNFSM6AAAAAA47IN7EWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBYGAYTGNBYGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

```shell
./configure CC="qcc -Vgcc_ntoaarch64le" CXX="q++ -Vgcc_ntoaarch64le" --host=aarch64-unknown-nto-qnx7.1.0 --enable-frame-pointers CXXFLAGS="-D__NO_EXT_QNX -D_SC_NPROCESSORS_ONLN=91"

What are the compilation instructions?
for qnx aarch64, use

./configure CC="qcc -Vgcc_ntoaarch64le" CXX="q++ -Vgcc_ntoaarch64le" --host=aarch64-unknown-nto-qnx7.1.0 --enable-frame-pointers

I compiled it with
./autogen.sh
 ./configure CC="qcc -Vgcc_ntoaarch64le" CXX="q++ -Vgcc_ntoaarch64le" --host=aarch64-unknown-nto-qnx7.1.0 --enable-frame-pointers CXXFLAGS="-D__NO_EXT_QNX -D_SC_NPROCESSORS_ONLN=91" --enable-minimal --enable-cpu-profiler

But in the .libs folder I don't see libprofiler.so.

Updates: on QNX socketpair api need link socket library, weired previous compile is passed.
And stash cpu profiler and libunwind support on an seperated branch: cpu profiler support on https://github.com/iDings/gperftools/tree/qnx_cpu_profiler, libunwind support on https://github.com/iDings/gperftools/tree/qnx_libunwind

@ibogosavljevic for cpu profile, you also need cherry-pick the change from https://github.com/iDings/gperftools/tree/qnx_cpu_profiler,  because QNX don't support SIGPROF,  the cpu profiler use wall-time,  see https://github.com/gperftools/gperftools/issues/1429#issuecomment-1728142330

Thanks a lot. I took first commit. Second I replaced with my own (which I think is better; let me know if you disagree). I am able to compile this with simple ./configure --host=x86_64-pc-nto-qnx7.1.0
I.e. no need to define odd things, hopefully. (But I am unable to test qnx binaries)

Thanks a lot. I took first commit. Second I replaced with my own (which I think is better; let me know if you disagree). I am able to compile this with simple ./configure --host=x86_64-pc-nto-qnx7.1.0

@alk thanks for your review.
you already had QNX SDP?  If yes, QNX SDP have a mkqnximage which can use to create a qemu qnx virtual machine.
This link https://doc.rust-lang.org/rustc/platform-support/nto-qnx.html#rust-std-library-test-suite have some guideline about how to use mkqnximage


SPI/FS fixes

Also fixes some problems on SAMD21

Ooops i merged it.

No big deal, will work on webusb in another branch


Question: how to install?

After adding the source files I get the following error:
Library not loaded: @rpath/MZAppearance.framework/MZAppearance
[...]
Reason: image not found

Check this, https://github.com/m1entus/MZFormSheetPresentationController/issues/49. You need to also import MZAppearance source files

Cool - thanks!


layouts: small fixes to website index

Signed-off-by: Lucas Servén Marín<EMAIL_ADDRESS>
[x] Change is not relevant to the end user.

Changes
Small grammar fixes to the website landing page.

ack rebased :)


Rancher UI requires a browser reload extremely  slow to do anything

Rancher versions:
rancher/server: 1.5.9
rancher/agent: 1.2.2
Infrastructure Stack versions:
healthcheck:
ipsec:
network-services:
scheduler:
kubernetes (if applicable):
Docker version: (docker version,docker info preferred)
1.12.6
Operating system and kernel: (cat /etc/os-release, uname -r preferred)
AWS linux machine, also happens on Ubuntu 14.04
Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
Steps to Reproduce:
Install rancher 1.5.9 with MySQL 5.6 or 5.7 with HA two nodes with virtually virgin install
Results:
If i create one stack or any task it does not complete in few but a several minutes or forever. I can only fix it if i refresh the browser and then it's done.
Not sure if this is a Browser or server or Database issue ?

To add , it takes a few second to complete but forever to refresh the status of the page unless i reload the browser page

Check the network tab of the browser dev tools, you're probably not connected to the websocket (/v2-beta/subscribe) for some reason.

 I'm using the ELB and not ALB for this setup. Are they any settings to make it work without having switch to ALB ?

TCP/TLS listener and target with PROXY protocol: http://docs.rancher.com/rancher/v1.6/en/installing-rancher/installing-server/#elb

Thank you so much , I have switched to ALB


Suppress building the main site from non-master branches.

Without this, the maintenance branches with older copies of the main site can overwrite changes, create races, etc.  One branch needs to be canonical for each part of the site.

This appears right to me, but I must admit that I didn't test it.

I tested it locally with and without environment variables, and I think it's right.  ghpages branch is git if it's not.

Travis failure is #591. Landing.


CI: Only deploy for upstream

Let's skip the deploy step for forks, it will fail because forks don't have secrets.ACTIONS_DEPLOY_KEY.
Also bump some versions.

@Anteru any objections?

No.


Possible to add to pypi?

Hi.
Any possibility of adding this to pypi similar to the sunvalley theme?
Thank you.

Coming soon. Stay tuned!

Thanks mate! I'd like to add it as an alternative theme for a gui I've made. I'll wait until it's on pypi first though.
Thanks for all the great work you do!

Hi, I know you are a very busy person but please remember this one. I look forward to adding this as a theme on my GUI. Thank you again.


[HUDI-500] Use enum method to replace switch case

What is the purpose of the pull request
this pr optimize a few codes
Brief change log
4 methods in the HoodieTableMetaClient have similar implementations which are switch HoodieTableType, we can refacor them use strategy pattern.

hi @dengziming, WDYT?
public enum HoodieTableType {

    COPY_ON_WRITE {
      @Override
      public String getCommitActionType() {
        return HoodieActiveTimeline.COMMIT_ACTION;
      }
    },

    MERGE_ON_READ {
      @Override
      public String getCommitActionType() {
        return HoodieActiveTimeline.DELTA_COMMIT_ACTION;
      }
    };

    public HoodieTimeline getCommitsTimeline(HoodieTableMetaClient metaClient) {
      return metaClient.getActiveTimeline().getCommitTimeline();
    }

    public HoodieTimeline getCommitsAndCompactionTimeline(HoodieTableMetaClient metaClient) {
      return metaClient.getActiveTimeline().getCommitTimeline();
    }

    public HoodieTimeline getCommitTimeline(HoodieTableMetaClient metaClient) {
      return metaClient.getActiveTimeline().getCommitTimeline();
    }

  public abstract String getCommitActionType();
}

Please update the title of pr

hi @dengziming, WDYT?
public enum HoodieTableType {

    COPY_ON_WRITE {
      @Override
      public String getCommitActionType() {
        return HoodieActiveTimeline.COMMIT_ACTION;
      }
    },

    MERGE_ON_READ {
      @Override
      public String getCommitActionType() {
        return HoodieActiveTimeline.DELTA_COMMIT_ACTION;
      }
    };

    public HoodieTimeline getCommitsTimeline(HoodieTableMetaClient metaClient) {
      return metaClient.getActiveTimeline().getCommitTimeline();
    }

    public HoodieTimeline getCommitsAndCompactionTimeline(HoodieTableMetaClient metaClient) {
      return metaClient.getActiveTimeline().getCommitTimeline();
    }

    public HoodieTimeline getCommitTimeline(HoodieTableMetaClient metaClient) {
      return metaClient.getActiveTimeline().getCommitTimeline();
    }

  public abstract String getCommitActionType();
}

this isn't consistent with before. In fact, only the getCommitTimeline of COPY_ON_WRITE and MERGE_ON_READ is identical, other methods are different.

I prefer to keep the code as-is and have this be in the TableMetaClient file.

I prefer to keep the code as-is and have this be in the TableMetaClient file.

maybe getCommitActionType can be moved to HoodieTableType, and the other 3 methods are fine as it is.

I prefer to keep the code as-is and have this be in the TableMetaClient file.

Hi @vinothchandar
In fact, this is a good programming skill. Enums can have constant-specific method implementations which simply means they can have abstract methods and they can override it.

@vinothchandar u r right, this change is introducing too many layers to make code awful, maybe should consider more to make code simple.

Thanks @dengziming. I agree with @vinothchandar to keep abstraction layers smaller and well defined to preserve orthogonality.

thank you @bvaradar , I thind you are right, it not a good design to bring to many abstraction layers.


[scatter] support country

allow placetype of country to be selected and when country is selected, show place as Earth
programmed together with Bo

dev updated (go to https://dev.datacommons.org/tools/scatter and choose country from the place type dropdown)

@googlebot I consent.


java: Cache is_musl() calls across AsyncProfiledProcess instances

I see it high in some profiles :)

Have you confirmed that the cache is of any help at all? The highs you have seen might come with zero reentrance (new short lived processes)

Haven't confirmed but the cost of the cache is 0 compared to the cost of reading /proc/pid/maps, and I have saw this issue often with many services

Have you confirmed that the cache is of any help at all? The highs you have seen might come with zero reentrance (new short lived processes)

Haven't confirmed but the cost of the cache is 0 compared to the cost of reading /proc/pid/maps, and I have saw this issue often with many services


Admin cluster tab refresh

Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

[x] Caught up with develop branch as of last change.
[x] Added CHANGELOG entry, or determined not required.
[x] Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
[x] Updated doc comments / prop-types, or determined not required.
[x] Reviewed and tested on Mobile, or determined not required.
[x] Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

New errorMessageBanner (local to the clusterTab component for now):

@lbwexler switched to using errorMessage cmp

(imagine it's the load balancer that's having the issue - every other request goes to a blackhole)

I think my proposal splits the difference -- it preserves maximal state,
and just masks things temporarily.
We could eventually replace the mask with the banner, but I think my
solution is less jarring
On Fri, Sep 13, 2024 at 10:36 AM Anselm McClain @.***>
wrote:

I'm going to let you guys decide which way you want to go on the error
handling - but I can really picture myself trying to work with the admin
client and looking at something specific in any of the cluster tabs to
diagnose an issue and then 💥 everything just disappears.
I would rather go the other direction, with eg the log viewer not clearing
itself so eagerly, but instead showing an indicator that you are looking at
a view that couldn't be refreshed.
I suppose there are two ways to think about how to make a tool like this
admin console reliable:

Never show anything that might be out of date - if in doubt, clear
and hide it all
Always strive to show/maintain what you can - something is going
wrong or flapping in / out, let an admin review / keep reviewing whatever
we can keep showing

🤷
—
Reply to this email directly, view it on GitHub
https://github.com/xh/hoist-react/pull/3783#issuecomment-2349113298, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AARTL2PB5WQBSGOZMU7MTGDZWLZ67AVCNFSM6AAAAABOBRCWY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBZGEYTGMRZHA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Proposal: Add support for colon delimited line number when opening files

Many compilers, runtimes and loggers output lines containing filename colon line number.
Currently i need to run vim /home/user/repo/myfile +123 to open a file at line number 123.
I'd like to instead run vim /home/user/repo/myfile:123; i.e. just cut and paste the log output including the line number into my command line.
I'd expect this behaviour to also apply to :tab new :vsp etc. (as the +123 version does now).
The +123 version would still have to be supported, in order not to break existing workflows and or scripts.
I know it's a minor difference, but it's a common usecase for me and I'm curious if others feel the same.

Duplicate of https://github.com/vim/vim/issues/4707 and https://github.com/vim/vim/issues/7224

You might be interested in one of these plugins:

vim-fetch
file-line
search-and-view


在iphone浏览器下hash路由问题

Version
3.0.1
Reproduction link
http://www.lulutopic.com/web/#/login
Steps to reproduce
1、设置hash路由
2、在iphone下打开带hash路由
3、点击浏览器‘复制’按纽
4、粘贴地址
What is expected?
粘贴地址带上hash部分
What is actually happening?
hash地址丢失

Copying the url is a browser interaction so this is likely to not be related to vue-router
That's not a valid repro anyway (it is explained in the issue helper)


get update

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: elijahneo sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Pretty bad artifacting in delta coding

New version of codec seems to produce some patches of extreme noise during p-frames.
I suspect the change to remove the >>1 from the delta coding may be to blame? Perhaps overflowing something internally, causing a patch of garbage data which doesn't recover until the next i-frame.

Should be fixed as of 1fb793115e72a36099f17ebb574e7d28832ac585


RTD PR builds are timing out

See https://readthedocs.org/projects/xray/builds/
There's no useful information in the logs AFAICT: e.g. https://readthedocs.org/projects/xray/builds/11504571/

This might be because of a matplotlib warning, see my own RTD setup. Not sure why the main build times out while mine fails cleanly.


[ISSUE #4739] Add TimerMessageStore runtime info in ClusterListSubCommand

Make sure set the target branch to develop
What is the purpose of the change
Add TimerMessageStore runtime info in ClusterListSubCommand
Brief changelog
Add TimerMessageStore runtime info in ClusterListSubCommand
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

@GenerousMan @ShannonDing PTAL~

Codecov Report

Merging #4740 (b3bccb7) into develop (c489a70) will decrease coverage by 0.19%.
The diff coverage is 36.95%.

@@              Coverage Diff              @@
##             develop    #4740      +/-   ##
=============================================
- Coverage      44.83%   44.63%   -0.20%
+ Complexity      7559     7535      -24
=============================================
  Files            977      977
  Lines          67641    67695      +54
  Branches        8934     8936       +2
=============================================
- Hits           30325    30217     -108
- Misses         33578    33734     +156
- Partials        3738     3744       +6

Impacted Files
Coverage Δ

...q/tools/command/cluster/ClusterListSubCommand.java
0.00% <0.00%> (ø)

...ocketmq/broker/processor/AdminBrokerProcessor.java
26.57% <45.45%> (+0.14%)
:arrow_up:

...apache/rocketmq/store/timer/TimerMessageStore.java
55.19% <60.00%> (+0.12%)
:arrow_up:

.../broker/subscription/SubscriptionGroupManager.java
68.79% <0.00%> (-14.19%)
:arrow_down:

...n/java/org/apache/rocketmq/test/util/StatUtil.java
16.19% <0.00%> (-14.09%)
:arrow_down:

...va/org/apache/rocketmq/store/FlushDiskWatcher.java
81.25% <0.00%> (-9.38%)
:arrow_down:

...va/org/apache/rocketmq/logging/inner/Appender.java
29.21% <0.00%> (-7.87%)
:arrow_down:

...org/apache/rocketmq/common/stats/StatsItemSet.java
41.79% <0.00%> (-5.98%)
:arrow_down:

...ketmq/common/protocol/body/ConsumerConnection.java
95.83% <0.00%> (-4.17%)
:arrow_down:

...controller/impl/DefaultBrokerHeartbeatManager.java
80.48% <0.00%> (-3.66%)
:arrow_down:

... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

Coverage decreased (-0.02%) to 49.08% when pulling b3bccb79352a8366bf27bfc7c04e2b6ca9857562 on RongtongJin:develop-zz into e8fd55bb0158df738d63854887fdc6b9e693a694 on apache:develop.


Jittery block rotation animation

The block rotation animation appears to be running at a low, inconsistent framerate compared to vanilla.
example: https://streamable.com/29it7t recorded at 60fps
Tested without any other mods and no config options seemed to change anything.

It looks like an oversight on my part. The rotation no longer had tickDelta added to it, so it was locked to 20fps increments.


nfs volume mount to mysql docker container inside a ubuntu virtualbox fail

I've a nfs file share set-up from freenas server, which I am mounting on a host linux (ubuntu 14.04 server)
mount -t nfs -o proto=tcp xxx.xxx.x.xxx:/mnt/freenas/nmedia /mnt/media

On the linux host, I've oracle virtualbox (4.3) installed and I've linux virtualbox  with shared folder from host /mnt/media (ubuntu 14.04 server again) in which I've installed kodi-xbmc. On this virtualbox, I've docker with following version details:
BUG REPORT INFORMATION
root@kodixbmc:~# docker version
Client version: 1.7.1
Client API version: 1.19
Go version (client): go1.4.2
Git commit (client): 786b29d
OS/Arch (client): linux/amd64
Server version: 1.7.1
Server API version: 1.19
Go version (server): go1.4.2
Git commit (server): 786b29d
OS/Arch (server): linux/amd64

root@kodixbmc:~# docker info
Containers: 1
Images: 15
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 17
 Dirperm1 Supported: false
Execution Driver: native-0.2
Logging Driver: json-file
Kernel Version: 3.13.0-32-generic
Operating System: Ubuntu 14.04.3 LTS
CPUs: 1
Total Memory: 1.463 GiB
Name: kodixbmc
ID: XJQY:LP5P:OOE3:5A5J:UJEB:JIDT:IVZT:J4I2:LIMR:NHKU:7KS7:V2AV
WARNING: No swap limit support

root@kodixbmc:~# uname -a
Linux kodixbmc 3.13.0-32-generic #57-Ubuntu SMP Tue Jul 15 03:51:08 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux

Steps to re-produce
I've mounted the shared folder from host into the virtualbox through the following start-up script with entry in /etc/rc.local:
#!/bin/bash
echo 'Mounting Share folder to /mnt/Share'
`sudo mount -t vboxsf -o uid=$UID,gid=root media /mnt/media`

I wanted to run the mysql container (built from https://github.com/sameersbn/docker-mysql) pointing to the /mnt/media/mysql through the following run command:
docker run -d --privileged --name=mysql -v /mnt/media/mysql/data:/var/lib/mysql -v /mnt/media/mysql/logs:/var/log/mysql mgmttools:443/phani/mysql:latest

Mysql demon is not starting, when I tried to connect to the terminal through
docker run -it --privileged --name=mysql -v /mnt/media/mysql/data:/var/lib/mysql -v /mnt/media/mysql/logs:/var/log/mysql mgmttools:443/phani/mysql:latest /bin/bash

and then execute the mysqld myself using/usr/bin/mysqld_safe it is able to write into the log file and following is the content of the log file
151006 11:02:19 mysqld_safe Starting mysqld daemon with databases from /var/lib/mysql
151006 11:02:19 [Warning] Using unique option prefix key_buffer instead of key_buffer_size is deprecated and will be removed in a future release. Please use the full name instead.
151006 11:02:19 [Warning] Using unique option prefix myisam-recover instead of myisam-recover-options is deprecated and will be removed in a future release. Please use the full name instead.
151006 11:02:19 [Note] Plugin 'FEDERATED' is disabled.
/usr/sbin/mysqld: Table 'mysql.plugin' doesn't exist
151006 11:02:19 [ERROR] Can't open the mysql.plugin table. Please run mysql_upgrade to create it.
151006 11:02:19 InnoDB: The InnoDB memory heap is disabled
151006 11:02:19 InnoDB: Mutexes and rw_locks use GCC atomic builtins
151006 11:02:19 InnoDB: Compressed tables use zlib 1.2.8
151006 11:02:19 InnoDB: Using Linux native AIO
151006 11:02:19 InnoDB: Initializing buffer pool, size = 128.0M
151006 11:02:20 InnoDB: Completed initialization of buffer pool
151006 11:02:20  InnoDB: Operating system error number 13 in a file operation.
InnoDB: The error means mysqld does not have the access rights to
InnoDB: the directory.
InnoDB: File name ./ibdata1
InnoDB: File operation call: 'create'.
InnoDB: Cannot continue operation.
151006 11:02:20 mysqld_safe mysqld from pid file /var/run/mysqld/mysqld.pid ended

Results received
Docker container doesn't get access to the mounted nfs volume
Results expected
Mysql container is expected to start without any errors pointing to the mounted nfs volume.
----------END REPORT ---------

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

rc.local typically occurs very late in the boot process. If you're starting docker from an init script, it's likely started before the mount comes up.
You should put the entry in /etc/fstab. Most distros ensure all mounts in /etc/fstab are up before proceeding with services.

@phemmer thank you very much for a quick and prompt response. I've tried to mount the share directory in virtualbox through fstab by many means and failed to achieve that and hence used thie rc.local approach.
media   /mnt/media      vboxsf  rw,auto,uid=0,gid=0,umask=0000  0       0

I've tried uid=$UID,gid=root; uid=1000,gid=1000. It always says "an error occurred while mounting press S to skip and M to manually modify"!
Apologies, I am shameless to accept I am coming from a windows background, all I am trying to do is what I've been learning from the experts out here online.

Also, I tried to restart the docker service using service docker restart before running the docker container, in this case it shall work right? But still having the same problem described in the original post.

InnoDB: The error means mysqld does not have the access rights to
This looks like the mysql user in the container does not have privileges to access the file.

But the same container working well from a windows host (windows 8.1, virtualbox 4.3) --> linux guest (ubuntu 14.04) --> docker. Also, I am running multiple other containers there.
Also, one more question, is there any prescription (I've been searching all over and couldn't find any) of the minimum set of privileges to be given to the share folders to be usable as volume mounts? If you could point me to the right place where I can find this, it would be great.

@phani1kumar It comes down purely to linux filesystem permissions.
You need to get the uid of the mysql process and ensure that the file has sufficient permissions for that user to access the file.
See http://linuxcommand.org/lts0070.php
I'm going to close this since it is not a Docker issue, but please feel free to ping me on #docker on IRC, or check out the docker-user mailing list.
Thanks!


Add mutliple callback

Remove callback from init
Add register_callback(callback) to appliance - allows multiple callbacks to register with single appliance (allowing for 1 event socket/appliance)

I don't think I did this "right" - looks like all commits from the other PR are in here too.
This should be everything needed for a single eventsocket per appliance - hopefully no new API actions appear that cause trouble.

Marking as draft (otherwise I get flooded with emails). Please mark as ready when finished.

I'll wait until the auth fix PR is approved... Sorry about the SPAM
On Fri, Sep 16, 2022 at 9:00 AM Abílio Costa @.***>
wrote:

Marking as draft (otherwise I get flooded with emails). Please mark as
ready when finished.
—
Reply to this email directly, view it on GitHub
https://github.com/abmantis/whirlpool-sixth-sense/pull/19#issuecomment-1249337796,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3GVBFBB2ZN3PFSNHBSGO3V6RVP5ANCNFSM6AAAAAAQM4YPEA
.
You are receiving this because you authored the thread.Message ID:
@.***>

I'll wait until the auth fix PR is approved... Sorry about the SPAM
…
On Fri, Sep 16, 2022 at 9:00 AM Abílio Costa @.> wrote: Marking as draft (otherwise I get flooded with emails). Please mark as ready when finished. — Reply to this email directly, view it on GitHub <#19 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3GVBFBB2ZN3PFSNHBSGO3V6RVP5ANCNFSM6AAAAAAQM4YPEA . You are receiving this because you authored the thread.Message ID: @.>

no problem! thanks for your help

No problem on the delay - no real hurry until we get the first HA PR approved.
I've been fairly happy with the performance over the last few weeks - no hangups at all.

Thanks again for your help. I've just published v0.18.0 to pypi.


test dynamic route flakiness (can't reproduce locally)

Temporal mitigation until https://github.com/reflex-dev/reflex/pull/4446 is ready
CI ran 2 times without failure


Move can be used to delete items

Describe the bug
Move is essentially a delete option in combination with custom permissions. Right now the permission Edit gives the option to update, copy or move a page or chapter.
Steps To Reproduce
Steps to reproduce the behavior:

Create two books (Book 1 & Book 2), Role A, a user in Role A and a page in Book 1
Set custom permissions for Book 1 for Role A to Create, View & Edit
Set custom permissions for Book 2 for Group A to Create, View, Edit & Delete
Move Page 1 from Book 1 to Book 2
Click Delete and the page is permanently deleted as the custom permissions of Book 1 don't matter for Book 2

Expected behavior
No option to move pages without the permission Delete from the source location as it deletes the item from the original location. Likewise as it needs the Create and not Edit permission on target location.
Copy doesnt't remove the original file from the original location so that's no problem.
Could be less of an issue with the recycle bin, but is still an isolated issue of its own.
https://github.com/BookStackApp/BookStack/issues/1017
Your Configuration:

Exact BookStack Version (Found in settings):  BookStack v0.24.2
PHP Version: 7.2
Hosting Method (Nginx/Apache/Docker): Apache2

Although I agree with what's said here (in particular about the recycle bin negating some of this), you should be able to Move elements within a Book.
@Bolthier was pointing out how you can potentially circumvent security to delete elements, but if the move was contained within the book the user had access to, the Delete permission shouldn't be required.
TJ

@sexy-trousers As it's possible to assign Delete permissions on a chapter by chapter base I think it would still be a potential security issue.
I think the same issue exists for the Sort Book function.


Android x support not working with 1.4.2

What kind of issue is this?
Latest version 1.4.2 is not working with AndoridX support libraries.
Info:

PinView version: 1.4.2

Pull Request #38 was merged but not released yet

Please upgrade to version 1.4.3.


Swipe not working if RecyclerView is using a GridLayout

Is there any way that we can implement it when the layout is a GridLayout?

+1, i really want use dragsort with GridLayout or StaggerredLayout

Hi. I have just published v0.8.0 and it supports swiping with GridLayoutManager (and maybe StaggerredLayoutManager also).


fix: Unhandled error when background fetching flags

Problem
Reported issues where failing API requests can crash the process (see here)
Changes
Don't throw but rather report up to the emitter
Release info Sub-libraries affected
Bump level

[ ] Major
[ ] Minor
[x] Patch

Libraries affected

[ ] All of them
[ ] posthog-web
[x] posthog-node
[ ] posthog-react-native

Thanks @benjackwhite 👍
cc @neilkakkar


To unspecific

Is that workload installed per project or per solution or globally?
If installed globally - does that require admin rights?
How do I get a list of the installed workloads?
Trying to publish a Blazor WASM solution I keep getting this error.
Severity	Code	Description	Project	File	Line	Suppression State
Error	NETSDK1147	To build this project, the following workloads must be installed: wasm-tools
To install these workloads, run the following command: dotnet workload install wasm-tools	Blazor2048	C:\Program Files\dotnet\sdk\6.0.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.ImportWorkloads.targets	38
I ran dotnet workload install wasm-tools in an elevated prompt. Worked without any error. Still getting error during publish
Ran the same command in the directory of the projects. Still getting error during publish
This is supposed to be easy. But there a hundreds of pitfalls where stuff just doesn't work out of the box or as described :-(

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1bc768e4-9b1f-3e7d-afb9-e0115f896eec
Version Independent ID: 6a0add91-7085-af96-9bac-de38e7249d35
Content: NETSDK1147: Missing workload for specified target framework - .NET CLI
Content Source: docs/core/tools/sdk-errors/netsdk1147.md
Product: dotnet-fundamentals
Technology: dotnet-cli
GitHub Login: @tdykstra
Microsoft Alias: tdykstra

@Rick-Anderson who can help with Blazor instructions?

@guardrex

Hello @hjrb ... A couple of quick answers, but we need to get you over to the product unit's ("PU") repo. They might ultimately redirect you elsewhere because AOT involves a few different groups of developers, but we'll start by having you open an issue over there for initial investigation.

It's a global install per my current information, and they suggested documenting the optional workload installation using either of the following approaches:

Use the CLI command, as this error message indicates.
For the ASP.NET and web development workload in the Visual Studio installer, select the .NET WebAssembly build tools option from the list of optional components.

They didn't provide further information, but I'll be tracking your PU issue for further doc improvements.

For guidance on the CLI command, see :point_right: https://docs.microsoft.com/dotnet/core/tools/dotnet-workload-install and the additional commands in that docs node, including the dotnet workload list command for a list of installed workloads. I don't have further information outside of what you see there in the When to run elevated section of the dotnet install command. You could open an issue from the bottom of that article if you feel that more detail is required in that section.

For Error NETSDK1147, please open an issue for the PU at ...
https://github.com/dotnet/aspnetcore/issues
They're responding to dev feedback on errors and problems with the new AOT, runtime relinking, and native dependencies features and tooling.
If you think to do so, please add a cc: @guardrex to the bottom of your opening comment. I track on their issues, but I don't see everything when I get super busy 🏃. If you mention me on the issue, I'll get the pings and keep tabs on the discussion for doc updates.

WRT this error not being helpful enough, mention that to the PU in your issue. This is a generic SDK error and doc topic, so nothing can be addressed here. AFAIK, it's possible for them to provide enhanced error output. Let them know what you would have found helpful, even if it's only an added link to further information (e.g., a cross-link to the dotnet install command article here).


Build script

This PR includes:

fixes a script build issue
runs test before build
prepares the build environment
rework build script
change PackIt relase config (Because when you create a release, PackIt creates too many unused PR into the RPM upstream.)

/packit copr-build

/packit copr-build

/packit copr-build

Great improvements, merging!


Bug when snoop floor

Bug cause when we snoop GetSideFaces

It is not a bug, floor does not have side faces. But indeed the user could be informed about that in a better way, there is room for improvement.


Added note about build dependencies in guide

Related: I think the references to Nightly on this page can be removed now that wasm32-unknown-unknown, and wasmm-bindgen work on stable, but I may be missing something.

I'm gonna go ahead and close this to help clean out the PR list a bit, but we can always link to Rust's own documentation about prerequisites!


0x119f095a45df2a77337042bcc4f2e52fA6e7e881.json and png

Official announcement:https://twitter.com/Minesweeper_SM/status/1462991043163426817
Team background：
The SuperMinesweeper team is located in Australia, and the core members have more than 10 years of Internet product development experience on average，Greg is an experienced CEO with an amazing history of contributing significant value to Fortune 500 companies. Greg has expertise in developing business strategies and a strong interest in the blockchain space. As an early adopter of NFT and a fan of multiple fields including games, art and anime, Greg is striving to define the NFT ecosystem with cutting-edge innovative solutions.
Project Basic Information：
The biggest difference between "Super Minesweeper" and Microsoft Minesweeper is that it empowers the game map to make a perfectly replicated decentralized + NFT + P2E + DeFi game for the vast number of cryptocurrency lovers and Minesweeper lovers. The game map that users play is not generated by the system, but a unique game map created by users, uploading the map parameters to the block chain to obtain NFT credentials, Minesweeper starts by referring to the NFT parameters on the chain to obtain the game map. At the same time, the user creates and generates the game map NFT can be stored and traded.
Website：https://smcoin.info
Twitter: https://twitter.com/Minesweeper_SM
Media reports:
AP NEWS https://apnews.com/press-release/kisspr/technology-blockchain-2f1c91832b02eac815f95f154873605b
Recommended gas limit: 60000
Exchange：
https://pancakeswap.finance/swap?outputCurrency=0x119f095a45df2a77337042bcc4f2e52fa6e7e881

Official website letter contains false information

Hi,
please let me know what is false information，then I can fix it.
Have a good one
Thank you
skinshuaan1 @.***> 于2021年11月29日周一 下午3:18写道：

Official website letter contains false information
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/consenlabs/token-profile/pull/7270#issuecomment-981351115,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWOD64F4OARWNUQ4ZIJIBH3UOMSMXANCNFSM5ISQOY5Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Missing Jetton Transfers in Transaction Query

I'm attempting to retrieve transactions, but I am only receiving a single transaction involving TON transfer. Is it possible to also retrieve transactions with Jetton (USDT) transfers?
Explorer Link:
TONSCAN Explorer
There should be two USDT transfers and one TON transfer visible for the address.
Code Sample:
package main

import (
	"context"
	"encoding/base64"
	"log"

	"github.com/xssnick/tonutils-go/address"
	"github.com/xssnick/tonutils-go/liteclient"
	"github.com/xssnick/tonutils-go/ton"
)

const (
	num = 10
)

func main() {
	client := liteclient.NewConnectionPool()
	err := client.AddConnectionsFromConfigUrl(context.Background(), "https://ton.org/global.config.json")
	if err != nil {
		panic(err)
	}

	api := ton.NewAPIClient(client, ton.ProofCheckPolicyFast).WithRetry()

	accountAddr := address.MustParseAddr("UQC7CECsMMrNJVcxJH8TlR-tK8yTS3gOC2JVvQdYyeC1RVZA")

	// we need fresh block info to run get methods
	b, err := api.CurrentMasterchainInfo(context.Background())
	if err != nil {
		log.Fatal(err)
	}

	// we use WaitForBlock to make sure block is ready,
	// it is optional but escapes us from liteserver block not ready errors
	res, err := api.WaitForBlock(b.SeqNo).GetAccount(context.Background(), b, accountAddr)
	if err != nil {
		log.Fatal(err)
	}

	lastTransactionId := res.LastTxHash
	lastTransactionLT := res.LastTxLT

	headSeen := false

	for {
		trxs, err := api.ListTransactions(context.Background(), accountAddr, num, lastTransactionLT, lastTransactionId)

		if err != nil {
			log.Fatal(err)
		}

		log.Printf("transaction count %d", len(trxs))

		for i, tx := range trxs {
			// should include only first time lastTransactionLT
			if !headSeen {
				headSeen = true
			} else if i == 0 {
				continue
			}

			if tx.IO.In == nil || tx.IO.In.Msg.SenderAddr().IsAddrNone() {
				// external message should be omitted
				continue
			}

			if tx.IO.Out != nil {
				// no outgoing messages - this is incoming Toncoins
				continue
			}

			// process trx
			log.Printf("found in transaction hash %s", base64.StdEncoding.EncodeToString(tx.Hash))
		}

		if len(trxs) == 0 || (headSeen && len(trxs) == 1) {
			break
		}

		lastTransactionId = trxs[0].Hash
		lastTransactionLT = trxs[0].LT
	}
}

Can you help me understand how to modify the code to retrieve Jetton transfer transactions alongside the TON transfer? Thanks!

Hi, as i see in explorer you have only one out transaction and you see it, if you want to see incoming then remove tx.IO.Out != nil

Currently, I have 8 transactions in total: 6 involving TON (5 incoming, 1 outgoing).

When I call the following method:
trxs, err := api.ListTransactions(context.Background(), accountAddr, num, lastTransactionLT, lastTransactionId)
And log the number of transactions:
log.Printf("transaction count %d", len(trxs))
I also print the transaction hashes:
for i, tx := range trxs {
    log.Printf("found transaction hash %s", base64.StdEncoding.EncodeToString(tx.Hash))
}

However, I'm not receiving two transactions where I received USDT. The hashes for these missing transactions are:
(5c508c90aa472e06fa063b9d0396fec1975e1f5760d982363b3035f5bf0f7122, eDdYeBMSmHRDDeYyRzlhmUAFg/MqlbAOOiGT4W+PRdA=)
These transactions don't appear in the response, and I'm unsure why they're missing. Any ideas on what might be causing this?

@keyliaran Thanks for posting the issue.
Your query would be best dealt with by the support team.
Please see the link below to our dedicated support line:
Support : Help Center
Note: Click on the live chat icon at the bottom corner of the page to start a conversation


Method Buy - IllegalStateException

Hello,
On Google Play Console I have crash report with this stack trace:

I'm not able to reproduce:  When I buy an object everything works well but it's a test purchase.
Do you know if I miss something? This seem to concern every device (3 exemples since I use 2.2.0 )

Hello! Thanks for your feedback and finding out the source of the issue.
That's probably something we could prevent directly in the plugin. What do you think about it?

Hello!
In the plugin itself, you maybe can catch the IllegalStateException and return a specific error code (like "operation already in progress".
But I don't think that disable methods during process is a good idea. It's the game develpper responsability.
I personaly disabled the "buy" button after the first click and until I have a success or error callback and I did not have error report anymore since few days.

Hi,
Is that what you had in mind ?

Absolutely 👍


0x protocol fee.

https://github.com/AugurProject/augur/blob/b380634f04fcf5fa18e3ae3f7739c70f1dc41026/packages/augur-core/source/contracts/trading/ZeroXTrade.sol#L215
Currently the protocol fee is hard coded in the contracts.  This means that if the fee rate changes, then Augur will stop working with 0x.
However, if a change is made to blindly fetch the fee at runtime and forward the whole thing, then the 0x Exchange owner has the opportunity to exit scam by jacking the fee way up and seeing how many users confirm the transaction without checking the fee amount (my guess is most users will fall to this scam until word gets out).
I'm not sure how to address this in a way that both protects Augur users from malicious fee changes while also allowing non-malicious fee changes through.  Best option I can think of is to ensure that the UI makes it incredibly prominent how much of a fee is being charged by 0x, and to protect Augur's reputation make it clear that this portion of the fee is a 0x fee, not an Augur fee.

Another option would be to have the UI accept any fee changes within a range, but require a UI update to go beyond that.

And pass the protocol fee in as an argument in the calldata?

Yeah, I believe it is already part of the order.


feat: Add SQS subscription option

Description
Added resources to create SQS subscription when desired.
Motivation and Context
Currently this module only created an SNS topic. I wanted the ability, using boolean, to create an optional subscription to SQS queues.
Breaking Changes
None
How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

No responses for this?

Thanks for your response @antonbabenko. I will work on incorporating those changes.


Enable specifying the ip address and port for the spectator view experience at runtime

This will primarily affect mobile experiences. Spectator devices should be able to specify user ip addresses/ports at runtime. This may also be improved by enabling showing the user ip address in the application.

When preparing this change, we should also check that spectator devices don't attempt to connect to local host. This can cause some weird behavior where the spectator ends up listening to messages from itself.

Flagging this as blocking based on how much the lack of this ability degrades the experience


Directions widget improvement

When using the directions widget, it is not possible to save a route to the current map. I can save it to a Route Layer in my content but the Add Data widget does not recognize route layers. It would be great if the user could save the route to a feature service in the web app, similar to how the ERG and Bomb Blast widgets can write data to an existing layer (or new layer). We need this ability to save the route so users can buffer the route to find incidents within a certain distance using the Situational Awareness widget.

If you have ideas for products they should be submitted via ArcGIS Ideas https://community.esri.com/t5/custom/page/page-id/arcgis-ideas


LRS: actor id is not expanded with the IDToken.

backend IDP did not provide the ID token as expected


Busy Does Not Build Docker Container

I wanted to test out Busy in a Docker container and made a simple test which produced an error:
From a FRESH git clone of the busy repository:

lonnie@lan101:~/busy/versions$ git clone https://github.com/busyorg/busy.git

Cloning into 'busy'...
remote: Counting objects: 34575, done.
remote: Compressing objects: 100% (199/199), done.
remote: Total 34575 (delta 143), reused 139 (delta 81), pack-reused 34295
Receiving objects: 100% (34575/34575), 62.13 MiB | 12.62 MiB/s, done.
Resolving deltas: 100% (25570/25570), done.
Checking connectivity... done.

lonnie@lan101:~/busy/versions$ cd busy/

lonnie@lan101:~/busy/versions/busy$ docker build -t busy .

Sending build context to Docker daemon  69.62MB
Step 1/8 : FROM node:alpine
alpine: Pulling from library/node
605ce1bd3f31: Pull complete
f10758dcda1f: Pull complete
4cbe43d669e5: Pull complete
Digest: sha256:b9e63df2deb2b0a30cf67ec8f66ae433dacd2d99d16465bf98884baf8ce7c398
Status: Downloaded newer image for node:alpine
---> 7af437a39ec2
Step 2/8 : RUN mkdir -p /usr/src/app
---> Running in bf8c93cb70f7
Removing intermediate container bf8c93cb70f7
---> 40bc6cff45fc
Step 3/8 : WORKDIR /usr/src/app
Removing intermediate container<PHONE_NUMBER>a1
---> d5ecb92e078a
Step 4/8 : COPY . /usr/src/app
---> 57ceb7b67873
Step 5/8 : RUN yarn install
---> Running in 40d493a6afa8
yarn install v1.5.1
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
error An unexpected error occurred: "Couldn't find the binary git".
info If you think this is a bug, please open a bug report with the information provided in "/usr/src/app/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
The command '/bin/sh -c yarn install' returned a non-zero code: 1
Are there any updates to the Docker file in the github to fix this?
Thanks and have a great day

I think that I resolved the issue by adding git to alpine:
Dockerfile ---------------------
FROM node:alpine
RUN mkdir -p /usr/src/app
WORKDIR /usr/src/app
COPY . /usr/src/app
RUN apk update && apk upgrade &&
apk add --no-cache bash git
RUN yarn install
RUN yarn run build
EXPOSE 3000
CMD yarn start
Cheers :)


translate intro to DOM and closures README

Translation of: 3-terrarium/3-intro-to-DOM-and-closures README to portuguese.
#341

Sorry! Fix done.
Thanks!


[question]MongoDB y Redis in Community edition

Community edition has support for mongo and redis?
If the answer is no, it is going to have?
Thanks

No, only EE version has support of Mongo and Redis.
There are no short-term plans to include them in CE.

Thanks


New tests

small touch ups, primarily for better error responses from okta_jwt.jwt
test coverage at 100%

LGTM


Fix PHP 7.4 RC2 incompatibility

Fixes #134

@erusev could you please merge this important fix for PHP 7.4 compatibility. The library is totally unusable on PHP 7.4 otherwise.

Done.
@aidantwoods can we create a patch release for this change?

Better to merge in the travis stuff and fix the tests first.

https://github.com/erusev/parsedown-extra/pull/141


Updates to docs to reflect new use of Result

A few tweaks to README / comments to update them to reflect the new Result return from validate.
Previously this would just return a list of validation errors but this is now wrapped in Result and (if valid) Valid

No problem! Have amended and pushed the update 👍


Jerky animation & multiple placeholders created

I upgraded this directive in my project from version 1.7.10 to the current 1.8.3 and experienced some issues that are preventing me from keeping the updated version.  I decided to make a simple demo to show the issues I was seeing, but the basic demo turned out to have a bunch of issues of it's own.
basically I am using this
 $scope.headerIsSticky=true;

Sticky Header

      <input type="checkbox" ng-model="headerIsSticky" /> Sticky?

:beetle:  When the window small & is below the triggers for the media query multiple placeholder elements are created. My content gets pushed down the page further and further.  The header element rapidly switches between being sticky and not being sticky.
:beetle: When the element is scrolled down and stick, and then I disable the stickiness, the placeholder element still remains and take up space when it should not
Demos
(When viewing the demos, be sure to open it in a new window it doesn't play well with the scrollable frame on the plnkr website.)
Code using v1.8.3: http://plnkr.co/edit/2MUAL8sw0IX3QnVbLvEg?p=preview

The above code works perfectly in version 1.7.11, so these seem like regression bugs.
Code using v1.7.11: http://plnkr.co/edit/XR30tyL1Y0RsLu5MMYHj?p=preview

I am experiencing the same issue here.

Have you tried upgrading to 1.84? It looks like the latest version has some fixes for the placeholder creation.

Nope, still has some issues.  Here's the same test with v1.8.5 now: http://plnkr.co/edit/ADRCObbB0mzgK2Pg0Okw?p=preview
To recreate issues: Open that link and click the blue "launch preview in a separate window" icon in the upper left of the preview (this directive doesn't play well when in a frame)
Issue 1 - placeholder not removed
To recreate:

use the link 7 instructions above.
Ensure that the "sticky?" box is checked
Scroll down a bit
uncheck the box
scroll back up to the top
:beetle: the placeholder is still there taking up space.
:beetle: Toggling the checkbox does not add/remove the placeholder.

Issue 2 - jerky craziness when using the responsive features
To recreate:

use the link 7 instructions above.
Ensure that the "sticky?" box is checked
resize the window to be more narrow, less than 992 pixels wide
:beetle: scroll down - the sticky element jumps in and out of the view like crazy
:beetle: scroll back up, the placeholder remains taking up space.
:beetle: Toggling the checkbox does not add/remove the placeholder.

+1 on this issue

UPDATE: I tried this again with version 1.8.6 (maybe 1.8.7 though?  The package.json file has a different version number than the version in the JS file... hard to tell what version is out right now)
It appears that Issue 2 from my last comment 5 months ago has been fixed, however Issue 1 still remains.
Here is an updated demo link: http://plnkr.co/edit/BEK8JIYErmv7vhr5U1HU
Remaining Issue: placeholder not removed
To recreate:

Open the link above and click the blue "launch preview in a separate window" icon in the upper left of the preview (this directive doesn't play well when in a frame)
use the link & instructions above.
Ensure that the "sticky?" box is checked
Scroll down a bit
uncheck the box
scroll back up to the top
:beetle: the placeholder is still there taking up space.
:beetle: Toggling the checkbox does not add/remove the placeholder.

please please please find a fix for this.  Basically we are all required to use a much older version (with other undesirable bugs) until this is fixed.

The issue remains with latest release (1.8.10)
Demo: http://plnkr.co/edit/PZJknd1UEptvtp8uEDKZ?p=preview


Migration error if users already has soft deletes

If your users model already uses soft deletes, the migration throws an error because it attempts to add them again. Also, rolling back the migration will drop soft deletes, which may not be what someone actually wants.
One possible way I can think of to remedy this would be with a config setting that says to add/remove soft deletes in the migration or not.
Expected Behavior
Migration runs successfully
Current Behavior
Migration fails because the deleted_at column already exists
Failure Information
SQLSTATE[42S21]: Column already exists: 1060 Duplicate column name 'deleted_at' (SQL: alter table `users` add `shopify_grandfathered` tinyint(1) not null default '0', add `shopify_namespace` varchar(255) null, add `shopify_freemium` tinyint(1) not null default '0', add `plan_id` int unsigned null, add `deleted_at` timestamp null)

Steps to Reproduce

Add soft deletes to the users model
Run package migrations

Context

Package Version: v13.0.0
Laravel Version: v7.28.3
PHP Version: v7.4.6

Failure Logs
N/A

Thanks, I'll have to look into a config option.

@osiset I'd be willing to work on that if you don't have the time for it.

if (!Schema::hasColumn('users', 'deleted_at')) { can be used. I can do an update later for this.

Merged, closing.