Integration tests do not work on MacOS

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When I run integration tests from my MacOS system, I cannot connect to the KIND cluster in which the integration tests deploy.
As per Docker's own documentation, this is not possible without a workaround.  See https://docs.docker.com/docker-for-mac/networking/.
Expected Behavior
Integration tests should run on MacOS as they do on Linux to provide a seamless developer experience across platforms.
Steps To Reproduce
1. On MacOS
2. Run `make test.integration`
3. Observe the following error(s):

time="2021-07-30T20:00:58-05:00" level=error msg="admission webhook server stopped" error="listen tcp <IP_ADDRESS>:49023: bind: can't assign requested address"
time="2021-07-30T20:00:58-05:00" level=info msg="WARNING: log stifling has been enabled (experimental)"
time="2021-07-30T20:00:58-05:00" level=info msg="diagnostics server is starting to listen" addr=10256
    controller_test.go:22: WARNING: error while waiting for http://localhost:10254/healthz: Get "http://localhost:10254/healthz": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
    controller_test.go:22: WARNING: error while waiting for http://localhost:10254/healthz: Get "http://localhost:10254/healthz": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
    controller_test.go:22: WARNING: error while waiting for http://localhost:10254/healthz: Get "http://localhost:10254/healthz": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
    controller_test.go:22: WARNING: error while waiting for http://localhost:10254/healthz: Get "http://localhost:10254/healthz": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
    controller_test.go:22: WARNING: error while waiting for http://localhost:10254/healthz: Get "http://localhost:10254/healthz": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
    controller_test.go:22: WARNING: error while waiting for http://localhost:10254/healthz: Get "http://localhost:10254/healthz": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
    controller_test.go:22: WARNING: error while waiting for http://localhost:10254/healthz: Get "http://localhost:10254/healthz": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
    controller_test.go:22: WARNING: error while waiting for http://localhost:10254/healthz: Get "http://localhost:10254/healthz": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
    controller_test.go:22: WARNING: error while waiting for http://localhost:10254/healthz: Get "http://localhost:10254/healthz": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
    controller_test.go:22: WARNING: error while waiting for http://localhost:10254/healthz: Get "http://localhost:10254/healthz": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
    controller_test.go:22: WARNING: error while waiting for http://localhost:10254/healthz: Get "http://localhost:10254/healthz": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
panic: controller manager exited with error: unable to start proxy cache server: making HTTP request: Get "http://<IP_ADDRESS>:8001/": context deadline exceeded

goroutine 404 [running]:
github.com/kong/kubernetes-ingress-controller/test/integration.deployControllers.func1(0x6b068f0, 0xc000545ec0, 0x0)
        /Users/sdustin/VSCode/scottnetlab-github/kubernetes-ingress-controller/test/integration/suite_test.go:315 +0x13fb
created by github.com/kong/kubernetes-ingress-controller/test/integration.deployControllers
        /Users/sdustin/VSCode/scottnetlab-github/kubernetes-ingress-controller/test/integration/suite_test.go:252 +0x292
FAIL    github.com/kong/kubernetes-ingress-controller/test/integration  116.188s
FAIL

Kong Ingress Controller version
Working from `next` branch.

Kubernetes version
From the integration test:

INFO: container environment ready
INFO: DOCKER=(Docker version 20.10.0, build 7287ab3)
INFO: KIND=(kind v0.11.1 go1.16.4 darwin/amd64)
INFO: KUBECTL=(Client Version: v1.18.2-6+38ac483e736488)
INFO: HELM=(v3.4.1+gc4e7485)

Anything else?
Suggest potentially using --network host with the KIND cluster (is possible) when the underlying OS is Mac.  We have done that in some past projects I've worked on to get this working on Mac.  See https://github.com/vmware-tanzu-labs/reference-platform-for-kubernetes/blob/develop/Makefile#L33 for an example.

Thanks for bringing this up :bow:
The problem stems from the Kong Kubernetes Testing Framework using Kubernetes In Docker (KIND) as the default cluster implementation for tests, and expecting that LoadBalancer type services that use Docker network IP addresses (utilized via MetalLB) will be rout-able from the host. The history behind this comes from the CI running on Linux, and the maintainers up until recently all using Linux development systems: for Linux this is true, as the iptables and routing rules by default will allow the host to access the Docker network when Docker is running natively on the same host, but the same is not true on Mac as it can't run Docker natively and it often connects to Docker in a VM or on an external Linux system.
There are a few different options on how we can fix this:

drop LoadBalancer services as the mechanism to communicate with cluster services during tests and use the Kubernetes API port-forwarding mechanism instead
develop configurations and rules for our kind based testing deployments that will allow MacOS hosts to connect to the LoadBalancer IPs directly
load and run the integration test suite inside of kubernetes itself and drop all external access

Personally I think option 1 is the quickest, option 2 is the most complete (but I don't personally use macos so I'm limited some in my ability to help), and option 3 could really just stop us from ever needing any special rules to run the tests but probably is the longest of the 3 options to implement and introduces some other considerations.
We would like to hear back from you on your thoughts and preference in this matter, let us know if you have a preference as a contributor, and if you are interested in or able to directly contribute to the fix?
As an immediate workaround: In next right now there is some preliminary support for running the integration test suite against a GKE cluster. This is not well matured functionality yet so if you're interested in using it feel free to reach out here for help, and its not ideal because it may end up costing extra money, but just to note that it is technically an option.

Thanks for the response @shaneutt !  I believe option 2 is what I'm looking for as it provides the most similar environment to a working installation as well as the most complete coverage for developers for the project.  My workaround has simply been to use a Linux VM in AWS, which has been sufficient in the short-term.
I may have some time to contribute a fix for MacOS, however it may be a few weeks, as I've got a lot going on both during and after work :)
I believe that the configuration (whatever that may look like in the end) should end up in the testing framework repo at https://github.com/Kong/kubernetes-testing-framework.  Please let me know if I should open an issue over there as well, or if this issue will suffice.

Sounds good, no rush on anything. This does belong over in the testing framework, I think we should probably keep this issue open for posterity and in case anyone else comes along with the same problem (because it's not obvious I think for most people to go check out ktf) and feel free to open a new issue in KTF for the specific action (number 2 above). :+1:


Pipeline hotfix bug

Context
https://github.com/LerianStudio/midaz/actions/runs/12400711636/job/34618555339
Quando abro mais de uma hotfix da develop para main, pelo fato de não ter pre-release o hotfix quebra e não gera release.

Error: AggregateError:
SemanticReleaseError: The pre-release branches are invalid in the branches configuration.
at default (file:///home/runner/work/_actions/cycjimmy/semantic-release-action/v4/node_modules/semantic-release/lib/get-error.js:6:10)
at file:///home/runner/work/_actions/cycjimmy/semantic-release-action/v4/node_modules/semantic-release/lib/branches/index.js:45:19
at Array.reduce ()
at default (file:///home/runner/work/_actions/cycjimmy/semantic-release-action/v4/node_modules/semantic-release/lib/branches/index.js:35:46)
at async run (file:///home/runner/work/_actions/cycjimmy/semantic-release-action/v4/node_modules/semantic-release/index.js:68:22)
at async Module.default (file:///home/runner/work/_actions/cycjimmy/semantic-release-action/v4/node_modules/semantic-release/index.js:278:22)
at async release (/home/runner/work/_actions/cycjimmy/semantic-release-action/v4/src/index.js:31:18)

How to do it?
validar as hotfix para sempre gerar a release independente se tem pre-release
Changes

@lfbarrile01 @GuilhermeMRodrigues


Large build logs not rendering in build window

A large build log is not rendering completely in the build log window on the build page.
The downloaded log file looks to be complete.  I also notice a discrepancy between the line numbers in the build log window and the downloaded log file.  The downloaded file appears to have quite a few less lines.

Thanks for reporting this @jonvanausdeln - if you are able to without disclosing any unwanted/sensitive info, could you share some screenshots and a sample repo that will reproduce the issue so we can see what you're experiencing?

Sorry it took me a little bit to get back to this.  I went and looked at our builds and don't see the issue any longer.  This issue can be closed.  Thanks.

Thanks, please reach out if you have any other issues.


Add support for reconfig cluster membership operation

ZK 3.5 introduced a new reconfig operation to change the cluster memberships at runtime. The feature was tracked in https://issues.apache.org/jira/browse/ZOOKEEPER-107. The bulk of the work happened in http://svn.apache.org/viewvc?view=revision&revision=1453693.
This is the new type code 16.

WIP: https://github.com/rgs1/kazoo/tree/support-reconfig, comments welcomed! Will add tests later this week.

So this PR has basic coverage for this feature: https://github.com/python-zk/kazoo/pull/333. That being said, there are some server-side bugs to be addressed (i.e.: https://issues.apache.org/jira/browse/ZOOKEEPER-2202), but it would be nice to have this in so I can support it in zk-shell!

It appears this was handled by #333


Cannot use a scalar value as an array in /vendor/mandango/mandango/src/Mandango/Document/Document.php line 19

I only read data in document but sometime mandango has error "Cannot use a scalar value as an array", can anyone help me?

This has to do something with the query cache. I've encountered the same error message by reading a document with embedded array of documents (embeddedsMany). After clearing the cache (by issueing rm /tmp/*.php) the first query runs OK, the seconds throws this error.

Gotcha. It happens in function all() in Model\Base\XYZQuery (where XYZ is the model in question). The getFields() function can return a field name like "a", and if that field is an array of embedded documents, it will return something like "a.0.b" too. This messes up the $f variable. An is_array() check solved the problem for me. Preparing PR.


worker: set up bridge parameters dynamically

Set up the bridge parameters for the qemu worker dynamically. This is to avoid conflicts when multiple workers + qemu instances are running on the same host.
The following are dynamically generated instead of being hardcoded/set with env variables:

bridge name
bridge ip
dnsmasq dhcp range
qemu vnc port
qemu qmp port

Change-type: patch
Signed-off-by: Ryan Cooke<EMAIL_ADDRESS>Required-by: https://github.com/balena-os/leviathan/pull/568

@balena-ci rebase

@balena-ci rebase

I think these 3 commits can be squashed but then I'll sign off.

good to go @klutchell


Updated regex to account for fine-tuned models

Updated regex (that checks whether to use the chat completion mode based on the model name) to account for fine-tuned models

Hey! Thanks so much so sending this in! Would you be willing to update this PR to account for the new pythonic 0.1 version? It just means changing the same regex here: https://github.com/guidance-ai/guidance/blob/a3af014512051e747634e32c06a47a883787c2c3/guidance/models/_openai.py#L32

Hey! Thanks so much so sending this in! Would you be willing to update this PR to account for the new pythonic 0.1 version? It just means changing the same regex here:
https://github.com/guidance-ai/guidance/blob/a3af014512051e747634e32c06a47a883787c2c3/guidance/models/_openai.py#L32
I can of course copy it over myself, but would like credit given where it is due :)

Thanks @slundberg! I've pulled the latest changes and updated the regex in the new pythonic 0.1 version. Let me know if it needs anything else.

Hi @marawan1805, just me taking the time to got back over this :) ...which I just did. It looks great, so merging now. Thanks!

Thank you!


threadpool init

Concurrent implementations use a threadpool or equivalent. For some langs, initialization of that resource is done explicitly.
In the explicit cases, should threadpool init happen after the processing timer starts or is it okay to do it beforehand?
Some impls do it beforehand e.g. rust_con and AppParallel.java, some do it afterward e.g. d_con and swift_con.
Cleaning up that resource is automatic in some langs, and for others it's at least a good practice to do so explicitly. In the latter case, is it okay to do it after the processing timer stops?
I raise the issue because I'm working on some speedups for nim_con and if I move threadpool init before timer the starts, the performance is a litter better and the numbers are slightly less bouncy. But then I wondered what other concurrent impls here are doing and saw that it varies.

I would expect all processing (including thread creation) to have after the timer. I think Go also did it in that way

I agree with @cyrusmsk


Data.UnionFind.IntMap, Add path compressing repr and equivalence

Consider
repr       :: PointSupply a -> Point a -> Point a
descriptor :: PointSupply a -> Point a -> a
equivalent :: PointSupply a -> Point a -> Point a -> Bool

They do not perform path compression, which may lead to O(n) performance for some points. It is nice to have simple interfaces where the updated PointSupply doesn't need to be handled. But, it would be nice to also have the following functions:
repr'       :: PointSupply a -> Point a -> (PointSupply a, Point a)
descriptor' :: PointSupply a -> Point a -> (PointSupply a, a)
equivalent' :: PointSupply a -> Point a -> Point a -> (PointSupply a, Bool)

That do path compression. It would be particularly nice to have in the Control.Monad.Trans.UnionFind transformer.

Hmm, so it wasn't only me who didn't find path compression in this extremely efficient union-find library.


feat: Update useBlocker hook to provide current and next location when conditionally blocking

Currently, when using the useBlocker hook there is no way to ascertain where the navigation being blocked is headed.
For my usage of blocking, this is necessary to allow navigation within a selected bunch of nested routes, but not allowing the user to exit the base route. Thought this could be a useful feature to have.

we wanted to follow react-router's API for this:
https://reactrouter.com/en/main/hooks/use-blocker
can you adjust your PR to match it?
also, the location should be typesafe  instead of just a string.
additionally, we would also need tests for useBlocker

we wanted to follow react-router's API for this:
https://reactrouter.com/en/main/hooks/use-blocker
can you adjust your PR to match it?
also, the location should be typesafe instead of just a string.
additionally, we would also need tests for useBlocker

Yes sounds good, I will update the PR as soon as possible

This implementation should now be providing the blockerFn inuseBlocker with a similar API to the hook in react-router. This also makes the blocker catch backwards navigation using the browser back buttons, which is very beneficial for our use case.
Things left to do:

[ ] Tests
[ ] Update docs/examples?

I am not quite sure how to do with the old blockerFn since it now behaves in a completely different way now. So any hints from someone on this would be appreciated.
Would also like to give a quick pitch for a different interface that could be used for useBlocker which I have implemented in our codebase with these changes:
import React from 'react'
import type { BlockerFn } from '../../lib/router/qudak-router'
import { BlockerFn, useRouter } from '@tanstack/react-router'

type BlockerOpts = {
  blockerFn: BlockerFn
  disabled?: boolean
}

export function useBlocker({ blockerFn, disabled = false }: BlockerOpts) {
  const { history } = useRouter()

  React.useEffect(() => {
    return disabled ? undefined : history.block(blockerFn as BlockerFn)
  }, [blockerFn, disabled, history])
}

Which gives very clean implementations for custom UIs using hooks and could look something like this:
  useBlocker({
    blockerFn: () => {
      if (blockerDisabled && blockerDisabled.current) {
        blockerDisabled.current = false
        return false
      }
      if (!blockerDisabled && _blockerDisabled.current) {
        _blockerDisabled.current = false
        return false
      }
      const shouldBlock = blockerFn()
      if (!shouldBlock) return false

      const promise = new Promise<boolean>((resolve) => {
        modals.open({
          title: 'Are you sure you want to leave?',
          children: (
            <SaveBlocker
              onSave={onSave}
              onDiscard={onDiscard}
              close={() => {
                modals.closeAll()
                resolve(false)
              }}
              confirm={() => {
                modals.closeAll()
                resolve(true)
              }}
              reject={() => {
                modals.closeAll()
                resolve(true)
              }}
            />
          ),
          onClose: () => resolve(false)
        })
      })

      return promise
    },
    disabled
  })

Any thoughts on this?

This would be a breaking change to useBlocker, right? then we cannot do it (now, only possible in v2).

While this might be out of scope for this PR. I think we can likely do much better from a type safety point of view for useBlocker. Correct me if I'm wrong but useBlocker blocks a navigation and we usually describe navigations with from and to.
I was imagining a more type safe hook.
useBlocker({ from: Route.fullPath, to: '..', blockerFn: ({ fromMatch, toMatch }) => // have I saved? })

from would describe a route matching the current location and would narrow the fromMatch passed to blockerFn for the matching route. This will be optional fromMatch will be loose if not provided
to would describe a route matching the destination location and would narrow the toMatch passed to blockerFn for the matching route. This will be optional toMatch will be loose if not provided
blockerFn determines if the navigation should continue or block.
fromMatch/toMatch is a match like from useMatch which will provide the usual params, search, context, etc

When from or to is provided the blockerFn is only called when navigating to the location described by these two properties. If they are not provided it will always call blockerFn for any navigation

we should make this as typesafe as possible, as per @chorobin's comment.
@tomrehnstrom can you tackle this? if you need support let us know

@tomrehnstrom, are you planning to continue working on this PR?
Does anyone know a quick and dirty workaround I can apply in the meanwhile?

@tomrehnstrom, are you planning to continue working on this PR?
Does anyone know a quick and dirty workaround I can apply in the meanwhile?

Yes, but have been quite busy elsewhere recently. The way i have solved this quickly in our codebase is just to copy the history package index.ts file and make the changes required to make it work, and then use it as a custom history:
const history = createQudakBrowserHistory()

export const router = createRouter({
  routeTree,
  defaultPendingComponent: FullWidthLoader,
  defaultErrorComponent: RouterSuspenseErrorFallback,
  defaultNotFoundComponent: Error404,
  context: {
    auth: undefined!,
    queryClient
  },
  defaultPreload: 'intent',
  // Since we're using React Query, we don't want loader calls to ever be stale
  // This will ensure that the loader is always called when the route is preloaded or visited
  defaultPreloadStaleTime: 0,
  history
})

With the changes in my first commit in this pr
Then written a custom blocker hook like this:
type BlockerOpts = {
  blockerFn: CustomBlockerFn
  disabled?: boolean
}

export function useCustomBlocker({ blockerFn, disabled = false }: BlockerOpts) {
  const { history } = useRouter()

  React.useEffect(() => {
    return disabled ? undefined : history.block(blockerFn as BlockerFn)
  }, [blockerFn, disabled, history])
}

Thanks @tomrehnstrom, I needed this urgently and managed to make do with the suggested temporary solution for now.

Whoops, i broke the PR

Hello @schiller-manuel, I have finally got this PR into a pretty nice shape. However, I am not sure about the way I implemented route from/to matching in the useBlocker hook, any suggestions there would be appreciated.

For anyone stumbling across the PR and really wants this now, use my fork: https://github.com/tomrehnstrom/router/tree/better-blocker-router
Until this can get merged :)

I need to have a closer look, what's the current status of this PR? anything obvious missing ?

The type safety and type narrowing described by @chorobin is not really implemented, but functionally of it should be complete, have been using this method in prod for quite a while and haven't had any issues so far. Maybe the old interface for useBlocker should still be supported and marked as deprecated though.

is your PR breaking the blocker API or is it backwards compatible?

let's work on merging this.
[] docs need updating

@tomrehnstrom thanks for the update
still not sure if the API is backwards compatible.
can you comment on that please? if it is not backwards compatible can you please fix this so we can release this in a non breaking manner

@tomrehnstrom thanks for the update still not sure if the API is backwards compatible. can you comment on that please? if it is not backwards compatible can you please fix this so we can release this in a non breaking manner

It should be backwards compatible now 👍

@Tanner-Scadden  I truly appreciate your help here. Thank you so much!

Could this be modified to supply the navigation type to the notify function? I will try to make an addon for the history API after this PR merges which will keep track of the history state. The addon will help us hide back buttons when there is only 1 entry in the navigation state and, maybe, for implementing breadcrumbs. Also, can you explain why back, forward and go are of type "POP"? It would help me if they had their own navigation type. My rough ideea for the addon right now is that PUSH, POP, REPLACE would do their respective action (.push, .pop or .replace) on an array and increment/decrement a cursor variable, while BACK, FORWARD and GO would only increment/decrement the cursor variable.

@ferretwithaberet Sorry for the long wait, would the changes in my latest commit accomplished this?

@ferretwithaberet Sorry for the long wait, would the changes in my latest commit accomplished this?

@tomrehnstrom I do not mind the wait, take your time, do not stress yourself. As to the implementation, I would need to get the index for the GO action, which actually is , as MDN calls it, a delta. I need it so I can know how much I would have to increase/decrease the cursor of the history state. Otherwise it looks good to me, great job.

I tried to test the code manually. When using the browser back/forward buttons, it seems that the popstate event gets triggered for both buttons, which in turn triggers a POP event regardless of navigation type.
Also, I could not find nothing on the pushstate window event, does it even exist or am I missing something?
I will not be able to look much on this until monday night EEST, I will try to look for a solution then.

@sagi-webiks

After this PR, I will be able to block based on the condition: currentUrl != nextUrl ? Thanks

yes!

I am working on making the API typesafe, stay tuned

Cool! I think using setup will be much more useful than having fromand to in the hook args

Anything here I can help with here @schiller-manuel?

@tomrehnstrom
we need

type tests for useBlocker
more unit tests in a full router setup to check that action, current and next are correctly passed into shouldBlockFn
e2e tests for the legacy API and the new API

I have also added a TODO whether we should return current and next in case the resolver is used. I thought about this when editing the example since we only know the status then but don't know current/next which might be necessary for UI?

Yes, I will jump on updating docs and supplying the current blocking state to the resolver.

@tomrehnstrom can you ping me on discord please?
https://tlinz.com/discord


[Bug]: Browse CO Det string appears twice

Steps to reproduce the bug
Scenario: @tmcelrath and I curating INHS ENT records on Production with biocuration issues (e.g. female,male in dwc:sex on export).

1.Browse to a given CO
2.See the "determined" row
3.In the "Object" column, for that Determination, the person who did the "det" shows up twice. (See screenshot)
4.See example https://sfg.taxonworks.org/tasks/collection_objects/browse?utf8=%E2%9C%93&collection_object_id=&%5Bcollection_object_id%5D=1129907
5.I have seen this in other records.

Screenshot

Expected behavior
I'm not really sure what I should expect.
Is it there twice for a reason?
Could it be that it's both buffered and parsed showing up in the call to the UI?
If that's true, it could be kind of nifty as a data quality check making it easy to compare the literal string with the parsed value.
If it's not there for a reason, I think I'd expect the "linked" part to remain (e.g. https://sfg.taxonworks.org/otus/215676) and the string to go away.
Additional Screenshots
No response
Environment
Production
Sandbox Used
No response
Version
v0.24.2
Browser Used
firefox

This is display issue, the data seems to be correct.


Add Unitree A1 quadruped

This PR adds the Unitree A1 quadruped. It's based on the latest upstream URDF (MPL-2.0 licensed) with the Gazebo and transmission tags removed.

Thanks @wxmerkt and @nim65s!


UnixPb: CentOS8 Updates

Use dnf config-manager to enable powertools repo.
Fix libdwarf package name.

Checklist

[ ] commit message has one of the standard prefixes
[ ] faq.md updated if appropriate
[ ] other documentation is changed or added (if applicable)
[ ] playbook changes run through VPC or QPC (if you have access)
[ ] VPC/QPC not applicable for this PR
[ ] for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

Assume solaris failure is separate

Bumping this so we can close it off on our end.

Comment updated.
The powertools repo is a prereq for the libdwarf install on aarch64.

/thaw

CentOS6 test failed but it may not be related to this PR so I'm re-running to see if it's repeatable.

Bumping this to try and get it closed out. Thanks.


Ensure "good defaults" are consistent, e.g. in datatoken creation

Background / Motivation
Q (Calina): related to defaults: there’s a big difference between our tests between Datatoken creation when creating assets and when “just” deploying Datatokens. Namely for the publish_market_order_fee_token (should it be ZERO_ADDRESS or OCEAN address?). same for publish_market_order_fee_address (should it be the publisher wallet address, or ZERO_ADDRESS?)
A (Trent): Great Q. It's useful to be consistent. Perhaps create an issue for it, and document the things that need consistency fixed. I can iterate with you on good defaults.
TODOs

[ ] Document which defaults need consistency fixed. E.g. as a GDoc or GSheet
[ ] For each item, Trent & Calina agree on how to fix. Document in the GDoc / GSheet
[ ]  Implement it

@trentmc The only notable differences between what we employ in asset creation vs. single datatoken creation are the two I mentioned:

publish_market_fee_token is OCEAN_address for asset creation and ZERO_ADDRESS for datatoken creation
publish_market_order_fee_token is the publisher wallet address in asset creation and ZERO_ADDESS for datatoken creation

There is another difference in most tests, where we add the consumer_wallet as the fee manager, even if we use another publisher, but I think that is fine, since there's no way of knowing the consumer beforehand, so we should always pass it in as a parameter when needed (see implementation for more context).
Where it should be implemented:

see if the fee_manager = consumer_wallet is really required in all the tests where it is used. My suspicion is it was just copied around and it's not necessary in ALL places where it is set. We should simplify where possible, while keeping it where needed.
add the proper good defaults in arguments.py
in tests, where we define the specific order fees and tokens which have become "good defaults", remove the explicit parameter setting
iterate on datatoken creation in tests and turn it into a fixture. Possibilities: two types of DT in fixtures, or keep just one if we align the "good defaults".

For defaults:

publish_market_fee_token - I recommend ZERO_ADDRESS. Why: most use cases, especially when from ocean.py, and when people are getting going, aren't going to have a publish market fee. Secondly: I want to move away from OCEAN for fees and payment everywhere; it's lower friction for users to use DAI, USDC, WETH. (FYI having it for fees & payment doesn't help OCEAN token health. Ref Burniske MV=PQ.)
publish_market_order_fee_token - ZERO_ADDRESS here too. Why: same as above

In tests, most of the time, fees should be zero, unless we're explicitly testing for fees. Then, we test well.
Re "consumer_wallet", one more note: labeling it "consumer_wallet" for a fee manager is confusing. Every time I see this, it annoys me.

To fix: have another account as pytest fixture called "fee_mgr_wallet", and use that instead of "consumer_wallet"

iterate on datatoken creation in tests and turn it into a fixture. Possibilities: two types of DT in fixtures, or keep just one if we align the "good defaults".

FYI, I re-introduced DT() as a fixture a couple days ago, along with data_nft() and data_NFT_and_DT(). Into conftest_ganache.py, here. You can leverage those. BTW if you want to rename data_nft to data_NFT go for it:)

As #1220 has worked out, I realised our tests were using a lot of boilerplate/copy-paste even when not needed. I.e. even when not testing consumer/market balances, we were specifying addresses for fees and such. After #1220 is merged, I think this issue becomes moot, because:

I removed any unnecessary setting of fees where we are specifically not testing fees, but other things
I added defaults in FeeTokenArguments classes and DatatokenArguments, as needed
The only places where defaults were unaligned were publish_market_order_fee_token and publish_market_order_fee_address, which are now inside FeeArguments

Sounds good to me!
I was hoping that via the work to simplify, other stuff becomes easy / trivial. This is a great example:)
Closing.


Feature request: resolvable page title for each state

It would be great to define complex titles that would be reflected in browser history. They could depend on resolvables so that one can put data in the title, even when a param is dynamic.
Feasible?

This should be easily done with a transition hook and the data property.
{
  name: 'parent',  url: '/parent',  component: 'parent',
  data: { title: 'Some Parent Title' }
},
{
  name: 'parent.inheritTitle',  url: '/reuse',  component: 'inheritTitle'
},
{
  name: 'parent.childTitle', url: '/child', component: 'child',
  data: { title: 'Child title overrides parent' }
}
...

$transitions.onSuccess({ to: state => state.data.title != null }, transition => {
  document.title = transition.to().data.title;
});

This solution does not work.

The title you set this way goes on the previous element in the browser history.
With a static title put in 'data', I can't build a dynamic string based on resolvables
Note that your onSuccess should be for all transitions, otherwise the current title would remain for states that don't define a title.

The title you set this way goes on the previous element in the browser history.

Oh weird.  I'll reopen then.
2 and 3 are left as exercise for the developer.  it's a transition hook, so it has access to everything a regular transition hook has including match criteria and resolve data.

I think that things are happening after the onSucess callback returns, that are necessary to make it work. I can solve this if I set the title inside a $timeout. Can we get rid of this workaround in some manner?


Update csharp examples to net6

Update to .NET 6, switch output type to the library, set language to C# 10 and update NuGet packages.

Thankyou!


Fe/txn progress visuals

Hid sourceChain from pending txs
Re-positioned progress-bar
Use tailwind green for 'completed' color
Hide progress bar as part of completed transition

Slightly glitchy in Safari, looks great in Chrome and Firefox

Updated hit areas and states for payload and dropdown menu
Change 'Pending {time}' to '{time} left'
Improved visuals of dropdown menu
Moved timestamp into dropdown menu
Clicking anywhere on page closes dropdown menu

BUG: Clicking one dropdown menu while another is open prevents the first dropdown from closing

Simplified Activity components
1a151b1a1b2fd9d71651f3ed0bced78e40475dfd: synapse-interface preview link
31261661a09433b42e3300a117d72c4af2a040a5: synapse-interface preview link
9dfda87a5997b98a46be0ca3e15d3dc7aeee2e97: synapse-interface preview link
f0754b03b0e32dee08f9cc62872d3a93d1ea5cfd: synapse-interface preview link

Summary by CodeRabbit

New Features

Introduced an AnimatedProgressBar to visually represent transaction progress.
Added a TestProgressBar for user interaction with a simulated progress bar.
Enhanced dropdown menus within transactions with new items and better UI interaction.
Implemented conditional rendering for transaction details based on type and completion status.
Display of historical transactions now includes 'Pending' status for testing purposes.

Refactor

Reorganized and optimized the structure and styling of transaction components for better alignment and appearance.
Streamlined styling by refactoring button styles and class names across components.
Updated transaction status handling with improved logic for delayed transactions.

Style

Adjusted layout, styling, and added a new color variable greenProgress for progress bars.
Modified SVG attributes in DownArrow component for better size and styling.

Documentation

No visible changes to end-users.

Fix bug where multiple dropdown are able to open in https://github.com/synapsecns/sanguine/pull/2002/commits/4deac352c63e8051babf09ae1673104c7c397d2a


refactor: removed login API call from passkey signup

What

removed login API call from passkey signup

Closing as a new PR will be created


Can't connect with and response  web-socket ticker

there are no response error when web-socket ticker run

it work after
NODE_TLS_REJECT_UNAUTHORIZED = 0

Hi @jeeteshnariya you should upgrade Node.js version. Current running version of Node.js is 12. This issue is because of an old root CA certificate expired on May 30th that affects old systems that are not updated with new root CAs. More about it: https://support.sectigo.com/Com_KnowledgeDetailPage?Id=kA03l00000117LT


Wrong method call

Method onUptimeCheckFailed marks site as up instead as down in class OhDearWebhooksEventSubscriber.php

Nice catch, fixed!


False sharing in multithreaded parallel_reduce

I just stumbled across your multithreaded parallel_reduce implementations here. Because you're writing to shared cache-lines from different threads (tmp[threadid()]) in a hot loop (1:N where N may be large) these implementations will very likely suffer (a lot) from false sharing.
I recommend to perform a thread-local reduction first, i.e. something like the following (untested):
using ChunkSplitters

function parallel_reduce(N::I, f::F, x...) where {I<:Integer,F<:Function}
    nt = Threads.nthreads()
    tmp = zeros(nt)
    Threads.@threads :static for (idcs, t) in chunks(1:N, nt)
        tmp[t] = sum(i->f(i, x...), idcs)
    end
    return [sum(tmp)]
end

(One could avoid the ChunkSplitters dependency by using e.g. Iterators.partition.)

Thanks @carstenbauer for pointing this out. You're the expert so please chime in anytime. We'll restart some of the work as we come back from the holidays.


Win32: Space bar with modifier key not working in gvim

I am using an alternative keyboard layout called "neo2". [http://www.neo-layout.org/] This layout focuses on minimal finger movements and instead works with several layers activated by pressing and holding a modifier key (e.g. caps-lock). In this layout modifier 4 + space bar is equivalent to "0" on the numerical key pad.
Not so in gvim: here the modifier key is ignored and all I get is a space character. That is quite annoying, because it doesn't work in normal mode, too. So I always get strange results for things like "10k". All other keys in neo2 layer 4 work perfectly normal (i.e. mod4+m for "1"), only the space bar is not recognized correctly.
As for gvim is the ONLY application I encountered having any problem with the layout, so I think it is causing the problem by some kind of input processing.
"gvim -N -u NONE" does not make any difference, so this is not plugin related. Commandline vim works fine, but I'd prefer using gvim due to better color support :-)
I am running Windows 8.1 64bit and can reproduce this using the official 7.4 build as well using the single drop distribution v7.4.657. I even tried older versions (e.g. v7.1.42 portable)

This issue seems to conflict with https://github.com/vim/vim/issues/250
If I REMOVE the line {VK_SPACE,		' ', NUL}, from gui_w32.c, then the issue with the neo2 layout is gone.
I don't have any smart idea though, how I could provide a fix suitable for all users. So I'll just compile gvim from the sources from now on :-)


mantle-bridge-backend restart frequently

https://github.com/mantlenetworkio/mantle-bridge-backend/commit/e4bab993d0106f2d78b14726b800f7f5a84a03b9

fixed.


GH-41797: [C++][S3] Remove GetBucketRegion hack for never AWS SDK versions

Rationale for this change
To get the region a S3 bucket resides on, it is required to issue a HeadBucket region and parse the response headers for a certain header value.
Unfortunately, the AWS SDK doesn't let us access arbitrary headers on successful responses for S3 model requests, which had us implement a workaround by calling lower-level SDK APIs.
However, the SDK recently added a GetBucketRegion method on HeadBucketRequest, which obsoletes the need for this workaround. We now use this method if the available AWS SDK version is recent enough.
Are these changes tested?
By existing tests on the various CI configurations.
Are there any user-facing changes?
No.

GitHub Issue: #41797

@github-actions crossbow submit -g cpp

@github-actions crossbow submit -g python -g wheel

@github-actions crossbow submit -g python -g wheel

@github-actions crossbow submit -g cpp

I'll merge this as the CI failures are unrelated.


Revert accidental changes on tests.e2e.sh

Revert accidental changes on tests.e2e.sh

I think we can close this one??


Sched action config

https://github.com/marketplace/actions/markdown-link-check
https://github.com/tcort/markdown-link-check

The title of this Pull Request needs to be changed to match the format:
<type>(<scope>): <subject>

See more details here: https://www.spinnaker.io/community/contributing/submitting/#commit-message-conventions
Some common examples are:
feat(armory.io): add docs.armory.io
fix(parser): grammar and spelling
style(loadingPage): made it super pretty!
refactor(helpMessages): changed order to make more sense


First Android app: Android Basics with Compose

URL of codelab
In which task and step of the codelab can this issue be found?
Step 3  task 9
Describe the problem
I am supposed to split the screen - Click Split on the top right of Android Studio, this allows you to view both code and design. You can also click Code to view code only or click Design to view design only. but there is not Android Studio nor split option to click on
Steps to reproduce?

Go to...
Click on...
See error...

Versions
Android Studio version: Electric Eel
API version of the emulator: ??
Additional information
Include screenshots if they would be useful in clarifying the problem.

I am stepping into this absolutely green. I know nothing about Kotlin  etc. or how to get around the program.


[BUG] Error while parsing Subdefinition

I am trying to use the workday API and when trying to autogenerate code for the Human Resources service I get the below error.
Error occured while generating client "Human_Resources.wsdl"
        Error: Error while parsing Subdefinition for wd:Get_Political_Affiliations_ResponseType.wd:Get_Political_Affiliations_ResponseType
1 Errors occured!

WSDL File: https://community.workday.com/sites/default/files/file-hosting/productionapi/Human_Resources/v36.1/Human_Resources.wsdl

Hi,
I tried to parse that wsdl file and it works, when I increased limit of max maxRecursiveDefinitionName to 85. It happens when there are a lot of definitions with same name. Then new option maxRecursiveDefinitionName will be available in next release (currently available in master branch).

thanks is there an ETA on when this fix will be released in a tagged version?

@starsoccer new version 1.2.0 is released https://github.com/dderevjanik/wsdl-tsclient/releases/tag/1.2.0
Update your package and pass --maxRecursiveDefinitionName=90 argument to CLI, like wsdl-tsclient ./Human_Resources.wsdl --maxRecursiveDefinitionName=90 -o ./generated

thanks that seems to have worked. I had to bump it to 180 though as some other files were having issues.
On an unrelated note it would be nice if there was a way to merge multiple wsdl files. In the case of workday there are 10+ different wsdl files and ideally I could just make one client with a shared authentication and endpoint rather then have to do so for each resource. But I can make another issue for that if you think its an idea worth exploring.

I see your point, but IMO it isn't good idea to merge multiple files.... instead of merging several wsdl files into one, you can generate several wsdl clients at once (wsdl-tsclient ./path/to/*.wsdl -o ./generated) and then in your code create one access point to your APIs (Google is doing same thing with google-api, where you initialize one class with several APIs at once and shared auth).
// api/commnuityworkday.ts
import soap from "soap";
import { createClientAsync as createHumanResourceClient, HumanResourceClient } from "../generated/humanresources";
import { createClientAsync as createCompanyServiceClient, CompanyServiceClient } from "../generated/companyservice";
import { createClientAsync as createFileShareClient, FileshareClient } from "../generated/fileshare";

interface CommunityWorkdayAuth {
    username: string;
    password: string;
}

class CommunityWorkdayAPI {

  private _humanResourceClient: HumanResourceClient;
  private _companyServiceClient: CompanyServiceClient;
  private _fileshareClient: FileshareClient;

  async init(auth: CommunityWorkdayAuth) {
      const basicAuth = new soap.BasicAuthSecurity(auth.username, auth.password);

      this._humanResourceClient = createHumanResourceClient("./resources/Human_Resources.wsdl");
      this._humanResourceClient.setSecurity(basicAuth);

      this._companyServiceClient = createCompanyServiceClient("./resources/CompanyService.wsdl");
      this._companyServiceClient.setSecurity(basicAuth);

      this._fileshareClient = createFileShareClient("./resources/FileShare.wsdl");
      this._fileshareClient.setSecurity(basicAuth);
  }

  humanResource() {
      return this._humanResourceClient;
  }

  company() {
      return this._companyServiceClient;
  }

  fileShare() {
      return this._fileshareClient;
  }

}

Then you can use it as module in your project (I'm used to create library from code above to avoid generating client everytime).
// main.ts
const communityWorkday = new CommunityWorkdayAPI();
await communityWorkday.init({ username: "admin", password: "adminpwd" });

await communityWorkday.fileShare().sendFileAsync({ path: "path/to/file" });

I hope this may help you

yeah that is similar to what I was planning I was just hoping to have it automatically generated is all.
Also rather then exposing each individual service I was hoping it would auto generate pass through functions so I could just have one top level client and call all functions and have them simply passed through to the needed service/resource path.

There also seems to be an issue with some of the auto generated function and parameter names that include a dash which isnt allowed and causes typings to break. I think a simple fix for this is to just replace all - with a underscore instead

Sure, I forget about those... We already have changeCase function, which replaces all ., so we can extend that...

It may be worth using a package that checks to ensure the string used is a valid java script variable name: https://www.npmjs.com/search?q=valid variable name

Yeah, it would be great to find good library for making sure the variable name is valid javascript varname.
Please, is your issue with - similar to https://github.com/dderevjanik/wsdl-tsclient/issues/18 ?
I just published dev version npm i wsdl-tsclient@dev, so you could try if the issue with wrong property names persists.

Yes I think its similar. Sadly the dev version doesnt fully resolve the issue. I still have cases like Put_User-Based_Security_Group_AssignmentAsync that is invalid

Oh, now I see similar problem. I only fixed definitions, not Ports nor Services. I'm going to fix it.
Besides that, I created PR to make sure all generated wsdl-tsclient are compile-time valid #19

Awesome well if you need me to try anything else just let me know. Otherwise I think atleast for now this can be closed


Add sobohop by relieieeiieie

Song Name
sobohop
Artist Name
relieieeiieie
Source
Youtube
Youtube Link
xy9VQoHlF6E
Direct File Link
No response
Song ID
436814
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 19759411
Downloaded: Yes

accept

its a joke nong btw


Proposal: Adding a nanosecond resolution now()

I think it would be useful to add a higher-resolution version of Dates.now(). Possible implementation could be something like
function now_μs()
    tv = Libc.TimeVal()
    tm = Libc.TmStruct(tv.sec)
    return TimeDate(tm.year + 1900, tm.month + 1, Int64(tm.mday), Int64(tm.hour), Int64(tm.min), Int64(tm.sec)) + Microsecond(tv.usec)
end

which gives the current date/time to the microsecond level.
This expression gives it up to nanosecond resolution but in GMT time zone.
now_ns() = TimeDate(1970) + Nanosecond(time()*1e9)

I am not sure how to get in the system timezone.
If this is fine, I can make a PR with this bit inside.

please do


T4.2 Pull receipt, scan transaction & filter them

Parent task: #11

Done in https://github.com/EspressoSystems/op-leader-election/pull/23


Implement a Join operator

To make our tree plan really a tree instead of a single node, we need connecting operators, mainly "Join."  I thought about it, and it doesn't seem to be very hard.  Here's a possible design:
join(IOperator leftChild, IOperator rightChild, List of JoinPredicates)

A single join predicate is a comparison on the gap offsets or token offsets of two children.  The comparison can be "<", "<=", "=", ">=", ">=", and "<>".
For now, we can do a nested-loop join.  Better algorithms are possible (e.g., hash based or sort based).

Added @sripadks to this issue.

Merged PRs:
179


Make setting dialog scrollable (to dev)

(This PR is a duplicate of the PR #134 )
This PR makes the setting dialog scrollable.
It is helpful if the settings dialog is scrollable when there are many contents.

I don't like that the border of the panel is now visible:

I will fix that.

Done!


Add support for Godot 4.0, 4.0.1, 4.0.2

With the stable releases of Godot 4.x we can now use those version as well.

Also updated README to use the latest version

Finally got the build to work this time. My npm was a few versions behind. It works now though!

Hey! Thanks for your contribution, I'm happy to merge 🙂
As a side note, though, this repository isn't actively maintained for 4.x. If you prefer a more active package, I suggest taking a look at chickensoft-games/setup-godot.

Great! Thanks for the heads up!


Update config.schema.json

Add Name config so that name is used in the logs instead of the full plugin name.
removed default for type on deviceoverridee as it was inputting "Boolean" every time you save config

thanks @donavanbecker , there's some issue with tab & space, others are okay :)

I didn't know I can update your branch... is okay now.... thanks again!

I will be posting some more changes soon :)

See #285 and #283


Add password gated drops

Why
Hackathon! https://showtime-rq88331.slack.com/archives/C02QQ5HDRHN/p1667489797639929
How
Added support for password at creation and collection
Test Plan
Create a drop and choose a password, then try to collect the drop with another account using the same password

😱😱😱


Validate custom survey on creation.

[x] Validate so that name (at least one language) is nonempty
[x] Validate dates
[x] Ultimate: validate students

Also, it crashes when fields are empty.

[x] Make rendering robust so when data is fakd, it doesn't crash.

Ez


Update interpolated-strings.md

Clarify that the new syntax for string interpolation is available starting from F# 8
Fixes #36662

Internal previews

📄 File
🔗 Preview link

docs/fsharp/language-reference/interpolated-strings.md
Interpolated strings

closing and reopening for a fresh build.


Deployment of Azure Cosmos DB failes

Hi,
We tried multiple times to create an Azure cosmos DB instance in our subscription but it fails every time with the error:
{"code":"DeploymentFailed","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details.","details":[{"code":"ServiceUnavailable","message":"Database account creation failed. Operation Id: c3ba349d-dfa5-41a1-86cf-333833428c55, Error : Sorry, we are currently experiencing high demand in this region, and cannot fulfill your request at this time. The access to the region is currently restricted, to request region access for your subscription, please follow this link https://aka.ms/cosmosdbquota for more details on how to create a region access request.\r\nActivityId: a468f1b1-edab-4c46-ab62-71ecfa80d2a9, Microsoft.Azure.Documents.Common/2.14.0, Microsoft.Azure.Documents.Common/2.14.0, Microsoft.Azure.Documents.Common/2.14.0, Microsoft.Azure.Documents.Common/2.14.0, Microsoft.Azure.Documents.Common/2.14.0, Microsoft.Azure.Documents.Common/2.14.0, Microsoft.Azure.Documents.Common/2.14.0, Microsoft.Azure.Documents.Common/2.14.0, Microsoft.Azure.Documents.Common/2.14.0, Microsoft.Azure.Documents.Common/2.14.0"}]}
Please help me with this.
Regards,
Andrei

Were you able to create the DB at the same region using the Azure Portal? Some regions are out of bound and to access them you need to contact Azure support.

I tried to create it in the same region as the ones we already have West Europe


divide abnormal spatial working memory (MP:0008428)

divide abnormal spatial working memory (MP:0008428)
this has over 160 annotations review to create child terms

Created
impaired - MP:0014370
enhanced - MP:0014369


How can I suppress "parseTree XXXms" output?

I have always used the VS Code extension. I like it very much. But the frequent appearance of notifications like parseTree XXXms is a bit depressing. Is there any way to turn it off?

Oops, thanks for telling us!
Removed these notifications, please update paperproof with lake update Paperproof.

Thank you!!


added unsatisfied ipywidgets dependency

After loading the notebook I still had to install ipywidgets. This pull request adds that dependency to the README file.

I added a proper requirements.txt file to achieve a better compatibility, so will close this request, but thank you for the contribution! I do appreciate it!


vagrantfile fails on macOS Sierra

In particular, Ansible seems to be what's failing. Here's the error I get:
TASK [common : docker service] *************************************************
task path: /Users/shartzell/projects/scale-master/ansible/roles/common/tasks/main.yml:69
fatal: [scale-master]: FAILED! => {"changed": false, "failed": true, "msg": "Unable to start service docker: Job for docker.service failed because the control process exited with error code. See \"systemctl status docker.service\" and \"journalctl -xe\" for details.\n"}
	to retry, use: --limit @/Users/shartzell/projects/scale-master/ansible/vagrant.retry

PLAY RECAP *********************************************************************
scale-master               : ok=14   changed=2    unreachable=0    failed=1

Ansible failed to complete successfully. Any error output should be
visible above. Please fix these errors and try again.

I don't know much about Ansible, so I'm not sure what it's trying to do. If it's trying to run the "systemctl ..." command then that would explain the error as MacOS doesn't have systemctl. Does this only work on Linux? I tried to run this on Ubuntu, but ran into separate issues.

Yeah, we are aware of issues with the ansible scripts. We are planning on phasing them out due to the difficulty and complexity of getting them to work consistently.
The recommended path for trying out Scale is to use our QuickStart guide which involves installing Mesosphere DC/OS: Quickstart


AMBARI-23574. Log Feeder: fix startup issues (root logger + include lazy config)

What changes were proposed in this pull request?
circular dependencies can be found with some Configuration object (we upgraded spring version, that did not happened before), we can use lazy loading for the configs, so those wont be created by something else if those are not referenced yet.
also fix logfeeder logging as root logger was missing. (plus remove unneded files)
How was this patch tested?
UT: not required
FT: manually
please review @swagle @kasakrisz @g-boros

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1839/
Test PASSed.


Depth parameter is not working properly

Issue 1:
I found a few more issues with depth parameter values:

When you set depth > 4 and recursive: true, no events will be emitted
When you set depth <= 4 and recursive: true, events emitted properly, though it doesn't make much sense logically, since this setup emits events up to Infinity, even though you specify level 4 as the limit. Perhaps it should throw an error if recursive and depth are both used at the same time?
When you set recursive: true without specifying depth, no events will be emitted
When you set recursive: true and depth: Infinity, no events will be emitted

I'm not sure what's the intended behavior.
For the following setup:
{
  depth: 10,
  recursive: true
}

I'd expected the following behavior:
limits the amount of nested levels being watched to level 10 on Linux (for performance), while watching up to Infinity on Win and MacOS using the native watchers. Though, I don't really understand the purpose of the recursive option - if its only purpose is to switch to the native watcher, why not call it useNativeWatcher instead?
Issue 2:
Also there's a separate depth problem - when you init the watcher for a drive root path (e.g. "E:/") no events are emitted as well.

When you set depth > 4 and recursive: true, no events will be emitted

Does it work when depth is set to 3 for example?

Perhaps it should throw an error if recursive and depth are both used at the same time?

Maybe it should 🤔

When you set recursive: true without specifying depth, no events will be emitted

It might be the same issue as 1.

When you set recursive: true and depth: Infinity, no events will be emitted

Still the same issue maybe.

limits the amount of nested levels being watched to level 10 on Linux (for performance), while watching up to Infinity on Win and MacOS using the native watchers.

Maybe it should throw instead because you didn't pass it the "native: false" option so the library can't implement watching consistently across systems, I'm not sure how much sense it makes to have it behave differently on different systems, the whole point is to abstract all the differences away and just work.

Though, I don't really understand the purpose of the recursive option

You don't always want to watch recursively. For example you might be interested in listening for when "the parent folder of this directory gets deleted", but you don't want to watch everything below that too, just the folder.

if its only purpose is to switch to the native watcher, why not call it useNativeWatcher instead?

It doesn't switch on or off to the native recursive watcher, there's the "native" option for that.

@fabiospampinato

At what depth are you watching and under what OS? Are you ignoring initial events? Are you getting the "ready" event?

OS: Windows 10; depth: < 4. Tried with ignoreInitial set to true and false, the same result.
And, as I mentioned, you always have to specify depth: < 4 for some reason, otherwise the watcher is not working at all, not even for non-root directories (the ready event will never be emitted either).
const Watcher = require('watcher')

let dirWatcher = new Watcher('E:/', {
  ignoreInitial: true,
  depth: 2,
  recursive: true
})
console.log('Watcher: init', dirWatcher)

dirWatcher.on('all', (event, targetPath, targetPathNext) => {
  console.log('Watcher: all', event, targetPath, targetPathNext)
})
dirWatcher.on('ready', (event, targetPath, targetPathNext) => {
  console.log('Watcher: ready', event, targetPath, targetPathNext)

})
dirWatcher.on('error', (error) => {
  console.log('Watcher: error', error)
})

Log:
// Watcher: init {Object}
// Watcher: ready undefined undefined undefined

When I modify any item inside E:/ nothing happens.

I'm aware of a similar bug existing in the library at the moment, but in your situation if it works by setting depth: 4 and it breaks by setting depth: 5 then most probably you are just instructing the watcher to watch on too many things. You should profile the app to be sure, but my guess is that the initial directory scan which completes in ~reasonable time at depth 4 or below just takes too long at depth 5, the number of directories to scan can grow exponentially.
I'm not sure this is something the library itself can address, unless there's some major performance issue somewhere causing this problem. You should probably adopt a different watching strategy, and potentially turn off the native recursive watcher (native: false).

@fabiospampinato I'm not sure it's due to the level 5 having too many paths to scan. I've waited for ~15 minutes after the ready event, and I still can't see any events firing when I modify nested files. CPU usage stays at 0. It doesn't look like it's scanning anything. On level 4, however, I can see the change events (add / unlink, etc) firing when I modify nested files immediately after ready event.
Can you run the code from the message above, do you see the same behavior? That is, on depth: 5+ you won't see any events firing when you modify a nested file

@fabiospampinato yeah, I've created E:/test directory with only 150 nested paths, and the watcher works fine even on depth 5+.
Where is this limitation of max amount of paths coming from? Node?
The strange thing is. when I init the watcher for a dir that has 100,000 paths (8 GB), the CPU usage stayed at 0 the whole time. It didn't look like it was scanning anything.

Where is this limitation of max amount of paths coming from? Node?

If you don't set native: false then you are using Node's wrapper over Windows' native recursive filesystem watcher, I've no idea what the actual limitations of that are.

The strange thing is. when I init the watcher for a dir that has 100,000 paths (8 GB), the CPU usage stayed at 0 the whole time. It didn't look like it was scanning anything.

Maybe it was largely just waiting for the filesystem to respond? Scanning isn't particularly expensive on Node's side, it's mostly just waiting for the responses I think. A profile of the app would be necessary to better understand where the time is being spent.

Yeah, I also think the native watcher just waits for the event from OS. So in theory it should emit events no matter how deep the watched directory is. Looks like it just doesn't work on deeply nested dirs at all (including the drive root dirs like E:/).
Just tested with native: false it also gives up on deeply nested dirs. The node.js process closes completely when I try to watch deeply nested dirs

Just tested with native: false it also gives up on deeply nested dirs. The node.js process closes completely when I try to watch deeply nested dirs

Is it just crashing for you? Do you know the exit code?

Yeah, it just crashes the process, error listener is not emitting any errors
I'm executing a js file from terminal: node test.js

是的，它只是崩溃的过程，错误侦听器没有发出任何错误
，我从终端执行js文件：node test.js

+1

@aleksey-hoffman if you can make a repro I'll look into this, I'm not sure how to reproduce it.


commands: use ReaderWithStats in flashback_to_version command

Signed-off-by: JmPotato<EMAIL_ADDRESS>What is changed and how it works?
Issue Number: ref #13303.
What's Changed:
Use `ReaderWithStats` in `flashback_to_version` command to collect the statistics info as much as possible.

Check List
Tests

Unit test

Release note
None.

/merge


Add smart chdir for files in projects

It would be nice if startify could chdir to the repository root directory if it can find one rather than chdiring to the directory the file is in.
I don't know how hard it would be, but I guess given you also work on signify it wouldn't be too hard.

For future users who arrive here from a google search, the option is actually called g:startify_change_to_vcs_root.


File client for reading from S3 Object Storage

Hi, sorry for asking a question similar to #4212, but just wanted to clarify more stuff regarding this:

Is petrel_client something internal to your lab?
If we want to read our data directly from a S3 bucket into memory, we can implement a file client that makes use of boto3 (for example), and various credentials/bucket name/path can be passed through file_client_args?
Under this implementation, is a new S3 client instantiated for every single image read?

Yes, it is supported for internal usage. This function is temporarily not open to the community, and it is supported by mmcv. If you want to discuss, you can open an issue in mmcv.

Alright, thanks!


docs(examples): Clean-up example config

Added missing "type": "module" to vite projects
Added "test:types" to examples which use TS

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (da5f40e) 41.78% compared to head (8bf7f53) 0.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #6817       +/-   ##
==========================================
- Coverage   41.78%   0.00%   -41.79%
==========================================
  Files         178      49      -129
  Lines        7017    2173     -4844
  Branches     1421     175     -1246
==========================================
- Hits         2932       0     -2932
+ Misses       3722    2055     -1667
+ Partials      363     118      -245

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Better voxel texturing

First off, we just want to apply a texture in a seamless way to the extracted mesh (this is a good read).
Next, we want to be able to UV map the texture appropriately so avoid stretching. GPU Gems 3 talks about that.

Polygons are always generated in sets of 4, and they fit together in quadrilaterals. The width and height are bounded above by 2*voxel_width. We can use this to naively flatten voxel textures into a 2D texture, by creating a texture that has max_width*max_height space for each voxel edge.

bca24129aec3a05352ea20b53847eb7a40c09839 and 3d41399dafbac475a8f631c6d4785cd3b9d280e2 add some better grass/dirt texturing.


[BUG] In dev mode the app is always trying to connect to localhost:8454 on startup

Describe the bug
When the app starts in dev mode on develop branch it always tries to poll localhost (hard hat) network.
To Reproduce
Steps to reproduce the behavior:

Start the app in dev mode yarn start
Go to Chrome Dev Console
See error messages. See attached screenshot.

Expected behavior
On startup, there is no need for the app to connect to any network that the user has not explicitly requested.
Workarounds (if any)
This does not stop the app from working, but it generates errors and slows down UX.
Screenshots
Attached.
Desktop (please complete the following information):

OS: OSX, iMac
Browser Chrome
Version: Jan 21, 2022

Additional context
This bug branched off of a performance analysis report here:
https://github.com/OlympusDAO/olympus-frontend/issues/1225#issuecomment-1018659178

I'm 99% certain this is functionality from ethers.js. When you don't pass in a RPC Node url then ethers assumes you are trying to connect to a local node (localhost:8454). If I'm correctly understanding your issue then if you simply populate your .env with a Node Url then the error goes away.
.env.example and the README describe the Node Urls you should have in your environment for the app to work.

I'm 99% certain this is functionality from ethers.js. When you don't pass in a RPC Node url then ethers assumes you are trying to connect to a local node (localhost:8454). If I'm correctly understanding your issue then if you simply populate your .env with a Node Url then the error goes away.
.env.example and the README describe the Node Urls you should have in your environment for the app to work.

Thank you. Will explore this route.

@appleseed-iii you were 100% correct. Submitted PR #1348 to initialize gitpod workspaces with a .env that prevents this issue.


Any plan for support androidx paging?

I wanna using androidx paging mixed with many components of this repo.
It need my custom adapter extends from PagedListAdapter.
Any plan for support it?
Thanks

Any update to add jetpack paging?thank you


Refinements to the DMA attacks

DMA attacker peripheral can now be configured in the length of the captured trace (allowing to capture more than 16 cycles at a time)
Add a test case demonstrating the use of the DMA-based leakage as a covert channel

LGTM, nice work!


Stongoros

Someone emailed asking about Stongoros. I see it is the name of a song that was previously discussed in https://github.com/tekinged/missing/issues/334. Does this word itself mean anything?

Murderer, from Japanese
Jim Geselbracht
510-919-2152

From: John Bent @.>
Sent: Sunday, August 18, 2024 4:33:03 PM
To: tekinged/missing @.>
Cc: Subscribed @.***>
Subject: [tekinged/missing] Stongoros (Issue #522)
Someone emailed asking about Stongoros. I see it is the name of a song that was previously discussed in #334https://github.com/tekinged/missing/issues/334. Does this word itself mean anything?
—
Reply to this email directly, view it on GitHubhttps://github.com/tekinged/missing/issues/522, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AX6MKZJQWUECLOREDLEXB6DZSEVK7AVCNFSM6AAAAABMWYVUBOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ3TEMJZGYZDMNI.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Yeah, OP confirms this in a subsequent email.


Documentation for Security providers

Environment Details

Helidon Version: 2
Helidon both SE and MP (security providers related)

Problem Description
Missing documentation:

Detailed expected interactions when a JWT token is received (OIDC provider and JWT provider) - what happens behind the scenes, interactions with identity provider
Detailed expected interactions when outbound service is called (what tokens would be attached and when)
How to configure per target outbound security

Reviewed doc in PR 2357.


Clicking on diamond logo in game leads to 404

Clicking on the diamond logo on the top left hand corner of the game leads to 404 page.

Able to reproduce, openWristDevice() leads to 404 as /academy/news does not exist.
Related line: https://github.com/source-academy/cadet-frontend/blob/master/src/components/academy/game/create-initializer.js#L51

@ReignOfComputer Thanks! Will you be willing to open a PR for this change?

Spoke to Prof @martin-henz, will redirect students to IVLE.

nice!


Better processing of JSON-encoded diagnostic messages.

Rebase of saviorisdead/RustyCode#223.
Some improvements to a processing of JSON messages (taken from Atom's plugin linter-rust):

Displaying message notes.

Following macro expansion to get correct filename and range.

Showing error code.

Hi @mitskevich,
Let me check this.

I haven't tried everything from the list. I will merge it in 2-3 hours.

Okay. I like it.


Aesthetics: remove extra \n's in vhd metadata

What this PR does / why we need it: remove extra \n's in vhd metadata
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
If applicable:

[ ] documentation
[ ] unit tests
[ ] tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

/lgtm


create-test-api-docs: Remove

This tool plays fast and loose with HTML generation, and nobody seems to use it.

Merged, thanks @andersk!


Adds 3 more verticals and simplifies 3 existing ones.

Adds Animals & Pet supplies vertical
Adds Baby & Toddler vertical
Adds Electronics vertical
Simplifies Food, Beverages, & Tobacco vertical
Simplifies Health & Beauty vertical
Simplifies Sporting Goods vertical

Pruned 5 mis-matches on capitalization leading to incorrect GIDs in our sources files:

Non-prescription Cat Food "gid://shopify/Taxonomy/Category/18"
Non-prescription Dog Food "gid://shopify/Taxonomy/Category/34"
Dog Treadmills "gid://shopify/Taxonomy/Category/40"
Pet Fragrances & Deodorizing Sprays "gid://shopify/Taxonomy/Category/83"
Baby Bottles "gid://shopify/Taxonomy/Category/920"

Did hotfixes to have it structurally correct, but exploring the values the tree doesn't have the behaviours for attribute that I expect so going to hold off on this until we are ready for a fresh export @tylerrowsell


Remove broken Slack link

Slack link doesn't work any more

Wish we could get it working again but IIRC only admins can create invites and there's only one admin.


[tinyfiledialogs] Fix tinyfiledialogs not being fetchable from sourceforge

Describe the pull request
Fix tinyfiledialogs not being fetchable from sourceforge. Use github instead.

What does your PR fix? Fixes issue #
No issue was created, but i encountered issues on my local machine.

Which triplets are supported/not supported? Have you updated the CI baseline?
No update outside of git url

Does your PR follow the maintainer guide?

The source seems move to https://sourceforge.net/p/tinyfiledialogs/code/ci/master/tree/

Hi @MaxKruse thanks for this PR.
Since there is no open issue to follow this problem.
Could you please open an issue about this?

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: MaxKruse sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Hi @MaxKruse thanks for this PR.
Since there is no open issue to follow this problem.
Could you please open an issue about this?
What's more, please also update the version and add homepage in CONTROL file.

#9665 is the issue number. Hope i didnt mess up anything.

/azp run


zziplib: 0.13.67 -> 0.13.68

Motivation for this change
Bump zziplib to 0.13.68 to fix multiple CVE issues:

CVE-2018-6381
(https://github.com/gdraheim/zziplib/commit/a803559fa9194be895422ba3684cf6309b6bb598)
CVE-2018-6484
(https://github.com/gdraheim/zziplib/issues/14#issuecomment-363198084)
CVE-2018-6540
(https://github.com/gdraheim/zziplib/commit/72ec933663f738d8e166979aa7fd5590b2104a07)
CVE-2018-6541
(https://github.com/gdraheim/zziplib/issues/16#issuecomment-363197718)
CVE-2018-6542
(https://github.com/gdraheim/zziplib/commit/931f962ddfec0e00d6f486df2c56d9857b55944e)

Unfortunately, getting only those patches is hard, as they're not well referenced to linked issues.
The testsuite is currently broken, and the newer python testsuite checking for vulns requires network access.
https://github.com/gdraheim/zziplib/issues/20 might still be an issue, so keeping this as a TODO here.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build zziplib

Success on x86_64-darwin (full log)
Partial log (click to expand)
make[3]: Nothing to be done for 'install-exec-am'.
make[3]: Nothing to be done for 'install-data-am'.
make[3]: Leaving directory '/private/tmp/nix-build-zziplib-0.13.68.drv-0/zziplib-0.13.68/i386-apple-darwin16.3.0'
make[2]: Leaving directory '/private/tmp/nix-build-zziplib-0.13.68.drv-0/zziplib-0.13.68/i386-apple-darwin16.3.0'
make[1]: Leaving directory '/private/tmp/nix-build-zziplib-0.13.68.drv-0/zziplib-0.13.68/i386-apple-darwin16.3.0'
post-installation fixup
gzipping man pages under /nix/store/d0nq0d966syw2rgw7mx9gvn8n2g0bys3-zziplib-0.13.68/share/man/
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/d0nq0d966syw2rgw7mx9gvn8n2g0bys3-zziplib-0.13.68/lib  /nix/store/d0nq0d966syw2rgw7mx9gvn8n2g0bys3-zziplib-0.13.68/bin
patching script interpreter paths in /nix/store/d0nq0d966syw2rgw7mx9gvn8n2g0bys3-zziplib-0.13.68

Success on aarch64-linux (full log)
Partial log (click to expand)
shrinking /nix/store/yswpmq97h924vmb76l4gr60xs3pszg34-zziplib-0.13.68/bin/zzcat
shrinking /nix/store/yswpmq97h924vmb76l4gr60xs3pszg34-zziplib-0.13.68/lib/libzzipwrap-0.so.13.0.68
shrinking /nix/store/yswpmq97h924vmb76l4gr60xs3pszg34-zziplib-0.13.68/lib/libzzipfseeko-0.so.13.0.68
shrinking /nix/store/yswpmq97h924vmb76l4gr60xs3pszg34-zziplib-0.13.68/lib/libzzipmmapped-0.so.13.0.68
shrinking /nix/store/yswpmq97h924vmb76l4gr60xs3pszg34-zziplib-0.13.68/lib/libzzip-0.so.13.0.68
gzipping man pages under /nix/store/yswpmq97h924vmb76l4gr60xs3pszg34-zziplib-0.13.68/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/yswpmq97h924vmb76l4gr60xs3pszg34-zziplib-0.13.68/lib  /nix/store/yswpmq97h924vmb76l4gr60xs3pszg34-zziplib-0.13.68/bin
patching script interpreter paths in /nix/store/yswpmq97h924vmb76l4gr60xs3pszg34-zziplib-0.13.68
checking for references to /build in /nix/store/yswpmq97h924vmb76l4gr60xs3pszg34-zziplib-0.13.68...

Causes ~1200 rebuilds. Maybe it should go to staging?

@adisbladis Base changed to staging.

@flokli Thank you :+1:


Add a quickstart guide to documentation

For new users transitioning to crypto-browserify (for example due to recent create-react-scripts 5 breakage), it would be really helpful if the user guide had a small example of how to:

Install crypto-browserify and configure package.json
How to import and use the package

For example, treating this like a normal npm package, I expected that this could work:
  "dependencies": {
    "crypto-browserify": "^3.12.0",

import hash from "crypto-browserify";

But it does not. Likely this needs to be patched over the "crypto" namespace, but having explicit instructions for this would be helpful.

If no one can use it due to lack of documentation then there really isn't any point in it existing.


Added ability to copy Z values of geometries in hosted feature service

Added a check to deep copying of hosted feature service to determine if layer hasZ and then add returnZ to query operation when harvesting records from source before adding to destination.
Fixes #239

Can be tested with ArcGIS Online item id 0cedb4d91a8e4e0cb3f648d5821ae288


Add instructions for Alpine Linux dependencies

Point users in the right direction when they install gh-md-toc on a fresh copy of Alpine Linux and see:
sh: ./gh-md-toc: not found

Thanks!

skyzyx:feature/alpine-info
https://github.com/ekalinin/github-markdown-toc.go/pull/19.patch

https://github.com/ekalinin/github-markdown-toc.go/pull/19#issue-299182978https://github.com/ekalinin/github-markdown-toc.go/pull/19.patch

Point users in the right direction when they install gh-md-toc on a fresh copy of Alpine Linux and see:
sh: ./gh-md-toc: not found
```https://github.com/ekalinin/github-markdown-toc.go/pull/19#issue-299182978https://github.com/ekalinin/github-markdown-toc.go/pull/19.patch


Handle unknown and skipped for unknown resources in dryrun diff

Description
closes #3919
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[x] Attached issue to pull request
[x] Changelog entry
[x] Type annotations are present
[x] Code is clear and sufficiently documented
[x] No (preventable) type errors (check using make mypy or make mypy-diff)
[x] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
[x] ~End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )~

Reviewer Checklist:

[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Code is clear and sufficiently documented
[ ] Correct, in line with design

Processing this pull request

Merged into branches master in 3b9f6851564bc4ecba41ca6293bc5fee7a159c12

Processing #3964.


fix: #1032: RPC: getClassAt doesn't follow specification for Cairo legacy program code

Removed double JSON serialization for Cairo legacy program code.

Pull Request type

Bugfix

What is the current behavior?
Calling RPC getClassAt with a Cairo legacy contract address doesn't return a valid compressed program code.

Resolves: #1032
What is the new behavior?
Calling RPC getClassAt with a Cairo legacy contract address returns a valid compressed program code.
Does this introduce a breaking change?

No

may it be related to: #664 ?


Forum Channel Posts

How can I enable posts to a forum channel?  This requires the field "thread_name" in the body of the web hook.  This will create a post with that title.
Here is a screenshot of posts in a forum channel.

When you open the post, users can comment and discuss it.

Nice thought! Should be a straight forward implementation. This will be pushed out in the next release - it will be an addition to our config:
{
  "RssUrls": [
    "YOUR",
    "RSS URLS",
    "HERE"
  ],
  "YoutubeUrls": [
    "YOUR",
    "YOUTUBE CHANNEL URLS",
    "HERE",
    "eg. https://www.youtube.com/@IGN"
  ],
  "DiscordWebhookUrl": "https://discordapp.com/api/webhooks/1139357708546478200/ncB3dshJOPkQhthwOFQibeNt6YI-1_DiFbg0B3ZecfxchnbCGQNdG-m3PxqDdDSvt5Kk",
  "RssCheckIntervalMinutes": 3,
  "EnableAutoRemove": true,
  "Username": "FeedCord",
  "AvatarUrl": "https://i.imgur.com/1asmEAA.png",
  "AuthorIcon": "https://i.imgur.com/1asmEAA.png",
  "AuthorName": "FeedCord",
  "AuthorUrl": "https://github.com/Qolors/FeedCord",
  "FallbackImage": "https://i.imgur.com/f8M2Y5s.png",
  "FooterImage": "https://i.imgur.com/f8M2Y5s.png",
  "Color": 8411391,
  "DescriptionLimit": 200,
  "Forum": true
}

"Forum": true <----- This will enable "thread_name" to be sent in the payload. Defaulted to the post's title

That sounds like it will work.  looking forward to testing.  You wont believe that few other RSS to web hook tools support this.

I'm curious about a few items in the configuration:
"EnableAutoRemove" - What does this do?
Are these fields mandatory?  What if they do not exist in the config?  The Webhook in Discord is configured with a username and avatar.
"Username": "FeedCord",
"AvatarUrl": "https://i.imgur.com/1asmEAA.png",
"AuthorIcon": "https://i.imgur.com/1asmEAA.png",
"AuthorName": "FeedCord",
"AuthorUrl": "https://github.com/Qolors/FeedCord",
What if these fields do not exist in the config
"FallbackImage": "https://i.imgur.com/f8M2Y5s.png",
"FooterImage": "https://i.imgur.com/f8M2Y5s.png",
I have been using a web hook with the following data:
{
"thread_name":"",
"content":""
}
Discord automatically embeds the content based on .  In some cases it might be useful to build this as an embed if Discord doesn't create it correctly.  We can start with your initial version and enhance though.
For example, here are two different posts.  One is me doing the sample above with postman and another is a bot named Readybot.  Readybot uses "Chess News" as the content and embeds the other information.  It's a subtle detail but it allows the title of the RSS feed to be on the tile of the forum post.  In my example, it shows url of the article.  Just a minor UX difference.  I'd love if I could even override the name of the RSS feed (since they aren't always useful).  Again, excited to test this initial version.

"EnableAutoRemove" - What does this do?

This will remove a URL from your list to stop processing it if it gets more than 3 bad responses from said URL

Are these fields mandatory? What if they do not exist in the config? The Webhook in Discord is configured with a username and avatar.
"Username": "FeedCord", "AvatarUrl": "https://i.imgur.com/1asmEAA.png", "AuthorIcon": "https://i.imgur.com/1asmEAA.png", "AuthorName": "FeedCord", "AuthorUrl": "https://github.com/Qolors/FeedCord",

Right now they are mandatory - but I can fix this in the coming update (we would leave them as empty strings) example:

"Username": ""

What if these fields do not exist in the config
"FallbackImage": "https://i.imgur.com/f8M2Y5s.png", "FooterImage": "https://i.imgur.com/f8M2Y5s.png",

There's no handling to have a Config without these fields, but we can change these to be left blank as stated above.

I have been using a web hook with the following data: { "thread_name":"", "content":"" }
Discord automatically embeds the content based on . In some cases it might be useful to build this as an embed if Discord doesn't create it correctly. We can start with your initial version and enhance though.
For example, here are two different posts. One is me doing the sample above with postman and another is a bot named Readybot. Readybot uses "Chess News" as the content and embeds the other information. It's a subtle detail but it allows the title of the RSS feed to be on the tile of the forum post. In my example, it shows url of the article. Just a minor UX difference.

This is certainly doable - with the updated Config file having the forum set to True, we can alter the way we're sending the payload to Discord to get the desired result.

I'd love if I could even override the name of the RSS feed (since they aren't always useful). ...

I could definitely implement this - simplest way would be something along the lines of this in our config:
"RssUrls": [
    {
      "url": "the-rss-url",
      "name": "My Custom Name"
    },
  ]

You're amazing!  Let me just start with testing the "Thread_Name" feature.
Once that's working, I can jump in and create user stories for new features we discussed above (if you'd like).  All doable... just don't want to overwhelm you.  Please know people like me appreciate what you're doing.  This lets me avoid paying for an IFTTT or Zapier plan or even a premium bot.

Right on! Appreciate the support! I'm glad it's finding good use 👍

Hey there!
I have finished working on getting functionality for Forum Posts - like the idea!
please try running your docker container with the nightly image

qolors/feedcord:nightly

Let me know your thoughts!
Reminder that you have to add the Forum field to your config:
{
  // ..Rest of Fields.. //
  "DescriptionLimit": 200,
  "Forum": true <--- Set this as true
}

Still have more work on the official release

FYI, I havent forgotten about you.  I hope to install everything tomorrow and see how it works.

Hey there! Release 2.0.0 is out! 🎉
Forums Support is now available - some modifications to your config file will be required.. Read more here
Thanks for the support!


Request for another format of PCB design file

Hey, I think it would be good if you can provide another format of the pcb design. The problem currently I have is there's no pcb printing service in my country that can use the gerber or the kicad. They use pdf, protel, altium, and eagle (but mostly use pdf).
And I know I can order using the gerber by the jlcpcb, but the shipping is too expensive (using dhl is 3 times of the board price). So I'd rather use the pcb printing service in my country instead.
I hope you can provide at least one of them.
Thanks!

I added a pdf version of the pcb files in the latest commit #e18efab. Got to admit never worked with a company that doesn't accept gerber but I guess its fair with it being a 20 year old standard almost. 😄


Ignores width?

Hey, whats up with the width? anything i put for maxsize, whether its 1, 100, or the function all look like this:

if i uncomment your plugin and use plain old cmp it looks like this:

      formatting = {
        expandable_indicator = true,
        fields = {
          "abbr",
          "kind",
          -- "menu",
        },
        format = lspkind.cmp_format({
          mode = "symbol_text",
          maxwidth = 10,
          ellipsis_char = "...",
          show_labelDetails = false,
          before = function (entry, item)
            return item
          end,
        })
  }

Very weird... the only way i got it to work was to set a blank string... i have no idea why
      formatting = {
        expandable_indicator = true,
        fields = {
          "abbr",
          "kind",
          "menu",
        },
        format = lspkind.cmp_format({
          mode = "symbol_text",
          maxwidth = 65,
          -- ellipsis_char = "...",
          show_labelDetails = false,
          before = function (entry, item)
            item.menu = ""
            return item
          end,
        })

I think #83 fixes this.

What is your version of neovim and nvim-cmp?
I'm on the neovim 0.10.1 and latest nvim-cmp. This is the default nvim-cmp looks like.

The blank spaces in your picture should be the message provided by nvim_lsp.
The workaround for this could be to disable the menu of nvim_lsp.
        format = lspkind.cmp_format({
            menu = { nvim_lsp = nil },
        }),


Implement OwnableData

Requires the API changes in SpongePowered/SpongeAPI#850, therefore checks will fail.
Test Plugin .jar
Test Plugin sources
All outputs from Test plugin will go to the logger on info logging level. Serialization is tested on server startup, tests for tameable entities and skulls have to be run by a logged-in player using the commands /et and /st respectively.
Setting the owner of a PlayerSkull is tricky, since Minecraft requires the name to look up the profile. Therefore I handled this with a call to the GameProfileResolver service.
Checklist for whoever handles this PR:

[ ] Implemented correctly using appropriate abstractions
[ ] DataManipulator
[ ] ImmutableDataManipulator
[ ] DataManipulatorBuilder
[ ] DataProcessor
[ ] ValueProcessor
[ ] Registered correctly
[ ] Keys.OWNED_BY
[ ] DataManipulatorBuilder
[ ] DataProcessor
[ ] ValueProcessor
[ ] Test plugin

Updated matching the changes in the API PR.
Since there is not really a legit default UUID value I can create new OwnableData instances with, I use the UUID 00000000-0000-0000-0000-000000000000 as a "null value". If that value is offered either in an  OwnableData instance or via the Keys.OWNED_BY key, the processor will treat it as removal of that data manipulator / value.
This is not pretty, but the closest to a default value possible.

Rebased for Java 8 changes


Update make_kn_lm.py

Fixed issue #163

Is it ready for merge?

Is it ready for merge?

Not yet. Will let you know when it is done. I think @teowenshen  will test it on his dataset.

Hi @huangruizhe , thanks for the tag.
The algorithm is stuck again at /i/. I think the conditions should be the other way round, i.e. assigning None when the denominator is zero.
Also, from my experience, some sum_z1_f_z summed up to more than 1.0, maybe due to Python's rounding, and yielded a large negative number. This caused print_as_arpa to throw a Math Domain Error at Line 353:

line += '\t{0}'.format('%.7f' % math.log10(bow))

So maybe we should assign None to both when sum_z1_f_z is greater than or equal to 1.0?

@teowenshen Sorry... I made a mistake when making the PR. You are correct.
Regarding "some sum_z1_f_z summed up to more than 1.0", I agree with your guess.
I think the best way to guarantee the correctness (i.e. a valid probability distribution) is to check whether .

Hi @huangruizhe , I have just implemented your fix in my code. It ran smoothly and produced this end result, which seems to be as expected. I attach the end result here too for your inspection.
P.arpa.txt


Prevent operator from overriding .Spec.Replicas

Fixes #963 by using the current .Spec.Replicas from the Deployment if the desired number of replicas isn't explicitly set.
Signed-off-by: Juraci Paixão Kröhling<EMAIL_ADDRESS>

@jpkrohling Once reviewed, would you be able to provide the same fix for ingester, so we don't run into the same issue with adding HPA to that?

@objectiser great point. I just went ahead and changed the query and ingester to use the same approach as the collector when it comes to the replica size.


Dialog component has more than one role

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
Dialog component has two roles: none and presentation:

Expected Behavior 🤔
Dialog component has only presentation role:

Duplicate of #18935


Create a button to "Check for updates"

Describe the enhancement you'd like to see
Monokle 1.7 was just released! 🥳
But when opening Monokle 1.6.3, I haven't received any notification to update.
Could we create a "Check for updates" button to search and download new versions?

Hi @aabedraba , we didn't have the builds for updates ready yesterday so that's why the modal didn't appear.
We will create them today as soon as possible

Thanks @devcatalin
I still think it's a good idea to have a proactive way of looking for the updates 🤔
But if we're sure that it's always displayed when a new release is there, maybe it's not an important issue, so feel free to close it :)


Update AQAvit certification to another name

We have been advised that the use of the word "certification" should be avoided (something about angering the gods, or some such).  In the website-v2 documentation, we've updated to use the word AQAvit "verification", but that does not seem appropriate for use as a menu item.
We know we want to change from certification, but need to determine the right word to switch to.  This issue is a placeholder for the work to change the menu item name.

Closed via https://github.com/adoptium/aqa-test-tools/pull/637


Domain Items Highlight toggle may need refresh to function

If you start trailing and have the toggle to highlight domain items on, it may not highlight them if the page loads after this is toggled.  You man need to toggle it off, then back on again to get them to highlight.  Think this is an order of operation sort of problem perhaps.

Completed and submitted pull request #104

Tested, looks good.  Tracking related issue with #114


Please match the requested format

When trying to add the server it says 'Please match the requested format' my domain is https://headscale.domain.network. Is .network not considered a TLD in the code?

The input is theoretically tied to a domain regex, but I'll test yours tomorrow and see if it doesn't meet the criteria. If not I'll have to find a better representative algorithm.

I can confirm that I can enter https://headscale.domain.network as is, can you provide an example where it doesn't work?

Closing unless/until problem can be recreated.


[ENG-872] feat: Add Microsoft Dynamics 365 Sales connector

Checklist

[x] Ran Linter

WARN [runner/source_code] Failed to get line 391 for file utils/credentials.go: invalid file line index0 (390) >= len(fc) (92)
WARN [runner/source_code] Failed to get line 402 for file utils/credentials.go: invalid file line index0 (401) >= len(fc) (92)
::error file=utils/credentials.go,line=391,col=1::getFromReader returns generic interface (T) (ireturn)
::error file=utils/credentials.go,line=402,col=1::get returns generic interface (T) (ireturn)
make: *** [Makefile:14: fix] Error 1

[x] Catalog tests passing
[x] Created PR from non-main branch

Catalog variables
Workspace: org5bd08fdd
Scopes: https://org5bd08fdd.crm.dynamics.com/user_impersonation,offline_access
As of now substitution works for BaseURL. Here user impersonation scope itself contains workspace variable.
Notes
Acquires AccessToken from Microsoft Entra ID that has preconfigured permissioning to access Sales App APIs making it a Sales Connector.
Testing
All Postaman requests are compared to the Web Portals View of Dynamics365Sales to demonstrate that both of them access the same data.
GET
URL: http://localhost:4444/
Top level discovery endpoint. Lists all entry sets for Sales CRM.

URL: http://localhost:4444/contacts?$select=fullname
List Contacts fullnames.

POST
URL: http://localhost:4444/leads
Create new Lead. To verify that it was created lets view this information in CRM.

GET
After lead creation filter GET response by firstname to get entry id, this will be used in update and delete step below. URL: http://localhost:4444/leads?$count=true&$filter=contains(firstname, 'Bob')
Now request Single Entry.
URL: http://localhost:4444/leads(dd2f7870-3fe8-ee11-a204-0022481f9e3c)?$select=firstname,lastname,subject

PATCH
URL: http://localhost:4444/leads(dd2f7870-3fe8-ee11-a204-0022481f9e3c)
Update Subject Name of the lead.

DELETE
URL: http://localhost:4444/leads(dd2f7870-3fe8-ee11-a204-0022481f9e3c)
Removes lead. After which entry is not found.

Pagination
GET
URL: http://localhost:4444/phonecalls?$count=true
List phone calls counting the number of entries.

First page
URL: http://localhost:4444/phonecalls?$count=true&$select=subject
List phone calls, limit to max page size of 2 via Prefer header.

Next page
URL: http://localhost:4444/phonecalls?$count=true&$select=subject&$skiptoken=<cookie pagenumber="2" pagingcookie="%253ccookie%2520page%253d%25221%2522%253e%253cactivityid%2520last%253d%2522%257b3D1D5314-ED24-EB11-A814-000D3A30F257%257d%2522%2520first%253d%2522%257b1D1D5314-ED24-EB11-A814-000D3A30F257%257d%2522%2520%252f%253e%253c%252fcookie%253e" istracking="False" />
Follow next page. We specify the same maxpagesize header. The link cannot be constructed or altered(as of MS docs), we are treating it as opaque string.

@RajatPawar it is ready for review :smiley:


added files for 2.23 blog post

According to https://www.coronawarn.app/en/faq/results/#glossary_validity the terms in English are:

technical validity and
effective validity

The blog however uses the term "technological validity" and "professional validity" which is inconsistent.

@HannaHei / @dsarkar
Will you address the issues I raised in this PR or do you want new issues submitted to document them?

@MikeMcC399 let me ping @HannaHei first.

https://github.com/corona-warn-app/cwa-website/pull/2933 addresses the issue raised in https://github.com/corona-warn-app/cwa-website/pull/2925#issuecomment-1143807169 concerning the English-language validity terms used.

The title of the blog
"Extension of technologically expired certificates in the CWA"
still uses the term "technologically" instead of "technically" 🙁

To follow up the issue using regular processes I submitted https://github.com/corona-warn-app/cwa-website/issues/2938

@HannaHei has not explicitly replied here, however the text problems regarding validity terms have been resolved through two PRs she submitted, so there is no need for a new issue on this topic.


bug 1757547: charts/openshift-metering: Update cpu/memory usage promqueries to handle many to many matching error

These queries were returning many to many matching errors on the
group_left that I didn't end up diagnosing, but I discovered we can
remove it since the container level metrics got the node name field that
we were joining from kube_pod_info. This simplifies them overall.
Additionally, I bumped up the window size for when we take the rate of
the CPU.

/hold I want to file a bug on this and possibly backport to 4.2

/hold
I want to file a bug on this and possibly backport to 4.2

This PR and others are blocked until #960 merges

/bugzilla refresh

/cherry-pick release-4.2

/hold cancel

The cherry-pick needs https://github.com/operator-framework/operator-metering/pull/962 since that has changes this PR requires (which came from #960)