pass input size M when creating mp emissions models, so F is right shape

Code otherwise breaks when making an mp-SLDS with inputs with size > 1

Hi @slinderman and @jglaser2, @orrenkt and I were running into an issue when fitting multi-region models with inputs. The emission parameter F that captures input dependence would be initialized to the wrong size. Here we propose a fix by passing the input size M when initializing the emission models that make up the compound emission.

That looks right to me (although I haven't run the updated code). I hadn't been running the multipop extensions with inputs, so thanks for updating that.


[UI/UX] Duplicate storymap feature

Description
Currently, users cannot modify existing storymap unless they have edit permission.
In a storymap page, maybe Duplicate button is needed to copy existing storymap as signed user owned storymap.

Click Duplicate button
Copy the storymap to create new storymap with owner permission for signed user
Open editor for duplicated storymap

Something similar to fork functionality of Github. Maybe we can have another table to manage which storymaps are copied  to this.

table: storymap_duplicate
columns:

original_id
duplicated_id
duplicatedat
duplicated_user

Then, we can show how many storymaps are duplicated from original one.
Screenshots

current

Mockup URL/file
No response

Questions to discuss:
Why do we need to see how many storymaps are created from the original one?
Figma Prototype


How to speed up training

Phenomenon
GPU cannot maintain high utilization. The utilization rate of the CPU is always maintained at about 400% and cannot be improved (Our CPU has 32 cores and 64 threads).
What I did
Adjusting IMS_PER_BATCH, NUM_WORKERS in the configuration file, and OMP_NUM_THREADS and MKL_NUM_THREADS in train_gdrn.sh did not improve CPU utilization.
Do you have any good suggestions?

Not sure, I am satisfied by the current speed.

Not sure, I am satisfied by the current speed.

How long does it take you to train? Thk.

For lm, < 10h.


Replace Apache Xalan with an alternative

Hello team,
Blackduck and WhiteSource report this vulnerability against Apache Xalan, which comes under htmlunit dependency. I want to know if that is planned to remove or replace Apache Xalan in future releases of the htmlunit library.
Thanks
Khusanjon

I already had a look at this several times, but i have no real idea how to do this with reasonable effort.
If you have an idea we can discuss this.
Or if you use HtmlUnit for your business we can have a look set up some sponsoring for this dedicated task.
@black-snow - if you like you can have a look at possible xalan alternatives

Maybe we have to have a closer look at SaxonJ-HE

To sum this up: Apache Xalan has long been the de facto standard for XLST in java but is pretty much dead now and has a CVE 9.8 (!) vulnerability that basically allows arbitrary code execution via malicious XLSTs.
I'll update the comment while investigating further.

Thanks for the first analysis.
Xalan is only used as XPath processor - for XSLT we use the java build in stuff.
Look at all the classes in the com.gargoylesoftware.htmlunit.html.xpath package.
If my memories are right, i did some try to use the jdk stuff also for XPath handling but i failed (maybe i'm to stupid).
But this means, there is no real need (at the moment) to use a full blown xslt engine only for xpath processing.
Maybe there is also an option to do roll our  own XPath handling (e.g. like https://github.com/code4craft/xsoup).

HI @rbri , any alternative planned or being worked on?

@sumitsg004 no real plans so far, did some experiments with the xsoup code - what i really like with rolling our own is the option to share the selector implementation (in parts) with the css selector stuff.
Maybe we can implement two parsers building the AST but using same nodes for same selectors (eg.g by id) and then processing the ast on an root node.
But this is just only an idea - any help is welcome.

Next step is to try to make a xpath only xalan clone - lets see if this works

current status: https://github.com/HtmlUnit/htmlunit-xpath

current status: html unit switched to htmlunit-xpath

@rbri thanks for the update.


Polish addCommentToUncommittedPRs

Clean up dead code/comments.
Don't comment on merged PRs.
Improve wording a little.
Move isTeamMember check earlier, so that it applies to both kinds of comments.

Yep, agree 👍🏻


Should we start a Discord?

First of all: I don't think it should replace the discussion in the github issues, and I don't expect there would be much traffic at all in there, but:
I think some discussion on this board would benefit from the "instant-ness" of a Discord chat. Some quick support or easier troubleshooting would be nice.
Of course I expect there would be frenquent "file an issue on github", because this is great for keeping track of issues, much better than a Discord server would.
Thoughts?

I sort of enjoy being able to take distance, so I probably won't be hanging out. However, I'd be happy to hop on at a scheduled time to discuss certain issues in real-time if people'd thought they'd benefit from that.
So: from my POV: feel free, I might make use, but probably won't be a constant regular :)

On Thu, May 13 2021 09:54, Rougemoot wrote:

Thoughts?

Real-time sounds great!
Personally, I would advocate for an IRC channel (freenode hosts a lot of
free software projects) or a matrix room (these two could be bridged
very easily as well).  Being yet another project that only has
proprietary communication channels would make me a bit sad.

Till now I didn't contribute anything to kmonad, but I would feel especially sad about the project being hosted on discord and not a free messenger. I feel like that, since kmonad is the project, that made me learn haskell (i'm still on it), so that i'm able to contribute to it.

I would be interested in live chat too. I second @slotThe 's proposal of IRC

Discord has a lot of great tools that makes it much more 2021 than IRC, so I'd much prefer that, but if people prefer IRC I guess that'd at least be something.

+1 for Discord. Most tech projects I'm a part of these days are using Discord. Hell, I don't even have IRC these days.

+1 for discord. Kmonad can be a bit difficult to get into so would be nice to have a place to ask questions and trubbleshoot having to open a new issue

I have never missed a chat for KMonad. But I also think that not every beginner's question should be labeled an issue. When I had a question about surfingkeys and created an issue, they told me that there is a GitHub Discussions page for questions like that. I think not many GitHub repositories use it. But maybe this is an option for KMonad, too. (Of course, this could be used additionally to IRC or Discord.)

I dont really care if its a github discussion forum or discord, but I think some way of communicating outside of creating issues would be nice

Maybe we should disappoint everyone and see if we can do some kind of ICQ room? Or am I showing my age with that joke?
I really like open-source free. Didn't realize discord wasn't that. However, I also really like ease of use and accessibility, and I remember having issues getting into IRC myself.
I'd really like to leave it open to the community, but on the other hand, a community without some guidance tends to go in 5 different directions, and suffer because of it. Sooo.....
How about we start a discord page. Basically because I think when a young nerd shows up at KMonad, they are probably more likely to know how to access discord than IRC, and some might be scared off by IRC. Whereas the old nerds are wiser and more patient, and although they prefer IRC, they are content using Discord and only occasionally making snide comments about the good old days?
However, anything worth preserving should never be 'stored on discord'. We should be ready to abandon ship the moment the policies start heading in the wrong direction. At which point the young nerds must adopt the ways of the wise ones, and off to IRC we go.

Oh, and if some of the wise ones want to already start an IRC to grumble about those little-enders in Discord, I'm not going to stop them, but I do think most of the signposts pointing at real-time help should point at Discord.

I really like open-source free. Didn't realize discord wasn't that. However, I also really like ease of use and accessibility, and I remember having issues getting into IRC myself.

That it's not accessible isn't exactly true, since there is e.g. kiwi that allows joining irc channels from the browser.
Also, matrix has with element a web client (you don't need your own server, since there is a public instance at matrix.org).

That it's not accessible isn't exactly true, since there is e.g. kiwi that allows joining irc channels from the browser.

Hey, that's really cool! Much nicer than the last time I tried to get on IRC.

Also, matrix has with element a web client (you don't need your own server, since there is a public instance at matrix.org).

I'm not sure I understand what you mean.
Since Kiwi gives such straightforward access to chat, my preference actually goes to IRC then. Any benefits to Discord that IRC doesn't have? Remember: you are talking to someone who has used neither: a mountain hermit who knows how to code, and very little else. That I can even maneuvre git is a miracle.

Also, I think we should wait at least until Monday to make any decisions, to give everyone a chance to contribute their views.

I'm not sure I understand what you mean.

There is a web client available for the matrix protocol, called element.

The matrix protocol...
I found this, but it's confused me even more: https://www.matrix.com/
Is this a 3d option? IRC, Discord, or Matrix? Is it something like Stack?

Element is a client for matrix. Matrix is similar to irc, since it is an open protocol, but in contrast it's federated. You can pretty easily bridge irc and matrix, so i don't really care which if either of those is chosen.
Matrix feels much more 2021 than irc, since it allows reactions, real replies, message editing, you don't have to be online all the time…

Any benefits to Discord that IRC doesn't have?

Discord allows reactions, message edits, built-in replies (seeeolvable by irc clients), you can see who is online, you can see how is typing, you don't have to be online, you can have multiple channels, there is voice-chat and video-chat and screen capture

But you have to use the official client that isn't exactly that privacy-aware (There are alternative clients, but i've heard you get banned, the moment discords finds out you used one).

I'm thinking that KMonad might at some point have some success with people who like to game a lot and want to bind macros and such to complicated keymaps. I'm probably right in estimating they'd be much happier popping into Discord, right?

There are also some other issues, e.g. if there is a new version of discord available, you have to use it. Which is really annoying on linux, since they don't warn you.

Ahh, I've only ever used discord from my browser, and then only a few times. I really would like to keep things as easy as possible on Linux, since um... I use Linux.

It's not a real issue, but it just chose discords attitude

I'm going to actually write some code now and wait for opinions and views to trickle in. Amazing, how distracting social media can be :-D

I'm probably right in estimating they'd be much happier popping into Discord, right?
Yes, that's probably right.

On the other hand, it wouldn't hurt to use irc, so that those that need reactions, editing, permanent messages, etc. can have that with a small effort on matrix and people, who have short questions can just hop onto kiwi.

Is this a 3d option? IRC, Discord, or Matrix? Is it something like
Stack?

Essentially, but Matrix and IRC integrate with each other very easily
(the matrix project bridges all of freenode, for example, so we'd
essentially get that for free).
IRC webchat is indeed very easy to join (and probably poses the least
number hurdles for users who just want to ask a quick question); just
enter a username and the channel and be ready to go.

Whereas the old nerds are wiser and more patient, and although they
prefer IRC, they are content using Discord and only occasionally
making snide comments about the good old days?

I can only speak for myself, but I won't be using discord anytime soon
(not that this should discourage the community from making one, should
more people want that).

I'd really like to leave it open to the community, but on the other
hand, a community without some guidance tends to go in 5 different
directions, and suffer because of it. Sooo.....

I definitely think that a little BDFL action is necessary, should we not
be able to find a consensus :)

There are also convenient ways to link a Discord server to IRC chatrooms, so that people can use whichever they like.
To me, Discord has a few advantages:

People of 2021 are much more likely to look for a discord server than an IRC chatroom. Even in the FOSS community. Discord is currently the most used platform for such things, and for good reason imo.
People might be turned off by an IRC chatroom, because let's face it, it's ancient, and not very user-friendly (just like with kiwi, on Discord you can join as a guest without creating an account IIRC.
Multiple channels on a single server. It might seem trivial, but much more than a solution to "too much traffic to have a discussion" (which is a problem we most likely wouldn't have), it's a very nice way to compartimentalize discussion about different topics. Tech support, suggestions, general discussion, off-topic...)
A very nice search engine, and discussion history. While I completely agree that nothing of "value" should exist only on discord (anything like bug reports, etc should definitely be kept on github, if only as a way to store them after having discussed them on Discord)

While I somewhat agree that using FOSS solutions is preferrable, I don't think it's worth giving ourselves any extra hurdles for the sake of doing so. That said, I'm definitely not a big contributor to the project, just a user who likes to give input and help where they can, and comes here for some help at times (although isn't that exatly the target for such a chatroom?)

I'd STRONGLY suggest not going for IRC. Multliple reasons here, among them that IRC is definitely not all that friendly to younger people and not all that welcoming to beginners in general (as it doesn't allow for clean organization into different channels). but, most importantly: having messages not persist would be a very stupid decision for any platform that's supposed to be focused around a tool like this, where a lot of the discussions would also be people asking for help. IRC would inevitably end up with getting the same 3 questions every day, because it's literally impossible to look at history.
Matrix doesn't suffer from that last issue, and is thus already infinitely preferable to IRC.
BUT: Still strongly argue in favour of a Discord. Not only is discord by far the most welcoming platform among the bunch, and generally the most popular - but organization into separate channels is a big thing for a project-focused community. even just splitting up development-related and user-focused discussions is a big deal. Not having that immediately makes the place much less useful in general.
Additionally, it is still possible to set up IRC/matrix bridges for a discord server. This would have the big benefit of keeping the IRC fans (mostly) happy while still not losing out on the (imo very essential) benefits of discord (-> message history, search, etc).
Not going with discord would be purely idealistic choice, which,.... I'm not a fan of, especially when it comes to something as inherently pragmatic as KMonad.

On Fri, May 14 2021 10:47, ElKowar wrote:

but, most importantly: having messages not persist would be a very
stupid decision for any platform that's supposed to be focused around
a tool like this, where a lot of the discussions would also be
people asking for help. IRC would inevitably end up with getting the
same 3 questions every day, because it's literally impossible to look
at history.

I don't think that that's very fair.  It's very easy to set up global
channel logging on IRC; both #haskell and #xmonad do it, for example.
This could then be placed inside the topic for everyone to easily find.

Not only is discord by far the most welcoming platform among the
bunch,

What could be more welcoming than IRC?  Just hop on and start chatting!
Don't even have to make a pseudo-account that you get pressured into
"claiming" later on.

and generally the most popular - but organization into separate
channels is a big thing for a project-focused community. even just
splitting up development-related and user-focused discussions is a big
deal. Not having that immediately makes the place much less useful
in general.

Serious discussions surrounding development should probably happen in
issues/pr's anyways.  But really it's not that big of a deal.  Looking
at #xmonad again I think this illustrates quite well that things works
out just fine in general.  It's not like you can't have multiple
discussions on IRC at the same time either (highlights are generally
used in that case).

Ahhh, so there were strong opinions in both directions. This I did not
anticipate. I've given it some thought, and I said I would wait till Sunday, but
I've ended up landing on a both-a-and-b decision which I think will equally
please and disappoint everyone.
This should probably be turned into some documentation at some point, but for
now this seems good enough.
TL;DR
Let's do both. I won't hang out in either. I'm happy to show up at scheduled
times or for appointments in both. I'm not going to be actively moderating
either. Anything that should last should be put on GitHub. Please be kind to
each other. If you have serious issues with each other, come to me.
My reasoning
A or B
There are people who strongly prefer A, there are people who strongly prefer B.
Both have very valid and good reasons. Sometimes it is good for a BDfaW
(Benevolent Dictator for a While) to be very clear and forceful in their
decisions, but sometimes it is not.
I do not like disappointing people, or forcing my ways on people. However, when
it comes to the code-base, I am going to make the effort to impose my will when
I think it benefits the project. The discussion IRC-vs-Discord is more of an
argument along the lines of: do we want to socialize in the cafe next to the
library, or the arcade across the street? Honestly: I don't like cafes or
arcades, and I'll mostly stay in the library (or on top of the mountain behind
the library in solitude). Here of course the library means GitHub, which is
where I think we should keep a record of all important conversations.
So, you all have my blessing to start a Discord or an IRC (or an actual cafe or
arcade) and get as much cross-platform connectivity as you can manage. The
benefit of either is that we can have easier real-time interactions, and I'd be
happy to come and visit either for that purpose. I'm also happy to schedule a
weekly David-is-here-for-an-hour arrangement, or to pop in uninvited. However, I
am also one of those people who keeps their phone on airplane mode for 6 hours a
day, because I prefer to not to have my thought interrupted. I think it's
conducive to sanity.
If you ever notice that someone shows up and they have a question, and your
impulse is to refer them to an already existing record on either the IRC or the
Discord, then I would ask you to copy out that conversation, put it in a
well-titled issue on the github, and just close the issue, and refer people
there. You don't even have to edit it, if the conversation is clear, that's
enough. That way people will not have to enter a cafe or an arcade to access the
books. The books should live in the library.
Moderation
If we are going to start hanging out in cafes or arcades, there will eventually
arise conflict. Such is the way of communities. Especially as they grow,
reputations get established, and egos get involved. Additionally, I am giving
the green-light on the opening of KMonad related real-time communities that I
won't be very real-time present in.
Everyone up to now has been extraordinarily pleasant to interact with, and it's
been an absolute pleasure to see my little booping-about project turn into
something that people like, want to use, and want to contribute to. As projects
grow, inevitably community moderation becomes a topic.
I am very much not a fan of stringent speech codes. I've seen communities get
very heated and upset around these topics, so I'm hoping to nip this in the bud
early. We will not be implementing one. I have a personal code that I live by
and use to guide my interactions (also outside of GitHub) that I am going to put
down here as an invitation. But again, this is just in anticipation of future
conflict. Up until now everyone has been absolutely great, so I am not asking
anyone to change anything about their behavior.
My code:

Try your hardest to be kind
Failing that, try your hardest to be civil
Failing that, try your hardest to be quiet
Failing that, go away until you can be quiet

If strong conflicts do arise, they can be brought to me, and I will hear out
both sides and attempt mediation. However, very much on a case-by-case basis.
Conclusion
I hope I've given a clear overview of my thoughts, and that you can all find
yourselves in the outcome. Furthermore, I hope that the expectation I've
expressed about your behavior doesn't feel stifling. Having gotten all of this
out of the way, I will conclude with:
Go forth and socialize!
P.S. Closing because 'decision made', but I'm happy to hear feedback here.

I like that decision! I'm assuming that @Rougemoot may be the one to create a discord server here, and @slotThe to manage an IRC?
I definitely think setting up bridging and having both is the way to go. That way, if there is a clear favorite, it will show itself to be that naturally. If there isn't, connecting the two places makes everything easy!

I will leave the decisions on who runs what up to the community. I will sit in the library and occasionally stroll through all available venues :-). Hey, who knows, maybe one day we'll have competing IRC channels and we can do dance-offs and rap-battles and such. I've been led to believe by my television that this is a thing that happens ;)

Sounds good, i'll organize a beatboxer for the rapbattle!

On Sat, May 15 2021 00:30, ElKowar wrote:

and @slotThe to manage an IRC?

Sounds good to me :+1:.  I've contacted freenode staff to register the
kmonad project with the network, so we can get #kmonad, as well as the
whole #kmonad-* namespace (so competing channels can be called
#kmonad-join-us-were-much-better-than-them)!

Meanwhile vherrmann already created the #kmonad channel on freenode
:S

oh lol

Meanwhile vherrmann already created the #kmonad channel on freenode
:S

On freenode, primary channels (one starting with a single #) are reserved for registered projects.  If you want to create a "community channel" of sort you'll have to use ##kmonad.  But really, don't worry about it :)    Worst that'll happen is that freenode staff kicks you (and you lose your OP) and you just rejoin the channel

Is there a reason  for not using github discussion by the way?

Is there a reason for not using github discussion by the way?

Not really, never used it, never felt the need. What is the niche it could fill?

Well, here we go!
https://discord.gg/3tFfWmnahN
Big thanks to @elkowar and @6gk for their help, they basically set the whole thing up. There's already a few people from the /r/unixporn discord server.
There are some things to do still, but we have a great start

In case people want to stop by, we're currently squatting on freenode/#kmonad (join via webchat if you don't have an IRC client set up!).  This will be official as soon as I hear back from the freenode admins (and perhaps once David sends them an email to confirm that I'm not just some rogue contributor acting on their own behalf :))

@slotThe Nice.  Hope the response is timely!
What would your thoughts on bridging the IRC to the Discord?
I'll look into methods of doing that later, hopefully.

Hi. How did this end? I can't connect to that channel. Neither the linked web client, nor my HexChat work. Is there currently a place for noob questions?

Hi. How did this end? I can't connect to that channel. Neither the linked web client, nor my HexChat work. Is there currently a place for noob questions?

Freenode imploded and we moved to Libera (as should be written in the current README<EMAIL_ADDRESS>


"tmpDir" within *.neon files are not respected due to phpstan-vscode "phpstan.tmpDir" config

When the vscode setting "phpstan.tmpDir" is unset, we should not default to /tmp/phpstan. We should instead honor the tmpDir setting in each of the passed config files:
parameters:
    paths:
        ...
    excludePaths:
       ...
    tmpDir: ../../.phpstan.cache/tests

Currently we ignore this value altogether and attempt to set the cache to /tmp/phpstan which can cause really awful performance on docker environments since we won't have a prebuilt cache there on container start (unless we bind the /tmp/phpstan directory to somewhere on the host. And this is also wiped on restart of the container, causing every first run (after opening vscode) to take exceedingly long.
This also means if we are using more than one config file via "phpstan.configFile" then every single run is going to never use the cache, since they both try to write to the same cache, which causes it to be invalid as per the PHPStan result cache docs:

Analysis variables used to invalidate a stale cache. If any of these values change, full analysis is performed again.
PHPStan version
PHP version
Loaded PHP extensions
Rule level
Configuration files hashes
Analysed paths
composer.lock files hashes
Stub files hashes
Bootstrap files hashes
Autoload file hash

Just to add with a few changes it does look like it actually reads the correct file, it's just the output of the extension that is printing the wrong information
[check:2] Spawning PHPStan with the following configuration:  {"binStr":"docker","args":["exec","-t","REDACTED_api_php-1","php","/var/www/REDACTED/vendor/bin/phpstan","analyse","-c","/var/www/REDACTED/build/phpstan/tests.2.neon.dist","--error-format=json","--no-interaction","--memory-limit=4096M"],"tmpDir":"/tmp/phpstan"}

Ah yeah that would explain it. It was intentional that the tmpDir wasn't being used since it's not trivial to parse a neon file, but indeed on machines/docker-images that reboot often, storing cache in tmp will cause a lot of full checks.
Will try to fix this but again I'm a bit busy currently. But thanks for the report!

Turns out I didn't need to parse the neon file, the default wasn't needed at all and I just removed it.


Asyncpg Connector implementation

Still very very early implementation. Mostly taking the suggested converter and loosely implementing the connector interface.
Needs:

[ ] Error handling - steal from others?
[ ] Tests - copy/paste from aiopg
[ ] a second set of eyes, maybe even more

Closes #417

Successful PR Checklist:

[ ] Tests

[ ] (not applicable?)

[ ] Documentation

[ ] (not applicable?)

Hey there, sorry for the delay.
I haven't been very active on the project maintenance these days. It looks like you're going in the right direction. The structure of the project means that adding a new db driver should, as you saw, only result in a single new file (plus tests).
Regarding test, it would be worth writing specific tests for the connector. Also, a sencod set of brain to ensure there's no risk for SQL injection is never too much.
I wonder if it would make sense that the converter has a method that receives query and arguments and returns the new query and the new argument instead of having to do the replacement yourself outside of the converter with %.

I'm no longer working with python project on a daily basis, and hence don't have the time to finish this work. A lot has happened, sorry for the long pause. I hope someone will pick this up.
Thanks for a great project.

Hey, thanks for the time you spent anyway :)
I'm currently working towards a psycopg3 implementation, and I'm starting to believe it will probably be the only supported one in the future. If people want to support other connectors, They'll likely be able to do it on their own, potentially in a dedicated package.


Test issue for reference

This issue serves no purpose other than to be referenced in git messages.

Reopen for testing


ContextMenu Support

I would like to be able to use the context menu in webview_windows. Ideally, this should allow for custom context menus, so consumers of the plugin can specify their own menu items and behaviour.
Webview2 already supports this functionality, so it just needs to be exposed.
https://learn.microsoft.com/en-us/microsoft-edge/webview2/how-to/context-menus?tabs=csharp
My C++ / Webview2 experience is non-existent, but I could work on this with some guidance.

considering to use context menu. does this lib support?


Inject content and actions into MdDialog

Bug, feature request, or proposal:
feature request: The injecting of content and actions for a MdDialog that has the same process as adding a 'normal' action for example.
What is the expected behavior?
For example a button stays like this <button md-raised-button="" color="primary" md-dialog-close="save">Save</button> when inspecting the page.
What is the current behavior?
For example it should have all the extra ng attributes  <button _ngcontent-c2="" class="mat-raised-button mat-primary" color="primary" md-raised-button="" ng-reflect-color="primary"> 	Open

  </button>
What are the steps to reproduce?
Using a pipe to set the text to SafeHtml and then building the actual form to inject into the innerHTML of both md-dialog-content and md-dialog-action. See http://plnkr.co/edit/IqTaoL?p=preview
What is the use-case or motivation for changing an existing behavior?
I want to dynamically setup a dialog.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
All for what I've found
Is there anything else we should know?
Nope

https://stackoverflow.com/a/40474494/4811678
https://stackoverflow.com/a/36408622/4811678

Ok, so I need to change my whole approach on this then. Thanks for the info!


Toasts don't support testid (or other data props)

Provide a general summary of the feature here
Most components support data props. Toast currently does not. Since it's added via the ToastQueue, we can't really add the prop. I'd like to add data-testid (or any data- prop) via the toast options.
🤔 Expected Behavior?
ToastQueue.neutral('Toast available', {...options, 'data-testid': 'some-testid' })

😯 Current Behavior
Test id is not supported by toast
💁 Possible Solution
https://github.com/adobe/react-spectrum/pull/6200/files
🔦 Context
Majority of RSP components support testid. Toast should as well.
💻 Examples
No response
🧢 Your Company/Team
Adobe/DC
🕷 Tracking Issue
No response

@snowystinger suggested adding domprops support or any data-* attributes. Open to suggestions. Just will be helpful for testing purposes.


new relationships for MF

https://github.com/geneontology/annotation_extensions/issues/70#issuecomment-264290901
OK working,
warning in 50a71e0348432087: directly_activates() not allowed for molecular_function
(I was sure I had done a few but only this one in the log file so far)

I've changed the config so it should be fixed tomorrow.

On 01/12/2016 22:04, Kim Rutherford wrote:

I've changed the config so it should be fixed tomorrow.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pombase/pombase-chado/issues/600#issuecomment-264309831,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHBLKIcLa4oZcBbtG5l1NgmaMmIUa56zks5rD0RVgaJpZM4LB8X5.

which ones did you add?

which ones did you add?

I only added directly_activates because that was in the log message.  I forgot about directly_inhibits.  I've added it now.

I've updated the configuration to use the current GO relations - per last few comments on https://github.com/geneontology/annotation_extensions/issues/70, they're now directly_negatively_regulates and directly_positively_regulates.
(I also updated the one annotation that used directly_activates in the Canto session.)

Hmm, I thought the decision was to use "directly activates" and "directly inhibits"
@dosumis  wasn't that the plan?

It says in the linked GO ticket that they're now directly_positively_regulates and directly_negatively_regulates, and those are on the list DOS linked to from it.

we can  add this to the display label config ...wherever that may end up to be....


feat: modify email duplicate lookup to use identities

Modifies the IsDuplicateEmail method to use email addresses within the identities table and not the primary user email address in users.
It now also returns the duplicate user it found, so that it can be reused in signup and update user.

Hmm i tested this PR with the following scenario:

User 1 logs in with github using<EMAIL_ADDRESS>User 1 changes github email to<EMAIL_ADDRESS>User 2 tries to signup with<EMAIL_ADDRESS>- this should now be possible with this PR right? However, it returns a unique constraint violation from the DB which looks like:

{"code":"23505","message":"duplicate key value violates unique constraint \"users_email_key\"","detail":"Key<EMAIL_ADDRESS>already exists."}

This PR doesn't fix the issue when you have a duplicate email address in the users table, but does use the email address present in the identities table instead of the one on users. (Since, the email addresses in identities is a subset of the one email address in users.)
Updating of the email address is today not being reflected in the email identity, which is fixed in #824.

Currently, we obfuscate a UserExistsError returned to prevent the /signup from leaking user information. However, this PR will always return an error now.

Let me check this and why it's happening, but it should be the same error.

@kangmingtay added a final check through auth.users which should fully prevent duplicates from accidentally showing up.

Updated the timestamp of the file and using 2022-11-25 as the updated at column.


adding glossary items "layer" and "namespace"

Referring to Issue #2407, adding sections for "layer"  and "namespace" in https://docs.docker.com/glossary/
Proposed changes
Requested addition of glossary items for "layer" and "namespace" in the glossary.md
Added two sections for each of them in _data/glossary.yaml file. Added a brief definition and links to references where needed for more elaboration.
Related issues (optional)
Glossary should have entries for "namespace" and "layer" #2407
https://github.com/docker/docker.github.io/issues/2407

@johndmulhausen the CI test looks good, the PR is waiting for some one to approve. Please take a look!


Add netlify-identity submodule

Website needs to be updated to document this submodule, and the two parameters that may be overridden:
[params.decap_cms._netlify_identity]
admin_path = "/admin/"
js_url = "https://identity.netlify.com/v1/netlify-identity-widget.js"

Ready for your review and merge @razonyang -- thank you!

Sorry for the delay response, just set up a demo on Netlify to see how it work.

No, that code only gets executed in response to the netlify server, which returns to the homepage, and really needs to go to the admin page. Someone who is not editing using the CMS will never know that it’s there
On Feb 8, 2024 at 7:18 PM -0800, Razon Yang @.***>, wrote:

@razonyang commented on this pull request.
On modules/netlify-identity/layouts/partials/hugopress/modules/decap-cms-netlify-identity/hooks/body-end.html:

That bit of code is required to redirect the response from the netlify identity server from / to /admin (or wherever you are going to base it). If no netlify response, it does nothing.
I'm still be confused by this, are you intend to force users to login into Decap CMS when they're visiting the homepage? For example, visit / -> not log in -> redirect to Decap CMS dashboard.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

No, that code only gets executed in response to the netlify server, which returns to the homepage, and really needs to go to the admin page. Someone who is not editing using the CMS will never know that it’s there

I took a look at the identity widget library docs, that code listend the login event, so it seems that you've a login button on homepage, redirect to /admin after user login?

For me the login button only appears on the admin page, but that code doesn’t know about admin so it returns to /, and without it, I never complete the login.
I don’t get any login button visible on root.
From decap docs:

When a user logs in with the Netlify Identity widget, an access token directs to the site homepage. In order to complete the login and get back to the CMS, redirect the user back to the /admin/ path. To do this, add the following script before the closing body tag of your site's main index page…

https://decapcms.org/docs/choosing-a-backend/
On Feb 8, 2024 at 8:27 PM -0800, Razon Yang @.***>, wrote:

No, that code only gets executed in response to the netlify server, which returns to the homepage, and really needs to go to the admin page. Someone who is not editing using the CMS will never know that it’s there
I took a look at the identity widget library docs, that code listend the login event, so it seems that you've a login button on homepage, redirect to /admin after user login?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

When a user logs in with the Netlify Identity widget, an access token directs to the site homepage. In order to complete the login and get back to the CMS, redirect the user back to the /admin/ path.

I get it, thanks for the references.

Merged and drafted releases, thank you so much.

Thank you, I learned a lot from you!


ci: empty commit to run CI on main

That Elixir test is passing now. Maybe some web resource was down temporarily.


Add 200k cap for partition result

As stated in our article on partitions, the maximum number of partitions per broker is 4k, or 200k per cluster.
Of course, we do not advise pushing the number of partitions to these limits. But any result above 200k is only a theoretical number and has no practical relevance.
We should therefore set the upper limit for the partition result to 200k.

@BenjaminBuick I think you have typo. it's 40k per broker, not 4k.


chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
9258283 -> c71ed90

terraform-ibm-modules/common-pipeline-assets
action
patch
v1.17.0 -> v1.17.4

Release Notes

terraform-ibm-modules/common-pipeline-assets (terraform-ibm-modules/common-pipeline-assets)
v1.17.4
Compare Source
Bug Fixes

remove collab check - no longer required (#523) (be1c5de)

v1.17.3
Compare Source
Bug Fixes

Debug logging (#522) (0fe31b8)

v1.17.2
Compare Source
Bug Fixes

bug with trim (60c8a95)

v1.17.1
Compare Source
Bug Fixes

add debug and trim comment (#520) (e0bb379)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.

:tada: This PR is included in version 1.11.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add error message in clusterwide stats aggregation

Catch the exception during parsing stats string by ObjectMapper to determine which instance the stats comes from.
./gradlew build && ./gradlew test

Codecov Report

Merging #1041 into master will decrease coverage by 0.03%.
The diff coverage is 55.55%.

@@             Coverage Diff             @@
##             master   #1041      +/-   ##
===========================================
- Coverage     68.33%   68.3%   -0.04%
+ Complexity     4763    4758       -5
===========================================
  Files           379     379
  Lines         30219   30223       +4
  Branches       3851    3851
===========================================
- Hits          20650   20643       -7
- Misses         8529    8533       +4
- Partials       1040    1047       +7

Impacted Files
Coverage Δ
Complexity Δ

...ithub.ambry.clustermap/HelixClusterAggregator.java
86.25% <55.55%> (-3.23%)
17 <0> (ø)

...java/com.github.ambry.store/CompactionManager.java
86.75% <0%> (-2.65%)
19% <0%> (ø)

...rc/main/java/com.github.ambry.store/BlobStore.java
83.06% <0%> (-1.62%)
69% <0%> (-2%)

.../src/main/java/com.github.ambry.store/Journal.java
90.76% <0%> (-1.54%)
24% <0%> (-1%)

.../java/com.github.ambry.router/DeleteOperation.java
92.19% <0%> (-1.42%)
47% <0%> (-1%)

...in/java/com.github.ambry.network/SocketServer.java
82.78% <0%> (-0.41%)
13% <0%> (ø)

.../main/java/com.github.ambry.store/HardDeleter.java
79.74% <0%> (-0.33%)
41% <0%> (-1%)

...in/java/com.github.ambry.store/BlobStoreStats.java
70.41% <0%> (-0.22%)
101% <0%> (ø)

...ain/java/com.github.ambry.router/PutOperation.java
89.8% <0%> (-0.2%)
81% <0%> (ø)

...m.github.ambry.clustermap/HelixClusterManager.java
93.52% <0%> (+1.12%)
33% <0%> (ø)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7341024...f6bf728. Read the comment docs.


Improvement for Robot "Get Length" with len() Function own

During my work on API endpoint validation, I needed know the length of an integer variable. It was then that I realized that the "Get Length" function couldn't count the characters in variables of types int, bool, and float. In discussions with my team, we noticed this need in several projects. Sometimes, it's necessary to validate the number of digits in an integer variable to ensure it doesn't exceed the limit of a system's business rule.
I'm submitting a Pull Request with this potential improvement. Now, when using "Get Length," it will return the number of digits in variables of types str, int, bool, and float and will no longer display the message "Could not get length of."

The idea seems to be to change Get Length so that it works with integers so that e.g. 1234 would yield 4. I don't think that's a good idea for the following reasons:

Most of the time you don't want numbers to have length. It's generally better to fail than return strange values.
You can easily convert an integer to a string first and get length from it.
Integers in Python actually have a kind of a length, but it is not at all the same as proposed here.
Getting a length as proposed is pretty ambiguous. What should be the length of 0? What about negative numbers?
Should also floats have a length?


Implement a secrets guardian

🧐 The problem
Since we're an open-source company, any contributor could accidentally commit a secret in our git repository. When that happens, we need to act quickly to prevent any bad actor from exploiting that vulnerability.
💡 What solution do I want
We could implement Gitguardian or any other tool that can monitor our secrets.
😰 What have I tried to do already
Nothing.
🍪 Further details
@victorperin suggested the following Github action:
name: GitGuardian scan

on: [push, pull_request]

jobs:
  scanning:
    name: GitGuardian scan
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v2
        with:
          fetch-depth: 0 # fetch all history so multiple commits can be scanned
      - name: GitGuardian scan
        uses: GitGuardian/gg-shield-action@master
        env:
          GITHUB_PUSH_BEFORE_SHA: ${{ github.event.before }}
          GITHUB_PUSH_BASE_SHA: ${{ github.event.base }}
          GITHUB_PULL_BASE_SHA: ${{ github.event.pull_request.base.sha }}
          GITHUB_DEFAULT_BRANCH: ${{ github.event.repository.default_branch }}
          GITGUARDIAN_API_KEY: ${{ secrets.GITGUARDIAN_API_KEY }}

Also, after creating that structure, we should consider implementing it on our other repositories as well.

Closed since we're now managing our engineering priorities on this Jira board.


Why is there a Winston Churchill quote here ?

Right now Im seeing a Wisnton Churchill quote on my FreeCodeCamp home page.
As an Indian I am very offended by this. Please do some research he is responsible for more deaths then even Hitler. He engineered the death of millions of Indians in Bengal Famine.
Please remove him and his quotes from ever coming again.

A pull-request is welcome.

Not fixed


Possible to move on after first hit?

Hi, thank you for this great package.
Would it be possible to end a search as soon as the string is found once? I am comparing a list of strings to a list of files, and I have no need to know if the string is found more than the first hit.
Thank you

Hi,
thanks for the report. I think that should be possible. I try to handle that as soon as I find the time. But right now, I can't really tell when that will be, as I am pretty busy at the moment. But you are very welcome to submit a Pull-Request :-)
Greets, Philipp

Thanks for the reply.
I found a solution by using 'fs' and 'glob' then iterating over each file, and then breaking out of the loop when a file matched the string.
Cheers

@areknow
"Thanks for the reply.
I found a solution by using 'fs' and 'glob' then iterating over each file, and then breaking out of the loop when a file matched the string.
Cheers"
Can you please share the example or sample code?
Thanks :)

@anjil I wrote the code a long time ago, so I really don't remember what my original issue was about. Here is the code: https://github.com/areknow/electron-profile/blob/master/app/js/render.js


Feature_Request Addition of Preloader and Custom Cursor

Is your feature request related to a problem? Please describe.
No
Describe Feature
Preloader appears at time of loading and disapperas at Web start.
Custom Cursor more appearence in ointer.
Demo Video/Screenshot (Mandatory )

https://github.com/Anishkagupta04/RAPIDOC-HEALTHCARE-WEBSITE-/assets/154777864/e111595d-804c-4638-a2c9-02f1f4a33bab
Are you contributing under any open-source program ?
Yes
GSSOC

@Anjaliavv51 we already have a preloader & also have a custom cursor , so I am closing this issue .hope to see more of your contributions


[html] code complete for href anchors

VSCode Version: Version: 1.30.1 (user setup)
Commit: dea8705087adb1b5e5ae1d9123278e178656186a
Date: 2018-12-18T18:12:07.165Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
OS Version: Windows_NT x64 10.0.17134

Steps to Reproduce:

Create html file and some elements with their own id like so:

Create an  tag with href like this: content
You will see no autocompletion for the href. If you reload VSCode fresh the autocompletion works for a few secs (via word autocompletion) but stops to work when VSCode has completed all startup processes.

Use-case: You have a static HTML file with a lot of elements with IDs and want to check while typing in an anchor link if that ID exists.
I tried three different autocompletion plugins, none of them could give me this functionality.
This works flawlessly in Atom, though.

Does this issue occur when all extensions are disabled?: Yes

This would be very helpful! Bump.


Improved Inspector Sub-Resource Editing

Based on ideas from @LucyLavend and @RPicster, posted in https://github.com/godotengine/godot-proposals/issues/2230

Better margins
Colors to delimit subresources better.

How it looks:

Bugsquad edit: This closes https://github.com/godotengine/godot-proposals/issues/2230.

Can the user somehow manipulate the colors? Otherwise I feel they are a bit too strong / saturated.

Can the user somehow manipulate the colors? Otherwise I feel they are a bit too strong / saturated.

In that case an editor setting should give the ability to toggle or tweak the saturation of the colors, maybe?

looks great, easy to distinguish between sub resources

Rather than rotate through the colours (16 of them it seems), why not just add editor theme settings for each level which can be modified by users? Then they can retain complete control over the theme of the editor. It doesn't have to be many.
I think having 5 or so and then looping back to the first colour if you have more than 5 would be fine: 1 > 2 > 3 > 4 > 5 > 1 > 2... etc. You would still  be able to easily distinguish each section since the repeated colours would be deeply nested and would not get confused with one another.

Seeing the feedback on Twitter and Discord, there seem to be quite a lot of people that prefer to have the resources highlighted with blue only. Because of this it might be good to have an option to turn off the automatic coloring. Another way would be to have a modifiable array of colors like @EricEzaM mentioned, so that the user can set them all to blue if preferred.

I added this small setting in the inspector dock sections (not the theme) for those with a dark heart who can't stand colors. Put it to 0 and the color goes away. I set it to 0.75 by default which imo looks best (less saturated that in the screenshot above, but less readable).

@EricEzaM Let's see how many find that to be a problem eventually and then we discuss again.

That would help a lot.

Very nice change, thank you!

I dont know if is too late, but I have this ideas based on what is presented in this PR

@alexfreyre TBH we explored a lot of options in the past too, and the colors are by far what works better. In your images it's not entirely clear what's going on in comparison.
I am a pragmatical person, so if something objectively works better at its given task, and then it's the best solution. The "consistency" arguments are subjective and thus irrelevant.

@reduz totally agree, my intention with the previous images was to show another solution. Any simple task can be time consuming if we have no alternatives. I am not trying to change the idea of this PR, it is very good, but I want to contribute some more.
With colors the problem is solved, without doubts.
What seems to me that three different colors separate three elements that are integrated.
what I wanted to do with the tones was to integrate the elements into a tonal group, not three families of different colors, although it can also be a group of analogous colors within the same family or same color with different values.
for example,
Group Environment = blue family
subgroup1 = blue,
subgroup2 = red + blue,
subgroup2 = green + blue,
then they are integrated, I think that this small detail would make any place have a visual hierarchy with unified groups and subgroups.

This was a suggestion I made on Twitter. Basically same separation by hue, however with the hue steps much smaller. I would suggest picking maybe 3 colors and linearly interpolating between them based on the level of nesting.

I like @API-Beast's "After" suggestion, but would suggest that contrast is increased on hover. This way you have something not too visually jarring by default, but when you do edit those options, you get a better contrast to make nesting much clearer (while keeping similar hues, like a typical hover effect would).

This was a suggestion I made on Twitter. Basically same separation by hue, however with the hue steps much smaller. I would suggest hand-picking three colors and linearly interpolating between them based on the level of nesting. (1. -> 2. second color for the most common nesting depths, 2. -> 3. color for deeply nested)

While I agree that it looks more stylish (apart from the colors getting basically all purplish, but that's taste), I think the contrast is much less resulting in a harder to differentiate subresources.
The idea of jumping between hues is to give a good contrast.
Also think about accesibility here, just moving along a hue give a hard time for colorblind people (and there are lot of colorblind people! Don't underestimate that)
You can upload your example image here:
https://www.color-blindness.com/coblis-color-blindness-simulator/
And you will quickly notice that the contrast is muss smaller and sometimes almost non existant.

If this chart is accurate then a transition between blue and yellow should be discernible for all types of color blindness.

If this chart is accurate then a transition between blue and yellow should be discernible for all types of color blindness.

The chart is correct. But compared to the palette that is used in the "After" image, the result is a different one.
The gradient you used in the example image goes from blue - through reddish hues - to yellow. So it includes hues that will be indistinguishable for many forms of colorblindness.
Also the hue differences are much too small.
I compiled a comparison of the first three sublevels of resources comparing the "before" to the "after" colorschemes when "emulated" with different forms of colorblindness:

As you can see, the colors on the right are not so easy to differentiate as on the right (which this color selection should be about).
It could be a solution to not move along the gradient but jump between end and start for each level to give maximum contrast between the subresource levels.

Like this maybe... (Warning, super quick mockup 😉 )
I'm not doing a crusade here, I most importantly think, the user should have some kind of influence about the colors (Starting hue, saturation or controlling the colors directly)

Ok, I did some change  and I will leave it at this, with a softer gradient but enough to be able to tell between sections.
Keep in mind this is a very extreme case of nesting, you won't get into so much normally, so imo this is good enough.

Also since usability has considerably improved now, I made it possible again to edit materials inline.

One question, will this change als be made available for the Godot 3 branch?

Thanks!

One question, will this change als be made available for the Godot 3 branch?

This could possibly be backported to the 3.2 branch if a contributor is motivated. I doubt @reduz would do it himself as he prefers (and should) focus on getting 4.0 feature complete instead.
That being said, this kind of change is usually iterative and we might want to wait for things to be fine-tuned in the master branch before considering a backport.

I use subresources workflow quite often, if these changes are not too different from the 3.2 branch, I think I'd be interested in backporting this to 3.2 myself, unless there's someone else who'd be willing to pick this up/have more experience in developing the editor UI, I'd be willing to test out the PR at least.

That being said, this kind of change is usually iterative and we might want to wait for things to be fine-tuned in the master branch before considering a backport.

See #45940 for 3.2.
I'd say that most people actually use 3.2 currently, this also applies to a lot of engine contributors, and there are people who cannot even properly use/launch master branch on their machines, so it makes sense to me to merge #45940 now to get more feedback than waiting for months to get master stabilized.

I think the point of waiting is to make sure we don't run into a change later on that would be breaking in 3.2 and thus impossible to fix without releasing at least 3.3, which is not on the radar yet. This won't be merged into 3.2.4 anyway, since it's in RCs now, so there is no need to rush with a backport.

According to what I've seen, usability PRs usually get merged regardless of release status. See #45902 for example which was merged just yesterday.
Unlike #45902, #45940 is mostly cosmetic and does not introduce any compatibility breakage (it's internal change).

One question, will this change als be made available for the Godot 3 branch?

This could possibly be backported to the 3.2 branch if a contributor is motivated. I doubt @reduz would do it himself as he prefers (and should) focus on getting 4.0 feature complete instead.
That being said, this kind of change is usually iterative and we might want to wait for things to be fine-tuned in the master branch before considering a backport.

It may be good to use 3.x as testing ground of that harmless feature, considering how long it will take for 4 to be released (and "feature preview" approaches seem to give good results for early tests on other popular tools).

There is any way to disable this?

There is any way to disable this?

How do you imagine it should look, when disabled?

@yosoyfreeman you can try to set docks/property_editor/subresource_hue_tint editor settings to 0.0.

@yosoyfreeman you can try to set docks/property_editor/subresource_hue_tint editor settings to 0.0.

Thanks you! This is a nice update anyway


Add a typescript version of an existing component

Add a typescript version of an existing component in the same folder.
Since there are multiple components already, multiple individuals can participate in it and take any component you would like to convert.

Yes @Yugal41735 we would love to have your contribution. The goal is to have the work done irrespective of who you are or how much you know. 😊😊

@Yugal41735 you can pick any component you want.


feat(static/get-cli): Download the CLI from GitHub

I guess users can choose either homebrew or direct download.

Sounds good!


Add NTP and use our new "boot2docker" vendor pool!

wow, we get our own!!
LGTM

cc @ehazlett

LGTM!!

:heart:


refactor: make fundingStatus optional in the ChannelResult

Currently the fundingStatus value is sometimes inaccurate. For example, it's possible to get 'Uncategorized' or 'ReadyToFund' when the channel is funded, but the funding hasn't been fetched from the db.
Fixing this would require always querying the db for funding, which might not be desirable for performance reasons. Instead, consumers will now receive fundingStatus: undefined if it hasn't be fetched.

It doesn't look like this will cause any issues with the graph, as the only way that code uses the fundingStatus is to check that it !== 'Defunded' - a property that won't change: https://github.com/statechannels/the-graph/search?q=fundingStatus

It doesn't look like this will cause any issues with the graph, as the only way that code uses the fundingStatus is to check that it !== 'Defunded' - a property that won't change: https://github.com/statechannels/the-graph/search?q=fundingStatus

This may cause an issue with this PR https://github.com/statechannels/the-graph/pull/480/files#diff-d5feac8493a10695a08de9574f4f0a695585f457b849e4ebe0cc05ffe3ea21b8R514

This may cause an issue with this PR https://github.com/statechannels/the-graph/pull/480/files#diff-d5feac8493a10695a08de9574f4f0a695585f457b849e4ebe0cc05ffe3ea21b8R514

I think it should be fine on the line you highlighted, as if fundingStatus == 'Funded' currently, that won't change.

I think it should be fine on the line you highlighted, as if fundingStatus == 'Funded' currently, that won't change.


[automation] Add upstream information for automation

By merging this separately from #322, we can work on automation engineering and testing the flow much more easily. This will also have the side-effect of keeping this information updated, since we can mandate this as part of contributions.

Laravel: https://github.com/laravel/framework/tags


2777: add copy changes to the allocations page

Context
Card
Changes proposed in this pull request
Guidance to review

 Update 'Allocations' guidance page.


[BUG] PopRootAndTick in ViewStackServiceBase leaves behind the wrong viewmodel

Describe the bug
If you look at PopRootAndTick in ViewStackServiceBase found here, https://github.com/reactiveui/Sextant/blob/master/src/Sextant/Navigation/ViewStackServiceBase.cs#L218 , I believe the code is returning a stack with the wrong viewmodel in it.
The purpose of this method is to clean up the stack after navigation to the root has occurred.  When PopToRootPage is called by a developer, an observable on the View (NavigationView) is sent a signal, then the method in question is called via a Do() following the observable.
The stackSubject.OnNext() should just update the stack by passing in a list with only the root viewmodel in it.  But it doesn't.   This line is the problem:
poppedStack = stack.RemoveRange(stack.IndexOf(stack[0]), stack.Count - 1)

To me, that looks like it takes the stack, removes everything but the last item in the list, and returns that modified list.
Second, I think there might be a problem with the reactive stuff:
stackSubject.Take(stackSubject.Value.Count - 1)

This doesn't make sense to me.  The stackSubject is an observable of a list of viewmodels, not an observable of viewmodel.  We just want to grab the latest list Take(1)... and even this is not necessary since we could just grab stackSubject.Value.
Ultimately, the problem is on Xamarin.Forms Android, you'll never see the consequences of this bug because the system doesn't rely on the first item in the stack after it's been placed during initialization.
Steps To Reproduce
I made a branch on my repo that sticks an extra button Home to display the current viewmodel type.  If you navigate forward a few times (red view), then pop to root, the top of the stack will contain a RedViewModel type instead of HomeViewModel type.
https://github.com/limefrogyank/Sextant/tree/PopRootAndTick_Bug
Expected behavior
Should contain HomeViewModel type.
Screenshots
Initial TopPage():

After navigating to red page a few times in a row, then hitting pop to root:

Environment

OS:       Windows10
Device:   Android Emulator
Version:
Working Version:

Additional context

@limefrogyank Thanks for reporting this.  I had some other issues that I resolved on Xamarin.iOS around PopToRoot not too long ago.  I will look into this and see if we can find a resolution.
The thought behind removing is to try and leave a ViewModel on the stack.
Is this really specific to Xamarin.Forms Android?  I will try and reproduce it on iOS to be safe, as that seems an odd side effect.

I don’t have easy access to testing on iOS so I don’t know.
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: Rodney Littles II<EMAIL_ADDRESS>Sent: Friday, January 3, 2020 11:53:45 AM
To: reactiveui/Sextant<EMAIL_ADDRESS>Cc: Lee McPherson<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [reactiveui/Sextant] [BUG] PopRootAndTick in ViewStackServiceBase leaves behind the wrong viewmodel (#189)
@limefrogyankhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flimefrogyank&data=02|01||24dca41b25564e02f27b08d79086a4ec|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637136780269622218&sdata=UN2xHdUCZw8hVO3XYqutAoNQjOP%2BI3HXKS0BaRvldpI%3D&reserved=0 Thanks for reporting this. I had some other issues that I resolved on Xamarin.iOS around PopToRoot not too long ago. I will look into this and see if we can find a resolution.
The thought behind removing is to try and leave a ViewModel on the stack.
Is this really specific to Xamarin.Forms Android? I will try and reproduce it on iOS to be safe, as that seems an odd side effect.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Freactiveui%2FSextant%2Fissues%2F189%3Femail_source%3Dnotifications%26email_token%3DAB3VQSBQBV7Q6EDK35M3JNLQ36JUTA5CNFSM4KCQH2E2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIB6HJY%23issuecomment-570680231&data=02|01||24dca41b25564e02f27b08d79086a4ec|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637136780269632224&sdata=AIUM84iQEsQNNVltcshIGPA22wQJH4U7LspYkixZQu8%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAB3VQSAEGEAJZEGS2XQZYUDQ36JUTANCNFSM4KCQH2EQ&data=02|01||24dca41b25564e02f27b08d79086a4ec|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637136780269642235&sdata=Ls9pX63eXGh2H2OGkYcbZoDlMVYuVMkVJJRaPrJr2BM%3D&reserved=0.

@limefrogyank So I am trying to reproduce this, but no matter how many Red Pages I push on iOS, I don't see the problem.  I have a branch GH189 where I am reproducing this.  Can you verify that this code still produces an error on your side?  I am moving to test Android now, just want to be sure my reproduction is correct.

Looks correct to me.
You’re right, I can’t reproduce it either.  I need to compare yours to mine and see what happened.
Lee
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10
From: Rodney Littles<EMAIL_ADDRESS>Sent: Sunday, January 5, 2020 12:17 PM
To<EMAIL_ADDRESS>Cc: Lee<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [reactiveui/Sextant] [BUG] PopRootAndTick in ViewStackServiceBase leaves behind the wrong viewmodel (#189)
@limefrogyankhttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flimefrogyank&data=02|01||3a997c66d482411ceefa08d7921c4b2a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637138522522432807&sdata=2zvUflVyu46WHxgEy8QpFY7geNmnNJDOEaEEFT5P%2BZU%3D&reserved=0 So I am trying to reproduce this, but no matter how many Red Pages I push on iOS, I don't see the problem. I have a branch GH189https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Freactiveui%2FSextant%2Ftree%2Fgh189&data=02|01||3a997c66d482411ceefa08d7921c4b2a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637138522522442811&sdata=LJG3%2Fmf%2FcTUXVvVXoQSQOKT2laI%2Bkm6NDBWl478rhRc%3D&reserved=0 where I am reproducing this. Can you verify that this code still produces an error on your side? I am moving to test Android now, just want to be sure my reproduction is correct.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Freactiveui%2FSextant%2Fissues%2F189%3Femail_source%3Dnotifications%26email_token%3DAB3VQSASRIXE7FHXMRSPCJ3Q4I55TA5CNFSM4KCQH2E2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEID6SJY%23issuecomment-570943783&data=02|01||3a997c66d482411ceefa08d7921c4b2a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637138522522442811&sdata=c%2BPUv6XNSisjtaU219DmtQ6sv%2FSrSvbFfJMmYOG22ZA%3D&reserved=0, or unsubscribehttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAB3VQSFLWAQVICAIAY2Z2N3Q4I55TANCNFSM4KCQH2EQ&data=02|01||3a997c66d482411ceefa08d7921c4b2a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637138522522452819&sdata=QGs9ONSvtJDkriK3ixWt3Ki%2B1FjUms4OeDsH0n2GUlA%3D&reserved=0.

Oh, you've got the changes I made already put into your branch.  The original code for PopRootAndTick was this:
IImmutableList<T> poppedStack = ImmutableList<T>.Empty;

            if (stackSubject?.Value == null || !stackSubject.Value.Any())
            {
                throw new InvalidOperationException("Stack is empty.");
            }

            stackSubject
                .Take(stackSubject.Value.Count - 1)
                .Where(stack => stack != null)
                .Subscribe(stack => poppedStack = stack.RemoveRange(stack.IndexOf(stack[0]), stack.Count - 1));

            stackSubject.OnNext(poppedStack);

That means your code somehow made it to the master branch, as my branch is cut from the most recent master.

@limefrogyank Can you verify master is fixed?  Then I would argue we can close this and attach it to the PR that solved the problem.

This works fine for me.  Sorry to slip that in unnoticed.
Fixed with https://github.com/reactiveui/Sextant/commit/dc23331447796cd5b209c185ebcee1492b78a0d1
Right?

Yes.  No worries about it.  It was a big PR with a lot of files changed.  Appreciate the contribution!


Misleading wording in fused multiply-add description

In the F extension section of the User-Level ISA manual, the four fused multiply-add instructions (FMADD.S, FMSUB.S, FNMADD.S, and FNMSUB.S) are described as follows:

Fused multiply-add instructions multiply the values in rs1 and rs2, optionally negate the product, then add or subtract the value in rs3, writing the final result to rd.

However, if you look at the behavior implied by the FMADD riscv-tests repo (https://github.com/riscv/riscv-tests/blob/master/isa/rv64uf/fmadd.S), the description doesn't accurately define the FNMADD and FNMSUB instructions. The optional N character doesn't "optionally negate the product" as the text says (where the product is rs1 times rs2), it optionally negates the output of the fused multiply-add/subtract.
The relevant code can be found here: https://github.com/riscv/riscv-isa-manual/blob/master/src/f.tex#L447
I would suggest that we change this sentence to something like this:

Fused multiply-add instructions multiply the values in rs1 and rs2, add or subtract the value in rs3, optionally negate the sum or difference, then write the final result to rd.

On a slightly separate note, I think that adding some parentheses to the FMA equations after this sentence might also make things a bit clearer. While the equations are correct with regard to order-of-operations (multiply before add/subtract), adding some parentheses around the multiply expressions might make things a bit clearer. Furthermore, factoring out the negation for the FNMADD and FNMSUB expressions might clarify their behavior as well (since their equations will then be identical to FMADD and FMSUB, just with a negation in front). For example, the original text says:

FNMADD.S computes -rs1*rs2-rs3

We might instead write:

FNMADD.S computes -((rs1*rs2)+rs3)

Hopefully this isn't overly-pedantic, but when I was reading through this section, the combination of the "optionally negate the product" comment and the unfactored equations threw me for a bit of a loop. Just want to make this clearer for whoever reads it next.

This is a duplicate of https://github.com/riscv/riscv-isa-manual/issues/103
Yes, it’s misleading, but as discussed in the other issue, the proposed change is also misleading. I suggest continuing the discussion on the aforementioned issue if you have other ideas on how to clear things up.

Ah, sorry about that. Failed to find that issue when I searched before. I'll move discussion to there.


[stable/nginx-ingress] default backend deployment and controller sharing same selector causes issue

Describe the bug
selector of default-backend and controller are the same.
with version 1.23.7
`$ helm template -n dev-nginx-ingress -x templates/controller-deployment.yaml . | yq .spec.selector
{
"matchLabels": {
"app": "nginx-ingress",
"release": "dev-nginx-ingress"
}
}
$ helm template -n dev-nginx-ingress -x templates/default-backend-deployment.yaml . | yq .spec.selector
{
"matchLabels": {
"app": "nginx-ingress",
"release": "dev-nginx-ingress"
}
}
`
This causes hpa to fail. Throwing error 'failed to get cpu utilization: missing request for cpu' (Tho this is a bug of hpa https://github.com/kubernetes/kubernetes/issues/79365)
Adding the 'component' label back to deployments selector fixes hpa.
Not very sure if this is something we should 'fix' in the chart or should just wait for the hpa bug to be fixed.
Version of Helm and Kubernetes:
kubernetes version: v1.14.3
helm version: v2.14.2
Which chart:
nginx-ingress
What happened:
hpa fails to get metrics as it relies only on selector of the deployment
What you expected to happen:
hpa works correctly
How to reproduce it (as minimally and precisely as possible):
a normal deployment of the chart
Anything else we need to know:
related to: https://github.com/kubernetes/kubernetes/issues/79365

@tkozma I might be missing something obvious here, but how would that patch help?
It will apply an extra label (component: controller) on the controller pods.
However, the spec.selector.matchLabels on both controller and backend deployments are unchanged, they are still only specifying app and release - no component.
(And this is what specifies which pods the deployment will point to)
There's no way via helm values.yml to add selector.matchLabels to either controller or backend

@soumeng09 you are absolutley right, I mixed up the patch command

Hi guys, is there no option in the chart to update this? going through all clusters manually patching is an options but it would be nice if this would be fixed in the chart itself. i have upgraded my chart to latest stable version and still see the hpa cannot get the metrics because of this.

you can also set resources for the default backend but I do not think this is a proper fix as it will mixed up HPA calculations.

Adding my voice that this is still an issue many months after it was first reported.


bot is not responding.

I have deployed a bot on azure using this example.
https://github.com/Microsoft/BotBuilder-Samples/tree/main/samples/csharp_dotnetcore/24.bot-authentication-msgraph
and to deploy the bot service, AD app, App service and their relevent configuration, I followed this https://learn.microsoft.com/en-us/azure/bot-service/bot-builder-authentication?view=azure-bot-service-4.0&tabs=userassigned%2Caadv2%2Ccsharp
but after deploying my bot is not responding. i am sending Hi but not getting response . here is screen shot of channels page

@ajeetchoudhary

The bot works successfully when ran locally?
Does it work locally when using the appid, apppassword and (oauth) connectionName?
What language is the bot written in?
What version of the SDK?


Use py 3.9

PiPPy requires 3.9, fixes more test failures

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Add support for Array

The following
#![feature(register_tool)]
#![register_tool(flux)]

pub fn read_u16() -> u16 {
    let bytes: [u8; 2] = [10, 20];
    u16::from_le_bytes(bytes)
}

currently fails with
unsupported aggregate kind: `Array(u8)`

I will take a look at this.

Perhaps related-
const BASE_PRIMES: [u32; 11] = [2, 3, 5, 7, 11, 13, 17, 19, 23, 29, 31];

fails with
error[FLUX]: invalid constant

@nilehmann here's some more fun array stuff, that we might look at in due course... The following code
#![feature(register_tool)]
#![register_tool(flux)]

pub fn first_byte(v: u16) -> u8 {
  let bytes: [u8; 2] = v.to_le_bytes();
  bytes[0]
}

fails with
error[flux]: unsupported rvalue: `Len(_2)`
 --> flux-tests/tests/pos/surface/issue-len.rs:6:3
  |
6 |   bytes[0]
  |   ^^^^^^^^

The source it comes from is this:
    pub fn write_u16(&mut self, start: usize, v: u16) {
        let bytes: [u8; 2] = v.to_le_bytes();

        // do stuff with bytes[0]
        // do stuff with bytes[1]

    }

which seems to do some fancy const stuff which we can probably ignore ...

The original issue was addressed in https://github.com/liquid-rust/flux/pull/183. I'm closing this in favor of https://github.com/liquid-rust/flux/issues/185 and https://github.com/liquid-rust/flux/issues/184 which capture the rest of the issues discussed here.


unable to install with amdgpu-install in centos 8 stream

I cannot install amdgpu driver with amdgpu-install in centos 8 stream. the installer shows it fails to download the amdgpu repository.
I find that the amdgpu repo definition file has been using an environment variable amdgpudistro, which the installer can not properly define in centos 8 stream.

Hi @siyy123
Thanks for reaching out.
Can you please share the exact steps(step by step) to reproduce the problem, so that I will try locally here and will update with the resolution. Thank you.


libparquet.1.0.0.dylib does not exist

I recently got the build for source working using the instructions from here: https://arrow.apache.org/docs/python/development.html#development
I am able to compile the first time, but when I try and recompile I get an error that libparquet.1.0.0.dylib doesn't exist (there is libparquet.1.dylib and a later version).  I also reproed the recompile error on CentOS with both PIP and conda installs.  I am able to solve the issue using a symlink.  Do you think this is an issue with my system/setup or is an issue I should create on JIRA?
(pyarrow) aandrade54-mac:python aandrade$ python setup.py build_ext --build-type=$ARROW_BUILD_TYPE \
>        --with-parquet --with-plasma --bundle-arrow-cpp bdist_wheel
running build_ext
creating build
creating build/temp.macosx-10.6-x86_64-2.7
-- Runnning cmake for pyarrow
cmake  -DPYTHON_EXECUTABLE=/Users/aandrade/arrow-dev/repos/pyarrow/bin/python  -DPYARROW_BUILD_PARQUET=on -DPYARROW_BUILD_PLASMA=on -DPYARROW_BUNDLE_ARROW_CPP=ON -DCMAKE_BUILD_TYPE=release /Users/aandrade/arrow-dev/repos/arrow/python
-- The C compiler identification is AppleClang <IP_ADDRESS>00038
-- The CXX compiler identification is AppleClang <IP_ADDRESS>00038
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
INFOCompiler command: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
INFOCompiler version: Apple LLVM version 9.0.0 (clang-900.0.38)
Target: x86_64-apple-darwin16.7.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

INFOCompiler id: Clang
Selected compiler clang 4.0.0svn
-- Performing Test CXX_SUPPORTS_SSE3
-- Performing Test CXX_SUPPORTS_SSE3 - Success
-- Performing Test CXX_SUPPORTS_ALTIVEC
-- Performing Test CXX_SUPPORTS_ALTIVEC - Failed
Configured for RELEASE build (set with cmake -DCMAKE_BUILD_TYPE={release,debug,...})
-- Build Type: RELEASE
-- Build output directory: /Users/aandrade/arrow-dev/repos/arrow/python/build/temp.macosx-10.6-x86_64-2.7/release/
-- Found PythonInterp: /Users/aandrade/arrow-dev/repos/pyarrow/bin/python (found version "2.7.14")
-- Found PythonLibs: /Users/aandrade/anaconda2/lib/libpython2.7.dylib
-- Found NumPy: version "1.13.3" /Users/aandrade/arrow-dev/repos/pyarrow/lib/python2.7/site-packages/numpy/core/include
-- Found Cython: /Users/aandrade/arrow-dev/repos/pyarrow/bin/cython
-- Found PkgConfig: /usr/local/bin/pkg-config (found version "0.29.2")
-- Checking for module 'arrow'
--   Found arrow, version 0.8.0-SNAPSHOT
-- Arrow ABI version: 0.0.0
-- Arrow SO version: 0
-- Found the Arrow core library: /Users/aandrade/arrow-dev/repos/dist/lib/libarrow.dylib
-- Found the Arrow Python library: /Users/aandrade/arrow-dev/repos/dist/lib/libarrow_python.dylib
Added shared library dependency arrow: /Users/aandrade/arrow-dev/repos/dist/lib/libarrow.dylib
Added shared library dependency arrow_python: /Users/aandrade/arrow-dev/repos/dist/lib/libarrow_python.dylib
-- Found the Parquet library: /Users/aandrade/arrow-dev/repos/dist/lib/libparquet.dylib
CMake Error: File /Users/aandrade/arrow-dev/repos/dist/lib/libparquet.1.0.0.dylib does not exist.
CMake Error at CMakeLists.txt:207 (configure_file):
  configure_file Problem configuring file
Call Stack (most recent call first):
  CMakeLists.txt:290 (bundle_arrow_lib)

Added shared library dependency parquet: /Users/aandrade/arrow-dev/repos/dist/lib/libparquet.dylib
-- Checking for module 'plasma'
--   Found plasma, version
-- Plasma ABI version: 0.0.0
-- Plasma SO version: 0
-- Found the Plasma core library: /Users/aandrade/arrow-dev/repos/dist/lib/libplasma.dylib
-- Found Plasma executable: /Users/aandrade/arrow-dev/repos/dist/bin/plasma_store
Added shared library dependency libplasma: /Users/aandrade/arrow-dev/repos/dist/lib/libplasma.dylib
-- Configuring incomplete, errors occurred!
See also "/Users/aandrade/arrow-dev/repos/arrow/python/build/temp.macosx-10.6-x86_64-2.7/CMakeFiles/CMakeOutput.log".
See also "/Users/aandrade/arrow-dev/repos/arrow/python/build/temp.macosx-10.6-x86_64-2.7/CMakeFiles/CMakeError.log".
error: command 'cmake' failed with exit status 1

The solution here was to create a sym link:
ln -s /Users/aandrade/arrow-dev/repos/dist/lib/libparquet.1.dylib /Users/aandrade/arrow-dev/repos/dist/lib/libparquet.1.0.0.dylib

The problem is that we have hard-coded the version in the case one sets PARQUET_HOME.
We normally use the option --bundle-arrow-cpp only for builds that discover Arrow C++ and Parquet C++ via PKG_CONFIG_PATH and not using the *_HOME variables. If you want to build wheels that can be passed around, I would advise you to use the pkg-config based discovery. Otherwise, if you only want a local development version, omit --bundle-arrow-cpp.

Opened https://issues.apache.org/jira/browse/ARROW-1856 about adding auto-detection for the ABI version in the case that PARQUET_HOME is set.

This is helpful!  Should we create a PR to explain --bundle-arrow-cpp and the other configs?  I don't see anywhere in the documentation on what the configs mean (but I only did a quick search)

Yes, we should somewhere document these options, a PR is welcome. --bundle-arrow-cpp will include all libraries (Arrow C++, Parquet C++) into the wheel so it is self-contained.

Cool, I have an open PR with documentation fixes, I'll include this.

https://github.com/apache/arrow/pull/1356


Adding dependency relationship to target is removing its actions

The PartitionMapWriter targets in Haiku have no actions with the conditional (on architecture) header dependency they have. Without the dependency, they do have actions.

The issue seems to be with the specification of the source; putting a different source works fine.

There's not much to go on tracking this down; somehow something about the MBR.h breaks its parent.

This specific issue was caused by the source file using Depends instead of Includes with the header file. I still don't understand why Jam accepted the input, but it might be chalked up to a bug.


Default value for wrap_width should be -1.0 not 0.0

Quick fix for default parameters. Default value for wrap_width  sould be -1.0 instead of 0.0 !

Thanks!

Released as 1.3.0:

release notes
available distributions


Query event in Transaction should be proxied to the main client

As discussed with @tgriesser in #855 the query event is no longer triggered onto the main client when in a transaction. It was simply a miss during the transaction overhaul, according to tgriessers's comments.
Example code:
dbClient.on('query', function(obj) {
	console.log('onQuery'); //Works in knex < 8.0.0, fails in >= 8.0.0
	return obj;
});

dbClient.transaction(function(tr) {
	return tr.raw('SELECT version()').then(tr.commit).catch(tr.rollback);
}).then(_.noop).catch(_.noop);

There may be better ways of fixing this, I don't know.

Hi @wubzz. That looks reasonable to me, and looks like it closes #855.
I've made a rule not to merge anything without tests as I am also not that familiarized with the codebase. So please add a couple of tests for these events and I'll merge it in.

@rhys-vdw Truthfully having issues installing dependecies for knex on my windows platform, and can't get it to work. Seems to primarily be mariasql where I have issues..
I commited a test hoping that I added it in the right place (also lack experience with the project structure/codebase), and hoping CI will pull through.
Pretty straight-forward test, tho.


Why have Unknown error while getting Access Token: 504 GATEWAY_TIMEOUT

same sir

This is a duplicate of this issue
https://github.com/shamhi/HamsterKombatBot/issues/338

Problem solution:

Log in to this telegram account from any device;
Close all sessions with the Pyrogram header
Recreate the session inside your bot (instead of a token, use a phone number in international format)
Disable proxy or use SOCKS5 instead of HTTP
Synchronize the system time on your computer

See also:

https://github.com/shamhi/HamsterKombatBot/issues/309
https://github.com/shamhi/HamsterKombatBot/issues/38
https://github.com/shamhi/HamsterKombatBot/issues/58
https://github.com/shamhi/HamsterKombatBot/issues/86
https://github.com/shamhi/HamsterKombatBot/issues/137
https://github.com/shamhi/HamsterKombatBot/issues/263


Single line inline snapshots conflict with babel/quotes in eslint

When I have an assertion like:
 expect(warningMessages[0]).toMatchInlineSnapshot(
        `"Could not connect to the HTTP cache. Original error: HTTP error: 502"`,
);

eslint will report this issue in some setups:
Strings must use singlequote. (babel/quotes)
Lint code: ESLINT
Lint name: babel/quotes

This is not ideal. Could we change the snapshot inliner to use single-quotes if the result is only a single line?

We use
    "quotes": [
      "error",
      "single",
      { "avoidEscape": true, "allowTemplateLiterals": false }
    ]

At work to work around it. Changing quotation impacts escaping and such, but maybe not an issue?


Injury debuffs do not take max health into account

Currently, the mod assumes the player has 10 hearts when it inflicts health-related debuffs. However, some mods (or vanilla commands) modify the maximum amount of hearts a player has, which leads to annoyances like being crippled at all time. I suggest that instead of checking for a hardcoded health amount, you check for a fraction of the maximum health.

I will do this, do you need it on 1.11.2 or is just 1.12 fine?

1.12 is all I need :)

cool :D

If you need it know it's here http://ci.blamejared.com/job/BetterWithMods/19/


feat: update rose-pine configuration options

The rose-pine configurations have updated in new versions. I've attempted to test the config locally but I'm countering the following error:
   error: Module for rose-pine is broken: Please remove the 'enable' options. This is added by 'mkLuaPlugin'

The new configuration has an enable option

Thanks for your PR. The problem is that every plugin has an enable option, which can be used to enable or disable the whole plugin. Unfortunately, the rose-pine theme seems to define an enable option as well. That results in a name clash, and that's the error you encounter.
I suggest renaming the option?
I see the option to rename them to enable_terminal, enable_legacy_highlights, and enable_migrations, or maybe just remove the enable and move the three options to the main level.
I know any inconsistency with the original options are annoying, but I don't see another option here

What will renaming them to enable_terminal, enable_legacy_highlights, and enable_migrations look like in the final config? Does the underscore convert the option back in to a table? For example does enable_terminal equal enable = {terminal = "value" }?

No, that's the point. Because enable is already used to enable the plugin, you can't use it a second time for another option.
The error message is not a result of a bug; it's the result of a sanity check in NixNeovim.


Graylog stuck at accepted stage with the new arm64 image

I have created a compose file for a stack (currently for single node).
version: "3.9"
services:

       mongodb:
          image: mongo:latest
          volumes:
            - mongo_data:/data/db
          environment:
            - MONGO_INITDB_ROOT_USERNAME=*********
            - MONGO_INITDB_ROOT_PASSWORD=*********
            - MONGO_INITDB_DATABASE=graylog.logs
          ports:
            - "27017:27017"
          deploy:
           replicas: 1
           restart_policy:
                condition: on-failure
          networks:
            - graylog
       elasticsearch:
image: docker.elastic.co/elasticsearch/elasticsearch-oss:7.10.2
          environment:
            - http.host=<IP_ADDRESS>
            - transport.host=localhost
            - network.host=<IP_ADDRESS>
            - "ES_JAVA_OPTS=-Xms64m -Xmx64m"
          volumes:
            - es_data:/usr/share/elasticsearch/data
          ulimits:
           nofile:
                soft: 65536
                hard: 65536
          deploy:
           replicas: 1
           restart_policy:
                condition: on-failure
          ports:
            - "9200:9200"
          networks:
            - graylog
graylog:
          image: graylog/graylog:4.1-arm64
          volumes:
            - graylog_data:/usr/share/graylog/data
            - /etc/graylog/server:/etc/graylog/server
          environment:
            - GRAYLOG_PASSWORD_SECRET=****************
            - GRAYLOG_ROOT_PASSWORD_SHA2=**********
            - GRAYLOG_ROOT_USERNAME=*********
            - GRAYLOG_HTTP_EXTERNAL_URI=http://<IP_ADDRESS>:9000/
            -<EMAIL_ADDRESS>            - GRAYLOG_MONGODB_MAX_CONNECTIONS=1000
            - GRAYLOG_ELASTICSEARCH_VERSION=7
          entrypoint: /usr/bin/tini -- wait-for-it elasticsearch:9200 --  /docker-entrypoint.sh
          ports:
           # Graylog web interface and REST API
            - 9000:9000
           # Syslog TCP
            - 1514:1514
           # Syslog UDP
            - 1514:1514/udp
           # GELF TCP
            - 12201:12201
           # GELF UDP
            - 12201:12201/udp
          networks:
            - graylog
networks:
  graylog:
volumes:
  mongo_data:
    driver: local
  es_data:
    driver: local
  graylog_data:
    driver: local

After deploying the stack the graylog service is stuck at accepted state. Tried a lot of work around but nothing seems to work. Nothing appears in logs too.Can you please look into it

Have posted my query on Graylog community site- https://community.graylog.org/t/graylog-service-stuck-at-accepted-stage-with-the-new-arm64-image/21164


Gitlab exposes target_url only for external builds

Describe the bug
I'm unable to use the deploy preview feature with Gitlab as a backend. My setup makes use of environments to tell to Gitlab the preview URL:

environment:
    name: review/$CI_COMMIT_REF_NAME
    url: https://$CI_ENVIRONMENT_SLUG.preview.mywebsite.tld
    on_stop: stop_review_app

The Netlify CMS Gitlab backend fetches the target_url information from the Gitlab Commit status API endpoint but the returned value for the target_url property stays null in my setup, and therefore Netlify CMS only provides a dead link.
If I understand the Gitlab source correctly, this gets set only through 3rd-party integration.
It gets really hard to get environment information for a specific MR through the API. Gitlab internally uses /<user>/<repo>/-/merge_requests/<iid>/ci_environments_status, but there doesn't seem to be a public equivalent.
Applicable Versions:

Netlify CMS version: 2.10.49
Git provider: Gitlab
OS: Ubuntu
Browser version: Firefox 76
Node.JS version: 14
Gitlab version: 13.0.3

CMS configuration
backend:
  name: gitlab
  repo: <me/my_repo>
  auth_type: implicit
  app_id: <redacted>
  api_root: https://<gitlab.host>/api/v4
  base_url: https://<gitlab.host>
  auth_endpoint: oauth/authorize
  branch: master # Branch to update (optional; defaults to master)

local_backend: true
publish_mode: editorial_workflow

media_folder: "/static/uploads"
public_folder: ""

collections:
  - name: "posts"
    label: "Posts"
    folder: "posts"
    path: "{{year}}/{{month}}/{{slug}}"
    media_folder: "{{media_folder}}"
    create: true
    preview_path: "{{year}}/{{month}}/{{slug}}"
    fields:
      - { label: "Title", name: "title", widget: "string" }
      - {
          label: "Publish Date",
          name: "date",
          widget: "date",
          dateFormat: "DD/MM/YYYY",
        }
      - label: "Tags"
        name: "tags"
        widget: "list"
      - label: "Featured Image"
        name: "thumbnail"
        widget: "image"
        required: false
        media_library:
          config:
            multiple: false
      - { label: "Body", name: "body", widget: "markdown" }

Hi @tcitworld, I'm not sure I understand the bug.
It's up to the CI service/build process to set the commit status with the preview URL (target_url).
As long as you pass a token with relevant permissions you should be able to add a commit status via the API https://docs.gitlab.com/ee/api/commits.html#post-the-build-status-to-a-commit

Gitlab CI already sets a status on the commit (with "status": "success" among other things), but doesn't include the target_url information. I may be able to POST another commit status containing the information through API from inside Gitlab CI, but it definitely feels like it's not the correct way to to this.
I found this issue that says that setting the Commit Status "was intended to only be used with external CI services".
Do you want me to open an issue on Gitlab's tracker to ask them what they think about it?

Hi @tcitworld, you could contact GitLab about setting target_url in their CI, but I think it might be better to have two different statues - the default one set by GitLab CI and another for the deploy preview.
You can see an example in a CircleCI job here (though with GitHub):
https://github.com/erezrokah/gatsby-netlify-cms-aws/blob/5e7c9197d40797a73cf1393fbf95c4112b68de88/.circleci/config.yml#L142
https://github.com/erezrokah/gatsby-netlify-cms-aws/blob/5e7c9197d40797a73cf1393fbf95c4112b68de88/.circleci/config.yml#L164
Then it would make sense to do it yourself via the commit status API (I would consider that as external since it is not built in into the GitLab CI platform).
Am I making sense here?

Closing as this is not a CMS issue

Hello @tcitworld @erezrokah
I have encountered the same issue with gitlab and target_url and this configuration works for me (just add 2 stages pre and after my pages deploy and set appropriate statuses in them):
pre-deploy:
  stage: pre-deploy
  environment:
    name: demo
  script:
    - 'curl --verbose --request POST --header "PRIVATE-TOKEN: ${API_PRIVATE_TOKEN}" "${CI_API_V4_URL}/projects/${CI_PROJECT_NAMESPACE}%2F${CI_PROJECT_NAME}/statuses/$CI_COMMIT_SHA?state=pending&context=pages:deploy&target_url=${CI_PAGES_URL}"'
  only:
    - /^cms\/.*$/

after-deploy:
  stage: after-deploy
  environment:
    name: demo
  script:
    - 'curl --verbose --request POST --header "PRIVATE-TOKEN: ${API_PRIVATE_TOKEN}" "${CI_API_V4_URL}/projects/${CI_PROJECT_NAMESPACE}%2F${CI_PROJECT_NAME}/statuses/$CI_COMMIT_SHA?state=success&context=pages:deploy&target_url=${CI_PAGES_URL}"'
  only:
    - /^cms\/.*$/


Add color parameters to WriteFile

Would this be possible?

You can change the QR Code color by setting the ForegroundColor/BackgroundColor (by default these are color.Black and color.White respectively):
https://godoc.org/github.com/skip2/go-qrcode#QRCode

Ah thanks, for some reason I thought this would take a lot more effort. Example for someone with the same problem as me in the future:
	qr, err := qrcode.New("https://example.org", qrcode.Medium)
	if err != nil {
		log.Fatal(err)
	}

	qr.BackgroundColor = color.black
	qr.ForegroundColor = color.White

	qr.WriteFile(256, "./qrcode.png")
}

Though i still think something like the following would be nice to have:
err := qrcode.WriteFileColor("https://example.org", qrcode.Medium, 256, color.White, color.Black "qr.png")
``

Added in https://github.com/skip2/go-qrcode/commit/429dd1126e8c5280943e99793a3783ef8f0d5d29 :)


Wake immediately before returning Poll::Pending

The original code returned Poll::Pending without first receiving
Poll::Pending from a downstream future or telling the task's waker
to wake the future immediately. This results in the future never
being called ever again (as nothing is told to wake it.
The original intent was for this future to be polled immediately
so more data would be read from the earlier part of poll_next().
Therefore, tell the task to wake this future immediately.
Please help keep the CHANGELOG up to date by providing a one sentence summary of your change:

Good catch!
I now realize this should ideally be rewritten using a loop. But for now re-polling like this should be fine, assuming waking your own task in such a manner is guaranteed to result in another poll (... it is, right? I'm not finding a lot of concrete information about waker's guarantees).

Yes, it guarantees another poll. Doing this does yield this task, meaning the tokio scheduler could pick (and probably will if any other is runnable) some other task to run before this one is run again.
This may or may not make you want to rewrite it as a loop. There are benefits to yielding after some quantity of work to give other tasks on the queue time to run. However, if no other task is ready, it will be run immediately just as if there was data to read.


[Bug]:

Dev Ops Area

[ ] Has been documented

Documentation

Add documentation as list

Bug Info
Powel-ID: [PowelId]
Product: [POM ]

Version: [VersionNumber]

Severity: [SeverityLevel]

Customer: [CustomerName]
Environment: [EnvironmentName]
Database: [DatabaseUsed]
Additional Info
{ Any additional info regarding the bug }
What Happened?
{ And what was expected }
Steps to Reproduce
{ How to reproduce it }

@ChristofferDahlen this is a stub issue that has been created as a placeholder in this repo.
Your original issue has been moved to https://github.com/ChristofferDahlen/TestRepo/issues/132


[X] Have you rebased the branch on the latest main?
[X] Have you tested the change locally?

Added functionality for GET and PUT for notifications with the backend. Check the console if you want to make sure what returns from the GET and PUT calls. Edit it to show what you want. Some modifications have been made to the code to match the DTO in the backend, hence some namechanges and outcommented code for the Message interface. Will be edited in the future to match the DTO.
Please comment progress and if some changes are required

Solved in #329