Revisit polymorphic classes with identical implementation

The Issuer- and User- SecurityContext classes have virtually identical implementations.
Aside for that the concept of Tenant does not belong to the domain of tokens. At some point I think some cleanup will be helpful in this area to clarify the concept.

Implemented in PR #26. I realized that actually, the issue would be with the token. If what's desired is to use the user ('sub') for identifying the key, then the issuer must have the same value as 'sub'.

The fingerprint() mechanism implemented is consistent with the output of ssh-keygen. All good there.

Fixed by PR #26.


Adds ./ and ../ as valid subpath prefix

Closes #67.
Checks if ./ and ../ are the first segment in the subpath, if they are, proceed. Otherwise, throw the invalid error

@pombredanne here is the PR to fix this in the go library.

GitHub Actions seem to be stuck on this PR. Similar issue like: https://github.com/orgs/community/discussions/26698

@ridhoq  can you run these commands to force another run of Github Actions?
git commit --amend --no-edit
git push --force-with-lease

The pipeline is stuck :/ it's an issue on Github.

@shibumi just repushed as you suggested. But the error looks the same. I noticed that it is saying that it is awaiting approval:

Are you able to approve the workflow?

@ridhoq  This approval button was missing for me, before.
Now it works! Thanks!

@ridhoq  I have created: https://github.com/package-url/packageurl-go/pull/69 to fix the Github actions issues.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.942%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
253

Relevant Lines:
291

💛  - Coveralls

Thanks for reacting to so quickly @sschuberth  :)

@shibumi is it possible to publish a new version to make this fix available for consumption? cc @pxp928

@sschuberth as well for the above question

@sschuberth as well for the above question

While I'm part of the general package-url org, I have no clue about Go and / or publishing packages for it specifically 😄


Allow implementations to override how primary key is defined

…similarly to how a column can be defined as auto-increment can be overridden.
The reason this is (probably) necessary is described in this issue for Swift-Kuery-SQLite, for which defining auto-increment columns is currently broken in a somewhat comical way which probably can't be fixed without hacking the core Swift-Kuery project like this.
Possibly in the future, both this and the auto-increment function can probably be replaced by a single function which receives the whole column definition and builds the query itself rather than going back and forth between Kuery and the implementation. (Based on a little bit of research, a hypothetical SQL Server implementation would need to implement both of these current methods as well.)
There is probably a small speed impact to this change, but getting auto-incrementation working in SQLite is worth it IMO.
I already have a tested and working change for the SQLite implementation ready to create a PR for as soon as this one lands.

I think the idea of a single function to build the column attributes is a good one and would save some of the back and forth between the plugins and Kuery as well as making the code a bit tidier (at least I imagine so).
@NocturnalSolutions would you be interested in prototyping this alternative? If not I will set some time aside early next week and pull something together for our consideration.

I have the following PR open that moves the building of the column out of SwiftKuery and into the plugin:
https://github.com/IBM-Swift/Swift-Kuery/pull/153
This PR will be unnecessary once the above PR gets merged.

#153 is now merged so I am closing this PR.


STS: verify that a role exists to allow sts:AssumeRole

Hey,
I started this PR by writing the test case, as I found odd that it was possible to assume_role() with a non-existing IAM role.
Then I tried to fix it, but:

it's becoming to feel like "by design" that this check does not exist to begin with
Given that assuming a role that does not exist yields an AccessDenied error, I wonder if the logic that check that the role can be assume should be instead in moto.iam.access_control.IAMRequestBase.check_action_permitted() ?

I'm pushing this code now as a draft to open the discussion, can you help me contributing to this or let me know if this does not make sense?

Thank you for the feedback @bblommers .
Since an sts:AssumeRole on a non-existing role yields an AccessDenied, I see an alternative way to test a code path for a non-existing role to use a principal lacking permissions to assume such role
I managed to get something like this to work:
@set_initial_no_auth_action_count(3)
@mock_sts
def test_access_denied_with_not_allowing_policy():
    user_name = "test-user"
    forbidden_role_arn = f"arn:aws:iam::{ACCOUNT_ID}:role/forbidden"
    inline_policy_document = {
        "Version": "2012-10-17",
        "Statement": [
            {"Effect": "Deny", "Action": ["sts:AssumeRole"], "Resource": forbidden_role_arn}
            ],
    }
    access_key = create_user_with_access_key_and_inline_policy(
        user_name, inline_policy_document
    )
    client = boto3.client(
        "sts",
        region_name="us-east-1",
        aws_access_key_id=access_key["AccessKeyId"],
        aws_secret_access_key=access_key["SecretAccessKey"],
    )
    with pytest.raises(ClientError) as ex:
        client.assume_role(
            RoleArn=forbidden_role_arn,
            RoleSessionName='azerr'
        )
    assert ex.value.response["Error"]["Code"] == "AccessDenied"
    assert ex.value.response["ResponseMetadata"]["HTTPStatusCode"] == 403
    assert (
        ex.value.response["Error"]["Message"]
        == f"User: arn:aws:iam::{ACCOUNT_ID}:user/{user_name} is not authorized to perform: sts:AssumeRole"
    )

(very inspired from https://github.com/getmoto/moto/blob/fa9aa95156d1e11a3c5a2e06ab8b085ae98c2c1f/tests/test_core/test_auth.py#L269)
But when I tried to set the inline_policy_document to something more "realistic" for the test, ie with broader permissions but a deny on that specific role, my assume_role that should work is denied as well:
@set_initial_no_auth_action_count(3)
@mock_sts
def test_access_denied_with_not_allowing_policy():
    user_name = "test-user"
    forbidden_role_arn = f"arn:aws:iam::{ACCOUNT_ID}:role/forbidden"
    allowed_role_arn = f"arn:aws:iam::{ACCOUNT_ID}:role/allowed"
    inline_policy_document = {
        "Version": "2012-10-17",
        "Statement": [
            {"Effect": "Deny", "Action": ["sts:AssumeRole"], "Resource": forbidden_role_arn},
            {"Effect": "Allow", "Action": ["sts:AssumeRole"], "Resource": "*"}
            ],
    }
    access_key = create_user_with_access_key_and_inline_policy(
        user_name, inline_policy_document
    )
    client = boto3.client(
        "sts",
        region_name="us-east-1",
        aws_access_key_id=access_key["AccessKeyId"],
        aws_secret_access_key=access_key["SecretAccessKey"],
    )
    with pytest.raises(ClientError) as ex:
        client.assume_role(
            RoleArn=forbidden_role_arn,
            RoleSessionName='azerr'
        )
    assert ex.value.response["Error"]["Code"] == "AccessDenied"
    assert ex.value.response["ResponseMetadata"]["HTTPStatusCode"] == 403
    assert (
        ex.value.response["Error"]["Message"]
        == f"User: arn:aws:iam::{ACCOUNT_ID}:user/{user_name} is not authorized to perform: sts:AssumeRole"
    )
    client.assume_role(
        RoleArn=allowed_role_arn,
        RoleSessionName='azerr'
    )

./tests/test_core/test_auth.py::test_access_denied_with_not_allowing_policy Failed: [undefined]botocore.exceptions.ClientError: An error occurred (AccessDenied) when calling the AssumeRole operation: User: arn:aws:iam::123456789012:user/test-user is not authorized to perform: sts:AssumeRole

Reading this line shows it's a known limitation: https://github.com/getmoto/moto/blob/bef70a47d93f10d6371bcc5edf7877cce0083cf2/moto/iam/access_control.py#L6
From debugging I noticed that the above client.assume_role call goes up to there an the resource attribute is not set properly: https://github.com/getmoto/moto/blob/c8b5470e25012477f817a619e88f9ad1bea08bbe/moto/core/responses.py#L131
I tried understanding how this PR for S3 got the resource policy checks implemented, but the call stack for s3 functions are going through the s3/reponses.py whereas the assume_role call stack goes though core/responses.py: I am a bit at loss as what/where/how to implement the missing logic for the resource parameter to be passed to moto.core.responses.ActionAuthenticatorMixin._authenticate_and_authorize_action()
I tried to see if I could contribute something in this regard but I may try to chew more than I can bite ; what do you think? Could you give me some pointers?

All S3-methods() call _authenticate_and_authorize_s3_action, which is also defined in moto/core/responses.py.
Other services call _authenticate_and_authorize_normal_action - but both versions end up calling _authenticate_and_authorize_action(), just using different parameters.

what/where/how to implement the missing logic for the resource parameter to be passed to moto.core.responses.ActionAuthenticatorMixin._authenticate_and_authorize_action()

IMO, the logical place would be to determine the resource when calling _authenticate_and_authorize_normal_action:
https://github.com/getmoto/moto/blob/fa9aa95156d1e11a3c5a2e06ab8b085ae98c2c1f/moto/core/responses.py#L496
The problem then becomes of course determining what the value for resource is, based on just the request (headers/body) - it's not immediately obvious to me how to do that cleanly...
Maybe we can delegate this to the service-specific backends? So something like STSResponse._determine_resource(request).
The action flow in call_action then becomes:
resource = "*"
if hasattr(self, '_determine_resource'):
     resource = self._determine_resource(request)
self._authenticate_and_authorize_normal_action(resource)

Open to suggestions here, maybe (hopefully!) I'm missing something obvious.

Closing this PR as it didn't make sense to begin with, continuing the other discussion in  #6799


contentScript sourceMap does not work

Describe the bug
contentScript sourceMap does not work
Expected behavior
It can be used at the tsx source file breakpoint
Screenshots

Environment
  System:
    OS: macOS 14.0
    CPU: (8) arm64 Apple M1
    Memory: 72.80 MB / 8.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.14.0 - ~/.nvm/versions/node/v18.14.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v18.14.0/bin/yarn
    npm: 9.3.1 - ~/.nvm/versions/node/v18.14.0/bin/npm
    pnpm: 8.6.9 - ~/Library/pnpm/pnpm
  Browsers:
    Chrome: 119.0.6045.123
    Chrome Canary: 121.0.6127.0
    Safari: 17.0
  npmPackages:
    wxt: ^0.9.0 => 0.9.0

Thanks for reporting. As far as I know, this is a problem with Chrome, not WXT. I have another build tool, vite-plugin-web-extension, and it has the same problem:

https://github.com/aklinker1/vite-plugin-web-extension/issues/142
https://github.com/aklinker1/vite-plugin-web-extension/issues/147

It works in Firefox, and this can be reproduced with any other bundler or project setup.
This comment/thread might help you out if you're trying to setup a debugger and break points

If anyone can make this work with a basic setup or different build tool, I would gladly implement the fix in WXT, because this is very annoying.

@aklinker1 I'm not sure that it actually is an issue with chrome as I get proper line numbers and mapping with this plasmo example : https://github.com/PlasmoHQ/examples/tree/main/with-content-scripts-ui

Starting vite with
export default defineConfig({
  vite: () => ({
    plugins: [react()],
    mode: "development",
    build: {
      minify: false,
      sourcemap: "inline",
      terserOptions: {
        sourceMap: true,
        compress: false,
      },
      rollupOptions: {
        treeshake: false,
      }
    }
  }),
});

I get the following error message (wxt:unimport plugin) Sourcemap is likely to be incorrect: a plugin (wxt:unimport) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help
WXT 0.14.7                                                                                23:55:32
√ Started dev server @ http://localhost:3000                                                                                23:55:32
i Pre-rendering chrome-mv3 for development with Vite 5.0.12                                                                                23:55:32
(wxt:unimport plugin) Sourcemap is likely to be incorrect: a plugin (wxt:unimport) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help
(wxt:unimport plugin) Sourcemap is likely to be incorrect: a plugin (wxt:unimport) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help
√ Built extension in 592 ms

CRXJS which also used vite plugins added this https://github.com/crxjs/chrome-extension-tools/pull/701

@lionelhorn After making the change in #381, I was able to get source maps working, but I needed to uncheck the "content scripts injected by extension" checkbox under the ignore list in devtools.
https://github.com/wxt-dev/wxt/assets/10101283/1496ca27-7389-4d79-98c6-8586d079ac13
Unfortunately, it resets when running wxt in dev mode by default. This can be mitigated by using a custom runner.chromiumProfile with the setting toggled. I can't figure out where this setting is stored or if it can be configured on startup or in new profiles...

Looks like it's a setting called "skipContentScripts"?
https://source.chromium.org/chromium/chromium/src/+/main:out/fuchsia-Debug/gen/third_party/devtools-frontend/src/front_end/panels/settings/settings.js;l=875;drc=b274bd7ace3a064c7fae27748b6d007068bbea30

Released some new changes to improve sourcemaps in v0.15.0

#381
#382

There are lots of command line flags in chromium
https://peter.sh/experiments/chromium-command-line-switches/
I'm not using the runner so your PR fixed the issue for me 👍 Thanks for the quick fix !

Found it! devtools.synced_preferences_sync_disabled.skipContentScripts under the <profile>/Preferences file.
I should be able to enable it automatically once my web-ext PR gets merged, or I add the change into my fork, web-ext-runner. It doesn't work for all preferences, but hopefully it will work for this one.


Avoid doing character decoding when parsing uuids

Valid UUIDs are always ascii so we can avoid doing the decoding unless
we encounter a byte that is not a valid character.
 name                           orig ns/iter  new ns/iter  diff ns/iter   diff %  speedup
 bench_parse                    1,832         1,407                -425  -23.20%   x 1.30
 bench_parse_invalid_character  71            64                     -7   -9.86%   x 1.11
 bench_parse_invalid_group_len  102           80                    -22  -21.57%   x 1.27
 bench_parse_invalid_groups     123           100                   -23  -18.70%   x 1.23
 bench_parse_invalid_len        2             2                       0    0.00%   x 1.00
 bench_valid_hyphenated         116           96                    -20  -17.24%   x 1.21
 bench_valid_short              98            78                    -20  -20.41%   x 1.26

👍
Nice wins!


Update README.md for Developer Center

Description
The Developer Portal is being deprecated in favor of the Developer Center, which doesn't require authentication.
Changes
Change from Developer Portal to Developer Center and link to API docs page, which looks as follows.

Checklist

[x] No sensitive information has been committed
[ ] Changelog file has been updated
[x] Code generates no warnings (i.e. cargo fmt --check)
[x] "Noisy" (WIP) commits have been squashed for better commit hygiene and cleaner history

Additional Notes
The Developer Center hasn't launched yet, which is why this PR is in draft form.

Thanks for the this, we will merge this as soon as it's avaiable.

The new site is live now and there's a redirect in place so there shouldn't be any issues before this PR is merged.

The new site is live now and there's a redirect in place so there shouldn't be any issues before this PR is merged.

Thanks for letting us know @mraible! We've added this to our meeting agenda and will discuss tomorrow.


Waste lots of time to redownload grpc when building with CMake

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):No.
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):Windows 7 64 bit.
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:No.
TensorFlow installed from (source or binary):source
TensorFlow version (use command below):1.9
Python version:3.5
Bazel version (if compiling from source):No.
GCC/Compiler version (if compiling from source):VS2015
CUDA/cuDNN version:CUDA 8.0 and cuDnn 7.0.
GPU model and memory:No.
Exact command to reproduce:

cd $TENDORFLOW_DIR/tensorflow/contrib/cmake
cmake .
make -j20

Describe the problem
Describe the problem clearly here. Be sure to convey here why it's a bug in TensorFlow or a feature request.
I want to build tensorflow from source with CMake in Windows, but it fails with the error caused by the fail of gprc. I wonder if there is a way to avoid the redownload gprc when rebuilding form source.
Source code / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached. Try to provide a reproducible test case that is the bare minimum necessary to generate the problem.
29>  Creating directories for 'grpc'
29>  Cloning into 'grpc'...
29>  Performing download step (git clone) for 'grpc'
29>  fatal: unable to access 'https://boringssl.googlesource.com/boringssl/': Failed to connect to boringssl.googlesource.com port 443: Timed out
29>  fatal: clone of 'https://boringssl.googlesource.com/boringssl' into submodule path 'D:/CNN/tensorflow/BUILD/grpc/src/grpc/third_party/boringssl-with-bazel' failed
29>  Failed to clone 'third_party/boringssl-with-bazel'. Retry scheduled
29>  Failed to clone 'third_party/boringssl-with-bazel' a second time, aborting
29>  CMake Error at D:/CNN/tensorflow/BUILD/grpc/tmp/grpc-gitclone.cmake:93 (message):
29>  Failed to update submodules in: 'D:/CNN/tensorflow/build/grpc/src/grpc'

I think that package is required. I don't know why you were having trouble downloading but I hope that the connection is working now. I will close for now assuming you were able to build, but please reopen if I have misunderstood.

Yes, I know grpc is required. But what we need is incremential downloading, not redownload the whole package when failed to build the project. As you known, the grpc is more than 200M! My network is not good and every time in rebuilding it takes serval hours to download the grpc package.
The url of boringssl is not accesible under the Great Firewall of China.

I see I'm sorry thanks for clarifying. @mrry do you think this is something that would be feasible without heroic effort?

It sounds like it should be possible, but we'll need someone with more CMake expertise to suggest a fix, so I'll mark this as "contributions welcome".
As a potential lead, the UPDATE_DISCONNECTED option seems relevant:

https://github.com/Kitware/CMake/blob/5bbcf76399e107bbb1712ba8aeee27c160413d2d/Modules/ExternalProject.cmake#L320-L338
https://stackoverflow.com/q/36254658/3574081

A couple of days ago the Windows build was switched over to use bazel instead of cmake. That doesn't solve your problem, but it means the best solution now is going to be a feature request to the bazel team I think. Sorry not to be more help.


inference with jpg files

Hello, As I know GAN algorithm has problem on jpg images.
do you try your algorithm for jpg files? is there abnormal noise texture exist in output?

Same! Whenever I try a jpg file the output is very “blocky”’ like there’s small but very noticeable square blocks covering the entire image. I assumed this was esrgan simply “enhancing” the jpg artifacts already present, is that accurate or does it actually create new/worse ones?
I’ve noticed slight improvement by converting the jpg to a png before I start, but it’s still not great.

@xinntao  for suggestion 2) finetuning the network with datasets with JPEG artifacts, so that the ESRGAN can handle them.
I try to finetune using jpg dataset for SRGAN, but not work well, also block and noise exist
but same training method for EDSR works well.

@suke27 You can try to first pre-train the network with L2/L1 loss with JPEG compressed images. And then use the pre-trained model to train a GAN-based model.
I think, L2/L1 loss is a clear and effective loss to guide the network to remove the JPEG compression artifacts (Therefore, finetuning with jpg dataset works well for EDSR). But for SRGAN, the VGG + Adv loss may be not enough to remove the JPEG artifacts. So I think first pre-training the network with JPEG compressed images to let the network learn to remove JPEG artifacts will work.


Launch failed: Cannot read property 'connection' of null

{
"version": "0.2.0",
"configurations": [
{
"type": "android",
"name": "Android Debug",
"request": "launch",
"appSrcRoot": "${workspaceRoot}/app/src/main",
"apkFile": "${workspaceRoot}/app/build/outputs/apk/debug/app-debug.apk",
"adbPort": 5037
}
]
}
Checking build
Warning: Build is not up-to-date. Source files may not match execution when debugging.
Searching for devices...
Found 1 device
Current build already installed
Launching js.j2v8/.MainActivity on device emulator-5554 [API:27]
Launch failed: Cannot read property 'connection' of null
Debugger disconnected

i have same luanch configuration and got same error with you.

There a number of issues relating to the debugger not starting on the emulators.
Often it's because the emulator does not support the APIs the app is relying upon - for example, building an app that uses APIs from Google Play Services and then running it on a non-play-services emulator will cause this.
In any case, viewing logcat on the emulator should show the reason why the debugger disconnects.
Closing until more information is available.


Implement microfacet based MaterialX closures

Another round of MaterialX closure support. Refraction and energy conservation/albedo is still TODO ...

@lgritz the testsuite failures appear to be unrelated to this change. Did something change on the OIIO side maybe?

Updated with refraction support.

I'm testing a fix for the mismatched images, stand by...

I think I have a fix, but no matter what I try, I can't seem to push an update to your branch (I know it's let me do that before).
So I pushed my fixes (as well as rebasing on to of current main) to lgritz/mx-fresnel. Can you please grab that, and then re-push it as fpsunflower/mx-fresnel, and then I think we're ready to go?

Will take a look tonight. Thanks!

Because I know I can repair this with a single small patch on top, I'm just going to merge this as-is and then just do my fix subsequently.


Add more Documentation

I try to follow the Numpy doc style

I think docs are in a good spot for now


fix(payment): INT-4598 handle vaulting Enable checkbox for Digital River

What? INT-4598
added showSavePaymentAgreement dynamically instead of hardcoded
Why?
It's a bug that could affect future DigitalRiver users
Testing / Proof

Dependency of
https://github.com/bigcommerce/checkout-sdk-js/pull/1178
@bigcommerce/checkout @bigcommerce/apex-integrations

Could a @bigcommerce/checkout take a look for us please?

Hi @icatalina I made changes, thanks for the feedback


feat: The class 'vtmn-container' doesn't allow us to set the margin according to the design system

Is your request related to a problem? Please describe.
When we tried to set the margins(in accordance to the Design System Guidelines) on the landing pages created using NEMO, we discovered that the container class, vtmn-container, is a fixed width container, meaning it will have a fixed left and right margin and will not take the complete width of the viewport. Attaching some screenshots below.
Describe the solution you'd like
Can we make the container class, vtmn-container a fluid container? As in, the container will take up the complete width of the viewport and will expand or shrink whenever the viewport is resized?
Our developers have told me that if the container has the styles 'min-width' and 'max-width', it will allow it to have the flexibility needed for us to set the desired margins. Right now, the container only has 'min-width'.
Additional context
The below screenshot shows a NEMO landing page (link) at the breakpoint 1440.

The below screenshot shows the same NEMO landing page at the breakpoint 1799.

(P.S: Just so you know, I am not a programmer. This request is based on my conversations with the developers here in Spain :) )

Hi @AlbertNambiaparambil, thanks for reaching us. Just to be sure, what component are you referring to?

Hi thanks @AlbertNambiaparambil for this report.
@GaspardMathon I think Albert is speaking about the vtmn-container generated by Tailwind CSS.
Maybe we need to update our preset.https://v2.tailwindcss.com/docs/container

Hello @GaspardMathon @lauthieb !
Correct, I was referring to the class, vtmn-container.

FYI @AlbertNambiaparambil, @thibault-mahe will investigate as soon as possible.
@thibault-mahe feel free to add a section "Containers" inside this page: http://localhost:6006/?path=/story/guidelines-layout--page
Thanks a lot!

Hi @AlbertNambiaparambil, thanks for reaching us!
The Design System Guidelines do not recommend that "the container[…] take up the complete width of the viewport". On contrary, the Breakpoints section specifies to avoid using a 100% width layout on large screens, using breakpoint's margins instead. This is what the vtmn-container class is all about : specifying given max-width on different breakpoints, with fluid margins, "to avoid having too many spaces or too long sentences on large screens."
On your 1440px wide screenshot, the container has a 1200px width (as specified in the guidelines), leaving (1440 - 1200) / 2 = 120px of fluid margin on each side. On your 1799px wide screenshot, the container still has a 1200px width since the next breakpoint is at 1800px, leaving this time (1799 - 1220) / 2 = 300px of fluid margin on each side. This approach is in line with the guidelines.
I'm closing this issue. Do not hesitate to get back to me here to discuss this subject or reopen it. I may not have fully understood the issue, especially the 2 following parts :  "vtmn-container is a fixed width container, meaning it will have a fixed left and right margin" (if the container is fixed then the margins are necessarily fluid, and vice versa) and the "Right now, the container only has 'min-width’." (right now the vtmn-container has a full width and max-width at different breakpoints).
I will add an illustrated « Containers » section in the guidelines to make this clearer.
Thanks! :)

Hello @thibault-mahe @lauthieb,
I understand the class vtmn-container works with a specific max-width and fluid margins.
However, if I understand the layout guidelines of the Design System correctly, the margins are supposed to be constant within a given breakpoint.

Which means according to the Design System (image above),

A device of size 1440 should have a margin of 80px
A device of size 1600 should also have a margin of 80px.

Where as on this landing made using NEMO,

A device of size 1440 has a margin of 120px (image below)

A device of size 1600 has a margin of 200px (image below)

Looking forward to our video call on Monday to discuss this problem further,
Have a great weekend,
Albert

Hi @AlbertNambiaparambil, thanks for your message :)

If I understand the layout guidelines of the Design System correctly, the margins are supposed to be constant within a given breakpoint.

You do understand the layout guidelines of the Design System correctly, mistake is our. I discuss this subject with the design team and they told me that the specified margins are not constant, but they are minimal margins.
It still means that your screenshots are compliant with the guidelines. But it also means that, de facto, some breakpoints cannot be in line: for instance at the 600px breakpoint, the container would be 600px wide, with 0 margin...
I reopen this issue for 2 tasks:

Rework the breakpoints (or the container) to be compliant all the time --> this could be a breaking change so it could take longer to be fixed
Clarify the guidelines: make the container width clear for each breakpoint, and make the minimal margins explicit.

I'll keep you updated on this thread. Thanks again for having pointed this out!

I have added this task to the Design system board projet

Hi,
As this issue will be brought in the next major release of Vitamin because of breaking changes for the current version, just added this issue in comment of our existing issue https://github.com/Decathlon/vitamin-design/issues/3#issuecomment-1327207263

The issue is now refered here : https://github.com/dktunited/vitamin-play/issues/35
Thanks again all !


Delay file truncate until after BeforeCopy hook

While integrating grab into my downloader application I wanted to add a custom hook to decide whether I really need to download the file based on some custom headers. The BeforeCopy hook appeared to be the place to do this as it would perform the request, let me read the headers, and return an error to cancel the request if I decide I don't want to read the body.
The issue with the BeforeCopy hook is that the openWriter has already run first, and if you are not doing a resume option on an existing file (which I am not) it will truncate the file when it opens it for writing. Then if the hook decides to cancel, it will have erased the existing file contents.
This patch removes the O_TRUNC option from the case in openWriter and moved it into copyFile after the BeforeCopy has evaluated. The result is that an existing file will not be truncated until it is actually going to write.
I debated solving this by adding another hook earlier into the lifecycle, but this seemed like a simpler change to make.
Minor extra changes to make testing easier were to add a Go.mod and .gitignore

Nice work! Thanks

Sweet. Thanks for the quick merge!


RXJS 5.0.1

Should it changed in package.json ?

RXJS 5.0.1 doesn't work for me...

@Blankarsch What is your problem? I just updated the lib, all the tests pass and everything seems to be working just fine.

Hi, having issues since angular and ionic are using<EMAIL_ADDRESS>but angularfire is using ^5.0.1... can't shrinkwrap either way.
npm ERR! peer dep missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer dep missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer dep missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer dep missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>Any suggestions? Thanks


Block Entities weird behavior

I found that when you create a block entity in a chunk, every create mod blocks/framed block mod blocks in that specific chunk stop working correctly. For example, you can't use copycat blocks in the same chunk as a block entity from Yuushya townscapes. (forge, Yuushya townscapes 2.0.0, mod list can be sent)

fix it. use 2.2.0


fix transfers

AND should be WHERE
also updating to _modified_timestamp.
These changes are in the larger PR but separating out due to the need to run manual fix on this model first

`dbt run -s silver__token_transfers+ --vars '{"MANUAL_FIX": True, "RANGE_START": 117598000, "RANGE_END": 117605000}'1


Unexpected error_buf population in wasm_runtime_load

Hi,
I've realised that the method check_wasi_abi_compatibility of the interpreter's wasm_loader populates the error buffer even though no error took place. Admitttedly, the code succeeds to run (and the return code is zero), but I find this behaviour slightly counter-intuitive.
In particular, in the cited method (check_wasi_abi_compatibility), WAMR will look for either _start or _initialize (but not both). As a consequence, one of the lookups must fail. The failing lookup populates the error buffer with an error string. IMO the error string should be reset when checking that only one of the symbols was found, but wanted to ask if this is the expected behaviour.

One of the checks in check_wasi_abi_compatibility is to check if the module exports either _start or _initialize but not both (exporting both would, correctly, yield an error.
As a consequence either:

The call to wasm_loader_find_export for _start (here), or
the call to wasm_loader_find_export for _initialize (here)
will fail, populating the error buffer.

Note that the call to set_error_buf happens inside wasm_loader_find_export here: https://github.com/bytecodealliance/wasm-micro-runtime/blob/main/core/iwasm/interpreter/wasm_loader.c#L711-L712

I take your point now. It seems there is a possibility to overwrite the error message from wasm_loader_find_export in check_wasi_abi_compatibility.
But it is allowed to be failed to look for _start or _initialize. In other words, the error message from
https://github.com/bytecodealliance/wasm-micro-runtime/blob/021130f4a3377726d9b3ab595caf76214c55fa80/core/iwasm/interpreter/wasm_loader.c#L711-L712
will be ignored and/or be overwrite with a new one.
Another error message
https://github.com/bytecodealliance/wasm-micro-runtime/blob/021130f4a3377726d9b3ab595caf76214c55fa80/core/iwasm/interpreter/wasm_loader.c#L740
seems to be unnecessary because there is a validation in load_export_section(). We might remove it.

#1720


Feature/workflow

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update build-definitions bot name

I'm gonna go ahead and merge this because the auto merge functionality is currently broken.


docs: Added neovim plugin option

I recently merged a PR to neoformat to support csharpier out of the box. This PR updates the editor plugin docs to reference it as an option for neovim users.
Referenced neoformat PR

Thanks for adding support for csharpier!
Do you mind also making the change to https://github.com/belav/csharpier/blob/master/Src/Website/docs/Editors.md, those are the "released" versions of the doc that the website uses.

No problem! I just pushed a commit doing that.


Add GitPod launch button

We should be able to provide a one-click "try me out on GitPod" button that let's visitors fire up VS Code in their browser and write Lingua Franca right away. More info: https://www.gitpod.io/docs/vscode-extensions

They are now here, closing this issue


Adding error code to distinguish between errors

Will discuss with @ericsciple  whether to use "Complete Task command result code or use logissue result code"

Can you only make the minimum change and not reformat the document? I'm having a hard time figuring out what the actual change is.

@ericsciple sorry. couldn't resist pressing formatting shortcut.
Changes:
https://github.com/Microsoft/vsts-task-lib/pull/253/files#diff-f7bc92bcb6131b3321462f4336b98b7bR281
https://github.com/Microsoft/vsts-task-lib/pull/253/files#diff-8d040e410d00a119c5517a408d3a7ec0R41
Exposing resultcode for warning/error as logissue already supports it.
Adding resultcode for complete command. this shouldn't break compat as it's new property

@ericsciple can you approve this? :)

@bryanmacfarlane @TingluoHuang to review since i'm not involved in the current proposed telemetry direction, and this is different than the initial discussion of a ## command

also does this require a new agent version? you may need to check agent version before including code in the command. would need to be documented on the function comments.

It doesn't require new agent as it's additional property and will not be parsed in older agents.

I don't want to hijack warning and error.   It's not a warning or error.
Whether it's not parsed in older agents or not called (##vso) because you don't have a newer agent, the result is the same - older agents won't send telemetry.
Use a new ##vso command

@bryanmacfarlane addressed the review comments. it uses only complete command error code now.

@bryanmacfarlane can you please approve the pr?

@TingluoHuang Can you please merge the PR?


Migrate network configurations from PreferencesController to NetworkController

Relevant tickets: https://github.com/metamask/core/issues/1004 & https://github.com/MetaMask/core/issues/969
This PR moves the management of network configurations (called frequentRPCList on the PreferencesController) from the PreferencesController to the NetworkController because a) this makes more sense and b) it will help with process of transitioning towards a paradigm where the wallets manage concurrent multi-chain "connections".
I've modified the state layout - networkConfigurations is an object keyed by uuids, where frequentRPCList was a simple array - but I am open to changing this back. Ultimately it doesn't realistically matter for performance given how small these lists will be, but reads will be theoretically faster and we are considering adding headers (or something like it for credentialed based RPC providers) as an additional part of these config and so rpcUrls may no longer be a reliably unique field in which case it will make sense for the configs to have a corresponding uuid. Given that I figured we might as well make the configuration storage an object keyed by these uuids.
Next step: implement these same changes on the extension side PreferencesController and NetworkController to ease the NetworkController merge

Marking as DO-NOT-MERGE until the equivalent migration is in-review on the extension (https://github.com/MetaMask/metamask-extension/issues/16572)

Looks great, nice work @adonesky1 ! Out of the comments left by the others, the comment about getting more strict on what is required as part of a providerConfig seems like it would be a really nice improvement.

Thought a bit more about whether we should continue upserting an RPC endpoint or not. If we were designing this from scratch, I would say we shouldn't do this and should instead throw if an RPC endpoint is added which shares the same URL as another. However given that this PR is concerned with just bring this code over from PreferencesController I would say that we can probably defer this. I would imagine that we would iteratively make some more design changes to improve the API as we tackle future issues.

Marking as DO-NOT-MERGE until the equivalent migration is in-review on the extension

Label removed, as the extension PR has been in review for some time now. But I've moved this into draft temporarily until this branch can be updated to reflect the API changes made in the course of implementing this on the extension.


Feature request: add .gitignore file

After installing the package, a number of directories and files are created in the lib/semantic-ui directory, some of which are generated when running meteor and thus not to be edited. To keep my repo clean, I want to exclude these files from the commit. To do this, I've added the following to lib/semantic-ui/.gitignore:
definitions
themes
.custom.semantic.json
semantic.less
theme.import.less

It might be useful to add this file by default when generating the other files (in the same way as theme.config.import.less is handled; "only if the file does not exist"), to make the package easier to use. What do you think?

How would you deploy on production without those files?

Hm, good point maybe.. I deploy with the modulus cli so it's no problem (it will just upload all the files from your computer). How it works with other methods I'm not sure.

I see! I still believe I would keep those files in my repo because I don't want to regenerate them. Moreover you could remove the plugin and it will still work with those files! :)

Ah ok, thanks for explaining! The way I saw it was more like a package; your repo only contains a link to the package (in .meteor/packages) and the code to configure the package for your app (like at_config.js). The package code itself is downloaded when running Meteor. But maybe that way of thinking doesn't apply here?

I'm new to Semantic and also have this issue. I want to keep my repo clean like @rijk. According to the README, the files and folders listed above are generated every time Meteor is run. Based on that, you should be able to ignore them, since your server will just generate them again. Is there some flaw in this logic?

They will be generated when run with meteor run but not when doing meteor build. I too want to keep my repo clean but It seems impossible for the moment. I opened an issue here for the build not generating the required files. https://github.com/Semantic-Org/Semantic-UI-Meteor/issues/83


Update Go to version 1.4.3

This pull request updates Go to version 1.4.3 compatible with Appengine SDK 1.8.0.
Despite the fact that the official release of GAE 1.8.0 was tied to Go 1.1.2 I think all Appscalers-Gophers would be grateful to see Go 1.4.3 merged into master. Moreover the current release of Go is 1.6 which seems so far away from the current supported version by Appscale.

@airamrguez thank you for submitting a Pull Request.
Thanks to contributors like yourself, AppScale gets better and better!
We'll do some testing and reviewing before we merge. :)
CI Trusty build: https://ocd.appscale.com:8080/job/Daily Build/1228/

@airamrguez: Would you be willing to remove the binaries from this pull request? I know the go binaries were already present in the repo, but I think it would be better if they were created during the build process.
Also, I think it would be best to create a new branch without these particular commits so that the extra ~35MB doesn't get added to the size of the repo.
I haven't tried building this, so let me know if there would be any problems with adding the process to debian/appscale_install_functions.sh.

If the build process takes an unreasonably long time, another option would be to download the go binaries from a trusted source during the AppScale build.


Epic: Refactor Container class to allow custom policies in various places

Main request from Word in this space:

Custom non-immediate noop policy / logic (this is already extracted into separate class, so need to allow ability to supply alternative implementation).
Potentially custom implementation of protocol handling, including connectivity and re-connectivity

request comes from potential differences RE tracking clients in quorum, and system without join / leave message (i.e. driver not using sockets, and whole system maintaining alternative ways to reconnect, i.e. going through more expensive external 3-way merge process).

Items:

[x] #8461
[x] #8462
[x] #8463

Closing Epics in Github


Stop setting UpstreamIO to nil on Close

Stops setting UpstreamIO to nil on Close or CloseStdin. This means that the
call will always return a valid non-nil connection even if that connection has
been previously closed. This will stop the shim from panic'ing and instead
return a "connection already closed" error if used.
Adds a check on the invariant state of in, out, serr returned from the
platform and makes sure it matches the requested state on creation.

Signed-off-by: Justin Terry (VM<EMAIL_ADDRESS>

@jhowardmsft - Try instead of #550


Make fetchFromGitHub support submodules

Currently if your source bundle uses git submodules, you either need to use fetchgit or manually string together fetchFromGitHub invocations to plug them into the relevant locations.
The former already works, but is less efficient than it needs to be. The latter could be done by calling fetchFromGitHub recursively, parsing the .gitmodules file, and pulling out submodules as needed. The submodules could themselves be fetched with the equivalent of fetchgit (with non-GH submodules, assuming its builder script is reusable) or fetchFromGitHub (if the submodules come from GH)

There are a few packages using fetchgit for this reason, we should port them when this is done as a proof of concept

The current fix uses fetchgit as Fallback, ideally we’d like to have a recursive fetchtar/fetchzip.

I believe this can be closed now.


GitHub workflows CI tests fail on Python 3.6

I've tried to solve it in #232, with no success. So I give up.
If someone knows how to fix it, please help us. Otherwise, I will drop support for Python 3.6 (both for the tests and python_requires='>=3.6', in setup.py, as it does not make sense to support a Python version which is not covered by CI).

Investigating this a bit further, it seems that ubuntu-latest is now 22.04 and Python 3.6 is not supported there in GitHub actions: https://github.com/actions/setup-python/issues/544
See also this versions manifest: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json
One possibility would be to do the following changes:

add a new os ubuntu-20.04 to the list of platforms, in order to keep testing python 3.6
create a new exclude rule for os ubuntu-latest and python 3.6
while we're at it, add python 3.11

WDYT? I'd be happy to create a PR for that.

I had to update a bunch of dependencies quite carefully and now it seems like CI should work. However, I get (randomly, AFAICT) internal errors for some jobs when the actions run: https://github.com/mjpost/sacrebleu/actions/runs/4938094678
Github reports no outstanding warnings or issues though, so maybe simply re-running the CI pipeline in a few hours could be worth a try? (I don't have permissions to do that it seems.)


Refactor and add tests to LengthUtils

Description
Refactored LengthUtils

Moving formatting a distance into its own method
Adding more error handling
Improve Javadocs

Added lots of tests to LengthUtils
Tests performed
Tested 2.9.0-debug-refactor-lengthutils~24669e4f on Galaxy Nexus (emulator) with API level 28. Nearby list looks okay:

All automated tests pass

Codecov Report

Merging #2201 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #2201      +/-   ##
=========================================
+ Coverage    5.77%   5.81%   +0.04%
=========================================
  Files         231     231
  Lines       11604   11608       +4
  Branches     1079    1079
=========================================
+ Hits          670     675       +5
+ Misses      10878   10877       -1
  Partials       56      56

Impacted Files
Coverage Δ

...in/java/fr/free/nrw/commons/utils/LengthUtils.java
91.3% <100%> (+7.09%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 809c0c3...24669e4. Read the comment docs.

100% coverage of LengthUtils :tada:


Document validation of resource types in fhir-server-config.json with whole-system search

Is your feature request related to a problem? Please describe.
We need to document what must be specified in fhir-server-config.json in order for whole-system search to be allowed.
Describe the solution you'd like
Documentation should include an explanation of what is checked and example configurations.
Describe alternatives you've considered
Acceptance Criteria
At least one acceptance criteria is included.

GIVEN [a precondition]
AND [another precondition] WHEN [test step]
AND [test step]
THEN [verification step]
AND [verification step]
Additional context
Add any other context or screenshots about the feature request here.

doc-only change; docs were reviewed

doc-only change; docs were reviewed


Disable BehaviorVillageHeroGift for custom villagers

Describe the bug
Players with "Hero of the village" buff can get "free" stuff from our villager traders that are set to no-ai

we use this villagers to distribute our custom currency

To Reproduce
Steps to reproduce the behavior:

have hero of the village buff
trade with villager
get free loot from our custom items selection dropped for free

Expected behavior
custom villagers should ignore hero of village buff
Screenshots
If applicable, add screenshots to help explain your problem.
Server Software and Version:

Vendor: Tuinity
Minecraft Version: 1.16.5 build #195

This isn't really a bug with WanderingTrades, it's more a vanilla issue where setting no ai doesn't stop their brain from working. I do however have a hacky workaround for this by removing the BehaviorVillageHeroGift from their brains using reflection. If you want to test it out before I push you can join my discord and let me know

Fixed in c3ff960478f9ec75b839c9b2894cb65e74418f6f


TSC Meeting - May 13th, 2018

NOTE: This is Monday at 9am PT
Zoom Meeting link: https://zoom.us/j/975841675
In order to give some more visibility into the topics we cover in the TSC meetings here is the planned Agenda for the next meeting.  Hopefully this will allow people to plan to attend meetings for topics that they have an interest in.  And for folks who cannot attend they can comment on this issue prior to the meeting.  Feel free to suggest other potential agenda topics.
Proposed Agenda

Topic
Owner
Decision/NextStep

Find volunteer to record action items
@namdeirf

Review progress of work on official OAS JSON Schema
@webron

Results of tag naming for draft-features proposals
@webron  & @earth2marsh

Tag alternate-schemas proposal with newly minted tag
@OAI/tsc

Update on Bikeshed vs Respec  voting +(GitHub Pages https celebration)
@OAI/tsc

Review issues with "review" tag
@OAI/tsc

Update on work related to  specification conformance tests
@tedepstein

/cc @OAI/tsc Please add items as you see fit

To follow up from last week, I've been thinking some about Hyper-Schema + OAS best practices but nothing concrete to report yet and no new questions, so unless there's some other schema question for which I'm needed I'll likely skip the call this week.  Hopefully @philsturgeon can make it :-)  (tag! you're it!)

I’m it!
--
Phil Sturgeon
@philsturgeon

On May 13, 2018, at 14:13, Henry Andrews<EMAIL_ADDRESS>wrote:
To follow up from last week, I've been thinking some about Hyper-Schema + OAS best practices but nothing concrete to report yet and no new questions, so unless there's some other schema question for which I'm needed I'll likely skip the call this week. Hopefully @philsturgeon can make it :-) (tag! you're it!)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


[SPARKTA-255] No-time-dependant aggregations

Now we don't depend of the time to aggregate data.
How to aggregate without time
To do it you have to specify it in the policy, in the "timeDimension" field you have to put "none
 "cubes": [
  {
    "name": "testCube",
    "checkpointConfig": {
      "timeDimension": "none",
      "granularity": "minute",
      "interval": 30000,
      "timeAvailability": 60000
    }

Test
All passed.
Test-at updated

Very nice!!
+1

changes done. Thanks @sgomezg

Very nice!! only 3 details, goooood job


"noforwardsecrecy" handler to detect cipher suites not using DHE

Added the "noforwardsecrecy" connection handler to detect TLS ciphers negotiated between client and server which don't support forward secrecy i.e. Ephemeral Diffie-Hellman methods DHE or ECDHE.

Sorry for not commenting here earlier, missed the PR.
Can you make your handler a data handler(and probably a passive one) instead of a connection handler since it just passively checks the connection, you could add it to https://github.com/google/nogotofail/blob/dev/nogotofail/mitm/connection/handlers/data/ssl.py which has similar data handlers.
Also you probably don't need to buffer for the server hello, its small enough to always come in in one recv(), its fine to keep it though but if you do make it store the buffer internally but still pass the traffic through (ie: always return response but store response if you need more data).

Chad - I made the suggested changes to the noforwardsecrecy handler in my local forked repo. If you have a chance have a look before I create a pull request:
https://github.com/mkenne11/nogotofail/blob/010d791f214deed3b07d75318e071f019bd27337/nogotofail/mitm/connection/handlers/data/ssl.py#l99
I did find one app (AirAsia) whose "server hello" response was large and needed to be buffered.
Let me know if I didn't address your last comment i.e. ... store the buffer internally but still pass the traffic through (ie: always return response but store response if you need more data).

You want to make sure to avoid buffering after you've found what you're looking for or you will probably run into issues once it becomes encrypted.
Let me create a base handler that does all the buffering for you, this has been a request I've gotten a couple times already now.

Closed and replaced by PR #98.


chore: typo in compatibility

Fixes #N/A
Description
AKS provider had a pr raised outlining some typos in the repo. Since then we added a typo linter but still will see the upstream typo show up so adding small pr to fix.
How was this change tested?

go test in target repo
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

CI Is failing in presumit but passes locally, new to repo is this error race condition/flakey?
https://github.com/kubernetes-sigs/karpenter/actions/runs/7666490060/job/20894399530
Pod Metrics should update the pod state metrics
/home/runner/work/karpenter/karpenter/pkg/controllers/metrics/pod/suite_test.go:56
[FAILED] in [It] - /home/runner/work/karpenter/karpenter/pkg/controllers/metrics/pod/suite_test.go:58 @ 01/26/24 09:56:15.954
• [FAILED] [0.062 seconds]
Pod Metrics [It] should update the pod state metrics
/home/runner/work/karpenter/karpenter/pkg/controllers/metrics/pod/suite_test.go:56
[FAILED] Expected success, but got an error:
<*errors.StatusError | 0xc000332320>:
namespaces "default" not found
{
ErrStatus: {
TypeMeta: {Kind: "", APIVersion: ""},
ListMeta: {
SelfLink: "",
ResourceVersion: "",
Continue: "",
RemainingItemCount: nil,
},
Status: "Failure",
Message: "namespaces "default" not found",
Reason: "NotFound",
Details: {Name: "default", Group: "", Kind: "namespaces", UID: "", Causes: nil, RetryAfterSeconds: 0},
Code: 404,
},
}
In [It] at: /home/runner/work/karpenter/karpenter/pkg/controllers/metrics/pod/suite_test.go:58 @ 01/26/24 09:56:15.954
Local
~/dev/karpenter-core/pkg/controllers/metrics/pod (bsoghigian/cringe-typo*) » go test                                                          sillygoose@Bryces-MacBook-Pro
Running Suite: PodMetrics - /Users/sillygoose/dev/karpenter-core/pkg/controllers/metrics/pod
Random Seed:<PHONE_NUMBER>
Will run 3 of 3 specs
•••
Ran 3 of 3 Specs in 3.334 seconds
SUCCESS! -- 3 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok      sigs.k8s.io/karpenter/pkg/controllers/metrics/pod       3.952s

new to repo is this error race condition/flakey

There's an issue in upstream controller-runtime that needs to get fixed: https://github.com/kubernetes-sigs/karpenter/issues/887

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 6 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 80.396%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
7751

Relevant Lines:
9641

💛  - Coveralls


Add config and install resource

Add Config and Install resources

          2 Errors

:no_entry_sign:
Please provide a summary of your Pull Request.

:no_entry_sign:
Please include a CHANGELOG entry.

          2 Warnings

:warning:
This is a big Pull Request.

:warning:
This Pull Request is probably missing tests.

  Generated by :no_entry_sign: Danger

Hey @damacus
Could you take a look at the conflicts here and decide if we want this or not?
Thanks

@damacus is this something we want still?

Yeah probably. Unless someone else wants to resource-ify this cookbook.

Closing due to inactivity.
If this is still wanted please reopen or open another pull request. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help!
Thanks,
Sous-Chefs


checkpoints of pre-training

Thank you for your excellent work! Could you please provide the checkpoints of pre-training?

@GrimaceLittleBoss Sorry for late reply from Github. Besides the s4 checkpoints I sent via email, I uploaded all checkpoints  and logs for StarNet and included in the model python file. You can directly load via "pretrained=True".
Thanks for your interest, please feel free to let me know if any other questions or concerns.
Best,
Xu


Is there a provision to add Minimize and Maximize the chat window

@OvidijusParsiunas Do we have a provision to add Minimize and Maximize the chat window for deepchat.

Hi @prabhakar1994, the ability to minimize/maximise the chat component does not come with Deep Chat as it is very case speicific, therefore it should be controlled by the container element in the parent application.

Thank you @OvidijusParsiunas. I think this would be a good enhancement. But as you suggested (Can be controlled by the container element in the parent application). I have done that. Thanks again for quick help.

Good to hear it works @prabhakar1994.
The Deep Chat project is currently focused on improving the chat component's experience as there are many features still to be introduced. Minimize/Maximise functionality would ofcourse be nice to have, but that falls under the category of external optional components which require a new element outside of the chat container that some users may need for their use-cases. Hence it may be released as a separate component in the future. Stay tuned for further updates on this.


Integrate ADK framework into Runtime and SDK

Migration the following functionality from the ADK external framework into the Runtime and the SDK.

External command configuration
Code block functionality
Code builder functionality

Completed first pre release SDK deployed to nuget. Runtime installer vsix still in internal and partner testing.
https://www.nuget.org/packages/CodeFactory.WinVs.SDK/2.23149.1-PreRelease


fix bug in after date in sleeploglist func

Noticed this bug in the get Sleep Log List function

Thanks, good catch!


perf: improvement github CI process

Initial checklist

[x] I read the support docs
[x] I read the contributing guide
[x] I agree to follow the code of conduct
[x] I searched issues and couldn’t find anything (or linked relevant results below)
[x] If applicable, I’ve added docs and tests

Description of changes
TODO

Codecov Report
Patch coverage: 57.41% and project coverage change: -40.90% :warning:

Comparison is base (3de24f8) 100.00% compared to head (eaa3796) 59.10%.
Report is 120 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##              main     #101       +/-   ##
============================================
- Coverage   100.00%   59.10%   -40.90%
============================================
  Files           12       17        +5
  Lines          316      604      +288
  Branches        22       39       +17
============================================
+ Hits           316      357       +41
- Misses           0      247      +247

Files Changed
Coverage Δ

packages/core/src/index.ts
100.00% <ø> (ø)

packages/build/src/index.ts
10.75% <10.75%> (ø)

packages/build/src/_esbuild.ts
21.87% <21.87%> (ø)

packages/utils/src/escalade/sync.ts
29.16% <29.16%> (ø)

packages/build/src/plugin/dts.ts
30.00% <30.00%> (ø)

packages/logger/src/index.ts
34.21% <34.21%> (ø)

packages/config/src/index.ts
63.63% <63.63%> (-36.37%)
:arrow_down:

packages/utils/src/errors.ts
80.00% <80.00%> (ø)

packages/config/src/load.ts
80.58% <80.58%> (ø)

packages/config/src/_default.ts
100.00% <100.00%> (ø)

... and 7 more

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Codecov Report
Patch coverage: 57.41% and project coverage change: -40.90% :warning:

Comparison is base (3de24f8) 100.00% compared to head (6648751) 59.10%.
Report is 120 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##              main     #101       +/-   ##
============================================
- Coverage   100.00%   59.10%   -40.90%
============================================
  Files           12       17        +5
  Lines          316      604      +288
  Branches        22       39       +17
============================================
+ Hits           316      357       +41
- Misses           0      247      +247

Files Changed
Coverage Δ

packages/core/src/index.ts
100.00% <ø> (ø)

packages/build/src/index.ts
10.75% <10.75%> (ø)

packages/build/src/_esbuild.ts
21.87% <21.87%> (ø)

packages/utils/src/escalade/sync.ts
29.16% <29.16%> (ø)

packages/build/src/plugin/dts.ts
30.00% <30.00%> (ø)

packages/logger/src/index.ts
34.21% <34.21%> (ø)

packages/config/src/index.ts
63.63% <63.63%> (-36.37%)
:arrow_down:

packages/utils/src/errors.ts
80.00% <80.00%> (ø)

packages/config/src/load.ts
80.58% <80.58%> (ø)

packages/config/src/_default.ts
100.00% <100.00%> (ø)

... and 7 more

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


__NO_MIDI__ define screws up ptk.cfg parsing on startup.

When the __NO_MIDI__ define is passed into the preprocessor, the parse of ptk.cfg fails with a segfault/coredump.  If there isn't a ptk.cfg file present, the program works with the default entries.  Tested on Haiku 64-bit and Linux 64-bit.

Can't reproduce the bug.

It may just be the Haiku branch I was working on.


feat(coral): Add connector update route and page behind a FF

About this change - What it does

adds Edit connector page
adds route rendering Edit connector page
fix link in EntityHeader
add feature flag

🤔  Didn't we agree that we'll do the "edit a request" after we finished the React migration?

This is editing a connector, not a request for a conector ^^

I think we should change the file names from edit-request to request-edit  to match with the naming convention we're trying to establish.

I think the file names naming conventions are also pretty weird, especially the page component which do not follow the normal casing for React component :o Maybe that can be another issue?

I think the file names naming conventions are also pretty weird, especially the page component which do not follow the normal casing for React component :o Maybe that can be another issue?

Ah good point.
The initial idea for pages/ was to match our routing and only have index.ts files.
Like this:

But we did not really enforce this 100%.
So we should align that, which would solve the naming also?
(will go ahead and merge this, we can reorder that in a separate PR!)

Ah yes, with an index it makes sense!


Implement station watcher which check number of dock available when getting close to a station

User should be able to set a watch given a certain time and certain date around a station
When user is moving closer to the station (here is how to simulate that), he should receive an notification if the station has a number of dock under the threshold it ask

Task list

[x] Design the GUI for setting a geofencing: it should be very similar to the alarm clock of android, allowing to setup days of week and time of day where the user want the geofencing to be active  cf issue23
[x] Create a station fragment where edits can be made. - cf issue14
[x] Integrate the GUI inside the fragment
[ ] Edit made in the geofencing gui should allow to create a geofence and register it to the system. When rebooting the device, created geofence should still be registered again
[ ] Trigger of the geofence should send a notification to the user if there is not enough dock on the target station

Resources:
https://developers.google.com/android/reference/com/google/android/gms/location/Geofence.Builder#setCircularRegion(double, double, float)
https://developer.android.com/training/location/geofencing
https://developer.android.com/guide/components/broadcasts

https://developer.android.com/training/location/geofencing

https://developer.android.com/guide/components/broadcasts

should use phone and https://play.google.com/store/apps/details?id=fr.dvilleneuve.lockito&hl=en_US&gl=US instead of emulator

Check this repo for android recommendation
https://github.com/android/location-samples/tree/master/Geofencing/app/src/main


vdc helm chart fails - IGC connector OMRS-AUDIT-0035

Using the odpi-egeria-vdc helm chart with the following override
ie
helm install vdc odpi-egeria-vdc -f ~/etc/cloud_igc.yaml

where the yaml contains: (hostname/ip obfuscated)
ibmigc:
  enabled: true
  internal:
    enabled: false
  external:
    enabled: true
    ip: "111.222.333.444"
    hostname: "igc.openmetadata.mydomain.com"
    ports:
      https: "9446"
      broker: "59092"

results in all the pods etc starting up. However the IGC proxy fails to initialize correctly with:
Fri Jan 03 14:31:48 GMT 2020 ibmigc Exception OMRS-AUDIT-0035 The connector to the local repositorys event mapper failed with a {0} exception and the following error message: {1}

Two issues here
a) The audit message is incorrectly formatted - preventing customer PD
b) Why the actual failure
The same error was reported  on slack at https://odpi.slack.com/archives/CBPRDQPRC/p1578028854030200 -- this was running locally, not using containers. I tried the helm chart to get my own environment working for debugging and comparison.

a) It looks like all of the messages in OMRSAuditCode use numerically-indexed formatters {0}, {1}, etc -- whereas our other classes all seem to just use {} with the order implied by the order the arguments are passed to the formatting method (?)
b) This is likely due to either not being able to resolve the address between the host running Egeria and the IGC hostname, or that the IGC host's Kafka bus believes it is a different hostname than the one it was initially called on.
I'll try to do some further testing related to (b) on my side and see if I can add more meaningful audit log messages on the IGC event mapper side...

Enabled debug (should not be needed)
Errors include:
2020-01-03 14:50:41.503 ERROR 1 --- [nio-8080-exec-1] o.o.o.a.r.ConnectorConfigurationFactory  : Bad connectorProviderClassName: org.odpi.egeria.connectors.ibm.igc.repositoryconnector.IGCOMRSRepositoryConnectorProvider
2020-01-03 14:50:41.869 ERROR 1 --- [nio-8080-exec-5] o.o.o.a.r.ConnectorConfigurationFactory  : Bad connectorProviderClassName: org.odpi.egeria.connectors.ibm.igc.eventmapper.IGCOMRSRepositoryEventMapperProvider

Ah, that's a case of not even being able to find the IGC connector classes at all -- so to audit that we'll need to do something on Egeria core side...  Will take a look at what's feasible.

It's hitting the exception in ConnectorConfigurationFactory:
      if (connectorProviderClassName != null)
        {
            try
            {
                Class      connectorProviderClass = Class.forName(connectorProviderClassName);
                Object     potentialConnectorProvider = connectorProviderClass.newInstance();

                ConnectorProvider  connectorProvider = (ConnectorProvider)potentialConnectorProvider;

                connectorType = connectorProvider.getConnectorType();

                if (connectorType == null)
                {
                    connectorType = new ConnectorType();

                    connectorType.setType(this.getConnectorTypeType());
                    connectorType.setGUID(UUID.randomUUID().toString());
                    connectorType.setQualifiedName(connectorProviderClassName);
                    connectorType.setDisplayName(connectorProviderClass.getSimpleName());
                    connectorType.setDescription("ConnectorType for " + connectorType.getDisplayName());
                    connectorType.setConnectorProviderClassName(connectorProviderClassName);
                }
            }
            catch (Throwable classException)
            {
                log.error("Bad connectorProviderClassName: " + classException.getMessage());
            }
        }

As you say... not finding the class it would seem. Will check loader etc.

From the spring docs at vdc-odpi-egeria-vdc-ibm-igc-d64b9bb6c-wd7d4 I'm inclined to think LOADER_PATH (which is set in the container - as per the yaml) needs to get set to the actual archive (jar) not just the containing directory, since the archive isn't unpacked

It's more likely that the jar filename is no longer correct as I've  changed the assembly method for them...  Please leave this for a few minutes while I fix 😉

That could be another change -- though I made the change before seeing that last post, and it seemed to resolve the jar issue

Correction - that didn't work. will wait until you're ready then can retest with correct connector.

a) It looks like all of the messages in OMRSAuditCode use numerically-indexed formatters {0}, {1}, etc -- whereas our other classes all seem to just use {} with the order implied by the order the arguments are passed to the formatting method (?)
b) This is likely due to either not being able to resolve the address between the host running Egeria and the IGC hostname, or that the IGC host's Kafka bus believes it is a different hostname than the one it was initially called on.
I'll try to do some further testing related to (b) on my side and see if I can add more meaningful audit log messages on the IGC event mapper side...

Umm ... All auditlog classes should be using the numberically indexed formatters because these are translatable messages and the order can/will change with different languates - which modules are not using number?

All auditlog classes should be using the numberically indexed formatters because these are translatable messages and the order can/will change with different languates - which modules are not using number?

You're right -- I thought I'd seen non-numerically-indexed at some point in the past, but having a quick look through now they all do appear to be numerically-indexed.

To the larger issue above, though, it doesn't look like we have access to an audit log within the ConnectorConfigurationFactory, which we'd need to be able to record the cause of this issue to the audit log rather than logging (?)

To the larger issue above, though, it doesn't look like we have access to an audit log within the ConnectorConfigurationFactory, which we'd need to be able to record the cause of this issue to the audit log rather than logging (?)

I'm thinking that we should remove the try/catch logic inside getConnectorType() ?  That way any exception (like ClassNotFound) is instead propagated upwards and eventually logged by a captureRuntimeException() rather than being swallowed in this way by a non-auditlog sink when the exception is caught inside getConnectorType() (?)

Hmm...  it seems that some of the calls use a class that's known at compile-time, and others where the class is provided at runtime.  I think for those where the class is provided at runtime we should allow things like ClassNotFoundExceptions to flow upwards, though for those where it is compile-time-determined we might well simplify by catching?
Catching and swallowing any exception regarding a class that is only known at runtime seems to be the fundamental problem here.
I'll put together a PR along these lines...

The connector does load fine now, so the original issue is resolved - just got caught in the refactoring time window. The original client issue may be the same - or user error.
That leaves the exception management which I see you have a PR for now - thanks
I think we can therefore close.


Multi-data source (same host:port) gets db.instance data error #4941

Please answer these questions before submitting pull request

Why submit this pull request?

[ *] Bug fix

[ *] New feature provided

[ ] Improve performance

Related issues
#4941

Bug fix

Bug description.

How to fix?

New feature or improvement

Describe the details and related test reports.

Your codes are not passing the CI. Please fix.

I am not sure your fix. Why remove old cache? This could be performance issue.

The ConnectionCache here uses host:port to make the key, in the case of shard tables or multiple data sources (if a database instance has many database, hos and port will be the same) get the db.instance (intercepted from url) is not accurate database name .
Here's just parsing url.  An ip:port is a unique address in the network, where there are many instances? Where are they?

More importantly, why you could have a different result from URL parsing? Could you share more details about what you are doing?

 An ip:port is a unique address in the network, where there are many instances? Where are they?

sns01-sns0 host:port same(sns01 is database name)
sns05 - sns10 ........
sns11 - sns 16
Three sets of database services

We don't separate the database name, that is another thing. The topology is focusing on the distributed system. You are talking about the multiple databases in one DB process, right?

We don't separate the database name, that is another thing. The topology is focusing on the distributed system. You are talking about the multiple databases in one DB process, right?

Right

Right now, we don't have the intent to separate the database.  I can't tell whether we should or shouldn't, but either of them is not the reason, you break the cache.
If you want to add the database entity as a part of topology and the analysis perspective, you should change the cache to include host:port:db-name, and also change the peer of the span, which could make the database metrics in the DB dashboard separated too.

Right now, we don't have the intent to separate the database. I can't tell whether we should or shouldn't, but either of them is not the reason, you break the cache.
If you want to add the database entity as a part of topology and the analysis perspective, you should change the cache to include host:port:db-name, and also change the peer of the span, which could make the database metrics in the DB dashboard separated too.

In the case of multiple data sources, tags db.instance is currently wrong to take the value of the code.

In the case of multiple data sources, tags db.instance is currently wrong to take the value of the code.

What do you mean wrong? What should it be?

In the case of multiple data sources, tags db.instance is currently wrong to take the value of the code.

What do you mean wrong? What should it be?

because of sns01 sns02 sns03 sns04 host:port same. So there's only one database name in the collection cache. Should be displayed separately

I think that is caused by the usage of Tags#DB_INSTANCE. It saved the database name for now. We haven't given a very specific definition, but it seems like they are treated as the database name in many plugins, I mean for now.
Like this,


Fixes false positive on loadFilesRecursive

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Tests pass?
yes

Fixed issues

When running a functional test with codeception, I wasn't getting a null of UploadedFile::getInstance().
Examining further, I realized that the $errors variable type, on elseif, was a string and UPLOAD_ERR_NO_FILE was a integer, therefore the test was returning true ($errors !== UPLOAD_ERR_NO_FILE).
But the $errors value was "4" (string) and UPLOAD_ERR_NO_FILE is 4 (integer).
intval($errors) worked for me and I see no drawbacks on using it.

Thanks!


Format the LTrim, RTrim, and Trim functions

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

VBA/Language-Reference-VBA/articles/ltrim-rtrim-and-trim-functions.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

VBA/Language-Reference-VBA/articles/ltrim-rtrim-and-trim-functions.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

VBA/Language-Reference-VBA/articles/ltrim-rtrim-and-trim-functions.md
:warning:Warning

Details

VBA/Language-Reference-VBA/articles/ltrim-rtrim-and-trim-functions.md

Line 42: [Warning] Invalid file link:(~/Language-Reference-VBA/articles/worksheetfunction-trim-method-excel.md).
Line 53: [Warning] Invalid file link:(~/Language-Reference-VBA/articles/worksheetfunction-object-excel.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

VBA/Language-Reference-VBA/articles/ltrim-rtrim-and-trim-functions.md
:warning:Warning

Details

VBA/Language-Reference-VBA/articles/ltrim-rtrim-and-trim-functions.md

Line 42: [Warning] Invalid file link:(~/Language-Reference-VBA/articles/worksheetfunction-trim-method-excel.md).
Line 53: [Warning] Invalid file link:(~/Language-Reference-VBA/articles/worksheetfunction-object-excel.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

VBA/Language-Reference-VBA/articles/ltrim-rtrim-and-trim-functions.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

VBA/Language-Reference-VBA/articles/ltrim-rtrim-and-trim-functions.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

All content in this repository has been migrated to a new repository (https://github.com/MicrosoftDocs/VBA-Docs). The changes in this PR have been applied in the new repository, so this PR is being closed. The changes will be published to the live docs soon. Thank you for your contribution!


RegistryCI#master workflow for testing on General

I originally proposed this on #pkg-registration in the Julia slack:

The idea that RegistryCI could break General’s automerge is kinda scary, and while we have integration tests, it’s always a bit of worry that when we bump General we might hit weird edge cases with new package registrations and things could break. Especially because RegistryCI does things like load arbitrary packages, clone git repos, etc, and it can be hard to test every edge case (esp since writing the integration tests isn’t always super easy either).

So I have an idea: what if we sometimes add another workflow to General’s CI which runs RegistryCI#master but does not write comments or influence merging. Then if we want to test something, we can just run that for a few days and then go through and see if we have any spurious failures before cutting a release.

@DilumAluthge mentioned that we need to ensure it doesn't post a comment or create the automerge/decision commit status.

https://docs.github.com/en/actions/reference/authentication-in-a-workflow#modifying-the-permissions-for-the-github_token could be useful to remove all but the minimal read-only permissions from that workflow we need for RegistryCI to run in a dry-run/staging mode. That way General can rest assured that the unreleased code won't do anything wonky and mess up the registration process.

Feels like this should be done in a separate repo instead?

Feels like this should be done in a separate repo instead?

We already do that currently (that's what the RegistryCI.jl integration tests do).
The motivation for this issue is that we want to make sure that RegistryCI#master doesn't throw any errors when being run on actual General registry PRs, so I think that it has to be done on this repo.
As Eric mentioned, for security reasons, the RegistryCI#master jobs will only have access to a GITHUB_TOKEN with read-only permissions.

The test repo could have a script that mirrors PRs from this repo for testing purposes, no?

The test repo could have a script that mirrors PRs from this repo for testing purposes, no?

That sounds OK to me; is it easy to do?

The test repo could have a script that mirrors PRs from this repo for testing purposes, no?

That sounds okay to me; is it easy to do?

Personally this sounds more complicated to me than just running it on General.
And since presumably the test repo will be in the JuliaRegistries organization, the jobs will still count against the concurrent jobs limit. (The limit of 20 free concurrent jobs is across an entire organization.)
The way we maintain RegistryCI.jl is that the master branch is stable. Any commit on the master branch is stable enough to make a release from. In particular, code is not merged into the master branch until it passes the integration tests.
So this is our current situation:

Make PR to RegistryCI.
Ask Bors to merge. Bors runs the unit tests and the integration tests on the PR. If all tests pass, Bors merged the PR into master.
We register a new release of RegistryCI from master.
We deploy the new release of RegistryCI into production on General.

This is the current situation, and it works very well. However, it doesn't cover one case: the case in which the RegistryCI integration tests pass, but then for some reason RegistryCI breaks in production on real PRs.
In the status quo, if we have this case happen, then AutoMerge will break in production.
With this new staging system, we would do this:

Make PR to RegistryCI.
Ask Bors to merge. Bors runs the unit tests and the integration tests on the PR. If all tests pass, Bors merged the PR into master.
The read-only "AutoMerge" staging job automatically updates to use the latest RegistryCI master.
We observe the staging jobs for a while and make sure that the master branch of RegistryCI does not break in production. If things look good, we register a new release of RegistryCI from master.
We deploy the new release of RegistryCI into production on General. We know that it will not break, because we already tested it in staging on General.

I guess my point is that the code we are running in "staging" is exactly the same code that we currently deploy directly to production. What we are suggesting here is that we first deploy to staging, and then deploy to production.

I guess my question is this: what is the advantage of the staging environment living in a different repository than the production environment (which is the General repository).

I'm not opposed to doing staging in a different repo.
We just have to figure out this part:

The test repo could have a script that mirrors PRs from this repo for testing purposes, no?

To me personally, this sounds like a difficult script to write.


Update transaction and script results to include computation usage

Description
This PR updates the results returned for transactions and scripts to include computation usage.
The rest of the changes in this PR (access nodes) are related to the proto-buff version updates.

For contributor use:

[ ] Targeted PR against master branch
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Updated relevant documentation
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Added appropriate labels

@peterargue we do but I left that for another PR depending on when we decide to update access nodes


Phar file is broken

The official documentation recomend to use http://cs.sensiolabs.org/download/php-cs-fixer-v2.phar but the URL does not returns the last version of cs-fixer.
$ curl -s http://cs.sensiolabs.org/download/php-cs-fixer-v2.phar > /usr/local/bin/cs-fixer  && chmod +x /usr/local/bin/cs-fixer

$ cs-fixer
PHP CS Fixer 2.4.0 Silver Gingerbread by Fabien Potencier and Dariusz Ruminski (63661f3)

whereas CS fixer 2.5.0 is released 3 days ago

Thanks for reporting!
I've confirmed this, as @keradus is currently the only who can resolve this I'm pinging him here.
It will probably resolved after the weekend earliest I'm afraid.

It's not a big issue. Thank you for your work.
Is there a way to automatically update the website with the release process to avoid such issue in the next deployments?

Is there a way to automatically update the website with the release process to avoid such issue in the next deployments?

There is some automation for this in place, but it seems it failed us this time. The new minor version release showed some issues in our deployment scripts and update systems we didn't anticipated .
Some of those we are trying to resolve through updating the code of the PHP CS Fixer itself, some need to be resolved in another matter as we've some limitations on the official sites we release on.
While sadly it takes some more time to get the latest version to our users, it should all be resolvable within the near future.

building was triggered: https://travis-ci.org/FriendsOfPHP/PHP-CS-Fixer/jobs/267204092#L593
yet not executed properly.
website simply provide last build that works fully.
sadly, with last release we crashed phar file, thus it cannot build website to newest version.
We need to fix a phar first.
I changed title of this issue and assigned it to me.
when phar will be fixed, we will release newest version (and that would retrigger website fixing your original issue)


Can read cielo breez plus but can't control it

The display reflects what is current state of the Breez-Plus.  However, I when I issue commands they are not "transmitted" to the device.
I am running 1.7.7
Thanks
Hal

Same issue here.  I tried reloading the integration, restarting HA, and no luck.

Running v1.7.5, same issue, started within the last couple of hours. Thanks.

I also have this issue on 1.7.7. Verified cielo app works but did not try the cielo url.

i can verify too that the URL is not controlling the deivce.  I was able to create some schedules on the web interface that were added to the app.
hal

As of 4am EST (UTC-5) Thursday, December 5, 2024
the control has started working again.  I guess problem corrected at cielo since I didn't make any changes

Same here, it's back!

Yes, now working for me too.  :-)
hal

I can also add that when i added cielo to my HA this week, it was working for a day and then stopped. First my automations did not execute. then i lost control of the dashboard buttons, but my cielo app on phone worked. I since deleted cielo from HA, and now i will try again since there are reports that it started working again.


Title: A project to detect anomalies in time series data

Initiative (Required)
GSSoC (Girl Script Summer of Code) 🌸
Is your feature request related to a problem? Please describe.
The project guides on how to detect anomalies in time series data which are autoregressive.
(for both gssoc-ext and hactoberfest)
Describe the solution you'd like.
Different approaches to detect anomalies(deviation from the expected norm or pattern) of time series data.
Under ML and datascience
Add any other context or screenshots about the feature request here.
No response

@amrutha-m206,
Could you please provide a more detailed description of this issue? Additionally, it would be helpful if you could include some screenshots to help us better understand the situation.
Thank you!


Feature/add on exception join point

Coverage increased (+0.7%) to 95.506% when pulling c5ffe308e2c7182a86d7364d13fa36df08e077ae on alexjoverm:feature/add-onException-joinPoint into 7f6865ca2036117475c145758fd92939f36f9867 on k1r0s:master.

Hi, thanks for the PR, seems pretty good.

I broke lint check :(


What vertical reference is used in the tile data?

It seems like the vertical reference system is not documented anywhere I've looked.  It is EMG96?, WGS84 ellipsoid?  Does the documentation clearly state this somewhere?  Thanks!

There is math documented on how to make the transformations, but that's out of scope for this project. WGS84 generally refers only to the XY coordinates, while EGM2008 also considers Z (height) and change over time because the planet is still shifting around.

I'm not asking for help with the math.  Do you know what the data in the tiles is referenced to?

Why is this closed without an answer or update to the documentation? Is the final answer that they are all referenced to the spheroid then?


Incremental Expansion of Folders

There is currently a performance problem with large directories. This is because the current code recursively lists out all files and folders from the working directory.
To fix the issue, we can consider only listing out files and directories within a given folder only after the user expands it. That way, only the first level of the recursion would run on page load, then more would be read in as the user expands folders in the sidebar.
A great example of this is node_modules, which takes some time to traverse.

This is pretty critical as it breaks when you try VZCode in any directory that has node_modules.
We might just need to handle or ignore symlinks. This is the error I get:
$ vzcode .
node:fs:1444
  handleErrorFromBinding(ctx);
  ^

Error: ENOTDIR: not a directory, scandir '/home/curran/repos/vizhub3/migration2/node_modules/.bin/why-is-node-running'
    at Object.readdirSync (node:fs:1444:3)
    at computeInitialDocument (file:///home/curran/.nvm/versions/node/v19.1.0/lib/node_modules/vzcode/src/server/computeInitialDocument.js:47:8)
    at file:///home/curran/.nvm/versions/node/v19.1.0/lib/node_modules/vzcode/src/server/index.js:28:25
    at ModuleJob.run (node:internal/modules/esm/module_job:194:25) {
  errno: -20,
  syscall: 'scandir',
  code: 'ENOTDIR',
  path: '/home/curran/repos/vizhub3/migration2/node_modules/.bin/why-is-node-running'
}

Node.js v19.1.0


Release Google.Cloud.Vision.V1 version 2.1.0

Changes in this release:

Commit 0790924: fix: Add gRPC compatibility constructors
Commit 0ca05f5: chore: Regenerate all APIs using protoc 3.13 and Grpc.Tools 2.31
Commit 6bde7a3: docs: Regenerate all APIs with service comments in client documentation
Commit 947a573: docs: Regenerate all clients with more explicit documentation
Commit bbccd6f: docs: change a relative URL to an absolute URL to fix broken links.

Created release for Google.Cloud.Vision.V1-2.1.0


General Grievance: Watch orientrailjourneys.com

General Grievance requests the watch of the watch_keyword orientrailjourneys\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

orientrailjourneys\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.


Update add-appxpackage.md

#1158
Run the following step:
1.) Was able to run cmd successfully: "Add-AppxPackage -Path "C:\Users\myapp.appxbundle""
See screenshot: https://snipboard.io/EK58W0.jpg
2.)Was able to run the ff cmd successfully:  just followed the article for creating .appinstaller file '' https://docs.microsoft.com/en-us/windows/msix/app-installer/app-installer-file-overview'' and ''https://docs.microsoft.com/en-us/windows/msix/app-installer/how-to-create-appinstaller-file''
Add-AppxPackage -AppInstaller "C:\myapp.appinstaller"
Add-AppxPackage -AppInstallerFile "C:\myapp.appinstaller"
see screenshot:
https://snipboard.io/Iapsnl.jpg
result screenshot:
https://snipboard.io/DdR6vz.jpg
References:
https://docs.microsoft.com/en-us/uwp/schemas/appinstallerschema/app-installer-file
https://docs.microsoft.com/en-us/windows/msix/app-installer/app-installer-file-overview
https://docs.microsoft.com/en-us/uwp/schemas/appinstallerschema/schema-root
https://social.technet.microsoft.com/Forums/en-US/5ca76ca0-c816-4e4d-aaa3-e21ec4c000bd/addappxprovisionedpackage-with-an-appinstaller?forum=win10itproapps

Docs Build status updates of commit ca985f9:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docset/windows/appx/add-appxpackage.md
:warning:Warning

Details

docset/windows/appx/add-appxpackage.md

Line 412: [Warning] Invalid file link:(~/windows/appx/msix-src/app-installer/how-to-create-appinstaller-file.md).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 9b9e5b0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/appx/add-appxpackage.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@dariomws306 @get-itips @tseward
Peer review needed for this PR. Thanks.

Confirmed the switch is in Win 10 1903. Are you able to update the description of the switch -RegisterByFamilyName?

Docs Build status updates of commit 1f1da85:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/appx/add-appxpackage.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@Tseward , updated the description of the switch -RegisterByFamilyName , feel free to let me know of any changes needed.

Docs Build status updates of commit ed716b3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/appx/add-appxpackage.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@get-itips Are there any additional comments? Thanks.

cc @sukihanabi


Bug: logs key required for rules that use datatypes

What
https://github.com/airbnb/streamalert/pull/285 introduced data normalization.
An intended side effect was the the logs key was not required if the datatypes key is provided.
Example:
@rule(datatypes=['command'])
def alert_suspicious_wget(rec):
    results = fetch_values_by_datatype(rec, 'command')
    for result in results:
        if fnmatch(result, "wget *"):
            return true
    return false

However, this doesn't match reality. If you don't specify logs, you get the following:
StreamAlert [ERROR]: Invalid rule [...] - rule must have 'logs' declared
Workaround
Define all relevant logs in the logs key for rules that use data normalization.
Expectations

if the datatypes key exists, logs is not required, it's optional
if the datatypes key does not exist, logs is required

This is now fixed


don't miss validator state transitions

fixes #1453
if you have a wallet that will witness the specific state transition, please test

closed by https://github.com/penumbra-zone/web/issues/1453#issuecomment-2270836323


Add dnnl_dim_t cast to fix executor windows failure

Type of Change: bug fix
API not changed
Description

As title, as well as fixing narrowing conversion problems in qbit
Compilation portability of qbit: use c++20 as MSVC does not have a feature switch for concept (-fconcept of GCC).
Circumvent a potential MSVC bug that prevent using } just after #progma omp barrier inside a template.

Expected Behavior & Potential Risk
the expected behavior that triggered by this PR
How has this PR been tested?
how to reproduce the test (including hardware information)
Dependency Change?
No

build wheel success: https://inteltf-jenk.sh.intel.com/job/nlp-release-build-win/246/

@DDEle please see here: /usr/bin/ld: dispatcher/libjblas_dispatcher.a(jblas_weightonly_dispatcher.cpp.o): relocation R_X86_64_PC32 against symbol `__libc_single_threaded@@GLIBC_2.32' can not be used when making a shared object; recompile with -fPIC /usr/bin/ld: final link failed: bad value collect2: error: ld returned 1 exit status ninja: build stopped: subcommand failed.

Fixed in 9811d5e: https://github.com/intel/intel-extension-for-transformers/actions/runs/6256362380/job/16987076494?pr=347#step:4:1

windows UT pass：https://inteltf-jenk.sh.intel.com/job/nlp-ut/279/


Doc: aws in Global

Includes methods like aws.getRegionOutput().name
Useful for getting info on the current provider.
https://www.pulumi.com/docs/concepts/resources/functions/#provider-functions

Closed with #152