[ENH] Getting the ball rolling on #945

PR Description
First order of business: No automated tests, sadly. Not because I didn't feel like it or didn't want to- but rather pytest was giving me trouble and I wanted to get a bit of feedback before wasting too much time. It took me longer than I'd like to admit to throw in the towel on that one.
Testing WOULD be done with the included  manual_read_command(string:str) in case any body wants to take up the mantle with that real quick.
Second: I did manual testing using a publicly available .csv spreadsheet of data, which I have named sep-quarter.csv. For those unfamiliar: argv is used to represent the commandline arguments. argv[0] is always the filename (thus python or python3 are not included in the argument list) and everything from argv[1] until end-of-line is an additional command.
I have tested the following use cases:
python3 <filename>.py cat sep-quarter.csv creates a pandas df from the .csv file, which in my testing is a big dataframe. About 19000 rows.
python3 <filename>.py 'cat sep-quarter.csv | grep '.SEA1AA' '  creates a pandas df only from the infromation in the .csv file that contains .SEA1AA, which in my testing results in 41 rows. Much smaller, and only containing information relevant to what was queried, in this case, anything with .SEA1AA in one of its columns.
NOTE: the entirety of argv[1] and beyond needs to be in a string for this, it doesn't work when it's not in quotes. The command I mentioned above this one however does work, with or without quotes. Unfortunately, when working with the shell there's always the possibility of a conflict: I think the | grep ... line tells the shell that the grep is a different command, so the shell will execute python 3 <filename>.py cat sep-quarter.csv  and then grep '.SEA1AA' separately, which naturally yields an incorrect result for the df.
python3 <filename.py>  'unzip -cq sep-quarter.csv.zip'  (in quotes for the same reason as above): Will unzip the .csv file before creating a df out of the contents within. This creates an identical df to the first command I mentioned.
I have included the .csv files in the branch, both zipped and unzipped. Those can be moved deleted at will, they're just there for testing.
**This PR lays the foundation for resolving #945 **
Relevant Reviewers

Please tag maintainers to review.

@ericmjl

Heard, thank you both.
I'll accept some or all changes suggested by @ericmjl and get to work refactoring to look more in line with what @samukweku has laid out. A word of 'warning' is that I tend to work slowly on stuff I'm not being paid for (because I'm tired from working on stuff I do get paid for), I'll probably take a few days for this.

Not a problem! We’re all volunteers here on this project, so it’s
totally reasonable :).
Can I check, did you enable allowing maintainers to push to the PR
branch? If so, I might help move some things along, though I’m also busy
with another PR to the repo.

According to the little check box, moderators are allowed access and edit, so they should be allowed to push, correct?

I think that's right! Thank you for confirming, @BaritoneBeard!

@samukweku  I think I'm missing something. Because I don't use pandas (I'm here for that sweet, sweet open source contribution experience, so I only know the bare basics in order to test that my stuff works) I'm not really sure of what exactly it is that's missing. The template you supplied passes the manual tests: it can make a df out of the commands I tested earlier in the pr -
#%%
df = read_commandline('cat sep-quarter.csv | grep BDCQ.SEA1AA')

df

makes a df of 41 rows as before when the cell is run.
if this is all you needed the function to do, then it looks like you didn't even need me, as the template did all the work.
On Testing: Pytest is giving me trouble despite trying my usual methods of making it work (pytest seems to be very fickle, it breaks every time I fork a repo). I've written plenty of tests before, so I can try to write some blind tests. Alternatively, my other test suite Behave would probably work for this and I can write some tests in there and translate those working tests into pytest ones, but again those translated tests would be blind. Should I give some blind testing a go?

if this is all you needed the function to do, then it looks like you didn't even need me, as the template did all the work.

@BaritoneBeard no, not at all! Your contribution is highly valued, even if the final PR ends up using something very close to what we've provided. This is because it takes care, time, and effort to not only implement the function but also to document it and test it sufficiently for others to use :smile:.
As for why the CI is failing, in this case, it's because the test coverage on the newly added code is below the target that we wish to hit. We measure test line coverage percentage and require it to be above a certain number as a first gatekeeping measure to ensure that there is high test coverage on the codebase. (That doesn't ensure the quality of tests, which is another matter, but on thoughtfully maintained repos, quality and percentage are correlated.)
To get the PR over the line, I think we need at least one software test. Here are a few ways we can proceed.
Firstly, can you move the newly added function into the janitor.io submodule? This is because it's a function that handles data I/O, rather than a data preprocessing function, akin to read_csvs in there.
Secondly, can you then add a test for read_commandline, perhaps mimicking this file?
Thirdly, can you remove the files seq-quarter.csv and sep-quarter.zip from the PR? We can create the test data on the fly rather than rely on pre-created data by using some of the provided test fixtures that we have. The pattern you can use for writing the test is as follows:
def test_read_commandline(dataframe):
    # set up the test
    dataframe.to_csv("/tmp/dataframe.csv")
    df = janitor.read_commandline("cat /tmp/dataframe.csv")
    # make assertion in the test
    assert pd.assert_frame_equal(dataframe, df)
    # clean up after the test
    Path("/tmp/dataframe.csv").unlink()

That test uses a magical variable, dataframe, that is provided as a "test fixture" for all of our tests. There are other magically available dataframes that you can use, they are discoverable here, and basically only need to be placed in the test function signature for the test body to be aware of them.

@ericmjl
First, thanks for the reaffirming words, the reason I came back to try my hand at another PR here was because you all were so welcoming the first time, so it's good to see nothing's changed on that front.

Firstly, can you move the newly added function into the janitor.io submodule?

Right, forgot to do that, consider it done.

Secondly, can you then add a test for read_commandline,

No problem, as I said though, my pytest is on the fritz and I have no way of making sure the tests work or pass their assertions. I can write the tests but that's about it. Do reviewers get emails every time I push? I know the workflow runs all tests each push so worst case I can push tests if it's not an inconvenience to anybody else but myself. Before that though I'll obviously see if I can get pytest working with a pair of fresh eyes tonight.

Thirdly, can you remove the files seq-quarter.csv and sep-quarter.zip from the PR?

Absolutely. I planned to remove them before the final push anyway. Thanks for highlighting how to better use the tests available.

@ericmjl  All green here, let me know if anything else jumps out.
@thatlittleboy I looked around a little bit for docs on python utils check function but couldn't find any, I know it exists but I guess the word "check" is a little too ubiquitous to reliably get search or ctrl-F results. I implemented raising TypeError without it though. If you feel the PR would benefit from using check over/in addition to what's provided then would you mind pointing me in the direction of some docs? Thanks!

@BaritoneBeard the check function is the first in the utils section here

@samukweku Your suggestions have been implemented.
(By the way I was looking for check in python's utils instead of janitors, I guess I need a nap. Thanks for the assist).

@BaritoneBeard they are all spark errors. In #986, I asked @thatlittleboy to mark them all as xfail; they are very flaky. Once that's merged in, we'll have you merge in the latest dev commits and the tests will re-run; I'm confident they'll pass.

Hitting da merge button!


M5stack core basic, SIM7600G, OTA, invalid segment length

Hi felmue
I used your code 'OTAoverLTE.ino', which seems to work seamlessly until the end. But then there is an error message about an 'invalid segment length'.
Here is the response I get:
Modem Info: ATI  Manufacturer: SIMCOM INCORPORATED Model: SIMCOM_SIM7600G-H Revision: SIM7600M22_V2.0.1 SVN: 01 IMEI: 8xxxxxxxxxx2 +GCAP: +CGSM
Waiting for network... success
Network connected
Connecting to internet success
GPRS connected
Connecting to xxxxxxx.ch success
Waiting for response header
HTTP/1.1 200 OK- - Date: Wed, 24 May 2023 12:23:36 GMT- - Server: Apache- - Upgrade: h2,h2c- - Connection: Upgrade, close- - Last-Modified: Wed, 24 May 2023 11:11:02 GMT- - ETag: "5xxxxxxxxxxxxxx5"- - Accept-Ranges: bytes- - Content-Length: 388720- - Content-Type: application/octet-stream- - - - Content-length: 388720
Update begin ok
Reading response data
0.00%
7.69%
15.38%
23.08%
30.77%
38.46%
46.15%
53.85%
61.54%
69.23%
76.92%
84.61%
92.31%[73261] ### Closed:  0
100.00%
100.00%
E (74036) esp_image: invalid segment length 0xffffffff
Error Occurred. Error #: 9
Server disconnected
GPRS disconnected
Content-Length: 388720
Actually read:  388720
Duration:       54.70s
Do you have any clue what I may be doing wrong?
Thanks and kind regards, Dan

Hello @Dan-Kiefer
have you tried multiple times? And if yes, does it always fail after the same amount of downloaded data?
Here are some ideas:

have you tried a different server?
have you tried a different power source?
have you tried a different position for the modem?
have you tried a different (size) firmware file?

Note: the modem I have is a SIM7600G (without the H) which I think means lower speed. Shouldn't make a difference though.
Thanks
Felix

Hi felmue
thanks for your prompt reply!
Yes, I tried many, many times, with always the same result. Playing with different delays and timeouts didn't help.
Yes, I have tried different positions of the modem.
No, I have not yet tried with a different power source. So far the symptoms do not make me suspect the hardware. 92.31% is always the end, regardless of the length of the file and the duration of the transfer. This does not look like a power supply problem. Do you agree?
As the numbers 'Content-Length:' and 'Actually read:' were the same, I didn't question whether the data actually arrived on the M5. The file size corresponds exactly to the file size shown by windows explorer. Therefore I thought, the file was received correctly. It's only now that I realize that the 'closing' always takes place after 92.31%. No idea what the 100% in the serial monitor means though. Do you know more about this?
Even with the smallest program possible (draw 'Hello' on the screen), the closing takes place after 92.31%.
The same thing happens with a program three times the size. The duration also triples, but the 'closing' still happens after 92.31%.
0.00%
7.69%
15.38%
23.08%
30.77%
38.46%
46.15%
53.85%
61.54%
69.23%
76.92%
84.61%
92.31%[176859] ### Closed:  0
100.00%
100.00%
E (177551) esp_image: invalid segment length 0xffffffff
Error Occurred. Error #: 9
Server disconnected
GPRS disconnected
Content-Length: 1122640
Actually read:  1122640
Duration:       157.81s
I played around with the size of 'TINY_GSM_RX_BUFFER', which didn't help, but slightly changed duration of the process.
So far I did not question the server (hostpoint), because the OTA worked fine when I used the ESP32's WiFi functionality. The problem is only with the SIM7600G module. Also I don't have another server available. This evening I will try to access xampp on my laptop from outside. Not yet sure how to achieve that.
Or do you know of a public http server with test binaries for ESP32 that I could test this with?
Thanks again, Dan

In my last post I asked for a public http server with a binary for testing. There is actually an example for https. But as TinyGSM is not yet ready for https for the SIM7600 module, I have to work with http.
Regards, Dan

Hello @Dan-Kiefer
I don't know if the error means incorrect / not complete download or if it means something is going wrong later on when checking the downloaded file.
Since my code is based on the file download example from here; maybe you could try to see if that works any better?
Thanks
Felix

Hello Felix
just double checked it with the file you linked. It provides the same result.
Now I printed to the serial monitor all characters received. I can clearly see all Bytes of the file transmitted. 8 of them actually arrive after the '100% 100%' written by the 'Update.h'. There are 8 additional bytes at the start of the transmitted data, in front opf the data of the actual file. I guess that must be some kind of header. I will now try to somehow drop these first Bytes and see what happens.
Regards, Dan

Hello @Dan-Kiefer
Firstly: just noticed - you might want to redact your IMEI in your first post.
I've rerun the example here a couple of times and it worked every time. I think in your case the actual download works fine as it reaches 100%. But yes, the actual data might be incorrect so I am curious about what you find.
In the mean time I am wondering if something goes wrong writing the data to the flash, so

have you tried to fully erase the flash?
have you tried with a different ESP32?

Thanks
Felix

Hello Felix
Yes I tried with another ESP32. Same result.
But: Yesterday I was confused about the '100%' message on the serial monitor, which was displayed before the last 8 bytes arrived. This is actually due to the fact that the 'printPercent' routine is called in an if-clause with a modulo operator in its condition. If the number of bytes is not a multiple of 13, the 100% are displayed too early. In my case it was 8 bytes before the end of the data. Which is not a problem, it just lead me to wrong conclusions.
 I compared the data received with a hex editor, they are all perfect. It's just the update that goes wrong.
Regards, Dan

Thank you for the hint regarding IMEI.

As you see, I am new to this forum. Do you think it might be useful to ask the question concerning the 'esp_image: invalid segment length 0xffffffff' to the creater of 'Update.h'. Or will that be considered a 'double posting'?
Thanks for your advice!

Hello @Dan-Kiefer
I think that would be ok. My experience is that asking doesn't cost much and being polite, like you are, helps as well.
Thanks
Felix

Hello Felix,
thanks for your help. I just posted the question here. ('awaiting triage', so you may not yet be able to see it.)
Kind regards, Dan

Hello Felix
I was finally able to solve the problem, which was due to a strangely modified library 'Update.h' on my PC. No idea how it got there.
It works fine now, based on your code! Thanks a lot!
Kind regards, Dan


charcode(183) '·' display issue when using nerd font

open terminal in nvy(git dir), and call gitui
type 'f' in files tab
type something
And then, you should see the display issue, I didn't find the way to fix this, So please check yourself

Font: guifont=Maple\ Mono\ SC\ NF:h12

this font doesn't contain the charcode(183)


paperwork: Patch broken libreoffice path

Description of changes
Due to the changes in #219166, no suitable path to libreoffice was found. I am working on getting this patch into upstream, but have opted to fixing this like so in nixpkgs since this is a somewhat nixpkgs specific regression.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I see that you submitted the patch upstream (thank you!) and that it was accepted. Can you rewrite the PR to use fetchpatch instead? (fetchpatch is preferred so that the size of nixpkgs as a git repo increases less, even though for such a small patch the difference is small)

Thanks for the reminder @symphorien ! I've updated it.

@GrahamcOfBorg eval


Bringup slice op

Bringup slice op

@sdjordjevicTT Ah my apologies. I was tasked with bringing up multidevice support in tt-xla. When sharding inputs, JAX generates slice ops to do so and I went forward with implementing that. I can hold off on the merging of this for sure. I get pretty poor functionality out of my bringup here as of right now, so I think the uplift @jserbedzijaTT is bringing along will be helpful.
I'll make this a draft PR now. @jserbedzijaTT Feel free to ping me if you're facing issues with MLIR when bringing this up :)

@sdjordjevicTT Ah my apologies. I was tasked with bringing up multidevice support in tt-xla. When sharding inputs, JAX generates slice ops to do so and I went forward with implementing that. I can hold off on the merging of this for sure. I get pretty poor functionality out of my bringup here as of right now, so I think the uplift @jserbedzijaTT is bringing along will be helpful.
I'll make this a draft PR now. @jserbedzijaTT Feel free to ping me if you're facing issues with MLIR when bringing this up :)

Thanks @LPanosTT! Let's keep this PR in draft for now.


Make contact api response a list

The current task returns a generator which can't be stored in celery

@gsvr review please

:+1: when travis happy


Remove ToolbarAndroid from doc

This PR is part of https://github.com/facebook/react-native/issues/26591#issuecomment-570972727
Removed docs for ToolbarAndroid as it has been removed from the package.

I was late for this PR, noticed this deprecation is handled differently than the other lean core components, such as the`slider, which remains on the doc but with the deprecate message...  Is this different approach intended?


Automatic Multipart/Form-Data parsing

Handling multipart/form-data encoding is not currently supported for forms automatically, and must be called via a request.parseMultiPartFormData().
It would be interesting to have a form of Middleware that would allow the user to specify what they would like done with any automatic multipart form data that is uploaded, such as stored to the temporary folder etc

See https://github.com/elliottminns/blackfish/commit/996b635e3b762d31fee7185d9a8ee63c8c610ebd


Write test suite

Pull Request Test Coverage Report for Build 80988533-7957-4a15-b30e-07dc8230974e

16 of 16 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+29.06%) to 72.33%

Totals

Change from base Build f8689e21-b92a-43f4-8510-0ba482105383:
29.06%

Covered Lines:
149

Relevant Lines:
206

💛  - Coveralls


Fixed SSL Error Bug And Files Not Found in concatenate

Adding SSL Error Bypass, Fix Error If File not Found
I had This Problem When using This with http Protocol It Giving me Error So this Patch will help you all

Thanks @idkwhyiusethisname. I've slightly modified the code. Instead of hardcoding the verify_ssl, I've made it a parameter for the user to decide in case of SSL warnings


feat: implement warning for blind transfer

Implement warning for blind transfer attempt when already on the active line

Task linked: CU-8695ep7vy Error setting ICE locally


1368 accordian cypress

Summary of the changes

Added cypress tests for ic-accordion & ic-accordion-group
Removed old tests from web-components package

Related issue
#1368
Checklist

[x] Relevant unit tests and visual regression tests added.
[x] Visual testing against Figma component specification completed.
[x] All acceptance criteria reviewed and met.
[x] Accessibility Insights FastPass performed.
[x] A11y unit test added and yields no issues.
[x] A11y plug-in on Storybook yields no issues.
[x] Manual screen reader testing performed using NVDA and VoiceOver.
[x] Page can be zoomed to 400% with no loss of content.
[x] Screen magnifier used with no issues.
[x] Text resized to 200% with no loss of content.
[x] Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.
[x] Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
[x] Windows High Contrast mode tested with no loss of content.
[x] System light and dark mode tested with no loss of content.
[x] Manual keyboard testing for keyboard controls and logical focus order.
[x] Min/max content examples tested with no loss of content or overflow.
[x] Browser support tested (Chrome, Safari, Firefox and Edge).
[x] Correct roles used and ARIA attributes used correctly where required.
[x] Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.
[x] All prop combinations work without issue.
[x] Changes to docs package checked and committed.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.9 out of 10 committers have signed the CLA.:white_check_mark: GCHQ-Developer-530:white_check_mark: jd239:white_check_mark: ad9242:white_check_mark: GCHQ-Developer-299:white_check_mark: j212122:white_check_mark: GCHQ-Developer-741:white_check_mark: timja:white_check_mark: zxh722:white_check_mark: GCHQ-Developer-112:x: dz333dzYou have signed the CLA already but the status is still pending? Let us recheck it.


Revert "OCPBUGS-16813: switch konnectivity-server to additional container in KAS pods"

Reverts openshift/hypershift#2942

/hold
We need to see CI results. The goal is to determine if this PR is impacting the kubevirt lane

/retest

CI registry is getting Gateway Timeout :confounded:

/close


Add a popup window to exit full screen mode.

There was no way to exit full screen mode in Windows so this CL adds a pop-up window to allow users to exit full screen mode by clicking the message to "Exit Full Screen". The pop-up window is automatically disappeared, but it can be reactivated by placing a mouse at the top of the screen in the center of the window.
BUG=XWALK-4861

@pozdnyakov PTAL

@pozdnyakov PTAL

@pozdnyakov PTAL again.

lgtm, thanks


[Containerapp] Fix safe_get for boolean value

Fix safe_get returns wrong value when try to get a field with False value.
eg.
When we try to get some.prop by calling safe_get("some", "prop", default=True).
If some.prop == False, it will return True which is not expected.
Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Containerapp

This PR is still draft


composable, dont enumarate sets

Thanks for the PR!  I took your change and revised it a little (there is a lot of nuance in how the composability works) in #940.  I plan to merge that once we get a code review.


feat: allow radio models to be searched

Closes #35

Thank you very much for this, it's working great :)


demo html does not show the correct map for drive profile

Hi,
when i was compiling by running "npm install" it was showing lot of Error such as deprecated module.
however, when i am running the demo.html, it does not show the map for Driving profile, i only see "Cyan line"
also there are lot of error while running in "Developer mode" i.e
i am trying to make  map-match work  by using mapbox api, but not working, Can you please tell me how can i do this by using this js? or is there anything i need to fix in this js ?
mapbox.match.js:894 Uncaught TypeError: Cannot read property 'map' of undefined
at Object.callback (mapbox.match.js:894)
at cbOnce (mapbox.match.js:642)
at XMLHttpRequest.loadFunc (mapbox.match.js:709)

Hi
Can any one please help on this ?
Thanks


Fixes Python test failure on Configuration API quickstart

Test failures can happen running tests on 1.13 -> 1.14 because test relied on implicit ToString instead of inspecting .value off of the configuration item.  Also ensure print consistently handles string interpolation.
Thank you @berndverst for educating me here.
Issue reference
#1050
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] The quickstart code compiles correctly
[x] You've tested new builds of the quickstart if you changed quickstart code
[x] You've updated the quickstart's README if necessary
[x] If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@msfussell Python tests pass, ready to merge.

Merging.  The JS and Tutorials failures are unrelated and have separate issues tracking.

@hhunter-ms docs-needed pls


Change defaultCheckProbesReadyTimeout to 15m

Changing defaultCheckProbesReadyTimeout to 15m as this is a minimum value that avoids breaking test in case of single node failure when probes are starting (this can delay starting probe up to 15 minutes, see https://github.com/kubernetes/perf-tests/pull/353 for similar change for waiting for deployments).
In the next PR I will remove known overrides in our tests which set this to 10m (still too low value to handel that case).
/assign @mm4tt

/lgtm


Caching, Last Version on XML reports, Remove Oldest

Edit: refactored the PR following Andrzej job, added caching for calls on "Newest" methods, removed "Oldest" methods
Still open to feedback before we merge this,
i would like to suggest:

removal of all the NEXT labels in the HTML reports, only the LATEST labels are usefull.
removal of all the OLDEST methods and replace calls by NEWEST
this suggestion impacts the XML reports (tag lastVersion instead of nextVersion)

this should normally not impact the "useNext" Mojos

Just a heads up ;)
I'm preparing a chunky PR unifying those renderers. I've introduced a common model and managed to largely unify them. Work not done since there's still some area of improvement.
https://github.com/mojohaus/versions-maven-plugin/compare/master...ajarmoniuk:versions-maven-plugin:doxia-renderers

ok i'll put my work on halt until then, my needs would be being able to access your model in any report method

I think this PR is made redundant by #749

I think this PR is made redundant by #749

That's hopefully ok, let me rework my PR and see if i need any additional refactoring.
We chatted about some reworks, there : https://github.com/mojohaus/versions-maven-plugin/issues/454#issuecomment-1262817203
my suggestions seems still relevant, i am eager to do the job, but i'd like feedback on the idea
ternary operator looks correct to me too.
in order to get correct result i was required to execute :  -DallowAnyUpdates=false -DallowMajorUpdates=false
about improvements:
allowMinor allowMinor etc could be replaced by an enum with NULL/EMPTY equivalent to MAJOR,
examples
-DupdateScope=major
-DupdateUpTo=major

Subinc
Inc
Minor
Major

YES
YES
YES
YES
Major/Any/All/Empty/Null/

YES
YES
YES
no
Minor/MinorOrLess

YES
YES
no
no
Inc/IncOrLess

YES
no
no
no
SubInc/SubincOnly

others are a bit more complicated, i would like to introduce the possibility to disallow previews :

Snapshots
Previews :Milestones RCs
Releases

YES
YES
YES
Any/All/Empty/Null

YES
no
no
Snapshots Only

no
YES
no
Previews Only

no
no
YES
Releases Only

no
YES
YES
All but Snapshots

YES
no
YES
All but Previews

YES
YES
no
All but Releases

I think this PR is made redundant by #749

That's hopefully ok, let me rework my PR and see if i need any additional refactoring.
We chatted about some reworks, there : #454 (comment)
my suggestions seems still relevant, i am eager to do the job, but i'd like feedback on the idea from you @ajarmoniuk or anybody :)
about improvements on -DallowAnyUpdates=false -DallowMajorUpdates=false : allowMinor allowMinor etc could be replaced by an enum with NULL/EMPTY equivalent to MAJOR, examples -DupdateScope=major -DupdateUpTo=major
Subinc 	Inc 	Minor 	Major
YES 	YES 	YES 	YES 	Major/Any/All/Empty/Null/
YES 	YES 	YES 	no 	Minor/MinorOrLess
YES 	YES 	no 	no 	Inc/IncOrLess
YES 	no 	no 	no 	SubInc/SubincOnly
others are a bit more complicated, i would like to introduce the possibility to disallow previews :
Snapshots 	Previews :
Milestones RCs 	Releases
YES 	YES 	YES 	Any/All/Empty/Null
YES 	no 	no 	Snapshots Only
no 	YES 	no 	Previews Only
no 	no 	YES 	Releases Only
no 	YES 	YES 	All but Snapshots
YES 	no 	YES 	All but Previews
YES 	YES 	no 	All but Releases

This is also largely handled. Since the interface should not have been changed (otherwise this would constitute a big change to the users and would probably cause a lot of new bug reports), I have simply implemented a change request that the allowMinorUpdates being false should imply allowMajorUpdates false. Which also implies allowIncrementalUpdates false implying both allowMajorUpdates and allowMinorUpdates equal to false.
Internally we represent this as Optional<Segment> across the board. Which is basically the enum we wanted, with all updates represented as empty(). Arguable whether this shouldn't be made a separate value of the Segment, in my opinion it's not.

Still open to feedback before we merge this,
i would like to suggest the removal of all the OLDEST methods and replace by NEWEST
this suggestion only impact the XML reports

Thanks @slawekjaranowski


WinForms build support

I noticed that WPF build support has already been requested but did not find a request for WinForms yet (https://github.com/microsoft/appcenter/issues/85).
WinForms should have build support as well. I tried the app center the first time today and I don't really see much value for a WinForms/WPF app currently without these time saving features.

Thanks for the feature request! We don't have immediate plans to support building WinForms apps but it's something we are definitely considering.
We started with distribute, diagnostics, and analytics support for WPF/WinForms apps because those were the top requested services at the time. I'll monitor this thread for community support and post here with any updates. In the meantime, I recommend using Azure DevOps for building your WinForms apps. Thanks!

@winnieli1208 Hi, thanks for considering my request. I'm not sure if a call is really necessary, my use case is quite easily explained unless you need in-depth details.
I have a WinForms app (also on Github by now https://github.com/canneverbe/Ketarin) that I would like to build and distribute to my users automatically. When I stumbled upon the App Center website I thought that's what it does. And it does indeed, except that it doesn't for WinForms projects.
The workflow I would have in mind is:

Build and package the app after every commit (or after a certain time has passed and changes have been detected). appveyor build is in fact already configured.
Allow me to select one of the generated packages to release it (by generating a download link).

As far as I can see, this is exactly what has already been implemented in App Center, even with support for multiple groups of people (in order to distribute to enthusiasts or beta testers for example).
I could imagine additional features like automatically converting the output and distribute to the app store as well, but I suppose that's a different story.


DISP-S1 CalVal SAS 0.4.3 Acceptance Test

Ticket to track new SAS delivery acceptance for version 0.4.3

ADT provided updated golden dataset; restarting tests

Tests passed


Update Session.cs

If forceRefresh is true, shouldn't you Reauthenticate anyway, even when the accessToken is still valid ?

see true 👍


Converted style1 table to patternfly in Storage Manager

Parent issue: #3139
Before:

After:

@epwinchell @skateman please review.

@dclarizio @martinpovolny Looks good


{Packaging} Bump cffi to 1.15.1 and psutil to 5.9.5

Description

These two packages do not provide wheels for Python 3.11
Update to newer version to prepare for upgrade python to 3.11.

Ref:
https://pypi.org/project/cffi/1.15.0/#files
https://pypi.org/project/psutil/5.9.0/#files
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Packaging

Not sure if the issue of cffi + RPM has been solved. 🤔
https://github.com/Azure/azure-cli/blob/5f52c83e218f3ddc4d933bd99a88dab9e1864d81/scripts/release/rpm/azure-cli.spec#L54-L55

@jiasli Not solved yet.
#13 [execution-env 4/4] RUN yum install -y ./azure-cli-dev.rpm &&     az --version
#13 0.725 Updating Subscription Management repositories.
#13 0.725 Unable to read consumer identity
#13 0.728
#13 0.728 This system is not registered with an entitlement server. You can use subscription-manager to register.
#13 0.728
#13 1.561 Last metadata expiration check: 0:00:52 ago on Mon Jul 17 07:13:26 2023.
#13 1.804 Error:
#13 1.804  Problem: conflicting requests
#13 1.804   - nothing provides libffi-2a6f5b63.so.8.1.0(LIBFFI_BASE_8.0)(64bit) needed by azure-cli-2.50.0-1.el8.aarch64
#13 1.804   - nothing provides libffi-2a6f5b63.so.8.1.0(LIBFFI_CLOSURE_8.0)(64bit) needed by azure-cli-2.50.0-1.el8.aarch64
#13 1.804 (try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)
#13 ERROR: process "/bin/sh -c yum install -y ./azure-cli-dev.rpm &&     az --version" did not complete successfully: exit code: 1
------


Import TLG broken

Using the newest build from pip (<IP_ADDRESS>), I cannot import the TLG corpus, even though I have the original files and all. Intially, this was the error:
File "/Users/smargh/Envs/cltk/lib/python3.4/site-packages/cltk/corpus/utils/importer.py", line 192, in import_corpus
    logger.info('Incoming path:', path)
Message: 'Incoming path:'
Arguments: ('/Users/smargh/Copy/CODE/TLG_PHI/TLG-E (Greek Texts)',)

So, I went in and commented that one logging message. Now, running this code in the shell in the virutual env just kills the shell (exit code 1, no traceback):
>>> from cltk.corpus.utils.importer import CorpusImporter
>>> greek_importer = CorpusImporter('greek')
>>> greek_importer.import_corpus('tlg', '~/Copy/CODE/TLG_PHI/TLG-E (Greek Texts)')

I have no idea what is happening since there's no traceback.

I think it's the TLG path TLG-E (Greek Texts)'). The code as-is expects TLG_E. I'm open to making this a little more flexible.
Speaking of tracebacks, I have been interested in improving the logging, to remove all the sys.exits(1), improve error handling, and add tracebacks to the logs. I haven't done much along these line so interested in any help!


[Feature] ADD: show create routine load

Proposed changes
Add show create routine load
Types of changes
What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)
[ ] Code refactor (Modify the code structure, format the code, etc...)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have created an issue on (Fix #5645) and described the bug/feature there in detail
[x] Compiling and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] If these changes need document changes, I have updated the document
[x] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

There was something wrong with the previous PR when I rebase. So I reopened a new one

DONE @EmmyMiao87

Could you please add some commit msg before I merge you PR?

Could you please add some commit msg before I merge you PR?

done，I added the connection to the PR before


coq: add desktop file for coqide

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[X] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Right, I kind of copied that blindly from other distros. I guess CoqIDE is better.

@vbgl could you merge this please?

Thanks!


Peer Review

The idea for a portfolio of images is a really good one!
Unfortunately, when I open the page the images don't show up. There might be something wrong in your links. If you remove this  /home/jp/codefellows/301/portfolio/ before each of your image tags in the body of your content it should work.
I also recommend making the images the size you want them to appear on the page so the page isn't trying to load such large images. It took me ages to pull this repo onto my computer because it had to pull down so many large images.
I don't see your Nav section when I open the page. And when I inspect it doesn't have any content. I couldn't work it out but it does help to remove the display: none from the .menu in the style.css.
The filters populate great. But they don't display or hide other articles when you select something in them, I think this is because you haven't linked this through a class name (like 'data category') in your toHtml function, set a class here as your category and set the category in the handleProjectFilter to the same thing so that they are linked.
It might help to organise your js files in a folder to keep track of where all your code is.
I know you had issues during the weeks so getting it to this point is a great accomplishment! congrats and keep going to make it look even better 👍

Thanks Claire for the feedback.  I'm working on it, hopefully, I'll have it
all good by Monday.
Regards, John Gaines
On Fri, Jun 17, 2016 at 2:28 PM, Claire Gatenby<EMAIL_ADDRESS>wrote:

The idea for a portfolio of images is a really good one!
Unfortunately, when I open the page the images don't show up. There might
be something wrong in your links. If you remove this
/home/jp/codefellows/301/portfolio/ before each of your image tags in the
body of your content it should work.
I also recommend making the images the size you want them to appear on the
page so the page isn't trying to load such large images. It took me ages to
pull this repo onto my computer because it had to pull down so many large
images.
I don't see your Nav section when I open the page. And when I inspect it
doesn't have any content. I couldn't work it out but it does help to remove
the display: none from the .menu in the style.css.
The filters populate great. But they don't display or hide other articles
when you select something in them, I think this is because you haven't
linked this through a class name (like 'data category') in your toHtml
function, set a class here as your category and set the category in the
handleProjectFilter to the same thing so that they are linked.
It might help to organise your js files in a folder to keep track of where
all your code is.
I know you had issues during the weeks so getting it to this point is a
great accomplishment! congrats and keep going to make it look even better
👍
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Firefly4266/portfolio/issues/17, or mute the thread
https://github.com/notifications/unsubscribe/ARhBM95t86qJ6E2xnxu92i3PVVfzk-2zks5qMxGPgaJpZM4I4vtF
.


The Polaris-vue can't work!

Hello, Our team found a major error in using your project.
This is my code to quote your project:
----main.js----
import Vue from 'vue';
import<EMAIL_ADDRESS>import<EMAIL_ADDRESS>import<EMAIL_ADDRESS>import PolarisVue from '@hulkapps/polaris-vue';
import<EMAIL_ADDRESS>Vue.use(PolarisVue);
But there was a error when we used it, the error message in console is "Uncaught ReferenceError: Cannot access 'vue_component$t' before initialization".
This error only occurs when we reference the code "import '@hulkapps/polaris-vue/dist/polaris-vue.esm.js';"
We guess maybe this file have somthing wrong.
Please solve it as soon as possible!!!

@TTDream30 You have used all our builds, try to use only one build at a time.

Thank you. But I have another question. I think your instance document is not eligible.
When I copy code from your document, it's only style effects, no related events. I need to read your source code to find the events about the component.
For example, I copy the "ColorPicker" component，your code in the document is :
<template>
  <PStack vertical="">
    <PStackItem>
      <PColorPicker label="Color Picker" id="color-picker" color="#FF0000" />
    </PStackItem>
    <PStackItem><PBadge color="#FF0000">#FF0000</PBadge></PStackItem>
  </PStack>
</template>But you know that, it's not work if I copy the code. The color can't change. I try to change the code like that:
<PStackItem>
    <PColorPicker
       label="Star color"
       id="color-picker"
       :color="starColor"
    />
</PStackItem>
It still have nothing change.
I think a good document should have a one rule at least.It's the effect of the code is the same as the effect of the case.
Thanks to read my words. Wish you better.
------------------ 原始邮件 ------------------
发件人:                                                                                "HulkApps/polaris-vue"                                                                                @.>;
发送时间: 2022年1月5日(星期三) 下午3:36
@.>;
抄送: "Bro<EMAIL_ADDRESS>主题: Re: [HulkApps/polaris-vue] The Polaris-vue can't work! (Issue #86)
@TTDream30 You have used all our builds, try to use only one build at a time.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: @.***>

@TTDream30 You have used all our builds, try to use only one build at a time.

Thank you. But I have another question. I think your instance document is not eligible.
When I copy code from your document, it's only style effects, no related events. I need to read your source code to find the events about the component.
For example, I copy the "ColorPicker" component，your code in the document is :

But you know that, it's not work if I copy the code. The color can't change. I try to change the code like that:

It still have nothing change.
I think a good document should have a one rule at least.It's the effect of the code is the same as the effect of the case.
Thanks to read my words. Wish you better.

Thank you. But I have another question. I think your instance document is not eligible.
When I copy code from your document, it's only style effects, no related events. I need to read your source code to find the events about the component.
For example, I copy the "ColorPicker" component，your code in the document is :
<template>
  <PStack vertical="">
    <PStackItem>
      <PColorPicker label="Color Picker" id="color-picker" color="#FF0000" />
    </PStackItem>
    <PStackItem><PBadge color="#FF0000">#FF0000</PBadge></PStackItem>
  </PStack>
</template>But you know that, it's not work if I copy the code. The color can't change. I try to change the code like that:
<PStackItem>
    <PColorPicker
       label="Star color"
       id="color-picker"
       :color="starColor"
    />
</PStackItem>
It still have nothing change.
I think a good document should have a one rule at least.It's the effect of the code is the same as the effect of the case.
Thanks to read my words. Wish you better.

We are working on that to provide source code.

We are working on that to provide source code.

All right. Thanks~

We are working on that to provide source code.

OK. Your kind early reply will be highly appreciated


Add health checks documentation

Proposed changes
Add health checks documentation
Checklist
Before creating a PR, run through this checklist and mark each as complete.

[ ] I have read the CONTRIBUTING document
[ ] I have run make install-tools and have attached any dependency changes to this pull request
[ ] If applicable, I have added tests that prove my fix is effective or that my feature works
[ ] If applicable, I have checked that any relevant tests pass after adding my changes
[ ] If applicable, I have updated any relevant documentation (README.md)
[ ] If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@dhurley Is this doc for v2 or v3?

@dhurley Is this doc for v2 or v3?

Its for v2


i18n AOT support

What problem does this feature solve?
ng-zorro now configure i18n in app.module.
when using aot compile, the locale is configured as project build param, and can just build one locale per package. it's not necessary to include more than one language file.
What does the proposed API look like?
N/A

supported, plz check the document for more detail.


Complete R.array.country_list string array

I made alert dialog which contain list of country timezone ID and user will select from this list, the selection will become input to set clock timezone.
Right now I am only putting one string inside the array resources. Need help to populate all country Java TimeZone ids and put it on R.array.country_list.
The Java TimeZone ids reference are here

Hi, I looked into this and found out that there are 582 available TimeZone IDs in API 21, but 593 of them in API 28. In an array, some listed timezones will not be available on certain API levels. I think using java.util.TimeZone.getAvailableIDs() would be better, since it will return a list of timezones which will definitely work on the tested device.

Alright. Let me try it tonight


Fix vertical_stretch injection and kwargs passing on DockWidget

Description
This PR fixes two issues with dock_widgets

not all of the keys from the widget options dict was making to the add_dock_widget method (preventing plugins from using {'add_vertical_stretch': False}
widgets that have sub-widgets with expanding QSizePolicies were still having layouts added.  this fixes that and adds a test.

Type of change

[x] Bug-fix (non-breaking change which fixes an issue)

How has this been tested?
test added,  checked manually on napari-animation ... testing now with AICS

LGTM! Thanks!! Can you add a release note, also maybe include in the UI changes section that we changed the default from bottom to right. Thanks!!

ok, have a look at the notes

Also looks like now there is a release notes merge conflict, will be easy to fix!!


we are weirding english

When sharing fails and the user is behind a full cone NAT, our grammar is poor:
It looks like you are on a FullCone, which is unlikely interfering with your ability to connect to friends.

This happens when "unlikely" is inserted into the __natImpact__ placeholder in the analysisResult message:
https://github.com/uProxy/uproxy/blob/1bb0b1b4c1b6d90669b3bc1a9e6b3f308af9aa15/src/generic_ui/locales/en/messages.json#L526
Screenshot attached.

Also, what is a FullCone? The term is "full-cone NAT":
https://en.wikipedia.org/wiki/Network_address_translation#Methods_of_translation

What is unableToShare?
On Wed, Jun 17, 2015 at 3:52 PM, trevj<EMAIL_ADDRESS>wrote:

Also, what is a FullCone? The term is "full-cone NAT":
https://en.wikipedia.org/wiki/Network_address_translation#Methods_of_translation
—
Reply to this email directly or view it on GitHub
https://github.com/uProxy/uproxy/issues/1654#issuecomment-112927142.

Oh yeah, that too :-)

my mistake! anyway, fixed: https://github.com/uProxy/uproxy/pull/1657
thanks for filing!


oni-ml: ml_ops.sh should fail if run without arguments

when running ml_ops.sh without specifying a date code and type it does not cause an error.
rm commands in the script run without parameters and cause the pwd to be deleted.

opened PR

fixed in Open-Network-Insight/oni-ml#23


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: kapilvarmabommagani sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


bug in cupyx.scipy.sparse.linalg.eigsh

Description
cupyx.scipy.sparse.linalg.eigsh has a bug that prevents convergence or accurate results. For example, for a simple identity matrix (all eigenvalues are 1), sometimes the maximum eigenvalue returned is very large (>50) and sometimes it returns nan. When using the eigenvalue solver for dense arrays cupy.linalg.eigvalsh, the result is correct.
To Reproduce
import cupy as cp
from cupyx.scipy.sparse.linalg import eigsh
from cupy.linalg import eigvalsh

print('Eigenvalue computation for sparse array')
a = cp.sparse.eye(100, dtype=cp.float64)

for i in range(10):
    w = eigsh(a,  k=1, return_eigenvectors=False)
    print(w)

print('Eigenvalue computation for dense array')
a = cp.eye(100, dtype=cp.float64)
for i in range(10):
    w = eigvalsh(a)
    print(w[0])

#Eigenvalue computation for sparse array
#[55.57465816]
#[nan]
#[55.57465816]
#[55.57465816]
#[55.57465816]
#[55.57465816]
#[nan]
#[55.57465816]
#[55.57465816]
#[55.57465816]
#Eigenvalue computation for dense array
#1.0
#1.0
#1.0
#1.0
#1.0
#1.0
#1.0
#1.0
#1.0
#1.0

Installation
Conda-Forge (conda install ...)
Environment
OS                           : Linux-5.11.0-38-generic-x86_64-with-glibc2.31
Python Version               : 3.9.10
CuPy Version                 : 10.1.0
CuPy Platform                : NVIDIA CUDA
NumPy Version                : 1.21.5
SciPy Version                : 1.7.3
Cython Build Version         : 0.29.27
Cython Runtime Version       : None
CUDA Root                    : /home/joan/anaconda3/envs/minipycsou
nvcc PATH                    : None
CUDA Build Version           : 11020
CUDA Driver Version          : 11040
CUDA Runtime Version         : 11060
cuBLAS Version               : (available)
cuFFT Version                : 10600
cuRAND Version               : 10209
cuSOLVER Version             : (11, 3, 2)
cuSPARSE Version             : (available)
NVRTC Version                : (11, 6)
Thrust Version               : 101000
CUB Build Version            : 101000
Jitify Build Version         : 6dbba68
cuDNN Build Version          : None
cuDNN Version                : None
NCCL Build Version           : None
NCCL Runtime Version         : None
cuTENSOR Version             : None
cuSPARSELt Build Version     : None
Device 0 Name                : NVIDIA GeForce RTX 3050 Ti Laptop GPU
Device 0 Compute Capability  : 86
Device 0 PCI Bus ID          : 0000:2D:00.0

Additional Information
No response

Can I go ahead with this?

Hello ! I have encountered this bug too. I think this is a quite serious bug: eigen-solvers are ubiquitous in numerical computing). Is there any plan on fixing it? @Onkar627 did you make any progress?
Thanks!

No, I have not proceeded with it but we can plan to fix it :)

That would be very nice yes, thanks!

Hi, @Onkar627 @toslunar @kmaehashi is there any update on this issue?
Thanks!


Use Machine Learning to Extract Information from Documents

Tutorial URL: https://developers.sap.com/tutorials/cp-aibus-dox-swagger-ui.html
Step 3: Create a client
Value for ClientId would be from doc-info-extraction-key, right?
What about clientName? Where do i get it from?

Hello,
No, in step 3, clientId  and clientName values are anything you want as long as you follow the format below.
Single client: {"value":[{"clientId":"c_00","clientName":"client 00"}]}
Multiple clients: {"value":[{"clientId":"c_00","clientName":"client 00"}, {"clientId":"c_01","clientName":"client 01"}]}
Best regards,
Juliana


Extract JSONTree

Closes https://github.com/gaearon/redux-devtools/issues/85
JSONTree has been extracted to chibicode/react-json-tree (npm).
Tested by running examples/counter and examples/todomvc against it.
src/utils/deepEqual.js and src/utils/hexToRgb.js were both only used by JSONTree, so I removed those as well.
The original credits are moved to README.md and package.json.
Don't mind transferring the ownership of chibicode/react-json-tree to @gaearon. Just let me know.

Note: I realized that JSONTree actually doesn't work if theme prop is missing.
As an emergency fix, I copied over solarized.js and made it as the default theme for JSONTree if its theme prop is missing. This way, users don't have to set the themes themselves for most use cases.
I chose Solarized (even though it's not the default for redux-devtools because I think most people will use JSONTree standalone on a white background (it's also the default browser background color), and I found that Solarized is most legible for white backgrounds.
I think the longer term solution would be to maybe pull out redux-devtools's themes directory into its own package and require it on both LogMonitor and react-json-tree. What do you think?
Here's the commit for adding a default theme. The screenshot is below (this is also on the README of react-json-tree.)

Finally, I also added an example for JSONTree.

Awesome job.

@gaearon thanks!


24px - link external

https://www.figma.com/file/2rjsQp42uKvzPXzLZIqOeA/Octicons-v2-Source?node-id=738%3A1592

Slightly smaller version on the right to have inner aliasing

@edokoa I think we can go with the line arrow here:

cc @colebemis


HAWQ-1315. Function validateResourcePoolStatus() in resourcepool.c is logging the wrong information

@jiny2 @stanlyxiang pls feel free to review this pull request, thank you.

+1

+1 LGMT

pushed into master branch


GitHub Action to lint Python code

Output: https://github.com/cclauss/pathfind-visualiser/actions
https://flake8.pycqa.org/en/latest/user/error-codes.html
On the flake8 test selection, this PR does not focus on "style violations" (the majority of flake8 error codes that psf/black can autocorrect).  Instead, these tests are focus on runtime safety and correctness:

E9 tests are about Python syntax errors usually raised because flake8 can not build an Abstract Syntax Tree (AST).  Often these issues are a sign of unused code or code that has not been ported to Python 3.  These would be compile-time errors in a compiled language but in a dynamic language like Python, they result in the script halting/crashing on the user.
F63 tests are usually about the confusion between identity and equality in Python.  Use ==/!= to compare str, bytes, and int literals is the classic case.  These are areas where a == b is True but a is b is False (or vice versa).  Python >= 3.8 will raise SyntaxWarnings on these instances.
F7 tests logic errors and syntax errors in type hints
F82 tests are almost always undefined names which are usually a sign of a typo, missing imports, or code that has not been ported to Python 3.  These also would be compile-time errors in a compiled language but in Python, a NameError is raised which will halt/crash the script on the user.

Woah dude thank you. Can you explain some of the things you've done? Still quite new to all this and I'm not sure what all this does (except the spelling mistakes of course, thanks for catching those)

GitHub Actions enable automated testing to happen anytime you or anyone else changes code in the repo.
This Action installs Python 3.8 on a Windows box in the cloud and then installs and runs black codespell flake8 isort pytest
black formats code
codespell spellchecks code
flake8 is explained in the commit message ... it is the most important one to start with
isort sorts the Python imports so that you don't have to
pytest runs any tests that you create
Lines that end in || true probably fail so the long term goal is to get those lines passing and then remove the || true.

Ok looks like I'll have to do some reading, but I'll merge this thank you!


I don't have anything like WEBSITE_USE_ZIP in my app setting.

Does this occur consistently?
Repro steps:

Action: azureFunctions.deploy
Error type: 409
Error Message: Run-From-Zip is set to a remote URL using WEBSITE_RUN_FROM_PACKAGE or WEBSITE_USE_ZIP app setting. Deployment is not supported in this configuration.
Version: 0.22.1
OS: darwin
OS Release: 18.2.0
Product: Visual Studio Code
Product Version: 1.45.1
Language: en

Call Stack
extension.bundle.js:309:399345
retryCallback extension.bundle.js:225:114550
retryCallback extension.bundle.js:157:31063
extension.bundle.js:157:32676
handleRedirect extension.bundle.js:171:7752
extension.bundle.js:157:29848
Request._callback extension.bundle.js:1:670836
Request.n._callback.n.callback.n.callback extension.bundle.js:201:4483
Request.emit events.js:203:13
Request.<anonymous> extension.bundle.js:201:17592
Request.emit events.js:208:15
IncomingMessage.<anonymous> extension.bundle.js:201:16382
Object.onceWrapper events.js:291:20
IncomingMessage.emit events.js:208:15
endReadableNT _stream_readable.js:1168:12
processTicksAndRejections task_queues.js:77:11

Likely dupe of https://github.com/microsoft/vscode-azurefunctions/issues/1684
If not, please add more detailed repro steps

Thanks.


add max_density

I wrote some code that adds density, but it could be adding a bunch of unnecessary points.  I'm going to add some code that only adds intermediate vertices if they change the slope between line segments.

done, see densify at https://github.com/DanielJDufour/reproject-geojson/tree/v0.5.0#point-densification


Steering doesn't work sometimes

Many users report that gas and brake work, but steering doesn't.

Okay the reason it fails, is that magnet is a null vector when the device doesn't have a magnetic sensor. This results in normH being 0 here and thus getRotationMatrix returning false. Thus SensorManger.getOrientation never gets called in this function:
    // calculates orientation angles from accelerometer and magnetometer output
    public void calculateAccMagOrientation() {
        if (SensorManager.getRotationMatrix(rotationMatrix, null, accel, magnet)) {
            SensorManager.getOrientation(rotationMatrix, accMagOrientation);
        }
    }

See https://github.com/BeamNG/remotecontrol/blob/77294470c5dcd6fd14343b11768765fcaa891f13/Android/Udpsteering/app/src/main/java/com/beamng/udpsteering/MainActivity.java#L276
MainActivity.java is only using accMagOrientation[1] here. getOrientation sets this to Math.asin(-rotationMatrix[7]) here. rotationMatrix[7] is set to
gravity[1] / Math.sqrt(gravity[0]*gravity[0]+gravity[1]*gravity[1]+gravity[2]*gravity[2])

here. gravity is accel in MainActivity.java.
To sum it up, the magnet sensor information isn't used at all. The calls to getRotationMatrix and getOrientation are unnecessary.


Adding a better link for awesome-computer-vision

The newer repository has many more links and many more stars than the currently listed one

Thanks for the suggestion, however could you please add the better repo as a separate entry? You can distinguish between them by adding the username of the respective author, e.g. [awesome-computer-vision](...) by @jbhuang0604

Sure, i'll update the PR

The comment has been addressed. Is it possible to merge this PR?

@t27 Sorry, I have completely missed your update. I have modified your commit a bit and merged it in b13e973d9aab5632e8bea126ec22aa832442cb20. Thank you!
@koppor Thanks for the heads up!


Attach circleci workspace and set terraform workspace

Hi,
#1
I'm trying to use this orb but my project uses some private repositories for terraform modules and the infracost cannot handle it even with the github token to access the repos, so I'm trying to attach the workspace from the previous steps to run the infracost over the terraform plan but it does not have support to attach the circleci workspace too.
#2
I need to pass the terraform workspace for the terraform, is this syntax right?
- infracost/infracost:
     tfdir: '.'
     tfflags: '-var environment=staging'

Thanks.

@amioranza so the orb just run this so one thing you can try is to just set the following in your .circleci/config.yml to fix #2 (TF_WORKSPACE is a built-in terraform env var). Regarding #1, I wonder if the following helps as it's a circleci job so it can be used in your existing workflow so it shares the workspace?
jobs:
  infracost:
    docker:
      - image: infracost/infracost:latest
    environment:
      percentage_threshold: '0'
      tfdir: '.'
      tfflags: '-var environment=staging'
      TF_WORKSPACE: staging
    steps:
      - checkout
      - run: /scripts/ci/diff.sh

So, in my case the result of infracost_cmd always duplicate the --tfdir appending the --tfdir . at the end of the command and failing, I solved it changing the script, to my use case, and inserting it on a job.

Glad you found a way to make it work :)

I solved it changing the script

Which script? https://github.com/infracost/infracost/blob/master/scripts/ci/diff.sh ? If possible, please share the details so others who might run into this can use the same workaround.

Yes the script I'm talking about is the one you linked, here is my job:
  infracost:
    <<: *default_config
    parameters:
      environment:
        description: "The target environment"
        type: string
    steps:
      - *restore_repo
      - run:
          name: infracost
          command: |
            apk add --no-cache ca-certificates curl git jq
            mkdir ~/.ssh
            echo "StrictHostKeyChecking accept-new" | tee ~/.ssh/config
            chmod 0600 ~/.ssh/config
            curl -s -L https://github.com/infracost/infracost/releases/latest/download/infracost-linux-amd64.tar.gz | tar xz -C /tmp && \
            mv /tmp/infracost-linux-amd64 /usr/local/bin/infracost
            current_branch_output=$(infracost)
            echo "$current_branch_output" > current_branch_infracost.txt
            current_branch_monthly_cost=$(cat current_branch_infracost.txt | awk '/OVERALL TOTAL/ { printf("%.2f",$NF) }')
            git fetch --depth=1 origin master &>/dev/null || git fetch --depth=1 origin main &>/dev/null || echo "Could not fetch default branch from origin, no problems, switching to it..."
            git switch master &>/dev/null || git switch main &>/dev/null
            git log -n1
            default_branch_output=$(infracost)
            echo "$default_branch_output" > default_branch_infracost.txt
            default_branch_monthly_cost=$(cat default_branch_infracost.txt | awk '/OVERALL TOTAL/ { printf("%.2f",$NF) }')
            percent_diff=$(echo "scale=4; $current_branch_monthly_cost / $default_branch_monthly_cost * 100 - 100" | bc)
            absolute_percent_diff=$(echo $percent_diff | tr -d -)
            if [ $(echo "$absolute_percent_diff > $percentage_threshold" | bc -l) = 1 ]; then
              change_word="increase"
              if [ $(echo "$percent_diff < 0" | bc -l) = 1 ]; then
                change_word="decrease"
              fi
              jq -Mnc --arg change_word $change_word \
                      --arg absolute_percent_diff $(printf '%.1f\n' $absolute_percent_diff) \
                      --arg default_branch_monthly_cost $default_branch_monthly_cost \
                      --arg current_branch_monthly_cost $current_branch_monthly_cost \
                      --arg diff "$(git diff --no-color --no-index default_branch_infracost.txt current_branch_infracost.txt | tail -n +3)" \
                      '{body: "Monthly cost estimate will \($change_word) by \($absolute_percent_diff)% (default branch $\($default_branch_monthly_cost) vs current branch $\($current_branch_monthly_cost))\ninfracost diff\n\n```diff\n\($diff)\n```\n\n"}' > diff_infracost.txt
              echo "Default branch and current branch diff ($absolute_percent_diff) is more than the percentage threshold ($percentage_threshold)."
              GITHUB_API_URL=${GITHUB_API_URL:-https://api.github.com}
              echo "Posting comment from CircleCI to GitHub"
              cat diff_infracost.txt | curl -L -X POST -d @- \
                -H "Content-Type: application/json" \
                -H "Authorization: token $GITHUB_TOKEN" \
                "$GITHUB_API_URL/repos/$CIRCLE_PROJECT_USERNAME/$CIRCLE_PROJECT_REPONAME/commits/$CIRCLE_SHA1/comments"
            else
              echo "Comment not posted as default branch and current branch diff ($absolute_percent_diff) is not more than the percentage threshold ($percentage_threshold)."
            fi
    environment:
      TF_WORKSPACE: << parameters.environment >>

I removed all the code that is not interesting to me like bitbucket and gitlab stuff. As we are using the terraform 0.12 I had to add some packages to the default executor and set some workarounds for git to download the code of the default branch and not stuck asking for host key confirmation.

@amioranza that's awesome - thanks for sharing. I'll close this issue and mention TF_WORKSPACE in https://www.infracost.io/docs/integrations as it's probably useful for others too.


Update magnolia-core to 2.0.0-M8

Updates com.softwaremill.magnolia:magnolia-core from 2.0.0-M4 to 2.0.0-M8.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.softwaremill.magnolia", artifactId = "magnolia-core" } ]

labels: library-update, semver-pre-release

Superseded by #321.


Add overflow checking for add_ovf and similar operations

ImportBinaryOperation currently handles all of the _ovf versions of arithmetic operations, but doesn't actually check for overflows. It should throw OverflowException if the operations overflow, but if exception handling isn't implemented yet, it could also trap for a start. Look for the // TODO: Overflow checks comment.

@morganbr that's up for grabs. Can I start working on it?

@matekm, thanks for the interest. It's all yours!

@robert-matusewicz Hi, did you have a change to do anything for this, I had a look at Wasm binary operations and LLVM binary operations and there's nothing there that will do this for you?  Something like emitting https://codereview.stackexchange.com/questions/37177/simple-method-to-detect-int-overflow I suppose is the way to go.


Added span.cpp for Span Problem in Others folder

This PR is for adding span problem under others folder.

https://github.com/TheAlgorithms/C-Plus-Plus/pull/493/checks?check_run_id=354706143#step:9:47


Fix/dep vulnerabilities

Update deps to fix vulnerabilities. This fixes all expect for one in next-tinacms-cloudinary that will have to be fixed in our monorepo first

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Full-width popover

How do I get a popover to be the full width of the screen?
If I make my View full-width it is rendered shifted to the left.
I can modify the BackgroundView in your example like this:
        .popover(present: $present) {
            VStack(alignment: .leading) {
                Text("You can put anything you want in the background.")

                HStack {
                    ExampleImage("circle", color: 0x5DCB72)
                    Text("This popover has a `Color.green` background.")
                }
            }
            .frame(width: UIScreen.main.bounds.width) // <<<<< added this line
            .padding()
            .background(.background)
            .cornerRadius(12)
            .shadow(radius: 1)
        } background: {
            Color.green.opacity(0.4)
        }

How can I horizontally center it and make it full width?
It looks like this:

Solved!!!!
The layout code gets confused when the width of the View that we are popping-over is wider than screenwidth - 32.  Which is what happens when I try to set the width == UIScreen.main.bounds.width.
The problem was that screenEdgePadding's default are UIEdgeInsets(16).
Adding this fixed my problem:
$0.screenEdgePadding = UIEdgeInsets(top: 16, left: 0, bottom: 16, right: 0)

When I do this I don't need to explicitly set the width.
The code that uses this is func calculateFrame() in Popover.

Awesome, glad it worked!

Thanks for the useful library.
The design of the project I'm working on wants messages to overlap the navigation title.  That's easy to do on the first screen with the NavigationView.  But not easy on successive screens reached via NavigationLink because the nav bar is owned by a previous screen.  Popover solves that easily.
They also want things like menus to sit at the bottom and cover a tab bar with an overlay of a transparent background on top of the rest of the screen (include the title).
All of that architecture is not readily accessible (or coverable) from a View that is deeply nested.  Again, Popover solves that one.


[MGDCTRS-1665] sending collected information to stdout using tar

Sending collected information about a connector to stdout using tar command, so that data can be downloaded to local machine for analysis.

LGTM

/ok-to-test

@tmielke can you add a description please?

/lgtm
@reetika-vyas can you please approve?

/approve

/lgtm

/retest


Settings decoration: Modified in Folder

Issue Type: Feature Request
Testing #57304
There already is a 'Modified in Workspace" decoration, it would be great if that would also list any folders in which that setting is modified (and also show these in the workspace settings).
VS Code version: Code - Insiders 1.27.0-insider (43676d0cb7db94e2fa771f1d10bff10eaa01b453, 2018-08-28T05:12:24.162Z)
OS version: Darwin x64 17.7.0

@sandy081 is there an easy way to find out whether a setting is modified in some folder, or do I need to call inspect for every workspace folder to check? All workspace folders multiplied by all settings could be large, which is why I left this out...

There is no such API but at the end I might also do internally. So, I see it as util method. I do not see how can we make it efficient other than checking a setting is modified for each folder or not. But internally everything comes from cache so getting a setting per resource is not costly.

Ok, I can do it from the frontend and measure whether it affects perf. I can also do it lazily when the row is rendered.


Check outgoing payment grant

add token introspection query to configured AS
store grant id with payment

(lock and) check existing grant payments on payment creation

I think the grant needs to be evaluated for the creation and the auth. In the unlikely scenario that a payment is created at the end of an interval but then only authorised in the start of the next interval it should be accounted for in the second interval.
As a basic rule, we should account for the outgoing payment at the moment it is authorised.
But, checking the authorisation and balance available under the grant at creation does help to fail fast so we should do that too.

https://hackmd.io/YWnLmu9ASiiHIwTPzmZKNg
The outgoing payment's sendAmount is needed in order to check the grant's sendAmount limit. The earliest it can be checked is as follows:

FixedSend
FixedReceive

authorized on create
on create
on quote

authorized pre-quote
on authorize
on quote

authorized post-quote
on authorize
on authorize

In order to check on quote, the grant's sendAmount limit (as seen when the payment was authorized) should be stored with the outgoing payment in Rafiki.

In order to check an outgoing payment against its grant when the payment is quoted (see above :point_up_2:), Rafiki needs the grant details in a context other than an Open Payments create or update request (when the grant is retrieved via access token introspection). Possible solutions include:

~store the access token from the create/update request(s) and re-introspect~
allow Rafiki to query the grant by its id (grant) at the AS
store the grant with the outgoing payment
(This would duplicate a grant across multiple outgoing payments with the same grant)
store the grant on its own
(Should we overwrite the grant every time we see it, such that a request involving a different payment would cause us to compare the quoted outgoing payment with what is presumably the most recent version of the grant? Should grants have something like a revision number to determine what is actually the latest version?)

FWIW, I think option 4 is the cleanest -- you really are talking about managing a cached state of an external object. If there's a single "latest" state then a straight overwrite would work fine.

I'm not sure I understand the use case. Isn't the payment quoted when it is created or updated? I thought the flow was

client -> RS: create|update
RS -> AS: introspect token
AS -> RS: token active, grant details
RS: get quote, check against grant
RS -> client: payment created|updated / creation|update denied
OR
RS: kicks off quoting flow but doesn't wait for it
RS -> client: payment created|updated (but state could be Prepared after quoting, b/c grant is too little)

Or is it when the quote expired and we re-quote that we don't know about the grant?


Add: Workspace symbols

Close #292

No tests for the new command yet right?

@zth not necessarily about this PR, but we should consider beginning to add tests for the TypeScript part of the extension. That's where most breakages have been recently (and where we have no tests).
Instead of going top down, test framework, overhead, unclear utility, i.e. using "best practices". How about doing a quick review of recent breakages and add the least amount of infra required to prevent those from re-occurring. Then build out from there in future.

@zth not necessarily about this PR, but we should consider beginning to add tests for the TypeScript part of the extension. That's where most breakages have been recently (and where we have no tests). Instead of going top down, test framework, overhead, unclear utility, i.e. using "best practices". How about doing a quick review of recent breakages and add the least amount of infra required to prevent those from re-occurring. Then build out from there in future.

Sounds good to me. Let's discuss this separately then.

@zth @cristianoc could you disable the CI? It's in an infinite loop

There were the following changes in the tests folder:

tests/src/, tests/not_compiled, tests/package.json and tests/bsconfig.json moved to tests/document/ folder.

The last changes slowed down tests by about 3 seconds each clean build+test.
10 features would slow down 30 seconds, so looking into a more lightweight approach

Let me test something.

Oops commit history is gone.
Anyhow, it's just about putting tests into analysis/tests/src/workplace and change nothing in the structure.

This way we also avoid to merge conflict any other PR currently ongoing.

The last changes slowed down tests by about 3 seconds each clean build+test.
10 features would slow down 30 seconds, so looking into a more lightweight approach

Even if that count is inaccurate, we don't want those 3 seconds.
If anything, faster would be better.

Anyhow, it's just about putting tests into analysis/tests/src/workspace and change nothing in the structure.

Placing tests in analysis/tests/src/workspace will get all symbols in analysis/tests/src/. The workspaceSymbols command needs to read bsconfig.json and get sources.
When putting in tests/workspaces I isolate the files in analysis/tests/src

Anyhow, it's just about putting tests into analysis/tests/src/workspace and change nothing in the structure.

Placing tests in analysis/tests/src/workspace will get all symbols in analysis/tests/src/. The workspaceSymbols command needs to read bsconfig.json and get sources.
When putting in tests/workspaces I isolate the files in analysis/tests/src

Reading bsconfig is always tricky, as there are a bunch of rules, and might change in future.
For example, global rename does not look into bsconfig.
Related question: what about dependencies?
About tests: there's quite a lot of freedom how test commands can be structured, and surely one can pass a folder as parameter or some other restriction to avoid noisy results.

Making this run on CI: https://github.com/rescript-lang/rescript-vscode/pull/519


docs: Added cookbook

This commit adds a new cookbook page which is intended to aggregate code snippets from multiple sources, including existing documentation, GitHub repositories, Discord and others. Each recipe includes a brief explanation, code sample and optional link to source. Recipes are categorized within the page, although the categorization is currently fluid and may change.
Note: Code samples are not yet available for all languages, but will be added ongoing in parallel with #4574

Thanks for the review @gerhard !

A few improvement suggestions:
1. Cookbooks
This is a collection of cookbooks. Plural reads best IMO.

AFAIK the general convention for code is singular ie a "cookbook" with different "chapters" eg. https://www.puppetcookbook.com/ and https://www.oreilly.com/library/view/python-cookbook-3rd/9781449357337/
Would it be better if we named the page differently eg.  "Code Library", "Code Samples", "Examples"?
Would like feedback from others on this as well!

2. Better navigation between cookbooks
There are a lot of super useful cookbooks, but it is hard to understand this from the secondary navigation, the one on the right-hand side of the page.
How difficult would it be to use the same layout as Guides?

The Guides page is created using a custom React UX component, which generates the index page dynamically by looking for markdown files in a specific directory and/or with specific metadata (@crjm to confirm). For the cookbook, the code samples are in different locations in the docs tree and don't have any specific identifying metadata. So we can't use the guides UX directly, we would need to create a new UX component or adapt the existing one, and probably have additional metadata to configure it.

3. Highlight relevant lines
In the Set host working directory cookbook, would it be possible to highlight the line which contains dagger.WithWorkdir(".")? It would make it easier to distinguish between the important line(s) vs the boilerplate code.

Yes, this is one that I already attempted. In fact, some of the code samples already had highlights and I removed them. The issue here is that the code samples "belong" to other guides and are already in use in those guides - the cookbook page is merely a different view that reuses (not duplicates) them. So, adding highlights for a specific code sample may make sense in cookbook context, but is confusing when the same highlights are seen in the context of the original guide (and vice-versa as well). However, I 100% agree this would be a useful feature to have, maybe @crjm can suggest a way to make it work while still maintaining the reusability.

4.  It is most likely that all examples with go 1.19 will not work.

Can you please point me to specific cases where you found this issue?

5. Wording
Feel free to implement the suggestions which you like, ignore the rest:

I implemented the majority of these, thank you!

Yes, Cookbook, no plural 👍
OK, we may need some help from @crjm or @slumbering on this one.
Sounds like another follow-up improvement to me, no worries.
Everything under the Integrations section which references Go 1.19 should be updated to 1.20 - e.g. go-version: 1.19 -> go-version: '1.20'
🙌

Yes, Cookbook, no plural +1

OK

4. Everything under the **Integrations** section which references Go 1.19 should be updated to 1.20 - e.g. `go-version: 1.19` -> `go-version: '1.20'`

Done

This is too good to not ship this Friday. Go for merge & remember to publish it live. We can follow-up with the rest of the improvements next week.

Thanks! On publication and timing, I'd like to have @mircubed and @shykes opinions eg. if we want to tweet it, maybe it's optimal to publish it at the beginning of the week instead?

Merging and going live per discussion with Gerhard: https://discord.com/channels/@me/1027171337866846299/1097560367879704698


Add resilience4j integration for circuitbreaker

Motivation:
Resilience4j provides utility patterns that are useful especially for microservices.
This PR attempts to integrate Resilience4j's circuit breaker utility into Armeria.
Modifications:

jdk 17 is required for resilience4j2.

:examples, :resilience4j modules are now built to target >= jre 17
tests for the above modules are not run for builds < jre 17.
shadow-gradle-plugin has been bumped to 7.1.2, and the module name has been updated to gradle.plugin.com.github.johnrengelman:shadow.

(Breaking change) users of gradle-scripts now must define a dependency of gradle.plugin.com.github.johnrengelman:shadow instead of com.github.jengelman.gradle.plugins:shadow to shade dependencies.

Added a missing factory method CircuitBreakerRpcClient#newDecorator(CircuitBreakerClientHandler<RpcRequest> handler, CircuitBreakerRuleWithContent<RpcResponse> ruleWithContent) so that resilience4j2 module can support rpc decorators.
A new resilience4j2 module has been introduced.

Resilience4jCircuitBreakerMappingBuilder which is analogous to CircuitBreakerMappingBuilder has been introduced.
Resilience4jCircuitBreakerMapping which is analogous to CircuitBreakerMapping has been introduced.
Resilience4JCircuitBreakerClientHandler and Resilience4JCircuitBreakerCallback have been introduced to use resilience4j's CircuitBreaker in conjunction with CircuitBreakerClient.
Resilience4jCircuitBreakerFactory has been introduced for users who may want to customize how CircuitBreaker is generated based on host, path, and method.

Resilience4jCircuitBreakerUtils is added to hide the default implementation of Resilience4jCircuitBreakerFactory

FailedCircuitBreakerDecisionException has been added to use as the default exception when a Throwable is not available for CircuitBreaker#onError.

An :examples:resilience4j-spring module has been introduced

This module is intended to be a playground for validating integrations with resilience4j-spring-boot2 and resilience4j-micrometer.

An it:resilience4j module has been added to verify rpc integration.

Result:

Closes #1469

Looking forward to progress in this PR ❤

@jrhee17 hi, jrhee :)
I am interested in this feature. Do you have any updates by any chance?
Will it be released in version 1.19.0?

@heesuk-ahn Hi! Sorry about the late reply.   Let me increase priority in getting this feature merged 🙇

Really sorry about the delay all 😅    I think this PR is finally in a reviewable state 🙏

@reviewers please take a look at #4426 before reviewing this PR

I believe this PR is (finally) ready for review. Please take a look at your convenience 🙏

Still looks good. 👍

Thanks for your hard work. You finally made it! 🚀🥳

wow ! 👀  thank you for your effort ! I will check this feature latest version :) 👍


[NGOHOAITRONG] solution for assignment testing

Commit solution for assignment manabie #hoaitrong
please read README.md

### technologies

SQLite3
Gin
Gorm
httpTest
testing

### user guide and installation guide
Get source after that try run "go install" and "go build" then open togo.exe to start hosting
can use Postman or just patse this curl to send request to API
change userId to another number to switch to another user
curl --location --request POST 'http://localhost:8080/todo/add' \
--header 'Content-Type: application/json' \
--data-raw '{
    "task":"example",
    "userid":1
}'

to run api test  execute this command
"go test -timeout 30s -run ^TestAddTodoTask$ github.com/manabie-com/togo/test"
"go test -timeout 30s -run ^TestAddTodoTaskWithIncorrectParameter$ github.com/manabie-com/togo/test"

to run integration test execute this command
- go test -timeout 30s -run ^TestAddTodo$ github.com/manabie-com/togo/handlers
- go test -timeout 30s -run ^TestAddTodoLimitTask$ github.com/manabie-com/togo/handlers
- go test -timeout 30s -run ^TestGetUserById$ github.com/manabie-com/togo/handlers
- go test -timeout 30s -run ^TestCreateUser$ github.com/manabie-com/togo/handlers

NOTE
the reason I posted command to execute unit test because we can add it to CI/CD to make Unit test and intergrate test run for each PR was merged to main branch.

### What do you love about your solution?

I don't have many experience with go lang so I just use factory pattern to handle this task  , I think its good to maintenance and extension
I use some popular technologies so Its good to follow up and understand code.


testcases must ensure that the dont call baile() several times

get-psgi-response of Bailador::Test calles baile() every time.
that should messes up Bailador::Feature::AutoHead.

baile() should fail if called several times
fix testcases to only do that once.

see t/14-feature-autohead.t


destination=EXTERNAL_STORAGE doesn't save the downloaded file

I'm having trouble getting files to download onto external storage on my Pixel 3a running Android 12. If I set destination=LIBRARY, the files go into the standard Downloads folder with no problems. But if I set destination=EXTERNAL_STORAGE and plug a USB drive into my phone (via a USB-OTG adapter), I get this error:
Error: download fail: /storage/emulated/0/img00001.jpg: open failed: EPERM (Operation not permitted)

I have granted my Ionic app permission to access "File and media". Is there another permission that needs approval for external storage?
Also, does the filedownload plugin support web apps? I've tried running "ionic serve" and launching the app in Chrome, but the HTTP download request is never sent. No error is thrown, the download() function just return the object {"path":""}. I'm guessing the plugin doesn't support PWAs, but just wanted to make sure.

I'm having trouble getting files to download onto external storage on my Pixel 3a running Android 12. If I set destination=LIBRARY, the files go into the standard Downloads folder with no problems. But if I set destination=EXTERNAL_STORAGE and plug a USB drive into my phone (via a USB-OTG adapter), I get this error:

Error: download fail: /storage/emulated/0/img00001.jpg: open failed: EPERM (Operation not permitted)

I have granted my Ionic app permission to access "File and media". Is there another permission that needs approval for external storage?
Also, does the filedownload plugin support web apps? I've tried running "ionic serve" and launching the app in Chrome, but the HTTP download request is never sent. No error is thrown, the download() function just return the object {"path":""}. I'm guessing the plugin doesn't support PWAs, but just wanted to make sure.

currently not supported Web Download


[docs] update Thread version to 1.2 in README

We have a number of references to 1.1 in openthread.io docs as well (some on GitHub, some not). Should we update all those as well?

@Vyrastas , yes, we should update references to 1.2 where it makes sense.


TEST: add test for CrossTokens

As part of WsFed add tests for:
CrossToken_ValidateSignature
CrossToken_ValidateAudience
CrossToken_ValidateIssuer
CrossToken_ValidateLifetime

Closing since we don't have support for SAML tokens.


[Request]: show entity attribute?

What happened?
Can you make it possible to show entity attribute in the card?
Card Version
1.0.6
HomeAssistant Version
2022.6.2
Relevant log output
No response

I will take it under consideration, thx

I think it is already possible to show an attribute, please see:
https://www.home-assistant.io/dashboards/entities/#special-row-elements
attribute property


Update sbt to 1.5.8

Updates org.scala-sbt:sbt from 1.5.7 to 1.5.8.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Codecov Report

Merging #170 (9ae4c4c) into master (92e2054) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #170   +/-   ##
=======================================
  Coverage   98.27%   98.27%
=======================================
  Files           1        1
  Lines          58       58
  Branches        2        2
=======================================
  Hits           57       57
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92e2054...9ae4c4c. Read the comment docs.


Change chart type of applicant timezones from a pie chart to a map

To improve visualization, it's always best to find the best type of chart for representation. For timezones, it's more intuitive to show a map instead of a pie chart to get a better feeling where applicants are coming from.
/assign @leonardpahlke
/kind feature
see tracking issue: https://github.com/kubernetes-sigs/release-team-shadow-stats/issues/4

/remove-lifecycle stale

feature is currently not needed
/close