Question regarding kzetafinder_equation

https://github.com/EHTJulia/ScatteringOptics.jl/blob/c730f8e9dfefb1656e17e0cd6970df1bc06cfd9e/src/kzetafinders/periodicboxcar.jl#L18-L21
The referenced formula (Equation 47 of Psaltis et al. 2018) contains an additional kzeta in the argument to sinus. Is that potentially missing here?
Part of openjournals/joss-reviews#6354 .

A related question about kzetafinder_equation in src/kzetafinders/dipole.jl and src/kzetafinders/vonmises.jl , shouldn't the square difference be penalized instead of value - A^2?

We are very sorry that our response came very late. @annatartaglia had a career transition after we received the report and unfortunately, it took a long time for us to come back to work on the revision. The package revision is almost done and here we would like to answer your question.

The referenced formula (Equation 47 of Psaltis et al. 2018) contains an additional kzeta in the argument to sinus. Is that potentially missing here?
Thanks for carefully going through the equation. Indeed, this implementation is slightly different from Equation 47 of Psaltis et al. 2018. To our knowledge, Equation 47 has a typo --- this extra kzeta you found is not required. Unfortunately, for some reason, the paper didn't complete the review process or have another revision, and the typo has been left in the arxiv posting for a while.

You can find the correct model implemented in the current community standard package (e.g. see l.106 of this code in eht-imaging library). This is a reference implementation of Psaltis et al. 2018. We added the clarification in the source code (commit: https://github.com/EHTJulia/ScatteringOptics.jl/commit/a619d553c22a40d8092943bb7385d0ae932fdfac).

A related question about kzetafinder_equation in src/kzetafinders/dipole.jl and src/kzetafinders/vonmises.jl , shouldn't the square difference be penalized instead of value - A^2?

This came from the definition of NonlinearProblem in NonlinearSolve.jl used in the package.  NonlinearProblem needs the actual equation to be solved rather than the cost function (e.g. squared differences) for the optimization. We tried other optimization packages available in Julia (e.g. Optim.jl and Optimization.jl), and we found NonlinearSolve was the fastest among the packages we tried. This leads to the current implementation choice and definition of the equation.

Thank you for your detailed reply! This all makes sense :)


File system implementation

The way we store data must be approved by both @terahlunah and @c-m-green before starting the implementation.
Features

[ ] Save a language

[ ] Define what data we need to store ( ID, name, nb speakers, etc...)
[ ] Define the how the data are organized ( is there an header ? are section nested as in phonology : { phonem : {...}})
[ ] Define serialization method (Json ? yml ? )
[ ] Define file extension (.ls for langscaper? .lang ? .conlang ?)
[ ] Must be easy to import/export only a subsection (ex: phonological system, inventory, etc..)

[ ] Load a language
[ ] Autosave system (each 10 min ? at exit ?)

nb speakers
What's that?

serialization method
JSON

is there an header?
Yes, at least for a version field that would help evolving this file without breaking stuff

file extension
I like .lang

how the data are organized
Too early to tell, it will reflect the C# structure representing a language's data

Define serialization method (Json ? yml ? )

I'm more familiar with JSON, and I think it'll suit our needs.

Define file extension (.ls for langscaper? .lang ? .conlang ?)

Subjectively, I like .conlang.

summary of our discussions
Together, we validated :

Serialization : JSON, and must have an header with versionning
File extension : .conlang
A description field in the json
A user custom metadata list (key:value). Things like number of speaker could be put inside by the user.

To be discussed later :

Define what data we need to store
Define the how the data are organized


[253] Update coefficients from SPECPower Database (Q1&Q2 2021)

Description of Change
Fixes #253 - Updates coefficients based on new entries from the SPECpower_ssj2008 results for 2021:
Q1: https://www.spec.org/power_ssj2008/results/res2021q1/
Q2: https://www.spec.org/power_ssj2008/results/res2021q2/
Checklist

[x] PR description included and stakeholders cc'd
[x] tests are changed or added
[x] yarn test passes
[x] yarn lint has been run
[x] relevant documentation is changed or added (Google Sheet)

Notes
Values calculated in my copy of the "Cloud Carbon Footprint - CPU / Watts Research" spreadsheet, which also need to be merged in the main version as part of this PR.

Closing this PR as it was replaced by https://github.com/cloud-carbon-footprint/cloud-carbon-footprint/pull/333


Stderr should not receive all internal log message, only fatal

What are the steps to reproduce this issue?

Start any gravwell ingester/component
look at journal

What happens?
all of our debug logs and info logs are in there
What were you expecting to happen?
we should ONLY wire fatal logs out to stderr
Any logs, error output, etc?
Any other comments?
error is debatable, but definitely not info, and warn
What versions of software are you using?
5.4.2

LGTM


bug: Neovim immediately disconnects even on clean run - extension not working

Check the following:

[X] I have checked the behavior after setting "vscode-neovim.neovimClean" in VSCode settings.
[X] I have read the vscode-neovim docs.
[X] I have searched existing issues.

Neovim version (nvim -v)
0.10.0
Operating system/version
Ubuntu 22
Describe the bug
I just installed the extension, and after setting everything I cannot get the neovim service working. It immediately disconnects.
See debugging logs.

And output from log:
2024-06-20T19:11:01.882Z MainController: Starting nvim: /snap/bin/nvim -N --embed --cmd source /home/dominik/.vscode/extensions/asvetliakov.vscode-neovim-1.17.2/runtime/vscode-neovim.vim --clean
Steps To Reproduce

Install extension
Setup configuration
Run clean
Get immediate failures

Expected Behavior
Something to work

your screenshot shows a EACCES (permissions) error. that's probably related to snap.
try installing nvim without snap.

your screenshot shows a EACCES (permissions) error. that's probably related to snap.
try installing nvim without snap.

Yes this fixed it. Thanks!


feat: add initial source code

Reference issue
Example: Fixes #1234.
What does this implement/fix?
Explain your changes.
Additional information
Any additional information you think is important.

LGTM! :cookie: Very nice source code @emma-bailey
Merging this to master branch now to get it synched with 55 commits from the repo we forked from. Will create a refactoring branch and reference it here shortly

Continue refactoring in #3


Markdown import/export/shortcuts

YAMD - Yet another markdown
Another markdown attempt, this PR includes core files to support shortcuts, import and export. Follow up PR (I wish we had stacks here) will show the way it's used and extended to support custom tags and nodes
Markdown logic relies on transformers that define how text and nodes are processed. There are three types of transformers:

Block transformers: # heading, > quote, 1. list, etc. Top level elements, almost always have child nodes.
Text format transformers: * italic ** bold, ~~ strikethrough, etc. Can wrap other nodes (links), can be nested into each other (e.g. *Hello __world__*.
Text match transformers: [text](url) link, ![alt](url) images or any other text matching RegEx pattern. Can not have any nested nodes.

Shortcuts
Since this logic is executed while typing it tries to have quick checks before running any matching. For text format and text match transformers it has internal maps:
{
  "*": [bold transformer, italic transformer, bold italic transformer],
  "~": [strikethrough transformer],
...
  ")": [image transformer, link transformer]
}

When char under caret matches any of the map keys it tries to apply those transformers (although logic for text format and text matchers is slightly different given format might span across multiple text nodes). For blocks it's little less effective, as they are triggered by spaces (and spaces unlike * or ~ are more common, hence checked more often).
Import
Executes following for each line of text (with exception for multi-line code blocks):

Convert into top level element
Process text format tags (*, **, etc) starting for top most and then recursively processing any nested ones
Process text matches last (e.g. links [](url)) since they always applied to leaf nodes

Export
Recursively runs over tree and generating output string. Nothing fancy, except maybe for text formats it deduplicates opening/closing tags if sibling nodes have same format
API
Transformers are passed from outside, hence users can define their own subset of markdown rules and/or extend existing ones (e.g. add ^ to support superscript text format, or add tables with | block transformer, see next pr for examples). We have predefined list of transformers for most common use cases (MarkdownTransformers.js).
As of now, each transformer contains all settings needed for shortcuts, import and export. This approach follows current implementation for a good reason: you define one transformer that will be passed whenever markdown is used (whether it shortcuts, import or export), so there are less chances to forget adding it into three separate places. One cons: block and text match transformers look a bit bloated, especially if someone don't need export/import and only care about shortcuts, or vise versa:
TextMatchTransformer:
  // Export:
  export: (...) => string | null,   // conversion logic
  nodeType: string, // node type that should use this export fn (not added yet, but will improve exporter lookup time)

  // Shortcuts:
  regExp: RegExp,
  trigger: string, // trigger char (last char of closing tag, e.g. ")" for images/links)

  // Import:
  importRegExp: RegExp,

  // Import & shortcuts:
  replace: (node: TextNode, match: RegExp$matchResult) => void,

BlockTransformer =
  // Export:
  export: (...) => string | null, // : conversion logic
  nodeType: string, // node type that should use this export fn (not added yet, but will improve exporter lookup time)

  // Import & shortcuts:
  regExp: RegExp,
  replace: (...) => void, // conversion logic

TextFormatTransformer
  format: Array<TextFormatType>,
  tag: string, // symmetric open/close tag

Usage
// Import/export usage
const importMarkdown = createMarkdownImport(...DEFAULT_TRANSFORMERS);
const exportMarkdown = createMarkdownExport(...DEFAULT_TRANSFORMERS);

// Init editor with markdown
<RichTextPlugin
  initialEditorState={() => {
    importMarkdown("# Hello");
  }}
/>

<button onClick={() => importMarkdown("# Hello")} />
<button onClick={() => await saveMarkdown(exportMarkdown())} />

Alternatives
As we're not relying on any dependencies, it's quite lightweight solution which comes at cost of handling more advanced cases. Although we should try to cover most of those, it could be a good alternative to wrap something like markdown-it into a plugin and use it for importing markdown instead (with some conversion logic needed)
If you've read through and reached this line - thank you!

Another question - this doesn't support inserting markdown at the selection point, right? importMarkdown will just replace the entire editor state with the nodes generated from provided markdown?

Another question - this doesn't support inserting markdown at the selection point, right? importMarkdown will just replace the entire editor state with the nodes generated from provided markdown?

Ah, you're right. Should have selection as an optional argument for both import & export
I'll probably merge this one and open a follow up as I have all playground code and e2e tests in next PR and jumping between branches is no joy

Do we have some tests for all this?

#2000 has this markdown @ playground and related e2e's this one is only for core logic as I wanted it to be reviewed in isolation which does not sounds like a great idea anymore :)


Update admin key as optional param if CLI is not available

FYI: the lines added in this patch have CRLF endings, but the rest of the file does not.


Updating slices

Is there currently a way to update the value of a slice without completely redrawing the graph?

Have you got solution for this?

No sorry about that

ok


No download

Hi!
I get 2 responses
Scraping From Account: username
Skipped acc hypnotic_catsbecause of
'graphql'
Scraping From Account: username
Downloaded 0 videos successfully
Videos are not uploaded, even if set within 10 days

Script is working fine.
It's an Instalooter issue
Try running this script in a different environment. or check these solutions

Bug got fixed. Latest version v1.51.0 will be released soon!

Can we have an updated for this issue please?

Yep, I'm facing the same issue unfortunately

many people have this problem so we are waiting for a solution :D

Bug got fixed. Latest version v1.51.0 will be released soon!

When will it release? I am also getting hat graphql error

It seems that instalooter is not working properly. The same script runs without any errors sometimes, and sometimes it gives graphql error...
I'm searching instalooter alternatives or it would be better if  @althonos/instalooter gets #bug fixes
so that, script works!

It also gives this error:
File "C:\Users\surya\Desktop\BotTuber\botTuber.py", line 170, in routine
    dfile.write(description)
  File "C:\Users\surya\AppData\Local\Programs\Python\Python39\lib\encodings\cp1252.py", line 19, in encode
    return codecs.charmap_encode(input,self.errors,encoding_table)[0]
UnicodeEncodeError: 'charmap' codec can't encode characters in position 446-450: character maps to <undefined>

I'm not using emojis in title.

It seems that instalooter is not working properly. The same script runs without any errors sometimes, and sometimes it gives graphql error... I'm searching instalooter alternatives or it would be better if @althonos/instalooter gets #bug fixes so that, script works!

Some alternatives for instalooter: InstagramScarper and InstaPy
Instagram Scraper is light weight and will serve the purpose for scraping media and meta data from Instagram.

It also gives this error:
File "C:\Users\surya\Desktop\BotTuber\botTuber.py", line 170, in routine
    dfile.write(description)
  File "C:\Users\surya\AppData\Local\Programs\Python\Python39\lib\encodings\cp1252.py", line 19, in encode
    return codecs.charmap_encode(input,self.errors,encoding_table)[0]
UnicodeEncodeError: 'charmap' codec can't encode characters in position 446-450: character maps to <undefined>

I'm not using emojis in title. Thanks for the quick replies. 😊

Bug Fixed!! git clone once again!!

It seems that instalooter is not working properly. The same script runs without any errors sometimes, and sometimes it gives graphql error... I'm searching instalooter alternatives or it would be better if @althonos/instalooter gets #bug fixes so that, script works!

Some alternatives for instalooter: InstagramScarper and InstaPy
Instagram Scraper is light weight and will serve the purpose for scraping media and meta data from Instagram.

You got the spoilers!!
I'll be working on this soon!!

When I type python3 botTuber.py, it just gives me instruction. Can this be run if I just type this or do I always have to choose the option?

I installed the latest version but I still get 'graphql' and download 0 videos.. Do I need to change something?

any updates on this? 👀

It seems that instalooter is not working properly. The same script runs without any errors sometimes, and sometimes it gives graphql error... I'm searching instalooter alternatives or it would be better if @althonos/instalooter gets #bug fixes so that, script works!

Some alternatives for instalooter: InstagramScarper and InstaPy
Instagram Scraper is light weight and will serve the purpose for scraping media and meta data from Instagram.

You got the spoilers!! I'll be working on this soon!!

Any updates regarding this? 👀

It seems that instalooter is not working properly. The same script runs without any errors sometimes, and sometimes it gives graphql error... I'm searching instalooter alternatives or it would be better if @althonos/instalooter gets #bug fixes so that, script works!

Some alternatives for instalooter: InstagramScarper and InstaPy
Instagram Scraper is light weight and will serve the purpose for scraping media and meta data from Instagram.

You got the spoilers!! I'll be working on this soon!!

Any updates regarding this? 👀

Started Working  on it today... Will update soon!

Hey, can you tell me the python version you are using? May be that's the root of all the errors.

My python version is 3.9.10. I'm just getting 'graphql'..

Any updates on this? :)

Any update on this

My python version is 3.5 I'm just getting 'graphql'


Process Hangs with activated opcache

Hi,
tbh, I don't know if I am correct here,  but my research showed me earlier issues with interactions with opcache and revolt/event-loop so I hope you might be able to help us figure out this issue.
We have developed an AV SDK and at one point we decided to go async because of connection issues (basically using two connection one websocket and an https connection for an upload). So the first step we did is replacing our old Guzzle http-client with the amphp one replacing our upload feature.
With this SDK we build a nextcloud-app and ran into an issue that (for now, because its not released with that feature) only exists in our pipeline.
The setup locally and in the CI are almost the same, the tests that fail are run in a container but the behaviour differs. Locally everything works fine, but in the CI we always get the "Empty reply from server" error, what basically means the server did not answer. My assumption was that something (like a repeat or a delay) might sill be active in the eventloop but that would also have caused the issue on our local setup.
We could mitigate the issue by disabling the opcache via opcache.blacklist_filename and adding the whole amphp path to the blacklist, but that is almost not an option for the nextcloud app, because the blacklist has to have full-pathes and the customer would have to write it by semself.
I am basically helpless right now. Do you have any Idea, maybe at the SDK code, where use the http-client or some runtime-trick to prevent opcache from caching the amphp directory completely?
I also opened this issue for the amphp-httpclient.

what

Here you can find the coredumps from the apache child processes:
https://github.com/GDATASoftwareAG/nextcloud-gdata-antivirus/pull/98#issuecomment-2291117317
And in our Dockerfile we have an automated way to get the apache2 debug-symbols for our version:
https://github.com/GDATASoftwareAG/nextcloud-gdata-antivirus/blob/renovate/major-all-major-patch/Dockerfile.Nextcloud#L8-L15

With dump_bt we get this
(gdb) dump_bt executor_globals.current_execute_data
[0x7efca1750180] version_compare(false, "0.3.0", "<") [internal function]
[0x7ffd3f49eeb0] Amp\File\Driver\UvFilesystemDriver::__construct()
/var/www/html/apps/gdatavaas/vendor/amphp/file/src/Driver/UvFilesystemDriver.php:0

I always enable uv when I want segs.

The fact that \phpversion('uv') returned false but still ended up being passed to version_compare appears to be impossible given the current version of UvFilesystemDriver. Are you sure you're not using some ancient version?

OK dude. Chill.

This might just have been a Bug in amp/file but I will still get the output of composer Info for you

OK dude. Chill.

Sure. I'm unsubscribed from this thread. Good luck.

Since this was some code in amphp/file triggering some opcache bug, which has been resolved, I'm going to close this issue.


Renaming

This PR simply search-replaces all ACE1pack -> ACEpotentials. All tests pass for me locally.

I thought this would be a PR within the fork but apparently now So I'm closing this.


Quest 2 issues

Hello here, I've got bevy_openxr running on quest 2 (v57).
But ~20FPS with multiple messages "JniUtils-inl: Creating temporary JNIEnv. This is a heavy operation and should be infrequent…". Can't fix it out for few days.

 (Update --release used, like cargo apk run --release --example xr)
Other issue I faced. Maybe helpful for others.

how can example work without #[bevy_main]? had to add it
had to add this in vulkan.rs

#[cfg(target_os = "android")]

xr_entry.initialize_android_loader().unwrap();

had to change vulkan versions to 1.1 from 1.2 in vulkan.rs
had crashes "Unable to load get_semaphore_counter_value". Found fix here https://github.com/kcking/bevy/blob/xr/crates/bevy_openxr/src/presentation.rs#L67

instance_extensions.retain(|ext| ext != &vk::KhrGetPhysicalDeviceProperties2Fn::name());

Somehow I overlooked android branch. https://github.com/awtterpip/bevy_openxr/tree/android
Setting primary window to None was crucial to get FPS up. That was last part.
primary_window: None,
exit_condition: ExitCondition::DontExit,

Now xr example on quest 2 ~70FPS !!!
lto = "fat" also helps a little.


Password strength checker

In this project the more strong password -> the more clearer background picture will be.
Could you assign me this issue please @Subhradeep10

@invad3r07 Assign to you


Update 07_RAG_Generator.md

Fixed a grammatical error in the tutorial md file

Hello @CarterT27...
Thanks for the contribution.
To modify to the tutorials, you should edit the ipynb notebook then generate the updated markdown files as specified here.
Probably it was not very clear. @bilgeyucel is currenty improving the contributing guide (#119).

This was fixed, and we made the contribution process simpler so that you don't have to generate markdowns, simply edit the .ipynb :) thanks for the fix!


Compatibility issue with spatie/nova-translatable

It doesn't work with https://github.com/spatie/nova-translatable, could someone help me identify and solve the problem?

@fede91it could you supply an example?

@wize-wiz Not OP, but I ran into the same problem today. I'm trying to have a Textfield that's translatable and which depends on the value of a select. The code I'm trying to get to work is quite simple:
NovaDependencyContainer::make([
    Translatable::make([
        Text::make('Service', 'service')
    ]),
])->('type', VoucherType::SERVICE)

But it fails in NovaDependencyContainer::resolveAttribute() when it tries to call $field->resolveForDisplay($resource) which does not exist on the Spatie Translatable Field.
Here's the code of the method that throws (NovaDependencyContainer.php on line 164):
protected function resolveAttribute($resource, $attribute)
{
    foreach ($this->meta['fields'] as $field) {
        // changed to resolveForDisplay(), resolve() will be called when displayCallback is empty.
        $field->resolveForDisplay($resource);
    }

    return [];
}

The error message is:
"Call to undefined method Spatie\\NovaTranslatable\\Translatable::resolveForDisplay()
Translatable extends MergeValue instead of Field, so there is no resolveForDisplay(...). Internally Translatable creates multiple fields (with their names being suffixed by _$locale), so I tried to modify resolveAttribute(...) so that it calls resolveForDisplay(...) on the nested fields (the ones created by Translatable). It no longer throws, but the translated fields do not show up in the backend. Let me know, if you need anything else.

@ThisIsJustARandomGuy Thanks for the input. Just out of curiosity, what does ])->('type', VoucherType::SERVICE) exactly do?
Just be clear here, this is not a problem with spatie/laravel-translatable, but the nova package mrmonat/nova-translatable, right?
The nova translatable field does extend from Field. So resolveForDisplay should work like no other.
I'll look into it.

Aah its this package spatie/nova-translatable :)

@ThisIsJustARandomGuy
I haven't tested it yet, but this should fix the problem.
Translatable calls $this->createTranslatableFields(); in __construct
    public function __construct(array $fields = []) {
        ...
        $this->createTranslatableFields();
    }

which calls $this->data[] = $this->createTranslatedField($field, $locale); in the eachSpread callback at the bottom. Which sets a resolve callback and returns the cloned $originalField.
$translatedField = clone $originalField;

$translatedField
    ->resolveUsing(function (...) {
        ...
    });

return $translatedField;

So the $translatedField lands in the public $data property of MergeValue. Iterating over each translateField in public $data and call resolveForDisplay should fix the problem. You could replace this method and give some feedback till I have the time to implement a clean compatibility fix for all these Nova packages.
protected function resolveAttribute($resource, $attribute)
    foreach ($this->meta['fields'] as $field) {
        // patch for nova-translatable
        // https://github.com/epartment/nova-dependency-container/issues/40
        if(is_a($field, \Illuminate\Http\Resources\MergeValue)) {
            foreach($field->data as
                $field->resolveForDisplay($resource);
            }
            return [];
        }
        // changed to resolveForDisplay(), resolve() will be called when displayCallback is empty.
        $field->resolveForDisplay($resource);
    }
    return [];
}

@ThisIsJustARandomGuy sorry, I updated the comment a view times. Try the fix if you like and if it works, let me know, I'll pull it in the next release.

@wize-wiz Sorry for the late reply. I missed some code in my original comment. It should say ->dependsOn('type', Voucher::SERVICE). I'll edit my comment. Anyways, thank you for the quick and thorough reply! I'll test this tomorrow morning and will give feedback.

@wize-wiz I got it to work correctly by overriding the NovaDependencyContainer constructor with a slightly altered version of your patch:
public function __construct($fields, $attribute = null, $resolveCallback = null)
{
    parent::__construct('', $attribute, $resolveCallback);

    $metaFields = [];
    foreach ($fields as $field) {
        // patch for nova-translatable
        // https://github.com/epartment/nova-dependency-container/issues/40
        if ( is_a($field, MergeValue::class) ) {
            foreach ($field->data as $translated_field) {
                $metaFields[] = $translated_field;
            }
            continue;
        }
        $metaFields[] = $field;
    }

    $this->withMeta([ 'fields' => $metaFields ]);
}

That doesn't seem right even if it might fix the problem. The translatable container should manage resolving its own fields, I'll look into this problem when I have some more time to test around.

Still... https://github.com/spatie/nova-translatable/issues/34

I'm facing same issue. does anybody have a solution for this?


documentation_url -> documentationUrl everywhere

for #30514
cc @howardjohn

@adiprerepa: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ac69f888974ea49178ead2fe9591e837034acd64
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@adiprerepa: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
ac69f888974ea49178ead2fe9591e837034acd64
link
/test unit-tests_istio

integ-multicluster-k8s-tests_istio
ca27205f92c95423bf76050ab7aefd9e2f980cb4
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@adiprerepa: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
ca27205f92c95423bf76050ab7aefd9e2f980cb4
link
/test integ-multicluster-k8s-tests_istio

integ-pilot-multicluster-tests_istio
ca27205f92c95423bf76050ab7aefd9e2f980cb4
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


migrate to swift 3.0

Migrating to swift 3.0.
Ran through XCode converter and make minimal changes to remove the errors and warnings.

@dekatotoro any updates on this PR?
Swift 3 now can be submitted onto AppStore

Hi @hyb175 & @OdNairy
The actual version works great with Swift 2.3 and Swift 3.
https://github.com/dekatotoro/SlideMenuControllerSwift/commit/a74a0a26c21a49dcd4ed0c24fb352a68f89eff33
Thanks

Paolo


no instance declaration for Monad GameAction

First of all, sorry if I am building this wrong I just started with Haskell and cabal and everything but when I try to compile it I get
[ 8 of 13] Compiling HaskellGame.GameMonad ( src/HaskellGame/GameMonad.hs, dist/build/haskell-game/haskell-game-tmp/HaskellGame/GameMonad.o )

src/HaskellGame/GameMonad.hs:18:10: error:
    • No instance for (GHC.Base.Applicative GameAction)
        arising from the superclasses of an instance declaration
    • In the instance declaration for ‘Monad GameAction’
   |
18 | instance Monad GameAction where
   |          ^^^^^^^^^^^^^^^^```

The build probably fails because the game was written before this.
To fix it, add the following to src/HaskellGame/GameMonad.hs:
import Control.Monad (ap, liftM)
instance Functor GameAction where
  fmap = liftM

instance Applicative GameAction where
  pure  = return
  (<*>) = ap

and replace
import Prelude import Prelude ( Monad(..), ($) )

by
import Prelude ( Monad(..), ($), Applicative (..), Functor (..))


Add Yii2 extension reference to README

Give me some time to think about this. :)

I've decided that I don't want to encourage people to have an automated loading system given that it's so quick and easy for people to write one for themselves.

@GrahamCampbell , I see that you added CakePHP integration reference on the Readme. Can we reopen this pull-request then?

Meh, added it. I might remove them both though. Not decided yet.

I don't think an integration is needed, that's all.

The reason why it's needed in Yii2 is because of error handling. Errors happening at the model instantiation/creation/update/delete are not logged by default. The integration piece takes care of these issues among other framework specific issues.


Add number of spans to recent activity

Add a 'Spans' column to the recent activity with the number of spans in the latest trace
https://www.figma.com/design/MxA95ZHK5NqGX4ptFQljRJ/⭐-Design-System-3.0?node-id=12740-161603&t=DEMQpTiVJrhd4wP5-11

min back version
v0.3.118


tiktok icon

Icon Request

Icon name: tiktok
Tags of this icon: tiktok
Use case: titok
Screenshots of similar icons:

Here's the Tiktok icons
https://remixicon.com/icon/tiktok-line
https://remixicon.com/icon/tiktok-fill


proto: annotate errors regarding invalid UTF-8 with the relevant field

Is your feature request related to a problem? Please describe.
string field contains invalid UTF-8 errors while marshaling using the new Go proto library google.golang.org/protobuf, but it's too difficult to debug since one doesn't know which field has the problem.
Describe the solution you'd like
Add the field name to the error message. Something like:
string field "foo" contains invalid UTF-8

Describe alternatives you've considered
Looks like the issue is related to directly converting from a slice of bytes to a string.
string([]byte)

If that's the case, one could potentially triage that, but the field name would much more helpfull.
Additional context
This is using the new golang google.golang.org/protobuf module at v1.25.0 at least.

Annotating errors with this information seems reasonable. If we do this or marshal, we presumably want to do it for unmarshal as well.
At least for unmarshal, we removed context from most errors since it was often misleading as to what the exact problem is. For example, unmarshaling random garbage would often produce an error saying that some specific field was the issue, when really the entire input was bad. This occurs because the protobuf wire format has no magic number. For invalid UTF-8, it seems unlikely to encounter this error due to random data since the data would first have to pass the length-prefix check.
Another concern I don't know the answer to is what the performance cost of this is. There's cost in allocating a new error value that contains the field information, and there may be cost passing the field information up/down the call stack.
\cc @neild.

I think it makes sense to include the field name for marshal/unmarshal errors caused by invalid UTF-8. It's been somewhere on my to-do list; just hasn't risen to the top of it yet.
I'm not worried much about the cost of allocating a new error in this case, but we do want to be sure that there isn't any additional cost paid by other errors or the non-error path.

Yeah, seems like the costs of allocating the new error would be limited by the number of messages that have utf8 errors in them, which unless you’re getting hit with a bunch of bad actors, seems unlikely to be as big of a concern. (But it has been known to accidentally turn quadradic before… 😬 )

There are almost certainly going to be better attack vectors on making unmarshal operations expensive than triggering an error allocation, so I'm not too worried about that case. (As long as we don't make it ridiculously expensive by accident, of course.)

+1

+1

Any chances we might see some action on this :)?

+1

+1

@neild @dsnet since we have in Go error.As and error.Is and error.Wrap/Unwrap it seems now to be possible to do this.
I observed these errors similar to other referenced issue in opentracing (and OTel).

+1

any updates on this?


Crash with extratic mod using rftools-2.30.n51

Like the title says man . :)
The crash is http://pastebin.com/FrvL5wLq
This crash stops when going back to rftools-2.21.n45 and crashes with any version up to rftools-2.30.n51 from rftools-2.21.n45. Thanx
-Crunk

Ok thanks for the report and the effort of finding exactly from which version it starts failing. Much appreciated!

Strange that it doesn't crash in RFTools code however...

Lol yeah that is a bit strange . Took me awhile to find the mod causing it because when i update mods its usually quit a few at a time . Like i said i had to go all the way back to n45 of your mod before the crash went away . It might be extra tic needs to add support to your nod

Should be fixed now

Thanks man it is. :) I really appreciate it .


Unexpected error occurred: "https://registry.yarnpkg.com/spellcheck-tech-word: Not found".

Caused here.
error: An unexpected error occurred: "https://registry.yarnpkg.com/spellcheck-tech-word: Not found".

🤔 Seems to my error, this should be textlint-rule-spellcheck-tech-word instead.


[RFE] Support for additional authentication

Thanks for this awesome operator!
I would like to suggest adding extra authentication methods in addition to Kubernetes one. Maybe using a Vault token can be enough in a first step (like here in cert-manager: https://cert-manager.io/docs/configuration/vault/#authenticating-with-a-token)

If I get it correctly, you mean additional methods to authenticate to Vault, not additional auth engines. What would the use case be?
the kubernetes method is designed to use the pod identity to authenticate to Vault.

Yes exactly. We use SPIFFE  to authenticate to Vault, either through JWT or through TLS client certificates (including Kubernetes workloads) by using an identity federator which gives identities to workloads (something similar to what is done here: https://cloud.redhat.com/blog/fine-grained-iam-roles-for-openshift-applications). The reason for that is the difficulty to manage the Kubernetes authentication in Vault at scale : if you have dozens of Kubernetes clusters to manage and also dozens of Vault instances, it means that every time you add cluster you need to change Vault configuration in order to add the additional cluster. That can be OK if the team who manages the Vault instances is the same as the one who manages the Kubernetes clusters. But if they are different it can be a mess. And it's even a bigger mess if you have several teams managing several fleets of Kubernetes and several fleets of Vault instances.

P.S: the reason why I proposed Vault token authentication instead of OIDC/JWT or TLS is that Vault token is more flexible, since it's more universal/flexible and leaves the the choice of getting Vault token to the user by using any authentication method he wants.

LDAP authentication has been added.


can you tell me where to put FirebaseEventListener inside this MVP project?

Hi, I have small doubt on using android FirebaseEventListener inside my project. I don't know where to put it inside MVP architecture, But am sure it is a kind of database Interactor, that get data from firebase db. What I planned to do is creating another class same like preference,database,api reference is enough to satisfy the firebase request coming from the view. Is it ok, if not, can you tell me what kind of class(singleton/not) i have to create and where to put that class.

Thanks, is that the way or there is any other way for doing this, because i have used some github android project they also used the same way you mentioned above.

I will try that


Error while running hyperctl info

@laijs I know this is an old issue but I ran into the same issue  I even posted on slack but so far not much help from there.. but I  get the same error when I run hyperctl info:
hyperctl ERROR: An error occurred trying to connect: Get http://%2Fvar%2Frun%2Fhyper.sock/v0.8.1/list?item=pod: dial unix /var/run/hyper.sock: connect: no such file or directory
and here is the log as you suggested:
Log file created at: 2017/06/24 20:57:49
Running on machine: localhost
Binary: Built with gc go1.8.3 for linux/amd64
Log line format: [IWEF]mmdd hh:mm:ss.uuuuuu threadid file:line] msg
I0624 20:57:49.122851 18247 config.go:38] config file: %!(EXTRA string=/etc/hyper/config)
I0624 20:57:49.123234 18247 config.go:72] [/etc/hyper/config] config items: &types.HyperConfig{ConfigFile:"/etc/hyper/config", Root:"/var/lib/hyper", Host:"", GRPCHost:"", StorageDriver:"", VmFactoryPolicy:"", Driver:"qemu", Kernel:"/var/lib/hyper/kernel", Initrd:"/var/lib/hyper/hyper-initrd.img", Bridge:"", BridgeIP:"", DisableIptables:false, EnableVsock:true, DefaultLog:"", DefaultLogOpt:map[string]string{}, logPrefix:"[/etc/hyper/config] "}
I0624 20:57:55.170355 18247 daemon.go:215] The hypervisor's driver is qemu
I0624 20:57:56.299793 18247 migration.go:23] Migrate lagecy persistent pod data, found: 0, migrated: 0
I0624 20:57:56.310088 18247 hyperd.go:189] Hyper daemon: 0.8.1 v0.4.0-912-g7a07c71
I0624 20:58:37.811799 18247 daemon.go:357] The daemon will be shutdown
I0624 20:58:37.811826 18247 daemon.go:358] Shutdown all VMs

Did the daemon shutdown by yourself or the OS? Try increase the hyperd log level with -v=4

No it is the OS

Then check what's the problem with OS. Based on the current logs, It's hard to judge what's the matter.

Actually I had to compile from source because I was unable to install using the bash script.. I am using Linux korora 25 but It's just Fedora 25 under the hood.. I mean:
uname -a
Linux localhost.localdomain 4.11.5-200.fc25.x86_64 #1 SMP Wed Jun 14 17:17:29 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
Or is it a problem when using Fedora beacuse I also tried to install hyper on machine running project atomic/fedora25 but It complained saying it only supports Fedora 23..but i believe it is mentioned on github that fedora 25 is supported..

Build from source won't break anything and FC25 is supported as well.

As I mentioned in the first comment, try increase the log level, maybe we could found why it quit.

Thanks a lot @gnawux . It's now working!!
Here are the issues and steps I took in case someone else gets the same problem..

cd /etc/hyper  and uncomment  the Hypervisor line and assign a value accordingly(libvirt,kvm,qemu)
enable hyper daemon with systemctl enable hyperd
start hyper daemon with systemctl start hyperd
N.B: step 2 and 3 only apply if you are using systemd, for example ubuntu 14  is still on init so adjust accordingly..
systemctl status hyperd if you get running and enabled you are good to go
sudo hyperctl list works!!

Good to know it works. And the default hypervisor would be qemu if no one is specified, as shown in the log
I0624 20:57:55.170355 18247 daemon.go:215] The hypervisor's driver is qemu

Yeah, I see..well I guess you can close this one. next stop Hypernetes!!

Enjoy it 👍


Empty error message when linting error code expression in 8.1

Describe the bug
Error message is empty when validating error code expression in 8.1:

Steps to reproduce

Open error-throw-error.bpmn
See empty error in log

Expected behavior
Descriptive error is shown in log. Works for escalation event not supported, for example.
Environment

OS: Linux
Camunda Modeler Version: v5.8.0
Execution Platform: Camunda Cloud
Installed plug-ins: None

Additional context
No response

CC @philippfromme.
May be an easy fix.

The issue is in @camunda/linting error-messages.js#L491
In the model shared by @nikku the parentNode's type is bpmn:EndEvent however  the if/elseif branch in the code only checks for bpmn:CatchEvent  and thus falls through.
Should implement both an explicit message for bpmn:EndEvent as well as an else statement to catch anything else.
Attaching snapshot of the linting result object:

@barmac 👀

Will be fixed via https://github.com/camunda/linting/pull/45


Add configuration field to customize the pr body

Motivations
Not everyone like the default release PR body.
Solution
Add a config field called pr_body. Similar to the git_tag_name field, the pr_body field should be a tera template.
Edit this function.
You need to add to the template a context with the array {{ releases }} (Similar to how {{ remote.contributors }} works in git_release_body).
Those two should be two objects so that people can format them how they want.

array releases (to find all these data check in changes and updates_summary functions:

package (e.g. my_package_name)
title (e.g. [0.3.96](https://github.com/MarcoIeni/release-plz/compare/release-plz-v0.3.95...release-plz-v0.3.96) - 2024-10-05)
changelog (e.g. ### Added ...)
previous_version (e.g. 1.2.3)
next_version (e.g. 1.2.4)

Alternatives

Additional context

asked in https://github.com/MarcoIeni/release-plz/issues/1738

Hi, @MarcoIeni, I going to give a shot to this too, it would be great if you could assign it to me.

thanks, done! :)

I opened https://github.com/MarcoIeni/release-plz/issues/1788 which is related to this issue.
Mainly to improve the docs 👍


SFCC-CI deployment Error

Hi,
One of the customers is facing an issue while trying to deploy the code to staging using SFCC-CI with 2FA. But they are getting below error:
Error: Network or certificate error
Error: An error occured. Try running the command again with -D,--debug flag.
[DEBUG] Error code: EPROTO, message: write EPROTO<PHONE_NUMBER>:error:14094410:SSL routines:ssl3_read_bytes:sslv3 alert handshake failure:../deps/openssl/openssl/ssl/s3_pkt.c:1498:SSL alert number 40
4447045056:error:1409E0E5:SSL routines:ssl3_write_bytes:ssl handshake failure:../deps/openssl/openssl/ssl/s3_pkt.c:659:
, stack: Error: write EPROTO<PHONE_NUMBER>:error:14094410:SSL routines:ssl3_read_bytes:sslv3 alert handshake failure:../deps/openssl/openssl/ssl/s3_pkt.c:1498:SSL alert number 40
4447045056:error:1409E0E5:SSL routines:ssl3_write_bytes:ssl handshake failure:../deps/openssl/openssl/ssl/s3_pkt.c:659:
We have checked that their certificate is still valid till 2027. Could anyone point why this may be coming.

Hi @mayankshukla10,
is the cert (and passphrase) working if using another client to deploy code to staging?

I have this issue also. I was able to upload code to our 2FA environment by running manual commands from the Jenkins slave server. When I add certificate to jenkins and attempt automation, I get:
sfcc-ci code:deploy -D version2.zip -i cert.staging.web.****.demandware.net -c **** -p ****
[DEBUG] No dw.json found in d:\jenkins\workspace\Test_jobs\Deploy_to_PODs
REQUEST {
baseUrl: 'https://cert.staging.web.****.demandware.net',
uri: '/on/demandware.servlet/webdav/Sites/cartridges/version2.zip',
auth: { bearer: 'r0lZyc1pCCiW-fcceA1wROXV-Ng' },
strictSSL: true,
method: 'PUT',
callback: [Function]
}
REQUEST make request https://cert.staging.web.****.demandware.net/on/demandware.servlet/webdav/Sites/cartridges/version2.zip
{
request: {
debugId: 1,

uri: 'https://cert.staging.web.****.demandware.net/on/demandware.servlet/webdav/Sites/cartridges/version2.zip',

method: 'PUT',

headers: {

  host: 'cert.staging.web.****.demandware.net',

  authorization: 'Bearer r0lZyc1pCCiW-fcceA1wROXV-Ng',

  'content-type': 'application/zip'

}

}
}
Error: Network or certificate error
Error: An error occured. Try running the command again with -D,--debug flag.
[DEBUG] Error code: EPROTO, message: write EPROTO 12500:error:14094410:SSL routines:ssl3_read_bytes:sslv3 alert handshake failure:c:\ws\deps\openssl\openssl\ssl\record\rec_layer_s3.c:1544:SSL alert number 40
, stack: Error: write EPROTO 12500:error:14094410:SSL routines:ssl3_read_bytes:sslv3 alert handshake failure:c:\ws\deps\openssl\openssl\ssl\record\rec_layer_s3.c:1544:SSL alert number 40
at WriteWrap.onWriteComplete [as oncomplete] (internal/stream_base_commons.js:92:16)

script returned exit code 1

I have this issue also. I was able to upload code to our 2FA environment by running manual commands from the Jenkins slave server. When I add certificate to jenkins and attempt automation, I get:
sfcc-ci code:deploy -D version2.zip -i cert.staging.web.****.demandware.net -c **** -p ****
[DEBUG] No dw.json found in d:\jenkins\workspace\Test_jobs\Deploy_to_PODs
REQUEST {
baseUrl: 'https://cert.staging.web.****.demandware.net',
uri: '/on/demandware.servlet/webdav/Sites/cartridges/version2.zip',
auth: { bearer: 'r0lZyc1pCCiW-fcceA1wROXV-Ng' },
strictSSL: true,
method: 'PUT',
callback: [Function]
}
REQUEST make request https://cert.staging.web.****.demandware.net/on/demandware.servlet/webdav/Sites/cartridges/version2.zip
{
request: {
debugId: 1,

uri: 'https://cert.staging.web.****.demandware.net/on/demandware.servlet/webdav/Sites/cartridges/version2.zip',

method: 'PUT',

headers: {

  host: 'cert.staging.web.****.demandware.net',

  authorization: 'Bearer r0lZyc1pCCiW-fcceA1wROXV-Ng',

  'content-type': 'application/zip'

}

}
}
Error: Network or certificate error
Error: An error occured. Try running the command again with -D,--debug flag.
[DEBUG] Error code: EPROTO, message: write EPROTO 12500:error:14094410:SSL routines:ssl3_read_bytes:sslv3 alert handshake failure:c:\ws\deps\openssl\openssl\ssl\record\rec_layer_s3.c:1544:SSL alert number 40
, stack: Error: write EPROTO 12500:error:14094410:SSL routines:ssl3_read_bytes:sslv3 alert handshake failure:c:\ws\deps\openssl\openssl\ssl\record\rec_layer_s3.c:1544:SSL alert number 40
at WriteWrap.onWriteComplete [as oncomplete] (internal/stream_base_commons.js:92:16)

script returned exit code 1

how did you resolve this error?

could you please share how did you resolve this error?

@jiahuichen93 In most of the case a re-generation of the client cert has solved this problem. Please make sure, you are using the right cert bundle for the client cert generation. If you are unsure, you can always request the current cert bundle by opening a Salesforce Support Case.

I'm also having the same error for code version activation but code upload works fine. I'm doing manual activation.


added filtering

added lowpass, highpass, bandpass, randomized filtering functionalities, and their corresponding testing functions

Thanks @lylyhan !  Can you fix the merge conflicts before we start a code review?  Either way of doing it is fine (web editor or command line).  Let me know if you need assistance getting it sorted out.

OK! i revised all suggestions above (replaced already implemented functions, revised __test_xx_filter series, corrected the messed up merge), pytest now pass on all functions.
please review :)


rpcserver+lnd_test: fixing unassigned UnsettledBalance field

fixes #2274
This PR adds a loop that sums the amount of PendingHtlcs to the UnsettledBalance field for Channels. Also adds a test in lnd_test to ensure that the UnsettledBalance field is actually updated.

@cfromknecht Thanks for review! appreciate the insights into the  tests, I'll update according to the comments

@cfromknecht I've updated the PR according to the suggestions but it's strange I'm receiving no test failures when I run make check locally but failing in travis?

@ccdle12 The Travis failure is unrelated to your change, I'm working on a fix :)

@halseth thanks! definitely puts my mind at ease a bit :)

@wpaulino thanks, appreciate the detailed review, I'll get started on the comments


feat: specify the GOOS/GOARCH to build in '.goreleaser.yml'.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[x] N
[ ] Y

2. What is the scope of this PR (e.g. component or file name):

.goreleaser.yml
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[x] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[ ] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[x] Other

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 40.363%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
913

Relevant Lines:
2262

💛  - Coveralls


*: Show return values of traced functions

This patch enables the trace command to take advantage of the return
value distinction present in the debug info of binaries produced with a
sufficiently new Go compiler.

Closing this for now, I will have a new implementation of this up by early next week.


fix(changelog): consider placeholder for old version

ref https://github.com/python-semantic-release/python-semantic-release/issues/652

hi @bernardcooke53 , do you know if there are test cases to cover the case where template_dir does not exist?

Hi @roggervalf - apologies, I've been quite unwell for the last couple of weeks and haven't really been able to look at this. I will try to look in more detail in the next couple of days, I would like to see an additional piece of logic:

If the changelog placeholder is detected, emit a warning of deprecation before falling back to the old behaviour implemented
I don't want to put the placeholder into the default changelog template, but I'm ok with a "legacy" changelog template that has one; or a switch to add it to the content.

I appreciate that might not be the most clear explanation, will come back to this in the near future

Hi @roggervalf - apologies, I've been quite unwell for the last couple of weeks and haven't really been able to look at this. I will try to look in more detail in the next couple of days, I would like to see an additional piece of logic:
* If the changelog placeholder is detected, emit a warning of deprecation before falling back to the old behaviour implemented

* I don't want to put the placeholder into the default changelog template, but I'm ok with a "legacy" changelog template that has one; or a switch to add it to the content.

I appreciate that might not be the most clear explanation, will come back to this in the near future

thank you @bernardcooke53, no worries, take your time


Recognize .nl email addresses

We have customers in Netherlands that reported this to us -- emails there end with the .nl extension, and whenever they enter it into our form, the mailcheck comes back with a ".net" extension instead.
I think it would be good to have mailcheck recognize the .nl email extension.

Ignore this, I just recognized that you offer the ability to input our own domains.


Uncaught ReferenceError: regeneratorRuntime is not defined

Expected Behavior
Jimp browser version should load
Current Behavior
Jimp fails to load in browser
Failure Information (for bugs)
index.js?c2d7:3 Uncaught ReferenceError: regeneratorRuntime is not defined
Steps to Reproduce
import Jimp from "jimp/es"
Screenshots
NA
Context
Browser, trying to use jimp in @vue-cli project

Jimp Version:0.8.2
Operating System: Windows 10
Node version: 12.10.0

Failure Logs
Uncaught ReferenceError: regeneratorRuntime is not defined
    at eval (index.js?c2d7:3)
    at<EMAIL_ADDRESS>(app.js:1259)
    at __webpack_require__ (app.js:727)
    at fn (app.js:101)
    at Module.eval (index.js?67ea:1)
    at eval (index.js:1303)
    at<EMAIL_ADDRESS>(app.js:855)
    at __webpack_require__ (app.js:727)
    at fn (app.js:101)
    at eval (index.js?0383:1)

I'm getting the same problem

Are you using TypeScript @mubaidr ?

FWIW, I'm using TS, trying to call the configure code, and hitting the same problem. However, if I try using the values that TS is clearly MEANING to handle, it is hitting this problem.

Adding the following into my TS config has fixed the problem:
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,

I admit total fault for removing this from the README. I'll make a PR to add this back

Wait, I'm confused. It seems that I had to add both:
yarn add -D regenerator-runtime
As well as the esModuleInterop and allowSyntheticDefaultImports to work properly. I'm unclear what's exactly happening. Let me see if I can narrow scope of when this occured (please not 0.8, please not 0.8, please)

Related https://github.com/oliver-moran/jimp/pull/783

I realized that there is two different problems going on here. There's an issue I'm having using default that requires docs changes to add the:
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,

Back in, and another that is likely related to the PR you linked. I'm looking into it currently

With the babel stuff I really don't know what to do. It's either:

add polyfill stuff = people complain
dont add polyfill stuff = people complain

🤷♂

This is one of the many engineering contraints in maintaining any library. I'd suggest finding a stance you approve of and maintaining it (as it's your codebase as the maintainer).
I tend to lean towards adding polyfil stuff as it reduces the workload of maintainers like you and I (who I'm certain only do this as a side-project), but there's little-to-no perfect answer for this
I think there's more work that can be done with babel as well - I'm going to see about upgrading the corejs version and fixing this problem at the same thing, as it's impacting https://github.com/akfish/node-vibrant/issues/96. Let me know if you change your mind on the way things are done and don't want to do more with babel and rather just remove it

I'd love to just target node 8 + browser. node 8 has all es6 and es7 so the could should mostly be fine. for older browsers I think we would need to include babel stuff.
I really don't care either way, just as long as we go with the majority of use cases.

I think that's a good idea too - especially given that Node 8 is now LTS

same problem here, and unfortunately the tsconfig update didn't help
"esModuleInterop": true,
"allowSyntheticDefaultImports": true,

I have a webpack build which is deployed to AWS lambda

Nothing works when I try to import Jimp in ts file :(

same here, even when using plan js with serverless-webpack
downgrading back to 0.6.4 fixes the issue

Same here, thanks to @vanerleo, downgrading to 0.6.4 is my workaround for now.

I'm working in electron w/ webpack and seeing the same error as the original poster in Jimp 0.8.5.
The standard workarounds that have worked for me w/ other projects don't seem to be doing the trick, ie:
"presets": [
    ["@babel/preset-env", {
      "useBuiltIns": "usage",
      "corejs": 3
    }],
    "@babel/preset-react"
  ],

and
["@babel/plugin-transform-runtime",
      {
        "regenerator": true
      }
    ]

I've also tried telling webpack to explicitly run babel-loader on jimp via the following updated webpack rule:
  {
    test: /\.js$/,
    //exclude: /node_modules/,
    exclude: /node_modules\/(?!(jimp)\/).*/,
    use: [
      { loader: "babel-loader"}
    ]
  },

but no dice..
Similar to @vanerleo  and @RomainFallet  - i've had to revert to v0.6.4 to run.
Please feel free to pull in a simple electron project that shows the problem (and does a basic demo of jimp): https://github.com/andrewrt/jimp-ef6
(Running in 0.6.4 - if you upgrade back to 0.8.5 - breaks on both windows & osx)
While I'm not using typescript - was thinking the above babel stuff should cover me...

@andrewrt @RomainFallet  can you test against 0.8.6-canary.815.488.0 to confirm a fix?

@crutchcorn I tried using the version you have here and when I invoke my lambda function with Serverless (aws, serverless, lambda), I get a different error:
`{
"errorType": "TypeError",
"errorMessage": "Cannot assign to read only property 'exports' of object '#'",
"trace": [
"TypeError: Cannot assign to read only property 'exports' of object '#'",
"    at Object. (/var/task/webpack:/node_modules/@jimp/core/es/request.js:34:10)",
"    at Object.call (/var/task/handler.js:9:283271)",
"    at r (/var/task/webpack:/webpack/bootstrap:19:22)",
"    at Module.call (/var/task/handler.js:25:14004)",
"    at r (/var/task/webpack:/webpack/bootstrap:19:22)",
"    at Object.call (/var/task/handler.js:9:310475)",
"    at webpack_require (/var/task/webpack:/webpack/bootstrap:19:22)",
"    at /var/task/webpack:/webpack/bootstrap:83:10",
"    at Object. (/var/task/handler.js:1:968)",
"    at Module._compile (internal/modules/cjs/loader.js:778:30)"
]
}
`

Thanks for the feedback, @divinealpine. Can you show me the code you used to do imports and running?

Are you using babel?

Yep, using typescript.
tsconfig.json:
{   "compilerOptions": {     "esModuleInterop": true,     "allowSyntheticDefaultImports": true,     "sourceMap": true,     "target": "es6",     "lib": [       "esnext",       "dom"     ],     "moduleResolution": "node"   },   "exclude": [     "node_modules"   ] }
code:
`import Jimp from "jimp/es"
export const doSomething: Handler = (event: APIGatewayEvent, context: Context) => {
Jimp.read('https://avatars0.githubusercontent.com/u/1192452?s=88&v=4')
.then(image => {
console.log('doing something');
})
.catch(err => {
console.log('handle exception: ', err);
});
...
}
`
More details if helpful: I'm trying to import jimp in a AWS Lambda function. Lambda function runtime is set to nodejs10.x.

That debug info helps a lot. I think I have enough to debug and try to fix in the next few days, but in the meantime I'm wondering if importing frtom jimp instead of jimp/es fixes the problem for you (Again, temporarily just to ensure this initial issue is resolved)

I updated the import to
import Jimp from "jimp"
redeployed and then invoked the lambda function and am receiving the same error message I had above.

Workaround--just explicitly include regenerator-runtime.
npm install --save regenerator-runtime
const regeneratorRuntime = require("regenerator-runtime");
const Jimp = require('jimp/dist')

Now it loads properly.

@divinealpine are you able to test again but against 0.8.6-canary.815.502.0?

@crutchcorn -
I just tested using npm i --save<EMAIL_ADDRESS>on my test project here, and it seems to be working.
Only note I see is when i run the npm install above - I get warnings saying:
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
... etc etc

But it appears I can ignore these and run jimp and I don't see any errors wrt the regenerator.
So looking good from my side!
Thanks!!

Fantastic! Thanks for checking @andrewrt! I'll fix up the peer dep warnings in that PR

0.9.2 has been released and should not only fix this issue but TypeScript usage in general

:rocket: Issue was released in v0.9.3 :rocket:

:rocket: Issue was released in v0.9.3 :rocket:

For anyone finding this in future and still having the issue:
I am also still experiencing this in an electon project with Jimp 0.9.3 (but only when I package the app with electron-builder).

Things I tried from above which didn't work:
# tsconfig.json
"esModuleInterop": true,
"allowSyntheticDefaultImports": true,

# package.json
"@babel/runtime": "^7.7.2",

# index.ts
require("@babel/runtime/regenerator");
import * as Jimp from 'jimp/es';

The only thing I have found which did work:
# package.json
# swap "jimp" to:
"jimp-compact": "^0.9.3"

# index.ts
import * as Jimp from 'jimp-compact';

I know that it is a semi-unofficial fork, but however jimp-compact dependency works vs jimp seems to fix the error...


From private repo

Hi @v-aljenk, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (v-aljenk). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


Lookups are very slow

I am finding that lookups are very slow, to the extent where sometimes it times out and the puppet run fails.
This could of course be down to the web server providing the json.
It does seem make an http request every time it looks up something even if it has already looked up that file during that run.
Do you have any recommendations for working around this, e.g caching?

Based on https://github.com/puppetlabs/hiera/pull/98 and what I've heard in #puppet, I think it's up to the backend to support caching.

@erik-stephens PR #18 currently has a proposal for caching which I'll try and get merged into the codebase this week if it looks good.

Excellent!  I've been using that version for about a week now without issues.

#18 has been merged, thank you to all who contributed and commented.


Error building Windows installer when package is in a subfolder

When building the Windows installer, we're getting an error stating that the package's Cargo.toml cannot be found in the root workspace directory; however, our package is in a sub-directory.
This is related to https://github.com/axodotdev/cargo-dist/issues/1453, where I missed the case when the package gets actually built.
Proposed PR: https://github.com/axodotdev/cargo-dist/pull/1566

Should be fixed by #1566 - thanks!


[Doc] fix format configuration

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[x] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

Thanks Amber.  I fixed many of the comments and will defer the rest until we split this page up.  For now I would like to:

get it merged and verify that search works
all of us adopt the use of Markdown H (##) tags instead of tables so that people can read the text and search can index it

@Mergifyio backport branch-3.2

@Mergifyio backport branch-3.1


”Grivița”, ”Odaia Bursucani”, ”Trestiana” are listed in the drop-down menu

Description:
When user writes ”Grivița”, ”Odaia Bursucani”, ”Trestiana” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Grivița"

Expected results
The location appears in the drop-down menu as "Sat Grivița, VASLUI (Grivița)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Odaia Bursucani"

Expected results
The location appears in the drop-down menu as "Sat Odaia Bursucani, VASLUI (Grivița)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Trestiana"

Expected results
The location appears in the drop-down menu as "Sat Trestiana, VASLUI (Grivița)".


name hashing does not track names of synthetic symbols and names from synthetic methods

https://github.com/gkossakowski/sbt/issues/9

As discussed here the current strategy for extracting used names might miss synthetic names for case classes like copy, apply, unapply, etc.
This ticket is a reminder for me to investigate this issue further. Both for members of case classes and other synthetic members.

steps
// A.scala
case class A(a: Int)
// B.scala
class B { def test(a: A) = a.copy() }

// > compile

// A.scala
case class A(a: Int) { private def copy = ??? }

// > compile
// [info] Compiling 1 Scala source to /Users/jason/code/scratch1/target/scala-2.11/classes...
// [success]

// > ;clean;compile
// ...
// [info] Compiling 2 Scala sources to /Users/jason/code/scratch1/target/scala-2.11/classes...
// [error] /Users/jason/code/scratch1/src/main/scala/B.scala:2: method copy in class A cannot be accessed in A
// [error]   def test(a: A) = a.copy()
// [error]                      ^

problem
Name hashing under compiles.
expectation
Changes are detected.
notes
isSynthetic is intentionally omitted.
 private def eligibleAsUsedName(symbol: Symbol): Boolean = {
    def emptyName(name: Name): Boolean = name match {
      case nme.EMPTY | nme.EMPTY_PACKAGE_NAME | tpnme.EMPTY | tpnme.EMPTY_PACKAGE_NAME => true
      case _ => false
    }

    (symbol != NoSymbol) &&
      !symbol.isSynthetic &&
      !emptyName(symbol.name)
  }

I think this was fixed in sbt/zinc#110. Can we close?

That would seem to not do the "names of synthetic symbols" part.

Migrated to https://github.com/sbt/zinc/issues/238 by @jvican


How to make the item height adaptive?

How to make the item height adaptive? I don't need a fixed height because there seems to be too much space between items.

Check: https://pub.dev/documentation/dropdown_button2/3.0.0-beta.7/dropdown_button2/DropdownItem/intrinsicHeight.html


(PDB-1307) Update to tk-jetty 1.3.0

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/920/

@pljenkinsro retest this please

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/925/


Contract transaction: no fees in details

Contract transactions do not display fees in details. Should show.

not fixed for vault and faucet contracts
build: 6.0.1033.3676 BeamX

not fixed for vault and faucet contracts
build: 6.0.1033.3676 BeamX

checked

checked


Basic Implementation of Git Accounts

Description
A basic implementation to support git accounts on CodeEdit
Checklist

[x] I read and understood the contributing guide as well as the code of conduct
[x] My changes generate no new warnings
[x] My code builds and runs on my machine
[x] I documented my code
[x] Review requested

Screenshots

@nanashili :
Some considerations:

Can you add the ability to import/export data?

The selection field, Sort by Name is equal in length to the other fields.

You could add a + and a -, for the files.
If there is no file, display a message like in the picture.

It would be nice if it was similar to xcode.

@nanashili :
Some considerations:

Can you add the ability to import/export data?

The selection field, Sort by Name is equal in length to the other fields.

You could add a + and a -, for the files.
If there is no file, display a message like in the picture.

It would be nice if it was similar to xcode.

In future commit I will add all that right now it's pretty much still a basic thing


/Gs is not the same as /Gs0

/Gs is not the same as /Gs0; instead it seems to set the stack probe size to the default, i.e. /Gs4096.
See e.g. http://llvm.org/PR39074

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a7677050-221f-18a7-7f9f-0ce6c76fd878
Version Independent ID: efdfd190-b9e8-d951-5256-41132bf4c743
Content: -Gs (Control Stack Checking Calls)
Content Source: docs/build/reference/gs-control-stack-checking-calls.md
Product: visual-cpp
GitHub Login: @corob-msft
Microsoft Alias: corob

The fixes are published. We now specifically note that /Gs is the same as /Gs0 only for x64 targets.

Thanks for the update! Looking through the doc, it reads much clearer now.
For x64 targets, if the /Gs option is specified without a size argument, it is the same as /Gs0 [...]

For x86, ARM, and ARM64 targets, the /Gs option without a size argument is the same as /Gs4096 [...]

The /Gs without argument behaviour on x64 is surprising. Do you know why there's a difference depending on target and why this would be desired on x64?

I tried to find out, but didn't learn much, since it's a flag that's been around a lot longer than the version control systems we currently use. It may be a case of "mistakes were made" that live on because a change would break someone's code. It's hard to imagine how changing it wouldn't be an improvement in this case, though. This is one of the flags you should definitely not apply unless you know what you're doing, have profiled your code, and have set a non-default stack commit size.

Thanks for looking into it. At least it's well documented now :-)


Integrate geospatial ip2geo functionality with security plugin

Description
Adds 2 ip2geo related roles to the plugin: read only and fully access.
Adds ip2geo system index to demo scripts as well.
Issues Resolved
N/A
Testing
N/A
Check List

[ ] New functionality includes testing
[ ] New functionality has been documented
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@heemin32 Is this change targeting 2.10?

@heemin32 Is this change targeting 2.10?

Yes

@heemin32 Can you rebase this PR with main? There were some recent build fixing PRs merged.

@heemin32 Can you rebase this PR with main? There were some recent build fixing PRs merged.

There is no conflict. So, rebase is not needed.

@heemin32 Can you rebase this PR with main? There were some recent build fixing PRs merged.

Thanks! Rebased.

Can another maintainer please review this PR?


Update PyPI Packages

Update all packages in requirements.txt.

openai-whisper

from 20230124 to 20230314

pytube

from 12.1.2 to 15.0

SQLAlchemy

from 2.0.3 to 2.0.15

streamlit

from 1.18.1 to 1.22.0

They are too slow, We should update packages again :)


Graceful 404 page

Right now any 404 gives a clunky page like this

Having a standard-ish 404 page with helpful-ish text would be nice.

Per Django docs, this is just a matter of creating a 404.html in the templates folder.


Switch to Rollup

Similar to #74 - this creates a bundle that works for Node.js CJS and the browser, but it goes about it a different way. Rather than using Webpack as a bundler it switches to rollup.
I also removed the dotenv functionality in favor of requiring a key in the config - the dotenv stuff was undocumented but it probably warrants a major version bump if this PR ships. This helps reduce the size significantly for the browser.
I added an API key in the travis file so that the test suite can run - that said, it looks like API limits restrict this significantly. I thought about modifying the tests to check stubbed responses from the API but it doesn't seem like there is value there - happy to take guidance on ways to update the test suite if you want!
Only other question I have is on the batch API - it looks like this doesn't exist, was it removed? Calling that code now throws an exception on my machine.

Yeah I’ll definitely remove it and update the PR!


CON-4609: added updateOrderChange to sync OrderStatus

added function to updateOrderStatus in ProductToShop
this function is configurable in the connect-settings
also a change is triggered if the tracking code
is changed

Coverage increased (+0.2%) to 38.242% when pulling 1786b828dbf9443c6bd30f642c3cc371919933d6 on CON-4609 into df35db2e82840dd230770bbc0bf0e758f9bbd203 on master.

Coverage increased (+0.3%) to 38.25% when pulling c53c511aa4b89d9fa22d115cc339e33e5ac12c93 on CON-4609 into df35db2e82840dd230770bbc0bf0e758f9bbd203 on master.

Coverage increased (+0.2%) to 38.203% when pulling e899f85be48996011f750dc00fdd80f48c678855 on CON-4609 into df35db2e82840dd230770bbc0bf0e758f9bbd203 on master.

Coverage increased (+0.2%) to 38.203% when pulling e899f85be48996011f750dc00fdd80f48c678855 on CON-4609 into df35db2e82840dd230770bbc0bf0e758f9bbd203 on master.

Coverage increased (+0.2%) to 38.203% when pulling e899f85be48996011f750dc00fdd80f48c678855 on CON-4609 into df35db2e82840dd230770bbc0bf0e758f9bbd203 on master.

Coverage increased (+0.4%) to 38.4% when pulling 297c33f3e849310253eddbe590c11d518e8f960a on CON-4609 into df35db2e82840dd230770bbc0bf0e758f9bbd203 on master.

Coverage increased (+0.2%) to 38.454% when pulling 07910c93d8f3bcc627645adabb81703a056be875 on CON-4609 into a801e496ec5c057b1753e8cfbc55b177f68066f2 on master.


Integrate resource trail on the EA Hub

We should probably integrate the resource trail on the old EA hub as part of going live.

Yup! Can I get some input from @Richenda on how this will work?

@sebgrebe I think this is done now, right?

@sebgrebe I think this is done now, right?

I think it might be ready but that he's not making it live until the last minute. But from what I'm looking at right now, this change isn't live.

Ok, marking it as fix before launch

@michaltrzesimiech this is done, but not on the resources.eahub.org page. If I switch it on on that URL, the hub is basically open to the public as anyone going to that URL would be redirected to the hub if they click on the Home button. That is, I would only switch that URL on if we're going proper public.

I think it's time to go ahead with this :D

Resource trail is integrated, which closes this issue.
Making that integration live is issue #183

Woohoo!


Decide upon, design and develop parsing options that appear after user has entered Commons categories

After a user has entered one or more Commons categories to start an OpenRefine project with, it makes sense to present them with some custom parsing options in the 'Configure Parsing Options' dialog window.
Several that I can think of, which would make sense, from the top of my head:

Reconcile file names (+ let users specify the language against which they want to reconcile - for possible data extension they may want to do later)
Display thumbnails of files? y/n
Display column with Wikitext? y/n
Display column with categories? y/n
Display one or more columns with some SDC in it already (user specifies the properties they are interested in)

I may miss some obvious ones, and I can imagine that conversations with potential end users may give us more good ideas/suggestions.
As for building this, the existing Wikitext parsing options in OpenRefine can be used for inspiration (although that interface is not optimal).
In our March 17 team meeting we talked about this a bit. Some of this should be retrievable via API, bypassing the need for the end user to run the Commons reconciliation service, which would be a good thing!

As discussed on March 17: no need to put development time in this task yet - let's first prioritize other more crucial bits (eg file upload from disk / from URL).
IMO it's totally OK for now if we deploy a Commons Extension that bypasses this parsing dialog and presents the user with a bare project with just file names. Unless there are objections or other considerations, which I'd love to hear!

Assigning this to @lozanaross (design) and @j-sal (building this dialog; deadline May 31).

I think in order to be consistent with how other previews work (before project creation) from the above list these are my comments (maybe worth it for @wetneb to have a look at my comments below too):

Reconcile file names (+ let users specify the language against which they want to reconcile - for possible data extension they may want to do later) >> I think we agree that this should happen automatically, so there is no need to add this as an option
Display thumbnails of files? y/n >> I think we should indeed include this and allow this also across all other parsing views (also outside the SDC extension)
Display column with Wikitext? y/n >> I think this is going into data extension territory, so not sure if it is appropriate to include at this stage (handy for users, but not sure if it's not going against the general behaviour of OpenRefine)
Display column with categories? y/n >> I think this makes sense because it's like giving the source of where each file was retrieved from.
Display one or more columns with some SDC in it already (user specifies the properties they are interested in) >> I think this is going into data extension territory, so not sure if it is appropriate to include at this stage (handy for users, but not sure if it's not going against the general behaviour of OpenRefine)

In principle, I think we can base this preview on the one generated after users connect to a database for data retrieval (operation seems logically comparable to me). Adding a TO DO for myself here:

[ ] to complete the design and add a screenshot to it below.

I think in order to be consistent with how other previews work (before project creation) from the above list these are my comments (maybe worth it for @wetneb to have a look at my comments below too):

Reconcile file names (+ let users specify the language against which they want to reconcile - for possible data extension they may want to do later) >> I think we agree that this should happen automatically, so there is no need to add this as an option
Display thumbnails of files? y/n >> I think we should indeed include this and allow this also across all other parsing views (also outside the SDC extension)
Display column with Wikitext? y/n >> I think this is going into data extension territory, so not sure if it is appropriate to include at this stage (handy for users, but not sure if it's not going against the general behaviour of OpenRefine)
Display column with categories? y/n >> I think this makes sense because it's like giving the source of where each file was retrieved from.
Display one or more columns with some SDC in it already (user specifies the properties they are interested in) >> I think this is going into data extension territory, so not sure if it is appropriate to include at this stage (handy for users, but not sure if it's not going against the general behaviour of OpenRefine)

In principle, I think we can base this preview on the one generated after users connect to a database for data retrieval (operation seems logically comparable to me). Adding a TO DO for myself here:

[ ] to complete the design and add a screenshot to it below.

I've added my suggested design options here: https://xd.adobe.com/view/fdf5a12c-9c30-4449-9eba-d1ea8523dddb-a8a6/ (p. 29)
Happy to discuss changes needed:

I've added my suggested design options here: https://xd.adobe.com/view/fdf5a12c-9c30-4449-9eba-d1ea8523dddb-a8a6/ (p. 29)
Happy to discuss changes needed:

Amazing. Thanks!!
I'll provide more detailed feedback in the Adobe document you provided, but for visibility here:

Display file thumbnails rather than image thumbnails (it's possible that the user will load videos, audio files, etc)
Include a column with categories: for this option we should explicitly look at what will happen when the user ticks this checkbox. Maybe it's also best to rename this option to 'Include a column with Commons categories' - just for clarity.

In most cases, files have multiple Commons categories. If the user checks the 'Include a column with categories', for me the most obvious outcome would be:

The OpenRefine project will then load in record mode (i.e. having multiple lines for each filename)
In which each category is in a different cell in a 'Commons category' column
And a category is displayed with the category name only, without square brackets or the Category: prefix

For outcome 2, the alternative would be just one cell with a concatenation of categories - not a terrible option, but the record mode approach sounds friendlier to me?
For outcome 3, it could also equally be outputted as [[Category:Historical photos of cats dressed as humans]] or Category:Historical photos of cats dressed as humans - no strong preference here.
Mainly, I think we want to be consistent, also with how the various GREL parsing operations for Wikitext will work, see also #4823.
@j-sal @wetneb any thoughts?

I'll provide more detailed feedback in the Adobe document you provided, but for visibility here:

Super thanks!

Display file thumbnails rather than image thumbnails (it's possible that the user will load videos, audio files, etc)
Yes, totally.
Include a column with categories: for this option we should explicitly look at what will happen when the user ticks this checkbox. Maybe it's also best to rename this option to 'Include a column with Commons categories' - just for clarity.
I don't know if we need Commons, because the checkbox comes underneath the column title "Wikimedia Commons specific options". Although the column titles right now are very far from the checkbox options, so that can be improved, I didn't change yet mostly because if we change here it will have implications to other places in the "Configure parsing options" view, so probably can be changed as part of the overall "audit" of the design system I hope to progress with in the coming months.

Record mode makes sense I think, users can then always readjust as needed.

It all looks great to me @lozanaross!

Display one or more columns with some SDC in it already (user specifies the properties they are interested in) >> I think this is going into data extension territory, so not sure if it is appropriate to include at this stage (handy for users, but not sure if it's not going against the general behaviour of OpenRefine)

yes I would rather avoid this - we sort of do this in the wikitable importer and it is not a great user experience because of the additional delay in fetching the data


Include throwable message in BeanInstanceCreationException

Include throwable message from cause in BeanInstanceCreationException.
The use case for this is to prevent loss of information when System.err is not available, for example for crash logging libraries like Crashlytics.
Somewhat related to #74

Hello,
can you rebase your 3 commits into just 1?
Thanks.

@caleb-allen Your PR need some rework.
Thanks

Well, I've patched the 1.0.0 with your idea.
https://github.com/Ekito/koin/commit/b4975dfe6c76dcb6cf6df592ac18b4723518df38
Thanks.


Update collection-index.yml

This adds support for the rust on nails devcontainer
The devcontainer source is here https://github.com/purton-tech/rust-on-nails
This container adds all the tools needed for full stack web development in Rust based on the tutorial/documentation here https://rust-on-nails.com/
Thanks

@samruddhikhandale Hi. Thanks for your time on this.
I've made the package public.


Upgrade failure

[xorm] [warn]  2023/08/09 01:38:51.317137 Table adapter column port db type is VARCHAR(20), struct type is INT
[xorm] [warn]  2023/08/09 01:38:51.327909 Table provider has column custom_scope but struct has not related field
[xorm] [warn]  2023/08/09 01:38:51.378737 Table payment has column organization but struct has not related field
panic: arg port as int: strconv.ParseInt: parsing "": invalid syntax

goroutine 1 [running]:
github.com/casdoor/casdoor/authz.InitApi()
	/go/src/casdoor/authz/authz.go:38 +0x153
main.main()
	/go/src/casdoor/main.go:51 +0xaa

Upgrading from image version image: casbin/casdoor:v1.379.0 to image: casbin/casdoor:v1.384.0 caused the above errors and startup failure.

@aosolao delete DB's adapter table, restart Casdoor

[xorm] [warn]  2023/08/09 02:39:17.697530 Table provider has column custom_scope but struct has not related field
[xorm] [warn]  2023/08/09 02:39:17.755109 Table payment has column organization but struct has not related field
panic: adapter not found

goroutine 1 [running]:
github.com/casdoor/casdoor/authz.InitApi()
	/go/src/casdoor/authz/authz.go:38 +0x153
main.main()
	/go/src/casdoor/main.go:51 +0xaa

@hsluoyz
Even after removing the adapter, I'm still seeing the above errors upon startup.

@aosolao pull this commit: https://github.com/casdoor/casdoor/commit/6746551447d7df9f286025296ec4d7ccad357205
Then fix your setting with the new improved error message


Seed functionality

I find that giving the user an optional seed value input could greatly increase the amount of fun users could have with the randomizer. It could be added as a separate value to the Preset, that is used as the input for the RNG for the Randomizer. This would prevent people from sharing ROMs illegally.
I may do a PR at some point with this change, since it's simple enough

There you go!

That was fast! Good work!
I had debated the idea of putting the seed value in the preset JSON file itself as a nullable field.
The reasoning behind the seed is so one can share an exact same game without having to share a ROM, which would present a legal issue.  But one could argue it negates the idea of a RANDOMIZATION preset.
This would require making the seed a nullable int within the Preset class, and when saving the preset, have an option to opt-in or opt-out of saving the randomly-generated seed. Likewise when loading in the preset, if the seed was null or the field was not present, it would just put in a random seed for when you randomize.
Although it would be a lot of hassle just for making a seed save inside the file when needed. One could just share the seed as well as the randomization file of need be. Making that change is up to you of course.
Thanks for the quick work by the way!

That should do it, then.

Perfect! Thanks for doing that. Have a good one!


tppos to a different dimension causes a casting error to Sponge's World

https://gyazo.com/1d052726d932698de2afb8af18893ff8
gabizou on the subject:
gabizou - Today at 2:29 PM
nah, more than likely he needs to recompile/re-update against the api

K


Crash on add to cart

Lunar version: 1.0.0-beta.5
Laravel Version: 11.31.0
PHP Version: 8.2.25
Database Driver & Version: 10.6.20-MariaDB

Expected Behaviour:
Product should be added to the cart
Actual Behaviour:
Crash with ErrorException Attempt to read property "id" on null
Steps To Reproduce:
Product created with 1 variant, 1 product option (Size) and one option (Small),
Add to Card on Product page

Once this crash happens, the app goes to unstable state, and now even the home page is not loading and crashes

Underlying reason for this crash is that, Tax Zone is not set in the admin.
So the checkout does not work without setting tax zone while it is an optional configuration

Also getting this error and it was fixed by adding a tax zone.

Yes, adding tax zone fixes it but then it should be a mandatory configuration


RPM for OpenSUSE Linux

OS: OpenSUSE tumbleweed
Version of IPFS Desktop UI v2.11.4 Revision 69cd414

Describe the bug
A clear and concise description of what the bug is.
The rpm package provided will not install on opensuse because of how the dependecy is named
libuuid on opensuse is libuuid1
nss on opensuse is mozilla-nss
To Reproduce
Steps to reproduce the behavior:

rpm -i {packagename}.rpm

     libuuid is needed by ipfs-desktop-0.14.0-1.x86_64
     nss is needed by ipfs-desktop-0.14.0-1.x86_64

Expected behavior
ipfs desktop should be installed as expected as libuuid1 and mozilla-nss is installed, but due to dependecy naming it wont install,
Additional context
I managed to get it working by rpmrebuild -enp ipfs-desktop-0.14.0-linux-x86_64.rpm and renaming the dependency.
suggestion: provide a seperate rpm package for opensuse with the modified  dependency names.
pic related is how the pacakge should look for opensuse linux.

also here is the rpm package i build after modifying the dependency names
https://ipfs.io/ipfs/QmZgyDf2iyrTfcs2LWeJi8Z9Mz35GHgkPNZraAWzxMy63A

@0kalekale is the issue still present in v0.15.0?
We have limited bandwidth and are unable to QA and produce packages for every distribution.

If you want to maintain a package for your distro, we provide .tar.xz variant that can be used in your build pipeline.
We could add it next to AUR at https://github.com/ipfs/ipfs-desktop#install


reformatting xcodeformatter output.

What is the cleanest way you suggest to reformat the xcodeformatter output to something like this:
I 09:07:39.015 -KeychainService.savedModelForKey:369 | Successfully retrieved a model from keychain
where the first column is I/E/U/W/D, the date is in 24h local time, ...
The sample I had posted earlier no longer works due to all the 2.0 changes.
Navi

The simplest thing would be to use the FieldBasedLogFormatter to construct your own custom LogFormatter:
let formatter = FieldBasedLogFormatter(fields: [
    .Severity(.Custom(textRepresentation: .Uppercase, truncateAtWidth: 1, padToWidth: 0, rightAlign: false)),
    .Literal(" "),
    .Timestamp(.Custom("hh:mm:ss.SSS")),
    .Literal(" "),
    .CallSite,
    .Literal(" "),
    .StackFrame,
    .Delimiter(.SpacedPipe),
    .Payload
])

The code above would get you close to the output you desire, eg.:
D 12:51:53.482 CommonAppDelegate.m:677 -[CommonAppDelegate networkActivityFinished:] | Network activity finished - initiating database cleanup.

However, the .CallSite and .StackFrame fields don't give you the exact output of your old stringRepresentationForCallingFile() function.
If you absolutely must have that exact format, the next-simplest way to do that is to create a LogFormatter that will format just that portion of a log entry. For example:
public struct CustomCallerLogFormatter: LogFormatter
{
    public init() {}

    public func formatLogEntry(entry: LogEntry)
        -> String?
    {
        let filename = NSURL(fileURLWithPath: entry.callingFilePath).URLByDeletingPathExtension?.lastPathComponent ?? "(unknown)"

        return "\(filename).\(entry.callingStackFrame):\(entry.callingFileLine)"
    }
}

Then, for the remaining output, you can use some of the built-in LogFormatter implementations and then combine everything using a ConcatenatingLogFormatter:
let formatter = ConcatenatingLogFormatter(formatters: [
    SeverityLogFormatter(style: .Custom(textRepresentation: .Uppercase, truncateAtWidth: 1, padToWidth: 0, rightAlign: false)),
    LiteralLogFormatter(" "),
    TimestampLogFormatter(style: .Custom("hh:mm:ss.SSS")),
    LiteralLogFormatter(" "),
    CustomCallerLogFormatter(),
    DelimiterLogFormatter(style: .SpacedPipe),
    PayloadLogFormatter()
])

Hope this helps,
E.

Navi,
I just wanted to update you on some recent API changes that make it a little easier to use a custom LogFormatter. You can now use the FieldBasedLogFormatter directly in conjunction with the CustomCallerLogFormatter shown in the example above. This means you can avoid using the slightly-more-complex ConcatenatingLogFormatter.
For example:
let formatter = FieldBasedLogFormatter(fields: [
    .Severity(.Custom(textRepresentation: .Uppercase, truncateAtWidth: 1, padToWidth: 0, rightAlign: false)),
    .Delimiter(.Space),
    .Timestamp(.Custom("hh:mm:ss.SSS")),
    .Delimiter(.Space),
    .Custom(CustomCallerLogFormatter()),
    .Delimiter(.SpacedPipe),
    .Payload
])

You'll notice that there's a new .Space delimiter now, so you can use more type-safe delimiters, in this case .Delimiter(.Space) instead of .Literal(" ").

Closing ticket now that question is answered.


Make remote directories before put_files

(async implementations, see https://github.com/dask/s3fs/issues/491 )

This change broke adlfs, since AzureBlobFileSystem doesn't implement _makedirs.


PANIC: Unable to connection to database: pq: password authentication failed

Set the password properly (using the PG_PASS environment variable), it keeps giving me this error message.

thanks for report @hdiwan

Do you want to send a PR ? @hdiwan

I already sent a pull request for an edit in the README.md, once I figure out this problem, I'll be happy to send another

Nice, let us know if you need any help

@crgimenes  @cassiobotaro  this issue is fixed? with pool implementation?

fix in PR #56