CustomPaint: Shader with SweepGradient crashes on WEB, but runs OK on device and desktop

Steps to Reproduce

Copy the example code from this gist:
https://gist.github.com/rydmike/dc8a915f169455463e4e2016619e00bb

Build it for WEB. When the "Crash me on WEB" switch is turned on, the application will crash if it is running on Web, but it will run OK and produce the expected result on a device or desktop.

You can try it it DartPad here;
https://dartpad.dartlang.org/dc8a915f169455463e4e2016619e00bb

But not see the crash reason. The crash occurs but when using Flutter WEB DomCanvas and CanvasKit.
TLDR
The second method shown in the example of producing the color circle is also in use by a some packages on pub.dev. As shown further below the merits of using this method can be argued against. Regardless of that, Flutter code that uses rather basic API calls, runs and produces expected output on devices and desktops, should probably not crash on Web.
The line that causes the crash on Web is isolated and highlighted below:

Logs and version
Error log from web crash below
[   +1 ms] The following JSNoSuchMethodError was thrown during paint():
[  +69 ms] NoSuchMethodError: invalid member on null: '_get'
[  +46 ms] The relevant error-causing widget was:
[   +2 ms]   CustomPaint file:///C:/Users/mryds/OneDrive/code/flutter/_mr/scroll_pan/lib/main.dart:73:24
[  +77 ms] When the exception was thrown, this was the stack:
[   +1 ms] C:/b/s/w/ir/cache/builder/src/out/host_debug/flutter_web_sdk/lib/_engine/engine.dart 239:26         toMatrix32
[   +1 ms] C:/b/s/w/ir/cache/builder/src/out/host_debug/flutter_web_sdk/lib/ui/src/ui/painting.dart 1186:71    sweep
[        ] packages/flutter/src/painting/gradient.dart 920:24                                                  createShader
[        ] packages/scroll_pan/main.dart 180:29                                                                paint
[        ] packages/flutter/src/rendering/custom_paint.dart 531:12                                             [_paintWithPainter]
[  +36 ms] packages/flutter/src/rendering/custom_paint.dart 572:7                                              paint
[  +38 ms] packages/flutter/src/rendering/object.dart 2264:7                                                   [_paintWithContext]
[   +3 ms] packages/flutter/src/rendering/object.dart 184:12                                                   paintChild
[   +1 ms] packages/flutter/src/rendering/proxy_box.dart 131:14                                                paint
[   +1 ms] packages/flutter/src/rendering/object.dart 2264:7                                                   [_paintWithContext]
[   +1 ms] packages/flutter/src/rendering/object.dart 184:12                                                   paintChild
[        ] packages/flutter/src/rendering/shifted_box.dart 70:14                                               paint
[   +1 ms] packages/flutter/src/rendering/object.dart 2264:7                                                   [_paintWithContext]
[ +101 ms] packages/flutter/src/rendering/object.dart 184:12                                                   paintChild
[   +4 ms] packages/flutter/src/rendering/box.dart 2515:14                                                     defaultPaint
[   +1 ms] packages/flutter/src/rendering/flex.dart 950:7                                                      paint
[   +1 ms] packages/flutter/src/rendering/object.dart 2264:7                                                   [_paintWithContext]
[   +1 ms] packages/flutter/src/rendering/object.dart 184:12                                                   paintChild
[        ] packages/flutter/src/widgets/single_child_scroll_view.dart 548:16                                   paintContents
[        ] packages/flutter/src/rendering/object.dart 391:12                                                   pushLayer
[        ] packages/flutter/src/rendering/object.dart 447:7                                                    pushClipRect
[        ] packages/flutter/src/widgets/single_child_scroll_view.dart 552:16                                   paint
[        ] packages/flutter/src/rendering/object.dart 2264:7                                                   [_paintWithContext]
[        ] packages/flutter/src/rendering/object.dart 135:10                                                   _repaintCompositedChild
[   +1 ms] packages/flutter/src/rendering/object.dart 95:5                                                     repaintCompositedChild
[  +71 ms] packages/flutter/src/rendering/object.dart 980:29                                                   flushPaint
[   +2 ms] packages/flutter/src/rendering/binding.dart 404:19                                                  drawFrame
[   +1 ms] packages/flutter/src/widgets/binding.dart 865:13                                                    drawFrame
[   +1 ms] packages/flutter/src/rendering/binding.dart 284:5                                                   [_handlePersistentFrameCallback]
[   +1 ms] packages/flutter/src/scheduler/binding.dart 1113:15                                                 [_invokeFrameCallback]
[   +1 ms] packages/flutter/src/scheduler/binding.dart 1052:9                                                  handleDrawFrame
[        ] packages/flutter/src/scheduler/binding.dart 968:5                                                   [_handleDrawFrame]
[        ] C:/b/s/w/ir/cache/builder/src/out/host_debug/flutter_web_sdk/lib/_engine/engine/window.dart 715:13  _invoke
[        ] C:/b/s/w/ir/cache/builder/src/out/host_debug/flutter_web_sdk/lib/_engine/engine/window.dart 338:5   invokeOnDrawFrame
[        ] C:/b/s/w/ir/cache/builder/src/out/host_debug/flutter_web_sdk/lib/_engine/engine.dart 211:18         <fn>
[  +72 ms] The following RenderObject was being processed when the exception was fired: RenderCustomPaint#891a8:
[   +3 ms]   creator: CustomPaint ← SizedBox ← Center ← Column ← _SingleChildViewport ←
[   +2 ms]     IgnorePointer-[GlobalKey#eb731] ← Semantics ← _PointerListener ← Listener ← _GestureSemantics ←
[   +1 ms]     RawGestureDetector-[LabeledGlobalKey<RawGestureDetectorState>#84767] ← _PointerListener ← ⋯
[        ]   parentData: <none> (can use size)
[        ]   constraints: BoxConstraints(w=170.0, h=170.0)
[        ]   size: Size(170.0, 170.0)
[        ] This RenderObject has no descendants.
[        ] ════════════════════════════════════════════════════════════════════════════════════════════════════
[   +1 ms] Another exception was thrown: Assertion failed: org-dartlang-sdk:///flutter_web_sdk/lib/_engine/engine/bitmap_canvas.dart:788:12
[  +54 ms] Another exception was thrown: NoSuchMethodError: invalid member on null: '_get'
[   +2 ms] Another exception was thrown: PersistedPhysicalShape: is in an unexpected state.
[+1672 ms] Another exception was thrown: PersistedScene: is in an unexpected state.
[  +11 ms] Another exception was thrown: PersistedScene: is in an unexpected state.
[  +23 ms] Another exception was thrown: PersistedScene: is in an unexpected state.
[  +71 ms] Another exception was thrown: PersistedScene: is in an unexpected state.

Used version
The above report was made on latest master channel shown below. However, as the DartPad example shows, it also crashes on the version it is running on.
flutter doctor -v
[√] Flutter (Channel master, 1.19.0-2.0.pre.133, on Microsoft Windows [Version 10.0.18363.778], locale en-US)
    • Flutter version 1.19.0-2.0.pre.133 at c:\src\flutter
    • Framework revision e92afc16b6 (24 hours ago), 2020-05-21 05:29:01 +0900
    • Engine revision 2d4e83921d
    • Dart version 2.9.0 (build 2.9.0-9.0.dev 40f7a11d89)

[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at C:\Users\mryds\AppData\Local\Android\sdk
    • Platform android-28, build-tools 28.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.5.4)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.5.30011.22

[√] Android Studio (version 3.6)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.8052
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)

[√] IntelliJ IDEA Community Edition (version 2019.2)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2018.3.1
    • Flutter plugin version 35.3.3
    • Dart plugin version 192.7402

[√] VS Code (version 1.45.1)
    • VS Code at C:\Users\mryds\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.10.2

[√] Connected device (4 available)
    • Nexus 7    • 0a99f5e8   • android-arm    • Android 6.0.1 (API 23)
    • Windows    • Windows    • windows-x64    • Microsoft Windows [Version 10.0.18363.778]
    • Web Server • web-server • web-javascript • Flutter Tools
    • Chrome     • chrome     • web-javascript • Google Chrome 81.0.4044.138

• No issues found!

More info
The Gist example also show an alternative and better way of producing the sought output that does not crash on Web.
The first color circle in the example does not crash on Web:

But the second one will crash on Web when the switch "Crash me on Web" is turned on. When running on desktop or a device, it will look very similar to the first one:

It is however not exactly the same, the second version version using the gradient and shader that crashes on Web, is actually not an entirely correct representation of the color circle. This becomes obvious when the width is of the circle is increased.

I have noticed that this SweepGradient + Shader way of producing the color circle can be found in a few packages on pub.dev. While the merits of using this method for wider color circles can be argued, the same code that runs fine without any issues on a device and desktop, using very basic Flutter APIs should probably not crash on Flutter WEB.

This is a duplicate of https://github.com/flutter/flutter/issues/41389

OK thanks @yjbanov for letting me know and finding the duplicate. I will be tracking its progress instead. Sorry that I did not find it myself before making this report, due to the amount of issues and not being familiar with the back-log, it can sometimes be difficult to locate an already existing issue when reporting a new one. Glad that you caught it.
Also for my particular use case, I found another way of doing what I needed that works on Web. I have however seen that some packages on pub.dev have used to approach shown here. I'll let the packages authors know about this issue as well.

@rydmike Don't let it stop you from filing issues! It's better to have a duplicate than not having an issue filed at all :)

No worries @yjbanov I will :grinning:
This particular example case actually crashes on both DomCanvas and CanvasKit (SKIA).
I just learned that in some cases some CustomPaint APIs work in CavnasKit but not on DomCanvas.
It is honestly a bit confusing as to what works where, would be great if there was a status list of what is implemented and supported on each render engine. Is there?
The example in this issue report actually also contain a solution (alternative implementation) for the particular color picker use case. I will therefore refer others that have published packages on pub.dev that use the approach that does not work, to this case as a solution example, if they want to make a version that also works on Flutter web, both DomCanvas and CanvasKit.

Just in case some of the people that I am directing to this issue for how to make color wheel that works in Flutter, I just want to add that I just updated the GIST code for the example that works.
The new updated version is much cleaner and simpler. The previous version used HSV/HSL color handling code that was borrowed/extracted from dart package TinyColor. Using TinyColor is however not needed for this use case, as the needed HSV/HSL color handling classes already exist in the Flutter SDK, the updated example takes advantage of that and is much simpler and shorter.

I will add references to existing Flutter Color pickers that I have come across, that at time of being added to this list, suffers from the issue described here, when used on Web. The packages' issue can be solved by changed the implementation to the workaround shown in this issue in the DratPad example:

Package: https://pub.dev/packages/flutter_circle_color_picker
Has open issue on the topic: https://github.com/itome/flutter_circle_color_picker/issues/8

...more later


[request] swipe up/down support ↕

First of all, what a great repo❗ :shipit:

My compose-foo is weak:

I'm trying to copy the Gmail Android app account-switch on avatar-swipe-down animation (and subsequent view recycle).
IMHO it's one of the best UX elements on mobile - usable, fast, and beautiful!.
Instagram just implemented something similar, but it's a avatar coin flip on tap  profile pic to what looks like a memoji.
I've searched far and wide on GitHub and this repo is the closest I've come to finding the promised land. I'm 📏🤏close to reverse engineering the Gmail APK.
Any chance we can get up down swipe support on FABs?
Cc @saket @c5inco
Best,
Ryan 🌵

Hey @maceip, swipe was designed for a very specific use-case -- horizontal swipe actions on list items. It can't handle arbitrary gestures for you.
Have you tried using Modifier.swipeable?.


my trainning data is thchs30, however it met some questions, and I  modify something, could I test the model in the end?Now,it starts training...

1.trainning data is thchs30,  and modify "./preprocess.py" line 49:
return [os.path.join('/home/cext/xiaoyi', 'data_thchs30')]

I have a question when python preprocess.py, should I have change the language? The default language is en_US, I did nothing in the language.
2.trainning data is thchs30, and update "./datasets/preprocessor.py"
in 33 lines:
trn_files = glob.glob(os.path.join(input_dir, 'xmly_record', 'A*', '*.trn'))

then, print(trn_files), however, it's empty list, so I made this update:
# trn_files = glob.glob(os.path.join(input_dir, 'xmly_record', 'A*', '*.trn'))
# ===update 20181018====
trn_files = glob.glob(os.path.join(input_dir, 'train', 'A*.trn'))

the last question, after training finished, could I test the model in Chinese? Oh, anyway, that is a good project.

Hello, @Michael1S

I have a question when python preprocess.py, should I have change the language? The default language is en_US, I did nothing in the language.

Have you read main README file? How many times? https://github.com/Rayhane-mamah/Tacotron-2/blob/master/README.md

Step (0): Get your dataset, here I have set the examples of Ljspeech, en_US and en_UK (from M-AILABS).

Note:
Our preprocessing only supports Ljspeech and Ljspeech-like datasets (M-AILABS speech data)! If running on datasets stored differently, you will probably need to make your own preprocessing script.

When I was preprocessing my non-English data, I just looked at the code, found place where the data is preprocessed, found where all these parameters like language are used, and made my own modifications. Your question doesn't seem to be related to this project, it's like python-related question.

the last question, after training finished, could I test the model in Chinese? Oh, anyway, that is a good project.

"Synthesis" paragraph in README

PS I'm not maintainer of this project, I'm just a user

hahahhh, lao ge 666
U a right. I am ok with u.

Have u read this file ?
preprocess.py
for 39 lines and 47 lines, this project had contained how to prepross the dataset-Thchs30.
# 39 line
supported_datasets = ['LJSpeech-1.0', 'LJSpeech-1.1', 'M-AILABS', 'THCHS-30']
# 47 line
if args.dataset.startswith('THCHS-30'):
    return [os.path.join(args.base_dir, 'data_thchs30')]

My question is not preprocess.py, is when running "python preprocess.py", the file "./dataset/preprocessing.py" returns a empty list. So I modified something in  the file "./dataset/preprocessing.py". I am not sure wether it is right or the model could be test in Chinese.The author had not reminded of this change, I tried it myself.

Have u read this file ?
preprocess.py
for 39 lines and 47 lines, this project had contained how to prepross the dataset-Thchs30.

No, I haven't. You gave a link to somebody's fork of this repo. You can ask him if you have any questions about his modifications containing in his mandarin-new branch of his fork.


Include statement

So the code aspects are completed up to per-file symbol resolution. I think there is a small step to gather information for project symbol usage for the sake of the IDE, and a big step to revise the static typing pass. The IDE changes are mostly independent of the code changes at this point.

[x] Revise IDE handling of files

[x] Handle main file consistently with imported files
[x] Revise scanning for changes to support the whole project
[x] Implement the project browser
[x] Find common ancestor directory
[x] Display information about the currently viewed file correctly
[x] Cache the currently viewed file and the program entry point
[x] Decide when to set IDE back/forward jump points

[ ] IDE features work across files

[ ] Decide data structure for finding symbols used in other files
[ ] Find usages
[ ] Go to def
[ ] Rename
[ ] error/search clickable links
[ ] search/replace for multiple files

[ ] Rewrite static pass to take disparate files (with parse trees and symbol tables) and produce a single AST
[ ] Make sure IDE information is preserved (mainly hover for type / value)

So there's a lot there, but this process has stumbled onto an elegant design, and the steps are relatively self contained.

From last time, the IDE problems for multifile support can be solved relatively independently of the code by using simple include statements. That includes:

Making the symbol table searchable despite being built from multiple files
Implementing the file browser
Some kind of scheme for setting the program entry point file (while still going off to edit other files)
Context click options to follow file paths in the editor
Decisions for if a file can be included multiple times, how the syntax highlighting if so
Caching loaded files and minimising I/O

Include statements are a hack. A useful hack, like macros‡, but a hack. It would behoove you to focus on modules first.
You need to declare anything you do with modules†, so cyclical references aren't a difficult issue. As I think about it, Forscape's current decision to do classic simultaneous declaration and reference resolution is not a problem for modules. It might be worth revisiting in its own right to allow codependency without prototypes, but that's not necessary for modules since you already need to declare which modules you are using.
Modules being decoupled as described above, the current file handling in the scanner is a bit daft. You really can parse the files one at a time, which makes figuring out the multi-file symbol table data structure much easier. Perhaps each document could have it's own symbol table data structure. If each file has it's own parse tree and symbol table, then I think you're finally starting to see the path towards partial compilation.
†The only caveat is that you can't do a "from MyModule import *" without a two-pass symbol resolution, but that capability isn't central to modules. In fact, you would need to be utterly convinced that "import *" capability is extremely valuable to the user before breaking the modularity of modules... and I don't think that will happen.
‡In C/C++ inclusions are quite similar to macros in that they substitute code, only from a text file instead of directly inline. You could even have "arguments" to an include statement using macro definitions. The preprocessor is a great and terrible thing...

So how does the typing work? In the decoupled modules, you could pass symbol resolution with
moduleA{ var = moduleB.var }
moduleB{ var = moduleA.var }

Especially since you want to allow generic functions without type annotations, the scope of a typing pass is the whole program, probably starting at the program entry point. Probably this would be a good time to rework the static pass.

There are currently 4 ways to reference symbols across files:

import module then module.var
import module as m then m.var
from module import var then directly reference var
from module import var as v then reference v

Classes will add more ways, with the caveat that you can use the . operator on an object to do an access at a known offset of the object.
So you can think about the data structure to store and update inter-file symbol references to be used in IDE interaction, but populating that information will fundmentally rely on the static pass. It is not a small operation before the static pass as I previously thought.

So there's a good, modular design, and the frontend work is DONE. Now the only small task left is a total rewrite of the backend. I should probably merge the frontend work before yeeting the backend...


Dedicated view container & Gradle daemons

Refs https://github.com/badsyntax/vscode-gradle/issues/435
Refs https://github.com/badsyntax/vscode-gradle/issues/429
Overview:

Use new view container
Move gradle tasks into view conainer
Split classes into individual files
Render gradle daemons in view container
List gradle daemons
Stop all daemons
Stop individual daemons
Always show the gradle tasks view, with loading state (now that it's in a dedicate view, it doesn't make sense to hide it when the tasks are initially loading)

Screenshots:

TODO:

add windows support for executing gradle wrapper
manually test in windows
add java unit tests
add vscode integration tests


search history will preview current and future conditions

WHEN I click on a city in the search history
THEN I am again presented with current and future conditions for that city

commuted with #1


Fix "undefined" in charts

In the Geo-schelling and urban growth models, I noticed that the charts said "undefined". I don't have time to look into this at the moment, so I'm dropping here just in case someone dose.

To recreate -- launch either model in the browser. I assume it is the same issue.
mesa versions that the requirements file in urban growth model was tied to -- mesa-1.1.1 mesa-geo-0.5.0

Thanks for reporting. This has been raised in https://github.com/projectmesa/mesa-viz-tornado/issues/26 and https://github.com/projectmesa/mesa-examples/issues/64 and is supposed to be fixed by https://github.com/projectmesa/mesa-viz-tornado/pull/37. But I haven't tested it yet.

Tested and verified that it's indeed fixed, although the fix is not yet released to PyPI (as mentioned in https://github.com/projectmesa/mesa-viz-tornado/pull/37#issuecomment-1764013166). I'll leave this issue open until then.

Fixed with mesa-viz-tornado v0.1.3 release.


.bowerrc cwd containing ~ creates ~ directory

According to the Bower Configuration section for cwd, one should be able to include something like "cwd": "~/my-project".
However, I have put my .bowerrc in my project root, then added "cwd": "~/repos/js/project-name/assets/".
I do not think the directory configuration is relevant, but in case it is, I have not set it, expecting a default bower_components/ directory to be placed in ~/repos/js/project-name/assets/.
Next, I run bower install --save-dev normalize.css. My file browser then shows that ~/ has been added to the project root.
Unexpectedly, ~/ contains repos/js/project-name/assets/bower_components/normalize.css/.
I assume this is unexpected behavior, because of the example in the documentation mentioned above, but please correct me if I am using the configuration incorrectly.
Although the steps above result in unexpected behavior, using an absolute path for the cwd configuration results in expected behavior.
Other facts about my environment:

I am using Zsh 5.0.2.
I am using Ubuntu 14.04 LTS
I am using Bower 1.4.1

This issue is also very closely related to this one... https://github.com/bower/bower/issues/1784

For better or worse bower now supports ~ expansion anywhere in config.


Cell Stats not working for a new foundation

Hi ECS team,
We are not getting Cell Stats or Capacity Plan info for a newly installed foundation.
The ERT version is 1.7.35.
Attached the screenshot.

Thanks,
Chandan

Can you open the log window (CTRL-D after cf top startup) and send a screenshot of the screen?   Also, you you try using the nozzle plugin and see if you are getting container metrics?   (e.g.,  cf nozzle -filter ContainerMetric)

I did cf nozzle and hit enter to collect all the log types. I got only ValueMetric and CounterEvent.

What user are you running the cf top with?
Does the user have admin privileges?

I am running as admin user for CF foundation. We have 8 foundations with ERT-1.7.35. This plugin works fine with foundations having more than 5 Diego cells but in this case which is a new foundation, it fails to pull Cell Stats.
Thanks,
Chandan

So something is odd -- cf nozzle should return container metrics every 30 seconds --- assuming you have running applications.   I can see you have 14 apps deployed but are they "started" AND running?  Or are they crashing / failed?

Can you review the privileges assigned to the firehose nozzle user?
    $> uaac token client get admin -s [admin client secret]
    $> uaac user get [firehose nozzle user] | grep -i display

Closing issue as there was no response from reporter.


Create biblionest.is-local.org.json

Requirements

[x] You have completed your website.
[x] The website is reachable.
[x] The CNAME record doesn't contain https:// or /.
[x] There is sufficient information at the owner field.

Description
For my web-hosted software, while in development
Link to Website
https://biblionest.pages.dev

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

I have read the CLA Document and I hereby sign the CLA

recheck


Deprecate MiAIRR field name

We have maintained a split between MiAIRR field names (which are human readable) and DataRep/Schema fields (which serve as unique and unambiguous keys) for the last two years. Given the recent decisions on Set 6/Rearrangement and the fact that everything is now represented in a single schema, this split appears unnecessary and potentially confusing. In addition, the x-airr:name property, which currently encodes the MiAIRR name, is used as short description for non-MiAIRR fields (e.g., study_description), which is illogical. As @schristley commented in #369, this information should be in a property called title, the introduction of which would howver duplicate the information for MiAIRR fields. We should simply this.
Proposed changes:

Move all x-airr:name properties to title
Officially deprecate the MiAIRR field names. There are only Schema fields, which have a human-readable title. For MiAIRR fields, this title will initially be what is now the MiAIRR field name.

I think this should best go into v2.0, but open for discussion if there is a reason to push for v1.3.

@bussec if it's okay, I'm thinking of adding title for v1.3 while the deprecation of MiAIRR name can be for V2? I actually have a need for the title now.

Only problem with doing one without the other is that if I think we want to avoid having this in two places... So we should agree that we will be deprecating the name field and replacing it with title even if we don't actually do the deprecation until the v2.0 release.

we should agree that we will be deprecating the name field

Well I agree. Based upon @bussec filing this ticket, I assume he agrees. Who else needs to agree? If @bcorrie agrees then we have a trifecta ;-D

Indeed... and I do agree... question is does anyone else have any thought/opinions other than the three of us 8-) Anybody??? going once, going twice, sold...

I have created a new branch (title-spec), we want this for v1.3 correct?

@bcorrie yes, please, title is on the same level as description.

We discussed at CRWG and decided to add the 'title' field now, leave name, and formally deprecate name in the v2.0 release. @bussec @schristley did I get that correct???

@bcorrie: Yes, or at least this was also how I understood it.

self-reminder: update conf.py once name is deprecated.


fix: don't panic when linting in empty environments

The "unreachable tactic" linter would previously assume that various parser categories were in the environment, and panic if they weren't. This caused problems when elaborating declarations in a fresh, empty environment.

Where "this" means "the fact that the linters are running" rather than "find! was used", right?

Yes!

I'm not opposed to fixing this particular issue.  I suspect we'll run into more issues when running linters (or other meta-programming) in restricted environments that don't have the same environment as the main environment.
It'd be good to have better regression testing.

I'll see if I can cook up a little test for it.

2288140 adds a regression test. I've manually verified that it would have caught the bug that's fixed in this PR, but I do suspect that there are many other bugs it wouldn't have caught.

One side effect of the way that I implemented the regression test is that panics during elaboration of any of the tests will now cause them to fail, rather than just write to stderr. I think this is a good thing, but I thought I should point it out. No tests currently panic, so it doesn't have an effect on existing tests.

The changes looked good to me.  If we ever want to test  intentional panics, then we may need to support unsetting LEAN_ABORT_ON_PANIC.  However, that can be done if/when needed.

Thanks!
We can definitely cross that bridge when we get to it, I think it'd be a pretty small change to the Makefile.


[BUG]: onConflictDoUpdate error in casing

What version of drizzle-orm are you using?
0.26.3
What version of drizzle-kit are you using?
0.18.1
Describe the Bug
Hey all!
I've found a funny problem while using drizzle + postgres (Vercel postgres).
Having this schema:
export const Processings = pgTable('processings', {
    id: serial('id').primaryKey(),
    name: text('name').notNull(),
    estimateHours: integer('estimateHours').notNull(),
    processDefinitionId: integer('processDefinitionId').references(() => ProcessDefinitions.id)
});

When trying to upsert a new Processing using
await db
  .insert(Processings)
  .values(form.data.processings)
  .onConflictDoUpdate({
    target: Processings.id,
    set: {
      name: sql`excluded.name`,
      processDefinitionId: sql`excluded.processDefinitionId`,
      estimateHours: sql`excluded.estimateHours`,
    },
  });

The query returns this error:
error: column excluded.processdefinitionid does not exist
and further in the error:
hint: 'Perhaps you meant to reference the column "excluded.processDefinitionId".'
The difference is in the casing of processDefinitionId.
I'm on typescript so I'm using intellisense suggestions.
Expected behavior
No response
Environment & setup
I'm using sveltekit right now
Vercel Postgres
Typescript

You need to add quotes around the column name, otherwise the DB will treat it as a lower-case name. It's a standard DB behavior.

Hello Dan!
Could you provide an example? I see no quotes apart from ticks.
Any help is appreciated

ran into the same issue. as @dankochetov says, it should work if you add quotes "" around the column names name, processDefinitionId, estimateHours as below
set: {
  name: sql`excluded."name"`,
  processDefinitionId: sql`excluded."processDefinitionId"`,
  estimateHours: sql`excluded."estimateHours"`,
},

That's a great idea, I'll use that. Thanks!


Improve homepage

Show what area is being hovered on the map
Clarify that the list contains both TAs and LADs
Add about button

https://user-images.githubusercontent.com/1664407/211301872-6f96ab80-edcb-411e-93e3-626c0f5e2f24.mp4

Big 👍 to these changes.


add CODEOWNERS

Enables developer infrastructure to be aware of any development going on in the cmake repo.
Particularly we want to avoid new features being developed for cmake that are not accounted for in the bazel system.

cc @silverjam do we need to edit the project settings so that it requires dev-infra for reviews in this repo?

Yes please

I don't have permissions to view/edit the settings in this repo.
I thought just adding the CODEOWNERS file would make the reviews required but it doesn't look like that's the case.


schema/fields changed fieldBuilders to exported types

Allows to create field templates as mentioned here https://github.com/ent/ent/issues/1381:

fields can be defined in a much cleaner, consistent and flexible way
simplifies to comply with company wide schema policies
allows to create tests against complex field definitions once

A function like
func PrimaryNanoID(fieldname string, prefix prefixes.Prefix) *field.StringBuilder {
	fieldname = strings.ToLower(prefix)

	return field.String("id").
		StorageKey(fieldname).
		GoType(nanoid.NanoID("")).
		DefaultFunc(prefix.NewNanoID).
		Match(regexp.MustCompile("^" + string(prefix) + "_[A-Za-z0-9]{19,25}$")).
		NotEmpty().
		Immutable().
                Annotations(
	        	entsql.Checks(map[string]string{
		        	fmt.Sprintf(`%v_valid_key`, fieldname):        fmt.Sprintf(`(%v ~ '^%v_[A-Za-z0-9]*$')`, fieldname, string(prefix)),
			       fmt.Sprintf(`%v_non_empty_string`, fieldname): fmt.Sprintf(`(utils.null_or_non_empty_trimmed_string(%v))`, fieldname),
	      }),
	)
}

makes it possible to reduce the field definition on each schema to one line (and remains expandable). E.g.
customfield.PrimaryNanoID(prefixes.FileID).Comment("This is the primary key")

Thanks for the contribution, @nxso. At the moment, we don't plan to export these builders because there are upcoming changes to make their implementations more type-safe using generics. I intend to address this in future versions. Since we cannot introduce breaking changes to the ent/schema, I prefer not to export the actual types at this stage.
Having said that, the issue described in https://github.com/ent/ent/issues/1381 can be solved the same as we do in the schema/mixin package and also internally. Since all builders expose the Descriptor method, you can add to your custom  constructors additional options as follows:
type FieldOption func(ent.Field)

func WithFieldComment(comment string) FieldOption {
	return func(f ent.Field) {
		f.Descriptor().Comment = comment
	}
}

func WithFieldAnnotations(annotations ...schema.Annotation) FieldOption {
	return func(f ent.Field) {
		f.Descriptor().Annotations = append(f.Descriptor().Annotations, annotations...)
	}
}

 // More options.

// Custom constructors.
func PrimaryNanoID(fieldname string, prefix prefixes.Prefix, opts ...FieldOption) ent.Field {
	fd := field.String("id").
		StorageKey(fieldname)
		// ...

	// Set field options.
	for _, opt := range opts {
		opt(fd)
	}
	return fd
}

Then, the usage is as follows:
PrimaryNanoID("id", prefixes.User, WithFieldComment("User ID"), WithFieldAnnotations(...))
CustomIntField("name", WithFieldComment("..."), ...)

I actually prefer this approach because it can be used for any field type.


[5.9][SE-0393] Enable parameter packs for generic functions.

Explanation: Now that SE-0393 is accepted, enable parameter packs for generic functions by default. The -enable-experimental-feature VariadicGenerics flag still exists and is required for generic types with parameter packs. This change also adds a separate TupleConformances flag, as the current experimental implementation of tuple conformances previously also used the VariadicGenerics flag.
Scope: Impacts new code using parameter packs. Does not impact existing code other than a few changes to diagnostics when repeat is parsed as a pack expansion expression.
Issue: rdar://103147562
Risk: Very low.
Testing: Updated existing parameter packs tests to remove -enable-experimental-feature VariadicGenerics.
Reviewer: @xedin
Main branch PR: https://github.com/apple/swift/pull/65214

@swift-ci please test


Hugo theme is not applied. All I can see is just word and img that I used

So for some reason, my website theme is starting to not apply. Have any idea? This the website I created: https://wessonmartin2018.firebaseapp.com/
Help!! Thx!

I found the issues. It looks like I accidentally overwrite the css without knowing it.


Backport fix for kotlin-jvm and java-gradle-plugin interactions with configuration cache enabled

Fixes https://github.com/gradle/gradle/issues/16269
See https://github.com/gradle/gradle/pull/16224

@bot-gradle test AST

Sorry some internal error occurs, please contact the administrator @blindpirate

@bot-gradle test RFM

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test and merge

OK, I've already triggered a build for you.


Fix for duplicate entries in mocha.options.globals

Fixes https://github.com/mochajs/mocha/issues/3933
Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions.

Description of the Change

Adds a deduping reducer to Mocha.prototype.globals to ensure that no duplicate items are added.
Alternate Designs

Decided against using Array.prototype.includes, opted to use IndexOf instead, to ensure the solution has a broad base of support since mocha runs in a lot of places. The method is already using Array.prototype.filter, so I think it's safe to use Array.prototype.reduce, which I believe has equivalent support.
Why should this be in core?

Slight change to a core method of the Mocha constructor API. Not a candidate for its own package.
Benefits

Mostly just house-cleaning.
Possible Drawbacks

Possible speed impact, but probably negligible.
Applicable issues

https://github.com/mochajs/mocha/issues/3933
Originated from a discussion with @juergba here: https://github.com/mochajs/mocha/pull/3914

@juergba Here's that PR I promised you to fix the duplicate globals issue. Let me know if you think this is the right approach.

Coverage increased (+0.08%) to 92.429% when pulling 74a9896f6412f1c869c605c289ec951b40da962c on pascalpp:issue/3933 into 29b7615148b383f4b177ecd21c917bad6f621561 on mochajs:master.

Will attempt to resolve this in https://github.com/mochajs/mocha/pull/3914


Environment:

App version:
Kubernetes version (use kubectl version): v1.21.0
Install details (e.g. helm install args):
koordinator_1.4
Others:

@hiwangzhihui To recursively check the parent tree, please set enableCheckParentQuota to true in the pluginArgs.


Router - if path is missing get path from parameter

https://github.com/slimphp/Slim/issues/2627

Not expecting this to be merged, just putting it out there.

A few comments:

I can't understand the actual issue you attempted to describe in #2627
You're not working off of the lastest master branch of 3.x
We're not going to modify the codebase to cater to an editor in particular, in this case Netbeans

Thanks

As indicated, I submitted this to document the issue. The issue being that when the framework is invoked like so: index.php?path=/some/path.php slim does not pick up the path from the parameter.


Fox Sports Channels

Source
https://www.foxtel.com.au/tv-guide.html/grid/
Notes
Channels 501, 502, 503, 504, 505, 506
This is a general guide for Australia don't know if it helps at all.
Thanks for your EPG's

The guide for 501 (Fox Cricket), 502 (Fox League), 503 (Fox Sports 503), 504 (Fox Footy), 505 (Fox Sports 505), 506 (Fox Sports 506) is now available at the link:
https://iptv-org.github.io/epg/guides/au.xml


fix: add temp's id to ids in updateTemp #489

Summary
When promoting a temp to a "real" item, the updateTemp mutation migrates a temp from tempsById to keyedById. It was not also adding the new ID to the ids array.
This PR adds the new ID to ids and adds a test assertion to verify.

[x] Tell us about the problem your pull request is solving.
[x] Are there any open issues that are related to this?

#489

[x] Is this PR dependent on PRs in other repos?

no

Other Information
I changed the type of ids from string[] to (string | number)[] so the test could use Array.includes with the ID of type number. Ids can already be string or a number.

@hamiltoes could you address the failing test?  Thanks for the PR!

@marshallswain actually the test that's failing was broke by 3.10.4 and fixed by #491 😄 is there any way to trigger Travis CI again for this PR without pushing an empty commit?


Cortex Schema config should now be configured via a YAML config

The new config can be passed in via the "config-yaml" argument. When set, the legacy arguments will be ignored. Review schema_config.go for further details.

(cleaning up older issues)
current chart the YAML config file


White/gray/black etc does not work as a main color

Currently, colors which all of R G and B are equal, example #FFFFFF or #CDCDCD does not recolor the main red color of the gauntlet. These colors which are grayscale colors ranging from white to black, seem to revert to the original red color. (Mostly, which some shading differ)
Also darker/brighter versions of the same color does not differ, example dark blue (almost black) #26262A and bright blue (almost white) #E4E4FD do not differ.
Example of white and very very bright teal:

Note that all of these do work as a secondary color.

Thanks for reaching out! Currently, the (primary) color only supports hue shifts. I'm actively working on improving this but can't provide an ETA right now.

Came here for the same issue. Is this being worked on? If not do you take pull requests if I tinker with it?

I'm currently tied up with some irl stuff, but yeah - it is being worked on. You are always welcome to make pull requests (you can dm me on discord if you want to go into specifics). It's surprisingly difficult to allow saturation/brightness changes, since we have very few bits to work with - you tend to loose a lot of detail quickly.

I'm currently tied up with some irl stuff, but yeah - it is being worked on. You are always welcome to make pull requests (you can dm me on discord if you want to go into specifics). It's surprisingly difficult to allow saturation/brightness changes, since we have very few bits to work with - you tend to loose a lot of detail quickly.

Could you elaborate about "allow saturation/brightness changes"? Does this mean its not allowed to manipulate such values for graphics within Runelite?

No, you can manipulate them just fine (the plugin handles this for the secondary color).
I'll assume you're familiar with the HSB color system, so here’s what's happening on the development side:
We have a total of 16 bits to represent the final color. Starting from the most significant bit (MSB), we allocate 6 bits for hue, 3 bits for saturation, and the last 7 bits for brightness.
Given this, we use a reference color (65452 in decimal), which represents about the average color of the default gauntlet. This breaks down into 63 for hue, 7 for saturation, and 44 for brightness (all in decimal).
Next, the plugin takes the user’s requested color values. For example, if the user provides 23 for hue, 3 for saturation, and 19 for brightness, the plugin calculates the "color difference" between these values and the reference (63 - 23 = 40; 7 - 3 = 4; 44 - 19 = 25). This difference is then applied to every other color in the gauntlet.
For hue, this generally works well because the gauntlet's structures tend to have consistent hue values. However, for saturation and brightness, this can cause issues due to the complexity of the structures (many lit or shadowed parts). This often leads to values falling outside the allowable range, either below 0 or above their maximum bit value. I can't allow these values to loop around, as that would result in bizarre, broken layouts.
As a result, many colors hit their minimum (0) or maximum values for saturation or brightness, which leads to a monochrome gauntlet where objects are indistinguishable.
However, if I limit the saturation and brightness changes to only affect the lit-up parts (which I do for the secondary color), the complexity issue disappears, since these parts usually have more uniform values.
To be clear, this is a solvable problem, but it requires fine-tuning or a different approach. For now, to ensure the plugin is in a usable state, I've opted to restrict changes to only the hue of the primary color.


broken

been doing workarounds for a while and nuthin'. Too bad its not working no more

Hello. Tested it myself, and also found out it doesn't work. It looks like they have changed something on the website. I'm going to fix this bug when I have time.

What exactly is not working, @demian-wolf @demian-wolf ?

@Xblow, I was talking about the ReversoContextAPI. When @DevWannabe-dot opened the issue, I found out that neither .get_examples nor .get_translations worked (generators yielded nothing), so I thought they meant this issue.
@DevWannabe-dot, is that what you were talking about? Could you please elaborate on what exactly didn't work and what workarounds have you been using?
Just now, I have tested it again, and everything seems to work okay. Actually, it's really strange behavior, and it's important to find the cause so that it never appears again...
On Friday, I'm having some free time, so I am gonna take a look at this bug.
P.S.: @Xblow ow, thanks for the star :)


Tabs/spaces, semicolons

I wonder, is it possible to make the snippets configurable so that the spaces become tabs and the semicolons are left out?
If not, perhaps you could make a second extension for tabs, no semi?

Hello @wmertens and sorry for my late reply. I don't think we can configure the snippets regarding the spaces and the semicolons. At least I can't imagine a way to do that.
Now about the second extension I think it would make the entire snippets functionality more complicated. I know I had to make a choice on how to implement that and it doesn't fit all the tastes but I can't do much about it. Even if I make a different version then someone else could argue that prefer tabs with semicolons. I hope you understand.


Request to upgrade version

Kindly update the carousel_pro version. it gives an error of null version

carousel_pro_nullsafety: ^1.0.2


Specify order of columns in project curve table

Probably with a flag like auto_order which is True by default (current behaviour).
Or maybe there are other options, eg order='alpha', or order='count' or order='keys' perhaps.

This doesn't happen for the left most columns, but it does works for the curve columns via the order of the elements in keys.

Unless I'm missing a particular use case. I'd say we can close this issue.

Right, but the idea is to be able to resort them dynamically according to some criteria. They're arranged according to my keys list, but now I want alphabetical, now by the reverse of the count of wells per curve.


Increase 79 character line limit

Due to the project having such a large number of message focused strings, I have increased the character limit to minimise excessive line wrapping caused by large message strings.

Fixed in: 14369f2ea7faccf5bab7b94bd0645c5369311b52
Increased project line limit to 120 characters.


OIDC Integration into GNAP flow

Implementation of TODOs (oidc integration for redirect interact) mentioned in https://github.com/trustbloc/auth/pull/212/files#diff-dfef19de3dd2587dafd4075a5ae93653e2b4b3da89f623ac639694d4e17325e3L191

Finished in #217


Add railway down

Closes #199
This PR will add a railway down command. I'm not comfortable enough with my GQL skills, reverse engineering skills, or Go skills to test it and be sure that I won't break anything important, so I have not tested anything.

Example usage:
❯ ../railway/cli/bin/railway down
Delete latest deployment for project railway-cli-ignore-test? (y/N): y
💁 Deleted latest deployment for project railway-cli-ignore-test.

yay


5 star rarity not working

My 5 star artifacts and weapons both show up as a rarity of 0 but my 4 stars work fine.

Hi there. Sorry for the delay in getting to this issue. Are there any more specific details you can provide? Screenshots generated in the logging folder will help us to understand the problem more as well.

it actually fixed itself when i tried it again and used another monitor i
had
On Sun, Feb 6, 2022 at 2:31 PM Alec @.***> wrote:

Hi there. Sorry for the delay in getting to this issue. Are there any more
specific details you can provide? Screenshots generated in the logging
folder will help us to understand the problem more as well.
—
Reply to this email directly, view it on GitHub
https://github.com/Andrewthe13th/Inventory_Kamera/issues/191#issuecomment-1030908533,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXQV6KGPMDUJDKYZ5LALQE3UZ3LDVANCNFSM5NDBOMTA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>


Is anyone else working with sound and having this issue?

No matter what I do it keeps saying that loadSound is undefined?

Did you uncomment the p5.sound.min.js line within your HTML document?
--
Michael Musick
michaelmusick.comhttp://michaelmusick.com
On May 2, 2018, at 3:36 PM, Ian Baldessari <notifications<EMAIL_ADDRESS>wrote:
No matter what I do it keeps saying that loadSound is undefined?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/Montana-Media-Arts/120_CreativeCoding/issues/104#issuecomment-386129283, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADe36O5mzcbbd_zVhqZjyQfikGuIFwskks5tuib3gaJpZM4TwMqL.

I would've never have caught this, thank you.

I'm having an issue with a sound file. I've taken a screenshot of the code below where I declare the variable 'song,' define it in the preLoad function, and then in setup call it - song.play();
However, the song does not play, and when I inspect the element in Firefox, I get - TypeError: song is undefined  which I don't understand as I think I have done that in the code.
Any suggestions welcome!
And yes, I have uncommented the p5 sound line in the html.  :)

As with the setup and draw functions. You can only define preLoad a single time. I imagine that when you define a second time, the song variable is getting collected by garbage. Therefore, combine your two preLoad functions into a single preLoad functions definition. I think that will fix it?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

I'm pretty sure that's exactly what it was, I just looked at this in another thread in the forum and it sounds like it's working now.

Yep - it is fixed now. Thanks to both of you!


Will not boot up after download

I have downloaded it but it wont boot up
I found the app through tiktok, and i liked how clean it looked. I also saw that you could make it transparent. But now that I have baught it, it wont start, so I only have it on my computer now.

OS: Windows 10 Home
Version: 2004

To be able to focus on major/current bugs I had to close all issues. The issues section has gotten very messy to a point that I couldn't follow it anymore. Most issues are duplicates, very old or are already fixed/solved. Feel free to reopen this issue if you still have this issue on the latest version of TaskbarX to get my attention. All feature requests have been put in a list here: 💡| Feature requests #870
I hope you understand ❤


Remove chef-sync from the known add on packages for the install command

chef-sync is no longer being offered as a product to new users and should
be removed as an option to prevent unintended user confusion.
It has already been removed as an option on the doc site and from the downloads site.

:+1:

@stevendanna nuked.


"Get query for Compare View" has capitilization issues

"Get query for Compare view"
or
"Get query for Compare"
or
"Map query in Compare"

Changed to "Get query for Compare"


Wrong keypresses being sent.

After building the Plaid all the keypresses were registering correctly, except one dead key. I was trying to trace this but since then only some of the keypresses work, and they dont match the keys that I'm pressing. A lot of the keys seem to trigger some combination with ctrl and alt too.
I've tried reflashing the firmware, but nothing seems to affect it. Any idea what I've done wrong?

Please check switch matrix isn't short.
And test this keymap below.
[0] = LAYOUT_plaid_grid(
    KC_A,     KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO,
    KC_NO,  KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO,
    KC_NO,  KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO,
    KC_NO,  KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO, KC_NO
),

@hsgw I tried the keymap you sent and this is what I get pressing all the different keys:

I can't seem to find a short in the matrix. I wonder if maybe I've damaged the atmega328?

I’ve just had the exactly same problem with my plaid yesterday. Rebooted my PC and keypresses were messed up. Found this in r/olkb: https://www.reddit.com/r/olkb/comments/d35aqo/help_with_plaid_thk_sending_seemingly_random/
Will try the fix later

confirming that
  eeconfig_init();
}```
also fixed the issue for me.

I am not quite certain if its related. I had a similar issue. Only when I press the key where the spaces are, it then switched to layer 3. I flashed an option on layer 3 to go back to layer 1 and that works. But I have to do it every time I plug it in. I will try the matrix init and see if that makes a difference


Suggestion: Tektopia Lumberjack compatibility

Even since the new villager mod, Tektopia by Tango Tek came out, I wonder if you can make the dynamic trees compatible with tektopia so that the lumberjacks can cut it down, get resources, and replant them.

I have a feeling though that this might have to be done on Tango Tek's side. Either way, I second this suggestion.

It would require them to be able to:

Detect Dynamic Trees
Plant Dynamic Saplings

Both of those are difficult to implement from only one side.

I stand corrected

It's still quite doable, but it would require TangoTek to help with at least some bits.

Any updates on this topic? Haven't found any package for now.


Make organizations searchable by ownership

Tasks V1

Update API keys with crm.objects.owners.read scope

[x] In QA - re-use the one from dev
[x] In live - Change the prod one: https://app.hubspot.com/private-apps/6291320

https://github.com/hypothesis/devdata/pull/78
https://github.com/hypothesis/report/pull/193
[x] Add a user centric page with links to organizations and activity
[x] Add a team centric page with links to organizations and activity

Tasks V2
General

[x] https://github.com/hypothesis/report/pull/211

LMS User Focus Dash
e.g. https://report.hypothes.is/dashboard/19-prototype-owner-focus-dashboard?owner_id=213113697&timescale=trailing_year&role=user&group_type=course

[x] Create one (minimum is showing the name and email)
[x] Add courses (with minimum deets)
[ ] Find places where a user shows up in teacher reports and link through
[ ] Duplicate counting of orgs which have more than one company linking them
[ ] Polish pass for names

Team Overview Dash
e.g. https://report.hypothes.is/dashboard/21-prototype-team-overview-dashboard?id=15543479&id=632071

[x] Limit to Sales and Success teams
[ ] Polish pass for names

Team Focus Dash
e.g. https://report.hypothes.is/dashboard/20-prototype-team-focus-dashboard?team_id=15543479

[x] Split the annotation and billable graph into two (over the relevant graphs)
This doesn't make any sense. Each team is attached to nearly every record

~Add teacher course info (1 row per teacher, course counts)~
~Add teacher course info (1 row per course, teacher lists)~

[x] Allow filtering by company and org in both as a filter
[ ] Add something to click on to get to organization dash when the name is blank
[ ] Polish pass for names

Owner Focus Dash

[x] Split the annotation and billable graph into two
[x] Add teacher course info (1 row per teacher, course counts)
[x] Add teacher course info (1 row per course, teacher lists)
[x] Allow filtering by company and org in both as a filter
[ ] Add something to click on to get to organization dash when the name is blank
[ ] Group created not showing in results
[ ] Polish pass for names

I've de-risked the getting things from Hubspot portion of this. We can get the two mentioned types of owners, along with teams. This means we could try to do something with teams, or we could not bother?
~It's worth checking in with @jeremydean to see if a company landing page would be useful or not.~ Yep, I think it is.
There's a few many to many things going on here, so we might need some cross reference tables or array columns:

Users can be in multiple teams
Orgs have multiple companies

So it might be convienent to have something like organization_owners with:

organisation_id
success_owner_ids
company_owner_ids
team_ids

Nope! https://github.com/metabase/metabase/issues/2974 - Metabase doesn't really work with array fields...
Aha! We can use Metabase for mockups!

https://report.hypothes.is/dashboard/20-prototype-team-focus-dashboard?team=Success
https://report.hypothes.is/dashboard/19-prototype-owner-focus-dashboard?owner=Bob Smith

User story

As a member of the success or sales team, I would like to conveniently see all organizations which are assigned to me.

Background
Our sales and success staff are grouped into teams:

Sales Team 1

Member 1
Member 2

Success Team 1

Member 3
Member 4

Companies are allocated to individual members, not teams (although the link is implicit). Each company has one member from each kind of team stored in fields on the record:

Sales team member: “Company owner”
Success team member: “Success owner”

Initial idea for a solution
Have a separate table / column for company owner and success owner and make it searchable on the organization overview page.
Priority (High)
This would be very beneficial for our users as this is currently a massive pain.
Effort Estimate (Medium)
We don’t have the data we need for this, but assuming it’s readily available from the Hubspot API (we’d want to check this) then getting this out and combining it shouldn’t be very hard. This should be investigated if we want to de-risk this, as this is kind of a big un-get-roundable hurdle if we can’t pull these values.
This will be more effort than the single report items above, but each step should be more straight forward once we have the info.
User story

As a team manager I would like to be able to compare activity metrics across organizations owned by the different staff members in my team. This would let me spot if someone is doing well or badly compared to their peers.

Background
If you are a team leader you need to be able to compare performance of the various team members. This implies a view where all, and only, your team members are visible.
I do not know how this is done currently.
This implies you can see:

The metrics you care about
The relevant team member names

It strikes me this might be better grouped by user than org? It would be good if it wasn’t as this is harder for us.
Initial idea for a solution
Have a separate table / column for company owner and success owner and make it searchable on the organization overview page.
The team leader can pick multiple values for user until they have filled out their team.
The table must display the users so they can know who is who.
Priority (Medium)
You might get this for free as result of the above, but as there are many more users than managers it seems like the above is probably more broadly beneficial?
Effort Estimate (Low / None)
We have to make sure we show the relevant user in the table, and if that’s enough, then this is really very little effort. If something more fancy is required (like aggregating values by user) this could be more involved. We’d need a bit more detail.

Feedback from Loree that we can close


Use uniform approach for the passing IP address

At this moment we explore 3 different approaches:

byte[16] address and uint addressType
*byte address and byte addressLength
struct AGAddr = {byte[16] address; uint addressType} structure

Let's start use struct AGAddr = {byte[16] address; byte addressLength} in all places

core/pull-requests/846


FloatSlot._as_feature should return unambiguous values

Currently, if a float slot value is set to 0.0 and the min value is 0.0, FloatSlot._as_feature will return 0.0. However, this is also the default value returned when the value could not be converted. As a result, the slot is considered "unfilled" and isn't added:

See user issue here
Proposed changes:

Make FloatSlot return two floats:
[1.0, <value>] if successfully converted
[0.0, 0.0] if not
This mimics the behaviour of BooleanSlot

Status (please check what you already did):

[X] added some tests for the functionality -> (updated existing tests)
[X] updated the documentation -> (not really user-facing, the functionality should stay the same from the outside)
[X] updated the changelog (please check changelog for instructions)
[X] reformat files using black (please check Readme for instructions)

this is a model breaking change and needs to increase the minimum compatible model version

@dakshvar22 should we run the model evaluation tests on this?

@tmbo Model regression tests are only for NLU at the moment, so not needed here.

this is a model breaking change and needs to increase the minimum compatible model version
@tmbo: thank you for taking a look! What does the above mean in terms of action items? I'm guessing it has to be documented somewhere, just not sure where

your changelog item should include a warning, e.g. here is an example: https://rasa.com/docs/rasa/changelog#deprecations-and-removals
and you'll need to increase the version in https://github.com/RasaHQ/rasa/blob/master/rasa/constants.py#L27

@tmbo sorry, could you take another look? I'm not sure why this is failing - I updated the rasa-sdk version by hand, maybe I shouldn't have done this?

Hi @tmbo, I think this is finally ready. I'm sorry it got so messy and required so many revisions... I definitely know better now for the future.

don't worry, e.g. the poetry issues and needed updates aren't your fault - was actually good that we ran into that to fix it :+1:


⚠ Bofrost.be has degraded performance

In d9012a8, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1908 ms

Resolved: Bofrost.be performance has improved in b66fec8 after 9 minutes.


Use headTitle and customCSS properties in newer apps

chaise-config.js has a customCSS property that's currently honored in the Search and Record 1 apps, but not the rest. The custom CSS file should be used in the other apps as well.
There's also a headTitle property that's used in Search, Record 1, Viewer, and RecordEdit, but not the others, so headTitle should be added in RecordSet and Record 2.
This issue should fix #516 and is somewhat related to #543 (dropdown support in navbar) because we need all apps to include the custom CSS in order to achieve a consistent look for the navbar across all apps.

Currently blocked as described in PR #599. :(

#599 has been merged!


Add npcmstsfc.txt

Government website:
https://ched.gov.ph/list-of-higher-education-institutions-2/
https://www.whed.net/institutions/IAU-012833

@davi811231 First stage of verification passed, official domain for Northern Philippines College for Maritime Science and Technology is npcmstsfc.com as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@davi811231 Regrettably, this request has signs of fraud. I have to close it without merging.
It does not mean that something is wrong with the school. The issue is related to a combination of suspicious factors related to the domain itself.
Thank you for your understanding!


Add remaining stories

[x] autofocus
[x] cohort date range
[x] date range
[x] file upload
[x] spacing
[x] toggle
[x] validators

Had to split across multiple PRs. All are merged.


One-shot vm not getting gce preemptible event and not retry

Cannot contact ubuntu-1804-lts-spot-ojrbv0: hudson.remoting.ChannelClosedException: Channel "unknown": Remote call on ubuntu-1804-lts-spot-ojrbv0 failed. The channel is closing down or has closed down
Cancelling nested steps due to timeout
Could not connect to ubuntu-1804-lts-spot-ojrbv0 to send interrupt signal to process
ubuntu-1804-lts-spot-ojrbv0 was marked offline: Connection was broken: java.io.EOFException
at java.base/java.io.ObjectInputStream$PeekInputStream.readFully(ObjectInputStream.java:2763)
at java.base/java.io.ObjectInputStream$BlockDataInputStream.readShort(ObjectInputStream.java:3258)
at java.base/java.io.ObjectInputStream.readStreamHeader(ObjectInputStream.java:873)
at java.base/java.io.ObjectInputStream.(ObjectInputStream.java:350)
at hudson.remoting.ObjectInputStreamEx.(ObjectInputStreamEx.java:49)
at hudson.remoting.Command.readFrom(Command.java:140)
at hudson.remoting.Command.readFrom(Command.java:126)
at hudson.remoting.AbstractSynchronousByteArrayCommandTransport.read(AbstractSynchronousByteArrayCommandTransport.java:36)
at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:63)
Caused: java.io.IOException: Unexpected termination of the channel
at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:77)

Hi @litan1106, can you tell me more about this One Shot VM?
If I understand the question correctly, you would have the boxes for "One Shot" and "Preemptible" checked for this configuration, right?
Also, what is the "Node Retention Time" for the configuration?

@stephenashank correct. here is my settings
Node Retention Time: 6
Number of Executors: 1
Launch Timeout: 300
One-Shot: checked
Preemptible?: checked

@litan1106 After attempting to reproduce this I think I have an idea of what is going on. Whether you were manually testing preemption through "simulate-maintenance-event" or had unfortunate luck with limited resource availability in the VM's zone, it seems that the machine may have been preempted too early in the launch cycle.
In order to check for a preemption event, we need to connect to the agent over ssh, then install and run the jenkins agent jar. Once that is done we are able to run a process on the agent which checks for the "preempted" value being changed in the instance metadata, which is how GCP gives warning for this. Currently we only restart the jobs under this specific circumstance. So, if the listener is added before the preempted instance is shut down but after the preempted flag is set, no change will be detected and it will timeout instead of canceling and restarting the job.
This should be a rare occurrence, but I think it can be mitigated by checking whether the instance is already preempted right after launching, most likely in the same place as the current listener. There may still be a rare case where the preemption event occurs between checking the initial value and then making the request that waits for a change.
Thanks for submitting the issue and bringing this to our attention.


IJ 152 User Goals

Users can now set short-term and long-term goals on the platform and these goals can belong to any number of goal types (currently set to Aspiration, Hope and Meaning) to better facilitate the 'aim' of the goal. Users can also mark the goal as achieved, archived or deleted by using the ellipsis control. Archived goals will appear in a searchable index.
Goals Index

Controls for unachieved goal

Controls for achieved goal

Archived goals

Archived goals can be marked as completed by the same ellipsis controls view.

Do you reckon it's worth putting something on the user view for team_members. So when they are having a quick overview of a user they could pick up on any achieved goals?

That view is becoming much too bloated, we need to rethink it. We have a core piece of functionality ready to go here so lets just get it integrated and if we need an additional view that can be added to a new ticket.

@phil-6 @garethdandrews are you able to have a look at this PR so we can move it forward?


SDK Service is not returning supplemental text for traffic directions.

When asking the assistant for traffic that isn't a known location (home/work), the audio feedback is fine, but the text response shows up blank.
Here is what I used to test:
Me: what's the traffic like on the 280
Audio from Assistant: There's light traffic on I280 California
Sadly there is nothing in the supplemental_display_text field in DialogStateOut.

@Fleker  any update on this issue?

I don't have an update. If I had an update, I'd share it.


FindNearestLanes doesn't return the correct lanes

I commented out the part from xodr_parser where all the lanes other than of "driving" type are ignored, so the rtree in MapInterface should have all lanes.
Then I queried the 3 nearest lanes from a given point using (the python binding) of FindNearestLanes.
For this point I would expect the 3 nearest lanes to be of type sidewalk (5), border (6) and driving (1):

But the function returns two lanes of type 1 and one of type 6:

When trying it for a different point:

Here the function works. It returns (as expected) lanes of type none (0), border (6) and sidewalk (5).
I also tried it with random other points along the road, for some points it gives the expected results, for others not.
I circumvented this problem by creating my own function to find the nearest lanes which uses:
boost::geometry::index::satisfies([&](rtree_lane_value const& v) {return distance(v.second->get_line(), point) <= radius; }),
instead of boost::geometry::index::nearest(point, num_lanes);.
This returns the expected results (but requires a radius parameter).
I also created a function to find all the lanes that are intersected by a given line and when doing the rtree query using boost::geometry::index::intersects(line_segment), it didn't return anything when it clearly should. Using a own lambda (here using modules::geometry Collide) solved this problem too.

I did a quick runtime comparison and using bgi::satisfies with distance (the way I implemented it) is more than 10 times slower than the version using bgi::nearest so it's not really an alternative.

I have another issue with FindNearestLanes. I want to use the function to find the outer boundary of the corridor that an agent currently is located in. Intuitively this could be done by calling FindNearestLanes(agent_position, 2, lanes). This returns two lanes, and the one with the higher absolut lane position should be the outer boundary.
This approach however fails, if the vehicle is located between the lanes with lane positions 0 and 1, because FindNearestLane never returns the lane with position 0 (i.e. the plan view). In this case, the function would return lanes 1 and 2, which would place the agent in the wrong corridor.
My workaround is to compare the distance between the vehicle position and the outer lane with the distance between the inner and outer lanes to detect this situation:
if (geometry::distance(outer_lane->get_line(), position) > geometry::distance(inner_lane->get_line(), outer_lane->get_line())) {
  // Position is between lane 0 and 1, but the two nearest lanes are 1 and 2, because 0 is never returned -> current_lane is the inner_lane
  return inner_lane;
} else {
  return outer_lane;
}

This workaround could fail if the all lanes do not have the same offset to each other.
@klemense1

Does this issue still exist? @AKreutz @ctonic @klemense1

My comment is not really an issue with Bark but a functionality that would be nice to have.
"Finding the outer boundary Line of the lane a vehicle is currently driving in" is a use case that I have stumbled upon twice, without having found a simple way of implementing it. I just wanted to mention it so that you can decide if this procedure is something that would be useful to have in the future.

should be solved by commit https://github.com/bark-simulator/bark/commit/dcbf0fd3a5d5a8f080184c57d71abab4fd8b5c52#diff-22c74272bd958ea74cb21f3612cea70f
( changing rtree from outer lane line to center line )


[SPARK-25307][SQL] ArraySort function may return an error in the code generation phase

What changes were proposed in this pull request?
Sorting array of booleans (not nullable) returns a compilation error in the code generation phase. Below is the compilation error :
java.util.concurrent.ExecutionException: org.codehaus.commons.compiler.CompileException: File 'generated.java', Line 51, Column 23: failed to compile: org.codehaus.commons.compiler.CompileException: File 'generated.java', Line 51, Column 23: No applicable constructor/method found for actual parameters "boolean[]"; candidates are: "public static void java.util.Arrays.sort(long[])", "public static void java.util.Arrays.sort(long[], int, int)", "public static void java.util.Arrays.sort(byte[], int, int)", "public static void java.util.Arrays.sort(float[])", "public static void java.util.Arrays.sort(float[], int, int)", "public static void java.util.Arrays.sort(char[])", "public static void java.util.Arrays.sort(char[], int, int)", "public static void java.util.Arrays.sort(short[], int, int)", "public static void java.util.Arrays.sort(short[])", "public static void java.util.Arrays.sort(byte[])", "public static void java.util.Arrays.sort(java.lang.Object[], int, int, java.util.Comparator)", "public static void java.util.Arrays.sort(java.lang.Object[], java.util.Comparator)", "public static void java.util.Arrays.sort(int[])", "public static void java.util.Arrays.sort(java.lang.Object[], int, int)", "public static void java.util.Arrays.sort(java.lang.Object[])", "public static void java.util.Arrays.sort(double[])", "public static void java.util.Arrays.sort(double[], int, int)", "public static void java.util.Arrays.sort(int[], int, int)"
	at com.google.common.util.concurrent.AbstractFuture$Sync.getValue(AbstractFuture.java:306)
	at com.google.common.util.concurrent.AbstractFuture$Sync.get(AbstractFuture.java:293)
	at com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:116)
	at com.google.common.util.concurrent.Uninterruptibles.getUninterruptibly(Uninterruptibles.java:135)
	at com.google.common.cache.LocalCache$Segment.getAndRecordStats(LocalCache.java:2410)
	at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2380)
	at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2342)
	at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2257)
	at com.google.common.cache.LocalCache.get(LocalCache.java:4000)
	at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:4004)
	at com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4874)
	at org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$.compile(CodeGenerator.scala:1305)

How was this patch tested?
Added test in collectionExpressionSuite

Test build #95585 has started for PR 22314 at commit 7dec581.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2763/
Test PASSed.

Good catch, LGTM

@kiszk Thanks. Can you please help look at 22315 as well.

Test build #95585 has finished for PR 22314 at commit 7dec581.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95585/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2766/
Test PASSed.

Test build #95588 has started for PR 22314 at commit 7dec581.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2767/
Test PASSed.

LGTM.

Test build #95588 has finished for PR 22314 at commit 7dec581.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95588/
Test PASSed.

Merged build finished. Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2776/
Test PASSed.

Test build #95601 has started for PR 22314 at commit 2e893ad.

Test build #95603 has started for PR 22314 at commit 2f1b192.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2778/
Test PASSed.

Test build #95603 has finished for PR 22314 at commit 2f1b192.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #95601 has finished for PR 22314 at commit 2e893ad.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95603/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95601/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2779/
Test PASSed.

Test build #95604 has started for PR 22314 at commit 2f1b192.

Test build #95604 has finished for PR 22314 at commit 2f1b192.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95604/
Test FAILed.

Test build #95617 has started for PR 22314 at commit 3645438.

Test build #95617 has finished for PR 22314 at commit 3645438.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95617/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2790/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2802/
Test PASSed.

Test build #95635 has started for PR 22314 at commit d27256e.

Test build #95635 has finished for PR 22314 at commit d27256e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95635/
Test PASSed.

Thanks! merging to master.

@ueshin @kiszk @maropu  Thanks a lot.

@dilipbiswal Do we need to backport this to 2.3? If so, could you submit a backport pr to branch-2.3 please? Thanks!

@ueshin Sure.

@ueshin Just verified in 2.3. This problem does not exist in 2.3. This is due to the fact that implementation of nullSafeCodeGen is different in 2.3 than in master. However, we are missing the test cases we added in these PRs in 2.3. Should we have the test cases checked in into the branch ? I am afraid that if we ever backported the pr that changed nullSafeCodeGen , we may introduce this bug. Please advise ..

@ueshin We don't have codegen enabled for this function in 2.3. So thankfully we don't have this problem :-)

@dilipbiswal Thanks for confirming!


fatal: not a git repository (or any of the parent directories): .git

Does this issue occur when all extensions are disabled?: Yes (I tried to disable all extensions to disable(workspace))

VS Code Version: 1.63.2
OS Version: WindowsNT x64 10.0.19043

Version: 1.63.2 (system setup)
Commit: 899d46d82c4c95423fb7e10e68eba52050e30ba3
Date: 2021-12-15T09:40:02.816Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19043

Steps to Reproduce:

start vscode and wait a moment.
select the Source Control icon on the left.
(additionally) error popups from extensions related to git appear.

vscode couldn't recognize git repository even though I opened git repository path.

Also, I got the below message from the GitLens extension after starting vscode:

And message from the 'Git Graph' extension:

It's really weird. I have already installed the latest version of Git for Windows.

And I specified git.path as follow:

The result of git rev-parse --git-dir is as follow:

What makes me crazy is that the git commands correctly work inside the command line prompt in vscode.
with powershell

with git bash actually I used zsh instead of bash

and Output (Git) is as follows:
Validating found git in: C:\Program Files\Git\cmd\git.exe
Using git  from C:\Program Files\Git\cmd\git.exe
> git rev-parse --git-dir
fatal: not a git repository (or any of the parent directories): .git
Opening repository for path='d:\@DevDocs\lab_weekly_meeting' failed; ex=Failed to execute git {
  "exitCode": 128,
  "gitErrorCode": "NotAGitRepository",
  "gitCommand": "rev-parse",
  "stdout": "",
  "stderr": "fatal: not a git repository (or any of the parent directories): .git\n"
}
> git rev-parse --git-dir
fatal: not a git repository (or any of the parent directories): .git
Opening repository for<EMAIL_ADDRESS>failed; ex=Failed to execute git {
  "exitCode": 128,
  "gitErrorCode": "NotAGitRepository",
  "gitCommand": "rev-parse",
  "stdout": "",
  "stderr": "fatal: not a git repository (or any of the parent directories): .git\n"
}
> git rev-parse --git-dir
fatal: not a git repository (or any of the parent directories): .git
Opening repository for path='d:\@DevDocs\lab_weekly_meeting\2018' failed; ex=Failed to execute git {
  "exitCode": 128,
  "gitErrorCode": "NotAGitRepository",
  "gitCommand": "rev-parse",
  "stdout": "",
  "stderr": "fatal: not a git repository (or any of the parent directories): .git\n"
}
> git rev-parse --git-dir
fatal: not a git repository (or any of the parent directories): .git
Opening repository for path='d:\@DevDocs\lab_weekly_meeting\2019' failed; ex=Failed to execute gitWhat: 128,
  "gitErrorCode": "NotAGitRepository",
  "gitCommand": "rev-parse",
  "stdout": "",
  "stderr": "fatal: not a git repository (or any of the parent directories): .git\n"
}
> git rev-parse --git-dir
fatal: not a git repository (or any of the parent directories): .git
Opening repository for path='d:\@DevDocs\lab_weekly_meeting\2020' failed; ex=Failed to execute git {
  "exitCode": 128,
  "gitErrorCode": "NotAGitRepository",
  "gitCommand": "rev-parse",
  "stdout": "",
  "stderr": "fatal: not a git repository (or any of the parent directories): .git\n"
}
Opening repository for path='d:\@DevDocs\lab_weekly_meeting\2021-07-13 H&A센터장 세미나.md' failed; ex=spawn C:\Program Files\Git\cmd\git.exe ENOENT {
  "gitErrorCode": "NotAGitRepository"
}Error: spawn C:\Program Files\Git\cmd\git.exe ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:269:19)
    at onErrorNT (internal/child_process.js:465:16)
    at processTicksAndRejections (internal/process/task_queues.js:80:21)
Opening repository for<EMAIL_ADDRESS>failed; ex=spawn C:\Program Files\Git\cmd\git.exe ENOENT {
  "gitErrorCode": "NotAGitRepository"
}Error: spawn C:\Program Files\Git\cmd\git.exe ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:269:19)
    at onErrorNT (internal/child_process.js:465:16)
    at processTicksAndRejections (internal/process/task_queues.js:80:21)
..... (ommitted) .....

I thought that special character @ might cause this situation, So I tried to re-clone in another path string without any special characters, d:\lab_weekly_meeting. The result is the same.
What should I do?

Add
In another machine, vscode recognizes this git repository and works nicely. What's wrong with it?
I integrated my github account on vscode to sync extensions and settings.
Version: 1.63.2 (system setup)
Commit: 899d46d82c4c95423fb7e10e68eba52050e30ba3
Date: 2021-12-15T09:40:02.816Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19042

Based on the information that you have provided the issue seems to be machine specific so we should try to track down the difference between the two machines. Could you please try the following on both machines and share the contents of the Git output?

Download VS Code Insiders to make sure that you have the latest code
Start VS Code insiders using code-insiders --disable-extensions to make sure that all extension are disabled
Open the repository in VS Code insiders and share the contents of the Git Output.

Thanks!

I'm so sorry. I missed your comment, @lszomoru!
As you suggested, I run VS Code Insiders with all extensions that are disabled and open the same repository.
The result is below:
[2022-01-19T05:21:30.652Z] Validating found git in: C:\Program Files\Git\cmd\git.exe
[2022-01-19T05:21:30.804Z] Using git  from C:\Program Files\Git\cmd\git.exe
[2022-01-19T05:21:31.169Z] > git rev-parse --git-dir [169ms]
[2022-01-19T05:21:31.170Z] fatal: not a git repository (or any of the parent directories): .git
[2022-01-19T05:21:31.465Z] > git rev-parse --git-dir [119ms]
[2022-01-19T05:21:31.465Z] fatal: not a git repository (or any of the parent directories): .git
[2022-01-19T05:21:31.674Z] > git rev-parse --git-dir [91ms]
[2022-01-19T05:21:31.674Z] fatal: not a git repository (or any of the parent directories): .git
[2022-01-19T05:21:31.900Z] > git rev-parse --git-dir [109ms]
[2022-01-19T05:21:31.900Z] fatal: not a git repository (or any of the parent directories): .git
[2022-01-19T05:21:32.122Z] > git rev-parse --git-dir [104ms]
[2022-01-19T05:21:32.122Z] fatal: not a git repository (or any of the parent directories): .git
[2022-01-19T05:21:33.116Z] > git rev-parse --git-dir [87ms]
[2022-01-19T05:21:33.116Z] fatal: not a git repository (or any of the parent directories): .git
[2022-01-19T05:21:36.952Z] > git rev-parse --git-dir [149ms]
[2022-01-19T05:21:36.952Z] fatal: not a git repository (or any of the parent directories): .git
[2022-01-19T05:21:37.337Z] > git rev-parse --git-dir [119ms]
[2022-01-19T05:21:37.337Z] fatal: not a git repository (or any of the parent directories): .git

This problem was resolved.
The root cause is the conflicts between git in VS Code and the security monitoring tool which our company insists to install.
After removing and applying the newest patch, git correctly works now.

@WoogonShim, thank you very much for the update. Happy to hear that you were able to track down the root cause of the issue. Would you be able to share the name of the security monitoring tool so that we have it on file in case any other user runs into the same issue? Thank you!

Thank you for your kindness.
The name of security program is "WaterWall". It's a kind of DLP(Data Loss Prevention) system.
https://wwsystems.co.kr/


[bug] refresh.ps1 probably doesn't work yet

Test the refresh.ps1 mechanism before official release

continue to use 1.4.0 via rubygems.org until release is made


When should I call setSettings() method on my php code?

Every time i push data to index ?  I made a mistake on the project.

So that means I should not  do this on any Model logic,I should do this at outside script or by algolia web management tools,right?

Yes exactly

@maxiloc Thank you very much.


HELP TO RUN LOCALLY

Hello,
I would like some help to run the code locally, how much do I run
Returns openai.error.InvalidRequestError: Must provide an 'engine' or 'deployment_id' parameter to create a <class 'openai.api_resources.chat_completion.ChatCompletion'>
I already made the settings in .env.sample
Could it be some setting in this file?

You should not be changing .env.sample, you should be making a new file based on .env.sample with the filename ".env", then that file will get automatically loaded in.

Hi I have the same issue, I was searching .env.sample in the code to see if in some place is a dependency, I didnt find anything related. So why we should not change .env.sample by only .env? Anyway is producing the same error

env.sample is just an example, like a template. It is commonly used in web applications to provide a demonstration of what the actual .env should look like. It poses a security risk if a .env file is committed to version control, it can expose private keys and database access credentials. I hope this helps!


SW-2123: Responsive Page Layouts -> Onboarding

This PR updates a fill color in the "blobby" icons from blue to green.
This PR supports this PR in terraware-web.
Screenshots
AFTER

BEFORE

I didn't realize assets was the source and I needed to run yarn generate-assets, thanks for pointing that out @karthikbtf 🙌


MINOR: Cleanup for #11513

Clean up some minor things that were left over from PR https://github.com/apache/kafka/pull/11513
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Failures were unrelated:
    Build / JDK 11 and Scala 2.13 / kafka.admin.LeaderElectionCommandTest.[1] Type=Raft, Name=testElectionResultOutput, Security=PLAINTEXT
    Build / JDK 17 and Scala 2.13 / kafka.admin.LeaderElectionCommandTest.[1] Type=Raft, Name=testPathToJsonFile, Security=PLAINTEXT
    Build / JDK 17 and Scala 2.13 / kafka.admin.LeaderElectionCommandTest.[1] Type=Raft, Name=testPathToJsonFile, Security=PLAINTEXT
    Build / JDK 17 and Scala 2.13 / org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldRemoveNamedTopologyToRunningApplicationWithMultipleNodesAndResetsOffsets


Add per epoch config stress tests

Description
Add a test that starts two threads, one that keeps mutating the denylist, one keeps executing transactions.
Make sure there is no fork.
Test plan
CI

Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

[ ] Protocol:
[ ] Nodes (Validators and Full nodes):
[ ] Indexer:
[ ] JSON-RPC:
[ ] GraphQL:
[ ] CLI:
[ ] Rust SDK:

Approved
On Friday, June 28, 2024, Xun Li @.***> wrote:

@.**** commented on this pull request.
In crates/sui-e2e-tests/tests/per_epoch_config_stress_tests.rs
https://github.com/MystenLabs/sui/pull/18445#discussion_r1657911211:

+// SPDX-License-Identifier: Apache-2.0

+use move_core_types::language_storage::TypeTag;
+use rand::random;
+use std::path::PathBuf;
+use std::sync::Arc;
+use sui_json_rpc_types::SuiTransactionBlockEffectsAPI;
+use sui_macros::sim_test;
+use sui_types::base_types::{EpochId, ObjectID, ObjectRef, SuiAddress};
+use sui_types::transaction::{CallArg, ObjectArg};
+use sui_types::{SUI_DENY_LIST_OBJECT_ID, SUI_FRAMEWORK_PACKAGE_ID};
+use test_cluster::{TestCluster, TestClusterBuilder};
+
+const DENY_ADDRESS: SuiAddress = SuiAddress::ZERO;
+
+#[ignore]
Because the Move APIs are not public callable yet.
—
Reply to this email directly, view it on GitHub
https://github.com/MystenLabs/sui/pull/18445#discussion_r1657911211, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A66IW47YGOOPUDWH6ZSC4ULZJSMCZAVCNFSM6AAAAABKAPBZGCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNBWGY3TINRQGA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

No, just working on addressing all the feedback

No, just working on addressing all the feedback

LGTM, but I'll leave for @mystenmark to stamp


Cygwin reports ps: unknown option -- o for wildcard completion

Checklist

[X] I have read through the manual page (man fzf)
[X] I have searched through the existing issues
[X] For bug reports, I have checked if the bug is reproducible in the latest version of fzf

Output of fzf --version
0.53.0 (c4a9ccd)
OS

[ ] Linux
[ ] macOS
[X] Windows
[ ] Etc.

Shell

[X] bash
[X] zsh
[ ] fish

Problem / Steps to reproduce
When trying to complete command using kill -9 ** and pressing TAB i get the following error
kill **ps: unknown option -- o

This seems to be caused by incompatibility / lack of the -o feature in ps command. For context I use Windows Cygiwin and I tried with bot bash and zsh. The output of ps --help is the following:
Usage: ps [-aefls] [-u UID] [-p PID]

Report process status

 -a, --all       show processes of all users
 -e, --everyone  show processes of all users
 -f, --full      show process uids, ppids
 -h, --help      output usage information and exit
 -l, --long      show process uids, ppids, pgids, winpids
 -p, --process   show information for specified PID
 -s, --summary   show process summary
 -u, --user      list processes owned by UID
 -V, --version   output version information and exit
 -W, --windows   show windows as well as cygwin processes

With no options, ps outputs the long format by default

Are you planning to add support for such case (eg. fallback some combination of ps -p $$ and awk command)?

I get the same error on the MSYS2

I think the issue with those is that cygwin version of ps does not support -o option (and it seems that msys2 also uses the same ps binary)

I should specify that most of the functionalities of fzf work fine this is specifically competition of kill command.

Also WSL does not really meet my needs and this issue is not dealbreaker for me, I will just keep using fzf for ctrl+R reverse search.

I can confirm that the issue happens in bash from git for windows as well (which I understand it is based on MSYS2). It uses the same ps as cygwin:
ps --version
ps (cygwin) 3.4.10
Show process statistics
Copyright (C) 1996 - 2024 Cygwin Authors
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

We already use an alternative ps command for BusyBox. Similarly, we can add another fallback command for Cygwin. Interested in opening a pull request?
https://github.com/junegunn/fzf/blob/4e85f72f0ee237bef7a1617e0cf8c811a4091d72/shell/completion.bash#L410-L415
https://github.com/junegunn/fzf/blob/4e85f72f0ee237bef7a1617e0cf8c811a4091d72/shell/completion.zsh#L300-L305

From a quick test I can see that using the options -ef gives an output similar closer to the -eo.
$ ps -ef
     UID     PID    PPID  TTY        STIME COMMAND
    user    2140       1 cons1    01:50:49 /usr/bin/bash
    user     903       1 cons0      Aug  1 /usr/bin/zsh
    user    2256     903 cons0    02:09:34 /usr/bin/ps
    ...

It also has an option -W to include all windows processes not only cygwin's (probably better for windows users).
$ ps -efW
     UID     PID    PPID  TTY        STIME COMMAND
    user    2140       1 cons1    01:50:49 /usr/bin/bash
    user     903       1 cons0      Aug  1 /usr/bin/zsh
    user    2256     903 cons0    02:09:34 /usr/bin/ps
       0   66412       0 ?          Jul 29 C:\Windows\System32\smss.exe
       0   67452       0 ?          Jul 29 C:\Windows\System32\svchost.exe
    ...

I can open a PR tomorrow if this is fine.


Recompute wall profiler sampling interval

The effective sampling interval of wall profiler is larger than the requested one. Eg. when requesting a 99Hz sampling rate (~10.1ms sampling interval), we observe an average sampling interval of ~12.5ms. This discrepancy leads to an underestimation of CPU consumption since samplesare weighted by the samping interval. To fix this discrepancy we recompute the average samping interval from profile duration and total number of hits, since profile duration should be #hits x mean interval.

Looks reasonable, though I would also recommend looking at if you can make use of the GetStartTime(), GetEndTime(), and GetSampleTimestamp() methods on the cpu profile. That could provide greater accuracy.
See: https://v8docs.nodesource.com/node-12.19/db/d79/classv8_1_1_cpu_profile.html

Hum, I should already be using GetStartTime / GetEndTime through prof.start/endTime, as for GetSampleTimestamp, I believe it's available only if samples are recorded, and I fear enabling sample recording will add some overhead to the profiler.
The correction I apply is not exactly the right one for each sample since I don't have the timestamps, but at least on average it should be good.

Yep, it would have some additional overhead but would be more correct. Just a question of if the improved correctness is worth the overhead. And I meant that GetSampleTimestamp is relative to GetStartTime and GetEndTime so you use them together.