MudTable: Using Record, row click changes value of "Name" property to: "Changed"

Bug type
Component
Component name
MudTable
What happened?
After the table is loaded and clicking on a row, modifies the value of the "Name" property to: "Changed"
The error can be reprocuded using the Records doc example.
Expected behavior
The value of the Name property must not change.
Reproduction link
https://try.mudblazor.com/snippet/7VZLb9s4EL77T2RA7EEGsnJ66CWWVLfepHHROMHat6IoaIlwuEuTWpJK7Bj-7x1KlCL51b3tZY3AUOb5zcw3Y_34cU-5DDV9VfpiVBgulzDbGMtW4ZTZ8M7aPPxilOx1dXO2tqU8nDHNqeCv1HIlh7XZfZF9Ei5meLOmq1wwE_5BLQ3vVcaE6Y24_IulFlz4seBMWnhqHnu9CN3ndCEYTDCZicnoRrAVqgzByMLyGRPojgljYnXBCMxj4k0IVEqWlb7jJyqXLIvJgzwmJzBWq5xqpmNSP5GkB_iJ7hjNmB4raTFsJSvlDtxTMtXRoHra18z4Up7STemKndI9KsNdTaf090pQDStqTMciGhwBGv2pXuYMG08t2wuUgZvEV7pgIiZTrHaUOk-c57RYLZgvKzvn5Sps-b0VfNbL1d7O1rTirFfdlZZnt1Fnvd961vIvhR3naHDQr-iRLk9N31GzVIP7nvFX9pA7QMhUyV6AS_vt-_b91SW8u7raERjUSQ5DRrdK2VNpMkiVMDlFlr8nSUVf-CjEHvS9EJXWQUz8JmHNMJGCS-bXJalXAbjbhWsYBaa9HO_iWBZCwAcgBK7BWI07HX5RXAbkEvCvax0-aOTfp02wjpN1yYZ-WGVoSfr9ChiCQVw4i4zBtqwg1_wZ2w531DzNmI38Iid7WSAG19x9q6A_7HXCfOWmFaM-HN67ozxw9Yr6EDS3oXI-MH9WPIPjdyU4KIZ5IP0yxLaZdC0Pb7k2NuiXe4EJSX2hhqXprk6Nsy4np56Z1hybSM1GpjCn5m_EMpG4Ge4cs-yjkwf76Vr9oC-Ut-9u-JnZW61W7qyXzlGnW0lAXtiC5nyQ48lXGU-tIxnpdwCmAnftoJHXMLn5p0BcdlPLmrh7APNiIXgKC6UElD4m8JZAL-vAsOhDnAD94G8WxDEs6n-G-7FwHwFrcyMZI-2aeOsySC0OEdkCdyRY14G6lflgmqVKZzWQ4-CrhYHPWhU5bGHJ7BDJjF-7Y9Dqc3be0scs2fHLkL4rXbvG8Jub8KNWOEe7cQEDYlZUCNL_fiKr2-DzWTNVuN_r6t6etZyUrOJ-OVOr8W6eQupdGq57OHM1Kx-CcoC_ka3Dt4PfYeuq2TUrs7vwYwpTc9F5fxkr4d8gDNJeIqHTYe_fveH0JObAq5yyX73lbNu86SzG_7T5b2nTWL7NwH00s4WWJwlVkcpT6yc
Reproduction steps
TryMB, click rows
Relevant log output
![image](https://user-images.githubusercontent.com/10358198/206927929-441ca681-1b1b-4f51-9c08-bbe498a1969f.png)

Version (bug)
6.1.5
Version (working)
No response
What browsers are you seeing the problem on?
Firefox, Microsoft Edge
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

The culprit:

This was an example to demonstrate that the record equality was being overridden by the Comparer @Yomodo. Changing the Name to "Changed" would otherwise break the table as it would think it was a different object (which is correct record behavior, but problematic for the table).

If you have an idea for a better way to demonstrate this, let me know. 😄 This one was quick and dirty.

@Mr-Technician Yeah, I later realized that. I'll close this.


Add support for creating elasticsearch mappings

Currently we don't explicitly set elasticsearch mapping when loading data into elasticsearch from snowplow. Instead we rely on elasticsearch to infer the mapping (schema) for us.
That's a shame because we know the schema, so should be able to explicitly set mapping and avoid failures due to elasticsearch incorrectly mapping fields.
To do this we'd need schema-guru to generate elasticsearch mappings, just as it generates redshift ddls today.

This would be awesome!

Here's an example where elasticsearch gets it wrong:
                  "type": "string"
               }```

This means you can't due numeric aggregations on the structured event value.

Migrated to https://github.com/snowplow/iglu/issues/239


Version 0.3

Reference Issues/PRs
#28 #29 #30
What does this implement/fix? Explain your changes.
Version 0.3
Any other comments?

@sadrasabouri Hi
Please complete this review until Wednesday - 2021-02-03 - 11:59 AM GMT+3:30
Notice: Only review, don't need to merge

@sadrasabouri Hi
Please complete this review until Wednesday - 2021-02-03 - 11:59 AM GMT+3:30
Notice: Only review, don't need to merge


Location NER Tagging

Want to contribute to DeepPavlov? Please read the contributing guideline first.
What problem are we trying to solve?:
I am new to deeppavalov framework, can we have an ner which can identify cities and states instead of just location. I mean having custom tags for entities

How can we solve it?:

Are there other issues that block this solution?:

@shamil-kadavan you can always get the specific location type by using vocabularies of cities and states.


Wifi is not working for Intel NUC 11 (NUC11ATKC4)

An Intel NUC 11 (NUC11ATKC4) wifi is not working. These messages are in the dmesg logs:
[ 2.231554] iwlwifi 0000:00:14.3: no suitable firmware found!
[ 2.231567] iwlwifi 0000:00:14.3: minimum version required: iwlwifi-QuZ-a0-jf-b0-39
[ 2.231569] iwlwifi 0000:00:14.3: maximum version supported: iwlwifi-QuZ-a0-jf-b0-59
[ 2.231571] iwlwifi 0000:00:14.3: check git://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git

WiFi seems to be working on NUC 11 with genericx86-64-ext.

We have merged the support for wifi6 adapters recently but apparently some 11th gen NUCs with a wifi5 Intel Wireless-AC 9462.

This support was added in v2.98.15.


[Feature request] Regex support for package exlusions

If you want to exclude packages with a common pattern, you currently have to list all packages you want to exclude. With regex support, you could specify a single regex to exclude many packages.
Example config.json
{
  "exclude": [
<EMAIL_ADDRESS>  ]
}

I could imagine that the use case is quite common, so this would be a good new feature for license-report.
As a solution I would prefer the "excludeRegex" variant, as this would not break any current installations.
Do you have the time to create a PR for this?

I could imagine that the use case is quite common, so this would be a good new feature for license-report.
As a solution I would prefer the "excludeRegex" variant, as this would not break any current installations. Do you have the time to create a PR for this?

Great! I will try to find some time!

I had some time to play around with this feature and created a pull request (#144).
Instead of an array of regular expressions, I used a single one, as this simplified the code. If more than one 'group of packages' is to be excluded this way, the regular expression must simply account for these 'groups'.
If you want, you can throw a look at the modifications before I merge the pr.

solved by pr #144


Update metadata records for qualified members

Allow EnclosingType of QualifiedMethod be a TypeSpecification.
This is to allow QualifiedMethod to represent situations where ECMA
format uses a MemberRef.
Introduce QualifiedField that mirrors what QualifiedMethod does,
but for fields.

@davidwrighton PTAL
Cc @trylek

@davidwrighton Now that I think about it, would the expectation of a consumer be that the Method record referenced from QualifiedMethod has it's signature already instantiated according to how the containing type is instantiated? If so, I would suggest we give up on trying to optimize this and simply emit a MemberReference (whose parent is a definition) and eat the cost of having to resolve the name and sig at runtime.
I would revert the change to QualifiedMethod and introduce a QualifiedField that mirrors the old definition of QualifiedMethod.

Let's wait and see what will be necessary.


Vue toasted can't  warning style

https://github.com/shakee93/vue-toasted

https://github.com/CoreProc/nova-notification-feed/blob/3d60e06d0c5bf2a973a782cf881cbf6c43a640b1/resources/js/components/NotificationMessage.vue#L13


Shopping cart

Added one or two notes, but this looks good. Nice job. First one especially communicates requirements well.


[BROKEN] Can't insert data after lastest update

After the last update the auotmatic data not does not work and i can't submit a new flight, related maybe with #129

ops... checking it

should be fixed now, new release is published


IterAll should use most aggressive read-ahead.

Is "most aggressive read-ahead" defined anywhere?

I think it is now LoadLeafSequences. Ping me if you want to discuss further.

As in adapt the blob loading code? Will ping you when I'm ready to start.

Yup.

I think the approach here would be to basically mimic Blob.Copy. The main rub here is knowing how many items to read ahead by. I'd be tempted to have a fixed initial estimate of items/leafSequence (this could be a const to begin with, but eventually based on the Type). As read-ahead takes place, you can update the estimate of values/leafSequence based on what was recently observed.

This is done for List. We still need to do it for Set and Leaf.

done in https://github.com/attic-labs/noms/pull/3761


Crash test was failed

http://helios.orientdb.com/view/develop/job/orientdb-develop-crash-tests/lastCompletedBuild/com.orientechnologies$orientdb-server/testReport/com.orientechnologies.orient.core.storage.impl.local.paginated/LocalPaginatedStorageSmallCacheBigRecordsCrashRestoreIT/testDocumentCreation/

Hi Andrey, I just pushed LocalPaginatedStorageSmallCacheBigRecordsCrashRestoreIT with few modification to be able to debug: single thread AND timeout is 1 minute.
The test fails on the first record compared. I added output to show the two documents stored on base and test DBs, and apart for the id, other fields are completely different. Let me know If I can do more to fix this tests. Thanks

Hi Roberto,
We will take care of it.

Fixed for now. But I will create set of issues for few specific tests for 3.0 version.


Missing request property in ListView payload.find calls

Link to reproduction
No response
Payload Version
3.0.0-beta.56
Node Version
20.10.0
Next.js Version
15.0.0-rc.0
Describe the Bug
I'm building a multitenant CMS with PayloadCMS. To restrict the data being shown by an user, I'm checking the request host in the access control functions of the collections.
For ListView component, the host is fake due to the attachFakeURLProperties method, so when the access control function is being called for this request, it is always getting localhost and I can't check the host properly. Returning false in the access control for this use case just breaks the view with an exception about permissions.
I think the request property should be passed from the iniPageResult object to both payload.find calls but I'm not sure about the side-effects it could have as I'm not an expert on React/Next.js or PayloadCMS core.
https://github.com/payloadcms/payload/blob/ef21182eac6aac9bf52c9c0777bea93d8add743d/packages/next/src/views/List/index.tsx#L103-L115
https://github.com/payloadcms/payload/blob/ef21182eac6aac9bf52c9c0777bea93d8add743d/packages/next/src/views/List/index.tsx#L51-L63
If I add the request property to both calls as described, the view starts working properly, receiving the host and being able to filter the data based on it.
UPDATE:
It is happening also in the Edit view of a collection item. In this case, adding the request object in the calls of the buildFormState function, fix the issue for the Edit view.
Reproduction Steps

Configure a host in /etc/hosts (or wherever depending on your OS) with a fake domain poniting to <IP_ADDRESS>
Create a read access control function for a collection:

export const readTest: Access = async ({ req }) => {
  const host = req.headers.get('X-Forwarded-Host') || req.host;
  console.info('readTest', host, req.url); // It should print "localhost" for ListView calls
  return true;
}

export const Tenants: CollectionConfig = {
  slug: 'tenants',
  access: {
    read: readTest,
  },
  ...

Access with this domain to the admin panel and load the collection list view

Adapters and Plugins
No response

@wishrd this was fixed in 3.0.0-beta.58


Updated test step for ATE port-2 and DUT port-2 config with subinterface indices

Updated test step for ATE port-2 and DUT port-2 config with subinterface indices. This is duplicate of PR#1086. Raised this PR as 1086 is having CLA issue.

Based on approval on pull/1086, I am approving this one too

/gcbrun


Core-Command: Correlation-ID not propagated when issuing command

The core-command service invokes commands on a remote addressable using a native http client.
https://github.com/edgexfoundry/edgex-go/blob/65d9a2a4033eb83af861f200106da1aaea6cff03/internal/core/command/device.go#L26
The correlation-id HTTP header is not being passed when these calls are made. The issueCommand function needs to have a Context passed into it from which a correlation-id can be obtained and set on the request. Callers to issueCommand need to be updated to provide the Context.

@tsconn23 , I am thinking about creating a unit test to cover this newly added functionality. Is this OK or is that getting too granular?

@AnthonyMBonafide We need more tests, not less.
You're doing the best work.

@AnthonyMBonafide Go for it

Opened PR #1240


Add files to allow playing in Sonic Pi

You may care to add these two files. The python script produces an output data file in .json format from a named piece in the songs.py file.
The Sonic Pi file (which runs in Sonic Pi!) extracts the frequency and duration data from the .json file and then plays the ringtone.
There is a recording of three of them produced using these files at https://soundcloud.com/user-195236670/ringtones

Thanks for the contribution.
Since your files aren't directly related to Micropython, I put them together into a subdirectory called sonic_py.
You may want to write up a little README.md file that goes along with them.
Merged n 6aca88ba77f184f88e0100dadb060c035071ac8b


Collect all markdown files from a certain directory

This should work recursively
Other files should not be collected
List the files for later processing

Pushed. Maybe someone with more experience could review, I have the feeling this is everything but optimal ;)

Alright, I can do a review tomorrow and we can talk about the current implementation during the meeting. Thank you for contributing!


ARXIVNG-1041 ARXIVNG-1061 Progress bar style

Made some changes to the macro code and CSS, now our progress bar looks prettier!
I am not tied to having the labels on the bottom, but they're a handy reference for us (for now). "Confirmed" is not a step that is intended to be on the progress bar during production, but I left it in the nav so that we can access that page (without having to remember the route name).
Bar automatically hides for mobile and is labeled for accessibility.
showing active 4th step with 5th step completed (user has backed up):

hover on incomplete step, showing active 4th step and completed 5th step:

hover on complete step, showing active 4th step and completed 5th step:

NOTE: I wasn't able to test this for the actual submission process, and the "active" and "completed" states are hardcoded at this present moment.  To preview the bar, use the mock route /progress.

Pull Request Test Coverage Report for Build 257

2 of 5 (40.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 67.118%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

submit/routes/ui.py
2
5
40.0%

Totals

Change from base Build 254:
-0.1%

Covered Lines:
843

Relevant Lines:
1256

💛  - Coveralls


Command to compile Dockerfile.erb without build

I'm using docker-compose and from time to time I need to just compile the Dockerfile.erb so that I can use it with docker-compose without actually building the container. Is this possible with ufo?

Not currently. Will consider PRs for this.


desalinating, fibrilation

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.1
logical conflict every: 1000
sleep for: 2100s
close stale after: 24 hours
[pullrequest]
requests per hour: 100
deps=[d,f]

/trunk merge


Backend Updates

I'll be performing some backend updates to the pivpn.io site over the next couple of weeks.
Although i have no time to maintain the actual project, backend work i can do in my sleep so...
The ubuntu server it is hosted on will be upgraded to a newer LTS release, php version upgraded for security patches on the wordpress site, and I'll finally move it to https since github added this: https://github.blog/2018-05-01-github-pages-custom-domains-https/
I'll post updates here and close this once all is done.

Although i have no time to maintain the actual project,

so, the project is unmaintained?
what about asking for people willing to help for maintenance?

It is maintained, just not by @0-kaladin, see #675.

https://github.com/pivpn/pivpn/issues/236
closing this one! @0-kaladin do you need any assistance with this?
please get in touch with me if so, maybe i can certainly host this on my servers if you don't have the time to keep the website as well.


Changes to add a team to assign page

Need an actual API to load teams

Please dicard this PR, I made a new one https://github.com/dmwm/WMCore/pull/6681


vue3-multiselect files are being referenced/packages, when it should just be vue-multiselect

Mentioned in #1527

Fixed and launched on v3.0.0-beta.2


unable to delete network after deletion of containers. / no command to delete/detach endpoint

This bug I faced with experimental build 1.8.0-dev.

I created a container with publishing a service myapp and network mydomain.
After that I killed the container and tried to delete the network mydomain.
But I am not able to delete network, since an active endpoint is attached to it.
How to delete or detach the network with endpoint?
I think some command is not exposed to UI.
Below is details of docker and commands I executed.
 ✘  kunal@kunal-XPS-L421X  ~  docker run -it --publish-service=myapp.mydomain ubuntu /bin/bash
root@4a911191e3dd:/# exit
exit
 ✘  kunal@kunal-XPS-L421X  ~  docker network ls
NETWORK ID          NAME                TYPE
ac4b44804a92        none                null
2549d95b995a        host                host
93cb96a431e8        bridge              bridge
d7f5fbc88156        mydomain          bridge

docker network rm overlay
Error response from daemon: network with name mydomain id d7f5fbc88156cdedfc38b5d2531fd5b6ab6b0778f64edddfd10445fd48731f55 has active endpoints

 kunal@kunal-XPS-L421X  ~  docker rm 4a911191e3dd
4a911191e3dd

 kunal@kunal-XPS-L421X  ~  docker network rm mydomain
Error response from daemon: network with name mydomain id d7f5fbc88156cdedfc38b5d2531fd5b6ab6b0778f64edddfd10445fd48731f55 has active endpoints

 kunal@kunal-XPS-L421X  ~  docker ps
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS              PORTS               NAMES

 ✘  kunal@kunal-XPS-L421X  ~  docker version
Client version: 1.8.0-dev
Client API version: 1.20
Go version (client): go1.4.2
Git commit (client): f39b9a0
OS/Arch (client): linux/amd64
Experimental (client): true
Server version: 1.8.0-dev
Server API version: 1.20
Go version (server): go1.4.2
Git commit (server): f39b9a0
OS/Arch (server): linux/amd64
Experimental (server): true

@kunalkushwaha when you run a container with --publish-service option, the service that you publish myapp remains as part of mydomain even after the container is gone. This is because one could attach another container behind the same service which will inherit all the service properties.
If you are done using the service, use the command docker service unpublish myapp.mydomain to unpublish the service and then you should be able to docker network rm mydomain.

thanks @mavenugo , It fixes the issue :)

Closing it too.


Add search mechanism in the doc

Add Algolia DocSearch in the Doc
Refs: https://www.algolia.com/developers/code-exchange/integrate-docusaurus-with-algolia-docsearch/

Issue completed in the PR #15


ember-apollo places real money orders

I was just trying the ember-apollo out.
I set it up locally on my machine and went through the checkout process to see how it works.
By the end of it I was very surprised to see that I had actually ordered a pair of boots for 190CAD.
The money was transferred out of my bank account.
Can we put the API or payment integration into some kind of sandbox/test mode by default?
Cheers

The payment integration is on test mode, but the paypal gateway got added at some point. It's been disabled. Sorry this happened, but it looks like the funds have been returned.


Setting enforce TLS 1.2 to True has failed

VERBOSE: Setting enforce TLS 1.2 to True has failed with exception Method invocation failed because [System.Xml.XPathNodeList] does not contain a method named 'SetAttribute'.
VERBOSE: Enforcing TLS 1.2 has raised an exception: Method invocation failed because [System.Xml.XPathNodeList] does not contain a method named 'SetAttribute'.
VERBOSE: Verifying TLS policy
VERBOSE: Get GPO TLS protocols registry 'enabled' values
VERBOSE: GPO TLS applied with the following preferences:
VERBOSE:     TLS protocol SSL 2.0 enabled value: 0
VERBOSE:     TLS protocol SSL 3.0 enabled value: 0
VERBOSE:     TLS protocol TLS 1.0 enabled value: 1
VERBOSE:     TLS protocol TLS 1.1 enabled value: 1
VERBOSE:     TLS protocol TLS 1.2 enabled value: 1
VERBOSE: TLS 1.2 is not enforced
VERBOSE: Restoring TLS policy ECE info. Setting TLS policy back to TLS_All
VERBOSE: Setting enforce TLS 1.2 to False has failed with exception Method invocation failed because [System.Xml.XPathNodeList] does not contain a method named 'SetAttribute'.
Any ideas... or raise a support request with MS ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8a6c4029-7e45-9b19-db5c-76311d37ae76
Version Independent ID: 831086f5-f1ad-7fb8-fdc4-de9929c8b6fa
Content: Configure Azure Stack security controls
Content Source: azure-stack/operator/azure-stack-security-configuration.md
Service: azure-stack
GitHub Login: @PatAltimore
Microsoft Alias: patricka

@LinoRS Make sure that your Azure PowerShell and Azure Stack are up to date with the latest patch and try again. If that does not work and you are doing this on an Azure Stack Integrated System (Not the ASDK), your best bet is to go through support.

@TravisCragg-MSFT, thank you.... i have used HLH and connected to PEP from my local PC, Same error occurs,
Azure Stack is on version 1906, which is supported in doing this in this version.
Powershell is using  version "Script     2.5.0      AzureRM" / "Script     1.7.2      AzureStack"  thanks.... so might then log a call to support to see whats going on.

@LinoRS We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.
If you get the chance, please update this thread with the resolution.

MS has identified this as a bug and they now also know the cause. Seem PG is currently working on the mitigation.

So Steps from MS
If you an early adopter and have upgraded Stack the issue came from other builds, however if you just installed stack and on build 1904 and upgrade to 1906 you will be fine. In my case not. So you need to break glass with MS, then Run the following mitigation:
Import-Module -Name ECEClient -Verbose:$false -DisableNameChecking
$eceClient = Create-ECEClientWithServiceResolver
$eceXml = XML
$tls12EnforcedNode = $eceXml.SelectNodes("//Parameter[@Name='TLS12Enforced']")
if (($null -eq $tls12EnforcedNode) -or ($tls12EnforcedNode.Count -eq 0))
{
Write-Verbose -Verbose "Persistent reference TLS12Enforced is not present, creating it"
$domainCategory = $eceXml.SelectSingleNode("//Category[@Name='Domain']")
$tls12ParamNode = $eceXml.CreateElement("Parameter")
$tls12ParamNode.SetAttribute("Name", "TLS12Enforced")
$tls12ParamNode.SetAttribute("Type", "bool")
$tls12ParamNode.SetAttribute("Value", $false)
$tls12ParamNode.SetAttribute("AllowedValues", "")
$tls12ParamNode.SetAttribute("Reference", "[{TLS12Enforced}]")
$domainCategory.AppendChild($tls12ParamNode) | Out-Null
$eceCloudParametersDefinition = New-Object Microsoft.AzureStack.Solution.Deploy.EnterpriseCloudEngine.Controllers.Models.CloudDefinitionDescription
$eceCloudParametersDefinition.ConfigurationName = 'AzureStack'
$eceCloudParametersDefinition.CloudDefinitionAsXmlString = $eceXml.OuterXml
$null = $eceClient.ImportCloudParameters($eceCloudParametersDefinition).GetAwaiter().GetResult()
Write-Verbose -Verbose "Persistent reference TLS12Enforced is now created"

}
Then once done, close your Admin session.
and you should now be able to run the Set-TLSPolicy -Version TLS_1.2... has worked for me.
So anyone that is having the same issue, hope this helps you.
thanks


Vector representation of a document

How can I let Tantivy to produce a vector representation of a document, i.e. a vector of e.g. TF-IDF scores for every term in the index of a given document?

The document vector is very useful for downstream applications, such as text classification.


README seems very out-of-date

Probably need to rewrite it, especially because of bundling strategies etc.

@usergenic I have a bunch of writing to do next week, I can add this to the list. If I get in a non-code flow I can probably get through it quickly.

I did rewrite a lot of the README already, and its much better than when I created the issue, and if I don't close this now it will just keep staring at me and making me feel bad until the README is perfect which it won't be.


SPIKE #6: Unit Tests React

AC:

[ ] Research and compare libraries for Unit Test
[ ] Presentation
[ ] WikiPage
[ ] Code coverage plugin for GitHub

Useful links:
https://reactjs.org/docs/testing.html
https://jestjs.io/docs/en/tutorial-react
https://testing-library.com/docs/react-testing-library/example-intro/

Code coverage plugin for GitHub - start with researching how to get a code coverage i.e. from the CLI.
@KarkabsisV do we need to integrate the coverage with the github ? and what's out motivation in this case?


Prepare Project for Update and Deployment

Ensure that necessary files are generated for the npm package and that the site builds correctly before finalizing the update.
Step-by-Step Guide

Execute yarn changeset again
Execute yarn build again

🦋  Which packages would you like to include?
✔  @your-scope/your-package
🦋  Which type of change are you making?
✔  Major change (breaking change)
✔  Minor change (new feature, no breaking change)
✔  Patch change (bug fix, no breaking change)
🦋  Describe your changes (this will be in the changelog):
✔  Your change description here


feat: apply OSSF suggestions

This is exactly what renovatebot is doing. Do we need drpendsbot also?


The difference and connection between _grounded_proposal and _ungrounded_proposal

Hi, thank you for your wonderful work! Can I ask about the difference and connection between _grounded_proposal and _ungrounded_proposal?

I have the same question 👍

Thanks for the kind words!
The difference is just whether heads have sequential dependence, so grounded == sequential dependence, ungrounded == no sequential dependence. So doing grounded is what Hydra proposes and ungrounded is the original Meudsa work essentially.
Ungrounded proposals are also only supported for MLP Head and not PrefixMLP. I would recommend doing grounded proposals for the speed boost Hydra gives 😁

Thanks for the kind words!
The difference is just whether heads have sequential dependence, so grounded == sequential dependence, ungrounded == no sequential dependence. So doing grounded is what Hydra proposes and ungrounded is the original Meudsa work essentially.
Ungrounded proposals are also only supported for MLP Head and not PrefixMLP. I would recommend doing grounded proposals for the speed boost Hydra gives 😁

I see, thanks for your response

@zankner  Sorry I have another question. In your repo, hydra choices 'mc_sim_7b_63' is the same to medusa's? or you use another dataset to calculate for a better sparse tree structure? Do you think we should do that or just follow medusa's. Thanks!

Yeah thats the same as Medusa's choices. We have done some work to calculate the optimal trees and will update the repo with it once finishes, but in the batch size 1 case it doesn't make much of a difference so I would recommend just sticking with medusa choices for now.


"Unsupported filesystem type: module"

This might just be a problem of "wrong error message", but currently I'm seeing this in the startup log.
Warning: Failed to mount '/spark-local/Untitled Workspace 10.slam/.tmp/outc2ee99b4-af3f-476c-ae19-b73e3fd095ec/' because 'Invalid mount config, '[module] CREATE FUNCTION cardc2ee99b4af3f476cae19b73e3fd095ec(:fieldName)
  BEGIN
    foo := lat; (select ((t).coords)[0] as lat, ((t).coords)[1] as lon, (t).location from `/spark-local/locations.json` as t order by :fieldName ASC)
  END', because: Unsupported filesystem type: module'.

(Yes I realise the query is gibberish :wink:)
This could be because spark-local isn't available via plugins yet, or the various #2813 issues (I'm trying on Windows). Thought I'd open an issue for it anyway in case it really is broken. I'll retry all this on a Mac next.

Does this happen with other backends, or just Spark Local?

This may be  https://github.com/quasar-analytics/quasar/issues/2370.

@djspiewak I don't think I have any other modules mounted right now, I'll try and rig something up to test it under a mongo mount and report back.
@alissapajer interesting, it could be - although it occurs whenever I try to start Quasar, so it's writing a corrupted metastore at least. Full startup log in case its of use:
Read web config from quasar\config.json
log4j:WARN No appenders could be found for logger (com.zaxxer.hikari.HikariConfig).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
Using metastore: jdbc:h2:C:\Users\Gary\AppData\Local\quasar\quasar-metastore.db
Warning: Failed to mount '/mongoq/' because 'Invalid mount config, '[mongodbq] mongodb://localhost:63174', because: Unsupported filesystem type: mongodbq'.
Warning: Failed to mount '/mongo/' because 'Invalid mount config, '[mongodb] mongodb://localhost:63174', because: Unsupported filesystem type: mongodb'.
Warning: Failed to mount '/spark-local/' because 'Invalid mount config, '[spark-local] /Home/Documents/Projects/quasar-test-starter/tmp/spark-local/', because: Unsupported filesystem type: spark-local'.
Warning: Failed to mount '/spark-local/Untitled Workspace 10.slam/.tmp/outc2ee99b4-af3f-476c-ae19-b73e3fd095ec/' because 'Invalid mount config, '[module] CREATE FUNCTION cardc2ee99b4af3f476cae19b73e3fd095ec(:fieldName)
  BEGIN
    foo := lat; (select ((t).coords)[0] as lat, ((t).coords)[1] as lon, (t).location from `/spark-local/locations.json` as t order by :fieldName ASC)
  END', because: Unsupported filesystem type: module'.
Server started listening on port 80
Press Enter to stop.

The mongoq mount in there hasn't worked for a while obviously, so I'm used to seeing that one!

@garyb What version are you using?
Also, we should really output the version to the console when starting the web server.

This was v24.0.15

@djspiewak this also failed for a module under mongo:
Warning: Failed to mount '/mongo/test/Untitled Workspace 8.slam/.tmp/out2d3a054d-31ca-444e-958c-f683b52900ac/' because 'Invalid mount config, '[module] CREATE FUNCTION card2d3a054d31ca444e958cf683b52900ac(:city)
  BEGIN
    (select * from `/mongo/test/smallZips` where ((city) = (:city)))
  END', because: Unsupported filesystem type: module'.

Again though, this is without a mongo plugin either due to #2813. I'll see what happens on my Mac now.

Ok, I've run this on my Mac now, with the mongo connector and everything mounted, and it still raises the error on startup:
Warning: Failed to mount '/mongo/test/Untitled Workspace.slam/.tmp/out0abed8ac-2b29-43c4-a1ba-8f942e5219dc/' because 'Invalid mount config, '[module] CREATE FUNCTION card0abed8ac2b2943c4a1ba8f942e5219dc(:city)
  BEGIN
    (select * from `/mongo/test/smallZips` where ((city) = (:city)))
  END', because: Unsupported filesystem type: module'.

But, the module is still actually there if I go and look in the filesystem after restarting Quasar.
Initially I tried this by running and older Quasar first and then upgrading. After I saw the error occurred there I deleted my metastore, and started completely fresh with the v24.0.15 release, set it all up again, and indeed the error still occurs.
So at least it's not quite as bad as it appears, since the module mount is actually working, it's just odd that the error is printed during startup.

This is a duplicate of #2282


[Suggestion] Variable fuel consumption based on planet gravity and orbital distance

Or: make landing on big planets more fuel expensive to encourage the use of advanced engines

I'll have to implement some kind of warning system to make sure players don't go to planets and get stranded too.

They can start a new life and make rocket fuel there muhahahah


Create script doesn't respect dependency order

The script cannot be run with a single command because the order of the Create statements doen's respect the FKs dependency.
Also, the drop statements should be ordered reversly to comply with the FXs dependency.

start the script with PRAGMA foreign_keys=off;
end the script with PRAGMA foreign_keys=on;
you may also move all the drops to the top of the script


Improve the fabricated test method code

The fabircated test methods are these little lamdba expressions.
The param to the lamdba is just a reference to what is effectively
'self'. So replace the *args syntz with a simple 'my_self' param,
and then in the lamdba contruct the 1-tuple as needed.

Verified that @potrebic has signed the CLA. Thanks for the pull request!

I'm going to self approve this minor change.


Support for FP8 quantization with TensorRT-LLM

DJL does not support (or has not documented support) for FP8 quantization (docs).
FP8 is currently TensorRT-LLM's recommended quantization technique, with the lowest performance degradation with good speedup.
It would be great to support this in DJL. It should not affect any APIs other than adding options (I expect adding option.quantization=fp8).
Any users seeking a speedup or lower memory footprint would benefit from this change.
Note
This does contradict an AWS blogpost but I expect this is an inaccuracy.

as part of the latest LMI DLC release (0.25.0), enabling state-of-the-art optimizations like SmoothQuant, FP8, and continuous batching

Hi Nathan, for FP8 quantization, there are two currently offered choices - SmoothQuant and AWQ.
For SmoothQuant for example, to enable FP8 smoothquant, the options you can add are
option.quantize = smoothquant
option.smoothquant_alpha = 0.8
option.smoothquant_per_channel = true
option.smoothquant_per_token = true
option.dtype = fp8

Ah thanks @ydm-amazon - I was aware of both, but am concerned about the quality difference in the model outputs given the reported MMLU decrease of SmoothQuant versus the "native" FP8. TGI recently added fp8 but indicate it only works on Hopper architecture onward. I suppose because it's the first architecture that natively supports fp8 operations.
Couple of follow-up questions:

Are there still plans to support this "native" fp8 mentioned in TRT-LLM and recently added to TGI?
Can you confirm that when using smoothquant that dtype should be set to fp8? The examples in the DJL docs seem to keep option.dtype = fp16 when using both smoothquant and awq.
I'm not sure smoothquant, but I believe AWQ requires calibration, and there are two option. parameters regarding calibration. Which dataset is used as the calibration set for calibrated quantization methods if we use JIT engine compilation? Is it possible to pack a calibration dataset with model files for JIT AWQ compilation if needed?


many sync C++ scenarios failing in json_run_localhost test run

In both:
aggregate_tests.run_tests_c++_linux_opt_native
aggregate_tests.run_tests_c++_linux_dbg_native
https://grpc-testing.appspot.com/job/gRPC_pull_requests_linux/4447/#showFailuresLink
c++_linux_dbg_native.bins/dbg/json_run_localhost --scenarios_json '{"scenarios": [{"name": "cpp_protobuf_sync_streaming_qps_unconstrained_1mps_insecure", "warmup_seconds": 0, "benchmark_seconds": 1, "num_servers": 1, "server_config": {"async_server_threads": 0, "security_params": null, "server_type": "SYNC_SERVER"}, "num_clients": 0, "client_config": {"client_type": "SYNC_CLIENT", "security_params": null, "payload_config": {"simple_params": {"resp_size": 0, "req_size": 0}}, "client_channels": 64, "async_client_threads": 0, "messages_per_stream": 1, "outstanding_rpcs_per_channel": 16, "rpc_type": "STREAMING", "load_params": {"closed_loop": {}}, "histogram_params": {"max_possible":<PHONE_NUMBER>0.0, "resolution": 0.01}}}]}' GRPC_POLL_STRATEGY=poll-cv (from grpc.c++_linux_dbg_native)

Failing for the past 1 build (Since Failed#4447 )
Took 1.3 sec.
Error Message

Failure
Standard Output

ting to localhost:1051
I0411 10:50:27.941322083    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.941943553    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.942520033    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.943131251    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.943712266    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.944264858    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.944828256    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.945401607    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.946024414    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.946582337    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.947193784    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.947754449    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.948350399    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.948938111    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.949502368    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.950059475    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.950675756    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.951228870    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.951827773    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.952376852    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.952968884    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.953560265    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.954125300    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.954759932    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.955360904    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.955957248    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.956518134    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.957128794    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.957745857    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.958360721    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.958971681    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.959609520    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.960181979    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.960798279    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.961413800    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.962028409    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.962637420    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.963198196    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.963761045    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.964316919    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.964887603    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.965484678    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.966081502    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.966687957    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.967331564    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.967912745    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.968534819    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.969159876    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.969738249    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.970315573    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.970913984    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.999249048    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:27.999909743    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:28.000537913    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:28.001222367    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:28.001786338    7362 client.h:416]               Connecting to localhost:1051
I0411 10:50:28.065615870    7362 qps_worker.cc:211]          RunClientBody: client created
I0411 10:50:28.065794662    7362 qps_worker.cc:216]          RunClientBody: creation status reported
I0411 10:50:28.065958385    7360 driver.cc:343]              Initiating
I0411 10:50:28.066153599    7362 qps_worker.cc:218]          RunClientBody: Message read
I0411 10:50:28.112127667    7362 qps_worker.cc:227]          RunClientBody: Mark response given
I0411 10:50:28.112398267    7360 driver.cc:364]              Warming up
I0411 10:50:28.112424325    7360 driver.cc:370]              Starting
I0411 10:50:28.112616526    7361 qps_worker.cc:263]          RunServerBody: Message read
I0411 10:50:28.113219507    7361 qps_worker.cc:272]          RunServerBody: Mark response given
I0411 10:50:28.155917097    7362 qps_worker.cc:218]          RunClientBody: Message read
I0411 10:50:28.176560574    7362 qps_worker.cc:227]          RunClientBody: Mark response given
I0411 10:50:28.176843905    7360 driver.cc:397]              Running
E0411 10:50:28.816086048   11057 ev_poll_posix.c:1428]       assertion failed: gpr_thd_new(&t_id, &run_poll, pargs, &opt)
E0411 10:50:28.816160397    8756 ev_poll_posix.c:1428]       assertion failed: gpr_thd_new(&t_id, &run_poll, pargs, &opt)
I0411 10:50:29.112620332    7360 driver.cc:411]              Finishing clients
E0411 10:50:29.112965672    7360 driver.cc:418]              Failed WritesDone for client 0
E0411 10:50:29.112986469    7360 driver.cc:436]              Couldn't get final status from client 0
E0411 10:50:29.113013089    7360 driver.cc:444]              Client 0 had an error OS Error
I0411 10:50:29.113136164    7360 driver.cc:457]              Finishing servers
E0411 10:50:29.113243011    7360 driver.cc:464]              Failed WritesDone for server 0
E0411 10:50:29.113258401    7360 driver.cc:477]              Couldn't get final status from server 0
E0411 10:50:29.113275755    7360 driver.cc:485]              Server 0 had an error OS Error
I0411 10:50:29.113577174    7360 report.cc:84]               QPS: -nan
I0411 10:50:29.113595403    7360 report.cc:94]               QPS: -nan (-nan/server core)
I0411 10:50:29.113626101    7360 report.cc:99]               Latencies (50/90/95/99/99.9%-ile): 0.0/0.0/0.0/0.0/0.0 us
I0411 10:50:29.113633707    7360 report.cc:109]              Server system time: -nan%
I0411 10:50:29.113639896    7360 report.cc:111]              Server user time:   -nan%
I0411 10:50:29.113646051    7360 report.cc:113]              Client system time: -nan%
I0411 10:50:29.113652054    7360 report.cc:115]              Client user time:   -nan%
I0411 10:50:29.113658640    7360 report.cc:120]              Server CPU usage: -nan%
I0411 10:50:29.114410931    7342 json_run_localhost.cc:82]   driver: subprocess exited with status 1
I0411 10:50:29.114465286    7342 json_run_localhost.cc:85]   worker: subprocess terminated with signal 6
I0411 10:50:29.114476207    7342 json_run_localhost.cc:85]   worker: subprocess terminated with signal 6
E0411 10:50:29.114481744    7342 json_run_localhost.cc:138]  assertion failed: driver_join_status == 0

It looks like this same failure occurred again on master: https://grpc-testing.appspot.com/job/gRPC_master_linux/2402/testReport/junit/(root)/c++_linux_opt_native/bins_opt_json_run_localhost___scenarios_json____scenarios______name____cpp_protobuf_sync_streaming_from_server_qps_unconstrained_insecure____warmup_seconds___0___benchmark_seconds___1___num_servers___1___server_config_____async_server_threads___0___security_params___null___server_type____SYNC_SERVER_____num_clients___0___client_config_____client_type____SYNC_CLIENT____security_params___null___payload_config_____simple_params_____resp_size___0___req_size___0_____client_channels___64___async_client_threads___0___outstanding_rpcs_per_channel___16___rpc_type____STREAMING_FROM_SERVER____load_params_____closed_loop_________histogram_params_____max_possible___60000000000_0___resolution___0_01_______GRPC_POLL_STRATEGY_poll/

superseded by #11970


Python server handler doesn't work on Ubuntu

Running server_handler.py (I suppose that's the right one) throws an exception (still renders, but doesn't seem to function at all):
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 810, in __bootstrap_inner
    self.run()
  File "/usr/lib/python2.7/threading.py", line 763, in run
    self.__target(*self.__args, **self.__kwargs)
  File "server_handler.py", line 26, in messageHandler
    op=subprocess.Popen(["node","server.js"],stdin=subprocess.PIPE,stdout=subprocess.PIPE,stderr=subprocess.PIPE,creationflags=createFlags)
  File "/usr/lib/python2.7/subprocess.py", line 675, in __init__
    raise ValueError("creationflags is only supported on Windows "
ValueError: creationflags is only supported on Windows platforms

If statement checks if os.name=="nt" (Winders)
Otherwise should be k

Alrighty then, looks like it's fixed now (commit 35e8af3dd11635877d8f164ff89a679247cc2ae9)


x/tools/go/packages: "-: cannot find package "nonexist" in any of: ..."

When I run go build nonexist, I get:
package nonexist: cannot find package "nonexist" in any of:
	/home/mdempsky/wd/go/src/nonexist (from $GOROOT)
	/home/mdempsky/go/src/nonexist (from $GOPATH)

But using go/packages.Load and go/packages.PrintErrors (full code below), I get:
-: cannot find package "nonexist" in any of:
	/home/mdempsky/wd/go/src/nonexist (from $GOROOT)
	/home/mdempsky/go/src/nonexist (from $GOPATH)

Is there some parser code that thinks "package nonexist:" is not a valid source position, so it gets mapped to "-:"?
Demo code:
package main

import "golang.org/x/tools/go/packages"

func main() {
	cfg := &packages.Config{Mode: packages.NeedName}
	pkgs, err := packages.Load(cfg, "nonexist")
	if err != nil {
		panic(err)
	}
	packages.PrintErrors(pkgs)
}

/cc @matloob @heschik

cc @stamblerre
Errors are associated with positions in a file, and if there's no position, the error is printed with a -. See the documentation of error here. https://pkg.go.dev/golang.org/x/tools/go/packages?tab=doc#Error
The error's already associated with a package, so the error doesn't print its own package to avoid redundancy.

Can we make "go build" follow the same convention then? I.e., make it print "-:" instead of "package nonexist:"?

@jayconrod @bcmills
I don't know if that's the right thing to do here: the closer analogue to what go packages does is go list -e -json: and with those you get a very similar result:
$ go list -e -json nonexist
{
	"ImportPath": "nonexist",
	"Match": [
		"nonexist"
	],
	"Incomplete": true,
	"Error": {
		"ImportStack": [
			"nonexist"
		],
		"Pos": "",
		"Err": "package nonexist is not in GOROOT (/usr/local/go/src/nonexist)"
	}
}

Looks like cmd/go's "package nonexist:" output comes from:
https://github.com/golang/go/blob/a55645fa3481413b335561924d8fa626ce440ad4/src/cmd/go/internal/load/pkg.go#L396

I don't think -: is a particularly helpful prefix. (Helpful to tools, perhaps, but confusing to humans.)
That said, package nonexist: cannot find package "nonexist" is unpleasantly redundant too. This failure message is a lot smoother in module mode than in GOPATH mode:
example.com$ GO111MODULE=on go build nonexist
package nonexist is not in GOROOT (/usr/local/google/home/bcmills/sdk/gotip/src/nonexist)

example.com$ GO111MODULE=off go build nonexist
package nonexist: cannot find package "nonexist" in any of:
        /usr/local/google/home/bcmills/sdk/gotip/src/nonexist (from $GOROOT)
        /tmp/tmp.00bJBNCJEL/_gopath/src/nonexist (from $GOPATH)

If someone wants to fix the GOPATH-mode error message to match the module-mode one, that seems like it would be an improvement, but unless we see something similar in module mode I don't think it's worth spending much time on.

On the go/packages side, one thing we can do is just drop the "-:" on the error's String method. That might be nicer for users if the package?

cmd/go now prints:

package nonexist is not in std (/home/user/sdk/gotip/src/nonexist)

and go/packages prints:

-: package nonexist is not in std (/home/user/sdk/gotip/src/nonexist)

Those look good to me. We're not printing setting a redundant pos from the go command and printing that from go packages, we indicate there's no position with "-".
In golang.org/x/tools/go/packages.Error.Error, we explicitly print "-:" when the pos is empty, which I think is reasonable.


[Bug]: Extension to 10548

Bug Description
The problem mentioned in 10548 (fix) is not working. Tried with the code changes and got below error:
/usr/local/lib/python3.10/dist-packages/llama_index/vector_stores/elasticsearch.py:357: RuntimeWarning: coroutine 'ElasticsearchStore._create_index_if_not_exists' was never awaited
self._create_index_if_not_exists(
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
/usr/local/lib/python3.10/dist-packages/llama_index/vector_stores/elasticsearch.py:388: RuntimeWarning: coroutine 'async_bulk' was never awaited
async_bulk(
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
/usr/local/lib/python3.10/dist-packages/llama_index/vector_stores/elasticsearch.py:392: RuntimeWarning: coroutine 'async_bulk' was never awaited
success, failed = async_bulk(
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
TypeError                                 Traceback (most recent call last)
 in <cell line: 1>()
----> 1 index = VectorStoreIndex.from_documents(
2     documents, storage_context=storage_context)
10 frames
/usr/local/lib/python3.10/dist-packages/llama_index/vector_stores/elasticsearch.py in async_add(self, nodes, create_index_if_not_exists, **add_kwargs)
390         )
391         try:
--> 392             success, failed = async_bulk(
393                 self.client, requests, stats_only=True, refresh=True
394             )
TypeError: cannot unpack non-iterable coroutine object
Version
0.9.46
Steps to Reproduce
Follow the case 10548
Relevant Logs/Tracbacks
/usr/local/lib/python3.10/dist-packages/llama_index/vector_stores/elasticsearch.py:357: RuntimeWarning: coroutine 'ElasticsearchStore._create_index_if_not_exists' was never awaited
  self._create_index_if_not_exists(
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
/usr/local/lib/python3.10/dist-packages/llama_index/vector_stores/elasticsearch.py:388: RuntimeWarning: coroutine 'async_bulk' was never awaited
  async_bulk(
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
/usr/local/lib/python3.10/dist-packages/llama_index/vector_stores/elasticsearch.py:392: RuntimeWarning: coroutine 'async_bulk' was never awaited
  success, failed = async_bulk(
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-16-4b901dfb7bfa> in <cell line: 1>()
----> 1 index = VectorStoreIndex.from_documents(
      2     documents, storage_context=storage_context)

10 frames
/usr/local/lib/python3.10/dist-packages/llama_index/vector_stores/elasticsearch.py in async_add(self, nodes, create_index_if_not_exists, **add_kwargs)
    390         )
    391         try:
--> 392             success, failed = async_bulk(
    393                 self.client, requests, stats_only=True, refresh=True
    394             )

TypeError: cannot unpack non-iterable coroutine object

yea so this is a different error in the code :sigh: the fix I merged fixed one bug, and allowed the code to get to the next I guess

Please let me know if this issue is fixed

Able to get below error post to creating VectorstoreIndex:

AttributeError                            Traceback (most recent call last)
 in <cell line: 3>()
1 query = "What is most interesting about this essay?"
2 query_engine = index.as_query_engine()
----> 3 answer = query_engine.query(query)
4
5 print(answer.get_formatted_sources())
10 frames
/usr/local/lib/python3.10/dist-packages/llama_index/vector_stores/elasticsearch.py in aquery(self, query, custom_query, es_filter, **kwargs)
544             logger.debug(f"Calling custom_query, Query body now: {es_query}")
545
--> 546         async with self.client as client:
547             response = await client.search(
548                 index=self.index_name,
AttributeError: aenter
Below is sample code:
query = "What is most interesting about this essay?"
query_engine = index.as_query_engine()
answer = query_engine.query(query)

We need to remove await in the above comment also. It is working for me now. Please fix this.


getting html embeded instead of error message

Describe the bug

Should throw error, when tokens are expired, rather it is embedding html
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-edgi7e
Steps to reproduce

Drain your tokens 2. try to enhance the prompt

Expected behavior
error message directly. or not allowing to enhance prompt, if no tokens are left
Screen Recording / Screenshot
No response
Platform

OS: , Windows
Browser:Chrome
Version: [e.g. 91.1]

Additional context
No response

Appreciate the feedback! We are tracking this issue here: #2529.


Question: is possible to use query or result set as not 'auto'?

Hi All.
It seems like the most common pattern to read and iterate through a database query is this:
    auto rowSet = db(select(...) );
    for ( const auto& row : rowSet ) { <do stuff with 'row'> }

The query and the result set have to be declared as 'auto' because the definitions of these objects are very complex and dependent on the columns you are selecting.
But I am wondering if there is any way to add helper 'default column' typedefs when you convert DDL script into proxy classes.  Ultimately, it would be a lot cleaner to be able to pass around retrieved rows, of a certain select column profile, in order to centralize row processing.
I hate to scrape the definition out of the debugger and create typedefs manually since if roland changes the underlying sqlpp11, it could break all those typedefs.  Kinda fragile.

I think the best thing to do would be to construct something like a std::vector<std::tuple</*data types*/>> or your own class and pass that around. The only issue then would be that it would need to fill the data at once instead of one row at a time.

I think the best thing to do would be to construct something like a std::vector<std::tuple</*data types*/>> or your own class and pass that around.

Or make row_t<...> convertible to std::tuple<...>. Easier said than done, but I am actually thinking about back-porting the way columns are represented in sqlpp17. The types would still be non-trivial, but converting to tuple would be considerably simpler.

Being able to use a tuple would be interesting. Would that let you use the C++17 structured bindings to do something like:
for(auto [ID, Name, ContactName, Address, City, PostalCode, Country] : db(query)) {
}

That would be very nice. Personally I think making your own structure for a specific select makes sense when you want to pass it back and forth across an interface.
struct Customer {
  std::uint64_t ID;
  std::string Name;
  std::string ContactName;
  std::string Address;
  std::string City;
  std::string PostalCode;
  std::string Country;

  Customer() noexcept = default;

  template<class RowT>
  Customer(RowT&& row)
    : ID{row.customer_id}
    , Name{std::move(row.customer_name)}
    , ContactName{std::move(row.contact_name)}
    , Address{std::move(row.address)}
    , City{std::move(row.city)}
    , PostalCode{std::move(row.postal_code)}
    , Country{std::move(row.country)}
  {}
};

If there were specializations for std::tuple_size, std::tuple_element and get<I>(const Row&>, then structured binding would be possible.
I also prefer converting rows into some struct you want to pass around, too.
BTW: In your code, you should use std::forward instead of move.

Hi,
`I have made similar functionality:
template<class Db, class... Args>
class SqlppResultDeduction
{
	template<class... TC>
	struct ColumsDeduction
	{
		template<class Col, typename std::enable_if<!std::is_base_of<sqlpp::table_base_t, Col>::value, int>::type = 0>
		static const auto& GetColumns(const Col&)
		{
			return std::declval<Col>();
		}

		template<class... Cols>
		static auto GetColumns(const sqlpp::table_t<Cols...>& tab)
		{
			return sqlpp::all_of(tab);
		}

		using Type = typename sqlpp::detail::make_select_column_list_t<void, decltype(GetColumns(std::declval<TC>()))...>::_nodes;
	};

	template<class... Cols>
	static auto GetResult(const sqlpp::detail::type_vector<Cols...>&)
	{
		using selectType = decltype(sqlpp::select(std::declval<Cols>()...));
		using char_result_type = decltype(std::declval<Db>().select(std::declval<selectType>()));

		return sqlpp::result_t<char_result_type, sqlpp::result_row_t<Db, sqlpp::make_field_spec_t<selectType, Cols>...>>();
	}
public:
	using Type = decltype(GetResult(std::declval<typename ColumsDeduction<Args...>::Type>()));
};

template<class Db, class... Args>
using SqlppResult = typename SqlppResultDeduction<Db, std::decay_t<Args>...>::Type;`

And you can use it like this:
`SqlppResult<sqlpp::mysql::connection, DbModelType> GetAll()
{
     sqlpp::mysql::connection con;
     const DbModelType model{};

     return con(sqlpp::select(all_of(model)).from(model).unconditionally();
}`

Regards

this doesn't work...

I think what you'd want to do to accomplish this is something that stores all of the results when it is constructed so that you don't have to worry about the entire template of the result_t. Many database libraries get around large and complex templates by using inheritance or unions to store results, while sqlpp11 only stores the actual data that would be used by that specific column.
Please see my earlier reply on this subject. Here you can see how you might construct a specific entity named Customer from whatever the result actually is. This object could then be easily passed around across libraries. You could also make a static function to make a vector of customers like so:
class Customer {
...
template<class Result>
static std::vector<Customer> all_rows(Result&& res)
{
    std::vector<Customer> ret;
    ret.reserve(res.size());
    for(auto&& row : res)
        ret.emplace_back(row);
    return ret;
}
};

Without c++14's copy elision you might want to do return std::move(ret); instead.

I have explained my concern in detail under this issue:
https://github.com/rbock/sqlpp11/issues/380
Thank you so much for help:)


Update luis-get-started-create-app.md

Instead of intent name, it should be entity name.

@hjain5164 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

Thanks for this contribution to the documentation. We'll merge this and have it live shortly.
#sign-off


Is there any benefit to having multiple test projects?

@JasonGT I see that you've added unit tests for Domain, Application and UI. Would there be a disadvantage to having them all in the same project, maybe organized in folders or by using a [TestCategory] attribute?

I think you can go either way, just need to decide what works well for you and your team. I prefer separate projects for large systems, but I could see a single project working well for smaller smaller systems. At a minimum I'd have separate projects for unit / integration / functional test projects, since their cross cutting concerns will be different.


chore: bdd-nh-1585015526 to 0.0.1

chore: Promote bdd-nh-1585015526 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[5.8] Update AuthorizesRequests.php

The viewAny-method in a policy generated with php artisan is not declared in this mapping. Policies don't work anymore after a composer update.

Have you upgraded to the latest version of Laravel? I thought this was fixed last week?

Have you upgraded to the latest version of Laravel? I thought this was fixed last week?

Yes, my laravel version is v5.8.26 and the composer update deleted my changes in the AuthorizesRequests-trait. I saw there was a revert a couple of days ago.

So to clarify - you were taking advantage of the new feature introduced in https://github.com/laravel/framework/pull/28820 (which was a breaking change) and then the revert in https://github.com/laravel/framework/pull/28865 caused you a different breaking change (since you had adopted the new behaviour.
Am I understanding that correctly?

So to clarify - you were taking advantage of the new feature introduced in #28820 (which was a breaking change) and then the revert in #28865 caused you a different breaking change (since you had adopted the new behaviour.
Am I understanding that correctly?

I followed the documentation on https://laravel.com/docs/5.8/authorization . viewAny didn't work. So i searched for a solution. I found it by debugging the code. After a composer update i noticed that the treat was changed (normal). So then i searched if i could add it to the laravel framework, because due a failing of tests an other commit #28820 (with the changes in this treat) was reverted #28865. If the edit causes an error for other users you may close this and delete the request. It wasn't my intention to take advante of the new feature or steal any credit.

Thanks @ZoWeArdeb - I think that's an error in the documentation, which was added after the original PR, but not reverted when we reverted the changes. So I can see how that would cause confusion.
Is there anyway we can support both behaviours with breaking anything?

Huh? This was sent to 5.9 because adding it is a breaking change.


[BUG] Unable to login ChatGPT, infinite Cloudflare challenge loop

Describe the bug
Unable to login ChatGPT since the last few days.
After clicking on the login link, stuck at Please stand by, while we are checking your browser... and auto refresh indefinitely.
To Reproduce

Click on ChatGPT (GPT-3.5) login link
Stuck at Please stand by, while we are checking your browser...

Expected behavior
Able to login
Screenshots
https://github.com/sunner/ChatALL/assets/26683979/46a7836c-5e61-4198-a7c5-6dab5e855fce
Devtools Info
chat.openai.com-1687862648125.log
Versions

OS and version: Windows 11
ChatALL version: 1.29.39

Network
Are you using a VPN or proxy? No

The issue has happened again.
As I checked the process.versions, the Chrome version is still 114.0.5735.134, same as the _userAgent.
https://github.com/sunner/ChatALL/blob/3d9c1708fd53c3fb4e3dc90fa1ae00a5dad53434/src/bots/openai/ChatGPTBot.js#L20
Below is the user agent that worked for me. The difference is the OS name.
Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.5735.134 Safari/537.36

I tested on the latest main branch. It worked well.
We can wait for more reports.

Facing exact same issue now, firefox works fine while chatall stuck in infinite Cloudflare challenge loop.


Gitops Config managing itself creates race condition that will delete all resources

What version of eunomia are you using?
0.1.6
kubectl exec $EUNOMIA_POD curl localhost:8383/metrics Output
$ kubectl get -n eunomia-operator endpoints/eunomia-operator -o jsonpath='{.subsets[*].addresses[*].targetRef.name}' | xargs -I% kubectl exec -n eunomia-operator % -- curl -sS localhost:8383/metrics | grep eunomia_build_info

eunomia version:
0.1.6
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (kubectl version)?
oc v3.11.0+0cbc58b
kubernetes v1.11.0+d4cacc0
Eunomia is running on an Openshift cluster
openshift v3.11.98
kubernetes v1.11.0+d4cacc0
kubectl version Output
$ kubectl version

What did you do?
Created a GitOpsConfig resource that would manage itself as well as a deployment stateful set and services

applied a GitOpsConfig that templated out its own gitopsconfig yaml as well as other resources.
The GitOpsConfig was set to trigger on webhook, cron, and change
What did you expect to see?
The gitops config would manage/update itself as well as other resources whenever an update was pushed to the branch.
What did you see instead?
The gitops config would fire multiple jobs and a race condition was created that could and did delete all of the resources as well as the GitopsConfig so then someone needed to reapply the GitOpsConfig.
Proposed Ideas of what happened in eunomia
the line that caused the deletion of all resources was https://github.com/KohlsTechnology/eunomia/blob/581ec8e6078b2f6a34a9ee2ae148cc808d954859/template-processors/base/bin/resourceManager.sh#L76
Since multiple jobs had kicked off for the same GitOpsConfig by one webhook and the GitOpsConfig was managing itself. I believe that one of the jobs updated the timestamps while the other job was running thus deleting the owned Kind of GitOpsConfig that had a different timestamp than it was expecting. So once the gitopsConfig was deleted then all of the other resources were deleted as well.
** Proposed Solutions **
multiple jobs for the same gitops config cannot run at the same time.
Ensure the Gitops Config cannot manage itself

Since multiple jobs had kicked off for the same GitOpsConfig by one webhook and the GitOpsConfig was managing itself. I believe that one of the jobs updated the timestamps while the other job was running thus deleting the owned Kind of GitOpsConfig that had a different timestamp than it was expecting.

The deletion logic does have problems when jobs overlap. We are mitigating this, in part at least, via #351 but we need a long term solution that can make the individual jobs idempotent or use a locking mechanism so that they are able to run concurrently if that case arises.

So once the gitopsConfig was deleted then all of the other resources were deleted as well.

An option would be setting resource deletion mode to None which abandons resources managed by a gitopsConfig when that gitopsConfig is removed. Not ideal but its something...

@sanbornick found a way to fix this ... https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#concurrency-control-and-consistency

Fixed by #376.

Fixed by #376.


⚠ AtmoLive03 Server has degraded performance

In fd4ac00, AtmoLive03 Server ($ATMOLIVE03) experienced degraded performance:

HTTP code: 500
Response time: 25760 ms

Resolved: AtmoLive03 Server performance has improved in f5f2e68.


Bugfixes, small additions, organization

Small bugfix for hostname. Move idls to their own directory, since there's going to be more of these as time goes on. Add the two recently added idls to have their generated js version removed on clean.

There's some extra noise in these due to some automated removal of spaces at the end of newlines. Let me know if you want me to remove that stuff or just leave it as is (removing end of life spaces is preferable due to a lot of stuff automatically doing it).

Brandon,
Thanks for this pull request.  Lots of good stuff in here!  I commented on a couple of the individual commits, and would like you to address those before I merge.
I don't care much about the extra spaces at the end of lines.  But clearly your toolchain does.  The only problem I've got is that it makes it harder to find what has actually changed.  Do you have some way to remove extraneous spaces throughout the entire codebase?  So we can just do it once and then not have to deal with it again?  (Maybe I can find an emacs setting that will prevent me from adding extra spaces...)
Thanks

Yeah the whitespace thing is killing me. I'm trying to figure out which part of the process is causing that. I have it explicitly set to ignore whitespace in git but alas. I'll see if I can get it to stop doing that or if I can do a mass whitespace removal in one commit to keep that separate. I hadn't even noticed it was doing that until I made this pull.

Thanks Brandon!


Fix page refresh whenever tab tap & card UI tweak

I've been trying to figure out a way to keep the states of each tab, your PR solves it. Thank you


⚠ Bofrost.nl has degraded performance

In 0495d06, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1131 ms

Resolved: Bofrost.nl performance has improved in e12fc8b.


Add OCSP Stapling feature to the generated certificates

Firefox complains when it opens a secured TLS connection using certificates generated by concert. The error code shown by Firefox is MOZILLA_PKIX_ERROR_REQUIRED_TLS_FEATURE_MISSING error. Concert needs to ask for ocsp stabling feature.

concert already generates certificates with must staple feature. I already tested it with nginx. The problem is in the minio server.
In the other side, I think that it will be good if concert will have a flag to disable must staple in the generated certificate.

concert already generates certificates with must staple feature. I already tested it with nginx. The problem is in the minio server.
In the other side, I think that it will be good if concert will have a flag to disable must staple in the generated certificate.

It is not must staple feature it is staple-ocsp feature which is not present the lego/acme library.

Project deprecated, closing this as won't fix.


Question regarding MRE use case + synchronizing plugins

Hello!
We are planning on using MRE to detect football highlights, and a few of our brainstormed feature detectors would rely on future knowledge to determine the importance of a play. For example:

The length of replays after the play (more replays indicate more exciting play)
Score (because of the "Touchdown" banner, the updated score doesn't appear until the play has been over for a few seconds)

We were wondering if it would be possible to make predictors of this type. For example, if we have one featurer that extracts the score of every frame (if it exists), would a second featurer be able to look a few seconds ahead to determine if the current play is responsible for that change in score? Or can featurers only access results from other featurers up to that chunk?
In general, how does MRE synchronize featurers and the segmenter as new chunks are arriving?
Thank you for your guidance!

Hi @marcos-acosta! In MRE, the synchronization of segmenter and featurers happens during Replay creation. That is, once you create a replay by choosing weights for different features, MRE will then query the PluginResult DynamoDB table to look for all the segments which contain the features selected during the replay creation. Because these features are typically outputted by the featurer plugins that execute independent of the segmenter plugin, the Replay Engine basically uses the "Start" time associated with these features to verify if a given feature is present within a segment or not (segment Start <= feature Start <= segment End). Once it finds a list of segments and associated features, it then uses the weights given during replay creation to each of these features to calculate an overall score for a segment and then decide whether or not to include that segment in the replay. This whole process happens every time a new segment is identified by MRE (if it's a catchup replay) or once at the end of the event after all the segments have been identified (if it's a non-catchup replay).
Now, to answer your other question on whether it's possible to "look ahead" in a featurer plugin - currently it's not possible to do so since there are no capabilities available (yet) in MRE to support this feature out-of-the-box. However, given you're looking to determine the importance of a play based on the future data, a possible workaround for this could be to "look back" once the future data arrives and then modify the play that happened prior to that. In order to implement this workaround, you would probably need to make use of the get_segment_state MRE dataplane API to get the last stored segment, figure out if it's important or not using the current chunk data (that is, if the instant replay found in the current chunk is long or not), and if the prior segment is deemed important, then store it again in MRE using the same Start and End time (now with additional metadata included to denote its importance). In addition to this, you may also need to make the featurer plugin that's detecting scores as the dependent plugin of the segmenter (so that the segmenter now knows what the featurer detected for that chunk) and include the Start, End, and other relevant metadata of segment N-1 when persisting segment N in cases where segment N is partial (that is, only Start was found with no End). This is to handle certain scenarios where a segment could span across multiple chunks resulting in get_segment_state giving you partial segment as the last identified segment.

Hi @araviraj-aws! Thanks so much for the detailed response, I really appreciate it. I have a couple, smaller questions based on your answer that I could use some clarification on, if you don't mind.

You mention that when creating a Replay, MRE looks through the feature results that occur between each segment Start and End. How does MRE handle the fact that the desired feature has multiple values within time frame? Does the criteria only need to be met once within the segment to be weighted?
You suggested re-storing previous segments with additional metadata included to denote its importance if we retroactively determine a previous segment be more important. But as you said, when generating Replays, MRE only looks at featurer results within the Start and End time of each segment, so what information could we add to the segment itself that MRE would use in the Replay generation step?

And three more related questions:

Looking through the sample plugin SegmentByScene in aws-media-replay-engine-samples, I noticed that partial segments are stored in the dataplane by storing an incomplete segment with a Start but no End, and when it finds the End in a later chunk, it stores a new segment with the same Start from the incomplete segment and the newly found End. Is my reading of the code correct? Is the incomplete segment ignored by MRE?
The UI seems to imply that features chosen as weights for Replay creation must be binary features (it shows | true and | false after each featurer output attribute when setting the weights). Is that correct?
To emulate a live video source, we've been adding 25-second .mp4 video chunks to an S3 bucket. We set timecode source to NOT_EMBEDDED, but noticed that MRE doesn't seem to work properly, as it uses the PTS time of the first keyframe as the start time of each chunk, and so for example it thinks the second chunk starts at t=3.883 when it really occurs 25 seconds after the first chunk. Because of this, the segmenter can't work properly. Do you have advice for how to work with this? Or is this not expected behavior?

Thank you again for your patience with our questions!
-Marcos

Hi @araviraj-aws, thank you so much again for your detailed responses! Two last quick questions before I'm happy to close the issue:

Within a featurer, is it possible to read its own plugin results on a previous chunk? Or is "looking across chunks" only possible in segmenters by design?
I have a featurer that uses Custom Labels to determine the scene type (e.g. in play, down time, replay, etc.). I would like the segmenter to create segments by grouping together long stretches of one type of detection. However, doing this requires some kind of state persistence to remember what type of scene to include in the segment and know when to end. E.g. if we find the start of a replay at the end of one chunk, it wouldn't be enough to know that the segment state is Start in the next chunk, it must also know that it's looking for more replay frames and to end the segment when it starts seeing non-replay scene types. Is it possible to persist arbitrary state across chunks like this? Should I create an output attribute from the segmenter with that information, and then read it in within the segmenter itself?

Thanks again!

Hi @marcos-acosta !

There's currently no API available in the data plane that lets a featurer plugin read its own results from a previous chunk. However, it doesn't mean this is not possible to achieve. In your featurer plugin, you can query the PluginResult DynamoDB table directly using the PK_ChunkNumber-index GSI with <program>#<event>#<featurer_plugin_name> as the partition key and <chunk_number> of the previous chunk as the sort key to get the results.

When you ask for the segment state using the get_segment_state() API, it not only returns the last segment state (which is either Start or End) but also returns the last stored segment itself (which is nothing but the actual DDB item). So, if you persist the scene type information as an additional attribute (key) when storing the segment, you could then read them the next time you get the segment state and take action accordingly. Let me know if this answers your question or if I totally misinterpreted your use case.

Thanks!

Great, those perfectly answer my questions. Thank you!


Upgrade isort to 5.5.1

For https://github.com/microsoft/vscode-python/issues/13831

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[x] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
[ ] The wiki is updated with any design decisions/details.

Codecov Report

Merging #13832 into main will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #13832      +/-   ##
==========================================
- Coverage   59.93%   59.91%   -0.03%
==========================================
  Files         684      684
  Lines       37962    37962
  Branches     5466     5466
==========================================
- Hits        22753    22744       -9
+ Misses      14048    14040       -8
- Partials     1161     1178      +17

Impacted Files
Coverage Δ

src/client/datascience/crossProcessLock.ts
79.41% <0.00%> (-11.77%)
:arrow_down:

src/client/common/utils/platform.ts
56.00% <0.00%> (-8.00%)
:arrow_down:

src/client/linters/pydocstyle.ts
86.66% <0.00%> (-2.23%)
:arrow_down:

src/client/datascience/debugLocationTracker.ts
76.56% <0.00%> (-1.57%)
:arrow_down:

src/client/common/process/proc.ts
14.49% <0.00%> (-0.73%)
:arrow_down:

src/client/logging/levels.ts
61.11% <0.00%> (ø)

src/client/logging/logger.ts
62.74% <0.00%> (ø)

src/client/logging/formatters.ts
53.57% <0.00%> (ø)

src/client/logging/transports.ts
65.11% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef5f4df...ab86a1d. Read the comment docs.


driver_entry_interface.h: Correct errors in API documentation

Signed-off-by: “Rico<EMAIL_ADDRESS>

man... I really like the "'" in "its" apparently 😄

Yup... I realize :tongue:
it's -> it is


Update README.md

added "comma-seperated" the description for env_vars
This is important when using the literal block scalar | with a variable ${{<variable name>}}, as entries are not parsed separately unless they are comma-seperated (newlines aren't enough)
example:
      - id: "deploy"
        uses: "google-github-actions/deploy-cloud-functions@v2"
        with:
          name: "function_name"
          entry_point: "main"
          runtime: "python311"
          memory_mb: "8192MB"
          env_vars: |
            FOO=${{ env.PROJECT_NAME }}
            BAR=BAZ
          source_dir: ...

sets one environment variable FOO as <project_name>\nBAR=BAZ

I just signed the CLA. Do I need to resubmit this PR?


Update data for next season?

Are you going to update the application so that it uses this year's rankings?

yup, that's the plan. gonna need to get in touch with boris chen.

I'm curious how you get the json data from FantasyPros. I didn't see any way of exporting their data in json format. Did you construct it yourself? This helped me a ton during my draft last year. Thanks!

I have a backend that serves the JSON content. I think it has functionality to import excel or csv. I don't get data directly from FantasyPros. I get it from Boris Chen who had it in a google spreadsheet.

This past season i used your tool and fantasyfootballcalculator.com's ADP rankings to draft. I used them in 3 leagues (2 14 team leagues and a 10 team league). I won a 14 team league however I picked up ODB which had a lot to do with it, but i also dominated (1st all year, most points/gm, most total points etc.). I went to the championship in the 10 teamer with little lineup tinkering; few waiver adds/trades. In the other 14 teamer I started poorly and began dropping and trading players by wk 5. I later realized the players i lost performed well later in the season. I might have gone further in to the playoffs if I hadn't made those moves.
All in all, pretty successful year using your tool and I hope to use it again. I found that with each draft I did I was using ffcalc less and your tool more. By the 3rd draft I was using your tool exclusively.

updated.

It's looking great, already used it a couple times. Great job!
On Tue, Aug 4, 2015 at 4:34 PM, Jay Zheng<EMAIL_ADDRESS>wrote:

updated.
—
Reply to this email directly or view it on GitHub
https://github.com/jayjzheng/ff_rankings/issues/7#issuecomment-127796567
.

--
Collin Steranka


chore: Configure Renovate

Welcome to Renovate! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin.
🚦 To activate Renovate, merge this Pull Request. To disable Renovate, simply close this Pull Request unmerged.

Detected Package Files

Dockerfiles/Dockerfile (dockerfile)
Dockerfiles/toolbox.Dockerfile (dockerfile)
.github/workflows/check-file-updates.yaml (github-actions)
.github/workflows/linter.yaml (github-actions)
.github/workflows/unit-tests.yaml (github-actions)
go.mod (gomod)

Configuration Summary
Based on the default config's presets, Renovate will:

Start dependency updates only once this onboarding PR is merged
Enable Renovate Dependency Dashboard creation.
Use semantic commit type fix for dependencies and chore for all others if semantic commits are in use.
Ignore node_modules, bower_components, vendor and various test/tests (except for nuget) directories.
Group known monorepo packages together.
Use curated list of recommended non-monorepo package groupings.
Apply crowd-sourced package replacement rules.
Apply crowd-sourced workarounds for known problems with packages.

🔡 Do you want to change how Renovate upgrades your dependencies? Add your custom config to renovate.json in this branch. Renovate will update the Pull Request description the next time it runs.

What to Expect
With your current configuration, Renovate will create 19 Pull Requests:

chore(deps): update registry.access.redhat.com/ubi8/go-toolset docker digest to 742ae6e

Schedule: ["at any time"]
Branch name: renovate/registry.access.redhat.com-ubi8-go-toolset
Merge into: main
Upgrade registry.access.redhat.com/ubi8/go-toolset to sha256:742ae6ec1aef3e7faae488c47695fb64964d342aefecf52d23bd9d5e6731d0b6

fix(deps): update github.com/openshift/addon-operator/apis digest to dd01f2f

Schedule: ["at any time"]
Branch name: renovate/github.com-openshift-addon-operator-apis-digest
Merge into: main
Upgrade github.com/openshift/addon-operator/apis to dd01f2f5c184

fix(deps): update github.com/openshift/api digest to 82e0822

Schedule: ["at any time"]
Branch name: renovate/github.com-openshift-api-digest
Merge into: main
Upgrade github.com/openshift/api to 82e082220d910f489d35880174e2eb90e21f5589

fix(deps): update golang.org/x/exp digest to 225e2ab

Schedule: ["at any time"]
Branch name: renovate/golang.org-x-exp-digest
Merge into: main
Upgrade golang.org/x/exp to 225e2abe05e6

fix(deps): update module github.com/go-logr/logr to v1.4.2

Schedule: ["at any time"]
Branch name: renovate/github.com-go-logr-logr-1.x
Merge into: main
Upgrade github.com/go-logr/logr to v1.4.2

chore(deps): update kubernetes packages to v0.31.1

Schedule: ["at any time"]
Branch name: renovate/kubernetes-go
Merge into: main
Upgrade k8s.io/api to v0.31.1
Upgrade k8s.io/apiextensions-apiserver to v0.31.1
Upgrade k8s.io/apimachinery to v0.31.1
Upgrade k8s.io/client-go to v0.31.1
Upgrade k8s.io/kube-aggregator to v0.31.1

fix(deps): update module github.com/onsi/ginkgo/v2 to v2.20.2

Schedule: ["at any time"]
Branch name: renovate/github.com-onsi-ginkgo-v2-2.x
Merge into: main
Upgrade github.com/onsi/ginkgo/v2 to v2.20.2

fix(deps): update module github.com/onsi/gomega to v1.34.2

Schedule: ["at any time"]
Branch name: renovate/github.com-onsi-gomega-1.x
Merge into: main
Upgrade github.com/onsi/gomega to v1.34.2

fix(deps): update module github.com/operator-framework/api to v0.27.0

Schedule: ["at any time"]
Branch name: renovate/github.com-operator-framework-api-0.x
Merge into: main
Upgrade github.com/operator-framework/api to v0.27.0

fix(deps): update module github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring to v0.77.1

Schedule: ["at any time"]
Branch name: renovate/github.com-prometheus-operator-prometheus-operator-pkg-apis-monitoring-0.x
Merge into: main
Upgrade github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring to v0.77.1

fix(deps): update module github.com/spf13/afero to v1.11.0

Schedule: ["at any time"]
Branch name: renovate/github.com-spf13-afero-1.x
Merge into: main
Upgrade github.com/spf13/afero to v1.11.0

fix(deps): update module github.com/stretchr/testify to v1.9.0

Schedule: ["at any time"]
Branch name: renovate/github.com-stretchr-testify-1.x
Merge into: main
Upgrade github.com/stretchr/testify to v1.9.0

fix(deps): update module go.uber.org/zap to v1.27.0

Schedule: ["at any time"]
Branch name: renovate/go.uber.org-zap-1.x
Merge into: main
Upgrade go.uber.org/zap to v1.27.0

fix(deps): update module sigs.k8s.io/controller-runtime to v0.19.0

Schedule: ["at any time"]
Branch name: renovate/sigs.k8s.io-controller-runtime-0.x
Merge into: main
Upgrade sigs.k8s.io/controller-runtime to v0.19.0

fix(deps): update module sigs.k8s.io/kustomize/api to v0.17.3

Schedule: ["at any time"]
Branch name: renovate/sigs.k8s.io-kustomize-api-0.x
Merge into: main
Upgrade sigs.k8s.io/kustomize/api to v0.17.3

fix(deps): update module sigs.k8s.io/kustomize/kyaml to v0.18.0

Schedule: ["at any time"]
Branch name: renovate/sigs.k8s.io-kustomize-kyaml-0.x
Merge into: main
Upgrade sigs.k8s.io/kustomize/kyaml to v0.18.0

chore(deps): update actions/setup-go action to v5

Schedule: ["at any time"]
Branch name: renovate/actions-setup-go-5.x
Merge into: main
Upgrade actions/setup-go to v5

chore(deps): update registry.fedoraproject.org/fedora-toolbox docker tag to v42

Schedule: ["at any time"]
Branch name: renovate/registry.fedoraproject.org-fedora-toolbox-42.x
Merge into: main
Upgrade registry.fedoraproject.org/fedora-toolbox to 42

fix(deps): update module gopkg.in/yaml.v2 to v3

Schedule: ["at any time"]
Branch name: renovate/gopkg.in-yaml.v2-3.x
Merge into: main
Upgrade gopkg.in/yaml.v2 to v3.0.1

🚸 Branch creation will be limited to maximum 2 per hour, so it doesn't swamp any CI resources or overwhelm the project. See docs for prhourlylimit for details.

❓ Got questions? Check out Renovate's Docs, particularly the Getting Started section.
If you need any further assistance then you can also request help here.

This PR has been generated by Renovate Bot.

Renovate is disabled
Renovate is disabled because there is no Renovate configuration file. To enable Renovate, you can either (a) change this PR's title to get a new onboarding PR, and merge the new onboarding PR, or (b) create a Renovate config file, and commit that file to your base branch.


Deployment to clean namespace fails when using embedded DAGs in Docker image

What is the bug?
Hi,
I think I found a bug in the chart when using 'Option 3 - embedded into container image' as my DAG deployment method. Let me try to describe what is going on.
I am currently deploying Airflow 2 locally to a minikube cluster as a preparation for the migration to Airflow 2. I already migrated all the DAG code according to the Airflow guides. Whenever I deploy my release to a brand new namespace, the airflow-local-db-xxxx pod keeps Crashing (CrashLoopBackOff). When I connect to the container "upgrade-db" I can see it fails to load my DAGs because of errors like:

connection.description does not exist:

ERROR [airflow.models.dagbag.DagBag] Failed to import: /opt/airflow/dags/my_amazing_dag.py
Traceback (most recent call last):
  File "/home/airflow/.local/lib/python3.8/site-packages/sqlalchemy/engine/base.py", line 1276, in _execute_context
    self.dialect.do_execute(
  File "/home/airflow/.local/lib/python3.8/site-packages/sqlalchemy/engine/default.py", line 608, in do_execute
    cursor.execute(statement, parameters)
psycopg2.errors.UndefinedColumn: column connection.description does not exist
LINE 1: ...id, connection.conn_type AS connection_conn_type, connection...

variable.description does not exist:

sqlalchemy.exc.ProgrammingError: (psycopg2.errors.UndefinedColumn) column variable.description does not exist
LINE 1: ....id AS variable_id, variable.key AS variable_key, variable.d...
                                                             ^
[SQL: SELECT variable.val AS variable_val, variable.id AS variable_id, variable.key AS variable_key, variable.description AS variable_description, variable.is_encrypted AS variable_is_encrypted
FROM variable
WHERE variable.key = %(key_1)s
 LIMIT %(param_1)s]

My feeling is that the airflow-local-db pod tries to load the DAGs before having succesfully imported the variables and connections into the database.
To test this assumption, I did the following:
(For the sake of simplicity, I have reduced my custom Docker image to this)
FROM apache/airflow:2.1.1-python3.8
COPY dags /opt/airflow/dags

I commented the COPY step out and tried installing the chart => I can succesfully deploy Airflow V2 to an empty namespace. This means that my environment does not contain any DAGs, but does have its connections and variables deployed.
Now, when I uncomment the COPY step again and re-run the installation, the installation succeeds and all my DAGs are deployed succesfully.
When I delete my namespace again and try deploying a clean install (with dags included in my Docker image) I get the error from above again.

Any idea how to solve this? Is it absolutely necessary for the airflow-local-db pod to load the DAGs in order to fill the database?
What version of the chart are you using?:
I am using version 8.4.1
What is your Kubernetes Version?:
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.3", GitCommit:"ca643a4d1f7bfe34773c74f79527be4afd95bf39", GitTreeState:"clean", BuildDate:"2021-07-15T21:04:39Z", GoVersion:"go1.16.6", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.2", GitCommit:"faecb196815e248d3ecfb03c680a4507229c2a56", GitTreeState:"clean", BuildDate:"2021-01-13T13:20:00Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}

What is your Helm version?:
$ helm version
version.BuildInfo{Version:"v3.6.3", GitCommit:"d506314abfb5d21419df8c7e7e68012379db2354", GitTreeState:"clean", GoVersion:"go1.16.5"}

@MarvinSchenkel I can't seem to reproduce this
Can you please provide an example python dag file which causes the airflow-db-XXX container to crash?

I also see @BastiaanRudolf and @DanojNL have liked this issue, can one of you share a python DAG file that causes the crash (when embedded into the image)?

@MarvinSchenkel I am interested to know if you still have this issue with the new 8.5.0 version of the chart?
As we have removed the upgrade-db job, and replaced it with a Deployment called db-migrations.

I'm currently on holiday so I can't access my DAGs to send you an example.
I'll test the new chart when I get back next week and let you know.
Op ma 23 aug. 2021 om 02:30 schreef Mathew Wicks @.***>

@MarvinSchenkel https://github.com/MarvinSchenkel I am interested to
know if you still have this issue with the new 8.5.0 version
https://github.com/airflow-helm/charts/blob/main/charts/airflow/CHANGELOG.md#850---2021-08-19
of the chart?
As we have removed the upgrade-db job, and replaced it with a Deployment
called db-migrations.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/airflow-helm/charts/issues/335#issuecomment-903359016,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEG2MJ243V6LF37EDR7ZUTTT6GJDJANCNFSM5BGVZHJQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

@thesuperzapper I think I figured out what's up. I found another error (besides the one in the OP). There is something happening because of our codebase.
We have a couple of .py  files that are executed by DAGs via a BashOperator. These .py files have a couple of required arguments that are parsed via ArgumentParser, for example:
......some unrelated lines of code

# Argument parsing
parser = argparse.ArgumentParser(
    description='This script is used as a bash script within Airflow that executes the appropriate stored procedure '
                'on a DM within the Azure DWH. This stored procedure can be any procedure on the DM.')
parser.add_argument("--DM", help="The datamart (DM) we will execute the SP on.", required=True)
parser.add_argument("--SP", help="The stored procedure (SP) that will be executed.", required=True)
args = parser.parse_args()

if __name__ == '__main__':
    source_DM = args.DM
    source_SP = args.SP

    main(data_mart=source_DM, stored_procedure=source_SP)

It seems like the db_migrations.py file is actually executing these Python files which results in the following error:
usage: db_migrations.py [-h] --DM DM --SP SP
db_migrations.py: error: the following arguments are required: --DM, --SP

Is there any way to avoid this error, for example excluding these files from migration since they are not DAGs?

/facepalm
Moving the ArgumentParser within the main() is of course the correct solution. Rewriting most of our python files ensures we can actually deploy the latest charts without any issues. Closing this issue, sorry for the inconvenience.
Still curious as to why we were seeing the 'variable.description does not exist` error in the logs

@MarvinSchenkel just to check, are you not using the .airflowignore file to prevent airflow trying to run anything looking like a python file in your dags folder?
See the airflow docs for more info about .airflowignore:
https://airflow.apache.org/docs/apache-airflow/stable/concepts/dags.html#loading-dags

Awesome! I didn't know Airflow had an .airflowignore file. Will
definitely start using this, thanks for the tip!
On Fri, 3 Sept 2021 at 08:54, Mathew Wicks @.***> wrote:

@MarvinSchenkel https://github.com/MarvinSchenkel just to check, are
you not using the .airflowignore file to prevent airflow trying to run
anything looking like a python file in your dags folder?
See the airflow docs for more info about .airflowignore:
https://airflow.apache.org/docs/apache-airflow/stable/concepts/dags.html#loading-dags
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/airflow-helm/charts/issues/335#issuecomment-912302964,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEG2MJY4YIOV7FHXSKASLHDUABWKFANCNFSM5BGVZHJQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@MarvinSchenkel I believe it only works at the ROOT of the dags folder (so you can only have one .airflowignore file).

Thanks! And thanks again for all your effort on this amazing chart :)


Fast edit/refresh cycles on emulators and devices

[ ] Measure our cycle on emulators and devices (https://github.com/flutter/flutter/issues/2253)
[ ] Drive the experience from the command-line tools
[ ] Drive the experience from Atom

cc @devoncarew @johnmccutchan

We have hot reload now. :)


Greater Than/Less Than?

The <> don't see to be working?

The current parsing splits on space IIRC, which is likely the issue you're seeing (and is a larger change to fix heh).

Re-open if you're still seeing without the space!