Faster mergeIntersectingSelections

This pull-request introduces a performance improvement in mergeIntersectingSelection. Before changing it the cost of this function was O(n^2): selections were accessed always and in sparse order, causing the traversing time to increase exponentially as more and more selections were added.
Before merging selections, we now order them first and try to intersect the current selection with the previous one only. This brings the cost of mergeIntersectingSelections down to O(n log n), changing this:

To this:

:racehorse: :racehorse: :racehorse:
(Benchmarks based on splitting into lines the entire selection of a 400 lines file)
All the specs are green, therefore this "new algorithm" shouldn't have changed the behavior of mergeIntersectingSelections. It would be great to have some more :eyes: to detect any possible regression.
Hopefully, this should be a significant step forward towards #5163 :smile:

/cc: @nathansobo @gregersrygg
(as you were discussing about this in #5163 and I thought it might have been relevant to you :wink:)

@as-cii Fantastic work here.
If you're interested in optimizing this further, I have some ideas. I recently introduced the TextEditorPresenter layer to synchronously and incrementally maintain a state object based on model changes. The intuition on this was that for small changes like a single cursor movement or a single character insertion, recomputing the entire presenter state was wasteful and it would be better to make a small change. Unfortunately, when there are ton of little changes before the next display update, we end up paying more for each incremental update than we would pay if we waited and just recomputed everything at the end.
I see two paths of attack on this.

We could do a better job on the incremental updates. Some of them are way more wasteful than they need to be in that they update every line when one line updated, etc.

We could apply a heuristic for when we think a bunch of incremental changes might be applied. For example, we could handle 1 cursor movement or text change incrementally, but if we get a second in either category we could flip into batch mode where we defer any further updates until it's time to render to the screen, then recompute everything async.

Not sure if you're interested in investigating this but since you're already doing a great job in other areas, I thought I'd suggest it.

Refs https://github.com/atom/atom/issues/5025.
Any further discussion should probably actually take place there.

@as-cii Awesome speed improvement :zap: :smile:


[BUG] Value is changing on page load

How can I make it only triggers when title changes.
The problem is I can't manually change the slug if I want to. It convert on page loads every time

You can just upload a video straight into GitHub comments, but I think I know what you mean and I believe I have a solution.

Fancy checking out the PR @tahir-asadov and seeing if it solves your issue? I basically had the same setup while testing so it should be A-OK! 🤞

Didn't work. I'm new to Alpine JS.
Maybe I'm doing something wrong.
I'll comment if I resolve the issue

Are you using the PR version and adding .lazy?

I've pushed that version to NPM, it's 1.1.1, change your package.json to use that version and install. It should be working.

x-slug.lazy fixed the issue.
Thank you.


scylla_cluster: introduce cluster.default_wait_* properties

moving the setting those default timeout into the cluster __init__ and a user of the cluster (i.e. dtest) can set those higher if needed.
also removed timeout argument from _start_scylla since no code in ccm or dtest were using it.

@bhalevy don't know if the best of interface, but it would allow for some test to set it higher before starting cluster/nodes


Fix for No podspec found for `flutter_user_agentx'

Not sure if I did this right since I don't really work on iOS as much as android.

Thanks for the PR, I believe the flutter_user_agentx version was an unofficial release done by someone else, who never publicly published their repo (and incorrectly pointed the source to this).
The package name in this repo won't need to be changed.


i3808 missing Fortran compiler config for macOS M1 runner

Description
Closes #3808
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

[x] Bug fix (non-breaking change which fixes an issue)

Key checklist:

[x] No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
[x] All tests pass: $ python run-tests.py --all (or $ nox -s tests)
[x] The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

I did not create this PR from a branch through my fork. The PR tests are working here since the erroneous cached wheel is removed prior during the nox session invocation. I have just triggered a workflow run from this branch here: https://github.com/pybamm-team/PyBaMM/actions/runs/7835711305

From the workflow run, I forgot that pybamm_install_odes will fail on Python 3.12 on Linux and macOS. I will comment that out in the workflow file rather than removing entirely so that we can remember to bring it back someday.

I did not create this PR from a branch through my fork. The PR tests are working here since the erroneous cached wheel is removed prior during the nox session invocation. I have just triggered a workflow run from this branch here: https://github.com/pybamm-team/PyBaMM/actions/runs/7835711305

Ok if I forget to come back and check if it worked, just ping me

Triggered another run for the scheduled tests here: https://github.com/pybamm-team/PyBaMM/actions/runs/7835843395


How do i add subtitle from url?

Is there a way to specify subtitle using URL

Not that I'm currently aware of. I'll need to look in to this more, as from my understanding, subtitles are to be included with the regular HLS stream.


Read consistency support for Datastore

It would be great if we could specifiy the read consitency like the java sdk can for google datastore.

Sounds good to me! Any interest in working on a PR?

I don't believe I am a good enough coder to implement this myself.

No problem, I've put together a PR in #1259 -- please share any thoughts!
$ npm install --save stephenplusplus/gcloud-node#spp--1218


Test: add nameserver to regex_remap test.

This test uses "localhost" and therefore should have a local nameserver.

Looks like a bad cherry pick.

Fixed.

[approve ci autest]

Gah. How can this fail -
Running Test traffic_dump_sni_filter:.. Failed


Exercise #5: Maybe Level 5 - or()

I need help with the method or() on level 5 in the self exercise 5.
"another variant is the or method which takes in a Supplier of a Maybe as the alternative. If a value does not exist in Maybe, the alternative Maybe produced by the supplier is returned."
Below is my code: I don't know how to cast the Supplier or the return value for this to work.

this is the error message that I receive:

I would really appreciate it if someone could give me some guidance or explain the logic.

Hi there! I think the issue lies in the difference between the variable mo, which is typed as a Maybe, and the Maybe you will get from the Supplier, which is a Maybe. Thus, you will need to find a way to convert / re-type the result of the Supplier's get() function to a Maybe.
What I did was to take in a Supplier that could return results belonging to child classes of Object using Supplier<? extends Maybe<? extends T>>. Within the if clause of the or method, I first casted supplier.get() to a Maybe<? extends T>, then retrieving its thing and returning it in a Maybe object. Hope this helps!

Hi there, my approach was identical to Jamie's. To add on, I used an orElse to retrieve the thing and then used a constructor to create a new Maybe before returning it. Hope it helps:)

@jamielfh @wjiayis thank you guys so much, I really appreciate it! That solved the problem!


How to Use ImageSlideshow in a single UITableViewCell

Hello guys, my situation is a bit special, and I can not solve it.
I want to use ImageSlideShow to only apply to one of the cells in the tableView. Is there any possible way to do that?

i have same issue.
EXC_BAD_ACCESS error occurs.

Have you guys solve it? I mean I can show but just the first image and my control page is not visible?

@marcelfagadariu show us how you did it.

Hallo, try to add ImageSlideshow as subview to an outlet, works for me


Bug while running the robocup enviroment

Hi guys!
I'm trying to run your  run_mad4pg.py script from the robocup examples but it's not working for me. I'm using a ubuntu 20.04 with a python 3.7. Here's the command I used to run
python examples/robocup/recurrent/state_based/run_mad4pg.py.
And I will attach here the error returned, thank you all in advance!
2021-11-11 18:06:33.030679: I tensorflow/stream_executor/cuda/cudart_stub.cc:29] Ignore above cudart dlerror if you do not have a GPU set up on your machine.
2021-11-11 18:06:36.869296: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libcuda.so.1'; dlerror: libcuda.so.1: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /home/pedro/anaconda3/envs/mava/lib/python3.7/site-packages/cv2/../../lib64:/home/pedro/anaconda3/envs/mava/lib
2021-11-11 18:06:36.869371: W tensorflow/stream_executor/cuda/cuda_driver.cc:269] failed call to cuInit: UNKNOWN ERROR (303)
2021-11-11 18:06:36.869428: I tensorflow/stream_executor/cuda/cuda_diagnostics.cc:156] kernel driver does not appear to be running on this host (pedro-All-Series): /proc/driver/nvidia/version does not exist
Traceback (most recent call last):
  File "examples/robocup/recurrent/state_based/run_mad4pg.py", line 24, in <module>
    from mava.systems.tf import mad4pg
  File "/home/pedro/anaconda3/envs/mava/lib/python3.7/site-packages/mava/systems/tf/mad4pg/__init__.py", line 16, in <module>
    from mava.systems.tf.mad4pg.execution import (
  File "/home/pedro/anaconda3/envs/mava/lib/python3.7/site-packages/mava/systems/tf/mad4pg/execution.py", line 25, in <module>
    from mava.systems.tf.maddpg.execution import (
  File "/home/pedro/anaconda3/envs/mava/lib/python3.7/site-packages/mava/systems/tf/maddpg/__init__.py", line 21, in <module>
    from mava.systems.tf.maddpg.system import MADDPG
  File "/home/pedro/anaconda3/envs/mava/lib/python3.7/site-packages/mava/systems/tf/maddpg/system.py", line 37, in <module>
    from mava.systems.tf.maddpg import builder, training
  File "/home/pedro/anaconda3/envs/mava/lib/python3.7/site-packages/mava/systems/tf/maddpg/builder.py", line 35, in <module>
    from mava.wrappers import DetailedTrainerStatistics
  File "/home/pedro/anaconda3/envs/mava/lib/python3.7/site-packages/mava/wrappers/__init__.py", line 16, in <module>
    from mava.wrappers.debugging_envs import DebuggingEnvWrapper, TwoStepWrapper
  File "/home/pedro/anaconda3/envs/mava/lib/python3.7/site-packages/mava/wrappers/debugging_envs.py", line 30, in <module>
    from mava.wrappers.pettingzoo import PettingZooParallelEnvWrapper
  File "/home/pedro/anaconda3/envs/mava/lib/python3.7/site-packages/mava/wrappers/pettingzoo.py", line 26, in <module>
    from supersuit import black_death_v1
  File "/home/pedro/anaconda3/envs/mava/lib/python3.7/site-packages/supersuit/__init__.py", line 1, in <module>
    from .generic_wrappers import * # NOQA
  File "/home/pedro/anaconda3/envs/mava/lib/python3.7/site-packages/supersuit/generic_wrappers/__init__.py", line 1, in <module>
    from .frame_skip import frame_skip_v0 # NOQA
  File "/home/pedro/anaconda3/envs/mava/lib/python3.7/site-packages/supersuit/generic_wrappers/frame_skip.py", line 3, in <module>
    from pettingzoo.utils.wrappers import BaseWrapper, BaseParallelWraper
ImportError: cannot import name 'BaseParallelWraper' from 'pettingzoo.utils.wrappers' (/home/pedro/anaconda3/envs/mava/lib/python3.7/site-packages/pettingzoo/utils/wrappers/__init__.py)```

Hey @Pvcunha :) Let's try and get you up and running. After building Mava did you also run the RoboCup builder?
Step 1: make build
Step 2: make build_robocup
Let me know if it works.

Hey @Pvcunha, please also check whether the other examples run or not (one of the debugging examples would be great, e.g. examples/debugging/simple_spread/feedforward/centralised/run_mad4pg.py). If you're trying to run outside of docker, something probably went wrong during your installation of the Mava dependencies.

Hi @DriesSmit yeah I did it, after thoose commands I tried to run the robocup example and then I got that error :(

Hello @mmorris44, I tried outside docker in a conda env. I will try to install again later this week and then I come back to you guys with an update, Thanks!

Hey @Pvcunha :) I think I found wat was wrong. See this PR. Let me know if it is working now.


[MatterYamlTests] Allow enum names in YAML instead of raw values

Problem
When writing tests using YAML, when a test specify an enum value it can not be used as if, one would need to write the raw value. As a result there are often steps where the "name" of the enum value is added next to the raw value.
This PR allows names to be specified instead of raw values. It also introduce a UnknownEnumValue that is automatically calculated based on the values from the enum definitions.
Some tests may want to specify the invalid value they want to use, for those case writing EnumName.UnknownEnumValue(66) is allowed if the invalid value is 66.
For now using an enum name is not enforced but I think we should ultimately do it when used in a as it make the test clearer and matches the test plan better.
The PR also updates some tests. Most of them are just valid tests that does not fit the new syntax but for 2 of them that looks like errors:

src/app/tests/suites/certification/Test_TC_TSTAT_2_1.yaml
src/app/tests/suites/certification/Test_TC_DRYERCTRL_2_1.yaml

I have updated the PR to be a little but more readable (I hope) and with some additional tests.


Proposal: kill bitcoin payment method type

Acknowledging

That maintaining code for a feature always takes time (eg. tests need to be updated, bugs...)
That unmaintained features can contain security issues, or be a vector for privilege escalation
That the bigger/more complex the code base, the harder it is for newcomers to get on board

And regarding the fact that...

The feature is not used since more than one year (last created was 2018-04-15)
There's very few of them (17 total)
We currently have no plan to re-support it in a near future
If we want to re-implement this, we'll need a lot of work on it in any case

I propose that
We kill the bitcoin payment method entirely:

Mark PMs as deleted in the DB
Remove all references from API code
Remove all references and translations from Frontend code

I agree. Stripe doesn’t support it anymore.
I’d love to abstract the concept of “manual donation” so that a host could define multiple manual ways. This would give them a way to accept crypto donations.
E.g. give money by making a bank transfer, give money by donating to this BTC address, etc.
It’s basically always the same mechanism: we send you special instructions by email and the host has to confirm once they have received the money.

+1

Thanks for the quick feedback!


Parse data back into my app?

I have my own homegrown ticketing system in my rails app. I was able to use this gem to create and update tickets in zendesk when they are created in my app.
How would I go the other way? Like, lets say a user opens a ticket, and then I respond from within zendesk. How could I get it back into my app to keep everything synced up?

You would probably want to poll the incremental ticket updates endpoint.
The documentation is here: https://developer.zendesk.com/rest_api/docs/core/incremental_export
I believe there is also a beta for HTTP targets which you can use to post-back to your application. But you may need to email<EMAIL_ADDRESS>for more information.

Here is a summary of the solution provided:
I believe what you're trying to do can be accomplished through our apps ecosystem.
Here is a link to the full documentation for this: https://developer.zendesk.com/apps/docs/agent/introduction
Essentially you would make an event listener in the app to fire on an agent reply from within Zendesk and send the comment as a XHR back into your app.


more narrow check for /gems/ for caller_lines search

also fix specs and account for case
related #410

This is a 🐞 bug fix.

[x] I've added tests (if it's a bug, feature or enhancement)
[ ] I've adjusted the documentation (if it's a feature or enhancement)
[x] The test suite passes (run bundle exec rspec to verify this)

Summary
More narrowly scope the search for caller_lines to find the template name in the overridden rails render method.
Context
#410
How to Test

Add gem 'haml-jets' to Gemfile
In a view, render out to another partial that is haml
It should now find the partial properly and render successfully

Version Changes
Patch

Released in v2.3.8


Add missing dependency

This one is only used for the catch (Exception $ex) right? Not sure if it's better to include it, or just to leave it out in the file itself.

Yes. Probably better to remove it.

@Techbrunch It's still being used here and on 2 other occurrences in the file. I think we can create this exception ourselves?


Add Endpoint as a resource with no spec for dependent resources

Reported by used:
ERROR ReconciliationDispatcher.java (64) Error during event processing ExecutionScope{ resource id: ResourceID{name='test-resource', namespace='default'}, version: 42334818} failed.
io.javaoperatorsdk.operator.AggregatedOperatorException: Exception(s) during workflow execution. Details:

com.example.test.PostgresEndpoint -> java.lang.IllegalStateException: No spec found on resource io.fabric8.kubernetes.api.model.Endpoints
  at io.javaoperatorsdk.operator.ReconcilerUtils.noSpecException(ReconcilerUtils.java:146)
  at io.javaoperatorsdk.operator.ReconcilerUtils.getSpec(ReconcilerUtils.java:111)
  at io.javaoperatorsdk.operator.processing.dependent.kubernetes.ResourceUpdatePreProcessor.matches(ResourceUpdatePreProcessor.java:18)...
Caused by: java.lang.NoSuchMethodException: io.fabric8.kubernetes.api.model.Endpoints.getSpec()
    at java.base/java.lang.Class.getMethod(Class.java:2108)
    at io.javaoperatorsdk.operator.ReconcilerUtils.getSpec(ReconcilerUtils.java:108)
    ... 15 more

We probably need to push for HasSpec & HasStatus support in the fabric8 client to address these issues once and for all.

We probably need to push for HasSpec & HasStatus support in the fabric8 client to address these issues once and for all.

totally, comes up again and again, can pick it up after the helm issue

Yes, there's another similar issue in QOSDK and RBAC generation


Add all the options to the Runner from other repos

#64 mostly -> especially with the video sampler


Make result counting optional and enable only for pagination

I realized before that the result counting query runs every time (e.g. for patch and remove) which is not very efficient and is unnecessary.

:+1: thanks for fixing that.


Upload attachment?

Thank you for the work on the library, it's exactly what I'm looking for!
I'm just wondering if it's possible to attach an image to a FeedPostRequest object, when posting a request?

Hi.
Please refer to the test code.
https://github.com/uakihir0/bsky4j/blob/main/core/src/test/java/bsky4j/bsky/feed/PostTest.java#L53

Thank you, I found that right after I posted!


Demo is not working

When saving the image to the public keeps uploading forever. Logged with my github account.

Damn nice catch! it's now fixed, sorry about this 😬


Add CTE receive and sampling in Bluetooth stack

The PR provides CTE receive and sampling functionality in BLE stack. It includes all three parts of implementation: controller, HCI, host.
The controller part:

Added changes in radio implementation to enable CTE reception for periodic advertising scan events.
Added API to get information about antenna id used to measure RSSI.
Added API to get CTEInfo PDU field parsed by radio peripheral.
New noder_rx type introduced. Thanks to that we are able to manage memory for required collected IQ samples separately from memory for regular PDUs. The node_rx_iq_report has node_rx_hdr, so it may be processed by regular received nodes path up to HCI.
Added enable or disable CTE receive in LL thread and ULL. The CTE enable and sampling configuration are provided to LLL via double buffer (stored in lll_sync). That functionality works in a similar way like double buffered PDUs in advertising role.
Added handling of HCI_LE_Set_Connectionless_IQ_Sampling_Enable HCI command.
Added dropping of unreported node_rx_iq_repots if CTE receive was disabled by Host in the meantime (e.g. disable operation was preempted by periodic advertising sync event and new node_rx_iq_report was put in receive path).
Added unit tests for handling of HCI_LE_Set_Connectionless_IQ_Sampling_Enable.

The HCI part:

Added HCI_LE_Set_Connectionless_IQ_Sampling_Enable command.
Added HCI_LE_Connectionless_IQ_Report.

The host part:

Added API to enable or disable CTE receive and sampling.
Added API to register callbacks for IQ samples report receive.
Added handling of HCI_LE_Connectionless_IQ_Report event.

The PR is long. I'm sorry for that. Splitting it at this stage (in my humble opinion) would increase the time it may be merged to master.

The PR provides CTE receive and sampling functionality in BLE stack. It includes all three parts of implementation: controller, HCI, host.
The controller part:

Added changes in radio implementation to enable CTE reception for periodic advertising scan events.
Added API to get information about antenna id used to measure RSSI.
Added API to get CTEInfo PDU field parsed by radio peripheral.
New noder_rx type introduced. Thanks to that we are able to manage memory for required collected IQ samples separately from memory for regular PDUs. The node_rx_iq_report has node_rx_hdr, so it may be processed by regular received nodes path up to HCI.
Added enable or disable CTE receive in LL thread and ULL. The CTE enable and sampling configuration are provided to LLL via double buffer (stored in lll_sync). That functionality works in a similar way like double buffered PDUs in advertising role.
Added handling of HCI_LE_Set_Connectionless_IQ_Sampling_Enable HCI command.
Added dropping of unreported node_rx_iq_repots if CTE receive was disabled by Host in the meantime (e.g. disable operation was preempted by periodic advertising sync event and new node_rx_iq_report was put in receive path).
Added unit tests for handling of HCI_LE_Set_Connectionless_IQ_Sampling_Enable.

The HCI part:

Added HCI_LE_Set_Connectionless_IQ_Sampling_Enable command.
Added HCI_LE_Connectionless_IQ_Report.

The host part:

Added API to enable or disable CTE receive and sampling.
Added API to register callbacks for IQ samples report receive.
Added handling of HCI_LE_Connectionless_IQ_Report event.

The PR is long. I'm sorry for that. Splitting it at this stage (in my humble opinion) would increase the time it may be merged to master.

Resolved merge conflicts.

Updated commit messages.

Fixed issues in unit tests. Added commit that fixes builds of controller for Openisa (RiscV) platforms.

Rebased due to failing clang/llvm builds.

Changes implementation of hci_df_set_cl_cte_rx_enable to hide an issue with Bluetooth Core Spec. Vol 4,Part E, sec 7.8.82. There is no right way to set receive of AoD CTE for devices with single antenna. The spec requires minimum antenna switch pattern to have at least two antennas.
To hide that from end user, the function verifies cte_type. If there is an AoA type enabled, slot_durations, num_ant_ids and ant_ids must contain valid values.
Besides that cte_type is stored in struct bt_le_per_adv_sync. hci_le_df_connectionless_iq_report uses it to drop IQ sample reports that has type not set in cte_type.

Added commit with sample application for CTE receive and sampling.

Before merge of this PR, that must be merged: https://github.com/zephyrproject-rtos/zephyr/pull/32358

@joerchan @jhedberg could you take a look on host part of the PR?
@nashif could you take a look on sample application?

I've found an issue in lll_sync.c isr_rx, handling of CTE receive while CRC was not ok scheduled ull unconditionally.

Before merge of this PR, that must be merged: #32358

This is merged now, please rebase.

Before merge of this PR, that must be merged: #32358

This is merged now, please rebase.

Done

@Thalley @joerchan @cvinayak @kruithofa could you please review?

@cvinayak All changes requested were implemented.

Fixed issue with coding rule - 5.7 A tag name shall be a unique identifier.
Referring to failing rules 5.1 and 5.2 I've created an issue: https://github.com/zephyrproject-rtos/zephyr/issues/34823

All requested changes are done.

updated commits related with: host, sample application, unit tests
added commit to use common mem_link_rx pool instead of dedicated one for node_rx_iq_report
added commit that fixes wrong cte_type in periodic advertising reports.

Coding guidelines still fail.

@cvinayak Commit message corrected as well as: removed printk and fixed code formatting in ull_df_internal.h.
I had to update commit that fixes builds for non Nordic platforms. There were missing forward struct lll_df_sync declaration. With that unit tests for OpenISA should pass.

@Thalley latest suggestions implemented.


SSMS restore database error 31 in docker

### SSMS restore database error 31
I have issue with restore backup from database inside SSMS. In SSMS, I select Database -> restore database -> Device -> Select backup devices -> Add -> bb.bak after that I click on added file into list and I want to see "Contents" error bellow "Error" and if I go next I'm not able to restore my database.
SSMS version: 17.9
### Error:
TITLE: Microsoft.SqlServer.Smo

System.Data.SqlClient.SqlError: Read on "/var/opt/mssql/backup/back.bak" failed: 31(A device attached to the system is not functioning.)

For help, click: http://go.microsoft.com/fwlinkProdName=Microsoft+SQL+Server&ProdVer=14.0.17285.0((SSMS_Rel_17_4).180821-0238)&LinkId=20476

I have tried to solve this error with full rights on whole path to backup dir inside the docker but it didn't help. After ls -la /var/opt/mssql/backup everything was setup to 777 (see output below).
My docker-compose.yml see below:
version: "3.1"
services:
  db:
    image: "microsoft/mssql-server-linux"
    container_name: mssql-server
    environment:
      SA_PASSWORD: "123456Aa+"
      ACCEPT_EULA: "Y"
      MSSQL_PID: "Developer"
    volumes:
     - ./database/backup:/var/opt/mssql/backup
    command: >
      bash -c "chmod -R 777 /var/opt/mssql/backup/* && /opt/mssql/bin/sqlservr"
    ports:
     - "<IP_ADDRESS>:6000:1433"

### ls -la /var/opt/mssql/backup
mssql-server | total 6900
mssql-server | drwxrwxrwx 1 1000 staff       0 Nov  8 12:06 .
mssql-server | drwxr-xr-x 3 root root     4096 Nov  8 15:25 ..
mssql-server | -rwxrwxrwx 1 1000 staff    2413 Nov  8 12:06 back.sql
mssql-server | -rwxrwxrwx 1 1000 staff 7056896 Nov  8 12:06 back.bak

@DrRee
Sorry, I can not reproduce this issue on my environment. (copy AdventureWorks database from host to container path:/temp)
ls -la /temp
-rwxr-xr-x 1 root root 48749568
Please make sure the sql server account connected to SQL database instance has enough permission to read the file.
Also have a check:
Restore a SQL Server database in a Linux Docker container

I also have this issue, were you able to solve it?

Perhaps this post could help. I’ve seen this issue when the database being restored is larger than the available space in Docker.
https://danielssilva.dev/2019-09-09-MODIFY-FILE-encountered-operating-system-error-31(A-device-attached-to-the-system-is-not-functioning.)-while-attempting-to-expand-the-physical-file/

Link above is dead now. It's on archive.org though: https://web.archive.org/web/20201212000307/https://www.danielssilva.dev/2019-09-09-MODIFY-FILE-encountered-operating-system-error-31(A-device-attached-to-the-system-is-not-functioning.)-while-attempting-to-expand-the-physical-file/
Dear mssql team: please improve your error messages.
I'm constantly having to guess what's going on because error messages are too vague.

Double-check the CASE of your file itself and that it matches... I noticed these types of issues when going from a case-insensitive environment to a case-sensitive one.  It seems to match in your description.
Beyond this, double-check the volume mount for SQL Server instance...
I can say that I have run backup/restore commands in/out of docker without issue in the past.... I did it a lot for testing scenarios.

For me, I was getting this error when Docker was running out of space. My environment: WSL2 Ubuntu on Windows 11 with Docker Desktop 4.15.0 and no extra configuration files.
I could restore a 16 and 67 GB backup; but when I tried to restore a 77 GB backup I would get 31(A device attached to the system is not functioning.).
I tried to follow Microsoft's Expand the size of your WSL 2 Virtual Hard Disk guide, but this guide doesn't expand the correct VHD for our Docker problems. Using this SO answer to correctly find the Docker VHD %LOCALAPPDATA%\Docker\wsl\data\<disk name>.vhdx I was able to follow the Microsoft guide, increase the correct VHD, and restore my 77 GB backup.
Hopefully this helps someone since we're not getting Docker specific errors back and have to dig a little bit into what's going on.

Intenta eliminando archivos con extensión .bak dejados dentro del contenedor:
docker exec -it "$CONTAINER_NAME" rm "/var/opt/mssql/backup/$BACKUP_FILE"
Donde $CONTAINER_NAME es una variable de ambiente cuyo valor es el nombre del contenedor con SQL Server y $BACKUP_FILE contiene el nombre de tu archivo backup.
En tu caso sería:
docker exec -it "mssql-server" rm "/var/opt/mssql/backup/back.bak"
--- English
Try deleting files with .bak extension let inside container:
docker exec -it "$CONTAINER_NAME" rm "/var/opt/mssql/backup/$BACKUP_FILE"
Where $CONTAINER_NAME is an environment variable with the container name with SQL Server as value and $BACKUP_FILE has the backup file name.
In your case:
docker exec -it "mssql-server" rm "/var/opt/mssql/backup/back.bak"

Just wanted to chime in that I had the exact same problem (error message) when trying to restore the db.
I solved it by allowing docker to use more disk space. I configured this in the docker desktop dashboard

Another thing I did while trying to solve the error message (idk if it is relevant but it might help others) was to ensure that the .bak files I were trying to restore were actually readable by the mssql user that is the default user in the docker image.

Thanks @birgersp , increasing virtual disk limit worked for me.


add hostname, python version and capabilities definition to system info output

Added small improvements and clarifications to ilab system info output

@jeremyeder can you update the PR description/commit message to more accurately reflect the changes?

Thanks @jeremyeder - once linting errors are fixed this LGTM


Refactor python script/gradle and (hopefully) add Mac M1 support

automates the build process outlined in #34 (comment) without the virtual environment part (uses default python as before).
renamed and changed python script util to support pre and post scripting (needed for renaming binaries after building dist). likewise changed build.gradle to support pre and post scripts. also added os/mac_arm_64 folder.
postscript also has option for automatic installation to Ghidra/Extensions folder though this is neither enabled nor tested.
seems to be working on mac m1 pro 13.3.1 with Ghidra 10.3, but untested on other platforms and should probably be tested by other m1 users.

i have an M1 mac mini and can try this out shortly, ideally in the next few days.

so i know that #50 would supersede this (and for reasons I agree with) but would the modified python/gradle script still be useful?
if not then this pr can be closed altogether i think.

Thank you for your contribution - this has been superseded by https://github.com/mandiant/Ghidrathon/commit/32f3969e09a5d29197cabbc28d93dc9c572d7e45.


Require libXext-devel for sip on RHEL

This extra dependency is already present for Fedora (#25891), but it looks like RHEL 8 will need it too. The dependency seems to be otherwise handled on RHEL 7, but including it explicitly shouldn't hurt.
This package is part of base on RHEL 7: https://mirrors.edge.kernel.org/centos/7.9.2009/os/x86_64/Packages/libXext-devel-1.3.3-3.el7.x86_64.rpm
This package is part of appstream on RHEL 8: https://mirrors.edge.kernel.org/centos/8.3.2011/AppStream/x86_64/os/Packages/libXext-devel-1.3.4-1.el8.x86_64.rpm

is shiboken/pyside available on RHEL and should we try to use it rather than sip/pyqt5 for cleaner licensing?

It is not, unfortunately. Neither RHEL 7 nor 8 have shiboken2.


Unable to compile under .net 3.5

Compilation error under .net 3.5

Sorry, but 3.5 is not supported.
Please see https://github.com/ButchersBoy/MaterialDesignInXamlToolkit/wiki/.Net-4.0-Compatibility-&--Visual-Studio-Versions


Introduce a new marker for quantities

Introduce a marker to differentiate IComparable (double, string...) from quantities.
That allows to type a little stronger generic APIs working on quantities.

We can do this, but could you list a couple of usecases where this is helpful?
I have yet not had the need to work with any type of unit.

I have encapsulated the UnitsNet units into some project classes to make sure that the system types could be changed somedays without breaking everything. Just a carefull approach when integrating external libs.
So there is one class for Force, one class for Length etc...
Below I removed most of implementation and just kept the BaseUnitName method.
At the moment there is no common types for Length and Force which forces the definition of  BaseUnitName in every subclass.
If Length and Force would inherit from IQuantity, then BaseUnitName could be pull up into the baseclass assuming of course that the ToString method be defined in IQuantity interface.
public class ForceDataType : SIDataType
    {
        private ForceUnit _baseUnit;

        public ForceDataType()
            : this(ForceUnit.Newton) {}

        public ForceDataType(ForceUnit baseUnit)
        {
            _baseUnit = baseUnit;
        }

        public override string BaseUnitName()
        {
            return _baseUnit.ToString();
        }
    }

    public class LengthDataType : SIDataType
    {
        private LengthUnit _baseUnit;

        public LengthDataType()
            : this(LengthUnit.Millimeter) {}

        public LengthDataType(LengthUnit baseUnit)
        {
            _baseUnit = baseUnit;
        }

        public override string BaseUnitName()
        {
            return _baseUnit.ToString();
        }
    }

I understand your careful approach, especially for serializing I would not trust a 3rd party library not changing the unit enum values, although I try to avoid these types of breaking changes.
Your usecase seems a bit specific though, not sure if this is something anyone else will benefit from?
If I understand correctly, you basically need a common interface to expose the string BaseUnitName() method, which would return "Millimeter" for Length and "Newton" for Force unit.

Just curious, is there a reason you use Millimeter for Length? Since Meter is Units.NET's base unit for Length. Do you need to choose your own base unit name, or can you use Unit.NET's choice of base unit?

What do you use BaseUnitName() string for? Just trying to understand your usecase better. Is it combined with a double value anywhere, or do you only care about units?

For 1)
Yes, the device I am communicating with understands millimeter and below. So I really want to manipulate millimeters. Choosing the base unit would be great. It would probably mean a tradeoff between precision of unit and loss of precision. As an exemple: choosing millimeter as base unit would give a high precision when converting to centimers and microns, but when converting to killometers, well I guess it is ok to loose some precision.
The base unit from Unit.NET are ok for us.
For 2) Some values are stored during a process. So ideally data structure would look like this:
class Record
{
   IQuantity
   List<IComparable>
}

For each sensor, there would be a record. So in the end the system ends up with a list of records.
One feature is to push those data into a report (csv file in this case) like this:
"s","mm"
0, 10
1, 15
2, 10

I still don't fully understand why you need IQuantity in the Record class though. Are you using it for anything else than to call BaseUnitName()? Can't you just store a string Unit property/field in Record instead?

Just checking in on this, are you still pursuing this idea? I currently don't have a good enough understanding of what you are trying to accomplish to say whether this is a good idea or not.

Just a heads up, I am about to delete develop and stable branches, and returning to using a master branch. It seems pull requests can't be edited to change target branch, so you will have to create a new PR targeting master instead.


Make request timeout and TLS properties configurable.

Related to https://github.com/wavefrontHQ/wavefront-sdk-go/issues/6.
This is an extension of PR #111, which I closed due to having introduced undesired merge commits in git history.
Detailed description:
Make request timeout and TLS properties configurable.
Add new configuration options to README.
Signed-off-by: Devon Warshaw<EMAIL_ADDRESS>Signed-off-by: Jeanette Booher<EMAIL_ADDRESS>Signed-off-by: Supraja Narasimhan<EMAIL_ADDRESS>

Hi @oppegard and @LukeWinikates, this PR is an extension of #111 with a cleaner git history.  I explained the decision to create this PR in this comment in #111. Thank you for helping me through this as I learn.

Hello @keep94, nice to meet you! Thank you for taking the time to review -- I will start addressing these today.

Hello @keep94, nice to meet you! Thank you for taking the time to review -- I will start addressing these today.

I made the changes and left the comments open so you can decide if they can be resolved. Thank you!

Hello @keep94! Coming back to this after the holidays and I made the changes you requested.
Overall, your feedback exposed me to concepts and code style that I can try to apply in the future, too! I really appreciate it. 🙏🏽

I will have time Friday afternoon to take a look. Is that ok?

@suprajanarasimhan I just reviewed your PR. I agree with what oppegard has said in his review, but for some reason my comments aren't showing up in this conversation page.

I will revisit this feedback later today -- thank you!


Support ext install pub.name

We should support the ext install pub.name global command. This should bypass extension searching and simply ask to install the extension.
cc @sandy081

Related #26389


Error in macOS

Following the instructions to build kevm I was getting errors when running make build on macOs BigSur (version 11.0.1).
bash --version:
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin20)

make --version
GNU Make 3.81

Fixes

Add KEVM to path:

export PATH=$(pwd)/.build/usr/bin:$PATH

Add the following line at the beginning of Makefile:

SHELL = /bin/bash -o pipefail

In the kevm file (in the root of the repository) delete the character & in the end of lines 74 and 75:

 llvm)      kompile_opts+=( --md-selector 'k & ! nobytes & ! node' )                         ;;
 node)      kompile_opts+=( --md-selector 'k & ! nobytes & ! standalone' --no-llvm-kompile ) ;;

Finally, running the following command should work:
make build-haskell build-provex -j2

This solution worked for me on macOS Monterey (version 12.2.1).
Additionaly, I ran into the solc: command not find error.
This can be solved installing solidity compiler (version > 8.0).
brew update
brew upgrade
brew tap ethereum/ethereum
brew install solidity

Further details are referred to the installation instructions.

Actually 2. can be also fixed with installing a new version of bash with Homebrew. The old version that is default on macOS doesn't support some of the features in Makefile, that is why it is complaining about the &.
Both 1. and 2. have been addressed in the updated README, @ehildenb should I close this?


Ref/use galaxy instead of sector

Codecov Report

Merging #34 (fe2dba1) into dev (7b7d63c) will increase coverage by 0.07%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##              dev      #34      +/-   ##
==========================================
+ Coverage   42.14%   42.22%   +0.07%
==========================================
  Files          23       23
  Lines        1108     1106       -2
  Branches      195      195
==========================================
  Hits          467      467
+ Misses        632      630       -2
  Partials        9        9

Impacted Files
Coverage Δ

pythonium/main.py
0.00% <0.00%> (ø)

pythonium/metrics_collector.py
0.00% <0.00%> (ø)

pythonium/game_modes.py
21.96% <66.66%> (ø)

pythonium/game.py
53.17% <75.00%> (-0.19%)
:arrow_down:

pythonium/galaxy.py
97.77% <100.00%> (+0.02%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b7d63c...fe2dba1. Read the comment docs.


add font awesome icons to figure link labels

currently the figure link labels look as follows:

However, we want two relevant font awesome icons to show up as below:

The first step is to enqueue the font awesome stylesheet from a cdn, like this one.
To actually use a particular icon, you use the  tag, as follows:

You can search the font awesome library here.

let icon1 =  ;     let icon2 = ;
  added similar icons to two links:
   firstLink.appendChild(document.createTextNode(info_obj['scienceText']));
...
   secondLink.innerHTML = icon2 + + secondLink.innerHTML;

added fa icons;
https://github.com/ioos/sanctuarywatch/blob/ebf79dd83deb873765f7d05c125001023a90c99f/themes/Sanctuary_Watch/assets/js/script.js#L843
from 843 to 860


Port request: MPFR

I have been trying to add a port of MPFR, a natural complement to MPIR. There is a Github repository at BrianGladman/mpfr, which includes Visual C++ build files but I haven't been able to understand the documentation for cloning with git.
There are the following problems:

First, I can't figure out how to use the vcpkg_from_github command to retrieve the latest repository from GitHub. It is problematic because it seems to want a tag (together with a hash) for a particular version of the library. But if I perform a clone in Git, it automatically retrieves the latest, essentially the behaviour I was hoping for with the vcpkg/CMAKE interface. It's impossible to specify a tag because there aren't any tagged releases in the BrianGladman/mpfr fork.
Second, the HEAD_REF switch to vcpkg_from_github doesn't seem to allow me to specify the master branch. My understanding was that the HEAD_REF switch allowed the user to bypass the requirement to specify a tag and a hash value, but when I write a switch like REF "master", it returns the error "Package does not specify REF.  It must built using --head."
Finally, from time to time when I have tried other parameters, I have gotten errors from the file command indicating that it can't create a package directory.

Thanks for starting the port and the questions!
We've just published some docs you might find useful: https://vcpkg.readthedocs.io/en/latest/maintainers/vcpkg_from_github/.

I can't figure out how to use the vcpkg_from_github command to retrieve the latest repository from GitHub.

We guard "unstable" fetches like this behind the --head option to install, to alert the user that even though the package works today it might break tomorrow if they uninstall and reinstall. It was added very recently, so we haven't gotten it fully documented yet, but the basic usage is:
vcpkg install --head mpfr

It's impossible to specify a tag because there aren't any tagged releases in the BrianGladman/mpfr fork.

You can also use a raw git commit sha, and it works really well! As an example, take a look at ms-gsl

My understanding was that the HEAD_REF switch allowed the user to bypass the requirement to specify a tag and a hash value, but when I write a switch like REF "master", it returns the error "Package does not specify REF. It must built using --head."

The idea is that a package will specify both REF and HEAD_REF. This means most users can get a nice, stable version that we know works well with everything else, but you can also easily access the latest master branch by installing with --head.

Finally, from time to time when I have tried other parameters, I have gotten errors from the file command indicating that it can't create a package directory.

I'd really like to fix any bugs here; if you can capture the command and output next time it happens that would be really helpful!

I had written a port for MPFR quiet a time ago. Since I had problems to get the Visual Studio projects from BrianGladman working at that time (I do not remember what exactly the problem was, but I think it was because you had to change the dependencies to MPIR manually). So I decided to roll out a minimal CMakeLists.txt for MPFR.
I pushed the port to a branch at https://github.com/albertziegenhagel/vcpkg/tree/add-mpfr so you can have a look at it. Since I am not really a user of MPFR myself (just needed it to build CGAL) I am not sure whether I missed to configure some special options, so I decided to not make a pull request yet.
It would definitely be nice if one could add assembler support, to get an optimized version of MPFR (which would actually be a good idea for MPIR as well).


Add sideinputs to the RunInference Transform

Part 1 of https://github.com/apache/beam/issues/24042

RunInference transform will accept side input emitting ModelMetadata.
The Side input must emit one value at a time. It should be compatible with AsSingleton view
All the metrics are tagged with unique id so that it would be easy to differentiate the metrics calculated by different models.

This method follows slowly changing side input patterns as described in https://beam.apache.org/documentation/patterns/side-inputs/
TODO:
Part 2: WatchFileTransform and it's use case. It will come in the following PRs.
Part 3: DLQ for error outputs.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Python 3.8 PostCommit

R : @damccorm

Run Python 3.8 PostCommit

Run Python 3.8 PostCommit

Run Python 3.8 PostCommit

Run Python 3.8 PostCommit

Run PythonDocker PreCommit

Run Portable_Python PreCommit

Run PythonDocker PreCommit

Run Portable_Python PreCommit

Precommit issues should be fixed by https://github.com/apache/beam/pull/25234#issuecomment-1410757836

Run PythonDocker PreCommit

Run Portable_Python PreCommit

Run Python Dataflow V2 ValidatesRunner

@damccorm I added the test to be in the validates DataflowRunner suite since I see that it is the test I see where all the side streaming tests are running.
Also, re the errors, i made a commit which I will push once the ValidateRunner test is done(Don't want to cancel in mid way).
PTAL

@damccorm Added a couple of tests and removed the restrictions.
PTAL.

Run Python Dataflow V2 ValidatesRunner

I'll merge once checks pass

Remaining checks all passed, they just didn't status for some reason


Migrating from the community package

This official package is published under the community package name and has some different API access. If you're upgrading from the community package, please use the migration guide below:

bugsnag_flutter/bugsnag.dart is now bugsnag_flutter/bugsnag_flutter.dart
2.0.1 uses a single API key instead of platform API keys. Use ternaries like Platform.isAndroid ? androidApiKey : iosApiKey when using bugsnag.start
.setUser accepts a named ID instead of an unnamed ID in the first position
BugsnagObserver is now BugsnagNavigatorObserver
Bugsnag.instance is now a global bugsnag
Bugsnag.instance.recordError is now bugsnag.notify
Bugsnag.instance.recordFlutterError should be translated as bugsnag.notify(error.exception, error.stack)
BugsnagBreadcrumb is now BreadcrumbType

Thanks for this I've incorporated those instructions into https://github.com/bugsnag/bugsnag-flutter/blob/next/UPGRADING.MD.

Excellent, thanks @gareththackeray


[WIP] Cherry-pick commits from GPDB, for psycopg2

The main goal is to upgrade python management scripts to use psycopg2.
In GPDB, this was done by b5920e061b4a347523899838f6027c947107306e
To achieve this, I have actually cherry-picked more commits from [1]. It was done to reduce conflicts-resolution job pain.
This is WIP PR to get initial feedback. I need to double check my work (if these is any conflict-resolving related bugs), but for our deployment this works fine.
[1] https://github.com/yezzey-gp/ygp/commits/yezzey_7/gpMgmt/bin/gpexpand

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 3 committers have signed the CLA.:x: shrakesh:x: kainwen:x: Annu149You have signed the CLA already but the status is still pending? Let us recheck it.

hi @reshke, Glad to see you are cherry-picking code from GP, if you wants to retry CI can direct @me(@jiaqizho )

@reshke I believe this is a supporting PR that you may want to consider for this work: https://github.com/greenplum-db/gpdb-archive/commit/6f9d85b8bb571ed4195aaf05de4fba80cc0b9e7a

Fix the CI pls :)


Does batch-size affect the final result? Or just more GPU memory

parser.add_argument("--batch-size", "-b",
                    help="Batch size (beware GPU memory usage) [DEFAULT: 128]", type=int, default=128)

command：
(reinvent-scaffold-decorator) $> spark-submit --driver-memory=8g sample_scaffolds.py -m drd2_decorator/models/model.trained.50 -i scaffold.smi -o generated_molecules.parquet -r 16 -n 16 -d multi
Does batch-size affect the final result? Or just more GPU memory

Hi!
The batch size doesn't affect the result when sampling, but it does when training.
Hope it helps!
Josep


"mvn install liberty:run-server" fails on Linux

Using the pom.xml generated by the Liberty yeoman generator, running mvn install liberty:run-server fails with the error [ERROR] Failed to execute goal net.wasdev.wlp.maven.plugins:liberty-maven-plugin:2.1.2:test-start-server (test-start-server) on project dave1: CWWKM2002E: Failed to invoke [/home/dlane/dave1/target/liberty/wlp/bin/server, start, defaultServer]. RC= 255 but expected=[0, 1]. -> [Help 1]. This error occurs on Linux (Ubuntu 16.04 in WSL) but not MacOS. No other Liberty or java processes are running.

@d-lane Can you attach the pom.xml here?

pom.xml
 <?xml version="1.0" encoding="UTF-8"?><project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>

    <groupId>projects</groupId>
    <artifactId>dave1</artifactId>
    <version>1.0-SNAPSHOT</version>
    <packaging>war</packaging>

    <!-- contains default pluginManagement configuration for liberty-maven-plugin -->
    <parent>
        <groupId>net.wasdev.wlp.maven.parent</groupId>
        <artifactId>liberty-maven-app-parent</artifactId>
        <version>2.1.2</version>
    </parent>

    <properties>
        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
        <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
        <maven.compiler.source>1.8</maven.compiler.source>
        <maven.compiler.target>1.8</maven.compiler.target>

        <app.name>dave1</app.name>
        <testServerHttpPort>9080</testServerHttpPort>
        <testServerHttpsPort>9443</testServerHttpsPort>
        <warContext>${app.name}</warContext>
        <package.file>${project.build.directory}/${project.artifactId}-${project.version}.zip</package.file>
        <packaging.type>usr</packaging.type>
    </properties>

    <dependencies>
        <dependency>
            <groupId>javax.servlet</groupId>
            <artifactId>javax.servlet-api</artifactId>
            <version>3.1.0</version>
            <scope>provided</scope>
        </dependency>
        <dependency>
            <groupId>com.ibm.websphere.appserver.api</groupId>
            <artifactId>com.ibm.websphere.appserver.api.servlet</artifactId>
            <version>1.1.18</version>
            <scope>provided</scope>
        </dependency>
        <dependency>
            <groupId>com.ibm.websphere.appserver.api</groupId>
            <artifactId>com.ibm.websphere.appserver.api.jaxrs20</artifactId>
            <version>1.0.18</version>
            <scope>provided</scope>
        </dependency>
        <dependency>
            <groupId>com.ibm.websphere.appserver.api</groupId>
            <artifactId>com.ibm.websphere.appserver.api.json</artifactId>
            <version>1.0.18</version>
            <scope>provided</scope>
        </dependency>
        <dependency>
            <groupId>javax.websocket</groupId>
            <artifactId>javax.websocket-api</artifactId>
            <version>1.0</version>
            <scope>provided</scope>
        </dependency>
        <dependency>
            <groupId>org.apache.kafka</groupId>
            <artifactId>kafka_2.11</artifactId>
            <version>1.0.0</version>
        </dependency>
        <dependency>
            <groupId>org.eclipse.microprofile</groupId>
            <artifactId>microprofile</artifactId>
            <version>1.2</version>
            <scope>provided</scope>
            <type>pom</type>
        </dependency>
        <dependency>
            <groupId>javax.enterprise.concurrent</groupId>
            <artifactId>javax.enterprise.concurrent-api</artifactId>
            <version>1.0</version>
            <scope>provided</scope>
        </dependency>
        <dependency>
            <groupId>junit</groupId>
            <artifactId>junit</artifactId>
            <version>4.12</version>
            <scope>test</scope>
        </dependency>
        <dependency>
            <groupId>org.apache.cxf</groupId>
            <artifactId>cxf-rt-rs-client</artifactId>
            <version>3.1.11</version>
            <scope>test</scope>
        </dependency>
        <dependency>
            <groupId>org.glassfish</groupId>
            <artifactId>javax.json</artifactId>
            <version>1.0.4</version>
            <scope>test</scope>
        </dependency>
    </dependencies>

    <build>
        <plugins>
            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-war-plugin</artifactId>
                <version>2.6</version>
                <configuration>
                    <failOnMissingWebXml>false</failOnMissingWebXml>
                    <packagingExcludes>pom.xml</packagingExcludes>
                </configuration>
            </plugin>
            <!-- Plugin to run unit tests -->
            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-surefire-plugin</artifactId>
                <version>2.18.1</version>
                <executions>
                    <execution>
                        <phase>test</phase>
                        <id>default-test</id>
                        <configuration>
                            <excludes>
                                <exclude>**/it/**</exclude>
                            </excludes>
                            <reportsDirectory>${project.build.directory}/test-reports/unit</reportsDirectory>
                        </configuration>
                    </execution>
                </executions>
            </plugin>
            <!-- Enable liberty-maven plugin -->
            <plugin>
                <groupId>net.wasdev.wlp.maven.plugins</groupId>
                <artifactId>liberty-maven-plugin</artifactId>
                <configuration>
                    <assemblyArtifact>
                        <groupId>com.ibm.websphere.appserver.runtime</groupId>
                        <artifactId>wlp-webProfile7</artifactId>
                        <version>[<IP_ADDRESS>,)</version>
                        <type>zip</type>
                    </assemblyArtifact>
                    <configDirectory>${basedir}/src/main/liberty/config</configDirectory>
                    <packageFile>${package.file}</packageFile>
                    <include>${packaging.type}</include>
                    <bootstrapProperties>
                        <app.location>${project.artifactId}-${project.version}.war</app.location>
                        <default.http.port>${testServerHttpPort}</default.http.port>
                        <default.https.port>${testServerHttpsPort}</default.https.port>
                    </bootstrapProperties>
                    <features>
                        <acceptLicense>true</acceptLicense>
                    </features>
                    <looseApplication>false</looseApplication>
                </configuration>
            </plugin>
            <!-- Plugin to run functional tests -->
            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-failsafe-plugin</artifactId>
                <version>2.18.1</version>
                <executions>
                    <execution>
                        <phase>integration-test</phase>
                        <id>integration-test</id>
                        <goals>
                            <goal>integration-test</goal>
                        </goals>
                        <configuration>
                            <includes>
                                <include>**/it/**</include>
                            </includes>
                            <systemPropertyVariables>
                                <liberty.test.port>${testServerHttpPort}</liberty.test.port>
                                <war.context>${warContext}</war.context>
                            </systemPropertyVariables>
                        </configuration>
                    </execution>
                    <execution>
                        <id>verify-results</id>
                        <goals>
                            <goal>verify</goal>
                        </goals>
                    </execution>
                </executions>
                <configuration>
                    <summaryFile>${project.build.directory}/test-reports/it/failsafe-summary.xml</summaryFile>
                    <reportsDirectory>${project.build.directory}/test-reports/it</reportsDirectory>
                </configuration>
            </plugin>
        </plugins>
    </build>

    <profiles>
        <profile>
            <id>runnable</id>
            <properties>
                <package.file>${project.build.directory}/${app.name}.jar</package.file>
                <packaging.type>runnable</packaging.type>
            </properties>
        </profile>
        <profile>
            <id>bx-dev-build</id>
            <build>
                <pluginManagement>
                    <plugins>
                        <plugin>
                            <groupId>net.wasdev.wlp.maven.plugins</groupId>
                            <artifactId>liberty-maven-plugin</artifactId>
                            <configuration>
                                <outputDirectory>/tmp/liberty</outputDirectory>
                            </configuration>
                            <executions>
                                <execution>
                                    <id>install-feature</id>
                                    <phase>prepare-package</phase>
                                    <goals>
                                        <goal>install-feature</goal>
                                    </goals>
                                    <configuration>
                                        <outputDirectory>/tmp/liberty</outputDirectory>
                                    </configuration>
                                </execution>
                                <execution>
                                    <id>package-server</id>
                                    <phase>package</phase>
                                    <goals>
                                        <goal>package-server</goal>
                                    </goals>
                                    <configuration>
                                        <outputDirectory>/tmp/liberty</outputDirectory>
                                    </configuration>
                                </execution>
                            </executions>
                        </plugin>
                    </plugins>
                </pluginManagement>
             </build>
        </profile>
    </profiles>
</project>

@d-lane Thanks for the pom.xml. We test on Windows, Linux and Mac. From the error shown, we don't know why it would be failing. Would you mind bumping the liberty-maven-app-parent version to 2.6 to see if that resolves your issue?

@cherylking Same error unfortunately

Can you post the contents of the server's messages.log and console.log?

messages.log:
********************************************************************************
product = WebSphere Application Server <IP_ADDRESS> (wlp-1.0.22.cl180320180905-2337)
wlp.install.dir = /home/dlane/dave3/target/liberty/wlp/
server.output.dir = /home/dlane/dave3/target/liberty-alt-output-dir/defaultServer/
java.home = /opt/java/ibm-java-x86_64-80/jre
java.version = 1.8.0_181
java.runtime = Java(TM) SE Runtime Environment (<IP_ADDRESS> - pxa6480sr5fp20-20180802_01(SR5 FP20))
os = Linux (4.4.0-17134-Microsoft; amd64) (en_US)
process = 6248@DLANE-P50
********************************************************************************
[9/27/18 11:05:05:445 GMT] 0000001b com.ibm.ws.kernel.launch.internal.FrameworkManager           A CWWKE0001I: The server defaultServer has been launched.
[9/27/18 11:05:05:467 GMT] 0000001b com.ibm.ws.kernel.launch.internal.FrameworkManager           A CWWKE0100I: This product is licensed for development, and limited production use. The full license terms can be viewed here: https://public.dhe.ibm.com/ibmdl/export/pub/software/websphere/wasdev/license/base_ilan/ilan/<IP_ADDRESS>/lafiles/en.html
[9/27/18 11:05:07:605 GMT] 0000001b com.ibm.ws.kernel.launch.internal.FrameworkManager           I CWWKE0002I: The kernel started after 2.158 seconds
[9/27/18 11:05:07:735 GMT] 0000002c com.ibm.ws.kernel.feature.internal.FeatureManager            I CWWKF0007I: Feature update started.
[9/27/18 11:05:07:772 GMT] 0000002c com.ibm.ws.kernel.feature.internal.FeatureManager            I CWWKF0008I: Feature update completed in 0.169 seconds.
[9/27/18 11:05:07:772 GMT] 0000002c com.ibm.ws.kernel.feature.internal.FeatureManager            A CWWKF0036I: The server defaultServer has finished gathering a list of required features.
[9/27/18 11:05:07:948 GMT] 0000001b com.ibm.ws.kernel.launch.internal.FrameworkManager           A CWWKE0036I: The server defaultServer stopped after 2.502 seconds.

console.log:
11:05:42.517 0x25e2a00   j9shr.1012   *   ** ASSERTION FAILED ** at CompositeCache.cpp:2071: ((this->_commonCCInfo->oldWriterCount == _theca->writerCount))
JVMDUMP039I Processing dump event "traceassert", detail "" at 2018/09/27 12:05:42 - please wait.
JVMDUMP032I JVM requested System dump using '/home/dlane/dave3/target/liberty/wlp/usr/servers/defaultServer/core.20180927.120542.6433.0001.dmp' in response to an event
JVMDUMP012E Error in System dump: Error opening "/proc/sys/kernel/core_pattern". Look for core file generated by child process with pid = 6455
JVMDUMP032I JVM requested Java dump using '/home/dlane/dave3/target/liberty/wlp/usr/servers/defaultServer/javacore.20180927.120542.6433.0002.txt' in response to an event
JVMDUMP010I Java dump written to /home/dlane/dave3/target/liberty/wlp/usr/servers/defaultServer/javacore.20180927.120542.6433.0002.txt
JVMDUMP032I JVM requested Snap dump using '/home/dlane/dave3/target/liberty/wlp/usr/servers/defaultServer/Snap.20180927.120542.6433.0003.trc' in response to an event
JVMDUMP010I Snap dump written to /home/dlane/dave3/target/liberty/wlp/usr/servers/defaultServer/Snap.20180927.120542.6433.0003.trc

@d-lane As mentioned in the above referenced issue, we investigated further and verified that the bin/server start command was failing when running Liberty in Windows Subsystem Linux (WSL). So Liberty has not been tested in WSL at this point. We would like to understand your use case. Is there a compelling reason that you are not using a Windows JVM?

@cherylking There is no reason that I can't use a Windows JVM (and when I run the same command on Windows it works without error), however I do most of my development on the Linux side via WSL so it was natural for me to try to run Liberty on WSL too. It's not a huge issue, but as the popularity of WSL increases supporting it might become more important.

@d-lane Thanks for the explanation. I will pass along your feedback to the Liberty architects.

I'm closing this issue since Liberty is not currently supported in WSL. It's worth to note that support for WSL would need to be added to both OpenJ9 and Open Liberty in order for WebSphere Liberty to support it.

When will this be supported in WSL?

@lulseged Thank you for bringing this to our attention once again. The referenced OpenLiberty issue 5188 is still open and has now been assigned to the proper team to look into it. Please follow that issue for any updates. There is no official testing done on WSL. So this issue escaped our attention.


Error with pattern matcher

I have added in pattern matching to my interaction.
When i run pact verification it works fine.
But i see a warn in the console for pact broker
 WARN: Ignoring unsupported matching rules {"min"=>1} for path $['body']['Advertisers']
I use eachLike on an array
	Advertisers: eachLike({
		Name: 'Account'
	})

Deps:
    "@pact-foundation/pact": "5.9.1",
        "@pact-foundation/pact-node": "^6.19.4",

pact broker : dius/pact-broker:latest
Thanks,
Shane.

I am actually just fixing that at the moment. Ignore the warning, the min is being used. The warning will be gone in the next release.

Next release will be out in the next few hours :)
On Thu., 12 Jul. 2018, 4:50 pm Beth Skurrie<EMAIL_ADDRESS>wrote:

I am actually just fixing that at the moment. Ignore the warning, the min
is being used. The warning will be gone in the next release.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pact-foundation/pact-node/issues/99#issuecomment-404408059,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAjA5OQ1EsBbyklqKw9sWGeAlRiE-1qNks5uFvGhgaJpZM4VMR1x
.

let me know @mboudreau  and ill test it out

Sorry, we hit a small snag because the latest binary changed something
slightly.  We're currently in the process of fixing it and will release a
new version soonish.  Cheers.
On Fri, Jul 13, 2018 at 10:42 AM shane lee<EMAIL_ADDRESS>wrote:

let me know @mboudreau https://github.com/mboudreau and ill test it out
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pact-foundation/pact-node/issues/99#issuecomment-404691985,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAjA5G_Wd2tVgCQAnqvj-hBDTPnOPyChks5uF-zlgaJpZM4VMR1x
.

6.19.5 on its way out folks, stand by.

🚀


Multiple authorized issuer

Changes

Auth0Service now can handle multiple authorized_issuer

This is a non-breaking change that allows the original string definition for jwt_auth.authorized_issuer to continue working.
Testing
[x] All existing tests complete without errors

@antzo - Thank you for the PR here! Can you explain what your use case is for having multiple allowed ID token issuers?

@joshcanhelp Of course! In my use case I have two applications:
a) iOS client that is consuming an API with example.domain.com token issuer
b) Android client which is also consuming an API with eu.domain.com token issuer
In this case I have to maintain the compatibility with both app's till the b) app changes to the new token issuer.
Seems like the auth0-php library is implementing authorized_iss as array for the RS256 so I thought can be a good addition to the bundle, btw thanks for create it.

Let me know if you want me to add some unit tests but I think that is enough with the current suite

@antzo - Thank you for the details here, that's helpful.
The next major version of the PHP SDK will actually remove the ability to set a custom issuer, single or multiple. But that change was made because we're improving our compliance with the OIDC specifications, which is centered around ID tokens, not access tokens. Unfortunately, those two concepts are conflated in the SDK, making for situations like this.
I'm going to approve this for now since this bundle will need to do what you're asking for here and it's pinned at the major level for the SDK.

❯ snyk test

Testing /Users/joshcanhelp/Sites/jwt-auth-bundle...

Organization:      auth0-sdks
Package manager:   composer
Target file:       composer.lock
Open source:       no
Project path:      /Users/josh-cunningham/Sites/jwt-auth-bundle
Licenses:          enabled

✓ Tested 35 dependencies for known issues, no vulnerable paths found.

@joshcanhelp @antzo this PR introduced a BC.
!!
!!  In BaseNode.php line 511:
!!
!!    A dynamic value is not compatible with a "Symfony\Component\Config\Definiti
!!    on\PrototypedArrayNode" node type at path "jwt_auth.authorized_issuer".
!!
!!
!!

jwt_auth:
  domain: "%env(resolve:AUTH0_DOMAIN)%"
  authorized_issuer: "%env(resolve:AUTH0_AUTHORIZED_ISSUER)%"
  api_identifier: "%env(resolve:AUTH0_AUDIENCE)%"

@darthf1 - What was the value of authorized_issuer for you? I believe the intent here was to handle both strings and arrays.

@darthf1 You are right. I just send a PR to fix the problem
https://github.com/auth0/jwt-auth-bundle/pull/89


devel branch: how is optimization of acquisition function over discrete variables done?

From your previous messages, I understand that in order to deal with discrete parameters you restrict search in the acquisition function only over feasible (discrete) values. As gradient descent is at least not obvious to apply in this case, I assume you use a combination of gradient descent and some smart enumeration of discrete parameters. I would greatly appreciate if you would drop a short message on how specifically you optimize, so that I can understand what I should expect in terms of scalability.

Exactly, we essentially enumerate the set of possible values of the
discrete variables and for each combination we optimize the acquisition for
the reaming continuous variables. To select the point to sample, we take
best candidate from all the combinations.
We don't expect this to scale well when you have many discrete
variables/values but you can speed-up the search by doing the optimization
in a grid.
On 2 April 2016 at 12:00, iaroslav-ai<EMAIL_ADDRESS>wrote:

From your previous messages, I understand that in order to deal with
discrete parameters you restrict search in the acquisition function only
over feasible (discrete) values. As gradient descent is at least not
obvious to apply in this case, I assume you use a combination of gradient
descent and some smart enumeration of discrete parameters. I would greatly
appreciate if you would drop a short message on how specifically you
optimize, so that I can understand what I should expect in terms of
scalability.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/SheffieldML/GPyOpt/issues/14

I see. A reasonable approach, as it is important to come up with high quality points to sample for experiments that might take days or even weeks to compute anyway.
Once again, thanks for a quick response!


[ASCII-2588] Increase configsync test timeout to avoid flakiness on slow runners

What does this PR do?
Increase a timeout in the test to avoid failure when the runner is slow.
Motivation
Not have the test fail just because the runner is slow.
Describe how you validated your changes

Possible Drawbacks / Trade-offs
Additional Notes

/merge


Change ContactListener from Interface to Abstract Class

ContactListener is currently implemented as an interface. As such, to follow C# naming conventions, it should be called IContactListener.
An alternative would be to implement ContactListener as an abstract class, and leave the name as is. I'm willing to update this PR to that if that makes more sense. This is closer to how it's done in the C++ version: https://github.com/erincatto/box2d/blob/c6cc3646d1701ab3c0750ef397d2d68fc6dbcff2/include/box2d/b2_world_callbacks.h#L86
Either way, it's a breaking change, but as 2.4 is currently in alpha, seems the time to fix this.

@NArnott Hi dude, thanks! Yeah, I think it should be abstract like DestructionListener.

@benukhanov Updated ContactListener to an abstract class to match other areas.

@NArnott LGTM. I've invited you to be a collaborator, if you plan to do more PRs feel free to accept it. I'll add GitHub Action workflow to publish NuGet packages automatically on each new commit in the source code.

@benukhanov Awesome, I might take you up on that. The personal project I'm building it making leaps and bounds because of this library, so I'm glad to contribute.

@NArnott Cool, I'm glad to hear. I'd like to share some examples from my game project (but, I'm using Box2D v1.0) that maybe will be helpful, see this folder and this.


RC > Merged master

Codecov Report

:exclamation: No coverage uploaded for pull request base (rc-2.0.0@d9fb4f0). Click here to learn what that means.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             rc-2.0.0     #444   +/-   ##
===========================================
  Coverage            ?   99.32%
===========================================
  Files               ?       73
  Lines               ?     1920
  Branches            ?      300
===========================================
  Hits                ?     1907
  Misses              ?       13
  Partials            ?        0

Flag
Coverage Δ

#builder
100% <100%> (?)

#runtime
95.56% <ø> (?)

#srcapp
100% <ø> (?)

Impacted Files
Coverage Δ

...fig/webpack/build-public-library.webpack.config.js
100% <100%> (ø)

cli/build-public-library.js
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9fb4f0...6841e83. Read the comment docs.

@Blackbaud-BobbyEarl This is ready for another look; please and thank you.


create jenkins-ci project plan

our current jenkins CI system (kraken-ci) is unmaintained, based on jenkins v1 and the instructions to rebuild no longer work.  we are going to abandon this project in favor of using a kubernetes-based jenkins build system built on jenkins v2.
this ticket will cover the basic planning and initial tickets for the new ci system

This should use the new CI system as being developed by the zonar client engagement team.  it should start with importing the following repos:

zonar-pipeline
zonar-pipeline-library
zonar-jenkins-base

will be important to scrub zonar specific items.  as a first pass don't worry about making it fully generic, just get it running.  we will make it generic later.

it seems like I should be able to deploy jenkins using jenkins-base, then futz with the new -pipeline repo (zonar-repo -> k2-repo(?)) to add some tester jobs.
open question:  what about CI jobs that shouldn't end with a helm chart?

there is a bunch of gke/google cloud information hardcoded into this setup.  it makes sense for zonar but this may be a slightly larger disentanglement project then I expected.

this is a very large and fluid project right now.  it also doesn't support what we (common tools) need from a CI system.  In my current cough medicine haze I may try and futz with some other things but until the zonar team ships this I'm not interested in plowing much effort into it.

going to take a look at:

travis CI on prem
bamboo
concourse CI

travis CI doesn't seem to have an freely available self hosted vesion.  bamboo also doesn't seem to be free.
concourse install was a snap.  going to try and get K2 building there tomorrow morning.  if it works, might just keep going with it.  need to sort out how the builds are run, ie:  if concourse is making docker calls directly or if it is creating pods or jobs or something for the builds.

after some poking and prodding I should have a usable k2 pipeline running in concourse this afternoon.  this looks like its going to be dumb easy so I'm tentatively going to say 'we're using this' and I'm going to go plan out some other projects instead for now.

got k2 working just fine. it was all pebcak.
attempting to get the non-supported github PR resource working.  my first naive attempt is not succeeding but the basic model is that you specify the resource_type which includes either a docker image location or a source repo and you let concourse pull the plugin down.  that seems awesome if I can get it to work cleanly in k8s.

I have some background work to do before we go any further on this.  Need to make sure this project lines up with what we're all about and is a good chunk better then our current system.

background work complete.  first discussion complete.  should have another conversation next week.  we will get a strategy and at least a full medium term plan out of it

ToDo when issue complete:  go through k2, k2cli and careen p2-backlogs and start moving all CI related tickets to p1 or at least onto the board.

got a jenkins 2.0 version running locally in docker and it was fine.  I expect the zonar jenkins-base image will also work when I try that.
I was unable to get a job to fire off though.  I was hitting an issue with the first groovy class import.  The one from the jenkins example docs.  This does not fill me with a great amount of confidence in this tool.
however, I believe I have created a useful sample project with a sample Jenkinsfile for later usage so this was a useful learning period.  I also learned a bit about jenkins management in general which is never a waste.  However, results remain inconclusive.

simple first pass is probably:

jenkins-base from zonar team (will then be part of common-tools)
hand rolled configs with as much of the job information stored in the code (ie:  have the jenkins job call a shell script in the repo)
nginx ingress controller
kube-lego for SSL certs
profit

things completed today:

nginx-ingress controller installed
kube-lego installed
both of the above configured to work with rbac

next things to complete:

install jenkins-base (should be a helm chart somewhere)
configure kube-lego secured ingress for jenkins-base
configure jenkins-base to use jenkins kubernetes job launcher as kubernetes jobs
configure sample job (in go)
start porting pipelet jobs

There is probably two or three days of work left here.  Will then need to document as odds are high we are going to trash the production cluster a bunch as we learn what we're doing.

Need to figure out how to add worker jobs as build agents.  will try and do that tomorrow.

Where work is being done:
jenkins configs:  https://github.com/coffeepac/charts/pull/1
kube-lego/nginx-ingress:  https://github.com/coffeepac/kube-lego/pull/1

the parameters being passed into the slave jenkins pods are being duplicated.  Error message:

two arguments required, but got [36e66654dab68a4e6de72b69380ec64635be8a7500a819b2ea495f6c47563ac1, kubernetes-f34eba4e5cd84baaa74bcd9f8880fd90-1c7299e3825f6, 36e66654dab68a4e6de72b69380ec64635be8a7500a819b2ea495f6c47563ac1, kubernetes-f34eba4e5cd84baaa74bcd9f8880fd90-1c7299e3825f6]

looks like the system should only be providing the first two and not doubling them up.

Was able to complete a job end to end!  The steps included are:

checkout a go project
build the go project
test the go project
a debugging step
build a docker image for the project
push the docker image to quay

the build, test, docker build and docker push steps were all accomplished via shell commands in a Jenkinsfile checked into the project.  This covers everything I was trying to do with concourse so woo.
I am now ready to start porting jobs from pipelet over.  Almost, I still need to setup some webhooks to make sure things happen on commit pushes and PR merges but that, I think, is well understood.

oh, jenkins server:  https://common-jenkins.kubeme.io ask @coffeepac for credentials

PRs are being built, extraneous branches are not.  This is running on a stock job config.
Events aren't being sent from github->jenkins yet.  I think I need to setup a webhook but haven't found quite the right incantation yet.

@joejulian sorted out the needed webhook.  super easy.  the process to add a new job is:

create a multibranch project in jenkins

need to use some auth
specify the owner/project

add a Jenkinsfile to the project
add a webhook to the project in github that points to https://common-jenkins.kubeme.io/github-webhook/

I'm mostly done porting over k2 now.  Need to sort out how to do different things on PR vs master commit, slack notifications and e2e tests.

this is good enough to demo.  Will demo tomorrow to team.

demo complete:  good to go!  going to add some productiony things:

robot users
samsung_cnct/k2
delete the sample projects
issues for any other projects we need to add (k2-charts, k2-tools, etc)

that's good enough to open a PR against master.  if I have time I'll open a PR against k2recon as well.

it seems it is not possible to run the e2e tests in the current k2-tools container.  e2e steps involve bringing in a specific version of ginkgo that we can't control (ie checked in binary).  this binary is using a lib loader that alpine doesn't have.
options:

change the base container for k2-tools
step into a new container for the e2e tests that has this lib loader

drawbacks from one:

requires a fairly massive change to k2-tools and k2

drawbacks from two:

may not be possible inside of the try/catch block

I prefer option two so that's what I'll start hunting down, its least invasive to k2 as a whole.

option two worked.  woo!
need to create a repo for the e2e-tester image

two issues are cropping up right now:

e2e tests are failing without any interesting/useful error message.  I am debugging this by spinning the jenkins worker pod up manually so I can iterate without jenkins destroying my work surface
exiting from the e2etester container and returning to the main flow of the jenkinsfile is causing an issue and the destroy isn't firing.  I'm trying to embed a direct call back using the k2-tools container in the finally.  if that fails I dunno.

the e2etester image I created is missing aws.  This is a decent sized problem as installing aws requires pip, python2 and a bunch of dev libs.  I'm going to craft a new base image based on some large OS instead of a minimal thing.
remains a problem!  unsure what to do about it.  could require some serious gymnastics or putting all container{} specifications at the same level.  we'll see!

and now I've lost outbound connectivity on pods in the common tools cluster.  huh.

had some cruft laying around that's not visible from the web console.  I think its a policy doc.  got around by using a new cluster name.
got the e2e tests to run!  but now they're existing and providing no error message.  I'm not particularly enthused.  I'm going to take a quick look and see what the old execution environment is and see if I can use that instead.  this is getting ridiculous.

the canal pod has died on the node that is hosting my trial pod.  this is twice in a row.  I smell a problem.

we have a configuration problem in K2:  emptyDirs are being created in the root partition in the common-tools cluster.  this is causing the node to run out of disk and, I suspect, causes the daemonSets to exit.

Used the same image that jenkins used.  it worked. going to make sure it works in my tester pod then switch over to using that int he Jenkinsfile.  if that works (and by works I mean successfully run the e2e test) I'll push this as a PR

Got the image down to being based on an upstream debian-jessie scm buildpack.  should be fine.  there's still a bunch of guff being installed that I don't understand but we're not installing java8 or jennkins so good enough for now.
once I get a valid e2e run, this goes to master and I'll clean up the current jenkins job list to not have the sample stuff.

:trumpet:

whomp-whomp.  still can't get the e2e to start, there seems to be a gsutil issue.  probably because (i'm just realizing) I didn't change the tag so if the pod landed on the same physical node the image wouldn't get pulled again.
upside:  specifying the k2-tools container to wrap the destroy call is has cleared the directory creation areas.  so that's a positive.

I seem to have a functioning image for running e2etests and I've added it to the build-scripts directory in k2.  It probably needs its own CI job but we can discuss that later.  Right now its a manual build and says so.
next steps:

get a clean run using the built-from-k2 e2etester image
lay out the other issues needed for the rest of this plan

issues for which jobs to port
cleanup of this job

create new job based on samsung_cnct/k2 instead of my fork

ToReview:

there is a new CI system running in the common tools production cluster

verify by checking the following

https://common-jenkins.kubeme.io/ points to IPs in the common tools cluster running in aws in us-east-1
check that there is a jenkins pod running in the common-jenkins namespace

see https://hanjin.atlassian.net/wiki/display/CoT/Production+Kubernetes+Cluster for access

there is a K2 job that executed e2e tests that ended in flakes

check https://common-jenkins.kubeme.io/job/k2-trial/job/jenkins-2.0/141/console and verify the error is from a conformance test and not conformance test setup

check that tickets exist to port k2-charts CI job
check that tickets exist to create k2-tools and k2cli CI jobs

I have done everything here except find a ticket to port k2-charts CI job.

There are jenkins pods there, but they don't seem too happy: DStorck~/.kube$ kubectl get pods --all-namespaces NAMESPACE         NAME                                                        READY     STATUS              RESTARTS   AGE common-jenkins    common-hudson-jenkins-1549779338-c83x2                      1/1       Running             0          33d common-jenkins    kubernetes-4bd0b92014f14e5db2099885414b8294-b78f49e3d0d44   3/4       Error               0          3d common-jenkins    kubernetes-f915280a451445049566c384abc58967-b78644731e215   3/4       Error               0          3d

What am I looking for to be able to discern if the jenkins test is failing for conformance reasons and not from conformance test setup?

I second the last 3 comments.

Okay I'm going to guess that that the 'check that it failed from conformance test' is investigating why it failed, and seeing that it looks like (as per usual) there was some error on the way down trying to destroy the vpc. So we are happy that the test ran successfully and showed a failure, but it was an expected failure, and the test as expected?

Seein the same jenkins pods being unhappy.

K2 charts porting tickets.
Original:  https://github.com/samsung-cnct/k2/issues/395 (whoops)
Correct Repo: https://github.com/samsung-cnct/k2-charts/issues/85

Unhappy jenkins pods:  this is a bummer but the resolution is to destroy the pod.  I have.  We will need a maintenance job that periodically reaps error'd jenkins pods (#420)

'check if it failed from conformance test' is to take a look in the console log output, find the error and see what happened.  its a fairly labor intensive process and maybe signals that this system isn't quite ready yet.  I'm  going to spend a bit of time right now to see if I can get the test results to publish.  that should help.

it seems that GKE clusters can't have capital letters in their name.  need to verify this.  if true, I need to lowercase all letters in the cluster name setting script.

PR to fix naming of GKE clusters has been merged.
there is a bug in the conformance test shell script.  the tests are, occasionally, passing.  need to go fix that bug now then we should be able to get passing conformance runs at the same rate as pipelet.

Jenkinsfile command 'checkout scm' is checking out the wrong version of code.  o.0

e2e tests are now running in the PR version.  There is a lower-case name requirement as part of GKE cluster creation.  I had missed updating the cluster name generation in a shell script.  its been updated now.
the tests failed (flakes) but as soon as it works I'll link it here.

ToReview:

there is a new CI system running in the common tools production cluster

verify by checking the following

https://common-jenkins.kubeme.io/ points to IPs in the common tools cluster running in aws in us-east-1
check that there is a jenkins pod running in the common-jenkins namespace

see https://hanjin.atlassian.net/wiki/display/CoT/Production+Kubernetes+Cluster for access
command:  kubectl get pods --namespace common-jenkins

there is a K2 job on the master branch that has passed

master job: https://common-jenkins.kubeme.io/job/K2/job/master/

specific successful job:  https://common-jenkins.kubeme.io/job/K2/job/master/9/

check that ticket exists to port k2-charts CI job
check that ticket exists to create k2-tools and k2cli CI jobs

LGTM


FW manual control actuator sensitivity param

In aircraft capable of generating large control throws (e.g. 3D fixed wing aircraft), it is normal to setup the RC TX with "dual rates" with low rates normal for takeoff and landing. But, when flying in stabilized modes, the autopilot maps 100% input to maximum roll and pitch angles. This necessitates switching to high rates for normal stabilized flight, if the programmed maximum angles are to be achieved, and can be a source of confusion if a plane has been set up "properly" for manual flight. This confusion is easily prevented by clearly documenting the need for high rates in stabilized modes.
But, in an emergency requiring manual intervention, this means the pilot will have to deal with high rates immediately after switching to manual mode. Some RC transmitters may be programmed to change rates according to flight mode, and in this case the rate switch can be set up such that it is reversed in stabilized modes, with low rates being the default in manual mode. Similar capability could be provided by additional scaling parameters which apply to RC roll/pitch/yaw inputs when in manual mode, effectively providing "low rate" in manual mode.
Of course, some emergencies might require high rates for a successful recovery...

How about just recommending expo in general on the transmitter? That together with a default max angle of 55 degrees for attitude control should pretty much fix all the issues.

oops, I edited the first comment (description), not realizing it would still be blamed on @tumbili
@LorenzMeier Regarding expo, I use it for both high and low rates on my 3D aircraft... expo doesn't eliminate the need (desire?) for low rates

@LorenzMeier @LorenzMeier I will do it, should be quick work.

Implemented in #4787


Management of subuid/subgid as part of package

Hello !
I was looking at the LXD Debian package sources and see that when user are created, the lxd and root users get some subuid/gid for user namespacing stuff.
Moreover in the docs, when building it from sources, it is mentioned that we need to add at least 10M range of UID/GID for the root user:
https://linuxcontainers.org/incus/docs/main/installing/#machine-setup
I don't see anything related to this in the Incus package, do we still need to handle it as part of package or there is some new kernel stuff that manage it automatically ?
Thanks !

We could put the same logic in place.
You need to have those entries in /etc/subuid and /etc/subgid if your system has the uidmap package installed (specifically has the newuidmap and newgidmap commands).
If you don't, then Incus just assumes it has free reign over the uid/gid allocations and will pick the default allocation of 0:1000000:1000000000.
We could try to match that pretty closely with the packaging, basically using the logic you pointed to but with NEXT_UID/NEXT_GID set to 1000000 (this avoids clashes with some central auth systems) and set the map size to be<PHONE_NUMBER>.

OK, didn't know about Incus assumption of UID/GID allocations, I thought this was mandatory and Incus will fail to launch containers if not configured therefore, that's good to know. Regarding logic to apply, do we need to do the same kind of calculation even with an high range start as you mentionned to avoid overlap ?

We need to keep the loop around just in case someone has manually defined some allocations in that range. It's unlikely, but probably still a good idea to do it.

Moreover, do we need to apply those also for an incus user (for example the one we create on #14) like in the Debian package ? Is there a use-case since it's not mentionned in the documentation ? Since it seems that this user is only used for Incus sub-processes and QEMU VMs, I don't see it but I could be wrong.

We don't. The only reason why we usually were assigning the map to both the user and root was so we could easily track down why root has a specific allocation. So it was purely done for cosmetic reasons and never actually used by the lxd/incus user.
As I don't think anyone ever really looks at the file anyway, only assigning to the root user is probably fine.

Thanks for your answers. I could also send a PR on this one (or maybe putting it in the same PR as #14, wdyt ?)

Yeah, you can do one PR with each change as a separate commit in there.


Added the documentations folder

Because obviously no one checks libs folders

It's technically mergeable right now but I'd really appreciate the added sentences at some point before I merge.


[DOC]: Add floating point equality warning

Add a warning about constructing floating-point equalities to the Iris user guide, section 2.2. This is a near duplicate of the warning found in section 4.1.
The rationale for duplicating this warning to this section is that when I went to find the warning I expected to find it in this section and was surprised when I did not find it there. This means our docs are not as usable as they could be for a user.

Having discussed with @pelson we agreed that a link to the existing warning is preferable to duplicating the existing warning because:

it prevents duplicating existing documentation, which
is good because it keeps the docs shorter, and
it keeps the docs cleaner (the Sphinx warning directive is quite noisy).

Thanks @dkillick!


Would like to pass JSON string via CLI

We added tests for Shopify Functions to the example repository.
https://github.com/huckleberry-inc/shopify-function-example-assemblyscript/tree/main/test
The test directory has couple JSON files per test cases.
We'd like to pass JSON string via CLI instead of JSON file. Like bellow.
function-runner -f build/release.wasm '{ "cart": { "lines": [] } }' -j | jq .output.JsonOutput

We avoided to create JSON files by helper function. No problem for now.
https://github.com/huckleberry-inc/shopify-function-example-assemblyscript/blob/main/test/helper.ts#L6


frontend wonkiness: ugly buttons in question tree

-get rid of that teal line on click
-fix alignment
-get rid of shading?

What does this entail? I can take a look.

hey @EvanHahn - these issues are a little out of date. I already fixed this. thanks though!


Obvious fix

Description

Remove deprecated OpenJDK 8 option MaxPermSize

Signed-off-by: Brian Menges<EMAIL_ADDRESS>Issues Resolved
#205
Contribution Check List

[ ] All tests pass.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.

  Generated by :no_entry_sign: Danger


Investigate Versioning in Docker Image Launch Descriptor

All Spring-based modules seem to specify dockerImage as @artifactId<EMAIL_ADDRESS>However, I am unable to test a Spring module locally like this: it must be only @artifactId@, as was the case with the RMB example.
The repercussions of removing the version number need to be investigated.
I have been told that the exec in the deployment descriptor (which I also removed, compared to the other Spring modules) is meaningless and does not affect the actual deployment of the module (it is deferred to the Dockerfile) (per Dmytro Tkachenko. Lead Java Dev @ EPAM).

I tried asking but did not get a reply: https://folio-project.slack.com/archives/C01HUKJCMC7/p1636652935008700
Should be investigated more, however, this is not urgent in the slightest.

Does not matter.


[ENH]: Pythonic metadata filters

This PR supersedes: #981
Description of changes
Summarize the changes made by this PR.

Improvements & Bug fixes

Pure Pythonic where metadata filters

Test plan
How are these changes tested?

[x] Tests pass locally with pytest for python

Documentation Changes
Notebook included

Quotation works here, but we must add the Attr for cases like this. In property tests, we always quote (avoiding the use of eval/exec) the expressions so this never shows up. Let me give it a thought

@HammadB I have added impl + test + examples for the following syntax:
from chromadb.utils.query_helper import attr

q = WhereFilter(attr.rating > 0.1 and attr["rating"] <= 0.9)
numeric_filter=collection.get(where=WhereFilter(attr.rating > 0.5 and attr["rating"] <= 0.9))

Both attributes (attr.my_attr and items (attr["my_attr"]) are supported for cases where the attribute name causes conflicts e.g. -my_python_invalid_attr`.

Any chance of merging this? looks quite useful.

Let's revisit this shortly - offline discussion: having a fluent api for changing would be useful