[WIP] New company tags not listed alphabetically

Modified the sort for tags to be case insensitive
https://bugzilla.redhat.com/show_bug.cgi?id=1238580

Before:

After:

@miq-bot add-label ui
@miq-bot add-label bug
@miq-bot add-label wip
WIP to add rspec

Closed in favor of https://github.com/ManageIQ/manageiq/pull/9234


Addressing edge-case scenarios in script

@rupisure,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


[netif] enhance IterateExternalMulticastAddresses

This PR enhances IterateExternalMulticastAddresses to use further filter external multicast addresses.
Should be rebased after #5269 is merged

@simonlingoogle , please resolve conflicts.


additionalResolvers config with object in args

Hello,
I want to create an additionalResolvers using only the config file but without success. It appears that we can't define object inside args.
Here the config file:
additionalResolvers:
  - type: ProductModel
    field: reviews
    requiredSelectionSet: |
      {
        id
      }
    targetSource: ReviewService
    targetMethod: reviewServiceGetReviewsByProduct
    returnData: data.reviews
    args:
      "input.productId": "{root.id}"

Here's the equivalent code in JS which is working :
module.exports = {
    resolvers: {
        ProductModel: {
            reviews: async (root, _args, {ReviewService}) => {
                return (await ReviewService.api.reviewServiceGetReviewsByProduct({input: {productId: root.id}})).reviews;
            }
        }
    }
}

I also tried to define the args like this:
args:
    input:
        productId: root.id

But I got the following error : str.match is not a function.
I want to use the config file because we can't define a requiredSelectionSet in the js function as in the config.
Thanks,
Note: since I'm using gRPC, I can't define args a different manner.

Could you create a reproduction for the first issue? And for the second one, you can add selectionSet for additionalResolvers like below;
module.exports = {
    resolvers: {
        ProductModel: {
            reviews: {
              selectionSet: `{ id }`,
              resolve: async (root, _args, {ReviewService}) => {
                   return (await ReviewService.api.reviewServiceGetReviewsByProduct({input: {productId: root.id}})).reviews;
               }
            }
        }
    }
}

@ardatan awesome it works like that ! I have to say that the documentation about that feature is very poor. :) But for now I have all the necessary informations. GraphQL-Mesh is really a good fit for my project.
You don't know how I can set an object inside the args value ?
I will create a repository but it's actually using Bazel as build system, I will try to make it easy to use and test with low dependencies.

Here's the repository: https://github.com/scorsi/graphql-gateway-grpc-services.
You have to run npm install then make run_products and make run_reviews, when both are finally built (may be long) you can run make run_gateway to run GraphQL.
Here's the GraphQL example:
{
  productServiceGetProducts(input: {productIds: ["1"]}) {
    products {
      title
      reviews {
        userName
        rating
      }
    }
  }
}

Thanks !

It should be fixed in the latest version! Let's know if it still persists!

@ardatan I'm running into the same issue: str.match is not a function, can you maybe describe the correct way to pass in the argument when its an object and an array?
My input is meant to be something like this:
args:
      input:
        playlistIds:
          - 'id1'
          - 'id2'
          - 'id3'

Similar to the author, I managed to get it working using an additional resolver file, but I can't get it to work in the yaml


Improve Package structure & Swift4

[x] Update to Swift4
[x] Update Package.swift to only import Test dependencies (Spectre) for development

A test-case was failing, so I fixed.

Update Package.swift to only import Test dependencies (Spectre) for development

I've cut a tag on my fork repo. So for now, users can now use my fork to acquire this behavior.

PathKit can return the last component without extension
PathKitSpec.swift:213
. is not equal to ..

Not sure what this is..?🤔 On mac it's sucessful.

@toshi0383 the functionality changes here have now been fixed on master. If you'd like to rebase and remove those, and resubmit just the Package.swift changes feel free. Ideally IMO we would fix this in SwiftPM though 😛


Adding spoken dialogue state tracking recipes for Spoken MultiWoz and SpokenWoz datasets

What does this PR do?
This PR adds spoken dialogue state tracking recipes for two datasets: spoken MultiWoz and SpokenWoz. I have tried my best to conform to speechbrain's conventions. Please let me know if there are any conventions I missed. I do not know if and how recipes should be tested.

Before submitting

[x] Did you read the contributor guideline?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[ ] Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified
[ ] Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
[ ] Review the self-review checklist to ensure the code is ready for review

#2441 also adds a T5 HuggingFace lobe as far as I could tell, we will see how we deal with this.

Hey @asumagic,
Thanks for taking a look into this PR, I have seen that the pre-commit pipeline fails because of the spokenwoz data preparation function which is too complicated. I believe the complexity is measured in number of lines of code, however I have trouble simplifying it since the formatting sometimes reformats into many lines. For instance line 146.

Hey @asumagic, Thanks for taking a look into this PR, I have seen that the pre-commit pipeline fails because of the spokenwoz data preparation function which is too complicated. I believe the complexity is measured in number of lines of code, however I have trouble simplifying it since the formatting sometimes reformats into many lines. For instance line 146.

I think the linter measures cyclomatic complexity rather than the plain number of lines of code, so fixing formatting would probably not help. In this case, it could make sense to extract the whole for dialog_id, dialog_info in annotations.items(): loop into its own function.
As for the other pre-commit style check fails, you can fix them locally by running pre-commit run -a (pypi).
As for the other tests failing, the issue seems to be that recipe tests should be added. Recipe tests use a small subset of data and launches a dummy training for a fixed number of epochs, then asserting that some metric is respected.

As far as I can tell, a line should be added in tests/recipes/MultiWOZ.csv and a tests/recipes/SpokenWOZ.csv file should be created. Recipe tests are further explained in tests/recipes.

Hi @asumagic,
I fixed the complexity and trailing space failed tests and added a test for each recipe. I had to commit without verifications the last commit since I had a failed test for large files for the sample audio (tests/samples/DST/SpokenWoz/audio_5700_train_dev/MUL1011.wav) required for the test. Let me know if I can do anything else.

BTW, I am still in the process of reviewing, but it does take some time.

Sorry for the delay and thank you for your review and changes which make a lot of sense! Regarding the other points:

I have not provided checkpoints but can provide them if needed. However it requires to re-run the whole training to reach the reported performances.
I corrected the few naming issues and missing documentation, hope its okay now.
I moved the Joint-Goal Accuracy tracker (used for training to keep a running JGA without storing the values) to metric_stats.py.
I left the common part of Dialogue State Tracking evaluation in utils to be able to import it from the recipes.
I moved the dataset specific evaluations to their recipe's meta folder.

Let me know what else I can do to go forward with this PR.


FZF (from nvim) doesn't bind function keys correctly (for example f4)

with the following .nvimrc
set nocompatible
set rtp+=~/.fzf

FZF_DEFAULT_OPTS="--multi --bind 'f4:toggle-all,ctrl-o:toggle-all'" nvim
Do :
:FZF
ctrl-o works to toggle-all, but f4 doesn't
f4 works correctly from withih vim with the same vimrc
FZF_DEFAULT_OPTS="--multi --bind 'f4:toggle-all,ctrl-o:toggle-all'" vim
I guess it is a problem in upstream @tarruda

Thanks for the heads up, but this issue is not specific to fzf. So I suggest that you discuss it on the nvim issue tracker. An easier way to reproduce (without fzf):

Start nvim
F1 should bring up help window
:term
Start nvim inside the term window
F1 does not work there

Ok, I've opened https://github.com/neovim/neovim/issues/3497 for this


Cwe 141523   jenkins operations plugin   add release prefix option

wrong pull request. original project has been fored into jenkinsci.


Montserrat font seems to not respect fontweight

Steps to Reproduce

Execute flutter run on the code sample
look at the montserrat two line of text

Expected results:
FontWeight.w100 and FontWeight.w900 should look a lot different one from the other and respect difference seen on https://fonts.google.com/specimen/Montserrat?query=montserrat#standard-styles following the screens taken from google font website.

No issues found! (ran in 1.1s)

~/projects/google_font_test$ flutter doctor -v
[✓] Flutter (Channel unknown, 3.0.4, on macOS 12.4 21F79 darwin-arm, locale en-IT)
    • Flutter version 3.0.4 at /opt/homebrew/Caskroom/flutter/3.0.5/flutter
    • Upstream repository unknown
    • Framework revision 85684f9300 (4 weeks ago), 2022-06-30 13:22:47 -0700
    • Engine revision 6ba2af10bb
    • Dart version 2.17.5
    • DevTools version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/clucera/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Ultimate Edition (version 2022.1.3)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 69.0.4
    • Dart plugin version 221.5921.27

[✓] VS Code (version 1.69.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.44.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 12.4 21F79 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 103.0.5060.134

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Update:
It looks like the issue is present also with other fonts (i.e. Roboto)

Hi this is a known issue #35
The workaround is
              Text(
                "THIS IS A TEST 100",
                style: GoogleFonts.lato(fontWeight: FontWeight.w100),
              ),
              Text(
                "THIS IS A TEST 900",
                style: GoogleFonts.lato(fontWeight: FontWeight.w900),
              ),


ASP.NET Core Hosted in IIS Stop Process on Startup

I would like to know how I can fail the application on startup in the case where database connectivity cannot be made. If you throw an exception in the startup.cs the process is still running. Anyone know?
asp.net core web application targeting .net framework 4.7.1 hosted in IIS.

I was able to set the aspNetCore startupUpTimeLimit in the web.config file and then retry the database connection until the timeout is exceeded. In this case the process is shut down.
web.config
startupTimeLimit="15"


Fix concurrency handling

Codecov Report
Patch coverage: 84.61% and project coverage change: +6.49 :tada:

Comparison is base (e7da399) 63.63% compared to head (ca37c99) 70.12%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   63.63%   70.12%   +6.49%
==========================================
  Files           1        1
  Lines          55       77      +22
==========================================
+ Hits           35       54      +19
- Misses         18       21       +3
  Partials        2        2

Flag
Coverage Δ

unittests
70.12% <84.61%> (+6.49%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

formatter.go
70.12% <84.61%> (+6.49%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Disable page feature "You may also be interested in"

Please provide information on the property switch to disable the page feature "You may also be interested in".
We need to be able to turn this off via PowerShell for all/multiple specific sites, in the same way that we can with these:
Set-SPOSite
[-CommentsOnSitePagesDisabled ]
[-SocialBarOnSitePagesDisabled ]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5d1c6b2b-5af6-acce-b7e8-bf784bb0973e
Version Independent ID: 301586d3-ec04-c42d-4681-0bb59443d35c
Content: Set-SPOSite (sharepoint-online)
Content Source: sharepoint/sharepoint-ps/sharepoint-online/Set-SPOSite.md
Service: sharepoint-powershell
GitHub Login: @trent-green
Microsoft Alias: trgreen

@officedocsbot assign @yogkumgit

Hello @angoo-atea can you please share a screenshot of what you see in your tenant?
Tried to reproduce in my lab tenant but the feature is not showing up.
Thank you

@get-itips

Hello @trent-green is this feature called RecommendedItems at SC level ?

Isn't is this under Site Features?

@whoisbex - that is the feature that I suspect is the one. We need to be able to turn this off via PowerShell for all/multiple specific sites, in the sam way that we can with these:
Set-SPOSite
[-CommentsOnSitePagesDisabled ]
[-SocialBarOnSitePagesDisabled ]

@angoo-atea @whoisbex I too suspect is the one, but as the feature is not showing up in my tenant I can not confirm, and we should wait for @trent-green confirmation.
Besides that, for any new feature for the Set-SPOSite cmdlet I suggest a user voice suggestion

@get-itips there is currently no parameter on Set-SPOSite for this.  The only way to enable or disable this via powershell is with PNP
https://docs.microsoft.com/en-us/powershell/module/sharepoint-pnp/disable-pnpfeature?view=sharepoint-ps

@get-itips there is currently no parameter on Set-SPOSite for this. The only way to enable or disable this via powershell is with PNP
https://docs.microsoft.com/en-us/powershell/module/sharepoint-pnp/disable-pnpfeature?view=sharepoint-ps

That is clear. What I am trying to find out for the issue creator is the name of the feature, is it RecommendedItems ?
Thanks.

@whoisbex has the correct feature above, "SharePoint Recommendations"
Thanks!

The Feature GUID is: '780AC353-EAF8-4AC2-8C47-536D93C03FD6'

The Feature GUID is: '780AC353-EAF8-4AC2-8C47-536D93C03FD6'

Ok so that is the same GUID I found out and the feature internally is called RecommendedItems as I mentioned earlier, and appears in the UI as "Sharepoint Recommendations" as @whoisbex could find out.
We will proceed closing  this one. Thanks to everybody.

@get-itips and @trent-green  Thank you very much for the contribution and sharing this explanation. @angoo-atea Hope this comment is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

@get-itips there is currently no parameter on Set-SPOSite for this. The only way to enable or disable this via powershell is with PNP
https://docs.microsoft.com/en-us/powershell/module/sharepoint-pnp/disable-pnpfeature?view=sharepoint-ps

@yogkumgit Thanks, the input is useful. However @get-itips @trent-green - will there be an addition to the Set-SPOSite command for this? It would make sense to include it.

Hello @angoo-atea for that inquiry I need to kindly redirect you to Sharepoint User Voice  where your proposal can be taken care of. As this issue system is specific to address issues in documentation.
Thank you


training only for one classes

Hello ,
Thanks for such effort , I would like to ask if we can used this platform and structure for training a model only on one class?
looking forward to receive an answer.

done , I figure it out.


Adds support for manifestTransforms

R: @addyosmani @gauntface
Fixes #626
This is based on the discussion from #626 + some follow-up meetings.
It adds support for a new manifestTransforms option to workbox-build, which takes one or more ManifestTransform functions as a parameter. This opens the door for doing post-processing of the manifest that was generated from globPatterns + templatedUrls.
I've reimplemented the existing dontCacheBustUrlsMatching and modifyUrlPrefix options so that they use the same manifest transformation pipeline.
I've made it so that its valid for an object ManifestEntry not to have a revision field, and that's treated the same way we treat a string ManifestEntry. I haven't removed support for using strings to represent manifest entries that lack revision fields, though we should revisit deprecating strings in favor of objects without revision fields in a future release.

Any idea when this will land in an npm release?

I just updated my project to use this feature (using a custom build). It looks great. Thanks for the work on this!

@gauntface, please take another look.

I can confirm that the original changes in this pull request work in a production app. 💯

Any idea when a new version will be published with this feature? We are currently using the code in a custom build, and it works in production over a CloudFront CDN. 💯

@kevinphelps @coryrylan we should we cutting a release tomorrow.
H/T to @jeffposnick for scheduling a more regular release schedule.

We're still finalizing the details, but the current idea is to track our release schedule (& any public meetings) using https://calendar.google.com/calendar/embed?src=gsmnmr45i797q67dfhp08t48no%40group.calendar.google.com&ctz=America/New_York
Stay tuned for more details.

It's in https://github.com/GoogleChrome/workbox/releases/tag/v1.2.0


[Intel MKL] Supporting native format in Convolution Fwd

This PR adds support for native(user) format in convolution forward op. _MklNative* ops will be used in both graph and eager modes.
This PR needs to be merged after "DNNL 1.5.1 Upgrade" PR is merged #42073

Thank you for your review. I have addressed the comments.


on longpress the row above immediately falls down behind the pressed one

With just a longpress Without any movement, this happens:

I experience the same problem. As soon as a row becomes active, the row above falls down on top of it, even though the active row hasn't moved at all. Once you start moving around, it works as expected.
I would be grateful for any clues pointing me to a possible solution.

Add the line
import styles from './Styles/ListviewExampleStyle'
to the SortableListViewExample file, and things work much better!

Hi,
perqa,I meet the same problem as you,but I don't understand how you to solove it.
Add the line import styles from './Styles/ListviewExampleStyle',
because the 'ListviewExampleStyle' can not find ,
can you tell me how to solve it ,thank you?

Hi,@perqa! thanks,the problem inside the screen is worked well,but Beyond the one screen,the problem is also not Solved.

This is mostly fixed by f5c2ae0cc55f3d8c332ee3ba5b8d3eb568520739.
There is still a problem with a long list when it is partially scrolled down and an item close to the top is selected. Closing this, I will file a new issue detailing the problem.


Is there a way to set pagination to false based on size of data ?

If the data size is too small say 4 entries, is there a way to set pagination to false ? it looks ugly on UI. having pagination which has nothing associate with it.

No, we don't have that feature. But please feel free to submit a PR for it, it sounds like a useful thing to have.


feat: update checker should log while exiting

The update checker currently checks and logs that the binary was outdated when the server was started. This warning is shown almost everytime the user start the Tailcall server and makes them ignore other important warning messages.
Technical Requirements

Make sure the upgrade is checked on start but the log::warn is only done exiting
The warning should be shown at max once a day.

/bounty $50


Change deprecated package...

npm WARN deprecated<EMAIL_ADDRESS>CircularJSON is in maintenance only, flatted is its successor.

This is no longer relevant in the recent dependancy package versions


Robert/75 resolve checkstyle issues

Ticket
Resolving some of the various issues highlighted by Checkstyle.
Please be aware that while the individual changes are relatively small there are a lot of them. You may want to review this PR on a per-commit basis, rather than as a single blob, if you find that helpful. If you would like to recommend breaking this up into multiple smaller PRs, please let me know.
Thus far, the changes made should have minimal, if any, impact on the actual behaviour of the code.

Approved a specific commit and it approve the whole project instead.


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v5.4 to before v5.4.162",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=9c3516d1b850ea938b074df33e4c86d721c77720",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=9e0df711f8dbe5650ad4f557c12a5cb302432a37"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "9c3516d1b850ea938b074df33e4c86d721c77720",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "9e0df711f8dbe5650ad4f557c12a5cb302432a37",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "perf bench futex: Fix memory leak of perf_cpu_map__new()\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.4.162 by commit 9e0df711f8dbe5650ad4f557c12a5cb302432a37, it was introduced in version v5.4 by commit 9c3516d1b850ea938b074df33e4c86d721c77720. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1002264


"Your workflow file was invalid" error

I'm trying to use your action but I get the following error:
Your workflow file was invalid: .github/workflows/staging.yml (Line: 26, Col: 9): There's not enough info to determine what you meant. Add one of these properties: run, shell, uses, with, working-directory
I added your action after my current setup so that I can run npm install and npm build first. Did I do something wrong?
jobs:
  build:
    runs-on: ubuntu-latest

    strategy:
      matrix:
        node-version: [12.x]

    steps:
      - uses: actions/checkout@v1
      - name: Use Node.js ${{ matrix.node-version }}
        uses: actions/setup-node@v1
        with:
          node-version: ${{ matrix.node-version }}
      - name: npm install & build
        run: |
          npm install
          npm run build --if-present
      - name: S3 Sync
      - uses<EMAIL_ADDRESS>        with:
          args: --acl public-read --follow-symlinks --delete
        env:
          SOURCE_DIR: './build'
          AWS_REGION: 'ap-southeast-2'
          AWS_S3_BUCKET: ${{ secrets.AWS_S3_BUCKET_STAGING }}
          AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
          AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

Hi there! Try deleting the dash before the second line here so it looks like this:
      - name: S3 Sync
        uses<EMAIL_ADDRESS>
Hopefully it's this simple but let me know if that doesn't work. :)

Yes that worked perfectly thank you!


transplant to ros2

hi, thanks for your work, when i  transplant the code to ros2, which can connet to the r2000 like this:
[r2000_node-4] [INFO] [1677779762.428661354] [r2000_node]: Device found: R2000
[r2000_node-4] [INFO] [1677779762.445970648] [r2000_node]: Device state changed to Initialized
[r2000_node-4] [INFO] [1677779762.452387113] [r2000_node]: Device state changed to Running
but after that return fault:
[r2000_node-4] terminate called after throwing an instance of 'rcpputils::IllegalStateException'
[r2000_node-4]   what():  Wrongly initialized. Serialized message has a capacity of zero.
dou you have any idea for that，thanks a lot.

ROS 2 version is still not ready to use. I am currently trying to fix the de-serialization issue - they way messages are serialized in ROS 2 is different than in ROS 1. Any help / suggestions are welcome

Has the problem been solved？I have the same problem，
log is below:
[ros_main-1] protocol error: 110 Unknown parameter 'skip_scans'
[ros_main-1] [INFO] [1720847655.008640679] [ros_main]: Device state changed to Initialized
[ros_main-1] [INFO] [1720847655.019496512] [ros_main]: Device state changed to Running
[ros_main-1] [ERROR] [1720847657.009863096] [transport]: Time out: No packets received in 2 seconds
[ros_main-1] [ERROR] [1720847657.010546774] [ros_main]: Network failure
[ros_main-1] [INFO] [1720847657.047467382] [ros_main]: Device state changed to Uninitialized
[ros_main-1] [INFO] [1720847657.094887568] [ros_main]: Device found: R2000
[ros_main-1] protocol error: 110 Unknown parameter 'skip_scans'
[ros_main-1] [INFO] [1720847657.141741912] [ros_main]: Device state changed to Initialized
[ros_main-1] [INFO] [1720847657.153894682] [ros_main]: Device state changed to Running
[ros_main-1] [ERROR] [1720847659.148992255] [transport]: Time out: No packets received in 2 seconds
[ros_main-1] [ERROR] [1720847659.149705975] [ros_main]: Network failur


How to mark messages

Hi,
Is there a way to mark messages, not only "chat" and "groupchat"?

Please direct these kinds of questions to Stack Overflow or something similar.

Can you improve documentation to know where to find this. Thanks in advance.

These plugins here are provided by various volunteers. It's up to them or other volunteers who use these plugins to improve the documentation.


Make local startup and experimentation simpler by using a composable docker-compose

Make local startup and experimentation simple by using a composable docker-compose file to start it with various Haystack subsystems and Zipkin as trace connector/provider.

Done. And find link here: https://github.com/ExpediaDotCom/haystack-docker


Localize ticket categories

Hi,
Is there any chance to add a feature to translate ticket categories aswell?
Or is this impossible by design?
Thanks
Matthias

Any news?

The current implementation of the plugin will break the native names for the IssueCategory (it will be impossible to change the original category name on the edit category page). Therefore, I'm afraid that it's not possible to implement localization for the Issue Category model without huge changes to the base plugin methods.


Split skip_output.execution into two options

:zap: Summary
# lefthook.yml

skip_output:
  - execution  # Skips printing successfully executed commands and their output (but still prints failed executions)

As the config comment says skip_output.execution will skip printing successfully executed commands and their output, can this config option be split into two parts, something like:
# lefthook.yml

skip_output:
  - execution      # Skips printing successfully executed commands
  - cmd_output     # Skips printing successfully executed commands' output (but still prints failed executions)

Value
I don't want to know what has been executed, as if I saw the output I will know what's happenning.

I think this option will allow the user to decide by themselves what can be output and will make this tool more user friendly

Hey! Thank you for the feature request. I decided to slightly change the option - execution_out. Does it feel OK for you?

Yes, Great, Thanks for the quick fix

It's weird that it does not work as expected after upgrade to the latest version:
min_version: 1.3.11
color: false
no_tty: false
skip_output:
  - meta              # Skips lefthook version printing
  - skips             # Skips "skip" printing (i.e. no files matched)
  - summary           # Skips summary block (successful and failed steps) printing
  - success           # Skips successful steps printing
  - failure           # Skips failed steps printing
  - execution         # Skips printing successfully executed commands
  # - execution_out   # Skips printing successfully executed commands' output (but still prints failed executions)
pre-push:
  follow: true # need to use follow to get stdin from git push
  scripts:
    'sync.sh':
      runner: sh

For me when I set skip execution then the execution output be skipped too.
When I disable skip execution and enable skip execution_out everything works as 1.3.10 with skip execution disabled: the executed commands and it's output been displayed

Hmm I guess I haven't handled the case when you use follow/interactive option. Let me fix that.

Hi, thanks for the new release, I have just tried 1.3.12, but still no luck.

I've tried your config, and it worked for me:
skip_output:
  # - meta              # Skips lefthook version printing
  # - skips             # Skips "skip" printing (i.e. no files matched)
  # - summary           # Skips summary block (successful and failed steps) printing
  # - success           # Skips successful steps printing
  # - failure           # Skips failed steps printing
  # - execution         # Skips printing successfully executed commands
  - execution_out   # Skips printing successfully executed commands' output (but still prints failed executions)
pre-push:
  follow: true # need to use follow to get stdin from git push
  scripts:
    'sync.sh':
      runner: sh

$ cat .lefthook/pre-push/sync.sh
echo waiting...
sleep 1
echo done
sleep 1

$ lefthook run pre-push
Lefthook v1.3.12
RUNNING HOOK: pre-push

  EXECUTE >  sync.sh

SUMMARY: (done in 2.02 seconds)
✔  sync.sh

What do you see if you remove all skip_output settings?

My sync.sh:
#!/bin/sh
# Author: hustcer<EMAIL_ADDRESS># Date:   2021/09/29 17:52:58 +0800
# Git pre push hooks, need just/nu and related nu scripts to run.

# set -exo pipefail

while read -t 2 -s local_ref local_oid remote_ref remote_oid
do
  echo waiting...
  echo $local_ref
  sleep 1
  echo done
  sleep 1
done

exit 0

Config:
min_version: 1.3.12
color: false
no_tty: false
# skip_output:
#   - meta              # Skips lefthook version printing
#   - skips             # Skips "skip" printing (i.e. no files matched)
#   - summary           # Skips summary block (successful and failed steps) printing
#   - success           # Skips successful steps printing
#   - failure           # Skips failed steps printing
#   - execution         # Skips printing successfully executed commands
  # - execution_out   # Skips printing successfully executed commands' output (but still prints failed executions)
pre-push:
  follow: true        # need to use follow to get stdin from git push
  scripts:
    'sync.sh':
      runner: sh

Output:
Lefthook v1.3.12
RUNNING HOOK: pre-push

  EXECUTE >  sync.sh
refs/heads/feature/sync 98c0a7490b34d901573ce709dcfe612beec4854c refs/heads/feature/sync 5498b11eb3a7ea2a17ef215914591f3ef5d4f396
waiting...
refs/heads/feature/sync
done

SUMMARY: (done in 4.04 seconds)
✔  sync.sh
Enumerating objects: 5, done.
Counting objects: 100% (5/5), done.
Delta compression using up to 8 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 332 bytes | 166.00 KiB/s, done.
Total 3 (delta 2), reused 0 (delta 0), pack-reused 0
To https://...............

With this config:
min_version: 1.3.12
color: false
no_tty: false
skip_output:
  - meta              # Skips lefthook version printing
  - skips             # Skips "skip" printing (i.e. no files matched)
  - summary           # Skips summary block (successful and failed steps) printing
  - success           # Skips successful steps printing
  - failure           # Skips failed steps printing
  - execution         # Skips printing successfully executed commands
  # - execution_out   # Skips printing successfully executed commands' output (but still prints failed executions)
pre-push:
  follow: true        # need to use follow to get stdin from git push
  scripts:
    'sync.sh':
      runner: sh

Got output:
Enumerating objects: 5, done.
Counting objects: 100% (5/5), done.
Delta compression using up to 8 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 322 bytes | 80.00 KiB/s, done.
Total 3 (delta 2), reused 0 (delta 0), pack-reused 0
To https://................
   98c0a749..6fd2c285  feature/sync -> feature/sync

BTW: I'm using git push to do a real push

Ok, and what do you see with this config?
min_version: 1.3.12
color: false
no_tty: false
skip_output:
  - meta              # Skips lefthook version printing
  - skips             # Skips "skip" printing (i.e. no files matched)
  - summary           # Skips summary block (successful and failed steps) printing
  - success           # Skips successful steps printing
  - failure           # Skips failed steps printing
  # - execution         # Skips printing successfully executed commands
  - execution_out   # Skips printing successfully executed commands' output (but still prints failed executions)
pre-push:
  follow: true        # need to use follow to get stdin from git push
  scripts:
    'sync.sh':
      runner: sh

  EXECUTE >  sync.sh
refs/heads/feature/sync 8fb4420dd8818b68115df7abd121ba3b2784b2fc refs/heads/feature/sync 6fd2c285dbd6513c85874fc935ac137abfcce86c
waiting...
refs/heads/feature/sync
done
Enumerating objects: 5, done.
Counting objects: 100% (5/5), done.
Delta compression using up to 8 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 294 bytes | 147.00 KiB/s, done.
Total 3 (delta 2), reused 0 (delta 0), pack-reused 0
To https://.....................
   6fd2c285..8fb4420d  feature/sync -> feature/sync

Well, I can't reproduce that, for my git push output is being skipped correctly.
Can you remove skip_output settings and check ENV-var approach?
LEFTHOOK_QUIET=execution_out git push

Sure.
(feature/sync) $> LEFTHOOK_QUIET=execution_out git push
Lefthook v1.3.12
RUNNING HOOK: pre-push

  EXECUTE >  sync.sh
refs/heads/feature/sync 4d9067adae1709abf48c9598c35afbdc8164ab4c refs/heads/feature/sync 8fb4420dd8818b68115df7abd121ba3b2784b2fc
waiting...
refs/heads/feature/sync
done

SUMMARY: (done in 4.04 seconds)
✔  sync.sh
Enumerating objects: 5, done.
Counting objects: 100% (5/5), done.
Delta compression using up to 8 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 333 bytes | 166.00 KiB/s, done.
Total 3 (delta 2), reused 0 (delta 0), pack-reused 0
To https://erda.cloud/terminus/dop/terminus-scm-source/scm-ui
   8fb4420d..4d9067ad  feature/sync -> feature/sync

BTW: My git version: 2.40.1.  macOS: 13.3.1 (22E261)

Ok, this thing drive me crazy :)
I have Arch Linux, git version: 2.40.1
Try removing follow flag. Does it change anything?

Ok, this thing drive me crazy :)
I have Arch Linux, git version: 2.40.1
Try removing follow option. Does it change anything?
BTW, follow option doesn't affect STDIN, it is only for STDOUT to appear without a delay

Still no luck yet. I think it's probably an issue specific to macOS. No worries, I can use it without skip execution and execution_out.
Very much appreciated.

Ok. But if you have time, I'd be glad to check a few possible reasons of this behavior:

Maybe it forwards STDOUT to STDERR. What if you do git push 2>&1
Or try interactive: true option for the script. It might be pty-related issue. With interactive: true we don't use pty lib.

Anyway thank you for bringing this feature idea. It's a pity it doesn't work correctly for you :confused:

Maybe it forwards STDOUT to STDERR. What if you do git push 2>&1
Or try interactive: true option for the script. It might be pty-related issue. With interactive: true we don't use pty lib.

I have just tried these two ways, and they all make no difference, It's really weird.
And I'm always happy to do more tests.

Hi, Any plan to fix the skip issue for macOS in the future version? Thanks

I put this issue on my radar. I will come with the details next week

Hi @hustcer! I have tried to reproduce this on my macOS machine but I had no luck. I have no idea why this might happen. Do you have an example repo with this config that I can fork and test on?

@mrexox Hi, just try https://github.com/hustcer/setup-nu/tree/feature/lefthook I have just added a demo pre-push hook on feature/lefthook branch, for the config: https://github.com/hustcer/setup-nu/blob/d631c0697e03cc5b5fbce80ef5dfa0048456251e/lefthook.yml#LL15C25-L15C137 I expect "Skips printing successfully executed commands, but don not skip execution_out, however no output will be printed"
Hope it will helps

I've created a PR with the changes to config that should work. Could you check it, please? Also I'm preparing a new release with the fix for interactive option - I noticed that stdout is being printed despite the execution_out setting.

THANKS for the quick reply I have left my mac laptop at office, I will give it a try tomorrow

I've created a PR with the changes to config that should work (nothing echoes to stdout for me on git push). Could you check it, please?

@mrexox Hi, I have just tested your PR, it does not work as expected, for this config: https://github.com/hustcer/setup-nu/blob/feature/lefthook/lefthook.yml, I don't want to see EXECUTE > sync.sh, and I want to see all the echos output, that's why I add execution to skip_output and comment out execution_out

Oh, I see, so you want to see something like this, right?
$ git push fork --force

refs/heads/feature/lefthook b45ceab5227c2d645255a30ad895b34cc0d51875 refs/heads/feature/lefthook 81d2b27a4b09f0340ae7e987229f9221890ef027
Output from sync.sh in pre push hook:
refs/heads/feature/lefthook
b45ceab5227c2d645255a30ad895b34cc0d51875
refs/heads/feature/lefthook
81d2b27a4b09f0340ae7e987229f9221890ef027
----------------------------------

Enumerating objects: 8, done.
Counting objects: 100% (8/8), done.
Delta compression using up to 8 threads
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 1.90 KiB | 1.90 MiB/s, done.
Total 6 (delta 4), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (4/4), completed with 2 local objects.
To github.com:mrexox/setup-nu.git
 + 81d2b27...b45ceab feature/lefthook -> feature/lefthook (forced update)

Oh, I see, so you want to see something like this, right?

Yeah, that's it. It's better not print refs/heads/feature/lefthook b45ceab5227c2d645255a30ad895b34cc0d51875 refs/heads/feature/lefthook 81d2b27a4b09f0340ae7e987229f9221890ef027

Hm, I'm not quite sure about why refs/heads/feature/lefthook b45ceab5227c2d645255a30ad895b34cc0d51875 refs/heads/feature/lefthook 81d2b27a4b09f0340ae7e987229f9221890ef027 gets printed but this is not lefthook-generated output, so it's from the script.
I think I got you, I'll provide an option execution_info that will skip printing EXECUTE > ... lines.


suite: use --subset X/Y as hints

http://tracker.ceph.com/issues/13855

I'm a bit confused, iirc, the mincyclicity argument to _build_matrix was supposed to ensure that chopping the output into  pieces retained the property.  I'll take another look after a good night's sleep :)

The problem is that dividing the resulting matrix into outof slices may not obey the minscanlen() constraint. Maybe the right fix would be that generate_combinations detects when that happens and throw an error ?


Add a probe for the axon npm module.

We will do a full review when we merge the adapter branch back into master.


Fix broken link in README.md

ISSUE
CONTRIBUTE.md link is broken in the README.md file.
TO-DO

[ ] Rename from CONTRIBUTE.md to CONTRIBUTE and
[ ] Link it property to CONTRIBUTE.md

CODE TO FIX
[CONTRIBUTE](CONTRIBUTE.md)

Thank you for the pull @navistonks, welcome to the project!


Add validated data args in default factory

Change Summary
Add feature pydantic https://github.com/pydantic/pydantic/issues/9789
Related issue number

Checklist

[ ] Unit tests for the changes exist
[ ] Documentation reflects the changes where applicable
[ ] Pydantic tests pass with this pydantic-core (except for expected changes)
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @davidhewitt

please review

Thanks @nix010 for the implementation.
The proper way (and this will simplify things even more here) to do this is to inspect the default_factory callable in Pydantic, using inspect. The core schema structure will have to be changed to add a new has_values_arg boolean entry (name TBD).
As an existing example, we do this in pydantic._internal.decorators.inspect_validator to determine if validators take the info argument or not.

Thanks @nix010 for the implementation.
The proper way (and this will simplify things even more here) to do this is to inspect the default_factory callable in Pydantic, using inspect. The core schema structure will have to be changed to add a new has_values_arg boolean entry (name TBD).
As an existing example, we do this in pydantic._internal.decorators.inspect_validator to determine if validators take the info argument or not.

@Viicos So my intention is exactly the same. But to inspect the function within fn default_value(), I went with the __code__ attr there. Can you advise me on a better way to do that?

@Viicos is referring to https://github.com/pydantic/pydantic/blob/6c3d3b3bb255422fc64eec8e9014016743207ff0/pydantic/_internal/_decorators.py#L514-L548
Basically, we want to inspect the function in pydantic with the inspect module, then modify the core schema accordingly (we'll have to add an argument). We can match on that argument to decide on whether we need to pass the validated data, in pydantic-core.

So my intention is exactly the same. But to inspect the function within fn default_value(), I went with the __code__ attr there. Can you advise me on a better way to do that?

Ok. So there will be a bool var in the model core schema to flag if the data need to pass in to the default_factory or not. Right ?

Ok. So there will be a bool var in the model core schema to flag if the data need to pass in to the default_factory or not. Right ?

Correcet, probably on the field core schema

Replaced by https://github.com/pydantic/pydantic-core/pull/1491. Thanks @nix010, you'll be added as a co-author on the pydantic PR.


Generate grpc bootstrap only when DISABLE_ENVOY=true and GRPC_XDS_BOO…

…TSTRAP set
Please provide a description of this PR:
Without this, it always generate grpc bootstrap for sidecar.
k exec -ti sleep-557747455f-n4lf8 -c istio-proxy -- ls etc/istio/proxy/
SDS  XDS  envoy-rev0.json  grpc-bootstrap.json

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[x] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test release-notes_istio

integ-helm_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-helm_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test release-notes_istio

integ-helm_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-helm_istio

integ-ipv6_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-ipv6_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test release-notes_istio

integ-helm_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-helm_istio

integ-ipv6_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-ipv6_istio

integ-distroless_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-distroless_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test release-notes_istio

integ-helm_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-helm_istio

integ-ipv6_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-ipv6_istio

integ-distroless_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-distroless_istio

integ-pilot-istiodremote_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test release-notes_istio

integ-helm_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-helm_istio

integ-ipv6_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-ipv6_istio

integ-distroless_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-distroless_istio

integ-pilot-istiodremote_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-istiodremote_istio

integ-pilot-multicluster_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test release-notes_istio

integ-helm_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-helm_istio

integ-ipv6_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-ipv6_istio

integ-distroless_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-distroless_istio

integ-pilot-istiodremote_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-istiodremote_istio

integ-pilot-multicluster_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-multicluster_istio

integ-pilot-istiodremote-mc_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-istiodremote-mc_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test release-notes_istio

integ-helm_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-helm_istio

integ-ipv6_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-ipv6_istio

integ-distroless_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-distroless_istio

integ-pilot-istiodremote_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-istiodremote_istio

integ-pilot-multicluster_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-multicluster_istio

integ-pilot-istiodremote-mc_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-istiodremote-mc_istio

integ-operator-controller_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-operator-controller_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test release-notes_istio

integ-helm_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-helm_istio

integ-ipv6_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-ipv6_istio

integ-distroless_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-distroless_istio

integ-pilot-istiodremote_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-istiodremote_istio

integ-pilot-multicluster_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-multicluster_istio

integ-pilot-istiodremote-mc_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-istiodremote-mc_istio

integ-operator-controller_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-operator-controller_istio

integ-pilot_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test release-notes_istio

integ-helm_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-helm_istio

integ-ipv6_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-ipv6_istio

integ-distroless_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-distroless_istio

integ-pilot-istiodremote_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-istiodremote_istio

integ-pilot-multicluster_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-multicluster_istio

integ-pilot-istiodremote-mc_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-istiodremote-mc_istio

integ-operator-controller_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-operator-controller_istio

integ-pilot_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot_istio

integ-cni_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-cni_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test release-notes_istio

integ-helm_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-helm_istio

integ-ipv6_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-ipv6_istio

integ-distroless_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-distroless_istio

integ-pilot-istiodremote_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-istiodremote_istio

integ-pilot-multicluster_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-multicluster_istio

integ-pilot-istiodremote-mc_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-istiodremote-mc_istio

integ-operator-controller_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-operator-controller_istio

integ-pilot_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot_istio

integ-cni_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-cni_istio

integ-security-multicluster_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test release-notes_istio

integ-helm_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-helm_istio

integ-ipv6_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-ipv6_istio

integ-distroless_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-distroless_istio

integ-pilot-istiodremote_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-istiodremote_istio

integ-pilot-multicluster_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-multicluster_istio

integ-pilot-istiodremote-mc_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-istiodremote-mc_istio

integ-operator-controller_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-operator-controller_istio

integ-pilot_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot_istio

integ-cni_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-cni_istio

integ-security-multicluster_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-security-multicluster_istio

integ-security-istiodremote_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-security-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test release-notes_istio

integ-helm_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-helm_istio

integ-ipv6_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-ipv6_istio

integ-distroless_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-distroless_istio

integ-pilot-istiodremote_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-istiodremote_istio

integ-pilot-multicluster_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-multicluster_istio

integ-pilot-istiodremote-mc_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-istiodremote-mc_istio

integ-operator-controller_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-operator-controller_istio

integ-pilot_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot_istio

integ-cni_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-cni_istio

integ-security-multicluster_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-security-multicluster_istio

integ-security-istiodremote_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-security-istiodremote_istio

integ-security_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-security_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test release-notes_istio

integ-helm_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-helm_istio

integ-ipv6_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-ipv6_istio

integ-distroless_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-distroless_istio

integ-pilot-istiodremote_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-istiodremote_istio

integ-pilot-multicluster_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-multicluster_istio

integ-pilot-istiodremote-mc_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-istiodremote-mc_istio

integ-operator-controller_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-operator-controller_istio

integ-pilot_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot_istio

integ-cni_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-cni_istio

integ-security-multicluster_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-security-multicluster_istio

integ-security-istiodremote_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-security-istiodremote_istio

integ-security_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-security_istio

integ-telemetry-mc_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-telemetry-mc_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test release-notes_istio

integ-helm_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-helm_istio

integ-ipv6_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-ipv6_istio

integ-distroless_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-distroless_istio

integ-pilot-istiodremote_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-istiodremote_istio

integ-pilot-multicluster_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-multicluster_istio

integ-pilot-istiodremote-mc_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-istiodremote-mc_istio

integ-operator-controller_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-operator-controller_istio

integ-pilot_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot_istio

integ-cni_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-cni_istio

integ-security-multicluster_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-security-multicluster_istio

integ-security-istiodremote_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-security-istiodremote_istio

integ-security_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-security_istio

integ-telemetry-mc_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-telemetry-mc_istio

integ-telemetry_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-telemetry_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test release-notes_istio

integ-helm_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-helm_istio

integ-ipv6_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-ipv6_istio

integ-distroless_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-distroless_istio

integ-pilot-istiodremote_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-istiodremote_istio

integ-pilot-multicluster_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-multicluster_istio

integ-pilot-istiodremote-mc_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot-istiodremote-mc_istio

integ-operator-controller_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-operator-controller_istio

integ-pilot_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-pilot_istio

integ-cni_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-cni_istio

integ-security-multicluster_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-security-multicluster_istio

integ-security-istiodremote_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-security-istiodremote_istio

integ-security_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-security_istio

integ-telemetry-mc_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-telemetry-mc_istio

integ-telemetry_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-telemetry_istio

integ-telemetry-istiodremote_istio
2caae6a0b91150b74086552554e39d5418d3d656
link
true
/test integ-telemetry-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Not sure the default setting though

Not sure the default setting though

The default setting of what?
Also we can't have only when DISABLE_ENVOY; It's possible to have envoy enabled and exclude some gRPC ports from capture. That way if a Pod runs some regular TCP/HTTP stuff + gRPC, we can still use Envoy for non-grpc traffic.

The default setting of what?

The xds bootstrap env is not empty.
The use case sounds very weird,

This usecase has been cited by @costinm in the past.
I don't really see the negative impact in generating the bootstrap. We don't have the actual env set, so the gRPC library won't actually use it unless the user modifies their app container to do so.

The use case is an app that is using both proxyless gRPC and TCP/HTTP services with Envoy sidecar.
Note that we are looking at other ways to generate the bootstrap - possibly as a library that can be linked to the app itself, so we may be able to remove this, but let's keep it until we have a replacement.

SGTM


Custom app gets redirected to :/tasks

My actions before raising this issue

[X] Read/searched the docs
[X] Searched past issues
[X] Consulted google

I have made a custom plugin to Cvat and I have it is working fine on when the url does not contain the port number. But when the portnumber is added I get automagically redirected to :8000/tasks.
Expected Behaviour

That I can access my app with the port number in the url without being redirected
Current Behaviour

I get redirected to /tasks even if my url is valid to my custom app.
Your Environment

59430bc  (tag: v1.0.0-alpha) Add missing information into changelog.
Docker version 19.03.8, build afacb8b7f0
Ubuntu 16.04

I think the issue is related to me changing the port when allowing all hosts:
`version: "2.3"
services:
cvat:
environment:
ALLOWED_HOSTS: '*'
ports:
- "80:8080"`
But it is strange since an app like documents is accessable both through
:/documentation/user_guide.html and
/documentation/user_guide.html
whilst my app is only accessable with /<my_app> and not :/<my_app>

@azhavoro , could you please take a look? I believe it is a proxy server configuration.
@nakceb , could you please share more information about the plugin. What is the purpose of the plugin. Are you going to open source it?

@nmanovic Hi, yes I found the issue. My problem was that I had configured cvat to port 80:8080.
Then I did not have my proxy configured for my custom app.
Solution was to add my app in the cvat.conf.template. (I also removed the port external port for the cvat container, should not have been there in the first place)


Presenting Popover in UIButton Inside UITableViewCell

How to do this? When I do it, the arrow gets pointed somewhere else.

@jaytrixz I think this article is to your help.
http://stackoverflow.com/questions/2795900/how-can-i-get-the-uitableview-scroll-position-so-i-can-save-it

@corin8823 Thanks! Checking it out now.


AppDeployIntegrationTest "backoff delays are reset on configuration changes" is unstable

Marked here: f03285b20817909a1c08169436b26af5520c0a1b
Seen here: ??? @unterstein where did you see this fail?

https://jenkins.mesosphere.com/service/jenkins/job/public-test-marathon-phabricator/706/

Marked as serial in cc82191e0fffff21b1d6b1c3380089513473affb and seems to be passing reliably now

great


Detect and prevent starting during demo cutscene

lgtm. Eventually we should NOP the demo cutscene call.

That's probably the easiest solution, though another option might be to find a way to skip the FMV while it's in progress.


[DISSCUSSION] the memory tracking approach that better handles shared buffers

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

See this comment https://github.com/apache/arrow-rs/issues/6363#issuecomment-2366788331,
when the Buffer's data is shared between many Buffer, the capacity() method will always return the total buffer memory usage, which causes the issue #6363, we need discussion the better memory track for shared buffers.
https://github.com/apache/arrow-rs/blob/d05cf6d5e74e79ddcacaa4a68bddaba230b0f163/arrow-buffer/src/buffer/immutable.rs#L166-L168
Describe the solution you'd like

The easy way to do this is to return the length and the unused capacity of the Buffer like pr #6438,
    pub fn capacity(&self) -> usize {
        self.length + self.data.capacity() - self.data.len()
    }

          This is changing what these methods report to something else that I'm not sure is correct. Whilst this formulation may benefit your use-case, there are common situations where it will now under report... Perhaps you might file a ticket to discuss a memory tracking approach that better handles shared buffers, as that is the actual issue here. This is not a bug

Originally posted by @tustvold in https://github.com/apache/arrow-rs/issues/6438#issuecomment-2367426442
But as @tustvold said, we need more discussion.
Describe alternatives you've considered

Additional context

https://github.com/apache/arrow-rs/issues/3960 is likely related.
Tagging @jhorstmann @waynexia @alamb

I personally prefer the allocator approach which gives the most accurate stats in theory. Given we in some aspects encourage sharing underlying buffer and arrays, only changing the behavior of .capacity() would still cause problems for end users when they want to track how many physical memories are used somewhere (e.g., in one query session).

I personally prefer the allocator approach which gives the most accurate stats in theory.

I agree with @waynexia  -- if the usecase is "accurately track the total memory used across some number of Arrays which (potentially) share underlying Buffers", I think this needs a hook into the underlying allocator. There is proposed PR https://github.com/apache/arrow-rs/pull/6336 which might be worth a look (I haven't had a chance to really understand it yet myself)

Builders are an interesting point, but come with two potential challenges to be aware of:

Builders tend to over-allocate to avoid repeatedly reallocating
Updating memory accounting per element is likely prohibitively expensive

This means any "eager" memory computation is likely to work poorly, however, the lazy approach as currently implemented for arrays could actually work quite well.
I could see a world where we remove lazy array memory tracking in favour of eager allocation tracking, and add lazy memory tracking for builders

As this appears to have stalled slightly I have created a POC in https://github.com/apache/arrow-rs/pull/6590 for what I think this could look like


section: Make sure to normalize line endings in body

This avoids having mixed line endings in final text
fixes #715, hey @alexjfisher

Perhaps this needs a rebase now?

@ekohl done, but someone still needs to review :)

Thanks, @lazyfrosch! Now merged and will be in the next release.


Setup task randomly fails

Situation:
On a symfony project, I use proxy jump to reach target server through a bastion.
I'm migrating deploy tool from an easycorp/easydeploybundle fork, which works well, but is no longer maintained.
Issue:
Even if i'm sometime able to deploy, the setup task randomly fails.
Config :
Symfony : 6.3
Deployer : 7.3.3
// ssh config
Host hostname
	User user
	Hostname bastionurl
	ForwardAgent yes
	ProxyJump  www-data@address

// host configuration
host('hostname')
    ->setForwardAgent(true)
    ->set('config_file', '~/.ssh/config')
    ->set('deploy_path', '~/www')
    ->setSshMultiplexing(true)
    ->set('http_user', 'user');

Output :
task deploy:info
[hostname] /usr/bin/php8.2 /home/user/Work/vault/vendor/deployer/deployer/dep worker --port 41007 --task deploy:info --host hostname --decorated -vvv
[hostname] info deploying development
done on hostname
done deploy:info 122ms
task deploy:setup
[hostname] /usr/bin/php8.2 /home/user/Work/vault/vendor/deployer/deployer/dep worker --port 41007 --task deploy:setup --host hostname --decorated -vvv
[hostname] ssh '-F' '/home/user/.ssh/config' '-A' '-o' 'ControlMaster=auto' '-o' 'ControlPersist=60' '-o' 'ControlPath=~/.ssh/hostname' 'hostname ': 369f170a5680d20ec1ea; bash -ls'
[vault-pp] run [ -d ~/www ] || mkdir -p ~/www;
cd ~/www;
[ -d .dep ] || mkdir .dep;
[ -d releases ] || mkdir releases;
[ -d shared ] || mkdir shared;
[hostname]  error  in setup.php on line 6:
[hostname] exit code -1 (Unknown error)
done deploy:setup 2s 158ms
ERROR: Task deploy:setup failed!
task deploy:failed
[hostname] /usr/bin/php8.2 /home/user/Work/vault/vendor/deployer/deployer/dep worker --port 41007 --task deploy:failed --host hostname --decorated -vvv
done on hostname
done deploy:failed 90ms
task deploy:unlock
[hostname] /usr/bin/php8.2 /home/user/Work/vault/vendor/deployer/deployer/dep worker --port 41007 --task deploy:unlock --host hostname --decorated -vvv
[hostname ssh '-F' '/home/user/.ssh/config' '-A' '-o' 'ControlMaster=auto' '-o' 'ControlPersist=60' '-o' 'ControlPath=~/.ssh/hostname' 'hostname' ': c818b48aa46313af89da; bash -ls'
[hostname] run rm -f ~/www/.dep/deploy.lock
[hostname]
[hostname] Echec de la connexion à la cible secondaire
[hostname]  error  in lock.php on line 21:
[hostname] exit code -1 (Unknown error)
done deploy:unlock 2s 644ms
ERROR: Task deploy:unlock failed!

I get the same problem here, my proxy jump points to a bastion server that connects to a secondary target

You might try this configuration : https://github.com/deployphp/deployer/issues/3558#issuecomment-2027081478
It might help to determine whether the issue is related to deployer, or your environment


mixed array errors on typed array

Functions with a parameter annotations with mixed[] error when passed a primitive array as in the following:
const f = (xs: mixed[]) => {};

const stringArray: string[] = ['abc', 'def'];

f(stringArray); // ERROR

Expected that as string[] is part of the union for mixed[] that it does not error on a typed array.
Example

Use $ReadOnlyArray<mixed> instead of Array<mixed> (mixed[]):
const f = (xs: $ReadOnlyArray<mixed>) => {};

see #4180 #4251 #3869 #3696 for explanation (variance)


Poor formatting of long slice pattern

The following (somewhat icky) code lays out the entire slice or array pattern on one line, rather than splitting it up like it would for an array literal or struct pattern.
fn test() {
    let mut magic_data = [0; 8];
    let [magic_data0, magic_data1, magic_data2, magic_data3, magic_data4, magic_data5, magic_data6, magic_data7] =
        &mut magic_data;
    let [magic_data0, magic_data1, magic_data2, magic_data3, magic_data4, magic_data5, magic_data6, ..] =
        &mut magic_data;
    // should format like literals do:
    let copy = [
        magic_data0,
        magic_data1,
        magic_data2,
        magic_data3,
        magic_data4,
        magic_data5,
        magic_data6,
    ];
}

@jrose-signal Thanks for reaching out.
It's not totally clear from your example, but you're saying you'd like each array to be formatted vertically?

If you're using nightly rustfmt you can set version=Two to get the vertical formatting that you're looking for.

It's not totally clear from your example, since there isn't an input and an output snippet, but what I understand is you'd like each array to be formatted vertically?

Sorry, yes. That's a snippet formatted the way rustfmt currently outputs it on stable (as tested on play.rust-lang.org), and I'd like the pattern matching lines to be formatted similarly to the line building up copy.

If you're using nightly rustfmt you can set version=Two to get the vertical formatting that you're looking for.

Oh, sweet, thank you! I don't think it's worth the unstable option, but even so maybe this can be closed. Or maybe it should stay open for better handling in "=One" mode.

Thank you both, but going to close. The various stability constraints prohibit us from being able to make such a change that's applied by default, which is most likely why this is gated behind the version flag.
At some point in the hopefully-not-too-terribly-distant future the output from version=Two will be the default, but there's no action that can be taken here.


finall fix for parsing strings and number

Description
Changes proposed in this pull request:

fix for a parsing string to a number.

Related issue(s)

/test pre-busola-lighthouse


build current fails due to missing attributes

See: https://<IP_ADDRESS>:8443/job/Port-Build/214/console
and Error: ./xalloc.h:141:43: error: use of undeclared identifier '__noreturn__'
VERBOSE: '"./configure" --prefix=/jenkins/workspace/Port-Build/install  CC=xlclang "CPPFLAGS=-DNSIG=9 -D_XOPEN_SOURCE=600 -D_ALL_SOURCE -D_OPEN_SYS_FILE_EXT=1 -D_AE_BIMODAL=1 -D_ENHANCED_ASCII_EXT=0xFFFFFFFF " "CFLAGS=-qascii -std=gnu11 " CXX=xlclang++ "CXXFLAGS=-+ -qascii " "LDFLAGS= " >"20220902_121119_config.log" 2>&1'
Usage: chtag -m | -t [-c codeset] [-hqRv] pathname...
	chtag -b | -r [-hqRv] pathname...
	chtag -c codeset [-hqRv] pathname...
	chtag -p [-hqR] pathname...
Running Build...
VERBOSE: '"make" -j1 CC=xlclang "CPPFLAGS=-DNSIG=9 -D_XOPEN_SOURCE=600 -D_ALL_SOURCE -D_OPEN_SYS_FILE_EXT=1 -D_AE_BIMODAL=1 -D_ENHANCED_ASCII_EXT=0xFFFFFFFF " "CFLAGS=-qascii -std=gnu11 " CXX=xlclang++ "CXXFLAGS=-+ -qascii " "LDFLAGS= " >"20220902_121119_build.log"'
In file included from ./dfa.c:25:
./dfa.h:150:8: warning: unknown attribute '_Noreturn' ignored [-Wunknown-attributes]
extern _Noreturn void dfaerror (const char *);
       ^
./../config.h:511:37: note: expanded from macro '_Noreturn'
#  define _Noreturn __attribute__ ((__noreturn__))
                                    ^
/usr/include/le/features.h:791:26: note: expanded from macro '__noreturn__'
    #define __noreturn__ _Noreturn
                         ^
In file included from ./dfa.c:63:
./xalloc.h:54:31: error: use of undeclared identifier '__noreturn__'
extern void xalloc_die (void) ATTRIBUTE_NORETURN;
                              ^
./xalloc.h:38:46: note: expanded from macro 'ATTRIBUTE_NORETURN'
#  define ATTRIBUTE_NORETURN __attribute__ ((__noreturn__))
                                             ^
/usr/include/le/features.h:791:26: note: expanded from macro '__noreturn__'
    #define __noreturn__ _Noreturn
                         ^
./../config.h:511:37: note: expanded from macro '_Noreturn'
#  define _Noreturn __attribute__ ((__noreturn__))
                                    ^
In file included from ./dfa.c:63:
./xalloc.h:141:43: error: use of undeclared identifier '__noreturn__'
extern void r_fatal(const char *msg, ...) ATTRIBUTE_NORETURN ;
                                          ^
./xalloc.h:38:46: note: expanded from macro 'ATTRIBUTE_NORETURN'
#  define ATTRIBUTE_NORETURN __attribute__ ((__noreturn__))
                                             ^
/usr/include/le/features.h:791:26: note: expanded from macro '__noreturn__'
    #define __noreturn__ _Noreturn
                         ^
./../config.h:511:37: note: expanded from macro '_Noreturn'
#  define _Noreturn __attribute__ ((__noreturn__))
                                    ^
1 warning and 2 errors generated.
Error while processing ./dfa.c.
CCN0793(I) Compilation failed for file ./dfa.c.  Object file not created.
make[2]: *** [Makefile:484: dfa.o] Error 12
make[1]: *** [Makefile:757: all-recursive] Error 1
make: *** [Makefile:574: all] Error 2
Usage: chtag -m | -t [-c codeset] [-hqRv] pathname...
	chtag -b | -r [-hqRv] pathname...
	chtag -c codeset [-hqRv] pathname...
	chtag -p [-hqR] pathname...
***ERROR: Make failed. Log: 20220902_121119_build.log
Build step 'Execute shell' marked build as failure
Archiving artifacts
[WS-CLEANUP] Deleting project workspace...
[WS-CLEANUP] Deferred wipeout is disabled by the node property...
[WS-CLEANUP] done
Finished: FAILURE

One workaround is to set export ZOPEN_EXTRA_CPPFLAGS="-DATTRIBUTE_NORETURN=_Noreturn"

PR: https://github.com/ZOSOpenTools/gawkport/pull/8

This is fixed in ibm-clang.  I was able to get LE to change the system headers so they don't define noreturn for clang.  We should fix the xlclang headers to do the same.

Closing this as it's now resolved with the workaround


ENH: DataFrame.to_csv support for "compression='gzip'"

the DataFrame.to_csv method seems to accept a "compression" named parameter:
import numpy as np,pandas as pd
data=np.arange(10).reshape(5,2)
df=pd.DataFrame(data,columns=['a','b'])
df.to_csv('test.csv.gz',compression='gzip')

However, the file it creates is not compressed at all:
francesco@i3 ~/Desktop $ cat test.csv.gz
,a,b
0,0,1
1,2,3
2,4,5
3,6,7
4,8,9
How about either (i) actually implementing compression, or at least (ii) raise an error? The current behavior is confusing...

+1, a compression argument for DataFrame.to_csv would spare many user headaches.
In Python 3.4, I use the following workaround:
with gzip.open('path_to_file', 'wt') as write_file:
    data_frame.to_csv(write_file)

@dhimmel If you're interested in putting in the work, I think we're still open to a PR to add this feature.

@shoyer, okay I will keep this in mind. I have a bit to learn first.

Thank you so much for implementing this! Besides the aesthetics POV and fixing the asymmetry between read/write, this is a huge improvement to some people like me.

This did not work for me, the output file isn't compressed. I'm using Pandas 0.18.1

@jsmedmar could you open a new issue with that demonstrating the problem? Thanks.

@jsmedmar I see the "compression" argument is properly documented and it is working
http://pandas.pydata.org/pandas-docs/version/0.19.0/generated/pandas.DataFrame.to_csv.html
One confusing thing is that if you run the following code
import numpy as np
import pandas as pd

data = np.arange(10).reshape(5, 2)
df = pd.DataFrame(data, columns=['a', 'b'])
print(df)
df.to_csv('test.csv.gz', compression='gzip')
"""
   a  b
   0  0  1
   1  2  3
   2  4  5
   3  6  7
   4  8  9
"""

you get a compressed file, but opening it in vim automatically decompresses it, so to verify that compression happened use the "head" command:
$ head test.csv.gz
D5X�test.csv�70


luhn: update examples to reinforce manipulating from the right

This updates the luhn examples to operate on even-length strings. This reinforces the idea that the numbers to be doubled are counted from the right, not from the left. (The previous odd-length example string did not emphasize this distinction.)

Related to #547

@petertseng commit split into two!

I agree on leaving the odd length examples to the tests; seems like the right place to discover that distinction if the (now multiple, consistent) clues from the description weren't enough.

LGTM!

Is there a "minimum number of approvals protocol" within this repo? I'm a little unclear as to when a PR is considered good to merge. Should I be merging this myself now that it has received 2 separate thumbs up? Thanks 🤓


chore(paper): address comments from @idoby

This PR addresses the comments from @idoby, especially from https://github.com/openjournals/joss-reviews/issues/6915#issuecomment-2185022268.
Ref: https://github.com/openjournals/joss-reviews/issues/6915

Looks good to me!


Don't allow exceptions during client creation

I just noticed that the current draft spec has:

Requirement 1.19
No methods, functions, or operations on the client should ever throw exceptions, or otherwise abnormally terminate. Flag evaluation calls must always return the default value in the event of abnormal execution. Exceptions include functions or methods for the purposes for configuration or setup.

I understand the motivation for never throwing exceptions, but I think we're failing to meet the spirit of this for client-side JS if we allow exceptions when creating a client, because of the unique lifecycle of browser-based apps. For a client-side app the client is often created just before an evaluation is done, so an exception thrown during client creation is pretty much just as disruptive as an exception when you call a method.
Because of this, I would propose that the spec not allow exceptions during client creation.

This also might relate to a question that's come up a few times: do we want to expose events (specifically readiness events) from the provider interface? Providers could sidestep this by requiring SDKs that have a readiness event simply be ready BEFORE passing them into the provider. For instance, the CloudbeesProvider may require an already-initialized Cloudbees SDK instance. Not sure.

I guess the only question here is if we should specifically add a requirement that .getClient() calls never throw. I think it's probably a good thing to do.


proposing change

making this similar to other topics on azure

Hi @4c74356b41, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@charwen - Please review this contribution to your article in the public repo.

#sign-off

@4c74356b41  - I ran this change through staging on our private side. It turns out this include file is used in 26 different articles. Updating the format to make it an Azure note causes problems in some of the articles, so I'm going to close this. Thanks for the suggestion.

Ok, no worries!


"Awaitable[Any]" is incompatible with "Coroutine[Any, Any, Any]"

Environment data

Language Server version: 2020.7.3 (pyright 5004efe5)
OS and version: macOS 10.15.6
Python version (& distribution if applicable, e.g. Anaconda): 3.8.5 via Homebrew

Expected behaviour
Awaitable[Any] should be compatible with Coroutine[Any, Any, Any]. Or, potentially, instead of being an Awaitable[Any] an un-awaited coroutine should be Coroutine[Any, Any, Any]? For comparison, I do not believe mypy views the below code snippet as an error, though it is possible I'm using mypy incorrectly.
Details from mypy are available here: https://mypy.readthedocs.io/en/stable/more_types.html#async-and-await
Actual behaviour
Pylance throws an error:
Argument of type "Awaitable[str]" cannot be assigned to parameter "coro" of type "Coroutine[Any, Any, Any]" in function "inspector"
  "Awaitable[str]" is incompatible with "Coroutine[Any, Any, Any]"Pylance (reportGeneralTypeIssues)

Logs
I don't think logs are necessary for this issue, can provide if requested.
Code Snippet / Additional information
Here's a silly example that just does some basic introspection of a passed coroutine. It runs as-is if copied into ipython, but pylance flags with the error from above on the last line, inner(1, "test"). I don't have much experience with mypy but I do not believe it is flagging the same line as an error.
import asyncio
from typing import Any, Coroutine

async def inspector(coro: Coroutine[Any, Any, Any]):
    print(coro.cr_frame.f_locals)
    return await coro

async def inner(sleep: int, message: str) -> str:
    await asyncio.sleep(sleep)
    print(message)
    return message

async def outer():
    await inspector(inner(1, "test"))

Thanks for the bug report. Currently, Pylance infers the type Awaitable[T] for an async function's return type. Mypy appears to infer the type Coroutine[Any, Any, T]. Both are arguably correct because Coroutine derives from Awaitable, but I think it's reasonable to change the behavior to match mypy in this case. This change will be in the next version of Pylance.

This didn't quite make it into 2020.7.4, but will be in the next release.

This issue has been fixed in version 2020.8.0, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/master/CHANGELOG.md#202080-5-august-2020

Shouldn't this PR make the following valid?
import typing as t
import asyncio
import functools
from concurrent.futures import Executor
from typing_extensions import ParamSpec

T = t.TypeVar("T")
P = ParamSpec("P")

def to_async(executor: t.Optional[Executor] = None):
    def decorator(f: t.Callable[P, T]) -> t.Callable[P, t.Awaitable[T]]:
        @functools.wraps(f)
        def wrapper(*args: P.args, **kwargs: P.kwargs) -> t.Awaitable[T]:
            loop = asyncio.get_event_loop()
            return loop.run_in_executor(executor, functools.partial(f, *args, **kwargs))

        return wrapper

    return decorator

@to_async()
def sync(name: str) -> int:
    return 2

async def main():
    return await sync("test")

asyncio.run(main())
asyncio.run(sync("test"))  # <-- "Awaitable[int]" is incompatible with "Coroutine[Any, Any, _T@run]"

@nixfixbix, no, your code sample should result in a type violation error. Coroutine derives from (i.e. is a subclass of) Awaitable. That means you can pass a Coroutine to a function that expects an Awaitable, but not vice versa. The asyncio.run method specifically requires a Couroutine, and you're attempting to pass it an Awaitable.
The title of this issue is misleading because it doesn't describe the underlying cause of the problem the OP was seeing. The fix was to infer a return type of Coroutine rather than Awaitable for an async function.

@nixfixbix, no, your code sample should result in a type violation error. Coroutine derives from (i.e. is a subclass of) Awaitable. That means you can pass a Coroutine to a function that expects an Awaitable, but not vice versa. The asyncio.run method specifically requires a Couroutine, and you're attempting to pass it an Awaitable.
The title of this issue is misleading because it doesn't describe the underlying cause of the problem the OP was seeing. The fix was to infer a return type of Coroutine rather than Awaitable for an async function.

Thanks @erictraut - I don't understand how you always are able to reply so quickly and great answers too. Great job! 👏🏼


Stack trace contains links that fail

Perhaps we should only consider path-like strings if they are absolute (i.e. start with path separator)

Fixed - see #193