Type definitions are not up to date

The type definitions maintained over at DefinitelyTyped seem to be out of sync with the current API.
Please can you keep these typings in sync with API otherwise it makes writing typescript consumers of the SDK very painful to write.
Thanks
Christian
Example
Current API
module Microsoft.ApplicationInsights.Telemetry {
    "use strict";

    export class PageView extends AI.PageViewData implements ISerializable {

Visaul Studio code showing compiler failure:

FYI, here are the extra [augmented] typings I needed for the code I references thus far in the SDK:

declare namespace AI {
    export enum DependencyKind {
        SQL = 0,
        Http = 1,
        Other = 2,
    }
}
declare namespace Microsoft.Telemetry {
    export interface Base {
        baseData: {
            dependencyKind: AI.DependencyKind;
            properties: { [property: string] : any }
        }
    }
}
declare namespace Microsoft.ApplicationInsights {
    export namespace Telemetry {
        // missing PageView class and its static members
        export namespace PageView {
            let envelopeType: string;
        }
        // missing PageView class and its static members
        export namespace RemoteDependencyData {
            let envelopeType: string;
        }
    }
}

Thank you reporting this issue. We did some cleanup work and extracted interfaces to a separate project JavaScriptSDK.Interfaces. I'm working on updating DefinitelyTyped files.
I have an initial version here.

Cool.
Out of interest, are you letting the tsc compiler generate the d.ts file(s) for you, or are you hand coding these?
I'm curious as I had the same decision to make when writing angular-cc-appinsights.
For angular-cc-appinsights, I found that the tsc tool did a good job of generating the type definitions for my library.

OK good to know

I'll update type definitions in two steps:

Update type definitions for files which are currently exposed in JavaScriptSDK.Intefaces:  https://github.com/DefinitelyTyped/DefinitelyTyped/pull/9651
Add interfaces for other classes (e.g RemoteDependencyData) to JavaScriptSDK.Intefaces and update DefinitelyTyped.

Are you planning to make the definitions available using typings project?

I wasn't aware of Typings project. I'll review it next few days. Thanks!
I send a pull request to DefinitelyTyped repo with definitions for all remaining  classes. https://github.com/DefinitelyTyped/DefinitelyTyped/pull/9789


Adding timeout to ChatOpenAI raises ConfigError

System Info
Running langchain==0.0.332 with python 3.11 and openai==1.2.0 on Windows.
Who can help?
No response
Information

[ ] The official example notebooks/scripts
[ ] My own modified scripts

Related Components

[X] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
from langchain.chat_models import ChatOpenAI

ChatOpenAI(
    model="gpt-3.5-turbo",
    request_timeout=5,
)

Expected behavior
Should run without errors.
Likely due to newly introduced httpx.Timeout type in request_timeout (https://github.com/langchain-ai/langchain/pull/12948). Always importing httpx and tiktoken (i.e. not conditionally on TYPE_CHECKING) fixes the issue.

Thanks for flagging @andreas-thomik. #13154 should fix and will be released in 0.0.334, let me know if you still see it after that

Seems fixed to me, thank you!


VirtualMemoryFiles: New resource proposal

Resource proposal
A new composite ressource to configure the system page file via ComputerManagementDsc\VirtualMemory.
Configure one or more page files for a system.
I've tried do build one myself, but the build fails with:

[-] Composite resource folder count matches composite resource count 49ms
Expected 125, but got 115.
114:         $compositeResouces.Count | Should -Be $compositeResouceFolders.Count
at , C:\Users\HannapCh\Repository\CommonTasks\tests\Unit\DSCResources\DscResources.Tests.ps1: line 114

and when used inside the DSCWorkshop Framework it does not recognise the Composite when building the Mof File.

"The term 'VirtualMemoryFiles' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the
spelling of the name, or if a path was included, verify that the path is correct and try again.

Is there an example guide how to add new ones?
Proposed properties

Property
Type qualifier
Data type
Description
Default value
Allowed values

PropertyName
Key
String
Detailed description
None
None

Special considerations or limitations
What i've tried:

Create a folder VirtualMemoryFiles at /source/DSCRessources/
Created the files

\source\DSCRessources\VirtualMemoryFiles.schema.psm1
\source\DSCRessources\VirtualMemoryFiles.psd1
tests\Unit\DSCResources\Assets\Config\VirtualMemoryFiles.yml

VirtualMemoryFiles.schema.psm1 contents:
configuration VirtualMemoryFiles
{
    param (
        [Parameter(Mandatory = $true)]
        [hashtable[]]
        $Files
    )

    Import-DscResource -ModuleName ComputerManagementDsc

    foreach ($file in $Files)
    {
        $executionName = $file.Drive
        (Get-DscSplattedResource -ResourceName VirtualMemory -ExecutionName $executionName -Properties $file -NoInvoke).Invoke($file)
    }
}

VirtualMemoryFiles.psd1 contents:
@{
    RootModule           = 'VirtualMemoryFiles.schema.psm1'

    ModuleVersion        = '0.0.1'

    GUID                 = 'decb37e2-f194-4502-bfee-aed06fafa34d'

    Author               = 'NA'

    CompanyName          = 'NA'

    Copyright            = 'NA'

    DscResourcesToExport = @('VirtualMemoryFiles')
}

VirtualMemoryFiles.yml contents:
Files:
  - Drive: C
  Type: CustomSize
  InitialSize: 4096
  MaximumSize: 4096
  - Drive: P
  Type: CustomSize
  InitialSize: 8192
  MaximumSize: 8192

ok it seams like i've got a faulty windows 10 vm. I'll try a new one and report back

I skimmed the code and it looks good to me. If the new configuration does not appear as a valid DSC resource, it is usually due to syntax issues in or inconsistent naming.
If it still doesn't work, can you create a PR so I can run through your code more thoroughly, please?

The issue had been a bad Windows 10 VM.


Spring Cloud Azure 4.0 should enable configuring executor service underneath any TokenCredential

Users could use multiple azure sdk clients in the same spring application, we should enable configuring executor service underneath any TokenCredential.

Closing this in #25334.


Bug: interpreter.send crashes when called with a circular structure

Related to this line.
When you pass a circular structure to this function in non-production envs, interpreter.send tries to log a warning using JSON.stringify, which then throws.
Expected result: it should not throw :sweat_smile:
Recommended solutions (pick one or both):

make warnings optional and configurable (not depending on env)
wrap a try / catch around the JSON.stringify call and report that you failed to stringify the object

This is a bit of a problem for me since it's a popular pattern in MobX to use circular structures for data stores (it's even recommended in the official docs).
I use this to provide an "outside world" state to the state machine via guards, e.g. interpreter.send({ type: 'NEXT', contextService: /* class with circular refs that has getters to the global store */ }).
Before I get criticized for not using state machines properly: this is an approach I picked knowing all of its drawbacks - I just needed a declarative way of defining state transitions of a really small part of my app and figured that this is the easiest / most effective way to do it. I'll understand if you'll decide not to accept my bug report because of this.
Let's discuss this and I'll be glad to send a PR once we reach consensus.

Before I get criticized for not using state machines properly

Nah this is fine - ideally, the context of a machine should be any (ideally serializable) data structure, not just POJOs. Are MobX's data structures serializable?

Yes, they are - JSON.stringify accepts a second argument that allows you to handle circular references. This is also one of the approaches we could take to solve this.
Just to clarify - it's not context that's the problem - it's the event passed to interpreter.send(). I don't use context.

Sure, I'll try to set up a reproducible example for you.

Here you go - sample code that's triggering the issue, with a setup similar to mine, just without MobX decorators https://stackblitz.com/edit/typescript-hxgu7x.
The reason why I supply the context via guards is because xstate context is supposed to be mutated only internally.
As a response to your comment - even if the best practice is that events are JSON-serializable, in my opinion, xstate shouldn't throw when they aren't if there aren't any specific technical reasons for this.

This is more of a design issue - events should definitely be serializable, and only include what they need to include.
Your { type: 'NEXT', ... } event can be simplified to:
{
  type: 'NEXT',
  isAuthenticated: true // contextService.currentUser.isAuthenticated, etc.
}

You might see the obvious problem with that: it's too easy to fake/mistakenly send { ... isAuthenticated: true } even if the user isn't authenticated, and this problem extends to sending the entire service; I can fake that contextService with an authenticated user, too.

What's better is to include the user state in context:
{
  // ...
  context: {
    user: contextService.currentUser, // etc.
  }
}

And use some sort of observer pattern:
// pseudo-code
contextService.onUpdateUser(updatedUser => {
  myService.send('USER.UPDATE', { data: updatedUser });
}

// ...

{
  on: {
    'USER.UPDATE': assign({ user: (_, e) => e.data })
  }
}

This gives you an explicit data flow, and also allows you to separate responsibilities in a flexible way (imagine if user updates came from polling an API endpoint instead of a local  contextService, or if the contextService implementation changed).
With the above, your event becomes simple and serializable:
{
  on: {
    NEXT: {
      target: 'complete',
      cond: ctx => ctx.user.isAuthenticated
    }
  }
}

// ...

myService.send({ type: 'NEXT' });

Let me know if you have any more questions on this 😄


Update copyright notices and license headers

Update: the correct copyright is Copyright OpenSearch Contributors, without All Rights Reserved, without years for the OpenSearch part (leave years if any Elastic copyright is needed), and no Amazon-related stuff.

[x] Do you have a Copyright OpenSearch Contributors in README?
[x] Does copyright Copyright OpenSearch Contributors match between NOTICE.txt or NOTICE and README?
[x] Did you remove the year from Copyright 2021 OpenSearch Contributors in README and NOTICE?
[x] Do you have other copyrights properly represented in NOTICE, such as Elastic, if your code was forked?
[x] Did you remove all Copyright Amazon and Affiliates?
[x]  Did you remove any other .md files that say anything about copyright?
[x] Is your CONTRIBUTING.md up-to-date saying to use short versions?
[x]  Are you using short versions in your files? See Update OpenSearch LicenseHeaders to use the short version

The correct header for files like this one is:
/*
 * Copyright OpenSearch Contributors
 * SPDX-License-Identifier: Apache-2.0
 */

For files that contain attribution to an external project, place this long version above those of the external project(s).
/*
 * Copyright OpenSearch Contributors
 * SPDX-License-Identifier: Apache-2.0
 *
 * The OpenSearch Contributors require contributions made to
 * this file be licensed under the Apache-2.0 license or a
 * compatible open source license.
 *
 * Modifications Copyright OpenSearch Contributors. See
 * GitHub history for details.
 */

Here is a rough list of files that need to change:
https://github.com/opensearch-project/k-NN/search?q=copyright+amazon.com+reserved

The correct header for files like this one is:
/*
 * Copyright OpenSearch Contributors
 * SPDX-License-Identifier: Apache-2.0
 */

For files that contain attribution to an external project, place this long version above those of the external project(s).
/*
 * Copyright OpenSearch Contributors
 * SPDX-License-Identifier: Apache-2.0
 *
 * The OpenSearch Contributors require contributions made to
 * this file be licensed under the Apache-2.0 license or a
 * compatible open source license.
 *
 * Modifications Copyright OpenSearch Contributors. See
 * GitHub history for details.
 */

Here is a rough list of files that need to change: https://github.com/opensearch-project/k-NN/search?q=copyright+amazon.com+reserved

Thank you, will update it.

Lets close this once all files are updated!


commafeed: init at 4.3.3

Description of changes
Adds CommaFeed package and module.
Link: https://github.com/Athou/commafeed
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[x] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3822

Additionally I formatted this PR using nixfmt-rfc-style.


TiSpark deployment

Deploy TiSpark to maven central repository.

Related JIRA creation
https://issues.sonatype.org/browse/OSSRH-39439

/run-all-tests tikv=release-2.0 tidb=release-2.0 pd=release-2.0


【feat】Could you integrate spark 3.4.1 ?

Spark 3.3.x and 3.4.x have many new features and function enhancements, making development more efficient. At present, it has been optimized and improved many times, and has been used in the production environment for a long time.
It is very hopeful to be able to upgrade integration or multi-version management.
Many thanks for contributing to the community.
Best regards

Hi @zyclove,
It was not planned for ODP 1.0 nor 1.1, as it pulls lot of dependencies with new version.
However as it is a requested feature, we are going to discuss about it internally and keep you update as soon as it is released.
(ODP 1.2 with Hadoop 3.3 is going to be release next October).
Best regards,
Clemlab Team

Upgrading Hadoop 3.3 is a very good plan and I am looking forward to it.
I also really hope to upgrade spark 3.4.
May I ask whether ODP 1.1 has been verified on the arm architecture cluster?
Best regards

ODP 1.1 has not been verified on arm as core components such as zookeeper, hadoop, hbase and ranger need native librairies.
However we started to study it. We focused on ubuntu operating system compatibility for ODP 1.2 release.
Best regards,
Clemlab Team

Hi @zyclove,
Its integrated in ODP 1.2.
We have also built a version of ODP 1.1 with spark 3.4.1 for answer yo your need links to ODP 1.1 with spark 3.4.1
Best regards,
Clemlab Team


link to rsvp list in adminium for info sessions

Result, for info sessions / admins only:

@jcudmore

love it

I'm no react expert so feel free to have another reviewer but LGTM 👍


[scaffolder-backend-module-http-request] - added credentials prop sup…

…port
Hi team, more information about this changes here
:heavy_check_mark: Checklist

[ ] Added tests for new functionality and regression tests for bug fixes
[ ] Added changeset (run yarn changeset in the root)
[ ] Screenshots of before and after attached (for UI changes)
[ ] Added or updated documentation (if applicable)

@goququ can I ask why you wouldnt configure the backstage proxy to provide the credentials? This change seems unusual, because these credentials will be presented to the backstage proxy backend which is designed to provide auth to the target service.

@punkle thank you for the question. May be I missed something, but when I try to do request to the backstage catalog api I don't use proxy. Isn't it?

Yes that is true. You can use this to call any api on the backstage backend. The user's backstage token is provided to the backstage backend by this scaffolder action already. https://github.com/RoadieHQ/roadie-backstage-plugins/blob/main/plugins/scaffolder-actions/scaffolder-backend-module-http-request/src/actions/run/backstageRequest.ts#L141
So in theory the catalog backend should be honouring this token and using it to identify the user who triggered the scaffolder task to start.
For example here on the catalog backend, it is using the authorization token to identify the user https://github.com/backstage/backstage/blob/master/plugins/catalog-backend/src/service/createRouter.ts#L205

@goququ were you able to consider my question?

@goququ I'll close this to keep things clean. When you'll have some time again to pick this up feel free to reopen this one!


[Bug]: Operator showing error with injection sidecar

What happened?
hello team,
I implemented sidecar injected on deployment as this document https://github.com/jaegertracing/jaeger-operator/blob/main/examples/business-application-injected-sidecar.yaml
and found error message from jaeger operator
1.6672863326932034e+09	INFO	annotation present on deployment	{"namespace": "applicationA", "deployment": "accounts"}
1.6672863326933312e+09	INFO	no suitable Jaeger instances found to inject a sidecar	{"namespace": "applicationA"}

Steps to reproduce

deployed jaeger and jaeger operator by helm chart with latest version (namespace jaeger)
implement sidecar inject on deployment of application (other namespace applicationA )
we are using traefik as service mesh https://traefik.io/blog/application-request-tracing-with-traefik-and-jaeger-on-kubernetes/
check log operator and found error message no suitable Jaeger instances found to inject a sidecar

here is services of jaeger was deployed

Expected behavior
Able to tracing appliacation api.
something like this picture

Relevant log output
Operator pod logs

1.6672916883622577e+09	INFO	no suitable Jaeger instances found to inject a sidecar	{"namespace": "applicationA"}

1.6672916883625038e+09	DEBUG	controller-runtime.webhook.webhooks	wrote response	{"webhook": "/mutate-v1-deployment", "code": 200, "reason": "no suitable Jaeger instances found to inject a sidecar", "UID": "294a91d5-fe16-417e-a19c-c3ac5664599e", "allowed": true}

Screenshot
No response
Additional context
No response
Jaeger backend version
v1.37.0
SDK
No response
Pipeline
No response
Stogage backend
No response
Operating system
No response
Deployment model
kubernetes (EKS)
Deployment configs
No response

Seems your deployment needs an injection. But can not find a Jaeger instance in the same namespace. In that case your sidecar doesnt know where it should send the collected data.
Have a look here:

https://github.com/jaegertracing/jaeger-operator/issues/60

hi @frzifus thanks for your response
Is there any solution for my case?
I deployed jaeger and jaeger operator in jaeger namespace and tracing application on other namespace.
thank you very much

Hi @minh-oolio, from my understanding you need to define WATCH_NAMESPACES in your operator.yaml file. To make sure the right jaeger instance is picked, change your annotation value to your instance name.
kind: Deployment
metadata:
  name: myapp
  annotations:
    "sidecar.jaegertracing.io/inject": "<INSTANCE_NAME>"

On the operator side, your jaeger instance should then be found here.

hi @frzifus thanks a lot for your suggestion
it seem it able to inject sidecar to pod
but it still trace on the console
i am concern, do i need to change jaeger-operator-jaeger to  jaeger-operator-jaeger.jaeger.svc
please advise on it
k get jaegers
NAME                     STATUS    VERSION   STRATEGY   STORAGE   AGE
jaeger-operator-jaeger   Running   1.38.0    allinone   memory    3h39m

with this annotaion
apiVersion: apps/v1
kind: Deployment
metadata:
  name: gateway
  annotations:
    sidecar.jaegertracing.io/inject: jaeger-operator-jaeger

and here is a log of jageragent injected to gateway pod
31
2022/11/08 00:46:53 maxprocs: Leaving GOMAXPROCS=2: CPU quota undefined
30
{"level":"info","ts":1667868413.1804988,"caller":"flags/service.go:119","msg":"Mounting metrics handler on admin server","route":"/metrics"}
29
{"level":"info","ts":1667868413.180543,"caller":"flags/service.go:125","msg":"Mounting expvar handler on admin server","route":"/debug/vars"}
28
{"level":"info","ts":1667868413.1809232,"caller":"flags/admin.go:129","msg":"Mounting health check on admin server","route":"/"}
27
{"level":"info","ts":1667868413.1809716,"caller":"flags/admin.go:143","msg":"Starting admin HTTP server","http-addr":":14271"}
26
{"level":"info","ts":1667868413.1809838,"caller":"flags/admin.go:121","msg":"Admin server started","http.host-port":"[::]:14271","health-status":"unavailable"}
25
{"level":"info","ts":1667868413.1815352,"caller":"grpc/builder.go:73","msg":"Agent requested insecure grpc connection to collector(s)"}
24
{"level":"info","ts":1667868413.1815639,"caller":"channelz/funcs.go:340","msg":"[core][Channel #1] Channel created","system":"grpc","grpc_log":true}
23
{"level":"info","ts":1667868413.1815975,"caller":"channelz/funcs.go:340","msg":"[core][Channel #1] original dial target is: \"dns:///jaeger-operator-jaeger-collector-headless.jaeger.svc:14250\"","system":"grpc","grpc_log":true}
22
{"level":"info","ts":1667868413.181634,"caller":"channelz/funcs.go:340","msg":"[core][Channel #1] parsed dial target is: {Scheme:dns Authority: Endpoint:jaeger-operator-jaeger-collector-headless.jaeger.svc:14250 URL:{Scheme:dns Opaque: User: Host: Path:/jaeger-operator-jaeger-collector-headless.jaeger.svc:14250 RawPath: OmitHost:false ForceQuery:false RawQuery: Fragment: RawFragment:}}","system":"grpc","grpc_log":true}
21
{"level":"info","ts":1667868413.1816468,"caller":"channelz/funcs.go:340","msg":"[core][Channel #1] Channel authority set to \"jaeger-operator-jaeger-collector-headless.jaeger.svc:14250\"","system":"grpc","grpc_log":true}
20
{"level":"info","ts":1667868413.1829572,"caller":"grpc/builder.go:113","msg":"Checking connection to collector"}
19
{"level":"info","ts":1667868413.182981,"caller":"grpc/builder.go:124","msg":"Agent collector connection state change","dialTarget":"dns:///jaeger-operator-jaeger-collector-headless.jaeger.svc:14250","status":"IDLE"}
18
{"level":"info","ts":1667868413.183288,"caller":"./main.go:88","msg":"Starting agent"}
17
{"level":"info","ts":1667868413.1833262,"caller":"healthcheck/handler.go:129","msg":"Health Check state change","status":"ready"}
16
{"level":"info","ts":1667868413.1833835,"caller":"app/agent.go:69","msg":"Starting jaeger-agent HTTP server","http-port":5778}
15
{"level":"info","ts":1667868413.1956995,"caller":"channelz/funcs.go:340","msg":"[core][Channel #1] Resolver state updated: {\n  \"Addresses\": [\n    {\n      \"Addr\": \"<IP_ADDRESS>:14250\",\n      \"ServerName\": \"\",\n      \"Attributes\": null,\n      \"BalancerAttributes\": null,\n      \"Type\": 0,\n      \"Metadata\": null\n    }\n  ],\n  \"ServiceConfig\": null,\n  \"Attributes\": null\n} (resolver returned new addresses)","system":"grpc","grpc_log":true}
14
{"level":"info","ts":1667868413.1957407,"caller":"channelz/funcs.go:340","msg":"[core][Channel #1] Channel switches to new LB policy \"round_robin\"","system":"grpc","grpc_log":true}
13
{"level":"info","ts":1667868413.1957922,"caller":"grpclog/component.go:55","msg":"[balancer]base.baseBalancer: got new ClientConn state: {{[{\n  \"Addr\": \"<IP_ADDRESS>:14250\",\n  \"ServerName\": \"\",\n  \"Attributes\": null,\n  \"BalancerAttributes\": null,\n  \"Type\": 0,\n  \"Metadata\": null\n}] <nil> <nil>} <nil>}","system":"grpc","grpc_log":true}
12
{"level":"info","ts":1667868413.1958196,"caller":"channelz/funcs.go:340","msg":"[core][Channel #1 SubChannel #2] Subchannel created","system":"grpc","grpc_log":true}
11
{"level":"info","ts":1667868413.1958375,"caller":"grpclog/component.go:71","msg":"[roundrobin]roundrobinPicker: Build called with info: {map[]}","system":"grpc","grpc_log":true}
10
{"level":"info","ts":1667868413.1958477,"caller":"channelz/funcs.go:340","msg":"[core][Channel #1] Channel Connectivity change to CONNECTING","system":"grpc","grpc_log":true}
9
{"level":"info","ts":1667868413.1958697,"caller":"channelz/funcs.go:340","msg":"[core][Channel #1 SubChannel #2] Subchannel Connectivity change to CONNECTING","system":"grpc","grpc_log":true}
8
{"level":"info","ts":1667868413.1958842,"caller":"channelz/funcs.go:340","msg":"[core][Channel #1 SubChannel #2] Subchannel picks a new address \"<IP_ADDRESS>:14250\" to connect","system":"grpc","grpc_log":true}
7
{"level":"info","ts":1667868413.195938,"caller":"grpc/builder.go:124","msg":"Agent collector connection state change","dialTarget":"dns:///jaeger-operator-jaeger-collector-headless.jaeger.svc:14250","status":"CONNECTING"}
6
{"level":"info","ts":1667868413.1959598,"caller":"grpclog/component.go:71","msg":"[balancer]base.baseBalancer: handle SubConn state change: 0xc00036ab50, CONNECTING","system":"grpc","grpc_log":true}
5
{"level":"info","ts":1667868413.2003353,"caller":"channelz/funcs.go:340","msg":"[core][Channel #1 SubChannel #2] Subchannel Connectivity change to READY","system":"grpc","grpc_log":true}
4
{"level":"info","ts":1667868413.200361,"caller":"grpclog/component.go:71","msg":"[balancer]base.baseBalancer: handle SubConn state change: 0xc00036ab50, READY","system":"grpc","grpc_log":true}
3
{"level":"info","ts":1667868413.2003944,"caller":"grpclog/component.go:71","msg":"[roundrobin]roundrobinPicker: Build called with info: {map[0xc00036ab50:{{\n  \"Addr\": \"<IP_ADDRESS>:14250\",\n  \"ServerName\": \"\",\n  \"Attributes\": null,\n  \"BalancerAttributes\": null,\n  \"Type\": 0,\n  \"Metadata\": null\n}}]}","system":"grpc","grpc_log":true}
2
{"level":"info","ts":1667868413.2004066,"caller":"channelz/funcs.go:340","msg":"[core][Channel #1] Channel Connectivity change to READY","system":"grpc","grpc_log":true}
1
{"level":"info","ts":1667868413.2004158,"caller":"grpc/builder.go:124","msg":"Agent collector connection state change","dialTarget":"dns:///jaeger-operator-jaeger-collector-headless.jaeger.svc:14250","status":"READY"}


make install does not install app correctly

I cloned commit 4cc617ec77304c32aa35f453b7bbb7670da5b867 and compiled like this:
CC=clang ./configure
make
sudo make install

I then have an app in /Applications. But I can't open it, because OSX claims it is damaged.

The app in macvim/src/MacVim/build/Release/MacVim.app does work though.
OSX version: 10.10.5

Please read the document https://github.com/macvim-dev/macvim/wiki/Building-(not-recommended-way) . It explains everything. And you are doing what is not recommended to build MacVim.


[PE-D][Tester C] Add: Timestamp cannot be in the future

Even though it is not stated in the documentation, the add command will not allow you to add a pet if its timestamp is in the future.
Relevant section of documentation:

sample input: add o/Alice n/Doggo p/98765432<EMAIL_ADDRESS>a/311, Clementi Ave 2, #02-25 ts/2024-03-31 14:48:09 t/Dog t/Chihuahua
This may be classified as a documentation or a functionality bug, depending on whether this behaviour is intended or not

Labels: type.FunctionalityBug severity.Low
original: filbertphang/ped#6

Thanks for raising this issue to us.

Fixed


Fix formatting on time stamps

Some sort of test here might be helpful to make sure it doesn't get accidentally changed in the future again


Package request: NAPS2 - Not Another PDF Scanner

Project description
NAPS2 is free and open source scanning software for Windows, Mac and Linux.
Easily scan with devices from Canon, Brother, HP, Epson, Fujitsu, and more. Then save to PDF, TIFF, JPEG, or PNG with a single click.
Metadata

homepage URL: https://www.naps2.com/
source URL: https://github.com/cyanfish/naps2
license: GNU GENERAL PUBLIC LICENSE
platforms: linux

Build Instructions


Add a --version option

It would be useful to have a --version option to display which would allow users to know what version they have installed.

Sounds sensible to me! I'm a little too busy to implement this myself right now, but I'd definitely be open to PRs.


Merge updates from Develop branch

Update

testnet chainparams
develop and main yml build/workflow files for Github Actions
readme, logo source location
fix fee rpc default to 1 dingocoin
Remove alert system
Add rescan to RPC commands
setmaxconnections RPC
checkpoints

Regarding the failing macOS build from the YML files, it should be noted that in the macOS part the original https://github.com/dogecoin/dogecoin/blob/master/.github/workflows/ci.yml no longer resembles this.

Building the new release is next.


monitor_window_timeout on Teams app

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.21.0
Wrapper Library
MSAL React (@azure/msal-react)
Wrapper Library Version
1.2.0
Description
Hi, we are trying to put our web app to teams tab,  it is built by teams fx. The app works perfectly on web but in teams we couldn't know which redirect url that we are going to put for teams, thus it is giving monitor window timeout error. I am confident that this issue caused by this since happened to stuck with this many times and solved giving the correct url.
We tried to give iframe src url and teams app url but none of those worked. I've been looking for 5 days but there aren't any to send teams notification without proper login given the scopes (cannot give scopes in msal graph sdk).
We do an ssoSilent operation on app load just before everything, data fetching etc. so it can't be throttling problem.
Thanks in advance
MSAL Configuration
{
    auth: {
        clientId: clientId,
        authority: "https://login.microsoftonline.com/" + tenantId
    },
    cache: {
        cacheLocation: "sessionStorage",
        storeAuthStateInCookie: true,
    }
}

Relevant Code Snippets
No response
Identity Provider
No response
Source
Internal (Microsoft)

@MudulOzan please take a look at our Teams Tab SSO sample to see how to use MSAL with the Teams SDK. The regular interactive flows will not work, you need to use an auth dialogue from the teams SDK and do the interactions in the resulting popup. Please let us know if this helps answer your question so we can close your issue.

@MudulOzan please take a look at our Teams Tab SSO sample to see how to use MSAL with the Teams SDK. The regular interactive flows will not work, you need to use an auth dialogue from the teams SDK and do the interactions in the resulting popup. Please let us know if this helps answer your question so we can close your issue.

If I am not mistaken, it receives an access token from a custom API. We want to do it with MSAL itself in the component

@MudulOzan unfortunately MSAL cannot be used on it's own in a Teams Tab since all interactive flows have to go through the Teams SDK.

Thanks, we found graph api and using it now.


Speedup

Implements asynchronous writes and direct async upload within pipe_file

These changes look nice. It'd be nice to deliberately decide on a policy for when we open / close a connection, but that shouldn't be a blocker here.

These changes look nice. It'd be nice to deliberately decide on a policy for when we open / close a connection, but that shouldn't be a blocker here.

Thanks for this @hayesgb!

Thanks for this @hayesgb!


Re-allow Hash-like parameters to be passed to steps

Previous commit 49c8dc24cf8e826c5771ddce5ec631f7952354a1 fixed a ruby 2.7 (https://github.com/dry-rb/dry-transaction/issues/132) / ruby 3.0 issue (https://github.com/dry-rb/dry-transaction/issues/135) , where you are no longer allowed to pass hash structures as the last argument to a method.
However, this fix affected other types of objects, that may inherit from Hash, and behave in a very similar way to Hash, specifically HashWithIndifferentAccess.
HashWithIndifferentAccess is used as the default object type for Rails parameters, and as such, is often passed to validation steps, as a HashWithIndifferentAccess type. The underlying validation code is often written with that implicit expectation, and may use strings or symbols as keys. This breaks, when the parameter is transformed in to a simple Hash.
While, it would probably be ideal to be able to go back, and remove HashWithIndifferentAccess from validators, and tighten the expectations to explicitly use strings or symbols, this fix was a breaking change to validators build with Rails parameters in mind.
This commit adds a test with a simple HashWithIndifferentAccess like test class, and demonstrates typical validation code. Without the included fix, these tests fail on current master (49c8dc24cf8e826c5771ddce5ec631f7952354a1) but pass on the commit before the fixes (69e886005ceff48a8f917011ceaf1bf2b90d03e9). The included fix limits the scope of the previous fix to only apply explicitly to Hash instances, leaving "hash-like" objects untouched.

Thanks @trammel for the great explanation and the code fix! This seems like a sensible adjustment to me.

@trammel actually, one request before I merge this: could you put a comment above the ruby_27_last_arg_hash? method succinctly explaining what it does, and why the instance_of? check is particularly important (instead of kind_of?/is_a?) –I think this will be very helpful to anyone who works on this part of the code in future.

Added a comment. It's not exactly brief, but it explains the why :grinning:

Thanks!

Released in 0.13.2!


BUGFIX: various bugs when a line of pip show module does not contain an ':' delimited entry.

Implemented a temporary fix for #8
Commit Files Diff

fix #8

Now, unless sbom4python is able to split a line of pip show module using : as a delimiter, and unless the result of this split contains EXACTLY 2 entries, with the second one being neither empty nor whitespaces, then the program will skip it and directly parse the next line of pip show module result.

This could be further improved by adding a dictionnary of valid entries keywords, and checking entries of parsed lines of pip show module against it, skipping lines that don't contain a proper keyword.

on-behalf-of: @Red-Alert-Labs<EMAIL_ADDRESS>

Don't hesitate if you want us to discuss the PR, or make some modifications before merging.


revision is wrong (push to open PR)

First of all, pardon me if this is a known GitHub Actions issue...
My action code:
            echo "try 2 version:"
            cat << EOF
            ${{ steps.tag.outputs.version }}
            EOF
            echo "try 2 tags:"
            cat << EOF
            ${{ steps.tag.outputs.tags }}
            EOF
            echo "try 2 labels:"
            cat << EOF
            ${{ steps.tag.outputs.labels }}
            EOF
            echo "try 2 json:"
            jq . << EOF
            ${{ steps.tag.outputs.json }}
            EOF
            echo
            echo "github event"
            jq . $GITHUB_EVENT_PATH

where tag is docker/medata-action@v4
When I push another commit to a branch with an open PR, I get this output:
try 2 version:
pr-10  # OK!
try 2 tags:
my/image:pr-10  # OK!
try 2 labels:
...
org.opencontainers.image.version=pr-10  # OK!
org.opencontainers.image.created=2023-04-06T02:30:38.641Z
org.opencontainers.image.revision=801fef0830758d8ccefdc8966569227b8bc22853  # ???
org.opencontainers.image.licenses=
try 2 json:
{
  "tags": [
    "my/image:pr-10"
  ],
  "labels": {
...
    "org.opencontainers.image.version": "pr-10",
    "org.opencontainers.image.created": "2023-04-06T02:30:38.641Z",
    "org.opencontainers.image.revision": "801fef0830758d8ccefdc8966569227b8bc22853",  # ???
    "org.opencontainers.image.licenses": ""
  }
}

github event
{
  "action": "synchronize",
  "after": "d7a982e8f5b039c7e4607f87a826f74c53918aec",  # correct!
  "before": "5dc80b95cd193b52101c1eecb83961bf16139966",
  "number": 10,
  "organization": {
...

Where did the 801fef0... hash come from?
It's not in the github event at all.
Meanwhile, my local checkout has my git commit d7a982... on top, in line with github event.

At the same time, if I push a tag, the revision is correct, it's the git hash that the tag points to.

@dimaqq Can you post your workflow please? Even better if you have a link to your repo.

There you go:
https://github.com/dimaqq/mre-metadata-action-283 repo
https://github.com/dimaqq/mre-metadata-action-283/pull/1 sample PR
Here are all the git commits in the repo, all branches:
> gt
* 3fe33e0 (HEAD -> branch-1, origin/branch-1) a sample change
* 93d6762 (origin/main, origin/HEAD, main) CI debug for https://github.com/docker/metadata-action/issues/283
* c650ac7 Initial commit

Here's the GHA run: https://github.com/dimaqq/mre-metadata-action-283/actions/runs/4718439641/jobs/8368042252
Extract:
2023-04-17T07:09:03.1641463Z ##[group]JSON output
2023-04-17T07:09:03.1641740Z {
2023-04-17T07:09:03.1642057Z   "tags": [
2023-04-17T07:09:03.1642593Z     "quay.io/somerepo/someimage:pr-1"
2023-04-17T07:09:03.1642904Z   ],
2023-04-17T07:09:03.1643199Z   "labels": {
2023-04-17T07:09:03.1643746Z     "org.opencontainers.image.title": "mre-metadata-action-283",
2023-04-17T07:09:03.1644437Z     "org.opencontainers.image.description": "https://github.com/docker/metadata-action/issues/283",
2023-04-17T07:09:03.1645873Z     "org.opencontainers.image.url": "https://github.com/dimaqq/mre-metadata-action-283",
2023-04-17T07:09:03.1646669Z     "org.opencontainers.image.source": "https://github.com/dimaqq/mre-metadata-action-283",
2023-04-17T07:09:03.1647318Z     "org.opencontainers.image.version": "pr-1",
2023-04-17T07:09:03.1647868Z     "org.opencontainers.image.created": "2023-04-17T07:09:03.153Z",
2023-04-17T07:09:03.1648589Z     "org.opencontainers.image.revision": "5d733763d2c575d9ac25b5c0922cbc1ac828df8f",
2023-04-17T07:09:03.1649174Z     "org.opencontainers.image.licenses": "MIT"
2023-04-17T07:09:03.1649496Z   }
2023-04-17T07:09:03.1649777Z }

The image.revision git hash 5d73376 does not exist in my repo.
(my guess is that this is GitHub's magical "this would be the merge commit if the PR was merged" hash)

(my guess is that this is GitHub's magical "this would be the merge commit if the PR was merged" hash)

Yes this looks similar to https://github.com/docker/metadata-action/issues/206. You need to set the associated head sha on pull request event by setting the DOCKER_METADATA_PR_HEAD_SHA env var:
      - id: tag
        uses: docker/metadata-action@v4
        with:
          images:
            quay.io/somerepo/someimage
        env:
          DOCKER_METADATA_PR_HEAD_SHA: true

Yep, looks the same.
I wish that PR_HEAD_SHA was on by default.

Yep, looks the same. I wish that PR_HEAD_SHA was on by default.

Just stumbled upon this PR and thought the same to myself until I saw #239

omg, this should be default

It's not otherwise we break other workflows. Please see https://github.com/docker/metadata-action/pull/239


init script for frps?

I'm using the router for frps and I just found out there's no way to manage the frps instance.
Given there's no luci-app-frps counterpart like frpc, I have to put this line somewhere, or execute it manually whenever the router reboots.
nohup frps -c <path-to-frps.ini> &
Can anyone point me to a package for this? While the nohup method works for me, it's still a bit hackish.

You can new a startup script. vi /etc/init.d/frpserver
#!/bin/sh /etc/rc.common
START=99

start(){
    frps -c <path-to-frps.ini> &
}

Add execute permission.
chmod +x /etc/init.d/frpserver
Now go to Luci - System -Startup. Enable it and start it.

You can new a startup script. vi /etc/init.d/frpserver
#!/bin/sh /etc/rc.common
START=99

start(){
    frps -c <path-to-frps.ini> &
}

Add execute permission.
chmod +x /etc/init.d/frpserver
Now go to Luci - System -Startup. Enable it and start it.

Yeah, this is a good init script example. However, I'm building my own images with all the packages I need included in the system, so I can conveniently upgrade the router as well as the software I need to use on it later on, as well as saving some storage space.
For that, I worry about the possibility that a custom init script (other than those included with the system image) might not survive when flashing a newer image.

Yeah, this is a good init script example. However, I'm building my own images with all the packages I need included in the system, so I can conveniently upgrade the router as well as the software I need to use on it later on, as well as saving some storage space.
For that, I worry about the possibility that a custom init script (other than those included with the system image) might not survive when flashing a newer image.

https://github.com/openwrt/packages/tree/master/net/frp
Frp is already in Openwrt offical repo, both client and server, you can try that one.

https://github.com/openwrt/packages/tree/master/net/frp
Frp is already in Openwrt offical repo, both client and server, you can try that one.

https://github.com/openwrt/packages/tree/master/net/frp
Frp is already in Openwrt offical repo, both client and server, you can try that one.

Sorry for a late response. Yeah, it seems the official OpenWrt's frp packages have the init scripts I wanted. Thanks.


Gelbooru problems

What steps will reproduce the problem?
Download anything on Gelbooru. Something happened in Sunday 4 that mess with the program, I already tried to reset the program, tried different versions, and erasing the config folder, the problem persist.
This is on version 5.0.1
1- When you download pics from Gelbooru, now grabber cant get the creation date from the server. You end up with files like this
https://k60.kn3.net/F/E/2/2/4/E/1B4.png
2- When you download files from Gelbooru, And a file appears on the download list like 169 o end up being downloaded in the wrong place, the default folder, even if i already specified another folder.
https://k60.kn3.net/A/9/5/7/C/6/2EC.png
Download list:
https://k61.kn3.net/5/D/6/E/7/9/853.png
3- I always used the version 4.6.0 (Is the one that works best for me)
On version 4.6.0 the bug its a bit different the 169 o happens  everytime starting sunday 4, files end up getting downloaded with wrong extension and when i see the log i found that the "New try with extension" happens with almost every file, the program failed found most of the time that i already have the file and downloaded it again. What i did on 4.6.0 the previous week was, delete gelbooru of the source list, and add it again. That solved the 169 o, the files end up showing the correct size but, the new try with extension still happened and the program failed still detecting the files that i already have and end up downloading them again, that also solved the wrong download folder.
What is the expected behavior? What do you get instead?
That the pictures get downloaded on the specified folders instead of the default folder. As they used to with Gelbooru.
What version of the program are you using? On what operating system?
Mostly 4.6.0 and 5.0.0 and 5.0.1 now.
Please provide any additional information below
The reason 4.6 worked better for me was because it crashed less, i can minimize the main window without minimizing the download  window, and retrying failed downloads worked quite well. Also was the version that better worked detecting the files that i already have and didnt try to downloading them again. Except on Sankaku when downloading from sankaku failed often to detect the files that i already have. This bug doesnt happen on example xbooru, or rule34 and rule34 paheal. Everything work fine with that boorus.

Sometimes it happen a lot.


About the order of feature data

Hello, sorry to bother you again! I wonder if the four types node feature in the dataset follow the same order from the first node to the last node ? For example , if I want to concatenate the 'spacy' feature and the 'profile' feature, if the same row of these two matrices decribe the same node so that I just need to concatenate the two feature vectors of the same row ?
Also, even though there is the 'content' feature , it seems that it's different with the concatenation of  'spacy' feature and 'profile' feature when I print them. Is that a problem?
Thanks!

Sorry for the late reply.

I wonder if the four types node feature in the dataset follow the same order from the first node to the last node ?

Yes

For example , if I want to concatenate the 'spacy' feature and the 'profile' feature, if the same row of these two matrices decribe the same node so that I just need to concatenate the two feature vectors of the same row ?

Yes , you can concatenate the same row since they represent the same user.

Also, even though there is the 'content' feature , it seems that it's different with the concatenation of 'spacy' feature and 'profile' feature when I print them. Is that a problem?

The content feature is composed of a 300-dimensional user comment feature and a 10-dimensional user profile feature. The user comment feature is the user reply to current news encoded by spaCy, it is different from the spacy feature where we encode a user's recent 200 tweets.


[FEATURE] Add docker support

Is your feature request related to a problem? Please describe.
Current project has no docker config provided
Describe the solution you'd like
Add Dockerfile, docker-compose.yml

Done


Some X-Axis properties modify Y-Axis behaviour in horizontal barRange chart type

Pleae see this fiddle:
https://jsfiddle.net/desytec/cq2xog7f/32/
Look at these options:
`xaxis: {
    type: 'category',
    categories: [
        "lunes",
        "martes",
        "mi\u00E9rcoles",
        "jueves",
        "viernes",
        "s\u00E1bado",
        "domingo"
    ],
    labels: {
        maxHeight: 20,
        rotate: 90
    },
    position: 'top'
},
yaxis: {
    min: 0,
    max: 24
},`

You can see that Y-Axis range is numeric 0 to 24 as the yaxis option says. However, the position property in the xaxis option affects the Y-Axis option as well.
I have not checked the other options.

Please provide more information about the issue. Please specific all the properties that modify the behavior, and how exactly does the behavior get modified?

You can check de JSFIDDLER I provided.
Full options are
let options = {     chart: {         type: 'rangeBar'     },     plotOptions: {         bar: {             horizontal: true,             barHeight: '30%'         }     },     grid: {         show: true,         xaxis: {             lines: {                 show: true             }         },         yaxis: {             lines: {                 show: true             }         },     },     xaxis: {         type: 'category',         categories: [             "lunes",             "martes",             "mi\u00E9rcoles",             "jueves",             "viernes",             "s\u00E1bado",             "domingo"         ],         labels: {             maxHeight: 20,             rotate: 90         },         position: 'top'     },     yaxis: {         min: 0,         max: 24     },     series: [         {             data: [               {                   "x": "lunes",                   "y": [                       15,                       18                   ]               },               {                   "x": "martes",                   "y": [                       15,                       18                   ]               },               {                   "x": "mi\u00E9rcoles",                   "y": [                       15,                       18                   ]               },               {                   "x": "jueves",                   "y": [                       15,                       18                   ]               },               {                   "x": "viernes",                   "y": [                       15,                       18                   ]               }           ]         }     ]   };
See the `position: 'top' value applied to X-Axis. It is actually being applied to Y-Axis.
Regards
Jaime

You should be using xaxis.min & xaxis.max in horizontal charts because the axis gets reversed in horizontal charts.
The configuration is correct in this case, hence closing this issue.

But I need Y Axis to be from 0 to 24 (this works). If setting Y Axis range (which is placed horizontally), intuitively, if I set position of Y Axis, it should made it.


Create Development Database

Create Development Database
User Story
AS A small business owner
I WANT to be able to write and save notes
SO THAT I can organize my thoughts and keep track of tasks I need to complete
Acceptance Criteria
GIVEN a functional Express.js API
WHEN I enter schema and seed commands
THEN a development database is created and is seeded with test data

This has been completed


set spatial filter in ogr source

 set spatial filter in ogr source

Pull Request Test Coverage Report for Build 816499459

132 of 134 (98.51%)  changed or added relevant lines in 2 files are covered.
30 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.08%) to 82.439%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

datatypes/src/primitives/bounding_box.rs
5
6
83.33%

operators/src/source/ogr_source.rs
127
128
99.22%

Files with Coverage Reduction
New Missed Lines
%

operators/src/concurrency/thread_pool.rs
3
91.91%

operators/src/source/ogr_source.rs
27
92.81%

Totals

Change from base Build 813835243:
0.08%

Covered Lines:
16858

Relevant Lines:
20449

💛  - Coveralls


Fatal error thrown when required parameters are not passsed to commands

ISSUE: the command !results #0 or !vote #0 is failing to catch some bad input. Input by a user it throws a unexpected error and crashes the script when a user sends a command !results without the #
index.js:367
            } else if(args[0].charAt(0) !== '#') {
                              ^
TypeError: Cannot read property 'charAt' of undefined

and
events.js:180
    throw err; // Unhandled 'error' event
    ^

FIX:
where
if(args[0].charAt(0) !== '#') {
should be
if(!args[0] || args[0].charAt(0) !== '#') {

Want to submit a PR for this?

Actually, don't bother; I'm going to refactor the entire file anyway so this bug will be handled pretty soon

Ian,
Good job on this bot. Other than the bug I specified it's really well written.
Best,
Justen
Get Outlook for Androidhttps://aka.ms/ghei36

From: Ian Sanders<EMAIL_ADDRESS>Sent: Thursday, March 14, 2019 7:37:57 AM
To: iansan5653/discord-votemaster
Cc: Abstract; Author
Subject: Re: [iansan5653/discord-votemaster] throws a unhandled error and crashes (#2)
Actually, don't bother; I'm going to refactor the entire file anyway so this bug will be handled pretty soon
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/iansan5653/discord-votemaster/issues/2#issuecomment-472890660, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AdpC0jIx_z9VP9HG1QUBM7pFimBemW78ks5vWl7FgaJpZM4bzXXB.

Thanks! I plan to take it a lot further but I haven't been on Discord in ages.

I hope you don't mind if I fork this. and implement my own features to make a multi purpose bot.
I'd like to use this for my cybersecurity club's discord.

Sure, but you may want to wait a little; I have some improvements I'll merge soon.


Thank you so much!

This is incredibly useful.  Unvbelievably fast and runs like a charm on Win10Edu.
I didn't know where else to put a commendation.

I'm glad it helped.


chore: add preparation commit command npm prepare

Description
Fixes #19
Checklist
Ensure you completed all of the steps below before submitting your pull request:

[ ] Added natspec comments?
[ ] Ran pnpm prepare?
[ ] Ran pnpm verify?

bad vscode, preselected this repo. sorry


Updates to the Zendesk SSO configuration docs

Description

Zendesk recently enhanced its SSO configuration options to support multiple configurations. This updates the docs to reflect these changes.

References

Changes were requested by Barkha Bathia, Product Manager at Zendesk, who has been in touch with Tom Wimmers at Microsoft. I'm on the Zendesk Docs team.

@chucknado : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


[SPARK-18016][SQL][followup] merge declareAddedFunctions, initNestedClasses and declareNestedClasses

What changes were proposed in this pull request?
These 3 methods have to be used together, so it makes more sense to merge them into one method and then the caller side only need to call one method.
How was this patch tested?
existing tests.

cc @bdrillard

Test build #79417 has started for PR 18579 at commit 7c8979e.

Test build #79417 has finished for PR 18579 at commit 7c8979e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79417/
Test PASSed.

LGTM except one minor comment

Thanks! Merging to master.

Thanks everyone!


python38Packages.jupyterlab: 3.2.5 -> 3.2.6

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python38Packages.jupyterlab is: "Jupyter lab environment notebook server extension."
meta.homepage for python38Packages.jupyterlab is: "https://jupyter.org/"
meta.changelog for python38Packages.jupyterlab is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
/nix/store/l3cwlman0cd79pmf88zagd4dsappnvv2-python3.8-jupyterlab-3.2.6/bin/jupyter-labhub passed the binary check.
/nix/store/l3cwlman0cd79pmf88zagd4dsappnvv2-python3.8-jupyterlab-3.2.6/bin/.jupyter-lab-wrapped passed the binary check.
/nix/store/l3cwlman0cd79pmf88zagd4dsappnvv2-python3.8-jupyterlab-3.2.6/bin/.jupyter-labhub-wrapped passed the binary check.
/nix/store/l3cwlman0cd79pmf88zagd4dsappnvv2-python3.8-jupyterlab-3.2.6/bin/jupyter-lab passed the binary check.
/nix/store/l3cwlman0cd79pmf88zagd4dsappnvv2-python3.8-jupyterlab-3.2.6/bin/.jlpm-wrapped passed the binary check.
/nix/store/l3cwlman0cd79pmf88zagd4dsappnvv2-python3.8-jupyterlab-3.2.6/bin/jlpm passed the binary check.
/nix/store/l3cwlman0cd79pmf88zagd4dsappnvv2-python3.8-jupyterlab-3.2.6/bin/jupyter-labextension passed the binary check.
/nix/store/l3cwlman0cd79pmf88zagd4dsappnvv2-python3.8-jupyterlab-3.2.6/bin/.jupyter-labextension-wrapped passed the binary check.
4 of 8 passed binary check by having a zero exit code.
8 of 8 passed binary check by having the new version present in output.
found 3.2.6 with grep in /nix/store/l3cwlman0cd79pmf88zagd4dsappnvv2-python3.8-jupyterlab-3.2.6
found 3.2.6 in filename of file in /nix/store/l3cwlman0cd79pmf88zagd4dsappnvv2-python3.8-jupyterlab-3.2.6

Rebuild report (if merged into master) (click to expand)

12 total rebuild path(s)

7 package rebuild(s)

7 x86_64-linux rebuild(s)
5 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
docbookrx
python38Packages.jupyterlab
python38Packages.jupyterlab-git
python38Packages.jupytext
python39Packages.jupyterlab
python39Packages.jupyterlab-git
python39Packages.jupytext

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/l3cwlman0cd79pmf88zagd4dsappnvv2-python3.8-jupyterlab-3.2.6 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python38Packages.jupyterlab https://github.com/r-ryantm/nixpkgs/archive/b972654ba20d618daa7d3cb3e48452ac64f569e0.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/l3cwlman0cd79pmf88zagd4dsappnvv2-python3.8-jupyterlab-3.2.6
ls -la /nix/store/l3cwlman0cd79pmf88zagd4dsappnvv2-python3.8-jupyterlab-3.2.6/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

6 packages built:

python38Packages.jupyterlab
python38Packages.jupyterlab-git
python38Packages.jupytext
python39Packages.jupyterlab
python39Packages.jupyterlab-git
python39Packages.jupytext

Maintainer pings
cc @zimbatm @costrouc for testing.

Result of nixpkgs-review pr 153972 run on x86_64-linux 1

6 packages built:

python38Packages.jupyterlab
python38Packages.jupyterlab-git
python38Packages.jupytext
python39Packages.jupyterlab
python39Packages.jupyterlab-git
python39Packages.jupytext


possible bug with PSUseBOMForUnicodeEncodedFile

Second version of this causes BOM to be considered missing, No failed test after deleting trailing whitespaces after Property. Not sure if false positive or personal mistake, worked fine with and without -Typename as well.
				$MovedUser = New-Object PSObject -Property @{...}

				$MovedUser = New-Object -TypeName PSObject  –Property   @{...}

@nurnbeck what version of PSScriptAnalyzer are you using?

I get the same issue, v 1.16.1


[RFC] explicit variable scope / not annotated uninitialized

Sometimes I find myself in the following pattern
obj = uninitialized Foo
some_with_that_exec_block do |context|
   # ...
   obj = context.foo
end
do_something_with obj

The code is unsafe, for sure. And I don't want/need to change that.
What bugs me is the mention of the Foo.
Crystal allows you to write
some_with_that_exec_block do |context|
   # ...
   obj = context.foo
  do_something_with obj
end

but in order to declare that the scope of obj is outside the do |context| block, then a type annotation is needed, yet the compiler is able to know the type of obj
Proposal 1
Allow uninitialized to be used without type annotation. It keeps the unsafe nature of uninitialized.
obj = uninitialized
some_with_that_exec_block do |context|
   # ...
   obj = context.foo
end
do_something_with obj

Proposal 2
Allow _ or maybe any other type restrictions over uninitialized. It will not compile if the types are not assignable. It is a generalization of current syntax.
obj = uninitialized _
some_with_that_exec_block do |context|
   # ...
   obj = context.foo
end
do_something_with obj

Proposal 3
Allow just _ as a declaration of the scope of the variable. I don't like this very much because it hides the uninitialized value of the variable. It adds an overload to _. But I imagine is something someone will propose. Seems less syntax, but more cryptic IMO.
obj = _
some_with_that_exec_block do |context|
   # ...
   obj = context.foo
end
do_something_with obj

First of all let me mention another (safer) variant, how you would solve it in Ruby:
obj = nil
some_with_that_exec_block do |context|
   # ...
   obj = context.foo
end
do_something_with obj.not_nil!

similarly extracting into a method works:
def fetch_foo
  some_with_that_exec_block do |context|
    # ...
    return context.foo
  end
  raise
end
do_something_with fetch_foo

Ruby actually has a feature for the inverse, preventing a closure:
foo = 1
bar do |context; foo|
  foo = 2
end
foo # => 1

I think we should find something along those lines, if we want to do this at all. Perhaps
some_with_that_exec_block do |context; obj=|
   # ...
   obj = context.foo
end
do_something_with obj

@jhass I like the prevent closure ;. It will end up in nillable values to be safe for sure.
Why in the last example there is a obj= rather than a obj?

Preventing a closure is not doing what you want, on the contrary, so I'm trying to come up with something for the inverse, pushing a block local to the parent scope.

@jhass yes. I meant preventing making the variable local to the clousure. Pushing up to the parent scope is far more clear way to express it.
I still think the = is a typo, isn't it?
Unless there is other use case for the not annotated uninitialized it's fine to make a RFC towards ;. It seems more neat.

A closure means the nested scope closures over the outer scope, the variable declared in the outer scope remains to be the same variable in the inner scope. Thus preventing a closure means introducing a new local variable in the nested scope. This is not what you're looking for, but it's what ; does in Ruby. Have a second look at my above example, here's a pry session demonstrating it:
[18] pry(main)> def foo
[18] pry(main)*   yield
[18] pry(main)* end
=> :foo
[19] pry(main)> x = 1; y = 1
=> 1
[20] pry(main)> foo do |; x|
[20] pry(main)*   x = 2
[20] pry(main)*   y = 2
[20] pry(main)* end
=> 2
[21] pry(main)> x
=> 1
[22] pry(main)> y
=> 2

So, introducing it like that with actually the opposite behavior would be rather confusing. Yet the overall area of the two features is the same, so I was searching for something that resembles it.

#1395 could be extended to allow this too actually
some_with_that_exec_block do |context|
   # ...
   $obj = context.foo
end
do_something_with $obj

When doing monkey business, I think it's perfectly good to be a little explicit; adding the type above seems a perfectly ok price for getting away with a little black magic. Chances are though, that LLVM would compile the obj = nil... version (which no doubt is cleaner) to the same thing after optimizations, if verified, that would be the best route.
Personally, I don't like the "generalized magic vars" theme, I'd rather see them gone completely.
The do |a, b; x, y] thing would be lovely for explicitly saying what is closured imo. Preferably with ref as default, and copied as optional ("capturing" the value), via say let/var / whatever. (do |a, b; let x, var y) - would be handy for some async work. I can see how that can't happen given the Ruby-situation though.

I very much prefer the obj = nil version, because in the case where the block isn't executed or for some reason the variable isn't set, you get an exception instead of a segfault/other undefined behaviour.

I actually like the idea of using a separate (private) method for this (https://github.com/crystal-lang/crystal/issues/3215#issuecomment-243545918). It's safe because it raises if no Foo could be found, but avoids a nilable union type. It's obviously not going to be an easy solution if you need closured variables in the block, because it doesn't share the scope. But if not, this is pretty perfect solution. A private method shouldn't add much overhead.
Continuing on this, maybe there could be a way to recreate the behaviour which can currently only be implemented using a separate method, to be moved in scope? But I suppose a method is actually the best way to model the control flow.


Looking forward to get involved and contribute to the community 🎉

First Name
Achalesh
Last Name
Lakhotiya
Discord Username (if applicable)
No response
Let us understand your motive.
To work, contribute and collaborate for different community oriented projects.

Hey @achalesh27022003 👋🏻
Thanks for requesting an invite! Welcome to SidHacks Community 🎉
Before going ahead, I would want you to complete the below To-Do list.
Your To-Do List ✔

Accept the invitation sent to you via mail.
Change the appearance of this organization to "Public" from the people list here.
Join our Discord Server here.

Accept the Rules from #📓〡rules channel.
Introduce yourself to our community in 👋〡introduction channel.

Feel free to share your excitement on socials with #SidHacksCommunity. You can also tag me @siddharth_hacks.

Close this issue once you complete all the above points.

Looking forward to interacting with you in our community! Welcome once again! 🤓


ExitCode logic inverted

Hi Lukas,
Thanks for addressing the ExitCode issue so quickly! Noticed that the logic looks inverted though, would be good to get another fix out soon.
https://github.com/LukasKalbertodt/libtest-mimic/blob/01aba1dd6ec60ab9e82f445b3c198efe5a415cf1/src/lib.rs#L341

And that's why one doesn't push out a new release within 15min first thing in the morning... grumble grumble
Thanks for catching this so quickly.

Fix published as 0.7.2


[Bug Report] v-loading on el-dialog will become a fullscreen loading

Element UI version
2.4.0
OS/Browsers version
MacOS 10.12.6 / Chrome  66.0.3359.181
Vue version
2.5.16
Reproduction Link
https://jsfiddle.net/z8p4umew/6/
Steps to reproduce
click the "Open Dialog" button.
What is Expected?
The loading mask is full of the dialog.
What is actually happening?
The loading mask is full of the screen. And user can't close the dialog before the loading close.

This is because the outmost element of Dialog is a fullscreen wrapper. Use $loading instead: https://jsfiddle.net/z8p4umew/11/

@Leopoldthecoder is this bug resolved? could u please give a demo using $loading ? cause I can't open that jsfiddle link ... thks.


Add CI badge

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   75.72%   75.72%
=======================================
  Files           3        3
  Lines         103      103
  Branches       20       20
=======================================
  Hits           78       78
  Misses         25       25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2afb581...75eb45c. Read the comment docs.


How to log the sql query that i used ?

DBFlow Version: 3.0.0-beta5
Issue Kind (Question):
Description:
Is there a way to know the sql statement that is queried ?
for example, i made this query:
SQLite.select()   .from(Location.class)   .where(Location_Table.latitude.eq(home.getLatitude()))   .and(ConditionGroup.clause()       .and(Location_Table.latitude         .minus(PropertyFactory.from(home.getLatitude())         .eq(1000L))))
i want to know the translation of it which is:
SELECT * FROM LocationWHERElatitude=45.05 AND (latitude - 45.05) = 1000

getQuery() and then you can log it.

Another thing, can i write native sql query ?


proposal: text/template: export error type for missingkey

There is currently not an easy way to test for missing key error from text/template in the case that that the template was constructed with the missingkey=error option.
I propose adding a new error type in text/template testable via errors.As and the missing key can be recovered:
type MissingKeyError struct {
    Key string
}

func (e MissingKeyError) Error() string {
    return "no entry for key"
}

This would be added in a way that doesn't cause the existing error's string representation to change, allowing any users that might be checking for certain sub-string in the error strings to gracefully transition to the new way.

Edit: changed fmt.Errorf to errors.New
Edit: took suggestion from @icholy to have the error be a struct type, allowing users to be able to recover the offending key.

cc @robpike

Perhaps something like:
type MissingKeyError struct {
    Key string
}

func (e MissingKeyError) Error() string {
    return "no entry for key"
}

@icholy , great idea! I've updated the proposal.

It looks like this might already exist (except for write errors): https://github.com/golang/go/blob/master/src/text/template/exec.go#L118-L124

Can you show an example on programmatically detecting whether the cause for an ExecError is due to missing keys? I don't think that capability exists today unless you resort to sub-string checks against the error string, which isn't a reliable method.


Some of my users can't join using 3.6, was not happening with 3.5

[12:34:47 WARN]: [SafeNET] DENIED (code B9): Failed to authenticate session "morenitojp" (044943b1-8b5c-39be-9e0f-501b449ef432): no properties found.

Hey 👋
thanks for submitting this issue. I've known this issue already, however, could you please tell if this happens only with offline players?
Thanks.
~ dejvokep

Fixed by #14. In case of any other questions, do not hesistate and contact me again. :)


Feeds surface content older than 6 months (based on createdAt date)

Steps to Reproduce

If you have the MLSky feed, refresh the feed on any platform.
You can see content that's 6 months old and from 2018, likely via Twitter imports in the attached images. In one of the cases, it's because the createdAt date on the plc record is old, and likely the source of order of ingest in the stream.
Other folks have noticed this issue with other feeds as well, particularly as people import more of their past Tweets when just onboarding onto the platform.

Given that many feeds are user-generated, it may make sense on the AppView side to limit feed content to < 7 days with clear labeling of intent and date limit, although with specific feeds like "📌" this might not make as much sense.
In general, based on users' previous experiences with social network "feed" speed, it feels like recency could be enforced on the AppView client side.
Attachments

e

What platform(s) does this occur on?
Web (Desktop)
Device Info
Web/iOS but not specific to either
What version of the app are you using?
Build version: 1.93.0; Bundle info: 7731136 (prod); Bundle date: 24110818; Platform: web
Additional Information
No response

This is on custom feeds, and the thing about feeds is they don't have to be reverse-chronological, so it's pretty much the feeds' responsibility to make sure that the posts it's returning are reverse-chron.


Taskbar doesn't appear when hide automatically is on and the Fullscreen app is always on top

Microsoft PowerToys version
0.70.0
Installation method
GitHub
Running as admin
Yes
Area(s) with issue?
Always on Top
Steps to reproduce

Make sure the taskbar is hidden automatically
Make the app Fullscreen
Set the app to always on top
Taskbar does not appear

✔ Expected Behavior
Taskbar should appear
❌ Actual Behavior
Taskbar Does not appear
Other Software
No response

like this?

Settings app is a basic WinUI 3 app at the end of the day as well so this feels like a taskbar bug.  /feedbackhub but looks like it is a known bug


Upgrade and convert to typescript

Pull request opened by github-pullrequestcreator.

Adding a linting step would be super nice :)

:tada: This PR is included in version 3.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


make DMA map/unmap optionally asynchronous

Some devices (e.g. NVMf/vfio-user in SPDK) need the DMA map/unmap callbacks to be asynchronous: the device callback can return but it doesn't mean that the DMA unmap operation can continue (libvfio-user must not call munmap, e.g. there can be pending I/Os). We can solve this problem the same way we plan to solve making the migration device state transition callback asynchronous (https://github.com/nutanix/libvfio-user/issues/296#issuecomment-916812012).
Another way to solve this (as suggested by @changpe1) is to have a reference counter and unmap it when the last reference is dropped, however there can be problems with thread safety there. @jlevon thoughts?

cf #594
We can't do a reference count - what happens if a remap comes in? What happens if we send a DMA_WRITE across the socket after we responded to the unmap?
The only reasonable approach we've found is the first one: everything at the vfio-user socket level is blocked until SPDK tells us it's done with the unmap.

cf #296


Idea: nested without always requiring &

f.e.
{
    '.webglearth': {
        background: '#f2ecdc',

        "blah": {
            'border':'1000px solid black'
        }
    }
}

would generate
.webglearth {
  background: #f2ecdc;
}
.webglearth blah {
  border: 1000px solid black;
}

or f.e.
{
    '.webglearth': {
        background: '#f2ecdc',

        ".blah": {
            'border':'1000px solid black'
        }
    }
}

would generate
.webglearth {
  background: #f2ecdc;
}
.webglearth .blah {
  border: 1000px solid black;
}

but if you want .webglearth.blah (no space) then
{
    '.webglearth': {
        background: '#f2ecdc',

        "&.blah": {
            'border':'1000px solid black'
        }
    }
}

would generate
.webglearth {
  background: #f2ecdc;
}
.webglearth.blah {
  border: 1000px solid black;
}

So the & is optional, but gives more control when you e.g. don't want the space which has completely different meaning.

Yeah, that'd be cool, but it was just two stylus sheets small enough that it took 15 min. I don't think I could write a stylus2jss thing that fast. Plus, with my limited time, I've chosen to start on a famo.us globe/map using Mixed Mode. The markers will be DOM for now, but mixed in with the webgl globe.

Yeah, that'd be cool, but it was just two stylus sheets small enough that it took 15 min. I don't think I could write a stylus2jss thing that fast. Plus, with my limited time, I've chosen to start on a famo.us globe/map using Mixed Mode. The markers will be DOM for now, but mixed in with the webgl globe.


[Bug]EndpointNameGrouping in SourceBuilder may not work

I glad to found the EndpointNameGrouping feature, and it can really solve problems that many enterprises will face.
Bug
SourceBuilder using NamingControl to do endpoint name length format and end-name-grouping when setSourceEndpointName or setDestEndpointName invoked. But NameControl dependence on serviceName to finish the group matching according to the code:
    @Getter
    private String destServiceName;

    public void setDestServiceName(final String destServiceName) {
        this.destServiceName = namingControl.formatServiceName(destServiceName);
    }

    @Getter
    @Setter
    private NodeType destNodeType;
    @Getter
    private String destServiceInstanceName;

    public void setDestServiceInstanceName(final String destServiceInstanceName) {
        this.destServiceInstanceName = namingControl.formatServiceName(destServiceInstanceName);
    }

But at this time the serviceName may not have been set. When using SourceBuilder in MultiScopesAnalysisListener, there are many place that set endpoint name first and service name later, like L118~L120
sourceBuilder.setDestEndpointName(span.getOperationName());
sourceBuilder.setDestServiceInstanceName(segmentObject.getServiceInstance());
sourceBuilder.setDestServiceName(segmentObject.getService());

Requirement or improvement
The fastest way to solve is change the set methods invoking order. But it's too easy to make a mistake as it depends on set method calling order.
I suggest adding a namingFormat() method in SourceBuilder and call it manually after all properties are set. How do you think?

I don't see the codes in the latest branch, maybe you're looking at an old commit

Oh yes, I have an old version code.


NotifyConfirm API order

In all practical cases, publisher Acks and Nacks should maintain the same sequence as publishings.
The current API of using two channels and a select {} over them leaves the ordering to the whim of the runtime scheduler.
Two options for how to handle this:

Remove the order guarantee from the library and leave that as an implementation complexity of the client.  The sequences will still be interpolated for n/ack{multiple=true}.

Change the interface of NotifyConfirm to instead accept a single chan of type Confirmation struct { Id int64, Nack bool } instead of two chans and maintain the strict ordering against the published sequence.

Please discuss.

@gaffneyc it's been a while, but I've put 3eba494 together as an example of how a single chan of publisher confirmations could work.  Would you please take a look?
This addresses requiring the application to maintain state from the Publish calls by ensuring strict ordering of acks/nacks.  I can't think of an example where delivering out-of-sequence DeliveryTags would be interesting for users of this library.

@michaelklishin can you think of a reason where consuming out-of-order confirmations would be desirable behavior?

It looks pretty good. We ended up with something similar on a client wrapper we're hoping to open source at some point. I'll give the changes a try on one of our apps here in the next day or two.
The confirms struct doesn't look to be thread safe but I'm not sure if it needs to be or not.

Good find.  A -race check confirms that Channel.dispatch and Channel.Publish are not properly ordered.  Instead of holding Channel.m in Channel.dispatch, it makes more sense to make confirms thread safe.  Fixed in the confirmations branch.

I finally had a chance to test out the changes locally and they are looking good so far. I posted a comment on the confirms code around ordering that I'm curious about. Mainly trying to understand the semantics so we I know we're not missing and acknowledgements.


Apps not directly detaching from terminal no longer launchable

At some point between v0.17.0beta and a7ed3a5e4718c5c3a84306bb190a3272e2bdecda a change got introduced breaking launching of apps not detaching from terminal directly after launch.
bind = $mainMod, F5, exec, emacsclient -c

does nothing, while
bind = $mainMod, F5, exec, emacsclient -c -nw
starts emacsclient. The first one waits for the terminal, while -nw makes it directly detach.


Fix: Trigger.dev

Changes
Fixed the Trigger.dev images pointing to the latest instead of main.
latest tag is 8 months old and points to v2 while main is the newest, v3.
This will also fix problems with ARM machines not being able to run because latest is v2 and has no support for linux/arm64
Trigger also comes with new services: Redis and Electric, which are configured in their own Docker examples.
Issues
N/A

@andrasbacsai
The trigger stack needed new services: electric and redis.
The trigger with external database service is expected to be handled by the user, but I'm not sure if we should remove it, as the stack is complete in trigger.yaml.

This will likely not run in Staging or Production because you're missing both the coordinator service and the docker-provider. The versions for these images should be v3 not main as has been set.
There are more complete versions (though still not following the deployment best practices provided by Trigger.dev) available in the discussion on this topic.
You can find details of official deployment which myself and other have based our working examples off at: https://github.com/triggerdotdev/docker
You can find the discussion at: https://github.com/coollabsio/coolify/discussions/2439

@Mortalife Let me take a look at it closer and I'll join that discussion afterwards.

I think this is still WIP, right? As we need the coorditor (and probably other stuffs) as well.

@andrasbacsai Looking at it in the next hours.

Not sure if I am the only one that has issues with shared configurations. They seem to not be working properly? I end up in the SERVICE_* variables not working well and get populated in my env variables.

Hi... when release this version ??

I have tested it and have one improvement request. Could you please check the healthcheck for Trigger as I am unsure if it has one and the current one is not working.

@peaklabs-dev @andrasbacsai

Thank you for the PR 💜. I will test it and fix it if necessary.


Apply Import Validation Checks (DTO) for Monitor Location ATTR Data  to Import API

LOCATION ATTR Data Format Checks

The value for DuctIndicator must be numeric, only options are 0 or 1
The value for BypassIndicator must be numeric, only options are 0 or 1
The value for GroundElevation must be numeric, and 5 digits max (no decimals)
The value for StackHeight must be numeric, and 4 digits max (no decimals)
The value for CrossAreaFlow must be numeric, and 4 digits max (no decimals)
The value for CrossAreaStackExit must be numeric, and 4 digits max (no decimals)
The value for BeginDate must be formatted as a date yyyy-mm-dd
The value for EndDate must be formatted as a date yyyy-mm-dd
If any of these fields do not contain valid values, it's an error. Error Message:
[LOCATIONATTR-FATAL-A] The value for [fieldname] in the Monitoring Location Attributes record #[index of record] is not formatted properly

LOCATION ATTR Data Value Checks

The value for MaterialCode must be string and limited to the results from (SELECT material_cd from camdecmpsmd.material_code)
The value of ShapeCode must be string and limited to the results from (SELECT shape_cd from camdecmpsmd.shape_code)
If any of these fields do not contain valid values, it's an error. Error Message:
[LOCATIONATTR-FATAL-B] The value for [fieldname] in the Monitoring Location Attributes record #[index of record] is invalid

Testing
Test Case:
Tester
Clean Monitoring Plan

Test Passed


He is good on the browser When I run to my phone, he will report the following error.

He is good on the browser
When I run to my phone, he will report the following error.
Unable to open asset URL: file:///android_asset/www/assets/fonts/roboto-bold.woff2
Unable to open asset URL: file:///android_asset/www/assets/fonts/roboto-bold.woff
Unable to open asset URL: file:///android_asset/www/assets/fonts/roboto-bold.ttf
Why is this so?
@natenorm @jpinkster @db3dev @sean-perkins @sbannigan

Not an issue with the plugin. Your PDF is probably referencing a font that's not available on Android devices. I don't own an Android device and pray I'm never kidnapped and forced to use one.

My Android version is 5.1.2
Is it related to the Android version? Still not supporting Android.
I can open it in the browser. I can't get it on my Android phone. Is this plugin not supporting Android or what is the reason? What time are you testing Android?

I am very sorry, just that the error is my other error. The real error is here.
TypeError: Cannot read property 'querySelector' of null
TypeError: Cannot read property 'querySelector' of null", source: file:///android_asset/www/build/main.js (178931)

@sean-perkins


Automator: update proxy@master in istio/istio@master

Generated by Automator - 2020-11-13T17:15:14+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
e29867c93ec0ad5b6594f867ba9f62cb477949be
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


403 Forbidden Issue

[root@my ~]# youtube-dl -s -4 http://www.youtube.com/watch?v=5OAW3TKwfyk
[youtube] 5OAW3TKwfyk: Downloading webpage
[youtube] 5OAW3TKwfyk: Downloading video info webpage
[youtube] 5OAW3TKwfyk: Extracting video information
[youtube] 5OAW3TKwfyk: Downloading DASH manifest
[youtube] 5OAW3TKwfyk: Downloading js player en_US-vflzomeEU
[youtube] 5OAW3TKwfyk: Downloading DASH manifest
WARNING: [youtube] 5OAW3TKwfyk: Skipping DASH manifest: ExtractorError(u'Could not download DASH manifest: HTTP Error 403: Forbidden (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.',)
[root@my ~]# youtube-dl -U
youtube-dl is up-to-date (2015.07.04)
[root@my ~]#

It's a duplicate of #5118.
A side note: DO NOT run youtube-dl as root unless you're updating (youtube-dl -U)


[$250] Chat - The size of the cursor after emoji differs in mWeb and android.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: V9. 0.73-6
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N
Email or phone of affected tester (no customers): N
Issue reported by: Applause Internal Team
Action Performed:

Launch app in mweb and android
Open a report
Enter :wave and select wave emoji from list
Note the size of the cursor after emoji

Expected Result:
The size of the cursor after emoji must be same.
Actual Result:
The size of the cursor after emoji differs in mweb and android.
Workaround:
Unknown
Platforms:

[x] Android: Standalone
[x] Android: HybridApp
[x] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/b81297fd-4680-43e6-86f5-583682afdf4f
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021866908996080563894
Upwork Job ID:<PHONE_NUMBER>080563894
Last Price Increase: 2024-12-18

Issue OwnerCurrent Issue Owner: @ishpaul777

Proposal
Please re-state the problem that we are trying to solve in this issue.
When inserting emojis in the chat composer, the cursor size and positioning appears differently between mWeb and Android platforms. This inconsistency occurs because mobile devices handle the automatic space insertion after emojis better than web platforms.
What is the root cause of that problem?
The root cause is that we have two different places where spaces are being automatically inserted after emojis:

In ComposerWithSuggestions.tsx:

const commentWithSpaceInserted = isEmojiInserted ? ComposerUtils.insertWhiteSpaceAtIndex(commentValue, endIndex) : commentValue;

In SuggestionEmoji.tsx:

updateComment(`${commentBeforeColon}${emojiCode} ${SuggestionsUtils.trimLeadingSpace(commentAfterColonWithEmojiNameRemoved)}`, true);

This double space insertion is handled differently by mobile platforms vs web platforms, leading to inconsistent cursor behavior.
What changes do you think we should make in order to solve the problem?
We should consolidate the space insertion logic to a single location to ensure consistent behavior. Since mobile platforms handle the space insertion better, we should:

Remove the space insertion in ComposerWithSuggestions.tsx as it is:

const commentWithSpaceInserted = commentValue;

Remove the extra space insertion in SuggestionEmoji.tsx:

// Remove the extra space after emojiCode
updateComment(`${commentBeforeColon}${emojiCode}${SuggestionsUtils.trimLeadingSpace(commentAfterColonWithEmojiNameRemoved)}`, true);

This change will:

Maintain the better handling of spaces on mobile platforms
Make web platforms behave consistently with mobile
Prevent double space insertion that causes cursor inconsistencies

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
N/A

Proposal
Updated

Proposal
Please re-state the problem that we are trying to solve in this issue.
Chat - The size of the cursor after emoji differs in mWeb and android.
What is the root cause of that problem?
When we type only emoji characters, they are styled with a larger font size, while the default text size for the composer remains set to 15px. This discrepancy occurs because the markdownStyle is applied only to emojis.
What changes do you think we should make in order to solve the problem?
To resolve this you need to change in below files:

useMarkdownStyle
You need to specify the same font size for either only emojis or text with emojis using the following:

const emojiFontSize = variables.fontSizeEmojisWithinText;

index.native.tsx
The composerStyle is defined as:

const composerStyle = useMemo(() => StyleSheet.flatten([style]), [style, styles]);

Here, textContainsOnlyEmojis is increasing the composer height and cursor height depending on it. To fix this, you should either remove styles.onlyEmojisTextLineHeight or adjust the lineHeight to match the composer's default height. This will ensure consistency in the height of the composer and the cursor.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)

Recording Native App

https://github.com/user-attachments/assets/de5919e0-fe80-4066-afe6-f57ea33c45ff

Recording mWeb

https://github.com/user-attachments/assets/c207da20-d63a-4954-9066-496937f9f74c

Web - entering empty space will reset cursor size

This makes sense to me too - I think that would be my expectation across all platforms if possible.

Agree 👍

Same 👍

@ishpaul777
I have checked across all the platforms and updated the proposal with recordings.

There is an existing issue in Safari (both desktop and iOS) where the cursor size does not adjust correctly after an emoji, even if the font size changes. This is due to a long-standing bug in WebKit, where the cursor inherits the line height rather than the actual font size. [See screenshot below for reference – demonstrating font size change but persistent large cursor due to emoji size.]

￼

￼
Bug Reference: https://bugs.webkit.org/show_bug.cgi?id=13820
Platform Breakdown:

Mobile Web (Chrome – Android): Cursor size behaves as expected, adjusting with font size.

https://github.com/user-attachments/assets/db38c1bd-421d-413f-a401-02afe82e93d2

Web (Safari – Desktop/iOS) & Mobile Web (Safari/Chrome – iOS): Cursor size remains larger after an emoji, unaffected by font size changes.

https://github.com/user-attachments/assets/d539ef1c-06ac-48e7-9e4d-fda569a0e08d
Native App Considerations:
For native apps, text inputs allow only one font size at a time. This means if we attempt to reduce the cursor size after a space (following an emoji), the entire font size would decrease – not just the cursor.
https://github.com/user-attachments/assets/92e444ab-ce2e-4b08-a276-e6c2e5618a95
￼
Let me know if this broader font size reduction is an acceptable solution or if we should explore alternative approaches.

I believe the issue is related to the Emoji Test Case:
https://github.com/Expensify/App/blob/main/tests/unit/EmojiTest.ts
Becasue If the same styleshhet and approach from the web version are applied to the native application,
still the cursor size behaves differently but when user type any character, emojis size is automatically reduced.
To address this inconsistency, why not preemptively reduce the size of emojis at the moment they're selected?
This would ensure that the emoji size and cursor size remains consistent across all platforms and aligns with font sizes.


Luci: support xtables-addons geoip

This is a feature request, hence the template was not used.
Please support in the web interface a way to block incoming and/or outgoing network traffic for specific countries by using xtables-addons geoip.
For more information, see https://github.com/PanderMusubi/geoipblock/

Create a traffic rule and enter -m geoip --src-cc XX,YY as extra iptables argument in the advanced options.

No, but neither would the linked tutorial.


Sentry.LoggerBackend should hook to the Erlang's Logger

Environment

Elixir version (elixir -v): 1.10
Erlang/OTP version (erl): 21+
Sentry version (mix deps): doesn't matter
Operating system: doesn't matter

Description
Currently Sentry.LoggerBackend hooks to the Elixir's logger which can be defined to ignore the OTP and SASL messages.
Expected Behavior
Error when configuration is like:
config :logger,
  handle_otp_reports: false,
  handle_sasl_reports: false

Should be handled by Sentry
Actual Behavior
Errors will not be handled
Steps to Reproduce
Just fire error with above options set (it need to be set before :logger application will be started.

In addition to above, it will be easier to control everything as :sentry application can define :logger field in application env and then it will be possible to attach it by:
:logger.add_handlers(:sentry)

Just in case, I will try to handle that in my spare time, I just created it to remember about it.
BTW There are plans to deprecate the "legacy backends" in future, so it is better to do the transition as soon as possible.

I think the transition will be relatively straightforward, assuming the structure of events remains similar. A log event from Erlang's new logger looks relatively similar to the format Sentry uses no:
  msg: {:report,
   %{
     label: {:proc_lib, :crash},
     report: [
       [
         initial_call: {:erl_eval, :"-expr/5-fun-3-", []},
         pid: #PID<0.550.0>,
         registered_name: [],
         error_info: {:error, %RuntimeError{message: "raise"},
          [
            {:erl_eval, :do_apply, 6, [file: 'erl_eval.erl', line: 678]},
            {Task.Supervised, :invoke_mfa, 2,
             [file: 'lib/task/supervised.ex', line: 90]},
            {Task.Supervised, :reply, 5,
             [file: 'lib/task/supervised.ex', line: 35]},
            {:proc_lib, :init_p_do_apply, 3, [file: 'proc_lib.erl', line: 249]}
          ]},
         ancestors: [#PID<0.539.0>, #PID<0.81.0>],
         message_queue_len: 0,
         messages: [],
         links: [#PID<0.539.0>],
         dictionary: ["$callers": [#PID<0.539.0>]],
         trap_exit: false,
         status: :running,
         heap_size: 17731,
         stack_size: 27,
         reductions: 12126
       ],

Do you know whether Logger translators will still play a role, or will they be deprecated as well?

If the Elixir backends will be deprecated then the translators will play almost no role as well. However the plan is to have formatter defined that will do translation if needed. However I think that structured log is better as Sentry can format it on their own to format that suits Sentry the best.
Additionally it could be useful to translate it to Erlang for example, so Sentry could be used in pure Erlang applications as well.

BTW There are plans to deprecate the "legacy backends" in future, so it is better to do the transition as soon as possible.

To be clear, it will likely take quite some time for the deprecation to happen. Erlang backends do not support overload protection yet, so we can't deprecate Elixir backends right now. And once Erlang introduces the functionality we need, we need to wait until that Erlang version becomes the minimum required OTP version in Elixir, which usually takes 2 years. So we are at looking at 2 or 3 years from now at best.

Given the timeframe, I'm going to close this issue for now. I definitely think we will do this though 🙂

@mitchellhenke Could you clarify on what's the situation regarding handling Erlang logs. I see there were Sentry.Logger for hooking up to Erlang error_logger. But now it's gone. Can Sentry.LoggerBackend handle Erlang events now if setup according to README?

@staring-frog it will capture log messages if you set the capture_log_messages flag as shown here: https://hexdocs.pm/sentry/Sentry.LoggerBackend.html#module-configuration

Thanks!


wsl2 ubuntu，shift+arrows output ABCD

Version
Microsoft Windows [版本 10.0.22000.708]
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
Ubuntu 20.04
Other Software
No response
Repro Steps

shit+left output D
shift+up output A
Expected Behavior
Shift + left and right   select text
Actual Behavior
output ABCD
Diagnostic Logs
No response

@shuohao PowerShell is using PSReadLine to process text, and that module offers options like Shift+LeftArrow to select text. In Linux the shell is using ReadLine which doesn't have this option. That's expected behavior when pressing Shift+LeftArrow in a Linux shell session.


Filter remote endpoints to prevent request hairpinning

For Reviewers
Wanted to get a pulse on this idea. I think it's reasonable. Don't want to merge without a unit test.
Context
When generating envoy clusters for SNI DNAT, I noticed that we included remote endpoints if they were present. This seems erroneous because this could result in request hairpinning (for example, infinitely between two different network gateways).
Instead, it seems like we should filter those out and let typical circuit breaking take effect, if the only healthy endpoints we had were in another network.
I only want this change to take effect in SNI DNAT because those clusters are known to be receiving traffic from another network.

@kdorosh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
cc44073b4073306fc46282fde28d78056bc3fe88
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

They should be filterd by REQUESTED_NETWORK_VIEW?
I am fairly sure this looping does not happen, we have pretty extensive tests around this and were pretty intentional

if we had two gateways, one for east/west ingress and one for north/south ingress, then we could have configured separate REQUESTED_NETWORK_VIEWs for each of them and that would work just fine.
that might work for me, so closing until i confirm it does