Focus might not handle child order change

I suspect based on discussions that if you have this kind of setup:
        Focusable widget
               |
              ...
               |
              Row
               |
           +---+---+
           |   |   |
         ...  ...  ...
           |   |   |
           A   B   C

...where A, B, and C are focusable, and then you focus B, and then you cause the tree to become:
        Focusable widget
               |
              ...
               |
              Row
               |
           +---+---+
           |   |   |
         ...  ...  ...
           |   |   |
           C   B   A

...by only rebuilding the Row, and then you hit Tab, the focus will go to C, not A.
cc @gspencergoog

This implies that WidgetOrderTraversalPolicy might need to be reimplemented to traverse the element tree instead of the focus node tree in order to find the next element to be focused.
And if that's the case, then it might be possible to flatten the focus node tree so that only FocusScopes have children.

Except that might not be possible (to reimplement using the element tree), since the element tree has no idea if a particular element is hosting a focus node (other than the Focus and FocusScope widgets themselves).

Can you have a Set that contains all the BuildContexts of FocusNodes?

Yes, we could, but one other thing occurred to me: we can't flatten the focus node tree because it uses that for distributing key events up the parent hierarchy, and it means that a widget that is a descendent of another being focused doesn't imply that the ancestor is also focused: right now the focused widget has hasPrimaryFocus set to true, but all of its ancestors have hasFocus set to true as well, and if the tree were flattened, that would only be true for scopes, not other nodes.

What's the use case for nested focus nodes both looking at the same key events?

For instance, the Shortcuts widget has a Focus node that that listens to keys pressed when its children have focus to see if it should handle the shortcut for them.

That's a solution, not a use case. :-)

Yes, OK.  But there are associated problems that it solves:
The reason we use the hierarchy of nodes to handle keys is so that it isn't necessary to redefine or at least refer to the key bindings at every widget (or in a global handler), so they can be defined (and re-defined) at the container level to do things specific to that UI arena.
A specific example would be a dialog that wants to define the ESC key as a way to get out of the dialog, even if a control within it is focused. As long as the control with focus is a child of the dialog, it will receive the event and handle it.
Another would be in order to define the LEFT ARROW key as the key to move to the next control to the left in a way that can be overridden. It can be defined at the app level so that it covers the entire app by default without having to redefine it for every single control in the app, or with a global key handler. Then, if a particular region of the UI wants to override that behavior, it can, just by redefining the key binding.
Without the hierarchy, the key bindings need to be defined, or at least referred to, at each control, or there has to be complex logic in a global handler to know where to apply it.

In any case, I think it's possible to re-implement the traversal code to use the element hierarchy instead, since we could (as you pointed out), have a set that contains all of the elements in the focus tree, and just look up each element as it's traversed to see if it's in the set.

I can't reproduce a case for this based on the description on the latest master 1.21.0-8.0.pre.176.

Used test case
import 'package:flutter/material.dart';

void main() => runApp(FocusTest());

class FocusTest extends StatefulWidget {
  @override
  _FocusTestState createState() => _FocusTestState();
}

class _FocusTestState extends State<FocusTest> {
  @override
  Widget build(BuildContext context) {
    print('parent rebuild');
    return MaterialApp(
      title: 'Sample',
      home: Scaffold(
        appBar: AppBar(
          title: Text('Sample'),
        ),
        body: Container(
          child: Center(
            child: SingleChildScrollView(
              child: FocusColumn(),
            ),
          ),
        ),
      ),
    );
  }
}

class FocusColumn extends StatefulWidget {
  static _FocusColumnState instance = _FocusColumnState();

  @override
  _FocusColumnState createState() => instance;
}

class _FocusColumnState extends State<FocusColumn> {
  final items = List<Container>.generate(
      5,
      (index) => Container(
            width: 100,
            decoration: BoxDecoration(
              border: Border.all(),
            ),
            child: TextFormField(
              initialValue: index.toString(),
              key: GlobalKey(),
              onChanged: (_) => FocusColumn.instance.shuffleStuff(),
            ),
          ));

  void shuffleStuff() {
    setState(() {
      items.shuffle();
    });
  }

  @override
  Widget build(BuildContext context) {
    print('Row rebuild');
    return Row(children: items);
  }
}

flutter doctor -v
[√] Flutter (Channel master, 1.21.0-8.0.pre.176, on Microsoft Windows [Version 10.0.19041.388], locale en-US)
    • Flutter version 1.21.0-8.0.pre.176 at C:\Development\flutter_master
    • Framework revision d9637ed784 (3 hours ago), 2020-08-11 23:51:03 -0400
    • Engine revision 6381b1511b
    • Dart version 2.10.0 (build 2.10.0-11.0.dev)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at C:\Users\marku\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.1
    • Java binary at: C:\Users\marku\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\193.6626763\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.6.5)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.6.30320.27
    • Windows 10 SDK version 10.0.18362.0

[√] Android Studio (version 4.0)
    • Android Studio at C:\Users\marku\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\193.6626763
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] Connected device (4 available)
    • SM G950F (mobile) • ce12171c51cc001c03 • android-arm64  • Android 9 (API 28)
    • Windows (desktop) • windows            • windows-x64    • Microsoft Windows [Version 10.0.19041.388]
    • Web Server (web)  • web-server         • web-javascript • Flutter Tools
    • Chrome (web)      • chrome             • web-javascript • Google Chrome 84.0.4147.105

• No issues found!

Has this been fixed and can the issue be closed?

Using the code sample provided above, I was unable to replicate the behavior mentioned in original issue, so I am going ahead and closing this issue as not replicable. If anybody disagrees, please write in comments and I'll reopen it.


Add support for media player state

Subscribe to and query media player state.
get_media_foreground_app() will return something like this when using the media player:
[{'appId': 'com.webos.app.mediadiscovery', 'playState': 'playing', 'type': 'media', 'mediaId': '_', 'windowId': '_Window_Id_3'}]
It also works with other media apps:
[{'appId': 'amazon', 'playState': 'playing', 'type': 'media', 'mediaId': '_fMe9g81DBtDVNw', 'windowId': '_Window_Id_9'}]
The endpoint used doesn't appear to be available in all versions of webOS.   It works for me on a newer TV running webOS 7, but on webOS 3.5, it will throw a aiowebostv.exceptions.WebOsTvServiceNotFoundError: 404 no such service or method.

@rale can you please run pre-commit supplied in this repo locally so it fixes the formatting? https://github.com/home-assistant-libs/aiowebostv/actions/runs/4780101336/jobs/8752249979?pr=178

FWIW I have tested this with my LG G2 TV and it works great. I'd love to see this functionality merged so it's usable more easily from Home Assistant.

FWIW I have tested remotely against my LG G2 TV and it works great. I'd love to see this functionality merged so it's usable more easily from Home Assistant.

@andyscott Can you add your TV OS version so that we can confirm what versions support it?
Would also need someone with older OS versions to confirm what is the behavior when/if the TV doesn't support this endpoint.

@thecode yep! I'm out of town at the moment and can't check the WebOS version until I'm back. I believe it was 7.x.x. As for the TV itself, it's:
OLED55G2PUA by LG
Firmware: 03.33.65

I can confirm that this is working:
Media State: {'subscribed': True, 'returnValue': True, 'foregroundAppInfo': [{'appId': 'netflix', 'playState': 'playing', 'type': 'media', 'mediaId': '_LWZpv6U9CkVIAz', 'windowId': '_Window_Id_4'}]}
Software info: {'returnValue': True, 'product_name': 'webOSTV 7.0', 'model_name': 'HE_DTV_W22O_AFABATAA', 'sw_type': 'FIRMWARE', 'major_ver': '03', 'minor_ver': '33.65', 'country': 'DE', 'country_group': 'EU', 'device_id': 'XX', 'auth_flag': 'N', 'ignore_disable': 'N', 'eco_info': '01', 'config_key': '00', 'language_code': 'de-DE'}

WebOS: 7.3.1-39 (mullet-mebbin)

I would prefer someone with older OS versions check it, I have a TV with an older OS but it is disconnected right now, the main problem would be to verify it doesn't break anything and how we detect that the TV doesn't support it to show it correctly on HA

On older TVs where it's not supported, client.media_state is None.
This is what I've been using myself: https://github.com/home-assistant/core/commit/f3c65c68c1c5e781477094fb8a9a3af35e60ff17

Hi!
I've followed what @dekiesel said in this comment to test the branch on my tv that's running an old version of webos (5.4.3-36).
Sadly, the script doesn't seem to receive any information concerning the media that is playing on the tv. Here are the lines that outputted when launching the script, then accepting the external program on my tv:
State changed:
System info: {'returnValue': True, 'features': {'dvr': False}, 'receiverType': 'ATSC', 'modelName': '75UN7070PUC', 'programMode': False}
Media State: {}
Software info: {'returnValue': True, 'product_name': 'webOSTV 5.0', 'model_name': 'HE_DTV_W20P_AFADATAA', 'sw_type': 'FIRMWARE', 'major_ver': '04', 'minor_ver': '41.45', 'country': 'CA2', 'country_group': 'CA', 'device_id': '58:fd:b1:f0:**:**', 'auth_flag': 'N', 'ignore_disable': 'N', 'eco_info': '01', 'config_key': '00', 'language_code': 'en-CA'}

I then started playing a show from the Jellyfin app directly on the tv but nothing more outputted from the script. I let it run for a while, paused, stopped it, to no avail.
On the contrary, here's the output when I lower the volume:
State changed:
System info: {'returnValue': True, 'features': {'dvr': False}, 'receiverType': 'ATSC', 'modelName': '75UN7070PUC', 'programMode': False}
Media State: {}
Software info: {'returnValue': True, 'product_name': 'webOSTV 5.0', 'model_name': 'HE_DTV_W20P_AFADATAA', 'sw_type': 'FIRMWARE', 'major_ver': '04', 'minor_ver': '41.45', 'country': 'CA2', 'country_group': 'CA', 'device_id': '58:fd:b1:f0:**:**', 'auth_flag': 'N', 'ignore_disable': 'N', 'eco_info': '01', 'config_key': '00', 'language_code': 'en-CA'}
State changed:
System info: {'returnValue': True, 'features': {'dvr': False}, 'receiverType': 'ATSC', 'modelName': '75UN7070PUC', 'programMode': False}
Media State: {}
Software info: {'returnValue': True, 'product_name': 'webOSTV 5.0', 'model_name': 'HE_DTV_W20P_AFADATAA', 'sw_type': 'FIRMWARE', 'major_ver': '04', 'minor_ver': '41.45', 'country': 'CA2', 'country_group': 'CA', 'device_id': '58:fd:b1:f0:**:**', 'auth_flag': 'N', 'ignore_disable': 'N', 'eco_info': '01', 'config_key': '00', 'language_code': 'en-CA'}

Let me know if I can test anything else!

Is there anything that should be tested before merging this PR? I am eager to see it merged.

i want to see this merged too :)

👋🏽 I'd also like to see this merged. Is there anything I can do to help?

When do you think the update will be released in HA ?

I can (unfortunately) confirm that on an older webOS version (6.3.3-442), C1 series "playing" status is not presented. But all other functionalities are working the same. So for version 6.x it's safe to merge, nothing is broken.

When do you think the update will be released in HA ?

I can release a new version, but someone needs to work on it on HA side.
I will release a new version tomorrow so we can start working on HA.


Chess: Move D1 to G4

Please do not change the title. Just click "Submit new issue".

@tmchuynh done! Successfully played move d1g4 for current game.
Thanks for playing!


Add Scala 2.13 build

Build also for Scala 2.13

Under 2.13 we have some deprecation warnings about .right.value because .right is deprecated (again?!)  I'm not sure whether we want to fix this right now by e.g. using .toOption.value because of https://github.com/scalatest/scalatest/pull/975

Should be merged after #38

Nice! Do you think we can benefit from https://docs.scala-lang.org/sips/byname-implicits.html in 2.13 without writing two different versions of the shapeless codecs?

Under 2.13 we have some deprecation warnings about .right.value because .right is deprecated (again?!) I'm not sure whether we want to fix this right now by e.g. using .toOption.value because of scalatest/scalatest#975

We should provide negative community feedback to dedeprecate it (again!)
Seriously not sure. Why does scalatest not provide a new rightvalue? I am unsure whether is misslike .toOption.value or the deprecation warnings more.


Make LogSeverity conform to Swift's Comparable protocol

I cleaned up a lot of code by leveraging Swift's Comparable protocol, I hope you like it!

This is great—thanks a lot!
Since the removal of the LogSeverity.Comparator constitutes a breaking API change, I'll release this with 1.3.0.


assert built mocha.js is identical to root mocha.js when version bumped

given the root mocha.js dist file shouldn't change until a version bump, and we build a new version of this dist file for tests, we are missing the potential problem where everything is fine for releasing except someone forgot to rebuild mocha.js.
granted, the preversion script should avoid this problem, but there's nothing stopping a maintainer from bumping via other means.

To be exact, under our current setup it will be fine if:

the version is bumped immediately before publishing and
the version bump is accomplished via NPM

What we need, at the most fundamental level, is not necessarily an assertion so much as simply something (assertion, or just doing the build) to get this right in the publishing step.

Since version 4, we now build in the prepublishOnly step, but only test in the version step, which opens us to more or less the same dangers (changes between version and publish, manually versioning); the remaining thing to do along the lines of this issue would be to move the test from preversion to prepublishOnly, right?

I'm a bit confused--prepublishOnly will fix the original issue here, which was that building the dist file wasn't necessarily happening.

Yeah -- we could close this, since for using for using an up-to-date built file we've got it solved.
I'm just saying that testing (ensuring that the built file is going to be any good) still has the same basic issue of not necessarily happening because it's associated with NPM-based versioning. If we closed this I'd want to open a near-identical issue with "test" replacing "build".

Right.  My motivation to remove it was that I ran npm version blah which ran the tests, pushed, asserted the build passed, then was gonna run npm publish which would just run the tests again, knowhatImean?  Just seemed like a waste of time at that point.  Perhaps removing the preversion script would be fine, since you don't necessarily have to push once you've done that--but npm publish makes things happen immediately!
I'll make this change

Oh, also, I noticed npm version will actually fail in<EMAIL_ADDRESS>if .package-lock.json is in your .gitignore...

Oh, also, I noticed  npm version  will actually fail in<EMAIL_ADDRESS>if  .package-lock.json  is in your  .gitignore ...

Wait, so if we use package-lock.json we break CI installs due to faulty dependency trees, but if we don't use package-lock.json we have to version manually? That's one I hadn't heard of before.

I really dunno.  I'll give package-lock.json another shot here soon.  could be a travis-related caching problem.

I'm reopening this as we had another publishing problem that this fix didn't address: missing file(s) in the published package.
As part of our "smoke" tests, we need to ensure the output of (perhaps?) npm pack works properly. Open to other ideas, but this is my first thought.  Create a script to:

Run npm start build && npm pack --json
Parse the result of npm pack --json to get the output filename
Unarchive the file to some temp directory
Run /path/to/temp/bin/mocha --no-config --reporter spec test/sanity/sanity.spec.js

This script should replace the script property of the smoke stage in .travis.yml.  It should be written in JavaScript.

Rename "sanity" to "smoke" while we're at it.


Add minimum gem version for ruby-kafka

I found this out the hard way :)
The method API of the monkey patched changed in ruby-kafka changed in 0.7.0+ (headers: kwarg was added). If you try to use 0.6.8 or earlier, chaos ensues.

add an appraisal for 0.7.0 up to the most recent version.

I've done this. Actually 1.0.0+ are already there, and 0.7.0 is the last in the 0.x series so I've added it (refer to code changes)

add an appraisal for 0.7.0 up to the most recent version.

I've done this. Actually 1.0.0+ are already there, and 0.7.0 is the last in the 0.x series so I've added it (refer to code changes)

@robertlaurin it looks like there is some unrelated spec failure here:
  1) Failure:
OpenTelemetry::Instrumentation::RubyKafka::Patches::Consumer::#each_message#test_0001_traces each_meassage call [/__w/opentelemetry-ruby/opentelemetry-ruby/instrumentation/ruby_kafka/test/opentelemetry/instrumentation/ruby-kafka/patches/consumer_test.rb:73]:
Expected # encoding: ASCII-8BIT
#    valid: true
"k\xD7\xBFu\xFF\xB7X\x92\xC3p\xB4\x9Cl\vH\xEA" to not be equal to # encoding: ASCII-8BIT
#    valid: true
"k\xD7\xBFu\xFF\xB7X\x92\xC3p\xB4\x9Cl\vH\xEA".

@robertlaurin it looks like there is some unrelated spec failure here:
  1) Failure:
OpenTelemetry::Instrumentation::RubyKafka::Patches::Consumer::#each_message#test_0001_traces each_meassage call [/__w/opentelemetry-ruby/opentelemetry-ruby/instrumentation/ruby_kafka/test/opentelemetry/instrumentation/ruby-kafka/patches/consumer_test.rb:73]:
Expected # encoding: ASCII-8BIT
#    valid: true
"k\xD7\xBFu\xFF\xB7X\x92\xC3p\xB4\x9Cl\vH\xEA" to not be equal to # encoding: ASCII-8BIT
#    valid: true
"k\xD7\xBFu\xFF\xB7X\x92\xC3p\xB4\x9Cl\vH\xEA".

Ready for merge

Ready for merge


Add the Roslyn syntax visualizer

https://github.com/dotnet/roslyn/tree/master/src/Tools/Source/SyntaxVisualizer
It can be very useful when writing analyzers and refactorings.
Besides, it doesn't stand to reason that LINQPad would have it whereas RoslynPad wouldn't :)

100th issue! 🎉

Shouldn't you be celebrating having few of these? 😏
On Apr 27, 2017 18:19, "Eli Arbel"<EMAIL_ADDRESS>wrote:
100th issue! 🎉
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aelij/RoslynPad/issues/100#issuecomment-297746437, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AIKMeWvH60AU_XjQhgp5bEuCUnnh7y4Kks5r0LH7gaJpZM4NKW1s
.

As long as they are enhancements and not bugs, I'm happy :)

😏
On Apr 27, 2017 9:20 PM, "Eli Arbel"<EMAIL_ADDRESS>wrote:

As long as they are enhancements and not bugs, I'm happy :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aelij/RoslynPad/issues/100#issuecomment-297797419,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIKMedEe_ThoXkx3vNq2C-tkbqboz5Iqks5r0NxfgaJpZM4NKW1s
.


No way to convert strings to numbers not in object mode

Hi, in object mode, data can be converted from strings to numbers.
b = np.array(['4', '5', '0', '1'])

@numba.jit
def test(b):
    for i in range(len(b)):
        print(int(b[i]))

test(b)

Output:

4
5
0
1

But when we try to use njit, an error occurs, can we do something about this?

@1e-to thanks for looking into this. Could you check if this might be a duplicate of #4758

Closing as a dupliacte of #4758


Add Los Rios Community Colleges

Los Rios Community Colleges are a group of community colleges in the Sacramento, California area.
Link to Parent Organization: https://losrios.edu/
Link to Computer Information Science Program: https://www.arc.losrios.edu/academics/programs-and-majors/computer-information-science
I have included in the upload a screenshot of my email account showing that apps.losrios.edu hosts the email account.

@kcameron85 lib/domains/los_rios/Email: Your request has an incorrect file path format, please ensure the request follows     the repository rules set out at the bottom of this page and change     it accordingly or start a new one.     If you are unable to make a pull request with the instructions provided, please send an email to<EMAIL_ADDRESS>mentioning the URL of this request in the message.

Hello @philipto,
I updated the file path to comply with the repository rules. I'm not sure what happened with my original upload but I think I fixed it.

@kcameron85 I am sorry, the domain losrios.edu is blacklisted because the school allows to register an email address there even if you are not a student of the school. If you are the student of this school, please apply with official document (OFFICIAL DOCUMENT tab at https://www.jetbrains.com/shop/eform/students).


Governance Updates -- update used dependencies

This doesn't address all of the component governance issues as some of the dependencies (one being the current npm) has not yet released a version that addresses all of them.
So this addresses those that it can.


use iso8601 date format everywhere in all reports

is there a way to have YYYY-MM-DD HH:MM:SS formatted timestamp in the html and console reports?

Are you asking about the date format specifically in the visitors panel?

that and also the title of the report:
"Overall Analyzed Requests 01/Jun/2023 — 28/Jun/2023"


Decimal input round up or round down in fixture

I have a decimal input for serum dig level which will be round up or down in fixture. If the digit is less than 5, round the previous digit down; if it's 5 or greater, round the previous digit up.

Guideline:https://www.mdcalc.com/digifab-digibind-dosing-digoxin-poisoning#evidence
@rashmidamu

@MaryamRazavi, it is probably a bug in the gdl2 editor. It executes as expected in the gdl2 engine. So, it should work when you use the fixture generator to create the test fixture for this guideline.

@rashmidamu This issue is fixed in gdl 2 editor preview 4.

Great!


install-llvm.sh doesn't install in the right place

I tried this
HIPSYCL_LLVM_BUILD_DIR=/tmp/git/llvm-vanilla INSTALL_PREFIX=/home/jehammond/RAJA/ bash ./install/scripts/install-llvm.sh

and it failed on make install when it tried to install something in /include/llvm.
This fixes it:
diff --git a/install/scripts/install-llvm.sh b/install/scripts/install-llvm.sh
index 173e381..c99ba53 100644
--- a/install/scripts/install-llvm.sh
+++ b/install/scripts/install-llvm.sh
@@ -49,7 +49,7 @@ mkdir -p $HIPSYCL_LLVM_BUILD_DIR/build
 cd $HIPSYCL_LLVM_BUILD_DIR/build
 cmake $CMAKE_OPTIONS $HIPSYCL_LLVM_BUILD_DIR/llvm
 make -j $NUMTHREADS
-make install
+DESTDIR=$HIPSYCL_LLVM_INSTALL_PREFIX make install
 cp -p $HIPSYCL_LLVM_BUILD_DIR/build/bin/llvm-lit   $HIPSYCL_LLVM_INSTALL_PREFIX/bin/llvm-lit
 cp -p $HIPSYCL_LLVM_BUILD_DIR/build/bin/FileCheck  $HIPSYCL_LLVM_INSTALL_PREFIX/bin/FileCheck
 cp -p $HIPSYCL_LLVM_BUILD_DIR/build/bin/count      $HIPSYCL_LLVM_INSTALL_PREFIX/bin/count

I am on the latest develop.

Hi, I am looking into this. My understanding is that this script hasn't been used for a while, would installing llvm using spack be an option for you? We have a script that uses spack to install llvm in install/scripts/spack-install/

I do not use spack for anything else and really hope to not have to install and learn an entire package management system just to install hipsycl.


Allow downcasts of Literals if convertible

The patch makes it possible to downcast Literals with higher precedence in expressions which also contain other castable arguments.
Before: int_arr[1] = 123 => to_long(subscript(int_arr, 1)) = 123
          ^^^^^      ^^^
         castable castable
After:  int_arr[1] = 123 => subscript(int_arr, 1) = to_int(123)

This has the advantage that the lossless conversion is only performed once for
the Literal, whereas it might have to be performed for every record in case of a
column. The LuceneQueryBuilder is only able to generate a fast Lucene index
query if no cast function is applied.

@matriv @mfussenegger Re-introduced explicit lossy casts by adding a lossless flag to the data type conversion.

I'm not sure if this is really the right approach to handle this.
We'll have inconsistent behaviour if parameter placeholders are used: select x + 1 = ?, x + 1 = 1.4 from t1 where ? := 1.4 will return True, False

I attempted to create a cleaner solution where ParamterSymbol and Literal are checked for conversion before any other Symbols. I also wanted to avoid any other casts which result in a lower precision. I'm struggling with replicating checks for all possible safe type conversions which we currently support. So I'm currently stuck with some tests cases failing. Last commit is WIP.

@mfussenegger Pushed a new version which a much narrower scope. Would appreciate if you could have a look.

There are already separate changes entries for both commits. Makes sense to split them up into different PRs.

Jenkins fails to fetch from GitHub.
retest this please

Do you think we should backport this to 3.0?

Do you think we should backport this to 3.0?

If we have any known cases where this results in a worse Lucene-query being generated I'd say yes.

The fix in the change log doesn't apply to 3.0 because the Lucene query optimization for arrays is only included in the latest master. However, there are other cases in 3.0 where we could cast literals to improve performance. Some of them are in the test cases changed in this PR.

So I'll backport this with an adjusted change log message.

Backported to 3.0 with 53b6ebabc6e44a92c86193552a24c29a30d71ea7.


Trust-location is causing ANR when used in the same project with the background_locator_2 library

Hi, your library is causing ANR in my project and it is possible that it causes the same problem in other libraries that use device location.
I/locator_exampl(19665): Thread[3,tid=19672,WaitingInMainSignalCatcherLoop,Thread*=0x7de5016400,peer=0x17ec0020,"Signal Catcher"]: reacting to signal 3
I/locator_exampl(19665):
I/locator_exampl(19665): Wrote stack traces to '[tombstoned]'

So that you can test it, download my FORK from the background_locator_2 project and add your library in the pubspec.yaml file of the "example" project:

background_locator_2:
path: ../
path_provider: ^2.0.8
location_permissions: ^3.0.0+1
trust_location: ^2.0.13

In the example project, when you press the "Start" button, you will notice that the app freezes.
PS: I noticed this problem when testing the safe-device library, which also uses your library. Upon investigation, I noticed that the problem is actually with your library.

I have the safe issue (constant ANR when calling isMockLocation on Android). I use trust-location (safe-device) with  geolocator

I have the same case like @tulioccalazans. Have you found any solution ?

I have the same case like @tulioccalazans. Have you found any solution ?

Nothing yet. I stopped using Trust-location.

meanwhile in the archive pubspec.yml
  safe_device:     git:         url: https://github.com/tulioccalazans/safe_device
thanks @tulioccalazans  ANR errors gone for now


Instrument http-out before app start

@StorytellerCZ thank you for merging this small improvement!
Could you please release new version containing this patch?
It is a blocker for my investigation indeed

@Strangerxxx Published in 2.4.2


MinGW and gfortran problem

MinGHC 7.10.2 x64, Windows 10 x64
I'm trying to build OpenBLAS that way:

Install MinGHC 7.10.2 in folder without spaces
Clone OpenBLAS (https://github.com/xianyi/OpenBLAS.git)
mingw32-make in OpenBLAS root

I got:

gfortran: error: CreateProcess: No such file or directory

while building it. So I found that problem on Stackoverflow:
http://stackoverflow.com/questions/28599135/gfortran-error-createprocess-no-such-file-or-directory-in-build-with-mingw
They state that the problem could be in not correctly installed Mingw.

The mingw shipped with minghc doesn't have Fortran as far as I know. It's
shipped with GHC specifically for building Haskell code. You'll likely need
to get a separate mingw install.
On Mon, Sep 21, 2015, 12:33 AM varosi<EMAIL_ADDRESS>wrote:

MinGHC 7.10.2 x64, Windows 10 x64
I'm trying to build OpenBLAS that way:

Install MinGHC 7.10.2 in folder without spaces
Clone OpenBLAS (https://github.com/xianyi/OpenBLAS.git)
mingw32-make in OpenBLAS root

I got:
gfortran: error: CreateProcess: No such file or directory
while building it. So I found that problem on Stackoverflow:
http://stackoverflow.com/questions/28599135/gfortran-error-createprocess-no-such-file-or-directory-in-build-with-mingw
They state that the problem could be in not correctly installed Mingw.
—
Reply to this email directly or view it on GitHub
https://github.com/fpco/minghc/issues/92.

Check this executable:
minghc-7.10.2-x86_64\ghc-7.10.2\mingw\bin\gfortran.exe

It's worth noting that the mingw that ships with GHC is never added to your PATH. GHC uses it privately with relative paths. If you actually want your build process to find anything in that folder, you likely need to add it to your PATH.

We now advise people use Stack instead, MinGHC is no longer supported.


Add vaultSkipVerify variable

Fixes #3
Adds the ability to insert VAULT_SKIP_VERIFY environment variable to skip TLS verification.

#5


Fix short/int16 casting from OpenApi

Why did this build fail? It looks like a completely genuine attempt to solve a small set of (apparently!) cut-and-paste typo errors around this bit of the code. I've applied these locally and they build and test fine!

(PS I noticed that this and #1139 are in the same area of code - it looks at first glance unlikely that both commits are fully right, since #1139 effectively does not make the changes which this commit does make?)

@epsitec Looking at the differences between this and #1139, it looks to me as if you need to modify:

Swashbuckle.AspNetCore.SwaggerGen.PrimitiveSchemaGenerator.FactoryMethodMap

as well?
Also the relevant tests:

Swashbuckle.AspNetCore.SwaggerGen.Test.SchemaGeneratorTests.GenerateSchema_GeneratesPrimitiveSchema_IfPrimitiveType
Swashbuckle.AspNetCore.SwaggerGen.Test.SchemaGeneratorTests.GenerateSchema_GeneratesEnumSchema_IfEnumType

I was wondering what the origin is of the type strings allowed in OpenApiSchema.Format... is "int16" actually 'valid'? (This document doesn't seem to say: https://tools.ietf.org/html/draft-fge-json-schema-validation-00) And what type should be used for a byte (#1139)? (Maybe these choices are purely internal to Swashbuckle.AspNetCore, I'm not quite sure.)
Assuming that "int16" is valid and that something like "byte" is valid for byte (i.e. mainly assuming that @domaindrivendev didn't already consciously decide against doing this!), then it's fairly easy to (and I'd be happy to) do a PR which combines the commits from this PR with the similar commits for the byte-valued enums from #1139, and with required (I think?) matching updates to the tests and factory methods mentioned above.

I had to apply the int16 fix in order for my Core 3.0 preview5 to work after migrating to this latest release of the framework, as the existing code crashed when trying to cast a short while unboxing. I’m not at my computer for the next few days, so I’m not in a position to test anything.

Closing because 1) "int16" is not a standard value for the schema Format and 2) I don't want to target 3.0 as the minimum supported version


MINOR: Increase the delta for a flaky quota test

Flaky test failing with assertion error just outside the defined threshold. So, bumping up the delta for quota by 1.
java.util.concurrent.ExecutionException: org.opentest4j.AssertionFailedError: Expected rate (30 +- 7), but got 37.50937734433608 (600 connections / 15.996 sec) ==> expected: <30.0> but was: <37.50937734433608>

@harinirajendran , thanks for the PR. Could you explain more what this test is trying to do, and why we originally set it to 7? I know it's not written by you, but after you investigating this test, why it is 7? And why changing to 8 fixes it? Just because you saw there's a flaky test failure message and changing to 8 can fix it? Then, if some day after you changing to 8, and it failed again, should we change to 9 then? then 10, 11... ? Please try to persuade me your rational behind this change. Thank you.

@showuon : Thank you for the review. The rationale for the change is as follows. This test used to be flaky in our proprietary fork with the same assert exception. The delta was bumped up from 7 to 8, 2 years ago and since then it has been fine. Now this test is behaving flaky in our public https://github.com/confluentinc/kafka repo. So, I am just applying the same fix here as well.

We decided to fix this flaky test in our fork for now. So, closing the PR.


Update 2022-06-06-postprint-pledge-for-linguists.md

Fixed numbering line 29
Please note that if you are trying to update your website, this is the wrong place to do so. Please carefully follow the Beautiful Jekyll instructions (found at https://github.com/daattali/beautiful-jekyll#readme) and make sure you submit changes to your version of the project.
If your intention is to submit a Pull Request, please describe what your pull request achieves.
Thank you!

Spacing issue has been fixed.


Review: Landing.jsx and Audited.jsx

Overview
The focus for this code review will be centered around the Landing and Audited pages.
Please pay attention too:

Javascript issues
React components

Review Branch
review-4
Files to review

Landing.jsx
Audited.jsx

Checklists

Architecture
Design
JS
React
Testing

Due date
10/07/2024 at 9:00am
For more information
The review process is documented at: http://courses.ics.hawaii.edu/ics414s21/morea/review/reading-idpm-review.html

Landing.jsx
DE-01: Can you refactor - The component is straightforward, but maybe you could refactor the feature cards into a separate FeatureCard component to improve reusability.
Audited.jsx
DE-01: Can you refactor - The tooltip functions could be refactored into a single reusable function that accepts the tooltip text as an argument to avoid redundancy.
DE-07: Ensure code is DRY- The tooltip elements are a bit repetitive. Maybe you could create a generic tooltip function to DRY up the code.

Landing.jsx

DE-01: Feature cards could be refactored to avoid repetition.
DE-03: The commented code, the third carousel item, can be deleted. I was the one who commented out that code and it is no longer needed.

Audited.jsx

DE-07: Even though each tooltip has a separate function, the code for the tooltips is repetitive because they follow the same structure. To avoid repetition, we can refactor into a reusable function.

Landing.jsx
AR-01 (ln N/A): The file name landing.jsx should follow the lowercase naming convention and is correct.
DE-01 (ln 28): There is commented-out code (<Carousel.Item> with a third slide), which can be removed if not needed, or reintroduced once the third image is ready.
DE-06 (ln 9): The ESLint comment disabling unused variable checks (eslint-disable-next-line no-unused-vars) indicates that e is not being used in the handleSelect function. It might be better to remove the parameter e if it's not necessary.
Audited.jsx
AR-01 (ln N/A): The file name audited.jsx follows the correct lowercase naming convention and is correct.
ES-01 (ln 10, ln 14, ln 18, ln 22, ln 26, ln 30, ln 34, ln 38, ln 42, ln 46, ln 50, ln 54, ln 58, ln 62, ln 66, ln 70, ln 74, ln 78, ln 82, ln 86, ln 90, ln 94): Multiple instances of eslint-disable-next-line react/jsx-props-no-spreading are used to suppress warnings. It is better to refactor the code to avoid spreading props unless absolutely necessary.
DE-06 (ln N/A): Code is generally readable, though the repeated use of OverlayTrigger components for tooltips might benefit from abstraction into a reusable component to reduce redundancy.

Landing.jsx
DE-03 on lines 41 to 42 (unused code)
ES-01 on line 12 (unused parameter e)
Audited.jsx
DE-01 in the beginning (not sure how to reduce
the duplication but it might be possible)
DE-05 line 92 (what does this mean?)
ES-01 line 1 (a lot is similar AuditedBalanceInput.jsx)

Landing.jsx

L40-42: Design-03, Remove code that is being unused
L11: Design-04,  e parameter is unused, remove unecessary comments
Audited.jsx

L105-112 and alike: Design-01: refactor the code that is similar to this format to avoid redundancy
L107-109: Design-08: Ensure code is DRY. There is repetition with the Form.Group as mentioned previously as well as OverlayTrigger

Landing.jsx
DE-01:  The same ImageCarousel is used twice. Add different images or remove the second one if it’s not needed.
DE-03: The cards are repetitive. Create a FeatureCard component to reuse the structure.
DE-04: Add "Learn More" buttons or links to the cards for more details.
Audit.jsx
DE-02: The buttons at the bottom are hardcoded with inline styles. It would be better to move the styles to CSS classes for consistency.
RE-01: The form fields and tooltips are repeated. Extract them into a separate form component to reduce duplication.

Review of Landing.jsx
1. Architecture Review:

AR-01: Directory Structure - Check if the file follows a proper directory structure.

Observation: The file seems to be located properly within the project’s structure. Ensure that components are placed in a directory that reflects their role in the application.

AR-02: File Naming Convention - Ensure the file name reflects the component's purpose.

Observation: The name Landing.jsx is appropriate for a landing page component.

AR-04: Component Organization - Components should be modular and organized.

Observation: The component could be modularized further, breaking down large sections into smaller reusable components.

2. Design Review:

DE-03: Use of Layout - Properly use layout grids and ensure responsiveness.

Observation: The layout of the Landing.jsx page is responsive, but could benefit from further testing across multiple screen sizes.

DE-06: Component Reusability - Look for repetition that could be abstracted into reusable components.

Observation: There are several repeated JSX elements, which could be extracted into reusable components to improve maintainability.

3. JavaScript Review:

JS-02: Variable Declarations - Ensure the use of const and let appropriately.

Observation: Proper usage of const for constants and let for variables is followed.

JS-07: DRY Principle - Avoid repetitive code.

Observation: Repeated JSX sections are present, and breaking these into functions or components would adhere better to the DRY principle.

4. React Review:

RE-01: Functional vs Class Components - Prefer functional components for simplicity.

Observation: If this is not a class-based component, it follows the recommendation to use functional components.

RE-03: Prop Drilling - Minimize prop drilling by using context or other state management tools.

Observation: If there is deep prop drilling, it should be refactored to use context API or a state management solution like Redux.

Review of Audited.jsx
1. Architecture Review:

AR-01: Directory Structure - Check if the file follows a proper directory structure.

Observation: Similar to Landing.jsx, the file seems appropriately placed but ensure consistency in how the component hierarchy is structured.

AR-02: File Naming Convention - Ensure the file name reflects the component's purpose.

Observation: The name Audited.jsx suggests it is related to audited data or elements, which fits well if that's its intended purpose.

2. Design Review:

DE-03: Use of Layout - Properly use layout grids and ensure responsiveness.

Observation: The layout looks solid, but there is room to ensure all components are responsive, especially on mobile.

DE-06: Component Reusability - Look for repetition that could be abstracted into reusable components.

Observation: There are areas where form groups and inputs are repeated, suggesting these could be moved into a more generic form field component for reuse.

3. JavaScript Review:

JS-02: Variable Declarations - Ensure the use of const and let appropriately.

Observation: Proper use of const and let is observed throughout.

JS-07: DRY Principle - Avoid repetitive code.

Observation: Like in Landing.jsx, there are sections of repeated form inputs that could be abstracted into reusable components.

4. React Review:

RE-01: Functional vs Class Components - Prefer functional components for simplicity.

Observation: If it is a functional component, then this guideline is followed well. Otherwise, consider converting any class-based logic to functional components.

RE-09: Stateless Components - Ensure that components are stateless if they do not manage their own state.

Observation: If this component doesn't manage state, it should be stateless, relying on props for data.

Landing.jsx
DE-01:  Feature cards should be refactored to improve reusability and code readability.
Audited.jsx
DE-06: Repetitive elements of code, namely the tooltips. Should be refactored into reusable components


Error: Missing field options

System Info
System:
OS: macOS 13.3.1
CPU: (10) arm64 Apple M1 Pro
Memory: 57.95 MB / 32.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 18.13.0 - ~/.nvm/versions/node/v18.13.0/bin/node
Yarn: 1.22.19 - /opt/homebrew/bin/yarn
npm: 8.19.3 - ~/.nvm/versions/node/v18.13.0/bin/npm
pnpm: 8.6.5 - ~/.nvm/versions/node/v18.13.0/bin/pnpm
Browsers:
Brave Browser: <IP_ADDRESS>
Chrome: 120.0.6099.71
Edge: 120.0.2210.61
Safari: 16.4
npmPackages:
@rspack/cli: 0.4.1 => 0.4.1
@rspack/core: 0.4.1 => 0.4.1
Details
Error: Missing field `options`
    at Compiler._Compiler_getInstance (/Users/andreas.neufeld/Code/aboutyou-panel-application/node_modules/@rspack/cli/node_modules/@rspack/core/dist/Compiler.js:516:55)
    at Compiler.build (/Users/andreas.neufeld/Code/aboutyou-panel-application/node_modules/@rspack/cli/node_modules/@rspack/core/dist/Compiler.js:380:87)
    at /Users/andreas.neufeld/Code/aboutyou-panel-application/node_modules/@rspack/cli/node_modules/@rspack/core/dist/Watching.js:269:27
    at Hook.eval [as callAsync] (eval at create (/Users/andreas.neufeld/Code/aboutyou-panel-application/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:24:1)
    at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/Users/andreas.neufeld/Code/aboutyou-panel-application/node_modules/tapable/lib/Hook.js:18:14)
    at Watching._Watching_go (/Users/andreas.neufeld/Code/aboutyou-panel-application/node_modules/@rspack/cli/node_modules/@rspack/core/dist/Watching.js:253:34)
    at Watching._Watching_invalidate (/Users/andreas.neufeld/Code/aboutyou-panel-application/node_modules/@rspack/cli/node_modules/@rspack/core/dist/Watching.js:217:74)
    at /Users/andreas.neufeld/Code/aboutyou-panel-application/node_modules/@rspack/cli/node_modules/@rspack/core/dist/Watching.js:51:94
    at processTicksAndRejections (node:internal/process/task_queues:77:11) {
  code: 'InvalidArg'
}

For some reason it works only again if the node_modules folder is deleted and then reverted to 0.4.0. Using bun 1.0.15 as a package manager.
Reproduce link
No response
Reproduce Steps

Upgrade from 0.3.14 to 0.4.x
npx rspack serve
Error is shown

same issue +1

check whether @rspack/binding and @rspack/core are same version in your node_modules

check whether @rspack/binding and @rspack/core are same version in your node_modules

--node_modules
--playground
--node_modules
--rspack-project
the first node_modules contains @rspack/core and binding, both version is 0.4.2
the inner node_modules(beside rspack-project) also contains @rspack/core and binding, both version is 0.4.0
I delete the inner node_modules/@rspack/core(binding), rspack works well.
I am not sure why there are two node_modules. (I am using npm workspace).
"workspaces": [
    ".",
    "playground/*"
  ],

seems your issue is resolved

seems your issue is resolved

What? I had to manually delete the problem to get rid of it, at least I think rspack's case support for monorepo is problematic.

I think this is related to bun.
Steps to reproduce:

Install bun:
curl -fsSL https://bun.sh/install | bash

clone rspack repro
git clone git@github.com:web-infra-dev/rspack-repro.git

cd rspack-dist

Run bun run dev:rspack

Working example:

Install pnpm
clone rspack repro
cd rspack-dist
Run pnpm run dev:rspack

@f0reclone  I can't reproduce following your step, you can commit the node_modules so we can investigate

@lovetingyuan  please provide repro


Transfer has issues with sending tx for sign for PolkadotJS extenstion

okay, it's happening on slow internet.
Probably enable submit button only once client is connected to RPC node

I'm working on it :)


App shell schematic does not use production configuration

When adding app-shell via ng generate app-shell, the generated target is
"app-shell": {
  "builder": "@angular-devkit/build-angular:app-shell",
  "options": {
    "browserTarget": "latest-project:build",
    "serverTarget": "latest-project:server",
    "route": "shell"
  }
}

Since browserTarget is latest-project:build, the production build will never be used when running the app-shell target and thus bundles sizes will be very big.
We should either use "browserTarget": "latest-project:build:production", or add a production configuration for the app shell target too.
"app-shell": {
  "builder": "@angular-devkit/build-angular:app-shell",
  "options": {
    "browserTarget": "latest-project:build",
    "serverTarget": "latest-project:server",
    "route": "shell"
  },
  "configurations": {
    "production": {
      "browserTarget": "latest-project:build:production"
    }
  }
}

I am getting enableProdMode() warning. Is this related to the server distribution?


DEPRECATED Action signature

Fresh install 2016-05-11 20:50 UTC
OSX: 10.11.5 Beta (15F28b)
Eng-MacBook-Pro:~ karl$ dvm ls
->	system (1.9.1)
DEPRECATED Action signature.  Must be cli.ActionFunc.  This is an error in the application.  Please contact the distributor of this application if this is not you.  See https://github.com/codegangsta/cli/blob/master/CHANGELOG.md#deprecated-cli-app-action-signature

Looks like a small enough signature change. I'll look at this today.

Okay the main change is that all command actions should return error. However I don't like how it handles the error, we have much nicer stuff in util right now with coloring, formatting, etc. So I'm going to keep what we have and just return nil from everything.

@kputland Thank you for reporting this problem! I've released dvm 0.4.2, just run dvm upgrade and you should be all set.

Looks good now. No more error.
Thanks.
Eng-MacBook-Pro:~ karl$ dvm ls
->
system (1.9.1)
DEPRECATED Action signature.  Must be cli.ActionFunc.  This is an error in the application.  Please contact the distributor of this application if this is not you.  See
https://github.com/codegangsta/cli/blob/master/CHANGELOG.md#deprecated-cli-app-action-signature
Eng-MacBook-Pro:~ karl$ dvm upgrade
Upgrading to dvm 0.4.2...
DEPRECATED Action signature.  Must be cli.ActionFunc.  This is an error in the application.  Please contact the distributor of this application if this is not you.  See
https://github.com/codegangsta/cli/blob/master/CHANGELOG.md#deprecated-cli-app-action-signature
Eng-MacBook-Pro:~ karl$ dvm ls
->
system (1.9.1)
Eng-MacBook-Pro:~ karl$
On May 12, 2016, at 9:46 AM, Carolyn Van Slyck<EMAIL_ADDRESS>wrote:
@kputland Thank you for reporting this problem! I've released dvm 0.4.2, just run
dvm upgrade and you should be all set.
—
You are receiving this because you were mentioned.
Reply to this email directly or
view it on GitHub


Source code of tiny lib

Where is the c/c++ JNI source code of the tiny lib?

You can see the sample code,also see my blog.

Yeah. Just without the whole repo being open source and transparent, people may or may not want to use it. Also what is the license of the tiny C, C++ lib?


Faie 1673: support inference for the latest anomalib

Tested tensorRT and pytorch weights of three models on x86: padim, patchcore and efficientad.
The latest anomalib requires python 3.10. Haven't test on ARM because we don't have any lab jetson devices with that version of python.

Also, update the pipeline_utils/resize_image function to support any type of input images


add grpc cache

Fixes # (issue)
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:

[ ] CHANGELOG.md updated for non-trivial changes
[ ] Unit tests have been added
[ ] Changes in public API reviewed

Codecov Report

Merging #26 (9a77aa7) into main (f4dd108) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   94.22%   94.22%
=======================================
  Files         187      187
  Lines        8882     8882
=======================================
  Hits         8369     8369
  Misses        513      513


Log monitor results into files.

Investigate using a common definition for the ForegroundItem class/interface.
Related:  #5

At this stage, ForegroundItem is being manually coded in both TypeScript and C#.


Searching with double quotes can return unexpected results

According to @Kimtaro, this is due an issue with the Jisho.org API's lack of proper support for the quotation mark feature. He should be on it some time after April. Thank you!
e.g. search "love" using the workflow and search "love" on Jisho.org
Temporary workaround: Search for English words without double quotations first. If romaji results appear, try surrounding with double quotations.

@janclarin Sorry for the delay on this. I have finally fixed it. The API should now behave like the regular site for ""-searches.
I should mention though that it's very naive, it just checks for the presence of " in the keyword, removes it and turns on exact mode, where I don't do any romaji<>kana conversion.

@Kimtaro thank you so much! It works great. I think that method should be sufficient, I'll let you know if I encounter any bugs.


Cloud Mqqt with homeassistant

I don't understand how connect it.. I try several things...
my config:
HOMEASSISTANT
mqtt:
broker: *********
port: *****  PORT WITHOUT SSL
username: ****** USER CREATED IN USER&ACL PANEL WITH topic # and read/write
password: ****
https://www.home-assistant.io/docs/mqtt/broker
same config for risco-mqtt-bridge (my riscocloud password are ok)

my config is ok... but no devices discover in homeassistant
which is my error?
I have to make other configurations?

Ciao Sei italiano ? Scrivimi a Calcaterra<EMAIL_ADDRESS>Il giorno Sab 10 Nov 2018, 21:50 platini76<EMAIL_ADDRESS>ha
scritto:

my config is ok... but no devices discover in homeassistant
which is my error?
I have to make other configurations?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lucacalcaterra/risco-mqtt-bridge/issues/1#issuecomment-437620249,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA1s0X9kasMuy6swc8nNMatGrA7JNjc_ks5utzv4gaJpZM4YYICk
.

Fixed.. With last commit (so release 1.1) you can reflect states on MQTT for Home Assistant. See config example


Update CODEOWNERS

From observation. Looks like nesting is winning and @tg-msft is no longer added to our PRs. Fixing that here.

/check-enforcer override


Discover page causes crash

After few refresh Discover page causes crash on Windows machines
I couldn't reproduce this on Mac and Windows,

[ ] need double check to make sure there is no memory leak
[ ] after few refresh list doesn't randomize anymore, use New/Created feed as well to increase randomness

The installer was being auto deleted by McAfee AV.

Discover page updated based on hardcoded user list. https://github.com/eSteemApp/esteem-surfer/commit/c1cc38369a6a7139117b9e99abbdc786ce93ff7c

@Transisto whitelist the installer in your McAfee AV so it won't get deleted again

@horpeyloaded  I dont think this problem related with discover page. Maybe you can define an exception for surfer to avast?


⚠ Bofrost.at has degraded performance

In c3e2e55, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2494 ms

Resolved: Bofrost.at performance has improved in e12f64c.


Why not run in production?

It's mentioned not to run this in production. Why not?

It uses a lot of memory and will most likely make all of your queries run a couple percentage points slower. If you're okay with that feel free to run it in prod, but at your own risk!

One last follow-up question: Does this use a lot of memory on the database nodes, or just in the NodeJS box where it runs? The former is a big problem for us, but the latter is no prob at all, we can just spin up an isolated box.

The latter!

thanks!

@mxstbr
Follow-up question: I'm perusing the code, and I don't see any reasons at first glance, that there would be increased memory usage. Why do you think that's the case.
Also re: time. It doesn't seem like it would slow queries down by a multiplier, as you indicated, but more as an addition. So longest queries wouldn't be much different. Am I misunderstanding the code?


SOLR-17400: remove deprecated snapshot related code

https://issues.apache.org/jira/browse/SOLR-17400
Description
Removing from main deprecated code.
Solution
this is only for main, and removing deprecated code and providing some clearer names.
Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
Checklist
Please review the following and check all that apply:

[ ] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[ ] I have created a Jira issue and added the issue ID to my pull request title.
[ ] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
[ ] I have developed this patch against the main branch.
[ ] I have run ./gradlew check.
[ ] I have added tests for my changes.
[ ] I have added documentation for the Reference Guide

Ready for review!


🚀 - InputPhoneInternational mask separator customisation

Description
Maskito provide an option to customise the phone mask separator (as seen here)

This is very useful because in France for example, we don't use - as a separator.
The lack of a way to change the separator in InputPhoneInternational leads to an incoherent display between the phone number displayed with MaskitoPipe (where I changed the separator) and within the input (where the separator is still -).

From what I've seen in the source code here, there is no options provided to change this separator in component InputPhoneInternational.
This could be resolved by adding an [separator] property on InputPhoneInternational, a provider to customise it, or both 😎
PS: Version 4.0 is amazing, keep up the great work 🔥

I will take it


Split cookies string w/ jest tests

Set-Cookie header returned by few frameworks is a one string of comma separated cookie strings.
This PR adds method to split this string into array of separate cookie strings.
Handles commas in parameters like expires.
e.g. string:
"cid=70125eaa-399a-41b2-b235-8a5092042dba; expires=Thu, 04-Jun-2020 12:17:56 GMT; Max-Age=63072000; Path=/, client_id=70125eaa-399a-41b2-b235-8a5092042dba; Max-Age=63072000; Path=/; expires=Thu, 04-Jun-2020 12:17:56 GMT"

to array:
[
"cid=70125eaa-399a-41b2-b235-8a5092042dba; expires=Thu, 04-Jun-2020 12:17:56 GMT; Max-Age=63072000; Path=/",
"client_id=70125eaa-399a-41b2-b235-8a5092042dba; Max-Age=63072000; Path=/; expires=Thu, 04-Jun-2020 12:17:56 GMT",
]

Maybe it will better fit to set-cookie-parser library?

I honestly think it should go to set-cookie-parser as it fits much better there.
I'm closing, react-native-cookies could use set-cookie-parser when needed.


python3Packages.batchgenerators: init at 0.19.7

python3Packages.threadpoolctl: init at 2.0.0

Motivation for this change
Add a package.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[NA] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@jonringer -- resolved, thanks.

@GrahamcOfBorg build python37Packages.batchgenerators python37Packages.threadpoolctl python38Packages.batchgenerators python38Packages.threadpoolctl

python38Packages.numexpr is timing on out Darwin.


Android: Choose folder when adding a new site

Add a folder chooser to add feed dialog. Also allow adding of folders.

I find the inability to assign feeds to folders - either when initially adding a feed or later when I want to change categorisation - is an unnecessary and frustrating limitation.

Happy to take this on if enough folks come forward in support to bump the priority up to critical/high.

Yes, we should be doing this. You should be able to select a folder when adding a feed. Just need a drop down, defaulting to the Top Level.

Good news - thanks Samuel.

Went much further and added full support for organising feeds into folders at any time in 4.6.0


Improve "Fail to merge schema" error messages

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

I am seeing this error:
ArrowError(SchemaError("Fail to merge schema Field due to conflicting datatype"))

It does not tell me which field has the issue or what the conflicting data types are.
Describe the solution you'd like

I would like the error to give me more information.
Describe alternatives you've considered

Additional context

I'll pick this up.

label_issue.py automatically added labels {'arrow'} from #3098


Add lifecycle hooks for MQTT

@BEagle1984 Can you have another look? I did all the refactorings we discussed.

@meggima, as discussed, I added the Configure method in the  IMqttProducerEndpointBuilder and IMqttConsumerEndpointbuilder. I think that you should offer the BindEvents as well, to allow for overwriting.
Example:
.AddMqttEndpoints(
    endpoints => endpoints
        .Configure(
            config => config
                .ConnectViaTcp("e2e-mqtt-broker")
                .UseProtocolVersion(MqttProtocolVersion.V311))
        .AddInbound(
            endpoint => endpoint
                .ConsumeFrom(DefaultTopicName)
                .Configure(config => config.WithClientId("client1"))
                .BindEvents(events => events.OnConnected(...client1Callback...))
                .DeserializeJson(
                    serializer => serializer
                        .UseFixedType<TestEventOne>()))
        .AddInbound(
            endpoint => endpoint
                .ConsumeFrom(DefaultTopicName)
                .Configure(config => config.WithClientId("client2"))
                .BindEvents(events => events.OnConnected(...client2Callback...))
                .DeserializeJson(
                    serializer => serializer
                        .UseFixedType<TestEventOne>())))

What do you think?

Done.

I would say this is OK. @meggima, if you are also happy with it you can merge it.

I think we can merge it. Actually, I can't do it myself (or I don't see the button to do so :wink:)


Security north toolbar layout is out

Height to big.
Tabs don't meet line
Back button is too far to the right

Okay, I'm not a designer, but how is the back button too far to the right? I actually like how it lines up with the item text. It just is slightly more clear than having it centered in the whitespace. Some testing... having it exactly centered looks weird ;)

FYI this is what it looks like in other areas.

I like it closer to the right actually.
What I dislike, is the "upload" icon on the save-button. That bothers me more ;)

Picking this one up now


Create a Dark Theme

From @adamdbradley on January 11, 2016 14:54
Ionic comes with a default theme, which is mainly a white background and black foreground:
https://github.com/driftyco/ionic2/blob/master/ionic/themes/default.scss
However, Ionic2's folder structure, Sass imports and variables have all been setup to allow other themes to be easily added, and allow end developers to choose which theme they want to start from. For example, an app could start with the dark theme, but they could still customize all the colors to fit their brand.
If anyone is looking to help create the dark theme we'd really appreciate the assistance. A lot of the work is just making sure all of the css and sass variables are in place to allow the entire app's theme to switch out, and allow many other themes to be easily created with minimal sass variable changes. If interested please let us know, thanks!
Copied from original issue: driftyco/ionic2#923

Yeah sorry, it did at one point. But as we were building our the sass files it got to be a pain to keep updating. But now that things are solidifying we can start building it out again.

From @alexbainbridge on January 12, 2016 0:20
I know you know this, but v2 docs suggests the dark theme already exists http://ionicframework.com/docs/v2/theming/theming-your-app/
I tried to use it then found it was docs only :)

From @jgw96 on January 13, 2016 18:53
@matheusrocha89 are you working on this? Id love to help if needed?

From @matheusrocha89 on January 12, 2016 11:6
I wanna help you guys with this :+1:

@matheusrocha89 Awesome thanks! I'll assign it to myself so for now so know it's being worked on. Any questions please let us know and we can help make sure the files are setup correctly. The new dark.scss file should go in here: https://github.com/driftyco/ionic2/tree/master/ionic/themes
Thanks!

Heads up, we JUST moved ionic2 to be in a different branch in the ionic repo: https://github.com/driftyco/ionic/tree/2.0

From @jgw96 on January 13, 2016 22:50
@adamdbradley yep saw that today. Are all these bugs moved over to the main repo too?

From @matheusrocha89 on January 13, 2016 20:59
@jgw96 I will start to do something today, I will create a branch. Any help it's welcome :+1:

From @jgw96 on January 13, 2016 22:50
@adamdbradley or are all the bugs still gonna be handled in this repo?

From @jgw96 on January 13, 2016 22:52
Got ya, is there gonna be an official set of contributing guidelines set up for v2?

Currently being moved over, we've got some work to do to clean up the process for creating and managing issues.

@adamdbradley, @jgw96 made a good point, is there any contributing guidelines?

there are several contributing guideline documents for ionic-related repos.
I usually follow the first link below to build and test changes:

https://github.com/driftyco/ionic/blob/2.0/scripts/README.md
https://github.com/driftyco/ionic/blob/af1bfef327e685585244c6051c4d38b98aa6c62a/CONTRIBUTING.md
http://ionicframework.com/contribute/#pull-request-guidelines
https://github.com/driftyco/ionic-conference-app/blob/2bd80de4874f3f363cf3717f0b986fb5aa85c727/CONTRIBUTING.md

for look and feel changes, perhaps should suggest contributors to build a demo page or update ionic-site repo as well ?

@jgw96 @3dd13 @matheusrocha89 Just checking in to see if there are any questions regarding this. Also, we have a slack channel for ionic2 development, if you're interested please email, adam at ionic io

Don't have any questions yet on my end, I plan on working on this tonight,
I'd love to be a part of that slack channel! Shooting you an email now.
On Jan 15, 2016 9:46 AM, "Adam Bradley"<EMAIL_ADDRESS>wrote:

@jgw96 https://github.com/jgw96 @3dd13 https://github.com/3dd13
@matheusrocha89 https://github.com/matheusrocha89 Just checking in to
see if there are any questions regarding this. Also, we have a slack
channel for ionic2 development, if you're interested please email, adam at
ionic io
—
Reply to this email directly or view it on GitHub
https://github.com/driftyco/ionic/issues/4967#issuecomment-171995904.

@adambradley is there any specific style guides that the dark theme should follow? Such as a specific color pallete? My thinking on this is that the $dark color in the normal theme should be the basis of the dark theme.

@adamdbradley If the slack is Ionic Worldwide I am already there :+1: Are you there too?

@adamdbradley I'm trying to create the dark theme and test the scss file in an example project to see how it's going on, but on the documentation it's says that I just need to import the "theme" on app.scss file and this file is importing ionic.scss but I can't find this app.scss file, I just found app.core.scss that it's not importing the ionic scss

@jgw96 Are you on Ionic Worldwide slack?

@adamdbradley I already create my dev enviroment to test the themes. I just have one question, do you have any idea of how do you want the dark theme? All dark, just toolbars dark? Or am I free to do whatever I want?

It should be the entire app, like these examples:

Also, the spotify app is a good example of a dark themed app:

For now you can guess some good colors to use, but we'll probably end up tweaking them a bit once @bensperry gets ahold of them. Any other questions please let me know, thanks

@adamdbradley :+1:

The links to the code are broken currently, but there is a searchable list of all of the Sass variables with their default values that may be helpful: http://ionicframework.com/docs/v2/theming/overriding-ionic-variables/
Subscribing to this issue to also answer any questions. :smile:

@brandyscarney I used this to run the ionic-site example https://github.com/driftyco/ionic/blob/2.0/scripts/README.md on my mac. Is there a way to force the v2 docs of ionic-site example to use the new theming that I am creating? I would like to edit my theme and see how it's looking with the docs examples

@matheusrocha89 We moved all of the demos to their own repo - https://github.com/driftyco/ionic-preview-app (I just made it public). So you could import the dark theme in this app and then run it just like a normal Ionic 2 app.

@matheusrocha89 I made some updates to the repo to make it easier to create new themes. If you get the latest from the 2.0 branch, I made a few changes to the theme structures, and added the dark theme scss files: https://github.com/driftyco/ionic/tree/2.0/ionic/themes
What I have there now is pretty much the same as the default theme, but with a black background and white text. If you can tweak the colors a bit to be more like the examples above that'd be great, but as it gets further along @bensperry well be helping to set the final the colors for the dark theme.
To view e2e with the dark theme:

gulp sass.themes
gulp watch
Default theme e2e tests: http://localhost:8000/dist/e2e/
Put ?theme=dark at the end of any e2e test to see it with the dark theme

When you make changes to the dark themes you'll have to run gulp sass.themes again to rebuild the e2e css files.
So the next steps are to come up with some good dark colors, then view each of the e2e tests and make sure each component can invert colors, and that there aren't any issues with components not styling correctly. Any questions please let us know. Thanks!

@matheusrocha89 Also, I'd prefer this is done in smaller steps, rather than one large PR. If you can break up changes to smaller commits and narrowed updating one component or color change that'd be great, and it'll be easier for us to merge in changes. Thanks

Looking nice!!

Ok, I will try, thanks @brandyscarney and @adamdbradley

@adamdbradley one last question, is there a way to use the md version on e2e too?

Either change the device with chrome's dev tools:

Or add this querystring ionicplatform=android

:+1:

@brandyscarney Hi, I created a version of the dark theme but I am having some problems with the chips component, because they don't have any variables to override and since they are dark the became almost invisible on dark theme. Do you have any idea of how we can find a solution for them?

@matheusrocha89 Hey, if you want to ignore the chip component for now I can work on adding some variables in this issue: https://github.com/driftyco/ionic/issues/5386 :smile:

"allow end developers to choose which theme they want to start from"
https://github.com/driftyco/ionic/issues/4967#issue-126730040
How is this accomplished (or what is the plan)?
(A starter-app currently loads ionic.ios.scss which loads components.ios which loads globals.ios which loads themes/default.ios...
Naive guess #1: somehow swap themes/default.ios for themes/dark.ios in the above chain even though you don't have ownership of those files?
Naive guess #2: themes/dark.ios by convention shadows all relevant parts of themes/default.ios and can be included directly by the app somehow? )

Importing themes/dark.ios before `'ionic.ios' from the app's scss does make things darker! (my instinct was to inport the theme as the last step, which does nothing)
app.ios.scss
@import 'themes/dark.ios';
@import 'ionic.ios';

the ability to switch themes programatically rather than just at build time would be great as then we could allow users to choose from a list of defined themes in app.

Can't tell for sure what is going on with this issue, since it seems it was never truly resolved.
Anyways...

There has been recent work on a dark theme by @pliablepixels here:
https://github.com/pliablepixels/ionic-dark-grey-theme

And then the other issue is: how can we have the ability to switch themes programmatically, as asked by @ghenry22?

@mg1075 Looks like some decent work on a dark theme there.
I do have a solution for programmatically switching themes which works perfectly, the only problem that I have to put it into production or share it is that I can't figure out how to adjust the ionic build process to run an extra step to compile and build the alternate css.
For example:
What I need to figure out is how to have a second copy of variables.scss (ie variables_dark.scss) which has the dark app theme selected and any specific colour overrides etc for the dark theme in it, where the default variables.scss has the default ionic light theme.
In the build process I want it to run the usual build against variables.scss, then run those tasks again against variables_dark.scss and generate a main_dark.css.
Then we have compiled and minified light theme (main.css) and dark theme (main_dark.css) and then we programmatically switch those out.
Sorry it can be hard to explain but basically if someone can help with how to add a custom build step as above so that automatic builds work properly then I will gladly share the rest of my solution for switching themes programmatically to pair up with it.

I did a bit of investigation on dynamic switching for my theme. I don't have an answer yet, just half-trodden paths with walls I need to scale. I  am also not sure if I'm diving in deeper than needed and if there is a better path to explore.
I looked at two options:
a) In variables.scss, scope your imports like this:
.dark_grey_theme { @import 'dark.scss' }

While this does scope the import and any classes defined in it correctly, it doesn't really solve the problem of ionic components using default colors for its components. My goal here was basically to have a dark_grey_theme and a default theme scoped import and wrap the app inside a div that I can dynamically toggle. However, this did not work due to reasons I stated above.
b) Get ionic build to compile multiple sass files and output them as 'main_dark.css' and 'main_default.css'. Ionic allows you to modify scripts with your custom scripts, which I got working, but couldn't figure out how to make the sass part invoke two different scripts with two prefixes. I used it to generate either dark or default, but not both
Maybe someone with more expertise here can comment on the right path to explore.


[core] Add the download tracker build script

Add a script to copy the source into the build folder (as required by convention).
Adapted from the mui-types package.

Thanks, I will merge, update the changelog and release.


Update when-should-you-upgrade-to-asp-net-core.md

not sure if you intended for that to say "is" or "is"

arg github formatted that. "is" italicized or with literal asterisks on either side

is as in italic was the intent. thanks


Bug: [reactdev tools][react native] Bridge was already shutdown. Inspection is broken

Try debugging in vanilla react native project.
Install reactdev-tools: npm i -D reactdev-tools
Start react native app in iOS or Android.
Start reactdev-tools
Enable debug mode.
Try to inspect element.
Observe that there's a warning Bridge was already shutdown.
The inspect mode doesn't connect to it.
Update:
Some how it connects, when devtools window is not in view. Then stop and start debug again.
Expected:
Inpection should connect to reactdev-tools instead of in app
reactdev-tools: 4.10.1
RN: 0.63.3
R: 16.13.1
Demo

I believe this is an issue with React Native's integration with DevTools so I've moved this issue to the React Naive repo.

I believe this is an issue with React Native's integration with DevTools so I've moved this issue to the React Naive repo.

I had the same issue and documented a workaround to get inspector working:
https://gist.github.com/sschottler/7771dc034d38b89d9d587dc5d358c386


Latest update - script editor now hangs when opening scripts

Hello,
Sorry I posted this in fiji/fiji but posting here as well because I'm not sure if this is Fiji or Imagej issue.
I'm using macOS Monterey 12.2.1, Oracle Java 8 update 321, and the no-jre Fiji.
The latest update brought in a script editor update.
Now, whenever I tried to open my .ijm scripts, it hangs the app. Please see the attached movie.
If I drag and drop to the Fiji window, it hangs every time.
If I open the script editor first, then open from "File - Open" it sometimes opens the script, and it sometimes hangs.
I can't think of a workaround for this right now, maybe I'll have to pause the updates with a fresh install.
Thank you.
Hyung-song Nam, PhD
https://user-images.githubusercontent.com/36607862/156863268-5e27d093-22fc-4323-8e1a-0af8031e0108.mov

Inappropriate forum. Also, issue fixed.
Closing this here.
HN


Implement a message queue system

Build using Rebus and most likely RabbitMQ or Postgres as backend

[x]  implement event types
[x]  implement event sender and receiver

Done! #8


Replace edit mode toggle with a simple user mouse click on the resource

There's an Edit mode in Bot Responses and User Input. However, the current design feels a little bit awkward -- the edit mode is up and above and very easy to miss.
How about just going into edit mode when a user clicks on a resource (see attached), and then stopping editing by clicking away from the editing space? This feels more intuitive than the extra clicks.

@mareekuh @sangwoohaan

Edit on click should allow the user to edit directly in the list view but not jump to the Editor.
@hibrenda


Resource generator

There should be a system for generating a resource. Generation of a resource creates two documents:

a resource definition file. this has validation, for instance.
an initial up/down migration

Eventually, there will also be resource editing. Editing a resource will possibly update the resource definition, and always generate a new migration file.

This is done in the first-work branch.


Reset Problem when Wifi is used

when i connect to the WiFi network the esp32 device resets after about 40 seconds.
But if I use APmode  it's fine
any ideas?

It is possible that the wifi router or the router is directing too much traffic to the ESP32 and it gets overloaded.  Or, there is an issue with multicast and the router.  On my home WiFi router, I cannot get multicast to work while the same code and hardware works fine on another network.  I haven't been able to track it down.  But, it is possible it is something like that where the ESP32 spends too long waiting and blocking on something and that overruns the WDT (which causes the ESP32 to reboot).  I'd try with another type of WiFi router to see if it is specific to one network or happens on both.


importing pyethereum messes up with standard logging

Standard, expected behavior:

import logging
logger = logging.getLogger('test')
logging.basicConfig(level=logging.DEBUG)
logger.debug('hi')
DEBUG:test:hi

Now I do the same, but I import pyethereum before:

import logging
from ethereum import vm
logger = logging.getLogger('test')
logging.basicConfig(level=logging.DEBUG)
logger.debug('hi')

Nothing is printed.
That's an unexpected side effect (and pretty hard to debug when I depended on pyethereum very indirectly).
Can you only do that kind of change where pyethereum is used directly as a standalone executable, but not when it's imported?
(also, what' the purpose of having a custom "slogging" module? that's unclear to me)
Thanks,
palkeo.

0xdf873A85923Af285E3de0676c678abF07F756260


What is the difference between MolScore and DockStream?

Thank you for your repo. Your opinion is highly appreciated.

Thanks for the question. Firstly I've not tried DockStream yet so my opinion is based on my current understanding, which may not be completely correct.
There is quite some overlap between functionality. For example,

DockStream can prepare ligands using rdkit, tautenum, ligprep, corina, openeye. While MolScore has code for rdkit+epik, ligprep, openeye omega, moka+corina and gypsum_dl. Currently, their code is more modular, while mine is specific to different docking protocols (e.g., gypsum_dl + smina).  However, separating ligand preparation for modularity is on my to-do list.
DockStream can dock ligands using rDock, Openeye Hybrid, Glide, Gold, AutoDock Vina. While MolScore only has code for Openeye Fred (untested due to lack of license), Glide and Smina (fork of Vina).

Key differences:

DockStream in itself has automated scripts for retrospective analysis of protocol performance.
DockStream includes protein preparation, while MolScore does not and leaves this to the user, which in my opinion is important. (Although DockStream doesn't automatically prepare proteins for Glide, so in that case, they're the same).
It seems DockStream is parallelised using python multiprocessing (use cores from running machine/node) whereas I use Dask (which can use cores across different compute machines/nodes).

Conceptual differences:

DockStream seems like an additional scoring component to reinvent, which is deeply integrated with reinvent. While MolScore is a scoring component manager designed to be flexible, customisable and to be used with any generative model requiring scoring (not just reinvent). Including score transformations and combinations for multi-parameter optimization.
MolScore also focuses on gathering all generated molecules in a data frame for downstream analysis using MolEval. This also enables other benefits such as not re-running duplicated molecules that have been scored previously (especially when scoring is expensive such as docking). Such that comparison between scoring configurations / generative models has also been at the forefront of my design.
I've written both an older dash monitor and newer streamlit monitor to monitor generative model progress 'live', which comes in very handy and has some nice functionality (I think more than tensorboard). Such as browsing generated compounds and being able to also view docked poses.
I've written a streamlit user interface for writing the configuration file (.json file). I think this is useful as it lists and describes all the options possible for the different settings. This is done by automatically parsing the code and code documentation, therefore if a user adds their own component properly annotated, it will automatically be added to the configuration file.

Other than the listed differences, there is of course the matter of fact that I've not published a software paper yet, I currently use MolScore more than I develop it, unfortunately. As for writing a publication I've got at least 2 other pieces of work to write up first.

Thank you so much for the detailed explanation. I think the combination of different generative models and docking packages is very important. There are so many generative models, but we can't say which one is the best for every problem. The docking packages are the same. So, the freedom of choosing the different combinations and collecting all the results together is very important. I am looking forward to your new update soon. Thank you again for your great work.


memfd: Some minor follow-ups

This is a follow-up of some minor nits that weren't worth blocking the original PR on, but seemed like nice-to-haves upon re-review.

Re: pooling allocator on-by-default, I wonder if we should evaluate the default limits at the same time? IIRC, for example, a build of SpiderMonkey/WASI doesn't fit within the defaults; when testing with the pooling allocator I've had to bump the limits. One advantage of the on-demand allocator is that since it does a heap allocation just once, for just the right amount of VMContext space, it doesn't need to be as careful; while the pooling allocator can easily mmap significant amounts of memory for instances if it makes too-conservative assumptions.
(Perhaps a way around that is for the pooling allocator defaults to allow for very large instances -- as high as, say, what a typical browser would have for implementation-defined limits -- but only one instance slot?)

That makes sense to me, but to clarify the pooling allocator is already enabled by default, this shouldn't change that. I do think it's reasonable to up the limits though (or measure the impact of malloc-ing the VMContext instead of mmap-ing it to avoid the need for most limits)

That makes sense to me, but to clarify the pooling allocator is already enabled by default, this shouldn't change that

Even for wasmtime-cli though? I was referring to your third commit, which I think changes this -- that's the part I'd worry about potentially surprising someone who's using wasmtime to run big modules from the commandline...

Oh I see it's in a somewhat inconsistent state right now I think. The pooling allocator is enabled on the wasmtime crate unconditionally but the top-level feature is disabled by default. In any case I think that it's best to defer the limits question to later, AFAIK this is mostly just used for our own internal testing right now since there's not really much purpose for using the pooling allocator on the CLI anyway. It should be pretty easy to tweak the limits in the future if necessary.


add sub_path option to volume_mounts

What this PR does / why we need it:
When kubeflow users using cluster builder in an air-gapped environment, users may want to add specific configuration for their build environment(kaniko executor pod). If there's internal python repository inside of air-gapped environment, users should add extra pip.conf file under /etc path using volume_mounts resource mutator.
Currently there's no sub_path option for volume_mounts and this results replacing whole folder contents of /etc to one pip.conf file. So, this PR add sub_path option to volume_mounts to support mount a file to existing path.
If user omits sub_path option then it'll behave as-is since default value of sub_path is None. So, this PR doesn't break backward compatibility.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #None
Special notes for your reviewer:
Release note:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ Googlers: Go here for more info.

@googlebot I signed it!

/ok-to-test
Thanks for your contribution @Minkyu-Choi

/lgtm
/approve
@Minkyu-Choi Thanks!


feat: adds a new method for requesting exercise permissions

Changes

Adds a new method for requesting route data of a particular exercise session record following the guide from Android docs.
Modifies requestPermission to accept an optional flag that indicates requested permissions should include write-route permission. Removed the unused providerPackageName arg from the method as well.
Updates the example app to include a button for inserting a random exercise session with routes and another button that requests the route of the given exercise id.

Issues
#34

Should solve #86, #127, #128 @matinzd. Whipped up in a rush, happy to address comments.

Will look into this further this weekend

@matinzd Any chance you could take a look at this? I patched our own app and syncing worked as expected. It also touches a few other things that we don't use necessarily so a review would be much appreciated 🙏

Hey @ugurakin1
Can you please rebase your branch?

Done @matinzd

Hey @matinzd , any updates on this/eta?
Also, did you want me to just update so there aren't any conflicts or did you actually want me to rebase instead?

Hey!
I am gonna try to release it this weekend. It doesn't matter, I don't want to see any conflicts.

Let me know if you need anything from me @matinzd, happy to land a hand 👍

Massive thanks @matinzd 🙏


connection lost

Hi, I have seen that some other people had the same problem as this can't connect to the world. Got a "Connection Lost" message directly after "Loading Terrain" message shows up. and that the solution is it needs to be on the same version as the launcher but I do not understand how to do that and how or find where are the different versions are.
could you help?

pls help!

Are you playing on a server or on singleplayer?
Are you using any data packs?
Could you share a log from your client?

I am on a server and I am not using a data pack but how do I share a log

?

Since your playing on the server, this is very likely the version issue. Ask your server owner which Origins version they are using. Then make sure to install exactly that version on your client. You can find all of the Origins versions on this page: https://www.curseforge.com/minecraft/mc-mods/origins/files
For more help, please visit the Discord server, because you'll get more immediate help there.


deleteUsers is not working

Hi,
Was trying for hours to delete users from a Cloud Function using the Auto API, without success.
I am using deleteUsers API from admin:
  admin.auth().listUsers(1000, nextPageToken).then(function(listUsersResult) {
                            listUsersResult.users.forEach(function(userRecord) {
                              var userID = userRecord.toJSON().uid;
                              usersToDelete.push(userID);
                            });
                            return;
                      }).then(() => {
                       console.log(usersToDelete.length);
                       return admin.auth().deleteUsers(usersToDelete);
                      }).catch(function(error) {
                                  console.log('Error listing users:', error);
                      });

This will list all users but keep showing error when deleting :
TypeError: admin.auth(...).deleteUsers is not a function
Why is the deleteUsers not working ?

TypeError: admin.auth(...).deleteUsers is not a function

You're using an old version of the SDK that doesn't have this function. You will have to upgrade.

No i don't, you don't know what version i use to be so sure.
Also, ListUsers works and they came out together.

No i don't, you don't know what version i use to be so sure.

The error makes it pretty obvious. The version your're using simply doesn't have that method.

Also, ListUsers works and they came out together.

No they didn't. ListUsers was released in v5.3.0. DeleteUsers was released in v8.12.0. Here are the historical release notes: https://firebase.google.com/support/release-notes/admin/node


Couldn't get lyrics [Windows 10]

I have JetBrains Toolbox installed too but I don't know why it is related.

Before this I application did not open at all after install. I checked Event Viewer and found out that I needed admin privileges. I re-run installer as admin and applicatin now starts but gives this error thingy.
CoreCLR Version: 4.700.20.26901
.NET Core Version: 3.1.6
Description: The process was terminated due to an unhandled exception.
Exception Info: System.Configuration.ConfigurationErrorsException: An error occurred loading a configuration file: Access to the path 'C:\Program Files (x86)\SwagLyricsGUI\nmoexge3.tmp' is denied. (C:\Program Files (x86)\SwagLyricsGUI\SwagLyricsGUI.dll.config)
 ---> System.UnauthorizedAccessException: Access to the path 'C:\Program Files (x86)\SwagLyricsGUI\nmoexge3.tmp' is denied.
   at System.IO.FileStream.ValidateFileHandle(SafeFileHandle fileHandle)
   at System.IO.FileStream.CreateFileOpenHandle(FileMode mode, FileShare share, FileOptions options)
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options)
   at System.IO.Internal.TempFileCollection.EnsureTempNameCreated()
   at System.IO.Internal.TempFileCollection.get_BasePath()
   at System.IO.Internal.TempFileCollection.AddExtension(String fileExtension, Boolean keepFile)
   at System.IO.Internal.TempFileCollection.AddExtension(String fileExtension)
   at System.Configuration.Internal.WriteFileContext..ctor(String filename, String templateFilename)
   at System.Configuration.Internal.InternalConfigHost.StaticOpenStreamForWrite(String streamName, String templateStreamName, Object& writeContext)
   at System.Configuration.Internal.InternalConfigHost.System.Configuration.Internal.IInternalConfigHost.OpenStreamForWrite(String streamName, String templateStreamName, Object& writeContext)
   at System.Configuration.ClientConfigurationHost.OpenStreamForWrite(String streamName, String templateStreamName, Object& writeContext)
   at System.Configuration.UpdateConfigHost.OpenStreamForWrite(String streamName, String templateStreamName, Object& writeContext)
   at System.Configuration.Internal.DelegatingConfigHost.OpenStreamForWrite(String streamName, String templateStreamName, Object& writeContext)
   at System.Configuration.MgmtConfigurationRecord.SaveAs(String filename, ConfigurationSaveMode saveMode, Boolean forceUpdateAll)
   --- End of inner exception stack trace ---
   at System.Configuration.MgmtConfigurationRecord.SaveAs(String filename, ConfigurationSaveMode saveMode, Boolean forceUpdateAll)
   at System.Configuration.Configuration.SaveAsImpl(String filename, ConfigurationSaveMode saveMode, Boolean forceSaveAll)
   at System.Configuration.Configuration.Save()
   at SwagLyricsGUI.ViewModels.MainWindowViewModel.set_ThemeIndex(Int32 value)
   at SwagLyricsGUI.ViewModels.MainWindowViewModel..ctor()
   at SwagLyricsGUI.App.OnFrameworkInitializationCompleted()
   at Avalonia.Controls.AppBuilderBase`1.Setup()
   at Avalonia.Controls.AppBuilderBase`1.SetupWithLifetime(IApplicationLifetime lifetime)
   at Avalonia.ClassicDesktopStyleApplicationLifetimeExtensions.StartWithClassicDesktopLifetime[T](T builder, String[] args, ShutdownMode shutdownMode)
   at SwagLyricsGUI.Program.Main(String[] args)

Windows 10 OS Build 19041.630

Interesting thing is if I close Jetbrains Toolbox it works and stops working when I open back.

@flabbet what do you think this could be? SwSpotify mistaking Jetbrains Toolbox window title to be a Spotify title?

Should I move issue to SwSpotify?

Should I move issue to SwSpotify?

I'll move it once we know what's up with the admin issue. The Jetbrains part is more suitable there


NixOS remote deployment w/ sudoer

Find out how to do a remote Flake deployment with a sudoer instead of root.
I tried it with the dev VM, using admin as a user but got an error message saying Nix couldn't run sudo. To reproduce, start the dev VM
$ qemu-system-x86_64 \
    -machine q35,vmport=off -cpu host -smp 2 -m 4G -accel hvf \
    -display none \
    -nic user,hostfwd=tcp::10022-:22 \
    devm.img.qcow2

run our Nix shell and cd into nix/nodes/devm. Then run
$ export NIX_SSHOPTS='-p 10022'
$ nixos-rebuild switch --fast --flake .#devm \
    --target-host admin@localhost --build-host admin@localhost \
    --use-remote-sudo

# Enter the VM's admin password when prompted—unless you changed the
# default config, the password is `abc123`.

It doesn't look like you can do it out of the box, at least not w/ passwords. Read this

https://discourse.nixos.org/t/nixos-rebuild-remote-target-with-non-root-user/


Memory not released when layer is removed or even on exit

🐛 Bug Report
Allocated memory is not reliably released when deleting layers or even on napari exit.
The layers I'm using contain multi-GB 4D image data.
💡 Steps to Reproduce
The simplest way to achieve this is:

start napari 0.4.18 from python console: "import napari; napari.Viewer(); napari.run()"
open large 4D data from TIF, allocated memory according to Windows task manager rises (in my case to 10.8GB)
exit napari using "File -> Exit"
memory remains allocated, only released when quit() in python console

The same happens when I remove the layer using the backspace or delete key or using the Trash icon before exiting. Loading (smaller) new data after deleting the old (large) one sometimes results in reported lower memory usage, but this is not reliable. I could not find any pattern yet.
💡 Expected Behavior
Memory should be freed when the layer disappears from the list and is not displayed any more.
While I do not really care about what happens at exit it should be possible to repeatedly:

acquire data and display it,
store it,
delete the layer,
start acquire again etc.

🌎 Environment
napari: 0.4.18
Platform: Windows-10-10.0.19045-SP0
Python: 3.10.11 (tags/v3.10.11:7d4cc5a, Apr 5 2023, 00:38:17) [MSC v.1929 64 bit (AMD64)]
Qt: 5.15.2
PyQt5: 5.15.9
NumPy: 1.25.2
SciPy: 1.11.1
Dask: 2023.7.1
VisPy: 0.12.2
magicgui: 0.7.2
superqt: unknown
in-n-out: 0.1.8
app-model: 0.2.0
npe2: 0.7.2
OpenGL:

GL version: 4.6.0 NVIDIA 536.23
MAX_TEXTURE_SIZE: 32768

Screens:

screen 1: resolution 1920x1080, scale 2.0

Settings path:

C:\Users\rixius\AppData\Local\napari\Python310_8d589e5d511b34f09eb70b6f194cf7f7589b669d\settings.yaml

💡 Additional Context
I'm aware of several issues posted (#2155, #2027) relating to memory leaks, and a lot of work regarding this problem. I still posted this description as I'm not sure about the current status.

Thanks for making the issue. It reminds me of some observations and discussion on zulip:
https://napari.zulipchat.com/#narrow/stream/212875-general/topic/GL_MAX_TEXTURE.20sizes/near/404907356

Explicitely calling the garbage collector gc.collect() before acquiring new data solves the problem. So far I did not see memory that is not freed when calling the GC. This probably also means that there is no lost reference or other actual bug.
Still it seems strange to me that Python keeps GBs of memory seemingly "forever". This is not a very cooperative behaviour for a multi-tasking environment. Maybe the GC is explicitely switched off? Maybe breaking a cyclic reference in "remove layer" would improve the behaviour?
NOTE: The amount of free memory reported is important in my case as new data comes from a digitizer card. Acquisition will fail if not enough memory is available and I need to warn the user if this is known in advance.

The problem with GC is that it is optimized for creating and releasing a bunch of small objects.
As GC call is expensive, python waits with call it on many changes of memory allocation happens. But it do not work well in scientific software, where we allocate and make free big chunks of data. Maybe the best solution for your use case is to either reuse the same data address (if you got the same shape of data) or explicitly call gc.collect() with the cost of little lags.


Can't exit to home menu

When existing to home menu, it hangs and needs a hard reset. Latest nightly, self compiled.

Doesn't seem to occur with the latest source.