splitting kafka/zk, turn to use bitnami images

This starts using bitnami/kafka and bitnami/zookeeper for msg broker.
Deploy them as separated services/deployments

@sebgoa Env key is updated following your comment.
So, after a nightmare last night and this morning diving into this setup, I am not be able to recreate the success case I've had before. I completely get loss on understanding the kafka-zookeeper setup in k8s. Maybe my minikube environment has something wrong so I strongly propose to double check it on your k8s environment. Here are what I found in conclusion:

kafka/zk setup works perfectly in docker-compose environment. This is the docker-compose.yml file https://gist.github.com/ngtuna/561efab1c72e9341a8ec6742ac2f3416
The main cause I believe is kafka container in the k8s pod can't reach itself via the service name kafka.kubeless. This leads to all kinds of error messages we are having on these days. The log file /opt/bitnami/kafka/logs/controller.log constantly showing

[2017-05-16 05:13:36,846] WARN [Controller-1001-to-broker-1001-send-thread], Controller 1001's connection to broker kafka.kubeless:9092 (id: 1001 rack: null) was unsuccessful (kafka.controller.RequestSendThread)
java.net.SocketTimeoutException: Failed to connect within 30000 ms
	at kafka.controller.RequestSendThread.brokerReady(ControllerChannelManager.scala:231)
	at kafka.controller.RequestSendThread.liftedTree1$1(ControllerChannelManager.scala:182)
	at kafka.controller.RequestSendThread.doWork(ControllerChannelManager.scala:181)
	at kafka.utils.ShutdownableThread.run(ShutdownableThread.scala:63)
[2017-05-16 05:14:06,975] WARN [Controller-1001-to-broker-1001-send-thread], Controller 1001's connection to broker kafka.kubeless:9092 (id: 1001 rack: null) was unsuccessful (kafka.controller.RequestSendThread)
java.net.SocketTimeoutException: Failed to connect within 30000 ms
	at kafka.controller.RequestSendThread.brokerReady(ControllerChannelManager.scala:231)
	at kafka.controller.RequestSendThread.liftedTree1$1(ControllerChannelManager.scala:182)
	at kafka.controller.RequestSendThread.doWork(ControllerChannelManager.scala:181)
	at kafka.utils.ShutdownableThread.run(ShutdownableThread.scala:63)
[2017-05-16 05:14:37,087] WARN [Controller-1001-to-broker-1001-send-thread], Controller 1001's connection to broker kafka.kubeless:9092 (id: 1001 rack: null) was unsuccessful (kafka.controller.RequestSendThread)
java.net.SocketTimeoutException: Failed to connect within 30000 ms
	at kafka.controller.RequestSendThread.brokerReady(ControllerChannelManager.scala:231)
	at kafka.controller.RequestSendThread.liftedTree1$1(ControllerChannelManager.scala:182)
	at kafka.controller.RequestSendThread.doWork(ControllerChannelManager.scala:181)
	at kafka.utils.ShutdownableThread.run(ShutdownableThread.scala:63)
[2017-05-16 05:15:07,219] WARN [Controller-1001-to-broker-1001-send-thread], Controller 1001's connection to broker kafka.kubeless:9092 (id: 1001 rack: null) was unsuccessful (kafka.controller.RequestSendThread)
java.net.SocketTimeoutException: Failed to connect within 30000 ms
	at kafka.controller.RequestSendThread.brokerReady(ControllerChannelManager.scala:231)
	at kafka.controller.RequestSendThread.liftedTree1$1(ControllerChannelManager.scala:182)
	at kafka.controller.RequestSendThread.doWork(ControllerChannelManager.scala:181)
	at kafka.utils.ShutdownableThread.run(ShutdownableThread.scala:63)

I strongly believe tackling this point correctly will solve the problem. The main reason we are splitting kafka and zookeeper deployment is because we would like to have them communicate via name rather than localhost or ipaddress. I checked in docker environment, we can reach kafka itself via its hostname but k8s seems doesn't allow this because of design principle I think.
WDYT ?
cc/ @anguslees @jbianquetti-nami

The problems seem to be related to Minikube KubeDNS name resolution.
This PR has been tested on GKE and it worked like a charm.

So what we have now:
@jbianquetti-nami confirm this PR worked on GKE
I confirm this PR worked on minikube v0.14.0 but failed on minikube v0.19.0
The last thing would probably figure out why it failed on the latest minikube but at least we can now be a bit more confident with this setup :-)

I guess we are waiting for the new kafka/zk manifests before modifying this ?

@sebgoa I am waiting for the new manifests from @jbianquetti-nami then I will add a follow-up commit to deploy them from kubeless install. Then this PR will be good for merging I hope :-)


Use vector icons for nearby-map markers #621

As described in the issue #621, replacing pngs like this:

With this svg:
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<svg
   xmlns:dc="http://purl.org/dc/elements/1.1/"
   xmlns:cc="http://creativecommons.org/ns#"
   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
   xmlns:svg="http://www.w3.org/2000/svg"
   xmlns="http://www.w3.org/2000/svg"
   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"
   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"
   height="28"
   viewBox="0 0 24 28"
   width="24"
   version="1.1"
   id="svg3839"
   sodipodi:docname="custom_marker_akaita.svg"
   style="fill:#000000"
   inkscape:version="0.92.1 r">
  <metadata
     id="metadata3845">
    <rdf:RDF>
      <cc:Work
         rdf:about="">
        <dc:format>image/svg+xml</dc:format>
        <dc:type
           rdf:resource="http://purl.org/dc/dcmitype/StillImage" />
        <dc:title></dc:title>
      </cc:Work>
    </rdf:RDF>
  </metadata>
  <defs
     id="defs3843" />
  <sodipodi:namedview
     pagecolor="#ffffff"
     bordercolor="#666666"
     borderopacity="1"
     objecttolerance="10"
     gridtolerance="10"
     guidetolerance="10"
     inkscape:pageopacity="0"
     inkscape:pageshadow="2"
     inkscape:window-width="1680"
     inkscape:window-height="925"
     id="namedview3841"
     showgrid="true"
     inkscape:zoom="24.375"
     inkscape:cx="5.1897436"
     inkscape:cy="14.875286"
     inkscape:window-x="0"
     inkscape:window-y="23"
     inkscape:window-maximized="0"
     inkscape:current-layer="svg3839"
     showguides="false">
    <inkscape:grid
       type="xygrid"
       id="grid3904" />
  </sodipodi:namedview>
  <ellipse
     style="fill:#000000;fill-opacity:0.06666667;stroke-width:1.37026358"
     id="path3899"
     cx="12.102563"
     cy="22.428205"
     rx="6.0307693"
     ry="3.6717949" />
  <path
     d="m 12,2.3769234 c -3.8699996,0 -6.9999996,3.13 -6.9999996,7 C 5.0000004,14.626923 12,22.376923 12,22.376923 c 0,0 7,-7.75 7,-12.9999996 0,-3.87 -3.13,-7 -7,-7 z m 0,9.4999996 c -1.38,0 -2.4999996,-1.12 -2.4999996,-2.4999996 0,-1.38 1.1199996,-2.5 2.4999996,-2.5 1.38,0 2.5,1.12 2.5,2.5 0,1.3799996 -1.12,2.4999996 -2.5,2.4999996 z"
     id="path3835"
     inkscape:connector-curvature="0" />
  <path
     d="M 0,4 H 24 V 28 H 0 Z"
     id="path3837"
     inkscape:connector-curvature="0"
     style="fill:none" />
  <path
     style="fill:#f84d4d;fill-opacity:1;stroke-width:0.04102564"
     d="M 11.575408,11.825361 C 10.688745,11.666747 9.9023831,10.964562 9.6248346,10.08359 9.5527876,9.8549054 9.5351956,9.7044904 9.5384636,9.3451284 c 0.00361,-0.396913 0.019229,-0.491787 0.1296458,-0.787492 0.2355178,-0.630736 0.6458016,-1.098647 1.2116146,-1.381792 0.386227,-0.193277 0.708521,-0.271742 1.116173,-0.271742 0.676431,0 1.262546,0.246849 1.7436,0.734337 0.354734,0.359479 0.541139,0.681663 0.657408,1.136269 0.32693,1.2782826 -0.441524,2.6108316 -1.722787,2.9874286 -0.281992,0.08289 -0.816778,0.113659 -1.09871,0.06322 z"
     id="path3849"
     inkscape:connector-curvature="0" />
  <path
     style="fill:#006699;fill-opacity:1;stroke:#003b59;stroke-width:1;stroke-miterlimit:4;stroke-dasharray:none;stroke-opacity:1"
     d="M 11.616794,21.911674 C 10.518479,20.62925 9.3375979,19.068762 8.3952457,17.654529 6.5241437,14.846476 5.4546019,12.509947 5.1020419,10.460171 5.014133,9.9490711 5.0064946,8.8329764 5.0875486,8.3424774 5.3480263,6.7661894 6.0432736,5.4266055 7.1582617,4.3526805 9.1483483,2.4358857 12.016137,1.8727748 14.59345,2.8927283 c 2.043205,0.808584 3.606586,2.5813031 4.161658,4.7189081 0.174081,0.670391 0.204374,0.932573 0.20343,1.760678 -9.22e-4,0.8100256 -0.03496,1.0975936 -0.21977,1.8566086 -0.61444,2.523538 -2.571462,5.977389 -5.383242,9.500614 -0.645397,0.808696 -1.321301,1.610028 -1.358021,1.610028 -0.0078,0 -0.179158,-0.192551 -0.380711,-0.427891 z m 1.000543,-10.103061 c 0.78285,-0.188213 1.457153,-0.795278 1.737658,-1.564386 0.516156,-1.4152346 -0.316651,-2.9618196 -1.783469,-3.3120326 -0.216428,-0.05167 -0.31719,-0.05889 -0.661455,-0.04738 -0.35432,0.01185 -0.441293,0.02512 -0.681724,0.103976 -0.673464,0.220894 -1.205333,0.695479 -1.5059061,1.343717 -0.1763343,0.380295 -0.2182632,0.584137 -0.2168632,1.054307 9.661e-4,0.323935 0.013916,0.452389 0.063992,0.6346746 0.2664071,0.969774 1.0768523,1.68863 2.0794153,1.844418 0.243193,0.03779 0.680462,0.01192 0.968352,-0.0573 z"
     id="path3859"
     inkscape:connector-curvature="0" />
</svg>

Which looks like this:

Drawer before the change (Nexus 5x)
Drawer after the change  (Nexus 5x)

This looks good to me, but I will ping @neslihanturan for input first.

@neslihanturan I am hoping to merge this soon, if no issues from your end.

It looks very nice, sorry for delay of mine. I think we should carry all of our png's to svg in near future.

At this stage, unfortunately I never really know if that indicates an issue with the test, with the PR, or with Travis (Travis has given us a lot of false negatives). Regardless, I will restart the build and hopefully we'll find out!

@neslihanturan great!
@misaochan the tests in Travis seem to fail because some Lint rules like RtlHardcoded are being run as fatal rules... not sure why.
The codacy rules... well it complains about the format of the javadoc, because the first line is /**...  I don't really agree with codacy :)

@whym , what do you think is the issue with the tests? The error messages seem rather vague to me.
Thanks for your patience @akaita ?

Regarding the codacy results, please try adding a period after "Draws a vectorial image onto a bitmap". (It says "First sentence of Javadoc is incomplete (period is missing) or not present.")
Regarding tests, I have commented in line.

Oh, my bad. I admit I didn't run the tests. I didn't change any method, so I assumed it would be fine... :(
Also fixed the codacy issue. Thanks for clearing that up for me @whym !

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@44d294e). Click here to learn what that means.
The diff coverage is 75%.

@@           Coverage Diff            @@
##             master    #786   +/-   ##
========================================
  Coverage          ?   6.75%
========================================
  Files             ?     100
  Lines             ?    5151
  Branches          ?     468
========================================
  Hits              ?     348
  Misses            ?    4776
  Partials          ?      27

Impacted Files
Coverage Δ

...a/fr/free/nrw/commons/nearby/NearbyController.java
25% <60%> (ø)

...c/main/java/fr/free/nrw/commons/utils/UiUtils.java
85.71% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44d294e...1ddf8be. Read the comment docs.


MNT: Update pinned versions.

Hi! This is the friendly conda-forge-admin automated user.
I've bumped some of the conda-forge pinned versions, and noticed that it impacts this feedstock.
If the changes look good, then please go ahead and merge this PR.
If you have any questions about the changes though, please feel free to ping the 'conda-forge/core' team (using the @ notation in a comment).
Thanks!

Please re-render with conda-smithy before merging this PR.

@jakirkham, I have to do re-render the feedstock in this PR or in a different one?

It can be a new PR.

Please re-render with conda-smithy before merging this PR.

Done. So now do I need to merge master with this PR and then merge it?

Nope. Can just merge this one.


update graalvm/native-image and port to arm64

[x] - updated graalvm
[x] - ported to arm64
[ ] - automate release

To update status here: all the releases are released for macOS/arm64, but they are manually built on my computer. Will try to get a GitHub action set up


Question: how to use prepare statement appropriately

Thanks @JoshuaWise for the awesome library. This may be a silly question, how to use prepare statements?
option 1, calling prepare many times
function getStuffById(id) {
  /* so some validation thing with id */
  return db.prepare('select * from someTable where id = ?').get(id)
}

// then
getStuffById(1);
getStuffById(2); // a moment later
getStuffById(3); // some more moment later

option 2, calling prepare once
const statement = db.prepare('select * from someTable where id = ?')
function getStuffById(id) {
  /* so some validation thing with id */
  return statement.get(id)
}

// then
getStuffById(1);
getStuffById(2); // a moment later
getStuffById(3); // some more moment later

Both options work fine, but the second option has better performance because you're only compiling the SQL string once.


Remove labels

User description
Sorry, we do not accept changes directly against this repository. Please see
CONTRIBUTING.md for information on where and how to contribute instead.

Type
Enhancement

Description

Added a new file labels.go that contains a map of labels that should be ignored and a function to check if a label is in the ignore list.
Modified the networkpolicy.go file to include a call to the removeLabels function, which removes ignored labels from the PodSelector in both generateEgressRule and generateIngressRule functions. The removeLabels function was also added, which removes labels from a given map if they are in the ignore list.
Updated the networkpolicy_test.go file to include ignored labels in the test cases for the TestGenerateNetworkPolicy function.

Changes walkthrough
Relevant files                                                                                Enhancement

labels.go

        pkg/apis/softwarecomposition/networkpolicy/labels.go
This file was added to the project. It contains a map of labels that should be ignored and a function isIgnoredLabel to check if a label is in the ignore list.

 +29/-0

networkpolicy.go

        pkg/apis/softwarecomposition/networkpolicy/networkpolicy.go
This file was modified to include a call to the removeLabels function, which removes ignored labels from the PodSelector in both generateEgressRule and generateIngressRule functions. The removeLabels function was also added, which removes labels from a given map if they are in the ignore list.

 +11/-0

Tests

networkpolicy_test.go

        pkg/apis/softwarecomposition/networkpolicy/networkpolicy_test.go
This file was modified to include ignored labels in the test cases for the TestGenerateNetworkPolicy function.

 +10/-4

 ✨ Usage guide:
Overview:
The describe tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.
When commenting, to edit configurations related to the describe tool (pr_description section), use the following template:
/describe --pr_description.some_config1=... --pr_description.some_config2=...

With a configuration file, use the following template:
[pr_description]
some_config1=...
some_config2=...

  Enabling\disabling automation

When you first install the app, the default mode for the describe tool is:

pr_commands = ["/describe --pr_description.add_original_user_description=true"
                         "--pr_description.keep_original_user_title=true", ...]

meaning the describe tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description.

Markers are an alternative way to control the generated description, to give maximal control to the user. If you set:

pr_commands = ["/describe --pr_description.use_description_markers=true", ...]

the tool will replace every marker of the form pr_agent:marker_name in the PR description with the relevant content, where marker_name is one of the following:

type: the PR type.
summary: the PR summary.
walkthrough: the PR walkthrough.

Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.

  Custom labels
The default labels of the describe tool are quite generic: [Bug fix, Tests, Enhancement, Documentation, Other].
If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases.
Examples for custom labels:

Main topic:performance - pr_agent:The main topic of this PR is performance
New endpoint - pr_agent:A new endpoint was added in this PR
SQL query - pr_agent:A new SQL query was added in this PR
Dockerfile changes - pr_agent:The PR contains changes in the Dockerfile
...

The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases.
Note that Labels are not mutually exclusive, so you can add multiple label categories.
Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.

  Utilizing extra instructions
The describe tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description.
Examples for extra instructions:
[pr_description]
extra_instructions="""
- The PR title should be in the format: '<PR type>: <title>'
- The title should be short and concise (up to 10 words)
- ...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the describe usage page for a comprehensive guide on using this tool.

@dwertent have you seen this https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/


support using cupy wheels as a dependency

This PR depends on https://github.com/cupy/cupy/pull/899.
Support CuPy wheels as a dependency.

LGTM, @okuta do you think it is okay to merge?

OK. But, does CuPy provides 4 packages?
    'cupy-cuda90',
    'cupy-cuda80',
    'cupy-cuda75',
    'cupy-cuda70',

CUDA support of other wheels:

TensorFlow: 9.0 only (was 8.0, but upgraded in recent release)
PyTorch: 8.0/9.0/9.1
CNTK: 8.0 only (but seems to upgrade to 9.0 in next release)
MXNet: 7.5/8.0/9.0/9.1

After offline discussion with @okuta san, we decided NOT to provide wheels for CUDA 7.x.

CUDA 7.0 / 7.5 was released in 2015 and is outdated.
Users of CUDA 7.0 / 7.5 can still install CuPy via source.

We will provide CUDA 8.0 wheel for Ubuntu 14.04 users, as CUDA 9.0 drops support for it.

jenkins, test this please.

@kmaehashi Could you check the CI failure?

jenkins, test this please.

jenkins, test this please.

@kmaehashi Sorry for the delay but could you resolve the conflict?

Resolved!

jenkins, test this please.

jenkins, test this please.

jenkins, test this please.

LGTM!


JSON notifications contain empty body

Describe the bug
A clear and concise description of what the bug is.
Version
Exact version in the top right area: 0....
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

! ALWAYS INCLUDE AN EXAMPLE URL WHERE IT IS POSSIBLE TO RE-CREATE THE ISSUE - USE THE 'SHARE WATCH' FEATURE AND PASTE IN THE SHARE-LINK!
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

not enough information

not enough information

It posted the issue before I was able to add content, I have now updated the description.


New Feature: ShowNext Command

ShowNext command shows the next up coming events.
If a number is provided to the command, the next xx number (as provided) of events will be shown.
ShowNext command uses the keyword "next".
Checkstyles checks are passed locally.
Testing is done only for parsing of the command.
No test cases for the handling of the command (need to consider how to create the test case when the outcome is time-dependent).
Closes Issue #26 and #72.

New sets of commits:
Moved the listener (added previously) to a different part of the code.
Added logic for getting UI to get upcoming events.
Code contribute towards #71.


Ensure that repos that do not need to sign in the VMR (e.g. arcade) have empty ItemsToSign lists

Some repositories don't require signing in VMR builds. Repos that we know do not contribute any artifacts that will be redisted by shipping packages in other components should have their ItemsToSign lists emptied.
I think arcade may be the only case of this.
This does not require any of the rest of the signing work to be complete.

T-Shirt Size: XS

I think arcade might be the only one as well. Looking through the repos defined in the source-manifest.json, I don't see any other repos that would fit this requirement: https://github.com/dotnet/dotnet/blob/main/src/source-manifest.json


Hotkey to minimise to system tray

Is your feature request related to a problem? Please describe.
I'm an ex-Franz user. Love Ferdi! The main thing I miss being able to ctrl-w to minimise to the system tray.
There is no explicit menu entry to do this, and so it relies on users knowing that they can click "x" or the system tray icon
I'd love to have a way of doing this again without the mouse.
Describe the solution you'd like
Add a menu item + hotkey to minimise Ferdi (ctrl-w). Franz puts these under the Window submenu, it seems sensible to add it there (and potentially remove the "open todos drawer", which is a duplicate of the "todos" menu).
As an added bonus, it'd be lovely to have a global hotkey to pull up Ferdi again, but I do appreciate that this would be a little more involved.
Describe alternatives you've considered

Using my mouse and sucking it up: can live with it but not ideal.
Switching back to Franz itself:  na
Windows Key + Down: Actually has the same effect (intended?), but I don't think it's obvious, and don't know what the equivalent is on mac.

@vantezzen - Hi mate,
Let me just add, it used to work on previous version (there are old issues open here which have reference to it on Mac, it also exists on the Windows client.
I noticed that during the start up process of Fredi, you have a couple of seconds where Ctrl+W Does minimize the app,
But after that, both the option from the "File menu" and the shortcut stops working.
tl;dr - definitely a bug mate. Would really appreciate if it could be fixed, otherwise i'll need to see if an older version is good enough to be used (Compared to Franz\Rambox - this shortcut is built in, in both apps)

This irritates me daily. Command-W is the universal "close tab or window" shortcut on macOS, and it's a pain to have to grab for the mouse every time I'm done IM'ing...

This irritates me daily. Command-W is the universal "close tab or window" shortcut on macOS, and it's a pain to have to grab for the mouse every time I'm done IM'ing...

@vraravam Looks like this has already been implemented and the issue can be closed.

Thanks @stnkl - I knew Cmd+M worked for all apps on macos - but, I wasn't aware whether it worked in other OSes. Thanks for confirming. We can close this ticket now!

@all-contributors - please add @stnkl for bug


Fixed some region highlighting bugs

This patch rewrites the region highlighting stuff. in editorRefreshScreen(), we now call editorIsRegionActive() to tell if we should color this area.

clean af <3


add centerHorizontally option

Codecov Report

Merging #71 into master will decrease coverage by 1.2%.
The diff coverage is 50%.

@@            Coverage Diff            @@
##           master     #71      +/-   ##
=========================================
- Coverage    97.4%   96.2%   -1.21%
=========================================
  Files           2       2
  Lines          77      79       +2
=========================================
+ Hits           75      76       +1
- Misses          2       3       +1

Impacted Files
Coverage Δ

lib/generator.js
97.18% <50%> (-1.37%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc144a7...d687f1c. Read the comment docs.


Dynamic Image URL not possible while looping through an object

Vue.js version
2.0.2
Reproduction Link

See the fiddle here -> https://jsfiddle.net/99hrw6uj/
What is Expected?
We use a system where the users picture is automatically displayed in a restful format: /user/pic/:id, but with vuejs, displaying the users picture is tedious and I would rather not try a hacky work around.
What is actually happening?
The following error is thrown:
VM992 vue.js:2601[Vue warn]: src="https://placehold.it/160x160/000000/ffffff?text={{person.name}}": Interpolation inside attributes has been deprecated. Use v-bind or the colon shorthand instead.

Any suggestions would be helpful! Thanks!

https://vuejs.org/v2/guide/migration.html#Interpolation-within-Attributes-removed


Update sbt-mima-plugin to 0.9.1

Updates com.typesafe:sbt-mima-plugin from 0.9.0 to 0.9.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.typesafe", artifactId = "sbt-mima-plugin" } ]

labels: sbt-plugin-update, semver-patch

Codecov Report

Merging #148 (dc616e6) into master (d0e58a5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #148   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            6         6
  Lines           84        84
  Branches         3         2    -1
=========================================
  Hits            84        84

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0e58a5...dc616e6. Read the comment docs.


Sync Public to Private

I have a public github repo that I want to sync to my own private repo so my embarrassing code is not public.
What is the best way to make this happen? I initially "imported" the target upstream repo which worked, then set up the sync script; however, I kept getting errors related to unrelated histories.
I followed the steps and added --allow-unrelated-histories which worked but now every time the script runs it shows a merge operation even if no files have been changed. I am not adding any new files at this point, I will create a fork off the private branch to make code changes then merge them back in.
Is there a command or flag to force the script to pull down the upstream branch the first time it runs as a fork so the histories are common?
Steps to repeat:

Find target upstream branch for example "https://github.com/ccxt/ccxt/"
Create private repo called "ccxt" on your account
Run the fork-sync-with-upstream-action script. Fails with unrelated histories.
Try adding --allow-unrelated-histories script runs but then shows a merge event every time the script runs regardless of if there are changes/new commits or not.

I am likely doing something wrong so any advice you have would be much appreciated.

Okay yeah, I see it always thinks there are new commits in this situation. That's not great, especially with such a large history to traverse. I suspect what's happening is that after the first sync from upstream, a merge commit is created whose hash is not the same as the last commit hash you synced from upstream. That last commit hash is what the action uses to check if it needs to try and pull new stuff, and it's a pretty naive implementation.
I think what's needed to fix it is --

Store the last synced commit hash from upstream
On sync run, compare the upstream branch head hash with the stored hash (not the target branch head)
Update the stored commit hash if there was a sync

I'm really hoping that's all that's required, but I'm also wondering if that extra merge commit will complicate pulling in new changes. Not sure, I'll have to try it out.

Good news - I do have a fix that checks for new commits a bit more intelligently.
Bad news - I'm not sure it really solves your problem.
I was lucky enough that some new commits were made to ccxt, and I ran the action again to see if it would correctly check for new commits (it did). Since there were new commits this time, it tried to merge new stuff again. Unfortunately, there were merge conflicts that I was unable to resolve automatically as well as a rejection pushing from a shallow clone. I wonder if you'll have similar issues.
You're welcome to try the changes in your workflow -- uses: aormsby/Fork-Sync-With-Upstream-action@merge-check-fix
If that doesn't work, I'm not sure what else to try at the moment. Will have to think on it.

UPDATE: I made a much better fix in the branch check-fix-2 (PR linked above). Works for me based on your notes. I would like for you to try this out on both the fresh ccxt 'fork' and then after you run with success to check for early exit. Should be good this time.

Thank you! I will give this a go and let you know. Excellent support and work on this project!

#38 merged, released as v3.2


Firewall: Button not rendered correctly with non-unicode charset

This may not a problem because we should use UTF-8 whenever possible, but while testing my firewall/firewall6 rework I noticed that buttons are displayed different when using en and en.UTF-8 language, same happen with de and de.UTF-8.
en.UTF-8:

en:

suprising is also that sometimes the first Add rule button is green, sometimes the last one

That is interesting how could this be possible indeed. I will take a look for the cause.

It's not because of non-unicode/unicode. You can reload the page multiple times and see different result each time.
It's the other issue that can't be solved really at the moment.


add support to new api 4.0.0

Please add support to new api 4.0.0

ye

Please add support to new api 4.0.0

10 January 2022 will support API 4.0.0


EmrEtlRunner: remove checks for existing data

We have to remove this otherwise when we try to resume from e.g. archive_raw, we can get a return code of 4 and message:
There seems to be an ongoing run of EmrEtlRunner: Cannot safely add enrichment step to jobflow, s3n://my-bucket/enriched/good/ is not empty

Updated ticket name

Closing


stm32f7:sdmmc invalidate before and after DMA

Summary
Impact
Testing

https://github.com/apache/incubator-nuttx/pull/5062


fix: search empty after delete test

closes #1288
This test was failing because we couldn't process .delete("true").

FYI I plan to fix this eventually. https://github.com/lancedb/lance/issues/1074


State transitions (EST, VST) should fail if one tx is invalid

Describe the bug
The validity of a block must also check if its nullifiers are unique. The current rules are:

None of the nullifiers exists in the nullifiers set before the block
All the ZK proof passes

We need to include

The nullifiers set of a given block can't contain duplicated items

If we have duplicated nullifiers, we might waste CPU cycles with transactions that can't have the gas paid.
To Reproduce
Example: Tx1_nullifier -> A, Tx2_nullifier -> B, Tx3_nullifier -> A
Tx1 is executed, and pays the gas with A
Tx2 is executed, and pays the gas with B
Tx3 fails, and can't pay the gas with A because its already spent.

Issue moved to dusk-network/rusk #704 via ZenHub


chore(deps): allow support for angular 1.4.0

Seems to work fine in 1.4.0 (master) !

Thanks ! :)

np!


Volume should be an int.

See this comment.
Connects to mapzen/vector-datasource#212.
@rmarianski could you review, please?

:+1:


logs in with ibm v1 sso and protects a page called /stats

Gave the code a quick scan. Looks good to me!


Convert indentation from smart tabs to 4-space

I've been a fan of smart tabs (tabs for indentation, spaces for alignment) and persevered with it through many years, but have to admit that I regret this choice now and 4 spaces provide a much less painful experience for both maintainers and contributors. I now use 4 spaces in all my other projects (smooth sailing), and it would be great to convert Leaflet as well eventually.
These are the big problems I see with smart tabs:

they're very hard to enforce on the linting level; there are all sorts of edge cases and the approach is not used often enough to drive fixing related issues and bringing related features on projects like ESLint
most contributors are unfamiliar with the approach so I have to write "please fix whitespace" comments in PRs over and over again; it will get easier with https://github.com/Leaflet/Leaflet/commit/301473ad4d83ec14254464e2f598e9827a904927 but that's still a hack
all-spaces indentation is much better supported in editors unlike mixed tabs and spaces, which is more hassle to write
smart tabs bring complexity to whitespace management; all-spaces are barebones simple

These are the issues that prevent me from doing a repo-wide conversion:

it'll bork all the open PRs (authors will have to painfully rebase and solve lots of conflicts); does anyone know a solution to this? I know there's at least an option to ignore whitespace when showing diffs, but is there an easy way to merge code with different whitespace in git?
it'll screw git blame so that you'll have to run it again on commits before the conversion, but I guess that's a necessary evil

Should we go ahead with this and deal with consequences, or just leave this alone and continue to deal with whitespace annoyances?
cc @IvanSanchez @yohanboniface @danzel @jfirebaugh

I'd support this and think the 1.0 is the good opportunity to do so. Will be painful, but necessary for a long term view imho.

Apparently it is possible to rewrite history and replace all tabs with spaces without borking blame, by using https://git-scm.com/docs/git-filter-branch and a sed replacement.

@IvanSanchez nah, that's just too scary — it would change all commit refs and break everything for sure. Not an option.

WARNING! The rewritten history will have different object names for all the objects and will not converge with the original branch. You will not be able to easily push and distribute the rewritten branch on top of the original branch. Please do not use this command if you do not know the full implications, and avoid using it anyway,

Breaking blame is gonna suck, but it is easy to work around when necessary.
Any PRs can be redone if they are worthwhile.
You could do the commit from another account just for this (leaflet-whitespace-rewrite) to make it super obvious in the history.
This could be the final commit for 1.0? :)

About white spaces only modification, git blame doc says:
-w
    Ignore whitespace when comparing the parent’s version and the child’s to find where the lines came from.

Not sure this apply to Github blame pages, though.

What's so difficult to enforce? I've never had an issue.
Keeping tabs and spaces separated by printing/non-whitespace characters is as easy to check as /\t\x20/.

Regarding the drawback for blame there is git blame --ignore-rev/--ignore-revs-file which is also supported by github when given the correct filename


feat: add optimize command

Description

Integrate asyncapi/optimizer as asyncapi optimize command.

Related issue(s)
Fixes #218 , to be merged after https://github.com/asyncapi/optimizer/pull/129

@derberg @Souvikns a review would be appreciated 🙏

@derberg @Souvikns another round of 👁 🙏

I think you should resolve the conflict first, it will dismiss the review later.

@KhudaDad414 the tests are red

@derberg the tests are red all over this repo. As you can see in the commit history, I have bashed my head against the wall tooooo many times over these failing tests and achieved nothing. 😆

@KhudaDad414 please update to latest master, there are some conflicts

@derberg I think it is ready.

@KhudaDad414 relax, zen, and all that stuff..... conflicts again....so changes in docs in readme. You need to pull latest and move info about new command to respective markdown file in docs directory 😄

/rtm


Client: Load and execute SQL script

A :load command in the client would be nice:
:load script.sql

This would load the file script.sql and execute all queries in the file. But not too important.

#85, except for parsing specific path


Update sql-server-backup-to-url-best-practices-and-troubleshooting.md

added common issues and solutions

@WilliamDAssafMSFT
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

closing for https://github.com/MicrosoftDocs/sql-docs-pr/pull/27782


how do I down volume?

I could play audio by using dgvoice.PlayAudioFile() but it is too big volume.
How do I down the volume played by bot?

Well, you should adjust the volume on your client's speakers.  You can adjust the volume from within Discord too. But there's no way with this library to adjust the volume.


Implement the main toolbar

For #7240
Modify the main toolbar to match the spec

Restart
Interrupt
Add new
Run All
Save
Save as Python blue button

Codecov Report

Merging #7301 into master will decrease coverage by 0.36%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##           master    #7301      +/-   ##
==========================================
- Coverage   58.34%   57.98%   -0.37%
==========================================
  Files         493      493
  Lines       21661    21667       +6
  Branches     3486     3481       -5
==========================================
- Hits        12639    12563      -76
- Misses       8242     8326      +84
+ Partials      780      778       -2

Impacted Files
Coverage Δ

src/client/telemetry/index.ts
86.13% <ø> (ø)
:arrow_up:

src/datascience-ui/interactive-common/mainState.ts
0% <ø> (ø)
:arrow_up:

.../datascience/interactive-common/interactiveBase.ts
6.41% <0%> (ø)
:arrow_up:

src/client/datascience/constants.ts
100% <100%> (ø)
:arrow_up:

src/client/common/utils/localize.ts
93.84% <100%> (+0.09%)
:arrow_up:

src/client/testing/serviceRegistry.ts
48.64% <0%> (-46.85%)
:arrow_down:

src/client/testing/codeLenses/main.ts
44.44% <0%> (-33.34%)
:arrow_down:

...t/datascience/jupyter/jupyterDataRateLimitError.ts
66.66% <0%> (-33.34%)
:arrow_down:

src/client/formatters/serviceRegistry.ts
75% <0%> (-25%)
:arrow_down:

src/client/api.ts
62.5% <0%> (-25%)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c21f6fc...f6b080b. Read the comment docs.

Codecov Report

Merging #7301 into master will decrease coverage by 0.36%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##           master    #7301      +/-   ##
==========================================
- Coverage   58.34%   57.98%   -0.37%
==========================================
  Files         493      493
  Lines       21661    21667       +6
  Branches     3486     3481       -5
==========================================
- Hits        12639    12563      -76
- Misses       8242     8326      +84
+ Partials      780      778       -2

Impacted Files
Coverage Δ

src/client/telemetry/index.ts
86.13% <ø> (ø)
:arrow_up:

src/datascience-ui/interactive-common/mainState.ts
0% <ø> (ø)
:arrow_up:

.../datascience/interactive-common/interactiveBase.ts
6.41% <0%> (ø)
:arrow_up:

src/client/datascience/constants.ts
100% <100%> (ø)
:arrow_up:

src/client/common/utils/localize.ts
93.84% <100%> (+0.09%)
:arrow_up:

src/client/testing/serviceRegistry.ts
48.64% <0%> (-46.85%)
:arrow_down:

src/client/testing/codeLenses/main.ts
44.44% <0%> (-33.34%)
:arrow_down:

...t/datascience/jupyter/jupyterDataRateLimitError.ts
66.66% <0%> (-33.34%)
:arrow_down:

src/client/formatters/serviceRegistry.ts
75% <0%> (-25%)
:arrow_down:

src/client/api.ts
62.5% <0%> (-25%)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c21f6fc...f6b080b. Read the comment docs.

Codecov Report

Merging #7301 into master will decrease coverage by 0.36%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##           master    #7301      +/-   ##
==========================================
- Coverage   58.34%   57.98%   -0.37%
==========================================
  Files         493      493
  Lines       21661    21667       +6
  Branches     3486     3481       -5
==========================================
- Hits        12639    12563      -76
- Misses       8242     8326      +84
+ Partials      780      778       -2

Impacted Files
Coverage Δ

src/client/telemetry/index.ts
86.13% <ø> (ø)
:arrow_up:

src/datascience-ui/interactive-common/mainState.ts
0% <ø> (ø)
:arrow_up:

.../datascience/interactive-common/interactiveBase.ts
6.41% <0%> (ø)
:arrow_up:

src/client/datascience/constants.ts
100% <100%> (ø)
:arrow_up:

src/client/common/utils/localize.ts
93.84% <100%> (+0.09%)
:arrow_up:

src/client/testing/serviceRegistry.ts
48.64% <0%> (-46.85%)
:arrow_down:

src/client/testing/codeLenses/main.ts
44.44% <0%> (-33.34%)
:arrow_down:

...t/datascience/jupyter/jupyterDataRateLimitError.ts
66.66% <0%> (-33.34%)
:arrow_down:

src/client/formatters/serviceRegistry.ts
75% <0%> (-25%)
:arrow_down:

src/client/api.ts
62.5% <0%> (-25%)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c21f6fc...f6b080b. Read the comment docs.

Codecov Report

Merging #7301 into master will decrease coverage by 0.36%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##           master    #7301      +/-   ##
==========================================
- Coverage   58.34%   57.98%   -0.37%
==========================================
  Files         493      493
  Lines       21661    21667       +6
  Branches     3486     3481       -5
==========================================
- Hits        12639    12563      -76
- Misses       8242     8326      +84
+ Partials      780      778       -2

Impacted Files
Coverage Δ

src/client/telemetry/index.ts
86.13% <ø> (ø)
:arrow_up:

src/datascience-ui/interactive-common/mainState.ts
0% <ø> (ø)
:arrow_up:

.../datascience/interactive-common/interactiveBase.ts
6.41% <0%> (ø)
:arrow_up:

src/client/datascience/constants.ts
100% <100%> (ø)
:arrow_up:

src/client/common/utils/localize.ts
93.84% <100%> (+0.09%)
:arrow_up:

src/client/testing/serviceRegistry.ts
48.64% <0%> (-46.85%)
:arrow_down:

src/client/testing/codeLenses/main.ts
44.44% <0%> (-33.34%)
:arrow_down:

...t/datascience/jupyter/jupyterDataRateLimitError.ts
66.66% <0%> (-33.34%)
:arrow_down:

src/client/formatters/serviceRegistry.ts
75% <0%> (-25%)
:arrow_down:

src/client/api.ts
62.5% <0%> (-25%)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c21f6fc...f6b080b. Read the comment docs.

Codecov Report

Merging #7301 into master will decrease coverage by 0.36%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##           master    #7301      +/-   ##
==========================================
- Coverage   58.34%   57.98%   -0.37%
==========================================
  Files         493      493
  Lines       21661    21667       +6
  Branches     3486     3481       -5
==========================================
- Hits        12639    12563      -76
- Misses       8242     8326      +84
+ Partials      780      778       -2

Impacted Files
Coverage Δ

src/client/telemetry/index.ts
86.13% <ø> (ø)
:arrow_up:

src/datascience-ui/interactive-common/mainState.ts
0% <ø> (ø)
:arrow_up:

.../datascience/interactive-common/interactiveBase.ts
6.41% <0%> (ø)
:arrow_up:

src/client/datascience/constants.ts
100% <100%> (ø)
:arrow_up:

src/client/common/utils/localize.ts
93.84% <100%> (+0.09%)
:arrow_up:

src/client/testing/serviceRegistry.ts
48.64% <0%> (-46.85%)
:arrow_down:

src/client/testing/codeLenses/main.ts
44.44% <0%> (-33.34%)
:arrow_down:

...t/datascience/jupyter/jupyterDataRateLimitError.ts
66.66% <0%> (-33.34%)
:arrow_down:

src/client/formatters/serviceRegistry.ts
75% <0%> (-25%)
:arrow_down:

src/client/api.ts
62.5% <0%> (-25%)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c21f6fc...f6b080b. Read the comment docs.

"DataScience.exportAsPythonFileTooltip" is different on 'localize.ts' and on 'package.nls.json'

the nls file trumps the localize.ts, but I should make them match. will do.


Resolve nested properties correctly DAT-7294

Environment
Liquibase Version:
Liquibase Integration & Version: <Pick one: CLI, maven, gradle, spring boot, servlet, etc.>
Liquibase Extension(s) & Version:
Database Vendor & Version:
Operating System Type & Version:
Pull Request Type

[ ] Bug fix (non-breaking change which fixes an issue.)
[ ] Enhancement/New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
A clear and concise description of the issue being addressed.  Additional guidance here.

Describe the actual problematic behavior.
Ensure private information is redacted.

Steps To Reproduce
List the steps to reproduce the behavior.

Please be precise and ensure private information is redacted
Include things like

Files used - sql scripts, changelog file(s), property file(s), config files, POM Files
Exact commands used - CLI, maven, gradle, spring boot, servlet, etc.

Actual Behavior
A clear and concise description of what happens in the software before this pull request.

Include console output if relevant
Include log files if available.

Expected/Desired Behavior
A clear and concise description of what happens in the software after this pull request.
Screenshots (if appropriate)
If applicable, add screenshots to help explain your problem.
Additional Context
Add any other context about the problem here.
Fast Track PR Acceptance Checklist:

[ ] Build is successful and all new and existing tests pass
[ ] Added Unit Test(s)
[ ] Added Integration Test(s)
[ ] Added Test Harness Test(s)
[ ] Documentation Updated

Need Help?
Come chat with us on our discord channel

It would be worth doing some testing both in yaml and XML of the setting of properties and making sure once they are set they can't be changed.
Like running with both -DtestProperty=X and <property name="testProperty" value="Y"> and making sure an echo or something changeSet with testProperty comes through as "X".
Also make sure to test global vs. not and that logic continues to work as expected/as before


kernel: enable CONFIG_RTC_SYSTOHC

The system time (wall clock) will be stored in the RTC specified by RTC_HCTOSYS_DEVICE approximately every 11 minutes if userspace reports synchronized NTP status.

@peti @edolstra
So, should this be merged or closed?

Let's just close it ...


feat: add svgr support

Close #6

I tried this fix, but it doesnt seem to work. Does it work for you?

@vviikk unfortunately it's still not working by adding the loader, not sure why exactly..

:/ There's two outstanding issues for me before I propose this to the team. SVGR and the new JSX transpiler that removed the import React from 'react' mandatory line. Let me give this a go later as well to see where it's breaking.


New version: ByteDance.JianyingPro version <IP_ADDRESS>62

Pull request has been created with WinGet Automation :rocket:
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Internet translation suggests: "We are very sorry, but the professional version of Clip Screen does not currently support your system version. Please update to the latest 64-bit operating system before running!" (Feel free to correct if wrong.)
This message seems to suggest that Windows 11 is a minimum OS for this package. To enable this, should this package have a MinimumOSVersion of 10.0.22000.000 or above?

Manifest Error: Schema Error. [Schema validation failed.
Error context: [Installers][0][MinimumOSVersion] Description: Failed to match regex specified by 'pattern' constraint.
Error context: [Installers][0] Description: Failed to validate against schema associated with property name 'MinimumOSVersion'.
Error context: [Installers] Description: Failed to validate item #0 in array.
Error context:  Description: Failed to validate against schema associated with property name 'Installers'. ] File: ByteDance.JianyingPro.installer.yaml

https://github.com/vedantmgoyal2009/vedantmgoyal2009/issues/1395


X-Forwarded-For support

It looks like Clickhouse does not support X-Forwarded-For HTTP header to detect client IP address when Clickhouse is behind a reverse proxy.
I've installed Clickhouse, its HTTP port is 8123.
For test user, only access from certain IP is allowed (let's say it's <IP_ADDRESS>).
I'm using nginx as a reverse proxy with the following config:
server {
    listen 80;
    server_name clickhouse.mydomain;
    resolver <IP_ADDRESS>;

    proxy_redirect          off;
    proxy_set_header        Host            $host;
    proxy_set_header        X-Real-IP       $remote_addr;
    proxy_set_header        X-Forwarded-For $proxy_add_x_forwarded_for;

    location / {
        proxy_pass http://localhost:8123/;
    }
}

Then I try to run a query using curl.
curl 'http://clickhouse.mydomain/?user=test&password=pass&query=select * from aaa.bbb'
Code: 195, e.displayText() = DB::Exception: User test is not allowed to connect from address <IP_ADDRESS>, e.what() = DB::Exception
But when I do the same directly (using port 8123), it works fine:
curl 'http://clickhouse.mydomain:8123/?user=test&password=&query=select * from aaa.bbb'
The response is
123
1234
which is expected.
So it looks like in the first case when nginx is used as a reverse proxy, Clickhouse does not pick up the X-Forwarded-For header value when determining the IP address.
Is it possible to have this feature? Is there a workaround?

I've used a simple echo server https://gist.github.com/solusipse/6419144 to make sure X-Forwarded-For is actually passed. For the following request
curl http://clickhouse.mydomain/aaa
I got the following:
GET /aaa HTTP/1.0
Host: clickhouse.mydomain
X-Real-IP: <my.ip>
X-Forwarded-For: <my.ip>
Connection: close
User-Agent: curl/7.47.0
Accept: /

X-Forwarded-For probably can be added to some stats, but using it for use authentication sounds  highly unsafe.
If Clickhouse will start to trust X-Forwarded-For header (which can be easily added to any request), it will give a lot of options to abuse that.
So for example you will connect from every ip, and will add X-Forwarded-For: <IP_ADDRESS> to make ClickHouse think that this request is from localhost.
For me it sounds like you need to just allow to connect to clickhouse from your reverse proxy ip, and limit the ips which can connect to proxy (inside proxy configuration) to get desired effect.

Let's see how it looks case by case.

Someone makes a request from outside and that request goes through a reverse proxy, the reverse proxy will not let the existing X-Forwarded-For header through and instead it will replace it with a valid header. This case is ok.
Someone makes a request from outside, but that request reaches Clickhouse directly, then there is a danger that the request will smuggle its X-Forwarded-For header. In such a case, Clickhouse should only trust to IPs from a white list (IPs that are known to be reverse proxy IPs). By default, this list could contain just '<IP_ADDRESS>' (and ::1). When an attacker from outside tries to smuggle his X-Forwarded-For, his real IP will be different from any whitelisted address, so X-Forwarded-For will be ignored.
Someone who is already at reverse proxy host (usually, it's the same host where Clickhouse resides) makes a request and tries to fool the authentication. Here I can't invent anything. But the attacker is already inside the perimeter...

Wouldn't it possible to add this feature, but disable it by default, and add a clarification in the documentation which would state the risks?

For me it sounds like you need to just allow to connect to clickhouse from your reverse proxy ip, and limit the ips which can connect to proxy (inside proxy configuration) to get desired effect.

It seems that this would reduce the flexibility of access control. I would like to have two users to only be able to connect from 2 IPs, one for each. Would it be possible?

It seems that this would reduce the flexibility of access control. I would like to have two users to only be able to connect from 2 IPs, one for each. Would it be possible?

Of course. If you will use Basic HTTP Authentication then you have a lot of configuration options.
For example for Apache:
AuthType Basic
AuthUserFile /www/.site_htpasswd
AuthName "Protected Area"

<RequireAny>
    Require ip <IP_ADDRESS>
    Require valid-user
</RequireAny>

Also, please take a look on that project https://github.com/Vertamedia/chproxy
It's a HTTP-proxy created especially for ClickHouse, it has a lot of ClickHouse-specific features and introduce few improvements in ClickHouse HTTP support.

Thank you! I'll take a look at it


Allow for basic or bearer auth for prometheus /api/metrics endpoint

Since #2903, Prometheus can no longer authenticate to scrape the /api/metrics endpoint. Prometheus does not support adding cookies to scraping endpoints, so we cannot provide a cookie for Prometheus to use. I am marking this as a 'bug' as this currently means that metrics don't work in versions deployed from master (e.g testnet setup).
Possible solutions:

Allow for basic auth to this endpoint again. I have taken a look locally at this but I realise it may be unwanted/controversial. I believe that the motivation for #2903 was mostly user experience, so in this case it shouldn't matter as this only touches how the automation works, but perhaps there are other considerations here.
Modify rocket-cookie-auth to be able to take a session token in some format through an Authorization: Bearer header. We would also need to have a way to generate a bearer token for Prometheus to use, and ensure that it would always be up to date.

Another (maybe temporary) solution would be to just remove the authentication from the metrics endpoint. It's not that the data is that sensitive.

Another (maybe temporary) solution would be to just remove the authentication from the metrics endpoint. It's not that the data is that sensitive.

temporary fix: https://github.com/itchysats/itchysats/pull/3002

Thanks!
Is there any preference on whether basic with password or bearer with token would be preferred for a longer term solution?

IMHO I would go for basic auth - as we already have an implementation and bearer tokens do not bring any additional value - since we would need to create one with a long period of validity or otherwise update the token regularly.
We should though make sure we are sending basic auth credentials only over an ssl encrypted connection.

Just to clarify, have we decided to leave /metrics unauthenticated and recommend that the /metrics endpoint is only exposed locally and not to the public internet?

Just to clarify, have we decided to leave /metrics unauthenticated and recommend that the /metrics endpoint is only exposed locally and not to the public internet?

We did a temporary patch to make sure things still work; if there's a nice way to authenticate it it would still be good.
Another way to deal with this would be disabling it by default (after all, no-one except us needs this).

This project is unmaintained


latest Zanata translation changes in uberfire-extensions from 2016-09-03

+1 to merge.

this PR is identical with PR #295 and can be closed


DF Scene Enhancements: Player's scene tab does not populate

Module
DF Scene Enhancements 3.5.0
Describe the issue
With the "Enable Scene Tab for Players" setting enabled, players can open the scene tab but it remains unpopulated.  This happens while they have navigable scenes via the top scene menu.
Foundry 9.242
DnD5e 1.5.6

Can confirm issue.

I noticed having DF Scene Enhancements causes Sidebar, Chat and Window Resizer to through a LibWrapperPackageError:
Error= 'SceneDirectory.defaultOptions' cannot be wrapped, the corresponding descriptor has 'configurable=false'
The name stuck out to me and I would venture a guess that these issues are related.  I'm posting this here just in case it helps in the debug process.   Also when enabling/disable the player nav option, I get this error in the console.

This is *not* a libWrapper bug.

Find information about this module here: https://github.com/flamewave000/dragonflagon-fvtt/tree/master/df-scene-enhance
Report this issue here: https://github.com/flamewave000/dragonflagon-fvtt/issues

== Technical Details:
Detected by libWrapper.
Package ID= df-scene-enhance
Error= A wrapper for 'SceneDirectory.prototype._onClickDocumentName' (ID=134) has already been registered by module df-scene-enhance.

[Detected 1 package: df-scene-enhance]
    at Function.🎁register [as register] (libWrapper-api.js:539)
    at Function.patchSceneDirectoryClick (df-scene-nav.ts:18)
    at Object.onChange (df-scene-nav.ts:111)
    at Setting._onUpdate (foundry.js:18103)
    at ClientDatabaseBackend.callback (foundry.js:10260)
    at foundry.js:10212
    at Array.map (<anonymous>)
    at ClientDatabaseBackend._handleUpdateDocuments (foundry.js:10212)
    at ClientDatabaseBackend._updateDocuments (foundry.js:10093)
    at async Function.updateDocuments (document.mjs:373)
    at async Setting.update (document.mjs:456)
    at async ClientSettings.set (foundry.js:2202)
    at async ExtendedSettingsConfig._updateObject (foundry.js:55538)
    at async ExtendedSettingsConfig._onSubmit (foundry.js:3853)
_onSubmit @ foundry.js:3856
async function (async)
_onSubmit @ foundry.js:3853```


pub dropped from all pub const and pub static

I am using master, last commit is 8a9bbd (it address const and static, can it be the cause of the regression?).
The following test
pub mod t2 {
    pub const CPUB:i64 = 3;
    const CNPUB:f32 = 3.0;

    pub fn do_nothing() -> bool {
      true
    }
}

pub static OTHER: &'static str = "Nothing";

fn main() {
    println!("{}", OTHER);
    //println!("pub: {}, nonpub: {}", t2::CPUB, t2::CNPUB);
    //this raises error: const `CNPUB` is private
}
```
becomes
```{rust}
pub mod t2 {
    const CPUB: i64 = 3;
    const CNPUB: f32 = 3.0;

    pub fn do_nothing() -> bool {
        true
    }
}

static OTHER: &'static str = "Nothing";

fn main() {
    println!("{}", OTHER);
    //println!("pub: {}, nonpub: {}", t2::CPUB, t2::CNPUB);
    // raises error: const `CNPUB` is private
}
```

All the `const` and `static` are now private! ~It's probably worth to introduce a test for this.~

This affected thousands of lines trying to re-run rustfmt on rusts `src/liblibc`.

EDIT: @marcusklaas with `d326a29` the bug is not present, it seems to be introduced by commit `1a7d390`. The test is there but the keyword is dropped as well.

Woa, I can't believe I did that. My bad!


Failed to load template: directives/toast/toast.html (HTTP status: 404 Not Found)

It used to work fine but now I get an error when showing a toast:
Failed to load template: directives/toast/toast.html (HTTP status: 404 Not Found)
I also can't find this file in the bower components folder. I already reinstalled the library with bower, but that didn't make a difference.

Never mind. If I include the tpls.js file it works. I overlooked that part.

Thank you sir, your comment worked for me. I was working with rails and it was including automatically, I changed to rails api and a static angular website, now I have to include the tpls.js file manually in the index.html. Again, Thank you! =)


flit build - fetching list of  valid trove classifiers  fails without Internet access

Hi,
I am using flit 3.6 in an environment without Internet and Python packages are fetched through an internal pypi mirror.
If I run
flit build

then it fails with the following
Fetching list of valid trove classifiers               I-flit.validate
Couldn't get list of valid classifiers to check against  W-flit.validate
Traceback (most recent call last):
  File "c:\test\pythonexample\Scripts\flit-script.py", line 9, in <module>
    sys.exit(main())
  File "c:\test\condaenv\pythonexample\lib\site-packages\flit\__init__.py", line 177, in main
    main(args.ini_file, formats=set(args.format or []),
  File "c:\test\condaenv\pythonexample\lib\site-packages\flit\build.py", line 45, in main
    sb = SdistBuilder.from_ini_path(ini_file)
  File "c:\test\condaenv\pythonexample\lib\site-packages\flit_core\sdist.py", line 91, in from_ini_path
    module = common.Module(ini_info.module, srcdir)
  File "dc:\test\condaenv\pythonexample\lib\site-packages\flit_core\common.py", line 58, in __init__
    raise ValueError("No file/folder found for module {}".format(name))
ValueError: No file/folder found for module flit

I suspect this is due to the lack of Internet access. Is it possible to skip the check and/or provide an alternative URL?
It seems to be hardcoded, which is not so suitable for Enterprise scenarios:
https://github.com/pypa/flit/blob/main/flit/validate.py#L55
Thank you.
Best regards

Hiya! You can set FLIT_NO_NETWORK=1 and flit won't try to fetch a list of trove classifiers.

We try to keep options to a minimum, so I'd say skipping the check is sufficient - and it will automatically skip it if you don't have an internet connection (I added that on a long train journey with beautiful scenery and no wifi :slightly_smiling_face: ).

I'm going to close this now. The error described was separate, and an internet connection is not required - you will only see a harmless warning that it can't check your classifiers if you're without internet. Even that doesn't show if it has cached the list previously and all your classifiers are in that list. :slightly_smiling_face:


CB-8790. Support custom cluster CRN & cluster name for metering heart…

…beat service
See detailed description in the commit message.

Tha change looks good to me.


Issue-161: Scope annotations must have Runtime Retention

Issue: https://github.com/stephanenicolas/toothpick/issues/161

Coverage decreased (-0.09%) to 94.541% when pulling 3f19e65b22676218ac9d29368afa944b2e4ea04a on dlemures/issue/161 into 55f2004fa694bdc2a74f19abbc38c450b4af7dd6 on master.

RTM. Thx !


Question | DirectLine message Ids

So we've got a web interface which uses https://www.npmjs.com/package/botframework-directlinejs (works really well) and we use the fact that messages returned via directline (bot and user msgs) have a messageId of the format "G0SRNz7iwTiLehjQsXk3tI|0000001", "G0SRNz7iwTiLehjQsXk3tI|0000002" etc to sort on the sent and received ones on our FE.
However... Messages (Activities) in the bot code itself have a messageId of the format of a GUID. Even if you got to that point in code from a request via directline.
So my question is: does directline have some sort of interception and enrichment of the messages (ids) on your side before returning to the user? Why then do these messages not have the same ID in our bot code itself?
Reason I'm asking is, we broadcast messages to a separate 'admin-console' via signalR. But the message has a GUID id. But the message had a directline id on the webchat side.
You can imagine how this mucks with sorting messages in their correct order. Especially as the timestamp on the messages is not reliable - messages are frequently in the wrong order.
Any feedback very much appreciated.

Hi @JPThorne, activity IDs are designed to be stable between the bot and the client.
At the moment, our storage system is assigning serial IDs for all activities that are stored. However, not all activities are stored -- for example, Typing activities are sent without being stored in the message history. Those activities will not have serial IDs.
Are you seeing literal GUIDs as the activity ID? We don't generate any GUIDs -- even the IDs assigned to Typing activities are random strings, similar to our conversation IDs.

Hi @dandriscoll thanks for the reply.
So, we are seeing literal GUIDs, well, a string version of a guid. For example, for the same "hi" message to our bot via directline, and then broadcasting the activity via signalR we see these two different messageIds:
0b4213bc-9c14-4787-819f-c53be27b20f0
2EUT44oscMYLKOpPmqG7bj|0000001
Maybe we're just misunderstanding things here - for example, we use IDialogContext.MakeMessage in several places to construct a message activity, and I'm seeing that that creates a new guid as the message id... obviously it wouldn't know about it's previously received messageId.

Activity IDs are assigned exclusively by the service, so even though the SDK may be generating IDs, those will be thrown out when the message is persisted. Most of our channels do this, and this mandatory in Direct Line as the service uses the ID for sequencing. If you want to add correlation information, you can do that in the ChannelData field, which will be passed between your client and your bot.

hy @dandriscoll , I'm trying to intercept all the incoming and outgoing messages on my bot code (.net) using an IActivityLogger but when the messages  (IActivity)  sent from my bot to the client gets intercepted on my IACtivityLogger it never have the "id" property filled, it is always null (even for activities of type "message"). It is driving me nuts to figure out why the activities sent from my bot to the client doesn't have the "Id" property properly assigned before it gets sent to the directline ? on my client side (directlineJS) the id propperty gets gratefully asigned for all messages in the format "2EUT44oscMYLKOpPmqG7bj|0000001". I was expecting to see the same when I intercept the messages on my IActivityLogger so I could create a history on my company's CRM software.
Is there any way I can get the same value for the IActivity.Id on both client and server side ?


container: bubblewrap runner: use --new-session to mitigate CVE-2017-5226

Without it, it is possible to escape the sandbox via TIOCSTI ioctls on the session PTY.
Related: https://github.com/containers/bubblewrap/issues/555
Related: https://github.com/containers/bubblewrap/issues/142
Related: https://news.ycombinator.com/item?id=30825088

Hi, good move!
I see that commit 07cd62ea469a1d05bdaa628354fbe13158ab2f42 is not part of release 0.2.0 and that 0.2.0 is packaged in Arch Linux and derivatives. My vote for considering a new release and a CVE for this. It only takes filling this form: https://cveform.mitre.org/ .

Our invocation of bubblewrap does not pass through the terminal file descriptor, so we do not believe there is any practical exposure to CVE-2017-5226.  We would be likely to dispute any CVE filed for that reason.

To be sure I understand: if that is true, why would you want to pass --new-session then? How is exec.Command not passing the controlling terminal to bwrap? Please help me understand what I may be missing.

To be sure I understand: if that is true, why would you want to pass --new-session then?

We do want the setsid effects for other reasons.  And it is better to have it anyway, just in case we begin to use PTYs in the future instead of pipes.

How is exec.Command not passing the controlling terminal to bwrap? Please help me understand what I may be missing.

exec.Command just creates an execution object.  The actual execution happens here, after stdio redirection is set up to use pipes: https://github.com/chainguard-dev/melange/blob/main/pkg/container/runner.go#L49

We do want the setsid effects for other reasons.

Could you elaborate?
The title "to mitigate CVE-2017-5226" communicates a different picture. I'm confused.


see if it's possible to upgrade to Scala 2.13 and then we can cross compile

for 2.12 and 2.13

I played around with this recently. Not quite there yet, getting compile errors on our custom types such as:
found   : org.adridadou.openlaw.OpenlawString
[error]  required: String
[error]         case Some(value:OpenlawString) => cast(value, executionResult)

and not quite clear why to me. Seems lower priority for now.

What file/line is that?  Might be a change in implicit resolution that's affecting the type class.

@craigwblake-openlaw I think @adridadou has done some work on this in a branch which is more recent than what I've done.
Seems like it's not a super high priority atm though given instability of some of other related deps


Fix Python 3.7 deprecation warnings

Importing ABCs directly from the collections module is deprecated
in Python 3.7.

It would be nice to get this merged. What is the status?

The CI failed, but it does not seem to be caused by this PR. It would be a good idea to add Python 3.7 to the travis XML.
@syrusakbary: can you please release a version with these warnings fixed? Python 3.7 is now the default version of Python in Homebrew (MacOSX).

Python 3.8.0 is now out. The deprecation warning has been extended to 3.9 so this doesn't block upgrades but it would still make my day if this could get cut into a new release to kill the warnings.
As commented above, the CI failure is not related to the changes
Any chance someone has spare eyes for this?

The core problem here is mypy isn't version pegged, so new versions find new problems.  I've created a PR, based on this PR, to fix the mypy errors: #79


Markdown formatting of table not correct

The table formatting here is not rendering correctly for the release calendar: https://docs.microsoft.com/en-us/azure/aks/supported-kubernetes-versions#aks-kubernetes-release-calendar

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ec484163-5d73-af3a-3d7b-9e0d421d2824
Version Independent ID: 42da7aed-a33d-e331-fb7f-4fb4b40e5813
Content: Supported Kubernetes versions in Azure Kubernetes Service - Azure Kubernetes Service
Content Source: articles/aks/supported-kubernetes-versions.md
Service: container-service
GitHub Login: @palma21
Microsoft Alias: jpalma

@patrick-stephens
Thanks for the feedback! We are currently checking and will update the document as appropriate.

@patrick-stephens The table is showing up properly for me. Can you please share a screenshot and also try in a different browser if that helps.

You are correct, it is indeed showing ok now. It definitely was not yesterday on the same browser but possibly an interrupted download issue or something, although the text after it was fine. It looked like the raw markdown text for a table rather than rendered.

We fixed it in the meantime yesterday. It was showing incorrectly for some hours. Thanks for the report!

Ah, thanks @palma21 as that explains it and I wasn't going mad!


Record shared by access link remains visible + "editable" in UI even after invalidating the link

Steps to Reproduce
Requires two user accounts.
User A: create an editable access link and "share" with User B
User B: use access link, edit the record
User A: destroy the link
User B still sees the record in his "user record" overview with the "Edit" button.
Pressing the button will do nothing in the UI and log a "Permission Error".
Expected behavior
User B should either not see the Edit possibilities anymore, or not even see the record in his list anymore (its not theirs, User B is just a temporarily invited guest to User A's record, so it should not stay in User B's list permanently)
Notes
Did not try with just "view" permission and private record, maybe this also should be tested. Especially in that case it would be important for the record to completely disappear from User B once the link is destroyed.

It looks like the issue is that the deletion of the secret link does not trigger a re-indexing of the draft.
The search result (curl -ks https://localhost/api/user/records\?q\=missing -H "authorization: bearer $TOKEN" | jq .)  still contains the secret link's ID, which is used by the permission generator to filter search results:
        "parent": {
          "communities": {},
          "access": {
            "owned_by": [
              {
                "user": 2
              }
            ],
            "links": [
              {
                "id": "4cf79522-52cc-4e90-aba5-732722971d75"
              }
            ]
          },
          "id": "bkas3-ptb19"
        },

However, the record's JSON in the back-end/DB already has the link's ID removed:
  "parent": {
    "access": {
      "links": [],
      "owned_by": [
        {
          "user": 2
        }
      ]
    },
    "communities": {},
    "id": "bkas3-ptb19"
  },

Thus, an artifact will still show up in user B's dashboard (because the search index isn't up to date), but the permission checks based on the actual record as per DB will fail.
The fix on Invenio's side here is to make sure that the record/draft is re-indexed whenever a secret link is deleted.
As a work-around for now, you could try editing the draft and immediately saving it again (without doing any actual changes), as that will cause the draft/record to be re-indexed, and thus filter out the record/draft from B's dashboard.


Update 2018_03_12.md

Thanks, but I'm not really worried about this level of grammatical detail in these updates.


apocalyptical

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.1
logical conflict every: 100
sleep for: 300s
close stale after: 4 hours
[pullrequest]
requests per hour: 0
deps=[a]

/trunk merge


Error with dropdown toggle input attribute

I am attempting to use the dropdown component using the example as a guide and I am getting an error and a non-functional button. It seems that maybe isOpen isn't being honored as an input by the component. I am using<EMAIL_ADDRESS>Removing isOpen fixes the error but does not cause the dropdown toggle to  work.
VM15222:84 EXCEPTION: Error: Uncaught (in promise): Template parse errors:
Can't bind to 'isOpen' since it isn't a known native property ("><button class="btn btn-secondary" id="sort-button" type="button" dropdown-toggle="dropdown-toggle" [ERROR ->][(isOpen)]="isSortDropdownOpen">Action </button><ul dropdownMenu"): RfpListComponent@0:270

Here's the relevant parts of my code:
TS:
import { Component, OnInit } from '@angular/core';
import { ROUTER_DIRECTIVES} from '@angular/router';
import { DROPDOWN_DIRECTIVES } from 'ng2-bootstrap';

@Component({
  selector: 'rfp-list',
  directives: [DROPDOWN_DIRECTIVES],
  template: require('./rfp-list.component.pug'),
  styles: [require('./rfp-list.component.scss')]
})
export class RfpListComponent implements OnInit {
  isSortDropdownOpen: boolean = false;

  constructor() { }

HTML:
<button id="sort-button" type="button" dropdown-toggle="dropdown-toggle" [(isOpen)]="isSortDropdownOpen" class="btn btn-secondary">Action </button>

Due Date

Name

I have same error but with datepicker(using exactly as in example in readme.md) when using pug. In html templates all works good.
Looks like it's pug-html-loader problem when using ng2-bootstrap(when using Webpack).
My idea to fix it - using pug-loader instead pug-html-loader. But i couldn't run it properly in webpack loaders config.

ok, you are trying to banana bind to isOpen
but is only a property, so only [isOpen] will work
but there are no isOpenChanged, so you can not use it as [(isOpen)]
I will close this issue, but if you will need this functionality
just create feature request or even PR
it will be really simple one


Remove as many links to guides as possible

... and replace them with links to a sample or the samples index page.

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test this

OK, I've already cancelled the old build and triggered a new ReadyForMerge build for you.


Q: About History downloading

When downloading history again, will it only download the ones you don't have?
And if not, is it a possibility to have it added?

History will only download links that have not been downloaded yet. To reset this you can delete the database folder.


Self update support

This PR contributes the capability to self-update the just binary in-place.

Hi maintainers, please have a look and provide feedback if this feature is desired and how it can be improved.
The current limitation is that it hard-codes updates to x86_64-unknown-linux-musl only but we can improve it later.

This is very cool! What happens if just is installed as a system package, e.g. with homebrew or another package manager? Will just --update overwrite the installed system package?

This is very cool! What happens if just is installed as a system package, e.g. with homebrew or another package manager? Will just --update overwrite the installed system package?

Yes, the binary will be overwritten directly. I am not sure if metadata is updated in the package manager (any way to programmatically update it?).
In that case, I wouldn't expect users to manually call just --update, but if they to, the metadata would be out-of-sync.

I'm on the fence about this!
On the one hand, it's cool and convenient. On the other hand, the current install script is pretty easy to use, and won't work when just is installed with a package manager.
I checked out the PR branch and did a little testing, and self_update is a pretty heavy dependency. It pulls in reqwest, tokio, and hyper, which are pretty big. This brings clean compile times on my machine from around 40 seconds to around 70 seconds, and incremental compiles from around 0.5 seconds to around 1.0 seconds. The clean compile time increase doesn't bother me that much, but the incremental compile time increase doesn't seem worth it. Especially since my machine is pretty fast, so it'll be worse on slower machines.
So I think on balance this isn't worth it, mostly because of the increase in compile times. Thank you for this PR though!


Settings: No way to focus edit button via keyboard

Environment Details:
VSCode Version : 1.24.1
OS Version : HighSierra10.13.5
Additional Details:
MAS Violated : MAS 2.1.1
Repro Steps:
1.Launch VS Code.
2.Navigate to Settings icon in Activity Bar->Press Enter->Select "Settings" from dropdown.
3.Keyboard Focus does not go on the "Edit" button present when a particular list item is expanded on the screen.
Actual:
Keyboard Focus does not go on the "Edit" button present when a particular list item is expanded and the edit button is visible on the page.
Expected:
Keyboard Focus does not go on the "Edit" button present when a particular list item is expanded and the edit button is visible on the page.
When the edit button is expanded using the mouse click , two options are displayed(True/False) which cannot be used until the edit button is actionable.
Recommendations:
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx
User Impact:
The End user will not be able to access the edit buttons which is embedded with some functionalities.
MAS Reference:
MAS 2.1.1 - https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={8492c4eb-c179-40ae-8777-cd044ed725a2}
Attachment for Reference:
A11y_VSCode_UserSettings_Keyboard_FocusIssue.pptx
Does this issue occur when all extensions are disabled?: Yes

This is the settings editor, leaving to @sandy081 to decide how to tackle and if low hanging

This settings editor is based on text editor. Since we are coming up with a new settings editor which is web style and will be accessible, I would not invest here.

That makes sense, assigning to backlog.


Q: Should "bodies" elements always be different technical formats of the same editorial body a la NewsML-G2?

e.g. should we be able to have "role": "long" and "role": "short"?
Or should we be strict and allow only technical formats?
An example could be a body in plain text, XHTML, AMP format, Apple News format, and Facebook Instant Articles format. These would be defined as roles. (Several of them would probably have the same contenttype, so we couldn't use the contenttype property alone as a way to distinguish these bodies from each other.)
This is probably more a documentation question than a schema one, the schema may not need to change but we should be clear about how we intend it to be used.

We can extend the documentation, but I don't think we should be too restrictive. If providers have use for roles we have not thought of it is better to be open and flexible. And what is the definition of technical format and other stuff?

Done.


Align prints parsing

Make both segments of building modules from prints use the same logic so that we do not get inconsistent bugs later. Also allows for us to have things like Cout or endl not at the top layer.

Thanks!


fix(deps): upgrade to the latest @google-cloud/common and grpc

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

[ ] Tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

The other question I have is that – given that we are using renovate – why were these dependencies out of date to begin with? Is the renovate integration even working?

Yes, it's working.  I messed up the original PR somehow while trying to make this change 😆

I see. For posterity that was PR #109 that you just closed a little while ago. I don't see a PR from renovate about grpc though. I wonder why 🤔.

It's because it was in the acceptable semver range :)


unity client turn failure, credential mismatch

in the unity sample client turn server configuration will not work, due to a bug in the mapping from the config username and password to the data object username and credential. The client will automatically fallback to stun (using google stun) or lan direct ip communication.

on a related note, https://github.com/CatalystCode/3dtoolkit/pull/66/commits/1ee334b4f25d6275b616e12353b2884fa2162bbd forces turn negotiation, which may be useful for testing in the future


User Guide form validation rules, decimal rule misleading

I noticed this in the User Guide for form validation rules: http://codeigniter.com/user_guide/libraries/form_validation.html
(Also an issue in previous versions)
The rule for decimal states that it accepts a parameter and: "Returns FALSE if the form element is not exactly the parameter value."
This seems to imply that you can give it a value and it will return false if that values do not match.  Looking at Form_validation.php the decimal function only takes the input string and verifies that it is in fact a decimal number.  I'm sure this is the intended functionality, but perhaps the documentation should be changed.

Fixed (see the referenced commit above) ... that was probably copied from 'matches'.


Missing cmdlets

Some cmdlets seem missing. I issued the following command in Windows PowerShell:
(get-module UpdateServices -ListAvailable).ExportedCommands.Keys | Sort-Object

What I got was this:
Add-WsusComputer
Add-WsusDynamicCategory
Approve-WsusUpdate
Deny-WsusUpdate
Get-WsusClassification
Get-WsusComputer
Get-WsusDynamicCategory
Get-WsusProduct
Get-WsusServer
Get-WsusUpdate
Invoke-WsusServerCleanup
Remove-WsusDynamicCategory
Set-WsusClassification
Set-WsusDynamicCategory
Set-WsusProduct
Set-WsusServerSynchronization
Items in boldface are missing.
The interesting things is, I can actually find documentation pages for these commands on docs.microsoft.com!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ae0c499d-8c99-b8e3-ba3a-e36a8ab7452e
Version Independent ID: c56224e1-6594-09c6-8425-a07370b0b69a
Content: UpdateServices
Content Source: docset/winserver2012-ps/updateservices/UpdateServices.md
Product: w10
GitHub Login: @brianlic-msft
Microsoft Alias: brianlic

Never mind. Windows Server 2012 R2 no lists these cmdlets. This means someone has fixed things the other way around.


Forecasting: Generated Console App cannot run on .NET6.0 in VS2022.

System Information (please complete the following information):
Windows OS: Windows-11-Enterprise-21H2
ML.Net Model Builder 2022: <IP_ADDRESS>1702 (Main Build)
Microsoft Visual Studio Enterprise: 2022(17.3.0)
.Net: 6.0
Describe the bug

On which step of the process did you run into an issue:
Generated Console App cannot run on .NET6.0 in VS2022 for Forecasting scenario.

TestMatrix
https://testpass.blob.core.windows.net/test-pass-data/forecasting.csv
To Reproduce
Steps to reproduce the behavior:

Select Create a new project from the Visual Studio 2022 start window.
Choose the C# Console App (.NET Core6.0) project template.
Add model builder by right click on the project.
Select Forecasting scenario.
On Data page, select the data source and then completed the training.
On the Consume page, click "Add to solution" button to generate a Console App.
Choose the generated Console App as startup project and then run it.
You will see that it reminded you need to install .NET5.0.

Expected behavior
The generated Console App should run successfully.
The default Target Framework should be 6.0 for the generated Console App.
Screenshot

Additional context:

The default Target Framework is 5.0 for the generated Console App.

After you installing .NET5.0 from https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=5.0.0&arch=x64&rid=win10-x64, the generated Console App can run successfully.

May be related to #2401.

The generated project always targeted to .net 5

The bug has been fixed on the latest main build <IP_ADDRESS>6903.


Remove gesture handler typings

There is no reason to have Types folder in root(unless really needed). Should be inside app or src folder -> typings folder
There is no reason to have React Native Gesture Handler typings in project(here they are: https://github.com/kmagiera/react-native-gesture-handler/blob/master/react-native-gesture-handler.d.ts)

It will be changed in a next merge request.
I'm not sure about this. Cause I had tried to remove React Native Gesture Handler typing and app crashed.


Deliver to Storage is not using ubuntu runner

Hey @freddydk ,
We recently got into the trouble with our github costs :) It trigger us to change our configuration and we switched to ubuntu-latest for the trivial jobs. We can see savings especially on Deployment Jobs, which costed us ~2.5$ per each deployment 🙃
We still see some room for the improvement. For example job "Deliver to Storage" is still using our expensive build machine. Could you please make code adjustments, so it would use "runs-on" setting?

Our settings are:
{
  "type": "PTE",
  "templateUrl": "https://github.com/microsoft/AL-Go-PTE@main",
  "treatTestFailuresAsWarnings": true,
  "doNotRunBcptTests": true,
  "enableCodeCop": true,
  "rulesetFile": "../cicd.ruleset.json",
  "companyName": "TNM Automated Test",
  "runs-on": "ubuntu-latest",
  "githubRunner": "srs-eid",
  "defaultNewContainerParameters": {
    "isolation": "hyperv"
  },
  "skipUpgrade": true,
  "environments": [
    "QA"
  ],
  "CICDPushBranches": [
    "main",
    "release/*",
    "feature/*"
  ],
  "CICDPullRequestBranches": [
    "main",
    "release/*",
    "features/*",
    "bug/*"
  ],
  "DeliverToStorage": {
    "Branches": [
      "main",
      "release/*"
    ]
  },
  "DeployToQA": {
    "EnvironmentType": "SaaS",
    "EnvironmentName": "QA",
    "Projects": "SRS.nl",
    "Branches": [
      "main"
    ],
    "ContinuousDeployment": true,
    "runs-on": "ubuntu-latest"
  },
  "DeployToQA24": {
    "EnvironmentType": "SaaS",
    "EnvironmentName": "QA24",
    "Projects": "SRS.nl",
    "Branches": [
      "feature/bc24-update-EID-3621"
    ],
    "ContinuousDeployment": true,
    "runs-on": "ubuntu-latest"
  },
  "DeployToUAT": {
    "EnvironmentType": "SaaS",
    "EnvironmentName": "UAT",
    "Projects": "SRS.nl",
    "Branches": [
      "release/*"
    ],
    "ContinuousDeployment": false,
    "runs-on": "ubuntu-latest"
  },
  "DeployToPROD": {
    "EnvironmentType": "SaaS",
    "EnvironmentName": "PROD",
    "Projects": "SRS.nl",
    "Branches": [
      "release/*"
    ],
    "ContinuousDeployment": false,
    "runs-on": "ubuntu-latest"
  },
  "EnableTaskScheduler": true,
  "doNotRunTests": true,
  "alwaysBuildAllProjects": true,
  "PullRequestTrigger": "pull_request",
  "CurrentSchedule": "0 2 * * *",
  "NextMinorSchedule": "0 2 * * 6",
  "NextMajorSchedule": "0 2 * * 0",
  "templateSha": "a6b2e468579e02a31a9cc9a2ae178a1e6beadf00"
}

Did you run Update AL-Go System Files after changing runs-on in your repo settings?
(I will specify this in the docs - it isn't clear today)
When I look in my CICD.yaml after updating AL-Go System Files - mine is using ubuntu (also for initialize and checkforupdates)

You are right @freddydk. I just checked and it got fixed last somewhere last week. I guess it got fixed after running al-go system update, as you suggested.


ciao-controller: All running instances status should be 'active'

When asking for a specific instance details or a list of instances
details, the status string for a running instance should be
consistent.
Then, for OpenStack compatibility sake, we want this string to
be 'active' and not 'running'.
Fixes #323
Signed-off-by: Samuel Ortiz<EMAIL_ADDRESS>

Coverage decreased (-0.002%) to 62.847% when pulling e3bb6be5aa9c1bb3d74d7e93c4894a32b6124769 on sameo/issue/323 into fd2aa1e441abcacb820429c7c7b0498dbbb2e3db on master.


Rename the default branch of this repo to main

This is a tracking FR that can be closed when the default branch of this repo is renamed from master to main. For more context, see https://github.com/ampproject/amp-github-apps/pull/1256, https://github.com/ampproject/amphtml/issues/32195, and https://github.com/ampproject/amphtml/pull/33571
Tagging @ampproject/wg-infra for visibility, since we'll need to coordinate the renaming with https://github.com/ampproject/amp-github-apps/pull/1256 (after there is agreement on this plan.)

Done.


Ensure nav-tree is the correct height

Ensure that the nav-tree extends to the full height of the content area. The footer must be enclosed in a div element with the id="nav-path" for this to work.

Thanks @ddirks !


(QENG-2545) Remove pe profile.

This profile was used to build pe-puppetdb using lein-ezbake. Instead, we will
be building pe-puppetdb from the pe-puppetdb-extensions repo.

@shrug @ajroetker @mullr @senior @kbarber ping

Can one of the admins verify this patch?

I think this should be targeted at stable, then we'll merge it up to master


URLS of images uploaded via RichTextUploadingField before migration to S3 not updated after migration

I recently migrated my media assets to AWS S3 and later discovered that the URLS of inline images uploaded via Django CKEditor's RichTextUploadingField appear to be hardcoded. After the migration, I can upload and view images without a problem. However, all images uploaded prior to the migration return a 404 not found error.
When I query the value of a problematic RichTextUploadingField field in the database, I get something like this (note that the first image was uploaded before the migration, and the second image was uploaded after the migration):

Is this normal behavior? One solution I can think of is to loop over the values of all RichTextUploadingField fields and manually update the URLS, but I'm wondering if there's a built-in solution for this that I might have overlooked.
I'm using Django CKEditor 6.7.0, Django 4.2.6, and Django Storages 1.14.2 with support for S3.

Yes that's expected, and yes, updating the HTML yourself is what you have to do. That's the downside of using HTML instead of more structured data formats.
I recommend using beautifulsoup4 or something for the transform.


Capture Group 2 and up is not working in extract()

I tried the following example and it is not working.
ex. extract(""Some string": "(.+)"", 2, Text)
Let me know if you need the actual example.

@orgen16  Please help with the link of the document on which the above document feedback request is created.
In case your query is not related to document content, open a new forum thread in Microsoft Q&A or Stack Overflow as it could be a better place to get help on your scenario. These forum community members could provide their expert guidance on your scenario based on their experience. Thanks.

@orgen16  Please help with the link of the document on which the above document feedback request is created.
In case your query is not related to document content, open a new forum thread in Microsoft Q&A or Stack Overflow as it could be a better place to get help on your scenario. These forum community members could provide their expert guidance on your scenario based on their experience. Thanks.

@orgen16  Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly reopen the issue and continue the discussion.