zap and EPG

Hello. I can't figure this one out - why is the EPG removed from the output if I do zap? Is this right? I can find another way to deal with this but maybe I'm missing something, so I'm just asking.

It seems that this is how zap is supposed to behave. But wouldn't this be useful feature to keep EIT for the zapped channel? I mean, if svremove removes EIT for removed services, it would make sense for zap to work with EIT as well. But I guess it's not a problem to use svremove many times instead of one zap to solve this.

Thanks, that's a good idea, similar to what I do now, which is forking PID 18 as local IP unicast and then merging it back after the zap. But there's still the issue with unnecessary EIT traffic from all the channels that were removed because of zap ... sure, adding svremove many times (for all removed channels, including other networks) would probably help so this isn't really such a big issue.

Sure!
The svremove plugin has the functionality to discard the EPG data from the program to remove.
In any case, perhaps @lelegard will like to add the option inside zap to maintain the EIT pid with the data of only the zapped program.
Regards.

Thanks! It looks good, comparing without and with --eit:

C:\>tsp -I file "D:\SAT\FULL TS\HBBTV\FRANSAT2.ts" -P zap 0x0606 -P eit -O drop
Summary
-------
TS id:         6 (0x0006)
Last UTC:      2018/06/15 19:47:36
EITp/f actual: 0
EITp/f other:  0
EITs actual:   0
EITs other:    0

TS      Services  With EITp/f  With EITs  EPG days
------  --------  -----------  ---------  --------
Actual         1            0          0         0
Other          0            0          0         0

A/O  TS Id   Srv Id  Name  EITp/f  EITs  EPG days
---  ------  ------  ----  ------  ----  --------
Act  0x0006  0x0606  TMC   no      no           0

C:\>tsp -I file "D:\SAT\FULL TS\HBBTV\FRANSAT2.ts" -P zap --eit 0x0606 -P eit -O drop
Summary
-------
TS id:         6 (0x0006)
Last UTC:      2018/06/15 19:47:36
EITp/f actual: 64
EITp/f other:  0
EITs actual:   137
EITs other:    0

TS      Services  With EITp/f  With EITs  EPG days
------  --------  -----------  ---------  --------
Actual         1            1          1         8
Other          0            0          0         0

A/O  TS Id   Srv Id  Name  EITp/f  EITs  EPG days
---  ------  ------  ----  ------  ----  --------
Act  0x0006  0x0606  TMC   yes     yes          8

OK, good, closing this one then.


all: Label connection pool metrics with the pool they come from

We identify pools as either 'main' or 'replicaN' in the labels
Fixes https://github.com/graphprotocol/graph-node/issues/1861

Following @leoyvens's idea of statically determining how much traffic to send to each database, added a commit that allows assigning weights to each database host


Adrilight doesn't change from rainbow

Hi,
Adrilight used to work for me awhile ago but after a couple of updates later (both windows 10 + adrilight) it doesn't work anymore.
I can get the rainbow to work and the preview works.
When I select connect in the windows app, the arduino light starts flashing so I know the app is working.
I read somewhere about baud rate being 1,000,000 but the maximum I can set it to in device manager is roughly 128000. I assumed the app itself sets the baud rate?
Any help will be much appreciated.
Kind regards
Hugo

Is the rainbow still animating around your screen?
Please reboot, just to be sure (actually fixed issues in the past!)
what is the version number of adrilight?
please provide log details:

Look in the folder %localappdata%\adrilightApp\app-2.0.9\logs or the highest version number you have. The real path may look like c:\Users\fancyUsername\AppData\Local\adrilightApp\app-2.0.9\logs. Put everything in a zip or 7z archive and upload it here (drag&drop into the comment window)

Rainbow is working however it will stop if I restart the computer.
I'm running the latest version both the app and the arduino sketch.
adrilight.log.2019-06-27.txt

All good, it works after using a new arduino.


How to get new key of FirebaseListObservable.push?

How do I get the new key when I push to a list?
This is a basic functionality and the docs/examples need updating.
Thanks

You can retrieve it with the .key() function:
var my_key= this.af.list("/list").push(data).key()


[Enhancement Request] "show slave status" should upgrade to "show replica status"

Background

From MySQL 8.0.22, SHOW SLAVE STATUS is deprecated, and from MYSQL 8.4, it will cause an syntax error You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'slave status' at line 1.
Proposal

When Wescale is deployed in local, it still relies on 'SLAVE' syntax. We should check the MYSQL version.

fixed


Bencode enums should contain offset and length of raw representation in source buffers

BEP 3 specifies that the infohash must be calculated from the raw representation of the dictionary as found in the source, not from round-tripping through the decoder and encoder. This requires the ability to find the offset and length of a particular value in the raw source buffer.
Similarly BEP 44 requires extraction of the raw data for the v key.

Thanks for the issue! I think this is a valid concern, though, I probably won't be pushing a fix for the current code as I will hopefully be getting to work on #41 soon.
Cheers!


Autosave generate the corrupted file

We found some corrupted project file in workspace.
Seems it is caused by the auto saving of the project. I guess It has been a incurring issue on the project saving. The "auto saving" was introduced which may cause the corrupted file issue. Then the "auto recover" feature was put as a patch to fix this when loading the workspace. sometime it works. But most of time it still fails to rescue.
static protected class AutoSaveTimerTask implements Runnable {
@Override
public void run() {
try {
ProjectManager.singleton.save(false); // quick, potentially incomplete save
} catch (final Throwable e) {
// Not the best, but we REALLY want this to keep trying
}
}
}
Need a decent way to save the project file. Autosave may not a good idea.

What version did you see this with?  There were significant changes made in 2.6 specifically to improve robustness of the save code in the face of heap exhaustion.
The periodic automatic project save uses exactly the same code as the user initiated save, so any problems seen in one will be seen in the other.
What evidence do you have that autosave, specifically, is the root cause?
Note that the alternative, forcing the user to manually save, will cause them to lose all work since their last manually initiated save.  In my mind, fixing the save function (if it still needs fixing) is vastly preferable to disabling autosave altogether.

The version I am using the 2.6 Beta. That might be reason. Will keep watching the new version if it still happens.
The evidence is that I can find *.corrupted file in my workspace. when I trace back from the code, the auto saver most likely the reason. My understanding is that even the auto saver and user initiated save use the same code, but the timing matters. The auto saver could happen at any time point even when some task is running. In that case may cause issue.

@wetneb You tagged this "to be reviewed". What type of review were you thinking? From my point of view, it's old enough and unreproducible enough to close.

Fine with me!


System.OverflowException : Arithmetic operation resulted in an overflow.

Overflow exception from SetUshort_Correct method in HelperTests.

Solved:
https://stackoverflow.com/questions/78615458/bitshifting-causes-system-overflowexception-arithmetic-operation-resulted-in-a?noredirect=1#comment138600166_78615458


Links in footer doesn't work

Hi,
I added spree_static_content to my project, addes static pages, but pages didn't show in a footer(I marked checkbox). Can you tell whats going on??

same problem


VSCode does not register changes in files under directories with non-conventional characters

VSCode Version:   1.40.0-insider
OS Version: 10.15

Steps to Reproduce:

Access a file in a directory with non-conventional characters (e.g., {{cookiecutter.repo_name}})
Modify a file.
The editor doesn't seem to register the fact that the file has changed. Saving the file does not save it to disk. Somehow, doing Save All does save it to file.

Does this issue occur when all extensions are disabled?: Yes

Do you have a single or multiple folders opened?

Interestingly, the problem seems to have just disappeared. I reopened the project that was giving me problems and the issue was still there. After closing all the tabs and refreshing the explorer everything seems fine now.
I'm fairly sure I did all that a few times before opening the issue. I wonder if the overnight version of Insiders somehow fixed this. I started noticing the problem after cherry-picking some files with conflict between two branches in the project; it may also be possible that had something to do.
Since I cannot reproduce anymore I think it's ok to close this and I'll reopen if it happens again.

Good to hear. Note there are a few issues related to the file watcher open, what you saw is likely one of them https://github.com/microsoft/vscode/issues?q=is%3Aopen+is%3Aissue+label%3Afile-watcher


Client-side console.log not showing output in browser

Describe the bug
I am trying to log messages to the browser console when a button is clicked, but nothing is showing up in the Firefox console. I expect at least the "Getting PDFs..." message to be displayed when the button is clicked.
Here's the relevant code from my Svelte component:
<!-- routes/+page.svelte -->
<script>
	import { page } from '$app/stores';
	import PdfList from '$lib/PdfList.svelte';
	import PdfViewer from '$lib/PdfViewer.svelte';
	import { selectedPdf } from '$misc/stores';
	import { SSE } from 'sse.js';

	async function getPdfs() {
		console.log('Getting PDFs...');
		const response = await fetch('/api/pdfs');
		console.log('Status:', response.status);
		console.log('Headers:', response.headers);
		const pdfs = await response.json();
		console.log('PDFs:', pdfs);
	}
</script>

<button on:click={getPdfs}>Get PDFs</button>

Here's the code from my API route:
// src/routes/api/pdfs/+server.ts
import fs from 'fs';
import path from 'path';

import type { Config } from '@sveltejs/adapter-vercel';
import type { RequestHandler } from './$types';

export const config: Config = {
  runtime: 'edge',
};

export const GET: RequestHandler = async () => {
  const pdfsDirectory = 'static/pdfs';
  const pdfFiles = fs
    .readdirSync(pdfsDirectory)
    .filter((file) => path.extname(file).toLowerCase() === '.pdf')
    .map((file) => ({
      filename: file,
      path: path.join(pdfsDirectory, file),
    }));

  const response = new Response(JSON.stringify(pdfFiles), {
    headers: {
      'Content-Type': 'application/json',
    },
  });
  console.log(response);
  return response;
};

The server side is console.logging a response, but nothing is showing up in the Firefox console. Shouldn't the client at least be saying "Getting PDFs..."?
Reproduction
Steps to reproduce
Add the above code to the respective files in a SvelteKit project (must add pdfs to the static/pdfs folder)
Start the development server.
Open the page in Chrome and open the developer console.
Click the "Get PDFs" button.

Expected behavior
The message "Getting PDFs..." should appear in the browser console when the button is clicked.
Actual behavior
No output appears in the Chrome console.
Logs
On the server side:

Response {
  [Symbol(realm)]: { settingsObject: {} },
  [Symbol(state)]: {
    aborted: false,
    rangeRequested: false,
    timingAllowPassed: false,
    requestIncludesCredentials: false,
    type: 'default',
    status: 200,
    timingInfo: null,
    cacheState: '',
    statusText: '',
    headersList: HeadersList {
      cookies: null,
      [Symbol(headers map)]: [Map],
      [Symbol(headers map sorted)]: null
    },
    urlList: [],
    body: {
      stream: undefined,
      source: '[{"filename":"...","path":"....pdf"}],
      length: 381
    }
  },
  [Symbol(headers)]: HeadersList {
    cookies: null,
    [Symbol(headers map)]: Map(1) { 'content-type' => [Object] },
    [Symbol(headers map sorted)]: null
  }
}

System Info
System:
    OS: Linux 6.2 Pop!_OS 22.04 LTS
    CPU: (12) x64 AMD Ryzen 5 5600X 6-Core Processor
    Memory: 521.72 MB / 15.54 GB
    Container: Yes
    Shell: 5.8.1 - /usr/bin/zsh
  Binaries:
    Node: 19.8.1 - ~/.nvm/versions/node/v19.8.1/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v19.8.1/bin/yarn
    npm: 9.6.2 - ~/.nvm/versions/node/v19.8.1/bin/npm
  Browsers:
    Firefox: 110.0.1
  npmPackages:
    @sveltejs/adapter-vercel: ^2.3.1 => 2.3.1
    @sveltejs/kit: ^1.11.0 => 1.11.0
    svelte: ^3.56.0 => 3.56.0
    vite: ^4.1.4 => 4.1.4

Severity
blocking all usage of SvelteKit
Additional Information
No response

I can't reproduce this. Did you double-check that you don't filter out logs which prevents them from showing up? Else we need a proper reproduction.

@rehypothecation
I noticed this behavior as well in my project after I bumped my SveltKit recently.
Before this all of my console.logs were showing both server and client side. Then it was only server side.
Along with the bump my vite got upgraded from "^3.1.0" => "^4.2.0"
I see that you are using ^4.1.4
I did another Goog search and found the answer was to configure vite to keep client side logs by setting the build.terserOptions.compress.drop_console boolean option to false
https://github.com/vitejs/vite/discussions/8463
Here is another discussion on how to set it programmatically based on build type for your PROD builds (Which you may want to consider).
https://github.com/vitejs/vite/discussions/7920
Now I can see logs on both sides again.
Hope this helps!
@dummdidumm

Closing due to lack of reproduction

I can't reproduce this. Did you double-check that you don't filter out logs which prevents them from showing up? Else we need a proper reproduction.

Just realized the Console log filter bar stays the same across all browser tabs. Thanks!


Transition to versioned bids functions

Another large PR! The task ended up being more finicky than expected, but I'll try to justify some of my decisions below:
Version functions using configuration, rather than import
The versioned imports (e.g. import bids_v0_0_0 as bids) would have worked well in our snakemake context, where we typically directly import the bids function. However, it doesn't scale well to any other context. There's three particular problems to point out:

If bids() is only imported once, as in snakemake, all is well, but in a standard python project, where bids must be repeatedly imported, now you have to ensure you import the same version in every file
I'm hoping one day to have bids-like methods directly on BidsComponent that will derive new paths based on the old component. The versioned imports wouldn't help configure these methods.
The long-term goal is to move path building methods from snakebids into rsbids. rsbids will have a much more robust configuration system, and the versioned imports wouldn't fit well in it.

So I decided instead to make the bids spec globally configurable via snakebids.set_bids_spec. The function takes a spec object (importable via snakebids.paths.specs.vx_x_x()), or the string name of one of the official specs (e.g. "vx_x_x"). Obviously, this introduces non-pure, state-dependent behaviour for bids(), but I think this type of thing is very typical for configuration in python libraries (e.g. numpy, matplotlib, etc all use similar global config objects).
Dynamic generation of python code and interface files
In an effort to reduce the impressive levels of code duplication, especially docstrings, that would have been required for the versioned bids functions, I used a lot of dynamic importing in the path module. Basically, you can define __getattr__ directly in a module, and that will be used for dynamic imports.  Finally, to keep type checking working, I set up a script to automatically generate *.pyi files for the dynamically generated versioned functions.
And then... I decided to switch over to the configurable system. So now the above paragraph only pertains to the spec reading functions (in snakebids.paths.specs), which are still dynamically generated and versioned. So I'm keeping around all the code generation stuff, but if it seems like overkill, that's why.
Documentation updates
I did some reorganization of the documentation, converting the very flat structure into a more explicit "User guide" and "API" sections. The main api page has been subdivided into different subpages based on category. Unfortunately, the API is complex enough that I could no longer sanely rely on autogen to make the pages, so most of the main functions are explicitly list in the documentation source (although the "Internal" API page is mostly automatic). So something to keep in mind for future maintenance
Blanket deprecation of include_subject_dir and include_session_dir
My original idea was to keep these arguments only for the v0_0_0 spec and not have them for all future specs. But the logic to maintain that exception was getting too complex, so I decided to still keep those arguments for every spec, but deprecate them, with plans for removal in 1.0. I don't know that many people use these arguments anyway (maybe in some of @akhanf's workflows?)

Nice work! Haven't gone through what you've done yet, but looks really cool at a glance!
re: the deprecation of include_subject_dir and include_session_dir that sounds fine, I use it rarely enough that I am good to either keep those uses pinned to an early snakebids version, or adapt the code moving forward.. By the way, what is the preferred way to use e.g. the subject entity in a filename only and not in the folder?

At this point a custom spec:
bids_factory(specs.v0_0_0(sub_dir=False))(subject="001")

If you need such paths frequently, otherwise use Path(...).name.
Is that sufficient? We can consider a more privileged API if it's sufficiently useful, but I'm hoping the above methods are enough.

One other thing to discuss before this is ready, I still want the bids function to return a Path object rather than a string (if/when this gets ported over to rsbids, it would return a BidsPath). I know I tried this before and broke some workflows (probably because there's workflows doing + operations?). So one, do people think this is a worthwhile goal to begin with, and two, what would be an acceptable transition strategy? If we go with this, the two likely options would be 1) keep a permanent exception for the v0_0_0 spec, and 2) keep a str return until 1.0, and then hard switch everything. 1) is more permanent, 2) is much easier to implement

Wow - a lot of great work done here! Will wait for the "ready for review" before going through it.
To your discussion / questions:

I personally agree with returning a Path object, based on my own use. That said, I think this might be a discussion that is worth calling a dev meeting for to get some more opinions of others who are working with Snakebids.
I think if we are make the switch, trying to keep a permanent exception might be a softer transition. The hard switch I think may cause workflows to break unexpectedly when the Snakebids upgrade ultimately done as you noted from your previous attempts.

I think if we are make the switch, trying to keep a permanent exception might be a softer transition. The hard switch I think may cause workflows to break unexpectedly when the Snakebids upgrade ultimately done as you noted from your previous attempts.

Yeah, so with a hard switch, it definitely wouldn't be until 1.0. Basically any workflows that break with the change would have to pin their snakebids version until they can be fixed

Hmm, yeah, I guess I wasn't thinking about the type hinting too much there. The more I think about it, I think the hard switch is fine as long as we give ample warning (i.e. have a warning message now that this is going to change come 1.0).
I agree about the redundancy - I'd rather choose one path and go down that way.

Codecov Report
Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (d7a2a7b) 88.71% compared to head (02d07cb) 54.95%.

Files
Patch %
Lines

snakebids/utils/containers.py
70.87%
30 Missing :warning:

snakebids/paths/_templates/spec_func.py
88.63%
5 Missing :warning:

snakebids/paths/_utils.py
91.42%
3 Missing :warning:

snakebids/paths/_config.py
92.59%
2 Missing :warning:

snakebids/paths/_factory.py
98.92%
1 Missing :warning:

snakebids/paths/specs.py
96.29%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #349       +/-   ##
===========================================
- Coverage   88.71%   54.95%   -33.77%
===========================================
  Files          30       36        +6
  Lines        1489     1656      +167
===========================================
- Hits         1321      910      -411
- Misses        168      746      +578

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@kaitj, I expanded on the discussion of bids specs in the documentation. It's definitely not perfect: I don't discuss custom specs, and it's really too much prose now to be in the API section. I'd like to leave addressing of these imperfections for another time though, as mentioned above, the docs will likely be evolving quite a bit moving forward anyway.


PyPI release

I'd love to try it out, but rather ironically it isnt on PyPI

and now it actually is, but very little information such as this :-


MNT: rerender

Hi! This is the friendly automated conda-forge-webservice.
I've started rerendering the recipe as instructed in #27.
If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!
Here's a checklist to do before merging.

[ ] Bump the build number if needed.

Fixes #27

@conda-forge/kvxopt This is done to have a build against libosqp==0.6.3, see https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/4494#issuecomment-1564098548 . The PR is ready for review, you just need to bump the build number, and then it is ready for merge, thanks!

Merged...
@traversaro thanks!! 👍


feat(diff): autojump

centralized configuration
Signed-off-by: Aaron Pham<EMAIL_ADDRESS>

some code conflicts

Done


docker container app doesn't work in dev mode

db doesn't work. it expects 10 postgress.
after changing on 10 postgres in dev mode ui shows this:

Does it work in non-dev mode?  I saw the same screen as a symptom that webpack wasn't running.
What are the errors from the superset_node container?

@wrschneider I won it, I changed path on 25 string on
BASE_DIR = '/usr/local/lib/python2.7/dist-packages/superset/'
in setup.py file, but i have some problems on UI.

me too

Indeed, I would try the non-dev docker-compose file, as the dev one pulls from master and you might get random problems. This is likely fixed by now, and is pretty out of date if not. If people are still encountering this in current versions (3.x) please open a new Issue or a PR to address the problem.


How to debug dependencies versioning issues? Execution failed for task ':app:transformClassesWithDexForDebug'.

Steps to Reproduce
Follow the codelab tutorial for flutter firebase.
Then try installing firebase_messaging at its latest version:
pubspec.yaml content:
dependencies:
  flutter:
    sdk: flutter
  image_picker: 0.1.1
  google_sign_in: 0.3.1
  firebase_analytics: 0.0.4
  firebase_auth: 0.2.0
  firebase_database: 0.0.12
  firebase_storage: 0.0.5
  firebase_messaging: 0.0.7

Logs
$ flutter run --debug
Running "flutter packages get" in grablunch...
Launching lib/main.dart on Android SDK built for x86 in debug mode...
Initializing gradle...
Resolving dependencies...
Running 'gradlew assembleDebug'...

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:transformClassesWithDexForDebug'.
> com.android.build.api.transform.TransformException: com.android.ide.common.process.ProcessException: java.util.concurrent.ExecutionException: com.android.dex.DexException: Multiple dex files define Lcom/google/android/gms/internal/zzben;

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
Gradle build failed: 1

Flutter Doctor
[✓] Flutter (on Linux, locale en_US.UTF-8, channel alpha)
    • Flutter at /home/dori/Projects/personal/flutter/flutter
    • Framework revision e8aa40eddd (4 weeks ago), 2017-10-17 15:42:40 -0700
    • Engine revision 7c4142808c
    • Tools Dart version 1.25.0-dev.11.0

[✓] Android toolchain - develop for Android devices (Android SDK 26.0.2)
    • Android SDK at /opt/android-sdk
    • Platform android-26, build-tools 26.0.2
    • ANDROID_HOME = /opt/android-sdk
    • Java binary at: /opt/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b01)

[✓] Android Studio (version 3.0)
    • Android Studio at /opt/android-studio
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b01)

[✓] Connected devices
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 8.0.0 (API 26) (emulator)

Question
The Dex exception error is incomprehensible.  After figuring out that the issue arose when adding the new dependency, I blindly tried older versions of firebase_messaging until the version 0.0.4 stopped raising the error.
The error Multiple dex files define Lcom/google/android/gms/internal/zzben suggest that firebase_messaging in addition to another dependency define that file. Is there a way to track back what package it is ? In javascript, the lock file shows related dependencies... is there a way to show related dependencies in dart ? Are there good practices on how to upgrade packages ? (I was surprised that the codelab tutorial keep using seemingly old versions for the firebase packages).
Thank you for your help!

@AdrienLemaire
The issue at https://github.com/flutter/flutter/issues/13079 has been closed and moved here. Future collaboration on this issue will be done here.

https://github.com/flutter/flutter/issues/13079#issuecomment-544593641


[SR-13334] A target should record the tools version of the package that declares it (so it can affect build semantics)

A package's declared swift tools version determines not only the API that is available to the package manifest, but also the semantics used for the target at build time.  This could include how a Clang target's headers are represented in an automatically generated module map, etc.  The idea is that, as new build features are added (e.g. additional compilation flags, etc), whether or not they apply to a particular target can depend on the swift tools version of the package that declares it.  This lets older packages continue to build the way they have in the past without needing to be updated.
Currently, targets in the SwiftPM package model don't record the declared tools version of the package manifest from where they came.  This change plumbs that information through from the package, so that it is available to the build plan and libSwiftPM clients.
There is no semantic change in this PR, but it will enable fixes and new functionality where the semantics depend on the declared tools version of the package that defines the target.

What exactly do you need this for? PackageGraph is most likely the thing you're looking for if you want to get the tools version given a target. Note that PackageGraph interface is not currently optimized for fast target lookups but we can enhance that if there's a need. But we should avoid duplicating the information in the model.

This is prep work for finding a way to address https://bugs.swift.org/browse/SR-12758.  We should avoid unconditionally changing compilation flags that break existing packages, so the point is to conditionalize the semantics in BuildPlan to avoid breaking old packages.
Are you saying that the BuildPlan should ask the PackageGraph object for the tools version for a particular package?  What about clients of libSwiftPM?  Regardless of where we get the information from, it seems to me that a target should be able to answer the question of what version of tools semantics it wants.

The PR I've put up at https://github.com/apple/swift-package-manager/pull/2844 that makes the module map conditional on the Swift tools version declared in the package doesn't rely on this PR, but instead uses the package graph.  I'll put this PR into draft mode for now while we discuss which approach to take.  Either way, we should make sure that clients of libSwiftPM (such as Xcode) have access to this information as well.

Closing this PR since there is already a way to get this information from the PackageGraph.


webpack instead of gulp

till webpack got some solution for html import
https://github.com/webpack/webpack/issues/547
https://github.com/webpack/html-loader/issues/14


Fix 2 typos in documentation and comment

Fix the following typos found by misspell:
docs/tutorial.md:118:59: "availble" is a misspelling of "available"
pkg/appgw/appgw_test.go:251:21: "listners" is a misspelling of "listeners"

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: aerostitch sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for contributing @aerostitch


Update default omnibus ruby version to 2.2.2

Closing this for now. We'll bump the Ruby version post Delivery migration.


Upgrade UI Select provider screen

Describe the task
Upgrade UI Select provider screen

Design: https://www.figma.com/file/2nYhrm0rlJtfJoMwrT51Ep/SubWallet-Apps?type=design&node-id=2763-99866&mode=design&t=YG46YSeNKfRfArne-4

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-220-1031-merge-2023-09-21T07-57-29.ipa
Device test: IP 11

[ ] UI bug

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-220-1031-merge-2023-09-26T04-07-36.ipa
Device test: IP 11
Validation passed.


Invalid next.config.js options detected

With Next.j 13.5.6 and node v18.18.2
 ⚠ Invalid next.config.js options detected:
 ⚠     Expected string, received number at "env.nextImageExportOptimizer_quality"
 ⚠     Expected string, received boolean at "env.nextImageExportOptimizer_storePicturesInWEBP"
 ⚠     Expected string, received boolean at "env.nextImageExportOptimizer_generateAndUseBlurImages"
 ⚠ See more info here: https://nextjs.org/docs/messages/invalid-next-config

Using default configs copy-pasted from repo readme.

Same issue here


Add IOE

Official website of IOE : https://ioe.edu.np/

@otsab19 Pull request merged. Thank you!

Thanks.


GAMMA: Consider a "from" and "to" in route references

https://github.com/kubernetes-sigs/gateway-api/pull/1493#discussion_r1018372989 had a lot of discussion about possible extensions to the matching API. However, they were out of scope on the PR for now, so moving to an issue

Thanks for opening this! I brought this up in the GAMMA meeting that happened on the 17th. John said this might be an optional thing since not all meshes may be able to implement these extensions in the matching API. I wanted to re-iterate on (and document) what our needs are, and what we'd like to see. Most of this is copy & pasted from the original thread.
In #1493 we changed the spec to allow for a hierarchy in routes. Routes defined in a consumer namespace that attach to a Service will take precedence over routes attached to the same Service that exist in the producer namespace. For the majority of cases, this is fine. This does imply that the route, and any policies that apply to that route (or the targeted Service) will apply for all workloads in the consumer namespace.
On the Linkerd side, we'd like to have a bit more flexibility and limit the behaviour to only a subset of pods. There might be situations in which our users will need to enforce different policies for consumers in the same namespace. We were thinking this could be addressed with a resource that captures the Consumer-to-Service binding relationship. Something between ServiceBinding and ServiceProjection (although projection probably fits better as a model and name). For example:
spec:
  consumerRefs:
    - group: apps
      kind: Deployment
      name: web
  providerRef:
    kind: Service
    namespace: backend
    name: emoji
status:
  conditions: ...

The resource describes traffic originating from a consumer workload (deploy/web) to a producer service (service/emoji). The status is added in for conflict resolution.
This is similar to @michaelbeaumont's idea, at least conceptually. In the write-up, it was mentioned that

In the mesh case, it's important to be able to talk about the source of a request when doing traffic routing. That's what the idea of consumer/producer routes in this PR expresses. A consumer route is "only requests from this namespace" and a producer route is "requests from anywhere in the mesh".
The PR gives the Namespace of an HTTPRoute the ability to scope a route based on source of a request. But doing this also answers the question of who can attach to a Service as a consumer/producer.

The post goes on further to say:

Is there a way to answer these two questions less implicitly/separately?

And suggests a to and from tuple in the parentRef. I believe this would also work for our use case. Regardless of how this is solved, think it's important to at least discuss it in a more official setting.
@kflynn not sure if you have anything additional to say. Corrections are more than welcome. Thanks in advance!

Continuing discussion from the original thread:

SHOULD allow control by the cluster operator (mesh administrator) to grant permission for whether HTTPRoute resources in a given namespace are allowed to configure mesh traffic routing.

This doesn't feel covered yet, right?

My interpretation of this was that this would be achieved by either Kubernetes RBAC (users not being given permission to create HTTPRoute resources) or namespace "enrollment" of some sort (allow/deny list of namespaces in something like a cluster-scoped Mesh CRD) - I was not expecting that cluster admins would likely to be authoring HTTPRoute resources.

Following from this, I think limiting the to targeting for producer routes and from targeting for consumer routes to same-namespace is relatively important for keeping configuration local/discoverable and reducing surprises (config from an arbitrary third namespace should likely not be modifying requests unexpectedly), but agree that making these roles more explicit could be potentially improve the UX.
Limiting the scope of consumer routes to only requests coming from a specified workload does feel like a use case we should aim to support, and I think this narrower scope somewhat overlaps with use cases that would benefit from a layered (consumer then producer instead of consumer or producer) application as described in https://github.com/kubernetes-sigs/gateway-api/pull/1493/files#r1034985599
Limited-scope producer routes feel less useful, but I'd be curious to hear any specific use cases. Limited-scope producer policy, such as further constraining timeouts or retries from a specific consumer does feel important for isolating abusive consumers, but that's a bit different scope from routing I think.

/remove-lifecycle rotten


Expose GDAL driver metadata

Would we want something like this in fiona: https://github.com/Toblerity/Fiona/pull/950 ?
It would allow to check the extension of a driver (and making the driver inference from the extension for writing more robust, cfr https://github.com/Toblerity/Fiona/pull/948), the open options, whether the driver supports certain data types, etc (but it would probably be mostly copy/paste from fiona ..)

Sounds like it is at least somewhat linked to #81 and #71

linked to https://github.com/geopandas/pyogrio/issues/81

Yes, if we have this, it could indeed be used for #81. But I think it's also certainly fine to already do something about #81 without this feature (this issue is also meant for user facing API, while for the tests we can hard-code a bunch of things on the short term)

I wonder if it would be possible to get more driver metadata into gdal... this way it is available centrally instead of having copies of this metadata in every python library + in every other programming language.

Which additional information are you thinking about? (the current GDAL metadata already exposes quite a lot: extensions, which data types are supported, whether nulls are supported, ..)

Ah, OK, I wasn't aware of that. In that case, ignore my remark :-).

I started using the GDAL driver metadata internally in https://github.com/geopandas/pyogrio/pull/189, but without publicly exposing it for now.


Utilize getAsArray to ensure customSelectFieldAnswers is an array

Screenshot demonstrating this erroring previously:

This should correct this from happening and ensure that this.customSelectFields is always defined as an array and can be operated on as such.

 BUG: Error message when changing email address.


Sender "Color" wants to know why their submission is not being delivered.

Problem Statement
We received an email from Nick from the sender "Color" through the ReportStream inbox stating Color started submitting COVID results for Ohio 05/03/2023, the specific submission, "5899e299-2a60-42f9-bf80-e05a141ab87d", did not receive any errors, only warnings, but was not delivered to any destination. The history API has this record marked only as "received" even though it was sent yesterday.
What you need to know
Hello,
Thank you for looking into this. We also migrated our Ohio reporting to ReportStream and encountered an issue there we would appreciate if you could look into. Submission "5899e299-2a60-42f9-bf80-e05a141ab87d" has no errors, only warnings, but was not delivered to any destinations. It was bound for "oh-doh.elr" and the message is exactly the same as the message we would have sent them if not reporting through ReportStream. The history API has this record marked only as "received" even though it was sent yesterday.
Best,
Nick
Acceptance Criteria
Investigate why the submission is not receiving errors, only warnings, and why it was not delivered to any destination.
Let help desk know so we can relay the message to Color and if there is any alternative.
To Do
Assign to an engineer.
Additional Comments
If applicable, add screenshots, links, etc. to further explain the ticket

Update from sender:
For Ohio, we had another submission on May 10 (a60181a7-5899-47ed-b755-5be033c06a6a) which shows no errors, but also no destinations. The record still shows as "received" 2 days later now.
Commnication from James on 5/4/2023:
Looking into these two tickets for you and here is what I have so far.
1.) Ohio  (#9394) - Ohio has a filter to only pass positive results. I can reach out to them to check and make sure this is what they still want from us but we would have set the filter this way at their direction. It looks like you didn't get a response that this was filtered out though. I believe this is a bug because the filter is set on the org and you are using the routeTo functionaility which bypasses some of the routing process. I can start a ticket for this and have it investigated.

@GilmoreA6
Hi Jmes,
Nick reached out to the RS Support team for an update on this, and mentioned another occurrence:

For Ohio, we had another submission on May 10 (a60181a7-5899-47ed-b755-5be033c06a6a) which shows no errors, but also no destinations. The record still shows as "received" 2 days later now.

Thank you!

Hi Nick,
Apologies for the delay. Here are the updates.
VT:
I've deployed a hotfix that should resolve the issues. The issue was on our side and related to how we were handling some of the subfields in the provider fields (ORC-12-9 and OBR-16-9), also added some logic around ORC-4 due to that error. I've re-ran the messages through the new code and re-submitted to VT. I'll follow up with our contact at VT-DOH on Monday to make sure they processed correctly.
OH:
I've changed some settings around how the filters are working so that instead of not getting any response you should receive indication from the submission history api that those messages were filtered out because they did not contain an abnormal flag in OBX-8 (this is not retroactive and querying anything submitted to this point will still return no errors or destinations). I have an email out to Ohio asking if they would like us to change their settings as they are currently blocking results they (theoretically) should want according to their current guidance.  I will let you know when I hear from them.
Thanks,
James

Hi James,
Just following up about Ohio. We had submissions May 17-20 that seem to still be filtered with the abnormal_flag. Have you heard back from them? And when you do, will it be possible for you to resend these messages?
Please let me know if I can assist in any way.
Best,
Nick

Hi Nick,
I have not yet heard from Ohio. I will try to ping them again. I can resend anything that is still in our blob storage (60 days). Ohio did update it's guidance after the end of the PHE to align with other Class B reporting for Ohio, so I think there is a strong possibility they will elect to continue only receiving positive results.
Thanks,
James

Update from sender 5/23/23:
James,
Sorry, I misunderstood the issue here initially. I just looked and we did have a successful result go through to Ohio when there was a positive test result. That submission was May 12.
Everything looks good then. We're able to submit to them when there's a positive test, and then they're correctly (from their perspective) filtering negative results.
Apologies for the confusion. Thanks for looking into this and for the explanation.


updated  count

What does the program do ?

In what programming language it is written?

This pull request exeeds the max additions limit. Please fix it and reopen


NIFI-6811: Allow enterGroup to complete prior to loading CS table

NIFI-6811:

Allowing enterGroup to complete prior to loading the controller service table.

Reviewing...


Anime Extentions & Anime Backup

I created backup right before uninstalling previous update(I had to for some reason)..... then I installed the latest update, I imported the backup file.....except anime almost every thing was restored.....and then I was about to install the anime extentions...but there was nothing to install.....even refreshing did not helped.....there's just a blank page....😔

this was an issue with the latest automatically generated preview build. the new update will use an updated extensions library, but the update was accidentally released before it was ready.


nag-flaky-issue: Do not ping if no assignee

also improve the comment very slightly.

This change is

/lgtm


the results of DMS fitness in the ProteinGym benchmark

Thank you very much for your wonderful work. I have some questions about the verification of DMS fitness in the ProteinGym benchmark. I noticed that the "substitution DMS benchmark" in the ProteinGym benchmark contains 217 groups of proteins, but in your experimental verification, only the There are 63 groups of proteins, and only 46 groups of proteins have the same names. Can you provide us with how your ProteinGym data set is constructed and why it is so different from the original proteinGym?

Hi, thank you for you interest in our work!
The ProteinGym benchmark is actually its 1.0 version. The ProteinGym dataset used in our paper is the 0.1 version, which was mentioned in https://arxiv.org/abs/2205.13760. At the time this paper was submitted, such 1.0 version was not published yet, so we only tested on the older version.


slot cannot work in jsx ,how to fix it?

Version
3.0.5
Steps to reproduce
my jsx code:
<el-popover placement='right' width='300' trigger='hover'>
          {popoverContent}
     <el-tag key={item.teacherName} size='mini' slot='reference'>
         {item.teacherName}
     </el-tag>
</el-popover>

it work well in vue2, but cannot in vue3.  change to h function, it work.
h(
        ElPopover,
        { placement: 'right', width: '300', trigger: 'hover' },
        {
          default: () => popoverContent,
          reference: () => {
            return (
              <el-tag key={item.teacherName} size="mini">
                {item.teacherName}
              </el-tag>
            )
          },
        },
      )

What is expected?
I want to write slot in jsx not h funtion, how can i do it?
jsx is close template.
What is actually happening?
vue3 dont support  slot prop in jsx.

plugin vue-jsx

This is not related to Vue core, move to jsx-next


Yahoo Mail - Left Margins Missing

If you run this template through Yahoo Mail, you'll see that all the text runs right up to the left margin. It looks fine in other mail clients. Does anyone know how to fix this problem with Yahoo?

here is a screenshot of how it is appearing in Yahoo. You can see that the left margins are missing.

@dlc3172 what I usually do for testing is to experiment with developer tool (I use Chrome) by playing around with inline changes until it fits my design expectation ... then implement the code for real testing and comparing with other platforms.
Give that a try and let us know

Unfortunately, I'm not advanced enough to really know where to start. Do you have any suggestions as to what should be changed to maybe correct the problem? This must be a new problem with Yahoo, because I see in your code you originally tested your template with Yahoo.

@charlesmudy Unfortunately, I'm not advanced enough to really know where to start. Do you have any suggestions as to what should be changed to maybe correct the problem? This must be a new problem with Yahoo, because I see in your code you originally tested your template with Yahoo.

@dlc3172 by playing with the body,center tag mergins, paddings, width size e.t.c.

Has anyone figured out how to fix the problem with Yahoo Mail? I haven't been able to figure it out myself.


fix for issue #1075 - Update Dockerfile

This fixes issue #1075
The previous version of node referenced in the web-ui Dockerfile may have had outdated packages needed by the web-ui, as attempting to deploy the web-ui via Docker resulted in the web-ui not rendering the page.  Once I updated node to v12, the web-ui properly rendered the Zally editor.

Codecov Report

Merging #1078 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1078   +/-   ##
=========================================
  Coverage     84.75%   84.75%
  Complexity     1056     1056
=========================================
  Files           176      176
  Lines          2821     2821
  Branches        460      460
=========================================
  Hits           2391     2391
  Misses          187      187
  Partials        243      243

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be4ed04...4f1f175. Read the comment docs.

Going to open this PR back up with the suggested fixes.


DMCI insert should be changed to create

I.e., curl --data-binary "@<PATH_TO_MMD_FILE>" localhost:5000/v1/insert should be curl --data-binary "@<PATH_TO_MMD_FILE>" localhost:5000/v1/create
NOTE: v0.3 can have both insert and create but only create must be in v1.0 onwards.

Added alias for insert: create.


Add unmarshal and raw unmarshal

This PR is a fork of @TimothyStiles's #3 that adds an UnmarshalRaw function that can be used on raw SurrealQL responses returned by the Query function. I also added a couple of tests for the new function and cleaned up some of the warnings in db.go.
I'm fairly new to Go, so I'm not too familiar with the style of Go code. If my changes do not seem to follow standard Go style, I would be happy to refactor the PR.

I merged in recent changes from main and cleaned up a few things that shouldn't have been in there (my personal .gitignore additions, a useless call I added into one of the tests, etc).
I also changed all the anys to interface{}s to match the changes from #9. I think the errors being caused by any in #9 are caused by an old compiler (any was introduced in 1.18), but interface{} is probably better anyway for compatibility.
The switch / select statement indentation changes from #9 may not be the recommended Go style considering my formatter keeps trying to change them, but I kept them in there for the sake of not changing main.

Hey @garrison-henkle if you could rebase from main again. Then I'll get this merged!

@tobiemh It should be good now!

@tobiemh +1 for merge! I'm excited for this one.


Standardize bug, tournament, league, prize and other important strings in a single place for use by bot/site/etc.

It might be that the bot favors short text so much that sharing doesn't make as much sense as I thought when I opened this ticket.
I've "shared" the bug text but mostly in the sense of linking to the website and using the first sentence.


Add script to align submodule on branch

What does this PR do ?
This PR add a script to align all submodules on the same branch.
When a merge occur on *-dev or master branch, .ci/align-submodules-on-merge.sh will clone the same branch of the repo, align submodules on this branch, commit and push.
How should this be manually tested?
# Align submodules on the current branch name
./align-submodules.sh
# Align submodules on 1-dev branch
./align-submodules.sh 1-dev

Other changes

Add contributing

See my remarks about https://github.com/kuzzleio/sdk-java/pull/12

@benoitvidis and @scottinet I added the travis script to push aligned submodules when merging occur on master or *-dev branch. You may want to review this PR again


[JENKINS-31437] Assign properties to lockable resources and retrieve them in environment variables

(This replaces https://github.com/jenkinsci/lockable-resources-plugin/pull/295 with a simplified commit history)
This is pretty much https://github.com/jenkinsci/lockable-resources-plugin/pull/20 updated for HEAD - most of the credits go to @McFoggy
I recommend reviewing this after https://github.com/jenkinsci/lockable-resources-plugin/pull/294 since it will simplify the complexity of this PR. https://github.com/jenkinsci/lockable-resources-plugin/pull/294 adds an environment variable for each acquired locks when unlocking multiple ones, and this PR builds on this change.
The lock properties can be set on the lock definition in the System Configuration;
When setting a variable, the name of the variable is used as a prefix to also set an environment variable for each of the lockable resource's properties. For example:
lock(label: 'some_resource', variable: 'LOCKED_RESOURCE', quantity: 2) {
  // comma separated names of all acquired locks
  echo env.LOCKED_RESOURCE

  // first lock
  echo env.LOCKED_RESOURCE0
  echo env.LOCKED_RESOURCE0_PROP_ABC

  // second lock
  echo env.LOCKED_RESOURCE1
  echo env.LOCKED_RESOURCE0_PROP_ABC
}

We plan on using these properties to store information such as the IP, URL or an account to use with the lockable resource obtained.

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Link to relevant issues in GitHub or Jira
[x] Link to relevant pull requests, esp. upstream and downstream changes
[x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Please hold - this change exacerbates the randomness of the lock ordering in the env variable; I will fix the current issue in master first and fix here after

Ok - fixed. This change would have caused regression against https://github.com/jenkinsci/lockable-resources-plugin/pull/301

You desserve the revival or wakeup the deads badge ;-)
Congrats.

@gaspardpetit : given the comments in #301, is this PR good to merge already (e.g. for #303/#302 to build upon, if suitable) or better delay until you complete the bigger idea here first?

This one is ready to go, it's a nice improvement to the plugin already :)

If #307  makes it to the master branch, I am  now wondering if we need to output properties to environment variables - we could instead make it easy to findLocks on the locked resources, ex. findLocks() could return the build's locks by default and then we'd have the lock details in groovy objects instead of environment variables. Any opinion on this? It can still be convenient to set environment variables from locks, but can easily be done by the user, ex.
lock(label:'color_printer', quantity:1) {
  selectedPrinter = findLocks()[0]
  withEnv(['PRINTER_IP=${selectedPrinter}) {
    echo '${env.PRINTER_IP}'
  }
}

This would soft of make the variable not necessary anymore; this approach would also correctly handle the extra locks

Sounds cool, but I think one downside could be generally about scripted vs declarative pipelines. Although in this particular use-case, you "declare" that you want a selectedPrinter variable...
@abayer : if we might bother someone more keen on pure-declarative code for an opinion? ;)

The most problematic flaw I see with the existing design is that the result is unpredictable.
If you ask for a single lock, or N of a single lock label, it's fine. But when you mix the extra in the lot it gets messy. For example, if you ask for 1 resource matching label A and 1 extra resource matching label B, you may end up with 2 locks, one matching each requirement, or a single lock matching both.
This makes using environment variables for the result almost impossible because you can't predict how many locks you will actually get.
The findLocks approach is much easier since you can ask to find the lock that matched A and later find the lock that matched B - and perhaps you will get the same resource each time, maybe not... but you don't have to worry, each findLock will give you what you expect.
If we do continue with environment variables, we will need to define very well how the extra should be handled, especially when they request the same variable name...

Hi @gaspardpetit, in case you couldn't tell, I'm more of an interim maintainer than a maintainer for this plugin. If you want commit access to be able to merge and release PRs for this plugin, feel free to file a repository-permissions-updater and I'll approve it.

Sorry about mostly falling out of the loop, recent months were hectic :\ Hope to catch up in the coming weeks...

@basil no worries, I understand - I find this plugin useful and I have java experience, so I'd be happy to give a hand on reviewing and approving some of the PR; Sorry for asking, I have never before asked for such permission, can you explain how I can request  "repository-permissions-updater" permission on github?

Hi @gaspardpetit, I highly appreciate your contributions to this plugin. This page documents the procedure; namely, submit a PR on the "Repository Permission Updater" (RPU) repository. Feel free to at-mention me on the PR and I will approve it. Once you have commit access, you will be able to merge PRs and perform releases. Feel free to reach out to me or any other members of the Jenkins core development team if you have any questions about Jenkins plugin development that are not answered in the Jenkins developer reference.

Hi @gaspardpetit, are you still interested in adopting this plugin?

+1 from me, hectic time here switching from one job to another to another... too long without a laptop of my own :\

@gaspardpetit are you still interested to conrtibut?

Yes, even though my time will be limited I'm happy the help. I still haven't figured out how to request the role though 😅

I am one of the owners now. And very interested to improve this plugin (now).
It will be fine, when we can merge some of your PRs. There are some great ideas. But I am not sure what shall be the best way.

Maybe you can allows to update your PRs by other developers. So I can remerge it with current master branch. (like this https://github.com/eidosmontreal/lockable-resources-plugin/pull/1)
When you want, I can add you (or request it for you) to be also a owner of this repo.
Or I bring your changes via new PRs like this https://github.com/jenkinsci/lockable-resources-plugin/pull/392 and can add you as reviewer.
Also it will be great when you looks sometimes into open PRs.

I try to do my best, but I am still missing some other developers here. Approve own changes without review makes no sense.
I think when we merge currently opened PRs and solve some issues, the maintenance here will be fine. It looks terrible at the moment.


Adds a simple HLS video player to DatoCMS example

This enhances the DatoCMS example to include a "Video Upload" record on a "Post" and then using HLS.js to set up a simple video player client side.
Here's what is looks like on the client side

And this is what it looks like in the CMS:

Hi @dylanjha Thank you for the PR. Can we create an official example for hls instead? something like with-media-hls or with-hls-video
Background for this is that the changes introduced are more complexity added to the example, and this example follows the same layout used for the other CMS examples.

@lfades thanks! I created with-hls-js in #12727, let me know what you think!

Closing in favor of #12723


Can not compile on Arch Linux with pulseaudio backend.

Hello i have a problem compiling librespot with pulseaudio backend.
Errorlog:
Compiling unreachable v1.0.0
Compiling base64 v0.5.2
Compiling shannon v0.2.0
error[E0503]: cannot use state because it was mutably borrowed
--> /home/kinau/.cargo/registry/src/github.com-1ecc6299db9ec823/getopts-0.2.14/src/lib.rs:1008:33
|
955  |     let mut machine = |cont: &mut bool, (i, c): (usize, char)| {
|                       ---------------------------------------- borrow of state occurs here
...
959  |         state = match (state, whitespace, limit) {
|                        ----- borrow occurs due to use of state in closure
...
1008 |     while cont && match state { B | C => true, A => false } {
|                                 ^ use of borrowed state
1009 |         machine(&mut cont, (fake_i, ' '));
|         ------- borrow later used here
error: aborting due to previous error
For more information about this error, try rustc --explain E0503.
error: could not compile getopts.
warning: build failed, waiting for other jobs to finish...
error: build failed

What version of Rust are you on?

I am on rustc 1.39.0 (4560ea788 2019-11-04)

Not sure why you have such an old version of getopts though - 0.2.14 is from 2015. Current Cargo.lock uses 0.2.19.

idk too. i just git cloned it. After that downloaded cargo via pacman -S cargo rustup and then tried to compile it.

We recommend using rustup directly,  from https://rustup.rs/.
You normally don't need to install cargo separately, as its bundled with rustup

yeah idk anything about rust.  Built on 2019-11-09. Build ID: BGt9RQk2
Available Backends :

portaudio (default)
rodio
pipe

`

You still have the wrong repo - portaudio hasn't been default for quite a while now..  I thought it will get install instantly. but i needed to get the binary. Well sorry D; but thanks for pointing that out.


docs(unstable): Improve nightly link

Unlucky?
let's see
---- freshness::rebuild_tests_if_lib_changes stdout ----
running `/Users/runner/work/cargo/cargo/target/debug/cargo build`
running `/Users/runner/work/cargo/cargo/target/debug/cargo test`
running `/Users/runner/work/cargo/cargo/target/debug/cargo build -v`
running `/Users/runner/work/cargo/cargo/target/debug/cargo test -v`
thread 'freshness::rebuild_tests_if_lib_changes' panicked at tests/testsuite/freshness.rs:633:10:

---- expected: tests/testsuite/freshness.rs:623:27
++++ actual:   stderr
   1    1 | [DIRTY] foo v0.0.1 ([ROOT]/foo): the dependency foo was rebuilt ([TIME_DIFF_AFTER_LAST_BUILD])
   2    2 | [COMPILING] foo v0.0.1 ([ROOT]/foo)
   3    3 | [RUNNING] `rustc --crate-name foo [..]
   4      - [RUNNING] `rustc --crate-name foo [..]
   5    4 | error[E0425]: cannot find function `foo` in crate `foo`
        5 +  --> tests/foo.rs:4:34
   6    6 | ...
   7    7 | [ERROR] could not compile `foo` (test "foo") due to 1 previous error
   8    8 | ...∅

@bors r+

:pushpin: Commit dc53eb2f5928e84104828a3629c8e84ddc069bb8 has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit dc53eb2f5928e84104828a3629c8e84ddc069bb8 with merge 5ff9328cb4d79afb7badb7d5d8869c3611677cf7...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing 5ff9328cb4d79afb7badb7d5d8869c3611677cf7 to master...


fix remote retry localities

https://github.com/istio/istio/issues/33737
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
3754c940984d8cfb2c73c9d28253462bc53e2db7
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
6b85e4b7fd4b3cbb6609089159055f10d2e68ddd
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
6b85e4b7fd4b3cbb6609089159055f10d2e68ddd
link
/test gencheck_istio

integ-security-k8s-tests_istio
bbbd481dcecb0c0e2f46c2936c5997d18084deff
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
bbbd481dcecb0c0e2f46c2936c5997d18084deff
link
/test integ-security-k8s-tests_istio

gencheck_istio
bbbd481dcecb0c0e2f46c2936c5997d18084deff
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
bbbd481dcecb0c0e2f46c2936c5997d18084deff
link
/test integ-security-k8s-tests_istio

gencheck_istio
bbbd481dcecb0c0e2f46c2936c5997d18084deff
link
/test gencheck_istio

integ-pilot-k8s-tests_istio
bbbd481dcecb0c0e2f46c2936c5997d18084deff
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
bbbd481dcecb0c0e2f46c2936c5997d18084deff
link
/test integ-security-k8s-tests_istio

gencheck_istio
bbbd481dcecb0c0e2f46c2936c5997d18084deff
link
/test gencheck_istio

integ-pilot-k8s-tests_istio
bbbd481dcecb0c0e2f46c2936c5997d18084deff
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
bbbd481dcecb0c0e2f46c2936c5997d18084deff
link
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
bbbd481dcecb0c0e2f46c2936c5997d18084deff
link
/test integ-security-k8s-tests_istio

gencheck_istio
bbbd481dcecb0c0e2f46c2936c5997d18084deff
link
/test gencheck_istio

integ-pilot-k8s-tests_istio
bbbd481dcecb0c0e2f46c2936c5997d18084deff
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
bbbd481dcecb0c0e2f46c2936c5997d18084deff
link
/test integ-cni-k8s-tests_istio

integ-pilot-multicluster-tests_istio
bbbd481dcecb0c0e2f46c2936c5997d18084deff
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn @hzxuzhonghu Will add an integration test. Is there any test that can be modified to test this behaviour? I could not find any retry related to tests? Atleast it would be good to validate that this config is not rejected by Envoy if validating the remote locality retry is difficult (which might be the case I guess)

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
bbbd481dcecb0c0e2f46c2936c5997d18084deff
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
bbbd481dcecb0c0e2f46c2936c5997d18084deff
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
bbbd481dcecb0c0e2f46c2936c5997d18084deff
link
/test integ-cni-k8s-tests_istio

integ-pilot-multicluster-tests_istio
bbbd481dcecb0c0e2f46c2936c5997d18084deff
link
/test integ-pilot-multicluster-tests_istio

gencheck_istio
e367a599f6b7e85a0bf81053c68a3b93d3e2e20c
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The closest test is TestLocality. Its not easy to test retries I think.. not sure of any grat way

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
f784789acf715a24dd5fd25226a1a988632b65ef
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-multicluster-tests_istio

In response to a cherrypick label: #33793 failed to apply on top of branch "release-1.10":
Applying: fix remote retry localities
Using index info to reconstruct a base tree...
M	tests/integration/pilot/common/routing.go
Falling back to patching base and 3-way merge...
Auto-merging tests/integration/pilot/common/routing.go
CONFLICT (content): Merge conflict in tests/integration/pilot/common/routing.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix remote retry localities
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #33815


Intl-ICU: String.prototype.localeCompare(other) is 4x slower than with WinGlob

The simplest of microbenchmarks for proof:
const start = Date.now();
let result = 0;
for (var i = 0; i < 1e5; ++i) {
    result -= "a".localeCompare("A");
}
const end = Date.now();

print(`Elapsed: ${end - start}, result: ${result}`);

This takes ~22ms in WinGlob and ~100ms in ICU on my machine using jshost.exe x64_test_pogo

/cc @jefgen @dilijev


Implement large scale sparse multi-players simulations

That won't be easy. But I want to reimplement in Python and in my environment the code we wrote for our article Multi-Armed Bandit Learning in IoT Networks and non-stationary settings.
It will extend the multi-players evaluator class to a "large scale" sparse multi-players: instead of 10 players each activated at each time step, maybe 1000 are only activated 1/100 time steps...

Never had and will probably never have the time to work on this ; sadly.


Current Goal Search Function by name ,  Implement on Home Activity to search any existing goal

Current Goal Search Function by name ,  Implement on Home Activity to search any existing goal
[ Please contact on Discord with me before implement this ]
https://stackoverflow.com/questions/53991868/search-in-recyclerview-with-edittext
https://codinginflow.com/tutorials/android/recyclerview-edittext-search

I would like to work on this issue under JWOC ✌


feat: add c api for packed multiexponentiations (PROOF-877)

Rationale for this change
Add a c api function to compute multi-exponentiations in packed format.
This will allow us to more efficiently compute multi-exponentiations of scalars that take varying bit size, for example, a mix of 32-bit, 64-bit, and boolean scalars.
What changes are included in this PR?
Adds the function sxt_fixed_packed_multiexponentiation to blitzar_api.h.
Are these changes tested?
Yes

:tada: This PR is included in version 1.70.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Round1

Initial code refactor, creating template for unit tests, automation, and code style.

Do we want to delete these Sphinx files? I believe they might be useful later but @cthoyt can perhaps comment.
Regarding the questions about length and number of spaces limitations, these may be arbitrary for quick processing, but this would require checking in with Ben.

There should only be one docs/ folder per repo, and it should be at the top level. Since the one I PR'd is still there, then any other sphinx docs should be migrated there, and these can be deleted

@dnsosa would it be possible to make me an admin for this repo so I can make pushes to @yangjunqingqiao's fork and solve the rebase vs master problem? Otherwise I'd have to fork his fork and PR into his fork, wait for him to rebase against it, and possibly end up in a catch-22
As it is, there are 50 files in the diff and it's not possible to see what's actually changed

@dnsosa would it be possible to make me an admin for this repo so I can make pushes to @yangjunqingqiao's fork and solve the rebase vs master problem? Otherwise I'd have to fork his fork and PR into his fork, wait for him to rebase against it, and possibly end up in a catch-22
As it is, there are 50 files in the diff and it's not possible to see what's actually changed

@cthoyt The most recent commit should show just the files that I changed with regard to your previous code review comments (10 files changed). I'm not too familiar with code reviews in github so let me know if that's not the view for you and I can try cleaning up the branch again!

When we're judging a PR, we shouldn't look at individual commits, but rather the whole PR. The best practice is: before merge to squash all of the commits together into one. This allows people to make whatever changes they'd like during the development process whether they're small or large.
The reason I keep bringing up a proper rebase vs master is this number here:

When you click this tab to see what changes are being made by this PR, you see nonsense (copying the changes made in other commits). We can't do a good job reviewing with this because it's not only distracting, but makes it impossible to tell what this PR would actually do if changed. Please let me know if this still isn't clear (there are tons of articles about rebasing vs. master. if you're having trouble finding one with google let me know and I can pick one for you)

@cthoyt I've added you to the repo with Maintainer privileges, which is what I've given to all the project leads. Will pushing to @yangjunqingqiao's fork require full Admin privileges or should Maintainer suffice?

@cthoyt I finally understood what you meant by your first comment. Instead of rebase I created a new branch and squash merged with master back onto the original Round1 branch. This commit also contains the changes I commented on your new PR.

@yangjunqingqiao well if there's a history of comments and discussion then it's generally bad to start a new PR. for the purposes of reviews, it's also nice to have the commit history. However, github has the "squash and merge" option which is best for project management (so squashing gets done after everyone is happy with the code)
So what will you do next?

@cthoyt In that case then I think it would be best to have a final review on the last squash commit I made and push this PR after everyone is happy with it. I also added the changes that I commented on your round1-reset branch.

I'm definitely not doing something right, I've already rebased wrt to master and squashed the commits from the branch but it's still showing the old files changed. I need a bit of time to figure out what's going on

Figured it out, according to this, the target branch determines the diffs seen in the PR screen. Since Round1 wasn't up to date with main before the PR no amount of rebasing would fix the issue as the upstream Round1 branch does not have those changes.
The solution is to change the target branch to main to filter out files that were not modified for this specific PR (I tested this with @cthoyt 's last rebasing PR by swapping his target to Round1 and it also still tracks the commits already made to main).

@yangjunqingqiao  looks like there's a problem with the automated checks - it's looking for there to be a "branch". Maybe you have to activate Travis-CI on your personal GitHub account? Try going to travis-ci.com and signing up, and see what it looks like at https://travis-ci.com/github/yangjunqingqiao/task-vt. Otherwise, we can ask @dnsosa to merge with admin powers

Currently trying to debug, apparently it's a known issue.
I have Travis CI enabled on my fork already I think it's an issue with the branch protection settings on main. Going to try switching the target to Round1 and see if that passes.

Weird, Travis CI is setup for the fork but my fork doesn't seem to b

@dnsosa I think we might have to just override the branch check. It seems that it's currently an unresolved recurring issue with travis-ci.

@yangjunqingqiao 🎊🎊🎊🎊 it's done :)

@cthoyt Thanks for all the feedback and help, I learned a lot!


Use trace server manager with Open Trace command

When the command 'openTraceFolder' is invoked from the Open Trace button, change the order so that the user is first prompted to select a trace folder. In order to do this, the openDialog() method is exported and is no longer called from the fileOpenHandler() method.
Use the selected trace to start the trace server using the trace server manager, which will select the proper contributor to start the server, based on the trace path.
Remove the execution of 'start-if-stopped' command from the startTraceServerIfAvailable() method, and make its pathToTrace parameter mandatory.
The fileOpenHandler() method is called last, and its traceUri parameter is now mandatory.
Fixes #183.

https://github.com/eclipse-cdt-cloud/vscode-trace-server/pull/16 should be merged before this one, otherwise the vscode-trace-server will fail to start as it won't be registered as a trace server manager contributor.


nacos2.0.0 adapt

// Describe your PR here; eg. Fixes #issueNo
issue #1188

Make sure that:

[x] You have read the contribution guidelines.
[x] You submit test cases (unit or integration tests) that back your changes.
[x] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #1189 (58c28f7) into master (22557c6) will decrease coverage by 0.44%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1189      +/-   ##
============================================
- Coverage     70.41%   69.96%   -0.45%
+ Complexity     2079     2074       -5
============================================
  Files           372      372
  Lines          8230     8230
  Branches        891      891
============================================
- Hits           5795     5758      -37
- Misses         1993     2031      +38
+ Partials        442      441       -1

Impacted Files
Coverage Δ
Complexity Δ

...soul/client/tars/TarsServiceBeanPostProcessor.java
47.56% <0.00%> (-35.37%)
10.00% <0.00%> (-4.00%)

...omara/soul/sync/data/http/HttpSyncDataService.java
49.01% <0.00%> (-16.67%)
10.00% <0.00%> (-2.00%)

...oul/sync/data/http/refresh/DataRefreshFactory.java
91.66% <0.00%> (-8.34%)
4.00% <0.00%> (-1.00%)

.../soul/admin/service/impl/UpstreamCheckService.java
65.42% <0.00%> (+9.34%)
17.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22557c6...58c28f7. Read the comment docs.

whats the modify?

@naah69 I don't understand the meaning of your modification, Can you explain it to me


Fix nuspec to make it clear what's going on

this should fix downstream usage: https://github.com/fsprojects/Paket/issues/2072

Closing because linked Paket issue does not seem to be related to this project.


Add notifier for "close" wars.

Let a channel decide what a close war/conquest is, but bot should be able to notify channel of a "close" war/conquest as defined by point difference and time.  Optionally, the bot should "ping" users in the room who have been inactive in the war or a specified amount of time.

No more use in implementing this


Remove submitted from individual form steps in payment provisioning component

Remove submitted from individual form steps in payment provisioning component
This PR modifies the submitted event behavior of the payment-provisioning component to only emit at the very end of the form after the provisioning request has been completed.
Links
Closes #716
Developer considerations

On any task

[X] Previous unit and e2e tests are passing
[ ] Perform dev QA on Chrome, Firefox, and Safari

Developer QA steps

[x] submitted event no longer emits on each form step.
[ ] submitted event emits at the end of the form's final step with the response from the provisioning request

I did one commit fixing a typescript error that was happening to me. Basically I remove onSubmitted on the last step.
If that was the intention we can revert that.
Also, the last step was not emitting the submitted event. Is that alright?


Add Tsiveriotis Fernandes Lattice Engine

Add the  Tsiveriotis Fernandes Lattice Engine for Convertible Bonds
Also added the Convertible Bonds example, ported from Quantlib

@amaggiulli has the final say, but I noticed some issues.
ConvertibleBonds.csproj has to be in the new .NET Core format. Look at https://github.com/amaggiulli/QLNet/blob/develop/src/Bonds/Bonds.csproj for an example. This is currently causing the CI build to fail.
Also, I suggest that you clean up the commit history.

And congratulations on your first pull request!

Think error is for msbuild-sonarqube-runner version 2.3, I'll fix now and retry

@amaggiulli But still the new .csproj file should probably follow the current pattern for the example projects?

@igitur correct , must be Net Core

SonarQube analysis reported 32 issues

 3 critical
 26 major
 3 minor

Watch the comments in this conversation to review them.
4 extra issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 bsmlattice.cs#L26: 'T' is not used in the class.
 bsmlattice.cs#L110: Make 'discount_' 'readonly'.
 bsmlattice.cs#L111: Make 'pd_' 'readonly'.
 bsmlattice.cs#L111: Make 'pu_' 'readonly'.

AppVeyor build fixed and is good , @maittaeb some work to do anyway , you can ignore 'readonly' issues but the others have to be fixed. Example project must be done in the new csproj format and remember to run format_code.bat before merging. Finally squash your pull request to not have all synch commits , if you need help on this you can ask @igitur to help you . Have fun !

Okay thank you, I'll try to figure out the issues you mentioned.
Le mer. 12 sept. 2018 à 23:52, Andrea Maggiulli<EMAIL_ADDRESS>a écrit :

AppVeyor build fixed and is good , @maittaeb https://github.com/maittaeb
some work to do anyway , you can ignore 'readonly' issues but the others
have to be fixed. Example project must be done in the new csproj format and
remember to run format_code.bat before merging. Finally squash your pull
request to not have all synch commits , if you need help on this you can
ask @igitur https://github.com/igitur to help you . Have fun !
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/amaggiulli/QLNet/pull/217#issuecomment-420810179, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AjU8M45r0M89QyoOOR1FyaUGyQ_ra97cks5uaYIJgaJpZM4WlZqu
.


Add pytest-sugar plugin

In addition to adding pytest-sugar, this also updates dependencies (updates websocket-client).
See my branch for unit test status, though this shouldn't affect that (our CI doesn't use the pytest runner).

I haven't merged this yet, because I'm unsure if this gives an overall experience, on our code and in the way we and others may be likely to use it, than pytest without the plugin.

Even with --color=yes, I can't get pytest output from tox runs to be colorized on Windows, when using pytest-sugar. It does colorize when not run with tox on Windows and Ubuntu, when pytest-sugar is not used on Windows or Ubuntu, and with tox and pytest-sugar on Ubuntu. Getting pytest output in tox runs to colorize at all requires --color=yes, but with pytest-sugar this has no effect.
When pytest is run without --force-sugar in tox, the pytest-sugar plugin is loaded, but it has no effect. Maybe that is related. --force-sugar is only needed when both the platform is Windows and pytest is run via tox.
Since I can't get that working, and there is useful color without pytest-sugar, I will close this PR unmerged unless I figure something out soon.


docs: fix go install command

What
fix go install command
Why
go install github.com/k3d-io/k3d@latest failed
Implications
install v5 by default

Thank you!


Spanish Translation

Added spanish translation

@codeofsumit
I'm new at this, i want to help with the spanish translation. I make it but the test fails, what i need to do?

@JeremyOL the failing tests are a problem with the testing framework right now. I'm on it


modifying the documentation as per Issue#1903

incorporated the review comments.

:+1: for me. @rasahner are you cool with the changes

+1

@rohitkochar Just realized we'll need a CLA: druid.io/community/cla.html

CLA done.


safe-guard against signs/balloons user settings

see #113

sweet :)

just realized that we don't need to check if it has('balloon_eval') again..


Windows7: Uncommon sprite drawing offset

Rarely when drawing a sprite the sprite actually drawn is offset by +1 on the y-axis. That is, the coordinate to sample the sprite from on the sprite-sheet is offset, not where it is drawn on screen. It is a consistent error-- that is, it will continuously happen if the drawing conditions are not changed. For example in the screenshot I took below, as long as I did not move my internal camera position on the y-axis, it would continue to draw the sprites offset by 1px from the correct spritesheet coordinates.

Does not seem to happen on android however.

Is this still happening at the latest nightly build ? because I added math.floor to most drawing functions..

Uh, that's a common graphical issue... Can be solved by using canvases in love2d, flooring the camera position or sprite padding, but that's not doable in your context :X

Does this still happen ?
If it does, try to add math.floor

I haven't experienced it for a few versions now, I think this can safely be closed


Moved get-tested setup to own workflow

This way it can be reused if one does need it in other places and not only for build matrix generation.

@mmhat Is there a concrete use-case for this? I have to admit I can't think of one and thus it's a bit hard to justify keeping it around if nobody uses it.

@Kleidukos  Consider a mono-repo like https://github.com/dhall-lang/dhall-haskell:
There, we have the dhall library in one Cabal package and some other packages like dhall-json, dhall-toml, ... that depend on the dhall library. Each of the packages might have different tested-with stanzas, and ideally we want the workflow matrix take the versions of all packages into account. Let's assume the following (version numbers are made up):

The dhall package has GHC ==9.6.6, GHC ==9.8.2, GHC ==9.10.1 in its tested-with stanza
The dhall-json package has GHC ==9.8.2, GHC ==9.10.1 in its tested-with stanza.
The dhall-toml package has GHC ==9.6.6, GHC ==9.8.2 in its tested-with stanza.

For the latter two contain only a subset since there might be additional dependencies that don't support some the GHCs listed in the stanza of the dhall library. So, how should the test matrix look like?
Since the mono-repo is acutally quite costly to build we don't want a matrix for each package.
Currently the Dhall project has one matrix build and excludes certain packages in jobs using Shell conditionals.
What I'd like to try is doing something similar using get-tested (in fact, that also motivated #49 and #50):

Generate a build matrix including the versions of all packages in a project.
Fetch the get-tested executable in the matrix job (this PR).
Then in a step:for package in PACKAGES; do
  if get-tested check "${package}" ${{ matrix.ghc }}; then
    DO_SOMETHING
  fi
done

Does that make sense?

I see. In servant get-tested is used on the servant.cabal file, which is the foundation for all other packages in the repository, and thus gives the widest possible support window for other packages: https://github.com/haskell-servant/servant/blob/master/.github/workflows/master.yml#L20

@mmhat I'm going to merge it. Can you test in some of your projects by specifying the commit in the uses: stanza?

@Kleidukos Yes, I can do that; But I also included a workflow test-action.yml that does checks that here: https://github.com/Kleidukos/get-tested/blob/1a77bbcf38be7d4136194760083325cce6751aec/.github/workflows/test-action.yml#L30


(django 1.8.6 mezzanine 4.0.1) need help to change the mezzanine admin language to local.

Hi,
I have try many settings but part of mezzanine admin still English.
LANGUAGE_CODE = "zh-HANS"
LANGUAGES = (
     ('zh-hans', _('Chinese')),
 )
USE_I18N = True

and

```python
LANGUAGE_CODE = "zh-CN"
LANGUAGES = (
     ('zh-cn', _('Chinese')),
 )
USE_I18N = True

but the part of admin page still English , and I find the locale file contain this word.
![image](https://cloud.githubusercontent.com/assets/5665818/11497580/e8288d6a-9854-11e5-8e0e-679a6be0a9d1.png)

anyone can give me some tips ? thanks very very much.

Can you post this to the mailing list instead?


doesn't send transaction to the server

On transaction form, create a transaction JSON and send it to the Connector. Show transaction id on a new screen.
https://github.com/ethereumproject/wiki/wiki/JSON-RPC#eth_sendtransaction

Closed with PR #20


Allow selection of GPU\CPU for calculations

It would be great to be able to run xgboost on GPU to reduce processing time

see #436


refactor(transformer): prefer create_bound_reference_id to create_reference_id

#6282  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite


GH-36396: [R] Non-existent functions called in array tests

Closes GH-36396
Closes: #36396

Could you use our pull request description template instead of removing it next time?

Could you use our pull request description template instead of removing it next time?

Sure!


fix: [UAT] listed issue 8

Fix #159
Test URLs:

Before: https://main--delta--hlxsites.hlx.page/us/en/skymiles/how-to-earn-miles/overview
After: https://issue-159--delta--hlxsites.hlx.page/us/en/skymiles/how-to-earn-miles/overview

Looking at a page like https://issue-159--delta--hlxsites.hlx.page/us/en/skymiles/how-to-earn-miles/earn-with-delta, I think the solution doesn't really work well.
And looking at https://issue-159--delta--hlxsites.hlx.page/us/en/skymiles/medallion-program/how-to-qualify which was the page with the issue, I think we should rather fix the CSS for:
.skymiles .default-content-wrapper p:first-child:has(strong) {
  margin-top: 3rem;
}


Add a hint that "Client credential grant" doesn't return a refresh token

It would be nice to have a hint, that the "Client credential grant" doesn't return a refresh token.
You mention this for the "implicit grant", why not also for the "Client credential grant" ?
https://docs.microsoft.com/en-us/azure/active-directory/develop/v2-oauth2-implicit-grant-flow#refreshing-tokens

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d32f55ac-acbc-292b-d1b7-ffdd257b11e1
Version Independent ID: ae2a266c-051b-7307-93fd-74bc521c93bf
Content: OAuth 2.0 client credentials flow on the Microsoft identity platform - Microsoft Entra
Content Source: articles/active-directory/develop/v2-oauth2-client-creds-grant-flow.md
Service: active-directory
Sub-service: develop
GitHub Login: @nickludwig
Microsoft Alias: ludwignick

@DanielFlath Thank you for your feedback . We will investigate and update the thread.

@DanielFlath Another GitHub issue is opened for this same issue, reference: https://github.com/MicrosoftDocs/azure-docs/issues/94803, closing this as duplicate.


Fade do-group tree when hovering over a do-group instead of making it completely transparent

Hovering over a dogroup in the tree now makes the rest of the tree disappear, but this is quite distracting and looks glitchy.
A better UX would be to fade the rest of the tree instead of making it disappear

Was not properly linked and should have been closed by merging #781


feat: add null safe if pg ver >= 12

Some hosted dbs e.g. Google cloud sql will not allow updates to internal tables e.g. pg_catalog
This change rescues, cancelling transaction and warning that not null check was not performed.
This change adds a check for pg >=12.  If 12 then add null constrain is safe if not use workaround per https://habr.com/ru/company/haulmont/blog/493954/

Yeah, that is a problem. Thank you for the PR and reporting.
Unfortunately, we cannot silently just print a log message, because it will be for sure missed by developers and NOT NULL won't be added, which will lead to other surprises.
Besides that, if we a changing a type of the primary key and if we skip that query, then we will introduce a downtime on the last step - https://github.com/fatkodima/online_migrations/blob/f9eb505d7126b8d809eb319b9ff9a93e86da6937/lib/online_migrations/change_column_type_helpers.rb#L267-L269. We can not also use invalid check constraints imitating NOT NULL, see- https://github.com/fatkodima/online_migrations/blob/f9eb505d7126b8d809eb319b9ff9a93e86da6937/lib/online_migrations/change_column_type_helpers.rb#L243-L245
So, I am not sure how to best handle the case mentioned in the PR description with the original kinda hack, except suggesting people to upgrade to PostgreSQL >= 11.

Thanks for the prompt answer and the gem. I should have read the full class comments, I see the pg ver 12 clause and understand the logic better now.  I guess its upgrade time :)

Ok so looking at the code, in order to bypass the pg_catalog update  (pr server_version > 12) I would still need to add
if connection.server.version >= <IP_ADDRESS>
   execute(<<-SQL.strip_heredoc)
              UPDATE pg_catalog.pg_attribute
              SET attnotnull = true
              WHERE attrelid = #{quote(table_name)}::regclass
                AND attname = #{quote(tmp_column_name)}
            SQL
else
    ...
end

-- short-time exclusive lock
alter table foos
  add constraint foos_not_null
  check (bar1 is not null) not valid;

-- seqscan, but without exclusive lock, concurrent sessions can read/write
alter table foos validate constraint foos_not_null;

-- exclusive lock, but foos_not_null proves: there is no NULL in this column
-- so this alter table would be fast
alter table foos alter column bar1 set not null;
-- not needed anymore
alter table foos drop constraint foos_not_null;

Can you check latest changes please?

Perhaps using change_column_default for any pg cluster >=12  is slower. I guess an alternative would be to rescue and apply the logic in the rescue block e.g
if 12 then change_column_default
else re-raise

For pg >= 11:
if you are changing primary key type - that is already set via https://github.com/fatkodima/online_migrations/blob/f9eb505d7126b8d809eb319b9ff9a93e86da6937/lib/online_migrations/change_column_type_helpers.rb#L119-L120
if you change some other column's type - that is set via https://github.com/fatkodima/online_migrations/blob/f9eb505d7126b8d809eb319b9ff9a93e86da6937/lib/online_migrations/change_column_type_helpers.rb#L122
So columns are already NOT NULL if needed. That hack is only for pg < 11 and for primary key conversions only.
You may find also logging queries, which are executed, to be helpful - https://github.com/fatkodima/online_migrations/blob/f9eb505d7126b8d809eb319b9ff9a93e86da6937/lib/online_migrations/config.rb#L147-L158

Thanks again. For some reason this block is being triggered for me but my pg server version is 12.11? In this case we're not talking about a primary key
# original col
t.integer "original_amount_cents", default: 0, null: false

=> SELECT version();
                                         version
------------------------------------------------------------------------------------------
 PostgreSQL 12.11 on x86_64-pc-linux-gnu, compiled by Debian clang version 12.0.1, 64-bit
(1 row)

Error
StandardError

An error has occurred, all later migrations canceled:

PG::InsufficientPrivilege: ERROR:  permission denied for table pg_attribute

ActiveRecord::StatementInvalid

PG::InsufficientPrivilege: ERROR:  permission denied for table pg_attribute

PG::InsufficientPrivilege

ERROR:  permission denied for table pg_attribute

Top of stack trace  relevant to gem is
online_migrations (0.5.4) lib/online_migrations/change_column_type_helpers.rb in block (2 levels) in finalize_columns_type_change at line 252

Did you write initialize_column_type_change ..., null: false as suggested by error message?
If you followed instructions from the readme, I see it does not suggest that additional options should be passed. I think, it is reasonable to update initialize_column_type_change to set :null to the value of the old column column by default.

here is the error message, I don't seem to have that null: false prompt for whatever reason.
rails aborted!
StandardError: An error has occurred, this and all later migrations canceled:

⚠  [online_migrations] Dangerous operation detected ⚠

Changing the type of an existing column blocks reads and writes while the entire table is rewritten.
A safer approach can be accomplished in several steps:

1. Create a new column and keep column's data in sync:

  class InitializeChangeBookingCentsColumnsToBigInt < ActiveRecord::Migration[6.1]
    def change
      initialize_column_type_change :bookings, :original_amount_cents, :big_int
    end
  end

2. Backfill data from the old column to the new column:

  class BackfillChangeBookingCentsColumnsToBigInt < ActiveRecord::Migration[6.1]
    disable_ddl_transaction!

    def up
      backfill_column_for_type_change :bookings, :original_amount_cents
    end

    def down
      # no op
    end
  end

3. Copy indexes, foreign keys, check constraints, NOT NULL constraint, swap new column in place:

  class FinalizeChangeBookingCentsColumnsToBigInt < ActiveRecord::Migration[6.1]
    disable_ddl_transaction!

    def change
      finalize_column_type_change :bookings, :original_amount_cents
    end
  end

4. Deploy
5. Finally, if everything is working as expected, remove copy trigger and old column:

  class CleanupChangeBookingCentsColumnsToBigInt < ActiveRecord::Migration[6.1]
    def up
      cleanup_column_type_change :bookings, :original_amount_cents
    end

    def down
      initialize_column_type_change :bookings, :original_amount_cents, :integer
    end
  end

6. Deploy

Ah, I see. I will review this PR and release a new version with the fix a bit later today.
Thanks for the patience btw.

Unfortunately, you still need to upgrade to postgres 11+.
We can not use change_column_null, because it will cause downtime. But we can set NOT NULL with DEFAULT as part of column creation in postgres >= 11 (and that hack won't be needed), so I improved initialize_column_type_change with this. Without that improvement, that hack was still needed for postgres < 12.
Also, I noticed that the code for copying old column :comment and :collation (if present) was missing, so fixed that.
So, again, thank you for contributing! ❤


fix(curriculum): change variable to function in calories step 56

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

Currently the hint message refers to variable instead of function

Here are screen grabs of the updated render

getCaloriesFromInputs is in fact a variable that points to a function. The text is correct as is. The next hint explains that the variable's value should be a function.