Adding Spotify/other Apps Branding title

Hello everyone, first of thank you for this great great app since the integration of Android phones is kinda restricted in BMW's, this app is a piece of heaven and gives everyone iPhone priviliges I know from my girlfriend's iPhone.
When we connect her iPhone to my BMW, the apps not only display the app icon, but also the branding name icon in the upper right next to the album covers, for example it displays the "@Spotify" written branding. The '@' in my example stands for the Spotify icon.
Is there a possibility to add this to your app as well for Spotify and maybe other apps?
Random example: https://www.bimmerfest.com/attachments/screen-shot-2018-08-04-at-10-19-51-pm-jpg.811052/
https://www.bimmerfest.com/attachments/image1533252318-797353-jpg.810746/
https://mediapool.bmwgroup.com/cache/P9/201503/P90178561/P90178561-bmw-group-welcomes-iheartradio-into-bmw-and-mini-vehicles-03-2015-1555px.jpg

Good afternoon! Thank you so much for the compliments!
The music app icon is readily available in the app, and does show up in some places. Those screenshots you've attached (which is incredibly helpful for showing what you mean, thank you!) depict the Audioplayer layout, in narrow and wide screen formats. When AndroidAutoIdrive is in this legacy Audioplayer mode, it does show the logo, but it omits the text, as depicted here. Is it this text specifically that is requested? I haven't given much consideration of it, but I suppose it would be doable! It was low priority previously, with the app name already displayed along the top, but it would definitely look slick with the branding image.
With the correct conditions (IDrive5+, connected over Bluetooth, with Spotify installed), the app runs in Spotify mode, which integrates a little more tightly into the car, allowing for coverart to show in the media sidebar and on the home screen. In this mode, the app icon shows along the bottom of the cover art, and so it was decided to not show the app icon in this mode.
Did I answer your question? I'll consider how to implement this feature, it would look really cool.

Good afternoon! Thank you so much for the compliments!
The music app icon is readily available in the app, and does show up in some places. Those screenshots you've attached (which is incredibly helpful for showing what you mean, thank you!) depict the Audioplayer layout, in narrow and wide screen formats. When AndroidAutoIdrive is in this legacy Audioplayer mode, it does show the logo, but it omits the text, as depicted here. Is it this text specifically that is requested? I haven't given much consideration of it, but I suppose it would be doable! It was low priority previously, with the app name already displayed along the top, but it would definitely look slick with the branding image.
With the correct conditions (IDrive5+, connected over Bluetooth, with Spotify installed), the app runs in Spotify mode, which integrates a little more tightly into the car, allowing for coverart to show in the media sidebar and on the home screen. In this mode, the app icon shows along the bottom of the cover art, and so it was decided to not show the app icon in this mode.
Did I answer your question? I'll consider how to implement this feature, it would look really cool.

Good afternoon :) You and everyone who contributes to this deserves all the compliments!
Ohh yes, everything works good and as it is supposed to on my iDrive4++, the individual app icons always show up and are displayed. I guess that the larger branding image is its own icon activated depending on the used app when we use my girlfriends iPhone.
Exactly, it is the white thick Spotify (or iHeartRadio,...) text or the branding image that I requested if it is doable in the future. I absolutely understand that it was low priority previously and I'm glad you like the idea and will consider how to implement this feature. Same thought, it would definitely look slick and really cool :)
Thank you and yes, you answered my question. I was curious if it can be considered to function and eventually be possible to make it display, hopefully it is, it would be lit.
Have a great day! :)

Good afternoon :) You and everyone who contributes to this deserves all the compliments!
Ohh yes, everything works good and as it is supposed to on my iDrive4++, the individual app icons always show up and are displayed. I guess that the larger branding image is its own icon activated depending on the used app when we use my girlfriends iPhone.
Exactly, it is the white thick Spotify (or iHeartRadio,...) text or the branding image that I requested if it is doable in the future. I absolutely understand that it was low priority previously and I'm glad you like the idea and will consider how to implement this feature. Same thought, it would definitely look slick and really cool :)
Thank you and yes, you answered my question. I was curious if it can be considered to function and eventually be possible to make it display, hopefully it is, it would be lit.
Have a great day! :)


New 23w03a mappings

There are a lot of mappings left, might add more in another PR.
Some of the mappings in MinecraftClient and GameOptions may be backported to 1.19.3

I have a major bug need to be fixed https://youtu.be/Wz6wANe_pbo this bug makes me can’t use the cloth-config mod, When I find to discord of the creator who create the mod says this bug is from you guys please fix


Implement OpCode for OP_PICK

Hello, can i do this issue?

Hey @89oso, it is basically finished on #56

@89oso yes sorry, @KhairallahA is finishing it


gh-dash: init at 3.2.0

Description of changes
https://github.com/dlvhdr/gh-dash
Closes #176381
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

works for me. Thanks for looking into my issues, it's super cool !

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1081


Add whitehall admin as a rendering app

whitehall-admin, rather than whitehall-frontend is responsible for
responding to requests for /government/uploads. Currently,
govuk-puppet sets up the NGinx configuration such that when the
request ends up at the frontend load balancer, it reverse proxies the
request to whitehall-admin.
Adding whitehall-admin as a valid rendering app will allow creating a
special route for directly routing traffic to whitehall-admin, which
will help with simplifying the routing, and making it more explicit.

It's probably not worth spending any time on simplifying asset routing; GoFreeRange are currently working on moving it all to S3, so all that complexity will be going away fairly soon.


[bug]: RMASelectProductTable does not show all products that are valid for returns and exchanges

To reproduce:

Create order
Create claim on an item
Cancel claim
Open return/exchange menu and see that the item in the cancelled claim is not available to return/exchange

Solved in #559


try omitting docs from upload

Should be fine as no one should be consuming docs this way (you would usually clone or fork repo). Worth noting https://github.com/microsoft/pxt-arcade/pull/4515 was removing .gifs before but now that's not working; maybe a weird regression in files field parsing in node 16 since I bumped that recently (https://github.com/microsoft/pxt-arcade/pull/5940/files)?

Also worth a note here is an article describing the different options for deciding what's included / not in npm publish since I had a small amount of trouble finding much reference to it / if anything had changed. One valuable portion to note from there is that npm pack runs the packing portion of npm publish, which is helpful for testing; with this change it looks like:

which... might be enough that it pxt cli is actually pretty zippy for ci type experiences?


Separate App Store Connect keywords with both English and Chinese commas

No environment needed. Version 2.204.3.
Steps to reproduce:

Prepare metadata file with keywords being 关键词1，关键词2, localization irrelevant.
Preview the metadata by running deliver and an HTML page is opened for preview
In the preview, keywords are only separated by English commas, not Chinese commas.

Expected behaviour: Keywords are separated both by English commas(,) and by Chinese ones (，).
Why this is expected: as per App Store Connect—

Include one or more keywords that describe your app. Keywords make App Store search results more accurate. Separate keywords with an English comma, Chinese comma, or a mix of both.

Above: screenshot of generated HTML preview by Fastlane

Above: screenshot of App Store Connect tooltips

It seems like you have not included the output of fastlane env
To make it easier for us help you resolve this issue, please update the issue to include the output of fastlane env 👍

Thanks, bot. It's not needed


Sarthak Portfolio

This is a portfolio website, @RITEKROUNAK kindly review my PR under hacktoberfest2022.

Good work. I am merging your PR.
Do give us a star by hitting the star button of this repo!


Issue with __Lock fields not being checked properly

Hi,
I am currently testing version 3.0-rc5 in combination with Sitecore 6.6.
All seems to work fine but I am now experiencing an issue with __Lock fields which seem to fail the check if the need to be updated.
I have the following item, taken from the Unicorn output:
[U] master:/sitecore/templates/Branches/User Defined/Websites/Horeca Toolbox/Quiz/Quiz root/$name/Winner slide (553fcbf5-1834-4707-8fcb-90c0eaf97bf9)
> Field __Lock - nl#1: Serialized , Source

How many times I do a re-sync, it keeps throwing this message. It also does this with other __Lock fields of other items.
The serialized data contains:
- Language: nl
  Versions:
  - Version: 1
    Fields:
    - ID: 001dd393-96c5-490b-924a-b0f25cd9efd8
      # __Lock
      Value: <r />

It does have a value equal to  but this is not present in the Unicorn output. Perhaps HTML tags are not displayed properly?
Data in target Sitecore environment before and after sync:
nl version of item: <r />
en version of item:
en-gb version of item: this language version was not created

As you can see the nl version already contains <r /> and the serialized data does as well. But Unicorn still want to update this field with every sync.

Any ideas?
Kind regards,
Dennis

Hmm, I can't seem to replicate that on 7.2 U5 which is the oldest thing I have handy. The <r /> values and blank values
The message (>) indicates that the comparison is occurring in the Rainbow ItemComparer. For __Lock, there are no custom comparers being used so it'd use the DefaultComparison https://github.com/kamsar/Rainbow/blob/master/src/Rainbow/Diff/Fields/DefaultComparison.cs which is a simple string.Equals() (case sensitive, culture aware).
For diagnostics, you can hook in a custom comparison based on something like https://github.com/kamsar/Rainbow/blob/master/src/Rainbow/Diff/Fields/FieldTypeBasedComparison.cs that targets __Lock specifically. This is registered on the <itemComparer> in Unicorn.config. At that point you can drop into the debugger and see what's going on with the comparison.
That said, I'd call __Lock a field that probably generally belongs on the ignore list by default, which I'll rectify in a minute for the next default config :)

Thanks for your detailed reply, I have some more insights to share.
In the source database the <r /> value is explicitly set in the item itself, it is not inherited as a standard value from the template. And therefor the value is also part of the serialized version. In the target database however the <r /> value  is not set in the item but already inherited from the template as standard value.
So when syncing and reading the target item it probably gets an empty string from the item itself as it should. Then it tries to persist the <r />  value from serialized item to the target database but this seems to fail because the value is already a standard value so perhaps Sitecore decides not to set it? Could be a Sitcore 6.6 bug?
But I agree that the best thing to do it so exclude this particular field by default.
Is it also correct behaviour the the Unicorn console does not display HTML values?

Re standard values differences: Standard values are intentionally ignored when comparing items as they are considered not directly part of the item data. So unfortunately if you've got different standard values across environments this is expected behavior (and those should probably be normalized).
Re: branches. Branches are evaluated once when instantiated and the values become not-standard at that point. If the template has standard values on a branch, the standard values will remain standard.
The HTML display issue has been fixed.

Thanks for the explanation. The __Lock issue is fixed (now ingored). Good to know the HTML issue has been fixed.


Allow init in empty repo

Fixes #8.

I've noticed that wok start doesn't work with empty repo either. Here is the tracking issue #12.


If no return type specified, should be void by default

Fixed by https://github.com/shoebox/inthebox-macros/pull/17


Collect all logs of pods running in the rook-ceph namespace

What this PR does / why we need it:
Update the default support bundle spec to have troubleshoot collect all logs of pods running in the rook-ceph namespace.
Which issue(s) this PR fixes:
Fixes https://github.com/replicatedhq/kots/issues/3318
Special notes for your reviewer:

This PR preempts a decision of collecting all pod logs in favour of collecting logs based on field selectors
The process of collecting a support bundle increased by about 30s in my test cluster

Does this PR introduce a user-facing change?

NONE

Does this PR require documentation?

NONE

Closing out this PR in favour of https://github.com/replicatedhq/kots/pull/3598


Add to napari hub collection

Once this plugin is released (and the name decided #40), this plugin should be added to the BrainGlobe collection on the napari hub. It can be added here.

Napari hub collections no longer exist, so this can be closed.


rustfmt not formatting in Legacy mode

Version of VSCode: 1.13.0
Version of the extension: 0.13.14
OS: Windows 10
This just started happening a couple days ago. When I select "Format Document" to format my rust code, nothing happens. Even if I purposely misformat the code. However running rustfmt from the command line will format the document.
Further, I don't see any output debugging in the output window.
Can anyone recommend any steps to further troubleshoot the issue?

Just managed to reproduce this on another environment that was just working. It appears to be relared to rustfmt 0.8.4. Things stop working after upgrading to that version.

Same here

rustfmt doesn't support Windows anymore

0.8.4 runs fine on windows commandline

Your crate must either be very small (not a lot of submodules), so you are not hitting the bug, or you are not actually running 0.8.4 in the command line. Anyways, basically rustfmt 0.8.4 canonicalizes paths, which syntex doesn't support. But syntex isn't getting updated anymore, so rustfmt will soon use nightly-only libsyntax: http://www.ncameron.org/blog/rustfmt-changes/

The fix until then is to downgrade to 0.8.3.

ok. I might be avoiding it because I was just running it against single files

Oh yeah, that should work. I think it's cargo fmt, that first collects all the paths, canonicalizes them and then runs rustfmt on each one.

Maybe we should shoot them a PR that reverts this behavior and it can be reintroduced in the nightly only 0.9 where it should work.

They released a new version. While rustfmt itself now works, it breaks the vscode-rust plugin :(

Cannot read property 'replace' of undefined: TypeError: Cannot read property 'replace' of undefined
    at patches.map.patch (C:\Users\Christopher\.vscode\extensions\kalitaalexey.vscode-rust-0.3.14\out\src\components\formatting\formatting_manager.js:204:62)
    at Array.map (native)
    at FormattingManager.parseDiff (C:\Users\Christopher\.vscode\extensions\kalitaalexey.vscode-rust-0.3.14\out\src\components\formatting\formatting_manager.js:196:35)
    at cp.execFile (C:\Users\Christopher\.vscode\extensions\kalitaalexey.vscode-rust-0.3.14\out\src\components\formatting\formatting_manager.js:70:41)
    at ChildProcess.exithandler (child_process.js:230:5)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at maybeClose (internal/child_process.js:885:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)

@CryZe, Could you provide a fix please?


Allow for large text in the "TEXT" field and auto move it to "EXTRA" if necessary

From @martindsouza on April 18, 2013 5:23
From Juergen:
The other enhancement I made was our developers don't have to know if the message they want to log are > 4K, so logger.error(my_variable); looks if my_variable is > 4K and automatically stores it in the extra column together with a short hint in the text column that the text is too long and can be found in the extra column
Note: We already do something similar for the log_params functionality.
Copied from original issue: tmuth/Logger---A-PL-SQL-Logging-Utility#17

For now this has been done to convert large varchar2 (up to 32767) to the EXTRA column if it exceeds 4000 characters. May look at converting to clobs in future but need to test performance.


Gradle plugin: Duplicated tag: 'dependencyManagement'

For build.gradle, when using
    dependencies {
        constraints {
            compile("com.fasterxml.jackson.core:jackson-databind:${jacksonVersion}") {
                because 'previous versions have security issues'
            }
        }
    }

in combination with
apply plugin: 'io.spring.dependency-management'

dependencyManagement {
    imports {
        mavenBom "org.springframework.cloud:spring-cloud-dependencies:${springCloudVersion}"
    }
}

an invalid POM file is generated with two dependencyManagement elements. Deployment (artifactoryPublish) is thus refused by the artifactory server.

I had the same problem.
You don´t need to/cannot use the  'io.spring.dependency-management' plugin in the project where you use your bom. so no "dependencymanagement in the build gradle too!
All you need is:
dependencies {
implementation platform('your-bom:version')

//your deps
}

Had the same problem and just implemented a hack that combines the content of the two dependency management blocks.
task fixPom {
    doLast {
        File file = new File("$buildDir/publications/mavenJava/pom-default.xml")
        def text = file.text
        def pattern = "(?s)(<dependencyManagement>.+?<dependencies>)(.+?)(</dependencies>.+?</dependencyManagement>)"
        Matcher matcher = text =~ pattern
        if (matcher.find()) {
            text = text.replaceFirst(pattern, "")
            def firstDeps = matcher.group(2)
            text = text.replaceFirst(pattern, '$1$2' + firstDeps + '$3')
        }
        file.write(text)
    }
}
generatePomFileForMavenJavaPublication.finalizedBy fixPom

Hi @lauraliparulo ,
explicitly defining the dependency does add the dependency. However I still get an extra dependencyManagement element in the end.

      **
org.springframework.boot
spring-boot-dependencies
2.4.2
pom
import
**

com.amazonaws
aws-java-sdk-bom
1.11.952
pom
import

org.springframework.boot
spring-boot-starter
runtime

com.amazonaws
aws-java-sdk-s3
runtime

org.springframework.boot
spring-boot-dependencies
2.4.2
import
pom

@micheljung Thank you for your workaround fix and idea.
But it did not work in our environment, there were a few differences (file path, task name..)
I wrote another workaround implementation. I may help somebody.
// FIXME workaround for https://github.com/jfrog/build-info/issues/198
val fixPom = tasks.register("fixPom") {
    doLast {
        val file = Path.of("$buildDir/publications/mavenJava/pom-default.xml")
        val content = Files.readString(file)

        val tag = "dependencyManagement"
        val findAll = "<$tag>".toRegex().findAll(content)
        if (findAll.count() == 2) {
            val tagEnd = "</$tag>"
            val start = findAll.toList()[1].range.first
            val end = content.indexOf(tagEnd, start) +tagEnd.length
            val fixedContent = content.removeRange(start, end)
            Files.writeString(file, fixedContent)
        } else {
            println("Is https://github.com/jfrog/build-info/issues/198 fixed already?")
        }
    }
}
tasks.findByName("generatePomFileForMavenJavaPublication")?.finalizedBy(fixPom)
    ?: throw NullPointerException("Task 'generatePomFileForMavenJavaPublication' was not found in " + tasks.names)

@micheljung @mpeterka thank you guys for your effort.
We've encountered the same issue after adding a transitive dependency constraint for a security reason.
Hence, it's crucial for us to keep the content of multiple tags.
The following solution merges <dependencyManagement> tags to keep all the managed dependencies data in the POM.
Also, it doesn't break the build if there are no tags or less than 2, but it will log a message.
The solution is pretty verbose though.
I didn't use the exceptions but nested if blocks, since I'm not sure about the way Gradle handles them, hence if you know it - feel free to optimize it further.
import java.nio.file.Files
import java.util.regex.Pattern
import java.nio.file.Path as FilePath

/**
 * Task to merge multiple <dependencyManagement> tags created in the POM file to publish.
 * Caused by: https://github.com/jfrog/build-info/issues/198 (io.spring.dependency-management + dependency constraints)
 */
val fixPom = tasks.register("fixPom") {
    doLast {
        val pomFilePath = FilePath.of("$buildDir/publications/mavenJava/pom-default.xml")
        val pomContent = Files.readString(pomFilePath)

        if ("<dependencyManagement>" in pomContent) {
            val (pomContentWithoutDependencyManagement, dependencyManagementTagContents) =
                extractDependencyManagementTags(pomContent)

            fixPomFileIfMultipleDependencyManagementTagsArePresent(
                pomContent,
                pomContentWithoutDependencyManagement,
                dependencyManagementTagContents,
                pomFilePath
            )
        } else
            logger.warn("Didn't find any <dependencyManagement> tags, maybe this project doesn't need this fix task")
    }
}

fun extractDependencyManagementTags(pomContent: String): Pair<String, List<String>> {
    val pattern = Pattern.compile(
        """(<dependencyManagement>.*?<dependencies>)(.+?)(</dependencies>.*?</dependencyManagement>)""",
        Pattern.DOTALL
    )
    var pomContentWithoutDependencyManagement = pomContent
    var matcher = pattern.matcher(pomContentWithoutDependencyManagement)
    val dependencyManagementTagContents = mutableListOf<String>()

    while (matcher.find()) {
        dependencyManagementTagContents.add(matcher.group(2))
        pomContentWithoutDependencyManagement = matcher.replaceFirst("")
        matcher = pattern.matcher(pomContentWithoutDependencyManagement)
    }

    return Pair(pomContentWithoutDependencyManagement, dependencyManagementTagContents)
}

fun fixPomFileIfMultipleDependencyManagementTagsArePresent(
    pomContent: String,
    pomContentWithoutDependencyManagement: String,
    dependencyManagementTagContents: List<String>,
    pomFilePath: FilePath?
) {
    if (dependencyManagementTagContents.size > 1) {
        val indexToInsertDependencyManagementTag = pomContent.indexOf("<dependencyManagement>")
        val fixedPomContent = getFixedPomContent(
            pomContentWithoutDependencyManagement,
            indexToInsertDependencyManagementTag,
            dependencyManagementTagContents
        )
        Files.writeString(pomFilePath, fixedPomContent)
    } else
        logger.warn(
            "Didn't find multiple <dependencyManagement> tag, " +
                    "maybe https://github.com/jfrog/build-info/issues/198 has been fixed " +
                    "or this project doesn't need this fix task anymore"
        )
}

fun getFixedPomContent(
    pomContent: String,
    indexToInsertDependencyManagementTag: Int,
    managedDependencies: List<String>
): String =
    pomContent.substring(0, indexToInsertDependencyManagementTag) +
            buildDependencyManagementTag(managedDependencies) +
            pomContent.substring(indexToInsertDependencyManagementTag)

fun buildDependencyManagementTag(managedDependencies: List<String>) =
    managedDependencies.joinToString(
        separator = "",
        prefix = "<dependencyManagement><dependencies>",
        postfix = "</dependencies></dependencyManagement>"
    )

tasks.findByName("generatePomFileForMavenJavaPublication")?.finalizedBy(fixPom)
    ?: logger.warn("Task 'generatePomFileForMavenJavaPublication' was not found in {}", tasks.names)

Had the same problem and just implemented a hack that combines the content of the two dependency management blocks.
task fixPom {
    doLast {
        File file = new File("$buildDir/publications/mavenJava/pom-default.xml")
        def text = file.text
        def pattern = "(?s)(<dependencyManagement>.+?<dependencies>)(.+?)(</dependencies>.+?</dependencyManagement>)"
        Matcher matcher = text =~ pattern
        if (matcher.find()) {
            text = text.replaceFirst(pattern, "")
            def firstDeps = matcher.group(2)
            text = text.replaceFirst(pattern, '$1$2' + firstDeps + '$3')
        }
        file.write(text)
    }
}
generatePomFileForMavenJavaPublication.finalizedBy fixPom

How are you pulling in the dependencies?  Which version of 'io.spring.dependency-management' are you using to run this?   Seems like some versions do not have that method.

@DerekWWestAwesomeDeveloper Which method?

The workarounds for updating the pom file with custom tasks are ugly, the issue is simple:
if you use dependencyManagement you can not combine it with implementation platform(..)
The right solution would be to use one, for instance, to migrate all the BOMs usages from
implementation platform("org.jetbrains.kotlin:kotlin-bom:$kotlinVersion")

to
dependencyManagement {
  imports {
      mavenBom("org.jetbrains.kotlin:kotlin-bom:$kotlinVersion")

I'd rather get rid of dependencyManagement, which is obsolete since Gradle introduced the platform plugin.


Integrate Go Node NFT Mint with Uniques Pallet

Depends on Identities being completed
[Add more details]

Done in - https://github.com/centrifuge/go-centrifuge/pull/1545

@mustermeiszer Sure, it was done in - https://github.com/centrifuge/go-centrifuge/pull/1545.


chore: replace IsLocalization.eq_iff_exists' by exists_of_eq

The other direction is a consequence of IsLocalization.map_units.
Also do the same for LocalizationMap and IsLocalizedModule.
This means we have one less fact to prove when constructing an IsLocalization (etc.) instance (thus many proofs are golfed), but once we construct it we still have access to the eq_iff_exists lemmas (without the prime) so the API doesn't get less powerful.

cc original authors @101damnations @jjaassoonn and users @erdOne @Vierkantor @awainverse @xroblot @mariainesdff

The docstring in Mathlib/RingTheory/Localization/Basic.lean probably needs some change but LGTM otherwise.
Thanks for the work! It sure will make things easier.

In fact, if you're localizing at the submonoid of nonzerodivisors (i.e. you're proving an IsFractionRing instance) or a smaller submonoid, exists_of_eq can also be replaced by injectivity of the algebraMap, because 1 is always in the submonoid. In concrete examples we do deal with domains or fraction rings most of the time, and many current proofs indeed take c = 1. I might consider adding a constructor for IsLocalization that takes injectivity as an argument, because we still need some one_mul/one_smul/coe_one to be able to apply injectivity even after this PR.

The docstring in Mathlib/RingTheory/Localization/Basic.lean probably needs some change but LGTM otherwise.

Thanks! Docstrings updated. Do they look good (or did I miss something)?

maintainer merge

bors merge


haskell-modules/generic-builder.nix: use mktemp instead of TMPDIR

Using $TMPDIR here is problematic because it is not always cleared at
the end of each build, for instance when using "nix-shell --run
genericBuild". This can cause confusing errors when a nix-shell build
is trying to pull in dependencies from a previous build since it tries
to use older package conf files.
To fix, we can just use mktemp which will guarantee us a clean
directory for each build. Should have no effect in nix-build, but will
fix a common issue with using generic-builder in nix-shell.
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

We should then maybe also deliberate cleaning up the temporary directory if nix-shell is to be an explicit use case.

Needs to target staging
Check contributing.md for how to do that

haskell-updates would be better in this case.

On 10. May 2022, at 01:56, Artturi @.***> wrote:

Needs to target staging
Check contributing.md for how to do that
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because your review was requested.

Thank you!


docs(README): 📖 remove unit symbol from Frequency examples

Continues #349

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1059

Relevant Lines:
1059

💛  - Coveralls


Excample of Create systoolspace in unistaller

When executing the uninstaller and it fails, it says one should execute a command, but that command depends on the systoolspace.
$ db2 "CALL SYSPROC.ADMIN_DROP_SCHEMA('LOGGER_1B', NULL, 'ERRORSCHEMA', 'ERRORTABLE')"

SQL0443N  Routine "ADMIN_DROP_SCHEMA" (specific name "*_DROP_SCHEMA") has
returned an error SQLSTATE with diagnostic text "SYSTOOLSPACE tablespace does

The correct order is:
db2 create tablespace "SYSTOOLSPACE
db2 DROP TABLE ERRORSCHEMA.ERRORTABLE
db2 "CALL SYSPROC.ADMIN_DROP_SCHEMA('LOGGER_1B', NULL, 'ERRORSCHEMA', 'ERRORTABLE')"
db2 "SELECT * FROM ERRORSCHEMA.ERRORTABLE"
db2 DROP TABLE ERRORSCHEMA.ERRORTABLE
db2 "CALL SYSPROC.ADMIN_DROP_SCHEMA('LOGDATA', NULL, 'ERRORSCHEMA', 'ERRORTABLE')"
db2 "SELECT * FROM ERRORSCHEMA.ERRORTABLE"
db2 "SELECT VARCHAR('db2 DROP PACKAGE LOGGER_1B.' || TRIM(NAME) || ';db2 DROP SCHEMA LOGGER_1B RESTRICT', 128) FROM SYSIBM.SYSPLAN WHERE CREATOR LIKE 'LOG%'"

This error exist with the Beta release, but it seems it was corrected at #https://github.com/angoca/log4db2/commit/d961d7887043703fbeb310ce39bd2eb0819e805e


Events web_app_set_header_color and web_app_set_background_color have no effect

Describe the bug
No effect when posting web_app_set_header_color and web_app_set_background_color events. There are no visual changes and changes in DOM.
To Reproduce
Steps to reproduce the behavior:

Open Sandbox
Open console
To test header color change, try both of the scripts:

WebView.postEvent('web_app_set_header_color', {color_key: 'secondary_bg_color'})

or
WebView.postEvent('web_app_set_header_color', {color_key: 'bg_color'})

To test background color change, try this script:

WebView.postEvent('web_app_set_background_color', {color: '#ffffff'})

See no changes in header and background colors

Expected behavior
Colors change right after event posting.

tdesktop issue: https://github.com/telegramdesktop/tdesktop/issues/25765
macos issue: https://github.com/overtake/TelegramSwift/issues/918


ErrorSummary - keyboard focus issue

Bug Report

What is the issue?

Moving the keyboard focus to the input element that has the error while on Error Summary does not work on FireFox.

What steps are required to reproduce the issue?

Open up FireFox
Go to: https://service-manual.nhs.uk/design-system/components/error-summary
Scroll to the first example
Press 'Enter your full name'
See that focus does not move the cursor to the text input

What was the environment where this issue occurred?

Device: MacBook Pro
Operating System: MacOS Catalina
Browser: FireFox
Browser version: 90.0.2
NHS.UK frontend package version: ^5.1.0
Node version: v14.16.1
npm version: v6.14.12

Is there anything else you think would be useful in recreating the issue?

This functionality seems to work fine in any other browser.

Just for clarity here's a screenshot of the component where expected the functionality fails.

The keyboard focus on the error summary component linking to text input field works well in the gov uk frontend library in FireFox.
See: https://design-system.service.gov.uk/components/error-summary/

This works fine when running the nhsuk-frontend dev server. The reason it's not working in the service manual is because the ErrorSummary component is not initialised. @chrimesdev - when we merged this, we forgot to do this!
Interestingly, in Firefox, without the JavaScript, this HTML does not result in the input field being focused. But it does in Chrome. Not sure what, if anything, we should be doing about this no-JS journey. Example here: https://codepen.io/andymantell/pen/ZEyEEgx

After initialising the ErrorSummary on the NHS digital service manual... the issue now is that when you visit the Error Summary component, on page load, the Error Summary JavaScript kicks in and jumps you half way down the page to the first Error Summary example code snippet.
We are trying to think of the best way around this, potentially something like: https://github.com/nhsuk/nhsuk-frontend/pull/770

Moving this back into In Progress column. Needs a bit more work.
@andymantell, does it still need the breaking change label?

@sarawilcox No the breaking change got released already. The ErrorSummary is working as expected and not exhibiting this bug in the released version of nhsuk-frontend. The outstanding piece of work is that it hasn't been intialised in the service manual so it's not working on any of the examples.
When this gets done - Refer to #770 and make sure that the error summary doesn't get focused on the page with all the demos on. Possibly could detect whether the demo was being rendered in an iframe, and if so don't enable the focusing behaviour. That would enable the full page demos to work as expected without causing problems on the index page.

Hi @andymantell and @will-dyson-nhsd, do you know it this has been initialised in the service manual now? If not, what do we need to do about it? Thanks.

@sarawilcox No it has not. We just need to initialise the JS and make sure to turn off the focusing as per #770. I'll try and get round to it at some point but can't guarantee when.

This issue will be resolved when the next Service Manual release goes out, solution can be found here https://github.com/nhsuk/nhsuk-service-manual/pull/1886.


added cot,sec, and csc trig functions

Added:

cot()
sec()
csc()

trigonometric functions plus their inverse and hyperbolic versions.

Looks good overall, i hope you did check if all the calculations are correct. but i will double check anyways and merge later.

I did double checked yes, but absolutely feel free to test it further!


Possible unrecognized rules

@jerone requests:
Any chance to recognize the rules from (new issue?):
*   @typescript-eslint ➡ https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/eslint-plugin#supported-rules
*   @angular-eslint ➡ https://github.com/angular-eslint/angular-eslint#rules-list
*   Prettier ➡ https://github.com/prettier/eslint-config-prettier (aldo this package only turns off all rules that are unnecessary or might conflict with Prettier).

@jerone Could you explain a bit more what you see when these rules are not recognized? I use them a lot in my testing and I see them. A screenshot might help. Do you have the plugins actually installed? If not, Lintel will show them under an "Unknown" tab.
Many thanks!

@mflorence99 This is what I see:

None of the @typescript-eslint and @angular-eslint rules are recognized.
All plugins are installed; this is from my package.json:
		"@angular-eslint/builder": "0.6.0-beta.0",
		"@angular-eslint/eslint-plugin": "0.6.0-beta.0",
		"@angular-eslint/eslint-plugin-template": "0.6.0-beta.0",
		"@angular-eslint/schematics": "^0.6.0-beta.0",
		"@angular-eslint/template-parser": "0.6.0-beta.0",
		"@typescript-eslint/eslint-plugin": "^4.7.0",
		"@typescript-eslint/parser": "^4.7.0",
		"eslint": "^7.13.0",
		"eslint-config-prettier": "^6.15.0",
		"eslint-plugin-prettier": "^3.1.4",

Happy to support more information if needed...

Got it, thanks

Should be fixed in v1.3.3, available now.

Awesome work @mflorence99, all rules are recognized now.

All thanks to you and your help. Many thanks again!
On Tue, Nov 10, 2020 at 5:41 PM Jeroen van Warmerdam <
<EMAIL_ADDRESS>wrote:

Awesome work @mflorence99 https://github.com/mflorence99, all rules are
recognized now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mflorence99/lintel/issues/28#issuecomment-725011154,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADI24DTADNLVGLZ36QZZ4DSPG6RBANCNFSM4TQVWAGA
.


plain text to segments

I have plain German text without any stop or punctuation. It it possible to get sentence segments with this library?

No, not exactly. This project shows how to describe words as vectors. It uses a corpus that is a combination of sources already containing one sentence per line (German news articles) on the one hand and using preprocessing to recognize sentences based on punctuation (German Wikipedia) on the other hand.
To use Gensims word2vec (which is the case in this project), you have to already know which words belong to which sentence...

Thank you for kind help.
sentences are in sequence. But without stops. Is there any other tool which can handle such issue??

 Ich suche ja schon.

Got it. I don't know a tool that's capable of such a sentence estimation...  even for a human it's sometimes impossible to find the correct segmentation as there are many right possibilities with different meaning...


license for contributions

Can you confirm that contributions to your project are accepted under Apache-2.0?
thank you.

@jlovejoy Thanks for bringing up this issue.  Since this repo is hosted under Baidu, the company requires the contributors to e-sign CLA (Contributor License Agreement).  We have updated the CLA binding to Github so it will pop up before making PR.

thanks @mingyux - but there is still no (obvious) way to review the CLA before someone is presented with signing it. Could you put a copy in your directory or a link to where one can review it?

@jlovejoy We've updated the README by adding a section for Contribution, which includes a link to the CLA for review.

Thanks! looks like this is based on the individual Apache CLA, and... (sorry to ask another question...) there is also a corporate version of that which is referenced in the version you have here - I think we need to sign the corporate version, unless you are not using that too?

The CLA linked to Github is the I-CLA.  For corporation CLA, please contact Weiling at<EMAIL_ADDRESS>

Hi again,
I hate to be a bother, but I have not gotten a response from Weiling. In the meantime, I reviewed your individual CLA (since it seems that all contributors will have to sign that, even if their employer also signs a corporate CLA) and it seem like maybe the terms got confused a bit:

“Baidu” is defined in the first sentence as “open source projects” – this doesn’t make sense in several places later in the agreement where “Baidu” seems to clearly be referring to the company, most notably in the license grants in section 2 and 3
“contributions is defined in the first paragraph and then again in the definitions section – there should only be one definition
“Projects” is a capitalized term in the first paragraph, yet not defined and not used again
“Work” is defined as “any of the products owned or managed by Baidu” – this is too far-reaching for a company. It seems like Work should mean “open source projects”, but as mentioned above, you have that definition for “Baidu”

We would really like to contribute to your project, do you think you can help clarify the above issues?
Thanks

@jlovejoy Please send email to<EMAIL_ADDRESS>again and cc<EMAIL_ADDRESS>as it may be blocked by the system.

will do, thanks!

Please leave a message here as well once you emailed us, so I can make sure it is not blocked.

sent and got your response :)


Find and Replace in a File Dialog Broken

Using one-light-ui v0.5.3:

Maybe this commit was a regression?
https://github.com/atom/one-light-ui/commit/a6a3dc8424ef3091daad8f1f09636a9447338edc

It looks like the same issue as https://github.com/atom/one-dark-ui/issues/36.
What's your current Atom version? It should look ok in Atom 0.190.0.

@simurai yup, it's resolved once I update. Thanks!


questions about the noise of IMU data and image data

Hi，First of all, thank you for sharing your dataset.
I have some questions about the noise of IMU data.
First：I want to use the dataset to run VINS mono，I want to know the paramaters as follows:
(1)accelerometer measurement noise standard deviation,
(2)gyroscope measurement noise standard deviation,
(3)accelerometer bias random work noise standard deviation
(4)gyroscope bias random work noise standard deviation
and gravity magnitude in your dataset.
Second: I found there is no image data in rosbag file, how can I get the image data?
Thanks for your time.

Hi there,
The IMU on the DAVIS is the MPU 6150, and you can find the specs sheet here: https://www.cdiweb.com/products/detail/mpu6150-invensense/470090/. This should have the statistics you are looking for. Regarding the image data, which bag are you referring to specifically? It should be available for most of them, although the right camera images are missing in outdoor_day1 and 2.

Hi,alexzzhu, I would like to know the calibration data of IMU when obtaining the data set, well,  Is the device calibrated before data collection?
And I am looking for the Indoor flying (Note: No VI-Sensor data is available for this scene)dataset's image file.
Thanks a lot!

Oh I see, no we do not have IMU calibrations beyond geometric extrinsics. The images should be stored in the bag file under /davis/image_raw, if that's what you're using. They're also available in the hdf5 files, I believe under the same name.

Please excuse me，calibration is very important for the stability of SLAM/VIO system , I want to know why do not have IMU calibrations beyond geometric extrinsics？

I agree that having the IMU parameters would help with state estimation. However, I'm not sure what to tell you aside from the fact that these were not collected.

I want to use this dataset to run the VINS-mono system,I need the (1)accelerometer measurement noise standard deviation,
(2)gyroscope measurement noise standard deviation,
(3)accelerometer bias random work noise standard deviation
(4)gyroscope bias random work noise standard deviation
and gravity magnitude in your dataset.
These parameters are very important for the initialization and normal operation of the system, If these parameters are not accurate, I don't know where the IMU can fly?

Have you tried running the system with some default set of calibrations? As far as I'm aware these systems shouldn't be so sensitive as to break completely without calibrated values.

Hi，First of all, thank you for sharing your dataset. I have some questions about the noise of IMU data. First：I want to use the dataset to run VINS mono，I want to know the paramaters as follows: (1)accelerometer measurement noise standard deviation, (2)gyroscope measurement noise standard deviation, (3)accelerometer bias random work noise standard deviation (4)gyroscope bias random work noise standard deviation and gravity magnitude in your dataset. Second: I found there is no image data in rosbag file, how can I get the image data? Thanks for your time.

I failed to run the indoor flying dataset on vinsmono, how is your yaml file set up?


Nada/FEQ-2426/chore: unit test for order review

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 76.953%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
4779

Relevant Lines:
5630

💛  - Coveralls


Getting Cannot find module 'C:\Projects\postGrest\subzero-base-project'

I installed the npm, docker and then the subzero cli (all seemed to install fine).
I then run the command subzero base-project and am getting this error:
C:\Projects\postGrest>subzero base-project
internal/modules/cjs/loader.js:783
throw err;
^
Error: Cannot find module 'C:\Projects\postGrest\subzero-base-project'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:780:15)
    at Function.Module._load (internal/modules/cjs/loader.js:685:27)
    at Function.Module.runMain (internal/modules/cjs/loader.js:1014:10)
    at internal/main/run_main_module.js:17:11 {
code: 'MODULE_NOT_FOUND',
requireStack: []
}
Any ideas what I'm missing? I'm running this on Windows 10 Pro

try subzero-base-project

this is a problem in a upstream package.
for some reason I thought it was fixed but it seems not, i'll bring the notice back
basically it means on win instead of subzero command you do subzero-command

That was it...worked with subzero-base-project. Thx!

Another quick question...the stack is up and running, but when I run the test call
curl http://localhost:8080/rest/todos?select=id,todo
I get a "permission denied". I'm assuming that's because the anonymous role wasn't granted privileges to the todos view?
In terms of setup, is there an additional script I should run in the db to grant privs?

No select means select * which means you are requesting the owner column and for that particilar column anonymous user does not have rights


Feature request in NaluwindUtils Local Refinement

Hi Nalu-wind team,
I am writing to request for a feature request in NaluWindUtils, related to nestedrefinement.cpp. When we do multilayer refinements around the turbine the list of one layer of refinement looks like this.
[X1,X2,YY,ZZ]

X1 is the normalized distance upstream of the turbine, X2 is the normalized distance downstream of the turbine for the streamwise box size.
The lateral extent of the box is y_hub - YYD to y_hub + YYD, and the vertical extent of the box is z_hub -ZZD, z_hub + ZZD.
While this is a workable solution, I am requesting more flexibility in the vertical direction, e.g., a list as follows
[X1, X2, YY, ZZ1, ZZ2]

The reason this will be extremely beneficial, is because in this way we can control the ground to remain unrefined. As an example,
in the existing feature, if we want the box to be 3D above the hub-height, then the lower corner of the box is at z = z_h - 3D, if z_h < 3D (which usually it is), the entire ground gets refined. This can be detrimental if we already have background mesh that is refined near the ground. So, I think this feature is enhanced to incorporate
[X1,X2,YY,ZZ1,ZZ2]

Then we can have something like this: ZZ1 = 0.5D, ZZ2 = 3D, so the vertical extent of the box is now z_h - 0.5D to z_h + 3D. This is similar to what is being done for the x-direction.
Best Regards,

Closing for lack of activity.


Favicon Update

closes #4920
What does this PR do?
This PR is update of Favicon in title bar.
Description of the task to be completed?
Adding logo of eddiehub to the title bar would be more engaging to the viewers.
How can this be manually tested?
Any background context you want to provide?
Is there any relevant issue to this PR?
No, I didn't find any related to this
Screenshots (if appropriate)

Questions

I'm not sure weather the aspect ratio of the favicon / logo is right 🤔 it seems to be a little bit stretched.
__        Summary: ❓ I have a question

Let me check it sir and update soon!

I've updated it sir!

This update looks great. It can be merged.

Can this PR be considered for hactoberfest?!

@keerthana054 only PRs created after october 1st are counted for hacktoberfest


Update C type integration and convert C++ to new type system

Contains two updates:

C++ has been updated to the new type system. There might be a few things that are not fully transfered over, but currently all tests pass and once we write some more tests we can discover what needs to still be completed. One of the biggest changes with this is the inclusion of the new tag system. See below.
Fixed a typo in C generation's "print" function, and generalized the code to specialize ints to the specific size given in the schema.

Aswell, this update adds a new feature to the type system called "tags". The rules are defined as:  Tag_D(T) =: T. Then, when the codegen encounters tags in the query, it is able to know the interface that gives it access to the values of type.
For example, the "dense" tag tells the C++ codegen that an object is stored in a std::vector, and when iterated over, must use a specific loop syntax. Alternatively, the "sparse" tag tells it that it's stored in a special CSVector or CSRMatrix class that has its own different loop syntax.
This tag system is generalized enough that it can be used for many more types of things aswell, both in C and C++ codegen. For example, it could be made that an object is a "struct" tag means constant accesses are just "x.field" syntax. Alterantively a "hashmap" would require running a lookup function when accessing fields. A "pointer" tag would require an object to be dereferenced to access the inner data; a "file-pointer" could indicate a specific byte index in a file (and include information about which file). Etc.

Looks good!


Guide: Add container to Digital Ocean with Terraform

What is the issue?
It would be great if we had a real-world example of how to add a Docker container to Digital Ocean while using Terraform

cc @kpenfound @jpadams added this as a placeholder.

I think this is covered by this demo as well: https://github.com/kpenfound/hello-do
Done!

I think we should leave this open until we have an official guide in the Dagger docs though, and maybe a demo video as well?

We can have @vikram-dagger take the lead on writing it based on your demo though if you'd like @kpenfound

Sure! fwiw, the demo flow doing this without terraform (on the DO site instead) is a bit smoother. Unless we build the terraform in 2 steps. Those steps would be like:

write terraform that creates the digitalocean_container_registry resource
run the dagger pipeline go run ci/main.go
write the terraform that creates the digitalocean_app resource
see the app running

@vikram-dagger let us know if you are ok with taking this on or if you need any additional support

I would need the code and 20 min with @kpenfound to understand how it works.


Free up disk space prior to caching docker images.

Without this, main is actively hitting disk-full when trying to cache
the images, failing CI.

The error is here: https://github.com/pantsbuild/pex/actions/runs/6206821754/job/16851439983#step:9:28
...
Images present before restore step will be skipped; only new images will be saved.
docker save --output ~/.docker-images.tar pantsbuild/pex/user:7fbd4f709120a0177c9065252fd48e1db3928a41 pantsbuild/pex/user:latest ghcr.io/pantsbuild/pex/base:45d4865a48417970e978510588a8098f1e986dc0 ghcr.io/pantsbuild/pex/cache:latest
Error: Error: Command failed: docker save --output ~/.docker-images.tar pantsbuild/pex/user:7fbd4f709120a0177c9065252fd48e1db3928a41 pantsbuild/pex/user:latest ghcr.io/pantsbuild/pex/base:45d4865a48417970e978510588a8098f1e986dc0 ghcr.io/pantsbuild/pex/cache:latest
write /home/runner/.docker_temp_1774573708: no space left on device
...


Fragile goods. Empty accelerometer readings array causes error

Cannot read property 'forEach' of undefined

Need to perform an empty check here or use alternative to forEach.
https://github.com/accordproject/cicero-template-library/blob/326a58670c982fab699e23844ec10952065c848d/fragile-goods/lib/logic.js#L36

This seems to have been fixed in the switch to Ergo: ```bash-3.2$ cicero execute --request request.json
15:56:33 - info: Logging initialized. 2018-06-22T19:56:33.791Z
15:56:34 - info: Using current directory as template folder
15:56:34 - info: Loading a default sample.txt file.
15:56:34 - info: Loading a default state.json file.
15:56:35 - info: {"clause":"fragile-goods@0.2.0-0eea79d5513163e5beb03d0a98aecb951372dad2e2e232f3bdb28fc7c8f69c0b","request":{"$class":"io.clause.demo.fragileGoods.DeliveryUpdate","startTime":"January 1, 2018 16:34:00","finishTime":"January 1, 2018 16:34:11","status":"ARRIVED","accelerometerReadings":[0.2,0.6,-0.3,-0.7,0.1]},"response":{"$class":"io.clause.demo.fragileGoods.PayOut","amount":{"$class":"org.accordproject.money.MonetaryAmount","doubleValue":790,"currencyCode":"USD"},"transactionId":"60700e2d-d9db-419b-8748-30138d3c7405","timestamp":"2018-06-22T19:56:35.181Z"},"state":{"$class":"org.accordproject.cicero.contract.AccordContractState","stateId":"org.accordproject.cicero.contract.AccordContractState#1"},"emit":[]}
bash-3.2$ cicero execute --request request-empty.json
15:56:43 - info: Logging initialized. 2018-06-22T19:56:43.532Z
15:56:44 - info: Using current directory as template folder
15:56:44 - info: Loading a default sample.txt file.
15:56:44 - info: Loading a default state.json file.
15:56:44 - info: {"clause":"fragile-goods@0.2.0-bcb0c557c772213426bc59d4ac05640a0959b9352ff72d7974c80c057e7d139c","request":{"$class":"io.clause.demo.fragileGoods.DeliveryUpdate","startTime":"January 1, 2018 16:34:00","finishTime":"January 1, 2018 16:34:11","status":"ARRIVED","accelerometerReadings":[]},"response":{"$class":"io.clause.demo.fragileGoods.PayOut","amount":{"$class":"org.accordproject.money.MonetaryAmount","doubleValue":800,"currencyCode":"USD"},"transactionId":"a00b5558-a62b-4e17-a368-01cb713e0a3c","timestamp":"2018-06-22T19:56:44.937Z"},"state":{"$class":"org.accordproject.cicero.contract.AccordContractState","stateId":"org.accordproject.cicero.contract.AccordContractState#1"},"emit":[]}

Added a test in PR #77. Closing this issue.


ZT UGDG

Many UGDG changes+ Code Changes

Pull Request Test Coverage Report for Build 1085

44 of 69 (63.77%)  changed or added relevant lines in 5 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 81.629%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/planner/logic/autocomplete/CustomSuggestionProvider.java
27
52
51.92%

Files with Coverage Reduction
New Missed Lines
%

src/main/java/seedu/planner/logic/autocomplete/CustomSuggestionProvider.java
4
47.45%

Totals

Change from base Build 1078:
-0.2%

Covered Lines:
3457

Relevant Lines:
4235

💛  - Coveralls


Fix Psalm 4.21 compatibility

totallyTyped was deprecated in Psalm v4.21.0. From the docs: totallyTyped="true" is equivalent to errorLevel="1".

There are two more places where totallyTyped is used: https://github.com/psalm/codeception-psalm-module/search?q=totallyTyped
Mind fixing them as well?

Sorry, I missed these. Strange that the tests passed for me locally regardless :thinking:

Perhaps it makes sense to bump the minimum Psalm version to whichever introduced the errorLevel attribute.

Looks like this would be v3.9.0.

Looks like there is still some issue with the test suite. I tested locally with "low deps" and while I had to upgrade squizlabs/php_codesniffer to ^3.5 for PHP 8 compatibility, the tests passed. But they passed for my first commit, too, so...

@tm1000 reopen doesn't trigger jobs, it requires a new push.

Still fails with Cannot find file phpvfscomposer:/home/runner/work/codeception-psalm-module/codeception-psalm-module/vendor/vimeo/psalm/psalm which is really strange

I believe this has already been fixed on the master branch.


Address remarks by @interkosmos

See https://github.com/fortran-lang/http-client/pull/5#pullrequestreview-1442484747.

As I already have a PR under review, in the meantime, I will work on this task.

Done by #10


If uber app is preinstalled then opening wber widget shows authentication failure.

If uber app is preinstalled then opening wber widget shows authentication failure. I am using sanbox. Any suggestion would be helpful.

Hey @bs2015 when using the widget if the Uber App is installed it by default will try to use Single Sign On (SSO) for a more pleasant user experience. You probably haven't configured your app to use SSO but you can do so by following our developer docs on authentication.

@itstexter Thank a lot for quick response. Yes, I have skipped that! I will try that.

Adding android app signature for SSO solved my issue. Thanks bro!


Added labels and updated documentation

Added scuderia mensa labels, team logo and updated index.md
Thank you for organizing this project!

Hi Tobi, thank you! I will go through the PR tomorrow in the evening. Please excuse the delay.

Hi Tobi, the labels are perfect as is, really good effort!
Unfortunately, I seem to have made a mistake when I composed your dataset and the last ~165 frames are almost identical.
I've scraped together enough images to replace them from our raw data and sent you an e-mail with the dataset.
I'm really sorry for this, I should've checked our raw data better before sending it out to you.

Hi Tobi,
thank you for the swift update to the newly added images.
There seems to be a small issue though, is it possible that during labeling the indices were incremented by one?
That would explain the following effect on the new images:

It should be a fast fix, though.

Hi David,
I fixed the issue in our script. The labels should be fine now!

Hi Tobi,
thank you for the swift fix. We're good to go, thank you for your contribution.


Make ZAP generation check do a clean of java folders first

Because java splits files per struct/cluster, if we ever rename or remove things, we may end up with obsolete
files in this folder.
Ensure a fresh regen on checks, so anything obsolete is forced to be removed.

Thanks!


"Article Schema Validation": Error for field "dateUpdated" - Should be "dateModified" instead.

I added an "Article Schema" to my SEOData object.
Problem: The $article->dateModified property is rendered as invalid schema field dateUpdated in src/Schema/ArticleSchema.php. The field in the schema should be named dateModified too.
This creates an invalid schema. https://validator.schema.org/ (Article Schema specification: https://schema.org/Article)
Error message of the Schema Validator: "dateUpdated" - The property dateUpdated is not recognized by the schema (e.g. schema.org) for an object of type Article.
1. Set the SEOData object with "dateModified"...
$seoData = new SEOData(
    title: $post->title,
    ...
    schema: SchemaCollection::initialize()->addArticle(
        function (ArticleSchema $article) use ($post) {
            $article->datePublished = $post->published_at;
            $article->dateModified = $post->updated_at;
            $article->addAuthor('Team');
            return $article;
        }
    ),
);

2. Output is created with wrong "dateUpdated" key.
See src/Schema/ArticleSchema.php: Line 88 should be updated to 'dateModified' => $this->dateModified->toIso8601String()
public function generateInner(): string
{
    return collect([
        '@context' => 'https://schema.org',
        '@type' => $this->type,
        'mainEntityOfPage' => [
            '@type' => 'WebPage',
            '@id' => $this->url,
        ],
        'datePublished' => $this->datePublished->toIso8601String(),
        'dateUpdated' => $this->dateModified->toIso8601String(),
        'headline' => $this->headline,
    ])
        ->when($this->authors, fn (Collection $collection): Collection => $collection->put('author', $this->authors))
        ->when($this->description, fn (Collection $collection): Collection => $collection->put('description', $this->description))
        ->when($this->image, fn (Collection $collection): Collection => $collection->put('image', $this->image))
        ->when($this->articleBody, fn (Collection $collection): Collection => $collection->put('articleBody', $this->articleBody))
        ->pipeThrough($this->markupTransformers)
        ->toJson();
}

Thanks for reporting Andreas, has been fixed in 1.2.1!

Looks fine. Just tested it. Thank you for the update.


Rename get_anchor  method before removal in mkdocstrings

There wasn't any deprecation warning, my bad.
It's also possible to return a tuple instead of a set.

Thanks for the thorough checkup. I needed to deduplicate ids in the Python handler, that's probably why I wanted it to accept sets, but I did it in a half-assed way.
About the order being important, I think it is for autorefs indeed, but not as much for inventories.

when falling back on additional ids to find a cross-ref, using sets gives nondeterministic results if a same object is rendered in different places (which is the case in Griffe for example, I've yet to find an elegant way to prevent/deal with that). With tuples instead, results are deterministic but still not obviously correct. We're missing the intent of the developer here, to know which one of several locations should be preferred. https://github.com/mkdocstrings/autorefs/pull/25 would come in handy here, probably.
regarding the change with sorted, the order of ids does not matter, however the order in which the same objects are rendered into different pages does. I used sorted simply to have entries in the objects.inv a bit more ordered (dicts keep ordering). But I realize now that registering all identifiers to the first location only is not correct either, since one id could be rendered in location A and one of its alias in location B. So once again we're missing the intent of the dev here: what's the public location? If we know that, we can postpone registering all remaining ids to this public location.

OK, I've updated mkdocstrings, mkdocstrings-python, mkdocstrings-python, and mkdocstrings-crystal (this PR) to always return tuples of strings, not sets.
Now, the priority issue for autorefs can be handled later, and I'd like to tackle the inventory issue in all handlers at once, in mkdocstrings. Rougly, in mkdocstrings extension:
if "data-role" in heading.attrib:
    self._handlers.inventory.register(
        name=rendered_anchor,
        domain=handler.domain,
        role=heading.attrib["data-role"],
        uri=f"{page}#{rendered_anchor}",
        # always overwrite for the heading that was just rendered
        overwrite=True,
    )
    for anchor in handler.get_anchors(data):
        self._handlers.inventory.register(
            name=anchor,
            domain=handler.domain,
            role=heading.attrib["data-role"],
            uri=f"{page}#{rendered_anchor}",
            # do not overwrite by default, only when user specified this location
            # to be the preferred one (through a handler option, to be determined)
            overwrite=heading.attrib.get("data-preferred-location", False)

If we want to ensure the inventory doesn't change across runs, we can sort it when writing it to disk. No need to do it earlier.

If you prefer, I can add back get_anchor to mkdocstrings with a deprecation warning :slightly_smiling_face:

Thanks

This is now released


Hotfix/disk content type

This patch updates the disk driver to store the content-type header contents alongside any files, written into the directory whose path is $storageRoot/.gaia-metadata/$address/$filename.  This is important, because these metadata files will not be directly listable or writeable by remote clients.
This PR also adds a reader/ sub-package that implements the read endpoint for the disk driver.  This is a necessary component because the read endpoint is aware of the disk driver's above scheme, and will supply the appropriate content-type header on GET.
When deploying a Gaia hub that uses the disk driver, it is recommended to run both the blockstack-gaia-hub process and the blockstack-gaia-reader process, with the blockstack-gaia-reader process running behind a "real" HTTP server like nginx.  The blockstack-gaia-reader process can read the same config file as the blockstack-gaia-hub, and will honor the diskSettings.storageRootDirectory field to find the top-level disk storage directory.

Pushed a simple error catch to the read endpoint. I was testing whether or not you can traverse with URLs like:
http://localhost:8008/1FmbX4xLUdf28RKGz7aFajvMTCvXmAnh8M/../../baz

You cannot, but it caused the sendFile to barf an uncaught promise rejection.

Anyways, thanks for the changes and the fix @jcnelson, please bump the version in package.json and then feel free to merge.


FromQueryParamsAttribute

Now the FromQueryParamsAttribute  is provided, we should make it support more sub DTOs
    /// <summary>
    /// From. To
    /// </summary>
    [FromQueryParams]

    public Range<DateTime>? CreateTime { get; set; }

    /// <summary>
    /// From. To
    /// </summary>
    [FromQueryParams]
    public Range<DateTime>? EditTime { get; set; }

    /// <summary>
    /// UserName,Email
    /// </summary>
    [FromQueryParams]
    public BlogAuthorFilter? Author { get; set; }

querystring like :
?CreateTime.From=2022-01-01&CreateTime.To=2022-02-01&EditTime.From=2022-08-01&EditTime.To=2022-09-01&Author.UserName=vipwan
In this way, it should be a good solution to the problem of DTOs that cannot be more than one

At present, it seems that such complex filter parameters can only be obtained by POST method

some work has already been done for this. pls see: https://discord.com/channels/933662816458645504/1019532313010376754
also couple of open PRs that i haven;t found the time to review: https://github.com/FastEndpoints/FastEndpoints/pulls

@vpetrusevici i think he's asking for the ability to decorate multiple root level properties with [FromQueryParams] which we will not be supporting anytime soon.
i don't think even swagger ui supports that query string format? does it?


Drawings missing from git

Draw.io drawings are not pushed into the git repo, which defeats the purpose of a git-based export a bit.
Drawings are part of the page and should stay with the rest of the data.
I would suggest moving the drawings folder to the pages folder and hiding it while listing the pages.

Yes indeed, never thought about it. I'll try to fix it.
Nice to see that the drawio plugin is being used!

It is one of the main features I'm setting up wikmd :) awesome project you got going!

@melvin-suter It is currently merged in the main branch. Let me know if it works as expected now :)


Clarify documentation of RequestHeaderModifier .set and .add behaviour

What would you like to be added:
The documentation for set currently reads:

To edit an existing header, use the set action and specify the value of the header to be modified and the new header value to be set.

However, according to the implementation by Traefik it actually sets it regardless of it exists or not. Go playground
This also goes for the add functionality, which according to the implementation in Traefik will add values iteratively, i.e. if an incoming request already has header x-header set to value and you add the add filter with value2 the actual header value will be value,value2. This is just a clarification I think could be useful to add.
If this is a wrong implementation by Traefik then let me know and I'll move the issue over there.
Why this is needed:
To avoid confusion when using the filters.

I think the issue here is that we haven't been clear enough about the expected behavior.
set is supposed to unconditionally set that header to that value and only that value. So, if the header is not present, then the header will be added, set to the specified value. If values are already set, they will be overridden with the specified value.
That's how you can edit a header that's already existing - set will do that if it's already set, with the side effect that it will set it if unset.
add is supposed add to values, setting them if unset, and adding comma-separated values to an existing header if the header already exists.
If you are looking for "edit this value if present and don't do anything if not", I don't think we have a way to do that at the moment.
From what I can see above, Traefik is behaving according to the spec.

Yes, I agree that line could be changed to something more like:

To edit an existing header, use the fact that set unconditionally sets a header to override whatever is in that header using the same header name and the new value.

or something.
Does that make more sense to you @FredrikAugust?

It stills appears a little self-contradictory to me as the first sentence reads "existing header" which implies that the header has to be there in the first place — which we have established is not the case.
What about:

To unconditionally set the value of a header, use set. It will override the value of a header with the provided value if the header is already present, or set it to the provided value if the header does not exist already.

Sorry for the delay here @FredrikAugust. That suggestion lgtm.


kjvelarde-angular-multiselectsearchtree version problem

I have this issue 👍
17:05:33 bower kjvelarde-angular-multiselectsearchtree#0.8.0     ENORESTARGET No tag found that was able to satisfy 0.8.0
17:05:33
17:05:33 Additional error details:
17:05:33 No versions found in https://github.com/kjvelarde/angular-multiselectsearchtree.git
My bower.json is like : "kjvelarde-angular-multiselectsearchtree" : "0.8.0"

Sorry I wasn't tagging the commits. I just added them #0.8.0 #0.8.5 #0.9.0
Thanks


Add ability to have IPv6-only OpenVPN vpns

As discussed with Franco Fichtner on IRC, I wanted to have an IPv6 only VPN but the check in the WebUI was a little bit to restrictive as the network tunnel IPv4 seems to be mandatory.
I think this is a simple fix. Therefore, I decided to bring this PR on the table. This has not been tested (I don't have a CI for OPNsense - and I don't like to push untested code - sorry), but I assume (read hope) this will be enough to have this feature :)

Ok. Testing in the PHP files made my VPN crash. Gonna investigate this on my side :) Before repushing a fix (and rebasing of course).

Not possible for now because of upstream.


MySQL Poor performance (when not using $queryRaw)

Bug description
This is a weird one.  I recently migrated from MariaDB 10 to MySQL 8. When I query the DB using the helper functions (i.e. Model.findMany), the queries take a long time and the mysql process on my machine takes at least a minute to process the query. Disk usage is also high for the mysql process.  When I use $queryRaw, the results are returned quickly as expected.
How to reproduce
If I run:
debugger;
// this is fast.
await DB.prisma.$queryRaw("SELECT `cryptick`.`Trade`.`marketId`, `cryptick`.`Trade`.`id`, `cryptick`.`Trade`.`amount`, `cryptick`.`Trade`.`price`, `cryptick`.`Trade`.`buyerMaker`, `cryptick`.`Trade`.`externalId`, `cryptick`.`Trade`.`time` FROM `cryptick`.`Trade` WHERE `cryptick`.`Trade`.`marketId` = 7 ORDER BY `cryptick`.`Trade`.`id` DESC LIMIT 1 OFFSET 0");
debugger;
// This is slow.
await DB.prisma.trade.findMany({
  where: {
    marketId: 7
  },
  orderBy: {
    id: "desc",
  },
  take: 1,
});
debugger;

I found the generated query for the second call and copied that into $queryRaw using SHOW FULL processlist;.
The first query will take first will take under a second and the second will take more than a minute.
Here is the data model for this table:
model Trade {
  marketId   Int      @db.SmallInt
  id         Int
  amount     Float    @db.Float
  price      Float    @db.Float
  buyerMaker Boolean
  externalId String   @db.VarChar(255)
  time       DateTime @db.Timestamp(6)
  Market     Market   @relation(fields: [marketId], references: [id])

  @@id([marketId, id])
}

Which currently has 27 GB of data (millions of records). Also if I use prisma.trade.findMany, I have the same issue, even though the generated query found by SHOW FULL processlist; runs quickly on its own.
Expected behavior
I would expect this query to take the same amount of time.
Prisma information
See above schema
Environment & setup

OS: Windows 10
Database: MySQL 8
Node.js version: 14.15

Prisma Version
v2.23.0
Also experienced this with 2.22.x, but haven't downgraded further.

Not sure how this can happen since I always thought the query was simply sent to the DB where all optimizations are generated by MySQL. The same query generated by 2 different functions has very different performance results.
I have uninstalled built files and node_modules repeatedly. Any help is appreciated.

Uh indeed a weird one. But interesting.
Might be that Prisma Client is running some additional queries? Confirm with https://www.prisma.io/docs/concepts/components/prisma-client/working-with-prismaclient/logging which gives you the Prisma view vs. the database view.
Is the data of the $queryRaw already typed the exact same way as the findMany?
We will try to reproduce this of course.

I didn't see any additional queries. It just seems to lag then outputs the log of the select query.
I have thought more about this issue and it may be related to #7232. The delete query, at least on mysql 8, was having poor performance. Perhaps the table is locked which would result in the wait.

Any idea how we could create similar ~27GB of data for that model you shared? Without that a reproduction will be very hard I guess.

This is happening with me as well. At the time i'm rewriting all my queries with raw SQL.
For a simple database with only 10 rows, a findMany with 2 relations it's taking about 1.3 seconds.

Ping @DakotaLarson. I realize it has been some time, but could you still provide additional information here? Otherwise we will need to close this as just do not have enough information about how to reproduce this with adequate effort. Thank you.


Review first draft of english about/pycontw

Fix #149

Current coverage is 87.52%

Merging #163 into en_about_pycontw will not affect coverage as of d1cf08a

@@            en_about_pycontw    #163   diff @@
================================================
  Files                     40      40
  Stmts                   1186    1186
  Branches                   0       0
  Methods                    0       0
================================================
  Hit                     1038    1038
  Partial                    0       0
  Missed                   148     148

Review entire Coverage Diff as of d1cf08a

Powered by Codecov. Updated on successful CI builds.

抱歉 @changyc 回得有點晚，妳的翻譯非常通順！！有空可以再找妳幫忙英文的部份嗎 > <
PS 我有改一些錯字在 d1c9c92c66f42e389b66bb3e8cfa60455ec004a7

@ccwang002 謝謝～好噢，有需要的話再跟我說 :)


osctiny.models.request.Source model: add an optional 'repository' attribute (fixes #190)

Note: do not merge before openSUSE/open-build-service#16883 is merged and released.


sqlite3 not working with ubuntu and gfortran

When running
 gfortran -o example example.f90 libfortran-sqlite3.a -lsqlite3 ,
I'm getting the following error:
/usr/bin/ld: libfortran-sqlite3.a(sqlite3.o): in function `__sqlite3_MOD_sqlite3_db_name':
sqlite3.f90:(.text+0x4a1): undefined reference to `sqlite3_db_name'         collect2: error: ld returned 1 exit status

I'm running this on Ubuntu, and my sql version is 3.41.2.
Apart from that, the only command i haven't executed is  pkg install databases/sqlite3, instead i run  sudo apt-get install -y libsqlite3-dev.

The SQLite function sqlite3_db_name() was introduced in version 3.39 (release notes). I’ve tested it on Debian 6.1, using GNU Fortran 12.2 and SQLite 3.40.1. I cannot reproduce this issue. Are you sure the SQLite library you link against is 3.41.2?

So now I have uninstalled the older version of sqlite, download and compiled the newer one (3.45), and now I can run your example. The problem now is that the sqlite file is created:

But then when executing this chunk of code:
    ! Run the statement.
    rc = sqlite3_step(stmt)
    if (rc /= SQLITE_DONE) print '("sqlite3_step(): failed")'

It doesn't work (I'm getting as output sqlite3_step(): failed, and nothing is inserted on the table.
Besides, how can bulk insert can be done using this library?
Thanks,

The error indicates a (write) permission error. Make sure the owner of the program has write permission to the database (use chmod or chown). You can output the error message instead:
rc = sqlite3_step(stmt)
if (rc /= SQLITE_DONE) then
    print '("Error: ", a)', sqlite3_errmsg(db)
end if

To bulk insert records into a database, follow:

Prepare the statement with sqlite3_prepare_v2().
Bind the values with sqlite3_bind_*() to the statement.
Execute the statement with sqlite3_step().
Reset the statement with sqlite3_reset().
Repeat from step 2 onwards until all records are inserted.
Clear the statement with sqlite3_finalize().

Solved, thx 👍


[DataFactory]Added new features into 4.26.0

Supported Power Query model changes for multiple queries
Added locale support in Power Query activity
https://github.com/Azure/azure-rest-api-specs/pull/16158
Added publicNetworkAccess into FactoryUpdateParameters
https://github.com/Azure/azure-rest-api-specs/pull/15950

All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] Please open PR in Draft mode if it is:

Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
[ ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:
Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

[ ] Include updated management metadata.
[ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

If the check fails at the Verify Code Generation step, please ensure:

Do not modify any code in generated folders.
Do not selectively include/remove generated files in the PR.
Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:
  `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

LGTM


Compatible with non-standard REST interface request to obtain body logic

Compatible with non-standard REST interface request to obtain body logic  #145

If possibile, pleaseifx sonarcloud scan issue. like code smells and coverage(new code)>=80%


Fixed a bug in the test file

Could you please elaborate more on this issue? I didn't see any key difference. Did you encounter any problem when running the original code?


Send message with attachments

Hi, thanks for the great project!
Is there any way to respond to user's input with slack attachments?

@ivanovaleksey - from what I've seen, since this bot exclusively uses slack's RTM api which doesn't currently support anything outside of plain old text, I'm afraid the answer is probably not. However, it shouldn't be terribly hard to update the bot to use one of the other Slack APIs that does support more advanced messages. Would certainly open this bot up to many more use cases.


Rework static/dynamic obstacle calculations

profiling found that in the robot allocator update step, the largest bottleneck was static/dynamic obstacle generation which is done from the existing robot positions/paths and item zones.
Some optimizations:

Zones as static obstacles are fixed, and stationary robots can be added to that separately, don't need to regenerate all of it per step
Dynamic obstacles is mostly fixed in a single step, and can be updated as new robot paths are added, don't regenerate per path finding call (this is the big one)

WIP that on robot allocator restart, trying to generate paths for all robots is very expensive and for say 500 robots will likely take > 1 cycle.
The simplest option, clear all paths and have robots wait in place will cause gridlocks on a less sparse grid, which is the case fora big warehouse with 500 robots, as no robot can find a valid path home because other robots are stationary in the way.
The next option is on restart, to let robots continue on their existing paths (world sim has access to existing paths on redis db), and assign a new restart-return-home type job that waits till they complete their current paths. This avoids gridlock and also defers path planning into the update step where it can be batched by time


How to Convert LandmarkProto.NormalizedLandmark into android screen pixel ..?

I want to know that how to convert LandmarkProto.NormalizedLandmark convert into android screen pixel, like now x and y landmark in coming in the range of [0..1]  but i want to convert it according to my screen size...?.
.
.

Hi @ni3-sharma, Could you please elaborate your issue with complete details. Thanks!

Hi @ni3-sharma, Could you please respond to my above comment. Thanks!

hello @sgowroji
sorry for the delay,
my point is that i am using this mediapipe hand tracking code in my android app and i got the points for the tracker that is in between 0 to 1 i just want to know about how to convert this normalize points according to android phone screen size.
Thanks!

Hi @ni3-sharma, You can make the changes from both android platform side and graph as you have coordinates with you (you get coordinates by multiplying the normalized landmark value with the height and width of the image).
If you are looking at graphs then you can refer here graph changes which you need to change as per  your requirement. Reach us back if you still have any quries on top of it. Thanks!


Implement MySql Realization

Note: Installed MySql.Data package from nuget ,so SqlSugar depends on MySql.Data now.

如果一样的不需要重写，只有需要重写的地方才进行重写 MYSQL的代码还是有点多了

These don't need   override
public override string OrderByTemplate

   {

       get

       {

           return "ORDER BY ";

       }

   }

   public override string GroupByTemplate

   {

       get

       {

           return "GROUP BY ";

       }

   }

@sunkaixuan Ok,I'll remove unnecessary override methods.

Thanks


Is there any way to build a private firebase test lab on my own device

I was in CHINA,so i can not use the google service.
can i build a private firebase test lab on my own server to test the APP?

@fengxiaohu this does not follow the issue template and is not related to the quickstart code.


[stable/kafka-manager] allow custom service annotations

@giacomoguiulfo  @ssalaues
What this PR does / why we need it:
Allow custom annotations on kafka-manager service. In our case we need to add custom annotation for external-dns, but I guess there could be many other use cases.
Checklist

[x] DCO signed
[x] Chart Version bumped => waiting for validation to bump version
[x] Variables are documented in the README.md

@juliendangers change look good. Please bump the chart version.

@juliendangers go for just a patch.

/ok-to-test

@giacomoguiulfo @ssalaues should I do anything else ?

/lgtm

Sorry for the delay @juliendangers . It should be merged now


MRG, ENH: Add support for CSD as custom reference type

Eventually I can roll back the constants tests once we get https://github.com/mne-tools/fiff-constants/pull/23 in. In the meantime we can merge this if it looks reasonable to folks so that #6910 can use it.
As @agramfort pointed out, our inverse checks just look at effectively bool(info['custom_ref_applied']), so we should still be good there.

ok for you @alexrockhill ?

Only failure was a timeout, okay to merge @agramfort and then @alexrockhill can rebase #6910 for hopefully the last time :)

Sorry not to respond sooner, sounds good to me.

Okay, feel free to rebase and make use of this!


MWPW-159374: Replace tinyMCE with Prosemirror

Resolve:
https://jira.corp.adobe.com/browse/MWPW-159374
https://jira.corp.adobe.com/browse/MWPW-159258
https://jira.corp.adobe.com/browse/MWPW-159259
Milo PR: https://github.com/adobecom/milo/pull/3117
OST PR: https://git.corp.adobe.com/wcms/tacocat.js/pull/645
Test URLs:

Before: https://main--mas--adobecom.hlx.live/studio.html?aem.env=qa#query=acom
After: https://mwpw-159374--mas--adobecom.hlx.live/studio.html?aem.env=qa&milolibs=mwpw-159374--milo--adobecom#query=acom

PROD: https://mwpw-159374--mas--adobecom.hlx.live/studio.html?milolibs=mwpw-159374--milo--adobecom#query=acom

I have some OST changes as well, I'll open a PR tomorrow.

seeing overlap

@yesil I am not able to add the price to the slice wide card that has text in it. Maybe it is something with the card. I can add it in the first row, but not in the second. I also get the 'fragment could not be saved message'

@afmicka updates in the editor should be fixed now.

@yesil Leaving here the list of issues still present:

Double click on configured CTA does not open the OST
Strikethrough price on slice cards - not able to apply bold style and font colour should be lighter grey as on suggested card

expected:

When

CTA variant is applied in studio, data-extra-option attribute without value is added, giving placeholder-failed

Issue #2 from the previous list

@yesil studio looks good to me now. Will create separate jira for the strikethrough price style
The remaining issues i see (but are no regression) are:

When you remove the text from the badge field, it does not get removed in the preview. Card needs to be saved and page refreshed in order to see the badge gone

When OST is opened for the checkout link, the window has a scroll bar, buttons at the bottom are not visible.

Let me know if these issues need a separate jiras or will be addressed here

Issue no 1 fixed, the second created a follow-up jira https://jira.corp.adobe.com/browse/MWPW-161588.
Looks good to me


Export to CSV not working

Hello,
I can't get the Export as CSV or Export statistics as CSV to work.
Am I missing something?
Logger: frontend.js.latest.202406101
Source: components/system_log/init.py:333
First occurred: 16:07:09 (2 occurrences)
Last logged: 16:13:43
Uncaught error from Edge <IP_ADDRESS> on Windows 10 ReferenceError: moment is not defined r.exportFile (/hacsfiles/history-explorer-card/history-explorer-card.js:17:66937) L.exportStatistics (/hacsfiles/history-explorer-card/history-explorer-card.js:93:7656)
Uncaught error from Edge <IP_ADDRESS> on Windows 10 ReferenceError: moment is not defined o.exportFile (/hacsfiles/history-explorer-card/history-explorer-card.js:17:65198) L.exportFile (/hacsfiles/history-explorer-card/history-explorer-card.js:93:7543)

Same problem here in firefox. Exporting, just waits forever until F5 is pressed to refresh the window.

I suppose that commit d49bcb5 might be the cause; switching to "normal JS imports" should also imply that each source file needs to include its dependencies. So adding
import "../deps/moment.js";
var moment = window.HXLocal_moment;

just at the top of the history-csv-exporter.js file and rebuilding the JS asset cured the problem for me.

I suppose that commit d49bcb5 might be the cause; switching to "normal JS imports" should also imply that each source file needs to include its dependencies. So adding
import "../deps/moment.js";
var moment = window.HXLocal_moment;

just at the top of the history-csv-exporter.js file and rebuilding the JS asset cured the problem for me.

How does one "rebuild" the JS asset?

You need nodejs installed after that something like "npm run build" (see package.json, "scripts"). You probably also need something like "yarn install" or "npm ci" before trying to rebuild. Do not quite remember. I can eventually generate a pull request, but right now I just do not have the time.

You need nodejs installed after that something like "npm run build" (see package.json, "scripts"). You probably also need something like "yarn install" or "npm ci" before trying to rebuild. Do not quite remember. I can eventually generate a pull request, but right now I just do not have the time.

Thanks for taking the time to answer - that's way above what I can do without starting ww3.
I have downgraded to 1.0.53 for now, and CSV exporting works.
Cheers

Unfortunately 1.0.53 doesn't work for me with Chrome - so +1 for a fix please. It's been bugging me ever since I switched from alexarch version but I've only just got around to looking if there was an issue open.

I would be glad for a fix too !

I would be glad for a fix too !

The mitigation for this is to downgrade to 1.0.53. And make sure to clear the cache.

Unfortunately 1.0.53 doesn't work for me with Chrome - so +1 for a fix please. It's been bugging me ever since I switched from alexarch version but I've only just got around to looking if there was an issue open.

Clear your cache.


KeyDerivation.Pbkdf2 use with byte[]

change addresses #87

changed interfaces and providers PBKDF2 to support byte[] as input for password
added tests for new logic

Hi @bwolkerstorfer, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

cc @blowdart

We go to extraordinary lengths to pin memory, clear memory when we're done using it, etc. This PR deletes all of that work, and has a huge risk that passwords and byte arrays representing passwords hang around in memory long after they should have been cleared.
A further attack vector added with Encoding.UTF8.GetBytes(password).
This PR is unsafe and must be rejected.

@blowdart I have no particular interest for this new API signature, but I'd really appreciate if you could detail your reasoning (not everyone is a security expert :trollface:).

We go to extraordinary lengths to pin memory, clear memory when we're done using it, etc. This PR deletes all of that work, and has a huge risk that passwords and byte arrays representing passwords hang around in memory long after they should have been cleared.

Since the password is initially flowed as a string, isn't that futile anyway? No matter what you do to reduce the lifetime of the intermediate byte arrays, the password is still held in clear as a string until it's garbage-collected. I'm not sure to understand how this PR makes this situation worse.

A further attack vector added with Encoding.UTF8.GetBytes(password).

Aren't all the PBKDF2 providers (managed, Win7/Win8) already using it? AFAICT, only the data protection extensions use a UTF-8 encoding that throws on invalid byte sequences (if that's what you mean)

https://github.com/aspnet/DataProtection/blob/dev/src/Microsoft.AspNetCore.Cryptography.KeyDerivation/PBKDF2/ManagedPbkdf2Provider.cs#L71
https://github.com/aspnet/DataProtection/blob/dev/src/Microsoft.AspNetCore.Cryptography.KeyDerivation/PBKDF2/Win7Pbkdf2Provider.cs#L53
https://github.com/aspnet/DataProtection/blob/dev/src/Microsoft.AspNetCore.Cryptography.KeyDerivation/PBKDF2/Win8Pbkdf2Provider.cs#L86

We are pinning and clearing what we produced after we've done it. It's a best effort here, and surely you agree we ought to make an effort rather than ignoring it altogether.

It's a best effort here, and surely you agree we ought to make an effort rather than ignoring it altogether.

Sure (you could even use SecureString instead of a plain old string).
My question was: why do you think this PR is bad from a security perspective?

You know how I feel about securestring you troll :p
Removing the pinning and clearing of the array which we converted the string into means we now have a second copy of the the plaintext password floating about, which is obviously a bad idea.

You know how I feel about securestring you troll :p

Me, trolling? Nah (tho I've always wondered why you hated SecureString so much) :smile:
Actually, the DP stack heavily uses Secret - which seems to be an equivalent of SecureString that also relies on CryptProtectMemory - to "protect" critical things like DP master keys.
IMHO, user passwords are at least as sensitive as master keys, so it wouldn't surprise me if the PBKDF helpers accepted an ISecret/SecureString.

Removing the pinning and clearing of the array which we converted the string into means we now have a second copy of the the plaintext password floating about, which is obviously a bad idea.

Sure, this line could be updated to use pinning and clear the intermediate bytes buffer before returning, but it's not clear to me why this makes the PR totally "unsafe".
Anyway, thanks for the details :smile:


Update NGINX

Update NGINX docker image to 1.19.0-alpine.
NOTE: Current image used is 1.17.10-alpine.

I can take care of this if needed, please let me know.

Please. It's ready for you to do it.

Please push to the following branch:
update-nginx


Increase accessibility of Toggle and update Docs

Increase accessibility of Toggle and update Docs
This PR increases the accessibility of the Toggle and ToggleGroup components.
Toggle

Includes aria-pressed and type=‘button’ as attributes, as discussed in #121

Toggle Group

add prop role, that defaults to 'group'.

This is consistent with Radix UI.
allows users to change the role in the rare cases where group might not be an appropriate role.

Type Inference in Toggle and ToggleGroup
The only changes that might be objectionable are in commit 813abbab1645832ca6815a8eed35581ae60e0623. I explicitly set the props types instead of inferring from $$Props as it was incorrectly inferring that the variable could be undefined.

It can be undefined outside of the component but not within the component.

@TGlide, I reverted to the previous method of type inference that used $$Props. You are correct; that is the correct way to infer types. I had never come across the case mentioned in the docs that occurs with Stores.
Learning something new every day! 😄