Sonarr works but Radarr goes 404?

Hi,
So this tests successfully - /api/v1/notify/sonarr
But when I go to Radarr and test with this, it goes 404 - /api/v1/notify/radarr
Any idea why please?
I am using the latest Docker image.
This is the Docker log -
Filtered out event: Ignoring Sonarr event type: 'Test'

[2018-08-31 11:19:07 +0100] - (sanic.access)[INFO][1:9]: POST http://<IP_ADDRESS>:8086/api/v1/notify/sonarr  200 115

[2018-08-31 11:19:12 +0100] [217] [ERROR] Traceback (most recent call last):

  File "/usr/lib/python3.6/site-packages/sanic/app.py", line 546, in handle_request

    handler, args, kwargs, uri = self.router.get(request)

  File "/usr/lib/python3.6/site-packages/sanic/router.py", line 344, in get

    return self._get(request.path, request.method, '')

  File "/usr/lib/python3.6/site-packages/sanic/router.py", line 393, in _get

    raise NotFound('Requested URL {} not found'.format(url))

sanic.exceptions.NotFound: Requested URL /api/v1/notify/radarr not found

Traceback (most recent call last):

  File "/usr/lib/python3.6/site-packages/sanic/app.py", line 546, in handle_request

    handler, args, kwargs, uri = self.router.get(request)

  File "/usr/lib/python3.6/site-packages/sanic/router.py", line 344, in get

    return self._get(request.path, request.method, '')

  File "/usr/lib/python3.6/site-packages/sanic/router.py", line 393, in _get

    raise NotFound('Requested URL {} not found'.format(url))

sanic.exceptions.NotFound: Requested URL /api/v1/notify/radarr not found

[2018-08-31 11:19:12 +0100] - (sanic.access)[INFO][1:9]: POST http://<IP_ADDRESS>:8086/api/v1/notify/radarr  404 52

The readme is somewhat inconsistent, in the limitations section is states:

only Sonarr Download notification

To bad, I would've liked a working solution for both Radarr and Sonarr

Hi. I recommend to look at Bazarr as a replacement of Dopplerr. It does a better job than Dopplerr:)
PS: I recommend to look at the suitarr docker images in your use docker


I1202 cannot select kip as source

Remove '/header.xml' from string returned from file selection dialog.

An error occurred during the creation of the branch - closing.


Kudos timestamps

FEATURE OVERVIEW
User Story
As a data-s-person I want to know when a person has Kudo'ed an item. 💟
Why This Matters
The Doctor (@Bladt)™ says we need to know.

The Doctor!

[x] update kudos database schema
[ ] store timestamps on new kudos


Boxing gloves broke

Description

They just act like regular punches now, presumably not properly applying the effects of boxing.

Fixed by https://github.com/space-wizards/space-station-14/pull/11841


Correct the way of joining sessions (let's take info about only the last month)

For issue: https://github.com/fishtown-analytics/snowplow/issues/68

Thanks for making this PR @sphinks! I need to think a lot harder about the way this package should change. I'm very open to change like this, but I'd like to discuss the implementation further in #68 first!
I won't be able to get back to this in the very near term, but we are super interested in speeding up this package, and a mechanism like you've provided here is a very good way to do that! If this works for you, I'd recommend running your package from your fork for the time being. Just wanted to give you a heads up!

@drewbanin Thanks, I will continue trying to speed up the package.

Closing PR as it not valid anymore. There will be another PR that allows speed up model.


Bump version. 1.10.2-alpha.2

Test are green. TestCafe build bot didn't add a comment again.

Test are green. TestCafe build bot didn't add a comment again.


Add support for all Watson Services

This should be converted into an epic with an issue for each of the services (these are the important ones for now)

[ ] Conversation
[ ] Discovery
[ ] Speech to Text
[ ] Text to Speech
[ ] Visual Recognition
[ ] Language Translator
[ ] Personality Insights
[ ] Tone Analyzer

The following are either deprecated, low priority or will be changing soon:

[ ] Document Conversion
[ ] Natural Language Classifier
[ ] Retrieve and Rank
[ ] Alchemy Data News
[ ] Tradeoff Analytics

I created a spreadsheet showing what has been supported sofar. If you would like write access please message me with your email.
https://docs.google.com/spreadsheets/d/12FZ2kVh1TNDGGgAYY0sEBx0ueKVKNooeGXINba0SsBo/edit?usp=sharing

This was completed


Unable to authenticate via EAP-PEAP-MSCHAPv2

When testing this, I was unable to use EAP-PEAP-MSCHAPv2.
I have checked both password was correct.
Digging into the logs, the formatting of NT-Hash might be the issue
(13) rest_passwords: Adding reply:REST-HTTP-Status-Code = "201"
(13) rest_passwords: Parsing attribute "control:NT-Password"
(13) rest_passwords: EXPAND <redacted>
(13) rest_passwords: --> <redacted>
(13) rest_passwords: NT-Password := 0x<redacted>
(13) rest_passwords: Parsing attribute "control:SSHA2-512-Password"
(13) rest_passwords: EXPAND <redacted>
(13) rest_passwords: --> <redacted>
(13) rest_passwords: SSHA2-512-Password := 0x<redacted>

(13) eap_mschapv2: Auth-Type MS-CHAP {
(13) mschap: WARNING: NT-Password has not been normalized by the 'pap' module (likely still in hex format). Authentication may fail
(13) mschap: WARNING: No Cleartext-Password configured. Cannot create NT-Password
(13) mschap: Creating challenge hash with username: test
(13) mschap: Client is using MS-CHAPv2
(13) mschap: ERROR: FAILED: No NT-Password. Cannot perform authentication
(13) mschap: ERROR: MS-CHAP2-Response is incorrect
(13) eap_mschapv2: [mschap] = reject
(13) eap_mschapv2: } # Auth-Type MS-CHAP = reject
(13) eap_mschapv2: MSCHAP-Error: ?E=691 R=1 C=fdb45badccc2323b97862a2f575ef9c7 V=3 M=Authentication rejected
(13) eap_mschapv2: Found new challenge from MS-CHAP-Error: err=691 retry=1 challenge=fdb45badccc2323b97862a2f575ef9c7
(13) eap_mschapv2: ERROR: MSCHAP Failure

Thanks for posting the issue, I assume you have some expertise in FreeRadius based on the investigation you have done so far.
Currently I don't have my development environment on hand. Can you help me to investigate by pasting an example of correct NT-Hash provided to radiusd? This could be achieved by using file-based password storage.

Apparently, The correct format is NT-Password := 0x
Here are the changes
*** packages/supervisor/src/rlm_rest/types/passwordAuth-orig.ts Mon May 13 11:50:40 2024
--- packages/supervisor/src/rlm_rest/types/passwordAuth.ts      Mon May 13 11:45:10 2024
***************
*** 67,73 ****
      ({ cleartext, nt, ssha, ssha512 }) => {
          const response: t.TypeOf<typeof EncodedRlmRestPasswordAuthResponseType> = {}
          if (cleartext) response["control:Cleartext-Password"] = cleartext
!         if (nt) response["control:NT-Password"] = nt
          if (ssha) response["control:SSHA-Password"] = ssha
          if (ssha512) response["control:SSHA2-512-Password"] = ssha512
          return EncodedRlmRestPasswordAuthResponseType.encode(response)
--- 67,73 ----
      ({ cleartext, nt, ssha, ssha512 }) => {
          const response: t.TypeOf<typeof EncodedRlmRestPasswordAuthResponseType> = {}
          if (cleartext) response["control:Cleartext-Password"] = cleartext
!         if (nt) response["control:NT-Password"] = `0x${nt}`
          if (ssha) response["control:SSHA-Password"] = ssha
          if (ssha512) response["control:SSHA2-512-Password"] = ssha512
          return EncodedRlmRestPasswordAuthResponseType.encode(response)

Aside from this, for some reason, the certificate created by PKI will cause my Samsung S23 to crash and restart. The only alternative is to not validate the certificate, which is bad for security. I don't have a clue why this happens.

Apparently, The correct format is NT-Password := 0x
Here are the changes

Thank you for proposing a fix. Would you open a PR so I can merge your fix?

Aside from this, for some reason, the certificate created by PKI will cause my Samsung S23 with the latest update to crash and restart. Older versions are not affected.

Unfortunately I don't have a Samsung device on hand. While I'm fixing #9, my OnePlus 9 works from Android 12 to 14.
To help you to resolve on this, can you open another issue with your current Android version, and ideally with a sample P12 file and any Android-generated logs?


Add support to int constructor with str and bytes values

Related issue
#770
Summary or solution description
It fixed incorrect type-checking validation that caused this implementation of the int constructor not to compile.
How to Reproduce
https://github.com/CityOfZion/neo3-boa/blob/499b46534aad1d244df0793baf82d210ef8c2d6f/boa3_test/test_sc/built_in_methods_test/IntStr.py#L4-L7
Tests
https://github.com/CityOfZion/neo3-boa/blob/499b46534aad1d244df0793baf82d210ef8c2d6f/boa3_test/tests/compiler_tests/test_builtin_method.py#L2270-L2476
Platform:

OS: Windows 10 x64
Python version: Python 3.7+

Task linked: CU-2ewekq9 Add support to int constructor with str and bytes values

Coverage: 91.43% (+0.4%) from 90.992% when pulling 4dee846733014ddc473cae077ae3b202e489a2e5 on CU-2ewekq9 into ab71cd53dd035cab88ce39368bed8557b71a3b88 on development.


[DOCS] PhysicsDirectSpaceState updates

Updates the docs for PhysicsDirectSpaceState.cast_motion to reflect the changes mentioned in https://github.com/godotengine/godot/issues/21212#issuecomment-423780563. There are also some minor changes for both PhysicsDirectSpaceState and Physics2DDirectSpaceState.

Thanks!

Nice work thanks you :)


Remove outdated warning about version 1.0.0

Version 1.0.4 works with current stemcells.

Hi @leaf-sigsci
I just saw that you removed the warning that v1.0.0 doesn't work with Xenial stemcells.
Why is that? I appreciate that v1.0.4 works with Xenial, but shouldn't users who haven't upgraded to v1.0.4 be warned that they can't use Xenial stemcells?

Hi Jane, that makes complete sense; i was asked to remove the warning because it seemed to leave the impression with readers that the tile, overall, was not supported on newer stemcells.
I pointed out that 1.0.4 != 1.0.0, but it didn't seem obvious enough.
I'll try to write up something of a compromise and re-submit the PR.

@jncd: is the current state of this change better?

No 1.0.0 version is live anymore, so closing this out


Bug 1952610: Bump dependencies

To support new AWS regions, we need to use a newer version of aws-sdk-go.

/hold
Tests are failing, needs investigation.

/retest

/hold cancel

/cherry-pick release-4.7


Unhandled rejection TypeError: expecting an array or an iterable object but got [object Null]

The 3.0.0 upgrade seems to have broken my web scraper. I get the following error message when trying to run this code:
I've deleted the node_modules directory and reinstalled all modules, as well as creating a new project with barebones code. The issue still persists, but disappears after I roll back bluebird to v2.10.2.
Unhandled rejection TypeError: expecting an array or an iterable object but got [object Null]
    at apiRejection (<dir>/node_modules/bluebird/js/release/promise.js:10:27)
    at PromiseArray.init [as _init] (<dir>/node_modules/bluebird/js/release/promise_array.js:62:19)
    at Promise._settlePromise (<dir>/node_modules/bluebird/js/release/promise.js:546:21)
    at Promise._settlePromise0 (<dir>/node_modules/bluebird/js/release/promise.js:594:10)
    at Promise._settlePromises (<dir>/node_modules/bluebird/js/release/promise.js:677:18)
    at Promise._fulfill (<dir>/node_modules/bluebird/js/release/promise.js:618:18)
    at Request._callback (<dir>/node_modules/bluebird/js/release/nodeback.js:42:21)
    at Request.self.callback (<dir>/node_modules/request/request.js:198:22)
    at emitTwo (events.js:87:13)
    at Request.emit (events.js:172:7)
    at Request.<anonymous> (<dir>/node_modules/request/request.js:1082:10)
    at emitOne (events.js:82:20)
    at Request.emit (events.js:169:7)
    at IncomingMessage.<anonymous> (<dir>/node_modules/request/request.js:1009:12)
    at emitNone (events.js:72:20)
    at IncomingMessage.emit (events.js:166:7)

promisify no longer makes multi-callback methods return arrays. This will break every single promisify call on request :(

It looks like I've got some reading & experimenting to do tonight. Thanks for letting me know.


aktualizr: use https protocol to fetch it

github decided that nobody should use git://
https://github.blog/2021-09-01-improving-git-protocol-security-github/#no-more-unauthenticated-git
and starting today all the builds were failing to fetch the metadata
layers from github like:
2021-11-01T18:53:26 INFO main Updating [meta-ros]
fatal: remote error:
The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
this was just a "test" as they said:
"November 2, 2021: We'll also run several short brownouts on this date."
and it will be completely disabled on January 11 2022.

Signed-off-by: Martin Jansa<EMAIL_ADDRESS>

This seems like something that could/should be fixed upstream, right? Otherwise we have to adjust literally every github URL in the entire OE/Yocto universe...
But it looks fine to me if that's not an option.

This seems like something that could/should be fixed upstream, right? Otherwise we have to adjust literally every github URL in the entire OE/Yocto universe...

Other upstream metadata layers already have fixes like this in the metadata.
For old releases there is a work around in bitbake to automagically use protocol=https when host is github.com.
As you're actively maintaining other branches, then this should be backported to dunfell, gatesgarth, hardknott as well, so that it doesn't depend on bitbake magic.

But it looks fine to me if that's not an option.

See https://lists.openembedded.org/g/openembedded-architecture/message/1333 for more background.

See https://lists.openembedded.org/g/openembedded-architecture/message/1333 for more background.

Personally I feel like it makes a lot more sense to rely on the internal bitbake mechanism than updating every single recipe in every supported branch. But if that's the norm, I don't really feel like arguing.

As you're actively maintaining other branches, then this should be backported to dunfell, gatesgarth, hardknott as well, so that it doesn't depend on bitbake magic.

dunfell is reasonably actively maintained, but I'd use the term lightly for gatesgarth, hardknott, and honister. AFAIK no one has actually tried to use them.


[WIP] Try to improve CI times

Summary
The step "Integration Linux" is identical to two steps in stanc3's CI ("Compile tests - good" and "Compile tests - example models") but takes ~3 hours while those two combined take 65 minutes. So far as @serban-nicusor-toptal and I can tell, the only difference between the two setups is PRECOMPILED_HEADERS and the misspecified PARALLEL setting.
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

@rok-cesnovar we'd also appreciate if you had any thoughts on why the two would be so different here

These changes immediately dropped that step from 3 hours down to 59 minutes, which is great. I think this is ready for review, unless @rok-cesnovar has further suggestions or any objections.
If I recall correctly, the reason we had these disabled was due to them causing intermittent failures on the Amazon EC2 instances. I think that the Flatiron machines mean we need to be less cautious (clearly the Stanc3 workflow has worked in that repo)


Build with profile guided optimization (PGO)

https://go.dev/doc/pgo
Seems easy enough to collect profiling metrics before we build releases, and feed them to those builds. I guess we could just run go test and go run main.go lint bundle with profiling for a start. Not sure if it's worthwhile doing something more advanced, like pulling down some large policy repo to run on, but we could try.

Initial testing of this tonight doesn't show much of an improvement, if any :( Perhaps one would need to run the CPU profiler against tons of repos in order to accomplish anything, but building with a CPU profile from linting the Kics repo, and then lintting the Kics repo again using the PGO binary gives... nothing, even after several attempts. I'll close this for the time being, but if someone else wants to pick this up and prove me wrong, that'd be awesome :)


Space ninja shoes' magnetic suction cups aren't magnetic

Description
It says in the item's description: "A pair of nano-enhanced boots with built-in magnetic suction cups."
The shoes are not magnetic however and a ninja has to rob engineering or some other place for magboots when there's no gravity.

with item toggle refactor it should be as shrimple as adding MagbootsComponent without toggle so theyre always on :trollface:

It'd probably a bugfix if anything if it was simply not imported to 14 entirely correctly, surely...


How does Bob load datafolders?

Hello Jed,
I hope you are not offended that I do not use your plugin. So while this is probably something that I could figure out simply by exploring it, I thought perhaps it would be better to just ask you directly.
How do you load data folders in Bob? I have heard rumors that Bob loads data folders differently than TiddlyServer does, but I'm very curious to know how it does that, since I saw that you have two commands that can be used to start the server (three if you count --listen but I don't know if you support that one or not). So I'm curious what the exact mechanism is that you use to handle requests for data folders, specifically whether you start an instance for each data folder and how you do that.
I'm not planning to change how TiddlyServer is designed, because I made it to fill a specific need (running multiple Node TiddlyWiki instances at once), and memory consumption is the only drawback I have run into on a technical level. But I am exploring other areas in the server space and it seems you have already explored some of these areas, so I'm really curious what you've done.
I've heard that Bob doesn't actually load the NodeJS server code, but rather calls bits and pieces of it as necessary to save and load tiddlers. Is that correct, and if so, what has your experience been with that. If it is not necessary to parse wikitext on the server, then we can write TiddlyWiki compatible servers in PHP or any other language we want to and even load folder wikis directly in the browser. So that's my line of thought.

Bob loads data folders using the built-in mechanism that the normal node server uses. It has a server that is almost the same as the normal server but has bits to support web sockets and the BobSaver tacked on. There is a little bit more that lets you set plugin paths and the like without setting environment variables, but they are all straightforward additions.
Bob uses the normal node backend for tiddlywiki, it just doesn't start redundant processes because tiddlyserver kept crashing my little raspberry pi home server and you said you didn't want help making tiddlyserver take less memory or be easier to configure.
So:
Bob uses the full nodejs tiddlywiki code base with the exception of the listen command itself, which is slightly modified to handle web sockets.
There is a bit of glue to allow loading from more than one data folder to avoid the complexity that comes with running different node processes for each wiki and to allow inter-wiki communication.
what you are talking about sounds much more like NoteSelf, I have been considering creating a simpler server in Julia that drops the tiddlywiki backend on the server and has the browser take care of all the rendering. Given what I already have with Bob it should be a pretty trivial setup , it is just a quick database back-end that serves an empty wiki and then whatever tiddlers go along with the wiki, probably determined by path although filters or authentication would be pretty simple to use also.

Bob uses the normal node backend for tiddlywiki, it just doesn't start redundant processes because tiddlyserver kept crashing my little raspberry pi home server and you said you didn't want help making tiddlyserver take less memory or be easier to configure.

I remember that specifically and I always wondered if there was a way to fix it, but until recently I had no way to do that. I'm hoping sometime I'll come up with a GUI for adjusting the settings, but as far as memory usage, I'm pretty sure it's just because of the way I load the entire tiddlywiki environment for each data folder, to keep them isolated and fully functional for development and compatibility. Unfortunately, that's a design constraint of TiddlyServer.
TiddlyServer only ever uses a single Node process, and all wikis are loaded inside that one process. Do you call $tw.boot.boot() for each data folder or do you have some other process that loads the data folder into Bob without actually creating the full server environment?

It uses the normal $tw.loadTiddlersFromPath or whatever it is called to load the data folders. There is no reason to call boot for every one unless you wanted to use different tiddlywiki versions on the server side of them. I have not found anything that uses the back-end to do more than hold and filter tiddlers, so calling the full boot process for each one seems excessive.
path that it gets into how the wiki objects themselves are handled and I don't think that I could explain that any better than just looking at the code.


feat(client): support cache when opening remote data

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

22 of 47 (46.81%)  changed or added relevant lines in 5 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 86.498%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

tensorbay/dataset/dataset.py
0
1
0.0%

tensorbay/client/dataset.py
8
11
72.73%

tensorbay/client/segment.py
5
8
62.5%

tensorbay/utility/file.py
5
23
21.74%

Files with Coverage Reduction
New Missed Lines
%

tensorbay/client/gas.py
3
90.91%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
6387

Relevant Lines:
7384

💛  - Coveralls


QS fails to launch when creating the master node

Getting the error:
14:05:11 UTC-0400 	CREATE_FAILED 	AWS::EC2::Instance 	K8sMasterInstance 	Received FAILURE signal with UniqueId i-XXXXXXXX
The EC2 itself launches but it fails when labeling the master node with the role of master.
Label this node as a master
kubectl label node "$(hostname -f)" "kubernetes.io/role=master"
~$ hostname -f
hostname: Name or service not known

Hello, sorry it took a bit to respond to this.
This seems strange, as it suggests that the EC2 instance doesn't have working networking/DNS configuration by the time the kubectl label step is running.
We've never seen this error on our end, can you give some steps to reproduce?  Are you creating this in a new VPC or an existing one?  Or are you doing something more customized?

I navigate to the Kubernetes Quick Start landing page and click on the link to Deploy on AWS in a new VPC.
Once there, I change my region to us-east-1 then continue on with the necessary parameters.
Once launched, all goes well until it runs the /tmp/setup-k8s-master.sh, when the CFN fails.
This is the error I see in the /var/log/cfn-init.log
# Label this node as a master
kubectl label node "$(hostname -f)" "kubernetes.io/role=master"
hostname -f
hostname: Name or service not known
error: resource name may not be empty

I tried using the IP address itself for the node but that didn't work either, said it was unable to find the node.
I added the line kubectl get nodes above the failure to see what the node and ran the script again:
NAME                         STATUS     AGE       VERSION
ip-10-0-11-32.ec2.internal   NotReady   1s        v1.6.4

What's your VPC configuration? Does your VPC have dns support and dns hostnames enabled?
http://docs.aws.amazon.com/AmazonVPC/latest/UserGuide/vpc-dns.html#vpc-dns-hostnames

Yes - the VPC has both DNS resolution and DNS hostname enabled (set to 'yes').
I changed the command to use -A and awk and it seems to have worked running /tmp/setup-k8s-master.sh
kubectl label node "$(hostname -A | awk -F' ' '{print $1}')" "kubernetes.io/role=master"
hostname -A | awk -F' ' '{print $1}'
node "ip-10-0-11-32.ec2.internal" labeled

Looks like this is a problem with how machines are configured in us-east-1... they have a search path of us-east-1.compute.internal, but the shortname doesn't seem to be valid address under that search path.
The hostname -A approach will probably work fine, I'll see if there's any better way to accomplish this.
Thanks for the report!

I think the issue is the DHCPOptions set we deploy to the VPC. We're configuring the domain name returned by DHCP to be ${AWS::Region}.compute.internal, but according to the docs, us-east-1 is special: if you're using AWS-provided DNS you are supposed to use .ec2.internal as the domain name for your DHCP servers in that region (and only that region.)  See: http://docs.aws.amazon.com/AmazonVPC/latest/UserGuide/VPC_DHCP_Options.html
I'm testing a change that will special-case us-east-1 and fix up the DHCP options for that region.  I think that's a better fix than working around it in the setup phase, because the real problem is that DNS is misconfigured.

I agree, I think your fix will be better than the hack above. Thanks for looking into this.

The fix is now merged into our master branch, but won't be in the production Quick Star template until probably late next week.  In the mean time if you want to run our latest master, instructions are here: https://github.com/heptio/aws-quickstart#deploying-latest-master


Flagged as bacteria for review

Gritola 5th

Review stage should be much more aggressive

Flagged as bacteria has been requested as something to just remoev as it causes issues with some assemblies. Even if it remove some tiny bit of assembly.

To make decon more aggresive.
Genome = get top scaffolds, calc coverage, and use as the TARGET_COV to compare against with coverage of putative contamination.
Tiara = classed as bacteria -> remove
Look at standard deviations from coverage and see how many more scaffolds get removed and whether they are true contamination.


Pressing Ctrl+Q show 31 instead of 17 in the console

Hi, thanks for the great tutorial!
I'm having this issue, maybe it is related to the fact that i'm using abnt-br keyboard layout? idk but it was supposed to show 17, i'll print the code since github doesn't allow to put c files here!

Hey, i fixed it, just changed the keyboard layout to US- International and the console shows 17 instead of 31


ECS & ACI Documentation lacks instructions to enable Experimental features

Problem description
Documentation for both Amazon ECS & Azure ACI integration is missing step to properly setup for a Linux environment. I suspect this only impacts Linux, not Docker Desktop for Mac / Windows - but that is just an assumption.
The ECS documentation states you need the following requirements (emphasis mine):

Install the Docker Compose CLI on Linux
The Docker Compose CLI adds support for running and managing containers on ECS.
Install Prerequisites
Docker 19.03 or later

I did verify I had the latest release of both Docker & Docker Compose installed (see version information below).
If you follow the instructions for Linux, and you attempt to create a new context - the following error occurs:
mike@XPS-13-9360:~/projects/otel-collector$ docker context create ecs staging
"docker context create" requires exactly 1 argument.
See 'docker context create --help'.

Usage:  docker context create [OPTIONS] CONTEXT

Create a context

In troubleshooting the problem, I found someone else who put in a ticket regarding this. I don't think the user's problem was well understood, as the ticket seems to have been closed without actually solving the underling problem.
https://github.com/docker/compose-cli/issues/847
It turns out, with the latest released version of the Docker CLI for Linux, you must enable experimental feature support in order to successfully create a ECS context.
To resolve the problem, I did the following:

Configured experimental support

https://github.com/docker/cli/blob/master/experimental/README.md

Restarted Docker Daemon

sudo systemctl restart docker

After this change, I was able to successfully create a ECS context:
mike@XPS-13-9360:~/projects/otel-collector$ docker context create ecs staging
? Create a Docker context using:  [Use arrows to move, type to filter]
> An existing AWS profile
  AWS secret and token credentials
  AWS environment variables

Problem location
I couldn't find the information I wanted. I expected to find it near the following URL:

https://docs.docker.com/engine/context/ecs-integration
https://docs.docker.com/engine/context/aci-integration/

Project version(s) affected
mike@XPS-13-9360:~$ docker --version
Docker version 19.03.14, build 5eb3275d40

mike@XPS-13-9360:~$ docker-compose --version
docker-compose version 1.23.2, build 1110ad01

Suggestions for a fix
Please consider adding information about enabling experimental features within the documentation.

Is there anything else than enabling experimental mode in both the server and client required for docker context create ecs … to work?
I am going crazy. I got it to work locally but now I'm trying to make it work on Gitlab CI, and, well:

Experimental: true on both client and server…

Same problem here with Azure, experimental features enabled. Version: 20.10.1 on Linux
docker context create aci azureaci
"docker context create" requires exactly 1 argument.
See 'docker context create --help'.

Usage:  docker context create [OPTIONS] CONTEXT

Create a context

Same error for me on Ubuntu 20.04

The issue is still here on Linux with Docker version 20.10.5

Anyone still having this issue, the solution here worked: https://github.com/docker/docker.github.io/issues/11949#issuecomment-778178431
Please make sure to reload your current shell session by closing/restarting all shell windows.

Perhaps I wasn't restarting the docker Daemon correctly on Mac but I had to follow mjpowersjr solution and then uninstall Docker Desktop entirely and reinstall it (it wouldn't update due to some issues)

For me, on Linux, I had to install "Docker Compose CLI", (which is different from "Docker Compose" and "Docker Compose V2"):

https://docs.docker.com/cloud/ecs-integration/#install-the-docker-compose-cli-on-linux
https://github.com/docker/compose-cli/blob/main/INSTALL.md

Then I had to exit and re-enter the shell to see the $ docker context create ecs myecscontext command work successfully.

Anyone still having this issue, the solution here worked: #11949 (comment)
Please make sure to reload your current shell session by closing/restarting all shell windows.

I have no idea why It's worked because I already docker-compose with Docker Compose version v2.2.3 installed but now is work.

Anyone still having this issue, the solution here worked: #11949 (comment)
Please make sure to reload your current shell session by closing/restarting all shell windows.

I've already had the Docker Compose version v2.2.3 when I tried docker context create ecs myecscontext. I installed the docker-compose again as you suggested and it worked. I checked the version and it was the same I was using before. I have no idea why it worked, but thank you.

Can I use this docker ecs setup in v2?

For those on linux trying to get this to work with ECS:
enable experimental features in docker
restart the docker daemon (systemctl restart docker or the like)
install the docker compose-cli binary
restart the docker daemon (for good measure)
reinitialize the shell environment (easiest to exit from the current shell and create a new one)


remove hard dependency on go-kit

As discussed in #27. This library's needs are simple, so a small interface should suffice. In general, a library should allow plugging in any suitable logging implementation, instead of hard-coding one in particular.
Particularly worrying since the go-kit module is massive, and we don't want to force all ircx users to pull it as a dependency too.
Will send a PR soon.

Hmmm, ircx also uses level, which does more than just using go-kit's logger. Do we really need logging levels beyond "error" and "verbose/debug"? With those two, it's trivial to just add Config.Verbose, so that verbose logs are enabled too. Then we can drop the dependency on level, and on the entirety of go-kit.
@nickvanw thoughts? go-kit contains dozens of packages and tens of thousands of lines of code, so I really don't think it's worth pulling it in to just have a few log lines at different levels.

I would love to get rid of the entirety of go-kit and level, which I think is all overkill. Based on your earlier recommendation, I'm going to switch over to using logrus which is self-contained, offers all of the same features, and something that I have much more experience with.
I'm not sure why I went with go-kit in the first place, but I'm working on a PR now that will switch everything over.
Sorry this has taken so long - the last while at work has been super busy, and I haven't had much time or mental energy for coding outside of work.


Uncaught TypeError: this.getFilename is not a function, when trying to add shapes to custom libraries

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
Trying to add a shape to custom library in draw.io desktop v12.9.13 results in an error "Uncaught TypeError: this.getFilename is not a function"
To Reproduce
Steps to reproduce the behavior:

Open a new drawing (File>New)
Create a new library (File > New Library..)
Create a shape and select it
Add to new library by clicking on "+"
Save the library
Save the file
Exit draw.io desktop
Run draw.io desktop
Add another shape to drawing and select it
Add to the custom library by clicking on "+"

Results in an error
Uncaught TypeError: this.getFilename is not a function
Expected behavior
Shapes should get added to custom library even after draw.io is restarted.
Screenshots

draw.io version (In the Help->About menu of the draw.io editor):

draw.io version 12.9.13 (edited from earlier typo)

Desktop (please complete the following information):

macOS Catalina 10.15.4
Using draw.io desktop

Smartphone (please complete the following information):

Not using smartphone

Additional context

This seems to happen only on desktop version and not web version
The standard "scratchpad" is unaffected, only custom lib, after saving once and reloading the desktop app start giving the error

Is it 12.9.13 or 12.9.14? When did you download this and where from?

This is 12.9.13 and I downloaded it few days ago from GitHub release page. After I noticed the problem, I removed it completely (including settings and other data files on my Mac) and downloaded it again.. Still, same error.

oops.. just noticed I wrote 12.9.14 in my original post. Sorry, ny bad.. its 12.9.13

Thanks for the report. This will be fixed in the next release.

I am getting the same problem on Windows version 13.0.1...

@stevenilsen123 Following exactly the same steps as OP?

I also have the exact same issue on 13.0.1/macOS 10.15.4.  The same reproduce steps as the OP.  draw.io is installed via homebrew.

This will be fixed in 13.0.2.


Add ignore_initial_volumes param to ConfoundsCorrelationPlot

Related to https://github.com/nipreps/fmriprep/issues/2614. Once this is merged and there's a new release, I will open a PR to fMRIPrep.
Changes proposed:

Add an ignore_initial_volumes parameter to the ConfoundsCorrelationPlot interface.
Add an ignore_initial_volumes parameter to the confounds_correlation_plot function.
Use the new parameter in related smoke tests.

@tsalo Can you duplicate this in nireports? https://github.com/nipreps/nireports/blob/main/nireports/interfaces/nuisance.py

Can do!

😱 I didn't actually use the parameter in this PR!!!


OM 2.0: Consider relaxing the requirement for counters timeseries to have a _total suffix

The 1.0 specification for counters reads:

The MetricPoint's Total Value Sample MetricName MUST have the suffix "_total".

I propose this should be changed to SHOULD have the suffix "_total" for 2.0.
It is a best practice in Prometheus to suffix counters with _total, but other libraries, such as OpenTelemetry, include counters without a _total suffix.  It is much nicer to be able to query for rate({"my.counter"}[5m]) than rate({"my.counter_total"}[5m]) for a metric defined as "my.counter".

I'm very much in favor for this one :)
I can see another downside to not having the suffix: Prometheus today relies on the suffix to provide query annotations, like "You shouldn't use delta() with counters!!!". We would need to think of another strategy there, but I think we're already covering it somewhere else :)

If _total is just a normal part of the name, then the created name would be foo_total_created. However, IIRC, we want to get rid of the _created line anyway, don't we?
Classic histograms and summaries will stay as they are, of course. This was also the case with the old text format. Those suffixes also have been mandatory always.
The OM intention was to make _total mandatory, and then all those changes make sense. But if we decide to not make it mandatory, then also those other decisions don't make sense anymore.

Also, note #283 which solves the suffix problems for summaries and classic histograms.


MaxSizeInMegabytes is ignored and always sets the queue to 16GB

It seems that no matter what value to provide to the MaxSizeInMegabytes property, the queue is always created with the max size of 16GB, is this expected?
The following simple code to create a queue highlights this problem.
using (var managementClient = new ServiceBusManagementClient(new TokenCredentials(accessToken)))
{
    managementClient.SubscriptionId = "MySubsciptionId";
    var queueParams = new SBQueue
    {
      EnablePartitioning = true,  // <-- Only when this is true
      MaxSizeInMegabytes = 2048  // <-- Get ignored, even if not setting the property at all, the default is 16GB not 1GB as stipulated by the documentation.
    };

    await managementClient.Queues.CreateOrUpdateAsync(Constants.ResourceGroupName, Constants.NamespaceName, "TwoGBQueue", queueParams);
}

The documentation claims the default it 1GB, but the queue is always created as a 16GB queue.

I've figured out that this only happens when you have EnablePartitioning switched on. Setting that to false honors the max size setting. Would certainly help having the documentation highlight this to avoid confusion.

@brutaldev - thanks for bringing this to our attention. This has already been documented here.
I'm closing the issue for now, but please feel free to reopen if you still have questions.


jax -> jtu for relevant functions

There were still cases of deprecation warnings coming from jtu functions being called from jax directly. This PR fixes these cases by replacing jax with jtu for all functions in jax.tree_util. These were tree_leaves, tree_transpose and tree_unflatten.

Looks like pre-commit checks are failing. (Should be an easy enough fix.)

Apologies for not running the tests myself. I did attempt to follow the guidelines but the compute terminals I was using weren't playing well with pytest. I figured that because the changes were so small there wouldn't be any problems. I hope that's the case now.

Merged - thank you!


Testing PR checks

Just testing to see if I can get a PR-triggered workflow to correctly use the action defined in the PR.
Using a Draft PR, not sure if that will affect checks running...
Edit: sweet, they still do

@webbertakken Ok so that last check run was enlightening. See the results here. I tweaked builder/entrypoint.sh so it just logs something then early exits. When I pushed that commit, the workflow was triggered in this repo, and the Action output shows the log message. In other words, the workflow did run the latest code present in the PR.

Could you be more specific when you say this repo?
Please note that I don't have variables for Pro license defined.

So from this last check run I think I've identified the issue that we've been looking for since I opened webbertakken/unity-actions#26. It looks like the UNITY_* environment variables are simply empty when the workflow runs. I tested this by logging process.env in the Action's builder/index.js file, and then logging UNITY_EMAIL in activate.sh (not the most secure thing to do in hindsight, but luckily nothing was printed). See the results here.
Again, UNITY_LICENSE, UNITY_SERIAL, UNITY_EMAIL, and UNITY_PASSWORD are all defined in the PR workflow, they're just apparently empty by the time this action runs. I have no why that would be. My fork has those secrets defined too, so even if the Action we're using the fork's secrets, they should be non-empty...

Could you be more specific when you say this repo?

I mean unity-builder...comment edited.


enable lint on published catalogs

Add support for folders on catalogcd-cmd lint
Add "stable" to generated catalogs and linting

Depends on #33

/hold

/hold cancel


Placeholder to investigate buffer adherence within KCL applications

PR: https://github.com/awslabs/amazon-kinesis-connectors/pull/75
Essentially the idea is that at the moment the Buffer is not adhered too if GetRecords returns a chunk of events greater than the buffer settings.  Solutions to this are to either:

Write buffer splitters to ensure that what we send correlates to the buffer settings, however we then cannot checkpoint until we send each slice which adds a risk of double sending data if some slices succeed but others do not or if the application crashes midway through processing a Buffer.
Greatly reduce the GetRecords amount so that it is closer to the Buffer settings we want to use.  This is not an efficient solution however and does not have any reasoning around Byte or Time limits.

Migrated to https://github.com/snowplow/enrich/issues/114


How to Disable Scroll of Scrollable Layout

Just call setSelfUpdateScroll(boolean) and pass true there (it means ScrollableLayout won't process touch events)


[Minor] Adding some doc on the benchmarks + requirements file

(easier to maintain for CI + something to look for when getting started)

Is pandas a requirement outside of tests and benchmarks? :o

Ah that's right, in triton.testing. Probably the right thing to do here is to remove the pandas dependency rather than add it as a requirement :p

Ah that's right, in triton.testing. Probably the right thing to do here is to remove the pandas dependency rather than add it as a requirement :p

it's there for the plots and some stats, I think that it's fine but it was a mistake to put it as a general requirement indeed. I moved that to requirements_bench only, let me know what you think


NextJS 13.0 new 'app' dir feature

How about adding app dir feature in the future?

I'm currently waiting for app dir come out from the beta. But, totally open to suggestion or open to pull request if someone want to try before
app dir has still some unimplemented feature: https://beta.nextjs.org/docs/app-directory-roadmap#planned-features

Thank you for your answer.

it's out of beta. It can be implemented now.


add support for mode and other kwargs in compress function

Hi, thanks for the great cffi wrapper!
It would be nice if the signature of the compress function could match the one from brotlimodule.cc at https://github.com/google/brotli/blob/master/python/brotlimodule.cc#L93
compress(string, mode=MODE_GENERIC, quality=11, lgwin=22, lgblock=0, dictionary='')

That would allow me to drop in brotlipy as a replacement for google/brotli CPython bindings.
Cheers,
Cosimo

This is a great idea. I'll tackle this after the move to brotli 0.5.1, which should let me throw away my C-based wrapper for the C++ based encoder.

So, after #36 is merged we can look to extend the API to add all those flags. =)

great, thanks!


WIP: Add support for buildPythonPackage

Hi @jtojnar:
I've started trying to add support for checking the arguments to buildPythonPackage as an addition to the current checking of the arguments to mkDerivation. So far, it appears to mostly work, although I can't yet seem to get it to report multiple failures at once -- the checks appear to short-circuit once a single failing check is identified.
Still WIP, but I wanted to post this now for any feedback.

I have a few ideas if you are interested:

check for duplications in propagatedInputs with checkInputs.
check for impure python imports which pull in another python version

I have a few ideas if you are interested:

check for duplications in propagatedInputs with checkInputs.
check for impure python imports which pull in another python version

I think I'm actually hitting this bug/issue, and I'm not sure how to solve it yet: https://github.com/NixOS/nixpkgs/issues/44426

I think I'm actually hitting this bug/issue, and I'm not sure how to solve it yet: https://github.com/NixOS/nixpkgs/issues/44426

Try https://github.com/NixOS/nixpkgs/pull/107044#discussion_r546236396?

Try https://github.com/NixOS/nixpkgs/pull/107044#discussion_r546236396?

Thanks for the hint. Let me bang my head against that for a bit.

Thanks for the hint. Let me bang my head against that for a bit.

@jtojnar: Awesome! Thank you. I think this structure roughly works
# example.nix
let
    idOverlay = final: prev: {};
    composeOverlays = old: new:
        final: prev: new final (old final prev);

    pkgs = import <nixpkgs> {
        overlays = [
             (self: super: {
                python3 = super.python3.override (oldOverrides: {
                    packageOverrides = composeOverlays (idOverlay) (python-self: python-super: {
                        buildPythonPackage = args: let
                            # note: here i unfortunately can't use python-super.buildPythonPackages,
                            # instead i need to get it off super because of the way composeOverlays
                            # works
                            originalDrv = super.python3.pkgs.buildPythonPackage args;
                        in
                            super.lib.recursiveUpdate originalDrv {
                            __nixpkgs-hammering-state = {
                                 reports = (originalDrv.__nixpkgs-hammering-state.reports or []) ++ [1];
                            };
                        };
                    });
                });
            })
             (self: super: {
                python3 = super.python3.override (oldOverrides: {
                    packageOverrides = composeOverlays (idOverlay) (python-self: python-super: {
                        buildPythonPackage = args: let
                            # see note above
                            originalDrv = super.python3.pkgs.buildPythonPackage args;
                        in
                            super.lib.recursiveUpdate originalDrv {
                            __nixpkgs-hammering-state = {
                                 reports = (originalDrv.__nixpkgs-hammering-state.reports or []) ++ [2];
                            };
                        };
                    });
                });
            })
        ];
    };

in pkgs.python3Packages.numpy.__nixpkgs-hammering-state.reports or []

$ nix-instantiate --strict --json --eval --show-trace debug.nix
[1,2]

@jtojnar: Awesome! Thank you. I think this structure roughly works
# example.nix
let
    idOverlay = final: prev: {};
    composeOverlays = old: new:
        final: prev: new final (old final prev);

    pkgs = import <nixpkgs> {
        overlays = [
             (self: super: {
                python3 = super.python3.override (oldOverrides: {
                    packageOverrides = composeOverlays (idOverlay) (python-self: python-super: {
                        buildPythonPackage = args: let
                            # note: here i unfortunately can't use python-super.buildPythonPackages,
                            # instead i need to get it off super because of the way composeOverlays
                            # works
                            originalDrv = super.python3.pkgs.buildPythonPackage args;
                        in
                            super.lib.recursiveUpdate originalDrv {
                            __nixpkgs-hammering-state = {
                                 reports = (originalDrv.__nixpkgs-hammering-state.reports or []) ++ [1];
                            };
                        };
                    });
                });
            })
             (self: super: {
                python3 = super.python3.override (oldOverrides: {
                    packageOverrides = composeOverlays (idOverlay) (python-self: python-super: {
                        buildPythonPackage = args: let
                            # see note above
                            originalDrv = super.python3.pkgs.buildPythonPackage args;
                        in
                            super.lib.recursiveUpdate originalDrv {
                            __nixpkgs-hammering-state = {
                                 reports = (originalDrv.__nixpkgs-hammering-state.reports or []) ++ [2];
                            };
                        };
                    });
                });
            })
        ];
    };

in pkgs.python3Packages.numpy.__nixpkgs-hammering-state.reports or []

$ nix-instantiate --strict --json --eval --show-trace debug.nix
[1,2]

This PR should be working now. I've force pushed and separated the commits into individual units.
I'm new to this codebase, and fairly new to nix in general, so any feedback would be appreciated. I'm sure I'm messing some things up.
Here's an example running with c64f442 and the new checks:
# hacked nixpkgs/pkgs/development/python-modules/aiostream/default.nix, with lots of bugs injected
{ lib
, buildPythonPackage
, numpy
}:

buildPythonPackage rec {
  pname = "aiostream";

  pythonImportCheck = [ "aiostream" ];  # typo
  propagatedBuildInputs = [ numpy ];
  checkInputs = [ numpy ];  # duplicate
  checkPhase = ''
    pytest
  '';  # unnecessary

  meta = with lib; {
    license = licenses.gpl3;  # deprecated
  };
}

Producing the output
$ ./tools/nixpkgs-hammer -f ~/projects/nixpkgs python38Packages.aiostream
When evaluating attribute ‘python38Packages.aiostream’:
warning: duplicate-check-inputs
Dependencies listed in propagatedBuildInputs shouldn't be repeated in checkInputs.

Near /home/mcgibbon/projects/nixpkgs/pkgs/development/python-modules/aiostream/default.nix:11:3:
   |
11 |   checkInputs = [ numpy ];  # duplicate
   |   ^
Near /home/mcgibbon/projects/nixpkgs/pkgs/development/python-modules/aiostream/default.nix:10:3:
   |
10 |   propagatedBuildInputs = [ numpy ];
   |   ^
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/duplicate-check-inputs.md
warning: python-explicit-check-phase
Consider using pytestCheckHook in checkInputs rather than checkPhase="pytest".

Near /home/mcgibbon/projects/nixpkgs/pkgs/development/python-modules/aiostream/default.nix:12:3:
   |
12 |   checkPhase = ''
   |   ^
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-explicit-check-phase.md
warning: python-imports-check-typo
A typo in pythonImportsCheck was detected.

Near /home/mcgibbon/projects/nixpkgs/pkgs/development/python-modules/aiostream/default.nix:9:3:
  |
9 |   pythonImportCheck = [ "aiostream" ];  # typo
  |   ^
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-imports-check-typo.md
warning: unclear-gpl
`gpl3` is a deprecated license, check if project uses `gpl3Plus` or `gpl3Only` and change `meta.license` accordingly.

Near /home/mcgibbon/projects/nixpkgs/pkgs/development/python-modules/aiostream/default.nix:17:5:
   |
17 |     license = licenses.gpl3;
   |     ^
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

This PR should be working now. I've force pushed and separated the commits into individual units.
I'm new to this codebase, and fairly new to nix in general, so any feedback would be appreciated. I'm sure I'm messing some things up.
Here's an example running with c64f442 and the new checks:
# hacked nixpkgs/pkgs/development/python-modules/aiostream/default.nix, with lots of bugs injected
{ lib
, buildPythonPackage
, numpy
}:

buildPythonPackage rec {
  pname = "aiostream";

  pythonImportCheck = [ "aiostream" ];  # typo
  propagatedBuildInputs = [ numpy ];
  checkInputs = [ numpy ];  # duplicate
  checkPhase = ''
    pytest
  '';  # unnecessary

  meta = with lib; {
    license = licenses.gpl3;  # deprecated
  };
}

Producing the output
$ ./tools/nixpkgs-hammer -f ~/projects/nixpkgs python38Packages.aiostream
When evaluating attribute ‘python38Packages.aiostream’:
warning: duplicate-check-inputs
Dependencies listed in propagatedBuildInputs shouldn't be repeated in checkInputs.

Near /home/mcgibbon/projects/nixpkgs/pkgs/development/python-modules/aiostream/default.nix:11:3:
   |
11 |   checkInputs = [ numpy ];  # duplicate
   |   ^
Near /home/mcgibbon/projects/nixpkgs/pkgs/development/python-modules/aiostream/default.nix:10:3:
   |
10 |   propagatedBuildInputs = [ numpy ];
   |   ^
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/duplicate-check-inputs.md
warning: python-explicit-check-phase
Consider using pytestCheckHook in checkInputs rather than checkPhase="pytest".

Near /home/mcgibbon/projects/nixpkgs/pkgs/development/python-modules/aiostream/default.nix:12:3:
   |
12 |   checkPhase = ''
   |   ^
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-explicit-check-phase.md
warning: python-imports-check-typo
A typo in pythonImportsCheck was detected.

Near /home/mcgibbon/projects/nixpkgs/pkgs/development/python-modules/aiostream/default.nix:9:3:
  |
9 |   pythonImportCheck = [ "aiostream" ];  # typo
  |   ^
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-imports-check-typo.md
warning: unclear-gpl
`gpl3` is a deprecated license, check if project uses `gpl3Plus` or `gpl3Only` and change `meta.license` accordingly.

Near /home/mcgibbon/projects/nixpkgs/pkgs/development/python-modules/aiostream/default.nix:17:5:
   |
17 |     license = licenses.gpl3;
   |     ^
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

@SuperSandro2000 wrote:

check for impure python imports which pull in another python version

I've implemented this in aa085cb, but the changes required are a little bigger to the code base, because it requires our checkDerivation functions knowing which interpreter version they're being called on. Making this consistent with the mkDerivation checks requires also changing those checks to get passed the relevant stdenv, I think.
So this commit will require some code review, I think. I'd be happy to move it to a separate PR, if you prefer.

@SuperSandro2000 wrote:

check for impure python imports which pull in another python version

I've implemented this in aa085cb, but the changes required are a little bigger to the code base, because it requires our checkDerivation functions knowing which interpreter version they're being called on. Making this consistent with the mkDerivation checks requires also changing those checks to get passed the relevant stdenv, I think.
So this commit will require some code review, I think. I'd be happy to move it to a separate PR, if you prefer.

Looks good at first glance, will give it a thorough review in the afternoon (CEST). Could you also add the test file to the tests directory, listing it in tests/default.nix and run-tests.py?

Looks good at first glance, will give it a thorough review in the afternoon (CEST). Could you also add the test file to the tests directory, listing it in tests/default.nix and run-tests.py?

So this commit will require some code review, I think. I'd be happy to move it to a separate PR, if you prefer.

Can't decide that because it is jtojnar projects.

So this commit will require some code review, I think. I'd be happy to move it to a separate PR, if you prefer.

Can't decide that because it is jtojnar projects.

@jtojnar: I've added tests.

@jtojnar: I've added tests.

Do you feel like writing a short blurb for each check to add to explanations/ directory? Otherwise, I can do that in the next week.

Do you feel like writing a short blurb for each check to add to explanations/ directory? Otherwise, I can do that in the next week.

I believe that I've fixed all of the more cosmetic changes in the last review, but I have not (yet) addressed the more substantive ones.

I believe that I've fixed all of the more cosmetic changes in the last review, but I have not (yet) addressed the more substantive ones.

Rebase finished.

Rebase finished.

Turns out I made a mistake when writing the composeOverlays function. I corrected it and then I found out I have written the exact same code that is contained in lib.composeExtensions (up to alpha equivalence).
The following should work:
diff --git a/lib/default.nix b/lib/default.nix
index 28abae1..97d2255 100644
--- a/lib/default.nix
+++ b/lib/default.nix
@@ -25,6 +25,9 @@ rec {
       };
     };

+  # Identity element for overlays.
+  idOverlay = final: prev: {};
+
   # Creates a function based on the original one, that, when called on
   # one of the requested packages, runs a check on the arguments passed to it
   # and then returns the original result enriched with the reports.
@@ -101,16 +104,14 @@ rec {

     in
     lib.genAttrs pythonPackageSetNames (pythonName:
-      let
-        prvPython = builtins.getAttr pythonName prev;
-      in prvPython.override {
-        packageOverrides = python-self: python-super: {
-          buildPythonPackage = wrapFunctionWithChecks prvPython.pkgs.buildPythonPackage namePositions check;
-        };
-      });
+      prev.${pythonName}.override (oldOverrides: {
+        packageOverrides = lib.composeExtensions (oldOverrides.packageOverrides or idOverlay) (final: prev: {
+          buildPythonPackage = wrapFunctionWithChecks prev.buildPythonPackage namePositions check;
+        });
+      }));

     checkFor = check: let
       o1 = (checkMkDerivationFor check);
       o2 = (checkBuildPythonPackageFor check);
-    in attrs: final: prev: (o1 attrs final prev) // (o2 attrs final prev);
+    in attrs: lib.composeExtensions (o1 attrs) (o2 attrs);
 }

Turns out I made a mistake when writing the composeOverlays function. I corrected it and then I found out I have written the exact same code that is contained in lib.composeExtensions (up to alpha equivalence).
The following should work:
diff --git a/lib/default.nix b/lib/default.nix
index 28abae1..97d2255 100644
--- a/lib/default.nix
+++ b/lib/default.nix
@@ -25,6 +25,9 @@ rec {
       };
     };

+  # Identity element for overlays.
+  idOverlay = final: prev: {};
+
   # Creates a function based on the original one, that, when called on
   # one of the requested packages, runs a check on the arguments passed to it
   # and then returns the original result enriched with the reports.
@@ -101,16 +104,14 @@ rec {

     in
     lib.genAttrs pythonPackageSetNames (pythonName:
-      let
-        prvPython = builtins.getAttr pythonName prev;
-      in prvPython.override {
-        packageOverrides = python-self: python-super: {
-          buildPythonPackage = wrapFunctionWithChecks prvPython.pkgs.buildPythonPackage namePositions check;
-        };
-      });
+      prev.${pythonName}.override (oldOverrides: {
+        packageOverrides = lib.composeExtensions (oldOverrides.packageOverrides or idOverlay) (final: prev: {
+          buildPythonPackage = wrapFunctionWithChecks prev.buildPythonPackage namePositions check;
+        });
+      }));

     checkFor = check: let
       o1 = (checkMkDerivationFor check);
       o2 = (checkBuildPythonPackageFor check);
-    in attrs: final: prev: (o1 attrs final prev) // (o2 attrs final prev);
+    in attrs: lib.composeExtensions (o1 attrs) (o2 attrs);
 }

@jtojnar: Nice!. I've pulled that diff into the first commit in this PR (now d3d30b2).

@jtojnar: Nice!. I've pulled that diff into the first commit in this PR (now d3d30b2).

Actually -- I need to bisect my changes a little bit. Something I've done has caused every error message do be repeated twice. I suspect that diff might be the problem...

Actually -- I need to bisect my changes a little bit. Something I've done has caused every error message do be repeated twice. I suspect that diff might be the problem...

(The duplication is has been fixed by slapping in a call to lib.unique, based on @jtojnar's suggestion.)

(The duplication is has been fixed by slapping in a call to lib.unique, based on @jtojnar's suggestion.)

I think this is ready to go, pending writing explanations for each error message. Is there anything else that's a blocker for you, @jtojnar?

I think this is ready to go, pending writing explanations for each error message. Is there anything else that's a blocker for you, @jtojnar?

Looks good to me otherwise. Great job.
Unfortunately, I do not think I will be able to write the explanations this week after all so we can just add link = false; to the new checks for now.

Looks good to me otherwise. Great job.
Unfortunately, I do not think I will be able to write the explanations this week after all so we can just add link = false; to the new checks for now.

I added some explanations in fa77e76. Maybe you could take a look at them, @SuperSandro2000?

I added some explanations in fa77e76. Maybe you could take a look at them, @SuperSandro2000?

I have fixed some minor style issues, squashed the explanations into the introducing commits, added some links. I have also changed the wording of python-imports-check-typo.md back since I am not sure it makes sense to require pythonImportsCheck when regular tests are present – they should already check imports work. I have also changed pytestFlagsArray example since pytestFlagsArray = [ "-o cache_dir=$(mktemp -d)" ]; is wrong on three counts.

I have fixed some minor style issues, squashed the explanations into the introducing commits, added some links. I have also changed the wording of python-imports-check-typo.md back since I am not sure it makes sense to require pythonImportsCheck when regular tests are present – they should already check imports work. I have also changed pytestFlagsArray example since pytestFlagsArray = [ "-o cache_dir=$(mktemp -d)" ]; is wrong on three counts.

Thank you for this great job.

Thank you for this great job.


Invalid Scope error on Live Environment

I implement this sdk on my android application for payment button, all was success on sandbox but when i switch to live environment, after calling create order, the new tab shows invalid scope. What may be the problem? Scopes (Fullname, email, paypalid...) are already verified by paypal.

I have the exact same problem. We have a Business Account. Native Checkout on Android is working in the sandbox. But in live environment I get the same problem - invalid scope. The configuration of the app in the developer account is identical with the configuration of the sandbox app.

I have the exact same problem. We have a Business Account. Native Checkout on Android is working in the sandbox. But in live environment I get the same problem - invalid scope. The configuration of the app in the developer account is identical with the configuration of the sandbox app.

Please Share if you found any solution

@tdchow
Do you have an idea how to solve the problem. In the developer dashboard sign in with PayPal is activated. Thank you.

Hey @sanjivdhakal and @blob810 - would you both be able to provide me with your live client ID? I'll do some digging on my end to see what scope issues you both have. Thanks!

Thanks for your fast reply. Here is my client id for this application.
AeFwbik8V07ENCFHlWxD-4nP4zor72XqAb2YoTbhPvh7do6zBTygsQtEMJ2ilhybn_9nIxREjM61C0kb

And here is mine AeyJxIfc52ZFDyEysKR32yxoGcm5aFMFFPN1CJewOdKiwgnXk0_fyWz4P5GpYSfJsnq-DqotpOJ21pGu

@tdchow Any Updates?

@sanjivdhakal - No updates to share yet. I'm still following up with an internal team to add the correct scope to your client ID.

Hi @tdchow,
it's working now in the live environment. I'm very happy. Thanks for your help.

Solved, Thanks


"Not a valid app" error is very vague

When I run bunny on a CWL file that can't be loaded, I get an error like:
14:07:54.003 [main] ERROR o.r.backend.local.BackendCommandLine - Error: file://cwl-workflows/workflows/hello/hello-param-packed.cwl#main is not a valid app!

It would be helpful to have more exact details about what is wrong. I usually have to dig deep into the source of both the workflow and bunny in order to figure out what's going on.

Yeah, it's truly hostile for trying out apps. We are working on it though: #102


Scavengers: make the queue broadcastable

I hope this way of dealing with broadcasting in a command called via this.parse() is fine.

If I type !scav queue, I get !scav viewqueue back, is it intended?

OK simply directly calling the command function while binding the same command context should work.  Since there is no recursion in the viewqueue command, recursion depth should not be an issue.  This makes so that no matter how they call the broadcast the command (viewqueue/queue, or !scavs vs !scavengers) it'll show the actual message they sent.

dot dot dot bump?

Pushed to master, sorry for making a bad commit in your branch, I don't understand GitHub merge failure resolution tools.


Stripe Dashboard

LOL where's the Stripe Dashboard on Admin section?

It would take a lot of work to make it function properly so I just removed it. Honestly it's best if he just goes to Stripe to check the status of the donations he has received

Cool, thanks!


Fix documentation for print_long_help, trim whitespace

print_long_help() erroneously had the same docstring as print_help(), so the mention of -h has been changed to --help

This change is

Coverage increased (+0.03%) to 91.956% when pulling bbf0b492627c7ee1a60b064c22188f36a2451ac8 on jdanford:fix-print-long-help-doc into e27a6ffbde87a35a367cd3c5b7369ef8173d0e7a on kbknapp:master.

Great catch, thanks! @homu r+


Not update cocoapods V 2.3

Version 2.3.0 is definitely available on the master spec repository: CocoaPods/Specs@3f4fded6792d640e98406b813eec84e022e460de
Please run pod repo update and try again. If it doesn’t work, please open an issue on the CocoaPods repository.

$ pod search XCDYouTubeKit

-> XCDYouTubeKit (2.3.0)
   YouTube video player for iOS and OS X.
   pod 'XCDYouTubeKit', '~> 2.3.0'
   - Homepage: https://github.com/0xced/XCDYouTubeKit
   - Source:   https://github.com/0xced/XCDYouTubeKit.git
   - Versions: 2.3.0, 2.2.0, 2.1.3, 2.1.2, 2.1.1, 2.1.0, 2.0.3, 2.0.2, 2.0.1, 2.0.0 [master repo]


CI: Update actions using deprecated node.js

Resolves #562
Also removes some redundant matrix strategies with non-matrix setups, adds some formatting, and specifies an accidentally omitted Python version.
cf. https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

The linting (3.10) workflow, marked required, will not complete because it's been replaced by just the linting workflow (i.e. it is no longer a matrix job). This requirement has to be swung to the linting workflow in the repository settings after merge.


[bug?] Nuxeo object (audio complex object) results in a 500 item record page

This collection: https://calisphere-stage.cdlib.org/collections/27694
The record with the grey thumbnail tile ark:/86086/n2668g9r/ results in a 500 page
Here's the Nuxeo object: https://nuxeo.cdlib.org/nuxeo/nxdoc/default/5ba475e3-5cd4-4830-8fa2-dd5eb0f550a8/view_documents
Here's the object on production: https://calisphere.org/collections/27694/ (grey thumbnail tile in the results)
Item record page: https://calisphere.org/item/ark:/86086/n2668g9r/

Run ID: manual__2024-05-14T00:33:44+00:00

@christinklez this should be fixed now.

This item record page now opens. Thank you so much!


Add nasa email communication field to users

Adds the field via migration along with all the assorted bits to roughly match how beta emails are handled, minus the checkbox on the Devise signup page.
Review checklist

[ ] First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
[ ] If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
[ ] If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
[ ] Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

I'm realizing now that I didn't update a bunch of the specs that include the other email attrs as options. Gonna add those real quick.


Include cluster_name and customMetadata in all output

What would you like to be added:
Currently, clusterName and customMetadata is only added to the container logs (tail.containers.** filter). It should be added to other logs such as those coming from journald and non-container files, in order to be able to distinguish those logs based on cluster name and other user-provided customMetadata.
Why is this needed:
It is not currently possible to search the Splunk logs produced by this component by cluster name or customMetadata. This means that all the journald and file logs are mixed together and difficult to separate in Splunk.

@rehevkor5 We would be happy to review a PR for the same.

If it was easier to test, I probably would do that. As it is, it depends on finding time to figure out how to test & debug it. I don't see any instructions for developers here, but maybe there are some elsewhere?

There are no instructions explicitly mentioned here on the github repo. But you can get started by cloning the repo, modifying the helm charts, testing them by deploying them, adding them to a commit and submitting a PR.

Resolved as part of https://github.com/splunk/splunk-connect-for-kubernetes/pull/294


use externalTranspiler before doing diffs for status

Create new function getRawOutputPostExternal with same interface
as getRawOutput except that it returns a <Promise<ts.EmitOutput>
instead of a ts.EmitOutput.
This function calls getRawOutut, then passes the result through
runExternalTranspiler so that babel, if configured, is applied.
Call/use this new function in getOutputJsStatus.
Net result: people using babel are not constantly being told their
JS is Outdated.

Cheers. Will publish with next release :rose:

Released : https://github.com/TypeStrong/atom-typescript/releases/tag/v7.13.0 :rose:

Reversing this commit. Just because I'm lazy, its 9pm on a Friday :) and this causes https://github.com/TypeStrong/atom-typescript/issues/765 :rose:


default folder creation is not working

/home/Genome Groups , etc..., need to be created

This is fixed on prod as of Sep 5, 2017


Initiate Reveal.js projects as Git repositories

The problem I'm having with reveal-init
I'm always frustrated every time I want to start a new Reveal.js project as a Git repository.
Proposed solution
I think you should add an option to initiate Reveal.js projects as Git repos (e.g. --git).

Solved 4d4281e.
Will available from reveal-init 2.0.


This change allows overriding the data type of an entry in the Schema.

For example, location is a geometric type and should be overwritten to be
of type geo_point.
In summary, this commit includes:

CustomIndex interface to allow for passing the entries to be "re-typed."
Refactored code to allow for an overall datatype replace
(e.g. string to keyword.)
Custom Mapping Tests.

@elalonde please review the latest changes. I reused IndexConfigurationProvider and extended this class within kafka-connect-pipelines.


ImproperlyConfigured: PATH is not a valid setting

Thanks for this the work on this repo, I have been looking for something like this for Django for sometime.
When running tests with django-swagger-tester I am getting the following error:
Found an excess key in the SWAGGER_TESTER settings: `PATH`.
System check identified no issues (0 silenced).
E
======================================================================
ERROR: documentation.tests (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: documentation.tests
Traceback (most recent call last):
  File "/Users/johnchase/miniconda3/envs/doc-api/lib/python3.7/unittest/loader.py", line 436, in _find_test_path
    module = self._get_module_from_name(name)
  File "/Users/johnchase/miniconda3/envs/doc-api/lib/python3.7/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/Users/johnchase/biota/documentation/documentation/tests.py", line 3, in <module>
    from django_swagger_tester.response_validation.static_schema import validate_response
  File "/Users/johnchase/miniconda3/envs/doc-api/lib/python3.7/site-packages/django_swagger_tester/response_validation/static_schema.py", line 10, in <module>
    from django_swagger_tester.response_validation.base.base import SwaggerTestBase
  File "/Users/johnchase/miniconda3/envs/doc-api/lib/python3.7/site-packages/django_swagger_tester/response_validation/base/base.py", line 8, in <module>
    from django_swagger_tester.response_validation.base.swagger_tester import SwaggerTester
  File "/Users/johnchase/miniconda3/envs/doc-api/lib/python3.7/site-packages/django_swagger_tester/response_validation/base/swagger_tester.py", line 5, in <module>
    from django_swagger_tester.configuration import settings
  File "/Users/johnchase/miniconda3/envs/doc-api/lib/python3.7/site-packages/django_swagger_tester/configuration.py", line 59, in <module>
    settings = SwaggerTesterSettings()
  File "/Users/johnchase/miniconda3/envs/doc-api/lib/python3.7/site-packages/django_swagger_tester/configuration.py", line 32, in __init__
    raise ImproperlyConfigured(f"`{setting}` is not a valid setting for the django-swagger-tester module")
django.core.exceptions.ImproperlyConfigured: `PATH` is not a valid setting for the django-swagger-tester module

Here is my settings.py
SWAGGER_TESTER = {
    "CASE": "camel case",
    "PATH": "/Users/johnchase/Desktop/v1.yaml",
}  # not required for drf_yasg

And my test:
class TestNothin(BaseViewTest):
    """Test class for nothing."""

    def test_get_200(self):
        """Verifies that a 200 is returned for a valid GET request to the /test/ endpoint."""
        response = self.client.get("/test/")
       # Test Swagger documentation
        validate_response(response=response, method="GET", endpoint_url="/test/")

running python manage.py test throws the error. I checked the demo app in this repository and received the same error.
Adding self.PATH on line 19 in the configuration.py file: https://github.com/sondrelg/django-swagger-tester/blob/aacde4d5b80326a9d4155a49936dcfaea27a14cf/django_swagger_tester/configuration.py#L19 fixes the issue and it works perfectly. I may be missing something, though I would be happy to submit a pr if that is all it is.

There are currently 2 different validate_response functions - which one are you using?

No need to answer the above question - I see you are right in that it has not been included as a setting after the last rewrite. I'm adding it back now :)

Feel free to test using the input branch to verify, otherwise I'll try and push a new version tomorrow anyways.

Thanks @sondrelg! Testing with the input branch, everything is working as expected


Order confirmed webhook

I want to merge this change because it adds a new webhook - order_confirmed.
Related ticket: SALEOR-1406
This is a PR to feature branch
Frontend part merged in: https://github.com/mirumee/saleor-dashboard/pull/820

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-1406 Add new plugin/webhook hooks

@korycins please re-review, after adding the action to order_created i've seen there are some edge-cases i've missed - like when order is created from draft. That is now fully covered and tested.


Is SearchFilter necessary?

First of all,
thank you for the repo! I am very much enjoying it.
Currently, I am testing some workloads with Search.Do function that requires a SearchFilter.
Notion API does not require for us to specify any filter (basically omit,) but I think there must be other reasons you have enforced it not to be nil. However, the objects we retrieve from the Search.Do function do provide the ObjectType, which could hint us the type of the object, meaning that we could possibly skip the SearchFilter if that is nil.
So... if there's any chance, could I post PR with the following and the some tests:

SearchFilter can be nil
Search.Do() will no longer reference nil pointer that were supposed* to be a SearchFilter instance.

But as always, I would like to learn the reason.
Thank you!

I just came across this too. I want to omit the filter to search both page and database objects (which works with the sample curl request in the Notion docs).
But when omitting filter, e.g.
resp, err := client.Search.Do(c.Request().Context(),
	&notionapi.SearchRequest{
		Query: "test",
	})

the API returns the error "body failed validation: body.filter.property should be '\"object\"', instead was '\"\"'." because the request is sent with the body "{\"query\":\"test\",\"filter\":{\"value\":\"\",\"property\":\"\"}}"


changes done in header and footer ...issue #1962 resolved👍👍

Related Issue
None
Fixes:  #(issue no.)  #1962
Description
basically there are 4 changes/ fixations that i have done on about page...

i adjusted the margin space for logo so that it stays inside the header only...

added top margin in the first section(about buddy trail section) so that the heading is now not sticked with the header....hennce, some space is now added there...

the footer attached in this page is now properly aligned, and  proper styling has been done

as you can see on the About page, the spacing of the section(The Buddy Trail Team section) just above the footer is now ok....Now , there is no overlapping as i adjusted the column's padding...

i have fixed the issue number: #1962
Type of PR

[ x] Bug fix

Screenshots / videos (if applicable)
Before :

changes:
after :

Checklist:

[x ] I have made this change from my own.
[ x] My code follows the style guidelines of this project.
[ x] I have performed a self-review of my own code.
[ x] I have made corresponding changes to the documentation.
[x ] My changes generate no new warnings.
[ x] I have tested the changes thoroughly before submitting this pull request.
[ x] I have provided relevant issue numbers and screenshots after making the changes.

@PriyaGhosal please approve this PR mam........
Thank you for this chance to make me work on this project

Please see the conflicts . Resolve the conflicts . Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!


Missing user font paths on Windows

https://github.com/AuburnSounds/printed/issues/39
On my machine, there are user fonts in C:\Users\<user>\AppData\Local\Microsoft\Windows\fonts
however only c:\Windows\fonts is returned by standardPaths(StandardPath.fonts), twice.
This leads to errors downstream as people instal fonts just for them and not globally.

Windows API does not provide a function to retrieve user fonts directories. I did a bit of research and it seems to be possible to get them from Windows registry via HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Fonts.
However on Windows fonts are specifically 'installed', so grabbing all fonts from the directory be it a global one or a user one may lead to including fonts that are not really 'installed' but just happen to be in these directories. If one wants to be truly correct it's better to grab the list of installed fonts via registry.
I can add evaluating of user fonts directories, but the evaluating of 'installed' fonts is not a scope of the standardpaths.
Including fonts paths in standardpaths probably was a mistake from the start. Currently it does not do a proper evaluation of fonts on freedesktop systems either since the correct way would be to parse fonconfig xml files which is again out of the scope of the standardpaths.

If you're interested in building a list of installed fonts on Windows you may look at matlob font manager code

Interesting thanks. For now I'm parsing font directories indeed and added the user ones as workaround.
Fonts are embedded in our SVG/PDF output in the general cases with printed so finding the OpenType file is enough to guarantee reproducibility (although we do strive to make it close to what a browser would do).


Unify development dependencies

Just curious to see what breaks if we unify our development dependencies.

The downside of this PR is that some dependencies are no longer locked in CI now. That means CI is less deterministic and potentially could get affected by issues in dependencies. For example, I guess there was a reason why vcr was pinned to 6.1.0. Now it's more unlocked.
But this may be acceptable.

After a second look, the only dependency that got relaxed with these changes is vcr. I'm happy to change this to keep that pin.

I was not too happy about the previous approach, because it was adding dependencies to the updater that it didn't really need. I changed the approach so that the set of dependencies used by /updater is exactly the same.
It's probably a bit too hacky, but essentially the same thing other gemspecs are doing by pulling development dependencies from common.
Let me know what you think!

It worked! 🥳


MSID: 89903 Version: 1 DOI: 2<IP_ADDRESS>6200

"msas": "Developmental Biology"
"msid": "89903"
"preprintDoi": "10.1101/2<IP_ADDRESS>620"
"Reviewed Preprint posted": "2023-08-07"
"Sent for peer review": "2023-06-12"
"Posted to bioRxiv": "2023-06-24" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>6200v1/")
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[ ] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v1/by-publisher/elife/get-by-manuscript-id?manuscript_id=89903)

or (only one should be ticked. remove other from description.)

[ ] Confirmed with Ted at bioRxiv that MECA archive is available

Send the following email to Ted and wait for his reply.
Hi Ted,

Please can you prepare the preprint MECA for 10.1101/2<IP_ADDRESS>6200

Thanks

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/89903/v1)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[x] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>6200)
[x] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[ ] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/89903/v1/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/89903)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/89903

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/89903

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/89903/v1/89903-v1.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/89903)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

elocation IDs missing from reference list; figure titles maybe displaying at wrong heading level?


Remove OperationChain from Store

At the moment everything is wrapped in OperationChains to be run by the Store/Graph.  This is then wrapped in a GraphRequest and run.
If you only have one Operation to run, this means it will be wrapped, then passed, then the Operation is extracted back out of the Chain and run.  This also won't work if you want to use no OperationChainHandler/might not work correctly with a custom one.
To fix this all references within Store/Graph (and therefore the GraphRequest) should be changed to Operation instead of OperationChain.
This will most likely be done as a subtask of #2031.

This will be merged into develop-2.

Merged into develop-2.


Both video playback and image display status in slick slider

Hello friends. I found a nice script in the slick slider. It is a nice slider that contains both Html5 video, youtube video and pictures. The demo link is:
https://codepen.io/digistate/pen/MvapbE
There are some things I want to do. First of all it works fine when you add the autoplay feature. There is no problem. I give it 4 seconds and all slides change automatically in 4 seconds. The point I want you to help with is this: When it comes to both Youtube and html5 video item, the autoplay feature will be disabled. When the video time is over, the autoplay feature will be activated again. How can I do that?

I am looking for this exact functionality. I found this script https://gist.github.com/tommydunn/1a8e43fef57059cc5197d02890d1a886 which is a fork of the digistate pen above. I cannot figure out how to disable autoplay while a video is playing and then start autoplay after video has ended. Any help is much appreciated.


Added test for running gleam using the starter project

@abeljim do you want to add things like discussed in the issue?

Fixed :)


Add Support For Querying Entities by Id

Description
This PR adds support for querying entities by ID
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

Reviewing again.... no new commits.


Make Variables editable for Behaviours, Plans, and Plantypes

ALICA Plan Variables should be addable to behaviours, plans and plantypes. We suggest to have an extra table in behaviour, plan, and plantype views that allows to add/delete them to each of them.
The name, type, and comment for a variable should be editiable.
See Behaviour Tab for a prototypical mockup implementation.

ticket fixed in 19015741a674b07f6df133c4ba5b3995086227d2


Allow mintmaker team members to create delete dependencyupdatechecks

DependencyUpdateCheck is a CR used by mintmaker to trigger Renovate jobs.

/approve
/lgtm


prisma generate on binary in venv generates js client instead?

Bug description
my project structure
**
.venv/bin/prisma
backend/
├── core
│   └── __pycache__
├── models
│   └── __pycache__
├── prisma
├── public
│   └── img
├── __pycache__
├── routes
│   ├── auth
│   │   └── __pycache__
│   ├── __pycache__
│   ├── scrapers
│   │   └── __pycache__
│   └── users
│       ├── personas
│       │   └── __pycache__
│       └── __pycache__
├── services
│   └── __pycache__
├── uploads
└── utils
    └── __pycache__**

When  I invoke prisma generate, even by calling the binary in .venv directly, it installs the @prisma library, then creates node_modules and generates the client in node_modules
I have made sure to uninstall prisma from global modules
from prisma import Prisma() does not work.

everoot@uwucloud:~/dev/eve# ./.venv/bin/prisma generate --schema=./backend/prisma/schema.prisma
Prisma schema loaded from backend/prisma/schema.prisma
Warning: [Prisma auto-install on generate] Prisma could not find a package.json file in the inferred project root /root/dev/eve. During the next step, when an auto-install of Prisma package(s) will be attempted, it will then be created by your package manager on the appropriate level if necessary.
bun add v1.1.6 (e58d67b4)

 installed<EMAIL_ADDRESS>with binaries:
  - prisma

 6 packages installed [794.00ms]
  Removed: 1
bun add v1.1.6 (e58d67b4)

 installed<EMAIL_ADDRESS>
 1 package installed [103.00ms]

✔ Installed the @prisma/client and prisma packages in your project

✔ Generated Prisma Client (v5.11.0) to ./node_modules/@prisma/client in 338ms

Start using Prisma Client in Node.js (See: https://pris.ly/d/client)

import { PrismaClient } from '@prisma/client'
const prisma = new PrismaClient()
or start using Prisma Client at the edge (See: https://pris.ly/d/accelerate)

import { PrismaClient } from '@prisma/client/edge'
const prisma = new PrismaClient()

See other ways of importing Prisma Client: http://pris.ly/d/importing-client

┌─────────────────────────────────────────────────────────────┐
│  Deploying your app to serverless or edge functions?        │
│  Try Prisma Accelerate for connection pooling and caching.  │
│  https://pris.ly/cli/accelerate                             │
└─────────────────────────────────────────────────────────────┘

How to reproduce

Expected behavior
generate prisma client in python
Prisma information
generator client {
  provider             = "prisma-client-js"
  interface            = "async"
  recursive_type_depth = 3
}

datasource db {
  provider = "postgresql"
  url      = env("DATABASE_URL")
}

Environment & setup

OS: Ubuntu
Database: PostgreSQL
Python version: 3.12
Prisma version:

prisma                  : 5.11.0
prisma client python    : 0.13.1
platform                : debian-openssl-3.0.x
expected engine version : efd2449663b3d73d637ea1fd226bafbcf45b3102
installed extras        : []
install path            : /root/dev/eve/.venv/lib/python3.12/site-packages/prisma
binary cache dir        : /root/.cache/prisma-python/binaries/5.11.0/efd2449663b3d73d637ea1fd226bafbcf45b3102

Hey @Bewinxed, I think you have a typo in your schema file, you have to change provider = "prisma-client-js" to provider = "prisma-client-py"
generator client {
  provider             = "prisma-client-py"
  interface            = "async"
  recursive_type_depth = 3
}

datasource db {
  provider = "postgresql"
  url      = env("DATABASE_URL")
}

Oh godbless your soul I’ll try this
On Wed, 15 May 2024 at 5:36 PM Robert Craigie @.***>
wrote:

Hey @Bewinxed https://github.com/Bewinxed, I think you have a typo in
your schema file, you have to change provider = "prisma-client-js" to provider
= "prisma-client-py"
generator client {  provider             = "prisma-client-py"  interface            = "async"  recursive_type_depth = 3}
datasource db {  provider = "postgresql"  url      = env("DATABASE_URL")}
—
Reply to this email directly, view it on GitHub
https://github.com/RobertCraigie/prisma-client-py/issues/961#issuecomment-2112719361,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACFY5BKVU45HGAALPWREJODZCNXFDAVCNFSM6AAAAABHLJGGFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJSG4YTSMZWGE
.
You are receiving this because you were mentioned.Message ID:
@.***>


Invalid date string

On row 268, there is an invalid date string template:
url_date = quote(oldest_completion_date.strftime("%b %-d, %Y %-I:%M:%S %p"))

This is causing errors when a date is being specified.
While I'm not 100% sure on this, is it supposed to return a Unix time code? That is what is needed for the SurveyCTO REST API. Thanks!

Hi @TheOmnimax ,
oldest_completion_date is a Python datetime.date or datetime.datetime object and url_date is the URL encoded value of the date.
For example: if the date is 24 January, 2021 13:42:42:
import datetime
from urllib.parse import quote

oldest_completion_date = datetime.datetime(2021, 11, 24, 13, 42, 42)
# oldest_completion_date: 'Nov 24, 2021 1:42:42 PM'
url_date = quote(oldest_completion_date.strftime("%b %-d, %Y %-I:%M:%S %p"))
#  url_date: 'Nov%2024%2C%202021%201%3A42%3A42%20PM'

Could you give an example where this is giving an error?

@jeenut27 I have reached out to the user who reported this issue to ask if they can share their code.

@jeenut27 I have been doing some testing, and while I cannot replicate the issue on my MacOS computer, I can on my Windows computer, so I believe that is the issue. It looks like those hyphens in the date string template are not supported on Windows.

Thanks for looking into this @TheOmnimax.
This reference shows the codes that are platform-specific, which confirms that codes with hyphens are not supported on Windows. Interestingly, it looks like the hyphen can be replaced with a hash on Windows.

Yes, adding try/except block to handle this makes sense to me! I will update the code and create a PR.

Hi @TheOmnimax ,
We added in a try/except block to handle the timestamps using - and # in case - fails. The upgraded pysurveycto version is 0.0.13. However, please do let us know if you face the same issue again.


Integration Test Runner Assertion Algorithm

There are a few algorithms that must be developed in handling the expected vs actual outputs when rnning the integration cms measures.
The 'proportion' algorithm must be developed first

Assigned to Alexander, who could also reassign to Rich.


Token type does not work for globalCss

Description
In the following code such like the example from the official documentation, when specifying a token value (such as gray.900) for the value of background-color, auto-completion does not work from the type. Since the background color is reflected as specified, I believe it should be an available value. I assume this is probably the case, but is this a bug?
  globalCss: {
    'html, body': {
      backgroundColor: 'gray.900', // auto-completion does not work
      lineHeight: '1.5',
    },
  },

Link to Reproduction
https://stackblitz.com/edit/vitejs-vite-l78ege?file=panda.config.ts
Steps to reproduce

Go to '...'
Click on '...'
Scroll down to '...'
See error

JS Framework
React, Vite, TypeScript
Panda CSS Version
0.3.2
Browser
No response
Operating System

[X] macOS
[ ] Windows
[ ] Linux

Additional Information
No response

Hi @makotot,
Please use the defineGlobalStyles function to get autocomplete.
import { defineConfig, defineGlobalStyles } from '@pandacss/dev';

const globalCss = defineGlobalStyles({
  'html, body': {
    backgroundColor: 'gray.900',
    lineHeight: '1.5',
  },
});

Here's the working code: https://stackblitz.com/edit/vitejs-vite-uk85nu?file=panda.config.ts,tsconfig.json

I see, thanks for letting me know. Thanks also for the update on the documentation!