Add TryHarder and MinLineCount hints for python wrapper

Added 2 hints to the python wrapper, MinLineCount and TryHarder

Thanks for your offer to improve the code. I'm hesitant to merge your PR, though. I deliberately did not include the tryHarder flag in the python API as this is basically only useful for real-time video frame scanning on mobile devices. What is your motivation to add that to the python API?
The same question generally applies to the minLineCount property as well. Do you need something else than the default of '2' here?

I use kinda real time implementation on android through the NDK, yes.
The reason is in my project, I have a unit test in python and I have to pass the same settings of the cpp implementation to check that is the same.
 Those can only be different if the two are based on different versions of the code base and I'm not convinced that this justifies the bloating of the python API, especially not the addition of the tryHarder flag, which I've had my issues with for years (#104).

We use in production the cpp with android NDK and iOS.
While python in a separate module to test barcodes joined with other pre-processing routine.
Maybe it's ok about tryHarder, but at least MinLineCount? The latter is crucial for some barcodes in our project, and we want to test using the old behaviour of v1.2.0 when was setted to 1

minLineCount is indeed a little different. But before we simply add that, I'd like to use the opportunity to point out that a value of 2 is in my experience really a very reasonable minimum value to combat false positives and I'd recommend to use that instead of 1. If you can share one of those samples from your project, where this makes a difference, I'd be interested to have a look.

Sure, I have many "strange examples" that might be useful for you, with this image we can spot 2 things: the slightly imperfect alignment make fail the detecting, I addressed this issue with an iterative rotation of step for 0.02 degree till +1.0 and from -0.02 to -1.0 --> SUCCESS but only if we use MinLineCount = 1 ! Try by yourself to set = 2 and it will fail, note, this is not an edge-case it's a very common one, I have so many like this

Testing and Pre-processing
//compile with -lZXing -lopencv_imgcodecs -lopencv_imgproc -lopencv_core
#include <algorithm>
#include <ZXing/ReadBarcode.h>
#include <opencv2/opencv.hpp>
#include <chrono>

void sharpen(cv::Mat &image, float strength)
{
    cv::Mat sharpened;
    image.convertTo(sharpened, CV_32F);
    cv::medianBlur(sharpened, sharpened, 3);
    cv::Mat laplacian;
    cv::Laplacian(sharpened, laplacian, CV_32F);
    sharpened = sharpened - strength * laplacian;

    sharpened.convertTo(image, CV_8U);
}

std::string read_barcode(const cv::Mat &image)
{
    auto imageBuffer = ZXing::ImageView(image.ptr(), image.cols, image.rows, ZXing::ImageFormat::Lum);
    auto hints = ZXing::DecodeHints()
                     .setMinLineCount(1)                              // default is 2 since commit https://github.com/zxing-cpp/zxing-cpp/commit/11fc1d889071562a9eb4fb7ac94e65f220dd86ab
                     .setTryHarder(true)                             // If false, skip some lines/pixels during detection (faster)
                     .setTryRotate(false)                             // If true, try 90, 180 and 270 degree rotation. Already handled by transform.
                     .setBinarizer(ZXing::Binarizer::GlobalHistogram) // Choose from fixed, histogram, local average, and bool
                     .setIsPure(false)                                // Assumes the image contains a perfectly aligned code (faster)
                     .setFormats(ZXing::BarcodeFormat::Code128)       // Limits the amount of formats to check for (faster)
                     .setTryDownscale(false);                         // If false, it doesn't downscale the image

    auto found_barcode = ZXing::ReadBarcode(imageBuffer, hints);
    if (!found_barcode.isValid())
    {
        return "";
    }
    const auto barcode_text = found_barcode.text();
    printf("Barcode detected: %s (%s)\n", barcode_text.c_str(), ZXing::ToString(found_barcode.error()).c_str());
    return barcode_text;
}

int main()
{

    cv::Mat image = cv::imread("original.png");
    if (image.channels() == 3)
        cv::cvtColor(image, image, cv::COLOR_RGB2GRAY);

    assert(image.channels() == 1);

    auto barcode_text = read_barcode(image);

    if (barcode_text.empty()) {
      printf("Trying to read barcode with sharpened image and Otsu's thresholding.\n");
      sharpen(image, 1.0);
      cv::threshold(image,image, 0, 255, cv::THRESH_BINARY | cv::THRESH_OTSU);

      barcode_text = read_barcode(image);
      cv::imwrite("sharpened_thresholded.jpg", image);
    }

    if (barcode_text.empty())
    {
        printf("Trying to read barcode with different degrees of rotation.\n");
        auto start = std::chrono::steady_clock::now();

        // Generate a lookup of degrees
        // with step of 0.02 and sorted for probabilities
        // of wrong cardboard alignment
        // [-0.02, -0.04 ... -1.0, +0.02, +0.04 ... +1.0]
        const float step = 0.02f;
        const int elements = 2 / step;
        auto degrees = std::make_unique<float[]>(elements);
        float degree = 0.f;
        std::generate_n(degrees.get(), elements / 2, [&degree, &step]
                        { return degree -= step; });
        degree = 0.f;
        std::generate_n(&degrees[elements / 2], elements / 2, [&degree, &step]
                        { return degree += step; });

        const cv::Point2f center(int(image.cols / 2.f), int(image.rows / 2.f));
        for (int i = 0; i < elements && barcode_text.empty(); ++i)
        {
            cv::Mat rotation_matrix = getRotationMatrix2D(center, degrees[i], 1.0);
            cv::Mat rotated_image;
            cv::warpAffine(image, rotated_image, rotation_matrix, image.size());
            barcode_text = read_barcode(rotated_image);
            if (!barcode_text.empty())
            {
                printf("%f\n", std::chrono::duration<double, std::milli>(std::chrono::steady_clock::now() - start).count());
                cv::imwrite("rotated.jpg", rotated_image);
                printf("rotation angle fixed %f after %i iterations\n", degrees[i], i + 1);
            }
        }
    }
}

I think that the iterative rotation emulates the real-time detection with frames, that's why it works always when previous attempts fail

I have a question without digging in the math formula, your GlobalHistogram is doing the same type of thresholding of Otsu's method, why alone is not enough? Is GlobalHistogram "less" accurate than Otsu? Shouldn't be the same? In the above code I'm doing Otsu to read the barcode, without it would fail

I'm a bit low on time but just to give you a quick update:

GlobalHistogram is a port of the original Java code. It is not meant to be an implementation of Otsu but tries to do something similar. I actually experimented with Otsu myself a while back and while it helps in some situations, it breaks other that currently work, hence I did not simply switch the algorithms.
Both your samples should work out-of-the box (with minLineCount >> 1) in my opinion. They currently don't because the 'black' bars are too wide compared to the 'white' ones due to sharpness/lighting issues. I see how a different binarizer implementation (e.g. Otsu) would help here. The real fix for this is a change in the pattern-to-character decoding though. I was having this on my todo list for a while and was looking into it, just now. I believe to have a promising way forward, but don't know how long this 'real' fix will take (see 'low on time' comment above).
You can of course use Otsu prior to calling the library.
This whole discussion further convinces me that the fix for your issue is not the addition of the minLineCount hint to the python API.

Thank! I didn't notice that are wide

Thank you! I didn't notice that are wide and the aspect ratio is not correct. I'm gonna fix

I don't know what you mean by 'aspect ratio not correct'. There is nothing wrong with that. What I meant is that the image is somewhat underexposed, which makes the black bars wider compared to the white ones, but I personally would like to see the library being capable of dealing with that as is and I am hopeful that it will in some not-too-far-away-future.

I want to clarify what I said before, ignoring the exposure situation (because even fixing that is not enough): so the aspect ratio is modified in my project, the original barcode has thin black lines because the height is 15% of the width, but for some problem after doing a warp, the height becomes the 10.9% of the width, so it's like stretched out, after resizing with opencv multiply for a factor of 1.375 the "Impossible" barcode is detected at first attempt . I think that stretching out barcodes, for mistake, make more difficult the detection sometimes. Therefore I'm trying to fix the warp function that I use in my project

Don't worry about the aspect ratio of the image, it is irrelevant for the detection of 1D barcodes like Code128 here (completely different situation for 2D symbologies, of course). Important for the detection is the relative widths of the black vs. the white bars. If you made all of them twice as wide, the result would be the same.
The reason why your symbol might still be detected after this rescaling is basically noise, same as your tiny rotation operations you mentioned earlier. Random minor changes might make the difference between 1 or 2 detected lines while this input should actually be found with 100 lines (or whatever the height of the symbol is in pixels).

The linked commit fixes your issue with the above images. They are now both detected with 40+ lines. I decided to trust my work and put this into the next release, even if it is very last minute ;).

Thank you very much!

I confirm, now is absolutely perfect with my "difficult" 100 barcode datasets. Could you explain what was exactly the cause of the issue and how you addressed it? Just to keep in my mind, even in short words. The black lines "too thick", right?

Yes all code128, do you want the archive?

No thanks.


As a user I want to search for direct ticket numbers (including project abbreviations)

Expected Behavior
As a user I want to search for direct ticket numbers (including project abbreviations)
Actual Behavior
doesn't yet work like this
Steps to Reproduce the Problem

open search and search for ticket numbers

Specifications

Chronos-timetracker version: 2.4.6
OS: MacOS

Done(development branch). Will be in the next release.

working, THX!


Change a response code to conform to the OSB API while fetching service bindings

When service instance doesn't exist service broker throws ServiceInstanceDoesNotExistException and then it will be maped to 422 Unprocessable Entity via ServiceBrokerExceptionHandler.
However it must return a response with code 404 Not Found.
Fixes #223

@royclarkson something went wrong...
* What went wrong:
Could not resolve all files for configuration ':jacocoAnt'.
> Could not download org.jacoco.core.jar (org.jacoco:org.jacoco.core:0.8.1)
   > Could not get resource 'https://repo.spring.io/libs-release/org/jacoco/org.jacoco.core/0.8.1/org.jacoco.core-0.8.1.jar'.
      > Connection reset

Appears to have been a flake with the first run. I reran the build and it passed the second time.

Appears to have been a flake with the first run. I reran the build and it passed the second time.

Thanks @royclarkson

Closed in c09366aeed666704146cbe544c9f4eda3603de9d

ServiceInstanceDoesNotExistException class documentation says: Throwing this exception will result in an HTTP status code 422 UNPROCESSABLE ENTITY being returned to the platform., but it can throw other codes too:

HttpStatus.NOT_FOUND
HttpStatus.GONE

@dalv666 since this has been merged and closed, please add new issues for these or submit PRs. thanks!


Feat: Support non-file input for acorn image sign --key

That's required e.g. for

the acorn-io/actions-sign GitHub Action (or other scenarios), where we don't want to (temporarily) write the private key repo secret to disk
the use cases, where the private key is not stored in a file, but rather retrieved via external tooling or some credential manager (e.g. Vault)

Example: This will work: acorn image sign --key="$(cat my.key)" my.reg.io/foo:v1

Tested with acorn version - v0.9.0-rc1-22-g08c68cf2+08c68cf2
I get "✗  ERROR:  failed to import private key: invalid key file" error when trying to use the key in "$(cat sangeegh1)" format.
%acorn image sign sangeetha/testsignature:v1 --key="$(cat sangeegh1)" -a qatag=ok
  •  Signing Image sangeetha/testsignature:v1 (digest: index.docker.io/sangeetha/testsignature@sha256:e7b2e6a60916544e2f58cd27591332f8d7132240678983057c80df00ed7e0ddd)
? Enter password for private key: *********
  ✗  ERROR:  failed to import private key: invalid key file

%acorn image sign sangeetha/testsignature:v1 --key "$(cat sangeegh1)" -a qatag=ok
  •  Signing Image sangeetha/testsignature:v1 (digest: index.docker.io/sangeetha/testsignature@sha256:e7b2e6a60916544e2f58cd27591332f8d7132240678983057c80df00ed7e0ddd)
? Enter password for private key: *********
  ✗  ERROR:  failed to import private key: invalid key file

 % acorn image sign sangeetha/testsignature:v1 --key sangeegh1 -a qatag=ok
  •  Signing Image sangeetha/testsignature:v1 (digest: index.docker.io/sangeetha/testsignature@sha256:e7b2e6a60916544e2f58cd27591332f8d7132240678983057c80df00ed7e0ddd)
? Enter password for private key: *********
  ✔  Created signature sha256:f084070580ffefaa634961d17126fba200b78a759a4a1838b90955c4fba06ebb

@sangee2004 what kind of key is that? Can you paste a redacted output of cat sangeegh1 or send it via Slack, please?


Mention Ruby logger in README

So that people are aware that the Ruby logger exists and how to use it.

Looks fine to me 👍 In a Rails app I assume you can also just use Rails.logger if it's configured correctly?


Type errors are not reported, only syntax errors.

Expected behavior:
gulp-typescript reports type errors - it should report the same errors that tsc does.
Actual behavior:
gulp-typescript doesn't report type errors. It does report syntax errors.
Also, using the noEmitOnError: true option does cause the task to fail, though the specific errors are not reported.
Your gulpfile:
const tsProject = typescript.createProject('tsconfig.json');

gulp.task('build', () =>
  gulp.src('src/**/*.ts')
    .pipe(typescript(tsProject))
    .pipe(gulp.dest('lib'))
);

tsconfig.json
{
  "compilerOptions": {
    "target": "es6",
    "module": "commonjs",
    "moduleResolution": "node",
    "isolatedModules": true,
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,
    "declaration": false,
    "noImplicitAny": true,
    "removeComments": false,
    "noLib": true,
    "preserveConstEnums": true,
    "suppressImplicitAnyIndexErrors": false,
    "outDir": "lib"
  },
  "filesGlob": [
    "custom_typings/*.d.ts",
    "src/**/*.ts",
    "!node_modules/**",
    "typings/index.d.ts",
    "node_modules/typescript/lib/lib.core.es6.d.ts"
  ],
  "files": [
    "custom_typings/dom5.d.ts",
    "custom_typings/fs-extra.d.ts",
    "custom_typings/hydrolysis.d.ts",
    "custom_typings/node.d.ts",
    "custom_typings/plylog.d.ts",
    "custom_typings/slash.d.ts",
    "custom_typings/vinyl-fs.d.ts",
    "src/analyzer.ts",
    "src/build.ts",
    "src/bundle.ts",
    "src/fork-stream.ts",
    "src/optimize.ts",
    "src/polymer-build.ts",
    "src/polymer-project.ts",
    "src/prefetch.ts",
    "src/project-config.ts",
    "src/streams.ts",
    "src/sw-precache.ts",
    "src/uglify-transform.ts",
    "src/url-from-path.ts",
    "typings/index.d.ts",
    "node_modules/typescript/lib/lib.core.es6.d.ts"
  ],
  "atom": {
    "rewriteTsconfig": true
  }
}

Code
I noticed this when I enabled noImplicitAny in my tsconfig, but it turns out there are other type errors reported by tsc and not by gulp-typescript. To check that gulp-typescript was actually catching any errors I introduced some syntax errors and those were indeed piped as errors and caused the task to fail.
I tried various combinations of using tsProject.src() instead of fulp.src(), using a custom Reporter (no errors are passed to it for type errors), and noEmitOnError. Only noEmitOnError caused anything to fail on type errors, or at least I presume. I need to fix my type errors to make sure emit works on error-free code.

With isolatedModules, all files are compiled separately. This improves compilation times a lot, but it does mean that type errors will not be reported (as all files are needed for the analysis). So you should either accept that or remove that option.

Why does tsc report type errors with isolatedModules? How come implicit any errors can't be reported, since they're always local?

Also, when I turn off isolatedModules (and move the lib.core.es6.d.ts to the top of filesGlob and files) tsc still works, but gulp build reports missing global types like Array that are usually an indication of not having a core lib declaration. I'm not using noExternalResolve, so this is unexpected.

gulp-typescript has as implementation that is very fast with isolatedModules. It compiles files one by one. When only one file changes, only that file is recompiled. But, with such implementation you cannot do type checking. I'm not sure how it was implemented in tsc but that's probably not as fast as gulp-typescript for large projects.
For your second issue, you're using gulp.src and you do not include the lib file there. You should list it there or use tsProject.src(), which will resolve files based on your tsconfig file.


chore: Initialise Google Client with access token

Please ensure your pull request adheres to the following guidelines:

[ ] make sure to link the related issues in this description
[ ] when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues
Thanks for contributing!

moved to #208


feat(input): add extra message slot

Checklist

[ ] add extra message slot

Change information

Please support maxlength related components. Such as Uploader.

Please support maxlength related components. Such as Uploader.

I will add it. I just checked and only the input & uploader has the attribute 'maxlength'. If I missed, please tell me!


Attachment Editor/Saved Trains Do Not Function/Spawn

BkCommonLib version: 789
TrainCarts version: 651 (TCC Coasters: 170)
Spigot version: 112 (Latest)

Problem or bug: The attachments editor does not work, and previous trains saved do not work. Server error log: https://pastebin.com/ZxmK5YJy
Expected behaviour: Can spawn in saved train and can use the attachment editor.
Steps to reproduce: Attempt to use the attachment editor.

Can you update to builds BK791 and TC654 and check if it's fixed?

Fixed, thank you!

Great. Closing.


use chrome extensions in nativefier?

Is this possible? Or a technical limitation?

Thanks for the feedback, @ekimia. No, for now we don't support bundling Chrome extension, and it's unlikely to come soon, given upstream (electron) position on this, see discussion at #207

@ekimia

Is this possible?

Yes, but it's a workaround: https://github.com/jiahaog/nativefier/issues/246#issuecomment-718708717


⚠ Bofrost.at has degraded performance

In e9374c2, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1325 ms

Resolved: Bofrost.at performance has improved in 5bcfea4.


CMake Windows Improvements

Creating a PR as requested by @JohnDMcMaster:
This PR fixes the following issues:

On Windows only, io.h is not found unless firmware is added to the include path.
Update cmake-microchip submodule to improve compiler autodetection on Windows.

Works for me, merged


x + C -> ctrl + C , x + v -> crtl + V

Description of the new feature / enhancement
I would like to be able to replace the existing shortcut by pressing two English keys.
When inputting text, it should be entered normally.
Scenario when this would be used?
x + C -> ctrl + C , x + v -> crtl + V
Supporting information
No response

Currently, this is not possible woth Keyboard Manager. But AutoHotkey could do this without breaking a sweat!


ProgressView is used in RecyclerView

Please complete the following information:

Library Version 1.0.9
Affected Device(s) ALL

Describe the Bug:
ProgressView can't set progress, but in the  getProgress() has value

As you can see this demo codes, you can set progress programmatically.


globalSetup should honor modulePaths

Do you want to request a feature or report a bug?
bug
What is the current behavior?
When globalSetup processes a setup, it doesn't seem to process files imported as absolute paths, e.g.
import 'router/Helmet'
They are setup through resolve in webpack and as modulePaths in jest setup.
I'm using babel-register to allow for ìmport statements. I'm wondering if this could be creating the problem as the error states this:
Error: Cannot find module 'router/Helmet'
    at Function.Module._resolveFilename (module.js:538:15)
    at Function.Module._load (module.js:468:25)
    at Module.require (module.js:587:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/Users/Shared/java/projects/react/projects/my-project/shared/App/index.js:5:1)
    at Module._compile (module.js:643:30)
    at loader (/Users/Shared/java/projects/react/projects/my-project/node_modules/babel-register/lib/node.js:144:5)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/Shared/java/projects/react/projects/mobile-minds/node_modules/babel-register/lib/node.js:154:7)
    at Module.load (module.js:556:32)
    at tryModuleLoad (module.js:499:12)

I have this at the top of my global setup file:
require('babel-register');

Before I tried to use global setup everything worked fine in principle. I understand from comments here: https://github.com/facebook/jest/issues/5164 that transform is not applied to global setup, which I hope will change. Perhaps the same goes for modulePaths?
What is the expected behavior?
These imports should work.
Please provide your exact Jest configuration
"jest": {
		"globals": {
			"__DEV__": true
		},
		"moduleNameMapper": {
			"^.+\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$":
				"<rootDir>/internal/jest/assetMock.js",
			"^.+\\.(css|less|scss|sass|less)$": "<rootDir>/internal/jest/styleMock.js"
		},
		"modulePaths": ["<rootDir>", "<rootDir>/shared"],
		"collectCoverageFrom": ["s<rootDir>/shared/**/*.{js,jsx}"],
		"snapshotSerializers": ["<rootDir>/node_modules/enzyme-to-json/serializer"],
		"testPathIgnorePatterns": ["<rootDir>/(build|internal|node_modules|flow-typed|public)/"],
		"setupTestFrameworkScriptFile": "<rootDir>/internal/jest/setup",
		"globalSetup": "<rootDir>/server/test/setup",
		"globalTeardown": "<rootDir>/server/test/teardown",
		"transform": {
			"^.+\\.(js)$": "babel-jest"
		},
		"testEnvironment": "node",
		"verbose": true
	},

Run npx envinfo --preset jest in your project directory and paste the
results here
System:
OS: macOS Sierra 10.12.6
CPU: x64 Intel(R) Core(TM) i7-3615QM CPU @ 2.30GHz
Binaries:
Node: 8.9.4 - ~/.nvm/versions/node/v8.9.4/bin/node
Yarn: 1.5.1 - /usr/local/bin/yarn
npm: 5.6.0 - ~/.nvm/versions/node/v8.9.4/bin/npm
npmPackages:
jest: 22.4.3 => 22.4.3

I now realize that global setup runs outside of jest, making it more like a kind of before jest setup. What I want is a global async beforeAll, afterAll inside jest

It makes it hard to setup something global, like an express server. Using beforeAll and afterAll to start and stop the express server at test level runs into issues with jest running through a pool. So, you get listen port conflicts. Since global is sandboxed as well, can't use that either at that level.

Hey @mschipperheyn thanks for using Jest! As I think you found, this is not a bug
For the follow-up questions please note this issue tracker is not a help forum. We recommend using our discord channel or StackOverflow for questions like this


KRB5 principal name is missing yet another combination of '@' and '/'

Fixed in 0.99.2 dd9fe1acdeb74029fa966b15287ba22062de342c


angular2-compilers CSS Compiler does't escape CSS strings

If compiling a style like this:
span::after {
     content: "\00A0 \2014"; // nbsp, em dash
}

The compiler errors:
C:\Users\funkv\AppData\Local\.meteor\packages\angular2-compilers\0.6.0\plugin.Angular2Compilers.os.windows.x86_32\npm\node_modules\meteor\babel-compiler\node_modules\babylon\lib\parser\location.js:22:13:
   Octal literal in strict mode (508:14)

@barbatus could you take a look? I think it needs escaping here: https://github.com/Urigo/angular2-meteor/blob/master/atmosphere-packages/css-compiler/compilers/basic_compiler.js#L56

btw I don't think \00A0 \2014 is a valid JS string, which basically means you are trying to escape 0 or 2 in them.

but valid CSS, alright


bump function's go client version to v0.7.0

Motivation
New go client v0.7.0 released recently. We need to bump the function's go client version.
Modifications
version change.
Verifying this change

[ ] Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API: (yes / no)
The schema: (yes / no / don't know)
The default values of configurations: (yes / no)
The wire protocol: (yes / no)
The rest endpoints: (yes / no)
The admin cli options: (yes / no)
Anything that affects deployment: (yes / no / don't know)

Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?

[ ] doc-required
(If you need help on updating docs, create a doc issue)

[X] no-need-doc
(Please explain why)

[ ] doc
(If this PR contains doc changes)

I think the mock message needs updated since there was a new method GetEncryptionContext() added in 0.7.0 for encryption.
https://github.com/apache/pulsar-client-go/blob/master/pulsar/message.go#L123
https://github.com/apache/pulsar/blob/master/pulsar-function-go/pf/mockMessage_test.go#L29

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


[Fix #9621] Add consistent style to Lint/SymbolConversion to require all symbol keys in a hash to use the same convention

The consistent style works the same as the previous default style (now called strict), in that symbol conversions should be explicit. However, in the case of a hash with a mix of symbol keys requiring quoting and not, this style now enforces that all keys are quoted for consistency.
Fixes #9621.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@rubocop/rubocop-core one thing that I'm not sure about is that Lint cops generally do not have configurable styles; Lint/InheritException is the only other one. However, this behaviour can't be enforced by a separate Style cop unless Lint/SymbolConversion is updated to ignore some cases if that cop is enabled, which is another can of worms. Maybe someone has an idea?
Separately, I am using the configuration from Style/StringLiterals to determine how to quote the keys. We don't currently have anything checking for consistency of quote style in quoted symbol literals.

@rubocop/rubocop-core one thing that I'm not sure about is that Lint cops generally do not have configurable styles; Lint/InheritException is the only other one. However, this behaviour can't be enforced by a separate Style cop unless Lint/SymbolConversion is updated to ignore some cases if that cop is enabled, which is another can of worms. Maybe someone has an idea?

Most Lint cops shouldn't have different supported styles, but I guess that's OK in the current situation. Alternatively this can also be some flag like "AllowConsistentSymbolsInHash" or something along those lines. I'm fine with the current approach as well.

Separately, I am using the configuration from Style/StringLiterals to determine how to quote the keys. We don't currently have anything checking for consistency of quote style in quoted symbol literals.

I think that's fine.

Thanks!


[webapi] Fix duplicated test purposes issue

@zqzhang  I will fix same issue in other suites  in this PR with several commits

@zqzhang  I have finished fix duplicated test purpose for test suites in webapi


Event queue must support implementation file resolution relative to eventQueueConfig.yml

We can do it consistently with the feature toggles, if you use $CONFIG_DIR as syntax for implementation path.
https://github.com/cap-js-community/feature-toggle-library/blob/main/docs/usage/index.md?plain=1#L116
I have a test for this behavior that might also be helpful
https://github.com/cap-js-community/feature-toggle-library/blob/main/test/integration-local/featureToggles.integration.test.js#L181

Good idea. I'll look into it. 👍

This is still an issue


Check that nmdm devices exist

If any /dev/nmdm* device doesn't exist, this means that the nmdm kernel module isn't loaded.

Done as of 9803b214dc945ca1541edf8a01bccb97b8724f5d.


⚠ Bofrost.com has degraded performance

In 5858533, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 833 ms

Resolved: Bofrost.com performance has improved in e06827f after 6 minutes.


frangula, bureaucratical

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.1
logical conflict every: 1000
sleep for: 2100s
close stale after: 24 hours
[pullrequest]
requests per hour: 100
deps=[b,f]

/trunk merge


Master to Live for Ex2019

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/active-directory/Add-ADPermission.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/active-directory/Dump-ProvisioningCache.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/active-directory/Get-ADPermission.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/active-directory/Get-ADServerSettings.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/active-directory/Get-ADSite.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/active-directory/Get-AdSiteLink.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/active-directory/Get-DomainController.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/active-directory/Get-OrganizationalUnit.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/active-directory/Get-Trust.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/active-directory/Get-UserPrincipalNamesSuffix.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/active-directory/Remove-ADPermission.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/active-directory/Reset-ProvisioningCache.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/active-directory/Set-ADServerSettings.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/active-directory/Set-ADSite.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/active-directory/Set-AdSiteLink.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Add-AttachmentFilterEntry.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Add-ContentFilterPhrase.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Add-IPAllowListEntry.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Add-IPAllowListProvider.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Add-IPBlockListEntry.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Add-IPBlockListProvider.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Disable-MalwareFilterRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Enable-AntispamUpdates.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Enable-MalwareFilterRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Get-AgentLog.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Get-AttachmentFilterEntry.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Get-AttachmentFilterListConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Get-ContentFilterConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Get-ContentFilterPhrase.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Get-IPAllowListConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Get-IPAllowListEntry.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Get-IPAllowListProvider.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Get-IPAllowListProvidersConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Get-IPBlockListConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Get-IPBlockListEntry.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Get-IPBlockListProvider.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Get-IPBlockListProvidersConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Get-MailboxJunkEmailConfiguration.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Get-MalwareFilterPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Get-MalwareFilterRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Get-MalwareFilteringServer.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Get-RecipientFilterConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Get-SenderFilterConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Get-SenderIdConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Get-SenderReputationConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/New-MalwareFilterPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/New-MalwareFilterRule.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Remove-AttachmentFilterEntry.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Remove-ContentFilterPhrase.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/Remove-IPAllowListEntry.md
:white_check_mark:Succeeded
View (exchange-ps)

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Sporadically incorrect remediation actions

I have noticed that one of our end-to-end tests is flaky (install-test-fail), and sometimes acts in such a way that the failures counter suddenly resets and the wrong remediation strategy is taken.
From a first observation of the logs this problem does not seem to just exist for the end-to-end tests, but may also occur in real environments. I have a suspicion that it may have to do with the fact that we do not retry failed status updates, and seem to be running into the object has been modified; please apply your changes to the latest version and try again errors quote often, especially for the install-test-fail scenario.
This may be an indication that:

Multiple processes are touching the same resource
The (during reconciliation) modified object is not passed on correctly everywhere, and we have a split brain problem (aggravated by the fact that we do not perform retries on failed updates)

34_Debug failure.txt

I have noticed that one of our end-to-end tests is flaky (install-test-fail), and sometimes acts in such a way that the failures counter suddenly resets and the wrong remediation strategy is taken.

It looks to me like the status update which increments the failure count fails, and so the retry is not aware of any failed installs, but does find an existing release, so it tries to upgrade it.

From a first observation of the logs this problem does not seem to just exist for the end-to-end tests, but may also occur in real environments. I have a suspicion that it may have to do with the fact that we do not retry failed status updates, and seem to be running into the object has been modified; please apply your changes to the latest version and try again errors quote often, especially for the install-test-fail scenario.
This may be an indication that:
1. Multiple processes are touching the same resource

2. The (during reconciliation) modified object is not passed on correctly everywhere, and we have a split brain problem (aggravated by the fact that we do not perform retries on failed updates)

The kustomize-controller e2e tests show the same status update error messages, I think the issue is the reconciliation requests when the undlerying source becomes ready:
https://github.com/fluxcd/helm-controller/blob/main/controllers/helmchart_watcher.go#L73
https://github.com/fluxcd/kustomize-controller/blob/main/controllers/gitrepository_watcher.go#L80

Rather than setting the annotation can we just directly queue a reconciliation from the Go?
Do we want to retry status updates regardless of this issue?

I'll start looking into 1.

The kustomize-controller e2e tests show the same status update error messages, I wonder if the issue is the reconciliation requests when the undlerying source is updated etc:
https://github.com/fluxcd/helm-controller/blob/main/controllers/helmchart_watcher.go#L73

I guess not, still seeing the status update errors when disabling the helm chart watcher: #126

Rather than setting the annotation can we just directly queue a reconciliation from Go?

I read a lot of the kubernetes-sigs/cluster-api code this week, and I think something like this is possible using https://godoc.org/sigs.k8s.io/controller-runtime/pkg/handler#EnqueueRequestsFromMapFunc.
Also a quick heads up that I am working on a bigger overhaul of the controller code, due to lessons learned from the above. Focused around splitting the reconcileRelease logic into smaller bits, more resilient state observations, and making it testable based on the advises in this document and some of this.

I guess not, still seeing the status update errors when disabling the helm chart watcher

We are probably losing state somewhere due to not working with pointers everywhere, this seems to be one of the reasons cluster-api is making extensive use of pointers.

Looking at the recent commit history, it seems to have worsened when #115 was introduced. I can't directly see why however.

Based on the work in #127, the quick fix for this particular issue (without waiting for my refactor) is likey to use Client#Status#Update as much as we can to push status updates, instead of fully updating the object using Client#Update.

kustomize-controller uses Client#Status#Update everywhere and the conflict error is still there

@stefanprodan I think we should then try to use https://godoc.org/sigs.k8s.io/controller-runtime/pkg/handler#EnqueueRequestsFromMapFunc instead of annotating the object there, to see if this improves the situation.

I think something like this is possible using https://godoc.org/sigs.k8s.io/controller-runtime/pkg/handler#EnqueueRequestsFromMapFunc.

This is what I use in image-reflector and image-automation, rather than annotating objects.

This seems to have been solved by the changes in #131, #132 and #133.


Update logo and favicon

Altered the logo, attempting to address #22

I'm a fan. Will check this tomorrow and merge.

Works well, thanks so much!


Error Building for IOS in unity > 2019.1

Hi, thanks for this great plugin.
I got it to work in unity 2019.1, but if i try to build for IOS in a version higher than 2019.1
it happens in 2019.3.13F1 and 2020.1.6f1.
I always getting the same error:
Undefined symbols for architecture arm64:   "_OBJC_CLASS_$_SFSpeechAudioBufferRecognitionRequest", referenced from:       objc-class-ref in SpeechRecorderViewController.o   "_OBJC_CLASS_$_SFSpeechRecognizer", referenced from:       objc-class-ref in SpeechRecorderViewController.o ld: symbol(s) not found for architecture arm64 clang: error: linker command failed with exit code 1 (use -v to see invocation)
Am I doing something wrong?  In my Frameworks, Libraries and Embedded content I have:
AVFoundation.framework
Speech.framework
UnityFramework.framework
and in my Build phases, link binaries with Libraries:
AVFoundation.framework
Speech.framework
Any help will be appreciated,
Thanks.

Have same problem) HELP!

Having the exact same issue! Even hired a $350 coder for him to get the same issue, PLEASE HELPPP!!!!
PLEASE!!!

Having the exact same issue! Even hired a $350 coder for him to get the same issue, PLEASE HELPPP!!!!

On Sun, Sep 27, 2020 at 9:05 AM vitalikbobrik<EMAIL_ADDRESS>wrote:

Having the exact same issue! Even hired a $350 coder for him to get the
same issue, PLEASE HELPPP!!!!
PLEASE!!!
you can pay 350$ for me, and I'll build it)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/PingAK9/Speech-And-Text-Unity-iOS-Android/issues/30#issuecomment-699639737,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARE66E23FAVHA6N42VECLL3SH5BBTANCNFSM4RXGWL2Q
.

Haha I wish, I already paid a coder and I understand it and got it to work but I can’t get it to install I have a clean build and all that except for that damn SFSpeechrecognizer smh damn iOS problems left And right!
…

if you want to build and send it to appstore, you can use 2018.4.27 LTS version) it helps for me)

Ok I’ll try that version of unity I’ve been running everything on the most
recent version except for the newest Unity because they made the cardboard
feature a hassle
On Sun, Sep 27, 2020 at 9:12 AM vitalikbobrik<EMAIL_ADDRESS>wrote:

Haha I wish, I already paid a coder and I understand it and got it to work
but I can’t get it to install I have a clean build and all that except for
that damn SFSpeechrecognizer smh damn iOS problems left And right!
… <#m_-6572679686994694638_>
if you want to build and send it to appstore, you can use 2018.4.27 LTS
version) it helps for me)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/PingAK9/Speech-And-Text-Unity-iOS-Android/issues/30#issuecomment-699640508,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARE66EZMH5EXQCL2C7CS6YLSH5B3JANCNFSM4RXGWL2Q
.

I'm having the same issue - did Unity change the way they build for iOS after 2019.1 or something? Does anybody know if there's a good way of finding something like this out?

@PingAK9 because that build error is coming from the Link UnityFramework (arm64) build stage, does that mean that Xcode is looking for speech.framework code within UnityFramwork.framework?

figured it out finally! make sure Speech.framework is linked to the UnityFramework target, not the Unity-iPhone target

And was that on 2019.1 or?

built with 2019.4.10

Ahh copy I’ve been using 2019.4.11f1 let me try that out.

It would be nice to figure out in unity how to link speech.framework to unityframework.framework in the build so we dont have to manually link it every time in xcode. Perhaps unity's xcode API is the way to go for this, Im not sure

Yea I tried to install 2019.10 and it wouldn’t run any projects new or old the unity header toolbar would pop up but the actual editor would never open Idk why things must be so simple yet so complicated:P

Update: Got .4.10 to install and build successfully but now I get crash errors about the “Default Unity View Controller” is being reset or something it’s a “NSInternallConsistencyException” Anyone else having this crash? Other than that I get no errors :((

Finally got it to work but now my issue is with the autorotate even if I select it to be all orientations or just 1 it either gives me the error that I can // out and does this or it builds and does this... does anyone know how to fix this?? If I upgrade then the voice command doesn’t work.. any solutions?

Does anyone else have these autorotation issues where the camera spins u controllably in iOS? If so PLEASEE HELPPPP this is my last hoop to jump through to get my mobile vr game working!!

Uncontrollably

It would be nice to figure out in unity how to link speech.framework to unityframework.framework in the build so we dont have to manually link it every time in xcode. Perhaps unity's xcode API is the way to go for this, Im not sure

Hi, I've added to BuildPostProcessor the following code lines:
string unityframeworkTargetGUID = project.GetUnityFrameworkTargetGuid();
AddFrameworks(project, unityframeworkTargetGUID);

figured it out finally! make sure Speech.framework is linked to the UnityFramework target, not the Unity-iPhone target

It works perfect for me! Thanks guy~

figured it out finally! make sure Speech.framework is linked to the UnityFramework target, not the Unity-iPhone target

Thank you this worked perfectly.


feat: add management canister methods for interacting with the chunk store

Description
Adds upload_chunk, stored_chunks, clear_chunk_store and install_chunked_code to the management canister API.
How Has This Been Tested?
I have tested this locally by uploading a wasm comprised of 3 chunks, the I queried stored_chunks which returned the chunks, then I called install_chunked_code which completed successfully, then I called clear_chunk_store, then I queried stored_chunks again and this time it was empty.
Checklist:

[x] The title of this PR complies with Conventional Commits.
[x] I have edited the CHANGELOG accordingly.
[ ] I have made corresponding changes to the documentation.

@hpeebles
For the inconsistency between the interface-spec and the replica implementation, the conclusion is that the replica will be modified to align with the spec. So we have to wait for that before we can complete this PR.
And since it will be pub chunk_hashes_list: Vec<ChunkHash> in the end, we don't have to implement the custom serde methods now.
Turning this PR back to draft now.


logictest: convert operator unit tests to logic tests

Issue:  https://github.com/polarsignals/frostdb/issues/226
Not ready for review yet, just opened a draft for visibility.

@asubiotto i wasn't able to convert any more unit tests as i run into some issues while trying to convert them:

TestAggregationProjection and filter_test.go all uses Projections which is currently not supported by the sqlparser, i see there is already an issue for that so I am assuming that these unit tests were already out of scope for this #226 till they get unblocked
TestAggregateInconsistentSchema sorts the result before checking it but since the sqlparser does not support *ast.OrderByClause as of now I don't think i will be able to convert this test case correct me if I am wrong. I didn't find an equivalent of Order By in frostdb either so I am guessing that this can't be done even if sqlparser supported OrderBy?
the sqlparser does not support comparison operators with more than one characters for e.g. <= or >= when i was trying to convert a filter test which used GtEq(logicalplan.Literal(2)) the logictest panicked with this error i think panic: unsupported binary boolean expression [recovered]  Since frostdb supports these operators i think there should be an issue to add support for these in the sqlparser too

Another unrelated issue i ran across while playing around with logictest was this. I wrote the following logictest
createtable schema=default
----

insert cols=(labels.label1, labels.label2, labels.label3, labels.label4, stacktrace, timestamp, value)
value1  value2  null    null    stack1  1   1
value2  value2  value3  null    stack1  2   2
value3  value2  null    value4  stack1  3   3
----

exec
select labels, stacktrace, timestamp, value where labels.label4 = value4
----
value3  value2  null    value4  stack1  3   3

and it panicked with this
panic: something terrible has happened, this should have errored previously during validation

goroutine 1033 [running]:
github.com/polarsignals/frostdb/query/physicalplan.BinaryScalarOperation({0x19ce800, 0xc00064e3c0}, {0x0?, 0x0}, 0x1)
        /home/palash/dev/frostdb/query/physicalplan/binaryscalarexpr.go:93 +0xa11
github.com/polarsignals/frostdb/query/physicalplan.BinaryScalarExpr.Eval({0xc000664540?, 0x4905b0?, {0x0?, 0x0?}}, {0x19cf498, 0xc000b0a570})
        /home/palash/dev/frostdb/query/physicalplan/binaryscalarexpr.go:54 +0xfd
github.com/polarsignals/frostdb/query/physicalplan.filter({0x19bef40, 0x27931c8}, {0x19bcd00, 0xc0009ba160}, {0x19cf498, 0xc000b0a570?})
        /home/palash/dev/frostdb/query/physicalplan/filter.go:252 +0x97
github.com/polarsignals/frostdb/query/physicalplan.(*PredicateFilter).Callback(0xc000324c40, {0x19c0e78, 0xc000324e00}, {0x19cf498, 0xc000b0a570})
        /home/palash/dev/frostdb/query/physicalplan/filter.go:235 +0xd0
github.com/polarsignals/frostdb.(*Table).Iterator.func1()
        /home/palash/dev/frostdb/table.go:725 +0x6b5
golang.org/x/sync/errgroup.(*Group).Go.func1()
        /home/palash/go/pkg/mod/golang.org/x/sync@v0.0.0-20220601150217-0de741cfad7f/errgroup/errgroup.go:75 +0x87
created by golang.org/x/sync/errgroup.(*Group).Go
        /home/palash/go/pkg/mod/golang.org/x/sync@v0.0.0-20220601150217-0de741cfad7f/errgroup/errgroup.go:72 +0x12f
FAIL    github.com/polarsignals/frostdb/logictest       0.111s
FAIL

i am not sure if I did something wrong here but since the panic message said "it should have errored previously" i thought to let you folks know in case this is some missed edge case.
Let me know if this PR can be merged as is or would you like some more changes.
I would like to come back and convert the rest of the testcases once Projections are supported. 😄

So as not to step on toes, I should have a PR out today for adding Projections

TestAggregateInconsistentSchema sorts the result before checking it but since the sqlparser does not support *ast.OrderByClause as of now I don't think i will be able to convert this test case correct me if I am wrong. I didn't find an equivalent of Order By in frostdb either so I am guessing that this can't be done even if sqlparser supported OrderBy?

btw just read this in more detail. The exec directive has an unordered argument which doesn't look at output ordering. Not sure if using something like that would be equivalent.

thanks for mentioning i didn't know that, but then won't it turn out to identical to the aggregate_nulls logic test (except for the use of the directive ofcourse)
even both the unit tests AggregateNils and AggregateInconsistent schema were identical except for the sorting

i just tried this

exec unordered
select sum(value) as value_sum group by labels.label2
----
value2  5
             1

used unordered and flipped the order of the result but it fails
    logic_test.go:78:
        testdata/aggregate/aggregate_nulls:30:
         select sum(value) as value_sum group by labels.label2
        expected:
        value2  5
                1

        found:
                1
        value2  5

it expects the same result as aggregate_nulls

Hmm not quite sure why that would be failing. Can you run the test once with the -rewrite flag and see if it still fails? We'd need to dig a bit deeper


remove associated type from IndexMut impls

:sparkling_heart:

@Gankro can this be published?

0.0.20 released


fix: linux scan and getCurrentConnections

Motivation and Context
Fixes not full list of scanned networks and current connections on linux

Usage examples
wifi --scan
wifi --current
How Has This Been Tested?
Manual tests on Linux
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


ElasticSearch index gets too large when tracing a large cluster.

Requirement - what kind of business use case are you trying to solve?
ElasticSearch index gets too large when tracing a large cluster. It's more than 1TB at this time and we expect it to grow even more later on.
Problem - what in Jaeger blocks you from solving the requirement?
A single huge index makes searching pretty slow even when I only need to search the latest spans within an hour.
Proposal - what do you suggest to solve the problem or improve the existing situation?
Support rollover indices by finer granularity like every hour or even every quarter hour.
Any open questions to address

Jaeger works with Elastic Rollover, which allows you to set different index rollover policies other than one index per day. https://www.jaegertracing.io/docs/1.17/deployment/#elasticsearch-rollover


LRU Cache images

And maybe other enhancements so you're not resending the same image multiple times (URL or whatever)

Nah, the main bottleneck is network not CPU and honestly the delay is fine. I don't want to rely on external URLs.


group 'hare' does not exist

Hello,
I followed Hare installation instructions. However, after "sudo make install", when I tried to add current user to "hare" group, I got the following output:
[cc@motr experiments]$ sudo usermod --append --groups hare $USER
usermod: group 'hare' does not exist

Looks like "sudo make install" didn't create "hare" group, but I suppose it should? (just assumption)
Is it a big problem?
(Though I didn't manage to add current user to "hare" group, I can still bootstrap the cluster and perform IO using "m0cp" and "m0cat" following this guide.)

Hi @mengwanguc no this is not a big issue, I personally am not sure what this is used for as I have not been able to get this command to complete either. @knekrasov can you help with what this command does, is it necessary?

Just a quick note, a few months ago this problem did not occur. Back then, the guideline use sudo make devinstall instead of sudo make install.
I am not sure what is the effect of not having the hare group, but I believe it is needed for managing the right access so that only users in hare group can manage CORTX cluster through hare.

After a bit of digging, turns out only devinstall has @groupadd --force hare which is creating hare group for some reasons.
Since the current guideline use make install, I believe the sudo usermod --append --groups hare $USER is not needed and should be removed from the docs.

Just a quick note, a few months ago this problem did not occur. Back then, the guideline use sudo make devinstall instead of sudo make install.
I am not sure what is the effect of not having the hare group, but I believe it is needed for managing the right access so that only users in hare group can manage CORTX cluster through hare.

I will get permission issues if I run "m0cp" as current user. But I won't have problem if I run everything as root user.

With respect to the Quickstart checklist: 5.  <user> is a member of hare group .., perhaps we do need to create the hare group manually, or add @groupadd --force hare  on the make file (make install). We can create a PR if this is the correct solution.

I think we need to modify page https://github.com/Seagate/cortx-hare/blob/main/README.md and replace make install with make devinstall.
I think currently this make install  instruction is there, as previously there were some issues with make devinstall and we were not able to merge the related PR to main branch as it was locked.
Right @knekrasov ?

@suvratjoshi make devinstall is intended to be used by the developers. In this case it is easier to debug as long as the changes get 'deployed' automatically, there is no need to rebuild Hare and reinstall it. I don't think that this is the most-used use case for those who'll read README.md file.
I'm not really sure that hare group is really required to run Hare. So probably there is a discrepancy between our checklists and make install functionality.

@suvratjoshi, @knekrasov, I believe we need to update the Readme to avoid further confusion when the public follows the instructions. I am currently interning under John Bent supervision, and my main task is to find out any possible problem/bug related to all CORTX's readme.
Let us know the preferable solution, and we can make the PR for it. Thanks

@daniarherikurniawan - we are looking in to this. @mssawant will let us know what can be done here.. if change is required in README or we do not need to use this step of creating hare group. Thank you for contributing.

PR for this created by @daniarherikurniawan  has been merged in to main README. closing this.


⚠ Bofrost.fr has degraded performance

In db7a574, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1326 ms

Resolved: Bofrost.fr performance has improved in 7b755bf.


Savings and Idea alternate checkboxes not working

Before you open a bug report
Disable plugins and snippets that could be causing a conflict. Update to the latest versions of the following, and restart Obsidian:

Minimal Theme
Minimal Theme Settings plugin (or Style Settings plugin, but not both)
Contextual Typography plugin

Describe the bug
Support for alternate checkboxes was added in the most recent Minimal update. These checkboxes include - [S], for savings, and - [I], for idea. However, I have found that these checkboxes do not render correctly if any text comes after them on the same line. If any text is after - [S], it will render as a regular checked checkbox. If any text is after - [I], it will render as an information checkbox (the same as typing - [i], with a lowercase i). Both types of checkboxes do render as expected if no text follows them.
To reproduce
Steps to reproduce the behavior:

On a new line , type - [I] or - [S]
Add any text after this checkbox
Change from Editing to Reading mode (I am using the legacy editor)

Expected behavior
- [S] and - [I] rendering as a savings checkbox (dollar icon) and an idea checkbox (lightbulb icon), respectively.

https://user-images.githubusercontent.com/90682443/158005493-ff8bf87e-5350-4695-af9c-09c6409bac35.mov
Here's a video showing the behavior described above.

I assume that this somehow related to a case-sensitivity issue but I cannot reproduce this on my end

I have this issue on iOS (it works fine on desktop), but I was able to reproduce it slightly differently. Live Preview shows the correct icons but Reader mode doesn’t. Does that help with reproducing?


Add packaging and methods

Add version
Implement normal caching and add directory methods
Fixes #3

I'll add travis in the next PR


Syncurons API

Like x.sync and execSync, powered by child_process#spawnSync?

This package is really neat, I agree synchronous functions similar to those provided by child_process seem to be missing. These would allow us to easily replace packages such as execa (or others).

I think it makes sense to have a sync API
It'll be a chunky piece of work I think since most of the underlying logic is async. But should be doable


Use of the term "compactification" on pi-Base

Extending discussion coming out of #1159. I'm going to enumerate a few suggestions; please feel free to edit and add any alternatives I miss and correct mistakes I make.

"Compactification" is any compact space that contains the original space as a dense subspace.

"A one-point compactification" is any compactification that adds a single point; there are several of these: https://en.wikipedia.org/wiki/Alexandroff_extension#Non-Hausdorff_one-point_compactifications So we must specify "the Alexandroff one-point compactification" for the Alexandroff extension (nbhds of new point are complements of closed-and-compact sets in the original).
"The one-point compactification" always means Alexandroff extension.

"Compactification" is any Hausdorff compact space that contains the original space as a dense subspace. In this case, "the one-point compactification" is unique and only exists for non-compact locally compact Hausdorff spaces.

I think I'm in camp (1.i). I've never assumed "Hausdorff" in my definition of "compact", nor "compactification"; I don't think I'm alone among working mathematicians. It seems more in the spirit of pi-Base to define things minimally, particularly with regards to separation axioms. Since there are many ways to "compactify" a space, being careful to always specify "Alexandroff [one-point] compactification" seems the most careful option.

That seems very reasonable and workable to me.
That matches the general definition of compactification in https://en.wikipedia.org/wiki/Compactification_(mathematics).
And as @GeoffreySangston mentioned in https://github.com/pi-base/data/pull/1159#issuecomment-2565719873, this is also backed up by some references in the literature.

If we are going to make the change to 1.i, then we need to change all the names "the one-point compactification" to "Alexandroff one-point compactification" for all the Hausdorff spaces where the former is present. The reason being that uniqueness, even when the space is locally compact Hausdorff, is still not present.
As for the definition, this is a minor point, but I would specify that compactification is at its core really a dense embedding $i:X\hookrightarrow Y$ into a compact space $Y$. While $Y$ is referred to as compactification, this is really the pair $(Y, i)$ that is the compactification. Of course I realize that everyone probably knows that here, but it's still an important detail that can be easily forgotten.
So we are really not dealing with "spaces" as much as with "embeddings" and arguing if those embeddings should be into Hausdorff space or not necessarily, and what to name them in either case.
For me it's two different concepts, and I'd adopt either of them depending on my needs. I don't see a point in restricting myself to just one definition, but pi-base needs to be consistent.

It seems more in the spirit of pi-Base to define things minimally, particularly with regards to separation axioms.

It might be true for properties which one adds to pi-base, not necessarily for concepts that we use. And I think that's an important distinction. So this doesn't convince me.
Either way, I don't know of any ways in which non-Hausdorff compactifications are useful. So far I am not convinced that they are, no one has provided any solid reason to actually go for that definition, as far as I can see.
Could either of you @StevenClontz @prabau @GeoffreySangston provide reasons as for why those non-Hausdorff compactifications might be useful? And perhaps, why they might be useful for pi-base?

Question: If one starts with a Hausdorff space that is not locally compact, its "Alexandrov extension" is not Hausdorff. Would you also describe this case as a "one-point compactification" ?

I think, even though that there can be many (non-Hausdorff) one-point compactifications on a space, the Alexandrov construction is still the most famous one, so while I would change the descriptions in any case, I'd still keep the names of those spaces.
Either call "the one-point compactification" for Hausdorff compactifications (so description of S29 One Point Compactification of the Rationals would still need change) and Alexandrov one-point compactification/Alexandrov extension for non-Hausdorff compactifications, or be consist and go with single "Alexandrov one-point compactification" in all cases.

Could either of you @StevenClontz @prabau @GeoffreySangston provide reasons as for why those non-Hausdorff compactifications might be useful? And perhaps, why they might be useful for pi-base?

For one, in https://math.stackexchange.com/a/5009157/86887 @david20000813 used the trivial one-point compactification (adding a focal point whose only neighborhood is the entire space) to produce an example of a [weakly locally] compact and semiregular space which is not Baire.

Yes, it is true that we should then change many places to "Alexandroff one-point compactification". At least in the descriptions. ... But maybe you have a point that it would be too much?

There are only 15 files appearing under 'point compacti' when using the search feature on github_dev. Changing these to 'Alexandroff one-point compactification' would realistically take 5 minutes even without tools, so it doesn't seem worth worrying about. (It would also take 5 mins for the reviewer to double check no mistakes were made. But this is not worth worrying about.)

@GeoffreySangston provide reasons as for why those non-Hausdorff compactifications might be useful? And perhaps, why they might be useful for pi-base?

It's not clear to me if this is a question about terminology or about if these appear in legitimate mathematics. I really am agnostic on this, but a contrived answer to the first is that it appears in the name of the 'Wallman–Shanin Compactification', which applies to $T_1$ spaces and could appear in pi-base one day. As you say, context could be applied to allow either usage.
If this question is about the utility of these in mathematics, I won't make any great claims here but I'll just share some things I've learned recently. The non-Hausdorff cone construction (from the finite topological spaces literature, e.g. Barmak or Peter May) = open extension (from Steen-Seebach) = extension by a (closed) focal point results in a compact space. The non-Hausdorff cone is used in Barmak's book in a way similar to how a cone is used in conventional topology (there's also a non-Hausdorff suspension which is related to the non-Hausdorff cone in the same way the conventional suspension is related to the the conventional cone), and I believe that can be used to give a succinct construction of https://en.wikipedia.org/wiki/Pseudocircle and analogs of higher dimensional spheres). An expert in finite topology would have to be consulted to give you a real answer though. The open extension is known to be the minimal 'compactification' by one point, and the Alexandroff one-point compactification / extension is known to be the maximal.
My research is related to group actions.  $\mathbb{Z}$ acts by homotheties on $\mathbb{R}^2$. The orbit space of $\mathbb{R}^2 \backslash \{0\}$ is called a Hopf torus, which is a basic example in flat affine geometry. The orbit space of of $\mathbb{R}^2$ is an extension of $T^2$ by a focal point. I don't know if this is useful or not, but it helps me out at least by providing at least some kind of name and information, since usually this is just the kind of thing someone would call pathological and not examine further. This kind of pathology seems to occur all of the time in geometry, e.g., the leaf space of the Reeb foliation of $S^3$ is the extension of $S^1 \sqcup S^1$ by a focal point.

@GeoffreySangston "Wallman-Shanin compactification" that I found in Encyclopedia of General Topology seems to always be Hausdorff though, even though the construction is a bit more general as they mention.

Yes, it is true that we should then change many places to "Alexandroff one-point compactification". At least in the descriptions. ... But maybe you have a point that it would be too much?

There are only 15 files appearing under 'point compacti' when using the search feature on github_dev. Changing these to 'Alexandroff one-point compactification' would realistically take 5 minutes even without tools, so it doesn't seem worth worrying about. (It would also take 5 mins for the reviewer to double check no mistakes were made. But this is not worth worrying about.)

I agree it's not much work to do it.  When I was referring to "too much", I meant too much for readers to see, when the simpler "one-point compactification" would be adequate.

@Moniker1998
Forgetting about the one-point case for a moment.
Do you at least agree that the general term "compactification" can be applied the general case of a space embedded as a dense subspace of a compact space?  (that is, without any Hausdorff assumption)
That is a well attested usage, and mentioned explicitly in Encyclopedia of General Topology for example, and other sources.

Do you at least agree that the general term "compactification" can be applied the general case of a space embedded as a dense subspace of a compact space? (that is, without any Hausdorff assumption)

Yeah, of course.
It does make phrasing of certain theorems awkward, like "a space is Tychonoff if and only if it admits a (Hausdorff) compactification" but even if, that's not that much of a problem, and certainly not on pi-base.


doc: update kubernetes CNI requirements

Please ensure your pull request adheres to the following guidelines:

[ ] For first time contributors, read Submitting a pull request
[ ] All code is covered by unit and/or runtime tests where feasible.
[ ] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[ ] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[ ] All commits are signed off. See the section Developer’s Certificate of Origin
[ ] Provide a title or release-note blurb suitable for the release notes.
[ ] Are you a user of Cilium? Please add yourself to the Users doc
[ ] Thanks for contributing!

I have updated the docs about enabling the cilium CNI
Fixes: #26531
docs: Update instructions for enabling the CNI in Kubernetes 1.24+

@swastik959 could you rebase, squash and address the feedback if you still want to land this PR?

(marking draft while feedback is addressed. When you're ready to continue, click "Ready for review" at the bottom of the page)


Proposal: Type inference for pluck function (Typescript)

Example
Let's create user object and Observable from the object
const user = {
    name: "Johny Little",
    age: 32,
    address: {
        street: "Lonely Road 32",
        city: "Fantaspolis",
        country: "Fantasy land"
    },
    daddy: {
        name: "Luke Little",
        age: 58,
        address: {
            street: "High Road 5",
            city: "Pikopolis",
            country: "Fantasy land"
        }
    }
}

const userObservable = Observable.of(user)

Now let's create a new Observable by plucking age from userObservable :
// Infered type: Observable<{}>
// Actual type: Observable<number>
const userAgeObservable = userObservable.pluck("age")

As you can see, there is no type inference. I think it would be great if the type was automatically inferred.
// Inferred type: Observable<number>
const userAgeObservable = userObservable.pluck("age")

It would be even better if we could infer the type from nested properties:
// Inferred type: Observable<string>
const daddiesCityObservable = userObservable.pluck("daddy", "address", "street")

Implementation
The current type declaration looks like this:
export declare function pluck<T, R>(this: Observable<T>, ...properties: string[]): Observable<R>;

We can add overload declaration to get type inference if call pluck with one argument (e.g. pluck("age")):
export declare function pluck<T, K1 extends keyof T>(this: Observable<T>, property: K1): Observable<T[K1]>;
export declare function pluck<T, R>(this: Observable<T>, ...properties: string[]): Observable<R>;

// userObservable.pluck("age") <- this now works - inferred type Observable<string>
// userObservable.pluck("daddy", "address", "street") <- this still doesn't - inferred type Observable<{}>

We can go further and add more:
// 2 more overloads

export declare function pluck<T, K1 extends keyof T>(this: Observable<T>, property: K1): Observable<T[K1]>;
export declare function pluck<
    T,
    K1 extends keyof T,
    K2 extends keyof T[K1]
    >(this: Observable<T>, property1: K1, property2: K2): Observable<T[K1][K2]>;
export declare function pluck<
    T,
    K1 extends keyof T,
    K2 extends keyof T[K1],
    K3 extends keyof T[K1][K2]
    >(this: Observable<T>, property1: K1, property2: K2, property3: K3): Observable<T[K1][K2][K3]>;
export declare function pluck<T, R>(this: Observable<T>, ...properties: string[]): Observable<R>;

// userObservable.pluck("daddy", "address", "street") <- it works - inferred type Observable<string>

It looks pretty nasty, but works as expected. If you better way to do this in Typescript, please comment :).
In most cases we don't need to pluck property nested more than 5 levels deep. Therefore, I think it's sufficient to have 5 - 10 overloads, then it falls into the default one.
What do you think :)? If you think it's a good idea I can make PR.

RxJS version: 5.0.3
Editor: VS Code
Expected behavior: Type inference
Actual behavior: No type inference (always returns Observable<{}>)

Yeah, probably we're going similar way by @david-driscoll suggested, but keyof is blocked by ts 2.1. It is currently tracked  at https://github.com/ReactiveX/rxjs/issues/2179

keyof is definitely the way to go, but we're not able to support it yet, as it's a breaking to anyone using TS < 2.1.

Ok, shame it can't be supported now.

@ErikCupal , I've updated original to reflect issue more clearly, and closing this issue to track further effort in single issue. Appreciate for writing up actual proposal, we'd like to have it asap with TS 2.1.

Ok, fine :)

Hello everyone, with new Lettable operator in rxjs 5.5, I think we can improve type inference for pluck.
Here is my implementation:
const myPluck = <T, M extends T[keyof T] = T[keyof T]>(prop: keyof T) => (source: Observable<T>) =>
  new Observable<M>(obs => {
    return source.pipe(pluck<T, M>(prop)).subscribe({
      next(val) {
        obs.next(val);
      },
      error(err) {
        obs.error(err);
      },
      complete() {
        obs.complete();
      }
    });
  });

I think user don't often pluck many nested prop, if they want to, just add another pluck in pipe. So instead of give prop parameter type string[], we can constrain it with generic type as describe above, add a few overload, 3 perhaps, And user can now take advantage of fantastic type checking.
for example:
 data = this.route.data.pipe(myPluck<{messages: Mail[]}>('messages'));


stream: RX thread - separate thread safe receiver

rtcp_msg gets a reference to the mbuf of the RTCP packet.
https://github.com/baresip/baresip/pull/2454 needs this to be able to decode a duplicate of the original rtcp_msg.
Maybe a better solution would be to implement a deep copy function of rtcp_msg.

Can be closed due to https://github.com/baresip/baresip/pull/2454#discussion_r1109639253.


Relationship Modal - Options box low z-index

Laravel Version: 5.5.23
Voyager Version: 1.0.8
PHP Version: 7.1.11
Database Driver & Version: 10.1.28-MariaDB Apache/2.4.29 (Win32) OpenSSL/1.0.2

Description:
When opening the Relationship Modal by adding a new relationship, .modal-open .select2-container has a z-index of auto which makes it hidden or behind the back the modal itself. Can be fixed by adding a higher integer for its z-index
Steps To Reproduce:

Click on the Has One dropdown, the options box will not show.

Change the value of z-index property.

Please update to v1.0.9.  There was a bad CSS change that got into v1.0.8, and has since been reverted.


⚠ Bofrost.be has degraded performance

In aa14c17, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1300 ms

Resolved: Bofrost.be performance has improved in 11661fd.


Native-Base 2.15.2 incompatible with React-Native 0.69

Description
After updating React-Native from 0.68 to 0.69 app is not building anymore.
Error: Requiring module "node_modules\native-base\dist\src\index.js", which threw an exception: Invariant Violation: ViewPropTypes has been removed from React Native. Migrate to ViewPropTypes exported from 'deprecated-react-native-prop-types'
Also this error pops up in console when trying to build:
TypeError: undefined is not an object (evaluating '_$$_REQUIRE(_dependencyMap[14], "native-base").Item')
CodeSandbox/Snack link
not needed
Steps to reproduce
Upgrade React-Native from 0.68 to 0.69
NativeBase Version
2.15.2
Platform

[X] Android
[ ] CRA
[ ] Expo
[X] iOS
[ ] Next

Other Platform
No response
Additional Information
No response

Hey @Relax594, Thanks for reporting the issue. We'll look into it.

Same here, last EXPO sdk.

@inspmoore Fix works!

ah, this has been driving me crazy. Glad you have identified it, it's been a blocker for my team for more than a week now and we really need to release it with the latest EXPO sdk.
Very grateful for a speed resolution. Thanks

I already updated my app to native-base v3. Much faster than waiting for new version v2.

https://github.com/facebook/react-native/issues/33734#issuecomment-1211119020. this solution worked for me.

I put the polyfill in, and it's compiling and running, but:

many s are not showing properly (or at all)
CheckBox shows something like a dash in the box rather than a tick

Same here! Any updates on this issue?

facebook/react-native#33734 (comment). this solution worked for me.
Copied from comment above:
Created a file rn-polyfill-depricated-proptypes.js, and imported at top of index.js. Solved the issue for me
you may also change the get function to return from deprecated-react-native-prop-types
/** *File: rn-polyfill-depricated-proptypes.js **/ const reactnative = require('react-native');
Object.defineProperty(reactnative, 'ColorPropType', { configurable: true, get() { return {}; }, });
Object.defineProperty(reactnative, 'EdgeInsetsPropType', { configurable: true, get() { return {}; }, });
Object.defineProperty(reactnative, 'PointPropType', { configurable: true, get() { return {}; }, });
Object.defineProperty(reactnative, 'ViewPropTypes', { configurable: true, get() { return {}; }, });

Thank you this solved my issue!

Is there any way to release a new react-native v2 version to avoid doing the above hacks?

I am afraid that no fix for v2 is coming. What's more, they seem to abandon native-base v3 in favor of gluestack-ui.

Picker in native base library is not working. I have 2.15.2 native base version and react native 0.72.3 version. Any solution?


Example Extension

please provide an example extension or a tutorial in wiki

We do have an extension you can use for reference. It’s located at https://github.com/cairoshell/cairoshell/tree/master/Cairo Desktop/Extensions/CairoDesktop.Extensions.Places.ShellFolders
On Dec 27, 2018, at 5:25 AM, Sam Johnson <notifications<EMAIL_ADDRESS>wrote:
Great idea, will do! The extension api is not close to finished so it will be a living document.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcairoshell%2Fcairoshell%2Fissues%2F222%23issuecomment-450123963&data=02|01||9d2b652795984ef7224108d66be5a487|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636815031375542291&sdata=UuCTKLCmZ%2BINWC3bN1k2w9fdsjK%2FfUafU8LntNelGrc%3D&reserved=0, or mute the threadhttps://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGxXAUqzTW6Y5sx6CB3yIMbLs5eWl8Puks5u9KAggaJpZM4ZimeC&data=02|01||9d2b652795984ef7224108d66be5a487|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636815031375542291&sdata=udwpE0OPWZZHKTsZnA24h0%2B%2Bw2KuU3y13W%2FcWmbinLU%3D&reserved=0.

https://github.com/cairoshell/CairoExtensionSamples


Bug. Black background in versions

When trying to choose version of any app - it shown with black background.

Fixed, coming in the next version!

You can now update


Remove double 14 scaling

Due to an issue with ForceBalance not checking for global parameters inCustomBondForces we had to add the scale14 global parameter to the CustomNonbondedForce to allow fitting of the scale factor. This is now fixed in ForceBalance and the fix can be removed from here once this package works with openff-toolkit>0.11 and openff-interchange as these are the only versions now compatible with ForceBalance.

I'm was a little confused by this but just writing up my questions clarified it, I think.
If I understand correctly

the 1-4 scaling factor is not at risk of being applied twice
the issue is that it shows up in two places (.scale14 .global_parameters).
the linked change was just so ForceBalance would be aware of it as a tunable parameter, which is previously missed because of the types of forces it was looking at, and nothing to do with which force it was applied to

I also assume you want it to

remain as a tunable parameter on the ParameterHandler/OFFXML blob long-term
only shows up on the CustomBondForce that is used for 1-4 interactions
not touch the CustomNonbondedForce since there would be no point

Yes to all!


Infer docstring style

It would be nice if we could simply infer the doc string style automatically and choose the appropriate
parser. This would especially be useful when:

the code is the result of combining code from other projects using different doc styles
you are changing the official doc-string style and don't want to have to convert all your strings at once
you are subclassing from another library using a different doc string format and want to include inherited members

Allow me to move this over to griffe :slightly_smiling_face:


I'm getting this issue getting repeated using this plugin with my homebridge

Socket Closed with error "Error" getaddrinfo ENOTFOUND string
Keep on repeating with error this plugin version v2.3.12, if I remove this plugin it's gone. I only add one light and my settings and current plugin list screenshots are attached for reference.
So looking for your help badly on this.
Error Shown

Current Plugin List

Current Plugin Settings

Hi !
Same error for me
"Socket Closed with error "Error" getaddrinfo ENOTFOUND string"
I have just "Homebridge UI" and "Yeelighter" plugins (homebridge-yeelighter v2.3.12)

Homebridge v 1.3.4

:(

Same with homebridge-yeelighter v2.5.6
At the beginning it just didn't discovered any device, then after a few hours it found one of 2 devices, but after adding the devices info to the JSON configuration it just failed with this error in endless loop (not before I had to manually fix #127)...


[BUG] CompletionSuggestSearchIT.testSkipDuplicates is flaky

Description
CompletionSuggestSearchIT.testSkipDuplicates is Flaky, caused by https://github.com/opensearch-project/OpenSearch/pull/8668
Related Issues
Resolves https://github.com/opensearch-project/OpenSearch/issues/8932

Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Thx @reta! I just saw this failure on #8826 and noticed the suggestion scores were wonky in the repro (not a flaky test!).

Thanks @nknize, this is related to Apache Lucene 9.8.0-snapshot which is for main only (not backported to  any of 2.x)

d0h.. 2 minutes too late :)
I'll open a follow up PR

@reta We're seeing test failures on the 2.x branch (#8932 has been reopened), and I believe this change was never backported. Do we need to backport this?

@andrross totally, I missed that once we moved 2.x to Apache Lucene 9.8.0


Adding support for git metadata for all collection docs.

This addresses issue #15.
Any docs in a collection will also have git metadata added to them.
Posts is the standard collection, the test case adds a new collection "gizmos" with a document included that now receives the git metadata.

This is AWESOME and there are tests! 🎉 Unfortunately, I did an earlier merge that caused a conflict. I don't have the luxury of internet connection currently but I'll merge it once I can resolve it (or you can and I'll just hit the green button 😄
Thanks for fixing!

Found some time to merge this in. Thanks a bunch!


Allow WriteSDF to create v3000 SDF files

What does this implement/fix? Explain your changes.
This allows the sdf files to be saved to v3000 files

@jkhales thanks for the contribution! The code change looks good, but it needs a test for the new functionality to be added before it can be merged. Please add a test in UnitTestPandasTools.py that tests that the output SDF is actually being written as V3000. I'm happy to answer any questions you may have about how to do this.

Hi @greglandrum how do these tests look?

@greglandrum Just wanted to bump this guy so it's not forgotten! 🙏

@jkhales Thanks for the contribution!

@greglandrum Just wanted to bump this guy so it's not forgotten! pray

Thanks for the ping.


Filters cannot be set using xml configuration

JadeConfiguration.filters is a private Map and there is no common getter/setter for it (there are just methods like setFilter() and removeFilter() so it's impossible to inject filters via XML configuration.
Please add getter and setter for it.

Fixed in version 1.2.2


Quicker test for i32 taggability and more tagging opportunities

see https://github.com/dfinity/motoko/pull/3330#discussion_r907673478
"can_tag_i32" is now one instruction shorter
"box_i32" is now keeping more values tagged and less go to the heap
TODO:

write a hashing-heavy benchmark

Above commit documents some of the tagging success, from 100_000 Int32s previously 75_000 went to  heap, now only 50_000. The difference is 25_000. Each heap object occupies 8 bytes, so the win is about 200_000, as shown by the diff.


Add MODULE_INIT_COMPRESSED_FILE definition

This adds in the definition for MODULE_INIT_COMPRESSED_FILE so that we can use it in the init_module class of functions to load compressed modules

It looks like there may be some platforms where this isn't available. Could you please take a look at the failures on the latest CI?
@rustbot author

It looks like MOD_INIT_COMPRESSED_FILE was added in Linux 5.17. My guess is that the arm test is failing because it's the first test that runs on a version of Linux older than that.

@sinkingpoint could you rebase to get a fresh run of tests? This probably just needs something added in libc-test/build.rs to account for the platforms this is available on, as mentioned by @nathaniel-bennett

I pushed your branch with a rebase just to get fresh CI. Seems like this will need to be disabled on at least a few platforms.

:umbrella: The latest upstream changes (presumably #4132) made this pull request unmergeable. Please resolve the merge conflicts.


"Copy Deiner Anfrage" in mail subject.

After sending a request to a trader the subject of the confirmation mail to the sender looks like that: "Copy Deiner Anfrage"
"Kopie Deiner Anfrage" would probably be better.

@JnSnw : this has to be changed within the snedgrid template.
I do not have access to that.
Can you please fix that?

Change Copy to Kopie in Sendgrid.

tested and is Okay


Toggle theme is not working

Possible cause: theme preferences are not being saved in LocalStorage

Could you, please, provide more details? It seems to be working just fine for me


Ender Book Crash

Minecraft version & Mod Version: 1.12 / recent. All the Mods 3 pack
Single player or Server: Server
Describe problem (what you were doing / what happened): Crash on Ender book teleportation. I've seen previous posts about crashes with the ender book. I can replicate this crash as it only happen when flying / in the air. I will consistently crash when using the Ender book if not firmly planted on the ground. The coordinates / length of the teleport does not appear to be relevant.
Crash log (if any):

Maybe related to https://github.com/PrinceOfAmber/Cyclic/issues/846 , maybe not. I will test it while flying

Not sure if this will be a 100% fix but i cleaned up what i can let me know if it dies again https://minecraft.curseforge.com/projects/cyclic/files/2575589


Serialization codec registry inconsistent behavior

Referring to org.mongodb.bson documentations,

A CodecRegistry.get(class) should throw CodecConfigurationException if it can't find any codec.
A CodecProvider.get(class, registry) should return null if it can't provide a codec.

This is not the case with the current implementation. It always returns a SerializationCodec, because, the serializer extraction procedure always returns a serializer.
The above policies must be obeyed.

E.g. in case of composing codec registries using helper functions from CodecRegistries, the SerializationCodecRegistry never fails, so, other registries under the SerializationCodecRegistry will never get place.

The serializer extraction procedure is all healthy, until the last step. There is no way to determine if a context contains a polymorphic serializer for a requested class, without an object of that class, which is not available at the moment (in a CodecRegistry).
Then, if there is no polymorphic serializer registered in the context, a SerializationException will be thrown.

Found a hack, we can take advantage of SerialModule.dumpTo function.


Bug in IPv6 aggregation

There seems to be a bug in IPv6 aggregation.
For example for Cloudflare's AS13335, I get:
anurag@tools:~/irrpt$ php bin/irrpt_fetch 13335
Processing AS13335 (Record 1)
Completed processing of 1 IRR object(s).
anurag@tools:~/irrpt$

and now if I look at the v6 aggregate, I get:

anurag@tools:~/irrpt$ cat db/13335.6.agg
2a06:98c0::/29
2400:cb00::/32
2405:8100::/32
2405:b500::/32
2606:4700:f00::/40
2606:4700::/32
2803:f800::/32
anurag@tools:~/irrpt$

2606:4700:f00::/40 is part of 2606:4700::/32 and hence should not be there in the list.

Thanks for spotting this, will investigate.

Hey man sorry for taking so long -- can you give this a try with the latest pull?  Seems to work well now.

We tried with a new aggregator but found the performance on it was not great on large sets.   Will need to find another solution to this.


Confirm SN 0.13.1 final compliance

Validate RPC 0.7 final specs - any changes required?

No changes are required, we follow the spec (tested the rpc endpoints and they act as expected)


Attribute generation

This microservice provides synthetic attributes using mustache templates.

This PR also contains PR #89, I think that is a mistake.

Damn, You're right.


iOS Build Error due to NativeModules defaultProps reference

On iOS the following line prevents successful builds for an app using this package.
https://github.com/Spicy-Sparks/react-native-google-one-tap-signin/blob/707651c97aec870f402c92c69016d92c794acf52/src/GoogleOneTapSignInButton.js#L28
The Error:
TypeError: null is not an object (evaluating 'RNGoogleOneTapSignIn.BUTTON_SIZE_STANDARD')
Suggested change:
size: IS_IOS ? 0 : RNGoogleOneTapSignIn.BUTTON_SIZE_STANDARD,

LGTM!

@scgough Your change is now merged in. We also released version 1.0.5 on NPM containing the fix.

@geroale great! thank you. Will yarn also be updated?

@scgough Yes


Port simulated annealing

Port Simulated Annealing from Quantlib + few commits on Optimization folder fromQuantlib not ported yet.
No test available yet.

SonarQube analysis reported 5 issues

 2 critical
 2 major
 1 minor

Watch the comments in this conversation to review them.

SonarQube analysis reported 3 issues

 1 critical
 1 major
 1 minor

Watch the comments in this conversation to review them.


inks in articles don't open the in-app browser

via https://github.com/NewSpring/newspring-app/issues/163

We are now using the SafariViewController on iOS, and falling back to a the bad in-app browser. This project now has support for Chrome custom tabs here.
@dcs619 is this something good?


 This should hopefully be the last one these I gotta do

thanks for changing it


add a draft of a simple summary

closes #115

@cjvanlissa You always urge me towards simpler more understandable phrases and explanations. If you have a moment I would be glad if you take a look.

Wow, Capar this rewrite is great.

Wow, Capar this rewrite is great.


Handle SIGTERM for dependent helm processes

helm handles SIGTERM gracefully.
helmfile captures SIGTERM, but does nothing to pass the SIGTERM on to the helm processes to roll back those charts.
This is often painful in CI when many charts get stuck due to a SIGTERM and an immediate shutdown of the agent, once the helmfile process exited. At this time the helm processes might still be working and get killed by the agent, which leaves the chart in the "pending-install" state, from which one can only manually recover.
helmfile should pass the SIGTERM to the child processes and only exit once all child processes exited.

@jonnylangefeld please use v0.148.1

https://github.com/helmfile/helmfile