Do not change users' GOPATH

It is considered as a bad practice to ask users to change their GOPATH to build some library/program. Because users could not install the program through go get. More details could be found here. To quote:

Sometimes people set GOPATH to the root of their source repository and put their packages in directories relative to the repository root, such as "src/my/package". On one hand, this keeps the import paths short ("my/package" instead of "github.com/me/project/my/package"), but on the other it breaks go get and forces users to re-set their GOPATH to use the package. Don't do this.

To make it more idiomatic, I would suggest you to move every thing in src/ to the root directory and change the import paths accordingly.

work in progress...

Seconded. It's the first thing I noticed from the readme and it makes it obvious you didn't read/understand How to Write Go Code; so why should anyone look any further at any Go code you write?

Yes, I didn't understand How to Write Go Code clearly :(
I have fixed this issue.


streams: Search text is overflowing with x button.

While searching for a topic in streams, the text to be searched is overflowing with the "x"(clear) button.

CZO

@yogesh-sirsat This issue has already been filed #19765

This is a duplicate of #19765.


is it possible to use this script for email notifications in outlook account?

I have tried to implement it for my outlook account by passing below values in ".env"
SMTP_HOST=smtp-mail.outlook.com
SMTP_PORT=587
SMTP_HOST=smtp.office365.com
SMTP_PORT=587
The script doesn't throw any error but I do not get build notifications.
https://support.microsoft.com/en-us/office/pop-imap-and-smtp-settings-8361e398-8af4-4e97-b147-6c6c4ac95353


[Android][TextInput] Cursor color

TextInput needs a prop like 'syncCursorColor' to change cursor color.
syncCursorColor prop value should be a bool. If there is a syncCursorColor prop in the textInput component (it means the prop value is true) then the java code of android:textCursorDrawable="@null" has to be run in Android side.
I've never contribute to this repository. So I don't know what the React-Native textInput component code and how should it be changed.
The cursor color cannot be changed yet. And if placeholderTextColor and underlineColorAndroid are assigned the component appearance is not good like the following.

However this blog says;

Set the android:textCursorDrawable attribute value to @null, then EditText widget will display text color as cursor color

<RelativeLayout
    xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:tools="http://schemas.android.com/tools"
    android:id="@+id/rl"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:padding="10dp"
    tools:context=".MainActivity"
    android:background="#ced4cb"
    >
    <!--
        android:textCursorDrawable="@null"
        android:textColor

            Set the android:textCursorDrawable attribute value to @null,
            then EditText widget will display text color as cursor color
    -->
    <EditText
        android:id="@+id/et"
        android:layout_width="250dp"
        android:layout_height="wrap_content"
        android:hint="Input your country"
        android:padding="10dp"
        android:textCursorDrawable="@null"
        />
    <EditText
        android:id="@+id/et_city"
        android:layout_width="250dp"
        android:layout_height="wrap_content"
        android:hint="Input your City"
        android:padding="10dp"
        android:layout_below="@+id/et"
        android:textCursorDrawable="@null"
        android:textColor="#ff0004"
        />
</RelativeLayout>

@mkonicek shouldn't this be default behaviour?

@grabbou , your question is not for me but I think shouldn't.
Because Android sets the EditText cursor and placeholder as gray as default. However, when developing Android app this color can be changed.
For instance; YouTube search EditText's cursor color. When pressing the magnifying glass to search video, the title and menu icon are removed and cursor color is changed to 'red'. (Sony music app sets search EditText's color as 'cyan' etc.)
In my case I use a dark color (deep purple) as toolbox color. I can color everything as white except cursor. And the user can not be aware of the cursor on the textInput.

See https://github.com/facebook/react-native/blob/master/ISSUE_TEMPLATE.md
This is a feature request that should live on Product Pains so people can see how many people want this feature and prioritize based on that. Also, this should be implemented by the community, fb won't add this unless it's needed in one of the fb apps. GitHub should be used for tracking bugs.
I'll close this but feel free to move this to Product Pains / continue the discussion here.


Report does not display on PR

Using the example on the market place I have implemented something and all the jobs run successfully but the report is not added to the comment section of the PR
The CI file looks like this:
`name: Github-Actions
on:
push:
jobs:
test:
name: running unit tests
runs-on: ubuntu-latest
permissions:
# Required to checkout the code
contents: read
# Required to put a comment into the pull-request
pull-requests: write`
steps:
- uses: actions/checkout@v2
- name: Install Tools
  run:
    make install-tools
- name: Linting
  run:
    make lint
- name: Running tests Test
  run:
    make test
- name: Running Coverage Test
  run:
    npx vitest --coverage
- name: Code Coverage Summary Report
  # Also generate the report if tests are failing
  if: always()
  uses: davelosert/vitest-coverage-report-action@v2
  with:
    json-summary-path: coverage/coverage-summary.json
    json-final-path: coverage/coverage-final.json
- name: Add Coverage PR Comment
  uses: marocchino/sticky-pull-request-comment@v2
  if: github.event_name == 'pull_request'
  with:
    recreate: true
    path: code-coverage-results.md

Please how do I fix this

Hey @Wandji69 ,
have you checked the action logs to see what went wrong?
Also, you don't need the last step with the marocchino/sticky-pull-request-comment@v2. This action will produce the coverage report on it's own and comment it on the pr.

I was able to fix the issue as I noticed I was triggering the build on:
push. So I made it on: pull_request and it worked perfectly fine now.
Thanks for the support.
On Mon, Jun 26, 2023 at 7:38 PM David Losert @.***>
wrote:

Hey @Wandji69 https://github.com/Wandji69 ,
have you checked the action logs to see what went wrong?
Also, you don't need the last step with the
@.*** This action will produce the
coverage report on it's own and comment it on the pr.
—
Reply to this email directly, view it on GitHub
https://github.com/davelosert/vitest-coverage-report-action/issues/242#issuecomment-1608024893,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHHQANYL4UHULV67K52B54DXNHJLRANCNFSM6AAAAAAZUDAKMY
.
You are receiving this because you were mentioned.Message ID:
@.***
com>

Glad to hear! Closing this issue. 🙂


Binary masking [WIP]

Adds support for non-matplotlib colored segmentation maps, without polygon borders. Instead, uses an indexed color.
This is for supporting raw readback of masks based on class/label index.

[ ] Port visualizer.py to https://github.com/webaverse/detectron2

Ported.


GUI_Reading Model Error

Hi Ramy,
Hope you are well. This is an error I am getting, can you please let me know if this is a GUI issue or something else. Thanks.

Hello Ramy,
I am having the same issue.

Hello Ramy,
I am having a similar issue, but my log does not mention the Buffer mismatch.
Also I note that my Lab 1 model still works correctly, so I do not believe that it is a connection error with the RPi.
outputLog.txt

@cljang If it doesn't mention the reason of the failure, it is likely that you have quite an old version, please use git pull in your GUI folder

As for the buffer dtype mismatch, can you confirm that you're training the model using a 32-bit machine or a 32-bit virtual env?

This problem looks similar to this: https://stackoverflow.com/questions/21033038/scikits-learn-randomforrest-trained-on-64bit-python-wont-open-on-32bit-python

Hi Ramy,
I tried to git pull yesterday, so my git is Already up to date.

@cljang sorry, this was actually an RPi_script update, you will need to git pull in the folder on the RPi, or go to Utilities-> Update RPi Script from the GUI (that second option may not work on the old version though but you can try)

I am using

@zipal12671 Please take a look at this: https://github.com/RamyE/SFU_ML#notes

Ok, I will try that thank you. This is weird because I used the same setup for Lab 1 and it worked perfectly fine.

So I used Utilities-> Update RPi Script from the GUI, which I believe worked correctly. Instead of it saying that there is a Problem opening the current model, it now has an error with lab selection. It makes multiple attempts to send the command SELECT_LAB with payload Lab2
outputLog2.txt

Are you sure it worked correctly? Also you need to reboot the RPi after running the command. If you did, this is probably cause the RPi hasn't fully rebooted yet and you just need to wait a minute or two (refer to: https://github.com/RamyE/SFU_ML/blob/master/Ui_project/manual.md#the-gui-is-running-but-i-keep-getting-errors)

So I checked my RPi in PuTTY, went to SFU_ML, and tried to git pull and got the following error:
error: object file .git/objects/b6/d218ccaa3a5ee34969641828a647fcbcd709f5 is empty
fatal: loose object b6d218ccaa3a5ee34969641828a647fcbcd709f5 (stored in .git/objects/b6/d218ccaa3a5ee34969641828a647fcbcd709f5) is corrupt
I assume this means something is broken with my cloned repo and that the Update RPi Script in GUI didn't work.
How can I reset the state of my RPi cloned repo? git reset?

I am not a git expert, so google may be your best friend here :D You can try git reset --hard. Worst case scenario just delete your SFU_ML directory and clone it again using the relevant steps here: https://github.com/RamyE/SFU_ML/blob/master/Ui_project/manual.md#14-clone-the-python-script

Okay, I deleted and recloned the repo which got me back to where I started, and then I followed the instructions to run a 32 bit python environment to pickle the models. Now my model is correctly working.
Thanks.

@RamyE @cljang I did create a 32 bit environment and it launches but for the model what's the version of Notebook compatible with 32 bit env as that's the error I'm getting. Or should I change anything in the command when saving the model on a 64 bit base root?

I haven't used a jupyter notebook with 32-bit env before so not sure, but you can probably just use a python script (no need for a jupyter notebook). I also don't understand when did you get this error?

Oh I got the error "Unsatisfiable Error" on the Anaconda Application. I'm facing another issue now, I have trained the model on my pi and saved the model file but the GUI throws in this error.

I see why the error has come so, the Model file has this in it. Any thoughts?

can you try to update (git pull) the RPi script?
Also, what were you trying to do when you got the "Unsatisfiable Error". That is what I meant by "when"

When I got the "Unsatisfiable Error" i was trying to install JupyterNB for the specific 32-bit environment ml_course32.
I did update the RPi script. Tried again, still same error - also FYI i need to comment out the following lines in the main.py on my mac to ensure it works -  159, 446-451.

I guess Jupyter NB may not be available for the 32-bit environment then. You can still just use a .py script and run it directly using python script_name.py after conda activate ml_course_32 or whatever your environment name is
As for the problem, it seems that it is a version incompatibility issue according to this https://github.com/ageitgey/face_recognition/issues/1262 Just make sure you have the same version of sklearn where you trained the model and where you're running it because they change the naming from classification to _classification

Hi Ramy, So after a lot of uninstalling, installing, recloning and help from almost all your links, my model is working, thank you so much.


trim className before split to avoid empty className

in function patchAttributes(dom, prev, cur), className like 'someClassName ' get an array contains empty element after split(' ') called. dom.classList.add(emptyString) will case an exception : Uncaught (in promise) DOMException: Failed to execute 'add' on 'DOMTokenList': The token provided must not be empty.

We're targeting platforms (specically IE11) that don't have trim. Maybe express this as a filter call after the split instead to avoid that?

MDN and caniuse says that String.prototype.trim has been supported since IE10.
Using .split(" ").filter(Boolean) is more compatible (with up to IE9) but prosemirror homepage says compatibility starts at IE11.

Ah, I guess it's trimStart/trimEnd that aren't in IE11. Thanks for pointing that out. I agree the filter patch is nicer.


When I first increase the version number, it will cause the 'latest_testflight_build_number' operation to fail.

Question Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Question Subject

When I first increase the version numbe, I want to get the testFlight build number.
Question Description

  testflight_last_version = latest_testflight_build_number(
  version: get_version_number,
  app_identifier: "#{app_identifier}",
  username: "#{user_name}"
  ).to_i

How can I solve this problem? Thanks for your help.

Could you please post the complete output you are getting? There must be more to the error message than just that I guess.

Getting similar output... here's the stack trace
INFO [2019-04-11 10:45:29.46]: Login successful
DEBUG [2019-04-11 10:45:30.43]: All plugins are up to date
bundler: failed to load command: fastlane (/usr/local/bin/fastlane)
FastlaneCore::Interface::FastlaneError: [!] Could not find a build number for version 8.8
  /Library/Ruby/Gems/2.3.0/gems/fastlane-2.120.0/fastlane_core/lib/fastlane_core/ui/interface.rb:141:in `user_error!'
  /Library/Ruby/Gems/2.3.0/gems/fastlane-2.120.0/fastlane_core/lib/fastlane_core/ui/ui.rb:17:in `method_missing'
  /Library/Ruby/Gems/2.3.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/actions/app_store_build_number.rb:45:in `get_build_number'
  /Library/Ruby/Gems/2.3.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/actions/app_store_build_number.rb:11:in `run'
  /Library/Ruby/Gems/2.3.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/actions/latest_testflight_build_number.rb:11:in `run'
  /Library/Ruby/Gems/2.3.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/runner.rb:256:in `block (2 levels) in execute_action'
  /Library/Ruby/Gems/2.3.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/actions/actions_helper.rb:50:in `execute_action'
  /Library/Ruby/Gems/2.3.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/runner.rb:235:in `block in execute_action'
  /Library/Ruby/Gems/2.3.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/runner.rb:227:in `chdir'
  /Library/Ruby/Gems/2.3.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/runner.rb:227:in `execute_action'
  /Library/Ruby/Gems/2.3.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/one_off.rb:42:in `run'
  /Library/Ruby/Gems/2.3.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/one_off.rb:22:in `execute'
  /Library/Ruby/Gems/2.3.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/commands_generator.rb:221:in `block (2 levels) in run'
  /Library/Ruby/Gems/2.3.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:178:in `call'
  /Library/Ruby/Gems/2.3.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:153:in `run'
  /Library/Ruby/Gems/2.3.0/gems/commander-fastlane-4.4.6/lib/commander/runner.rb:476:in `run_active_command'
  /Library/Ruby/Gems/2.3.0/gems/fastlane-2.120.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:76:in `run!'
  /Library/Ruby/Gems/2.3.0/gems/commander-fastlane-4.4.6/lib/commander/delegates.rb:15:in `run!'
  /Library/Ruby/Gems/2.3.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/commands_generator.rb:333:in `run'
  /Library/Ruby/Gems/2.3.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/commands_generator.rb:41:in `start'
  /Library/Ruby/Gems/2.3.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/cli_tools_distributor.rb:119:in `take_off'
  /Library/Ruby/Gems/2.3.0/gems/fastlane-2.120.0/bin/fastlane:23:in `<top (required)>'
  /usr/local/bin/fastlane:22:in `load'
  /usr/local/bin/fastlane:22:in `<top (required)>'

Terminal information:

report.xml information:

  <testcase classname="fastlane.lanes" name="0: default_platform" time="0.006507">

  </testcase>1

  <testcase classname="fastlane.lanes" name="1: Switch to ios update_build_version lane" time="0.000909">

  </testcase>

  <testcase classname="fastlane.lanes" name="2: get_version_number" time="2.289654">

  </testcase>

  <testcase classname="fastlane.lanes" name="3: latest_testflight_build_number" time="5.396566">

      <failure message="/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/actions/actions_helper.rb:48:in `execute_action'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/runner.rb:235:in `block in execute_action'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/runner.rb:227:in `chdir'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/runner.rb:227:in `execute_action'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/runner.rb:157:in `trigger_action_by_name'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/fast_file.rb:154:in `method_missing'
Fastfile:39:in `block (2 levels) in parsing_binding'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/lane.rb:33:in `call'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/runner.rb:204:in `try_switch_to_lane'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/runner.rb:146:in `trigger_action_by_name'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/fast_file.rb:154:in `method_missing'
Fastfile:34:in `block (2 levels) in parsing_binding'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/runner.rb:284:in `execute_flow_block'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/runner.rb:46:in `block in execute'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/runner.rb:45:in `chdir'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/runner.rb:45:in `execute'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/lane_manager.rb:56:in `cruise_lane'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/command_line_handler.rb:36:in `handle'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/commands_generator.rb:108:in `block (2 levels) in run'
/usr/local/lib/ruby/gems/2.5.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:178:in `call'
/usr/local/lib/ruby/gems/2.5.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:153:in `run'
/usr/local/lib/ruby/gems/2.5.0/gems/commander-fastlane-4.4.6/lib/commander/runner.rb:476:in `run_active_command'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.120.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:76:in `run!'
/usr/local/lib/ruby/gems/2.5.0/gems/commander-fastlane-4.4.6/lib/commander/delegates.rb:15:in `run!'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/commands_generator.rb:333:in `run'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/commands_generator.rb:41:in `start'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.120.0/fastlane/lib/fastlane/cli_tools_distributor.rb:119:in `take_off'
/usr/local/lib/ruby/gems/2.5.0/gems/fastlane-2.120.0/bin/fastlane:23:in `<top (required)>'
/usr/local/bin/fastlane:23:in `load'
/usr/local/bin/fastlane:23:in `<main>'

Could not find a build number for version 2.15.2" />

  </testcase>

same here. I think I found this since I updated fastlane to latest version. I initially used like
latest_testflight_build_number(version:"2.2.0", initial_build_number:"1")

so if 2.2.0 is not found, it used to return initial build number instead.

Same here

Same here.

Ok, that doesn't really help more @Link913.
Please, post the information necessary to understand your problems. The bug report template includes all the stuff we need, so please use that as a template. Thanks.

I think this commit https://github.com/fastlane/fastlane/commit/78fd2b1b5e5414251cd8c08c042f4af36d9ca70e breaks it. If there is no version we should fallback on initial_build_number
# Get version number from latest pre-release if no version number given
          client = Spaceship::ConnectAPI::Base.client
          version = client.get_pre_release_versions(filter: filter, sort: "-version", limit: 1).first
          unless version
            UI.user_error!("Could not find a build number for version #{version_number}")
          end

I have Fastlane 2.120.0 installed, and fastlane run latest_testflight_build_number was failing on the weekend, but I just tried this morning and it's returning the correct build number. Not sure is Apple fixed anything on their end, but this appears to be working again.

Same here

Which one @wolfasaeru - the being broken or the working again magically after the weekend?

It's still not working for me with fastlane 2.120.0. I see this error "Could not find a build number for version 5.0.0".
5.0.0 is the new version I am using for latest_testflight_build_number, it does not have any builds yet on Testflight.
This is the script I have. It used to work fine until like a week ago, but it's suddenly not working now.
latest_testflight_build_number = latest_testflight_build_number(
team_id: ENV['itc_team_id'],
app_identifier: ENV['app_identifier'],
version: "#{versionNumber}",
initial_build_number: "1"
)

It's still not working for me with fastlane 2.120.0. I see this error "Could not find a build number for version 5.0.0".
5.0.0 is the new version I am using for latest_testflight_build_number, it does not have any builds yet on Testflight.
This is the script I have. It used to work fine until like a week ago, but it's suddenly not working now.
latest_testflight_build_number = latest_testflight_build_number(
team_id: ENV['itc_team_id'],
app_identifier: ENV['app_identifier'],
version: "#{versionNumber}",
initial_build_number: "1"
)

@janpio yesterday I tried to make a build with fastlane version 2.120.0 and it failed with ‘Could not find a build number for version’

Hi @janpio, I'm getting the same error when trying to get latest_testflight_build_number on a new version.

New Regression Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Regression Information

Breaking version: [e.g. 2.120.0]
Last working version: [e.g. 2.116.1]

Regression Description

Running latest_testflight_build_number on a new version (i.e. one that doesn't exist on itunesconnect yet) fails.
Complete output when running fastlane, including the stack trace and command used

➜  APP_NAME-ios git:(alpha) ✗ bundle exec fastlane build_APP_NAME_alpha
[✔] 🚀
[14:30:39]: ------------------------------
[14:30:39]: --- Step: default_platform ---
[14:30:39]: ------------------------------
[14:30:39]: Driving the lane 'ios build_APP_NAME_alpha' 🚀
[14:30:39]: --------------------------------
[14:30:39]: --- Step: get_version_number ---
[14:30:39]: --------------------------------
[14:30:39]: --------------------------------------------
[14:30:39]: --- Step: latest_testflight_build_number ---
[14:30:39]: --------------------------------------------
[14:30:39]: To not be asked about this value, you can specify it using 'username'
[14:30:43]: Login to App Store Connect
[14:30:45]: Login successful
+------------------+------------------------+
|               Lane Context                |
+------------------+------------------------+
| DEFAULT_PLATFORM | ios                    |
| PLATFORM_NAME    | ios                    |
| LANE_NAME        | ios build_APP_NAME_alpha |
| VERSION_NUMBER   | 0.0.10                 |
+------------------+------------------------+
[14:30:46]: Could not find a build number for version 0.0.10
+------+-------------------------------+-------------+
|                  fastlane summary                  |
+------+-------------------------------+-------------+
| Step | Action                        | Time (in s) |
+------+-------------------------------+-------------+
| 1    | default_platform              | 0           |
| 2    | get_version_number            | 0           |
| 💥   | latest_testflight_build_numb  | 7           |
|      | er                            |             |
+------+-------------------------------+-------------+
[14:30:46]: fastlane finished with errors
[!] Could not find a build number for version 0.0.10

Environment

✅ fastlane environment ✅
Stack

Key
Value

OS
10.14.3

Ruby
2.3.7

Bundler?
true

Git
git version 2.20.1 (Apple Git-117)

Installation Source
/usr/local/bin/fastlane

Host
Mac OS X 10.14.3 (18D109)

Ruby Lib Dir
/System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/lib

OpenSSL Version
LibreSSL 2.6.4

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
10.2

System Locale

Variable
Value

LANG
en_GB.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:
`./fastlane/Fastfile`
# This file contains the fastlane.tools configuration
# You can find the documentation at https://docs.fastlane.tools
#
# For a list of all available actions, check out
#
#     https://docs.fastlane.tools/actions
#
# For a list of all available plugins, check out
#
#     https://docs.fastlane.tools/plugins/available-plugins
#

# Uncomment the line if you want fastlane to automatically update itself
# update_fastlane

default_platform(:ios)

before_all do
  ENV['DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS'] = ' '
end

platform :ios do
  desc "Build Reclip iOS Alpha"
  lane :build_reclip_alpha do
    version = get_version_number
    latestBuildNumber = latest_testflight_build_number(version: version, app_identifier: "com.reclip.alpha")
    increment_build_number(
      build_number: latestBuildNumber + 1
    )
    get_certificates
    get_provisioning_profile(
      app_identifier: "com.reclip.alpha"
    )
    build_ios_app(
      workspace: "Reclip.xcworkspace",
      configuration: "Alpha",
      scheme: "Reclip"
    )
  end

  desc "Build Reclip iOS Beta"
  lane :build_reclip_beta do
    version = get_version_number
    latestBuildNumber = latest_testflight_build_number(version: version, app_identifier: "com.reclip.beta")
    increment_build_number(
      build_number: latestBuildNumber + 1
    )
    get_certificates
    get_provisioning_profile(
      app_identifier: "com.reclip.beta"
    )
    build_ios_app(
      workspace: "Reclip.xcworkspace",
      configuration: "Beta",
      scheme: "Reclip"
    )
  end

  desc "Build Reclip iOS Proto"
  lane :build_reclip_proto do
    version = get_version_number
    latestBuildNumber = latest_testflight_build_number(version: version, app_identifier: "com.reclip.proto")
    increment_build_number(
      build_number: latestBuildNumber + 1
    )
    get_certificates
    get_provisioning_profile(
      app_identifier: "com.reclip.proto"
    )
    build_ios_app(
      workspace: "Reclip.xcworkspace",
      configuration: "Proto",
      scheme: "Reclip"
    )
  end

  desc "Build Reclip iOS Production"
  lane :build_reclip_production do
    version = get_version_number
    latestBuildNumber = latest_testflight_build_number(version: version, app_identifier: "com.reclip")
    increment_build_number(
      build_number: latestBuildNumber + 1
    )
    get_certificates
    get_provisioning_profile(
      app_identifier: "com.reclip"
    )
    build_ios_app(
      workspace: "Reclip.xcworkspace",
      configuration: "Release",
      scheme: "Reclip"
    )
  end

  desc "Upload Build to TestFlight"
  lane :upload_reclip_to_testflight do
    upload_to_testflight(
	    skip_waiting_for_build_processing: true,
	    username<EMAIL_ADDRESS>    )
  end

end

`./fastlane/Appfile`
itc_team_id("119688839") # App Store Connect Team ID
team_id("PJWC9KVM7B") # Developer Portal Team ID
<EMAIL_ADDRESS>

fastlane gems

Gem
Version
Update-Status

fastlane
2.120.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.0.0

bundler
2.0.1

io-console
0.4.5

CFPropertyList
3.0.0

concurrent-ruby
1.1.4

i18n
0.9.5

minitest
5.8.5

thread_safe
0.3.6

tzinfo
1.2.5

activesupport
4.2.10

public_suffix
2.0.5

addressable
2.6.0

atomos
0.1.3

babosa
1.0.2

claide
1.0.2

fuzzy_match
2.0.4

nap
1.1.0

cocoapods-core
1.6.1

cocoapods-deintegrate
1.0.3

cocoapods-downloader
1.2.2

cocoapods-plugins
1.0.0

cocoapods-search
1.0.0

cocoapods-stats
1.1.0

netrc
0.11.0

cocoapods-trunk
1.3.1

cocoapods-try
1.1.0

colored2
3.1.2

escape
0.0.4

fourflusher
2.2.0

gh_inspector
1.1.3

molinillo
0.6.6

ruby-macho
1.4.0

nanaimo
0.2.6

xcodeproj
1.8.2

cocoapods
1.6.1

colored
1.2

highline
1.7.10

commander-fastlane
4.4.6

declarative
0.0.10

declarative-option
0.1.0

digest-crc
0.4.1

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20180417

dotenv
2.7.2

emoji_regex
1.0.1

excon
0.64.0

multipart-post
2.0.0

faraday
0.15.4

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

faraday_middleware
0.13.1

fastimage
2.1.5

jwt
2.1.0

memoist
0.16.0

multi_json
1.13.1

os
1.0.0

signet
0.11.0

googleauth
0.6.7

httpclient
2.8.3

mime-types-data
3.2019.0331

mime-types
3.2.2

uber
0.1.0

representable
3.0.4

retriable
3.1.2

google-api-client
0.23.9

google-cloud-env
1.0.5

google-cloud-core
1.3.0

google-cloud-storage
1.16.0

json
2.2.0

mini_magick
4.5.1

multi_xml
0.6.0

plist
3.5.0

rubyzip
1.2.2

security
0.1.3

naturally
2.2.0

simctl
1.6.5

slack-notifier
2.3.2

terminal-notifier
2.0.0

unicode-display_width
1.5.0

terminal-table
1.8.0

tty-screen
0.6.5

tty-cursor
0.6.1

tty-spinner
0.9.0

word_wrap
1.0.0

rouge
2.0.7

xcpretty
0.3.0

xcpretty-travis-formatter
1.0.0

generated on: 2019-04-16

Hi @janpio, I'm getting the same error when trying to get latest_testflight_build_number on a new version.

New Regression Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Regression Information

Breaking version: [e.g. 2.120.0]
Last working version: [e.g. 2.116.1]

Regression Description

Running latest_testflight_build_number on a new version (i.e. one that doesn't exist on itunesconnect yet) fails.
Complete output when running fastlane, including the stack trace and command used

➜  APP_NAME-ios git:(alpha) ✗ bundle exec fastlane build_APP_NAME_alpha
[✔] 🚀
[14:30:39]: ------------------------------
[14:30:39]: --- Step: default_platform ---
[14:30:39]: ------------------------------
[14:30:39]: Driving the lane 'ios build_APP_NAME_alpha' 🚀
[14:30:39]: --------------------------------
[14:30:39]: --- Step: get_version_number ---
[14:30:39]: --------------------------------
[14:30:39]: --------------------------------------------
[14:30:39]: --- Step: latest_testflight_build_number ---
[14:30:39]: --------------------------------------------
[14:30:39]: To not be asked about this value, you can specify it using 'username'
[14:30:43]: Login to App Store Connect
[14:30:45]: Login successful
+------------------+------------------------+
|               Lane Context                |
+------------------+------------------------+
| DEFAULT_PLATFORM | ios                    |
| PLATFORM_NAME    | ios                    |
| LANE_NAME        | ios build_APP_NAME_alpha |
| VERSION_NUMBER   | 0.0.10                 |
+------------------+------------------------+
[14:30:46]: Could not find a build number for version 0.0.10
+------+-------------------------------+-------------+
|                  fastlane summary                  |
+------+-------------------------------+-------------+
| Step | Action                        | Time (in s) |
+------+-------------------------------+-------------+
| 1    | default_platform              | 0           |
| 2    | get_version_number            | 0           |
| 💥   | latest_testflight_build_numb  | 7           |
|      | er                            |             |
+------+-------------------------------+-------------+
[14:30:46]: fastlane finished with errors
[!] Could not find a build number for version 0.0.10

Environment

✅ fastlane environment ✅
Stack

Key
Value

OS
10.14.3

Ruby
2.3.7

Bundler?
true

Git
git version 2.20.1 (Apple Git-117)

Installation Source
/usr/local/bin/fastlane

Host
Mac OS X 10.14.3 (18D109)

Ruby Lib Dir
/System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/lib

OpenSSL Version
LibreSSL 2.6.4

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
10.2

System Locale

Variable
Value

LANG
en_GB.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:
`./fastlane/Fastfile`
# This file contains the fastlane.tools configuration
# You can find the documentation at https://docs.fastlane.tools
#
# For a list of all available actions, check out
#
#     https://docs.fastlane.tools/actions
#
# For a list of all available plugins, check out
#
#     https://docs.fastlane.tools/plugins/available-plugins
#

# Uncomment the line if you want fastlane to automatically update itself
# update_fastlane

default_platform(:ios)

before_all do
  ENV['DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS'] = ' '
end

platform :ios do
  desc "Build APP_NAME iOS Alpha"
  lane :build_APP_NAME_alpha do
    version = get_version_number
    latestBuildNumber = latest_testflight_build_number(version: version, app_identifier: "com.APP_NAME.alpha")
    increment_build_number(
      build_number: latestBuildNumber + 1
    )
    get_certificates
    get_provisioning_profile(
      app_identifier: "com.APP_NAME.alpha"
    )
    build_ios_app(
      workspace: "APP_NAME.xcworkspace",
      configuration: "Alpha",
      scheme: "APP_NAME"
    )
  end
end

`./fastlane/Appfile`
<EMAIL_ADDRESS>

fastlane gems

Gem
Version
Update-Status

fastlane
2.120.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.0.0

bundler
2.0.1

io-console
0.4.5

CFPropertyList
3.0.0

concurrent-ruby
1.1.4

i18n
0.9.5

minitest
5.8.5

thread_safe
0.3.6

tzinfo
1.2.5

activesupport
4.2.10

public_suffix
2.0.5

addressable
2.6.0

atomos
0.1.3

babosa
1.0.2

claide
1.0.2

fuzzy_match
2.0.4

nap
1.1.0

cocoapods-core
1.6.1

cocoapods-deintegrate
1.0.3

cocoapods-downloader
1.2.2

cocoapods-plugins
1.0.0

cocoapods-search
1.0.0

cocoapods-stats
1.1.0

netrc
0.11.0

cocoapods-trunk
1.3.1

cocoapods-try
1.1.0

colored2
3.1.2

escape
0.0.4

fourflusher
2.2.0

gh_inspector
1.1.3

molinillo
0.6.6

ruby-macho
1.4.0

nanaimo
0.2.6

xcodeproj
1.8.2

cocoapods
1.6.1

colored
1.2

highline
1.7.10

commander-fastlane
4.4.6

declarative
0.0.10

declarative-option
0.1.0

digest-crc
0.4.1

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20180417

dotenv
2.7.2

emoji_regex
1.0.1

excon
0.64.0

multipart-post
2.0.0

faraday
0.15.4

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

faraday_middleware
0.13.1

fastimage
2.1.5

jwt
2.1.0

memoist
0.16.0

multi_json
1.13.1

os
1.0.0

signet
0.11.0

googleauth
0.6.7

httpclient
2.8.3

mime-types-data
3.2019.0331

mime-types
3.2.2

uber
0.1.0

representable
3.0.4

retriable
3.1.2

google-api-client
0.23.9

google-cloud-env
1.0.5

google-cloud-core
1.3.0

google-cloud-storage
1.16.0

json
2.2.0

mini_magick
4.5.1

multi_xml
0.6.0

plist
3.5.0

rubyzip
1.2.2

security
0.1.3

naturally
2.2.0

simctl
1.6.5

slack-notifier
2.3.2

terminal-notifier
2.0.0

unicode-display_width
1.5.0

terminal-table
1.8.0

tty-screen
0.6.5

tty-cursor
0.6.1

tty-spinner
0.9.0

word_wrap
1.0.0

rouge
2.0.7

xcpretty
0.3.0

xcpretty-travis-formatter
1.0.0

generated on: 2019-04-16

Like @johandelouche mentioned above - the commit fails if no version exists.
https://github.com/fastlane/fastlane/commit/78fd2b1b5e5414251cd8c08c042f4af36d9ca70e#diff-2ef74c080ffebaba6bf980049c5663bdR43
So if you have a new version or no version, this fails here and doesn't return the initial build number as I believe it should

@janpio Is there anything else I can attach here to help push this forward? thank you for your hard work! :)

Not really, this is not my area at all so I was just helping to collect some information. The implementation will have to be done by someone else.

Ah I see, no problem. Thanks!

Apparently this was due to the Apple API and now it's working as expected on version 2.120.0. For me this isn't an actual fastlane issue.

Apparently this was due to the Apple API and now it's working as expected on version 2.120.0. For me this isn't an actual fastlane issue.

I don't believe thats true. Still getting the same error. The issue that was resolved that was due to Apple API change had to do with always returning a bad value (1? as a default due to failure I guess), no matter if the version we were looking for was existent in appstore connect or not. This issue though has to do with trying to upload a build for a new version number (one that isn't existent in appstore connect yet), which still results in "Could not find a build number for version", instead of defaulting to the "initial_build_number" parameter.
As a side note, I can see how the fix you mention (might have) caused the issue we are having here now.

This is part of my recipe
version = get_version_number
latestBuildNumber = latest_testflight_build_number(app_identifier:"xxx.xxx.xxx", version: version, initial_build_number: 0)
increment_build_number( build_number: latestBuildNumber + 1, xcodeproj: "xxx.xcodeproj" )

And here is the log
[12:03:56]: All required keys, certificates and provisioning profiles are installed 🙌
[12:03:57]: Setting Provisioning Profile type to 'app-store'
[12:03:57]: --------------------------------
[12:03:57]: --- Step: get_version_number ---
[12:03:57]: --------------------------------
[12:03:57]: --------------------------------------------
[12:03:57]: --- Step: latest_testflight_build_number ---
[12:03:57]: --------------------------------------------
[12:03:57]: Login to App Store Connect<EMAIL_ADDRESS>Available session is not valid any more. Continuing with normal login.
[12:04:00]: Login successful
[12:04:02]: Fetching the latest build number for version 4.9.37
[12:04:03]: Latest upload for version 4.9.37 is build: 2
[12:04:03]: ------------------------------------
[12:04:03]: --- Step: increment_build_number ---
[12:04:03]: ------------------------------------
Current version of project xxx is:
    2

/Users/xxx/Workspace/iOS/xxx
[12:04:05]: $ cd Users/xxx/Workspace/iOS/xxx && agvtool new-version -all 3 && cd -

And didn't get any errors this time

I do not know exactly where the error occurs, but version 2.120.0 is experiencing the same problem as not encountering the build version.
Returning to 2.119.0 worked perfectly.

@wolfasaeru I believe you are missing the point. You already have a version 4.9.37 in appstore connect (you are getting a response with latest build: 2). The title of the issue states "When I first increase the version number", meaning trying to upload a new version that isn't in appstore connect yet.
In your case, assuming 4.9.37 is your current latest uploaded version in appstore connect, try to upload a build via fastlane for version > 4.9.37 (4.9.38 for example).

@gitfrz You’re totally right. I wasn’t considering that

I'm on fastlane version 2.121.0 & still facing this issue!
My script has not been changed for months & was working perfectly fine.
This is the error log -
NFO [2019-04-23 18:10:18.45]: Login successful
WARN [2019-04-23 18:10:20.09]: Lane Context:
INFO [2019-04-23 18:10:20.09]: {:DEFAULT_PLATFORM=>:ios, :PLATFORM_NAME=>:ios, :LANE_NAME=>"ios bump_version", :PODSPEC_VERSION_NUMBER=>"4.5.1", :VERSION_NUMBER=>"4.5.1", :BUILD_NUMBER=>"20"}
ERROR [2019-04-23 18:10:20.09]: Could not find a build number for version 4.5.1
INFO [2019-04-23 18:10:20.09]: Successfully generated documentation at path '/Users/xxx/Documents/xxx/fastlane/README.md'

+------+--------------------------------+-------------+
|                  fastlane summary                   |
+------+--------------------------------+-------------+
| Step | Action                         | Time (in s) |
+------+--------------------------------+-------------+
| 1    | default_platform               | 0           |
| 2    | version_bump_podspec           | 0           |
| 3    | increment_version_number       | 0           |
| 4    | increment_build_number         | 1           |
| 5    | increment_version_number       | 1           |
| 💥   | latest_testflight_build_number | 4           |
+------+--------------------------------+-------------+

ERROR [2019-04-23 18:10:20.12]: fastlane finished with errors
bundler: failed to load command: fastlane (/usr/local/lib/ruby/gems/2.6.0/bin/fastlane)
FastlaneCore::Interface::FastlaneError: [!] Could not find a build number for version 4.5.1
  /usr/local/lib/ruby/gems/2.6.0/gems/fastlane-2.121.0/fastlane_core/lib/fastlane_core/ui/interface.rb:141:in `user_error!'
  /usr/local/lib/ruby/gems/2.6.0/gems/fastlane-2.121.0/fastlane_core/lib/fastlane_core/ui/ui.rb:17:in `method_missing'
  /usr/local/lib/ruby/gems/2.6.0/gems/fastlane-2.121.0/fastlane/lib/fastlane/actions/app_store_build_number.rb:45:in `get_build_number'
  /usr/local/lib/ruby/gems/2.6.0/gems/fastlane-2.121.0/fastlane/lib/fastlane/actions/app_store_build_number.rb:11:in `run'
  /usr/local/lib/ruby/gems/2.6.0/gems/fastlane-2.121.0/fastlane/lib/fastlane/actions/latest_testflight_build_number.rb:11:in `run'
  /usr/local/lib/ruby/gems/2.6.0/gems/fastlane-2.121.0/fastlane/lib/fastlane/runner.rb:256:in `block (2 levels) in execute_action'
  /usr/local/lib/ruby/gems/2.6.0/gems/fastlane-2.121.0/fastlane/lib/fastlane/actions/actions_helper.rb:50:in `execute_action'
  /usr/local/lib/ruby/gems/2.6.0/gems/fastlane-2.121.0/fastlane/lib/fastlane/runner.rb:235:in `block in execute_action'
  /usr/local/lib/ruby/gems/2.6.0/gems/fastlane-2.121.0/fastlane/lib/fastlane/runner.rb:227:in `chdir'
  /usr/local/lib/ruby/gems/2.6.0/gems/fastlane-2.121.0/fastlane/lib/fastlane/runner.rb:227:in `execute_action'
  /usr/local/lib/ruby/gems/2.6.0/gems/fastlane-2.121.0/fastlane/lib/fastlane/runner.rb:157:in `trigger_action_by_name'
  /usr/local/lib/ruby/gems/2.6.0/gems/fastlane-2.121.0/fastlane/lib/fastlane/fast_file.rb:154:in `method_missing'
  Fastfile:29:in `block (2 levels) in parsing_binding'
  /usr/local/lib/ruby/gems/2.6.0/gems/fastlane-2.121.0/fastlane/lib/fastlane/lane.rb:33:in `call'
  /usr/local/lib/ruby/gems/2.6.0/gems/fastlane-2.121.0/fastlane/lib/fastlane/runner.rb:49:in `block in execute'
  /usr/local/lib/ruby/gems/2.6.0/gems/fastlane-2.121.0/fastlane/lib/fastlane/runner.rb:45:in `chdir'
  /usr/local/lib/ruby/gems/2.6.0/gems/fastlane-2.121.0/fastlane/lib/fastlane/runner.rb:45:in `execute'
  /usr/local/lib/ruby/gems/2.6.0/gems/fastlane-2.121.0/fastlane/lib/fastlane/lane_manager.rb:56:in `cruise_lane'
  /usr/local/lib/ruby/gems/2.6.0/gems/fastlane-2.121.0/fastlane/lib/fastlane/command_line_handler.rb:36:in `handle'
  /usr/local/lib/ruby/gems/2.6.0/gems/fastlane-2.121.0/fastlane/lib/fastlane/commands_generator.rb:108:in `block (2 levels) in run'
  /usr/local/lib/ruby/gems/2.6.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:178:in `call'
  /usr/local/lib/ruby/gems/2.6.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:153:in `run'
  /usr/local/lib/ruby/gems/2.6.0/gems/commander-fastlane-4.4.6/lib/commander/runner.rb:476:in `run_active_command'
  /usr/local/lib/ruby/gems/2.6.0/gems/fastlane-2.121.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:76:in `run!'
  /usr/local/lib/ruby/gems/2.6.0/gems/commander-fastlane-4.4.6/lib/commander/delegates.rb:15:in `run!'
  /usr/local/lib/ruby/gems/2.6.0/gems/fastlane-2.121.0/fastlane/lib/fastlane/commands_generator.rb:333:in `run'
  /usr/local/lib/ruby/gems/2.6.0/gems/fastlane-2.121.0/fastlane/lib/fastlane/commands_generator.rb:41:in `start'
  /usr/local/lib/ruby/gems/2.6.0/gems/fastlane-2.121.0/fastlane/lib/fastlane/cli_tools_distributor.rb:119:in `take_off'
  /usr/local/lib/ruby/gems/2.6.0/gems/fastlane-2.121.0/bin/fastlane:23:in `<top (required)>'
  /usr/local/lib/ruby/gems/2.6.0/bin/fastlane:23:in `load'
  /usr/local/lib/ruby/gems/2.6.0/bin/fastlane:23:in `<top (required)>'

The issue specifically happens on Fastlane versions 2.120 & 2.121.0
Works fine on 2.119.0 😣

Just tried out version 2.121.1 and worked for a new version

Confirmed, 2.121.1 fixed the issue. Thanks @joshdholtz

Can you try 2.121.1 @ygit and report back if this is also solved for you? If so, I think we can consider this whole issue solved and close it.

Can confirm this works on version 2.121.1, thanks! 🎉

It's fixed thanks!

Thanks👍


Swarm mode- services are getting shut down and not recovered (restarted) if a network partition (between managers and a worker) occurs.

Description
Services are getting shut down and not recovered (restarted) if a network partition occurs.
Steps to reproduce the issue:

Build a swarm cluster of three managers
Add a swarm worker node to this cluster. We now have four machines on which the docker swarm is running. Three machines are running docker swarm manager and one is running worker.
Start a service on a worker node. If a network partition occurs for any reason, the service gets shut down. When the worker node becomes alive on the cluster again, the service is NOT getting started, it remains in shutdown state.

Describe the results you expected:
I would expect the service to get started again when the worker node joins the cluster again.
Note that I understand if a partition occurs among the swarm managers, shutting down services is okay but partition I'm talking about here is between the worker node and the rest of the cluster.

Are new tasks for the service being created on another node though?

@thaJeztah no, I only have one worker node. So if it loses any network connectivity with the swarm managers, everything on this node goes down and I then have to manually start the services. I would expect these services to get automatically started.
If it helps, I see following message on the swarm manger and after that the worker services are shutdown -
Apr  6 20:05:55 <redacted> dockerd: time="2017-04-06T20:05:55.836338457Z" level=warning msg="memberlist: Failed TCP fallback ping: read tcp <IP_ADDRESS>:33628-><IP_ADDRESS>:7946: i/o timeout"
Apr  6 20:05:55 <redacted> dockerd: time="2017-04-06T20:05:55.837922287Z" level=info msg="memberlist: Suspect <redacted>-05295c81b013 has failed, no acks received"

Ahm, ok, it wasn't clear from your description if the manager nodes also were used to carry load; by default, managers also act as workers, unless you out them in --availability=drain.
Swarm should keep trying to deploy tasks whenever a node becomes available (either a new node, or the existing node to re-attach).
ping @dongluochen any thoughts?

If you docker service ps <service name>, what does it show while the worker node is down?

@gauravphoenix Can you show docker node ls and docker service ps #service_id when the worker node is partitioned, and after the node recovers? Swarm doesn't shutdown a service. Service reconciliation depends on task status.

@thaJeztah,  when creating services, we use node constraints so that tasks are executed on specific nodes only. In our case, we don't use swarm manager to run any tasks.
docker service ps <service name> basically shows that the "desired state" is "shutdown" and the tasks are in shutdown state. I will post the exact message here when the services goes down next time.
@dongluochen  will do!

docker service inspect #service_id would be useful to understand the constraints and service status.

Here is the how the docker ps on the service looks like-
ID           	 NAME       			IMAGE                                            NODE                   DESIRED STATE  CURRENT STATE            ERROR                             PORTS
xyr3rj225moe  redacted.1     redacted:f78520ddda89  dev-aux-services-6pnj  Shutdown       Complete 18 minutes ago
f4nn3pila1ne   \_ redacted.1 redacted:f78520ddda89  dev-aux-services-6pnj  Shutdown       Shutdown 19 minutes ago
p3hcqfnhvyh1   \_ redacted.1 redacted:f78520ddda89  dev-aux-services-6pnj  Shutdown       Complete 21 minutes ago
ovhfav2zd3gi   \_ redacted.1 redacted:f78520ddda89  dev-aux-services-6pnj  Shutdown       Shutdown 21 minutes ago
aud5uovuvz78   \_ redacted.1 redacted:f78520ddda89  dev-aux-services-6pnj  Shutdown       Failed 23 minutes ago    "Cannot stop container redacted.1.a…"

as for docker service inspect, the JSON is -
[
    {
        "ID": "pgn0c3mqs6a0saoz9dwydo26s",
        "Version": {
            "Index": 12353
        },
        "CreatedAt": "2017-04-03T23:20:31.357497675Z",
        "UpdatedAt": "2017-04-07T01:58:09.375640366Z",
        "Spec": {
            "Name": "redacted",
            "TaskTemplate": {
                "ContainerSpec": {
                    "Image": "redacted",
                    "Args": [
                    ],
                    "Env": [

                    ],
                    "Mounts": [
                        {
                            "Type": "bind",
                            "Source": "/home/redacted/",
                            "Target": "/redacted"
                        }
                    ],
                    "StopGracePeriod":<PHONE_NUMBER>0,
                    "DNSConfig": {
                        "Nameservers": [
                            "redacted"
                        ]
                    }
                },
                "Resources": {
                    "Limits": {},
                    "Reservations": {}
                },
                "RestartPolicy": {
                    "Condition": "any",
                    "Delay":<PHONE_NUMBER>0,
                    "MaxAttempts": 5
                },
                "Placement": {
                    "Constraints": [
                        "node.labels.redactedrole == redacted"
                    ]
                },
                "ForceUpdate": 0
            },
            "Mode": {
                "Replicated": {
                    "Replicas": 1
                }
            },
            "UpdateConfig": {
                "Parallelism": 1,
                "FailureAction": "pause",
                "MaxFailureRatio": 0
            },
            "EndpointSpec": {
                "Mode": "vip"
            }
        },
        "PreviousSpec": {
            "Name": "redacted",
            "TaskTemplate": {
                "ContainerSpec": {
                    "Image": "redacted",
                    "Args": [

                    ],
                    "Env": [

                    ],
                    "Mounts": [
                        {
                            "Type": "bind",
                            "Source": "/home/redacted/",
                            "Target": "/redacted"
                        }
                    ],
                    "StopGracePeriod":<PHONE_NUMBER>0,
                    "DNSConfig": {
                        "Nameservers": [
                            "redacted"
                        ]
                    }
                },
                "Resources": {
                    "Limits": {},
                    "Reservations": {}
                },
                "RestartPolicy": {
                    "Condition": "any",
                    "Delay":<PHONE_NUMBER>0,
                    "MaxAttempts": 5
                },
                "Placement": {
                    "Constraints": [
                        "node.labels.redactedrole == redacted"
                    ]
                },
                "ForceUpdate": 0
            },
            "Mode": {
                "Replicated": {
                    "Replicas": 0
                }
            },
            "UpdateConfig": {
                "Parallelism": 1,
                "FailureAction": "pause",
                "MaxFailureRatio": 0
            },
            "EndpointSpec": {
                "Mode": "vip"
            }
        },
        "Endpoint": {
            "Spec": {}
        },
        "UpdateStatus": {
            "StartedAt": "0001-01-01T00:00:00Z",
            "CompletedAt": "0001-01-01T00:00:00Z"
        }
    }
]

Your service has set restart-max-attempts to 5. So there is no more retries after 5 attempts within restart-window (infinite in your case because it's not set). This option is used to stop excessive retries.
$ docker service create --help | grep -i restart
      --restart-condition string           Restart when condition is met ("none"|"on-failure"|"any")
      --restart-delay duration             Delay between restart attempts (ns|us|ms|s|m|h)
      --restart-max-attempts uint          Maximum number of restarts before giving up
      --restart-window duration            Window used to evaluate the restart policy (ns|us|ms|s|m|h)

                "RestartPolicy": {
                    "Condition": "any",
                    "Delay":<PHONE_NUMBER>0,
                    "MaxAttempts": 5
                },

But the problem is that I don't see any attempt to restart the service. When restart-window is infinite, does it mean that no restart attempts will be made?

Your service has 1 replica so orchestrator create one task redacted.1. When this task fails, it's restarted until MaxAttempts within the restart-window is reached. Here are the 5 attempts. If you want it to be always restarted, use the default MaxAttempts value 0.
ID           	 NAME       			IMAGE                                            NODE                   DESIRED STATE  CURRENT STATE            ERROR                             PORTS
xyr3rj225moe  redacted.1     redacted:f78520ddda89  dev-aux-services-6pnj  Shutdown       Complete 18 minutes ago
f4nn3pila1ne   \_ redacted.1 redacted:f78520ddda89  dev-aux-services-6pnj  Shutdown       Shutdown 19 minutes ago
p3hcqfnhvyh1   \_ redacted.1 redacted:f78520ddda89  dev-aux-services-6pnj  Shutdown       Complete 21 minutes ago
ovhfav2zd3gi   \_ redacted.1 redacted:f78520ddda89  dev-aux-services-6pnj  Shutdown       Shutdown 21 minutes ago
aud5uovuvz78   \_ redacted.1 redacted:f78520ddda89  dev-aux-services-6pnj  Shutdown       Failed 23 minutes ago    "Cannot stop container redacted.1.a…"

My guess to what happens is this

Worker fails
Manager checks service constraints
Determines that no node can meet constraints
As there's no node, no retries are done
Service marked as shutdown before the node comes back

I have set the maxattempts as 3, but there are already more than 3 retries.
As described on the API page,  there are three choices to set for the "Condition" item . If the  "Condition" is set as 'any' and turn off the machine while the service is running , after turning on the machine, will the service restart by iteself?
Or it is limited by the MaxAttempts item? Fox example, MaxAttempts is set as 3, and condition is set as 'any'. Before turn off the machine , the service has tried to restart for 3 times on failure. Then turn off the machine and reboot the machine, the service will not restart by itself for it has already achieved the max setting for MaxAttempts. How about  the service has tried to restart for 2 times（has one chance left） on failure beforen turning off the machine?
If MaxAttempts is set as 3 when create the service, after the service is updated for one time ,will the MaxAttempts be left as 2 (I mean only two chances left to try to restart )?

@sallyzhaohz To restart a task, swarmkit checks Condition, then checks MaxAttempts.

How about the service has tried to restart for 2 times（has one chance left） on failure beforen turning off the machine?

If there is still quota within restart-window, restart will be executed.

If MaxAttempts is set as 3 when create the service, after the service is updated for one time ,will the MaxAttempts be left as 2 (I mean only two chances left to try to restart )?

Normal update is not counted in MaxAttempts.


Secrets Provider (P2) - Research, Update and Removal of Deployment

A valid solution requires that the Secrets provider be decoupled from customer applications (AKA not sitting with each app in same pod).
As part of this research, we also need to evaluate the lifecycle for the solution, supporting the upgrade and removal of the secrets provider deployment.
Solution doc: https://ca-il-confluence.il.cyber-ark.com/pages/viewpage.action?pageId=319161469#/

Due to the volume of potential apps running on > 2000 clusters, my company is definitely interested in this.


Fixes

Navbar to base components
Remove formik & redux
Dates format
Fixed footer to non-fixed
Search field UI
Responsiveness (table cards)
Table pagination

Done on Dev Branch


⚠ Bofrost.lu has degraded performance

In 3831bf0, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 811 ms

Resolved: Bofrost.lu performance has improved in 14df7c5.


Add MT6816 magnetic sensor SPI driver

Hi,
I wrote an SPI driver recently for MagnTek's MT6816,  and an example code was put in this PR. They work well in my ESP32 test bench so far. Well, is there anybody interested in this driver? Or at least take a code review? Thanks

Thank you so much for this, this looks like great work!
Unfortunately I don't have a MT6816 sensor to try it, but if you've tested it on ESP32 then that's enough for the drivers repo, I think.
I will merge it and check for compilation on the different platforms, and get it ready for the next release of the drivers library. :-)
At the moment the dev branch of the drivers repo is waiting on the next release of SimpleFOC for some needed changes, so it could take a little time before it gets released.
Thank you so much for your contribution!


Array asssertion

closes #131 and #139
Add a holes assertion. But also serves as an example on how to create custom assertions to operate on specific objects. Hence I kept the code in a single example file, and didn't combine it with other files.
example usage;
local arr = { "one", "two", "three" }

assert.array(arr).has.no.holes()   -- checks the array to not contain holes --> passes
assert.array(arr).has.no.holes(4)  -- sets explicit length to 4 --> fails

local first_hole = assert.array(arr).has.holes(4)     -- check array of size 4 to contain holes --> passes
assert.equal(4, first_hole)        -- passes, as the index of the first hole is returned

:+1:


[MM-37314] Sync sidebar category update

Summary
After some research I was able to reproduce the autocategorization bug locally, but only when I'm trying to autocategorize 2 channels at once. That is if I start two playbook runs. There we have the race condition on an HA environment. When there are 2 concurrent calls of UserHasJoinedChannel:
GetSidebarCategories()
change_categories
UpdateSidebarCategories()

will not work, because what might happen is
GetSidebarCategories() //for the first channel on node1
GetSidebarCategories() //for the second channel on node2
change_categories //first channel is updated on node1
change_categories //second channel is updated on node2
UpdateSidebarCategories()//first channel info is saved to DB from node1
UpdateSidebarCategories()//second channel info is saved to DB from node2

Hence the data will be overwritten and first channel will not be autocategorized.
Solution here is to have the distributed lock.
P.S. I was not able to reproduce the same for the single channel. Server code seems to be Ok as well.
Ticket Link
Fixes: https://mattermost.atlassian.net/browse/MM-37314
Checklist

[ ] Telemetry updated
[ ] Gated by experimental feature flag
[x] Unit tests updated

Yes I thought about that, but there is no easy solution here.
If we stick to the “state” model where we get and update the entire state of the sidebar categories we will need a distributed lock shared between webapp, server and plugins. There is no way around it.
If we change to the event-based model where we send only changes to the server. For example: channel: X added to:categoryY or channel: X moved from: categoryY to: categoryZ we will still need to verify the order somehow. Order of the changes should be the same on every node. We can do that with CRDTs.
I don’t see an easy way of solving this general problem. These solutions seem overkill.
One ugly solution for this concrete problem we are having can be to wait until a new channel is categorized by the server. And only when we detect it in some category autocategorize it, hence making serial changes instead of concurrent ones.
Thoughts? @lieut-data @agarciamontoro


No app generated dates

Cleanup some SQL by letting postgres generate timestamps

We should carefully consider whether that matters.

For buffered outputs it would matter (the main issue for a more complex workflow I think)
For synchronous writes this would also ignore network delays


Restrict fog-core version

Newer versions of fog-core require xmlrpc, which requires Ruby >= 2.3 and our Chef version doesn't ship that new of a Ruby.

LGTM 👍


Rename UserProject to DashboardProject

A simple renaming to make DashboardProject match the other Dashboard display model Interface.

Can you do the renaming after #1966 to prevent merge conflict?

Can you do the renaming after #1966 to prevent merge conflict?

Sure.

LGTM. I noticed dashboard.project from types package has a different naming convention compared to other files in this package, like dashboard-file.interface.ts. We should unify the naming for these files, possibly in another PR.

It's an easy fix. I can fix it on this PR.


Hyperion.ng fails to start after OS update

[x] I confirm that this is an issue rather than a question. Yes it is an issue.

Bug report
My Hyperion install has refused to start after a recent raspbian os update.
Raspberry Pi3, Kernel: 5.10.17-v8+, Hyperion.ng: Hyperion-2.0.0-alpha.9-Linux-armv7l.deb, runnung as user: pi
I initially thought that maybe there was some file corruption, so removed the package "apt remove" and then reinstalled, but am still getting exactly the same issue. No indication of anything else running oddly, so I don't suspect the SD card.
Error messages: (from journalctl -f): -
hyperiond[2586]: Error : incorrect HTTP headers line : "umber%255Edirection%253Ds%25253AASC%5Efilters%3Do%253A\r\n"
hyperiond[2586]: Error : incorrect HTTP headers line : "s%25253AchannelNumber%255Edirection%253Ds%25253AASC%5Efilters%3Do%253A\r\n"
hyperiond[2586]: Error : incorrect HTTP headers line : "%255Edirection%253Ds%25253AASC%5Efilters%3Do%253A\r\n"
hyperiond[2586]: Error : incorrect HTTP headers line : "ction%253Ds%25253AASC%5Efilters%3Do%253A\r\n"
hyperiond[2586]: Error : incorrect HTTP headers line : "3Ds%25253AASC%5Efilters%3Do%253A\r\n"
hyperiond[2586]: Error : incorrect HTTP headers line : "AASC%5Efilters%3Do%253A\r\n"
hyperiond[2586]: Error : incorrect HTTP headers line : "er%255Edirection%253Ds%25253AASC%5Efilters%3Do%253A\r\n"
hyperiond[2586]: Error : incorrect HTTP headers line : "253Ds%2525253Agenre%25255Ewidth%25253Dn%2525253A250%5Esort%3Do%253Afield%253Ds%25253AchannelNumber%255Edirection%253Ds%25253AASC%5Efilters%3Do%253A\r\n"
hyperiond[2586]: Error : incorrect HTTP headers line : "Do%253A\r\n"
hyperiond[2586]: Error : incorrect HTTP headers line : "3A\r\n"
hyperiond[2586]: Error : incorrect HTTP headers line : "s%25253AchannelNumber%255Edirection%253Ds%25253AASC%5Efilters%3Do%253A\r\n"
hyperiond[2586]: Error : incorrect HTTP headers line : "253Ds%25253AASC%5Efilters%3Do%253A\r\n"
hyperiond[2586]: Error : incorrect HTTP headers line : "lNumber%255Edirection%253Ds%25253AASC%5Efilters%3Do%253A\r\n"
hyperiond[2586]: Error : incorrect HTTP headers line : "253Ds%2525253Agenre%25255Ewidth%25253Dn%2525253A250%5Esort%3Do%253Afield%253Ds%25253AchannelNumber%255Edirection%253Ds%25253AASC%5Efilters%3Do%253A\r\n"
hyperiond[2586]: Error : incorrect HTTP headers line : "rs%3Do%253A\r\n"
After the installation, the web interface doesn't load automatically when I navigate to the ip:port, I have to keep refreshing the page in the browser, which causes it to partially appear, but all greyed out. The constant refreshing also causes the above errors to appear in the logs.
Steps to reproduce
Have rebooted initially, no change
Then re-installed from a newly downloaded .deb package, again no change
What is expected?
Expected to get the full web interface
What is actually happening?
Errors as reported above and web interface eventually appears but completely greyed out, no buttons/menus are accessible.
System

Can't get this far, the web interface is not working correctly.

This can be closed as fixed. Removed local web browser cookies.


Mist/julia friendship kernel

This pull request implements the friendship kernel in Julia language. The algorithm is more memory-efficient than the one implemented in Python - these changes can be backported there if necessary...

closed in fawor of #38


Determine if any additional existing integration points with Galaxy should be implemented

Determine if any additional existing integration points with Galaxy should be implemented

There may be value in implementing the currently playing feature.

The other currently existing and documented endpoints have been reviewed and they don't appear to be useful for any near term updates but will be needed for trophies and friends.
https://galaxy-integrations-python-api.readthedocs.io/en/latest/galaxy.api.html#module-galaxy.api.plugin


feat: dtoss 4568 create hub pipeline

First cut of resources required to deploy the hub network.

Context

Type of changes

[ ] Refactoring (non-breaking change)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Bug fix (non-breaking change which fixes an issue)

Checklist

[x] I am familiar with the contributing guidelines
[x] I have followed the code style of the project
[ ] I have added tests to cover my changes
[ ] I have updated the documentation accordingly
[x] This PR is a result of pair or mob programming

Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

[x] I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Not yet ready for merge - still needs a change for GitHub.Network and needs the changes in a branch of the templates repo to be rebased and merged first, so the module reference commit IDs can be updated to main branch refs:

Updated pinned commit IDs for module dependencies.


[SPARK-15370][SQL] Fix count bug

What changes were proposed in this pull request?
This pull request fixes the COUNT bug in the RewriteCorrelatedScalarSubquery rule.
After this change, the rule tests the expression at the root of the correlated subquery to determine whether the expression returns NULL on empty input. If the expression does not return NULL, the rule generates additional logic in the Project operator above the rewritten subquery. This additional logic intercepts NULL values coming from the outer join and replaces them with the value that the subquery's expression would return on empty input.
This PR is a takes over https://github.com/apache/spark/pull/13155, and it only fixes an issue with Literal construction and some style.  All credits should go @frreiss.
How was this patch tested?
Added regression tests to cover all branches of the updated rule (see changes to SubquerySuite).
Ran all existing automated regression tests after merging with latest trunk.

Test build #60375 has started for PR 13629 at commit 30dd0bd.

Test build #60375 has finished for PR 13629 at commit 30dd0bd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60375/
Test PASSed.

Thanks - merging in master/2.0.


ChromeOS typing cursor is offset from text

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: VSCode for the web 1.77.3
OS Version: ChromeOS 111.0.5563.118 (Official Build) (64-bit)

Steps to Reproduce:

Randomly happens only on specific lines of code, and nowhere else
Same thing as issue 78058 (Making a new issue due to it being old and closed but not yet fixed)
This randomly occurs, but the cursor will be in the wrong position making it difficult to work
I have almost all defualt settings, and the only plugin I am using is a plugin pack (Still occurs when it is disabled)

Let's track in https://github.com/microsoft/vscode/issues/160702 . Please let me know if you know of any way to reproduce this in a VM.

Let's track in #160702 . Please let me know if you know of any way to reproduce this in a VM.

Ok, sorry I missed that other one, I am unsure on any methods to reproduce in a vm, but I can try testing it out. ATM it seems to only happen in normal ChromeOS on a Chromebook, but it may be able to be replicated elsewhere


Add interactive prop to Avatar component

Sometimes you need an Avatar inside a Button, for example when the Avatar is the trigger for a Context  dropdown. We need some kind of hover effect for the Avatar in these cases.

Implemented in v0.6.6


Create the dynamic extra node group

In version 2.6.1, we hard-coded the configuration for the extra node group.
However, the client now requests a dynamic variable to create new node groups. They wish to create two additional node groups. They will declare them as [nodegroupa, nodegroupb]. Based on this, we will iterate through the array to create two node groups in the Terraform configuration.

The feature is completed.


version bump to 0.5.4

@stephanielee9 this is ok to merge - the notebook change won't pass until we deploy


[FEATURE] Revert the Stalker changes

[Please do not close the request after a revision release is posted. Request will be closed by the developer when it is implemented to the base version or when it is flagged as not planned]
Feature
Just revert the stalker changes from before the current version.
Usage
I don't have to type a long essay to explain why giving radiance tier 2 to any sanded target is a terrible idea that hurts the experience of the mod as a whole.
Extras
P-2 P-rank went from actually fun to downright impossible. Many people have said this singular change was what ruined the mod as a whole for them

There actually is an error in the calculation of extra radiance. Problem is that it stacks with the stat editor. Will fix it to see if it is still too overpowered

There actually is an error in the calculation of extra radiance. Problem is that it stacks with the stat editor. Will fix it to see if it is still too overpowered

(quick reply, i know)
But don't you realize how radiance's original stats were also part of the problem? No matter how you look at it, alot of the people who play ultrapain play because forceradiance is too unfair of an environment. Even just one enemy with questionable radiance numbers turning radiant is enough to completely drain the fun from an encounter.
P-2 stalker room was designed with the intent that you'd have to deal with not being able to heal against a combination of difficult enemies, but that's made inconceivably harder once those enemies are made radiant despite what you desire.
And it's not just in the case of idoled stalkers. Stalkers throw sand in almost all cases where you want one to not explode near a difficult enemy. With how stalkers are intended to behave in ultrapain right now, it's almost impossible to prevent that type of enemy that'd pose a serious threat if radiant from turning radiant.
In essence, this is a radiance issue. I feel that stalkers didn't need a change to begin with, since their threat scales with the threat of the other enemies in the room.


Qt runs out Built target px4 NOT Built target px4fmu-v2_default

On my Ubuntu 14.04 LTS  Terminal
I type make px4fmu-v2_default and get Built target px4fmu-v2_default
then I use the following commands to get some files for Qt
cd ~/src/Firmware
mkdir ../Firmware-build
cd ../Firmware-build
cmake ../Firmware -G "CodeBlocks - Unix Makefiles"

Qt runs out [100%] Built target px4 but not Built target px4fmu-v2_default?
I check the CMakeLists.txt and change LINE 143 to set(CONFIG "nuttx_px4fmu-v2_default" CACHE STRING "desired configuration") but didn't work
Hope to talk with you soon.
 Next I'm going to solve the "rsync error" on Windows 7 , there are many people encounter  with the same problem

Glad to hear!


Extend test guidelines with implementation notes for unit/regression tests

I extended the test guidelines with information on how to write unit/regression tests. Furthermore, I added hints/links to other important information for tests authors, most importantly: the existing RFC keywords guide and the assumption about privileges.
Resolves: #185

I'm only wondering why we now have two documents, and how developers will know what document to read for which purpose. I have the feeling that they need to read both documents anyway in order to do meaningful work. Can they be merged in a reasonable way?

The other document specializes on the RFC keywords and without a complete restructuring I didn't see how I could fit my topics in there. For this reason, I decided to create a separate document. The new document can be seen as the more general entrypoint which a newcomer should read first.
I agree with you that this isn't obvious at the moment. One more thing which isn't obvious: the testing related contributor documents are currently placed below the "operations" hierarchy:
contributor-docs/
├── index.md
└── operations/
    ├── iam/
    │   ├── identity-federation-in-scs.md
    │   └── openstack-federation-via-oidc.md
    ├── operations/
    │   └── zuul-ci-cd-quickstart-user-guide.md
    └── tests/
        ├── rfc2119-keyword-test-guide.md
        └── test-implementation-guide.md

My suggestion: create a new "development" hierarchy and move "tests" there. Furthermore, solve the "which document to read first?" question by putting an index.md in there. So it will look like this:
contributor-docs/
├── development/
│   ├── index.md
│   └── tests/
│       ├── rfc2119-keyword-test-guide.md
│       └── test-implementation-guide.md
├── index.md
└── operations/
    ├── iam/
    │   ├── identity-federation-in-scs.md
    │   └── openstack-federation-via-oidc.md
    └── operations/
        └── zuul-ci-cd-quickstart-user-guide.md

@mbuechse what do you think about this proposal?

We (@cah-patrickthiem, @mbuechse and me) just had a discussion about the above proposal and it was agreed to proceed with it.


Fixed issue where lazy-import tags were being moved around just like eager import tags.

The code that moves around links into the hidden div was including lazy-import links because they are html imports.  That was bad and has been fixed.
[x] CHANGELOG.md has been updated

cc @stramel
This fixes #494


from_tiktoken_encoder creating over-sized chunks

Hi there
Thanks for creating such a useful library. It's a game-changer for working efficiently with LLMs!
I'm trying to get CharacterTextSplitter.from_tiktoken_encoder() to chunk large texts into chunks that are under the token limit for GPT-3.
The problem is that no matter what I set the chunk_size to, the chunks created are too large, and I get this error
INFO - error_code=None error_message="This model's maximum context length is 2049 tokens, however you requested 3361 tokens (2961 in your prompt; 400 for the completion). Please reduce your prompt; or completion length." error_param=None error_type=invalid_request_error message='OpenAI API error received' stream_error=False

Is there a magic incantation to get chunk sizes under the input limit?
Cheers

having the same issue ^
text_splitter = CharacterTextSplitter.from_tiktoken_encoder(chunk_size=100, chunk_overlap=0)
text = text_splitter.split_text(extract_text())

Actually was able to fix it. Seems like the library will only split the tokens around the separator which by default is \n\n. So if the separator is not present it will not split the text . You probably have to use a different separator. I am not sure if you can pass multiple separators into the function

@aparekh5 Yes, if you have a long paragraph of text that contains no line breaks, the chunking seems not to work.
Maybe we first need to run a sentence splitter on the input to chunk sentences into \n\n delimited sentences.

You can change the default separator:
text_splitter = CharacterTextSplitter.from_tiktoken_encoder(
    separator='.\n',
    encoding_name=encoder_name,  # tiktoken encoding name
    chunk_size=max_tokens,
    chunk_overlap=100  # let's add a small overlap
)
texts = text_splitter.split_text(text)

It will still not split if the separator doesn't exist however

@jamescalam thanks, this was the magic I was missing :)
I got the encoding_name from the mappings in tiktoken.model.MODEL_TO_ENCODING and I first run a sentence splitter on the input text so that the separator matches how the text is actually separated.
Works a treat - thanks again!

could it be possible to have the ability of passing an array of different separators ? rather than having to run the function multiple times

@aparekh5 this would be better, although I tested this and I think there may be another issue — on my own data I can write a function to split with a given separator and it works fine, however when using the langchain implementation it doesn't work, despite the separate being in the text that should be broken up
I'm not sure why this is yet, and it didn't seem to happen too frequently - however I did notice that there were more chunks that were longer than the limit that what was being printed by the text_splitter function


join lines has already been deprecated

https://github.com/wmaurer/vscode-join-lines
https://code.visualstudio.com/updates/v1_10

Thanks, I removed it.
Will review plugins according to VS Code changes.


Hardcoded version of escodegen-wallaby.

I found the problem. I upgraded the generator. That also installed the newest version of escodegen-wallaby (1.6.7). Support for ExportDeclaration has been dropped and replaced by more specific types. Unfortunately, esprima-fb still outputs ExportDeclaration, so updating the const and App files no longer works.
I fixed it by downgrading to<EMAIL_ADDRESS>

Merged into dev. Will be part of the next release.
Thank you for your contribution :+1:


-p doesn't seem to be a valid option on this page

azure storage blob upload -c <connectionstring> -p cacheControl="max-age=3600"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e745eb82-ea12-5135-31f8-7f5a88882560
Version Independent ID: 68496c81-5048-fb2b-645f-ead02aa2fbf6
Content: Manage expiration of Azure Blob storage - Azure Content Delivery Network
Content Source: articles/cdn/cdn-manage-expiration-of-blob-content.md
Service: azure-cdn
GitHub Login: @zhangmanling
Microsoft Alias: mazha

@justin-caldicott , Thanks for reaching out. We will investigate and update this thread.

@justin-caldicott , Appreciate your patience. Here, -p stands for --properties  the storage blob properties for uploaded file. Properties are key=value pairs and separated with semicolon(;). Available properties are contentType, contentEncoding, contentLanguage, cacheControl, contentDisposition, contentMD5.
This should work fine in this scenario while setting up the cache.
We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.


Add support for ~ substitution in path

(and probably other magic tokens as well?)

https://www.npmjs.com/package/expand-tilde


Ga 132 changes serialization issues in ga master

Before creating a pull request make sure that:

[ ] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[ ] tests have been updated / new tests has been added (if needed)
[ ] the keep-helm label has been added, if the helm release should be persisted after a successful build

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
Change description
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

The errors I have encountered whilst trying to load the UI initial page when logging in : GA-28 - GA-master ccd-data-store Testing.docx

Not required now


Adding yet another color because we need more than three

Don't actually need this it was just for deomonstrating git


add html_image myst extension

fixes #75

Now you can use standard HTML for images:
https://jupyterbook.org/content/figures.html#raw-html-images
Or "colon markdown" to display figure and create a ref and caption that rendered both in the website and in jupyterlab (although it's only partially formatted in jupyterlab)
https://jupyterbook.org/content/figures.html#markdown-figures


Server crashed when blowing up an IC Reactor Beside it...

https://pastebin.com/LeysUdGV
Hope this helps. Maybe the dog wold of not been near the reactor if they were chasing cats in armor ;)

Ah, looks like a sided method problem.  Sounds fun.
Thanks for the report!


Added JPEG XL

enable-libjxl, that is.

It's not that easy, also needs a build script for the library itself.
Will look at it when I got some time.

https://github.com/BtbN/FFmpeg-Builds/commit/71b37989a519080fb83dbe788089eb75dc30577a

Encoder does not work, only decoder and only on special type of files. This ffmpeg.exe works well: https://github.com/zhongfly/mpv-winbuild/releases/tag/2022-05-04
Maybe 638ca594d54c0f9eb16a8c236770418750e4cbec is bad?
It also talks about upstream fix: https://github.com/zhongfly/mpv-winbuild/commit/4ac31e4afc4f92264ff908e4c588b60b8b0d05f0

I bumped libjxl to the latest version.
I have zero experience with that format, so no idea how to work with it.

Nope, does not work.
Well. ffmpeg.exe -i 02-14817ce690189825ddc36fe847d7f436.png --distance 0 -effort 9 jxq5.jxl
for lossless image. I checked, it is lossless...

I just tried this in both Windows and Linux using gpl build "2022-05-07 12:40", using the command;
ffmpeg -i Test.png -distance 0 -effort 9 Test.jxl
and worked fine in both, could open the file with ImageGlass.

Are you checking with https://github.com/BtbN/FFmpeg-Builds/releases/download/latest/ffmpeg-master-latest-win64-gpl-shared.zip? That or not shared do not work. It is bad you cannot reproduce :(

You really should run this through gdb, to get a proper crash log.
It is crashing for me as well, with the following output:
[...]
Output #0, image2, to 'Test.jxl':
  Metadata:
    encoder         : Lavf59.23.100
  Stream #0:0: Video: jpegxl, rgba(pc, progressive), 374x763 [SAR 3779:3779 DAR 374:763], q=2-31, 200 kb/s, 25 fps, 25 tbn
    Metadata:
      encoder         : Lavc59.27.100 libjxl
--Type <RET> for more, q to quit, c to continue without paging--c

Thread 51 received signal SIGSEGV, Segmentation fault.
[Switching to Thread 15296.0x2de8]
0x00007ff77569964d in ffmpeg_g!JxlDecoderRewind ()
(gdb) bt
#0  0x00007ff77569964d in ffmpeg_g!JxlDecoderRewind ()
#1  0x00007ff77569a7b7 in ffmpeg_g!JxlDecoderRewind ()
#2  0x00007ff775535d28 in ffmpeg_g!JxlDecoderRewind ()
#3  0x00007ff7755375d5 in ffmpeg_g!JxlDecoderRewind ()
#4  0x00007ff77573c938 in ffmpeg_g!JxlDecoderRewind ()
#5  0x00007ff77573ca1a in ffmpeg_g!JxlDecoderRewind ()
#6  0x00007ff777a25b91 in ffmpeg_g!JxlDecoderRewind ()
#7  0x00007ff774162aa3 in ?? ()
#8  0x00007ffb3ea4e634 in msvcrt!_beginthreadex () from /c/WINDOWS/System32/msvcrt.dll
#9  0x00007ffb3ea4e70c in msvcrt!_endthreadex () from /c/WINDOWS/System32/msvcrt.dll
#10 0x00007ffb3f4e244d in KERNEL32!BaseThreadInitThunk () from /c/WINDOWS/System32/KERNEL32.DLL
#11 0x00007ffb404adf88 in ntdll!RtlUserThreadStart () from /c/WINDOWS/SYSTEM32/ntdll.dll

Though not sure what to do about it, since the crash is happening inside libjxl, so not really somewhere I got any control over.
When I find some time, I'll make a debug build and look at the trace again.

I just tried it again this time with;
https://github.com/BtbN/FFmpeg-Builds/releases/download/latest/ffmpeg-master-latest-win64-gpl-shared.zip
and it still works for me https://imgur.com/a/tBjsJxq

Did it produce a valid output file?
Windows likes to not display crashes for some reason, so try running it through gdb.

Though not sure what to do about it, since the crash is happening inside libjxl, so not really somewhere I got any control over.

You are wrong, since THE FFMPEG BUILD ABOVE from mpv people does work and does create a file. PLEASE test that. Please. Thank you.

Well, then enlighten me please.

I've uploaded the output file to pCloud
https://e1.pcloud.link/publink/show?code=kZg2lZOTHgGjIqTxbnlleTldtp0kr8LdvV

I'd be more interested in the input file, if you can share that.
Would be interesting to know if some specific combination of resolution/pixel format triggers the crash.

Added that too.

That also crashes for me, with the same commandline.
Still crashing in deep within libjxl, so not sure what I could do about it, other than hoping libjxl eventually fixes the crash.
Will know more once I managed to make a build with debug symbols in libjxl.

Wonder why it works for me.
Just tried ffmpeg-master-latest-linux64-gpl-shared.tar.xz "2022-05-07 12:40" in Arch Linux this time.

Possible that only the Windows builds are affected, and it works fine on Linux.
Does not at all make it easier to debug it.

In fact you right: linux build works perfectly. But yopu did not see https://imgur.com/a/W3xalNn that means windows works too, but no0t for me and you :(

Yeah, it being system specific is super odd for sure.

I will point out that ffplay.exe does crush too for normal jpeg xl samples, but not for algorithmic jpeg xl!!!
So it looks like decoding partially works.

In particular those samples work: https://jpegxl.info/art/2021-04_jon.html

@zhongfly Can you help us to fix jpeg xl versus your build? please?

@zhongfly Can you help us to fix jpeg xl versus your build? please?

I think you have the wrong person, I am using the build configuration provided by https://github.com/shinchiro/mpv-winbuild-cmake. When I say upstream fix, I actually mean this issue have been fixed( https://github.com/shinchiro/mpv-winbuild-cmake/issues/207 ) by https://github.com/shinchiro/mpv-winbuild-cmake/commit/c7775d3f4eb312067e5a694eb5ab0173aa35d783

Like, the only somewhat obvious thing that comes to my mind is that I disabled a bunch of dependencies of libjxl that were marked as optional.
They only seemed to be used for the included CLI tools, so I disabled them.
Does it in fact use them internally to decode parts of jxl images?

maybe this can help you https://github.com/shinchiro/mpv-winbuild-cmake/commit/765af62ed1ec9fe6d00706fa0c81c908ce48471b
It solves the problem that mpv will crash when generating screenshots in jxl format

Yes, it looks like it because small files like this can be very simply decoded, since AVX256 is not needed:

I've added those flags.
You can pull the updates builds from the build assets, or wait until tomorrows builds.
If that fixes it, this is an upstream issue and should be reported to them.

IT WORKS! Can be closed. I will report upstream though they do use the option throughout the issues.

Interesting. That seems like a severe issue (and might explain why it worked fine for some people). They should be aware.
Feel free to link to this issue, so stuff gets linked. And I can track when to remove the Workaround.

FWIW, we have received similar bug reports, only with Microsoft Visual Studio builds though, so I assume this is either a compiler bug in msvc or it's something else that somehow magically works in clang and gcc on all platforms but not in msvc... The bug could be in avx2 code generation, since sse3-only builds are not affected iirc.

These builds are not using MSVC, and it still crashes. Something in AVX2 seems likely though, given some users with more out of date machines aren't seeing any issues.

This seems to be sufficiently worked around for now, so closing here.


Remove “Building the documentation” docs from the plugin generator

DocumentJS is no longer included by default, so those docs shouldn’t be included.

Coverage remained the same at 97.989% when pulling f6033fc9d4eaf10bce5c63433080036e72d9c741 on remove-building-the-documentation into cc596d9c9ca76025f57f0154f89a7d940345b17a on master.


Google account

Create a Google account and subscribe:

Google collab pro.
Google Drive basic plan (100GB).

Completed, see wechat group for account detals


MSSql  precision is not added

When we are creating column with type numric(18,2)
it is generating the following and does not adding precision.
@Column("numeric",{
nullable:true,
scale:2,
name:"basic_price"
})
basic_price:number | null;
And typeorm is treating scale:2 as precision instead of scale.
but when we manually add precision then its working fine...
@Column("numeric",{
nullable:true,
precision:18,
scale:2,
name:"basic_price"
})
basic_price:number | null;

We are facing same issue with type decimal as well...

Fixed and released in<EMAIL_ADDRESS>


Assertion error trying to instantiate two "SmtEnumerator"s

The following program attempts to create two objects of the class SmtEnumerator:
#!/usr/bin/env python

import tyrell.spec as S
from tyrell.enumerator import SmtEnumerator
from tyrell.logger import get_logger

logger = get_logger('tyrell')
logger.setLevel('DEBUG')

spec_str = '''
enum SmallInt {
  "-1", "-2", "0", "1", "2"
}
value Int {
    is_positive: bool;
}
value Empty;

program Toy(Int, Int) -> Int;
func const: Int -> SmallInt;

func empty: Empty -> Empty;
'''

logger.info('Parsing Spec...')
spec = S.parse(spec_str)
logger.info('Parsing succeeded')

logger.info('Building synthesizer 1...')
SmtEnumerator(spec, depth=3, loc=2)

logger.info('Building synthesizer 2...')
SmtEnumerator(spec, depth=3, loc=2)

But fails with an assertion error:

(venv) bash-3.2$ python smt_bug_minimal.py
[info] Parsing Spec...
[debug] Building Tyrell spec from parse tree...
[debug] Processing type definitions...
[debug] Processing input/output definitions...
[debug] Processing function definitions...
[debug] Processing global predicates...
[info] Parsing succeeded
[info] Building synthesizer 1...
[info] Building synthesizer 2...
Traceback (most recent call last):
File "smt_bug_minimal.py", line 33, in
SmtEnumerator(spec, depth=3, loc=2)
File "/Users/rodamber/Projects/msc/code/current/tyrell/tyrell/enumerator/smt.py", line 240, in init
self.createFunctionConstraints(self.z3_solver)
File "/Users/rodamber/Projects/msc/code/current/tyrell/tyrell/enumerator/smt.py", line 94, in createFunctionConstraints
assert len(self.nodes) == len(self.variables_fun)
AssertionError

In Tyrell class variables/attributes are assigned outside of the init method. Therefore these attributes are shared among its instances.
I don't know if it's an intended feature or if it was simply a mistake due to python's diverging syntax.
Anyway, this "problem" is not exclusive to this class. A quick fix is to avoid using different enumerators in the same process.


Azure CP: Permissions are not effective while granted via Azure AD groups. Does work only in one WFE

We are using AzureCP in SharePoint Subscription Edition farm. Since Monday we are facing critical incident in our production farm. Only 1 out of 4 our WFE is able to properly allow users accessing sites while permissions are granted via Azure AD. For the traffic processed by other 3 servers users are getting "Site has not been share with you" error message. We've already verified OS settings, policies etc.
Is there any option that you can support us please?
Thank you in advance
BR
Szymon

(working on this issue through separate channels)
@SzymonCebula, based on the logs, augmentation (at sign-in time) fails because of https://github.com/Yvand/EntraCP/issues/240
Here is the callstack I found in your logs:
[AzureCP] Unexpected error occurred in AugmentEntity: System.ArgumentNullException: Value cannot be null., Callstack:
 at Microsoft.SharePoint.Utilities.SPUtility.GetProviderName(String fullName)
 at Microsoft.SharePoint.Administration.Claims.SPClaimEncodingManager.IsEncodedClaim(String value)
 at azurecp.OperationContext..ctor(IAzureCPConfiguration currentConfiguration, OperationType currentRequestType, List`1 processedClaimTypeConfigList, String input, SPClaim incomingEntity, Uri context, String[] entityTypes, String hierarchyNodeID, Int32 maxCount)
 at azurecp.AzureCP.AugmentEntity(Uri context, SPClaim entity, SPClaimProviderContext claimProviderContext, List`1 claims)

I fixed it in https://github.com/Yvand/EntraCP/pull/267, and it will be available in the next version, but I am not ready to publish it in the next few days, I will need a bit more time.
I will update this issue as I have more visibility on this

We appreciate you support. Could you please elaborate little bit "Fix an ArgumentNullException in a very rare scenario where ClaimsPrincipal.Identity is null" appearing in https://github.com/Yvand/EntraCP/pull/267.
Could you please advice what is the scenario when this "very rare scenario" occurs.

Sure, this is the scenario described in https://github.com/Yvand/EntraCP/issues/240
I suspect your scenario might be different, but with exactly the sane root cause

@Yvand I would like to clarify one detail. On non-working (3 out of 4 WFEs) servers only permission granted via Azure AD groups are not working. Permissions granted for users accounts are working properly in all 4 WFEs. I'm not sure whether that was clear based on my previous input thus I' would like to clarify that.

@SzymonCebula understood, it is consistent with ArgumentNullException I referenced above, because in your scemario (based on the log message I copied earlier), this exception happens during augmentation.

@SzymonCebula FYI I just published v26.0, which should fix your issue.
Please make sure to do the update as documented in https://entracp.yvand.net/docs/usage/update/


Handle errors fetching existing merge requests

Currently if someone sets up their token wrong, GitLab will respond with a 4XX error and _get_open_merge_requests will fall into an infinite loop until it triggers SSLError(OSError(24, 'Too many open files'))).
Handle the non-200 status code and print a helpful error message instead.
Also handles the case of having a non-string token set in .git/config.
I note this bucks the trend in this file of doing raise_for_status and allowing it to explode. But the current pattern contains a superfluous check of r.status_code before setting r.raise_for_status().

Nice catch!

I note this bucks the trend in this file of doing raise_for_status and allowing it to explode. But the current pattern contains a superfluous check of r.status_code before setting r.raise_for_status().

I should've removed the superfluous checks.


feat: load memory from network after login

Fixes issue #132: retrieve messages from memory after login success
Changes:

on login, load messages from memory

please review @dynamitechetan @chiragw15 @isuruAb @mayank408 @amitiwary999 @betterclever

Can I test it on appetizer?

The free time has been used from that account. I can add a GIF though.

@amitiwary999

Please resolve conflicts.

done!


Test issue

Thank you for reporting an issue! We truly appreciate your feedback. A
maintainer of the project has notified me that you're missing some information
we'll need to replicate this issue.
To receive the quickest help with your issue, please reply back on this issue
with a short, self-contained example that illustrates the bug you're seeing. If
you're not sure what that should include, more details are available here.

Thank you for reporting an issue! We truly appreciate your feedback. A
maintainer of the project has notified me that you're missing some information
we'll need to replicate this issue.
To receive the quickest help with your issue, please reply back on this issue
with a short, self-contained example that illustrates the bug you're seeing. If
you're not sure what that should include, more details are available here.

Thank you for reporting an issue! We truly appreciate your feedback. A
maintainer of the project has notified me that you're missing some information
we'll need to replicate this issue.
To receive the quickest help with your issue, please reply back on this issue
with a short, self-contained example that illustrates the bug you're seeing. If
you're not sure what that should include, more details are available here.


Grammatical consistency for weakmaps.md

Really enjoyed this blog post! Cleaned up a few things while reading through it. This cleans up some of the grammar and consistency for this post.
Highlights:

Consistent semicolons.
Consistent periods at ending of lists.
Consistent spacing in conditional statements.
Spaces in example code to simplify grokking.

This is fantastic, thank you so very much! Makes me look good lol :D


Allow detecting standalone jres inside other installation locations

Fixes #15094

@bot-gradle test QF

OK, I've already triggered QuickFeedback build for you.


Issue with k8s.io/docs/getting-started-guides/scratch/

This is a...

[ ] Feature Request
[x] Bug Report

Problem:
https://kubernetes.io/docs/getting-started-guides/scratch/ recommends "Set --configure-cbr0=false on kubelet and restart.".
The --configure-cbr0 was removed from kubelet in 1.9
Proposed Solution:
Update the documentation to match reality.
Page to Update:
https://kubernetes.io/docs/getting-started-guides/scratch/

@zegl This has since been handled by #7518 (thanks for the cc @islinwb - sorry for the delay, was recovering from car accident).
This issue can be closed.

/close


PR for sorting Example

@eugenp  @pkhanal  this branch has not conflicts now but has also pushed files not from my module. What do you suggest. Shall we close this pull request and start again ?


Pandas 0.19.0

import dask.bag as db
import dask.dataframe as dd
from dask.cache import Cache
import dask as da
import numpy as np
from dask.diagnostics import ProgressBar
from dask.dot import dot_graph
create this error -->  ImportError: cannot import name local
works well with pandas 0.18.1

Some of these issues are handled in https://github.com/dask/dask/pull/1540

Pandas 0.19.0 issues have been fixed by #1540. Closing.