Packaging for PyPi

Description of the feature request
Related to #29, it would be very nice if this were a lightweight package that were available to pip install.
Description of the solution you'd like
Proposed solution:

The core library could be shipped with just requests and tqdm as dependencies. This would mean removing dependence on the cohere and openai packages, and replacing their clients' get_request methods with requests HTTP calls, similar to ai21_client

The caches could either be included, or shipped separately (as manifest-caches or something) to avoid dependence on sqllitedict and redis, as well as allowing for additional backends

The API package could be released separately for those who want to use it (as I feel the most common production usecase by far will be using HTTP), this removes dependence on flask, torch, transformers, etc

I am happy to work on this if you think this is a good/useful architecture. Perhaps it's worth a fork of the library at that point since I'm sure a good amount of research code now depends on this package as-is.

https://github.com/jmilldotdev/manifesting/tree/refactor-for-pypi
i did a quick prototype of what that would look like here - it knocks the production dependencies down to just a handful.

Hey! I'm so sorry for the delayed response. I didn't realize this issue was here (I forgot to watch my own repository 🤦  - I just fixed it).
This has been on my road map, but you're ideas are better than mine.
I really like moving to all requests and adding a standard timeout argument for all models.
I've starting working on a PR for this (taking a lot from your prototype - THANK YOU!!!). Need a bit more time to better handle request statuses and error. I'll remove dependencies on any of the API packages. I'll leave in sqlite and redis for now. I'll also add run_id flag to run so that a user can specify the run_id - thereby allowing for multiple cached reruns and the ability for the user to retrieve that rerun (if the run_id is random - it can't be retrieved)
The one thing I need to figure out is how to do optional pip installs. So what I'd like is for a user to say pip install manifest[api] and then get the transformers etc. But otherwise, the only dependencies are requests, tqdm, sqlite, and redis.

manifest is on pip
pip install manifest-ml


Solved an Issue to edit Section1 men's page. Create men.html and edit explore now button

📝 Description
Please include a summary of the change and which issue is fixed.
🔧 Fixes #(issue)

📷 Provide related Screenshot/Gifs if any.

[ ] I have performed a self-review of my own code.
[ ] I'm a contributor in Hacktoberfest'21.

Please make sure to get assigned before working.


feat(sklearn): add recursive_strict parameter to patch()

Description of change

copilot:all

Pull-Request Checklist

[ ] Code is up-to-date with the main branch
[ ] This pull request follows Contributing.md
[ ] This pull request links relevant issues as Fixes #0000
[ ] pre-commit run -a passes with this change
[ ] poetry run pytest passes with this change
[ ] There are new or updated unit tests validating the change
[ ] Documentation has been updated to reflect this change
[ ] The new commits follow conventions outlined in the conventional commit spec

Codecov Report

Merging #86 (1eb5e22) into main (41f231c) will decrease coverage by 0.82%.
The diff coverage is 18.18%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
- Coverage   57.39%   56.57%   -0.82%
==========================================
  Files          10       10
  Lines         622      631       +9
  Branches       98      104       +6
==========================================
  Hits          357      357
- Misses        250      257       +7
- Partials       15       17       +2

Files
Coverage Δ

src/boost_loss/sklearn.py
58.09% <18.18%> (-5.45%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


bin: clean up argument support, rename binary file

This PR:

Remove the positional [owner] [repo] arguments, because that reminds me of the mess of net.connect()/server.listen() once again..we don't really have to support those, using the dash-prefixed arguments is pretty enough.
Rename the binary to get_metadata.js, which calls metadata.js that does the actual work, so we can reuse metadata.js later for other targets
Add an -f argument that specifies the file to write metadata in, this is also useful for future targets

Codecov Report

Merging #86 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   97.97%   97.96%   -0.01%
==========================================
  Files          13       13
  Lines         445      443       -2
==========================================
- Hits          436      434       -2
  Misses          9        9

Impacted Files
Coverage Δ

lib/args.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 174aa93...20deb53. Read the comment docs.

@apapirovski I've moved metadata.js to steps (the intention is to put files that interact with external system but does not necessarily are binaries here). PTAL.

Just linking things: this is part of https://github.com/joyeecheung/node-core-utils/issues/10


Create contribution.md as it is empty

Can you assign it to me?

Do you mean the CONTRIBUTING.md file?? to set guideline

Do you mean the CONTRIBUTING.md file?? to set guideline

If yes then assign it to me


Remaining program time sensor: wrong unit?

Hi,
Thank you for your work on this project; I am using it with great pleasure.
However, from my testing I've found that one of the sensors enabled by this integration interprets one value (BSH.Common.Option.RemainingProgramTime) as being a timestamp, while according to the API documentation it should be seen as an integer, or more specifically as a timespan. As far as I can tell, the line linked here is where it should be changed, should you agree to do so.
Implementing this change would also make this sensor function as expected, at least from my perspective.
Thanks!

Unfortunately there is no native support for timespan in HA so the options are to define this sensor as an int, a string or a timestamp. Out of these options I believe most people would find the timestamp most useful. If you wish to convert it back to seconds you can use a template like this:
{{ as_datetime(states("sensor.<you_appliance_ID>_bsh_common_option_remainingprogramtime"))-now() }}

Thanks for the quick response.
I understand your perspective about it being useful as a timestamp too. However, the API natively returns the number of seconds until the program is finished, therefore any timestamp that is formed from it will be off - which is how I noticed this issue in the first place.
Moreover, in my personal opinion, interpreting this variable as a timestamp also presents a bit of a incongruity with its name. When I see remaining program time, my mind thinks of a timespan, rather than a timestamp, which would be called something like ProgramCompletionTime or something.
As such, I changed line 31 of the .py as follows:
From:
"BSH.Common.Option.RemainingProgramTime": {"unit": None, "class": "timestamp" },
To:
"BSH.Common.Option.RemainingProgramTime": { "unit": None, "class": f"{DOMAIN}__timespan"},
To be more in line with the other timespan values in the CONF_ENTITY_SETTINGS block. However, of course this totally up to you to implement or not.

In the UI the timestamp class is actually displayed as a timespan, so it will show something like: "In 2 hours", which is consistent with the name of the sensor.
The HA UI is rounding the time to full hours for values greater than 45 minutes, but the sensor itself is accurate to the second. You can verify that using the template.
Changing the behavior now would be a breaking changing for existing automatons that rely on this sensor.

If you want to override the default class definition you can do that using entity_settings in your configuration.yaml file. Check the README for more information.
I suggest that you open this as a discussion topic and try to get some feedback from other users. If this suggested change gets a wide enough support I'll change it.

I would support a better format, if possible. Right now I've come up with this monstrosity to display the estimated finishing time also when delayed start is active:
{{ as_timestamp(now() + timedelta(seconds=as_timestamp(states('sensor.01311xxx_bsh_common_option_remainingprogramtime'))-as_timestamp(states.sensor['01311xxx_bsh_common_option_remainingprogramtime'].last_changed)) + as_timedelta('0 '+states('sensor.01311xxx_bsh_common_option_startinrelative')+':00'))|timestamp_custom('%H:%M',now()) }}

I hope I am addressing my concerns correctly at this point.
Using this integration, my new NEFF S157ZBX01D dishwasher shows a remaining program running time of 4 hours when switched off. Only when I switch on the device and start a program is the correct remaining program running time displayed.
Am I doing something wrong? Can someone help me?

Thanks for the quick response.
I understand your perspective about it being useful as a timestamp too. However, the API natively returns the number of seconds until the program is finished, therefore any timestamp that is formed from it will be off - which is how I noticed this issue in the first place. Moreover, in my personal opinion, interpreting this variable as a timestamp also presents a bit of a incongruity with its name. When I see remaining program time, my mind thinks of a timespan, rather than a timestamp, which would be called something like ProgramCompletionTime or something.
As such, I changed line 31 of the .py as follows:
From: "BSH.Common.Option.RemainingProgramTime": {"unit": None, "class": "timestamp" },
To: "BSH.Common.Option.RemainingProgramTime": { "unit": None, "class": f"{DOMAIN}__timespan"},
To be in line with the other timespan values in the CONF_ENTITY_SETTINGS block. However, of course this totally up to you to implement or not.

I changed it too and actually find the 00:00 display better than the timestamp. This means I no longer need the sensor I created myself, which converts the previous display into HH:MM.
Thank you @TjallingO

There is no reason to change source files, see my note above:

If you want to override the default class definition you can do that using entity_settings in your configuration.yaml file. Check the README for more information.

I'm going to close this issue now since I don't expect new developments here. As also noted above, if you want this changed by default please open a discussion about it and get some other people to vote for for or against that change.


Building of the PIP package (as described in docs) is broken

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 18.04
TensorFlow installed from (source or binary): source
TensorFlow version: 2.3.0
Python version: 3.7.6
Installed using virtualenv? pip? conda?: neither
Bazel version (if compiling from source): 2.0.0
GCC/Compiler version (if compiling from source): 7.5.0
CUDA/cuDNN version: 10.2.89/7.6.5
GPU model and memory: GeForce RTX 2080 Ti

Describe the problem
The documentation says that in order to build the PIP package from source you have to:
./bazel-bin/tensorflow/tools/pip_package/build_pip_package --nightly_flag /tmp/tensorflow_pkg
This doesn't work, since there is no more bazel-bin in the TF source tree, and running the same command with bazel-tensorlflow instead of bazel-bin doesn't work either.
Provide the exact sequence of commands / steps that you executed before running into the problem
./bazel-bin/tensorflow/tools/pip_package/build_pip_package --nightly_flag /tmp/tensorflow_pkg

bazel-bin should be created as a symlink after successful run of bazel build //tensorflow/tools/pip_package:build_pip_package.

@mihaimaruseac Got it, thanks!


ENH: STAC compliance

It could be nice to make eoreader compliant with STAC item format, by:

[ ] Changing the attributes names (i.e. extent to bbox)
[ ] Changing band names
[ ] Add informations to the bands (centrale wavelength, bandwidthn gsd, ...)
[ ] Creating a to_stac() function for every product

Add ESA resolution category (VHR1/2, HR1/2, OTHER)

Use this changes to create a band object overloading bands and index (no more wild functions/enum)

Create namedtuples for STAC extensions:
- prod.proj for proj extension with projected data (i.e. call the projected bbox like prod.proj.bbox)
- prod.view for view extension
- prod.cloud_cover for cloud cover from the  eo extension
- enrich the band_names attribute (change name to bands) with everything here

In the band object, add the output radiometric processing aimed, either reflectance or brilliance temperature.

Rather than changing all the function names, it would be better to have a stac object as an attribute implementing all needed functions, i.e.:
# BBOX / extent
eoreader_bbox = prod.extent()
stac_bbox_wgs84 = prod.stac.bbox()
stac_bbpx_utm = prod.stac.proj.bbox()

# Export
stac_item = prod.stac.create_item()

PR merged


Compilation errors when enabling XTENSOR_USE_XSIMD

Hi.
I have a program that I wrote with xtensor., on microsoft visual studio.
compilation_log.txt
everything work great (but a little bit slow) when XTENSOR_USE_XSIMD is disable, but when I enabling XTENSOR_USE_XSIMD I got hundreds of compilation errors.
Please help.
attached the compilation log.

The master branch of xsimd contains breaking changes, please use version 7.5.0 instead.

@sagyHarpaz Is this issue still relevant?

No update from OP and this is more of an xtensor issue than an xsimd issue, closing.


session data gets modified before saving

mongo store added two new fields (sid and ttl) to the session data (in set(sid, sess, ttl))
Issue found by user yuu2lee4:

from: yuu2lee4
and i found a strange thing,  i seted session.user, then i console it, the object has no 'sid' and 'ttl' , but after i setted session.pin ,  it has 'sid' and 'ttl'

thanks @longztian! fixed in https://github.com/pavelvlasov/koa-generic-session-mongo/commit/355eaa24ed3eec62aee4d21ec1e92ed3fba2ee5c


ARROW-2068: [Python] Expose array's buffers

This recurses into child data if present (for nested types).

AppVeyor build at https://ci.appveyor.com/project/pitrou/arrow/build/1.0.88


Regression introduced in e90b17e

Hi and thank you for your plugin!
I've noticed today that my neovim would frequently freeze when navigating within files. Pressing jjjjjjjjj would make it hang for up to 10 seconds. I was able to narrow down the problem to this plugin. Interestingly enough if I roll it back to before e90b17e it completely fixes the problem.
This problem is easier to reproduce with a really large file with a lot of comments. Here is a good example vscode/index.d.ts.

Redraws are now throttled. This should fix your issue. Would be great if you can confirm. Thanks!

Thanks for the prompt response. I've just checked and it no longer hangs. Thank you!


Tree item_selected event firing twice

Operating system or device:
Issue description (what happened, and what was expected):
When connecting item_selected to a function it fires that function twice
Steps to reproduce:
Connect tree to function, it will fire twice
Link to minimal example project (optional but very welcome):

The description is a bit short. How do you connect the three to the function? Via the editor, or via a script? If it's via a script, please give the code snippet. If it's via the editor, do you bind parameters or just bind item_selected to a function without anything specific?
When does it fire twice? When you connect the tree to the function? Or when you actually trigger the signal in game?

I bind item selected to a function in the editor, when I go in-game and I click an item in the list the function is called twice.

This seems to not happen anymore.

@EIREXE did you check with Godot 3.0?

@volzhs yes


mrp support py37

Description
Remove features from MRP that do not support py37
Fixes #1058
Type of change
Please check the options that are relevant.

[x] Bug fix (non-breaking change that fixes an issue)
[ ] Proposes a change (non-breaking change that isn't necessarily a bug)
[ ] Refactor
[ ] New feature (non-breaking change that adds a new functionality)
[ ] Breaking change (fix or feature that would break some existing functionality downstream)
[ ] This is a unit test
[ ] Documentation only change
[ ] Datasets Release
[ ] Models Release

Type of requested review

[ ] I want a thorough review of the implementation.
[x] I want a high level review.
[ ] I want a deep design review.

Before and After
Previously, MRP only worked in environments with py38+
The minimum requirement has been reduced to py37+
Testing
Created a conda env with py37. Confirmed mrp fails without these changes. Rebuilt with these changes. Ran through all examples.
Checklist:

[x] I have performed manual end-to-end testing of the feature in my environment.
[ ] I have added Docstrings and comments to the code.
[ ] I have made changes to existing documentation where needed.
[ ] I have added tests that show that the PR is functional.
[ ] New and existing unit tests pass locally with my changes.
[ ] I have added relevant collaborators to review the PR before merge.
[ ] [Polymetis only] I ran on hardware (1) all scripts in tests/scripts, (2) asv benchmarks.

Codecov Report

Merging #1072 (388ff07) into main (9e50a3a) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1072      +/-   ##
==========================================
- Coverage   33.98%   33.93%   -0.06%
==========================================
  Files         344      343       -1
  Lines       33685    33430     -255
==========================================
- Hits        11448    11343     -105
+ Misses      22237    22087     -150

Impacted Files
Coverage Δ

agents/droidlet_agent.py

interpreter/craftassist/tasks.py
75.00% <0.00%> (+0.54%)
:arrow_up:


Fix file ownership after sudo make install

I am following the readme and stumble upon this problem. When doing sudo make install, it will generate vendor/ which is own by root (drwxr-xr-x  4 root   root     44 Jun 22 16:23 vendor).
Then, when we run make rpm for generating Hare RPMs, we will get this error:
make[1]: Entering directory `/mnt/extra/hare'
ln: cannot remove ‘current’: Permission denied
make[1]: *** [unpack-dhall-bin] Error 1
make[1]: Leaving directory `/mnt/extra/hare'
make: *** [rpm] Error 2

Therefore, the simple fix is to apply chown to the hare/.

View rendered README.md

Not sure that this is worth documenting.
Normally, when the user runs something under sudo, it is expected that the files would be owned by the root user.

Can one of the admins verify this patch?

@knekrasov , totally agree with you. However, my goal is to test that the Readme works without any errors. The thing is the error doesn't really tell you which dir caused the permission error, and anyone could easily waste 5 minutes to find the solution.
There is another solution to this, which is to use sudo when running make rpm. Either way, I believe we still need to update the Readme.

Just to be clear, the readme tells us to use sudo when running make install. So, the Readme should also be accountable for causing the problem, thus it should provide a solution. Thanks.

@gatekeepers, please review & merge the PR

@suvratjoshi, @knekrasov, please review & merge the PR

@Gatekeepers, please approve & merge the PR

Hi @knekrasov , @mssawant , @suvratjoshi; Could you merge this PR? Thanks

Hi @daniarherikurniawan
Can you please squash commits in a single and have the appropriate commit message for the same?
Thank you!

Hi @suvratjoshi! Sure, I will close this and create another PR

Hi @suvratjoshi ,
I am not sure what do you mean by "squash". I can't do that unless I make a new PR. Therefore, I have made a new PR here https://github.com/Seagate/cortx-hare/pull/1717, but it doesn't seem to be reviewed by the team. Please advise. Thanks :)

Hi Mandar @mssawant , could you please merge this. Thanks!

@mssawant @suvratjoshi  do we need this any more with latest dev environment? I am closing this right now, in  case required we can reopen


Introduce thread safety to SAML schema validation

Per the references below, use of Dir.chdir is not thread-safe. This usage was causing exceptions to be raised when running on Puma and in other multi-threaded environments.
This patch also moves the schema read up to a class instance, as this data is static and does not need to be read every time an assertion is validated. This boosts performance, especially in environments with higher throughput.
Thanks to @dannyb for the assistance!
References:

https://www.ruby-forum.com/topic/165079
https://bugs.ruby-lang.org/issues/9785
http://www.justskins.com/forums/working-directory-in-thread-42304.html
http://www.ruby-doc.org/core-2.1.5/Dir.html#method-c-chdir

Wouldn't it make sense to not even change the directory and read the file relative to __FILE__? i.e.
@schema ||= begin
  path = File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'schemas', 'saml-schema-protocol-2.0.xsd'))
  Nokogiri::XML::Schema(IO.read(path))
end

@cgthornt the chdir is required due to a known issue with Nokogiri and schema validation.
References:

http://ktulu.com.ar/blog/2011/06/26/resolving-validation-errors-using-nokogiri-and-schemas/
https://stackoverflow.com/questions/11996326/nokogirixmlschema-syntaxerror-on-schema-load
https://github.com/dougalcorn/nokogiri-chdir-schema-validate-bug

@phlipper any chance you can rebase off master and throw a test around the new method you introduced? self.schema
We updated the test suite to use Minitest and I just want to ensure its all passing  still before we merge.
Thank you for this improvement!

@Lordnibbler i have rebased on top of the latest master and tests are green.

I'm :+1: on this but would love a simple unit test around this new self.schema method

@Lordnibbler what would you like to see for test coverage? I'm happy to add some, but there are no existing tests for the SamlMessage class at the moment. The subclasses are tested and passing so I felt confident in the change.

@phlipper We will make a followup issue to test the SamlMessage class (unless you want to throw some tests around the class too).

@cgthornt @pitbulk can you guys review?

Changes Unknown when pulling ea8e552d293d23681617a42adc0c4ec99d0be288 on phlipper:thread-safety into ** on onelogin:master**.


fix: update asset code with localized contenthashes

Figured I might as well fix it while I'm on the clock!
fix #40

:tada: This PR is included in version 1.4.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Consultations - Change States

As a Ministry User
I want to update the states of my consultation
so that I can better track where the request is at from my queue

Assumptions & Scope
What are the assumptions for this story?
Only Ministry Coordinators can update the state on consultations
There will be less states in a consult vs a traditional FOI Requests
State changes should not be included in FOI Request Analytics
Ministry coordinators can change states as needed, there is no enforcement of when states can change.
What is IN scope?
What is NOT in scope?
Acceptance Criteria
Scenario 1: Change State from Open - State Options

GIVEN a Ministry Coordinator is on an Open Consultation
WHEN they activate the state drop down
THEN they will see the following options: Harms Assessment; Records Review; Ministry Sign-Off; Response and Closed

Scenario 2: Change State

GIVEN a Ministry coordinator has activated the state drop down
WHEN they select a state
THEN the state of the consultation will be updated to the selected state
AND the State options for the drop down will be the same as in AC 1, except for the state the request is already in

Scenario 3: Close Consultation

GIVEN a Ministry Coordinator has activated the state drop down
WHEN they select "Closed" from the dropdown menu
THEN a modal will open up showing the "Close Consult" window, showing the following information: Public Body, Request ID, Request Description  Closing Date of Consult. Reason for Closing Consult, Save and Cancel button.
AND Public Body, Request ID, and Request description will be autofilled (if no data, display n/a)
AND the save function will not be active

Scenario 4 Cancel Back to Prior State:

GIVEN the Ministry Coordinator has opened the close request modal
WHEN I click the cancel button
THEN the modal will close, and that state of the request will remain as it was before selecting the close state

Scenario 5: Calendar picker for Closing date:

GIVEN the Ministry Coordinator has opened the close request modal
WHEN the Closing Date calendar picker has been selected
THEN a calendar picker will appear to select a date
AND when a date is selected, it will appear as the value for the close date

Scenario 6: Closing Date Cannot be in the Future

GIVEN the Ministry Coordinator has opened the close request modal,
WHEN they have activated the calendar picker for Close Date
THEN the analyst will be unavailable to pick a date in the future

Scenario 7: Reason for Closing Request

Given the Ministry Coordinator has opened the close request modal
WHEN the "Reason for Close" drop down is selected
THEN the following options will be available to select: Access Denied, Full Disclosure, Partial Disclosure, Withdrawn

Scenario 8: Reason for Closing Request

Given the Ministry Coordinator has opened the close request modal
WHEN the "reason for close" drop down is selected
AND an option is selected
THEN the option will be displayed in the field

Scenario 9: Save Change button becomes Active

GIVEN the Ministry Coordinator has opened the close request modal
WHEN the mandatory fields have any value filled in: Closing date, Reason for Closing Request, Number of Pages Release, and Number of pages reviewed
THEN the Save Change button will become active

Scenario 10: Clicking Save Change button

GIVEN the Ministry Coordinator has opened the close request modal
WHEN all mandatory fields are filled in
AND the save change button is clicked
THEN the modal will close
AND state of the request will be update to "Closed"
AND colour of the left navigation tab will turn to black
AND the request will be removed from all assigned queues
AND the request details will be Read Only

Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)
Validation Rules? (If yes, list here)
Design
@xxx - please link the Design here
Definition of Ready

[ ] Is there a well articulated User Story?
[ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
[ ] If there is a user interface, is there a design?
[ ] Does the user story need user research/validation?
[ ] Does this User Story needs stakeholder approval?
[ ] Design / Solution accepted by Product Owner
[ ] Is this user story small enough to be completed in a Sprint? Should it be split?
[ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
[ ] Has the story been estimated?

Definition of Done

[ ] Passes developer unit tests
[ ] Passes peer code review
[ ] If there's a user interface, passes UX assurance
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Confirm Test cases built and succeeding
[ ] No regression test failures
[ ] Test coverage acceptable by Product Owner
[ ] Ticket ready to be merged to master or story branch
[ ] Developer to list Config changes/ Update documents and designs
[ ] Can be demoed in Sprint Review
[ ] Tagged as part of a Release
[ ] Feature flagged if required
[ ] Change Management activities done?

State Change for Consults Story
Will likely need some designs for this one @JHarrietha-AOT
Thought here is to track a consultation from the lifecycle of a request. Because this will be Ministry driven I am not including any validation or rules (ie: can go from Open to Sign-off, if they wish).
Copied the AC from closing a request to address that piece of the consult.
Please review when you have time @arielleandrews @lmullane @mpilchar


Add ability to add directories to MigrationStorage

This PR adds the ability to add directories to MigrationStorage.
Using the addDirectory function, we can add additional directories for MigrationStorage.
This way we can define a function to register additional directories in the ServiceProvider (like loadMigrationsFrom to register database migrations).
For example:
/**
 * Register elastic migration directories.
 *
 * @param  array|string  $directories
 * @return void
 */
protected function loadElasticMigrationsFrom($directories)
{
    $this->callAfterResolving(\ElasticMigrations\Filesystem\MigrationStorage::class, function ($migrationStorage) use ($directories) {
        foreach ((array) $directories as $directory) {
            $migrationStorage->addDirectory($directory);
        }
    });
}

Hey, sorry but I don't see any real benefits of having migrations in multiple directories. This makes code slower (many additional loops) and less readable. Maybe you can create your implementation of MigrationStorage and register it in the application service provider?


Ensure order is qualified by table name for rss feeds

BEFORE:
SELECT "vms"."id" [...] ORDER BY created_on DESC

This is problematic because if we later join another table to this
scope and execute the query, if that table has a created_on field
Postgres will complain and throw an error for the ambiguous statement.
AFTER:
SELECT "vms"."id" [...] ORDER BY "vms"."created_on" DESC

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1451180
Note: I tried to bisect but had great difficulty (because you need to check out all the git gems to be concurrent with the revision you're checking out in core), but since this seemed to be a good idea anyway (and works), I was satisfied.
@miq-bot add-label bug, core
@miq-bot assign @gtanzillo

@miq-bot add-label blocker

Fine backport details:
$ git log -1
commit a4bf78fc24c566cc3f2834cbc0d5ac5c84cacdac
Author: Gregg Tanzillo<EMAIL_ADDRESS>Date:   Wed May 17 14:50:23 2017 -0400

    Merge pull request #15112 from imtayadeway/fix/rss-feeds

    Ensure order is qualified by table name for rss feeds
    (cherry picked from commit 0974ffc67358219e47e27f08976c85eccf6a3986)

    https://bugzilla.redhat.com/show_bug.cgi?id=1451925


Document releases in this Github repository

It appears that this repository is the main repo for wireit. Please document releases or at least tag the releases so changes can be referenced between versions via releases-tab. This is more or less automatic if you "just" tag releases.

They're documented in the CHANGELOG file: https://github.com/google/wireit/blob/main/CHANGELOG.md

Yes, the term "document" was probably wrong. What I meant is running git tag v0.0.1 and git tag v0.0.2 so that Github can do its magic and list all changes between these versions. This will also add an entry in the notifications on updates. Having to manually going to CHANGELOG.md works currently.

Sure, I added vx.x.x tags to all the release so far, and will do so going forward.


Please Can I Join This Organisation? 🥺🙏"

Name:
Your name here..
.Mars Bryant
Why do you want to join this organization?
Explain here...
want join your team.
Pull request with your contribution
Replace this with a link to the pull-request with your contributions.
If you have not created a pull-request yet, please follow these instructions first.

Our Website 🌐 | Repositories 📚 | LinkFree Profile 🔗
You have received an email to join, or press this link - https://github.com/App-Choreography - , and you'll see a banner, for you to join the organisation! 🎉
You can also show that you are part of this org, by making yourself public. This will show our profile org on your profile:
Follow This:

After you join the organisation, search your name in the list of people. 🔍
Follow this below: ⬇

When you join our org, you will be automatically be part of our community team, where you will get updates, and news about our org!
We are so happy you have joined!  Here is a few things you can do in this org:

App-Choreo's Community team chat = Here you see the latest updates, can share your ideas and collaborate!
GitHub Profile League = submit your GitHub profile readme, to be in the chance of winning! 2 entries left to fill!
Hacktoberfest Practice = practice your Hacktoberfest.
Best App Tutorials = see the latest app tutorials you can either add or take a look at.
Fix our Readme = Here you can polish your code debugging/review and GitHub skills.
Best GitHub Open Source = See the best GitHub opensource repos!

For any help or support, feel free to ask.
Thank you.


Manual drive control

[x] get test motors responding to controller input
[ ] Operate the real drive train with controller input

[ ] test option


Update docs to latest

Regenerates the docs

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4147/
Test FAILed.

alluxio-bot, merge this please.

alluxio-bot, cherry-pick this to branch-2.0 please.


feat: Create Profiles block

Description
This PR creates a new block called profiles, which displays a header followed by a quote, followed by an image and other text content. The block can handle one to multiple profiles, and the image and text content can be displayed in variable order.
Related Issue
ADB-46
Motivation and Context
The main use-case for this block will be for an upcoming page.
How Has This Been Tested?
Tested on preview site: https://sbx-image-with-copy--design-website--adobe.hlx.page/drafts/dev/profiles-draft
Types of changes

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] All new and existing tests passed.

Pivoting work to #326 after design feedback.


Fix typo in Releases.md

Thank you for sending the PR! We appreciate you spending the time to work on these changes.
Help us understand your motivation by explaining why you decided to make this change.
If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
Test Plan:
Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!
Release Notes:
Help reviewers and the release process by writing your own release notes. See below for an example.
[DOCS] [MINOR] [Releases.md] - Fix typo in Releases.md

@facebook-github-bot shipit


Example in README throws error on useDragDropContext

I'm trying to run the example code in the README.
import {
  DragDropProvider,
  DragDropSensors,
  useDragDropContext,
  createDraggable,
  createDroppable,
} from "@thisbeyond/solid-dnd";
import { render } from 'solid-js/web'

const Draggable = (props) => {
  const draggable = createDraggable(props.id);
  return
draggable
;
};

const Droppable = (props) => {
  const droppable = createDroppable(props.id);
  return
droppable
;
};

const Sandbox = () => {
  const [, { onDragEnd }] = useDragDropContext();

  onDragEnd(({draggable, droppable}) => {
    if (droppable) {
      // Handle the drop. Note that solid-dnd doesn't move a draggable into a
      // droppable on drop. It leaves it up to you how you want to handle the
      // drop.
    }
  });

  return (

      <Draggable id="draggable-1" />
      <Droppable id="droppable-1" />

  );
};

const App = () => {
  return (
    <DragDropProvider>
      <DragDropSensors>
        <Sandbox />
      </DragDropSensors>
    </DragDropProvider>
  );
};

let appRoot = document.getElementById("app")! as HTMLDivElement;
render(() => <App/>, appRoot);

I'm getting the following error on Chrome:
Uncaught TypeError: useDragDropContext is not a function or its return value is not iterable
    at createPointerSensor (create-pointer-sensor.js?v=65bad4a2:4:108)
    at DragDropSensors (drag-drop-sensors.jsx:3:5)
    at dev.js:516:12
    at untrack (dev.js:421:12)
    at Object.fn (dev.js:512:37)
    at runComputation (dev.js:694:22)
    at updateComputation (dev.js:677:3)
    at devComponent (dev.js:523:3)
    at createComponent (dev.js:1225:10)
    at get children [as children] (main.tsx:111:22)

and on Firefox:
Uncaught TypeError: (intermediate value)() is null
    createPointerSensor create-pointer-sensor.js:4
    DragDropSensors drag-drop-sensors.jsx:3
    c dev.js:516
    untrack dev.js:421
    c dev.js:512
    runComputation dev.js:694
    updateComputation dev.js:677
    devComponent dev.js:523
    createComponent dev.js:1225
    get children main.tsx:111
    get dev.js:1290
    get children drag-drop-context.jsx:503
    res dev.js:969
    runComputation dev.js:694
    updateComputation dev.js:677
    createMemo dev.js:238
    children dev.js:577
    res dev.js:969
    untrack dev.js:421
    provider dev.js:965
    runComputation dev.js:694
    updateComputation dev.js:677
    createRenderEffect dev.js:205
    provider dev.js:965
    c dev.js:516
    untrack dev.js:421
    c dev.js:512
    runComputation dev.js:694
    updateComputation dev.js:677
    devComponent dev.js:523
    createComponent dev.js:1225
    DragDropProvider drag-drop-context.jsx:503
    c dev.js:516
    untrack dev.js:421
    c dev.js:512
    runComputation dev.js:694
    updateComputation dev.js:677
    devComponent dev.js:523
    createComponent dev.js:1225
    _Hot$$App main.tsx:110
    hmrCompWrapper @solid-refresh:10
    untrack dev.js:421
    hmrCompWrapper @solid-refresh:10
    runComputation dev.js:694
    updateComputation dev.js:677
    createMemo dev.js:238
    hmrCompWrapper @solid-refresh:7
    c dev.js:516
    untrack dev.js:421
    c dev.js:512
    runComputation dev.js:694
    updateComputation dev.js:677
    devComponent dev.js:523
    createComponent dev.js:1225
    _cleanup main.tsx:121
    render dev.js:93
    updateFn dev.js:168
    runUpdates dev.js:786
    createRoot dev.js:176
    render dev.js:91
    <anonymous> main.tsx:121

I had the same problem with Vite version 3.2.4 and npm run dev.
To fix was to change the Vite version to 3.0.0.
I checked and found that drag-drop-context.jsx was called twice.
It seems that the DragDropProvider executed in the first module initialization is tied to the first Context.
However, in the second module initialization, useDragDropContext is called after Context is initialized, but before DragDropProvider is called, so useContext() is undefined as a result. It seems that useContext() is undefined as a result.
I'm thinking that perhaps esbuild or rollup in Vite is affecting this.
The same problem does not occur in bundles created with npm run build.
The package versions involved at the time of the check are as follows

@thisbeyond/solid-dnd: 0.7.3
solid-js: 1.6.2
vite: 3.2.4
vite-plugin-solid: 2.4.0

This is a vite<>solid issue. However, it should have been resolved at this point with those versions.
You may need to update your vite config perhaps? See https://github.com/thisbeyond/solid-dnd/issues/53#issuecomment-1272076800 for details.

I had this same issue as well, and the suggestion in https://github.com/thisbeyond/solid-dnd/issues/53#issuecomment-1272076800 did solve the problem for me.
Adding the following to my vite.config.js file was needed:
optimizeDeps: {
  extensions: ["jsx"],
},

I created my SolidJS project a few versions back when the SolidJS new project wizard didn't include this setting automatically.


Option under the [Hook Legendary] checkbox to use either Precision or Powerful Hookset

Drop down option under the [Hook Legendary] checkbox to use either Precision or Powerful Hookset
Not sure which hookset this option does by default. I assume powerful, but several legendary bites use the precision hookset.

Could you link me some examples? Most if not all the !!! i checked always used powerful.

There are a significant number of them. Just with a cursory glance I would say at least 20% of the ' !!! ' tugs are for precision hookset. Here are a few.
https://ffxivteamcraft.com/db/en/item/7902/Cupfish
https://ffxivteamcraft.com/db/en/item/7681/Caterwauler
https://ffxivteamcraft.com/db/en/item/7933/Charon's-Lantern
https://ffxivteamcraft.com/db/en/item/7682/Crystal-Perch
https://ffxivteamcraft.com/db/en/item/28929/Black-Jet
https://ffxivteamcraft.com/db/en/item/16751/Hraesvelgr's-Tear
https://ffxivteamcraft.com/db/en/item/17589/Opabinia
https://ffxivteamcraft.com/db/en/item/15634/The-Soul-of-the-Martyr
https://ffxivteamcraft.com/db/en/item/24213/Princess-Killifish
https://ffxivteamcraft.com/db/en/item/33318/Steel-Razor
https://ffxivteamcraft.com/db/en/item/16753/Hundred-eyed-Axolotl
https://ffxivteamcraft.com/db/en/item/24995/The-Unconditional
https://ffxivteamcraft.com/db/en/item/33242/Ealad-Skaan
https://ffxivteamcraft.com/db/en/item/33241/Cinder-Surprise
https://ffxivteamcraft.com/db/en/item/33316/Aster-Trivi
https://ffxivteamcraft.com/db/en/item/16749/Moggle-Mogpom
https://ffxivteamcraft.com/db/en/item/30438/The-Mother-of-All-Pancakes
https://ffxivteamcraft.com/db/en/item/33322/Celestial
https://ffxivteamcraft.com/db/en/item/33319/Shadeshifter
https://ffxivteamcraft.com/db/en/item/32049/Moonlight-Guppy
https://ffxivteamcraft.com/db/en/item/32052/Sunken-Tome
Can also just go through https://ff14fish.carbuncleplushy.com/ and look at the right hand side how many of the ' !!! ' have the green precision hookset icon.

Already fair enough, ill see what I can do.

Hopefully it's not complicated or difficult to implement. I was even thinking there could still just be Powerful as default and then a checkbox for "Precision Hookset Override" since Powerful Hookset is more common. I don't know if that would be easier or however you want to do it. Regardless, it's a very helpful add-on, so thanks for creating it!

I've added some new options to select your hookset when using Patience, I hope it can be useful/work as intended.


Allow for 64 Bytes serials

On Nucleo boards the serial gets truncated. This allows for longer serials.

Thanks, for which nucleo board this was an issue? This makes the changelog a little bit more clear!

Thanks, for which nucleo board this was an issue? This makes the changelog a little bit more clear!

Nucleo-L476RG

Thanks!


Variational Inference for Dirichlet Process Gaussian Mixture

This also has some helper classes for diagnostics, I could separate into a differnet pull requets if that will make it easier to go over the diff.
The main thing that this diff accomplishes is that now we can infer an infinite mixture of Gaussians when doing density estimation. It's slow, but it's a good start.

@pbailis can we change the coverage check to be slightly more tolerable?

can we change the coverage check to be slightly more tolerable?

What do you mean?

Coverage decrease is not phenomenal... :)

LGTM, with a few concerns to address beforehand:

Not sure why so many of the log entries need to be at info.
Would be good to discuss how to dump the scores. @edgan8 had some thoughts.
If Travis is failing spuriously, can we use smaller datasets for the tests?

can we change the coverage check to be slightly more tolerable?

What do you mean?

Make coverage check not fail if coverage decreased by less than say 0.1% :)

If Travis is failing spuriously, can we use smaller datasets for the tests?

Travis does not fail any longer after I introduced a limit on number of iterations tests run

Not sure why so many of the log entries need to be at info.

Changed info's into debugs

Would be good to discuss how to dump the scores. @edgan8 had some thoughts.

I reverted src/main/java/macrobase/analysis/transform/BatchScoreFeatureTransform.java, I though I had done that before too. I'll talk to @edgan8 about his ideas.

Make coverage check not fail if coverage decreased by less than say 0.1% :)

1000 * 0.1% = 100%!


Middleware Initial code

@sainak

@AnkurPrabhu Can you update the Description with details of the Test Server and Asset/Location/Facility Setup in our Care Instance connected to the Test Server


ConnectionError when downloading deep_weeds dataset

I'm unable to use the deep_weeds dataset from TensorFlow Datasets. Seems like this has happened in the past #44053
import tensorflow as tf
import tensorflow_datasets as tfds

data, info = tfds.load(name='deep_weeds')

Results in ConnectionError
See gist here

@jvishnuvardhan I was able to replicate the issue on colab using TF v2.8.0 and tf-nightly ,please find the gist here for reference.Thanks!

@Conchylicultor Can you please take a look at this issue? Thanks!

I think we can close this now. It has been fixed in tfds-nightly, see gist.

Thanks @nikitamaia


[UX] should config values related to the VM (disk-size, cpu, memory) be reflective of actual state of the VM?

The usual way to find out the disk-size, cpu, memory of the CRC instance is to look at their respective config values, but these values only. give information about the desired config and not the actual config in the VM. crc status command shows the actual information but only when the instance is running.
/cc @gbraad

Both values are useful to know, so we need a way to get both. Imo it's good that config reflects what the user requested. If we also want the actual config of the VM to be in crc config, I'd add a --live, --actual flag for this. Imo it's fine to have this in crc status.  I don't think actual cpu/memory will make a lot of sense when the VM is not running/will be possible to know, so this leaves only disk size?

the api should be able to return requested and actual, so in that case the UI can decide what to show around this; actual is the most important as this is the truth...


Support for bundled realm files with initialRealmFile

This PR adds support for initializing a realm file with a prebundled realm.
val config = RealmConfiguration.Builder(....)
    .initialRealmFile("asset.realm", "d4cdef5d8da2b2e2ae692f2e2fead4ef8deeaccb8e4cf0790c2a2ae0dbaabbc4")
    .build()

There is currently no common convention for distributing asset and resource files across Kotlin Multiplatform project, so this PR requires the developer to place the assetFile according to the target platform conventions. The asset files are located through:

Android: Located through android.content.res.AssetManager.open(assetFilename)

<sourceset>/assets

JVM: Class.javaClass.classLoader.getResource(assetFilename)

<sourceset>/resources

Darwin: NSBundle.mainBundle.pathForResource(assetFilenameBase, assetFilenameExtension)

Add framework files to the main bundle through Xcode

Closes #577

Looking good. I only have a few minor comments about naming and then we need to add a few tests for Sync as well.

I have added a complete round trip test with PBS to ensure that we are consistent on the order of:

initialRealmFile
initialData, and
initial download of remote data

It is quite tricky to get right for flexible sync in a repeatable manner, so left that out as the internals for realm initialization is actually not different. Thoughts?


Docker aspnet.core 2004 image doesn't start on scale set with Window server 2004 OS

Service Fabric Runtime Version:
Environment: Azure
Description:
My team created a containerized application that is using the following image: mcr.microsoft.com/dotnet/core/aspnet:3.1-nanoserver-2004. We recently updated our Azure service fabric clusters to Windows servers with the SKU datacenter-core-2004-with-containers-smalldisk on the scale set so to run the application inside a container.
Observed behavior:

After deploying the SF application to the cluster, the application doesn't start and creates an error log event entry:

'System.Hosting' reported Error for property 'CodePackageActivation:Code:EntryPoint:132399740953317313'.
There was an error during CodePackage activation.System.Fabric.FabricException (-2147017731)
Failed to start Container. ContainerName=sf-5-7e313cf0-de1b-4715-9616-b364592c89d5_0ae51ac5-8690-4fe9-963b-6c6d4714dde3, ApplicationId=SampleAppType_App5, ApplicationName=fabric:/SampleApp. DockerRequest returned StatusCode=InternalServerError with ResponseBody={"message":"hcsshim::CreateComputeSystem 620bdba93c111aff29398d9d54baa3c8f62e3b1f70f0b2a146937bbc6ed2a175: The container operating system does not match the host operating system.\n(extra i

If we run the same image locally and execute the ver command on an interactive prompt, this is the result:

C:\app>ver
Microsoft Windows [Version 10.0.19041.388]

If we RDP into the SF nodes and execute the ver command, this is the result:

C:\Users>ver
Microsoft Windows [Version 10.0.19041.388]

While RDP into the SF node, if we try to run the docker image manually, this is the error reported:

docker: Error response from daemon: hcsshim::CreateComputeSystem a1c0c42d72ae3ccaafd46d2f5808ae50df59462e60bf11627bfbec4733fdc8f5: The container operating system does not match the host operating system.
(extra info: {"SystemType":"Container","Name":"a1c0c42d72ae3ccaafd46d2f5808ae50df59462e60bf11627bfbec4733fdc8f5","Owner":"docker","VolumePath":"\\\\?\\Volume{464c23d8-1873-40c5-9afb-0fc9e30a8a03}","IgnoreFlushesDuringBoot":true,"LayerFolderPath":"C:\\ProgramData\\docker\\windowsfilter\\a1c0c42d72ae3ccaafd46d2f5808ae50df59462e60bf11627bfbec4733fdc8f5","Layers":[{"ID":"377a81b1-b3fa-5e9d-a408-8ed971df2768","Path":"C:\\ProgramData\\docker\\windowsfilter\\8b02ea6a9a569040a2e2db67381bb7b886985526dffc59ac30c9e0d145b950f1"},{"ID":"b2dc43b1-8f1f-5204-99d3-dbf3587abae9","Path":"C:\\ProgramData\\docker\\windowsfilter\\33166140655da2729899d1d115cf7df5e14162f1ae27135f73c6491a7773d78c"},{"ID":"b86db10f-21e8-5d9f-8310-393139095cc3","Path":"C:\\ProgramData\\docker\\windowsfilter\\8c62735a6da708dc55a577f2ae2459b5e3c860f982d9ba450e1c1e34ff3707a7"},{"ID":"f17b978e-430f-53f6-999b-a8e8e3cd2da6","Path":"C:\\ProgramData\\docker\\windowsfilter\\708f91e6edb84aae8fe62a62b00b87d946ec8d35f6dc18b849fb3b288f8a590f"},{"ID":"4d269c2d-28dc-585c-bc8a-42bf1b4abbbc","Path":"C:\\ProgramData\\docker\\windowsfilter\\6c88cb2874b815551f0ce52c7d6fc04e9e86fda8b61a159fdfb4d21eae9d0853"},{"ID":"8d337e8e-dab1-53dd-b344-ddbd03994089","Path":"C:\\ProgramData\\docker\\windowsfilter\\0b7c7ab98220ebea894a3939d5971144bd7ea797eb4f8da7597c27998bd21a71"},{"ID":"423ba5fc-855a-5b86-90d9-3071ddf4ec72","Path":"C:\\ProgramData\\docker\\windowsfilter\\ef96b43e64bb9c5e1f37630e79537978bdab3128dc5af4dc038e98d682ca1880"},{"ID":"884b57ee-33be-5838-991b-2e0b0fb3cac7","Path":"C:\\ProgramData\\docker\\windowsfilter\\d58da0fce7965660334de5f1c41bb1be80c3f289abae5ed5b7d92d07a5f3dcda"},{"ID":"2aae91ab-2f37-5be5-b28a-0537d25d86f1","Path":"C:\\ProgramData\\docker\\windowsfilter\\ff7563ce41fc9f11bb46bb48d4aab8d0a5621b837a22099d8f7bdb33a5ed93d2"},{"ID":"7901ad4a-2ac4-5729-b067-f2dae455eac7","Path":"C:\\ProgramData\\docker\\windowsfilter\\0246b4420fa4b53d17b20167f49ddf48da930fbf72549f028f70d8230cf88bde"},{"ID":"8ff06661-72a8-5484-8891-781a4143db0f","Path":"C:\\ProgramData\\docker\\windowsfilter\\6604e639e6bdb8edb9bb409492cf3217f4ee08608f2a0c11f7d981b69e583ad9"},{"ID":"d0b4b6a9-a544-5586-a94b-aac3e37fac82","Path":"C:\\ProgramData\\docker\\windowsfilter\\10ad8963a83dd55daaffccd1619ec190a98f65309fca79a3f31753c1393ab21b"},{"ID":"41e04f6b-0e05-549c-a50d-94484a939bef","Path":"C:\\ProgramData\\docker\\windowsfilter\\4357ef5b44f83c5309558f6bb80a18b9faf380691d226d2ca56ee5ed76da5a6f"},{"ID":"45b8ee71-c3fa-5cbd-b3ec-0e37e02eaf28","Path":"C:\\ProgramData\\docker\\windowsfilter\\a685d3d9b9e42eb44602e35f9b6f5f822aaee0d92fd7c693fcba54b15cb5d3da"},{"ID":"680985ef-bf51-510d-ac30-98259479fcc1","Path":"C:\\ProgramData\\docker\\windowsfilter\\2f1823b1470c99a5c34be16c589c837affa613ad8853f8926984d91c3d1a2ed0"},{"ID":"1e73da6a-be54-53dd-afca-e0db84bf306f","Path":"C:\\ProgramData\\docker\\windowsfilter\\0fd5e003a143ca23a0a477446c09bd934c69da37318ab1832ce2eeea1dc5e1b4"},{"ID":"f457eec7-70a4-59b7-9379-babcafc98433","Path":"C:\\ProgramData\\docker\\windowsfilter\\2787257291de883c602b108c5f23a8f07b1950f78042d245934ab5550cf6a4ec"},{"ID":"87eb11f4-4ef6-563e-b46f-6b0b02450fb9","Path":"C:\\ProgramData\\docker\\windowsfilter\\5e8429b9bd6d0e8897d340231e31f93de9c74a8df5294636cfd4070e8f6e448d"},{"ID":"24921fd7-7c5b-5867-bca1-d0acbd662988","Path":"C:\\ProgramData\\docker\\windowsfilter\\f62d81a556f9cdfe2e00690b076a33a9c03f979b4f837bc55127ce50ea6a6c92"}],"HostName":"a1c0c42d72ae","HvPartition":false,"EndpointList":["0813da77-386c-446a-aee7-c39c277c3401"],"AllowUnqualifiedDNSQuery":true}).

Still at RDP on the node, if we try to run the container with hyper-v isolation:

docker: Error response from daemon: hcsshim::CreateComputeSystem 130a2bcf04aeb1b2719f28eebaa9981870fe72a091151c97b6121d7e4f304e4e: The virtual machine could not be started because a required feature is not installed.
(extra info: {"SystemType":"Container","Name":"130a2bcf04aeb1b2719f28eebaa9981870fe72a091151c97b6121d7e4f304e4e","Owner":"docker","IgnoreFlushesDuringBoot":true,"LayerFolderPath":"C:\\ProgramData\\docker\\windowsfilter\\130a2bcf04aeb1b2719f28eebaa9981870fe72a091151c97b6121d7e4f304e4e","Layers":[{"ID":"377a81b1-b3fa-5e9d-a408-8ed971df2768","Path":"C:\\ProgramData\\docker\\windowsfilter\\8b02ea6a9a569040a2e2db67381bb7b886985526dffc59ac30c9e0d145b950f1"},{"ID":"b2dc43b1-8f1f-5204-99d3-dbf3587abae9","Path":"C:\\ProgramData\\docker\\windowsfilter\\33166140655da2729899d1d115cf7df5e14162f1ae27135f73c6491a7773d78c"},{"ID":"b86db10f-21e8-5d9f-8310-393139095cc3","Path":"C:\\ProgramData\\docker\\windowsfilter\\8c62735a6da708dc55a577f2ae2459b5e3c860f982d9ba450e1c1e34ff3707a7"},{"ID":"f17b978e-430f-53f6-999b-a8e8e3cd2da6","Path":"C:\\ProgramData\\docker\\windowsfilter\\708f91e6edb84aae8fe62a62b00b87d946ec8d35f6dc18b849fb3b288f8a590f"},{"ID":"4d269c2d-28dc-585c-bc8a-42bf1b4abbbc","Path":"C:\\ProgramData\\docker\\windowsfilter\\6c88cb2874b815551f0ce52c7d6fc04e9e86fda8b61a159fdfb4d21eae9d0853"},{"ID":"8d337e8e-dab1-53dd-b344-ddbd03994089","Path":"C:\\ProgramData\\docker\\windowsfilter\\0b7c7ab98220ebea894a3939d5971144bd7ea797eb4f8da7597c27998bd21a71"},{"ID":"423ba5fc-855a-5b86-90d9-3071ddf4ec72","Path":"C:\\ProgramData\\docker\\windowsfilter\\ef96b43e64bb9c5e1f37630e79537978bdab3128dc5af4dc038e98d682ca1880"},{"ID":"884b57ee-33be-5838-991b-2e0b0fb3cac7","Path":"C:\\ProgramData\\docker\\windowsfilter\\d58da0fce7965660334de5f1c41bb1be80c3f289abae5ed5b7d92d07a5f3dcda"},{"ID":"2aae91ab-2f37-5be5-b28a-0537d25d86f1","Path":"C:\\ProgramData\\docker\\windowsfilter\\ff7563ce41fc9f11bb46bb48d4aab8d0a5621b837a22099d8f7bdb33a5ed93d2"},{"ID":"7901ad4a-2ac4-5729-b067-f2dae455eac7","Path":"C:\\ProgramData\\docker\\windowsfilter\\0246b4420fa4b53d17b20167f49ddf48da930fbf72549f028f70d8230cf88bde"},{"ID":"8ff06661-72a8-5484-8891-781a4143db0f","Path":"C:\\ProgramData\\docker\\windowsfilter\\6604e639e6bdb8edb9bb409492cf3217f4ee08608f2a0c11f7d981b69e583ad9"},{"ID":"d0b4b6a9-a544-5586-a94b-aac3e37fac82","Path":"C:\\ProgramData\\docker\\windowsfilter\\10ad8963a83dd55daaffccd1619ec190a98f65309fca79a3f31753c1393ab21b"},{"ID":"41e04f6b-0e05-549c-a50d-94484a939bef","Path":"C:\\ProgramData\\docker\\windowsfilter\\4357ef5b44f83c5309558f6bb80a18b9faf380691d226d2ca56ee5ed76da5a6f"},{"ID":"45b8ee71-c3fa-5cbd-b3ec-0e37e02eaf28","Path":"C:\\ProgramData\\docker\\windowsfilter\\a685d3d9b9e42eb44602e35f9b6f5f822aaee0d92fd7c693fcba54b15cb5d3da"},{"ID":"680985ef-bf51-510d-ac30-98259479fcc1","Path":"C:\\ProgramData\\docker\\windowsfilter\\2f1823b1470c99a5c34be16c589c837affa613ad8853f8926984d91c3d1a2ed0"},{"ID":"1e73da6a-be54-53dd-afca-e0db84bf306f","Path":"C:\\ProgramData\\docker\\windowsfilter\\0fd5e003a143ca23a0a477446c09bd934c69da37318ab1832ce2eeea1dc5e1b4"},{"ID":"f457eec7-70a4-59b7-9379-babcafc98433","Path":"C:\\ProgramData\\docker\\windowsfilter\\2787257291de883c602b108c5f23a8f07b1950f78042d245934ab5550cf6a4ec"},{"ID":"87eb11f4-4ef6-563e-b46f-6b0b02450fb9","Path":"C:\\ProgramData\\docker\\windowsfilter\\5e8429b9bd6d0e8897d340231e31f93de9c74a8df5294636cfd4070e8f6e448d"},{"ID":"24921fd7-7c5b-5867-bca1-d0acbd662988","Path":"C:\\ProgramData\\docker\\windowsfilter\\f62d81a556f9cdfe2e00690b076a33a9c03f979b4f837bc55127ce50ea6a6c92"}],"HostName":"130a2bcf04ae","HvPartition":true,"EndpointList":["2103d101-c14c-487a-ab14-cf5585cca849"],"HvRuntime":{"ImagePath":"C:\\ProgramData\\docker\\windowsfilter\\f62d81a556f9cdfe2e00690b076a33a9c03f979b4f837bc55127ce50ea6a6c92\\UtilityVM"},"AllowUnqualifiedDNSQuery":true}).

Expected Behavior:

The service fabric cluster can start a containerized application with compatible OS without any errors

OS(Windows/Linux): Windows

Assignees: @microsoft/service-fabric-triage

While RDP into the SF node, if we try to run the docker image manually, this is the error reported

Just to be clear, this means it is not a Service Fabric issue. You RDP'd into an Azure VMSS VM. Service Fabric is just other software that runs on that same machine trying to launch the container on your behalf. If docker run doesn't work, then SF isn't going to be able to launch it either.
Since it looks like the versions are the same, this starts to feel like something else is wrong. Some things to look into:

Is the container hosting feature actually on/enabled or did something go wrong there?
What version of docker is installed?
Are there any containers that you have that will run here? If there are any what's different between those and this one?
Are you trying to launch as a process or with hyper-V enabled, and does the behavior change?
Does the VM sku that you're using support nested virtualization?

Hi @masnider
After some investigation we finally found that there was a problem updating the docker images on the scale set and what we thought it was the most recent image version was indeed a previous one that had an incompatible OS version. A docker image inspect command finally made it possible to understand the root cause.
Thanks for your feedback and availability.
Cheers.


[Medium] Meatball menu doesn't depend on JDN browser console position

JDN v 3.1.112
Back-end v 2022-01-21-15.18.28
Chrome
https://www.behance.net/
Scenario 1:

open any page
open JDN in browser console
separate it from the main tab
click Settings

Scenario 2:

open any page
open JDN in browser console
separate it from the main tab
click Identify
click any meatball menu in locators list

AR: settings popup can be covered by console tab

ER: settings popup should always be in the front of the JDN console browser tab

Not a bug


[Enhancement] Enable partial update to be used with condition update

Actually we can do partial update with condition update, but we reject it. This pr enable it.
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[x] Yes, this PR will result in a change in behavior.
[ ] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[x] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE Incremental Coverage Report]
:disappointed: fail : 3 / 11 (27.27%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/load/routineload/PulsarRoutineLoadJob.java
0
1
00.00%
[414]

:large_blue_circle:
com/starrocks/load/Load.java
0
7
00.00%
[138, 139, 140, 142, 144, 148, 151]

:large_blue_circle:
com/starrocks/planner/StreamLoadPlanner.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/load/loadv2/LoadingTaskPlanner.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/load/routineload/KafkaRoutineLoadJob.java
1
1
100.00%
[]

[BE Incremental Coverage Report]
:disappointed: fail : 1 / 3 (33.33%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/storage/delta_writer.cpp
0
2
00.00%
[231, 232]

:large_blue_circle:
src/storage/rowset_update_state.cpp
1
1
100.00%
[]

[FE Incremental Coverage Report]
:heart_eyes: pass : 11 / 12 (91.67%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/load/routineload/PulsarRoutineLoadJob.java
0
1
00.00%
[414]

:large_blue_circle:
com/starrocks/planner/StreamLoadPlanner.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/load/loadv2/LoadingTaskPlanner.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/load/routineload/KafkaRoutineLoadJob.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/load/Load.java
7
7
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/LoadStmt.java
1
1
100.00%
[]

[BE Incremental Coverage Report]
:disappointed: fail : 1 / 3 (33.33%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/storage/delta_writer.cpp
0
2
00.00%
[231, 232]

:large_blue_circle:
src/storage/rowset_update_state.cpp
1
1
100.00%
[]

[FE Incremental Coverage Report]
:heart_eyes: pass : 11 / 12 (91.67%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/load/routineload/PulsarRoutineLoadJob.java
0
1
00.00%
[414]

:large_blue_circle:
com/starrocks/planner/StreamLoadPlanner.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/load/loadv2/LoadingTaskPlanner.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/load/routineload/KafkaRoutineLoadJob.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/load/Load.java
7
7
100.00%
[]

:large_blue_circle:
com/starrocks/sql/ast/LoadStmt.java
1
1
100.00%
[]

[BE Incremental Coverage Report]
:disappointed: fail : 1 / 3 (33.33%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/storage/delta_writer.cpp
0
2
00.00%
[231, 232]

:large_blue_circle:
src/storage/rowset_update_state.cpp
1
1
100.00%
[]

@mergify backport branch-3.1


Improve visibility of openmp suggestions with dask.array

I mentioned this on gitter and thought it may help if this was more public on the dask documentation as well. A lot of users of the SatPy library (which uses xarray and dask) end up running their operational processing on one or two high performance servers with 30-40 cores. Limiting the number of dask workers on a threaded scheduler has become something that many users understand to avoid memory errors from too many chunks being processed at once. However, I learned yesterday that using numpy with openmp can also be a huge problem. Having openmp create a lot of threads on these servers is not a huge issue in a single thread/process, but combined with dask it is (see details below).
I'm wondering if OpenMP and OMP_NUM_THREADS should be mentioned more in the documentation when either introducing dask arrays or talking about performance. Right now I think it is only mentioned here and that is specifically about errors when working with OpenMP. Am I missing anything? I'm guessing you would be against automatically setting OMP_NUM_THREADS in dask and I can agree with that. If I was to add more to the docs about this, where would you prefer I do it?

My processing was configured for 8 workers on a 48 core machine and without limiting openmp it was creating 384 threads. The processing I was doing took about 12m30s. After being surprised by the number of threads, I forced openmp to 2 threads and the processing now created an understandable 20-30 threads and completed in 10m30s.

I'm in favor of documentation that helps people past common issues. The challenge is how to list common issues while not flooding documentation with them.  There are probably 10 issues of similar-or-greater importance to OMP_NUM_THREADS for dask array workloads (use good storage, chunk your storage appropriately, don't use very small chunks, don't use bad compression, ...) and so the approach of putting these things front-and-center generally means that nothing is front-and-center.
What has worked decently well is the Delayed best practices documentation page.  I think that it would be good to establish such a page for each of the collections that could hold information like this.  I think that a start on such a document would be a good idea if you're interested in starting it up.

Yes, I'll see if I can find the time. I've definitely read the Delayed best practices multiple times. Do you think this should be dask.array specific best practices? I guess we'll deal with overlap with other things later (link or duplicate). So the list:

limit workers
limit openmp threads
good storage
chunk your storage appropriately (what does this mean?)
no very small chunks
choose good compression (are you thinking input data or output data? zarr only or all formats?)

Yes, I think that a new page that was array specific but that had the same structure of the Delayed best practices page would be good.
I recommend that you only write down the things that you're pretty comfortable with.  If you're not sure about some of those then leave them for others.

Closing as OMP_NUM_THREADS was included in #4705


Polyfill error in imageKit plugin setup

Bug Report

Getting polyfill error in imageKit plugin setup
Current Behavior
Polyfill error
Expected Behavior
Image should be uploaded to imageKit
Possible Solution
Not sure
Steps to Reproduce

install he payload imagekit plugin:  npm i payloadcms-plugin-imagekit
It was giving an error that imageKit module not found so i installed that: npm i imagekit
add the confiig as instructed on plugin's github repo: https://github.com/novanda1/payload-imagekit
After saving got polyfill error in console

Payload version: 1.1.15
imageKit version: 4.1.1
payloadcms-plugin-imagekit version: 0.2.3
Github Link: https://github.com/shubhamwebdesign/devstack_project_crm/tree/imagekit

Hey @shubhamwebdesign — this is an issue with that plugin and not with Payload. It appears that there is a Node package being imported which is not compatible with browsers, and should be removed using Webpack aliases as seen in the docs here.
You should re-open this issue and link to the above docs on that repo itself!

Opened the issue on the plugin repo - thanks @jmikrut for the quick response


Update gradle enterprise server

Because we are officially recognized by Gradle
and offered a gradle enterprise managed instance!

Ooh, surely this wasn't done just because of this cheeky message? https://github.com/detekt/detekt/issues/4585#issuecomment-1042236761
I'm assuming this was actually arranged through other channels, but either way this is great to see!
Not sure about any usage limitations that might apply, but is this also the target for any locally run builds? Or can it only be used when running the CI builds?

From the build logs (no doubt you've seen this already but just in case):
Publishing build scan...

The Gradle Enterprise server (ge.detekt.dev) rejected the request due to authentication being required.
If you are able to sign in to this server in a web browser, you can authenticate your environment by running the following task:

:provisionGradleEnterpriseAccessKey

Or see https://gradle.com/help/gradle-plugin-auth for additional help with authenticating your build environment.

I believe we need to get the access key and set up GitHub secrets for this. I will wait for Gradle team to get back to us.

Not sure about any usage limitations that might apply, but is this also the target for any locally run builds? Or can it only be used when running the CI builds?

Once this is properly configured I think that all the maintainers will have a key to upload our local builds too.

Ooh, surely this wasn't done just because of this cheeky message? #4585 (comment)

On the Droidcon London Nico and I asked for this. And after some months of Nico pushing for it he made it happen :).

Ooh, surely this wasn't done just because of this cheeky message? #4585 (comment)

On the Droidcon London Nico and I asked for this. And after some months of Nico pushing for it he made it happen :).

Kudos to @runningcode also for driving this forward as well 👍

We're very happy to partner with the Detekt project and sponsor with a Gradle Enterprise OSS instance.
Please let me or @clayburn review this before merging.

🤔 @chao2zhang is this an issue rebasing?

🤔 @chao2zhang is this an issue rebasing?

Yeah I guess so 👍

I've force pushed this @chao2zhang with the correct config.
@clayburn it should be ready to go, waiting for your approval 👍

LGTM, but not sure if @runningcode wanted a sign-off here too.

We are selectively publishing build scans for two Github workflows with this PR now. Check https://ge.detekt.dev/scans

Thanks for setting up GRADLE_ENTERPRISE_ACCESS_KEY. This is good to go on my end 👍


Some how I can't get the switching between FancyZone layouts, with the set key, running anymore.

PowerToysReport_2024-11-11-15-37-35.zip
Microsoft PowerToys version
V0.86.0
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
FancyZones, FancyZones Editor
Steps to reproduce
Every FancyZone layout has an dedicated key (0 to 5), set in the FancyZones-Editor.
Normaly, with the FancyZone aktive when draing a screen arround, I could switch between those layouts by the programmed key, but this is not working anymore.
I have to open the FancyZone editer to choose another layout.
✔ Expected Behavior
When key press of the dedicated layout key, I expect the layout to change.
❌ Actual Behavior
FancyZone layout does not switch anymore.
Other Software
No response

Some how, I don‘t know why, it is working now again.
Have not changed anything so far.
So all good.


Rename to Glupyter

And what about confusions with this repo? https://github.com/glue-viz/glue-jupyter
It took me quite a while to find this one.

Your comment makes me think this should probably move under the glue-viz organization at some point as well!


Integrate in java

Hi Team,
We are planning integrate Nuget Sign in our product. kindly provide me the link for Java sample like, how to integrate with java and sample APIs execution Java Example
Thank you
Anilkumar

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5e2a0cf1-bbb7-18f7-bfed-f717da4c1812
Version Independent ID: 0e4df241-34c7-d943-5811-9ed0d40291f1
Content: Signing NuGet Packages
Content Source: docs/create-packages/Sign-a-Package.md
Product: nuget
GitHub Login: @rido-min
Microsoft Alias: rmpablos

Could you be able to provide more context? Is it about package signing with X.509 certificate?

@erdembayar : Yes, we have done integration for Microsoft MSAL with our product with the help of https://github.com/Azure-Samples/ms-identity-java-webapp this example. it is working as expected.
I need this kind of  JAVA example sample code to integrate for Signing NuGet Packages. Kindly Suggest me ASAP

@anilkumarhgowda NuGet is not a WebAPI, so we can't generate Java bindings, like Azure services can. As NuGet is written in .NET, we only have a .NET SDK for programmatic integration. I suggest you shell out to nuget.exe or the .NET CLI, check the process exit code and parse the console output.

@anilkumarhgowda As my previous comment suggested, one option is to run nuget.exe as a separate process, capture the output, and parse the output. I'm sure there are many Stack Overflow answers on how to do this if you don't know how already.
Other ideas are:

Searching online for "bridge java .net", there are multiple products allowing you to call .NET assemblies from Java. You could investigate these products
These products are probably implemented using .NET's ability to embed the host in a native application. You'd probably need to use JNI to call these APIs.
NuGet is open source, so you could look at the code that is relevant to the functionality you want to provide, and port it to Java. NuGet client is under the Apache 2.0 license, so just make sure that your port is compliant.

Finally, we don't have Java APIs, and it's out of scope for the support we provide, so I'm going to close this issue.


Firestore - surprising behavior of object mapping annotations

If com.google.cloud.firestore.annotation.Exclude annotation used on a property, but not on a getter, it is ignored. The same is true for @PropertyName
For @PropertyName it gets even more surprising if the property is public and there is a public getter. In that case a field is duplicated, one instance under the property's name and the other one under the getter's name.
Example that replicates the issue:
class User {
  @PropertyName("user_name")
  public String name;

  @Exclude
  private Integer age;

  public User(String name, Integer age) {
    this.name = name;
    this.age = age;
  }

  public User() {
  }

  public String getName() {
    return name;
  }

  public Integer getAge() {
    return age;
  }
}

This would produce the following fields:
{age=integer_value: 29
, name=string_value: "abc"
, user_name=string_value: "abc"
}

But I would expect this:
{
user_name=string_value: "abc"
}

@dmitry-s  If you want to use annotations at field level than you need to follow rules which are below.

the field has to be public.
If you are using annotations at field level than please do not create getters.
Suppose you want to use annotations at getter level than do not use them at field level
(this is kind of built-in design at the moment).

Field level: fields has to be public
class User {

  @PropertyName("user_name")
  public String name;

  @Exclude
  public Integer age;

  public User(String name, Integer age) {
    this.name = name;
    this.age = age;
  }

  public User() {}
}

For getter level fields has to be private.
class User {

  private String name;

  private Integer age;

  public User(String name, Integer age) {
    this.name = name;
    this.age = age;
  }

  public User() {}

  @PropertyName("user_name")
  public String getName() {
    return name;
  }

  @Exclude
  public Integer getAge() {
    return age;
  }
}

@pmakani
Thanks for response.
That issue was not a question, but a feature request.
I understand how to make it work, but it is not convenient/consistent.
It is very different from how annotations work in Spring (which is by far the most used java framework and most java developers are familiar with it). It would be great to make Firestore annotations work in the same way, so users don't have to re-educate themselves and this would make adoption fast and effortless.

@dmitry-s i agree to your suggestions. this would help a lot of developers.
@schmidt-sebastian @BenWhitehead i would like to know your thoughts on the feature request.

Hi! There's certainly a bit of cleanup we can do here, and I am not overly exposed. It does sound like the suggestions here involve breaking changes, and since Firestore just went GA we would have to wait until the next major version. Are you currently blocked on this?

We are not blocked on this, it can wait till the next major version.


RPi, Steady mode didn't work

RPi, web interface, Steady mode didn't work

It works in ESP32 connecting by AP.


How to use a color statically, not affected by theme?

I have a UI in which the toggle thumb should remain white on both light and dark mode:

This doesn't seem possible with Radix Colors without manually defining a new variable --white: <hardcoded radix color value>. Is this the recommended way? Is adding an escape hatch for using a static non-theme dependent color a feature that you would consider supporting?

What's wrong with simply defining backgroundColor: white? That's the approach we take.

I second this issue. I like to sometimes mix light and dark themes, which is hard to do with the way Radix Colors segregates light and dark themes. It's also hard to work with CSS' prefers-color-scheme when using the CSS files provided by Radix Colors.


the device can hear my own voice, how can i fix the problem?

I use the flutter-webrtc plugin to implement my android p2p videochat app, but can hear my own voice during the call. how can i fix the problem?

I have the same problem, seems like the mic is also listening to speaker. Any fix on this?


Instructions on readme

This PR adds installation and usage instruction for RTC.

@gshiroma Thanks for the quick turnaround. I've accepted all of your suggestions.


Broke compatibility with PlatformIO

Issue Type: Bug
Try and compile a program for ESP-IDF using Platform IO
VS Code version: Code 1.22.1 (950b8b0d37a9b7061b6f0d291837ccc4015f5ecd, 2018-04-06T02:26:57.615Z)
OS version: Windows_NT x64 6.1.7601

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6600U CPU @ 2.60GHz (4 x 2808)

Memory (System)
7.86GB (3.36GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe

Screen Reader
no

VM
0%

Extensions (7)

Extension
Author (truncated)
Version

code-gnu-global
aus
0.2.2

vscode-github
Kni
0.27.1

python
ms-
2018.3.1

cpptools
ms-
0.16.1

platformio-ide
pla
0.14.0

vscode-icons
rob
7.22.0

debug
web
0.22.0

(3 theme extensions excluded)

Same here. The auto-update of Visual Studio Code broke my platformio setup. There's also a report on platformio's tracker with some more details:
https://github.com/platformio/platformio-vscode-ide/issues/97
This is a serious regression, I just don't know if it's a bug in vscode or platformio.

Do you have a .vscode/tasks.json file? Can you post it?
In the upstream issue it shows the terminal writing a path to platformio.exe. Is the path correct?

There's no tasks.json file in my project's .vscode folder. (Is that to be expected?)
No, the path to platformio.exe is not correct and AFAICT it should not have been added to the command. I.e. simply calling "platformio run" (without specifying the path to the .exe) in the project's source folder works just fine if I open the integrated PlatformIO Terminal.
I can't remember if the previous version of vscode (probably 1.21) also added a (correct) path to the .exe or if it simply relied on the .exe being found through the PATH variable.

That's ok, it sounds like the extension is contributing a task and either vscode is interpreting it incorrectly or the task is not formed correctly. @dbaeumer or the extension maintainer can investigate more.

@Tyriar is this bug related to Terminal?

A temporary solution is to roll back to 1.21 using https://code.visualstudio.com/updates/v1_21 and "Download" links.
Also, maybe you will need to disable automatic updates for VSCode.

Yes, the only Windows is affected.

I am able to reproduce this. Will look into what broke it.

Under Windows I wrote my own code to find the executable on the path. This got broken with https://github.com/Microsoft/vscode/commit/b1adb2179631ff83ab6bb1e43bc343e2835cd985 which fixed https://github.com/Microsoft/vscode/issues/39720

I started to debug why this is broken and the problem is that I when VS Code tries to find the executable the C:\Users\dirkb.platformio\penv\Scripts is not on the PATH in my system (e.g. the renderer) but it is in the terminal. Need to understand why this is the case.

Understand it now. The reason for the breakage is that Platform IO brings its own PATH environment and findExecutable doesn't consider this. It only takes the PATH from the current renderer process.

The interesting questions is why that worked in the first place since under Windows the OS doesn't try to find an executable on the PATH when launching a process. The PATH must always be absolute.
@Tyriar did the terminal or some of the underlying libraries get code to find the executable on the PATH under Windows. This would explain why it worked before. If this is the case then I could simply remove my code :-)

OK. I found the code: https://github.com/Tyriar/node-pty/blob/master/src/win/path_util.cc#L31
However that only works if the extension is already provided. So I need to keep my code since simply using platformio would have been enough. The task system then looks for platformio.com and platformio.exe

To verify:

install Platform IO (see http://docs.platformio.org/en/latest/ide/vscode.html)
create a Project (http://docs.platformio.org/en/latest/ide/vscode.html#quick-start)
Run Task > PlatformIO: Build

The build task should succeed.

Reopening the issue to discussion in bug standup.

OK. I found the code

Yes that's it, there's an open issue to improve this: https://github.com/Tyriar/node-pty/issues/112

@Tyriar thanks. I wrote which in TS if that would help for you. It is here: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/tasks/electron-browser/terminalTaskSystem.ts#L691

We decided to include the fix in the fix in the next recovery build.

@dbaeumer that does indeed help :+1: is this something we can push to node-pty and rely on it there?


Moving light classes files generation to separate job

Is it somehow relevant to KE-301?

Is it somehow relevant to KE-301?

It is. By creating lightclasses files on IResourceChangeEvent.PRE_REFRESH callback, we were causing blocked tree exception. That's why I moved it to the separate job.
But please do not merge it yet, there is a strange problem with failing KotlinAnalyzerTest this PR somehow caused.

Ok, reworked, now everything pass correctly

OK,  thanks!


Add --skipLibCheck compiler option

This PR adds a new --skipLibCheck compiler option that causes type checking of declaration files (files with extension .d.ts) to be skipped. When a program includes large declaration files, the compiler spends a lot of time type checking declarations that are already known to not contain errors, and a compile times may be significantly shortened by skipping declaration file type checks.
Since declarations in one file can affect type checking in other files, some errors may not be detected when --skipLibCheck is specified. For example, if a non-declaration file augments a type declared in a declaration file, errors may result that are only reported when the declaration file is checked. However, in practice such situations are rare.
Fixes #8521. Compile times for the example given in this issue are reduced 5x.

👍

:+1:

:+1:


Replace strip! by strip on compute_digest method

This PR replaces #647, Issue reported at #603
@bramleyjl This PR contains only 1 commit vs the one you created with 6 commits.
This PR is for a fix to the compute_digest method that was rendering a nil digest after Base64-encoding it. The reason for this bug is the usage of strip!, a method that returns nil if no whitespace is found on either end of the string to be stripped. By replacing it with strip, an identical method that will return the original string if no whitespace is found to be stripped, this bug can be prevented.

Indeed, as lots of Ruby bang methods, #strip! returns nil if it didn't make any change to its receiver. 🎯
But those methods are also known to be more efficient (especially with big objects), as they mutate their receivers instead of duplicate it.
So if you want the best of both worlds (knowing that here the mutation didn't generate any problem by itself), you could also do receiver.tap(&:strip!).
You probably already know that, but the short explanation is that the #tap method allows us to do whatever we want with its receiver in its block, then returns the receiver itself (i.e. not the result of the block), therefore in that case it will never returns nil. 🙂
Nevertheless I am not familiar with this gem, so I'm not sure at all that it could be any significant impact in this case.


Use symlinked Action Cache in ramdisk

Would using an acttion cache in a ramdisk imrove lookup time when using the bazel remote cache?
I have tried to test this but seems spinning up the docker container fails with the message below.
I tried creating a ramdisk and moving the  ac into it, then symlinking to the ac where the cache is stored:
➜  /bazel_cache  ll                                                                                total 28K
lrwxrwxrwx   1 root root   27 Jun  2 13:53 ac -> /mnt/ramdisk/bazel_cache/ac
drwxr-xr-x 258 root root 4,0K Feb  4 15:17 cas
drwx------   2 root root  16K Feb  4 15:06 lost+found
drwxr-xr-x 258 root root 4,0K Feb  4 15:17 raw

When I try to run the docker image, I get a mkdir /data/ac: file exists exception.
➜  /bazel_cache  docker run --rm --log-opt max-size=10m -v /bazel_cache:/data -p 9090:8080 -p 6060:6060 buchgr/bazel-remote-cache --ax_size=17
2020/06/02 11:36:23 bazel-remote built with go1.13.8 from git commit ae546fc99a1bd7addd63269879e634545cdfcc1b.
2020/06/02 11:36:23 Initial RLIMIT_NOFILE cur: 1048576 max: 1048576
2020/06/02 11:36:23 Setting RLIMIT_NOFILE cur: 1048576 max: 1048576
2020/06/02 11:36:23 mkdir /data/ac: file exists

I assume the implementation here does not accept existing folders as symlinks.

Would using an acttion cache in a ramdisk imrove lookup time when using the bazel remote cache?

This would not help the "lookup" since we already use an in-memory index. It might improve the actual download since reading from a ramdisk has lower latency than reading from SSD (and much more than reading from HDD). However it is not clear if this will help much in practice, since the cost of the network traffic is much higher than the SSD latency. Benchmarks would be welcome, of course.

ac -> /mnt/ramdisk/bazel_cache/ac
...
When I try to run the docker image, I get a mkdir /data/ac: file exists exception.

I think the problem might be that your symlink target is an absolute path outside the docker container, but bazel-remote runs inside the container and does not see the target dir. Can you either try mapping that path into the docker container, or using bind mount in the host system instead of a symlink?

However it is not clear if this will help much in practice, since the cost of the network traffic is much higher than the SSD latency.

We are using the remote cache in a production environment and cosistenly seeing at least 3k+ sockets on baremetal and 10k+ sockets on VMs with up to 750MB/s (Megabytes/s!).
The baremetal is obviously where we observe the bottlenec, since we're just using a generic ssd and gigabit ethernet as opposed to NVME and 10 GigE in the cloud.
As it turns out, there are a lot of possible bottlenecks:

the network badwith, as you mentioned.
the number of sockets.
the buffer size and seek time to/from the ssd.

I think the problem might be that your symlink target is an absolute path outside the docker container.

True, this is most likely the root cause. I'll look at it again tormorrow. Thank you!

OK, so we had a look at it again, this time also mounting the ramdisk:
➜  /bazel_cache  docker run --rm --log-opt max-size=10m -v /bazel_cache:/data -v /mnt/ramdisk:/mnt/ramdisk -p 9090:8080 -p 6060:6060 buchgr/bazel-remote-cache --max_size=17
2020/06/03 09:08:24 bazel-remote built with go1.13.8 from git commit ae546fc99a1bd7addd63269879e634545cdfcc1b.
2020/06/03 09:08:24 Initial RLIMIT_NOFILE cur: 1048576 max: 1048576
2020/06/03 09:08:24 Setting RLIMIT_NOFILE cur: 1048576 max: 1048576
2020/06/03 09:08:24 Migrating files (if any) to new directory structure: /data/ac
2020/06/03 09:08:24 Attempting to migrate the old directory structure to the new structure failed with error: rename /data/ac /data/ac/ac: file exists

It appears that the implementation does not skip past symlinks. Is this correct? How would we tackle this best?

It appears that the implementation does not skip past symlinks. Is this correct? How would we tackle this best?

That code should be fixed to handle symlinks. To run your test in the meantime, can you try mounting the ramdisk at /bazel_cache/ac/ ?

works using mounting the ramdisk to /data/ac. Thank you.
So using symlinks out-of the box sounds like a feature request, doesn't it? :)

works using mounting the ramdisk to /data/ac. Thank you.

Great- I look forward to seeing some benchmark numbers :)

So using symlinks out-of the box sounds like a feature request, doesn't it? :)

Yes, I will fix it (unless you would like to).

Great- I look forward to seeing some benchmark numbers :)

I'm using a Samsung EVO 860 2TB with 500-1k sockets and 20-40MB/s constant traffic.
First benchmark is inconclusive. I could not see a major improvement by moving the ac into RAM.
Busy IO slowly ramps up and eventually saturates. I can see it ramping up quicker with no ramdisk than using the ramdisk, but I cannot tell if this is due to traffic or actual speed improvement I get from the ramdisk.

Yes, I will fix it (unless you would like to).

Unfortunately I don't have time to and I don't need this feature this urgently to have to implement it.
Besides, the docker mount of the ramdisk fulfills my usecase. :+1:


added a game memory fllip

PR Description 📜
I have added a game named as memory flip
Fixes #4785

##4785 ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @1911aditi ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

can u check now? @ishita-43 @kunjgit

Thank you  @1911aditi , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Don't Merge! PR real time test for webhook case

Docs Build status updates of commit 3a37973:
:clock10: Full build: the average full build time is 7 min(s) 52 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit 3a37973:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/testing.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


pick method returns null

The following method does not open the printer selection window in iOS:
cordova.plugins.printer.pick({ top: 40, left: 30 }, callback);
The method returns null.
cordova.plugins.printer.print() works as expected.

Same for me. IOS 14 iPad.

Same here. iPad Pro(4th generation).
Hope this issue would solved soon.

Hey guys. I think I found the solution. The plugin includes platform detection inside the code. The platform detection uses navigator.userAgent.indexOf('ipad') || navigator.userAgent.indexOf('iphone') to detect if the code is running on iPad or iPhone.
I removed the line for isIOS check and it started working like a charm. This is a temporary solution but it's better than nothing.
Later you can unbranch from master, create your own repository and use it with this fix for later plugin install actions. Go to
/cordova-plugin-printer/www/printer.js

Dude that's amazing, thanks for figuring this out 💪

This must still be an issue because I'm struggling to get the pick method to fire on iOS 15

Removed the same isIOS and that got things working, thanks @1nstinct
Is this project still being maintained?

Thanks @1nstinct for finding the origin of the bug ❤.
Personally, I added a check in the isIOS variable on a fork of the project.
|| window.cordova.platformId === "ios"

I created a PR hoping that @katzer would merge the fix 🤞🏻.
https://github.com/katzer/cordova-plugin-printer/pull/293


missing software

Is there a possibility to report missing software so that it gets detected and analyzed as well?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dc646df4-fc3c-9a3d-7f17-b12777c4a659
Version Independent ID: 1b37afc4-6615-e88a-d9d4-6cb29e26059e
Content: Software inventory
Content Source: windows/security/threat-protection/microsoft-defender-atp/tvm-software-inventory.md
Product: w10
Technology: windows
GitHub Login: @DulceMontemayor
Microsoft Alias: dolmont

@officedocsbot assign @mypil@officedocsbot assign @mypil

@sebhe - Thank you for submitting feedback.
I will get this issue over to the Win10 ITPro writing team for investigation.
Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

Hello @sebhe ,
unfortunately no, it only can detect vulnerabilities for existing soft
Thank you

@sebhe  - From our understanding, the issue you raised has been answered by MaratMussabekov. If you feel it hasn't been answered, please re-open this issue.
Thank you for your contribution to make the docs better! Much appreciated!

@officedocsbot close


[Bug]: Running Next Dev locally with MiddlewareRequest causes error

Summary
Running next dev locally with MiddlewareRequest inside middleware.ts causes an error MiddlewareRequest only works in a Netlify Edge Function environment

If you have to run locally using netlify dev this should be called out inside the documentation.
Subsequently there is a typescript error also  Types of property 'geo' are incompatible.
Steps to reproduce
Inside middleware.ts import { MiddlewareRequest } from "@netlify/next";
create a new netlify middleware request with the below code
const request = new MiddlewareRequest(req);
go to a url in browser and notice the error
A link to a reproduction repository
No response
Next Runtime version
x
Is your issue related to the app directory (beta)?

[ ] Yes, I am using the app directory

More information about your build

[ ] I am building using the CLI
[ ] I am building using file-based configuration (netlify.toml)

What OS are you using?
Mac OS
Your netlify.toml file

`netlify.toml`
# Paste content of your `netlify.toml` file here

Your public/_redirects file

`_redirects`
# Paste content of your `_redirects` file here

Your next.config.js file

`next.config.js`
# Paste content of your `next.config.js` file here. Check there is no private info in there.

Builds logs (or link to your logs)

Build logs
# Paste logs here

Function logs

Function logs
# Paste logs here

.next JSON files

generated .next JSON files
# Paste file contents here. Please check there isn't any private info in them
# You can either build locally, or download the deploy from Netlify by clicking the arrow next to the deploy time.

Closing as stale

Sorry @sarahetter have been off work for the last few months. Am i correct in assuming that you are running your local dev environment with netlify dev ? Is this a requirement for using this?

Yes, I was running with netlify dev. The @netlify/next package makes use of edge functions, and so using our dev command rather than next dev is required.
I'll create an issue to make this clearer in the documentation.

I am experiencing the same issue, even when running ntl dev.
To reproduce, I followed the steps above. I created a new next project (tried with several different options, app/pages, src, etc), installed @netlify/next, added the middleware.ts just like above, and ran ntl dev.
Then I get:
Error: MiddlewareRequest only works in a Netlify Edge Function environment
    at middleware (middleware.ts:6:18)
  4 | export async function middleware(req: NextRequest) {
  5 |
> 6 |   const request = new MiddlewareRequest(req)
    |                  ^
  7 |
  8 |   return request.next()
  9 | }

Can we please reopen this issue?