Hi I am trying to compile on windows and get errors

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows10
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): trying to install from source
TensorFlow version:2.2
Python version:3.9
Installed using virtualenv? pip? conda?:pip
Bazel version (if compiling from source):3.73
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:11.2/<IP_ADDRESS>
GPU model and memory:RTX 2080/ 15.9GB

Describe the problem I followed everything explained in this tutorial https://towardsdatascience.com/how-to-compile-tensorflow-2-3-with-cuda-11-1-8cbecffcb8d3
until the command :
bazel build --config=cuda //tensorflow/tools/pip_package:build_pip_package
where I got :
WARNING: Download from https://storage.googleapis.com/mirror.tensorflow.org/github.com/llvm/llvm-project/archive/418c218efa950245ba075b9bb3a53505b807c5df.tar.gz failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException GET returned 404 Not Found
INFO: Analyzed target //tensorflow/tools/pip_package:build_pip_package (419 packages loaded, 27891 targets configured).
INFO: Found 1 target...
ERROR: C:/users/korin/tensorflow/tensorflow/core/profiler/internal/gpu/BUILD:108:16: undeclared inclusion(s) in rule '//tensorflow/core/profiler/internal/gpu:cupti_wrapper':
this rule is missing dependency declarations for the following files included by 'tensorflow/core/profiler/internal/gpu/cupti_wrapper.cc':
'tensorflow/stream_executor/cuda/cuda_activation.h'
'tensorflow/stream_executor/gpu/gpu_activation.h'
cl : Command line warning D9035 : option 'experimental:preprocessor' has been deprecated and will be removed in a future release
cl : Command line warning D9036 : use 'Zc:preprocessor' instead of 'experimental:preprocessor'
Target //tensorflow/tools/pip_package:build_pip_package failed to build
INFO: Elapsed time: 1356.616s, Critical Path: 249.97s
INFO: 7667 processes: 3916 internal, 3751 local.
FAILED: Build did NOT complete successfully
Provide the exact sequence of commands / steps that you executed before running into the problem
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

python 3.8

@divastar,
Every TensorFlow release is compatible with a certain CUDA/cuDNN version. For more information, please take a look at the tested build configurations.
Could you please run the bazel clean --expunge command and then try building the latest version of TensorFlow v2.4 with CUDA 11.0 and cuDNN 8 and check if you are facing the same issue.
Also, follow the official guide while building TensorFlow from source. Thanks!

I am working on it. Thank you

Hi .
So I uinstalled cuda 11.0 cudnn <IP_ADDRESS>
made a new environment with conda python 3.6
bazel 3.7
when I configure I get :
(newtensor) C:\Users\korin\tensorflow>python ./configure.py
You have bazel 3.7.2 installed.
Please specify the location of python. [Default is C:\Users\korin\anaconda3\envs\newtensor\python.exe]:
Found possible Python library paths:
C:\Users\korin\anaconda3\envs\newtensor\lib\site-packages
Please input the desired Python library path to use.  Default is [C:\Users\korin\anaconda3\envs\newtensor\lib\site-packages]
Do you wish to build TensorFlow with ROCm support? [y/N]: n
No ROCm support will be enabled for TensorFlow.
Do you wish to build TensorFlow with CUDA support? [y/N]: y
CUDA support will be enabled for TensorFlow.
Could not find any cuda.h matching version '' in any subdirectory:
''
'include'
'include/cuda'
'include/*-linux-gnu'
'extras/CUPTI/include'
'include/cuda/CUPTI'
'local/cuda/extras/CUPTI/include'
of:
Asking for detailed CUDA configuration...
Please specify the CUDA SDK version you want to use. [Leave empty to default to CUDA 10]: 11
Please specify the cuDNN version you want to use. [Leave empty to default to cuDNN 7]: 8
Please specify the comma-separated list of base paths to look for CUDA libraries and headers. [Leave empty to use the default]: C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\extras\CUPTI\include
Traceback (most recent call last):
File "third_party\gpus\find_cuda_config.py", line 653, in
main()
File "third_party\gpus\find_cuda_config.py", line 645, in main
for key, value in sorted(find_cuda_config().items()):
File "third_party\gpus\find_cuda_config.py", line 583, in find_cuda_config
result.update(_find_cuda_config(cuda_paths, cuda_version))
File "third_party\gpus\find_cuda_config.py", line 257, in _find_cuda_config
get_header_version)
File "third_party\gpus\find_cuda_config.py", line 244, in _find_header
required_version, get_version)
File "third_party\gpus\find_cuda_config.py", line 233, in _find_versioned_file
actual_version = get_version(file)
File "third_party\gpus\find_cuda_config.py", line 250, in get_header_version
version = int(_get_header_version(path, "CUDA_VERSION"))
ValueError: invalid literal for int() with base 10: ''
Asking for detailed CUDA configuration...
Please specify the CUDA SDK version you want to use. [Leave empty to default to CUDA 10]: 11
Please specify the cuDNN version you want to use. [Leave empty to default to cuDNN 7]: 8
after I copied cuda.h from C:\Users\korin\tensorflow\tensorflow\core\platform to
C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.0\extras\CUPTI\include
and specified this folder for cuda during confi - same errors
then i tried to edit cuda_configure.bzl with:
),
"cupti": _check_cuda_lib_params(
"cupti",
cpu_value,
cuda_config.config["cupti_library_dir"],
#cuda_config.cuda_version,
"11",
static = False,
),
"cusparse": _check_cuda_lib_params(
"cusparse",
stil same errors during config
Thank you..

of course I did bazel clean --expunge before and downloaded latest tensorflow as you suggested ..

@divastar,
Could you please confirm if you've added the CUDA, CUPTI, and cuDNN installation directories to the %PATH% environmental variable as mentioned in this guide. Thanks!


Question on how to extend BaseEffects

Hi all and thanks in advance,
I am trying to create a BaseEffects Class and then a bunch of other classes that extend base.
Current implementation:
base.ts
@Injectable()
export class BaseLoopbackEffects {
  public upperName: string;

  @Effect()
  public create: Observable<Action> = this.actions$
    .ofType(this.actionTypes[this.upperName + '_CREATE'])
    .map(toPayload)
    .mergeMap((payload) =>
      this.apiService.create(payload)
        .map((response) => new this.actionTypes.loginSuccess(response))
        .catch((error) => concat(of(new this.actionTypes.loginFail(error)), of(new LoopbackErrorActions.error(error))))
    );

  @Effect()
  public test: Observable<Action> = this.actions$
    .ofType(UserActionTypes.USER_CREATE_SUCCESS)
    .map((action) => new LoopbackErrorActions.error(action.payload));

  constructor(
    public actions$: Actions,
    public apiService: any,
    public modelName: string,
    public actionTypes: any
  ) {
    this.upperName = modelName.toUpperCase();
  }
};

user.ts
@Injectable()
export class UserEffects extends BaseLoopbackEffects {
  @Effect()
  public login: Observable<Action> = this.actions$
    .ofType(UserActionTypes.LOGIN)
    .map(toPayload)
    .mergeMap((payload) =>
      this.user.login(payload.credentials, payload.include, payload.rememberMe)
        .map((response) => new UserActions.loginSuccess(response))
        .catch((error) => concat(of(new UserActions.loginFail(error)), of(new LoopbackErrorActions.error(error))))
    );

  @Effect()
  public logout: Observable<Action> = this.actions$
    .ofType(UserActionTypes.LOGOUT)
    .map(toPayload)
    .mergeMap((payload) =>
      this.user.logout()
        .map(() => new UserActions.logoutSuccess())
        .catch((error) => concat(of(new UserActions.logoutFail()), of(new LoopbackErrorActions.error(error))))
    );

  constructor(
    @Inject(Actions) public actions$: Actions,
    @Inject(UserApi) public user: UserApi
  ) {
    super(actions$, user, 'User', UserActionTypes);
  }
}

Problem is that this apparently is not working.
UserEffects effects work properly but BaseLoopbackEffects are not triggered.
Any idea of why this is not working?

@spali I read in another issue that you have accomplished this. Can you give me some insight on how did you do it?

It's a bit uggly, but I started with a base class just as a you would do an effect class by default. Only difference, no @Effect decorator. then extend this class and just redeclare the effect properties without assigning a value and add the @Effect decorator.
Example:
class BaseEffect {
 protected myEffect = ....

 ...
}

class SubEffect extends BaseEffect {
 @Effect()
 protected myEffect;

 ...
}

If you inject something you need to inject it in the sub-class and manually invoke the super constructor of the BaseEffect class.
But currently I ended implementing all Effects in a effect "utility" class and assign the effects in the real effect class.
This allows me to reuse the same effect mutliple times and specific operators as needed during the assignement. I.e. I have a base-util class which all my Model Item uses. And I have an selection-util class which all model items can use that support selection.
class MyEffectUtil {
  public myEffect = ....

  ....
}

class MyEffects {

 protected myEffect = myEffectUtil.myEffect;

 constructor(protected myEffectUtil: MyEffectUtil) {}
}

@spali Where do you decorate the effects? In the MyEffectUtil or do you 'import' it in your concrete effect classes and decorate there? I can't tell from your last sample, but it looks interesting :)

In the concrete effect class because this allows reusing the effect logic of the util class in multiple variations in the concrete effect classes.

Makes sense, thanks!

I also ran into this and found an interesting solution similar to @spali.  You can decorate methods in the derived class that return methods in the base class (which are undecorated).
constructor(
    actions$: Actions,
    apiService: ApiService,
    store: Store<any>,
    model: Model
  ) {
    super('SomeActionString', 'SomeReducerKey', actions$, apiService, store, model);
    // Effects cannot be run from base classes :(
    // If we use the decorators here, we can return
    // the actual methods in the base class which are
    // then registered in the store
    this.initCreate();
  }

  @Effect()
  initCreate() {
    return this.create();
  }

then in the base class...
  create(): Observable<Action> {
    let CREATE = 'CREATE_' + this.ACTION_TYPE;
    return this.actions$
            .ofType(CREATE)
            .map(action => action.payload)
            .switchMap(payload => this.api.create(payload)
              .map(res => {
                return { type: `RECEIVE_${this.ACTION_TYPE}`, payload: res };
              })
              .catch(e => Observable.of({ type: `FAILED_FETCH_${this.ACTION_TYPE}`, payload: e }))
            );
  }

Please check this against NgRx v4, and if it’s still an issue, please reopen on https://github.com/ngrx/platform. Thanks!

@robwormald I'm still having this issue with v4. As a workaround I've used @spali 's suggestion (no decorators in base class and re-define variables with decorators)


Make a new "experiments lab" tool feature to be opted into all current and future feature experiment configs

Some new features are implemented in Flutter as opt-in configs.  Impeller, Swift Package Manager, web, and desktop support come to mind.  Every time we add one we need publicize that the new feature exists. Often this involves adding to the technical blog post, the website, emailing Flutter Insiders, and pushing on social mdeia.
It would be neat to have a new config flutter config --enable-all-experiments or similar for Flutter Insiders or other groups that want to try out all the bleeding edge features, regardless of what channel they are on.
This should be prominently called out in flutter doctor, possibly including instructions for how to turn it off.

cc @zanderso @RedBrogdon @anderdobo based on our release meeting conversation about SwiftPM, widget inspection, and other experiments we have coming down the pipe.
Does devtools have something similar? If not, a similar concept would need to be added there so the flutter tool can pass in the setting on launch, if possible.


Improve documentation: Correct typos, enhance clarity and formatting

Summary of Changes

Corrected typos and grammatical errors.
Improved clarity and consistency in language.
Enhanced formatting for better readability.
Added context where necessary for better understanding.

Motivation
These changes aim to improve the documentation's readability and comprehension, making it easier for new users to understand and use the project effectively.
Additional Notes

No functional changes were made to the codebase.
All changes are limited to documentation files.

Please review the changes and let me know if there are any issues or further improvements needed.

Thanks


WIP fix for decrypting password fields in workflow creation

resolves RackHD/RackHD#417
@RackHD/corecommitters
@keedya
This resolves the issue Andre was seeing where the script file was being rendered with an encrypted password.
However, I have locally been hitting an issue where, when I try to submit the graph to run against a node, I hit a JSON schema validation error, shown below.
    "UUID": "80c7e41c-d957-4c92-bc69-c33f0a44f111",
    "message": "Task.Set.BMC.Credentials: JSON schema validation failed - data.password should NOT be longer than 20 characters, data.password should match pattern "^[ -~]{1,20}$"",
    "status": "400"
}```

I have an open question out to Andre about what commit he's running... I assume, since he did not hit this error, it is older then around Aug... ( when this schema seems to have showed up here: https://github.com/RackHD/on-tasks/blob/5ffd1780a1bf8783152a8f04202b49a0b4fbb1ac/lib/task-data/schemas/set-bmc-credentials.json )

Currently still working on a fix to decrypt the password field at this validation stage, but what is here should unblock Andre's work.

Build finished.

So I discovered that my method for testing the resolution was flawed, @benbp 's comments about this only effecting the client http response (in effect nullifying my earlier redaction work) was correct, please standby until I can get the correct fix pushed.

Build finished.

BUILD on-http #2658 : FAILURE

** BUILD build-config-setup  #127482: SUCCESS
** BUILD unit-tests  #9585: FAILURE
** BUILD smoke-test  #3533: SUCCESS

Build finished.

new PR with good fix: https://github.com/RackHD/on-core/pull/220 closing this PR.


Package request: libfprint supporting 2808:a658 from libfprint-2-2_1.94.4+tod1-0ubuntu1~22.04.2_amd64_rts5811.deb

libfprint supporting 2808:a658

The fingerprint sensor on various Asus devices is 2808:a658 doesn't have existing drivers for NixOS, but exists for Ubuntu and Fedora based OS.
The drivers are also accessible to Arch users via AUR PKGBUILD.
ID 2808:a658 Realtek USB2.0 Finger Print Bridge FocalTech Fingerprint Device
Package to patch:

.deb format
.rpm format
AUR Package

Corresponding discourse link: https://discourse.nixos.org/t/request-for-libfprint-port-for-2808-a658/
Corresponding AUR PKGBUILD
# Maintainer: Harry Walker<EMAIL_ADDRESS>pkgname=libfprint-ft9366
pkgver=1.94.4
pkgrel=2
pkgdesc="Proprietary driver for the Focaltech fingerprint reader 2808:a658, which is used on various ASUS Vivobooks"
arch=('x86_64')
url="https://github.com/ftfpteams/RTS5811-FT9366-fingerprint-linux-driver-with-VID-2808-and-PID-a658"
depends=('glib2>=2.56' 'libgusb>=0.3.0' 'nss>=3.13.4' 'pixman>=0.30.0')
conflicts=('libfprint')
provides=('libfprint-2.so' 'libfprint')
options=('!strip' '!emptydirs')
install=${pkgname}.install
source=("https://github.com/ftfpteams/RTS5811-FT9366-fingerprint-linux-driver-with-VID-2808-and-PID-a658/raw/refs/heads/main/libfprint-2-2_1.94.4+tod1-0ubuntu1~22.04.2_amd64_rts5811.deb" "https://github.com/ftfpteams/RTS5811-FT9366-fingerprint-linux-driver-with-VID-2808-and-PID-a658/raw/refs/heads/main/libfprint-2-2-1.94.4+tod1-FT9366_20240627.x86_64.rpm")
sha512sums=('9d8a98884ffe02c4871cac668e46038727a70fe0c0f4fbc9477a785612e6f0f567173eebaea83f78e9248a0a59a5ac5fef192546da997a6b43d6e1ba4dc90afb' '6e5bd54929c8dbcba6ce16628502ac34164c8aa72785f9d84d871c7a0c2baed2a54e957d4b46c7b5176ebe5354d3f8abebe9b8195e8115f621f47bcb5b86f894')

package(){

	# Extract package data
	tar -xI unzstd -f data.tar.zst -C "${pkgdir}"
	mkdir -p "${pkgdir}/usr/lib"
	cp usr/lib64/* "${pkgdir}/usr/lib"

	# Fix directory structure differences
	cd "${pkgdir}"

	install -D -m644 "usr/share/doc/libfprint-2-2/copyright" "${pkgdir}/usr/share/licenses/${pkgname}/LICENSE"
	mv lib/* usr/lib; rm -rf lib
	mv usr/lib/x86_64-linux-gnu/libfprint-2.so.2 usr/lib
	rm -rf usr/lib/x86_64-linux-gnu

	getent group plugdev > /dev/null || groupadd plugdev

	cd ..

}

Metadata

homepage URL: https://github.com/ftfpteams/RTS5811-FT9366-fingerprint-linux-driver-with-VID-2808-and-PID-a658/
source URL: https://github.com/ftfpteams/RTS5811-FT9366-fingerprint-linux-driver-with-VID-2808-and-PID-a658/tree/main
license: unfree
platforms: linux

Add a :+1: reaction to issues you find important.

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/request-for-libfprint-port-for-2808-a658/55474/9

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/request-for-libfprint-port-for-2808-a658/55474/30

closed with #354311


Why favicons are loaded on every request?

Hello. I am using favicons and code snippets generated by https://realfavicongenerator.net
I have this in nuxt.config
{ rel: 'icon', type: 'image/png', sizes: '32x32', href: '/favicon-32x32.png' },
{ rel: 'icon', type: 'image/png', sizes: '16x16', href: '/favicon-16x16.png' },

And in result I see them loaded in DevTools on every route on the page.

Is this things related? https://github.com/nuxt/nuxt.js/issues/239

It is @iamdubx
It's Chrome which requests favicon.ico every time, I suggest to also add a favicon.ico in your static/ directory :)


Change IndicatorLightsCommunityExtensions relationships from recommends to supports

I think supports is the more appropriate relationship here over recommends since users installing this mod may not even care or be interested in any of the mods it supports except maybe one or two. It's basically a set of compatibility patches, it doesn't encourage using any particular mod.

LGTM, Merging


VS Code Fails to Save

Issue Type: Bug
This happens often when editing a Jupyter notebook.
Steps:

Open and edit an .ipynb file with the Jupyter extension enabled.
Save the file.
Open the integrated source control panel, make some commits, view a diff, close the diff view. (I think the interaction with the diff view causes the problem).
Continue editing the .ipynb.
Ctrl+S or File->Save As.

Observed:
Current changes in the editor are not written to disk. Save-As writes the file's previously saved state to disk. No error is shown.
Related:
This doesn't duplicate microsoft/vscode#114588 which is specific to untitled files. Might duplicate microsoft/vscode#126561.
VS Code version: Code 1.57.1 (507ce72a4466fbb27b715c3722558bb15afa9f48, 2021-06-17T13:28:32.912Z)
OS version: Darwin x64 20.5.0
Restricted Mode: No
Extensions (15)

Extension
Author (truncated)
Version

mdmath
goe
2.7.4

latex-workshop
Jam
8.19.2

python
ms-
2021.6.944021595

vscode-pylance
ms-
2021.6.3

jupyter
ms-
2021.6.999662501

vscodeintellicode
Vis
1.2.14

Hi @eric-mc2, could you please provide the Jupyter output content when the issue occurs?
Do you know if you are working with the Native Notebook interface? If you are unsure pasting a screenshot of your notebook would help us determine that.

Hi @claudiaregio,
I can consistently reproduce the issue. It seems to be triggered by editing the working version while the diff is open. I'm not sure which interface I'm using. The screenshot has more detailed steps.

jupyter-output.txt

@eric-mc2 This should be fixed when we migrate to the native notebook interface completely. Does it work if you click the save button in the notebook toolbar or if you close the diff and try to save?

Thanks for your feedback. This issue is addressed with new native support for editing notebooks. To opt into that experience see: https://github.com/microsoft/vscode-jupyter/wiki/Introducing-Native-Notebooks.


IntStreamEx.of(IntBuffer)

Hi Tagir,
since in jogl I am gonna handle GL resources through IntBuffers, it'd be nice to have the possibility to init a StreamEx from those

Sounds interesting. Will think about it. Similarly LongStreamEx.of(LongBuffer) could be implemented. Note however that buffer has internal state like current position and limit. I think the StreamEx implementation should not alter the state of the supplied buffer.

LongBuffer is not interesting but you can implement for it too if you want.
Jogl already avoid any internal state modification by creating/deleting resource at the given position buffer. For this purpouse there is put(int index, int value)

It seems that simplest implementation would be like IntStreamEx.range(buf.position(), buf.limit()).map(buf::get). You may check whether it works for you.

Yep and it'd be cool to have also just a simple IntStreamEx.range(), anyway I'd like something like:
IntStreamEx.of(textureName).forEach(...)

IntStreamEx.of(IntBuffer), LongStreamEx.of(LongBuffer), DoubleStreamEx.of(DoubleBuffer) are implemented. Current implementation is quite straight-forward, but it should be quite fast.

Awesome, thanks Tagir! :+1:


feat(mission_planner): add route safety checker

Description
Add a route safety checker that checks if the new given route is safe or not

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

I know it's still a draft, but it would be nice to add explanation about this reroute check in the documentation as well (just like Goal Validation)

@mitsudome-r Sure. Let me write a document about it after all of the related PR has been merged


Support different embedding types of model response

Description
Support different embedding types of model response
Related Issues
https://github.com/opensearch-project/neural-search/issues/1006
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] API changes companion pull request created.
[ ] Commits are signed per the DCO using --signoff.
[ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Can you provide sample request/response for each of new embedding type? Is the type configurable on the client side (neural search in this case), or model is smart enough to switch between types? Any changes required from user to use new type(s), for instance do they need to recreated model connector and index mapping?

Can you provide sample request/response for each of new embedding type? Is the type configurable on the client side (neural search in this case), or model is smart enough to switch between types? Any changes required from user to use new type(s), for instance do they need to recreated model connector and index mapping?

Sample of different embedding types:
{
    "float": [
        [
          -0.03933716,
          -0.04534912,
          -0.088256836,
          -0.084350586,
          ...
        ]
    ],
    "binary": [
        [
          -127,
          90,
          103,
          ...
        ]
    ],
    "int8": [
        [
          -50,
          -58,
          -113,
          ...
        ]
    ],
    "ubinary": [
        [
          1,
          218,
          231,
          ...
        ]
    ],
    "uint8": [
        [
          78,
          70,
          15,
          ...
        ]
    ]
}

The type is configurable in model side, in the connector specifically. When user wants to switch to a different embedding type, user needs to recreate a new model with different embedding type in the connector, also user should do a reindex to ensure the embeddings are using the new embedding type result, in this case, a new index should created and after the reindex user can specify alias on original index to new one. We don't consider modifying index mapping as we can only add new field in existing index mapping, not able to modify an existing field.


Decryption not working.

After running password protected pages through this, the Decrypt button that is generated is not actually functioning. I see the SHA hashes being generated on the appropriate pages so I know it's processing the pages correctly, it just won't actually allow a user to decrypt.

In the latest commit, I use WebCrypto API instead of CryptoJS to decrypt the pages.  Maybe you can try to revert the commit to see if it works.

Closing this issue, since it's not being addressed.


[BUG] corrupted data-rpvider code when npm run refine swizzle

Describe the bug

Steps To Reproduce
npm run refine swizzle
yes
you will see code is corrupted
Expected behavior
code must be correct
Packages
simple-rest
Additional Context
No response

Hey @vitali-bc, sorry for the issue! Looks like our swizzle command had some issues with the import type statements which are introduced with the latest release to our codebase. I've just opened up a PR to fix this issue. 🙏
Until the next release is done, you can check out the source code for @refinedev/simple-rest here to create your data provider 🚀

Hey @vitali-bc, sorry for the issue! Looks like our swizzle command had some issues with the import type statements which are introduced with the latest release to our codebase. I've just opened up a PR to fix this issue. 🙏
Until the next release is done, you can check out the source code for @refinedev/simple-rest here to create your data provider 🚀

Hi! Could you please look also inside the next BUG I opened? I think they are correlated...


 vbproj property isn't standard or might be invalid

The reason for the <RepositoryType> property is to specify the .nuspec <repository type= attribute value. I've never seen the value GitHub before; with GitHub projects, everyone uses git that I've seen. The <RepositoryType> value is referring to the protocol used to programmatically connect to the <repository url= URL.
https://docs.microsoft.com/en-us/nuget/reference/nuspec#repository shows an example which has a GitHub URL and a git repository type, so I'm pretty sure that's what it should be:
<?xml version="1.0"?>
<package xmlns="http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd">
    <metadata>
        ...
        <repository type="git" url="https://github.com/NuGet/NuGet.Client.git" branch="dev" commit="e1c65e4524cd70ee6e22abe33e6cb6ec73938cb3" />
        ...
    </metadata>
</package>

Fixed in Master


use asar to fix MAX_LENGTH problem on windows

https://github.com/atom/electron/blob/master/docs/tutorial/application-packaging.md
This can help to solve the MAX_LENGTH problem on windows, it's good to give it a try.

this is really cool !! This can solve MAX_LENGTH problem and unzip slowly problem too !


[TDVT] Update sample plugins in SDK

Added vendor-information and min-tableau-version to the manifest files in sample plugins. Updated the connector_plugin_manifest_latest.xsd.

Hi, @saugatt! Thanks for opening this PR!

In the file packaging/package/helper.py:

Line 19:22: E127 continuation line over-indented for visual indent
Line 15:37: E226 missing whitespace around arithmetic operator
Line 9:1: E302 expected 2 blank lines, found 1

In the file packaging/package/jar_jdk_packager.py:

Line 58:1: W391 blank line at end of file
Line 49:61: E226 missing whitespace around arithmetic operator
Line 49:32: E226 missing whitespace around arithmetic operator
Line 7:1: F401 '.connector_file.ConnectorFile' imported but unused

In the file packaging/package/jar_jdk_signer.py:

Line 85:26: E226 missing whitespace around arithmetic operator
Line 28:36: E226 missing whitespace around arithmetic operator

In the file packaging/package/package.py:

Line 23:121: E501 line too long (131 > 120 characters)
Line 22:121: E501 line too long (141 > 120 characters)
Line 21:121: E501 line too long (142 > 120 characters)
Line 21:84: E241 multiple spaces after ','
Line 20:121: E501 line too long (132 > 120 characters)
Line 19:121: E501 line too long (144 > 120 characters)
Line 15:121: E501 line too long (185 > 120 characters)

In the file packaging/package/xml_parser.py:

Line 174:1: W293 blank line contains whitespace
Line 174:1: W391 blank line at end of file
Line 164:121: E501 line too long (129 > 120 characters)
Line 164:52: E222 multiple spaces after operator
Line 163:121: E501 line too long (143 > 120 characters)
Line 155:1: W293 blank line contains whitespace
Line 153:121: E501 line too long (149 > 120 characters)
Line 134:1: W293 blank line contains whitespace
Line 126:9: F841 local variable 'schema' is assigned to but never used
Line 114:1: W293 blank line contains whitespace
Line 98:46: W291 trailing whitespace
Line 95:53: W291 trailing whitespace
Line 90:1: W293 blank line contains whitespace
Line 86:1: W293 blank line contains whitespace
Line 54:73: W291 trailing whitespace
Line 53:1: W293 blank line contains whitespace
Line 51:113: W291 trailing whitespace
Line 47:1: W293 blank line contains whitespace
Line 45:106: W291 trailing whitespace
Line 43:1: W293 blank line contains whitespace
Line 41:1: W293 blank line contains whitespace
Line 29:31: E262 inline comment should start with '# '
Line 29:30: E261 at least two spaces before inline comment
Line 28:28: E261 at least two spaces before inline comment
Line 27:31: E261 at least two spaces before inline comment
Line 14:1: E302 expected 2 blank lines, found 1
Line 12:121: E501 line too long (129 > 120 characters)
Line 4:41: E231 missing whitespace after ','
Line 4:1: F401 'defusedxml.ElementTree.ParseError' imported but unused

In the file packaging/package/xsd_validator.py:

Line 110:121: E501 line too long (139 > 120 characters)
Line 107:5: E722 do not use bare 'except'
Line 75:1: E302 expected 2 blank lines, found 1
Line 7:1: F401 '.connector_file.ConnectorFile' imported but unused
Line 5:1: F401 'xmlschema.validators.exceptions.XMLSchemaException' imported but unused

In the file packaging/tests/__init__.py:

Line 8:38: E231 missing whitespace after ','

In the file packaging/tests/jar_packager.py:

Line 60:29: W605 invalid escape sequence '\j'
Line 52:49: W605 invalid escape sequence '\p'
Line 52:41: W605 invalid escape sequence '\p'
Line 52:33: W605 invalid escape sequence '\s'
Line 52:30: W605 invalid escape sequence '.'

In the file packaging/tests/test_connector_file.py:

Line 15:1: W391 blank line at end of file
Line 4:1: E302 expected 2 blank lines, found 1

In the file packaging/tests/test_jar_signer.py:

Line 17:1: W293 blank line contains whitespace

In the file packaging/tests/test_package.py:

Line 7:1: F401 'package.package.main' imported but unused
Line 4:1: F401 'argparse' imported but unused

In the file packaging/tests/test_xml_parser.py:

Line 45:1: W391 blank line at end of file
Line 34:121: E501 line too long (125 > 120 characters)
Line 33:121: E501 line too long (143 > 120 characters)
Line 29:121: E501 line too long (142 > 120 characters)
Line 26:121: E501 line too long (130 > 120 characters)
Line 25:121: E501 line too long (143 > 120 characters)
Line 24:88: W291 trailing whitespace
Line 22:121: E501 line too long (147 > 120 characters)
Line 20:76: W291 trailing whitespace
Line 15:30: F841 local variable 'files_list' is assigned to but never used
Line 9:1: E302 expected 2 blank lines, found 1

In the file packaging/tests/test_xsd_validator.py:

Line 63:1: W293 blank line contains whitespace
Line 63:1: W391 blank line at end of file
Line 62:1: W293 blank line contains whitespace
Line 56:121: E501 line too long (132 > 120 characters)
Line 55:1: W293 blank line contains whitespace
Line 51:121: E501 line too long (149 > 120 characters)
Line 47:121: E501 line too long (126 > 120 characters)
Line 43:121: E501 line too long (131 > 120 characters)
Line 25:1: W293 blank line contains whitespace
Line 17:1: W293 blank line contains whitespace
Line 15:1: W293 blank line contains whitespace
Line 13:1: W293 blank line contains whitespace
Line 12:1: E302 expected 2 blank lines, found 1
Line 5:1: F401 'package.xsd_validator.get_xsd_file' imported but unused

In the file tdvt/test/tdvt_test.py:

Line 23:41: E231 missing whitespace after ','
Line 23:1: F401 'defusedxml.ElementTree.ParseError' imported but unused

For reference: Error Code Reference, PEP8, Python code style


TimeSpan parsing failed with NAOT

Describe the bug
When using animation in XAML from the Community Toolkit, the application crashes. I suppose in this lines:

Error text: Failed to create a Windows.Foundation.IReference1<TimeSpan> from the text '0:0:0.3'
To Reproduce

Install CommunityToolkit.WinUI.Animations package
Enable PublishAot in csproj
Use lines from the screenshot above

Expected behavior

Application does not crash. animations works correctly
Version Info

CsWinRT: 2.1.0-preview2
WinUI: 1.6-exp2
WinSDK: 10.0.22621.37-preview
NET: net8.0-windows10.0.22621
Windows: build 26100
Additional context

Should be fixed by https://github.com/microsoft/CsWinRT/pull/1684.  Will be publishing updated CsWinRT preview shortly.

Published https://www.nuget.org/packages/Microsoft.Windows.CsWinRT/2.1.0-prerelease.240801.1


[MSL] Support SPV_EXT_fragment_invocation_density in MSL 2.2

MSL 2.2 adds a new rasterization rate map type which maps between logical and screen coordinates. Using this new type with the FragCoord builtin should enable us to support the FragSizeEXT builtin from SPV_EXT_fragment_invocation_density. The FragInvocationCountEXT builtin, meanwhile, can be implemented in terms of the number of samples in the render target, assuming sample-rate shading is active. Since Metal doesn't actually support minSampleShading, we'd thus always return the number of samples as the invocation count.

It looks like Apple removed this incomplete feature from the MSL 2.2 headers. Maybe the next version will support this.

yep.. but we should reopen as it should have returned today in Xcode 11 GM as it's a new feature of A13 GPU..
see (https://twitter.com/gavkar/status/1171494278545018882)
also https://developer.apple.com/videos/play/tech-talks/608/

It does not seem like Metal's varying shading rate is remotely compatible with D3D or Vulkan. From what I understand it's varying rasterization rate with required resolve rather than varying shading rate (but fixed raster rate).

It does not seem like Metal's varying shading rate is remotely compatible with D3D or Vulkan. From what I understand it's varying rasterization rate with required resolve rather than varying shading rate (but fixed raster rate).

Part of it's the way it's implemented. Vulkan and D3D12's Tier 2 use an image to set the rate at which the fragment/pixel shader is invoked. Metal, however, uses a pair of piecewise linear functions, which cannot express everything that you can express with a shading rate image. Basically, Metal's functionality is greater than D3D12 Tier 1 VRS (which sets a constant rate for the whole render target) but lesser than Tier 2.

It does not seem like Metal's varying shading rate is remotely compatible with D3D or Vulkan. From what I understand it's varying rasterization rate with required resolve rather than varying shading rate (but fixed raster rate).

Part of it's the way it's implemented. Vulkan and D3D12's Tier 2 use an image to set the rate at which the fragment/pixel shader is invoked. Metal, however, uses a pair of piecewise linear functions, which cannot express everything that you can express with a shading rate image. Basically, Metal's functionality is greater than D3D12 Tier 1 VRS (which sets a constant rate for the whole render target) but lesser than Tier 2.

The other thing is that it's unclear if the rasterization rate map affects depth and stencil rendering. D3D12 is clear that its implementation of VRS does not. Vulkan does not seem to specify.


Distribution

add missing resitive heater + micro CHP to electricity distribution
restrict solar rooftop potential to 10m² per person
add new electricity demand of industry to electricity distribution
add option to add costs for gas distribution, currently assuming same costs for gas distribution as for electricity distribution

This looks great @lisazeyen! The only thing I had a question about was the rooftop versus old utility potentials.
You've assumed 100 Wp/m² for the PV density to get 1 kWp/person from 10m²/person, is that right?
Why do you take the minimum of the old p_nom_max and the rooftop potential?
According to the PyPSA-Eur paper, we allow PV to be built on CORINE land cover codes that include "artificial surfaces", where we use a density of 1.7 Wp/m², i.e. much lower than would be theoretically possible to allow for other land uses/conflicts etc. I guess we don't need to subtract the rooftop from this total since it is hopefully non-overlapping.

Yes, exactly I have assumed 100 Wp/m² for the PV density to get 1 kWp/person from 10m²/person. Great, I didn't know that there is now overlap. I took the minimum because even with 48 buses, sometimes the solar rooftop potential was reaching 33% of the old p_nom_max and I wanted to make sure, that when running a scenario with a higher spatial resolution the rooftop potential is not over estimated. But if there is no overlap, we don't have to take the minimum and also not subtract the rooftop potential from the solar utility one.


Check for an unpublishing explanation

gds-api-adapters will not forward an explanation parameter
if the value is nil, this raises an exception because this key
is expected for withdrawals so an additional condition is needed to check for an explanation otherwise this data migration will create failing Sidekiq jobs, retries and errors.

:+1:


Route prefixing

As a feature, it would probably benefit users to be able to define the base route on which Voyager exists. As it stands, all routes are prefixed with "admin".
While this works, some users may not want something quite so obvious, or they may require a means by which they can change this prefix to something else in order to prevent conflicts on existing installations.
This branch seeks to correct that by adding a configuration value that users may change. All routes declared in each view make use of this by leveraging route aliasing. Tests have been modified to take all of this into account.
The Media Uploader Javascript has also been modified to use a class name which can take in an optional object that defines the base url on which the AJAX routes exist.
Testing in a local Valet installation yields satisfactory results, but may require further investigation before merging.
EDIT: All tests passing, Valet installation yields satisfactory results under /voyager route prefix.

Looks like the latest commits addressing the icon fixes are causing conflicts. Will resolve manually later tonight.

Thanks man!

For flexibility, can we change the config to open it up for any route configuration?
So instead of:
$router->group(['prefix' => config('voyager.routes.prefix', 'admin'), 'namespace'=>$this->routeNamespace], function(){
    include __DIR__.'/routes.php';
});

you'll end up with something like:
routeConfig = config('voyager.routes.config', array());
// set sensible defaults
if (!array_key_exists('prefix', routeConfig)) {
    routeConfig['prefix'] = 'admin';
}
if (!array_key_exists('namespace', routeConfig)) {
    routeConfig['namespace'] = $this->routeNamespace;
}
$router->group(routeConfig, function(){
    include __DIR__.'/routes.php';
});

Note: This is untested code... please test before committing it!

I'll also look into making this an interactive part of the installation process.
As it stands, if you run the installer and then change your route prefix, you'll have to also change the paths in the menu builder. In order for the paths to be correct, the route prefix needs to be set before running the installer.


make on Windows

Using the new makefiles for 1.5rc, it should be relatively simple to support windows builds via make, using a bash terminal emulator (such as msys2) with a windows install of make (ie make from gnuwin32).
Required changes / differences for windows:

[x] Alternate host compiler per OS / do not provide one on windows and let nvcc choose.
[x] use .obj for object files, rather than .o
[x] do not pass -std=c++11 or similar when on windows.
[x] ~do not link using -L$(LIB_DIR) on windows.~ Do not pass -L via -Xlinker
[x] explicitly specify the location of xsltproc as ../../tools/XSLTProcessor.exe
[x] Different order of arguments for xsltproc usage on windows, $(XSLTPROC) $(XML_MODEL_FILE) $< $@
[x]  Do not specify LD_RUN_PATH on windows, DLLs are provided next to the executable files.

This is resolved by 2ad84e6 (rc1.5/alternate-makefiles)


Update Thorin to fit app v3

A list of changes that were needed for getting in sync with app-v3

Field

Added option to display the error and description messages at the top or bottom of the content

Input

Decrease with of "state" border to 1px
Added property to control spacing inside input (prefix, input, suffix)

Select

Added react-transition-state to remove the menu when closed
Changed the border radius to match Input
Moved the "clear" & "open/close" button to it's own container
Added options for controlling the "size" attribute of the input element for when the input is in a flexbox
Select menu width is set to min-width of the select parent but will expand to fill the space needed to show the options without cutting option off.
Added option to displace menu on top or bottom of select container
Made the scrollbar tasteful looking
Added option for message when no selection has been made
Added option to set max number of rows to display in menu
Added a "node" option to "Select Options" which can be displayed in place of the label

TextArea

decreased the "status" border width to be the same as
fixed the background color

Latest update

MenuPlacement

A wrapper for menus that gives the option of using a portal to display the menu.

Input

Added option the change the element type of prefix and suffix labels. This is needed so that if we embed a control element in the Input, a click on the control element will not cause the input to gain focus.
Added status "dot"

TextArea

Added status "dot"

Select

Implemented MenuPlacement
Added preEnter state to useTransition so that it gives and extra frame for the menu to be mounted. This is an extra precaution for when the menu immediately appears with no transition.
Added intersectional observer to close the Select to close the menu when it is not visible. Needed for portal so that menu does not remain on screen when Select in hidden.

the enter animation for the messages example in the select doc randomly doesn't animate

I switched the menu away from being mounted/unmounted since that's the only way to guarantee that the transition will always run.

how is the status dot activated for input?

Properties:
showDot - makes the status dot active
validated - makes the status dot green
error - makes the status dot red
CSS
focus-within makes the status dot blue


Checksum classes

Description of changes:
Adds implementations of all of the supported Checksum algorithms as Digest like classes.  These are all basically just thin wrappers, but give us concrete classes to make future changes on if needed.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Moved checksum classes to AWS.  Closing in favor of: https://github.com/alextwoods/aws-sdk-ruby-v4/pull/30


Load Likes/Dislikes with filters

See #2
Use the api/liked end-point but add filtering capabilities.
AP end point filtering capabilities

[x] itemKey - load for specific items

[x] type - load like/dislike

[x] attributedTo - load by specific accounts

[x] Implement api.LoadVotes repository method.

Implemented loading the votes from the API in 9d38cb42


outdated Moby reference to be updated with Containerd

https://docs.microsoft.com/en-us/azure/aks/concepts-clusters-workloads#nodes-and-node-pools refers to Moby Whereas Containerd is used by default since 1.19, see https://docs.microsoft.com/en-us/azure/aks/cluster-configuration#container-runtime-configuration
See also #69327
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a445f8cc-6581-ad43-1dba-719a94eda81a
Version Independent ID: 31280746-d8de-91b4-d430-91693c2e869d
Content: Concepts - Kubernetes basics for Azure Kubernetes Services (AKS) - Azure Kubernetes Service
Content Source: articles/aks/concepts-clusters-workloads.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

@ezYakaEagle442
Thanks for your feedback! We will investigate and update as appropriate.

@ezYakaEagle442
Thanks for your feedback! We will investigate and update as appropriate.

@ezYakaEagle442
Thank you for pointing this out! I've assigned this issue to the author to investigate and update as needed.
Nodes and node pools documentation:

Container runtime configuration documentation:
AKS clusters using Kubernetes version 1.19 node pools and greater use containerd as its container runtime. AKS clusters using Kubernetes prior to v1.19 for node pools use Moby (upstream docker) as its container runtime.

@ezYakaEagle442
Thank you for pointing this out! I've assigned this issue to the author to investigate and update as needed.
Nodes and node pools documentation:

Container runtime configuration documentation:
AKS clusters using Kubernetes version 1.19 node pools and greater use containerd as its container runtime. AKS clusters using Kubernetes prior to v1.19 for node pools use Moby (upstream docker) as its container runtime.

thank you @ezYakaEagle442 for the feedback.
The article has been updated to address your feedback.
#please-close


AttributeError: 'PyiCloudService' object has no attribute 'requires_2fa'

I'm getting a crash when trying to download photos:
$ ./download_photos.py my-photos --username<EMAIL_ADDRESS>--password REDACTED
Traceback (most recent call last):
  File "./download_photos.py", line 252, in <module>
    download()
  File "/home/hugo/.local/share/virtualenvs/icloud/lib/python3.6/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/home/hugo/.local/share/virtualenvs/icloud/lib/python3.6/site-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/home/hugo/.local/share/virtualenvs/icloud/lib/python3.6/site-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/hugo/.local/share/virtualenvs/icloud/lib/python3.6/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "./download_photos.py", line 91, in download
    smtp_username, smtp_password, smtp_host, smtp_port, smtp_no_tls, notification_email)
  File "/home/hugo/tmp/icloud_photos_downloader/authentication.py", line 10, in authenticate
    icloud = PyiCloudService(username, password)
  File "/home/hugo/.local/share/virtualenvs/icloud/lib/python3.6/site-packages/pyicloud/base.py", line 192, in __init__
    self.authenticate()
  File "/home/hugo/.local/share/virtualenvs/icloud/lib/python3.6/site-packages/pyicloud/base.py", line 211, in authenticate
    data=json.dumps(data)
  File "/home/hugo/.local/share/virtualenvs/icloud/lib/python3.6/site-packages/requests/sessions.py", line 555, in post
    return self.request('POST', url, data=data, json=json, **kwargs)
  File "/home/hugo/.local/share/virtualenvs/icloud/lib/python3.6/site-packages/pyicloud/base.py", line 100, in request
    self._raise_error(code, reason)
  File "/home/hugo/.local/share/virtualenvs/icloud/lib/python3.6/site-packages/pyicloud/base.py", line 105, in _raise_error
    if self.service.requires_2fa and \
AttributeError: 'PyiCloudService' object has no attribute 'requires_2fa'

My env:
certifi==2<IP_ADDRESS>
chardet==3.0.4
click==6.7
docopt==0.6.2
future==0.16.0
idna==2.6
keyring==8.7
keyrings.alt==1.3
pyicloud==0.9.1
python-dateutil==2.6.1
pytz==2017.2
requests==2.18.4
schema==0.6.6
six==1.11.0
tqdm==4.17.1
tzlocal==1.4
urllib3==1.22

Ah sorry, this is a bug in the pyicloud library, but I've included a fix for it in the script.

Please make sure you're using the latest version of the script.
Reinstall pyicloud:

pip uninstall pyicloud
pip install -r requirements.txt

Hope that helps!

Please reopen this issue if you are still experiencing problems.

Thanks! I did have a few issues related to login, but I'll follow up upstream, since they're strictly pyicloud-related.


fix: correct safelyMount check

What this PR does / why we need it:

do not output the trailing delimiter when readlink
split volume path correctly

Special notes for your reviewer:
Does this PR introduce a user-facing change?

Codecov Report

Merging #1165 (4abcc8b) into main (0f00a8c) will increase coverage by 0.15%.
Report is 4 commits behind head on main.
The diff coverage is 57.14%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##             main    #1165      +/-   ##
==========================================
+ Coverage   38.83%   38.98%   +0.15%
==========================================
  Files          25       25
  Lines        1970     1980      +10
==========================================
+ Hits          765      772       +7
- Misses       1103     1106       +3
  Partials      102      102

Files
Coverage Δ

...k-manager/handler/localdiskclaim/localdiskclaim.go
69.23% <100.00%> (ø)

pkg/local-disk-manager/filter/filter_disk.go
51.66% <70.00%> (+1.66%)
:arrow_up:

...manager/handler/localdiskvolume/localdiskvolume.go
7.97% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Syntax highlight inside HTML

VSCode Version: 1.12.1
OS Version: Windows 10 Enterprise, version 1607, OS Build: 14393.1198

Steps to Reproduce:

Open an index.html file
Write a <script> tag with attribute type="text/x-template" or type="text/html"
Inside <script> write some HTML
Result:

Note: until this build of VSCode it was working properly.

Duplicate of #25920, will  be in the next recovery build.


#685 Add spring cloud config

Hello everyone,
I just implement the spring cloud config server for centralizing config that will be used in other services.
Please help me review this PR, thanks.

For simplicity, we will duplicate shared configuration value in applications.properties or in docker-compose file. In k8s environment can leverage ConfigMap. So that we don't need to maintain an extra config service


Draft: Init UI

created the launcher window:
Functions -> working as planed
Design -> Not Final

LGTM; still needs Unit testing tho; but merging for now


Docker api is not listing containers

Hi,
We have installed Docker on RHEL  7 behind the firewall. Created few containers from Dockerfiles.
I can see docker images but when I do curl -X GET http://:4243/images/json it is showing nothing. (i.e. [])
Basically I am trying to spin docker slave machines from Jenkins and Jenkins master is unable to find any images on Docker host.
Information about the Docker setup.
Docker version:
[root@XXXXXXX ~]# docker version
Client:
Version:         1.10.3
API version:     1.22
Package version: docker-common-1.10.3-46.el7.10.x86_64
Go version:      go1.6.2
Git commit:      2a93377-unsupported
Built:           Fri Jul 29 13:45:25 2016
OS/Arch:         linux/amd64
Server:
Version:         1.10.3
API version:     1.22
Package version: docker-common-1.10.3-46.el7.10.x86_64
Go version:      go1.6.2
Git commit:      2a93377-unsupported
Built:           Fri Jul 29 13:45:25 2016
OS/Arch:         linux/amd64
[root@XXXXXX ~]# docker info
Containers: 36
Running: 6
Paused: 0
Stopped: 30
Images: 120
Server Version: 1.10.3
Storage Driver: devicemapper
Pool Name: docker-253:4-263325-pool
Pool Blocksize: 65.54 kB
Base Device Size: 10.74 GB
Backing Filesystem: xfs
Data file: /dev/loop0
Metadata file: /dev/loop1
Data Space Used: 4.704 GB
Data Space Total: 107.4 GB
Data Space Available: 6.691 GB
Metadata Space Used: 9.654 MB
Metadata Space Total: 2.147 GB
Metadata Space Available: 2.138 GB
Udev Sync Supported: true
Deferred Removal Enabled: false
Deferred Deletion Enabled: false
Deferred Deleted Device Count: 0
Data loop file: /var/lib/docker/devicemapper/devicemapper/data
WARNING: Usage of loopback devices is strongly discouraged for production use. Either use --storage-opt dm.thinpooldev or use --storage-opt dm.no_warn_on_loop_devices=true to suppress this warning.
Metadata loop file: /var/lib/docker/devicemapper/devicemapper/metadata
Library Version: 1.02.107-RHEL7 (2016-06-09)
Execution Driver: native-0.2
Logging Driver: journald
Plugins:
Volume: local
Network: bridge null host
Authorization: rhel-push-plugin
Kernel Version: 3.10.0-327.28.2.el7.x86_64
Operating System: Red Hat Enterprise Linux Server 7.2 (Maipo)
OSType: linux
Architecture: x86_64
Number of Docker Hooks: 2
CPUs: 2
Total Memory: 7.64 GiB
Name: XXXXXXXXXXXXX
ID: KDAL:PQLB:TFMH:T7V2:KL3Z:AXUJ:YCD6:KUJT:CPUI:HFKW:XDH6:LMJN
WARNING: bridge-nf-call-iptables is disabled
WARNING: bridge-nf-call-ip6tables is disabled
Registries: registry.access.redhat.com (secure), docker.io (secure)
Port 4243 is listening.
[root@XXXXXX ~]# netstat -tunlp | grep 4243
tcp6       0      0 :::4243                 :::*                    LISTEN      15370/docker-curren
There are images available:
[root@XXXXXXX ~]# docker images
REPOSITORY                        TAG                 IMAGE ID            CREATED             SIZE
testslave                         latest              6f516138e4d5        19 hours ago        426.1 MB
               8a09033510d5        20 hours ago        196.7 MB
               4286e0891b8b        21 hours ago        218.2 MB
build_slave                       latest              b761b6b52081        23 hours ago        635.5 MB
jenkins-1                         latest              34d24490b12b        43 hours ago        892.2 MB
new_slave                         latest              90afbeb14b24        45 hours ago        892.2 MB
               b10c60459ea3        46 hours ago        892.2 MB
Please guide me how to access these images over API.
Thanks,
Rakesh

*http://:4243/images/json is http://hostname:4243/images/json

You are using a forked version of Docker, so I'm not sure we can provide much help.
Are you sure the docker client is talking to the engine on the TCP port? Typically unless you configure it otherwise it will connect to /var/run/docker.sock.
curl localhost:32769/images/json                            )git:(use_docker_mounts_api
[{"Id":"sha256:2b8fd9751c4c0f5dd266fcae00707e67a2545ef34f9a29354585f93dac906749","ParentId":"","RepoTags":["busybox:latest"],"RepoDigests":["busybox@sha256:a59906e33509d14c036c8678d687bd4eec81ed7c4b8ce907b888c607f6a1e0e6"],"Created":1466724217,"Size":1092588,"VirtualSize":1092588,"Labels":{}}]

Closing since this is not really a Docker issue.


docs: playwright component testing instructions

Thanks but I don’t think this should go in the official docs as it would also required to be maintained to be up to date 🙂
I would recommend you to write an article instead


Merge pull request #1 from nuxt/dev

merge

Types of changes

[ ] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[ ] I have added tests to cover my changes (if not applicable, please state why)
[ ] All new and existing tests are passing.

121221212121212


It is not able to decrypt file which are encrypted by rclone.

I have rclone encrypted file. And when I use this code to decrypt, it shows error.
Any way to use this to decrypt rclone encrypted file??

can you show me your code and the error?

To decrypt a file:
from rclone import Crypt
crypt = Crypt('passwd1', 'passwd2')
crypt.File.file_decrypt('encrypted_file.bin', 'new_decrypted_file')

And you should note that the 'passwd1' and 'passwd2' is not the strings in rclone config file. You should use the passwd when you create the rclone crypt storage

yes, i'll add this function in the future.

Now you can use passwords in configuration file directly.
crypt = Crypt(passwd1, passwd2, passwd_obscured = True)


Sidebar database explorer only shows tables and views

Describe the bug
The only objects I'm shown in my sidebar database explorer are tables and views.
Expected behavior
I expected to see my Stored Procedures, Triggers, Assembly, etc, that are in my databases.
Desktop (please complete the following information):

SQLTools Version v0.17.18
VSCode Version: 1.33.1
Dialect Used: MSSQL 2016
OS: Windows

Additional context
Querying works though, I did not test yet with other dialects as I'd have to set up a DB for this.

That's expected. I didn't develop to list stored procedures yet for mssql, I need to put some effort on it.
Also this is a good first issue, someone can just add the queries to retrieve that information and it will start to work.
Would you like to try @weltherrschaf ? I can provide some guidance

Hi @weltherrschaf!
How is it going with the extension? Is it working as expected now? Hope so!
Just came to remember, if you like the project, please consider a donation or reviewing it on VSCode marketplace. That you help it to keep evolving.
Thanks!


Fix wemo discovery

Description:
Wemo would create their own discovery objects that mimicked format of the discovery component. This was missed in the upgrade when I updated the discovery component format.
CC @pavoni @adgelbfish

Cool - that explains what I was seeing. Thanks!


Jib CLI integration tests dump too much garbage on Kokoro

We should make Jib CLI auto-detect the terminal type and disable rich progress if necessary.
> Task :jib-cli:integrationTest
Task ':jib-cli:integrationTest' is not up-to-date because:
  No history is available.
Starting process 'Gradle Test Executor 8'. Working directory: /tmpfs/src/github/jib/jib-cli Command: /usr/lib/jvm/java-8-oracle/bin/java -D_JIB_DISABLE_USER_AGENT=true -Djava.security.manager=worker.org.gradle.process.internal.worker.child.BootstrapSecurityManager -Dorg.gradle.native=false -Xmx512m -Dfile.encoding=UTF-8 -Duser.country=US -Duser.language=en -Duser.variant -ea -cp /tmpfs/tmp/.gradle/caches/5.2.1/workerMain/gradle-worker.jar worker.org.gradle.process.internal.worker.GradleWorkerMain 'Gradle Test Executor 8'
Successfully started process 'Gradle Test Executor 8'

com.google.cloud.tools.jib.cli.cli2.JarCommandTest > testNoDependencyJar_packagedMode_toDocker STANDARD_OUT
    [WARN] Base image 'gcr.io/distroless/java' does not use a specific image digest - build may not be reproducible
    Executing tasks:
    [                              ] 0.0% complete
    > building image to Docker daemon

    Executing tasks:
    [                              ] 0.0% complete
    > pulling base image manifest

    Executing tasks:
    [                              ] 0.0% complete
    > pulling base image manifest
    > launching application layer builders

    Executing tasks:
    [                              ] 0.0% complete
    > pulling base image manifest
    > building jar layer

    Executing tasks:
    [======                        ] 20.0% complete
    > pulling base image manifest

    Using base image with digest: sha256:90596f62a8ec0701d00845b85dfccf7f53b5e0bb3c49e275d7f19ea6c3e4565d
    Executing tasks:
    [======                        ] 20.0% complete
    > pulling base image manifest

    Executing tasks:
    [======                        ] 20.0% complete
    > pull container configuration sha256:8302d62f8...

    Executing tasks:
    [=========                     ] 30.0% complete
    > pulling base image manifest

    Executing tasks:
    [============                  ] 40.0% complete
    > building image to Docker daemon

    Executing tasks:
    [============                  ] 40.0% complete
    > scheduling obtaining base images layers

    Executing tasks:
    [============                  ] 40.0% complete
    > launching base image layer pullers

    Executing tasks:
    [============                  ] 40.0% complete
    > checking base image layer sha256:31eb28996804...

    Executing tasks:
    [============                  ] 40.0% complete
    > checking base image layer sha256:31eb28996804...
    > checking base image layer sha256:e59bd8947ac7...

    Executing tasks:
    [============                  ] 40.0% complete
    > checking base image layer sha256:31eb28996804...
    > checking base image layer sha256:e59bd8947ac7...
    > checking base image layer sha256:e708be98c58f...

I think jib-gradle-plugin has the same issue. When I pipe a Gradle run into a file (e.g., gradle jib > a.log 2>&1), Jib still makes rich output, while Gradle itself doesn't. OTOH, jib-maven-plugin works as expected.

Unfortunately for jib-gradle-plugin, I was not able to find a way to determine if a Gradle run is (practically) attached to a console. I was curious why jib-maven-plugin checks System.console() != null while jib-gradle-plugin doesn't. A Gradle build (hence the Jib plugin code) by default runs with the daemon process, so System.console() is always null: https://github.com/gradle/gradle/issues/1251
If I run Gradle with --no-daemon and some shenanigans to really run Gradle without creating a daemon, I verified that System.console() returns a non-null console.


Stocks demo becomes optimistic on restart

Put the stocks demo in pessimistic mode.
Hit the back button to dismiss the app.
Restore the app. Optimism prevails.

We're probably not storing the optimistic/pessimistic setting.

Dupe of #1233


Calling plist_options is deprecated! Use service.require_root instead.

brew doctor output
brew doctor
Warning: Calling plist_options is deprecated! Use service.require_root instead.
Please report this issue to the mongodb/brew tap (not Homebrew/brew or Homebrew/homebrew-core), or even better, submit a PR to fix it:
  /opt/homebrew/Library/Taps/mongodb/homebrew-brew/Formula/mongodb-community@4.2.rb:47

Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Some installed formulae are deprecated or disabled.
You should find replacements for the following formulae:
<EMAIL_ADDRESS>
Warning: Unbrewed header files were found in /usr/local/include.
If you didn't put them there on purpose they could cause problems when
building Homebrew formulae, and may need to be deleted.

Leaving kegs unlinked can lead to build-trouble and cause formulae that depend on
those kegs to fail to run properly once built. Run `brew link` on these:
  mysql

Verification

[X] My "brew doctor output" above says Your system is ready to brew. and am still able to reproduce my issue.
[X] I ran brew update twice and am still able to reproduce my issue.
[X] This issue's title and/or description do not reference a single formula e.g. brew install wget. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.

brew config output
brew config
HOMEBREW_VERSION: 3.6.21-140-g82a3af6
ORIGIN: https://github.com/Homebrew/brew
HEAD: 82a3af6ce1a4b02ab28a046e54fb6923bac833e7
Last commit: 40 minutes ago
Core tap origin: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 2a94737cfccfc5f87dcea905232b29eeb09091fd
Core tap last commit: 2 weeks ago
Core tap branch: master
Core tap JSON: 15 Feb 08:34 UTC
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_MAKE_JOBS: 10
Homebrew Ruby: 2.6.10 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: 10-core 64-bit arm_firestorm_icestorm
Clang: 14.0.0 build 1400
Git: 2.39.2 => /opt/homebrew/bin/git
Curl: 7.86.0 => /usr/bin/curl
macOS: 13.2-arm64
CLT: N/A
Xcode: 14.2
Rosetta 2: false

What were you trying to do (and why)?
brew upgrade
What happened (include all command output)?
Warning: Calling plist_options is deprecated! Use service.require_root instead.
Please report this issue to the mongodb/brew tap (not Homebrew/brew or Homebrew/homebrew-core), or even better, submit a PR to fix it:
  /opt/homebrew/Library/Taps/mongodb/homebrew-brew/Formula/mongodb-community@4.2.rb:47

Error: Not upgrading 1 pinned package:
<EMAIL_ADDRESS>5.7.41
==> No packages to upgrade

What did you expect to happen?
Upgrade brew
Step-by-step reproduction instructions (by running brew commands)
1/ Open terminal,
2/ type `brew update`
3/ type `brew upgrade`

Error appears

Please report this issue to the mongodb/brew tap (not Homebrew/brew or Homebrew/homebrew-core)


Warning position is wrong when the warning is in script and TypeScript parser is used

Before You File a Bug Report Please Confirm You Have Done The Following...

[X] I have tried restarting my IDE and the issue persists.
[X] I have updated to the latest version of the packages.

What version of ESLint are you using?
8.43.0
What version of eslint-plugin-astro are you using?
0.27.1
What did you do?

Configuration
{
  "root": true,
  "extends": [
    "eslint:recommended",
    "plugin:@typescript-eslint/recommended",
    "plugin:astro/recommended"
  ],
  "parserOptions": {
    "ecmaVersion": 2022,
    "parser": "@typescript-eslint/parser"
  }
}

<script>

  const foo = document.querySelector('foo')!
  console.log(foo)
</script>

What did you expect to happen?
eslint . outputs
4:14  warning  Forbidden non-null assertion  @typescript-eslint/no-non-null-assertion

What actually happened?
eslint . outputs
2:14  warning  Forbidden non-null assertion  @typescript-eslint/no-non-null-assertion

Link to Minimal Reproducible Example

Open https://github.com/sapphi-red-repros/eslint-plugin-astro-script-ts-pos
npm i
npm run lint

Additional comments
The warning position is correct for .ts files. So I thought this is a bug in eslint-plugin-astro instead of typescript-eslint.

Thanks for this report. I will fix it.

Thank you!


Made JWT input be string for make-user-data

In PR#321, I switched the '--jwt' input to make-user-data be a filename instead of a string.  But other commands use JWTs as strings, so make-user-data should follow that convention.

Thanks for catching the inconsistency in the CLI spec.  I totally missed it in PR 321.

Added latest fix and squashed commits in new PR: #331


autobahn.Session

Hi there,
How would I do something like this:
var conn = new autobahn.Session('ws://localhost:8080',
        function() {
            console.warn('WebSocket connection open');
        },
        function() {
            console.warn('WebSocket connection closed');
        },
        {'skipSubprotocolCheck': true}

I've gotten this example from(http://socketo.me/docs/push).
It's implemented and it works. But now I'm trying to fit this in using angular-wamp.
Can you tell me how I get it working?

Angular-wamp only works with a WAMPv2 router. Your example looks like it's for v1.

Yeah it is.


How to @Autowired @DubboReference bean（怎样注入一个@DubboReference声明过的bean）

[x] I have searched the issues of this repository and believe that this is not a duplicate.
[x] I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

Dubbo version: 2.7.8
Operating System version: Mac OS MoJave 10.14.2
Java version: 1.8.0_151

Steps to reproduce this issue

config

@Configuration
public class DubboServiceReferences {

    @DubboReference(version = "${serverside.userservice.version}")
    UserService userService;

    @DubboReference(version = "${serverside.greetservice.version}")
    GreetingServerService greetingServerService;

}

@RestController
@RequestMapping(Constants.WEB_API_PREFIX + "/web")
public class WebController {

    @Autowired
    private GreetingServerService greetingServerService;

    @Autowired
    private UserService userService;
}

error

Description:

Field greetingServerService in com.xxx.clientside.web.controller.WebController required a bean of type 'com.xxx.serverside.facade.service.GreetingServerService' that could not be found.

The injection point has the following annotations:
	- @org.springframework.beans.factory.annotation.Autowired(required=true)

Expected Result
I want to centrally manage all @DubboReferences into one class, so that the maintenance of the version number and the configuration of some parameters are more intuitive.It seems that the bean declared by @DubboReference cannot be injected through @Autowried.
我想集中管理所有的DubboReference到一个类里，这样版本号的维护以及一些参数配置比较直观。
目前看来@DubboReference声明的bean并不能通过@Autowried进行注入。
Actual Result
Description:

Field greetingServerService in com.xxx.clientside.web.controller.WebController required a bean of type 'com.xxx.serverside.facade.service.GreetingServerService' that could not be found.

The injection point has the following annotations:
	- @org.springframework.beans.factory.annotation.Autowired(required=true)

This can work in Dubbo 3: https://github.com/apache/dubbo/pull/7383
This kind of reference annotation configuration is very clear and can be recommended to everyone.

结合  xml 配置文件，可以解决你这样的需求

如果一定要使用注解，可以这样来解决；
@Bean(ReferenceAnnotationBeanPostProcessor.BEAN_NAME) 	public ReferenceAnnotationBeanPostProcessor processor() 	{ 		ReferenceAnnotationBeanPostProcessor processor = new ReferenceAnnotationBeanPostProcessor(); 		processor.setOrder(Ordered.HIGHEST_PRECEDENCE); 		return processor; 	}

The above answer should solve your problem, temporarily close the issue, if there is still a problem, you can reopen it.


Add additional flags to flags extracted from compilation database

First of all, amazing project and great work!
Parsing compile_commands.json is sometimes not enough. The cross-compiling toolchain comes with many predeterminated options it was internally configured with, like --sysroot= and has a different set of predefined preprocessing macros depending on slight compile flags that are passed to the compiler. I could potentially generate:
$ something-something-gcc -mcpu=cortex-m0 -mthumb -mabi=aapcs -mfloat-abi=soft -dM -E -x c /dev/null | sed -nE '/#define +([^ ]+) +(.+)$/{ s//-D\1=\2/; s/"/\\"/g; s/.*/"&"/; p; }' | sed 's/$/,/' |
"-D__DBL_MIN_EXP__=(-1021)","-D__HQ_FBIT__=15",".... etc. etc. ",-Dsomething=something"
$ something-something-gcc -mcpu=cortex-m0 -mthumb -mabi=aapcs -mfloat-abi=soft -Os -dM -E -x c /dev/null -v |& sed -zE 's/.*-isysroot ([^ ]*).*/"--sysroot=\1"/'
"--sysroot=/some/path/to/sysroot/something-eabi"

and then add all these flags to fallbackFlags. But, sadly, fallbackFlags is not used when compile_commands.json is found, so then, sadly, I would have to remove compile_commands.json and work without database.
Could it be possible to append custom flags with the flags extracted from compile_commands.json? Like "initializationOptions": { "extraDatabaseFlags": ["-Dfoo=1", "--sysroot=somelocation"] }? What is the preferred way I should take? I believe current workaround I'll do will be cat compile_commands.json | jq '.[].command += " -Dfoo=1 --sysroot=/some/path"' > compile_commands.json. The ideal solution would be to extract these flags by clangd itself from the compiler present in compile_commands.json - I do not wish to aim that high, just a simple "append flags" will be just enough for me.
I read https://github.com/thomasjo/atom-ide-cpp/issues/16 https://reviews.llvm.org/D53641 https://reviews.llvm.org/D34947 https://reviews.llvm.org/D53641 , but I do not understand, I think it's about a extraFlags option that has different purpose. I tried going through source code, I believe in here protocol.c should be added O.mapOptional("extraDatabaseFlags", Opts.extraDatabaseFlags), then here ClangdLSPServer would need Params.initializationOptions.extraDatabaseFlags be added, and in GlobalCompilationDatabase.cpp additional constructor parameter and class member and then finally in here they would have to be added to Argv maybe, right?

Does the Config mechanism in clangd 11 (see CompileFlags: example) meet your needs?

Yes! I installed clangd11 and tested it - yes, the CompileFlags: Add: array is added after flags extracted from compile_commands.json. Didn't knew about this option. Thank you!


have _brew in my fpath but it does not work unless calling compinit

Environment: homebrew-installed zsh
And in the output of echo $fpath, /usr/local/share/zsh/site-functions does show up, where I symlinked _brew and _brew_cask into this directory.
And if I call rm -f ~/.zcompdump; compinit, although it's a little bit slow but when I press tab it works.
However, after restarting my terminal, it stop working again unless I use the same command above.

Are you sure you're running the Homebrew-installed zsh in all cases? If your default shell is still pointing at /usr/bin/zsh, then you'll be running the system zsh in new terminal sessions, even if which zsh reports the Homebrew-installed zsh. This behavior sounds consistent with running a system zsh which gets /usr/local/share/zsh/site-functions placed on $fpath after OMZ initialization/compinit is run.
Could you post the output of omz_diagnostic_dump as a gist so we can take a look at your config files and help you debug this?

I just started using OMZ (it's great BTW) and ran into this issue tonight after updating Homebrew. The completions were working before so I remove the group write bit from the two directories listed by compaudit.
chmod g-w /usr/local/share/zsh
chmod g-w /usr/local/share/zsh/site-functions

Sorry about the late and here's my output:


Include the file name when reporting Dhall errors

For example, if I modify packages.dhall so that there is a syntax error:
$ spago build
spago:
Error: Invalid input

2:9:
  |
2 | Welcome to your new Dhall package-set!
  |         ^
unexpected 't'
expecting ':', '=', or whitespace

It would be helpful if the error message included the file name "packages.dhall". Likewise for errors involving spago.dhall.

@hdgarrood wow, great catch.
I'm not sure where the problem is - since the spago.dhall imports packages.dhall, the error happens on the Dhall side of things (it should be this line), but I'm pretty sure there's an option to get nicer error reporting with filenames (i.e. I think the fix could just be replacing inputExpr with inputFile on that line)

Fix up in #241


os: Exit does not respect deferred functions making any cleanup code useless

What version of Go are you using (go version)?

$ go version
go version go1.14.1 windows/amd64

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
go env Output
set GO111MODULE=auto
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\anonymous\AppData\Local\go-build
set GOENV=C:\Users\anonymous\AppData\Roaming\go\env
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\anonymous\go
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=c:\go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=c:\go\pkg\tool\windows_amd64
set GCCGO=gccgo
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=C:\Users\anonymous\Desktop\an\go.mod
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\anon~1\AppData\Local\Temp\go-build078526234=/tmp/go-build -gno-record-gcc-switches

What did you do?
I called os.Exit(1) on SIGINT
https://play.golang.org/p/_Py0WToAf8v
(Local testing is better, playground does not like sleeps and have no way to cause a SIGINT).
What did you expect to see?
Golang runs all deferred cleanup routines. This would allow every go routine to register it's own cleanup function if you think separation of concerns is a thing.
What did you see instead?
No Cleanup function is called at all, but that is important if you're writing to files in other goroutines. Panic have a similiar issue.
See also: #4101

This is working as intended (and it's well documented, both in the spec section about defer and in the os.Exit documentation); so I don't believe this is a bug.

I called os.Exit(1) on SIGINT
This would allow every go routine to register it's own cleanup function

In close_handler, call runtime.Goexit() instead of os.Exit(), the former does run deferred functions.
Would that satisfy your use case?

This is working as intended (and it's well documented, both in the spec section about defer and in the os.Exit documentation); so I don't believe this is a bug.

I called os.Exit(1) on SIGINT
This would allow every go routine to register it's own cleanup function

In close_handler, call runtime.Goexit() instead of os.Exit(), the former does run deferred functions.
Would that satisfy your use case?

No, because it does not close the entire process just the calling goroutine. Therefore the main goroutine (or other routines which have been spawned) keep running. Goexit only exists from the calling goroutine.  Cleanup code in other goroutines do not get executed and I it make things much more easier (also in terms of separation of concerns) if Golang, which contains the defer and goroutine stuff, would provide reliable Exit functions which take care of all these stuff.

os.Exit is the wrong tool for the job here. In most cases you should spawn your goroutines with cancelation and join mechanisms built with channels or the context package.
Since os.Exit is already well defined, if you still want this behavior, you should probably propose adding a new function to the runtime package instead. I can’t think of any good use-cases off the top of my head for such a function though.

@ccbrown I already explained the use case. And I think contexts are not applicable because you can't interrupt sleeping goroutines. What about blocking file operations for example. I'm not sure how you get separation of concerns with contexts, because my idea is, that every routine should be responsible for the cleanup it must do. And as far as I can remember the defer call was advertised for cleanup tasks. Which, as we can see is not a reliable way if the application panics or if the process is killed. See my example on playground.
And I think it's a common task to do some cleanup if the user interrupts the process with SIGINT before exiting. The other way arround I'm question myself why we have os.Exit when it does not respect defers. Some of go's core features.

The way you would do this with contexts looks like this:
package main

import (
	"context"
	"os"
	"os/signal"
	"time"

	"golang.org/x/sync/errgroup"
)

func GoroutineThatSleeps(ctx context.Context) error {
	select {
	case <-ctx.Done():
		return ctx.Err()
	case <-time.After(time.Second):
		return nil
	}
}

func main() {
	ctx, cancel := context.WithCancel(context.Background())

	go func() {
		ch := make(chan os.Signal, 1)
		signal.Notify(ch, os.Interrupt)
		<-ch
		cancel()
	}()

	var g errgroup.Group

	// launch some goroutines that we can cancel
	for i := 0; i < 3; i++ {
		g.Go(func() error {
			return GoroutineThatSleeps(ctx)
		})
	}

	if err := g.Wait(); err != nil {
		println(err.Error())
		os.Exit(1)
	}
}

https://play.golang.org/p/YAarsVHJSGp
This works fine for goroutines that sleep and goroutines that use blocking IO. Many third-party APIs have direct support for using contexts in this way.
I said I couldn't think of any good use-cases for a function that attempts to immediately end all goroutines gracefully. There are better, more elegant ways to gracefully cancel goroutines.

Also want to add: If your concern is with canceling work done by a third-party library that does something like time.Sleep, that library obviously was not written with cancelation in mind, and even with your proposed behavior, you would not be able to ensure that it shuts down gracefully.

Also want to add: If your concern is with canceling work done by a third-party library that does something like time.Sleep, that library obviously was not written with cancelation in mind, and even with your proposed behavior, you would not be able to ensure that it shuts down gracefully.

Maybe golang does not work like other languages like C if they're calling blocking I/O, but as far as I know blocking I/O is another example for a sleeping thread which cannot be interrupted until a timeout or completion of the operation.
At least my proposal whould allow developers to recover if for example some goroutine panics. Currently only the panicking goroutine is able to do something in case of an error. If some other routine hasn't completed it's operation this could case data corruption, just for example.

I said I couldn't think of any good use-cases for a function that attempts to immediately end all goroutines gracefully. There are better, more elegant ways to gracefully cancel goroutines.

I just wanted to show that without support by os.Exit() or another API function it forces you to use many more lines of code if you compare this to just an simple exit call.
Maybe I misunderstand your code, but as I read the code this looks like you're only able to cancel goroutines which aren't already sleeping (like they would do if some blocking I/O operation is in progress).
func GoroutineThatSleeps(ctx context.Context) error {
	select {
	case <-ctx.Done(): // Will be selected if canceled
		return ctx.Err()
	case <-time.After(time.Second): // No cancelation possible until goroutine exits
		return nil
	}
}

Maybe I misunderstand your code, but as I read the code this looks like you're only able to cancel goroutines which aren't already sleeping (like they would do if some blocking I/O operation is in progress).

Yeah this is just a misunderstanding. You can cancel goroutines that are already sleeping or doing blocking I/O. My example function sleeps for one second. If you interrupt the process half a second into the goroutine's slumber, it'll be canceled and return immediately. Try making the sleep time one minute and interrupt it a few seconds in and this will be easier to see: You won't have to wait the full minute.

My example function sleeps for one second. If you interrupt the process half a second into the goroutine's slumber, it'll be canceled and return immediately. Try making the sleep time one minute and interrupt it a few seconds in and this will be easier to see: You won't have to wait the full minute.

I know this is not the right place to ask questions, but in the example the magic is, that the select statement causes the goroutine to wait for the channels, but how would that work in context of blocking i/o operations? They don't return channels on which a select could choose between the cancelation channel and time.After. For example, a file read/write.

Unfortunately os.File predates the context package, so this isn't as easy as it should be, but the easiest thing to do is just close the file when the context is cancelled:
func ReadAllWithContext(ctx context.Context, path string) (bufOut []byte, errOut error) {
	f, err := os.Open(path)
	if err != nil {
		return nil, err
	}
	defer f.Close()

	// Spawn a goroutine to close the file if the context is canceled.
	done := make(chan struct{})
	go func() {
		select {
		case <-ctx.Done():
			f.Close()
		case <-done:
		}
	}()
	defer close(done)

	// If the context was canceled before we could read the file, change the error to ctx.Err().
	defer func() {
		if ctxErr := ctx.Err(); errOut != nil && ctxErr != nil {
			errOut = ctxErr
		}
	}()

	return ioutil.ReadAll(f)
}

Close closes the File, rendering it unusable for I/O. On files that support SetDeadline, any pending I/O operations will be canceled and return immediately with an error

– https://golang.org/pkg/os/#File.Close

Ordinary Go code doesn't have blocking I/O operations in the sense that I think you mean.  When a goroutine calls Read or Write on a network connection, the runtime puts that goroutine to sleep and uses epoll, or the equivalent on other operating systems, to decide when to wake the goroutine up again.  A different goroutine can always wake the goroutine up by changing the deadline of the operation or closing the network connection.
But I'm not sure what that has to do with the behavior of os.Exit.  The current behavior of os.Exit, to exit the program without running any deferred functions, is well established and is not going to change at this point.
In general there is no reliable way to do anything as a program exits, because there are many different ways that a program can exit.  For example, on GNU/Linux, the kernel can kill it if it starts using too much memory.  Therefore, if there is any cleanup that must be done on program exit, the only reliable way to do it is to invoke the program from a different process that just does the cleanup.  The Go standard library has chosen to not provide a 90% solution in this space, because it is a space where correct functioning often requires a 100% solution.

@Sebi2020 if you can get data corruption due to unexpected exit, that will happen if the host crashes or powers off. You should be able to recover on restart, and not expect graceful exit.
If you're using a transactional data store, this isn't hard to do. If using the filesystem, it's much more involved (speaking from experience).

@networkimprov I think that are two different problems yielding to the same result. But with the difference that a power loss or crash off the host is out of your control (from the viewpoint of the application developer), if you have not taken any steps to mitigate this cases. But how an application exits is within your control (mostly, not always).
As I said I just think that a language construct like defer should be reliable regarding their execution is guaranteed. If it isn't you have to keep track of which function calls get executed on exit. As long as deferred function calls are only executed as long the normal operation continues the only reliable way is to exit in the main. That is little bit like only being allowed to use a single return at the end of a function instead of using multiple exits.

@ccbrown most of the other languages have other methods ensuring that cleanup code can run on a call to exit. This doesn't necessary have to happen inside a destructor (or a defer call) but it would make things much less annoying. An example in C++ is atexit. I don't know a similiar golang mechanism. And saying, no language did this that way is not a really good reason for not doing it. Golang does many things other languages do not do. And as far as I can remember a simliar policy applies for sdtuff people want golang to have.

I think you misunderstand my point a bit. Go's defer statements are much more similar in purpose to destructors than atexit. So my point was just that what Go currently does isn't unusual and should not be surprising.
 But if you want that sort of thing, you should probably modify your issue or create a new one to propose it since os.Exit isn't going to change for compatibility reasons.

Seems like this is working as documented. If you have a specific proposal in mind, please file a new issue with details. For now, I'm closing this issue as there doesn't seem to be anything else to do here.


Another way of acquiring tokens:

Get 1 token for watching the stream for 1 hour. how? idk.
This would require us to change the way tokens "expire".
Just make a cap on 10 tokens or something.

sounds fair but there will be alot of sounds then so maybe make it 2 hours or more so it doesnt have to be too often.

Due to pajbot being moved into maintenance mode I'm closing this feature request.


pretrained models

hi! thanks for sharing your excellent work!
could you please release the pretrained model??

Please refer the Readme.Md

Oh, I see. Sorry I didn't notice. I thought it was a link to download the dataset.


Issue 82 kill setup environ funfactory

Moves monkeypatches so we can stop relying on django.core.management.setup_environ
This (together with a small playdoh patch) fixes https://github.com/mozilla/playdoh/issues/82

This looks alright to me, but I want to know what @kumar303 thinks, since I had already seen this code.

Landed https://github.com/mozilla/funfactory/commit/c7eaa7822c05d4d4d71ac14fd23c9ae02fc31871


Improve documentation for Storage and Ui components

Closes #267 Closes #261 Closes #258 Closes #247 Closes #243 Closes #237

Closes #237


adsorbate_depositor add symmetry detection utility

adsorbate_depositor add symmetry detection utility

Closed. Should focus on bug fix, don't have extra energy on this script for the time being.


Split link-at-beginning watch into new reason

Discussed in CHQ. The reason has its own whitelist for now, until we have unified whitelist-checking.

If we are implementing this as a separate rule (which I think we should), I would just duplicate the code used for link-at-end, which takes whitelists into considerations.
@create_rule("link at end of {}", title=False, all=False, sites=[
    "superuser.com", "askubuntu.com", "drupal.stackexchange.com", "meta.stackexchange.com",
    "security.stackexchange.com", "patents.stackexchange.com", "money.stackexchange.com",
    "gaming.stackexchange.com", "arduino.stackexchange.com", "workplace.stackexchange.com"])
def link_at_end(s, site):   # link at end of question, on selected sites
    s = regex.sub("</?(?:strong|em|p)>", "", s)
    match = regex.compile(r"(?i)https?://(?:[.A-Za-z0-9-]*/?[.A-Za-z0-9-]*/?|plus\.google\.com/"
                          r"[\w/]*|www\.pinterest\.com/pin/[\d/]*)(?=</a>\s*$)").search(s)
    if match and not is_whitelisted_website(match.group(0)):
        return True, u"Link at end: {}".format(match.group(0))
    return False, ""

See the CHQ discussion; my understanding is that this reason will eventually adopt the MS whitelist once we have the new whitelist-checker.

This should have a max_rep and a max_score. The only data we have is for what the watchlist is using, which is max_rep=32, max_score=1.

@makyen Thanks. I went ahead and put in a max_rep and max_score for now; I've noticed enough false-positives from this that I think it's worthwhile.

I agree, I'd rather have the max_rep and max_score, at least for now. Maybe once we have the whitelist working, it will reduce the FP rate sufficiently such that we can look at adjusting those, if it's felt there's a need.
!!/approve


Sonnet keeps using EOF format

Sonnet recently tries to write to files using some weird format like cat << " code" >> EOF I don't exactly remember the syntax that always makes the command fail(will edit with the correct format when it does it again). An update to the tools prompt could easily fix this.

Duplicate of https://github.com/ErikBjare/gptme/issues/108?
We could try to fix the shell tool, would be nice.