Azure CI OWASP Dependency check task failing to download

I installed the dependency check extension for my Azure CI. As mentioned in the link : https://marketplace.visualstudio.com/items?itemName=dependency-check.dependencycheck&ssr=false#qna
I followed the steps mentioned, but getting the below issue..
Hostname/IP doesn't match certificate's altnames: "Host: api.github.com. is not in the cert's altnames: DNS:*.ABC.com, DNS:ABC.com"
Unhandled error condition detected.
Please do the needful.

Are you running the extension on premise or on an Azure hosted builder? I'm guessing this is due to running on prem behind a network appliance that is intercepting egress traffic.

Closing this due to no response and inactivity.


Correct stringify to JSON.stringify

Pre-Submission Checklist

[x] Your pull request targets the staging branch of FreeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[x] Closes #9276

Description
Reverts line var collectionCopy = JSON.parse(stringify(collection) to var collectionCopy = JSON.parse(JSON.stringify(collection)) as intended by https://github.com/FreeCodeCamp/FreeCodeCamp/commit/3fa86377f87c98cb5a3ea3bae84daee3424cf58c (this commit omitted JSON. from JSON.stringify)

LGTM :+1:
Thanks for contributing :tada:


PR review updates

A placeholder ticket to allow for time to make updates to code after the PR review.

Project ended early (this week); this ticket will not be finished due to no more time/funding.


Add functionality to allow the item creator to edit the passport

We want to allow the creator of an item (the first owner of the nft) to be able to edit the properties of the item passport.

[x] add creator property to contract
[x] check creator of contract on edit page

We solved this issue creating a hash-map where we keep all item owners in an array {item : [users]}. So then we created a function isEligible that it checks if the user is eligible for changes. Explanation:
if (userAddress == ownerOf(tokenID) || userAddress == allItemOwners[tokenId][0]) return true;

We make a check if the user is the first user in the array of the hash-map for the current item, if it's true that means the user is the creator of the item because when the user creates an item they get added as first user in the hash-map array.


Adding LiDAR

I added hokuyo lidar for detecting gazebo obstacles. You should rosdep install <dependency packages> before launch roslaunch ackermann_vehicle_gazebo ackermann_vehicle_hokuyo.launch

I'm only keeping this repository as a mirror of the now-deleted wunderkammer laboratory repo; I'm not prepared to accept contributions.
I don't have any plans to release this package either, but you're welcome to maintain and release your own fork.


Add kubevirt_vmi_resource_requests metric for memory resource

What this PR does
Before this PR:
No metric with VMI resource requests data
After this PR:
kubevirt_vmi_resource_requests hold memory resource requests for VMIs
jira-ticket: https://issues.redhat.com/browse/CNV-44275

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

Add kubevirt_vmi_resource_requests metric for memory resource

/cc @sradco @avlitman

/retest

/lgtm

/hold

/approve

/hold

@machadovilaca Please update pr name

/unhold

/lgtm

/approve

/retest-required

/retest-required


Lab 4 - Numeronyms

Fixes #326
Review of colleague's PR #
Changes proposed in this PR:

Add function to return numeronyms of strings
Add tests

Codecov Report

Merging #327 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #327   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          20     21    +1
  Lines         328    343   +15
=====================================
+ Hits          328    343   +15

Impacted Files
Coverage Δ

04_numeronym/jessodri/main.go
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b64a6e9...0d39253. Read the comment docs.


feat(onyx-1113): sell flow - additional documents step

The type of this PR is: Feat
This PR solves ONYX-1113
Description
Made some assumptions how thumbnails should look like and behave, once it's on staging I'll ask Barney what needs to be changed.

Need to mention it after a second review - great PR @nickskalkin  👏


deserialse to domain class rirght from the response

@corinnekrych instead of the user doing it the sdk could do this.

:eyes:

@edewit @corinnekrych Still valid?

yeah @danielpassos I think it's an nice addition instead of getting a list back with JsonObjects you get list of domain objects

Thanks @edewit I have merged it in https://github.com/feedhenry/fh-dotnet-sdk/commit/6b5b1c5b351386a396d3f0ba600ca7194d691ce4


feat: support subpath imports

Summary
Fixes #12270.
While the implementation may be a bit buggy, I think it's safe to roll this out as it currently fails altogether. Hopefully people try it out and report bugs so we can fix it 🙂

Test plan
Tests added

Looking forward to this being published, thank you!


Site not working?

I'm seeing this on the console and the page doesn't do anything further.
Unhandled Promise Rejection: TypeError: undefined is not an object (evaluating 'a.state.data.period')

Fixed earlier, sorry about that!


Four and a half Feature Requests

[x] Please allow us to blacklist certain curses (I'd like to blacklist certain curses that are added from other mods)
[x] Please allow us to configure how many curses we can get at a time (ie 0 curses, 1 curse, X curses)
[x] Please allow us to configure the start and end times (if we want them to last longer and/or happen during the day)
[x] Please allow us to enable if curses should occur when we sleep to skip nights (if players want to be babies -> curses)

[ ] Optionally you can allow curses to happen only if the players skip a configurable amount of days in a row

Thank you!

Thank you for adding these features! I have to ask, do you plan on doing this? If so, then your mod is perfect.

Optionally you can allow curses to happen only if the players skip a configurable amount of days in a row

I think about it. It's a bit more effort than the other stuff. Because of this, I will not say yes. I opened another issue for that #3 to close this one


Enable cross build down to sbt 0.13.x; add snykProject and snykBinary settings

Uses the standard plugin cross compilation mechanism with a small shim to deal with logger differences
enables snykBinary in Global := "./path/to/snyk"
enables snykProject := "my-project-name"
consistently sets --org and --project-name as appropriate
small logging/help improvements

Backwards incompatibility:

you now have to set snykOrganization in Global := not merely snykOrganization :=.  I didn't want this, but I don't know enough about idiomatic use of sbt configuration axes to fix it.  Similarly I would prefer users not to have to set snykBinary in Global.

LGTM 👍


Add Visual Studio 2010 support.

@lygstate , our supported minimum compiler version is VS 2013. We've moved the minimum compiler so we can leverage many useful C++11 features.
There are no plans to support VS 2010.
Are there any specific challenges in using VS 2013 instead of 2010?

@jeffdiclemente Vs2010 is the lastest compiler can debugging on Windows XP.

VS 2010 was supported in the 2.x versions, but as Jeff said we dropped support for it intentionally. You could either stick with 2.x or build your binaries on Windows 7 using VS 2013 targeting Windows XP. If you really need to debug running applications directly on Windows XP, you should be able to use VS 2010 just for the debugging task.


Update docs

This PR:

moves the docs for enable(), etc. from Laravel usage to framework-agnostic usage
updates the usage reference to reflect removal of enabled methods from spatie/laravel-ray

Thanks!


Feature Request: convert Post section and subsection to pdf format as a document to read

Describe the solution you'd like
Need to convert post.md to post.pdf  pdf button as interface

Describe alternatives you've considered
N/A

Additional context

Why not use ctrl+shift+p  then print as PDF?

Why not use ctrl+shift+p then print as PDF?

output.pdf

instead
it should use the sidebar headings as table contents and each post content

Why not use ctrl+shift+p then print as PDF?

output.pdf

instead
it should use the sidebar headings as table contents and each post content

pdf title
-from parent section
Table contents
- from sidebar
body

from each post

@HenzelMoras This seems like it would be beyond the scope of a theme and more a feature request for hugo. I did manage to find where someone else has created a custom implementation that might be worth your time.

@HenzelMoras This seems like it would be beyond the scope of a theme and more a feature request for hugo. I did manage to find where someone else has created a custom implementation that might be worth your time.

@Rihoj  thanks ill look into it


[backport] Fix typo in README

Backport of #5395 by @kmaehashi

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit 548144ef7cce7b8285a4f567c2f0c303edbeebbe, target branch v9) failed with status FAILURE.


Underwater Altars not shown

MoreTerra does not appear to reveal the locations of demon altars if they are underwater.

Can you try this on the latest release and open a new issue if you still encounter a problem? Thanks
Link: https://github.com/mike-mo/MoreTerra/releases/tag/v1.16


add option to specify storageclass name

I propose to add an option to specify storageclass name during helm chart deployment

@houshym This comment is referring to which helm chart? PR's always welcomed hideaway.

Trivy operator helm chart

done


encoding/json: error positions do not reflect position of error

What version of CUE are you using (cue version)?

$ cue version
cue version v0.7.0

Does this issue reproduce with the latest stable release?
Yes
What did you do?
exec go mod tidy
# The syntax error is on line 4, so we expect
# error message to include that.
exec go run main.go
stderr 'test\.json:4'
-- go.mod --
module m

go 1.21

require cuelang.org/go v0.7.0
-- test.json --
{
	"x": 2
}
	{"unterminated",}
-- main.go --
package main

import (
	"bytes"
	_ "embed"
	"fmt"
	"log"
	"os"

	"cuelang.org/go/cue/errors"
	"cuelang.org/go/encoding/json"
)

//go:embed test.json
var testJSON []byte

func main() {
	dec := json.NewDecoder(nil, "test.json", bytes.NewReader(testJSON))
	// Sanity check that the first value can be extracted OK.
	_, err := dec.Extract()
	if err != nil {
		log.Fatalf("first: %v", err)
	}
	_, err = dec.Extract()
	fmt.Printf("error: %v\n", err)
	fmt.Printf("positions: %v\n", errors.Positions(err))
	fmt.Println("errors.Print: ")
	errors.Print(os.Stdout, err, nil)
}

What did you expect to see?
A passing test
What did you see instead?
The position of the error bears no relationship to the position that the syntax error actually occurred at.
It always says it's at line 1, column 1.
# The syntax error is on line 4, so we expect
# error message to include that. (0.258s)
> exec go run main.go
[stdout]
error: invalid JSON for file "test.json": invalid character ',' after object key
positions: [test.json:1:1]
errors.Print:
invalid JSON for file "test.json": invalid character ',' after object key:
    test.json:1:1
> stderr test,json:4
FAIL: /tmp/testscript3302001597/jsonpos.txtar/script.txtar:5: no match for `test,json:4` found in stderr

Is test,json:4 in the testscript a typo?

Is test,json:4 in the testscript a typo?

Yup, fixed.

Note that you created a duplicate of this issue in #3317, now fixed, but this reproducer above shows that we're not fully fixed for NDJSON or JSONL inputs. I'll send a follow-up fix using this tracking issue.


to_chars integer parser

@pdimov Do you see anything obvious as to why Windows is failing in CI? It's all the same linker error.

14.0 because of this:
D:\a\charconv\boost-root\boost/charconv/to_chars.hpp(107): error C2220: warning treated as error - no 'object' file generated
D:\a\charconv\boost-root\boost/charconv/to_chars.hpp(107): warning C4127: conditional expression is constant

The rest seems to be because they try to link to the DLL, but it exports nothing, so no LIB is generated.
I suppose now that the functions are constexpr, nothing remained in the DLL. But there will be one day, so maybe add a stub fp function just to have something exported.

@pdimov Can you take a look through this? I think it is in good shape.

Looks good overall. The html should be in doc/html though, not doc, and shouldn't be checked in.
I think we need significantly more test values than that; esp. against <charconv>, we need to be testing with both hand-picked values (1, 9, 10, 99, 100, 999, etc) and random values (e.g. from splitmix64.)
(Like https://github.com/boostorg/core/blob/8977da6f50b3a29e429c9f78766296f66e2dab26/test/bit_ceil_test.cpp#L51-L62 for instance, except maybe with more than 1000 values.)

https://master.charconv.cpp.al/
https://develop.charconv.cpp.al/

@pdimov Can you please take a final look at this? I think I addressed all of your previous comments.

Looks good to merge.


Problem when computing chunk content [DOT 2.x]

I'm attaching a sample project:
https://www.oxygenxml.com/forum/files/maprefChunk.zip
The main DITA Map has a reference to a slave DITA map:
  <mapref href="slave.ditamap" keys="akvs_glossar"/>

which in its turn chunks two topics into a single file:
    <topicref href="kostra/t1.dita" chunk="to-content">
      <topicref href="kostra/t2.dita" keys="akvs_bauabschnitt"/>
    </topicref>

When published to XHTML output, there are a couple of related problems:

The slave DITA Map has chunking defined on a topicref:

but the original file name "t1.dita" is not preserved in the temporary files folder, a generated "Chunkxxx.dita" file name is generated with all the references to the CSSs broken.

Probably related to (1) I also receive a warning like this:
[xslt] Processing C:\Users\radu_coravu\Desktop\maprefChunk\temp\webhelp-responsive\kostra\t1.dita to C:\Users\radu_coravu\Desktop\maprefChunk\out\webhelp-responsive\kostra\t1.html
[xslt] [DOTX037W][WARN]: No title found for this document; using "***" in XHTML title bar.

If I remove from the main DITA Map the key definition 'keys="akvs_glossar"' then both problems disappear.

Probably a fix for:
https://github.com/dita-ot/dita-ot/issues/2298
will also fix this issue, as at some point the code in the ChunkTopicParser.processChunk method avoids overwriting an existing file and uses the generated chunk file name.


Merge 3.10.x -> 3.15.x

🚀 CI was able to deploy the build of this PR, so you can now try it directly here
Notes: The deployed app is linked to the management API of APIM master. (Same login and password as APIM master)

Replaced by https://github.com/gravitee-io/gravitee-api-management/pull/2209


Update RemoveSeatWelds

Was erroring due to /tp me me  for some reason. Probably that once it checked and removed the seat welds, the seat suddenly didn't have children and errored about nil?

inhale


Note: Anyone can take up this issue and work parallel


DRILL-3743: Fail active listeners if server connection is closed

Remove dead code
Improve error and logging messages

@jacques-n @adeneche please review.

Addressed review comments.

Move new changes
Improve error and logging messages

+1, LGTM


Dev 2007

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: huiguangjun:x: yi-liu9You have signed the CLA already but the status is still pending? Let us recheck it.


added andrew content + copyright date update

LGTM, might require some extra work for newline unless you tested locally - we will see once merged. Thanks Andrew! :)

LGTM, might require some extra work for newline unless you tested locally - we will see once merged. Thanks Andrew! :)


Sandbox fails to compile with mui5 using the latest @material-table/core version

Describe the bug
sandbox: https://codesandbox.io/s/material-table-starter-template-forked-p6yrde?file=/src/index.js
Just found out that store/LocalizationStore.js is still referencing the library fast-deep-equal which is removed in package.json. Don't know why it can still compile though.
Additional context
https://github.com/material-table-core/core/blob/master/.github/ISSUE_TEMPLATE/bug_report.md
sandbox for mui4 and mui5 are pointing to the same sandbox

Can you create a PR to adress this?


#EasyBatchingConfig Provide a way to configure shared batchers without having to specify the complete dependent chains

Today, to create a shared batcher, the only way is to list the complete dependent chains which have to share the batcher
Provide a way to more easily configure shared modulators

Open-sourced the auto-inference utility to https://github.com/flipkart-incubator/Krystal/blob/b9ba3bc482536a3c2e5910a4259d6d0193ce0277/vajram/vajram-krystex/src/main/java/com/flipkart/krystal/vajramexecutor/krystex/InputBatcherConfig.java#L117C22-L117C48
Thanks @vinisha-parwal for this sophisticated and super useful algorithm and implementation!


Furnace Calculator Timer Reset

Give an option (button) to cancel the current Furnace Timer

Implemented in 908162997cce297ce2fbbb7a2d77ec3b7068a7cb


feat(sqlqueryreceiver) add error count metrics for receiver

Format of metric:
# HELP otelcol_receiver_error_count Number of errors
# TYPE otelcol_receiver_error_count counter
otelcol_receiver_error_count{error_type="collect_error",query="query-0: select * from simple_logs",receiver="sqlquery",service_instance_id="9763b7d6-e907-438f-9b70-6e4882756785",service_name="otelcol-sumo",service_version="v0.70.0-sumo-0-198-g210a3dfb53"} 0
otelcol_receiver_error_count{error_type="collect_error",query="query-0: select * from test_logs",receiver="sqlquery/wrong_query",service_instance_id="9763b7d6-e907-438f-9b70-6e4882756785",service_name="otelcol-sumo",service_version="v0.70.0-sumo-0-198-g210a3dfb53"} 2
otelcol_receiver_error_count{error_type="start_error",query="query-0: select * from simple_logs",receiver="sqlquery",service_instance_id="9763b7d6-e907-438f-9b70-6e4882756785",service_name="otelcol-sumo",service_version="v0.70.0-sumo-0-198-g210a3dfb53"} 0
otelcol_receiver_error_count{error_type="start_error",query="query-0: select * from test_logs",receiver="sqlquery/wrong_query",service_instance_id="9763b7d6-e907-438f-9b70-6e4882756785",service_name="otelcol-sumo",service_version="v0.70.0-sumo-0-198-g210a3dfb53"} 0

for configuration:
receivers:
  sqlquery:
    collection_interval: 10s
    driver: postgres
    datasource: "host=<IP_ADDRESS> port=5432 user=otel password=otel sslmode=disable"
    queries:
      - sql: "select * from simple_logs"
        logs:
        - body_column: BODY

  sqlquery/wrong_query:
    collection_interval: 10s
    driver: postgres
    datasource: "host=<IP_ADDRESS> port=5432 user=otel password=otel sslmode=disable"
    queries:
      - sql: "select * from test_logs"
        logs:
        - body_column: BODY
exporters:
  logging:
    verbosity: detailed
    sampling_initial: 5
    sampling_thereafter: 200

service:
  telemetry:
      logs:
        level: "debug"
  pipelines:
    logs:
      receivers:
        - sqlquery
      exporters:
        - logging
    logs/wrong_query:
      receivers:
        - sqlquery/wrong_query
      exporters:
        - logging

Is the _count suffix in the metric name right? I'm not sure I've seen it in other OpenTelemetry metrics.

Suffix removed, new format of metric:
# HELP otelcol_receiver_errors Number of errors
# TYPE otelcol_receiver_errors counter
otelcol_receiver_errors{error_type="collect_error",query="query-0: select * from simple_logs",receiver="sqlquery",service_instance_id="f5884777-cec4-48a0-8b9c-834562e91acb",service_name="otelcol-sumo",service_version="v0.70.0-sumo-0-204-gdbf1aff740"} 0
otelcol_receiver_errors{error_type="start_error",query="query-0: select * from simple_logs",receiver="sqlquery",service_instance_id="f5884777-cec4-48a0-8b9c-834562e91acb",service_name="otelcol-sumo",service_version="v0.70.0-sumo-0-204-gdbf1aff740"} 0


Hide all error internals

Before we do v1.0 we want to hide all the error internals so that we can modify/improve them without breaking the public API.
Please pay particular attention to the Display strings because we they are considered part of the public API so we don't want to change them willy-nilly. Of note, because the enums have inner structs it was difficult to not duplicate the error message.
Resolve: #42

Man, I forget if struct errors are supposed to have #[non_exhaustive]?

All suggestions implemented @Kixunil except removing non_exhaustive, ok with that?

Please don't merge yet, I want to remove the unnecessary non_exhaustive.

lol @tcharding you were just a bit too late, sorry

Ha! I thought you might have started the merge process soon as you acked. I'll fix as a follow up.


Make the block-indentation rule aware of leading content

If the block children are inline elements, then there can be important reasons for them to appear on the same line. For example:

  key:value

will render as
key: value

but

  key:
  value

will render as
key:
value

The block indentation rule was previously forbidding the first version because the second 's column number is not two. This commit makes the indentation rule aware of previous content on the same line, whether it is an element/mustache node or text.

Sorry for the delay here, this looks great!
Can you add some bad tests for these:

  Foo{{#some-thing}}
  {{/some-thing}}

  Foo{{#some-thing}}
                  {{/some-thing}}

{{#if foo}}
  {{foo}}

    Bar

{{/if}}

  Foo{{#some-thing}}
                  {{/some-thing}}

actually passes validation because the opening and closing some-things are aligned with each other (this PR doesn't currently include any changes to validateBlockEnd.) That's kind of a weird syntax to be "correct" but I'm not exactly sure what other syntax would be correct.
I suppose we could say that if you open a block on a line that is preceded by any other content, you must also close that block on the same line:

  Foo{{#some-thing}}...{{/some-thing}}

That seems a bit restrictive, but users can always disable the rule in-context with comment instructions.
Another option would be to not perform any validation on the block end if the block start had other content preceding it on the same line. But if we really want to handle the case of a multi-line block that starts on a line with preceding content, then we also need to think about the contents of the block. For example, if all we did was ignore the indentation of the closing block, then which of these would be correct?

  Foo{{#some-thing}}
    Bar
  {{/some-thing}}

  Foo{{#some-thing}}
                    Bar
  {{/some-thing}}

Or do we ignore its closing block and all of its descendant blocks? Kind of seems like a can of worms. What do you think?

I suppose we could say that if you open a block on a line that is preceded by any other content, you must also close that block on the same line:

Agreed, but "feels" more arbitrary that the other portions of the rule.  Lets just add that example as a "good" one for now...

For example, if all we did was ignore the indentation of the closing block, then which of these would be correct?

TBH, both seem wrong to me.  I think I would prefer what is currently implemented (even though it is also a bit weird):

  Foo{{#some-thing}}

lorum ipsum

                  {{/some-thing}}

Okay, so add

  Foo{{#some-thing}}
lorum ipsum
{{/some-thing}}

as a good example, and omit the original three (since the second one is good, but for a confusing reason and the first and third are bad, but for a confusing reason)? Or do you still want the first and third as bad examples?

I would like:

the first and third as bad examples with a comment in the the block describing what is wrong about them
the additional good example you just entered (basically all one line)

Okay, done. Also fixed a minor error message formatting issue I stumbled over when writing the bad cases.
If you give a :+1: I'm happy to squash the commits before the merge, or if you don't care, merge away :smile:

Thank you!


Light theme looks strange

I used discord-linux for the first time today (installed from the AUR using yaourt), and the Light theme looks like this:

The dark theme looks as intended (or at least as it looks on the webapp). I'm using Antergos 2015.06 (Linux Kernel 4.1.6-1) on an Intel i7 4790k (GPU is a GTX 970). Am I doing something wrong?

This was fixed in<PHONE_NUMBER>f8c6a1635efe94411bee0440620556. The binaries/aur PKGBUILD haven't been updated yet, however.

Luckily this is pretty easy to fix for the meantime. Just sudo vim /opt/discord/resources/app/index.html and replace those two lines.

This has been resolved and will be fixed in the next update push.


code clean up

Codecov Report

Merging #87 into master will increase coverage by 0.02%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   75.25%   75.27%   +0.02%
==========================================
  Files          86       86
  Lines       13485    13486       +1
==========================================
+ Hits        10148    10152       +4
+ Misses       2554     2552       -2
+ Partials      783      782       -1

Impacted Files
Coverage Δ

metastore/disk_metastore.go
57.62% <50%> (+0.05%)
:arrow_up:

memstore/cuckoo_index.go
91.21% <0%> (+1.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc7ca9b...b8b1caf. Read the comment docs.

Closed this pr as no response for 30 days, please reopen and resolve the conflicts if you still want to contribute, thanks


Blurry Text Rendering

Glyphs are rendered to a canvas which already has AA. When we render to a framebuffer, we apply FXAA which makes the text blurry.
We can change the pipeline so that text is rendered after FXAA or use multisampled textures when WebGL 2 is supported.

See this forum post: https://groups.google.com/forum/#!msg/cesium-dev/lBAPrC7IaDw/9dcT9FV4d4kJ

Fixed in #7730

Congratulations on closing the issue! I found these Cesium forum links in the comments above:
https://groups.google.com/forum/#!msg/cesium-dev/lBAPrC7IaDw/9dcT9FV4d4kJ
If this issue affects any of these threads, please post a comment like the following:

The issue at https://github.com/AnalyticalGraphicsInc/cesium/issues/2752 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.


fixed unknown_host

fixed the below issue.
paramiko.SSHException: Server '[<IP_ADDRESS>]:8888' not found in known_hosts

@rikiesxiao Are you still interested in making these changes? I hit this issue as well and would be happy to help get this over the finish line.

Superseded by #41


Store BlockNumber at KyodoRegistry

We need to collect the events related to payments.
If we choose to use The Graph, this won't be necessary.

I've marked this issue with the 'bug' tag since there's a problem with the payments list not functioning correctly. This is because it's having trouble retrieving event data from blocks that are too far back.


Comments "you" (the user) made are in a weird blue color

Comments you make is in a weird blue color (don't know if this is intentional or not but it looks odd in a way)
Screenshots

More info
I also have some extensions that changes how github looks / added features but it still happens when they're disabled :c

Thank you for reporting this issue. It will look a lot better across all color-schemes in the next release:


Remove development.md

This file is empty and doesn't seem to be referenced anywhere. We either have to delete it or add metadata and the boilerplate text for unwritten topics.

LGTM, merge it! 🎉


[release-2.4] Manual cherry-pick: Handle non-map annotations (#196)

Manual cherry-pick of #196
Addresses:

https://github.com/open-cluster-management/backlog/issues/18178

/hold for 2.4.2

/auto-cc

/unhold


az extension add --name aks-preview fails with checksum error

[Enter feedback here]
Tried this on Cloud Shell. I got this error.
kumar@Azure:~$ az extension add --name aks-preview
The checksum of the extension does not match the expected value. Use --debug for more information.
Tried with --debug option
Downloaded to /tmp/tmpl17r6sx9/aks_preview-0.4.10-py2.py3-none-any.whl
Validating the extension /tmp/tmpl17r6sx9/aks_preview-0.4.10-py2.py3-none-any.whl
Invalid checksum for /tmp/tmpl17r6sx9/aks_preview-0.4.10-py2.py3-none-any.whl. Expected '412e936f0505550e1f2130ec45e412dcfbff61b6f2b0443295ab15c313341cfe', computed '19d5aa03491239728eeef0384a75a7e02e1a52733bffac25c29f1d97d9b3b921'.
cli.azure.cli.core.util : The checksum of the extension does not match the expected value. Use --debug for more information.
The checksum of the extension does not match the expected value. Use --debug for more information.
az_command_data_logger : exit code: 1
telemetry.save : Save telemetry record of length 2430 in cache
telemetry.check : Negative: The /home/kumar/.azure/telemetry.txt was modified at 2019-08-27 01:17:48.821356, which in less than 600.000000 s
command ran in 2.067 seconds.
kumar@Azure:~$

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6de70aec-9ebe-5655-6657-5c171de374b1
Version Independent ID: c9eb35c8-8703-511b-987b-e2a441be2e47
Content: Preview - Create a Windows Server container on an Azure Kubernetes Service (AKS) cluster
Content Source: articles/aks/windows-container-cli.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

@kumarallamraju
Thanks for the feedback! We are currently investigating and will update you shortly.

#37818 similar issue

@kumarallamraju I am unable to reproduce your issue. i tried in my cloud shell and it updated my aks-preview version. Cli version  is 2.0.71
In my laptop i had Cli with version 2.0.71. i dont have aks-preview installed. When i gave the command it worked well.
Can you give the command az extension list and check if you have aks-preview installed or not.
If installed please try to update the extension with az extension update --name aks-preview

@kumarallamraju Good to know that its working now.
Use who opened this #37818  issue also commented the same,
I will close this issue now.  Feel free to open a new one if you any other issues.


Initial documentation of unit testing

@eqfarhad and @habdullah working on a document describing how to do unit testing
@timur-friedman has written an architecture document and has updated the top-level README


Blazor components topic

Fixes #8
Fixes #19

🐕 ROUGH! ROUGH! 🐕 draft for sure. I wrote to our outline, but I'm sure I'm missing bits. I made educated guesses in spots ... and they really weren't very "educated" given only a couple of days thus far with the tech.
Follows our plan from the call regarding Razor ... I show what works. I mention our Razor topic, but I don't tell the reader go learn everything in the Razor topic.
To show Blazor, C#, Razor, and HTML, I start with a carefully documented example, and then I break it down section-by-section for each piece. My plan is that the example provides context for the related technologies involved. That example at the top of the topic is also in our ...
:tada: Components Sample app! 🎈, which demos many of the features described in the topic. I probably need to link another line at the top back out to our .NET site Get started page with setup instructions. [btw- I still have a concern about not having a Get started page in the doc set.]
This topic is set up as an index page in a "Blazor components" TOC area: In the future, many of the sections in this topic become expanded into full topics under this node of the TOC. The sections here will then link to those new topics for further (detailed) content.
No API links for now. Best to wait until we have a stable API endpoints.

@danroth27 I made the updates to bind syntax, and I added a few bits from the 0.2.0 file.

@SteveSandersonMS Please take a look.

@danroth27 @SteveSandersonMS Ok ... see where the last commit gets us.

@danroth27 Updates made. I left a short blurb and bookmark link to the Razor support section so that we maintain some coverage for directives early. See if that works.

Must be my local .gitignore is lacking it and it snuck into one of my commits. I'll clear it out on the next one.

@danroth27 I broke that section and tried to stay true to the sample app. We can mod the sample and split it there too, if needed. I use line highlighting to help the reader follow along in the code snippets.

@SteveSandersonMS Do you have additional changes?


feat(package): eliminate the need for compilation of dependencies on most platforms

This commit bumps the sharp depenecy to v0.20.0, which introduces prebuilt binaries for sharp.node. Sharp was the only remaining dependency which did not provide pre-built binaries, and therefore always required compilation.
Now that all deps have pre-built binaries, this library will only need to have a compiler toolchain on platforms which are not supported by the prebuilt binaries.

This also makes the Travis builds take about a third of the time they did before :+1:.


Test: add cron job to test tutorials regularly

The cron jobs can only run, hence be tested on main branch so closing deleting this branch.


Enhancements and Fix

Send renamed to "Select"
Dismiss Photo Library Picker when Select is tapped on Image Preview Screen
Add a property "isFilePickerEnabled" to enable / disable the File Picker.

I've fixed some more places using _imageFilesPicker as private, and added a default value to "isFilesEnabled" to YES, and merged.
Thank you for your contribution (: have a great day

Thank you for the great control ;)


UI: TextEdit element "focus_exited()"signal not firing

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Windows10 64bit
Godot version: 3.0.6
Issue description:
It's second time of submitting this #11744 issue but now for Godot Version: 3.0.6
PROBLEM:  When i try to use the focus_exited() signal under "LineEdit" or "TextEdit" control node it never seems to fire, but the focus_enter() works just fine. NB: I tried all focus modes (ALL, NONE, CLICK).
Steps to reproduce:
Click on "LineEdit" or "TextEdit" gui control and try to click away or press enter, it never looses focus and is stuck focused forever. NB: Changing Focus Mode between "All" and "Click" didn't change a thing.
Link to minimal example project:
focus_exited_demo.zip

Looking at line_edit.cpp, it should probably be made to not accept events which are of the "ui_focus_next" action. That way, tabbing out of the LineEdit will be possible.
Not sure about TextEdt, since needs to consume the Tab character when editing scripts. Maybe it should be optional?

Yes i think feature like this should be feature by default  or optional at the very least. For example i'm trying to make Chat-bar which requires me to have way to tell if LineEdit/TextEdit focus was lost. I think it it would benefit a lot of people that try to make input boxes of any kind for their game, without having to do bound checks manually and keep GUI state in custom variables.

I tried the MRP and this is expected behavior. You need another control to click to exit focus. Or implement it manually (e.g. unfocus when pressing Esc). All controls work this way, you can try with e.g. a button. If you want to unfocus when clicking away from control, you could try making a screen-sized flat button (clickable but invisible), so it steals focus when you click outside your TextEdit.
That said, this is not a bug. If you think the behavior should be changed, open a proposal.


StatusCode + PlatformRequest

StatusCode + PlatformRequest

Created StatusCode enum for all known status codes PR #36
Created Package for Platform, with subpackage Requests and Responses (metarequests #202)
Removed unknown6 envelope & response  (metarequests #202)
Created PlatformRequest messages & responses  (metarequests #202)
-- BuyItemAndroidRequest
-- BuyItemPokeCoinsRequest
-- SendEncryptedSignatureRequest
-- BuyItemAndroidResponse
-- BuyItemPokeCoinsResponse
-- GetStoreItemsResponse
-- SendEncryptedSignatureResponse
created PlatformRequestType enum

Still yet to test these changes as an implementation, some of the semantics have changed (unknown6 having a byte type instead of u2).
Please dont merge til i check

This is good to good, tested with JavaAPI and can get pokestops etc

Any thoughts anyone?

+1

+💯    just for the archive, discussion also here
amazing that u/community figured that out!

@AeonLucid good to go?

@rastapasta Yeahhh, looks good to me.

Merge Simpson!

Wuhu! 🎉

Great work! I guess there's a typo in the package for GetStoreItemsResponse (https://github.com/AeonLucid/POGOProtos/blob/master/src/POGOProtos/Networking/Platform/Responses/GetStoreItemsResponse.proto#L2)

Yes sorry! you are right

By the way, is there no GetStoreItemsRequest?

The request takes no arguments, so just send the type with null bytes


Fix - display the home route when the app restarts on mobile platforms

Details

Opens the home route on app startup for native platforms by clearing the lastVisitedPath
Fixed Issues

$ https://github.com/Expensify/App/issues/35927
PROPOSAL: https://github.com/Expensify/App/issues/35927#issuecomment-1931796355
Tests

For IOS native and Android native

Launch the app.
Open any report.
Close the app and kill it(make sure it is not running in the background).
Launch the app.
Verify that the Home route is displayed instead of the report opened on step two.

For Other platforms( Web, mobile chrome, safari, desktop)

Open the expensify app.
Open any report(chat).
Close the tab(for web) or close the desktop app.
Open the expensify app again( launch the desktop app).
Verify that the report opened on step two is displayed.

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/39636266/f9b15d72-0417-4a5d-8cf8-7e9882f6112b

Android: mWeb Chrome
https://github.com/Expensify/App/assets/39636266/c186f780-c864-4c6a-b28a-2cc1c67387f5

iOS: Native
https://github.com/Expensify/App/assets/39636266/e3578fb8-5e23-468c-8ff0-81fbaf6bf05b

iOS: mWeb Safari
https://github.com/Expensify/App/assets/39636266/16b8b6a0-90c3-4555-867c-4b3e26877b77

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/39636266/1c22f61d-3cac-45b6-8005-2ff6fb380d45

MacOS: Desktop
https://github.com/Expensify/App/assets/39636266/6625324b-6dcf-45b4-8918-7ade2be6193c

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@hayata-suenaga @HezekielT this works as expected on native, web and desktop.
But on mWeb, the app always restarts at home screen 😕
I think this is ok and we're good to merge, but it would be great to understand how is it possible?

You're right about the app always starting on home screen for mweb but the issue is also happening on the latest main.

@HezekielT Does this issue only happen on mweb?

Well, it's unrelated to the PR. So let's not worry about it?

@HezekielT @rushatgabhane I filed a bug report
I suggest we hold this PR until the bug is identified and fixed.

@hayata-suenaga should we hold on merging? because this PR is needed for e2e tests to run
https://expensify.slack.com/archives/C05LX9D6E07/p1708015299306599?thread_ts=1708015218.455719&cid=C05LX9D6E07

by the way, QA codes for Ad Hoc builds will be posted on this PR soon because I was planning to test the issue with mweb. But as we now know that the issue is already present on staging, please ignore the ad hoc builds 🙇

@hayata-suenaga should we hold on merging? because this PR is needed for e2e tests to run. And the bug is unrelated, it's about correctly setting the lastVisitedPath before the app is closed.

you made a good point, especially on the broken E2E tests. I was trying to be cautious about merging before we can test this fully on all platforms, but I can see the argument that the discovered bug is not related to this PR.
I'd say... let's merge 🚀

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.43-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@HezekielT
This PR is failing because of issue https://github.com/Expensify/App/issues/36926
The issue is reproducible in: IOS/Safari and Android/Chrome
https://github.com/Expensify/App/assets/93399543/e87c9ed1-0db9-4f22-9ab1-75e903f2a387

This issue was known previously

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Batching errors

Do you want to request a feature or report a bug?
Feature
What is the current behavior?
Currently, Raven.js send a request for per event.
What is the expected behavior?
I understand we need the server-side supports a batching API.
In some cases, we have multiple errors have the same type, so we should raise only one error to prevent flooding the server (we also can have a tag to indicate how many times this errors were happened).

This is a moot point because, as you mention, Sentry does not (yet) support batched requests.
Re: flooding the server, Raven.js now backs off if the server responds with a 429 Too Many Requests (see #839).

We can get back to this discussion once Sentry will support this. Closing for now.


Best way to make form input groups?

I want to create input groups for forms that look like this:

I would like to be able to select an input type of input group and then customize each input.
I'm having a hard time figuring out the best way to do this. If you can point me in the right direction, I would appreciate it. Thanks.

@gwenf , we solved this issue using the MultiValueField and MultiWidget. Basically, you build a new form field from MultiValueField and include all your group fields, then you render it as you like using the MultiWidget.
Sorry it took so long to respond. I hope this helps!

Thanks @rgs258! Yes.


tutor for CNV-BNN_Road-Signs?

Hy Everyone
i had some issues when i tried image classification, i tried to classified a car pict with 720p. when i tried at line "Here we launch the classification on all the tiles from the source image" and make stride s//2 and it shows 1144. at first result, there's no bounding box in it even it classified as a automobile. and i tried the next line and error and it says "cannot reshape array of size 11440 into shape"

and i tried to re-run the road signs with same picture and there's no box in it. is it possible that actually error?

It is possible, the neural network does not have an 100% accuracy. It is important nonetheless that the tiling of the original image is performed correctly. This means making sure that the crop of the original image is done such that one or more tiles completely embed the object you want to recognize.

Hi Mr. giuliogamba,
Now i know what should i do, i appreciate with your answer and i'm very happy to discuss it again with you.
Thank You So Much


How to 'use' this model in our own project ?

I can't find a way how to incorporate this model to my code? I just need to get sentiment scores on some Feedbacks. As this model is pre-trained, it will be of much help. How do i do this? Thanks!

@pgurazada I'm a total beginner to python and pandas trying to apply this code to my csv, would love any help whatsoever as to why I'm getting this error.
I replaced '/path/to/samples/' with a file names 'samples.csv in the same directory
`Warning (from warnings module):
File "/Volumes/Transcend/sentimentneuron/generating-reviews-discovering-sentiment/sentiment-extractor.py", line 14
warnings.warn(msg, category=DeprecationWarning)
DeprecationWarning: sklearn.externals.joblib is deprecated in 0.21 and will be removed in 0.23. Please import this functionality directly from joblib, which can be installed with: pip install joblib. If this warning is raised when loading pickled models, you may need to re-serialize those models with scikit-learn 0.21+.
Warning (from warnings module):
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/sklearn/externals/joblib/init.py", line 15
warnings.warn(msg, category=DeprecationWarning)
DeprecationWarning: sklearn.externals.joblib is deprecated in 0.21 and will be removed in 0.23. Please import this functionality directly from joblib, which can be installed with: pip install joblib. If this warning is raised when loading pickled models, you may need to re-serialize those models with scikit-learn 0.21+.
WARNING:tensorflow:From /Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/tensorflow/python/framework/op_def_library.py:263: colocate_with (from tensorflow.python.framework.ops) is deprecated and will be removed in a future version.
Instructions for updating:
Colocations handled automatically by placer.
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/pandas/core/indexes/base.py", line 2657, in get_loc
return self._engine.get_loc(key)
File "pandas/_libs/index.pyx", line 108, in pandas._libs.index.IndexEngine.get_loc
File "pandas/_libs/index.pyx", line 132, in pandas._libs.index.IndexEngine.get_loc
File "pandas/_libs/hashtable_class_helper.pxi", line 1601, in pandas._libs.hashtable.PyObjectHashTable.get_item
File "pandas/_libs/hashtable_class_helper.pxi", line 1608, in pandas._libs.hashtable.PyObjectHashTable.get_item
KeyError: 'samples'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/Volumes/Transcend/sentimentneuron/generating-reviews-discovering-sentiment/sentiment-extractor.py", line 23, in
samples = list(data_df['samples'])
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/pandas/core/frame.py", line 2927, in getitem
indexer = self.columns.get_loc(key)
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/pandas/core/indexes/base.py", line 2659, in get_loc
return self._engine.get_loc(self._maybe_cast_indexer(key))
File "pandas/_libs/index.pyx", line 108, in pandas._libs.index.IndexEngine.get_loc
File "pandas/_libs/index.pyx", line 132, in pandas._libs.index.IndexEngine.get_loc
File "pandas/_libs/hashtable_class_helper.pxi", line 1601, in pandas._libs.hashtable.PyObjectHashTable.get_item
File "pandas/_libs/hashtable_class_helper.pxi", line 1608, in pandas._libs.hashtable.PyObjectHashTable.get_item
KeyError: 'samples' `

@pgurazada I should mention I also don't know how to convert csv to pandas dataframe

@massimosclaw
Firstly, pd.read_csv() will read the csv file into a pandas data frame. So you will not need any extra work on that. Secondly, it appears to me that your data frame does not have a column named 'samples' and the subsetting step data_df['samples'] fails (hence the KeyError). Kindly check if you have a column named 'samples' in your csv.
I understand where you are coming from. I am sure this link would help you grok pandas better - https://tomaugspurger.github.io/modern-1-intro.html

@pgurazada
Thank you so much! And thank you for the resource, will definitely check it out. Now it's giving me this error.
Traceback (most recent call last):
  File "/Volumes/Transcend/sentimentneuron/generating-reviews-discovering-sentiment/sentiment-extractor.py", line 10, in <module>
    text_features = model.transform(samples)
NameError: name 'model' is not defined

It seems to me this means the variable 'mode' hasn't been given a value? I'm not sure what value to give it though...

I also tried replacing
text_features = model.transform(samples)
with
text_features = sentiment_model.transform(samples)
And got this:
Traceback (most recent call last):
  File "/Volumes/Transcend/sentimentneuron/generating-reviews-discovering-sentiment/sentiment-extractor.py", line 12, in <module>
    text_features = sentiment_model.transform(samples)
  File "/Volumes/Transcend/sentimentneuron/generating-reviews-discovering-sentiment/encoder.py", line 156, in transform
    xs = [preprocess(x) for x in xs]
  File "/Volumes/Transcend/sentimentneuron/generating-reviews-discovering-sentiment/encoder.py", line 156, in <listcomp>
    xs = [preprocess(x) for x in xs]
  File "/Volumes/Transcend/sentimentneuron/generating-reviews-discovering-sentiment/utils.py", line 53, in preprocess
    text = html.unescape(text)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/html/__init__.py", line 130, in unescape
    if '&' not in s:
TypeError: argument of type 'float' is not iterable

@massimosclaw Thank you for pointing the error on the sentiment_model out. I now corrected my original comment. Seems to me there is some error in the data types of your columns. The encoder is returning an error on iteration? Would you be able to check if there are any missing values? Also, any data sanity checks on whether the strings are all encoded properly would help.

@pgurazada No prob!
Unfortunately, I don't know how to check if there are any missing values (or what that means exactly... empty cells?) as well as data sanity checks on whether the strings are all encoded properly... don't know what that means either. Anything in particular I should search for to learn more about that?

Found this... https://towardsdatascience.com/data-cleaning-with-python-and-pandas-detecting-missing-values-3e9c6ebcf78b - will read up on it.

@pgurazada I finally managed to get it to work just by deleting all other columns which contained links, dates, times, and other data. Thank you so much again for the help.
Wanted to ask one last question... how do you get the code to run on your GPU? As it takes a long time to run on my CPU.

@pgurazada I finally managed to get it to work just by deleting all other columns which contained links, dates, times, and other data. Thank you so much again for the help.
Wanted to ask one last question... how do you get the code to run on your GPU? As it takes a long time to run on my CPU.

I am so sorry, missed this out for some reason. On a GPU predictions are about 10x faster. I was using the standard Colaboratory GPUs.

could you kindly tell ,why you have taken ""sentiment_scores = text_features[:, 2388]"",2388 in text features.What is the use of it?

@divyag11  Please check out the original paper from Open AI. This is the activation of the sentiment neuron.

okay,thanks for your reply


TypeScript types

It would be nice if type declarations could be added to the project.

Hi @daviddelusenet 👋
We're working on a brand new version of the SDK. It's built with Typescript and will have all the typings out of the box. Stay tuned 😉

Nice!

The new version is out now!


doi for pre-published submission

Need doi for pre-published submission if submitted by the user to check if the submission has been linked to a pmid using the Article Status Monitor of European PMC.

@ljwh2 expand details

@sajo-ebi  this requires a script that curators can run periodically to generate a list of GCPs for all prepublication submissions (including embargoed submissions) and preprint DOI.  See screenshots for where DOI is displayed in the UIs

@Santhi1901 is there any other information that would be useful to include in the output, like author, title etc?

Yes it will be good if the title, as well as authors name can be included

@sajo-ebi columns in output should be GCP, first author, title, preprint DOI, embargo y/n
Not that note all submissions will have DOI, please list all submissions whether or not they have DOI, DOI can be blank or NA for those submissions.

Closing since we found a workaround in old curation app - search for wildcard in "Add Study" page gives all submissions including DOI


Image holder

Sorry but I cannot find a image hosting service in short time... (And my math homework is due tonight XD)

Here is the compressed version:


How can this shadow like effect be achieved?

I have been looking for a long time without finding an example.

@zkung  Please post your question (e.g. how can this shadow like effect be achieved?) to the official public forum => https://old.reddit.com/r/CryptoPunksDev/       Thanks.


Associated Log File

Reviewing microsoft-365/security/office-365-security/external-email-forwarding.md page - trying to find the log file that would be associated with this change. Would someone be able to provide either a sample log file generated, or how to search for this change log?
https://docs.microsoft.com/en-us/microsoft-365/security/office-365-security/external-email-forwarding

@mgetzem Thank you for your feedback. There are no such log files that get generated. Are you referring to an Admin audit log that confirms this change being made on the tenant?
Thanks
Sri

Yes, i apologize. I meant which admin audit log would capture this change

@mgetzem You can view the admin audit log from the EAC. You can find the steps here -https://docs.microsoft.com/en-us/exchange/security-and-compliance/exchange-auditing-reports/view-administrator-audit-log#use-the-eac-to-view-the-administrator-audit-log
The specific cmdlet that you need to look for in the Log would be Set-HostedOutboundSpamFilterPolicy
Hope this helps!
Thanks
Sri

@msbemba Thank you very much for the contribution and sharing this explanation. @mgetzem Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


code to evaluate rules asynchronously is synchronous

There is code in finding.save() to evaluate rules asynchronously:
       if rules_option:
            from dojo.tasks import async_rules
            from dojo.utils import sync_rules
            try:
                if self.reporter.usercontactinfo.block_execution:
                    sync_rules(self, *args, **kwargs)
                else:
                    async_rules(self, *args, **kwargs)
            except UserContactInfo.DoesNotExist:
                async_rules(self, *args, **kwargs)
                pass

However, in all cases the rules are evaluated syncrhonously.
The call to async_rules should really be async_rules.delay.
And probably the call for when usercontactinfo doesn't exist should default to synchronous.
I don't want to change it rightaway as I don't know what people are using rules for and if it will affect dedupe etc.

@valentijnscholten I'm not sure if some delay causes these to function correctly or if it is a side effect. But generally speaking, the functions have worked for me as intended.

Fixed in pr


Master to Live

Docs Build status updates of commit e6c600b:
:clock10: Full build: the average full build time is 12 min(s) 13 sec(s), this is based on the last 584 build(s) for this repository.

Docs Build status updates of commit e6c600b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/devices/Get-ActiveSyncDeviceStatistics.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/mailboxes/Search-Mailbox.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/organization/Set-OrganizationConfig.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/policy-and-compliance-audit/Search-UnifiedAuditLog.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/users-and-groups/Add-UnifiedGroupLinks.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/users-and-groups/New-DynamicDistributionGroup.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[Image] wardenenv/nginx:1.16

Version of Warden
0.14.3
Operating System and Installation Method
WSL2 Ubuntu Windows 11
Image
docker.io/wardenenv/nginx:1.16
Describe the Bug
2024-10-01 11:17:52 2024/10/01 01:17:52 [emerg] 1#1: "proxy_cache" zone "catalog_media" is unknown in /etc/nginx/nginx.conf:34
2024-10-01 11:17:52 nginx: [emerg] "proxy_cache" zone "catalog_media" is unknown in /etc/nginx/nginx.conf:34
The container is not starting.

To Reproduce
warden env up
Expected Behavior
No response
Additional context
No response

cc @theuargb It looks like this is a bug related to https://github.com/wardenenv/images/pull/32 - can you use your expertise to resolve it?

@ssniranga Do you by chance use a custom nginx configuration file in this environment?

Hi @ssniranga,
Could you please provide some logs of nginx, so we would see what could cause such issue?


Added tests for F15 and I01 (without REX)

added tests based on data contributed in #41 and #48.
added str methods to make debugging easier
fixed bug in parsing cbsData

@ChristianKuehnel
ready to be merged

Thx :owl:


Please clarify what you mean with "when you DELETE a user"

Up to now we have DELETED users by blocking sign in. In this document you are not making clear what action you exactly refer to when you say  "when you delete a user" . I realize that from your perspective is should be totally clear .. duh "you press delete" , but you need to clarify please, using Azure, Using O365, what step triggers this.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 762932d1-8eef-ea51-c51d-a40ed88b8237
Version Independent ID: d0ef71ba-21b3-1352-85b5-63d7882782da
Content: OneDrive retention and deletion
Content Source: OneDrive/retention-and-deletion.md
Service: one-drive
GitHub Login: @kaarins
Microsoft Alias: kaarins

Deletion means removed from Azure AD. Blocking, as you're doing, isn't deleting. See the first step, which outlines what you're asking:

A user is deleted from the Microsoft 365 admin center or is removed through Active Directory synchronization.

Thank you Trevor,
My remark is/was more for other readers to benefit from and to share how
readers may not quite get unless really really clear. Ok maybe it's me :-)
Thank you for confirming
Bart
Bart Louwagie
Holmes, NY
<EMAIL_ADDRESS>845 202 0239 (google voice)
http://louwagie.com
https://www.linkedin.com/in/bart-louwagie/
(when conference call is needed)
On Mon, Jun 24, 2019, 15:57 Trevor Seward<EMAIL_ADDRESS>wrote:

Deletion means removed from Azure AD. Blocking, as you're doing, isn't
deleting. See the first step, which outlines what you're asking:
A user is deleted from the Microsoft 365 admin center or is removed
through Active Directory synchronization.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/OfficeDocs-SharePoint/issues/1110?email_source=notifications&email_token=AESZT5OUWTMRASHGWHP75JDP4ERJBA5CNFSM4H3AUUT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYOBFNA#issuecomment-505156276,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AESZT5N7GJKRQP4DXGSSH6DP4ERJBANCNFSM4H3AUUTQ
.

@blouwagie is there anything in the article that you'd like to change? In my personal opinion, I think the 1. section under 'The OneDrive deletion process' is fairly clear.

@officedocsbot assign @scanum

@blouwagie We appreciate any feedback that improves the content in the Microsoft docs but we haven't had any response from you so we are going to close this issue.

Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.

@officedocsbot close


using same dataset and same parameters while trained two different model

Describe the bug
when i tried to run unit test on linux, Serialization Fuzzing test may failed sometimes which shows that the prediction result for the same training dataset  may be inconsistent sometimes  after using deserialized model from disk. so, why it can't be the same ?
To Reproduce
i also wrote some codes to test, it may failed sometimes:
 test("Verify LightGBM Classifier output same model with same parameters") {
    val fileName = "PimaIndian.csv"
    val labelColumnName = "Diabetes mellitus"
    val fileLocation = DatasetUtils.binaryTrainFile(fileName).toString
    val dataset = readCSV(fileName, fileLocation).repartition(numPartitions)
    val featuresColumn = "_features"
    val rawPredCol = "rawPrediction"

    val featurizer = LightGBMUtils.featurizeData(dataset, labelColumnName, featuresColumn)
    val trainData = featurizer.transform(dataset).select(labelColumnName, featuresColumn)

    val lgbm1 = new LightGBMClassifier()
      .setLabelCol(labelColumnName)
      .setFeaturesCol(featuresColumn)
      .setRawPredictionCol(rawPredCol)
      .setDefaultListenPort(LightGBMConstants.DefaultLocalListenPort + portIndex)
      .setNumLeaves(5)
      .setNumIterations(10)
      .setObjective(binaryObjective)

    val lgbm2 = new LightGBMClassifier()
      .setLabelCol(labelColumnName)
      .setFeaturesCol(featuresColumn)
      .setRawPredictionCol(rawPredCol)
      .setDefaultListenPort(LightGBMConstants.DefaultLocalListenPort + portIndex)
      .setNumLeaves(5)
      .setNumIterations(10)
      .setObjective(binaryObjective)

    val model1 = lgbm1.fit(trainData)

    println("<=================== model ====================>")
    val model2 = lgbm2.fit(trainData)
    val df1 = model1.transform(trainData)
    val df2 = model2.transform(trainData)
    assertDFEq(df1, df2)
  }

Info (please complete the following information):

SynapseML Version: [v0.18]
Spark Version [2.4.3]
Spark Platform [Spark On Yarn]

** Stacktrace**
Please post the stacktrace here if applicable

If the bug pertains to a specific feature please tag the appropriate CODEOWNER for better visibility
Additional context
Add any other context about the problem here.

@imatiach-msft thanks for the reply, i also tried to using lightGBM distributed case ,it sounds like i can get the same result. i will keep attention on it, thanks~

closing as lightgbm is now deterministic with merged PR https://github.com/microsoft/SynapseML/pull/1387 as long as seed and deterministic=True parameters are set


Use correct service name in livy ingress

When I deployed the spark-cluster helm chart, I noticed the ingress config does not work. This is because the spark cluster helm chart changes the livy service name. However, in the ingress template of the livy chart, the configured value is not used. I fixed it by using the same function that is used in the service to generate the name there.

Awesome catch @andreas-eberle . Thx for the contribution!

Awesome catch @andreas-eberle . Thx for the contribution!


Another thing - tags for datasets - probably something to go in user interface

for autogenerating websites it may be useful to have some defined tags for production datasets similar to those used to classify rucio datasets.
Joe user can find datasets by looking tags.
tags:
core.file_type
core.data_tier
core.run_type
DUNE.campaign
core.application.version
core.application.name
the script that makes the dataset should know these things and be able to set them as metadata for the dataset.
I think this is a script that goes in the metacat utilities area, not a base feature but very handy.

Will there be a cli client?  Will there be a web portal with pull down choices.


⚠ Jenkins Plugins Artifactory has degraded performance

In ecf4ebd, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 2255 ms

Resolved: Jenkins Plugins Artifactory performance has improved in ff2e5b9 after 21 minutes.


add judge before use slices's index

API changes
add judgw before use slices's index,if the index is out of the length then is will be crashed
/kind
Supported kinds are: bug, cleanup, design, documentation, failing-test, feature, flake, misc, question, tep
-->

Thanks! @pengbinbin1


feat(operator): pass teardown function to refCount

Feature Request
Is your feature request related to a problem? Please describe.
Sometimes, when sharing an observable (e.g. via share() operator), I wish to attach a cleanup function which is called when the last subscriber unsubscribes from the observable. As far as I can tell, currently this is not possible.
Describe the solution you'd like
Update the refCount() operator to accept a teardown function which is called whenever the last subscriber unsubscribes.
Describe alternatives you've considered
I cannot think of an alternative option. Currently, I've forked the refCount() operator and patched it to provide this functionality.
(If this is new operator request) describe reason it should be core operator
N/a
Additional context
N/a

If this is change is accepted, I can put together a PR.

To do what you want, you should be able to place a finalize operator before the share operator.

Oh that's much better! I didn't realize that share() completed the source observable when the last subscriber unsubscribed. Thanks!

share doesn't effect the completion of the source observable. Rather, finalize invokes its callback upon explicit unsubscription - not just upon complete or error notifications.

@cartant thanks. That is an important distinction. Am I reading the finalize() docs wrong? It doesn't appear to say that.

The JSDoc mentions it. IDK why the generated docs don't:
https://github.com/ReactiveX/rxjs/blob/56e7cebd211d93b9958e1ec508052beb8927604a/src/internal/operators/finalize.ts#L8-L10

@cartant strange. I just downloaded rxjs v6.5.4 which has the following jsdoc
/**
 * Returns an Observable that mirrors the source Observable, but will call a specified function when
 * the source terminates on complete or error.
 * @param {function} callback Function to be called when source terminates.
 * @return {Observable} An Observable that mirrors the source, but will call the specified function on termination.
 * @method finally
 * @owner Observable
 */
export declare function finalize<T>(callback: () => void): MonoTypeOperatorFunction<T>;

I guess whatever PR added that comment hasn't been released yet.

Anyway, thanks again for the info!


Add support for custom validators

This PR adds support for custom validators that are registered with <iron-meta> element. The implementation is based on how the support is done in <paper-input>.
Fixes #128

This change is

Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion.

test/form-input.html, line 16 [r1] (raw file):
Need to add iron-meta to devDependencies

Comments from the review on Reviewable.io

Review status: 0 of 5 files reviewed at latest revision, 1 unresolved discussion.

test/form-input.html, line 16 [r1] (raw file):
Done. I was just pushing an updated version at the same minute, you made the comment. :smile:

Comments from the review on Reviewable.io

vaadin-date-picker.html, line 505 [r4] (raw file):
Don't know if it's a problem but after the change datepicker._getValidity() returns a different value for disabled&required datepicker than before?

Comments from the review on Reviewable.io

Review status: 0 of 5 files reviewed at latest revision, 2 unresolved discussions.

vaadin-date-picker.html, line 505 [r4] (raw file):
You're right. Compared how this is done with paper-input and made few changes on how the readonly and disabled are handled.

Comments from the review on Reviewable.io

Reviewed 2 of 4 files at r2, 1 of 2 files at r4, 2 of 2 files at r5.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io


⚠ Bofrost.es has degraded performance

In add4694, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1760 ms

Resolved: Bofrost.es performance has improved in b1183a2 after 6 minutes.


Lacking route-specific middleware chain

What is the problem this feature would solve?
I would like to see a solution where I can pass multiple handlers or middlewares to a specific route, being able to funnel the request through and prevent passage to subsequent handlers.
What is the feature you are proposing to solve the problem?
I would like to be able to pass multiple handlers in an array, similar to Express. Maybe produce a function to create a new middleware chain, where the argument passed is an array of handlers, or provide the option to pass an array of handlers/middleware where a single handler is the only option at this time.
What alternatives have you considered?
I have seen examples of custom middleware implementations that are framework agnostic, but I do question their robustness.

Yes, manual middleware can make code inefficient and difficult to understand

Technically we lifecycle can perform the same as middleware but just with a named or a point in time. So basically nothing stopping you from doing that as you can just pass an array to a specific lifecycle.
For example:
new Elysia()
	.get('/', () => 'a', {
		beforeHandle: [
			() => {
				console.log(1)
			},
			() => console.log(2)
		]
	})

Either way, you could also use https://elysiajs.com/patterns/macro.html#macro to achieve the same effect.
Closing as complete, and not going to implement.


Object description metadata lost/wrong when saving NWB files

When saving Neo objects to NWB files using the NWBIO, the information in the description metadata field of several objects is lost or wrongly changed:

If two blocks are saved, when they are reloaded from the NWB file, the description of the second will be equal to the one from the first;
Descriptions of AnalogSignal are replaced by a generic string no description;
Descriptions of Segment and SpikeTrain are lost.

When saving a single block, the behavior for AnalogSignals, Segments and SpikeTrains is similar.
The code below reproduces the behavior:
from datetime import datetime
import numpy as np
import quantities as pq
import neo
from elephant.spike_train_generation import StationaryPoissonProcess

def print_metadata(block):
    print(f"Block: {block.name}, description: {block.description}")
    seg = block.segments[0]
    print(f"\tSegment: {seg.name}, description: {seg.description}")
    signal = seg.analogsignals[0]
    print(f"\t\tSignal: {signal.name}, description: {signal.description}")
    for idx, st in enumerate(seg.spiketrains):
        print(f"\t\tST {idx}: {st.name}, description: {st.description}")

start_time = datetime.now()
blocks = []
for i in range(1, 3):
    block = neo.Block(name=f"Data {i}", description=f"The block {i}",
                      session_start_time=start_time)

    signal = neo.AnalogSignal(np.random.normal(size=(1000, 5)), units=pq.mV,
                              name=f"Signal {i}",
                              description=f"The signal of block {i}",
                              sampling_rate=1000*pq.Hz)

    segment = neo.Segment(name=f"Segment {i}",
                          description=f"The segment of block {i}")

    spiketrains = StationaryPoissonProcess(rate=10*pq.Hz).generate_n_spiketrains(3)
    for idx, st in enumerate(spiketrains, start=1):
        st.name = f"SpikeTrain {idx}"
        st.description = f"SpikeTrain {idx} of block {i}"

    segment.add(signal)
    segment.add(*spiketrains)
    block.add(segment)

    blocks.append(block)

# Inspect the metadata
print_metadata(blocks[0])
print_metadata(blocks[1])

print("\nSaving\n\n")
# Save and load as NWB
nwb_file = "test.nwb"
io = neo.NWBIO(nwb_file, 'w')
io.write_all_blocks(blocks)

print("\nLoading\n\n")
io = neo.NWBIO(nwb_file, 'r')
read_blocks = io.read_all_blocks()

# Inspect the metadata
print_metadata(read_blocks[0])
print_metadata(read_blocks[1])

Output (warnings on existing AnalogSignal names removed):
Block: Data 1, description: The block 1
	Segment: Segment 1, description: The segment of block 1
		Signal: Signal 1, description: The signal of block 1
		ST 0: SpikeTrain 1, description: SpikeTrain 1 of block 1
		ST 1: SpikeTrain 2, description: SpikeTrain 2 of block 1
		ST 2: SpikeTrain 3, description: SpikeTrain 3 of block 1
Block: Data 2, description: The block 2
	Segment: Segment 2, description: The segment of block 2
		Signal: Signal 2, description: The signal of block 2
		ST 0: SpikeTrain 1, description: SpikeTrain 1 of block 2
		ST 1: SpikeTrain 2, description: SpikeTrain 2 of block 2
		ST 2: SpikeTrain 3, description: SpikeTrain 3 of block 2

Saving

Loading

Block: Data 1, description: The block 1
	Segment: Segment 1, description: None
		Signal: Segment 1 Signal 1 0, description: no description
		ST 0: SpikeTrain 1, description: None
		ST 1: SpikeTrain 2, description: None
		ST 2: SpikeTrain 3, description: None
Block: Data 2, description: The block 1
	Segment: Segment 2, description: None
		Signal: Segment 2 Signal 2 0, description: no description
		ST 0: SpikeTrain 1, description: None
		ST 1: SpikeTrain 2, description: None
		ST 2: SpikeTrain 3, description: None

Expected behaviour
Preserve metadata when saving to NWB, only changing names to guarantee uniqueness
Environment:

OS: Ubuntu
Python 3.10
neo==0.13.0
numpy==1.26.4
quantities==0.15.0

@apdavison is working on updating the nwb reading in neo so he can read over this


Turn on warnings as errors by default, and fix some warnings

Couple of problems with the ROCm backend, but I'm going to skip over those for now, since they were warnings in AMD's code.


Ff

Kindly follow the step on this link to talk to the customer care service directly on your issues anyone asking you to DM is a scam
https://direct.lc.chat/14201763/

🤔


fix: update to eye v10.11.4

fix: update to eye v10.11.4

:tada: This PR is included in version 16.10.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v16.10.4

Your semantic-release bot :package::rocket:


Comment out helpful tips in ISSUE_TEMPLATE so they're visible only when editing

The comments are now visible only to the issue creator and do not need to be manually removed before submitting the issue.

Thank you for the contribution!

Thanks for the framework in the first place!

Then again, I did that on purpose to make sure people were paying attention.

Then again, I did that on purpose to make sure people were paying attention.

Not sure it makes a difference, I found out I read it when it appears suddenly because it does not appear in the preview. That happened when opening this PR

Sorry @davidism, want me to revert?


buildGoModule: add ./ to all sub-packages

Motivation for this change
When $subPackages has more than one item, the build was failing because ./ was added only to the first subPackage. This commit adds ./ to all specified subPackages.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

closes #63923
cc @gazally @worldofpeace

@GrahamcOfBorg build pdfcpu hugo golangci-lint caddy jx rclone

@gazally your package now works on my side. Please try it on your side and LMK so I can merge.

I tried it and it works now, thanks.

Thank you for trying it. I'll merge this then.


Errors are not consistent

Comparing /vehicles to /launchpads, the error messages for invalid id's are not consistent, complicating error handling.
Observed behavior:
GET https://api.spacexdata.com/v1/vehicles/bad
{   "error": "No Endpoint Found" }
Status code is 404: Not Found
GET https://api.spacexdata.com/v1/launchpads/bad
{   "error": "No Matches Found" }
Status code is 200: OK
Expectation:
Both would return the 'No Matches Found' message. I have no opinion on status code, though the most REST-ful would be 404's in both cases.

I agree, both should return a 404, regardless of the message. I'll reduce it to a single agnostic 404 error message, to make it easier to check for, as opposed to multiple. 👍

All errors now return the following {"error": "No results found"} with a 404 status code

Thanks


Publish prep

What's Changed

explicitly set minimum compatible java version to java 17
add jitpack config file to configure runner to use java 17
remove redundant version declarations in packages
fix message and resource digest computations

sha-256 hashing the canonicalized json was missing

verify - default assertionMethods to an empty list if null

@jiyoontbd thoughts on making e2e file an integration test of http-client? we can do so by adding an integration-tests package to http-client/src. Otherwise we'll need to shuffle some stuff around in the build.gradle.kts files so that the e2e package isn't published.

@michaelneale is the current state of httpserver taking ktor.server for a test drive to see what it's capable of? if so, thoughts on moving your findings to a branch or issue? thinking about removing the module until there's some meat on the bones

Yep the server is just a placeholder - can move it

@mistermoe yeah after you merge (or part of this) could move it out, or just don't publish the server? https://github.com/TBD54566975/tbdex-kt/issues/23 is the issue BTW

@jiyoontbd thoughts on making e2e file an integration test of http-client? we can do so by adding an integration-tests package to http-client/src. Otherwise we'll need to shuffle some stuff around in the build.gradle.kts files so that the e2e package isn't published.

Totally good with me if you'd like to move the e2e.kt into httpclient in this PR :)

Do we want to go ahead and bump to
implementation("com.github.TBD54566975:web5-kt:0.0.5-beta")

yep good call @KendallWeihe. on it

@KendallWeihe bumped. thoughts on surfacing web5-kt via api dependency instead of implementation? prevents people from having to include both as deps

@KendallWeihe bumped. thoughts on surfacing web5-kt via api dependency instead of implementation? prevents people from having to include both as deps

Yeah it's the same question we're puzzling over in tbdex-js with regards to the peer dependencies. I think it's sort of a six of one, half a dozen to the other. I do think I side with the peer dependency approach because of one particular reason, I outlined it in this comment.

I thought more about this and am fully bought in with this approach. The primary reason being Developer experience. Sure it's a slightly less good experience to have to install two packages. But, it makes the distinction between tbdex the transport agnostic protocol and the specific implementation over http much less ambiguous. Which is to say we're making it clear that tbdex isn't married to http.


Bad performances.

Whatever iOS or Android, when devices has alot of picture, and calling MediaPickerBuilder.getAlbums, It looks like media_picker_builder try to build all of photos  or videos thumbnail and get path for it, This is very slow and use too much memory, sometime my app crashed because this, Is there anyway to disable auto generate thumbnail? or let it as a getter or Future or someother defer behavior?

Hi,
getAlbums actually only returns thumbnails if there was already a thumbnail cached in the device. If not, it will not generate a new thumbnail.
Get the thumbnail using getMediaFile individually when the item is in display.
i.e.
if(mediaFile.thumbnailPath == null)

FutureBuilder(
            future: MediaPickerBuilder.getMediaFile(
              fileId: mediaFile.id,
              type: mediaFile.type,
              loadIOSPath: true,
              loadThumbnail: true,
            ),
            builder: (BuildContext context, AsyncSnapshot<MediaFile> snapshot) {
              if (snapshot.hasData) {
                var updatedMediaFile = snapshot.data;
                mediaFile.thumbnailPath = updatedMediaFile.thumbnailPath;
                mediaFile.duration = updatedMediaFile.duration;
                mediaFile.mimeType = updatedMediaFile.mimeType;
                mediaFile.orientation = updatedMediaFile.orientation;

}

I understand there is a performance issue (ONLY on iOS) when you have a lot of assets (i.e >2k) and its not related to generating the thumbnail. It's how the albums and pictures are stored in iOS and the native api provided by iOS is not scalable for retrieving that many assets.
There is no performance issue with android though. I have over 10k pictures and videos and its very quick.

I am working on fixing the performance for iOS. Any suggestions or help will be appreciated.

It looks like you can fetch a fixed amount of images on iOS. https://developer.apple.com/documentation/photokit/phfetchoptions/1624761-fetchlimit. Maybe it would be best to only fetch maybe 25 assets at a time and then fetch more when requested.

Did this ever get fixed? I still have bad performance for iOS

修复了吗？


Running in TrueNAS Scale: bc missing

./zfs-inplace-rebalancing.sh: line 60: bc: command not found
My guess it is something just missing in the base install of TrueNAS Scale.
What are your thoughts running the script in a Docker container that has the missing component?

if you download bc.deb you can extract and copy bc out. I just did this
http://ftp.us.debian.org/debian/pool/main/b/bc/bc_1.07.1-2+b2_amd64.deb
download that, use 7zip to extract, grab bc binary, chmod +x it and put it in /usr/bin...then works.

wget http://http.us.debian.org/debian/pool/main/b/bc/bc_1.07.1-2+b2_amd64.deb && \
dpkg -i bc_1.07.1-2+b2_amd64.deb && \
rm bc_1.07.1-2+b2_amd64.deb

is the quick and dirty line that I use

that works too =)

Sure, creating a docker image would be an option.

There exists a Docker image now:
https://github.com/markusressel/zfs-inplace-rebalancing/pkgs/container/zfs-inplace-rebalancing
I will go ahead and close this issue. Feel free to open another if anything comes up.


Remove algorithms that are superseded with many-to-many matching algorithm

With an implementation of many-many n-level proposing algorithm, there may not be a need for other algorithms.

Removed HHeuristicHRLQ and RHeuristicHRLQ. These algorithms are not well tested and will be superseded by a new implementation.