Install Git and OpenSSH Client to allow non mounted config

We use TugboatQA to build images of pull requests that we'd like to test with Cypress; however, we cannot mount volumes in this way and instead need to get the cypress config from the repo directly. The issue is the image doesn't contain openssh-client so you get the error:
Cloning into '/var/lib/tugboat'...
error: cannot run ssh: No such file or directory
fatal: unable to fork

I was able to fix this by adding openssh-client to my own docker image (I added git as well for good measure). Is this something we could get into the base image? It seems like a minimal change with large benefit:
FROM cypress/included:12.7.0

USER root

# install openssh-client
RUN apt-get update && apt-get install -y git openssh-client
RUN apt-get clean && \
    rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*

Hello @b-sharpe, we don't use openssh-client directly when running cypress, so it is not installed by default in an effort to slim down our docker containers and not provide dependencies unused by the majority of cypress users.  We have made exceptions in the past for small dependencies like curl that have wide use. In cases where we do not add the dependency, your workflow is exactly correct and expected, extend the docker container and add your dependency.
We do install git by default.

@b-sharpe, good news! I've decided to do this.... mostly because i found a need in our own CI... but a win a win right? 😬

@mjhenkes Tugboat was nice enough to create images of their own for me here but this does help my local machine, so thanks!


AiService throw a ClassNotFoundException outside of a request scope

Description
Hello, I'm working on a project using Quarkus + Kotlin + Langchain4j with a queue system that uses Kotlin Coroutine to call specific quarkus services to handle specific task.
I'm taking advantage of Kotlin Coroutine to allow multiple task being run when limiting the number of total executions.
(i've provided a basic representation of the system in Steps to Reproduce section)
The issue here, is when calling the service that handle the task which has a AiService has a dependency, i get a java.lang.ClassNotFoundException when calling this AiService.
The service can only be used inside a request scope level while i've added the @ApplicationScoped annontation on the AiService.
The exact stacktrace is : https://pastebin.com/5A5aQniX
Expected Behavior
Being able to use the AiService outside of a request scope when using the @ApplicationScope annontation on the AiService.
Current Behavior
The service only working on a request scope level, outside we get a ClassNotFoundException.
Solution
?
Steps to Reproduce

Git clone : https://github.com/anis-gha/quarkus-kotlin-coroutine-langchain-bug
Run quarkusDev (no api key needed since it's doesn't not work)
Call http://localhost:8080/api/ (curl -X GET -v http://localhost:8080/api/)

Thank you for your help !

Thanks for the great report description and the reproducer.
I'll have a look in a few days

This has to do with the fact that when Coroutines are launched, the Thread Context ClassLoader is not set properly.
Using the following diff, things start to work as expected:
diff --git a/src/main/kotlin/gg/anis/api/ApiService.kt b/src/main/kotlin/gg/anis/api/ApiService.kt
index e8bdecf..cf2e4ff 100644
--- a/src/main/kotlin/gg/anis/api/ApiService.kt
+++ b/src/main/kotlin/gg/anis/api/ApiService.kt
@@ -38,7 +38,9 @@ class ApiService(

     @Startup
     open fun startup() {
+        val originalTCCL = Thread.currentThread().contextClassLoader
         launch {
+            Thread.currentThread().contextClassLoader = originalTCCL
             processQueue()
         }
     }
@@ -63,7 +65,9 @@ class ApiService(
                 delay(100)
             }

+            val originalTCCL = Thread.currentThread().contextClassLoader
             launch {
+                Thread.currentThread().contextClassLoader = originalTCCL
                 try {
                     activeScans.add(queuedScan.id)
                     processScan(queuedScan)
@@ -82,8 +86,9 @@ class ApiService(
         try {
             val service = scanServices.firstOrNull { it.canHandle(queuedScan) }
                 ?: throw Exception("No suitable service found for scan ${queuedScan.id}")
-
+            val originalTCCL = Thread.currentThread().contextClassLoader
             val result = withTimeout(1.minutes.inWholeMilliseconds) {
+                Thread.currentThread().contextClassLoader = originalTCCL
                 service.processScan(queuedScan)
             }

@@ -103,4 +108,4 @@ interface ScanService {

 data class Scan(
     val id: UUID
-)
\ No newline at end of file
+)
diff --git a/src/main/resources/application.properties b/src/main/resources/application.properties
index f0d3d48..538b75b 100644
--- a/src/main/resources/application.properties
+++ b/src/main/resources/application.properties
@@ -3,4 +3,6 @@ quarkus.langchain4j.openai.log-requests=true
 quarkus.langchain4j.openai.log-responses=true
 quarkus.langchain4j.openai.chat-model.model-name=chatgpt-4o-latest
 quarkus.langchain4j.openai.timeout=60
-quarkus.langchain4j.chat-model.provider=openai
\ No newline at end of file
+quarkus.langchain4j.chat-model.provider=openai
+
+quarkus.package.jar.decompiler.enabled=true


useFormik example

Thanks for making us easier using formik and material-ui. I keep failing integrate useFormik and the TextField come from package.
on example it needed <Field /> from formik but useFormik can't use that.
how to use the component with useFormik?

This package in no way prevents the useFormik hook from being used. I use the hook myself a lot in my projects. Perhaps you will deal with the subject of hooks and context again in detail.

I failed to make it work with hooks.
Always the same error but maybe I did it wrong ?
codesandbox: https://codesandbox.io/s/gifted-knuth-wv453

From the docs
It seems there components are infact incompatible with useFormik
** Be aware that <Field>, <FastField>, <ErrorMessage>, connect(), and <FieldArray> will NOT work with useFormik() as they all require React Context.


Memory leak in Kubernetes discovery

Bug Report
What did you do?
Ran Prometheus v2.2.1 plus latest race patches (https://github.com/prometheus/prometheus/compare/v2.2.1...f8dcf9b272c9ab1a6148ccc22c4de6d4403c601d) for several days.
What did you expect to see?
Stable memory footprint.
What did you see instead? Under which circumstances?
Memory leak, daily crashes.

Environment

System information:
Linux 4.4.10+soundcloud x86_64

Prometheus version:
custom built from https://github.com/prometheus/prometheus/commit/f8dcf9b272c9ab1a6148ccc22c4de6d4403c601d

Prometheus configuration file:
22 jobs (17 kubernetes_sd from a big cluster, 1 ec2_sd, 2 dns_sd, 2 static_config)

Profiles

16:36 pprof.prometheus.alloc_objects.alloc_space.inuse_objects.inuse_space.001.pb.gz
18:32 pprof.prometheus.alloc_objects.alloc_space.inuse_objects.inuse_space.002.pb.gz
svg 002.svg.gz

pprof top 10 comparison
Showing nodes accounting for 1743.66MB, 36.60% of 4764.52MB total
Dropped 220 nodes (cum <= 23.82MB)
      flat  flat%   sum%        cum   cum%
  502.03MB 10.54% 10.54%   453.03MB  9.51%  github.com/prometheus/prometheus/vendor/github.com/ugorji/go/codec.(*jsonDecDriver).DecodeString
  333.68MB  7.00% 17.54%    27.52MB  0.58%  github.com/prometheus/prometheus/vendor/github.com/prometheus/tsdb/chunkenc.(*bstream).writeBits
  327.53MB  6.87% 24.41%    29.50MB  0.62%  github.com/prometheus/prometheus/vendor/github.com/prometheus/tsdb.(*memSeries).cut
 -294.53MB  6.18% 18.23%  -294.53MB  6.18%  github.com/prometheus/prometheus/vendor/github.com/prometheus/tsdb/chunkenc.NewXORChunk (inline)
  262.15MB  5.50% 23.74%   269.65MB  5.66%  github.com/prometheus/prometheus/vendor/k8s.io/client-go/pkg/api/v1.codecSelfer1234.decResourceList
 -216.12MB  4.54% 19.20%  -216.12MB  4.54%  github.com/prometheus/prometheus/vendor/github.com/prometheus/tsdb/chunkenc.(*bstream).writeByte (inline)
 -147.56MB  3.10% 16.10%  -147.56MB  3.10%  github.com/prometheus/prometheus/vendor/github.com/prometheus/tsdb/chunkenc.(*bstream).writeBit (inline)
  134.66MB  2.83% 18.93%   134.66MB  2.83%  reflect.unsafe_NewArray
  132.13MB  2.77% 21.70%   776.30MB 16.29%  github.com/prometheus/prometheus/vendor/k8s.io/client-go/pkg/api/v1.codecSelfer1234.decSliceContainer
  130.57MB  2.74% 24.44%   144.37MB  3.03%  github.com/prometheus/prometheus/scrape.(*scrapeLoop).append

Built from 2cbba4e9485a130cf317e117d4f3a3bf54142088 now (finally a version without known data races so that we can rule out races as a chaos source). Still seing the memory leak. New interesting finding: The K8s pod targets were not updated (Prometheus tried to scrape pods that didn't exist anymore and failed to scrape the new pods). I could fix that by sending SIGHUP which then also brought the escalating memory usage back to normal levels.
This seems to have to do with something in K8s SD getting stuck.

Fixed by #4117 .


Turning on takes 1.5 seconds

This feels like a while, from a users perspective. Is this due to one step in particular?

On https://en.wikipedia.org/wiki/Prime_number, on my shitty laptop,
detectSentenceBoundary() can range from
0.619 s
3.942 s
..
And one instance it waited for a few seconds that caused my browser to crash.
Note that this is a page with a lot of math symbols.

Nice job isolating it!!

Some non-mutually exclusive fixes:

If detect , skip
Actually fix  handling
If number of sentences >> x, skip
Implement a streaming sentence processing logic where you don't preprocess everything at once, but preprocess only the K neighboring paragraphs (much trickier to implement, but that's what video games do)

I think 3 strikes a good balance at the moment between easiness and user not noticing it (though all seem like fine options)

Detecting sentence boundaries done in 36.634 s
-- I think my browser was about to crash this time.
I have a possible fix for the math problem.
Impose a min number of non-empty chars that each sentence should have. If too small, merge the sentence with the next.
I think this would solve the math issue, which then reduces the number of sentence boundaries, which then makes most pages renderable.
Still need to handle "too big won't parse" someday tho. I wanna see if this fix works first.

For reference,
https://en.wikipedia.org/wiki/Language has 500 ish words
ttps://en.wikipedia.org/wiki/Prime_number has 2800 ish words because of missegmentation of math els.

Even for language, for my crappy computer, sometimes
DEBUG: Number of sentences = 511
content_script.js:17 DEBUG: Detecting sentence boundaries done in 19.18 s

https://github.com/benfrancis314/reading_project/pull/108


allow changing some properties of keyword completions

right now the keyword completions are impossible to really change in any way, and it's super annoying, because we'd like to have autocomplete sections in our app, but if we put anything in any section, that section will placed below all the hundreds of keywords. we'd love to put the keywords in a section below the other far more important stuff

I think, rather than trying to make the package support all these options, it makes more sense to provide an option to disable keyword completion entirely, and have people who want something like this do that and use dialect.spec.keywords directly to build their own completion. Does that sound reasonable?

I think that would be a lot more work for us. Generally we prefer adding options if something already does very nearly what we want, instead of cloning an entirely new implementation into our own codebase. We've already forked for this fix, so if there's any way to get something like this upstream, I'm all ears. Otherwise, this is the easiest and most time-effective solution for us right now.

Does attached patch, which allows you to pass in a function that builds up the keyword completions, work for you?

Great. I've tagged 6.8.0.


Upgrade ruby and gems

About
Seasonal upgrade

newest ruby
upgrade all gems
upgrade rubocop and fix style due to new cop
remove hakiri since this is integrated in github

waiting on ruby 2.6.5 availability in rbenv


Unable to read memory on x86-64 Ubuntu

I was testing this out on an Ubuntu 22.04 (64-bit) virtual machine under VMware Fusion, and having some issues. Same results when I install version 0.6.1 from cargo or when I build and run from the current HEAD of main, which is:
mmyers@ubuntu-22-04-vm:~/Desktop/avml$ /home/mmyers/.cargo/bin/avml --version
avml 0.6.1
mmyers@ubuntu-22-04-vm:~/Desktop/avml$ sudo /home/mmyers/.cargo/bin/avml ~/Desktop/quick_test_0.6.1.lime
Error: error: unable to read memory
caused by:
    0: unable to create memory snapshot:
        error: unable to create memory snapshot from source: /dev/crash
        caused by:
            0: unable to create memory snapshot
            1: unable to read memory
            2: No such file or directory (os error 2)

        error: unable to create memory snapshot from source: /proc/kcore
        caused by:
            0: unable to find memory range: 175116312..175124567

        error: unable to create memory snapshot from source: /dev/mem
        caused by:
            0: unable to create memory snapshot
            1: write block failed: 1048576..175116311

The filesystem should have ~55 GB free, and the RAM to capture should be ~12GB uncompressed. But this seems more of a failure to read memory than to dump it? I understand that AVML will iterate over the memory sources to find a functional source. so I suppose all three methods failed here.
This looks like https://github.com/microsoft/avml/issues/73 but I will try to be responsive here to figure out what this is.

Having the same issue. Any updates?

You're correct that unless AVML is writing output in a streaming fashion, it will iteratively try each source until one succeeds.
I'm not able to reproduce this issue locally.  I've tested on Ubuntu 22.04 VMs in Azure with 1GB, 16GB, and 32GB of ram respectively.  I will try to put together PR that will provide more information to help debug this issue.

Perhaps the VM is booting in 'secure' mode which disables raw memory access?

This is what @bmc-msft determined from additional info I sent him:

AVML coalesced sequential ranges, but the pseudo-headers that /proc/kcore creates doesn't do that.
AVML should be more inclusive of which pseudo section headers it uses to refer to physical memory.

So he's going to remove the coalescence of sequential ranges. I'll re-test when there's a new branch and see if it fixes it.

Can someone confirm if secure boot is the cause of this error? Basically, the tool is deprived of direct memory access?

I do not believe the issue to be secure boot related.

A fix that addresses this issue has been released as part of 0.7.0


Preview flashcards in Obsiadian sidebar (on the right)

Is this the same as #81? Or a list like the notes queue one?

It is exactly what is discussed in issue #81 but integrated in the sidebar like the note queue feature.
I imagined to be like clickable tiles that, once clicked, show the preview of the card in the same style the queue card feature does.


Add

Codecov Report

Merging #2528 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #2528   +/-   ##
=========================================
  Coverage     50.19%   50.19%
  Complexity     2046     2046
=========================================
  Files           410      410
  Lines         12554    12554
  Branches       1285     1285
=========================================
  Hits           6301     6301
  Misses         5806     5806
  Partials        447      447

Impacted Files
Coverage Δ
Complexity Δ

...ava/com/ctrip/framework/apollo/core/enums/Env.java
100% <100%> (ø)
3 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbb6d7d...608cd47. Read the comment docs.

Coverage remained the same at 53.752% when pulling 608cd47d40f25e9a0a2fab86988b0a541c528109 on luyufengbj:master into cbb6d7d5e8909dd9456cd8d05f85d709a38806df on ctripcorp:master.

@luyufengbj  misoperation？ Otherwise, you can refs https://github.com/ctripcorp/apollo/wiki/部署&开发遇到的常见问题#42-添加自定义的环境.

@luyufengbj misoperation？ Otherwise, you can refs https://github.com/ctripcorp/apollo/wiki/部署&开发遇到的常见问题#42-添加自定义的环境.

sorry, I just want pull new source merge into my own branch


The "Open structure" window doesn't match the mockup

Steps to Reproduce

Launch Ketcher
Click on "Open..." icon on the top menu
Select the "PASTE FROM CLIPBOARD" to open the "Open structure" window
Observe the "Open structure" window

Expected behavior
The "Open structure" window matches the mockup

Actual behavior
The "Open structure" window doesn't match the mockup

OS: [Microsoft Windows]
Browsers: Google Chrome: Version 100.0.4896.75/FireFox: Version 99.0 (64-bit
Ketcher v2.4.2-180-gf29e041f

The mockup isn't relevant
Open structure window should contain textarea


i cant install script on my atom

im finding it difficult to install script on my atom

To help you we need more information.  What is happening? Do you have screen shots?  Do you see an error?


fix: permissions changes for subscriptions after keyloak optimisations

Checklist

[ ] Affected Issues have been mentioned in the Closing issues section
[ ] Documentation has been written/updated
[ ] PR title is ready for inclusion in changelog

When #3397 was introduced, changes to the context were made, but the subscriptions was missed. This broke subscriptions permissions checks, so they resulted in a weird error that wasn't a permission denied error, but an undefined id error because the current user and all the new information was not passed through to the permission function.

woot!
We can now see the subscribers receiving the updated requests


Purge Line does not seem to be rendered

Hey there!
I'm working on a simple little python script that will help users generate a nice beefy line purge to prime the nozzle prior to printing.
I can see the preview of the line purge in my typical slicer, but when I try to render it in your gcode previewer live demo, it doesn't seem to show up. Not sure if it has something to do with where gcode starts being read, but figured it should be mentioned.
Here's the gcode rendered in Prusaslicer's previewer:

And here's how it's rendered in your live demo:

I'll also drop the sliced gcode file here, as a .txt,
Shape-Cylinder-9.52316g-24m.txt
Thanks so much! If you need anything else, let me know!

Hi @kyleisah, thanks for bringing this to our attention. We'll be taking a look at it soon.

Just found out that the purge line isn't rendered bc GCode Preview doesn't like spaces right before the numerical params.
So, this original snippet doesn't render a line:
G0 X95 Y 99.2894
G0 Z 0.8
G1 X155 E 50.0  F 718.42

While this version with the spaces removed does render a line:
G0 X95 Y99.2894
G0 Z0.8
G1 X155 E50.0  F718.42

Should be fixed soon in the parser. As a temporary solution you can remove the spaces for now.

Nice work! The additional spaces are something the script seems to be doing, I'll see if I can add some stuff to remove trailing spaces after the axis and feedrate denominations are printed out. Thanks again!

Sweet, fixed my script. Was escaping the print function to print variables and it all got so confusion. fstrings to the rescue!

That's great! And thank you for reporting back.
I'll keep this open so we'll fix this issue in the parser at some point.
Good luck with those beefy purge lines! 😉

Cheers!


[Feature Request] Clearer error message on login pages

Problem description
The error shown on login pages if something goes wrong is shown on the bottom of the page and easily missed.
Desired solution
Error message that the user cannot miss on page for login and related authentication pages (such as setup MFA, lost password, etc, etc)
Additional context
This is what it looks like at the moment, see small error on the bottom:

Better would be to show it in the login window, something like:

But then hopefully with a clearer message =]

Fixed in #222


Add new token to ethTokens.json

Add description for InsureX (IXT) token.

Company website: https://www.insurex.co
Support email<EMAIL_ADDRESS>


Configs say optimizer is AdamW but blog post says the optimizer is LION

The training configs (e.g. https://github.com/mosaicml/llm-foundry/blob/main/scripts/train/yamls/mpt/7b.yaml#L60) say the optimizer is decoupled_adamw, which calls through to here returning a DecoupledAdamW. The announcement blog post says all the models are trained with the LION optimizer:
We also train our MPT models with [the Lion optimizer](https://arxiv.org/abs/2302.06675) rather than AdamW,
which provides stable update magnitudes and cuts optimizer state memory in half.

Are the training config yamls in this repository supposed to be the ones used for the MPT training runs? If not, will the actual configs be made available?

Relatedly: I noticed that the linked config shows weight_decay: 0.0. Is that also correct for the official MPT models on Huggingface?

We'd also be interested in seeing the configs for how llm-foundry was used to fine-tune storywriter (long context) on 8xA100.

The scripts in the repo are just examples to show all the fields that are available for you to set. They aren't the configs for the actual hero run. We make those configs available to our customers.


Unable to download codesandbox

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example:
Steps:

Go to an example

Follow codesandbox button

In Files, click "export to ZIP"

Unpack the archive

navigate to the folder and run yarn && yarn start

Current behavior 😯

Failed to compile.

Module not found: Error: Can't resolve './Demo' in '/Users/janpotoms/Desktop/k5gwnp/src'
ERROR in ./src/index.tsx 7:0-26
Module not found: Error: Can't resolve './Demo' in '/Users/janpotoms/Desktop/k5gwnp/src'

webpack compiled with 1 error

Expected behavior 🤔

Run mv src/tsconfig.json tsconfig.json
Run again yarn start

Now it works
Context 🔦

Additionally when you log in, fork, and go to the docker tab and convert to a cloud sandbox, the same happens:

Related issue? https://github.com/mui/material-ui/issues/38530

Your environment 🌎

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

I noticed the default create-react-app template that ours is based on uses a src folder to contain the application. I suspect that it could start working if we change https://github.com/mui/material-ui/blob/7f81475ea148a416ec8fab252120ce6567c62897/docs/src/modules/sandbox/CodeSandbox.ts#L44-L49
to
    [`src/index.${ext}`]: {
      content: CRA.getRootIndex(demoData),
    },
    [`src/Demo.${ext}`]: {
      content: demoData.raw,
    },

Hey @siriwatknp,
I'm interested in working on this issue. Could you please assign it to me? I'd appreciate some guidance on how to get started and the best approach to tackle this.
Thanks!

Hey @siriwatknp,
I'm interested in working on this issue. Could you please assign it to me? I'd appreciate some guidance on how to get started and the best approach to tackle this.
Thanks!

Assigned, thanks for asking!

Hi @siriwatknp, Thank you for assigning the issue to me. I've taken a closer look at the problem and the suggestions provided by Janpot. I'm considering starting with the file structure adjustment as proposed. Before I proceed, I'd appreciate any insights or suggestions you might have on this approach or if there are other considerations I should be aware of.

Is this issue open ? Should I start working on it??

Hi @siriwatknp, Thank you for assigning the issue to me. I've taken a closer look at the problem and the suggestions provided by Janpot. I'm considering starting with the file structure adjustment as proposed. Before I proceed, I'd appreciate any insights or suggestions you might have on this approach or if there are other considerations I should be aware of.

I think you can try the suggestion from @Janpot and see if it solve the problem.

Hi, I have just started contributing to open source. If there are any changes you'd like to make to the PR please free to!
PS - Thank you @Janpot, the suggestion was tremendously helpful!


changing java version to 8 has no effect on centos

this needs a bit more testing ubuntu, to get java 8

#84 fixes java_version parameter


SignedTransaction should provide a way to avoid recalculating transaction hash

should we add some version of this with hash? recalculating the hash seems wasteful.
i took a peek at the codebase and it seems like we do this even when the type already has an hash .

.eg
impl TryFrom<WithOtherFields<alloy_rpc_types::Transaction>> for TransactionSigned {

or adding a `maybe_tx_hash() -> Option<TxHash>` to the trait, that can be checked here

Originally posted by @joshieDo in https://github.com/paradigmxyz/reth/pull/12187#discussion_r1828702979

Hi @joshieDo , I am checking this issue. Do you know what is the best way to check if a Transaction has a hash?
I can currently see that provided method signature_hash is a heavy operation that calculates the hash so I believe this is not the way to just perform the check.

Hi @joshieDo , I am checking this issue. Do you know what is the best way to check if a Transaction has a hash? I can currently see that provided method signature_hash is a heavy operation that calculates the hash so I believe this is not the way to just perform the check.

bring the alloy_network_primitives::TransactionResponse trait into scope makes method tx_hash accessible for the rpc transaction


[Proposal]: Increase timeout in probes

Currently the probes are using timeoutSeconds: 1 which works fine for local deployments. Using Amazon RDS that is too low.
bash-4.3# time curl -v localhost:8000/healthz
*   Trying ::1...
* connect to ::1 port 8000 failed: Connection refused
*   Trying <IP_ADDRESS>...
* Connected to localhost (<IP_ADDRESS>) port 8000 (#0)
> GET /healthz HTTP/1.1
> Host: localhost:8000
> User-Agent: curl/7.46.0
> Accept: */*
>
< HTTP/1.1 200 OK
< Server: gunicorn/19.4.5
< Date: Fri, 05 Feb 2016 19:10:22 GMT
< Connection: close
< Transfer-Encoding: chunked
< x-content-type-options: nosniff
< DEIS_API_VERSION: 2.0
< X-Frame-Options: DENY
< x-xss-protection: 1; mode=block
< DEIS_PLATFORM_VERSION: 2.0.0-dev
< Content-Type: text/html; charset=utf-8
<
* Closing connection 0
OK
real	0m1.120s
user	0m0.000s
sys	0m0.000s

I agree, @aledbf . Do you think we should simply set a higher limit, or make this configurable?

or make this configurable?

Configurable with a default? :)

Default of 5 seconds?

Default of 5 seconds?

:+1:

Just a heads up that right now the default for Deis apps is 1 second as well (https://github.com/deis/workflow/blob/master/rootfs/api/models/config.py#L32) with initial delay of 10 but it is pretty easily configurable.
While the deis platform itself can be treated differently we should probably go ahead and bump that default (and update the docs) for the apps if we decide on a 5 second timeout

I'm pulling this to RC1, since it's not a blocker for beta1. Feel free to PR a change whenever.


Add enabled flag for bucket logging for more comprehensive looping

Is your request related to a problem? Please describe.

When iterating over a list of buckets to create in AWS S3 multiple module instantiations must be created with conditionals for buckets that desire logging and buckets that do not.
Describe the solution you'd like.

By adding an optional logging.enabled flag (defaulted to true) to the logging input we can reduce instantiations to a single instance which sets logging to false as necessary.
Describe alternatives you've considered.

The only current alternative is to instantiate the module twice and filter a for_each with a conditional based on whether or not the specific bucket requires logging.
Additional context

It'd just be really nice to have!  Reduce code complexity, make the module more DRY, etc.

Not stale, just needs review.


disable pagination

Looking at the name of the project probably out of the scope :D
but is there a way to disable pagination (i just need to reuse the filters and maybe sorting and other applicable logic)?

just set defaultLimit and maxLimit very high 😅 so it returns always just a single page.

yep this is my actual workaround :) i was searching just if there was some cleaner way maybe can be implemented like putting limit value to 0/-1 (if allowed by maxLimit)

FYI, the workaround of setting an high default/maxLimit will cause a very inefficient query generated in case of relations on the table (something like https://github.com/ppetzold/nestjs-paginate/issues/329) that is not happening using the suggested PR

@FrancYescO Could elaborate in more detail about the differences? It still executes COUNT + FIND
An issue with the current implementation would be that it introduces an attack surface. Allowing every client to remove the resource limit can cause perf issues on the db (DoS attack).

The limit (and DoS protection) should be up to the dafault/maxLimit.
Count + find will cause the result query to have a giant list of OR for each row on each key of joined table:
...
Table WHERE (`Table`.`ID` = ? AND Table`.`secondID = ?) OR (`Table`.`ID` = ? AND Table`.`secondID = ?) OR (`Table`.`ID` = ? AND Table`.`secondID = ?) OR (`Table`.`ID` = ? AND Table`.`secondID = ?) OR (`Table`.`ID` = ? AND Table`.`secondID = ?) OR (`Table`.`ID` = ? AND Table`.`secondID = ?) OR (`Table`.`ID` = ? AND Table`.`secondID = ?) OR (`Table`.`ID` = ? AND Table`.`secondID = ?) OR (`Table`.`ID` = ? AND Table`.`secondID = ?) OR (`Table`.`ID` = ? AND Table`.`secondID = ?) -- PARAMETERS: ["169","3","170","3","171","3","172","3","173","3","174","3","175","3","176","3","177","3","178","3"]

(1) Ok, the PR tho used an infinite limit 😅
https://github.com/ppetzold/nestjs-paginate/pull/406/files#diff-c58e144dadf00250381ed55e6ce83245cda76aca84131ad494fd4911932f656fR180
(2) So, you are saying removing .take(limit).skip((page - 1) * limit) would create a better query
https://github.com/ppetzold/nestjs-paginate/pull/406/files#diff-c58e144dadf00250381ed55e6ce83245cda76aca84131ad494fd4911932f656fR247
(3) doesn't (2) imply that we query an infinite result set?

yep the PR maybe should be fixed to avoid allowing 0 if we have a 20 as maxlimit

yep

is what i want, if asking for a 0 limit

Yep no problem to modify the pr to include the maxLimit check.

to (1) if we must do (2) then setting maxLimit has no effect
I think, what it comes down to is that there cannot be any DoS protection. But I understand that there are use cases where this is neglectable.
So, I am okay adding this feature but it should be whitelisted. Something like enableLimitRemoval: true

Okay with that as well. But then no pagination would be possible on that endpoint. So always infinite resource requests.

Btw. not sure how typeorm handles this.
But if I any query all items, I don't need a separate COUNT. So you may optimize there as welk

Okay with that as well. But then no pagination would be possible on that endpoint. So always infinite resource requests.

pagination will be enabled if runtime i'll set the limit to something different than 0 (PR already act like this)

Okay with that as well. But then no pagination would be possible on that endpoint. So always infinite resource requests.

pagination will be enabled if runtime i'll set the limit to something different than 0 (PR already act like this)

once again, I am not okay with making it a default behavior due to the attack surface it opens
I understood you suggested using maxLimit: 0 instead of enableLimitRemoval: true. which is okay with me to act as whitelisting. but then there is no pagination while maxLimit: 0

ah okay, that's cool. I was reading it still literally but you meant maxLimit: 0 as way of disabling it.
sounds good to me. please add some lines to the README then :)

just got another needs (get the total count of filtered items avoiding to get all datas) and probably a little rework on this PR can help...
limit = 0 can be used to get the count of elements in the table (reading meta.totalItems) that actually is also bugged as it return 0 in this value
limit < 0 unpaginated

cannot really follow. could you explain with example query + response?

maybe easier in this way:
maxLimit: 0 = allowed only to count elements in the table
maxLimit: -1 = allowed to do unpaginated query (actual behaviour as 0)
http://localhost:3000/cats?limit=0&search=i&filter.age=$gte:3
{
  "data": [], << NO DATA RETRIVED
  "meta": {
    "itemsPerPage": 0,
    "totalItems": 12, << this is the only value that i need/i want to allow to retrive
    "currentPage": 1, << or maybe these can be 0..
    "totalPages": 1,
    "search": "i",
    "filter": {
      "age": "$gte:3"
    }
  },
  "links": {
    ...
  }
}

http://localhost:3000/cats?limit=-1&search=i&filter.age=$gte:3
{
  "data": [...],  <<<< ALL ITEMS OF THE TABLE
  "meta": {
    "itemsPerPage": 12,
    "totalItems": 12, <<< after your edits this is 0 when retrieving full table!!
    "currentPage": 1,
    "totalPages": 1,
    "search": "i",
    "filter": {
      "age": "$gte:3"
    }
  },
  "links": {
    ...
  }
}

that actually makes sense semantically, lol.
totalItems tho should keep the count as usual on limit=-1
currentPage can stay 1 on limit=0
no need to hijack those fields.
so, yeah would accept PR 😅

addition:
limit=0 can then be allowed always (even if maxLimit > 0)
limit=-1 must be "enabled" with maxLimit=-1


CascadingClient: Avoid scary stack trace

The idea is that most users react to stack traces. The very common
scenario for the CascadingClient is that it's totally fine for the
non-last clients in the cascading chain to fail. So when there's an
error, they are likely to get blind by this actually harmless stack
trace.

No complaints ---> Merging


Fix for incorrect done button title

Critical Changes
Changes
Fix for incorrect done button title on BSDT interface.
Issues Closed
New Metadata
Deleted Metadata
Definition of Done
Refer to Asteroids DoD document to see any additional details for the items below

[ ] Code does not reference translatable strings in its logic
[ ] Place holder data is incorporated (Refer to Case Management Sample Data document)
[ ] Base axe-core JEST test included for any new LWC (No critical violations)
[ ] CRUD/FLS is enforced in Apex
[ ] Permission sets are updated to account for CRUD/FLS for new object metadata
[ ] All modified classes are unit tested (Apex) at 100% coverage
[ ] UX approval or UX not necessary
[ ] PR contains draft release notes
[ ] Attach work item to the pull request with Lurch **Lurch:attach W-000000 or **Lurch:add
[ ] All acceptance criteria have been met

[ ] Developer
[ ] Code Reviewer
[ ] QA

[ ] QE story level testing completed

**lurch: attach W-041026

Tracking W-041026


[WIP] Message fabricators for bETH and fix issues

In this PR:

Add bETH related fabricators.
Fix linter problems.
Fix Export issues.

@iamssen @kjessec @r-amiri  If there are no issues we can release 1.1.0 before the beth integration.


'.coffee.md' -> '.litcoffee'

Coverage decreased (-27.5%) to 4.577% when pulling 4fdb2cd9d752b15dc3d445eff1244f90acdc0bb6 on coffeemd_to_litcoffee into 6e5f052488302ed2f7ce513c05b4a2a0f7cc817a on master.

Coverage decreased (-26.9%) to 5.148% when pulling 4fdb2cd9d752b15dc3d445eff1244f90acdc0bb6 on coffeemd_to_litcoffee into 6e5f052488302ed2f7ce513c05b4a2a0f7cc817a on master.

Coverage remained the same at 32.078% when pulling feb74662c4f7ee7aedc58bcb4488ea1b56f65be9 on coffeemd_to_litcoffee into 6e5f052488302ed2f7ce513c05b4a2a0f7cc817a on master.


Issue with custom query and pagination

I have a problem with Timber and paginating posts when the posts_per_page is higher than what the default posts_per_page is set at in the CMS.
EG if you have your Wordpress option set at 10 and then do a custom query (using PostQuery())with 50 posts at 5 per page you will get to page 6 and get a 404 (as it is expecting pagination on 50 posts by 10 per page)
Steps to reproduce behavior
$query = $GLOBALS['wp_query']->query_vars;
$query['posts_per_page'] = 4;
$posts = new PostQuery($query);
$context['posts'] = $posts;

also tried this
$context['posts'] = new PostQuery([
    'posts_per_page' => 4,
    'paged' => $paged,
    'ignore_sticky_posts' => 1
]);
$context['posts']->pagination(['mid_size' => 4]);

What version of WordPress, PHP and Timber are you using?
WordPress 5.2.2, PHP 7.3, Timber dev-master
How did you install Timber? (for example, from GitHub, Composer/Packagist, WP.org?)
Composer

Did you thought about using pre_get_posts? It's the best solution for main
queries.
czw., 22 sie 2019, 16:08 użytkownik Keith Light<EMAIL_ADDRESS>napisał:

I have a problem with Timber and paginating posts when the posts_per_page
is higher than what the default posts_per_page is set at in the CMS.
EG if you have your Wordpress option set at 10 and then do a custom query
(using PostQuery())with 50 posts at 5 per page you will get to page 6 and
get a 404 (as it is expecting pagination on 50 posts by 10 per page)
Steps to reproduce behavior
$query = $GLOBALS['wp_query']->query_vars;
$query['posts_per_page'] = 4;
$posts = new PostQuery($query);
$context['posts'] = $posts;
also tried this
$context['posts'] = new PostQuery([
'posts_per_page' => 4,
'paged' => $paged,
'ignore_sticky_posts' => 1
]);
$context['posts']->pagination(['mid_size' => 4]);
What version of WordPress, PHP and Timber are you using?
WordPress 5.2.2, PHP 7.3, Timber dev-master -->
How did you install Timber? (for example, from GitHub, Composer/Packagist,
WP.org?)
Composer
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/timber/timber/issues/2061?email_source=notifications&email_token=AAR34OUZP62DQ2WUWFHSOWLQF2MXDA5CNFSM4IOVOOR2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HGZQY3A,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAR34ORCWAZ35OQSDNCK6Q3QF2MXDANCNFSM4IOVOORQ
.

@palmiak,
yes overriding the posts_per_page in pre_get_posts does work. Is there a reason setting posts_per_page in a PostQuery() doesn't do this automatically for that query?

No WP first detects it is out of posts so it shows a 404. Using pre gets
posts tell WP at the right moment that it should paginate be a selected
post number
czw., 22 sie 2019, 16:19 użytkownik Keith Light<EMAIL_ADDRESS>napisał:

@palmiak https://github.com/palmiak,
yes overriding the posts_per_page in pre_get_posts does work. Is there a
reason setting posts_per_page in a PostQuery() doesn't do this
automatically for that query?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/timber/timber/issues/2061?email_source=notifications&email_token=AAR34OWWQYN6IUEUP4ESRJLQF2N6PA5CNFSM4IOVOOR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD45H2HA#issuecomment-523926812,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAR34OVAFDV6OYMR5PYW3BTQF2N6PANCNFSM4IOVOORQ
.


SBT doesn't include system out or system error in JUnit XML reports

steps

Run JUnit tests with sbt test.
Check the JUnit XML output in target/test-reports.

problem
The <system-out> and <system-err> tags are always empty, even if the unit tests produced output. This is because JUnitXmlTestsListener.scala hardcodes them to always be empty. This makes it harder to track down the cause of unit test failures.
expectation
Those XML tags should be populated with each unit test's sysout and syserr (or SBT should be configurable so that they can be populated).
notes
https://github.com/dmitchellmim/sbt-junit-sysout is a simple project to reproduce the issue. It uses Scala 2.13.3 and SBT 1.2.8, but based on the Git history of JUnitXmlTestsListener.scala, I think all versions have the same issue.

JUnit XML report was added in sbt 0.13.5 as an enhancement to list the test results for CI environment that could interpret it, and I don't think it ever supposed things like capturing standard error or output. From sbt's project's point of view, what we have is ok, and anything more I'd consider it a nice to have. We should also be careful that implementing this will not degrade test performance for existing builds.

I'm happy to have a go at fixing this - @eed3si9n would an acceptable solution be to add new flags testCaptureStdOut and testCaptureStdErr to the configuration? These would be false by default to be backward-compatible.

I'm happy to have a go at fixing this - @eed3si9n would an acceptable solution be to add new flags testCaptureStdOut and testCaptureStdErr to the configuration? These would be false by default to be backward-compatible.

That sounds good to me.

Okay, I've looked at this a bit more and it's sadly not as simple as I first thought:

sbt itself can fork one or more child processes to actually run tests
individual test runners might have their own parallelism built in within single test-runner instance: for example, ScalaTest states:

ScalaTest uses its own thread pool to run ParallelTestExecution suites, its pool size is determined by the following formula:
Pool Size = Available Processors x 2

So we potentially have a situation where a single sbt parent process is sending tests to runners in multiple JVMs, and those JVMs are each running multiple tests in parallel. It seems that therefore this can't (sadly) be fixed with a simple change to JUnitXmlTestsListener like I'd hoped, since the problem is much deeper.
Even in the simple case where everything is on one JVM, and tests run serially, fixing this properly will probably require changes to the individual test frameworks - they would need to be modified to capture standard out and standard error only for the duration of a single test (and not anything produced by the test framework itself); and then to somehow feed that back to sbt.
For comparison, it looks like the junit-interface plugin for sbt does something like this already, handling cases where it's running in pure-Java or Java+Scala configurations, to buffer standard out/error for a test:
https://github.com/sbt/junit-interface/blob/develop/src/main/java/com/novocode/junit/OutputCapture.java
@eed3si9n thoughts on this?


Show reference lines on

Currently the reference lines are shown like this

I want to show reference lines on all other viewers only related to the image user is interacting with like below screenshot.

This is happening because the reference lines algorithm is not a true plane/plane intersection (it uses the simpler two corner approach).  Perhaps this is something you could contribute?

Plane/plane intersection is being addressed in #105. It sounds like the filed issue actually deals with selectively enabling/disabling the reference line tool.
If you want to hide reference lines for the element the user is interacting with, you'll need to store which viewport is "Active" somewhere, and then whenever the active viewport changes, disable reference lines for the new viewport.
You can use CornerstoneToolsMouseDown, CornerstoneToolsMouseClick, CornerstoneToolsMouseWheel, etc to set your active flag.

Closing since #105 was merged.


vs studio fails on startup

Describe the bug
[A clear and concise description of the bug]
Steps to Reproduce

started vs studio thats it

Expected behavior
[A clear and concise description of your expectation]
Additional context and screenshots
[Add any other information such as screenshots, error message, or stack trace]
Sample Code
XXX

Configuration information (If you are providing a diagnostics file (see below), skip this section)
[Window Title]
devenv.exe
[Main Instruction]
An unexpected error occurred
[Content]
Please press Ctrl+C to copy the contents of this dialog and report this error to our issue tracker.
[^] Hide details  [Close]
[Expanded Information]
Build: 17.0.24138.2

Microsoft.VisualStudio.CommonIDE.Solutions.HResultExtensions+WrapperCOMException (0x8000FFFF): Catastrophic failure (Exception from HRESULT: 0x8000FFFF (E_UNEXPECTED)) [FindActiveProjectCfg @ SolutionBuildManager.cs:2221] ---> System.Runtime.InteropServices.COMException (0x8000FFFF): Catastrophic failure (Exception from HRESULT: 0x8000FFFF (E_UNEXPECTED)) [FindActiveProjectCfg @ SolutionBuildManager.cs:2221]
   at System.Runtime.InteropServices.Marshal.ThrowExceptionForHRInternal(Int32 errorCode, IntPtr errorInfo)
   at Microsoft.VisualStudioTools.Project.ProjectNode.SetCurrentConfiguration()
   at Microsoft.PythonTools.Project.PythonProjectNode.SetCurrentConfiguration()
   at Microsoft.VisualStudioTools.Project.ProjectNode.GetMsBuildProperty(String propertyName, Boolean resetCache)
   at Microsoft.VisualStudioTools.Project.ProjectNode.GetProjectProperty(String propertyName, Boolean resetCache)
   at Microsoft.PythonTools.Project.CondaEnvCreateProjectInfoBar.<CheckAsync>d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.PythonTools.Infrastructure.VSTaskExtensions.<HandleAllExceptions>d__5.MoveNext()

Thanks for reporting the issue. This is a dupe of https://github.com/microsoft/PTVS/issues/7930. Is your code in a public repo or could you provide code samples that help us repro this issue? Does this repro constantly for you? Could you also share more detailed repro steps? Thanks!

Hi @bluelight1324, this has been reported to the Visual Studio team. The problem is corruption in the .vs folder. Could you please delete the .vs folder in your project folder and see if the problem disappears?
When you delete the .vs folder, VS will rebuild it automatically when VS is restarted.
If this does not work, please reopen the issue. Thanks for raising this issue.
jude


Modularization of app run

Fixes #345
Fixes #346

Description

[x] Breakout of local config creation and web build/deploy into separate files. (@shazron )
[x] Separation of build and serve of UI to enable the build/deploy hooks.
[x] Re-ordering of build/deploy tasks (see #340, #339)
Was build-actions -> build-actions -> deploy-actions -> build-static -> serve-static
Now build-actions -> build-actions -> build-static -> deploy-actions -> serve-static
[x] Adding new hooks build-actions, build-static, deploy-actions, serve-static (pre-app-deploy, post-app-deploy, pre-app-build, post-app-build)
[x] Remove parcel watching and use own so we can call the hooks on every update/change
[x] Remove parcel serve and use a generic one to facilitate serving non-parcel builds

How Has This Been Tested?

[X] npm test
[X] aio app run (test generic function, with/without Authorization header)
[X] aio app run --local (test generic function, with/without Authorization header)
[X] aio app run (test action watcher, re-deploy action changes)
[X] aio app run --local (test action watcher, re-deploy action changes)
[X] aio app run --skip-actions
[X] aio app run --no-serve --verbose
[X] aio app run --no-serve --local --verbose
[X] aio app run (invoke action, verify logs are shown in console)
[X] aio app run --local (invoke action, verify logs are shown in console)
[x] aio app run (debug with wskdebug ok)
[x] aio app run --local (debug with wskdebug ok)
[x] aio app run --open (launches web browser to ExC shell)
[X] build-actions app hook ok
[X] build-static app hook ok
[X] deploy-actions app hook ok
[X] serve-static app hook ok

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Docs update pending for https://github.com/AdobeDocs/project-firefly/blob/master/guides/app-hooks.md (add the 4 new app hooks for app run)

Docs update pending for https://github.com/AdobeDocs/project-firefly/blob/master/guides/app-hooks.md (add the 4 new app hooks for app run)

Some more comments/observations:

testing with custom package name:

in manifest.yml I replaced __APP_PACKAGE__: with custom-package:
then in package.json added the following scripts```
"build-actions": "echo build-actions",
"build-static": "echo build-static",
"serve-static": "echo serve-static",
"deploy-actions": "echo deploy-actions"

  - `aio app run` outputs

build-actions
build-static
deploy-actions
serve-static
✖ setting up vscode debug configuration files...
TypeError: Cannot read property 'actions' of undefined
  - it seems vscode debug config is failing to retrieve the action names
2) ? more generally does it make sense to set up the debug config if the user has used the custom `deploy-actions` hook ? (can be addressed separately)
3) shouldn't we also provide an undeploy-static  and undeploy-actions hook for completeness ?

Some more comments/observations:

testing with custom package name:

in manifest.yml I replaced __APP_PACKAGE__: with custom-package:
then in package.json added the following scripts```
"build-actions": "echo build-actions",
"build-static": "echo build-static",
"serve-static": "echo serve-static",
"deploy-actions": "echo deploy-actions"

  - `aio app run` outputs

build-actions
build-static
deploy-actions
serve-static
✖ setting up vscode debug configuration files...
TypeError: Cannot read property 'actions' of undefined
  - it seems vscode debug config is failing to retrieve the action names
2) ? more generally does it make sense to set up the debug config if the user has used the custom `deploy-actions` hook ? (can be addressed separately)
3) shouldn't we also provide an undeploy-static  and undeploy-actions hook for completeness ?

I can verify the bug happens, but it's different on mine. It's a bug in aio-lib-runtime getActionUrls:

$ aio app run --verbose
ℹ using remote actions
ℹ building actions..
⠋ build-actions
ℹ watching action files at /Users/shaz/Desktop/tmp/app-2/actions...
ℹ watching action files at /Users/shaz/Desktop/tmp/app-2/actions...
ℹ injecting backend urls into frontend config
✖
    TypeError: Cannot read property 'actions' of undefined

running with DEBUG=*:
TypeError: Cannot read property 'actions' of undefined
    at Object.getActionUrls (/Users/shaz/git/work/adobe/aio-cli-plugin-app/node_modules/@adobe/aio-lib-runtime/src/utils.js:1737:54)
    at runDev (/Users/shaz/git/work/adobe/aio-cli-plugin-app/src/lib/run-dev.js:106:33)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async Run.run (/Users/shaz/git/work/adobe/aio-cli-plugin-app/src/commands/app/run.js:83:27)
    at async Run._run (/Users/shaz/git/work/adobe/aio-cli-plugin-app/node_modules/@oclif/command/lib/command.js:43:20)
    at async Config.runCommand (/Users/shaz/.nvm/versions/node/v12.19.0/lib/node_modules/@adobe/aio-cli/node_modules/@oclif/config/lib/config.js:173:24)
    at async Main.run (/Users/shaz/.nvm/versions/node/v12.19.0/lib/node_modules/@adobe/aio-cli/node_modules/@oclif/command/lib/main.js:27:9)
    at async Main._run (/Users/shaz/.nvm/versions/node/v12.19.0/lib/node_modules/@adobe/aio-cli/node_modules/@oclif/command/lib/command.js:43:20)

The bug is not occurring in the vscode generation (see above). In any case, this is changing -- we are adding/changing the vscode config when you add an action / remove an action and removing it from aio app run (what I'm working on next)

we actually don't have a deploy-static since aio app run only uses local web assets. undeploy-actions -- not sure where this fits in inside aio app run. Can you clarify?

I can verify the bug happens, but it's different on mine. It's a bug in aio-lib-runtime getActionUrls:

$ aio app run --verbose
ℹ using remote actions
ℹ building actions..
⠋ build-actions
ℹ watching action files at /Users/shaz/Desktop/tmp/app-2/actions...
ℹ watching action files at /Users/shaz/Desktop/tmp/app-2/actions...
ℹ injecting backend urls into frontend config
✖
    TypeError: Cannot read property 'actions' of undefined

running with DEBUG=*:
TypeError: Cannot read property 'actions' of undefined
    at Object.getActionUrls (/Users/shaz/git/work/adobe/aio-cli-plugin-app/node_modules/@adobe/aio-lib-runtime/src/utils.js:1737:54)
    at runDev (/Users/shaz/git/work/adobe/aio-cli-plugin-app/src/lib/run-dev.js:106:33)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async Run.run (/Users/shaz/git/work/adobe/aio-cli-plugin-app/src/commands/app/run.js:83:27)
    at async Run._run (/Users/shaz/git/work/adobe/aio-cli-plugin-app/node_modules/@oclif/command/lib/command.js:43:20)
    at async Config.runCommand (/Users/shaz/.nvm/versions/node/v12.19.0/lib/node_modules/@adobe/aio-cli/node_modules/@oclif/config/lib/config.js:173:24)
    at async Main.run (/Users/shaz/.nvm/versions/node/v12.19.0/lib/node_modules/@adobe/aio-cli/node_modules/@oclif/command/lib/main.js:27:9)
    at async Main._run (/Users/shaz/.nvm/versions/node/v12.19.0/lib/node_modules/@adobe/aio-cli/node_modules/@oclif/command/lib/command.js:43:20)

The bug is not occurring in the vscode generation (see above). In any case, this is changing -- we are adding/changing the vscode config when you add an action / remove an action and removing it from aio app run (what I'm working on next)

we actually don't have a deploy-static since aio app run only uses local web assets. undeploy-actions -- not sure where this fits in inside aio app run. Can you clarify?

we actually don't have a deploy-static since aio app run only uses local web assets. undeploy-actions -- not sure where this fits in inside aio app run. Can you clarify?

yes the deploy-static hook was introduced in https://github.com/adobe/aio-cli-plugin-app/commit/e7f7a543fab6d6045c91c973284a3f040259fa47 but there are no undeploy hooks. However, sry for the confusion, this should be solved in a separate PR as this is focusing on run hooks, opening an issue

we actually don't have a deploy-static since aio app run only uses local web assets. undeploy-actions -- not sure where this fits in inside aio app run. Can you clarify?

yes the deploy-static hook was introduced in https://github.com/adobe/aio-cli-plugin-app/commit/e7f7a543fab6d6045c91c973284a3f040259fa47 but there are no undeploy hooks. However, sry for the confusion, this should be solved in a separate PR as this is focusing on run hooks, opening an issue

@moritzraho I cleaned up my node_modules and reinstalled now I see the error you saw. Will fix:
✖ setting up vscode debug configuration files...
TypeError: Cannot read property 'actions' of undefined
    at generateConfig (/Users/shazron/Documents/git/adobe/aio-cli-plugin-app/src/lib/vscode.js:73:56)
    at Object.update (/Users/shazron/Documents/git/adobe/aio-cli-plugin-app/src/lib/vscode.js:40:38)
    at runDev (/Users/shazron/Documents/git/adobe/aio-cli-plugin-app/src/lib/run-dev.js:142:24)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async Run.run (/Users/shazron/Documents/git/adobe/aio-cli-plugin-app/src/commands/app/run.js:83:27)
    at async Run._run (/Users/shazron/Documents/git/adobe/aio-cli-plugin-app/node_modules/@oclif/command/lib/command.js:43:20)
    at async Config.runCommand (/Users/shazron/.nvm/versions/node/v12.16.0/lib/node_modules/@adobe/aio-cli/node_modules/@oclif/config/lib/config.js:173:24)
    at async Main.run (/Users/shazron/.nvm/versions/node/v12.16.0/lib/node_modules/@adobe/aio-cli/node_modules/@oclif/command/lib/main.js:27:9)
    at async Main._run (/Users/shazron/.nvm/versions/node/v12.16.0/lib/node_modules/@adobe/aio-cli/node_modules/@oclif/command/lib/command.js:43:20)

@moritzraho I cleaned up my node_modules and reinstalled now I see the error you saw. Will fix:
✖ setting up vscode debug configuration files...
TypeError: Cannot read property 'actions' of undefined
    at generateConfig (/Users/shazron/Documents/git/adobe/aio-cli-plugin-app/src/lib/vscode.js:73:56)
    at Object.update (/Users/shazron/Documents/git/adobe/aio-cli-plugin-app/src/lib/vscode.js:40:38)
    at runDev (/Users/shazron/Documents/git/adobe/aio-cli-plugin-app/src/lib/run-dev.js:142:24)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async Run.run (/Users/shazron/Documents/git/adobe/aio-cli-plugin-app/src/commands/app/run.js:83:27)
    at async Run._run (/Users/shazron/Documents/git/adobe/aio-cli-plugin-app/node_modules/@oclif/command/lib/command.js:43:20)
    at async Config.runCommand (/Users/shazron/.nvm/versions/node/v12.16.0/lib/node_modules/@adobe/aio-cli/node_modules/@oclif/config/lib/config.js:173:24)
    at async Main.run (/Users/shazron/.nvm/versions/node/v12.16.0/lib/node_modules/@adobe/aio-cli/node_modules/@oclif/command/lib/main.js:27:9)
    at async Main._run (/Users/shazron/.nvm/versions/node/v12.16.0/lib/node_modules/@adobe/aio-cli/node_modules/@oclif/command/lib/command.js:43:20)

@moritzraho Fixed the custom package issue in 55aee57 but there is another issue in<EMAIL_ADDRESS>https://github.com/adobe/aio-lib-runtime/commit/25e888bb7e90134895e805a735e5423923fc771b#r46138572
I can do a workaround but it's best if we fix it in an aio-lib-runtime patch off the 1.2.1 branch

@moritzraho Fixed the custom package issue in 55aee57 but there is another issue in<EMAIL_ADDRESS>https://github.com/adobe/aio-lib-runtime/commit/25e888bb7e90134895e805a735e5423923fc771b#r46138572
I can do a workaround but it's best if we fix it in an aio-lib-runtime patch off the 1.2.1 branch

@moritzraho Fixed the custom package issue in 55aee57 but there is another issue in<EMAIL_ADDRESS>adobe/aio-lib-runtime@25e888b#r46138572
I can do a workaround but it's best if we fix it in an aio-lib-runtime patch off the 1.2.1 branch

a fix is in and released at<EMAIL_ADDRESS>

@moritzraho Fixed the custom package issue in 55aee57 but there is another issue in<EMAIL_ADDRESS>adobe/aio-lib-runtime@25e888b#r46138572
I can do a workaround but it's best if we fix it in an aio-lib-runtime patch off the 1.2.1 branch

a fix is in and released at<EMAIL_ADDRESS>

Re-doing the manual tests because some logic changed:

[X] npm test
[ ] aio app run (test generic function, with/without Authorization header)
[ ] aio app run --local (test generic function, with/without Authorization header)
[ ] aio app run (test action watcher, re-deploy action changes)
[ ] aio app run --local (test action watcher, re-deploy action changes)
[ ] aio app run --skip-actions
[ ] aio app run --no-serve --verbose
[ ] aio app run --no-serve --local --verbose
[ ] aio app run (invoke action, verify logs are shown in console)
[ ] aio app run --local (invoke action, verify logs are shown in console)
[ ] aio app run (debug with wskdebug ok)
[ ] aio app run --local (debug with wskdebug ok)
[ ] aio app run --open (launches web browser to ExC shell)
[ ] build-actions app hook ok
[ ] build-static app hook ok
[ ] deploy-actions app hook ok
[ ] serve-static app hook ok
[ ] undeploy actions before the following tests below (so as not to have a false positive)
[ ] (NEW) aio app run (custom package name, invoke action, verify logs are shown in console)
[ ] (NEW) aio app run --local (custom package name, invoke action, verify logs are shown in console)
[ ] (NEW) aio app run (custom package name, debug with wskdebug ok)
[ ] (NEW) aio app run --local (custom package name, debug with wskdebug ok)

Re-doing the manual tests because some logic changed:

[X] npm test
[ ] aio app run (test generic function, with/without Authorization header)
[ ] aio app run --local (test generic function, with/without Authorization header)
[ ] aio app run (test action watcher, re-deploy action changes)
[ ] aio app run --local (test action watcher, re-deploy action changes)
[ ] aio app run --skip-actions
[ ] aio app run --no-serve --verbose
[ ] aio app run --no-serve --local --verbose
[ ] aio app run (invoke action, verify logs are shown in console)
[ ] aio app run --local (invoke action, verify logs are shown in console)
[ ] aio app run (debug with wskdebug ok)
[ ] aio app run --local (debug with wskdebug ok)
[ ] aio app run --open (launches web browser to ExC shell)
[ ] build-actions app hook ok
[ ] build-static app hook ok
[ ] deploy-actions app hook ok
[ ] serve-static app hook ok
[ ] undeploy actions before the following tests below (so as not to have a false positive)
[ ] (NEW) aio app run (custom package name, invoke action, verify logs are shown in console)
[ ] (NEW) aio app run --local (custom package name, invoke action, verify logs are shown in console)
[ ] (NEW) aio app run (custom package name, debug with wskdebug ok)
[ ] (NEW) aio app run --local (custom package name, debug with wskdebug ok)

Ugh I was checking off a task and it erased the whole comment with all the tasks in it. Re-generating:

[X] npm test
[ ] aio app run (test generic function, with/without Authorization header)
[ ] aio app run --local (test generic function, with/without Authorization header)
[ ] aio app run (test action watcher, re-deploy action changes)
[ ] aio app run --local (test action watcher, re-deploy action changes)
[ ] aio app run --skip-actions
[ ] aio app run --no-serve --verbose
[ ] aio app run --no-serve --local --verbose
[ ] aio app run (invoke action, verify logs are shown in console)
[ ] aio app run --local (invoke action, verify logs are shown in console)
[ ] aio app run (debug with wskdebug ok)
[ ] aio app run --local (debug with wskdebug ok)
[ ] aio app run --open (launches web browser to ExC shell)
[ ] build-actions app hook ok
[ ] build-static app hook ok
[ ] deploy-actions app hook ok
[ ] serve-static app hook ok
[ ] undeploy before testing the below
[ ] (NEW) aio app run (custom package, test generic function, with/without Authorization header)
[ ] (NEW) aio app run --local (custom package, test generic function, with/without Authorization header)
[ ] (NEW) aio app run (custom package, debug with wskdebug ok)
[ ] (NEW) aio app run --local (custom package, debug with wskdebug ok)

Ugh I was checking off a task and it erased the whole comment with all the tasks in it. Re-generating:

[X] npm test
[ ] aio app run (test generic function, with/without Authorization header)
[ ] aio app run --local (test generic function, with/without Authorization header)
[ ] aio app run (test action watcher, re-deploy action changes)
[ ] aio app run --local (test action watcher, re-deploy action changes)
[ ] aio app run --skip-actions
[ ] aio app run --no-serve --verbose
[ ] aio app run --no-serve --local --verbose
[ ] aio app run (invoke action, verify logs are shown in console)
[ ] aio app run --local (invoke action, verify logs are shown in console)
[ ] aio app run (debug with wskdebug ok)
[ ] aio app run --local (debug with wskdebug ok)
[ ] aio app run --open (launches web browser to ExC shell)
[ ] build-actions app hook ok
[ ] build-static app hook ok
[ ] deploy-actions app hook ok
[ ] serve-static app hook ok
[ ] undeploy before testing the below
[ ] (NEW) aio app run (custom package, test generic function, with/without Authorization header)
[ ] (NEW) aio app run --local (custom package, test generic function, with/without Authorization header)
[ ] (NEW) aio app run (custom package, debug with wskdebug ok)
[ ] (NEW) aio app run --local (custom package, debug with wskdebug ok)


how to get an instance of the presenter when extend from TiActivity

In the demo, HelloWorldActivity extends TiActivity,  but I can't see any method to get the presenter instance.

Simply call getPresenter() I guess.

As stated simply call getPresenter(). Make sure you are using Version 0.7.1, since the method is missing in 0.7.0.

duplicate #3


feat(history-sync): add priority option to routes

Please check the added test suite to see the expected behavior!

Our team has been thinking about this issue before, and we thought of several candidates for the acceptable priority rule.

Users set their own path priorities (This PR's way)
Indirect reflection in the order of declaration (vue router)
Score calculation (react router)

How do you think?

Although I also believe that the score calculation should be the default behavior in most cases, I found that it sometimes makes sense to override this and therefore made this PR, which works as a hybrid of 1 and 3. I prefer my solution the most since it provides both a good default and an escape hatch that can be utilized in advanced use cases.

Oh, I see. Is there an example that requires an escape hatch against score rule?


Some docs amendments

While reading the docs, I found these minor things that could be changed.
Excellent software documentation, by the way :-)

Awesome, thanks so much for all these fixes.


Update lagoon-remote to use latest lagoon-build-deploy chart

All test have passed successfully in separate runs, failed tests appear to be because the API is not fully operation when the first test starts to run. We need to address this in core to find out why, I have a feeling it is related to the api-db sometimes getting hung up and crashing but not restarting properly. There are plans to move away from api-db in the future though, as this is already a problematic point.


Rename Abstract Syntax Tree to Lossless Semantic Tree

Attempts to update all docs to utilize LST instead of AST.
Also minor rephrases in the LST explanation doc.
Also minor grammar / spelling fixes.

Going to merge this in as I haven't heard any other feedback. If there's suggestions later, please feel free to let me know!


Abstract Engine (MiniMina) for integration tests

This PR introduces the abstract engine for integration testing and general improvements.
The general idea is that the abstract engine should be agnostic to the network runner. It operates by using network runner-specific config files (e.g. the mock config located in ./integration_tests/) and running bash commands based on the config. The stdout of the network runner commands is captured by the abstract engine and parsed into the response types defined in config_util.ml, which are subsequently used to manage Lucy's internal network state. Network runner responses must conform to return_spec.json. Node interactions still proceed via GQL.
The other major departures from the GCP engine are the abstract engine's generation of a topology file to be consumed by the network runner and the usage of pre-generated network and libp2p keys to boost performance.

adds abstract engine module in src/lib/integration_test_abstract_engine
adds topology file generation
adds usage of pre-generated network and libp2p keys
adds config and return spec

!ci-build-me


Small question

Is it possible to Add/Remove followers while the stream is active ? if not is it possible while it's Paused or it must be Stopped ?

It is not possible when it is paused. It needs to be stopped, because starting a stream after it has been stopped result in the HttpRequest to be run again. Pause just result in content to not be retrieved while the HttpRequest still runs.

Just as i thought so, thank you. ;]


Input v2

Figma Link: @bhoppers2008 to create

### Released in
- [ ] Design
- [ ] Dev

### Tasks
- [ ] https://github.com/jpmorganchase/salt-ds/issues/1742

All versions assume support for:

All densities
All modes
Accessibility considerations

Version 2
a. Static suffix and prefix adornment: Icon, Text
b. Interactive suffix adornment: Adornment Button component
c. Placeholder text

June 9 - features all merged; need design review from Ben and ADA

@bhoppers2008, can someone on the design team review this so we can ship? And @maj-stella - either in advance of release or post-release, can you review and highlight any ADA updates required?

Figma library released


Bring feat-2.0 up to date with dev since 3dfcbc1

This PR brings all recent commits since https://github.com/casper-network/casper-node/commit/3dfcbc1ca0c3a17973ad7ff274d940ecedc26cae from the dev branch to the feat-2.0 branch.
Merge had no conflicts.

bors r+


[ts] could not find a declaration file (.d.ts)

Not able to require and use function

Hi Hariom, can you please give more details?

basically, I want dts file.

Well this project uses Flow so there is no .d.ts file in the npm package.

I am using expressJS with mongoose and calling your function in this way :
exports.cherrypick = function (req, res) {

  const result =  cherryPickCommits({
        commits: [ '0d4e1843aff9fe26f542e7069ebf44256980c235',
        '919ae1b8987e0a3c16fd574d3380552aa8290029',
        'edaea3e735f8c69c2c65028d369eea191cddd6cc' ],
        head: "master",
        octokit,
        owner: "exzeo",
        repo: "git-automation",
      }).then(newHeadSha => {
        console.log(newHeadSha);
      });

}
```

and getting this error

```
TypeError: cherryPickCommits is not a function
    at exports.cherrypick (/home/hariomv/Documents/jira-workflow-automation/app/controllers/githubpr.controller.js:240:19)
    at Layer.handle [as handle_request] (/home/hariomv/Documents/jira-workflow-automation/node_modules/express/lib/router/layer.js:95:5)
    at next (/home/hariomv/Documents/jira-workflow-automation/node_modules/express/lib/router/route.js:137:13)
    at Route.dispatch (/home/hariomv/Documents/jira-workflow-automation/node_modules/express/lib/router/route.js:112:3)
    at Layer.handle [as handle_request] (/home/hariomv/Documents/jira-workflow-automation/node_modules/express/lib/router/layer.js:95:5)
    at /home/hariomv/Documents/jira-workflow-automation/node_modules/express/lib/router/index.js:281:22
    at param (/home/hariomv/Documents/jira-workflow-automation/node_modules/express/lib/router/index.js:354:14)
    at param (/home/hariomv/Documents/jira-workflow-automation/node_modules/express/lib/router/index.js:365:14)
    at Function.process_params (/home/hariomv/Documents/jira-workflow-automation/node_modules/express/lib/router/index.js:410:3)
    at next (/home/hariomv/Documents/jira-workflow-automation/node_modules/express/lib/router/index.js:275:10)
    at /home/hariomv/Documents/jira-workflow-automation/node_modules/body-parser/lib/read.js:130:5
    at invokeCallback (/home/hariomv/Documents/jira-workflow-automation/node_modules/raw-body/index.js:224:16)
    at done (/home/hariomv/Documents/jira-workflow-automation/node_modules/raw-body/index.js:213:7)
    at IncomingMessage.onEnd (/home/hariomv/Documents/jira-workflow-automation/node_modules/raw-body/index.js:273:7)
    at IncomingMessage.emit (events.js:182:13)
    at endReadableNT (_stream_readable.js:1081:12)

```

Also, I am new with NodeJS. So, plz ignore if i do some silly  mistakes.

You should add a const cherryPickCommits = require('github-cherry-pick') in your githubpr.controller.js as shown in the readme.

As I said, there is no TypeScript declaration file shipped in this package so the error you're seeing in Visual Studio Code is expected. You can try what they sugggest: "add a nex declaration (.d.ts) file containing `declare module 'github-cherry-pick';`".

the above-mentioned suggestion didn't work. After some googling, I changed the last line of your code and function starts working!
module.exports = cherryPickCommits;

Hi Hariom, this should be fixed now and I also switched the library to TypeScript ;).


Underscore in section name

Example:
require 'kramdown'
require 'html/pipeline'

text = <<TEXT
# Prelude

The quick brown fox jumps over the lazy dog.

## Table of Contents

- [What_is_this?](#what_is_this)

## What_is_this?

The quick brown fox jumps over the lazy dog.
TEXT

puts Kramdown::Document.new(text).to_html

# ...
#
What_is_this?

# ...

MarkdownPipeline = HTML::Pipeline.new [
  HTML::Pipeline::MarkdownFilter,
  HTML::Pipeline::TableOfContentsFilter
]

result = MarkdownPipeline.call text
puts result[:output].to_s

# ...
#

#
#
#    What_is_this?
#

Two different anchors: whatisthis and what_is_this.
Github uses anchor what_is_this.
How the gem "danger-toc" should behave in this case?
@dblock, i need your help.

By default we should be using what Github does since this is about TOC on Github pages.
Making it configurable could be useful for everybody else.


[Feature Request] Show full flow output when running a directory of flows

Is your feature request related to a problem? Please describe.
When running multiple flows in a directory via maestro test <dir>, I can't see each step that is being executed. Instead, the only output possible is
Waiting for flows to complete...

Describe the solution you'd like
A CLI option to display the step-by-step flow that is being currently executed, in the same way that it is displayed when running one flow at at a time

Thanks for raising this issue. It's indeed very annoying, I have no way of knowing what flow is currently executing.


Current Issues

Fix grammar errors in database. The location, and tutor name has all letters capital. Also, make sure future versions of entries are correct.
Optimise database storage options.
Design the view-all page further.
In view-all pages, add a form for further searches.
Improve the review section on view individual.
Improve the register form.
Get a working database.

#1,#2,#4 resolved

#5 - what of the register form?

[ ] Fix grammar errors in database. The location, and tutor name has all letters capital. Also, make sure future versions of entries are correct.
[ ] Optimise database storage options.
[ ] Design the view-all page further.
[ ] In view-all pages, add a form for further searches.
[ ] Improve the review section on view individual.
[ ] Improve the register form.
[ ] Get a working database.

The register form needs to take in the name, email address and mobile number of the user as input. And the positioning of button needs improvement.
Overall - the design of the view-ind page can be improved a bit more - although it is looking quite good for now.
Lastly, the only major thing left is the database for which Karan was responsible.

pagination is very difficult, so i have left it for now
we will add the immunity scores once we have a databse


Expense: Create activity when draft expense gets verified

Fix https://github.com/opencollective/opencollective/issues/4020 (https://opencollective.freshdesk.com/a/tickets/13223)
This PR will trigger a COLLECTIVE_EXPENSE_CREATED activity when a draft is verified, but it won't send the associated email (only the webhooks will be triggered).
@kewitz I'm wondering a few things:

Are collective admins notified in some way when there's a new draft? Can they see them listed somewhere?
Don't we want to send a "New expense" email notification too when the expense gets verified?
If the answer to (1) is yes, shouldn't we generate the COLLECTIVE_EXPENSE_CREATED activity when the draft gets created?

@Betree only the invited person is notified through COLLECTIVE_EXPENSE_INVITE_DRAFTED.
My rationale was that since the draft is temporary, I wouldn't like to bother collective admins if this draft never becomes an expense.
This is a good catch, and I think it makes sense to notify admins when the draft becomes a pending expense. This part was missing.

@Betree only the invited person is notified through COLLECTIVE_EXPENSE_INVITE_DRAFTED.
My rationale was that since the draft is temporary, I wouldn't like to bother collective admins if this draft never becomes an expense.
This is a good catch, and I think it makes sense to notify admins when the draft becomes a pending expense. This part was missing.

Ok, I'll remove the skipEmail to make sure they get an email notification then. Thanks!


Trying to get reactive backpressure to work

Hi, I'm trying to do a PoC on reactive backpressure using pgadba, and I kind of get the impression it isn't honoring backpressure. I'm doing a simple query from a database using a rowpublisheroperation:
DataSource ds = DataSourceFactory.newFactory("org.postgresql.adba.PgDataSourceFactory")
    .builder()
    .url("jdbc:postgresql://localhost:5432/dvdrental")
    .username("postgres")
    .password("mysecretpassword")
    .build();

CompletableFuture<String> result = new CompletableFuture<>();
Session session = ds.getSession();
// Very basic SubmissionPublisher (and a Flow.Processor), so I can expose the result as a publisher
RowProcessor rp = new RowProcessor();
final CompletableFuture<String> completableFuture = session.<String>rowPublisherOperation("select title from film limit 1000")
			.subscribe(rp, result)
			.submit()
			.getCompletionStage()
			.toCompletableFuture();

// Convert to RxJava2, because I'm most confortable with that
long count = FlowInterop.fromFlowPublisher(rp)
	.doOnTerminate(()->session.close())
	.map(e->(String)e.at("title").get())
	.doOnNext(e->System.err.println("Title: "+e))
	.count()
	.blockingGet();
System.err.println("Count: "+count);

Where the rowprocessor is this:
public class RowProcessor extends SubmissionPublisher<Result.RowColumn> implements Flow.Processor<Result.RowColumn,Result.RowColumn> {

	private Subscription subscription;
	@Override
	public void onSubscribe(Subscription subscription) {
		this.subscription = subscription;
		this.subscription.request(1);
	}
	@Override
	public void onNext(RowColumn item) {
		submit(item);
		this.subscription.request(1);
	}
	@Override
	public void onError(Throwable throwable) {
		throwable.printStackTrace();
	}
	@Override
	public void onComplete() {
		System.err.println("completed");
		close();
	}
}

Now what happens is this: If I limit to about 500 it works fine.
select title from film limit 500

results in:
completed
Count: 500

All good. If I increase to 900 I see this:
completed
Count: 895

Along with 5 IllegalStateExceptions:
java.lang.IllegalStateException: failed to offer item to subscriber
	at org.postgresql.adba/org.postgresql.adba.submissions.ProcessorSubmission.lambda$0(ProcessorSubmission.java:82)
	at java.base/java.util.concurrent.SubmissionPublisher.retryOffer(SubmissionPublisher.java:445)
	at java.base/java.util.concurrent.SubmissionPublisher.doOffer(SubmissionPublisher.java:422)
	at java.base/java.util.concurrent.SubmissionPublisher.offer(SubmissionPublisher.java:550)
	at org.postgresql.adba/org.postgresql.adba.submissions.ProcessorSubmission.addRow(ProcessorSubmission.java:81)
	at org.postgresql.adba/org.postgresql.adba.communication.network.Portal.addDataRow(Portal.java:152)
	at org.postgresql.adba/org.postgresql.adba.communication.network.ExecuteResponse.read(ExecuteResponse.java:31)
	at org.postgresql.adba/org.postgresql.adba.communication.NetworkConnection.handleRead(NetworkConnection.java:407)
	at org.postgresql.adba/org.postgresql.adba.execution.DefaultNioLoop.run(DefaultNioLoop.java:127)
	at java.base/java.lang.Thread.run(Thread.java:844)

If I do more with the results (like printing the rows to the console) the problem gets worse, so I get the impression that if the pg driver does not slow down reading the result when the consumer can't keep up.

Hi. I agree on that this needs improvement.
What the driver needs to do is to stop reading from the tcp socket once it encounters back pressure, but it doesn't do that yet.
Patches are of source welcome, otherwise i will look at it later this week. My day job is currently very busy so my open source work suffers a bit.

No rush, I know that feeling. Glad it is something that makes sense.


Make Colima work out of the box

Is there a reason why Wait.forListeningPorts isn't the default behavior? I'm not sure if I'm reading it right, but it seems like it is in testcontainers-go, which makes it "just work" (source):

As of Colima v0.4.0 it's recommended to set the active Docker context to use Colima. After the context is set Testcontainers for Go will automatically be configured to use Colima.

It is the default behaviour

It is the default behaviour

Hmm, I could be misunderstanding something, but doesn't the page you link to contradict this?

... wait strategies such as waiting for a health check or a log message are insufficient when using Colima. You can use a composite wait strategy to additionally wait for a port to be bound, on top of an existing wait strategy.

Is there a reason why Wait.forListeningPorts isn't the default behavior

My answer was to this question.
Users are free to use whatever wait strategy they wish. What you quoted explains that there is a known issue with colima if you deviate from the listening ports wait strategy (which is the default wait strategy).

Ah, I understand, thanks, I see it:
https://github.com/testcontainers/testcontainers-node/blob/055c02f074e079996a2ba5be409dd0f3c8646252/packages/testcontainers/src/generic-container/generic-container.ts#L48
Okay, then my question is, why is this overridable? Seems like most modules forget to add Wait.forListeningPorts when using a custom strategy.

@cristianrgreco Friendly ping, just in case you missed this. I'm interested in getting to the bottom of this because I'd be willing to at least update all modules to include forListeningPorts in their wait strategies if this is an oversight.


Chart's lock file warnings

Looks like we're pinning to specific charts versions rather than using semver ^, is this intended?
warning Lockfile has incorrect entry for "<EMAIL_ADDRESS>Ignoring it.
warning Lockfile has incorrect entry for "<EMAIL_ADDRESS>Ignoring it.
warning Lockfile has incorrect entry for "<EMAIL_ADDRESS>Ignoring it.

This is an issue with the @carbon/charts release process, should be resolved automatically when it's fixed upstream.