Add mistaOba to Contributors list

My first Pull Request and I'm really excited!

Hi  @mistaOba, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

The experience was really great! I have had numerous challenges understanding Git before now but this tutorial made it really easy!!
Thank you

I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://goo.gl/PM1Jdh


Extension only works on Windows because of hardcoded path divider ""

I tried this on a Mac and the plugin fails because it is concatenating "" into the path instead of using path.join().
This worked like a charm on my Windows machine though. Thanks for creating it.

 Ill try to fix that so that it works on both!

I've published a fix.
Let me know if theres any more trouble!

That was incredibly fast! Thanks for the fix. I've just verified it works on the Mac.


anyone experiencing issues downloading in Safari?

Chrome and Firefox works fine. In Safari, data is written to the DOM but fails to trigger a download

please ignore, Chrome and Safari's download indicator works differently and Safari works with the latest package version.

Glad you were able to sort this out!

I'm still having problem with downloading the pdf file on Safari.
safari version: 11.0.1
html2pdf version: 0.9.0
I'm using the command:
html2pdf().from(element).set(configuration).save();
Chrome and Fire fox are working fine, but in Safari I can see the creation of the pdf logs but the file isn't downloaded.
Does this html2pdf version supports my Safari version? @eKoopmans
What did you do to make it work? @chulander
Thanks

I never had an issue downloading from safari. The issue was post-download, all the svgs on the page were scaled out of proportions.
What does your safari console say? Sounds like there’s an error there


Add the text "My changes"

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Add the text "My changes"


Break/replace any block with any type of torch same also happens with flowers (edit appears to happenw ith any non full block)

[x] I've searched existing issues and couldn't find a duplicate.

Describe the bug
Placing a torch and click on the block where the torch is located with any other block will end up in replacing the torch also click with any block on a side of the torch of chosen variant will end up replacing any block is there is 1
To Reproduce
For part 1:
1.Place a torch of chosen variant then choose a block and place it looking at the block below the torch
Part 2:
1.Place a torch of chosen variant
2.Choose a block and place it next to the torch
3.Choose a another block and place it to the same spot where previous block is located while looking at the side of the torch
Expected behavior
The torches should have stayed in the block and not replace the other blocks
Environment (please complete the following information):

Operating System: [Arch Linux
Server Software Version/Commit: [e.g., 1.0.0/39b4cb3]

Additional context
Add any other context about the problem here.

Same happens if you place on ground on the side of grass/sign/ladder/door etc. Every block that isn't full scale 1 meter and where you can click on the ground underneath it.

I'll try to fix this

As far as I know, this is because the minecraft client is not sending a FinishedDigging packet when a block is broken under one tick. So we need to calculate the block destruction speed and break the block if it was fast enough.
Reference:
https://wiki.vg/Protocol#Player_Action
https://github.com/dmulloy2/ProtocolLib/issues/2413
pumpkin/src/client/player_packet.rs Player handle_interact handle_player_action Status::FinishedDigging


Curation UI behaves confusingly and does not remove old license

I am looking on git/github/lz4/lz4/dfed9fa1d77f0434306d377c4da1f7191d3ba08a at the file lib/dll/example/Makefile. The file has the old SPDX ID GPL-2.0+ as license. If I use pencil-icon or the eye-icon to modify the license to GPL-2.0-or-later the UI always displays GPL-2.0+ AND GPL-2.0-or-later afterwards.
Screenshots:
before the change:

after the change:

Looks like a service issue, i've reproduced the problem with another definition.
This is the PATCH details sent to the preview endpoint:
{"files":[{"path":"Makefile","license":"0BSD","attributions":["Copyright (c) Yann Collet 2011-2016"]}]}
and this is the response of the related file:
{"path":"Makefile","license":"0BSD AND BSD-2-Clause","attributions":["Copyright (c) Yann Collet 2011-2016"],"hashes":{"sha1":"e352eb782a0948c9f1154462f903f88dcbd17abb"}}

@dabutvin did you had the chance to look at this? Should we move this issue to the service repo?

@dabutvin i think this should be moved to the service. We can then take care of this and see why it has this strange behavior.

This is related to https://github.com/clearlydefined/service/issues/526

Since this has been fixed by clearlydefined/service#526 , we can close this one.


Check for 'main' as potential default branch name

There are repos out there that switched to 'main' as the default branch. This PR improves the importing experience of repos who use 'main' as the default branch instead of 'master'.

Codecov Report

Merging #14193 (ec5d9e7) into master (8e5aea8) will decrease coverage by 0.01%.
The diff coverage is 10.00%.

@@            Coverage Diff             @@
##           master   #14193      +/-   ##
==========================================
- Coverage   42.01%   42.00%   -0.02%
==========================================
  Files         733      733
  Lines       78704    78713       +9
==========================================
- Hits        33071    33062       -9
- Misses      40201    40218      +17
- Partials     5432     5433       +1

Impacted Files
Coverage Δ

modules/repository/init.go
40.79% <0.00%> (-1.05%)
:arrow_down:

services/mirror/mirror.go
15.57% <0.00%> (-0.18%)
:arrow_down:

routers/private/hook.go
32.29% <100.00%> (ø)

modules/git/repo_language_stats_nogogit.go
57.44% <0.00%> (-6.39%)
:arrow_down:

models/unit.go
46.57% <0.00%> (-2.74%)
:arrow_down:

modules/git/batch_reader_nogogit.go
44.77% <0.00%> (-1.50%)
:arrow_down:

routers/repo/view.go
37.60% <0.00%> (-0.65%)
:arrow_down:

services/pull/pull.go
42.35% <0.00%> (ø)

modules/indexer/stats/db.go
60.00% <0.00%> (ø)

modules/git/repo_commit_nogogit.go
65.00% <0.00%> (+1.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af2fe9a...ec5d9e7. Read the comment docs.

make lg-tm work


Activation date event considered as sim swap event

Problem description
SIM Swap api delivers information about last MSISDN and IMSI pairing. However, there are events within telco subscription, that can be considered as a sim swap, i.e. activation date.
The problem that is addressed inside this issue is to discuss scenarios and viable solutions to consider activation date within Camara SIM Swap API response.
Expected action

Provide an enhanced definition of SimSwap event
Provide a description of country specific limitations to sim swap date delivery (e.g. in some countries only date within 30days period is delivered)
Use this issue to discuss other related topics

Additional context
This issue came from a discussion within Issue #16

What about eSIM...  I think moving eSIM to another device should be considered as a SIM Swap

Activate date of SIM or an MSISDN?
The very first link of an MSISDN with a SIM is hardly an indicator of any fraud. However, formally, this MSISDN could have being used before (same MNO, different user who cancelled their subscription; or MSISDN is migrated from another MNO).
Therefore, it could make sense to consider first MSISDN-IMSI assignment as a SimSwap as well.
But then it must be handled as a "regular" SimSwap.

Please keep in mind that many MSISDN's are also ported between MNO's. From the perspective of an MNO this may be seen as the first association of an MSISDN with a SIM, from the perspective of an end user he may have been using the phone number already much longer, with several SIM cards.  In NL, more than 50% of "new" users is actually a porting between MNO's.   And note this process may be abused by fraudsters as well.
From our perspective , we dont see a need to make a distinction between a first association of a "new" MSISDN and a SIM, and  an "existing" MSISDN that is being associated with a new SIM.   If you  ask me, the name of the API is a bit misleading.  SIM Activation or SIM Activation Detection would be a better description of what the developer is trying to achieve.

@HuubAppelboom , yes number portability is a ting, therefore I explicitly mentioned it above.
regarding the naming... well, SimSwap attack is a commonly used term and this API addresses it.

Sim Swap is indeed a commonly used term, but this also leads to confusion with parties who think that SIM Swap itself is the fraudulent process, which it is not.  And what will you name an API that indeed does what it says (move the user to a new SIM card) ??

"And what will you name an API that indeed does what it says (move the user to a new SIM card) ??"

here I do agree :)

closing


update godoc tag

was pointing to chewxy repo.

Coverage decreased (-0.05%) to 71.61% when pulling 792057ea7d9477d5da4ee1f2e58ba4ec53a7ed45 on poopoothegorilla:patch-1 into 44b4fa05b497907bd19a294029da0c0319cc32c1 on gorgonia:master.

Merged. Thank you @poopoothegorilla


Missing test case for the Positive and Negative Lookahead challenge

Per the discussion in the following forum topic, a new test case should be added which should fail if
a password like “8pass99” which has more than 6 characters long and has 6 consecutive characters.
https://www.freecodecamp.org/forum/t/regex-look-aheads/323407/3
@ArielLeslie has already corrected the forum hint/solution topic for the challenge, so the actual solution for the challenge file needs to also reflect the following corrected regex:
let pwRegex = /^(?=\w{6,})(?=\D*\d{2})/;

@RandellDawson I would like to work on this issue. https://github.com/freeCodeCamp/freeCodeCamp/blob/master/curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/positive-and-negative-lookahead.english.md
This is the link containing this problem , right? So I just need to modify Tests and add the above test case "8pass99" test case to it ?

@FullBinaryAlchemist Yes, but please make sure to run npm run test:curriculum locally or use GitPod  before creating the actual PR.  This will validate your changes do not break anything.


added entry for httpstatuscode

Thanks for your suggestion. However, the linked resource doesn't add much value when compared to the HTTP spec and the multiple tutorials on the subject. So we won't add it to the list.


[modify] gws/schedule: search plans

Coverage decreased (-0.002%) to 83.641% when pulling e39e00de99fa8d00bb396bc2437afa7636257509 on tany:gws into 9a3dd585e5bd7e083427353849b2733c88628eee on shirasagi:master.


Implement Blend Modes

The blending modes available are the same as what LOVE2D as of 11.3 offers:

alpha - Default. This also takes place if none is used.
replace - Essentially renders the sprite without an alpha.
screen - Screen blending
add - Additive blending
subtract - Subtractive blending
multiply - Multiplicative blending (which is better used for darkening objects).
lighten / darken - math.min/math.max blending.

(The second commit isn't related but it was also on the ZB remake repository so whatever)

This PR is quite a mess, so blend modes will be implemented independently.


slide failed to load SyntaxError: The requested module '/node_modules/react/jsx-runtime.js?v=9d5c9697' does not provide an export named 'Fragment'

Hi Albert,
I tried to use the addon and I got the above error? What do you think could be the issue?
Here is my package.json

Package.JSON

"dependencies": {
"@slidev/cli": "^0.49.29",
"@slidev/theme-default": "latest",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"slidev-addon-tldraw": "^0.2.3",
"vue": "^3.5.10"
},
"devDependencies": {
"@iconify-json/logos": "^1.2.0",
"@iconify-json/mdi": "^1.2.0",
"@slidev/types": "^0.49.29",
"@vue/compiler-sfc": "^3.5.10",
"markdown-it-magic-link": "^0.1.4",
"nodemon": "^3.1.7",
"playwright-chromium": "^1.47.2",
"prettier": "^3.3.3",
"prettier-plugin-slidev": "^1.0.5"
},

Here is the addons field on my formatter

I can't reproduce with version 0.3.0, if I take an example presentation and use your package dependencies that presentation does not give an error. @Oluwasetemi Can you check if it still fails with v0.3.0? If not, I need a larger reproduction case.

@AlbertBrand will it right away and left you know if it works

@Oluwasetemi did you try? Else I'll close this one.

As discussed on Discord, in your configuration you have:
  optimizeDeps: {
    exclude: [
      '@vue/compiler-sfc', 'react', 'react-dom/client', '@babel/standalone'
    ],
  }

which caused React not to be part of the Vite bundling. As tldraw requires react and react-dom the page breaks when running it on the Vite dev server.
Make sure not to exclude React!

Closing.


AWS LangChain using bedrock: Setting Relevance Score Function

System Info
Thank you for your great help. I have issue with setting the score function (I have AWS LangChain using bedrock). What I have is:
from langchain.vectorstores import FAISS
loader = CSVLoader("./rag_data/a.csv")
documents_aws = loader.load()
docs = CharacterTextSplitter(chunk_size=2000, chunk_overlap=400, separator=",").split_documents(documents_aws)
def custom_score(i):
#return 1 - 1 / (1 + np.exp(i))
return 1
vectorstore_faiss_aws = FAISS.from_documents(documents=docs,embedding = br_embeddings)
vectorstore_faiss_aws.relevance_score_function=custom_score
This made no difference in the scores (did not give any errors either as I am getting large negative numbers and the vectorstore_faiss_aws.similarity_search_with_relevance_scores is indifferent to the score_threshold value)
Then I tried:
vectorstore_faiss_aws = FAISS(relevance_score_fn=custom_score).from_documents(documents=docs,embedding = br_embeddings)
and it gave the following error:
FAISS.init() missing 4 required positional arguments: 'embedding_function', 'index', 'docstore', and 'index_to_docstore_id'
Your advice is highly appreciated
Who can help?
No response
Information

[X] The official example notebooks/scripts
[X] My own modified scripts

Related Components

[X] LLMs/Chat Models
[X] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[X] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
The code is included:
from langchain.vectorstores import FAISS
loader = CSVLoader("./rag_data/a.csv")
documents_aws = loader.load()
docs = CharacterTextSplitter(chunk_size=2000, chunk_overlap=400, separator=",").split_documents(documents_aws)
def custom_score(i):
#return 1 - 1 / (1 + np.exp(i))
return 1
vectorstore_faiss_aws = FAISS.from_documents(documents=docs,embedding = br_embeddings)
vectorstore_faiss_aws.relevance_score_function=custom_score
Expected behavior
The score to be in the range of 0 and 1 and the vectorstore_faiss_aws.similarity_search_with_relevance_scores to react to score_threshold

@dosu-bot
Thank you for your help. This was helpful. A Follow-up question. It seems that the metric used here is L2. How can I change it to cosine similarity?

@dosu-bot
Thank you for your great help. In your answer you used DistanceStrategy.MAX_INNER_PRODUCT . What is the difference of this and DistanceStrategy.DOT_PRODUCT?

@dosu-bot
Thank you for your answer. I have a follow-up question. Once I set the distance strategy for FAISS, do I need to explicitly set it for similarity_search_with_score method?

@dosu-bot
Thank you for your help. I have a follow-up question. Do I need to normalize_L2 to True?
Thank you

@dosu-bot
Thank you for your help. Can you tell me about Jaccard similarity and what needs to be set in its conjunction. Is it better than MAX_INNER_PRODUCT and do I need to set normalize_L2 ? Also, what is the range of values for Jaccard Similarity? As far as I know, Jaccard similarity is defined for binary valued vectors, but FAISS is not binary valued. So how is the Jaccard similarly calculated with langchain?

@dosu-bot
I am using the latest version of langchain by issuing
!pip install --upgrade langchain
I do not see any errors, I am using langchain for an RAG application and would like to know if the Jaccard Similarity is better than MAX_INNER_PRODUCT and if I need to set normalize_L2

@dosu-bot
Thank you for your great help. Do you have any information in the range of values returned by Jaccard and how does it map into similarity, I am specifically asking about langchain implementation for non binary vectors.

I wonder if override_relevance_score_fn can be used with FAISS.from_documents. I tried but ended up with unexpected keyword argument 'override_relevance_score_fn' error.

@dosu-bot I wonder if override_relevance_score_fn can be used with FAISS.from_documents. I tried but ended up with unexpected keyword argument 'override_relevance_score_fn' error.


Increase bufio's buffer size to handle long lines

Because of its default buffer size of 4K, bufio.Scan() cannot handle long lines of some datatypes like nodeinfo1 (around 80K).

This change is

Coverage: 85.744% (+0.1%) from 85.639% when pulling 69a270af8185efc139ca1c8962d6fd11cefce402 on sandbox-saied into af3f96577bfe9193c1aeca54a4bb69759d06e6d2 on main.

test/cmd/check_bundles/check_bundles.go line 188 at r1 (raw file):
Previously, stephen-soltesz (Stephen Soltesz) wrote…
This is only applicable to the test utility?
Is https://pkg.go.dev/encoding/json#Decoder an option instead of a scanner?

Yes, it's only applicable to the test utility.
For strict sanity checking, the utility makes sure that it finds the file at a specific line number in the bundle.  Using bufiomakes it easy to keep track of line number vias.Split(bufio.ScanLines).

Thank you.


Fixed azure_key_vault_secret crashes when keyvault name is camel-case Closes #637

Integration test logs

Logs

No env file present for the current environment:  staging
 Falling back to .env config
No env file present for the current environment:  staging
customEnv TURBOT_TEST_EXPECTED_TIMEOUT undefined

SETUP: tests/azure_key_vault_secret []

PRETEST: tests/azure_key_vault_secret

TEST: tests/azure_key_vault_secret
Running terraform
data.azurerm_client_config.current: Reading...
azurerm_resource_group.named_test_resource: Refreshing state... [id=/subscriptions/3510ae4d-530b-497d-8f30-53b9616fc6c1/resourceGroups/turbottest86537]
data.azurerm_client_config.current: Read complete after 0s [id=Y2xpZW50Q29uZmlncy9jbGllbnRJZD0wNGIwNzc5NS04ZGRiLTQ2MWEtYmJlZS0wMmY5ZTFiZjdiNDY7b2JqZWN0SWQ9MDZmZDQ2YjAtYTg2Ny00OWExLWE0ZjEtZjc3Njg0NjVjYWJhO3N1YnNjcmlwdGlvbklkPWQ0NmQ3NDE2LWY5NWYtNDc3MS1iYmI1LTUyOWQ0Yzc2NjU5Yzt0ZW5hbnRJZD1jZGZmZDcwOC03ZGEwLTRjZWEtYWJlYi0wYTRjMzM0ZDdmNjQ=]
data.null_data_source.resource: Reading...
data.null_data_source.resource: Read complete after 0s [id=static]
azurerm_key_vault.named_test_resource: Refreshing state... [id=/subscriptions/3510ae4d-530b-497d-8f30-53b9616fc6c1/resourceGroups/turbottest86537/providers/Microsoft.KeyVault/vaults/turbottest86537]
azurerm_key_vault_secret.named_test_resource: Refreshing state... [id=https://turbottest86537.vault.azure.net/secrets/turbottest86537/9389cdcdf1954198b2c19498be4f5c4e]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # azurerm_key_vault.named_test_resource must be replaced
-/+ resource "azurerm_key_vault" "named_test_resource" {
      ~ access_policy                   = [
          ~ {
              - application_id          = ""
              - certificate_permissions = []
              - key_permissions         = []
              - storage_permissions     = []
                # (3 unchanged attributes hidden)
            },
        ]
      - enable_rbac_authorization       = false -> null
      - enabled_for_deployment          = false -> null
      - enabled_for_disk_encryption     = false -> null
      - enabled_for_template_deployment = false -> null
      ~ id                              = "/subscriptions/3510ae4d-530b-497d-8f30-53b9616fc6c1/resourceGroups/turbottest86537/providers/Microsoft.KeyVault/vaults/turbottest86537" -> (known after apply)
      ~ name                            = "turbottest86537" -> "turbottest76829" # forces replacement
      - purge_protection_enabled        = false -> null
      ~ resource_group_name             = "turbottest86537" -> "turbottest76829" # forces replacement
      - tags                            = {} -> null
      ~ vault_uri                       = "https://turbottest86537.vault.azure.net/" -> (known after apply)
        # (5 unchanged attributes hidden)

      - network_acls {
          - bypass                     = "AzureServices" -> null
          - default_action             = "Allow" -> null
          - ip_rules                   = [] -> null
          - virtual_network_subnet_ids = [] -> null
        }
    }

  # azurerm_key_vault_secret.named_test_resource must be replaced
-/+ resource "azurerm_key_vault_secret" "named_test_resource" {
      ~ id                      = "https://turbottest86537.vault.azure.net/secrets/turbottest86537/9389cdcdf1954198b2c19498be4f5c4e" -> (known after apply)
      ~ key_vault_id            = "/subscriptions/3510ae4d-530b-497d-8f30-53b9616fc6c1/resourceGroups/turbottest86537/providers/Microsoft.KeyVault/vaults/turbottest86537" # forces replacement -> (known after apply) # forces replacement
      ~ name                    = "turbottest86537" -> "turbottest76829" # forces replacement
      ~ resource_id             = "/subscriptions/3510ae4d-530b-497d-8f30-53b9616fc6c1/resourceGroups/turbottest86537/providers/Microsoft.KeyVault/vaults/turbottest86537/secrets/turbottest86537/versions/9389cdcdf1954198b2c19498be4f5c4e" -> (known after apply)
      ~ resource_versionless_id = "/subscriptions/3510ae4d-530b-497d-8f30-53b9616fc6c1/resourceGroups/turbottest86537/providers/Microsoft.KeyVault/vaults/turbottest86537/secrets/turbottest86537" -> (known after apply)
      ~ tags                    = {
          ~ "name" = "turbottest86537" -> "turbottest76829"
        }
      ~ version                 = "9389cdcdf1954198b2c19498be4f5c4e" -> (known after apply)
      ~ versionless_id          = "https://turbottest86537.vault.azure.net/secrets/turbottest86537" -> (known after apply)
        # (2 unchanged attributes hidden)
    }

  # azurerm_resource_group.named_test_resource must be replaced
-/+ resource "azurerm_resource_group" "named_test_resource" {
      ~ id       = "/subscriptions/3510ae4d-530b-497d-8f30-53b9616fc6c1/resourceGroups/turbottest86537" -> (known after apply)
      ~ name     = "turbottest86537" -> "turbottest76829" # forces replacement
      - tags     = {} -> null
        # (1 unchanged attribute hidden)
    }

Plan: 3 to add, 0 to change, 3 to destroy.

 Resources: 3 added, 0 changed, 3 destroyed.

Outputs:

location = "westus"
resource_aka = "azure://https://turbottest76829.vault.azure.net/secrets/turbottest76829/2a85fc95faa44164ad9ba5e12f7fe12a"
resource_aka_lower = "azure://https://turbottest76829.vault.azure.net/secrets/turbottest76829/2a85fc95faa44164ad9ba5e12f7fe12a"
resource_id = "https://turbottest76829.vault.azure.net/secrets/turbottest76829/2a85fc95faa44164ad9ba5e12f7fe12a"
resource_name = "turbottest76829"
secret_uri_without_version = "https://turbottest76829.vault.azure.net/secrets/turbottest76829"
secret_version = "2a85fc95faa44164ad9ba5e12f7fe12a"
subscription_id = "3510ae4d-530b-497d-8f30-53b9616fc6c1"

Running SQL query: test-get-query.sql
[
  {
    "content_type": "text",
    "enabled": true,
    "id": "https://turbottest76829.vault.azure.net/secrets/turbottest76829/2a85fc95faa44164ad9ba5e12f7fe12a",
    "name": "turbottest76829",
    "recoverable_days": 7,
    "recovery_level": "CustomizedRecoverable+Purgeable",
    "region": "westus",
    "resource_group": "turbottest76829",
    "subscription_id": "3510ae4d-530b-497d-8f30-53b9616fc6c1",
    "value": "steampipe",
    "vault_name": "turbottest76829"
  }
]
✔ PASSED

Running SQL query: test-list-query.sql
[
  {
    "id": "https://turbottest76829.vault.azure.net/secrets/turbottest76829/2a85fc95faa44164ad9ba5e12f7fe12a",
    "name": "turbottest76829"
  }
]
✔ PASSED

Running SQL query: test-not-found-query.sql
null
✔ PASSED

Running SQL query: test-turbot-query.sql
[
  {
    "akas": [
      "azure:///subscriptions/3510ae4d-530b-497d-8f30-53b9616fc6c1/resourceGroups/turbottest76829/providers/Microsoft.KeyVault/vaults/turbottest76829/secrets/turbottest76829",
      "azure:///subscriptions/3510ae4d-530b-497d-8f30-53b9616fc6c1/resourcegroups/turbottest76829/providers/microsoft.keyvault/vaults/turbottest76829/secrets/turbottest76829"
    ],
    "name": "turbottest76829",
    "tags": {
      "name": "turbottest76829"
    },
    "title": "turbottest76829"
  }
]
✔ PASSED

POSTTEST: tests/azure_key_vault_secret

TEARDOWN: tests/azure_key_vault_secret

SUMMARY:

1/1 passed.

Example query results

Results
> select * from azure_key_vault_secret
+-----------------+--------------------------------------------------------------------------------------------------+-------------------+---------+---------+--------------+---------------------------+------------+--------+------------+------------------+-------------->
| name            | id                                                                                | vault_name        | enabled | managed | content_type | created_at                | expires_at | kid    | not_before | recoverable_days | recovery_leve>
+-----------------+--------------------------------------------------------------------------------------------------+-------------------+---------+---------+--------------+---------------------------+------------+--------+------------+------------------+-------------->
| turbottest86537 | https://turbottest86537.vault.azure.net/secrets/turbottest86537/9389cdcdf1954198b2c19498be4f5c4e | turbottest86537   | true    | <null>  | text         | 2023-07-27T13:05:02+05:30 | <null>     | <null> | <null>     | 7                | CustomizedRec>
| CamelCase       | https://turbottest86537.vault.azure.net/secrets/CamelCase/fc5f037904104738bff8476571d20027       | turbottest86537   | true    | <null>  | <null>       | 2023-07-27T13:12:13+05:30 | <null>     | <null> | <null>     | 7                | CustomizedRec>
| test-secret     | https://keyvaultcamelcase.vault.azure.net/secrets/test-secret/7b49e5c40eff41b79f35bac546746cf5   | keyvaultcamelcase | true    | <null>  | text         | 2023-07-27T13:18:41+05:30 | <null>     | <null> | <null>     | 7                | CustomizedRec>
+-----------------+--------------------------------------------------------------------------------------------------+-------------------+---------+---------+--------------+---------------------------+------------+--------+------------+------------------+-------------->

Time: 6.0s. Rows fetched: 3. Hydrate calls: 12.
> select * from azure_key_vault_secret where vault_name = 'turbottest86537' and name = 'CamelCase'
+-----------+--------------------------------------------------------------------------------------------+-----------------+---------+---------+--------------+---------------------------+------------+--------+------------+------------------+---------------------------->
| name      | id                                                                                | vault_name      | enabled | managed | content_type | created_at                | expires_at | kid    | not_before | recoverable_days | recovery_level             >
+-----------+--------------------------------------------------------------------------------------------+-----------------+---------+---------+--------------+---------------------------+------------+--------+------------+------------------+---------------------------->
| CamelCase | https://turbottest86537.vault.azure.net/secrets/CamelCase/fc5f037904104738bff8476571d20027 | turbottest86537 | true    | <null>  | <null>       | 2023-07-27T13:12:13+05:30 | <null>     | <null> | <null>     | 7                | CustomizedRecoverable+Purge>
+-----------+--------------------------------------------------------------------------------------------+-----------------+---------+---------+--------------+---------------------------+------------+--------+------------+------------------+---------------------------->

> select * from azure_key_vault_secret where vault_name = 'keyvaultcamelcase' and name = 'test-secret'
+-------------+------------------------------------------------------------------------------------------------+-------------------+---------+---------+--------------+---------------------------+------------+--------+------------+------------------+-------------------->
| name        | id                                                                                | vault_name        | enabled | managed | content_type | created_at                | expires_at | kid    | not_before | recoverable_days | recovery_level     >
+-------------+------------------------------------------------------------------------------------------------+-------------------+---------+---------+--------------+---------------------------+------------+--------+------------+------------------+-------------------->
| test-secret | https://keyvaultcamelcase.vault.azure.net/secrets/test-secret/7b49e5c40eff41b79f35bac546746cf5 | keyvaultcamelcase | true    | <null>  | text         | 2023-07-27T13:18:41+05:30 | <null>     | <null> | <null>     | 7                | CustomizedRecoverab>
+-------------+------------------------------------------------------------------------------------------------+-------------------+---------+---------+--------------+---------------------------+------------+--------+------------+------------------+-------------------->

@ParthaI I think it is worth reviewing this section of code - https://github.com/turbot/steampipe-plugin-azure/blob/d5a14b57a79ab157100351ef41d76f536221a3f9/azure/table_azure_key_vault_secret.go#L264-L293
I don't think we need to make an additional API call to get Turbot data. We can use the ParentHydrate or the Hydrate call instead. That way we might not have an API mismatch error.

@ParthaI I think it is worth reviewing this section of code -
https://github.com/turbot/steampipe-plugin-azure/blob/d5a14b57a79ab157100351ef41d76f536221a3f9/azure/table_azure_key_vault_secret.go#L264-L293
I don't think we need to make an additional API call to get Turbot data. We can use the ParentHydrate or the Hydrate call instead. That way we might not have an API mismatch error.

@misraved, Thanks for pointing it out, We need an extra API call in this case.

Because the columns (region, resource_group, and akas) value can not be populate. because we are not getting that much information from list/get call of secret.
If we want to get the things using parent hydrate from the list config we may get but not from the get config.


Make test_shuffle_drop_ratio by not setting shuffle_row_drop_partitions >> rowgroup size.

It was working fast while we knew the number of rows in each rowgroup. We don't have this information now,
so there are many row-groups that are dropped without being used by shuffle_row_drop_partition feature.
The time it takes for the test to finish now is 2 seconds instead of 23 seconds (and I assume it takes more on travis)

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b25d161). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master    #214   +/-   ##
========================================
  Coverage          ?   85.7%
========================================
  Files             ?      69
  Lines             ?    3574
  Branches          ?     473
========================================
  Hits              ?    3063
  Misses            ?     412
  Partials          ?      99

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b25d161...38b78a8. Read the comment docs.


fix: support cyclic dependencies

fix #153
For CycloneDX it's just a matter of stopping the recursive function when the cyclic dependency is detected.
However for SPDX, the root node does not point to the direct dependencies so it is not possible to draw a reliable graph in that case as there are multiple alternatives. In that case it will be better to throw a validation error.

lgtm
Tested OK on 2 sboms containing cyclic dependencies.


1.1.0.RC1 not published in repo.spring.io

<spring-cloud-bus.version>1.1.0.RC1</spring-cloud-bus.version> is referenced in spring cloud brixton rc1 release deps, but not resolvable in repo https://repo.spring.io/

Hi,
The proper repository url for the artifact is:
http://repo.spring.io/libs-milestone
Cheers,
Marius

From his gitter comments, I think he's complaining about the bus redis starter specifically.

see also https://github.com/spring-cloud/spring-cloud-stream/issues/454 and https://github.com/spring-cloud/spring-cloud-starters/issues/47

closing, point to the right repo and spring-cloud-starter-bus-redis is no longer provided.


Did not set up a Password and cannot log in anymore

Describe the bug
A pin was set up before without a password, upon restarting, I cannot log in to the machine using the pin
To Reproduce
Steps to reproduce the behavior:

Start machine after security setting updated
Select login and type in previously used pin
Wait for login
See error

Expected behavior
The pin would work as a password with the previous user
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Heya,
I can't see how this is related to the script as it doesn't interact at all with any security settings.
It's likely related to changes to your MS account or pc hardware.
I have found this post here on MS forums of someone encountering this issue, with a possible solution involving a third party tool called Hiram BootCD. I don't have any experience with this tool however.