BUILD-348: share discoverability ('use' verb, namespace scope roles); inject build-284 in repo

/assign @adambkaplan
/assign @coreydaley
@deads2k FYI (if anything else, for api godoc)
So this PR proves out our recent discussions in slack and @coreydaley 's https://github.com/openshift/api/pull/979
Highlights:

switches to only a 'use' verb when seeing if the Pod SA can use / mount a SharedResource
I replaced use of ClusterRole/ClusterRoleBinding in tests/examples to vet out the discussion point around allowing namespace admins to grant permissions to SA's in their namespaces for shares they can discover based on separate roles etc. around getting and listing SharedResources
I pulled in @coreydaley 's PR change into this repo's current local API def, including updating the godoc based on the simplification @deads2k noted because of the switch to the 'use' verb , and updated all the code/tests with the changes from that
presumably when @coreydaley 's PR merges his openshift/api vendor into this repo should be greatly simplified
I've deferred on the naming discussion @adambkaplan is having with Jan on the groupname ... left it as is from @coreydaley 's PR for now

I'm still going to put up a openshift/enhancements update, but I am currently of the opinion this PR progresses us on the path, could be merged after review, and then follow up PRs can come if the EP merge or api merge results in addition adjustments.

all green e2e's @adambkaplan @coreydaley

getting 500s from CIs registry on startup of all jobs
will sit tight and retry tests later

/retest

/lgtm


OpenCL error Error: [ComputeCpp:RT0208] Failed to enqueue OpenCL command  (clEnqueueNDRangeKernel) CL_OUT_OF_RESOURCES

System information

Have I written custom code: No
OS Platform and Distribution:Linux Ubuntu 16.04
TensorFlow installed from: build from the source with https://github.com/lukeiwanski/tensorflow/tree/dev/eigen_mehdi
TensorFlow version:v1.1.0-rc1-7178-g9586bef 1.3.0
Python version: 3.5.2
Bazel version (if compiling from source):0.5.4
CUDA/cuDNN version: none
GPU model and memory: none
Exact command to reproduce:~/Downloads/models/tutorials/image/imagenet$ python3 classify_image.py

Describe the problem
I have an i5-6500 CPU but no GPU in my computer.
i tried the "hello world" example, it was OK.
But, when i try the imagenet example from http://github.com/tensorflow/models, I got a erro like this:
OpenCL error Error: [ComputeCpp:RT0208] Failed to enqueue OpenCL command  (clEnqueueNDRangeKernel) CL_OUT_OF_RESOURCES

after that I tried the mnist example, and I got this problem too.
Source code / logs

2017-10-31 20:57:41.791291: I tensorflow/core/platform/cpu_feature_guard.cc:137] Your CPU supports instructions that this TensorFlow binary was not compiled to use: SSE4.1 SSE4.2 AVX AVX2 FMA
2017-10-31 20:57:41.794652: W ./tensorflow/core/common_runtime/sycl/sycl_device.h:49] No OpenCL GPU found that is supported by ComputeCpp, trying OpenCL CPU
2017-10-31 20:57:41.872196: I ./tensorflow/core/common_runtime/sycl/sycl_device.h:66] Found following OpenCL devices:
2017-10-31 20:57:41.872229: I ./tensorflow/core/common_runtime/sycl/sycl_device.h:68] id: 0, type: CPU, name: Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz, vendor: Intel(R) Corporation, profile: FULL_PROFILE
2017-10-31 20:57:42.252877: W ./tensorflow/core/framework/op_def_util.cc:334] Op BatchNormWithGlobalNormalization is deprecated. It will cease to work in GraphDef version 9. Use tf.nn.batch_normalization().
 OpenCL error Error: [ComputeCpp:RT0208] Failed to enqueue OpenCL command  (clEnqueueNDRangeKernel) CL_OUT_OF_RESOURCES
Error detected Inside Sycl Device.
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 1323, in _do_call
    return fn(*args)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 1302, in _run_fn
    status, run_metadata)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/errors_impl.py", line 473, in __exit__
    c_api.TF_GetCode(self.status.status))
tensorflow.python.framework.errors_impl.InternalError: Unknown error detected on device /job:localhost/replica:0/task:0/device:SYCL:0

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "classify_image.py", line 227, in <module>
    tf.app.run(main=main, argv=[sys.argv[0]] + unparsed)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/platform/app.py", line 48, in run
    _sys.exit(main(_sys.argv[:1] + flags_passthrough))
  File "classify_image.py", line 193, in main
    run_inference_on_image(image)
  File "classify_image.py", line 157, in run_inference_on_image
    {'DecodeJpeg/contents:0': image_data})
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 889, in run
    run_metadata_ptr)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 1120, in _run
    feed_dict_tensor, options, run_metadata)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 1317, in _do_run
    options, run_metadata)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 1336, in _do_call
    raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.InternalError: Unknown error detected on device /job:localhost/replica:0/task:0/device:SYCL:0

clinfo
Number of platforms                               1
  Platform Name                                   Intel(R) OpenCL
  Platform Vendor                                 Intel(R) Corporation
  Platform Version                                OpenCL 2.0
  Platform Profile                                FULL_PROFILE
  Platform Extensions                             cl_khr_icd cl_khr_global_int32_base_atomics cl_khr_global_int32_extended_atomics cl_khr_local_int32_base_atomics cl_khr_local_int32_extended_atomics cl_khr_byte_addressable_store cl_khr_depth_images cl_khr_3d_image_writes cl_intel_exec_by_local_thread cl_khr_spir cl_khr_fp64 cl_khr_image2d_from_buffer
  Platform Extensions function suffix             INTEL

  Platform Name                                   Intel(R) OpenCL
Number of devices                                 1
  Device Name                                     Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz
  Device Vendor                                   Intel(R) Corporation
  Device Vendor ID                                0x8086
  Device Version                                  OpenCL 2.0 (Build 475)
  Driver Version                                  <IP_ADDRESS>5
  Device OpenCL C Version                         OpenCL C 2.0
  Device Type                                     CPU
  Device Profile                                  FULL_PROFILE
  Max compute units                               4
  Max clock frequency                             3200MHz
  Device Partition                                (core)
    Max number of sub-devices                     4
    Supported partition types                     by counts, equally, by names (Intel)
  Max work item dimensions                        3
  Max work item sizes                             8192x8192x8192
  Max work group size                             8192
  Preferred work group size multiple              128
  Preferred / native vector sizes
    char                                                 1 / 32
    short                                                1 / 16
    int                                                  1 / 8
    long                                                 1 / 4
    half                                                 0 / 0        (n/a)
    float                                                1 / 8
    double                                               1 / 4        (cl_khr_fp64)
  Half-precision Floating-point support           (n/a)
  Single-precision Floating-point support         (core)
    Denormals                                     Yes
    Infinity and NANs                             Yes
    Round to nearest                              Yes
    Round to zero                                 No
    Round to infinity                             No
    IEEE754-2008 fused multiply-add               No
    Support is emulated in software               No
    Correctly-rounded divide and sqrt operations  No
  Double-precision Floating-point support         (cl_khr_fp64)
    Denormals                                     Yes
    Infinity and NANs                             Yes
    Round to nearest                              Yes
    Round to zero                                 Yes
    Round to infinity                             Yes
    IEEE754-2008 fused multiply-add               Yes
    Support is emulated in software               No
    Correctly-rounded divide and sqrt operations  No
  Address bits                                    64, Little-Endian
  Global memory size<PHONE_NUMBER> (7.716GiB)
  Error Correction support                        No
  Max memory allocation<PHONE_NUMBER> (1.929GiB)
  Unified memory for Host and Device              Yes
  Shared Virtual Memory (SVM) capabilities        (core)
    Coarse-grained buffer sharing                 Yes
    Fine-grained buffer sharing                   Yes
    Fine-grained system sharing                   Yes
    Atomics                                       Yes
  Minimum alignment for any data type             128 bytes
  Alignment of base address                       1024 bits (128 bytes)
  Preferred alignment for atomics
    SVM                                           64 bytes
    Global                                        64 bytes
    Local                                         0 bytes
  Max size for global variable                    65536 (64KiB)
  Preferred total size of global vars             65536 (64KiB)
  Global Memory cache type                        Read/Write
  Global Memory cache size                        262144
  Global Memory cache line                        64 bytes
  Image support                                   Yes
    Max number of samplers per kernel             480
    Max size for 1D images from buffer            129451136 pixels
    Max 1D or 2D image array size                 2048 images
    Base address alignment for 2D image buffers   64 bytes
    Pitch alignment for 2D image buffers          64 bytes
    Max 2D image size                             16384x16384 pixels
    Max 3D image size                             2048x2048x2048 pixels
    Max number of read image args                 480
    Max number of write image args                480
    Max number of read/write image args           480
  Max number of pipe args                         16
  Max active pipe reservations                    65535
  Max pipe packet size                            1024
  Local memory type                               Global
  Local memory size                               32768 (32KiB)
  Max constant buffer size                        131072 (128KiB)
  Max number of constant args                     480
  Max size of kernel argument                     3840 (3.75KiB)
  Queue properties (on host)
    Out-of-order execution                        Yes
    Profiling                                     Yes
    Local thread execution (Intel)                Yes
  Queue properties (on device)
    Out-of-order execution                        Yes
    Profiling                                     Yes
    Preferred size<PHONE_NUMBER> (4GiB)
    Max size<PHONE_NUMBER> (4GiB)
  Max queues on device<PHONE_NUMBER>
  Max events on device<PHONE_NUMBER>
  Prefer user sync for interop                    No
  Profiling timer resolution                      1ns
  Execution capabilities
    Run OpenCL kernels                            Yes
    Run native kernels                            Yes
    SPIR versions                                 1.2
  printf() buffer size                            1048576 (1024KiB)
  Built-in kernels
  Device Available                                Yes
  Compiler Available                              Yes
  Linker Available                                Yes
  Device Extensions                               cl_khr_icd cl_khr_global_int32_base_atomics cl_khr_global_int32_extended_atomics cl_khr_local_int32_base_atomics cl_khr_local_int32_extended_atomics cl_khr_byte_addressable_store cl_khr_depth_images cl_khr_3d_image_writes cl_intel_exec_by_local_thread cl_khr_spir cl_khr_fp64 cl_khr_image2d_from_buffer

NULL platform behavior
  clGetPlatformInfo(NULL, CL_PLATFORM_NAME, ...)  No platform
  clGetDeviceIDs(NULL, CL_DEVICE_TYPE_ALL, ...)   No platform
  clCreateContext(NULL, ...) [default]            No platform
  clCreateContext(NULL, ...) [other]              Success [INTEL]
  clCreateContextFromType(NULL, CL_DEVICE_TYPE_CPU)  No platform
  clCreateContextFromType(NULL, CL_DEVICE_TYPE_GPU)  No platform
  clCreateContextFromType(NULL, CL_DEVICE_TYPE_ACCELERATOR)  No platform
  clCreateContextFromType(NULL, CL_DEVICE_TYPE_CUSTOM)  No platform
  clCreateContextFromType(NULL, CL_DEVICE_TYPE_ALL)  No platform

Hi @JulyJohn, thanks for your report. As described on this page, https://www.khronos.org/registry/OpenCL/sdk/1.2/docs/man/xhtml/clEnqueueNDRangeKernel.html, CL_OUT_OF_RESOURCES is returned from the OpenCL implementation "if there is a failure to queue the execution instance of kernel on the command-queue because of insufficient resources needed to execute the kernel. For example, the explicitly specified local_work_size causes a failure to execute the kernel because of insufficient resources such as registers or local memory." I guess one of the kernels in Tensorflow uses too many resources for Intel CPU? I'm not sure, however. I'll find out from our developers if there's a way we can print some more information about exactly what is failing (and therefore why it is failing).

@DuncanMcBain thanks for your reply:-)
I was wondering what the meaning of different branches are, and the difference between them.
Since I only compiled successfully with "eigen_mehdi" branch, but always failed with almost of the other branches.

Hi,
/dev/eigen_mehdi is the branch you should use, it refers to a particular version of Eigen that we pull from. The Intel GPU branch is likely to be a little stale at the moment, we investigated it a little but I don't think anyone's working on it right now.

@JulyJohn Apologies for so many branches.. cleaning that is high on my priority list. There are few reasons for that.. for instance what @DuncanMcBain mentioned above - we are actively improving Eigen library that drives TensorFlow computation.
As well branches are created for: pull requests and different features (across different platforms) that we are working on
We did work on Intel GPU support via Beignet - however that has been put on hold for now, therefore branch is quite behind.
As Duncan suggested use dev/eigen_mehdi or dev/amd_gpu
Back to your compilation problem: it seems that you are using old version of ComputeCpp could you pick up the latest and give it a spin?
Luke

Hi, @DuncanMcBain @lukeiwanski
I tried it again, and got an erro like this:
hejunhua@hejunhua-B150M-D3H:~/Downloads/code/models/tutorials/image/imagenet$ python3 classify_image.py
>> Downloading inception-2015-12-05.tgz 100.0%
Successfully downloaded inception-2015-12-05.tgz 88931400 bytes.
2017-11-21 11:54:10.564309: I tensorflow/core/platform/cpu_feature_guard.cc:137] Your CPU supports instructions that this TensorFlow binary was not compiled to use: SSE4.1 SSE4.2 AVX AVX2 FMA
2017-11-21 11:54:10.610305: W ./tensorflow/core/common_runtime/sycl/sycl_device.h:49] No OpenCL GPU found that is supported by ComputeCpp, trying OpenCL CPU
2017-11-21 11:54:10.657781: I ./tensorflow/core/common_runtime/sycl/sycl_device.h:66] Found following OpenCL devices:
2017-11-21 11:54:10.657843: I ./tensorflow/core/common_runtime/sycl/sycl_device.h:68] id: 0, type: CPU, name: Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz, vendor: Intel(R) Corporation, profile: FULL_PROFILE
2017-11-21 11:54:10.988000: W ./tensorflow/core/framework/op_def_util.cc:334] Op BatchNormWithGlobalNormalization is deprecated. It will cease to work in GraphDef version 9. Use tf.nn.batch_normalization().
LLVM ERROR: Cannot select: 0x7f9dfc6bf560: v2i64 = bitcast 0x7f9dfdcb7380 [ORD=25] [ID=136]
  0x7f9dfdcb7380: v4i64 = and 0x7f9dfc100db0, 0x7f9dfdcb6c10 [ORD=16] [ID=131]
    0x7f9dfc100db0: v4i64 = bitcast 0x7f9dfdd66710 [ORD=16] [ID=126]
      0x7f9dfdd66710: v8i32 = X86ISD::VSHLI 0x7f9dfdd66e80, 0x7f9dfdd675f0 [ORD=13] [ID=124]
        0x7f9dfdd66e80: v8i32 = X86ISD::VZEXT 0x7f9dfc52bcb0 [ORD=12] [ID=123]
          0x7f9dfc52bcb0: v8i16 = X86ISD::PINSRW 0x7f9dfc0c5640, 0x7f9dfc6bf450, 0x7f9dfc100310 [ORD=11] [ID=122]
            0x7f9dfc0c5640: v8i16 = X86ISD::PINSRW 0x7f9dfc63eab0, 0x7f9dfdcb6b00, 0x7f9dfd221680 [ORD=11] [ID=121]
              0x7f9dfc63eab0: v8i16 = X86ISD::PINSRW 0x7f9dfdcb6e30, 0x7f9dfc0fffe0, 0x7f9dfc50d250 [ORD=11] [ID=120]
                0x7f9dfdcb6e30: v8i16 = X86ISD::PINSRW 0x7f9dfc6bf780, 0x7f9dfc100420, 0x7f9dfc100200 [ORD=11] [ID=118]
                  0x7f9dfc6bf780: v8i16 = X86ISD::PINSRW 0x7f9dfc0c5200, 0x7f9dfc50d9c0, 0x7f9dfdcb7050 [ORD=11] [ID=116]

                  0x7f9dfc100420: i32 = any_extend 0x7f9dfc2f11f0 [ORD=11] [ID=72]

                  0x7f9dfc100200: i64 = Constant<4> [ID=25]
                0x7f9dfc0fffe0: i32 = any_extend 0x7f9dfce63d70 [ORD=11] [ID=73]
                  0x7f9dfce63d70: i16,ch = CopyFromReg 0x7f9dfd623b30, 0x7f9dfe028c40 [ORD=9] [ID=50]

                0x7f9dfc50d250: i64 = Constant<5> [ID=26]
              0x7f9dfdcb6b00: i32 = any_extend 0x7f9dfcc676c0 [ORD=11] [ID=74]
                0x7f9dfcc676c0: i16,ch = CopyFromReg 0x7f9dfd623b30, 0x7f9dfc52bba0 [ORD=10] [ID=51]
                  0x7f9dfc52bba0: i16 = Register %vreg210 [ID=10]
              0x7f9dfd221680: i64 = Constant<6> [ID=27]
            0x7f9dfc6bf450: i32 = any_extend 0x7f9dfc50dad0 [ORD=11] [ID=75]
              0x7f9dfc50dad0: i16,ch = CopyFromReg 0x7f9dfd623b30, 0x7f9dfc63e890 [ORD=11] [ID=52]
                0x7f9dfc63e890: i16 = Register %vreg211 [ID=11]
            0x7f9dfc100310: i64 = Constant<7> [ID=28]
        0x7f9dfdd675f0: i8 = Constant<13> [ID=17]
    0x7f9dfdcb6c10: v4i64 = bitcast 0x7f9dfd976a90 [ORD=16] [ID=108]
      0x7f9dfd976a90: v8i32 = X86ISD::VBROADCAST 0x7f9dfc2f10e0 [ID=99]
        0x7f9dfc2f10e0: i32,ch = load 0x7f9dfd623b30, 0x7f9dfccba180, 0x7f9dfce63820<LD4[ConstantPool]> [ID=86]
          0x7f9dfccba180: i64 = X86ISD::Wrapper 0x7f9dfc2f0640 [ID=63]
            0x7f9dfc2f0640: i64 = TargetConstantPool<i32 268435455> 0 [ID=39]
          0x7f9dfce63820: i64 = undef [ID=29]
In function: SYCL_ef04060d33f36a4172a9c5f3b83552c7_0
 SYCL Runtime closed with the following errors:
SYCL objects are still alive while the runtime is shutting down

 This probably indicates that a SYCL object was created  but not properly destroyed.
terminate called without an active exception
Stack dump:
0.	Running pass 'Function Pass Manager' on module 'main'.
1.	Running pass 'X86 DAG->DAG Instruction Selection' on function '@SYCL_ef04060d33f36a4172a9c5f3b83552c7_0'
Aborted (core dumped)

@JulyJohn  / @DuncanMcBain  ping

0.5.0 isn't the most recent version any more, so it would be interesting to see if we can replicate it on the newest version.


[BugFix] Fix snapshot manager get tablet max version crash

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #12765
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

BE Build Success

run starrocks_admit_test

@mergfiy backport branch-2.4 branch-2.3 branch-2.2


RequestCancelWorkflowExecution does not work without RunID

Cadence should allow cancelling workflow execution with just workflow ID.  If the workflow is running we should be able to lookup the runID of current execution.
Seems like we have unnecessary validation on frontend as the history engine code already have logic for load running execution using just the workflow ID.
Current the RequestCancelWorkflowExecution call fails with the following error:
BadRequestError({Message:RunId is not set on request.})

Frontend just tries to validate the uuid if RunID is set.  So the behavior looks correct.  Maybe we should skip the check if RunID is set as empty string.

already solved 1 year ago


Folder synchronization lost. Some folders are OK, some not.

Folder synchronization lost. Some folders are OK, some not.
my log id: b58f877110d6dd3bba58911c

22724723d6fcc0ee4b0ee01c

b58f877110d6dd3bba58911c

It looks like this is the same issue as #9034, and will be fixed in the next release (hopefu.  If you'd like to fix it sooner, the user whose data has not been synchronized should try installing this experimental build, which worked for another user: https://s3.amazonaws.com/prerelease.keybase.io/darwin-test/Keybase-1.0.34-20171013234544%2B8bdf88aed.dmg.


consider addinf roaring bitmap to benchmarks

https://docs.rs/roaring/latest/roaring/

The RoaringBitmap looks very cool! Thanks for suggesting this.
I'm very interested in testing it with the model of 'clumpiness' used by the benchmark. (Described in Benchmark #2)
I hope to do this "soon", but don't have a timetable.

The update is complete. Thanks again for the suggestion!
https://github.com/CarlKCarlK/range-set-blaze/blob/main/docs/bench.md
In general, Roaring is much better than RangeSetBlaze when the u32s are uniform. RangeSetBlaze does much better than Roaring on clumpy integers. Both offer similar interfaces. If you're not sure which is best for your application, you can easily swap between them and see.


Update tofu-optics-core, ... to 0.10.1

Updates

tf.tofu:tofu-optics-core
tf.tofu:tofu-optics-macro

from 0.10.0 to 0.10.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (0.10.0).
You might want to review and update them manually.
examples/project/plugins.sbt
project/plugins.sbt

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "tf.tofu" } ]

labels: library-update, semver-patch, old-version-remains

Superseded by #565.


HOSTEDCP-950: Validate release payload images

What this PR does / why we need it:
Validates and report missing images in the release payload in ValidReleaseInfo condition
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #HOSTEDCP-950
Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.

/retest-required

Do we want to do the same thing with the ignition server? (https://github.com/openshift/hypershift/blob/main/ignition-server/controllers/local_ignitionprovider.go#L318-L324)

/lgtm

/approve

/cherry-pick release-4.13


Support SSH key based auth for cluster repos

When we bootstrap the cluster we point ArgoCD to a git repo where manifests for the cluster are stored. Accessing this repo currently uses username and password, but we want to support SSH keys too.

[ ] create GIT_SSH_KEY environment variable and use it instead of username/password for connecting to the cluster repo if it is present
[ ] document usage of GIT_SSH_KEY

https://argo-cd.readthedocs.io/en/stable/operator-manual/declarative-setup/#repositories

Depends on https://github.com/cli/cli/issues/6519


Document how to activate this plugin

Adding pyenv-lazy (the main body of the plugin file) and zsh-pyenv-lazy (the name of the directory in ~/.oh-my-zsh/custom/plugins) both fail.

Resolved by #1

#1 is now merged. Thanks! 🌻


[Roadmap] Use OpenAI TTS models for speech generation to avoid having too many API keys

Why
Having to register additionally with ElevenLabs for voice generation is a hussle. Also, they don't provide "pay as you go" plans. OpenAI has pretty good speech generation model TTS-1, and it can be used directly with the openAI API key, thus simplifying the setup process and the comfort of use.
Description
Use OpenAI TTS model by default if OpenAI API key is provided. Make ElevenLabs optional if API key is added, and allow to select which one to use (similar to the image generation selection).

Thanks @nick-harder this will require some abstraction to switch and configure the models (and add/remove them dynamically alongside model providers, as one could have multiple openai set up for instance).
Code is welcome here, I'm not sure I can tackle this on the short term as I'm implementing the full multimodal pipeline now.


Register vaathi.is-cool.dev

Added vaathi.is-cool.dev using the CLI.

I have read the CLA Document and I hereby sign the CLA


Firefox Mobile + Gboard behaves poorly

I reviewed the state of the latest CodeMirror on various Android browsers and keyboards.  I found that my personal favorite combination, Chrome + SwiftKey, now works very well, so that's what I'll recommend to my users.  I found some problems with Firefox and Gboard individually, and especially together.  Here's one consistent reproduction sequence that might be helpful for debugging:

Load https://codemirror.net/demo/sublime.html
Tap right after a comma at the end of one of the lines (e.g. line 2)
Swipe a word like "hello" (without lifting your finger)
The cursor ends up to the left of "hello", instead of to the right of "hello" as it should.
Swiping another word like "world" puts that word before "hello" instead of "after"

But it didn't work well with chrome web view + G-Keyboard :(

Hello, is there any progress on this matter?
I found that any MultiByte-based Gboard, on both iOS and Android, performs weirdly due to it's word conversion.
Example, normallly はなし -> 話, however upon inputing な after は , the cursor resets in front of は , making it hard to input text.
No issue on PC though.

Did you try the version 6 demo? While CodeMirror 6 is far from usable, it is intended to fix issues like these.

@adrianheine
Thank you for introducing version 6 :)
It solved word conversion issue, however the 1st multibyte letter on the line will reset the gboard input.
I understand is still far from completion, heres my experience at the moment.
By using the the はなし -> 話 example again,
I will need to type は, な, し in order to convert it to 話.
The current symptom is, if I try to input it on the beginning on the line, after inputing は,
gboard resets as it starts to input another word. (This do not happen in the middle of the line)

Thanks for trying out the demo! If you feel like it you could open an issue about your problem on https://github.com/codemirror/codemirror.next/issues.


Wrap React Email For Reflex.

@elviskahoro I want to work on this bounty as a part of hacktoberfest for Reflex 🔥

Sure @itsmeadarsh2008

We looked into this and it doesn't make sense to do!


Autolingo error named "AUTOLINGO - UNKNOWN CHALLENGE TYPE: listenIsolation"

It means that that specific challenge type is not supported.

hi mate, EASY FIX :)
go into your duolingo settings and simply TURN OFF listening exercises.
should work :)
yw


[Bug Report]: Exceptionally large Rspack config causes segfault

System Info
  System:
    OS: macOS 13.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 1.42 GB / 64.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 19.8.1 - ~/.nvm/versions/node/v19.8.1/bin/node
    npm: 9.5.1 - ~/.nvm/versions/node/v19.8.1/bin/npm
    Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
  Browsers:
    Chrome: 111.0.5563.64
    Safari: 16.2
  npmPackages:
    @rspack/cli: latest => 0.1.2
    @rspack/core: latest => 0.1.2

Details
When testing on this repo from @tbranyen I noticed that there is different behavior based on the size of the Rspack config that is generated. On the edge of where I get segfault and where I get a clean build there is an intermittent alternative state with the below error.
[rspack-cli] [Error: error[internal]: internal error: entered unreachable code.
Raw: panicked at 'internal error: entered unreachable code', /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.24.1/src/sync/rwlock.rs:773:13
This is not expected, please file an issue at https://github.com/web-infra-dev/rspack/issues.

   0: _napi_register_module_v1
   1: <unknown>
   2: _napi_register_module_v1
   3: _napi_register_module_v1
   4: _napi_register_module_v1
   5: _napi_register_module_v1
   6: _napi_register_module_v1
   7: _napi_register_module_v1
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: <unknown>
  14: <unknown>
  15: _napi_register_module_v1
  16: _napi_register_module_v1
  17: _napi_register_module_v1
  18: _napi_register_module_v1
  19: <unknown>
  20: <unknown>
  21: <unknown>
  22: _napi_register_module_v1
  23: _napi_register_module_v1
  24: _napi_register_module_v1
  25: _napi_register_module_v1
  26: __pthread_deallocate

] {
  code: 'GenericFailure'
}

Reproduce link
No response
Reproduce Steps
Segfault

run npm i
run npm run build:rspack

Troubleshooting
On my machine modifying line 27 of dev.js to 66 then running the above steps caused the build to enter the intermittent state. 65 always passes for me and 67 always creates a seg fault.

Hey @Boshen, here is a backtrace I got on Ubuntu 22.04, hope it helps.
#0  0x00007fffe3032368 in <tokio::sync::batch_semaphore::Acquire as core::future::future::Future>::poll () from<EMAIL_ADDRESS>#1  0x00007fffe1028a12 in tokio::sync::rwlock::RwLock<T>::write::{{closure}} () from<EMAIL_ADDRESS>#2  0x00007fffe1009c7c in rspack_core::compiler::Compiler<T>::build::{{closure}}::{{closure}} () from<EMAIL_ADDRESS>#3  0x00007fffe1030449 in _ZN11rspack_node6Rspack5build28_$u7b$$u7b$closure$u7d$$u7d$28_$u7b$$u7b$closure$u7d$$u7d$17he440184997b23026E.llvm.12465974412614280580 ()
   from<EMAIL_ADDRESS>#4  0x00007fffe0f9cf57 in <rspack_error::catch_unwind::CatchUnwindFuture<F> as core::future::future::Future>::poll () from<EMAIL_ADDRESS>#5  0x00007fffe0f610eb in _ZN11rspack_node5utils11callbackify28_$u7b$$u7b$closure$u7d$$u7d$17h9b52104fe767b248E.llvm.12397566669204084719 ()
   from<EMAIL_ADDRESS>#6  0x00007fffe0fae2c5 in tokio::runtime::task::core::Core<T,S>::poll () from<EMAIL_ADDRESS>#7  0x00007fffe0f8c256 in tokio::runtime::task::harness::Harness<T,S>::poll () from<EMAIL_ADDRESS>#8  0x00007fffe303e58b in tokio::runtime::scheduler::multi_thread::worker::Context::run_task () from<EMAIL_ADDRESS>#9  0x00007fffe303dc60 in tokio::runtime::scheduler::multi_thread::worker::Context::run () from<EMAIL_ADDRESS>#10 0x00007fffe302d159 in tokio::macros::scoped_tls::ScopedKey<T>::set () from<EMAIL_ADDRESS>#11 0x00007fffe303d6e1 in tokio::runtime::scheduler::multi_thread::worker::run () from<EMAIL_ADDRESS>#12 0x00007fffe303c8a3 in tokio::loom::std::unsafe_cell::UnsafeCell<T>::with_mut () from<EMAIL_ADDRESS>#13 0x00007fffe303005c in tokio::runtime::task::core::Core<T,S>::poll () from<EMAIL_ADDRESS>#14 0x00007fffe303609f in tokio::runtime::task::harness::Harness<T,S>::poll () from<EMAIL_ADDRESS>#15 0x00007fffe3043a52 in tokio::runtime::blocking::pool::Inner::run () from<EMAIL_ADDRESS>#16 0x00007fffe302be9a in std::sys_common::backtrace::__rust_begin_short_backtrace () from<EMAIL_ADDRESS>#17 0x00007fffe30415cb in core::ops::function::FnOnce::call_once{{vtable.shim}} () from<EMAIL_ADDRESS>#18 0x00007fffe3074963 in alloc::boxed::{impl#45}::call_once<(), dyn core::ops::function::FnOnce<(), Output=()>, alloc::alloc::Global> () at library/alloc/src/boxed.rs:2000
#19 alloc::boxed::{impl#45}::call_once<(), alloc::boxed::Box<dyn core::ops::function::FnOnce<(), Output=()>, alloc::alloc::Global>, alloc::alloc::Global> () at library/alloc/src/boxed.rs:2000
#20 std::sys::unix::thread::{impl#2}::new::thread_start () at library/std/src/sys/unix/thread.rs:108
#21 0x00007ffff7ae2b43 in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:442
#22 0x00007ffff7b74a00 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81

@messense Thank you for looking into this. Are you looking at this purely from the perspective of why the lock crashed?
I'm more interested in why the system in spawning so many threads that the lock crashed, I'll tackle from this angle.

I found a workaround, but I need some assistance on real projects to verify if this works.
Inside<EMAIL_ADDRESS>add options.parallelism = 1; below line 29:
class MultiCompiler {
    constructor(compilers, options) {
        options.parallelism = 1;

And comment out line 444
                if (result) {
                    node.result = undefined;
                    // stats.push(result);
                }

There are two problems at hand:

Running the multi compiler in parallel will cause Rspack to go haywire on the Rust side
Sending a huge stats array through napi will cause it to crash

Fixed in #2744 , you can find the cause there🥰

@JSerFeng will this be in 1.9 or is there a canary we can test with?

@JSerFeng will this be in v1.9 or is there a canary we can test with?

Yes, there is a nightly version of it, you can try @rspack/cli: nightly, then run npm run build:rspack

@JSerFeng I installed the latest rspack using:
    "@rspack/cli": "nightly",
    "@rspack/core": "nightly",

and reran:
    "build:rspack": "NODE_ENV=development npx rspack --config webpack.config.js --mode=development",

In the repo linked in the original comment, and I'm still seeing:
><EMAIL_ADDRESS>build:rspack
> NODE_ENV=development npx rspack --config webpack.config.js --mode=development

zsh: segmentation fault (core dumped)  npm run build:rspack

Could you validate the changes in that reduced test case?

Could you validate the changes in that reduced test case?

Check this sandbox, created from your issue repo, but 150 configs for this 2 cores machine are way too much, so I changed the total config number to 30, it will run very slow, but won't have segfault again, try deleting your package-lock.json, and node_modules, then reinstall, everything will work well again.

@JSerFeng everything works in the repo now! Excellent :100: Thank you for validating

Thank you everyone for the hard work on this issue.  Really interesting to see what the root cause was.

You can the cause in #2744


iOS crash when starting to drag

I got this crash
libc++abi: terminating due to uncaught exception of type folly::ConversionError: Loss of precision during arithmetic conversion: (long long) 99.46

    <Carousel
      data={data}
      height={100}
      pagingEnabled={true}
      snapEnabled={true}
      width={Constants.DeviceWidth - 2 * 24}
      style={{
        marginTop: 24,
        alignItems: 'center',
        justifyContent: 'center',
        width: '100%',
        height: 160
      }}
      mode={'vertical-stack'}
      modeConfig={{
        snapDirection: 'left',
        stackInterval: 10
      }}
      customConfig={() => ({ type: 'positive', viewCount: 1 })}
      renderItem={InsightCarouselCell}
    />

Versions (please complete the following information):

react: 18.3.1

react-native: 0.76.0

react-native-reanimated: 3.16.1

react-native-reanimated-carousel: 4.0.0-canary.22

react-native-gesture-handler: 2.21.2

Device: iPhone16 Pro

OS: iOS18.1

same issue in android

same issue in expo also. I realized this bug was related to updating panOffset value in onGestureStart function which is implemented in ScrollViewGesture.tsx.
"react-native-reanimated": "~3.16.1"
"react-native-reanimated-carousel": "4.0.0-canary.19"

Only happens when using "mode"

Same issue with:

"react": "18.3.1",
"react-native": "0.76.5",
"react-native-reanimated": "^3.16.1",
"react-native-reanimated-carousel": "^3.5.1",
"react-native-gesture-handler": "~2.20.2",

Loss of precision during arithmetic conversion: (long long)

works, thanks


This version vs SD 1.4(CompVis)

I test two images using SD 1.4 from CompVis and this consistencydecoder, and is seems that no obvious difference between of them. Anyone else found this?

@yuhaoliu7456  could you provide more context? I tried myself and the outputs of SD v1.4 VAEDecoder and ConsistencyDecoder  differ significantly.
Code:
vae = AutoencoderKL.from_pretrained(
    "CompVis/stable-diffusion-v1-4",
    subfolder="vae",
    revision="fp16",
    torch_dtype=torch.float16,
).to(device)

sample_vae = vae.decode(latent).sample.detach()

sample_consistency = decoder_consistency(latent)

VAE

ConsistencyDistillation

@yuhaoliu7456 could you provide more context? I tried myself and the outputs of SD v1.4 VAEDecoder and ConsistencyDecoder  differ significantly.
Code:
vae = AutoencoderKL.from_pretrained(
    "CompVis/stable-diffusion-v1-4",
    subfolder="vae",
    revision="fp16",
    torch_dtype=torch.float16,
).to(device)

sample_vae = vae.decode(latent).sample.detach()

sample_consistency = decoder_consistency(latent)

VAE  ConsistencyDistillation

Can you provide this original image and I can test it by myself? Thanks

@yuhaoliu7456 Sure, you can upload it from this url:
https://img.championat.com/c/900x900/news/big/p/l/real-madrid_1651732892490413154.jpg

Is it possible to load a local VAE encoder instead of pointing to Huggingface?

@Kallamamran if you have directory with model weights and config you can try:
AutoencoderKL.from_pretrained(path_to_local_dir, subfolder="vae" or no subfolder)


Publish Obelisk packages on Hackage

Are there any plans to publish Obelisk's Haskell code on Hackage the way reflex-frp is published there?
This could provide a gentle path for people who like reflex-frp and want to try Routes or other components but do not want to lose control over how the code is deployed.

I can answer this question now: There is a long, long road where obelisk and its underlying dependencies can be more easily published outside of the mess of nix that keeps them stable. There is no specific plan, but it is a consideration that we take into account on a regular basis.


Build.use yarn1.9.4

The kubevirt-web-ui-components recently requires yarn >= 1.9.0.
But current openshift/console build image is based on yarn 1.7.0.
Unless we decrease this dependency in kubevirt-web-ui-components, we have to deviate from openshift/console by using custom builder image.

This might be reverted in the future, if kubevirt-web-ui-components ease its requirements.

As I've just built web-ui image using this PR to address imminent need for demo and the web-ui-components requirements are about to be eased again, I'm not merging this.
Let's see if we can reuse openshift/console build scripts again.


Separate tags from test title

Playwright version 1.42 offers a new syntax to seperate tags from title, this will make the test looks little neat
https://playwright.dev/docs/release-notes#version-142

Reviewed Merging changes . Thanks for your contribution


cli should validate/behave more consistently w.r.t 'name' in func.yaml

if 'name' is missing from func.yaml on fn build then 'fn build' runs a garbage build with no image name,
fn deploy defaults name to the PWD
it should either work, or validate that func.yaml has name
version: 0.0.6
runtime: java
cmd: com.example.fn.HelloFunction::handleRequest
build_image: fnproject/fn-java-fdk-build:jdk9-1.0.56
run_image: fnproject/fn-java-fdk:jdk9-1.0.56
format: http

fn  --verbose build                                                                                1
Building image :0.0.6
invalid argument ":0.0.6" for "-t, --tag" flag: invalid reference format
See 'docker build --help'.

Error during build. Run with `--verbose` flag to see what went wrong. eg: `fn --verbose CMD`
ERROR: error running docker build: exit status 125

i think this https://github.com/fnproject/cli/pull/541 clarifies and name has changed quite a bit since this issue


chore: bzlmod

Part of https://github.com/aspect-build/rules_js/issues/63
and a criteria for 1.0 release of this ruleset


lsm9ds0: Initial implementation

This module implements support for the LSM9DS0 accelerometer,
magnetometer, and gyroscope.
It was developed on the Sparkfun 9DOF sensor block for Intel Edison.
https://www.sparkfun.com/products/13033
Commonly used capabilities are supported, and methods/register
definitions exist to easily implement any desired functionality that
is missing.  Interrupt support has also been added.
Signed-off-by: Jon Trulson<EMAIL_ADDRESS>

Thanks, merged 36b0e1dce0f10dabc59ea7669f2183a44a84a48e!


do not want client redirects all internet traffic over the VPN (OVPN_DEFROUTE=0)

I have disabled  push "redirect-gateway" by  OVPN_DEFROUTE=0, I do not want client redirects all internet traffic over the VPN.
But I cannot anymore ping the openvpn server ip.

I'd double check the setting in your client aren't adding the default route.  Also manually verify client config.  If the server isn't pushing routes, those are the only ways that could happen.

I'm using docker run  OVPN_DEFROUTE=0 ... but the Internet traffic is still going through VPN (I need VPN only to access it through IP).
Am I missing something obvious?

Ah, probably I didn't issue the client certificate using OVPN_DEFROUTE=0


Fix dem hopper example

Description of the problem

The DEM Hopper example had bad meshing at corners
The example did not used any rolling friction method and the no_resistance was the default value when example was added.
Some DEM examples and application tests did not have rolling friction methods, but had explicit rolling friction coefficients for p-p and p-w which was a bit incoherent.

Description of the solution

A new GMSH mesh was generated.
The rolling resistance torque method was set to constant_resistance
Unused rolling friction coefficients in application tests and example where removed

How Has This Been Tested?

Application tests passed
Removing the rolling friction coefficients should not have changed the examples since no_resistance was the previous default method

Comments

Some examples should actually use a rolling friction method, but since results are shown in the documentation of the examples, the use of a rolling friction must need a rerun to verify that the new results are mostly the same with the previous results.

@blaisb Still waiting for the simulation results, the plot also needs to be changed and the only mesh to be deleted.

@blaisb documentation have been modified


Istio JWT should forward token to workload

Description
Configure Istio RequestAuthentication JWT rules with forwardOriginalToken set to true.
Reasons
providing same functionality as ORY oathkeeper
DoD:

[x] provide documentation
- [ ] release notes and What's New updates for Kyma customers
[x] provide unit tests
- [ ] provide integration tests
[x] test on production-like environment
- [ ] verify resource limits
- [ ] followup issue
- [ ] create release and bump in kyma

Attachments

[x] https://github.com/kyma-project/api-gateway/pull/375

What is the forwardOriginalToken syntax with ORY ?

@ptesny it's default setting for ORY. you don't need to configure it


0.9.0

@quanrs Was this opened by mistake? If so, could you please close it?

closing as-per INFRA-11185


Update how it works

Please update the "how it works page" to be congruent with figma
We mad some changes in the font and writing, please verify the whole page and adjust if necessary.

close


/proc/net/tcp and similar not working (thus breaking netstat, ss)

Microsoft Windows [Version 10.0.15063], build 15063.138
Ubuntu 16.04.2 LTS (for user windows account)

Netstat and ss doesn't show listening and established connections due to the underlying info is not present in /proc/net/{tcp,tcp6,udp,udp6}. If I'm not mistaken it worked earlier.
$ strace netstat -nap
...
open("/proc/net/tcp", O_RDONLY)         = 3
read(3, "", 4096)                       = 0
close(3)                                = 0
...
Steps:

$ nc -l -p 4545  # nc.openbsd
In windows cmd
C:\> netstat -a -n -t | findstr 4545
  TCP    <IP_ADDRESS>:4545           <IP_ADDRESS>:0              LISTENING       InHost
In bash
$ netstat -nap
Active Internet connections (servers and established)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name
Active UNIX domain sockets (servers and established)
Proto RefCnt Flags       Type       State         I-Node   PID/Program name    Path
$ wc /proc/net/tcp
0 0 0 /proc/net/tcp
Next we connect to port 4545 from another window:
$ nc localhost 4545
everything is ok here
After successful connection we see (windows cmd)
C:\> netstat -a -n -t | findstr 4545
  TCP    <IP_ADDRESS>:4545         <IP_ADDRESS>:36204        ESTABLISHED     InHost
  TCP    <IP_ADDRESS>:36204        <IP_ADDRESS>:4545         ESTABLISHED     InHost
In bash netstat output still is empty

#69 (message).

Thanks for reporting the issue, closing this out as a duplicate so we can track it on one thread.


Cannot run tests with Maven on a recent java version. (need to update bnd version in pom.xml)

Cannot run tests with Maven on a recent java version.
According to https://github.com/bndtools/bnd/issues/3903 it looks like we need to update bnd version to at least 5.1.0.
$ mvn test
[INFO] Scanning for projects...
[INFO]
[INFO] -----------------< org.java-websocket:Java-WebSocket >------------------
[INFO] Building Java-WebSocket 1.5.4-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ Java-WebSocket ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /home/admin/Java-WebSocket/src/main/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @ Java-WebSocket ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 78 source files to /home/admin/Java-WebSocket/target/classes
[INFO] /home/admin/Java-WebSocket/src/main/java/org/java_websocket/drafts/Draft.java: /home/admin/Java-WebSocket/src/main/java/org/java_websocket/drafts/Draft.java uses or overrides a deprecated API t
hat is marked for removal.
[INFO] /home/admin/Java-WebSocket/src/main/java/org/java_websocket/drafts/Draft.java: Recompile with -Xlint:removal for details.
[INFO]
[INFO] --- bnd-maven-plugin:4.3.1:bnd-process (default) @ Java-WebSocket ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  3.694 s
[INFO] Finished at: 2022-07-04T13:00:14Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal biz.aQute.bnd:bnd-maven-plugin:4.3.1:bnd-process (default) on project Java-WebSocket: bnd error: null: ConcurrentModificationException -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[= 1]

Environment(please complete the following information):

Version used:
bdf928b
Java version:

openjdk 17.0.3 2022-04-19
OpenJDK Runtime Environment (build 17.0.3+7-alpine-r2)
OpenJDK 64-Bit Server VM (build 17.0.3+7-alpine-r2, mixed mode, sharing)

Operating System and version: Linux 5.15.43-0-virt #1-Alpine SMP Thu, 26 May 2022 10:32:47 +0000 x86_64 Linux

This was fixed in as part of #1309


Zotero 6 beta citation key field

Log ID: HUDQAFXA-refs-euc
In the latest Zotero beta, the new Preprint item type has a Citation Key field. This field picks up and matches the BBT Citation key, but editing this field does not currently change the BBT Citation key, so it reverts immediately. Better behavior would be for edits to this field to be function as pinning the key.

JFC I'd have hoped they would have ran this by me earlier. This is going to be a pain to work around.

All types will get it eventually. They haven't added it to other types because they need to turn off syncing on the old schema first.

It will be a PITA to do this piecemeal. So yes, it makes sense to use the field for pinning the citekey, but because they have chosen to pick the key out of my DB and fill it in that field, that route is effectively blocked, because the test "is that field filled, then it is a pinned key" is now gone, because that field is always filled now.
The only sensible thing for me is to wait until all item types have this field, then do a one-time migration of my DB to that field, and then move my DB to a place where Zotero doesn't pick it up anymore, because I will still need my own DB  to shadow these keys. So from the looks of it, the current state is just the way things are going to be until all item types have this field. Once that is available, I can split the pinning method between beta and release, but it will mean that in beta, all keys are pinned keys.
Really would have hoped to get more notice on a thing like this.

they need to turn off syncing on the old schema first.

wait -- all users must have migrated to 6 before any of these itemtypes get this field?! Meaning that 6 would go non-beta with only preprint having this field? Ay caramba! Please tell me I'm wrong on this 😭 .

I am wrong, fortunately. That field uses getField to retrieve the value, but since I've patched getField to fetch the key from my DB, it reverts immediately. I know this will look shitty in the interim, but I'm going to see if I can wait out all itemtypes getting this, and then make that the storage for the (now always pinned) citekey.

@dstillman Tagging you in here in case there might be a smooth way to integrate here

Maybe an ultimate solution would be to add a check box that is "pin" next to this new field. You might not need a shadow copy then

I will still need a shadow DB, because I need to be able to retrieve the keys synchronously in a few places.


Add README documentation for "spellCheckDelayMs" setting

Updated the README file to include documentation for the new "cSpell.spellCheckDelayMs" configuration setting, including it's default value.

Thank you.  I'll push it out in my next release in a few days.


Reorganize CUB environment variables

Currently there're 4 CUB-related environment variables.

CUB_PATH: used at build time to build cupy.cuda.cub
CUPY_CUB_PATH: used at runtime to build  reduction kernel (#3244)
CUPY_CUB_BLOCK_REDUCTION_DISABLED (default: 1): Set to 0 to enable performance boost in reduction kernel (#3244)
CUB_DISABLED (default: 1): Set to 0 to enable CUB in various computations

We think it is better to disable CUB by default, even in CUDA 11, as users expect reproducibility (deterministic behavior). Instead, we need to provide a simple "opt-in" method to enable CUB for users needing a performance boost.
This issue proposes the followings:

Remove CUB_PATH and CUPY_CUB_PATH (always use bundled CUB #2584 or CUDA 11 built-CUB, as user-provided CUB headers are unlikely to be used (considering we haven't requested to implement CUPY_THRUST_PATH).
Merge CUPY_CUB_BLOCK_REDUCTION_DISABLED and CUB_DISABLED into one environment variable CUPY_CUB_ENABLED (default: 0, set to 1 to opt-in).
For debugging purposes, we will internally leave undocumented cupy.core.cub_reduction.enable flag (default: True). (note: cupy.core.cub_reduction refactoring in progress by @asi1024 )

Logic:

CUPY_CUB_ENABLED
cupy.core.cub_reduction.enable
CUB (general)
CUB (reduction)

1
True
Enable
Enable

1
False
Enable
Disable

0
True
Disable
Disable

0
False
Disable
Disable

cc/ @leofang @anaruse

Thanks for organizing the logics, @kmaehashi!

Remove CUB_PATH and CUPY_CUB_PATH (always use bundled CUB #2584 or CUDA 11 built-CUB, as user-provided CUB headers are unlikely to be used (considering we haven't requested to implement CUPY_THRUST_PATH).

As I explained recently in #2584 and in https://github.com/cupy/cupy/pull/3244#issuecomment-644269815, we prefer to keep CUPY_CUB_PATH (and use it in both build time for cupy.cuda.cub and in runtime for using cupy.core.cub_reduction) because on conda-forge we can make cupy depend on cub (which is version-locked to thrust and vice versa). This was @jakirkham's proposal (https://github.com/conda-forge/cupy-feedstock/issues/60).
In any case, CUB_PATH is better to be removed (I marked it deprecated in #2584). Name collision is very unlikely to happen, but not impossible...

Merge CUPY_CUB_BLOCK_REDUCTION_DISABLED and CUB_DISABLED into one environment variable CUPY_CUB_ENABLED (default: 0, set to 1 to opt-in).

I don't have objection on combining them 👍 CUPY_CUB_BLOCK_REDUCTION_DISABLED was more a workaround/unresolved leftover from #3244, which I dislike.
But, I have two comments (probably not a big deal):

if you are setting default to 0, why not just keep CUB_DISABLED as is? (Double negative is annoying, I admit...)
Combining them will lose the flexibility to toggle them on/off separately using env vars, and runtime toggles as listed in your table would be the only solution.

Provide cupy.core.cub_reduction.enable flag (default: True) to provide an option to turn-off CUB in reduction feature. (note: cupy.core.cub_reduction refactoring in progress by @asi1024 )

Sounds good. So this will replace cupy.core.cub_block_reduction_enabled from #3244, right?
By the way, I think the last element in the 3rd row of your table is wrong. CUB (reduction) should be Enabled when cupy.core.cub_reduction.enable=True.

As I explained recently in #2584 and in #3244 (comment), we prefer to keep CUPY_CUB_PATH (and use it in both build time for cupy.cuda.cub and in runtime for using cupy.core.cub_reduction) because on conda-forge we can make cupy depend on cub (which is version-locked to thrust and vice versa). This was @jakirkham's proposal (conda-forge/cupy-feedstock#60).

Won't we be building cupy with the cub bundled in the git submodule or the cuda11 one?

Won't we be building cupy with the cub bundled in the git submodule or the cuda11 one?

First, I thought about it today, and I feel once we bundle it, we won't be able to choose the CUDA 11 one without explicitly overwriting (via CUPY_CUDA_PATH).
Next, I guess @jakirkham was having in mind -- I may be very wrong -- that we as package maintainers are free to choose newer CUB should one be available, not bound by anyone's release cycle. 😂
But, I do wanna point out that it's best to stick to CuPy's choice of CUB, because it gets tested by the CIs here. We have experienced multiple issues not having CI get our back...

if you are setting default to 0, why not just keep CUB_DISABLED as is? (Double negative is annoying, I admit...)

It's because we thought it's better to avoid double-negative and follow "set 1 to enable" convention like as in other environment variables.
https://docs-cupy.chainer.org/en/latest/reference/environment.html

Sounds good. So this will replace cupy.core.cub_block_reduction_enabled from #3244, right?

Yes. (sorry, I updated the text just before you post the comment)

By the way, I think the last element in the 3rd row of your table is wrong. CUB (reduction) should be Enabled when cupy.core.cub_reduction.enable=True.

This is intentional (CUPY_CUB_ENABLED is the master control of CUB features in CuPy).

But, I do wanna point out that it's best to stick to CuPy's choice of CUB, because it gets tested by the CIs here. We have experienced multiple issues not having CI get our back...

Regarding CUPY_CUDA_PATH, I think it's better to avoid mixing various versions of CUB (use cub conda package for reductions, use CuPy-bundled CUB for others).

It is difficult to guarantee future CUB + CuPy to work, and difficult to reproduce an error reported by users
I think CUB is relatively stable and users are unlikely to need non-bundled versions

By the way, I think the last element in the 3rd row of your table is wrong. CUB (reduction) should be Enabled when cupy.core.cub_reduction.enable=True.

This is intentional (CUPY_CUB_ENABLED is the master control of CUB features in CuPy).

Ah, OK, but it'd be nice to able to turn off global/general CUB and turn on cupy.core.cub_reduction. It's useful at least for debugging and benchmarking. Could you think of some way to do this (could be undocumented 😇)?

Regarding CUPY_CUDA_PATH, I think it's better to avoid mixing various versions of CUB (use cub conda package for reductions, use CuPy-bundled CUB for others) in a single release.

I agree. So, if on conda-forge we are determined to make cupy depend on cub (overwriting the bundle), we will need to set CUPY_CUB_PATH to conda's include dir in the activation script to ensure the CUB seen at runtime is identical to that at build time. This was the original intention when I did this:
https://github.com/cupy/cupy/blob/311390a7923cf7fb06ad5527c7c40f3b0a968f88/cupy/_environment.py#L77-L78

Regarding CUPY_CUDA_PATH, I think it's better to avoid mixing various versions of CUB (use cub conda package for reductions, use CuPy-bundled CUB for others) in a single release.

I agree. So, if on conda-forge we are determined to make cupy depend on cub (overwriting the bundle), we will need to set CUPY_CUB_PATH to conda's include dir in the activation script to ensure the CUB seen at runtime is identical to that at build time. This was the original intention when I did this:
https://github.com/cupy/cupy/blob/311390a7923cf7fb06ad5527c7c40f3b0a968f88/cupy/_environment.py#L77-L78

Not saying we are bound to do this, just providing a solution.

How about cupy.cuda.cub_enabled? Is it controlled by CUPY_CUB_ENABLED?

(overwriting the bundle)

Why would you want to overwrite the bundle? (I am asking because I can't figure out such situation 😥)

We discussed and come up with this solution:
(1) Provide documented APIs to specify the order of preferred backends. Both are empty by default (i.e., fallback to use naive cupy implementation).
CUPY_ROUTINE_BACKENDS="cub,cutensor"
CUPY_REDUCTION_BACKENDS="cub,cutensor"

(2) Provide undocumented APIs for debugging and benchmarking purposes:
cupy.core.set_routine_backends(['cub', 'cutensor'])
cupy.core.set_reduction_backends(['cub', 'cutensor'])

(overwriting the bundle)

Why would you want to overwrite the bundle? (I am asking because I can't figure out such situation 😥)

@emcastillo Because we can then use newer CUB from conda-forge, see all available versions here. Moreover, it allows us to simplify the package recipe as follows (@jakirkham correct me if I'm wrong!):
requirements:
  build:
    - (...)

  host:
    - (...)
    - cub ==1.9  # this also pulls down thrust
    run_exports:
      strong:
        - cub

  run:
    - (...)
    # dependency on exactly the same version of cub/thrust is inherited via run_exports

The effect is more or less the same as what would be achieved with conda install -c conda-forge cupy cub==1.9 ..., but with all the dependency requirements resolved and taken care by conda.

We discussed and come up with this solution:

Thank you, @kmaehashi! So am I understanding it correctly on the final decision for runtime APIs?

Public: cupy.core.cub_reduction.enable & cupy.cuda.cub_enable
Private/undocumented: cupy.core.set_*_backends()

@emcastillo Because we can then use newer CUB from conda-forge, see all available versions here. Moreover, it allows us to simplify the package recipe as follows (@jakirkham correct me if I'm wrong!):

I think we should stick to the bundled cub when distributing binaries because it is the main one tested and make user configurations deterministic across package systems. Changing packages versions depending on the environment is most likely going to give us headaches later on.
If the user wants to try a different cub version then he/she can update the submodule folder.

we should stick to the bundled cub when distributing binaries because it is the main one tested
If the user wants to try a different cub version then he/she can update the submodule folder.

Makes sense to me. This echos what I said earlier too.
Just need a final confirmation on this part:

So am I understanding it correctly on the final decision for runtime APIs?

Public: cupy.core.cub_reduction.enable & cupy.cuda.cub_enable
Private/undocumented: cupy.core.set_*_backends()

Another thing is what do you plan for CUDA 11? Do you wanna use CuPu's CUB or CUDA's? I guess it depends if you have a separate CI to test CUDA 11 or not...

Thank you, @kmaehashi! So am I understanding it correctly on the final decision for runtime APIs?

I'm thinking of cupy.core.cub_reduction.enable & cupy.cuda.cub_enable to be removed, as they're confusing after  "preferred order of backends" concept is introduced.
After discussing with @asi1024, we're now going to provide documented public interface CUPY_BACKENDS="cub,cutensor" env var, which controls the default preferred order of backends for both reduction and routines. For testing and debugging purposes, you can use undocumented cupy.core.set_*_backends().

Another thing is what do you plan for CUDA 11? Do you wanna use CuPy's CUB or CUDA's?

My idea is:

In CUDA 11, use CUB included in CUDA runtime. If CUB headers are unavailable in system (e.g., maybe in "runtime" docker container? I'm not sure as CUDA 11.0 is still RC...), use CUB bundled in CuPy.
In CUDA 10 or earlier, always use CUB bundled in CuPy. No external CUB_PATH.

@asi1024 @emcastillo  How do you think?

I guess it depends if you have a separate CI to test CUDA 11 or not...

I'm now preparing CI for CUDA 11.
The first cupy-cuda110 release would be in the next month.

I agree with @kmaehashi proposal

Sounds good. I'll resolve the conflict in #2584 based on this discussion.

@kmaehashi Could you update the issue summary to reflect everything discussed above? It'd be easier to refer to. Thanks!

Updated.

CUPY_CUB_PATH currently exists in a few places:
https://github.com/cupy/cupy/search?q=CUPY_CUB_PATH&unscoped_q=CUPY_CUB_PATH
I will send a PR to remove them.

Thank you, @kmaehashi! Glad to see everything works out! 💪


Error in type at build time

Describe the bug
At build time, errors are emitted due to a type in file client/base.d.ts
To Reproduce
Build openlayers in a typescript project
Expected behavior
Build run successfully

Looks like a problem with geotiff. Try reporting it there: https://github.com/geotiffjs/geotiff.js/

Done


rowwise() >> mutate() takes a long time to execute

rowwise() >> mutate()  takes a very long time to execute.
My original test data was 4000 columns and  2000 rows(mostly zeroes)  and took about 24minutes to execute but with sum(axis=1) took a few seconds.  I try to replicate the issue with the mtcars dataset below.
Also I would like to keep the index so I can know which values the sum belong to but rowwise() >> mutate()  takes it away -  sum(axis=1) keeps the index
Lines of code to replicate:
mt2 = mtcars.append(mtcars).append(mtcars).append(mtcars).append(mtcars)

mt2 >> rowwise() >> mutate(total = sum(c_across(everything())))

#compare to
mt2.sum(axis=1)

In the example below  rowwise() >> mutate()   takes   844ms  and  sum(axis=1) 26ms

Yep, noticed. Thanks for reporting. Working on a "fast" version at fast branch.

With 0.6.0:

It still takes longer, but the overhead was spent to parse the expressions, recycle the values, copy the original frames (so that the function is immutable). It uses sum(axis=1) to implement (sum(c_across())) under the hood, so the overhead is somehow fixed (won't increase while data gets bigger).

I can confirm the timing of datar's rowwise() >> mutate() is very similar to that of sum(axis)- even when the data size increases.
Thanks @pwwang !

Thanks for checking out.
You can also use datar.base.row_sums() (ported from rowSums() in R) in  this specific case to have less overhead that spent in assembling the frame from c_across().


Async method naming conventions

Apologies if this has been asked before, I couldn't find an issue about it.
C#/.NET design docs recommend the use of the Async suffix for async methods, and I think this is a well-established convention. The MediatR interfaces however don't use this suffix - e.g. Task<TResponse> Handle(TRequest request, CancellationToken cancellationToken).
Is there any plan to align with this convention?

No. Otherwise every single method would have Async in its name. So I opted for what some other, pure-async libraries do:
https://docs.particular.net/nservicebus/upgrades/5to6/async-suffix


Docker on pi

I'm trying to get the docker image running on my Raspberry Pi running Raspbian Stretch but when I start the docker container it exits immediately with:
standard_init_linux.go:211: exec user process caused "exec format error"
I think it's because the architecture for docker is locked to amd64 rather than armv6 or armv7 but I've only been playing with docker for a couple of days so I'm still learning.

Hello!
I was actually looking into multi-architecture Docker support shortly after the 1.4.0 release where we've added some preliminary arm/rpi support. I spent a good hour investigating what would be needed, and you beat me to this issue. :D I still trying to figure it all out, and I'll update this issue as soon as I have more knowledge on the subject.
Open to pointers, tips and tricks on how to convert a normal linux Docker image to multi-arch. I was looking for a recent "howto switch" article and couldn't really come up with one. I'm still very new to Docker and don't personally run any containers.

Can you try this?
docker pull golift/unifi-poller:latest_linux_arm

Lemme know! Thanks!

Hi David,
Thanks for your help.
I’m now getting a permissions error.  Trying to work out how to build an environment I can test in but I’m new to docker too - getting Grafana/InfluxDb/Telegraf and now your poller to work is my project to get me started on docker.
docker: Error response from daemon: OCI runtime create failed: container_linux.go:345: starting container process caused "exec: "/unifi-poller": permission denied": unknown.
Cheers,
Garan.

On 6 Jul 2019, at 00:29, David Newhall II<EMAIL_ADDRESS>wrote:
Can you try this?
docker pull golift/unifi-poller:latest_linux_arm
Lemme know! Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/davidnewhall/unifi-poller/issues/66?email_source=notifications&email_token=AAX5GRVZYBXQCZLD2KJFY23P57KL3A5CNFSM4H6N2MO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZKOE2A#issuecomment-508879464, or mute the thread https://github.com/notifications/unsubscribe-auth/AAX5GRQLOEI4SU5Y7AXRGTLP57KL3ANCNFSM4H6N2MOQ.

That seems so odd. I've been pushing new latest tags for the past few hours, maybe one of these commits will fix it. hah. I'm googling trying to figure out what can cause that particular error...

Figured it out. ARGs must be specified in each build stage. Try latest again in about 15-20 minutes after it finishes building.

Thanks for all of your help David and I’ve got it all working now.
I was getting a connection refused to get to my docker contained InfluxDB so I’m now using the following line to start my container with the —net=host line being key:
docker run --restart unless-stopped --detach --net=host --name=unifi-poller -v //up.conf:/etc/unifi-poller/up.conf golift/unifi-poller
Cheers,
Garan.

On 6 Jul 2019, at 20:59, David Newhall II<EMAIL_ADDRESS>wrote:
Closed #66 https://github.com/davidnewhall/unifi-poller/issues/66 via #69 https://github.com/davidnewhall/unifi-poller/pull/69.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/davidnewhall/unifi-poller/issues/66?email_source=notifications&email_token=AAX5GRQT4PQYJEK3763XVXDP6D2RNA5CNFSM4H6N2MO2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSLPPEDI#event-2464084493, or mute the thread https://github.com/notifications/unsubscribe-auth/AAX5GRVML7FJ4JBN274ULGDP6D2RNANCNFSM4H6N2MOQ.

Nice! That's good info, I'll add it to the Docker wiki. Please let me know if you run into any other problems, happy to help!


task: update golangci-lint to 1.39.0

Description
Updating our linting
Type of change:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Required Checklist:

[x] I have signed the MongoDB CLA
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added any necessary documentation (if appropriate)
[x] I have run make fmt and formatted my code

@themantissa this is a minor update so I'll just merge


Is this code working on raspberry pi model B  arm71 ?

I am running Grafana 7.4.1 on a raspberry pi 3 B  arm71 en put the plugin
grafana-sqlite-datasource  in the folder plugins but after restarting  grafana in the  pluginlist nothing shows up.
Do I something wrong ? or is this not working on my type  raspberry  ?

I don't have that exact device to test against, but I believe the plugin should be compatible.
Can you also try installing the plugin with the grafana-cli? grafana-cli plugins install frser-sqlite-datasource
Other than that the (error) logs of Grafana might provide further input :shrug:

When I installed I did it with      grafana-cli plugins install frser-sqlite-datasource  , and all files are in the plugins directory.
I tried another plugin and alsothisone show up.
For this reason I remove grafana  completely and install grafana and sqlite  again.
Now everything is working.
the error logs showed no errors.


Realtime / Unicast send returns timeout error

Bug report
Describe the bug
I'm trying to get started with realtime but am facing issues. I need unicast. The docs say I can do it but I'm facing a timeout sending unicast messages. If I switch to broadcast, it works.
To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:
receiver.js
const { createClient } = require('@supabase/supabase-js');

const supabaseUrl = 'https://***.supabase.co';
const supabaseKey = '***';
const supabase = createClient(supabaseUrl, supabaseKey);

const channel = supabase.channel('chat', {
    user_id: '5678',
})

channel.on('unicast', {event: 'new_message'}, event => {
    console.log(event)
})
    .subscribe()

sender.js
const { createClient } = require('@supabase/supabase-js');

const supabaseUrl = 'https://***.supabase.co';
const supabaseKey = '***';
const supabase = createClient(supabaseUrl, supabaseKey);

const channel = supabase.channel('chat', {
    user_id: '1234',
})

channel.subscribe(async (status) => {
    if (status === 'SUBSCRIBED') {
        console.log('subscribed')
        await channel.send({
            type: 'unicast',
            event: 'new_message',
            payload: { text: 'Hello, world!' },
            user_id: '5678',
        }).then(resp => {
            console.log('sending message got response:', resp)
        })

Expected behavior
A unicast message should be send and received.
System information

OS: Arch
Browser (if applies) [e.g. chrome, safari]
Version of supabase-js: 2.21.0
Version of Node.js: 19.9.0

This is so weird. I know I got that example passing user_id from the supabase docs, and described unicast as a parameter in the api, but now I can't find my way back to the doc. I'm not crazy!


feat: prev & next links for RSK section

What

Modify the jekyll include liquid template of the prev and next buttons
Modify the jekyll config to identify the rsk folder as a jekyll collection
Modify all the markdown files to add front matter metadata for collection_order
Modify the "index" pages to override permalink in front matter metadata

Why

So that reader may simply click on links at the bottom of each page to go to the next section instead of having to jump back and forth between the navigation column and the content
This has already been done for the quick start section

Refs

Task
Equivalent PR for Quick Start section

I really like it, we should implement it in every section

@alepc253 yes, this is the plan - getting there a little at a time!


[Question] Why are losses negative?

Many losses in the end return -loss , e.g. SoftDiceLoss or Tversky:
https://github.com/JunMa11/SegLoss/blob/131663994df22efb907e7ae897a39efe628518fc/losses_pytorch/dice_loss.py#L291
Why are the losses returned negative?

Hi @neuronflow ,
This is because dice_loss = 1 - dice.
1 can be omitted because constant does not affect backpropagation.
So, we use -dice as the loss.

Thanks for the quick response and why is this only done for a few of the losses? :)
E.g. Generalized Dice should follow the same results?

Yes. I standardize the GDice loss too.
1 - GDice -> - GDice.


[INLONG-9884][Manager] Optimized code AuditServiceImpl

Title Name: [INLONG-9884][Manager] Optimized code AuditServiceImpl
https://github.com/apache/inlong/issues/9884
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.

@balloon72 Thanks for your contribution!
This is a code-optimization type pull request same as #9888. Other places may also have the same problem. There will be too many issues and pull requests if we resolve them individually, also, it's hard to track all the issues.
So, I recommend bringing an umbrella issue to track all the code optimization issues at the module or sub-module level, each module or sub-module has only one issue to deal with the code optimization.
WDYT? Please feel free to share your opinions.

Great idea, I completely agree with this approach. Next time, I will create an umbrella issue to track code optimization problems.


Invalid content /en/testnets/cardano/overview/

Where does the issue occur?
Link to the file or location on the website where the issue occurs. Optionally add screenshots for context.
Describe the issue
A clear and concise description of what the issue is.
Expected changes
A clear and concise description of what you expected to change.
Additional context
Add any other context about the problem here.

Where does the issue occur?
Link to the file or location on the website where the issue occurs. Optionally add screenshots for context.
Describe the issue
A clear and concise description of what the issue is.
Expected changes
A clear and concise description of what you expected to change.
Additional context
Add any other context about the problem here.

Where does the issue occur?
Link to the file or location on the website where the issue occurs. Optionally add screenshots for context.
Describe the issue
A clear and concise description of what the issue is.
Expected changes
A clear and concise description of what you expected to change.
Additional context
Add any other context about the problem here.


venti v0.2.18

What this PR does / why we need it
venti v0.2.18
Which issue this PR fixes

fixes #24

Checklist

[x] Chart Version bumped


Add Sumana Harihareswara

Hi. I'm a woman of color and I'd be honored if you could add me to this list. Thank you.

We're honored to have you on the list 😄.  Thank you!


chore(maintenance): Add GitPod.io support for external contributions

Issue number: #1361
Summary
Added GitPod.io support for external contributions to make creating a development environment easier
Changes

Please provide a summary of what's being changed

Added integration with Gitpod.io and through the badge/link in README.md it will be very simple for any contributor to configure a new environment

User experience

Please share what the user experience looks like before and after this change

Before: any contributor had to clone the project, install dependencies, and set up an environment in order to start development. This generates an overhead for new people who want to contribute to the project, as even a small fix required setting up a full new environment.
After: any contributor just needs to create an environment on Gitpod using the fork URL and everything will be set up.
Checklist
If your change doesn't seem to apply, please leave them unchecked.

[x] Meet tenets criteria
[x] I have performed a self-review of this change
[x] Changes have been tested
[x] Changes are documented
[x] PR title follows conventional commit semantics

Is this a breaking change?
RFC issue number:
Checklist:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

View rendered CONTRIBUTING.md
View rendered README.md

Thank you! I believe Heitor will have some comments about wording, but otherwise this is nice :) Looking forward for more!

Thank you @rubenfonseca. It will be really cool to be able to contribute more to this project that I started as a user. :1st_place_medal:

Thank you so much @leandrodamascena for taking it this far (and addressing all feedbacks). Merging!

Thank you so much @leandrodamascena for taking it this far (and addressing all feedbacks). Merging!

Thanks also @heitorlessa  for insights and helping me make this PR even better. :airplane:


Whitelist in CSP policy

Hello!
When using script-src 'self' "Content-Security-Policy" ai.0.js file loaded via sdk is blocked by the browser, which is expected.
What would be the correct setting to whitelist it? Which part of the url is dynamic and very likely to change over time https://az416426.vo.msecnd.net/scripts/a/ai.0.js ?
Thanks!

Looks like it's making calls to https://dc.services.visualstudio.com/v2/track. Might need to whitelist as well.
A section in the docs would be very appreciated. Thanks!

You are correct; both are constant and can be whitelisted as is.


New name?

Let's make a thread here with options for new names that we can vote on.
My proposal is have a separate comment for each proposed name and anyone can vote on as many names as they want by reacting to the comments. We can have both a "full" official name and a a shorthand used as the base command. The comment proposing a name can also have a few short sentences stating why they think it's good.
For example, for the current name:
Full: world-edit (or world-edit-scarpet?)
Command: /world_edit
Features: Clashes and creates confusion with the actual world-edit mod/plugin. It's also long to write when using commands.
Upvote this comment if you'd like to keep the current name.

Full: world-edit
Command: /we
Features: Easier to type; we don't need to change a bunch of thext in the app to accomodate for the new name, just suggested commands.

Full: world-edit
Command: /we
Features: Easier to type; we don't need to change a bunch of thext in the app to accomodate for the new name, just suggested commands.

Full: scarpet-edit
Command: /se
Features: Really easy to type too; play on the name of other world-edit type stuff (world edit, bling edit, prolly some others)

Full: scarpet-edit
Command: /se
Features: Really easy to type too; play on the name of other world-edit type stuff (world edit, bling edit, prolly some others)

Full: paint-app
Command: /pa
Features: Some may argue it's harder to type, because it's two hands, some may argue its easier, for the same reason. Name is a bit lame, tho.

Full: paint-app
Command: /pa
Features: Some may argue it's harder to type, because it's two hands, some may argue its easier, for the same reason. Name is a bit lame, tho.

Full: worldoshop
Command: /ws
Features: idk, gnembon proposed it a while back. Command is still good in qwerty keyboards.

Full: worldoshop
Command: /ws
Features: idk, gnembon proposed it a while back. Command is still good in qwerty keyboards.

I think Github Discussions (if available for this repo, not sure if there are requirements) would be better suited for this issue, since it basically makes a "thread" for each base reply, so each of the options could be discussed on its own.

I think Github Discussions (if available for this repo, not sure if there are requirements) would be better suited for this issue, since it basically makes a "thread" for each base reply, so each of the options could be discussed on its own.

Yes, that's a good idea; I wasn't aware of that feature.
I don't think the hyphen is necessary, no, in particular since that name will only appear in some text in chat like help menu, and in the documentation. We can choose if we want a hyphen, two words or PascalCase it.

Yes, that's a good idea; I wasn't aware of that feature.
I don't think the hyphen is necessary, no, in particular since that name will only appear in some text in chat like help menu, and in the documentation. We can choose if we want a hyphen, two words or PascalCase it.

yo @Firigion you can move the suggestions to #47 (a discussion) and close this.

yo @Firigion you can move the suggestions to #47 (a discussion) and close this.


fix: remove top-level await to prevent rollup failure

Can you describe the problem?

https://github.com/neondatabase/neonctl/actions/runs/10079958146/job/27868540553

the rollup build wouldn't parse the source file as a commonjs module if there is a top-level await :(


Popup inside iframe, avoid scroll of outer page

This is my situation:

the html page contains an iframe
inside the iframe there are some images, and the popup are plugged on these images
the iframe has an high height, le'ts say 1000px, without a scroll (it occupies the entire page). Boefore the iframe there is other 1000px of content

The problem is that if I click on an image inside the iframe, and the property css 'top' of the iframe isn't 0 (e.g. the iframe starts in the middle of visible page, it doesn't start from the top of visible page), the page containing the iframe scrolls down , such that the 'top' css property of the iframe becomes 0.
The code for putting the popup on is:
$('.image-popup').magnificPopup({
                                    type: 'image',
                                    closeOnContentClick: true,
                                    mainClass: 'mfp-img-mobile',
                                    image: {
                                        verticalFit: true
                                    },
                                    callbacks: {
                                        open: function() {
                                            var magnificPopup = $.magnificPopup.instance;

                                            var iframe = $(".iframe", parent.document.body).first();
                                            var iframeTop = iframe.offset().top
                                            var scrollTop = $(parent.document.body).scrollTop()
                                            var mytop = (scrollTop + 200) - iframeTop

                                            var el
                                            el = magnificPopup.content
                                            el.css('position', 'fixed')
                                            el.css('top', mytop)
                                        },
                                        close: function() {
                                            // Will fire when popup is closed
                                        },
                                        elementParse: function(item) {
                                            item.el.css('width', 100)
                                         }
                                    }

                                });
                            })

I want to avoid that the outer page scrolls down.

fixedContentPos: true

Changing Both from auto to true worked for me. Thanks
fixedContentPos: "true",
fixedBgPos: "true",


Native python plugins are not shown as busy (red) during execution

When running a longer computation with a native python plugin running on a Jupyter notebook, the plugin name does not turn red to indicate execution but remains blue.
Code snippet
from imjoy import api
import time

class ImJoyPlugin():
    def setup(self):
        api.log('initialized')

    def run(self, ctx):
        time.sleep(5)
        api.alert('I feel rested.')

Hi, thanks for the report, I can reproduce this bug. I think it may related to some changes when we move engines to plugins.


Allow to style ::-ms-reveal for the input of md-outlined-text-field

Description
Currently we have implemented our own password reveal icon using md-outlined-text-field along with md-icon-button.
Microsoft edge however adds it's own reveal icon as mentioned in https://learn.microsoft.com/en-us/microsoft-edge/web-platform/password-reveal
This is how it looks on edge

To remove this , it mentions to add
::-ms-reveal {
    display: none;
}

However, I cannot add this style to the input since the input is within the component
Do we have any way to add this style which I did not realize? If not, can we add this feature to add this style somehow?

We can add a display: none style for ::-ms-reveal in this section of text field's styles, where we turn off some other built-in <input> ui elements.
Do you mind creating a PR to update that?

Shouldn't that be an optional toggle? Some of us actually prefer using the browser's controls...

The built-in icon doesn't match Material, and our text field has a spot for Material icons to be added to it.

Created a PR to fix this.


Update hashbrown to 0.14

As the MSRV of metrics-util now is 1.65 we can now update to hashbrown version 0.14 (which has MSRV 1.63).

Thanks for your contribution!

Released as part of<EMAIL_ADDRESS>


⚠ SceneTime has degraded performance

In 12e09fe, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1499 ms

Resolved: SceneTime performance has improved in f423dd0 after 7 minutes.


For mainnet

Todo

[ ] https://github.com/blockstack/explorer/issues/234
[ ] https://github.com/blockstack/explorer/issues/255
[x] https://github.com/blockstack/explorer/issues/256
[ ] https://github.com/blockstack/explorer/issues/257
[ ] https://github.com/blockstack/explorer/issues/258
[ ] https://github.com/blockstack/explorer/issues/261
[ ] https://github.com/blockstack/explorer/issues/262
[x] https://github.com/blockstack/explorer/issues/224

Needs more research/design

https://github.com/blockstack/explorer/issues/244
https://github.com/blockstack/explorer/issues/228
https://github.com/blockstack/explorer/issues/227

@aulneau- did we complete all of the above?

@aulneau- did we complete all of the above?


Use the default ServiceAccount when creating NMC

Using default instead of an empty string allows us to attach all pull secrets configured for that account when setting up the mounts for the worker Pod.
/cc @yevgeny-shnaidman

/lgtm

/hold

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.01% :tada:

Comparison is base (f0cb9a0) 79.63% compared to head (84f16a3) 79.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #551      +/-   ##
==========================================
+ Coverage   79.63%   79.65%   +0.01%
==========================================
  Files          43       43
  Lines        4316     4320       +4
==========================================
+ Hits         3437     3441       +4
  Misses        721      721
  Partials      158      158

Files Changed
Coverage Δ

internal/controllers/nmc_reconciler.go
73.60% <ø> (ø)

internal/nmc/helper.go
96.84% <100.00%> (+0.13%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

/unhold

/lgtm


nodejs: 10.21.0 -> 10.22.0, 12.18.2 -> 12.18.3, 14.5.0 -> 14.6.0

Motivation for this change
https://github.com/nodejs/node/releases/tag/v10.22.0
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

This conflicts with https://github.com/NixOS/nixpkgs/pull/93482 when merging staging-next into staging.


State does not get pushed when URL is the same as window.location

I'm having a problem with the window.popstate event not getting triggered if pushing OR replacing the state has the same URL as the window's. For example, if the current URL in the browser window is http://example.com/foobar, then
History.pushState(null, "foobar title", "/foobar");
History.replaceState(null, "foobar title", "/foobar");

will not trigger
$(window).bind('statechange', function() {
  console.log("I do not get triggered!");
});

Google Chrome 15.0.874.121, Firefox 7.0.1

What a strange coincidence. I was about to post that :D
Yeah I also need statechange to trigger when clicking on the same page (I basically need to refresh the page when a user clicks link to the page he is already on).

Ah hahaha!
Well I found a temporary workaround and it seems to be working okay.
History.pushState(null, "foobar title", "/foobar");
$(window).trigger('statechange')

=p

@Axsuul, check above :) Perfect timing :D

@pokonski Wow perfect timing indeed!

Actually this workaround is not suitable because
$(window).trigger('statechange')

will not be able to access the History.stateData() that was pushed

I actually changed that since my comment to:
History.pushState({timestamp: (new Date().getTime())},title,url);

So state get's pushed even when url is the same.


Combat Tracker

Hi, I don't know if this is me being really dumb or not, but in the v10 version of the system, pressing the "start combat" button in the combat tracker does nothing. The participating combatants are added to the tracker perfectly fine, and the system does a great job of ordering them according to speed and dexterity, but the actual combat refuses to begin for some reason. Maybe its me being dumb, which if it is, let me know so I can get it working. Thanks.

Can confirm.

I can also confirm. Just tried it tonight.

Sorry just now saw this! It should be fixed now. Try updating to the latest release :)

I just did, and it works! Thanks a lot for the fix, its really helpful because my players sometime argue what turn we're on for the sake of recovery, haha. Great work, and much appreciated!


header: Do not panic on data root mismatch on unmarshal

As the fields are public, if a full node or light node is sent an ExtendedHeader with mismatched Row/Col roots that don't compute to the DataRoot, the node will panic.
We should do a severe WARN log and ban the peer instead.

Supposed to be fixed by https://github.com/celestiaorg/celestia-node/pull/2220

@Wondertan I'm working on a fix right now that implements a custom error - bridge nodes should panic as they receive blocks from a "trusted" source.
Change is almost the same as yours, would you be ok rebasing on it?

I don't mind rebasing, if you want to move the panic from Validate to CoreListener

Yes pls :)

https://github.com/celestiaorg/celestia-node/pull/2558/files


⚠ Fortnite has degraded performance

In 47a7390, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1618 ms

Resolved: Fortnite performance has improved in f244776.


Fixed some issues with handedness declarations.

Overview
Values were wrong, and added Both enum.

Should work fine in dropdowns


Fixed import dataset and basemaps modal texts and footer elements

Fixes #8987

CR @matallo

@matallo, take a look and if you feel confident merge it too pretty please 🙏 , @MariaCheca doesn't work today.

ping @matallo review it please

taking a look now

LGTM!

✨


Incorrect regex in v0.2.2

@SlexAxton You might use incorrect regex and it fails in IE8:
https://github.com/SlexAxton/messageformat.js/blob/0.2.2/messageformat.js#L49
Should it be .match(/{[\^]*}/) or .match(/{.*}/) or .match(/{.+}/) ? Please fix this bug as soon as possible, thanks!

Closing this due to finally releasing 0.3.0, which loads locales differently. Also, we have a new website at messageformat.github.io.

@theking-laptop @eemeli  For those of us who are locked in to v0.2.2 what is the correct regex?

I think this should work... Any thoughts?

That won't match newlines. The original expression /{[^]*}/ tries to match all characters within braces, which .* actually doesn't do. Try /{[\s\S]*}/ instead.

Looks good, thanks!


Will this work with GraphQL?

Not tested, let me look into this.

It is working fine with GraphQL.


feat: add erc7779 support

https://github.com/ethereum/ERCs/pull/663/files

added naive onRedelegation() implementation also

think this looks good to go now - wdyt @filmakarov


Update http(s).get and http(s).request libdefs

Closes: https://github.com/facebook/flow/issues/7603
See:

https://nodejs.org/api/http.html#http_http_get_url_options_callback
https://nodejs.org/api/http.html#http_http_request_url_options_callback
https://nodejs.org/api/https.html#https_https_get_url_options_callback
https://nodejs.org/api/https.html#https_https_request_url_options_callback

Sorry it took a bit to get to this, it looks good. Is it possible though to get a more precise type for options than just Object (which is unsafe and generally should be avoided)?

@mvitousek Sure, will do. I was just extending what was already there a little bit. I'll let you know when it's ready to be checked again. :)

@mvitousek Updated and rebased. There are two things I am unsure about:

http$requestOptions and https$requestOptions are very similar with some small changes for HTTS - not sure if this is the best way how to do it. I would appreciate some guidance here if not.
I noticed that createConnection methods  in http(s) Agent are not compatible. I didn't touch this part at all in this PR but should probably be fixed. It's kind of related because there is also createConnection property in the request options I created.

Please, have a look and let me know what to improve.

Looks really good, thank you for taking this on! Made one suggestion, and since the request object is different only in its default values (which aren't visible by the caller), could you just use the same object for both?
Would you mind filing an issue regarding the createConnection definition?

... since the request object is different only in its default values (which aren't visible by the caller), could you just use the same object for both?

I tried to follow the differences between  HTTP and HTTPS module so there are additional differences in http$Agent<net$Socket> vs. http$Agent<tls$TLSSocket> and similar for return type of createConnection. Should it really be the same?

Oops great catch, thank you. What I would do then--when most attributes are the same, but some are different--is to put the attributes in common in a single type, and then use spreading to copy those attributes into distinct types that also capture the differences. See here for an example:
https://flow.org/try/#0C4TwDgpgBMULxQN4B8oEMBcUB2BXAtgEYQBOUyAvlAPTVQDKYJEaAJgJbYDmUA7gPYkA1gGcoxEbF7tgACygQAHmgDGsfoQBWENTHAQRAKFCR08JADorwADTiskkpx4Vj+8ecRWLt+zgLEZK6GrDoANmjMUABukVCKWGgA3IaxZNhYeESk5ooWyalxIg7ATty5FoRJQA
That said, if you'd prefer to not go down this route I'm happy to merge this as-is, as long as it passes all our tests.

@mvitousek Updated. Please have a look.

@mvitousek Hi, is there anything I can do to make it mergeable? :)

Hi @mrtnzlml, sorry for taking so long to finish this! The PR is landing right now :) Thanks a lot for your work on this PR, it's a great contribution and we appreciate it.


[#1366] Properly pass on query modifiers for count queries in Queryds…

…l integration

Description

Related Issue

Motivation and Context

Integrated, thanks!


caffe2 can't import caffe2.python.core

I want to import caffe2.python.core.
But, result are
import caffe2.python.core
WARNING:root:This caffe2 python run does not have GPU support. Will run in CPU only mode.
WARNING:root:Debug message: /usr/local/lib/libcaffe2.so: undefined symbol: _ZN6google4base21CheckOpMessageBuilder9NewStringB5cxx11Ev
segmentation fault (core dumped)
And, python exits...
Anyone know about this error?
please help me.
environment

python 2.7(Anaconda2)
GCC 7.2.0

Yes I solve it.
I just reinstall and recompile.
-----Original Message-----
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Sent: 2018-04-23 (월) 23:24:52
Subject: Re: [caffe2/caffe2] caffe2 can't import caffe2.python.core (#1683)
do you solve the problem ？i meet the same issue
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Can you be more explicit about what you did to solve your problem ? I'm encountering the same issue. I tried to remove and reinstall Caffe2 with gpu support for Cuda 9 from built-in libraries but it doesn't work.

I just reinstalled caffe2 and changed python path.
And, my cuda version was 8. and cudnn version was 5.1.
-----Original Message-----
From: "Mounir<EMAIL_ADDRESS>To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Sent: 2018-05-30 (수) 20:41:53
Subject: Re: [caffe2/caffe2] caffe2 can't import caffe2.python.core (#1683)
Can you be more explicit about what you did to solve your problem ? I'm encountering the same issue. I tried to remove and reinstall Caffe2 with gpu support for Cuda 9 from built-in libraries but it doesn't work.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Using isPrint() instead of isLetterOrNumber() to check if a key is di…

…splayed in the widget
This will correct the record event bug in the DelimitedTextReader in paraview.

@utkarshayachit

@mwestphal Mind changing the commit log to follow the standard line length practices e.g. http://chris.beams.io/posts/git-commit/
It's a little hard to read the way it is currently. Otherwise looks okay.

done


Bug in Greetings Workflow .yml file

Describe the bug
Error found in yaml for greetings.yml
https://github.com/Call-for-Code-for-Racial-Justice/Truth-Loop/blob/main/.github/workflows/greetings.yml
To Reproduce
Expected behavior
See line 9 here for what it should be (note the space) https://github.com/Call-for-Code-for-Racial-Justice/Truth-Loop/blob/main/.github/workflows/greetings.yml
Screenshots
line 9 is missing the appropriate indentation and space.

Proposed a fix in https://github.com/Call-for-Code-for-Racial-Justice/Truth-Loop/pull/216