Batch Exclude Reportbacks to Clear Campaign Inboxes

FEATURE OVERVIEW
User Story
As a campaign lead, I want all fids on the nodes listed below with a quantity under x to be marked as excluded before Thursday of this week.
Additional Information (optional)
Campaign (Node ID) // Threshold for Exclusion
#SuperStressFace (2710) // coming soon
Notes from Shawn (2805) // coming soon
Shower Songs (3590) // coming soon
Trash Scavenger Hunt (2929) // coming soon
Why This Matters
The campaigns team doesn't have the bandwidth to clear out these inboxes. The most pressing concern is that Shower Songs is reopening in May and the inbox needs to be cleared before it launches again -- currently there are approx. 11,800 images that need to be reviewed.
Order of Operations

[ ] Nami provides impact threshold for four campaigns + verifies with campaign leads
[ ] Chloe writes code
[ ] Chloe and Nami test code on Thor
[ ] Ask Sena to backup production
[ ] Deploy to production and confirm!

cc @angaither @mikefantini

@chloealee this should be a php script or custom drush command, instead of an update hook so we can pass in params (nid, run_nid, and quantity) to know which rbs we want to bulk exclude and run it X times (instead of having one update hook per campaign)

thanks @angaither, makes sense! I'm following a tutorial right now to create a custom drush command - does it make sense to put this custom drush command in dosomething_reportback.drush.inc or to create a new drush command file separate for the job of batch excluding?

@chloealee you can put it in the existing file

@angaither quick q! If I put this in dosomething_reportback.drush.inc, would I have to implement a new hook_drush_command that describes my new custom command (with arguments) in order to run it?

@chloealee no, you can add it to the array that's returned here

oh cool, thanks @angaither !


Feat: validator schema to atomWithFormControls

[ ] Zod

[x]  basic implementation
[ ]  type inference hacks
[ ]  Mixed and Object schema forms ( might need to a little more thinking through)

[ ] Yup

[x]  basic implementation
[ ]  type inference hacks
[ ]  Mixed and Object schema forms ( might need to a little more thinking through)

closes: https://github.com/jotaijs/jotai-form/issues/25

@dai-shi review of the initial idea and implementation please


Fix some typos and broken links

I went through the page (nice job btw:)) and added some corrections.
(Please check that the file renaming one doesn't break anything else.)

Thank you for the spell check and broken links.

You're welcome:)


Readonly Service Object doesn't Validate at Compile time

Description:
Consider the following record:
public type GraphqlServiceConfig record {|
    readonly readonly & Interceptor[] interceptors = [];
|};

public type Interceptor distinct service object {
    isolated remote function execute(Context context, Field 'field) returns anydata|error;
};

GraphQL module uses a similar record as the GraphQL ServiceConfig. But, when passing an invalid value into interceptors field, It's not validated at the compile time. Consider the following GraphQL service.
readonly service class PersonInterceptor {
}

@graphql:ServiceConfig {
    interceptors: [new PersonInterceptor()]
}
service /graphql on new graphql:Listener(9000) {
    isolated resource function get name() returns string {
        return "Ballerina";
    }
}

Since PersonInterceptor is an invalid value, ideally this should be invalidated at compile time. But currently, it returns the following error at runtime.
Compiling source
        interceptors_with_records.bal

Running executable

error: {ballerina/lang.array}InherentTypeViolation {"message":"incompatible types: expected '(graphql:Interceptor & readonly)', found 'PersonInterceptor'"}
        at interceptors_with_records:$annot_func$_0(interceptors_with_records.bal:12)

Affected Versions:
2201.2.0

Seems to happen when the target type is from another module.


[Firmware] Delete template with associated firmware

When the template with associated firmware is removed, the image associated with that template is not removed.

template is removed:

device-manager_1              | [15/07/19 - 13:37:00] |TemplateHandler| INFO: Removing template with id: 15

the image associated with that template is not removed:

curl -X GET {{HOST}}:8000/fw-image/image/f101077e-27a8-469d-81fe-0fb4ed38cb17 -H "Authorization: Bearer ${JWT}" -H 'Content-Type:application/json'
{
    "confirmed": true,
    "created": "2019-07-15T13:29:46.526976+00:00",
    "fw_version": "FW 1.0",
    "id": "f101077e-27a8-469d-81fe-0fb4ed38cb17",
    "label": "15",
    "updated": "2019-07-15T13:29:46.704187+00:00"
}

Affected version: 63.1-20190705

It will be retested.

Still happens in v0.5.0-alpha.2.

template is removed:

[22/07/20 - 20:53:23] |TemplateHandler| INFO: Removing template with id: 1

the image associated with that template is not removed:

curl -X GET <IP_ADDRESS>/fw-image/image -H "Authorization: Bearer ${JWT}" -H 'Content-Type:application/json'
[
  {
    "confirmed": true,
    "created": "2020-07-22T20:45:58.175475+00:00",
    "fw_version": "FW 1.0",
    "id": "f5162c66-459e-4bdb-8a61-623d45a79765",
    "label": "1",
    "updated": "2020-07-22T20:45:58.523212+00:00"
  }
]


The 'overwriteRemotePolicyUrl' configuration is not working

I just took a quick peek into how Api URL overwriting is implemented here, in context of admission controller, and based on the code I see it won't work.
There is const with default URL defined (pointing to dev instance):
https://github.com/kubeshop/vscode-monokle/blob/924c8b68e9b6d31a51cda2924e3509f5ed7d7eb7/src/constants.ts#L9
And then there is global getter using it and overwrite config:
https://github.com/kubeshop/vscode-monokle/blob/924c8b68e9b6d31a51cda2924e3509f5ed7d7eb7/src/utils/globals.ts#L30-L32
The problem is (and the fact that it works now well, querying production Monokle Cloud) is that it is not propagated, and extension uses default synchronizer:
https://github.com/kubeshop/vscode-monokle/blob/924c8b68e9b6d31a51cda2924e3509f5ed7d7eb7/src/utils/synchronization.ts#L24-L25
Which in turn has it's own defaults (pointing to production instance), through ApiHandler util:

https://github.com/kubeshop/monokle-core/blob/main/packages/synchronizer/src/createDefaultMonokleSynchronizer.ts
https://github.com/kubeshop/monokle-core/blob/1df8a27699344b9c2ea12a81461019e8ec6369f0/packages/synchronizer/src/handlers/apiHandler.ts#L159
https://github.com/kubeshop/monokle-core/blob/1df8a27699344b9c2ea12a81461019e8ec6369f0/packages/synchronizer/src/constants.ts#L4

To fix this, remoteUrl getter should just return overwrites:
get remotePolicyUrl() {
  return process.env.MONOKLE_TEST_SERVER_URL ?? this.overwriteRemotePolicyUrl;
}

and pass a result to synchronizer initialization (to ApiHandler instance) - if empty string is passed it will still use default production API, if overwrite (or test env var) is used it will use this new URL.

This needs to be reworked to origin similarly as done in CLI in https://github.com/kubeshop/monokle-cli/issues/23.


add Lombok dependency  to pom.xml

Issue: Add Lombok Dependency and Refactor JobPost Class
Feature Overview:
We need to simplify the JobPost class by reducing boilerplate code using the Lombok library. Lombok will auto-generate common methods like getters, setters, constructors, etc. This will streamline the code and enhance maintainability.
Implementation Details:
Add Lombok Dependency:
Update the pom.xml to include the Lombok dependency

I have used Lombok in previous projects. I can contribute in solving this issue


Allow rotation of non-admin config tokens

Related to #68
We have the need to use a non-admin service account PAT, but we cannot have it expiring. We would like to use the "rotation API" or at a minimum, the "user" API for creating an access token. We could have an option to use rotation API or maybe we could use it, by default, if the version is over the version where rotation API was added.

We have also encountered this issue when trying to rotate tokens in GitLab Cloud, any chance the MR can be progressed? it would be greatly appreciated

@cm3brian I've been busy adding tests against real Gitlab instance, as soon as I'm finished with that you'll have that functionality as well. Hopefully this will land in the next couple of weeks.

@ilijamt thank you so much for your efforts and moving this along. Both the progress on this and the plugin over all are greatly appreciated from our side!

Would you guys be willing to test it out? Here is the MR #97

@cm3brian @TJM I tried with a normal user on gitlab.com, and now you are able to rotate the tokens (also added some tests for this as well). Instead of creating a separate one, I just made it all rotation of the main token use their own endpoint for it. So no need to have two code paths.

Released with the new version v0.4.0

Thanks @ilijamt !! Sorry, my gitlab emails were going to the wrong place and I didn't see these.

@TJM is it all good now?


Update URLUtils.ts

Change service to entity as this is the new correct link.
Change description

Description here

Type of change

[ ] Bug fix (fixes an issue)
[ ] New feature (adds functionality)
[ ] Improvement (improves codebase without changing functionality)

Related issues

Fix #1

Checklists
Development

[ ] Lint rules pass locally
[ ] Application changes have been tested thoroughly
[ ] Automated tests covering modified code pass

Security

[ ] Security impact of change has been considered
[ ] Code follows company security practices and guidelines

Code review

[ ] Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
[ ] "Ready for review" label attached and reviewers assigned
[ ] Changes have been reviewed by at least one other contributor
[ ] Pull request linked to task tracker where applicable

Yup just update this line to 1.7.3 https://github.com/cortexapps/backstage-plugin/blob/04716eb37e30dc798ce6a6cdf84107c1ab459c77/package.json#L3


Reduce boilerplate

Instead of changing the API #484, let's approach and try to come up with a solution for the boilerplate problem within the current architecture.
Importing/Exporting modules
// ABC.js
import { B } from "./B"
import { C } from "./C"

export const state = {
  value: 0,
  B: B.state,
  C: C.state
}
export const actions = {
  add: value => state => ({ value: state.value + value }),
  B: B.actions,
  C: C.actions
}

Setup
import  { A } from "./A"
import  { B } from "./B"
import  { C } from "./C"

app({
  state: {
    A: A.state,
    B: B.state,
    C: C.state
  },
  actions: {
    A: A.actions,
    B: B.actions,
    C: C.actions
  }
})

Props
const view = state => actions => (
  <App>
    <Feed state={state.feed} actions={actions.feed} />
    <Trend state={state.trend} actions={actions.trend} />
  </App>
)

// OR

const view = state => actions => (
  <App>
    <Feed
      model={{
        ...state.feed,
        ...actions.feed
      }}
    />
    <Trend
      model={{
        ...state.trend,
        ...actions.trend
      }}
    />
  </App>
)

@lukejacksonn @SkaterDad @okwolf @zaceno @Alber70g

@lukejacksonn @SkaterDad @okwolf @zaceno @Alber70g

A possible way to reduce boilerplate when composing modules/models, while still keeping state and action separate, could be to introduce an action that returns the initial state:
// ABC.js
import { B } from "./B"
import { C } from "./C"

export const actions = {
  getInitialState: () => ({ value: 0 })
  add: value => state => ({ value: state.value + value }),
  B: B.actions,
  C: C.actions
}

import  { A } from "./A"
import  { B } from "./B"
import  { C } from "./C"

app({
  actions: {
    A: A.actions,
    B: B.actions,
    C: C.actions
  }
})

The getInitialState() action would be executed automatically by app(), it could also be renamed getState() init() or simply state().
This action could also be used to subscribe to outside events (like init()/subscribe() was meant to).
Not sure this is a good idea, let's see what you guys think.

@JorgeBucaran would it be possible to provide actions with the 'unmerged' state and the view with the model?

@Alber70g the key question here is how strongly do we feel about keeping the API consistent and simple by minimizing the number of concepts new users need to learn.

@whaaaley and I came up with an improvement to the current API without need to merge state & actions, but making it easier to reduce boilerplate.
It consists of extracting the view from the props argument to app.
app(props, view, container)

Props is the state and actions, same API as 0.16.2. While we are at it, I find it more logical to call it model, instead of props, so I'll do just that.
const model = {
  state: {
    count: 0
  },
  actions: {
    down: () => state => ({ count: model.count - 1 }),
    up: () => state => ({ count: model.count + 1 })
  }
}

const view = state => actions => (

{model.count}

    <button onclick={model.down}>-</button>
    <button onclick={model.up}>+</button>

)

app(model, view)

So almost nothing changes, but the advantage of this approach is that it makes it now easier to merge multiple models.
app(
  combine({ A, B, C, D }),
  view,
  document.getElementById("root")
)

or
app(
  {
    ...model,
    ...combine({ A, B, C, D })
  },
  view,
  document.getElementById("root")
)

Of course you need to write that custom combine function, but surely this can be pushed to userland.

imperative

const combine = models => {
  var out = {state:{},actions:{}}
  for (var key in models) {
    out.state[key] = models[key].state
    out.actions[key] = models[key].actions
  }
  return out
}

functional

const combine = models =>
  Object.keys(models).reduce(
    (obj, key) => ({
      ...obj,
      ...{
        state: {
          ...obj.state,
          ...{ [key]: models[key].state }
        },
        actions: {
          ...obj.actions,
          ...{ [key]: models[key].actions }
        }
      }
    }),
    {}
  )

Looks good but it would also make sense to change the view-signature while were at it:
app({state, actions}, ({state, actions}) => h(....))

Symmetrical to the conventional signature of components, and IMO nicer and less confusing to newcomers than state => actions => h(...)

@zaceno I am okay with either one (state, actions) or ({ state, actions }).

@Alber70g @lukejacksonn @okwolf @whaaaley What do you think? :)

Symmetrical to the conventional signature of components...

Good point though! 🤔😆

This is definitely a nice incremental improvement!
I'm voting for changing the view signature also.  Dont really care which of the 2 proposed solutions, they're both nicer.

fwiw, I been talking to @whaaaley and I like this approach.  For the view signature I would prefer (state, actions) but dont care too much.

I like this proposal even more (as opposed to the previous) because it keeps the state and actions separated while at the same time it allows actions and state on slices to be more explicit entangled.
It also allows to have actions still return only state instead of state and actions.
The only thing I feel is kind of obsolete is the initial state. Right now we export the state as a part of the model that can be combined by the combine-function.
This doesn't have to be this way if we, like Redux does, call all init- actions first. The init action can return it's default state. This also removes a part of the cognitive load of thinking about initial-state, actions and the 'current' state in actions, as a saparate thing.
My proposal would be to drop the state drop the initial app-call as a whole and provide a lifecycle hook which calls each function named init() in the actions object. Starting from root and traversing trough the slices/props.

@Alber70g I don't follow, what's obsolete?

My proposal would be to drop the state drop the initial app-call as a whole and provide a lifecycle hook which calls each function named init() in the actions object. Starting from root and traversing trough the slices/props.

What would be the benefit of adding something like this potentially adding a lot more bytes to hyperapp?

I'm not really a fan of that idea. Being able to define the initial state before Hyperapp starts is really nice, in my opinion, and doesn't introduce special framework specific actions.

I think this is Hyperapp's final API.
const model = {
  state: {
    count: 0
  },
  actions: {
    down: () => state => ({ count: state.count - 1 }),
    up: () => state => ({ count: state.count + 1 }),
    /* actionName: data => (state, actions) => State */
  }
}

const view = ({ state, actions }) => (

{state.count}

    <button onclick={actions.down}>-</button>
    <button onclick={actions.up}>+</button>

)

export const App = app(model, view) // => { state, actions }

Looks good.  Is the root element a 3rd parameter missing from the example?

@SkaterDad Done.
Hmm, should we make it non optional? 🤔🤯

I think it's nice that its optional currently, but I'm not that opinionated on it.

@SkaterDad I feel the same way, but maybe this can somehow be connected with #491.

@JorgeBucaran well, now that you have a feeling we should just ship 1.0 immediately 😂

The optionated root element make some troubles in some case.
This is not a secret now, I use Hyperapp to build web component, using the custom
element compliance <hyperapp-custom-element/>.
Using the new API, it will be something like :
document.querySelectorAll('hyperapp-custom-element).map(element => {
  app(model, view, element)
})

In the case of there is no <hyperapp-custom-element/>, nothing will occur (the array is empty, no map iteration is called).
But if I am only doing the following :
app(model, view, document.querySelector('#app'))

And no #app exist in the dom, the whole body will be replaced by the app.
tl;dr
I use a custom root element, because the app is located somewhere in a landing page, if I remove the element from the html body, I want the app do not load not to replace the whole body.

I prefer the proposed view signature of ({state, actions}). The current (0.16.2) approach of double fat arrows state => actions => h() to me implies/suggests that there is an opportunity for currying, but that is not really the case.

@Alber70g I like your way of thinking! We're on the same page as far as "only actions should make state". The caveat here is that you need a way to load in old state. Having a top-level state prop in app() lets us load in initial state from local storage or some other place.

I am very happy with the result and feel this can be closed.

@whaaaley you can still do:
const appActions app(state, {init: payload => ({ ...payload }) }, view);
appActions.init(storage.getItem('myState'));

If I'm not mistaken and the render function has a setTimeout()/is put on the callback queue, this wont even pose a render performance hit. Therefore you don't need to set the initial state as property of app.

@JorgeBucaran
It might be good to add a code example where different slices are exported as models and combined by the combine function?

My favourite bit about the models proposal was the way it made passing stuff down the view much easier.. and that when you called stuff it was by namespace.value not (state|actions).namespace.value. But yes.. you could write a custom combine function that turns almost any data structure into what hyperapp accepts.

@lukejacksonn My favourite bit about the models proposal was the way it made passing stuff down the view much easier.. and that when you called stuff it was by namespace.value not (state|actions).namespace.value.

My favorite bit as well. Almost like a class.


include p values at peak level for get_clusters_table function

Hello everyone,
I was looking to recover the p values at peak level and tried the get_cluster_table function.
However, if cluster ID, localization, Z score peak and cluster size are reported, I can't found the associated p values.
Because Nistats generates this table based on the input threshold, I am pretty sure this p value at peak level is already computed to discriminate if H0 is accepted or rejected, so I was wondering if you could add a columm to write it?
Many thanks,
Jordy T

@kchawla-pi this relates to #307


Build without a Mac for the P12

Hi,
It took a while but we figured out there is a way of setting up a build WITHOUT a mac.  The steps in this document require one for obtaining CSR and P12.
I posted the solution here: https://stackoverflow.com/questions/9418661/how-to-create-p12-certificate-for-ios-distribution/64771489#64771489
Please consider adding this as an alternative route, it will save people hours!
Thanks, Matt

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c01f1809-2316-7d47-1547-23775f6dd618
Version Independent ID: 7d719380-4d1d-e995-e0e5-b2474ae5e9af
Content: iOS Code Signing in App Center - Visual Studio App Center
Content Source: docs/build/ios/code-signing.md
Service: vs-appcenter
Sub-service: app-center-build
GitHub Login: @King-of-Spades
Microsoft Alias: kegr

Building for iOS without a Mac isn't a supported scenario. So even if it's possible consistently, it's not in scope for us to document.


[ParallelInstaller] Allow installing with corrupted lockfiles

[x] Specs

This looks good to me! :+1:

@indirect except it's not actually a bug with the old bundler but rather with rubygems.org...

That changed eating also means we can't print which gem has the dependencies causing the problems.

@segiddins I didn't say "an old Bundler that had a bug", I said "an old Bundler that left some things out". I didn't also include "because of a bug in RubyGems.org" because that doesn't make anything about the problem clearer.
Moving the warning up into the check so we can keep the context is fine, just merge the warnings into one place. 😛

Does this look like a good warning?
Your lockfile was created by an old Bundler that left some things out.
Because of the missing DEPENDENCIES, we can only install gems one at a time, instead of installing 9 at a time.
You can fix this by adding the missing gems to your Gemfile, running bundle install, and then removing the gems from your Gemfile.
The missing gems are:
* archive-tar-minitar, hoe, rcov depended upon by mime-types

This looks great.

@bundlerbot r+

Thank you @segiddins 💝 🎉


Add an URL inputType

Add an URL inputType so there is no need to do some code "trick" and encoding.

This works now.


Memory Leak: performCleanupOnOldImages

Hello!
I'm developing an app with your SDK and I've just noticed using Instruments a big memory leak in the next method:

I only call the getImojiCategoriesWithClassification(.Generic) or getImojiCategoriesWithClassification(.Trending). I commented the line of the method who calls performCleanupOnOldImages and (obviously) the memory leaks have disappeared.
any idea how to solve this huge memory leak?
thanks in advance

Hi @MoralAlberto, we've since removed the manual caching of images in f0f0e6b in favor of NSURLCache. The latest version removes IMMutableImojiSessionStoragePolicy entirely.
Upgrading for you should be quite straightforward. The only notable change is the signature to IMImojiSessionResultSetResponseCallback that'll require small updates on your end.
Thanks!

Thanks! I was using an old SDK's version


[Bug]: Car park out scenario not working in second map

Current Behavior
Car doesn't seem to be able to park out of it's parking spot in the second map
Expected Behavior
Car should be park out on the second map just as good as on the first map
How to reproduce the issue

let the car drive till the first map stops and the second map starts
right at the beginning it seems like the park out scenario is inactive
-> could be due to the fact, that the behaviour tree doesn't work properly after some time
OR: the park out scenario variable has to reset when we spawn on another map

The problem is that the behavior is not reset. I currently can't test the fix because my memory usage would raise too high. Can you try it out on your PC? @robertik10

When trying to reproduce the situation, I found the behavior working (video). The problem that the vehicle doesn't leave the parking space also occurred sometimes on the first map. The problem is that the vehicle starts driving seconds before the initial trajectory is calculated. Therefore the steering doesn't work and we stay inside the parking space. You can observe in the rviz window that we start driving just before the green trajectory is visible. This bug is fixed in @JuliusMiller's branch where the curve speed is considered.
BugFix_edited.webm
Therefore I will delete the branch from this issue.

Alright sounds good to me, great job!


White screen after ending session in TWA

My PWA is already in PLAYSTORE and it's working well, but when i download it, sign in and then end my session, the screen goes white, and i'd like to know if the issue its on the bubblwrap deployment or if it's on my pwa side? or maybe the new google necessity to upload apps in .aab format?
I'll attach a video showing you what's happening...
https://user-images.githubusercontent.com/45378130/154337455-c1b35c17-e4c8-4b7d-b84b-9d534272cf5f.mp4

I'm not completely sure about what's happening on the video.  A couple of things to keep in mind:

Bubblewrap is just a generator for the Android application. So, unlikely that behaviour is related to Bubblewrap at all.
Mostly, the Trusted Web Activity is a setup on how the site is loaded. There may be some awkward interaction between the TWA and the site.
But my guess is that something is happening inside the PWA, that is rendering an empty HTML. I'd first try using Chrome DevTools connected to the Android device to understand what's happening.

Closing this as it's unrelated to Bubblewrap.


Transition from model and vectorizer to pipeline

This PR moves away from having two separate pickle files for a model and a vectorizer and utilises the pipeline functionality of sklearn to combine the two so that we do not need to carry around two objects as well as pass two arguments. Instead all the logic that comes from training the model is incorporates into the pipeline object that accepts a list of strings and returns a classification and a probablity.

Should this also include changes to parse_latest.py? e.g. line 68, args.vectorizer_file.

@peter337 good point, will make the necessary adjustments


terraform-providers.lxd: init at 1.3.0

Motivation for this change
This adds support for terraform-provider-lxd
Things done
Used the provider to setup an LXD k8s cluster and it seems to work just fine.

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@Mic92 Thanks for the review, I've forced pushed the changes requested.


[Feature Request] teardown test hook API

Describe the feature request
Storybook Test Runner test hook api has a setup, preRender, and postRender but no teardown.
Why does this matter?
We trying to connect to an on-prem (for security concerns) visual differential tool but the lacking of a teardown function means we can't send a proper request to finalize the batch. When an engineer gets a visual regression instead of reviewing/approving a single batch of all the components, she has to go through 80 "batches", one for each component because we're sending the call to finalize the batch after the postRender call.
I'm happy to submit a PR for this. Any thoughts on what would be the best way to add a teardown hook? I've tried adding it to playwright/jest-setup.js but I can't seem to find a way to trigger the function when Jest runs it's teardown.

Hey @puppybits! Feel free to open a PR and we can do experimentations to get it over the finish line.
These are possible places to take a look at:
https://github.com/storybookjs/test-runner/blob/future/playwright/custom-environment.js#L13
https://github.com/storybookjs/test-runner/blob/future/playwright/global-teardown.js#L6

Adding another use case from #109:

It would be very useful to have teardown() hook similar to setup() so we can run code after all stories are tested.
One use-case is to write github test summary after tests finish. Which would be super useful for a11y tests.
But in principle there can be many things that afterAll or teardown function would be useful.


homebridge-gpio-device not loading correctly

I thought I got everything working again after I updated to the newest Homebridge, but
GarageDoorOpener isn't showing up in HomeKit, and everytime I do a restart of Homebridge I get this:
[Garage Door] Initializing GPIODevice accessory...
juni 14 23:11:06 raspberrypi homebridge[17534]: [2021-6-14 11:11:06 PM] Error: EBUSY: resource busy or locked, write
juni 14 23:11:06 raspberrypi homebridge[17534]:     at Object.writeSync (fs.js:573:3)
juni 14 23:11:06 raspberrypi homebridge[17534]:     at Object.writeFileSync (fs.js:1204:26)
juni 14 23:11:06 raspberrypi homebridge[17534]:     at exportGpio (/usr/local/lib/node_modules/homebridge-gpio-device/node_modules/onoff/onoff.js:18:8)
juni 14 23:11:06 raspberrypi homebridge[17534]:     at new Gpio (/usr/local/lib/node_modules/homebridge-gpio-device/node_modules/onoff/onoff.js:172:36)
juni 14 23:11:06 raspberrypi homebridge[17534]:     at Object.init (/usr/local/lib/node_modules/homebridge-gpio-device/index.js:22:19)
juni 14 23:11:06 raspberrypi homebridge[17534]:     at new GarageDoor (/usr/local/lib/node_modules/homebridge-gpio-device/index.js:754:8)
juni 14 23:11:06 raspberrypi homebridge[17534]:     at new DeviceAccesory (/usr/local/lib/node_modules/homebridge-gpio-device/index.js:137:18)
juni 14 23:11:06 raspberrypi homebridge[17534]:     at config.accessories.forEach (/usr/local/lib/node_modules/homebridge/src/server.ts:350:50)
juni 14 23:11:06 raspberrypi homebridge[17534]:     at Array.forEach ()
juni 14 23:11:06 raspberrypi homebridge[17534]:     at Server.loadAccessories (/usr/local/lib/node_modules/homebridge/src/server.ts:270:29)
juni 14 23:11:06 raspberrypi homebridge[17534]:     at Server.start (/usr/local/lib/node_modules/homebridge/src/server.ts:162:12)
juni 14 23:11:06 raspberrypi homebridge[17534]: [2021-6-14 11:11:06 PM] Got SIGTERM, shutting down Homebridge...
Then I get homebridge up and running by reinstalling homebridge-gpio-device. But GarageDoorOpener isn't showing up.
gpio version: 2.46
node version: v10.19.0
<EMAIL_ADDRESS><EMAIL_ADDRESS>npm version v6.13.4
homebridge version: v1.3.4
Type: Pi 3, Revision: 02, Memory: 1024MB, Maker: Sony

Device tree is enabled.
*--> Raspberry Pi 3 Model B Rev 1.2
This Raspberry Pi supports user-level GPIO access.

GPIODevice in config.json:
(...)
"accessory": "GPIODevice",
"name": "Garage Door",
"type": "GarageDoorOpener",
"inverted": "false",
"pin": 7
(...)

If I change to a different pin Homebridge starts and the plugin loads.
I used to have pin: 11 when the plugin looked for the wPi number. The BCM number should be 7. Why is this giving me an EBUSY error?

Any suggestions?


python312Packages.yalexs: 6.4.4 -> 8.0.2

Diff: https://github.com/bdraco/yalexs/compare/refs/tags/v6.4.4...v8.0.2
Changelog: https://github.com/bdraco/yalexs/releases/tag/v8.0.2
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 335241 run on x86_64-linux 1

1 package failed to build:

home-assistant-component-tests.august

4 packages built:

python311Packages.yalexs
python311Packages.yalexs.dist
python312Packages.yalexs
python312Packages.yalexs.dist

Out of date.


Installation instruction inconsistent between README and docs

README:
Kanister Installation
Kanister is based on the operator pattern. The first step to using Kanister is to deploy the Kanister controller:

$ git clone git@github.com:kanisterio/kanister.git

# Install Kanister operator controller
$ kubectl apply -f bundle.yaml

docs:

This will install the controller in the default namespace

# install Kanister operator controller using helm
$ helm install stable/kanister-operator

This has now been addressed.


MSB3030	Could not copy the file "..\SmartComponents.StaticAssets\dist\SmartComponents.StaticAssets.lib.module.js

Severity	Code	Description	Project	File	Line	Suppression State	Details
Error (active)	MSB3030	Could not copy the file "..\SmartComponents.StaticAssets\dist\SmartComponents.StaticAssets.lib.module.js" because it was not found.	SmartComponents.AspNetCore.Components (net6.0), SmartComponents.AspNetCore.Components (net8.0)	C:\Users\sanjay.dwivedi\Source\Repos\smartcomponentsnew\src\SmartComponents.AspNetCore.Components\SmartComponents.AspNetCore.Components.csproj	30

Confirming this issue, it also happens on my workstation with Visual Studio 2022.


spoofer: 1.3.3 -> 1.4.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/spoofer/versions.
meta.description for spoofer is: '"Assess and report on deployment of source address validation"'.

Checks done (click to expand)

built on NixOS
/nix/store/yk87nfn2763fcrd3p4a955ml3q0hpb8w-spoofer-1.4.0/bin/spoofer-prober passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 1.4.0 with grep in /nix/store/yk87nfn2763fcrd3p4a955ml3q0hpb8w-spoofer-1.4.0
directory tree listing: https://gist.github.com/b8b0d6b9e64b5cfb4f35f0430b820f90
du listing: https://gist.github.com/45c56ca270b18f4980256a9e422c3d47

Outpath report (click to expand)

Outpath difference report
8 total rebuild paths
2 package rebuilds
2 x86_64-linux rebuilds
2 i686-linux rebuilds
2 x86_64-darwin rebuilds
2 aarch64-linux rebuilds
First ten rebuilds by attrpath
spoofer
spoofer-gui

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/yk87nfn2763fcrd3p4a955ml3q0hpb8w-spoofer-1.4.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A spoofer https://github.com/r-ryantm/nixpkgs/archive/e681d3a6da63e34f2c66c65b345b2a827467af18.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/yk87nfn2763fcrd3p4a955ml3q0hpb8w-spoofer-1.4.0
ls -la /nix/store/yk87nfn2763fcrd3p4a955ml3q0hpb8w-spoofer-1.4.0/bin

cc @leenaars for testing.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: spoofer
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on aarch64-linux (full log)
Attempted: spoofer
Partial log (click to expand)
make[2]: Leaving directory '/build/spoofer-1.4.0'
make[1]: Leaving directory '/build/spoofer-1.4.0'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/khav76p8zlbh0yzfiyqvy8zaqqs3qgzl-spoofer-1.4.0
shrinking /nix/store/khav76p8zlbh0yzfiyqvy8zaqqs3qgzl-spoofer-1.4.0/bin/spoofer-prober
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/khav76p8zlbh0yzfiyqvy8zaqqs3qgzl-spoofer-1.4.0/bin
patching script interpreter paths in /nix/store/khav76p8zlbh0yzfiyqvy8zaqqs3qgzl-spoofer-1.4.0
checking for references to /build in /nix/store/khav76p8zlbh0yzfiyqvy8zaqqs3qgzl-spoofer-1.4.0...
/nix/store/khav76p8zlbh0yzfiyqvy8zaqqs3qgzl-spoofer-1.4.0

Success on x86_64-linux (full log)
Attempted: spoofer
Partial log (click to expand)
make[2]: Leaving directory '/build/spoofer-1.4.0'
make[1]: Leaving directory '/build/spoofer-1.4.0'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/yk87nfn2763fcrd3p4a955ml3q0hpb8w-spoofer-1.4.0
shrinking /nix/store/yk87nfn2763fcrd3p4a955ml3q0hpb8w-spoofer-1.4.0/bin/spoofer-prober
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yk87nfn2763fcrd3p4a955ml3q0hpb8w-spoofer-1.4.0/bin
patching script interpreter paths in /nix/store/yk87nfn2763fcrd3p4a955ml3q0hpb8w-spoofer-1.4.0
checking for references to /build in /nix/store/yk87nfn2763fcrd3p4a955ml3q0hpb8w-spoofer-1.4.0...
/nix/store/yk87nfn2763fcrd3p4a955ml3q0hpb8w-spoofer-1.4.0


Expose translate_package_lock as a module_extension

Per
https://github.com/bazelbuild/bazel/issues/14445#issuecomment-997976771
This would give end-users a way to change to bzlmod with sth like this in their MODULE.bazel
bazel_dep(name="aspect_rules_js", version="x")
# needed for transitive visibility for the extensions to use
bazel_dep(name = "rules_nodejs", version="y")

package_lock = use_extension("@aspect_rules_js//js:extensions.bzl", "package_lock")
package_lock.translate(name = "my_npm", package_lock_json = "//:package-lock.json")
use_repo(package_lock, "my_npm")
# if needed for visibility
use_repo(package_lock, "npm__swc_cli-0.5.1")

then in BUILD.bazel
...
deps = ["@my_npm//@swc/cli"],
# OR
deps =<EMAIL_ADDRESS>
The package_lock extension would both create the npm_import rules for every package, and also the my_npm aliases repository (but not with a repositories.bzl helper inside, as bzlmod gives no way to call that helper since extensions run in parallel)

replaced by #63


Add support for Ptyxis terminal

Ptyxis is a new GNOME terminal from Christian Hergert that offers first-class support for containers.
https://gitlab.gnome.org/chergert/ptyxis
This PR adds it as the 1st choice given it's container-oriented feature set, but if you'd like that changed just let me know :)

Thanks for the contribution!
From reading that page, it looks like the preferred method of installing ptyxis is via Flatpak, which BoxBuddy won't be able to spawn. It's also new and niche, and unlikely to be on many users' systems, so I think it's probably better to go toward the bottom of the priority list.

Thanks for the contribution! From reading that page, it looks like the preferred method of installing ptyxis is via Flatpak, which BoxBuddy won't be able to spawn. It's also new and niche, and unlikely to be on many users' systems, so I think it's probably better to go toward the bottom of the priority list.

Thanks for merging! The Universal Blue project is shipping both Ptyxis and BoxBuddy OOTB now, so we'll just ship a file to set the default.


GodotPayments

Can someone write in the wiki how to use this singleton on android? I saw that in the java source but I'can make it work from gdscript.

This sounds interesting.

Moved to the godot-docs repo.


[Bug]: When viewing remote results, the workflow containing Chinese characters appears garbled

Apache Hop version?
2.6.0
Java version?
11.0.2
Operating system
Windows
What happened?
I created a workflow (this workflow contains Chinese characters), see Figure 1, using the remote (Hop remote workflow engine) way to run, the output of the log is normal, but when I view the results (Location type is Remote location, see Figure 2) appeared garbled, see Figure 3.

Issue Priority
Priority: 2
Issue Component
Component: Actions, Component: API, Component: Hop Gui, Component: Hop Server

Could you test with Hop 2.7, this issue should be resolved #3356

Thanks a lot for the answer, I tested again with the latest version 2.7.0 (client and docker image) but the issue persists, maybe it is different from #3356.

The same problem is also visible in the metrics tab.
Local execution

Remote server execution

Charset problems seem to have been corrected with https://github.com/apache/hop/pull/3599

The problem doesn't seem to be completely solved, I downloaded the latest version 2.8.0, created a workflow to test it, and there is still Chinese gibberish when getting the workflow remote results.
Figure 1. Workflow remote logs print properly.

Figure 2. Workflow remote results appear garbled, including the workflow name, log, and the name of the action in the workflow.

Figure 3. Double-click to enter the operation of the pipeline type, which also has a lot of garbled code, including pipeline names, conversion names and logs, etc.

I'm reopening the issue. I reproduce the bug with the following "Execution Information Location":

@ahai-code, could you test with a latest build from here then we know the issues are resolved in the next version

Well, I downloaded "hop-client-2.9.0-20240318.234909-1.zip" from the link, and hop-server (Docker image) is still using 2.8.0, and testing revealed that when using the remote method to run the workflow and pipeline, this error message appears, as shown in Figure 1. Is it because I am not using the same version (2.9.0-20240318.234909-1) of the Docker image as the client?

Hi @ahai-code for docker images you can use the 2.9.0-SNAPSHOT or Development tags:
https://hub.docker.com/r/apache/hop/tags

@hansva Thank you, it's because the client and hop server versions are not the same. And I just created a remote workflow to test it, and the garbled Chinese issue is resolved. @nadment Thank you again for your patience in solving this problem, which has helped me a lot in using the software.


Ensure that we filter and QFLAGS and do not automatically say we have…

… the same capabilities as our master.
@havardpe PR

Something better is slime.
And that shall happen this year....
I suggest not putting to much into this, and work towards slime instead.

after some more thought, and since individual query flags are actually defined in the protocol itself, I suggest calling the filter ACTIVE_QUERY_FLAGS and leave the rest as-is.

I would prefer this flag and the associated filtering to be located in fdispatch, together with the code where flags from qrs are copied into flags to proton. The current solution entangles the protocol, fdispatch and proton even tighter together, where the protocol layer takes decisions on behalf of fdispatch based on knowledge of proton...


Combine multiple masks and boxes

I want to apply Yolact to remote sensing images, UH,. Could you give me some Suggestions?
Thanks~

If you can pose the problem as producing instance masks, you can use those predicted instance masks any way you want (including combining them). You'll want to do extra processing on YOLACT's output.
Also, I'll answer technical questions, but I can't help with open ended research questions since my hands are full already.

Fine,thank you~


Support task dependencies

We want to be able to do entire workflows of jobs, the workflows would be DAGs.
The idea is that when a DAG is submitted all the tasks will be created after a BFS of the DAG so that all the tasks have their parents filled in.
ajc will then, when a task with dependencies is handled, first check the dependent tasks are ok. It will optionally load up all their results into the task also.
For now we should just support basic n ancestors of a task.

Updated tasks overview wiki page with details of dependencies and also updated the flow chart.
Will close this now and make further issues for the DAG system


"S02-158. Simplice Update Dockerfile on Dev pipeline"

Reverts devopseasylearning/SESSION-01-DEVELOPMENT#94

good


Reorgs, sync & db optimizations

Blockchain reorganizations added to combat accidental network splits & forks due to orphan blocks, these blocks will now be abandoned in favor of a longer (Thus, the "correct") blockchain.
Blocks are now written to disk once every 1000 blocks, instead of once per-block, greatly improving disk efficiency and general blockchain-related processing.
Network usage has also improved, a node will no longer requests the full blockchain from multiple peers simultaniously, only one peer can send a full blockchain, otherwise, this adds up to possibly hundreds of MBs of duplicate chain data.

Oops, sorry about that. PR was meant for a forked project ahah.


is this normal?

Describe your problem here.
when i am compiling the code i see this message, do you guys know if this is supposed to happen?

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
no

It's normal, doesn't cause any issues

It's normal, doesn't cause any issues
ah ok thank you!


Linux R Services installation script and instructions

Create a PAM config file in /etc/pam.d by the name "rtvs". Should include common-auth, common-account, common-session-noninteractive
Create a 'broker user'
Install the service start/stop/restart scripts
Install RunAsUser to run as root
Copy library and binaries to /usr/lib/rtvs
Create symbolic link for Broker/Host/RunAsUser in /usr/bin
Copy rtvs R package files to /usr/share/rtvs/rtvs
Config files should go to /etc/share/rtvs

we create a deb package , that installs a systemd service. Instructions for configuration are available in rtvsd man pages.


Hide enclave setup functions in peer cli wrapper

This addresses issue #141
Additionally, this also separate more cleanly the namespace of internal functions  from the namespaces of functions passed to FPC chaincode.  This right now causes tlcc_enclave to fail with now quick fix. Given that tlcc_enclave anyway has to be fixed (issue #139), it can be best addressed in that context (there is a corresponding issue #143)

Regarding init, let's use #141 to elaborate on this topic first.

FYI: Moved from #141 to #145

tlcc_enclave test is now re-enabled. See commit log for what and what is not fixed related to issue #143


CSS loading issue?

This is how the app looks like when I open it in Safar/Chrome/Firefox:

Seems like it is not loading Tailwind properly.

Do you have any terminal output or errors? Because I can't reproduce it

No, all is running properly. Maybe some local network issue on my side or something then... investigating.

Yes, installing it with pnpm i was the issue. npm i works with turbopack.


Ability to utilize NT Authority/Network Service should be able to interact with host network objects

Add a test case into windows gmsa test.

/reopen


wal: Add _total suffix as metric is a counter

Follow up from https://github.com/prometheus/tsdb/pull/619#discussion_r290019916
@bwplotka @gouthamve @cstyan @krasi-georgiev
Signed-off-by: Frederic Branczyk<EMAIL_ADDRESS>

:+1:


Making Logging a separate module outside of autoconfiguration

Fixes: #1448.

@artembilan I decided against the "stackdriver" module because there is nothing useful to put there for the trace stuff, only logging.

Codecov Report

Merging #1455 into master will increase coverage by 0.35%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1455      +/-   ##
============================================
+ Coverage     69.15%   69.51%   +0.35%
- Complexity     1520     1525       +5
============================================
  Files           215      215
  Lines          5898     5898
  Branches        600      600
============================================
+ Hits           4079     4100      +21
+ Misses         1567     1543      -24
- Partials        252      255       +3

Flag
Coverage Δ
Complexity Δ

#integration
?
?

#unittests
69.51% <ø> (+0.35%)
1525 <ø> (+5)
:arrow_up:

Impacted Files
Coverage Δ
Complexity Δ

...k/cloud/gcp/logging/StackdriverTraceConstants.java
100% <ø> (ø)
1 <0> (?)

...work/cloud/gcp/logging/TraceIdLoggingEnhancer.java
28.57% <ø> (ø)
4 <0> (?)

...ork/cloud/gcp/logging/LoggingWebMvcConfigurer.java
71.42% <ø> (ø)
2 <0> (?)

...d/gcp/logging/TraceIdLoggingWebMvcInterceptor.java
81.81% <ø> (ø)
3 <0> (?)

...e/logging/StackdriverLoggingAutoConfiguration.java
100% <ø> (ø)
3 <0> (ø)
:arrow_down:

...ework/cloud/gcp/logging/StackdriverJsonLayout.java
64% <ø> (ø)
11 <0> (?)

...gcp/logging/extractors/XCloudTraceIdExtractor.java
100% <ø> (ø)
4 <0> (?)

...gure/trace/sleuth/StackdriverHttpServerParser.java
87.5% <0%> (+50%)
3% <0%> (+2%)
:arrow_up:

...gure/trace/sleuth/StackdriverHttpClientParser.java
85.71% <0%> (+80.95%)
4% <0%> (+3%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07529ad...9c94be5. Read the comment docs.

@artembilan I see your point. I did expect this to come up because there are some serious breaking changes, the most important of which is the path change to logback config files. I am, however, curious about the breaking changes policy. I have seen some breakage in minor versions of Spring like from Boot 2.0 to 2.1 and Framework 5.0 to 5.1, and even more so in Spring Cloud projects.
I'll try to make this a bit more backwards compatible. Perhaps we can import the logging configs from one file to the other.

I'm not sure what you mean about Spring Framework, but we really had some breaking changes in Spring Boot from 2.0 to 2.1: https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.1-Release-Notes
We had a big team discussion on the matter and those changes were really reasonable because previous behavior has just hidden an issue from us.
But that's fully different story and should be revised privately if that.
Anyway let's just don't make this breaking changes story like blaming each other! Let's try to keep our code from the breakage as much as possible.
This way we will eliminate many questions and issues from community.
I think it won't hurt to keep content of those logging configs as identical. Doesn't look like we change it too often...

@artembilan I followed your suggestion to also keep the original classes and files as deprecated. Please take another look.


Publish test results fail though tests succeed

Note
Issues in this repo are for tracking bugs, feature requests and questions for the tasks in this repo
For a list:
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
If you have an issue or request for the Azure Pipelines service, use developer community instead:
https://developercommunity.visualstudio.com/spaces/21/index.html )
Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: here
Enter Task Name: here
list here (V# not needed):
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
Environment

Server - Azure Pipelines or TFS on-premises?

If using TFS on-premises, provide the version:

If using Azure Pipelines, provide the account name, team project name, build definition name/build number:

Agent - Hosted or Private:

If using Hosted agent, provide agent queue name:

If using private agent, provide the OS of the machine running the agent and the agent version:

Issue Description
[Include task name(s), screenshots and any other relevant details]
Task logs
[Enable debug logging and please provide the zip file containing all the logs for a speedy resolution]
Troubleshooting
Checkout how to troubleshoot failures and collect debug logs: https://docs.microsoft.com/en-us/vsts/build-release/actions/troubleshooting
Error logs
[Insert error from the logs here for a quick overview]

Can you please share some more details requested in the above template? That will help us isolate and resolve the issue.

Please do reopen the issue with requested information.


Add workload finished event

What type of PR is this?
/kind feature

What this PR does / why we need it:

Added workload finished event for the job reconciler.
Added event reason constants for the job reconciler.

Which issue(s) this PR fixes:

Fixes #1387
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/hold for #1454

This is potentially missing a change in the workload reconciler (which terminates the Workload if it detects that an AdmissionCheck is rejected). Is that why you put the hold?

This is potentially missing a change in the workload reconciler (which terminates the Workload if it detects that an AdmissionCheck is rejected). Is that why you put the hold?

Yes. I would rather wait for that PR to be merged.

/test pull-kueue-test-integration-main

/assign @trasc

/lgtm

/unhold


Total calculation is incorrect

Even if the full discount was applied to the earrings, the Total for the line item would be incorrect and should be $0.50. The line item should have a total of $30.00, if discounts are not shown on the line items, instead of $5.00.

The reason that the earrings are showing $5 as the total price is due to two line item level promos  (promo Auto3 takes $5 off for each set of earrings, totaling $10, and promo MARC21 takes $15 off to represent 50% off those products).  Because these are sku-specific promos, the discounted total is reflected as $5 on the cart page  (I agree, this isn't very clear).
The 10% off entire order with code 0OUJX is taking $4.50 of the Subtotal of $45, and is not reflected in the Line Item totals.

Hello,
Thank you for the clarifications.  Much appreciated.
Upcoming Out of Office –  February 21, March 3 – 4, April 22 – 26, May 28 – June 5, June 20, July 2 - 10
Sincerely,
Michael Mavrofrides
From: Ashley Bishop @.>
Reply-To: ordercloud-api/headstart @.>
Date: Tuesday, February 15, 2022 at 12:27 PM
To: ordercloud-api/headstart @.>
Cc: Michael Mavrofrides @.>, Author @.***>
Subject: Re: [ordercloud-api/headstart] Total calculation is incorrect (Issue #347)
The reason that the earrings are showing $5 as the total price is due to two line item level promos (promo Auto3 takes $5 off for each set of earrings, totaling $10, and promo MARC21 takes $15 off to represent 50% off those products). Because these are sku-specific promos, the discounted total is reflected as $5 on the cart page (I agree, this isn't very clear).
The 10% off entire order with code 0OUJX is taking $4.50 of the Subtotal of $45, and is not reflected in the Line Item totals.
—
Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fordercloud-api%2Fheadstart%2Fissues%2F347%23issuecomment-1040562872&data=04|01|michael.mavrofrides%40sitecore.com|8dd69c84a8b94aba374708d9f0a865af|91700184c3144dc9bb7ea411df456a1e|0|0|637805428320223828|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=e2Fung6RbkhsrYq8EfvGQq1RWKNzrfAjVOQo80GxSPw%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIYKGJN6ZB6LAZ6IXN3XGGDU3KEGZANCNFSM5NMIUINQ&data=04|01|michael.mavrofrides%40sitecore.com|8dd69c84a8b94aba374708d9f0a865af|91700184c3144dc9bb7ea411df456a1e|0|0|637805428320223828|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=jNPBcQoxOiAIPubkoEn0csyTH2aMTzKm29IyJCFhrWw%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|michael.mavrofrides%40sitecore.com|8dd69c84a8b94aba374708d9f0a865af|91700184c3144dc9bb7ea411df456a1e|0|0|637805428320223828|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=4aHCNckU7EQYJELCS0bbzBrYjU13Ez6nP7gnA9T8q9A%3D&reserved=0 or Androidhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|michael.mavrofrides%40sitecore.com|8dd69c84a8b94aba374708d9f0a865af|91700184c3144dc9bb7ea411df456a1e|0|0|637805428320223828|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=QJdA9WNGdppj2GHYcXDV5BdbNOOpRwHfrNMw6sRVatE%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>
This message and its attachments are for the designated recipient only and may contain proprietary or otherwise confidential information. If you have received this message in error, please notify the sender immediately and delete the original. Any other sharing, copying or use of this message by you is strictly prohibited.


See also removed file 60 to 63

partial fix for SEE ALSO section under content/zh/docs/reference/setup-tools/kubeadm/generated/ need to be deleted.
see also removed from file 60 to 63

/lgtm

/cc @xichengliudui

/approve


all matchers should have FromStr trait implemented

[ ] combinator
[x] depth
[x] simple

Depth matcher implements such trait

Currently it would be easy to implement it for the combinator.
A new syntax would be required and most of all it would be necessary to register custom matchers somehow.
So lets postpone it. And create another task for that.


In EditScreen, vertical padding of CreateButton is narrow

Overview
As the title says, the vertical padding of Create Card Button is narrow.

Figma
Actual

Figma
https://www.figma.com/design/XUk8WMbKCeIdWD5cz9P9JC/DroidKaigi-2024-App-UI?node-id=55588-34615&t=VpbDVe3CvbfpqvxU-4

:raising_hand: I want to try it!

Thanks! Assigned 👍

@takahirom
I have something to report.
The padding between the Image label and the Add Image button is wider than that of Figma.
I have identified the cause of the problem. Is it okay to handle it together while dealing with the above issue?
Screenshot

Figma
Actual

@Songgyubin I think it's ok to handle! Thank you for your reporting

@kosenda @takahirom
Would it be alright if we go over this one more time?
Is it correct that the issue is that the vertical padding of the Create Card button on the actual screen is wider than that of the Create Card button in Figma?
However, looking at the code, the vertical padding is narrower than that of the Figma.
figma vertical padding: 18dp / actual padding: 16dp
Maybe the vertical padding value looks different because of the Android phone system font size?
cf.1)
Figma
figma's top padding: 18dp

Actual Code
8dp(Text's Padding) + 8dp(Button's default content padding) = 16dp

 Button(
                onClick = {
                    onClickCreate(
                        ProfileCard.Exists(
                            nickname = nickname,
                            occupation = occupation,
                            link = link,
                            image = imageByteArray?.toBase64() ?: "",
                            cardType = selectedCardType,
                        ),
                    )
                },
                enabled = isValidInputs,
                modifier = Modifier.fillMaxWidth()
                    .testTag(ProfileCardCreateButtonTestTag),
            ) {
                Text(
                    modifier = Modifier.padding(8.dp),
                    text = stringResource(ProfileCardRes.string.create_card),
                )
            }

cf.2)
Buttons for each system font size
 | | |

@takahirom
Additionally, the padding is different between Select Thme Item and Create Card.
Can I handle this too?
Screenshot

Figma
Actual

@Songgyubin cc: @takahirom
Sorry for the lack of explanation 🙇
This issue was intended to be about the padding outside the button, not the padding around the text inside the button!
(Both the top and bottom of the padding outside the button are narrow)

@kosenda  cc: @takahirom
it's okay. I should have asked in more detail before starting work :)
So I guess that's what this comment is about.
I will request PR after the work is in progress.
thank you for your reply.

@takahirom 또한, Select Thme Item과 Create Card 사이의 패딩이 다릅니다.
제가 이걸 처리할 수 있을까요?
스크린샷
피그마	실제


Design the UI flow for changing/undoing course selection

If a user accidentally selects a wrong course when turning a project into A+ project, how could they undo that selection afterwards?
This issue is opened as a design issue only, but can cover the implementation too, if so decided. Otherwise, follow-up issue(s) can be created once it is known how it will be implemented.

Currently the only (not so nice) solution: create a new project (since the course selection isn't shown again if you use "Turn Project Into A+ Course Project" in a course project).

Currently the only (not so nice) solution: create a new project (since the course selection isn't shown again if you use "Turn Project Into A+ Course Project" in a course project).

how about this

pawel likes this


Build not working

OS: Ubuntu 20.04 amd64
Rust: rustc 1.49.0 (e1884a8e3 2020-12-29)
Commit: 967c077
Output:
marcel@marcel-desktop:/mnt/data/code/psst$ git submodule update --recursive --init
marcel@marcel-desktop:/mnt/data/code/psst$ cargo build --release
warning: /mnt/data/code/psst/Cargo.toml: unused manifest key: profile.dev.split-debuginfo
   Compiling serde v1.0.127
   Compiling thiserror v1.0.26
   Compiling futures-util v0.3.16
   Compiling time-macros v0.1.1
   Compiling tracing v0.1.26
   Compiling souvlaki v0.4.1
error: unexpected token: `include_str`
 --> /home/marcel/.cargo/registry/src/github.com-1ecc6299db9ec823/souvlaki-0.4.1/src/lib.rs:1:10
  |
1 | #![doc = include_str!("../README.md")]
  |          ^^^^^^^^^^^

error: aborting due to previous error

error: could not compile `souvlaki`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed

Am I missing something? This is the same commit as the one in the CI, so it should work, right?

I have the same error (for rustc 1.53.0  (53cb7b09b 2021-06-17)) after running cargo build.

Latest Rust stable is needed.

I've had the same issue, updating rust with rustup update fixed it.

The compiler error is just pretty user unfriendly :)

I updated that, and it works!
@jpochyla - you were right and by lastest, you really mean lastest, not almost that

rustc 1.54.0 (a178d0322 2021-07-26) works
rustc 1.53.0 (53cb7b09b 2021-06-17) does not work


More Europe Servers

Is your feature request related to a problem? Please describe.
I'm always frustrated when i open the website to play tf2 and all the Europe servers are full and i have to wait 10-20 minutes to play tf2. I cant play in the US servers because there is too much lag (150-200 ms)
Describe the solution you'd like
I want to have more Servers at least 1 more server in the UK  . I live in Portugal so it would be great if there was a server in spain because even people from north africa could play with little ping.
Describe alternatives you've considered
I thought of other alternatives like improving the anti-lag system, (I'm not the most creative person)
Additional context

I will revisit this when I get a chance to talk to Dane

yes a server in spain would be really awesome

Done :P


How to uninstall it completely

Press the start button and search "Add or remove programs", find WinJump, then uninstall it


Added translation feature to sort title : _("some title")

The default django-sorting implementation does not support django translation, for example,  _("some ttitle"), I've made some slight modifications to support this feature.
Example:
{% anchor "creation_date" _("Creation") %}

see : https://github.com/jetli/django-sorting

closing this due to  duplication


IOS8SWiftAttributedStringsTutorial "W" got uppercase?

IOS8SWiftAttributedStringsTutorial should be IOS8SwiftAttributedStringsTutorial

nvm

thanks
2016-02-21 20:42 GMT+07:00 katopz<EMAIL_ADDRESS>
Closed #6 https://github.com/ioscreator/ioscreator/issues/6.
—
Reply to this email directly or view it on GitHub
https://github.com/ioscreator/ioscreator/issues/6#event-558367141.


Enable the copy-button

Proposed formatting enables the copy-button which appears in the top right corner of the copy widget. Which makes copy'n pasting the code fragment much easier.

@gvidon thx for the PR 👍


prevents deprecation warning

[DEPRECATION WARNING]:
Using bare variables is deprecated. Update your
playbooks so that the environment value uses the full variable syntax
('{{composer_global_packages}}')

thanks this is your release https://github.com/kosssi/ansible-role-composer/releases/tag/v1.6.1 ;)

+1:


CLI doesn't have intuitive message if it can't connect to MicroK8s

Bug Description
Right now the DSS CLI will show cryptic errors when it can't connect to microK8s. We saw this in https://github.com/canonical/data-science-stack/issues/151
Specifically we saw messages like this:
dss status
[ERROR] Failed to retrieve status: [Errno 111] Connection refused.

The CLI should clearly expose that the issue is with talking to MicroK8s
To Reproduce

sudo snap install data-science-stack --channel latest/stable
dss status

Note that you should run those without initialising the DSS
Environment
Ubuntu 22.04
Relevant Log Output
[ERROR] Failed to retrieve status: [Errno 111] Connection refused.

Additional Context
No response

From @misohu suggestion:
Part of this task can be to confirm with the UX team on how to best show the message, based on that we can fix it.


Upgrade to the latest puppet-apt

There's about 4 years of development on the puppet apt module since the version we have at puppet/apt in the Zulip codebase.  The changelog is here:
https://forge.puppet.com/puppetlabs/apt/changelog
We should also look at whether there's a better way to be managing this dependency than checking it in, though given how small our over puppet dependencies are, my hypothesis is that adding a gem toolchain to our provisioning would be more of a pain than it's worth.
We probably also need to upgrade puppet/stdlib, which we have only because puppet/apt uses it.

@zulipbot claim

@zulipbot abandon

I did some testing, and apparently modern puppet-apt just does not work with the older versions of Puppet we have on Ubuntu Trusty (uses too much fancy syntax).  So we might need to do something else.


Bug: Footer Fix

Footer needs to be implemented globally. All pages should have same footer.

Requirement -

i can do that task. If you want me to work on this please assign me under Hacktoberfest topic.

I would like to solve this issue. Could you assign me this issue. I would really like to contribute to it

@shikharg1110 @Shanb98 Assigned.
Make sure you are part of this repo's discord - https://discord.gg/v3M9kB7h

Hey @Karamraj , I want to work on this issue. I've ⭐ star-ed this repo and looking forward for furthermore contributions.


[Spike] how current and never versions of terraform handle disk resize

Is your feature request related to a problem? Please describe.
We don't have comparison based on different criteria on terraform behavior.
Describe the solution you'd like
We need research and small PoC showing how terraform handles disk resize. Preferable matrix of tests should have following axis:

terraform versions
cloud provider
linux distribution images
scale up/down size

Describe alternatives you've considered
No.
Additional context
Originally posted by @seriva in https://github.com/epiphany-platform/epiphany/issues/1325#issuecomment-645196356_

Closing as we currently don't have a valid business case anymore.


WADL reader fixes, duplicate params and missing info object

Back in April in https://github.com/APIs-guru/openapi-directory/issues/393 I noted that the WADL converter did not de-duplicate parameters and didn't include an info object. This PR aims to fix this. I wasn't totally sure about the best way to populate info.title and info.version but I went with what the test harness seemed to be doing.

Thanks! I think it's best to leave info.title and info.description as empty strings, so that any tooling can take into account that they're not defined. Other than that looks good!

Will rev the PR. Thanks.

Scraped v3: https://github.com/bobby-brennan/scrape-to-swagger/blob/master/output/jira.swagger.json
It's not perfect, since host unfortunately varies by user, and the oauth flow is even weirder.

Amended - note that this still changes the existing output of some tests.

Looks good, thanks!


Create sajdak.txt

@rsajdak sajdak.com website does not belong to an educational institution, the domain is even to registered. I have to close the request without merging. Please ensure you are familiar with this repository rules located at the bottom of this page and submit a new request with correct information. Thank you for the understanding!


Fix elevenlabs voice settings breaking

11labs API requires style float and use_speaker_boost boolean. defaulting to None gets translated to JSON as null type. this sets them to their default values noted in the API here: https://api.elevenlabs.io/v1/voices/settings/default

just noticed that this does break our API, as the default for speaker boosting is now True and it used to be False; do we keep it as it was?

Are the defaults safe when listing the voices using this fnc:
async def list_voices(self) -> List[Voice]:

Are the defaults safe when listing the voices using this fnc?
async def list_voices(self) -> List[Voice]:

that function sets settings=None, which changes the behaviour of the stock voices now, yes

Looking at their docs, they seem to explicitly use it on the examples? https://github.com/elevenlabs/elevenlabs-python/blob/a75c7e7e0b2aa8d04225ca34e2e387ccd0ba13ac/README.md#-voices
On their 11labs python-client, I see that they also default these stuff to None

new method just strips the Nones from the object before passing it to the JSON encoder, and doesn't mess with our defaults, so everything should be the same.

Looking at their docs, they seem to explicitly set it on the examples<EMAIL_ADDRESS>On their 11labs python-client, I see that they also default these stuff to None

i don't think elevenlabs' Python client even supports professional or cloned voices, they errored as well.


transform code with decorator encountered syntax error

I'm using decorator in my project and enabled @vitejs/plugin-react-refresh, it seems can handle decorator by this commit:
https://github.com/vitejs/vite/commit/565bcb4121e678310c26bb249b119da504d13ada
But macro plugin reports syntax error:

my vite config:
import { defineConfig } from "vite";
import reactRefresh from "@vitejs/plugin-react-refresh";
import { defineMacroPlugin } from "vite-plugin-macro";
import { join } from "path";
import { loadConfigMacro } from "./macros/loadConfig";
import { loadPluginsMacro } from "./macros/loadPlugins";
import { loadModulesMacro } from "./macros/loadModules";

export default defineConfig({
  plugins: [
    reactRefresh(),
    defineMacroPlugin({
      name: "macro-plugin",
      typesPath: join(__dirname, "./macros.d.ts"),
      exports: {
        "@loadConfig": {
          macros: [loadConfigMacro],
        },
        "@loadPlugins": {
          macros: [loadPluginsMacro],
        },
        "@loadModules": {
          macros: [loadModulesMacro],
        },
      },
    }),
  ],
});

use option parserPlugins: ['decorators'] in defineMacroPlugin

There are a lots of comments in the .dts file of the plugin, you can use these comments to understand options/concepts before the new document is created.

I solved this by parserPlugins option just then. Thx very much for your reply quickly.

@unbyte I debugged @vitejs/plugin-react-refresh and passed the same parserPlugins option to macro plugin but there are still some syntax parsing error. I'm using a lot of inversify features.
export default defineConfig({
  plugins: [
    reactRefresh(),
    defineMacroPlugin({
      name: "macro-plugin",
      typesPath: join(__dirname, "./macros.d.ts"),
      parserPlugins: [
        'jsx',
        'importMeta',
        'topLevelAwait',
        'classProperties',
        'classPrivateProperties',
        'classPrivateMethods',
        'typescript',
        'decorators-legacy'
      ],
      exports: {
        "@loadConfig": {
          macros: [loadConfigMacro],
        },
        "@loadPlugins": {
          macros: [loadPluginsMacro],
        },
        "@loadModules": {
          macros: [loadModulesMacro],
        },
      },
    }),
  ],
});

@unbyte Can we just parse the specific file. I just use Macro in limit scope.

since parser plugin jsx is enabled by default, <Type>xxx is ambiguous, try xxx as Type instead.

@unbyte Can we just parse the specific file. I just use Macro in limit scope.

include/exclude will be available in the next version.

since parser plugin jsx is enabled by default, <Type>xxx is ambiguous, try xxx as Type instead.

I'm migrating a huge legacy project to vite and use Macro to replace prepare script. Modifying the code writing style needs efforts.


pub.dev Page for this Package Wrong Link

As of right now, the link for the documentation for this Flutter package on pub.dev currently leads to "floor.codes". I noticed that the README.md for this repo has an updated link that seems to go to the correct site (https://pinchbv.github.io/floor/).

Good point @acuba001 Will fix that in the next release. Thanks

PR #714  has been created.


Arrow-related ligatures are not working in pretty-code

What did you expect to happen?
...
I used the prettify-symbols module to allow for ligature support on emacs 28. The font I am using, JetBrains Mono, includes many ligatures such as ->, -->, =>, ==>, >>=, etc.
What actually happened?
...
None of these are rendering as ligatures. Their original forms are being rendered.
Additional details:

screenshot:

Steps to reproduce:

Download and Install JetBrains Mono Font
Set JetBrains Mono to the default font for doom emacs
Enable Prettify-Symbols and change to a mode in which ligatures are supported.

System information:

((emacs
  (version . "28.0.50")
  (features . "XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY W32NOTIFY ACL GNUTLS LIBXML2 HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS MODULES THREADS JSON PDUMPER LCMS2 GMP")
  (build . "Jul 05, 2020")
  (buildopts "--without-dbus --host=x86_64-w64-mingw32 --without-compress-install -C 'CFLAGS=-O2 -static -g3' host_alias=x86_64-w64-mingw32 PKG_CONFIG_PATH=/mingw64/lib/pkgconfig")
  (windowsys . batch)
  (daemonp . server-running))
 (doom
  (version . "2.0.9")
  (build . "HEAD -> develop, origin/develop, origin/HEAD f3bb23aa7 2020-07-21 16:19:08 -0400")
  (dir . "~/.doom.d/"))
 (system
  (type . windows-nt)
  (config . "x86_64-w64-mingw32")
  (shell . "C:/Program Files/Emacs/emacs-28/x86_64/libexec/emacs/28.0.50/x86_64-w64-mingw32/cmdproxy.exe")
  (uname . "n/a")
  (path "c:/Program Files/Goneovim-0.4.6-win64" "C:/Program Files/nvim-win64/Neovim/bin" "C:/Python38/Scripts/" "C:/Python38/" "C:/Program Files (x86)/Python37-32/Scripts/" "C:/Program Files (x86)/Python37-32/" "C:/Program Files (x86)/Java/jre1.8.0_251/bin" "C:/WINDOWS/system32" "C:/WINDOWS" "C:/WINDOWS/System32/Wbem" "C:/WINDOWS/System32/WindowsPowerShell/v1.0/" "C:/WINDOWS/System32/OpenSSH/" "C:/Program Files (x86)/IVI Foundation/VISA/WinNT/Bin" "C:/Program Files (x86)/Go/bin" "C:/Program Files/Git/cmd" "C:/ProgramData/chocolatey/bin" "C:/Program Files/Racket" "C:/Program Files/nodejs/" "C:/Program Files/swipl/bin" "C:/Users/myusername/Documents/C/ascii/bin" "C:/Program Files/Emacs/emacs-28/x86_64/bin" "C:/Program Files/Emacs/emacs-27/x86_64/bin" "~/.emacs.d/bin" "C:/Program Files/ripgrep-12.1.1-x86_64-pc-windows-gnu" "C:/Program Files/fd" "C:/Program Files/LLVM/bin" "C:/cygwin64/usr/local/bin" "C:/tools/msys64" "C:/Users/myusername/AppData/Local/Microsoft/WindowsApps" "C:/MinGW/bin" "~/npm" "C:/Program Files (x86)/Dr. Memory/bin/" "C:/ProgramData/chocolatey/lib/ghc/tools/ghc-8.10.1/bin" "c:/Program Files/Emacs/emacs-28/x86_64/libexec/emacs/28.0.50/x86_64-w64-mingw32"))
 (config
  (envfile . envvar-file)
  (elc-files . 0)
  (modules :completion company ivy :ui doom doom-dashboard doom-quit hl-todo indent-guides modeline ophints (popup +defaults) pretty-code vc-gutter vi-tilde-fringe workspaces :editor (evil +everywhere) file-templates fold multiple-cursors snippets :emacs dired electric undo vc :checkers syntax :tools (eval +overlay) lookup magit :lang cc emacs-lisp markdown org python sh :config (default +bindings +evil-commands +smartparens))
  (packages "n/a")
  (unpin "n/a")
  (elpa "diffview" "decide" "dad-joke" "chess" "2048-game" "0blayout")))

Off the top of my head, Doom has a good track record with Fira Code, HaskLig, Iosevka and Pragmata Pro (use M-x +pretty-code/install-patched-font to install the correct version). I've no idea if it's supposed to work with other fonts, or if harfbuzz adds support for them.
Sorry to say ligatures are outside my expertise. I don't use them and I've relied mostly on users to provide them for Doom. I'd appreciate any help on the matter, or to improve the implementation.

Ok. It's not a super critical feature anyway. Thank you for taking the time and effort to read and consider the issue. Good job, by the way, creating doom. I love it!

@qazxwecvr This solution is working for me: https://emacs.stackexchange.com/a/55936/30204
(Fedora 32, Emacs 27.1)


Maintenance mode destination nullpointer with local storage data disk

ISSUE TYPE

Bug Report

COMPONENT NAME

Maintenance Mode

CLOUDSTACK VERSION

<IP_ADDRESS>

CONFIGURATION

host.maintenance.local.storage.strategy: Migration

OS / ENVIRONMENT

SUMMARY

Nullpointer exception when setting a host in maintenance if the host has a running vm with a local storage data disk.
Found the bug while fixing another bug where the host going into maintenance is not avoided so maintenance for local storage vms can fail.
During testing I did not find a path in the current version to reach the breaking code without a debugger attached.
Bug is caused by the deployment returning null causing a nullpointer in https://github.com/apache/cloudstack/blob/18fe4226cecc930ec0b39c43e5b63a48c17c2ad4/server/src/main/java/com/cloud/resource/ResourceManagerImpl.java#L1471
Deployment returns null as the only suitable storage pool returned by findSuitablePoolsForVolumes in server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java for the data disk is the host the data disk is located on.  (Only applies for data disk, for a local storage root disk all suitable storage pools are evaluated). With that host being avoided to prepare it for maintenance the deployment planner has no suitable hosts returning null.
Migrating the vm using the ui does not cause issues.
STEPS TO REPRODUCE

Create a vm with a local storage data disk.
Add breakpoint at the start of https://github.com/apache/cloudstack/blob/18fe4226cecc930ec0b39c43e5b63a48c17c2ad4/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java#L300
Set host with the vm in maintenance
Add the host going into maintenance to the avoids avoids.addHost();
Continue running

EXPECTED RESULTS

VM migrated and host going into maintenance
ACTUAL RESULTS

2024-11-01 16:04:39,428 ERROR [c.c.a.ApiAsyncJobDispatcher] (API-Job-Executor-5:ctx-b739d4ae job-371) (logid:51494050) Unexpected exception while executing org.apache.cloudstack.api.command.
admin.host.PrepareForMaintenanceCmd
java.lang.NullPointerException
        at com.cloud.resource.ResourceManagerImpl.migrateAwayVmWithVolumes(ResourceManagerImpl.java:1471)
        at com.cloud.resource.ResourceManagerImpl.doMaintain(ResourceManagerImpl.java:1403)
        at com.cloud.resource.ResourceManagerImpl.maintain(ResourceManagerImpl.java:1489)
        at com.cloud.resource.ResourceManagerImpl.maintain(ResourceManagerImpl.java:1543)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:566)
        at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
        at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
        at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
        at com.sun.proxy.$Proxy200.maintain(Unknown Source)
        at org.apache.cloudstack.api.command.admin.host.PrepareForMaintenanceCmd.execute(PrepareForMaintenanceCmd.java:101)
        at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:172)
        at com.cloud.api.ApiAsyncJobDispatcher.runJob(ApiAsyncJobDispatcher.java:112)
        at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:654)
        at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:48)
        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55)
        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:102)
        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:52)
        at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:45)
        at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:602)
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        at java.base/java.lang.Thread.run(Thread.java:829)

@BartJM is #9892 a full solution for the issue, or just a partial solution?

#9892 is not a solution to this issue. It is a solution to another issue (any local storage vms not migrating with maintenance) which allows this issue to be reachable.

@BartJM  I tested the host maintenance on a host with vm using local storage in 4.18. I set host.maintenance.local.storage.strategy: Migration
It fails since it selects the source host/primary storage for migration.
I understand PR 9892 fixed the above issue but still won't result in successful vm migration without fixing this NPE.

@rajujith PR9892 fixed the issue you describe, but it will result in a successful vm migration when no data disk is used or when the datadisk is not on local storage.
This NPE only occurs when a local storage data disk is used.


Lack of tonality (hearing model) sound quality metric

I only found the tr/pr sound quality metric, but not the tonality (hearing model) sound quality metric.
Which is the best sound quality metric in tr/pr/tonality (hearing model)?
If tonality (hearing model) is useful, I am going to write the python code of tonality (hearing model) recently and upload it to MoSQITo
Library.
Hope to get your reply as soon as possible.

Hi,
Indeed the tonality from ECMA 418-2 is currently lacking in MOSQITO.
We are currently working on the roughness from ECMA 418-2, and the tonality was supposed to come after, so we'd be very happy to review your implementation :)
This metric would be very useful for all MOSQITO users, thanks for your contribution !
Don't hesitate to share your fork if you need some help with the implementation...
Salomé


Need to add Hide Window Dialog functionality to Codeunit 5880

Hello !
We need new global boolean variabel HideProgressWindow and new external procedure SetHideProgressWindow() in Codeunit 5880
in order to managed them by Job Scheduler and web services.
I think you need to add some GuiAllowed too :)
thank you
best regards

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


segmentation fault in st_contains spatial join

Problem
Good morning, again!
When performing an ST_ContainsProperly or ST_Within of a centroid in another boundary (the centroids of a 152M record table compared against the large township boundaries of only a 2M record table) -- I'm getting a segmentation fault.
As an aside, I want to say that we are very close to getting DuckDB to work for processing all our spatial data. This spatial join is the last blocker. DuckDB is performing faster than PostGIS. The work done here has been a blessing. I am grateful for everyone here at DuckDB!
Traceback
segmentation fault

Steps to re-create
Running this query against a row table stored in .duckdb file, locally.
          select
                 b.row_id,
                 t.township
          from parcel_batch_1 b
          join './section_township_range.parquet' t
          on st_containsproperly(st_centroid(b.geom), st_geomfromhexewkb(t.geom));

I've added an R-Tree index to the geom column of the large, 152M record table, parcel_batch_1.
I've added the query plan to this issue indicating the non-use of the R-tree index.
Query gets to ~49% completion before hitting segmentation fault.

Initial Query Plan
┌─────────────────────────────┐
│┌───────────────────────────┐│
││       Physical Plan       ││
│└───────────────────────────┘│
└─────────────────────────────┘
┌───────────────────────────┐
│         PROJECTION        │
│    ────────────────────   │
│            row_id         │
│          township         │
│                           │
│       ~25000000 Rows      │
└─────────────┬─────────────┘
┌─────────────┴─────────────┐
│           FILTER          │
│    ────────────────────   │
│    ST_ContainsProperly    │
│    (ST_Centroid(geom),    │
│  ST_GeomFromHEXEWKB(geom))│
│                           │
│       ~25000000 Rows      │
└─────────────┬─────────────┘
┌─────────────┴─────────────┐
│          IE_JOIN          │
│    ────────────────────   │
│      Join Type: INNER     │
│                           │
│        Conditions:        │
│     ST_XMin(ST_Extent     │
│  (ST_Centroid(geom))) <=  │
│      ST_XMax(ST_Extent    │
│(ST_GeomFromHEXEWKB(geom)))│
│     ST_XMax(ST_Extent     │
│  (ST_Centroid(geom))) >=  │
│      ST_XMin(ST_Extent    ├──────────────┐
│(ST_GeomFromHEXEWKB(geom)))│              │
│     ST_YMin(ST_Extent     │              │
│  (ST_Centroid(geom))) <=  │              │
│      ST_YMax(ST_Extent    │              │
│(ST_GeomFromHEXEWKB(geom)))│              │
│     ST_YMax(ST_Extent     │              │
│  (ST_Centroid(geom))) >=  │              │
│      ST_YMin(ST_Extent    │              │
│(ST_GeomFromHEXEWKB(geom)))│              │
│                           │              │
│       ~25000000 Rows      │              │
└─────────────┬─────────────┘              │
┌─────────────┴─────────────┐┌─────────────┴─────────────┐
│         SEQ_SCAN          ││       PARQUET_SCAN        │
│    ────────────────────   ││    ────────────────────   │
│       parcel_batch_1      ││         Function:         │
│                           ││        PARQUET_SCAN       │
│        Projections:       ││                           │
│            geom           ││        Projections:       │
│            row_id         ││            geom           │
│                           ││          township         │
│                           ││                           │
│       ~25000000 Rows      ││       ~2379868 Rows       │
└───────────────────────────┘└───────────────────────────┘

Alternate Attempt (no segmentation fault, but query hangs at 50%)

I then created a centroid column on parcel_batch_1 so the st_centroid needn't be calculated in the join condition, and materialized the Parquet file as a table. I added an R-Tree index on both parcel_batch_1.centroid and the geom column of the township (formerly the Parquet file) table. Still, no usage in query plan.
I changed ST_ContainsProperly to ST_Contains, as well.
Memory is under control, threads being used:

Environment:
 % uname -a
Linux john-XPS-15-9520 6.8.0-40-generic #40~22.04.3-Ubuntu SMP PREEMPT_DYNAMIC Tue Jul 30 17:30:19 UTC 2 x86_64 x86_64 x86_64 GNU/Linux

 % duckdb --version
v1.1.2 f680b7d08f

My Machine:

64GiB Memory
20 CPU
Dell XPS

Hi! Happy to hear DuckDB spatial is useful for you and thanks for opening this issue!
R-Tree indexes are not used for spatial joins yet, only when doing spatial filters, so it makes sense that you wouldn't see it used in the plan. Adding support for joins is of course high on the TODO list but I can't provide an exact timeline.
All the functions you use, ST_ContainsProperly, ST_Contains, ST_Within ST_Centroid etc. are all implemented by calling into the GEOS library, which will allocate memory outside of DuckDB's control. This is usually the reason why larger spatial joins/queries fail, but since you seem to be well within the memory bounds and the process doesnt get killed by the oom-killer, there might be a bug somewhere in either our code or GEOS. Is there any way you could share the data? Alternatively try to isolate which geometries caused the crash (e.g. by recursively dividing the datasets in half and still see if the segmentation fault occurs, and if so, in which half)?
If you convert and store the geometries into a table first (so that you don't have to call ST_GeomFromHEXEWKB in the main query), does it still crash?

@Maxxen, thank you for your reply. Unfortunately, I can not share the proprietary data, but the suggestions were right-on:

I pre-processed the ST_GeomFromHEXEWKB() column so i was only performing an st_within(), not calcuating the geometry as well. I was able to complete this query where the larger table was 152M rows and the smaller table was 1.5M. The maximum RAM usage was 40GiB. The query completed successfully! Thank you.

Yet, in another query, using the same data from the first query, I'm trying to perform a spatial join between a 142M row subset table and a 3M row subset table. Same geometries. Using the same Spatial extension functions as the first, passing query:
select ....
from 152_M_row_table large
join 3_M_row_table small
on st_within(geom_centroid, geom)

and it is using up to 57GiB RAM, but eventually hitting the initial segmentation fault.
I then tried dialing down the precision of my spatial join with a:
select ....
from 152_M_row_table large
join 3_M_row_table small
on st_intersects(geom_centroid, geom_envelope)

whereby the geometry is just the calculated, st_envelope (minimum bounding box) value
still gets terminated with a segmentation fault.

Realizing I only really care how records match to the larger table, I changed the join to a left join, which has now shifted from an IE Join to an NL Blockwise Join, even with set prefer_range_joins=true;. Good news: the query plans total rows are the same, but I'm only using up to 9GiB of RAM, now. Not sure what the total run time will be, now, but I'll update here.
I really appreciate you taking the time to answer my questions, and the work you're doing to improve the Spatial extension.

Looking at it more:

the geometries in this second case have more vertices, are more complex.
When i run this in PostgreSQL, and add an additional joinfilter for matching on state, the query planner winnows to only try joining geometries that first match on state. However, when i try to replicate that filter condition (on state) in DuckDB, it explodes the join into trillions of rows in the explain.
wonder if reducing precision helps, meaningfully here.


xz1

An arthropod with tentacles jumping out of the water

An arthropod with tentacles jumping out of the water

An arthropod with tentacles jumping out of the water

An arthropod with tentacles jumping out of the water