Rect2i.end always returns an empty rect, works in GDScript

# GDScript
var rect = Rect2i(0, 0, 100, 100)
print(rect.end)
# → (100, 100)

// Swift
let rect = Rect2i(x: 0, y: 0, width: 100, height: 100)
GD.print(rect.end)
// → Vector2i(x: 0, y: 0)

workaround:
extension Rect2i {
    var end: Vector2i {
        .init(
            x: position.x + size.x,
            y: position.y + size.y
        )
    }
}

(I'm not sure why the compiler doesn't complain about me shadowing end without an override keyword 🤔)

The core problem seems to be that Generator assumes Rect2i to have end as a stored property based on the builtin_classes in extension_api.json:
"name": "Rect2i",
"is_keyed": false,
"members": [
	{
		"name": "position",
		"type": "Vector2i"
	},
	{
		"name": "size",
		"type": "Vector2i"
	},
	{
		"name": "end",
		"type": "Vector2i"
	}
],

But in the builtin_class_member_offsets it only has the first two members:
"name": "Rect2i",
"members": [
	{
		"member": "position",
		"offset": 0,
		"meta": "Vector2i"
	},
	{
		"member": "size",
		"offset": 8,
		"meta": "Vector2i"
	}
]

which is closer to the C implementation, since there's just getter and setter for end:
_FORCE_INLINE_ void set_end(const Vector2i &p_end) {
	size = p_end - position;
}

_FORCE_INLINE_ Vector2i get_end() const {
	return position + size;
}

So the fix would be to take into account only members listed in builtin_class_member_offsets to make sure stored properties on Swift side match the C memory layout (There're probably some other issues caused by extra properties not expected by Godot). Not sure what to do with end though. I don't see any way to generate the implementation based on extension_api.json, so probably we have to implement it manually on non-generated side.

So the fix would be to take into account only members listed in builtin_class_member_offsets to make sure stored properties on Swift side match the C memory layout (There're probably some other issues caused by extra properties not expected by Godot).

👍  As a first step, this would be an improvement because the property would be missing rather than silently broken.

Not sure what to do with end though. I don't see any way to generate the implementation based on extension_api.json, so probably we have to implement it manually on non-generated side.

I don't have much experience calling C from Swift, so maybe this isn't possible but: In these cases, where there's no entry in builtin_class_member_offsets, could we assume that they're going to have getter/setters and generate a set of swift getters and setters that forward to the C implementation?

Also thanks for investigating and explaining! 🥇

I don't have much experience calling C from Swift, so maybe this isn't possible but: In these cases, where there's no entry in builtin_class_member_offsets, could we assume that they're going to have getter/setters and generate a set of swift getters and setters that forward to the C implementation?

The problem is: those setters and getters are not described in extension_api.json. For reference types properties with setters and getters are described in the following manner:
"properties": [
	{
		"type": "Rect2i",
		"name": "region",
		"setter": "set_region",
		"getter": "get_region"
	},

And there's no such description for end.

Should we file an issue upstream so that the setter/getter can be added to extension_api.json ?

We could request the features, it won't hurt, but we can also add extensions that make sense for us to have in our codebase.
In addition to the above, I want to also have pure Swift-implementations of certain methods, to avoid the round trip to C++ via the glue layer.   In particular for things in Vector*/Rect* methods.   If we are missing things, is mostly a function of time, and not a matter of principle :-)

By the way, @migueldeicaza is there any sort of documentation on how to interpret extension_api.json? I'd love to read that to make sure we even understand what we're doing before jumping to any conclusions that something is missing.

We could request the features, it won't hurt, but we can also add extensions that make sense for us to have in our codebase.

I'm in favour of our own extensions, I am also worried that there are other examples like end that might be missing; It'd be good to know that the json file was complete as a base layer, even if we choose to add nicer API on top later.


[Helm charts]: meshery-operator needs helm chart

Current Behavior

Desired Behavior

Meshery-operator needs helm charts:

Can deploy into Kubernetes cluster by Helm chart.
The chart is needsed to be included in the Meshery helm chart repo.

Resources

Alternatives / Additional Context

We need a stable image of meshoperator.

It turns out that we don't need this as Meshery deploys the Operator itself.


[Reddit] User posts (not submissions) are missing

We have user submissions and user posts. The user posts are missing.
Offending url: http://rss-bridge.org/bridge01/?action=display&bridge=Reddit&context=user&u=brendt_gd&comments=on&score=&d=hot&search=&format=Html

I am unfamiliar with the terminology. Are user submissions and posts not synonymous? What are the missing items from the link above?

I guess user submission is a post too. User submission is when a user create a completely new post thread. It's like creating a new issue in an issue tracker. So, the bridge shows new issues but not comments by the user.

I see, so a new checkbox should be added that includes a user's comments on the post.

There is already a checkbox for that. It's the third context with the name user: http://rss-bridge.org/bridge01/#bridge-Reddit


Why do we need both docstore and index_struct? They seem very similar.

Hi there! I am sorry if this is a rookie question but when I inspect the docstore and index_struct, them seem very similar and a bit duplicated. Index file size is a big concern for me so I was thinking why we need both of them?
I tried deleting them one by one but then querying does not work at all. Both seems to be required.

@ymansurozer we need docstore for storing multiple index structs (say in the case of composability). For single indices we don't need docstore. That said docstore should just store a reference to the same index struct, so there shouldn't be duplicates! (I think) Have you experienced issues here?

@jerryjliu Ah, I see and that makes perfect sense. But still, when you get embeddings for large bodies of text, there is some duplication (or am I doing something wrong?). Here is a Faiss index file (not core) I've just created from a single file containing the text 'Containts Document content':
{
    "index_struct": {
        "text": null,
        "doc_id": "c0fe2a1e-a69f-4e10-bd6f-07472df43685",
        "embedding": null,
        "extra_info": null,
        "nodes_dict": {
            "8407316112998839724": {
                "text": "Contains Document content",
                "doc_id": null,
                "embedding": null,
                "extra_info": null,
                "index": 0,
                "child_indices": [],
                "ref_doc_id": "e150af44-ea2f-4d62-93b0-98e97c9d9532",
                "node_info": { "start": 0, "end": 25 }
            }
        },
        "id_map": { "0":<PHONE_NUMBER>998839724 }
    },
    "docstore": {
        "docs": {
            "e150af44-ea2f-4d62-93b0-98e97c9d9532": {
                "text": "Contains Document content",
                "doc_id": "e150af44-ea2f-4d62-93b0-98e97c9d9532",
                "embedding": null,
                "extra_info": null,
                "__type__": "Document"
            },
            "c0fe2a1e-a69f-4e10-bd6f-07472df43685": {
                "text": null,
                "doc_id": "c0fe2a1e-a69f-4e10-bd6f-07472df43685",
                "embedding": null,
                "extra_info": null,
                "nodes_dict": {
                    "8407316112998839724": {
                        "text": "Contains Document content",
                        "doc_id": null,
                        "embedding": null,
                        "extra_info": null,
                        "index": 0,
                        "child_indices": [],
                        "ref_doc_id": "e150af44-ea2f-4d62-93b0-98e97c9d9532",
                        "node_info": { "start": 0, "end": 25 }
                    }
                },
                "id_map": { "0":<PHONE_NUMBER>998839724 },
                "__type__": "dict"
            }
        }
    }
}

You can see 'Contains Document content' is repeated three times. In SimpleVectorIndex, the embeddings are repeated three times, too. The ID map should be sufficient to keep references so I thought there should be a way around this but now that you say there shouldn't be duplications, I am more thinking if I'm doing something wrong. :)

@jerryjliu Just wanted to follow up and ask if you have any ideas about this because removing this duplication would drastically reduce index file sizes.

@jerryjliu Just wanted to follow up and ask if you have any ideas about this because removing this duplication would drastically reduce index file sizes.

apologies for the delayed response. yes you're right - this is something i'll try to look into tonight + tmrw


Pasting same object twice causes ID duplication

When i copy an item and then past multiple copies of it - it seems to maintain the same object ID resulting in some weird behavior.

Someone reported the same issue in the bpmn.io forum.


Refactor front-end

Overview of the Solution:

We need to change our front-end technology from Vue.js to React.
Examples (if relevant):

Blockers (if relevant):

Sub Activities

[ ] Refactor the front-end
[ ] Add the next.js framework

Closing the issue since the merge was developed to develop.


FactoryGirl depracation warning

When running FactoryGirl.create_one or FactoryGirl.create_many, a warning like this is spit out:

DEPRECATION WARNING: Looking up factories by class is deprecated and will be removed in 5.0. Use symbols instead and set FactoryGirl.allow_class_lookup = false. (called from block in <top (required)> at /Users/bgoldberg/Documents/versus_platform/features/step_definitions/tournament_structure_steps.rb:2)

This is coming from /lib/active_cucumber/active_record_builder.rb:27:
def create_record attributes
  creator = @creator_class.new attributes, @context
  FactoryGirl.create @clazz, creator.factorygirl_attributes
end

because @clazz is a class name. This should simply be swapped out for a symbol, like:
FactoryGirl.create @clazz.name.underscore.to_sym, creator.factorygirl_attributes

This was addressed in #5. Are there any hold ups on doing a version bump now that #5 is merged in?


[12.x] Add missing methods to the Illuminate\Contracts\Container\Container interface

refresh($abstract, $target, $method)
rebinding($abstract, Closure $callback)

Proposed Changes
The changes have been made to the src/Illuminate/Contracts/Container/Container.php file, where the new methods have been added to the Illuminate\Contracts\Container\Container interface.
Potential Impact
These changes are intended to be backward-compatible and should not break existing code that relies on the Illuminate\Contracts\Container\Container interface. They provide additional capabilities that can be optionally utilized by developers.

Hey, you can't make changes to an interface on a minor release, because there could be apps which implement the interface and would not be confronted with a breaking change.
These changes can only happen in major versions (master branch).

@Jubeki Shall I change the base branch then? Or can you please suggest what I can do?

Yeah changing the base branch to master would be okay, because that would be the branch for the next major version 12.x

Hi @Jubeki, I've create another PR as you suggested.


Book space somewhere for September 26

Do this after #3

Official e-mail sent to Megah Hall @ Smile.io (305 King St).


security/acme-client: highest port number is limited to 49151 in SSH/SFTP automation

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[ ] I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md
[ ] I have searched the existing issues, open and closed, and I'm convinced that mine is new.
[ ] The title contains the plugin to which this issue belongs

Describe the bug
I want to configure an automation that run a remote SSH command. The max. port I can configure for the remote host is 49151. But I need a higher one.
Environment
Software version used and hardware type if relevant.
e.g.:
OPNsense 22.1.8_1 (amd64, OpenSSL).
Intel(R) Xeon(R) CPU E5645 @ 2.40GHz (4 cores, 4 threads)

@jkellerer Do you happen to know why the port number is limited to 49151? Is this an arbitrary limit or is there a valid reason? Thanks :)

@jkellerer, thanks for the quick response! Much appreciated.
This restriction will be removed in the upcoming release 3.12 of os-acme-client.


Springfox not working on payara 5

Hi
It seems that springfox isn't working when deployed to payara 5

[x] What version of the library are you using?

What kind of issue is this?

[x] Bug report.

How to reproduce:

Deploying springfox-petstore to payara 4.1 works
Deploying springfox-petstore to payara 5 doesn't work. I get the "Unable to infer base url ..." dialog.

Have never used Payara, so no idea sorry.

Payara is a web application server similar to Glassfish and Tomcat. In fact, it's a fork of Glassfish, which by the way, has the same problem when switching from version 4 to version 5.
I assumed springfox would work on any application server just as spring does.
Is springfox supposed to work only with spring boot?

@luStopai May be a little detail on why its not working would help. It appears to be a problem with not getting the right base url because of path mapping/ servlet context differences

Sorry but I have no idea on why its not working.
Since it works fine when deploying the webapp to payara 4 and it doesn't when deploying to payara 5, I guess there's nothing wrong with the webapp itself.
It seems that something changed in the new version of the webserver that is causing the issue, but I don't know what is it. Any idea on how can I find out?

Nevermind. I just tried the lastest nightly build of glassfish 5 and it works now. It seems it was a bug in both webservers. It's a matter of time that it gets fix in payara 5 too.

Thanks for reporting back @luStopai


[WIP] Collect/Collections/Collection use Analytics v2

Updates all rail events to use cohesion ClickedEntityGroup events (clickedCollectionGroup, clickedArtistSeriesGroup)
Removes click events on carousel arrows (not used in new schemas)
Converts RelatedCollectionsRail and RelatedCollectionEntity from class to React.FC
Removes tracking properties passed through @track decorator

TODO:

[ ] Explore options for adding context page data to context provider
[ ] Convert impression event to v2 schema
[x] QA with data-team

closing in favor of https://github.com/artsy/force/pull/6253


How to judge the loss of video stream

How to judge the loss of video stream？
When a browser video is closed, how do other browsers know that the video stream is closed？

i hope this can help
stream.onremovetrack = () => {
    try {
        const i = this.streams.findIndex((stm) => stm.id === stream.id)
        if (i !== -1) {
            this.streams.splice(i, 1);
        }
    } catch (error) {
        console.error(error)
    }
}


Deploy your app for free 🚀

Hey @SamarpanCoder2002, I'm just stopping by to say great work and to make a recommendation! Will you need to host your app in the future? If so, I'd highly recommend using DeeloCloud. It's built for developers, it's super easy to use, and you won't have to manage servers - which means you can focus on building!
Here's how it works in a few steps:
After signing up at https://deelo.cloud:
1.) Select the repo and branch where your app lives. In this case, it would be SamarpanCoder2002/Auth-Form-Design.
2.) Select the runtime template of the app you wish to deploy.
3.) Hit deploy. 🚀
4.) In a few minutes your app will be live.
5.) Each time you push code to your branch, your app will pick up the changes and re-deploy.
And boom, just like that you got yourself free hosting! Enjoy.

hey @deelobase thanks for informing me.... I will definitely try it... it looks good me...🥳


apidocs: Fix description of topic parameter in update_message.

The information of topic being required for stream messages
in update_message OperationID wasn't true. Fixed the
incorrect description.

Testing plan:
GIFs or screenshots:

Merged, after adding a bonus commit to further clarify how the topic and stream_id parameters work.  Thanks @MSurfer20!


Expand the Troubleshooting doc

Still WIP a bit, since I can't run Jekyll locally and so I can't preview what this looks like when rendered. Should be ready for copyediting, though.

Fixes https://github.com/pulumi/docs/issues/510

thanks!


error in run-asm-pipeline.sh

Hi ,
I ran 3d-dna for a fungal genome with the command: ./run-asm-pipeline.sh -r 2 fh140.pilon2.fasta aligned/merged_nodups.txt
I got error infomation as follows: awk: /stor9000/apps/users/NWSUAF/2010110076/software/3d-dna/edit/overlay-edits.awk:27: (FILENAME=fh140.pilon2.0_asm.scaffold_track.txt FNR=2) fatal: division by zero attempted
Do you know how I deal with the problem?
Thank you very much!

Hello JRW-ang,
Sorry, this by itself does not give me much to go on with. I don't remember seeing any errors from overlay-edits. Are you using the latest version? Is this the only error message?
Olga

Thank you so much! I re-downloaded the latest version, and the probelm have been solved.

Great! Good luck with your assembly. Best, -Olga


OSError: [WinError 126] The specified module could not be found

Attempting to execute the code results in the following:
PS C:\> python piptv.py
Traceback (most recent call last):
    File "piptv.py", line 4, in <module>
        import vlc
    File "C:\Users\xxx_000\AppData\Local\Programs\Python\Python37\lib\site-packages\vlc.py", line 207, in <module>
        dll, plugin_path  = find_lib()
    File "C:\Users\xxx_000\AppData\Local\Programs\Python\Python37\lib\site-packages\vlc.py", line 167, in find_lib
        dll = ctypes.CDLL(libname)
       File "C:\Users\xxx_000\AppData\Local\Programs\Python\Python37\lib\ctypes\__init__.py", line 364, in __init__
        self._handle = _dlopen(self._name, mode)
OSError: [WinError 126] The specified module could not be found

The following has been attempted:

Restart and attempting to go through the steps again
Download Python from the official site 3. Move the .py file to different directories
Download the file from https://github.com/schwifty42069/piptv/raw/master/piptv.py along with the original Github.
Updated my Net Framework
Updated VLC to the newest version

Alright, let's see what we can do. Is this windows 10?

It is indeed Windows 10

Can you try following this guide

If I remember correctly, it's a VLC issue that can be resolved if you follow that doc to the T

Did you forget to install the dependencies?

Not that I'm aware of, I've followed that doc when I first installed, just running through the steps again

Alright, let me know what happens after you follow that doc

Everything was running smoothly until
PS C:\WINDOWS\system32> choco install -y python3
Chocolatey v0.10.15
Installing the following packages:
python3
By installing you accept licenses for the packages.
Progress: Downloading python3 3.7.4... 100%

python3 v3.7.4 [Approved]
python3 package files install completed. Performing other installation steps.
Installing 64-bit python3...
WARNING: Generic MSI Error. This is a local environment error, not an issue with a package or the MSI itself - it could mean a pending reboot is necessary prior to install or something else (like the same version is already installed). Please see MSI log if available. If not, try again adding '--install-arguments="'/l*v c:\python3_msi_install.log'"'. Then search the MSI Log for "Return Value 3" and look above that for the error.
ERROR: Running ["C:\ProgramData\chocolatey\lib\python3\tools\python-3.7.4-amd64.exe" /quiet InstallAllUsers=1 PrependPath=1 TargetDir="C:\Python37" ] was not successful. Exit code was '1603'. Exit code indicates the following: Generic MSI Error. This is a local environment error, not an issue with a package or the MSI itself - it could mean a pending reboot is necessary prior to install or something else (like the same version is already installed). Please see MSI log if available. If not, try again adding '--install-arguments="'/l*v c:\python3_msi_install.log'"'. Then search the MSI Log for "Return Value 3" and look above that for the error..
The install of python3 was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\python3\tools\chocolateyInstall.ps1'.
 See log for details.

Chocolatey installed 0/1 packages. 1 packages failed.
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

Failures
 - python3 (exited 1603) - Error while running 'C:\ProgramData\chocolatey\lib\python3\tools\chocolateyInstall.ps1'.
 See log for details.

I presume that this is because I had python previously installed?

Most likely. If you have a working installation of python3 you should be good. Try to type python --version in a cmd and see if it spits the version number back

3.7.4

Perfect. Also, redo the installation of the dependencies with pip install -r requirements.txt in the directory you have piptv

Installed all the pip's, just going to run python piptv.py now and see if it errors out again

Error again, I'm going to attach a screencap of the powershell for you

Your pip install for python is incorrect.
 WinError 126?

Yep. I'll run through everything yet again though, just as a precaution.

 Are you in the directory where piptv is? Type dir and see what it says

I switched to the directory where Piptv is after step 5, like the instructions said. But I'll try again from that directory

Sorry about this.  I will walk you through that one if we can't get this to work. It uses the same scraper logic and formats a pretty m3u, but doesn't use the vlc python bindings, so you can just manually play the m3u it generates in vlc

126 error again, and even ran it from the folder with all the files in the Github, I'll try that other file you mentioned. Not sure what the hell is the matter. Might be missing some file somewhere in my OS

Yeah I saw this error with another person but following the aforementioned doc resolved it. Go ahead and clone the piptv-plex repo and I will walk you through it.

There is a config folder in the repo that contains a config.properties file. Change the dir= key to the directory you want the m3u to be written to, including its name.
For example:
dir=C:\Users\Me\m3u_folder\piptv.m3u

Then you can just run the script and wait, it takes about a minute and a half and is quiet (no output in the console) You should already have the dependencies you need

I'm running Plex off of an external server, does this look right?
dir=F:\Movies\TV\Live TV/m3u/piptv.m3u

Yeah, I'm not sure it will work correctly in plex yet. A buddy and I are working on documenting the process to make it work like butter, but you can try it. If it doesn't work in plex, it will most definitely work in vlc.

Whoa you have back and forward slashes in your directory though. Is that intentional? I am an all Linux guy so Windows isn't my strong suite haha

I don't think it is, but it works, so I'm not going to mess around with it lmao

just running it now in powershell

Alright let me know what happens.

Still waiting, oddly enough
PS C:\Users\natha_000> cd F:\piptv-plex-master
PS F:\piptv-plex-master> python piptv-plex.py

I believe that's what I'm supposed to do

Yeah it takes a bit, it has to send, process, and parse 82 requests, and then assemble all the data and write it to a file. The first part takes a bit.

PS F:\piptv-plex-master> python piptv-plex.py
Traceback (most recent call last):
  File "piptv-plex.py", line 97, in <module>
    main()
  File "piptv-plex.py", line 92, in main
    mw.initialize_m3u_file()
  File "piptv-plex.py", line 73, in initialize_m3u_file
    with open(write_dir, "w") as writer:
FileNotFoundError: [Errno 2] No such file or directory: 'F:\\Movies\\TV\\Live TV/m3u/piptv.m3u'

Okay, so your goofy path is wrong.

I'll throw it on my desktop then, my apologies

Just try to write it to the directory the script is in

so it would be:
dir=piptv.m3u

haha no worries man. I just want people to use it and enjoy it. I slapped these together real quick as soon as I figured out the scraping logic

Should work this time lol. Changed the directory in the config file, and ran it with no weird slashes
PS C:\WINDOWS\system32> cd C:\Users\natha_000\Desktop\piptv-plex-master
PS C:\Users\natha_000\Desktop\piptv-plex-master> python piptv-plex.py

Alrighty, fingers crossed. I would test it in vlc first after it completes. Then see if you can get plex to run it. We will have a well documented process soon for plex. Also, the auth tokens only last 6 hours, so you will need to rerun it before then. We are gonna have a guide to setup a cron job to automate it.

Also, I think I remember the source of the issues of the regular piptv script, I think it's an architecture mismatch. So you probably have 64bit Python and 32bit VLC or vice versa.

I can check that, I presume that I installed 64 python and 64 VLC, as I'm on a 64 bit OS, but let me check that for you

Freaking python vlc bindings are such a pain -_-
At least there's the other script, which I think I am going to integrate with the original

I can believe it. I have 64 bit Python, and am doing a fresh install of VLC, I'll see if that clears up the issue, once this Plex one is done running.

Aha, so it was an issue with VLC's version.

Also, I don't know if you're a football fan, but I am posting HLS links for all the games tomorrow, and I am working on a script to aggregate all the streams from r/nflstreams for a one touch stream of every game. If you haven't already, you should sub to r/hlsvillage

Nice! Hell yeahhhh
Make sure the other script works too

I think the colors will correct themselves after you tune to a channel. Something with windows 10 vtx100 virtualization makes the color codes whacky at first.

So now you know, if you have that error again with someone else, to try checking VLC. I will also try the Plex version as well. I'm not really a football fan aside from the Superbowl lol.

 ;D hahaha
Yeah let me know if that works, and if all is well I will close this up

I knew it was a vlc issue I just couldn't remember the specifics. I have been putting out fires all over today my brain is scrambled haha

Haha, I don't have a favorite team per se, I just pick one at random and cheer for them. I have an m3u file now, I presume I just throw it in VLC?

Yes sirrrr. Make sure it works.

Yep, I've got football, not sure how to change the channel

click the little list button on the bottom of the player, you will see all the channels

Yep, tried 4 channels at random, they all seem to work. Thank you so much for taking the time to help out sir/madam.

 Just glad it's working. Have a great night!


any example to find and download files in kademlia?

I want to build a website that search and download files in kad network, like search files in emule, but I almost know nothing about kad.
I need some code examples that find and download files in kad.

Hey @niceday345 - this library is likely too lowlevel for what you're looking for (it stores binary blobs with a max size, you'd have to break a file apart into a merkle tree etc yourself if you want to store files).  I recommend looking at IPFS.


Tutorial Exercise L1.1: Why do we have to make this calculation?

Why do we have to make the following calculation?

Hello Johannes.
Honestly, I think you are referring to the solution of last year and not the current one.
However, I believe the calculation was posted just to give an alternative to those who struggle to compute derivatives of matrices.

Yes, exactly. Because I can't attend the tutorials each week. Thank you!


"watchlist" feature for admins that allows notes to be placed by a player for future ref by other admins for assessing intent, consistent behavior, etc.

We could include praise too, doesn't have to be too big brother-ish! :D

1c20a29. Keeping this open to remind me to add my notes from existing file when it is on prod.

Added existing notes, closing.


How to get last value before update?

I have many Spinbox on screen. I need get last value before change. How i make this?

Typically, you'd have a view model, controller, or such that implements this sort of application-specific logic.


Allow DurationType as scalar type for arrays

Summary
This PR allows for array types with duration scalars.
I don't know whether the previous omission of DurationType was intentional or not. However,

There does not appear to be any discussion in the spec explicitly restricting the set of scalar types. So I think this should be syntactically valid, even if particular implementors do not currently support it.
We  allow for loops over durations, e.g. for duration delta in {0us, 1.0us, 2.0us, 3.0us} { ... }. Currently the parser handles via a special rule for set expressions, but the spec indicates  that this is array-literal syntax. There's no reason, in principle, why we should accept this but reject the equivalent where a user declares a duration array and loops over the index range.

By the same argument, we should include stretch as an allowed data type as well, but I think that's relatively clearly never going to be valid in any implementation.  Perhaps we can update the text of the spec to explicitly spell out the allowed types (definitely excluding stretch), while we're at it?

@jakelishman I've updated the spec to list allowed and disallowed array base types.


Quantity unit purchase Red

For some reason Quantity unit purchase  and Quantity unit stock are red and im unable to change it at all.

Have you added any quantity units (Manage master data/Quantity units)?

Yeah, I just saw it on the demo ago called Quantity units. All good, sorry about that.

👍, no problem. :)


Consider adjustments to sizes to default to whole numbers

Should the sizing open-props provides default to whole numbers.   While I think for the most part the do, but there are a couple places where they don't.
For example in Typography.
There is a "font-size" of 1.1rem.  at the default 16px this calcs to 17.6px.  A font size of 1.125 would give an 18.
I believe this exists on line height as well.  there is a 1.1 but that isn't rem and is relative to the actual font size of the element itself.  So maybe not as much of an issue.
Anyway, maybe I am a bit old-school and sub-pixels aren't much a thing to care about anymore.  But if it is something that we wanted to look at I would be happy to see if there are any other places it comes up. Although, any changes would effect peoples currently using the sizes, that is likely a bigger problem.

Maybe this only exists in the font sizing as well, which also might not be a big deal since fonts aren't really in whole pixels themselves.

i could see wanting to avoid sub pixel sizes, makes sense! consider just overwriting them individually with your own exceptions?
/* don't have to specificity fight, just set a new value */
:root {
  --font-size-2: 1.125rem;
}

i could see wanting to avoid sub pixel sizes, makes sense! consider just overwriting them individually with your own exceptions?
/* don't have to specificity fight, just set a new value */
:root {
  --font-size-2: 1.125rem;
}

This is the route I am taking now, just was wondering if this was worth looking into on the defaults. ;)  but I suppose making changes like that to the defaults wouldn't be ideal.  I will search for other ways to contribute, lol.

i'd strongly consider a PR btw 🙂
i mean, it's a small change, may go unnoticeable to devs and users alike, but perhaps the engine will appreciate it. it sounds more deliberate than what i've done here, which is nice! are there others than could benefit from a similar adjustment?


Add-Type should not fail when default referenced assemblies are specified with -ReferencedAssemblies

This regression got introduced with #3556. This impacted the functionality of PowerShellGet module in PowerShellCore beta1 release (https://github.com/PowerShell/PowerShellGet/issues/125).
I think, Add-Type should ignore -ReferencedAssemblies if that is not applicable on PowerShellCore.
Add-Type should still support -ReferencedAssemblies for assemblies which are not referenced by default in PowerShellCore.
This impacts all PowerShell Script modules which uses Add-Type with -ReferencedAssemblies. Please ensure that this is not another SemanticVersion related issue in PowerShellCore for 2 part version comparison with $PSVersionTable.PSVersion .
Repro
$requiredAssembly = @([System.Management.Automation.PSCmdlet].Assembly.FullName)
$source = @"
namespace Microsoft.PowerShell.Commands.PowerShellGet
{
     public static class Telemetry
     {
         public static void TraceMessageArtifactsNotFound(string[] artifactsNotFound, string operationName)
         {
             Microsoft.PowerShell.Telemetry.Internal.TelemetryAPI.TraceMessage(operationName, new { ArtifactsNotFound = artifactsNotFound });
         }

         public static void TraceMessageNonPSGalleryRegistration(string sourceLocationType, string sourceLocationHash, string installationPolicy, string packageManagementProvider, string publishL
ocationHash, string scriptSourceLocationHash, string scriptPublishLocationHash, string operationName)
         {
             Microsoft.PowerShell.Telemetry.Internal.TelemetryAPI.TraceMessage(operationName, new { SourceLocationType = sourceLocationType, SourceLocationHash = sourceLocationHash, InstallationP
olicy = installationPolicy, PackageManagementProvider = packageManagementProvider, PublishLocationHash = publishLocationHash, ScriptSourceLocationHash = scriptSourceLocationHash, ScriptPublishLocat
ionHash = scriptPublishLocationHash });
         }
     }
 }
"@

Add-Type -TypeDefinition $source -Language CSharp -Verbose -PassThru -ReferencedAssemblies $requiredAssembly

Expected Behavior
Add-Type runs successfully, like it does in alpha.18.
Actual Behavior
Add-Type : (1) : Missing compiler required member 'System.Collections.Generic.EqualityComparer`1.Equals'
(1) : >>> namespace Microsoft.PowerShell.Commands.PowerShellGet
(2) : {
At line:1 char:1
+ Add-Type -TypeDefinition $source -Language CSharp -Verbose -PassThru  ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidData: (Microsoft.Power...peCompilerError:AddTypeCompilerError) [Add-Type], Exception
    + FullyQualifiedErrorId : SOURCE_CODE_ERROR,Microsoft.PowerShell.Commands.AddTypeCommand

Add-Type : (1) : Missing compiler required member 'System.Collections.Generic.EqualityComparer`1.GetHashCode'
(1) : >>> namespace Microsoft.PowerShell.Commands.PowerShellGet
(2) : {
At line:1 char:1
+ Add-Type -TypeDefinition $source -Language CSharp -Verbose -PassThru  ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidData: (Microsoft.Power...peCompilerError:AddTypeCompilerError) [Add-Type], Exception
    + FullyQualifiedErrorId : SOURCE_CODE_ERROR,Microsoft.PowerShell.Commands.AddTypeCommand

Add-Type : (1) : Missing compiler required member 'System.Collections.Generic.EqualityComparer`1.get_Default'
(1) : >>> namespace Microsoft.PowerShell.Commands.PowerShellGet
(2) : {
At line:1 char:1
+ Add-Type -TypeDefinition $source -Language CSharp -Verbose -PassThru  ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidData: (Microsoft.Power...peCompilerError:AddTypeCompilerError) [Add-Type], Exception
    + FullyQualifiedErrorId : SOURCE_CODE_ERROR,Microsoft.PowerShell.Commands.AddTypeCommand

Add-Type : Cannot add type. Compilation errors occurred.
At line:1 char:1
+ Add-Type -TypeDefinition $source -Language CSharp -Verbose -PassThru  ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidData: (:) [Add-Type], InvalidOperationException
    + FullyQualifiedErrorId : COMPILER_ERRORS,Microsoft.PowerShell.Commands.AddTypeCommand

Environment
Name                           Value
----                           -----
PSVersion                      6.0.0-beta
PSEdition                      Core
BuildVersion                   <IP_ADDRESS>
CLRVersion
GitCommitId                    v6.0.0-beta.1
OS                             Microsoft Windows 10.0.14393
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Solution/Workaround
Add-Type now implicitly include all netcoreapp2.0 reference assemblies and System.Management.Automation by default with -ReferenceAssembly is not specified. So running Add-Type without -ReferenceAssembly will work.

[Move discussion comments from MSTeam to Github]
Add-Type can be made smarter to do better choice about what explicitly given reference assemblies to ignore and what to included implicitly. The user probably should be notified that the ignored ref assemblies are not necessary, probably through a warning message.

The problem we need to solve (or at least mitigate) is to avoid requiring conditional logic about how to specify -ReferenceAssembly parameter when using Add-Type cross Windows PowerShell and PowerShell Core. Ideally, a single set of arguments for -ReferenceAssembly should work on both Windows PowerShell and PowerShell Core.

@daxian-dbw It seems you already fixed the Issue.

@iSazonov If I remember it correctly, running Add-Assembly with the same script may require different reference assemblies on Wndows PowerShell and PowerShell Core, so a conditional logic is needed if Add-Type is needed for a module targeting both Windows PowerShell and PowerShell Core. This issue is for solving or mitigating that problem.

@daxian-dbw Thanks for clarify! The repo and workaround from the Issue don't work now. Have you new repo?

@iSazonov I have updated the repro steps in the issue description. It should demonstrate that the same script runs on Windows PowerShell but fails on PowerShell Core.

@daxian-dbw Thanks for the update!
If we remove -ReferencedAssemblies the code works on both versions - so the reference on the assembly is not mandatory for Windows PowerShell. The error is because required assemblies is missing from this list -ReferencedAssemblies. If replace s_autoReferencedAssemblies.Value with s_defaultAssemblies.Value in the line the Issue is resolved. If it is a right fix I can add it to my fork  where I work on SyntaxTree integration.

@iSazonov The repro is just a demonstration, there could be other examples which you can come up with yourself once leaned the code that causes the issue.
If I remember correctly, you will also need to resolve the conflicts between what are specified by the user with -ReferenceAssemblies and the default references we use. The default ones are pointing to the reference assemblies in the /refs folder. If the user specify a dll path points to the runtime dll, you may get ambiguous type identity or other issues during the compilation. But sometimes it's OK to use a runtime dll path so that you can use types that are not included in the reference dlls that we include (we only include the standard .NET Core 2.0 reference assemblies, but say you want to use Json.net.dll).
Currently, we include the default references (all .NET Core 2.0 ref assemblies) only if -ReferenceAssemblies is not specified. It will be tricky if you want to always include them.


Prepare data for AR Reminder batch job to be sent on Aug 14th AR Reminder email

Here's a link to the columns needed for loading business data manually into [BAR](https://docs.google.com/spreadsheets/d/1DOEBBmEay1Vtn2hdcZi13Yl8J-mQgzN7y-IfItGnPmY/edit?usp=sharing
Please move to the appropriate place for the team)

@ozamani9gh can this tix now be closed?


updateStyle called after FINISH event

This issue was imported from Closure Library's previous home at http://closure-library.googlecode.com
The link to the original issue is:
https://code.google.com/p/closure-library/issues/detail?id=299

This issue is being closed as a preparation step before archiving the repository.  See the README for more detail.


Fix prepare-assets.sh script for antrea-octant.yml

The wrong Docker image was used because the IMG_NAME environment
variable was not set properly before generating the manifest.
Fixes #607

/skip-all


Skip tests that depend on OpenAI via --skip-openai

Allows skipping test that depend on OpenAI. It is possible to run the whole test suite with openai dependency installed via pytest test --skip-openai (previously it was required to uninstall openai lib to run tests that don't interact with LLM).
Related issue number
Partially closes #1088
Checks

[x] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[N/A] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[x] I've made sure all auto checks have passed.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (75fc278) 30.14% compared to head (faf885a) 20.02%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1097       +/-   ##
===========================================
- Coverage   30.14%   20.02%   -10.13%
===========================================
  Files          30       30
  Lines        4020     4020
  Branches      908      957       +49
===========================================
- Hits         1212      805      -407
- Misses       2729     3098      +369
- Partials       79      117       +38

Flag
Coverage Δ

unittests
19.97% <ø> (-10.13%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Does not work with our druid installation

The UI is stuck on 'loading'
http://screencast.com/t/5HGTLH06RS
I see this msg in the browser console:
http://screencast.com/t/4U66Yadml

I am happy to show you our installation privately if that will help debug this issue

Interesting... let me look into this.

I think I found the problem. That error happens if one of your measures come back as a NaN. Which should not really happen. Even if a NaN does happen it should not crash everything like it did for you.
I am going to fix this and release in like an hour or two.
Meanwhile I would also like to determine what was producing those NaNs.  I suspect that pivot was trying to so a SUM(some_hyper_log_log_measure) could you please start pivot again as you did before and see what measures you have selected? Are any of them some sort of fancy sketch or HLL?
This issue will be closed when I fix the NaN thing but please still comment if any of the measures are interesting.

This is still present.
Using latest version:
root@druid-pivot:/home/prashant# npm list -g imply-pivot
/usr/local/lib
└──<EMAIL_ADDRESS>
The UI hangs right on hitting the root url. I havent even gotten a chance to add any measures or interact with it at all

hmmm. ok reopening.

if you want I can do a screenshare with you later today to help figure this

Could we screenshare some time tomorrow (Thursday)? I would love to get this fixed.

ok. I can even do right now if you want
On Wednesday, October 14, 2015, Vadim Ogievetsky<EMAIL_ADDRESS>wrote:

Could we screenshare some time tomorrow (Thursday)? I would love to get
this fixed.
—
Reply to this email directly or view it on GitHub
https://github.com/implydata/pivot/issues/46#issuecomment-148275527.

--
Prashant

I can not do today, but let's find a time tomorrow :-)

how about now?

I am ready whenever. Not sure how we should do this... Maybe Google hangouts

my email is vadim [at] imply.io for hangouts e.t.c

i just sent u a hangouts invite.

trying to connect

Just to update the thread: @pdeva and I have chatted over hangout and I now understand the issue. This will be fixed today.
Thank you @pdeva

waiting for a fix so I can use pivot

Hi, Sorry I forgot to update this issue. Please try again with the latest pivot. It should not crash on initial load. Going to close the issue for now but if it still crashes I will reopen.
For the best experience you will still want to define your datasources inside the config.yaml auto introspection can only do so much (it will greatly improve in Druid 0.8.2)

while 0.4.24 does not crash on initial load, adding just 1 dimension on 'split' caused to throw the same error again.
Screenshot:
http://screencast.com/t/xyY31IvEOs

Could you try now please. It should no longer crash.
The "Min" and "Max" measures are problematic and should now show -.
Could you please tell me more about them? What are they in Druid?
Also log term the solution for you is to define this datasource explicitly in the config.yaml that way the min and max measures can be defined correctly.

ok, while it works now, the layout is stil broken.
http://screencast.com/t/PksQuQsQyZ5
a way to resize the column and/or truncate the amount of decimal places might help..
As for min and max, they hold the 'min' and 'max' values of a row respectively.
We sometimes pass Long.MaxValue to min in cases when there is no value.

also i see some cells have 0.0.t as value. what does t stand for here?
also you should consider making the 'b' and 'm' capital.

I am glad to hear that it is finally working, it took some iterations but the code is a lot more robust now.
In the screenshot you sent the layout looks to be behaving as intended, the long numeric values are caused by a pivot misconfiguration.
0.0 t stands for 0.0 trillion. The min and max columns are treated by pivot like sums because there is no way for it (in druid < 0.8.2) to detect what is the underlying agg. Please define them as $main.min($min) and $main.min($max) in config.yaml.
I think making T, B, M capitals is a capital idea.


Unsupported HTML (iframe)

Are there certain HTML elements that are not supported? I am trying to embed a PowerPoint presentation which is embedded using an <iframe>. Assuming this is intentional, could the article include a list of non-supported HTML elements?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 29f1e43f-a069-dd88-7fc7-9cc497fb94f0
Version Independent ID: c261afa7-6eb7-b3f0-9f92-6d2f3c5ac336
Content: Markdown syntax for wikis in Azure DevOps - Azure DevOps
Content Source: docs/project/wiki/wiki-markdown-guidance.md
Product: devops
Technology: devops-collab
GitHub Login: @chcomley
Microsoft Alias: chcomley

@squalrus -- Chad, thank you for your question.  There are many HTML tags, and it would be more complete to specify those that are supported than those that are not.
@chcomley -- Chrystal, please look into this issue.

Hi @squalrus, I have to agree with William that listing the HTML tags that are supported is our goal. I invite you to submit a feature request for supporting this, however. Please go here to do so: https://developercommunity.visualstudio.com/spaces/21/index.html, and then select Suggest a feature. Thank you for your feedback!

Vote here for iframe: https://developercommunity.visualstudio.com/content/idea/608314/allow-iframe-elements-to-be-embedded-in-wiki-pages.html


Why you don't use VS Code API for search of package?

VS Code API (language-server) provides a useful API for searching local or global package.

But it's a must do during initialization, so as not to look for a module every time.

For example:
const { Files } = require('vscode-languageserver');

connection.onInitialize((params) => {
  workspaceDir = params.rootPath;
  return Files.resolveModule(workspaceDir, 'pug-lint')
    .then((Linter) => {
      linter = new Linter();

      return {
        capabilities: {
          textDocumentSync: documents.syncKind
        }
      };
    })
    .catch(() => {
      const res = {
        code: 99,
        message: 'Failed to load pug-lint library. Please install pug-lint in your workspace folder using \'npm install pug-lint\' or globally using \'npm install -g pug-lint\' and then press Retry.',
        options: {
          retry: true
        }
      };

      return Promise.reject(new ResponseError(res.code, res.message, res.options));
    });
});

It seems to me that keep Linter in the package - it's a bad idea. For example, in my extensions Linter is installed separately:

https://github.com/mrmlnc/vscode-puglint (with File method: https://github.com/mrmlnc/vscode-puglint/blob/068bf071c80e8e36dcb11c43d29bfdd326561a05/server.js#L227-L250)
https://github.com/mrmlnc/vscode-autoprefixer
https://github.com/mrmlnc/vscode-doiuse

If you don't want to use the built-in API, you can use my package :sweat_smile:.

https://github.com/mrmlnc/npm-module-path

It seems to me that keep Linter in the package - it's a bad idea

Depending on user-installed packages is even worse idea.

@shinnn can you expand on why you think it is a bad idea? Not being hostile, just want to know your views. Because now vscode's eslint plugin also can depend on the user-installed package. And it is very helpful, as a user can have different settings per project.

I have a definite answer for this question and will comment it on https://github.com/shinnn/vscode-stylelint/issues/4 when I have time.
@mrmlnc Sorry, https://github.com/shinnn/stylelint-vscode/issues/2#issuecomment-236482684 was a bit offensive.

@shinnn why did you delete all the discussion in the other issue? We were just offering suggestions here.

@kumarharsh I do just what I want to do. The project owner is me.

@shinnn you could avoid a lot of being bothered and having your time wasted with the exact same issue and derivatives of #8 if you would just comment why you think its a bad idea to have an option to override with the project folder's stylelint.


Update fs2-core, fs2-io to 3.2.5

Updates

co.fs2:fs2-core
co.fs2:fs2-io

from 3.2.4 to 3.2.5.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "co.fs2" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Codecov Report

Merging #622 (2bcdb60) into master (08cfd7e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #622   +/-   ##
=======================================
  Coverage   62.54%   62.54%
=======================================
  Files          39       39
  Lines        1303     1303
  Branches        7        7
=======================================
  Hits          815      815
  Misses        488      488

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08cfd7e...2bcdb60. Read the comment docs.


Modal: Support disabling the "Close on click outside of modal"

Modal should support disabling hiding the modal when user clicks outside the modal. This is useful when we are dealing with complicated form and we don't want user to lose the work if they accidentally clicks outside the modal.

If I have to take a look at this, how do I go about? Can you please give me some pointers.

Appreciate you separating this from the other Modal issue.  I'd merge this PR as well.  How about:
<Modal closeOnClickOutside />
<Modal closeOnEscape />

Propose we default these to true as well.

First, follow the CONTRIBUTING.md to get setup and understand the basics.  Then,
Modal.js
  handleHide = () => {
    debug('handleHide()')
    // Always remove all dimmer classes.
    // If the dimmer value changes while the modal is open,
    //   then removing its current value could leave cruft classes previously added.
    document.body.classList.remove('blurring', 'dimmable', 'dimmed', 'scrollable')

    // == START PR == //
    // wrap these in if conditionals based on the proposed props above
    document.removeEventListener('keydown', this.handleDocumentKeyDown)
    document.removeEventListener('click', this.handleClickOutside)
    // == END PR == //
  }

See // == START PR == // comment above.  Then also add/update tests in test/modules/Modal-test.js.

Also, only remove the body classes if the modal actually closed.

Got it. Thx.


x/mobile/cmd/gomobile: init fails with go1.5.x

Edit: Sorry, Pressed Publish before writing anything :stuck_out_tongue_closed_eyes:
Anyways, today, I got around installing go/mobile, I followed the instructions, called go get ... and dowloaded the basic example, and ran gomobile init, that resulted in an error, as in:
user@Terminal-T61:~/Go/src/terminal/admin/core$ gomobile init
gomobile: go install -p=2 -gcflags=-shared -ldflags=-shared -pkgdir=/home/user/Go/pkg/gomobile/pkg_android_arm std failed: exit status 2
# runtime
flag provided but not defined: -shared
usage: 5g [options] file.go...
/* etc ... */

I don't really know how to fix it, I'm using go1.51 and go env echoes.
  Check your PATH.

I met the same problem. Modify the source code of gomobile/init.go as following:
//if err := installStd(androidArmEnv, "-gcflags=-shared", "-ldflags=-shared"); err != nil {
if err := installStd(androidArmEnv); err != nil {

Recompile gomobile command and try again.

@ianlancetaylor
malek@Terminal-T61:~$ go version
go version go1.5.1 linux/386
malek@Terminal-T61:~$ echo $PATH
/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/usr/lib/go/bin:/home/user/Go/bin

I will revert https://go-review.googlesource.com/#/c/16912/ for now.

@xuwaters suggestion worked for me, i edited gomobile/init.go, then I put in
sudo apt-get install gcc
sudo GOPATH=/home/user/Go go install -a golang.org/x/mobile/cmd/gomobile

And it worked!

/cc @crawshaw


Fixed bug when setting username in openIdStrategy.

Fixed bug when setting username in openIdStrategy.
Instead of firstname we have to set username for existing user, the way as we do for new user.
Type of change
Please delete options that are not relevant.

[ X] Bug fix (non-breaking change which fixes an issue)

Thank you! Looks related to #686 and had to do a double-take to make sure which line got changed, since I remember seeing this before.

Does it need a ; at the end of the line instead of a , ?

yes, you are correct, I will update the pull request


EKS delete modal UI issues (session token)

Version - 2.1.2 rc5 ui tag 2.1.8
Steps to reproduce (least amount of steps as possible):

Create eks cluster with session token
Once it's active select delete from it's menu

Result:

[x] Change Update Token button to Delete

[x] Add red * to fields to indicate they are required.

Version - 2.1.2-rc7 & master
Verified fixed


[ja] Improve Japanese expression in Kubernetes object management

Why

To help Japanese readers understand the documentation more easily and precisely.

What

however the user does not define the operations to be taken on the files.  (https://kubernetes.io/docs/concepts/overview/working-with-objects/object-management/#declarative-object-configuration)

The operation is not something written in a file but specified in command. Thus, I'd like to change in the following way:

Before: しかし、ユーザーは操作内容をファイルに記載しません。
After: しかし、ユーザーはファイルに対する操作内容を指定しません。

Thanks for this PR @nakamasato! It's great to see folks helping with this kind of improvement.

/approve

/lgtm
Nice update for Japanese :smile:


[#noissue] feat: timeline v3

feat timeline on v3 UI
Additional features to be updated later

search
link to calltree
display time and axis

will merge this after 3.0.0 release


How to change the distance of the outside label

Hi,
I need to change the distance of the outside label because the label is too close to the lice.

Regards

please try textMargin


Adding appropriate favicon to the website

Is your feature request related to a problem? Please describe.
currently, this website is showing the  default nextjs  favicon

Describe the solution you'd like
I would like to add a more appropriate favicon to the website.
Describe alternatives you've considered
No response
Additional context
Can you please assign this issue to me under gssoc'23? So that I can start working on it.

#117


Add MongoDB _Id validation routine

Various places need to have a check that the _id request in certain request APIs are correct and match the regex expression or not.

I am working on it.


fix typo

@hezhizhen
hi its a typo from another of my repo
https://github.com/yihong0618/github-readme-stats
can you open a PR for that? thanks.

and just found all my language is a typo.....

and just found all my language is a typo.....

Correct. https://github.com/yihong0618/github-readme-stats/pull/12

FYI, you can use https://github.com/crate-ci/typos CLI to quickly find some typos.


support chunked encoding/streaming

Unless I get something very wrong, vulcans (or oxy?) currently doesn't support streaming proxied responses. Oxy even seems to explicitly buffer chunked responses and flush them in one go to the original client.
What is the rationale behind that? Is there a specific reason, why you chose not to support chunked responses?
What would be the best way to support chunking in vulcand? It seems, like a custom middleware won't work here.

+1

:+1:

I originally impelemented it this way because it reduces load and risk for backend services - with vulcand they are guaranteed to get the same request with well defined length and makes it more predictable as backend services will be talking on local network, not through the internet.
However I understand that some use-cases may need the opposite behaviour, so PR's are welcome :) This should be a parameter for a fronted turning this feature off in Vulcand and Oxy.

I made the relevant change in Oxy here: https://github.com/vulcand/oxy/pull/45
The vulcan change is here: https://github.com/vulcand/vulcand/pull/292
I posted a sample go app, which should allow you to create a local chunking endpoint to test against.


C# Reference in a Inherited Scene breaks (Null or Disposed)

Tested versions

Reproducable in 4.3stable, 4.4dev4

System information
Windows10
Issue description
I have following Nodes:

ActorBase : Node2D
ActorFarmer: Actor
and some Child Components

I create a Scene where the base node is an "ActorBase". I reference this in child nodes.
I create a Inherited Scene from the "ActorBase" Scene. Instead of the ActorBase Script I add an "ActorFarmer".
All references are still present in the Editor when I click the revert Button. When I start the game the Reference to the Actor is null or disposed.
When I dont set the reference in the Base Scene and directly in the Inherited Scene, I dont get the issue.
https://github.com/user-attachments/assets/488dff6b-308c-4fb2-838c-ae4c3a119ede
Steps to reproduce

Create a Base Class
Add References to other Nodes
Inherit from the Base Class
Create a Base Scene
Drag the references to the Base Class
Create a Inherited Scene from the Base Scene

Minimal reproduction project (MRP)
When you run the MRP, you can run on the remote tab. Then click for example on AnimationPlayer2d, then you get an ObjectDisposed Exception.

InheritanceBug.zip

Happy to see this issue is already reported, I'm having the same issue using a Character class with another scene inheriting from it, with a C# class inheriting from Character.
Sad to see there hasn't been a response yet, so with commenting I hope I can bump this up!
I regret to announce that I don't have enough experience in the lower levels of the code in Godot to be sure enough to fix this, however I'll try to look into it. From the errors that I see reported in the console, my (uninformed) guess would be that GodotObject seems to cache the pointer it uses to call the actual engine code.
For completeness sake:
E 0:00:05:0170   GodotObject.base.cs:78 @ nint Godot.GodotObject.GetPtr(Godot.GodotObject): System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'QuakeRPG.Actor.Character.Character'.
  <C# Error>     System.ObjectDisposedException
  <C# Source>    /run/build/godot-tools/modules/mono/glue/GodotSharp/GodotSharp/Core/GodotObject.base.cs:78 @ nint Godot.GodotObject.GetPtr(Godot.GodotObject)
  <Stack Trace>  GodotObject.base.cs:78 @ nint Godot.GodotObject.GetPtr(Godot.GodotObject)
                 CharacterBody3D.cs:594 @ bool Godot.CharacterBody3D.IsOnFloor()
                 MovementComponent.cs:27 @ void QuakeRPG.Components.Actor.MovementComponent._PhysicsProcess(double)
                 Node.cs:2389 @ bool Godot.Node.InvokeGodotClassMethod(Godot.NativeInterop.godot_string_name&, Godot.NativeInterop.NativeVariantPtrArgs, Godot.NativeInterop.godot_variant&)
                 Node3D.cs:1071 @ bool Godot.Node3D.InvokeGodotClassMethod(Godot.NativeInterop.godot_string_name&, Godot.NativeInterop.NativeVariantPtrArgs, Godot.NativeInterop.godot_variant&)
                 QuakeRPG.Components.Actor.MovementComponent_ScriptMethods.generated.cs:102 @ bool QuakeRPG.Components.Actor.MovementComponent.InvokeGodotClassMethod(Godot.NativeInterop.godot_string_name&, Godot.NativeInterop.NativeVariantPtrArgs, Godot.NativeInterop.godot_variant&)
                 CSharpInstanceBridge.cs:24 @ Godot.NativeInterop.godot_bool Godot.Bridge.CSharpInstanceBridge.Call(nint, Godot.NativeInterop.godot_string_name*, Godot.NativeInterop.godot_variant**, int, Godot.NativeInterop.godot_variant_call_error*, Godot.NativeInterop.godot_variant*)

Maybe we could work together to fix it

As a work around, I was able to use Owner as CharacterBody3D to reference the Character itself, which works for my specific scene setup.
I'm very open to working together to solve this. The error originates from here: https://github.com/godotengine/godot/blob/fd4c29a189e53a1e085df5b9b9a05cac9351b3ef/modules/mono/glue/GodotSharp/GodotSharp/Core/GodotObject.base.cs#L90
My guess was right that there's a pointer which is cached, I haven't looked into where it is set on constructing a class...

I don't have the code local to debug, but from what I can gather from the commit f88d8902cfc0d6a9441e794eb47611ef4ed0d46c, it seems that it's not necessary to throw the exception anymore, as the commit efd5d4bcf9fc15a92ef40e3f6edb185d190cd50e (5 years ago) introduced the line and the first referenced commit states

The only solution I can think of so far is to keep a list of all instances alive to dispose when the AssemblyLoadContext.Unloading event is raised.

which I think is already implemented, based on usage of DisposablesTracker and looking at https://github.com/godotengine/godot/blob/f88d8902cfc0d6a9441e794eb47611ef4ed0d46c/modules/mono/glue/GodotSharp/GodotSharp/Core/DisposablesTracker.cs#L15
which disposes the objects here
https://github.com/godotengine/godot/blob/f88d8902cfc0d6a9441e794eb47611ef4ed0d46c/modules/mono/glue/GodotSharp/GodotSharp/Core/DisposablesTracker.cs#L31

@neikeq I'm sorry for the ping, but I was wondering if my assumption could be correct?

The exception is thrown when trying to get the pointer for a GodotObject that has been disposed. Removing this check would allow accessing a freed pointer which will crash the engine.
Also, the two commits you mentioned are unrelated:

https://github.com/godotengine/godot/commit/efd5d4bcf9fc15a92ef40e3f6edb185d190cd50e adds the check to prevent returning freed pointers.
https://github.com/godotengine/godot/commit/f88d8902cfc0d6a9441e794eb47611ef4ed0d46c implements DisposablesTracker to keep track of instances that need to be disposed when unloading the assembly.

There's other reasons why the object could have been disposed. You could have disposed it yourself by calling .Dispose() manually or through the using statement. It also may have been freed by the engine (on the C++ side).
In this particular case, because of how inherited scenes are instantiated, the nodes in the scene are referencing an instance that is disposed. The base scene (ActorBase.tscn) is instantiated first which creates an instance of the ActorBase.cs script. Then, the derived scene (ActorFarmer.tscn) is instantiated which creates an instance of the ActorFarmer.cs script to replace the old one. However, the nodes in the scene are still referencing the ActorBase object that is now disposed.
It also sounds like this issue may be a duplicate of:

https://github.com/godotengine/godot/issues/86970

Thank you very much @raulsntos for clarifying. I used to be able to succesfully use this pattern in Godot 3.5 and onward, but I used a NodePath reference there to get to the actual Node, so I suppose that since it always used GetNode<T> to get the Node, I never encountered this before.
I agree that it's a bug, and I would like to see it fixed (and I would like to contribute to a fix), however it seems I would need quite a bit of engine knowledge to even start investigating, as I have a lot of experience working with the engine, however zero experience in the memory model.


bug: folke/trouble.nvim installation problems not identified in :checkhealth

Did you check docs and existing issues?

[X] I have read all the trouble.nvim docs
[X] I have searched the existing issues of trouble.nvim
[X] I have searched the exsiting issues of plugins related to this issue

Neovim version (nvim -v)
0.8.1
Operating system/version
macOS 12.6
Describe the bug
Trouble silently fails to install itself with LunarVim, and there is nothing relevant in :checkhealth.
This bleeds over to a feature request: It'd be great for your users, and probably for you too, if Trouble could surface problems in the checkhealth report.
I'm getting no :Trouble command:
E492: Not an editor command: Trouble
I've tried it (so far) with bashls and sumneko_lua.  Intentionally introducing a syntax error in either produces no Trouble report.
I've currently got this (among other things) in my config.lua:
return packer.startup(function(use)
│   use {
│   │   'wbthomason/packer.nvim' -- Have packer manage itself
│   }
--     use {
--         'ilAYAli/scMRU.nvim' -- This is to give an :Mru command, which is per-git-repo unlike ygappan/mru
--     }
│   use {
│   │   'ibhagwan/fzf-lua',
│   │   requires = { 'nvim-tree/nvim-web-devicons' }
│   }
│   use {
│   │   "folke/trouble.nvim",  -- Gives a subwindow of errors at the bottom
│   │   requires = { "kyazdani42/nvim-web-devicons", "folke/lsp-colors.nvim" },
│   │   config = function()
│   │   │   require("trouble").setup {
│   │   │   │   -- your configuration comes here
│   │   │   │   -- or leave it empty to use the default settings
│   │   │   │   -- refer to the configuration section below
│   │   │   │   height = 7
│   │   │   }
│   │   end
│   }
│   end
)
Steps To Reproduce

Install LunarVim, either by using the official LunarVim installer, or you can see exactly what I have by svn checkout'ing https://stromberg.dnsalias.org/svn/lunarvim-config/trunk and running "make install".  My full config.lua is there too, at https://stromberg.dnsalias.org/svn/lunarvim-config/trunk/config-lvim/config.lua
Enter LunarVim with the 'lvim filename' command
Try to issue the :Trouble command, and see that it doesn't tab-complete or appear as an editor command.

Expected Behavior
I want to see Trouble's report of errors at the bottom of my LunarVim session.
Repro
Covered above.

must be due to laz-loading in lunarvim. not a trouble issue


your work consumes 0.2s ?what‘s  0.2s contain?

Hi,dingmyu! I am quite interested in your work, especially its efficiency.But you don't report the run-time in the paper.So I found it on kitti official website.

Could you please tell me what does the time represents? Does it including the pre/post-process in the network,such as the time from cpu to gpu ,3D anchor transform, nms, post-optimization ?
Or  just calculating the consuming time of network flow on the gpu,from the processed image to feature map?

Hi,
It contains the neural network forward time, NMS, and post-optimization, thanks.
We use depth maps, which increases time and improves performance. So time-consuming is not our focus in this paper.
Regards,
Mingyu


Run CSI e2e tests in CI/CD pipeline CAS-577

Refactor scripts/e2e-test.sh to

Run the CSI tests
Be more developer friendly

Add csi to the set of tests run by default
The set of tests to be run can now be specified
using env var e2e_tests
Run uninstall test only if specified,
and always after all other tests have
run successfully or not.

This seem to be conflicting with https://github.com/openebs/Mayastor/pull/597/
Let's discuss on slack what to do as it seems they're doing both very similar things.

I like:

being able to specify what tests to run
having shell script function to run a test so we don't need to repeat the same parameters everywhere
what I don't like that much is:
introducing new env variables instead of command line options - confusing if the tool is configured using both ways
quite complicated logic iterating over tests skipping uninstall and then iterating again running only uninstall - we could have simply just a list of tests to run

but as Arne suggested it's probably better to discuss that in the chat after the e2e nightly PR is merged.

bors try

bors try

Superseded by https://github.com/openebs/Mayastor/pull/595

Superseded by https://github.com/openebs/Mayastor/pull/595


cassandra: handle out-of-retention queries correctly

This change is

+1

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


MapController Design

This is a proposal for a new Metacontroller API that attempts to fill a gap in the set of supported controller patterns that has been identified based on user feedback. Namely, the proposed API offers a way to observe objects you don't own and tie them into your custom behavior without trying to adopt (take ownership of) those objects.

/lgtm
The design is very nicely done. :)

/lgtm

I replied to some of the comments above.


Custom user roles and permissions

I would like to see an option to create some customer roles with granulated permissions.
Example of what i would like to see, basically an admin will be able to:

[ ] create a new role
[ ] assign granulated permissions
[ ] assign custom fields to this role -> company name, username, website etc (select which fields will be used when signup if signup with this role is enabled)
[ ] enable or disable -> user can sign-up with this role on frontend

Example of roles:

[ ] Moderator role -> this role cannot be used for registration (it will be assign manually by an admin) and it has access to the admin panel but only for some fields or sections like editing/ approving posts.
[ ] Company role -> this role can be selected when registering on the site and it has access only on the frontend of the site. This role has different fields other than the usual user role, like example instead of the name and last name it has the company name and son.

this is being worked on right now #194
please comment on the pr and explain if that specification fits your use cases

Thanks, fair requirements! I'll work on my PR to add signup role and custom fields features.
@faierbol can you pls explain the part:

select which fields will be used when signup
How do we use them?

@playrich any entity has isEnabled flag. You can use it on the frontend to disable the role. I'll configure backend to reject such role for auth

Thanks, fair requirements! I'll work on my PR to add signup role and custom fields features. @faierbol can you pls explain the part:

select which fields will be used when signup

How do we use them?

i was thinking as follows: create a role > assign permissions > chose if this role can be used when registering the site, basically ïsEnabledForRegistering field or something like this.

besides permissions we would be able to select or create new fields for this role like instead of name a custom role will have company name, now when creating a custom role the entire flow will be as follows: create. anew role > assign permissions > create or select existing fields (username, name, password etc) > chose if this role can be used when registering the site, basically ïsEnabledForRegistering > chose what fields will be displayed when registering if registration is enabled for this role

besides permissions we would be able to select or create new fields for this role like instead of name a custom role will have company name, now when creating a custom role the entire flow will be as follows: create. anew role > assign permissions > create or select existing fields (username, name, password etc) > chose if this role can be used when registering the site, basically ïsEnabledForRegistering > chose what fields will be displayed when registering on the frontend signup form, if registration is enabled for this role

this is theme related and theme authors can implement this feature
the cms itself will be able to handle this case
signup forms on the theme are something that the base system should not care about

@playrich right, theme authors can configure these forms. Another part of the question is what roles backend should accept for signup. Right now there's one signup role customer, but after refactor this role can be removed and created several new.
So we need to have isEnabledForRegistering in roles table, or maybe have a list of these roles in CMS settings?


Seekbar

A seekbar was added but not fully operational. The value is from 0 to 6.
Data is injected as a JSON object with a several arrays. Currently the index to parse it is hardcoded as "0".
A variable need to be created and his value depends of the slider position.
Additionaly, the app rewrite the weather values to the appropriate position textviews when user moves the slider.
At the same time we are to change "today" to "forecast" when this index isn't "0".
EDIT :
The seekbar is for a hourly use.

The seekbar is implemented for 6 hours forecasting.


[question] temporal convolutional networks

Hi,
It's more to have an opinion on the feasibility and relevance of implementing a custom policy network based on temporal convolutional networks (TCN). This paper talks about using it with A3C and shows promising results. I couldn't find any other references to such usage in RL though.
It seems like TCNs are gaining traction in supervised learning and seq2seq problems, and there were empirical demonstrations on how they can outperform RNNs in that area (e.g. here).
I find this interesting also for reducing memory consumption (also compared to RNNs).
I've tested it a bit myself with PPO2. Basically I've replaced LSTM layer of the LstmPolicy with conv1d layers (with specific padding and dilation rate for each layer, there are a few examples of Temporal blocks implementations out there)
Implementation scope wise, I think such custom policy would have the same "limitation" as for LSTM policies: you need to feed it with a sequence of observations, which is not the case (or even possible) with every algo.
For now (but I did only a few runs) my tests didn't show good convergence, but it requires some (lot of) tweaking. PPO2 seems also very sensitive to network architecture.
Would be interesting to hear opinions and/or experiences on that.
Thx!

Hello,
I don't know much about TCN but here are some thoughts on your problem:

This paper talks about using it with A3C and shows promising results.

I looked at it briefly and it does not seem to follow the best practices for reporting RL results:

the number of seed used is not clear
the budget dedicated to hyperparameter tuning for each baseline is not mentioned
the experiments seems "unfair" for the baselines as they removed the velocity from the observation (breaking the markovian assumption) and did not provide any mechanism like frame-stacking to counter-act this effect for feedforward policies
they train their algorithms on pong without the common pre-processing step (and again without frame-stacking which is completely unfair for feedforward methods)

As a result, I'd take those results with a grain of salt.

It seems like TCNs are gaining traction in supervised learning and seq2seq problems, and there were empirical demonstrations on how they can outperform RNNs in that area

I thought that "Attention [was] all you need" now ^^# (cf the transformer and recently BERT from Google)

For now (but I did only a few runs) my tests didn't show good convergence, but it requires some (lot of) tweaking. PPO2 seems also very sensitive to network architecture.

Well, you changed completely the network architecture, so you need unfortunately to tune a bit the hyperparameters.
Out of curiosity, on which problems are you working on?

Hi,

I thought that "Attention [was] all you need" now ^^# (cf the transformer and recently BERT from Google)

Well, that's very interesting too. Is integration of attention mechanism on your roadmap yet?

Out of curiosity, on which problems are you working on?

Industrial applications for which main constraint is energy consumption. Input of model is multivariate time series (from simulator). Action space can be continuous but most of the time discretizing it gives better results.
The biggest challenge I'm facing so far is that model tends to fit for a single action value after some time (value often optimal though) and doesn't generalize well. So I'm exploring various options to encourage exploration, prevent overfitting, and make the policy "remember" about past experiences.
TRPO was giving the best results so far, but since it doens't make much sense to feed a sequence-based network like TCN with one observation at a time (although it gives interesting results), I'm now testing with PPO2.

Is integration of attention mechanism on your roadmap yet?

It is not for now. We already have a lot of higher priority things I think (see https://github.com/hill-a/stable-baselines/projects/1)

Hi,
There is something I don't get with TRPO: there's a timesteps per batch parameter but it seems there's always only 1 timestep provided for every run (n_steps is always = 1). With PPO2, you get n_env * n_steps observations.
Is it fundamentally how TRPO is supposed to work?
Also it seems that some parameters aren't initialized with TRPO: n_batch is None.

Nevermind. Just saw it’s being addressed I  #140

Hi,
After some testing, I seem to be able to reproduce what is described in the paper. Most importantly, sum of rewards converges faster, is higher, and is more stable than with a feed forward network.

I didn't do a thorough comparison (only tested on my custom env), and my tests aren't fair since same parameters are used for both TCN and FF.
Also I noticed that results are good with TRPO and PPO1, but not with PPO2 (not even converging), which raises some concerns.
However it feels like a promising option and I'll dedicate more testing time to it.

@antoine-galataud

I'm closing this question as I think:

I couldn't prove it can be beneficial, and it seems quite unstable
no state of the art demonstration of how to use it or integrate it (feature extraction layer? somewhere else?)

I would be happy to share some ideas/code portions if anyone interested

I came here looking for TCN implementation, would you be able to share some sample code and your thoughts on it?


Host locator backend for MVP presentation

Expected Outcome
A hosted locator back-end serving pre-processed image data that is reachable from anyone without need of authentication.

Done as an experiment.


.net 8 apsire database issue

I am following Microsoft documentation. I did a simple project with Backend api, frontend, and Redis cache.
var builder = DistributedApplication.CreateBuilder(args);

var cache = builder.AddRedisContainer("crediscache");

var weatherapi = builder.AddProject<Projects.WeatherApp_Api>("weatherapi");

builder.AddProject<Projects.WeatherApp_Web>("frontend")
    .WithReference(weatherapi)
    .WithReference(cache);

All works fine. By working fine I mean it can deploy everything on the local environment with a Redis container on the docker desktop and when I use the command line azd init, it creates the required infrastructure files and when I run azd up it deploys everything correctly on azure.
But when I AddSqlServerContainer like:
var database = builder.AddSqlServerContainer("database");
It creates the database on the docker desktop but, when I run azd init, it returns an error:
ERROR: unsupported resource type: sqlserver.server.v1
I use Visual Studio Enterprise 2022 Preview 17.9.0 Preview 1.0
latest azd version "azd version 1.5.0 (commit 012ae734904e0c376ce5074605a6d0d3f05789ee)"

Azd is missing support for some of the resource types that exist in aspire (mostly due to running out of time).
These are the list of issues on azd for aspire:
https://github.com/Azure/azure-dev/issues?q=is%3Aopen+is%3Aissue+label%3Aaspire

I filed an issue here https://github.com/Azure/azure-dev/issues/3020


Gzip compression in addition to decompression?

Hello,
I'm sending potentially thousands of JSON objects in a list, and they're nearly identical.
Without gzip the size becomes large, and I'd like a way to turn on gzip request body compression.
Is this supported? I only see gzip decompression options in the client builder.
Thanks.

Nope, it's not currently supported. If you have the bytes already, you could pass them through a gzip function before sending in the requests...
As for adding the functionality to reqwest, I'd suggest canvassing what other libraries (even in other languages) provide.

I believe you could use got as a beacon, its API is really cool.

+1 for being able to do this, mixpanel is an API where compressing requests is very useful. As it wants JSON, the ergonomics of reqwest suffer a long - can't use json(..) have to encode manually and then drop the bytes in by hand.


Update dependencies + rebuild using svd2rust 0.28.0

update the dependencies to their latest version.
increase the MSRV to 1.59 and update the CI accordingly
rebuild the code with latest svd2rust

Hmm, not sure why this is failing.

Me either - the CI scripts are a bit old and haven't run in a while unfortunately.
Looks like the cargo cache is stale so it can't find the package. I wonder if we can manually update it...

Nope. Looks like it will work if you don't try to build for 1.59. something is up with the matrix action.
And we need to remove svdconv for it to work as well since that URL is broken.
Anyway: I've tested with those changes at https://github.com/sipeed/bl602-pac/pull/17 and it's passing.

Would you mind if I brought those changes across?

Go ahead! Do you need permission on my repo for that?

Nope, maintainers automatically have permission to edit for PRs - maybe for forks, too.


soc: stm32: stml051

Adding support for the stml051 devices.
Signed-off-by: Even Falch-Larsen<EMAIL_ADDRESS>

When I look in the reference manual (both l051 and l053), it doesn't seem like timer6 has PWM support. But the dts file claims PWM support for timer6 in the stm32l053.dtsi file. Which one is correct?

When I look in the reference manual (both l051 and l053), it doesn't seem like timer6 has PWM support. But the dts file claims PWM support for timer6 in the stm32l053.dtsi file. Which one is correct?

Seems you're right. Let's update dts

Please squash the second commit into the first

Done

Bump


Provide JS Modules export?

Hi @sindresorhus!
This module is pretty popular, and its functionality is fairly segmented (get vs set). I'm willing to bet a decent number of people are only using this to safely retrieve the value at a dotted path (not set).
Given that assumption, I was wondering if you'd be open to providing a JS Modules version where { set, get } are named exports?  I'd be happy to open a PR, though I'd need to know what solution you'd prefer for transpiling modules to commonjs (I'm biased).
Cheers!

I'm generally not interested in having a transpile-step in my modules, but I've started appreciating TypeScript, which actually makes a compile-step worth it. So what I'm saying is that if anyone rewrites this module in TS, I'm willing to add a compile-step. Happy to use https://github.com/developit/microbundle for that.

Hi!
I wanted to participate in this issue, but found that this module exports .delete() method, which can't be exported as named exports (because delete is a keyword in JS). My decision is to rename this method to remove, but leave it as delete in CommonJS exports.
Can you suggest a better solution for this?

I'm having doubts whether these makes sense as named imports. get as in import {get} from 'dot-prop; is not very readable in code if it's far from the import statement, and import {get as getProperty} from 'dot-prop'; is quit verbose...

I wanted to participate in this issue, but found that this module exports .delete() method, which can't be exported as named exports (because delete is a keyword in JS).

I think del or delete_ would be better. I prefer the latter and it's what I've been using in many other places for reserved keywords.

If they are going to be "named exports", I think it would make sense to make them named something like import {getProperty, deleteProperty} from 'dot-props';. Thoughts?

Your package already has type definitions which reflect the simple named import :
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/dot-prop/dot-prop-tests.ts
I suggest keeping it that way, i.e. concise instead of verbose. I know everyone has a different opinion on this naming dilemna.
Another point for me is don't fix what is not broken. Ask yourself : did somebody complain about the concise naming ?
Finally, you already have some kind of "standard" on this matter : Lodash also exports a simple get or set.

Just another perspective: I actually use the import { get } from 'dot-prop' a lot in a large API project, and it seems pretty readable to me. An example route handler might look like:
import { get } from 'dot-prop'

export default async ({ mediator, query, security }) => {
    if (get(security, 'security/public-mobile-app')) {
        query.state = 'published'
    }

    return {
        status: 200,
        body: {
            data: await mediator.call('controller/players/find', { query })
        }
    }
}

Coming from projects that use lodash with the _ a lot, I feel like _.get( is just as readable as get( but I am all for making names more wordy:
import { getProperty } from 'dot-prop'

export default async ({ mediator, query, security }) => {
    if (getProperty(security, 'security/public-mobile-app')) {

import {getProperty, deleteProperty} from 'dot-props';.

I'm going with this. We can move to ESM when TypeScript 4.6 is out.


Allow ignoring attributes for deriving FromRow

This pull request adds a new attribute flag skip for deriving FromRow (similar to serde's skip). It allows to add additional fields to a struct which will be filled with Default::default().
This is PR #2341 reopened since the branch 0.7-dev was deleted.

This is reaaaaally nice. I hope it makes the cut in time for 0.7

@abonander  Sorry, my bad! I have just added a skip section to the FromRow documentation.

@abonander Is it ok now?


Incomplete inference of unit recursive rule

If recursive rules are calling each other we do not infer a unit type.

This is related to the fact that we can not build recursive type by ourself. We must re-introduce the recursive type analysis in the typing module.

Actually, this is not true for all grammars, let consider this grammar:
r = "a" r
   / "b"

It actually leads to a bug because r is not well-typed, it has the type Tuple(vec[rule_id]) where rule_id is the type of r. We would like to allow this kind of rules and infer the type unit.
Therefore, we propose to infer unit type for recursive types by default and provide a warning informing that the unit type has been affected by default to r because it has a recursive type definition.


[Enhancement] Update Kyverno guidance with current status

Describe the bug
Not a bug, more of an enhancement. Kyverno made adjustments as of 1.8.3 to how it performs validation of attestations based on previously breaking changes introduced in Cosign 1.10. The guidance here needs to be updated to offer a policy which will work with the current version of Kyverno.
To Reproduce
Follow the link and attempt this on Kyverno 1.9.0-beta.1 and see it fails.
Expected behavior
An updated policy is available here and will soon be used to replace the one visible on the site here.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

@chipzoller Do you know if Kyverno updated their apiVersion for the ClusterPolicy CRD to maintain backwards compatibility? Or will simply upgrading Kyverno break it?

This is a breaking change, a one-off we permitted to happen in a patch release because we have stated that verifyImages rules are beta quality.

This is a breaking change, a one-off we permitted to happen in a patch release because we have stated that verifyImages rules are beta quality.

Ok, maybe we can keep around an example for the older version of Kyverno if folks are still using that.