[Bug-App]: [0.18.0]: Build fails on FreeBSD: undefined: NewGPUNvidia

Describe the bug
What support for NVidia GPU is WanDB using?
CUDA isn't available on FreeBSD, but Vulkan is available.

We use a rust wrapper around Nvidia's nvml (https://github.com/Cldfire/nvml-wrapper) to collect metrics for their gpus, so if there's no libnvidia-ml.so available for FreeBSD, no need to build that binary: to skip it, please set WANDB_BUILD_SKIP_NVIDIA=true.

I also should have read the title of the issue lol :)
here's the fix for it: https://github.com/wandb/wandb/pull/8373

@dmitryduev
When I apply the patch from the PR https://github.com/wandb/wandb/pull/8373 to the release 0.18.0 and add the WANDB_BUILD_SKIP_NVIDIA=true environment variable the build still fails:
Building wandb-core Go binary...
# github.com/wandb/wandb/core/pkg/monitor
pkg/monitor/monitor.go:162:12: undefined: NewGPUAMD
pkg/monitor/monitor.go:171:17: undefined: NewTrainium
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/pyproject_hooks/_in_process/_in_process.py", line 380, in <module>
    main()
  File "/usr/local/lib/python3.11/site-packages/pyproject_hooks/_in_process/_in_process.py", line 364, in main
    json_out["return_val"] = hook(**hook_input["kwargs"])
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

oops, sorry about that. here: https://github.com/wandb/wandb/pull/8374

@dmitryduev
When I added https://github.com/wandb/wandb/pull/8374 on top of https://github.com/wandb/wandb/pull/8373 it now fails like this:
===>  Building for py311-wandb-0.18.0
* Getting build dependencies for wheel...
* Building wheel...
Failed to parse sysconfig.get_platform() (freebsd-14.1-STABLE-amd64); disabling cross-compilation.
Building wandb-core Go binary...
# github.com/wandb/wandb/core/pkg/monitor
pkg/monitor/noop_freebsd.go:114:6: GPUAMD redeclared in this block
        pkg/monitor/noop_freebsd.go:57:6: other declaration of GPUAMD
pkg/monitor/noop_freebsd.go:119:6: NewGPUAMD redeclared in this block
        pkg/monitor/noop_freebsd.go:62:6: other declaration of NewGPUAMD
pkg/monitor/noop_freebsd.go:126:18: method GPUAMD.Name already declared at pkg/monitor/noop_freebsd.go:69:18
pkg/monitor/noop_freebsd.go:128:18: method GPUAMD.Sample already declared at pkg/monitor/noop_freebsd.go:71:18
pkg/monitor/noop_freebsd.go:130:18: method GPUAMD.IsAvailable already declared at pkg/monitor/noop_freebsd.go:73:18
pkg/monitor/noop_freebsd.go:132:18: method GPUAMD.Probe already declared at pkg/monitor/noop_freebsd.go:75:18
pkg/monitor/noop_freebsd.go:137:6: Trainium redeclared in this block
        pkg/monitor/noop_freebsd.go:80:6: other declaration of Trainium
pkg/monitor/noop_freebsd.go:145:6: NewTrainium redeclared in this block
        pkg/monitor/noop_freebsd.go:88:6: other declaration of NewTrainium
pkg/monitor/noop_freebsd.go:160:20: method Trainium.Name already declared at pkg/monitor/noop_freebsd.go:103:20
pkg/monitor/noop_freebsd.go:162:20: method Trainium.Sample already declared at pkg/monitor/noop_freebsd.go:105:20
pkg/monitor/noop_freebsd.go:162:20: too many errors
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/pyproject_hooks/_in_process/_in_process.py", line 380, in <module>
    main()
  File "/usr/local/lib/python3.11/site-packages/pyproject_hooks/_in_process/_in_process.py", line 364, in main
    json_out["return_val"] = hook(**hook_input["kwargs"])
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pyproject_hooks/_in_process/_in_process.py", line 278, in build_wheel
    return _build_backend().build_wheel(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/hatchling/build.py", line 58, in build_wheel
    return os.path.basename(next(builder.build(directory=wheel_directory, versions=['standard'])))
                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/hatchling/builders/plugin/interface.py", line 147, in build
    build_hook.initialize(version, build_data)
  File "/usr/ports/misc/py-wandb/work-py311/wandb-0.18.0/hatch_build.py", line 37, in initialize
    self._prepare_wheel(build_data)
  File "/usr/ports/misc/py-wandb/work-py311/wandb-0.18.0/hatch_build.py", line 43, in _prepare_wheel
    artifacts.extend(self._build_wandb_core())
                     ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/ports/misc/py-wandb/work-py311/wandb-0.18.0/hatch_build.py", line 167, in _build_wandb_core
    hatch_core.build_wandb_core(
  File "/usr/ports/misc/py-wandb/work-py311/wandb-0.18.0/core/hatch.py", line 46, in build_wandb_core
    subprocess.check_call(
  File "/usr/local/lib/python3.11/subprocess.py", line 413, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/usr/ports/misc/py-wandb/work-py311/.bin/go', 'build', '-ldflags=-s -w -X main.commit=9295e1f45704eac6d89bb2e18ab3eb12565ce56c', '-o', '../wandb/bin/wandb-core', '-mod=vendor', 'cmd/wandb-core/main.go']' returned non-zero exit status 1.

ERROR Backend subprocess exited when trying to invoke build_wheel
*** Error code 1

@yurivict looks like something got botched, there aren't even this many lines in this file: https://github.com/wandb/wandb/blob/main/core/pkg/monitor/noop_freebsd.go. Could you please try checking out main and trying it off it? (merged both of those prs and that will go into the release next week)


Question on Physical Address. Manual Entry

Hi,
Setting the Physical Address by code was intended to be like the following? Or there is another way?
  // Set Physical KNX Address of ESP KNX (Optional)
  address_t physaddr;
  physaddr.pa.area=1;
  physaddr.pa.line=1;
  physaddr.pa.member=1;
  knx.physical_address_set(physaddr);

Yes, either that way or like this:
knx.physical_address_set(GA_to_address(1, 2, 3));

Oops, yeah sorry. I confused group and physical addresses for a moment there...
I will add a PA_to_address method for this.


Make girder_client optional

A single function in HistomicsTK depends on girder_client:
https://github.com/DigitalSlideArchive/HistomicsTK/blob/master/histomicstk/utils/girder_convenience_utils.py
To simplify the build we should make girder_client optional.
Will need to update build instructions and note this in some of our examples (@kheffah).

@cooperlab While only connect_to_api() uses girder_client per se, almost all the other functions in girder_convenience_utils.py need to have an authenticated girder client as a non-optional parameter. These functions, in turn, are used particularly often in the database parsing and tissue tissue/cellularity detection modules.

I'll note that currently on pypi, version 1.0.5dev2 installs girder_client by default.  If we just make this an official release (just tag it in GitHub), then it would be version 1.0.5 and the installation would be automatic.  girder_client doesn't add much code or secondary dependencies.

Closed since an official release was made so girder_client is now installed by default without extra dependencies.

Closed since an official release was made so girder_client is now installed by default without extra dependencies.


Export ASCII to PDF or image file

Results will be printed + framed in 13x18 cm frame, so it would be useful if we could generate a PDF or image file that automatically adjust image size to fit these constraints.

Wontfix.


[VL] memory leak on unit tests job exit

Describe the bug
2023-05-25T10:19:50.3960388Z ===== POSSIBLE THREAD LEAK IN SUITE o.a.s.sql.execution.datasources.parquet.GlutenParquetSchemaInferenceSuite, thread names: rpc-boss-1268-1, shuffle-boss-1271-1 =====
2023-05-25T10:19:50.3961700Z
2023-05-25T10:19:50.4366391Z [36mRun completed in 1 hour, 4 minutes, 47 seconds.[0m
2023-05-25T10:19:50.4367546Z [36mTotal number of tests run: 5632[0m
2023-05-25T10:19:50.4368523Z [36mSuites: completed 208, aborted 0[0m
2023-05-25T10:19:50.4369704Z [36mTests: succeeded 5632, failed 0, canceled 0, ignored 25, pending 0[0m
2023-05-25T10:19:50.4370688Z [32mAll tests passed.[0m
2023-05-25T10:19:52.6889761Z E0525 18:19:52.688163 44087 Exceptions.h:68] Line: ../../velox/common/memory/MemoryAllocator.cpp:106, Function:~MallocAllocator, Expression: (numAllocated_ == 0) && (numMapped_ == 0) [allocated pages 256, mapped pages 0], Source: RUNTIME, ErrorCode: INVALID_STATE
2023-05-25T10:19:52.6892480Z terminate called after throwing an instance of 'facebook::velox::VeloxRuntimeError'
2023-05-25T10:19:52.6928922Z   what():  Exception: VeloxRuntimeError
2023-05-25T10:19:52.6929704Z Error Source: RUNTIME
2023-05-25T10:19:52.6930415Z Error Code: INVALID_STATE
2023-05-25T10:19:52.6931161Z Reason: [allocated pages 256, mapped pages 0]
2023-05-25T10:19:52.6931864Z Retriable: False
2023-05-25T10:19:52.6932613Z Expression: (numAllocated_ == 0) && (numMapped_ == 0)
2023-05-25T10:19:52.6933361Z Function: ~MallocAllocator
2023-05-25T10:19:52.6934160Z File: ../../velox/common/memory/MemoryAllocator.cpp
2023-05-25T10:19:52.6934877Z Line: 106
2023-05-25T10:19:52.6935388Z Stack trace:
2023-05-25T10:19:52.6938028Z # 0  facebook::velox::VeloxException::VeloxException(char const*, unsigned long, char const*, std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >, bool, facebook::velox::VeloxException::Type, std::basic_string_view<char, std::char_traits<char> >)
2023-05-25T10:19:52.6941030Z # 1  void facebook::velox::detail::veloxCheckFail<facebook::velox::VeloxRuntimeError, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&>(facebook::velox::detail::VeloxCheckFailArgs const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)
2023-05-25T10:19:52.6943385Z # 2  std::_Sp_counted_ptr_inplace<facebook::velox::memory::(anonymous namespace)::MallocAllocator, std::allocator<facebook::velox::memory::(anonymous namespace)::MallocAllocator>, (__gnu_cxx::_Lock_policy)2>::_M_dispose()
2023-05-25T10:19:52.6944975Z # 3  std::shared_ptr<facebook::velox::memory::MemoryAllocator>::~shared_ptr()
2023-05-25T10:19:52.6945803Z # 4  0x0000000000000000
2023-05-25T10:19:52.6946334Z # 5  on_exit
2023-05-25T10:19:52.6946891Z # 6  0x0000000000000000
2023-05-25T10:19:52.6947461Z # 7  0x0000000000000000
2023-05-25T10:19:52.6947991Z # 8  0x0000000000000000
2023-05-25T10:19:52.6948533Z # 9  0x0000000000000000
2023-05-25T10:19:52.6949083Z # 10 0x0000000000000000
2023-05-25T10:19:52.6949598Z # 11 0x0000000000000000
2023-05-25T10:19:52.6950155Z # 12 start_thread
2023-05-25T10:19:52.6950702Z # 13 clone

To Reproduce
This happens on GHA jobs, not 100% occur
Expected behavior
no memory leakage on unit test job exit
Additional context
N/A

I face this issue in https://github.com/oap-project/gluten/pull/1948

@ulysses-you Thanks for feedback here, this is a tricky bug and not 100% occur, the memory leaked is small and it may due to some schema related issue(?).  I may need more time to dig it out.
Just triggerted the GHA job again, re-run the job may get it passed :-)
Thanks, -yuan


Multiplications failing after bootstrapping

I tried to do some multiplications after bootstrapping was done, but it keeps giving this error (even though it shows levels rem is 10 after bootstrapping):
CKKS scheme is using ring dimension 4096
Input: (2, 2, 2, 2, 2, 2, 2, 2,  ... ); Estimated precision: 59 bits
Initial number of levels remaining: 1
Number of levels remaining after bootstrapping: 10
terminate called after throwing an instance of 'lbcrypto::math_error'
what():  /home/imtiyazuddin/Ubuntu/openfhe-development/src/pke/lib/encoding/ckkspackedencoding.cpp:537 The decryption failed because the approximation error is too high. Check the parameters.
Aborted (core dumped)
why is this?

You may be able to find some answers by searching the OpenFHE forum. We encourage OpenFHE users to post their questions there.


Using Iterable causes code to run 360x slower.

Observed
The following patch made my code execute in 0.5s instead of 3m:
if (changedFileBuildCommands.isEmpty) {
       _outSink.writeln(
@@ -236,13 +239,13 @@ class ClangTidy {
   ) {
     final List<Command> totalCommands = <Command>[];
     if (sharedBuildCommandsData.isNotEmpty) {
-      final Iterable<Command> buildCommands = buildCommandsData
-          .map((dynamic data) => Command.fromMap(data as Map<String, Object?>));
-      final Iterable<Set<String>> shardFilePaths =
+      final List<Command> buildCommands = buildCommandsData
+          .map((dynamic data) => Command.fromMap(data as Map<String, Object?>)).toList();
+      final List<Set<String>> shardFilePaths =
           sharedBuildCommandsData.map((List<Object?> list) => list
               .map((Object? data) =>
                   Command.fromMap((data as Map<String, Object?>?)!).filePath)
-              .toSet());
+              .toSet()).toList();
       final Iterable<_SetStatusCommand> intersectionResults =
           _calcIntersection(buildCommands, shardFilePaths);
       totalCommands.addAll(intersectionResults

Exepected
The code that uses Iterable should execute faster if anything since it eliminates extra copies.
Context
https://github.com/flutter/engine/pull/37265
cc @zanderso

The code that uses Iterable should execute faster if anything since it eliminates extra copies.

.map(...) and friends don't cache results (which is mentioned in the documentation).
Your code is basically the following:
for (var x in iterable1) {
  for (var y in iterable2) {
    // ...
  }
}

So for each element of iterable1 you recompute elements of iterable2 from scratch.
Computing them once makes things faster.
I think this is WAI and well documented?

Here is the documentation:

Returns a new lazy Iterable with elements that are created by calling f on each element of this Iterable in iteration order.
This method returns a view of the mapped elements. As long as the returned Iterable is not iterated over, the supplied function f will not be invoked. The transformed elements will not be cached. Iterating multiple times over the the returned Iterable will invoke the supplied function f multiple times on the same element.
Methods on the returned iterable are allowed to omit calling f on any element where the result isn't needed. For example, elementAt may call f only once.

Yea, I understood that the values were lazy, I expected the results to be memoized.  I think I'm having some sort of weird mandela effect where that was the expected behavior of map functions.  At least in some languages the map function returns an iterator not an iterable so you can't accidentally iterate over it twice.
I don't think there is anything actionable here.


Example of how to use with bs-form-group

    {{#bs-form-group validation='???'}}
        <label class = "control-label">Title</label>
        {{bs-input type="text" value=model.title}}
    {{/bs-form-group}}

What should the value of validation be here?

Unfortunately bs-form-group isnt supported. Is there a reason you cant just use bs-form-element?

bs-form-element is fine, thanks.

@danjac 👍 . If you get into a use-case where bs-form-group is needed, please feel free to reopen.


Increasing pause after sentences

Hi
I am trying to increase the duration of the pause between sentences generated when using the pretrained model. The model is recognizing periods, but I would like to increase the duration of the pause.

Is this a Tacotron 2 or Waveglow question?

Hi @rafaelvalle it's a Tacotron 2 question, in my understanding.

This is the waveglow repo. Ask the question at the Tacotron 2 repo.


Look for a nightly compiler

$ rustup run stable cargo expand >/dev/null

  warning: the option `Z` is unstable and should only be used on the nightly
    compiler, but it is currently accepted for backwards compatibility; this
    will soon change, see issue #31847 for more details
  warning: the option `pretty` is unstable and should only be used on the nightly
    compiler, but it is currently accepted for backwards compatibility; this
    will soon change, see issue #31847 for more details

Let's run rustc --version and rustup run nightly rustc --version and choose the one that provides a nightly compiler.
If neither is nightly, keep the current behavior with warnings.

Note: as of Rust 1.19 you must use nightly in order for cargo expand to work.
I'm curious if you have any thoughts about the future of cargo expand.    In rust-lang/rust#31847 it is mentioned that --pretty is broken and may be removed or replaced.

Fixed in db455ab7266ee1440ee2b3bd535a548806a89513.


SQL2019 CU8

Type of Change

[ ] Bug fix (non-breaking change, fixes # )
[ ] New feature (non-breaking change, adds functionality, fixes # )
[ ] Breaking change (effects multiple commands or functionality, fixes # )
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[x] Documentation
[ ] Build system

Purpose

https://www.microsoft.com/en-us/download/details.aspx?id=100809
Approach

Commands to test

Screenshots

Learning

awesome thank you!

🏆


🌐 Remove duplicate line in translation for docs/pt/docs/tutorial/path-params.md

There was a repeated line in the file path-params.md in the docs/pt.
I only removed this line.

📝 Docs preview for commit af36fde794a85ec1ead9e7d02f32e5229b5e82df at: https://6386f17b.fastapitiangolo.pages.dev

Great, thanks @LecoOliveira! 🚀


Adding TakeAll processor to be used instead of take first. resolves #45

Hi Rakan,
the other DDS processors (http://django-dynamic-scraper.readthedocs.org/en/latest/reference.html#processors) are working on strings as an input and output, so this won't work out.
Holger

Just noticed i didn't have a description to the PR. The basic idea is that we get a list of all nodes captured through the xpath, so returning 1 if only one exists in the list, otherwise return all. The other way would be by not having a processor for this purpose only as well as removing the TakeFirst from the DjangoSpider and DjangoBaseSpider that we have in DDS.
What do you think?

Why not just use Join processor?


rondo form in production

Hello!
I deploy my application via dokku (docker) to my own Hetzner VPS and have:
ActionController::RoutingError (No route matches [GET] "/assets/controllers/nested_rondo_controller")
browser console:
Request URL: https://pm.<IP_ADDRESS>.sslip.io/assets/nested_rondo_controller
Status Code:
404 Not Found

I already have few Stimulus controllers in the application and they are all working in the production, except rondo controller.
What additional steps should I take to make it work?
I already did asset:precompile, :clobber, :clean and such stuff, but no luck
Rails 7, importmaps, ruby "3.2.2"
javascript/cotnroller/index.js:
import NestedRondoController from "./nested_rondo_controller"
application.register("nested-rondo", NestedRondoController)

Should I more specifically set a path somewhere to this controller?
Thanks in advance!
UPDATE:
Not sure if it is a correct approach or I found a real issue.
I just commented out these lines in index.js and controller works fine in the production:
import NestedRondoController from "./nested_rondo_controller"
application.register("nested-rondo", NestedRondoController)

since this already loading all the controllers:
import { eagerLoadControllersFrom } from "@hotwired/stimulus-loading"
eagerLoadControllersFrom("controllers", application)

I don't use VPS for deployment, it worked well when I tried to deploy on Flyio.
Do you have any error when running asset:precompile.
Maybe you can try renaming the stimulus controller and file names, I named nested_rondo just for convention.


Interval "expand" produces invalid results

define "test": expand {Interval[@2020-01-01, @2020-01-08]} per day
The above CQL calculates:
[Interval[2020-01-01, 2020-01-01), Interval[2020-01-02, 2020-01-02) [...]
Those intervals are invalid, both including and excluding a particular day. If the "expand" operator uses the "except" operator, this issue may be linked to issue #403

This same behavior is confirmed for integer intervals.
define "test": expand {Interval[4,6]} //results in Interval[4, 4), Interval[5, 5), Interval[6, 6)]
Decimal intervals work better, but the ends should probably be inclusive instead of exclusive
define "test_decimal": expand {Interval[4.0,6]} //results in [Interval[4.0, 4.99999999), Interval[5.0, 5.99999999)]

Resolved by #462

Whoops. Had too many tabs open.


Update 1.mdx : Fix typo

Fixed a typo in paragraph

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Hello @lewtun I need you for a code review please.


Build Failing

Docker file referring https://github.com/Azure/go-autorest/autorest/utils does not exists...
Docker Build is failing. Seems the owner of go-autoreset has removed this Utils directory.

Thanks, I'm taking a look.

Should be fixed now.


Disable Excon sockets thread cache

This is the cause of the memory leak that we experienced recently.
Every Excon connection has a cache of sockets that ensures that a socket is only
used by a specific thread during its lifetime. This means that 1 Excon
connection might hold any number of open sockets to the same server.
In our case for example if Puma is running with 4 threads, and a connection pool
of 4 Excon connections to the PVB API it means that there will a maximum of 16
HTTP persistent connections.
The issue is that the implementation of the cache doesn't clear old connections
for threads that are no longer running (an issue when Puma is configured to
autoscale threads). We inadevertedly solved the memory leak by configuring Puma
to use a fixed number of threads.
The implementation of this cache was changed just before we started having
memory leaks to fix a use case of Excon that we don't use. The old
implementation didn't have a memory leak with our use case.
Although this makes the PrisonVisits::Client not thread safe it's fine in our
use case because:

we use a connection pool of connections and a connection is only used by 1
thread at a time.
It means that we don't hold sockets open unnecessarily for each Excon
connection.

I've tested the value of this setting locally by load testing the server with
concurrent requests:

with the cache enabled and Puma autoscaling threads it showed the memory
leak when spacing the load testing by 1 minute between benchmarks
with the cache disabled and Puma autoscaling threads memory usage remained
stable and there were no threading issues.

Excon discussion about the recent
change to the cache where it actually mentions that it has an memory leak issue.

Opened an issue for Exxon: https://github.com/excon/excon/issues/651


Sort struct declarations in dependency order

Currently, structs are emitted in the order their corresponding complexTypes are found in the .xsd file.
Order them such that the root element occurs last and every complexType which is included in another type occurs before it(phew). This is required to declare structs as direct children of other structs. It also assists in viewing - just go up for a child type.

This also works now.


Is this Yolo V3 uses darknet framework and darknet cfg?

@tanluren hello, is your code uses darknet framework and darknet cfg?

You can fine-tune on darknet

@zbyuan no, you did not understand, i guess! i mean does the original code use the original darknet model written in C not in pytorch and require CFG parser? is it? if not, then if you know the details please provide the details.


Fix false positive of FalseExportDefault

Was this actually a false positive? TS imports with node16 moduleResolution fail with this library, and there's an issue open on that library around it - https://github.com/ajv-validator/ajv/issues/2132
The suggested fix provided appears to be a workaround for the exact issue that arethetypeswrong was previously flagging

@me4502 in case you’re still interested in this, #85 adds a type checker run to bring back a more specific and accurate error for this case with ajv:


Expose buildHitCorners function in ElementInput

Related to https://github.com/playcanvas/editor/issues/896 where I would like visualise the hit area in the Editor like so:

Not sure how to go about this. All the math used to workout the button hit area is in ElementInput.
For testing purposes, I've just made them static so I can access them in the Editor as private API
// Add the padding to the existing world corners
// We are always in world space in the Editor
const elementScale = pc.ElementInput.calculateScaleToWorld(entity.element)
hitCorners = pc.ElementInput.buildHitCorners(entity.element, hitCorners, elementScale.x, elementScale.y, elementScale.z);

renderLineCorners[0].copy(hitCorners[0]);
renderLineCorners[1].copy(hitCorners[1]);
renderLineCorners[2].copy(hitCorners[1]);
renderLineCorners[3].copy(hitCorners[2]);
renderLineCorners[4].copy(hitCorners[2]);
renderLineCorners[5].copy(hitCorners[3]);
renderLineCorners[6].copy(hitCorners[3]);
renderLineCorners[7].copy(hitCorners[0]);

app.renderLines(renderLineCorners, cornerColor, immediateRenderOptions);

This works of course but just feels wrong to have this as the standard.
So I'm think on doing:

Leaving it as is for minimal change to the engine
Making this public API and/or moving these to some utils namespace and making it public API
Making a separate, public function for this in ButtonComponent that gets the worldHitCorners

I'm leaning towards 3 but could use some input
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

I'd leave it as is (static) to be honest. Just add a comment that the function is called directly by the Editor, so we're aware when we change it.

Thanks Martin!


"Processing... this might take a while"

Describe the bug
Please fix EsmBot's image manipulation commands (Slow while doing a command)
To Reproduce
Steps to reproduce the behavior:

Go on Discord
Type any image manipulation command
Wait. If you wait for 1 hour or more, the bot may not work at all.
See error

Expected behavior
1, Type any image manipulation command
2. Bot runs and completes task given by command in less than 1 hour or more
Screenshots

Self-hosted instance?
No
Additional context
It appears this happened more than once, particularly with the bot being slow at least multiple times already.
List of emojis while taking so long
:processing:
:glxgears:
:processing: - This "processing" emoji is now green, and instead of the usual gears, there's spinning and shapeshifting polygons
"Spunch Bop" processing emoji - I wasn't even able to retrieve the name of this emoji, but it shows the famous "Spunch Bop" moving fast in weird effects.
Let me know if you manage to find more proccessmojis in replies.

See #56


Manifest update for Microsoft.OpenJDK.11 #13983

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Closes #13983

You messed up by commiting 2 different manifests into one branch, revert the java 16 commit, i already made a manifest for java 16 anyways :)
Also you're damn fast between creating a issue and fixing the problem your self 😆

You messed up by commiting 2 different manifests into one branch, revert the java 16 commit, i already made a manifest for java 16 anyways :)
Also you're damn fast between creating a issue and fixing the problem your self 😆

Ahh! my bad. Removed commit.

Yes!!! as a Java enthusiast couldn't wait after the announcement :)

Whats the difference between Microsoft OpenJDK, Liberica JDK and AdoptOpenJDK tho? 🤔

Whats the difference between Microsoft OpenJDK, Liberica JDK and AdoptOpenJDK tho? 🤔

Different vendors for OpenJDK. Each of them has the provision to add additional enhancements, utilities or maintain different schedules for adding patches/backports etc


-filtered-gen.jar and -filtered-gen-src.jar generated for packages without any .java files

Description of the feature request:
We do have "resources"-only packages that generate Java code and then compile it as part of the build.
Those packages are consumed by others, and sources/classes are certainly used downstream.
Some of such modules have absolutely no .java sources present that results in missing -filtered-gen.jar entries.
Since there are no source artifacts generated for such packages, there is nothing in .intellij-info.txt after aspects pass, and IDE cannot navigate to legitimate sources.
I suspect that https://github.com/bazelbuild/intellij/blame/86e31292434875ca1f86a02230cde5a3de5a70cf/aspect/intellij_info_impl.bzl#L794 should detect such cases to be able to generate required jars anyway here https://github.com/bazelbuild/intellij/blame/86e31292434875ca1f86a02230cde5a3de5a70cf/aspect/intellij_info_impl.bzl#L653
Which category does this issue belong to?
Intellij
What underlying problem are you trying to solve with this feature?
Navigation to the generated source code for non-standard targets without any .java sources.
What operating system, Intellij IDE and programming languages are you using? Please provide specific versions.
Any
Have you found anything relevant by searching the web?
No response
Any other information, logs, or outputs that you want to share?
Before:
❯ ls -l bazel-bin/pppp/ | grep gen
dr-xr-xr-x. 4 user group  4096 Apr 25 14:59 rrr_generated
-rwxr-xr-x. 1 user group 10577 Apr 18 13:51 rrr_generated-0.params

Then I've created a dummy class that was just an empty file

After running Bazel Sync next time I see
❯ ls -l bazel-bin/pppp | grep gen
-r-xr-xr-x. 1 user group  1843 Apr 25 20:05 pppp_lib-filtered-gen.jar
-r-xr-xr-x. 1 user group  1808 Apr 25 20:05 pppp_lib-filtered-gen-src.jar
dr-xr-xr-x. 4 user group  4096 Apr 25 14:59 rrr_generated
-rwxr-xr-x. 1 user group 10577 Apr 18 13:51 rrr_generated-0.params

I'm not sure honestly. Maybe these targets could be just added to the libraries section in IntelliJ Project Structure? Would it be possible to prepare a minimal reproducible example?

This is part of our large project and generation is happening inside a macro. So I don't even have a good repro to share here :(
I need to introduce some Code generation to greetings_project to even give you a repro.
Is there a way to do this now, @tpasternak ?

Maybe these targets could be just added to the libraries section in IntelliJ Project Structure

We not using targets and directories is the only mechanism that we using.

Please note that we have hundreds of such "targets" so if we want to include all of those as part of .bazelproject we need to use some wildcards, and even this might not be possible. I need to explore our graph more and probably rename some things to make it work.

@tpasternak you can find repro here https://github.com/bazelbuild/intellij/pull/6415/files. It probably not a wrong idea to add some code generation to sample project as well...
With
directories:
  # Add the directories you want added as source here
  # By default, we've added your entire workspace ('.')
  greeting_lib

# Automatically includes all relevant targets under the 'directories' above
derive_targets_from_directories: true

targets:
  # If source code isn't resolving, add additional targets that compile it here

additional_languages:
  # Uncomment any additional languages you want supported
  # android
  # dart
  # go
  # javascript
  # kotlin
  # python
  # scala
  # typescript

With
directories:
  # Add the directories you want added as source here
  # By default, we've added your entire workspace ('.')
  .

# Automatically includes all relevant targets under the 'directories' above
derive_targets_from_directories: true

targets:
  # If source code isn't resolving, add additional targets that compile it here

additional_languages:
  # Uncomment any additional languages you want supported
  # android
  # dart
  # go
  # javascript
  # kotlin
  # python
  # scala
  # typescript

With a dummy java class

Ok, to me it seems to be unrelated to the JarFilter logic. The generated library is correctly attached with the source jar, but the contents of the source jar doesn't match the contents of the jar. Doesn't it look like a bazel bug?

Reported to bazel https://github.com/bazelbuild/bazel/issues/22254

This issue is more nuanced and not only filtered-gen-src.jar can be used as lib source.
_lib-src.jar is used when package with generated module referred from some other module.


Add AAU Illumina ARTIC protocol

This came up in a discussion of protocols and turnaround time and might be a useful addition to the list: https://www.protocols.io/view/aau-ncov-2019-tailed-long-amplicon-sequncing-bfc3jiyn

Added. Sorry for the delay!


Transformed the params in getStrictCSP into an options object

Fixes #44

Transformed the params in getStrictCSP into an options object
Reordered the params

cc @lweichselbaum FYI - please comment in case you don't agree!


Fix chunk size parsing: handle invalid chunk sizes

Currently, when the chunk size is an invalid hex number (i.e. contains a non-hex digit), hyper would halt its parsing at the last valid hex digit and report this as the chunk size.
For example, the following would be the chunk sizes reported for some strings:
"X" => 0
"1X" => 1
"aY" => 10
"a;a" => 10 (only this should be correct!)

This fix makes it so that any chunk size, which cannot be parsed as a valid hex number, causes an IoError.
Additionally, the case where the chunk size is followed by a chunk extension is also handled -- the ";" token is allowed to immediately follow the chunk size, as it represents the delimiter between the size and the extensions.
The chunk extension parsing is (still) not fully compliant with the official syntax spec and accepts extensions deviating from it (or rather no error is raised). For example, the following shouldn't be a valid chunk size + extension (because the name needs to be a single token preceding the "=" separator):
"A;name with spaces=value"

but it will not cause an error and will return 10 as the chunk size.
However, octets which should be part of the chunk extension are identified, meaning that if in the future the extension should be fully parsed and exposed by some API, the logic can be plugged in. Although, AFAIK, most HTTP parser implementations disregard the extensions in a similar manner as done here.
Regression tests for the get_chunk_size function and the parsing of requests in the server and responses in the client module are included.

This is amazing work. Thanks!


[SPARK-28570][CORE][SHUFFLE] Make UnsafeShuffleWriter use the new API.

What changes were proposed in this pull request?
Uses the APIs introduced in SPARK-28209 in the UnsafeShuffleWriter.
How was this patch tested?
Since this is just a refactor, existing unit tests should cover the relevant code paths. Micro-benchmarks from the original fork where this code was built show no degradation in performance.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13519/
Test PASSed.

Test build #108423 has started for PR 25304 at commit 0ee9311.

@squito @vanzin @ifilonenko @yifeih

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13521/
Test PASSed.

Test build #108425 has started for PR 25304 at commit 1d08d80.

Test build #108423 has finished for PR 25304 at commit 0ee9311.

This patch fails Java style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108423/
Test FAILed.

Test build #108427 has started for PR 25304 at commit a02448c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13523/
Test PASSed.

Test build #108425 has finished for PR 25304 at commit 1d08d80.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108425/
Test FAILed.

Test build #108427 has finished for PR 25304 at commit a02448c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108427/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13581/
Test PASSed.

Test build #108487 has started for PR 25304 at commit 86b2c4f.

Test build #108487 has finished for PR 25304 at commit 86b2c4f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108487/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13676/
Test PASSed.

Test build #108587 has started for PR 25304 at commit fc798b7.

Test build #108587 has finished for PR 25304 at commit fc798b7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108587/
Test PASSed.

@squito addressed the comments here.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14311/
Test PASSed.

Test build #109243 has started for PR 25304 at commit 48335fa.

Addressed most things, except https://github.com/apache/spark/pull/25304#discussion_r311131107 - not sure how important it is or where to move the comment if at all.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14323/
Test PASSed.

Test build #109255 has started for PR 25304 at commit cf046df.

Test build #109243 has finished for PR 25304 at commit 48335fa.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109243/
Test PASSed.

Test build #109255 has finished for PR 25304 at commit cf046df.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109255/
Test PASSed.

@squito or @vanzin - wanted to check if this is ok to merge.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14993/
Test PASSed.

Test build #109972 has started for PR 25304 at commit c125a14.

Test build #109972 has finished for PR 25304 at commit c125a14.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109972/
Test PASSed.

@vanzin or @squito is this good to merge?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15269/
Test PASSed.

Test build #110273 has started for PR 25304 at commit f8f95f3.

Test build #110273 has finished for PR 25304 at commit f8f95f3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110273/
Test PASSed.

Test build #110298 has started for PR 25304 at commit 94a3653.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15293/
Test PASSed.

Test build #110298 has finished for PR 25304 at commit 94a3653.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110298/
Test FAILed.

retest this please

Test build #110335 has started for PR 25304 at commit 94a3653.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15326/
Test PASSed.

Test build #110335 has finished for PR 25304 at commit 94a3653.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110335/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15353/
Test PASSed.

Test build #110365 has started for PR 25304 at commit 94a3653.

lgtm aside from marcelo's comments

Test build #110365 has finished for PR 25304 at commit 94a3653.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110365/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15374/
Test PASSed.

Test build #110385 has started for PR 25304 at commit 85a101d.

Test build #110385 has finished for PR 25304 at commit 85a101d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110385/
Test PASSed.

@squito @vanzin good to merge this?

Merging to master.


archive-fork-links - Update Selector

close: #7334
Test URLs
https://github.com/dnSpy/dnSpy
Screenshot

There is a typo in the PR title and in the changelog:
- archive-fork-links
+ archive-forks-link


MAINT: Remove deprecated events and methods.

select and deselect events were supposed to be removed in 0.4.9, and two functions were supposed to be private in 0.4.11.
Remove them.

@tlambert03 you seem to be the one that both introduced the deprecation/removal and the private functions that still use those events. I seem to have a hard time following where this is used and how the code should be updated.

looks like they are still used here ... and until someone updates the points layer, it probably can't be removed:
https://github.com/napari/napari/blob/22cd5596838a98d402ce03ae0f7031d91bcf9bc2/napari/layers/base/base.py#L1759-L1769

@Carreau any updates here? Looks like you have one approval and are passing tests.

I just want to note that this PR has been opened for 9 month now. And it's becoming slightly annoying to have to rebase/fix because a PR that was opened more than 7 month after this one was approved a couple of time was merged.

A few days ago, we start working about update of responsibilities (ex code ownership) and assignments persons to PR.
Maybe you know some application that allows to create a task queue (like revisiting this PR after 72h - then it will appear on the todo list after this time)?

A few days ago, we start working about update of responsibilities (ex code ownership) and assignments persons to PR.

Thanks, I've seen an increase of nudge reviews, so your efforts are seen.

Maybe you know some application that allows to create a task queue (like revisiting this PR after 72h - then it will appear on the todo list after this time)?

Not from the top of my head. I tend to use the "last updated" on GitHub view, and find that it's not a problem if you try to keep the number of PRs relatively small and close dormant ones.
Would it help you to make a cron workflow that does that with a say "nudge" label ?
import requests
from datetime import datetime, timedelta

owner = "napari"
repo = "napari"
#token = ... Your GitHub personal access token

label_to_check = "nudge"

headers = {"Authorization": f"token {token}"}

# Get all open pull requests
url = f"https://api.github.com/repos/{owner}/{repo}/pulls?state=open"
response = requests.get(url, headers=headers)
pulls = response.json()

for pull in pulls:
    labels = [label["name"] for label in pull["labels"]]

    url = f"https://api.github.com/repos/{owner}/{repo}/pulls/{pull_number}"

    response = requests.get(url, headers=headers)
    pull = response.json()

    labels = [label["name"] for label in pull["labels"]]
    if label_to_check in labels:
        continue

    url = f"https://api.github.com/repos/{owner}/{repo}/issues/{pull['number']}/events"
    response = requests.get(url, headers=headers)
    events = response.json()

    label_events = [event for event in events if event["event"] in "unlabeled" and event["label"]["name"] == label_to_check]

    if label_events:
        # check if label has been remove 72+ hours ago if so re-add
        # we may want to check for comments from napari (core) dev in
        # the last 72h as well and add/remove label as necessary ?
        last_label_event = label_events[-1]
        label_removed_at = datetime.strptime(last_label_event["created_at"], "%Y-%m-%dT%H:%M:%SZ")
        if datetime.now() - label_removed_at > timedelta(hours=72):
            url = f"https://api.github.com/repos/{owner}/{repo}/issues/{pull['number']}/labels"
            response = requests.post(url, headers=headers, json={"labels": [label_to_check]})

I have a plan to investigate writing own GitHub app that one of ability will be to remind one after a given time. But the investigation of this could take time. Maybe setup a server with corn could be a good idea.

I do have https://github.com/MeeseeksBox/meeseeksdev hosted on heroku, feel free to send PR to extend it. Though I'm not sure it does cron.

Di you pay for Heroku, or free tier is still available?

thanks !
On Sun, May 21, 2023 at 01:14 Grzegorz Bokota @.***>
wrote:

Merged #5042 https://github.com/napari/napari/pull/5042 into main.
—
Reply to this email directly, view it on GitHub
https://github.com/napari/napari/pull/5042#event-9295097824, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACR5T5KLSGJU4WVCZY3WGDXHFF57ANCNFSM6AAAAAAQHPE2WI
.
You are receiving this because you were mentioned.Message ID:
@.***>


Issue

In my modpack i cant find any of the stuff from this mod in the lexikon. I dont know if thats because of the versio, its just not in the mod or because other mods in my modpack intervere.

The addon entries are only displayed if you play in English (en_us). Unfortunately I can't fix the problem (It's on the M&A side)


Fixes #130: Live validation not fully disabled by default.

Refs #130 for context. r=? @leplatrem /cc @matiaslarsson
This also nicely fixes #75.

r+ :)


Barter Container Location Incorrect Persistence

We noticed that the barter container is saved to a specific coordinate in the world. This is expected behavior but becomes an issue when the barter container is broken. That block coordinate is still owned by the player that made the shop.
If another player attempts to place a block in that location, they cannot.
If the original shop owner places a barrel back in that location it is recognized as a barter container

Solution may be to make container breaking cancel. Container owner has to empty it first, then close the shop, then they can break it.


Performance improvement for large table

Too slow with N0000~ songs in a table.
Ag-grid is supposed to be faster.

This only happens with Chrome. Firefox is much faster for large dataset rendering.

Chrome performance is slow when Redux dev tool is enabled.


Restore NewConnection struct for parts of a connection

This enables forwards-compatibility with future extensions such as a datagram stream.
Partially unblocks #395.

LGTM. Just fix up the examples?

Whoops. Examples which require features are always so difficult to get cargo to see. That should do it.

Forget the benchmarks! 😝

Thank god for CI.


High Contrast and Reduced Motion improvements

What kind of changes does this PR include?

Changes to the docs site code

Description

Added outline for blockquote elements in high contrast mode:

Changed TabGroup border-bottom-color for a more semantic color (Highlight -> ButtonText), now all the tabs in the docs have the same semantic styling.
Removed details svg animation in reduced motion mode:

Thanks for the review @delucis!


Scripture range parser

This change is

Codecov Report
Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (11d098a) 66.59% compared to head (dc07a03) 66.74%.
Report is 4 commits behind head on master.

Files
Patch %
Lines

src/SIL.Machine/Scripture/ScriptureRangeParser.cs
94.70%
7 Missing and 3 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage   66.59%   66.74%   +0.15%
==========================================
  Files         434      435       +1
  Lines       33778    33967     +189
  Branches     4535     4571      +36
==========================================
+ Hits        22493    22672     +179
- Misses      10215    10222       +7
- Partials     1070     1073       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

src/SIL.Machine.AspNetCore/Services/NmtPreprocessBuildJob.cs line 1 at r1 (raw file):
Previously, Enkidu93 (Eli C. Lowry) wrote…
Done.

That just a mix-up trying to separate the changes - thank you :).


Email?

Hi Jerrison, I was wondering if you could reach out to me via email at<EMAIL_ADDRESS> It's kind of weird to be collaborating without having chatted 😉.

This is a good idea! Sorry if I was being too reckless inviting you without proper introduction. I sent you an email and I will close this issue, and we can continue the discussion through email : )


upgrade-cluster with docker-image has unknown error

i called
docker run --rm -it -v ${PWD}/cluster:/cluster -v ${PWD}/.ssh:/tmp/.ssh vitobotta/hetzner-k3s:v0.5.0 upgrade-cluster --config-file /cluster/cluster_config.yaml --new-k3s-version=v1.21.8+k3s1

/usr/local/bundle/gems/subprocess-1.5.5/lib/subprocess.rb:334:in `exec': No such file or directory - bash (Errno::ENOENT)
        from /usr/local/bundle/gems/subprocess-1.5.5/lib/subprocess.rb:334:in `block in initialize'
        from /usr/local/bundle/gems/subprocess-1.5.5/lib/subprocess.rb:287:in `fork'
        from /usr/local/bundle/gems/subprocess-1.5.5/lib/subprocess.rb:287:in `initialize'
        from /usr/local/bundle/gems/subprocess-1.5.5/lib/subprocess.rb:83:in `new'
        from /usr/local/bundle/gems/subprocess-1.5.5/lib/subprocess.rb:83:in `check_call'
        from /usr/local/bundle/gems/hetzner-k3s-0.4.9/lib/hetzner/utils.rb:37:in `run'
        from /usr/local/bundle/gems/hetzner-k3s-0.4.9/lib/hetzner/k3s/cluster.rb:242:in `upgrade_cluster'
        from /usr/local/bundle/gems/hetzner-k3s-0.4.9/lib/hetzner/k3s/cluster.rb:68:in `upgrade'
        from /usr/local/bundle/gems/hetzner-k3s-0.4.9/lib/hetzner/k3s/cli.rb:47:in `upgrade_cluster'
        from /usr/local/bundle/gems/thor-1.2.1/lib/thor/command.rb:27:in `run'
        from /usr/local/bundle/gems/thor-1.2.1/lib/thor/invocation.rb:127:in `invoke_command'
        from /usr/local/bundle/gems/thor-1.2.1/lib/thor.rb:392:in `dispatch'
        from /usr/local/bundle/gems/thor-1.2.1/lib/thor/base.rb:485:in `start'
        from /usr/local/bundle/gems/hetzner-k3s-0.4.9/exe/hetzner-k3s:4:in `<top (required)>'
        from /usr/local/bundle/bin/hetzner-k3s:25:in `load'
        from /usr/local/bundle/bin/hetzner-k3s:25:in `<main>'

Docker run under macOS 11.6.2
I tried to build dpcker local and run again ... error same.

this version worked
docker run --rm -it -v ${PWD}/cluster:/cluster -v ${PWD}/.ssh:/tmp/.ssh vitobotta/hetzner-k3s:v0.4.8 upgrade-cluster --config-file /cluster/cluster_config.yaml --new-k3s-version=v1.21.8+k3s1

@vitobotta can you check this? I can confirm upgrading does not work since v0.4.9 / docker due to the error above

I will try to look into it tonight. Thanks for reminding me about it

I have updated the image 0.5.0 and was able to create a cluster successfully. Can you try again with this version?

hi @vitobotta! I cannot see any updates – the problem persists on 0.5.0 (which is why I wrote since v0.4.9). I haven't tried creating a cluster but upgrading does throw the error mentioned above.

Awesome, thanks for confirming. Closing this then. Thanks again


WIP: preload some system dlls

Found one more place that needed safer loading

Having tests for this would be kind of nice, but that can be a separate PR. E.g. have a DLL that crashes on load and copy it to the same dir as the exe, does the exe run or crash? The DLL loading bit looks good, but for the install dir I'm somewhat conflicted.

so is this approved for merging then @taruti ?


Don't attempt to parse null frontmatter locations

Avoids cluttering up the dev console with logs like:
Error converting location in file <path>:
    TypeError: Cannot read properties of null (reading 'match')`

Hey,
I made some changes to this code in the latest commits pushed to the branch and I think the new code also covers your case, can you check if this fix is still relevant? If that's the case, we rather not add this extra null check.

Yep, your change fixed it. Thanks!


Improve init function split logic

Purpose

Improve init function split logic to split functions further.
Also, enable http integration tests.

Fixes #
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

Reported https://github.com/ballerina-platform/ballerina-lang/issues/16280 for failing tests.

Check List

[ ] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #16279 into jballerina will decrease coverage by 3.55%.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             jballerina   #16279      +/-   ##
================================================
- Coverage         15.53%   11.97%   -3.56%
+ Complexity         3600     2755     -845
================================================
  Files              1468     1496      +28
  Lines             71573    72156     +583
  Branches           8603     8634      +31
================================================
- Hits              11122     8644    -2478
- Misses            59448    62702    +3254
+ Partials           1003      810     -193

Impacted Files
Coverage Δ
Complexity Δ

...et/http/clientendpoint/CreateSimpleHttpClient.java
30.43% <0%> (ø)
2 <0> (ø)
:arrow_down:

...g/wso2/ballerinalang/compiler/desugar/Desugar.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...n/java/org/ballerinalang/util/BootstrapRunner.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...rver/completions/util/CursorPositionResolvers.java
0% <0%> (-100%)
0% <0%> (-7%)

...sorters/ActionAndFieldAccessContextItemSorter.java
0% <0%> (-100%)
0% <0%> (-6%)

...er/completions/util/sorters/DefaultItemSorter.java
0% <0%> (-100%)
0% <0%> (-2%)

...server/completions/util/filters/SymbolFilters.java
0% <0%> (-100%)
0% <0%> (-7%)

...ngserver/completions/util/sorters/ItemSorters.java
0% <0%> (-100%)
0% <0%> (-8%)

...rg/ballerinalang/langserver/index/dao/DAOType.java
0% <0%> (-100%)
0% <0%> (-1%)

...tions/util/sorters/CallableUnitBodyItemSorter.java
0% <0%> (-100%)
0% <0%> (-2%)

... and 144 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58089d1...44fa7c0. Read the comment docs.


308 upgrade export category workflow

This PR addresses issue #308.
We wanted to have the ability to pick which category to export from the Github Action Workflow. In this PR, you can now pick which category to export from a dropdown menu. Further improvements can be made to where we set up a dropdown menu for geography but default to all geo's.
I recommend running the action and then viewing the output in DO to test.
Here are is action I ran

Also would be good for peace of mind to see a working export category action from the feature branch

here is the working export category action: https://github.com/NYCPlanning/db-equitable-development-tool/actions/runs/3069828930


Support requests for multiple scopes

Per docker/docker#20387:

cesanta/docker_auth only understands a single scope query parameter, and the docker engine is requesting push/pull for the repository you are pushing to and pull access for the repository you're mounting the blob from. This means you request both scopes and the auth server only returns a token with the single repository scope.

...
I can address issue number 2 so that it immediately falls back to pushing the blob on auth failure, specifically for the case of a cross-repo push, but I'd recommend filing an issue with cesanta/docker_auth to support this workflow.

let's see... can you give me an example of a token request that is handled incorrectly?

My own logs have aged off (I had to fall back to a different form of auth), but my understanding is they'd look like this:
GET https://myregistry.private/auth?service=myregistry.private&scope=repository:foo/my-app:pull,push&scope=repository:foo/my-otherapp:pull

i see. this should be easy to do. what is the actual use case for this? when does this happen?

Docker 1.10 has the ability to avoid pushing the same layer to different repositories. To do that, it needs push and pull rights on the target repository, and pull rights on the repository that is the source of the "mount".
This helps a ton in the case of several $platform applications that all use the same customized $platform docker image.

i see. as i said, it should be easy to do, but i'm super busy atm.
if you (or anyone else reading this) do it, please send a PR, otherwise i'm afraid this will have to wait a few days

@erikswanson i built and pushed cesnat/docker_auth:scopes, can you give it a go?

@rojer Sorry, I'm super-busy for the next few days and it's not trivial for me to roll back the emergency removal of token auth from my production registry/fallback to an awful nginx conditional basic auth bodge. (The lack of it was triggering a serious performance issue in Docker 1.10.1, making my push times way worse than with < Docker 1.10: When a "mount" failed due to token scope, it'd fall all the way back to re-uploading the layer, even if that layer was already uploaded for a different tag in the same repository.)
If nobody else is able to look at/validate this by mid-next week, I should definitely have time then.

so i just need docker 1.10, re-tag some image as a different one, push and i should see requests for multiple scopes, right?

A different repository (foo/bar vs foo/baz) within the same registry, yes.

installed docker 1.10, verified that multiple scope auth requests and cross-repo pushes now work


Can not remove P1 accessory from favorites in Home app

After the iOS14 upgrade I discovered something weird. The P1 is added to the Home App as an unsupported accessory. So far nothing new. But is stays in my Favorites. There is no option on the accessory page to remove this.
Any idea how to solve this?

Somehow Home on iOS14 no longer provides favourite settings for unsupported accessories.  You can still change this setting on Home on macOS or on iOS13.
The only thing I can do is expose the meters as something that Home recognises, e.g. a non-functional switch or outlet.

Ok, for now I will change the setting on Mac OS.

This option has also disapeared now on the latest MacOs, can I help with exposing this differently?

Big Sur?  That was to be expected.
Apparently an accessory now needs at least one supported service to be unmarked as favourite.  I fail to understand Apple’s reasoning here.  I tried a read-only Switch before, but Home doesn’t accept that either.  I was thinking maybe to use a Stateless Programmable Switch, but that makes no sense semantically.

That indeed doesn't make much sense; but from the user perspective it would be good because the goal is to hide them from the favourites screen. A dummy but supported switch to achieve that goal imho is for now perhaps the best possible way?

It's what I did for the bridge/gateway accessory in Homebridge Hue.

In v1.1.3.

In v1.1.3.

Updated everything but no change here

Did you set button in config.json?

Did you set button in config.json?

I guess I was a bit impatient... it works! Thanks!


LRUCache use ReentrantReadWriteLock

What is the purpose of the change
Optimize LRUCache performance
Brief changelog
change LRUCache ReentrantLock to ReentrantReadWriteLock
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #5820 into master will decrease coverage by 0.09%.
The diff coverage is 86.66%.

@@             Coverage Diff             @@
##             master    #5820     +/-   ##
===========================================
- Coverage     61.27%   61.17%   -0.1%
+ Complexity      499      496      -3
===========================================
  Files           981      981
  Lines         39133    39144     +11
  Branches       5640     5644      +4
===========================================
- Hits          23980    23948     -32
- Misses        12525    12564     +39
- Partials       2628     2632      +4

Impacted Files
Coverage Δ
Complexity Δ

...n/java/org/apache/dubbo/common/utils/LRUCache.java
87.09% <86.66%> (+0.88%)
0 <0> (ø)
:arrow_down:

...bo/config/event/listener/LoggingEventListener.java
37.5% <0%> (-25%)
0% <0%> (ø)

...che/dubbo/remoting/transport/mina/MinaChannel.java
39.47% <0%> (-10.53%)
15% <0%> (-1%)

...ava/org/apache/dubbo/config/DubboShutdownHook.java
71.73% <0%> (-9.12%)
0% <0%> (ø)

...e/dubbo/remoting/transport/netty/NettyChannel.java
52.27% <0%> (-7.96%)
19% <0%> (-2%)

...ng/transport/dispatcher/all/AllChannelHandler.java
62.06% <0%> (-6.9%)
0% <0%> (ø)

...mmon/threadpool/support/AbortPolicyWithReport.java
83.78% <0%> (-5.41%)
0% <0%> (ø)

...ng/exchange/support/header/HeartbeatTimerTask.java
73.68% <0%> (-5.27%)
0% <0%> (ø)

.../org/apache/dubbo/remoting/ExecutionException.java
15.78% <0%> (-5.27%)
0% <0%> (ø)

.../remoting/transport/netty4/NettyClientHandler.java
59.32% <0%> (-5.09%)
0% <0%> (ø)

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a7b5d1...a85892e. Read the comment docs.


i can't build it,can u share releases

i can't build it,can u share releases

https://github.com/Flangvik/SharpCollection#sources--credits

thinks

hahahah


Allow for push/replace at specific point in stack

It would be nice to have the ability to say "remove last two history elements and push this new location" via the API. This is possible today via something like:
    this.props.history.go(-2);
    setTimeout(() => {
      this.props.history.push('/my-events');
    }, 100);

and under Chrome on my high-powered development machine this does not produce any jank, but I worry that other classes of devices and browser may introduce lag or flicker as the view associated with history@{-2} could potentially be rendered during the transition phase.
Note that executing both operations without a timeout results in just the go operation taking effect.
Ideally this would be exposed as an "atomic" API where users could do something like history.pushAt(-2, '/my-events') and this will avoid sending any transition events to the API until the history's state has been fully mutated.

Can you elaborate on the use case? At first glance, this doesn't seem like a good practice (for browser apps at least) and not trivial to implement.
Maybe not a big issue in practice, but there's also that paragraph in the spec:

In addition, a user agent could ignore calls to pushState() that are invoked on a timer, or from event listeners that are not triggered in response to a clear user action, or that are invoked in rapid succession.

I wonder if your issue could be better solved by being able to navigate without triggering a re-render.

My goal was to try to actively manage the history to create wizard-type flows, i.e. a history transition like:
[/home, /user/create, /user/create/confirm] -> [/home, /user/1234]

Effectively, we want to have the browser back button work while in the wizard, but remove the wizard from the history.
Interesting that the spec suggests behavior that is explicitly contrary to the anecdotal and required behavior that I saw under Chrome. The more I think about that point, should a browser vendor implement that, it breaks a pretty massive use case for history API, where routing responses are conditional on a AJAX call or other sort of async operation. I have a difficult time believing that browsers would prevent all async pushState operations in a manner similar to popup blockers as this would potentially break large swaths of sites using the history API.
The option to navigate without triggering a rerender was one route that I was thinking a potential here. I used this in the backbone world years ago and it worked well enough for the use cases on those projects.

I think you just need to handle this in e.g. a router onEnter hook or something. I don't see how we can really expose this in history in a principled way. Really the concern you care about is "don't re-render in the Router".

I think you just need to handle this in e.g. a router onEnter hook or something. I don't see how we can really expose this in history in a principled way. Really the concern you care about is "don't re-render in the Router".

@kpdecker I think i discovered the same issue as you did. Did you figure out a way to resolve it?
@taion Could you elaborate on how this should be handled in an onEnter hook in more detail?

@martindederer I haven't had a chance to look at a proper fix, wherever that may be. For right now just dealing with the possible double route trigger and render as we have other things we need to focus on at this stage in our project.

+1
I faced the same issue.
[home > item > order > pay] => [home > item > orderDetail]


Support Vue 3

What do you think of a package for Vue 3?

That would be great. I feel there is a lot of room for a new GraphQL client. Currently, only vue-apollo and graphql-request are avaiable and being maintained actively. urql would be a great addition to the ecosystem.

Superseded by #1006 as an intent to implement.


Fix nit in LoRA doc

Very tiny fix, closes #1053

hi @awni , According to OpenAI's official documentation, this may not be a bug, as arguments is not an object but a "string" type "object" that needs to be deserialized into a real object.
For details, see: https://platform.openai.com/docs/guides/fine-tuning/fine-tuning-examples

Yes it is true that it should be like that according to the openai docs, but MLX does not fine-tune well if you adhere to that...
I guess there is something wrong under the hood then with the interpretation of the training data in that format...

If you check the chat_temlpate configuration in the meta-llama/Llama-3.1-8B-Instruct repository, you may find that the reason could be the requirement for the function return format, which is inconsistent with the OpenAI format. Llama-3.1-8B-Instruct requires a dictionary to be returned.

You have access to the following functions. To call a function, please respond with JSON for a function call.
'Respond in the format {"name": function name, "parameters": dictionary of argument name and its value}.'

So if you return according to the document's format, some issues may arise (the format in the base model is inconsistent with the fine-tuning data format). When I reviewed the HuggingFace chat_template document again, I found it also highlighted this part:

If you’re familiar with the OpenAI API, you should pay attention to an important difference here - the tool_call is a dict, but in the OpenAI API it’s a JSON string. Passing a string may cause errors or strange model behaviour!

When I checked the mistral-finetune project again, I found that its data usage is consistent with the OpenAI format.
So I think there might not be a strictly correct format here. The key point is to ensure that the format of your fine-tuning dataset needs to be consistent with the base model's format, otherwise problems will arise. I think this part can be explained in the documentation.

I think the right call for this is to leave a pointer in the doc that the data format that works well for tool calling can be different for different models and linking to the page about tool use in HG chat templates that you found @madroidmaq. Thanks for digging into that. I will update the doc and leave the current example as is.

@awni I submitted a PR #1063, could you help check if any adjustments are needed?


[WFLY-10493]: Support JMS Java EE resources definition for remote Artemis-based broker.

* Creating queue / topic on deployments
* Deleting queue / topic in undeployments
* Looking for default ee resource adapter if none is specified.
* Making @JMSConnectionFactoryDefinition work without internal broker.
* Adding support for description of runtime external destinations.
* Adding support for management address definition in the @JMSDestinationDefinition

JIRA: https://issues.jboss.org/browse/WFLY-10493
https://github.com/wildfly/wildfly-proposals/pull/78

@ehsavoie This will need a community docs commit as well.


cvxpy for real-time - Understanding prob.solve overhead time

Hello,
For some real-time model-predicted control (MPC), I'm trying to figure out if cvxpy could be used for real-time control.
Therefore, I'm constructing a cvxpy minimization problem with cvxpy variables, constraints and parameters. I only construct this problem one time. Then I update the parameter values (param.value = ...)  in my control loop without reconstructing the problem or any of the constraints or variables.
Using different solvers (ECOS, OSQP), I measured the time for the cvxpy.Problem.solve function call which is 100 ms:

prob.solve 0.109   (=100 ms)
When activating 'verbose=True' for cvxpy.Problem.solve, I can see in the terminal output that the actual solve time however is only 6 ms:

Runtime: 0.0062 seconds.   (=6 ms)
Why is there such a big difference in processing time between the cvxpy.Problem.solve function call and the actual solver function, how could I reduce the function call overhead time? I assumed that just assigning values to parameters can be fast and would not have to internally 'recompile' anything for the solver?
cvxpy version: 1.0.24
Conda: 4.5.12 (Python 3.6.6, Win64)
my code:  mpc.zip
Thanks,
Alexander Grau

Hey Alexander. CVXPY is not yet ready for real-time applications. We’re working on a new version of CVXPY (version 1.1) that’ll be better suited for your needs — it’ll make more intelligent use of parameters, and it’ll also support code generation for embedded optimization. So stay tuned — we don’t know when exactly 1.1 will be ready, but hopefully it’ll land sometime this year.

Thanks for the info :-)

You can close this issue if you like. I found the solution by using the ACADO code generator to generate a Python C extension for my MPC problem that can run even faster than realtime (only a few hundred microseconds per control step). I'm quite happy with the results :).
Maybe a future code generator for CVXPY could do the same, however I think it probably runs best when looking at specific optimization problems (MPC in my case).

I am still experiencing overhead time consumption. The time difference is approximately one order of magnitude greater than the optimizer reported one.
Could I get some info on the causes of this and possible solutions?
PS: I have version 1.1.10

Hi @Danfoa, you could try to profile the function call when solving the optimization problem.
For that, you can use something like tuna (kudos to @akshayka, from whom I copied using the tool).
Is your optimization problem related to the one discussed in the issue above (which dates back to before the release of version 1.1)?

Hi, @phschiele thanks for the quick answer. I did profile my program, here is the .prog file. Search for the flight_stance_cycle_opt function call, this is where I am solving a QP with OSQP.
The profile seems to suggest that there is a lot of heap time in reductions and expressions transforms, I guess this part of cvxpy is done in python and that's why it consumes so much? Could it be related to the details of my implementation?
I can really use some insight into how to reduce the overall time.
In the image, you can see the order of magnitude increase elapsed time from the solver reported time:

@Danfoa are you using parameters? I assume you're solving the same problem form multiple times.

Yes I am using warm start, time limit, refine=False, max_iter, and I believe some other minor adjustments. However although the solver works extremely fast the overhead keeps constant.
As a matter of fact I am solving the same QP Form (Quadratic cost is computed as the sum of quadratic error of a polynomial (whose coefficients are the program variables) and some reference trajectory), while constraints are final and initial trajectory constraints.
I am solving the same QP but the reference trajectory varies from iteration to iteration, only the reference in que quadratic error costs, everything else is kept constant through iterations.

I think the question was referring to the usage of cvxpy Parameters.
As you mention, reconstructing the problem indeed can create overhead.
Consider this simple example (slight adaption of Docs) to see how using a Parameter can speed up the optimizations:
import time
import cvxpy as cp
import numpy

# Problem data.
m = 1000
n = 1000
n_solves = 10
numpy.random.seed(1)
A = numpy.random.randn(m, n)
parameter_values = numpy.random.randn(m,100)

# w/o parametrization
solver_time = 0
start=time.time()
for i in range(n_solves):
    x = cp.Variable(n)
    b = parameter_values[:,i]
    prob = cp.Problem(cp.Minimize(cp.sum_squares(A @ x - b)),
                       [x >= 0])
    prob.solve()
    solver_time += prob.solver_stats.solve_time
end = time.time()
print(f'total_time {end-start}, solver_time: {solver_time}, solver share: {solver_time/(end-start)}')

# w/ parametrization
solver_time = 0
start = time.time()
x = cp.Variable(n)
b = cp.Parameter(m)
prob = cp.Problem(cp.Minimize(cp.sum_squares(A @ x - b)),
                   [x >= 0])
for i in range(n_solves):
    b.value = parameter_values[:,i]
    prob.solve(warm_start=True)
    solver_time += prob.solver_stats.solve_time
end = time.time()

print(f'total_time {end-start}, solver_time: {solver_time}, solver share: {solver_time/(end-start)}')

total_time 69.73, solver_time: 61.42, solver share: 0.88
total_time 27.06, solver_time: 25.73, solver share: 0.95

Not only is the computation much faster overall, but the fraction of time spent in the solver also increases.
Relevant to when such improvements are achievable, check out the DPP ruleset.

@phschiele @SteveDiamond, sorry for the confusion with the Parameters.
I followed your example and the documentation on DPP, and effectively the overhead time was increasingly reduced, although it's still considerable on top of the solver reported one. However, I was able to achieve almost real-time performance, which is more than fine for now. Absolute Thanks!.
Also, although I read a lot of the documentation while implementing the QP for the first time (this was my first use of cvxpy) I was never able to find the concepts of the DPP and the tricks for optimal performance. Maybe it would be helpful to make it more accessible in the documentation.

@Danfoa I'm glad things are working for you now! For sure, I'll mention to the other devs that we should make DPP more prominent. We've added a lot of features over the last year or so and the docs may not highlight them all as clearly as they should

Hi! I want to use CVXPY to slove a quadratic problem with changing cost and constrains for path tracking. As the example Repeatedly solving a DPP problem shows in the tutorial , the cost and constrains of the problem are not changing with the value. I try to constructing the problem once at the beginning, and solve the problem at each iteration with different cost and constrains. Unfortunately, it doesn't seem to work well. But the total time was increasingly reduced. I think this method is feasible, maybe somewhere has gone wrong.  Could you please give me some suggestions on  repeatedly solving a DPP problem with changing cost and constrains?

@whenwherewhy it's a bit tricky if you have a changing set of constraints. DPP is designed for problems where the dimensions and functional form don't change, for example a quadratic program
min x^TPx + q^Tx
subject to Ax = b
                  Gx <= h

where P, q, A, b, G, and h are parameters with fixed dimensions. Does your application fit into that setting?


chore: update Dependency Analytics Plugin version - 0.0.14-2020.06.25-1

chore: update Dependency Analytics Plugin version - 0.0.14-2020.06.25-1

@dvandra Push the package-lock.json as well

[test]

[test]


Error in NetworkExplorer on Orange3

I'm running Orange3 from Anaconda.
I'm trying to use Network Explorer but it appear that error
Does anyone know what it means?
Thank you in advance,
M.

What does this have to do with Redmine?

sorry, wrong repository,
you can delete that issue

hahaha nice


fix: list_indices never updated after first call

lance in rust would cache the index metadata so no need to cache it in python.

also added an option to control which indices to optimize
also added tests for optimize_indices

Codecov Report
Attention: Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.78%. Comparing base (51126ab) to head (5d83e1d).

Files with missing lines
Patch %
Lines

rust/lance/src/index.rs
92.85%
0 Missing and 2 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2936      +/-   ##
==========================================
+ Coverage   77.76%   77.78%   +0.01%
==========================================
  Files         231      231
  Lines       70487    70516      +29
  Branches    70487    70516      +29
==========================================
+ Hits        54817    54852      +35
+ Misses      12771    12765       -6
  Partials     2899     2899

Flag
Coverage Δ

unittests
77.78% <93.10%> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


No File object in Flutter Web

Flutter Web Crashes when i use File object in dart:io.

Flutter Web Crashes when i use File object in dart:io.

What do for web then? For Files like images, audio files, pdf etc .

What do for web then? For Files like images, audio files, pdf etc .

@nasir447
if you need assistance with your code please follow the link I want help writing my application in the new issue menu


Release notes broken since 0.42

I am new to the React Native world and having fun learning it. Though there is one thing which is confusing me - the Release Notes are empty for every version since 0.42. I really would like to know the difference between React Native versions. Whats new, what did change, what did break etc.
I am following the links on https://facebook.github.io/react-native/versions.html
so https://github.com/facebook/react-native/releases/tag/v0.41.0 still has it but
https://github.com/facebook/react-native/releases/tag/v0.42.0 does not.
Where can i get this information? Is it in a different place now? Does the documentation need a fix?
Its really confusing for a beginner to not find this information.
Thanks a lot

It's because the release notes go with the latest minor version. For example 0.42 is 0.42.3.
You can find the latest releases here: https://github.com/facebook/react-native/releases

Thanks for that information, Ehesp.
So that release notes compare to the latest minor e.g. 0.42.3 vs 0.42.2 or (as i suppose from the amount of changes) do they compare current major.minor 0.42.3 vs last latest major.minor 0.41.x (whatever latest minor there is)?
How can i find out changes between 2 minors 0.42.3 vs 0.42.2? I guess its down to git cli then?

Sorry for the confusion, as @Ehesp said the release notes are only for minor versions (monthly release).
But you're probably right, before the release notes was always tagged to the version v0.X.0 as linked in React Native Versions, but now they're linked to the latest patch.
cc @grabbou Thoughts?
If you want to know the changes between two patches, you can do this by comparing changes like this: https://github.com/facebook/react-native/compare/v0.43.2...v0.43.3

Hi there! This issue is being closed because {:search=>"repo:facebook/react-native is:open is:issue updated:<2017-05-25 -label:"Good First Task" -label:"Help Wanted" ", :message=>"it has been inactive for a while"}. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!
If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.


How to install firebase on active webpage?

Hello, I was looking for long time to try firebase, finally I got some time to test your amazing APP
On Linux server I make those steps
I run npm install -g firebase-tools
Then I go to
/var/www/runningpage and I create a folder /firebase
On /var/www/runningpage/firebase
I run successful firebase login
Then firebase init where creates the following files
.firebaserc, .gitignore, database.rules.json, folders functions, public, with their own files
My question
I need to run firebase on
/var/www/runningpage and not in /var/www/runningpage/firebase
How to do that?
Can I move/edit files .firebaserc, .gitignore, database.rules.json, and move/rename folders
or I need to delete all and run firebase init outside of /runningpage
Thank you

@petrospap sorry for the slow response here!  You should generally use the firebase command from the same directory where firebase.json lives.  It may be easiest to just start over and run firebase init again, although moving those files should work fine.


May need to include "context" parameter to create accurate permalink

It seems like docid may not be enough for an accurate permalink. Here's an example of a broken link:
https://primo.lclark.edu/primo-explore/fulldisplay?docid=TN_oxford10.1093/pan/mpq009&context=L&vid=LCC&search_scope=lcc_nz_pc&tab=default_tab&lang=en_US
If you change the context to "PC", then it works. So unless we can figure out what context can be based upon the docid, may need to include context param from the Primo URL.

I made a change to the $scope.link value to pull the entire permalink (which includes the context) as opposed to just the docid:
https://github.com/blakeegee/primo-explore-report-problem/blob/cef0c133967ef8fae9a686bf34238cac10221151/js/report-problem.module.js#L19


Make deps=msvc experimentally available on non-Windows.

This makes it possible to run most of the clparser tests on non-Windows,
and is potentially useful for cross-compiling on non-Windows hosts.
Also, the manual didn't document this as Windows-only previously.
If you use this on non-Windows, please let me know, else I might undo
this change again in the future.

What tools are there for cross compiling for Windows (with the CL command line interface)? I only know about clang-cl. Though I haven't tried using it on a non-Windows machine (I'm loosely assuming that it's possible to do so), I'd like to try it in the future.

In addition to clang-cl, cl.exe might work under wine. (I'm using this with clang-cl.)

https://github.com/ninja-build/ninja/blob/master/HACKING.md#using-microsoft-compilers-on-linux-extremely-flaky
On Tue, Apr 5, 2016 at 1:38 PM, Nico Weber<EMAIL_ADDRESS>wrote:

In addition to clang-cl, cl.exe might work under wine. (I'm using this
with clang-cl.)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/ninja-build/ninja/pull/1125#issuecomment-205977832


External URL for wiki

Like the Issue Tracker "external url" would it be possible to have one for the Wiki link ?

It's now possible on develop and see in action here: https://try.gogs.io/gogs/gogs

It works so far but there is on minor annoyance.
You have to enable the wiki even if you use the external address. Which does not make much sense IMHO

If you do not enable, the tab is not even visible. Same rule apply for issues.

Yes but the difference is when you use an external wiki url you cannot use gogs internal wiki. But when you enable the issues you can use gogs internal issue tool even if you have added the external issue url.

@stonerl make sense, let me think...

My suggestion would be. When Using the internal Wiki on cannot use the external-wiki-url. When using the internal issue tracker one cannot use the external issue-tracker-url. I think one will run into problems with the issues-tracker-linking when the external and the internal-numbers are the same.

@stonerl yes, I think it would be better to rise another issue.


Right/Left arrows feature

Something like this

Somebody wants to get in "from box" ?

Something like this?

@abner86, yep)
Would you like to get this feature in next releases?
Because I don't know, if it would be useful feature or not.

Honestly, I don't think this is a useful feature. But we can add this feature in the next releases since I added a boolean property that gives devs an option if they want to display this feature to the user.

Ok, let's close this issue for now.. maybe return to it later

Please implement the feature. It would be nice to have.

I will do it on weekend)
It will be something like indicatorsControl)

This would be really helpful, tbh I was hoping this already had it  which it didnt so was bit disappointed but would be super to have it. Can we have the ability to either get the dots in the middle bottom or the side indicaters.

@LeoJHarris yes, you can put IndicatorsControl, where you want

@benazir0 @LeoJHarris I'm so sorry, guys =( I had no time to implement it on this weekend.
I will try to find time today =)
Thanks for patience )

Hi
Check it on sample project

@AndreiMisiukevich Will check, just as a side question, in the demo gifs, you have first one that has images going to the next with the images tilting over and fade out and the 2nd example gif give they just swipe across. Is there some setting for this?

Mine are fading and tilting when I move between but Im trying to just have it so it just just swipes without the effects

Want this: https://camo.githubusercontent.com/5f26de8f92151b1185d10610a0ae210c5a176c60/68747470733a2f2f6d656469612e67697068792e636f6d2f6d656469612f647530616b5843754f384254487a427561742f67697068792e676966
getting this:
https://camo.githubusercontent.com/a4d6aae8af292dc1db629441f8eefb5c963e0404/68747470733a2f2f6d656469612e67697068792e636f6d2f6d656469612f336f467a6c563574516846317564447849592f67697068792e676966

@LeoJHarris sorry, i can't see it.

On your home page for this project you have two gifs the top has a different animation then the below. I would like to get the below animation.

@AndreiMisiukevich but have to compliment you on a really cool library anyhow :)

@LeoJHarris

if you want to get "Carousel" animation, you should use CarouselView instead of CardsView

They are almost the same https://github.com/AndreiMisiukevich/CardView/blob/master/PanCardView/CarouselView.cs#L10
but have different animation processors

Yes, arrows don't response during animation process..
https://github.com/AndreiMisiukevich/CardView/blob/master/PanCardView/Controls/ArrowControl.cs#L181-L184
Do you think I should remove this check?

Thank you so much :)

Hi
1.6.3 is published
https://github.com/AndreiMisiukevich/CardView/blob/master/docs/ArrowControl (Left:Right).md


Building with zarr s3 on manjaro fails

I am trying to build it on Manjaro with support for zarr and s3:
CPPFLAGS=-DH5_USE_110_API cmake -DENABLE_NCZARR_S3=on ..
make

Building fails with the following error:
Consolidate compiler generated dependencies of target nczarr
[ 20%] Building CXX object libnczarr/CMakeFiles/nczarr.dir/zs3sdk.cpp.o
/home/gkraemer/progs/cpp/netcdf-c/libnczarr/zs3sdk.cpp: In function ‘int NCZ_s3sdkcreateconfig(const char*, const char*, void**)’:
/home/gkraemer/progs/cpp/netcdf-c/libnczarr/zs3sdk.cpp:81:31: error: cannot convert ‘bool’ to ‘Aws::Client::FollowRedirectsPolicy’ in assignment
   81 |     config->followRedirects = true;
      |                               ^~~~
make[2]: *** [libnczarr/CMakeFiles/nczarr.dir/build.make:440: libnczarr/CMakeFiles/nczarr.dir/zs3sdk.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:2264: libnczarr/CMakeFiles/nczarr.dir/all] Error 2
make: *** [Makefile:166: all] Error 2

The version of aws-sdk-cpp is 1.8.149-1

They may have changed the API. Try removing that line and see if it works.

Here is the culprit (from the aws changelog):
Another breaking change is that the type of followRedirect in ClientConfiguration changed from a true or false boolean to the enum, FollowRedirectsPolicy, including the following options:

    DEFAULT: Let the SDK decide if the underlying HTTP client should redirect a request if it receives a response with a 30x status code. With the aws-global region, the HTTP client will handle the 30x response manually. Otherwise, it will redirect the request by default.
    ALWAYS: The underlying HTTP client will always redirect the request if it receives a 30x response. (It’s equivalent to true before version 1.8.)
    NEVER: The underlying HTTP client will never redirect the request. (It’s equivalent to false before version 1.8.)

I am unable to properly compile the 1.8 (version 1.8-beta1) branch.
You may have to back down to the 1.7.9 branch of aws-sdk-cpp.

I finally gave up on this for now. I can get it to work with 1.7.301. If you cant get it, then let
me know and I will provide a copy for you.


Refactor client code into dedicated module

This moves a bunch of code from tubiniactl into it's own module at client.py. The functions should be mostly similar to the original form in turbiniactl (for the review I'm not sure if there are any "move detection" features in github to help with that).

Hey @aarontp let me know when this PR is ready for review.

@berggren Thanks for the ping, I should have added a PTAL yesterday to make it clear, but I think it's ready for review now.  Thanks!

Ack, will take a look first thing tomorrow!

Thanks for the review.  PTAL.


feat: Add "Privacy Policy" and "Terms of Service" link in footer

Changes

Added "Privacy Policy" (/privacy) and "Terms of Service" (/tos) links to the footer, accessible globally.
Updated footer text to use i18n translation keys (privacy, terms_of_service, and build_on) for localization.
Updated i18n/en_US.yaml to include the new keys.

Testing

Verified that the footer displays properly on all pages.
Checked links to ensure they redirect to the appropriate pages.

Screenshots
Before:

After:

Issue Reference
Closes #1187

Hi @sy-records and @shuashuai, I have made the changes based on your feedback. Could you please review the PR and let me know if there are any further improvements needed?

Replace the locations of /privacy and /tos in this file to maintain the same ordering.
          <NavLink to="/privacy" key="privacy" className="nav-link">
            {t('privacy')}
          </NavLink>
          <NavLink to="/tos" key="tos" className="nav-link">
            {t('tos')}
          </NavLink>

https://github.com/apache/incubator-answer/blob/3d2187d8491d582a41481e8a52f142e2750e500e/ui/src/pages/Legal/index.tsx#L34-L39

@sy-records  Thanks for feedback I will change according to the feedbacks and commit in few minutes.

Hi @sy-records , I have made the changes based on our previous discussions and feedback. Could you please review the PR and let me know if there are any further improvements needed?

@sy-records I made the changes in footer/index.tsx to as requested and made the makefile to original

Thanks guys for guiding me. I am beginner to opensource contributions.  @sy-records @shuashuai

Will my profile be visible on repo contributors list.

Will my profile be visible on repo contributors list.

Wait until your code is merged into the main branch, specifically until version 1.4.5 is released


Creating new plaquettes by copy-drag spawns extra plaquettes

When I copy a plaquette by dragging, sometimes an extra plaquette appears, usually next to the new one, but sometimes on a different part of the tileset. Example video
Mentioned in #12.

I've been testing the latest commit (macOS / trackpad) and cannot copy-drag. Will post a video when that uploads to GDrive.

For the above, need to set this.eventMode = 'dynamic'; in the plaquette class. Will submit PR

Rather than dragging by copy, it might be easier (both to use, and debug/program) to copy through a menu option.

Double click and select "Copy"
Mouse the cursor to where you want to place the plaquette. Placing can be disallowed, until a legal spot is selected
Click to copy the plaquette

Yes I was thinking of adding arrow keys @smburdick  looking forward to take a look at your PR :)

There are many additional logs statements that shouldn't be there just by mousing over the plaquettes after copying them.

I believe this may be the culprit (in makeExtensible())
		this.on('pointermove', this.onDragMove);