Tagalog Translation for widget.md

@tabuna I've just translated all the files in the docs folder. Are there more files that I have to translate? Thanks.

Hi, there is a translation file for the application itself, but it has already been translated into Thai. I thank you for your work

You're welcome @tabuna  I'll translate those files too. It will be my pleasure :)


German README.md

I've added a translation docs/de to include german, I've also added  | [Deutsch](https://github.com/reflex-dev/reflex/blob/main/docs/de/README.md) to display the availability of this translation in the other readme files
Please let me know if I have overlooked something or if there is a problem with my PR.

Thanks for the contribution.


public api

Maybe we should rename the "internal" package to something that could be imported as library?
My case is simple - I want to use goofys as a docker volume via plugin interface, not the CLI. To do that I have a wrapper for the api - https://github.com/monder/goofys-docker. But right now, goofys added in a very hacky way via submodule + symlink. It would be great if I can reference in as a normal go package.
Or it would be good to add another package with public api, and leave "internal" and "main" packages as is?

That's really cool! How well does it work in practice? The goofys "api" came about as a way to test goofys independently without going through fuse, but it wasn't meant to be stably maintained.
I don't think goofys is complicated enough to warrant a public and a private api, but I also don't want to commit to maintain a stable api unless there's a strong reason. Although from the looks of it, you only need mount/umount, which is simple enough to expose.
Feel free to send a PR to expose mount/umount. Or you can also just keep this hackish way and see how well docker likes S3 ;-) Definitely keep me posted.

closing for now, not sure if goofys-docker is still being worked on and what the API surface should be


'Publish' doesn't always work.

For some reason I could not publish a message, only save it as draft.
As long as I created a draft message with the same title, it couldn't be published.
Changing the title to something else made it work for me.

Post titles need to be longer than 3 characters - This is a hard rule enforced by the API - Sorry, it's not very well communicated when the post fails due to this at the moment.


Zookeeper Transaction Allocator Unit Test Inconsistency

Here's the log from travis-ci:
https://gist.github.com/rfecher/ce0d8c75cb015b125966

Will be included with spatial optimization since this is a really tiny fix.


ci: align node js version used in all workflows

Description
This pull request changes the following:

Changing to 20.14.0 LST

Related Issues

Closes #382

:tada: This PR is included in version 0.28.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


prange correlation

We need to add correlations for prange parfors.

looks like it has been solved by numba/numba#2492. I noticed some of the prange loops already fuse in the test cases, like test_prange08_1


[MM-14014] UI Automation: Write an automated test using Cypress for "Recently used emojis are shown 1st"

Summary
Add E2E test for recently used emoji
Ticket Link
10246
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed

Sorry for long delay.

Hi @saturninoabril,
I have some update please take a look.
And I have question why it shown error like this  DEVELOPER MODE : A JavaScipt error has occured...? I've been looking for but still didn't get it.

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @hanzei

@saturninoabril @deanwhillier Could you please review when you have the time?

@saturninoabril, I'll review once you're good with the overall test – let me know.

@saturninoabril Would you please take a look at this PR?

Thanks @hanzei.
@adzimzf I had my last comment here in case you haven't seen yet.  Basically, I'm still encountering fail running this test.

Hi @saturninoabril,
sorry for delay, I had a comment regarding failed test.

Hi @saturninoabril I have some updates.

@deanwhillier please take a look

I have rebased to master

@adzimzf Please help rebase and it's good to merge.  Thanks!

Hi @saturninoabril I have rebased.

Awesome, thanks @adzimzf 🎉

Thanks @saturninoabril for reviewing this PR and sorry for long time to complete this PR

You're welcome and no worries; we're glad to have your contributions!


Initial implementation of GitLab statistics

Issue: https://github.com/pypi/warehouse/issues/12789

Thanks for the PR! It looks great, but I'm going to hold off on fully reviewing/merging this until #8635 is resolved for GitLab URLs, so we don't run into the same issue as we have for GitHub.

#16205 looks good! I will follow it and work on Gitlab part if needed

Hello!
Do I need to rebase this PR or either merge main branch here?

@nE0sIghT Hang tight, I suspect the next part of https://github.com/pypi/warehouse/issues/8635 that we will resolve will be verifying the GitHub statistics, after which we can get this up to date. Thanks for your patience!

Could we proceed with this PR? I can rebase or merge main branch here

Sorry, I meant to comment here that this is unblocked now that https://github.com/pypi/warehouse/pull/16532 is merged. Please feel free to proceed!

Thanks! Should I merge or rebase?

Either is fine, we do squash merging so it doesn't make much difference.

I rebased PR on top of the main branch, added unit tests and tested locally

Thanks for review! I pushed new commits that should address mentioned issues.

@nE0sIghT Can you resolve the merge conflicts here? Thanks

Can you resolve the merge conflicts here?

It's done

Sorry, we have been sorting out some issues there recently :) Yes please, should be the last time!


Launch when clicking CTRL+T

Would be great if the floating bar launched when clicking CTRL+T to open a new tab

I second this


torchvision version is not passing pythonRuntimeDepsCheck

Describe the bug
Even though the version of torchvision inside search.nixos.org is 0.20.1 when i install it locally (for both nixpkgs-24.11 and nixpkgs-unstable)and check with pip it says
$ pip freeze | grep torchvision
 torchvision==0.20.1a0

The reason why this is a problem is that i have been trying to package a python package that has torchvision as a dependency. But during the build it gives me this error:
...
       > adding 'fastmri-0.3.0.dist-info/RECORD'
       > removing build/bdist.linux-x86_64/wheel
       > Successfully built fastmri-0.3.0-py3-none-any.whl
       > Finished creating a wheel...
       > Finished executing pypaBuildPhase
       > Running phase: pythonRuntimeDepsCheckHook
       > Executing pythonRuntimeDepsCheck
       > Checking runtime dependencies for fastmri-0.3.0-py3-none-any.whl
       >   - torchvision>=0.8.1 not satisfied by version 0.20.1a0
       For full logs, run 'nix log /nix/store/632ybvighvi9zax6r7s41y1g4sfzghmm-python3.12-fastmri-v0.3.0.drv'.

It is obvious that the torchvision 0.20 is bigger than 0.8.1. I wonder if this is an another bug in itself.
Here is the derivation:
 pkgs.python3Packages.buildPythonPackage rec {
        pname = "fastmri";
        version = "v0.3.0";
        src = pkgs.fetchFromGitHub {
          owner = "facebookresearch";
          repo = "fastmri";
          rev = "v0.3.0";
          sha256 = "sha256-0IJV8OhY5kPWQwUYPKfmdI67TyYzDAPlwohdc0jWcV4=";
        };
        doCheck = false;
        pyproject = true;
        build-system = with pkgs.python3Packages; [
          setuptools
          setuptools-scm # what is this
        ];
        propagatedBuildInputs = with pkgs.python3Packages; [
          torchWithCuda
          torchvision
          self.outputs.packages."${system}".runstats
        ];
        pythonImportsCheck = ["fastmri"];
      };

Steps To Reproduce
Steps to reproduce the behavior:
I made these examples into nix flakes

Run this command to reproduce torchvision version issue  nix develop github:osbm/torchvision-version
Run this command to reproduce the nix derivation error nix build github:osbm/fastmri-nix

Expected behavior
Either torchvision version should be 0.20.1 or nix python package builder should accept that the 0.20.1a0 is bigger than 0.8.1.

Screenshots
None

Additional context
I love nix

Metadata

system: "x86_64-linux"
host os: Linux 6.6.66, NixOS, 24.11 (Vicuna), 24.11.20241219.b47fd6f
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.24.10
nixpkgs: /nix/store/yrg3gx1g04dfwn7qjxm06165d8ndxdpl-26h92s5nj1h7ky9bk6yf71am5zc121j8-source

Notify maintainers
torchvision maintainer - @ericsagnes

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

I actually was able to suppress my issue using the dontCheckRuntimeDeps = true; option. But the problem still remains.

I am pinging python maintainers because i think this is related but if im wrong i am sorry
@natsukium @hexa


Message with attachment & Facebook

A message with an attachment incorrectly display in Facebook messenger.
For example message
{   "conversationId": "8a684db8",   "language": "en",   "text": "Test image attachment.",   "attachments": [     {       "contentType": "image",       "contentUrl": "http://aka.ms/Fo983c"     }   ]   ... }
will be display two message with picture, but not display "Test image attachment." text.
The same case happens with cards...
PS Also Facebook require ContentType image, not image/png, It would be good to bring it to a single mind at the connector level

@tomlm Any thoughts?

the facebook connector was completely rewritten for V3, this should work.

Thanks for closing!


Configurable Security Contexts

Hardcodes some sane security defaults

runAsNonRoot: true
allowPrivilegeEscalation: false
readOnlyRootFilesystem: true
capabilities:
   drop:
   - all

~- Allows users to configure runAs User/Group globally for the deployment~

with container fs set as readonly, add emptyDir volumes for containers that need to write locally

FREQQ-110

We're hard-coding the UID/GIDs for the pachyderm components but a user can still configure the user ones for pipelines via the pipeline spec. For more advanced changes, it requires using a pod_patch

One breaking change in this PR:
disabling security contexts is now done globally with a single value at global. securityContexts.enabled=false, instead of securityContexts.enabled=false under each service. This only really applies to OpenShift users


Make Strain Design Dialog Compatible With Smaller Screen Sizes

When I use the strain design dialog with the advanced KI/KO settings (see image attached), it is too high for my screen resolution and there is no way to access the lower controls. Hence, a scroll-bar solution or a reorganization of the elements to the right side would be helpful.

Done with #370


Y24-217 push historic data to warehouse

Closes #https://github.com/sanger/traction-service/issues/1371
Changes proposed in this pull request

Creates a rake task to push all aliquots to the warehouse using EMQ

Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

This is actually a very good opportunity to test the robustness of our messaging platform and our overall volume tracking solution. I suppose we could use training data, and cross-check the UAT mlwh aliquots table since the training instance of our message consumer is pointed to UAT mlwh (mlwh doesn't have a training instance).
Yes, I have dumped the training data to the local database and tested it locally, which seems to be working fine, at least checked until the point where it is successfully publishing to mlwh consumer queue.
While testing it in uat, we can check whether the other end works as well so it updates the mlwh table.

This is actually a very good opportunity to test the robustness of our messaging platform and our overall volume tracking solution. I suppose we could use training data, and cross-check the UAT mlwh aliquots table since the training instance of our message consumer is pointed to UAT mlwh (mlwh doesn't have a training instance).

Yes, I have dumped the training data to the local database and tested it locally, which seems to be working fine, at least checked until the point where it is successfully publishing to mlwh consumer queue. While testing it in uat, we can check whether the other end works as well so it updates the mlwh table properly.

Nice. We can check full end to end process if we do this in training. We will have to do some sort of cross validation to check the consistency of the data between the aliquots in traction and the ones persisted in mlwh.


Adding api_management module

This contains all the code for the api_management module

hi @abdulrabbani00, is this PR ready for review? do you plan to add more?

@arnaudlh - This is ready for review. My apologies for not having submitted it earlier.

Can we just name the folder as "modules/api_management" rather than "modules/api_management_services" - just to in inline with other module folders

Thanks @abdulrabbani00 for this PR, we have merged #888 for APIM coverage in 5.5.1 as it seemed to have broader coverage, but I'm sure it could be extended and improve. Let us know if we have missed something out there as we always value your contribution :)


Order of points affects linear interpolation results

Describe your issue.
I noticed that the order in which I pass 2D points to scipy.interpolate.griddata affects the output of the interpolated results, sometimes quite drastically. For example, this code block sometimes produces one interpolation, and sometimes the other interpolation, depending only on  the order of the points. Why the inconsistency?

Reproducing Code Example
import numpy as np
import matplotlib.pyplot as plt
from scipy.interpolate import griddata

values = np.array([5.25, 5.0, 4.95, 5.0, 5.2, 5.3, 5.35, 5.4, 5.1, 4.9, 4.8, 5.45, 5.35, 5.2, 5.3, 5.25])
coords = np.array([[0, 4], [1, 4], [2, 4], [3, 4], [4, 4], [4, 3], [4, 2], [4, 1], [4, 0], [3, 0], [2, 0], [1, 0], [0, 0], [0, 1], [0, 2], [0, 3]])
coords = coords * 1e4

shuffled_idx = np.array(list(range(len(coords))))
np.random.shuffle(shuffled_idx)

xi=np.linspace(0, 1e4, int(1e4 // 50))
yi=np.linspace(0, 1e4, int(1e4 // 50))
X,Y=np.meshgrid(xi,yi)

gap_interpolated=griddata((coords[shuffled_idx, 0], coords[shuffled_idx, 1]), values[shuffled_idx], (X,Y), method='linear')

plt.gca().set_aspect('equal', adjustable='box')

plt.contourf(X, Y, gap_interpolated)
plt.colorbar()
plt.show()

Error message
N/A

SciPy/NumPy/Python version and system information
1.10.1 1.22.4 sys.version_info(major=3, minor=10, micro=12, releaselevel='final', serial=0)
Build Dependencies:
  blas:
    detection method: cmake
    found: true
    include directory: unknown
    lib directory: unknown
    name: OpenBLAS
    openblas configuration: unknown
    pc file directory: unknown
    version: 0.3.18
  lapack:
    detection method: cmake
    found: true
    include directory: unknown
    lib directory: unknown
    name: OpenBLAS
    openblas configuration: unknown
    pc file directory: unknown
    version: 0.3.18
Compilers:
  c:
    commands: cc
    linker: ld.bfd
    name: gcc
    version: 10.2.1
  c++:
    commands: c++
    linker: ld.bfd
    name: gcc
    version: 10.2.1
  cython:
    commands: cython
    linker: cython
    name: cython
    version: 0.29.33
  fortran:
    commands: gfortran
    linker: ld.bfd
    name: gcc
    version: 10.2.1
  pythran:
    include directory: /tmp/pip-build-env-xob7rtip/overlay/lib/python3.10/site-packages/pythran
    version: 0.12.1
Machine Information:
  build:
    cpu: x86_64
    endian: little
    family: x86_64
    system: linux
  cross-compiled: false
  host:
    cpu: x86_64
    endian: little
    family: x86_64
    system: linux
Python Information:
  path: /opt/python/cp310-cp310/bin/python
  version: '3.10'

As much as I know this is an acceptable behaviour.
You should call griddata with rescale=True
From the documentation of griddata:
rescale : bool, optional
    Rescale points to unit cube before performing interpolation.
    This is useful if some of the input dimensions have
    incommensurable units and differ by many orders of magnitude.

When I added rescale=True to your example, the difference between the two results was reduced to about 1e-15.

Hmm, even with rescale=True I'm still observing the two different interpolations, which have a maximum difference of 0.48 at the center

Qhull triangulation is not unique, thus it's probably not avoidable. Also note that if your data is on a grid, griddata is not the right tool, use RegulatGridInterpolator instead. That one is unique btw.

I don't believe there is a bug for us to fix really, so am going to close this issue. Can continue discussing of course.


Codeflow: Can't push a commit [remote rejected] main -> main (push declined due to email privacy restrictions)

Describe the bug
My github account enforces privacy for the email address. In codeflow, the git config email is tied to my stackblitz email which cannot be chaged.
Link to the blitz that caused the error
https://stackblitz.com/~/github.com/danielduckworth/langchain-vue3-app
Steps to reproduce

Enable email privacy on github: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address#setting-your-commit-email-address-on-github
Import a github repo in Codeflow
Commit a change and push

Expected behavior
Using git config --global user.email "my-private-github-email" should enable the commit to work.
Parity with Local

[X] I have run the project in my local machine and I could not reproduce the issue.

Screenshots
No response
Platform
Version = 1.72.0
Hash = eb830b448d6f85984cc7a6d3a21311b5d6640759
WebContainer = d5d65229

Browser name  = Chrome
Full version  = <IP_ADDRESS>
Major version = 115
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 Edg/115.0.1901.188
performance.memory = {
  "totalJSHeapSize": 187129046,
  "usedJSHeapSize": 178440878,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}

Additional context
No response

Hey @danielduckworth 👋 . Thanks for reaching out. We're already tracking this issue as it was reported in #933. Closing it in favour of that one. Feel free to leave a 👍 on that issue.


4.16.0 - release notes, invalid date of the live stream

Bug description
In release notes of 4.16.0

How to reproduce
unless I've missed and it already was on the 1st of June.
Expected behavior
No response
Prisma information

// Add your schema.prisma

// Add your code using Prisma Client

Environment & setup

OS:
Database:
Node.js version:

Prisma Version
4.16.0

Thanks, fixed the date in the release notes to June 22nd based on the Youtube description.


Change font size

There's no way to change the font size in ther terminal, right? At least not via the UI.

@black-snow that's correct; it's not there yet. Although, there is an open issue already, so I'll close this one. Please make sure to vote for that issue if you want to see it implemented sooner. https://github.com/railsware/upterm/issues/1113

Weird that the search didn't show me that issue ... thanks.

@black-snow now you can change font size with Cmd++ and  Cmd+-. Or  Ctrl, if you use Linux.

Awesome!
Which version ships this? Not working in 0.2.161

It's not released yet, but you can clone the repo and run npm run pack. Or wait for a few days for a new release.

Aight, thanks

May I ask you a few questions about your experience with Upterm?

Of course. Feel free to mail me @ info at black-snow.net

There is nothing private, so I'll ask here. If you don't feel like answering them in public my email is<EMAIL_ADDRESS>
What made you switch to Upterm?
Is there anything that annoys you?
What features do you miss?
How did you find Upterm?

Actually I haven't fully switched to upterm. I use the default OS X terminal, my IDE/editor's integrated terminal and upterm at the same time (silly, isn't it?). But let me tell you what I find great about upterm:
1.1 Current path shown in the bottom (awesome!)
1.2 Tooltips and notifications (nice!)
1.3 Colors (bg color)
1.4 Search
1.5 Showing me the git branch? Just recognized that. F*ck yeah.
Somewhat.
2.1 Search results get lost when something's happening in the terminal.
2.2 Confused when first starting upterm for it's just showing a blank window. Wait, this is a terminal, right? Why isn't there a cursor in the top left? Maybe we could show some text instead of an empty background? (As it's done in Atom.)
2.3 Background color sometimes confusing. I guess it's always red when the exit code wasn't 0? Some programs I use usually don't exit with 0 / are throwing some hints and warnings but nothin critical. Always takes me a second look cuz I think something's gone badly wrong due to the red punching me in the face.
2.4 Updates from within the app would be nice. (instead of brew cask reinstall upterm)
2.5 Font size (already addressed)
2.6 No "about upterm" in the menu. That's ... uncommon.
2.7 Sometime's focus seems gone on the input but when I type it actually goes in there. That's weird.
2.8 Why can't I cd $SOMEVAR? I have some shortcuts for common paths like $HT for my htdocs. I commonly cd $HT but that's not working in upterm ... echo $HT does echo the contents just right.
->
3.1 Having an "edit .bashrc" and "edit .ssh/config" etc. in the menu would be a nice shortcut.
3.2 No titles for the tabs. That's actually annoying. I don't remember which tab's what. At least let me rightclick + set a title.
3.3 Also it's hard to see which tab is active. More contrast or some other indicator please!
3.4 It'd be sweet if I could click the branch icon (git) to switch it (visually).
Don't remember. Probably https://github.com/sindresorhus/awesome-electron

Also there's this:
(node:4092) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 end listeners added. Use emitter.setMaxListeners() to increase limit
process.on @ internal/process/warning.js:21

Wow, that's a great feedback, @black-snow, thank you so much! We already have open issues for some of your concerns, but I'll make sure to create ones for the rest. Also, updates within the app are already implemented, you'll see a notification when the next version is released.


[marl] Update to 2020-06-30

Describe the pull request

What does your PR fix? Fixes #11953

Update to 2020-06-30
Repoint HEAD_REF to main (#11953)
Dynamic build support

Which triplets are supported/not supported? Have you updated the CI baseline?
N/A. No.

Does your PR follow the maintainer guide?
Yes.

@ben-clayton

LGTM, thanks for the update and new manifest mode!


Scroll to top button

There must be a scroll to top button . i would love to work on this issue . please assign it to me under gssoc-extended , hacktober fest accepted  and with suitable level.

I see this issue hasn’t been assigned yet. I’d be happy to take it on. Could you please assign it to me? Thank you!

@Tejashri-Taral  but this issue must be assigned to me .


fix(Subscription): Limit Subscription::closed public accessibility to readonly

Description:
This PR changes the signature of ISubscription::closed to readonly.
Currently, it is allowed to change state of closed as well as unsubscribe() but those two are causing different outcome by unsubscribe actually does necessary teardown for unsubscription, while closed flag only changes state flag. Instead, this PR explicitly makes given flag as getter only to read state, otherwise let use unsubscribe() if needed.
This is indeed breaking change if anyone has been using closed to control subscription state, it won't work anymore. For now, I have targeted this to master until gets reviewed and approved.
BREAKING CHANGE: Cannot change closed state without unsubscribe()
Related issue (if exists):

Coverage decreased (-0.01%) to 97.675% when pulling 0ef4d83025ceab9d715215a595df7e6cde68a222 on kwonoj:fix-subscription-closed into 6922b16f4a297a4acbe8ad2b086c947b7c0d8315 on ReactiveX:master.

Coverage decreased (-0.01%) to 97.675% when pulling 0ef4d83025ceab9d715215a595df7e6cde68a222 on kwonoj:fix-subscription-closed into 6922b16f4a297a4acbe8ad2b086c947b7c0d8315 on ReactiveX:master.

Coverage decreased (-0.01%) to 97.675% when pulling 0537a32205e593cdae26fc28292d11bc17ca799f on kwonoj:fix-subscription-closed into 6922b16f4a297a4acbe8ad2b086c947b7c0d8315 on ReactiveX:master.

Coverage decreased (-0.01%) to 97.675% when pulling 0537a32205e593cdae26fc28292d11bc17ca799f on kwonoj:fix-subscription-closed into 6922b16f4a297a4acbe8ad2b086c947b7c0d8315 on ReactiveX:master.

Coverage decreased (-0.01%) to 97.675% when pulling b64e50c39324ab00e343d6c912d23de8157bf870 on kwonoj:fix-subscription-closed into 6922b16f4a297a4acbe8ad2b086c947b7c0d8315 on ReactiveX:master.

Coverage decreased (-0.01%) to 97.675% when pulling b64e50c39324ab00e343d6c912d23de8157bf870 on kwonoj:fix-subscription-closed into 6922b16f4a297a4acbe8ad2b086c947b7c0d8315 on ReactiveX:master.

I'm not sure why this change is necessary. How does it effect perf?

Way I'm seeing this change is enhancing ergonomics with small complexity addition in codebases.
It is indeed this codebase is javascript and anyone can actually do anything if they try to avoid given interfaces, on the other hand if library's interface prevents any accidental incorrect usage, it would be better to prevent user's confusion.
Perfwise, previously it is just property access and with this change it'll be getter function, () => boolean. I do agree this adds complexity course, but it's small, though gain is also not quite hugh - small complexity, small gain.
If this change doesn't seems give sufficient benefit to library users, I'd like at least propose to update signature of ISubscription only which is free gain for typescript user without any codebase complexity- created https://github.com/ReactiveX/rxjs/pull/2249 for it.

Honestly, @kwonoj, I think I'm :-1: on this change and other changes like it. I'm happy with TypeScript enforcement (and possible _name "enforcement" in "private" or "protected" variables cases) for now.
I'm willing to be convinced otherwise, of course. But right now I'm not feeling it.

@blesh fine for me. Just one thing, can we add this as agenda for how much of runtime guarantee / validation we'd like to provide? Currently codebase barely does not provide anything on it, and this PR is kind of those to adding some more soundness on runtime (by introducing runtime complexity). As you can see, there are some of opened issues to demand certain level of runtime validation which non-TS user could benefit. User of TS this doesn't be too much issues for myself, but worth to think of where to draw those lines (such as it's already good as-is vs. we need something more)
Closing PR without checking it.

@kwonoj that's fine. I'm happy to discuss it.
I'm on the side of: "If you want soundness, use a type system, otherwise this is JavaScript and I'll duck-punch all the things I want"
Although, I really would like to go through and rename all private and protected variables to have underscores before them. That's been bothering me.

I really would like to go through and rename all private and protected variables to have underscores before them. That's been bothering me.

: That maybe sufficient soundness of runtime level we'd like to achieve. I think having settled down line would be great whatever level we'd like to have.


Optimized prompt and set hard limit to agent as guard rail

Optimized prompt to limit tool usage to just 1, making it ~5s faster
Added a max iteration for the agent as a guard rail in case it decides to go in an infinite loop

LGTM


breaking: remove deprecated behavior

Removes the following behavior, which has been deprecated for about a year:

Providing the id as the dataframe index, it has to be a column. Also the outputs from the methods will now always have the id as a column.
Providing sort_df to fit and cross_validation, we always check if it's sorted.

Also updates the documentation to remove usages of this behavior, docs that use datasetsforecast.losses and uses utilsforecast.plotting.plot_series instead of StatsForecast.plot

I removed the uses of datasetsforecast.losses, the ones that set the env variable wouldn't be broken but it can be confusing. We still have to update all notebooks which have a reset_index in them but I wanted to finish this within my lifetime so I didn't do it here but I'll update this PR when I get time to run those as well.


Update README fix typo and include link

Fixed "FINE APP" to industry canonical terminology of "FINE APP FRAMEWORK".
Also included a link to the mentioned "FINE APP FRAMEWORK".

@jasonjchang :sob:


KAFKA-15507: Make AdminClient throw non-retriable exception for a new call while closing

AdminClient will throw IllegalStateException instead of TimeoutException if it receives new calls while closing down. This is more consistent with how Consumer and Producer clients handle new calls after closed down.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@tinaselenge ,  kafka.api.PlaintextAdminIntegrationTest.testDelayedClose is failing because of this PR. Could you take a look? Thanks.

Failed tests are unrelated.


Only try to create the xdg-surface once.

When more than one supported XDG-Shell protocol is available (for example both xdg and xdg_v6 can be available) we should not try to do the xdg-surface initialization more than once.
This fixes running dyz inside weston inside x11 after 5974ec1539a704c1054f0023d0503d39cf623f31
I'm getting defined both xdg and xdg_v6, picking any of them works, but trying to do the initilization of the xdg-surface causes a fatal error:
zxdg_surface_v6@12: error 0: Cannot assign role xdg_toplevel to wl_surface@3, already has role xdg_surface

I have submitted a new patch replacing the order in which the protocols are tested.
Now it should select the first protocol that matches the order: IVI > xdg_v6 > xdg


sslSecrets false option didnt take the given cacert and password

Internal and External listeners use SSL.
I have configured
sslSecrets:
tlsSecretName: "ssl-secret"
jksPasswordName: "ssl-pass"
create: false
ssl-secret contains
Name:         ssl-secret
Namespace:    kafka
Labels:
Annotations:
Type:  Opaque
Data
caCert:  1391 bytes
caKey:   1679 bytes
ssl-pass contains
Name:         ssl-pass
Namespace:    kafka
Labels:
Annotations:
Type:  Opaque
Data
password:  6 bytes
Kafka is up and Running
But on checking the broker config it has different certificate and password.

Checked in below locations
/var/run/secrets/java.io/keystores/server/controller/
/var/run/secrets/java.io/keystores/server/external
/var/run/secrets/java.io/keystores/server/internal
/var/run/secrets/java.io/keystores/client/

Hello!
Thank you again the feedback.
This is a bug because currently the operator doesn't use the jksPasswordName field.
The password is autogenerated for the keystore.
You can get the password from the broker configmap: kubectl get configmaps kafka-config-0 -o yaml
or from the generated secrets for the listeners:  k get secrets kafka-server-certificate -o yaml
I have tested it.

Thank You @bartam1
It works fine as you said.

We have created an internal issue tracking this unexpected behavior.
If it is okay for you @lavis11 we would like to keep this issue open until that one is resolved.

I'm okay with it  @pregnor


Question relates to DHCPS_LEASE_UNIT option and how to change the dhcp server lease time. (IDFGH-13342)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
DHCPS_LEASE_UNIT was defined in https://github.com/espressif/esp-idf/blob/bdb9f972c6a1f1c5ca50b1be2e7211ec7c24e881/components/lwip/include/apps/dhcpserver/dhcpserver.h#L68
DHCPS_LEASE_UNIT's usage: https://github.com/espressif/esp-idf/blob/bdb9f972c6a1f1c5ca50b1be2e7211ec7c24e881/components/lwip/apps/dhcpserver/dhcpserver.c#L429-L432
It seems the configured dhcps->dhcps_lease_time was multiplied by a factor when offering. Wouldn't this cause mismatch of the LWIP DHCP pool retention time and the client lease time? i.e., LWIP only offers 5 minutes of lease but the client was told the lease time is 300 minutes.

If I want to change the default lease time, what is the correct way?

call esp_netif_dhcps_option

 uint32_t dhcp_lease_time = 864000;
esp_netif_dhcps_option(usb_netif, ESP_NETIF_OP_SET, ESP_NETIF_IP_ADDRESS_LEASE_TIME, &dhcp_lease_time, sizeof(dhcp_lease_time));

idf.py menuconfig and set LWIP_DHCPS_LEASE_UNIT to 7200 (because the default lease time is 120, 864000/120 ==7200)

P.S. The description of LWIP_DHCPS_LEASE_UNIT is not very clear to me:
 The DHCP server is calculating lease time multiplying the sent and received times by this number of seconds per unit. The default is 60, that equals one minute.

what is the sent and received times?

According to the FAQ, the unit of ESP_NETIF_IP_ADDRESS_LEASE_TIME is minute. I will stick to this method. But it does not answer whether the dhcp server and client would having different lease time.


test tooling (phantomjs support?)

The fact that ember-collection doesn't run in phantomjs tripped me up for a time; at the least the documentation should mention that, as phantomjs is standard config for ember-cli apps.
Better would be to get it to work in phantomjs, though; we need a requestAnimationFrame polyfill. I tried https://github.com/cagosta/requestAnimationFrame but couldn't get it to work. Any ideas?

I ran into this issue and was able to use this polyfill for phantomjs
https://gist.github.com/paulirish/1579671

ah great :)

If it helps, I installed this polyfill
bower install raf.js
and then updated my ember-cli-build.js
with
  /**
   * phantomJS needs a polyfill of requestAnimationFrame, which
   * is used in ember-collection.
   */
   app.import('bower_components/raf.js/raf.min.js', {test: true});


How to scroll content of the page? (that sits outside of Ionic)

I'm using Ionic to build a mobile web app.
On larger screen I'm displaying an image:

At first I was using iframe but that was causing issues on iOS, eventually ended up using this: https://github.com/driftyco/ionic/issues/1534#issuecomment-44946144

Now that causes problems with scrolling:
Video: https://www.youtube.com/watch?v=ShNQr3eNUCM (2m 25s)
Plunker: http://plnkr.co/edit/TNU6iQN30WZgmqwg80Tl?p=preview

I wonder which CSS classes shall I modify to allow scrolling on body?
I know that it is outside core mission of Ionic but I'm pretty sure you can give me a hint.
Related question on SO: http://stackoverflow.com/questions/9280258/prevent-body-scrolling-but-allow-overlay-scrolling
Thanks!

add two styles: scroll-content overflow-scroll


Onboarding

Description

[x] Add Layout component and wrap all View components with it (hence the many file changes 🥴)

In a later PR this will also handle wrapping pages with Header/Sidebar etc.
For now, it will handle displaying the "onboarding" dialog on any page for a "new" user.

[x] Add OnboardingDialog (used inside Layout) to show CLOUD users on first load (using local storage)
[x] Cleanup ServiceTemplatesDialog to align with others.

Demo
https://user-images.githubusercontent.com/7349341/122558935-514a2080-d047-11eb-8f3d-0bfcaa2220a6.mp4
How to Test
Because we're only showing this Dialog to CLOUD users on first load, here's what you can do to debug/recreate locally…

Override the config in services/orchest-webserver/client/src/main.tsx   <DesignSystemProvider>
--   <OrchestProvider {...config}>
++   <OrchestProvider config={{ ...config.config, CLOUD: true }} user_config={config.user_config}>
       <App />
     </OrchestProvider>
   </DesignSystemProvider>

Clear your local storage (after each "close", a key will be set to state that onboarding has been completed)

Checklist

[x] The documentation reflects the changes.
[x] I have manually tested the application to make sure the changes don’t cause any downstream issues, which includes making sure ./orchest status --ext is not reporting failures when Orchest is running.
[ ] In case I changed code in the orchest-sdk, I updated its version according to SemVer in its _version.py and updated the version compability table in its README.md

[ ] In case I changed one of the services’ models.py I have performed the appropriate database migrations.

@joe-bell Can we merge this into dev instead of master?

Update: Added indicator dots based on feedback

@ricklamers all change requests have been made!

Fantastic job @joe-bell glad with the end result.
As per discussion, we'll later replace the fixed height for a dynamic (tallest component height) solution.


About axis parameter

Hello titu 1994.
I use group normalization code for my project.
If i use GN after a layer whose output shape is (batch_size, C, D, H, W), is it okay to set axis = 1 because the format is channel-first?

Yes that's fine.


completeMergeReferences should not hide MergeDataTransferModal, inste…

…ad when MERGE_BUTTON_API_DISPATCH reducer returns, it should set that to hide.  Also MergeDataTransferredModal can show when dataTransferHappened and mergeTransferringCount is zero, or also when mergeCompletingCount is not zero, because the merging is still happening, but the modal hasn't come up yet.  This is confusing, but it works and fits the story

It sounds complicated to me.  =)

haha, thanks @sweng66 !


[DoNotMerge][Tests-Only] Run tests for operations on file with commas in ocis

Fails are in multilinkSharing.feature which is unrelated and needs update of ocis from ocis-reva


Plot cbs take ax

I'm not sure why the example deletions ended up on this branch, but in any case they are intentional (having been superceded by documentation already in master).

Ready for another round of review.

Travis is happy; codecov patch is complaining that we don't test all the input-validation cutouts. OK to merge as is?


Disable bastion tests for CAPV during upgrades

We don't support bastion for CAPV and upgrade tests are failing because of this check now.
What this PR does
Checklist

[x] Update changelog in CHANGELOG.md.

Trigger e2e tests

/run cluster-test-suites

/run cluster-test-suites

Upgrade tests are run on this repo so I'm gonna add the skip/ci label.

It failed for my PR here https://github.com/giantswarm/cluster-vsphere/pull/86

Yeah, I mean the upgrade tests are skipped when triggered from this repo as there's nothing to upgrade to.
Feel free to merge this in and do a new patch release.


Apple DEP supported with PTA?

If I read the below link correctly (and as stated in the comments) it should be possible to use Apple DEP with PTA. Maybe update the documentation and add a description how the experience changes?
https://blogs.technet.microsoft.com/intunesupport/2018/02/08/support-for-multi-token-dep-and-authentication-with-company-portal/

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c535414b-05a2-d4b5-8f15-5c93274d25ef
Version Independent ID: 0bef709f-d10f-5fe6-68a8-f21d0204ecd5
Content: Azure AD Connect: Pass-through Authentication - Current limitations
Content Source: articles/active-directory/connect/active-directory-aadconnect-pass-through-authentication-current-limitations.md
Service: active-directory
GitHub Login: @swkrish
Microsoft Alias: billmath

@chwilfing Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

@chwilfing thank you for this.  I am following up with the PM on this.

@chwilfing  thank you for submitting this.  It is taking me longer then expected to get a response so I have created a work item for this, as this is going to require me to get some verification from the engineering team.  At this point I am going to close the issue and I will re-open this once I have an updated.  Thanks again!

#please-close

@chwilfing We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Submit the application of GreenVerse

Project Abstract
GreenVerse is an innovative platform that combines gamification with sustainability, empowering users to take tangible actions towards a greener future. By offering diverse eco-friendly challenges, a rewarding point system, GreenVerse makes it fun and rewarding for users to adopt sustainable habits. With impact tracking features and strategic partnerships with environmental organizations and eco-conscious brands, GreenVerse provides users with the tools and support they need to make a real difference in the world.
GreenVerse leverages interoperability and scalability of Substrate and the Polkadot ecosystem to allow existing users and projects to interact and collaborate with it easily.
Grant level

[ ] Level 1:  Up to $10,000, 2 approvals
[x] Level 2:  Up to $30,000, 3 approvals
[ ] Level 3:  Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

[x] The application template has been copied and aptly renamed (project_name.md).
[x] I have read the application guidelines.
[x] Payment details have been provided (Polkadot AssetHub (DOT, USDC & USDT) address in the application and bank details via email, if applicable).
[x] I understand that 30% of each milestone will be paid in vested DOT, to the Polkadot address listed in the application.
[x] I am aware that, in order to receive a grant, I (and the entity I represent) have to successfully complete a KYC/KYB check.
[x] The software delivered for this grant will be released under an open-source license specified in the application.
[x] The initial PR contains only one commit (squash and force-push if needed).
[x] The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
[ ] I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

I have read and hereby sign the Contributor License Agreement.

recheck

I have read and hereby sign the Contributor License Agreement.

recheck

Hi @keeganquigley , thanks a lot for the reply! I've looked into the Decentralized Future program and it seems like a good match for our project. Thanks for the recommendation and please close my application here then.

Sounds good @hermione6 thanks for your reply. I'll go ahead and close it, and you can always re-apply if it isn't accepted in DF program. Cheers!


Efilter cant install

Efilter setup.py is broken because it tries to import efilter code before this is actually installed.
The symptom is that the installation breaks if six is not installed yet, because efilter tries to transitively import it.

Looks like this is fixed?


purescript.compile

Can I do something like
var purescript = require("purescript")
var js = purescript.compile("Code here")
console.log(js)

Use child_process module.

@shinnn You should not use child_process if you want to see your project alive.

You should not use child_process if you want to see your project alive. If you want to understand why please use StackOverflow

@askucher http://www.catb.org/esr/faqs/smart-questions.html#writewell


Adds in Sophronia Broadcasting as a Company

Sophronia Broadcasting is referenced by the Ingredient Beacon given to the Cook with, "Please enjoy your Sophronia Broadcasting's 'Plasteel Chef' Ingredients Box, exactly as shown in the hit show!", as well as the Curators Hero Beacon with, "Please enjoy your Sophronia Broadcasting's 'History Comes Alive branded' Costume Set, exactly as shown in the hit show!". I think it'd be a sensible addition, and adds nicely to any any reporter crewmembers, or a reporter AI who don't know what company they should say they work for. The original idea behind the company was that they were involved in mind control experiments, but it wasn't referenced in the game so I didn't add it.

seems good to me

seems good to me


RSP 2.2 and PE 2.1 modules

I have updated the ASN.1 module of the GSMA RSP specification v2.2 and for the SIMAlliance profile package file format v2.1.

Ok thanks, I updated the GSMA Specs manually


Advancements loading disable config flag

A flag to disable advancements loading completely. Sometimes advancement loading throws tonns of exceptions and startup slowdowns. IIRC, this isn't fixable now and this isn't sponge issue.

Nvm, found pr to fix this


Improvement: Support RSA Private Keys ( PKCS#1)

Right now only Private Keys are supported ( PKCS#8).
We may support  (PKCS#1) in order to avoid the user to manipulate and convert its private key.
as described on the setting file

@pitbulk Is this issue still relevant ? If yes, I can give it a go.


importer issues with large checkpoint managements

currently occurring on multiple CP managers

[x] verify that only enabled gateways are inspected for CPR8x importer
[x] do test import with anonymized customer data

error was on corrupt cp manager which could not return full details for all rules:
Tests run:

standard case:

curl --insecure --request POST   --url https://xxx/web_api/show-access-rule --header 'Content-Type: application/json' --header "X-chkp-sid: $SID"  --data '{"uid": "acd36164-ad78-402e-bbfb-c4e2af986653", "details-level": "standard", "layer": "xxx Network" }'
{
"uid" : "acd36164-ad78-402e-bbfb-c4e2af986653",
"type" : "access-rule",
[…]

same rule with full details:

curl --insecure --request POST   --url https://xxx/web_api/show-access-rule --header 'Content-Type: application/json' --header "X-chkp-sid: $SID"  --data '{"uid": "acd36164-ad78-402e-bbfb-c4e2af986653", "details-level": "full", "layer": "xxx Network" }'
{
"code" : "generic_server_error",
"message" : "Management server failed to execute command"
}

not affected rule can be read in full:

curl --insecure --request POST   --url https://xxx/web_api/show-access-rule --header 'Content-Type: application/json' --header "X-chkp-sid: $SID"  --data '{"uid": "dd09410f-4486-449d-823f-3c29f46d0fcc", "details-level": "full", "layer": "xxx Network" }'
{
"uid" : "dd09410f-4486-449d-823f-3c29f46d0fcc",
"type" : "access-rule",
[…]


SOLR-17034: Hitting /solr// ends up with HttpSolrCall NPE

https://issues.apache.org/jira/browse/SOLR-17034

Yea I looked at adding a test for this but couldn't find a good place. I think its pretty obvious that origCoreName can be null since a few lines later is on line 1181 is:
if (origCorename != null) {

so there is obviously a need for this check in normal cases.


ARROW-14750: [Release] Update post-03-website.sh for 6.0.1

Add more artifacts

AlmaLinux
Amazon Linux
C#

Add support for patch release
Ensure updating base branch of arrow-site

+1


GO:0103064	inositol phosphorylceramide mannosyltransferase activity  parent query

SPAC2F3.01
I am picking up a mapping for
GO:0000030	 mannosyltransferase activity IBA with A0A1D8PIF7 , S000000365 , S000005978 , PTN001285482
Is  already annotated to
GO:0103064	inositol phosphorylceramide mannosyltransferase activity ISO with S000000365
So, should  GO:0000030	 mannosyltransferase activity be a parent of  GO:0103064 (or should the GO:0000030 annotation be removed), I am not sure?

This should be fixed from another ticket (#23995) which made GO:0103064 a child of GO:0000030. I will close this now.


[WTD] Azure Active Directory Inclusion Articles

In support of #31413, here is a list of articles with line numbers of where non gender neutral language is present.

[ ] concept-password-ban-bad.md Line   #77
[ ]   one-time-passcode.md Line   #65
[ ]   plan-conditional-access.md Line   #79
[ ]   active-directory-saml-claims-customization.md Line   #46
[ ]   enterprise-state-roaming-enable.md Line   #84
[ ]   active-directory-groups-view-azure-portal.md Line   #123
[ ]   perform-access-review.md Line   #71
[ ]   plan-hybrid-identity-design-considerations-business-needs.md Line   #25
[ ]   plan-hybrid-identity-design-considerations-incident-response-requirements.md   Line   #48
[ ]   plan-hybrid-identity-design-considerations-lifecycle-adoption-strategy.md   Line   #39
[ ]   reference-connect-adconnectivitytools.md Line   #34
[ ]   reference-connect-adconnectivitytools.md Line   #314
[ ]   reference-connect-adconnectivitytools.md Line   #34
[ ]   reference-connect-adconnectivitytools.md Line   #314
[ ]   tshoot-connect-sync-errors.md Line   #191
[ ] overview-v2.md   Line   #156
[ ] overview-v2.md   Line   #179
[ ] overview-v2.md   Line   #181
[ ] overview-v2.md   Line   #183
[ ]   application-sign-in-problem-first-party-microsoft.md Line   #87
[ ]   answerhub-tutorial.md Line   #194
[ ]   boomi-tutorial.md Line   #252
[ ]   boomi-tutorial.md Line   #257
[ ]   clickup-productivity-platform-tutorial.md Line   #204
[ ]   landgorilla-tutorial.md Line   #187
[ ]   opsgenie-tutorial.md Line   #221
[ ]   pagedna-tutorial.md Line   #171
[ ]   rollbar-tutorial.md Line   #244
[ ]   rollbar-tutorial.md Line   #244
[ ]   tigertext-tutorial.md Line   #156
[ ]   turborater-tutorial.md Line   #158
[ ]   uberflip-tutorial.md Line   #160
[ ]   workday-inbound-tutorial.md Line   #966
[ ]   manage-user-access.md Line   #37
[ ]   manage-user-access.md Line   #47
[ ]   manage-user-access.md Line   #37

Working on this.

Complete--gender neutral language has been suggested for all items.


fix: use the synced locale on client if set during SSR

If vuex.syncLocale is true, then any locale determined on the server during SSR should be used as initial value by the client.
This also allows:

Not to determine the language twice when a page is loaded (once on the server, then again in the client)
Other plugins (e.g. user session in a universal app) to alter the locale during bootstrap (await app.i18n.setLocale('xx')) and make sure that that locale is re-used on the client.

Note that I think that this should be default behavior for this module.

I think it makes sense but would need some tests for it too

I have no idea how to test that. Can you help ?

Can help when I find some time.

Sorry for holding it off for so long.
I haven't really find a good way to test it (to assert that locale from store is used on the client), but since tests run with syncLocale enabled, it should be fine already. I'll only add some tests with vuex disabled to make sure that that is tested.


Improve Windows Support

Overview
Many of the make targets leverage some handy shell techniques that only work on UNIX systems, but I'd like to get this demo project working smoothly on Windows.
Checklist

[X]  Remove pg_config dependency by using docker compose healthchecks
[X] Remove use of sleep by using docker compose healthchecks
[X] Require a more recent docker version to rely on Docker Compose v2 features
[ ] Find an alternative to open to launch the demo site?
[ ] Test on Windows

Closes #18

@ThomasLaPiana can you try this branch now? I'm hoping the only blocker is open but I have a feeling there are others and I don't have a good way to test on Windows right now


Make MudDataGrid column ordering after drag/drop able to save/reapply

Feature request type
Enhance component
Component name
MudDataGrid
Is your feature request related to a problem?
We have the ability to let users reorder the columns in the datagrid with the new DragDropColumnReordering parameter. However, there is currently no way to save that new ordering and reapply it when the page is opened again. This means our users have to redo the column reordering process every time they load the page that contains the datagrid. We hope to save our users time with this feature
Describe the solution you'd like
We'd like two new methods in the MudDataGrid component. One to return the order of the rendered columns so we can save the order. And another to pass in the order the user saved in a previous session to be able to reapply that order.
Have you seen this feature anywhere else?
I haven't seen it elsewhere but I worked on implementing this with a class that inherits MudDataGrid. Here is a screenshot of what I have that works. I have a button on the page to save the ordering to local storage, and in OnInitializedAsync for the page I pull the dictionary back from local storage and call the ApplyColumnOrder method to be able to reload columns to the order I'd saved.

Describe alternatives you've considered
Our alternative is moving ahead with the component I created that inherits the datagrid but we want to avoid having two versions of the datagrid across our applications if possible, so we'd really like to see this as a feature in the datagrid component.
Pull Request

[X] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I am currently looking for something like this and trying to implement my own method but this exactly what Im looking form.
How would I go about get something like this to work in my solution? How do I hook the MudDataGrid up to those 2 methods? I cannot figure which events to use.

I am currently looking for something like this and trying to implement my own method but this exactly what Im looking for.
How would I go about get something like this to work in my solution? How do I hook the MudDataGrid up to those 2 methods? I cannot figure which events to use.

So the way I used this was in OnInitialized for the page that contained the OrderableDataGrid component, I was pulling the dictionary from local storage and then calling the ApplyColumnOrder method by passing in the dictionary.
I was saving the method to local storage just in the onclick for a "Save Layout" button on the page.
Hope that helps and that we get an official implementation of something like this worked into Mudblazor soon

Oh so no automatic saving? User has to click button?
Does reordering columns actually not rise an event of some sort?
Would saving the column layout on any click be too much you think? I'd really want it to be able to save any customization without the user having to click a save layout button.
But thanks. I'll see what I can come up with. If I figure out something cool Ill let you know.

This kind of functionality is needed. I think it needs more consideration around what state may want to be saved/loaded as ColumnState is just one part of it.
There are also filter definitions and sort order for the grid along with if a column is hidden, grouped and many other potential properties that could be considered part of the state.
I think the above code would also create potential issues when the saved columns no longer match the default grid. e.g. You have a grid with Name, Age columns and save the column order to database. The user returns when the default grid has now been updated with an extra column Address. ApplyColumnOrder passing Name and Age columns would then remove the Address column. Having used commercial grids before there is usually an option to either version the state so an old one won't load or control what happens to extra columns such as to show them by default.

Have been looking at implementing so the columns that a user hides or re-orders get saved and this was great inspiration. Thank you. The hiding of the columns works great since we have the HiddenChanged event on the column. This works both through the dot menu and the columns panel. It also works great on load through await column.HideAsync() method on init.
Would love something similar or a workaround for when the column order is changed. Have looked around a little bit and can't find any workarounds for this. All I have for now is a button you have to click manually which looks through RenderedColumns and saves that.

When using the solution as provided by @badcock22  you could add IDisposable to the datagrid. When leaving the page, Dispose will be called and you could save the order to the local storage. Not perfect but enought for my usecase.
I struggle with loading the column order wihtout the users attention. As you can only apply thr correct order and visibility after the columns have been rendered, but than the changes are visible to the user.

@GrooveXT
Using IDisposable works pretty well.
The way i load the user settings on load is that I have extended the MudDataGrid with a custom data grid class
[CascadingTypeParameter(nameof(T))]
public class CustomDataGrid<T> : MudDataGrid<T>

protected override async Task OnAfterRenderAsync(bool firstRender)
{
    if (firstRender && _dataGrid != null)
    {
        await _dataGridService.Init(ApplicationState, _dataGrid);
    }
}

And then in init you can apply the customization on the datagrid.
Here you can also call await SetRowsPerPageAsync(x) to set the saved pageSize.
Hide the columns
foreach (var column in RenderedColumns)
{
    // if column should be hidden
    {
        await column.HideAsync();
    }
}

var newOrder = tableSetting.ColumnSettings.Where(x => x.Order.HasValue).ToDictionary(x => x.FieldName, x => x.Order);
var columnsOrdered = (from sourceColumn in RenderedColumns
                      join column in newOrder on sourceColumn.PropertyName equals column.Key into grp
                      from order in grp.DefaultIfEmpty()
                      orderby order.Value.HasValue descending, order.Value
                      select sourceColumn).ToList();

RenderedColumns.Clear();
RenderedColumns.AddRange(columnsOrdered);

@badcock22  let me know sample code for this? or snippet?

Does the core devs have any input on this? Like @henon
The original poster says to be willing to do a PR to fix this, but that was over a year ago, I don't know if that is still true. Would that be ok?
Do you have any advice on how to accomplish this? Or at least where to start looking.

@DonKarlssonSan you are very welcome to do it. I am not at all experienced with the MudDataGrid source code and how it works. That would be @tjscience. But if we do this I guess it would be best to not only allow getting and setting column indices but other settings the user can change as well, right? Though in the first step this could have only the column index and other things could be added later.
So maybe a public API function to get the column settings and one to set it such as ColumnSettings[] GetColumnSettings() and SetColumnSettings(ColumnSettings[])? (I have no idea how the settings would be identified with the individual columns). Definitely would be good to have @tjscience 's advice here too!


⚠ Jenkins Plugins Artifactory has degraded performance

In dbde643, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1034 ms

Resolved: Jenkins Plugins Artifactory performance has improved in d4d7d5f after 1 hour, 4 minutes.


feat(gitoid): Add BoringSSL backend support for SHA-1 and SHA-256 in gitoid

This commit introduces support for the BoringSSL backend for SHA-1 and
SHA-256 in the gitoid Rust package. The SHA-1CD algorithm is not
supported with this backend. To enable BoringSSL, use the "boring"
feature in Cargo.
Additionally, benchmarks have been added to measure the performance
of the implemented cryptographic algorithms.
Signed-off-by: Frederick F. Kautz IV<EMAIL_ADDRESS>

@alilleybrinker i hope i implemented your recommendations faithfully. let me know if there are any other issues.


Company information doesn't show up

Thank you

Fixed with version 3.2.7, please update.

Really appreciate the quick fix. Thank you


Mistake in website

📚 Documentation

I believe the mistake is obvious in photo.
traget = traget =....
Best regards

Fixed by #1287 . Closing issue.


Modified ThreadPools to conditionally register metrics

When ThreadPools calls ExecutorServiceMetrics, it creates Meters
that are registered with the MeterRegistry. However, there is no
easy way to remove the Meters from the MeterRegistry when the
ThreadPool is shut down. Modified the ThreadPools methods to accept
a boolean value for registering metrics for the newly created
ThreadPool. Modified classes that use ThreadPools class to only
pass true for this boolean value when the ThreadPool is long lived.
Closes #2423

Boolean parameters can make code harder to read. Instead of boolean parameters, you could have a separate method name, like .action() and .actionWithMetrics(), or you could use a builder, like builder.withMetrics().build(), or you could have enums for flags, like .action(EnumSet.of(WITH_METRICS, OTHER_FLAG))

Another option would be to replace the last boolean argument in the method with a new enum type.  The single boolean here is not too bad, an enum would be more readable.  We have had methods in the past w/ multiple boolean arguments and that was awful to read.

Boolean parameters can make code harder to read. Instead of boolean parameters, you could have a separate method name, like .action() and .actionWithMetrics(), or you could use a builder, like builder.withMetrics().build(), or you could have enums for flags, like .action(EnumSet.of(WITH_METRICS, OTHER_FLAG))

I have no issue with modifying ThreadPools to use a builder pattern, but I think that should be done in a different issue. IDEs make it pretty easy to see the formal parameter name for the method and the formal parameter name is descriptive in this case.

Another option would be to replace the last boolean argument in the method with a new enum type. The single boolean here is not too bad, an enum would be more readable. We have had methods in the past w/ multiple boolean arguments and that was awful to read.

I have no issue with modifying this PR to use an enum for the boolean parameter, but I'm not sure that it's necessary if there is going to be a follow-on issue created to modify the class to use a builder pattern.

IDEs make it pretty easy to see the formal parameter name for the method and the formal parameter name is descriptive in this case.

That is a good point.  That does dramatically increase readability. However when reviewing a PR on GH, you dont have that nice feature.  But thinking back to my review that was not a problem at all. The review was very easy for me to review because I knew what the single boolean did.  The more difficult part of the review was that I had to look at code outside the PR sometimes to see how code was called externally, which had nothing to do with the boolean.  More than one boolean would certainly have given me a headache during review though.

I'm not sure that it's necessary if there is going to be a follow-on issue created to modify the class to use a builder pattern.

That makes sense to me.


fix: enable werror for dao-api.

#29
Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[x] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

ping

Also, since this is a breaking change, and the others will be too, how do we feel about adding them to a separate branch, and then once they're all in merging to master without review? i.e. review small PRs to the other branch, then we can have one big breaking change all at once that was "already reviewed" in chunks?


Offline version (PWA)

Is this a bug report?
No, a feature request
Have you read the [Contributing Guidelines]
Yes
Environment
Web browser
Steps to Reproduce
As a developer
In order to work on the documented project while offline
I would like to « download it » in my browser
Is it something you’d like to support at some point?
Any ideas of features that you’d like in priority? For instance search could be disabled when offline, should the documentation be downloaded entirely offline upon a visit or should it be an action button for visitors…
I’d love to work on it since we are considering using Docusaurus for a project documentation and offline access is one of our criteria, however I’d need guidance and help.

Hi @real34 -- Just wanted to clarify when you say "offline" is that you want the website available when you do not have internet access? Or you want to work on the documentation itself when offline. For the latter, you can use the local web server to do your testing.

It is for being able to read the docs (maybe the website is not necessary) while not having internet access.
Of course a PWA would help, but there may also be other alternative (maybe easier and more in the SSG spirit) like generating alternative outputs compatible with existing tools such as Dash / Zeal or http://devdocs.io/

If you need guidance/assistance, I'd love to help out!

@Happy-Ferret Hi. You have some ideas around this? What type of help do you have in mind?

@JoelMarcey
I've got some experience producing PWA's (albeit of a simpler nature) and wouldn't mind working on a simple PoC here, once I can make some time.

@Happy-Ferret I will say that you claimed this issue for now. Feel free to let me know if you will not have time. Thanks!

@JoelMarcey
Thanks!
Unrelated, but could you have a look at #468?
That one is rather bothersome. Unfortunately, it's over my head what exactly might be the issue there.

@Happy-Ferret I will take a look at that issue tomorrow PST.
Sent with GitHawk

@Happy-Ferret I commented on #468 and submitted a PR that I would love for you to test #490

Thanks for your positive feedbacks. Let’s start working on this as soon as someone finds time. I will very likely only have time for it in 1-2 weeks.

I think one of the prerequisites for achieving offline/PWA would be to use an offline search. Please consider adding lunarjs option for offline search.

@Happy-Ferret are you still working on this ?

@Happy-Ferret Due to inactivity, I'll be removing the "issue: claimed" label and making this issue up for grabs.

cc: @jordwalke

@JoelMarcey Has there been any progress on this issue? I'd love to work on it, but I probably couldn't start working until the beginning of April.

Hi @nebrelbug -- not much. We would love your help. Thanks!

It looks like there hasn't been any progress on this issue. I'll spend some time this weekend and see if I can get a POC working 😃

Alright, I made some decent progress. I'm currently experimenting with using the Webpackoffline-plugin. I was able to get both the server and client Webpack configs to compile, but there's an issue with the generated service worker.
I just got back from vacation so I should have more time to look into it this week. I'll update if I encounter any blockers or if I make significant progress 😄

@codemonkey800 Thank you so much for taking the lead on this.

Hey all,  this is feature is now released!
If you like it, don't forget to retweet 😄
https://twitter.com/docusaurus/status/1286715187983048704

Thanks for this work! Great job everyone. :clap:


[feat] SegmentAttributes

Related to #999
This PR is a PoC. I've implemented following approach:

SegmentAttribute enum, different options represent different types + different strategies of merging while merging segments
Every segment has HashMap<String, SegmentAttribute> aka SegmentAttributes in its metadata
IndexSettings has SegmentAttributesConfig that is used to create SegmentAttributes for inserting into every segment on segment creation.
While merging we additionally merge all SegmentAttributes and set them to a new segment.

@PSeitz @fulmicoton Could you review? I haven't implemented tests or helper functions because not sure if Tantivy still needs this feature at all.

Codecov Report

Merging #1512 (0585522) into main (4d634d6) will decrease coverage by 0.00%.
The diff coverage is 93.40%.

@@            Coverage Diff             @@
##             main    #1512      +/-   ##
==========================================
- Coverage   93.96%   93.96%   -0.01%
==========================================
  Files         242      243       +1
  Lines       44936    45119     +183
==========================================
+ Hits        42226    42397     +171
- Misses       2710     2722      +12

Impacted Files
Coverage Δ

src/core/mod.rs
100.00% <ø> (ø)

src/lib.rs
96.48% <ø> (ø)

src/core/segment_attributes.rs
90.64% <90.64%> (ø)

src/core/index.rs
93.25% <100.00%> (+0.09%)
:arrow_up:

src/core/index_meta.rs
94.62% <100.00%> (+0.26%)
:arrow_up:

src/indexer/log_merge_policy.rs
98.15% <100.00%> (+0.02%)
:arrow_up:

src/indexer/segment_register.rs
85.29% <100.00%> (+0.44%)
:arrow_up:

src/indexer/segment_updater.rs
95.54% <100.00%> (+0.09%)
:arrow_up:

src/postings/stacker/expull.rs
99.05% <0.00%> (+0.47%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Thank you @ppodolsky for this PR! We were a bit overwhelmed these days :)
I don't have enough knowledge to say if such a feature can be added so I let @fulmicoton and @PSeitz answer on this.
But when looking a the code, I was not very fond of the enum, why not using a Trait for segment attributes?

Hi @fmassot ! Thank you for reply!
I can rewrite it to traits but I'd prefer to stabilize the approach verbally at first if the feature is still needed.
Further I'd like to confirm that putting segment attributes config in IndexMeta and segment attributes in meta.json (not in separate file) is OK.

@fmassot
I have tried to implement it via traits and didn't like the way it looks. The main issue is that we need to store type. Enums are well suited for this purpose because they are serializable and naturally aligned with serialization format like
"<type_name>": .
Traits should be serialized in non-trivial way and we have to map trait and its serializable name for deserialization.

@ppodolsky I read again your PR and yes enum is fine per attribute... My thought about trait was on a higher level, I mean on the SegmentAttributes level. I don't have a genuine opinion on how to implement correctly this feature, and I did not want to add some noise here, sorry.
Concerning serialization/deserialization of traits, this can done with https://github.com/dtolnay/typetag, I believe it is just using an enum behind the scene.

Currently the behaviors are provided by tantivy. As an alternative, we could have a registry.
    fn register_attribute(name, &str, attribute: Attribute); // name has to be unique

trait Attribute{
    fn merge(attrs: Vec<serde_json::Value>) -> serde_json::Value;
}

is_frozen attribute, ConjunctiveBool could be provided by tantivy.
{
     "is_frozen": true
}

register_attribute("is_frozen", ConjunctiveBool)

Not sure if this too unwieldy.

@PSeitz Yes, I came to this design while trying to reimplement it with traits. I was slightly confused by using serde_json::Value as value for segment attribute, not sure if tying to specific serialization format is worth to do. And without serde_json::Value there will be a need to create a Value representation which would be enum again.
What do you think?

@PSeitz Yes, I came to this design while trying to reimplement it with traits. I was slightly confused by using serde_json::Value as value for segment attribute, not sure if tying to specific serialization format is worth to do. And without serde_json::Value there will be a need to create a Value representation which would be enum again.
What do you think?

The enum would look like serde_json::Value, so we can just use that. serde_json::Value is not tied to json de/serialization, it's implementing the De/Serialization traits.

Ok but still have questions. Is global registry ok? It will bind a set of available attributes to the compiled version of application. In the approach implemented here indices can manage a set of attributes by their own.

Also, trait objects are not very friendly with OnceCell or whatever would be used for the global registry

Finally, safe trait objects won't be able to incapsulate default values for attributes. Putting Value inside trait object will make trait non-safe, it would require manual implemenation of Serialize/Deserialize traits and so on. I tried and might miss something but implementation looks rather messy

Ok but still have questions. Is global registry ok? It will bind a set of available attributes to the compiled version of application. In the approach implemented here indices can manage a set of attributes by their own.

True, the registry should probably have some attribute_name attribute association. The predefined attribute names would be reserved. So the current json format could stay the same, but conjunctive_bool would be an attribute_name.
{"is_frozen:{conjunctive_bool:false}}

Finally, safe trait objects won't be able to incapsulate default values for attributes. Putting Value inside trait object will make trait non-safe, it would require manual implemenation of Serialize/Deserialize traits and so on. I honestly tried to implement it and might miss something but implementation looks rather messy

For de/serialization, you can just use the serde_json::Value.

Putting Value inside trait object will make trait non-safe

Why put Value inside the trait object, it's just merge behavior.
trait Attribute{
    fn merge(attrs: Vec<serde_json::Value>) -> serde_json::Value; // There's no self
}

Finally, safe trait objects won't be able to incapsulate default values for attributes.

Why do you need default, only for merge right?
trait Attribute{
    // handle default internally
    fn merge(attrs: Vec<Option<serde_json::Value>>) -> serde_json::Value;
}

No global registry please.

Why do you need default, only for merge right?

Default is needed for any newly created segment, not just merge.
For example, this is_frozen attribute should be set to false for new segments, manually turned to true during specific event (in my case it is index publication that freezes segments and should prevent them from further merging) and again, set to false after any merge (can still happen if run it manually). Here the default is false.

@ppodolsky The idea to have the serialized object embed the logic of how things should be merged is not interesting, but I don't think we want that here.
Here is a counter proposition...
What about you have a public trait.
pub trait SegmentAttribute: Default + Serializer + Deserializer {
     fn merge(segment_attributes: &Self);
}

Internally to tantivy, you could then have a SegmentAttributeMergerImpl.
struct SegmentAttributeMergerImpl<S: SegmentAttribute>;

And a boxable trait (also private to tantivy)
trait SegmentAttributeMerger {
    fn merge_json(&self, segment_attributes_json: &[serde_json::Value]) -> serde_json::Value;
}

The index then would have public method
fn set_segment_attr::<S: SegmentAttribute>() {
    let typed_segment_attr_merger: SegmentAttributeMergerImpl<S> = SegmentAttributeMergerImpl;
    self.segment_attribute_merger = Some(Box::new(typed_segment_attr_merger));
}

Note that we are not making Index a generic here.

@fulmicoton Done :)

Friendly bump ⬆
@fulmicoton

Bump:)

Regular bump @PSeitz @fulmicoton

@fulmicoton Done, sorry for being late.
Also, had to turn Box into Arc because you suggested to remove impl Clone for Box<...> etc.


Provide some overview and introductory documentation to OpenSSL and the libraries

We incorporate and expand on some of the existing crypto.pod and ssl.pod text

The CI failure seems spurious. I see the same error that @hlandau also reported recently:
Warning: source code did not work: Error: spawnSync C:\Users\runneradmin\nasm\nasm-2.15.05\configure ENOENT
Error: could not install NASM: Error: I'm sorry, Dave. I'm afraid I can't do that.

Would it be better to leave crypto.pod as just containing links to the new documentation?

Would it be better to leave crypto.pod as just containing links to the new documentation?

The ossl-guide-libcrypto-introduction page has "crypto" as an alias in the "NAME" section, so doing "man crypto" should take you to the right page. Similarly with the "ssl" page.

All comments addressed or responded to above. Fixups pushed. Please take another look.

Looks good.

Would it be better to leave crypto.pod as just containing links to the new documentation?

Yeah, that would be definitely better. Keep the ssl and crypto manpages as links at least. People can be used to look at them.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

New fixups as per the latest feedback.
Please reconfirm your approvals: @hlandau, @t-j-h, @mspncp

Reconfirmed - still approved.

I don't see any fixups from two hours ago (using the mobile app)?

Now pushed for real!

I assume this can be closed now.

Well, there is still the grace period, which is reset by pushing fixup commits.

Still approved - as I simply re-read the whole context (so hadn't noticed the non-push).

Merged to master branch. Excellent work!


APISnoop does not appear to detect the ServiceInternalTrafficPolicyendpoints

ServiceInternalTrafficPolicy
https://github.com/kubernetes/kubernetes/pull/113496

promoted a new field to GA inside of services not an any endpoints.


Allow exporting and importing of configuration (especially sharing configuration)

I spent a week slowing connecting to all my friends in different countries, waiting for us to both be online. I accidentally remove the app, and then lost all my settings, now I have to go back and it will take a long time for me to be able to share access with everyone again. I wish I could have exported my settings and then imported them. I also want that so that I can more quickly configure a new amazon instance, or a new laptop. I think this will be helpful/needed for cloud also. We probably need some UX for this, but to start with I could imagine it in advanced settings, or maybe we need to have a separate settings page (linked to from hamburger menu) as we're getting more things we want there?

Related to this I've thought our code would be much easier maintained if
rather than saving and loading multiple objects to storage (e.g. one object
per contact, another object per instance, etc), we just stored one giant
object (or maybe at least one giant object per login).  This would then be
much easier to export from storage and import to another uProxy
installation.  The downside is that loading and saving might take a little
longer (every time you need to save any change, you ended up saving the
whole giant object) - but we could experiment with browser storage APIs and
see how bad this is likely to be.
On Thu, May 14, 2015 at 11:14 AM, iislucas<EMAIL_ADDRESS>wrote:

I spent a week slowing connecting to all my friends in different
countries, waiting for us to both be online. I accidentally remove the app,
and then lost all my settings, now I have to go back and it will take a
long time for me to be able to share access with everyone again. I wish I
could have exported my settings and then imported them. I also want that so
that I can more quickly configure a new amazon instance, or a new laptop. I
think this will be helpful/needed for cloud also. We probably need some UX
for this, but to start with I could imagine it in advanced settings, or
maybe we need to have a separate settings page (linked to from hamburger
menu) as we're getting more things we want there?
—
Reply to this email directly or view it on GitHub
https://github.com/uProxy/uproxy/issues/1536.

Lucas, where would u export it to? Without automatic export i dont see this
being useful. U never know when u might accidentally delete the app. We've
talked about permission syncing and i like that solution more.
We store instanceids to storage and use them as keys too, so this would
also require changing how we organize storage.
Daniel, we discussed having one big entry vs multiple small entries when we
were designing storage. I believe that was the argument against one big
blob, I'm not super against this change, because we don't know for sure it
will affect the performance, but also this is not really necessary to
support this export/import feature.
On May 14, 2015 11:21 AM, "dborkan"<EMAIL_ADDRESS>wrote:

Related to this I've thought our code would be much easier maintained if
rather than saving and loading multiple objects to storage (e.g. one object
per contact, another object per instance, etc), we just stored one giant
object (or maybe at least one giant object per login). This would then be
much easier to export from storage and import to another uProxy
installation. The downside is that loading and saving might take a little
longer (every time you need to save any change, you ended up saving the
whole giant object) - but we could experiment with browser storage APIs and
see how bad this is likely to be.
On Thu, May 14, 2015 at 11:14 AM, iislucas<EMAIL_ADDRESS>wrote:

I spent a week slowing connecting to all my friends in different
countries, waiting for us to both be online. I accidentally remove the
app,
and then lost all my settings, now I have to go back and it will take a
long time for me to be able to share access with everyone again. I wish I
could have exported my settings and then imported them. I also want that
so
that I can more quickly configure a new amazon instance, or a new
laptop. I
think this will be helpful/needed for cloud also. We probably need some
UX
for this, but to start with I could imagine it in advanced settings, or
maybe we need to have a separate settings page (linked to from hamburger
menu) as we're getting more things we want there?
—
Reply to this email directly or view it on GitHub
https://github.com/uProxy/uproxy/issues/1536.

—
Reply to this email directly or view it on GitHub
https://github.com/uProxy/uproxy/issues/1536#issuecomment-102069856.

Closing as this is not a priority right now


Adding Garrison tip to Enemy Intelligence

Adds a popup tip, intended to perform two functions:

Inform new AP players that the mechanic has been changed from base NCO
Give players a way to check which units can be garrisoned without needing to build a copy of everything

Cherry-picking commit so it can go onto master


HDFS-15650. Make the socket timeout for computing checksum of striped…

… blocks configurable
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
36m 13s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m  7s

trunk passed

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
1m 11s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 47s

trunk passed

+1 :green_heart:
mvnsite
1m 21s

trunk passed

+1 :green_heart:
shadedclient
18m 32s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 52s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 20s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
3m 15s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 13s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
compile
1m  6s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
1m  6s

the patch passed

+1 :green_heart:
checkstyle
0m 41s

the patch passed

+1 :green_heart:
mvnsite
1m 13s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
16m 38s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 22s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
3m 15s

the patch passed

_ Other Tests _

-1 :x:
unit
114m 21s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+0 :ok:
asflicense
0m 34s

ASF License check generated no output?

243m 11s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestFSInputChecker

hadoop.hdfs.TestFileCreationClient

hadoop.hdfs.TestBalancerBandwidth

hadoop.hdfs.TestAclsEndToEnd

hadoop.hdfs.TestErasureCodingPoliciesWithRandomECPolicy

hadoop.hdfs.tools.TestStoragePolicySatisfyAdminCommands

hadoop.hdfs.TestFileConcurrentReader

hadoop.hdfs.tools.TestDebugAdmin

hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

hadoop.hdfs.server.balancer.TestBalancer

hadoop.hdfs.server.mover.TestMover

hadoop.hdfs.TestCrcCorruption

hadoop.hdfs.server.balancer.TestBalancerRPCDelay

hadoop.hdfs.TestUnsetAndChangeDirectoryEcPolicy

hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy

hadoop.hdfs.TestDFSInputStreamBlockLocations

hadoop.hdfs.TestHDFSFileSystemContract

hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer

hadoop.hdfs.tools.TestGetConf

hadoop.hdfs.TestBlockTokenWrappingQOP

hadoop.hdfs.server.namenode.TestDeleteRace

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2414/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2414

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux ea3f89c87426 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 74634eb0027

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2414/1/testReport/

Max. process+thread count
2147 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2414/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.1.3

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m 38s

trunk passed

+1 :green_heart:
compile
1m 57s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 58s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 40s

trunk passed

+1 :green_heart:
mvnsite
2m 10s

trunk passed

+1 :green_heart:
javadoc
1m 26s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m  5s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
4m 34s

trunk passed

-1 :x:
shadedclient
23m  1s

branch has errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 21s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
compile
0m 23s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.

-1 :x:
javac
0m 23s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.

-1 :x:
compile
0m 23s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.

-1 :x:
javac
0m 23s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 21s
/buildtool-patch-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
The patch fails to run checkstyle in hadoop-hdfs

-1 :x:
mvnsite
0m 23s
/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
javadoc
0m 23s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.

-1 :x:
javadoc
0m 23s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.

-1 :x:
spotbugs
0m 24s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

+1 :green_heart:
shadedclient
5m 23s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
1m  8s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

+0 :ok:
asflicense
0m 23s

ASF License check generated no output?

91m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2414/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2414

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux b5b73b1c0ab6 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ad4acf3bda14ece7b4245d420772c0e414e881e9

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2414/1/testReport/

Max. process+thread count
89 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2414/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
14m  3s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 41s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 58s

trunk passed

+1 :green_heart:
compile
5m 18s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
4m 34s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 15s

trunk passed

+1 :green_heart:
mvnsite
2m 17s

trunk passed

+1 :green_heart:
javadoc
1m 38s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m  7s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
6m  3s

trunk passed

+1 :green_heart:
shadedclient
17m  8s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 12s

the patch passed

+1 :green_heart:
compile
5m 26s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
5m 26s

the patch passed

+1 :green_heart:
compile
4m 45s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
4m 45s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  7s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 2 new + 65 unchanged - 0 fixed = 67 total (was 65)

+1 :green_heart:
mvnsite
2m 16s

the patch passed

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 26s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 54s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
6m  6s

the patch passed

+1 :green_heart:
shadedclient
17m 32s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 20s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
240m 17s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

372m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2414/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2414

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml

uname
Linux 1a4975f32f64 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fb6b4d96391c7f8a991715118249daef06c8858f

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2414/4/testReport/

Max. process+thread count
3329 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2414/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


Cleanup/filter_params

As spotted by Julia, we were not using binding parameters in our filtering code. This was bad. Now we do!
Should have no impact in functionality. I tested the UX and the test cases are passing.

Looks to be working as expected @julesyan - thank you!