Persisting tweaks

We've just integrated our first a/b tests and we noticed the values of the tweaks are not persisted. So if the user is in cohort B and then kill/restart the app, the value of the tweak will be re-fetched.

Is that on purpose?
If it is, is there any plan to add persistency?
Is there any harm if we persist it ourselves?

Hi @RomainPiel! I can definitely see the benefit of persisting tweaks. My concern is that you may load tweaks locally that were already removed remotely. That means that after a request, those tweaks will be removed and that could be a very odd user experience.
What is your user case and why do you need to persist them? I want to understand what you are going through :)

Ah right, I see how it could be problematic if the tweak is removed remotely. I guess instead of removing it we could return the initial default value from the server.
So my use case is that I have a A/B test on my very first screen. So it can happen and it happens quite frequently that the tweak value is initialised with some delay after the view is rendered. I don't really want to wait for it to come back so the UX is a bit odd.
Caching it fixes it for the subsequent launches (not really for the first one but that's acceptable).
Thanks for your help!

Setting the initial value would be an equivalent of removing/updating a tweak after another one is loaded.
For your use case, I think it'd be an improvement if we persist the tweaks. However, you'd face the same situation as soon as you remove them remotely. If that's something that does not concern you, I'd like to implement this on the SDK in such a way that loading persisted tweaks does not happen by default unless you specify so in an Activity or in the app.
Alternatively, on our latest SDK release we provide callbacks when tweaks are updated (see changelog and how to set it up https://github.com/mixpanel/mixpanel-android/releases/tag/v4.9.2). In your app, would that be a solution? I.e. render the UI after tweaks are updated from the server.

I agree, the best solution would be to handle it in the SDK because it has full context on wether the tweak still exists or not.
We have considered using addOnMixpanelTweaksUpdatedListener() but it wouldn't work for us, we don't want to block the UI until we get the experiments and we don't want to alter the UI after it has been rendered.
In any case, the problem of the tweak being removed on the server side is not a massive issue.
Assuming that version 1 has a 50/50 A/B test. Then eventually maybe B wins. We can set it to 100% B for a while. Then we roll out version 2 that only has feature B with no tweak check. After some time version 1 is not much used, we can drop the tweak remotely.
Obviously it would be awesome if the SDK was handling it, it would mean less code on our end and a cleaner implementation. But the remote deletion is not a biggie.

Something that I could do (and that the SDK could do) is to set an expiration date on that cached value. That's what Google is doing with firebase remote controls: https://firebase.google.com/docs/remote-config/android#caching

@RomainPiel Thanks for the link! I see a lot of benefits persisting the tweaks moving forward. I will keep this in my radar but i can't give you an ETA at this moment. In the mean time, feel free to implement it on your side and open a PR. I'll be happy to review it.
Thanks!

Cool, I'd be happy to help but I'm not very familiar with the code. So any quick walkthrough the potential changes would be greatly appreciated.
I've had a quick look at the code and it seems that there is some persistency happening during initialization in ViewCrawler. These mPersistentTweaks are applied to the shared tweaks. I'm wondering why these values are not reused after a re-launch.

Does mixpanel iOS sdk persists toggles? -- because I guess it does. if yes can we check how they its implemented in iOS and can get better insights?cc @asifmujteba

Any updates on this?

Starting on the next version (5.2.0) we will start persisting tweaks https://github.com/mixpanel/mixpanel-android/pull/492
Thanks for your feedback guys!


v1_1 Directions Corn Syrup Confusion

In the v1_1 Directions
Step 2 states

Combine water, glycerin and corn syrup in a mixing bowl.

Step 4 states:

Combine corn syrup, sugar, salt and sucralose.

Should both steps include corn syrup? If so how much of the 6.5 tbsp for each one?
Referencing the v1_0 Directions, I suspect the Step 2 shouldn't mention corn syrup.

Hey bud, did you find a good mix or is the recipe good?

If you checkout the latest versions contributed by another bait maker, I
haven't tried it myself but he said there is promise there.
+1<PHONE_NUMBER>
Adam Merrifield
On Mon, Dec 30, 2024, 18:02 SNS Fishing PNW @.***>
wrote:

Hey bud, did you find a good mix or is the recipe good?
—
Reply to this email directly, view it on GitHub
https://github.com/seyDoggy/biopolymer-recipe/issues/4#issuecomment-2565992664,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACM3K7DKQX3YTZANDOKXI32IHGIRAVCNFSM6AAAAABMDOZAG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRVHE4TENRWGQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Delete car

Description
Add functions to delete a car
General requirements

[x] There are no linter errors.
[x] Followed the Github flow.
[x] The documentation is professional.

JavaScript requirements

[x] Follow our list of best practices for JavaScript.

Built With
React
JavaScript
Webpack
Project requirements

[x] When the user clicks the "Delete item" link in the navigation panel they can see a list of all items with a title and a "Delete" button.
[x] When the user clicks the "Delete" button, the selected item is marked as removed and does not show on the main list anymore.

closes #5
Thank you for taking the time to review this pull request.
Hope you enjoy yourself whiles reviewing :grinning:

Thank you @Tobinchilongo


Relocate File and HttpClient to their respective modules

This PR relocates the code for File and HttpClient to their respective modules as suggested in #521.
Please review the same.
Summary by Sourcery
Chores:

Relocate code for better organization.

There's a couple of other places we will have to reference these files, install.sh, maybe others, a grep should find them.


Select2 4.0 - decorator doesn't apply while using custom dataAdater

When I define custom dataAdapter and minimumInputLength option (for example), decorator doesn't call.

To prevent double-decorating adapters, Select2 will not automatically apply decorators when a custom adapter is used. On the options page, we include all of the decorators for the documented functions, labelled "Decorator" with the matching "Adapter" as well, so you can know what decorators to use in order to get the option working.
The minimumInputLength option is not yet documented, but it wraps the DataAdapter using the MinimumInputLength decorator, available at select2/data/minimumInputLength.

Based on your answer above @kevin-brown, if we want to globally use a custom adapter, e.g., extend ResultsList to show a checkbox per #411, we'd have to manually come up with some system to manage all those decorator permutations, similar to how defaults.js does it with all the if statements based on options?


Charset determination from messages

Due to compatibility issues, message encoding determination has been turned off and messages are assumed to be encoded in UTF-8.

PR#90 introduces a Configuration Option for ths purpose. It also re-enables using the charset specified in the message to decode it.
When the PR is merged, this issue is hence resolved.

PR #90 is merged, thus closing this issue.


🐛 Bug Report: No Logo

👟 Reproduction steps
I installed Pingvin Share using the docker compose provided.
I'm delighted. Everything works great.
But I have one problem. The logo at the top left is not displayed. Neither after a fresh installation nor when uploading it myself. Both when accessing via the direct IP:Port and the reverse proxy.
👍 Expected behavior
See the logo
👎 Actual Behavior
No Logo
🌐 Browser
Chrome, Firefox, Samsung Internet (all mobile)

Can you share the docker compose that you are using and the logs of the container? You can get the logs with docker compose logs.

My docker compose
services:
  pingvin-share:
    image: stonith404/pingvin-share
    restart: unless-stopped
    ports:
      - 3003:3000
    volumes:
      - "./data:/opt/app/backend/data"
      - "./data/images:/opt/app/frontend/public/img"

In data images I also see the uploaded logo in 2 resolutions.
My log when starting (copied from portainer):
I just saw "no such file or directory" in the log. But it disappeared after I restarted the container and I can't see it anymore. However, the logo appeared after the restart. Very interesting.


feat(MatFormField): Add new css class when field has been touched

Feature Description
I would like to have a css class on the mat-form-field component (e.g. mat-form-field-touched) when the inner ng-control was touched. Adding it as a conditional class in the host section of the MatFormField might do the trick:
@Component({
...

   host: {
      '[class.mat-form-field-touched]': '_control.ngControl.touched',
   }
...
})

Use Case
My designer wants to give a form field a different background color, whenever the user has touched it.

Isn't that currently possible? ng-touched applies to  component as soon as control is touched.

Yes that works. Just forgot to bind a form controll to the select input...


Convert position from MIS to NRML.

HI There, how can I convert my position from Intraday to Delivery? Is there any method available to convert mis to nrml and vice-versa. If not, could you please add this feature?

I checked there is method for modify order but I can't figure out how should I get Order ID of my open positions. In "get_netwise_positions" Order ID (oms_order_id) is coming as blank values.

Not able to find anything. Could you please check if we can get order ID field in "get_netwise_positions" method? If we get order id then we can try modify order method.

@ravi14390 yes will try but as of now have not updated this library much.


AWS Lambda SDK: Send payloads from internal to external extension in dev mode

@medikoo Just to make sure I am following here, this PR just setting up forwarding payloads to the external extension without including the req/res payload for instrumented libraries correct?
As you mentioned in this PR the work to include the req/res payloads in instrumented libraries will happen in a follow up PR correct?


Build(deps-dev): Bump html-webpack-plugin from 5.5.1 to 5.5.3 (#4942)

Pull request opened by the merge tool on behalf of #4942

Merged in f2a11ca092ad7e4589cbd52e78c6bb1abcb183b8


Added CMake command to dev docs for linking against librocksdb

In the current docs for linking against libsrockdb, building libsnappy.a will fail because of an error thrown while building its third party benchmarks which are enabled by default.
Describe your changes
This PR adds the CMake CLI option to the docs so that snappy's optional benchmarks are disabled by default.
Issue ticket number and link
NA
Checklist before requesting a review

[x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

This is a one line change to developer docs for linking against a crate dependency.

Thanks for taking the time, @ejmg! Just-merged is a more comprehensive dev env in #4726, which should do the needful on setting up local tooling, regardless of your workstation platform.


raw browser size gets mess up and becomes too small for working

Describe the bug
While trying to look into issue #9616, I ran into a problem with the sample dataset which could not be plotted using raw.plot().
This problem occurs on both the version 0.23 and on the latest commit version using the develop mode.
Steps to reproduce
import mne
from pathlib import Path

data_folder = Path(mne.datasets.sample.data_path())
raw_file = data_folder / 'MEG' / 'sample' / 'sample_audvis_filt-0-40_raw.fif'
raw = mne.io.read_raw_fif(raw_file)
raw.plot()

Actual results
Opening raw data file C:\Users\Mathieu\mne_data\MNE-sample-data\MEG\sample\sample_audvis_filt-0-40_raw.fif...
    Read a total of 4 projection items:
        PCA-v1 (1 x 102)  idle
        PCA-v2 (1 x 102)  idle
        PCA-v3 (1 x 102)  idle
        Average EEG reference (1 x 60)  idle
    Range : 6450 ... 48149 =     42.956 ...   320.665 secs
Ready.
Traceback (most recent call last):

  File "C:\Users\Mathieu\AppData\Local\Temp/ipykernel_20280/2983236992.py", line 9, in <module>
    raw.plot()

  File "c:\users\mathieu\documents\git\mne-python\mne\io\base.py", line 1520, in plot
    return plot_raw(self, events, duration, start, n_channels, bgcolor,

  File "<decorator-gen-165>", line 24, in plot_raw

  File "c:\users\mathieu\documents\git\mne-python\mne\viz\raw.py", line 350, in plot_raw
    fig = _browse_figure(**params)

  File "c:\users\mathieu\documents\git\mne-python\mne\viz\_figure.py", line 2353, in _browse_figure
    fig = _figure(inst=inst, toolbar=False, FigureClass=MNEBrowseFigure,

  File "c:\users\mathieu\documents\git\mne-python\mne\viz\_figure.py", line 2341, in _figure
    fig = figure(FigureClass=FigureClass, **kwargs)

  File "C:\Users\Mathieu\Documents\pyvenv\mne\lib\site-packages\matplotlib\pyplot.py", line 797, in figure
    manager = new_figure_manager(

  File "C:\Users\Mathieu\Documents\pyvenv\mne\lib\site-packages\matplotlib\pyplot.py", line 316, in new_figure_manager
    return _backend_mod.new_figure_manager(*args, **kwargs)

  File "C:\Users\Mathieu\Documents\pyvenv\mne\lib\site-packages\matplotlib\backend_bases.py", line 3544, in new_figure_manager
    fig = fig_cls(*args, **kwargs)

  File "c:\users\mathieu\documents\git\mne-python\mne\viz\_figure.py", line 410, in __init__
    self.subplotpars.update(left=left, bottom=bottom, top=top, right=right)

  File "C:\Users\Mathieu\Documents\pyvenv\mne\lib\site-packages\matplotlib\figure.py", line 166, in update
    raise ValueError('bottom cannot be >= top')

ValueError: bottom cannot be >= top

Additional information

Platform:      Windows-10-10.0.19042-SP0
Python:        3.8.10 (tags/v3.8.10:3d8993a, May  3 2021, 11:48:03) [MSC v.1928 64 bit (AMD64)]
Executable:    C:\Users\Mathieu\Documents\pyvenv\mne\Scripts\python.exe
CPU:           AMD64 Family 25 Model 33 Stepping 0, AuthenticAMD: 12 cores
Memory:        31.9 GB
mne:           0.24.dev0
numpy:         1.21.0 {blas=D:\a\1\s\numpy\build\openblas_info, lapack=D:\a\1\s\numpy\build\openblas_lapack_info}
scipy:         1.7.0
matplotlib:    3.4.2 {backend=Qt5Agg}
sklearn:       0.24.2
numba:         0.53.1
nibabel:       3.2.1
nilearn:       0.8.0
dipy:          1.4.1
cupy:          Not found
pandas:        1.3.0
mayavi:        4.7.3
pyvista:       0.31.3 {pyvistaqt=0.5.0, OpenGL 4.5.0 NVIDIA 471.41 via NVIDIA GeForce RTX 3070/PCIe/SSE2}
vtk:           9.0.1
PyQt5:         5.15.4

Perhaps your raw browse size got messed up, what do you get for:
>>> mne.get_config('MNE_BROWSE_RAW_SIZE')
'14.4,8.42'

These are in inches, if yours are too small then bad things happen with the matplotlib layout.

@larsoner That's definitely it. I get '1.82,0.53'. When I tried to run the code from issue #9616 it crashed but created a relatively large window with a tiny matplotlib figure/raw browser in the top left. I guess it somehow changed this config value.
How can I reset it?
And by the way, why is it allowed to change this value, and to change it to small values which then create problems?

why is it allowed to change this value

Having the browse window "remember" your previous window size setting is IMO a very useful feature.  It is updated in the config each time you close a data browser window (raw.plot(), epochs.plot(), or ica.plot_sources()).

and to change it to small values which then create problems? Shouldn't it default to e.g. the monitor size?

Often we don't know how/why it gets set to very small values.  But this error happens often enough that perhaps we should consider making fixed a minimum size?

But this error happens often enough that perhaps we should consider making fixed a minimum size?

Sure, why not. We could also expose a size parameter, probably in pixels (?) for most generality (matches our 3D functions) and future compatibility with other backends. And maybe we should start storing that value in pixels, maybe by detecting float vs int in the values.

But this error happens often enough that perhaps we should consider making fixed a minimum size?

+1
We should handle the race condition of the too-small window and fall back to a sane default.

So you mean we sanity check MNE_BROWSE_RAW_SIZE before creating the window? Good idea!

So you mean we sanity check MNE_BROWSE_RAW_SIZE before creating the window? Good idea!

Yes, either that or we catch the exception and then apply the defaults. Both would yield the same results :)

I'd prefer sanity checking and correcting the values in the config.

I'd prefer sanity checking and correcting the values in the config.

Yes, seems like the MNE way to do things :) +1

Yes, seems like the MNE way to do things :) +1

If by that you are referring to EAFP vs. LBYL, I'm also fine with a try/catch block, but I'd definitely update the config in either case.

There is no need to update the config because it will automatically be updated with the window dimensions when the plot is closed. All we need to do is make sure the window successfully opens


[WIP] add typescript definitions

to resolve #2

@Fil I need to test this out still, so not ready to merge yet.

Seems to work for me when I import this branch into a Typescript project:
import versor = require("versor");

const v0 = versor([ 0, 0, 0 ]);
const v1 = versor([ 90, 0, 0 ]);

const delta = versor.delta(v0, v1);

const delta2 = versor.delta(v0, v1, 0.5);

const cartesian = versor.cartesian([-80, 44]);

const rotation = versor.rotation([10, 30, 40, 4]);

const multiply = versor.multiply([10, 20, 30, 40], [0, 20, 30, 50]);

// typescript yells at this for example
versor.delta("a", "b");

// it also yells about this
versor("a");

// and this
versor.multiply([0, 1, 2]);

in Typescript if you use the import * as versor from "versor" method then you need to use versor.default() to do the equivalent of versor() as with using common js var versor = require("versor").


Snapshot restore throws UPnP Error 701

From issue #454 about an UPnP Error 701 (Transition not available):
@mediaguycouk commented on 7 May 2017 on #454:

I had this error on a snapshot restore(). I mention this as your comment suggests that I should be checking if the Sonos is in a state to be played, but I don't think I have that option with a snapshot.
snap.snapshot()
deviceco.play_uri(alert_uri)
time.sleep(10)
snap.restore()

This should be investigated.

Hi,
I'm seeing this issue as well. Happens pretty regularly, and I'm not sure exactly what causes it or how to fix it. The code detaches a player from a set of players, clears the queue, adds some items to it, and then attempts to .play(), which then throws an error. I can see that the other steps have worked, and when I try to play the queue in the desktop controller it works fine.
    sonos_player.play()
  File "/home/pi/.local/lib/python2.7/site-packages/soco/core.py", line 105, in inner_function
    return function(self, *args, **kwargs)
  File "/home/pi/.local/lib/python2.7/site-packages/soco/core.py", line 558, in play
    ('Speed', 1)
  File "/home/pi/.local/lib/python2.7/site-packages/soco/services.py", line 217, in _dispatcher
    return self.send_command(action, *args, **kwargs)
  File "/home/pi/.local/lib/python2.7/site-packages/soco/services.py", line 501, in send_command
    self.handle_upnp_error(response.text)
  File "/home/pi/.local/lib/python2.7/site-packages/soco/services.py", line 560, in handle_upnp_error
    error_xml=xml_error
soco.exceptions.SoCoUPnPException: UPnP Error 701 received: Transition not available from <IP_ADDRESS>

@DPH I think the snapshot code was originally you addition. Do you want to have a look?

@KennethNielsen had a look when I saw this back in April - but will look again.
Cheers David

This is a challenging intermittent error. I have struggled to replicate on my system, but did achieve it twice after lots of tries. On investigation when snapshot restores, the first thing is check if something is still PLAYING and if so PAUSE it.
I believe that the cause of this error is a small network delay where the request for current_transport_state shows PLAYING when the track has just STOPPED.  Issuing a PAUSE when it is STOPPED causes a UPnP 701.
To fix this we can change self.device.pause() in line 178 of snapshot.py to self.device.stop()
Issuing a STOP when the track has already STOPPED does not cause an error, but still ensures playing is halted. As this is hard to test, before we make the change could I ask those having this issue quite regularly to try it. @sglickman @ghcs27
@KennethNielsen let me know if you would like me to make a pull request for this.
Cheers David

When I've experienced it, there's definitely nothing playing and there hasn't been anything playing particularly recently, but I'll try adding a .stop() call first.
thanks!


Improve documentation

Architecture diagrams, onboarding and setup for stacks.

Addition of architecture diagram and high level onboarding documentation is now available for the backend stacks.


Azure Kubernetes Service Solution Changes

Azure Kubernetes Service Solution Changes
Required items, please complete
Change(s):

See guidance below

Reason for Change(s):

See guidance below

Version Updated:

Required only for Detections/Analytic Rule templates
See guidance below

Testing Completed:

Test Document

Checked that the validations are passing and have addressed any issues that are present:

See guidance below

Guidance <- remove section before submitting

Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR.  Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process.  Providing associated Issues that this resolves also easily connects the reason.

Change(s):

Updated syntax for XYZ.yaml

Reason for Change(s):

New schema used for XYZ.yaml
Resolves ISSUE #1234

Version updated:

Yes
Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly.  If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:

Guidance for Detection checks
General contribution guidance
PR validation troubleshooting

CreateUI definition looking good

Maintemplate deployment succeeded

In Hunting queries tested in "CybersecuritySOC" workspace and attached screenshots in PR test document itself.
Active content created for  workbook

All are looking good

Merged since Suresh is approved the PR


Example App appears blank

I can build the sample app successfully.  It loads but quickly end up with blank screen.  Appreciate your response to rectify this issue.

Hi!
Make sure that you run
yarn install
and
yarn start
from the root folder of the repo (not from the example folder).
If this doesn't resolve the issue, it would be helpful if you could provide more info about your system and node/browser console logs

Thanks for the prompt reply.
My system information as below:
node -v
v16.17.1
yarn -V
yarn install v1.22.19
ubuntu-distro-info --lts
jammy
Dev server IP:port
<IP_ADDRESS>:3000
Deployment output:
$ yarn install
yarn install v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has unmet peer dependency "react@>=15".
warning " ><EMAIL_ADDRESS>has unmet peer dependency "react-dom@>=15".
warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has unmet peer dependency "react@>=15".
warning " ><EMAIL_ADDRESS>has unmet peer dependency "react-dom@>=15".
warning "workspace-aggregator-d9289832-e8a5-40b3-abbd-8582d694908d > @livekit/react-components ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^17.0.0".
warning "workspace-aggregator-d9289832-e8a5-40b3-abbd-8582d694908d > @livekit/react-components ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^17.0.0".
warning "workspace-aggregator-d9289832-e8a5-40b3-abbd-8582d694908d > @livekit/react-components ><EMAIL_ADDRESS>has unmet peer dependency "@testing-library/dom@>=5".
warning "workspace-aggregator-d9289832-e8a5-40b3-abbd-8582d694908d > @livekit/react-components ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "workspace-aggregator-d9289832-e8a5-40b3-abbd-8582d694908d > @livekit/react-components > eslint-config-standard-react ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "workspace-aggregator-d9289832-e8a5-40b3-abbd-8582d694908d > @livekit/react-components > react-scripts > eslint-config-react-app ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "workspace-aggregator-d9289832-e8a5-40b3-abbd-8582d694908d > @livekit/react-components > react-scripts > eslint-config-react-app ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>[4/4] Building fresh packages...
Done in 51.50s.
yarn start
yarn run v1.22.19
$ turbo run start
• Packages in scope: @livekit/react-components, @livekit/react-core, livekit-react-example
• Running start in 3 packages
@livekit/react-core:build: cache miss, executing 0df9302f818e0c99
@livekit/react-core:start: cache bypass, force executing d30e236df37aec0f
@livekit/react-core:build: $ microbundle-crl --no-compress --format modern,cjs
@livekit/react-core:start: $ microbundle-crl watch --no-compress --format modern,cjs
@livekit/react-core:start: Watching source, compiling to dist:
@livekit/react-core:build: Build "reactCore" to dist:
@livekit/react-core:build:        2.5 kB: index.js.gz
@livekit/react-core:build:       2.19 kB: index.js.br
@livekit/react-core:build:       2.41 kB: index.modern.js.gz
@livekit/react-core:build:       2.12 kB: index.modern.js.br
@livekit/react-components:start: cache bypass, force executing 7ce71d80eb9b4d2a
@livekit/react-components:build: cache miss, executing 60c2bcfd2caac8ef
@livekit/react-core:start: Wrote 2.02 kB: index.modern.js.gz
@livekit/react-core:start:       1.78 kB: index.modern.js.br
@livekit/react-core:start: Wrote 2.5 kB: index.js.gz
@livekit/react-core:start:       2.19 kB: index.js.br
@livekit/react-components:start: $ microbundle-crl watch --no-compress --format modern,cjs
@livekit/react-components:build: $ microbundle-crl --no-compress --format modern,cjs
@livekit/react-components:start: Watching source, compiling to dist:
@livekit/react-components:build: Build "reactComponents" to dist:
@livekit/react-components:build:       7.34 kB: index.js.gz
@livekit/react-components:build:       6.46 kB: index.js.br
@livekit/react-components:build:       7.19 kB: index.modern.js.gz
@livekit/react-components:build:        6.3 kB: index.modern.js.br
livekit-react-example:start: cache bypass, force executing a6d1d4df4a31a19e
livekit-react-example:start: $ react-scripts start
@livekit/react-components:start: Wrote 6.2 kB: index.modern.js.gz
@livekit/react-components:start:       5.47 kB: index.modern.js.br
@livekit/react-components:start: Wrote 7.49 kB: index.js.gz
@livekit/react-components:start:       6.58 kB: index.js.br
livekit-react-example:start: (node:10881) [DEP_WEBPACK_DEV_SERVER_ON_AFTER_SETUP_MIDDLEWARE] DeprecationWarning: 'onAfterSetupMiddleware' option is deprecated. Please use the 'setupMiddlewares' option.
livekit-react-example:start: (Use node --trace-deprecation ... to show where the warning was created)
livekit-react-example:start: (node:10881) [DEP_WEBPACK_DEV_SERVER_ON_BEFORE_SETUP_MIDDLEWARE] DeprecationWarning: 'onBeforeSetupMiddleware' option is deprecated. Please use the 'setupMiddlewares' option.
livekit-react-example:start: Starting the development server...
livekit-react-example:start:
livekit-react-example:start: Compiled with warnings.
livekit-react-example:start:
livekit-react-example:start: Failed to parse source map: 'webpack:///dist/react-responsive.js' URL is not supported
livekit-react-example:start:
:
livekit-react-example:start: Failed to parse source map: 'webpack:///dist/react-responsive.js' URL is not supported
livekit-react-example:start:
livekit-react-example:start: Search for the keywords to learn more about each warning.
livekit-react-example:start: To ignore, add // eslint-disable-next-line to the line before.
livekit-react-example:start:
livekit-react-example:start: WARNING in ../node_modules/react-responsive/dist/react-responsive.js
livekit-react-example:start: Module Warning (from ../node_modules/source-map-loader/dist/cjs.js):
livekit-react-example:start: Failed to parse source map: 'webpack:///dist/react-responsive.js' URL is not supported
livekit-react-example:start:
livekit-react-example:start: webpack compiled with 1 warning
livekit-react-example:start: No issues found.

thank you!
to figure out what's going wrong:

does it work when you run it locally and access it via localhost:3000 ?
are there any additional logs either in the browser or from nodejs after you try to open localhost:3000?

As you have assumed, it is working at localhost.  I even cloned  it and deployed  to gh-pages here: https://reactdemo.kit.cyber.lk/ working fine this too.
Great, Thanks a lot for the tip.


No such middleware

Linux discourse 4.4.0-38-generic #57-Ubuntu SMP Tue Sep 6 15:42:33 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-linux]
vagrant@discourse:/vagrant$ zeus start
Starting Zeus server v0.15.10
[ready] [crashed] [running] [connecting] [waiting]
boot
└
...

vagrant@discourse:/vagrant$ zeus console
/home/vagrant/.rvm/gems/ruby-2.3.1/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/middleware/stack.rb:125:in `assert_index': No such middleware to insert after: ActionDispatch::DebugExceptions (RuntimeError)
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/actionpack-<IP_ADDRESS>/lib/action_dispatch/middleware/stack.rb:96:in `insert_after'
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/railties-<IP_ADDRESS>/lib/rails/configuration.rb:68:in `block in merge_into'
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/railties-<IP_ADDRESS>/lib/rails/configuration.rb:67:in `each'
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/railties-<IP_ADDRESS>/lib/rails/configuration.rb:67:in `merge_into'
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/railties-<IP_ADDRESS>/lib/rails/engine.rb:501:in `app'
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/railties-<IP_ADDRESS>/lib/rails/application/finisher.rb:34:in `block in <module:Finisher>'
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:30:in `instance_exec'
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:30:in `run'
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:55:in `block in run_initializers'
        from /home/vagrant/.rvm/rubies/ruby-2.3.1/lib/ruby/2.3.0/tsort.rb:228:in `block in tsort_each'
        from /home/vagrant/.rvm/rubies/ruby-2.3.1/lib/ruby/2.3.0/tsort.rb:350:in `block (2 levels) in each_strongly_connected_component'
        from /home/vagrant/.rvm/rubies/ruby-2.3.1/lib/ruby/2.3.0/tsort.rb:431:in `each_strongly_connected_component_from'
        from /home/vagrant/.rvm/rubies/ruby-2.3.1/lib/ruby/2.3.0/tsort.rb:349:in `block in each_strongly_connected_component'
        from /home/vagrant/.rvm/rubies/ruby-2.3.1/lib/ruby/2.3.0/tsort.rb:347:in `each'
        from /home/vagrant/.rvm/rubies/ruby-2.3.1/lib/ruby/2.3.0/tsort.rb:347:in `call'
        from /home/vagrant/.rvm/rubies/ruby-2.3.1/lib/ruby/2.3.0/tsort.rb:347:in `each_strongly_connected_component'
        from /home/vagrant/.rvm/rubies/ruby-2.3.1/lib/ruby/2.3.0/tsort.rb:226:in `tsort_each'
        from /home/vagrant/.rvm/rubies/ruby-2.3.1/lib/ruby/2.3.0/tsort.rb:205:in `tsort_each'
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:54:in `run_initializers'
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/railties-<IP_ADDRESS>/lib/rails/application.rb:352:in `initialize!'
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/railties-<IP_ADDRESS>/lib/rails/railtie.rb:194:in `public_send'
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/railties-<IP_ADDRESS>/lib/rails/railtie.rb:194:in `method_missing'
        from /vagrant/config/environment.rb:5:in `<top (required)>'
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:274:in `require'
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:274:in `block in require'
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:240:in `load_dependency'
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:274:in `require'
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/railties-<IP_ADDRESS>/lib/rails/application.rb:328:in `require_environment!'
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/zeus-0.15.10/lib/zeus/rails.rb:105:in `development_environment'
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/zeus-0.15.10/lib/zeus.rb:199:in `block in run_action'
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/zeus-0.15.10/lib/zeus/load_tracking.rb:11:in `features_loaded_by'
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/zeus-0.15.10/lib/zeus.rb:197:in `run_action'
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/zeus-0.15.10/lib/zeus.rb:72:in `block in boot_steps'
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/zeus-0.15.10/lib/zeus.rb:56:in `catch'
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/zeus-0.15.10/lib/zeus.rb:56:in `boot_steps'
        from /home/vagrant/.rvm/gems/ruby-2.3.1/gems/zeus-0.15.10/lib/zeus.rb:48:in `go'
        from -e:1:in `<main>'

Interesting issue, is this happening on just discourse or on multiple apps for you? It looks like there is an issue with the order of requires but this seems to be reasonably deep in the rails stack which seems odd as this seems solid in the apps I have touched so far. Would you be able to try again with the newest Zeus and discourse version just to check if this is still an issue?

I can't reproduce this so I'm closing it for now maybe it got fixed in a recent version? Feel free to reopen if you are still experiencing this. Thank you :)


GETARRAY is missing in the Azure Resource Manager Data Source

In this section: https://learn.microsoft.com/en-us/azure/azure-monitor/visualize/workbooks-data-sources#azure-resource-manager, there's a note that says "Only GET, POST, and HEAD operations are currently supported.", however, it does not provide further information about the GETARRAY operation. This was crucial when I had to call my secrets from Azure Key Vault to resolve a paging issue where without the GETARRAY, I would have had to manually follow a NextLink option.
Please include more information about each operation and when to use.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 51d6b063-f5a0-a048-c463-f69929e57d8e
Version Independent ID: 1dae5d46-4545-c9c7-5dcc-11f32c6de25d
Content: Azure Workbooks data sources - Azure Monitor
Content Source: articles/azure-monitor/visualize/workbooks-data-sources.md
Service: azure-monitor
Sub-service: visualizations
GitHub Login: @AbbyMSFT
Microsoft Alias: abbyweisberg

@FabianGonzalez-MSFT
Thanks for your feedback! We will investigate and update as appropriate.

#assign: @gardnerjr

Addressed in a PR in azure docs, more details will be available soon
#please-close


Add ability to change users' roles in the manage users page

Also removes enzyme.

 Add page in UI for admins to assign roles to people


Enhancement: Retrieve manager(s) via aad user get

Let's extend command aad user get with the possibility to retrieve the manager. It is possible to retrieve the direct manager, or retrieve the whole manager tree to the top.
Options to add

Option
Description

--withManager
Retrieve the direct manager for the user.

API request
https://learn.microsoft.com/en-us/graph/api/user-list-manager?view=graph-rest-1.0&tabs=http
We can get the manager by expanding the manager property on the user object.
Since the whole user object of the manager is returned, the response becomes huge. Therefore I suggest that we only show:

UPN
Display Name
ID
Email

of the manager. Let's use this as select query in the request.

Seems like a solid plan. I would suggest we simplified the manager user object a bit more, like removing the property ´email´. Mainly, because the nested object can become quite big with a lot of managers.

What we also need to think about is how we present managers hierarchy in non-JSON output mode.

Valid point
We could do something like we do for spo term list

Creating something like managerId to specify the ID of the manager and print all managers as separate values. Something like: (sorry for the bad formatting, it's harder to align than it looks 😄)
id                                     userName         managerId
------------------------------------   --------------  ---------------
00000000-0000-0000-0000-000000000000    John Doe        00000000-0000-0000-0000-000000000001
00000000-0000-0000-0000-000000000001    Megan Bowen     00000000-0000-0000-0000-000000000002
00000000-0000-0000-0000-000000000002    Ray Cookes

However it's counter intuitive that a get command returns multiple items in text/csv output.

I think it would be confusing, because for a get command we expect a single item, not a collection. For text output, we could display only the first one and ignore other levels. If you want multiple levels, then you're likely doing something around automation and JSON is probably the format you'd use.
Perhaps there's also something to say for a different command, like aad user hierarchy get that allows you to get the hierarchy for the specified user and then indeed, we'd return a collection of items where each one corresponds to a different hierarchy level.

Perhaps there's also something to say for a different command, like aad user hierarchy get that allows you to get the hierarchy for the specified user and then indeed, we'd return a collection of items where each one corresponds to a different hierarchy level.

I think it will be inconsistent if setting the manager can be done by aad user add and aad user set, but if you want to retrieve it you should use aad user hierarchy get. Or do you mean that you should only get one manager using aad user get and if you want to retrieve more managers, you should use another command?
Anyway, my vote would go to aad user get being able to retrieve the managers hierarchy, if you are using text, csv or md as output, you're only getting the direct manager.

Or do you mean that you should only get one manager using aad user get and if you want to retrieve more managers, you should use another command?

Yes, that's what I meant. It would be consistent with the behavior that with add/set you can set the direct manager and with get, you get the direct manager too. Bringing in the whole hierarchy to me goes beyond the purpose of the user get command and would belong in a separate command.

So should I update the spec and change --managerLevel [managerLevel] to --withManager ?

Yes, let's update and then propose a new command to get the management hierarchy.

Specs updated!

Ship it!

Can I work on this please?

Definitely! All yours!


Add Auto Comment Feature to Improve Collaboration

Issue Description:
As an active contributor to your open-source project, I believe that implementing an auto-comment feature would greatly enhance collaboration and communication within the project. This feature would automatically generate comments in response to specific events, such as when an issue is opened, a pull request is created, an issue is assigned, or an issue is unassigned.
Feature Details:

When an issue is opened, the auto-comment should greet the author and provide a brief acknowledgement and request for additional context.
When a pull request is opened, the auto-comment should greet the author, express gratitude, and remind them to follow the project's contributing guidelines.
When an issue is closed, the auto-comment should thank the author for their contribution and encourage further engagement.
When an issue is assigned to someone, the auto-comment should notify the assignee and encourage them to start working on it.
When an issue is unassigned from someone, the auto-comment should notify the assignee about the change and suggest reassignment if they are offline.

Benefits:

Improved communication and engagement with contributors.
Provides clear instructions and acknowledgements for various events.
Enhances collaboration by setting expectations and providing reminders.
Reduces manual effort by automating comment generation.

Acceptance Criteria:

The auto-comment feature should be implemented using the "wow-actions/auto-comment" GitHub Action.
Comments should be appropriately customized for each event, mentioning relevant parties and providing the necessary information.
The auto-comment workflow should trigger on the following events: issues opened, pull requests opened, issues closed, issues assigned, and issues unassigned.
The feature should be added to the project's existing GitHub Actions workflow file.

Additional Context:
Feel free to ask any questions or seek clarification regarding the auto-comment feature. I'm excited about contributing to your project and believe this enhancement will greatly benefit its community.

Hello @Nishitbaria , I want to work on this issue

Hey @KanishkaVerma054  if want to work on this issue you cam ask collaborator to assign this issue

Where I can ask the collaborator to assign me this issue?

You can ask them in Discord

You can ask them in Discord

I'm not getting the discord channel of this project may you please give me the link for the project


Fix message id

Summary
Fix message id introduced by this changes
Ticket Link
N/A
Checklist

[x] Includes text changes and localization file (.../i18n/en.json) updates

@kaakaa Nice catch!


Python Guidelines: Fit content to new Guidelines structure

Description
Per the MQ Guidelines initiative to fill gaps in the guidelines across languages, we are moving to a new common structure for the guidelines and calling out areas where there are content gaps -- i.e. one or more of the other language guidelines have guidance that is not language-specific that is not represented in this language's guidelines.
Details
Design
Please add guidance for the following sections:

[ ] ### Support for non-HTTP protocols
[ ] Service Client Configuration Options
[ ] Service Client Immutability
[ ] Service Method Parameters
[ ] Conditional Request Methods
[ ] Extensible enums, if relevant
[ ] Samples

Implementation Note
For the implementation, the below structure is based on .NET content.  It is intended to provide implementation details for things that aren't visible in the public API, with a TOC that largely maps to the API Design section in the Design TOC, with sections filled for areas where you already have content written.  Feel free to reach out with any questions.
New Structure
(Numbers for ease of reading here, but won't be shown in the guidelines page TOC)
For further details, please see the restructured .NET guidelines here.
Design

Introduction

Design Principles
General Guidelines
Non-HTTP Libraries

Azure SDK API Design

Service Client

Service Client Constructors

Client Configuration
Setting the Service Version
Sync and Async
Client Immutability

Service Methods

Naming
Return Types
Cancellation

Service Method Parameters

Options Parameters
Parameter Validation

Methods Returning Collections (Paging)
Methods Invoking Long Running Operations
Conditional Request Methods
Hierarchical Clients

Supporting Types

Model Types
Enumerations
Using Azure Core Types
Using Primitive Types

Exceptions (Errors)
Authentication
Namespaces
Support for Mocking

Azure SDK Libraries (Packages)

Packaging

Service-Specific Common Libraries

Versioning
Dependencies
Native Code
Doc Comments

Repository Guidelines

Documentation Style
README
Samples

Implementation

API Implementation

Service Client

Service Methods

HttpPipeline
HttpPipelinePolicy/Custom Policies

Service Method Parameters

Parameter Validation

Supporting Types
1. Serialization
2. Enumeration-like Structs

SDK Feature Implementation

Configuration
Logging
Distributed Tracing
Telemetry

Testing
Language-specific other

@salameer FYI


test: 💍 messageFile test

#206

@huan ping

This bug should be fixed by upgrading the FileBox.
See:

https://github.com/huan/file-box/issues/79


If you continue this project when Github purchased by Microsoft

Sorry for my poor english.But I so worry about this qustion

I do too, I mean it would be funny if https://atom.io/ redirected to https://code.visualstudio.com/. It would be nice to have a developer comment though, as the GitHub deal will likely close soon.

Move to Gitlab?
Github is acquired by Micro$oft.
https://www.theverge.com/2018/6/3/17422752/microsoft-github-acquisition-rumors

Thanks everyone for your concern.
Atom remains key to GitHub. Our product roadmap is set, and the team will continue all of their work.

Because we treat our issues list as the Atom team's backlog, we close issues that are questions since they don't represent a task needing to be completed. For most questions about Atom there are a lot of options, check out:

The Atom Flight Manual
The Atom FAQ on Discuss
Discuss, the official Atom and Electron message board
Join the Atom Slack team

On Discuss and in the Atom Slack team, there are a bunch of helpful community members that should be willing to point you in the right direction.

@lee-dohm Thanks for you work

I'm glad Atom development will continue. It's far more polished with better UX + more extensible than VSCode.

If you want to be further reassured that Atom will continue, see this comment by GitHub's future CEO: https://www.reddit.com/r/AMA/comments/8pc8mf/im_nat_friedman_future_ceo_of_github_ama/e0a235q/

Developers are really particular about their setup, and choosing an editor is one of the most personal decisions a developer makes.  The last thing I would want to do is take that decision away from Atom users.
Atom is a fantastic editor with a healthy community, adoring fans, excellent design, and a promising foray into real-time collaboration. At Microsoft, we already use every editor from Atom to VS Code to Sublime to Vim, and we want developers to use any editor they prefer with GitHub.
So we will continue to develop and support both Atom and VS Code going forward.

It's better to merge these two projects. That's just my opinion.

atomiks
I get it .. you like Atom, good for you but VSCode is by far best editor I've used, so pls stop being microsoft hating sheep.
I hated them because of actions they did .. bude those were different people in different time and world.
But when they do tools like this it's nothing negative. Its positive even for atom. Without competition you became lazy ;)

@ino76 your comment was hidden as a violation of the Atom Code of Conduct as it was insulting or derogatory. You may consider this an official warning.

lee-dohm
is it good now or people can't post comments here because of biased censorship?

I gonna have to learn to take others comments so comments and
Julesvicious
On Aug 5, 2018, at 7:50 PM, ino76<EMAIL_ADDRESS>wrote:
lee-dohm
is it good now or people can't post comments here because of biased censorship?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Prop filtering

What:
Filter props on string tags.

Why:
#183

How:
Regex generated at build time with babel-plugin-preval.

Checklist:

[ ] Documentation
[ ] Tests
[x] Code complete

This adds about 1kb to the react version.

Codecov Report

Merging #227 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
+ Coverage   90.27%   90.31%   +0.04%
==========================================
  Files          20       20
  Lines         967      971       +4
  Branches      262      264       +2
==========================================
+ Hits          873      877       +4
  Misses         76       76
  Partials       18       18

Impacted Files
Coverage Δ

src/macro-styled.js
100% <100%> (ø)
:arrow_up:

src/react/index.js
100% <100%> (ø)
:arrow_up:

src/utils.js
71.42% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 502b76f...e2fb773. Read the comment docs.


Bug on Xamarin Live player

I tried to run the iOS sample on Visual Studio 15.4 with Xamarin Live player and it gave me this strange error. not sure if it's due to a limitation on the live player itself or some bug with the code. will confirm after I get access to the Mac after this weekend

I tried it on the latest Visual Studio for Mac, and the project doesn't load at all. could you look into this?


Switch from "java" to "openjdk" base docker containers.

The java images have been deprecated according to the site in favor of the openjdk images.

This is in the 2.0 branch at this point.


Does not catch the error message from prompts.

No error message from the prompts are catched.

:tada: This issue has been resolved in version 2.3.0-beta.1 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 2.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[e2e]: go workflow_dispatch branch1 config-ldflags slsa3

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/9441134087
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.workflow_dispatch.branch1.config-ldflags.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.workflow_dispatch.branch1.config-ldflags.slsa3.yml
Trigger: workflow_dispatch
Branch: branch1
Date: Mon Jun 10 01:32:25 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/9458115290
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.workflow_dispatch.branch1.config-ldflags.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.workflow_dispatch.branch1.config-ldflags.slsa3.yml
Trigger: workflow_dispatch
Branch: branch1
Date: Tue Jun 11 01:35:20 UTC 2024
Tests are passing now. Closing this issue.


Implement sign out

A sign out method should be added
This should be a delete endpoint, maybe DELETE /api/authentication, this should use getAuthenticationState and delete the associated state, if there is a cookie set, it should be deleted.


Added testcase :Issue multiple restores

Issue mutliple restores with different combinations of restores

What this PR does / why we need it:
Which issue(s) this PR fixes (optional)
Closes #https://portworx.atlassian.net/browse/PA-326
Special notes for your reviewer:
Aetos: http://aetos.pwx.purestorage.com/resultSet/testSetID/84441

Please mention the name of the restore that you are deleting so that we know which restore is causing in an issue in case of failures. Please do the same at all places.

done


Fix noticeable freeze after saving a scene

Fixes #93104 and maybe #92515
After testing with a project having a lot of Resources I was able to reproduce the problem.
MRP:
test-godot-resource-icon.zip
The problem came from the modifications in _get_entry_script_icon for the management of the resource icons, more specifically the calls to ResourceLoader::get_resource_type and EditorFileSystem::get_singleton()->find_file:

I reused the cache that was there but instead of resetting the cache at each _update_tree, I created a clear_icon_cache method and called it only when an icon script or a resource changes. I probably missed some places where the icons could change!?!
It's really not perfect but I guess the performance should be the same as before #77932.
My tests with 3000 resources:
Before: 4-4.5 seconds
After: 1.5-2 seconds
The time remaining on a save occurs in the Tree, I'm really not sure I should touch that:

Thanks for testing this PR.
I tested on my system and effectively with an optimized build with optimize=speed lto=full the master version is pretty fast even if my PC is less performant then yours, it's around 1.5sec after the save and before the editor unfreeze. With the PR, it's less then a second.
For the scrollbar, I don't have the same issue about the scroll bar position.
My PC specifications:
CPU: Intel Core i5-11600KF 3.9Ghz
GPU: NVIDIA GeForce RTX 3060
OS: Windows 11
Master version:
https://github.com/godotengine/godot/assets/81109165/fc4425b3-3615-4bf2-a43a-7d8a329502c8
This PR version:
https://github.com/godotengine/godot/assets/81109165/a447f265-7b94-4b3b-97fd-13f8656c2d91

One difference I found with my latest modifications are icons for the script that have a @icon. Before these scripts did not have an icon, now they do because of the line icon_path = file_info->script_class_icon_path; in EditorFileSystem::_update_file_icon_path.
Before:

After:

Should I removed this line?

Technically it's consistent with the inspector showing icon in Script field, but personally I find it annoying. I think scripts should show script icon (for their language), not their @icon, which should be reserved for instances of these scripts.

I tend to agree with you. I'll revert it to what it was before.

Done!

Thanks!


PLAT-3623 Decommission codecov

Remove coverage submission via codecov

All the tests failed, but again I am not sure what this repo is for ..

@ksex oh shoot I didn't see that let me fix

@ksex should be fixed now


Invalid configuration object

        throw new WebpackOptionsValidationError(webpackOptionsValidationErrors);
        ^
WebpackOptionsValidationError: Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.
 - configuration has an unknown property 'vue'. These properties are valid:
   object { amd?, bail?, cache?, context?, dependencies?, devServer?, devtool?, entry, externals?, loader?, module?, name?, node?, output?, plugins?, profile?, recordsInputPath?, recordsOutputPath?, recordsPath?, resolve?, resolveLoader?, stats?, target?, watch?, watchOptions? }
   For typos: please correct them.
   For loader options: webpack 2 no longer allows custom properties in configuration.
     Loaders should be updated to allow passing options via loader options in module.rules.
     Until loaders are updated one can use the LoaderOptionsPlugin to pass these options to the loader:
     plugins: {
       new webpack.LoaderOptionsPlugin({
         // test: /\.xxx$/, // may apply this only for some modules
         options: {
           vue: ...
         }
       })
     }
 - configuration.resolve has an unknown property 'fallback'. These properties are valid:
   object { alias?, aliasFields?, cachePredicate?, descriptionFiles?, enforceExtension?, enforceModuleExtension?, extensions?, fileSystem?, mainFields?, mainFiles?, moduleExtensions?, modules?, plugins?, resolver?, symlinks?, unsafeCache? }
 - configuration.resolve.extensions[0] should not be empty.
 - configuration.resolveLoader has an unknown property 'fallback'. These properties are valid:
   object { alias?, aliasFields?, cachePredicate?, descriptionFiles?, enforceExtension?, enforceModuleExtension?, extensions?, fileSystem?, mainFields?, mainFiles?, moduleExtensions?, modules?, plugins?, resolver?, symlinks?, unsafeCache? }
    at webpack (/Users/Maopy/www/mobile/node_modules/webpack/lib/webpack.js:16:9)
    at Object.<anonymous> (/Users/Maopy/www/mobile/webpack/build.js:23:1)
    at Module._compile (module.js:556:32)
    at loader (/usr/local/lib/node_modules/babel-cli/node_modules/babel-register/lib/node.js:146:5)
    at Object.require.extensions.(anonymous function) [as .js] (/usr/local/lib/node_modules/babel-cli/node_modules/babel-register/lib/node.js:156:7)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Function.Module.runMain (module.js:590:10)
    at /usr/local/lib/node_modules/babel-cli/lib/_babel-node.js:151:24
    at Object.<anonymous> (/usr/local/lib/node_modules/babel-cli/lib/_babel-node.js:152:7)
    at Module._compile (module.js:556:32)
    at Object.Module._extensions..js (module.js:565:10)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)

<EMAIL_ADDRESS>

This template is not compatible with Webpack 2.0 yet.

@chrisvfritz<EMAIL_ADDRESS>is ok

With beta.19 it might not fail right away, but last time I checked, many of the companion libraries had not yet been updated to work with 2.0 yet, so I still recommend putting off that upgrade.

我也是这么bug

@Maopy yes it works,but will this be fixed?or design another way?
the<EMAIL_ADDRESS>is released, 2.x will be a tending.

I encountered the same problem,with<EMAIL_ADDRESS>and vue-cli@2.8.1,not sure about whether if i downgrade or upgrade.
node_modules\webpack\lib\webpack.js:19
                throw new WebpackOptionsValidationError(webpackOptionsValidationErrors);
                ^

WebpackOptionsValidationError: Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.
 - configuration has an unknown property 'vue'. These properties are valid:
   object { amd?, bail?, cache?, context?, dependencies?, devServer?, devtool?, entry, externals?, loader?, module?, name?, node?, output?, performance?, plugins?, profile?, recordsInputPath?, recordsOutputPath?, recordsPath?, resolve?, resolveLoader?, stats?, target?, watch?, watchOptions? }
   For typos: please correct them.
   For loader options: webpack 2 no longer allows custom properties in configuration.
     Loaders should be updated to allow passing options via loader options in module.rules.
     Until loaders are updated one can use the LoaderOptionsPlugin to pass these options to the loader:
     plugins: [
       new webpack.LoaderOptionsPlugin({
         // test: /\.xxx$/, // may apply this only for some modules
         options: {
           vue: ...
         }
       })
     ]
 - configuration.resolve has an unknown property 'fallback'. These properties are valid:
   object { alias?, aliasFields?, cachePredicate?, descriptionFiles?, enforceExtension?, enforceModuleExtension?, extensions?, fileSystem?, mainFields?, mainFiles?, moduleExtensions?, modules?, plugins?, resolver?, symlinks?, unsafeCache?, useSyncFileSystemCalls? }
 - configuration.resolve.extensions[0] should not be empty.
 - configuration.resolveLoader has an unknown property 'fallback'. These properties are valid:
   object { alias?, aliasFields?, cachePredicate?, descriptionFiles?, enforceExtension?, enforceModuleExtension?, extensions?, fileSystem?, mainFields?, mainFiles?, moduleExtensions?, modules?, plugins?, resolver?, symlinks?, unsafeCache?, useSyncFileSystemCalls? }
    at webpack (xxx\node_modules\webpack\lib\webpack.js:19:9)
    at Object.<anonymous> (xxx\build\dev-server.js:18:16)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Function.Module.runMain (module.js:441:10)
    at startup (node.js:139:18)
    at node.js:974:3

What happens when the error just says
options: {
 23: ....


Web page is not working :(

I'm using a Wemos D1 mini +  RFM95. On the IDE terminal, the gateway seems to be working, is connected to my wifi network and I get an IP, but when I used it in a web browser, I can't view any web page...
I tried the WifiManager and is running good, I can configure an wifi network through the browser...
Anyone can help me?

I wasn´t declaring the _PIN_OUT value after the #defined ESP8266 . Is working now


Update synapse-workspace-ip-firewall.md ports and protocols

There is mention of a required port of 1443 for Synapse Studio. I'm assuming that this is a typo and the port is actually 1433. Requesting an update to the document to reflect the correct port.

@Danzhang-msft

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

@Danzhang-msft - can you update the author metadata value; it's not a valid GitHub alias.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Our doc is correct. It is 1443 not 1433 for Synapse studio.

Closing per https://github.com/MicrosoftDocs/azure-docs/pull/121980#issuecomment-2080313465. Thanks!


Enso Docs: Fix inline scripts.

Pull Request Description
Optimizes and fixes inline scripts by removing them and putting into IDE. It makes the sent html much smaller then 👍
Important Notes

Checklist
Please include the following checklist in your PR:

[x] The documentation has been updated if necessary.
[x] All code conforms to the Scala, Java, and Rust style guides.
[x] All documentation and configuration conforms to the markdown and YAML style guides.
[x] All code has been tested where possible.

@BinarySoftware what is happening with this PR?


reserved_role breaks DROP ROLE IF EXISTS ....

Bug report
Describe the bug
If you enable supautils.reserved_roles, DROP ROLE IF EXISTS ... fails with SQLSTATE 42704 for non-existent users instead of skipping the DROP USER.
To Reproduce

Configure Postgres with supautils and set supautils.reserved_roles to a reserved role.
run  DROP ROLE IF EXISTS for a non-existent user, it will return an error instead of skipping the drop - SQLSTATE 42704

For example:
Settings from postgresql.conf
# Add settings for extensions here
shared_preload_libraries = 'supautils'
supautils.reserved_memberships = 'pg_read_server_files,pg_write_server_files,pg_execute_server_program,pg_read_all_settings'
supautils.reserved_roles = 'user_a'

psql -U admin test
psql (12.7)
Type "help" for help.

test=> \du
                                   List of roles
 Role name |                         Attributes                         | Member of
-----------+------------------------------------------------------------+-----------
 admin     | Create role, Create DB                                     | {}
 postgres  | Superuser, Create role, Create DB, Replication, Bypass RLS | {}
 user_a    |                                                            | {}
 user_b    |                                                            | {}

test=> DROP ROLE IF EXISTS "user_b";
DROP ROLE
test=> \du
                                   List of roles
 Role name |                         Attributes                         | Member of
-----------+------------------------------------------------------------+-----------
 admin     | Create role, Create DB                                     | {}
 postgres  | Superuser, Create role, Create DB, Replication, Bypass RLS | {}
 user_a    |                                                            | {}

test=> DROP ROLE IF EXISTS "user_b";
ERROR:  role "user_b" does not exist

Disabling the reserved_role settings allows it to work as intended:
psql -U admin test
psql (12.7)
Type "help" for help.

test=> \du
                                   List of roles
 Role name |                         Attributes                         | Member of
-----------+------------------------------------------------------------+-----------
 admin     | Create role, Create DB                                     | {}
 postgres  | Superuser, Create role, Create DB, Replication, Bypass RLS | {}
 user_a    |                                                            | {}

test=> DROP ROLE IF EXISTS "user_b";
NOTICE:  role "user_b" does not exist, skipping
DROP ROLE

Debug logs from the failing DROP
2021-08-31 18:40:25.642 UTC [358] DEBUG:  CommitTransaction(1) name: unnamed; blockState: STARTED; state: INPROGRESS, xid/subid/cid: 0/1/0
2021-08-31 18:40:27.107 UTC [358] DEBUG:  StartTransaction(1) name: unnamed; blockState: DEFAULT; state: INPROGRESS, xid/subid/cid: 0/1/0
2021-08-31 18:40:27.107 UTC [358] NOTICE:  role "user_b" does not exist, skipping
2021-08-31 18:40:27.108 UTC [358] DEBUG:  CommitTransaction(1) name: unnamed; blockState: STARTED; state: INPROGRESS, xid/subid/cid: 0/1/0
2021-08-31 18:40:28.201 UTC [358] DEBUG:  shmem_exit(0): 1 before_shmem_exit callbacks to make
2021-08-31 18:40:28.201 UTC [358] DEBUG:  shmem_exit(0): 6 on_shmem_exit callbacks to make
2021-08-31 18:40:28.201 UTC [358] DEBUG:  proc_exit(0): 3 callbacks to make
2021-08-31 18:40:28.201 UTC [358] DEBUG:  exit(0)
2021-08-31 18:40:28.201 UTC [358] DEBUG:  shmem_exit(-1): 0 before_shmem_exit callbacks to make
2021-08-31 18:40:28.201 UTC [358] DEBUG:  shmem_exit(-1): 0 on_shmem_exit callbacks to make
2021-08-31 18:40:28.201 UTC [358] DEBUG:  proc_exit(-1): 0 callbacks to make

Expected behavior
DROP ROLE IF EXISTS ... skip not error out if the role does not exist and role_protection is enabled.
System information

OS: UBI 8
Version of supabase: 1.1.0
Version of Postgres 12.7 (hits other versions though)

@bradnicholson Thanks for the great bug report! I've submitted a fix on https://github.com/supabase/supautils/pull/12.


clangd only indexed opened file

My project can't generate compile_commands.json file, so I create a compile_flags.txt, the contents like this:
-Wall
-Wextra
-std=c11
-Wno-int-to-pointer-cast
-Wno-pointer-to-int-cast
--target=x86_64-w64-mingw
-x
c
-std=c11
-D__GNUC__
-I......
When opened vscode, clangd only indexed opened .c file, I can't go to defintion.
Windows 10 + Vscode
clangd -11.0.0

project wide indexing doesn't work with compile_flags.txt as it doesn't
contain file names. unfortunately you need a compile_commands.json if you
want a full index.
On Fri, Apr 17, 2020 at 12:19 PM maosuyun2009<EMAIL_ADDRESS>wrote:

My project can't generate compile_commands.json file, so I create a
compile_flags.txt, the contents like this:
-Wall
-Wextra
-std=c11
-Wno-int-to-pointer-cast
-Wno-pointer-to-int-cast
--target=x86_64-w64-mingw
-x
c
-std=c11
-D__GNUC__
-I......
When opened vscode, clangd only indexed opened .c file, I can't go to
defintion.
Windows 10 + Vscode
clangd -11.0.0
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/clangd/clangd/issues/340, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAG3EE4KMAZNUZMKI6DIIHTRNANIZANCNFSM4MKS2I6Q
.

Wondering about making the fixed compilation db (compile_flags.txt) support enumerating files - scan the FS and report all likely extensions found.
Negative side effects? If someone put compile_flags.txt in their homedir they're in for a nasty surprise :-\ @kadircet think this is a bad idea?

Only scan under the project root passed from LSP ?
I guess that must be what vscode-cpptools does. IIRC they do discover files without a "project file".
e.g. if there's no compilation database, find all files under rootUri which look like they could be compiled as a TU
	/**
	 * The rootUri of the workspace. Is null if no
	 * folder is open. If both `rootPath` and `rootUri` are set
	 * `rootUri` wins.
	 */
	rootUri: DocumentUri | null;

My project can't generate compile_commands.json file, so I create a compile_flags.txt, the contents like this:

Just curious: what build system do you use? You might be able to use Bear to generate compile_commands.json.

@puremourning clangd doesn't rely on the LSP project root, but infers one from the source file. The project is mostly closely tied to compile flags, and to the index - it seems important that these are consistent when you open the same file. vscode-cpptools only supports VSCode that has something of an IDE-like project concept - is it fair to say that vim plugins are mostly guessing?
Maybe there are ways we can safely use it though, like warning the user that there's no compile info in/above the project root, or offering to create compile_flags.txt there.

is it fair to say that vim plugins are mostly guessing?

kinda. in the case of YCM we have the .ycm_extra_conf.py which is placed in the project root, and we also have a way for users to specify what the root should be. I guess what I was thinking is that if you have nothing better than the rootUri then it would be better than the user's home dir. But I guess I see your problem; if you find a compile_flags.txt, you're gonna have a hard time to know if you shouldn't use it for the project root.

@kirillbobyrev I use IAR IDE

Negative side effects? If someone put compile_flags.txt in their homedir they're in for a nasty surprise :-\

IIRC this was the reason we didn't go for it. And also figuring out which files to keep. An extension based approach is likely to yield some false positives/negatives(for example .m could mean objc or matlab :D), should we include cuda files, etc. But I suppose this one can be mitigated with some clever but expensive heuristics that perform some disk IO. The former is harder to mitigate though, as users can have a catch-all compile command in any parent directory not just $HOME.

using compile_commands.json, but still jump to .h file for declaration, cannot jump to .c file for definition. only when .c file is open once, jumping works find.

using compile_commands.json, but still jump to .h file for declaration, cannot jump to .c file for definition. only when .c file is open once, jumping works find.

The usual culprits are:

clangd is not finding your compile_commands.json
the .c file does not have an entry in the compile_commands.json

It's helpful to look at the clangd logs to understand what clangd is doing, including whether it found the compile_commands.json. If you're having trouble figuring it out, please feel free to share the logs (preferably in a new issue).


throttler: Reset the "replica under increase test" when we leave the …

…increase state.
Before this fix, the following sequence was not possible:

increase by replica1
decrease or emergency by replica2
increase by replica2

That was because the module was still locked in to "replica1" and therefore only "replica1" could trigger the next increase.
@alainjobart

LGTM


Pipeline failed specifying jointcaller with freebayes

I recently attempted to run a pipeline when specifying joint-calling with freebayes and encountered an error.  I think the problem is that only one samples bam/vcf is being passed to bcbio-variation-recall.
I'm using bcbio_nextgen.py version 0.9.2
Template file:
# Template for whole genome Illumina variant calling with FreeBayes
# This is a GATK-free pipeline without post-alignment BAM pre-processing
# (recalibration and realignment)
---
details:
  - analysis: variant2
    genome_build: hg38
    algorithm:
      aligner: bwa
      mark_duplicates: true
      recalibrate: false
      realign: false
      variantcaller: freebayes
      effects: false
      tools_off:
         - gemini
      jointcaller: freebayes-joint

The output to the console containing the error is as follows:
[2015-09-04T06:27Z] Resource requests: bamtools, bcbio-variation-recall, bcbio_variation, fastqc, gatk, gemini, qsignature, samtools; memory: 2.00, 2.00, 0.21, 2.00, 0.29, 2.00, 0.17, 2.00; cores: 16, 16, 1, 16, 1, 16, 1, 16
[2015-09-04T06:27Z] Configuring 1 jobs to run, using 12 cores each with 24.1g of memory reserved for each job
[2015-09-04T06:27Z] Timing: joint squaring off/backfilling
[2015-09-04T06:27Z] multiprocessing: square_batch_region
[2015-09-04T06:27Z] ['bcbio-variation-recall', 'square', '-Xms750m', '-Xmx5460m', '-XX:+UseSerialGC', '-c', 12, '-r', 'chr1:1-16086892', '--caller', 'freebayes', '/xxx/desc/work/joint/freebayes-joint/sample1-joint/chr1/sample1-joint-chr1_0_16086892.vcf.gz', '/xxx//bcbio/genomes/Hsapiens/hg38/seq/hg38.fa', '/xxx/desc/work/joint/freebayes-joint/sample1-joint/chr1/sample1-joint-chr1_0_16086892.vcf-inputs.txt'] in region: chr1:1-16086892
[2015-09-04T06:27Z] 2015-09-04 07:27:33 XXXX INFO [bcbio.run.itx] - ***** WARNING: File stdin has inconsistent naming convention for record:
[2015-09-04T06:27Z] 2015-09-04 07:27:34 XXXX INFO [bcbio.run.itx] - HLA-A*01:01:01:01    0   3503
[2015-09-04T06:27Z] 2015-09-04 07:27:34 XXXX INFO [bcbio.run.itx] -
[2015-09-04T06:27Z] 2015-09-04 07:27:34 XXXX INFO [bcbio.run.itx] - ***** WARNING: File stdin has inconsistent naming convention for record:
[2015-09-04T06:27Z] 2015-09-04 07:27:34 XXXX INFO [bcbio.run.itx] - HLA-A*01:01:01:01    0   3503
[2015-09-04T06:27Z] 2015-09-04 07:27:34 XXXX INFO [bcbio.run.itx] -
[2015-09-04T06:27Z] 2015-09-04 07:27:34 XXXX INFO [bcbio.run.itx] - Error: Only a single file was specified. Nothing to combine, exiting.
[2015-09-04T06:27Z] 2015-09-04 07:27:34 XXXX ERROR [bcbio.run.itx] -
[2015-09-04T06:27Z] java.lang.Exception: Shell command failed: bedtools multiinter -i /xxx/desc/work/joint/freebayes-joint/sample1-joint/chr1/merge/sample1/sample1-qprep-passonly-sample1-chr1_1_16086892-splitpoints.bed | awk -F $'\t' '{OFS=FS} $4 >= 1 {print $1,$2,$3}' > /xxx/desc/work/joint/freebayes-joint/sample1-joint/chr1/merge/split/chr1_1_16086892/txtmp8046852311729447767/sample1-qprep-passonly-combo-1-splitpoints.bed
[2015-09-04T06:27Z]                      Error: Only a single file was specified. Nothing to combine, exiting.
[2015-09-04T06:27Z]                           bcbio.run.itx/check-run      itx.clj: 168
[2015-09-04T06:27Z] bcbio.variation.recall.split/group-breakpoints/fn    split.clj:  78
[2015-09-04T06:27Z]    bcbio.variation.recall.split/group-breakpoints    split.clj:  78
[2015-09-04T06:27Z]       bcbio.variation.recall.split/group-pregions    split.clj:  89
[2015-09-04T06:27Z]       bcbio.variation.recall.merge/prep-by-region    merge.clj: 136
[2015-09-04T06:27Z]        bcbio.variation.recall.square/combine-vcfs   square.clj: 278
[2015-09-04T06:27Z]               bcbio.variation.recall.square/-main   square.clj: 328
[2015-09-04T06:27Z]                       clojure.lang.RestFn.applyTo  RestFn.java: 137
[2015-09-04T06:27Z]                                clojure.core/apply     core.clj: 624
[2015-09-04T06:27Z]                 bcbio.variation.recall.main/-main     main.clj:  33
[2015-09-04T06:27Z]                       clojure.lang.RestFn.applyTo  RestFn.java: 137
[2015-09-04T06:27Z]                  bcbio.variation.recall.main.main             :
...

The above command refers to a file (containing bam and vcf inputs):
 '/xxx/desc/work/joint/freebayes-joint/sample1-joint/chr1/sample1-joint-chr1_0_16086892.vcf-inputs.txt'

which has the following contents:
/xxx/desc/work/freebayes/sample1.vcf.gz
/xxx/desc/work/align/sample1/4_2015-09-03_desc-sort.bam

This pipeline has been specified to run with six samples.

Dan;
Sorry about the issue, it looks lke you're working faster than we can implement things. We haven't yet tested and validated FreeBayes joint calling with hg38 and it looks to be having problems on some of the differently named HLA alleles.
Practically if you have six samples you're best running these in a single batch, rather than using joint calling. The joint approach is more useful with too many samples to batch together. If you remove jointcaller: freebayes-joint it will take that approach and should work cleanly. Hope this helps.

Thanks for the feedback. Apologies for all the bug reports :-). I'll take that approach instead. However, when running without the jointcaller option (which I tried previously) I only obtained a VCF for each sample rather than a VCF with all samples (I think)? I was under the impression that this option is required to obtain a single VCF with all samples?

Dan;
Sorry for the confusion. You need to specify samples to run together with the batch parameter in metadata:
https://bcbio-nextgen.readthedocs.org/en/latest/contents/configuration.html#sample-information
That is required for both pooled (the standard) and joint calling, so that bcbio knows what samples in your input should be called at the same time.
Let us know if we can improve the documentation on this -- sorry again for the confusion.

Great - thanks again!

Is possible to have different tumor sample (from different patients) on the same batch?
Thank!
Sent from my iPhone

On Sep 4, 2015, at 5:47 AM, Brad Chapman<EMAIL_ADDRESS>wrote:
Dan;
Sorry for the confusion. You need to specify samples to run together with the batch parameter in metadata:
https://bcbio-nextgen.readthedocs.org/en/latest/contents/configuration.html#sample-information
That is required for both pooled (the standard) and joint calling, so that bcbio knows what samples in your input should be called at the same time.
Let us know if we can improve the documentation on this -- sorry again for the confusion.
—
Reply to this email directly or view it on GitHub.

Not in a tumor/normal setup. We either support tumor/normal, tumor-only, or population (called in a batch) variant calling. Practically, callers don't offer options beyond these choices so we need to stick with those. If you want to implement custom filtering based on patient populations, you'd either call in tumor/normal pairs then combine results afterwards to find shared variants, or call in a population and do your own post-filtering based on the normals in the population. Hope this helps.

Thanks this make perfect sense! I was just confuse from the previous answered and I had the impression that may be an option to get around this in bcbio!
again thanks!

On Sep 4, 2015, at 9:31 AM, Brad Chapman<EMAIL_ADDRESS>wrote:
Not in a tumor/normal setup. We either support tumor/normal, tumor-only, or population (called in a batch) variant calling. Practically, callers don't offer options beyond these choices so we need to stick with those. If you want to implement custom filtering based on patient populations, you'd either call in tumor/normal pairs then combine results afterwards to find shared variants, or call in a population and do your own post-filtering based on the normals in the population. Hope this helps.
—
Reply to this email directly or view it on GitHub https://github.com/chapmanb/bcbio-nextgen/issues/998#issuecomment-137738791.

Which joint caller can/should be used for paired tumor/normal samples? Does this have to match the variant caller option? If ensemble calling is chosen, would that be done with the joint caller if a joint caller is given?
Thanks!

For tumor/normal calling do not specify a jointcaller. This is only used for large population germline calling where it's impractical to call samples together.

But ensemble calling is ok?

Sorry I'm not sure I understand your question, but ensemble calling will not work with jointcalling, but does work with the standard tumor/normal calling.

Thanks!

Closing this since it seems all questions were addressed.
Feel free to re-open if there are further issues.
thanks a lot to everybody.


Timeline view is still not right

You may notice how the timeline bar breaks after the first incident.

Closed in 0e8899e.


Eslint Integration

@helio-frota @lholmquist  Maybe we should integrate eslint with this project for a more consistent code style. I have never set up eslint with TypeScript but I've seen other repos do it.
I also did find this GitHub repo https://github.com/dustinspecker/awesome-eslint#configs that lists eslint configs from big companies that we can use as a guide if we want

@alexalikiotis sounds good :+1:


functional test cases

beforeTest() is commented because the test is for Invalid NoteId. So we
don`t need to call beforeTest to get note id
On Fri, Oct 19, 2018 at 5:05 PM manzarul Haque<EMAIL_ADDRESS>wrote:

@manzarul commented on this pull request.
In
sunbird_service_api_test/src/test/java/org/sunbird/integration/test/user/notes/DeleteUserNoteTest.java
https://github.com/project-sunbird/sunbird-functional-tests/pull/120#discussion_r226616322
:

@@ -80,7 +80,7 @@ public void testDeleteUserNoteSuccess(
@CitrusTest
public void testDeleteUserNoteFailureWithInvalidNoteId() {
getTestCase().setName(TEST_DELETE_USER_NOTE_FAILURE_WITH_INVALID_NOTEID);

beforeTest();

//beforeTest();

why beforeTest(); is commented.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/project-sunbird/sunbird-functional-tests/pull/120#pullrequestreview-166484005,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AomXLrsqPaNaEVInPOPGVaUjdyh-vlr0ks5umbj9gaJpZM4XuT4W
.


Updated permissions on shared log directories.

… perissions changes work when multiple components are installed on a single host (Zookeeper, Broker).  Correct many yaml linting issues.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Changes:

Updated permissions on shared log directories for instances when multiple components are installed on the same host.  Group members will now have full access.

Added new molecule scenario to confirm the changes take affect: sharedhost-plaintext-rhel

Corrected numerous yaml linting issues.

Fixes # (issue)
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Created a new molecule scenario: sharedhost-plaintext-rhel
Test Configuration:
The test does the following:

Adds a new Zookeeper user to the environment
Adds the new Zookeeper user to the logs directory
Restarts Zookeeper and confirms it starts correctly
Restarts the Broker and confirms it starts correctly

This validates that the permissions are open enough that anyone in the confluent group can access the shared log directory.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[ ] Any dependent changes have been merged and published in downstream modules

Closing for PR 406.


Do not mutate types

Just look at this report part:

Stryker config

module.exports = function(config){
  config.set({
        mutate: ['src/**/*.ts'],
        mutator: 'typescript',
        packageManager: 'npm',
        reporters: ['html', 'progress', 'event-recorder'],
        testRunner: 'jest',
        coverageAnalysis: 'off',
    });
}

Stryker environment

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
Add stryker.log
stryker.log

I don't think it is a bug. Since you are using constants in interface, it is like you would make class
class sortableHeader {
   sortable: true
}

so it is normal it will be mutated to false.
If you don't want it to be mutated, use .d.ts files. Otherwise i think it is correct to mutate it :/

I don't think so. Such things will not compile at all if I'll have some implementations for this interfaces

Thanks for bringing this to our attention! This is something we should fix in my opinion.

Although I agree with the sentiment, wouldn't the better solution be to mark the mutant as CompileError?
If you have an interface with a literal value. It should be either tested, or throw a compile error. That way you know the interface is actually being used correctly.
The TypeScript transpiler plugin reports compile errors, but only if they happen in the same file as mutation. This is done for performance reasons. WIth the new architecture of using mutation switches (still no progress on that yet) we probably will support a TypeCheckPlugin type. I would suggest that the TypeChecker plugin will have multiple settings so you can tune performance and correctness.
If people here don't agree, I would be happy to review & merge the PR of @kmdrGroch

@nicojs I think this PR can be a good temporary workaround for now, because, as you say, mutation switches are only a plans now.

I also ran into a similar error with mutations in function overload declarations:

I think this PR can be a good temporary workaround for now, because, as you say, mutation switches are only a plans now.

Agreed. It might be changed in the future, but for now, let's merge this in. Thanks for the feedback 👍  And thanks to @kmdrGroch for implementing


az deploy failed

Describe the bug
I want to re-deploy my Azure functions app, but I met these error when I deploy.

Related command
az webapp deploy --resource-group {groupName}--name {name} --src-path dist.zip --type zip --slot second --debug
ref: https://learn.microsoft.com/en-us/azure/app-service/deploy-run-package
Errors

Issue script & Debug output

Expected behavior
could deploy right
Environment Summary

Additional context
No response

Thank you for opening this issue, we will look into it.

similar issue here


feat: allow any network to be used in Treasuries

Summary
Now any network should be possible to be used in Treasuries on onchain spaces.
Depends on: https://github.com/snapshot-labs/sx-monorepo/pull/946
Closes: https://github.com/snapshot-labs/sx-monorepo/issues/857
How to test

Go to SX space settings.
Create treasuries on some non-SX supported network (Base for example).
It shows up in treasuries.

Are we planning another refactoring to rename network to chainId in relevant places ? We currently have something like
:chain-id="treasury.network"

which are not straightforward

Yeah, I'd like to refactor it at some point.

Looks good, there is just these 2 weird networks that appear (it doesn't appear on snapshot.org):


Listing templates fails with a ValueError if there are no templates

I tried listing templates before adding any, to see if there were any built-in ones, but got the following error:
=> llm templates list
Traceback (most recent call last):
  File "/Users/achabot/.local/bin/llm", line 8, in <module>
    sys.exit(cli())
  File "/Users/achabot/.local/pipx/venvs/llm/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/Users/achabot/.local/pipx/venvs/llm/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/Users/achabot/.local/pipx/venvs/llm/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/achabot/.local/pipx/venvs/llm/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/achabot/.local/pipx/venvs/llm/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/achabot/.local/pipx/venvs/llm/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/Users/achabot/.local/pipx/venvs/llm/lib/python3.10/site-packages/llm/cli.py", line 303, in templates_list
    max_name_len = max(len(p[0]) for p in pairs)
ValueError: max() arg is an empty sequence

The templates directory is empty:
=> llm templates path
/Users/achabot/Library/Application Support/io.datasette.llm/templates
=> ls /Users/achabot/Library/Application\ Support/io.datasette.llm/templates/

This was fixed in:

https://github.com/simonw/llm/pull/47


Clean console errors in All Drops, Drop managers and Create Drops pages

Description
Clean up console warnings/errors in All Drops, Drop managers and Create Drops pages
Some warnings fixes were
Drops pages:

Create drops:

Fixes #142 and #141
How to test
Show steps to replicate and test the feature/fixes in this PR

check out locally, and go to http://localhost:3000/drops
check for console errors
go to http://localhost:3000/drop/token/new and check
go to http://localhost:3000/drop/nft/new and check

Screenshots/Screen Recording of Implementation

Looks good to me - can we also remove unnecessary console logs?


Use lol_alloc instead of wee_alloc in example

wee_alloc is unmaintained and has a memory leak

Hi, I haven't touched rust for a long time and am not familiar with it. If you think everything is okay, you can submit a PR. If there are no objections, I will merge it. Thanks.


Added getOrCreateIndex function

Implements the #4. Please do not merge yet due missing documentation.

@qdequele Yes I am, are you asking about the number of tabs? If yes I can see where you are coming from, there is a file with 1 tab instead of one, I will fix it. The Swiftlint linter does not detect this I think.

Thank you all!


Adding more size options?

Currently, it has small, normal, and large. What is the best way to have more options?

You mean adding xs and xl? Unlikely, I think such decision would add high maintenance cost and has from little to no practical value, because AtlantaFX for now is targets desktop only and here is an example from MD spec:

As much as I remember many Web component frameworks also support 3 sizes only. E.g. iView or Prime.
Overall, I think improving current sizes to fit interface font more smoothly and maybe adding compact theme flavor in the future is better time investment, but adding examples to the docs to guide user how to change component size via custom CSS might be a good idea.

An extra to the question I have made? Can we switch between sizes (small, normal, large) in one shot (such as switching pseudo class for .root) .
I am not so sure. Is it a good idea to add size choices here

An extra to the question. I am not so sure but is it a good idea to make it possible and easy to switch sizes in one shot (like   themization, switching .root pseudo-class). I do not see it in docs?

Sadly, JavaFX only partially implements CSS 2.1 spec and custom properties is a CSS 4 module. You can define custom variables at any level, but variable type is restricted. It can be only color type variable. See CSS ref or docs for looked-up colors. There's no way to manipulate controls size at runtime via variables except changing the font size at .root level.


chore: bump git-sync for security fixes

note - this commit is not a cherry pick. The main branch has moved forward a major version which contains breaking changes. This commit upgrades the patch version on the release branch to avoid breaking changes.

/assign @nan-yu


transfers: "credit only" destination

From https://github.com/moov-io/paygate/issues/417 a transfer's destination should support being credit only. Debiting from a customer requires that customer is validated.

We have this with ReceiveOnly as a Customer status -- https://github.com/moov-io/customers#customer-approval


[BUG] New Azure SDK doesn't allow creating Event Grid's system topic or subscription

Library name and version
Azure.ResourceManager.EventGrid 1.1.0-beta.2
Describe the bug
The old SDK was deprecated, and now we have a new SDK to use.
This new SDK doesn't have Create methods for System Topic and Event subscriptions.
Using "Update" method doesn't allow creating missing resources because SDK is using "Patch" and not "Put" http verb and Azure WebAPI returns an error.
Expected behavior
Whether we should have a new method CreateOrUpdate or we should support creation via Update method. This can be done by using Put verb instead of Patch. For example, calling "UpdateAsync" on RoleAssignmentResource creates the missing resource.
Actual behavior
Calling Update methods throw the error.
Reproduction Steps

Create Arm Client
Use Arm client to create event subscription resource like this: (replace ids with actual values and patch request as well)

await armClient.GetSystemTopicEventSubscriptionResource(SystemTopicEventSubscriptionResource.CreateResourceIdentifier("id", "id", "id", "id")).UpdateAsync(WaitUntil.Completed, new EventGridSubscriptionPatch());
Environment
No response

Oh... I didn't see you can create new item from the collection. You can do things like this:
SystemTopicData data = new SystemTopicData(new AzureLocation("global"))
{
Source = new ResourceIdentifier(scope),
TopicType = "Microsoft.Communication.CommunicationServices",
};
ArmOperation lro = await systemTopics.CreateOrUpdateAsync(WaitUntil.Completed, systemTopicName, data);


Separated "Gnorm" phase?

Hello, Thank you for your greate work.
I have a question on the training code.
I can see that "Gmain" and "Gnorm" phase are separated.
Isn't normal map can be generated during "Gmain"  phase?
Is there a reason you have separated normal and texture generation?

The normal map can also be generated during "Gmain" phase. We separated normal and texture generation during training to reduce the GPU memory cost.


component test

Description
I wrote an enzyme test on the CategoryDelete page on the admin panel
All test passed
Screenshots

Original
Updated

** original screenshot **
** updated screenshot **

Checklist

[✔] 🔽 My branch is up-to-date with "development" branch
[✔] ✅ All tests passed locally
[✔] ✨ My changes working with up-to-date front-end and back-end part locally, like a charm
[✔] 🔗 Link pull request to issue

CI errors should be fixed


SQL Still problematic

Description
Running just a single statement in in DBeaver is problematic.
Even though:
SQL Processing Statement delimiter is ;
Ignore native delimiter is unchecked
Blank line is statement delimiter is set to Never
Remove trailing query delimiter is unchecked
placing my cursor instaide of a complete statement and pressing "Execute SQL Query" will occationally try to run every statement in the SQL Editor with disasterous results.
I had thought that switching:
Blank line is statement delimiter: from the default of Smart, to Never had fixed the issue, but apparently all doing that accomplished was to reduce the occurance not eliminate it entirely.
The only way to ensure that only a single statement is run is to select the entire statement.
This is a marked regression from the behavior of previous versions,
hopefully this can be corrected  soon.
DBeaver Version
Community Edition 24.0.4
Operating System
Windows 10
Database and driver
PostgreSQL 16
Steps to reproduce
Have an SQL Editor window with many sql statements
place the cursor (symbolized by {c} in the example below) inside a single statement
press the orange arrow (Execute SQL Query)
sometimes it will run the specified query
other times it will run all queries in that editor
ex:
select * from foo;
select yaba, daba, doo {c} from flintstones;
insert into baz set fld1 = 'something' where fld2 > 10;
delete from important_table where entered < '2023-01-01';
since the cursor {c} is in the select from flinstones statement that's the only statement that should be run.
Additional context
No response

I can't reproduce your issue on the provided query script neither with Blank line is statement delimiter set to Smart, nor to Never on DBeaver 24.0.4.

Could you open Outline view and show it to me?
It can be opened here by clicking this button

Is this what you wanted?

@E1izabeth I often have multiple statements with no black spaces between them, see example below.
I expect Dbeaver to only use the delimiters to, well, delimite commands.  If I place my cursor within the third line, I expect that only the third line will be executed.
Dbeaver should, and used to, only run the SQL statement that my cursor was within.
How do I get back to that behavior?
thanks,
rik.
For example:

-- create tables
create table rxnorm.rxnatomarchive_20240205 as table rxnorm.rxnatomarchive;
create table rxnorm.rxnconso_20240205 as table rxnorm.rxnconso;
create table rxnorm.rxncui_20240205 as table rxnorm.rxncui;
-- create the indicies
create index if not exists x_rxnconso_str on rxnorm.rxnconso (str);
create index if not exists x_rxnconso_rxcui on rxnorm.rxnconso (rxcui);
create index if not exists x_rxnatomarchive_rxcui on rxnorm.rxnatomarchive (rxcui);
create index if not exists x_rxnatomarchive_merged_to on rxnorm.rxnatomarchive (merged_to_rxcui);
-- drop tables
drop table if exists rxnorm.rxnatomarchive_20240102;
drop table if exists rxnorm.rxnconso_20240102;
drop table if exists rxnorm.rxncui_20240102;
drop table if exists rxnorm.rxncuichanges_20240102;

Or:
-- list roles
select usename as username,

  case
     when usesuper then
	   cast('superuser' as pg_catalog.text)
     else
	    cast('No user' AS pg_catalog.text)
  end user_attribute

from pg_catalog.pg_user
order by username asc;

Thank you for more examples. All of them works right for me on version 24.0.4. We have a bug in 24.0.3, but now it's fixed. I cannot reproduce the behavior you're describing.

You can change this setting to Always. It should help

This seems pretty clearly related to the bug I reported here.  I'm attaching an additional screenshot in hopes of clarifying that "Blank line as a statement delimiter" has no effect under certain conditions.  Also, the outline view (which I just learned about, thanks to this post) even shows that the parser doesn't correctly parse these as separate statements.

https://github.com/dbeaver/dbeaver/issues/30136#issuecomment-2104266206

@philosaur Thank you for the suggestion, that is reproduced 100% of the time with your example