Blank image is created from svg generated in angular

I have an Angular 7 application which generates SVG graphs based on dynamic data loaded from a backend. I want to include this generated SVG graph in PDF I am generating and hoped to do so by converting the SVG graph to an image using this library.
However, all I get is a blank/white image with the correct aspect ratio.
I have no idea where to start debugging this. I could understand if some of the colours would not match due to missing css styles, but I would have expected to at least see the drawn elements in black. I copied the created DOM element and attached it to this post. Might the angular-generated comments and/or extra fields be an issue? Or is my use of a viewbox the cause?
The graph shows correctly as part of the angular applilcataion.
I'd appreciate any feedback what I need to change.
This is the source  element:
svg-graph.zip
This is the code I'm using to generate the URI:
    svg.svgAsPngUri(document.getElementById('pressure'), {}, (uri) => {
      console.log('pressure uri', uri);
    });

This is the generated URI: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAUAAAABjCAYAAADq39mGAAAAkklEQVR4nO3BMQEAAADCoPVPbQ0PoAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAgCMD73IAAV8svh8AAAAASUVORK5CYII=

What's the output of svgAsDataUri? That will show you exactly what SVG code this library is using to generate the PNG, and should be more debuggable than the PNG, since you can put the data URI in its own tab and inspect the DOM.

I had to pass the result through DomSanitizer.bypassSecurityTrustResourceUrl() in order for it to not log a warning in my angular app. Optically, the result is the same (a white rectangle)
Having a quick look at the decoded content, one thing that I noticed is that apparently the negative offsets to my viewBox have been removed. Also, all x-ccordinates have been shifted by 10 and the viewBox is 10 wider. All the styles that I had in my angular.css files seem to have ended up in the result.
If I adjust the viewBox offset again, the image looks as it should. Is this a bug in the library? Or is that use case just not supported? I'm attaching both the base64 encoded and decoded output.
.
data-uri-base64.txt
decoded-svg.xml.txt

This lib does do some viewbox handling, so it's possibly a bug. I'd be happy to look at a PR that improves the situation. Specifically, take a look at what the viewbox attribute is set to on the cloned DOM element as well as the getDimension function: https://github.com/exupero/saveSvgAsPng/blob/ccfd5bbf5f5dff9548047aa6d7c7651d0960d897/src/saveSvgAsPng.js#L246 https://github.com/exupero/saveSvgAsPng/blob/ccfd5bbf5f5dff9548047aa6d7c7651d0960d897/src/saveSvgAsPng.js#L46-L54

I think the cause for my issue is the following part of the code, where the parameters leftand top are defined which are then used in the first code snipped you referenced to create the viewBox:
 out$.prepareSvg = (el, options, done) => {
    requireDomNode(el);
    const {
      left = 0, // --> always hard coded to 0, should probably be taken from source viewBox
      top = 0, // --> always hard coded to 0, should probably be taken from source viewBox
      width: w,
      height: h,
      scale = 1,
      responsive = false,
} = options || {};

Thanks, I'll need to find some time to look at the library, to better understand how it works and try to see if I can come up with a PR (not sure if I'm up to it :-)

I've tried debugging the library as part of my angular app in the hopes of better understanding what happens and what a fix might look like, but sadly have been unable to get the breakpoints to trigger. This seems to be way beyond my javascript abilities to handle. Sorry, but I don't think I'll be able to provide a pull request with a fix. If anyone else sees how to solve it, I would of course greatly appreciate it.


Module object has no such attribute version

Hi,
I am building the opencv package as described in the tutorial.
I have tried the prebuild lib, I have built it myself and I run Amazon AMI 2 and built it manually and it still gives me this error:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'module' object has no attribute '__version__'

This happens when I run the Lambda function or just import the module in the python shell and type in cv2.__version__
Could you help me with this issue? Should I change the AWS image to Amazon AMI 1?

Hi,
when I built it on the classic Amazon AMI image, I was able to run the cv2 library on lambda.
Thank you for your attention,
Regards.


make a proper damn scrollbar on list

I didn't log that I was doing this but it's done. Settable width, normal color and bar color. Inherits background from underneath, scrolling sense area covers the bar as expected.

oops forgot one detail on this - setting the minimum size on the grabber.

facbd668229762d5a86d372c5396ec26f7671129 completes it


ORC-961: [C++] expose related metrics of the reader

What changes were proposed in this pull request?
This patch keeps track of the time spent and the number of calls to each module. The current metrics mainly include the decompression time and number of calls, decoding time and number of calls and total elapsed time.
Why are the changes needed?
It exposes the relevant metrics of the reader, so that the user can visually see the metrics of each module which includes decompression, decoding.
How was this patch tested?
The orc-scan tool with the -m parameter can output relevant metrics.

I have requested @stiga-huang for review because he has opened the JIRA.

FYI, this PR still fails on all MacOSes, @coderex2522 .

fixed.

Thanks for adding these metrics! Can we also expose the stats of SargsApplier?
https://github.com/apache/orc/blob/afc671d214020116cb5d6cde8c3b2dfc945295c5/c%2B%2B/src/sargs/SargsApplier.hh#L122-L123

Thanks for adding these metrics! Can we also expose the stats of SargsApplier?
https://github.com/apache/orc/blob/afc671d214020116cb5d6cde8c3b2dfc945295c5/c%2B%2B/src/sargs/SargsApplier.hh#L122-L123

Sure, I add the SelectedRowGroupCount and EvaluatedRowGroupCount to expose the PPD metrics.

Gentle ping, @coderex2522 .

Thank you, @coderex2522 and @wgtmac .
I have three questions as the final pieces:

Backward-compatibility: Apache ORC C++ API is used in the downstream. So, although this PR looks good, it would be great to make it sure that we don't break the backward compatibility once more. I believe the default value of new parameters could reduce the pain.
The ability to disable this metrics. According to the code, we can disable this feature by hand over NULL pointer? Could you double-confirm it? Could you add a test coverage to confirm that this case is possible? It will be helpful to prevent accidentally segfault in the future.
Last question is about the target version. For this PR, if you want, you can backport this to branch-1.8 for Apache ORC 1.8.0. Which one do you prefer v1.9.0 (Next year) or v1.8.0 (This year).

Good suggestion @dongjoon-hyun.
We should be able to set nullptr to ReaderMetrics to disable it at run time. BTW, we can totally disable it at compile time if we have something like this: https://github.com/apache/impala/blob/master/be/src/util/runtime-profile-counters.h#L53

Thank you,  @wgtmac

Thank you, @coderex2522 and @wgtmac .
I have three questions as the final pieces:

Backward-compatibility: Apache ORC C++ API is used in the downstream. So, although this PR looks good, it would be great to make it sure that we don't break the backward compatibility once more. I believe the default value of new parameters could reduce the pain.
The ability to disable this metrics. According to the code, we can disable this feature by hand over NULL pointer? Could you double-confirm it? Could you add a test coverage to confirm that this case is possible? It will be helpful to prevent accidentally segfault in the future.
Last question is about the target version. For this PR, if you want, you can backport this to branch-1.8 for Apache ORC 1.8.0. Which one do you prefer v1.9.0 (Next year) or v1.8.0 (This year).

External projects will depend on the api interface in the include directory and need to maintain compatibility, while the header files in the src directory will not be dependent on external projects, so I prefer not to add the default value.
I will add the new test to coverage the disable metrics case.
The target version v1.9.0 is fine, I have no requirement to support in branch-1.8.

It seems like this feature is enabled by default and will bring extra overhead to the decoding performance, as I tested via orc-scan. Could this feature be disabled by default?

Thank you for suggestion, @XinyuZeng . Yes, it was also discussed before https://github.com/apache/orc/pull/1158#pullrequestreview-1031811661 .
Could you open a new official JIRA for that? We can add that configuration for that at Apache ORC 1.9.0 too.

BTW, please include the reproducible step for the following observation, @XinyuZeng .

reading time increased by more than 2x with orc-scan on my machine.

@dongjoon-hyun I created jira-issue 1232 for this problem. Also, even the metrics is disabled by setting nullptr, there is still some cost of initing the AutoStopWatch object and destructing it. The following perf flamegraph shows the cost.

Thank you for the detail, @coderex2522 . Could you make a PR to provide an opt-out way to achieve your goal?

@dongjoon-hyun I created jira-issue 1232 for this problem. Also, even the metrics is disabled by setting nullptr, there is still some cost of initing the AutoStopWatch object and destructing it. The following perf flamegraph shows the cost. Although the extra time may be trivial, it may be better to be disabled at compile time.

I am confused about why does the chrono time function call still appear in the flamegraph after disabling the metrics.

@dongjoon-hyun I created jira-issue 1232 for this problem. Also, even the metrics is disabled by setting nullptr, there is still some cost of initing the AutoStopWatch object and destructing it. The following perf flamegraph shows the cost. Although the extra time may be trivial, it may be better to be disabled at compile time.

I am confused about why does the chrono time function call still appear in the flamegraph after disabling the metrics.

The SCOPED_STOPWATCH and SCOPED_MINUS_STOPWATCH macros still create the AutoStopwatch object which has chrono members, even after we pass in null METRICS_PTR.

Since Apache ORC 1.9.0 is planned on September 2023, I believe we have enough time to remove the regression before release. Please feel free to open a PR for the improvement. Everyone can make a PR and in the worst case (if there is no volunteer to fix the regression), we can revert ORC-961 from branch-1.9 before creating 1.9.0 RC1 vote.

https://github.com/apache/orc/milestone/10

BTW, please let us know your opinions about the above approach, @wgtmac , @williamhyun , @guiyanakuang , @stiga-huang .

I submitted ORC-1232 PR in order to diable the metrics collector at compile phase. If there is no requirement for metrics collection, users do not have to turn on BUILD_CPP_ENABLE_METRICS.


bump rust from 1.56.1 to 1.57.0

Codecov Report

Merging #524 (c52a108) into main (aff2d19) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #524   +/-   ##
=======================================
  Coverage   61.13%   61.13%
=======================================
  Files          85       85
  Lines       12612    12612
=======================================
  Hits         7710     7710
  Misses       4902     4902

lgtm


Speed up unit tests

Initializing the full Spring application context in a test case is super slow. SUPER slow.

Nice af

Nice

Changes Unknown when pulling 55877dad51bcba065cb6c35a615a569f16617261 on dwarfcrank:test-speedup into ** on tdd-pingis:master**.

Actually I noticed this problem earlier but forgot to fix it.
Nice. Work.


Remove duplicate words

Avoid the possibility of duplicate words being entered into the database by removing duplicates automatically.

Thanks!


Update cocoapods repository to support Swift 2.2

Could you please update cocoapods version to be 2.2 compatible? Thanks

+1

Yes, I'll update it soon.

The new version 0.9.5 was just published on Cocoapods.
It seems that Cocoapods is approaching 1.0 release. I have not tested against the beta release. Please report bugs if any, thanks.


use vespalib::ReusableSetPool

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
@geirst please review

Lets wait with merge until we have results from multi-client perf test.


readme-update

This PR includes updates to the Qualtrics README. Please be aware that the table descriptions or links to github docs have not been included yet. These can be updated prior to release once all reviews are completed.
If this looks good to go, feel free to merge into main.

copied readme into my branch


adding wrap to url

added wrap to urls.
usage :
url(r'^$', include('suburl'), wrap=[wrap1, wrap2])

whats the test my code fails?

This is being discussed at https://code.djangoproject.com/ticket/25409. We need to make a design decision about this first before writing code. Feel free to add your thoughts to the ticket and/or mailing list discussion. Thanks!

@timgraham was a conclusion ever reached on this feature?

No, there's no activity on the ticket since 3 years ago.


Reflection: Remove vestigial Offset fields from ReflectionInfo

These are now always zero, because memory readers handle virtual address mapping.
The swift_reflection_info_t structure used by the C RemoteMirror API keeps
its offset fields because it's supposed to be a stable API, but we now assert that
the values are always zero.

@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - bc3795eb532cd995759ed00165fedc952aedbb63

@swift-ci Please test OS X

Build failed
Swift Test OS X Platform
Git Sha - bc3795eb532cd995759ed00165fedc952aedbb63

@swift-ci Please test OS X

Build failed
Swift Test OS X Platform
Git Sha - bc3795eb532cd995759ed00165fedc952aedbb63

@swift-ci Please test OS X


Network refactor: routeless

The purpose of this PR is to explore the possibility of shifting from actors to shared memory within the snarkOS network implementation. This will, in time, allow for the removal of routing logic that isn't necessary with the new model as every structure now has access to the NetworkState.
This is a work in progress. I'd consider the main structural changes to be in place, though there is still quite a bit of refactoring, optimising and cleanup to be done. I would not consider the APIs stable at this point as I plan on breaking up the newly introduced methods further.

Closing for the time being as this was purely exploratory.


Support Cloud Asset upload

Tasks for Skygear-Server

[x] Load config from env.
[x] Request for signer token
[x] Refresh signer token periodically
[x] New endpoint asset:put for new upload protocol

Tasks for SDKs

[ ] Support on iOS SDK
[x] Support on JS SDK
Support on Android SDK

Tasks for Others

[ ] Update documentation

Pending: ASSET_STORE_HOST should default to HOST if not specific explicitly.


Update columns in DynamoDB

In this order:

Id becomes TimeBucket, primary index
EventType, second index
Count
CreatedAt
UpdatedAt

redone compiles and writes ADDB


[CPX-Marketplace-Catalog] API Review

New API Review meeting has been requested.
Service Name: CPX-Marketplace-Catalog
Review Created By: Alon Han
Review Date: 11/1/2022 2:00 PM PT
PR: https://github.com/Azure/azure-rest-api-specs/pull/20621
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided
Description: Marketplace Catalog api for fetching products metadata
Detailed meeting information and documents provided can be accessed here

Meeting updated by Alon Han
Service Name: CPX-Marketplace-Catalog
Review Created By: Alon Han
Review Date: 11/1/2022 1:00 PM PT
PR: https://github.com/Azure/azure-rest-api-specs/pull/20621
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided
Description: Marketplace Catalog api for fetching products metadata
Detailed meeting information and documents provided can be accessed here

Cancelled by: Alon Han


Random failure occurs in integration test "TestBundleErrorWhenOVSRestart"

Describe the bug
The integration tests failed quite often recently because of timeout (10min). And the it is stuck at case "TestBundleErrorWhenOVSRestart"
To Reproduce
Run integration test.
Expected
All tests should pass
Actual behavior
The integration tests failed, and the failed case is "TestBundleErrorWhenOVSRestart". After dumping goroutines, one goroutine info shows like following,
sync.runtime_Semacquire(0xc000044e08)
	/usr/local/go/src/runtime/sema.go:56 +0x42
sync.(*WaitGroup).Wait(0xc000044e00)
	/usr/local/go/src/sync/waitgroup.go:130 +0x64
github.com/vmware-tanzu/antrea/test/integration/ovs.TestBundleErrorWhenOVSRestart(0xc00014c300)
	/usr/src/github.com/vmware-tanzu/antrea/test/integration/ovs/ofctrl_test.go:461 +0x624
testing.tRunner(0xc00014c300, 0x16493f0)
	/usr/local/go/src/testing/testing.go:909 +0xc9
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:960 +0x350

Versions:
Please provide the following information:

Antrea version (Docker image tag): 0.9.0+
Kubernetes version (use kubectl version). If your Kubernetes components have [different versions]

I think it's a duplicate of https://github.com/vmware-tanzu/antrea/issues/711? You can close the older issue if it is.

There should be some bug when resolving the goroutine leak issue in ofnet, which might cause the integration test failed and report a new error like,
panic: send on closed channel

goroutine 30736 [running]:
github.com/contiv/ofnet/ofctrl.(*OFSwitch).publishMessage.func1(0xc001f669c0, 0x1, 0x2cb00000000, 0x1)
	/tmp/gopath/pkg/mod/github.com/wenyingd/ofnet@v0.0.0-20200911061943-60f892dbc243/ofctrl/ofSwitch.go:463 +0x49
created by github.com/contiv/ofnet/ofctrl.(*OFSwitch).publishMessage
	/tmp/gopath/pkg/mod/github.com/wenyingd/ofnet@v0.0.0-20200911061943-60f892dbc243/ofctrl/ofSwitch.go:462 +0xfe
FAIL	github.com/vmware-tanzu/antrea/test/integration/ovs	6.924s
FAIL


update on testing...

Testing devices...
Sonoff mini - no problems
Sonoff T1 3channel - no problems
Sonoff T1/Touch - no problems
Shelly 1 (flashed with Tasmota) - no problems
Shelly 4 pro (stock firmware as you cant flash it!) - built the device handler and happilly working and reading power and energy.
NodeMCU test rig flashed with tasmota - for testing device handlers! - working fine
to do...
sonoff iFan03
Shelly 2 PM (when I get one ordered)

Glad to hear they are all working
I can add
Sonoff basic
wemos d1

ive got it working with iFan03 (all the MQTT packets passing both ways and contolling the fan speed and lights; processMQTT working properly to interpret Fanspeed but ignore everything else... needed to look at stat/x/RESULT to get fanspeed but that means I've got to check what to interpret and what to ignore!)
im just finishing a decent device handler.  Bonus...because it is Tasmota, it should work with the iFan02 as well.

You have got to get the sonoff RF bridge - takes this to a whole new level.
I can get any cheapo rf transmitter physical switch from aliexpress stick that switch anywhere and control one -> one or one->many any number of RF or non-rf devices with these physical switches they don't even have to be tasmotized or wifi or mqtt enabled because the the RF bridge can act as the MQTT hub for all non mqtt devices translating RF signals to MQTT messges to mbs-server.
i just used an rf switch to control a legacy x10 lamp that is exposed through HABridge. No new device handlers - just simple change in config in the config file

Also robross0606 has confirmed the legacy part of the bridge works with HassIO without config file

moved info to wiki


Tapping large costs for "X" From multiple mana producing objects quicker!

Context
I play Expansion // Explosion for a total cost of 2u 2R and X=20
I have 9 Treasure artifacts on the board, 4 Basic lands, and 15 Dual lands.
Problem
Because I have treasure on the board I have to tap each source individually. Each time I Sacrifice a treasure for mana I have to click it once, wait for the oddly placed color wheel to come up, and click a color. Once I get through those I have to do the same thing for 15 Dual lands. It takes an enormous amount of time to tap all of these, making it a very risk situation trying to produce all of this mana at any time during my game.
Solution
The main request here is to come up with a way that is more convenient for choosing large cost of X that is coming from multiple sources of mana producing objects. Perhaps if you click a treasure it can bring up an interface that is not the color wheel where you can quickly assign the colors for multiple treasure at a time. For Dual lands and regular lands perhaps there is a quick button labeled "X" somewhere on the screen That you can click before you quick tap all of the mana you want to be assigned for just X.

Sorry to disappoint you, but the bug tracker for MTG Arena is somewhere else, probably here: https://mtgarena.community.gl/forums/categories/52
This here is the bugtracker for one of the tracker apps, developed independently from the game.


How to not disable the outer scrollbar?

It seems that jupyter-themer disables the outermost vertical scrollbar in jupyter (in the extreme right). See below how things look when the problem is NOT present.

That bar was created inserting this code on custom.js:
.container{ width:100% !important; }
div#site{ height: 100% !important; }

I can't get it back even with jt -r (I solved it reinstalling the notebook). And this bar is very useful in hiding the menus.
Running on notebook 4.2, firefox 48, ubuntu-gnome 16.04.
Besides this, jupyter-themer is awesome!

I make some confusions when using jupyter-themer alongside another library (jupyter-themes). I am closing this issue. Sorry about that.


Named Specta types in select! and include! - Feature Request

While using named select and include bindings.ts still generate inline type instead of reference one which leads to less readable/ mockable types.
I suggest that when there is type name provided to select! or include! macro we should use it for generating specta reference type instead of inline type.

am gonna just implement this since it's not that hard and doesn't really change much

Hi i Noticed update now
My friend (who is responsible for front-end) complained that he needs to copy types for mocking and to functions or alias them outside of file. Mostly dx.
Happy to see  it done thanks.

I assume you're talking about Erudio, so I checked how you're doing tests and noticed that you're mocking rspc responses. That makes sense, but rather than pass in the types to getData manually I'd suggest using rspc's inferProcedureResult helpers. That way you wouldn't need to use the generated types for include/select, and could also be a lot more certain about the data your tests need.


Want to Linking libstdc++ and libgcc statically

Hi ,
When I run PHP, I get the following error：
[05-Nov-2018 14:21:19 PRC] PHP Warning:  PHP Startup: Unable to load dynamic library '/home/homework/php/ext/pinpoint.so' - /mnt/homework/php/bin/../../lib/gcc-3.4.5/libstdc++.so.6: version `CXXABI_1.3.1' not found (required by /home/homework/php/ext/pinpoint.so) in Unknown on line 0
I run ldd and got the following results:
ldd pinpoint.so
libboost_system.so.1.63.0 => /usr/local/lib/libboost_system.so.1.63.0 (0x00007f9456a65000)
libboost_thread.so.1.63.0 => /usr/local/lib/libboost_thread.so.1.63.0 (0x00007f9456841000)
libboost_filesystem.so.1.63.0 => /usr/local/lib/libboost_filesystem.so.1.63.0 (0x00007f945662a000)
libboost_date_time.so.1.63.0 => /usr/local/lib/libboost_date_time.so.1.63.0 (0x00007f9456416000)
libthrift-0.11.0.so => /usr/local/lib/libthrift-0.11.0.so (0x00007f94560ad000)
libstdc++.so.6 => /usr/lib64/libstdc++.so.6 (0x00007f9456c69000)
libc.so.6 => /lib64/libc.so.6 (0x00007f945587e000)

（I Can't Upgrade libstdc++. So.6 and libc.so.6 for my PHP）
I want to linking libstdc++ 、 libgcc 、libboost、libthrift statically，make their so not in ldd result.
Please tell me how to config。

@ZuLiHu
Did you copy the pinpoint.so from other environment?

@ZuLiHu
Did you copy the pinpoint.so from other environment?

My PHP reference it's own library not the system libraries。So, pinpoint.so become a php extension，pinpoint.so not reference the system libraries，its reference PHP's libstdc++.so.6 and libc.so.6 not System's libstdc++.so.6 and libc.so.6。
But I build pinpoint.so use System gcc，so,when run pinpoint.so error。

@eeliu Can you help me?

@ZuLiHu
If you want to link static library, use "./Build.sh --enable-release".
BUT, keep in mind that all libraries must support -fPIC when compiled, and only boost and thrift is supported. [This is an experiment function]
https://github.com/naver/pinpoint-c-agent/blob/a8f7c16cc783d505aa386ac77046ce193dd23747/pinpoint_php/config.m4#L26-L30
For you php , use system libraries is a solution, as pinpint.so needs them.

@ZuLiHu
hi, does your PHP application support composer classloader ?

Hi, this is a deployment problem
https://github.com/naver/pinpoint-c-agent/releases/tag/v0.2.0 provided a better solution on such scene. Hope you clone it and upgrade it. Thanks


[Add] Syndicate pAI

About the PR

This adding syndicate personal AI without any functional. That only resprite.

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl: fedKotikeD

add: Added syndicate pAI
tweak: Syndicate pAI now spawns in Nuke planet

Closes #16802

It was already in the Imperial!

i agree with faints reviews here

The author allowed to close it as they probably won’t work on it. Can ask to re-open in case


Add a new suspended workflow status phase

What would you like to be added:
Reintroduce the suspended workflow status phase
Why is this needed:
Adds a status phase that clearly describes that the workflow has been manually and explicitly suspended by a user, as opposed to waiting, which describes that the workflow is waiting for event(s) to be correlated.
Additional notes:
The suspended status phase was initialy part of the DSL, but was removed following (very valid) observations from @fjtirado, who considered that waiting could actually represent both phases.
However, following the implementation of the suspend feature in Synapse, we realized that users could not differenciate flows that were explicitly suspended from ones that were being correlated, thus the feature request.

ok, so waiting is a "natural" status, the workflow reach it as part of its execution while suspended is "forced" one, explicitly set by the user.
My only concern is that suspending a workflow should not necessarily be implemented by all implementors. I mean, I can foresee an implementation that does not provide ways to suspend workflow execution and its still a compliant one, wdyt?

ok, so waiting is a "natural" status, the workflow reach it as part of its execution while suspended is "forced" one, explicitly set by the user.

That's my understanding of it, yes.

I mean, I can foresee an implementation that does not provide ways to suspend workflow execution and its still a compliant one, wdyt?

@fjtirado Very valid point indeed. I personally don't see the requirement of enforcing such features. That status phase is IMO a nice to have in case one implements the related feature. Furthermore, adding it would allows us to exhaustively describe all the possible phases of a workflow, regardless of implemented features.

As an alternative, I think we can broadly understand waiting as waiting for something (not just events), so it will also included the state "waiting for the user to remove the workflow he temporalily stopped" and then let implementos provides "substates" or "states additional description" freely. Becuase there might be implementations that might want to differentiate between "waiting for event" or "waiting for rest response" and this will allow them to do that.

Or following a similar idea, add an additional actor field, which will include the "initiator", human or machine ;), that let the workflow to reach the current state
So in the "suspend" case, state will be waiting and actor user
In the "waiting for event" case., state will be waiting and actor event

The reason Im stuying alternative is that once we diferentiate between two ways of waiting in a standard state, more will eventually come up (not necesarily applicable to all implementations, as is the case for suspended), but I maybe wrong and we will just have those too.


Fixed copy-paste mistake in reference text.

There was a copy-paste mistake so the reference text was about number series instead of error handling.

Nice catch


helmfile: 0.137.0 -> 0.138.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/roboll/helmfile/releases.
meta.description for helmfile is: "Deploy Kubernetes Helm charts"
meta.homepage for helmfile is: "https://github.com/roboll/helmfile"
meta.changelog for helmfile is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.138.1 with grep in /nix/store/q8z81vx4b5if61f8z8zc96pkfvb1jxif-helmfile-0.138.1

directory tree listing: https://gist.github.com/af2fb3837f237fcfa4f3fe2a3fcae20d

du listing: https://gist.github.com/9c280dfbcfa60a66029f64d1b247dc87

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
helmfile

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/q8z81vx4b5if61f8z8zc96pkfvb1jxif-helmfile-0.138.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A helmfile https://github.com/r-ryantm/nixpkgs/archive/d136928c48a2b7b47451cb17f6ffdcedb1f97c8d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/q8z81vx4b5if61f8z8zc96pkfvb1jxif-helmfile-0.138.1
ls -la /nix/store/q8z81vx4b5if61f8z8zc96pkfvb1jxif-helmfile-0.138.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

helmfile

Maintainer pings
cc @pneumaticat @yurrriq @kalbasit for testing.

Thanks! FWIW I don't think I've seen an automated update for helmfile that has had any issues. Sometimes there's a regression or something upstream, but as far as packaging goes, it seems fine. In my local packages, I've had doCheck = true for the last several versions, at least. I'll plan to open a PR.


[BACKPORT][v1.3.1][IMPROVEMENT] Replace the GCC allocator in liblonghorn with a more efficient memory allocator

What's the task? Please describe
https://github.com/longhorn/longhorn/issues/4136

Test environment:
machine: AWS c5d.2xlarge
test size: 80G
v1.3.x-head longhorn-manager version: 57c20a3
Test Result:
https://ci.longhorn.io/job/private/job/longhorn-benchmark-test/16/console
Bandwidth: KiB/s
Latency: ns
(1) Replica count = 1
|   | IOPS |   | Bandwidth |   | Latency |
-- | -- | -- | -- | -- | -- | -- | --
  |   | read | write | read | write | read | write
v1.3.0 | rand | 23,368 | 15,477 | 362,232 | 162,006 | 360,537 | 320,068
  | seq | 38,820 | 27,257 | 357,754 | 164,405 | 296,046 | 319,916
v1.3.x-head | rand | 24,275 | 15,638 | 362,238 | 161,390 | 343,980 | 304,498
  | seq | 40,081 | 27,575 | 399,427 | 163,796 | 279,971 | 303,989
Improvement | rand | 3.88% | 1.04% | 0% | -0.38% | 4.59% | 4.86%
  | seq | 3.25% | 1.17% | 11.65% | -0.37% | 5.43% | 4.98%
(2) Replica count = 2
|   | IOPS |   | Bandwidth |   | Latency |
-- | -- | -- | -- | -- | -- | -- | --
  |   | read | write | read | write | read | write
v1.3.0 | rand | 22,301 | 14,398 | 724,476 | 161,991 | 397,878 | 375,128
  | seq | 36,707 | 24,767 | 503,033 | 164,410 | 395,131 | 373,400
v1.3.x-head | rand | 23,760 | 14,556 | 724,526 | 161,999 | 381,960 | 352,950
  | seq | 37,742 | 25,202 | 532,462 | 164,420 | 380,859 | 352,385
Improvement | rand | 6.54% | 1.1% | 0.01% | 0% | 4% | 5.91%
  | seq | 2.82% | 1.76% | 5.85% | 0.01% | 3.61% | 5.63%
(3) Replica count = 3
|   | IOPS |   | Bandwidth |   | Latency |
-- | -- | -- | -- | -- | -- | -- | --
  |   | read | write | read | write | read | write
v1.3.0 | rand | 22,331 | 13,173 | 836,394 | 161,967 | 443,608 | 472,776
  | seq | 35,940 | 21,982 | 529,633 | 164,325 | 439,327 | 469,590
v1.3.x-head | rand | 22,927 | 13,297 | 878,596 | 161,754 | 421,266 | 427,169
  | seq | 36,415 | 21,766 | 474,454 | 164,215 | 421,265 | 431,184
Improvement | rand | 2.67% | 0.94% | 5.05% | -0.13% | 5.04% | 9.65%
  | seq | 1.32% | -0.98% | -10.42% | -0.07% | 4.11% | 8.18%

All looks (read/write) improved especially latency. Thanks, @yangchiu for the report.
cc @derekbit @joshimoo


Bring pulse command naming in line with circuit Registers

What is the expected enhancement?
If a Command does not have a name it is currently assigned a default name of p%d where %d is the number of existing Commands. Instead the naming commands should be brought in line with the circuit.register.Register classes default naming policy. There should be a unique prefix and counter for each Command type.
Additionally, validation of the name type should also be performed in a similar manner to the register.
Suggestion for prefix names:

Command default: c
SamplePulse: p
FrameChange: fc
PersistentValue: pv
SamplePulse: acq
Snapshot: snap

@taalexander I agree with the naming convention. I think this will help make the QObj more readable. Can you assign this to me? I propose creating a small function create_name(key: str) in class Command which could be called from the constructors of the SamplePulse, FrameChange, etc... e.g. __init__ in FrameChange would call create_name('acq') to set self.name. What type of user given names should we accept? Anything that can be cast to a str?

Thank you for taking this @eggerdj. I believe 'Register' accepts names of the form. '[a-z][a-zA-Z0-9_]*'. Perhaps we should also take the time to make Register use create_name in a following PR so as to unify the two naming schemes.

One function for both Register and PulseCommand and its children makes sense. Where should we put the function?

Here is what I had in mind for create_name:
def create_name(name: str = None, prefix: str = None, counter: itertools.count = None) -> str:
    if name is None:
        try:
            name = '%s%i' % (prefix, next(counter))
        except TypeError:
            raise QiskitError("prefix and counter must be non-None when name is None.")
    else:
        try:
            name = str(name)
        except Exception:
            raise QiskitError("The circuit/pulse command name should be castable to a string "
                              "(or None for autogenerate a name).")
        name_format = re.compile('[a-z][a-zA-Z0-9_]*')
        if name_format.match(name) is None:
            raise QiskitError("%s is an invalid OPENQASM register/OpenPulse command name." % name)

    return name

But I'm not sure where it should go. If it would not be used by class Register I would have it live in 'class Command'.

I agree it should live as a classmethod in the Command class for now.  Too build the custom counter for each subclass is a bit more difficult. I believe a metaclass will be necessary, eg., usecases for metaclasses as init_subclass is Python 3.6+. If this is too complicated I am ok with only having a single counter or all commands for now.

Closed by #2623.


Small errata for p27 of book (post-June 2023)

Loving that these resources are on GitHub - thank you @AlxndrMlk!
Quick notational suggestion: on p27, the line  $X_{sample} = 1.9 < X < -1.9$ doesn't make sense at the moment.
The right-side reads as a boolean, and the condition can never be satisfied, as written.
Would be clearer what's meant if it was "...sampled according to the condition $X < - 1.9$ or $X > 1.9$".

Hi @j-at-ch
Thank you for pointing this out.
You're right, this is an abuse of notation and might be confusing.
I'll add this to the list of corrections for the next edition.
Best,
Alex

Thanks @AlxndrMlk!


Preview of annotateerror yielding IFluidErrorBase

Once https://github.com/microsoft/FluidFramework/pull/6721 merges, this will be my next PR.

See https://github.com/microsoft/FluidFramework/compare/main...markfields:annotateError-IFluidErrorBase


"odo catalog list components" doesn't list components from all registries

What versions of software are you using?
Operating System: all
Output of odo version: master
How did you run odo exactly?
odo catalog list components
Actual behavior
$ odo catalog list components
Odo OpenShift Components:
NAME              PROJECT       TAGS                   SUPPORTED
java              openshift     11,8,latest            YES
nodejs            openshift     10,12,latest           YES
dotnet            openshift     2.1,3.0,3.1,latest     NO
golang            openshift     1.11.5,latest          NO
httpd             openshift     2.4,latest             NO
modern-webapp     openshift     10.x,latest            NO
nginx             openshift     1.10,1.14,latest       NO
perl              openshift     5.26,latest            NO
php               openshift     7.2,7.3,latest         NO
python            openshift     2.7,3.6,latest         NO
ruby              openshift     2.4,2.5,latest         NO

Odo Devfile Components:
NAME                 DESCRIPTION                            REGISTRY                   SUPPORTED
maven                Upstream Maven and OpenJDK 11          DefaultDevfileRegistry     YES
openLiberty          Open Liberty microservice in Java      DefaultDevfileRegistry     YES
java-spring-boot     Spring Boot® using Java                DefaultDevfileRegistry     YES
quarkus              Upstream Quarkus with Java+GraalVM     DefaultDevfileRegistry     YES
nodejs               Stack with NodeJS 10                   DefaultDevfileRegistry     YES

Expected behavior
I've got three registries configured on the system:
$ odo registry list
NAME                         URL
CheDevfileRegistry           https://che-devfile-registry.openshift.io
DefaultDevfileRegistry       https://raw.githubusercontent.com/elsony/devfile-registry/master
DefaultDevfileV2Registry     https://raw.githubusercontent.com/elsony/devfile2-registry/master

But I see components from only one. If I use #3264 and do odo catalog list components -o json, I see components from other registries as well.
/kind bug
/area component
/area devfile
/area devfilev2

Ah, so I see all components if I do odo catalog list components --all which shows unsupported components as well.
IMO, this is a bit unintuitive because we list both supported and unsupported s2i components when we do odo catalog list components. However, for devfile components, we require --all flag to list unsupported ones.
But then, I guess, this is temporary as we phase out s2i components.
TBH, not sure what the behaviour should be in the interim. Should odo catalog list components -o json show unsupported without --all when odo catalog list components doesn't? Maybe, we shouldn't be too bothered about interim? That would make sense as well! :smile:
/kind discussion


Make ignore role standard unless otherwise specified

Example:
      <equalTo>
            <column index="0" role="key"/>
            <column index="1" type="numeric" role="value" tolerance="0.001"/>
            <column index="..." role="ignore"/>
            <resultSet ..../>
      </equalTo>

Columns that are not to be included in the test are currently marked with the ignore keyword. On big tables of which you only want to check one or two columns you have to specify ignore on all the others.
The feature proposition is: Make ignore standard behavior unless specified otherwise.

I understand the unfriendliness of the current design when most of the columns must be set to ignore. Nevertheless, changing the default behaviour (all columns are keys except the first) is a huge breaking-change and will probably break 20% of the tests that are coded with NBi.
I'll check further the best solution but I'll probably add an attribute at the level of the equalTo assertion to specify that by default columns should be ignored.

I was talking to Wim last week about a possible non mandatory attribute remarking default behavior

How could a use case look like to ignore columns? I never select columns I don't test for, that's why I ask.

@FuegoArtificial If you've a stored procedure returning 3 columns (1 key and two values), the best practice is to have two tests, one checing the first value-column and ignoring the second and a second with the opposite configuration.
Another case is when you've a CSV file with many information including the few columns that you need for your assertion.

ah okay, that makes sense.
I disagree with that best practice to have an extra test for each value along the same entities, so maybe that's why I never have that use case.
There can be a heavy performance impact on the one side and I don't see a reason not to test multiple values at once on the other side. But maybe that's a matter of taste to understand which values fail just from the test name instead of having to look on the error result table.

Finally, I just added an option to specify none for the values attribute of the equalTo assertion. If you select this option it means that you must specify one by one all the columns that should be treated as a value column.

Available in beta: https://ci.appveyor.com/project/Seddryck/nbi/build/1.16.0-beta.20.build.18


Add code for Longest increasing subsequence in DP

Is your feature request related to a problem? Please describe.
Given an array find the Longest increasing subsequence.
In interviews they might ask these as what is the max length of sub array.
Describe the solution you'd like
Suppose A={1,4,2,4,3} we can have increasing subsequence 1,2,3 or 1,2,4.
Brute force takes exponential time, so this is preferred.
Do you want to work on it
Ill add comments and code using C++.

@amankhanathani Can I work on this issue using c++?

@amankhanathani  please assign this issue to me in C++.I am a GSSOC'21 participant

hey!! @amankhanathani can i use this as my first open source contribution?


Error when Prisma try to fit an old MongoDB record in a model with a new field.

Those are two existing records in my MongoDB collection. I inserted them using a version of Post model without author field.

Then I added author field as a String in Post model.

When I tried to recover those records, I got an error.

Looking at this again, I'm not totally sure it's a bug, because the schema defines the shape of your data and the previous items in the collection don't have that shape.
Without migrate or introspect though, I can see how easy it is to run into this and I'll talk to the team to see what we can do.
Two workarounds that should work:

Make the author optional (String?)
Backfill the previous records to have an author.

Awesome! It's working now. It is something to pay attention, maybe an advise would help.

As this might be much more common with Mongo, we could possible invest in giving a better error message here that tells the user what is going on @matthewmueller, something along "Data returned included and author with value null which is not compatible with your current schema."

Glad to hear that worked for you @matheusfenolio. Re-opening as a discussion because this is a super easy trap to fall into in the current state.

Closing in favor of: https://github.com/prisma/prisma/issues/6715


Support ARM architecture

ARM-based processors are becoming increasingly popular. Should build and publish images for ARM64 in addition to AMD64.
This would allow podtato-head to run on Raspberry Pi clusters as well as new machine types like Graviton2.

Makes sense, thanks for the proposal.

any news on this feature ?
I would like to deploy the podtato-head application to test the Keptn Lifecycle Toolkit on an ARM64 Kubernetes cluster.


[Avatar] Missing fetchPriority property

Steps to reproduce
fetchPriority property does not have in the Avatar component
Current behavior
No response
Expected behavior
No response
Context
No response
Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: fetchPriority, Avatar

Hey @jalalmanafi! You can pass any props to the underlaying <img> using slotProps:
<Avatar
  alt="Yay"
  src="https://placehold.co/400"
  slotProps={{ img: { fetchPriority: "low" } }}
/>

Here's a working example: https://codesandbox.io/p/sandbox/recursing-mendeleev-66qwxl?file=/src/Demo.tsx:3,41

Thank you so much @aarongarciah


Transacter.readonly

To prevent unintended DB writes. We should be deliberate about MVCC: if you enter a readonly block the data beneath you shouldn’t change.

https://github.com/square/misk/pull/578/files


fix(loader): Test webpack version in get-matched-rule

What kind of change does this PR introduce? (bugfix, feature, docs update, improvement)
bugfix
What is the current behavior? (You can also link to an open issue here)
#461
What is the new behavior (if this is a feature change)?
Checks webpack version in get-matched-rule to ensure we're targeting the correct webpack version.
Does this PR introduce a breaking change?
No
Please check if the PR fulfills contributing guidelines

Unfortuanality in this repo we trying to get rid of versions checks and check functionality availability.


Used bang in file-header

PR checklist

[x] Addresses an existing issue: Fixes #3738
[x] New feature, bugfix, or enhancement

[x] Includes tests

Overview of change:
Adds the ! to indicate to TypeScript that this should come before auto-added inserts.
CHANGELOG.md entry:
[enhancement] Added ! character to file-header auto-fixes.

Hi @JoshuaKGoldberg, not sure whats happening with these tests - would you mind re-running them?


Upload distributions to GitLab

Hi,
Is there a way to upload the dist folder to gitlab. Going thourgh the code ,it seems that the upload_dists function has't been overridden in the Gitlab class. Are there any alternative ways?
Thanks

When I added the ability to attach distributions to GitHub Releases, I'd never worked with GitLab (and still never have), so I left it out. I'm happy to convert this issue into a feature request to get something similar added if you'd like.

Sure, that would be great.

@e0lithic You can push to Gitlab instead of PyPi, see documentation at https://python-semantic-release.readthedocs.io/en/latest/#distributing-release-on-pypi-or-custom-repository
Point custom_url to ${CI_API_V4_URL}/projects/${CI_PROJECT_ID}/packages/pypi, set REPOSITORY_USERNAME to gitlab-ci-token and REPOSITORY_PASSWORD to $CI_JOB_TOKEN

Hello,
When I launch semantic-release  publish I also this message
semantic_release/hvcs/_base.py:88: UserWarning: upload_dists is not supported by Gitlab
  _not_supported(self, "upload_dists")

The content of upload_dists in gitlab.py is not implemented, there are work in progress ?
Thanks

@general03, not that I am aware of. I would also validate this is actually what you desire. Part of the reason this has not been implemented is because GitLab makes the approach of release assets differently.
It is important to distinguish that if you are desiring to publish to the GitLab Package Registry for pip integration. The  upload_dists() function does not provide this functionality. This is a common misconception.

I need to publish a Gitlab release like this

When I used the version 7, all worked fine but since I updated to version 9 I can't do this

Ok good, yes, the assets section would be the proper output of the upload_dists function.

And It is not compatible with gitlab ?

And It is not compatible with gitlab ?

Don't know yet, I've only been on the periphery of GitLab support of Releases. I was doing a lot of GitLab when it wasn't possible and  then it updated fairly quickly over the past 4 years. Just from the Release GUI, i remember it just wasn't the same as GitHub in how you upload files.

@general03, looked at GitLab docs, GitLab does not support assets in the same manner as GitHub where the asset storage is a separate storage area from the "registries".  It uses the Generic Package Registry as the backing file storage and then asset links can be attached to the release notes.
If this was going to be implemented, then PSR would need to publish the files to the Generic Package Registry via the API and then create an asset link in the release notes.
My hesitation with this is that if the project is Python distribution artifacts (sdist, wheel), the expectation would be to publish it to the GitLab Python Package Registry so that pip could download these and the asset links would point to the GitLab Python Package Registry entries. The problem is that with the migration to v8, PSR removed the internal wrapping of the twine tool to publish to Python Registries (it's now the users responsibility to run the twine command). With that in mind how would you imagine providing the input to the publish command to tell PSR where the assets are located (link location)?
Essentially you could even point these links to the Pypi registry.

hum I'm something that I don't understand because now I can create "Gitlab Release" with command semantic-release version, normal ?
So what do the command  semantic-release publish ?
Thanks

hum I'm something that I don't understand because now I can create "Gitlab Release" with command semantic-release version, normal ?
So what do the command  semantic-release publish ?

Please take a look at my responses here as this has been asked before: https://github.com/python-semantic-release/python-semantic-release/issues/802#issuecomment-1899692167
But also please provide a recommendation on how you would like to see upload_dists via links implemented


Connect https://geo.di.huc.knaw.nl to DI website

Now that the DI site is in place, to what extent do we still need an entirely separate geo.di.huc.knaw.nl website? What parts can be integrated? What parts cannot? The Geo expertise section on the DI site currently has no links or references at all to https://geo.di.huc.knaw.nl.

ik overleg ook even met Thomas.

As a smaller point, Rombert should probably appear on the geo expertise page as well.

I think we can turn off geo.di.huc.knaw.nl. It is entirely obsolete now. I'll check some possible dependencies, and then turn down the website.

prima. En sommige content kan ook worden verplaatst naar de nieuwe website.


Add guidance for Data Factory Client

Azure Data Lake has an official .net Client (Microsoft.Azure.Management.DataFactory).
It would be great to add it to the table.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8194899c-dee2-70ac-422a-edc06e779f7c
Version Independent ID: cafc7418-404c-5908-3037-dba7f452087b
Content: Retry service specific guidance
Content Source: docs/best-practices/retry-service-specific.md
Service: guidance
GitHub Login: @dragon119
Microsoft Alias: pnp

Microsoft.Azure.Management.DataFactory is .Net SDK for Azure Data Factory service, not Azure Data Lake.
Please refer to https://www.nuget.org/packages/Microsoft.Azure.Management.DataFactory/0.8.0-preview and https://azure.microsoft.com/en-us/services/data-factory/ for more information.

We recently added a line in the table for Data Lake Store


feat(router): Adding response schema for compat_generate

What does this PR do?

This PR adds response schema to compat_generate based on the content_type. Multiple content types and schema are added to 200 response code for the compat generate path and we can see the drop down for the content type in Swagger UI. Change the content type to display respective response schema and examples.
Screenshots:

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@feynmanliang - I'm assuming that updating that JSON file is not required as the specs are auto generated by utoipa, but I might be wrong.
@OlivierDehaene - would you be able to suggest?


Improve JSON parser error recovery

Does two loosely related things:

After we’ve finished parsing one of the top-level expression kinds that are valid in JSON, we check to see if we’re on the EndOfFileToken yet. If we’re not, we loop and parse another top-level expression, issuing an "unexpected token" error. At the end, if we have more than one top-level expression, we make them the elements of an ArrayLiteralExpression, and that becomes the single top-level expression of the file. This is to make sure that in a case like {} identifier, identifier actually belongs to a node, instead of being a token totally unaccounted for in the parse tree (which triggers a debug failure if the language service finds out about it). This fixes the remaining repro of #39854.
Fixes error reporting in tsconfig parsing when the top-level expression is not an object (#37850).

Neither of these bugs are very important, and parser changes are inherently somewhat risky, so this should wait until 4.3.
Fixes #39854
Fixes #37850

The approach seems reasonable - the only thing I'm a little concerned about is whether there are any places in the compiler/LS where we try to ask for brackets on a node (since they won't exist here)

the only thing I'm a little concerned about is whether there are any places in the compiler/LS where we try to ask for brackets on a node (since they won't exist here)

We generally don’t do any interactive stuff with JSON files in the language service since editors (at least VS Code) use another set of providers for JSON. The only way we discovered this was through API use and the playground. But if you have a suggestion of something else to test, I’ll add it.

@typescript-bot perf test this faster
I don’t know if any of our perf tests resolve JSON modules though


Better Readme File

The readme file now has clearer instructions, improved grammar, much less typing/spelling errors and more consistent Markdown code.

Out of topic.
@Seedy-Threepio
May I know where can I learn the markdown code for MD file or have any way
to write the MD file more easier including testing the MD file after
writing?
Thanks.


Assign API key

Hi, I am building an Angular2 / typescript app using the Angular CLI.
I installed the typings and it seems to be working.
I'm trying to set the KEY, statically, as per the docs:
GoogleMapsLoader.KEY = 'myApiKey';
It seems that property is read-only, I get the following compilation error:

Left-hand side of assignment expression cannot be a constant or a read-only property

Am I missing something obvious?

Hi, how do you import this library?

Thanks for your response, like so:
import * as GoogleMapsLoader from 'google-maps';

You should import it like this:
import googleMapsLoader = require('google-maps');

Thats because this library was written just for common js loader, not for es6.

Ah shucks,
Import assignment cannot be used when targeting ECMAScript 2015 modules, which I believe I have to.
Everything else seems to work (I only get a warning) I just can't assign the API key
Thanks so much for your time anyway ;)

I see, in my typescript apps I target es5 so thats probably why it works for me even when I combine es5 and es6 modules together..
Anyway in a future I plan to rewrite this library to typescript and use es6 loading, so stay tuned :wink:


Add missing regex escapes

In reference to the Issues #142 #144, here the commit to the master branch.

Thanks. Fixed it for me under Python 3.7.3!

Yes, this fixes the issue. Can the maintainer please pull into master so we do not have to fork and patch.
ping @joepie91

Could you please merge this pull request? Thanks

Could you please merge the pull request?

Or maybe give the write access to some other dev who can help with this grat code.


[feature request] allow us to extend lambda roles

Allow us to add roles to the lambdas since most organisation aws accounts has a very limited access

Original issue:
I need to give it access to read secretsManager, i could only do it manually in AWS console, is there a way to do it in serverless yml or js file?
i need something like this
name: testAApp

appPortal:
  component: serverless-next.js
  inputs:
    domain:
      - ${env.subdomain}
      - ${env.domain}
    bucketName: ${env.bucketName}
    iamRoleStatements:
      Version: 2012-10-17
      Statement:
        - Effect: Allow
          Action:
            - secretsmanager:GetSecretValue
          Resource: "arn:aws:secretsmanager:eu-central-1:<account_id>:secret:<secret_name>"
        - Effect: Allow
          Action:
            - logs:CreateLogGroup
            - logs:CreateLogStream,
            - logs:PutLogEvents
          Resource: "*"

I even tried to create a policy and added it to serverless.yml but still doesn't work
name: myapp

myAppPortal:
  component: serverless-next.js
  inputs:
    domain:
      - ${env.subdomain}
      - ${env.domain}
    bucketName: ${env.bucketName}
  	policy: "arn:aws:iam::930000340522:policy/myapp-limited-access"

policy
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Sid": "VisualEditor0",
            "Effect": "Allow",
            "Action": "secretsmanager:GetSecretValue",
            "Resource": "arn:aws:secretsmanager:eu-central-1:930000340522:secret:myapp-v2-0vMKxR"
        },
        {
            "Effect": "Allow",
            "Action": [
                "logs:CreateLogGroup",
                "logs:CreateLogStream",
                "logs:PutLogEvents"
            ],
            "Resource": "*"
        }
    ]
}

the only way i could make it work is finding the role this plugin creates and attach a policy to it
Appreciate some help here

Finally managed to get it work to deploy, now i have to work on the removing so you can run sls remove
@danielcondemarin could you please confirm if it's a good way to do it?
serverless.js
const yaml = require("js-yaml");
const fs = require("fs");
const aws = require("aws-sdk");
const { Component } = require("@serverless/core");

function addPolicy(policy) {
  const doc = yaml.safeLoad(fs.readFileSync("./serverless.yml", "utf8"));
  doc.myApp.inputs = {
    ...doc.name.inputs,
    policy
  };

  return doc;
}

class Deploy extends Component {
  async default() {
    const iam = new aws.IAM({ credentials: this.context.credentials.aws });
    const sts = new aws.STS({ credentials: this.context.credentials.aws });

    const params = {
      PolicyDocument: JSON.stringify({
        Version: "2012-10-17",
        Statement: [
          {
            Effect: "Allow",
            Action: "secretsmanager:GetSecretValue",
            Resource: "*"
          },
          {
            Effect: "Allow",
            Action: ["logs:CreateLogGroup", "logs:CreateLogStream", "logs:PutLogEvents"],
            Resource: "*"
          }
        ]
      }),
      PolicyName: "myAppV2Policy",
      Description: "Policy used by myApp V2 website",
      Path: null
    };

    let policyArn = "";

    try {
      const identity = await sts.getCallerIdentity().promise();
      policyArn = `arn:aws:iam::${identity.UserId}:policy/myAppV2Policy`;

      await iam
        .deletePolicy({ PolicyArn: policyArn })
        .promise()
        .catch(err => err);
      await iam.createPolicy(params).promise();
    } catch (error) {
      throw new Error(error);
    }

    const doc = addPolicy(policyArn);

    const template = await this.load("@serverless/template");
    const output = await template({ template: doc });

    return output;
  }
}

module.exports = Deploy;

serverless.yml
name: my-app

myApp:
  component: serverless-next.js

Is there a reason this was closed?

I didn't think Daniel would like to add this, i believe this will makes things much easier if they do.
I'll reopen it.

Have you checked https://github.com/danielcondemarin/serverless-next.js#aws-permissions ? You can add a policy input to the component:
myNextApplication:
  component: serverless-next.js
  inputs:
    policy: "arn:aws:iam::123456789012:policy/MyCustomPolicy"

@danielcondemarin Currently i wrote above code in the serverless.js file to create the policy and attach it to the yml file, i was hoping this plugin just let us extend the roles instead.
Not a big deal but would be nice to have this and let us attach any extra inline policy we need
https://github.com/serverless-components/aws-iam-role#4-configure (i know it's for V2 but something like this would be nice)


feat: add showwin/speedtest-go

https://github.com/aquaproj/aqua-registry/pull/5644 showwin/speedtest-go: CLI and Go API to Test Internet Speed using speedtest.net
$ aqua g -i showwin/speedtest-go

Thank you always!

Renamed the command speedtest-go to speedtest.

https://github.com/showwin/speedtest-go#usage
https://github.com/showwin/homebrew-speedtest/blob/1b5b090b5435f245ba2cbbc7ce8653be2f60e26e/speedtest.rb#L14-L21

Released. https://github.com/aquaproj/aqua-registry/releases/tag/v3.35.0


Add many to many relations and their table

What does this PR do?
This PR is raised to implement the following features: 👍 :

[x] Use GitFlow to introduce new features
[x] Create specializations and visits join tables
[x] Add mock data to them
[x] Create many-to-many relationship
[x] Use the new join table to query data

Description of the tasks completed 👇

[x] Add join tables
[x] Setup PostgreSQL
[x] The process involves installing PostgreSQL, creating a new database, defining tables using SQL commands, loading data into tables, configuring database settings, and connecting to the database. ☺

How should it be tested
Clone the repository
git clone https://github.com/UbdaNam/Vet-Clinic-db-query.git

Navigate to the folder
cd Vet-Clinic-db-query

Checkout the branch
git checkout Add-join-table

Run app
open your terminal and run the following commands
  psql -U [enter your username here] -h localhost
  password:_"Enter your password"
  CREATE DATABASE vet-clinic;

Thank you @tugsem for reviewing my kudos to you.


[CAMEL-13123] Add test stopping endpoint

@oscerd I finally raised PR against master. As you said before.

Thanks, merged on master and fixed CS


Use selfhosted openai-server instead of spending money

WIP in new branch, ran into an issue w/ openai-sever :  https://github.com/shawwn/openai-server/issues/1
Nevermind the need to then make it run w/o a GPU, which might be hopeless anyways.
Perhaps worth spinning up on a machine separate from docker.

Ok so since the other mentioned repo is borked, we're gonna use something like this code snippet, throw it in flask, and then call it a day :shipit:
from transformers import AutoModelWithLMHead, AutoTokenizer

model_name = "gpt2-xl"
tokenizer = AutoTokenizer.from_pretrained(model_name)
model = AutoModelWithLMHead.from_pretrained(model_name)

text = "The quick brown fox jumps over the lazy dog, and then"
input_ids = tokenizer.encode(text, return_tensors="pt")
output = model.generate(input_ids, max_length=50, do_sample=True)
generated_text = tokenizer.decode(output[0], skip_special_tokens=True)
print(generated_text)

This can be a new container with just like, python, and pip3 install transformers torch

Oh yea btw i did the thing it's working now (worse, but free)


[gh-152] Revert change that was made to postgres schema parsing that cau...

...ses regressions and has no tests.
The original "fix" that I reverted was undocumented, unreproducible, etc. I have no idea how to even verify what he expected from the original ticket. Clearly it was some edge case involving quotes in default values.
I have reverted that change out to restore normal behavior until the original poster can provide some kind of test data or a better patch.

IGNORE, wrong branch.

OOPS wrong branch


Navigation support

Added support for navigation menu items in Ghost 0.5.

Dude thanks for this. Worked perfectly.


Update Project.toml

Closes #73
I also updated Project.toml format.

I'll close this PR since #73 was fixed by #75.


chore: hardcoding open-source cloudscape favicon

This pull request hardcodes a base64 string of the cloudscape favicon from cloudscape.design site ensuring that we show an approved version into our open source package.
By having a favicon in the index file, there is less likeliness for failed integ test from the SEVERE network error of a missing favicon, especially when chrome versions are updated.
Unexpected errors in browser console:     [       {         "level": "SEVERE",         "message": "http://localhost:8080/favicon.ico - Failed to load resource: the server responded with a status of 404 (Not Found)",         "source": "network",         "timestamp":<PHONE_NUMBER>544       }     ]
This favicon will make it harder for us to distinguish our dev and even deployed environments in the browser's fabs, however future followups where different colored favicons will be added once available
Description

Related links, issue #, if available: n/a
How has this been tested?

Open https://d21d5uik3ws71m.cloudfront.net/components/8e7f0dc2b7c184cb3cfc92fbe8a6e0909db20553/dev-pages/index.html#/light/ on different browsers

Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness

Changes include appropriate documentation updates.
Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
Changes do not include unsupported browser features, see CONTRIBUTING.md.
Changes were manually tested for accessibility, see accessibility guidelines.

Security

If the code handles URLs: all URLs are validated through the checkSafeUrl function.

Testing

Changes are covered with new/existing unit tests?
Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Any chances of making it more clean and readable? There is favicon option in the HtmlWebpackPlugin which we already use

resolution no longer needed. We can reopen if needed at another time


[ISSUE #4323] Transaction example add the default NamesrvAddr

fix : #4323
Make sure set the target branch to develop
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+0.03%) to 52.181% when pulling 058d03f9a0875f2205aee09f1dba8d09cccd16bf on li-xiao-shuang:feature_example_11 into 82a48be00a6d9def14abb871a40cb68cf8a041e9 on apache:develop.

Coverage increased (+0.03%) to 52.181% when pulling 058d03f9a0875f2205aee09f1dba8d09cccd16bf on li-xiao-shuang:feature_example_11 into 82a48be00a6d9def14abb871a40cb68cf8a041e9 on apache:develop.

Codecov Report

Merging #4354 (b762bb7) into develop (82a48be) will decrease coverage by 0.25%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #4354      +/-   ##
=============================================
- Coverage      48.18%   47.93%   -0.26%
+ Complexity      5082     5047      -35
=============================================
  Files            642      642
  Lines          42770    42770
  Branches        5597     5597
=============================================
- Hits           20609    20500     -109
- Misses         19655    19760     +105
- Partials        2506     2510       +4

Impacted Files
Coverage Δ

...va/org/apache/rocketmq/store/FlushDiskWatcher.java
81.25% <0.00%> (-9.38%)
:arrow_down:

...org/apache/rocketmq/common/stats/StatsItemSet.java
41.79% <0.00%> (-8.96%)
:arrow_down:

...in/java/org/apache/rocketmq/test/util/MQAdmin.java
38.88% <0.00%> (-5.56%)
:arrow_down:

...org/apache/rocketmq/store/ha/WaitNotifyObject.java
66.07% <0.00%> (-5.36%)
:arrow_down:

...apache/rocketmq/remoting/netty/ResponseFuture.java
85.00% <0.00%> (-5.00%)
:arrow_down:

...e/rocketmq/client/impl/consumer/RebalanceImpl.java
40.23% <0.00%> (-4.30%)
:arrow_down:

...rocketmq/remoting/netty/NettyRemotingAbstract.java
47.08% <0.00%> (-4.02%)
:arrow_down:

...nt/impl/consumer/ConsumeMessageOrderlyService.java
46.83% <0.00%> (-3.53%)
:arrow_down:

...lient/impl/consumer/DefaultMQPushConsumerImpl.java
40.84% <0.00%> (-3.00%)
:arrow_down:

...ava/org/apache/rocketmq/filter/util/BitsArray.java
59.82% <0.00%> (-2.57%)
:arrow_down:

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82a48be...b762bb7. Read the comment docs.


Keyboard Shortcuts Menu Accessibility and I18N Improvements

Bug Description
The keyboard shortcuts menu should be using the  element. That'd remove the need for all those aria-label props due to the element's semantic meaning.
Also, the menu should avoid string concatenation for the actual menu items.
For example, "Hold CMD" would need to be translated to "CMD halten" in German, but that's currently not possible because the shortcut isn't one translatable string:
https://github.com/google/web-stories-wp/blob/06d921a7a7e1080a52cb3ff07c8fe7ad5493809f/assets/src/edit-story/components/keyboardShortcutsMenu/keyboardShortcutList.js#L160-L161
This should be using something like:
<TranslateWithMarkup
  mapping={{kbd: }}
>
  {
    sprintf(
      /* translators: %s: Cmd/Ctrl key. */
      __('Hold %s', 'web-stories'),
      cmdOrCtrl
    )
  }
</TranslateWithMarkup>

Expected Behaviour

Steps to Reproduce

Screenshots

Additional Context

Plugin Version: 1.7.0
WordPress Version: 5.7
Operating System: macOS
Browser: Chrome

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

@BrittanyIRL FYI, assigning this one to pea pod as the original creators of this component (if I'm not mistaken).

(This was brought into the sprint late in the game because it looked like we would have some extra time. As fate would have it, Karma was going to throw fits and eat up most of that time! this might go back to the backlog. Will check in with Samuel when he's back from PTO next week.)

for something like the [cmdOrCtrl, /] key, how would we like to write the translator comment statement?
Option 1
    {sprintf(
          /* translators: 1: 'Cmd/Ctrl' key 2: '/' key */
          __('%1$s%2$s', 'web-stories'),
          cmdOrCtrl,
          '/'
    )}

Option 2
    {sprintf(
          /* translators: 1: Cmd/Ctrl key 2: / key */
          __('%1$s%2$s', 'web-stories'),
          cmdOrCtrl,
          '/'
    )}

Option 3
    {sprintf(
          /* translators: %s: Cmd/Ctrl key */
          __('%s/', 'web-stories'),
          cmdOrCtrl,
    )}

I don't think we need to translate simple shortcuts that don't include any text, such as [cmdOrCtrl, '/']. Just the ones where we have "partial" text like "or double-click", "or", and "Hold".
If anything, I'd go with option 3. Because option 1 and 2 don't include anything translatable at all. (How do you translate %1$s %2$s to Spanish?)
Taking Shift, Up, 'or', Down as an example, we could write that like so:
'' +
printf(
  /* translators: 1: Shift key. 2: Up key. 3: Down key. */
  __('%1$s%2$s or %3$s', 'web-stories'),
  SPECIAL_KEYS.SHIFT,
  SPECIAL_KEYS.UP,
  SPECIAL_KEYS.DOWN
)
+ ''

(Moving the wrapping outer  out of the translatable string makes this easier for translators)
Which would result in final output
⇧(Up Icon)or(Down Icon)

Perfect. Sounds good. Thanks for the guidance!

one other quick question. Our shift constant looks like this:
  SHIFT: {
    symbol: '⇧',
    title: _x('Shift', 'The keyboard key "Shift"', 'web-stories'),
  },

Should the final rendered result just look like this?
{SPECIAL_KEYS.SHIFT.symbol}

Should the title property be included anywhere in there? or is ⇧ already language agnostic? Not familiar with keyboards in other languages and how that all works out, so still trying to learn a bit here.
Is the SPECIAL_KEYS[someKey].title property needed at all once we switch to rendering with ?

Let's put the title in an aria-label for these special keys.
⇧

If that doesn't work well with screen readers, we might need to do something like this:
⇧<VisuallyHidden>Shift</VisuallyHidden>

Awesome. Will go with aria-label for now and try it out. Thanks!

@swissspidy Sorry for this being the ticket with never ending questions.
For a key combination with just a special key and an alphabetical key, is there any need to translate?
        shortcut: (

              <TranslateWithMarkup mapping={{ kbd:  }}>
                {sprintf(
                  /* translators: 1: Cmd/Ctrl key title. 2: Cmd/Ctrl key symbol. */
                  __(
                    '%2$sK',
                    'web-stories'
                  ),
                  cmdOrCtrl.title,
                  cmdOrCtrl.symbol
                )}
              </TranslateWithMarkup>

        ),

vs
        shortcut: (

              {cmdOrCtrl.symbol}
              {'K'}

        ),

@csossi this just needs regression testing for the shortcut menu. the translations were updated.

Verified in QA


ZetaSQL test Java version fixes

Align SDK container version with pipeline submission env

Disable ZetaSQL test on Java8

This fixes beam_PostCommit_XVR_PythonUsingJavaSQL_Dataflow and beam_PostCommit_XVR_Samza after #32902
Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @shunping


Dcoumentation references example with method Square() which does not exist in any examples

Documentation introduction needs s/Square/IntToString/

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d5ff437a-9d89-1f75-6b5b-ab7f43186b7b
Version Independent ID: 36091647-7822-1c5e-97d8-e28b37832d8c
Content: Compiler Error CS1520
Content Source: docs/csharp/misc/cs1520.md
Product: dotnet-csharp
Technology: csharp-diagnostics
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Thanks for raising this @eberleitguy
I've added it to our backlog, and added the "up for grabs" label to this issue.


[FLOC-1848] Remove resize dataset from API

Fixes:

https://clusterhq.atlassian.net/browse/FLOC-1848

Removes the maximum_size change capabilities from the update dataset API endpoint.

Thanks @dwgebler
Not a full review, but:

I was going to say that it'd be nice to not duplicate the properties in the types.yml file, but I know that it's difficult to merge / inherit json schemas and have them rendered nicely....so leave that.
There are some remaining (failing) acceptance tests that need to be deleted though.

http://build.clusterhq.com/builders/flocker%2Facceptance%2Frackspace%2Ffedora-20/builds/1318/steps/trial/logs/stdio
Please remove / fix those and resubmit.

Looks good, address and merge. And maybe file issue for resurrecting this code, with a link to the check-in so it's easy to revert.


FINERACT-1981: Advanced payment allocation validation between Loan pr…

…oduct and Loan account
Description
Repayment strategy validation applied in the Loan account creation and modification, specifically when the Loan product uses Loan Schedule Type as PROGRESSIVE

Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!

[ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests

[ ] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

[ ] Create/update unit or integration tests for verifying the changes made.

[ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

[ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

[ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

Please see my comment!

Done! Code updated and conflicts solved with the latest changes

@josehernandezfintecheandomx Please dont forget to squash your commits! ;)


fix: add missing fakeTime export

I noticed that the export of fakeTime seems to be missing.
Hope you don't mind that I didn't open an issue just for this.

Good catch! Thank you!

:tada: This PR is included in version 1.2.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Renaming all functions with azs branding and warning on deprecated items

updated with Azs capitalization

@BrianLPeterson,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


fixes #32 'Emitted ContainerStd*WrittenToEvent.Data Incomplete'

approved

Current coverage is 32.02% (diff: 0.00%)

Merging #33 into master will increase coverage by 2.83%

@@             master        #33   diff @@
==========================================
  Files            29         29
  Lines           716        712     -4
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            209        228    +19
+ Misses          502        479    -23
  Partials          5          5

Powered by Codecov. Last update d69b764...cb97b00


Intro to hacktoberfest

Your pull request seems good, but must be checked by a human maintainer for the following reason(s):

This file has modifies a pre-existing file.

Please be patient until a maintainer has time to look over your contribution.
This is an automated response, beep boop.
if you think there is a mistake, contact a maintainer

2dcfd3516debb16a0f34d0e98655fd901b21b56a

If we're doing that, we may as well link to the hacktoberfest page on the readme, if you can do that either embedded into the paragraph or a separate link underneath i will be happy to merge.

Also just noticed that this PR completely fails to see the point of hacktoberfest and how it encourages open source contributions and the emphasis on impact that OS has had on software in the past years. This pr is clearly an attempt to gain a point and will be locked as spam. Feel free to try again with a more appropriate description of the event.


starts engine_preparePayload API call implementation

changelog:

introduces Duty preparation
uses Duty preparation in BlockProductionDuty to handle the call to the execution engine to prepare the block
starts extending other required classes to be able to call the new method

BTW, should the preparePayload be called on reorg?

BTW, should the preparePayload be called on reorg?
Or just a new Duty recreated on reorg?

oh, I see onChainReorg event in DutyScheduler. But does it trigger an onAttestationCreationDue for the same slot in any case? Here I need @ajsutton :-)

BTW, should the preparePayload be called on reorg?
Or just a new Duty recreated on reorg?

oh, I see onChainReorg event in DutyScheduler. But does it trigger an onAttestationCreationDue for the same slot in any case? Here I need @ajsutton :-)

It's not necessarily a chain reorg that triggers calling prepare again but any head update.  The most common case will be that we're proposing at slot X and the block at X-1 is received late.  That's a normal head update to fill the empty slot but it still changes the parent root of the block we'll create so need to send a new prepare call.
You should get another call to onAttestationCreationDue in that case - the duplicates are filtered by AbstractDutyScheduler.onProductionDue where it checks lastProductionSlot and we just don't want to do that same kind of check for preparations.

@ajsutton a unit test is still failing i guess not related to current PR (GetPeersScoreTest)


validate_arguments decorator is creating copy of arguments instead of keeping references

Checks

[x] I added a descriptive title to this issue
[x] I have searched (google, github) for similar issues and couldn't find anything
[x] I have read and followed the docs and still think this is a bug

Bug
When using @validate_arguments it seems that the reference to the original object arguments is lost, making it unable for the function to modify the object in place
Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":
pydantic version: 1.8.2
pydantic compiled: False
     install path: /root/.cache/bazel/_bazel_root/143636f84d400ba086751871f30d30df/external/pip_deps/pypi__pydantic/pydantic
   python version: 3.10.0 (default, Oct  4 2021, 23:05:56) [GCC 7.5.0]
         platform: Linux-5.10.47-linuxkit-x86_64-with-glibc2.27

from typing import List
from pydantic import validate_arguments

@validate_arguments
def add_one(numbers: List[int]) -> None:
    for i in range(len(numbers)):
        numbers[i] += 1

    return id(numbers)

numbers = [1, 2]
argument_id = add_one(numbers)

print(id(numbers))
print(argument_id)

assert numbers == [2, 3] # passes without the decorator, fails with it

Output shows
# With @validate_arguments (different)
139624718827072
139624719156544

# Without @validate_arguments (same)
140046989633408
140046989633408

That's a side effect of validation.
Not a bug, create a discussion or feature request if you want it changing, but I think it would require a massive change to pydantic.

Ok, at least this is useful to know I'm not crazy. The change in behavior was super weird and unexpected, it was also VERY time consuming to figure out what was going on. Is it documented anywhere?
I worked around it by defining a custom decorator for this:
from pydantic import validate_arguments

def custom_validator(func):
    validated_func = validate_arguments(func)

    def wrapper(*args, **kwargs):
        validated_func.validate(*args, **kwargs)
        return func(*args, **kwargs)

    return wrapper

@custom_validator
def add_one(numbers: List[int]) -> None:
    for i in range(len(numbers)):
        numbers[i] += 1

    return id(numbers)

Since I only use this in tests and performance is not an issue this works for all of my use cases.

Probably not documented explicitly.
Happy to accept a PR to add a warning to the docs.


iOS small widget not working

Describe the bug
https://user-images.githubusercontent.com/20890995/229505830-a4936c6f-c415-4de0-be7f-73385a0af5c0.mov
To Reproduce
Steps to reproduce the behavior:

Add small widget
click into it

Expected behavior
Small widget should open the application as expected

Most likely disable small widget if it's too much work

This started hapening after #532 when adding the flutter_siri_shortcuts library. I'm going to disable the small widget for now and prevent the app from opening by clicking in the background. if that doesn't work then I'll just let this problem stand.


Support forvietnamese-llama2-7b

Hi folk
Really love this project
I just wonder can you guy support this model
https://huggingface.co/bkai-foundation-models/vietnamese-llama2-7b-40GB
It would be fantastic to have this run  inside Ollama

Hi @khoint0210 it should be possible to import this model to Ollama and publish it on ollama.com. Let me know if you hit any issues and I can help you convert – so sorry for the slow reply.


DCGM exporter is not able monitor per-Pod gpu utilization.

I reproduce the issue when I use the time-sharding feature of k8s-device-plugin. Is that the same situation for you ?

@larry-lu-lu I don't what you are talking about, but in my case i deployed dcgm exporter to scrape gpu metrics, but for me it is only able to scrape the metrics of the node and not the metrics of the pods which are utilizing the gpu on that node.

@kishor-3
  In my case, i  has virtualized 3 instance vGPU through config the  nvidia/k8s-device-plugin,like below:

version: v1
sharing:
  timeSlicing:
    resources:
    - name: nvidia.com/gpu
      replicas: 3

I tried to add logs to the source code of dcgm exporter and repackage and deploy, I was pleasantly surprised to find that DCGM can only collect the information of the physical GPU, and the collected metrics information records the UUID of the physical GPU, but the GPU ID of each pod is the UUID of the corresponding physical GPU append an instance number. For example, the UUID of a physical GPU is ABCD, while the GPU ID assigned to a pod is ABCD-0, or ABCD-1。As a result, the metrics information will  be never matched with the pod。

try config

try to config the helm values.yaml
dcgmExporter:
    relabelings:
    - sourceLabels: [__meta_kubernetes_pod_node_name]
      separator: ;
      regex: ^(.*)$
      targetLabel: nodename
      replacement: $1
      action: replace

this will modify the parsed kube api data filed name so they can be recognized.


Consider using winget to distribute packages on Windows

https://docs.microsoft.com/en-us/windows/package-manager/winget/
(Feedback from discuss.ocaml's v0.4.0 release announcement)

Only potential problem is the package must support a non-interactive install per https://docs.microsoft.com/en-us/windows/package-manager/package/winget-validation#submission-expectations.
The Git and the Visual Studio parts are the only interactive parts, but hopefully those can be modeled as dependencies in winget.

https://swi-prolog.discourse.group/t/for-windows-users-is-winget-now-a-standard-command/5564?u=ericgt has useful information as well.

Only potential problem is the package must support a non-interactive install per https://docs.microsoft.com/en-us/windows/package-manager/package/winget-validation#submission-expectations.

That has been fixed by #3

Making task list:

[ ] Create package manifest for 1.0.0, including dependencies for Visual Studio and Git. Precise versions of Visual Studio may make this impossible
[ ] Edit bump2version and sign.sh so package manifest is updated every version
[ ] Test package manifest in CI (Vagrant)
[ ] When Opam is part of winget (confer: @dra27) the DKML winget package needs to use Opam as a dependency
[ ] Submit to Microsoft

Note: With winget I can model Visual Studio Build Tools > x.y.z, but not exact versions that are compatible. Also, you should not have to install Visual Studio Build Tools if you have Visual Studio 2019 Enterprise (etc.).
So modeling the Visual Studio dependencies is not good. The lack of exact versions may mean someone will get an incompatible Visual Studio Build Tools that doesn't work with OCaml. That is actually a bug with OCaml though, not winget or DKML.

Open items that arose during first winget PR https://github.com/microsoft/winget-pkgs/pull/69112 :

[ ] The version is coming through as dev instead of the Opam version 1.0.0. It may be better to just use bump2version inside a version.ml file instead of probing with dune-build-info.

These will be fixed in v1.0.1.

Okay, the final winget problem seems to be a 2hr install limit. Without running in 2hr the winget CI will auto-fail the PR. Otherwise winget installs successfully.

[ ] Will resubmit after install time is reduced to substantially under 2hr (including Visual Studio Build Tools and Git)

Added to winget at https://github.com/microsoft/winget-pkgs/pull/92477
Announced at https://discuss.ocaml.org/t/ann-diskuv-ocaml-1-1-0-windows-winget-setup-dkml/11077/4?u=jbeckford
Closing.


fetch-*: remove md5 support

fixes #4491
cc @domenkozar @edolstra

Mostly okay with this, but I might leave the parameter in place and add an assertion that it's empty, so we can throw a helpful error message ("we've removed md5 support from nixpkgs; please use sha256 from now on" or something) for a while, instead of just breaking it. Nix packages do exist outside of nixpkgs and I hate breaking things with no helpful errors.

@copumpkin updated

Awesome, thanks!!


Package describe should always succeed.

@jsancio there seems to be a problem with the dcos-launch script for the integration tests, any ideas?

Going with a different solution.


[BUG]

Description
The search icon on the books page is behaving weirdly while hovering over it.
Screenshots
https://github.com/rohansx/informatician/assets/77545230/92b78e00-6c9b-4867-a44f-ad121dca76c2
Any additional information?
I want to work on this issue, please assign me this issue under GSSOC'23
What browser are you seeing the problem on?
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I have read the discussion tab thoroughly and got the project idea
[X] I am willing to work on this issue (optional)
[X] I am a GSSoC'23 contributor

@sshiwangi go for it


add qeye()=eye()

Support qeye which makes the syntax more similar to QuTiP.

Something wrong, will make another PR later


[Refactor]: Circles for Pomo Count

The circles indicating the pomo count at the top of the page could be exchanged for little tomato icons to better capture what they represent. Circles are very ambiguous on their own.

Recognized that this issue could be properly implemented in a future team so this issue will remain in the back logs and can be used as an issue for future teams to look into. Currently there are two branches that are associated with this:

Remove-Cycle-Count-From-Header
New-Cycle-Count-on-Timer-Page

Opening this since it should remain open in the backlogs


Added Webpack + some Docs updates to comply with the changes.

Fixes #26
Description

Used Webpack 4 to move from CSS to SASS, as webpack folder is added which contains the config files as well as the SASS and JS files which would be compiled during lektor runtime.
The built CSS and JS files are configured to be stored in the asset folder.
Other information

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the master branch of the repository.
[x] My commit messages follow best practices.
[x] I added tests for the changes I made (if applicable).
[x] I added or updated documentttion (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

I deployed it on my own GitHub page, working fine there. Please check for any further change.