fatal error

chronos@localhost / $ sudo startunity
Entering /mnt/stateful_partition/crouton/chroots/precise...
X.Org X Server 1.13.0
Release Date: 2012-09-05
X Protocol Version 11, Revision 0
Build Operating System: Linux 2.6.42-54-highbank armv7l Ubuntu
Current Operating System: Linux localhost 3.14.0 #1 SMP Sun Aug 16 14:10:32 PDT 2015 armv7l
Kernel command line: cros_secure console= loglevel=7 init=/sbin/init cros_secure oops=panic panic=-1 root=/dev/dm-0 rootwait ro dm_verity.error_behavior=3 dm_verity.max_bios=-1 dm_verity.dev_wait=1 dm="1 vroot none ro 1,0 2506752 verity payload=PARTUUID=f26d5cf9-8cbc-e74e-a721-4ba656b3bf72/PARTNROFF=1 hashtree=PARTUUID=f26d5cf9-8cbc-e74e-a721-4ba656b3bf72/PARTNROFF=1 hashstart=2506752 alg=sha1 root_hexdigest=7d16dfd6647864317c84b64ffd092069c8507f65 salt=f5db6aaf07f8653cd319eee1dd47e2f34be8a2272c27cd8823d15901f314c15c" noinitrd vt.global_cursor_default=0 kern_guid=f26d5cf9-8cbc-e74e-a721-4ba656b3bf72
Build Date: 05 November 2013  03:23:26PM
xorg-server 2:1.13.0-0ubuntu6.5~precise1 (For technical support please see http://www.ubuntu.com/support)
Current version of pixman: 0.30.2
Before reporting problems, check http://wiki.x.org
to make sure that you have the latest version.
Markers: (--) probed, (**) from config file, (==) default setting,
(++) from command line, (!!) notice, (II) informational,
(WW) warning, (EE) error, (NI) not implemented, (??) unknown.
(++) Log file: "/tmp/Xorg.crouton.1.log", Time: Wed Aug 19 22:48:35 2015
(==) Using system config directory "/usr/share/X11/xorg.conf.d"
Initializing built-in extension Generic Event Extension
Initializing built-in extension SHAPE
Initializing built-in extension MIT-SHM
Initializing built-in extension XInputExtension
Initializing built-in extension XTEST
Initializing built-in extension BIG-REQUESTS
Initializing built-in extension SYNC
Initializing built-in extension XKEYBOARD
Initializing built-in extension XC-MISC
Initializing built-in extension SECURITY
Initializing built-in extension XINERAMA
Initializing built-in extension XFIXES
Initializing built-in extension RENDER
Initializing built-in extension RANDR
Initializing built-in extension COMPOSITE
Initializing built-in extension DAMAGE
Initializing built-in extension MIT-SCREEN-SAVER
Initializing built-in extension DOUBLE-BUFFER
Initializing built-in extension RECORD
Initializing built-in extension DPMS
Initializing built-in extension X-Resource
Initializing built-in extension XVideo
Initializing built-in extension XVideo-MotionCompensation
Initializing built-in extension XFree86-VidModeExtension
Initializing built-in extension XFree86-DGA
Initializing built-in extension XFree86-DRI
Initializing built-in extension DRI2
Loading extension GLX
Fatal server error:
no screens found
(EE)
Please consult the The X.Org Foundation support
at http://wiki.x.org
for help.
(EE) Please also check the log file at "/tmp/Xorg.crouton.1.log" for additional information.
(EE)
Server terminated with error (1). Closing log file.
/usr/bin/xinit: giving up
/usr/bin/xinit: unable to connect to X server: No such file or directory
/usr/bin/xinit: server error
Unmounting /mnt/stateful_partition/crouton/chroots/precise...
someone please tell me what went wrong lol

Can you give us the output of crouton version?
sudo enter-chroot -n precise
croutonversion
Also, have you ever been able to see the gui on this chroot or is this right after an install?

right after install:
chronos@localhost / $ sudo enter-chroot precise
Entering /mnt/stateful_partition/crouton/chroots/precise...
-su: 1: precise: not found
Unmounting /mnt/stateful_partition/crouton/chroots/precise...

chronos@localhost / $ sudo enter-chroot -n precise
Entering /mnt/stateful_partition/crouton/chroots/precise...
(precise)welch@localhost:~$ croutonversion
crouton: version 1-20150811114815~master:f6b810fe
release: precise
architecture: armhf
xmethod: xorg
targets: unity
host: version 7077.134.0 (Official Build) stable-channel veyron_jerry
kernel: Linux localhost 3.14.0 #1 SMP Sun Aug 16 14:10:32 PDT 2015 armv7l armv7l armv7l GNU/Linux
freon: yes
(precise)welch@localhost:~$

there ya go

Ok, try this.  I'm not as confident about this but it should be worth trying.
If you have not already, type exit and hit enter. Then enter:
sudo rm /dev/dri/card0
sudo mv /dev/dri/card1 /dev/dri/card0
Then try starting the chroot.
sudo startunity
If this works, you will have to run those top two commands every time you reboot the system.  Rebooting sets card0 and card1 to the default settings.

alright thanks a bunch
just saved me a lot of time haha
also, what is the issue i keep having with updating unbuntu?

like it,ll do the exact same fatal error message

I'm  not sure.  I have a similar problem when I try to use the trusty version of Unbuntu.  I have a working older copy but any new chroots don't work, they give that error even if I do the card change.  For now, I can get a trusty version working if I add xiwi to the target during the install.  I have my own issue down below about this and I'm just trying to help out here while waiting on a response.

thanks it really did help a lot

No problem.  I spent a good chunk of time figuring that out.  Glad to help save you that time.

wish i could help out, but i am really new to this, and only understand a small portion of it

Same, but you got to start somewhere.

yeah

like i don't even know what changing the cards did haha

To tell you the truth, I'm not 100%.  Here is what I "think" is happening.  They seem to be files that let the kernel talk to the video drivers.  Apparently when starting, something is causing it to choose the wrong one.
Check out  this link for more info.

chronos@localhost / $ sudo startunity
Entering /mnt/stateful_partition/crouton/chroots/precise...
Creating hwaudio group with GID 18...
Changing cdrom GID from 24 to 19...
Changing floppy GID from 25 to 11...
Changing plugdev GID from 46 to 85...
Changing uucp GID from 10 to 14...
Changing video GID from 44 to 27...
Moving sudo GID from 27 to 28...
X.Org X Server 1.13.0
Release Date: 2012-09-05
X Protocol Version 11, Revision 0
Build Operating System: Linux 2.6.42-54-highbank armv7l Ubuntu
Current Operating System: Linux localhost 3.14.0 #1 SMP Sun Aug 16 14:10:32 PDT 2015 armv7l
Kernel command line: cros_secure console= loglevel=7 init=/sbin/init cros_secure oops=panic panic=-1 root=/dev/dm-0 rootwait ro dm_verity.error_behavior=3 dm_verity.max_bios=-1 dm_verity.dev_wait=1 dm="1 vroot none ro 1,0 2506752 verity payload=PARTUUID=f26d5cf9-8cbc-e74e-a721-4ba656b3bf72/PARTNROFF=1 hashtree=PARTUUID=f26d5cf9-8cbc-e74e-a721-4ba656b3bf72/PARTNROFF=1 hashstart=2506752 alg=sha1 root_hexdigest=7d16dfd6647864317c84b64ffd092069c8507f65 salt=f5db6aaf07f8653cd319eee1dd47e2f34be8a2272c27cd8823d15901f314c15c" noinitrd vt.global_cursor_default=0 kern_guid=f26d5cf9-8cbc-e74e-a721-4ba656b3bf72
Build Date: 05 November 2013  03:23:26PM
xorg-server 2:1.13.0-0ubuntu6.5~precise1 (For technical support please see http://www.ubuntu.com/support)
Current version of pixman: 0.30.2
Before reporting problems, check http://wiki.x.org
to make sure that you have the latest version.
Markers: (--) probed, (**) from config file, (==) default setting,
(++) from command line, (!!) notice, (II) informational,
(WW) warning, (EE) error, (NI) not implemented, (??) unknown.
(++) Log file: "/tmp/Xorg.crouton.1.log", Time: Thu Aug 20 12:12:16 2015
(==) Using system config directory "/usr/share/X11/xorg.conf.d"
Initializing built-in extension Generic Event Extension
Initializing built-in extension SHAPE
Initializing built-in extension MIT-SHM
Initializing built-in extension XInputExtension
Initializing built-in extension XTEST
Initializing built-in extension BIG-REQUESTS
Initializing built-in extension SYNC
Initializing built-in extension XKEYBOARD
Initializing built-in extension XC-MISC
Initializing built-in extension SECURITY
Initializing built-in extension XINERAMA
Initializing built-in extension XFIXES
Initializing built-in extension RENDER
Initializing built-in extension RANDR
Initializing built-in extension COMPOSITE
Initializing built-in extension DAMAGE
Initializing built-in extension MIT-SCREEN-SAVER
Initializing built-in extension DOUBLE-BUFFER
Initializing built-in extension RECORD
Initializing built-in extension DPMS
Initializing built-in extension X-Resource
Initializing built-in extension XVideo
Initializing built-in extension XVideo-MotionCompensation
Initializing built-in extension XFree86-VidModeExtension
Initializing built-in extension XFree86-DGA
Initializing built-in extension XFree86-DRI
Initializing built-in extension DRI2
Loading extension GLX
setversion 1.4 failed
crouton: version 1-20150811114815~master:f6b810fe
release: precise
architecture: armhf
xmethod: xorg
targets: unity
host: version 7077.134.0 (Official Build) stable-channel veyron_jerry
kernel: Linux localhost 3.14.0 #1 SMP Sun Aug 16 14:10:32 PDT 2015 armv7l armv7l armv7l GNU/Linux
freon: yes
No Chromium OS X server is available.
Running exit commands...
/usr/bin/xinit: connection to X server lost
waiting for X server to shut down Hangup
Server terminated successfully (0). Closing log file.
Unmounting /mnt/stateful_partition/crouton/chroots/precise...

@thatoneguy64 I think you are in the same boat as me.  I have to use xiwi in order to load in a window.
Load into your shell window and enter
sudo sh ~/Downloads/crouton -u -t xiwi -n precise
After all that finishes, try running your sudo startunity
Also, make sure you have the crouton extension installed on the chromebook side, just search for crouton in the web store.

nothing for crouton shows up on the web store

Ok.  Use this link for it then.

@thatoneguy64 crouton extension is hidden from search on the web store, so people don't think they can install crouton with installing the extension. You can find the extension on https://goo.gl/OVQOEt link should also be presented to you when finishing updating with xiwi or can be found in the README.md

@divx118 Thanks.  I didn't know it was hidden.

thanks guys

another question: what does it mean when it says
mv: cannot stat ‘/dev/dri/card1’: No such file or directory

You only need to do the rm and mv commands  when you reboot the chromebook.


Improve and test setproject cmd

It seems that the build on appveyor timed out... I don't know how to fix that...

On windows the subprocess doesn't get closed when the stdin is empty. Thus the tests that rely on the workon command are usually just skipped on windows.

I just put back the line you pointed out...
About the windows problem, I don't have a windows computer... so I can't work on that for now...

I have left some comments as a reminder to myself, I'll act upon them when merging

Thank you
I switched back setproject to have an implementation closer to the previous one. (while retaining things like support for relative project directories).


[Bug] Load order not saving

Load order is not saving across restarts of the application.  If I change it, it will save until I close and repoen

Hi this should be fixed now, sorry for not working on it for a long time


Add configuration for bypassing Auth even when enabled to allow API to be used with multiple frontends

#310


Add translated device info message

Currently, if you check an MEID/ICCID pair, it will just return the poc_swap_description. This means you get a successful response even if the ICCID is incompatible with the MEID. I'm adding a high level translation message to address that. We will display this from the Connect Portal.

👍

👍


Update third-party-support.md

Added live2d animation model.

Thanks but please add EN version also.


Work with s3-scrubber to clean up deleted timelines

Use https://github.com/neondatabase/s3-scrubber to clean up deleted branches.
Possibly for tenants that were moved after deletion being performed these branches can be attached. Consider removing them from pageservers themselves too.

Merging into #4263


Don't ask the user about autorestart in setup (disabled by default)

Description:
So people often check this option, but have invalid config, so AlexaPI crashes and keeps on restarting. This is not the case intended for the feature.
This removes the setup option and people who do want that can easily enable it. It's all described in the wiki, now in its own page - https://github.com/alexa-pi/AlexaPi/wiki/Restart-on-crashes
It removes only the question (and defaults to disabled), but leaves the underlying methods parameter, so it can be later used when doing non-interactive setup or something.
Checklist:

[x] Update CHANGELOG.md
[x] Update Wiki (new platform, installation, configuration changes etc)
[x] PR Location (usually master for hotfixes, dev for general development)

I don't really see the point in doing this. At least they know their program is having isssues.
If it only says hello once yo may be trying to say "Alexa" and get fustrated

Hmm ... that's true ...
It's not a standard daemon behavior though. The only point of this endless loop is to notify the user that the config (or something else) is wrong. Also, it will do two requests to Amazon every time it starts (one to check the internet connection and one to obtain the access token, which we will not store anywhere permanently with #138 and that will be requested every time AlexaPi starts up).

I like this change. When I first installed AlexaPi, I was puzzled by this question in setup: "Does that mean that program is so unstable, so it needs that special nudge to be stable enough? Or what? I better not enable this."
I think that it is better to leave such option for people who has crashing problem, hoping that this is small population.

My opinion is that the auto restart option should be removed.
AlexaPi has advanced significantly since I put that in there, and if there are instabilities with the code it can be addressed from a different angle than by restarting it with brute force.

Hm. So if we take this as a vote, we'll merge this.
Also, @dgonano you have a point that when you hear "hello", you expect that everything works. So, I've made a few changes:

it checks if the input_device is valid (which is the main problem why AlexaPi crashes) and prints valid devices (this is useful, I don't know why we weren't doing this a long time ago)
it plays the hello only after all synchronous setup operations are finished (which also is checking the input_device)

It looks like this:
renekl@piggy ~/workspace/AlexaPi (git)-[disable-autorestart-setup] % python2 src/main.py -d
2017-01-18 17:17:12 CRITICAL: Your input_device 'defaulta' is invalid. Use one of the following:
null
pulse
default
sysdefault:CARD=MID
front:CARD=MID,DEV=0

Is this okay?

Damn, the list isn't exhaustive, because you can address device as hw:x,y ... Okay, I'll rewrite it to make an attempt to open the device and if it doesn't work, let's just throw the damn exception with a meaningful message. We can then rewrite the mess when we use sounddevice instead of pyalsaaudio.

Yeah that last looks like a better approach to me :)

While you can address device by "hw:x,y", is that what comes to mind of person, who just installed AlexaPi to try it out? I think that result from alsaaudio.pcms(alsaaudio.PCM_CAPTURE) is what alsaudio recognizes as valid capture devices and we shall stick to those.
At the same time it would be good to provide override option in case user knows that the only way that works is to use "hw:x,y". In config with message that dragons are expected there. ;)

Ah, silly me! I thought we have a problem when we set device for CHIP like this, but we actually set the output_device, so no problem there.
We do have input_device: "plughw:1" in the config template though. I believe we should set it to default and let the people set something else if they want to.
Okay, let's try your idea @lechat :-) Sound good to me. I'll do that soon.

I've moved the input_device validation to #156, because it makes more sense.
This then:

doesn't do restart by default
indicates setup success (platform indication, playing hello) after all synchronous operations

I think I'm probably out of date on this one but from looking at the file changes it looks simple enough to approve.

Dope! Merging.


Add schema codegen command

I really wanted to use turms for this, but it turned out to be quite simple for us to implement via libcst 😊
TODO (maybe in other PRs):

[ ] Add support for custom schema directives
[ ] Add support for federation directives
[ ] Add support for Generic types when detecting relay connections (worth doing it I think :))

Apollo Federation Subgraph Compatibility Results

Federation 1 SupportFederation 2 Support

_service🟢@key (single)🟢@key (multi)🟢@key (composite)🟢repeatable @key🟢@requires🟢@provides🟢federated tracing🔲@link🟢@shareable🟢@tag🟢@override🟢@inaccessible🟢@composeDirective🟢@interfaceObject🟢

Learn more:

Apollo Federation Subgraph Specification
Compatibility Tests

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

This release adds support for generating Strawberry types from SDL files. For example, given the following SDL file:
type Query {
  user: User
}

type User {
  id: ID!
  name: String!
}

you can run
strawberry schema-codegen schema.graphql

to generate the following Python code:
import strawberry

@strawberry.type
class Query:
    user: User | None

@strawberry.type
class User:
    id: strawberry.ID
    name: str

schema = strawberry.Schema(query=Query)

Here's the tweet text:
🆕 Release (next) is out! Thanks to @patrick91 for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)


Prepare version 3.27.0

Added

Prepare backend to manage apps
Prepare frontend to manage apps
Add BBB backend app
Add BBB frontend app
Add configuration to filter app with feature flags
Start and stop a live
Add a form to create a scheduled video on the Dashboard
Add frontend components to register an email for scheduled webinars

Changed

Postpone AWS creation stack to the first live start action
Scheduled videos have a live_state set to IDLE
Allow access to videos with a scheduled date past

Fixed

Users with empty email in their token can register to scheduled webinars
Users with wrong email in token is properly detected as registered

Removed

check_live_idle management command
Remove validate_date_is_future validator on Video model

I will reopen it once we will be ready


Favored dependencies (readr, dplyr, signal, ...)

@wincowgerDEV, do you happen to know if read_table() is the only function you used from the readr package? If so, I'd suggest to use read.table() instead to limit dependencies a little:
https://github.com/wincowgerDEV/OpenSpecy/blob/f868ab5e79e354a2845a7d887e8ace7573a4d223/R/read_spectra.R#L37-L38

I guess, we're done here for now.


Include Schoendorff's seg-cc basis sets.

Closes #248

Codecov Report

Merging #250 (eb52217) into master (8b535a6) will decrease coverage by 4.04%.
The diff coverage is n/a.

@bennyp please merge asap


Get hints list for a given country

As a User
I need to get a list of hints about the given country  from the Source of Truth
So that I can make a guess based on given hints
Details and Assumptions

Source of Truth - Wikipedia country page
Hints are extracted from the key facts about the country on it's Wikipedia page, such as:

Size (value in sq. km and rank in the world)
GDP per capita (value in $ and rank in the world)
Population (value and rank in the world)
Population density (value in p./sq. km and rank in the world)
Establishment/Independence (year and from/of which country/countries)
Government type
Official religion (or abscence of it)
Currency
Official language
Capital

Acceptance Criteria
Given the collection of countries and it's Wikipedia pages URLs exists
When the desired country name is provided to a "Get hints" method
Then the method returns a collection of hints as key-value pairs { <hint_name>: <hint_value> }

Blocked by: https://github.com/JesusLike/wiki-guess-backend/issues/1


[CPP] Parquet Writer does not write Boolean values correctly

The core of the problem is due to https://github.com/apache/parquet-cpp/blob/master/src/parquet/encodings/plain-encoding.h#L203
The bit packing happens for every Write(). However, the packing is done at the byte level. If the number of (1-bit) values are not a multiple of 8, it results in padding incorrect values (false for boolean).
To reproduce: src/parquet/column/column-writer-test.cc
using TestBooleanValuesWriter = TestPrimitiveWriter<BooleanType>;
TEST_F(TestBooleanValuesWriter, AlternateBooleanValues) {
  this->SetUpSchema(Repetition::REQUIRED);
  auto writer = this->BuildWriter();
  for (int i = 0; i < SMALL_SIZE; i++) {
      bool value = (i % 2 == 0) ? true :  false;
      writer->WriteBatch(1, nullptr, nullptr, &value);
  }
  writer->Close();
  this->ReadColumn();
  for (int i = 0; i < SMALL_SIZE; i++) {
      ASSERT_EQ((i % 2 == 0) ? true :  false, this->values_out_[i]) << i;
  }
}

Reporter: Deepak Majeti / @majetideepak
Assignee: Uwe Korn / @xhochy
Related issues:

parquet-cpp 1.0.0 release (blocks)

Note: This issue was originally created as PARQUET-764. Please see the migration documentation for further details.

Wes McKinney / @wesm:
Issue resolved by pull request 185
https://github.com/apache/parquet-cpp/pull/185

Uwe Korn / @xhochy:
PR: https://github.com/apache/parquet-cpp/pull/185

Uwe Korn / @xhochy:
@majetideepak I'm going to have a shot at this.


Syntax error when i run script

Hi, can someone please help my with this syntax error?
/tmp/recover.sh: line 9: syntax error: unexpected newline
Thank you.

Hi, how are you running the script? Additionally, does the file name you’re providing contain any special characters?


Don't allow coloraxis to be referenced by id

After 462bfd606d8b799b725effe429bf75cf3973e5e0 it is not possible to reference coloraxis by id in Series.
I think we should just remove support for it now, and require coloraxis to be referenced from context.
The coloraxis can anyway be referenced from Series with:
<Series colorAxis="myColorAxis" />

So it's not a big deal.

Codecov Report

Merging #256 into master will decrease coverage by 18.37%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #256       +/-   ##
===========================================
- Coverage   89.86%   71.48%   -18.38%
===========================================
  Files          82       18       -64
  Lines        1026      249      -777
  Branches      195       45      -150
===========================================
- Hits          922      178      -744
+ Misses         91       63       -28
+ Partials       13        8        -5

Impacted Files
Coverage Δ

...-highcharts/src/components/WithHighcharts/index.js

.../src/components/HighchartsChart/HighchartsChart.js

...x-highcharts/src/components/Options3d/Options3d.js

...s/src/components/PlotBandLine/PlotBandLineLabel.js

...x-highcharts/src/components/UseHighcharts/index.js

...react-jsx-highcharts/src/components/YAxis/YAxis.js

...omponents/PlotBandLine/UsePlotBandLineLifecycle.js

.../components/Highcharts3dChart/Highcharts3dChart.js

...t-jsx-highcharts/src/components/Loading/Loading.js

...sx-highcharts/src/components/UseColorAxis/index.js

... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 495fa21...e5a5ebd. Read the comment docs.


Bandits

F1-measure code for chunking and the fixes to the factored encoder.

Was an accidental pull request

When I see commits like "fixes to make factor encoder work" or "new evaluator for the F1", I think you might consider making separate PRs with these features (we will be happy about it).

And GLEU, and METEOR, these are all great features, don't be shy ;-)

Sure, there's a lot of commits. We will re-organize the code a bit and then make separate pull requests for all the parts :)


Convert datepicker date to French

Hello the bookstore is great but would it be possible to put the dates in French starting with Monday instead of Sunday, but for the names it doesn't matter if we stay in English name just the succession of dates must start with Monday
Thanks

Hello the bookstore is great but would it be possible to put the dates in French starting with Monday instead of Sunday, but for the names it doesn't matter if we stay in English name just the succession of dates must start with Monday
Thanks


Attribute 'mathvariant="double-struck"' has no effect

mathml-to-latex version 1.2.0
<math><msup><mrow><mi mathvariant="double-struck">R</mi></mrow><mrow><mi>n</mi></mrow></msup></math>
This is converted to 'R^{n}'
It should be converted to '\mathbb{R}^{n}' or something similar.
https://developer.mozilla.org/en-US/docs/Web/MathML/Global_attributes/mathvariant
Thanks,
-Ryan

Implemented in #17
Thanks for the report


Clearing chat messages produces console error

Add some chat messages and then clear them. We get a console error and an unclear behavior in other clients concerning the bagde with the number of currently unread messages. Proposal: The bad should be set to zero and disappear.

Confirmed. The JS error is TypeError: Cannot read property 'id' of undefined.
Your proposal is ok for me but has a low priority for 2.1.


Unwated tag injection when mouse sits over suggest box

When the mouse pointer sits somewhere below the input field and you start typing, the suggested tag under the pointer gets injected immediately. This behaviour should only happen when the mouse is moving.

I tried to avoid hover on suggested items when we start typing and mouse pointer is just below the input, but this seems to be expected behavior of hover event.
The moment suggested items are appearing, hover event is getting triggered as mouse is just over those items.
If you have any solution for it, please let me know else I will close the issue.


Reverse winding order for negatively scaled models

Fixes https://github.com/CesiumGS/cesium/issues/6304 for ModelExperimental. I don't think it's possible to fix this in Model without significant changes.
Sets renderState.cull.face to either CullFace.FRONT or CullFace.BACK depending on whether the model matrix determinant is less than zero. This fixes rendering for models with negative scale like the box on the right.

Sandcastle using the model provided in https://github.com/CesiumGS/cesium/issues/6304. This checks that negative scaled primitives work on load and at runtime.

Thanks for the pull request @lilleyse!

:heavy_check_mark: Signed CLA found.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.

@ptrgags ready for another look

Looks good to me, thanks @lilleyse!


Menu bar always open in the main display

In a dual display setup, the IPFS Desktop menu bar works great if clicked in the main display:

But if clicked in the secondary display, it opens up in the main one, on the bottom right corner of the screen:

@hacdias can you check if this happens on windows too?

@fsdiogo those kind of icons (in the menubar) only show up on the main display on Windows so that problem doesn't exist here.

Hmm, ok.. I'll take a look then!

related issue from deep history https://github.com/ipfs-shipyard/ipfs-desktop/issues/586

the fix for this will probably be in hacdias/electron-menubar https://github.com/hacdias/electron-menubar/issues/2

Related, I expect. It's not that the menu always opens on the main display, but on my second screen it opens reliably on the left-middle.

Ref: https://github.com/electron/electron/issues/13461


Add a flag for debugging

Would be nice to log all commands that smug runs.
We can achieve it by injecting log.Logger interface in the commander.go. By default, we can write everything into ~/.config/smug/smug.log

--debug option has been added in v0.1.3


[CLI] Unable to update sift via Saltstack

When performing a 'sudo sift upgrade' I receive an error.
List of Failures (first 10 only)
NOTE: First failure is generally the root cause.
IMPORTANT: If opening a ticket, please include this information.
  - ID: undefined
    SLS: undefined
    Run#: undefined
    Comment: undefined

Log:
more /var/cache/sift/cli/v2020.2.1/saltstack.log
[DEBUG   ] Reading configuration from /etc/salt/minion
[DEBUG   ] Guessing ID. The id can be explicitly set in /etc/salt/minion
[DEBUG   ] Found minion id from generate_minion_id(): siftworkstation
[DEBUG   ] Configuration file path: /etc/salt/minion
[WARNING ] Insecure logging configuration detected! Sensitive data may be logged.
[DEBUG   ] Grains refresh requested. Refreshing grains.
[DEBUG   ] Reading configuration from /etc/salt/minion
[DEBUG   ] Please install 'virt-what' to improve results of the 'virtual' grain.
[DEBUG   ] Loading static grains from /etc/salt/grains
[DEBUG   ] Determining pillar cache
[DEBUG   ] LazyLoaded jinja.render
[DEBUG   ] LazyLoaded yaml.render
[DEBUG   ] LazyLoaded jinja.render
[DEBUG   ] LazyLoaded yaml.render
[DEBUG   ] LazyLoaded state.apply
[DEBUG   ] LazyLoaded saltutil.is_running
[DEBUG   ] LazyLoaded grains.get
[DEBUG   ] LazyLoaded config.get
[DEBUG   ] Popen(['git', 'version'], cwd=/etc/salt, universal_newlines=False, shell=None)
[DEBUG   ] Popen(['git', 'version'], cwd=/etc/salt, universal_newlines=False, shell=None)
[DEBUG   ] Updating roots fileserver cache
[DEBUG   ] Gathering pillar data for state run
[DEBUG   ] Determining pillar cache
[DEBUG   ] LazyLoaded jinja.render
[DEBUG   ] LazyLoaded yaml.render
[DEBUG   ] Finished gathering pillar data for state run
[INFO    ] Loading fresh modules for state activity
[DEBUG   ] LazyLoaded jinja.render
[DEBUG   ] LazyLoaded yaml.render
[DEBUG   ] Could not find file 'salt://undefined.sls' in saltenv 'base'
[DEBUG   ] Could not find file 'salt://undefined/init.sls' in saltenv 'base'
[DEBUG   ] LazyLoaded yaml.output
local:

No matching sls found for 'undefined' in env 'base'

Ubuntu 18.04 upgraded from 16,04. I upgraded via dist because I have a complex install with a cuckoo sandbox environment. Any help would be appreciated.
Attempted:

Reinstall of SaltStack
recreate saltstack minion
all permissions checked
repos reloaded

Send me the contents of /etc/os-release

@ekristen
$ more /etc/os-release
NAME="Ubuntu"
VERSION="18.04.4 LTS (Bionic Beaver)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 18.04.4 LTS"
VERSION_ID="18.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic

UPDATE
I downgraded to CLI 1.8.1. No change.

Please go back to 1.8.3 and provide me the full output of the CLI as well as the salt stack log file; clearly something is not being detected properly

@ekristen Thank you for the support. Its been a struggle to keep missing out on the SIFT updates since 2018.
[CLI]
<EMAIL_ADDRESS>sift-version: v2018.16.0
downloading v2020.2.1
downloading sift-saltstack-v2020.2.1.tar.gz.asc
downloading sift-saltstack-v2020.2.1.tar.gz.sha256
downloading sift-saltstack-v2020.2.1.tar.gz.sha256.asc
downloading sift-saltstack-v2020.2.1.tar.gz
validating file sift-saltstack-v2020.2.1.tar.gz
validating signature for sift-saltstack-v2020.2.1.tar.gz.sha256
extracting update sift-saltstack-v2020.2.1.tar.gz
performing update v2020.2.1
Log file: /var/cache/sift/cli/v2020.2.1/saltstack.log
Incomplete due to Failures -- Success: 0, Failure: 1
List of Failures (first 10 only)
NOTE: First failure is generally the root cause.
IMPORTANT: If opening a ticket, please include this information.
ID: undefined
SLS: undefined
Run#: undefined
Comment: undefined
SALTLOG (appears to be same as prior)
[DEBUG   ] Reading configuration from /etc/salt/minion
[DEBUG   ] Using cached minion ID from /etc/salt/minion_id: siftworkstation
[DEBUG   ] Configuration file path: /etc/salt/minion
[WARNING ] Insecure logging configuration detected! Sensitive data may be logged.
[DEBUG   ] Grains refresh requested. Refreshing grains.
[DEBUG   ] Reading configuration from /etc/salt/minion
[DEBUG   ] Please install 'virt-what' to improve results of the 'virtual' grain.
[DEBUG   ] Loading static grains from /etc/salt/grains
[DEBUG   ] Determining pillar cache
[DEBUG   ] LazyLoaded jinja.render
[DEBUG   ] LazyLoaded yaml.render
[DEBUG   ] LazyLoaded jinja.render
[DEBUG   ] LazyLoaded yaml.render
[DEBUG   ] LazyLoaded state.apply
[DEBUG   ] LazyLoaded saltutil.is_running
[DEBUG   ] LazyLoaded grains.get
[DEBUG   ] LazyLoaded config.get
[DEBUG   ] Updating roots fileserver cache
[DEBUG   ] Gathering pillar data for state run
[DEBUG   ] Determining pillar cache
[DEBUG   ] LazyLoaded jinja.render
[DEBUG   ] LazyLoaded yaml.render
[DEBUG   ] Finished gathering pillar data for state run
[INFO    ] Loading fresh modules for state activity
[DEBUG   ] LazyLoaded jinja.render
[DEBUG   ] LazyLoaded yaml.render
[DEBUG   ] Could not find file 'salt://undefined.sls' in saltenv 'base'
[DEBUG   ] Could not find file 'salt://undefined/init.sls' in saltenv 'base'
[DEBUG   ] LazyLoaded yaml.output
local:

No matching sls found for 'undefined' in env 'base'

I need this file please /var/cache/sift/cli/v2020.2.1/saltstack.log

@ekristen the SALTLOG above is the output. Apologies for the confusion.

I believe I’ve figured out what’s going on, just not sure why. Working on a fix

@ekristen Copy, thanks!

try -- https://github.com/teamdfir/sift-cli/releases/tag/v1.8.4

$ sudo sift upgrade
<EMAIL_ADDRESS>sift-version: v2018.16.0
downloading v2020.2.1
downloading sift-saltstack-v2020.2.1.tar.gz.asc
downloading sift-saltstack-v2020.2.1.tar.gz.sha256
downloading sift-saltstack-v2020.2.1.tar.gz.sha256.asc
downloading sift-saltstack-v2020.2.1.tar.gz
validating file sift-saltstack-v2020.2.1.tar.gz
validating signature for sift-saltstack-v2020.2.1.tar.gz.sha256
extracting update sift-saltstack-v2020.2.1.tar.gz
performing update v2020.2.1
Log file: /var/cache/sift/cli/v2020.2.1/saltstack.log
Update returned exit code not zero
Error: Update returned exit code not zero
at ChildProcess. (/snapshot/sift-cli/sift-cli.js:529:23)
at ChildProcess.emit (events.js:196:13)
at maybeClose (internal/child_process.js:1011:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:268:5)
Log:
more /var/cache/sift/cli/v2020.2.1/saltstack.log
[DEBUG   ] Reading configuration from /etc/salt/minion
[DEBUG   ] Using cached minion ID from /etc/salt/minion_id: siftworkstation
[DEBUG   ] Configuration file path: /etc/salt/minion
[WARNING ] Insecure logging configuration detected! Sensitive data may be logged.
[DEBUG   ] Grains refresh requested. Refreshing grains.
[DEBUG   ] Reading configuration from /etc/salt/minion
[DEBUG   ] Loading static grains from /etc/salt/grains
[DEBUG   ] Determining pillar cache
[DEBUG   ] LazyLoaded jinja.render
[DEBUG   ] LazyLoaded yaml.render
[DEBUG   ] LazyLoaded jinja.render
[DEBUG   ] LazyLoaded yaml.render
[DEBUG   ] LazyLoaded state.apply
[DEBUG   ] LazyLoaded direct_call.execute
[DEBUG   ] LazyLoaded saltutil.is_running
[DEBUG   ] LazyLoaded grains.get
[DEBUG   ] LazyLoaded config.get
[DEBUG   ] key: test, ret: _|-
[DEBUG   ] Updating roots fileserver cache
[DEBUG   ] Gathering pillar data for state run
[DEBUG   ] Determining pillar cache
[DEBUG   ] LazyLoaded jinja.render
[DEBUG   ] LazyLoaded yaml.render
[DEBUG   ] Finished gathering pillar data for state run
[INFO    ] Loading fresh modules for state activity
[DEBUG   ] LazyLoaded jinja.render
[DEBUG   ] LazyLoaded yaml.render
[DEBUG   ] Could not find file 'salt://undefined.sls' in saltenv 'base'
[DEBUG   ] Could not find file 'salt://undefined/init.sls' in saltenv 'base'
[DEBUG   ] LazyLoaded yaml.output
local:

No matching sls found for 'undefined' in env 'base'

I did do an update prior. Nothing to autoremove or update. Is it possible im missing a repository?

Try adding —mode=desktop

Same errors/outputs.
I also tried manually installing the specific version as per the help, but it just returns the usage page.

I found the bug.

https://github.com/teamdfir/sift-cli/releases/tag/v1.8.5

Possible progress. Updated using sift upgrade --mode=desktop. A large number of updates appeared to run, even received new posters. Ended with the error below. May have updated, but "sift version" does not indicate it.
Event error:
Running: sift-config-tools
Update returned exit code not zero
Error: Update returned exit code not zero
at ChildProcess. (/snapshot/sift-cli/sift-cli.js:529:23)
at ChildProcess.emit (events.js:196:13)
at maybeClose (internal/child_process.js:1011:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:268:5)
cuckoo@siftworkstation: ~
$ sift version
<EMAIL_ADDRESS>sift-version: v2018.16.0
mode: complete
Log much larger. I have attached it.
saltstack.log

@brendancarey33 honestly the scenario of 16.04 -> 18.04 hasn't been tested. It looks like there are just a lot of general failures to upgrade packages, this could be for a number of reasons outside the control of me and SIFT and the tooling.
I would start by running apt-get update && apt-get upgrade manually and make sure apt is healthy and happy and everything is up-to-date. After that you can try running sift upgrade again.
The SIFT cli is a simply proxy for running saltstack to configure the host properly, 90% of the configuration is just apt-get install commands.

@ekristen Copy. I did notice when I ran apt-get update//upgrade a lot of things did update. Hopefully, I can help figure it out. Let me know if you'd still like bug reports pertaining to this, otherwise, I can keep awaiting new CLI updates and see if something clicks later on.

@ekristen @brendancarey33 I came across the error that's listed in the saltstack yesterday, and it came about because I already had rekall installed. I did a pip uninstall rekall -y, then rm /usr/local/bin/rek* then sudo sift upgrade and there was no issue.
The issue listed in the saltstack log said it was unable to create the symlink for rekall, likely because the binaries already existed in the /usr/local/bin directory.
That's what fixed the particular issue you're seeing at this point.

@Fetchered I tried that, got reminded I didn't have it installed. However, looked like a possible issue with lvm2, force uninstalled and attempted to sift upgrade. It ran through and ended with the exit code error previously identified. I'm starting to wonder if it IS in fact upgraded, but the CLI output is not upgrading due to a cache issue. Thanks for the tip, I think your on to something.

The /etc/sift* files are what tracks the "installation" part of it. Another thought might be to rename them to ".old", fix the rekall binaries (above) and then do a sudo sift install.

Thanks for all the help, but I think its deep somewhere and not likely identified. I downgraded to 1.8.5 (I was not getting this on a working 1.8.6 master by @ekristen) I got a stop on "sift-config-tools" so I tried your rekall technique but no go. see below. I think its just not going to work from an upgrade from 16.04.
Update returned exit code not zero
Error: Update returned exit code not zero
at ChildProcess. (/snapshot/sift-cli/sift-cli.js:529:23)
at ChildProcess.emit (events.js:196:13)
at maybeClose (internal/child_process.js:1011:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:268:5)

If you take a look in the saltstack.log file and do a search for 'result: false' (not the space between the colon and false), you'll see where the failure is. You might see it three or four times, likely all centered around rekall or python.
It is possible to upgrade from 16.04, I've done it before, it just takes a little finessing at times. If you want to submit your saltstack.log from this go 'round, I can take a quick peek as well.

Thanks @Fetchered for helping out! I definitely need the saltstack.log to pinpoint what's failing.

@ekristen @Fetchered I should clarify, I am unsure of the challenges of upgrading with a cuckoo user/sandbox setup. too many variables between them I think. However, please see my saltlog below.
saltstack.log

Apologies for not getting back to you sooner, I let this get away from me (I am/was Fetchered). @brendancarey33 Your installation issue primarily only seemed to be rekall, and it appeared that since rekall was already installed on your system, the SIFT installer was unable to create a symlink in the optimal location, because a file with the intended destination already existed.
If you're still in the same situation, you can uninstall or manually remove the rekall binaries (symlinks) from /usr/bin or /usr/local/bin and run the installer again (not the desired method).
However, I would recommend downloading the newest cli and running the install again, and this time try using the --pre-release option to see if this fixes some of your issues. The final issue located at the end of the saltstack.log file about not finding a pip binary should be resolved by both the newest CLI and the --pre-release option.
Cheers

I appreciate the support @digitalsleuth! I will apply fixes and promptly report. As someone who makes about %15 of their income off this suite, I knew I was safe with all the support from you and @ekristen, but felt uneasy at times. I will reply soon with fix results.

@digitalsleuth Tried both the update and the --pre-release tag (as well as other modes) and I am still getting some sort of error. It appears the log is quite a bit larger than previously, so I was unable to try and find the issue myself or see if it was still due to rekall. Again, I appreciate any help (knowing I should just operate on a new install), but my cuckoo config is just so bloated I cant separate them. I have attached the log if it is of any value. (I ran both scenarios
as sansforensics and cuckoo users)
saltstack.log

Got the log, but not at a computer at the moment. Will reply when I get home. Cheers.

There's a new pre-release out too. We've been suffering a lot of python issues unfortunately and still have not tracked down the root cause. Something that works perfectly for @digitalsleuth doesn't work for me and visa-versa.
Appreciate the assist @digitalsleuth

I get hung up on "Running: cpan install HTML::QuickTable" when trying updates. FYI

@brendancarey33 We've identified the issue with the cpan install command. It should be fixed in the next release.

@brendancarey33 the pre-release is working at the moment

https://github.com/teamdfir/sift-saltstack/releases/tag/v2020.7.0 -- with fixes above.


feat: Select all for synchronous select

SUMMARY

This PR adds a 'select all' functionality to the synchronous Select component. This functionality has been requested by a large number of users and contributors. The select component has been previously split into sync and async components to simplify the code. The sync select component is the more widely used component, and a select all for the sync case is much easier to implement. This PR simply adds the option for selectAllEnabled only when the select component is in multi-select mode. The option is by default set to false. This is part of the greater task to rework the select component for the select all functionality outlined by @michael-s-molina in this PR: https://github.com/apache/superset/pull/20143
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

In storybook, go to the select component -> interactive select and set the mode to multi and selectAllEnabled to True
ADDITIONAL INFORMATION

[x] Has associated issue: https://github.com/apache/superset/discussions/18247#discussioncomment-2467080
[ ] Required feature flags:
[x] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@cccs-RyanK any news about this PR?

/testenv up

Hi @cccs-RyanK. Thank you for this PR!
Can we try to use 'Select All' in columns, table viz? Or it'll be next PR?

When allowNewOptions is enabled, if you add a new option and remove it, "Select All" will be unchecked.
https://user-images.githubusercontent.com/70410625/207110358-091b7ad9-591b-44a5-a0ba-0891756b56ba.mov

Not sure if this was discussed before, but I disagree with the choice of showing the number of items selected when "Select all" is checked and the plain items with the +X when the "Select all" is unchecked. I tend to believe we should always be showing the plain items that fit and the +X which is the default behaviour independently of whether the "Select all" option is checked to avoid the sudden change shown in the video and for consistency reasons
https://user-images.githubusercontent.com/60598000/207359271-47b47db1-f853-4362-b2c4-7170152b7931.mp4
When clearing the "Select all" from the options, the dropdown shows up. I think it shouldn't as the user intends to clear the selection and not to choose other options necessarily. Additionally, if you look at the video you will see that the dropdown in not positioned vertically in the correct way for a moment
https://user-images.githubusercontent.com/60598000/207360266-810a2b6a-9c6f-4033-b3ce-dc10085b93ae.mp4
When allowNewOptions is enabled if you add a new option, such as "test" shown in the video and you select it an unselect it, it's gone from the list (as shown in the video).
https://user-images.githubusercontent.com/60598000/207360792-50cf73b8-8fc4-4698-b6be-10b355983931.mp4
If you create multiple ones and uncheck "Select all", all of them will be gone
https://user-images.githubusercontent.com/60598000/207361806-5243f9b0-9699-4509-8a7f-7b01fa97b497.mp4

When allowNewOptions is enabled If you create multiple options and uncheck "Select all", all of the newly created options will be erased. This should not be the case
Select.-.Interactive.Select.Storybook.3.mp4

Thanks for the feedback @geido ! Made the suggested changes from your first two points. As for the last point you made about the new options being erased when they are deselected, I do think that this behaviour is consistent with how the component currently works. For example, before the select-all changes if you add new values by themselves and then deselect them, they are erased from the options. My thoughts are that deselecting-all should then also remove all the new options. Please let me know if that makes sense to you.

Hi @cccs-RyanK! This PR is important for us. Any news when we can merge it?

FYI @cccs-RyanK @EugeneTorap this is on my priority todo list, and I'm hoping to give it a proper review+test pass this weekend.

Thanks for the feedback @geido ! Made the suggested changes from your first two points. As for the last point you made about the new options being erased when they are deselected, I do think that this behaviour is consistent with how the component currently works. For example, before the select-all changes if you add new values by themselves and then deselect them, they are erased from the options. My thoughts are that deselecting-all should then also remove all the new options. Please let me know if that makes sense to you.

@cccs-RyanK @geido I think we should disassociate the uncheck and remove actions on new items. We could have an X icon to remove new items. I can think of a scenario where a user is adding filters to a chart and after seeing the results, the user can check/uncheck the added filters to test different combinations. Making the remove action more intentional will improve UX. Let's tackle this in a separate PR. For now, I'm fine with removing all items when Select All is unchecked.

When working in oneLine mode, it's counting the Select All option.
https://user-images.githubusercontent.com/70410625/211862341-565316ce-bffa-42bc-8a99-f072d5908782.mov

@cccs-RyanK and @michael-s-molina I was wondering whether this feature could be configurable, especially as it pertains to SQL Lab. For example at Airbnb we have schemas which house thousands of tables/views (see attachment) and if the user accidentally chooses the Select All option`  SQL Lab will implode.
It's unclear if this option really has any value in the context of SQL Lab, i.e., whether one would ever needs to see the schema for all the tables/views as opposed to selecting the subset to entities they're interested in.

I agree with @michael-s-molina , let's disable it in that particular context.


Handle TODOs in Random Beacon tests

This PR handles TODOs that were left in the Random Beacon tests.

@nkuba
There is one more TODO in tests:
https://github.com/keep-network/keep-core/blob/8e3689ba3aeb9a5d08a71c79282c521f85ee1d2b/solidity/random-beacon/test/Groups.test.ts#L599
I'm not entirely sure what the purpose of that TODO is, but I think we could get rid of it.
I think we test everything there is to test about activateCandidateGroup in that testcase.

@nkuba There is one more TODO in tests:
https://github.com/keep-network/keep-core/blob/8e3689ba3aeb9a5d08a71c79282c521f85ee1d2b/solidity/random-beacon/test/Groups.test.ts#L599
I'm not entirely sure what the purpose of that TODO is, but I think we could get rid of it. I think we test everything there is to test about activateCandidateGroup in that testcase.

Good catch @tomaszslabon ! I removed the TODO.

I don't have any further comments, just wanted to ask somebody (e.g. @pdyraga) if calling genesis is the proper way to restart DKG after DKG timeout notification.

@nkuba I think we could merge it. We just need to resolve the conflicts.


[MM-20590] Migrate 'components/interactive_dialog/dialog_element' module and associated tests to TypeScript

Summary

This migrates the components/interactive_dialog/dialog_element component in the webapp to TypeScript. I've used the apps_form_field component as a reference and the trickiest part was that I coudn't avoid using type assertions for the value prop.
Ticket Link

Fixes https://github.com/mattermost/mattermost-server/issues/13482
JIRA: https://mattermost.atlassian.net/browse/MM-20590

Release Note

NONE

Hello @LSantos06,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @jfrerich @emilyacook

@levb Gentle ping to review this :)

cc @mickmister

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @jfrerich @emilyacook

@DHaussermann Gentle ping to review :)


Remove Asset and AssetLink

Fixes #974.
Moves some of the on-create validation to other model's init's and the one remaining static method to Transaction (where, arguably, it fits better).

Current coverage is 96.08% (diff: 95.00%)

Merging #982 into master will decrease coverage by 0.13%

@@             master       #982   diff @@
==========================================
  Files            35         35
  Lines          1827       1789    -38
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           1758       1719    -39
- Misses           69         70     +1
  Partials          0          0

Powered by Codecov. Last update 3a7fe30...4dfa80c

In the end moving the types and amount validation code simplified the code 👍


tensorflow lite x64 minimal build

i do all intruction that described in this link https://github.com/tensorflow/tensorflow/tree/master/tensorflow/lite/examples/minimal
i success build tensorflow lite, but its win32
how to change to x64

@terryheo could you take a look?


Lifecycle binding

in CameraFragment you call
CameraX.bindToLifecycle(this, preview, imageCapture, imageAnalyzer)

meaning you bind it to fragment's lifecycle. But you call this method on onViewCreated() which means you would receive the old lifecycleOwner. To avoid crashing you every time also call CameraX.unbindAll() which is some sort of work around.
Instead it would be better to call CameraX.bindToLifecycle() with viewLifecycleOwner. Then you can delete CameraX.unbindAll()
Thus, it seems like you have misused fragment's lifecycle with view's lifecycle. Correct me I am wrong.
Thanks

I'm not sure what you mean by "the old lifecycleOwner". The current sample is using the fragment's lifecycle, which usually is the same as the view's lifecycle except CameraFragment sets the retainInstance flag.
By attaching CameraX to the fragment lifecycle, we avoid CameraX being fully torn down (and thus closing the camera) upon config changes like rotation. The intent is to allow for CameraX to maintain some of its state by doing: CameraX.unbindAll() → CameraX.bindToLifecycle(), which happens during onViewCreated.
By using the view's lifecycle, the order of events is: CameraX *teardown* → CameraX *initialize* → CameraX.bindToLifecycle(). However, I just tested this and it seems that this results in snappier transitions during device rotations on a Pixel 3 device. I'm guessing it's due to the teardown starting as the view gets destroyed, rather than doing everything during onViewCreated.
I will investigate the potential implications of switching to the view's lifecycle. It's likely that devices with slow camera open/close will have degraded performance using this path. We have to take into consideration other things such as navigation, multi-window environments, etc.

Could you please explicitly specify where CameraX *initialize* happens?

CameraX initialization is not triggered by app code. Some of it happens upon app startup, some of it when the first use case is bound. It's up to the CameraX library and subject to change in the future.

Then, returning to original question, it seems that if you would bind to fragment's lifecycle the call stack is
CameraX *initialize* → CameraX.unbindAll() → CameraX.bindToLifecycle() → (rotate) → CameraX.unbindAll() → CameraX.bindToLifecycle()
While with viewLifecycleOwner it is
CameraX *initialize* → CameraX.bindToLifecycle() → (rotate) →  CameraX.bindToLifecycle()
The main concern is when you doing CameraX.unbindAll() the concept of lifecycle awareness is lost since you bind and unbind it each time manually.

While with viewLifecycleOwner it is
CameraX initialize → CameraX.bindToLifecycle() → (rotate) → CameraX.bindToLifecycle()

I don't think this is entirely true. I'm counting camera open as CameraX *initialize* although maybe I'm not making things very clear. Essentially, by binding to the view's lifecycle, we will be closing and reopening the camera every time we rotate. Whereas binding to the fragment's lifecycle we can even keep some use cases bound across config changes (which we aren't doing yet).

The main concern is when you doing CameraX.unbindAll() the concept of lifecycle awareness is lost since you bind and unbind it each time manually.

That's fair feedback, although only partly true. We are just making sure that no other use cases are bound, which is not necessarily a bad practice but, as you say, it kinda defeats the point of making everything lifecycle-aware.
As I said earlier, we will investigate switching to using the view's lifecycle as the owner. Personally, assuming there are no major drawbacks, I think it would be the right choice. It simplifies the code and sets a good example for developers to follow. Otherwise, we are chasing diminishing returns for a slight performance gain, whereas some of the optimizations could be done by CameraX itself. For example, CameraX could wait a bit to close the camera during a config change, since it's likely that an app will bind the same use cases and open the same camera again.

Thank you for your response. I close the issue but pls ping me if there would be any updates on this


Sort Schema and Add CloudFormation Resources

Overview

Description:

I've arranged the JSON properties to be more readable.
Implemented the reference to AWS Labs CloudFormation for the serverless References property.

Schema update type: extended
Services affected:

How was this tested?
I have installed YAML for VSCode on my computer, then I have referenced the schema with the configuration: "yaml.schemas" and I have verified in the serverless.yaml and serverless.yml file that the "Resources" property is correctly loading the resources from AWS Labs CloudFormation.

I can't even open the diff on github, I'd need some time to view this, will hold merge till then

Can't go through 40K line changes, please wait for us to split the schema across multiple files before this can be looked at?
Could you try explaining what you did? I tried going through the diff but as I said, it's too many changes.
Watch #80 before we proceed.

@lalcebo I'd like to see what your view is on this.

@arcaela Do not apply style to the schema at the same time you introduce changes. It's hard to see what you added new, especially since you applied format the whole file.


Add pre-commit and lint

Now that we have pre-commit setup in gufe we should follow the example and happy it here!

It probably would be best to let @atravitz set the org standard for linting before we go ahead and do it for all the repos.
I guess that I'm saying here @jthorton is, if it's not blocking you, I'd wait a bit on this (unless @atravitz is happy to go ahead with the current status in gufe).

I'm in favor of this but want to make some decisions up front first! We went ahead with a "something is better than nothing" approach in gufe, but I want to audit it a bit before applying things project-wide.
@jthorton - please let me know if you have any strong preferences about what linting standards we use!

No problem, I am happy to wait, my only request is black!


Protocols and ports are the wrong way round in the first table

Protocols and ports are the wrong way round in the first table

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6e20ba5e-787f-63d2-b6e2-822b14788ad1
Version Independent ID: 5a0ce135-f88d-a490-48bb-356147c8a76e
Content: Use Azure Firewall to protect Azure Virtual Desktop
Content Source: articles/firewall/protect-azure-virtual-desktop.md
Service: firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

@PlanetWilson, Thanks for reaching out. We will investigate and update this thread.


bpf_loop Dependency Causes Errors in Kernel Versions < 5.17 When Extending TCP Payload with extend_skb Hook

extend_skb hook extends the TCP payload. When writing new additional data to the payload, the bpf_loop function is used, but this function only exists in kernel versions greater than 5.17.
https://github.com/grafana/beyla/blob/d2a8a83184949ed8d0b4766d421a1bdaef0829ac/bpf/tc_http_tp.c#L402-L407
If we enable BEYLA_BPF_TC_L7_CP:true and use a kernel version lower than 5.17, an error occurs.
Considering that the current long-term versions include 5.15, 5.10, 5.4, and 4.19, this issue should be considered a bug and needs to be addressed.

By the way, I've already discussed this with @grcevski  on Slack. To prevent others from encountering the same issue, I'm leaving a backup here. Please feel free to close this issue if it has been resolved.

Hi @tomatopunk, thanks for bringing this up. Yeah, unfortunately the dependency on bpf_loop hinders us a bit, we will try to do without it in a few places, but in this particular case it's really not feasible.
If you look here, you will see that we do print out an error, but we are missing a return, which causes us to still try to load the http tracer and fail with a big kernel verifier error message (which I assume is what you are seeing). If you feel like, you can raise a PR adding a return statement there, so that the error message becomes more evident, and I can review it, or if you prefer, I can raise it myself as well.
I also wanted to note that BEYLA_BPF_TC_CP now also supports L7 context propagation. This is all new functionality that needs further testing, but all things going according to plan, we may elect to remove BEYLA_BPF_TC_L7_CP altogether and make BEYLA_BPF_TC_CP the canonical way of doing it.
Another thing I'd like to point out in case it helps, is that RedHat based kernels tend to have all of these functionalities (such as bpf_loop and other eBPF related patches) backported.

Hello team,
I completely agree with your point: bpf_loop and other patches should be ported. However, this function is a 2017 patch with no clear plan for porting. Therefore, I think that if we decide to use bpf_loop, we should highlight this issue more prominently, such as including the minimum kernel version in the documentation.
Furthermore, the dependency on bpf_loop isn't just here. For example, in #1413, unfortunately, there's also an edge-back issue when searching for the traceparent header, which might require using bpf_loop. Internally, what is our view on such issues? Should we strive for compatibility or abandon it, setting 5.17 as the minimum kernel version?


Record hauls last update

Closes #106 - coincides with file update.

The area swept is weirdly low for 2023 but confirmed that the raw CSV exports from https://www.fisheries.noaa.gov/foss/f?p=215:28:2900984441213::::: show the same. So, merging this in for now but may need to update again later. Will hold on updating the visualization for a moment.


fix: bug in the idiom

fixes #20
Screenshots

Checklist:

[x] the language matches the copy and go button text in the page 1.
[x] the language matches the initials of the date in the page 1.

@mdibuhossain please, solve conflicts to merge


Hello, I have implement this library in my app and its working nice, but when I am uploading my app to google play store , I have received a Email, which consider this line: "We wanted to let you know that your application is statically linking against a version of OpenSSL that has multiple security vulnerabilities for users. Please migrate your app to an updated version of OpenSSL by Jul 7, 2015. ". Please advice me what to do for this.

Hello, could you please describe, what features of the Media for Mobile library do you use in your application? We are going to open source Media for Mobile around April'16.

yeah sure, I have implement video trimming from that library.

Thanks. OpenSSL library won't be required for video trimming functionality.

but I found that , error is becoming from libippresample.so , this is using openssl, may be.
because if i have remove this its works properly.

It's strange, libippresample.so shoudn't use Openssl.
Openssl is used only by AudibleMagic plugin. If you don't use AudibleMagic, then you can simply exclude libssl.so library from your project.

Hey thankx, solved my problem. thank you very much

I have same problem. Please help me fix it?
Thank so much!

Hey,
tell me your problem
Khyati
-----Original Message-----
From: "DanhDue ExOICTÌ"<EMAIL_ADDRESS>Sent: 28-04-2016 01:27 PM
To: "INDExOS/media-for-mobile"<EMAIL_ADDRESS>Cc: "khyatiChitroda"<EMAIL_ADDRESS>"Author"<EMAIL_ADDRESS>Subject: Re: [INDExOS/media-for-mobile] Hello, I have implement this libraryin my app and its working nice, but when I am uploading my app to google playstore , I have received a Email, which consider this line: "We wanted to letyou know that your application is statically linking against a version ofOpenSSL that has multiple security vulnerabilities for users. Please migrateyour app to an updated version of OpenSSL by Jul 7, 2015. ". Please advice mewhat to do for this.  (#16)
I have same problem. Please help me fix it?
Thank so much!
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

I have implement this library for my app. I have removed libssl.so library because I don't use it.
But when I publish my app to Google Play, they reject it with reason:
This app uses software that contains security vulnerabilities for users. Below is the list of vulnerabilities and the corresponding APK versions that were detected in your recent submission. Please upgrade your app(s) as soon as possible and increment the version number of the upgraded APK.
Vulnerability: OpenSSL
APK Version(s): 1
The vulnerabilities were fixed in OpenSSL versions beginning with 1.0.1h, 1.0.0m, and 0.9.8za. To confirm your OpenSSL version, you can do a grep via:
$ unzip -p YourApp.apk | strings | grep "OpenSSL"
You can find more information and next steps in this Google Help Center article.
Please help me fix it!
Thank so much!

Remove audiblemagic lib
-----Original Message-----
From: "DanhDue ExOICTÌ"<EMAIL_ADDRESS>Sent: 28-04-2016 03:18 PM
To: "INDExOS/media-for-mobile"<EMAIL_ADDRESS>Cc: "khyatiChitroda"<EMAIL_ADDRESS>"Author"<EMAIL_ADDRESS>Subject: Re: [INDExOS/media-for-mobile] Hello, I have implement this libraryin my app and its working nice, but when I am uploading my app to google playstore , I have received a Email, which consider this line: "We wanted to letyou know that your application is statically linking against a version ofOpenSSL that has multiple security vulnerabilities for users. Please migrateyour app to an updated version of OpenSSL by Jul 7, 2015. ". Please advice mewhat to do for this.  (#16)
I have implement this library for my app. I have removed libssl.so library because I don't use it.
But when I publish my app to Google Play, they reject it with reason:
This app uses software that contains security vulnerabilities for users. Below is the list of vulnerabilities and the corresponding APK versions that were detected in your recent submission. Please upgrade your app(s) as soon as possible and increment the version number of the upgraded APK.
Vulnerability: OpenSSL
APK Version(s): 1
The vulnerabilities were fixed in OpenSSL versions beginning with 1.0.1h, 1.0.0m, and 0.9.8za. To confirm your OpenSSL version, you can do a grep via:
$ unzip -p YourApp.apk | strings | grep "OpenSSL"
You can find more information and next steps in this Google Help Center article.
Please help me fix it!
Thank so much!
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

Thanks so much!

Adding a little more detail to the point above.
This can also be accessed in the Preferences > Editor > General > Auto Import
-Section is called"Exclude from Imports and Completion"
(Add the following and compile)
--AudioContentRecognition.java
--IRecognitionPlugin.java


codein

Why do you want to join?
love to be part of the community. I have been very lucky that this community exists and love to see how i can contribute.
Which project(s) are you looking to contribute to?
wagtail
Code of Conduct

[X] I agree to follow Django Commons's Code of Conduct

Welcome Robin! 🫶

Thank you for joining!


Fixed relative path to network.json

Thanks for the contribution! However, this is a read-only mirror. please read the contribution guide. Also, feel free to join us on chat!


[USMON-1140] Harden TLS handshake classification

What does this PR do?
Hardens TLS handshake classification.

Converts TLS version to the host byte order (instead of network byte order)
Verifies the TLS version in the record header is a valid version
Verifies the TLS version in the hello message (client or server) is greater or equal to the version in the TLS record header.
Verifies the TLS hello message length equals to the TLS record header length minus 4 (the size of the handshake size and the length of the hello message buffer).
Verifies the TLS record length didn't exceed the maximum allowed by the RFC (2^14-1)

Motivation
Removing false negatives.

Additional Notes
Following the RFC https://datadoghq.atlassian.net/wiki/spaces/UT/pages/3954869126/Internal+RFC+Protocol+Classification+-+Harden+TLS+socket+filter+classification

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Did you test those changes to validate that there is no impact on TLS support for different protocols using the load test or by deploying to staging?

Did you test those changes to validate that there is no impact on TLS support for different protocols using the load test or by deploying to staging?

yes, ran on staging clusters over the last day

/merge


why do resnet image feature model use a fixed att_size?

Hello, really thanks for building such an awesome codebase. However, I noticed that the resnet model for image feature extraction in misc/resnet_utils.py used a fixed att_size equals 14 which should be possibly variable as mentioned in the topdown paper. Is this a reasonable option for att_size or an unsolved problem?

oh...it's not the bottom-up feature you provide, i'm sorry i didn't read the README.md carefully. Thanks for your work.


Add resolv.9 to c-ares linkopts

Without this upstream iOS builds fail to link
Undefined symbols for architecture x86_64:
  "_res_9_getservers", referenced from:
      _ares_init_options in libcares.a(ares_init.c.o)
  "_res_9_ndestroy", referenced from:
      _ares_init_options in libcares.a(ares_init.c.o)
  "_res_9_ninit", referenced from:
      _ares_init_options in libcares.a(ares_init.c.o)

Signed-off-by: Keith Smiley<EMAIL_ADDRESS>

I'm not sure if this change is universally acceptable, we'll see what CI thinks

Seems it is only for iOS?

I guess so, I'll add this upstream


Rewind readable body before POST redirect

This addresses the issue (#3079) of Requests hanging when a POST with a file-like body encounters a temporary redirect. This currently has the unmerged tests from #3536, so I'll need to remove those if we reach a point where we're ready to merge this.
This approach has a couple of things that I'm not especially happy with but couldn't come up with a nicer alternative. I've added a few outstanding questions below.
1.) I feel like body_position should probably be _body_position, but we need to use it in the Session module. Making it a private var would require an additional getter method for PreparedRequest to expose the data to Session, but I wanted to run that by before adding more  code. It just seems problematic to provide any encouragement to manually set body_position since it will lead to fairly unintuitive behaviour.
2.) As I noted in the comment here, this still allows for the possibility that a request with a file-like object, that has tell but no seek, to hang. I feel like we should raise an IOError if we can't rewind, at least allowing the user to manually recreate the body and POST it to the new URL. Does that seem reasonable?

Alright @Lukasa, I think everything in that last round should be addressed. A couple of notes on some decisions I made in these tweaks.
Python 2.7 decided it needs to return a long from tell instead of an int like every other version. I've adjusted for that by casting it to int because we can't test for long in Py3.
I didn't declare the "sentinel object" as a global because I couldn't come up with a scenario where it was equivocal to anything in the sessions module. Simply setting it to object accomplishes what we were looking for but perhaps there's a caveat I'm missing here?
Tests. I went a little crazy. I have a few "lifecycle" tests, but found a snag when adding test_rewind_body_failed_tell. I realized things were failing in different ways (_body_position was never being set with the custom test objects) but the error messages produced were still "correct". In order to prevent accidental regressions, I add specific tests for setting _body_position and failure conditions in rewind_body by manually setting _body_position. Let me know if you want these collapsed back.

Here's another round of changes @Lukasa.
I moved the rewind_body to a util function but when I started looking at moving tests over to test_utils they're going to bring a lot of import overhead with them. I can chop them up into individual _body_position and rewind_body tests and divide them up accordingly. Otherwise, we can leave them where they are.

Alright, ValueError removed, tuple properly instantiated, and comment added. I also squashed most of the commits down. There's an unnecessary space I need to pull from beneath the _body_position declaration but I'll do that when I remove bc199e7 before merging. That is unless we have another round :)

Want to do your final tidying up now, @nateprewitt? I don't think I'm going to have any further feedback at this time.

Ok, I think things are good to go from my end.

Just a reminder, we'll need to merge #3536 before this is merged.

Ah, sorry, I didn't realise that's what was going on there. Can you merge the branch from #3536 into this branch and then I'll merge them both as one? I'd rather not have a weird interim master state where we have deliberately failing tests on the master branch.

Ok, everything is merged in and this should be ready to go. It will now supersede #3536.

Thanks for this @nateprewitt!


Screen resize via media queries or manually makes Select2 go crazy

We are trying to use Select2 with Bootstrap in a Modal. We have specified the parent attribute but when the screen is resized

Select2 will not stay open for a user to tyoe in the search box.
The positioning of the dropdown goes all over the place and gets hidden from view

Can you expand upon the issue you are facing by adding a few more pieces of information to your bug report?

What steps can be used to reproduce the issue?
What is the bug and what is the expected outcome?
What browser(s) and Operating System have you tested with?
Does the bug happen consistently across all tested browsers?
Can you reproduce this issue on any of the examples in the docs?
What version of jQuery are you using? And what version of Select2?
Are you using Select2 with other plugins?

The contributing guide contains a useful section with a few questions which can help us track down the bug and speed up the process of finding a fix for it.  The creation of an isolated test case would also be useful.

hi
All you need to do is palace a Select2 in a Bootstrap 3 Modal. If the
content of the modal is scrollable and you scroll, the Select2 loses its
positioning.
We are using the latest of everything and testing in Chrome.
Thanks
On Tue, Nov 9, 2021 at 6:33 PM Kevin Brown-Silva @.***>
wrote:

Can you expand upon the issue you are facing by adding a few more pieces
of information to your bug report?

What steps can be used to reproduce the issue?
What is the bug and what is the expected outcome?
What browser(s) and Operating System have you tested with?
Does the bug happen consistently across all tested browsers?
Can you reproduce this issue on any of the examples in the docs
https://select2.org/?
What version of jQuery are you using? And what version of Select2?
Are you using Select2 with other plugins?

The contributing guide
https://github.com/select2/select2/blob/master/.github/CONTRIBUTING.md#asking-for-help
contains a useful section with a few questions which can help us track down
the bug and speed up the process of finding a fix for it. The creation of an
isolated test case https://css-tricks.com/reduced-test-cases/ would
also be useful.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/select2/select2/issues/6103#issuecomment-964423366,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACA6J2PTRYPYZCTUHAVWWYLULFSO3ANCNFSM5FH7GXSQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Hi
S|orry, we cannot show this issue on any examples in the doc as the docs do
not include an example using a BS3 Modal Dialog.
On Tue, Nov 9, 2021 at 8:07 PM H Nahavandi @.***> wrote:

hi
All you need to do is palace a Select2 in a Bootstrap 3 Modal. If the
content of the modal is scrollable and you scroll, the Select2 loses its
positioning.
We are using the latest of everything and testing in Chrome.
Thanks
On Tue, Nov 9, 2021 at 6:33 PM Kevin Brown-Silva @.***>
wrote:

Can you expand upon the issue you are facing by adding a few more pieces
of information to your bug report?

What steps can be used to reproduce the issue?
What is the bug and what is the expected outcome?
What browser(s) and Operating System have you tested with?
Does the bug happen consistently across all tested browsers?
Can you reproduce this issue on any of the examples in the docs
https://select2.org/?
What version of jQuery are you using? And what version of Select2?
Are you using Select2 with other plugins?

The contributing guide
https://github.com/select2/select2/blob/master/.github/CONTRIBUTING.md#asking-for-help
contains a useful section with a few questions which can help us track down
the bug and speed up the process of finding a fix for it. The creation of an
isolated test case https://css-tricks.com/reduced-test-cases/ would
also be useful.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/select2/select2/issues/6103#issuecomment-964423366,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACA6J2PTRYPYZCTUHAVWWYLULFSO3ANCNFSM5FH7GXSQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Hi
I am sorry to have to say this, but although I appreciate that this widget
is free, the developer community expects open source software to be of a
high quality.
We spent several hours trying to make this widget work, but it was
completely useless in many scenarios.
How long has this widget been under development? It seems for a long time
and if it cannot do a simple thing as maintaining its correct position on
an HTML page, then it's time to Dump it and not waste people's time - even
if it is free.
Please print in big letters that this widget is NOT FIT for production
scenarios and should only be used by amateurs who are trying to learn
programming.
On Tue, Nov 9, 2021 at 8:08 PM H Nahavandi @.***> wrote:

Hi
S|orry, we cannot show this issue on any examples in the doc as the docs
do not include an example using a BS3 Modal Dialog.
On Tue, Nov 9, 2021 at 8:07 PM H Nahavandi @.***> wrote:

hi
All you need to do is palace a Select2 in a Bootstrap 3 Modal. If the
content of the modal is scrollable and you scroll, the Select2 loses its
positioning.
We are using the latest of everything and testing in Chrome.
Thanks
On Tue, Nov 9, 2021 at 6:33 PM Kevin Brown-Silva <
@.***> wrote:

Can you expand upon the issue you are facing by adding a few more pieces
of information to your bug report?

What steps can be used to reproduce the issue?
What is the bug and what is the expected outcome?
What browser(s) and Operating System have you tested with?
Does the bug happen consistently across all tested browsers?
Can you reproduce this issue on any of the examples in the docs
https://select2.org/?
What version of jQuery are you using? And what version of Select2?
Are you using Select2 with other plugins?

The contributing guide
https://github.com/select2/select2/blob/master/.github/CONTRIBUTING.md#asking-for-help
contains a useful section with a few questions which can help us track down
the bug and speed up the process of finding a fix for it. The creation of an
isolated test case https://css-tricks.com/reduced-test-cases/ would
also be useful.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/select2/select2/issues/6103#issuecomment-964423366,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACA6J2PTRYPYZCTUHAVWWYLULFSO3ANCNFSM5FH7GXSQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


--changed-since and a path to test file conflict

When running with both for example
nf-test test --changed-since HEAD^ path/to/main.nf.test

The changed-since takes presidence and the tests in the test file are ignored.
I'd like to be able to run the command and only the tests in the test file be considered.
But this may be difficult to implement and we should just use a tag.

Thanks, I will take a look to see how complicated this would be 👍


fix: MD038/no-space-in-code

Spaces inside code span elements
Adjust indenting for code fences that didn't render

@nschonni : Thanks for your contribution! The author, @mssedusch, has been notified to review your proposed change.

We are reviewing this submission. Thank you

@rdeltcheva can you have a look? I think you modified these lines a few days ago. Thanks

@nschonni : Thanks for your contribution! The author, @cephalin, has been notified to review your proposed change.

@PRMerger8 I can only review and sign off on includes/configure-deployment-user-no-h.md (and it looks good). I don't own the other docs.

@nschonni : Thanks for your contribution! The author, @cephalin, has been notified to review your proposed change.

@GitHubber17 i've rebased this again

It looks to me like the revisions remove extra spaces in code lines that likely were typographical errors. I believe that's the purpose of the linter tool the contributor ran to get these results (re: the PR title). The updates look good to me. I'll go ahead and merge the PR.
@nschonni Thanks for your contributions. It would probably be most efficient for the assign/review/approval process if you created PRs by Azure service (data-factory, virtual-machines, etc.) at a minimum (by author would work best). Thanks again.


php-grpc exit timeout [php]

Have you ever noticed this situation, if you use php-grpc , then when you exit, it will about last 5 seconds (both in console and brower). Both in the example helloword.php  and unit test. If send many requests, it response fast each time, but when scipt end, if will last many seconds. I try die() exit() set_timelimit() and all kinds of method, but not work.I guess its reason is the Call, not destruct, can any one help me?

Folding this into #4017


removes highlighting when day is disabled

Description
When disabling "today's date" the UI indicates that today's date is select-able and/or currently selected.  This update will resolve two UI issues.

When opening a datepicker that has the current date disabled, that day will no longer display as visually active/selected.
When a date in a given month is selected, switching months will ignore the disabled settings for that same numeric date.  An example:

If the current month is April, and April 11th is disabled, opening the datepicker will show the 11th as disabled.  Changing the month to May and selecting May 11th will show the May 11th as selected.  However, when you change the month back to April, it will show April 11th - a disabled day - as visually active.

This bug is particularly notable - so while the existing code does have pointer-events-none, this is not perceivable when using a mobile device, so the visual changes here will more effectively communicate disabled dates across all devices.
Visual changes
Today's date bug-fix
Before: April 19th (today's date) is shown as highlighted:

Before: April 19th (today's date) is shown correctly as disabled:

Cross-month selection bug-fix
Before: Selecting May 11th and showing April 11th as highlighted:
https://github.com/filamentphp/filament/assets/4382816/d0103cd4-773e-4950-a1fb-200a745f78d7
After: Selecting May 11th and showing April 11th as disabled:
https://github.com/filamentphp/filament/assets/4382816/27dcdff6-a39d-4b27-bd54-59aad0a82019
Functional changes

[X] Code style has been fixed by running the composer cs command.
[X] Changes have been tested to not break existing functionality.
[X] Documentation is up-to-date.

Thanks!


Shortdump when sorting by Created At in repo overview

makes me wonder how many string literals representing technical names are misspelled. could be an interesting lint check.

https://github.com/abaplint/abaplint/issues/1361


./seedvault-extractor-linux-amd64: command not found

Im not that tech sawyy, I could figure it out. In what can be problem?

You most likely need to run chmod +x seedvault-extractor-linux-amd64 to make it executable. I'd also advise not running it with sudo, as it shouldn't require root permissions to work.


Sentence Transformers test (soon) no longer expected to fail

Hello!
Pull Request overview

Remove xfail from Sentence Transformer "save_to_hub" test.
Add an assert to verify that it should work.

Details
The upcoming Sentence Transformers 2.3.0 has removed the hardcoded endpoint in save_to_hub, so we can soon expect for this behaviour to work correctly.

Tom Aarsen

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

In the meantime, do the contrib tests download the bleeding edge version from the respective repos?

Yes it does! I forgot about that. Then we should be good to merge once the CI is green.

Thanks for debugging @tomaarsen. Let's merge this now :)


Update volatile-volatile-keyword-interpretation.md

Further clarify the target archs (ARM-related) that use /volatile:iso by default, and those that use /volatile:ms by default.

@mcfi : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@corob-msft,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge. Thanks.
#label:"aq-pr-triaged"
#assign:@MicrosoftDocs/public-repo-pr-review-team

The following users don't have valid GitHub IDs, or are not collaborators on this repo: microsoftdocs/public-repo-pr-review-team

@mcfi Did you decide this change wasn't needed?

@mcfi Did you decide this change wasn't needed?

The change is still needed, but needs some tweaks. I'll re-open this PR with changes later. Thanks.


Introduce BrotliDecoder

Motivation:
Netty lacks client side support for decompressing Brotli compressed response bodies.
Modification:

Introduce optional dependency to brotli4j by @hyperxpro. It will be up to the user to provide the brotli4j libraries for the target platform in the classpath. brotli4j is currently available for Linux, OSX and Windows, all for x86 only.
Introduce BrotliDecoder in codec module
Plug it onto HttpContentDecompressor for HTTP/1 and DelegatingDecompressorFrameListener for HTTP/2
Add test in HttpContentDecoderTest

Result:
Netty now supports decompressing Brotli compressed response bodies.

cc @hyperxpro

cc @hyperxpro

@normanmaurer @hyperxpro The PR fails randomly on Linux (first build failed on Java 8, second one failed on Java 11 while Java 8 was successful) with the following error:

2021-01-25T22:09:01.2229566Z 22:09:01.212 [main] DEBUG i.n.handler.codec.compression.Brotli - Failed to load brotli4j; Brotli support will be unavailable.
2021-01-25T22:09:01.2232104Z java.lang.UnsatisfiedLinkError: /tmp/com_aayushatharva_brotli4j_1234063592518/libbrotli.so: /lib64/libm.so.6: version `GLIBC_2.29' not found (required by /tmp/com_aayushatharva_brotli4j_1234063592518/libbrotli.so)

Do you guys have any idea? Is it an issue with GH Actions where hosts are inconsistent? It there any way to compile the native lib differntly?

@normanmaurer @hyperxpro The PR fails randomly on Linux (first build failed on Java 8, second one failed on Java 11 while Java 8 was successful) with the following error:

2021-01-25T22:09:01.2229566Z 22:09:01.212 [main] DEBUG i.n.handler.codec.compression.Brotli - Failed to load brotli4j; Brotli support will be unavailable.
2021-01-25T22:09:01.2232104Z java.lang.UnsatisfiedLinkError: /tmp/com_aayushatharva_brotli4j_1234063592518/libbrotli.so: /lib64/libm.so.6: version `GLIBC_2.29' not found (required by /tmp/com_aayushatharva_brotli4j_1234063592518/libbrotli.so)

Do you guys have any idea? Is it an issue with GH Actions where hosts are inconsistent? It there any way to compile the native lib differntly?

Looks like a dependency error. @normanmaurer Help :D

Looks like a dependency error. @normanmaurer Help :D

@slandelle @hyperxpro we use Centos 6 on our CI setup to ensure the maximum compatibility. Your native artefacts were compiled on something which has GLIBC_2.29 which is a lot newer to what cantos 6 offers. For maximum compatibility you should ensure you compile it on a system with a very old GLIBC version.

@slandelle @hyperxpro we use Centos 6 on our CI setup to ensure the maximum compatibility. Your native artefacts were compiled on something which has GLIBC_2.29 which is a lot newer to what cantos 6 offers. For maximum compatibility you should ensure you compile it on a system with a very old GLIBC version.

I used GitHub Actions for building the native library.

I used GitHub Actions for building the native library.

@hyperxpro yeah this explains it as they use ubuntu 18 (as minimum). You will need to use something like docker to compile with centos6. Thats what we do

@hyperxpro yeah this explains it as they use ubuntu 18 (as minimum). You will need to use something like docker to compile with centos6. Thats what we do

Just a comment: there is no chance to get a JNI-free pure Java impl?

Just a comment: there is no chance to get a JNI-free pure Java impl?

Just a comment: there is no chance to get a JNI-free pure Java impl?

Nope, not yet.

Just a comment: there is no chance to get a JNI-free pure Java impl?

Nope, not yet.

Just a comment: there is no chance to get a JNI-free pure Java impl?

The java implementation has been lagging behind for a very long time. Last release was in May 2017.

Just a comment: there is no chance to get a JNI-free pure Java impl?

The java implementation has been lagging behind for a very long time. Last release was in May 2017.

@slandelle

The java implementation has been lagging behind for a very long time. Last release was in May 2017.

Recently I see the good trend to get some JNI code turned into Java one, even while accessing native resources and I like it, for many reasons.
I'm looking on https://github.com/google/brotli/tree/master/java/org/brotli if is pure-Java or not...

@slandelle

The java implementation has been lagging behind for a very long time. Last release was in May 2017.

Recently I see the good trend to get some JNI code turned into Java one, even while accessing native resources and I like it, for many reasons.
I'm looking on https://github.com/google/brotli/tree/master/java/org/brotli if is pure-Java or not...

@franz1981 franz1981
Assuming similar levels of performance and maintenance, I agree I'd rather have a pure Java implementation than a JNI one.
Sadly, so far:

the Brotli team hasn't been actively maintaining the pure Java implementation, on contrary to the C one.
I've never seen a benchmark comparing the performance of the Java based implementation. I would expect le latter to be implemented mostly for the sake of the client side on Android, where performance is not really an issue (low throughput per client instance).

@franz1981 franz1981
Assuming similar levels of performance and maintenance, I agree I'd rather have a pure Java implementation than a JNI one.
Sadly, so far:

the Brotli team hasn't been actively maintaining the pure Java implementation, on contrary to the C one.
I've never seen a benchmark comparing the performance of the Java based implementation. I would expect le latter to be implemented mostly for the sake of the client side on Android, where performance is not really an issue (low throughput per client instance).

@normanmaurer I've just addressed your comments, thanks!
@hyperxpro The ball is now in your court :) Please chime in once you've fixed the glibc issue (sorry, I can't help with that).

@normanmaurer I've just addressed your comments, thanks!
@hyperxpro The ball is now in your court :) Please chime in once you've fixed the glibc issue (sorry, I can't help with that).

@normanmaurer CentOS 6 has officially reached EOL. You sure we need to compile Linux binary on CentOS 6?

@normanmaurer CentOS 6 has officially reached EOL. You sure we need to compile Linux binary on CentOS 6?

@hyperxpro while it is EOL I still think it is a good idea for max compatibility

@hyperxpro while it is EOL I still think it is a good idea for max compatibility

@hyperxpro while it is EOL I still think it is a good idea for max compatibility

After some digging, I second @normanmaurer here: the glibc version on the latest Amazon Linux 2 is 2.26, so we definitely require 2.29.

@hyperxpro while it is EOL I still think it is a good idea for max compatibility

After some digging, I second @normanmaurer here: the glibc version on the latest Amazon Linux 2 is 2.26, so we definitely require 2.29.

What's the GLIBC version I need to compile this with?

What's the GLIBC version I need to compile this with?

@chrisvest
WDYM? This is a new and optional feature.

@chrisvest
WDYM? This is a new and optional feature.

What's the GLIBC version I need to compile this with?

From distrowatch, CentOS 6 has glibc 2.12 while CentOS 7 has glibc 2.17.

What's the GLIBC version I need to compile this with?

From distrowatch, CentOS 6 has glibc 2.12 while CentOS 7 has glibc 2.17.

Yes just use cents 6 which uses glib 2.12... OpenJDK compiles against and old GLIBC for the same reasons as well.

Yes just use cents 6 which uses glib 2.12... OpenJDK compiles against and old GLIBC for the same reasons as well.

@normanmaurer Would you mind helping me build? My docker experience is almost null.
:-|

@normanmaurer Would you mind helping me build? My docker experience is almost null.
:-|

@hyperxpro sorry I am super busy atm so I can't help a lot here. But basically this should give you some idea:
https://github.com/netty/netty/blob/4.1/docker/Dockerfile.centos6
https://github.com/netty/netty/blob/4.1/docker/docker-compose.yaml
https://github.com/netty/netty/blob/4.1/docker/docker-compose.centos-6.18.yaml

@hyperxpro sorry I am super busy atm so I can't help a lot here. But basically this should give you some idea:
https://github.com/netty/netty/blob/4.1/docker/Dockerfile.centos6
https://github.com/netty/netty/blob/4.1/docker/docker-compose.yaml
https://github.com/netty/netty/blob/4.1/docker/docker-compose.centos-6.18.yaml

I give up Docker. WSL 2 is making me cry. @slandelle Can you help in building the binary of Linux?

I give up Docker. WSL 2 is making me cry. @slandelle Can you help in building the binary of Linux?

@slandelle Go ahead with this. I don't have plans to downgrade the GLIBC version. Brotli4jLoader#isAvailable call should be enough.

@hyperxpro I'll try to have someone at Gatling take a look next week at the Docker/GH Action configuration.
As is:

this PR can't be merged as it doesn't pass Netty's CI
brotli4j doesn't work on current major distributions, including Amazon Linux 2. From my (Gatling) PoV, that's a major blocker.

I agree with your point. I also saw some issues with RHEL 8.X.

Some update on this: we (at Gatling) can't manage to compile the original Brotli code on CentOS6. We plan on contributing fixes to brotli4j so that Linux binaries work on widespread modern distributions (eg current Amazon Linux) and keep on integrating on our side.
As for contributing upstream to Netty, until Netty revisits its CentOS compatibility requirement, the only solution I see is to disable Brotli related tests on linux-x86_64.
Thoughts?

@slandelle Agree with your points. Also, please do the PR for Brotli4j.

@hyperxpro Yeah, we're working on this. We're still working on the CentOS docker image as it's still quite large.

Just updated PR with brotli4j 1.4.0, which is compatible with CentOS 6.

@slandelle Do you have plans for Brotli Encoder or I should add it to my list?

Do you have plans for Brotli Encoder or I should add it to my list?

@hyperxpro no, no plans, sorry. In Gatling, we're mainly focused on the client side, so it's very unlikely we'll ever work on the encoder ourselves. And we're still working on trying to make the binary work on CentOS6.

Do you have plans for Brotli Encoder or I should add it to my list?

@hyperxpro no, no plans, sorry. In Gatling, we're mainly focused on the client side, so it's very unlikely we'll ever work on the encoder ourselves. And we're still working on trying to make the binary work on CentOS6.

Alright. I will do PR for the encoder after we're done fixing the binary issue and merger of this PR.

Error:  COMPILATION ERROR :
[INFO] -------------------------------------------------------------
Error:  /home/runner/work/netty/netty/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentDecoderTest.java:[225,33] error: unreported exception Throwable; must be caught or declared to be thrown
[INFO] 1 error
[INFO] -------------------------------------------------------------

ByteBuf leak ;/ @slandelle

@normanmaurer Please hold reviews for now. I'm investigating a test failure I'm having a hard time reproducing locally. I have to stay the test suite is very weird, with  static AbstractDecoderTest#compressedBytesLarge actually loaded from ctor. This seems to be some JUnit hack, but this hack crashes with NPE when trying to run one single test, eg mvn -Dtest=io.netty.handler.codec.compression.BrotliDecoderTest test.