Add a couple of tabs for jenkins.

Before this PR travis has passed (https://travis-ci.org/erasche/community-package-cache/builds/89715899) in spite of showing tab number error - Jenkins would fail though.

Oh, hmph. Nice catch @martenson. I'll fix that shortly.

Opened #13.


Getting NFC tags real Id, not the byte array

Is there a way to get a Tags Id as a string?
In the object "NfcFormsTag" i am getting the Id, but its a byte[]..
I would want the real UID from the tag. A 20 digit number.
This was our latest diskussion, if u wanna know the implementation, but i think u remember it :)
https://github.com/poz1/NFCForms/issues/10

Applying more information.
When i am reading my nfc tags with my NFid reader, it prints out a 20 diget number. It should be the Id of  the tag, but the id of the "NfcFormsTag" object that i get from the code, is a byte array.
Is it possible to convert this array into the 20 diget number that my NFid reader is getting?
Or is that a completly diffrent thing?

If you are looking for the MifareID
my solution was :
reverse the byte array id
convert array to hex
convert hex to decimal
hope it helps :):):)


OpenSSH logs are not included in the file mode logs

Gitea version (or commit ref): 1.13.1
Operating system: official Docker image
Database (use [x]):

[x] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Description
I'm trying to setup fail2ban with Gitea that uses SSHD (START_SSH_SERVER=false).
I can see unsucessful SSH connection attempts in docker logs, but not in log files, even when file logging enabled.
Gitea documentation about fail2ban seem to assume that it is an internal ssh server running, not sshd.
Excerpt from docker logs:
2021/01/27 16:39:25 cmd/web.go:163:runWeb() [I] Listen: http://<IP_ADDRESS>:3000
2021/01/27 16:39:25 ...s/graceful/server.go:55:NewServer() [I] Starting new server: tcp:<IP_ADDRESS>:3000 on PID: 16
2021/01/27 16:39:25 ...s/graceful/server.go:66:func1() [D] Starting server on tcp:<IP_ADDRESS>:3000 (PID: 16)
Could not load host certificate "/data/ssh/ssh_host_ed25519_cert": No such file or directory
Could not load host certificate "/data/ssh/ssh_host_rsa_cert": No such file or directory
Could not load host certificate "/data/ssh/ssh_host_ecdsa_cert": No such file or directory
Could not load host certificate "/data/ssh/ssh_host_dsa_cert": No such file or directory
Invalid user user from REDACTED_IP port 53821
Connection closed by invalid user user REDACTED_IP port 53821 [preauth]
Could not load host certificate "/data/ssh/ssh_host_ed25519_cert": No such file or directory
Could not load host certificate "/data/ssh/ssh_host_rsa_cert": No such file or directory
Could not load host certificate "/data/ssh/ssh_host_ecdsa_cert": No such file or directory
Could not load host certificate "/data/ssh/ssh_host_dsa_cert": No such file or directory
Invalid user user from REDACTED_IP port 54825
Connection closed by invalid user user REDACTED_IP port 54825 [preauth]
Could not load host certificate "/data/ssh/ssh_host_ed25519_cert": No such file or directory
Could not load host certificate "/data/ssh/ssh_host_rsa_cert": No such file or directory
Could not load host certificate "/data/ssh/ssh_host_ecdsa_cert": No such file or directory
Could not load host certificate "/data/ssh/ssh_host_dsa_cert": No such file or directory
Invalid user user from REDACTED_IP port 55734
Connection closed by invalid user user REDACTED_IP port 55734 [preauth]

Here's my app.ini regarding logging:
[log]
MODE                 = console, file
LEVEL                = debug
REDIRECT_MACARON_LOG = true
MACARON              = console, file
ROUTER               = console, file
ROOT_PATH            = /data/gitea/log

you can use sshd in docker .. but you have to add install & enable it.

you can use sshd in docker .. but you have to add install & enable it.

If you aren't running the internal ssh why would you expect the gitea logs to provide that information? Just set up fail2ban to use the sshd logs.
Adjust the config of /etc/ssh/sshd_config as necessary,

If you aren't running the internal ssh why would you expect the gitea logs to provide that information? Just set up fail2ban to use the sshd logs.
Adjust the config of /etc/ssh/sshd_config as necessary,

If you aren't running the internal ssh why would you expect the gitea logs to provide that information? Just set up fail2ban to use the sshd logs.
Adjust the config of /etc/ssh/sshd_config as necessary,

That makes sense, thanks.
Sorry, I've assumed the logs would be "redirected" for some reason.
I've tried to switch to the internal ssh, but it seems that the default ssh provider for Docker image is openssh and it gets run even if internal ssh is turned on. For example, if I set START_SSH_SERVER=true in the app.ini, container crashes on startup because it can not bind to the port that openssh already took:
Server listening on :: port 2222.
Server listening on <IP_ADDRESS> port 2222.
2021/01/28 11:18:24 cmd/web.go:108:runWeb() [I] Starting Gitea on PID: 15
2021/01/28 11:18:24 ...dules/setting/git.go:91:newGit() [I] Git Version: 2.26.2, Wire Protocol Version 2 Enabled
....
2021/01/28 11:18:25 routers/init.go:56:checkRunMode() [I] Run Mode: Production
2021/01/28 11:18:25 routers/init.go:188:GlobalInit() [I] SSH server started on :2222. Cipher list ([aes128-ctr aes192-ctr aes256-ctr<EMAIL_ADDRESS>arcfour256 arcfour128]), key exchange algorithms ([diffie-hellman-group1-sha1 diffie-hellman-group14-sha1 ecdh-sha2-nistp256 ecdh-sha2-nistp384 ecdh-sha2-nistp521 curve25519-sha256@libssh.org]), MACs<EMAIL_ADDRESS>hmac-sha2-256 hmac-sha1 hmac-sha1-96])
2021/01/28 11:18:25 ...s/graceful/server.go:55:NewServer() [I] Starting new server: tcp::2222 on PID: 15
2021/01/28 11:18:25 ...s/graceful/server.go:79:ListenAndServe() [E] Unable to GetListener: listen tcp :2222: bind: address already in use
2021/01/28 11:18:25 .../ssh/ssh_graceful.go:23:listen() [F] Failed to start SSH server: listen tcp :2222: bind: address already in use
Received signal 15; terminating.

Also it seems that the default openssh server does not write logs: /var/log/ folder is empty.

If you aren't running the internal ssh why would you expect the gitea logs to provide that information? Just set up fail2ban to use the sshd logs.
Adjust the config of /etc/ssh/sshd_config as necessary,

That makes sense, thanks.
Sorry, I've assumed the logs would be "redirected" for some reason.
I've tried to switch to the internal ssh, but it seems that the default ssh provider for Docker image is openssh and it gets run even if internal ssh is turned on. For example, if I set START_SSH_SERVER=true in the app.ini, container crashes on startup because it can not bind to the port that openssh already took:
Server listening on :: port 2222.
Server listening on <IP_ADDRESS> port 2222.
2021/01/28 11:18:24 cmd/web.go:108:runWeb() [I] Starting Gitea on PID: 15
2021/01/28 11:18:24 ...dules/setting/git.go:91:newGit() [I] Git Version: 2.26.2, Wire Protocol Version 2 Enabled
....
2021/01/28 11:18:25 routers/init.go:56:checkRunMode() [I] Run Mode: Production
2021/01/28 11:18:25 routers/init.go:188:GlobalInit() [I] SSH server started on :2222. Cipher list ([aes128-ctr aes192-ctr aes256-ctr<EMAIL_ADDRESS>arcfour256 arcfour128]), key exchange algorithms ([diffie-hellman-group1-sha1 diffie-hellman-group14-sha1 ecdh-sha2-nistp256 ecdh-sha2-nistp384 ecdh-sha2-nistp521 curve25519-sha256@libssh.org]), MACs<EMAIL_ADDRESS>hmac-sha2-256 hmac-sha1 hmac-sha1-96])
2021/01/28 11:18:25 ...s/graceful/server.go:55:NewServer() [I] Starting new server: tcp::2222 on PID: 15
2021/01/28 11:18:25 ...s/graceful/server.go:79:ListenAndServe() [E] Unable to GetListener: listen tcp :2222: bind: address already in use
2021/01/28 11:18:25 .../ssh/ssh_graceful.go:23:listen() [F] Failed to start SSH server: listen tcp :2222: bind: address already in use
Received signal 15; terminating.

Also it seems that the default openssh server does not write logs: /var/log/ folder is empty.

https://stackoverflow.com/questions/22526016/docker-container-sshd-logs
There's also a rootless variant of the docker.

https://stackoverflow.com/questions/22526016/docker-container-sshd-logs
There's also a rootless variant of the docker.

https://stackoverflow.com/questions/22526016/docker-container-sshd-logs

Thank you, I also found this question on SO, but it is not straightforward. Gitea docker image is based on alpine (not Ubuntu as in SO question) and even after downloading and installing rsyslog (apk add rsyslog; rsyslogd) the logs are not there. I will try some more tomorrow.

There's also a rootless variant of the docker.

It seems there is no stable version of rootless Gitea image, so I don't think it's a good alternative. Even though docs say For a stable release you can use :1-rootless or specify a certain release like :1.13.1-rootless., in reality on Dockerhub there is only latest-rootless.

https://stackoverflow.com/questions/22526016/docker-container-sshd-logs

Thank you, I also found this question on SO, but it is not straightforward. Gitea docker image is based on alpine (not Ubuntu as in SO question) and even after downloading and installing rsyslog (apk add rsyslog; rsyslogd) the logs are not there. I will try some more tomorrow.

There's also a rootless variant of the docker.

It seems there is no stable version of rootless Gitea image, so I don't think it's a good alternative. Even though docs say For a stable release you can use :1-rootless or specify a certain release like :1.13.1-rootless., in reality on Dockerhub there is only latest-rootless.


improved axios typings

fixes https://github.com/aishek/axios-rate-limit/issues/20

preserve export default for import rateLimit from 'axios-rate-limit';
add interface export for RateLimitedAxiosInstance - now you can do import rateLimit, { RateLimitedAxiosInstance } from 'axios-rate-limit';
added the prototype function calls, so that typescript does not complain when you use the example http.getMaxRPS()

@aishek ?

Oh, I've missed the PR somehow. Will take a closer look this week.

@aishek ?

@jomel would you be able to made the suggested changes. TS users are not able to use the maxRPS option today.

This library is exactly what I was looking for but unfortunately I can't use it in my TypeScript projects.
I hope this PR will be accepted soon or I would need to move to another solution.

@aishek Could you check this PR?
Could you approve?
Thank you

Guys, I sorry not hearing back so long. Finally reviewed and merged this PR. Thanks for contribution!


doc/go_mem: define "control flow constructs"

https://github.com/golang/go/blob/6b80b62fd1b5338e6ec8bc2ff521b94f2fefae9c/doc/go_mem.html#L124
I'm reading the Go memory model doc, and this part is not clear to me,
'''
the sequenced before relation, defined as the partial order requirements set out by the
Go language specification for Go's control flow constructs
as well as the order of evaluation for expressions
'''
It's not clear what exactly consist Go's control flow constructs.
The link is a general link to the full language spec, but searching for "control flow constructs" in the language spec doesn't match anything.

It'll be great if there can be an explicit definition for "Go's control flow constructs", either in the language spec, or in the memory model doc.
The language spec does not have clear indication of the concept of 'partial order'. For example, in https://go.dev/ref/spec#If_statements, “If the expression evaluates to true, the "if" branch is executed, otherwise, if present, the "else" branch is executed.”
It seems to indicate the expression and the "if/else" branch has some partial order, but this isn't obvious enough to be reflected when reading the memory model doc.

cc @rsc


[BUG] full-screen option not working on ios

Describe the bug
Hi,
The option to toggle full-screen is not working on ios device. As soon as I click on the toggle option nothing happens.
Technical Details:

Device: iPhone11promax (simulator)
Flutter version: 1.22.6
package version: 7.0.0+7

** CODE **
This isthe code for the player wrapper:

import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'package:youtube_player_flutter/youtube_player_flutter.dart';

class PlayYT extends StatefulWidget {
  final String ytLink;

  const PlayYT(this.ytLink, {Key key}) : super(key: key);

  static Route route(String ytLink) {
    return CupertinoPageRoute<void>(
      builder: (BuildContext _) => PlayYT(ytLink),
    );
  }

  @override
  _PlayYTState createState() => _PlayYTState();
}

class _PlayYTState extends State<PlayYT> {
  YoutubePlayerController _youtubeController;
  @override
  void initState() {
    super.initState();
    _youtubeController = YoutubePlayerController(
      initialVideoId: widget.ytLink,
      flags: YoutubePlayerFlags(
        autoPlay: true,
        forceHD: true,
        hideControls: false,
        hideThumbnail: false,
      ),
    );
  }

  @override
  void dispose() {
    _youtubeController.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    print('YOOOO');
    return _buildContentAndroid;
  }

  get _buildContentAndroid => WillPopScope(
        onWillPop: () {
          _youtubeController.pause();
          // SystemChrome.setPreferredOrientations([DeviceOrientation.portraitUp]);
          Navigator.of(context).pop();
          return Future<bool>.value(true);
        },
        child: YoutubePlayerBuilder(
          onEnterFullScreen: () {
            print('>>>>>onEnterFullScreen called!!');
          },
          onExitFullScreen: () {
            print('>>>>>onFullScreen called!!');
          },
          player: YoutubePlayer(
            controller: _youtubeController,
            showVideoProgressIndicator: true,
            topActions: <Widget>[
              const SizedBox(width: 16.0),
              IconButton(
                icon: const Icon(
                  Icons.close,
                  color: Colors.white,
                  size: 25.0,
                ),
                onPressed: () {
                  _youtubeController.pause();
                  Navigator.of(context).pop();
                },
              ),
              const SizedBox(width: 16.0),
              Expanded(
                child: Text(
                  _youtubeController.metadata.title,
                  style: const TextStyle(
                    color: Colors.white,
                    fontSize: 18.0,
                  ),
                  overflow: TextOverflow.ellipsis,
                  maxLines: 1,
                ),
              ),
            ],
            onEnded: (data) {
              Navigator.of(context).pop();
            },
          ),
          builder: (context, player) => Scaffold(
            backgroundColor: Colors.black,
   body: Center(
              child: FittedBox(
                fit: BoxFit.fitWidth,
                child: player,
              ),
            ),
          ),
        ),
      );
}

Any news?

I encountered the same issue, would appreciate a fix for this.

any news? x2

Same issue running flutter 3.3.4 and 8.1.0 on iOS.
It a show stopper..

In my case, the full screen mode was not working because I didn't have the available device orientations correctly configured in Info.plist
You have to edit the UISupportedInterfaceOrientations variable in app -> Runner -> Info.plist
Answer based on https://github.com/flutter/flutter/issues/119473#issuecomment-1415631020


Use maui

Description

I added a props file that will get included now with the nuget so users don't have to add those properties themselves
The root issue here seems to be that just using  <UseMauiCore> isn't sufficient enough to be functional. For now, I changed it to <UseMaui/>. I noticed the template also uses UseMaui so at this point it's probably fine though I wonder if we can get both the template and this package converted over to using just UseMauiCore.

Is there a reason the template uses UseMaui ? You could probably copy what comet does here for it's Use code instead of using ours https://github.com/dotnet/Comet/blob/dev/src/Comet/AppHostBuilderExtensions.cs#L29

There's also a few more changes that need to be made to the template in order to work. I've attached a working template here.
mauifab.zip

the App.Xaml file needs to be deleted from Platforms/Windows/
I added a Maui.fs file that acts as the EntrtyPoint that calls up into the WinUI startup code.
the deploy checkbox has to be selected for the winui project

Is there a reason the template uses UseMaui ?

Which template are you talking about?
Currently there's 3 different repositories for F# + Maui:

FSharp.Mobile.Templates: this one is pure XAML Maui in F#, so we need UseMaui.
Fabulous.MauiControls: this one is a Fabulous wrapper around Microsoft.Maui.Controls, so we need UseMaui.
Fabulous.Maui: this is a still WIP and would wrap Microsoft.Maui.Core instead

The requirement for UseMaui for the Windows target could be an issue for Fabulous.Maui, but for now it's alright.


Having problems getting traildash to run

I can't run traildash via docker as our infrastructure isn't ready for that yet so I'm installing it via go get github.com/AppliedTrust/traildash and running it directly from the commandline (well, via chef any way on a VM box via vagrant) and then I forward the port I'm running the kibana board on port 80 to port 8000 on my host and try to access it.
All that happens is that I get is the board but with nothing on it (sometimes it does display values) and the url changes to http://localhost:8000/#/connectionFailed and then traildash dies, when I run it directly with traildash I get:
2015/03/19 12:25:51 Started
2015/03/19 12:25:51 web server exit

it does log out either:
2015/03/19 12:27:42 Empty queue... polling for 20 seconds.

or sometimes about pulling and deleting sqs information from Cloudtrail but I can't access the kibana board from the host or on the box (by doing curl localhost:80).
We have the following settings on elasticsearch btw:
http.cors.enabled: true
http.cors.allow-origin: "*"

Also I'm not seeing any errors about connecting to elasticsearch in the logging output.
I'm not sure what to do next.

I think the problem is that you need to take some special steps to bundle Kibana and a customized Kibana config file into the binary when you build it.  Two alternatives you could try:

Use the release from here, which includes Kibana in the binary: https://github.com/AppliedTrust/traildash/releases
Run these commands before building (these are from the Makefile):

curl -s https://download.elasticsearch.org/kibana/kibana/kibana-3.1.2.tar.gz | tar xvz -C .
mv kibana-3.1.2 kibana
cp assets/config.js kibana/config.js
cp assets/CloudTrail.json kibana/app/dashboards/default.json
go-bindata -pkg="main" kibana/...

Let me know how it goes!

Well, I just tried it and no dice, it still bleats about connection failed.

I'm having trouble, whenever I try to run the MakeFile Glock just errors with unable to find the GLOCKFILE even though I can physically see it, I even changed it's mode to 777 and yet still it errors.

This looks like your missing glock. Do you have glock installed?
go get github.com/robfig/glock
with that and traildash installed using:
go get github.com/AppliedTrust/traildash
you should be able to run glock install to get the hooks added to the repo:
glock install github.com/AppliedTrust/traildash

The problem was that the folder was spelt AppliedTrust when it was looking for appliedtrust >_<, bah, freaking capitals! Any way, No dice, still erroring with connection failed when run through chef and still doing :
2015/03/20 15:30:50 Started
2015/03/20 15:30:50 web server exit

ok, I got it working, not sure what I did but it's working (somtimes I don't pay attention to what I'm doing, bad habit), I did however remove the steps that @nmcclain mentioned so what I did to get it working didn't involve that.
Thanks for the help though.


HELP

Description
What steps will reproduce the problem?

What is the expected output? What do you see instead?
Please provide any additional information below
module = _import_module_from_path(module_name, plugin_path)
module = spec.loader.load_module(module_name)

File "", line 399, in _check_name_wrapper
File "", line 823, in load_module
File "", line 682, in load_module
File "", line 262, in _load_module_shim
File "", line 618, in _exec
File "", line 678, in exec_module
File "", line 219, in _call_with_frames_removed
from .pylint import Pylint as PLUGIN_CLASS
from .widgets.pylintgui import PylintWidget
import pylint
from .pkginfo import version as version
from setuptools import version as setuptools_version
ModuleNotFoundError: No module named 'setuptools'
Version and main components

Spyder Version: 3.2.6
Python Version: 3.6.3
Qt Versions: 5.6.2, PyQt5 5.6 on Windows

Dependencies
pyflakes >=0.6.0 :  1.6.0 (OK)
pycodestyle >=2.3:  2.3.1 (OK)
pygments >=2.0   :  2.2.0 (OK)
pandas >=0.13.1  :  0.20.3 (OK)
numpy >=1

Thanks for reporting. Did you try installing the latest version of setuptools, and are you running Spyder in the correct enviroment? If you read your error message,

ModuleNotFoundError: No module named 'setuptools'

Python seems to think it isn't installed, which isn't typically something within Spyder's control.
If that doesn't help, please try the steps listed in the Spyder Troubleshooting Guide, specifically the Basic First Aid and Emergency CPR sections, which resolve the great majority of Spyder installation issues.
If it still isn't working, please describe in detail the circumstances in which the error occurred, and post the information listed in relevant subsection of the Calling for Help section as a comment to this issue, and we'll try to help if we can. Otherwise, your issue will likely have to be closed after one week (7 days). Thanks, and best of luck!

Closed due to lack of response.


DRAFT: New validation limit API

Fixes #38

A question, can we guesstimate the number of iterations, even before iterating? With a formula like any of these:

COUNT
(min(.to_date(), UNTIL) - DTSTART) / FREQ
...

Another observation. What if we choose to go with the approach of having methods that take a limit argument, then how should one handle this scenario where the user uses the iterator API directly:
let rrule: RRuleSet = "DTSTART:20220101T090000Z\nFREQ=SECONDLY";

// `IntoIterator` is a trait in `std` and doesn't take any args.
let rrule_iter = rrule.into_iter();

// Then assume I for example want to get the string representation for the results
// OOPS! Infinite loop
let rrule_dates_str: Vec<String> = rrule_iter().map(|d| format!("{d}")).collect();

Another observation. What if we choose to go with the approach of having methods that take a limit argument, then how should one handle this scenario where the user uses the iterator API directly:

I would say it's fine. You can have not limited iterators in Rust itself.
Example: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=78fc0c06a38c641b976fd51a28a9b936

Ready for re-review! Changes made:

before and after methods are added to RRuleSet
RRuleSet::all and RRuleSet::all_with_error takes a limit whereas RRuleSet::all_unchecked and RRuleSet::all_with_error_unchecked is not limited.
Removed just_before and just_after methods as they can easily be achieved with the iterators API and I think it makes sense to keep the RRuleSet api surface lean and clean and let people use the iterator api for more complex queries.
all_between methods are removed.

I will make sure to update documentation etc once we have settled and agreed upon this API.

It looks a loOOOoo...oooOOt better <3
Thanks @fmeringdal


Add test for source names with quotes

Resolves #10582
Problem
We did not have tests for source names with characters requiring escaping in json.
Solution
Create a test case.
Checklist

[x] I have read the contributing guide and understand what's expected of me.
[x] I have run this code in development, and it appears to resolve the stated issue.
[x] This PR includes tests, or tests are not required or relevant for this PR.
[x] This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
[x] This PR includes type annotations for new and modified functions.

I wasn't sure about the changelog either. We probably should have a policy discussion on that.
I thought about a unit test, but we want to test writing the artifact and the way that's done makes for a kind of tricky unit test setup, where it's hard to be really confident that you're testing what you want to be testing.


feat: Added isOpen option to ManualSideBarGroup

What kind of changes does this PR include?

Changes to Starlight code

Description
Added an isOpen option to the groups in the sidebar. Sometimes you don't want a group to be expanded/open by default only if a user navigates to it or needs to see the topics.
Example:

The first Start Here group is without the option to defaults to true and acts like before. The second Start Here group has isOpen set to false in the astro.config.mjs.

Thanks for this PR @nikcio! We're actually already working on more or less this feature in #63! OK if we close this in favour of that?

@delucis Oh didn't see that. Go with that 😄


Feat: Pre push hook

Pull Request Overview
📝 Summary

Closes #79

🔄 Changes Made

Git Hooks Implementation:

Added pre-push hook that automatically runs sozo test before any code push

Makefile Enhancements: Added three new commands

make init:

Sets up Git hooks infrastructure
Creates and configures pre-push hook

make katana:

Launches Katana

make setup:

Builds the project
Initializes Torii

Summary by CodeRabbit
Release Notes

New Features

Introduced new katana, setup, and init targets to enhance the build process.
Added a setup.sh script for automated project setup and service initialization.
Expanded installation instructions in the README, including direct links for Git and Scarb installation.

Bug Fixes

Implemented a pre-push Git hook to ensure code quality by running tests before pushing.

Documentation

Updated README with clearer setup instructions and improved formatting for readability.

awesome @cristianFleita ! 🚀 we are testing this but it looks pretty good overall, thank you!

Hi @cristianFleita, I tested the pre-push hook and it looks good. Great job this will be really helpful! 🚀


i18n(zh-cn): Update components.mdx

Description

Update components.mdx
https://github.com/withastro/starlight/pull/1784
https://github.com/withastro/starlight/pull/2087

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

zh-cn
guides/components.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Nightly 2022-11-06 missing std?

I created a basic devshell with the example provided by the README, and I'm running into some strange issues. flake.nix is below:
{
  description = "A devShell example";

  inputs = {
    nixpkgs.url    = "github:NixOS/nixpkgs/nixos-unstable";
    rust-overlay.url = "github:oxalica/rust-overlay";
    flake-utils.url  = "github:numtide/flake-utils";
  };

  outputs = { self, nixpkgs, rust-overlay, flake-utils, ... }:
    flake-utils.lib.eachDefaultSystem (system:
      let
        overlays = [ (import rust-overlay) ];
        pkgs = import nixpkgs {
          inherit system overlays;
        };
      in
      with pkgs;
      {
        devShells.default = mkShell {
          buildInputs = [
            pkg-config
            (rust-bin.fromRustupToolchain { channel = "nightly-2022-11-05"; })
          ];
        };
      }
    );
}

Creating a devshell with this flake.nix file works just fine and the project compiles. However, if I change the channel to nightly-2022-11-06 and run nix develop again, the project fails to compile due to missing std. I tried a few other channels including beta and stable and none of them had the missing std issue, only nightly-2022-11-06 exhibits this problem.
I'm not sure if this is an issue with the overlay or the latest nightly, but it seemed strange that everything but that specific nightly seemed to be working fine.

rust changed its sysroot resolution, fenix ran into the same problem and was just fixed: https://github.com/nix-community/fenix/pull/91 in case you want to try to fix it for rust-overlay

Fixed since a1ce4b7c66ed9eb6fbefa88846e04a5341553ff2


Constrain the minimum height of an AppBar's toolbar

Currently an AppBar's toolbar is fixed at 56.0 per the material spec - https://material.io/guidelines/patterns/scrolling-techniques.html#scrolling-techniques-behavior.
It would be much more accommodating to only constrain the toolbar's minimum height.
This could be included as part of  https://github.com/flutter/flutter/issues/5288,
@Hixie

Is this still relevant?

Is this getting some changes soon or not? I am having problems with just width and I can't even fit a FlatButton with Text("Save") there

Another bump here. Should be easy fix.

I have situations where I want the height of the title to be less than 56 (this works currently for some reason). I also have situations where I want the title and actions to be more than 56, and making the AppBar higher does not allow for a higher title and actions which is disappointing. Making it higher than 56 does increase the height of the AppBar, but not the title area, and nothing will make the title and actions area higher. I would like the height of both the title and actions area and the AppBar area and the bottom to be modifiable. Thanks.

AppBar "flexibleSpace:" appears to solve this issue 100% for me. If this appears to be the case for other situations, perhaps this issue should be marked resolved.

And how about changeable width and FlatButton(child: Text("Save")) in the leading?

If you use "flexibleSpace:" you can specify your own widgets to be anything you like. In my case, I define an Icon, Text, Icon, Icon to emulate the standard AppBar toolbar. The Icons have a text above and below and the text for the title is two lines. All of these are within a "Container". I then use the "bottom:" for a TabBar. It works like a treat for me, so I cannot see why it wouldn't solve your problem. If you google it you should find some examples.


Updated dependencies

I noticed when trying to use this example that some dependencies were out of date. This is the result of running npm audit fix.

Thanks! It's curious that npm audit fix added wasm-test as a dependency. Merging this into and will investigate on another branch where I am upgrading to Webnative 0.35.


RuntimeError: CUDA error: invalid device ordinal

System Info
  File "/home/xxx/anaconda3/envs/xxx/lib/python3.11/site-packages/accelerate/state.py", line 211, in __init__
    torch.cuda.set_device(self.device)
  File "/home/xxx/anaconda3/envs/xxx/lib/python3.11/site-packages/torch/cuda/__init__.py", line 350, in set_device
    torch._C._cuda_setDevice(device)
RuntimeError: CUDA error: invalid device ordinal
CUDA kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
Compile with `TORCH_USE_CUDA_DSA` to enable device-side assertions.

Who can help?
No response
Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[X] An officially supported task in the examples folder
[ ] My own task or dataset (give details below)

Reproduction
run scripts: examples/sft/run_peft_deepspeed.sh
Expected behavior
run success

@pacman100 do you have an idea?


Implement cupsLocalizeDestMedia2

Currently the cupsLocalizeDestMedia2 function is not implemented. Need to copy this over from libcups.

[master 5c2e6023f] Implement cupsLocalizeDestMedia2 (Issue #1025)


[Feature] Add install section onto package sidebar

Is your feature request related to a problem? Please describe.
A small QOL change, can we add a section on the package sidebar with a npm install @package/name? Many of my coworkers (especially some not as versed with the javascript ecosystem would find this extremely helpful).
Describe the solution you'd like
Add a section to the package sidebar with a quick, simple copy-able command. Similar to the main npm registry.
Describe alternatives you've considered
The alternative would be to include a section in my README.md at the top with a simple:
npm install @package/name

It's not a huge update, but it's something simple that I think is missing to make Verdaccio as user friendly as possible.
I'd be happy to do it myself and start being a contributor to the project with some others input on what item it should display under.

Follow up on #1195 closing this one.


Evaluate moving framework installation outside of root dir

Currently, when we are running the factory, we take the framework image and copy everything we find to the root directory.
boot    etc     system  usr     var

COPY --from=framework / /

It seems there are some reported issues related to this: https://github.com/kairos-io/kairos-framework/pull/17#issuecomment-1852081522
For me, it is not clear why this would be an issue since the contents of the framework image are exclusive to what was installed with Luet. So the question is, can we copy the framework content somewhere else? And what does that imply?

The problem I mentioned was only with kaniko (more like a bug). It should be ok do do it like we do it here. If we ever have to build with kaniko and it doesn't work, we'll work around it then.


grains:  verify ordering of actual/expected

In the Jasmine testing framework, it is convention to:
expect(actual).fn(expected)

But some test suites have the following:
expect(expected).fn(actual)

This causes the error messages to be confusing.
Please verify the grains exercise to make sure that the expectations are ordered correctly. If they are, then this can be closed.
This issue will help to close #111

Got it

This one is OK and can be closed

Perfect :tada:


Personal Issue List

[x] tree_traversal: c++ - renamed to tree.cpp, fixed identifier style

[x] tree_traveral: ocaml - added back

[x] euclidean_algorithms: c++ - make sure it's good

[x] euclidean_algorithms: all - rename the "euclidean_example" files to "euclidean"

[x] convolutions: c++ - copy the fft from fft

[x] convolutions: c++ - rewrite to make it compile

[x] verlet: c++ - make sure it's good

[ ] sorting_searching: add C++

(gonna start fixing these once something similar to #61 is merged)

#86 are you done, now @ubsan?

Maybe a better place for this To do list is a project?
Since we have the new organization now, people have the possibility to create projects. I did a project for C#, which isn't that loose however and targets a more strict tracking process.
But if you plan (@ubsan) this issue more as an ongoing issue list, a project may be a better place for that.

ah, yeah, I've finished now.


refactor: move projects list into its own yaml file, fixes #5639

The Issue

https://github.com/ddev/ddev/issues/5639

How This PR Solves The Issue
Moves the projects list into its own ~/.ddev/projects.yaml file.
For now this is a fairly naive approach - I'd probably lean towards calling the file ~/.ddev/project_list.yaml, and renaming all of the GlobalProject* that I've added to ProjectList, i.e.

GetGlobalProjectsPath => GetProjectListPath
DdevGlobalProjects => DdevProjectList
DdevGlobalProjectName => DdevProjectListFileName
etc. If maintainers agree, I'll make those changes.

I'll admit I don't fully know what that list is used for - but running this locally everything seems to work as expected. I'll look at updating tests once maintainers have let me know if this is the right direction, and any general implementation changes they want.
Manual Testing Instructions
I'm honestly not sure what this list is for so I'm not sure what manual testing will actually show if it's working as expected.
Creating a new project did add it to the new file, .gotmp/bin/linux_amd64/ddev list worked as expected, and deleting the project removed it from the list.
Automated Testing Overview

To be done once I know if this is the right direction.
Related Issue Link(s)
https://github.com/ddev/ddev/issues/5639
Release/Deployment Notes

Not sure. Presumably since this is moving where the list is stored there could be some migration required to move the items from the old list to the new one.

This is a tricky task because we also need to allow people to downgrade without losing the project list.
What if DDEV keeps the project list in two files for now and reads it from projects.yaml, and in some future version we remove project_info from global_config.yaml 🤔
As for the function and variable names, I agree that Global should be removed.

I'm honestly not sure what this list is for so I'm not sure what manual testing will actually show if it's working as expected.

It is used in many places, for example, it allows you to execute ddev start project-name from any folder - so it knows that you have a project-name (from the global configuration file).

What if DDEV keeps the project list in two files for now and reads it from projects.yaml, and in some future version we remove project_info from global_config.yaml 🤔

Sounds good to me, that should be pretty straight forward. The fact that most of the test runs are passing already is a good sign that we won't end up missing any reads.
I am a little worried about the two (non-doc) failures though - I'm not sure what is causing those failures, and I'm hesitant to make the swap to keeping the list in both places until we know everything will be using the new file for reading without causing problems. Could you please help me understand what's causing those failures?

I am a little worried about the two (non-doc) failures though

Colima fails all the time, restarted the test.
The panic in ddev-macos-amd64-mutagen looks scary, we had some issues with Docker Desktop in this runner, it may not be related to your changes, restarted the test.

Here's a scenario we don't currently handle:

When upgrading, if there are any projects in project_info in global_config.yaml they will not be added to the new file, because we're not reading the project info from that file anymore.
As soon as the project list is written to the new file for the first time, the data from project_info will be overwritten.

That's probably not ideal behaviour - my current thinking is in (or after) ReadGlobalProjects() we should check DdevGlobalConfig.ProjectList - if that list does not match what we just read from the new projects list file, we can assume that we've just upgraded from an earlier version and that the global config content is correct.
Does that sound about right?
Also, do you want any new tests for this? If so, it'll be my first time properly writing new tests (until now I've just copied existing ones that were very similar to what I needed) so I'll need some guidance for where to put them and what sort of thing you want to be tested.

That's probably not ideal behaviour - my current thinking is in (or after) ReadGlobalProjects() we should check DdevGlobalConfig.ProjectList - if that list does not match what we just read from the new projects list file, we can assume that we've just upgraded from an earlier version and that the global config content is correct.

Sound right for me.

Also, do you want any new tests for this? If so, it'll be my first time properly writing new tests (until now I've just copied existing ones that were very similar to what I needed) so I'll need some guidance for where to put them and what sort of thing you want to be tested.

I've only written a few tests myself 🙂, looking for advice from @rfay here.

That's probably not ideal behaviour - my current thinking is in (or after) ReadGlobalProjects() we should check DdevGlobalConfig.ProjectList - if that list does not match what we just read from the new projects list file, we can assume that we've just upgraded from an earlier version and that the global config content is correct.

Sound right for me.

Sweet, I've done that. There might be a better way to compare maps - if so let me know and I'll make the change.

What I see in tests seems like it will be fine, but I won't be able to look at this carefully until probably February.

Sweet, no worries

I wasn't implying that it needs to wait for my attention. Stas is fully authorized to move forward on anything when he's comfortable with it.

Rebased because the artifact bot comment links were invalid (see #5662).

Good catch - I didn't notice that 'cause the ddev list command still shows those existing projects even though they're not in the file anymore (not sure where it's getting the info from...)
Should be fixed now.

DDEV inspects existing container labels for ddev list in addition to using the global config for this. So that's where things are coming from.

Thank you for all the hard work on this, merging.

awesome thank you for all the effort! already tested and i can confirm that right after the update ~/.ddev/project_list.yaml was created. with the identical number of projects listed in the global_config.yaml. at first i wanted to raise a question because of the redundancy between the two yaml files, but note to myself i should read the Release/Deployment Notes first properly ;) therefore instead of a question this confirmation that everything works and a thank you ;)


⚠ Processors has degraded performance

In a6d7238, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 55 ms

Resolved: Processors performance has improved in bee327b.


Figure out how to speed up OSX runs on Travis CI

This one timed out and was killed by Travis CI, and was reported as a failure: https://travis-ci.org/gimli-rs/gimli/jobs/165874003
We should figure out how to speed them up so that this doesn't become a recurring problem.

One idea: cache the .rustup directory in addition to .cargo?

I restarted the job, which I guess throws away the old logs. Lame. Basically, we timed out while doing a rustup for stable rust.

A big chunk of the OSX time is installing python for travis-cargo. Is it possible to cache that? I'm not sure that travis-cargo is providing much benefit, so we could also try replacing it with shell scripts.

A big chunk of the OSX time is installing python for travis-cargo. Is it possible to cache that?

Yes, I think so: https://docs.travis-ci.com/user/caching/#Arbitrary-directories

I'm not sure that travis-cargo is providing much benefit, so we could also try replacing it with shell scripts.

I'd like to do this only if caching the python/pip/brew stuff doesn't solve our problems.

OSX times in Travis are fine now.


Update openssl to version 1.1.1s for OpenJ9

See also https://github.com/eclipse-openj9/openj9/pull/16236.

Mac failures are unrelated.


@Test(singleThreaded = true) from (abstract) parent class should apply to all childs

I've got @Test(singleThreaded = true) on abstract class and i expect it to be applied to the child class(es) so that each child class can be run in parallel but only with one thread each.
Also when i add @Test(singleThreaded = true) to the child class it don't work either. But when i change testng.xml from
<suite name="Suite" preserve-order="false" parallel="tests">
	<test name="Test" preserve-order="false" parallel="classes">
		<packages>
			<package name="my.package" />
		</packages>
	</test>
</suite>

to
<suite name="Suite" preserve-order="false" parallel="tests">
	<test name="Test" preserve-order="false" parallel="false">
		<packages>
			<package name="my.package" />
		</packages>
	</test>
</suite>

tests pass! Also it's clear from logs (with thread name logging enabled) that test methods from one class are actually run in parallel.

Hello, @cbeust ! Can you reproduce this?

I haven't had a chance to look at it yet, sorry.


Add constraint manipulation methods

Closes https://github.com/dwavesystems/dimod/issues/1066
Closes https://github.com/dwavesystems/dimod/issues/1104

Good point, I went ahead and made the error messages a bit more generic. I don't love "items", but I think it will still be clear from context what is intended.

Codecov Report

Merging #1112 (68ed515) into main (77c9af7) will increase coverage by 0.02%.
The diff coverage is 96.55%.

@@            Coverage Diff             @@
##             main    #1112      +/-   ##
==========================================
+ Coverage   93.86%   93.88%   +0.02%
==========================================
  Files          88       88
  Lines        9205     9229      +24
==========================================
+ Hits         8640     8665      +25
+ Misses        565      564       -1

Impacted Files
Coverage Δ

dimod/utilities.py
91.66% <66.66%> (+0.63%)
:arrow_up:

dimod/constrained.py
94.24% <100.00%> (+0.23%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77c9af7...68ed515. Read the comment docs.


More options for sorting output rows and columns

Would be nice to be able to sort columns and rows for write.

Current hack:

write:
  - file:
  -   name: myfile
  -   where: |
  -      1 = 1
  -      ORDER BY category
  -      LIMIT 10


Roll engine 0e8ed2715a35..5041ff1b1e37 (23 commits)

https://github.com/flutter/engine/compare/0e8ed2715a35...5041ff1b1e37
git log 0e8ed2715a35..5041ff1b1e37 --first-parent --oneline
2020-02-11<EMAIL_ADDRESS>support endless trace buffer (flutter/engine#16520)
2020-02-11<EMAIL_ADDRESS>Expose DPI helper functions for Runner apps to use (flutter/engine#16313)
2020-02-11<EMAIL_ADDRESS>[fuchsia] Disable retained layers (flutter/engine#16548)
2020-02-11<EMAIL_ADDRESS>Revert "Use os_log instead of syslog on Apple platforms (#13487)" (flutter/engine#16546)
2020-02-11<EMAIL_ADDRESS>libtxt: use a fixture in the benchmarks (flutter/engine#16531)
2020-02-11<EMAIL_ADDRESS>Use os_log instead of syslog on Apple platforms (flutter/engine#13487)
2020-02-11<EMAIL_ADDRESS>Roll src/third_party/skia 50a490a1a4fb..c3b67eb988c8 (4 commits) (flutter/engine#16542)
2020-02-11<EMAIL_ADDRESS>Roll src/third_party/skia cdf2491afa04..50a490a1a4fb (2 commits) (flutter/engine#16541)
2020-02-11<EMAIL_ADDRESS>Roll src/third_party/skia dc2782c380f6..cdf2491afa04 (1 commits) (flutter/engine#16540)
2020-02-11<EMAIL_ADDRESS>Roll src/third_party/dart 30151a654151..76b18c455e2c (1 commits) (flutter/engine#16539)
2020-02-11<EMAIL_ADDRESS>Roll src/third_party/skia 4fe89b4d871d..dc2782c380f6 (1 commits) (flutter/engine#16538)
2020-02-11<EMAIL_ADDRESS>Roll src/third_party/dart 5fc031ebc1d7..30151a654151 (2 commits) (flutter/engine#16537)
2020-02-11<EMAIL_ADDRESS>Roll src/third_party/skia abefc9c170c9..4fe89b4d871d (2 commits) (flutter/engine#16536)
2020-02-11<EMAIL_ADDRESS>Roll src/third_party/skia 88c3793a4eaa..abefc9c170c9 (1 commits) (flutter/engine#16535)
2020-02-11<EMAIL_ADDRESS>Roll src/third_party/skia f83d0346c06a..88c3793a4eaa (1 commits) (flutter/engine#16534)
2020-02-11<EMAIL_ADDRESS>Roll src/third_party/dart 5244d99a5d4e..5fc031ebc1d7 (42 commits) (flutter/engine#16533)
2020-02-11<EMAIL_ADDRESS>Roll src/third_party/skia 21f382c19d76..f83d0346c06a (2 commits) (flutter/engine#16532)
2020-02-11<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from PMcw3... to 7JkB7... (flutter/engine#16530)
2020-02-11<EMAIL_ADDRESS>Roll fuchsia/sdk/core/linux-amd64 from 8L7NY... to Bmq1m... (flutter/engine#16529)
2020-02-11<EMAIL_ADDRESS>Roll src/third_party/skia 465864cad5d2..21f382c19d76 (6 commits) (flutter/engine#16528)
2020-02-10<EMAIL_ADDRESS>Clear frame references at the end of every CanvasKit frame (flutter/engine#16525)
2020-02-10<EMAIL_ADDRESS>Enable verbose logging for shell unittests on Fuchsia (flutter/engine#16526)
2020-02-10<EMAIL_ADDRESS>Roll src/third_party/skia c03e6982f96f..465864cad5d2 (14 commits) (flutter/engine#16524)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Commit queue failed; closing this roll.


*(ticdc): enable new scheduler by default

What problem does this PR solve?
Issue Number: ref #4126
What is changed and how it works?
Check List
Tests

Unit test
Integration test

Release note
Enables a new scheduler.

/run-integration-tests

/run-integration-tests

/run-kafka-integration-test

/run-leak-tests
/run-integration-tests
/run-kafka-integration-tests

/run-verify

/run-leak-tests
/run-integration-tests
/run-kafka-integration-tests

/run-verify

/run-kafka-integration-tests

/run-integration-tests
/run-kafka-integration-tests

/run-kafka-integration-tests

/run-kafka-integration-tests

/run-kafka-integration-tests

/run-integration-tests
/run-kafka-integration-tests

/run-integration-test
/run-kafka-integration-test

/run-integration-test
/run-kafka-integration-test

/run-integration-test
/run-kafka-integration-test

Codecov Report

Merging #4836 (17517a0) into master (9607554) will increase coverage by 0.4197%.
The diff coverage is 66.4299%.

Flag
Coverage Δ

cdc
60.5294% <66.4299%> (+0.6072%)
:arrow_up:

dm
52.4306% <ø> (+0.4017%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #4836        +/-   ##
================================================
+ Coverage   55.6402%   56.0599%   +0.4197%
================================================
  Files           494        522        +28
  Lines         61283      65157      +3874
================================================
+ Hits          34098      36527      +2429
- Misses        23750      25065      +1315
- Partials       3435       3565       +130

/merge


HV-847: Allowing to use @SupportedValidationTarget to resolve target ambiguity of purely composed constraint

For now I just added support for resolving the ambiguity by meta-annotating the constraint definition with @SupportedValidationTarget.
Trying to deduct the target from composing constraints led to some chicken/egg issue: to do so, I need to parse the composing constraints first, but for that I need the constraint type of the composed constraint. I guess it could be sorted out somehow, but it didn't seem worth the effort: It's an border case, and explicit resolution is needed anyways as a fallback in case deduction from the composing constraints fails. I'd say we can add that should the subject be defined in the spec.

Looking good, just the typo. I can fix that ...

Cool, thanks!

Merged.


Find a holistic way to encode xml doc writer methods

We should safe guard against xml characters in the summary writer methods in autorest.  In this PR https://github.com/Azure/autorest.csharp/pull/3053 I covered one known case which is property descriptions from cadl, but this is just one of many places these can come from.
We should look into making sure all of the methods like these have this encoding at the base layer so that we won't have build breaks regardless of where it comes from.

We also need to solve use cases like this: https://github.com/Azure/autorest.csharp/blob/54cc349bb728fd6b5e30574bf00f4740704550bc/src/AutoRest.CSharp/Common/Output/Models/RestClientBuilder.cs#L85
This is escaping inside parameter or methods, in fact we should need to keep the raw strings in those models, only escape them when we are about to write the xml document. Doing this will avoid the "double escape" issue


fix: Onboarding UTI for macOS

- What I did

Documented additional setup steps for at_onboarding_flutter with macOS

It is now required that the developer adds a Universal Type Identifier (UTI) for the .atKeys file extension in order to enable a proper onboarding experience in macOS

Added this additional configuration to each of the example apps
- How I did it

- How to verify it
- Description for the changelog
fix: Onboarding UTI for macOS

It's expected that melos bootstrap fails until the work in #741 is completed


does it support open source presto ? We wanted to use it to compare the data between presto and postgres tables.

Presto is not on the roadmap as of now.


[ROIAlign] refactor to nnvm interface & unified impl for cpu/gpu

Description

[x] Unified kernel for both cpu/gpu.

[x] Refactor to nnvm interface since old operator interface is deprecated, here is a PR to refactor operators https://github.com/apache/incubator-mxnet/pull/8302.

[x] Replace tensor operation in mshadow with kernel launch since mshadow is deprecated and some kernels might be faster.
For example, replace https://github.com/TuSimple/mx-maskrcnn/blob/master/rcnn/CXX_OP/roi_align-inl.h#L116 grad_in = 0.0f with Fill in init_op.h which will be faster accordding to https://github.com/apache/incubator-mxnet/pull/8340.

[x] Remove some unneccessary initialization.
Since forward kernel will loop through all the indexes, are the initializations here neccessary? https://github.com/TuSimple/mx-maskrcnn/blob/master/rcnn/CXX_OP/roi_align-inl.h#L76-L78

[x] fix initialization of maxval here for other DType, https://github.com/TuSimple/mx-maskrcnn/blob/master/rcnn/CXX_OP/roi_align.cu#L68 Dtype maxval = is_empty ? 0 : -FLT_MAX
Replaced with mshadow::red::limits::MinValue<DType>().

Checklist
Essentials

[x] Passed code style checking (make lint) if copy these three new files to mxnet/src/operator/contrib
[x] Passed the test below with the latest mxnet, please also copy the old three files to mxnet/src/operator

import mxnet as mx
import numpy as np
from mxnet.test_utils import assert_almost_equal

def test_roi_align():
    # x and y are same with test_roipooling at https://github.com/apache/incubator-mxnet/blob/master/tests/python/unittest/test_operator.py#L2106
    x = np.random.rand(4, 3, 12, 8).astype('float32')
    y = np.array([[0, 1.1, 1.1, 6.2, 6.2], [2, 6.1, 2.1, 8.2, 11.2],
        [1, 3.1, 1.1, 5.2, 10.2], [0, 3, 3, 3, 3]], dtype='float32')

    def check_roi_align(context, spatial_scale):
        data = mx.nd.array(x, ctx=context)
        rois = mx.nd.array(y, ctx=context)
        data.attach_grad()
        rois.attach_grad()
        with mx.autograd.record():
            pool = mx.nd.contrib.ROIAlign_v1(data, rois, (4, 4), spatial_scale)
        pool.backward()
        out_contrib = pool.asnumpy()
        grad_data_contrib = data.grad.asnumpy()
        grad_roi_contrib = rois.grad.asnumpy()

        data = mx.nd.array(x, ctx=mx.gpu(0))
        rois = mx.nd.array(y, ctx=mx.gpu(0))
        data.attach_grad()
        rois.attach_grad()
        with mx.autograd.record():
            pool = mx.nd.ROIAlign(data, rois, (4, 4), spatial_scale)
        pool.backward()
        out = pool.asnumpy()
        grad_data = data.grad.asnumpy()
        grad_roi = rois.grad.asnumpy()

        assert_almost_equal(out_contrib, out)
        assert_almost_equal(grad_data_contrib, grad_data)
        assert_almost_equal(grad_roi_contrib, grad_roi)

    check_roi_align(mx.gpu(0), 1.0)
    check_roi_align(mx.cpu(), 1.0)
    check_roi_align(mx.gpu(0), 0.8)
    check_roi_align(mx.cpu(), 0.8)

if __name__ == '__main__':
    test_roi_align()

Comments

This operator is not tested in real training.

Thanks for the PR, we'll merge the code after test it on cityscapes.

Tested ROIAlign_v1 on the RCNN2 stage of alternate training and the result is OK. Full test is ongoing.

Checked on a full 4 stage training on 8 GPUs, get 32.1AP on val.
This is OK to merge.
@winstywang @Zehaos

@ZiyueHuang The new interface seems to make the namespace quite messy. Now we can not use addAtomic by simply include ../../common/cuda_utils.h. So could you please shed some light on how the code is organized? Many thanks.

Sure. I will look into it. Thanks for reporting.

atomicAdd cannot be directly used in the header file. You can specialized the implementation for cpu  version in .cc and gpu version .cu, like SparseEmbedding https://github.com/apache/incubator-mxnet/blob/master/src/operator/tensor/indexing_op.cu#L59.
Or you can consolidate this with the gpu kernel by using #if __CUDA__ #else in the header file. That would make the implementation less verbose.
Please let me know if you have any further questions.


Add PHI checklist to documentation and link on Metadata page

@adswafford, could you send us that list so it can be added?


generic-auth: use extended validation for applying rules

Currently, the generic auth plugin applies authorization rules during the execution phase, as the resolvers are called.
I think this has some confusing behavior, as parts of a mutation/query/subscription operation will be executed before yielding an error (that might even bubble up, thus resulting in the whole execution result data being null).
While building the advanced tutorial examples, this popped up:
type Mutation {
    signup(email: String!, password: String!, name: String!): AuthPayload @skipAuth
}

type User {
  id: ID!
  name: String!
}

type AuthPayload {
  token: String
  user: User
}

With the current behavior, this allowed executing the operation resolver (Mutation.signup), but if you added a selection for the field token, you got an unauthenticated error. So the user was created in the database and ultimately you did not receive the response because as the result was constructed the auth rule was applied for the AuthPayload.token resolver.
I personally think it makes sense to apply GraphQL based authorization rules via the extended validation phase and then reject either the whole operation document or allow executing the complete operation document.

See https://github.com/dotansimha/envelop/pull/998


How about simple methods such as min and max

It seems like the library doesn't support these.

Not efficient at all, but here's what I'm using. I'm sure there's a clever way to do this with mapreduce.
The following are done up to dig into nested arrays and find the max or min values in them. From StackOverflow.
	arrmax = (arrs) -> 		toplevel = [] 		i = 0 		l = arrs.length 		while i < l 			toplevel.push Math.max.apply(window, arrs[i]) 			i++ 		Math.max.apply window, toplevel 	arrmin = (arrs) -> 		toplevel = [] 		i = 0 		l = arrs.length 		while i < l 			toplevel.push Math.min.apply(window, arrs[i]) 			i++ 		Math.min.apply window, toplevel


readme: Slack invite link has expired

This link in the readme:
Slack: https://aka.ms/azconfig/slack
Leads me a page at slack that says "This invite link is no longer active. Please check with the person who shared it with you to see if there's a new link available." and I'm unable to join.

@richardpark-msft can you please try again? The link is set to not expire, but @yegu-ms just refreshed it anyway.

That did it - thanks!


add distributor Conversations

Conversations, a popular XMPP client, can now act as a UnifiedPush distributor. See changelog.

Thanks! I'll add some more info and then merge this.


Issue running Blazor in tutorial

URL
https://dotnet.microsoft.com/en-us/learn/aspnet/blazor-cli-tutorial/run
Operating system
windows
More information about your system
Windows 11 23H2 (OS Build 22631.4317) on x64
Description
Issues while running tutorial.  It looks like the Microsoft.NET.Sdk.StaticWebAssets.target want the PackageId variable but it isn't set
PS C:\dev\repos\BlazorApp> dotnet watch
dotnet watch 🔥 Hot reload enabled. For a list of supported edits, see https://aka.ms/dotnet/hot-reload.
💡 Press "Ctrl + R" to restart.
dotnet watch 🔧 Building...
Determining projects to restore...
All projects are up-to-date for restore.
C:\Program Files\dotnet\sdk\8.0.403\Sdks\Microsoft.NET.Sdk.StaticWebAssets\targets\Microsoft.NET.Sdk.StaticWebAssets.target
s(507,5): error MSB4044: The "DiscoverStaticWebAssets" task was not given a value for the required parameter "SourceId". [C
:\dev\repos\BlazorApp\BlazorApp.csproj]
dotnet watch ⏳ Waiting for a file to change before restarting dotnet...
dotnet --info
.NET SDK:
Version:           8.0.403
Commit:            c64aa40a71
Workload version:  8.0.400-manifests.18f19b92
MSBuild version:   17.11.9+a69bbaaf5
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.22631
OS Platform: Windows
RID:         win-x64
Base Path:   C:\Program Files\dotnet\sdk\8.0.403\
.NET workloads installed:
Configured to use loose manifests when installing new manifests.
There are no installed workloads to display.
Host:
Version:      8.0.10
Architecture: x64
Commit:       81cabf2857
.NET SDKs installed:
6.0.427 [C:\Program Files\dotnet\sdk]
8.0.403 [C:\Program Files\dotnet\sdk]
.NET runtimes installed:
Microsoft.AspNetCore.App 6.0.35 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 8.0.10 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 6.0.35 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 8.0.10 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 6.0.35 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 8.0.10 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Other architectures found:
None
Environment variables:
Not set
global.json file:
Not found
Learn more:
https://aka.ms/dotnet/info
Download .NET:
https://aka.ms/dotnet/download

I was able to fix this myself by adding a PackageId property to the PropertyGroup section in BlazorApp.csproj.


Missing deprecation from phpunit 10?

It seems setMethods on mockBuilder is deprecated in PHPUNIT 10, this rule is currently under the codestyle setlist, but it seems it should be in the phpunit10 setlist? Am i missing something?
https://github.com/sebastianbergmann/phpunit/pull/3687
 RemoveSetMethodsMethodCallRector::class, is the class im talking about.

You're right :+1:  Could you add it to particular set?

Hmm, the thing is though. The rector is pretty simple, just remove it. But seems like it is technically a little different.
Its has been deprecated in phpunit https://github.com/sebastianbergmann/phpunit/commit/d618fa3fda437421264dcfa1413a474f306f79c4 so should we fix it since phpunit 8?
Also there are alternatives as mentioned here: https://github.com/sebastianbergmann/phpunit/pull/3687 (with somemore deprecation info).
What should rector do? Remove usage from 8 and up? Or even make the replacement better, although im not sure it is even possible since the signatures are a little different.

Open a PR which moves it to the phpunit_100  setlist


Create groups without using the dashboard

Right now to create a group you need to use the dashboard, it would be nice to create groups dynamically using code without using the dashboard.

Ya we very much need this capability for discreetly. We will likely have 2 groups for most chat rooms, members, and admins

Might be a duplicate of #318


Feature Request: Subsetting and Merging Variable Font axes

Per Nick Shinn's proposal in http://typedrawers.com/discussion/comment/23887/#Comment_23887 I suppose that fontTools ought to perform subsetting and merging of Variable Font axes.
Eg, a VF has 34 axes and I'm only interested in 3 of them for my webpage, I'd like to subset the font to make it load faster.

That would certainly be useful... after FontTools is fully supporting creation of all the new tables in OT1.8.

For sure! Just wanted to file this idea for later, so it wasn't lost =)

I call this operation "partially instantiating".  Eg. set the width, but retain weight axis.  There's a tiny issue with doing these with respect to the 0x91 GETVARIATIONS hinting instruction.  We need to go back to rewriting those as 0x92 and use IDEF to fill in the removed axes.

I call this operation "partially instantiating"

Yes, this sounds like a good name :)
Related question: is 'full instantiating' a named instance of a VF into a 'legacy' non-VF font supported today in fontTools? If yes, how to do it? :)

Related question: is 'full instantiating' a named instance of a VF into a 'legacy' non-VF font supported today in fontTools? If yes, how to do it? :)

The start of that is in fontTools.varLib.mutator.
I have to merge varLib.__init__, varLib.instantiate_layout, and varLib.mutator into the same architecture, instead of having to implement everything three times.


ERROR: InexactError: trunc(Int64, Inf)

Here is a MWE:
function calc!(x)
    delta_fp = 2
    phase_fp = Int32(0)
    @avx for i = 1:length(x)
        phase_fp = phase_fp + delta_fp
        phase_int = phase_fp >> 17
        x[i] = phase_int
    end
end
x = Vector{Int32}(undef, 100)
calc!(x)

ERROR: InexactError: trunc(Int64, Inf)
Stacktrace:
 [1] trunc at ./float.jl:702 [inlined]
 [2] round at ./float.jl:367 [inlined]
 [3] unroll_no_reductions(::LoopVectorization.LoopSet, ::Array{Symbol,1}, ::Symbol, ::Int64, ::Int64) at /home/zorn/.julia/packages/LoopVectorization/9Qgzg/src/determinestrategy.jl:151
 [4] determine_unroll_factor(::LoopVectorization.LoopSet, ::Array{Symbol,1}, ::Symbol, ::Symbol) at /home/zorn/.julia/packages/LoopVectorization/9Qgzg/src/determinestrategy.jl:170
 [5] choose_order(::LoopVectorization.LoopSet) at /home/zorn/.julia/packages/LoopVectorization/9Qgzg/src/determinestrategy.jl:550
 [6] lower(::LoopVectorization.LoopSet, ::Int8) at /home/zorn/.julia/packages/LoopVectorization/9Qgzg/src/lowering.jl:497
 [7] avx_body(::Tuple{Int8,Int8,Int8}, ::Array{LoopVectorization.Instruction,1}, ::Array{LoopVectorization.OperationStruct,1}, ::Array{LoopVectorization.ArrayRefStruct,1}, ::Core.SimpleVector, ::Core.SimpleVector, ::NTuple{4,DataType}) at /home/zorn/.julia/packages/LoopVectorization/9Qgzg/src/reconstruct_loopset.jl:225

I'm closing this issue because:
julia> using LoopVectorization

julia> function calc!(x)
           delta_fp = 2
           phase_fp = Int32(0)
           @avx for i = 1:length(x)
               phase_fp = phase_fp + delta_fp
               phase_int = phase_fp >> 17
               x[i] = phase_int
           end
       end
calc! (generic function with 1 method)

julia> calc!(x)
200

julia> function calc2!(x)
           delta_fp = 2
           phase_fp = Int32(0)
           @avx for i = 1:length(x)
               phase_fp = phase_fp + delta_fp
               phase_int = phase_fp >> 17
               x[i] = phase_int
           end
       end
calc2! (generic function with 1 method)

julia> x2 = Vector{Int32}(undef, 100);

julia> calc2!(x2)
200

julia> x == x2
true

It still needs better support for mixing types.
Feel free to create an issue for that, if (e.g.) you want to try and convert between fixed and floating point.


Feature/client-family-intake-form

https://www.loom.com/share/b9aa3514960248909b159ba35dc4c1ee
3-28-2022
What work was done?

Added the rest of the form, as much as I could, using Steven Clair's First Section as a guide. The css and modals to add sets of information for separate family members, work history, and such still need completion but the bulk of the intake form is now there.

Why was this work done?
The Intake Form is one of the basic items we promised to deliver to the stakeholder.
https://trello.com/c/uE0HDt7Y/28-design-the-intake-section
Type of Change

[x] Feature

Change Status

[x] Almost complete, tested, ready to review, and merge. I actually tested everything seconds before pushing up to git but now I can't get the software to load locally on my machine.

Checklist

[x] My code follows the style guidelines of this project.
[x]  I have performed a self-review of my own code.
[ ]  My code has been reviewed by at least one peer
[x] I have commented my code, particularly in hard to understand areas.
[x] My changes generate no new warnings.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] There are no merger conflicts.

I AM CLOSING THIS PR and it should not be merged since Steven Clair and I are going to refactor everything to be in smaller components based on the section of the intake form. We will submit new PRs soon.


Problems badge does not have the same colour as other badges

The problems panel badge is not the same colour as other badges. They should be blue in this case instead of grey.

@stevencl I believe we have primary (blue) and secondary badges (grey). These secondary badges also show up in the debug viewlet, opened editors, and search results (settings, keyboard shortcuts). So these are intentionally a different color.

Sounds good.


Switched broken pypip.in badges to shields.io

Hello, this is an auto-generated Pull Request. (Feedback?)
Some time ago, pypip.in shut down. This broke the badges for a bunch of repositories, including django-query-builder-pebble. Thankfully, an equivalent service is run by shields.io. This pull request changes the badges to use shields.io instead.
Unfortunately, PyPI has removed download statistics from their API, which means that even the shields.io "download count" badges are broken (they display "no longer available". See this). So those badges should really be removed entirely. Since this is an automated process (and trying to automatically remove the badges from READMEs can be tricky), this pull request just replaces the URL with the shields.io syntax.

My apologies. It appears that my code made a mistake with your repo.
(It doesn't seem to handle non-master default branches quite right.)
I am sorry for any incovenience.


chore: Release 0.24.1

:robot: I have created a release beep boop
root: 0.24.1
0.24.1 (2023-09-03)
Bug Fixes

Add WASI 20 _initialize call to acvm_backend.wasm binary (#518) (ec6ab0c)

acir: 0.24.1
0.24.1 (2023-09-03)
Miscellaneous Chores

acir: Synchronize acvm versions

acir_field: 0.24.1
0.24.1 (2023-09-03)
Miscellaneous Chores

acir_field: Synchronize acvm versions

acvm: 0.24.1
0.24.1 (2023-09-03)
Miscellaneous Chores

acvm: Synchronize acvm versions

Dependencies

The following workspace dependencies were updated

dependencies

brillig_vm bumped from 0.24.0 to 0.24.1

acvm_blackbox_solver: 0.24.1
0.24.1 (2023-09-03)
Bug Fixes

Add WASI 20 _initialize call to acvm_backend.wasm binary (#518) (ec6ab0c)

acvm_js: 0.24.1
0.24.1 (2023-09-03)
Bug Fixes

Add WASI 20 _initialize call to acvm_backend.wasm binary (#518) (ec6ab0c)

Dependencies

The following workspace dependencies were updated

dependencies

acvm bumped from 0.24.0 to 0.24.1

acvm_stdlib: 0.24.1
0.24.1 (2023-09-03)
Miscellaneous Chores

acvm_stdlib: Synchronize acvm versions

brillig: 0.24.1
0.24.1 (2023-09-03)
Miscellaneous Chores

brillig: Synchronize acvm versions

brillig_vm: 0.24.1
0.24.1 (2023-09-03)
Miscellaneous Chores

brillig_vm: Synchronize acvm versions

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/noir-lang/acvm/releases/tag/root-v0.24.1 :sunflower:

:robot: Release is at https://github.com/noir-lang/acvm/releases/tag/acir-v0.24.1 :sunflower:

:robot: Release is at https://github.com/noir-lang/acvm/releases/tag/acir_field-v0.24.1 :sunflower:

:robot: Release is at https://github.com/noir-lang/acvm/releases/tag/acvm-v0.24.1 :sunflower:

:robot: Release is at https://github.com/noir-lang/acvm/releases/tag/acvm_js-v0.24.1 :sunflower:

:robot: Release is at https://github.com/noir-lang/acvm/releases/tag/brillig-v0.24.1 :sunflower:

:robot: Release is at https://github.com/noir-lang/acvm/releases/tag/brillig_vm-v0.24.1 :sunflower:

:robot: Release is at https://github.com/noir-lang/acvm/releases/tag/acvm_stdlib-v0.24.1 :sunflower:

:robot: Release is at https://github.com/noir-lang/acvm/releases/tag/acvm_blackbox_solver-v0.24.1 :sunflower:


[Backport 2.3] Monitoring: Pod Usage (CPU/Memory) is doubled

https://github.com/rancher/rancher/issues/25539

Monitoring v0.1.0 is now available in dev-v2.3, which is what is v2.3-head is pointing to.

The bug fix is validated in v2.3-head a0c372a82
Steps:

run Rancher v2.3.5 single install
add an ec2 cluster
enable the cluster monitoring
deploy a workload with the image progrium/stress, set Command to --cpu 1 and set the CPU limit to 150
check the pod metrics in Grafana (from the pod page)

Results:

the values in the metrics are correct, and the current does not exceed the limit.

I am running version 2.7.5 on arm64 and there it still exists. Cluster metrics show exactly double the memory than grafana.


build: downgrade bazel to 3.6.0

Description: On bazel 3.7.2 we no longer can see Java error output in builds. Downgrading for now, since this significantly impedes development and debugging.
Risk Level: Low
Testing: Local & CI
Signed-off-by: Mike Schore<EMAIL_ADDRESS>

tracking issue here: https://github.com/envoyproxy/envoy-mobile/issues/1300


programs/nh: allow flake uris to be set

This allows a configuration like
  programs.nh = {
    enable = true;
    flake = "github:shawn8901/nix-configuration";
  };

which lets the user use nh module even when the flake is not available locally (nh itself supports that anyways already).
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@Shawn8901 In any case, NH 4.0 will support any installable (-f, --expr, etc) and I want to support multiple env variables. So we will probably have to rework the module in any case.

Honestly i am not sure if i misunderstand the intention of the comment (or am just super salty at the time reading the response). Unless there is a planned release date for that reworked 4.0 version within the next days, wouldn't it be more okayish to just improve the UX on the old state?
But it sounds for me, that we are preferring to wait for some rework in the future.
For me sad, as it kind of just started about arguing about how a flake reference might look like and give examples about it (but those should be hopefully known anyways, when using flakes, as they are used on every ones input attrs).
But i am fine in not doing it and just pick that change to my own fork until there is some rework available.

I already approved the PR, just wanted to add that remark

For me sad, as it kind of just started about arguing about how a flake reference might look like and give examples about it

I came here to merge this you know. There was no need to close this PR.

Ran into this issue just now. Can we re-open this? Or shall I open a new MR?

Reopening this isn't possible as the OP deleted their branch, just cherry-pick the commite

Ran into this issue just now. Can we re-open this? Or shall I open a new MR?

Feel free to open as a new PR


[Bug] README.md Installation step should describe required Menu.Main config.toml setting

Expected behavior
Following hugo getting started and castanet installation instructions should result in a basic rendered hugo site.
Actual behavior
After following hugo getting started and castanet installation hugo server -D displays an error related to Site.Menus.
Reproduction Steps
Starting from scratch, follow hugo getting started steps and install the castanet theme. hugo server -D displays an error no rendered website.
Operating System and Version
n/a
Web Browser and Version
n/a
Hugo Version
hugo v.0.36.1 windows/amd64

This fix for this could be just to document adding the menu to the config.toml as a required step in the installation instructions.

I think I can actually add some code that will check to see if there are any menu elements before trying to display them.


Automatic flashing fails with multiple source directories?

Hello there,
I recently found this article in the docs (see "Managing multiple Mbed projects") that describes how to use one instance of the mbed library for multiple projects.
Now I have setup a folder structure like this for testing purposes:
Multiple-Projects-Test/
`- mbed-os/
`- my_project/
`- BUILD/

And I call mbed-cli (from within the Multiple-Projects-Test folder) like this:
mbed compile --build=BUILD/my_project/(...) --source my_project --source mbed-os -t GCC_ARM -m DISCO_F769NI -f
But here comes the weird part:

The binary file is built correctly, inside the correct build folder and it does what I'd expect it to.
However, flashing the MCU (through -f) fails, since it looks for a file called BUILD/my_project/(...)\Multiple-Projects-Test.bin

Which is the name of the parent folder, whereas the path to the binary file is BUILD/my_project/(...)\my_project.bin
My Mbed-cli version is 1.10.1.
Is this intended behaviour?
Kind regards,
Andreas

Internal Jira reference: https://jira.arm.com/browse/IOTBTOOL-411

Stumbled across a solution to my problem.
mbed compile has a CLI option --artifact-name that allows to specify the name of the bin file.
Could anybody add this to the docs in the article that mentions this?
Sticking to the example used there but with automatic flashing it would be something like:
$ mbed compile -t ARM -m LPC1768 --source project1 --source mbed-os --build BUILD/project1 -f --artifact-name project1
$ mbed compile -t ARM -m K64F --source project2 --source mbed-os --build BUILD/project2 -f --artifact-name project2

Or correct me if I'm mistaken, but that's what works for me.


Rework examples layout

This is a rework of  https://github.com/icerpc/icerpc-csharp/pull/3750
Mostly renamed core to icerpc and kept interop for examples that show interoperability with ZeroC Ice.

I think you should:

move all examples that use Slice into the slice sub-directory
keep the renaming examples in "icerpc" but rename icerpc to "no-idl"
in follow-up PRs, add more protobuf examples (Logger, Thermostat, Quic and more) that duplicate the slice examples, except they use Protobuf.

I think you should:

Applied these suggestions, and let additional Protobuf examples for follow up PRs


[gen-typescript-declarations] Patching missing dependency for typescript generator

Fixes #816
This PR moves source-map-support from dev dependencies to dependencies.
P.S.
I am not sure how the workflow looks like here. Should --require source-map-support/register be removed from packages/gen-typescript-declarations/test/mocha.opts?

Thanks for the PR!

P.S.
I am not sure how the workflow looks like here. Should --require source-map-support/register be removed from packages/gen-typescript-declarations/test/mocha.opts?

We still need it here, since the tests don't invoke cli.ts, which is where source-map-support is required.

Great, thanks


An API Key is not optional as described in the documentation (TypeScript)

According to the documentation an API Key is optional, but in TypeScript the typing says it is mandatory.

Ah, my bad. I'll fix it and publish tonight.

Fixed in v4.2.4 🎉


Add validation to metric names, slight refactoring

I was going through some old forks of mine and realized I had made some changes on a branch.
This may have also served as a fix for https://github.com/sm-Fifteen/asgi-server-timing-middleware/issues/3.
I can confirm that this code does indeed work in a production application.
Frankly, I don't entirely remember exactly what my changes achieve, since it has been fifteen months since I looked at this. I think I added some validation and a few other conveniences.
Please merge if you think these changes are useful! Let me know if you need me to explain any parts in greater detail.

Woah, you basically rewrote the whole thing! It's certainly a lot more proper than what I had before, and I can already see a number of benefits to some of these changes, like performing validation while creating ServerTimingMetricName instead of when initializing the middleware. I'll be sure to give it a try before merging.
Any reason why you used attrs instead of dataclasses for your data structures?
PS: Sorry if I've been leaving the issues and PRs to languish for so long, I've really neglected my personnal Github projects in recent years.

Any reason why you used attrs instead of dataclasses for your data structures?

I couldn't say 😅 Like I wrote earlier, I haven't looked at this in fifteen months. As a quick guess, I assume I wanted to leverage the field validation facilities attrs provides. Let me think on it.
It may be a good idea to replace attrs in favor of a standard library implementation in order to eliminate the dependency.

I began removing the dependency on attrs. I'll finalize this pull request soon.

Hi @sm-Fifteen! Take a look when you get the chance.

Alright, sorry for taking so long to come back to this, I'm looking at it now.

I notice you have two separate structures, which you convert between using server_timing_metrics_to_dict(), and that strikes me as unneccessary? You even reimplement some methods across both, so I'm not entirely sure why you don't simply use the same one?
You have description be a field in _ServerTimingMetricName, but you should probably have it live in ServerTimingMetric. Despite the name, "description" isn't actually meant to be a longer description of what the metric name stands for (which would be a waste of bandwidth). It's never spelled out out lout in the spec, but the examples use customView, dc;desc=atl to indicate that some request was routed through the "atl" datacenter, for instance.

I would actually change the doc to read "A text value for the Server-Timing metric." instead of "A description for the Server-Timing metric."
In fact, I'm pretty sure I used to have a yappimem;desc="1234k" ServerTiming metric to let users keep track of how close the profiler was getting to the limit (I really don't know why I didn't keep it in).

It occured to me while reviewing your code that quoted strings still need to escape double-quotes and backslashes, which I myself forgot to do. It's just a re.sub(r'(["\\])', r'\\\1', desc_text) substitution, but now that it's a properly structured project, I guess it would be a sin to forget it.

That aside, it looks pretty good!

Woah, I totally forgot about this pull request. Maybe I'll get around to it. Sorry for the long wait!

Don't worry about it. I've been in a continuous cycle of forgetting and remembering about this repo for the past 4 years, I understand how it's like.


Fixed Add button and added Cyio Dialog box in UI

Proposed changes

Related issues

Checklist

[x] I consider the submitted work as finished
[x] I tested the code for its functionality
[ ] I wrote test cases for the relevant uses case
[ ] I added/update the relevant documentation (either on github or on notion)
[ ] Where necessary I refactored code to improve the overall quality

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

this changes required to address this issue appear to be included in another PR, so I'm closing this PR.


unkillable zombie process left behind on osx

Latest OSX/Visual Studio Code
Existing instance was unresponsive, tried killing it and launching a fresh instance - failed saying the port was in use.
Investigated at the terminal and discovered there were a number of processes still active.
ps awux | grep -i electron

b                  574 124.3  0.0  4418348   4932   ??  R    Sat04pm 225:49.03 /var/folders/tt/8d93bx550wzdp20cw56gl5400000gn/T/AppTranslocation/5D9818E0-2B53-4E49-8F2D-B0844BB906D2/d/Visual Studio Code.app/Contents/Frameworks/Electron Framework.framework/Resources/crashpad_handler --no-rate-limit --no-upload-gzip --database=/var/folders/tt/8d93bx550wzdp20cw56gl5400000gn/T/VSCode Crashes --metrics-dir=/var/folders/tt/8d93bx550wzdp20cw56gl5400000gn/T/VSCode Crashes --url=https://rink.hockeyapp.net/api/2/apps/21a48a66799e47fea4f52c0ff81e803d/crashes/upload --handshake-fd=63
b                 1056   0.0  0.0  5028920    484   ??  UE   Sat04pm   0:01.05 /private/var/folders/tt/8d93bx550wzdp20cw56gl5400000gn/T/AppTranslocation/5D9818E0-2B53-4E49-8F2D-B0844BB906D2/d/Visual Studio Code.app/Contents/Frameworks/Code Helper.app/Contents/MacOS/Code Helper /private/var/folders/tt/8d93bx550wzdp20cw56gl5400000gn/T/AppTranslocation/5D9818E0-2B53-4E49-8F2D-B0844BB906D2/d/Visual Studio Code.app/Contents/Resources/app/extensions/json-language-features/node_modules/vscode-languageclient/lib/utils/electronForkStart /private/var/folders/tt/8d93bx550wzdp20cw56gl5400000gn/T/AppTranslocation/5D9818E0-2B53-4E49-8F2D-B0844BB906D2/d/Visual Studio Code.app/Contents/Resources/app/extensions/json-language-features/server/out/jsonServerMain.js --node-ipc --clientProcessId=939
b                  566   0.0  0.2  5472740  28312   ??   Interesting as I went to root to kill them - so I suppose they are running at root permission level or higher.

This looks to have been a result of the Erlang language server having locked up - https://github.com/pgourlain/vscode_erlang - I killed that (erlang) process and the zombie pids went away. So it's resolved on my side.


Add LinkedIn use case: people publishing their verifiable education credentials

Source: spec call on 2023-12-14

Is part of #25


Rest defintions lack a group property so cannot be 'grouped'

The RestDefinition class in camel lacks a group property. Since this is used as the property for grouping nodes then the routes generated by rest definitions get added to default. Maybe we can also group rest routes by using the tag property?

@phantomjinx Is there any problem with just treating the REST routes as default group?  Is it that we would have so many routes in the default practically when we wouldn't group them in some way like you suggested?
I'm wondering where it should be addressed. Rather than handling REST routes specially at Hawtio, shouldn't we raise a feature request to Camel so that it can add them to a group different from default?

@phantomjinx Is this already resolved or still an issue?


ios records 14 s and 15 seconds of video dragging.

Hello, ios records 14 s and 15 seconds of video dragging. I have the following questions, please help me to take a look:

Unsupported operation: Infinity or NaN toInt
When the exception was thrown, this was the stack:
#0      double.toInt (dart:core-patch/double.dart)
#1      _ScrollableTrimViewerState._onStartDragged (package:video_trimmer/src/trim_viewer/scrollable_viewer/scrollable_trim_viewer.dart:528:64)
#2      _ScrollableTrimViewerState._onDragUpdate (package:video_trimmer/src/trim_viewer/scrollable_viewer/scrollable_trim_viewer.dart:492:9)
#3      DragGestureRecognizer._checkUpdate. (package:flutter/src/gestures/monodrag.dart:483:55)
#4      GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:253:24)
#5      DragGestureRecognizer._checkUpdate (package:flutter/src/gestures/monodrag.dart:483:7)
#6      DragGestureRecognizer.handleEvent (package:flutter/src/gestures/monodrag.dart:330:9)
#7      PointerRouter._dispatch (package:flutter/src/gestures/pointer_router.dart:98:12)
#8      PointerRouter._dispatchEventToRoutes. (package:flutter/src/gestures/pointer_router.dart:143:9)
#9      _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:625:13)
#10     PointerRouter._dispatchEventToRoutes (package:flutter/src/gestures/pointer_router.dart:141:18)
#11     PointerRouter.route (package:flutter/src/gestures/pointer_router.dart:127:7)
#12     GestureBinding.handleEvent (package:flutter/src/gestures/binding.dart:460:19)
#13     GestureBinding.dispatchEvent (package:flutter/src/gestures/binding.dart:440:22)
#14     RendererBinding.dispatchEvent (package:flutter/src/rendering/binding.dart:336:11)
#15     GestureBinding._handlePointerEventImmediately (package:flutter/src/gestures/binding.dart:395:7)
#16     GestureBinding.handlePointerEvent (package:flutter/src/gestures/binding.dart:357:5)
#17     GestureBinding._flushPointerEventQueue (package:flutter/src/gestures/binding.dart:314:7)
#18     GestureBinding._handlePointerDataPacket (package:flutter/src/gestures/binding.dart:295:7)
#19     _invoke1 (dart:ui/hooks.dart:164:13)
#20     PlatformDispatcher._dispatchPointerDataPacket (dart:ui/platform_dispatcher.dart:361:7)
#21     _dispatchPointerDataPacket (dart:ui/hooks.dart:91:31)

Same issue is here

Same issue here

I was able to solve this issue by adding this parameter
type: ViewerType.fixed


Development

There are quite a few linting errors in this PR - We use linting to make sure that our code styling is easy readable and consistent across all files. You can seen linting errors by typing "gulp vet".  I have also just pushed a commit which makes vetting compulsory - so now whenever you compile for distribution you will see the linting errors and the compile will fail.  Also if you use SublimeText it's worth checking out SublimeLint which shows you linting errors while you are coding :)

Sure I'll fix it and let you know

done

hmmm I seem to have imagined the issue, I've reverted the commit


*: Cut v0.15.0-rc.2

Update CHANGELOG.md and bump VERSION to v0.15.0-rc.2.

This PR is blocked by https://github.com/prometheus/alertmanager/pull/1363

Closing here in favour of https://github.com/prometheus/alertmanager/pull/1410.


Feature/192 Add supporting named accounts

Closes #192

@ITStar10 I have this basically working, except when I try to run it against the smart contract deployed on Polygon Mumbai, I always get invalid signature. The signing code was copied directly from your working unit tests, so I don't know what the problem is. Perhaps Mumbai doesn't have the latest contract deployed or I'm using the wrong contract address?
Contract address is specified here: https://github.com/verida/verida-js/pull/268/files#diff-4c679fe299c1df8851850945c1ee983f06275b657f595ce00d6d9243e714c089R6

Please update the default postfix for Verida names to be .vda instead of .verida.

@ITStar10 Can you please add this library to standardize usernames?
https://github.com/adraffy/ens-normalize.js


add type hints to python-package/setup.py

Added type hints for python-package/setup.py as per #3756

Thanks for taking this on! Please see my suggestions below.

Thanks! I applied your suggestion. Is there anything more to change?


Not routing DNS-UDP queries to DNS over TLS server.

I am trying to accept dns queries on Nginx listening on UDP port and using nginx as a gateway to get a response from the public dns resolver with TLS port i.e. <IP_ADDRESS>:853.
Configuration:
user www-data;
worker_processes auto;
pid /run/nginx.pid;
include /etc/nginx/modules-enabled/*.conf;
error_log /var/log/nginx/error.log info;
events {
	worker_connections 768;
	# multi_accept on;
}

stream {

    # DoT upstream pool
    upstream dot {
        zone dot 64k;
        server <IP_ADDRESS>:853;
    }
    # DNS server for upstream encryption
    server {
        listen 53;
        proxy_ssl on;
        proxy_pass dot;
        proxy_responses 1;
        proxy_timeout 1s;
     }
    server {
        listen 53 udp;
        proxy_ssl on;
        proxy_pass dot;
    }
}

It is working when I am trying to get a response with kdig over tcp.
kdig @<IP_ADDRESS> facebook.com A +tcp +short
<IP_ADDRESS>

But with UDP, It is timing out.
kdig @<IP_ADDRESS> facebook.com A +notcp
;; WARNING: response timeout for <IP_ADDRESS>@53(UDP)

Nginx Status:
tcp        0      0 <IP_ADDRESS>:53              <IP_ADDRESS>:*               LISTEN      3225669/nginx: mast
udp        0      0 <IP_ADDRESS>:53              <IP_ADDRESS>:*                           3225669/nginx: mast

I am not sure if it is because of proxy_ssl on directive?
I want Nginx to listen on UDP/53 and route requests to the DNSoverTLS server.

Hi,
Unfortunately the stream module does not support mixing UDP and TCP services. So there's no way to accept a UDP request and forward on over TCP. If this changes in the future, then I'll update this project to include support.
Cheers


Improve connection and corresponding logging

Discover the remote system before starting the grpc server
Do not call notify_on_discover when the sysid is 0 (which means that MAVSDK is connecting to a remote, and therefore a system has not actually been discovered)
Improve connection logging (stuff like "discovered 0 components" is a bit confusing IMO)

@JonasVautherin
Hi! After this change I can't receive any notification when remote is actually connected.
Maybe you could add notify_on_discover() here: https://github.com/mavlink/MAVSDK/blob/ea2386c109cd8b6284416d0d24317023fd03fec7/src/core/mavsdk_impl.cpp#L225

You mean that your remote has a sysid set to 0? :thinking:

You mean that your remote has a sysid set to 0? 🤔

Nope, it is 1. But the problem is that when I connect to it via UDP, a placeholder is created in _systems vector, with zero id. When the remote is connected, zero is rewritten by actual sysid (in the place I linked above). Notification isn't fired at the moment of placeholder creation nor at the moment of setting the actual sysid, so it's not fired at all

Oh right I see! Yes that makes sense. Can you open a PR with your suggestion? :pray: