Changing query filters from list of tuples to dict

Issue28's description:
While designing new unittests, I figured I wasn't sure about what to expect when we use query_filters with multiple filters on a single value. Since this does not include order relationships but strictly equality, I suggest changing this to a dictionary to prevent duplication of keys.
Here is an example on the fetch_all crud function:
what a call currently looks like
result_entries = crud.fetch_all(user_table, [('username', 'fg')]
my suggestion
result_entries = crud.fetch_all(user_table, {'username': 'fg'}]

@martin1tab Thanks for the PR! We're just waiting for #33 to be merged, because it deletes the routing module. So there might be conflicts with your PR. But overall, your proposition looks good! Could you just investigate the low coverage on diff hit please? :pray:

Hey @martin1tab,
Thanks for the PR!
Could you merge master into this before moving on to reviewing? :pray:

@martin1tab Thanks for the PR! We're just waiting for #33 to be merged, because it deletes the routing module. So there might be conflicts with your PR. But overall, your proposition looks good! Could you just investigate the low coverage on diff hit please? 🙏

Yes, I still have this issue; I am still investigating this problem

@martin1tab Thanks for the PR! We're just waiting for #33 to be merged, because it deletes the routing module. So there might be conflicts with your PR. But overall, your proposition looks good! Could you just investigate the low coverage on diff hit please? 🙏

Yes, I still have this issue; I am still investigating this problem


The view doesn't refresh correctly in IE when multiple input source link to same model

angular-1.2.0-rc.2

	<input id="a" data-ng-model="model1.input1">
	<input id="b" data-ng-model="model1.input1">
	The input is: {{model1.input1}}
	The input is: {{model1.input1}}

The above code, when input in either of the <input>, both <input> are updated, but the views don't, untill double click the page, or highlight the <input> content. This happen in IE9, didn't test other version. Using ng-bind behaves the same.

The fiddle works in Win7 / IE9


APPS-324 Create release pipeline

Adds a release pipeline for the compiler which runs scripts/build_all_releases.sh, creates a version tag, creates a release entry with release notes, pushes the released branch to remote repo if successful and rolls back in case of a failure or cancellation.
To initiate the release, go to Actions > dxCompiler Release (Staging and Prod) and click 'Run workflow' on the right side:

A real release pipeline hasn't been run yet, I will run the first release tomorrow.
TODO:

[ ] update doc/Developing.md once the first auto-release is successful.

Thanks @jdidion! I'll merge, run the release from main, and if there are any hiccups, will issue another PR.


Updated to use latest version of emoji-data

Have updated the library to bundle the latest Emoji changes from October 2015.

Sorry, had trouble and didn't run tests. I'll look into it!


Fix CIS Control cis_v120_1_1 producing incorrect results for corporate login credentials Fixes #84

Checklist

[ ] Issue(s) linked

@khushboo9024, even though the query results solve the reported issue, marking this as a (wip) state to check a more optimal way to render results in a single row for the info condition.


vault: Kv1 hardcoded path prevents use of Kv2 secrets

Plugin Name
@backstage-community/plugin-vault
📜 Description
Here I see a problem trying to use Kv2 secrets, the v1/secrets/ path does not allow the use of Kv2 secrets as the Official Docs mention here, the snippet above must be changed in case the use of Kv2 secrets to accomplish the right path /:secret-mount-path/data/:path?version=:version-number, As we can see, to use Kv2, this v1/secrets/ must become this :secret-mount-path/data/.  In my tests, I got that happening /api/vault/v1/secrets/***-secret?engine=***, the engine is being used as query params which the Vault API does not allow.
👍 Expected behavior
The correct validation of the plugin while using Kv2 secrets, as the documentation shows.
👎 Actual Behavior with Screenshots
In my tests, I got that happening /api/vault/v1/secrets/***-secret?engine=***, the engine is being used as query params which the Vault API does not allow for Kv2 secrets, or Kv1 in other mountpaths besides the default secrets hardcoded.
👟 Reproduction steps
Try to use Kv2 secrets, or Kv1 in other mountpaths besides the default secrets.
📃 Provide the context for the Bug.
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

@ellipsis-me We encountered the same problem. Maybe I can help you in some way?


Add icons to footer

from https://www.extropic.ai/accelerate

Done in https://github.com/macterra/artx-market/commit/dc991a138c4c2d9f8272a44912a54fd328aeae24


Feature request: Documentation for CDF time data types

In the HAPI metadata, we want to include a note stating what CDF type the Time variable was derived from and also want to point the user to more information about interpretation (e.g., UTC based, etc.) We don't want to write our own explanation because of the experience we had with some SPASE records where a rephrasing of a source led to ambiguity or incorrectness.
A Google search of CDF_EPOCH16 shows mostly source code mentioning CDF_EPOCH16. The second page shows https://ui.adsabs.harvard.edu/abs/2011AGUFMSM21A2001C/abstract
It would be helpful if there was an authoritative link we could point to for the explanation. At present, we point to https://spdf.gsfc.nasa.gov/pub/software/cdf/doc/cdf390/cdf390ug.pdf, which contains a description, but this link may change; also, pointing to a 165-page document when the reader wants one sentence does not seem sensible.
Maybe post the poster https://ui.adsabs.harvard.edu/abs/2011AGUFMSM21A2001C/abstract, which I assume contains all the details, on Zenodo?

The 2011 Fall AGU poster SM21A-2001: "Common Data Format (CDF) New Time Variable CDF_TIME_TT2000" is now at https://spdf.gsfc.nasa.gov/pub/documents/SPDF/presentations/CDF_AGU2011_Common-Data-Format-CDF-New-Time-Variable-CDF_TIME_TT2000a.pdf . It's basically the info at https://cdf.gsfc.nasa.gov/html/leapseconds.html and https://cdf.gsfc.nasa.gov/html/leapseconds_requirements.html and in the CDF User Guide permanent link https://spdf.gsfc.nasa.gov/pub/software/cdf/doc/cdf_User_Guide.pdf . We're redoing the CDF website and can add a page on CDF variable types, pad values and typical fill values, and special time strings and their corresponding values.


Support for uniqe object names through user-supplied variable values

Is your feature request related to a problem? Please describe.
I'm creating save files from multiple versions of objects. I can use variables like&NAME when naming the save files, however this will result in a conflict when saving a different version of the same object (that has the same name, library, etc.). Unfortunately CRTSAVF doesn't have REPLACE parameter...
Describe the solution you'd like
It'd be convenient to have a variable that would prompt the user for its value, so I could use it like:
CRTSAVF (&OPENLIB/&USERVAL)
SAVOBJ SAVF(&OPENLIB/&USERVAL) ...

When this action runs the user would be prompted for a value by VSCode, and the supplied value would be inserten in place of &USERVAL.
Describe alternatives you've considered
I was thinking about having a variable with a value increasing with every action call, but I think this would quickly result in too long names.
A workaround could be to have a prompted CL command that stores some value for later calls, but I'm not that familiar with CL programming TBH.

Have you checked out our prompting capabilities for actions?
https://halcyon-tech.github.io/docs/#/pages/developing/actions/execution?id=prompted

This seems just perfect, thank you!

One more question though: is there a way to reference  a previously prompted value so I don't have to provide the same value twice?
Thanks!


[BUG] Package breaks npm ci command

Describe the bug
After installing the @odata/client package, npm ci stops working.
System Environment

OS: Windows 11
Node Version: 18.12.0
This Library Version: 2.21.1

To Reproduce
Steps to reproduce the behavior:

Create empty npm project
Run npm install @odata/client
Run npm ci
See error

Expected behavior
The command finishes without error
Additional context
Here is the error I get, for reference
$ npm ci

npm ERR! code EBADPLATFORM
npm ERR! notsup Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"android","arch":"arm"} (current: {"os":"win32","arch":"x64"})
npm ERR! notsup Valid OS:    android
npm ERR! notsup Valid Arch:  arm
npm ERR! notsup Actual OS:   win32
npm ERR! notsup Actual Arch: x64

interesting, windows on arm, let me check with esbuild

Hi @Twometer
I released a new version 2.21.2, please have a try.
I think I realized the nature of this issue, but its hard to explain, its similar to the well-known fsevents issue I think, and caused by npm/package-lock and optional dependencies.
Best Regards,
Theo

Hi @Soontao,
I now get a different error:
npm ERR! code EBADPLATFORM
npm ERR! notsup Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin"} (current: {"os":"win32","arch":"x64"})
npm ERR! notsup Valid OS:    darwin
npm ERR! notsup Valid Arch:  undefined
npm ERR! notsup Actual OS:   win32
npm ERR! notsup Actual Arch: x64

Hi @Twometer
I'm so sorry just see your update today, really sorry for this, I've released a new version 2.21.3 to fix the fsevents issue, could you have a try ?
Best Regards,
Theo

Hi @Soontao,
Thank you, the bug seems to be fixed now :)


An issue with Hardware Acceleration

I just installed this module a week ago and had my first time with it the other day and two of my players had issues. The lag they were experiencing was profound, to the point I had to turn it off. There was no other changes to my system up until this point in months. Also the two players in question kept getting this error message. Even though they had and always have had it turned on, it was showing the error. I had them turn it off and on again to no effect. All my players connect via Chrome.

I would be very surprised if this error modules is because of this module. This error message is created when missing hardware acceleration is detected. This detection step happens before this module even becomes active.
Just to clarify: do these players really get the same error message with the module disabled vs enabled and no other changes?

Okay, then it clearly seems to be somehow caused by this module or much more likely the interplay of your modules.
I also double checked and indeed the module activates itself before the webgl check is executed. I still don't know what my module could do to actually trigger this issue, but something aparrently goes wrong for some of your players.
Could you maybe provide me with a list of your other active modules so I can try and replicate the issue?
Easiest would be the support report:
Settings tab > Support & Issues
Click on the bottom-right button "Generate Full Report", then "Copy Report to Clipboard"


[linux-shell] Disable the headerbar support

Description
Disable the headerbar support because it seems to be interacting badly with NVIDIA drivers.
Related Issues
https://github.com/flutter/flutter/issues/59960
Tests
No tests changed.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

Started Google testing for this PR

Google testing passed!

https://github.com/flutter/engine/pull/19438 is the proper fix for this, so it looks like we won't need to land this PR.


graphql_scalar!() does not support paths in resolve()

From @djc on gitter:

sooo it seems like the return path for resolve() in graphql_scalar!() is not allowed to be a path or whatever
(I previously wanted to prevent importing Value globally and used juniper::Value instead)

Thanks for filing! This change:
@@ -325,8 +329,8 @@ macro_rules! identifiers {
         graphql_scalar!($id {
             description: "Identifier for $t type"

-            resolve(&self) -> Value {
-                Value::int(self.0)
+            resolve(&self) -> juniper::Value {
+                juniper::Value::int(self.0)
             }

             from_input_value(v: &InputValue) -> Option<$id> {

results in pretty obscure errors:
error: no rules expected the token `parse`
   --> src/models.rs:343:1

(I actually have a macro generating the newtypes that I'm using the scalars for, so the error points to the invocation of that macro.)


Remove non vertx operations from vertx implementation

Will probably need to refactor out a common parent to do it nicely. Shouldn't be too hard though.
People might instantiate a vertx implementation but mistaking luck use the vanilla methods, where the thread pool size is only one.
I can't think right now of a good reason to keep them both available in the vertx implementation.

@radoslawtwardy any thoughts?

I think removing methods such as poll, pollAndProduce etc. from vertx implementation is good idea.


Installation issue with S3proxy

Hi Team,
I am trying to install s3proxy in centos-7. I installed go version - go1.6.2.
After installation of go i didn't see proper installation steps provided.
We tried to install using go get but no response & its getting stuck.
Closed the go get process and cloned folder using git clone command.
Later we tried to use go install but running into error.
" cannot find package "github.com/aws/aws-sdk-go/aws" in any of:"
" cannot find package "github.com/aws/aws-sdk-go/service/s3" in any of:"
Please let me know how to install s3proxy.
If need more info, just let me know....

Hi,
Thanks for reaching out. Sorry you are having problems with the installation. I realise now that the README only mentions development and nothing about installation.
The installation instructions would be very similar to the Development instructions.
git clone git@github.com:qstorey/S3Proxy.git
cd S3Proxy
make

You should end up with a bin directory in the root of the repo and the S3Proxy executable inside of the bin directory.
Please note I have only tested this on OS X, so if there are issues with CentOS I would like to know so that I can address them.

[root@centos ~]# git clone git@github.com:qstorey/S3Proxy.git
Cloning into 'S3Proxy'...
Warning: Permanently added the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts.
Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
So i changed command as below after which can clone folder.
[root@centos ~]# git clone https://github.com/qstorey/S3Proxy.git
Cloning into 'S3Proxy'...
remote: Counting objects: 206, done.
remote: Total 206 (delta 0), reused 0 (delta 0), pack-reused 206
Receiving objects: 100% (206/206), 35.98 KiB | 0 bytes/s, done.
Resolving deltas: 100% (99/99), done.
[root@centos ~]# cd S3Proxy/
[root@centos S3Proxy]# ls
License.md  main.go  Makefile  README.md  S3Proxy
[root@centos S3Proxy]# Makefile
-bash: Makefile: command not found
[root@centos S3Proxy]# make
go vet .
make: go: Command not found
make: *** [vet] Error 127

Ran from the GOPATH directory->Installation successful .
[root@devstack gocode]# cd src/github.com/
[root@devstack github.com]# ll
total 0
drwxr-xr-x. 3 root root 23 Mar 25 06:57 aws
drwxr-xr-x. 3 root root 19 Mar 25 06:59 drone
drwxr-xr-x. 3 root root 20 Mar 25 06:57 qstorey
[root@devstack github.com]# cd qstorey/S3Proxy/
[root@devstack S3Proxy]# ll
total 20
-rw-r--r--. 1 root root 1080 Mar 25 06:57 License.md
-rw-r--r--. 1 root root  432 Mar 25 06:57 main.go
-rw-r--r--. 1 root root  276 Mar 25 06:57 Makefile
-rw-r--r--. 1 root root 1964 Mar 25 06:57 README.md
drwxr-xr-x. 2 root root 4096 Mar 25 06:57 S3Proxy
[root@devstack S3Proxy]# make
go vet .
cd S3Proxy && go vet .
go fmt .
cd S3Proxy && go fmt .
go get -v
cd S3Proxy && go build -v
go build -v -o bin/S3Proxy
github.com/qstorey/S3Proxy
[root@devstack S3Proxy]#
[root@devstack S3Proxy]# ll
total 20
drwxr-xr-x. 2 root root   20 Mar 25 10:56 bin
-rw-r--r--. 1 root root 1080 Mar 25 06:57 License.md
-rw-r--r--. 1 root root  432 Mar 25 06:57 main.go
-rw-r--r--. 1 root root  276 Mar 25 06:57 Makefile
-rw-r--r--. 1 root root 1964 Mar 25 06:57 README.md
drwxr-xr-x. 2 root root 4096 Mar 25 06:57 S3Proxy
it gives  S3Proxy executable file inside of the bin directory.
but when i entered S3Proxy, it throws error as shown below.
/root/gocode/src/github.com/qstorey/S3Proxy/bin
[root@devstack bin]# ll
total 13816
-rwxr-xr-x. 1 root root 14141272 Mar 25 10:56 S3Proxy
[root@devstack bin]# S3Proxy version
-bash: S3Proxy: command not found
[root@devstack bin]#
could you please let me know, how to use S3Proxy.


Yt-dlp not downloading livestream when fed .m3u8 link?[Question]

Checklist

[x ] I'm asking a question
[x ] I've looked through the README and FAQ for similar questions
[x ] I've searched the bugtracker for similar questions including closed ones

Question

Using yt-dlp on a link like this (https://live.gchao.cn/live/23331_m84p323q.m3u8) only downloads one chunk of the livestream. Using command "yt-dlp [url]". However doing the same thing with base youtube-dl downloads the entire stream, using command "youtube-dl [url]".

Since I can't access that link, I am not sure whether yt-dlp detects it as a non-live manifest due to lack of information in the manifest itself, or due to some bug. Please attach the manifest file so that I can test.
In either case, you can use --downloader ffmpeg as a workaround

This is a manifest from the same site, but a different stream as the original I linked is no longer available. Confirmed to have the same behavior as the first as well. I was unable to attach it directly, https://gofile.io/d/Vcz2qa. I can try uploading it another way if you don't trust this link.

Like I thought, it is not possible to tell that it is a livestream just by the manifest. There is no option but to give --downloader ffmpeg
The only clue that it is live is EXT-X-MEDIA-SEQUENCE but that is not reliable. See c15c47d19bfeeacd42f44dd7736f175711a91346

Could you explain why youtube-dl handles it correctly while yt-dlp doesn't? I'm just curious, all good if you don't want to.

youtube-dl uses ffmpeg downloader by default while yt-dlp uses the native one

ah ok that makes sense. Thanks for your help, appreciate it. Will be closing this.


Scale-down

Simplified use of the library. Now it is more easy getting started with a simple sample.

Scale down
Simplified use of the library. Now it is more easy getting started with a simple sample.
The init() method in GraphEngine has been removed. Logic moved to the constructor of GraphEngine, actually  to its parent class RenderManager.
The Observable previously return by init() now is a public attribute in GraphEngine: fps$, initialized inside the constructor.
Simplified API GraphEngine.requestRender()
It is no longer needed to invoke requestRender() the first time after the creation of a scene. Now the adding graphics family methods do invoke requestRender() automatically.
Smart management: more than one render requests within the same "animation cicle" are dismissed, thus, there won't be any performance penalty if multiple invocations are submitted.
The family methods addGraphicXXX() and addObjectXXX() no longer accept effects. Instead, these methods return a new structure GraphContext to offer serveral operation on the engine related to the added graph, being one of them the hability to add effects:
const context = engine.addGraphic(graph);
context.effect(fx1, fx2);
context.playTransition(t).then(() => context.playTransition(r));

engine.addGraphic(graph).effects(fx1, fx2);

NOTE: playTransition() doesn't exist yet, it will be offered when transitions are available...

addGraphic() and addGraphicInLayer() merged in one method: layer param is optional.


Succeed RC when dependencies not met

Schedules and Runs should only be created once all dependencies have been met.
Closes #273

ok to test

ok to test

ok to test

ok to test

ok to test


Typos/name changes

#Under Phylogeny, distance matrix configuration, the text when you hover over "Sort deepest clades to bottom has a typo"
Github help text for Histogram view has WinHIVTrace.

The Histogram view help text can be edited here.

Resolved by 535d00167c01a3e2be6aaad0a019fe26c00fd139 and 33add8a52dcf55afd529b7b3d7d8057dbabca7b9


Transport layer: SDK retries on same replica in exception scenarios

The SDK should retry on different replicas on transport exceptions. Based on the following diagnostics the SDK seems to be retrying on the same replica twice.
RequestStartTime: 2021-09-22T13:18:37.7437788Z, RequestEndTime: 2021-09-22T13:18:40.3221334Z, Number of regions attempted:2
ResponseTime: 2021-09-22T13:18:39.3063898Z, StoreResult: StorePhysicalAddress: rntbd://cdb-ms-prod-northeurope1-fd18.documents.azure.com:14002/apps/ea705b66-063a-48e6-9d26-f5ab2888d753/services/6326deb4-372c-49af-a45b-120d8504a453/partitions/a006ddaa-2533-4100-b88b-6fa01c17dabc/replicas/132767031075181121s/, LSN: -1, GlobalCommittedLsn: -1, PartitionKeyRangeId: , IsValid: True, StatusCode: 410, SubStatusCode: 0, RequestCharge: 0, ItemLSN: -1, SessionToken: , UsingLocalLSN: True, TransportException: A client transport error occurred: The request timed out while waiting for a server response. (Time: 2021-09-22T13:18:39.3063898Z, activity ID: dbc9613c-8f9c-45fb-b876-e831512891de, error code: ReceiveTimeout [0x0010], base error: HRESULT 0x80131500, URI: rntbd://cdb-ms-prod-northeurope1-fd18.documents.azure.com:14002/apps/ea705b66-063a-48e6-9d26-f5ab2888d753/services/6326deb4-372c-49af-a45b-120d8504a453/partitions/a006ddaa-2533-4100-b88b-6fa01c17dabc/replicas/132767031075181121s/, connection: <IP_ADDRESS>:34637 -> <IP_ADDRESS>:14002, payload sent: True, CPU history: (2021-09-22T13:17:40.1570849Z 16.420), (2021-09-22T13:17:50.1576839Z 16.223), (2021-09-22T13:18:00.1617846Z 20.217), (2021-09-22T13:18:10.1633584Z 17.899), (2021-09-22T13:18:20.1764200Z 22.982), (2021-09-22T13:18:30.1659185Z 21.746), CPU count: 4), ResourceType: Document, OperationType: Read
ResponseTime: 2021-09-22T13:18:40.3065107Z, StoreResult: StorePhysicalAddress: rntbd://cdb-ms-prod-northeurope1-fd18.documents.azure.com:14002/apps/ea705b66-063a-48e6-9d26-f5ab2888d753/services/6326deb4-372c-49af-a45b-120d8504a453/partitions/a006ddaa-2533-4100-b88b-6fa01c17dabc/replicas/132767031075181121s/, LSN: -1, GlobalCommittedLsn: -1, PartitionKeyRangeId: , IsValid: True, StatusCode: 410, SubStatusCode: 0, RequestCharge: 0, ItemLSN: -1, SessionToken: , UsingLocalLSN: True, TransportException: A client transport error occurred: The request timed out while waiting for a server response. (Time: 2021-09-22T13:18:40.3065107Z, activity ID: dbc9613c-8f9c-45fb-b876-e831512891de, error code: ReceiveTimeout [0x0010], base error: HRESULT 0x80131500, URI: rntbd://cdb-ms-prod-northeurope1-fd18.documents.azure.com:14002/apps/ea705b66-063a-48e6-9d26-f5ab2888d753/services/6326deb4-372c-49af-a45b-120d8504a453/partitions/a006ddaa-2533-4100-b88b-6fa01c17dabc/replicas/132767031075181121s/, connection: <IP_ADDRESS>:34637 -> <IP_ADDRESS>:14002, payload sent: True, CPU history: (2021-09-22T13:17:50.1576839Z 16.223), (2021-09-22T13:18:00.1617846Z 20.217), (2021-09-22T13:18:10.1633584Z 17.899), (2021-09-22T13:18:20.1764200Z 22.982), (2021-09-22T13:18:30.1659185Z 21.746), (2021-09-22T13:18:40.1658653Z 23.817), CPU count: 4), ResourceType: Document, OperationType: Read
ResponseTime: 2021-09-22T13:18:40.3221334Z, StoreResult: StorePhysicalAddress: rntbd://am4prdddc11-docdb-2.documents.azure.com:14134/apps/919f03de-8bbf-4ea1-ad94-ca78b0bb1f81/services/7bf6f884-2231-45f1-bc77-67c3534fd4f4/partitions/1fdcf903-98b3-48a6-b4f3-ba57919bdxyz/replicas/132755781395325766s/, LSN:<PHONE_NUMBER>, GlobalCommittedLsn:<PHONE_NUMBER>, PartitionKeyRangeId: 26, IsValid: True, StatusCode: 200, SubStatusCode: 0, RequestCharge: 1, ItemLSN:<PHONE_NUMBER>, SessionToken: 14#8968363229#36=-1#3=-1#24=-1#7=-1#12=-1#13=-1, UsingLocalLSN: True, TransportException: null, ResourceType: Document, OperationType: Read

@asketagarwal what else is pending for this work item?

This PE only covered Transport Exceptions. We also need to cover GoneExceptions that is not a transport exception (410 returned from service)


test: skip CCO in pod crash check

We are seeing test flakes due to CCO pod restart because of https://issues.redhat.com/browse/OCPBUGS-30068
Skip for now to avoid flakes.

/lgtm

/area testing


Remove "inserted ways" handling

Part of the old-style multipolygon handling is the "inserted way" cache, that stores which (outer or inner) way of a relation does not need to be imported anymore, because it shares the same tags as the multipolygon relation.
For example: A forest multipolygon relation with a hole where the outer way is also tagged as forest. Only the relation should be imported and not the outer way (as this polygon will cover the hole in the multipolygon).
While old-style multipolygons are removed, tagged outer ways are still present. See: osmlab/fixing-polygons-in-osm/issues/36
The "inserted ways" handling can be removed when this issue is fixed in the OSM data, or when openstreetmap-carto deploys 4.0 where this handling is dropped.

Already implemented.


feat(DHIS2-16132): transpose section forms

This PR implements the ability to display sections transposed, and grouped by category in the data entry app. Implements DHIS2-16132 .
transpose-different-options.webm
Default Section form - without pivoting (existing implementation)

Form pivoted (data elements moved to columns)

Single Category pivoted

Multiple categories (with one pivoted)

Data elements with different category combos

Notes about implementation
As an general approach, I aimed to decouple the display details (table, rows, columns, column and row spans) from our internal concepts (data elements, categories, category options, cocs etc...), to provide a middle layer (a matrix) that represents a form in our context. This middle layer can become the base of a form builder, for implementations that are cross-platform and other improvements in the future.
With the previous implementation, we were more than half-way there, but the data elements were tightly coupled to rows, and in turn the rows/data elements are tightly coupled to functionality like search, filters, highlighting current cell in the table etc... The next step should be to consolidate this implementation with the "normal" section form - there is a followup ticket for this:  https://dhis2.atlassian.net/browse/LIBS-584
The only concept that remains metadata-aware is the date entry field  - this was the existing design and it works well, as a self-contained component responsible of its own state, validation etc... regardless of where it appears in a form.

I avoided changing the original CategoryComboTable and added a new PivotedCategoryComboTable to handle the new use cases for transposing. I  didn't want to change something that already works and well-tested for what's essentially an experimental new feature (i.e. not part of achieving parity with the existing app). Next step is to consolidate theses two components and the underlying matrix generation.

In the grouped matrix logic, I added a special case for when there is one category and another for 1+ categories. This is needed because we need a "shadow" row in the case of more categories, this is unnecessary for one category. See the photo below, the first one has a "shadow" row (location fixed/outreach) and the categories are displayed underneath each other - this is necessary for multiple categories. In the case of one category (second table), we can do  with the category being on top of the options.

Background
We are aiming to add more form configuration options as part of an initiative to provide configurations natively to data entry forms to reduce the necessity for custom forms. Users are currently building custom forms as a workaround for shortcomings of the configuration options (ability to transpose, or customise a cell design) or implementation (such to avoid issues with RTL issues). This is an RFC that describes the approach and the priorities for form configuration options. This is based on a thorough investigation by the functional design team for custom form use cases in real-life implementations. Based on that investigation, the ability to transpose forms and adding free-text descriptions were one of the main reasons people choose to go the custom forms route so we're tackling these first.
Known limitations

Transpose (not grouping) doesn't work for a dataset with more than one category combo
Support multiple transposed categories (right now, we transpose only one)
Search and filtering doesn't work as these were tightly couple with data elements - we will need to design and rethink that for transposed sections.

ToDos (future)

[ ] Consolidate CategoryComboTable and PivotedCategoryComboTable, as well as underlying "matrix" logic:  https://dhis2.atlassian.net/browse/LIBS-584

Related PRs:

Maintenance app
Data entry app (beta)
Backend

@tomzemp thanks for testing - I fix the issue with the transposed form with one default combo or one category. Below is how it looks. Also removed the cool 🕶 feature toggle.


ChangeRoad Action

The ChangeRoad Action is not yet implemented. It should work as follows:
When applicable, an agent should estimate if it is better to change road (and thus also a new route). That is, it should check if it is beneficial to change its current route and adapt a new one. It should do so when it will soon be in a position to change a road, and after it made this decision, it should commit to it (unless new information arrives).
In practice, I think it would be best to sent the new calculated route to SUMO immediately after this decision is made. Maybe we should also allow agents do both take the ChangeRoad action as well as another action (such as ChangeVelocity), since the ChangeRoadAction doesn't conflict with other actions directly.

Agent has a currentRouteEdges, Edge[]. In case of a changeRoute AgentAction, a new route is generated with A* and currentRouteEdges is updated and the new data is immediately sent to SUMO in a SumoStringList.

It works not, but must be improved later on. See for example #14. Also, we have to implement that this action will only be considered when appropriate.


can't signup through cmd line

# exp --version
0.30.0

# exp signup
[exp] Cannot read property 'apply' of undefined
TypeError: Cannot read property 'apply' of undefined
    at Command._callee$ (/opt/node-v6.3.1-linux-x64/lib/node_modules/exp/build/exp.js:276:29)
    at tryCatch (/opt/node-v6.3.1-linux-x64/lib/node_modules/exp/node_modules/regenerator-runtime/runtime.js:64:40)
    at GeneratorFunctionPrototype.invoke [as _invoke] (/opt/node-v6.3.1-linux-x64/lib/node_modules/exp/node_modules/regenerator-runtime/runtime.js:355:22)
    at GeneratorFunctionPrototype.prototype.(anonymous function) [as next] (/opt/node-v6.3.1-linux-x64/lib/node_modules/exp/node_modules/regenerator-runtime/runtime.js:116:21)
    at step (/opt/node-v6.3.1-linux-x64/lib/node_modules/exp/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
    at /opt/node-v6.3.1-linux-x64/lib/node_modules/exp/node_modules/babel-runtime/helpers/asyncToGenerator.js:35:14
    at new Promise (/opt/node-v6.3.1-linux-x64/lib/node_modules/exp/node_modules/core-js/library/modules/es6.promise.js:191:7)
    at Command.<anonymous> (/opt/node-v6.3.1-linux-x64/lib/node_modules/exp/node_modules/babel-runtime/helpers/asyncToGenerator.js:14:12)
    at Command.<anonymous> (/Users/Jesse/Exponent/newuniverse/universe/dev/exp/src/exp.js:47:10)
    at Command.listener (/opt/node-v6.3.1-linux-x64/lib/node_modules/exp/node_modules/commander/index.js:301:8)
    at emitTwo (events.js:111:20)
    at Command.emit (events.js:191:7)
    at Command.parseArgs (/opt/node-v6.3.1-linux-x64/lib/node_modules/exp/node_modules/commander/index.js:615:12)
    at Command.parse (/opt/node-v6.3.1-linux-x64/lib/node_modules/exp/node_modules/commander/index.js:458:21)
    at _callee3$ (/opt/node-v6.3.1-linux-x64/lib/node_modules/exp/build/exp.js:72:55)
    at tryCatch (/opt/node-v6.3.1-linux-x64/lib/node_modules/exp/node_modules/regenerator-runtime/runtime.js:64:40)

In particular I found the following path a bit surprising:
/Users/Jesse/Exponent/newuniverse/universe/dev/exp/src/exp.js:47:10
This is not a mac (/Users doesn't exist), and there is no user named Jesse. May be an unrelated leftover from the machine where exponent was built.

@acornejo hi! Thanks for the report! It looks like you're running with Node 6.3.1, where we require at least the current LTS release for our tools. I believe the current LTS version is 6.9.1. Can you try upgrading and seeing if that resolves your issue?
Regarding the stray path from a Mac, this is an artifact of the current build process and how it handles sourcemaps. I believe we have a patch in the pipeline to get these paths correctly resolving to the local directory, but I'd need to double check to be sure when it's going to land & release.

I tried with latest LTS (6.9.2), same results:
# exp signup
[exp] Cannot read property 'apply' of undefined
TypeError: Cannot read property 'apply' of undefined
    at Command._callee$ (/opt/node-v6.9.2-linux-x64/lib/node_modules/exp/build/exp.js:276:29)
    at tryCatch (/opt/node-v6.9.2-linux-x64/lib/node_modules/exp/node_modules/regenerator-runtime/runtime.js:64:40)
    at GeneratorFunctionPrototype.invoke [as _invoke] (/opt/node-v6.9.2-linux-x64/lib/node_modules/exp/node_modules/regenerator-runtime/runtime.js:355:22)
    at GeneratorFunctionPrototype.prototype.(anonymous function) [as next] (/opt/node-v6.9.2-linux-x64/lib/node_modules/exp/node_modules/regenerator-runtime/runtime.js:116:21)
    at step (/opt/node-v6.9.2-linux-x64/lib/node_modules/exp/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
    at /opt/node-v6.9.2-linux-x64/lib/node_modules/exp/node_modules/babel-runtime/helpers/asyncToGenerator.js:35:14
    at Promise.F (/opt/node-v6.9.2-linux-x64/lib/node_modules/exp/node_modules/core-js/library/modules/_export.js:35:28)
    at Command.<anonymous> (/opt/node-v6.9.2-linux-x64/lib/node_modules/exp/node_modules/babel-runtime/helpers/asyncToGenerator.js:14:12)
    at Command.<anonymous> (/Users/Jesse/Exponent/newuniverse/universe/dev/exp/src/exp.js:47:10)
    at Command.listener (/opt/node-v6.9.2-linux-x64/lib/node_modules/exp/node_modules/commander/index.js:301:8)
    at emitTwo (events.js:111:20)
    at Command.emit (events.js:191:7)
    at Command.parseArgs (/opt/node-v6.9.2-linux-x64/lib/node_modules/exp/node_modules/commander/index.js:615:12)
    at Command.parse (/opt/node-v6.9.2-linux-x64/lib/node_modules/exp/node_modules/commander/index.js:458:21)
    at _callee3$ (/opt/node-v6.9.2-linux-x64/lib/node_modules/exp/build/exp.js:72:55)
    at tryCatch (/opt/node-v6.9.2-linux-x64/lib/node_modules/exp/node_modules/regenerator-runtime/runtime.js:64:40)

Quite right! I'll work on a fix for this. In the meantime, the node 7.2 series works for me to signup in exp, and you can still use XDE to create an account.

Hi! Sorry about the delay here. I've published v0.30.1 to npm which should resolve this issue. Could you try installing that and confirming it fixed things for you?

worked. thank you @dikaiosune!
closing.


I am curious about why the flops and parms of TAdaConvNeXt-T is one half of the ResNet50's, to my knowledge they should be similar.

          I am curious about why the flops and parms of TAdaConvNeXt-T is one half of the ResNet50's, to my knowledge they should be similar.

Originally posted by @leexinhao in https://github.com/alibaba-mmai-research/TAdaConv/issues/11#issuecomment-1415454364
Could you give me the implement of TAdaConvNeXt？

Sorry for the delayed reply.
The reason for the reduced computation for TAdaConvNeXt is that we used a tublet embedding stem in TAdaConvNeXt model, which reduces the temporal resolution by a factor of 2 in the first downsample layer of ConvNeXt :). In contrast, the TAda2D stem employs only spatial convolutions with no temporal downsampling.


refactor(components): migrate tabs to fast

@rinaok
In the vertical tabs component "hover"/"selected" indication must always be the same width,
like in this example:

This is the link to Figma:
https://www.figma.com/file/JJNgZvt1qf3ydYmOwbE3Jg/Vivid-UI-Kit---3.0-WIP?node-id=19097%3A81830&t=pYTzgCh1RB4ypPYV-1

@rinaok
I made some changes to the info connotation in tabs text
for it to be in line with the other elements with ghost appearance,
Please take a look and change accordingly:
https://www.figma.com/file/JJNgZvt1qf3ydYmOwbE3Jg/Vivid-UI-Kit---3.0-WIP?node-id=19097%3A81791&t=n460dkt4vqkK2LqH-1
https://www.figma.com/file/JJNgZvt1qf3ydYmOwbE3Jg/Vivid-UI-Kit---3.0-WIP?node-id=19097%3A81745&t=n460dkt4vqkK2LqH-1

@rachelbt @yinonov @AyalaBu
I think that the PR is ready :)

@rinaok @yinonov
The developed tabs don't look like a design I created at all.
These are the links to Figma:
https://www.figma.com/file/JJNgZvt1qf3ydYmOwbE3Jg/Vivid-UI-Kit---3.0-WIP?node-id=19097%3A81745&t=n460dkt4vqkK2LqH-1
https://www.figma.com/file/JJNgZvt1qf3ydYmOwbE3Jg/Vivid-UI-Kit---3.0-WIP?node-id=19097%3A81791&t=n460dkt4vqkK2LqH-1
The appearance is ghost,
with bg 50 in hover state, and 100 in enabled state.
This pattern should repeat in all the ghost component.
Also the indicator is way under the tab itself,
it's supposed to be 1px in & 1px out.
Also,
the padding is not like in design at all.

@rinaok - I went over and remembered why this is not done yet :) visual things that are still need to be tended:

the focus ring need to be on only when keyboard navigation
not sure about the vertical design. Maybe we should remove it for now? in Vivid-2 we do not have it
the selected underline transition is not fixed yet (get offset width and position and after a split second its OK)

@rachelbt @yinonov

Why the focus ring should be only on navigation? In vwc-option for example the focus ring is activated on click.
Why should we remove the vertical design? I don't remember that we talked about it.
I think that the selected underline should be fixed with css, right?

Tab-panel documentation is missing. There's no recollection of it, what it's for or how to use it

Tab-panel documentation is missing. There's no recollection of it, what it's for or how to use it

@yinonov I don't think that we should have tab-panel readme file. It cannot live without the tabs and the tab. Therefore, it will look exactly the same as tabs readme.

partially patched up the janky transitioned active-indicator -
width is now determined by css variable assigned with the current active tab getClientRect().width.
The tabs container active-indicator is responsible for the smooth animation of transitioning from 1 active tab to another active tab when changed.
this active-indicator element is only visible when transitioned. this requires each of the individual child tabs to set their own active-indicator style when they're active. reason is to support edge case of a tab character data mutation. otherwise the animated active-indicator requires a mutation observer of character data. seem like a complete overkill when there are feasible css hacks around that.
there's still an issue of first change not well baked by fast.
indicator offsets unexpectedly outside horizontal boundaries. .active-indicator element seem to require an initial setting of
grid-column: ...;
transform: translateX(...);

Tab-panel documentation is missing. There's no recollection of it, what it's for or how to use it

@yinonov I don't think that we should have tab-panel readme file. It cannot live without the tabs and the tab. Therefore, it will look exactly the same as tabs readme.

not a readme, but a mention in tabs, at least. on why is it there?

@YonatanKra Do you have any idea why the test is failing?

About the UT failure: you can't retrieve a custom CSS var, it's a jsdom limitation.

@YonatanKra Do you have any idea why the test is failing?

About the UT failure: you can't retrieve a custom CSS var, it's a jsdom limitation.

Oh. Is there a workaround?

There are two issues with the coverage:

Two paths not taken when activeIndicatorRef? is not defined, in orientationChanged() and patchIndicatorStyleTransition(). It seems that activeIndicatorRef is kept when showActiveIndicator is switched false (which is not gracefully handled by the component it seems.)
jsdom does not handle getClientRects (another limitation), you need to mock it.

window.HTMLElement.prototype.getClientRects = function () {
    return [ { width: 10 } ] as unknown as DOMRectList;
}

@YonatanKra Do you have any idea why the test is failing?

About the UT failure: you can't retrieve a custom CSS var, it's a jsdom limitation.

Oh. Is there a workaround?

you mean like using Playwright? 😁

@YonatanKra Do you have any idea why the test is failing?

About the UT failure: you can't retrieve a custom CSS var, it's a jsdom limitation.

Oh. Is there a workaround?

you mean like using Playwright? 😁

The problem with playwright is that it opens a new browser for every spec file.
It is slow and resource consuming (comes hand in hand).
That's what FAST is doing, and while working on the grid, I see a lot of issues with that (besides the fact their tests take a lot of time to run locally on my machine, with lots of flakiness).

The problem with playwright is that it opens a new browser for every spec file. It is slow and resource consuming (comes hand in hand). That's what FAST is doing, and while working on the grid, I see a lot of issues with that (besides the fact their tests take a lot of time to run locally on my machine, with lots of flakiness).

it's a tradeoff. by choosing DX over accuracy, we should be aware we'll have unexpected behaviors in our tests (which, in turn, impact DX). I sympathize with the lack of watch mode which has been reported two years ago and have made a pros & cons list of PW vs jsdom here.


support config the exclude files patterns to disable preview

Clear and concise description of the problem
I generate the icon types in icons.d.ts which include many icons about 3500 icons.
When I open the file, vscode crash and no respond.

Suggested solution
support config files to disable preview.
{
    "iconify.preview.exclude": ["**/typings/icon.d.ts"]
}

Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Sure, pr welcome!


Missing device configuration: Namron Z-Wave Termostatplugg 16A

Checklist

[X] It is not in the configuration DB

[X] It was not merged recently or has a pending PR

Which device is missing?
Namron Z-Wave Termostatplugg 16A
Manufacturer ID
0x0438
Product Type
0x0200
Product ID
0xd004
Firmware Version
2.6.0
Is the device listed on the Z-Wave Alliance website?
no
Do you have a manual?
Manual: https://www.elektroimportoren.no/docs/lib/4512725-Brukerveiledning-5.pdf
Product page: https://www.namron.com/products/namron-z-wave-termostatplugg-16a/

fixed in #5349


Regrading to "NeRF_Representing_Scenes_as_Neural_Radiance_Fields_for_View_Synthesis"

Hi Max,
Thanks very much for your detailed tutorial on Youtube. But I have one thing pretty confused about. Taking the training dataset as an example, where the shape is 16,000,000 by 9, I see the first three numbers are the ray_origins, the mid three are the ray_directions, and the last three are the RGB colors. I am wondering how the ray origins and ray directions are computed. The problem may be tedious, but I think it would very helpful if it could be included in the video or the code.

Hi @chenmingxiang110,
Thank you for your suggestion. The aim of this repository is to provide i) short, and ii) self-contained implementations. I did not include the ray computation in order to keep the code short, but I agree it alters the self-contained criterion.
I think the ray computation can be incorporated in 15-20 lines of code, I will try to add them in the near future, thank you.
In case you need more details about the ray computation, here is a nice script, or my Udemy course where we discuss it in details.

Thank you very much for your reply:-)


Closes #124

Checks for null value.

Awesome, thanks for the PR.

No problem!
On Mon, Sep 14, 2015 at 5:20 PM, Tim Lancina<EMAIL_ADDRESS>wrote:

Awesome, thanks for the PR.
Reply to this email directly or view it on GitHub:
https://github.com/driftyco/ionic-plugin-keyboard/pull/125#issuecomment-140221965


Improved & expanded README

Added a second, more complex example to the README, which shows how to use the lp_sum function to programmatically build expressions.
The introductory section is revised and slightly expanded. The TODO/Future/Limitation sections are consolidated.
Also, updated contributors as per invitation: Issue #15

@jcavat I think you're the only one with write-access to the repo 🙂. Let me know what you think when you get a chance.


[$250] When sending text that NewDot thinks is a link, it adds the link markdown automatically and doesn't allow to edit

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open any chat
send safe.directory/link message
Edit the message to remove the link

Expected Result:
User would expect it to save the text as-is and be able to remove the link
Actual Result:
App won't let user to remove the link. If I remove the [] and (http://safe.directory/) from the message and hit Save, it adds them back.
Workaround:
unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.63-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43995119/169213256-805d3d4e-c468-46c9-a0ca-4daddc5b9261.mp4

Expensify/Expensify Issue URL:
Issue reported by: @rafecolton
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1652808490521729
View all open jobs on GitHub

Posted to Upwork!
https://www.upwork.com/ab/applicants/1527523209823019008/job-details
https://www.upwork.com/jobs/~012f7992db0fb8f099

https://user-images.githubusercontent.com/4989101/169474379-25c795a4-cb36-4dac-a11d-e43261cd9b3a.mov
Hi,
I would like to work on this issue!
I am not allowing the user to automatically convert the text to link if it is in editMode!
Is this the expected behaviour?

@NehaSantani Thanks for the proposal. However, I think that skipping the parser would affect other styles as well (code blocks, quotes, etc) and we wouldn't want that. Let me know if that doesn't answer your question and I can try to clarify any remaining concerns.

@luacmartins Hi,
I want a bit clarification on this issue!

1.) Do you want to remove the hyperlink styling on text after edit?
Or
2.) you want to avoid mdText that is being displayed in input while edit is clicked.

If its a yes for 2 :
Then My Proposed solution  to this problem is  use parser.htmlToText instead of parser.htmlToMarkdown !
Is there any specific reason we are using below line in ReportActionItemMessageEdit.js file at line no - 77
        const draftMessage = parser.htmlToMarkdown(this.props.draftMessage);

Instead we can use
        const draftMessage = parser.htmlToText(this.props.draftMessage);

Hey @NehaSantani! Thanks for the questions.
I think the intention is 1. We want to be able to:

Edit the comment
Remove the link md
When we save the edited comment, the link should be display as text (since we removed the link md).

What we have right now is that after editing, the link md is added back and the link is shown as a link instead of text.

Proposal
We should change the following:
https://github.com/Expensify/App/blob/56213d07d5e10b5ecf1cb2fae2d82aff9360bb5a/src/libs/actions/Report.js#L1393
to
    const htmlForNewComment = parser.replace(textForNewComment, ["link"]);

This will not run the link rule of the parser. However, the current implementation of the library does not allow a second argument. We'll need to modify the replace function such that it accepts a second argument which is an array of rule names to skip. As far as I know, it's not possible for me to directly edit that library. If this is not the case, please let me know.
@luacmartins

@allroundexperts the library can be found here and I believe you have access to it.

@luacmartins I can access it. I'll update my proposal.

@luacmartins Updated.

Cause
We cant detect url changes.
Solution
If the original text is changed but the output is not affected, we can ignore the link conversion.
It is active only if the link has been updated and is the same as the old one.
When we add this code to line 1394, we can achieve this. let htmlForNewComment of course.
https://github.com/Expensify/App/blob/56213d07d5e10b5ecf1cb2fae2d82aff9360bb5a/src/libs/actions/Report.js#L1391-L1394
if (htmlForNewComment === originalReportAction.message[0].html && textForNewComment === originalReportAction.message[0].text) {
        //alert('link not present anymore and same text show up');
        parser.rules = parser.rules.map(rule => rule.name !== 'link');
        htmlForNewComment = parser.replace(textForNewComment);
    }

https://user-images.githubusercontent.com/6093207/169603919-37c80004-0297-4719-b1de-44ae5486c6bf.mp4
note : I just realized that he mentioned this approach actually @allroundexperts .
It would be nicer if it was detected and done in this way, in my humble opinion.
You can think of it as if I didn't do proposal @luacmartins 😅 .  I wrote it so that maybe I can contribute to the solution 👼 .

I'll try to evaluate the proposals today!

@luacmartins I going OOO on next week, so I am happy to defer this to another C+.
Can you reapply exported, I am un-assigning myself here.

Current status: Proposals yet to be reviewed!

@mananjadhav Santhosh is going ooo next week, so we reassigned this issue and you were the chosen lucky one!

@allroundexperts I think that your proposal might have some unintended side effects. Always skipping the "link" rule on edit means that we would always remove links, even when we want them. Maybe I missed something? I think the correct style to skip is probably "autolink".
@metehanozyurt your approach is quite similar to @allroundexperts's approach. However, I think that running the parser twice is not a good option for performance reasons. The parser is quite slow and if we have a long comment that would be problematic on mobile devices.
@NehaSantani your proposal is almost identical to @allroundexperts's approach.

@luacmartins You're correct. We should be using using autoLink. I'll update my proposal.

@luacmartins I've updated the proposal.

@mananjadhav any thoughts here?

@luacmartins I went through the proposals, and @allroundexperts's proposal does solve the issue. I was out sick. Still catching up.
I have a few questions about the behavior.

Are we saying we allow autolink for create message but not for edit message?
Is Do nothing an option? My experience with Slack and other tools has been that a link stays as a link.
What Slack does is, when I edit the link it gives me an option to remove the link from the text.

If the answer to the first question is one is yes and rest no, then we're good with @allroundexperts's proposal.

Are we saying we allow autolink for create message but not for edit message?

Correct!

Is Do nothing an option? My experience with Slack and other tools has been that a link stays as a link.

That's always an option. Although as you mentioned in 3, editing a link in Slack gives you the option to remove it. The problem here is that even when we edit the link to remove it, it gets added back via the autolink parsing rule.

Are we saying we allow autolink for create message but not for edit message?
Correct!

Then @allroundexperts's proposal looks good to me.
🎀 👀 🎀 C+ reviewed

@allroundexperts your proposal looks good! Assigning you to this issue.

Applied on upwork!

@allroundexperts offer sent

@allroundexperts any updates for us on this one?

I’ll have a PR today.
On Thu, 9 Jun 2022 at 3:20 AM, Manan @.***> wrote:

@allroundexperts https://github.com/allroundexperts any updates for us
on this one?
—
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/issues/9090#issuecomment-1150471118,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHFJUUD4RLTN6GL3AMR6M4LVOEMBZANCNFSM5WK6C2MA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@allroundexperts Were you able to get to this? Are you facing any challenges?

@mananjadhav Apologies for the delay.
https://github.com/Expensify/App/pull/9405

Thanks for the PR @allroundexperts. Change looks fine. I'll test this today/tomorrow and update here.

@allroundexperts Do you have any updates for me on this one?

@mananjadhav Updated the PR.

Note: Please hold payment on this regression.

@allroundexperts could you please look into a fix for that regression?

@luacmartins What's the expected behaviour?

The expected behavior is as follows:

User sends a message with a link
User edits the message
If the user intentionally removes the hyperlink in their edit, i.e. from [text](link.com) to link.com markdown, we should not autolink because the user wanted to remove that hyperlink
If the link still has the hyperlink markdown when the user saves the edit, i.e. they edit something and the link markdown is still [text](link.com), we should keep the hyperlink as the user did not want to intentionally remove it

Does that make sense?

Coming from your comment here @luacmartins.
If you carefully observe the video, https://user-images.githubusercontent.com/3069065/178571896-3570f289-4f90-4b92-84b8-d051fca67dc9.mov, editing some links doesn't show up [text](link.com) syntax. It only shows the http://link.com text. Hence my confusion on resolving this. You'll see google.com works just fine, because editing it shows [google.com](google.com) but https://mail.google.com doesn't show the markdown syntax.

I do not think this is an issue we should fix, as we are supporting auto-link in the initial message, the user expects it to work on the edit message too.
[text](URL) and URL are the same thing
Tested on Github it also has the same behavior.

@mananjadhav Thanks for clarifying! It makes sense now and it seems like the issue is that we are not adding the markdown syntax to those links when editing them, i.e. https://mail.google.com should show up as [https://mail.google.com](https://mail.google.com) when we tap edit, but it shows up as https://mail.google.com.
In that case I agree that it is not a regression, but it would be nice to fix that and add the markdown to those links. Let's move this conversation back to the original issue to work on a fix there.

@kadiealexander this is not a regression and we should proceed with payment as usual.

Thanks @luacmartins! Will pay tomorrow as expected.

@allroundexperts  - Paid! Thanks for your work.
@mananjadhav - just sent you an Upwork contract. Could you please let me know when you accept?

All paid! Thanks team!


Wrong datatype in PHP Doc when using typehint attribute

I have the following schema:
<table name="user">
    <column name="email" type="varchar" size="255" typehint="my\namespace\Email"></column>
</table>

The generated base class then looks the following:
use my\namespace\Email;
...

abstract class User implements ActiveRecordInterface {
     ...

     /**
     * Set the value of [email] column.
     *
     * @param string $v new value
     * @return $this|\User The current object (for fluent API support)
     */
    public function setEmail(Email $v = null)
    {
        if ($v !== null) {
            $v = (string) $v;
        }

        if ($this->email !== $v) {
            $this->email = $v;
            $this->modifiedColumns[UserTableMap::COL_EMAIL] = true;
        }

        return $this;
    } // setEmail()

     /**
     * Get the [email] column value.
     *
     * @return my\namespace\email
     */
    public function getEmail()
    {
        return $this->email;
    }

In the setter the typehint is right but the doctag is not (as it describes $v to be string instead of Email).
In the setter the typehinted class is referenced with its fully qualified name instead of only Email (because it got already referenced with the use-statement).
I have to admit that I did not run this code. It is only what PhpStorm is marking.
But one more question: I understood that serialization of the Email object is done with the __toString() method (because of the string cast in the setter). But is Propel able to create the Email object when querying a User entity?
Also I am wondering how the query class' filterByEmail method could use Email objects as search parameter.

I had the same problem. Please see #984


Implementing WorkflowStatusListener interface

I am trying to implement my own version of WorkflowStatusListener . I am seeing that my listener is getting picked up in the sense that I can see the log statement in the constructor of class getting called.
However I dont see the calls going to the two methods "onWorkflowCompleted" and "onWorkflowTerminated" .
Is there something else which needed to be done?
It seem that the class WorkflowExecutorModule.java seem to have a stub binding in place which is being used.

My mistake, the WF did not have the status listener turned on.


Unrecognized keywords

So apparently newlines like this doesnt work:
{
	'match': '\\b(abilcmd|actor|actorscope|bank|bool|byte|camerainfo|char|
				  color|fixed|int|marker|order|playergroup|
				  point|revealer|region|soundlink|string|text|timer|
				  transmissionsource|trigger|unit|unitfilter|unitgroup|
				  unitref|void|waveinfo|wavetarget)\\b'
	'name': 'storage.type.builtin.galaxy'
}

Because color, point, transmissionsource and unitref are not recognized as keywords.

Collapsed the matching string, should match properly now.
Thanks!