[FEAT]: Learn how to save files from colab notebook to google drive

Description
Learn how to save files (possibly with various content... ) from colab notebook to google drive.
Additional Information
No response

I've tried this and it works (after giving the permission):
from google.colab import drive
drive.mount('/content/gdrive')

with open('/content/gdrive/MyDrive/content/foo2.txt', 'w') as f:
  f.write('Hello Google Drive!')
!cat /content/drive/MyDrive/content/foo2.txt

drive.flush_and_unmount()
print('All changes made in this colab session should now be visible in Drive.')


Domain Handling

Current Situation
ZITADEL currently selects the instance context based on a HTTP header (see order below) and checks it against the list of instance domains. Let's call it instance or API domain.
For any context based URL (e.g. OAuth, OIDC, SAML endpoints, links in emails, ...) the requested domain will be used. Let's call it the public domain.
Example

Instances
Generated Domain
Custom Domain(s)

Test
test-asjklr.zitadel.cloud
-

Prod
prod-f4gss.zitadel.cloud
auth.mydomain.com

Request
Instance
Public Domain / Issuer

https://test-asjklr.zitadel.cloud/.well-known/openid-configuration
test instance
https://test-asjklr.zitadel.cloud

https://prod-f4gss.zitadel.cloud/.well-known/openid-configuration
prod instance
https://prod-f4gss.zitadel.cloud

https://auth.mydomain.com/.well-known/openid-configuration
prod instance
https://auth.mydomain.com

This led to some confusion / issues in the past for self-hosters, as you would need to set up / configure ZITADEL with the domain you'll expose it.
Additionally, the new login UI will require proxy functionality, which requires an easy way to select the instance and also the public domain, which might differ.
Current implementation
HTTP1:

configured header (if not host)
"origin":

forwarded
x-forwarded-*
host

GRPC:

HTTP1 host (see above)
configured header (authority by default)

OIDC:

forwarded
x-zitadel-forwarded
host

Proposal
First of all we should allow the selection of the instance context and public domain separately. A client / developer must be able to do so by using preconfigured headers. This allows to address different scenarios
Allow setting instance context by header
(Self-Hosting) single instance
An admin wants to just start ZITADEL “out-of-the-box” and all traffic routed to the binary just needs to be handled as is:
Automatically select the only instance and use the Host header (as default) for the public domain.
In case of a (reverse) proxy, a configured public domain header must be sent by the proxy and handled by ZITADEL.
Single tenant mode
To prevent fallbacks in multi instance setups, a flag for the single instance / tenant must be activated.
Multi instance setup
ZITADEL needs to be aware of the instance context and therefore needs this information from either the Host header or a preconfigured (instance) header.
In case of a (reverse) proxy, it can either just be sent as Host header or any other header, which just needs to be configured in ZITADEL.
If the instance header is not sent in the request, we fallback to the Host header.
ZITADEL cloud
Works like any other multi instance setup, but there are probably more external setups possible as we cannot control the clients as much as you could in a self hosted setup.
Therefore we need to have an explicit instance header, e.g. X-Zitadel-Instance and not rely on any predefined (forwarded, x-forwarded, …) header.
Allow setting public domain by header
Additionally to support the scenarios where a reverse proxy, e.g. login UI needs the ability to overwrite the public domain, we should allow so by an additional header. In case the header is not set by the request, we fallback to the instance header, resp. it’s default the Host header.
Example

Request
X-ZITADEL-INSTANCE
X-ZITADEL-DOMAIN
Instance
Public Domain / Issuer

https://test-asjklr.zitadel.cloud/.well-known/openid-configuration
-
-
test instance
https://test-asjklr.zitadel.cloud

https://auth.mydomain.com/.well-known/openid-configuration
-
-
prod instance
https://auth.mydomain.com

https://prod-f4gss.zitadel.cloud/.well-known/openid-configuration
-
auth.mydomain.com
prod instance
https://auth.mydomain.com

https://api.zitadel.cloud/.well-known/openid-configuration
auth.mydomain.com
-
prod instance
https://auth.mydomain.com

https://api.zitadel.cloud/.well-known/openid-configuration
auth.mydomain.com
customer1.auth.mydomain.com
prod instance
https://customer1.auth.mydomain.com

Redirect URI
We need to clarify how to handle the redirect_uri check in cases of automatic domain handling / public domain overwrites.

@fforootd please add / update if i missed anything
@peintnermax FYI

Going to check it in a few minutes!

Some small thoughts:

We should make a multi-tenant toogle and default to single-tenant
I would default to x-zitadel-publicdomain to be more explicit for the header that carries what public domain we run (it should anyway be configurable)

The rest looks good to me!

Some small thoughts:

We should make a multi-tenant toogle and default to single-tenant
I would default to x-zitadel-publicdomain to be more explicit for the header that carries what public domain we run (it should anyway be configurable)

The rest looks good to me!

About the toggle: Defaulting to single-tenant would certainly improve DevX when starting from scratch but would also break all existing systems 😏 --> V3? 😄

We should make a multi-tenant toogle and default to single-tenant

This would be very helpful for our use case. We currently host zitadel and our applications on a single server via docker-compose and have hit numerous very hard to debug and fix issues with wrangling zitadel to use the correct instance.
We currently have yet another auth bug because the email server is using the docker address as the base url for generating email links rather than the configured EXTERNAL_DOMAIN. Enabling a toggle to put zitadel into a single instance mode should prevent issues like this and would drastically reduce the unnecessary DevX complexity when using zitadel for a single organisation / application.


Create Entity class

Signed-off-by: Kaiyuan Hu<EMAIL_ADDRESS>

Codecov Report

Merging #799 (ede8c5b) into main (c998703) will increase coverage by 0.01%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #799      +/-   ##
==========================================
+ Coverage   70.80%   70.81%   +0.01%
==========================================
  Files         169      170       +1
  Lines        7723     7747      +24
  Branches     1267     1270       +3
==========================================
+ Hits         5468     5486      +18
- Misses       1880     1886       +6
  Partials      375      375

Impacted Files
Coverage Δ

towhee/functional/entity.py
75.00% <75.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c998703...ede8c5b. Read the comment docs.

/lgtm
/approve


Zooming not working

Hi!
I tried to leftCTRL + mouse to zoom in my graph, but it does nothing, not even an error is shown.
I am using a WpfGraphController<FloatDataPoint, FloatDataPoint>

Fixed absolute position calculation casting for float data point.
Please get the latest code or nuget.


Fixed bug that caused reader.cs to read input incorrectly

Fixed a bug where when a csv file contains an entry with multiple
Windows new line characters (\r\n) in succession, reader.cs would read
each \r\n as a separate entry instead of the whole string of them as one
entry.

Thank you!


today() is not working correctly

There are some problems in today(), and I know some other people filled issues about it but here are my problems with ADM, and today() :

Today button needed to have a type="button", otherwise, it is trying to submit its parent form.
Icons are not included, I don't know if is there any dependencies for ADM?

Thank you
This date picker is nice and is working good, but there are some small problems to become better

Hi Mohammad ,
Thanks.
I think it's fixed in V1.1.6.

@MeTe-30  Thanks for your good support :+1:


Migrate default query function example to vite

Codecov Report

Merging #3954 (3d28811) into main (eab6e2c) will increase coverage by 0.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3954      +/-   ##
==========================================
+ Coverage   96.36%   96.77%   +0.41%
==========================================
  Files          45       57      +12
  Lines        2281     2666     +385
  Branches      640      782     +142
==========================================
+ Hits         2198     2580     +382
- Misses         80       84       +4
+ Partials        3        2       -1

Impacted Files
Coverage Δ

src/core/retryer.ts

src/react/utils.ts

src/react/QueryErrorResetBoundary.tsx

src/react/useQueries.ts

src/core/subscribable.ts

src/core/notifyManager.ts

src/core/query.ts

src/react/QueryClientProvider.tsx

src/react/useBaseQuery.ts

src/devtools/Explorer.tsx

... and 92 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2861b53...3d28811. Read the comment docs.


fatal error: parser.h: No such file or directory

So I've downloaded several versions (git, 2.1.1 and 2.1.0) and always I receive the following error during compilation:
Building C object src/CMakeFiles/zmap.dir/shard.c.o /home/ubuntu/sslscan/src/github.com/zmap/zgrab/zmap/zmap-2.1.0/src/filter.c:12:20: fatal error: parser.h: No such file or directory  #include "parser.h"                     ^ compilation terminated.
I followed the installation instructions and installed the dependencies via
sudo apt-get install build-essential cmake libgmp3-dev gengetopt libpcap-dev flex byacc libjson-c-dev pkg-config libunistring-dev
then
cmake -DENABLE_DEVELOPMENT=OFF .
make -j4
and make fails. I need ztee, which is not included in the apt package of my Ubunutu distribution and I hope to receive it from the source install.
Can someone help me?
this seemt to be related to #271
therefore my details:
byacc - 1.9 20140101
cmake version <IP_ADDRESS>
Kernel: Linux 3.13.0-92-generic x86_64
Ubuntu 14.04.4 LTS

I believe that parser.h is generated by byacc. Can you double check that you can run flex and byacc on your machine?
What happens when you run:
flex -o "src/lexer.c" --header-file="src/lexer.h" "src/lexer.l"
and
byacc -d -o "src/parser.c" "src/parser.y"

weird... after a reboot it worked now. Btw: this issue did not happen on debian 8.
It is a Amazon EC2 instance. Thanks for your input though.
for the record though, the output was:
ubuntu@XXXXX:~/zmap-2.1.1$ flex -o "src/lexer.c" --header-file="src/lexer.h" "src/lexer.l" ubuntu@XXXXX:~/zmap-2.1.1$ byacc -d -o "src/parser.c" "src/parser.y"


Comments should be less visible

Check for existing issues

[X] Completed

Describe the feature
In most of available themes here the comments are too "insistent". Only in the `One Dark' theme they look good in my opinion, because they are slightly dimmed and do not catch the eye so much.
If applicable, add mockups / screenshots to help present your vision of the feature
No response

I assume this would be solved by #538

@jansol For me "solved" means "OK by default" - not "you can solve it yourself" 😅

Only in the `One Dark' theme they look good in my opinion, because they are slightly dimmed and do not catch the eye so much.

Agree. I've been using Rose Pine Moon which also has subtler comments.
I'd prefer to be using Ayu Mirage, my favourite theme in VSCode, but the comments carry the same weight as the code. In the original source for ayu they're not as prominent.
Could we get some of the comments toned down, at least until #538 is released?


Non-standard devkitPro installation path not detected on Windows

Hi, I'm running into an issue with this tool running in Windows 10.
When attempting to launch the program, I get the error saying that I must install wubtool "correctly" to be able to use the program, even though it's fully installed. Looking into the source code, I believe this is because it's searching for a hard coded path of c:\devkitPro* for devkitPro's installation, while I installed it to D:\applications\devkitPro*
Adding a .ini file to set a custom devkitPro\tools\bin directory, a dialog available at boot to set it to a custom path, or at least having the program check within the same directory that the executable is placed in, would probably be all that needs to be changed to fix this.
In my case I'm just going to move the directory, but I thought I'd add the Issue here so you can fix it for future users. Thank you!

Hey, thanks for submitting this issue! I appreciate it!
You are correct, the paths are currently hard-coded to wherever devkitPro should install by default on both Windows and Linux. I am not a fan of this behavior myself, so I have been looking into this issue over the past while, even before you submitted this. The problem is that I can't find a solution I like that would replace this behavior.
My current idea I have been toying around with was to look at the environment variables which devkitPro would set during install. As far as I can tell, this approach shouldn't be much of a hassle to get going in a Linux environment. However, I can't really say the same for Windows, which is a shame because I wrote WUHB Packager particularly for Windows users.
Currently, my DEVKITPRO variable is set to /opt/devkitpro. Unless my installation is borked, I don't fully understand how I can use this variable on Windows. I assume it's because devkitPro stuff is traditionally supposed to be ran under MSYS2, rather than just through Command Prompt or Terminal.
I feel like I might be hitting it on the money with my idea, but I just don't know how to implement it. I will continue to toy with this idea, and consider other solutions if nothing else.


Gatsby/mbch chapters 3 plus

Summary

Mastering Bitcoin Cash chapters 3-8
Chapter 7 still needs to be done

Looks great. Merge when ready.


Next issue with scripts. CHANGED_REGION_START

Can it be that a region restart is not recognized by LSL i have a script containing this:
changed(integer change)
  {
      //Region restartet
      if (change & CHANGED_REGION_START)
      {
          //Request new URL
          llResetScript();
          status = TRUE;
          llRequestURL();
          llInstantMessage(llGetOwner(), "The Region " + llGetRegionName() + " has been restarted, please put me back online!");
      }
  }

However if i restart the region i dont get the llInstantMessage it seems like it does not do anything, i would expect to get the message after the restart.
Edit: nevermind my mistake with llResetScript

Closing this, was just an extraneous llResetScript() call


Make dask collections hashable?

Should we be able to put dask arrays and dataframes within sets and dictionaries?  This can be convenient at times (I'm trying to put collections in dictionaries in order to specify resource constraints) but breaks with the immutability guarantee.
cc @jcrist @shoyer

We already made dask collections mutable when we defined __setitem__ on Array. So I don't see how we could possibly make them hashable.
One plausible alternative is to make dask dictionaries hashable, e.g., by wrapping them in some sort of light-weight Frozen class.

I also don't think we should make them hashable. Since constraints are kept by task key, perhaps keep a mapping of keys to constraints instead of collections to constraints?

OK, closing


Fix warnings from Meson's warning level 2

Fixes three small warnings reported by activating warning level 2 in meson.

Thanks!


Point the documentation link to docs.rs

It seems the current documentation link in Cargo.toml leads to a 404 page.

Closed in version 1.0.0 by commit f53d06f.


Vue 2 support

What problem does this feature solve?
Continue to create safe and secure applications with Vue 2.x
What does the proposed API look like?
I've seen the statements and the roadmap here:
https://github.com/vuejs/vue/projects/6#card-16117796
https://v2.vuejs.org/lts/
I have a large application made with Vue 2 and Vuetify 2. I cannot migrate the application until Vuetify 3 components are ready and mature. I'd like to request to continue support for Vue 2 till the ecosystem is ready to allow migration. The migration is a long and expensive process. Clients don't like buggy applications.
So, I request for the support to be extended for another 6 months till June 2024, by then Vuetify 3 will be ready.
Can I know if you will be able to extend the support for Vue 2.x in favor of people who are in similar situation like me?
Thanks,
Gajendra Kashyap

We are in same situation. Our solution:

update to Vue 2.7 with vite and pinia
remove vuetify and choose other library with Vue 3 support
upgrade to Vue 3
In vuetify are problems with migration of data tables and others to Vue 3.

Hi Marcel,
We have a small company and team, we can't afford to switch so easily with a large application. It is a lot of work.
Thanks.

Yes.
Maybe first step:
update to Vue 2.7 with vite and pinia
will be good start :)

We announced the EOL plan 18 months ago when 2.7 was released, and provided the promised 18 months of LTS. This 18 months was supposed to be the period for users to plan and execute a migration plan.
As an independent project providing all of our code for free, I think we have done what we could. We have limited bandwidth, and we need to focus what we have on improving Vue 3 for the future. Unfortunately, that means Vue 2 support will end as planned.


[Task] Integrate translation service in DevOps

We have decided to use a service to better manage the localization of the extension.
The service chosen is Crowdin.
To integrate the service with our repo a configuration file (crowdin.yml) is needed.
The content of the file must be:
files:
  - source: package.nls.json
    translation: /package.nls.%two_letters_code%.json
    languages_mapping:
      two_letters_code:
        zh-CN: zh-cn
        zh-TW: zh-tw
  - source: /locale/lang.en.json
    translation: /locale/lang.%two_letters_code%.json
    languages_mapping:
      two_letters_code:
        zh-CN: zh-cn
        zh-TW: zh-tw

This can also enhance #526.

I'm in favor of using Crowdin 👍

OK. I'll provide a PR to start utilizing the service. For questions about the workflow of the service contact me on slack.


Make backward-cpp compatible with nvcc_wrapper

This is a follow-up of pull request #96
if nvcc_compiler is used together with MPI wrapper, we need to check env variables OMPI_CXX and MPICH_CXX to really know if nvcc compiler is used and then de-activate flag "-pedantic-errors".

Is it possible to merge this small modification ?
Thanks.


adding setSession back in for site login

Thanks so much for creating this binding!  Glad to see you met up with my fork.  I pulled yours again to get up to date with ios unified.  I added back the setSession method in this update.  We're using this for our New Belgium app Beer Mode, which is about to be released.  I really appreciate it!

Thanks for the pull request


When will the London Region support will be available?

I would like to configure my mobile project serverless via amplify cli but I can't see London (west-2) support in the configuration.
Is there any approx. date for this region support? I really want to avoid moving between regions.

@animalmagnetic  I cannot comment on the timeline for this. As soon as the AWS services we support as a part of the CLI are available in London, we'll make it available as a part of the CLI.

@@animalmagnetic We launched London support with CLI version 1.1.8.

Thank you!


v1.0.7 🍉

Codecov Report

Merging #166 (82be314) into main (e36e839) will increase coverage by 0.48%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main      #166      +/-   ##
===========================================
+ Coverage   99.51%   100.00%   +0.48%
===========================================
  Files          45        45
  Lines        4131      4190      +59
===========================================
+ Hits         4111      4190      +79
+ Misses         20         0      -20

Impacted Files
Coverage Δ

blacksheep/client/connection.py
100.00% <100.00%> (+7.77%)
:arrow_up:

blacksheep/server/openapi/v3.py
100.00% <100.00%> (ø)

blacksheep/client/pool.py
100.00% <0.00%> (+6.09%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c8491a...82be314. Read the comment docs.


Add Panel layout docs and enhancements [doc-build]

Codecov Report

Merging #347 into master will increase coverage by 0.11%.
The diff coverage is 90.86%.

@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
+ Coverage   86.94%   87.05%   +0.11%
==========================================
  Files          88       88
  Lines        7583     7741     +158
==========================================
+ Hits         6593     6739     +146
- Misses        990     1002      +12

Impacted Files
Coverage Δ

panel/tests/widgets/test_slider.py
100% <ø> (ø)

panel/tests/widgets/test_player.py
100% <ø> (ø)

panel/tests/widgets/test_button.py
100% <ø> (ø)

panel/tests/widgets/test_input.py
100% <ø> (ø)

panel/tests/pane/test_equation.py
100% <ø> (ø)

panel/tests/widgets/test_select.py
100% <ø> (ø)

panel/tests/pane/test_vega.py
96.61% <ø> (ø)

panel/tests/pane/test_markup.py
100% <ø> (ø)

panel/tests/pane/test_plotly.py
97.46% <ø> (ø)

panel/tests/pane/test_image.py
100% <ø> (ø)

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc0b7d8...0ada9e6. Read the comment docs.


Updated James' about info

@jamesma560 So i merged all your pull requests but your info doesnt seem to show up on the People page. Not sure what's wrong here?


Day93

Resolves #196.

Pull Request Test Coverage Report for Build 410

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 401:
0.0%

Covered Lines:
5

Relevant Lines:
5

💛  - Coveralls


pre-commit config references a broken symlink in nix store

Describe the bug
When trying to set pre-commit.settings.prettier.binPath my generated .pre-commit-config.yaml file ends up with an entry referencing a broken symlink in my nix store.
Here's an example of generated config file https://gist.github.com/alejandro-angulo/a467575f910ea4bb7b837d913f8e44af
To reproduce
I've created a repo to reproduce this bug: https://github.com/alejandro-angulo/devenv-pre-commit-test/tree/59e2e768d472d64e39e9d47992fd54c83cfb9d31
git clone https://github.com/alejandro-angulo/devenv-pre-commit-test.git
cd devenv-pre-commit-test
nix develop --impure  # or `direnv allow`
pre-commit run prettier --files test.js

On my machine I get this output
❯ pre-commit run prettier --files test.js
prettier.................................................................Failed
- hook id: prettier
- exit code: 1

Executable `/nix/store/apjv7ccblhywdccadbpb2w0ghd0k20fb-prettier` not found

❯ l /nix/store/apjv7ccblhywdccadbpb2w0ghd0k20fb-prettier
lrwxrwxrwx 28 root 31 Dec  1969  /nix/store/apjv7ccblhywdccadbpb2w0ghd0k20fb-prettier -> ../prettier/bin/prettier.cjs

Notice that the symlink resolves to a directory /nix/store/prettier/.... (this does not exist).
I expected the executable to match the value I see in nix repl
nix-repl> outputs.devShells.x86_64-linux.default.config.pre-commit.settings.prettier.binPath
/nix/store/a80wmqkzayj1kvrllif6db3c0skklymr-source/node_modules/.bin/prettier

Version
devenv: 0.6.3

I'm not sure that can even work, it would work if the path was a string and binPath allowed types.string.

Ah interesting, thanks for the explanation it makes sense now.
I was playing around in a nix repl and if there were an option to specify that the binPath exists in the repo (if the file is in the repo I think it should be safe to avoid creating a copy). binPathInRepo is a hypothetical new option under pre-commit.settings.prettier.
nix-repl> binPathInRepo = true

nix-repl> "I'm a string ${if binPathInRepo then toString outputs.devShells.x86_64-linux.default.config.pre-commit.settings.prettier.binPath else outputs.devShells.x86_64-linux.default.config.pre-commit.settings.prettier.binPath}"
"I'm a string /nix/store/a80wmqkzayj1kvrllif6db3c0skklymr-source/node_modules/.bin/prettier"

nix-repl> binPathInRepo = false

nix-repl> "I'm a string ${if binPathInRepo then toString outputs.devShells.x86_64-linux.default.config.pre-commit.settings.prettier.binPath else outputs.devShells.x86_64-linux.default.config.pre-commit.settings.prettier.binPath}"
"I'm a string /nix/store/apjv7ccblhywdccadbpb2w0ghd0k20fb-prettier"

This seems kinda hacky but it would work. Maybe there'd be a way to infer that the binPath points to a file already in the repo (and remove the need for adding something like pre-commit.settings.prettier.binPathInRepo)?
Would something like this be a change that would be considered if I opened a PR against pre-commit-hooks.nix?
By the way, I realize now my issues is really about pre-commit-hooks.nix and not devenv itself. If you prefer, I can close this issue here and continue the conversation in pre-commit-hooks.nixs issue tracker.


Feature Request: Get visual feedback, when invoking clang-format on project level

It would be good to get some visual feedback that clang-format is currently running over the project. So far I thought it works not on project level, because I get no feedback after clicking.

Hi,
We are happy to announce you that we added status bar support for clang-format in the new version CPT v4.5 just released. In the future we will take in consideration to improve the feedback for all the extension commands, so stay tuned for future improvements
Thank you for your feedback 😄


Create SimpleCalculator

input two number and and an any operation and this program will calculate the result.
For example., 2 3 *
output=6
Description
enter here if you have any details
Program Name -Simple Calculator
Issue No.- #358

Type issue number after hash(#)

Checklist(self check)

[x] Yes, this task assigned to me.
[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] My Filename is in camelCase format
[x] I have added Problem statement, Problem link in file.

Invalid isssue numer.
No Edabit question
Un assigned PR


Update with prepr

Minor edit to update the PEMr package in line with PEMprepr updates.
Edited directory structure file, core templates and vignette and update tests.
@ateucher - I was not going to ask for a review as this is a simple update, however it looks like the macos checks are failing so I might need your expertise.

@ateucher - it seems to be passing now, so will go ahead and merge!


update latest version on pypi.org

Hi,
Could you please update latest pip-review on pypi.org?
https://pypi.org/project/pip-review/

@Mark-Joy Please clarify what you mean by your request.

@jgonggrijp Hi, when I do pip install pip-review, I did not get the latest version. The date on pipy was Mar 22, 2020
There was some updates at github such as: constraint file and other fixes..

I see. I'll try to get to it on Friday.

@jgonggrijp how was the update going on?

Terribly sorry, I forgot about it and I didn't roll the update. My next opportunity is Wednesday, November 17. I'll write it down it in my agenda.

@jgonggrijp Since today is Nov-17, a reminder here may help a little bit :)

@Mark-Joy Version 1.1.1 is now up on PyPI. Sorry for the long delay. Merry christmas!


Program improvement suggestion #2

Suggest an option to apply the same color to all nodes with the same callsign.  (Or is it doing this already?  My map is so dense I can't tell.)

Select a node
Set the color
click in the background (if it doesn't do it the first time, click again)

I knew that worked, but it wasn't obvious that I was setting the color for more than that node.

If it only does one and you think it should be more just click the background again

Would be good to add checkboxes to the color picker to specify what you want to color:

Single node
All nodes with callsign
Network Background

dupe #12


Logic to identify the hierarchy for widgets - Example: The List Widget uses the existing widgets under the hood and we should be able to group these widgets files as one

Need to discuss with FE and discuss if this is possible.

@hetunandu Is this possible?

Working on this in the backend completely. Attached the image.

Changes are available via the PR - https://github.com/appsmithorg/appsmith/pull/24764


Doorbell - which camera?

I've got 3 Cams and one doorbell integrated in homekit2mqtt.
Is there any option to setup which camera "pops up" in Homekit, when the doorbell is pressed?
Can't find it. Or is the cam choosen by the HomeApp?

i think it just depends on the room. Try to assign the camera and the doorbell to the same room.

Yep, you're right. Thanks


ReferenceError: customElements is not defined

[X] bug

Expected behavior
New Angular 6 app built using the CLI, seeing a reference error in debug console.
ReferenceError: customElements is not defined clr-icons.min.js:17:345

Actual behavior
Don't expect to see any error.
Reproduction of behavior
Create new app using cli and follow step to install Clarity design.

Include a link to the reproduction scenario you created by forking one of the Clarity Plunker Templates:

Environment details

Angular version: 6.0.2

**Clarity version: 0.12.1

**OS and version: Linux karma 4.13.0-45-generic #50~16.04.1-Ubuntu SMP Wed May 30 11:18:27 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

**Browser: Firefox Quantun 60.0.2 (64-bit)

I had the same issue, it was because I was loading the clr-icons.min.js before the polyfill.  FYI, I got it from the clarity-seed project, which also seems to have it backwards.  https://github.com/vmware/clarity-seed/blob/master/.angular-cli.json

The seed has it correct https://github.com/vmware/clarity-seed/blob/master/.angular-cli.json#L29.
Also, if you are starting a new project you can run ng add @clr/angular and it should set it up correctly for you.

@gnomeontherun -- That's actually the line I had to manually edit, and put the "../node_modules/web-animations-js/web-animations.min.js" script above it (switch lines 29 and 30).  My scripts section:
"scripts": [
<EMAIL_ADDRESS><EMAIL_ADDRESS>            ]

Oh, yep, I misread web-animations for webcomponents.  Sorry about that.


VS2012 light theme doesn't redraw document tabs with OnMouseMove

When using the VS 2012 light theme, tabs only get redrawn in response to a WM_MOUSEHOVER event, which has a noticable delay. If you constantly move your mouse over an inactive tab, it'll take 0.5 - 2 seconds for the tab to highlight, finally indicating that the tab is under the mouse.
Since the entire VS2012LightDockPaneStrip is a single control, the events OnMouseEnter and OnMouseLeave won't be much help to fix this, since if the mouse stays within the control (moving between tabs without leaving the control's area), the tabs don't repaint until WM_MOUSEHOVER fires which can be a while (especially if the mouse is never stationary).
A cheap fix is to take all of the code in VS2012LightDockPaneStrip.OnMouseHover, copy it to a new method, and then call that method from OnMouseHover and OnMouseMove. This will cause a lot of repainting, however, even if the active tab doesn't change (which is the complaint in https://github.com/dockpanelsuite/dockpanelsuite/issues/141).
A better fix might be to always track enter/leave/move/hover on a per-tab basis, and redraw only the tab(s) that changed instead of the entire control, and only redraw when their state changes.

Same problem occurs with the 2013 theme, probably for the same reason. You can really easily reproduce this in the sample by endlessly, quickly wiggling the mouse over the tabs - none of them will be highlighted (and thus show their close button) until you finally let the mouse be still over one tab.

Thanks for pointing out the issue. We welcome pull requests on such optimization.


[docs] Remove unecessary createStyles in TypeScript Tabs demo

This PR changes files in Tabs demo that uses createStyles when the Hook API makeStyles is already used. When using TypeScript, makeStyles alone is enough -- createStyles is used only if the HOC API withStyles is used -- because there are some type incompatibilities with some styles e.g. flexboxes (flexDirection, flexGrow, etc.).
Some parts of the demo I left them as they were -- because I think HOC is more appropriate in these cases instead of Hooks, e.g.
https://github.com/mui-org/material-ui/blob/44c335c3b3f8669b16901c5f777bb5ba9e9241c0/docs/src/pages/components/tabs/CustomizedTabs.tsx#L16-L49
This is because withStyles generates classes prop directly -- and almost all Material UI components can consume classes prop from its parent. As they are more like "reusable sub-components", inlining withStyles with the components is better in my opinion.

[x] I have followed (at least) the PR section of the contributing guide.

@Imballinst Much appreciated. Thanks.


[OpenCL] Implementation improvements

OpenCL implementation improvements (#22)

[Build] Use gcc/g++ as a host compiler to avoid #8394 (#54)
[Eigen] Version bump
[OpenCL] Implementation improvements

Register SYCL implementations for random ops

Simplify by using Eigen math functions

Registers Scatter and ScatterNd Ops for SYCL
Registers Stack op for SYCL
Fixes No sycl buffer found error for debug ops
Registers MatMul and Transpose Ops to SYCL device for double
Extends analyzer_cli_test.py test to cover SYCL
Fixes Transpose Op for double when on SYCL
Bumps Eigen version to fix double precision issue on SYCL
Extends SessionDebugTestBase to cover SYCL
Bumps Eigen Version
Refactors Ops registration
Introduces workaround for Const Op related to the difference between
CUDA which uses pointers and OpenCL that uses buffers/accessors
Extends memory types to cover DEVICE_SYCL as well
Introduces  GetSYCLDevice() method that returns list of supported devices
with GPU device having the highest priority ( doesn't include blacklisted devices )
::internal::Transpose -> tensorflow::internal::Transpose in order to
avoid compilation reported error
Adds sycl_runtime to bazels ARRAY_DEPS
Replicates TF_CALL_GPU_PROXY_TYPES for SYCL
Fixes an issue caused by switch to aligned allocator for sycl buffer (#53)
Fix testSimple and testConst in stack_op_test (#3)
RandomGamma has no GPU friendly implementation (#57)
Register batch normalization kernels for OpenCL (#61)
Compatibility fixes for TensorFlow 1.1.0-rc1
Fixes Scatter Op
Implements BatchMatmul Op for SYCL
Lowercase the device name when GPU or SYCL returned
kernel_estimator_test.py assertEqual-> assertAlmostEqual due to floating point
representation on the device

Can one of the admins verify this patch?

@ville-k, @Zakor94 can you confirm?

Sometimes googlebot gets confused, could you git pull --rebase and push again?

@lukeiwanski @googlebot  ok with me.

@lukeiwanski @googlebot yes ok with me too.

@tensorflow-jenkins test this please

@tensorflow-jenkins test this please

@tensorflow-jenkins test this please

@tensorflow-jenkins test this please

Jenkins, test this please.

Jenins, test this please.

@lukeiwanski these massive PRs are hard to review since there is a stream of new commits being added, and the PR is already very large.
We typically try to stage these changes in small PRs that are more easily reviewable -- can you break this change into smaller requests in some way?  As it is, I don't see anybody being able to safely review a change of this magnitude (117 files!)

@vrv Ok I will try. What is desired changeset size?

Benoit would have a better idea of what he'd like, but it's much easier to review a change that has like, <10 files, < 200-300 LoC change at a time; that we he can review it, it will have fewer things to change, and we can make more iterative progress.
Might be worth you and Benoit talking offline to see what's going to work well!
(I'm just on sync rotation this week and trying to help move things along :)

Appriciate and thanks @vrv !
My plan for this PR is to revert refactoring changes ( that should knock off 77 files ) and re-introduce them in a new one ( or series ) - I will check with @benoitsteiner on how to proceed.

@vrv Is current size of the pull requst acceptable or should I keep spliting it?

Can one of the admins verify this patch?

@benoitsteiner could you please take another look?

@tensorflow-jenkins test this please

The MacOs CPU Tests seems to be failing due to a missing dependency in gif_archive..
ERROR: /private/var/tmp/_bazel_jenkins/13e370a18c169b19baeafefb05212b85/external/gif_archive/BUILD.bazel:8:1: undeclared inclusion(s) in rule '@gif_archive//:gif':
this rule is missing dependency declarations for the following files included by 'external/gif_archive/lib/openbsd-reallocarray.c':
Is that caused by our changeset or is it present in the upstream? I cannot see how we could cause it.

@lukeiwanski no, the build error on MacOS is unrelated to your changes.

Jenkins, test this please.

Jenkins, test this please.


repeated calculation problem

I've found that you are using sigmoid_prime function in network.py and network2.py to calculate backpropagation. But it is not necessary.
You had calculated activation list in feedforward pass. sigmoid_prime is the derivative of sigmoid function, which is equal to activation * (1 - activation) .
You have no need to repeated calculate this sigmoid derivative function, which is really what old-backpropa paper suggest, just one feedforward pass, and a backward pass.

Closing as this library is just a ported update of neural netwotks Python code


[YouTube] Fix not finding videos listed under a channel's "shorts" subpage.

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] Searched the bugtracker for similar pull requests
[x] Read adding new extractor tutorial
[x] Read youtube-dl coding conventions and adjusted the code to meet them
[x] Covered the code with tests (note that PRs without tests will be REJECTED)
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Bug fix
[x] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Fixed a bug related to youtube-dl not being able to find and download videos listed under a channel's "shorts" subpage with help and guidance from @dirkf. Also tried to improve upon the solution by having the playlist data allow a title to be proposed in the list of playlist items. When running youtube-dl with the --flat-playlist and --dump-json option, the returned JSON data now has the title for each video.

Thanks for your work!
I'll fix a couple of spacing nits and then we can see how the tests look.

Ok sounds good! Thanks again for your help as well. Let me know if I need to add more tests or add additional changes.


NPM mediapipe library usage not clear in documentation, total built size huge

Description of issue (what needs changing)
It's awesome we have an npm package, but using the package distributed by npm is not straight forward, since the same npm readme docs say to download wasm files from cdn.
Clear description
The final built package size of mediapipe/tasks-vision from npm is 860kB because of wasm, but the documentation recommends importing from a cdn, but we still need the types from the package. The end result becomes of having the wasm file in the bundle size but downloading them from the CDN.
Correct links
No response
Parameters defined
No response
Returns defined
No response
Raises listed and defined
No response
Usage example
No response
Request visuals, if applicable
No response
Submit a pull request?
No response

Hello @schmidt-sebastian,
Could you please help out here. Thank you!

Our JS library consists of a couple of files. The 3 important ones are:

The Library JS file (e.g. vision_bundle.js)
The Wasm Loader script (e.g. vision_wasm_internal.js)
The Wasm code (e.g. vision_wasm_internal.wasm)

Only the library file needs to be included in your script. While the file size is over 800 kB, the code is modular and your should be able to tree-shake the build fairly substantially. On our end, we can minify the sources, which should reduce the size further, but that requires a new release.

Making this a feature request.

It would be awesome though to have a documentation on npm on how to use all 3 (js, loader & wasm) from npm, without using external cdn.
Inlcuding wasm files and not specifically describing how to properly use the library it's a bit weird.
Did I miss something?
Thanks again for your work, keep it up!

Hi @schmidt-sebastian I might have the same question as Perez here.
I'm building an application that will live locally, on a PC without connection to the internet. Where can i download the WASM file that I'm loading in the visionTasks? ("https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>thanks in advance

Thanks @schmidt-sebastian found it :)

@vettorazi,
Could you please let us know if we can change the status to close if now no longer issue from your end. Thank you

We still need to address the build size issue (hence it is marked as a feature request)

This will be fixed in our next release, which should go out this week. The vision library is 160 kB with this build.


[fix](inverted index) reset fs_writer to nullptr before throw exception

… exception
Proposed changes
If the writer is not set to nullptr, the close method will be called again when the FSIndexOutput object is destructed after an exception is thrown, resulting in an unintended behavior.

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall


to_sql double quoting in create index

I have table names that include _,  . and -, up until Pandas .14 I used to quote the table name like this:
    def quote_identifier(s, errors="ignore"):
        encodable = s.encode("utf-8", errors).decode("utf-8")

        nul_index = encodable.find("\x00")

        if nul_index >= 0:
            error = UnicodeEncodeError("NUL-terminated utf-8", encodable,
                                       nul_index, nul_index + 1, "NUL not allowed")
            error_handler = codecs.lookup_error(errors)
            replacement, _ = error_handler(error)
            encodable = encodable.replace("\x00", replacement)

        return "\"" + encodable.replace('"', '""') + "\""

then call:
    pd_sql.to_sql(group, quote_identifier(name), con, if_exists='replace')

But since 0.15 if I do not quote CREATE TABLE (or DROP TABLE) will give me an error:
    OperationalError: near "-": syntax error

And if I do quote CREATE INDEX will give me an error:
    OperationalError: near ""_b.m_test_01-30"": syntax error

The problem is that in CREATE INDEX ix_{tbl}_{cnames} ON {tbl} ({cnames_br}) CREATE INDEX thinks it is the only one trying to prepend a namespace with _ and thus does not check if {tbl} is already quoted.
The proper fix should do what quote_identifier does with " and escape them, or just use quote_identifier and then prepend ix_.
This is the query that it tries and gives error:
CREATE INDEX ix_"_b.m_test_01-30"_index ON "_b.m_test_01-30" ([index])

Here is the patch I am now using in my monkey patch and works fine:
    if len(ix_cols):
        cnames = "_".join(ix_cols)
        cnames_br = ",".join([br_l + c + br_r for c in ix_cols])
        idx_name = quote_identifier("ix_{tbl}_{cnames}".format(
            tbl=self.name, cnames=cnames
        ))
        create_stmts.append(
            "CREATE INDEX {idx_name} ON {tbl} ({cnames_br})".format(
            idx_name=idx_name, tbl=self.name, cnames_br=cnames_br))

I will be glad to submit proper PR, but wanted to know if you think it might make even more sense to apply the quote automatically so that one does not have to quote table name beforehand and call to_sql?

This does indeed looks like a bug.
But, for the record:

Can you test this with master? (there has already been some reworking of this part of the code, eg the CREATE INDEX ix_{tbl}_{cnames} ON {tbl} ({cnames_br}) is no longer in the code, see https://github.com/pydata/pandas/blob/master/pandas/io/sql.py#L1384)
What database did you use? (sqlite?)
Can you also test if you encounter the same problem or not with an sqlalchemy engine?

cc @artemyk

This is sqlite3.
I tried the master branch '0.15.2-146-gef48c6f' and I do not even need quote_identifier anymore!
However if I do use quote_identifier then the quotations themselves will end up used in table name, which is a little weird to have a table that its name starts with ".
However I think this issue is resolved, I cannot wait to get this in the release, thanks!
This is a simple test case btw:
    import pandas as pd
    import sqlite3 as db
    from pandas.io import sql as pd_sql

    dbname='/home/dashesy/test.sqlite'
    con=db.connect(dbname)
    df = pd.DataFrame(np.ones(3))
    pd_sql.to_sql(df, '_b.m_go_test_01-30', con, if_exists='replace')

    pd_sql.to_sql(df, quote_identifier('_b.m2_go_test_01-30'), con, if_exists='replace')

@dashesy Thanks for testing!
We can add your test case (or if you want to do that in a PR, certainly welcome!)

For PR id not find something related so added a new module, first PR here please let me know if I need to revise for coding style or anything.
I think the docs should also mention that there is no need to quote the table name if there are special characters in it.

@dashesy I pointed you to the correct place for sql tests
About the docs, you can certainly add somewhere a note that table names do not have to be quoted

@jorisvandenbossche did you mean to close this? (as the PR is still open/not merged)

ah no, that button ..

I think this one is the right place, I get many errors on AttributeError: '_TestSQLApi' object has no attribute 'connect' is there anyway to silence nose about the base class? I also added a line to the docs, again let me know if that was the right place.

Great to hear that #8986 fixed this pre-emptively ;-)  Yes, you can have table names with quotes since those appear to be legal identifier names in sqlite.


Added Microsoft Edge Beta version 87.0.664.18.

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

Microsoft Reviewers: Open in CodeFlow

/AzurePipelines run


Add commands to move to speakers

Add two new features to the robot based on the Vision subsystem implemented in #1. Both of these features rely on the built in ability of PhotonVision to track an estimated pose of the robot based on what April tags it can see on the field. It does this with a combination of motor encoders and the tags that are visible, so for this to be accurate we'll have to make sure the webcam and encoders are sending solid data. The added features in this PR are:

Add a "Go to speaker" command on the driver controller. This  command gets the current alliance from the driver station and uses it to determine which speaker to score at. While the command button is held the robot will move to a predetermined pose in front of the speaker so it can make a shot.
Update the aimAtTarget command to align the robot with the speaker based on which alliance the team is a part of.

Some things to verify from this PR when things are on the bot:

[ ] Set up April tags on the test Speaker and Amp to verify the positioning can work off of just a few tags
[ ] Make 100% sure the camera is calibrated correctly
[ ] Make sure the speaker/alliance connections are correct (ie are we going to the correct speaker when we push the button?)
[ ] Find the optimal location to shoot in the speaker and update the Pose in the code
[ ] Add Poses and aiming commands for the amps

Add two new features to the robot based on the Vision subsystem implemented in #1. Both of these features rely on the built in ability of PhotonVision to track an estimated pose of the robot based on what April tags it can see on the field. It does this with a combination of motor encoders and the tags that are visible, so for this to be accurate we'll have to make sure the webcam and encoders are sending solid data. The added features in this PR are:

Add a "Go to speaker" command on the driver controller. This  command gets the current alliance from the driver station and uses it to determine which speaker to score at. While the command button is held the robot will move to a predetermined pose in front of the speaker so it can make a shot.
Update the aimAtTarget command to align the robot with the speaker based on which alliance the team is a part of.

Some things to verify from this PR when things are on the bot:

[ ]  Set up April tags on the test Speaker and Amp to verify the positioning can work off of just a few tags
[ ]  Make 100% sure the camera is calibrated correctly
[ ]  Make sure the speaker/alliance connections are correct (ie are we going to the correct speaker when we push the button?)
[ ]  Find the optimal location to shoot in the speaker and update the Pose in the code
[ ]  Add Poses and aiming commands for the amps
I was testing out this code in the sim and what I found is it only wants to go to the blue speaker

I think that's a bug with the simulator. It's supposed to dynamically choose the team based on the driver station, but there's no way to pass the team color to the simulation (from what I could find anyway) without a real driver station hooked up.
I've been manually testing by setting the if statement that determines which constants to use to true or false.


Make AlpacaToMessage public.

Context
What is the purpose of this PR? Is it to

[ ] add a new feature
[X] fix a bug
[X] update tests and/or documentation
[ ] other (please add here)

Please link to any issues this PR addresses.
Changelog
What are the changes made in this PR?

Make AlpacaToMessage public.
#1769

Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.

[X] run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
[ ] add unit tests for any new functionality
[ ] update docstrings for any new or updated methods or classes
[ ] run unit tests via pytest tests
[ ] run recipe tests via pytest tests -m integration_test
[ ] manually run any new or modified recipes with sufficient proof of correctness
[ ] include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example

[ ] I did not change any public API
[X] I have added an example to docs or docstrings

Really minor fix. This code is now working:
from torchtune.datasets import AlpacaToMessages

message_transform = AlpacaToMessages(
    train_on_input=True, column_map=None
)

@joecummings @RdoubleA Require review.

Oh, some strange problem with docs, let me fix

I see, should have added in data/__init__.py

@joecummings I found out the problem. AlpacaToMessages should be moved to torchtune.data by analogy to other Transforms, it should no be included in datasets if it is public(I don't know how it happened that is is not with other transforms but in alpaca_dataset).

New example, if changing API:
from torchtune.data._messages import AlpacaToMessages

message_transform = AlpacaToMessages(
    train_on_input=True, column_map=None
)

We probably can don't care about legacy, because previously it was internal.

@krammnic @joecummings thanks for pointing this out. Let's move AlpacaToMessages to torchtune/data/_messages.py where the other message transforms live.

@joecummings  @RdoubleA You can check new changes

Docs look good. just need to fix lint by running: pre-commit run --all-files

Docs look good. just need to fix lint by running: pre-commit run --all-files

Runned it and pushed. I hope now is fine.

Probably can be merged, lint checks passed.


[ztracy] Upgrade to tracy 0.11.0

Next one 😄

strange... I see __cpuidex => intrin.h in zig  but compile failed.

strange... I see __cpuidex => intrin.h in zig but compile failed.

Ohh its fixed in master https://github.com/wolfpld/tracy/pull/836

fixed


[POAE7-2756] replace boost codes by using stl

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Which label does this PR belong to?

what's benefit of such replacement？

what's benefit of such replacement？

enable c++20 and gcc10.3 to compile.
because bdtk use boost 1.71, this version could not compile under c++20 and gcc10.3

Will there be updated documentation to tell people how to upgrade the version in the development environment to adapt to this change?


Custom class per supstance

Hi,
How can I add a custom class for a substance? I would like to have supstances on the same side with different colors. The substance takes a value, start and end, but I would like to add a class to that as well so I can change the color in the CSS.
Is there a way to do that already, or does that require a library change?
Thanks!!

NVM, found a way to do it :)
svg.selectAll("g.supstances")
  .datum(supstanceData)
  .call(supstance)
  .call((a) => a.selectAll(".scope-supstance").attr("class", (d) => ".scope-supstance " + d.color));


plugin provides message

Initializing Civitai Link
If submitting an issue on github, please provide the below text for debugging purposes:
Python revision: 3.10.8 (tags/v3.10.8:aaaf517, Oct 11 2022, 16:50:30) [MSC v.1933 64 bit (AMD64)]
Civitai Link revision: 579d6940168230daf0d32a1c936c0dd0ba27b433
SD-WebUI revision: 66cfd1dcfc893a9051310c208a66890b86334118
Checking Civitai Link requirements...
[!] python-socketio[client] version 5.7.2 NOT installed.

Where exactly do I execute the above?
In the extension folder or in the main web-ui folder?

Where exactly do I execute the above? In the extension folder or in the main web-ui folder?

execute it before you running webui, it should be install to your compute, no matter what folder you chosed.


Add new terms for microscope models

name: Zeiss Axio Observer Z1
def: "Inverted fluorescence microscope"
https://www.zeiss.com/microscopy/en/products/light-microscopes/widefield-microscopes/axio-observer-for-life-science-research.html
is_a:  CHMO:0001095 [fluorescence microscope]
Ursula Eberhardt | ORCID: 0000-0003-1221-7074
name: Zeiss Imager M1
def: "Upright fluorescence microscope"
https://microscopy.ucsf.edu/instruments/zeiss-axioimager-m1, https://profcontrol.de/Zeiss-Axio-Imager-M1m-Fluorescence-DIC-Microscope-Fluoreszenz-Mikroskop
is_a: CHMO:0001095 [fluorescence microscope]
Ursula Eberhardt | ORCID: 0000-0003-1221-7074

Currently, the parent term for all microscope models is OBI:0400169 (microscope) as this is what Swate templates (for example, see 3ASY05_Imaging) use as the heading for that particular information. I would therefore like to adhere to this instead of using the CHMO term. Please let me know if this is okay with you.

fine with me. Thanks for your help.


Add font fallback or warning

If you run yofi and do not have the default font installed it does this

After changing font in config with font = "/usr/share/fonts/noto/NotoSansDisplay-Thin.ttf"

This is probably completely unrelated but I'm running NVIDIA proprietary driver and that's only just now started working on other compositors that are not GNOME or KDE

If default font (DejaVu Sans Mono) is not installed/found then yofi will panic with the corresponding message. The issue seems rendering related (perhaps related #46 & #82). Do you use pre-built 0.1.5 version or another one?

How about using the system-ui family name as a fallback font?
It's a special family name that maps to the font configured for system ui elements (usually Cantarell by default).
Out of the box with no config I get this very unusual choice of a font:

What's the system-ui you are talking about? Tried both fontconfig and rust-fontconfig and the family name isn't found. I'm thinking about either providing a hardcoded list of well-known fonts, or simply embedding one into the final binary.

What's the system-ui you are talking about?

It's a family name. It resolves to whatever font is configured for system ui elements on the local setup. It's kinda like monospace, which is not an actual font, but actually resolves to the default monospace font on the system.
My bad though there's no dash in it, it's actually system ui:
$ fc-match "monospace"
FantasqueSansMono-Regular.otf: "Fantasque Sans Mono" "Regular"

$ fc-match "system-ui"  # Wrong name, just a fallback
OpenSans-Regular.ttf: "Open Sans" "Regular"

$ fc-match "system ui"  # Actual system ui font
Cantarell-VF.otf: "Cantarell" "Regular"

It's a pretty safe fallback because rather than providing a font and expecting the user to have that installed, it picks something that's locally installed.

This one unfortunately doesn't work for rust-fontconfig, you may try it with smth like this:
fn main() {
    use rust_fontconfig::*;
    let path = FcFontCache::build().query(&FcPattern {
        familiy: Some("monospace".into()),
        ..Default::default()
    }).unwrap();
    dbg!(path);
}

or either via yofi:
diff --git a/src/font/fdue.rs b/src/font/fdue.rs
index 3b19c35..86f1853 100644
--- a/src/font/fdue.rs
+++ b/src/font/fdue.rs
@@ -96,7 +96,10 @@ impl Font {
 impl FontBackend for Font {
     fn default() -> Self {
         FONTCONFIG_CACHE
-            .query(&FcPattern::default())
+            .query(&FcPattern {
+                family: Some("system ui".into()),
+                ..Default::default()
+            })
             .map(Font::from_fc_path)
             .unwrap()
             .unwrap()

I had the same issue (AUR yofi-bin package). Now that I've read that rust-fontconfig got dropped, it would be great if this could be addressed again.
Also thanks for your efforts, l4l!


Add valheim-docker

Application you'd like to add:
Valheim-docker, which is a self-hosted multiplayer server for the popular video game Valheim. This is similar to the Minecraft server that's already available.
Link to Docker image:
https://hub.docker.com/r/mbround18/valheim
Why you'd like this application added:
I'll be setting up another server using this Docker image soon and figured that it'd make sense to have the config in this project if others would like it. This was fairly easy to get running when I last used it ~1 year or so ago, it only required a few directories to exist to place game save files and backups + a docker-compose file to keep things tidy.

Looks pretty cool, would be happy to accept a PR!


Issues with the reading and writing on the SQL database

One (quick) solution is to create different databases for raw data and model / forecast data. Another solution (and better) is to migrate the data for a completely different database (RethinkDB? PostgreSQL?).

Done. The issue was caused by starting many Python jobs at the same time (100+).


Redesign

Redesign.zip
Figma
Inspired by SoundBoardX from @xtonousou

OMG SOUNDBOARD APP DESCRIPTION.docx

I plan to release the soundboard on F-Droid and Google Play with just a few tunes. There should be a way for users to add own tunes or import them from a different source.


Make EXAMPLES and RETURN VALUES in consistent order

This is based on #8304 and I also added a new option in util/find-doc-nits to help find out the inconsistent order in the document POD files.

Checklist

[x] documentation is added or updated

Dont' make the -r flag optional; do strict enforcement.

Dont' make the -r flag optional; do strict enforcement.

Which is better: Enforced with the -n flag of util/find-doc-nits or enforced when doing make doc-nits?

Which is better: Enforced with the -n flag of util/find-doc-nits or enforced when doing make doc-nits?

I would prefer the former, i.e., include the check in the -n option.

If it makes sense to make this a part of -n (which I think is fine!), then I think it's a bit silly to have a separate option for the order check as well.  Just drop -o and call this particular check from check

All have been fixed by the latest commit.

Pushed to master (4564e77ae9 and cc838ee2d6), thanks!


Fix site/sitearea/company filters

Remove include external sites auth filter and OR definition
Create 2 dynamic auth filters to handle external elements
Update charging station auth filters
Update site, sitearea, company auth definition
Update OCPI auth check

@LucasBrazi06 as discussed please have a look at this PR.
The filters now work as expected, and charging stations / connector seem to also work like before (no regression)
Will tacle the OwnUser issue using this branch as a reference.
PS: this modification doubles the number of requests to the DB, don't know if we can cache some auth queries to reduce number of requests ?


Suppress RUSTSEC-2023-0044 audit failure until SPL upgrades to Solana v1.16.2 or greater

…

Merging to unblock CI for everyone


Non-updated docs

The version displayed in the docs (0.1.dev1+gbb87bc5) is not the current one of ctapipe:

and also I think that the Getting Started For Developers still recommends a development based on forking the repo, while I understand that, since we cannot use travis anymore, if we want to perform tests using github ci we need to do PRs to branches of the repo, instead of the fork. Since people are usually pointed to these instructions when they get started in any cta-observatory package, do you think it would be a good idea to change them?

Wow, that's an old version of the docs... I guess this is a bug in our new GitHub Actions CI pipeline.

if we want to perform tests using github ci we need to do PRs to branches of the repo, instead of the fork

I'm still using a fork, and it works fine.

branching or forking shouldn't depend on the CI itself, but rather on operations that require to pass from the official repository, such as downloading protected test data

I do notice that in the docs builds, there does not seem to be any restictions on when they are deployed - in the previous CI build with Travis, we only deployed docs to GitHub-Pages if this was the master branch, and otherwise the deploy part was skipped.  @maxnoe Is there a way to do that with github actions?  I suspect now they are being overwritten by PR  CI pipelines

Weird.
I have the same in protopipe and it worked as expected, at least after recent PRs.

@rlopezcoto The reason forks don't work for lstchain or ctapipe_io_lst anymore is the reliance on password protected test data which needs the secrets that are only availlable in the main repo. ctapipe does not use password protected test data.

@rlopezcoto The reason forks don't work for lstchain or ctapipe_io_lst anymore is the reliance on password protected test data which needs the secrets that are only availlable in the main repo. ctapipe does not use password protected test data.
Another way to solve this would be instead of using secrets would be to use a custom runner for the CI that has the data, which would also work for pull requests from forks. But someone would need to provide a server where that can run.

Ah ok, thanks, that got me confused. In any case, it is a pity that we cannot point people to the "Getting started For Developers" ctapipe link to people that have password protected test data (there may be several, at least for those developing plugins)

@rlopezcoto We should update the docs to state that for regular contributors, we don't recommend forking. At least that is my preferred solution.

@maxnoe that sounds good, it would be nice to include this recommendation in the docs if @kosack agrees

Maybe we are missing a "git pull --tags" somewhere?

It's there and they are pulled, I am confused where that version is coming from:
https://github.com/cta-observatory/ctapipe/blob/bb87bc5019d272241c3392ebe1586268450b8574/.github/workflows/ci.yml#L56

I do notice that in the docs builds, there does not seem to be any restictions on when they are deployed

There is, the deployment is done only on master:
https://github.com/cta-observatory/ctapipe/blob/bb87bc5019d272241c3392ebe1586268450b8574/.github/workflows/ci.yml#L66-L68
You can also see it being skipped here in a PR:
https://github.com/cta-observatory/ctapipe/pull/1614/checks?check_run_id=1929875109
And run on the master here:
https://github.com/cta-observatory/ctapipe/runs/1919537990?check_suite_focus=true
So besides the wrong version, everything works as expected I'd say.

@kosack Interestingly, the git commit hash is correct. bb87bc5 is the current master commit.

From what I can see there is nothing wrong with the documentation building or deploying, what is wrong is the version number read by the configuration file of the documentation.
I still have to understand how the versioning works now in ctapipe (I wanted to do the same for protopipe, but it appears that it's best for me to see what's the problem  :P).
My point of view:
In docs/conf.py we do,
version = ctapipe.__version__
# The full version, including alpha/beta/rc tags.
release = version

which is read from ctapipe/version.py where, as far as I can see, in this case the version is taken from the section,
try:
    try:
        from ._dev_version import version
    except ImportError:
        from ._version import version

Side comment: have you checked for warnings in the compilation of the docs? If yes, perhaps one of these is the one that changes between the try and the first except (I am excluding the second one since the displayed version is not 0.0.0).
(This is why I prefer to use readthedocs, with which I can stop the build if there is any warning, even the most stupid)

The version works correctly in a local test.

Version fixed in #1628


Code editor becomes unresponsive after updating some extension. Reload works after trying to close window. Then dialog becomes visible.

VSCode Version: Code 1.8.1 (ee428b0eead68bf0fb99ab5fdc4439be227b6281, 2016-12-19T14:49:23.350Z)
OS Version: Windows_NT ia32 6.1.7601
Extensions:

Extension
Author
Version

html-snippets
abusaidm
0.0.18

django-html
bibhasdn
1.2.0

githistory
donjayamanne
0.1.4

jquerysnippets
donjayamanne
0.0.1

python
donjayamanne
0.5.5

xml
DotJoshJohnson
1.6.1

EditorConfig
EditorConfig
0.3.4

vscode-npm-script
eg2
0.1.5

CppSnippets
hars
0.0.5

format-indent
Kasik96
1.3.0

vscode-JS-CSS-HTML-formatter
lonefy
0.2.2

cpptools
ms-vscode
0.9.3

csharp
ms-vscode
1.6.2

debugger-for-chrome
msjsdiag
2.4.1

sass-indented
robinbentley
1.3.0

Angular2
UVBrain
0.3.5

cordova-tools
vsmobile
1.2.4

JavaScriptSnippets
xabikos
1.2.0

ReactSnippets
xabikos
1.2.0

Steps to Reproduce:

Code shows that some extension has an upgrade pending. Press Upgrade button
Once this is done, Code shows Reload button next to the upgraded extension.
Press Reload button -> nothing happens.
Click x-button to close Code from the top right corner (maybe restarting it also reloads the extension)
-> now the extension's reload "are you sure?" dialog becomes visible and I can reload the extension. No need to restart whole program.
So is the dialog behind some other windows or why wasn't it shown first?

Do you mind recording a screencast?


Else statement is not covered with unit tests

In file
AEM-Rules-for-SonarQube/src/main/java/com/cognifide/aemrules/checks/resourceresolver/close/FindRRDeclarationVisitor.java
133-135 lines are not covered with unit tests. Please add new testing case or remove this statement if not needed.
Quick Link

Hi @SylvesterAbreu ,
unfortunately it is still valid, however the lines have changed. Please take a look at following report:
https://coveralls.io/builds/10409903/source?filename=src%2Fmain%2Fjava%2Fcom%2Fcognifide%2Faemrules%2Fchecks%2Fresourceresolver%2Fclose%2FFindRRDeclarationVisitor.java
Br,
Michał

Fixed!


Since version 1.6.0 - Angular Material Datepicker is blank until scrolled

Angular Material Datepicker is blank until you scroll
https://puu.sh/sNbCk/616eae9a00.png

You should report this to https://github.com/angular/material as the fix must probably go into their library. Don't forget to include a demo, too.

Will do.  I created this:
https://plnkr.co/edit/phZR6W?p=preview https://plnkr.co/edit/phZR6W?p=preview
I’ll post it on the material page.
Thanks
Steve

On Dec 12, 2016, at 8:06 PM, Martin Staffa<EMAIL_ADDRESS>wrote:
You should report this to https://github.com/angular/material https://github.com/angular/material as the fix must probably go into their library. Don't forget to include a demo, too.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/angular/angular.js/issues/15499#issuecomment-266537429, or mute the thread https://github.com/notifications/unsubscribe-auth/AEs76qkbO0_ssbTUExCG6Zr19-fB4d4Mks5rHakzgaJpZM4LK7sy.


[Swift] Add support for attribute((objc_class_stub))

A class annotated with this attribute requires the compiler to emit
a call to objc_loadClassRef() when the class is referenced.
Categories are not affected.
rdar://45647064

The corresponding Swift change is https://github.com/apple/swift/pull/23320


New smart legend & co

Rewrite Reference, footnote, Abbr, comment, fenced & figure/legend
Fix #95
Fix #60
Fix #66
Fix #67
Fix #57
Fix #34

Coverage increased (+0.3%) to 94.184% when pulling f814f95f39d02cffe382c7493fdd6318acbc4c02 on new_smart_legend into 97965b090d9da07523c903296b308815168f2e72 on master-zds.

Coverage increased (+0.2%) to 94.096% when pulling 3652b44cc149bde090d4b048986625aacd45a2b0 on new_smart_legend into 97965b090d9da07523c903296b308815168f2e72 on master-zds.


Question: presenters

@petrspelos
How should we handle presenters in our application?
See #11 for more details please

@petrspelos

Default implementation isn't needed, we can use mocks in our tests. ☺

@TomasNiemczyk98 please update your latest PR based on this.


chore: Bump github.com/awslabs/operatorpkg to latest

Fixes #N/A
Description
Bump github.com/awslabs/operatorpkg to latest to fix failures on not having unique controller names
How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

0 of 0   changed or added relevant lines in 0 files are covered.
11 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.1%) to 80.666%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/disruption/consolidation.go
4
87.25%

pkg/controllers/provisioning/scheduling/preferences.go
7
86.67%

Totals

Change from base Build<PHONE_NUMBER>1:
-0.1%

Covered Lines:
8382

Relevant Lines:
10391

💛  - Coveralls


trying to build but having issues

[ Subject of the issue ]
Description
trying to build polygon and it appears it wont let me say the below issue and fails.
git clone https://github.com/0xPolygon/polygon-edge.git
cd polygon-edge/
go build -o polygon-edge .

github.com/quic-go/quic-go/internal/qtls
/root/go/pkg/mod/github.com/quic-go/quic-go@v0.33.0/internal/qtls/go121.go:5:13: cannot use "The version of quic-go you're using can't be built on Go 1.21 yet. For more details, please see https://github.com/quic-go/quic-go/wiki/quic-go-and-Go-versions." (untyped string constant "The version of quic-go you're using can't be built on Go 1.21 yet. F...) as int value in variable declaration
Your environment

OS and version. - Ubuntu 20.04
The version of the Polygon Edge.
(Confirm the version of your Polygon edge client by running the following command: polygon-edge version --grpc-address GRPC_ADDRESS)
The branch that causes this issue.
Locally or Cloud hosted (which provider).
Please confirm if the validators are running under containerized environment (K8s, Docker, etc.).

Steps to reproduce

Tell us how to reproduce this issue.
Where the issue is, if you know.
Which commands triggered the issue, if any.
Provide us with the content of your genesis file.
Provide us with commands that you used to start your validators.
Provide us with the peer list of each of your validators by running the following command: polygon-edge peers list --grpc-address GRPC_ADDRESS.
Is the chain producing blocks and serving customers atm?

Expected behavior

Tell us what should happen.
Tell us what happened instead.

Logs
Provide us with debug logs from all of your validators by setting logging to debug output with: server --log-level debug
Proposed solution
If you have an idea on how to fix this issue, please write it down here, so we can begin discussing it

go.uber.org/multierr
Error: ../../../go/pkg/mod/go.uber.org/multierr@v1.11.0/error.go:209:20: undefined: atomic.Bool
note: module requires Go 1.19
github.com/libp2p/go-libp2p/p2p/host/eventbus
Error: ../../../go/pkg/mod/github.com/libp2p/go-libp2p@v0.27.8/p2p/host/eventbus/basic.go:30:23: undefined: atomic.Bool
Error: ../../../go/pkg/mod/github.com/libp2p/go-libp2p@v0.27.8/p2p/host/eventbus/basic.go:322:23: undefined: atomic.Int32
Error: ../../../go/pkg/mod/github.com/libp2p/go-libp2p@v0.27.8/p2p/host/eventbus/basic.go:375:19: undefined: atomic.Int32
Error: ../../../go/pkg/mod/github.com/libp2p/go-libp2p@v0.27.8/p2p/host/eventbus/opts.go:15:19: undefined: atomic.Int64
note: module requires Go 1.19
github.com/quic-go/quic-go/internal/qtls
Error: ../../../go/pkg/mod/github.com/quic-go/quic-go@v0.33.0/internal/qtls/go_oldversion.go:5:13: cannot use "The version of quic-go you're using can't be built using outdated Go versions. For more details, please see https://github.com/quic-go/quic-go/wiki/quic-go-and-Go-versions." (untyped string constant "The version of quic-go you're using can't be built using outdated Go...) as int value in variable declaration
note: module requires Go 1.19
make: *** [Makefile:49: test-e2e] Error 2
Error: Process completed with exit code 2.

@Stefan-Ethernal
getting this issue now
/network
network/server.go:470:9: cannot use s.host.Peerstore().GetProtocols(peerID) (value of type []"github.com/libp2p/go-libp2p/core/protocol".ID) as []string value in return statement

Probably you don't have the latest go dependencies. Please try to run go mod tidy and see if is it any better.

Just FYI @SECRYPT-2022, you can also run a local network using Docker. Try make docker-run command.

Is it any better now @SECRYPT-2022? Also consider @begmaroman's comment, if you want to spin up locally running cluster.

I don't know how to use the make docker  run.
I'm quite new to all this.
I have my testnet running ok now.
Its just the mainnet the wallet address appears to be the same as block count.

In order to execute the make run-docker command, you would first need to install docker engine. Procedure is described here.
It allows you to spin up a local test net containing 4 Supernets nodes and 1 rootchain node (Geth client).

i have fixed this issue.


Race condition results in error "Some of your tests did a full page reload!"

Expected behaviour
When running Karma with singleRun = false and autoWatch = false I would expect to be able to schedule a new run as soon as the 'old' run is completed.
Actual behaviour
A race condition in clearContext can report a false error in the new run.
Environment Details

Karma version (output of karma --version): 4.4.1
Relevant part of your karma.config.js file

{
  singleRun: false,
  autoWatch: false
}

Steps to reproduce the behaviour
It is difficult to reproduce since it is a race condition. Essentially it can happen in this scenario:
const karam = require('karma');
const server = new karma.Server({ singleRun: false, watch: false });
await server.start();
function runUntilError() {
  karma.runner.run({}, exitCode => {
    if(exitCode === 0) {
       runUntilError();
    } else {
       console.log('Aha! Run errored');
    }
  });
}
runUntilError()

Triage
The problem is in the complete handler. Results are reported to the server before the context is cleared:
https://github.com/karma-runner/karma/blob/6235e68bbf5a21b6723b652b3e9e09d627c2fad0/client/karma.js#L230-L242
The clearContext function sets the reloadingContext flag and navigates away.
https://github.com/karma-runner/karma/blob/6235e68bbf5a21b6723b652b3e9e09d627c2fad0/client/karma.js#L148-L152
Now, just before the browser navigates away, the reloadingContext is reset by the next execution:
https://github.com/karma-runner/karma/blob/6235e68bbf5a21b6723b652b3e9e09d627c2fad0/client/karma.js#L266
The concequence of this, is that the error is reported here:
https://github.com/karma-runner/karma/blob/6235e68bbf5a21b6723b652b3e9e09d627c2fad0/client/karma.js#L132

Some of your tests did a full page reload!

However, I didn't reload any page.
Workaround
If you set client.clearContext to false, the context will not be cleared and there is no risk of this race condition.

Ok if I understand your analysis, our scenarios are
PASS:

execute test
emit result
clearContext on next event loop
clearContext sets reloadingContext =true
reload on next event loop
onbeforeunload checks reloadingContext
success!

FAIL

execute test
emit result
clearContext on next event loop
clearContext sets reloadingContext =true
reload on next event loop
execute test sets reloadingContext = false
onbeforeunload checks reloadingContext
fail

Just reporting that I'm still encountering this issue on Karma 5.2.2
However, setting clearContext to false resolves the issue for me.

We started experiencing Some of your tests did a full page reload! error message after upgrading karma 5.1.1 => 5.2.0. First test run is OK but it starts failing since the second run. By default we have clearContext set to false. The problem goes away when setting clearContext to true. Could it be related to this issue?

+1

Please open a new bug with steps to reproduce. This issue is related to a race in the code and steps to reproduce are essential.


Unasync semaphore

The @semaphore decorator can be given the <thread> argument which locks a function out for one thread (once called). When the thread dies, others will unblock and resume execution (out of a sleep loop).
This is handy for uncoordinated blocks where code must be run in a batch but might be called more than once. Say, for example, calling git command line work in an async thread. Using this, such a function can't be called again until the first finishes.

There's a TODO in line 494 where it checks if the call_id < min(call_queue), which implies the thread id was recycled. I haven't tested it yet though as that would require looping the thread IDs... which could take a long while (or almost never, depending on the size - skimming the docs, it seems vague on how they loop).


X-Axis tickformat question

Hi, there,
I want to format the x-axis tick (tickFormat). although I can do that, however, the issue is that the default ticks in the x-axis won't change. the default ticks is the ones controlled by n3-charts automatically. for example, there are 10 thousands ticks in x-axis, by default, n3-charts only display very small part of those ticks along the x-axis. my question is that how to change those ticks' format.
Thanks!
Sam

never mind, false alarming


Plugin usage causes system crash on Android

Plugin version: "1.0.1"
Issued android versions: 12, 13, 14, 15, didn't test anywhere else
targetSdkVersion = 34
minSdkVersion = 26
Providing device logs:
11-29 13:26:19.874 10853 10853 W Method java.lang.Object androidx.compose.runtime.snapshots.SnapshotStateMap.mutate(kotlin.jvm.functions.Function1) failed lock verification and will run slower.
11-29 13:26:19.874 10853 10853 W Common causes for lock verification issues are non-optimized dex code
11-29 13:26:19.874 10853 10853 W and incorrect proguard optimizations.
11-29 13:26:19.874 10853 10853 W Method void androidx.compose.runtime.snapshots.SnapshotStateMap.update(kotlin.jvm.functions.Function1) failed lock verification and will run slower.
11-29 13:26:19.874 10853 10853 W Method boolean androidx.compose.runtime.snapshots.SnapshotStateMap.removeIf$runtime_release(kotlin.jvm.functions.Function1) failed lock verification and will run slower.
11-29 13:26:19.914  4019  4186 D OplusNetworkSlowMgr: checkCidDorecoveryInvalid, mRecoveryConfig is false
11-29 13:26:19.925 10853 10853 D AndroidRuntime: Shutting down VM
11-29 13:26:19.927 10853 10853 E AndroidRuntime: FATAL EXCEPTION: main
11-29 13:26:19.927 10853 10853 E AndroidRuntime: Process: appName,
11-29 13:26:19.927 10853 10853 E AndroidRuntime: java.lang.NoSuchFieldError: No field Companion of type Landroidx/camera/lifecycle/ProcessCameraProvider$Companion; in class Landroidx/camera/lifecycle/ProcessCameraProvider; or its superclasses (declaration of 'androidx.camera.lifecycle.ProcessCameraProvider' appears in /data/app/{AppTag}/base.apk)
App is crashing on attempt to call method
await CapacitorBarcodeScanner.scanBarcode({
hint: 17,
cameraDirection: 1,
})

Please see #41

The latest version on package on NPM 1.0.3 doesn't have this fix.

updated to 1.0.3, android crashes, error : No static method rememberComposableLambda. I couldn't find any way to fix it, have to downgrade to 1.0.2.


Move Finch under finch/finch (instead of finagle/finch)?

This may help with discoverability. I don't really have a strong preference at the moment but eager to hear what people think.
As a side bonus we can have a little nicer URL for a website: https://finch.github.io - I'm not super sure though we can't already do that.

This would be a good opportunity to consolidate internal/external dependencies across the entire suite of projects. At the moment, a certain project A depends on X.x whilst a certain project B depends on X.y. We have to eye-ball several projects in order to avoid jar hell. Ideally, all internal/external version numbers should be sitting on a single place, shared across the entire suite.

@vkostyukov I don't see a lot of reason to prefer com.github.finagle to com.github.finch or io.finch as the groupId for new releases as long as there are warnings (and perhaps dual publishing) I personally like having finagle in some part of the the name but that's just due to me being used to it. If there ends up being wide agreement to move I'd prefer io.finch as it's what the code uses now.

It'll damage SEO for some time, but in a long-term sense it should be better.

I created https://issues.sonatype.org/browse/OSSRH-41890 so we can register io.finch group id and start publishing Finch there (even before we move).


Make auth should support multiple environments / SPs and persistent state

Is your feature request related to a problem? Please describe.
Currently running make auth deploys a single Service Principal and tracks the state locally for that SP. If you wish to deploy an SP per environment (for example, one for infra-test, one for app-dev and one for prod), you effectively need to either overwrite the state and change your config.yaml file temporarily with a new flowehr_id / suffix to give the SP a different name, or have three local clones of the FlowEHR repo, one per environment.
Also, this state isn't persisted anywhere, so will live locally on someone's laptop which isn't ideal for making modifications to the SP and associated role permissions.
Describe the solution you'd like
I think this code should be moved to Azure-Bootstrap. We could then use the config.yaml file in bootstrap to define the AD Apps per environment / project we wish to deploy and the associated permissions they need, as an optional auth block, i.e.:
auth:
  - flowehr-infratest:
    graph_permissions:
      - User.ReadWrite.All
      - etc.
  - flowehr-appdev:
    etc.

This would provide a flexible way of supporting multiple environments and could be re-used for other deployments as well. It will also benefit from the fact that we store state for bootstrap in a private repo.
Should an organisation wish to use existing SPs they have, they can just configure those in CI for FlowEHR without needing azure-bootstrap.

not blocking, but may get done when there's a spare moment, should be reasonably well scoped.


GKE: Hard rebooting nodes does not work

All of our nodes in GKE were pegged at 100% cpu and could not be ssh'd into, so I was forced to reboot them all from the console. When starting up, it seems google-startup-script is run after salt-minion has started. The script then fails with
Apr 16 19:45:00 k8s-dev1-c-blue-node-1 startupscript: == Installing salt-common_2014.1.13+ds-1~bpo70+1_all.deb, ignore dependency complaints (will fix later) ==
Apr 16 19:45:00 k8s-dev1-c-blue-node-1 startupscript: (Reading database ... 40258 files and directories currently installed.)
Apr 16 19:45:00 k8s-dev1-c-blue-node-1 startupscript: Preparing to replace salt-common 2014.1.13+ds-1~bpo70+1 (using salt-common_2014.1.13+ds-1~bpo70+1_all.deb) ...
Apr 16 19:45:00 k8s-dev1-c-blue-node-1 startupscript: Unpacking replacement salt-common ...
Apr 16 19:45:01 k8s-dev1-c-blue-node-1 startupscript: Setting up salt-common (2014.1.13+ds-1~bpo70+1) ...
Apr 16 19:45:01 k8s-dev1-c-blue-node-1 startupscript: Processing triggers for man-db ...
Apr 16 19:45:02 k8s-dev1-c-blue-node-1 startupscript: == Installing salt-minion_2014.1.13+ds-1~bpo70+1_all.deb, ignore dependency complaints (will fix later) ==
Apr 16 19:45:02 k8s-dev1-c-blue-node-1 startupscript: (Reading database ... 40258 files and directories currently installed.)
Apr 16 19:45:02 k8s-dev1-c-blue-node-1 startupscript: Preparing to replace salt-minion 2014.1.13+ds-1~bpo70+1 (using salt-minion_2014.1.13+ds-1~bpo70+1_all.deb) ...
Apr 16 19:45:02 k8s-dev1-c-blue-node-1 startupscript: Salt shall not start.
Apr 16 19:45:02 k8s-dev1-c-blue-node-1 startupscript: invoke-rc.d: policy-rc.d denied execution of stop.
Apr 16 19:45:02 k8s-dev1-c-blue-node-1 startupscript: Unpacking replacement salt-minion ...
Apr 16 19:45:02 k8s-dev1-c-blue-node-1 startupscript: Setting up salt-minion (2014.1.13+ds-1~bpo70+1) ...
Apr 16 19:45:02 k8s-dev1-c-blue-node-1 startupscript: Salt shall not start.
Apr 16 19:45:02 k8s-dev1-c-blue-node-1 startupscript: invoke-rc.d: policy-rc.d denied execution of start.
Apr 16 19:45:02 k8s-dev1-c-blue-node-1 startupscript: Processing triggers for man-db ...
Apr 16 19:45:02 k8s-dev1-c-blue-node-1 startupscript: == Installing unmet dependencies ==
Apr 16 19:45:02 k8s-dev1-c-blue-node-1 startupscript: Reading package lists...
Apr 16 19:45:03 k8s-dev1-c-blue-node-1 startupscript: Building dependency tree...
Apr 16 19:45:03 k8s-dev1-c-blue-node-1 startupscript: Reading state information...
Apr 16 19:45:03 k8s-dev1-c-blue-node-1 startupscript: 0 upgraded, 0 newly installed, 0 to remove and 4 not upgraded.
Apr 16 19:45:03 k8s-dev1-c-blue-node-1 startupscript: == Finished installing Salt ==
Apr 16 19:45:03 k8s-dev1-c-blue-node-1 startupscript: salt-minion started in defiance of runlevel policy, aborting startup.
Apr 16 19:45:03 k8s-dev1-c-blue-node-1 startupscript: Finished running startup script /var/run/google.startup.script

The only way to recover these hosts is to do
sudo service salt-minion stop
sudo service google-startup-scripts start

on each host.

/cc @zmerlynn @mbforbes

I'm sorry you ran into this. It's a dupe of #5666.

Do you know what caused your original issue?

I'm closing this in favor of the original, bumping the original priority and working on it.

Not at the moment. Thankfully, we have a cluster that hasn't died yet, but has a 78 load avg on our n1.standard.4. Containers are getting killed very often, but that looks like an issue w/our liveness probe.
Docker & Kubelet are taking up the majority of the CPU
$ top
082 root      20   0  448m 259m  15m S  98.7  1.7  23:15.69 kubelet
4450 root      20   0 7186m 269m  11m S  68.0  1.8   1235:07 docker

There are 68 veth interfaces at the moment on that node.
CAdvisor has been killed 4 times due to OOM. It is possible we have it oversubscribed, but currently there is 7GB free on that node.
and this is repeated in the logs for kubelet
W0416 22:46:42.939702    8082 docker.go:767] found a container with the "k8s" prefix, but too few fields (5): "k8s_POD.5426ef83_cadvisor-agent.file-6bb810db-k8s-qa1-c-blue-node-1.file_d3de30998479ba8b551557ea9bc3b064_4fb46b5e"


Keep status when stream mode and compress

Fixes #2351
related to https://github.com/NYTimes/gziphandler/pull/58

Awesome, thanks for the super quick fix!


Ensuring operator updates ScaledObject on all HTTPScaledObject changes

In certain situations, a valid update to an HTTPScaledObject won't trigger any in-kind update to the corresponding ScaledObject
Checklist

[x] Test in live Kubernetes
[x] Commits are signed with Developer Certificate of Origin (DCO)
[x] Any necessary documentation is added, such as:

README.md
The docs/ directory
The docs repo

Fixes #323
Fixes #20

@tpiperatgod could you take a look at this when you have a chance? It's almost ready but I would appreciate your review.

@tpiperatgod could you take a look at this when you have a chance? It's almost ready but I would appreciate your review.

Sorry, I'm just now seeing this, I think it will solve my issue, thanks @arschles !

 Closing in favor of the smaller #402.


Increase in Batch Size slows down runtime signficantly

Hi,
thanks for the wonderful repo! It's a pleasure to read the code and to work with it.
The runtime of the training seems to increase dramatically when I increase the batch size, despite still having a good GPU utilization and the data_time  just a small fraction of the time.
For example, with a batch size of 4 (with maskdino) is see:
[03/07 18:46:09 d2.utils.events]:  eta: 5 days, 15:55:47  iter: 59, ...  time: 1.3493  data_time: 0.0196

Whilst with a batch size of 2 I see:
[03/07 18:43:33 d2.utils.events]:  eta: 3 days, 2:58:34  iter: 59, ... time: 0.7281  data_time: 0.0101

My understanding would be that if time double but the batch size also double, the runtime should be identical. I am a bit surprised that time double despite the data_time being still so low (dataloader does not seem to be the bottleneck) and the GPU memory still be available and utilization is also not constantly maxed out. This is running on a single GPU with amp activated.
Why could that be?  Can I do something about it?

Hello! Thanks for your issue to point out this problem, I was wondering, do you refine the max_iter with a larger batch-size
To the best of my knowledge, detectron2 only support iter-based training now, so if you are using a larger training batch-size, you should set a small max_iter in your config, an example:
total_batch_size = 16
max_iter = 90000

total_batch_size = 32
max_iter = 45000

Thanks for the kind & informative reply!
Your answer makes a lot of sense - thanks.

Thanks for the kind & informative reply!
Your answer makes a lot of sense - thanks.

You're welcome~ I also believe that using epoch-based trainer may not be that confused~ we will try to update a epoched-based trainer in detrex in the future version


When creating initializers for WebGPU try to use first stored value

For #2387, the simplest suggestion of just adding a null initializer is being done for the cases that are missing an initializer. This will produce correct code, but not necessarily optimal code. For cases in which a constant value is stored to the variable before any usage, initializing to that value would remove an instruction from the emitted code. This may introduce significant complexity to the implemention, so has been broken out into its own issue to be implemented later.

This seems non-trivial to implement correctly, for what may not being a significant gain. I am going to put this on the back burner until we have evidence suggesting the current transformation's code needs optmization.

Can one rely on dead store elimination in the backends?

Can one rely on dead store elimination in the backends?

Yes, most driver shader compilers are very sophisticated, and they should be able to clean up the code.


Added tests for KeywordFunctionCall; added field checks and field err…

…ors to parser

Codecov Report

Merging #32 (4372125) into master (26665c6) will increase coverage by 0.03%.
The diff coverage is 81.39%.

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   91.60%   91.63%   +0.03%
==========================================
  Files         551      551
  Lines       14286    14327      +41
  Branches     1904     1919      +15
==========================================
+ Hits        13086    13128      +42
+ Misses        958      950       -8
- Partials      242      249       +7

Impacted Files
Coverage Δ

src/grammar-builder/build-grammar.ts
9.58% <ø> (+0.06%)
:arrow_up:

src/grammar-runtime-3/grammar.ts
95.23% <ø> (ø)

src/mysql-grammar-2/compiled-grammar.generated.ts
100.00% <ø> (ø)

...rc/mysql-grammar-2/expression/simple-expression.ts
100.00% <ø> (ø)

...ment/partition/list-partition-by-column-tuple-2.ts
100.00% <ø> (ø)

src/grammar-builder/grammar.ts
77.77% <50.00%> (-0.98%)
:arrow_down:

src/grammar-runtime-3/parser-2.ts
76.02% <71.87%> (+1.11%)
:arrow_up:

src/grammar-runtime-3/to-string.ts
91.66% <80.00%> (-4.42%)
:arrow_down:

...ql-grammar-2/expression/function-call/arguments.ts
100.00% <100.00%> (ø)

.../expression/function-call/keyword-function-call.ts
100.00% <100.00%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26665c6...4372125. Read the comment docs.


[DMZ] Remove /api/v1/verifyXMLDSig #2678

Closes #2678

Need quick check to see it doesn't break other things (seems harmless to remove that 1 method)


Mint IDs for unidentified concepts in the catalogue

We ignore FAST subjects in the transformer, because they often result in duplication (e.g. against the same concept in MeSH in the same record)
I wonder if the same problem is true WRT unidentified concepts.  Would this introduce a problem further downstream?

Example with unidentified concepts:
b24303318 (qrvudmy7)
A treatise on bear's grease, with observations to prove how indispensible the use of that incomparable substance, to preserve the head of hair
650  0 Hair|xCare and hygiene|vEarly works to 1800.
650  0 Hairstyles|xHistory|vEarly works to 1800.

Currently yields this in the API
{
  "subjects": [
    {
      "label": "Hair - Care and hygiene - Early works to 1800",
      "concepts": [
        {
          "label": "Hair",
          "type": "Concept"
        },
        {
          "label": "Care and hygiene",
          "type": "Concept"
        },
        {
          "label": "Early works to 1800",
          "type": "Concept"
        }
      ],
      "type": "Subject"
    },
    {
      "label": "Hairstyles - History - Early works to 1800",
      "concepts": [
        {
          "label": "Hairstyles",
          "type": "Concept"
        },
        {
          "label": "History",
          "type": "Concept"
        },
        {
          "label": "Early works to 1800",
          "type": "Concept"
        }
      ],
      "type": "Subject"
    }
  ]

Something I spotted when testing was that the tests in this space function more like mocks than matchers.
There are places where the return value from the SUT is checked to match against an object generated by the various object.apply calls that are found within the SUT.
The "extraction" part of it, where it finds the data in the Sierra data to pass to those apply calls is being tested, but what goes on inside apply is just being called again in the test.
The result of this is that we don't actually know what the member values are in any of the instances.  If we changed (e.g. ParsedPeriod.apply() to reverse the label it's trying to parse, we'd never know.
Many of the tests in this space are currently fairly readable, given that they assume there are no ids anywhere, but would become much harder to read when all these new IDs are implemented.
As a result, I have created some Matchers so that the tests can be read in a more narrative fashion.  Rather than "calling this function like this returns the same thing as calling that function like that", the new tests read more like "calling this function returns something that has these properties and those properties".
A further step might be to populate them with given/when/then/and, to make the narrative even clearer, but there's enough yak shaving going on here already.

https://github.com/wellcomecollection/catalogue-pipeline/pull/2149 (Draft PR for visibility)

There is an inconsistency between Subject and Genre.  Currently:
Subject has its own id, if available in $0, which represents the whole MARC field, and no Concepts have ids
Genre has no id, and the first Concept accepts the id from $0
My policy with this change is that everything that currently has an identifier will continue having that same identifier.  Only things that do not currently end up with an identifier will change.

This record has a 110 field with no second indicator, but the id in 0 is the LCNames identifier that matches the label
https://catalogue.wellcomelibrary.org/search/a?searchtype=Y&searcharg=Glucodin%2C+Minadex%2C+Adexolin+and+Adexocal+&searchscope=12&SORT=D
I assume that the behaviour should be as though indicator2=0 is the default (in subject/contributor fields).
That said, this has the potential to introduce error.  If the field is actually in the "wrong" scheme, and the id value coincidentally corresponds with an LCNames id, which is unrelated to the subject/contributor in question, then we would end up with dodgy links.
Perhaps the safest thing to do is this:

indicator2
subfield 0
no subfield 0

"0"
lc names
label derived

""
unidentifiable
label derived

anything else
unidentifiable
unidentifiable

i.e.

only create ids when there is no id.
only extract ids when we know what the id is
don't create or extract ids when the scheme is unexpected

Actually, it looks like it should assume LCNames, according to tests for Contributors.