Ability to mark mark flags as done on /app/flags/all/

Hi there,
it would be great to be able to mark flags as done on the overview page as some items just do not apply to the current tests and to mark them one does have to open them, mark them as done and apply the changes afterwards.
Thanks in advance.

Hey @lam0r,
I agree with this completely. Will add this feature in the next release. It's good one, appreciate it. Thank you!

Hey @lam0r ,
Just to keep you updated about the progress, today I pushed some updates that was required for the requirement you requested, I'm targeting to complete the functionality of marking multiple flags as done by next weekend. I'll let you know once it's ready.

Thank You for the Update :-)

Hey @lam0r,
This is done!
Now users should be able to mark multiple flags as done. We have a separate page for open flags too.
All the remaining pages get multiple delete option and with pagination support.
git pull the latest, update your sh00t set up. Don't forget to tell me how do you find this change.


New feature: Image carousel

Create a MDL based carousel that advance or rotate images in a fixed space
Markup:

Use a list to hold each image to display (ul li figure img figcaption)

Features:

Navigate carousel using keyboard (arrow keys, tab, pgup, pgdown, home, end), mouse drag, touch or by sending custom events to the carousel (first, scroll-prev, prev, next, scroll-next, last, play, pause)
Select a particular image  using enter or space key, or by clicking
Move images from right to left at a given interval; slideshow
Set slideshow interval via a data attribute or as a part of the play custom event
Stop slideshow via custom event (pause) or by a user interaction, e.g clicking an image
User interactions via keyboard or mouse may be blocked, if configured
Start slideshow at page load using a data attribute
The carousel should emit custom events reflecting a user action. E.g. clicking an image will emit a 'select' event with a detail object holding a reference to the selected image.

Limitations:

Only horizontal layout in first release

See also: https://www.w3.org/WAI/tutorials/carousels/


Make currently required features for some examples explicit

Objective
Fixes #3255
Solution

mark the bevy_gltf feature as required for some examples

This should be cleaned up when we remove the old renderer

This is needed only temporary, while the two renderer are available, as it's not possible to have two loaders for the same file extension.

Yes, but I would like the examples to run as expected at any time. So I would at least make the needed features explicit.
If a new user starts looking at the examples on main at the moment, the asset loading issues break quite a few of them.

This should be cleaned up when we remove the old renderer

Do you mean with this "Once removed the underlying cause is cleaned up" or "Once removed those annotations should also be removed"?
If it's the latter I would argue they should stay, in case a User starts a test with the --no-default-features flag.
Alongside the same argument, all other current default features should also be added if the example requires them.
(Doesn't have to be done in this PR, quickly fixing the Bug is of higher importance here.)

Do you mean with this "Once removed the underlying cause is cleaned up" or "Once removed those annotations should also be removed"?

I meant that once the old renderer is gone we probably have the needed loader by default again so the feature does not have to be turned on manually. So we could revert these changes again.
I like your suggestion to generally add the required features though. Not just because users might be running with --no-default-features, but mainly because I think it's nice documentation.

I like your suggestion to generally add the required features though. Not just because users might be running with --no-default-features, but mainly because I think it's nice documentation.

As a counterpoint to this, I think it makes sense for examples to only manually opt in to "non default" features because they should represent the "out of the box bevy experience". I want examples to stop compiling if we remove a feature they rely on from the defaults.

For now, I think the changes here are a reasonable workaround. Although I expect to remove the old renderer in the next couple of days.

bors r+

As a counterpoint to this, I think it makes sense for examples to only manually opt in to "non default" features because they should represent the "out of the box bevy experience". I want examples to stop compiling if we remove a feature they rely on from the defaults.

I totally agree with the "out of the box bevy experience" point.
But adding a feature to required-features still requires manually enabling said feature. It just prevents issues when running the example that might not be obviously caused by the missing feature. Instead, there will be a nice error message telling you to please enable the feature when running the example.
To fail compilation if a needed feature is missing might be hard in some cases. Here, for example, the missing asset loader just causes run-time issues.

I think I completely misunderstood your comment

Haha no worries!

Something  seems wrong with the merge. Bors is still pending.

bors try

bors r+


Translated Josh step syntax to Sam step syntax

I renamed every whisperer.yaml to whisperer.josh.yaml and then wrote my versions in whisperer.sam.yaml. The only thing I changed was things under steps:.
Some things I noticed while writing my version:

It's noticeably more verbose than your way
Despite commenting about my dislike of special characters, I added a % in some places
I opted to not have Git Whisperer rewrite any YAML structure so many next keys have an array of one element. If we decide that rewriting structure is okay, I'd remove the array part.
GW will require significant validations to ensure people haven't really screwed up step paths (in particular, infinite loops and dangling steps that don't lead to a done step).

Closing because I lost the bake off :(


Add option to use plenary.nvim to manage floating window

Lots of plugins have the same basic code to open floating windows. I'd love it
if there were a standard API for this, but the closest thing I have found is
plenary.nvim, which is already a
required dependency of a number of popular plugins (e.g.
Telescope). Using plenary to
manage floating windows allow for a consistent UI across multiple plugins, for
example, using winblend for transparency.
This patch adds a configuration variable
g:lazygit_floating_window_use_plenary, which, if set, checks for and uses
plenary.window.float to open lazygit's floating window. Default and fallback
behavior is unchanged.
After review, if you'd like to make this the default, I wouldn't complain :)

Thanks for making another PR! This is a good idea! I tested your implementation and it works. However, I think the colors and the winblend by default are a little off.
I edited the MINRC file to include plenary and ran the following vim -u tests/MINRC tests/MINRC. This loads just lazygit.nvim and nothing else.
The default background color and the default winblend are not great. Here's a side by side comparison (on the left is with the use plenary flag set to 1, on the right the flag is set to 0):

Here's the file I used:
" If after installing lazygit.vim, you are having trouble getting it to work, try the following minimal vimrc file.

set nocompatible              " be iMproved, required
filetype off                  " required

if empty(glob('~/.local/share/nvim/site/autoload/plug.vim'))
  silent !curl -fLo ~/.local/share/nvim/site/autoload/plug.vim --create-dirs
    \ https://raw.githubusercontent.com/junegunn/vim-plug/master/plug.vim
  autocmd VimEnter * PlugInstall --sync | source $MYVIMRC
endif

call plug#begin('~/.local/share/nvim/plugged')

Plug 'nvim-lua/plenary.nvim'
Plug '~/gitrepos/lazygit.nvim'

" Initialize plugin system
call plug#end()

let mapleader = " "
nnoremap <silent> <leader>lg :LazyGit<CR>

let g:lazygit_floating_window_use_plenary = 1

" Save the above to a file `MINRC`, and run `nvim -u MINRC` and type `<leader>lg` in normal mode.

There does seem to be a option.winblend in plenary.nvim but I don't see a way to change the background color? Do you happen to know? I'm happy to merge it as is without making it the default if that feature doesn't exist.

I confirm your results using a minimal config. In my default config, it looks normal, and I don't set any plenary options. Probably another plugin sets plenary options. I'll investigate more. Thanks!

Okay, I figured out what's going on. It's a highlight issue. By default, floating windows use the Pmenu highlight group. Almost every colorscheme sets this to something sane, but the default is a terrible magenta color. If you add
hi clear Pmenu

to your MINRC file, it looks normal. Or, if you add a realistic colorscheme and use it, it looks fine too. For example:
Plug 'kyoz/purify', {'rtp: 'vim'}
colors purify

What I haven't figured out is how your code avoids looking like that with the default colorscheme!

Thanks for digging through this! I believe it is because of this line:
https://github.com/kdheepak/lazygit.nvim/blob/cb20b05ca781e3d5d2f3707ca43965c4222c2177/lua/lazygit.lua#L116
On Thu, Mar 25, 2021 at 3:02 PM Joel Elkins @.***>
wrote:

Okay, I figured out what's going on. It's a highlight issue. By default,
floating windows use the Pmenu highlight group. Almost every colorscheme
sets this to something sane, but the default is a terrible magenta color.
If you add
hi clear Pmenu
to your MINRC file, it looks normal. Or, if you add a realistic
colorscheme and use it, it looks fine too. For example:
Plug 'kyoz/purify', {'rtp: 'vim'}
colors purify
What I haven't figured out is how your code avoids looking like that with
the default colorscheme!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kdheepak/lazygit.nvim/pull/37#issuecomment-807480591,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAN2VAIQV2UTZPBUWKA6YBTTFOQE3ANCNFSM4ZYGLUMQ
.

Ah, I just saw your edit. I'll go ahead and merge it and leave it non default!

Thanks for making the PR!

thank you!


Update scheduled-events.md

@mimckitt : Thanks for your contribution! The author(s) have been notified to review your proposed change.


[Android] Blocked someone via a mod list, but still got a notif of them mentioning me

Describe the bug

I got a notification from someone even though I had them blocked via a mod list.
To Reproduce
Steps to reproduce the behavior:

Block someone via a mod list.
They mention you
You get the notification

Expected behavior

If they mention me, I don't get a notification
Screenshots

N/A
Details

Platform: Android
Platform version: 14
App version: 1.63.0

Additional context
Not sure if this is replicable, but please fix this. The person is on the mod list for harassing me and I'd rather not be reminded of their presence. Thanks.

Hey @heikadog sorry for the delay, finally putting a dent in my triage
Some quick questions:

You blocked the modlist, not muted, right? (Shouldnt affect the outcome just need to know)
Was this a push notification on mobile, or a notification in the app's notifications feed?
Have you only witnessed this from mentions? Not replies, likes, or anything else?

Thanks!

blocked
push notif on mobile!
just from a mention!

update: just happened again a few minutes ago—didn't take a screenshot of the notif but it's worth noting this is still an issue as of 1.70


Python Debug in internalConsole doesn't work with setting cwd

Type: Bug
Hello,
I am debugging a python file that is in a subfolder of the root folder of the project:
midterm
|- scans-and-canvas-upload
   |- push-to-canvas.py

So to debug this script, I have to add the following option to launch.json:
"cwd": "scans-and-canvas-upload",
When I'm debugging with the option "console": "integratedTerminal", it works fine.
However, when I'm debugging with the option "console": "internalConsole", I get the following error:

Failed to spawn launcher: [Errno 2] No such file or directory: 'scans-and-canvas-upload'.
And I can either Cancel or Open 'launch.json'.

I feel like there must be a bug where having a custom cwd is not compatible with the internalConsole. I have looked online but couldn't find a similar issue.
Is there additional configuration that I need to add when I'm using the internalConsole?
Thank you!
VS Code version: Code 1.72.2 (d045a5eda657f4d7b676dedbfa7aab8207f8a075, 2022-10-12T22:16:26.920Z)
OS version: Linux x64 5.15.0-52-generic
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
AMD Ryzen 9 3950X 16-Core Processor (32 x 2200)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: disabled_softwarevideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
0, 0, 0

Memory (System)
62.74GB (39.68GB free)

Process Argv
--unity-launch --crash-reporter-id e424459f-456d-4d84-918e-444764c154ef

Screen Reader
no

VM
0%

DESKTOP_SESSION
ubuntu

XDG_CURRENT_DESKTOP
Unity

XDG_SESSION_DESKTOP
ubuntu

XDG_SESSION_TYPE
x11

Extensions (14)

Extension
Author (truncated)
Version

doxdocgen
csc
1.4.0

githistory
don
0.6.19

language-julia
jul
1.38.2

python
ms-
2022.16.1

vscode-pylance
ms-
2022.11.10

jupyter
ms-
2022.9.1202862440

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.10

vscode-jupyter-cell-tags
ms-
0.1.6

vscode-jupyter-slideshow
ms-
0.1.5

remote-containers
ms-
0.262.3

remote-ssh
ms-
0.90.1

remote-ssh-edit
ms-
0.84.0

cmake-tools
ms-
1.12.27

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
dsvsc012:30540252
azure-dev_surveyone:30548225
pyindex848:30577860
nodejswelcome1cf:30587006
fc301958:30595537
2e4cg342:30602488
3d0df643:30602300
dbltrim-control:30603952

Note that if I open a new VScode window with the root folder being scans-and-canvas-upload, then I just don't specify cwd, and both internalConsole and integratedTerminal work fine.

Please file an issue on the python repo


98970 fix cypress test 86462 verify date sent return

Amended cypress test so that expected value for ...dateSent is no w set before checking the value of it

Have confirmed that these tests are passing locally:


cannot find symbol in adapter class

I have multi module app. It was so complicated to configure apollo3 running in my project. Pls make it easer for multi module project !
Now are the query classes generated, but i get this error:
/app/build/tmp/kapt3/stubs/sLiveDebug/adapter/MyClassQuery_VariablesAdapter.java:6: error: cannot find symbol
public final class TopNavigationQuery_VariablesAdapter implements com.apollographql.apollo3.api.Adapter {
^
symbol: class MyClassQuery
Why in this folder in tmp/kapt3/stubs/ ?
How do i fix this ? thanks
Here my config:
apollo {
    service("service") {
        //packageNamesFromFilePaths()
        packageName.set("")
        srcDir("src/main/graphql")
        generateApolloMetadata.set(true)

}

Hi!
Not exactly sure what the issue with kapt is, but do you have the kapt plugin applied in your Apollo module(s)? You could try to remove it, or isolate Apollo in independent modules that don't use kapt.
More generally, would you be able to share a minimal project that reproduces the issue?

@BoD How can i isolate Apollo that don't us kapt ?

It's difficult to say without knowing the structure of your project, but I meant something like this:

app: Android module, depends on api module, uses kapt (if needed)
api: not an Android module, depends on Apollo lib, defines GraphQL schema and operations, doesn't use kapt

I can't post the app structure, its big
I see only package adapter in header ,maybe kapt do not find imports in header.
`package adapter;
@kotlin.Metadata
public final class MyClassQuery_VariablesAdapter implements com.apollographql.apollo3.api.Adapter {
@org.jetbrains.annotations.NotNull()
public static final adapter.MyClassQuery_VariablesAdapter INSTANCE = null;`

Hi @namdroid were you able to find a solution to this problem?

I'm assuming you found a solution. If not, please leave a comment and I'll reopen this issue.

I ran into this same issue, I think. For me it was caused by the empty package name (like I see here). Fixed by setting one. (From your comment in https://github.com/apollographql/apollo-kotlin/issues/3292#issuecomment-894377860)


HDDS-7590. Use keyManager and trustManager provided by keyStoreFactory in om grpc services

https://issues.apache.org/jira/browse/HDDS-7590

@neils-dev


CI：move some tests which run for a long time from travis to action

Codecov Report

Merging #1938 (cf3d6ff) into main (a240bf4) will increase coverage by 0.02%.
The diff coverage is n/a.

:exclamation: Current head cf3d6ff differs from pull request most recent head e56ccd8. Consider uploading reports for the commit e56ccd8 to get more accurate results

@@            Coverage Diff             @@
##             main    #1938      +/-   ##
==========================================
+ Coverage   61.50%   61.52%   +0.02%
==========================================
  Files         135      135
  Lines       23446    23446
==========================================
+ Hits        14420    14426       +6
+ Misses       7350     7344       -6
  Partials     1676     1676

Impacted Files
Coverage Δ

pkg/chunk/utils_unix.go
73.33% <0.00%> (-20.00%)
:arrow_down:

pkg/vfs/writer.go
78.64% <0.00%> (-1.02%)
:arrow_down:

pkg/chunk/disk_cache.go
79.85% <0.00%> (-0.49%)
:arrow_down:

pkg/meta/sql.go
64.70% <0.00%> (ø)

pkg/meta/redis.go
71.77% <0.00%> (+0.04%)
:arrow_up:

pkg/chunk/cached_store.go
76.23% <0.00%> (+0.18%)
:arrow_up:

pkg/meta/base.go
69.93% <0.00%> (+0.32%)
:arrow_up:

pkg/fs/fs.go
77.66% <0.00%> (+0.78%)
:arrow_up:

pkg/meta/sql_lock.go
75.00% <0.00%> (+2.56%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84ab2fb...e56ccd8. Read the comment docs.


Refactor: rider links in sidebar

Commits are atomic. The goal here is show rider-specific links to dispatcher who are also riders. Along the way I did a bit of refactoring.
I still need to make it so that the toggleable "rider links" sticks open/close between pages, which might have to be done with javascript unless you have any ideas on how to do that application wide on the elixir side @mveytsman .
Screenshot:

Update: removed toggling. Keep it simple.

Is the fialing test just flakey?

Is the fialing test just flakey?

yes it's a bit flakey ❄ .


extensions/nv/low_latency2: Use count parameter for p_timings "array" member

Fixes #814, CC @repi @vzout
As it turns out this extension has a rather suboptimal layout where the vk::GetLatencyMarkerInfoNV struct is not aware that its own p_timings field is an array, because it does not have a count field. Instead the length of this array is passed around via the pTimingCount pointer parameter of get_latency_timings().
A couple things are needed to set this straight:

The struct builder must be adjusted to accept a slice (without storing the length anywhere...);
The get_latency_timings() wrapper function should no longer accept a mutable slice of vk::GetLatencyMarkerInfoNV, but instead accept a single object that contains a pointer to the array (and p_next...);
This function must have a separate parameter to pass the length of the p_timings slice mentioned at 1., as we cannot reconstruct it from vk::GetLatencyMarkerInfoNV nor via its p_timings pointer;
The mutable struct and initialized p_timings array must still be passed fully by the user because both vk::GetLatencyMarkerInfoNV and vk::LatencyTimingsFrameReportNV have a p_next field that the user could initialize to point to some extension structure that they desire to be filled in.  This info might also be relevant in the _len() query;
Asserts have been put in place to ensure correct use of this API with regards to p_timings being (not) NULL for querying the count or actual values, respectively.

If it wasn't for p_next in vk::GetLatencyMarkerInfoNV we could have hidden away the construction of that type. And if it weren't for p_next in vk::LatencyTimingsFrameReportNV we could have done the allocation in a helper function and hid all this away and just return a Vec<vk::LatencyTimingsFrameReportNV<'_>>...

Let's hold off merging these changes for a little bit until upstream fixes land in vk.xml: https://github.com/KhronosGroup/Vulkan-Docs/issues/2269#issuecomment-1813339455

The extension API definition has been fixed upstream (pCount is moved from being a function argument to a field on VkGetLatencyMarkerInfoNV), and our generator now "correctly" (see above regarding the lifetime...) generates a slice-setter. The changes are pulled in via a regular Vulkan spec-update PR: #816

Awesome work!


Add consoleLog flag

Update action.yml to include support for logging to the console. When the flag consoleLog is set to true, the output will look like the following:

@microsoft-github-policy-service agree

@A-Katopodis - can we get this reviewed and merged please? This is useful and I've had to create my own version in the meantime to work round this.


docs: Update api-routes.page.server.mdx

add warning to make people aware of changes in any files that affecting the server, such as adding api routes, middleware, etc.

👍 Good idea.


Separate default trait impl from abstract trait

This change is

Codecov Report

Merging #901 (3a05a08) into main (e8ee613) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #901      +/-   ##
==========================================
- Coverage   69.74%   69.69%   -0.06%
==========================================
  Files          42       42
  Lines        5744     5754      +10
  Branches     5744     5754      +10
==========================================
+ Hits         4006     4010       +4
- Misses       1366     1372       +6
  Partials      372      372

Files Changed
Coverage Δ

.../blockifier/src/transaction/account_transaction.rs
93.69% <ø> (ø)

crates/blockifier/src/transaction/objects.rs
43.47% <0.00%> (-0.97%)
:arrow_down:

crates/blockifier/src/transaction/transactions.rs
65.26% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fixed sitemap.xml with multiple tiers in content-sites

1. Why is this change necessary?
Currently only 2 tiers available in sitemap.xml
2. What does this change do, exactly?
Uses simple faster dbal instead of ORM and fetches all children
3. Describe each step to reproduce the issue or behaviour.
Creates multiple tiers content pages
4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[ ] I have read the contribution requirements and fulfil them.

Hey @shyim,
please provide tests for this bugfix.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-20639
Please use this issue to track the state of your pull request.

@shopwareBot ,
done.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-20650
Please use this issue to track the state of your pull request.

Has been fixed with https://github.com/shopware/shopware/commit/662720fec2c1174c454c52fb42e73656fe84ec3b


ci: add OS X build

" Total time 12 min 48 sec" :/

" Total time 12 min 48 sec" :/

That's the sum of two build times, that ran in parallel.  https://travis-ci.org/propelml/propel/builds/339919219


Support default configuration export

Conveniently available for developers to modify from the default configuration

Closes #
📝 Description

as title

⛳ Current behavior (updates)

export default configuration

🚀 New behavior

export default configuration

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

New Features

export default configuration

changeset:
export default configuration


TypeError: Cannot read property 'launch' of undefined

When I run even the simplest of tests. ::
This is the sample from the documentation.
//foo.spec.ts
import { it, expect } from "@playwright/test";
it("is a basic test with the page", async ({ page }) => {
await page.goto("https://playwright.dev/");
const name = await page.innerText(".navbar__title");
expect(name).toBe("Playwright");
});
I get the following error:

foo.spec.ts:3:1 › is a basic test with the page ===============================================
browserName=chromium,, headful=false, slowMo=0, video=false, screenshotOnFailure=true

TypeError: Cannot read property 'launch' of undefined

    at Object.fixtures.browser.init.scope [as fn] (C:\repos\SkyKick.Migrations.MigrationServices\tools\prototypes\playwright-test\node_modules\@playwright\test\out\index.js:48:39)
    at Fixture.setup (C:\repos\SkyKick.Migrations.MigrationServices\tools\prototypes\playwright-test\node_modules\folio\out\fixtures.js:78:52)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at FixturePool.setupFixtureForRegistration (C:\repos\SkyKick.Migrations.MigrationServices\tools\prototypes\playwright-test\node_modules\folio\out\fixtures.js:239:9)
    at Fixture.setup (C:\repos\SkyKick.Migrations.MigrationServices\tools\prototypes\playwright-test\node_modules\folio\out\fixtures.js:68:25)
    at FixturePool.setupFixtureForRegistration (C:\repos\SkyKick.Migrations.MigrationServices\tools\prototypes\playwright-test\node_modules\folio\out\fixtures.js:239:9)
    at Fixture.setup (C:\repos\SkyKick.Migrations.MigrationServices\tools\prototypes\playwright-test\node_modules\folio\out\fixtures.js:68:25)
    at FixturePool.setupFixtureForRegistration (C:\repos\SkyKick.Migrations.MigrationServices\tools\prototypes\playwright-test\node_modules\folio\out\fixtures.js:239:9)
    at Fixture.setup (C:\repos\SkyKick.Migrations.MigrationServices\tools\prototypes\playwright-test\node_modules\folio\out\fixtures.js:68:25)
    at FixturePool.setupFixtureForRegistration (C:\repos\SkyKick.Migrations.MigrationServices\tools\prototypes\playwright-test\node_modules\folio\out\fixtures.js:239:9)
    at FixturePool.resolveParametersAndRunHookOrTest (C:\repos\SkyKick.Migrations.MigrationServices\tools\prototypes\playwright-test\node_modules\folio\out\fixtures.js:258:29)
    at WorkerRunner._runTestWithFixturesAndHooks (C:\repos\SkyKick.Migrations.MigrationServices\tools\prototypes\playwright-test\node_modules\folio\out\workerRunner.js:187:17)

Running in powershell core causes this issue.  Running in Windows Powershell I don't see this issue occur.

The new test-runner which got released yesterday is quite different. So I'm closing this as part of the triage. Please reopen if its still persistent.


Install-Package: Index was outside the bounds of the array.

Steps to reproduce
# install docker stable
Install-Module DockerMsftProvider
Install-Package Docker -ProviderName DockerMsftProvider

# uninstall
Uninstall-Package -name docker -Verbose

# install docker preview
Install-Module DockerProvider
Install-Package Docker -ProviderName DockerProvider -RequiredVersion preview

Expected behavior
A correct installation of the preview version of Docker.
Actual behavior
PS C:\Program Files\PowerShell\7-preview> Install-Package Docker -ProviderName DockerProvider -RequiredVersion preview
WARNING: Cannot bind argument to parameter 'version' because it is an empty string.
WARNING: Index was outside the bounds of the array.

The package(s) come(s) from a package source that is not marked as trusted.
Are you sure you want to install software from 'Docker'?
[Y] Yes  [A] Yes to All  [N] No  [L] No to All  [S] Suspend  [?] Help (default is "N"): A
Install-Package: Index was outside the bounds of the array.

Environment data
Windows Server 2016, $PSVersionTable:
Name                           Value
----                           -----
PSVersion                      7.1.0-preview.3
PSEdition                      Core
GitCommitId                    7.1.0-preview.3
OS                             Microsoft Windows 10.0.14393
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Unless there's a version that is just labelled prerelease, I don't think that's expected to work. -RequiredVersion expects a full version number.
If you just want the latest prerelease, you just need to supply the -AllowPrereleaseVersions switch, without specifying a -RequiredVersion. 🙂

Got it, thanks :)


Apply black code fromatter

Hello @vlukiyanov! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file examples/20news/20news.py:

Line 18:80: E501 line too long (83 > 79 characters)
Line 21:80: E501 line too long (84 > 79 characters)
Line 23:80: E501 line too long (86 > 79 characters)
Line 80:80: E501 line too long (84 > 79 characters)
Line 84:80: E501 line too long (88 > 79 characters)
Line 84:86: E231 missing whitespace after ','
Line 91:80: E501 line too long (88 > 79 characters)
Line 122:80: E501 line too long (80 > 79 characters)

In the file examples/nypl_menus/nypl_menus.py:

Line 15:80: E501 line too long (83 > 79 characters)
Line 18:80: E501 line too long (84 > 79 characters)
Line 20:80: E501 line too long (86 > 79 characters)
Line 51:62: E231 missing whitespace after ','
Line 65:80: E501 line too long (88 > 79 characters)

In the file examples/nypl_menus/prepare_data.py:

Line 36:80: E501 line too long (84 > 79 characters)
Line 40:80: E501 line too long (84 > 79 characters)

In the file examples/wine_reviews/prepare_data.py:

Line 51:80: E501 line too long (87 > 79 characters)
Line 52:80: E501 line too long (86 > 79 characters)

In the file examples/wine_reviews/wine_reviews.py:

Line 19:80: E501 line too long (83 > 79 characters)
Line 22:80: E501 line too long (84 > 79 characters)
Line 24:80: E501 line too long (86 > 79 characters)
Line 72:80: E501 line too long (88 > 79 characters)
Line 78:80: E501 line too long (88 > 79 characters)
Line 78:86: E231 missing whitespace after ','
Line 85:80: E501 line too long (88 > 79 characters)
Line 118:80: E501 line too long (80 > 79 characters)

In the file ptavitm/model.py:

Line 74:75: E231 missing whitespace after ','
Line 96:80: E501 line too long (82 > 79 characters)
Line 106:80: E501 line too long (88 > 79 characters)
Line 177:80: E501 line too long (80 > 79 characters)

In the file ptavitm/sklearn_api.py:

Line 102:80: E501 line too long (85 > 79 characters)

In the file ptavitm/vae.py:

Line 59:80: E501 line too long (85 > 79 characters)
Line 87:80: E501 line too long (84 > 79 characters)
Line 114:80: E501 line too long (85 > 79 characters)
Line 117:80: E501 line too long (85 > 79 characters)


shouldn't react be a peer dependency instead of a dependency?

as the title says :)

This is solved in pull request #86.


Apollo federation and subgraph configuration

Description
We have setup this plugin in apollo federated gateway and subgraphs.
We have them running in one server - 1 gateway + 4 subgraphs
The problem is that newrelic stopped working after apollo federations.
So we started to introduce this plugin but still the same.
Here is some of the code structure we have.
|
  |-- gateway
    |-- server.ts
  |-- subgraphs
    |-- subgraph1
      |-- server.ts
    |-- subgraph2
      |-- server.ts
  newrelic.js

gateway/server.ts file
import dotenv from 'dotenv'
dotenv.config()

import { ApolloGateway } from '@apollo/gateway'
import createPlugin from '@newrelic/apollo-server-plugin'
import { ApolloServerPluginLandingPageGraphQLPlayground } from 'apollo-server-core'
import { ApolloServer } from 'apollo-server-express'
import cors from 'cors'
import express from 'express'
import { readFileSync } from 'fs'
import { graphqlUploadExpress } from 'graphql-upload'
import { createServer } from 'http'
import path from 'path'

const app = express()
const gateway = new ApolloGateway()
const server = new ApolloServer({
    gateway,
    introspection: process.env.ENABLE_INTROSPECTION_QUERIES === 'true',
    plugins: [
      ApolloServerPluginLandingPageGraphQLPlayground(),
      usageReportingPlugin(),
      createPlugin(),
    ],
  })
  const httpServer = createServer(app)
  await server.start()

  server.applyMiddleware({
    app,
    path: '/graphql',
  })

  httpServer.listen(process.env.PORT, () => {
    console.log(`🚀 Gateway ready 🚀`)
  })

newrelic.js
'use strict'
require('dotenv').config()
/**
 * New Relic agent configuration.
 *
 * See lib/config/default.js in the agent distribution for a more complete
 * description of configuration variables and their potential values.
 */

const appName = process.env.NEW_RELIC_APP_NAME

exports.config = {
  /**
   * Array of application names.
   */
  app_name: [appName],
  /**
   * Your New Relic license key.
   */
  license_key: process.env.NEW_RELIC_LICENSE_KEY,
  logging: {
    /**
     * Level at which to log. 'trace' is most useful to New Relic when diagnosing
     * issues with the agent, 'info' and higher will impose the least overhead on
     * production applications.
     */
    level: 'info',
  },
  /**
   * When true, all request headers except for those listed in attributes.exclude
   * will be captured for all traces, unless otherwise specified in a destination's
   * attributes include/exclude lists.
   */
  allow_all_headers: true,
  attributes: {
    /**
     * Prefix of attributes to exclude from all destinations. Allows * as wildcard
     * at end.
     *
     * NOTE: If excluding headers, they must be in camelCase form to be filtered.
     *
     * @env NEW_RELIC_ATTRIBUTES_EXCLUDE
     */
    exclude: [
      'request.headers.cookie',
      'request.headers.authorization',
      'request.headers.proxyAuthorization',
      'request.headers.setCookie*',
      'request.headers.x*',
      'response.headers.cookie',
      'response.headers.authorization',
      'response.headers.proxyAuthorization',
      'response.headers.setCookie*',
      'response.headers.x*',
    ],
  },
}

subgraph1/server.ts
  const app = express()

  const server = new ApolloServer({
    schema: config.schema,
    plugins: [
      ApolloServerPluginLandingPageGraphQLPlayground(),
      ApolloServerPluginInlineTrace(),
      usageReportingPlugin(),
      createPlugin(),
    ],
  })

  if (config.requiresUploadPlugin) {
    app.use(graphqlUploadExpress())
  }

  const httpServer = createServer(app)
  await server.start()

  server.applyMiddleware({
    app,
    path: '/graphql',
  })

package.json
{
...
  "scripts": {
    "dev:subgraph:subgraph1": "ts-node-dev -r tsconfig-paths/register ./subgraph1/server.ts",
    "dev:subgraph:subgraph2": "ts-node-dev -r tsconfig-paths/register ./subgraph2/server.ts",
    "dev:supergraph": "ts-node-dev -r tsconfig-paths/register ./gateway/server.ts",
    "dev": "concurrently -n subgraph:,supergraph\"npm run dev:subgraph:*\" \"npm run dev:supergraph\""
  }
}

Expected Behavior
Expected to see the reports in newrelic or log file locally.
Your Environment
node 16
"@apollo/gateway": "^0.50.0",
"@apollo/subgraph": "^0.4.0",
"@newrelic/apollo-server-plugin": "^1.2.2",
"apollo-server": "^3.6.7",
"apollo-server-express": "^3.6.7",
"newrelic": "^8.9.1",
Additional context
I got undefined for that first parameter: instrumentationApi

I believe the issue is that you are calling createPlugin prior to providing it as a plugin. The example code from our plugin's documentation indicates you should leave it to Apollo to invoke the plugin, like so:
// index.js
const plugin = require('@newrelic/apollo-server-plugin')

// imported from supported module
const server = new ApolloServer({
  typeDefs,
  resolvers,
  plugins: [plugin]
})

Let us know if you continue to have issues!

Ah, my apologies. It looks like that's not the solution. Let me look deeper and get back to you...

So, it looks like the New Relic agent isn't loading, which causes that instrumentationApi parameter to be undefined. My team feels you should reach out to our technical support team to help you parse out your logs and ensure the agent is being loaded properly.

@garbados, we've already tried to reach out to<EMAIL_ADDRESS>for our issues.

Is Apollo Federation supported on the Acquia Cloud platform?

[UPDATE]
Acquia executive leadership for enterprise has confirmed they do not support Apollo Federation with New Relic. Similar limitations with distributed tracing issues. They were did update their documentation 😂 which is the furthers I have gotten.

https://docs.acquia.com/cloud-platform/monitor/apm/configuring-new-relic/#compatibility-statement

https://discuss.newrelic.com/t/node-new-relic-agent-not-starting-using-apollo-federation/181282

Suggestion
I suggest New Relic leadership applies pressure and works out something with the major Drupal hosting platform if you would like customers on Acquia to continue to leverage your platform for monitoring.
Compatibility statement
Cloud Platform is compatible with the Application Monitoring services provided by New Relic. Acquia doesn’t support New Relic Infrastructure Monitoring services, Log Monitoring services, or any plug-ins.

Cloud Platform isn’t compatible with [New Relic APM’s Distributed Tracing (https://docs.newrelic.com/docs/understand-dependencies/distributed-tracing/get-started/introduction-distributed-tracing) feature.
Acquia can’t make changes to the New Relic agent on a per-client basis.
Acquia doesn’t support the installation of New Relic on any non-web infrastructure. While New Relic routinely makes updates to their services and periodically adds new features, Acquia will update versions of this service running on Acquia Cloud twice annually. This allows Acquia to ensure new logic in New Relic’s PHP monitoring agent has had several months to stabilize before introducing it onto Cloud Platform.

Weak sauce on their part so I hope someone can fix this partnership.
fyi @douglas-wang @garbados @bizob2828

Link to Community forum post about this: https://discuss.newrelic.com/t/node-new-relic-agent-not-starting-using-apollo-federation/181282


fix:  adds lookup_keys for cisa_kev enrichment table

Based on https://www.matano.dev/docs/enrichment/lookup-data - it looks like lookup_keys needs to be specified in order to be able to lookup against the enrichment table in our python rules and VRL. Adding this to the managed enrichment definition for cisa_kev

Assuming my assumption above is correct, looks like the other managed enrichment tables need their lookup keys specified too? I'd be happy to include those in this PR if appropriate

Great, I'll do a quick check, we may not be merging these in when using a managed enrichment table right now, should add that for convenience.


Not Able to insert DataSet using Backend API

Hi,
I am trying to insert Dataset using Backend API (POST: {wherehows-backend-url}/dataset/).
The API returns a success but in logs, it throws an error saying "Column count doesn't match value count at row 1".
I am trying to integrate with Wherehows using backend APIs.
Please help.
Thanks

I don't think the backend API is being supported anymore. =(
#1051

Dear issue owner,
Thanks for your interest in WhereHows. We have recently announced DataHub which is the rebranding of WhereHows. LinkedIn improved the architecture of WhereHows and rebranded WhereHows into DataHub and replaced its metadata infrastructure in this direction. DataHub is a more advanced and improved metadata management product compared to WhereHows.
Unfortunately, we have to stop supporting WhereHows to better focus on DataHub and offer more help to DataHub users. Therefore, we will drop all issues related to WhereHows and will not accept any contribution for it. Active development for DataHub has already started on datahub branch and will continue to live in there until it's finally merged to master and project is renamed to DataHub.
Please check the datahub branch to get familar with DataHub.
Best,
DataHub team


Wrong version number in README.md for responsive image

The README.md is stating a wrong version number.
I don't know if it slipped through due to merging back and forth while preparing for v2 or something similar and if other parts are also affected.

thanks


Remove the mkstream endpoint

This endpoint has been deprecated for a while, hasn't been called in the past 4 weeks.

Nice!


Add off-canvas nav sidebar component

@shanksdev Do you mean something similar to a vertical nav menu ( http://v4-alpha.getbootstrap.com/components/navs/#stacked-pills ), or similar to an off-canvas menu (like http://getbootstrap.com/examples/offcanvas/ with its "Toggle nav" button when the screen is narrow)?

The off-canvas menu with toggle nav was something i was looking for. I came across this need when i was first time getting my hands on bootstrap i came up with the sidebar using the nav stacked-pills, something like this

Sorry, I didn't knew about offcanvas.css and offcanvas.js that time. But after reviewing the code of both js and css files it seems easy to implement. :)
Still, if you think that its worth adding that much code of both files in your bootstrap's js and css then please do, we can save 1 or 2 http requests. :)

YES. Off Canvas Menu is more and more often used UI component these days. It would be nice if it become an official Bootstrap 4 component with standardized implementation process.
I'm not sure how sophisticated and bullet-proof this v3 (old) Off Canvas example is. Some of Bootstrap GURUs should revised that solution and update it. Because this v4 Off Canvas example is only copy of that v3 (old) solution.

Will be great to see this in next v4 alpha. cheers.

+1

+1
Those drawers are also used in Material Design, therefore I would like to use drawsers for the main navigation of my mobile optimized websites (like used in materializecss.com, but with a horizontal navbar on non-mobile devices)

+1
This seems to be a popular feature. I've used a bootstrap plugin (http://www.jasny.net/bootstrap/examples/navmenu/) for this sort of thing before but it would be great to have official support for something like this.

X-Ref: #15796

I think in Collapsible content is the best method to create off-canvas, drawer, or whatever name to references this.
If this feature is add example not only on the top, maybe in right, left or bottom. If added a OVERLAY option, this will be great :)
Actually/currently method to handle off-canvas in other framework
And overlay method to handle ui like material-design menu implement now

Here is a proof-of-concept of @adiramardiani's method: https://jsfiddle.net/2q4ppqm5/2/. I was able to use all existing BS classes except I added added an .overlay class that sets:
.overlay {
  height: 100vh;
  position: fixed;
  background-color: #FFF;
  border-right: solid 1px ;
}

A few problems with my example:

Navigation should come in from the right instead of the top.
It isn't possible to make the drawer visible as a sidebar. (This probably could be done, but I didn't take the time to figure out how.)

Note that this example has two buttons, one on the page, and one in the drawer (for closing).
I think this might be a good idea, it will just take a little work. Also, .navbar-toggleable-* & .navbar-toggle would need to be renamed if we implement drawers with this method.

Hi @RyanZim!
You appear to have posted a live example (https://fiddle.jshell.net/2q4ppqm5/2/show/light/), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

line 10181, column 5: E013: Only columns (.col-*-*) may be children of .rows

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

Updated: https://jsfiddle.net/2q4ppqm5/3/

Added .col-xs-12 to main content to fix lmvtfy errors
Moved <nav> outside .row
Added z-index: 1 to .overlay

Hi @RyanZim!
You appear to have posted a live example (https://fiddle.jshell.net/2q4ppqm5/3/show/light/), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

line 10164, column 3: E014: Columns (.col-*-*) can only be children of .rows or .form-groups

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

Punting on adding this in v4 for the initial launch. Let's tackle it with a follow-up release.

Is this possible as of now? The off canvas example on the website doesn't seem to be working as a side drawer

The offcanvas example is confusing since it seems to be broken.


How to turn off warnings messages ?

Messages like this
[vue-i18n] Value of key 'forms.fields.email_label' is not a string!

Options like ?
debug: false

This question is available on Nuxt community (#c390)

    vueI18n: {
      silentTranslationWarn: true,
      silentFallbackWarn: true,
    },

Why this message is outputted?


Content on "How to create a Python package"

Migrating an interesting discussion over from https://github.com/ProjectPythia/projectpythia.github.io/issues/43.
I think that the Foundations book could have an entirely new top-level section (after Core Scientific Packages) devoted to best practices for developing Python packages.
Tentatively, the chapter could be entitled "Building Python Packages", and have sections like:

tutorial on tests and testing
Good package structure (i.e., the structure of the files and folders in the repository)
Building documentation
CI services like GitHub Action (for testing, linting, etc.) and ReadTheDocs (for building and hosting documentation)
Using pre-commit hooks and other enforcing tools (including various pre-commit checks like black/prettier, flake8, isort, talisman, etc.)

I'm not 100% sure if this is in-scope for the Foundations book, but it could be really useful to have self-contained tutorials on all this material cross-referenced with our tutorials on conda, git, GitHub pull requests, etc.

It bears repeating here, @jbusecke has already done much of this work over at https://github.com/jbusecke/cookiecutter-science-project
and we could easily adapt many of the instructions from his README.

Is there already a skeleton for this kind of documentation? I was just wondering if I should add more info to my readme (which should really be a full docs page at this point) or already move over to a more general space.

Is there already a skeleton for this kind of documentation? I was just wondering if I should add more info to my readme (which should really be a full docs page at this point) or already move over to a more general space.

We now have a template notebook for new contributions to the Pythia Foundations book: https://foundations.projectpythia.org/preamble/template.html
What I proposed above was to add an entirely new top-level section to the book, with individual sections delivering content in line with our template. I could quickly rough this out in a PR with some tentative section headings if that will help get things rolling.

At the EWG meeting today (9/30/2021) we batted around the idea of getting started with a separate gallery or "cookbook" section of the Pythia Portal that could house material that doesn't belong in Foundations for whatever reason. That could be the right place for this content.


no implicit conversion of String into Hash

When visiting /recurring_tasks UI, I'm getting an error:
mission_control-jobs (0.3.0) lib/active_job/queue_adapters/solid_queue_ext/recurring_tasks.rb:29:in `merge'
mission_control-jobs (0.3.0) lib/active_job/queue_adapters/solid_queue_ext/recurring_tasks.rb:29:in `each'
mission_control-jobs (0.3.0) lib/active_job/queue_adapters/solid_queue_ext/recurring_tasks.rb:29:in `reduce'
mission_control-jobs (0.3.0) lib/active_job/queue_adapters/solid_queue_ext/recurring_tasks.rb:29:in `recurring_tasks_from_dispatchers'
mission_control-jobs (0.3.0) lib/active_job/queue_adapters/solid_queue_ext/recurring_tasks.rb:7:in `recurring_tasks'
....

My recurring tasks config in config/solid_queue.yml:
default: &default
  dispatchers:
    - polling_interval: 1
      batch_size: 500
      recurring_tasks:
        solid_queue_cleaner_job:
          class: Cron::SolidQueueCleanerJob
          schedule: every day at 07:00 UTC
        expired_plans_cleaner_job:
          class: Cron::ExpiredPlansCleanerJob
          schedule: every day at 08:00 UTC

SolidQueue::Process.where(kind: "Dispatcher").last.metadata
=> {"polling_interval"=>1, "batch_size"=>500, "concurrency_maintenance_interval"=>600, "recurring_schedule"=>["solid_queue_cleaner_job", "expired_plans_cleaner_job"]}

solid_queue: 0.5.0
mission_control-jobs: 0.3.0

Oops, sorry @morgoth! I had pushed a fix for this one but hadn't published a new version. Could you update to version 0.3.1 and see if that fixes it?

Just hit this and confirm 0.3.1 fixes it for me

Yes, this is fixed. Thank you


Add file size column to dataset table

Done

Great thanks! @BenjaminMorrell  shouldn't be done for hvm as well?

Yeah probably
On Fri, Jun 3, 2022, 11:53 Andrzej Reinke @.***> wrote:

Great thanks! @BenjaminMorrell https://github.com/BenjaminMorrell
shouldn't be done for hvm as well?
—
Reply to this email directly, view it on GitHub
https://github.com/NeBula-Autonomy/nebula-odometry-dataset/issues/7#issuecomment-1146267275,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEHOT6O4AA4F2EWEACRPHP3VNJIBNANCNFSM5XZOJFQQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


GCP deployment

It seems likely we'll need to deploy to GCP. We could use cloud run and hosted database / redis.
CI integration would be nice but is not necessary, so it would make sense to prioritize whatever is the minimal effort way of getting this up and running for demo purposes.

It's worth calling out that we will have custom changes to SuperAGI. One thing we might do here is take the base SuperAGI image and copy in the files we need to create a final container, then deploy that. Part of this ticket is also creating a solution for getting our custom changes deployed.


RootClientEnabled: "true" not working  with PowerScale CSI Driver v1.2.0

It's PowerScale H700 storage environment, with K8S cluster v1.16 and Powerscale CSI Driver v1.2.0.
As requested, we need to provide root access to Persistent Volumes in Pods, using the PowerScale CSI Driver previously installed with RootClientEnabled: "false".
Then, we created a new StorageClass, changing RootClientEnabled to "true" as below:
allowVolumeExpansion: true
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  annotations:
    meta.helm.sh/release-name: isilon
    meta.helm.sh/release-namespace: isilon
    storageclass.beta.kubernetes.io/is-default-class: "false"
  labels:
    app.kubernetes.io/managed-by: Helm
  name: isilon-core
parameters:
  AccessZone: System
  AzServiceIP: service.sycoreisilon.bj.bob
  IsiPath: /ifs/data/csi
  RootClientEnabled: "**true**"
provisioner: csi-isilon.dellemc.com
reclaimPolicy: Delete
volumeBindingMode: Immediate

After the new StorageClass created, and new PVC created and mounted, it showed that the mount point in Pod is still owned by nobody (id 99). From PowerScale H700 UI, both the "Root Client" and "Client" are empty. Look like RootClientEnabled: "true" is not working as expected.
Is there any workaround to fix it? Is it a version issue?
Thanks a lot,
RyanBao

Thanks @RyanBao for reaching out !
RootClientEnabled: "true" , hope these "*" are not there in SC definition.
Need some more details to understand the real failure.

Describe SC o/p
Describe PVC
kubectl get pvc,po -n  {to fetch the status of that particular pvc and pod}
Driver controller and corresponding node log where pod is running.

Thanks for the help.
The "*" was not originally there, I expected it would make the word in bold text...
Some of the info about the test were cleared after the failure, will re-collect again later.

I've just tested again in another environment with CSI Driver 2.0 + PowerScale Simulator,  chown operations in Pod is working after Root User Mapping is configured in Global Unix Sharing -> Export Settings, no matter RootClientEnabled is "true" or "false".
Just curious what the parameter RootClientEnabled do? Is it a MUST setting to get the root privilege of changing ownership of the mounted PV in Pods?
Thanks.

Ideally not.
Pls share me all requested data so can deep dive and see why its not giving expected results.

Considering it's not easy to test and collect info in production, we're going to follow the findings in CSI 2.0 test environment:

keeping RootClientEnabled with the default "false" in StorageClass
Enable root mapping for NFS shares in Isilon
Disable NFSv4 in Isilon to make the file/folder owner showed as "root:root" in Pods

Will update the result later when it's done.
Many thanks for the help.

Thanks @RyanBao.
I'm still curious to know what causing you to trouble using "RootClientEnabled" where results are not as expected.
Let us know if you have the similar issue in future and would be of any help there.
For now I'm closing this case and pls open new one for later issues. Hope this is fine with you.


added simple Tests

created github action amed ci

check code style with flake8
test with pytest

Thanks for the PR!
This project isn't meant to be actively developed, it's basically a tutorial on how ASGI works, so I don't think we need an automated CI here. Also the idea was to keep it minimal and dependency-free, adding linters or test frameworks would break that

I like to develop it. Please pass methe ownership(if you like)

This project is just an example, so there's nothing to develop here. If you want to create a full-featured framework based on this code, you can fork it

I like to publish it as nanoasgi?

Well, if you will develop it it won't be nano anymore ;)

Can I use the name nanoasgi

Yes


Note Date Issue?  Old notes showing up as 2001

A high school counselor alerted me that some of Jill's old notes from Healey are showing up with a 2001 date.   I've attached the snip of it.  LMK if you want a specific name, but it looks like it's with a few kids.

This was from the "revision" mechanism but was fixed a long time ago.


Casting int32_t* to int* in call to  tflite::PopulateConvolutionQuantizationParams

All calls to  tflite::PopulateConvolutionQuantizationParams seem to cast the per_channel_output_shift param from int32_t* to int*.
For example https://github.com/tensorflow/tflite-micro/blob/main/tensorflow/lite/micro/kernels/depthwise_conv_common.cc#L116
This is not causing problems currently, but I expect that it may be a source of future bugs.

Yeah, I have been puzzled by this in the past as well. The not completely satisfying answer is that TfLite and TFLM currently implicitly assume that ints are 32 bit.
In this particular case we have two different functions that expect per_channel_output_shift to be an int* and an int32_t*
https://github.com/tensorflow/tflite-micro/blob/68dd0cf4ff9b46f8ff7e0fb2a416714fb0ba0f2b/tensorflow/lite/micro/kernels/depthwise_conv.cc#L71-L73
https://github.com/tensorflow/tflite-micro/blob/68dd0cf4ff9b46f8ff7e0fb2a416714fb0ba0f2b/tensorflow/lite/kernels/internal/reference/integer_ops/depthwise_conv.h#L22-L24
https://github.com/tensorflow/tflite-micro/blob/f583f92992c3c9dfb8e10f36d66b2fe7267cf7bc/tensorflow/lite/micro/kernels/depthwise_conv_common.cc#L111-L117
https://github.com/tensorflow/tflite-micro/blob/68dd0cf4ff9b46f8ff7e0fb2a416714fb0ba0f2b/tensorflow/lite/kernels/kernel_util.cc#L210-L215

I suppose 32 bit integers are a fairly safe assumption, but it would be nice to make the type names consistent.
Would you be open to a patch to make the PopulateConvolutionQuantizationParams() per_channel_shift parameter an int32_t* , and remove the reinterpret_cast<>s ?

Yeah, that's going to help. The change to PopulateConvolutionQuantizationParams will have to go in the tensorflow/tensorflow repo and it will then get synced to the current repo automatically.


staking: npos reward account

I would be nice if the npos reward pool account address would be a human readable one that obviously has no possible private key associated with it.
Besides the fact that is is very clear, no private key that can leak or kept secret is present

The Base58 alphabet consists of the following characters:
123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz

@DylanVerstraete can you try this address starting from the genesisconfig?

documented in https://github.com/threefoldtech/tfchain/blob/cae0866df24d4b0b1e72422d997750f4dc6ad593/substrate-node/doc/initliazing_staking_module_genesis.md#configure-stakingpoolaccount


Single DOI landing page

In the PFSes there's often this terminology

Information on X should be available in the metadata as a single DOI landing page

A couple of questions:

Does this necessarily need to be a DOI landing page? (i.e. doi.org/...) If I want to create STAC based metadata and the page from ESA for example has no DOI, I'd need to register a DOI for ESA, which feels wrong.
What are the implications on the amount of DOI landing pages? Is it a maximum of 1 per product? Is it a maximum of 1 per requirement? If it's the latter, does it need to be a clear how the landing pages relates to the requirements?

Let's looks at an example: The ESA Sentinel-2 L2A data was peer-reviewed to be CEOS ARD compliant.
It seems to have a single DOI landing page in the metadata - i.e. https://doi.org/10.5270/S2_-znk9xsj - in the XML PRODUCT_DOI tag. That I find this DOI landing page there, how do I know this as a user?
As a user that is looking to find the e.g. the information about water vapour (req. 3.5), I have to assume I find that under this page. If there would be two DOI pages in the metadata, it seems I'd need to look at both at there's no necessarily a need to document what the individual DOI pages are meant to provide information about.
As I have only one DOI this time, I'm looking at https://doi.org/10.5270/S2_-znk9xsj . The page says that water vapour maps are included, but doesn't give details about the algorithm as required by 3.5. It generally says "Algorithm used: Sen2Cor – Version 2.10". That's rather uninformative with regards to the requirements, it doesn't list a citable paper without googline Sen2Cor – Version 2.10.
Are people expected to read self-assessments and randomly walk around DOI landing pages? I feel this is not solving what it was meant to solve.

Hi Matthias, thanks for your questions!
Regarding the need for a DOI: It should be the provider of the information (in this case ESA) who creates the DOI, not the one assembling a STAC catalogue.
More tricky is the question on the amount of DOI's to be created. We will first need to specify more uniquely what we mean by 'product' which is the entity we ultimately award the 'CEOS-ARD' label.
Next we would need to talk about about whether to harmonise the metadata labels (irrespective of their format) where PFS relevant info is associated to. To my knowledge this is not the case in any PFS so far.
Then comes the metadata content and whether this has to comply with certain standards. For many fields this is not the case (yet).
Ultimately, and that's one of the most challenging issues, we need to define some hierarchy and relations (a sort of ontology) in metadata as otherwiose we'll never finish discussing what needs to be provided where in what detail. That's certainly something I want to raise when meetiong in Delft for the OGCISO ARD SWG where this will be crucial (in my opinion).

Regarding the need for a DOI: It should be the provider of the information (in this case ESA) who creates the DOI, not the one assembling a STAC catalogue.

So I can't create a CEOS ARD compliant STAC catalog for Sentinel-3 for example if ESA doesn't provide me with a DOI?

Well my take would be that it is a product which is certified as 'CEOS-ARD'. While we still need to better define what a 'product' exactly is, it will definitely be more than a catalogue or just metadata. So, you can create a STAC catalogue by harvesting all or parts of the Sentinel-3 archive, but that catalogue is not what qualifies the S3 product to be 'CEOS-ARD'.
If a provider chooses not to fulfill certain threshold criteria by withholding information, his product is not 'CEOS-ARD' regardless on how the metadata are presented. If you as an interim entity undertake to fill this gap and meet all threshold requirements (by e.g. creating missing metadata or setting up a DOI) you become the provider and it is 'your' (derived) product that might be granted 'CEOS-ARD' status, if you file an application.

Just flagging that this DOI requirement is also being question in the Ocean Reflectance PFS development.


Swift 5/Xcode upgrade broke my ability to compile Realm

!!! MANDATORY TO FILL OUT !!!

Goals
My app should compile as it did under Swift 4.2.1
Expected Results
App should compile normally
Actual Results
/Users/jonathansilverman/Library/Autosave Information/MixDJ/Pods/Headers/Private/Realm/Realm.h:21:9: 'Realm/RLMArray.h' file not found
Could not build Objective-C module 'Realm'
Steps to Reproduce
Make a Swift 4.2.1 project and import Realm. Then load in new Xcode and try to compile.
Code Sample
I'm not sure a code sample is required but let me know if any code is needed and I'll be happy to provide it.
Version of Realm and Tooling
Using Realm (3.13.1)
Using RealmSwift (3.13.1)
Realm Object Server version: Not sure how to get this
Xcode version: Version 10.2 (10E125)
iOS/OSX version: 12.1.4
Dependency manager + version: Cocoapods 1.7.0.beta.1

You'll need to upgrade to Realm 3.14.0 to use Xcode 10.2.

Thanks @tgoyne.
Where do I get that pod from?
[!] The version of CocoaPods used to generate the lockfile (1.7.0.beta.1) is higher than the version of the current executable (1.5.2). Incompatibility issues may arise.
Analyzing dependencies
[!] CocoaPods could not find compatible versions for pod "RealmSwift":
  In Podfile:
    RealmSwift (= 3.14.0)

None of your spec sources contain a spec satisfying the dependency: `RealmSwift (= 3.14.0)`.

You have either:
 * out-of-date source repos which you can update with `pod repo update` or with `pod install --repo-update`.
 * mistyped the name or version.
 * not added the source repo that hosts the Podspec to your Podfile.

Note: as of CocoaPods 1.0, `pod repo update` does not happen on `pod install` by default.

[!] [!] Xcodeproj doesn't know about the following attributes {"inputFileListPaths"=>[], "outputFileListPaths"=>[]} for the 'PBXShellScriptBuildPhase' isa.
If this attribute was generated by Xcode please file an issue: https://github.com/CocoaPods/Xcodeproj/issues/new

[!] Automatically assigning platform `ios` with version `12.1` on target `MixDJ` because no platform was specified. Please specify a platform for this target in your Podfile. See `https://guides.cocoapods.org/syntax/podfile.html#platform`.

Attempting "pod update" now.

As the error says, you need to run pod repo update.

In progress. I’ll report back soon
On Thu, Mar 28, 2019 at 12:37 PM Thomas Goyne<EMAIL_ADDRESS>wrote:

As the error says, you need to run pod repo update.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/realm/realm-cocoa/issues/6117#issuecomment-477721266,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABo96_UqvybYvOBys82YrjK_hZq5PJnoks5vbQv3gaJpZM4cQ2RP
.

--
Jonathan Silverman
tel:<PHONE_NUMBER>

Same error after both pod update and pod repo update

Here is a picture of my current state:
https://pasteboard.co/I7AGfMx.png

Those warnings about xcconfig files not being found are not harmless and indicate that there's something wrong with cocoapods's integration with your project. Running pod deintegrate and then pod install may fix things.

Still seem to get the same error.

Turned out to be a Cocoapods corruption. I removed Cocoapods and switched
to Carthage. That error has disappeared but I need to include a
Non-Carthage small Cocoapods project. I should be able to do that on my own
soon/
On Thu, Mar 28, 2019 at 7:24 PM Thomas Goyne<EMAIL_ADDRESS>wrote:

Those warnings about xcconfig files not being found are not harmless and
indicate that there's something wrong with cocoapods's integration with
your project. Running pod deintegrate and then pod install may fix things.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/realm/realm-cocoa/issues/6117#issuecomment-477829571,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABo961IynFy58NOgSs7FYlbK8JEIuWn1ks5vbWtQgaJpZM4cQ2RP
.

--
Jonathan Silverman
tel:<PHONE_NUMBER>


Fix for https://github.com/andreacremaschi/GEOSwift/issues/11 and a few more tweaks

This PR attempt to fix https://github.com/andreacremaschi/GEOSwift/issues/11 and contain also a few other minor tweaks

Merged on develop


Pod Lifecycle

Under the 'Container restart policy' it states "After containers in a Pod exit, the kubelet restarts them with an exponential back-off delay (10s, 20s, 40s, …), that is capped at five minutes."
The back-off delay actually starts at 0s which causes an instant restart.
Please change the back-off delay to '(0s, 10s, 20s, 40s, ...)' so that people know there is no back-off the first time a container fails and restarts.

Page related to issue:  https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/
/language en

Hii there folks.. Can I work on this issue?


chore: use container to build preview

chore: use the same container to build local preview and GitHub preview.
Signed-off-by: Fabrice Flore-Thébault<EMAIL_ADDRESS>

Commit amended for DCO.

@rkratky @schultzp2020 @jc-berger @HarshCasper I believe now it is ready for merge.
@HarshCasper thanks for the surge workflows, I have reused most of it in https://github.com/antora-for-modular-docs/antora-for-modular-docs/tree/main/.github/workflows


Fixed Img Link

*/ Fixed Link Mistake

Testing in my fork

Wait what, https://vutondesign.com/mymit/.


Display subscribed msg

Description
Displayed subscribed msg and error msg
Fixes #822
Replace issue_no with the issue number which is fixed in this PR
Screenshots

Checklist

[x ] Tests have been added or updated to cover the changes
[x ] Documentation has been updated to reflect the changes
[x ] Code follows the established coding style guidelines
[x ] All tests are passing

That's not we are looking for
Try this : https://www.youtube.com/watch?v=8JTrY1dlXCw
https://www.youtube.com/watch?v=ekml6vcDwWY

Ok @thestarsahil I'll make the changes and raise a new PR for it..


Time zone not working

SELECT * FROM "event" WHERE time > now() - 5d and Id = 'xxxx' tz('Asia/Shanghai')
TZ ('Asia/Shanghai') time zone does not work
client.py #line 165
self._headers = {
'Content-Type': 'application/json',
'Accept': 'application/x-msgpack'
}
I find that the problem is caused by setting Accept as application/x-msgpack, and it works normally when changing to application/json. I wonder if it is a bug？

could you please post the influx db, influx client versions and a sample data point that you're writing to the db so that it becomes easy to resolve the issue for the community?

Influx version 1.7.4
use the cq table test of the _internal database,
use SELECT * FROM "cq" WHERE time > now() - 5m or SELECT * FROM "cq" WHERE time > now() - 5m tz('Asia/Shanghai') test

The query seems to be running fine on my end.


deck: 1.38.0 -> 1.38.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/Kong/deck/releases.
meta.description for deck is: A configuration management and drift detection tool for Kong
meta.homepage for deck is: https://github.com/Kong/deck
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.38.1 with grep in /nix/store/cahq4kr9x7kmagh5503nbrzii2ir6nm1-deck-1.38.1
found 1.38.1 in filename of file in /nix/store/cahq4kr9x7kmagh5503nbrzii2ir6nm1-deck-1.38.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

deck

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/cahq4kr9x7kmagh5503nbrzii2ir6nm1-deck-1.38.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A deck https://github.com/r-ryantm/nixpkgs/archive/d5f51cfde2d05346867221bc14877b1a66e5c9ee.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/d5f51cfde2d05346867221bc14877b1a66e5c9ee#deck

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/cahq4kr9x7kmagh5503nbrzii2ir6nm1-deck-1.38.1
ls -la /nix/store/cahq4kr9x7kmagh5503nbrzii2ir6nm1-deck-1.38.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

deck

Maintainer pings
cc @liyangau for testing.

Result of nixpkgs-review pr 318610 run on aarch64-darwin 1

1 package built:

deck


Shard tests to support multiple browser tests and combine test report

Motivation
To reduce the (wall clock) time it takes to run our E2E tests. Context: For CI/CD, we intend to run (most) E2E tests prior to every push to main branch (running on a RDev stack). Since this will be more frequent than running only on deploy GHA jobs, the test test run time needs to be improved.
Definition of Done

e2e tests run in parallel with Chrome, FF, and Edge
Sharded test reports are merged

Tasks

[ ] Finish https://github.com/chanzuckerberg/single-cell-data-portal/pull/4926 and enable multi browser tests by upgrading PW and implement report merging

Notes:

Upgrade Playwright to 1.37 Github thread - NOTE: Upgrading Playwright might cause existing tests to fail, due to us importing tsx files. Something to look out for
PW Docs: https://playwright.dev/docs/test-sharding#merging-reports-from-multiple-shards

Currently parking the PR until Playwright fixes .only() bug in hopefully 1.38


feat(mongo): upgrade node-mongodb to v4

BREAKING CHANGE:
Some driver methods now have different return types,
e.g. rows are missing from nativeInsertMany().

Codecov Report

Merging #2425 (d9a891f) into master (9996a16) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            master     #2425    +/-   ##
==========================================
  Coverage   100.00%   100.00%
==========================================
  Files          188       188
  Lines        10533     10648   +115
  Branches      2308      2427   +119
==========================================
+ Hits         10533     10648   +115

Impacted Files
Coverage Δ

packages/core/src/connections/Connection.ts
100.00% <ø> (ø)

packages/mongodb/src/MongoConnection.ts
100.00% <100.00%> (ø)

packages/mongodb/src/MongoDriver.ts
100.00% <100.00%> (ø)

packages/cli/src/CLIHelper.ts
100.00% <0.00%> (ø)

packages/core/src/MikroORM.ts
100.00% <0.00%> (ø)

packages/core/src/utils/Utils.ts
100.00% <0.00%> (ø)

packages/core/src/EntityManager.ts
100.00% <0.00%> (ø)

packages/migrations/src/Migrator.ts
100.00% <0.00%> (ø)

packages/core/src/entity/Collection.ts
100.00% <0.00%> (ø)

... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9996a16...d9a891f. Read the comment docs.


Infrared support

Is it possible to support infrared via Switchbot hub?
Thanks.

probably not. Switchbot also hasn't released any documentation for local communication with the Switchbot hub. It all uses their API through cloud
This only works for Bluetooth BLE switchbot devices. My guess is the hub only uses WIFI? not sure, I don't own one
I personally use a Broadlink RM Pro+ for IR and RF and it has been flawless once I enabled local control for it. I know that doesn't help though if you already have the Switchbot hub


docopt incorrectly parses options in argv when these are passed together, e.g. in a script

$ cat s.py
from docopt import docopt

__doc__ = """
My cool script!

Usage:
  s -h | --help
  s one [options]
  s two [options]

Global options:
  --file=<path>          read file
  --verbose              turn on verbose output
  --sleep                go to sleep in the end

"""
opts = docopt(__doc__)
print opts

$ python s.py one --verbose --sleep
{'--file': None,
 '--help': False,
 '--sleep': True,
 '--verbose': True,
 '-h': False,
 'one': True,
 'two': False}

$ cat q.sh
#!/bin/bash
which=one
file="--file=path/to/file"
other="--verbose --sleep"

echo Running: python s.py "$which" "$file" "$other"
python s.py "$which" "$file" "$other"

$ chmod 755 q.sh
$ ./q.sh
Running: python s.py one --file=path/to/file --verbose --sleep
Usage:
  s -h | --help
  s one [options]
  s two [options]
$ #WTF

12 hours of head-to-wall-banging later:
sys.argv = ['s.py', 'one', '--file=path/to/file', '--verbose --sleep']
Here, the last parameter --verbose --sleep is not parsed correctly. As a result, Usage is printed which is not very helpful, as copying the result of echo and running it would do just fine.
Also, please consider adding more verbatim output of what exactly went wrong with the parameters instead of just printing usage string.

[~]$ cat "--show-ends --show-tabs" /etc/passwd
cat: unrecognized option '--show-ends --show-tabs'
Try 'cat --help' for more information.

Yes, this is how shells work overall. Here's a simplest example:
$ options="-l -h"
$ ls "$options"  # expands into: ls "-l -h" (which doesn't work)
ls: illegal option --
usage: ls [-ABCFGHLOPRSTUWabcdefghiklmnopqrstuwx1] [file ...]
$ ls $options  # expands into: ls -a -h (which works)
-rw-r--r--@    1 vladimir  staff    56K Sep 25  2014 README.txt

To debug this kind of issue you can define argv-of like this:
$ alias argv-of='ruby -e "p ARGV"'
$ argv-of ls $options
["ls", "-a", "-h"]
$ argv-of ls "$options"
["ls", "-a -h"]

cat: unrecognized option '--show-ends --show-tabs'

Note how easy it is to understand the issue, and how much time it should take to come up with the solution.

So come up with your own workaround if you want nonstandard, error-prone behavior.

I now understand that this is standard behaviour, there is no need to personally attack me, Oleh. All I'm advocating for currently is a better error statement that would allow the person to understand where the parsing went wrong. Something to the tune of
Unrecognized option: '--verbose --sleep'
Usage:
  s -h | --help
<...>

@keleshev it looks like I can't define alias in a script and use it. Gets me argv-of: command not found.

@mintigo-efi I'm in favor of better failure modes, although it can be difficult. The way that argv is matched against usage patterns makes it pretty tricky to describe why no match could be found. It's a more a binary "here's the usage that it matched or no match." I'd like to work on improving this some day. :)

Then describe where no match is found.
Here I am 12 hours later, running a job in Jenkins that configures another job with parameters that runs a shell script that runs Python script that uses docopt. Docopt parsing fails, and all I get from docopt is a dump of how to use my script, and I still have no idea why.

Then describe where no match is found.

That's what I just said was hard.

Here I am 12 hours later, running a job in Jenkins that configures another job with parameters that runs a shell script that runs Python script that uses docopt. Docopt parsing fails, and all I get from docopt is a dump of how to use my script, and I still have no idea why.

Yes. I just agreed with you. Better failure modes would be great.

@mintigo-efi regarding alias not working in script—you could use ruby -e "p ARGV" inline, or define a small Ruby/Python script that does that. Probably it's possible to write a bash function for that, but I tried that now and failed, so can't help here. In general I try to avoid writing shell scripts at all costs and use shell only for quick commands in the terminal, leaving any multi-line scripting to Ruby/Python.
Regarding docopt error-handling in general—I really want to improve it, I only wish I had more time.


Unable to create a connection with an additional connection options.

Connector version: v0.1.2-beta
Power BI Desktop version: 2.123.742.0 64-bit (November 2023)
How to reproduce:
Specify any valid option in connection options:
For example Timeout=600:
Details: "We cannot convert the value "Timeout=600" to type Record."

Hi @ne1r0n
We had a problem with converting the ODBC options.
I added a parser handler and validator.
Feel free to share any feedback you may have on #12.
I will add this change to release number 0.1.3-beta.


"You must have" prefix was on 1 of 2 prerequisites

@memildin : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @bmansheim


Suppress INVALID_MKV_DATA error and retry on zero Block

KVS returns INVALID_MKV_DATA if mkv doesn't contains Block.
It happens when no data is fed during the length of the fragment.

@seqsense/cloud_backend please take a look


Layout is broken on Blackbery Z10

It used to work fine.

Is secure.phabricator.com (which is running HEAD) also broken?
I don't think any of us have a Blackberry Z10, so we probably can't easily reproduce or fix this.

I'm curious what browser this is, right now we only support Chrome, Firefox, and Safari on mobile devices.
Blackberry looks free to test: http://us.blackberry.com/sites/developers/resources/simulators.html

I also thought Blackberry went out of business, but I guess the only mostly went out of business:

@andytruong that screenshot is the desktop layout. We detect and style mobile layouts differently. That detection code has not been in any recent changes (years).

It looks like the simulator requires VMWare Fusion on OSX, which costs approximately as much as buying a phone.

I have fusion, trying to get the VM running now

I haven't been able to get it running in VMWare. The image mounts and launches, but the screen never displays so I'm stuck. Their forums don't seem to have much guidance other than I might be running an unsupported video card....

OK, I did get the simulator running on an older Mac I have. It's a stock install, launched "Browser" and went to https://secure.phabricator.com/
Layout works as expected, mobile menus are displaying.

Hi,
I have just install Phabricator for my team and tried to see how it works on my phone (:

Is secure.phabricator.com (which is running HEAD) also broken?

No, secure.phabricator.com is good, but I found same issue with phabricator.wikimedia.org

Wikimedia renders correctly for me.


feat: do not create EN related resources when SM crn is passed

Description
issue: https://github.com/terraform-ibm-modules/dev-rag/issues/32

Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

:tada: This PR is included in version 1.18.0 :tada:
The release is available on:

GitHub release
v1.18.0

Your semantic-release bot :package::rocket:


Add feature to initialize project with dunner recipes

dunner init go_github_release

This command will initialize project with dunner recipe, present in dunner cookbook.

Codecov Report

Merging #93 into develop will increase coverage by 2.75%.
The diff coverage is 71.13%.

@@            Coverage Diff             @@
##           develop     #93      +/-   ##
==========================================
+ Coverage    59.04%   61.8%   +2.75%
==========================================
  Files            4       4
  Lines          315     411      +96
==========================================
+ Hits           186     254      +68
- Misses          89     107      +18
- Partials        40      50      +10

Impacted Files
Coverage Δ

pkg/initialize/initialize.go
67.44% <67.56%> (-3.99%)
:arrow_down:

internal/util/util.go
76.11% <73.33%> (-23.89%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8822994...8dcee46. Read the comment docs.

You also have the List Receipts feature also in this PR, right? Mention that also in the description.


add example for transaction replay to CLI docs

Description
Adds example to CLI documentation for transaction replay. I will add a link to this example in the newsletter once this is merged
Test Plan
How did you test the new or updated feature?

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] protocol change
[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

Looks good, thanks Laura!


Implement parallelization V.1, i.e., 2-3 docker simulations at the same time.

A simple parallel simulation job manager has to be implemented that allows for simulation jobs to be added to the queue, and assign them to a known pool of workers (simulators).

The parallelization has been implemented and works for a small number of evaluations. However, when running a longer search with population sizes of 10, the code raises the following exception:
concurrent.futures.process._RemoteTraceback:
"""
Traceback (most recent call last):
  File "/usr/lib/python3.8/concurrent/futures/process.py", line 239, in _process_worker
    r = call_item.fn(*call_item.args, **call_item.kwargs)
  File "/home/sepehr/AV/MLCSHE/MLCSHE/simulation_manager_cluster.py", line 112, in _process_sim_job
    self.get_results(container, simulation_log_file_name,
  File "/home/sepehr/AV/MLCSHE/MLCSHE/simulation_manager_cluster.py", line 413, in get_results
    self.copy_to_host(container, file_name, source_path, destination_path)
  File "/home/sepehr/AV/MLCSHE/MLCSHE/simulation_manager_cluster.py", line 444, in copy_to_host
    pw_tar.extractall(dst_file_path)
  File "/usr/lib/python3.8/tarfile.py", line 2028, in extractall
    self.extract(tarinfo, path, set_attrs=not tarinfo.isdir(),
  File "/usr/lib/python3.8/tarfile.py", line 2069, in extract
    self._extract_member(tarinfo, os.path.join(path, tarinfo.name),
  File "/usr/lib/python3.8/tarfile.py", line 2141, in _extract_member
    self.makefile(tarinfo, targetpath)
  File "/usr/lib/python3.8/tarfile.py", line 2190, in makefile
    copyfileobj(source, target, tarinfo.size, ReadError, bufsize)
  File "/usr/lib/python3.8/tarfile.py", line 249, in copyfileobj
    raise exception("unexpected end of data")
tarfile.ReadError: unexpected end of data
"""

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "run_iccea.py", line 89, in <module>
    main()
  File "run_iccea.py", line 79, in main
    solution = solver.solve(
  File "/home/sepehr/AV/MLCSHE/MLCSHE/src/main/ICCEA.py", line 138, in solve
    cs_archive_gen, popScen, popMLCO = self.evaluate(
  File "/home/sepehr/AV/MLCSHE/MLCSHE/src/main/ICCEA.py", line 389, in evaluate
    cs_list_per_gen = self.evaluate_joint_fitness(complete_solutions_set)
  File "/home/sepehr/AV/MLCSHE/MLCSHE/src/main/ICCEA.py", line 308, in evaluate_joint_fitness
    self.num_sim, results = self.toolbox.compute_safety_cs_list(
  File "/home/sepehr/AV/MLCSHE/MLCSHE/problem.py", line 60, in compute_safety_value_cs_list
    results = start_computation(simulator)
  File "/home/sepehr/AV/MLCSHE/MLCSHE/simulation_manager_cluster.py", line 458, in start_computation
    results = [list(f.result()) for f in futures]
  File "/home/sepehr/AV/MLCSHE/MLCSHE/simulation_manager_cluster.py", line 458, in <listcomp>
    results = [list(f.result()) for f in futures]
  File "/usr/lib/python3.8/concurrent/futures/_base.py", line 437, in result
    return self.__get_result()
  File "/usr/lib/python3.8/concurrent/futures/_base.py", line 389, in __get_result
    raise self._exception
tarfile.ReadError: unexpected end of data

The log file and the console output of the run are below:
20220717_150908_CCEA.log
typescript.log
Note that I have repeated the experiment twice and it still raises the same exception at the exact same time.

@SepShr May I ask what tar file we are reading above? I don't understand why we have an error tarfile.ReadError: unexpected end of data...

I don't know what tar files are used, but the error could be because of trying to read/access a tar file before the writing/generating of the file is completed. Or, different processes/threads try to read/write on the same tar file. Can you check if this would be the case?

Apologies for the incomplete explanation. So, docker-py only has methods to communicate tar files between the host and the container using put_archive() and get_archive(). Thus, the simulation results and the finished.txt file and communicated as a tar file.

So, the tarfiles are not shared between processes as far as I know. Also, the code transfers the results after the container is stopped. However, I have to make sure that whether the process is blocked until the container is stopped or not. If not, it might be the case that it is trying to copy a file before it is fully available. However, it is still weird that this only happens at a certain point repeatedly.

Does it happen at a certain point repeatedly? If so, it could be that a problematic tar file (including an irregular character/byte) is generated at that certain point, possibly related to a compatibility/encoding issue. Can you have the last tar file when the error occurs? Is it readable through get_archive() if you access it independently?

It has happened at the same point twice. All tar files are extracted using the function copy_to_host() in simulation_manager_cluster.py. The thing is, I am not even sure during which process it was trying to copy the results, since all the processes had just ended and the results were successfully recorded.

Hi,
So, I profiled the memory consumption of the algorithm using mprof and the findings are as follows:
Our current version, receives a batch of jobs, runs them using a ProcessPoolExecutor and returns all the simulation results at the end. Basically:
def start_computation(sim_manager, max_workers: int = cfg.max_workers):
"""Runs the simulation jobs in parallel and returns the results.
"""
    with concurrent.futures.ProcessPoolExecutor(max_workers=max_workers) as executor:
        futures = {executor.submit(sim_manager._process_sim_job, sim_job): sim_job
                   for sim_job in sim_manager.job_list}
        logger.info('jobs submitted')
        for future in concurrent.futures.as_completed(futures):
            logger.info(f'Run {futures[future]} did finish')
        results = [list(f.result()) for f in futures]
        del futures
        sim_manager.job_list.clear()
        gc.collect()
    return results

For this version, the memory profile is provided below:

As shown in the figure, memory consumption is almost steady except for the peaks that increase over time.
Another alternative is to split the inputs into batches and submit and run the simulation to a new ProcessPoolExecutor for each batch. Interestingly, as shown in the figure below, this is worse and the average memory consumption increases multiple fold.

There is another alternative where you keep the same ProcessPoolExecutor and submit jobs in batches. I will try that as well and provide report the results.

The following code works well on my local machine, without any error:
import docker
import tarfile
from io import BytesIO
from datetime import datetime

# initialize docker container
client = docker.from_env()
container = client.containers.run(
    image="donghwan/docker-python-copy-test:v1",  # a test docker image
    detach=True,
)

# copy files to host
files = [  # two files in the docker container
    '/working/20220809_145238_sim_pylot_1.log_ex.log',
    '/working/finish.txt'
]
timestamp = datetime.now().strftime("%Y%m%d_%H%M%S")
for f in files:
    ret, stat = container.get_archive(f)
    filelike = BytesIO(b"".join(b for b in ret))
    with tarfile.open(fileobj=filelike) as tar:
        tar.extractall(f'./results_{timestamp}')

# remove container
container.remove()

I didn't use Mount and it still works. I am not sure if we really need it in this case.


endpoint.hpp: allow custom packet id implementations

Currently endpoint uses a mutex and a monotonic increasing packet id.
There are other possible packet id strategies.
For example: An implementation with a known-ahead-of-time number of threads, might want break the packet id into two parts, a prefix (1 or more bits) and an id (the rest of the packet id's bits) and use thread-local-storage to track the increment of the id portion of the packetid. This would guarantee no two threads can ever generate the same packet id, with the benefit of not needing a mutex, but it would come at the cost of increased complexity and a smaller packet id space per thread.
Another example: A cluster implementation where the packetid to use is determined by another process on a separate computer.
A third example: The packet ID is queried from a database
I'd like to see the packet ID concept be improved in one of the two following ways:

Remove endpoint.hpp's ability to generate it's own packet ids entirely, and require this functionality be handled by a derived class. (e.g. see #192, which talks about decomposing endpoint.hpp into an endpoint_base.hpp and endpoint.hpp)
Require a new template argument (with default implementation) that supports the following functions
2.1 PacketId_t get_packet_id(void)
2.2 void release_packet_id(PacketId_t id)
2.3 bool reserve_packet_id(PacketId_t id)

I think that separating PacketId management mechanism is a good idea :)