Make sure that scala proto files are generated correctly for external proto dependencies

Problem
scalapb_proto_library will not work with proto_library_targets that are imported from an external repo. The reason is that bazel's proto_library expects proto files to import external files while omitting the external/<repo name>/ bit from the file name. In addition to this java conversions will not work for the final scala library because of the fact that java_proto_library generates a separate external jar for external dependencies that scala_library cannot pull in transitively.
Solution
Two steps:

Pass in the repo_root as well as the proto path for each proto file to be compiled and use a -I flag in protoc to map the actual location of proto files to the one that omits the repo root prefix.
Don't automatically generate the java_proto_library dependency if with_java is true, but expect it to be passed as part of deps.

@johnynek @ittaiz let me know what you think

Can one of the admins verify this patch?

Right Kristina was working on it but that's a hard work. It still has to
ship in the following months hopefully.
On Tue, Oct 3, 2017, 7:17 PM P. Oscar Boykin<EMAIL_ADDRESS>wrote:

@johnynek commented on this pull request.
In scala_proto/scala_proto.bzl
https://github.com/bazelbuild/rules_scala/pull/294#discussion_r142546988
:

@@ -414,7 +414,7 @@ Example:

Args:
name: A unique name for this rule

deps: Proto library targets that this rule depends on (must be of type proto_library)

deps: Proto library targets or jvm targets that this rule depends on

this can't be any jvm target, right? You are expecting java_proto_library?
In src/scala/scripts/ScalaPBGenerator.scala
https://github.com/bazelbuild/rules_scala/pull/294#discussion_r142547124
:

@@ -39,7 +39,20 @@ class ScalaPBGenerator extends Processor {

def processRequest(args: java.util.List[String]) {
val jarOutput = args.get(0)

val protoFiles = args.get(1).split(':').toList

val parsedProtoFiles = args.get(1).split(':').toList.map { rootAndFile =>

 val parsed = rootAndFile.split(',')

 val root = parsed(0)

 val file = if (root.isEmpty) {

   parsed(1)

 } else {

   parsed(1).substring(root.length + 1)

 }

 (file, Paths.get(root, file).toString)

}
val imports = parsedProtoFiles.map { case (relPath, absolutePath) =>

can you comment what these are doing?
In scala_proto/scala_proto.bzl
https://github.com/bazelbuild/rules_scala/pull/294#discussion_r142547224
:

@@ -414,7 +414,7 @@ Example:

Args:
name: A unique name for this rule

deps: Proto library targets that this rule depends on (must be of type proto_library)

deps: Proto library targets or jvm targets that this rule depends on
with_grpc: Enables generation of grpc service bindings for services defined in deps
with_java: Enables generation of converters to and from java protobuf bindings

to do this you must also depend on the java_proto_library? Is that right?
Should we update this comment?
In README.md
https://github.com/bazelbuild/rules_scala/pull/294#discussion_r142547384
:

@@ -498,7 +498,7 @@ generated by the ScalaPB compiler.
deps

List of labels, required

List of proto dependencies that this target depends on. Must be of type proto_library

List of dependencies for this target. All targets of type proto_library are passed to scalapb for compilation. All other targets are used to compile the final output scala library

can these really be any generic target if not proto?
Is it anything that you might need to do the with_java, is that it?
In scala_proto/scala_proto.bzl
https://github.com/bazelbuild/rules_scala/pull/294#discussion_r142547900
:

@@ -445,20 +445,12 @@ def scalapb_proto_library(
)

 external_deps = list(SCALAPB_DEPS + GRPC_DEPS if (with_grpc) else SCALAPB_DEPS)

if with_java:

   java_proto_lib = name + "_java_lib"

   native.java_proto_library(

       name = java_proto_lib,

       deps = deps,

       visibility = visibility,

   )

   external_deps.append(java_proto_lib)

scala_lib_deps = external_deps + deps

do you not need the transitive compile time dependencies of any of the jvm
code?
Also, I think we want to filter this so that we only include the non-proto
deps. Otherwise, casual formatting changes to the proto that don't change
the compile output will cause a recompilation.
In scala_proto/scala_proto.bzl
https://github.com/bazelbuild/rules_scala/pull/294#discussion_r142548141
:

@@ -308,12 +308,13 @@ def scala_proto_repositories():
)

def _colon_paths(data):

return ':'.join([f.path for f in data])

return ':'.join(["{root},{path}".format(root=f.owner.workspace_root, path=f.path) for f in data])

this is making me nervous, but maybe that's the only way to go here.
There was an old doc about fixing these kinds of issues about cross
workspace dependencies like 1.5 years ago or so, but I don't think they
actually ever did anything about it, unless I'm mistaken:
cc @damienmg https://github.com/damienmg I recall there was a plan to
put all the paths rooted with the project name. That never shipped right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_scala/pull/294#pullrequestreview-66924186,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADjHfxugl0YBjLtjdgtdwE-KNy8ZtY0Nks5sosBrgaJpZM4PsouD
.

@johnynek ok I think this is better: I changed it only accept proto_library and java_proto_library deps and pushed the logic of figuring out jar dependencies into the rule implementation.
Note: I had to modify a couple of scala.bzl methods to be public instead of private (and also deleted a method that could be removed in scrooge). Let me know if that looks ok.

Haven't had a chance to take a look unfortunately but turning private
scala.bzl methods to public sounds like a really bad idea.
It turns it to public API which will be hard to change.
Can we extract them out to a separate bzl and have it have limited
visibility so only internal rules_scala targets can use it?
We need to do this refactoring at some point since scala.bzl is a god file
On Wed, Oct 4, 2017 at 11:35 PM Argyris Zymnis<EMAIL_ADDRESS>wrote:

@johnynek https://github.com/johnynek ok I think this is better: I
changed it only accept proto_library and java_proto_library deps and
pushed the logic of figuring out jar dependencies into the rule
implementation.
Note: I had to modify a couple of scala.bzl methods to be public instead
of private (and also deleted a method that could be removed in scrooge).
Let me know if that looks ok.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_scala/pull/294#issuecomment-334281560,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABUIFw_polJS2_zPP7_qNjHGNvz5g9Ugks5so-wjgaJpZM4PsouD
.

@ittaiz happy to do this refactor. How can I limit a .bzl file to only be accessible from within this repo?

I think this is good.
We already had duplication about collection of jars and many scala/java related code want this.
The alternative is copy-paste.
I'm +1 on this PR.

Argyris,
The full docs are here
https://docs.bazel.build/versions/master/be/common-definitions.html but
essentially subpackages should be your friend.
Oscar,
Not sure I understand what you mean. Did you mean you're good without the
refactoring? To leave this code duplication in?
On Thu, 5 Oct 2017 at 0:52 P. Oscar Boykin<EMAIL_ADDRESS>wrote:

I think this is good.
We already had duplication about collection of jars and many scala/java
related code want this.
The alternative is copy-paste.
I'm +1 on this PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_scala/pull/294#issuecomment-334300490,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABUIF2B3iy1DmbzffwtzuLymWqztjroBks5so_4XgaJpZM4PsouD
.

@ittaiz how do you apply visibility to .bzl files? I thought that was for rules.
I am fine with the refactoring he has done as it stands now. If it is easy to mark bazel functions or files with visibility then great, but I didn’t know we could.

Right... my bad. I mixed up the two.
I actually saw an issue around this recently but it's obviously unsolved.
On Thu, 5 Oct 2017 at 10:32 P. Oscar Boykin<EMAIL_ADDRESS>wrote:

@ittaiz https://github.com/ittaiz how do you apply visibility to .bzl
files? I thought that was for rules.
I am fine with the refactoring he has done as it stands now. If it is easy
to mark bazel functions or files with visibility then great, but I didn’t
know we could.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_scala/pull/294#issuecomment-334382634,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABUIF05DPkBx4yrUz7npYVJGfp9BwI9tks5spIYbgaJpZM4PsouD
.

@ittaiz yup tests would be good but I think that would require adding an external repo dependency in WORKSPACE. Let me know if I should do that. Should I add a personal repo for this?

@azymnis you can have a nested WORKSPACE I think and use that in tests.
But this is a bit of a yak shave if you ask me. With a nested WORKSPACE I think you have to set up --deleted-packages or something to prevent the outer build from finding it.

@johnynek @ittaiz I'll let you two decide on this. If you feel very strongly that I should add tests for external, I will do so. The current tests at least prove that this doesn't break the non external use cases (which I suspect are much more common). I verified locally that this works for us.

personally I'm happy to merge and add an issue.
When we don't have good examples of how to do a test, I'm -1 on asking contributors to shave a new yak to fix a bug they can observe. If we can test it with existing or simple patterns I would say okay, but having used a nested workspace internally it is a pain, and I don't want to rush to it.

@johnynek seems like travis-ci had another transient download issue

sorry for the latency.


Enh new property skipUpdateOnClean for AttributeBehavior

Q
A

Is bugfix?
kind of

New feature?
yes

Breaks BC?
yes

Tests pass?
yes (new test added)

Fixed issues
#11002

Break BC since before this patch $model->save() would always execute an update query even when no  attributes were edited.

I don't think that option is needed.

@samdark it in case the user wants to configure it or another behavior requires to always trigger an update on the attributes. Example
class Store
{
     public function behaviors()
     {
         return [
             'blame' => [
                    'createdByAttribute' => 'seller_id',
                    'updatedByAttribute' => 'manager_id',
             ],
             'blameSuperVisor' => [
                    'skipUpdateOnClean' => false,
                    'updatedByAttribute' => 'supervisor_id',
             ],
         ];
     }
}

Also it helps to keep BC compatibility since now it only requires to change the option to false to have the exact same behavior as before.
If those arguments are still not enough, then just delete the property and simplify the if statement

OK. It makes sense.

@yiisoft/core-developers need a brief review.

We need a CHANGELOG line and a note in UPGRADE.md
Looks good to me

@samdark @SilverFire done

Merged! Thank you!


Have quickStartSecurity use a generated password

Currently we have a default username and password configured in our starter via quickStartSecurity. We should consider using an auto generated password for the inner loop and removing the qss config when deploying in the outerloop.

I believe the generation happens at server create time, so we may run into a problem since we are creating the server in the base dev image.

@awisniew90

I believe the generation happens at server create time, so we may run into a problem since we are creating the server in the base dev image.

No, we're throwing away the server we created and only saving the OL install.

Done.


Infinite loop when deleting watched namespace

This is due to the fact that the generic Fetch function isn't returning a k8s error and the reconcile loop is depending on it.

Fixed with https://github.com/halkyonio/operator/commit/0b84fbdcd9bb93a7d16ec29996b8c857910fd296


XSS in markdown renderer

Split out of #353
The markdown implementation is vulnerable to XSS. When viewing a markdown file, arbitrary scripts from this file can be executed. As an example, go to https://sheep.solidcommunity.net/public/ and click on the xss.md file, which will call print() as a XSS demonstration. The attacker then has the same privileges as mashlib (likely read, write and control).
A POC markdown file that will call print() when it is displayed:
# Hello

A relevant comment from @bourgeoa :

SoliOS is using https://github.com/markedjs/marked. They recommend to sanitize using https://github.com/cure53/DOMPurify

This should be moved to the sourcePane repository.
Whenever you create a new text file, mintNew: function inside of sourcePane.js is called to create/mint the file in question.
The code I am working on will utilize the DOMPurify library.
However, there are some future concerns.

Even tho this will fix future XSS storage exploits, how can we sanitize the already existing files on users pods?
Essentially those who are grandfathered in. You will have unsanitize files resting on pods, unless an some kind iterative approach can be used to query through each user's list of items in the storage area to sanitize them.

I think this issue should stay here, as the problem lies in rendering the markdown file as unsanitized html rather than saving the markdown file. The steps for an exploit are:

Evil user creates xss.md on the pod (including )
User opens xss.md in mashlib
Mashlib fetches markdown and converts it to html
Mashlib inserts html to document
The inserted html executes print(), as image loading fails (1234 is not an existing image file)

We can't control step 1. The evil user can create the markdown file with mashlib, solid-filemanger, a node script, or probably even directly appending to the users inbox. In the normal case this won't go through mashlib. Or, as you already pointed out, the files could be already existing on the pod.
However, we can sanitize the html at step 3. So if there is evil markdown, we convert it to html and remove the evilness before showing it to the user.
The conversion step is in the solid-panes repository: https://github.com/SolidOS/solid-panes/blob/6cc8fb8a5139d754b84c06e177b755fe61c0223a/src/humanReadablePane.js#L89-L99
So between line 94 and 95 the sanitization should happen.

@Otto-AA thanks
@chunt007 the sanitization process here only concerns rendering markdown to html and not the markdown source.In the future the chat should also render markdown and sanitization should apply.


CardCharge Exception

I have tried all I could but it throws an exception without specifying what to fix.
Why can't this library just generate a payment link? See this error, it;'s very vague "Your card charge call failed with message: An error occured while attempting to decrypt some parameter" How is this supposed to be helpful, I am very frustrated and angry rn. Which parameter is it trying to decrypt? is it my fault? is it the test cards? I don't know, somebody pls help.

No help on this anywhere like this problem doesn't exist, even after copying the payment flow on the docs to replicate the possible success, Infact I will prefer to just generate payment link like stripe and paypal does instead of processing the payments myself. But this library doesn't seems to do that.

Bugs are just everywhere on the platform, tried using flutterwave standard, Its returning "str.replace is not a function" imagine. tried ravepay.co, I am just tried at this point

Hello @azeez010, how are you making your request ?
Can you drop the code snippet.
I was having similar issue str.replace is not a function , which i just resolved.

So here is how I was able to get past this error:
First off, I checked this library documentation, i couldn't find anywhere it was documented to generate payment link ( i must've missed it or it's not included yet ), so my implementation was solely through httpx  library ( requests library can also work in this case or any other http client library ).
    request_headers = {
        'Authorization': f'Bearer {SK}',
        'Content-Type': 'application/json'               # <--- without this i got str.replace is not a function error
    }

    data = json.dumps({                              # <- without this json.dumps() i got server error from flutterwave
        "redirect_url": "https://your-redirect-url",
        "tx_ref": transaction_ref,
        "customer": customer,
        "amount": amount,
    })

Flutterwave Docs Ref

Hello @azeez010
Thank you for sharing how you resolved this. We definitely would look into improving the error messaging so the corrective steps are intuitive.
@spaceofmiah Thank you for helping out with the issue.


feat(operator): greaterThanOrEqual operator

PR for https://github.com/xFAANG/askql/issues/135

@km4 , just a hint: use this message and this file as an inspiration.

sure :) @czerwinskilukasz1 you have some generator for *.ask, *.askjson, *.askcode files?

@km4 , following Marcin's comment in another issue, please rename the resource to greaterThanOrEqual.

@km4 , as for test, I discovered that the syntax in the example test file I sent you a link to, doesn't really work yet.
Could you please watch changes in my PR for lessThanOrEqual and when it's approved, create similar tests?

I think it's all.


unclear explanation about feature branch at the end of §Scheduled triggers

At the end of the § "Scheduled triggers" there are explanation about the trigger of a release branch : "Because release was added to the branch filters in the main branch, but not to the branch filters in the release branch, the release branch won't be built on that schedule".
But then the next sentense is confusing because we are talking about a feature branch : "Only when the feature branch is added to the branch filters in the YAML file in the feature branch will the scheduled build be added to the scheduler.".
Shouldn't we be talking about the release branch also ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2ea2c851-bd1e-cddc-b4d0-e9f4112b8565
Version Independent ID: 07c23fdd-14b5-985b-1c63-3f26f3a216ad
Content: Configure schedules to run pipelines - Azure Pipelines
Content Source: docs/pipelines/process/scheduled-triggers.md
Product: devops
Technology: devops-cicd-process
GitHub Login: @steved0x
Microsoft Alias: sdanie

Yes, thank you for letting us know. This has been fixed.


Help developers better handle SQL errors

Problem
We sometimes want to handle SQL errors differently to return a proper error to the frontend. For example, we might want to display email already used if a unique violation is detected on the field. The current situation is that we have to check against an obscure error code (P2002 for example for unique validation failure) and then go into meta.target to get which field broke. Its never easy to extract meaningful stuff from ORM(-like) tools despite being a very common operation and I think it could be a factor of differentiation for prisma.
Propositions
I see two possible way of dealing more gracefully with that:

Create more custom error types in javascript and use instanceof to catch them. This would look like:

  try {
    const user = await prisma.user.create({ data });
    return res.status(204).send();
  } catch (err) {
    if (err instanceof PrismaUniqueViolationError) {
      return res.status(400).send('DUPLICATE EMAIL');
    }
    return res.status(400).send('BAD REQUEST');
  }

Create an enum of errors. This would look like

  try {
    const user = await prisma.user.create({ data });
    return res.status(204).send();
  } catch (err) {
    if (err.code === PrismaErrors.UniqueViolation) {
      return res.status(400).send('DUPLICATE EMAIL');
    }
    return res.status(400).send('BAD REQUEST');
  }

I also think there should be helpers to extract the problematic fields from the error. Something like:
if (err.code === PrismaErrors.UniqueViolation) {
    const duplicateFields = extractErrorFields(err);
    return res.status(400).json({ code: 'unique_violation', fields: duplicateFields});
}

Below is the content of https://github.com/prisma/prisma/issues/2122 which I opened after this issue (I didn't find this issue by searching for "error messages")
Problem

There is currently no easy way to handle different types of errors thrown by prisma client.

Currently it appears that all errors thrown by prisma client have error.name = 'Error'

The content of error.message can vary a lot depending on the configured errorFormat. This makes it hard to consistently handle messages.
There is no way to know all the possible errors that will be thrown

Solution

All errors thrown by prisma client should have a descriptive name
Add a field on all errors that always have a minimal error format regardless of the errorFormat config.

Example: error.shortMessage

All possible errors should be clearly documented

Examples
error.name === 'PrismaInputError'
error.shortMessage === 'Argument where of type ProductWhereUniqueInput needs at least one argument'
error.message === " /* ... long error message ... */"

error.name === 'PrismaConnectionError'
error.shortMessage === 'Failed to connect to database blah blah'
error.message === " /* ... long error message ... */"

error.name === 'PrismaDatabaseViolation'
error.shortMessage === 'unique constraint violated, id = 1 already exists, blah blah'
error.message === " /* ... long error message ... */"

My comments on this original issue:

I suggest this issue name be changed to include all prisma errors, not just SQL errors.
I think adding an error.code property is a good idea
I think any extra error information should be put directly on the error object in a way that doesn't require a helper method to extract.

@flybayer I think there already is an error.code property on their error object (not sure if it was added after your comment or not). The only problem I currently have is that there does not seem to be any clear reference material for me to be able to easily tell what exactly that error code means.
I was able to find this: Error Docs, but that doesn't appear to be very exhaustive.

If possible, I'd like to have something like this which I've initially proposed in #720:
try {
  await db.users.insert(newUser)
} catch (err) {
  if (err instanceof UniqueConstraintViolation) {
    // not sure if typescript can infer the error, but I think it can
    if (err.field == "email") {
      console.log("user already exists with this email")
      return
    }
    console.log("unique constraint violation on another field: " + err.field)
  }
}

Prisma Client (2.11.0) is returning the following for a composite unique constraint:

Exception: PrismaClientKnownRequestError2
code: 'P2002' 👍

I don't know where the "2" comes from because I see only PrismaClientKnownRequestError defined.
I vote for exception ConstraintError, code 'P2002'.
Also regarding a better error, there is this other issue:
https://github.com/prisma/prisma/issues/4072


updated year

*Created an html file for the Home page
*Styled the Home page for mobile and desktop mode
*Created an html file for the About page
*Styled the About page for both mobile and desktop mode
*Linked both the Home and About page using JavaScript.
*Created a README.md file
*Created a LICENSE.md file

Thanks for the feedback madam!
On Tue, Jul 9, 2024, 14:30 Nwanjoh Nalian Achei @.***>
wrote:

STATUS: REQUIRED CHANGES ♻♻
Hi @Henriettahenrietta https://github.com/Henriettahenrietta Good job
so far! I know you worked hard to implement this project, I really
appreciate the effort you put in! But there are some issues that you still
need to work on to go to the next project but you are almost there! [image:
0bd223a2b156e0eaf61a713e84c3d3b7]
https://user-images.githubusercontent.com/57408419/255594021-109e7375-12de-4f5b-9e29-79eefc52e35a.gif
To highlight 🍾

Code well structured💯 ✔
Good PR description ✔
Follow GitHub flow ✔

Required changes ♻ ♻

Check the comments under the review.

Kindly host your project on Github pages and add the link to live
website on your README file

The link to your license file is not working properly, kindly adjust
it

Please add the link of your loom video to your README file

Kindly adjust your mobile design to align with the figma design
Figma design
image.png (view on web)
https://github.com/Henriettahenrietta/Portfolio-2/assets/88759996/7008c2be-f1db-4487-9ae5-0879cf96b186
Your design

Please add a shadow at the bottom of your header
image.png (view on web)
https://github.com/Henriettahenrietta/Portfolio-2/assets/88759996/a94b7fd6-d7be-4cac-98e3-b70bee6edf6c

Mobile figma design
image.png (view on web)
https://github.com/Henriettahenrietta/Portfolio-2/assets/88759996/60d5b6ca-b8b3-4c7d-8297-ea0eaa95b5b0
Your design

Kindly adjust the gap between the images and the text
image.png (view on web)
https://github.com/Henriettahenrietta/Portfolio-2/assets/88759996/0375ceb4-2f47-4ee1-abd3-07b9bbc4ab30

The section should not be added to home page on the mobile version
of design. It is only on the about page for mobile version
image.png (view on web)
https://github.com/Henriettahenrietta/Portfolio-2/assets/88759996/64fadc08-b3f4-42a3-b95b-26769ce24247

Kindly adjust the header for the desktop version
Figma design
image.png (view on web)
https://github.com/Henriettahenrietta/Portfolio-2/assets/88759996/9802ff70-877b-4e70-bb8e-1ef51db77d99
Your design
image.png (view on web)
https://github.com/Henriettahenrietta/Portfolio-2/assets/88759996/f3bd9c99-af7a-4f6f-b383-49a24016fc0f
Figma design
image.png (view on web)
https://github.com/Henriettahenrietta/Portfolio-2/assets/88759996/bed194c9-519c-479b-9f55-f0219e8d4ead
Your design
image.png (view on web)
https://github.com/Henriettahenrietta/Portfolio-2/assets/88759996/2b9ddbfa-31e4-4075-add6-6138958088d9

Optional suggestions
_Every comment with the [OPTIONAL] prefix is not crucial enough to stop
the approval of this PR. However, I strongly recommend you to take them
into account as they can make your code better.

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if
something is not 100% clear. Please ping me @NalianAchei2020
https://github.com/NalianAchei2020 when you comment so I can receive
the notification or send a message to interns whatsApp group
Please, do not open a new Pull Request for re-reviews. You should use the
same Pull Request submitted for the first review, either valid or invalid
unless it is requested otherwise.
—
Reply to this email directly, view it on GitHub
https://github.com/Henriettahenrietta/Portfolio-2/pull/1#issuecomment-2217753119,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BGTUCG2PMLLKJZDUFYLNI2LZLPQYDAVCNFSM6AAAAABKNEHI22VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJXG42TGMJRHE
.
You are receiving this because you were mentioned.Message ID:
@.***>


Package versions have conflicting dependencies.

ERROR: Cannot install -r requirements.txt (line 13) and -r requirements.txt (line 4) because these package versions have conflicting dependencies.
The conflict is caused by:
chainlit 0.6.402 depends on click<9.0.0 and >=8.1.3
streamlit 0.89.0 depends on click<8.0 and >=7.0

Thanks for flagging this!
To sort it out with the updated versions (chainlit 1.0.0 and streamlit 1.29.0), tweak your requirements.txt like so:
chainlit==1.0.0
streamlit==1.29.0

@matteuscruz create a pull request—I'll gladly merge it.
Cheers!


If a tooltip is too large - try and centralise as much as possible

If the text is bigger than the canvas there's not much we can do, but in cases where the tooltip is just to the left/right of the canvas, we could centralise it more to try and fit within the whole width of the canvas:
Example screenshot: https://mduk.pw/RNFcZ2

This should already be addressed in v2.

Closing as v1 is mainly for bug fixes, see https://github.com/chartjs/Chart.js/blob/master/docs/08-Notes.md


Fix pythonic interface for numpy.finfo

Looks like this was still using an older getattr API, and wasn't being caught by the test because it gets optimised away.

LGTM, thanks!


Dont try to create a room with invalid handler

This PR include:

Correct patch for #84 + test.
A test still fails randomly even after #83, this should finally fix that.
Missing stub.restore() of a test introduced in #79.

Thanks a lot @Federkun! I've made some changes based on your pull-request.


Various recipe issues

Cornbread stuffing has 9 bars of hunger and 18 saturation, while the corn dog made out of it has 4 hunger and 7.5 saturation.

Tortilla chips no longer have a recipe (no picture but the chopping board recipe broke)
Stuffed pumpkin has 2 identical recipes

there are 2 recipes for raw tortillas with create

Very good mod, just wanted to bring awareness to some of these minor issues that seem to have come from the lastest update.

Stuff pumpkin isn't the only recipe duplicated by being copied to the Minecraft data subspace; corn_seeds_from_bag and corn_from_crate are also present there causing duplicate recipes with Minecraft as the recipe source.

Should be safe to close this one now!


Crash on setting tooltip

Crashes as soon as I start my app and the method play is called, but happens only if I am setting tooltip.
This is what I get always
No static field toolTip_container of type I in class Ltourguide/tourguide/R$id; or its superclasses (declaration of 'tourguide.tourguide.R$id' appears in /data/app

I'm not sure why you're encountering this.
Can you run the example of the project? Then you can compare what is different from your app vs. the example of TourGuide.
Besides, can you post your relevant code? Maybe I can spot something strange..

I drilled into it and found while adding it via gradle, the asset toolTip_container is missing, thats why it was happening.

Did you manage to resolve the issue?
You don't actually need to include toolTip_container, because this library is an aar type, so the resources (like layout) should already be included.

@worker8 I'm using 1.0.16-SNAPSHOT and also get the same problem....I simply followed the guide to setup.

I had the same problem. I had layout file called "tooltip.xml" in my app. So library was loading my layout and trying to find view with id toolTip_container, but there was none, since it wasn't layout from library. I changed file name of layout in my app, and now everything works.


[Backport] Require DATASOURCE WRITE access in SupervisorResourceFilter and TaskResourceFilter

Backport of #11680 to 0.22.0.

fyi decided not to backport because of https://github.com/apache/druid/pull/11680#issuecomment-917918247


Error: error parsing variable 'owner=platform' | %!w()

When using one of the examples (or my own query) of the graphQL command, the passing in of fields appears to be broken.
❯ opslevel graphql -f "owner=platform" -f "tier=tier_1" --paginate -a=".account.services.nodes[]" -q='
query ($endCursor: String, $owner: String!, $tier: String!) {
  account {
    services(first: 1, after: $endCursor, ownerAlias: $owner, tierAlias: $tier) {
      nodes {
        name
        aliases
      }
      pageInfo {
        hasNextPage
        endCursor
      }
    }
  }
}'
Error: error parsing variable 'owner=platform' | %!w(<nil>)

@rdohms can you please provide which version of the CLI you are using?  Thanks

Thanks @rdohms - I don't see anything sticking out at first glance looking at the code and some of the recent commits to that area.  So i'll throw this over to the engineering team to triage further.

Hi @rdohms, thank you for raising this bug. The fix has been added to the main branch and will be included in our next release 🚀


feat: add url-shortener example

Closes #3956

Looks great. One tiny comment

Good 👍🏻

THANK YOU! All changes merged 🥳
Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord.
You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub.
You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile.
Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :)


Fixes Issue #587

Fixes Issue #587
Checklist

[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the [Contribution Guide] and my PR follows them.
[x] I updated my branch with the master branch.
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation about the functionality in the appropriate .md file
[] I have added in line documentation to the code I modified

Short description of what this PR does:

Updates documentation based on the new email activity API.
Creates a folder for messages.py, updates USE_CASES.md and USAGE.md.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

Hello @ajloria,Thanks again for the PR! It's HACKTOBERFEST! We want to show our appreciation by sending                                              you some special Hacktoberfest swag. If you have not already, could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX


feat: sort tuple properties in cl pretty print

This PR was published to npm with the version 6.11.4-pr.3d18e85.0
e.g. npm install<EMAIL_ADDRESS>--save-exact

Description
Change Cl.prettyPrint so that it sorts properties in a tuple.
This an opinionated change and I could do it in Clarinet, but it kind of make sense to have it natively here as well. I would understand if one disagrees though.
Breaking change?
Not really, in the sense that developers shouldn't rely on the property output of this method, this is mostly for debugging
Example
Cl.prettyPrint is used in the clarinet sdk to show output diffs in tests.
Because the output is just a string, Vitest can fail to properly render the diff of the properties of the expected tuple vs the actual tuple are not in the same order
See below where only the value of a changes.
- Expected
+ Received

  (some {
-   d: u1010000000,
-   a: u1,
+   b: u1013,
    c: u75,
-   b: u1013
+   a: u0,
+   d: u1010000000
  })

With this PR, it would display
- Expected
+ Received

  (some {
-   a: u1,
+   a: u0,
    b: u1013,
    c: u75,
    d: u1010000000
  })

Clarinet already does this sorting in expectTuple, but this is actually needed for every composite types (some, ok, err, list, tuple) and with nested values. It could be done at the clarinet level but Cl.prettyPrint already handle the recursive nature of clarity values.

Checklist

[x] Unit tested updated code paths
[x] Tagged 1 of @janniks for review

Comment addressed @janniks @zone117x
Thx for the feedback!

If this can be included in the next release of stacks.js, I'd like to include it in the next release of clarinet


Add note about none-level role

FYI this isn't live in prod yet
On Thu, Jul 27, 2023 at 8:14 PM Benson @.***> wrote:

Merged #101 https://github.com/Ganymede-Bio/website-docusaurus/pull/101
into main.
—
Reply to this email directly, view it on GitHub
https://github.com/Ganymede-Bio/website-docusaurus/pull/101#event-9943143258,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIAGKMUKJG5KOWIFMZXDHCLXSMVBNANCNFSM6AAAAAA22L3J7Y
.
You are receiving this because you authored the thread.Message ID:
@.***
com>


Feature integration test

So okay the commit messages don't go through to PR comments.
The integration test now runs a single test suite consisting of six tests. The tests have names and an end report is given. Human evaluation of tests is possible and used in these test cases. The end raport counts number of errors.
Test system is extendable and should last us as integration test system until we feel the need for a more professional system such as Robot Framework.

I'm messing up accidentally with git pull. This was a huge no-no. This pull request is hosed, I'll make a new one.
Problem was really that I had pushed this branch to create a pull request. Then master had progressed. Now, I rebased on master and push refused. As this is a single user branch, I should have pushed with force instead of doing what the instructory error message suggested: git pull. Pulling is bad mmkay?
also: DAMN YOU, LEELA!
closing


Amazon Connect login page never finishes loading using puppeteer

Steps to reproduce
Tell us about your environment:

Puppeteer version: 1.12.2
Platform / OS version: macOS Mojave 10.14.3
URLs (if applicable): https://ccalderon-reinvent.awsapps.com/connect/ccp#/
Node.js version: 8.11.1

What steps will reproduce the problem?
const browser = await puppeteer.launch();

const page = await browser.newPage();
const url = ' https://ccalderon-reinvent.awsapps.com/connect/ccp#/';

await page.goto(url, {waitUntil: 'domcontentloaded'});

console.log(await page.content());

await browser.close();

Execute the code above

What is the expected result?
The content of the page should be logged to the console.
What happens instead?
The request times out.

I am not sure what is going on here, maybe some race condition with redirects. But this is a brittle way that solves this issue on my machine:
    await page.goto(url, { waitUntil: 'domcontentloaded' });
    await page.waitFor(5000);
    console.log(await page.content());

I copied and pasted your code in https://try-puppeteer.appspot.com/ but still facing the same error. Also tested on my Mac and same.

Yeah that kind of works but I'm trying to log in after that using something like this:
console.log('waiting for username input');
await page.waitForSelector('#wdc_username');
console.log('filling login form...');
await page.type('input[type="username"]', CCP_USERNAME);
await page.focus('input[type="password"]');
await page.keyboard.type(CCP_PASSWORD);
await page.keyboard.press('Enter');
console.log('Submitted login form');

and that never finishes loading. I can confirm there is a selector called #wdc_username.

Sorry, I cannot test this. I am not registered, but at least I have failed log-in page after successful form sending with random user/password pair.

you do @ccalderon911217 ??? Can you please share your code? I can't get that.

I've just used your code:
'use strict';

const puppeteer = require('puppeteer');

(async function main() {
  try {
    const browser = await puppeteer.launch({ headless: false });

    const page = await browser.newPage();
    const url = ' https://ccalderon-reinvent.awsapps.com/connect/ccp#/';

    await page.goto(url, { waitUntil: 'domcontentloaded' });
    await page.waitFor(5000);
    console.log(await page.content());

    console.log('waiting for username input');
    await page.waitForSelector('#wdc_username');

    console.log('filling login form...');
    await page.type('input[type="username"]', 'CCP_USERNAME');
    await page.focus('input[type="password"]');
    await page.keyboard.type('CCP_PASSWORD');
    await page.keyboard.press('Enter');

    console.log('Submitted login form');

    // await browser.close();
  } catch (err) {
    console.error(err);
  }
})();

I'll keep researching but I'm still getting a timeout...

Please refer to https://stackoverflow.com/questions/54657355/how-to-use-puppeteer-to-automante-amazon-connect-ccp-login.
This seems to be a bug with chromium version 73.x as it's currently working fine for version 72.

@ccalderon911217 so does this repro with Puppeteer v1.13.0?

@aslushnikov what version of chromium comes with puppeteer 1.13? I haven't tested myself.

@ccalderon911217 pptr v1.13.0 comes with Chromium 74.0.3723.0 (r637110)


Sum and Product cleanups

This continues on from #406
I cleaned up the impls to be consistent with the other code in cgmath, and implemented Sum for Angles. I also reordered the assertions so that type inference worked, and ensured that the tests covered both taking the iterator items by value and by ref.

I suppose tests for Basis product is warranted :) .


[carla_ros_scenario_runner-1] RuntimeError: trying to create rpc server for traffic manager; but the system failed to create because of bind error.

I have seen this issue multiple times:

while using Autopilot functionality (turning it on/off) for a vehicle actor
main issue: after running couple of scenarios using scenario runner (carla- ros), this error pops up. I know that this is because previous process is still active or maybe not completely closed down. I have been using 'pkill -9 python3' until now, but I want to find a better way to avoid using  this.
Any ideas?

@jackbart94
@germanros1987
(excuse my rudeness, in tagging y'all directly!)
CARLA 9.14 in a docker
ROS2 Humble

You can first check whether the trafficManagerPort you set is used. If so, please kill the related process first. If not, try to restart carla and connect again


Better getting-started section of react-server README

Taken from the top-level README, with absolute links pointing to npmjs.com
(and github for the docs) instead of relative links within the repo.
Also changed an instance of react-server to React Server.

👍


Issue with adding a svg file path for polygon mask

Contact Details
No response
What do you need?
Hello I'm trying to use a svg file on the website and can't add a relative path to the file, it works with url path but not files on the server.
The regular particles work (so the initialization was done correctly.)
Here's my config file:
{
      "background": {
        "color": {
          "value": "#000000"
        },
        "position": "50% 50%",
        "repeat": "no-repeat",
        "size": "cover"
      },
      "fullScreen": {
        "zIndex": 1
      },
      "detectRetina": false,
      "fpsLimit": 30,
      "interactivity": {
        "events": {
          "onClick": {
            "mode": "push"
          },
          "onDiv": {
            "selectors": "#repulse-div",
            "mode": "repulse"
          },
          "onHover": {
            "enable": true,
            "mode": "bubble"
          }
        },
        "modes": {
          "bubble": {
            "distance": 40,
            "duration": 2,
            "opacity": 8,
            "size": 6
          },
          "grab": {
            "distance": 400
          },
          "slow": {
            "factor": 1,
            "radius": 0
          }
        }
      },
      "particles": {
        "color": {
          "value": "#ffffff"
        },
        "links": {
          "color": {
            "value": "#ffffff"
          },
          "distance": 30,
          "enable": true,
          "opacity": 0.4
        },
        "move": {
          "attract": {
            "rotate": {
              "x": 600,
              "y": 1200
            }
          },
          "enable": true,
          "outModes": {
            "default": "bounce",
            "bottom": "bounce",
            "left": "bounce",
            "right": "bounce",
            "top": "bounce"
          },
          "speed": 1
        },
        "number": {
          "density": {
            "area": 2000
          },
          "value": 200
        },
        "opacity": {
          "value": {
            "min": 0.05,
            "max": 0.4
          },
          "animation": {
            "enable": true,
            "minimumValue": 0.05
          }
        },
        "size": {
          "random": {
            "enable": true
          },
          "value": 1,
          "animation": {
            "speed": 40,
            "minimumValue": 0.1
          }
        }
      },
      "polygon": {
        "draw": {
          "enable": true,
          "stroke": {
            "color": {
              "value": "rgba(255,255,255,0.2)"
            },
            "width": 0.5,
            "opacity": 0.2
          }
        },
        "enable": true,
        "inline": {
          "arrangement": "equidistant"
        },
        "move": {
          "radius": 10,
          "type": "path"
        },
        "scale": 0.5,
        "type": "inline",
        "url": "./File.svg"   // the place where I'm having problem with... (the file is on the same location.)
      }
    }

And what the console logs:
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'getElementsByTagName')
    at PolygonMaskInstance.parseSvgPath (PolygonMaskInstance.js:180:1)
    at PolygonMaskInstance.downloadSvgPath (PolygonMaskInstance.js:219:1)
    at async PolygonMaskInstance.initRawData (PolygonMaskInstance.js:366:1)
    at async PolygonMaskInstance.initAsync (PolygonMaskInstance.js:24:1)
    at async Container.init (Container.js:351:1)
    at async Container.start (Container.js:208:1)
    at async Function.loadOptions (Loader.js:71:1)

Version
1.39.0
Which library are you using?
React.js (react-tsparticles, react-particles-js)
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @Daniel31x13,
Can you check your Console Network tab, is there a failed XHR request about that file?

Hello @matteobruni,
No there wasn't, looks like it haven't found the file and its giving me the status code of 304 in the .svq file.
Ok so I think my problem is about giving the location of the file because of the Request URL: http://localhost:3000/Nanoplating.svg
when the hierarchy's like this:

304 is Not Modified, it's a cache response, so it's fine.
I was looking on my React demo and I import the svg first:
https://github.com/matteobruni/tsparticles/blob/9a7513337a393b3d779df9b95033d7af4712315f/demo/react/src/frames.ts#L4
Then I use that variable in the url property:
https://github.com/matteobruni/tsparticles/blob/9a7513337a393b3d779df9b95033d7af4712315f/demo/react/src/frames.ts#L301
Anyway, the SVG file must have at least a path tag, without it, it doesn't work.


AttributeError: 'Namespace' object has no attribute 'func'

I got an error in create_ubuntu_dataset.py
AttributeError: 'Namespace' object has no attribute 'func'

same here

Have you solved this problem? I have the same problem, but I don't have a clue.

Some time ago I submitted an issue to update to python3.  I had encountered that error in the process and resolved it though I am sorry to say that I don't remember the details..  I included a diff in the issue because I don't have time to back test the changes with python2 so my changes are not suitable for a pull request.  If you don't need python 2 code, you can apply the diff from https://github.com/rkadlec/ubuntu-ranking-dataset-creator/issues/24 and that should solve this issue. but this is for python3 only.
I hope this is helpful.


Template for empty values

Is there a way to render an "empty" message when an empty array is passed to the List object? It would be handy to be able to add a template like you do for items whenever there are no values passed.
For example with an empty template:
const options = {
  item: function(values) {
    return `<li>${values.name}"></li>`;
  },
  empty: '
No results
'
};

You might have to correct in detail but I guess you understand the approach:
const options = {
  item: function(values) {
    return values.length ? `<li>${values.name}"></li>` : '
No results
';
  },
};

You might have to correct in detail but I guess you understand the approach:
const options = {
  item: function(values) {
    return values.length ? `<li>${values.name}"></li>` : '
No results
';
  },
};

Yeah that's where I landed as well. Though the item function doesn't get called when there's no values. Also values is an object so length doesn't work. So I made a workaround by prepping the data like this instead:
const values = data.length ?
  data.map(el => ({
    values: el.values
  })) : {
    empty: true
  };

and then:
const options = {
  item: function(values) {
    return !values.empty ? `<li>${values.name}"></li>` : '
No results
';
  },
};

Yeah that's where I landed as well. Though the item function doesn't get called when there's no values. Also values is an object so length doesn't work. So I made a workaround by prepping the data like this instead:
const values = data.length ?
  data.map(el => ({
    values: el.values
  })) : {
    empty: true
  };

and then:
const options = {
  item: function(values) {
    return !values.empty ? `<li>${values.name}"></li>` : '
No results
';
  },
};

A solution if you use existing HTML instead of item templates + search is to add it in the update event. If you use the search filter and it doesn't match anything you can do:
let myList = new List('my-list', options)
  .on('updated', function(list) {
    if (list.matchingItems.length == 0) {
      $('.my-list').append('
No items found
');
    }
});

You manually add a row when no results are found. When you remove the search filter query, the values will override the placeholder you just put in there.
It would still be handy to be able to set this as a property in the options object to account for all these scenarios.

I went with
var hackerList = new List('my-list', options).on('updated', function(list) {
  $('.list__empty')[list.matchingItems.length == 0 ? "addClass" : "removeClass"]('visible')
});


[fix][client] Fix DeadLetterProducer creation callback blocking client io thread.

Fixes #19784
Motivation
when create consumer using avro schema. and enable dlqPolicy. the producer creation callback maby block the client io thread. (which is only one thread by default.)
"pulsar-client-io-1-1" #120 prio=5 os_prio=0 cpu=30919.69ms elapsed=151047.72s allocated=104M defined_classes=415 tid=0x00007f03824d7010 nid=0x84 waiting on condition  [0x00007f02e39f7000]
   java.lang.Thread.State: WAITING (parking)
	at<EMAIL_ADDRESS>Method)
	- parking to wait for  <0x00000000ad6fd400> (a java.util.concurrent.CompletableFuture$Signaller)
	at java.util.concurrent.locks.LockSupport.park(java.base@17.0.2/LockSupport.java:211)
	at java.util.concurrent.CompletableFuture$Signaller.block(java.base@17.0.2/CompletableFuture.java:1864)
	at java.util.concurrent.ForkJoinPool.unmanagedBlock(java.base@17.0.2/ForkJoinPool.java:3463)
	at java.util.concurrent.ForkJoinPool.managedBlock(java.base@17.0.2/ForkJoinPool.java:3434)
	at java.util.concurrent.CompletableFuture.waitingGet(java.base@17.0.2/CompletableFuture.java:1898)
	at java.util.concurrent.CompletableFuture.get(java.base@17.0.2/CompletableFuture.java:2072)
	at org.apache.pulsar.client.impl.schema.AbstractStructSchema.atSchemaVersion(AbstractStructSchema.java:100)
	at org.apache.pulsar.client.impl.MessageImpl.getReaderSchema(MessageImpl.java:400)
	at org.apache.pulsar.client.impl.ConsumerImpl.lambda$doReconsumeLater$11(ConsumerImpl.java:657)
	at org.apache.pulsar.client.impl.ConsumerImpl$$Lambda$4185/0x0000000801ee43e0.accept(Unknown Source)
	at java.util.concurrent.CompletableFuture$UniAccept.tryFire(java.base@17.0.2/CompletableFuture.java:718)
	at java.util.concurrent.CompletableFuture.postComplete(java.base@17.0.2/CompletableFuture.java:510)
	at java.util.concurrent.CompletableFuture.complete(java.base@17.0.2/CompletableFuture.java:2147)
	at org.apache.pulsar.client.impl.ProducerImpl.lambda$resendMessages$18(ProducerImpl.java:1795)
	- locked <0x00000000ad6fd530> (a org.apache.pulsar.client.impl.ProducerImpl)
	at org.apache.pulsar.client.impl.ProducerImpl$$Lambda$2248/0x0000000801b24440.run(Unknown Source)
	at org.apache.pulsar.shade.io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:174)
	at org.apache.pulsar.shade.io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:167)
	at org.apache.pulsar.shade.io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:470)
	at org.apache.pulsar.shade.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:403)
	at org.apache.pulsar.shade.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
	at org.apache.pulsar.shade.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
	at org.apache.pulsar.shade.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	at java.lang.Thread.run(java.base@17.0.2/Thread.java:833)
   Locked ownable synchronizers:
	- None

When deadLetterProducer is created. the code maybe run in pulsar-client-io thread.
https://github.com/apache/pulsar/blob/0c4db3abe599722e0a36a92c6730c8ab7ee06011/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java#L1880-L1884
when the producerCreateFuture trigger callback ComplateableFuture.thenApply we still on the pulsar-client-io thread.
https://github.com/apache/pulsar/blob/17c58a539315cc4ea39655d4328c5caf55f87d3d/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java#L651-L656
and retryMesage.getReaderSchema maybe a blocking call to send rpc to retrieve schema. so the pulsar-client-io thread is blocked. and won't be liveliness because the schema retrieve rpc need io-thread to do the job to get the result.
https://github.com/apache/pulsar/blob/82237d3684fe506bcb6426b3b23f413422e6e4fb/pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/AbstractStructSchema.java#L117-L135
Modifications
execute CompletableFuture callback logic on fork-join-common-pool.
Verifying this change

[ ] Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

Closing and reopening to trigger a new build.

Codecov Report

Merging #19930 (54ef5ce) into master (329e80b) will increase coverage by 11.24%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             master   #19930       +/-   ##
=============================================
+ Coverage     61.50%   72.74%   +11.24%
- Complexity    25755    31978     +6223
=============================================
  Files          1859     1863        +4
  Lines        136792   140065     +3273
  Branches      15043    15792      +749
=============================================
+ Hits          84129   101886    +17757
+ Misses        44857    30072    -14785
- Partials       7806     8107      +301

Flag
Coverage Δ

inttests
24.34% <66.66%> (-0.15%)
:arrow_down:

systests
25.04% <0.00%> (+0.02%)
:arrow_up:

unittests
71.99% <100.00%> (+13.34%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...va/org/apache/pulsar/client/impl/ConsumerImpl.java
76.53% <100.00%> (+10.38%)
:arrow_up:

... and 629 files with indirect coverage changes


about the generated synthetic data

hello! I am not an optic expert so ther may be some misunderstanding.
For the generated zernike-based psf, are you assuming they are all under a fixed and known lighting condition? Since it seems that the parameter related to the pupil radius (pixel_limit here and here) are all pre-defined.

Yes all these parameters make one big constant called pixel limit. If I recall correctly, it just needs to be in the same order of magnitude as what you want to model since it's used to limit the support of the wavefront function. I added some magic numbers of plausible distances used in optical microscopy.
Sorry for the delay, I finished my thesis in 2020 :)


✨feat(homePlugin): changed list view of starredEntities to facilitate…

… distinguish entities with same name
Hey, I just made a Pull Request!
I change the list view of the Starred Entities to group them by kind so in case of having entities with different kind but same name it easier to distinguish

Also moved the star icon to the left side before the entity name for make easier to remove them from preferred

This is included as an optional groupByKind property for the StarredEntities component
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

#16909

Hi , still interested if it is valuable for the users of the Home plugin 😁

Still interested! @freben it is #17474 ready or make sense to merge this one?

@antoniobergas Thanks for your patience. #17474 is now merged. Would you mind rebasing this on latest master, and checking out

what's the experience like without your change, and
with your change, does it look worse to have the iconography and custom formatting that #17474 added

Let's see where to take this PR, with this new background!

Hey @freben ! Thanks for taking a look at this, will try your suggestions when I find a free spot. I let you know!

Hi @antoniobergas
I'm a designer working on Backstage 👋 One of the engineers shared your post and I have a few comments - hope you find them useful.
A few things to bear in mind:

I can see that you've ordered the groups alphabetically, however, if my most used/visited item is a System, that could be quite annoying and result in a poor experience for the user to have to scroll to the end of the list to select that each time, especially if it's a long list. I'm not sure whether you're planning on limiting the number of starred items. If there isn't a limit to the number of starred items, the scanability of the list and subsequently the findability of the link someone's looking for is greatly reduced the longer the list is. To increase the user's success rate of scanning the content and finding what they're looking for, I would recommend introducing tabs to the card, so a user can select which group they want to access and be presented with a more focused list to scan and select from.

Each star is quite far away from the title, creating a large gap. I assume a user can 'un-star' a URL from here. If so, I would highly recommend moving the stars to the left of the title. It will make it easier for a user to be confident that they're selecting (or rather de-selecting) the correct star.

Hope you find my comments useful.

Hi @creecree10 !
Thanks a lot for your thoughtful feedback! I agree with your suggestions, make a lot of sense to improve more the user experience.
Once I've made these adjustments, I'll post in the original issue to gather feedback from the rest of people that were discussing this improvement in the Home Plugin.
If you have any further suggestions or if there's anything specific you'd like me to consider during the implementation, please feel free to let me know.

Awesome, thank you so much @creecree10 @antoniobergas just one additional thing that came to my mind - can we make this grouping optional so that others can decide to make the grouping different if they want or keep as it is?

That sounds like a good way to go @emmaindal , but actually not sure were we should specify this optional grouping, I'm guessing in the properties of the HomePage component in the routes?
Maybe @freben can you maybe guide me a little bit on this? Thanks!

I was thinking a property on the component similar to the noStarredEntitiesMessage prop and then maybe separate the rendering of grouped vs non-grouped entities

Yeah @emmaindal you are totally right, I just get confused because of a custom wrapper we did in our internal instance. 😅
Thanks for the guidance! Will try to make some free spot this weekend if I can to work on this!

@emmaindal @creecree10 I modify the code with your suggestions! Let me know if this is what you got on mind or if there's anything else to care about 😁
@freben I would like to know what you think with this new changes? Maybe its just enough? Not sure If this anwser properly to your suggestions.

Looking good to me @antoniobergas

hi @antoniobergas could you rebase on top of master for me? 😄

Hi @djamaile , yes , will do when I have a free spot, thanks 😁

@djamaile done! everything should be fine now 😁


Contribute first table component

Start with initial work from MPATT, or consider an open source library
Requirements:

Configurable columns
Export to CSV/JSON widget
Sorting

#37 was the initial Table contribution


[BUG] Random slowdowns in tensor parallel.

OS
Linux
GPU Library
CUDA 11.8
Python version
3.10
Pytorch version
2.4
Model
Luminum 123b 4.0bpw H6
Describe the bug
I am happily genning at 11-16t/s. Suddenly random messages go really slow and the t/s drops. After some more messages it goes back up.
I went into nvtop to check GPU temps but they were all in the 60s. One GPU is cranking and the others are at low % for some reason as if it was processing sequentially.
Am not sure if it's related to my machine but it's a new behavior for me since 2.2 and dev. Mostly probing to see if anyone has experienced the same.
Reproduction steps
Generate as normal. Some messages will be slow.
Expected behavior
Consistent speeds.
Logs
No response
Additional context

Acknowledgements

[X] I have looked for similar issues before submitting this one.
[X] I understand that the developers have lives and my issue will be answered when possible.
[X] I understand the developers of this program are human, and I will ask my questions politely.

You're not rolling over the KV cache at ~4K context or something like that, right? I don't experience this with the latest dev pull, but I also usually don't have conversations longer than the pre-allocated sequence length. That said, paged attention is now pretty good at handling rolling cache too... so maybe not relevant.

Nope, it's 32k model. Haven't seen it crop up lately though.


GEODE-4662: Add method for retrieving size to the region interface.

Previously, the size (e.g., entry count) of a region
could be retrieved as part of the region attributes.
However, only the name of the region (which is
already known) and the size of the region are data
that can be affected during runtime; the remaineder
of the fields of the region attributes were
administrative. So region attributes has been
elided in favor of just the size.

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[x] Is your initial contribution a single, squashed commit?

[x] Does gradlew build run cleanly?

[x] Have you written or updated unit tests to verify your changes?

[n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

Closing due to weirdness with builds; will reopen.


question regarding qrdqn

Hi,
while trying to extend qrdqn to support double qrdqn, I couldn't convince myself with the current implementation of the update function.
specifically, refer to the train function in  QRDQN class (qrdqn.py), line 165:
                # Follow greedy policy: use the one with the highest value
                next_quantiles, _ = next_quantiles.max(dim=2)

it looks like the max operation is done on the actions dimensions and by that per each quantile separately, the value from the action that yielded maximum value. (e.g. for the first quantile it can take from a=1, for the 2nd quantile it can take from a=4 etc.)
so the resulting buffer will include quantile values from different actions.
As I have understood (and checked various other implementations of qrdqn), the intent was to calculate the q value of each of the actions by averaging over the quantiles of each action and only then take the quantiles of the best next action.
something like this:
            with th.no_grad():
                # Compute the quantiles of next observation
                next_quantiles = self.quantile_net_target(replay_data.next_observations)
                best_next_actions = next_quantiles.mean(dim=1).argmax(dim=1,keepdim=True)
                actions_index = best_next_actions[...,None].expand(batch_size,self.n_quantiles,1)
                next_quantiles = target_quantiles.gather(dim=2,index=actions_index).squeeze(dim=2)
                # 1-step TD target
                target_quantiles = replay_data.rewards + (1 - replay_data.dones) * self.gamma * next_quantiles

My question : is the current implementation differs by design ? if so, and assuming the implementation that I'm proposing here corresponds to the publication, what's the justification of the variant currently implemented ?
BTW, Great work with SBL3 !! a very useful and easy to work with library !
I mainly use it (and thus extend it) for offline RL settings.
Thanks a lot :)

Pinging @ku2482 to give insight. We maintainers are mainly taking vacations and won't be around until after holidays ^^

BTW, Great work with SBL3 !! a very useful and easy to work with library !

Thanks for the kind words :). This work would not be possible without such acknowledgements, and more importantly, not without the generous contributions done by many!

is the current implementation differs by design ?

Hello,
thanks for raising this issue. In fact, I forgot to ask @ku2482 myself why is it so...
That may be a bug.
I will try to check again the paper and other implementations, but I would tend to agree with you ;)

is the current implementation differs by design ?

Hello,
thanks for raising this issue. In fact, I forgot to ask @ku2482 myself why is it so...
That may be a bug.
I will try to check again the paper and other implementations, but I would tend to agree with you ;)

@guyk1971
Thank you for pointing it out.
You're right it's a bug.
@Miffyli @araffin
I'm so sorry about that...
I will create PR to fix it later today, and I will also evaluate the algorithm again.
Thanks.

@guyk1971
Thank you for pointing it out.
You're right it's a bug.
@Miffyli @araffin
I'm so sorry about that...
I will create PR to fix it later today, and I will also evaluate the algorithm again.
Thanks.

Thanks for handling this, and for the great work you're doing with stable
baselines 3 ! 👏
Good luck ! 🤞
On Wed, Jan 6, 2021 at 2:15 AM Toshiki Watanabe<EMAIL_ADDRESS>wrote:

@guyk1971 https://github.com/guyk1971
Thank you for pointing it out.
You're right it's a bug.
@Miffyli https://github.com/Miffyli @araffin
https://github.com/araffin
I'm so sorry about that...
I will create PR to fix it later today, and I will also evaluate the
algorithm again.
Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Stable-Baselines-Team/stable-baselines3-contrib/issues/17#issuecomment-754979342,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYIHGHQKV6D4UVMEKIX6F3SYOTT7ANCNFSM4VJFLNZQ
.

Thanks for handling this, and for the great work you're doing with stable
baselines 3 ! 👏
Good luck ! 🤞
On Wed, Jan 6, 2021 at 2:15 AM Toshiki Watanabe<EMAIL_ADDRESS>wrote:

@guyk1971 https://github.com/guyk1971
Thank you for pointing it out.
You're right it's a bug.
@Miffyli https://github.com/Miffyli @araffin
https://github.com/araffin
I'm so sorry about that...
I will create PR to fix it later today, and I will also evaluate the
algorithm again.
Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Stable-Baselines-Team/stable-baselines3-contrib/issues/17#issuecomment-754979342,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYIHGHQKV6D4UVMEKIX6F3SYOTT7ANCNFSM4VJFLNZQ
.


summary reference

Hi,
Thanks for your awesome work!
I just wonder if you would consider include summary references in your benchmark data. Because probably people want to test their general summarization metrics on your benchmark too.
Shiyue

Hey @ZhangShiyue, that's a great point! I have been thinking about article-based metrics, but I will add the reference summaries as well to allow testing reference-based metrics.
I'll let you know when that's done.

@ZhangShiyue  I just added reference summaries to the benchmark data file. Let me know if you have any other suggestions!

Great! Thanks!


Add CA file option for TLS connection

:tada: :tada: :tada: :tada: :tada: :tada:
Congrats for your pull request :)
I believe the code it is very reasonable.
Let's wait for feedback from brocaar and we will move from there :)

Thanks! I have added a few comments (just a few consistency related comments). Would you be able make these changes? Then I think it is good to merge :-)

@brocaar : Changes are done... and it works on my gateway.
If this is ok, I will write a short installation manual for the lorixOne http://lorixone.io/ Gateway.

OT
@minggi , do you mind to write me an email, I am quite interested in those little gateways that you linked.

@brocaar , do you want me to add this change to the other loraserver and the lora-app-server too?

If you would like to do so, that would be great!

This is working on my Conduit Gateways.  Thank you!  It would be great if lora-gateway-bridge could support client certificate authentication with MQTT as well.

@nickumbe , it doesn't look too difficult, why you don't try to submit a pull request?
Look at the previous thread about this issues: https://github.com/brocaar/lora-gateway-bridge/issues/37
You see how minggi was supported?
If you are interested in the feature the simplest thing you can do is to implement it yourself, ask feedback, fix whatever need to be fixed and finally get it merged.
Bonus point, after the first PR is accepted it is simpler to implement it in other parts of the architecture: https://github.com/brocaar/loraserver/pull/190


better cluster filenames

This was originally based on PR #238, but I ended up doing it differently: instead of just renaming files in _work, files related to a cluster installation are now in _work/clear-kvm[-something] sub-directories, with generic names inside that directory.
The immediate benefit is that multiple parallel clusters can prepared in parallel (but cannot run in parallel yet).
When we add alternative ways of bringing up clusters, we can just swap out the rules which set up the cluster, while code using the cluster just needs to know the directory name and then can use the generic files inside it for whatever operation it needs to do (to be decided).

A cluster brought up from scratch with this branch passed "make test_e2e".

finally managed to create clear VM cluster, earlier today I used DNSSEC override, now it worked in clean tree of this PR. make test_e2e passes, took 75 seconds (amazed as it used to be 1600s ... I think thats the result of previous testing change of #228 right, I just had not tried it yet on Clear-based VMs).

Olev Kartau<EMAIL_ADDRESS>writes:

finally managed to create clear VM cluster, earlier today I used
DNSSEC override, now it worked in clean tree of this PR.

So shall we merge?

make test_e2e passes, took 75 seconds (amazed as it used to be 1600s
... I think thats the result of previous testing change of #228 right,

Correct.


preflist support

Run tests with ./vendor/bin/phpunit PreflistTest tests/functional/PreflistTest.php

Hahahahaha @christophermancini remove var_dump... the only way to debug php! that's a joke right?

@debo your right... sometimes I use print_r($var, true) too! :stuck_out_tongue:

oh come on... you are taking the p..s now :smile:

LOL, nah. This is actually super old code that I had to dust off because the preflist end point on the HTTP interface was finally fixed on Riak. I finally learned how to use xdebug / zend_debug and don't use var_dump much anymore but sometimes its just faster. :wink:

True that. Also, once more, thanks for the great job you are doing.

:shipit:


Adds average success/failure rate information to plot legend

Adds average success/failure rate information to plot legend

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

See the complete overview on Codacy


[Tackle-234/236] Fix issues with Adoption Plan

Issues : Tackle-234 and Tackle-236
Fixes :

flipped the dependency concept (inbound/outbound)
flipped the priority concept (descendent order)
added check on the parents regarding having a review
changing the vertical sort to be : DESC Priority ASC App Name

Result

Thanks @jonathanvila this PR looks good to me.


lib/node: Add util.TextDecoder/TextEncoder

Library docs:

TextDecoder
TextEncoder

Node 8.3 added them to 'util'.
Node 11.0 added them to the global object, but I didn't do that part.

This is actually just duplicates same thing from bom.js

Oh, interesting.  I wonder if there's a way to share some of the definitions.
One tricky thing is that the Node API is slightly different.  For example, the TextEncoder constructor doesn't accept an argument, since it only supports UTF-8.


add batched cholesky solver

This PR adds a public function cupyx.linalg.cholesky_solve (#4237) that computes the solution to a system of linear equations A * X = B for symmetric/Hermitian positive-definite matrices. Similar to the LAPACK xPOSV routines, it performs factorization and then uses the factored form to solve the system of equations. This PR is mostly a refactor of cupyx.linalg.invh, which is implemented as the special case A * X = I.
There is related work in #4172 to implement cupyx.scipy.linalg.cho_factor and cupyx.scipy.linalg.cho_solve which are wrappers for the non-batched cholesky factorization step (xPOTRF) and cholesky solve step (xPOTRS) and match the scipy api.
It might make more sense to separate the factorization and solution steps here too but since this was mostly just a refactor of cupyx.linalg.invh, I didn't want to change too much.

Thanks for the PR to generalize cupyx.linalg.invh to cholesky solver.
It's a bit annoying that there is no function in numpy.linalg or scipy.linalg that corresponds to the cholesky solver, but since it it the LAPACK posv equivalent, I thinks it is better to put it in cupyx.lapack as posv.
For reference, there are gesv and gels in cupyx.lapack now.

Thanks for the suggestion, I moved the cholesky solver to cupyx.linalg.posv.
It looks like scipy.linalg.solve(..., assume_a='pos', ...) calls posv here: https://github.com/scipy/scipy/blob/v1.5.4/scipy/linalg/basic.py#L243
In general though, it doesn't seem like the scipy api supports batch inputs which is really what I am trying to accomplish here.

pfnCI, test this please.

Jenkins CI test (for commit 6372b4190c6b5c23d84cbaa1affcb1b5397b7bc7, target branch master) failed with status FAILURE.

pfnCI, test this please.

Jenkins CI test (for commit 6372b4190c6b5c23d84cbaa1affcb1b5397b7bc7, target branch master) failed with status FAILURE.

pfnCI, test this please.

Jenkins CI test (for commit 6372b4190c6b5c23d84cbaa1affcb1b5397b7bc7, target branch master) succeeded!

LGTM!


yarn watch not working on windows 10

I'm submitting a ...
[x ] bug report
[ ] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project

Summary
running yarn watch on windows 10 will produce this output

yarn watch v0.20.3
$ trash build && multiview [yarn watch:build] [yarn watch:unit]
module.js:472
    throw err;
    ^

Error: Cannot find module './build/Debug/buffertools.node'
    at Function.Module._resolveFilename (module.js:470:15)
    at Function.Module._load (module.js:418:25)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (~~my repo~~\node_modules\buffertools\buffertools.js:26:20)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
error Command failed with exit code 1.

this is because multiview use buffertools  which not support simple instalation on windows ( you need a C++ compiler & python 2.7 for that).

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

Hey @bungcip – thanks for opening the issue!
Did you get some sort of error or warning when running yarn/yarn install for the first time? I'd like to continue using multiview in the watch task for machines which support it – is it possible to get multiview working on Windows?
I might just add a note to that section of the readme to inform people that it's possible to  run yarn watch:build and yarn watch:unit separately (if they are unable / don't want to install the extra dependencies).

Ah, maybe a silly question – did you run yarn/yarn install before trying to run yarn watch? I just realized I didn't add that anywhere in the readme.

running yarn install will fail on windows 10 because  my desktop don't have python installed. So I just use npm install, somehow npm install can skip the error...
D:\repo\typescript-starter-master>yarn install
yarn install v0.20.3
[1/4] Resolving packages...
[2/4] Fetching packages...
warning<EMAIL_ADDRESS>The platform "win32" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
[4/4] Building fresh packages...
[-/2] ⡀ waiting...
[2/2] ⡀ buffertools: using<EMAIL_ADDRESS>| win32 | x64
[-/2] ⡀ waiting...
[-/2] ⡀ waiting...
error D:\repo\typescript-starter-master\node_modules\buffertools: Command failed.
Exit code: 1
Command: C:\Windows\system32\cmd.exe
Arguments: /d /s /c node-gyp rebuild
Directory: D:\repo\typescript-starter-master\node_modules\buffertools
Output:
D:\repo\typescript-starter-master\node_modules\buffertools>if not defined npm_config_node_gyp (node "C:\Users\bungcip\AppData\Roaming\npm\node_modules\yarn\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node  rebuild )
gyp info it worked if it ends with ok
gyp info using<EMAIL_ADDRESS>gyp info using<EMAIL_ADDRESS>| win32 | x64
gyp ERR! configure error
gyp ERR! stack Error: Can't find Python executable "python", you can set the PYTHON env variable.
gyp ERR! stack     at PythonFinder.failNoPython (C:\Users\bungcip\AppData\Roaming\npm\node_modules\yarn\node_modules\node-gyp\lib\configure.js:454:19)
gyp ERR! stack     at PythonFinder.<anonymous> (C:\Users\bungcip\AppData\Roaming\npm\node_modules\yarn\node_modules\node-gyp\lib\configure.js:480:16)
gyp ERR! stack     at C:\Users\bungcip\AppData\Roaming\npm\node_modules\yarn\node_modules\graceful-fs\polyfills.js:284:29
gyp ERR! stack     at FSReqWrap.oncomplete (fs.js:111:15)
gyp ERR! System Windows_NT 10.0.14393
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\bungcip\\AppData\\Roaming\\npm\\node_modules\\yarn\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd D:\repo\typescript-starter-master\node_modules\buffertools
gyp ERR! node -v v7.3.0
gyp ERR! node-gyp -v v3.5.0
gyp ERR! not ok
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Multiview is supported on windows, but you need Visual Studio (or msbuildtools) and python to compile it. On my notebook which have vs 2015 and python 2.7, I can run multiview without problem
npm config set python C:\Python27\python.exe
npm install -g multiview

I think the README need more explanation when installing on windows.

Build and run "multiview" on windows 10, but any command I pass to it returns error code 1 with no console output.

I think I just too early to say that multiview support windows 10 T_T.  @tbko  is right, I also cannot run it. It give me error about socket though.

@bungcip, @tbko thanks for the reports.
I think I'll try switching from multiview to concurrently. Hopefully that will make things simpler. 🚀


Add smoke tests for shiny.playwright.NavPanel

From https://discord.com/channels/1109483223987277844/1271090164357402626/1271090164357402626

Other Nav panel requests:

[ ] Rename _NavPanelBase class to _NavSetBase
[ ] Document _NavPanelBase's  public nav_panel() method.
[ ] Additional request to change data_value init parameter to panel_value to match the ui.nav_panel(*, value=) parameter.

Since our parameter is still a positional arg, the rename should be fine.

Fixed in https://github.com/posit-dev/py-shiny/pull/1602


Add missing state paths

Fix the list of config paths which are missing corresponding state path

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 72.677%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1314

Relevant Lines:
1808

💛  - Coveralls

/gcbrun


feat: make content models connection agnostic

Summary
This PR is a prerequisite  for integrating sas server into the extension (see overall design, here: https://github.com/sassoftware/vscode-sas-extension/issues/889). This makes a few additional refactors outside of those mentioned in https://github.com/sassoftware/vscode-sas-extension/issues/889.
Favorites. Previously, we were storing a favorite id w/n ContentItem.flags. This change delays finding that favorite id until we're actually doing something with that favorite.
Notebook -> flow conversion. When we first implemented this change, there was some question around whether this belong in content data provider or not. In this PR, functionality is moved to a NotebookToFlowConverter which makes use of a ContentModel directly.
It's also worth mentioning that this moves some additional properties into ContentItem that were previously utils functions, and updates every content adapter method to return a content item decorated with those new properties. Additionally, this splits utils such that ContentNavigator/utils has things that are connection agnostic, while rest/utils contains things that are connection specific.
Testing

[x] Test creating file
[x] Test creating folder
[x] Test moving files & folders
[x] Test recycling files & folders
[x] Test deleting files & folders
[x] Test add to favorites for files and folders
[x] Test remove from favorites for files and folders
[x] Test editing files (regular files & favorites & favorites w/n folders)
[x] Test downloading files and folders
[x] Test converting sas notebooks to flows (test in explorer as well as sas content)
[x] Test renaming files & folders
[x] Test emptying recyling bin
[x] Test refreshing content
[x] Test filename statement
[x] Test fetching viya cadence
[x] Test uploading files (context menu, dragging from file system, dragging from explorer)
[x] Test collapsing all files
[x] Make sure multi-select is working the same on this branch and main

Todos

[x] Address test coverage/build issues

Observations

Unable to download flows. This is because flows are stored at a different endpoint than regular files

Hey @smorrisj. I made some changes matching the general design of https://github.com/sassoftware/vscode-sas-extension/issues/889.
That said, after these changes, ContentModel looks pretty slim and serves no real purpose of its own other than:

Presenting some error messaging back to content data provider
providing a different data format (i.e. string vs buffer)

After working through this, it almost feels like ContentModel should be an abstract class that connection-specific things extend. Thoughts?

@scnwwu wondering if you have any thoughts about the above?

@scnwwu wondering if you have any thoughts about the above?

defer to @boyce-w who is more familiar with the Content part.

ContextMenu name changed from 'Remove from My Favorites' to 'Add to My Favorites' if the file already has been added to My Favorites.
1.Create a file under My Folder
2.Add the file to My Favorites through ContextMenu
3.Open ContextMenu against the file again

Multi-select is not working the same on this branch and main.
Multi-selection through pressing Shift or Ctrl works well on this branch. It does not work well on main.

Multi-select some files and perform 'Add to My Favorites' through context menu, it does not move all files

ContextMenu name changed from 'Remove from My Favorites' to 'Add to My Favorites' if the file already has been added to My Favorites. 1.Create a file under My Folder 2.Add the file to My Favorites through ContextMenu 3.Open ContextMenu against the file again

Multi-select some files and perform 'Add to My Favorites' through context menu, it does not move all files

It looks like this second one is an issue on main as well. Both of these have been resolved in https://github.com/sassoftware/vscode-sas-extension/pull/1079/commits/da0417b33d5994c55590fc5b73c36259c884ce65 .

Multi-select is not working the same on this branch and main. Multi-selection through pressing Shift or Ctrl works well on this branch. It does not work well on main.

Is this still an issue for you, @Zhirong2022 . I noticed this problem on main and my branch several weeks ago when implementing this, but it since seems to have resolved itself (I'm guessing it may've been a vscode bug)

@scottdover , thank you for your help.  I upgraded my VSC to the latest version, multi-selection works well through pressing Shift or Control.  And other issues have been fixed in the branch package.


[1259] Rename institution_code to provider_code

Context
The frontend is wired up to use provider_code to connect courses and providers, but the backend was returning an institution_code instead of a provider_code.
Changes proposed in this pull request
Provider resources now have a provider_code instead of an institution_code.
Guidance to review
Do not merge until frontend has been wired up to support this change.

https://trello.com/c/bPZDnJjy

Frontend PR https://github.com/DFE-Digital/manage-courses-frontend/pull/154

We should change provider_name too but that can be done later

We should change provider_name too but that can be done later

yea made a card https://trello.com/c/U5X1SNps


179 4.13 how did you find out about us 2

#179

Coverage remained the same at 100.0% when pulling 057a2db0170d72bac9b6d0ebad86c60c989b1fd3 on 179_4.13_how_did_you_find_out_about_us_2 into 22020137dd5a47a5975e854363bc0291d4dd0ee2 on dev.

Coverage remained the same at 100.0% when pulling 73158cc266557ae124173a273a0416c066b2be02 on 179_4.13_how_did_you_find_out_about_us_2 into 027294343ab7875ab3b50a97674de822e65dd707 on dev.


Regarding whether the tf-job-operator v1.0 metrics can expose specific failed pods

What you would like to be added?
tf-job-operator v1.0 metrics can expose specific failed pods
The logging details are as follows
content="{'filename':'record/event.go:221','level':'info','msg':'Event(v1.ObjectReference{Kind:\'TFJob\', Namespace:\'iem-trs-training\', Name:\'android-consume-v2-update-2024-08-20-053447\', UID:\'803a4aca-561b-4609-9ee3-8953f075b66c\', APIVersion:\'kubeflow.org/v1\', ResourceVersion:\'860397344\', FieldPath:\'\'}): type: 'Normal' reason: 'ExitedWithCode' Pod: iem-trs-training.android-consume-v2-update-2024-08-20-053447-worker-0 exited with code 1','time':'2024-08-20T22:35:42Z'}"
Why is this needed?
It is necessary to quickly locate the training node with specific problems
Love this feature?
Give it a 👍 We prioritize the features with most 👍

Thank you for creating this @SecretSun!
Are you looking to improve the Failed message in TFJob events: https://github.com/kubeflow/training-operator/blob/master/pkg/controller.v1/tensorflow/tfjob_controller.go#L501-L503 ?
/area monitoring
/remove-label lifecycle/needs-triage

content="{'filename':'record/event.go:221','level':'info','msg':'Event(v1.ObjectReference{Kind:\'TFJob\', Namespace:\'iem-trs-training\', Name:\'android-uni-item-eval-2024-09-09-043604\', UID:\'f31ff823-5904-41cb-b490-e368426e8061\', APIVersion:\'kubeflow.org/v1\', ResourceVersion:\'906983038\', FieldPath:\'\'}): type: 'Normal' reason: 'TFJobFailed' TFJob android-uni-item-eval-2024-09-09-043604 has failed because 1 Worker replica(s) failed.','time':'2024-09-09T20:52:45Z'}"
It is possible that there is no understanding of the meaning, whether the support can be specific to that worker


Add support for translation endpoint

See https://learn.microsoft.com/en-us/azure/ai-services/openai/reference#translations

[ ] add generator for translations and include in default generators
[ ] validate translation endpoint with record/replay
[ ] determine how rate-limiting is applied and add to the simulator rate-limiting
[ ] add tests
[ ] add load test

(from https://github.com/stuartleeks/aoai-simulated-api/issues/47)

@stuartleeks I will try this one


Update Dataprovider for Appwrite >0.12

The recent relase of Appwrite 0.12 has changed the database API of Appwrite. Specifically the permissions have been changed. The "*" wildcard permission has been replaced by "role:all". You can find more info in the Migration Guide blog post.
I found 4 instances of falling back to the "*" wildcard in the provider:
https://github.com/pankod/refine/blob/cba0000f86d35774f9b397fcf3a2f4edae62a739/packages/appwrite/src/index.ts#L139
https://github.com/pankod/refine/blob/cba0000f86d35774f9b397fcf3a2f4edae62a739/packages/appwrite/src/index.ts#L140
https://github.com/pankod/refine/blob/cba0000f86d35774f9b397fcf3a2f4edae62a739/packages/appwrite/src/index.ts#L155
https://github.com/pankod/refine/blob/cba0000f86d35774f9b397fcf3a2f4edae62a739/packages/appwrite/src/index.ts#L156
https://github.com/pankod/refine/blob/cba0000f86d35774f9b397fcf3a2f4edae62a739/packages/appwrite/src/index.ts#L172
https://github.com/pankod/refine/blob/cba0000f86d35774f9b397fcf3a2f4edae62a739/packages/appwrite/src/index.ts#L173
https://github.com/pankod/refine/blob/cba0000f86d35774f9b397fcf3a2f4edae62a739/packages/appwrite/src/index.ts#L226
https://github.com/pankod/refine/blob/cba0000f86d35774f9b397fcf3a2f4edae62a739/packages/appwrite/src/index.ts#L227

Hey @BobcatProgrammer ,
The Appwrite team warned us about this. Let's review the Migration Guide and see what we can do. Thank you!

As far as I understood it the old "*" is equivalent to "role:all" and changed on all documents during appwrite migration to 0.12. so just changing the instances I marked above should be enough (and a comment in the docs that appwrite >=0.12 is required)

As far as I understood it the old "*" is equivalent to "role:all" and changed on all documents during appwrite migration to 0.12. so just changing the instances I marked above should be enough (and a comment in the docs that appwrite >=0.12 is required)

Great, do you want to do this for us?

I can do that?
I just need to replace ["*"] with ["role:all"] in refine/packages/appwrite/src/index.ts
am I correct?

Yes, it looks great. Also, in Appwrite Guide, we need to add a warning for those who use an Appwrite version older than 0.12.
@BobcatProgrammer what do you think?

Yes, it looks great. Also, in Appwrite Guide, we need to add a warning for those who use an Appwrite version older than 0.12.
@BobcatProgrammer what do you think? Do you want to do it? @bhagatpratham can it?

hey @omeraplak can you guide me on how to create a warning? thanks

The Appwrite docs are here
in the docs you can scroll down to the bottom and click "Edit this page" and it takes you to the related github file

Yes, it looks great. Also, in Appwrite Guide, we need to add a warning for those who use an Appwrite version older than 0.12.
@BobcatProgrammer what do you think? Do you want to do it? @bhagatpratham can it?

hey @omeraplak can you guide me on how to create a warning? thanks

We use Docusaurus for docs.
Here you can find how to add Warning, https://docusaurus.io/docs/markdown-features/admonitions.
here is what you need to run our docs, https://refine.dev/docs/contributing/#starting-documentation-in-watch-mode

Hey @BobcatProgrammer , @bhagatpratham ,
We've released<EMAIL_ADDRESS>Thank you!
ps. @bhagatpratham, Are you on our Discord server? If you DM me on Discord, I will give you the "Contributor" role.
Discord: https://discord.gg/UuU3XCc3J5
@BobcatProgrammer, I already gave it to you :)


Default values in schema not applied to new record

When a default value is applied in *.schema.xml:
<table name="page" phpName="Page">
<column name="is_protected" type="INTEGER" required="true" sqlType="tinyint(1) unsigned" defaultValue="1"/>
</table>
the generated BasePage.applyDefaultValues function has:
public function applyDefaultValues()
{
	$this->is_protected = 1;
}

However, when the value is stored in the database it takes on whatever the default is for the table in the MySQL definition.
Logically, if a default value is set in the XML and used within the code, it should also enforce this value for new records, particularly as the value is set when using $page = new Page();
I don't have a patch, but this would simply be guaranteed by inserting a single line into "applyDefaultValues":
public function applyDefaultValues()
{
	$this->is_protected = 1;
	$this->modifiedColumns[] = PagePeer::IS_PROTECTED;
}

This flags the field as having been modified and ensures the field is saved when a new record is added.

@willdurand, What the status of this issue?

Didn't take time to work on that issue. Consider it as a bug fix so it will be scheduled for 1.6.4.

Propel considers that the default value is set both in applyDefaultValues() in PHP, and in the CREATE TABLE SQL statement. When you use the SQL code generated by Propel, this is the case.
That explains why the default values aren't persisted on new objects - this saves processing time (less binding in PHP).
From your description, I understand that you are using a legacy database with default values different from what you show in the XML schema. There are two solutions to this problem - both on your side, not on Propel side:

Use the migrations to upgrade your database to use the same default value in SQL and PHP, or
Override the applyDefaultValues() method in the stub classes to call $this->setIsProtected(true) instead of $this->is_protected = 1


Added "inputStyle" property

What style do you want to pass to the input?
It should be possible to style any elements using CSS directly, that's what I do.

I saw it's possible to use CSS, but I would like to use JS inline styles.

Honestly I feel like Kronos should pass through most major input field keys:

styles
on*
name
required

I totally agree with @krainboltgreene may I submit a PR with that?

Absolutely @dalkir


Update remaining files to match with new way of running experiments

Pull request information

Status: Ready to merge
Kind of changes: bug fix
Related PR or issue: #720

Description

Update evaluate.py to match with the new way of running experiments

Pull Request Test Coverage Report for Build 4965

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals

Change from base Build 4916:
0.0%

Covered Lines:

Relevant Lines:
0

💛  - Coveralls


How to access the page

Hello! How can I access my page? I've now done this,

if I go directly to http://localhost:8081
The connection failed，

so what should I do next? What's wrong with me?Thank you！

You went to port 8080 in your screenshot, not 8081.
On Wed, Oct 30, 2019 at 2:33 AM qkqk-hub<EMAIL_ADDRESS>wrote:

Hello! How can I access my page? I've now done this,
[image: 图片]
https://user-images.githubusercontent.com/54273704/67845702-edee4080-fb3a-11e9-844e-75f965536253.png
if I go directly to http://localhost:8081
The connection failed，
[image: 图片]
https://user-images.githubusercontent.com/54273704/67845783-0a8a7880-fb3b-11e9-8836-b648bb425c44.png
so what should I do next? What's wrong with me?Thank you！
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/igvteam/igv-webapp/issues/118?email_source=notifications&email_token=AAHD2HHGT4OGRZDBA53RRFDQRFIFPA5CNFSM4JGWCKX2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HVK43DA,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHD2HASJLTCBSL2J7ULNA3QRFIFPANCNFSM4JGWCKXQ
.

Thank you for your reply, but after I visited 8081, it still could not link to the page, why?

Sorry I'm unable to read that message, but why are you starting this from an apache-tomcat directory?  It could certainly cause issues running apache-tomcat and http-server on the same computer especially if there are port conflicts.     That's just a guess.

@qkqk-hub  You need to hit http://localhost:8080/index.  In your case http://localhost:8081/index to access application
@jrobinso  It will be good  if you correct this startup URL in  README.md file

Some browsers require the /index in the URL to start the app - so I updated the readme as suggested.

Thank you for your reply. I see


no documentation for re-exported renamed modules

Original reporter: claude@
With a deep module heirarchy and modules re-exporting many modules, I find this syntax much less verbose:
module Foo (module M) where
import Bar as M
import Baz as M

But haddock makes no useful documentation.
The verbose repetitive syntax works as expected with links to the re-exported modules:
module Foo
  ( module Bar
  , module Baz
  ) where
import Bar
import Baz

It would be very nice if haddock recognised module renaming and generated appropriate links to the re-exported modules - as it is now I'm going to have to go back to listing everything twice so that documentation is useable.

Duplicate of #121?

Issue #584 also mentions this issue among others.

should be resolved by #688