Roboticist wardrobe

About the PR

Added roboticist jumpsuit, jumpskirt and labcoat.
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

add: Added roboticist jumpsuit, jumpskirt and labcoat. They're available in RoboDrobe.
tweak: Robotics wardrobe is now filled.

Sure robo is almost ready.


Hint crony install for time syncronization.

cc: https://github.com/akash-network/website/issues/243

that's chrony and it doesn't need to be part of helm-charts


Icon / logo design proposal for NewsBlur

Hello  ,
I'm a graphic designer and i'm willing to design an icon and a logo for your application and i need your permission before starting .
Thank you.

Sure, I'd love to see your concept.

Hey, any interest in this? I'd be willing to pay if I use the icon.


fix: handle undefined clientPrefix for server env and not throw error

fixes #151
Got the same error as #151 (for me, my lsp didn't throw an error, but when i compiled with nodemon, it threw this error)... took a dive into the source code of this repo and figured it was checking if the server envs start with the prefix specified in the clientPrefix option. In my case, clientPrefix wasn't specified, so instead of being an empty string (which the code checks for), it was undefined. The code doesn't handle the case where TPrefix is undefined, and so it errors out.
It was strange that the lsp didn't catch this error, but the express server did.

In case you want to reproduce this issue, create a codebase with:

// .babelrc - not being used though
{
  "presets": ["@babel/preset-env", "@babel/preset-react"]
}

// nodemon.json
{
  "watch": [
    "../../packages/api",
    "../../packages/schemas",
    "../../packages/db",
    "."
  ],
  "ext": "js ts tsx jsx json prisma",
  "exec": "pnpm run with-env ts-node src/index.ts"
}

// package.json
{
  //...
  "private": true,
  "scripts": {
    "dev": "nodemon",
    "with-env": "dotenv -e ../../.env --"
  },
  "dependencies": {
    "@babel/core": "^7.22.20",
    "@babel/node": "^7.22.19",
    "@babel/preset-env": "^7.22.20",
    "@t3-oss/env-nextjs": "^0.6.1",
    "nodemon": "^3.0.2",
    //...
  },
  //...
}

// tsconfig.json
{
  "extends"<EMAIL_ADDRESS>  "compilerOptions": {
    "target": "es5",
    "lib": ["dom", "dom.iterable", "esnext"],
    "allowJs": true,
    "skipLibCheck": true,
    "strict": false,
    "forceConsistentCasingInFileNames": true,
    "noEmit": true,
    "esModuleInterop": true,
    "moduleResolution": "node",
    "resolveJsonModule": true,
    "isolatedModules": true,
    "incremental": true,

    "paths": {
      "~/*": ["./*"]
    },
    "module": "commonjs",
    "jsx": "preserve"
  },

  "include": ["."],
  "exclude": ["node_modules"]
}

Nice catch, I think I forgot to handle this in #121, as none of our test cases throwing any talk errors.


@ObservedResults inside a ViewModel (ObservableObject)

How frequently does the bug occur?
All the time
Description
I would like to put my @ObservedResults variable in my view model (which is an ObservableObject) instead of putting it directly inside the SwiftUI view. When I do this, my variable is correctly populated but the view is not updated anymore.
Stacktrace & log output
No response
Can you reproduce the bug?
Yes, always
Reproduction Steps
Put the @ObservedResults inside a view model instead of the view directly:
@MainActor class ViewModel: ObservableObject {
    // Implicitly use the default realm's objects(Group.self)
    @ObservedResults(Group.self) var groups
}

/// The main content view if not using Sync.
struct LocalOnlyContentView: View {
    // My view model
    @ObservedObject var viewModel = ViewModel()

    var body: some View {
        if let group = viewModel.groups.first {
            // Pass the Group objects to a view further
            // down the hierarchy
            ItemsView(group: group)
        } else {
            // For this small app, we only want one group in the realm.
            // You can expand this app to support multiple groups.
            // For now, if there is no group, add one here.
            ProgressView().onAppear {
                viewModel.$groups.append(Group())
            }
        }
    }
}

You will see that the view is not updating anymore.
Version
10.24.0
What SDK flavour are you using?
Local Database only
Are you using encryption?
No, not using encryption
Platform OS and version(s)
iPhone 13 - iOS 15.4 - Simulator
Build environment
Xcode version: 13.3
Dependency manager and version: SPM

@ObservedResults is only intended to be used on a SwiftUI View.

Do you think it would be possible to add an equivalent to ObservableObject for Realm to mimic the behavior in Combine?

You should just be able to do:
@MainActor class ViewModel: ObservableObject {
    @Published var groups: Results<Group>
}

And create your view model with the realm's results.

@jsflax I just tried it and the view doesn't seem to be updating when there is an update to the results

Closing this as it has gone off topic. @ObservedResults was created for the purpose of being used on SwiftUI Views. To use it in a ViewModel you'll need to make the ViewModel a struct like the example above. Otherwise you will need to notify your View the traditional way by setting up a change listener on the Realm.

@ObservedResults is only intended to be used on a SwiftUI View.

It would be nice to write that under documentation. The description is currently ambiguous.


Submission wdl

Adds wdl for submitting an analysis bundle to ingest.
Adds the following:

hca-dcp/submit.wdl - the submission wdl
docker/secondary-analysis-python/tools/submit - Python package that does most of the submission work

I've modified the secondary-analysis-python Dockerfile to install the "submit" Python package.
The new submit wdl is generic and should be able to submit outputs from any analysis workflow.. Previously, we had a submission wdl that was specific to SmartSeq2.

Yep. Makes sense. Thanks!
On Wed, Sep 20, 2017, 4:58 PM David Shiga<EMAIL_ADDRESS>wrote:

@dshiga commented on this pull request.
In docker/secondary-analysis-python/Dockerfile
https://github.com/HumanCellAtlas/skylab/pull/19#discussion_r140091011:

@@ -5,3 +5,9 @@ LABEL software="Python"
LABEL description="Python with some useful libraries"

RUN pip install requests
+
+RUN mkdir /tools
+
+COPY tools /tools
The development process I want to enable is that I make changes to
submit.py in my local copy of the repo, then I use the test.sh script to
build and run the docker image and run unit tests in it. So for that use
case it's important to have the docker image built from my local copy, so
that my changes are reflected in it and tested.
I'm assuming that anyone else who has the secondary-analysis-python
Dockerfile will have cloned the repo so that pip installing from
tools/submit will work.
Does that make sense?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/HumanCellAtlas/skylab/pull/19#discussion_r140091011,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE_xcJqzjVskt3rU4yb_gNQKS2m6DPpVks5skXx8gaJpZM4Pc926
.

I had a few minor suggestions @dshiga but overall this looks really good! :octocat:

I added 3 commits to this PR. @samanehsan @ambrosejcarr could at least one of you please take another look since you two had the most comments on the original PR? Please feel free to just click through to the diffs for the new commits rather than rereading everything.

51b89ab: This is a squashed version of Saman's PR here, which adds a wrapper for 10x: https://github.com/HumanCellAtlas/skylab/pull/25. I decided to base my branch on Saman's for expediency ahead of the demo.
9b86a70: Most of the changes are here, described further in commit message, stuff needed to make submission work for 10x and to make it more robust.
cae3a2f: Changes to address the PR comments from 3 weeks ago.

@samanehsan it's because align_reads_main is called in a scatter but get_trimmed_and_aligned is not. So each align_reads_main task produces a File genome_output, but then outside the scatter block, align_reads_main.genome_output is an Array[File] that aggregates the files from each instance of the align_reads_main task. get_trimmed_and_aligned needs to consume the whole Array of Files, so I had to change it to expect genome_output to be an Array.
Really, both inputs, trimmed_seqs and genome_output need to be arrays, since they are zipped together inside the get_trimmed_and_aligned.

Oh I see! Thanks for the clarification @dshiga

@ambrosejcarr about the python package being inside the docker dir: The docker build command doesn't let you use the COPY command to get files anywhere outside the directory where the Dockerfile lives. Since the purpose of this docker image is just to hold the secondary-analysis-python tools, it seems like a good idea to keep the Python code close to the Dockerfile anyway. We could think about renaming things so that the parent folder is not named docker but maybe tools. So we would have skylab/tools/submit, and inside submit there would be a Dockerfile as well as the Python package. That is probably best done in another ticket though.

This PR is no longer willing to update itself when I push commits. I will close and open a new one.


notebooks have a potential  bug where  llm_config is used that have functions and tools registered to it

Describe the issue
notebooks have a potential  bug where  llm_config is used that have functions and tools registered to it
I fixed one here: https://github.com/microsoft/autogen/pull/2176
but we have many more to cleanup
Steps to reproduce
No response
Screenshots and logs
No response
Additional Information
No error message should occur in notebook examples

Hi! Is this issue still open?

Hi jtoy, with the least version, is this issue still open?


Add  header for file dma.h

Hi,
I upgraded my dev environment to Ubuntu 24.04 LTS. This comes whith arm-none-eabi-gcc 13.2.1.
When building pico_lib i noticed there is a compiler error in pico_lib/dvi/dma.cpp, which did not occur in previous versions of gcc:
/home/frank/projects/public/pico-infones/pico_lib/dvi/dma.cpp: In constructor 'dvi::DMA::DMA(const dvi::Timing&, PIO)':
/home/frank/projects/public/pico-infones/pico_lib/dvi/dma.cpp:57:13: error: 'printf' was not declared in this scope
57 |             printf("lane %d: DMA ch ctrl %d, ch data %d, FIFO %p, dreq %d\n", i, cfg.chCtrl, cfg.chData, cfg.txFIFO, cfg.dreq);
|             ^~~~~~
/home/frank/projects/public/pico-infones/pico_lib/dvi/dma.cpp:7:1: note: 'printf' is defined in header ''; did you forget to '#include '?
So i added
#include  to pico_lib/dvi/dma.h
which solved the error.
Best regards,
Frank

Thank you for pointing that out.
It seems I missed the include. This happens to me often.
However, I would prefer if the include is added to the cpp file instead of the header file.
Could you please make that change?

Hi,
No problem. I now moved the the include to dma.cpp.
Best regards,
Frank


Dragonrage: Watch torocloud.com

Dragonrage requests the watch of the watch_keyword torocloud\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

torocloud\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Approved by cigien in Charcoal HQ


Replaced overflow hidden with scroll for dmn-editor. Large decision t…

…ables are now viewable again, scrolls ahoy.

Thank you for a quick fix.
Change will be available in the latest nightly build.


Fix darker/flynt/isort/Pygments combination

Install flynt/isort/Pygments via darker "extras", to get always compatibility version combinations.
See: https://github.com/akaihola/darker/issues/472

Codecov Report

Merging #165 (1f6f14e) into master (54d2a39) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   92.72%   92.72%
=======================================
  Files          41       41
  Lines        1223     1223
  Branches      201      201
=======================================
  Hits         1134     1134
  Misses         89       89

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


⚠ AVS (kty) has degraded performance

In 5770665, AVS (kty) (https://avus.com.br) experienced degraded performance:

HTTP code: 200
Response time: 9693 ms

Resolved: AVS (kty) performance has improved in 6629331.


Executing test client: LOADING kvrocks is restoring the db from backup

Report: https://github.com/apache/incubator-kvrocks/runs/7026847364?check_suite_focus=true#step:10:713

I will follow up this issue, it should be caused by forbidding to get role when restoring
the data.

There is another fail with same exception: https://github.com/apache/incubator-kvrocks/runs/7085774273?check_suite_focus=true
But I feel that the root cause of this error and the above error may be different, because the execution path seems to be different.

Looks caused by this line: replication.tcl#L196, need to wait for restoring. Will fix it later.


Tokenizer anomalies

So, ran the rest of my code through the formatter this morning, and two more issues cropped up (both in obsolete code, but thought I'd make you aware).

Something in this breaks the keyword count. Seems like it has to do with the "] at the end of the statement

function test()
    asdf = "asdf: " + anytostring(m.asdf["asdf"])
end function

A single line if statement, like this from the documentation, messes up the indentation after it

sub test()
  if x > 127 then print "out of range"
  end sub

Regards!
-Carl

Oh, just spotted another that is possibly related to #1. Indentation messed up.
  if (m.externalAuth) then
    jsonData["Access Type"] = "Accessible"
    else
      jsonData["Access Type"] = "Link Required"
      end if

Sorry, didn't mean to close the issue, I clicked on the close button thinking it would close the window (:

Haha. I was confused there for a second.
I'll take a look at these tonight and see what I find. Great finds again. This just just goes to show how valuable the whole open source concept is. It only makes the product better.
Thanks for your help! I'll let you know what I find.

Probably the same issue: new indents after each of these lines:
  lineups_index["audio"] = CreateObject("roAssociativeArray")
    lineups_index["video"] = CreateObject("roAssociativeArray")
      ci = 0

I fixed these issues. Fun stuff! The way that I implemented the formatter, I'm not doing any type of code validation (i.e. parsing). It's much more primitive.
The brightscript spec says that the "then" in an if statement is optional. https://sdkdocs.roku.com/display/sdkdoc/Program+Statements#ProgramStatements-IFexpressionTHENstatements[ELSEstatements]
For the one-line if statements, I don't have a nice way of figuring out when the logical expression ends and the operation begins. So things like this will probably still cause issues
sub test()
    if 1=1 and 2=2 return 12
end sub

Until I can write a full brightscript parser, I'll probably not be able to support that particular format.
Anyway, try out the latest npm package and let me know if that solves your issue.

Worked great. Thanks!


Lammps polaris

the added files have the commands to compile and run LAMMPS with CUDA MPS support on Polaris

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
26 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.3%) to 40.877%

Files with Coverage Reduction
New Missed Lines
%

mofa/utils/src/edm.py
26
58.46%

Totals

Change from base Build<PHONE_NUMBER>:
-0.3%

Covered Lines:
3992

Relevant Lines:
9766

💛  - Coveralls


[TBDGen] don't add "_" when adding objc classes to swift TBD

When a class definition is marked with @objc, the swift tbd emits a special section with of the tbd labeled objc-classes, and the values are incorrectly given leading underscores, this causes tapi verification in Pedantic mode to fail, and this change is needed to apply the enhanced swift installapi updates.
<rdar://problem/73664795>

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test macos platform

@swift-ci Please smoke test macos platform


[Notice]Thanks for your valuable contribution

Hi Developers,
Wish you all a brand-new start in 2022!
On the moment to welcome the new year
A delicate gift will be sent to all community contributors!
Anyone who have participated in the contribution can receive the gift after indicating your GitHub ID and submitting a record to verify your identity and contribution. Non-code contributors can also mark your GitHub ID and contribution record in the comment area.
Example: GitHub ID: xxx
Contribution link:
Deadline: January 19, 2022
Tips:
Don't forget to fill out the questionnaire to get the gift.
https://jinshuju.net/f/hSVtNG

Thanks @nielifeng

GitHub ID: wuchunfu
Contribution link:
https://github.com/apache/incubator-seatunnel/pull/701
https://github.com/apache/incubator-seatunnel/pull/713
https://github.com/apache/incubator-seatunnel/pull/752
https://github.com/apache/incubator-seatunnel/pull/818
https://github.com/apache/incubator-seatunnel/pull/821
https://github.com/apache/incubator-seatunnel/pull/826
https://github.com/apache/incubator-seatunnel/pull/862
https://github.com/apache/incubator-seatunnel/pull/869
https://github.com/apache/incubator-seatunnel/pull/894
https://github.com/apache/incubator-seatunnel/pull/808

GitHub ID: wuchunfu
Contribution link: #701 #713 #752 #818 #821 #826 #862 #869 #894 #808

hi, code contributors do not need to show their commit records.

Ok thanks for your reminder.

GitHub ID: wuchunfu
Contribution link: #701 #713 #752 #818 #821 #826 #862 #869 #894 #808

hi, code contributors do not need to show their commit records.

Ok thanks for your reminder

GitHub ID: songjianet
Contribution link: #41

GitHub ID: dongzl
Contribution link: #915

GitHub ID: @asdf2014
Contribution link: https://github.com/apache/incubator-seatunnel/pull/923

GitHub ID: cnmac
Contribution link:
#545
#562
#564

GitHub ID: zhuangchong
Contribution link: https://github.com/apache/incubator-seatunnel-website/pull/16

GitHub ID: ZHAO-Yi-0511
Contribution link:  https://github.com/apache/incubator-seatunnel/issues/686#issuecomment-1006510151

GitHub ID:  an-shi-chi-fan and an-shi-chi-fan-le
贡献链接： #907

GitHub ID: wolfobys
Contribution link:
#2
#775
#761

GitHub ID: xhmz
Contribution link:
#686

GitHub ID: shangeyao
Contribution link: #686  (comment)

GitHub ID: bunenghulai
Contribution link: #40

GitHub ID: bunenghulai
Contribution link: #686 (comment)

GitHub ID: bunenghulai
Contribution link: #686 (comment)

GitHub ID: Aaronoooooo
Contribution link: https://github.com/apache/incubator-seatunnel/issues/686#issuecomment-1007079836

GitHub ID: felix-thinkingdata
Contribution link: https://github.com/apache/incubator-seatunnel/pull/960

GitHub ID: JiaShy94
Contribution link: #686

GitHub ID: xtr1993
Contribution link:
#831
#850
#800
#845
#945

GitHub ID: xbkaishui
Contribution links:
#930

GitHub ID: superguhua
Contribution link:
#686

Github ID: chaozwn
Contribution link: #992

GitHub ID: xiaobaiwalk
Contribution link: #686

GitHub ID: batclubyoyo
Contribution link: #569

GitHub ID: wolfboys Contribution link: #2 #775 #761

Hi there, I haven't received your post information here  https://jinshuju.net/f/hSVtNG, please fill in the sheet before 1.19.2022.

batclubyoyo
Hi there, I haven't received your post information here https://jinshuju.net/f/hSVtNG, please fill in the sheet before 1.19.2022.

Hi there, I haven't received your post information here https://jinshuju.net/f/hSVtNG, please fill in the sheet before 1.19.2022.

GitHub ID: @asdf2014 Contribution link: #923

Hi there, I haven't received your post information here https://jinshuju.net/f/hSVtNG, please fill in the sheet before 1.19.2022.

GitHub ID: zhongjiajie
Contribution link: #854


Verify all Alderaan contracts on https://verification.komputing.org/

It would be nice to verify all contracts or even automate the process of verifying contracts on https://verification.komputing.org/ for the Alderaan contracts.

[ ] Verify all Alderaan contract
[ ] (optional) Automate the process for the future

A bit more in-depth documentation can be found here: https://github.com/ethereum/sourcify

Except for the lack of clear instructions, their UI is actually really nice to use! This will be a quick thing to do, so I'll do it right away.

I didn't do a full automation. When we do this for the next time, we can automate it. Here's the gist:

Collect files needed for verification (it always includes all sources, but their server is smart enough to pick out the right ones):

for contract in $(jq '.contracts | keys[]' raiden_contracts/data/contracts.json -r); do
    mkdir -p verify/$contract
    jq ".contracts.$contract.metadata" -r raiden_contracts/data/contracts.json > verify/$contract/metadata.json
    cp raiden_contracts/data/source/{lib,raiden,services}/* verify/$contract
done

For each contract, look up the address in raiden_contracts/data/deployment_{services_,}mainnet.json and submit all files created in the previous step in verify/$contract.

Can you send me the link to to the sources, once they're ready?

http://contractrepo.komputing.org/contract/1/0xa80aEc9eebD8058A1468e563C025999590F32C08
http://contractrepo.komputing.org/contract/1/0x1c62fF66aF8aaD410065E02338F5bFbbe23e1f10
http://contractrepo.komputing.org/contract/1/0x727DDdBD042d891180A252C7A20634a696A16925
http://contractrepo.komputing.org/contract/1/0x960f01E9E219E1c8564784a050fD1cA51651592D
http://contractrepo.komputing.org/contract/1/0x70f0c29b946E63803BD0Be796E17E47138668A68
http://contractrepo.komputing.org/contract/1/0x6d07A2ef8De5d7D48337510BCEb9FEEa5424b20c


Idle more then one game at once.

Recently I have found that ASF only idles one game at a time. I also have noticed that IdleMaster sometimes would idle multiple games at once not sure about the patter however.
So I am simply wondering if it's possible to idle a specified amount of games at once to speed up the card farming process.

Please review the guidelines for contributing to this repository.

https://github.com/JustArchi/ArchiSteamFarm/blob/master/CONTRIBUTING.md

If my issue is not meeting contributing guidelines specified above, especially if it's a question or technical issue, please close my issue immediately - I won't complain.

Please explain to me how this doesn't meet the guidelines?
On Wed, Oct 12, 2016, 12:20 AM Łukasz Domeradzki<EMAIL_ADDRESS>wrote:

Please review the guidelines for contributing to this repository.
https://github.com/JustArchi/ArchiSteamFarm/blob/master/CONTRIBUTING.md
If my issue is not meeting contributing guidelines specified above,
especially if it's a question or technical issue, please close my issue
immediately - I won't complain.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/JustArchi/ArchiSteamFarm/issues/347#issuecomment-253115435,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC9ACGkaXeit3jhEvmV-owDqCJtDEX88ks5qzGAXgaJpZM4KUU60
.

Sorry didn't notice that this was already possible (I didn't see the tags in the email.)
Also didn't notice it in the features or anywhere on the wiki, I know that you can have multiple bots and multiple accounts. But what I'm asking is... Is it possible to have a single bot attempt to idle a set amount of games either consistently or in intervals?

GitHub is NOT technical support.

I'm not sure how it's even possible to miss info you were initially looking for, that is included in at least 3 different places over the wiki, and I'm also not sure why you still don't follow contribution guidelines, but you won't get any answer to your technical questions here.


GH-385 Fix instantiate scene to respect input pin

Fixes #385

Applied to main (=2.1) and branch 2.0.


The files sort may cause that the README.md file is after the child directory

const sameDir = path.dirname(a) == path.dirname(b)
            if (sameDir && isReadme(a))
              return -1
            if (sameDir && isReadme(b))
              return 1
            return a < b ? -1 : a > b ? 1 : 0

In this code
if the directory like this:
├── README.md
│   ├── ADIC
               └── TEST.md

the files  is like this:
README.md
ADIC/TEST.md
the summery may like this:
(TEST)[ADIC/TEST.md]
(READ)[README.md ]
but it's not my expect
I think that the 'sameDir ' function should judge
 path.dirname(b).index(path.dirname(a)) != -1

Hi,
have you got a PR and/or a branch where this works? I would be happy to try it. Maybe with a provided test case.
Thank you in advance,
Julian

HI,
beacase I have not have the guide of the gitbook plugin developig, so I can't try my think in the gitbook enviroment,  where are you learning about the gitbook pulugins? can you share it to me ?
But lately, I found that the summary plugin doesn't work in the first executing the gitbook serve command, the secode one it works, the first one uses the summary file generated by the laste time.
Thank you for your reply,
zpfang

Solved with #9

Released as 0.2.1


Stop auto-assigning default addresses to checkout.

I want to merge this change because the default address should be a hint for the API client. Saleor should not be the one deciding on whether to use the default address or not.

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-7135 Stop auto-assigning default addresses to checkout


support Python 3.5.0 too

see https://github.com/dask/dask-jobqueue/pull/312#issuecomment-522478412

Thanks a lot for the PR! Dask does this as well (see https://github.com/dask/dask/blob/master/setup.py#L51) so let's merge this one.


Dd7to9 offscreen surfaces

After working around #65 Dungeon Keeper 2 is always crashing at the end of the loading screen. It creates a series of weirdly sized DDSCAPS_OFFSCREENPLAIN|DDSCAPS_SYSTEMMEMORY surfaces which get turned into IDirect3DTexture9 textures. I guess the Lock2 is somehow wrong.
With only ConvertToDirectDraw7/ConvertToDirect3D7 it works:
m_IDirectDrawX::CreateSurface2 (00B43460){DDSD_WIDTH|DDSD_HEIGHT|DDSD_CAPS|DDSD_PIXELFORMAT,82,2173,302517504,6103731,302517504,7609384,7610460,0019C828,{0x741c2c,0x5b6015},{0x74205c,0x0},{0x0,0x19c868},{0x741c28,0x474e5089},{0x40,0,32,0xff0000,0xff00,0xff,0x0},32,{{ DDSCAPS_OFFSCREENPLAIN  DDSCAPS_SYSTEMMEMORY },0x0,0x0,0x0},0} 4
Creating interface m_IDirectDrawSurfaceX::m_IDirectDrawSurfaceX (0F7DC598) converting interface from v4 to v7
m_IDirectDrawSurfaceX::GetSurfaceDesc2 (0F7DC598)
m_IDirectDrawSurfaceX::Lock2 (0F7DC598)
m_IDirectDrawSurfaceX::GetSurfaceDesc2 (0F7DC598)
m_IDirectDrawSurfaceX::Unlock (0F7DC598)
m_IDirectDrawX::CreateSurface2 (00B43460){DDSD_WIDTH|DDSD_HEIGHT|DDSD_CAPS|DDSD_PIXELFORMAT,205,4879,1689704,5992079,1689844,7118016,59568128,006CBAC8,{0x5,0x38cf5b0},{0x50,0x0},{0x5,0x1},{0x19c884,0x639524},{0x40,0,32,0xff0000,0xff00,0xff,0x0},32,{{ DDSCAPS_OFFSCREENPLAIN  DDSCAPS_SYSTEMMEMORY },0x0,0x0,0x0},0} 4
Creating interface m_IDirectDrawSurfaceX::m_IDirectDrawSurfaceX (0F7DD348) converting interface from v4 to v7
m_IDirectDrawSurfaceX::GetSurfaceDesc2 (0F7DD348)
m_IDirectDrawSurfaceX::GetSurfaceDesc2 (0F7DC598)
m_IDirectDrawSurfaceX::GetSurfaceDesc2 (0F7DD348)
m_IDirectDrawSurfaceX::Blt (0F7DD348){0,0,206,4880} 0F7565C8 {0,0,82,2174} 16777216 0
m_IDirectDrawSurfaceX::QueryInterface (0F7DC598) IID_GetRealInterface
m_IDirectDrawSurfaceX::Release (0F7DC598) v4
m_IDirectDrawSurfaceX::~m_IDirectDrawSurfaceX (0F7DC598) deleting interface!
m_IDirectDrawX::CreateSurface2 (00B43460){DDSD_WIDTH|DDSD_HEIGHT|DDSD_CAPS|DDSD_PIXELFORMAT,42,20,302517504,6103731,302517504,7609384,7610460,0019C828,{0x741c2c,0x5b6015},{0x74205c,0x0},{0x0,0x19c868},{0x741c28,0x474e5089},{0x40,0,32,0xff0000,0xff00,0xff,0x0},32,{{ DDSCAPS_OFFSCREENPLAIN  DDSCAPS_SYSTEMMEMORY },0x0,0x0,0x0},0} 4
Creating interface m_IDirectDrawSurfaceX::m_IDirectDrawSurfaceX (0F7DD590) converting interface from v4 to v7
m_IDirectDrawSurfaceX::GetSurfaceDesc2 (0F7DD590)
m_IDirectDrawSurfaceX::Lock2 (0F7DD590)
m_IDirectDrawSurfaceX::GetSurfaceDesc2 (0F7DD590)
m_IDirectDrawSurfaceX::Unlock (0F7DD590)

Dd7to9:
m_IDirect3DDevice9Ex::BeginScene (09515F50)
m_IDirectDrawX::CreateSurface2 (00A3BB48){0x1007,82,2173,151457024,6103731,151457024,7609384,7610460,0019C828,{0x741c2c,0x5b6015},{0x74205c,0x0},{0x0,0x19c868},{0x741c28,0x474e5089},{0x40,0,32,0xff0000,0xff00,0xff,0x0},32,{{ DDSCAPS_OFFSCREENPLAIN  DDSCAPS_SYSTEMMEMORY },0x0,0x0,0x0},0} 4
m_IDirect3D9Ex::CheckDeviceFormat (00A617D0)0 1 D3DFMT_X8R8G8B8 0 D3DRTYPE_SURFACE D3DFMT_X8R8G8B8
Creating interface m_IDirectDrawSurfaceX::m_IDirectDrawSurfaceX (095F17F0) converting interface from v4 to v9
m_IDirectDrawSurfaceX::AddRef (095F17F0) v4
m_IDirectDrawSurfaceX::GetSurfaceDesc2 (095F17F0)
m_IDirectDrawSurfaceX::GetSurfaceDesc2 (095F17F0):{0x100f,82,2173,328,0,151457024,7609384,0,0019C828,{0x741c2c,0x5b6015},{0x74205c,0x0},{0x0,0x19c868},{0x741c28,0x474e5089},{0x40,0,32,0xff0000,0xff00,0xff,0x0},32,{{ DDSCAPS_OFFSCREENPLAIN  DDSCAPS_SYSTEMMEMORY },0x0,0x0,0x0},0}
m_IDirectDrawSurfaceX::Lock2 (095F17F0){0x0,0,0,0,0,0,0,0,00000000,{0x0,0x0},{0x0,0x0},{0x0,0x0},{0x0,0x0},{0x0,0,0,0x0,0x0,0x0,0x0},0,{{},0x0,0x0,0x0},0},1
m_IDirect3DDevice9Ex::TestCooperativeLevel (09515F50)0
m_IDirectDrawSurfaceX::CreateD3d9Surface (095F17F0) D3d9 Surface size: 82x2174 Format: D3DFMT_X8R8G8B8
m_IDirect3DDevice9Ex::CreateTexture (09515F50)
Creating interface m_IDirect3DTexture9::m_IDirect3DTexture9 (095C5330)
m_IDirect3DDevice9Ex::CreateTexture Succeeded
m_IDirect3DTexture9::LockRect (095C5330)
m_IDirectDrawSurfaceX::ChangeUniquenessValue (095F17F0)
m_IDirectDrawSurfaceX::Lock2 (095F17F0){DDSD_WIDTH|DDSD_HEIGHT|DDSD_CAPS|DDSD_PITCH|DDSD_LPSURFACE|DDSD_PIXELFORMAT,82,2173,328,0,151457024,7609384,0,11BBE040,{0x741c2c,0x5b6015},{0x74205c,0x0},{0x0,0x19c868},{0x741c28,0x474e5089},{0x40,0,32,0xff0000,0xff00,0xff,0x0},32,{{ DDSCAPS_OFFSCREENPLAIN  DDSCAPS_SYSTEMMEMORY },0x0,0x0,0x0},0}
m_IDirectDrawSurfaceX::Lock2 (after){DDSD_WIDTH|DDSD_HEIGHT|DDSD_CAPS|DDSD_PITCH|DDSD_LPSURFACE|DDSD_PIXELFORMAT,82,2173,328,0,151457024,7609384,0,11BBE040,{0x741c2c,0x5b6015},{0x74205c,0x0},{0x0,0x19c868},{0x741c28,0x474e5089},{0x40,0,32,0xff0000,0xff00,0xff,0x0},32,{{ DDSCAPS_OFFSCREENPLAIN  DDSCAPS_SYSTEMMEMORY },0x0,0x0,0x0},0}
m_IDirectDrawSurfaceX::GetSurfaceDesc2 (095F17F0)
m_IDirectDrawSurfaceX::GetSurfaceDesc2 (095F17F0):{0x100f,82,2173,328,0,151457024,7609384,0,0019C828,{0x741c2c,0x5b6015},{0x74205c,0x0},{0x0,0x19c868},{0x741c28,0x474e5089},{0x40,0,32,0xff0000,0xff00,0xff,0x0},32,{{ DDSCAPS_OFFSCREENPLAIN  DDSCAPS_SYSTEMMEMORY },0x0,0x0,0x0},0}
Quiting DxWrapper

full logs
https://gist.github.com/Trass3r/6854537d31416ff1b8b68e365db44306
https://gist.github.com/Trass3r/da4f799bfcd6a10253f6fae310f43df1

It always seems to crash inside the movie decoding 65CA50 function even with the -nomovies -level mpd6 -32biteverything parameters. The logs seem to confirm that:
m_IDirect3DDeviceX::Clear (08A39810)
m_IDirect3DDevice9Ex::Clear (089EBC90)
m_IDirect3DDeviceX::BeginScene (08A39810)
m_IDirect3DDevice9Ex::BeginScene (089EBC90)
m_IDirectDrawSurfaceX::Lock2 (093E9C88){0x64f2e808,1689268,0,1153611423,1688664,1686932,1691196,1995936688,33D9E5CB,{0xfffffffe,0x19c7d0},{0x64f1434e,0x19c6c0},{0x70d3c0,0x793388},{0x65737341,0x6f697472},{0x64656c69,MAKEFOURCC(':', ' ', 'F', 'a'),1698981227,0x65636976,0x423a3a33,0x6e696765,0x6e656353},1634082926,
    {{ DDSCAPS_3DDEVICE  DDSCAPS_ALLOCONLOAD  DDSCAPS_BACKBUFFER  DDSCAPS_FRONTBUFFER  DDSCAPS_HWCODEC  DDSCAPS_LIVEVIDEO  DDSCAPS_LOCALVIDMEM  DDSCAPS_MODEX  DDSCAPS_NONLOCALVIDMEM  DDSCAPS_OFFSCREENPLAIN  DDSCAPS_PRIMARYSURFACE  DDSCAPS_SYSTEMMEMORY  DDSCAPS_TEXTURE },0x69772039,0x48206874,0x55534552},807425100},1
m_IDirect3DDevice9Ex::TestCooperativeLevel (089EBC90)0
m_IDirectDrawSurfaceX::CreateD3d9Surface (093E9C88) D3d9 Surface size: 128x128 Format: D3DFMT_A8R8G8B8 dwCaps: 0x1800
m_IDirect3DDevice9Ex::CreateTexture (089EBC90)
Creating interface m_IDirect3DTexture9::m_IDirect3DTexture9 (093F8698)
m_IDirect3DTexture9::LockRect (093F8698)
m_IDirect3DTexture9::LockRect (093F8698)
m_IDirectDrawSurfaceX::Lock2 Error: failed to lock surface texture

surfaceTexture->LockRect(0, pLockedRect, pRect, Flags);

with Flags=0 returns D3DERR_INVALIDCALL.
DDSCAPS_SYSTEMMEMORY | DDSCAPS_OFFSCREENPLAIN might not be handled well enough in CreateD3d9Surface.
https://learn.microsoft.com/en-us/windows/win32/api/d3d9helper/nf-d3d9helper-idirect3dtexture9-lockrect#remarks

Textures created with D3DPOOL_DEFAULT are not lockable.

Creating interface m_IDirectDrawSurfaceX::m_IDirectDrawSurfaceX (092FE0F8) converting interface from v4 to v9
m_IDirectDrawSurfaceX::AddRef (092FE0F8) v4
m_IDirectDrawSurfaceX::GetSurfaceDesc2 (092FE0F8)
m_IDirectDrawSurfaceX::GetSurfaceDesc2 (092FE0F8):{0x100f,1024,768,4096,0,1690856,16,0,0019CC9C,{0x5b858b,0x19cc9c},{0x742090,0x742094},{0x19cce8,0x742070},{0x19cd48,0x742074},{0x40,0,32,0xff0000,0xff00,0xff,0x0},32,{{ DDSCAPS_OFFSCREENPLAIN  DDSCAPS_SYSTEMMEMORY },0x0,0x0,0x0},0}
m_IDirectDrawSurfaceX::Lock2 (092FE0F8){0x0,0,0,0,0,0,0,0,00000000,{0x0,0x0},{0x0,0x0},{0x0,0x0},{0x0,0x0},{0x0,0,0,0x0,0x0,0x0,0x0},0,{{},0x0,0x0,0x0},0},1
m_IDirect3DDevice9Ex::TestCooperativeLevel (08A5BEB0)0
m_IDirectDrawSurfaceX::CreateD3d9Surface (092FE0F8) D3d9 Surface size: 1024x768 Format: D3DFMT_X8R8G8B8 ddsCaps: {{ DDSCAPS_OFFSCREENPLAIN  DDSCAPS_SYSTEMMEMORY },0x0,0x0,0x0}
m_IDirect3DDevice9Ex::CreateTexture (08A5BEB0) 1024x768x1 0 D3DFMT_X8R8G8B8 0
Creating interface m_IDirect3DTexture9::m_IDirect3DTexture9 (09317660)
m_IDirect3DTexture9::LockRect (09317660)
m_IDirect3DTexture9::LockRect (09317660)
m_IDirectDrawSurfaceX::Lock2 Error: failed to lock surface texture
m_IDirectDrawSurfaceX::Release (092FE0F8) v4
m_IDirectDrawSurfaceX::~m_IDirectDrawSurfaceX (092FE0F8) deleting interface!
m_IDirectDrawSurfaceX::ReleaseD9Surface Releasing Direct3D9 texture surface
m_IDirect3DTexture9::Release (09317660)
m_IDirectDrawSurfaceX::Blt (08A56508)null 09CE4918 null 16777216 0
m_IDirect3DDevice9Ex::TestCooperativeLevel (08A5BEB0)0
m_IDirectDrawSurfaceX::CreateD3d9Surface (08A56508) D3d9 Surface size: 1024x768 Format: D3DFMT_X8R8G8B8 ddsCaps: {{ DDSCAPS_LOCALVIDMEM  DDSCAPS_VIDEOMEMORY },0x0,0x0,0x0}
m_IDirect3DDevice9Ex::CreateTexture (08A5BEB0) 1024x768x1 0 D3DFMT_X8R8G8B8 0
Creating interface m_IDirect3DTexture9::m_IDirect3DTexture9 (093171A0)
m_IDirectDrawSurfaceX::QueryInterface (08A56730) IID_GetInterfaceX
m_IDirect3DDevice9Ex::TestCooperativeLevel (08A5BEB0)0
m_IDirect3DDevice9Ex::TestCooperativeLevel (08A5BEB0)0
m_IDirect3DTexture9::GetSurfaceLevel (09317020)
Creating interface m_IDirect3DSurface9::m_IDirect3DSurface9 (09D20AD8)
m_IDirect3DTexture9::GetSurfaceLevel (093171A0)
Creating interface m_IDirect3DSurface9::m_IDirect3DSurface9 (09D204A8)
D3DXLoadSurfaceFromSurface
m_IDirect3DSurface9::GetDesc (09D204A8)
m_IDirect3DSurface9::GetDesc (09D20AD8)
m_IDirect3DSurface9::GetDevice (09D20AD8)
m_IDirect3DDevice9Ex::AddRef (08A5BEB0)
m_IDirect3DDevice9Ex::StretchRect (08A5BEB0)
m_IDirect3DDevice9Ex::Release (08A5BEB0)
m_IDirect3DSurface9::GetDesc (09D20AD8)
m_IDirect3DSurface9::LockRect (09D20AD8)
m_IDirect3DSurface9::GetDesc (09D20AD8)
m_IDirect3DSurface9::GetDevice (09D20AD8)
m_IDirect3DDevice9Ex::AddRef (08A5BEB0)
m_IDirect3DDevice9Ex::CreateTexture (08A5BEB0) 1024x768x1 0 D3DFMT_X8R8G8B8 2

Yes, I realized this after the change.  However, the latest check-in should resolve this issue:  280ba38c49f68353239f0d13cbab0999c602869b

Yeah ok now we're back to the original crash I assume.
https://gist.github.com/Trass3r/76463d7fc4d5921c53226773f8b65cc6

The issue is that this game uses Direct3D and so far I have only started the conversion from Direct3D to Direct3D9.    But I do have this game and will take a look later.
Note: this game uses the Direct3D version 3 interfaces.  So far the only games I have seen work are the ones that use the Direct3D version 7 interfaces.

Yeah I know, on the plus side it doesn't use many D3D features. But it's hard to debug since it crashes deep down in game code when it accesses some surface.

Ok, I put a fix in that solves this first issue.  There seems to be some other issue I need to look into though.

Other peculiarities are the GOG patch messing around with draw calls and multiple windows getting created. I guess for example the video rendering was done with an external EA library that creates its own window.

If you set FullscreenWindowMode to 1 then you can start the game normally and see the intro video.  The video is done using IID_IMMDeviceEnumerator, which does not interact well with Direct3D9 when in exclusive fullscreen mode.

"I don't see the keeper hand"

Yes, the menu is also not being seen.  I'll need to figure out why these items are not being seen.  Also, the display looks wrong as it only appears in the upper left corner of the screen:

You need to run the game in Windows 7 compatibility.
You need to set the following settings in dxwrapper.ini:

[Compatibility]
Dd7to9                     = 1

[Dd7to9]
DdrawOverrideWidth         = 640
DdrawOverrideHeight        = 480

[d3d9]
FullscreenWindowMode       = 1

This does not solve the invisible menu and hand, but otherwise makes everything work.

It looks like the game play is in 800x600 but the menu is 640x480.  I put a fix in that allows ddraw to get the correct resolution so you don't need to use DdrawOverrideWidth/Height.

Yeah they are using different resolutions.
And as I said the GOG patch also fiddles around with those things, e.g. via ScaleMode: https://www.gog.com/forum/dungeon_keeper_series/dk2_gog_configini_extra_settings/post2

And as I said the GOG patch also fiddles around with those things, e.g. via ScaleMode:

After converting it to Direct3D9 we already have many of those types of options: antialiasing, anisotropic filtering, vertical sync, etc.  I tried the Direct3D9 antialiasing and it looks pretty good with this game, IMHO.

It might have to do with the viewport. The structures changed in v5 and v7.

There is already code in there to convert the viewport back and forth between the two structures.  I know the code works on this game because the same code is used for ConvertToDirectDraw7/ConvertToDirect3D7, which works fine with this game.
Anyways, I am not too worried about the resolution and scaling.  I can use the surface size to determine the resolution since this game never calls the SetDisplayMode() function.
The real question is why the hand and the menu items on the first screen after the intro video are missing.

It's unfortunate RenderDoc doesn't support DX9.
When trying other wrappers like dgVoodoo I think the hand part always showed up weirdly as its own frame.

The D3D backend was something they only added after the fact. That's why they are still using their SW renderer for T&L, just sending D3DFVF_XYZRHW vertices to be rasterized.

Ok, I see what is happening here.  This game is mixing 2D and 3D graphics.  However, dxwrapper only supports pure 2D or pure 3D modes.  Once the intro video ends it switches to 3D mode.  All of the graphics you see are 3D.  All of the graphics you don't see are the 2D graphics.
All of the missing graphics are on the primary surface.  To fix this we would need to find a way to show the primary surface on top of the scene before calling EndScene() and Present().

With FullscreenWindowMode it works quite well now.
It does mess with my desktop resolution though, setting it to 1024x768.
The GOG patch handles this by rendering to a surface I think and upscaling it to the desktop resolution.

Once the intro video ends it switches to 3D mode.

Yes the main menu is actually a map.
The movies can be skipped with -nomovies or -level mpd6 btw, good for debugging.

I put a hack into the module under the DDraw-2D-3D-Mix branch that allows the menu and hand to be seen.
However, this exposes another issue where dxwrapper is not detecting the correct buffer size.  If you manually put the correct size into DdrawOverrideWidth/Height then it works for the most part.
I'm not quite sure how to detect the correct display size at this point.

I put a few fixes in for this game.  The overlay is now showing up correctly in both the menu and the game play.  There are still a few graphical anomalies, especially during the videos.  But it should be completely playable at this point.
Here is the build with the fixes in it:  dxwrapper.zip
It requires the following settings:
[Compatibility]
Dd7to9                     = 1

[Dd7to9]
DdrawOverridePrimaryWidth  = 640
DdrawOverridePrimaryHeight = 480

[d3d9]
FullscreenWindowMode       = 1

Note: if you are starting the game using the level hack then you may need to adjust the size to something else, like this:
[Dd7to9]
DdrawOverridePrimaryWidth  = 800
DdrawOverridePrimaryHeight = 600

Thanks! No need to make the videos perfect. I always use -nomovies or -level.

Unfortunately can't test atm. Some definitions conflict with the Win 10/11 SDK d3dcommon.h like: https://github.com/elishacloud/dxwrapper/blob/master/Libraries/d3dx9.h#L58

Some definitions conflict with the Win 10/11 SDK d3dcommon.h:

Ok, I just put a fix in that should resolve that issue.  I am now using d3dcommon.h for the definitions in d3dx9.h.

Is it normal that the keeper hand is a bit transparent?

That is because when I draw the texture I draw it with blending enabled.  This is because the texture is all black and only has the hand and menu on it.  If I draw it without blending then it will only show the hand and the menu items and then a black screen.
Technically it should not be transparent.  The game is trying to write directly to the render target.  However, since writing to a render target is slow and not yet supported in dxwrapper I have it write to a black texture and then do blending to show it on the screen.  Later I will find a better way to do this.

Seems like it's working now with Dd7to9.


Fix code scanning alert - Semgrep Finding: javascript.sequelize.security.audit.sequelize-injection-express.express-sequeliz...

Tracking issue for:

[ ] https://github.com/varol-adem/juice-shop/security/code-scanning/156

SQL Injection gerçekleştirilebilir.


Automatically deploy @ContextName Camel context beans

Thanks the code has been merged. Do you mind closing

Closing. Thanks.


Standard 404 rule causes infinite redirect when running static Hugo site with dev command

Describe the bug
The following has been present, unchanged, in our _redirects file on our live site without any issues for months if not years:
/* /404.html 404

However, it seems that this redirect command causes the website served by netlify dev to enter an infinite redirect loop when trying to navigate to any page, including /. This renders the entire site inaccessible. Removing this line from _redirects causes the site to work as normal (although 404s then simply redirect to the home page instead of displaying 404.html).
My reading of the docs suggests that this should be a valid rule and that this would be expected behavior only if ! was used, which it is not in this case.
To Reproduce
Unfortunately I cannot share our GitHub repository as it is private, however this is the full text of our _redirects file:
_redirects.txt (.txt added so Github would allow the upload)
The issue happens when the last line is un-commented.
You can see these rules in action on our live site at jaquishbiomedical.com
Configuration

If possible, please copy/paste below your netlify.toml:

Full netlify.toml
# Default build command.
[build]
publish = "public"
command = "hugo --gc --minify --baseURL $URL --environment production"
HUGO_VERSION = "0.78.2"
HUGO_ENV = "production"
HUGO_ENABLEGITINFO = "true"

##############################################################################
# Master branch context: all deploys from the Master branch set in your site's
# deploy contexts will inherit these settings.
##############################################################################

[context.master]
command = "hugo --gc --minify --enableGitInfo --baseURL $URL --environment production"

[context.master.environment]
HUGO_ENV = "production"
HUGO_VERSION = "0.78.2"
HUGO_ENABLEGITINFO = "true"

##############################################################################
# Staging branch context: all deploys from the staging branch set in your site's
# deploy contexts will inherit these settings.
##############################################################################

[context.staging]
command = "hugo --gc --minify --enableGitInfo --baseURL $URL --environment development"

[context.staging.environment]
HUGO_ENV = "development"
HUGO_VERSION = "0.78.2"
HUGO_ENABLEGITINFO = "true"

##############################################################################
# Deploy Preview context: all deploys generated from a pull/merge request will
# inherit these settings.
##############################################################################

[context.deploy-preview]
command = "hugo --gc --buildFuture --baseURL $DEPLOY_PRIME_URL --environment development"

[context.deploy-preview.environment]
HUGO_ENV = "development"
HUGO_VERSION = "0.78.2"
HUGO_ENABLEGITINFO = "true"

##############################################################################
# Devstore Deploy Context:
#
##############################################################################

[context.task1314c]
command = "hugo --gc --minify --enableGitInfo --baseURL $URL --environment devstore --config config.toml,devstoreconfig.toml"

[context.task1314c.environment]
HUGO_ENV = "devstore"
HUGO_VERSION = "0.78.2"
HUGO_ENABLEGITINFO = "true"

##############################################################################
# Branch Deploy context: all deploys that are not from a pull/merge request or
# from the Production branch will inherit these settings.
##############################################################################

[context.branch-deploy]
command = "hugo --gc --baseURL $DEPLOY_PRIME_URL --environment development"

[context.branch-deploy.environment]
HUGO_ENV = "development"
HUGO_VERSION = "0.78.2"
HUGO_ENABLEGITINFO = "true"

##############################################################################
# devsite.jaquishbiomedical.com just a site to always have the devstore products running
##############################################################################

[context.devstore]
command = "hugo --gc --minify --enableGitInfo --baseURL $URL --config config.toml,devstoreconfig.toml --environment devstore"

[context.devstore.environment]
HUGO_ENV = "development"
HUGO_VERSION = "0.77.0"
HUGO_ENABLEGITINFO = "true"

##############################################################################
# Develop site context: must manually set branch
##############################################################################

[context.task1607a-save-fb-tracking-data-for-shopify]
command = "hugo --gc --minify --enableGitInfo --baseURL $URL --environment development"

[context.task1607a-save-fb-tracking-data-for-shopify.environment]
HUGO_ENV = "development"
HUGO_VERSION = "0.78.2"
HUGO_ENABLEGITINFO = "true"

##############################################################################
# Plugins
##############################################################################
#[[plugins]]
#package = "netlify-plugin-cypress"
#    [plugins.inputs]
#    record = true

##############################################################################
# Headers
# For info about Netlify/TOML header formatting see: https://docs.netlify.com/routing/headers/#syntax-for-the-headers-file
##############################################################################
[[headers]]
  for = "/*"
  [headers.values]
    Access-Control-Allow-Origin = "*"
    Strict-Transport-Security = '''
    max-age=63072000,
    includeSubDomains,
    preload'''

# Proxy Caching
# The default Netlify cache-control header, are `max-age=0, must-revalidate, public` which means all content should be cached but also re-validated.
# `s-max-age` Takes precedence over `max-age` or the `Expires` header, but it only applies to shared caches (e.g., proxies) and is ignored by a private cache. This means we’re using custom headers on Netlify to tell Cloudflare (our CDN) how long to cache assets. We’ll then control how long browsers cache using CDN settings.
# 604800 seconds translates to 7 days, so during normal operation Cloudflare will cache images, CSS and JavaScript files for 7 days.
# Even if Cloudflare has cached our .css or .js we are using adding a hash to the filenames which causes any chance to be cache busting. Hugo has a cache-busting hash baked in called fingerprinting.  Old versions and new versions will be fetched and cached separately due to this new filename with a hash. This makes it safe to aggressively cache across the CDN and in browsers.
# For more info: https://developers.google.com/web/fundamentals/performance/optimizing-content-efficiency/http-caching#defining_optimal_cache-control_policy

# ******** Non-hashed static assets ********
# These we're ok caching for 7 days on a local machine and 7 days on Edge. (see above)
[[headers]]
  for = "/img-gen/*"
  [headers.values]
    cache-control = '''
    public,
    s-max-age=604800,
    max-age=604800'''

[[headers]]
  for = "/images*"
  [headers.values]
    cache-control = '''
    public,
    s-max-age=604800,
    max-age=604800'''

[[headers]]
  for = "/fonts/*"
  [headers.values]
    cache-control = '''
    public,
    s-max-age=604800,
    max-age=604800'''

[[headers]]
  for = "/favicon/*"
  [headers.values]
    cache-control = '''
    public,
    s-max-age=604800,
    max-age=604800'''

# ******** Hashed assets ********
# These we're ok to cache for 1 year on a local machine and 1 year on Edge (see above)

[[headers]]
  for = "/*.css"
  [headers.values]
    cache-control = '''
    public,
    s-max-age=31536000,
    max-age=31536000'''

[[headers]]
  for = "/*.js"
  [headers.values]
    cache-Control = '''
    public,
    s-max-age=31536000,
    max-age=31536000'''

System:
    OS: Windows 10 10.0.18363
    CPU: (8) x64 Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
    Memory: 7.40 GB / 15.96 GB
  Binaries:
    Node: 12.13.0 - C:\Program Files\nodejs\node.EXE
    npm: 6.14.8 - C:\Program Files\nodejs\npm.CMD

Expected behavior
I expect for the local version of the website served by netlify dev to be accessible and useable just like it is when the redirect rule is removed.
CLI Output
n/a (Site launches successfully)
Additional context
The error causes the only thing visible when trying to visit the site to be the error page showing "too many redirects" error on both Chrome and Firefox.

Any word on a fix for this? We use custom 404 pages via redirects for all our sites so this make netlify dev untenable to use currently. Also thanks for posting this @LandGod, I was having a hard time figuring out what was causing this issue.

Hi @rybrad, we have an experimental flag that might help.
Can you try running ntl dev --edgeHandlers? That will switch the CLI to use a redirect engine that is much closer to the one we have in production instead of emulating redirects via JavaScript.

@erezrokah just tried this and while the home page of my site loads up, clicking any link or trying to manually navigate to any other page it fails.
In the Chrome console I'm seeing 504 (Gateway Timeout)
And on the page itself all I get is: Failed to connect to host: Timeout while establishing connection
No output from the console that I ran netlify dev --edgeHandlers in other than the standard server started successfully message and this: ✔ Done processing request remaps, header rules and Edge Handlers

@erezrokah Homepage loads fine, all other pages 404 when I keep the 404 redirect in _redirects. When I remove the 404 redirect and try with the --edgeHandlers flag it gives me Failed to connect to host: Timeout while establishing connection

Sorry for the delay to respond.
Can anyone post a reproduction for this issue? I tried on https://github.com/erezrokah/netlify-build-reproductions/blob/cli/issue_1595/public/_redirects and netlify dev works fine for me.
Probably my example is a bit too simple to surface the bug.

@erezrokah I downloaded your repo and it did indeed work fine. I tried with an Eleventy site we have and that also worked fine. The original site I tried it on was using Hugo which also is the case for the site @LandGod posted about. I'll see if I can get a minimal Hugo setup and repro.

I have a repo that can reproduce the issue in Hugo now: https://github.com/rybrad/netlify-hugo-redirect
With Hugo installed, running ntl dev should cause the "page is not redirecting properly/too many redirects" issue. If you comment out the 404 redirect in https://github.com/rybrad/netlify-hugo-redirect/blob/master/site/static/_redirects and refresh, the page will load correctly.
With that being said, I have a couple other observations that may or may not be useful. The issue did not seem to be reproducible when using the default publish directory within Hugo. Also, when changing the publish directory in netlify.toml to test instead of site/test/ it also seemed to bypass the issue. Not sure how much of that is just a red herring, but figured I would mention it anyway.

Hi @rybrad and sorry for the delay. You' reproduction repo helped a lot.
I wrote a detailed explanation on the cause for the bug here https://github.com/netlify/cli/pull/2195#issue-621121838


Package dependency with lowercase name and mixed case path results in "Requiring non existant package" error

Consider the following directory structure:
├── myapp
│   └── fiddler.json
├── composer.json

In composer.json:
{
    "require": {
        "php": ">=5.5.9",
        "laravel/framework": "5.1.*"
    }
}

In myapp/fiddler.json:
{
    "deps": [
        "vendor/laravel/framework"
    ],
    "autoload": {
        "psr-4": {
            "App\\": "app/"
        }
    }
}

This results in:
[RuntimeException]
  Requiring non existant package 'vendor/jeremeamia/superclosure' in 'myapp'.

My app includes laravel/framework which in turn includes jeremeamia/superclosure. The path to jeremeamia/superclosure is vendor/jeremeamia/SuperClosure. It seems that this can be resolved by changing:
$packages['vendor/' . $name] = $fiddleredComposerJson;

to:
$packages['vendor/' . strtolower($name)] = $fiddleredComposerJson;

in Fiddler\Build, but I'm not familiar enough with the package yet to know if this causes other issues. Does anyone have any thoughts on this issue? Thanks!

@timroberson Can you create a pull request?

This looks like a mistake in composer, i thought it requires everything to be lowercase. The proposed solution looks good.


[SPARK-21871][SQL] Fix infinite loop when bytecode size is larger than spark.sql.codegen.hugeMethodLimit

What changes were proposed in this pull request?
When exceeding spark.sql.codegen.hugeMethodLimit, the runtime fallbacks to the Volcano iterator solution. This could cause an infinite loop when FileSourceScanExec can use the columnar batch to read the data. This PR is to fix the issue.
How was this patch tested?
Added a test

Test build #82485 has started for PR 19440 at commit 473bbf0.

cc @maropu @rednaxelafx

Test build #82485 has finished for PR 19440 at commit 473bbf0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82485/
Test PASSed.

Thanks for pining! LGTM except for one comment.

LGTM except two minor comments.

Test build #82494 has started for PR 19440 at commit b8eb6a0.

Test build #82494 has finished for PR 19440 at commit b8eb6a0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82494/
Test PASSed.

Thanks! Merged to master.


fix: Adding processing of unrecoverable deployment conditions

Signed-off-by: Ilya Buziuk<EMAIL_ADDRESS>What does this PR do?
Adding processing of unrecoverable deployment conditions
What issues does this PR fix or reference?
https://github.com/devfile/devworkspace-operator/issues/685
https://github.com/eclipse/che/issues/20821
Is it tested? How?

apply quota to a namespace where the devWorkspace is going to be created e.g.

apiVersion: v1
kind: ResourceQuota
metadata:
  name: compute-resources-long-running
spec:
  hard:
    pods: "4"
    limits.cpu: "1"
    limits.memory: "1Gi"
  scopes:
  - NotTerminating

create a devWorkspace with high CPU / RAM limits

kind: DevWorkspace
apiVersion: workspace.devfile.io/v1alpha2
metadata:
  name: spring-petclinick
spec:
  started: true
  template:
    projects:
      - name: sprint-petclinick
        git:
          remotes:
            origin: "https://github.com/benoitf/spring-petclinic/tree/error-cpu.git"
    components:
    ### BEGIN Contributions from Theia plugin ###
      - name: tools
        container:
          image: quay.io/devfile/universal-developer-image:ubi8-d433ed6
          memoryRequest: 32Mi
          memoryLimit: 3Gi
          cpuLimit: 3000m
          cpuRequest: 100m
          endpoints:
            - exposure: none
              name: debug
              protocol: tcp
              targetPort: 5005
            - exposure: public
              name: 8080-tcp
              protocol: http
              targetPort: 8080
          volumeMounts:
            - name: m2
              path: /home/user/.m2

      - name: m2
        volume:
          size: 1G

      - name: mysql
        container:
          image: quay.io/eclipse/che--centos--mysql-57-centos7:latest-e08ee4d43b7356607685b69bde6335e27cf20c020f345b6c6c59400183882764
          memoryLimit: 300Mi
          endpoints:
            - exposure: none
              name: db
              protocol: tcp
              targetPort: 3306
          env:
            - name: MYSQL_USER
              value: petclinic
            - name: MYSQL_PASSWORD
              value: petclinic
            - name: MYSQL_DATABASE
              value: petclinic
            - name: PS1
              value: $(echo ${0})\\$

    commands:
      - id: prepare-database
        exec:
          component: mysql
          workingDir: ${PROJECTS_ROOT}/java-spring-petclinic
          commandLine: |
            /opt/rh/rh-mysql57/root/usr/bin/mysql -u root < ${PROJECTS_ROOT}/java-spring-petclinic/src/main/resources/db/mysql/user.sql && \
            /opt/rh/rh-mysql57/root/usr/bin/mysql -u root petclinic < ${PROJECTS_ROOT}/java-spring-petclinic/src/main/resources/db/mysql/schema.sql && \
            /opt/rh/rh-mysql57/root/usr/bin/mysql -u root petclinic < ${PROJECTS_ROOT}/java-spring-petclinic/src/main/resources/db/mysql/data.sql && \
            echo -e "\e[32mDone.\e[0m Database petclinic was configured"
          group:
            kind: run
            isDefault: true

      - id: build
        exec:
          component: tools
          workingDir: ${PROJECTS_ROOT}/java-spring-petclinic
          commandLine: mvn clean install
          group:
            kind: build
            isDefault: true

      - id: run-with-hsqldb
        exec:
          component: tools
          workingDir: ${PROJECTS_ROOT}/java-spring-petclinic
          commandLine: >-
            java -jar target/*.jar
          group:
            kind: run
            isDefault: true

      - id: run-with-mysql
        exec:
          component: tools
          workingDir: ${PROJECTS_ROOT}/java-spring-petclinic
          commandLine: |
            java -jar -Dspring-boot.run.profiles=mysql \
            -Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=5005 \
            target/*.jar
          group:
            kind: run
            isDefault: true

      - id: run-debug
        exec:
          component: tools
          workingDir: ${PROJECTS_ROOT}/java-spring-petclinic
          commandLine: >-
            java -jar -Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=5005 target/*.jar
          group:
            kind: run
            isDefault: true

follow up on the dw state:

devworkspace.workspace.devfile.io/spring-petclinick created
[ibuziuk@fedora devworkspace-operator]$ oc get dw
NAME                DEVWORKSPACE ID             PHASE      INFO
spring-petclinick   workspace5f3020fb221441dd   Starting   Waiting for workspace deployment
[ibuziuk@fedora devworkspace-operator]$ oc get dw
NAME                DEVWORKSPACE ID             PHASE    INFO
spring-petclinick   workspace5f3020fb221441dd   Failed   Detected unrecoverable deployment condition: FailedCreate pods "workspace5f3020fb221441dd-59f5dfc6-vxt6n" is forbidden: failed quota: compute-resources-long-running: must specify limits.cpu

PR Checklist

[ ] E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)

[ ] v8-devworkspace-operator-e2e: DevWorkspace e2e test
[ ] v8-che-happy-path: Happy path for verification integration with Che

@amisevsk how this PR can be merged? merge button is disabled due to prow e2e pending state :man_shrugging:

/test v8-devworkspace-operator-e2e


Unrecorded traces and spans are fully processed by the module

Module by default records 100% of the traces and spans. This may not be needed all the time and can be controlled with trace sampling.
It is possible to use Sampler properties of the OpenTelemetry SDK to configure Head Sampling with Consistent Probability Sampling.
If it is configured to use traceid ratio based sampling eg. otel.traces.sampler= parentbased_traceidratio, otel.traces.sampler.arg=0.1, SDK will only record 01 i.e. 10% of the traces. Although 90% of the traces are not recorded, this module is still performing a full processing of trace and span data for unrecorded traces. This is an un-necessary overhead and must be avoided.
When using head sampling, the recording decision is made when starting a span. So it should be using to decided if further processing of any related spans and traces are needed or not. Honoring the recording flags can help reduce the processing load and improve the performance, if needed.

where could that be configured in a mule app


adds o365 property patch

Coverage decreased (-0.09%) to 85.598% when pulling 673e8f8469cf9930856d062b85da036021570076 on feature/uwnetid-property-get-and-patch into 57e94c9d8ff37ac51d6f452afe2578aa22773481 on develop.


Code Review Comment Creation 500 in Gitea Version 1.21.3

Description
I am using Gitea version 1.21.3, and when creating a code review comment, an error occurs with the following message:
2024/01/30 14:27:51 .../context_response.go:86:HTML() [E] Render failed: failed to render template: repo/diff/conversation, error: template error: builtin(bindata):repo/diff/conversation:1:16 : executing "repo/diff/conversation" at <index .comments 0>: error calling index: reflect: slice index out of range

I noticed that this issue has been fixed in #28351 by the official team, but it seems the fix is not effective. Could you please help investigate how to resolve this issue?
Gitea Version
1.21.3
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
https://github.com/go-gitea/gitea/assets/24191438/a46e7aa4-36e9-4bf8-aaf3-56a6d68c1dfd
Git Version
2.39
Operating System
CentOS7
How are you running Gitea?
Kubernetes cluster
Database
PostgreSQL

Can you try to upgrade to 1.21.5?

1.21.5 doesn't help.
The root problem is that your PR is closed and outdated, so https://github.com/go-gitea/gitea/pull/29049 might help (in next release 1.21.6 , aka nightly at the moment)

I think this has been fixed by #29086 @wxiaoguang ?

Yes, but 1.21.6 hasn't been released yet.


The status filters need to be updated to display "Active/Inactive" instead of "True/False" for consistency with the datagrid.

Describe the bug
The status filters need to be updated to display "Active/Inactive" instead of "True/False," matching the values shown in the datagrid. In the Admin datagrid filters, data should appear consistently to maintain uniformity.
To Reproduce
Steps to reproduce the behavior:

Go to admin -> Products -> Filters -> Status -> True/False
Go to admin -> Products -> Status -> Active /Inactive

Expected behavior
The status filters need to be updated to display "Active/Inactive" instead of "True/False" for consistency with the datagrid.
Screenshots
https://prnt.sc/4ht40RSicrU_

Checked and Found that the Improvement has been done and verified. I have checked the details in below section and found it working properly.
Catalog -> Products
Catalog -> Categories
Catalog -> Attributes
Customers -> Customers
Marketing  ->Promotions -> Cart Rule
Marketing  ->Promotions -> Catalog Rule
Marketing  -> Communications -> Email Templates
Marketing  -> Communications -> Campaigns
Marketing  -> Communications -> Newsletter Subscriptions.
Settings -> Inventory Sources
Settings -> Users
Settings -> Themes


can't uninstall kadira

After removing kadira via meteor remove meteorhacks:kadira, my app no longer works:
/Users/me/.meteor/packages/meteor-tool/.<IP_ADDRESS>v7ejbf++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/dev_bundle/server-lib/node_modules/fibers/future.js:173
            throw(ex);
                  ^
ReferenceError: Kadira is not defined
    at app/server/kadira.js:1:36
    at app/server/kadira.js:3:3
    at /Users/me/src/packaging/.meteor/local/build/programs/server/boot.js:175:10
    at Array.forEach (native)
    at Function._.each._.forEach (/Users/me/.meteor/packages/meteor-tool/.<IP_ADDRESS>v7ejbf++os.osx.x86_64+web.browser+web.cordova/meteor-tool-os.osx.x86_64/dev_bundle/server-lib/node_modules/underscore/underscore.js:79:11)
    at /Users/me/src/packaging/.meteor/local/build/programs/server/boot.js:86:5
Exited with code: 8
Your application is crashing. Waiting for file change.

whoops, forgot to delete kadira.js

Okay.
On Sun Feb 15 2015 at 3:06:54 AM dasmodel<EMAIL_ADDRESS>wrote:

whoops, forgot to delete kadira.js
—
Reply to this email directly or view it on GitHub
https://github.com/meteorhacks/kadira/issues/138#issuecomment-74392992.

BTW: Why are you removing it?
Is there any issues with that. May be we can fix them :)
On Sun Feb 15 2015 at 3:07:09 AM Arunoda Susiripala<EMAIL_ADDRESS>wrote:

Okay.
On Sun Feb 15 2015 at 3:06:54 AM dasmodel<EMAIL_ADDRESS>wrote:

whoops, forgot to delete kadira.js
—
Reply to this email directly or view it on GitHub
https://github.com/meteorhacks/kadira/issues/138#issuecomment-74392992.

Well I'm actually in the throes of trying to debug an issue with the spiderable package (I keep seeing an error about 'Meteor code must always run within a Fiber') and am uninstalling packages to see if it changes anything

Okay. We did some bug fixes lately.
Make sure you are running the latest version of Kadira :)
On Sun Feb 15 2015 at 3:10:27 AM dasmodel<EMAIL_ADDRESS>wrote:

Well I'm actually in the throes of trying to debug an issue with the
spiderable package (I keep seeing an error about 'Meteor code must always
run within a Fiber') and am uninstalling packages to see if it changes
anything
—
Reply to this email directly or view it on GitHub
https://github.com/meteorhacks/kadira/issues/138#issuecomment-74393105.

Hi — I finally found the source of the bug and it's actually related to a diff. library of yours: meteorhacks:npm. When I remove the npm-container the fibers/spiderable error goes away but I can no longer use npmRequire which i really need. Do you have any ideas how to fix?


Update list.json

Insert AbapGenerator

thanks, please add a license to the repository, https://docs.github.com/en/github/building-a-strong-community/adding-a-license-to-a-repository

looks like its there now, merging, thanks 👍

thank you very much for the quick reply and your whole work with AbapGit and the dotabap page 👍
I would really appreciate it if you could give my project a short look and maybe some critic.
I built a ABAP Object Generator for quickly using templates with new projects.
For that i also looked a lot in the AbapGit Repo so thank you again for that 😊


Update data inventory report SQL with updated dynamic variables

Describe the task
Update the data inventory report to be in sync with the updated dynamic variables.
Issues that has been noticed to be impacted in DATA INVENTORY REPORT
Acceptance Criteria

[ ] The variable validDependent has been removed from student application form but it is still used in data inventory report SQL and needs to be updated.(This value to be used must come from workflow data)
[ ] The student application variable pleaseProvideAnEstimationOfYourParentsIncome has been updated to studentParentsTotalIncome and the same needs to be adjusted in data inventory report SQL.
[ ] The data inventory report SQL is using the key of a form panel which is totalUnsubsidizedDayCareCostsDuringClassHoursForTheProposedStudyPeriodForDisabledInfirmedDependents12YearsOfAgeAndOlderPanel insted of a form input object. Hence the SQL of data inventory report needs to be updated.

close it as obsolete and note that we'll have a ticket to sunset the data inventory


viewer.addOverlay & updateOverlay "placement" argument seems optional

Documentation describes the placement argument in viewer.addOverlay and viewer.updateOverlay methods as required, but it seems to me that it's actually optional as the Overlay class constructor has a default value of Placement.TOP_LEFT if none is provided.
I have actually tested calling both methods without the placement parameter and it seems to work fine.
I'd be willing to open a PR modifying both methods documentation with regard to that argument.

Good catch! Yes, please fix the docs, thank you!

Hi @iangilman, I just submitted the PR.
However, can you explain me how to proceed with regard to the site-build and openseadragon.github.com repositories? I'm not sure if I'm supposed to:

grunt publish from openseadragon repo dir and grunt doc from site-build to rebuild the documentation.
Submit PR to site-build
grunt publish from site-build to rebuild the web.
Submit PR to openseadragon.github.com

Am I expected to submit these two PR too or there's some CI workflow in charge of that?

@alvaromartmart I'll take care of propagating these changes to site-build and then on to openseadragon.github.com when we release the next version. We don't really have a mechanism for updating the docs between versions.
Thank you for making the fix!

Closed by #1696


Rarcif issue 55

Issue 55: Please review
Added:

RPC Methods
RPC Server
RPC Namespaces

Happy first PR @rarcif  🎉🎉

/staging

/staging


Add missing bundle info feature, bug fix, and specs

What was the end-user problem that led to this PR?
The problem was that bundler info GEM did not have feature parity with bundle show GEM, and it should because it's the recommended alternative. Also, bundle info bundler was showing an incorrect path while bundle show bundler was correct.
What was your diagnosis of the problem?
My diagnosis was that some code should be pulled from bundle show.
What is your fix for the problem, implemented in this PR?
My fix is to port the missing feature, bug fix, and specs to bundle info from bundle show.
Why did you choose this fix out of the possible options?
I chose this fix because it guarantees that the recommended alternative will work similarly to the current show command.

I just noticed that bundle show GEM accepts a regexp, but bundle info GEM does not. Should I bring that feature too?
$ bundle show rail
1 : rails-dom-testing
2 : rails-html-sanitizer
3 : railties
4 : coffee-rails
5 : jquery-rails
6 : autoprefixer-rails
7 : capistrano-rails
8 : dotenv-rails
9 : factory_bot_rails
10 : rails-i18n
11 : sprockets-rails
12 : rails
13 : rspec-rails
14 : sass-rails
15 : slim-rails
16 : unicorn-rails
0 : - exit -

vs
$ bundle info rail
Could not find gem 'rail'.
Did you mean rails?

That's bundle list

Oh, nice! We should document that bundle list feature since it's currently undocumented.
Then I'll remove the spec about the regexp matching, since the feature is not really there and it's only passing by chance... :sweat_smile:

Actually, this is not true. The new bundle list only applies to sets of gems:
$ RUBYOPT=-I/home/deivid/Code/bundler/lib ../bundler/bin/bundle list rails
ERROR: "bundle list" was called with arguments ["rails"]
Usage: "bundle list"

$ RUBYOPT=-I/home/deivid/Code/bundler/lib ../bundler/bin/bundle list rail
ERROR: "bundle list" was called with arguments ["rail"]
Usage: "bundle list"

I think we can bring this feature from bundle show too, so that the alternative works as much as possible in the same way as the deprecated command.

I ported the missing feature from bundle show. Now bundle info has feature parity for the use cases of the current bundle show acting on a specific argument.
Something I also noticed is that bundle info works against any default gem while bundle show does not. In my opinion, bundle show is correct here. bundle info or bundle show should only give information about the gems being currently included in the bundle. If the user is explicitly specifying a default gem in the gemfile, then yes, bundle info or bundle show should report it, possibly with a note that it's a default gem.
If a user wants to see information about any installed gem, not necessarily in the bundle, there's gem info already.
Thoughts about this?

@indirect Do you have any opinion about this? I'm torn here. My previous message kind of makes sense to me and might be strictly more correct, but in real life would probably lead to worse behavior. As of today:
$ bundle info zlib
  * zlib (1.0.0)
	Summary: Ruby interface for the zlib compression/decompression library
	Homepage: https://github.com/ruby/zlib
	Path: /home/deivid/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems/zlib-1.0.0
	Default Gem: yes

$ bundle show zlib
Could not find gem 'zlib'.

Regardless of this, this PR should be ready to go!

@deivid-rodriguez oh man, you're right. bundle info should only work on gems that are inside the bundle, like bundle ls should only show gems that are inside the bundle. I guess that's a bug. :)
Thanks for getting this fixed up!
@bundlerbot r+


Remove APP_API_TOKEN from SDKs

APP_API_TOKEN is used for sidecar to communicate to the APP when there is an authentication token required. Some SDKs (.Net, Go and PHP) also offer a way to propagate this token from the caller application. I propose we remove this feature from SDKs and keep it in runtime only. Having both ways can cause confusion and fragmentation in the Dapr setup.

https://github.com/dapr/dapr/issues/4640


Not redirecting to Url after SignOut

Hi,
I'm learning to use Identity Server. This method I added in the Web App client for Sign out,
    public IActionResult SignOut()
    {
        var callbackUrl = Url.Action("Index", "Home", values: null, protocol: Request.Scheme);
        return SignOut(new AuthenticationProperties { RedirectUri = callbackUrl },
            CookieAuthenticationDefaults.AuthenticationScheme, OpenIdConnectDefaults.AuthenticationScheme);
    }

The callbackUrl shows the web app client Url, however after SignOut action executed and successfully signing out, it did not redirect back to the web app, instead is showing the identity server login page. I also add this in the client configuration:
PostLogoutRedirectUris = { $"{webDomain}" },

I believe I'm missing something here. How do I implement this flow on the Identity Server web app side. I use the asp.net MVC template with asp.net identity for the identity server project. Thanks.

Any update on the issue? closing for now - feel free to re-open if it needs further discussion.


Copy works in PR#72

Description
Resolves #77. Don't know if it works.
Changes

I will continue your work from your branch, thanks.


table command produces a cell with a table when used with ls

This appears to be coming from us lacking StringStream, so we're getting a stream of a string and treating that stream like a table rather than strings to be printed to the screen.

(fwiw, I have a draft of a PR I was working on in hopes of fixing this)

this seems to be fixed now


chore(docs): add types to public and jsdoc cleanup

This PR:

Cleans up missing types on PUBLIC methods/properties
Cleans up JSDoc comments
Adds more excludes for internal methods

@amcdnl  Needs rebase.

@josephperrott done :)

needs rebase again

@mmalerba - done :)

needs rebase again

@mmalerba - Done.

Please check CI issues (incl lint)


Issue #455: Move examples/prod readme to docs

I'm avoiding prod.config.yml in the example.

Makes sense to me.


Show special type interaction moves in Offense screen

Certain moves like "Dry Ice" and "Flying Press" bypass normal type interactions.
If a visitor could specify a list of special moves their Pokémon/team has, the site could present a modified matchups result representing their real type coverage...

Dupe of #224


Archive all taps that are older than N-2

To speed up verification and cluttering of the .rb files. IMO we can archive most of the older versions.
Can be merged before: https://github.com/knative-extensions/homebrew-kn-plugins/pull/183

/cc @rhuss

/hold
There are some older versions that have wrong formula format, probably better to fix them before archiving for good.

@dsimansk thanks, I think that makes totally sense. However, looks like there are some conflicts to resolve right now.

@dsimansk thanks, I think that makes totally sense. However, looks like there are some conflicts to resolve right now.

Yep, I've made the moves before fixing all the checksum etc. in the files. I'll sync the changes and rebase.

/unhold

/approve
/lgtm


Adds Gradient Clipping to Fabric

What does this PR do?
Adds Gradient Clipping to Fabric.
Fixes  #13266

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca @justusschock @awaelchli

@justusschock For the misbehaving collectives test, I vote for adding Runif(skip_windows=True).


feat: add REST sample and test for AML AI

Description
Fixes b: 355523386
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist

[X] I have followed Contributing Guidelines from CONTRIBUTING.MD
[X] Tests pass:   go test -v ./.. (see Testing)
[X] Code formatted:   gofmt (see Formatting)
[X] Vetting pass:   go vet (see Formatting)
[X] These samples need a new API enabled in testing projects to pass (let us know which ones)
[ ] These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
[X] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
[ ] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
[X] Please merge this PR for me once it is approved

Question: I think we should wait until an official Financial Services Go client is available, rather than shipping a sample with REST.

Hey @irataxy -- do you still want to add this sample? If not, let's close this PR. Thanks!


PHP tags results commented and {source} wrapped inside p tags

Jodit Version:  3.1.69 Joomla component
Browser:  FF
OS:  Windows
Is React App:  False
Using the Sourcerer Joomla extension by Regular Labs and Jodit:
Code
Expected behavior:
{source}
<?php
  // codice PHP
?>
{/source}

Actual behavior:

{source}

{/source}

Any news about that? I see other new version of the Joomla extension of Jodit have been released but the problem still remain.


Create m2m relations with existing data in the Database

So I have this model in Django:
class Course(models.Model):
    class Meta:
        unique_together = ('name', 'year', 'semester')

    name = models.CharField(primary_key=True, max_length=250, null=False, blank=False)
    year = models.IntegerField(null=False)
    semester = models.IntegerField(null=False)
    active = models.BooleanField(default=True)

    _articles = models.ManyToManyField(to='Article', blank=True)
    _students = models.ManyToManyField(to=User, blank=True)
    _teachers = models.ManyToManyField(to=User, blank=False, related_name='courses_taught')

    def students(self) -> QuerySet['User']:
        """
        Retrieves the list of students in the course.

        :returns: List of students in the course.
        """
        return self._students.all()

    def teachers(self) -> QuerySet['Teacher']:
        """
        Retrieves the list of teachers associated with the course.

        :returns: List of teachers associated with the course.
        """
        return self._teachers.all()

    def add_teacher(self, teacher: 'Teacher'):
        """
        Adds a teacher to the course.

        :param teacher: The teacher to be added.
        """
        self._teachers.add(teacher)

    def add_student(self, user: 'User'):
        """
        Adds a student to the course.

        :param user: The user to be added as a student.
        """
        self._students.add(user)

    def __str__(self):
        return f"{self.name} ({self.year}-{self.semester})"

Teachers and students are default Django users. Since the data for teachers, students and course come from the same .xls file (one file contains a course with it's teachers and students), I've decided to make custom resources for both teachers and students (using tablib to just import these two individually).
Now that I'm creating the resource for course I'm facing the problem of making the manytomany relations between a course and it's corresponding teachers and students (which were previously imported and already exist in the DB).
I haven't really figured out how the manytomany widget works yet (from what I understand, you use the widget to import related data at the same time). I don't know if it would be possible to gather data from the DB and somehow append it with the dataset I'm building in the class resource.
What would be the correct approach for making the two manytomany relations with course using import-export? Considering I have the methods add_teacher() and add_students()

Best advice would be to download the example app and see how m2m fields are handled by default.  Reading source code and stepping through with breakpoints is the best way to understand how it fits together.

I haven't really figured out how the manytomany widget works yet (from what I understand, you use the widget to import related data at the same time).

Yes, there are examples in the example app.  The example app uses the "Category" model as an example.  m2m fields can be updated using pipe delimited fields in csv, or in yaml, json etc.

I don't know if it would be possible to gather data from the DB and somehow append it with the dataset I'm building in the class resource.

Get a handle on how it's working in the example app already.  There are hooks you can use during the import process if you need to fine tune.


bug(tdFileDrop): no way to remove .drop-zone flag

tdFileDrop directive adds .drop-zone class on (dragenter). And I expect .drop-zone class to be removed after user released mouse button and  (fileDrop) event emitted. However It doesn't happen and I can't find a way to do it manually.

Hey @quanterion,
Can you provide more info on the example? Since its supposed to remove it on dragleave, although the ripple in the button might affect it since we have a target validation (which we might need to remove because of the ripple background).

oh! nvm, just replicated it haha we never noticed cause we use it inside the td-file-upload component.
Thanks for the heads up!


Improve generate_stats_figs.R optional parameter documentation and checks

Example generate_stats_figs.R call:
Rscript --vanilla /home/ubuntu/riboviz/rscripts/generate_stats_figs.R \
  --num-processes=1 --min-read-length=10 --max-read-length=50 \
  --buffer=250 --primary-id=Name --dataset=vignette \
  --hd-file=vignette/output/WTnone/WTnone.h5 \
  --orf-fasta-file=vignette/input/yeast_YAL_CDS_w_250utrs.fa --rpf=True \
  --output-dir=vignette/output/WTnone --do-pos-sp-nt-freq=True \
  --t-rna-file=data/yeast_tRNAs.tsv \
  --codon-positions-file=data/yeast_codon_pos_i200.RData \
  --features-file=data/yeast_features.tsv \
  --orf-gff-file=vignette/input/yeast_YAL_CDS_w_250utrs.gff3 \
  --asite-disp-length-file=data/yeast_standard_asite_disp_length.txt
  --count-threshold=64

Output files:
3ntframe_bygene.tsv
3ntframe_propbygene.pdf
3nt_periodicity.pdf
3nt_periodicity.tsv
codon_ribodens.pdf
codon_ribodens.tsv
features.pdf
pos_sp_nt_freq.tsv
pos_sp_rpf_norm_reads.pdf
pos_sp_rpf_norm_reads.tsv
read_lengths.pdf
read_lengths.tsv
startcodon_ribogridbar.pdf
startcodon_ribogrid.pdf
tpms.tsv

Some of these output files are optional depending upon RiboViz configuration parameters which determine the parameters passed to generate_stats_figs.R. The documentation about, and checks for these parameters, can be enhanced:
--orf-gff-file:

Default value: NA
This is a required parameter. Check that the file name has been provided and, if not, then exit with an error message.

--t-rna-file and --codon-positions-file:

Default value: NA
These are both optional, and either both nor none can be provided.
If neither are provided the code prints Skipped: Codon-specific ribosome densities for correlations with tRNAs - t-rna-file and/or codon-positions-file not provided.
Check that either both file names or neither file name are provided, and, if not the case, exit with an error message (or ignore and treat as a skip).
This determines the output of: codon_ribodens.pdf, codon_ribodens.tsv

--features-file:

Default value: NA
This is optional.
If not provided then the code prints Skipped: Correlations between TPMs of genes with their sequence-based features - features_file.tsv not provided")
This determines the output of: features.pdf

--asite-disp-length-file:

Default value: NA
This is optional.
If not provided the code skips the relevant functionality but prints no Skipped message. Print one.
This determines the output of: 3ntframe_bygene.tsv, 3ntframe_propbygene.pdf

--orf-fasta-file:

Default value: FALSE
This is only needed if do_pos_sp_nt_freq=true. However, the code fails as the default value should be NA, and a check for an inconsistent configuration combination of NA and do_pos_sp_nt_freq=true done, exiting with an error message (or ignore and treat as a skip).
This determines the output of: pos_sp_nt_freq.tsv

This may be in scope for #32.

Comments requested on where this documentation might be placed? Is this more -user or -developer focussed?  Presumably developer?
As issues #152 (document the outputs) and #153 (document analysis code) both would add significantly more documentation about code in generate_stats_figs.R, do these issues change how we should think about structuring the documentation of #169 in #32 ?
Opinions welcome!

I think it would be useful to document this in the following places:

In a header comment in generate_stats_figs.R itself.
In https://github.com/riboviz/riboviz/blob/develop/docs/user/prep-riboviz-operation.md#output-files, to make it clear which files are only produced when the relevant configuration parameters are set (an example is already there for minus.bedgraph and plus.bedgraph)

Note to self:
It's definitely worth me considering optional parameters behaviours while thinking about testing of generate_stats_figs.R, read_count_functions.R and stats_figs_blocks_functions.R.
Also worth doing some kind of checking whether key parameters are numeric/character/logical etc, or if they're null/NA?
Definitely agree they should be documented better in generate_stats_figs.R probably. Especially after seeing the block in prep_riboviz.nf:
// Optional inputs for generate_stats_figs.R.
// If an optional file is not provided then a 'Missing_<PARAM>' file
// (for example 'Missing_features_file') is created within the 'work/'
// directories for the generateStatsFigs process. This symbolically
// links to a non-existent 'Missing_<PARAM>' file in the users current
// directory. This is not an issue since the files will not be passed
// onto generate_stats_figs.R and no attempt is made to use them. They
// are a side-effect of using the Nextflow pattern for optional
// inputs.
// Optional inputs implementation follows pattern
// https://github.com/nextflow-io/patterns/blob/master/optional-input.nf.

At the very least, it's worth adding a bit to the option parseing info in generate_stats_figs.R about which parameters are optional and which aren't...

No progress on this lately.
Still requires documentation. Something to work on in my next R sweep, possibly tying into #213 since that describes some of the 'checking' described in this issue?


Error API request path in web

I run web in localhost, but the API request path starts with localhost:3000. For example:
http://localhost:3000/cluster/master

Expected as follows:
http://localhost:9000/cluster/master

currently can't start web console work alone,
you can run lindb as standalone mode(https://github.com/lindb/lindb#standalone-mode)

if run web in localhost for dev/test, need modify api path in
https://github.com/lindb/lindb/blob/develop/web/src/config/config.ts
it dep on lindb server.