printing with :hardcopy should respect folds

Per @masukomi's comment on vim-markdown-folding's #23 and @ychin's note on macvim-dev' #874, printing in vim uses :hardcopy, which ignores folding. This decision has unfortunate consequences, in that it results in unfortunate surprises for users who print and fold.
Following the UI principle of Least Surprise, printed output for folded documents should respect respect content hidden by folds (otherwise the screen and printed output will differ wildly), and certain forms of documents will be unprintable, e.g. a collapsed outline. In a perfect world, printing would respect the folded state of the buffer. In an imperfect, but improved world, perhaps a warning could be displayed when printing that all folds will be unfolded in the printed output, at least until this can be updated?
Currently, unless this is changed, a folded document on screen:
1. Thing 1
...
2. Thing 2
...

will print in a completely unexpected and different fashion, like this:
 1.  Software sellers want
to divide the users and conquer them, making each user agree not to
share with others. I refuse to break solidarity with other users in
this way. I cannot in good conscience sign a nondisclosure agreement
or a software license agreement. For years I worked within the
Artificial Intelligence Lab to resist such tendencies and other
inhospitalities, but eventually they had gone too far: I could not
remain in an institution where such things are done for me against
my will.

2. Thing 2

So that I can continue to use computers without dishonor, I have
decided to put together a sufficient body of free software so that I
will be able to get along without any software that is not free. I
have resigned from the AI Lab to deny MIT any legal excuse to
prevent me from giving GNU away.(2)

Once GNU is written, everyone will be able to obtain good system
software free, just like air.(3)

This means much more than just saving everyone the price of a Unix
license. It means that much wasteful duplication of system
programming effort will be avoided. This effort can go instead into
advancing the state of the art.

Complete system sources will be available to everyone. As a result,
a user who needs changes in the system will always be free to make
them himself, or hire any available programmer or company to make
them for him. Users will no longer be at the mercy of one programmer
or company which owns the sources and is in sole position to make
changes.

Schools will be able to provide a much more educational environment
by encouraging all students to study and improve the system code.
Harvard's computer lab used to have the policy that no program could
be installed on the system if its sources were not on public
display, and upheld it by actually refusing to install certain
programs. I was very much inspired by this.

Finally, the overhead of considering who owns the system software
and what one is or is not entitled to do with it will be lifted.

Arrangements to make people pay for using a program, including
licensing of copies, always incur a tremendous cost to society
through the cumbersome mechanisms necessary to figure out how much
(that is, which programs) a person must pay for. And only a police
state can force everyone to obey them. Consider a space station
where air must be manufactured at great cost: charging each breather
per liter of air may be fair, but wearing the metered gas mask all
day and all night is intolerable even if everyone can afford to pay
the air bill. And the TV cameras everywhere to see if you ever take
the mask off are outrageous. It's better to support the air plant
with a head tax and chuck the masks.

@jm3 one option is to write a quick function to convert the viewable lines to the printed lines. What you're asking for is, in my opinion, out of vim's scope, but it can be scripted. Please see the example below - which will open a new window at the bottom and contain only the viewable lines including the foldtext() for lines that are folded.
function! PrintBuffer()
	let l:curpos = getcurpos()
	let l:bufnr = bufnr('%')
	let l:ft = &ft
	let l:linenr = line('$')
	call setpos('.', [l:bufnr, 1, 1, 0])
	let l:lines = []
	let l:line = 1
	let l:FoldText = function(empty(&foldtext) ? 'foldtext' : substitute(&foldtext, '\s*(\s*)\s*$', '', ''), [])
	while l:line < l:linenr
		let l:foldend = foldclosedend('.')
		if l:foldend ==# -1
			call add(l:lines, getline('.'))
		else
			call add(l:lines, l:FoldText())
		endif
		let l:line += abs(l:foldend)
		call setpos('.', [l:bufnr, l:line, 1, 0])
	endwhile
	call setpos('.', l:curpos)
	belowright new
	call setline(1, l:lines)
	let &ft = l:ft
	setlocal nofoldenable
endfunction

Thanks, @dylnmc! I'm not sure I 100% understand the characterization that vim would have to "jump through a thousand hoops"; I'm saying, "vim should print the buffer in its current state" which is both the least surprising choice and also how printing works in every text editing app I know of. I get that vim is different but… that seems strange. :) But OK. Thanks!

I am not opposed to this, for what it is worth, but this is what I am saying: when you send a range of lines to a command (for example, <line1>,<line2>write or, more usefully, '<,'>write), vim sends the plain text without any sort of modification to the command. That is how it is - in that regard, you're correct.
If you wanted to have what you describe, you'd have to create another option that perhaps takes a string so that it could be set to allow folds to be hidden with :hardcopy or :write as well as allow concealment to be written/hardcopy'd. This will require adding another option and writiing some C code. If Bram or some vim dev is up to the task, then great. The questions would then be: (1) how useful is this option when it can be scripted; (2) what commands should it apply to? just :hardcopy; (etc).

I'm with @jm3 It's not clear what the "hoops" are @dylnmc  . I say this from a perspective of ignorance not disagreement.
From an outsider's perspective it seems confusing that vim appears to have a clue what lines are folded and which aren't and thus you'd think the function would be something along the lines of

process file as if for display on infinitely tall screen with the desired print width
take that text and send it to the existing hardcopy function.

What are we missing? Is it something to do with the syntax highlighting?

The issue is that as mentioned by @dylnmc, :hardcopy basically just takes a range of lines from the file and use that to create the Postscript file to print out or convert to PDF etc. It doesn’t contain any formatting information or metadata.
For example, write a long line, then call :hardcopy with or without :set wrap. The results would be the same as that’s more a display / formatting information. On the other hand, if you use :TOhtml the difference would be captured.
Now, obviously Vim knows what lines are folded, but this would basically be a new feature to integrate folds and other displays / formatting info to print that out I.e. the “hoops”. It’s up to Bram to decide but I would imagine just like most feature requests it’s about time management and what feature to implement and whatnot.
I have already recommended on the MacVim thread but does using :TOhtml and then printing the results not suffice?

I have already recommended on the MacVim thread but does using :TOhtml and then printing the results not suffice? - @ychin

first off "using :TOhtml" really means

run :TOhtml
save resulting file
open file in browser
go to print dialog
probably undo them random crap your browser wants to add to the printed verison of the page
accept the horrible fact that it's going to wrap badly
print
switch to terminal / finder / run terminal command in vim
delete file you didn't want in the first place
switch to vim

Not only is the wrapping a non-trivial issue it's a convoluted pain in the butt that relies on external apps and prays they won't screw it up (but they do anyway). It's not even remotely equivalent to printing anywhere else. Vim, printers, and PDFs have been around for enough years that this is long overdue. Emacs has had this for how many years now?
The suggestion to use :TOhtml is like suggesting someone walk the 30 miles to work instead of driving. Sure you can do it, but it's a pain in the butt that takes longer and makes you not want to work at that place anymore.
Note that printing isn't just about outputting paper. It's one of the best available methods for sharing what you've created with the appropriate highlighting to people who aren't using vim. emailing / slacking / file sharing HTML files is not really a commonly understood / accepted way to share files these days.  I, for example, use printing to generate PDFs of ideas I want to discuss / share with coworkers when we can't be in the same room sharing a screen together.

The proof is in the pudding: I've already written a (blazingly fast) function that does that which is desired. It's like walking 5 minutes to work rather than developing complex flying car just so you can get to work in 3 minutes. @masukomi

@dylnmc I'm sorry to report that there are actually quite a few bugs in your function.  HOWEVER Assuming it's actually possible to debug and make it do the right thing (including correct syntax highlighting) why wouldn't that be the solution to this problem? Take the output of the function, shove it in a register, then run the print functionality on the contents of the register... I'm just thinking off the top of my head here.
On the one hand you keep saying that it's a very hard thing, but on the other you're like "here's a function that gets you 90% of the way there [ignoring the bugs]". It's still not clear what makes this request so hard. If someone could explain the complexity of the request to us outsiders (at a high level) we might be able to put our heads together and come up with a solution.  So far it seems achievable.

buggy PrintBuffer results
Source:
#     Markdown example                        [2 lines]---
## Formatting examples
###   Italic                                  [2 lines]---
###   Backtick handling                       [2 lines]---
###   Blockquote Handling                     [2 lines]---
## List Handling
### Bullet Lists

* bullet lists
* have highlighted asterisks
* another item with many words that will
  wrap shortly but alas will not wrap a
  second time

###   Ordered Lists                           [5 lines]---

PrintBuffer output:
###   Ordered Lists                           [5 lines]
## Formatting examples
###   Ordered Lists                           [5 lines]
###   Ordered Lists                           [5 lines]
###   Ordered Lists                           [5 lines]

just tested the PrintBuffer funciton out with some ruby code and sections of unfolded code are missing completely and  and an UNfolded method  (def claim_bounty(bounty) ) had this appended above the comment preceding it +-  8 lines: def claim_bounty(bounty)

yep. I hadn't tested PrintBuffer() function. It's unfortunately a bad solution because of how foldtext functions work; there might be another small bug also, unfortunately. It would be easiest to make a dummy foldtext() function and to allow your current function that you set 'foldtext' to to allow for an optional paremeter (you'd have to check if a:000 > 0, though). But you're correct in that my solution was tested very minimally and does not work well. It could be modified to work, perhaps, with some additional effort.
The reason it is not easy to just modify the vim source code to fix this is because commands already receive the raw lines without any filtering. In order to implement this filtering in the vim source code, you would have to rewrite how output is piped to all commands while preserving the way it is already done (since for most commands you'd want to send the raw output) with another option.

Yes, printing using :hardcopy basically only prints the whole buffer content, without taking into account the visual appearance. The current work-around is to use the :TOhtml command and printing from the browser.
Enhancing the printing function has been a long whish of users, however considering the length of the todo list, it might take a while until this will be developed (unless someone steps up and provides patches with a test).

I'm not sure why the animosity, but I was suggesting the :TOhtml method because it works today. I would imagine the original requester is interested in getting stuff done now rather than waiting for a feature to be implemented in the future. As explained already by multiple people, getting this feature  working perfectly requires some thought and isn't trivial to implement. Since hardcopy doesn't know anything about visual data, you now have to pipe a lot more data and think about how to send the display data over, how layout would work, etc, so it's essentially a new feature.

first off "using :TOhtml" really means
run :TOhtml
save resulting file
open file in browser
go to print dialog
probably undo them random crap your browser wants to add to the printed verison of the page
accept the horrible fact that it's going to wrap badly
print
switch to terminal / finder / run terminal command in vim
delete file you didn't want in the first place
switch to vim

Note that Vim's :hardcopy feature works by generating a temporary .ps file too which you then have to manually convert to a pdf file or whatnot before printing. In fact, in MacVim (the original issue was filed against it) it doesn't even open a print dialog box. It generates the ps file, then open it in Preview which you have to print manually.
Also, most of the steps you mentioned could be automated if you are willing to script together a function (or have a plugin do it) and you could also use tools like wkhtmltopdf to generate pdfs for printing without needing a browser. No one is saying this is perfect but it works. My point is that I think using or modifying TOhtml is a better starting point to get a working solution than implementing this from scratch in C code in Vim.
Also, wrapping should work in TOhtml. Did you try it and it didn't work for you?

emailing / slacking / file sharing HTML files is not really a commonly understood / accepted way to share files these days. I, for example, use printing to generate PDFs of ideas I want to discuss / share with coworkers when we can't be in the same room sharing a screen together.

Honestly, generating an HTML file at least as an intermediary file is a much more versatile way IMO to handle this because it is resizable and are responsive (similar to a text editor). You could for example copy and paste from a HTML web page to an email or any document editors, and it's also much easier to export HTML document to PDF rather than vice versa.
Also, just a cursory glance shows that VSCode and Sublime Text also don't support printing natively, although there are plugins to do that. Xcode does do printing natively but it doesn't preserve folds similar to Vim as it's printing the document rather than the visual rep. Not sure about other text editors.

From guessing based on your descriptions, you need to make sure you don’t both wrap your text using textwidth (hard wrap) and wrap (soft wrap). I don’t think there’s an easy solution for that if that’s what’s happening. Easiest way is joining all the hard-wrapped lines using J and then rely on soft wrapping.
The thing is a text file is inherently formatless. Someone has to make a decision how to format a file to a fixed width on a page, either Vim or the web browser. If done in Vim it would likely mean implementing a whole layout engine for printing. HTML is a really robust standard by now so I feel like there’s either a bug or how you are wrapping the text that’s the issue here. Maybe an example?

Don't know if this is off-topic, but I just found out that Neovim has removed :hardcopy in https://github.com/neovim/neovim/pull/21472. Their plan is to use a lua-ported version of TOhtml to replace it, and add a more flexible API to it so you cann export a file to HTML and open in a browser directly.
FWIW, I think it's quite useful to have native printing support, but I think it's a little odd that we essentially have two separate mechanisms of generating formatted output (PostScript from :hardcopy and HTML from TOhtml) with different featuresets. I wonder if we should at least make TOhtml have a more flexible API that allows you to directly generate a temp file and open it in a web browser, or convert to a PDF and print? This would make it easier for people who want the additional functionality (e.g. non-wrapped texts, conceal, folds) to have a simpler solution instead of the rather TOhtml interface. I tried to look it up but it doesn't seem like TOhtml has a separte repo that we can submit PRs to.

I'm still not understanding why vim can't just use the text that it's showing in the buffer instead of the text that constitutes the entire file. No-one's explained why we can't we just point the input of the printing functionality at the text on the screen instead of the text on the disk. in both cases there's an array of characters. why is one usable but the other isn't? I get that for some reason it's hard, but it's not clear WHY that's hard. Does vim just have no idea what it's displaying in the buffer?

@masukomi I think someone just needs to implement it. The responses aren't saying that this is "hard", but that this takes work to do. Change requires work, and no one is signing up to implement it. It's an open-source project, so you can feel free to jump in. :hardcopy is also a niche enough feature I think not enough people care enough to improve it (Neovim actually removed the feature recently).
But also, I don't think this thread is just about just printing a selected number of lines. It's really asking about printing the presented view of the file (e.g. folds) rather than the raw file itself, so the logic would be a bit different. And this is why I have already suggested using TOHtml instead. When I made that suggestion I was pretty clear that it's not optimal, but starting from that plugin makes more sense because it's already making use of the presented view instead of just the raw file, so if there are UX issues (it generates a temp buffer that you have to save out etc) feels to me fixing those would be faster than fixing :hardcopy. Just my 2c.

Don't know if this is off-topic, but I just found out that Neovim has
removed :hardcopy in https://github.com/neovim/neovim/pull/21472.
Their plan is to use a lua-ported version of TOhtml to replace it,
and add a more flexible API to it so you cann export a file to HTML
and open in a browser directly.

The purpose of :hardcopy is to be able to print text directly to any
installed printer.  Not using a tool like a browser.  Going through HTML
is inherently complex and can easily lead to bad results, as it wasn't
designed to be used for printing.
:hardcopy uses either the MS-Windows printing support or PostScript,
which was specifically designed for printing.  The implementation is
still complex, but once done it should "just work" without requiring
other tools.

FWIW, I think it's quite useful to have native printing support, but I
think it's a little odd that we essentially have two separate
mechanisms of generating formatted output (PostScript from :hardcopy
and HTML from TOhtml) with different featuresets. I wonder if we
should at least make TOhtml have a more flexible API that allows you
to directly generate a temp file and open it in a web browser, or
convert to a PDF and print? This would make it easier for people who
want the additional functionality (e.g. non-wrapped texts, conceal,
folds) to have a simpler solution instead of the rather TOhtml
interface. I tried to look it up but it doesn't seem like TOhtml has a
separte repo that we can submit PRs to.

The TOhtml plugin was an addition that intentionally does some things
differently.  So that the user has a choice.  Ben Fritz maintains the
plugin, if you have suggestions for improving it, you can discuss it
with him.  You could open a new issue if you like, but an issue about
:hardcopy is not the right place for it.
--
TALL KNIGHT: We are now no longer the Knights Who Say Ni!
ONE KNIGHT:  Ni!
OTHERS:      Sh!
ONE KNIGHT:  (whispers) Sorry.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


python310Packages.influxdb-client: 1.36.0 -> 1.36.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.influxdb-client is: InfluxDB client library
meta.homepage for python310Packages.influxdb-client is: https://github.com/influxdata/influxdb-client-python
meta.changelog for python310Packages.influxdb-client is: https://github.com/influxdata/influxdb-client-python/blob/v1.36.1/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.36.1 with grep in /nix/store/5krv7ky7mzmf0x6v9xfidwkkqi1h7rrm-python3.10-influxdb-client-1.36.1
found 1.36.1 in filename of file in /nix/store/5krv7ky7mzmf0x6v9xfidwkkqi1h7rrm-python3.10-influxdb-client-1.36.1

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
home-assistant-component-tests.influxdb
python310Packages.influxdb-client
python311Packages.influxdb-client

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/5krv7ky7mzmf0x6v9xfidwkkqi1h7rrm-python3.10-influxdb-client-1.36.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.influxdb-client https://github.com/r-ryantm/nixpkgs/archive/d9e39ec30a3bb0f1a2af641df6d20bc8632f8ced.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/5krv7ky7mzmf0x6v9xfidwkkqi1h7rrm-python3.10-influxdb-client-1.36.1
ls -la /nix/store/5krv7ky7mzmf0x6v9xfidwkkqi1h7rrm-python3.10-influxdb-client-1.36.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

home-assistant-component-tests.influxdb
python310Packages.influxdb-client
python311Packages.influxdb-client

Maintainer pings
cc @Mic92 for testing.

@ofborg build home-assistant-component-tests.influxdb


ci: publish to Open VSX

This will make the extension more discoverable and more easily accessible to users.
Currently, I only know of the Microsoft's Visual Studio Marketplace and Eclipse Foundation's Open VSX Registry. The latter is the default registry for VSCodium (The FLOSS-licensed builds of VSCode), but it may be decommissioned at the end of May so publishing to Open VSX is up to your discretion.
If publishing to one or the other is undesired, feel free to drop the corresponding commit.
If not intended for use in  Production, the extension can be marked as a prerelease by modifying the version property in package.json. "prerelease" rules and examples from semver.org

Precedence for two pre-release versions with the same major, minor, and patch version MUST be determined by comparing each dot separated identifier from left to right until a difference is found as follows:

Identifiers consisting of only digits are compared numerically.
Identifiers with letters or hyphens are compared lexically in ASCII sort order.
Numeric identifiers always have lower precedence than non-numeric identifiers.
A larger set of pre-release fields has a higher precedence than a smaller set, if all of the preceding identifiers are equal.

Both platforms require prior setup before view-avalonia-preview can be published to them. Most importantly, both require access tokens for authorization. These token need to be accessible to HaaLeo/publish-vscode-extension as workplace secrets (OPEN_VSX_TOKEN, VS_MARKETPLACE_TOKEN).

Open VSX Registry

[ ] Create an access token

[ ] Log in and sign the Publisher Agreement

[ ] Create an Eclipse account

[x] Package LICENSE file
[ ] Create a namespace/publisher.
[ ] Add access token to GitHub repository's Secrets. Name it OPEN_VSX_TOKEN.

Visual Studio Marketplace

[ ] Create an access token

[ ] Create organization in Azure DevOps

[ ] Create a publisher
[ ] Add access token to GitHub repository's Secrets. Name it VS_MARKETPLACE_TOKEN.

Thanks!
I didn't want to publish as the plugin is not finished yet. As far as I remember, the plugin is not informative, or I'm not used to using VsCode (my main tool is Rider). In addition, I also wanted to support axaml libraries, but I got stuck :( I have to overcome myself and complete what I wanted
I'll leave the PR open for now and come back to it later. Thanks again for your attention!

Things have changed since I opened this PR.
Avalonia has an official VSCode extension. Will this project be discontinued? Or will it stick around as an early-WIP alternative to AvaloniaVSCode?

@BinToss hello, thanks.
Yes, after the announcement the meaning disappeared, it’s better to work on a general solution, especially since it was better there)


State defaults to "on" at Hass startup

With the latest version, every time I restart Hass the TV's state is set to "on" regardless of it's actual state. This wasn't happening previously.

Please check your MQTT broker, if any Hisense-related topic has the retained flag set. If this is the case, every client (in your case, your restarted HA) will get the last value stored by the broker.
The integration sets the TV to "on" if any related MQTT message has arrived.

Clearing all the topics and restarting seems to have fixed it. There was probably something left over from all the testing with the issues from the previous build. Thanks


(PostCSS plugin): Add postcss to  used dependencies when using PostCSS with Tailwind CSS

Closes https://github.com/webpro-nl/knip/issues/762

Checking for failed tests now🙏

Thank you! 🙏

:rocket: This pull request is included in v5.27.3. See Release 5.27.3 for release notes.
Using Knip in a commercial project? Please consider becoming a sponsor.


Could not sent message to group

I follow documentation
https://github.com/ableev/Zabbix-in-Telegram/wiki/How-to-test-script-in-command-line
Testing simple text, group chats
./zbxtg_group.py "Zabbix in Telegram" test test
and got zbxtg_group.py: You need start a conversation with your bot first in 'Zabbix in Telegram' group chat, type '/start@talkerzabbixbot'

how i created bot talkerzabbixbot
in Botfather
/newbot
talkerzabbix
talkerzabbixbot
Done! Congratulations on your new bot...

find  talkerzabbixbot - press start

bot is added to my group

type message in group /start@talkerzabbixbot - nothing to give. bot is not answer.

in zbxtg_settings.py added tg_key = "xxxx03392:AAFuq6jMYqGVoU7PUn0q_6WoEHkzHMuZsCc"  # telegram bot api key

all is working file with ./zbxtg.py - it is sent messages to my bot, but not to group
thanks for advice

You need replace "zabbix in telegram" name of your group (register sensitive) and add --group to end command
example:
./zbxtg.py Name_your_group test test --group
use --debug for more information

Thanks!


migrate sgx related commits to 1.19

Please provide a description of this PR:
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Ambient
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@zhlsunshine Can you review this because this PR also contains SGX gateway related commits?

@zhlsunshine Can you review this because this PR also contains SGX gateway related commits?

Yes, thanks @Chen-Xintong,  and @gyohuangxin LGTM


Check host is down before upgrading

And improve messages.

I don't think we actually want this, because of #228 ?

yeah indeed!


Add directory option to workbench.editor.labelFormat

The directory option shows the file's directory name followed by the name of the file.
This option very useful when working in project containing multiple same named files (e.g. index.js and config.yaml) and/or where the folder in which the file is located gives the most context.
For example with React folder structure:
Components/
    Feed/
        index.js
        Button.js
    Store /
        index.js
        Button.js
    Post/
        Footer.js
    Button.js

the tabbar looks like:

Feed index.js
Feed Button.js
Store index.js
Store Button.js
Post Footer.js
Components Button.js

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: joihelgi sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Is there an issue for this?

Isn't this the default behavior, but backwards?

Is there an issue for this?

No I don't think so

Isn't this the default behavior, but backwards?

Not exactly default but yes backwards, the folder name is Title and the file name is Description in the tab, sometimes that is more convenient.

default uses verbosity: Verbosity.MEDIUM, shortenDuplicates: true
directory uses verbosity: Verbosity.SHORT, shortenDuplicates: false

Thanks for the PR, but I do not consider this a change for now. I think you can easily do 10 more PRs that all try to optimize how a tab title is being built and we solved this for the window title by allowing to use variables and thus be 100% flexible. I think for this area we would need something like that as well.

The feature mentioned by bpasero looks like issue #43806, just for future reference.


Migrate top level tools scripts into the routing/controller/view system

We're removing tools support from concrete5 version 9. Tools were a very old way of handling backend scripts like AJAX endpoints, etc... and things like dialogs/panels before we had the routing/controller system. You could just go to index.php/tools/required/foobar and that would just load the script located at concrete/tools/foobar.php. Tools would also work with subdirectories so index.php/tools/required/foo/barwould load the content atconcrete/tools/foo/bar.php`.
To finish this task, you'll need to take all tools scripts located here:
concrete/tools/edit_collection_popup
concrete/tools/pile_manager.php
concrete/tools/reindex_pending_pages.php
concrete/tools/sitemap_search_selector.php
and do the following for EACH tool script.

Search the core for any usage of the script. Some of these scripts may have already been migrated, but the original code was left behind. If there is no usage of the tool script in the core, delete it and proceed to the next tool. If the script is indeed in use, proceed with the next step.
Create new routes for these tools. They'll have to be created specifically and registered in our routing system. Put them in either routes/misc.php or in an appropriately named routes file.
Make sure these routes are registered in SystemRouteList. If the file they're being added to already existed, they should be.
Create backend controllers for relevant portions of these routes.
If there is a frontend aspect to this tool, make sure that there is a front-end view in the concrete/views directory for it.
Make sure that all code in the core is updated to point to the new ccm/system/ URL for this endpoint instead of the old index.php/tools/required endpoint.

I guess we should also remove the tools from the core block types.
At the moment, we have:

concrete/blocks/core_gathering/tools
concrete/blocks/form/tools

I don't think it's worth spending time on the gathering block type, isn't it?

Yeah don't worry about the gathering – that is going to go away in a separate issue. We're deleting it.
I honestly wouldn't worry about the Form block either. I think we should make those forms continue to work but make editing/adding them impossible.

Well, I can make it work without tools without that much effort, it'd require only a few minutes


Compile fix for new Odin compiler

Because it's only in master rn. I'm leaving this open until next release.

And as it's an enum now, you're welcome to add it Unmarshal_Error and remove the old Unable_To_Open_File value.

Ok! I'll look at improving the error handling sometime before next release.


Home page

i fixed the file/folder duplication. please review and approve the merge to develop branch

i just fixed the directory attachements path.


Navbar above first heading

Current Behavior
The navbar on the website is above the first heading. This makes it difficult for users to find the main content of the page, especially on mobile devices.
Also in mobile version the contents are overflowing.
Desired Behavior
The navbar should be above the first heading. This would make it easier for users to find the main content and would improve the overall user experience.
In mobile version contents of navbar should be hidden or some other animation.
Screenshots / Mockups

Assign me this under GSSoC'23


once is redundant?

Since the subscribe function returns the unsubscribe for the specific handler - why even pass the once arg?
One could just immediately call the unsubscribe inside of the handler!

This would, however, produce a lot of boilerplate code like this:
const onceHandler = (unsub) => (event) {
	// some logic
	unsub();
}

const unsub = on(someMap)(someEvent)(onceHandler(unsub));

Another solution would be to pass the unsub function into an event context, since there's no once in it anymore.
This also gives more flexibility, like conditional once-ing an event.


[QUESTION]  Is anti-afk-kick possible with BloxStrap?

Acknowledgement of preliminary instructions

[X] I have read and acknowledged the preliminary instructions.

What idea do you have?
Is it possible?

it's not possible with bloxstrap but it's possible with an autoclicker

no


I can create a disk of size 64 GB from portal but gives an error while using python SDK for VMs

Hi,
I have been trying to create an instance using the python SDK, but while running it, I get the following error:

azure.core.exceptions.ResourceExistsError: (OperationNotAllowed) The specified disk size 64 GB is smaller than the size of the corresponding disk in the VM image: 127 GB. This is not allowed. Please choose equal or greater size or do not specify an explicit size.
Code: OperationNotAllowed
Message: The specified disk size 64 GB is smaller than the size of the corresponding disk in the VM image: 127 GB. This is not allowed. Please choose equal or greater size or do not specify an explicit size.
Target: `osDisk.diskSizeGB

But the same successfully goes through from the portal.
Code:
priority = "Regular"
        eviction_policy = None
    poller = compute_client.virtual_machines.begin_create_or_update(rg_name, vm_name,
                                                                    {
                                                                        "location": location,
                                                                        "storage_profile": {
                                                                            "image_reference": {
                                                                                "publisher": 'MicrosoftWindowsServer',
                                                                                "offer": "WindowsServer",
                                                                                "sku": "2022-datacenter-azure-edition",
                                                                                "version": "latest"
                                                                            },
                                                                            'os_disk': {
                                                                                'os_type': 'Windows',
                                                                                'caching': 'None',
                                                                                'create_option': compute_client.models().DiskCreateOptionTypes.FROM_IMAGE,
                                                                                'disk_size_gb': storage,
                                                                                'managed_disk': {
                                                                                'storage_account_type': 'Standard_LRS'
                                                                                }
                                                                            }
                                                                        },
                                                                        "hardware_profile": {
                                                                            "vm_size": instance
                                                                        },
                                                                        "os_profile": {
                                                                            "computer_name": vm_name,
                                                                            "admin_username": user_name,
                                                                            "admin_password": password
                                                                        },
                                                                        "network_profile": {
                                                                            "network_interfaces": [{
                                                                                "id": nic_id,
                                                                            }]
                                                                        },
                                                                        "priority": priority,
                                                                        "eviction_policy": eviction_policy
                                                                    },

                                                                    )

    vm_result = poller.result()

Any help would be greatly appreciated!

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Compute - VM:0.22270338,Storage:0.14714763,Service Bus:0.054369718'

Thanks for the feedback, we’ll investigate asap.

Thanks for the feedback, we’ll investigate asap.

Hi, @VishnuNairP ,You said that you successfully created this VMS through the portal. Can you give me a screenshot of the VMS resource JSON？

Hey @kazrael2119, Thanks for the reply. But I just noticed that the disk was a data disk and the OsDisk is indeed 127GB. I assumed  from the schema value=null that the disk wasn't being created.
Attaching the JSON here anyway:
 "$schema": "https://schema.management.azure.com/schemas/2015-01-01/deploymentParameters.json#",
    "contentVersion": "<IP_ADDRESS>",
    "parameters": {
        "disks_virga_OsDisk_1_d8c8e205f45c47a5b1875325c340fa35_name": {
            "value": null
        }
    }
}

I will close the issue now.
Thanks for the help and sorry for the trouble.


Duplicated timeseries in CollectorRegistry: {'xxxx'}

how to clear guage registry
my metrics format :  'serverid+ metricsname' , my serverid is auto add or del .

my mrtics name is variable, so i need clear this


Parameter default in validation schema

Maybe I'm missing something, but currently for the following code:
tagsController.get('/', ({ query }) => {
		return query;
	},
	{
		query: t.Object({
			skip: t.Number({ minimum: 0, default: 0 }),
			take: t.Number({ minimum: 0, default: 10 }),
		}),
	}
);

I get an error if not providing skip and take in query parameters. I've tried different approach like:
	...
		query: t.Object({
			skip: t.Optional(t.Number({ minimum: 0, default: 0 })),
			take: t.Optional(t.Number({ minimum: 0, default: 10 })),
		}),
	...

, which doesn't throw error, but I still don't get a default value in the handler. So in both cases default doesn't do a thing and doesn't affect anything. Is it a bug or expected behavior? Are there any plans on supporting default parameter?
Expected behavior would be for the code above:

Do not require neither skip nor take in query parameters;
The type for query in handler context would be:

query: {
	skip: number;
	take: number;
}

(no optionals, since we always will have number, either set explicitly or implicitly via default)

having the same issue here

Same issue

I have the same issue here as well.

[!NOTE]
You should be using Numeric instead of Number because a query is always a string and Numeric provides the ability to parse strings into numbers.

Close as implementation of Default property and type coercion


feat: add appeal config for cross individual appeal

@singhvikash11 @bsushmith  need more context here. to which issue in guardian does this PR for?

@mabdh this one is addressing this issue


feat: Resolve function for OpenID4CI display data

Signed-off-by: Derek Trider<EMAIL_ADDRESS>

Codecov Report
Base: 88.38% // Head: 76.12% // Decreases project coverage by -12.26% :warning:

Coverage data is based on head (d5bd621) compared to base (12836f1).
Patch coverage: 58.35% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #82       +/-   ##
===========================================
- Coverage   88.38%   76.12%   -12.27%
===========================================
  Files          20       27        +7
  Lines         551      867      +316
===========================================
+ Hits          487      660      +173
- Misses         36      138      +102
- Partials       28       69       +41

Impacted Files
Coverage Δ

cmd/wallet-sdk-gomobile/openid4ci/openid4ci.go
60.00% <0.00%> (-21.82%)
:arrow_down:

pkg/openid4ci/openid4ci.go
75.86% <30.43%> (-10.35%)
:arrow_down:

pkg/credentialschema/issuerdisplay.go
33.33% <33.33%> (ø)

...-sdk-gomobile/credentialschema/credentialschema.go
47.61% <47.61%> (ø)

pkg/credentialschema/opts.go
52.11% <52.11%> (ø)

pkg/credentialschema/credentialdisplay.go
56.96% <56.96%> (ø)

pkg/credentialschema/credentialschema.go
60.00% <60.00%> (ø)

pkg/credentialschema/credentialssupported.go
71.42% <71.42%> (ø)

pkg/credentialquery/credentialquery.go
90.90% <88.88%> (-9.10%)
:arrow_down:

internal/gomobilewrappers/credentialreader.go
92.30% <92.30%> (ø)

... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Note that some of the test files are duplicated... go:embed doesn't allow you to reference files in parent directories, making sharing test files cleanly difficult...


[feature] Create and display unique sigil from hash of url

For security, a displaying a unique sigil created from the url hash, etc may be helpful for users to make sure their url hasn't been tampered with.  Could be displayed at center of QR on every payment.  This could also be a way of ensuring payment is going to the right person- you could print off a copy of the code, and ensure patrons/paymet collectors see the same image

Nice potential library for this: https://lnquy065.github.io/react-katar/


[synapse] Migrate @azure/synapse-managed-private-endpoints to ESM/vitest

Packages impacted by this PR

@azure/synapse-managed-private-endpoints

Issues associated with this PR

https://github.com/Azure/azure-sdk-for-js/issues/31338

Describe the problem that is addressed by this PR
Migrates using the migration tool for @azure/synapse-managed-private-endpoints to ESM/vitest
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.


Prometheus CLI: remove no-default-scrape-port featureFlag

Fixes #13959

I’m unclear whether this PR does what was originally proposed.
Reading back through the issues, it seems the problem was adding a port to the Host header. But it looks like this flag changes whether it is added to the target address.
Does it work?  Does it double up all series due to a new value for instance?

My gut is that post-beta is too late to make such a sweeping change.
Maybe inverting the feature flag to be on by default is OK, if someone tested it and assures us it’s safe.
@beorn7 you asked for it - what do you think?

I have very little skin in this game. I only "asked" for it because I tried to gather information provided by others.
@roidelapluie might have more context.
Very generally (without claiming any intimate knowledge of the implications of this change) I think we should try to get rid of all feature flags where it makes sense in the v3 release. (That's why we released only a beta version of v3 for now, precisely so that we can still introduce breaking changes.)
However, if this change manoeuvres us into a corner where users that need the default port have no way of adding it back, we could consider bringing back the old behavior, either as a feature flag with inverted behavior or as some 1st class config setting. (But I would assume you could just work around the change of behavior with one more relabel setting?)
In any case, as said above, my intention was merely to relay information. We should do what the experts say, not what I say.

I also don't see an issue with getting this in. The beta release is an incomplete preview imo with the implication of possibly more breaking changes.
Looking at the issue that prompted the feature flag (#9507) this solution seem right to me.
We could probably add a release note entry or similar pointing out a relabel config that adds this back? Though a feature flag for the old behavior would also work in my book.

An easy work-around is also to specify the desired port (80 or 443) explicitly.
Or in other word: This will only affect users that have not added the port explicitly to their scrape config so far and relied on the default port not only being used but also being added to the __addr__ label and thus the default instance label. This addition was (in the spirit of the discussion on #9507) probably wrong from the beginning. Why should Prometheus code replicate the information what the default port of http or https is?
My gut feeling is we should simply remove this behavior from Prometheus v3, as done in this PR. (But I still don't claim to have expert domain knowledge here. Happy to be proven otherwise.)

Just relaying from an in-person discussion I just had with some colleagues:
Assuming that this change is indeed fairly innocuous, we could move forward with just removing the feature flag (and make the "enabled" behavior the new and only behavior), we should describe more clearly in the description of (one of) the commits and in the PR description above what this is precisely doing (because the linked issue #13959 isn't really telling a lot, and even the very original issue #9507 isn't crystal clear).
I think the feature flag documentation this PR removes is actually pretty good, and the PR description could be build on top of it, i.e.:
"""
When enabled, the default ports for HTTP (:80) or HTTPS (:443) will not be added to
the address used to scrape a target (the value of the __address__ label), contrary to the default behavior.
In addition, if a default HTTP or HTTPS port has already been added either in a static configuration or
by a service discovery mechanism and the respective scheme is specified (http or https), that port will be removed.
"""
Which reminds me that the last sentence in the above is actually not true. I tried it out. If I enable the feature flag and set localhost:80 as one of the targets in one of the static_configs, I still get an instance label localhost:80. Only if I set merely localhost as the target, I get localhost as the instance label with the feature flag enabled, and localhost:80 without the feature flag enabled. I think the currently implemented behavior (with the feature flag enabled) is the desired and least surprising one.
In different news, we should have an "upgrade guide" with all the relevant changes from v2 to v3 and how to deal with them. This would also alleviate concerns about how invasive of a change is acceptable.

Taking a step back:
This PR is almost identical to #14160. And the latter still seems active. @jackma-00 why did you open this PR in the first place?

Not sure why this PR was opened in the first place. It seems to really copy it and not by accident implemented the same feature in a slightly different way.

@beorn7, we started working on this issue based on your suggestion on Slack when we asked how to begin contributing. So no, it wasn't by accident—we were just following your guidance.

Apologies, I am to blame. #14160 didn't see any activity for over 2 months, so I assumed it was orphaned. ABout a week after @arejula27  and @jackma-00 reached out it got attention again. Sorry for the confusion this caused.

No problem, these things happen. I just want to make it clear that we did not take advantage of an ongoing PR.
However, I would like to make another contribution. Where would be the best place to discuss which issue to take? All the good-first-issue ones seem to be taken. 😄

Apologies also from my side.
Generally, if someone starts to take over the work on an abandoned PR, it would be good to leave a note on the (seemingly) abandoned PR. Now we had multiple persons working in parallel doing the same thing.


Initial Code to watch Istio CRD

Here i have used istio client to use istio clientset and feed to the watcher.
Watcher is then fed to the controller
queue used is ratelimiting ( we might even want to remove the queue and directly push the event to a stream )
controller takes in istioclientset, queue and a watcher.
On a create,update, delete we get an event.

Looking forward to build on this. Please suggest changes/improvements.
@leecalcote @nitishm

closing this


Disable scrollwheel map zoom functionality when editing text overlays

Can inadvertently change map zoom and position with trackpad while editing text overlay, maybe map position/zoom should be locked while editing text overlay?

There has been no activity on this issue for more several months. We are closing it. If you think this still needs to be addressed please open a new issue.


Unable to open link in messages

Steps to Reproduce

Open Whakarere flatpak.
Open any chat with external link.
Right click to show the context menu

Choose either "Open Link" or "Open Link in New Window"

Expected Behaviour
Preferable the link is opened in an external browser. Or the link is opened in Whakarere.
Actual Behavior
Nothing happened.

same here. I love the approach, how the Whakarere looks and feels, however not being able to open link with default browser is hard to swallow.


[AIFlow] Update logging level of log in sqlalchemy_store.py

What is the purpose of the change
Update logging level of log in sqlalchemy_store.py
Brief change log
Update logging level of log in sqlalchemy_store.py
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.

Codecov Report

Merging #212 (95643de) into master (c7a267c) will increase coverage by 3.80%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage   61.71%   65.51%   +3.80%
==========================================
  Files         203      203
  Lines       15222    15221       -1
  Branches     2290     2291       +1
==========================================
+ Hits         9394     9972     +578
+ Misses       5330     4724     -606
- Partials      498      525      +27

Impacted Files
Coverage Δ

ai_flow/store/sqlalchemy_store.py
75.30% <80.00%> (+0.16%)
:arrow_up:

...plugins/blob_manager_plugins/blob_manager_utils.py
74.07% <0.00%> (-14.82%)
:arrow_down:

ai_flow/cli/commands/server_command.py
92.72% <0.00%> (-1.22%)
:arrow_down:

ai_flow/cli/commands/webserver_command.py
93.87% <0.00%> (-1.21%)
:arrow_down:

ai_flow/endpoint/server/server.py
58.08% <0.00%> (+0.59%)
:arrow_up:

ai_flow/endpoint/server/server_config.py
63.85% <0.00%> (+1.35%)
:arrow_up:

ai_flow/endpoint/server/server_runner.py
75.43% <0.00%> (+1.75%)
:arrow_up:

ai_flow/endpoint/server/workflow_proto_utils.py
60.86% <0.00%> (+2.17%)
:arrow_up:

ai_flow/api/ai_flow_context.py
94.28% <0.00%> (+2.85%)
:arrow_up:

... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7a267c...95643de. Read the comment docs.


chore(deps)!: require 3.6+

Removes 2.7 and 3.5 from the test suite and explicitly requires >= 3.6. Also adds tests for 3.9

@parthea Comments have been addressed, PTAL. :)


I this section of XRDP wiki docs still valid -  xrdp pulseaudio sink and source

I am wondering if this section of the WIKI doc's is still valid/correct?
http://www.xrdp.org/index.php?option=com_content&view=article&id=19:xrdp-pulse-sink&catid=2:documents&Itemid=7
in particular the section describing the following:

Now, you need to change the pulse and alsa setting on the terminal server.
Note, this will break any local sound as all audio will go to the xrdp sink.
Create or change these files to look like this.  Make a backup first in case you want to go back.  Note, don't put the long lines of minus in the file, that is a seperator for this document.
/etc/asound.conf
pcm.pulse {
type pulse
}
ctl.pulse {
type pulse
}
pcm.!default {
type pulse
}
ctl.!default {
type pulse
}

/etc/pulse/default.pa
.nofail
.fail
load-module module-augment-properties
load-module module-xrdp-sink
load-module module-native-protocol-unix

Yes and it’s moved to GitHub wiki and updated there
בתאריך יום ב׳, 16 באוק׳ 2017 ב-15:51 מאת bmullan<EMAIL_ADDRESS>
I am wondering if this section of the WIKI doc's is still valid/correct?
http://www.xrdp.org/index.php?option=com_content&view=article&id=19:xrdp-pulse-sink&catid=2:documents&Itemid=7
in particular the section describing the following:
Now, you need to change the pulse and alsa setting on the terminal server.
Note, this will break any local sound as all audio will go to the xrdp
sink.
Create or change these files to look like this. Make a backup first in
case you want to go back. Note, don't put the long lines of minus in the
file, that is a seperator for this document.
/etc/asound.conf
pcm.pulse {
type pulse
}
ctl.pulse {
type pulse
}
pcm.!default {
type pulse
}
ctl.!default {
type pulse
} /etc/pulse/default.pa .nofail
.fail
load-module module-augment-properties
load-module module-xrdp-sink
load-module module-native-protocol-unix
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/neutrinolabs/xrdp/issues/913, or mute the thread
https://github.com/notifications/unsubscribe-auth/ADTH1NhNyIuzhE3MQzAY47z124ZWlj1iks5ss1FSgaJpZM4P6kvH
.

--
Idan Freiberg
PGP FP: 8108 7EC9 806E 4980 75F2  72B3 8AD3 2D04 337B 1F18

Idan
I looked for that something similar to that same section on the github wiki
but couldn't find it....   do you have a link ?
Thanks
On Oct 16, 2017 2:24 PM, "Idan Freiberg"<EMAIL_ADDRESS>wrote:

Yes and it’s moved to GitHub wiki and updated there
בתאריך יום ב׳, 16 באוק׳ 2017 ב-15:51 מאת bmullan<EMAIL_ADDRESS>
:

I am wondering if this section of the WIKI doc's is still valid/correct?
http://www.xrdp.org/index.php?option=com_content&view=
article&id=19:xrdp-pulse-sink&catid=2:documents&Itemid=7
in particular the section describing the following:
Now, you need to change the pulse and alsa setting on the terminal
server.
Note, this will break any local sound as all audio will go to the xrdp
sink.
Create or change these files to look like this. Make a backup first in
case you want to go back. Note, don't put the long lines of minus in the
file, that is a seperator for this document.
/etc/asound.conf
pcm.pulse {
type pulse
}
ctl.pulse {
type pulse
}
pcm.!default {
type pulse
}
ctl.!default {
type pulse
} /etc/pulse/default.pa .nofail
.fail
load-module module-augment-properties
load-module module-xrdp-sink
load-module module-native-protocol-unix
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/neutrinolabs/xrdp/issues/913, or mute the thread
<https://github.com/notifications/unsubscribe-auth/
ADTH1NhNyIuzhE3MQzAY47z124ZWlj1iks5ss1FSgaJpZM4P6kvH>
.

--
Idan Freiberg
PGP FP: 8108 7EC9 806E 4980 75F2 72B3 8AD3 2D04 337B 1F18
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/neutrinolabs/xrdp/issues/913#issuecomment-336982995,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABmtp75u47wK3-6_WCx-ks3BwSRelCCqks5ss59CgaJpZM4P6kvH
.

Actually, it is not found at wiki.  I think the text file in the source repository is most correct.
See sesman/chansrv/pulse/pulse-notes.ubuntu.txt. It should be written in the wiki.

I meant editing /etc/pulse/default.pa or /etc/asound.conf is no longer needed.
At this point, pulse-notes.ubuntu.txt is more correct than pulse-notes.txt.

I've written up bran-new build instructions.
https://github.com/neutrinolabs/xrdp/wiki/How-to-build-and-install-pulseaudio-modules

Thanks !
On Dec 22, 2017 11:00 AM, "metalefty"<EMAIL_ADDRESS>wrote:

I've written up bran-new build instructions.
https://github.com/neutrinolabs/xrdp/wiki/How-to-
build-and-install-pulseaudio-modules
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/neutrinolabs/xrdp/issues/913#issuecomment-353625629,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABmtp3Q5dUTjswZsLzZm6wad7k5n13Udks5tC9IGgaJpZM4P6kvH
.

Closed by #984.


[monitor-query] items to complete for first release (1.0.0-beta.1)

Meta-issue to keep track of the various things I'm finding as I build out the monitor-query layer and will need to continue working on:

[ ] statistics doesn't appear to be modeled in the current swagger. They do come back in the raw response, however.
[ ] Current SDK doesn't have a place to specify an API key but the main demo site for ALA specifies one (https://dev.loganalytics.io/). So users won't be able to try out the library immediately.
[ ] CI doesn't appear to be setup correctly (doesn't run on the PR for track 2): link

(this might release earlier than June, but it's the nearest milestone that has not passed)


Added basic codes to start with Tkinter

you tried

Your code is very nice and clean, but try to comment more. In this way, you will make your code look cleaner


Upgrade to 2.12.0

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

My apologies @metab0t , I've been meaning to put some time away to properly review the changes, but since I no longer use pandapower nor Python at my current role it's not been possible to do so. I've approved a PR for someone else to be added as a maintainer and planing to be remove myself once that's merged in.
If merging this PR is blocking you, I can approve it but full disclaimer I do not have the capacity to review whether it actually works


Added unit tests to generated app and improved gulpfile

Coverage remained the same at 100.0% when pulling 6f279b6270eed8345d1e268351cc803d12b865c8 on app-tests into 6f975c1e915ea44f9047b25ddfe0cb1eb7d60b13 on master.

Coverage remained the same at 100.0% when pulling 6f279b6270eed8345d1e268351cc803d12b865c8 on app-tests into 6f975c1e915ea44f9047b25ddfe0cb1eb7d60b13 on master.


v<IP_ADDRESS> - Launcher fails to extract assets - missing restool.py from tables folder

Log file. I had to manually create the tables folder to get this far. - See #28
Starting commandline processess...
8/16/2023 11:51:07 PM
----------------------------
Executing via cmd.exe:
 /C .\tables\python.exe .\tables\get-pip.py
Collecting pip
  Obtaining dependency information for pip from https://files.pythonhosted.org/packages/50/c2/e06851e8cc28dcad7c155f4753da8833ac06a5c704c109313b8d5a62968a/pip-23.2.1-py3-none-any.whl.metadata
  Using cached pip-23.2.1-py3-none-any.whl.metadata (4.2 kB)
Collecting setuptools
  Obtaining dependency information for setuptools from https://files.pythonhosted.org/packages/b8/49/b3b29c52b09075fb77f69309763a563b4054d5808a3f3b95df3a62ef3d3f/setuptools-68.1.0-py3-none-any.whl.metadata
  Using cached setuptools-68.1.0-py3-none-any.whl.metadata (6.2 kB)
Collecting wheel
  Obtaining dependency information for wheel from https://files.pythonhosted.org/packages/28/f5/6955d7b3a5d71ce6bac104f9cf98c1b0513ad656cdaca8ea7d579196f771/wheel-0.41.1-py3-none-any.whl.metadata
  Using cached wheel-0.41.1-py3-none-any.whl.metadata (2.2 kB)
Using cached pip-23.2.1-py3-none-any.whl (2.1 MB)
Using cached setuptools-68.1.0-py3-none-any.whl (805 kB)
Using cached wheel-0.41.1-py3-none-any.whl (64 kB)
Installing collected packages: wheel, setuptools, pip
  WARNING: The script wheel.exe is installed in 'I:\Games\ZeldaALttP\zelda3\tables\Scripts' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
  WARNING: The scripts pip.exe, pip3.11.exe and pip3.exe are installed in 'I:\Games\ZeldaALttP\zelda3\tables\Scripts' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed pip-23.2.1 setuptools-68.1.0 wheel-0.41.1

8/16/2023 11:51:12 PM
----------------------------
Executing via cmd.exe:
 /C .\tables\python.exe -m pip install --upgrade pip pillow pyyaml
Requirement already satisfied: pip in i:\games\zeldaalttp\zelda3\tables\lib\site-packages (23.2.1)
Collecting pillow
  Obtaining dependency information for pillow from https://files.pythonhosted.org/packages/66/d4/054e491f0880bf0119ee79cdc03264e01d5732e06c454da8c69b83a7c8f2/Pillow-10.0.0-cp311-cp311-win_amd64.whl.metadata
  Downloading Pillow-10.0.0-cp311-cp311-win_amd64.whl.metadata (9.6 kB)
Collecting pyyaml
  Obtaining dependency information for pyyaml from https://files.pythonhosted.org/packages/b3/34/65bb4b2d7908044963ebf614fe0fdb080773fc7030d7e39c8d3eddcd4257/PyYAML-6.0.1-cp311-cp311-win_amd64.whl.metadata
  Downloading PyYAML-6.0.1-cp311-cp311-win_amd64.whl.metadata (2.1 kB)
Downloading Pillow-10.0.0-cp311-cp311-win_amd64.whl (2.5 MB)
   ---------------------------------------- 2.5/2.5 MB 8.4 MB/s eta 0:00:00
Downloading PyYAML-6.0.1-cp311-cp311-win_amd64.whl (144 kB)
   ---------------------------------------- 144.7/144.7 kB 8.4 MB/s eta 0:00:00
Installing collected packages: pyyaml, pillow
Successfully installed pillow-10.0.0 pyyaml-6.0.1

8/16/2023 11:51:14 PM
----------------------------
Executing via cmd.exe:
 /C cd .\tables && python restool.py --extract-from-rom
python.exe: can't open file 'I:\\Games\\ZeldaALttP\\zelda3\\tables\\restool.py': [Errno 2] No such file or directory

restool.py appears to be in the assets folder, NOT the tables folder.

Preliminary examination indicates that the original snesrev project has rearranged the file structure and that's why this is now happening. I'll have to research and adjust for the new file structure.

Should be addressed with #30.

i have still got the error with the new release, i have to do some research first, maybe i fucked something up on my end

Did you delete everything from the previous version before attempting again?

yes deleted everything and started from scratch.
he still misses the path to the tables folder.
if i understand the orginal code correctly this progress happens in assets normaly?

I'll have to go over the translations functionality specifically. I didn't even consider that specifically and focused on the build itself in testing.

Definitely an issue with the translation functionality referencing the old directory, but there's something odd going on beyond just that as well. It will take some further exploration of the issue to determine why the translation functionality specifically is now busted.


Move electron-releases to devDependencies

Hi,
electron-releases package is only required for build/update process.
This will save around 9 MB space on end user harddisk.

Thanks!


Issue 1 needs update

My first ever PR. I've checked this code out independently to see that it builds according to the instructions.
One point is that I don't think we need the fable daemon any longer (?), but I'm too new to Fable to make the call on that. Webpackdev seems to handle it.

I don't think we need the fable daemon any longer

Indeed, fable daemon is no longer required since everything is handled via webpack and fable-loader


⚠ ClamAV has degraded performance

In c5c9a74, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 443 ms

Resolved: ClamAV performance has improved in 3366828.


Branch add assert function

Why?
Add isTruthy type-aware assert function

[x] Tests have been added/updated
[x] Documentation has been updated

@JasonEtco If this pull request will be merged with new assert feature - could you please publish new version of actions-toolkit to npm?

@likern 👋 can you explain what this would be used for? I'm not sure I understand the need for it in this library, it seems more like a helper method that's very specific to your use-case, but I'd love to hear more.

@likern 👋 can you explain what this would be used for/why its needed? I'm not sure I understand the need for it in this library, it seems more like a helper method that's very specific to your use-case, but I'd love to hear more.

Yes, of course. If we use actions-toolkit in TypeScript we want to check types and  narrow down types.
There is a common pattern for that in JavaScript: using assert functions. This is especially useful in scripts, where in branches we just exit with failure. And main branch for successful path.
But TypeScript can't understand that we did checks.
// get version from inputs, it has type string | undefined
const version: string | undefined = '0.63.2'
assert (version !== undefined, 'Invalid version')
const str: string = version // TypeScript didn't understand that in assert we checked types. version is still string | undefined

If using with available API
// get version from inputs, it has type string | undefined
const version: string | undefined = '0.63.2'
if (version === undefined) {
  tools.exit.failure('version is undefined')
}

const str: string = version // TypeScript didn't understand that common pattern. version is still string | undefined

For that case TypeScript added assertion control flow analysis support https://github.com/microsoft/TypeScript/pull/32695

Thanks for that @likern. But I'm not clear on why regular old assert doesn't do what you want? It seems that https://github.com/microsoft/TypeScript/pull/32695 added support for TypeScript being aware of assert possibly exiting.
To be honest, this seems like a very specific use-case, one that I'd hesitate to add to a library like actions-toolkit. I'd recommend just using a helper function in your own app code to do the same thing:
function isTruthy (tools: Toolkit, condition: boolean, msg?: string) {
  if (!condition) {
    tools.exit.failure(msg ?? `Assertion for value ${condition} is not truthy`)
  }
}

Thanks for that @likern. But I'm not clear on why regular old assert doesn't do what you want? It seems that https://github.com/microsoft/TypeScript/pull/32695 added support for TypeScript being aware of assert possibly exiting.
To be honest, this seems like a very specific use-case, one that I'd hesitate to add to a library like actions-toolkit. I'd recommend just using a helper function in your own app code to do the same thing:
function isTruthy (tools: Toolkit, condition: boolean, msg?: string) {
  if (!condition) {
    tools.exit.failure(msg ?? `Assertion for value ${condition} is not truthy`)
  }
}

Yes, that's possible solution. But I've decided to make pull request exactly as exit functions merely do the same. They just wrap Node.js process.exit().
The only they do on top of that is logging messages with different log level. I thought if you've added them you wanted to have unified high-level API and, possibly, do not interact with broad low-level API.
The same intention behind assertion function. Instead of throwing exceptions as Node.js asset do, worrying about broad Node.js Assert API or fighting with type guards it allows do this in s simple way.
Not many developers know assert function doesn't reduce type. Moreover assertion functions are not well known.
But, of course, if you hesitate to accept this pull request I will use my own branch, no problems.


deploy: k8s: resync accounts-db in wholeWeaveDemo.yaml

accounts.yaml was updated in #234 but the change was forgotten in wholeWeaveDemo.yaml
Symptoms: unable to login

/cc @philwinder @idcrosby

Good catch @alban. We are in the process of reorganising the repo, should be in a better state in a couple days.


Cache trace results

We should cache the traces generated for a block to be served from cache if we get the same request again. Assuming that people will mostly be interested in traces from recent blocks, this should relieve the pressure on the CPU.

Done in #1344


Moving AWS X-Ray Components to JS-Contrib

What is the Problem?
Currently, the AWS X-Ray ID Generator and propagator components sit in the aws-otel-js repo instead of the opentelemetry-js-contrib repo. The issue with this setup is that developers who plan on using OpenTelemetry with AWS X-Ray have to discover and locate the AWS X-Ray specific ID Generator and propagator since these components do not reside in the OpenTelemetry (CNCF) GitHub organization.
Moreover, not having the AWS X-Ray ID generator and propagator inside the js-contrib repo is inconsistent with the structure that other language SDK repos follow for making contributed components available. The Go, Python and DotNet implementations of these components all reside within their respective contrib repositories.
Solution
Reduce Developer Friction: I propose migrating the AWS X-Ray ID Generator and propagator components to be maintained in the opentelemetry-js-contrib repository. This will reduce developer friction greatly. As a possible solution, one could consider the existing OpenTelemetry registry. However using the existing registry does not reduce developer friction.
Increase User Adoption: Adding vendor components such as the AWS ID-generator and propagator to js-contrib will also facilitate a better user experience for anyone using OpenTelemetry with AWS X-Ray.
@alolita, @wilguo

Both have been upstreamed in the contrib repo, closing


HubSpot CRM

When submitting a connector, please check the following conditions for your PR.

[X] I attest that the connector works and I verified by deploying and testing all the operations.
[X] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[X] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a logo.

Fixed title

Can you please add connectionParameters section as shown below? It's needed for deployment.
  "properties": {
    "connectionParameters": {
      "api_key": {
        "type": "securestring",
        "uiDefinition": {
          "constraints": {
            "clearText": false,
            "required": "true",
            "tabIndex": 3
          },
          "schema": {
            "description": "Enter your API Key for HubSpot",
            "type": "securestring"
          },
          "displayName": "API Key generated in HubSpot"
        }
      }
    },
    "connectionParameterSets": {

I don't understand why OAuth would be put in a connectionParameterSet and not the API key

[[certify-connector]]


Feature/#66 - Refactor JobConfig + Add StandaloneConfig

Seperate standalone config properties from JobConfig into StandaloneConfig class.
Do some refactoring to reduce boilerplate code.

For me, it s good to go on develop.


Failed to run automated scorecard-action@main ossf-tests/scorecard-action-non-main-branch

https://github.com/ossf-tests/scorecard-action-non-main-branch/actions/runs/2142138983

duplicarte #169


DenseVector to DenseMatrix?

Is there a method to convert an m-length DenseVector into an m-by-1 or an 1-by-m matrix?

@saarraz I am using this function, but it turns out to be highly expensive operation for me. takes 300-400 ms for a dense vector of size 5,00,000. Is this normal and can we reduce it somehow

.asDenseMatrix
I think this function may help you


Coredns is not deployed as a daemonset in AKS

This section states that coreDNS in AKS runs as a deamonset, however it runs as a deployment instead.
"Regarding DNS, with both kubenet and Azure CNI plugins DNS is offered by CoreDNS, a daemon set running in AKS."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9615c579-305d-2482-7eaf-2d120c75e8d5
Version Independent ID: 064f4a10-bd74-f554-9550-781dd3e838cb
Content: Concepts - Networking in Azure Kubernetes Services (AKS) - Azure Kubernetes Service
Content Source: articles/aks/concepts-network.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

@ohorvath Thanks for pointing this out.
Yes, this runs as deployment, we are updating the document to reflect this.


wip: chore(userspace/libsinsp): perf improvements

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area CI
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This PR does a couple of things:

keep a reference on m_sinsp_stats_v2 where needed, instead of fetching it every time
cache gmt2local result instead of fetching it every time as it is an heavy operation

The latter means that if timezone changes while Falco is running, we will not adapt to new timezone. Anyway, that function is not called often by Falco, but is called continuously eg: when replaying a scap file, and the change has a big impact there. I think it is worth the tradeoff.
Also, a CI job was added to test with perf whether we have any perf regression running unit-tests-libsinsp executable diffing from a baseline (same perf run but on master). The job will fail if any delta (relative) are > 2%.
This can be further tuned if needed.
Of course, the job is meant to fail until the new CI job is merged because we don't actually have any master perf-related artifact.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Here is a snippet of the perf diff between master and this branch  when running unit-tests-libsinsp executable (manually done in my laptop):
    35.53%     -5.73%  [.] sinsp_parser::reset(sinsp_evt*)
    18.64%     -0.64%  [.] std::thread::_State_impl<std::thread::_Invoker<std::tuple<mpsc_priority_queue_multi_concurrent_producers_Test::TestBody()::{lambda()#1}> > >::_M_run()
    10.02%     +0.42%  [.] sinsp_threadinfo::sinsp_threadinfo(sinsp*, std::shared_ptr<libsinsp::state::dynamic_struct::field_infos>)
     9.30%     +1.37%  [.] next
     8.95%     +1.53%  [.] sinsp_thread_manager::get_thread_ref(long, bool, bool, bool)
     8.38%     +1.69%  [.] sinsp::next(sinsp_evt**)
     3.73%     +2.21%  [.] sinsp_threadinfo::init(scap_threadinfo*)
     3.58%     +2.06%  [.] std::thread::_State_impl<std::thread::_Invoker<std::tuple<mpsc_priority_queue_single_concurrent_producer_Test::TestBody()::{lambda()#1}> > >::_M_run()
     1.88%     +0.30%  [.] void std::__push_heap<__gnu_cxx::__normal_iterator<mpsc_priority_queue<std::unique_ptr<int, std::default_delete<int> >, std::greater_equal<int>, std::mutex>::queue_elm*, std::vector<mpsc_priority_queue<std::unique_ptr<int, std::default_delete<int> >, std::greater_equal<int>, std::mutex>::queue_elm, std::allocator<mpsc_priority_queue<std::unique_ptr<int, std::default_delete<int> >, std::greater_equal<int>, std::mutex>::queue_elm> > >, long, mpsc_priority_queue<std::unique_ptr<int, std::default_delete<int> >, std::greater_equal<int>, std::mutex>::queue_elm, __gnu_cxx::__ops::_Iter_comp_val<std::less<mpsc_priority_queue<std::unique_ptr<int, std::default_delete<int> >, std::greater_equal<int>, std::mutex>::queue_elm> > >(__gnu_cxx::__normal_iterator<mpsc_priority_queue<std::unique_ptr<int, std::default_delete<int> >, std::greater_equal<int>, std::mutex>::queue_elm*, std::vector<mpsc_priority_queue<std::unique_ptr<int, std::default_delete<int> >, std::greater_equal<int>, std::mutex>::queue_elm, std::allocator<mpsc_priority_queue<std::unique_ptr<int, std::default_delete<int> >, std::greater_equal<int>, std::mutex>::queue_elm> > >, long, long, mpsc_priority_queue<std::unique_ptr<int, std::default_delete<int> >, std::greater_equal<int>, std::mutex>::queue_elm, __gnu_cxx::__ops::_Iter_comp_val<std::less<mpsc_priority_queue<std::unique_ptr<int, std::default_delete<int> >, std::greater_equal<int>, std::mutex>::queue_elm> >&) [clone .isra.0]
     7.99%     -0.29%  [.] sinsp_thread_manager::find_thread(long, bool)
     7.52%     -0.61%  [.] gz_read
     6.71%     -1.16%  [.] sinsp::next(sinsp_evt**)
     5.71%     -0.81%  [.] sinsp_parser::reset(sinsp_evt*)
     5.51%     -0.71%  [.] sinsp_utils::find_longest_matching_evt_param(std::basic_string_view<char, std::char_traits<char> >)
     3.99%     +0.95%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release()
     3.82%     -0.80%  [.] gzread
     3.79%     +0.81%  [.] longest_match
     3.68%     -0.38%  [.] sinsp_evt::load_params()
     3.41%     -0.04%  [.] next
     2.47%     -0.39%  [.] deflate_slow
     2.46%     -0.16%  [.] gzfile_read
     2.37%     +0.27%  [.] sinsp::fetch_next_event(sinsp_evt*&)

And here is a diff computed running sinsp-example against a scap file (where gmt2local impact is much higher since we print every event; look for sinsp_filter_check::tostring):
  20.26%     -3.27%  [.] sinsp_filter_check::extract(sinsp_evt*, std::vector<extract_value_t, std::allocator<extract_value_t> >&, bool)
    17.58%     -2.36%  [.] sinsp_filter_check::tostring(sinsp_evt*)
     7.60%     -1.09%  [.] sinsp_evt_formatter::tostring_withformat(sinsp_evt*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, sinsp_e>
     6.05%     -3.29%  [.] sinsp_threadinfo::populate_cmdline(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, sinsp_threadinfo const*)
     5.99%     -2.29%  [.] sinsp_fdtable::add_ref(long, std::unique_ptr<sinsp_fdinfo, std::default_delete<sinsp_fdinfo> >)
     5.23%     -2.13%  [.] void std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<ch>
     5.20%     +0.08%  [.] gz_read

Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Mmmh seems like the job is hit by: https://github.com/actions/runner/issues/2402

/milestone 0.18.0

Mmmh seems like the job is hit by: https://github.com/actions/runner/issues/2402

So, the job is failing on our cncf x64 self-hosted ode too; but i manually tried on the node and it worked fine.
I think there is something wrong with how github actions spawn sub-process/shells (?)...

Will rebase on #1918 once it gets merged.

Rebased :) Wait for CI :crossed_fingers:

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

 4.27%     +9.52%  [.] sinsp_filter_check::tostring

Weird :/ perhaps latest changes (thread_local) killed the perf? @jasondellaluce

/hold

Perf diff from master - scap file

Yes, scap files perf are pretty unstable it seems :(

Beautiful @FedeDP!

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/hold

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/unhold

/milestone 0.17.3


Loader bug

Could you confirm that in the following line, self.shot_num should be self.way_num？It is not consistent with mini-imagenet-tools and gives error.
https://github.com/yaoyao-liu/tiered-imagenet-tools/blob/master/tiered_imagenet_dataloader.py#L189

Thanks for reporting this issue. I have updated the code.

Thanks for your quick reply.
Another question about using import scipy.misc as scm,
in  mini-imagenet-tools, import imageio is used, I am wondering what's the reason to change it?
For me it seems imageio works fine and scm gives me problems.

In the initial versions for the two projects, I use similar libraries.
After that, I updated the mini-imagenet-tools more often, but I didn't update this project correspondingly. Sorry about that.
You may directly use the dataloader for miniImageNet on tieredImageNet with minor changes. You may also apply the dataloader I used in this project for different datasets.

Thanks, good to know your new project.
And last thing is that the following line works for me using:
class_idxs = list(range(0, self.way_num))
https://github.com/yaoyao-liu/tiered-imagenet-tools/blob/master/tiered_imagenet_dataloader.py#L147
with these fixes, it works fine for me now.

Thanks.
You may create a pull request for this issue so that I can include you in the contributors' list.

It's fine, only several minor points, you could fix it directly if that is correct to you.

Thanks for the contributions.


Codebase sync

Hello!
Here is a pull request for syncing and keeping the subbranches up to date.
Thanks!

Ready to merge, no review required


Errors After Install and Run

After I run "npm i" and then "npm start" I get the errors below:

This is on Mac OSX

Hi Turner,
Thanks for taking the time to report an issue, however I cannot replicate it:
npm i
npm start

This is what I get:

It seems an error with Babel as you get the Unexpected token => on the arrow function. Which version of Node have you got installed?

Are you using Node.js 5.10.1 also on your Mac?

I will check this issue tonight. Sorry only have my PC at the moment.

Hi Bartoli, I was using v0.12.2. I upgraded to v6.2.2 and it's working without errors now. Thank you.


Fix typo and rephrase sentence in lib/hbc/cli.rb

[x] Followed hacking.md.

Fixes a typo in one sentence and rephrases it to be more specific.

I just added a commit to https://github.com/caskroom/homebrew-cask/pull/23246.
Closing this, as this would create a conflict.

@reitermarkus: You missed the typo though! And install is technically not a noun.

@Eitot, just pushed again. Should be correct now.


6.x maitnenance

Description

fixes a memory leak
shouldn't be merged at this time
seems to do great things

This should be updated and merged, but only after:
https://github.com/osmosis-labs/iavl/pull/40
AND
https://github.com/osmosis-labs/cosmos-sdk/pull/200
ps, @p0mvn -- yes, this works to address the memory leak in v6, I think.  Running with 150mb cache and seems stable at about 60gb ram use.

For contributor use:

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer

Codecov Report

Merging #1281 (00ccd8c) into v6.x (2b61fd3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             v6.x    #1281   +/-   ##
=======================================
  Coverage   19.06%   19.06%
=======================================
  Files         167      167
  Lines       23684    23684
=======================================
  Hits         4516     4516
  Misses      18387    18387
  Partials      781      781

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b61fd3...00ccd8c. Read the comment docs.

Awesome! Great to hear that the cache change helped to address this issue on v6.x

This can address
https://github.com/osmosis-labs/osmosis/issues/1239

@faddat are we still blocked on the PRs in IAVL and SDK with this?

no, I don't think so

Yes.
Otherwise we end up with memory issues.
Should I replace to the commits in your PR's?
It's otherwise 100% ready to go.

Thanks for the update. Let's wait for the IAVL PR to get merged :+1:

Closing this for now, due to it being stale, and our open PR list beginning to get hard to manage


Alias shell support

Please describe the problem you're trying to solve
I have a ton of aliases, like for example instead of lazygit, I am used to typing lg. So when I press : for shell, and type lazygit, it works fine but not with lg.
Similarly for other aliases too.
Would you be willing to contribute this feature?

[X] Yes, I'll give it a shot

Describe the solution you'd like
If from my ~/.zshrc (or bashrc, etc.) aliases can be ran through a flag --alias then it would be great. This would add on the functionalities.
Additional context
Also I don't know how to write lua/rust but if someone can help me with how to do it. I am willing to work on this.

Yazi uses sh by default because it's available on all platforms, on most Linux systems, sh points to bash, so if your aliases are defined in bashrc, it should work fine.
For zsh, a potential solution is to allow users to set the default shell, but this would require us to adapt to different shells (zsh, fish, nushell), which would be a complex task due to needing to consider the specific behaviors and all edge cases of each shell. I don't have plan to support this, but I'm open to reviewing and accepting PRs for it.
Another solution is to define those aliases in Yazi, like:
{ on = [ ":", "l", "g" ], run = "shell lazygit --block --confirm" }

Or, if you just want to use zsh, you can achieve it with a simple plugin (save it as ~/.config/yazi/plugins/zsh.yazi/init.lua):
return {
  entry = function()
    local value, event = ya.input {
      title = "Zsh shell:",
      position = { "top-center", y = 3, w = 40 },
    }
    if event == 1 then
      ya.manager_emit("shell", {
        "zsh -c " .. ya.quote(value, true),
        block = true,
        confirm = true,
      })
    end
  end,
}

Then bind it in your keymap.toml:
{ on = [ ":" ], run = "plugin zsh" }

That did not work.

This is how it looks like. I tried changing the keymap directly where it originally as well as adding separately like-
[[manager.prepend_keymap]]
on = [":"]
run = "plugin zsh"
desc = "Run zsh commands"

Although if I do plugin --sync zsh, it didnt show the error. but didnt work either.

I've updated the code, try it again. This is how it works on my side:
https://github.com/sxyazi/yazi/assets/17523360/6eeac180-0364-436b-ba6c-02e8d4127a3e

I donno why it is not working for me :( . Is their any thing I can send details on so that it can be debugged? It looks ideal at your end.

This plugin essentially does:
sh -c 'zsh -ic "your-alias-here; exit"'

so you can run it directly in your shell and see what happens.

That worked perfectly. it opened lazygit nicely.
oh wait. I see what might be the problem. I have setup few commands to run when my zsh opens like taskwarrior. Thats why it didnt open directly. Although lazygit takes over the whole screen so it should technically work in yazi as well. What do you think? ( This is a bit personal customisation going on here)
Ill report back to you the results after I remove them.

It works fine even with and without having the extra text and commands.


Can Fastlane servers be clustered?

I have an issue where my fastlane mac mini goes offline every now and then. Was thinking of have another mini running as well. Is it possible to run Fastlane clustered or with failover? I just didn't want both running the same job from Gitlab at the same time

This is not within the scope of fastlane. There is no serving mechanism. The solution seems like it should be within the realm of gitlab. It should have the ability to preform a health check on your mini and failover to another one if possible.

Fast Lane is an authorized Cisco Learning Specialized Partner and authorized Cisco Business Learning Partner. With certified, experienced instructors, our broad Cisco curriculum covers routing and switching, networking, wireless, security, service provider, collaboration, and data center technologies. We offer a range of courses and certifications, from entry-level to advanced specialist, all featuring content that is approved by Cisco.


Fix Share dialog not resolving promise when dismissed on iOS

Summary
On iOS the promised returned by Share.share(content, options) isn't resolved if the user dismisses the dialog by either pressing "Cancel" or pressing outside the shared dialog. This PR fixes this issue.
This fixes #26809.

Changelog

[iOS] [Fixed] - Fix promised returned by Share.share(content, options) not resolving if share dialog dismissed
Test Plan

on iOS, open a share dialog with:

const onShare = async () => {
  const result = await Share.share({ message: 'example message' });
}

Dismiss the opened share dialog and the returned promised should resolve.

So it looks like this is because of my PR (https://github.com/facebook/react-native/pull/26429). I added this check because we need to have some sort of guard against the success callback being called multiple times. Is there a way we can know that the ActionSheet was closed so we can do if (completed || dismissed)?

@v-fernandez so I think we can change the check to:
if (completed || activityType == nil)
It looks like in completionWithItemsHandler the activityType will only be nil if the user closed the ShareSheet themselves, like so:

Here's when they close the reminders modal:

And the photos modal:

This should fix the current issue without reintroducing the crash.

@tomtargosz makes sense. I'll update the PR with this. Thanks for the help!

When is this PR going to be picked?

When is this PR going to be picked?

https://github.com/facebook/react-native/releases/tag/v0.62.0-rc.0


Balance calculator middle-ware.

this middleware should take the user object after saving the user object in the DB then it will calculate the following properties [sick_leaves, anual_leaves, leave_execuses ] and then return them.
see this issue to more suspence
The second middleware should take these returned values as well as the user object then it will create a record in the vacation_balance table linked to this user.

@mhmdhelmy28
Please mention what you did!


Package for building Go apps during tests

For tests that cover more functionality than unit tests we currently have to resort to bash scripts, or to have the SCION test infrastructure running. This either (1) does not integrate with our unit testing framework, (2) is more brittle and (3) requires more busywork/is harder to automate.
 We can use this in the future to test utilities (like the scion-pki tool) and servers (like SCIOND) while still using the same patterns and environment we run in our unit tests.

This change is

Reviewed 1 of 3 files at r1.
Review status: 1 of 3 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

go/lib/xtest/loader/binary.go, line 59 at r1 (raw file):

// Build compiles package target, and saves the resulting binary in directory
// dir with a file name starting with prefix, and a randomly generated suffix.
func Build(target, dir, prefix string) string {

This does not allow for any build flags to be passed in. I suggest you add build flags to Binary and have this method take an additional parameter.

Comments from Reviewable

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.

go/lib/xtest/loader/binary.go, line 59 at r1 (raw file):
Previously, shitz wrote…
This does not allow for any build flags to be passed in. I suggest you add build flags to Binary and have this method take an additional parameter.

Done.

Comments from Reviewable

Reviewed 1 of 2 files at r2.
Review status: 1 of 3 files reviewed at latest revision, 1 unresolved discussion.

go/lib/xtest/loader/binary.go, line 45 at r2 (raw file):

	if name, err := Build(b.Target, b.Dir, b.Prefix, b.BuildFlags...); err != nil {
		return err
	} else {

I really prefer when there code adheres to the so called 'line-of-sight of code', i.e., remove the else. See https://medium.com/@matryer/line-of-sight-in-code-186dd7cdea88 for more info.

Comments from Reviewable

Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion.

go/lib/xtest/loader/binary.go, line 45 at r2 (raw file):
Previously, shitz wrote…
I really prefer when there code adheres to the so called 'line-of-sight of code', i.e., remove the else. See https://medium.com/@matryer/line-of-sight-in-code-186dd7cdea88 for more info.

I generally adhere to what the article is advocating; the only time I choose not to do that is if it interferes with my preference for aggressive scoping (e.g., when I need to declare some variable in the function's top scope, even though its lifetime is only relevant for an if/else block). It's something I've also seen on the Golang slack as causing quite a lot of debate :-).
In this case, since the function is very short so there is no risk of the top-level scope getting polluted, I think your suggestion is cleaner. Done.

Comments from Reviewable

Reviewed 6 of 8 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


https://github.com/gaupt/devops_todolist_cicd_task_3_docker_ci/actions/runs/9810084259

https://github.com/gaupt/devops_todolist_cicd_task_3_docker_ci/actions/runs/9810214432