Needs to polish these screens for Tutorials

[x] App initialisation

Downloading the app and starting as a new app
Onboarding screens help user know a bit about the app before they start.
Use of login time for the useful tips. It is important to educate the user while they use the app.
They land on a simple Home Screen.

[x] App Backup/ Recovery Key

Using the Action Card and backing up the Recovery Key
Recovery key is a fundamental piece of the app and it is great UX that is also very sovereign. You don't need accounts with Keeper.
More here: https://medium.com/bitbees/what-is-a-recovery-key-in-bitcoin-keeper-9a1c6716bc82

[x] Hot Wallets

You can create multiple hot wallets in Keeper but don't need to back them up as all are generated from the parent Recovery Key (BIP 85)
Hot Wallets can be used for different purposes to keep your stack separate and manage UTXOs easily
We can create a few from Add then Hot Wallet option

[x] Wallet actions (Send, Receive, Buy and Manage UTXOs)

We can show receive and send in hot wallets.
While sending you can see that if you want to transfer to other wallets/ vaults in the app, there is no need to copy paste the address.
You can do custom fee and it even tells you how the fee is behaving. We call it Fee Insight.
We can also manage UTXOs and Buy directly into a wallet or vault.

[x] Manage Keys

This allows you to add and manage keys to be used in the app
You can add almost all types of Hardware Wallets.
You have more options in Soft Keys (Mobile Key, External key and Seed key)
You can also add Assisted Keys (Signing Server and Inheritance Key)
For now we can add a TapSigner, a couple of Mobile Keys, a Cold Card, a Jade, a Passport and a Seed Signer. You can also choose the medium you want to use where different mediums are available. I will use the file medium with CC as CC NFC is not great.

[x] Add options

You can use this to create new or import external wallets/ vaults.
We can try some/ all the options here. They are self explanatory.
Collaborative Vault is a template to quickly create a 2 of 3 vault with friends and family w/o needing a hardware wallet.

[x] Multi-key vaults

We can create a Collab Wallet to start. You will also need two other apps here with their Mobile Key which act as co-signers or External keys in this app.
We can also create another 3 of 5 from the keys we have added with say a TS, CC, MK, Jade and Seed Signer
Send and receive work similar in vault as in the wallet but needs multiple signatures. We can try that flow.

squirrel hero shop bulk muffin hedgehog melt suggest depth critic current narrow

Is this a valid issue now? I think everything on this is done @cakesoft-utkarsh


bpkg metadata

Addresses #54.
Adds a package.json that allows bpkg to install shpec on our behalf. Once this is merged, I'll open the PR to add shpec to bpkg's list.

I'm not bumping the version here because a) there's no real change to the library and b) it's not actually part of bpkg yet, this was just the preliminary step.


Use inward tickets and Co57/Ni57 in get_modeldata()

Hello @lukeshingles! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file artistools/spectra.py:

Line 41:121: E501 line too long (125 > 120 characters)
Line 961:121: E501 line too long (147 > 120 characters)

Pull Request Test Coverage Report for Build 255

7 of 9 (77.78%)  changed or added relevant lines in 6 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.03%) to 58.996%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

artistools/radfield.py
0
2
0.0%

Files with Coverage Reduction
New Missed Lines
%

artistools/radfield.py
1
20.63%

Totals

Change from base Build 253:
0.03%

Covered Lines:
2915

Relevant Lines:
4941

💛  - Coveralls


News limit is not working correctly

Acknowledge the following

[x ] I carefully read and followed the Getting Started guide.
[x ] I read through FAQ and searched through the past issues, none of which addressed my issue.
[x ] The issue I am raising is a potential bug in al-folio and not just a usage question.  [For usage questions, please post in the Discussions instead of raising an issue.]

Describe the bug
A clear and concise description of what the bug is.
News limit (5 by default) is not working correctly on the About page. The webpage will display all the news items and disregard the limit.
To Reproduce
Steps to reproduce the behavior:

Go to '_news'
Add more news by copying and pasting announcement files
Enter "http://<IP_ADDRESS>:4000" in the browser to open the About page
See all the news in the bottom. News limit (should only display 5 news items by default) is not work.

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
System (please complete the following information):

OS: [e.g. iOS] Mac OS
Browser (and its version) [e.g. chrome, safari] Both Chrome and Safari
Jekyll version [e.g. 3.8.7] 4.3.2
Ruby version [e.g. 2.6.5] 3.1.3

Additional context
Add any other context about the problem here.

The problem here is that in _config.yml we have news in two locations:
collections:
  news:

news:
  enabled: true

And the code only uses correctly the collection one. Renaming the second news to something like site_news and using it like site.site_news solves this. What do you think of renaming this in _config.yml to announcements @alshedivat? Or do you have another suggestion?

Thanks for fixing the bug. There is another request I would like to ask. Right now I set the news limit to 5, and it works perfectly on the About page. However, when I click on News link, a new page will pop up with only 5 news items. I assume when people click on News, they expect to see all the news. So is it possible to display all the news on this new page disregard the news limit?

I realized that when you click on the news link, it basically opens the same piece of code (news.html) without the rest. Any idea how to handle this case @alshedivat @rohandebsarkar @pourmand1376?


handling additional addons and configurations

it would be great if additional addons don't prevent from updating from master.
it would be nice if there is a place where i can overwrite the theme/addon configs without having a pull conflict.
any plans how to add common addons? maybe a .md where people can PR addons? with instructions where to add code?

common addons as in? once the module system is finalized I'll make official contributing guidelines but for now:

New modules / PR to modules can just be PR'd as you would with any other project
"Contrib modules" (modules that are great but outside the scope of nyoom) can be uploaded to their own repository. I'll make a contrib folder, and these contribute modules will be git submodules in that contrib folder
User configuration (stuff that doesn't fall under the "improved defaults" umbrella) should stay between config.fnl and packages.fnl. Currently this is a bit hard, but in the future you'll be able to change module defaults within config.fnl

I hope that makes sense

is what i mean with common, modules that are out of scope. the contrib idea sounds good
how about a user/config.fnl that get loaded last and could overwrite stuff like core modules settings, colorschemes and keybindings

imho users should be able to update /.config/nvim with a git pull and still be able to access to the user config and the contrib modules

re number 2, yeah thats the idea once all the core stuff is sorted. I want to make the module system final or else people who make modules will have to remake them with new changes etc.
As for number 3, thats the intention of the current config.fnl and packages.fnl. It's supposed to be entirely for use configuration and packages. Its just I haven't gotten around to making the functions/macros for it, as I've been focusing on the aforementioned module system (and recently the colorscheme rewrites)

thanks,
i added some stuff to my config
https://github.com/luxus/nyoom.nvim/tree/develop
its mostly straight forward

basic support for after has been added, along with additional modules etc. Closing this issue for now


Fix: MiniMax model function call

PR content:
fix MiniMax model function call and unit tests.
Most scenarios has worked, but in some complex situations within the English context, if there are multiple rounds of function calls, there's a certain probability they might stop prematurely.
For example, when trying to get the weather for multiple locations at once, but the function for getting the weather only accepts a single location as a parameter. This is mainly limited by the model's performance.
related issue: https://github.com/spring-projects/spring-ai/issues/1077

HI @mxsl-gr  and thank you for the update.
As we are deprecating AbstractFunctionCallSupport in favor of AbstractToolCallSupport would you be interested to re-work your PR to support AbstractToolCallSupport?
For examples, you can check the OpenAI/AzureOpenAI/Anthropic/Mistral/Ollama/VertexAIGemini function calling implementations, or ask me for support ;)
Would appreciate your help as you own those models.

hi, no problem, i'll check and handle them later

hi, @tzolov
it worked for now, and this PR has been squash and force pushed

some issues in streaming, but as with the other PRs you made, it is better to get this in as it is a big step forward.
Thanks and apologies for the delay.
merged in 0927bd197db7ed4f8ac7fa7d99c9cbfdc24b3c27

some issues in streaming, but as with the other PRs you made, it is better to get this in as it is a big step forward.
Thanks and apologies for the delay.
merged in 0927bd1

thanks for you merged my PR, when i committed this PR,  all tests passed. i will check it out later to see what the problem is


Both current slide dot and next slide dot highlighted, but no slide change

short description of the bug / issue, provide more detail below.

Sometimes clicking on the current dot and then clicking on the next dot causes both dots to be highlighted, but the slide does not change.
====================================================================
jsFiddle not needed. Can reproduce on the website.
====================================================================
Steps to reproduce the problem
Sometimes the bug happens, but sometimes it does not. After repeating the following steps several times, it eventually comes up.

Click on the dot of the current slide.
Click on the dot of the next slide.
If the bug didn't happen, click on the dot of the previous slide and try again starting at step 1.

====================================================================
What is the expected behaviour?
Slick should show the next slide (in this case slide 2) and the dot for the current slide should be un-highlighted.
====================================================================
What is observed behaviour?

====================================================================
More Details

Which browsers/versions does it happen on?

I've tried this on Chrome.

Which jQuery/Slick version are you using?

Tested on the website and on the provided jsFiddle, so the latest one. (1.6.0)

I just did a quick look. I see that there is really only "active" class applied and it only happens when you click between dots very quickly. My guess is that it has to do with a CSS property you set on focus or the animation speed.

Can reproduce by switching dots before the transition finishes.
http://imgur.com/SIcuM50

+1

Did you guys already found the solution? Otherwise I can take a look. I have a version in my website where I don't have that bug. Almost certain it's CSS related, but can't point it out directly.

I had fixed the problem with 'waitForAnimate: false'

Ahhh sounds logical! :)


A / AAAA record does not exist error

Problem
I only get a 404 response when I add your settings to my Fritz!Box.
I'm using a Strato domain with cloudflare.
I tried using ipv4 and ipv6, neither worked (ipv4 will probably never work due to my provider)
Settings

Strato domain
cloudflare setup
A record is shown in cloudflare
AAAA record is shown in cloudflare
DynDNS settings in Fritz!Box as you explained

Screenshots
Cloudflare

Strato

What would I have to specify for record if I only want to change my A record? Essentially, I don't want to change the A record for www.example.com, but I want to change the A record for example.com.


test changes

PR description
Fixed Issue(s)

Changelog

[ ] I thought about the changelog and included a changelog update if required.

Codecov Report

Merging #469 (cc2f9f7) into main (ccdc299) will increase coverage by 2.59%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
+ Coverage   59.84%   62.43%   +2.59%
==========================================
  Files         155      144      -11
  Lines        7481     7129     -352
==========================================
- Hits         4477     4451      -26
+ Misses       2707     2383     -324
+ Partials      297      295       -2

Flag
Coverage Δ

acceptance
67.83% <ø> (+4.66%)
:arrow_up:

unittests
62.43% <ø> (+2.59%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/stores/connectors/stores/get_key.go

src/stores/connectors/stores/import_secrets.go

src/stores/connectors/stores/create_secret.go

src/stores/connectors/stores/get_eth.go

src/stores/connectors/stores/get_secret.go

src/stores/connectors/stores/import_keys.go

src/stores/connectors/stores/import_eth.go

src/stores/connectors/stores/stores.go

src/stores/connectors/stores/create_key.go

src/stores/connectors/stores/create_eth.go

... and 2 more


_jibSkaffoldFilesV2 fails with subproject dependencies

Environment:

Jib version: 3.0.0
Build tool: jib-gradle-plugin
OS:  Mac OSX 11.1 (20C69)

Description of the issue:
The gradle task _jibSkaffoldFilesV2 (used by skaffold) fails when defining implementation dependencies from a subproject.
Expected behavior:
This can be reproduced in the example project by commenting out the line
    implementation project(':api')

$ ./gradlew clean _jibSkaffoldFilesV2

...
> Task :_jibSkaffoldFilesV2

BEGIN JIB JSON
{"build":["/Users/seth/projects/minimal-service/build.gradle","/Users/seth/projects/minimal-service/settings.gradle"],"in.....

Steps to reproduce:

git clone https://github.com/sethrylan/skaffold-minimal-service
./gradlew clean _jibSkaffoldFilesV2

jib-gradle-plugin Configuration:
See https://github.com/sethrylan/skaffold-minimal-service/blob/main/build.gradle
plugins {
    id 'java'
    id 'org.springframework.boot' version '2.4.5'
    id 'io.spring.dependency-management' version '1.0.11.RELEASE'
    id 'com.google.cloud.tools.jib' version '3.0.0'
}

group = 'org.example'
version = '0.0.1'

repositories {
    mavenCentral()
}

configurations {
    api
}

dependencies {
    implementation 'org.springframework.boot:spring-boot-starter-web'

    api project(':api')
    implementation project(':api')
}

jib {
    to {
        image = "$project.name"
    }
    container {
        mainClass = 'org.example.Application'
        ports = ['8080']
    }
}

Log output:
> Task :_jibSkaffoldFilesV2 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':_jibSkaffoldFilesV2'.
> Configuration with name 'default' not found.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 685ms
2 actionable tasks: 1 executed, 1 up-to-date

One workaround to this error is to name the configuration for subproject dependencies. E.g.,
    implementation project(path: ':api', configuration: 'client')

instead of
    implementation project(':api')

Although gradle's dependency resolution seems to figure out that the unnamed dependency matches client, the assumption of an empty configurationName as "default" doesn't work the same in FilesTaskV2.listFiles.

This seems like a bug, but it's probably not a high priority since there is a workaround.
Thanks for the report! We welcome community contributions for this.

Keeping open as the bug is still valid AFAIK.


Unit test for threadsCount library component

Write a unit test for threadsCount library component, issue #715

using mock metrics data update the store
test that the header threadscount has the expected value
test that the JVM threadscount tab has the expected value

Is this something that you've already started? I think some of these components might be impacted by changes around #610.

@I started this yesterday but no solid progress with enzyme mount issues.

@karinakeen - I'm just saying I think that the threadsCount stuff might get refactored and the stuff you're proposing to test might get refactored out of the project, so this should be considered blocking until #610 is complete.

@spmcbride1201 sounds good.

@spmcbride1201 pretty sure this is irrelevant now ^^

Yep, closing


i've fixed the issue and restarted but still wont chage

Steps to Reproduce

...
...
...

Logs

If you have an issue to report, please open a new issue and fill in the requested details. Without any information, we cannot investigate or help.

sorry, i thought i filled all the forms.


Remove undesirable direct dependency on github.com/juju

There remains some indirect dependencies on github.com/juju, those
will be addressed separately.

In response to a cherrypick label: new pull request created: #18429


If the search input box has no focus (cursor not in box) then do not show suggestions

currently, if a search was done, there is no focus on the search box (which is correct), the search result page is shown (correct) but search suggestions are showed below the search box and this overlaps with the search result, see example:

Please do not show the suggestions if there is no focus on the search input box

This is now can be checked on live.


Package up as a Mac App?

Hey, this project is super cool. I was wondering how difficult it would be to turn the built binary into a .dmg or put in the App Store?
I tried https://github.com/sindresorhus/create-dmg, but it has certain expectations about the build:
Error: ENOTDIR: not a directory, open 'main/Contents/Info.plist'

you just need a plist and make an app bundle. but you also have to deal with signing and notarizing. and entitlements.

Got it! If I get it working with MacDriver, I'll write an update here.


Handle Rate Limit Responses in Prom Client

What does this PR change?

Adds a PrometheusClientConfig instance for grouping configuration options passed to instantiation.
Adds a RetryOnRateLimit option (defaulted to true) which will process a rate limit response, determine wait time from the response headers (if available), wait, then retry.
Reorganize the way we create the rate limited clients to remove env.Get from implementations, further decoupling of client functionality to allow for better unit tests
Added RateLimitedResponseError which is returned if retries are exhausted for rate limited responses
Handle Amazon Services strange 400 Status Code with ThrottlingException body, and treat as rate limited response.

How does this PR impact users? (This is the kind of thing that goes in release notes!)

Prometheus and Thanos Clients now handle Rate Limited Responses. A response is recognized as rate limited/throttled if:

Response has 429 Status Code (Header contains Retry-After or not)
Response has 400 Status Code and Response body contains "ThrottleException". This addresses cases where Amazon's Managed Prometheus will use a 400 instead of 429 for throttling.

How was this PR tested?
Unit Tests covering all rate limit conditions:
=== RUN   TestRateLimitedOnceAndSuccess
=== PAUSE TestRateLimitedOnceAndSuccess
=== RUN   TestRateLimitedOnceAndFail
=== PAUSE TestRateLimitedOnceAndFail
=== RUN   TestRateLimitedResponses
=== PAUSE TestRateLimitedResponses
=== RUN   TestConcurrentRateLimiting
=== PAUSE TestConcurrentRateLimiting
=== CONT  TestRateLimitedOnceAndSuccess
=== CONT  TestRateLimitedResponses
=== CONT  TestConcurrentRateLimiting
=== CONT  TestRateLimitedOnceAndFail
--- PASS: TestRateLimitedOnceAndSuccess (2.50s)
--- PASS: TestRateLimitedOnceAndFail (2.50s)
=== CONT  TestConcurrentRateLimiting
    /home/mbolt/kubecost/kubecost-cost-model/cost-model/pkg/prom/ratelimitedclient_test.go:348: Request was Rate Limited and Retries Exhausted:
         * Wait Time: 1.00 seconds, Retries Remaining: 4
         * Wait Time: 1.00 seconds, Retries Remaining: 3
         * Wait Time: 2.00 seconds, Retries Remaining: 2
         * Wait Time: 1.00 seconds, Retries Remaining: 1
         * Wait Time: 0.00 seconds, Retries Remaining: 0

=== CONT  TestRateLimitedResponses
    /home/mbolt/kubecost/kubecost-cost-model/cost-model/pkg/prom/ratelimitedclient_test.go:246: Request was Rate Limited and Retries Exhausted:
         * Wait Time: 2.00 seconds, Retries Remaining: 4
         * Wait Time: 1.93 seconds, Retries Remaining: 3
         * Wait Time: 1.00 seconds, Retries Remaining: 2
         * Wait Time: 1.00 seconds, Retries Remaining: 1
         * Wait Time: 3.00 seconds, Retries Remaining: 0

--- PASS: TestRateLimitedResponses (10.44s)
=== CONT  TestConcurrentRateLimiting
    /home/mbolt/kubecost/kubecost-cost-model/cost-model/pkg/prom/ratelimitedclient_test.go:348: Request was Rate Limited and Retries Exhausted:
         * Wait Time: 2.00 seconds, Retries Remaining: 4
         * Wait Time: 3.00 seconds, Retries Remaining: 3
         * Wait Time: 3.00 seconds, Retries Remaining: 2
         * Wait Time: 0.00 seconds, Retries Remaining: 1
         * Wait Time: 1.00 seconds, Retries Remaining: 0

    /home/mbolt/kubecost/kubecost-cost-model/cost-model/pkg/prom/ratelimitedclient_test.go:348: Request was Rate Limited and Retries Exhausted:
         * Wait Time: 4.18 seconds, Retries Remaining: 4
         * Wait Time: 0.00 seconds, Retries Remaining: 3
         * Wait Time: 1.00 seconds, Retries Remaining: 2
         * Wait Time: 2.00 seconds, Retries Remaining: 1
         * Wait Time: 2.00 seconds, Retries Remaining: 0

    /home/mbolt/kubecost/kubecost-cost-model/cost-model/pkg/prom/ratelimitedclient_test.go:348: Request was Rate Limited and Retries Exhausted:
         * Wait Time: 1.00 seconds, Retries Remaining: 4
         * Wait Time: 3.00 seconds, Retries Remaining: 3
         * Wait Time: 0.00 seconds, Retries Remaining: 2
         * Wait Time: 1.00 seconds, Retries Remaining: 1
         * Wait Time: 1.00 seconds, Retries Remaining: 0

    /home/mbolt/kubecost/kubecost-cost-model/cost-model/pkg/prom/ratelimitedclient_test.go:348: Request was Rate Limited and Retries Exhausted:
         * Wait Time: 2.00 seconds, Retries Remaining: 4
         * Wait Time: 3.00 seconds, Retries Remaining: 3
         * Wait Time: 0.00 seconds, Retries Remaining: 2
         * Wait Time: 1.00 seconds, Retries Remaining: 1
         * Wait Time: 1.00 seconds, Retries Remaining: 0

--- PASS: TestConcurrentRateLimiting (19.01s)
PASS
ok  	github.com/kubecost/cost-model/pkg/prom	19.018s

@dahamr @valdisrigdon Thanks for the input here. I've added the following environment variables:

PROMETHEUS_RETRY_ON_RATE_LIMIT: [Defaults to true] Setting to false will disable the response inspection and retries.
PROMETHEUS_RETRY_ON_RATE_LIMIT_MAX_RETRIES: [Defaults to 5] The maximum retries attempted per request (where the response is rate limited).
PROMETHEUS_RETRY_ON_RATE_LIMIT_DEFAULT_WAIT: [Defaults to "100ms"] The default wait time used if a Retry-After header doesn't exist in the response. The value is used to apply an exponential backoff based on the retry attempt as well. So, wait times of: 100ms, 200ms, 400ms, 800ms, 1600ms for the default retries of 5.

Hope this will at least get you guys past the weird AWS throttling. Let me or @AjayTripathy if you need anymore help here!


Tutorial: Running Multiple Instances of Your App may have a wrong suggestion of preparation.

This is a Bug Report

Problem: The tutorial Running Multiple Instances of Your App may have a wrong suggestion before trying to scaling.
Snippet:

NOTE If you are trying this after the previous section , you may need to start from creating a cluster as the services may have been deleted

Proposed Solution: The suggest tutorial shouldn't be creating a cluster but Using kubectl to Create a Deployment. Because the previous section only mentioned delete Deployment, not about the cluster.
Page to Update:
https://kubernetes.io/docs/tutorials/kubernetes-basics/scale/scale-intro/

/language en

/sig docs

Thanks for filing! Looks like this note was updated by https://github.com/kubernetes/website/pull/44752. If you have any other suggestions for improving this page, please file a new issue :)
/close


feat: version flag

Closes #6

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

33 of 34 (97.06%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.8%) to 90.852%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cmd/otelinji/main.go
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.8%

Covered Lines:
437

Relevant Lines:
481

💛  - Coveralls


Switch from actix-web to a better maintained web framework

From https://github.com/roapi/roapi/pull/75#issuecomment-918385245. We should evaluate both warp and https://github.com/tokio-rs/axum.

rocket has added async support, so we should evaluate them as well.

What is your criteria for evaluation? I have started using rocket for a little project I am working on, so if there are some features you want to compare I can share what I have learned about rocket to compare with other frameworks.

I don't have a very objective rule here. I prefer frameworks that have intuitive APIs without layers of unnecessary abstractions and coupling. So mostly coding style I guess. Code base with simple and right level of abstractions makes it easier maintain, debug, optimize and troubleshoot.
I have been ignoring rocket mainly because they didn't have tokio 1.x support. Author of rocket is a really solid engineer, so I have high hope for it :)
But honestly, I am happy if we can migrate to any of these 3 frameworks because I am really not a fan of actix-web :( I think feature wise they should be pretty comparable.

I am looking at the different options and currently there are some outstanding issues that would be impacted by / could influence the decision:

#16
#40
#77
#80

At this point I investigated Axum the most:

#16 and #77 (GRPC) on a single endpoint is described here. Apparently not super easy, but working solution available.
#40 is supported, see: axum::extract::ws
#80 is not supported as it is in Actix.

Apart from that, it seems that compiling certain routes is problematic for the Rust compiler, as described in rust-lang/rust#88322 and tokio-rs/axum#200. https://github.com/tokio-rs/axum/issues/200#issuecomment-903724433 lists a possible workaround that might be sufficient. I did find similar problems for Warp, see seanmonstar/warp#507.
I think I am quite positive about Axum. Regardless of that, how would we go about this change anyways? In https://github.com/roapi/roapi/pull/67#issue-987875891 I suggested having integration tests through an HTTP api, which I think would be very helpful for migrating the codebase without having (too much ;)) regressions.
Coincidentally, https://github.com/tokio-rs/axum/issues/200#issuecomment-914506125 has an example how we could go about that with Hyper. The Zero To Production series also uses this approach: blog and code.

Sorry @ekroon I have been busy with datafusion lately, so I won't have much time to help with the web framework evaluation this week. If you are feeling good about axum, then please feel free to give it a stab :)
I am all for integration tests over unit tests. So if you want to contribute integration tests to help with the migration, that would be great.

I did a quick PoC with both axum and rocket, see: https://github.com/houqp/roapi/tree/qp_axum and https://github.com/houqp/roapi/tree/qp_rocket.
For my very limited and uncomprehensive test, rocket port was doing around 29k rps, axum 33k rps and actix 39k. But I think rocket's performance issue is the less concerning part, after all, we can help them fix these performance bottlenecks. What I really don't like about rocket is it's heavily dependent on macros. These procedure macros are not as easy to study and debug compared to simple structs and functions that axum has. Most of the UX problem these macros addressed can be easily handled by simple generic functions that are a lot easier to maintain. The rocket community also seems to be in an inactive state right now for the last couple months.
I am not that concerned about downloads and popularities. Flask is the most popular web framework in the python community, and it's a pretty bad framework of choice for serious python projects.
I think we should go with axum for now. I really like its simplicity and debuggability compared to all other choices. @ekroon let me know if you need any help with the integration tests.


Create none auth service and enable auth for router and console

@grs This is without TLS on the auth-service connection, but we plan to address that in a later task.


Update utils file

Resolves #52
Proposed changes

Updated the Exceptions to more exact Exceptions.
Added custom exceptions BatchUpdateError, UnorderedQuerySetError
Fixed objs to objects
Added model factories to make creating test objects easier
Added factory-boy to dev dependencies
Updated utils docstrings for uniformity following numpydoc style.

Types of changes
What types of changes does your code introduce to DjangoTypesense?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d676ec2) 71.96% compared to head (0c368e2) 79.50%.
 Consider uploading reports for the commit 1959c5a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   71.96%   79.50%   +7.54%
==========================================
  Files          11       12       +1
  Lines         560      571      +11
==========================================
+ Hits          403      454      +51
+ Misses        157      117      -40

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@EricOuma done. Please review. Thanks


When a bot dies, respawns in other server.

Maybe client bug, maybe slither anti bot protection.

the server keeps changing so that we have fun and not get savaged by others

Try use a vps. if ur already using one maybe check if any extension is on.

Just lol... Go out, and stop spaming wiht ISSUES.


Login freeze

(TrueCraft.Launcher:12925): GLib-GObject-WARNING **: Attempt to add property __gtksharp_6_Xwt_GtkBackend_ImageRenderer::image after class was initialised
System.NotImplementedException: The requested feature is not implemented.
at System.Net.WebRequest.CreateHttp (System.String requestUriString) [0x00000] in :0
at TrueCraft.Launcher.Views.LoginView.LogInButton_Clicked (System.Object sender, System.EventArgs e) [0x00000] in :0
at Xwt.Button.OnClicked (System.EventArgs e) [0x00000] in :0
at Xwt.Button+WidgetBackendHost.OnClicked () [0x00000] in :0
at Xwt.GtkBackend.ButtonBackend.m__0 () [0x00000] in :0
at Xwt.Toolkit.Invoke (System.Action a) [0x00000] in :0

mono --version

Mono JIT compiler version 3.2.8 (Debian 3.2.8+dfsg-4ubuntu1.1)
Copyright (C) 2002-2014 Novell, Inc, Xamarin Inc and Contributors. www.mono-project.com
TLS:           __thread
SIGSEGV:       altstack
Notifications: epoll
Architecture:  amd64
Disabled:      none
Misc:          softdebug
LLVM:          supported, not enabled.
GC:            sgen

Upgrade to at least mono 3.12.
http://www.mono-project.com/docs/getting-started/install/linux/#debian-ubuntu-and-derivatives

Fixed. Ty.


Provide an option to exclude namespaces from ConfigMap creation

Describe the feature request
Please provide an option to exclude namespaces from ConfigMap creation/update and/or limit the rate of logging of the following information.
In our cluster Istio doesn't have the permission to create ConfigMaps in all namespaces (for example in kube-system). Because of that, it logs every second this message for each namespace where the create action is denied:
2021-04-26T09:22:47.847447Z	info	Work item handle failed (error when creating configmap istio-ca-root-cert: configmaps is forbidden:
User "system:serviceaccount:istio-system:istiod-service-account" cannot create resource "configmaps" in API group "" in the namespace "kube-system":
["You're not allowed to create/update/delete/exec on namespaced resources in kube-system and xxxx-system"]), retry after delay 1s

This spams the logs with unwanted information.
Describe alternatives you've considered
I've asked in the forum for a workaround https://discuss.istio.io/t/how-to-exclude-namespaces-from-creation-of-configmap-with-root-certificate/9614 and I've also checked the source code (\pilot\pkg\serviceregistry\kube\controller\namespacecontroller.go) to no avail.
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[x] User Experience
[ ] Developer Infrastructure
Additional context

What Kubernetes platform is blocking the permission? You're not allowed to create/update/delete/exec on namespaced resources in  does not seem like a standard k8s one.
@lei-tang should we just not retry on RBAC denied?

There are a few possible options to address the issue (first two have been mentioned above):

Provide an option to exclude namespaces from ConfigMap creation/update and/or limit the rate of logging of the following information.
If the ConfigMap creation failure is caused by the lack of RBAC permission, print the error log and do not retry.
Provide an option to configure the maximum number of retries for ConfigMap creation.

@howardjohn, we're deploying in a K8s cluster (v1.20.5-xyz) that has a custom deny policy for two namespaces (implemented using https://github.com/c445/kubernetes-policy-controller and https://github.com/open-policy-agent/opa).

RBAC is not the only issue this would help with. In our cluster we create many (multiple thousands) of namespaces, many of which are short lived, where we run things that don't need istio at all. istiod has a very hard time keeping up with that. Worse, if it doesn't create the config map before the namespace goes away, it will forever requeue the internal task to try to create that config map. This creates an ever-increasing list of tasks in istiod's queue, tasks which will never succeed. We have to periodically kill istiod to get around that.
istio 1.4 (I think) supported a namespace label (ca.istio.io/override) which IIRC caused istio to ignore the namespace completely. That option seems to have gone away in 1.5 and I couldn't find anything to replace it.


NodeJS support

On the website it says:

It can run in the browser or on a server with NodeJS.

When importing the library in Node however, I get the following error:
Uncaught ReferenceError: document is not defined

Thanks for the report!
I see the issue  and I'll get a patch out as soon as possible.

Unfortunately, I'm swamped at the moment. Could probably get a patch out by early May.
Thanks for the patience.

Hello,
Thanks for the patience! This has now been patched in v1.1.0.
Make sure to check the wiki section Use on NodeJS - the usage is slightly different.
If you run into any problems please let me know 👍


Fix for CMSIS-NN operator. Merge from ref conv.cc.

The testcase "FilterDimsNotMatchingAffineQuantization" was failing for CMSIS-NN. The reason is that there has been a change in the ref operator that is now merged into the cmsis operator. Also, I changed kMaxChannels to be able to handle the person detect model.
Change-Id: I1311d2f8b8c6e297b3af97a7cc0498f146bd4677

@suharshs review approval needed

Hi @suharshs , I believe this PR needs your approval as well. Cheers!

Ready to merge! Error seem unrelated to changes in this PR:
=== Sanity check step 5 of 15: do_buildifier (buildifier check) ===
Running do_buildifier on 373 files
tensorflow/compiler/xla/BUILD # reformat
tensorflow/compiler/jit/BUILD # reformat
buildifier took 0 s
FAIL: buildifier found errors and/or warnings in above BUILD files.
buildifier suggested the following changes:
tensorflow/compiler/xla/BUILD:
1c1

Ready to merge


How to use hub with custom http URL without SSL

What exactly is the problem you're running into? What's its current behavior?
It's worth noting that the normal GitHub API can only be accessed over HTTPS.

hi there, I think I have a similar 'issue'. We are running GitHub enterprise internally, and it is running on http:// (so, no SSL). I have configured hub to use our GitHub hostname (using git config's hub.host setting) but I guess hub is hardcoded to use https:// here.
I know that HTTPS is a way to go, but for GitHub Enterprise installations, when they sometimes are on isolated networks (like in our case), there is no need for HTTPS. It would be good to have an option here, IMHO

That is exactly my problem. ^

Right now, you have to configure this manually within the ~/.config/hub file. Find the existing config for your GHE host and add the protocol line:
example.com:
- user: mislav
  oauth_token: REDACTED
  protocol: http

@mislav hmm, I thing it should be in ~/.config/hub, not ~/.hub/config :)

@mislav I can confirm that does not work.

@Swoorup What exactly did you try? (Please show ~/.config/hub, which sensitive data redacted.)  What happened instead?
This feature was around since hub 2.2.0. It's a bit of a hassle, but it always worked. 🤔

I can confirm that it works.

github:
- user: swoorup
  oauth_token: REDACTED
  protocol: http

I ran the hub issue command on the repository whose URL is in format of git://. It then asked me, for my username and password. After entering it, it would take quite a while and show me errors. I could see it tried to access a https site instead.

In the first line of what you pasted there is github:. Instead of that, it should be the exact name of your host where GHE is installed, in the same way it appears in the git://HOSTNAME/... url for your git remote. Can you double-check that it matches?

Its github :) without the [dot] com

Ah, I see. Which hub version do you have? What do you see when you use HUB_VERBOSE=1 hub issue in that repo? (Again, try to mask out sensitive data!)

@Swoorup Did you ever manage to get this working?

Closing due to lack of info


crashes on $finish and $fatal

if(!failed) begin
  $fwrite(fd, "Test passed!\n");
  $finish;
end else begin
  $fatal(1, "Test failed!");
end

end

If this is within a valid outer construct, such as a a module,
module foo ();
  if (!failed) begin
    $fwrite(fd, "Test passed!\n");
    $finish;
  end else begin
    $fatal(1, "Test failed!");
  end
endmodule

It will not bail out with a syntax error.
However, the formatted output still adds seemingly unnecessary newlines. And misses a newline before the $finish; @jbylicki can you have a look ?
module foo ();
  if (!failed) begin
    $fwrite(
        fd, "Test passed!\n"
    ); $finish;
  end else begin
    $fatal(
        1, "Test failed!"
    );
  end
endmodule

It does crash. But not in a small example than the above. I worked around it by doing
....
end else begin
$display("Test failed!");
$fatal(1);
end


[Kernel] Cleanup the FileNames.java utility methods

Some of the utility methods in FileNames.java take strings and some Paths. For string input, it is either the file name or the file path. It is confusing and can easily cause bugs. Unify all APIs to take Path (we anyway create Path in all places when the utility methods are used)
Also, avoid using finding the / to figure out the file name. This could be risky. Instead rely on the Path.
    final int slashIdx = path.lastIndexOf(Path.SEPARATOR); <-- avoid this.
    final String name = path.substring(slashIdx + 1);
    return Long.parseLong(name.split("\\.")[0]);

can I pick it ?


Bring to mongo spec for $ne on fields of arrays of objects.

Addresses issue #143
If running a $ne operation on an array of sub-objects, the object being filtered should only pass if all of the sub-objects pass the $ne query.  Prior to this the object would pass if only one of the sub-objects passed the $ne query.

Awesome, thanks for doing this! This should be published to npm as version 6.0.0.


Why are my logistics vessels going as far as possible first?

Hi there,
Basically title, I noticed my logistics vessels are going as far as possible first (34.1 LY) to get FireIce rather than the gas giant that is in my local system with 40 orbital collectors and plenty of stored FireIce. I tried adjusting the TLDCBalance float values from 1 to 100 and it still happens. (If I'm being honest, I don't even know if it's your mod that is causing this to happen...but it seemed like a good place to start.)
Thanks for your great mod! :)

Example case of TLDCBalance:
transport range of vessels: 2LY
TLDCDemandMultiplier: 10
Import from a range of 2LY when storage is over 3,000.
When storage is less than 3,000, import from a range of 2x10=20LY.
If "transport range of vessels" is left at its default value of infinity, TLDCBalance setting will have no effect (infinity is treated as 10,000LY).
LSTM does not have the ability to prioritize transport from nearby locations like IntelligentTransport mod.
One solution is to make the "transport range of vessels" small enough and set TLConsiderOppositeRange to true to prevent self-serving imports from other stations if you want.
Or use IntelligentTransport mod (I haven't used it, so I don't know how it works in detail)


certloader: prevent panic when Watcher.Stop is called multiple times

Problem
Panic in Hubble when context is cancelled too quickly
 time="2024-12-04T08:02:03.359947688Z" level=error msg="Error while serving from Hubble server" address=":4244" error="grpc: the server has been stopped" subsys=hubble
panic: close of closed channel

goroutine 400 [running]:
github.com/cilium/cilium/pkg/crypto/certloader.(*Watcher).Stop(...)
    /go/src/github.com/cilium/cilium/pkg/crypto/certloader/watcher.go:200
github.com/cilium/cilium/pkg/hubble/cell.(*hu

Explanation
In pkg/hubble/cell/hubbleintegration.go, we have a racy stop behaviour:
h.log.WithFields(logrus.Fields{
	"address": address,
	"tls":     !h.config.DisableServerTLS,
}).Info("Starting Hubble server")

// (4)
go func() {
	// (5)
	if err := srv.Serve(); err != nil {
		// (6) err: grpc: the server has been stopped
		// NOTE: error only happens if serve is called AFTER Stop() is called.
		h.log.WithError(err).WithField("address", address).Error("Error while serving from Hubble server")
		// (7) close(tlsServerConfig.stop == nil) -> panic
		if tlsServerConfig != nil {
			tlsServerConfig.Stop()
		}
	}
}()

// (1)
go func() {
	<-ctx.Done()
	// (2)
	srv.Stop()
	if tlsServerConfig != nil {
		// (3)
		tlsServerConfig.Stop()
		// tlsServerConfig.stop == nil
	}
}()

Fix
Since we plan on further updating the hubble cell integration and incorporate more components into the hive ecosystem, therefore modifying this behaviour in the near future, I apply a quick fix at the source by preventing the close call on the stop channel to happen twice.

/test


Question: Why not using 'WaitAny' instead of 'WaitAll'

Hello there
at the line 113 of WebsockifyMiddleware.cs in my opinion you could have used WaitAny so if one of the loops ends then the second loop ends too and the middleware execution terminates.
Even better would be using Task.WhenAny(WebLoop, TcpLoop), what do you think?
Cheers

I will try to follow your suggestion. Thanks.

I will try to follow your suggestion. Thanks.

@MouriNaruto thank you... I don't have much time at the moment but in a couple of weeks from now I can make that change and try it connecting to a x11vnc server and push a PR

@MouriNaruto thank you... I don't have much time at the moment but in a couple of weeks from now I can make that change and try it connecting to a x11vnc server and push a PR


[Bug]: RegEx Helper Dash Bug

Version of the software
0.1.27 [Beta]
Operating system
Windows 10
Browser / Native
Browser [Chrome/Firefox/Brave]
What happened?
A bug happened!

dash should be escaped in this case, or will cause problems
also i guess 'Test Regex' should show an error here instead of this
Relevant LoliCode if needed
No response

#387


pytest ContractContainer imports

What I did
Allow import of  ContractContainer instances from main brownie package when running tests. This behavior is documented, but for some reason was never actually implemented :fearful:
How I did it
Move namespace black magic from project.scripts.run to class methods in project.main.Project
How to verify it
Run the tests.
Checklist

[x] I have confirmed that my PR passes all linting checks
[x] I have included test cases
[x] I have added an entry to the changelog

cc @celioggr, thanks for pointing this out


Allow users to give projects away

It would be useful to be able to properly give a project you created to another user. At the moment the 'give this project' tab in project properties gives a copy of the project to another user rather than giving the actual project to the user. It would be useful for this tab to include the option to give ownership of the project to the specified user too. At the moment this is only possible by an admin via management. I'd rather users be able to do this themselves if needed, e.g. where they have changed roles.

I've had a request for this now too e.g.
Would it be good to also allow a creator to transfer the ownership of their objects to other people? For example, before a user leaves the University, they can clear unused objects and pass their objects to another colleague. When the owner is unavailable, Xerte administrators can help them too.

Just to add to this while it's in my mind...
I think one of the advantages of enabling a user to do this before they leave is that they may have better insight into which projects should be transferred to different users. On the other hand if this is about a user leaving in some cases at least they are perhaps more likely to do this (rather than just leave without doing it) if the option included transferring all projects in one go rather than one by one or at least the option to select multiple and then transfer all those selected in one go.


Update logo image in footer

Resolves Update logo image in footer ticket in Asana by updating the styles in the footer styles sheet and using an img with alt in place of the existing span.

Noticed there was a margin-left being set elsewhere on about, so added something that seemed reasonable to this PR:
On about:

Thanks, Katy! Thanks for looking at the original about site and implementing the margin-left


[GKE] allow setting svc spec.loadBalancerIP for GKE reserved/static IPs

[GKE] To use a reserved/static IP for LoadBalancer services you need to set spec.loadBalancerIP, rather than spec.externalIPs. This PR allows the following values to be set for GKE:
services:
  router:
    loadBalancerIP: <IP_ADDRESS>
    externalIPs: []
  ssh-proxy:
    loadBalancerIP: <IP_ADDRESS>
    externalIPs: []
  tcp-router:
    loadBalancerIP: <IP_ADDRESS>
    externalIPs: []

How Has This Been Tested?

against cf-operator v1.0.0
on GKE
only for services.router.loadBalancerIP to confirm my kube service switched to use my reserved IP

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code has security implications.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

fixes #291

@drnic Thanks for fixing this one!
@fargozhu We need a doc update for GKE.

after deploying kubecf with PR merged and set the values.yaml to support the described approach, I can see the endpoints created with the specified IPs but the k8s cluster EXTERNAL-IP column (router, ssh and tcp) are in pending state.


Envs that fail to build still show up in the UI

I have an environment that failed to build. The error I saw was 'you don't have permissions', but @costrouc investigated further and discovered that we ran out of disk space. Either way, the environment failed to build (with a conda exit code).
I would expect any env that fails to build should 1) repeat the error to me as a user and 2) Show on the UI that the environment doesn't actually exist.
Either we could provide a popup saying env failed to build (one that doesn't disappear until the user clicks 'OK') and completely remove the env from the UI
OR
Leave the env in the UI, but add some visual indicators (red labels, background, etc) to let users know that its not available and provide some easy to see error statement (not just the logs).

An edge case that might to worth considering in this context - that @costrouc  mentioned to me -  is when a restart of conda-store-server occurs during a build. The build will not show up as failed but will persist in that state indefinitely. A check during start-up should make sure that there are no "pre-existing builds" as these were likely interrupted and will not complete. There is a caveat that there might be more than one instance of conda-store-server so pre-existing builds are legitimate in some situations.

Want to mention that this issue is now resolved in conda-store now on server restart. There is a check when the server restarts on build which are BUILDING but the actual task id does not exist on the celery workers. Implying the build failed.
Additionally there are now check for disk space on build so this edge case should now be resolved.
I'd be in favor of closing this issue and reopening if on a new conda-store-server version this issue persists.


UID 1000 not found

sudo startxfce4
Entering /mnt/stateful_partition/crouton/chroots/xenial...
UID 1000 not found in xenial
Unmounting /mnt/stateful_partition/crouton/chroots/xenial...
when i just re-installed crouton this popped up

That error message is most likely due to an incomplete crouton installation.
Try updating it with: sudo sh ~/Downloads/crouton -n xenial -u
Hope this helps,
-DennisLfromGA


reformat the download output

reformat the download output
e.g.
$ ilab model download
Downloading model from Hugging Face:
    Model: instructlab/merlinite-7b-lab-GGUF@main
    Destination: /Users/user/.cache/instructlab/models

Downloading model failed with the following Hugging Face Hub error:
    (ProtocolError('Connection aborted.', ConnectionResetError(54, 'Connection reset by peer')), '(Request ID: eb0fd877-eae3-4799-b6a2-47422213a96f)')

Downloading model failed with the following error: 1

---------------
$ ilab model download --repository=TheBloke/Mixtral-8x7B-Instruct-v0.1-GGUF --filename=mixtral-8x7b-instruct-v0.1.Q4_K_M.gguf
Downloading model from Hugging Face:
    Model: TheBloke/Mixtral-8x7B-Instruct-v0.1-GGUF@main
    Destination: /Users/user/.cache/instructlab/models

TheBloke/Mixtral-8x7B-Instruct-v0.1-GGUF requires a HF Token to be set.
Please use '--hf-token' or 'export HF_TOKEN' to download all necessary models

---------------
$ ilab model download --repository=TheBlokeMixtral-8x7B-Instruct-v0.1-GGUF --filename=mixtral-8x7b-instruct-v0.1.Q4_K_M.gguf
repository TheBlokeMixtral-8x7B-Instruct-v0.1-GGUF matches neither Hugging Face nor OCI registry format.
Please supply a valid repository.

---------------
$ ilab model download --repository docker://xx.xx.io/xx/mixtral-8x7b-instruct-v0-1 --release 1.1
Downloading model from OCI registry:
    Model<EMAIL_ADDRESS>    Destination: /Users/user/.cache/instructlab/models

skopeo is not installed.
Please install recommended version: 1.9.0

Downloading model failed with the following error: 1

---------------
$ ilab model download --repository docker://xx.xx.xx/xx/mixtral-8x7b-instruct-v0-1 --release 1.1
Downloading model from OCI registry:
    Model<EMAIL_ADDRESS>    Destination: /Users/user/.cache/instructlab/models

Downloading model failed with the following error:
    skopeo version 1.8.1 is lower than 1.9.0.
    Please upgrade it.

Checklist:

[ ] Commit Message Formatting: Commit titles and messages follow guidelines in the
conventional commits.
[ ] Changelog updated with breaking and/or notable changes for the next minor release.
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Functional tests have been added, if necessary.
[ ] E2E Workflow tests have been added, if necessary.

thanks

hi team, anyone more help to take a look? thanks.

@jaideepr97  PTAL


"Loading data" after first image generation

After restarting the addon, it works and generates the wanted image:

After a while, it just displays "loading data" perpetually:

Logs
Starting browser...
Visiting 'http://nucky:8123' to login...
Adding authentication entry to browser's local storage...
Starting first render...
Rendering http://nucky:8123/dashboard-displays/0?kiosk to image...
Converting rendered screenshot of http://nucky:8123/dashboard-displays/0?kiosk to grayscale...
Finished http://nucky:8123/dashboard-displays/0?kiosk
Starting rendering cronjob...
Server is running at 5000
2024-05-11T13:55:44.063Z: Image 1 was accessed
Invalid request: /favicon.ico for page NaN
2024-05-11T13:55:45.833Z: Image 1 was accessed
Rendering http://nucky:8123/dashboard-displays/0?kiosk to image...
Converting rendered screenshot of http://nucky:8123/dashboard-displays/0?kiosk to grayscale...
Finished http://nucky:8123/dashboard-displays/0?kiosk
Rendering http://nucky:8123/dashboard-displays/0?kiosk to image...
Converting rendered screenshot of http://nucky:8123/dashboard-displays/0?kiosk to grayscale...
Finished http://nucky:8123/dashboard-displays/0?kiosk
2024-05-11T13:57:12.173Z: Image 1 was accessed
2024-05-11T13:57:37.048Z: Image 1 was accessed
Rendering http://nucky:8123/dashboard-displays/0?kiosk to image...
Converting rendered screenshot of http://nucky:8123/dashboard-displays/0?kiosk to grayscale...
Finished http://nucky:8123/dashboard-displays/0?kiosk
Rendering http://nucky:8123/dashboard-displays/0?kiosk to image...
Converting rendered screenshot of http://nucky:8123/dashboard-displays/0?kiosk to grayscale...
Finished http://nucky:8123/dashboard-displays/0?kiosk
2024-05-11T13:59:12.176Z: Image 1 was accessed
Rendering http://nucky:8123/dashboard-displays/0?kiosk to image...
Converting rendered screenshot of http://nucky:8123/dashboard-displays/0?kiosk to grayscale...
Finished http://nucky:8123/dashboard-displays/0?kiosk
2024-05-11T14:00:02.022Z: Image 1 was accessed
Invalid request: /favicon.ico for page NaN

Found this maybe related issue: https://github.com/sibbl/hass-lovelace-kindle-screensaver/issues/15
I've played with the RENDERING_DELAY parameter, but it doesn't help. Tried 5, 10, 100 and 1000 as delay, but it doesn't seem to change anything.
config:

Anybody else have this problem?

RENDERING_DELAY set to 10000 seems to fix it.

Thanks for the feedback! 10000 ms, which is 10s, rendering delay indeed makes sense - especially for slower devices which I guess is used here.
At some point the browser just tells this tool "I'm done with the first render of the website" but i.e. Javascript is still executed. Depending on how much data is still loaded and then needs to be drawn, this can take up to 10s or more.
To be safe, I could imagine that 15-20s may also be a reasonable value there (so 15000 or 20000 ms as the input value).

It worked fine without any delay before the most recent home assistant update ( https://github.com/home-assistant/core/releases/tag/2024.5.3 ), that's why I didn't close this issue.
Also, not really a slow device. I'm using the mainboard of a framework laptop with an i5-1135G7. (Not great, not terrible lol)
I think there might be something going wrong in the addon, which now necessitates the delay


[WIP] Optimize signature verification

Still getting OOG on tests for InvalidSigner, not sure why

If signer == 0  and  signature.length != 27 or 28 then this function could allow the signature.
As a safety precaution: check signer !=0
function _assertValidSignature(address signer, ..., bytes memory signature ) ... {
    address recoveredSigner;
    assembly {
        let signatureLength := mload(signature)
        let lenDiff := sub(ECDSA_MaxLength, signatureLength)
        ...
        if lt(lenDiff, 2) {    // assume this false
            ...
        }
        ...
        success := eq(signer, recoveredSigner)   // if signer happens to be 0 then success = true
        ...
    }
}

Still getting OOG on tests for InvalidSigner, not sure why

Maybe because EIP1271WalletCrossChain.sol returns a string on revert?
https://github.com/ProjectOpenSea/seaport/blob/c1711de558a93e039ec93d42c4ea2898c3f55652/contracts/test/EIP1271WalletCrossChain.sol#L131-L136

Still getting OOG on tests for InvalidSigner, not sure why

Look like static call even success for EOA case

Performed a cleanup pass (including managing stack pressure) and moved to using the existing 1271 test contract as the new one was introducing unnecessary complexity. Could use further review!

_ No description provided. _

Stop and allow it


Recent activity for basketball

Hey, this API is awesome and it's really approved my fantasy football keeper league that's been together for 10 years. I also want to use it to get the recent activity for my fantasy basketball league. I noticed that the capability to access the activity is not in the basketball/league.py. Is this something that can be easily added? Or is it not possible?
Thanks so much!

I'm glad it's been helpful! Yeah I think it should be pretty simple adding recent activity to basketball. I will look into it in the next couple days!

I tried to implement it the same way as you do for football, but it is only giving me the team names. Not the adds and drops.
Here is what I added:
https://github.com/jwill24/espn-api/blob/master/espn_api/basketball/constant.py#L102-L115
https://github.com/jwill24/espn-api/blob/master/espn_api/basketball/league.py#L70-L94

I see the issue. You need to add self._fetch_players() when the league is created. Look at https://github.com/cwendt94/espn-api/blob/master/espn_api/football/league.py#L27. This will get all NBA player id's and name

When you get a chance could you open a PR for the new recent_activity changes in basketball!


Can BaGet hosting under Default Website in IIS possible?

Hi ,
Right BaGet is hosted with port 5000.
Can we host it as application under Default web site in IIS?
Please help on this .
@loic-sharma please help on this

I suggest you deploy it as a single website. It's just a normal ASP.NET Core, which means you just need to config the app settings, as same as what other projects do.


Matrix multiplication vs elementwise multiplication

Hi @mortcanty,
In numpy, the * operator in numpy corresponds to element-wise multiplication whereas np.matmul or (@ operator since Python 3.5) corresponds to matrix multiplication. So should'nt the notation be fixed in places such as this?

That's right, it is confusing. But S = cpm.covariance() returns a matrix object S and not a numpy array so s11*s22 etc is interpreted as matrix multiplication.

Ah I see. That makes sense. Thanks for clearing it up.

As a side note, what is your preferred method of contact if a reader of your book has some questions (not necessarily code related)?

email probably best for me. I'll look into discussions, thanks


Invalid semver tag error when running manually

https://github.com/silverstripe/gha-merge-up/actions/runs/5994977394/job/16257325820
Ran it manually on the default branch

This was previously fixed ... though the ironically auto-tag didn't work :-) I've manually updated v1 to match 1.0.2


fix: join chat message content, removing empty space

What does this PR do?
Fixes #128.

Thank you @bhimrazy, merged!


Documentation bug

In the section entitled "Automatic Schema Inference", the text says the example "returns the number of rows in September 2017 without specifying a schema." However, I don't think that's what the query returns. Rather, it just returns the first 10 rows, and does not limit it to September 2017.
Phil
https://research.microsoft.com/~philbe

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7770a017-f3de-4ffb-fbe1-7f673e46b9f6
Version Independent ID: 17f6ec57-f223-63ef-e8a6-971a756c186b
Content: Query Parquet files using serverless SQL pool - Azure Synapse Analytics
Content Source: articles/synapse-analytics/sql/query-parquet-files.md
Service: synapse-analytics
Sub-service: sql
GitHub Login: @azaricstefan
Microsoft Alias: stefanazaric

@philbe
Thanks for the feedback and bringing this to our notice. At this time we are reviewing the feedback and will update the document as appropriate.

Hi @philbe you are correct!
I created a pull request for this.
Thanks!

Since a PR has been created I'm going to close this thread.


Add combined account community selector and fix remaining issues from #327

Add a combined community/account selector
No longer show mock data but show the actual available accounts in the sliding up panel
Add community opens the world map with pins with communities, so you can select a community there
Add account opens the existing add account page
The selected account/community gets highlighted with a blue circle
clicking outside the panel closes it (this is the only way to close it)
closes #331 and remainder of #327

adding account works. But, strangely, I didn't need to enter the PIN when I did that and it wasn't cached. How can that be? How will the account be encrypted?

This is a very good catch. The account will be encrypted, but the seed probably is "". This breaks this account, as it will not be successfully decrypted if the PIN is entered.
This PR will fix this error systematically, but it is not quite ready yet.

guess you're referring to #506 ?


[RFC] Introduce String.fromBytes and String.fromCodePoints methods.

One thing I find rather awkward in Wren is manipulating strings as byte buffers. Although converting a string to a mutable byte list is easy enough, converting it back again after manipulation is not so nice as the following simple case conversion shows:
var s = "wren"
var bytes = s.bytes.toList
var S = bytes.map { |b| String.fromByte(b - 32) }.join()
System.print(S) // WREN

On the face of it, you're having to convert each byte to a string and then concatenating them all together which is hardly efficient.
I'm not sure how strings are implemented in Wren - length prefixed byte buffers? - but I'd have thought there must be a much more efficient way of doing this from the C side of things.
I realize of course that a String.fromBytes method would imply an ASCII encoding (and String.fromCodePoints a UTF-8 encoding) but I make no apologies for that as these are by far the commonest string encodings in current use.
Is there perhaps some technical difficulty here as I've always found it strange that Wren doesn't have String.upper and String.lower methods which even languages with minimal standard libraries usually have. Although these are easy enough to write in Wren itself, they're inefficient and very slow for large strings.
I'd appreciate any comments.

While I agree this is sometimes awkward, nothing prevent you from having a
separate ByteList class with fromString constructor and toString to achieve
the same functionality.
Having it in the core means means that the base language grow, which is not
usually wanted.
String is implemented as a read-only structure, because of internals trades
of mainly to implement a fast hash map.
toLower and toUpper does not exist because nobody felt the need yet, but it
seems legitimate.

While I agree this is sometimes awkward, nothing prevent you from having a
separate ByteList class with fromString constructor and toString to achieve
the same functionality.
Having it in the core means means that the base language grow, which is not
usually wanted.
String is implemented as a read-only structure, because of internals trades
of mainly to implement a fast hash map.
toLower and toUpper does not exist because nobody felt the need yet, but it
seems legitimate.

From a technical point we can make a mitigated solution, by allowing a List of Num to be converted to a String.
this would go like this:
String {
   static fromBytes(bytes) { fromBytes_(bytes.toList) }
   foreign static fromBytes_(bytes)
}

fromBytes_ would check that the given argument is a List containg only integer numbers compatible with bytes. And construct a tring of it.

From a technical point we can make a mitigated solution, by allowing a List of Num to be converted to a String.
this would go like this:
String {
   static fromBytes(bytes) { fromBytes_(bytes.toList) }
   foreign static fromBytes_(bytes)
}

fromBytes_ would check that the given argument is a List containg only integer numbers compatible with bytes. And construct a tring of it.

About the toLower to Upper, the problem might reside in the fact that we don't use an UTF-8 library to provides a valid conversion.
At best we can do a cheap ASCII-7 version of it which might be not enough for some people.

About the toLower to Upper, the problem might reside in the fact that we don't use an UTF-8 library to provides a valid conversion.
At best we can do a cheap ASCII-7 version of it which might be not enough for some people.

From a technical point we can make a mitigated solution, by allowing a List of Num to be converted to a String.

Yes,  as long as the  fromBytes_ private method is implemented in C, I'd be happy with that.

About the toLower to Upper, the problem might reside in the fact that we don't use an UTF-8 library to provides a valid conversion.

I agree that's a difficulty. In my own implementations of these methods, I go a bit further than ASCII-7 by dealing with code-points up to 255 which, apart from a few rare characters, is enough to deal with all the major Western European languages. Much improved coverage and still quite cheap to implement .

From a technical point we can make a mitigated solution, by allowing a List of Num to be converted to a String.

Yes,  as long as the  fromBytes_ private method is implemented in C, I'd be happy with that.

About the toLower to Upper, the problem might reside in the fact that we don't use an UTF-8 library to provides a valid conversion.

I agree that's a difficulty. In my own implementations of these methods, I go a bit further than ASCII-7 by dealing with code-points up to 255 which, apart from a few rare characters, is enough to deal with all the major Western European languages. Much improved coverage and still quite cheap to implement .

If we go that route we migth also whant to have a fromCodePoints

If we go that route we migth also whant to have a fromCodePoints

Yes, we'd ideally need both to maintain symmetry with the existing String.fromByte and String.fromCodePoint methods.
However, even without knowing much about the VM internals, I can see that the latter would be trickier to implement.
For the 'bytes' version, you'd already know the size of the string buffer needed from the size of the list and presumably you could just 'block copy' the byte values into that.
For the 'codePoints' version, you'd need to iterate through the list (whose elements could now go up to 0x10ffff rather than just 0xff) to figure out how many bytes would be needed to represent that element in UTF-8 and then allocate a string buffer big enough to accommodate the total. You'd then need to iterate through the list again and embed the bytes for each element, one by one, into the buffer. There may be ways to optimize this process but it's clearly going to be much slower than the 'bytes' version.
If the list contained any 'out of range' values,  that would have to be a runtime error as it is now for the existing single byte/code-point conversion methods.

Yes, we'd ideally need both to maintain symmetry with the existing String.fromByte and String.fromCodePoint methods.
However, even without knowing much about the VM internals, I can see that the latter would be trickier to implement.
For the 'bytes' version, you'd already know the size of the string buffer needed from the size of the list and presumably you could just 'block copy' the byte values into that.
For the 'codePoints' version, you'd need to iterate through the list (whose elements could now go up to 0x10ffff rather than just 0xff) to figure out how many bytes would be needed to represent that element in UTF-8 and then allocate a string buffer big enough to accommodate the total. You'd then need to iterate through the list again and embed the bytes for each element, one by one, into the buffer. There may be ways to optimize this process but it's clearly going to be much slower than the 'bytes' version.
If the list contained any 'out of range' values,  that would have to be a runtime error as it is now for the existing single byte/code-point conversion methods.

Incidentally, if we had a String.fromCodePoints method, then it might be quick enough to implement String.lower and String.upper methods in Wren itself.

Incidentally, if we had a String.fromCodePoints method, then it might be quick enough to implement String.lower and String.upper methods in Wren itself.

I'm thinking, things can be a little bit more complicated than that, and
maybe we should be only utf-8 encoding compatible and not compliant. This
would removed a lots of headache.

I'm thinking, things can be a little bit more complicated than that, and
maybe we should be only utf-8 encoding compatible and not compliant. This
would removed a lots of headache.

maybe we should be only utf-8 encoding compatible and not compliant

Can you clarify, as I'm not sure what you mean by that.
Do you perhaps mean that out of range values could be dealt with by masking rather than throwing runtime errors?

maybe we should be only utf-8 encoding compatible and not compliant

Can you clarify, as I'm not sure what you mean by that.
Do you perhaps mean that out of range values could be dealt with by masking rather than throwing runtime errors?

I mean allowing all the possible codepoints that the encoding allows, it
means no baning of some ranges due to some code pages due to UTF-16 and up
to 8 (or so) byte long encodings.

I mean allowing all the possible codepoints that the encoding allows, it
means no baning of some ranges due to some code pages due to UTF-16 and up
to 8 (or so) byte long encodings.

Yes, but isn't it going to seem odd to people if  String.fromCodePoints isn't completely consistent with String.fromCodePoint?
The latter is after all just a degenerate case (for one code-point) of the former.

Yes, but isn't it going to seem odd to people if  String.fromCodePoints isn't completely consistent with String.fromCodePoint?
The latter is after all just a degenerate case (for one code-point) of the former.

The idea is to reuse things, but to extends things to allow all encodings. The compliance was not a goal, so why not go all the way?

The idea is to reuse things, but to extends things to allow all encodings. The compliance was not a goal, so why not go all the way?

I'm not sure that I see much practical value in that as I don't know why anyone would be interested in, say, UTF-16 unless they were trying to embed Wren in a Java or C# application.
But, as long as the existing String.fromCodePoint method were extended in a similar way, I'd have no particular problem with it.

I'm not sure that I see much practical value in that as I don't know why anyone would be interested in, say, UTF-16 unless they were trying to embed Wren in a Java or C# application.
But, as long as the existing String.fromCodePoint method were extended in a similar way, I'd have no particular problem with it.

fromBytes is done. Need polish, doc and tests.

fromBytes is done. Need polish, doc and tests.

Great stuff!
Possible docs:
String.fromBytes(bytes)
Creates a new string consisting of each byte in a List of bytes.
System.print(String.fromBytes([87, 114, 101, 110]) //> Wren

It is a runtime error if  bytes is not a List or if any byte is not an integer between 0 and 0xff, inclusive.

Great stuff!
Possible docs:
String.fromBytes(bytes)
Creates a new string consisting of each byte in a List of bytes.
System.print(String.fromBytes([87, 114, 101, 110]) //> Wren

It is a runtime error if  bytes is not a List or if any byte is not an integer between 0 and 0xff, inclusive.

fromCodePoint is done but I have to dig some obscure bug where the stack seems not to be correct..... and will do the polish later.

fromCodePoint is done but I have to dig some obscure bug where the stack seems not to be correct..... and will do the polish later.

Code is done (in a style that will probably rejected, but it is made to allow error return values) and polished (unless I found a really odd corner case in test, but it is so trivial that I have doubts).
Missing conformance tests, documentations yet.
Full encoding of max theoretical needs to be done in a separated patch.

Code is done (in a style that will probably rejected, but it is made to allow error return values) and polished (unless I found a really odd corner case in test, but it is so trivial that I have doubts).
Missing conformance tests, documentations yet.
Full encoding of max theoretical needs to be done in a separated patch.


CREATE TYPE support

Doltgres does not yet support user-defined datatypes, created through CREATE TYPE.
Types to support:

[x] enum
[ ] composite
[ ] range
[ ] base
[x] shell

Discovered through testing the sakila data dump

https://github.com/dolthub/doltgresql/pull/1045 adds partial support for enum and shell types.


running updated version of task 111

New PR for task #111 in reference to reverted changes in #134 . Should contain frontend template for Total Grants table on dashboard. See #111 for more details.

template and backend functionality connected in #150


Swallow shift keyboard event when dragging window

Summary of the Pull Request
Don't pass SHIFT keyboard press to other applications in chain when dragging window (and shift+drag option enabled in PowerToys).

PR Checklist

[x] Applies to #1141

Validation Steps Performed

Turn on FancyZones setting: Hold Shift key or any non-primary mouse button to enable zones while dragging
Open Google Chrome.
Press shift key and drag on of the opened tabs outside of main window.

Expected result: Zone hints are displayed and tab can be taken out of the main window and put to certain zone.

I tested the fix and it works when the key pressed event is received by FZ before Chrome, but that is not always the case, there are times when the event is processed by Chrome first.
Anyway, even if this is not perfect, let's go ahead and merge it.

I agree, that is something that we really can’t do much about it.

Any reason why this wasn’t on hold for 0.16?

You are right, we should have waited, we'll roll it back.


chore: add blog posts to README & contributors list

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: a2a70dfa4ca30bc1c62f59be2a2dd34eac2858ce
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 7afacfa93b739b37b3f809d1644f8e4928c3b9f7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: de6248568f6fa2b5c453750677ebb7d3c609aff3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: 95ab2b1aac95295b83dd7a1ae456af981d31aeb6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Organized todoList styling and setup, and hooked up example data

i haven't looked at the newer PR yet, but i don't see where it might have a conflict with the most recently approved PR.  doesn't appear to change the names of existing variables unless i missed it.


⚠ Bofrost.fr has degraded performance

In 17f7eaf, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1469 ms

Resolved: Bofrost.fr performance has improved in 282f0ae after 13 minutes.


Move typecheck-specific code to rsc.typecheck

Very soon, Rsc will gain the capability to load SemanticDBs produced
by metacp and use that information to understand third-party dependencies.
In preparation for that, I asked myself a question: "Which parts of
rsc.semantics make sense both for metadata loaded from SemanticDBs
and metadata computed during typechecking?".
Answering that question led me to believe that lots of data structures
and logic in rsc.semantics belongs to rsc.typecheck instead.
For example, the ceremony around scope statuses, the Scope.lookup/resolve
separation - all that is irrelevant to SemanticDB loading (at least,
as far as I can see now).

Blocked benchmarking 21b89e3. First, I'm planning to benchmark 4466172, and then I'll get back to this commit.

Accepted benchmarking 21b89e3. This may take a while.

Finished benchmarking 21b89e3.

Benchmark
Before
After

RscNativeTypecheck
64.516 ms
64.295 ms

RscTypecheck
26.373 ms
25.646 ms

Full results are available at https://github.com/twitter/rsc/commit/ba79d6c4f3b7158504d57a86d950096c9491626b.


NIFI-12959: Support loading python processors from NARs

Summary
NIFI-00000
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[ ] Apache NiFi Jira issue created

Pull Request Tracking

[ ] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[ ] Pull Request based on current revision of the main branch
[ ] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[ ] Build completed using mvn clean install -P contrib-check

[ ] JDK 21

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

Nice improvement Mark! Would this approach help with a processor like ParseDocument where Tesseract has to be installed on the node first?

@pvillard31 no, it wouldn't really help there. The issue there is that a native library like Tesseract would need to be compiled for the correct OS and architecture. So in order to include that, we'd need to include many copies of the library. And currently, we do not set any sort of environment variables telling it to search for native libraries in the NAR's unpacked directory. It might be worth exploring as a future improvement, though. Even though it may not help for something like ParseDocument, it might be helpful at least for custom nars, where perhaps you know that you're only going to run in containers or on a specific architecture/os so you can include the appropriate library for the custom nar?

Yeah, I must admit that I tried to figure out a way to use ParseDocument with NiFi in a container and I didn't manage to find a clean way to bring Tesseract into it. I feel like it would probably be easier to have it as a side container or something but I didn't find a way to piece everything together so I was naively (without too much hopes) thinking that this improvement may help :)

@dan-s1 thanks great catch. I removed some carrige-return-newline combos in that file and my IDE did something I didn't expect :) Fixed that.

Hi ,
When I try to follow the folder structure:

my-nar.nar
+-- META-INF/
    +-- MANIFEST.MF
+-- NAR-INF/
    +-- bundled-dependencies/
        +-- dependency1
        +-- dependency2
        +-- etc.
+-- MyProcessor.py

I keep getting the following error:
java.io.FileNotFoundException: work\nar\extensions\nifi-MyProcessor-nar-2.0.0-M4.nar-unpacked\MyProcessor.py (The system cannot find the path specified)
Please advise.


CASMCMS-8718: Fix CVE in CFS

Backport of https://github.com/Cray-HPE/csm/pull/2609

/backport release/1.5 release/1.6

Holding on this until it's ready to be promoted from the unstable branch.


The "Safely select entries with " example from wiki does not work correctly in command mode

FAQ

[X] I have checked the FAQ and it didn't resolve my problem.

Announcement

[X] I have checked Breaking change announcement.

Minimal reproducible full config
if has('vim_starting')
  set encoding=utf-8
endif
scriptencoding utf-8

if &compatible
  set nocompatible
endif

let s:plug_dir = expand('/tmp/plugged/vim-plug')
if !filereadable(s:plug_dir .. '/plug.vim')
  execute printf('!curl -fLo %s/autoload/plug.vim --create-dirs https://raw.githubusercontent.com/junegunn/vim-plug/master/plug.vim', s:plug_dir)
end

execute 'set runtimepath+=' . s:plug_dir
call plug#begin(s:plug_dir)
Plug 'hrsh7th/nvim-cmp'
Plug 'hrsh7th/cmp-buffer'
Plug 'hrsh7th/cmp-nvim-lsp'
Plug 'hrsh7th/vim-vsnip'
Plug 'neovim/nvim-lspconfig'
call plug#end()
PlugInstall | quit

" Setup global configuration. More on configuration below.
lua << EOF
local cmp = require "cmp"
cmp.setup {
  snippet = {
    expand = function(args)
      vim.fn["vsnip#anonymous"](args.body)
    end,
  },

  -- mapping = {
  --   ['<CR>'] = cmp.mapping.confirm({ select = true })
  -- },
  mapping = {
     ["<CR>"] = cmp.mapping({
       i = function(fallback)
         if cmp.visible() and cmp.get_active_entry() then
           cmp.confirm({ behavior = cmp.ConfirmBehavior.Replace, select = false })
         else
           fallback()
         end
       end,
       s = cmp.mapping.confirm({ select = true }),
       c = cmp.mapping.confirm({ behavior = cmp.ConfirmBehavior.Replace, select = true }),
     }),
  },

  sources = cmp.config.sources({
    { name = "nvim_lsp" },
    { name = "buffer" },
  }),
}
EOF

lua << EOF
local capabilities = require('cmp_nvim_lsp').default_capabilities()

require'lspconfig'.cssls.setup {
  capabilities = capabilities,
}
EOF

Description
With the added config from wiki: Safely select entries with <CR>
When in command mode and pressing tab for completion, selecting some other menu item than the first and then pressing <Enter><Enter> will execute the first item instead of the currently selected one.
Steps to reproduce
Type :co<TAB>
you get a menu of:
 colder
 colorscheme
 comclear
 command
 compiler
 confirm
 const
 continue
 copen
 copy

with the first entry colder selected by default
press <TAB> one more time so that colorscheme is selected
press <Enter>
:colorscheme is printed out in the command line, however when pressing <Enter> again this happens:
E380: At bottom of quickfix stack
error list 1 of 0; 0 errors
Press ENTER or type command to continue

Which is the output from the first entry colder Instead of the expected output from colorscheme which would be default.
Pressing :<Up> or :history to reveal the command history will show that :colder was actually entered.
Expected behavior
Selected menu entry would be executed instead of the first
Actual behavior
The first menu entry is always executed
Additional context
If I change this config line:
      c = cmp.mapping.confirm({ behavior = cmp.ConfirmBehavior.Replace, select = true }),

to:
      c = cmp.mapping.confirm({ behavior = cmp.ConfirmBehavior.Replace, select = false }),

Then it works as expected.
Not sure if it's a bug in the code, or a wrong example on wiki.

I am having the same issue and can confirm your change works as expected.


Add a make target to spin up only the database

Closes #468
Code Changes

[x] add the make target for just the db

Steps to Confirm

[x] run fidesctl commands with a local install of fidesctl that points to a localhost db

Pre-Merge Checklist

[x] All CI Pipelines Succeeded
[x] Documentation Updated
[x] Issue Requirements are Met
[x] Relevant Follow-Up Issues Created

Description Of Changes
For the sake of being able to dev when away from a power outlet, this option has been added as an even lower-power way to do some work when needed. It also helps us test fidesctl webserver more easily.
Power testing on my windows machine:

Using the dev containers: 10-14 watts
make cli: 9-12 watts
make api with the CLI running locally: 9-12
make db with the webserver and CLI running locally: 4-6

@PSalant726 i'm seeing this error when running locally:
(base) PS C:\Users\tal10\Documents\Git\fides> fidesctl status
Getting server status...
Server is reachable and the client/server application versions match.
Exception ignored in: <function _ProactorBasePipeTransport.del at 0x00000253304290D0>
Traceback (most recent call last):
File "C:\Users\tal10\anaconda3\lib\asyncio\proactor_events.py", line 116, in del
self.close()
File "C:\Users\tal10\anaconda3\lib\asyncio\proactor_events.py", line 108, in close
self._loop.call_soon(self._call_connection_lost, None)
File "C:\Users\tal10\anaconda3\lib\asyncio\base_events.py", line 719, in call_soon
self._check_closed()
File "C:\Users\tal10\anaconda3\lib\asyncio\base_events.py", line 508, in _check_closed
raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed

I've confirmed that the CLI works just fine when opting out of analytics

going to merge this and then open another issue for that...


Implement "natural sort" (a la ls -v)

The default ls implementation has a -v flag. This implements a "natural sort". This example shows the difference:
$ ls
1.txt  10.txt  11.txt  12.txt  2.txt
$ ls -v
1.txt  2.txt  10.txt  11.txt  12.txt

This also works with "version" numbers, like so (mostly the same idea):
$ ls
10.10  10.11  10.9  11.10  11.11  11.9	9.10  9.11  9.9
$ ls -v
9.9  9.10  9.11  10.9  10.10  10.11  11.9  11.10  11.11

Would we be interested in implementing this? I could look into implementing it if you think it would be a valuable feature.

I'd also appreciate it very much !
FWIW Exa has natural sort implemented.

A bit more information about Exa's implementation.
It uses the natord crate.
The implementation is here ; and there's a discussion on which sorting to choose by default there.
Exa's author chose to enable natural sort by default, and in practice I've found it to be very pleasant. I'd highly suggest making it the default for Lsd too.

Note: natord supports ANSI digits only.
humanesort uses unicode-segmentation crate.

fixed by https://github.com/Peltoche/lsd/commit/16f1b1ce7c45e98b505c2e7d57e0d46c88d882d3

@zwpaper : thanks for your work !
Just out of curiosity, what made you choose human-sort over humanesort ?

hi @ngirard
Actually there is not a special reason for choosing human-sort,
Maybe the main reason for me when researching is human-sort looks simpler and cleaner.
After reading this thread, I found what data-man mentioned, maybe unicode would be hidden trouble, I will work on it when necessary.


Bump version to 2.2.0

Prepping for the next OSG release. Is there anything else we want to sneak in before the dev freeze Tuesday?

I can't think of anything else to add.


feat: remove dependency on jekyll-feed

Provides correct updated attribute.
See: https://gist.github.com/HenryQW/77dd297e49187de9ef1a65e48ed46b0b
Based on: https://jekyllcodex.org/without-plugin/rss-feed/
Currently, jekyll-feed plugin doesn't generate the correct updated attribute,

Using this method, which also lifted the dependency on the plugin, provides the correct updated time based on modify_date in post front matter.

Probably not a good idea as it breaks relative links for  tags.
https://github.com/jekyll/jekyll-feed/blob/bf0b9c5721a0e41619920c62fa0cda4f4ff2ecf3/lib/jekyll-feed/feed.xml#L51
A second thought, jekyll-feed uses post.last_modified_at to determine updated wherelse it's renamed to modify_date in this theme. Is it possible to somehow link these two variables?
Some thing like modify_date=last_modified_at: 2018-03-13 in front matter.

Quick fix:
{%- if post.modify_date -%}
  {%- assign post.last_modified_at = post.modify_date -%}
{%- endif -%}

emmmmm, seems it didn't work. I'm clue less now.


Investigate import strictness and editable installs

Tracking for #1139.

https://github.com/microsoft/python-language-server/issues/1013#issuecomment-493023559 provides https://github.com/carmenbianca/vscodesrc:
+ WORKSPACE_ROOT
    + src
        + mypackage
            + __init__.py
    + tests
        + test_mypackage.py  "from mypackage import foo"

This works with extraPaths set to ["./src"], but involves the editable install issue.
This is a boiled down case of https://github.com/fsfe/reuse-tool and they work the same way:
+ WORKSPACE_ROOT
    + src
        + reuse
            + download.py
            + project.py
            + report.py  "from . import __version", "from .project import Project"
    + tests
        + test_download.py  "from reuse.download import download_license"

#1085 has:
+ WORKSPACE_ROOT
    + projectmain
        + mymodule.py
        + myproject.py  "import mymodule"

Works with ["./projectmain"], and doesn't involve editable installs.

https://github.com/microsoft/python-language-server/issues/1137#issuecomment-497011739 provides https://github.com/chudytom/LangServerError:
+ WORKSPACE_ROOT
    + .vscode
    + network
        + section_network_input.py  "from timepredictionslib.helpers.file_parser import FileParser"
    + timepredictionslib
        + build
        + dist
        + timepredictionslib
            + __init__.py
            + prediction_test_result.py
            + helpers
                + __init__.py
                + file_parser.py
        + setup.py

Which works with ["./timepredictionslib"], but similarly would be affected by the editable install issue.

https://github.com/microsoft/python-language-server/issues/1137#issuecomment-496964249 provides https://github.com/rdrey/langservtest:
+ WORKSPACE_ROOT
    + .vscode
    + langservtest
        + langservtest
            + errors
                + __init__.py
            + noerrors
                + __init__.py
            + __init__.py
            + test.py  "from langservtest.errors import Test", "from .noerror import RelativeImport"
        + setup.py

Which works with ["./langservtest"], but would be broken when installed as editable.

#989 provides https://github.com/crhan/vscode_python_error_reproduce:
+ WORKSPACE_ROOT
    + package_a
        + setup.py
        + namespaced
            + a
                + __init__.py
    + package_b
        + setup.py
        + namespaced
            + b
                + __init__.py
    + package_c
        + setup.py
        + c
            + __init__.py

    + test_file.py "from namespaced.a import func_a", "from namespaced.b import func_b", "from c import func_c"

Which works with ["./package_a", "./package_b", "./package_c"], but again would be affected with editable installs.

#1099 is an interesting case, as the C drive is getting opened, but adding extraPaths should work there as well.
#1118 should have worked with the configuration, but the screenshots show that it's been installed as editable.
#918 has a mix of things (mostly +1s and repeated comments from other threads). The original post, however, talks about actually placing user-editable packages into a virtual environment then editing them there; I think this may be out of scope because we wouldn't really be able to understand what is library code and what is not. This may be out of scope for this reason, but potentially could be improved if the underlying editable install bug is fixed.

Why doesn't vscode use my python path to give intelligent suggestions + show parameters/docs?


Send console output in the comment

We configured Jenkins to keep the 50 last builds and sometimes, when a revision makes Jenkins crash, I have the following message on my revision :

Build is unstable
Link to build: https://jenkins.ourdomain.com/job/ourjob/1244/
See console output for more information: https://jenkins.ourdomain.com/job/ourjob/1244/console

But when I click on the link (the console for example), I’m redirected to a Jenkins build that has since been deleted. Is it possible (maybe with the checkbox “Add Custom Comment”) to tell Jenkins to post the console output on Phabricator revision?
To implement this, we could either paste the full text as part of the comment (and make a checkbox option to enable this behavior) or post it as a Harbormaster artifact, like we currently do for the URL. I'm not sure what the UX would look like for the harbormaster artifact, but I know that it supports more than just URLs (for example, you could post a harbormaster artifact of a completed build JAR).
Thanks
Ben

Great point, we actually have the same issue at Uber occasionally.
There are two ways to implement this, and either would be relatively simple, but the plugin is more or less in maintenance mode right now so I wouldn't have the bandwidth to implement myself.
We could either paste the full text as part of the comment (and make a checkbox option to enable this behavior) or post it as a Harbormaster artifact, like we currently do for the URL. I'm not sure what the UX would look like for the harbormaster artifact, but I know that it supports more than just URLs (for example, you could post a harbormaster artifact of a completed build JAR).

Started by user Saurav Kumar
Running as SYSTEM
Building in workspace /var/lib/jenkins/workspace/New_Node-Server
The recommended git tool is: NONE
using credential abe316b9-f2fe-423b-b5e2-9a34d840ccaf

git rev-parse --resolve-git-dir /var/lib/jenkins/workspace/New_Node-Server/.git # timeout=10
Fetching changes from the remote Git repository
git config remote.origin.url https://git.kent.co.in/a-pandey/poc_tuya_eh.git # timeout=10
Fetching upstream changes from https://git.kent.co.in/a-pandey/poc_tuya_eh.git
git --version # timeout=10
git --version # 'git version 2.25.1'
using GIT_ASKPASS to set credentials
git fetch --tags --force --progress -- https://git.kent.co.in/a-pandey/poc_tuya_eh.git +refs/heads/:refs/remotes/origin/ # timeout=10
git rev-parse refs/remotes/origin/dev_0.0.1_notification^{commit} # timeout=10
Checking out Revision d98382c609cfff7b4d96b3d7e2496c330ade218e (refs/remotes/origin/dev_0.0.1_notification)
git config core.sparsecheckout # timeout=10
git checkout -f d98382c609cfff7b4d96b3d7e2496c330ade218e # timeout=10
Commit message: "changed error handler"
git rev-list --no-walk d98382c609cfff7b4d96b3d7e2496c330ade218e # timeout=10
[Checks API] No suitable checks publisher found.
[New_Node-Server] $ /bin/sh -xe /tmp/jenkins16815865095137068261.sh

tar -czvf new_node-server.tar.gz README.md apnsnotification config doc jest.config.js new_node-server.tar.gz package.json src test tsconfig.json tuyaEventNotification
README.md
apnsnotification/
apnsnotification/VoIP_Dev.crt.pem
apnsnotification/VoIP_Dev.key.pem
apnsnotification/apnsPushNotification.js
config/
config/config.json
doc/
doc/use.md
jest.config.js
new_node-server.tar.gz
package.json
src/
src/index.ts
src/config.ts
src/utils.ts
test/
test/client.test.js
test/const.js
test/utils.test.js
tsconfig.json
tuyaEventNotification/
tuyaEventNotification/index.js
tuyaEventNotification/Logger.js
Archiving artifacts
SSH: Connecting from host [jenkins]
SSH: Connecting with configuration [New_Node-Server] ...
SSH: EXEC: completed after 201 ms
SSH: Disconnecting configuration [New_Node-Server] ...
ERROR: Exception when publishing, exception message [Exec exit status not zero. Status [126]]
Build step 'Send build artifacts over SSH' changed build result to UNSTABLE
[Checks API] No suitable checks publisher found.
Finished: UNSTABLE

plz tell me how to resolve this issue