 Which toolchain?
Looks like it works fine with newlib 2.5, not versions before that.

this issue only happen when i enabled openamp function. if i disabled openamp function, c lib works good.@nashif

I think this might get fixed when we update OpenAMP to the new version.   See PR #11355

Hi, @galak, I have tested your branch (galak:openamp-v2018.10),  and the question still exist, i have add <stdint.h> to <stdatomic.h>, but other errors occur, our product need <math.h>, so we must enable newlib support, hope your relay.

Which c-library, how can I reproduce this?

@galak  newlib through menuconfig

@galak
example：openamp  lpc54114 board, enable libc through menuconfig.

@Jeepgoing what errors are you seeing when you do this with current tree?

@galak  there are something undefined errors from  SDK

@galak there are something undefined errors from SDK

can you post the errors you see currently, want to make sure i'm seeing the same thing.

@galak  Hi, thank you for your relay, do you have replicated this issue?

@Jeepgoing if you can add a log of the failure you are seeing to the issue that would be great.

@Jeepgoing can you put the full build log.
Also have you tried the 0.10.0-rc3 sdk?

@Jeepgoing can you put the full build log.
Also have you tried the 0.10.0-rc3 sdk?

full log as below, and i have tried 0.10.0-rc3 sdk, it is the same error.
amine@amine-VirtualBox:~/work/zephyr/zephyrproject/zephyr/samples/subsys/ipc/openamp/lpcxpresso54114$ ninja
[0/1] Re-running CMake...
Zephyr version: 1.14.0
-- Selected BOARD lpcxpresso54114_m4
-- Loading /home/amine/work/zephyr/zephyrproject/zephyr/boards/arm/lpcxpresso54114/lpcxpresso54114_m4.dts as base
-- Overlaying /home/amine/work/zephyr/zephyrproject/zephyr/dts/common/common.dts
lpcxpresso54114_m4.dts_compiled: Warning (simple_bus_reg): /soc/gpio@0: simple-bus unit address format error, expected "4008c000"
lpcxpresso54114_m4.dts_compiled: Warning (simple_bus_reg): /soc/gpio@1: simple-bus unit address format error, expected "4008c000"
Parsing Kconfig tree in /home/amine/work/zephyr/zephyrproject/zephyr/Kconfig
Loading /home/amine/work/zephyr/zephyrproject/zephyr/samples/subsys/ipc/openamp/lpcxpresso54114/zephyr/.config as base
Configuration written to '/home/amine/work/zephyr/zephyrproject/zephyr/samples/subsys/ipc/openamp/lpcxpresso54114/zephyr/.config'
-- Cache files will be written to: /home/amine/.cache/zephyr
-- Host:    Linux/x86_64
-- Target:  Generic/arm
-- Machine: cortexm
-- C_FLAGS :  -Wall -Wextra
-- Build type:  Debug
-- Host:    Linux/x86_64
-- Target:  Generic/arm
-- Machine: cortexm
Including module(s):
-- Configuring done
-- Generating done
-- Build files have been written to: /home/amine/work/zephyr/zephyrproject/zephyr/samples/subsys/ipc/openamp/lpcxpresso54114
[6/118] Building C object CMakeFiles/app.dir/src/main.c.obj
In file included from /home/amine/work/zephyr/zephyrproject/zephyr/ext/lib/ipc/open-amp/open-amp/lib/include/openamp/virtio.h:11:0,
                 from /home/amine/work/zephyr/zephyrproject/zephyr/ext/lib/ipc/open-amp/open-amp/lib/include/openamp/rpmsg_virtio.h:18,
                 from /home/amine/work/zephyr/zephyrproject/zephyr/ext/lib/ipc/open-amp/open-amp/lib/include/openamp/open_amp.h:12,
                 from ../src/main.c:18:
zephyr/ext/hal/libmetal/libmetal/lib/include/metal/spinlock.h: In function ‘metal_spinlock_acquire’:
zephyr/ext/hal/libmetal/libmetal/lib/include/metal/spinlock.h:47:34: warning: passing argument 1 of ‘atomic_flag_test_and_set’ from incompatible pointer type [-Wincompatible-pointer-types]
  while (atomic_flag_test_and_set(&slock->v)) {
                                  ^
In file included from zephyr/ext/hal/libmetal/libmetal/lib/include/metal/atomic.h:19:0,
                 from zephyr/ext/hal/libmetal/libmetal/lib/include/metal/system/zephyr/mutex.h:19,
                 from zephyr/ext/hal/libmetal/libmetal/lib/include/metal/mutex.h:22,
                 from /home/amine/work/zephyr/zephyrproject/zephyr/ext/lib/ipc/open-amp/open-amp/lib/include/openamp/rpmsg.h:16,
                 from /home/amine/work/zephyr/zephyrproject/zephyr/ext/lib/ipc/open-amp/open-amp/lib/include/openamp/open_amp.h:11,
                 from ../src/main.c:18:
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:398:1: note: expected ‘volatile atomic_flag * {aka volatile struct <anonymous> *}’ but argument is of type ‘atomic_int * {aka struct <anonymous> *}’
 atomic_flag_test_and_set(volatile atomic_flag *__object)
 ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/amine/work/zephyr/zephyrproject/zephyr/ext/lib/ipc/open-amp/open-amp/lib/include/openamp/virtio.h:11:0,
                 from /home/amine/work/zephyr/zephyrproject/zephyr/ext/lib/ipc/open-amp/open-amp/lib/include/openamp/rpmsg_virtio.h:18,
                 from /home/amine/work/zephyr/zephyrproject/zephyr/ext/lib/ipc/open-amp/open-amp/lib/include/openamp/open_amp.h:12,
                 from ../src/main.c:18:
zephyr/ext/hal/libmetal/libmetal/lib/include/metal/spinlock.h: In function ‘metal_spinlock_release’:
zephyr/ext/hal/libmetal/libmetal/lib/include/metal/spinlock.h:59:20: warning: passing argument 1 of ‘atomic_flag_clear’ from incompatible pointer type [-Wincompatible-pointer-types]
  atomic_flag_clear(&slock->v);
                    ^
In file included from zephyr/ext/hal/libmetal/libmetal/lib/include/metal/atomic.h:19:0,
                 from zephyr/ext/hal/libmetal/libmetal/lib/include/metal/system/zephyr/mutex.h:19,
                 from zephyr/ext/hal/libmetal/libmetal/lib/include/metal/mutex.h:22,
                 from /home/amine/work/zephyr/zephyrproject/zephyr/ext/lib/ipc/open-amp/open-amp/lib/include/openamp/rpmsg.h:16,
                 from /home/amine/work/zephyr/zephyrproject/zephyr/ext/lib/ipc/open-amp/open-amp/lib/include/openamp/open_amp.h:11,
                 from ../src/main.c:18:
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:406:1: note: expected ‘volatile atomic_flag * {aka volatile struct <anonymous> *}’ but argument is of type ‘atomic_int * {aka struct <anonymous> *}’
 atomic_flag_clear(volatile atomic_flag *__object)
 ^~~~~~~~~~~~~~~~~
../src/main.c: At top level:
../src/main.c:95:18: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
  .get_features = virtio_get_features,
                  ^~~~~~~~~~~~~~~~~~~
../src/main.c:95:18: note: (near initialization for ‘dispatch.get_features’)
../src/main.c:96:18: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types]
  .set_features = virtio_set_features,
                  ^~~~~~~~~~~~~~~~~~~
../src/main.c:96:18: note: (near initialization for ‘dispatch.set_features’)
../src/main.c: In function ‘ns_bind_cb’:
../src/main.c:133:4: warning: passing argument 6 of ‘rpmsg_create_ept’ from incompatible pointer type [-Wincompatible-pointer-types]
    endpoint_cb,
    ^~~~~~~~~~~
In file included from /home/amine/work/zephyr/zephyrproject/zephyr/ext/lib/ipc/open-amp/open-amp/lib/include/openamp/open_amp.h:11:0,
                 from ../src/main.c:18:
/home/amine/work/zephyr/zephyrproject/zephyr/ext/lib/ipc/open-amp/open-amp/lib/include/openamp/rpmsg.h:324:5: note: expected ‘rpmsg_ept_cb {aka int (*)(struct rpmsg_endpoint *, void *, unsigned int,  long unsigned int,  void *)}’ but argument is of type ‘int (*)(struct rpmsg_endpoint *, void *, size_t,  u32_t,  void *) {aka int (*)(struct rpmsg_endpoint *, void *, unsigned int,  unsigned int,  void *)}’
 int rpmsg_create_ept(struct rpmsg_endpoint *ept, struct rpmsg_device *rdev,
     ^~~~~~~~~~~~~~~~
../src/main.c: In function ‘app_task’:
../src/main.c:240:42: warning: passing argument 3 of ‘rpmsg_init_vdev’ from incompatible pointer type [-Wincompatible-pointer-types]
  status = rpmsg_init_vdev(&rvdev, &vdev, ns_bind_cb, io, &shpool);
                                          ^~~~~~~~~~
In file included from /home/amine/work/zephyr/zephyrproject/zephyr/ext/lib/ipc/open-amp/open-amp/lib/include/openamp/open_amp.h:12:0,
                 from ../src/main.c:18:
/home/amine/work/zephyr/zephyrproject/zephyr/ext/lib/ipc/open-amp/open-amp/lib/include/openamp/rpmsg_virtio.h:130:5: note: expected ‘rpmsg_ns_bind_cb {aka void (*)(struct rpmsg_device *, const char *, long unsigned int)}’ but argument is of type ‘void (*)(struct rpmsg_device *, const char *, u32_t) {aka void (*)(struct rpmsg_device *, const char *, unsigned int)}’
 int rpmsg_init_vdev(struct rpmsg_virtio_device *rvdev,
     ^~~~~~~~~~~~~~~
[56/118] Building C object zephyr/ext/lib/ipc/open-amp/open-amp/lib/CMakeFiles/open_amp.dir/virtio/virtio.c.obj
In file included from ../../../../../ext/lib/ipc/open-amp/open-amp/lib/include/openamp/virtio.h:11:0,
                 from /home/amine/work/zephyr/zephyrproject/zephyr/ext/lib/ipc/open-amp/open-amp/lib/virtio/virtio.c:7:
zephyr/ext/hal/libmetal/libmetal/lib/include/metal/spinlock.h: In function ‘metal_spinlock_acquire’:
zephyr/ext/hal/libmetal/libmetal/lib/include/metal/spinlock.h:47:34: warning: passing argument 1 of ‘atomic_flag_test_and_set’ from incompatible pointer type [-Wincompatible-pointer-types]
  while (atomic_flag_test_and_set(&slock->v)) {
                                  ^
In file included from zephyr/ext/hal/libmetal/libmetal/lib/include/metal/atomic.h:19:0,
                 from zephyr/ext/hal/libmetal/libmetal/lib/include/metal/io.h:21,
                 from ../../../../../ext/lib/ipc/open-amp/open-amp/lib/include/openamp/virtqueue.h:24,
                 from ../../../../../ext/lib/ipc/open-amp/open-amp/lib/include/openamp/virtio.h:10,
                 from /home/amine/work/zephyr/zephyrproject/zephyr/ext/lib/ipc/open-amp/open-amp/lib/virtio/virtio.c:7:
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:398:1: note: expected ‘volatile atomic_flag * {aka volatile struct <anonymous> *}’ but argument is of type ‘atomic_int * {aka struct <anonymous> *}’
 atomic_flag_test_and_set(volatile atomic_flag *__object)
 ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../../../../ext/lib/ipc/open-amp/open-amp/lib/include/openamp/virtio.h:11:0,
                 from /home/amine/work/zephyr/zephyrproject/zephyr/ext/lib/ipc/open-amp/open-amp/lib/virtio/virtio.c:7:
zephyr/ext/hal/libmetal/libmetal/lib/include/metal/spinlock.h: In function ‘metal_spinlock_release’:
zephyr/ext/hal/libmetal/libmetal/lib/include/metal/spinlock.h:59:20: warning: passing argument 1 of ‘atomic_flag_clear’ from incompatible pointer type [-Wincompatible-pointer-types]
  atomic_flag_clear(&slock->v);
                    ^
In file included from zephyr/ext/hal/libmetal/libmetal/lib/include/metal/atomic.h:19:0,
                 from zephyr/ext/hal/libmetal/libmetal/lib/include/metal/io.h:21,
                 from ../../../../../ext/lib/ipc/open-amp/open-amp/lib/include/openamp/virtqueue.h:24,
                 from ../../../../../ext/lib/ipc/open-amp/open-amp/lib/include/openamp/virtio.h:10,
                 from /home/amine/work/zephyr/zephyrproject/zephyr/ext/lib/ipc/open-amp/open-amp/lib/virtio/virtio.c:7:
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:406:1: note: expected ‘volatile atomic_flag * {aka volatile struct <anonymous> *}’ but argument is of type ‘atomic_int * {aka struct <anonymous> *}’
 atomic_flag_clear(volatile atomic_flag *__object)
 ^~~~~~~~~~~~~~~~~
[60/118] Building C object zephyr/ext/lib/ipc/open-amp/open-amp/lib/CMakeFiles/open_amp.dir/rpmsg/rpmsg.c.obj
FAILED: zephyr/ext/lib/ipc/open-amp/open-amp/lib/CMakeFiles/open_amp.dir/rpmsg/rpmsg.c.obj
ccache /opt/zephyr-sdk/sysroots/x86_64-pokysdk-linux/usr/bin/arm-zephyr-eabi/arm-zephyr-eabi-gcc -DBUILD_VERSION=v1.14.0-rc1-348-gcda3fad5c8 -DCPU_LPC54114J256BD64_cm4 -DKERNEL -D_FORTIFY_SOURCE=2 -D__LINUX_ERRNO_EXTENSIONS__ -D__ZEPHYR__=1 -I../../../../../ext/lib/ipc/open-amp/open-amp/lib/include -I../../../../../kernel/include -I../../../../../arch/arm/include -I../../../../../include -I../../../../../include/drivers -Izephyr/include/generated -I../../../../../soc/arm/nxp_lpc/lpc54xxx -I/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include -I../../../../../ext/hal/cmsis/Include -Izephyr/ext/hal/libmetal/libmetal/lib/include -I../../../../../ext/hal/nxp/mcux/devices/LPC54114 -I../../../../../ext/hal/nxp/mcux/drivers/lpc/. -isystem /opt/zephyr-sdk/sysroots/x86_64-pokysdk-linux/usr/lib/arm-zephyr-eabi/gcc/arm-zephyr-eabi/6.2.0/include -isystem /opt/zephyr-sdk/sysroots/x86_64-pokysdk-linux/usr/lib/arm-zephyr-eabi/gcc/arm-zephyr-eabi/6.2.0/include-fixed -Wall -Wextra -g   -Os -g -Wall -Wformat -Wformat-security -Wno-format-zero-length -imacros /home/amine/work/zephyr/zephyrproject/zephyr/samples/subsys/ipc/openamp/lpcxpresso54114/zephyr/include/generated/autoconf.h -ffreestanding -Wno-main -fno-common --sysroot /opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr -mthumb -mcpu=cortex-m4 -fno-asynchronous-unwind-tables -fno-pie -fno-pic -fno-strict-overflow -Wno-pointer-sign -Wno-unused-but-set-variable -fno-reorder-functions -fno-defer-pop -Werror=implicit-int -Wpointer-arith -ffunction-sections -fdata-sections -mabi=aapcs -march=armv7e-m -std=c99 -MD -MT zephyr/ext/lib/ipc/open-amp/open-amp/lib/CMakeFiles/open_amp.dir/rpmsg/rpmsg.c.obj -MF zephyr/ext/lib/ipc/open-amp/open-amp/lib/CMakeFiles/open_amp.dir/rpmsg/rpmsg.c.obj.d -o zephyr/ext/lib/ipc/open-amp/open-amp/lib/CMakeFiles/open_amp.dir/rpmsg/rpmsg.c.obj   -c /home/amine/work/zephyr/zephyrproject/zephyr/ext/lib/ipc/open-amp/open-amp/lib/rpmsg/rpmsg.c
In file included from /opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:33:0,
                 from zephyr/ext/hal/libmetal/libmetal/lib/include/metal/atomic.h:19,
                 from zephyr/ext/hal/libmetal/libmetal/lib/include/metal/system/zephyr/mutex.h:19,
                 from zephyr/ext/hal/libmetal/libmetal/lib/include/metal/mutex.h:22,
                 from ../../../../../ext/lib/ipc/open-amp/open-amp/lib/include/openamp/rpmsg.h:16,
                 from /home/amine/work/zephyr/zephyrproject/zephyr/ext/lib/ipc/open-amp/open-amp/lib/rpmsg/rpmsg.c:10:
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:204:17: error: expected specifier-qualifier-list before ‘int_least8_t’
 typedef _Atomic(int_least8_t)  atomic_int_least8_t;
                 ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/sys/cdefs.h:303:30: note: in definition of macro ‘_Atomic’
 #define _Atomic(T)  struct { T volatile __val; }
                              ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:205:17: error: expected specifier-qualifier-list before ‘uint_least8_t’
 typedef _Atomic(uint_least8_t)  atomic_uint_least8_t;
                 ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/sys/cdefs.h:303:30: note: in definition of macro ‘_Atomic’
 #define _Atomic(T)  struct { T volatile __val; }
                              ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:206:17: error: expected specifier-qualifier-list before ‘int_least16_t’
 typedef _Atomic(int_least16_t)  atomic_int_least16_t;
                 ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/sys/cdefs.h:303:30: note: in definition of macro ‘_Atomic’
 #define _Atomic(T)  struct { T volatile __val; }
                              ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:207:17: error: expected specifier-qualifier-list before ‘uint_least16_t’
 typedef _Atomic(uint_least16_t)  atomic_uint_least16_t;
                 ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/sys/cdefs.h:303:30: note: in definition of macro ‘_Atomic’
 #define _Atomic(T)  struct { T volatile __val; }
                              ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:208:17: error: expected specifier-qualifier-list before ‘int_least32_t’
 typedef _Atomic(int_least32_t)  atomic_int_least32_t;
                 ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/sys/cdefs.h:303:30: note: in definition of macro ‘_Atomic’
 #define _Atomic(T)  struct { T volatile __val; }
                              ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:209:17: error: expected specifier-qualifier-list before ‘uint_least32_t’
 typedef _Atomic(uint_least32_t)  atomic_uint_least32_t;
                 ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/sys/cdefs.h:303:30: note: in definition of macro ‘_Atomic’
 #define _Atomic(T)  struct { T volatile __val; }
                              ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:210:17: error: expected specifier-qualifier-list before ‘int_least64_t’
 typedef _Atomic(int_least64_t)  atomic_int_least64_t;
                 ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/sys/cdefs.h:303:30: note: in definition of macro ‘_Atomic’
 #define _Atomic(T)  struct { T volatile __val; }
                              ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:211:17: error: expected specifier-qualifier-list before ‘uint_least64_t’
 typedef _Atomic(uint_least64_t)  atomic_uint_least64_t;
                 ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/sys/cdefs.h:303:30: note: in definition of macro ‘_Atomic’
 #define _Atomic(T)  struct { T volatile __val; }
                              ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:212:17: error: expected specifier-qualifier-list before ‘int_fast8_t’
 typedef _Atomic(int_fast8_t)  atomic_int_fast8_t;
                 ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/sys/cdefs.h:303:30: note: in definition of macro ‘_Atomic’
 #define _Atomic(T)  struct { T volatile __val; }
                              ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:213:17: error: expected specifier-qualifier-list before ‘uint_fast8_t’
 typedef _Atomic(uint_fast8_t)  atomic_uint_fast8_t;
                 ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/sys/cdefs.h:303:30: note: in definition of macro ‘_Atomic’
 #define _Atomic(T)  struct { T volatile __val; }
                              ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:214:17: error: expected specifier-qualifier-list before ‘int_fast16_t’
 typedef _Atomic(int_fast16_t)  atomic_int_fast16_t;
                 ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/sys/cdefs.h:303:30: note: in definition of macro ‘_Atomic’
 #define _Atomic(T)  struct { T volatile __val; }
                              ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:215:17: error: expected specifier-qualifier-list before ‘uint_fast16_t’
 typedef _Atomic(uint_fast16_t)  atomic_uint_fast16_t;
                 ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/sys/cdefs.h:303:30: note: in definition of macro ‘_Atomic’
 #define _Atomic(T)  struct { T volatile __val; }
                              ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:216:17: error: expected specifier-qualifier-list before ‘int_fast32_t’
 typedef _Atomic(int_fast32_t)  atomic_int_fast32_t;
                 ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/sys/cdefs.h:303:30: note: in definition of macro ‘_Atomic’
 #define _Atomic(T)  struct { T volatile __val; }
                              ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:217:17: error: expected specifier-qualifier-list before ‘uint_fast32_t’
 typedef _Atomic(uint_fast32_t)  atomic_uint_fast32_t;
                 ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/sys/cdefs.h:303:30: note: in definition of macro ‘_Atomic’
 #define _Atomic(T)  struct { T volatile __val; }
                              ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:218:17: error: expected specifier-qualifier-list before ‘int_fast64_t’
 typedef _Atomic(int_fast64_t)  atomic_int_fast64_t;
                 ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/sys/cdefs.h:303:30: note: in definition of macro ‘_Atomic’
 #define _Atomic(T)  struct { T volatile __val; }
                              ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:219:17: error: expected specifier-qualifier-list before ‘uint_fast64_t’
 typedef _Atomic(uint_fast64_t)  atomic_uint_fast64_t;
                 ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/sys/cdefs.h:303:30: note: in definition of macro ‘_Atomic’
 #define _Atomic(T)  struct { T volatile __val; }
                              ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:220:17: error: expected specifier-qualifier-list before ‘intptr_t’
 typedef _Atomic(intptr_t)  atomic_intptr_t;
                 ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/sys/cdefs.h:303:30: note: in definition of macro ‘_Atomic’
 #define _Atomic(T)  struct { T volatile __val; }
                              ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:221:17: error: expected specifier-qualifier-list before ‘uintptr_t’
 typedef _Atomic(uintptr_t)  atomic_uintptr_t;
                 ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/sys/cdefs.h:303:30: note: in definition of macro ‘_Atomic’
 #define _Atomic(T)  struct { T volatile __val; }
                              ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:224:17: error: expected specifier-qualifier-list before ‘intmax_t’
 typedef _Atomic(intmax_t)  atomic_intmax_t;
                 ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/sys/cdefs.h:303:30: note: in definition of macro ‘_Atomic’
 #define _Atomic(T)  struct { T volatile __val; }
                              ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:225:17: error: expected specifier-qualifier-list before ‘uintmax_t’
 typedef _Atomic(uintmax_t)  atomic_uintmax_t;
                 ^
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/sys/cdefs.h:303:30: note: in definition of macro ‘_Atomic’
 #define _Atomic(T)  struct { T volatile __val; }
                              ^
[61/118] Building C object zephyr/ext/lib/ipc/open-amp/open-amp/lib/CMakeFiles/open_amp.dir/rpmsg/rpmsg_virtio.c.obj
In file included from ../../../../../ext/lib/ipc/open-amp/open-amp/lib/include/openamp/virtio.h:11:0,
                 from ../../../../../ext/lib/ipc/open-amp/open-amp/lib/include/openamp/rpmsg_virtio.h:18,
                 from /home/amine/work/zephyr/zephyrproject/zephyr/ext/lib/ipc/open-amp/open-amp/lib/rpmsg/rpmsg_virtio.c:14:
zephyr/ext/hal/libmetal/libmetal/lib/include/metal/spinlock.h: In function ‘metal_spinlock_acquire’:
zephyr/ext/hal/libmetal/libmetal/lib/include/metal/spinlock.h:47:34: warning: passing argument 1 of ‘atomic_flag_test_and_set’ from incompatible pointer type [-Wincompatible-pointer-types]
  while (atomic_flag_test_and_set(&slock->v)) {
                                  ^
In file included from zephyr/ext/hal/libmetal/libmetal/lib/include/metal/atomic.h:19:0,
                 from zephyr/ext/hal/libmetal/libmetal/lib/include/metal/io.h:21,
                 from ../../../../../ext/lib/ipc/open-amp/open-amp/lib/include/openamp/rpmsg_virtio.h:15,
                 from /home/amine/work/zephyr/zephyrproject/zephyr/ext/lib/ipc/open-amp/open-amp/lib/rpmsg/rpmsg_virtio.c:14:
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:398:1: note: expected ‘volatile atomic_flag * {aka volatile struct <anonymous> *}’ but argument is of type ‘atomic_int * {aka struct <anonymous> *}’
 atomic_flag_test_and_set(volatile atomic_flag *__object)
 ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../../../../ext/lib/ipc/open-amp/open-amp/lib/include/openamp/virtio.h:11:0,
                 from ../../../../../ext/lib/ipc/open-amp/open-amp/lib/include/openamp/rpmsg_virtio.h:18,
                 from /home/amine/work/zephyr/zephyrproject/zephyr/ext/lib/ipc/open-amp/open-amp/lib/rpmsg/rpmsg_virtio.c:14:
zephyr/ext/hal/libmetal/libmetal/lib/include/metal/spinlock.h: In function ‘metal_spinlock_release’:
zephyr/ext/hal/libmetal/libmetal/lib/include/metal/spinlock.h:59:20: warning: passing argument 1 of ‘atomic_flag_clear’ from incompatible pointer type [-Wincompatible-pointer-types]
  atomic_flag_clear(&slock->v);
                    ^
In file included from zephyr/ext/hal/libmetal/libmetal/lib/include/metal/atomic.h:19:0,
                 from zephyr/ext/hal/libmetal/libmetal/lib/include/metal/io.h:21,
                 from ../../../../../ext/lib/ipc/open-amp/open-amp/lib/include/openamp/rpmsg_virtio.h:15,
                 from /home/amine/work/zephyr/zephyrproject/zephyr/ext/lib/ipc/open-amp/open-amp/lib/rpmsg/rpmsg_virtio.c:14:
/opt/zephyr-sdk/sysroots/armv5-zephyr-eabi/usr/include/stdatomic.h:406:1: note: expected ‘volatile atomic_flag * {aka volatile struct <anonymous> *}’ but argument is of type ‘atomic_int * {aka struct <anonymous> *}’
 atomic_flag_clear(volatile atomic_flag *__object)
 ^~~~~~~~~~~~~~~~~
ninja: build stopped: subcommand failed.
amine@amine-VirtualBox:~/work/zephyr/zephyrproject/zephyr/samples/subsys/ipc/openamp/lpcxpresso54114$

Please see libmetal patches: https://github.com/OpenAMP/libmetal/pull/85

@Jeepgoing should hopefully now be fixed with PR #14203.


A spinner is a conjunction of a single-line textbox and 2 buttons

All of which InForm already has.

This might be only going to accept numbers, right?

Yup. It'll be the existing NumericTextBox with two tiny buttons for the spinning action. Likely for beta 9 too.


Fix name clashing of terminal and non-terminal rules

Closes #294.

@Pluralia For the tests, you can reuse this code, which I wrote for another PR:
https://github.com/langium/langium/blob/81b0aff271609707f411aed2e466aea5a3189598/packages/langium/test/parser/langium-parser-builder.test.ts#L76-L95


Check In and Check Out custom time for highlighting days

Hi Airbnb Team,
This is my second time asking question.

Is it possible specify time ie. hours for check in and out highlighting as in screenshot.

Can I make bigger in size for check in guest images? Similar in screenshot! Overall is it even achievable as design in airbnb calendar?

Thank you for your time!

Hi @bekzodrakhmatof!
Your design looks possible to build with HorizonCalendar 🙂
For the guest image view, use a custom view (with an image view + corner radius + border) and return it from CalendarViewContent(...).withDayItemModelProvider
See https://github.com/airbnb/HorizonCalendar#providing-a-custom-view-for-each-day for more details.

For the highlight, use a custom day range indicator. Day range indicators are views that are behind multiple days. You will need to make a custom view to draw the highlight, then return it from CalendarViewContent(...).withDayRangeItemModelProvider.
See https://github.com/airbnb/HorizonCalendar#adding-a-day-range-indicator for more details.

You may also look in the example app. The "Day Range Selection" demo is close to your design:

Hi @bekzodrakhmatof!
Your design looks possible to build with HorizonCalendar 🙂
For the guest image view, use a custom view (with an image view + corner radius + border) and return it from CalendarViewContent(...).withDayItemModelProvider
See https://github.com/airbnb/HorizonCalendar#providing-a-custom-view-for-each-day for more details.

For the highlight, use a custom day range indicator. Day range indicators are views that are behind multiple days. You will need to make a custom view to draw the highlight, then return it from CalendarViewContent(...).withDayRangeItemModelProvider.
See https://github.com/airbnb/HorizonCalendar#adding-a-day-range-indicator for more details.

You may also look in the example app. The "Day Range Selection" demo is close to your design:

Thank you for the answer. I will be playing around with this and close this issue!

Thank you for the answer. I will be playing around with this and close this issue!

Hi @bryankeller
I have been able to set custom images to days but I am still struggling for applying custom check out time. Do you have any example for that case? If not it's okay I will try to dig more into it.

Thank you!

My understanding is that the custom check out time is really a day range indicator that draws its end rounded cap inset from the edge of the last day in the range.
Have you looked at the day range indicator in the example project? The design is very similar, but you will need to modify the drawing code to draw the end of the day range indicator a few pixels before the last day frame.

Can you tell me exactly which code is setting checkin and out day range indicator?
I am having a bit difficulties working with day range indicators.
Thank you!

If this is the desired effect, change the implementation of DayRangeIndicatorView.swift to this:
// Created by Bryan Keller on 6/7/20.
// Copyright © 2020 Airbnb Inc. All rights reserved.

// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

import HorizonCalendar
import UIKit

// MARK: - DayRangeIndicatorView

final class DayRangeIndicatorView: UIView {

  // MARK: Lifecycle

  init(indicatorColor: UIColor) {
    self.indicatorColor = indicatorColor

    super.init(frame: .zero)

    backgroundColor = .clear
  }

  required init?(coder: NSCoder) {
    fatalError("init(coder:) has not been implemented")
  }

  // MARK: Internal

  var framesOfDaysToHighlight = [CGRect]() {
    didSet {
      guard framesOfDaysToHighlight != oldValue else { return }
      setNeedsDisplay()
    }
  }

  var isLastDayHalfFilled = false {
    didSet {
      guard isLastDayHalfFilled != oldValue else { return }
      setNeedsDisplay()
    }
  }

  override func draw(_ rect: CGRect) {
    let context = UIGraphicsGetCurrentContext()
    context?.setFillColor(indicatorColor.cgColor)

    if traitCollection.layoutDirection == .rightToLeft {
      transform = .init(scaleX: -1, y: 1)
    } else {
      transform = .identity
    }

    // Get frames of day rows in the range
    var dayRowFrames = [CGRect]()
    var currentDayRowMinY: CGFloat?
    for proposedDayFrame in framesOfDaysToHighlight {
      let dayFrame: CGRect
      if isLastDayHalfFilled && proposedDayFrame == framesOfDaysToHighlight.last {
        dayFrame = CGRect(
          x: proposedDayFrame.origin.x,
          y: proposedDayFrame.origin.y,
          width: proposedDayFrame.width * 0.5, // Shrink frame width by 1/2
          height: proposedDayFrame.height)
      } else {
        dayFrame = proposedDayFrame
      }

      if dayFrame.minY != currentDayRowMinY {
        currentDayRowMinY = dayFrame.minY
        dayRowFrames.append(dayFrame)
      } else {
        let lastIndex = dayRowFrames.count - 1
        dayRowFrames[lastIndex] = dayRowFrames[lastIndex].union(dayFrame)
      }
    }

    // Draw rounded rectangles for each day row
    for dayRowFrame in dayRowFrames {
      let cornerRadius = dayRowFrame.height / 2
      let roundedRectanglePath = UIBezierPath(roundedRect: dayRowFrame, cornerRadius: cornerRadius)
      context?.addPath(roundedRectanglePath.cgPath)
      context?.fillPath()
    }
  }

  // MARK: Private

  private let indicatorColor: UIColor

}

// MARK: CalendarItemViewRepresentable

extension DayRangeIndicatorView: CalendarItemViewRepresentable {

  struct InvariantViewProperties: Hashable {
    var indicatorColor = UIColor.blue.withAlphaComponent(0.15)
  }

  struct ViewModel: Equatable {
    let framesOfDaysToHighlight: [CGRect]
    let isLastDayHalfFilled: Bool
  }

  static func makeView(
    withInvariantViewProperties invariantViewProperties: InvariantViewProperties)
    -> DayRangeIndicatorView
  {
    DayRangeIndicatorView(indicatorColor: invariantViewProperties.indicatorColor)
  }

  static func setViewModel(_ viewModel: ViewModel, on view: DayRangeIndicatorView) {
    view.framesOfDaysToHighlight = viewModel.framesOfDaysToHighlight
    view.isLastDayHalfFilled = viewModel.isLastDayHalfFilled
  }

}

Then, in DayRangeSelectionDemoViewController.swift, change the day range item model provider to look like this:
.withDayRangeItemModelProvider(for: dateRanges) { dayRangeLayoutContext in
        CalendarItemModel<DayRangeIndicatorView>(
          invariantViewProperties: .init(),
          viewModel: .init(
            framesOfDaysToHighlight: dayRangeLayoutContext.daysAndFrames.map { $0.frame },
            isLastDayHalfFilled: true))
      }

The day range item model provider will be called for each date range in the dateRanges array you pass in. The demo project creates this date range for the current check in / check out date. You can pass in many date ranges if you want, and each one will receive a date range indicator view.
The README explains this in more detail https://github.com/airbnb/HorizonCalendar#adding-a-day-range-indicator

Thank you very much!

@bekzodrakhmatof were you able to make progress implementing your designs? I'm hoping the code I posted gives enough information about how this can be implemented.

Hi @bryankeller,
Yeah I made my design as I wanted. I really appreciate your help.

I replaced day label with button and give background image for the button or title.
I had 2 border colors so I gave one to button and one to cell so I was able to make it look transparent.
To make the checkin day bigger I shrieked with y position day indicators for other days so I get this result.
Overall I get my result,
Thank you!


SimpleFCMClient works but topic notif doesnt work on fground in iOS

Hi
I have just downloaded, modified and compiled the simple-fcm-client.
Remote notifications with token works ok, but topic is received and ignored while in foreground. It shows up in the console.
Testing on iPhone 4S, iOS 9.3
Is this a common problem?

Have you tested with iOS >= 10?
what do you mean  ignored while in foreground?

I have started from scratch and now it works.
My problem was that the console.log showed in React Native Debugger the notification, but app doesn't come up foreground.
Now I started testing on top of SimpleFCMCliente and it works. Don't know what the problem was on my original app.
Thanks for responding.


Write a Java program to find volume of a sphere

Description
Write a Java program to find volume of a sphere
Volume of sphere = 4/3 × π × Radius^3
Radius : 2

Volume : 33.510321638291124

How to contribute

Save the solution in FindVolumeOfASphere.java file
Add FindVolumeOfASphere.java file in find-volume-of-a-sphere folder

!assign


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v5.15 to before v5.16.8",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=514aee660df493cd673154a6ba6bab745ec47b8c",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=fa3b844a50845c817660146c27c0fc29b08d3116"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "514aee660df493cd673154a6ba6bab745ec47b8c",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "fa3b844a50845c817660146c27c0fc29b08d3116",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "RDMA/siw: Fix refcounting leak in siw_create_qp()\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.16.8 by commit fa3b844a50845c817660146c27c0fc29b08d3116, it was introduced in version v5.15 by commit 514aee660df493cd673154a6ba6bab745ec47b8c. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2022-1000668


design Sliders

fraction widget

Progress bar
slider

fraction bar widget

scroll bar
scroll indicator

Renaming done. Slider widget is missing.

Implement Slider widget

ScrollBar can be used as Slider


Adds bola and a crafting recipe for them.

About the PR
This adds bola to the game.  In SS13 they're used as ranged legcuffs.  Right now, I personally can't figure out how to add that system into SS14 so instead I gave them a knockdown like how reinforced bola would have in SS13.  I wasn't sure what I needed to put for copyright information in the sprite file, so if anyone could help me with that I can get that fixed.
There was also a tweak I made to StunOnCollide to also apply to thrown items that have the attribute, with help from some people on the discord.
Screenshots

Changelog

:cl:

add: Added bolas, which includes the sprite, sound on throw/land, and crafting recipe.
tweak: Tweaked StunOnCollide system to allow for stun/knockdown on thrown items that have the attribute
fix: Also fixes the ability for stun baton to work when thrown.

Where would I find this?  I'm not sure where to look in the .dmm for that kind of information.

On mobile but for your meta.json for textures make sure it's the same attribution as our other texture files "CC-BY-SA-3.0", (2.0 or 3.0) just copy how it is in another file but make sure it's the correct version as it states on the repo you took it from).
And for the commit, head to the repo you took it from all the way to the .dmm file you exported it from and copy link the commit hash and paste that in the description with "taken from codebaseX at [commit hash]" as it is in the other files.

Where would I find these? I'm not sure where to look in the .dmm for that kind of information.

On mobile but for your meta.json for textures make sure it's the same attribution as our other texture files "CC-BY-SA-3.0", (2.0 or 3.0) just copy how it is in another file but make sure it's the correct version as it states on the repo you took it from).

And for the commit, head to the repo you took it from all the way to the .dmm file you exported it from and copy link the commit hash and paste that in the description with "taken from codebaseX at [commit hash]" as it is in the other files.

Where would I find these? I'm not sure where to look in the .dmm for that kind of information.

The license will be on the main readme page for the whole codebase you took it from. What codebase is it?
The commit is on the page you view the .dmm on GitHub not in the dmm. If you click one in another meta file it will take you to where it will be. If you want to send a link I can show you.

Tests passing and yaml lgtm.
Out of curiosity is the recipe cuffs + steel? Just the description mentions cable so wondering if that's as intended or if it should require less steel but + tiny amount of cable. Up to you how you balance it, if it's fine as is then cool.
Good work.

Tests passing and yaml lgtm.
Out of curiosity is the recipe cuffs + steel? Just the description mentions cable so wondering if that's as intended or if it should require less steel but + tiny amount of cable. Up to you how you balance it, if it's fine as is then cool.
Good work.

Thanks!  I was trying to mimic what it is on SS13 where you need cablecuffs and 6 metal.  I forgot who but someone pointed me to the pneumatic cannon and said to use it as an example.  IIRC someone else said that even though cablecuffs are pictured on pneumatic, you could just use regular cuffs just fine.  I could change the description if need be.

changelog should be exclusively player-facing


Don't display a period at the end of mouse/joypad actions in the editor

This matches how input actions display in master.
This will likely have to wait for 3.5 to be merged to avoid breaking existing translations.
Preview
Before

After

This will likely have to wait for 3.5 to be merged to avoid breaking existing translations.

Welp, now it's the same dilemma with 3.5 being basically in translation freeze. At this stage it's probably no longer useful to merge this for 3.x.


Docker Integration

Provided Docker script that allows the (parallel) execution of several build tasks within a Docker container.
VOTE: +1

any reason this can't be targetted at tp31 and merged forward to master?

actually based on the CHANGELOG contents and git tree, it looks like it should be targeted at tp31 and not master, no?

Doh, always the same thing. I will create a new PR targeting tp31 (and you're right about the typo in the docs, I will fix that as well).


Not able to send messages on Ubuntu 23.04, after reboot old messages are remarked as unread

I'm  not able to send messages on Ubuntu 23.04, after reboot old messages are remarked as unread even if they have already been read on the mobile phone.
Ubuntu 23.04, Whatssie <IP_ADDRESS>6ca7e
Here is the debug info:
Version: 4.14
Source Branch: main
Commit Hash: 906ca7e
Build Datetime: 2023-05-20T15:56:15UTC
Qt Runtime Version: 5.15.4
Qt Compiled Version: 5.15.4
System: Ubuntu Core 20
Architecture: x86_64
Install mode: snap

I though that qtwebengine on my system has gone broken.
But looks like it's a more common problem.

Hi to everyone, I quote @proofy. Needs to update API. WhatSie is not correctly working.
Thank you.

For now the solution is to force logout by cleaning the persistent data from settings.

Hi all,
I have the same problem. Cleaning the persistent data helps only for a short time.
Thanks!

I think I got hit by the same issue. Cannot send messages, and can only receive them on startup or by forcing 'reload'. Nothing fixes the inability to send messages. This started two days go for me.

Hi all, I have the same problem. Cleaning the persistent data helps only for a short time.
Thanks!

Yes, I cleanup persistent data, but he problem occurs again.
same issue that https://github.com/keshavbhatt/whatsie/issues/145

Because of the issue, I used the webapp now. But after some weeks, I started WhatSie and it works without cleaning up, but also only for some days

Issue still exists. I cleared the data, but just a few days later the issue happened again.
This makes WhatSie pretty much unusable for me.

Please verify this with new version 4.15 of Whatsie released today and re-open the ticket again if the problem still persists.
Thanks


Initial /prices page implementation

What kind of PR is this?:

/kind feature
What this PR does / why we need it:
Added initial /prices page implementation.

They are not optimized for responsive view yet.
Oracles copy information missing atm, need to fill them up and implement.
Prices copy information is missing, need to fill them up.

Which issue(s) does this PR fixes?:

Fixes part of #72

Codecov Report

Merging #121 (d10f503) into main (a7806e8) will increase coverage by 0.30%.
The diff coverage is 95.65%.

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   82.70%   83.00%   +0.30%
==========================================
  Files          15       17       +2
  Lines         185      206      +21
  Branches       32       40       +8
==========================================
+ Hits          153      171      +18
- Misses         32       35       +3

Impacted Files
Coverage Δ

src/pages/prices/index.tsx
80.00% <80.00%> (ø)

src/cms/prices/index.ts
100.00% <100.00%> (ø)

src/components/prices/PriceFeed.tsx
100.00% <100.00%> (ø)

src/pages/_app.tsx
60.00% <0.00%> (-40.00%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7806e8...d10f503. Read the comment docs.


对代理页面增加url的展示

https://github.com/alibaba/lightproxy/issues/227 一键复制到剪贴板的操作在这个页面

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update MapLibre GL JS

I would like to update the MapLibre GL JS submodule to the latest 1.x version. This will probably affect the shaders and the style spec.

Relevant files could be:
scripts/generate-shaders.js

This commit from @petr-pokorny-1 could be relevant: https://github.com/maplibre/maplibre-gl-native/commit/672f2d86556a10c7f086c1f2ab577969dfd511e4

https://github.com/maplibre/maplibre-gl-native/pull/6/files shows some things from GL JS which are used in native...

Lot's of testing stuff seems shared, @HarelM

#339

The commit hashes in the src/shaders folder before typescript are
eeefc070d7333b21b205be3882df9b2e3cd444d1
d8cf29023392b7de85b365cdc17e50ae263a357c
e27049d87be346a4f67ef6956a5113d977de63d8
aa6b4b2e51ac19156ba1537baf32a63551313612
58a73906d6f467762e486fcddf0643b27193ba89
842ea2e08f57dbc4c70537dc9988512439d05f9d
12991995fa1bb62c5ecdb0282c7c142578b897e5

I would like to run the update-gl-js.yml action on those and see at what point stuff breaks...

Can you also confirm that the same set of tests is ignored in JS than in native?

In native, depending on the platform different tests are ignored. For a full list, see https://github.com/maplibre/maplibre-gl-native/tree/main/metrics/ignores
In GL JS, we might actually run all the render tests. See https://github.com/maplibre/maplibre-gl-js/blob/main/test/integration/render/render.test.ts ...

@HarelM How do we handle ignored tests again in GL JS? I remember there was some discussion about removing ignored tests...

eeefc070d7333b21b205be3882df9b2e3cd444d1 is in #360

d8cf29023392b7de85b365cdc17e50ae263a357c is in #361

e27049d87be346a4f67ef6956a5113d977de63d8 is in #362

We removed ignored tests.

This seems like a difficult but important ticket. I assigned myself because I am going to spend some time looking into this, but don't let that hold anyone back working on this or assigning themselves as well.

Is this still only trying to get MapLibre GL JS to lastest in the 1.X branch and not the current main 2.x/3.x release? If it was going to 2.x I also wanted to note the path to tests seems to have changed. If it is just to 1.X this is not an issue (yet)
For example, in a linux build you can run tests with
xvfb-run -a ./build/mbgl-render-test-runner --manifestPath metrics/macos-xcode11-release-style.json
and it uses a bunch of tests from
maplibre-gl-js\test\integration\render-tests
But in the current main branch of maplibre-gl-js that path has moved to
`maplibre-gl-js\test\integration\render\tests
https://github.com/maplibre/maplibre-gl-js/tree/main/test/integration/render/tests
I know there was also some discussion of moving these tests into this project...so maybe this would be fixed by doing that.

The biggest issue is that we've observed breakage of tests when trying to update the version even in the 1.X branch. See some of the old open MRs.

The strategy should probably be to update the GL JS submodule commit by commit and make sure everything works every time. So you would first go from Mapbox v1.x in March 2020 (where it is now) to something near December 2020 (time or fork). This period has some new features in GL JS from Mapbox but not so many. Then you would follow MapLibre v1 until something like August 2021 (TypeScript and v2). This period has almost no new features from MapLibre. And finally, you would follow MapLibre v2 until today. This time period also has very few new features.
So the good news is that there is some work to be done around tooling, but the style spec did not change much since March 2020 and so there is not that crazy much work to be done feature-wise...

git rev-list HEAD^..$(git rev-list -n 1 "v1.14.0") | wc -l
189

189 commits until v1.14.0

Note that the workflow does not run
platform/android/scripts/generate-style-code.js
platform/android/scripts/generate-test-code.js

https://github.com/maplibre/maplibre-gl-native/blob/main/.github/workflows/update-gl-js.yml

Change of plans.


Swipe back will crash/freeze navigation (IOS, add to HomeScreen App)

Hi,
On iPhone i created a Homescreen App (through safari) of the standard demo (under /dist).
Fire the app up.
Click Service, the About page, and than add a Dynamic Page.
Swipe 3 times to get to the home/start screen and than all navigation will not work. None of the buttons will work.
Except the open sidebar icon top right.
Usually it takes 3 swipe back to freeze navigation, whatever the amount of pages you visited (create dynamic page .)
ps: i think that the behavior works like this if you swipe fast. If you swipe slower it might not freeze.

Hi,
Can't replicate this issue. What is your device and OS version?

iPhone 6, IOS 8.4 (not 8.4.1)
i can replicate it every single time
just swipe fast back, like you would with any app.
as homescreen app as well as in Safari
I will test it on an older iphone with outdate ios too and let you know
these are my setting in the my-app.js:
var myApp = new Framework7({
pushState: true,
cache: false,
swipeBackPageAnimateOpacity: false,
swipeBackPageAnimateShadow: false,
swipeBackPageActiveArea: 100,
// swipeBackPageThreshold: 100,
swipeBackPage: true
// swipePanel: 'left'
});
tried everything related to swiping.
And AnmateOpacity, does not seem to work, the 'previous' page still show darken (i guess less opacity) while swiping.
When it freezes, if on home page, i can click Services, it shows the click animation (focus), but nothing happens. Initially i thought there is some sort of overlay that does not disappear, but there is clicktrough so i have no idea, it's hard to debug it on the phone with Safari dev tools.
On desktop, i can not simulate the dragging fast, to see if it happens too.

I still can't replicate it. Can you check your mainView.allowPageChange property, i guess for some reason it is still false at this moment?

I mirrored the device on my screen:
https://drive.google.com/file/d/0B6MtqClJH_q-ZFJ6ZjM5YXBHTVE/view?usp=sharing
You see how i can scroll 5 levels deep, and then when swipe back, at some point it just stays stuck.
There is no way to record the tap, but before i tap the sidebar, i try all links on that page, and nothing happens.
allowPageChange: true does also not do anything.

Then there could be issue with layout or with data, do you see any errors in console?

The layout is the standard one that comes with the distribution.
To be honest i did not try  to use this because of this issue, so i dod not continue to look into it.
There are also no errors in the console. (Was the first thing i tried/looked into)
I have no clue what can trigger it.

Never had this problem. Can anyone replicate this? Otherwise I'd close it since the ticket is old af.

ng-repeat behaviour unexpected with swipeBackPage property in angularjs with framework7.
I am use swipeBackPage = true property for swipe than ng-repeat behaviour unexpected (ng-repeat bind multiple time) on screen swipe or back both opration.


Countdown button for Claim window

Finding:
Countdown on top of the claim button was considered by most of the users scary. Most of them had hard times reading the count down due to the very small font.
Part of the scare may be tied to the fact that all of them are worried and concerned of what happens if they do not claim in time.
Recommendation:

Move the countdown from the top of the button to an area that permits a bigger font.
Explain in a tooltip what happens if the tokens are not claimed in time, that your tokens are not getting slashed
Scary color, change the color
Removing clock icon and increase the contrast
Move this above the fold so you see it vs. below the fold
Move the timer out as well into a notification

Updated version of this:


Address issue #138 correct max-pods for t3/t2.small instances

Issue #138
Updated the t2 and t3.small instances max pods to 11 as per the updated CNI plugin version 1.3.0.
Maximum of 11 pods should be schedulable for the above mentioned instance types.

Seems like we are one checkbox further @micahhausler https://aws.amazon.com/about-aws/whats-new/2019/02/amazon-eks-releases-vpc-cni-plugin-v1-3-2-with-enhancements-for-/

Fixed in #231


docs: add about-us section in README.md

Closes #4

Requested changes

The order of "About Us" is: Board of Leaders, Mentors, Curriculum Maintainers, Contributors. Please maintain  same order.
Switch back all style changes. (Maybe do another PR with it if you want). you can save them locally using git stash if you are not familiar with git.

Is there anything else should I do?

@Hulxv
Excellent work. 2 things that can even make it more excellent.

In table, use |:-:| to center text in table. you don't need to use more than -.
Try to use logos from website instead of text.

If you don't want to do it, then this is fine and I will do it myself :)

@OmarShawky1

Fixed in #4


python310Packages.teslajsonpy: 3.7.2 -> 3.7.4

Changes:

https://github.com/zabuldon/teslajsonpy/releases/tag/v3.7.3
https://github.com/zabuldon/teslajsonpy/releases/tag/v3.7.4

Description of changes

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 222145 run on x86_64-linux 1

2 packages built:

python310Packages.teslajsonpy
python311Packages.teslajsonpy


Hack duration.

Oh, and you can add a comment about your hack (somewhere near the code that checks maxDurationYear).


How to generate personal coco-style PASCAL VOC meta

I would like to apply your work to my own dataset and ask how to generate the corresponding coco-style PASCAL VOC meta. Thank you for your reply

Hi, coco-style meta file refers to aligning the format of PASCAL VOC's meta file with the JSON format of coco's meta file. This alignment allows us to use coco API to process VOC datasets, especially for evaluating VOC results using coco's evaluation protocol.


feat: Support string type

Hey, I just made a Pull Request!

Closes https://github.com/backstage/backstage/issues/6489
Fixes: #6374
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@OrkoHunter How I can bump the version like #6374 branch is deleted so I can pull the changes of Dependabot.

@iamrajiv you can update the version in package.json files manually and run the yarn commands I mentioned above.

@OrkoHunter I tried to change string to string | undefined in files but locally also failing can you help?

@iamrajiv We need to update a few more places. :)
Looking at this error, we need to update the api we have defined so that html_url can be string | null now.

@iamrajiv The second error

is coming due to type incompatibility for workflowName in a WorkflowRun.

Type 'string | null | undefined' is not assignable to type 'string'.

https://github.com/backstage/backstage/blob/ea5631a40d41ddc1ddda96aa215c2bde29a366e6/plugins/github-actions/src/components/useWorkflowRuns.ts#L22

@OrkoHunter Yeah like locally I am trying to fix like I changed string to string | undefined still showing error when I do yarn tsc:full :/


Seeking Assistance With New Documentation

Issue:
The current BigCalendar documentation site is not in sync with the repository, missing a number of updates and features. Currently there is no automated process for updating the documentation site (GitHub page) when new packages are created.
Solution:
PR #2108 is a complete rewrite of Big Calendar documentation, located in the chore/storybookUpgrade branch. Some of it's highlights include:

All documentation has been moved to Storybook
Storybook has been upgraded
All previous Examples have been updated and included
Stories, with mdx docs and specific examples, have been created for every prop
Addon stories, to include examples and prop stories, have been created for DnD
Guide stories have been created to talk about Custom Styling, Custom Views, information about Big Calendar and Dates, and a guide on dealing with Timezones
General documentation contribution guidelines have been included
A GitHub workflow is included that will automatically build and deploy documentation to GitHub pages, after successful Release workflow (requires review and discussion with @jquense)

ToDo:
I need help in reviewing this documentation, and getting the testing straightened out. A number of dependencies were updated for this (Read: requires yarn install), and though all 'build' processes fine something in the Babel config is conflicting with Jest.
Any and all assistance is appreciated.

new docs look great! I'd be happy to help review the tooling changes, but don't have a time of time (as i'm sure you noticed) to look over docs thoroughly

@jquense Much appreciate the look at tooling. Also would need some assist with the auto doc deploy workflow, as that requires some info from you about the GitHub Pages setup for the repo.

I'm already helping at definitely typed. I'll take a look at this later, I'm still no aware of this update.

@jquense Have you had any time/luck looking at the tooling?


Push 0.1.2 to npm.

It seems when trying to install this, it doesn't find 0.1.2.

Hello? I am having the same problem, can't use loopPhrases props because of this.

Hey @AndreasArledal, can you push the 0.1.2 or are you still waiting to add some more improvements?

Sorry for the delay. I've started a rewrite. Hopefully I'll be able to publish it over the weekend.

Dude, is there any chance we'll be seeing this one ever published?

 Going to close this issue out so it disappears from my dashboard.


Ok/container element

Add container element.
Using FormElement instead of ExpressionProviderElement in all places where we do not need this abstraction.
Unify API of Radio buttons and Dropdown buttons

Codecov Report

Merging #7 into master will increase coverage by 0.06%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   43.81%   43.87%   +0.06%
==========================================
  Files          53       54       +1
  Lines        1495     1502       +7
==========================================
+ Hits          655      659       +4
- Misses        840      843       +3

Impacted Files
Coverage Δ

...ynamic_forms/lib/src/form_elements/validation.dart
36.36% <ø> (ø)
:arrow_up:

...rms/lib/src/form_elements/required_validation.dart
0% <ø> (ø)
:arrow_up:

...amic_forms/lib/src/form_elements/radio_button.dart
0% <ø> (ø)
:arrow_up:

...dynamic_forms/lib/src/form_elements/check_box.dart
0% <ø> (ø)
:arrow_up:

...c_forms/lib/src/form_elements/dropdown_option.dart
0% <ø> (ø)
:arrow_up:

...ages/dynamic_forms/lib/src/form_elements/form.dart
22.22% <ø> (ø)
:arrow_up:

...ges/dynamic_forms/lib/src/form_elements/label.dart
33.33% <ø> (ø)
:arrow_up:

...ages/dynamic_forms/lib/src/form_elements/text.dart
40% <ø> (ø)
:arrow_up:

...c_forms/lib/src/form_elements/dropdown_button.dart
0% <ø> (ø)
:arrow_up:

...amic_forms/lib/src/form_elements/form_element.dart
59.09% <0%> (ø)
:arrow_up:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4e2e6f...d2e4f8b. Read the comment docs.


Add means to easily add context information to messages from a given logger

We want to have certain values logged every time a log message is emitted from a given logger. In Journal we achieved this using its support for a handler function (handler: LogMessage => Unit) thus:
    new Logger(
      backend, {
        case journal.Error(message, None) =>
          backend.error(prependContext(message))
        case journal.Error(message, Some(e)) =>
          backend.error(prependContext(message), e)
        case journal.Info(message, None) =>
          backend.info(prependContext(message))
        case journal.Info(message, Some(e)) =>
          backend.info(prependContext(message), e)
        case journal.Warn(message, None) =>
          backend.warn(prependContext(message))
        case journal.Warn(message, Some(e)) =>
          backend.warn(prependContext(message), e)
        case journal.Debug(message, None) =>
          backend.debug(prependContext(message))
        case journal.Debug(message, Some(e)) =>
          backend.debug(prependContext(message), e)
      }
    )

Obiously this is a lot of code duplication.
So far as I can see to achieve a similar result with log4cats in its current form one would need to create a new log4s logger with a new implementation of the org.slf4j.Logger interface that would do the above prepending.  This seems overly cumbersome, it would be great to have some sort of easier way to do this in log4cats.

So this is String => String for all messages in a particular logger algebra?

yep


Fix MySQL lock name length limit

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Tests pass?
yes

MySQL 5.7.5 and later enforces a maximum length on lock names of 64 characters. Previously, no limit was enforced.

See https://github.com/symfony/symfony/pull/27250

Merged. Thank you!

Would it be safer to only hash if length is too long?

That still would be BC break if someone uses MySQL <5.7.5 and has lock name longer than 64 characters - it will be hashed even if there is no need for it.
IMO such condition will add unnecessary complicity and inconsistency. hashLockName() is protected, if someone relies on lock name, he could always override it.


Fix mysterious build failure in demo

Demo fails on any use of dynamic import.
No idea why this used to work and has now stopped.
Attempt upgrade to babel 7 to see if this resolves.

Disabling the code splitting demo page until this is fixed.

Revert changes from: https://github.com/downplay/jarl-react/pull/16/commits/f7fb70d5e573edbd3e963b0bbbfee14e94c3dd41
To re-enable


Playwright Conversion from Selenium

First pass at changing selenium to playwright
Got it to work with a simple carbon command carbon -s 'print("Hi World")'

commented out selenium functions for now
headless=False, so it's easy to confirm it was opening chrome and opening url page
"carbon_image.png" should save in the set destination folder
wait_for_event() let's the browser finish downloading before closing. (may not need that sleep function)

Currently fails following pytests:

test_create_image_for_one_liner
test_create_image_for_larger_snippet
test_storing_image_in_different_folder

Updated pyproject.toml file with correct dependencies

moved mypy, pytest-playwright, ruff to dev-dependencies
ruff linting config settings --> includes ignore E501
mypy config settings --> ignore_missing_import

Removed code related to Selenium
Moved carbon code image generation logic into with statement

Add ruff to pre-commit #15

copied ruff pre-commit hook as seen in documentation. Lint fixes enabled.
https://docs.astral.sh/ruff/integrations/#pre-commit


Remove core dependency

We use core2 for no-std builds now, no need to use extern crate core anymore.
Note
This was originally part of #1065 but I pulled it out into a separate PR.

You are correct, I'm not sure what I was thinking when I wrote that. I've rectified the commit log and PR description. Thanks.


When sending a signal to container, only set container to exit on next if the signal is KILL or INT

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "issue-11065" git@github.com:ble/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

This will update the existing PR, so you do not need to open a new one.

One way to address #11065
Not necessarily the best.

Is there an open issue that this is fixing?
Can you provide a test in integration-cli?

wait wait dont close
On Thu, Apr 23, 2015 at 5:44 PM, Ben Ellis<EMAIL_ADDRESS>wrote:

Closed #12722 https://github.com/docker/docker/pull/12722.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/12722#event-288853775.

just focrce push your branch
On Thu, Apr 23, 2015 at 5:44 PM, Jessica Frazelle<EMAIL_ADDRESS>wrote:

wait wait dont close
On Thu, Apr 23, 2015 at 5:44 PM, Ben Ellis<EMAIL_ADDRESS>wrote:

Closed #12722 https://github.com/docker/docker/pull/12722.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/12722#event-288853775.

it won't let me reopen because I force-pushed. "dog-wearing-goggles.jpeg"

you can open a new one, just dont close it hahaha


create jupyter-notebook topic

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md

I am:

[x] Curating a new Topic page

[x] I've formatted my changes as a new folder directory, named for the topic as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME])

[x] My folder contains a *.png image (if applicable) and index.md

[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please explain why you think this Topic page should be curated:
There are many notebooks on GitHub, data scientists love 'em, and GitHub loves Jupyter Notebooks.

I figured trying to do this using only the GitHub UI was a bad idea... Time to fetch this and rebase it as one clean commit with the logo in the right place.

@rgbkrk Thanks for the PR! Can you look at fixing the test failures: https://travis-ci.org/github/explore/builds/296023126#L581-L595. Thanks!

(date)(place);
monetic.transactiuon.exe
( credit .card.limited);
(bitcoins .demateralized)
1 bitcoin equal 1 euro
and so on
when number increase on the face of the bitcoins
if it is in precious metal so value increase
presented like e card or like piece of money
it is an european express of easyness
save

Updated, time to see what Travis thinks.

@rgbkrk Still failing I'm afraid: https://travis-ci.org/github/explore/builds/298053492?utm_source=github_status&utm_medium=notification. You can run them locally with script/cibuild, FYI.

Nice, I love that the script/cibuild required no intervening from me to get dependencies setup and run locally. ❤
I'll make sure things pass before I push again (after this last one).

Thanks for your first contribution to github/explore, @rgbkrk!  You rock!


custom stage problem

Describe your problem here.
i've been trying to make a mod on some unused songs in the ylyl mod but when i try to load in the song i get this error:

jimmyroom.lua.txt
jimmyroom.json.txt
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

two ends.

function onCreate()
	-- background shit
	makeLuaSprite('daRoom', 'daRoom', -600, -300);
	setScrollFactor('daRoom', 0.9, 0.9);

	addLuaSprite('daRoom', false);

	close(true); --For performance reasons, close this script once the stage is fully loaded, as this script won't be used anymore after loading the stage
end

why didn't it work before
thank you


Do not raise NewPeer unless both parties called connect()

This is a rebase of #599 against master.

This change is

r? @vinipsmaker
(maidsafe_highfive has picked a reviewer for you, use r? to override)


add support for choosing multiple test files to run

a command to interactively choose some test files to run (more than one) would be helpful.

implemented in 5db5900720aff76d7485a951d26edbbe482aa4fc


Provide support for additional static routes on AVD subnet

Describe the feature end to end, including deployment scenario details under which the feature would occur.
When using the CAF ALZ architecture, the domain controllers are two virtual network peerings away from the AVD network. This means that domain controllers cannot be reached without going through a firewall or NVA in the hub network.
Deployments should support a path to the domain controller (and possibly other) network(s).
Why is this feature important. Describe why this would be important for your organization and others. Would this impact similar orgs in the same way?
Customers are increasingly adopting the CAF ALZ architecture and placing their domain controllers in a dedicated identity subscription and virtual network.
Please provide the correlation id associated with your error or bug.
c04726a1-dc65-4931-8527-caa5c724da02
Can you describe any alternatives that you have taken since this feature does not exist?
N/A
Feature Implementation
Pending

@SvenAelterman great catch, thank you for your contribution.


remove description kubectl --show-all

--show-all has been deprecated and set to true by default.
https://github.com/kubernetes/kubernetes/pull/60210

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For 1.10 Features: set Milestone to 1.10 and Base Branch to release-1.10
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
NOTE: After opening the PR, please un-check and re-check the "Allow edits from maintainers" box so that maintainers can work on your patch and speed up the review process. This is a temporary workaround to address a known issue with GitHub.>
Please delete this note before submitting the pull request.

/assign @tengqm

Change looks good but you have to rebase it to the release-1.10 branch because it is not a 1.9 feature.

Change looks good but you have to rebase it to the release-1.10 branch because it is not a 1.9 feature.

Done.

/approve


Support package refactor

Issue link
Closes https://github.com/project-codeflare/codeflare-operator/issues/237
What changes have been made
The support package has been removed and moved to a separate repo here. Relevant imports have been updated.
Verification steps

Checkout this PR
Run the e2e tests and confirm that they work as expected.

Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[X] Manual tests
[ ] Testing is not required for this change

lgtm ! I guess we would need to merge the PR on the common repo first, this way we can test the e2e on GitHub actions here on this pull request before merging this one right?

lgtm ! I guess we would need to merge the PR on the common repo first, this way we can test the e2e on GitHub actions here on this pull request before merging this one right?

Yes that's right. We also need to run go mod tidy in CFO once the other PR has been merged to update the dependencies in go.mod and go.sum.

/retest

/lgtm

/approve


Use cpu_total_cores for vm cpu right_size

CPU right size recommendation was reporting a VM with 1 socket
and 4 cores as having 1 total CPU.  Use cpu_total_cores instead
of num_cpu to correctly report the total number of logical CPUs.
https://bugzilla.redhat.com/show_bug.cgi?id=1299809

@miq-bot add-label bug

cc @blomquisg @bdunne

@agrare Nice catch, thanks!

:+1: LGTM


fix: make pip error message test more robust

The error message generated by pip when a package fails to install has changed, causing an integration test to fail. This change tries to make the test more future-proof.

@Mergifyio refresh


Add some debug info to try to analyze canary issue

Are we corrupting the hub kubeconfig?  Printing it out to find out.
The one we create is usually less than 900 bytes so I think if we
overwrite the hub kubeconfig with the e2e one it will be obvious from
the trace -- but this won't necessarily help us know why.
Refs:

https://github.com/stolostron/backlog/issues/22014

Signed-off-by: Gus Parvin<EMAIL_ADDRESS>

/unhold


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_0bd71b3f-0e77-4d05-8f3f-0d424d87f653/pull/1 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-archive-test-target_0bd71b3f-0e77-4d05-8f3f-0d424d87f653.git

Docs Build status updates of commit 7ebd90b:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-UserAccountBuildPermissionInsufficientError] Owner v-alji no longer has Read permission of the repository https://github.com/VSC-Service-Account/docs-archive-test-source. It might be due to recent GitHub changes on SSO. Please ask the owner v-alji to logon to Docs Portal https://ops.microsoft.com once again. If it is not the case, please ask anyone of Admin permission of the repo to assign a new owner via Docs Portal https://ops.microsoft.com

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 7ebd90b:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-UserAccountBuildPermissionInsufficientError] Owner v-alji no longer has Read permission of the repository https://github.com/VSC-Service-Account/docs-archive-test-source. It might be due to recent GitHub changes on SSO. Please ask the owner v-alji to logon to Docs Portal https://ops.microsoft.com once again. If it is not the case, please ask anyone of Admin permission of the repo to assign a new owner via Docs Portal https://ops.microsoft.com

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Update merge.md

Updated Powershell what-if scripts

@seesharprun

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

@tarabhatiamsft
PRMerger will only accept sign off from the listed 'author'. However, if you are a Microsoft employee authorized to update this content, you can send a request to<EMAIL_ADDRESS>for this PR to be merged.  Include your role, and an explanation of why the PR should be merged without approval from the listed author.

#please-close


Waves

@AnthonyMyatt  @fivdi, I've just completed and tested and documented the Wave section  of pigpio library.
New function calls available are:
gpioWaveChain
gpioWaveAddSerial
gpioTick
gpioSetWatchdog
I will add 433D porting to example and create another repository implementing VirtualWire with pigpio

Syntax style corrected (camelCase  style).
Fixed parameter check in gpioWaveAddSerial
@AnthonyMyatt, can we merge now to the Waves branch?


Update peerDependency on apollo-client

Steps to Reproduce
react-apollo has a peerDependency on apollo-client: ^0.6.0, see https://github.com/apollostack/react-apollo/blob/master/package.json#L68.
apollo-client is already at 0.7.3, so I'd expect the peerDependency to be updated to include ^0.7.0.
Version

<EMAIL_ADDRESS><EMAIL_ADDRESS>

I think that #427 might be solved by this an uprev.

Does this issue duplicate #415 ?

Yesss duplicate indeed! Stupid I didn't find that one.


Build broken on master

make gives me the following error
Installing test dependencies for vet...
internal/consumer/dlq.go:28:2: cannot find package "github.com/golang/protobuf/proto" in any of:
	/Users/venkat/go-workspace/src/github.com/uber-go/kafka-client/vendor/github.com/golang/protobuf/proto (vendor tree)
	/usr/local/Cellar/go/1.9.3/libexec/src/github.com/golang/protobuf/proto (from $GOROOT)
	/Users/venkat/go-workspace/src/github.com/golang/protobuf/proto (from $GOPATH)

Looks like glide.yaml is missing some dependencies

Fixed by https://github.com/uber-go/kafka-client/pull/23


PureBASIC 5.60

Update PureBASIC language definition to version 5.60 (new keywords)

Sorry for the unclean commits history ... the changed file is just the language definition.

I used the script on the official forum PureBasic, but it is not enough highlighting code.

@azjio:

I used the script on the official forum PureBasic, but it is not enough highlighting code.

In what sense? It doesn't highlight at all or it doesn't highlight well?
I've used it in many projects and it's working fine. Here you'll find some prebuild hjs packages for PureBasic (modded version, slightly old hjs version) with full examples and instructions:

https://github.com/tajmone/purebasic-archives/tree/master/syntax-highlighting/highlight.js

Here's a live example of PB code being highlighted:

https://tajmone.github.io/doxter/

look here adapted script http://forum.ru-board.com/topic.cgi?forum=2&topic=5708&start=80#14
Check the way it works on the site here https://www.purebasic.fr/english/viewtopic.php?f=12&t=73662&sid=76d08736cb21fdf6e74cc1ab0ca99f69

I don't see any PB code on the page of first link.
The second link point to the PB forum, but the forum doesn't try to load the hjs package at all.
In order to make Highlight.js work on CMSs, Forums softwares, etc., you'll need to edit the application template to ensure:

It loads the precompiled Highlight.js package with the languages you need.
It emits the correct tags around code blocks, so that hjs can find them and auto-detect the code language.

But this is not an issue specific to the PureBasic language, but a general issue with setting up HJS.
You'll probably find better support by asking help on the community support forums for these specific web forum applications (phpBB, etc.), they might know how to adapt the underlying template, and if there are any conflicts with other JS plugins.

I don't see any PB code on the page of first link
you'll need to edit the application template to ensure:
The first link contains "edit template". Use Greasemonkey, Tampermonkey. When using javascript code highlighting good.


Add ES2015 String method includes

Per the specification at http://www.ecma-international.org/ecma-262/6.0/#sec-string.prototype.includes
I'm not certain whether the first argument should accept a RegExp. The specification says:

"Throwing an exception if the first argument is a RegExp is specified in order to allow future editions to define extensions that allow such argument values."

So using a RegExp won't work today, but allowing that argument type is forward-compatible, so I've included it.

Thanks for the contribution!
The purpose of the type checker is to prevent runtime errors. Since a regexp argument currently throws, I think we should catch that use case as an static error, as well.

@samwgoldman Okay, I've removed the RegExp from the accepted types and I've signed the CLA.

@rjn945 Cool! One annoying thing about our test setup: adding a line to a flowlib file changes the expected output files, which include line numbers.
Do you think you could make the necessary changes to bring this PR into a passing state? In order to fix the tests, you need to change the test/xxx/xxx.exp with the updated line numbers. The easiest way to do this is using the diff command, like so: diff test/xxx/xxx.{exp,diff}, but you can also change them by hand.
Thanks again!


Return responses that are compatible with http status code

Is your feature request related to a problem? Please describe.
The database errors are hard to classify properly. When trying to send back a HTTP response
eg. 422 for invalid data
Describe the solution you'd like
It could return a default
{
message: 'Error message',
status: 500
}

Describe alternatives you've considered
N/A
Additional context
N/A

This does not seem to be valid anymore


Fix datetime

fix #51

Codecov Report

Merging #52 into master will decrease coverage by 5.45%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   85.68%   80.23%   -5.46%
==========================================
  Files           5        5
  Lines        1062      936     -126
==========================================
- Hits          910      751     -159
- Misses        152      185      +33

Impacted Files
Coverage Δ

src/TableReader.jl
77.89% <100%> (-13.93%)
:arrow_down:

src/parser.jl
93.33% <75%> (+5.91%)
:arrow_up:

src/download.jl
66.66% <0%> (-13.34%)
:arrow_down:

src/tokenizer.jl
78.59% <0%> (-3.41%)
:arrow_down:

src/stringcache.jl
78.26% <0%> (-3.32%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8c4dd4...19fe542. Read the comment docs.


add Cedric Conol to Contributors

Adding my name in the Contributors section

Nice! Will merge as soon as #101 is over 👍

oh sorry this was in reference to your comment in #108.
currently resolving #101 😄

My fault, actually you already contributed with #108! Merged, and once again welcome to Texthero!! 🎉 🚀  it's a pleasure to have you on board! :)


⚠ Bofrost.at has degraded performance

In ddbcd88, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1739 ms

Resolved: Bofrost.at performance has improved in ecbb1ea after 6 minutes.


support for other data types like io.Reader or []byte

hi, the Open function is taking a file path, but in my case, the data format is io.Reader or []byte. Could you please let me know if this will be supported in future?

nevermind, you already support io.Reader with  Decode function. thank you


Enhancement - switch private to protected

Hard to customize for example resulting filename generation algo (suppose i dont want '_' symbol in it) from getCurrentFilePath(). Would be nice to replace some/all private methods by protected

It is better to add extension points rather than opening up everything.


Feat/add google cloud firestore support

Add Support for Azure Blob Storage
Following the code and tests of the Micronaut implementation of the azure blob-storage-client, I've implemented something similar for Firebase.
Problem
All tests - if run individually - pass.
But if I run them via ./gradlew check, FirestoreStorageSpec fails when trying to access the firestore-emulator docker-image with the following error-message:
Caused by: com.google.api.gax.rpc.UnavailableException: io.grpc.StatusRuntimeException: UNAVAILABLE: Network closed for unknown reason

@SimonFrauenschuh Does this also support gcp cloud storage https://cloud.google.com/storage?hl=en

@SimonFrauenschuh Does this also support gcp cloud storage https://cloud.google.com/storage?hl=en

EclipseStore has no support (yet) for google cloud storage so the short answer is no because you can't use the Firestore client that is required by EclipseStore.
Currently, there seems to be no direct support, but you can try using the S3Client and accessing googles XML-Endpoint. According to the documentation I've read until now there might be a change that because there is a S3-compatible endpoint you can use (Micronaut) EclipseStore for AWS S3.
(Maybe this tutorial works for you? (Note: You have to use the S3Client, not the AmazonS3))

@SimonFrauenschuh Thanks for the contribution.
The test FirestoreStorageSpec is failing for me.
can you check it?

Sorry, I have a few exams right now in university, will probably take a few days (weeks).
If the test is executed alone, it works, but I'll try to the tests.


1136514475 master

Edits to https://github.com/obophenotype/cell-ontology/pull/556 to comply with patterns (& fix up some related terms)

I have no idea why there is a failing check, what should I do then?

@1136514475  - Apologies this has been hanging so long. Merging now.  Please review and let me know if you need further changes or make another pull request, otherwise I'll assume good to release as-is.  I plan to run a release today to make these changes public. Perhaps we could meet to discuss setting up an efficient pipeline for such requests in future?

Thanks for your work. No changes needed. This pull request is a little difficult for me because I am not familiar with these owl works. Now I think your pipeline is efficient enough. If I need to make more pull requests, I will continue using this pipeline.


Enable builtins.

Can you try adding tests for these? I thought they couldn't work for now.

They seem to work fine. Any reason why you think they shouldn't?

Is there an example of an existing builtin test somewhere?

See: https://github.com/EmbarkStudios/rust-gpu/pull/789 (I followed the git blame)

In discord, it was pointed out that #[spirv(workgroup_size)] is broken - the decoration applies to a constant, not a variable, and it specifies the workgroup size, it's not provided with the workgroup size. (A subsequent discussion also showed that WorkgroupSize in SPIR-V is just plain broken with multi-entry-point shaders - but the LocalSize(Id) execution mode is a replacement for its behavior)

ok workgroup_size might be broken, realized I wasn't actually using it. but I think we went over this in https://github.com/EmbarkStudios/rust-gpu/issues/841, subgroup_local_invocation_id should be supported as it has the following enabling capabilities: Kernel, GroupNonUniform, SubgroupBallotKHR.

Let me know if you want me to drop the example.


GitHub API credentials is always set to the first entry

Whenever I load my job settings, the "GitHub API credentials" is set to the first available choice in the drop-down, regardless of the last saved entry. Unless I correct this entry ever time I save, it will be updated (incorrectly) to the first available entry.

I'm seeing the same issue here.

Same Issue here

I even have to click 'save' for this to be applied, clicking apply seems also to apply the first entry everytime.


Modification on nav

on hovering on nav bar content because of bright yellow colour background the text is not that clear so i can change it a bit and give like a short transition to make it little smooth.
Would you like to assign this to me under LGMSOC'21..?
Something like this.

Okay go ahead @Ruchi-163


[Cherry Pick] fix view parsing problem

What problem does this PR solve?
cherry-pick https://github.com/pingcap/tispark/pull/953

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

Codecov Report

:exclamation: No coverage uploaded for pull request base (release-2.1@ce8d50b). Click here to learn what that means.
The diff coverage is 34.61%.

@@              Coverage Diff              @@
##             release-2.1    #964   +/-   ##
=============================================
  Coverage               ?   53.4%
  Complexity             ?    1120
=============================================
  Files                  ?     153
  Lines                  ?    7026
  Branches               ?     816
=============================================
  Hits                   ?    3752
  Misses                 ?    2901
  Partials               ?     373

Impacted Files
Coverage Δ
Complexity Δ

...ain/java/com/pingcap/tikv/meta/TiUserIdentity.java
0% <0%> (ø)
0 <0> (?)

...rc/main/java/com/pingcap/tikv/meta/TiViewInfo.java
0% <0%> (ø)
0 <0> (?)

.../main/java/com/pingcap/tikv/types/DecimalType.java
40% <100%> (ø)
4 <0> (?)

...c/main/java/com/pingcap/tikv/meta/TiTableInfo.java
41.46% <75%> (ø)
17 <3> (?)

...rc/main/java/com/pingcap/tikv/catalog/Catalog.java
74.48% <83.33%> (ø)
12 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce8d50b...d256a72. Read the comment docs.


Export data out of the module and added type declaration and test.

Is this still up-to-date after merging https://github.com/freeall/currency-codes/pull/25? Then I'll add it

Now it's up to date 👍

Perfect, thanks!
Published as 2.1.0


[doc/security] Identities and Root Keys

The document describes the composition of the Silicon Creator and Silicon Owner
identities and the Silicon Owner root key derivation scheme. This scheme is based
on a symmetric key manager with support for software binding and key versioning.
This document also defines a non-cryptographic Device Identifier to facilitate
silicon tracking during manufacturing flows. The Device Identifier is also mixed
into the Creator Identity.
The document was converted to markdown by a GDoc plugin and formatted by
a md-linter. Since the maximum line width is set to 80cols, in most
cases a sentence change will trigger a full paragraph reformat/diff.
The GDoc to Markdown pluging generates tables in HTML format, which in
this case is useful to retain the per-cell text formatting and the rows
and columns layout.
Signed-off-by: Miguel Osorio<EMAIL_ADDRESS>

Miguel, just a note, and a question. Note: there are a few syntactical requests here for consistency. Question: the TC will be considering the Google Doc form as part of the RFC process. Has it been compared against this .md for consistency?

Hi Scott, I will proceed with updates here PR once the document is approved by the TC.  It should be ok for the TC to comment directly on the Google Doc version.

PTAL @sjgitty, @felixmiller, @gkelly


Support 'detail' field in 'GetJob'/'ListJobs' openapi

Background
Currently, 'GetJob' and 'ListJobs' openapi need to get the job detail and show in frontend. But the job detail in framework and in specific job is different:

For framework, business logic can only set the job detail to the backend job table when the job state is transitting.
For job, it can define any kind of job detail in any format by defining its own openapi, and offer the service as long as it is online

So, we get 3 schemes to offer job detail:

Scheme1: User queries the framework  'GetJob' and 'ListJobs' openapi first, and then queries business openapi for job detail if job is online
Scheme 2: User queries the framework  'GetJob' and 'ListJobs' openapi directly, in which the framework dispatches the request to specific job openapi if the job is online
Scheme 3: Put business job detail in framework backend job table and use framework  'GetJob' and 'ListJobs' openapi directly

Discussion
The main arguement of upper 3 schemes are:

For Scheme1,  User need to deal some subtle corner cases to show the job detail correctly. It's not easy to use these openapi although every openapi has more clear semantic at the perspect of the framework.
For Scheme2,  It's easy for users to use the  'GetJob' and 'ListJobs' openapi. But framework need to deal with specific job openapi, which makes framework decouples with some implements of business logic.
For Scheme3,  It's easy for users to use the  'GetJob' and 'ListJobs' openapi. But the design of framework meta decouples with some implements of business logic, which may affect the stability of framework when we have large num of jobs.

Proposal
After some offline discussion and the frontend design by PM, I propose to choose Scheme2 with some restrictions to support 'detail' field in 'GetJob'/'ListJobs' openapi.  The main reason is as follows:

For the frontend page, user will list all jobs with job detail at the very beginning, which means we need to query job openapi seperately for each job if we choose Scheme1. It seems unreasonable to do such a thing.

For Scheme3, It may cause some design problems if we mix up the  meta data of framework and business
For Scheme2, we can make some rules to decouple the framework and business in these two openapi

Detail of the Scheme2:

[ ] Explicitly declare whether a job type offers a 'GetJobDetail' openapi
[ ] Unify the format of job's 'GetJobDetail' openapi, so that framework can dispatch the request to specific job directly and put the job's openapi resp to 'detail' fields without any other knownleges.
[ ] When framework calls 'GetJob' and 'ListJobs', it first checks the status of job, and then decides whether to dispatch the request to specific jobmaster.
[ ] Since 'ListJobs' may fans out to so many jobmasters, we need to restrict the calling frequency and make some cache if possible.

/area engine
/type feature
/cc @maxshuang

Since 'ListJobs' may fans out to so many jobmasters, we need to restrict the calling frequency and make some cache if possible.

For this maybe adding a cache mechanism is enough, and we can add a global API rate limit later, which means we don’t need to customize rate limiter for single API

Since 'ListJobs' may fans out to so many jobmasters, we need to restrict the calling frequency and make some cache if possible.

For this maybe adding a cache mechanism is enough, and we can add a global API rate limit later, which means we don’t need to customize rate limiter for every single API

Ok. Agree.

lgtm


BZ1306 — get_fsm crashes when riak_object value is not a binary

Fixes issue in riak_kv_get_fsm:update_stats/2 calling erlang:size/1 on a riak_object value which isn't a binary
https://issues.basho.com/show_bug.cgi?id=1306

+1 merge - riak_object values should really be binaries, but that hasn't been enforced on put and the various interfaces convert on retrieval so making it work is the right thing to do.