Fix version

This branch introduces a version module for handling the version and git information. It should work whether the user is running from a git repo, from a setup.py installed version, or from pip installed.

This is addressing issue #133

This branch needs to be rebased before it gets merged. But if the cal branch gets merged first the rebase will have to be redone, so we should wait on the rebase until this PR is signed off on.


Add changelog for v1.4.4

What type of PR is this?
/kind documentation
What this PR does / why we need it:
Add changelog for v1.4.4.
Does this PR introduce a user-facing change?:
NONE

/assign @kron4eg

/approve
/lgtm

/cherrypick release/v1.4


Associate cdx.json extension with the media type

This is a completely optional request, but I was wondering if the CycloneDX team would be comfortable associating the extension .cdx.json to uniquely identify cyclonedx sbom json files? This would help with auto detection of cyclonedx bom files and provide some consistency around the file extension for users who want to be explicit about it.
Currently the cyclonedx json media type is associated with json file extension.
I am not sure if IANA allows you to update/add new extensions to an existing media type but I thought it was worth bringing this up in an issue for further discussion. For context SPDX uses spdx.json extension https://github.com/spdx/spdx-spec/issues/577#issuecomment-960295523 Here's the related syft issue where I describe the reasons behind a uniquely identifiable extension - https://github.com/anchore/syft/issues/612#issuecomment-962264996

I believe SPDX file naming requirements are part of the standard itself which is why the RFC needed to include spdx in the file extension. IMO, this is a legacy trait and was not adopted by CycloneDX. The primary purpose for the media types for CycloneDX adopters are for HTTP Accept headers where a client can request a specific type of SBOM and get that type back. Often times, these are not files. Its just machine-to-machine data transport. The CycloneDX BOM Repository Server and OWASP Dependency-Track both honor this behavior.
By convention, CycloneDX names their boms as bom.json and bom.xml. All official CycloneDX implementations and many community ones also follow this convention. It's similar to the convention used by Maven (pom.xml) and npm (package.json). So the auto detection algorithm should likely take this convention into consideration.
Changing an IANA type would break compatibility for all CycloneDX adopters, so it's unlikely to happen.
Seeking input from @coderpatros and @DarthHater

Changing an IANA type would break compatibility for all CycloneDX adopters, so it's unlikely to happen.

It could be an optional convention which shouldn't break compatibility.
But I'm of two minds about this. It helps for some use cases. But, IMHO, isn't a sufficient solution.
There's a bunch of projects now trying to support SBOMs of different formats side by side. But an extension like .spdx.json or .cdx.json only goes part of the way.
I know the SPDX folks are working on v3. So what happens for consumers when they release v3 with breaking changes? And how do publishers handle the transition period where they might want to publish v2 and v3 SBOMs side by side?
I'm in favour of it as an optional "official" convention. But I don't think it needs to be added to the media type registration. Which also supports specifying the spec version for the above reason.

@coderpatros I am happy with this compromise if it's okay with you -

I'm in favour of it as an optional "official" convention. But I don't think it needs to be added to the media type registration. Which also supports specifying the spec version for the above reason.

Hi team - any thoughts on https://github.com/CycloneDX/specification/issues/100 ? As CI processes are creating multiple SBOMs per release, it is not viable to have a single file named sbom.json  having a common extension, even if it is just a documented convention would help a lot with auto detection of cdx sboms in various tools. .cdx.json  is already used in buildpacks and I was also thinking of proposing this extension to discover known sboms via syft (so that if an artifact already has pre-provided sboms. tools like syft can easily find and output them)) and to also trigger the auto-mime detection for cosign attach sbom feature.

it is not viable to have a single file named bom.json

This should not occur as spdx is required to be part of the filename per spec.
Note that we will have to document two conventions.

bom.xml / bom.json as the default because that's what most people use today
bom.cdx.xml / bom.cdx.json as a fallback

Reason being is that bom.xml and bom.json are already being published to internal and public repos today.

@stevespringett by multiple SBOMs per release, I meant that there are CI processes creating multiple cyclonedx SBOMs per release (for different components/containers/clis for eg.)
I was not too worried about interoperability with SPDX bom documents when this issue was created.
It was more along the lines of - lets say my CI process is creating CycloneDX SBOMs for -

myapp1
myapp2

and so on, I would like to create files like myapp1.cdx.json and myapp2.cdx.json.

Got it, understood. Thanks for clariifying.

So given the above, does the following sound okay (made a small modification to the second point)?

Note that we will have to document two conventions.

bom.xml / bom.json as the default because that's what most people use today
*.cdx.xml / *.cdx.json as a fallback

If so I am happy to submit a PR.

@coderpatros, @DarthHater: What are your thoughts? Should we document this in the READMD as well as the website?

Yeah, I think so. Probably good to add it to the spec overview below the registered media types https://github.com/CycloneDX/cyclonedx.org/blob/master/specification/overview/index.md
Having it there is also good for context. As in, where media types are available they should be used to infer the format. But the file extensions are a fallback option when you can't use the media types.


Error messages in the notebook file cannot be copied and not wrap.

System Information (please complete the following information):

Model Builder Version (available in Manage Extensions dialog): <IP_ADDRESS>2802 (Main)
Notebook Editor [Preview]: <IP_ADDRESS>2602

To Reproduce
Steps to reproduce the behavior:

Select Create a new project from the Visual Studio 2022 start window;
Choose the C# Class Library (.NET Core) project template with .Net 6.0;
Add model builder by right click on the project;
Select Object detection to complete the training;
Add Notebook on consume page;
Open the Notebook file and click "Run All" button;
See the error messages cannot be copied, and they are not wrap, so cannot see the full error message.

Expected behavior
can copy+paste the error message,  and the message will wrap if too long.
Screenshots

This should go in the Notebook repo. I've moved it - https://github.com/microsoft/VS-Notebook/issues/99
Thanks Qin!


remove / resurrect tests in the tests_broken directory

Related to #400

I can work on this sometime this week


[SPARK-37464][SQL] SCHEMA and DATABASE should simply be aliases of NAMESPACE

What changes were proposed in this pull request?

In the Spark SQL parser, most of the time we treat SCHEMA and DATABASE simply be aliases of NAMESPACE. However, there are still two places that we treat them differently: USE NAMESPACE, SHOW NAMESPACES and SHOW CURRENT NAMESPACE.
This PR fixes these 2 places and always treats SCHEMA and DATABASE as aliases of NAMESPACE.
Why are the changes needed?

This makes the parser consistent and easy to understand for end-users.
Does this PR introduce any user-facing change?

no
How was this patch tested?

updated tests

cc @imback82 @MaxGekk

Test build #145633 has started for PR 34713 at commit 7829d84.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50104/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50104/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50104/

Test build #145633 has finished for PR 34713 at commit 7829d84.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145633/

Test build #145641 has started for PR 34713 at commit eca043f.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50112/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50112/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50112/

Test build #145641 has finished for PR 34713 at commit eca043f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145641/

thanks for the review, merging to master!


Issue: when parsing code to , \n at the end lost

marked version: 0.3.6
My markdown code:

` ` `
code1
code2

` ` `

After parsing the HTML code looks like this,  and all \n at the end lost:

code1
code2

#983


feat: combine reading spec from url

in the future if we want to support other url sources (like ftp, etc.) we can

@jordanshatford do you want to add tests for these?

Might need to wait to test these properly. There wasnt any previous tests and I am not entirely sure how to mock the HTTP request.


chore: Adds cache write

So that users can reuse cached artifacts in other environments.
Related issue(s)

Resolves #
Description
Summary of changes

Dependency additions / changes

Test additions / changes

Checklist

[ ] I have tested the changes locally.
[ ] I have formatted the changes with Prettier and/or cargo fmt with default settings.
[ ] I have linked this PR to the issue(s) that it resolves.
[ ] I have reviewed the changes on GitHub, line by line.
[ ] I have ensured all changes are covered in the description.

Documentation needs

[ ] This PR requires documentation updates when merged.

Additional context

@kobyhallx can this be closed?


Validation in service and instance creation

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind feature

What happened: empty 'name' in services and instance creation gives error
What you expected to happen: Ideally all required param should have validation and it should throw proper error accordingly
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

Orchestration(release/branch) version:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

PR raised

Must fix


Typescript highlight color error

Does this issue occur when all extensions are disabled?: Yes

VS Code Version:1.86.2
OS Version: ubuntu 23.10/Web Editor

It seems the error will happen if the length of template list is longer than 1 and let var const with operator= is on the left.
I'm sorry with my poor English.

Minimal example as text:
let m = new Map<number, number>;

Move here as the TM scoping is wrong. In this case, meta.type.parameters.ts is not added for <...>


docs-bug(mat-slider): thumbLabel unsupported

Documentation Feedback
Hi,
I recently upgraded from angular 13 to angular 18, and I noticed that since 16v mat-slider does not support the thumbLabel option.
In the documentation, it was present in version 14, then it disappeared.
Now I don't know what to replace it with, and in the documentation, there is no mention of this property disappearing. How can I replace it? And how can I make other components where it happens as well?
@Input()
thumbLabel: boolean
<mat-slider
[(ngModel)]="_value"
[max]="_max"
[min]="_min"
[step]="_step"
[thumbLabel]="true"
color="primary" #ngSlider><input matSliderThumb (change)="onChange({source: ngSliderThumb, parent: ngSlider, value: ngSliderThumb.value})" #ngSliderThumb="matSliderThumb" />

Affected documentation page
https://v14.material.angular.io/components/slider/api

Hi, you can assign this one to me

I don't completely understand because the docs does reference thumblabel in its example
    <mat-slider         class="example-margin"         [disabled]="disabled"         [max]="max"         [min]="min"         [step]="step"         [discrete]="thumbLabel"         [showTickMarks]="showTicks">       <input matSliderThumb [(ngModel)]="value" #slider>     </mat-slider>
here -> https://v18.material.angular.io/components/slider/examples

Thank you very much for the answer. (I dont' know why but i don't have permission to assign issues)
So what used to be an input parameter [thumbLabel] becomes [discrete]=“thumbLabel”?
My component is already matSliderThumb as in the v18 documentation example, but it is not shown.
Let's say my doubt is that the [thumbLabel] decorator has been deprecated since v14 but in the documentation there is no why and no alternative

I don't know if this really answers the question but I believe the recommended approach now involves setting the label property directly on the matSliderThumb component. This aligns with the current Material Slider implementation and ensures compatibility with future updates.
Something like this?
<mat-slider>   <mat-slider-thumb label="My Label"></mat-slider-thumb> </mat-slider>

It works. Thank you!

It sounds like this is resolved so I'll close it. It can be reopened if there's anything actionable on our end.


Merge pull request #1 from apache/trunk

update from apache
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[x] Verify design and implementation
[x] Verify test coverage and CI build status
[x] Verify documentation (including upgrade notes)

I am going to close this appears to have been opened by mistake.


failed retrieving metric, request failed for query karpenter_reserved_capacity_cpu_utilization{name="demo"}, Post "http://prometheus-operated:9090/api/v1/query\": dial tcp: lookup prometheus-operated on <IP_ADDRESS>:53: no such host

i have not configured prometheus yet. even though its redirecting to the below specified URL and its failing to collect the metrices. Can you please tell me where this configuration is made ? and how do i change it?
failed retrieving metric, request failed for query karpenter_reserved_capacity_cpu_utilization{name="demo"}, Post "http://prometheus-operated:9090/api/v1/query\": dial tcp: lookup prometheus-operated on <IP_ADDRESS>:53: no such host

Hey @Balukeethu 👋 . It looks like you may have solved your own problem. We have an install script that includes prometheus https://github.com/awslabs/karpenter#quick-install---controller--dependencies.
If you want to configure a custom prometheus endpoint, simply update this https://github.com/awslabs/karpenter/blob/main/cmd/controller/main.go#L50


Start to backfill some protocol documentation

See here for a rendered preview.

+@SeanCurtis-TRI could I ask for any early feature-review feedback here?  I still have some TODOs to fill out, but I should probably check if I'm moving in the right direction.

Thanks.  I'll ping you again once I have the additional JSON examples filled in.  My hope is that will help mitigate the lack of a more structured specification.


Regression with globalAlpha (?) in 0.1.29

After updating to<EMAIL_ADDRESS>I noticed my app having problems. After downgrading, everything started to work again. Sorry for the not-really-minimal repro but it was the best I could do. I think globalAlpha is the issue here, but I'm not really sure.
Basically I just create a gif with 6 frames, where every other frame is alternating, and 1 frame has a lower alpha than the other.
000.png

FFF.png

test.js
import { createCanvas, Image } from '@napi-rs/canvas'
import { GifEncoder } from '@skyra/gifenc'
import { readFileSync, writeFileSync } from 'fs'
import { buffer } from 'stream/consumers'

const encoder = new GifEncoder(256, 256)
	.setRepeat(0)
	.setDelay(20)
	.setQuality(100)

const imageHex = [
	'FFF',
	'000'
]

const stream = encoder.createReadStream()
encoder.start()

const canvas = createCanvas(256, 256)
const ctx = canvas.getContext('2d')

for (const hex of imageHex) {
	const image = new Image()
	image.height = image.width = 256
	image.src = readFileSync(`./${hex}.png`)

	const image2 = new Image()
	image2.height = image2.width = 256
	image2.src = readFileSync(`./${hex === 'FFF' ? '000' : hex}.png`)

	ctx.globalAlpha = 1
	ctx.drawImage(image, 0, 0)

	ctx.globalAlpha = 0.5
	ctx.drawImage(image2, 0, 0)

	const bytes = ctx.getImageData(0, 0, 256, 256).data
    encoder.addFrame(bytes)
}

encoder.finish()

writeFileSync('./test-0.1.28.gif', await buffer(stream))

Output v1.1.29

Output v1.1.28

Flashing image warning

@KhafraDev this is a bug in previous version see https://github.com/Brooooooklyn/canvas/issues/539, the globalAlpha should not apply to images

node canvas behaves similarly to v0.1.28, this is likely an unexpected change for a few people. According to the spec as well: [t]he global alpha value gives an alpha value that is applied to shapes and images before they are composited....
I believe globalAlpha also affects images on the browser, at least, according to some stackoverflow posts.


Downloads bugfix

Addresses #1239 and another reported issue.
User reported error msg on plan download (PDF)

Due to not checking if an answer has text before attempting to .gsub  (case for option_based questions which would be valid with options but no text)
1239 is due to an issue in the logic where answers with blank text will not get exported, breaking export for option_based questions.

Changes:

Refactored &fixed checking for blank to answer.rb
Switched export to conditionally check for presence of options/text with special case to handle rda questions's hash answers.

NOTE: REBASE DEVELOPMENT and CONTRIBUTIONS after merging

It's been brought to my attention that Question text for questions with options is not currently exporting.  Updating this as well in the following commit


Public dev merged

PR checklist

[ ] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] Make sure your code lints (nf-core lint).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).

This is the merge of the dev branch into the public-dev branch. I've also added the genome metadata sub workflow into the main pipeline


ENTERPRISEPACK doesn't show MICROSOFTBOOKINGS inclusion

The ENTERPRISEPACK entry does not show MICROSOFTBOOKINGS as an included service plan.
Product documentation claims entitlement: https://docs.microsoft.com/en-us/microsoft-365/bookings/bookings-faq?view=o365-worldwide#pricing-and-licensing
Validation can be performed on SKU in tenant:
Get-AzureADSubscribedSku|?{$_.skupartnumber -eq "enterprisepack"}|select -ExpandProperty serviceplans|select serviceplanname

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7c245452-161d-89a1-c026-99a0721cf071
Version Independent ID: 16dec59a-eb83-1837-4efd-4645e7aeaed2
Content: Product names and service plan identifiers for licensing - Azure AD
Content Source: articles/active-directory/enterprise-users/licensing-service-plan-reference.md
Service: active-directory
Sub-service: enterprise-users
GitHub Login: @daveba
Microsoft Alias: daveba

@Snozzberries Thank you for your feedback on this . We will review this and update accordingly .

@Nicholak-MS Could you please review and add it to the list as requested

There is a PR pending review for this change. https://github.com/MicrosoftDocs/azure-docs-pr/pull/156619. @shashishailaj can you review and approve and get it on the next deployment?

@Nicholak-MS Thanks  This has been reviewed and merged .


Verify broker-admin secret in system tests

...instead of broker-client secret as is currently done because with https://github.com/submariner-io/subctl/pull/653, subctl no longer creates a broker client SA and its associated secret.

Since it's subctl that creates these secrets, perhaps these tests should be in the subctl project.

Do we need this in 0.15? I am not sure why it's part of the 0.16 board

Do we need this in 0.15?

No this is related to https://github.com/submariner-io/subctl/pull/653.


plugins/docker  How do you configure global host and let clone specify IP or domain name on the Intranet、The same cloud service bandwidth is very small Clone

plugins/docker  How do you configure global host and let clone specify IP or domain name on the Intranet、The same cloud service bandwidth is very small Clone

:wave: hey there, per our issue template, for end-user support please use one of our support channels, such as our chatroom or our mailing list.


fix: Check HTTP code for redirect before raise

Closes #35 #36

Thanks @renyuneyun I will check it out.

There is a typing problem in the 3.7 environment. I think we can just ignore it since 3.7 is already EOL.


Update README.md

Problem
Building the connector from the latest code is described in a previous section. Seems like it should not be repeated at this location in the README.
Solution
Removed redundant instructions.

@ybyzek I couldn't select a reviewer for this. not a big thing I don't think, but maybe something to fix

@ybyzek I couldn't select a reviewer for this. not a big thing I don't think, but maybe something to fix

@tobydrake7 -- thank, assigned to @rspurgeon

@tobydrake7 -- thank, assigned to @rspurgeon


Create in-memory database for testing purposes.

Should be able to store Users and Routines.

Both MagicianDB and ContactDB objects have been created.

Mark has updated with RoutineDB.

Routine & Magician in-memory CRUD models are done.  I'd say the essence of this issue is complete.


🐛 [cloud_firestore] namedQueryGet unknown error with select clause

Bug report
Consuming bundle generated with select clause fails with error:
[ERROR:flutter/lib/ui/ui_dart_state.cc(199)] Unhandled Exception: [cloud_firestore/load-bundle-error] Unknown error or an error from a different error domain.
#0      new MethodChannelLoadBundleTask.mapNativeStream (package:cloud_firestore_platform_interface/src/method_channel/method_channel_load_bundle_task.dart:45:9)

Steps to reproduce
Steps to reproduce the behavior:
Bundle generated without select clause is loaded as spected by method namedQueryGet().
Same Bundle generated with select produce error in client load time.
Loaded correctly.
    const best = await db.collection('scores')
      .orderBy(scoreName)
      .limit(100)
      .get();

    // Build the bundle from the query results
    const bundleBuffer = db.bundle()
      .add(scoreName+"_query", best)
      .build();

Dont load
    const best = await db.collection('scores')
      .orderBy(scoreName)
      .limit(100)
      .select("nickname",scoreName)
      .get();

    // Build the bundle from the query results
    const bundleBuffer = db.bundle()
      .add(scoreName+"_query", best)
      .build();

Flutter doctor
[✓] Flutter (Channel stable, 2.2.2, on macOS 11.4 20F71 darwin-x64, locale en-ES)
    • Flutter version 2.2.2 at /Users/rubenleal/Projects/flutter
    • Framework revision d79295af24 (8 days ago), 2021-06-11 08:56:01 -0700
    • Engine revision 91c9fc8fe0
    • Dart version 2.13.3

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/rubenleal/Library/Android/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Users/rubenleal/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5, Build version 12E262
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] VS Code (version 1.57.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 11.4 20F71 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 91.0.4472.106
    ! Error: iPad de Ruben is not connected. Xcode will continue when iPad de Ruben is connected. (code -13)

• No issues found!

Flutter dependencies
Dart SDK 2.13.3
Flutter SDK 2.2.2
whynotone 0.0.6+6

dependencies:
- cloud_firestore 2.2.2 [cloud_firestore_platform_interface cloud_firestore_web firebase_core firebase_core_platform_interface flutter meta]
- cloud_functions 1.1.2 [cloud_functions_platform_interface cloud_functions_web firebase_core firebase_core_platform_interface flutter]
- cupertino_icons 1.0.3
- firebase_analytics 8.1.2 [firebase_analytics_platform_interface firebase_analytics_web firebase_core flutter meta]
- firebase_auth 1.4.1 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta]
- flame 1.0.0-releasecandidate.11 [flutter meta ordered_set vector_math]
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]
- flutter_localizations 0.0.0 [flutter intl characters clock collection meta path typed_data vector_math]
- forge2d 0.7.1 [vector_math]
- google_mobile_ads 0.13.0 [meta flutter]
- google_sign_in 5.0.4 [google_sign_in_platform_interface google_sign_in_web flutter meta]
- in_app_purchase 1.0.5 [flutter in_app_purchase_platform_interface in_app_purchase_android in_app_purchase_ios]
- intl 0.17.0 [clock path]
- shared_preferences 2.0.6 [meta flutter shared_preferences_platform_interface shared_preferences_linux shared_preferences_macos shared_preferences_web shared_preferences_windows]
- sign_in_with_apple 3.0.0 [flutter meta]
- tiled 0.6.0 [flutter flame archive xml vector_math]

dev dependencies:
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher meta source_span stream_channel string_scanner term_glyph typed_data]

transitive dependencies:
- _fe_analyzer_shared 22.0.0 [meta]
- analyzer 1.7.1 [_fe_analyzer_shared cli_util collection convert crypto glob meta package_config path pub_semver source_span watcher yaml pedantic]
- archive 3.1.2 [crypto path]
- args 2.1.1
- async 2.6.1 [meta collection]
- boolean_selector 2.1.0 [source_span string_scanner]
- characters 1.1.0
- charcode 1.2.0
- cli_util 0.3.0 [meta path]
- clock 1.1.0
- cloud_firestore_platform_interface 5.1.2 [collection firebase_core flutter meta plugin_platform_interface]
- cloud_firestore_web 2.1.2 [cloud_firestore_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js]
- cloud_functions_platform_interface 5.0.7 [firebase_core flutter meta plugin_platform_interface]
- cloud_functions_web 4.0.9 [cloud_functions_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js]
- collection 1.15.0
- convert 3.0.0 [typed_data]
- coverage 1.0.3 [args logging package_config path source_maps stack_trace vm_service]
- crypto 3.0.1 [collection typed_data]
- fake_async 1.2.0 [clock collection]
- ffi 1.1.2
- file 6.1.2 [meta path]
- firebase 9.0.1 [http http_parser js]
- firebase_analytics_platform_interface 2.0.1 [flutter meta]
- firebase_analytics_web 0.3.0+1 [firebase firebase_analytics_platform_interface flutter flutter_web_plugins meta]
- firebase_auth_platform_interface 4.3.1 [firebase_core flutter meta plugin_platform_interface]
- firebase_auth_web 1.3.1 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser intl js meta]
- firebase_core 1.3.0 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_core_platform_interface 4.0.1 [collection flutter meta plugin_platform_interface]
- firebase_core_web 1.1.0 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- flutter_web_plugins 0.0.0 [flutter js characters collection meta typed_data vector_math]
- glob 2.0.1 [async collection file path pedantic string_scanner]
- google_sign_in_platform_interface 2.0.1 [flutter meta quiver]
- google_sign_in_web 0.10.0 [google_sign_in_platform_interface flutter flutter_web_plugins meta js]
- http 0.13.3 [async http_parser meta path pedantic]
- http_multi_server 3.0.1 [async]
- http_parser 4.0.0 [charcode collection source_span string_scanner typed_data]
- in_app_purchase_android 0.1.2 [collection flutter in_app_purchase_platform_interface json_annotation meta test]
- in_app_purchase_ios 0.1.0+1 [collection flutter in_app_purchase_platform_interface json_annotation meta test]
- in_app_purchase_platform_interface 1.0.0 [flutter plugin_platform_interface]
- io 1.0.0 [meta path string_scanner]
- js 0.6.3
- json_annotation 4.0.1
- logging 1.0.1
- matcher 0.12.10 [stack_trace]
- meta 1.3.0
- mime 1.0.0
- node_preamble 2.0.1
- ordered_set 3.1.0
- package_config 2.0.0 [path]
- path 1.8.0
- path_provider_linux 2.0.0 [path xdg_directories path_provider_platform_interface flutter]
- path_provider_platform_interface 2.0.1 [flutter meta platform plugin_platform_interface]
- path_provider_windows 2.0.1 [path_provider_platform_interface meta path flutter ffi win32]
- pedantic 1.11.0
- petitparser 4.1.0 [meta]
- platform 3.0.0
- plugin_platform_interface 2.0.0 [meta]
- pool 1.5.0 [async stack_trace]
- process 4.2.1 [file path platform]
- pub_semver 2.0.0 [collection]
- quiver 3.0.1 [matcher]
- shared_preferences_linux 2.0.0 [flutter file meta path path_provider_linux shared_preferences_platform_interface]
- shared_preferences_macos 2.0.0 [shared_preferences_platform_interface flutter]
- shared_preferences_platform_interface 2.0.0 [flutter]
- shared_preferences_web 2.0.0 [shared_preferences_platform_interface flutter flutter_web_plugins meta]
- shared_preferences_windows 2.0.0 [shared_preferences_platform_interface flutter file meta path path_provider_platform_interface path_provider_windows]
- shelf 1.1.4 [async collection http_parser path stack_trace stream_channel]
- shelf_packages_handler 3.0.0 [path shelf shelf_static]
- shelf_static 1.0.0 [convert http_parser mime path shelf]
- shelf_web_socket 1.0.1 [shelf stream_channel web_socket_channel]
- sky_engine 0.0.99
- source_map_stack_trace 2.1.0 [path stack_trace source_maps]
- source_maps 0.10.10 [source_span]
- source_span 1.8.1 [collection path term_glyph]
- stack_trace 1.10.0 [path]
- stream_channel 2.1.0 [async]
- string_scanner 1.1.0 [charcode source_span]
- term_glyph 1.2.0
- test 1.16.8 [analyzer async boolean_selector collection coverage http_multi_server io js node_preamble package_config path pedantic pool shelf shelf_packages_handler shelf_static shelf_web_socket source_span stack_trace stream_channel typed_data web_socket_channel webkit_inspection_protocol yaml test_api test_core]
- test_api 0.3.0 [async boolean_selector collection meta path source_span stack_trace stream_channel string_scanner term_glyph matcher]
- test_core 0.3.19 [analyzer async args boolean_selector collection coverage glob io meta package_config path pedantic pool source_map_stack_trace source_maps source_span stack_trace stream_channel vm_service yaml matcher test_api]
- typed_data 1.3.0 [collection]
- vector_math 2.1.0
- vm_service 6.2.0
- watcher 1.0.0 [async path pedantic]
- web_socket_channel 2.1.0 [async crypto stream_channel]
- webkit_inspection_protocol 1.0.0 [logging]
- win32 2.1.5 [ffi]
- xdg_directories 0.2.0 [meta path process]
- xml 5.1.2 [collection meta petitparser]
- yaml 3.1.0 [collection source_span string_scanner]

Hi @rusoleal
It's unclear from your code example what the select method is supposed to do or where you are using namedQueryGet.
Could you provide a minimal complete reproducible code sample?
Thank you

Hi @markusaksli-nc
I try to explain better what is happening.
Im generating (just for testing purposes) two different bundles.
// bundle with all fields
https://whynotone-73e13.web.app/functions/global
generated by function:
async function generateBundle(scoreName) {
const db = admin.firestore();
const best = await db.collection('scores')
  .orderBy(scoreName,"desc")
  .limit(100)
  //.select("nickname",scoreName)
  .get();

// Build the bundle from the query results
const bundleBuffer = db.bundle()
  .add(scoreName, best)
  .build();
return bundleBuffer;

}
and same bundle with select clause just to get only "nickname" and "score" fields.
https://whynotone-73e13.web.app/functions/global_select
generated by function:
async function generateBundleSelect(scoreName) {
const db = admin.firestore();
const best = await db.collection('scores')
  .orderBy(scoreName,"desc")
  .limit(100)
  .select("nickname",scoreName)
  .get();

// Build the bundle from the query results
const bundleBuffer = db.bundle()
  .add(scoreName+"_select", best)
  .build();
return bundleBuffer;

}
If you try to read first bundle there is no problem. This is my load method...
Future<QuerySnapshot<Map<String,Object?>>> loadScores(String scoreName) async {
var url = Uri.parse("https://whynotone-73e13.web.app/functions/"+scoreName);
var response = await http.get(url);

// http.get(url).then((http.Response response) async {
  Uint8List buffer = Uint8List.fromList(response.body.codeUnits);
  var task = FirebaseFirestore.instance.loadBundle(buffer);
  await task.stream.last;

  var toReturn = await FirebaseFirestore.instance
      .namedQueryGet(scoreName,options: const GetOptions(source:Source.cache));
  print("documents loaded in "+scoreName+": "+toReturn.size.toString());

  scores[scoreName] = toReturn;

  return toReturn;
//});

}
But unknown exception if you try to load second bundle in method FirebaseFirestore.instance.namedQueryGet(...)
Thanks for your assistance

I'm similarly seeing the Unknown error or an error from a different error domain. when trying to read my bundle on iOS. Public bundle is available here: https://us-central1-pollyn-prod.cloudfunctions.net/categoriesBundle
It works fine on Flutter web, but on iOS I get this exception:

Code I execute on the client:
LoadBundleTask loadBundleTask =
        FirebaseFirestore.instance.loadBundle(bundleResp.bodyBytes);

await loadBundleTask.stream.last; // Throws exception

Have Same error

Debug error log for iOS:
[Firebase/Firestore][I-FST000001] Failed to GetNextElement() from bundle with error Queries with 'select' statements are not supported in bundles

Debug error log for android:
[Firestore]: Loading bundle failed : java.lang.IllegalArgumentException: Queries with 'select' statements are not supported by the Android SDK

Neither platform support select queries. Web does which is why it works for web.


iOS (Safari) - Bullet points for columns 2/3 of homepage links do not appear

The bullet points for the items in columns 2 and 3 on the homepage on iOS Safari are not appearing in portrait or landscape orientation. The bullet points for column 1 do appear regardless of orientation.
@irfanpirbhai

Also observed this issue on Chrome in Windows 7 on all screen resolutions. Did not see this issue on Mozilla Firefox on the same computer in all resolutions.


fix readme

What if we don't need to describe the API in markdown and can't suggest checking it in Swagger


How can one disambiguate a string that looks like a date?

Hello,
console.log(require("yaml").stringify({a: "1", b: "b", c: "2012-10-12"}))

returns
a: "1"
b: b
c: 2012-10-12

Would there be a way to keep the value of c quoted so that it wouldn't be interpreted as a timestamp by parsers?

The yaml stringifier verifies that its output will also be parsed to the same type as its input; this is why the string "1" gets stringified as "1", rather than just 1. What's happening here with "2012-10-12" is that the re-parsing test is defaulting to use the YAML core schema, which does not include timestamps as a data type, and hence allows the default unquoted style to be used.
In order to make sure that your date-ish string also gets quoted, the most appropriate thing to do is to specify either the schema or version in your options:
YAML.stringify(obj, { version: '1.1' })

To really fine-tune your stringification, you'll need to construct a YAML.Document and set the type value for your scalar nodes.

Another great thoroughly detailed answer! Thanks.


Hypothesis: Using tags as a search term will drive related content for the page

Description
Let's test whether using the tags defined in the docs as a search query using ORs is enough to drive related content. This PR will also include boosting tags fields.
Relevant links

Swiftype Search docs

Merged to search-research


<IP_ADDRESS> apoc.export.json.query does not allow ARRAY_JSON

 Issue by Rezu
Thursday Nov 04, 2021 at 23:51 GMT
Originally opened as https://github.com/neo4j-contrib/neo4j-apoc-procedures/issues/2282

Greetings,
Cross posting with Neo4j forum: https://community.neo4j.com/t/apoc-3-5-0-3-exact-syntax-for-jsonformat-array-json/46718
I am trying to pin down the exact apoc syntax for producing array json using apoc <IP_ADDRESS>. I am having a very hard time even finding apoc <IP_ADDRESS> documentation.
Here is what I am trying, it does not work:
CALL apoc.export.json.query( "Match (b:Beer) Return b.name as name Limit 5", "bnl.json", {config:{jsonFormat:'ARRAY_JSON'}})
I have tried all kinds of iterations in the config param, but nothing seems to work and the only real, with example, type documentation I can find is for apoc 4.*. I can find nothing for 3.5.
Of note, the following works for 4.1.9 Community, but I want it to work in 3.5 Community:
CALL apoc.export.json.query( "Match (b:Beer) Return b.name as name Limit 5", "bnl.json", {jsonFormat:'ARRAY_JSON'})
Grateful for any help.
Many Thanks,
Keith

Unfortunately this configuration has only been implemented since apoc 4.1+, because 3.5 was out of support.
Feel free to reopen the issue if you have problem with newer versions.


🐛 Further installation fixes

Description
The goal of this PR is to identify and fix why

cda-tum/mqt-qcec#355
cda-tum/mqt-qmap#418
cda-tum/mqt-ddsim#336

are all having problems with the static libraries deployed with v2.2.2. of mqt-core.
I have the slight feeling that shared libraries might actually be necessary to get this working.
Currently known issues:

Due to some unknown reason, some of the symbols are undefined and cannot be found in the shared Python module library.
Due to some also unknown reason, the Windows wheels are installed in a Debug configuration which causes incompatibilities when trying to compile them together with Release build libraries.

Checklist:

[ ] The pull request only contains commits that are related to it.
[ ] I have added appropriate tests and documentation.
[ ] I have made sure that all CI jobs on GitHub pass.
[ ] The pull request introduces no new warnings and follows the project's style guidelines.

Closing this for now as it seems the preferred course of action is to go with shared libraries, so there is no need to keep this open.


Initial script for generating images using a python script instead of…

This PR adds a Python script offering an alternative to the node script  for generating images with Verovio outside Docker.
The Python scripts dependencies are standard ones plus:
import verovio

Both can be installed with pip
The script can be run through a new ant a new target generate-images-py (guidelines should have been built beforehand):
ant generate-images-py

@lpugin looks like there's a merge conflict now. Could you please resolve this?

@musicEnfanthen is this also tested in the docker-mei container?

@bwbohl I was able to execute the target from within docker-mei, yes.

@ahankinson Are your requested changes addressed?

Many thanks for this I think it's much better to have a script for generating the images inside this repo and should even replace the other ant target and node.js method.


Armhf architecture files added from Raspbian Jessie - yet again

Please see pull request 61 for reference.
The Ubuntu cross compilation  gcc-arm-linux-gnueabihf fails to compile working libtuv for Rasperry Pi 2 Raspbian Jessie.
Ubuntu Precise fail to compile libtuv because it uses older cmake. Ubuntu Trusty and Xenial compile libtuv but executable generates SEGFAULT during run. The tools fail to compile hello world also.
The only working with Raspbian cross-compiler for Ubuntu is stored by RaspberryPi team at GITHUB.
It is in folder for 64-bit Ubuntu:
    tools/arm-bcm2708/gcc-linaro-arm-linux-gnueabihf-raspbian-x64

When you reconfigure your machine to use this compiler:
    $export PATH="tools/arm-bcm2708/gcc-linaro-arm-linux-gnueabihf-raspbian-x64/bin:$PATH"

You can compile it with makefile:
    TUV_PLATFORM=armhf-linux TUV_BOARD=rpi2 make

The GCC linaro toolchain fails to enable librt by default so it was necessary to add flag -ltr.

Yes, Travis is happy :)

Please don't do new PR always when you want to update it. Just update your branch and the PR will be updated automatically.

Thank you for good advice.

Dear glistening, thank you for review. I double checked compilation options and I managed to compile at Raspberry Pi Raspbian Jessie using arm-linux-gnueabihf-gcc compiler. The key is armhf architecture flag. I have to used it because for arm architecture I get Illegal instruction error during libtubtester. I updated Wiki: https://github.com/Samsung/libtuv/wiki/How-to-Build/_compare/ee0ac5e0eb23925aca717dbb8b0082b4f679cc25...5ebc64ed1365c15f8a173a7017521acdbd362cdd

Please see:
https://github.com/Samsung/libtuv/pull/65
Glistening noticed that two cmake flags set in config_armhf-linux.cmake are not used during build:
CMAKE_SYSTEM_NAME
CMAKE_SYSTEM_PROCESSOR

I removed both from armhf configuration and it compiles for RPi2 both in cross and normal build.
The only flag, which has to be set in this file is CMAKE_C_COMPILER. It is used by CMakeForceCompiler cmake scripts during cross compilation at PC.
I analysed more deeply option_amrhf-linux.cmake_. The flag -lrt is mandatory for all armhf devices, compiled with linaro compiler and it will not cause any negative side effects for other armhf compilers so in my opion it is not necessary to check for rpi2 board here.
It is possible to compile/cross compile for RPi2 with just platform flag:
TUV_PLATFORM=armhf-linux make

Is there anything more I can do to improve this pull request?


[Feature] Integrate KubeRay with Kubeflow

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
KubeRay can be installed with other OSS ML Ops products (like Kubeflow) in the same Kubernetes cluster to provide an integrated platform.
Some benefits provided by Kubeflow that can be complementary to KubeRay:

User profiles (access control and resource isolation)
Authentication/authorization support
Jupyter notebook integration

I have a blog post (coming soon) that discusses these ideas in more detail. Would be great to work with the KubeRay community to make this a long-term supported solution.
Use case
No response
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

For reference, @richardsliu's blogpost is live here: https://cloud.google.com/blog/products/ai-machine-learning/build-a-ml-platform-with-kubeflow-and-ray-on-gke !
The goal of a Kubeflow/KubeRay integration would be to simplify the management of the components described in the blog. Let's use this thread to discuss implementation ideas.
cc @cadedaniel @sublimotion @zhe-thoughts @ericl @richardliaw


[imgui] Set C++ 11 standard in CMakeLists.txt

Is your feature request related to a problem? Please describe.
When compiling imgui with vcpkg on Ubuntu Xenial the compiler rightfully complains about needing C++ 11 for constexpr which is used in imgui code.
Proposed solution
The CMakeLists.txt should set the compiler flags for C++ 11, as the code contains C++ 11 features.
Describe alternatives you've considered
I tried setting CMAKE_CXX_STANDARD=11 from the outside (e.g. with cmake -DCMAKE_CXX_STANDARD=11 ....), which should enable C++ 11 in imgui code, but it does not get propagated by vcpkg.
Switching to another compiler so it defaults to C++ 11 might be an last resort alternative.
Additional context
This is the compilation error that I get on a fresh ubuntu:xenial. Well mostly fresh: as vcpkg needs at least cmake-3.7 and ubuntu:xenial does not provide it, cmake-3.8.2 is compiled from source - but that should make no difference on the compilation error:
.../vcpkg/buildtrees/imgui/src/v1.88-34c93572a3.clean/imgui.h:252:5: error: ‘constexpr’ does not name a type
     constexpr ImVec2()                      : x(0.0f), y(0.0f) { }
     ^
.../vcpkg/buildtrees/imgui/src/v1.88-34c93572a3.clean/imgui.h:252:5: note: C++11 ‘constexpr’ only available with -std=c++11 or -std=gnu++11
.../vcpkg/buildtrees/imgui/src/v1.88-34c93572a3.clean/imgui.h:253:5: error: ‘constexpr’ does not name a type
     constexpr ImVec2(float _x, float _y)    : x(_x), y(_y) { }
     ^
.../vcpkg/buildtrees/imgui/src/v1.88-34c93572a3.clean/imgui.h:253:5: note: C++11 ‘constexpr’ only available with -std=c++11 or -std=gnu++11

... goes on forever...

There is nothing fresh about Ubuntu Xenial (16.04) ;-)
And vcpgk will need and use a much fresher CMake (3.22) to build ports. You can use CMake 3.7 for user project but YMMV.

Is it better to use cxx_std_11 meta feature instead of locking the version number? This should indicate cmake to use at least 11 instead of exactly 11. Honest question, I do not know.

There is nothing fresh about Ubuntu Xenial (16.04) ;-) And vcpgk will need and use a much fresher CMake (3.22) to build ports. You can use CMake 3.7 for user project but YMMV.

Yea, Xenial is truly not that fresh in itself. But officially supported by vcpkg^^. I think you need at least cmake 3.7 for vcpkg to automatically download cmake 3.22 which it then uses.


backport: bitcoin#18044, #18244, #19569, #19670, #19710, #19730, #19818

Issue being fixed or feature implemented
Just regular bitcoin backports, mostly from v21
What was done?

bitcoin/bitcoin#18044
bitcoin/bitcoin#19569
bitcoin/bitcoin#19730
bitcoin/bitcoin#19710
bitcoin/bitcoin#18244
bitcoin/bitcoin#19670
bitcoin/bitcoin#19818

How Has This Been Tested?
Run unit/functional tests
note for reviewers:

bitcoin#19552 is full because we don't have fee-filter msg, but this backport still have useful code (https://github.com/bitcoin/bitcoin/pull/19730 depends on it for example)
bitcoin#18044 and bitcoin#19569 has witness related code, but for sack of unification with bitcoin codebase I backported some related refactorings/variable renames/etc

Breaking Changes
N/A
Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[x] I have assigned this pull request to a milestone

@knst knst force-pushed the bp-v21-p13 branch from fdf8df0 to 007da48

rebase to tip of develop and drop 19552

@knst knst force-pushed the bp-v21-p13 branch from 007da48 to 7ed162b
@knst knst force-pushed the bp-v21-p13 branch from 7ed162b to ca32862

address review comments


Add api for read finalize mapping

Motivation
Add api for read finalize mapping

Thank you @ghostant-1017 !
#2461 has a more complete implementation, I will close this one in favor of that one.

We will prioritize getting this feature in quickly 🙏


Make python3 compatible

Also +1, though the same caveat applies that it's been over 3 years since I had a working build environment for Debathena.
Thanks for doing this work, great to see new folks committing!


[RFC] standardize reporting of async errors

Standardize reporting of errors to client
tl;dr: Let's use Failure + a new error RPC notification to report relevant errors to the client.
Error handling in xi-core is currently ad-hoc at best. We would like to propose a standard core-client RPC notification for reporting core errors to the client.
Earlier issues: #434, #438, #519, #484
Motivation
Although there is a tentative mechanism for returning errors during RPC requests, there is currently no way to report an error that occurs asyncronously.
Such errors could be fatal or recoverable, but in both cases the client should (probably) be notified. For fatal errors the client should be notified so that it can perform any necessary cleanup, write log files, notify the user, restart the connection, or exit cleanly; and with recoverable errors so that it can notify the user, solicit actions, and respond appropriately.
Recoverable Errors Example
As of #538, xi-core will watch open files for external changes. If a file is modified by another process, xi-core will check if the user has modified the local copy. If they have, a request to save the file will fail, because we want to be very defensive about possibly overwriting user data.
In theory, we could introduce a mechanism to present a multi-option modal dialog to the user (#438); but the solution I would prefer is to report this error back to the client, and allow the client to determine the appropriate response.
This allows different clients to handle recoverable errors in the manner most appropriate for their particular needs. In this example case, the client may end up prompting the user for input, but it can do that without the knowledge of xi-core, which saves us from the complications around sync/async response handling required by a dialog RPC.
Implementation
Portocol
This change involes a new core -> client RPC method, which would look something like this:
{
  "method": "error",
  "params": {
    "view_id": "view-id-1", // optional
    "code": 420, // from a canonical list of errors codes
    "msg": "Insufficient chill", // a human readable message.
  }
}

Fatal errors could be identified by a reserved block of error codes, or through a separate "fatal_error" method; or we could add a "disconnect" method that core sends when it is shutting down, which could return an exit code. In the long term, xi-core should be very difficult to crash.
xi-core
What little error reporting currently exists in xi-core is entirely ad-hoc, and involves manually sending the 'alert' rpc method with some custom message. We propose standardizing the handling of errors via the failure crate's Error + ErrorKind pattern. Our custom ErrorKind would enumerate distinct user-expressible errors; for instance an io::Error encountered while loading a preference file would be a different ErrorKind than an io::Error encountered while trying to save a file.
Any method which could fail non-fatally would return a Result; errors will be passed back to the top level handler methods, which will report them to the client automatically.
Questions

How do we want to identify fatal errors? This is actually a concrete problem; core crashes currently hang the runloop without notifying the client, which is less than ideal. This is partly a limitation of the current runloop implementation, our read thread will be blocked on io when our main thread has crashed, but the main thread joins the read thread and doesn't return (#434). While this will be fixed eventually, It probably makes sense for clients to be notified when core has exited abnormally.

Another question is whether we could wrap the underlying RPC errors behind
the same unified error.  Probably not important for front end because, at
least currently, those don’t use rust but if we have requests to the front
end from core core could have a uniform way of handling.  Also, it
simplifies the handling in core if it’s propogaring an RPC error from
somewhere (remote Xi-core, plugins etc) to the front end.
As for fatality, having an is_error function could be used for that.
Alternatively, there could be an is_alive ping the front end could send and
all the processes (core, plugins, remote core etc) would reply
success/error.  Alternatively the core could check the liveliness of
plugins via os APIs and let the front end know about their lifetime.
Similarly the front end could just look for the core’s pix thereby knowing
that it is going to receive notifications about crashes.  Where it can get
tricky potentially is if plugin processes become dynamic in lifetime to
reduce memory/cpu pressure we’ll need a way to indicate graceful shutdown
but I think that’s a tractable problem.
Tldr: my recommendation would be to not worry about trying to send a
message right before process death
On Thu, Mar 8, 2018 at 1:26 PM Colin Rofls<EMAIL_ADDRESS>wrote:

Standardize reporting of errors to client
tl;dr: Let's use Failure https://github.com/withoutboats/failure + a
new error RPC notification to report relevant errors to the client.
Error handling in xi-core is currently ad-hoc at best. We would like to
propose a standard core-client RPC notification for reporting core errors
to the client.
Earlier issues: #434 https://github.com/google/xi-editor/issues/434,
#438 https://github.com/google/xi-editor/issues/438, #519
https://github.com/google/xi-editor/issues/519, #484
https://github.com/google/xi-editor/issues/484
Motivation
Although there is a tentative mechanism for returning errors during RPC
requests, there is currently no way to report an error that occurs
asyncronously.
Such errors could be fatal or recoverable, but in both cases the client
should (probably) be notified. For fatal errors the client should be
notified so that it can perform any necessary cleanup, write log files,
notify the user, restart the connection, or exit cleanly; and with
recoverable errors so that it can notify the user, solicit actions, and
respond appropriately.
Recoverable Errors Example
As of #538 https://github.com/google/xi-editor/pull/538, xi-core will
watch open files for external changes. If a file is modified by another
process, xi-core will check if the user has modified the local copy. If
they have, a request to save the file will fail, because we want to be very
defensive about possibly overwriting user data.
In theory, we could introduce a mechanism to present a multi-option modal
dialog to the user (#438 https://github.com/google/xi-editor/issues/438);
but the solution I would prefer is to report this error back to the client,
and allow the client to determine the appropriate response.
This allows different clients to handle recoverable errors in the manner
most appropriate for their particular needs. In this example case, the
client may end up prompting the user for input, but it can do that without
the knowledge of xi-core, which saves us from the complications around
sync/async response handling required by a dialog RPC.
Implementation Portocol
This change involes a new core -> client RPC method, which would look
something like this:
{
"method": "error",
"params": {
"view_id": "view-id-1", // optional
"code": 420, // from a canonical list of errors codes
"msg": "Insufficient chill", // a human readable message.
}
}
Fatal errors could be identified by a reserved block of error codes, or
through a separate "fatal_error" method; or we could add a "disconnect"
method that core sends when it is shutting down, which could return an exit
code. In the long term, xi-core should be very difficult to crash.
xi-core
What little error reporting currently exists in xi-core is entirely
ad-hoc, and involves manually sending the 'alert' rpc method with some
custom message. We propose standardizing the handling of errors via the failure
crate https://github.com/withoutboats/failure's Error + ErrorKind
pattern https://boats.gitlab.io/failure/error-errorkind.html. Our
custom ErrorKind would enumerate distinct user-expressible errors; for
instance an io::Error encountered while loading a preference file would
be a different ErrorKind than an io::Error encountered while trying to
save a file.
Any method which could fail non-fatally would return a Result; errors will
be passed back to the top level handler methods, which will report them to
the client automatically.
Questions

How do we want to identify fatal errors? This is actually a
concrete problem; core crashes currently hang the runloop without notifying
the client, which is less than ideal. This is partly a limitation of the
current runloop implementation, our read thread will be blocked on io when
our main thread has crashed, but the main thread joins the read thread and
doesn't return (#434 https://github.com/google/xi-editor/issues/434).
While this will be fixed eventually, It probably makes sense for clients to
be notified when core has exited abnormally.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/xi-editor/issues/543, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMSRxrN2pqRNvt2k3ViB5K25UESsvkMks5tcaIBgaJpZM4SjXzT
.

Not sure I totally understand the first point; are you talking about a unified Error type? We currently have something like this (in rust/rpc/src/error.rs) but it only really applies to synchronous requests, which require a return value. The overwhelming majority of RPC methods we use are asynchronous, though; the main point of this RFC is to standardize error handling in that case.
I think you're right about the fatal case. Including it in this discussion muddies the waters; it's mostly just a frustration that core hangs instead of exiting after a panic right now, but that's a distinct issue.

I think my point is that explicit error codes as codified in the RFC for
async rpc should be unified with other common error types (Json fails to
decode/encode, RPC failure of some kind etc).  It’s probably an
implementation detail only relevant to rust though.
As for fatal, one thought I had is that Xi-core death must be the easiest
problem since it should result in the IpC channel (TCP?) being terminated
and the front end getting notified.  It’s a harder problem more generally
if you care about the front end getting notified about plug-in deaths (or
remote problems for remote editing)
On Thu, Mar 8, 2018 at 7:07 PM Colin Rofls<EMAIL_ADDRESS>wrote:

Not sure I totally understand the first point; are you talking about a
unified Error type? We currently have something like this (in
rust/rpc/src/error.rs
https://github.com/google/xi-editor/blob/master/rust/rpc/src/error.rs)
but it only really applies to synchronous requests, which require a return
value. The overwhelming majority of RPC methods we use are asynchronous,
though; the main point of this RFC is to standardize error handling in that
case.
I think you're right about the fatal case. Including it in this discussion
muddies the waters; it's mostly just a frustration that core hangs instead
of exiting after a panic right now, but that's a distinct issue.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/google/xi-editor/issues/543#issuecomment-371699544,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMSR5v0RVH64cMTVlq4Z9rSec7Luuq-ks5tcfIEgaJpZM4SjXzT
.

You're right about the fatal case, in theory; in practice xi-core is bad at actually exiting even when the main thread has crashed, although that is approximately resolved in #546.
There's some subtlety around handling of errors that result from json parsing etc. The JSON-RPC spec does not define any mechanism for communicating errors that occur when handling an async RPC calls ('notifications'), although errors in sync RPC calls ('requests') are defined. I always thought this was an iffy design choice, however. We've in general tried to stay pretty true to the spec, but I'm not opposed to handling RPC-level errors and client level errors through a shared mechanism.
Notifying the client of plugin termination isn't too tricky, since core necessarily notices if either the remote connection closes or the thread crashes, and in both cases can notify the client; this works currently; if you do something that crashes syntect, the checkmark beside it's name in the plugins menu should disappear, although I won't promise this is currently working.


Feature Request: Scrobbler support for Libre.fm, Last.fm, ...

It would be great if scrobbling support could be added to your CleverStyle-Music player.
http://www.last.fm/api/authentication
http://www.last.fm/api/scrobbling
If that feature could be useful for your CleverStyle-Music player, i maybe could support with coding.

If someone needs this - it will be useful. Feel free to send pull request or ask questions, any help is highly appreciated.


Support Non-PlainText Secret Format for Container Repository Login

Hello, we are using this library to copy containers from a private container repository (Artifactory) to AWS ECS. We would like to re-use our existing secrets rather than creating something new for this functionality. Specifically, we already have secrets to allow for ECS to authenticate with a private registry based on the following documentation:
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/private-auth.html
This requires that the secret be a JSON object with "username" and "password" properties. Would it be possible to update the library to support reading a secret of this type, object, rather than plain-text?
{   "username" : "privateRegistryUsername",   "password" : "privateRegistryPassword" }

@Bbuff101 Just to clarify, are you only wanting to be able to send a JSON string as credentials or are you wanting JSON support for the SecretsManager Secret?

@Bbuff101 Just to clarify, are you only wanting to be able to send a JSON string as credentials or are you wanting JSON support for the SecretsManager Secret?

Hi @cbentkowski , I would like to pass a secret name or ARN which contains as a secret value the JSON representation of a username and password, similar to how ECS functions to pull containers from a private registry. I do not want to pass the JSON secret value itself into the CDK resource. Does that help?

Ok, similar to the ARN credentials that it already accepts, but the return from the ARN will be JSON formatted text. I've got a JSON parser built, but let me work on detecting JSON string formatted credentials from the ARN and see what I can come up with.

Ok, similar to the ARN credentials that it already accepts, but the return from the ARN will be JSON formatted text. I've got a JSON parser built, but let me work on detecting JSON string formatted credentials from the ARN and see what I can come up with.

Yes, thanks, @cbentkowski ! I did see your PR, so if I can be of any additional help, please let me know.


Use absolute imports for python2

See http://stackoverflow.com/a/11741846/1234176
and http://stackoverflow.com/a/33744115/1234176

Thanks very much, I will need to test this thoroughly :-)

merged locally with other PR, thanks.


[CPI] Add self-signed certificate to CPI configuration, bsc#1101973

I've change this according to @kiall wishes, but I think that it would be better to use System wide certificates feature for uploading CPI certificate.

I've change this according to @kiall wishes, but I think that it would be better to use System wide certificates feature for uploading CPI certificate.

This does use the system wide CAs feature - all of those uploaded CAs are bundled into /etc/ssl/ca-bundle.pem. However, it also contains the distro provided CA. We can't assume that just because a system wide cert was uploaded, that this is the cert required for OpenStack - using the bundle ensures this should always work.

Guys - this is STILL a problem.
@ajaeger
The config disappears and I have to add manually the ca-file entry manually...

Hey -
Today I built another cluster. Installed CaaSPv3, registered and updated the admin. Performed a reboot. Then I Accepted the other minions and bootstrapped. The openstack-config file did not have the ca-file entry, some nodes don't even have the openstack-config file at all and the bootstrap is not finishing, likely due to this.


(fix) enable sourcemaps in production build

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix: sourcemaps are no longer enabled by default in the UglifyJS Webpack plugin.

What is the current behavior? (You can also link to an open issue here)
No source maps are generated in a production build.

What is the new behavior (if this is a feature change)?
Source maps are correctly generated.

Other information:

@colinskow - See #1241
This is not something that should be on by default but opt in should a developer choose or need to push production sourcemaps.

As an alternative, An off by default configurable flag would be fine if the idea is to not have to deal with overwriting the config setting. i.e --sourcemaps on the build call like env.

Just to help other developers who pull their hair out trying to get the source maps on production build: this pull request is not sufficient anymore, as recent updates to OptimizeJsPlugin, which is included by angular-starter broke SourceMaps generation: https://github.com/vigneshshanmugam/optimize-js-plugin/issues/7

Developers that need sourcemaps in a production build should probably disable the optimize-js plugin then.

Thanks !


Fixed global parameter defindfinitions

Some "global" parameters defined in Makefile.machine.include and read
from the rom had no effect in the hardware when changed.

Fixed "global" parameters, now affect hardware
Renamed parameters
Reformatted

Passes regression on timing_v0_8_4 and 4x4_fast_n_fake

This is ready for review


Translations

It would be great to be able to change the default text strings to be able to translate them.
As far as I see, there are these static strings:
Title of the Buttons on the Bottom:

"Next"
"Previous"

Title of the right Sidebar:

"On this page"

Options on the Theme toggle:

"Light"
"Dark"
"System"

Titles on the admonitions:

"Note"
"Info"
"Tip"
"Warning"
"Danger"
"Experimental"

Search (?):

"Search Documentation"
"No recent searches"
"to select"
"to navigate"
"to close"
"Search by"

Thank you for documenting it all for me, super helpful. I'll create an i18n field on KitDocsLayout now and translate all mentioned strings. I'm not sure we can change Algolia search text? I'll look at the docs.

Added this option in, feel free to test it out and let me know how you go.
Docs Link
Translations Link


Implement fallback for glCopyImageSubData if it's not available

I just got curious, why not to make "software" implementation for blitting? I am writing this because most of Macs (huh.. and mostly everyone behind ogl 4.3) don't have this extension (*_copy_image) to perform hardware buffer copy. This is fairly easy to implement and it will be not necessary to copy buffers using shaders/drawquad every time.
I am currently using this temporary approach (it works great and it's fast, it should show what I want) instead of glCopyImageSubData (in renderer_gl.cpp):
`
                    // SrcFormat = src.m_textureFormat as bimg::TextureFormat::Enum and same with DestFormat
                    const bool bIsColorBuffer = !bimg::isDepth(SrcFormat);
                    const bool bIsStencil = SrcFormat == bimg::TextureFormat::D24S8/* || SrcFormat ==  bimg::TextureFormat::D0S8*/;

                    GLenum Attachment = GL_COLOR_ATTACHMENT0;
                    GLbitfield Mask = GL_COLOR_BUFFER_BIT;
                    if (!bIsColorBuffer && !bIsStencil)
                    {
                        Attachment = GL_DEPTH_ATTACHMENT;
                        Mask = GL_DEPTH_BUFFER_BIT;
                    }
                    else
                    {
                        Attachment = GL_DEPTH_STENCIL_ATTACHMENT;
                        Mask = GL_DEPTH_BUFFER_BIT | GL_STENCIL_BUFFER_BIT;
                    }

                    /** Assume we have created framebuffers before */

                    glBindFramebuffer(GL_FRAMEBUFFER, DestFramebuffer);
                    GL_CHECK(glFramebufferTexture2D(GL_FRAMEBUFFER, Attachment, src.m_target, dst.m_id, 0));
                    glBindFramebuffer(GL_FRAMEBUFFER, SrcFramebuffer);
                    GL_CHECK(glFramebufferTexture2D(GL_FRAMEBUFFER, Attachment, dst.m_target, src.m_id, 0));

                    glDrawBuffer(bIsColorBuffer ? GL_COLOR_ATTACHMENT0 : GL_NONE);
                    glBindFramebuffer(GL_DRAW_FRAMEBUFFER, DestFramebuffer);

                    glReadBuffer(bIsColorBuffer ? GL_COLOR_ATTACHMENT0 : GL_NONE);
                    glBindFramebuffer(GL_READ_FRAMEBUFFER, SrcFramebuffer);

                    GL_CHECK(glBlitFramebuffer(0, 0, src.m_width, src.m_height, 0, 0, dst.m_width, dst.m_height, Mask, GL_NEAREST));
                    // Switch back to the previous framebuffer
                    GL_CHECK(glBindFramebuffer(GL_FRAMEBUFFER, m_currentFbo) );

`

Wanna create PR for this change?

I'll see, Now I need to find a good place where I can create temporary framebuffers for blitting and later remove them.

You can scope them to submit call, on first request it will create them, if resize is needed it will destroy/create new one, and then at the end of submit will destroy them.

Did you figure out how to this properly?


Add support for Linux SAS classes

Linux exports ~5 useful metrics per SAS PHY, which can be useful for debugging SAS performance problems and errors.  I'm planning on adding support for this to node_exporter (see https://github.com/prometheus/node_exporter/issues/2386), but I need to extract information from /sys first before I can do this.
The useful metrics are all in /sys/class/sas_phy, but we need data from /sys/class/sas_end_device, /sys/class/sas_port, and /sys/class/sas_expander in order to make sense of the PHY data and know what's connected to a specific PHY.

Ah, I think I can close this one, but the node exporter issue is still open.  I have the code for that, but I never put a PR together.  I'll work on it soon.

Ah, I think I can close this one, but the node exporter issue is still open.  I have the code for that, but I never put a PR together.  I'll work on it soon.


Change CorePPL stack size and add more particles in experiment

This PR includes https://github.com/miking-lang/miking-benchmarks/pull/27 (only this PR should be merged). In addition to that PR, this one adds more particles for the CorePPL experiment.

I cannot see that this PR has been presented at a Miking meeting. Is that correct?

That's correct (I just created it).


[tests-only]Bump core commit id for tests

Part of: https://github.com/owncloud/QA/issues/753

The PHP code dependencies used for acceptance tests are fetched into vendor-php these days. That was done because "something else" (I don't remember exactly) also used a directory called vendor
I added vendor-php to .gitignore so that I (and other people) don't accidentally commit it after doing some local testing.


[Menu] C2A buttons should be links with chevron

In the mega menu, update the CTA buttons to text with hyperlinks for the following sections:

In the "Overview" section under "SERVICE & SUPPORT,"
In the "Newsroom" and "Events" section under "Company,"

Ours today:

Should be: (original)

@johan-t @jose-correia please have a look this was fixed but is broken again


Numeric field search

Getting this error when searching on a numeric field:
TypeError: item.toLocaleLowerCase is not a function     at Function.isMatch (app.d50f24c….js:3548)     at FuzzySearch.search (app.d50f24c….js:3516)     at VueComponent.activeData (app.d50f24c….js:3278)     at Watcher.get (app.d50f24c….js:35120)     at Watcher.evaluate (app.d50f24c….js:35220)     at VueComponent.computedGetter [as activeData] (app.d50f24c….js:35446)     at Object.get (app.d50f24c….js:34180)     at Proxy.render (app.d50f24c….js:32297)     at VueComponent.Vue._render (app.d50f24c….js:36241)     at VueComponent.updateComponent (app.d50f24c….js:34811)

I never assumed people would want to search in numeric values. I'll update this today/tomorrow and just cast the value to a string. Everything should work after that!

It took me some time to start looking into this, my apologies for that. Now that I have looked into it I've come to the conclusion that it's not as simple as 'just cast everything to a string'. It would slow the library down to check every input on numbers (this would have to happen in nested objects as well). The best thing you can do is manually cast your search array to a string and then run FuzzySearch on it.


Custom function to use spaces for indent

Fixes #2092, #1556
Apparently Github doesn't have a built-in way to just use spaces instead of tabs for indentation. This PR uses a custom script to change that behavior, based on this discussion on the CodeMirror github:
https://github.com/codemirror/codemirror5/issues/988#issuecomment-549644684

Tab: indent using spaces at the current location (will use 1 or 2 spaces, to line up with the next tab boundary)
Tab while text is selected: indent whole line
Shift+Tab : unindent whole line

Also removes the "smartIndent" feature which auto-indents inside HTML blocks when pressing return. Manual indenting and then pressing return will maintain the current indent.
You can test the behavior at https://homebrewery-pr-2839.herokuapp.com/

Looks good to me, both the result and the code (besides that extra layer of indent on the if statement that Eric pointed out).
I do think that this is going to irk someone, but in my opinion it's an improvement.  However, there are likely lots of old brews that get copied (in part or in full) into new brews, so there is going to be this weird sort of hybrid situation that might trip people up.   I don't know if there is a smart way to convert tabs into spaces when pasting into a new brew?  Even if it requires a dialog prompt that asks about it?
In either case, i think it's good to go.


Updated circleci to point to main branch

Updated circleci config to point to main branch instead of master branch

circleci is failing because terraform is looking for the branch with "master", I believe this should fix that.

The conversation can be seen in slack, however the fix was deleting that in circleci and generating a new one. Which means this PR is unrelated to the issue. I'm going to leave this up because it still may be necessary.


Set the controllerTempDir for Self Contained mode

Remoting services require it to be set

Can one of the admins verify this patch?

this is okay to test

retest this please

this is ok to test

Linux Build 2506 is now running using a merge of 6fad7e678b75ec0f3844560a824ee9376c86894b

Core - Full Integration - Windows Build 54 is now running using a merge of 6fad7e678b75ec0f3844560a824ee9376c86894b

Windows Build 2017 is now running using a merge of 6fad7e678b75ec0f3844560a824ee9376c86894b

Core - Full Integration Build 1633 is now running using a merge of 6fad7e678b75ec0f3844560a824ee9376c86894b

Windows Build 2017 outcome was SUCCESS using a merge of 6fad7e678b75ec0f3844560a824ee9376c86894b
Summary: Tests passed: 3403, ignored: 64 Build time: 00:36:29

Linux Build 2506 outcome was SUCCESS using a merge of 6fad7e678b75ec0f3844560a824ee9376c86894b
Summary: Tests passed: 3403, ignored: 64 Build time: 00:42:02

Core - Full Integration Build 1633 outcome was SUCCESS using a merge of 6fad7e678b75ec0f3844560a824ee9376c86894b
Summary: Tests passed: 3056, ignored: 358 Build time: 00:55:09

Core - Full Integration - Windows Build 54 outcome was SUCCESS using a merge of 6fad7e678b75ec0f3844560a824ee9376c86894b
Summary: Tests passed: 3056, ignored: 358 Build time: 00:57:46


Add hyper-active-tab plugin

A plugin to show a symbol next to the active tab.
Link to the repo.

@timothyis
I changed the screenshot to this :


Write unit tests for GPIO HAL

Unit tests for GPIO HAL shall cover every functionality. Attention has to be paid to cover corner cases when configuration spanning over several bitfields has to be cleared before applying new configuration.

Branch: https://github.com/NikodemKastelik/stm32_drv/tree/feature/nk5-prepare-gpio-hal-unit-tests

Decision has been made to include all test-related files in separate repository. Therefore this issue will be closed as invalid.


New style pow

New style pow functions (e.g. ** including PowVarVar, PowVarConst, PowConstVar) to support double backprop.

Thanks for the review. I made changes according to the feedback.

@takagi Thank you again for the comments. I fixed the forward cpu/gpu code separation!
I still have a question regarding only applying y * y for linear functions. The test code is quite complex with repeated similar code. Is there a clean way of applying this twice-differentiability check? Otherwise, I think it is okay to always square the output. Ideally, we could refactor these tests to use less code.

I'll add missing tests for other functions, probably in a different PR when this one is merged.

I had some misunderstanding and, as you say, it is enough to apply y * y to non-linear functions as well as liner ones. It might bring slightly increased numerical error, but which can be ignored.

jenkins, test this please.

LGTM!