Page is constantly reloading when I add web part on the SharePoint Online

Category

[x] Question
[ ] Typo
[ ] Bug
[ ] Enhancement / Suggestion
[ ] Additional article idea

Expected or Desired Behavior
I expect that the content of the web part appears when I add it to the SharePoint Online in my dev tenant.
Observed Behavior
When I add the web part on the modern page, it starts reloading indefinitely.
When I add it on the wiki page, it shows an error.
Steps to Reproduce

yo @microsoft/sharepoint
selecting React in the wizard
gulp trust-dev-cert
gulp serve
web part works perfectly on the bench
gulp package-solution
uploading sppkg file to the app catalog and deploying
gulp serve --nobrowser
adding app onto some /sites/ web site.
trying to add the web part on a modern page
trying to add the web part on a wiki page

Thank you in advance

@shurick81 Same is happening to me. Using RC0

Looking into it, thanks.

In the topic, I mentioned bench. What I meant is my local one, https://localhost:4321/temp/workbench.html.
And now I have also tried to add on the SharePoint Online Bench, I get this:

I also checked the server log (gulp) and there seems to be no requests from the page when I add to SharePoint Online, while adding a web part on the local workbench triggers following requests:
Request: '/dist/hello-world-3.bundle.js'
Request: '/lib/webparts/helloWorld3/loc/en-us.js'

Hi @shurick81 - did you get to the bottom of this? Webpart is throwing an Uglify/Angualr error in Chrome, but continual page reloads in IE.

Just to keep you informed - we're looking into this and a couple other loading issues.  It is our primary focus at the moment.  It's proving tricky.  There are really two issues at play here.  The first is that loading the webpart is generating an error, the second is that the page is refreshing on the error (which then triggers again, etc. etc.)  The 2nd issue has been fixed and should be rolling out to the tenants this week (I think it's currently at 10%).  That should result in only the webpart error itself appearing.  That is something we are investigating.
If you get to just the error showing, can you try this?
1 - Open the dev console (ctrl-F12 now)
2 - Go to the trace tab
3 - Paste the errors that appear in it?
Thanks, Pat.

@shurick81 It probably can't find the resources as it will still be looking in localhost (unless you are running "gulp serve" whilst also looking at the SP online site). You need to specifically run:
gulp clean
gulp build
gulp bundle --ship
gulp package-solution --ship
Also copy contents to /temp/debug (not /dist) to CDN location specified in write-manifest.json.

Hello Pat,
Thanks for your reply.
I use edge and probably 'console' is that what you meant by 'trace tab'. When I just open a /_layouts/workbench.aspx, before I try to add a web part I get this in the console:

At the same time in in the browser area I get this:

After this, when I add web part itself on the bench, console is not updated at all
As for adding the web part on the modern page, When I create a new page, I get this in console:

And when I add the web part on this page, I can see two messages in console after which the navigation is occurring:

Just for information: before I test anything, I run gulp serve --nobrowser so that files are available on my localhost.

Hello Ben,
I run gulp serve --nobrowser everytime so that files are available on my localhost. I am going to try the sequence you suggest, but what do you mean by "write-manifest.json"? I've got HelloWorld3WebPart.manifest.json in my solution and that is its content:
{   "entries": [     {       "entry": "./lib/webparts/helloWorld3/HelloWorld3WebPart.js",       "manifest": "./src/webparts/helloWorld3/HelloWorld3WebPart.manifest.json",       "outputPath": "./dist/hello-world-3.bundle.js"     }   ],   "externals": {},   "localizedResources": {     "helloWorld3Strings": "webparts/helloWorld3/loc/{locale}.js"   } }

You should have a config folder with the weite-manifest.json folder in it.

Thanks, I shouldh've found it before. I will probably try to follow this article then: https://dev.office.com/sharepoint/docs/spfx/web-parts/get-started/deploy-web-part-to-cdn
I mean when you said copy files to CDN, I think this article would be a good one to follow, right?

I tried another deployment scenario and it worked:
"cdnBasePath": "/siteassets//"
and uploaded files on https://.sharepoint.com/siteassets/
So cannot the web part on the SharePoint use js files on my developer machine via https://localhost/...?

Yes it can as long as you "gulp serve" so the node server is running. No good for production though of course.

(For the /siteassets/ location you need to copy the contents of your temp/deploy (not /dist/).

I also expected this to work but it did not work for me for some reasons, as I described earlier. It would be great to understand how can I fix that. It is not that critical since I can use the deployment procedure to site assets, but it would significantly improve my development if I could do it properly. As for the files, yes, I copy from temp/deploy, thanks

This should be sorted out now.


[Bug] relationship with hasMany and subfields (pivot fields) can't delete empty rows

Bug report
What I did
Inside the new demo entries, we have Owner hasMany Pet (with role on the pivot table). I go edit an existing Owner with no pets. Add a Pet. Remove that pet... can't do it, I get a javascript error.
What I expected to happen
No error.
What happened
JS error:

What I've already tried to fix it
Nothing.
Is it a bug in the latest version of Backpack?
4.2

I've submitted #4096 that should fix this. Closing in favor of that one.


No Proper Alignment

Description

the subscribe button is not properly aligned
Steps to Reproduce
Hi , I came across this issue . I am confident I can contribute effectively to this issue.
Would you mind assigning it to me so I can start working on it? Looking forward to contributing and adding value to the project.
Expected Behavior
No response
Actual Behavior
No response
Screenshots
No response
Additional Information
No response
What browser are you seeing the problem on?

[ ] Firefox
[X] Chrome
[ ] Safari
[ ] Microsoft Edge

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

@Roshn1 assigning this issue to you.
make sure to complete it within a day.


Throwing exception in DuplexConnection interceptor makes requester RSocket ignore future requests

Throwing exception in DuplexConnection interceptor makes requester RSocket silently ignore all future requests

Likely caused by upstream introduction of sendProcessor into RSocketClient - exception from  DuplexConnection of interceptor cancels processor, and it ignores all future onNexts()

Fixed in #9


Not Working on Windows

Is there any way to verify that traffic is going through the proxy via VM? I have Windows 10 desktop USB tethered to phone, sshed into phone, have VM running sshuttle, and added the route. But it seems all traffic is being registered by the tethering app, not Termux.

You can run ssh server in debug mode and you will see the details for the data sent through the tunnel:
 sshd -D -dd
You must delete the default route create once you connect to the AP (Wi-Fi or USB tethering) and add the default gateway route to the VM:
route delete <IP_ADDRESS>
route add <IP_ADDRESS> mask <IP_ADDRESS> <VM_IP> IF <Interface>

If you don't delete the other route, it will have the lowest metric and the route to the VM will not be used.

@SergioaAndres if you make a pull request adding that to the README, I'll approve and merge it.


inject fine scale aliquots into database and use vector tile service

Fine scale requires database approach. Can't load entirety of aliquots into Quarto doc or R package.

See Gdrive data/blocks/README:
Inconsistencies across Shelfs and multiple finer units possible.

Official Protraction Diagrams (OPDs) (2 degrees wide by one degree high)

Blocks (2304 hectares; 4800 x 4800 meters on a UTM).

Aliquot (144 hectares)


Error messages in English

I translated the error messages to English with google translate (if you'd agree) , and added (or appended the value) of a few ones that GMO support provided me:
{
  // 'E00000000': 'Null',
  'E01010001': 'Shop ID is not set',
  'E01010008': 'Wrong ShopID format (Please make sure that ShopID should have 13 digits of alphanumeric characters only)',
  'E01010010': 'ShopID does not match',
  'E01020001': 'The shop password is not specified',
  'E01020008': 'Wrong ShopPass format (Please make sure that ShopPass should have 10 alphanumeric characters only)',
  'E01030002': 'Neither the specified ShopID nor ShopPass does not exist.',
  'E01030061': 'Forced Refund is not available',
  'E01040001': 'The order ID is not specified',
  'E01040003': 'The order ID exceeds the maximum character number',
  'E01040010': 'An order ID already exists',
  'E01040013': 'Wrong OrderID format (Please make sure that OrderID should only have alphanumeric characters and "-".)',
  'E01050001': '"JobCd" is not specified.',
  'E01050002': 'The specified "JobCd" does not exist.',
  'E01050004': 'The specified "JobCd" is not available.',
  'E01060001': 'The amount of money is not specified',
  'E01060005': 'The amount of money exceeds the maximum digit number',
  'E01060006': 'The amount of money contains characters other than numbers',
  'E01060010': 'The Order ID was already used. It is possible that you have specified the Order ID again with the different payment amount',
  'E01060021': 'Captured amount does not match authorized amount',
  'E01070005': 'Tax shipping exceeds the maximum digit number',
  'E01070006': 'Tax shipping includes characters other than numbers',
  'E01080007': 'Wrong value is set for "TdFlag". Please set 0 or 1 for this parameter.',
  'E01080010': 'It does not match with the administration screen',
  'E01080101': 'Wrong value is set for "TdFlag". Please set 1 for this parameter.',
  'E01090001': 'Transaction ID is not specified',
  'E01090008': 'The form of the transaction ID is not correct',
  'E01100001': 'The transaction password is not specified',
  'E01100008': 'The form of the transaction password is not correct',
  'E01110002': 'Neither the specified AccessID nor AccessPass does not exist.',
  'E01110010': 'The settlement for this OrderID is not complete',
  'E01130012': 'Card company abbreviation exceeds the maximum bytes',
  'E01160001': '"PayTimes" is not specified.',
  'E01160007': 'Wrong characters are specified for "PayTimes". Please use numbers only.',
  'E01160010': '"2" is not specified for "PayTimes".',
  'E01170001': 'The card number is not specified',
  'E01170003': 'The card number exceeds the maximum character number',
  'E01170006': 'The card number contains characters other than numbers',
  'E01170011': 'Wrong card number digits (It should be from 10 to 16 digits.)',
  'E01180001': '"Expire" is not specified.',
  'E01180003': 'Wrong "Expire" format (Please make sure this value has to be 4 digits)',
  'E01180006': 'The expire date contains characters other than numbers',
  'E01180008': 'Wrong Format (for "Expire")',
  'E01180011': 'Wrong Format (for "Expire")',
  'E01190001': 'The site ID is not specified',
  'E01190008': 'The form of the site ID is not correct',
  'E01200001': 'The site password is not specified',
  'E01200007': 'Wrond SiteID',
  'E01200008': 'The form of the site password is not correct',
  'E01210002': 'Neither the specified SiteID nor SitePass does not exist.',
  'E01220001': 'The member ID is not specified',
  'E01220005': 'The number of digits for "MemberID" exceeds the limit.',
  'E01220008': 'Wrong Format (for "MemberID")',
  'E01220010': 'The specified "SiteID" has been already used.',
  'E01220012': 'Wrong Length (for "MemberID")',
  'E01230006': 'Wrong characters are specified for "CardSeq". Please use numbers only.',
  'E01230009': 'The number of registered cards reaches a limit of 5 cards.',
  'E01240002': 'The specified card does not exist.',
  'E01240012': 'The specified MemberID duplicates in the uploaded file.',
  'E01250008': 'Wrong Format (for "CardPass")',
  'E01250010': 'Wrong "CardPass" entered by the user.',
  'E01260001': '"Method" is not specified.',
  'E01260002': 'Wrong value is specified for "Method".',
  'E01260010': 'Either card number or the value set for "Method" is the wrong one.',
  'E01270001': '"PayTimes" is not specified.',
  'E01270005': 'The number of digits for "PayTimes" exceeds the limit.',
  'E01270006': 'Wrong characters are specified for "PayTimes". Please use numbers only.',
  'E01270010': 'The specified value is not available for "PayTimes".',
  'E01290001': 'HTTP_ACCEPT is not specified.',
  'E01300001': 'HTTP_USER_AGENT is not specified.',
  'E01310002': '"DeviceCategory" is not specified.',
  'E01310007': 'Wrong value is specified for "DeviceCategory". The available values are "0" or "1".',
  'E01320012': 'The number of bytes for "ClientField1" exceeds the limit.',
  'E01330012': 'The number of bytes for "ClientField2" exceeds the limit.',
  'E01340012': 'The number of bytes for "ClientField3" exceeds the limit.',
  'E01350001': '"MD" is not specified.',
  'E01350008': 'Wrong format (for MD)',
  'E01360001': '"PaRes" is not specified.',
  'E01370008': '"TdTenantName" is not specified.',
  'E01370012': 'The number of bytes for "TdTenantName" exceeds the limit.',
  'E01390002': 'Neither the specified SiteID nor MemberID does not exist.',
  'E01390010': 'The specified "MemberID" has been already used.',
  'E01400007': 'Wrong value is specified for "DeviceCategory". The available values are "0" or "1".',
  'E01410010': 'The specified Order ID is not allowed to be made any change to.',
  'E01420010': 'The provisional sales authorization has expired for the specified Order ID.',
  'E01430012': 'The number of bytes for "MemberName" exceeds the limit.',
  'E01440008': 'Wrong Format (for "DefaultFlag")',
  'E01450008': 'Wrong Format (for "ItemCode")',
  'E01460008': 'Wrong Format (for "SecurityCode")',
  'E01470008': 'Wrong Format (for "SeqMode")',
  'E01480008': 'Wrong Format (for "HolderName")',
  'E01480011': 'The number of characters for "HolderName" exceeds the limit.',
  'E01490005': 'The sum of "Amount" and "Tax" exceeds the limit.',
  'E01500001': '"ShopPassString" is not specified.',
  'E01500005': 'The number of characters for "ShopPassString" is the wrong one. Please make sure that the number of characters should be 32.',
  'E01500012': 'Wrong value is set for "ShopPassString".',
  'E01510001': 'Purchase information string is not specified.',
  'E01510005': 'The number of characters for "CheckString" is the wrong one. Please make sure that the number of characters should be 32.',
  'E01510010': 'Wrong format (for usage date)',
  'E01510011': 'Wrong value is set for usage date.',
  'E01510012': 'There is something wrong with purchase information string.',
  'E01520002': 'Invalid value is set for "UserInfo".',
  'E01530001': '"RetURL" is not specified.',
  'E01530005': 'The number of characters exceeds the limit for "RetURL".',
  'E01540005': 'The number of characters exceeds the limit for "CancelURL".',
  'E01550001': '"DateTime" is not specified.',
  'E01550005': 'Wrong format (for DateTime) *It should be in the format of yyyyMMddhhmmss',
  'E01550006': 'Invalid value is set for "DateTime".',
  'E01590005': 'The number of characters exceeds the limit for "ItemCode".',
  'E01590006': 'Invalid value is set for "ItemCode".',
  'E01600001': '"MemberPassString" is not specified.',
  'E01600005': 'The number of characters exceeds the limit for "MemberPassString".',
  'E01600012': 'Wrong value is set for "MemberPassString".',
  'E01610005': 'The value for "RetryMax" is not from 0 to 99.',
  'E01610006': 'Wrong format (for RetryMax). Please use numbers only.',
  'E01620005': 'The value for "SessionTimeout" is not from 0 to 9999.',
  'E01620006': 'Wrong format (for "SessionTimeout"). Please use numbers only.',
  'E01630010': 'Wrong MemberID is specified.',
  'E01640010': 'Wrong SiteID is specified.',
  'E01650012': 'Wrong ShopID is specified.',
  'E01660013': 'Wrong value is set for "Lang".',
  'E01670013': 'The value set for "Enc" is not supported.',
  'E01700001': 'There is something wrong with the number of parameters.',
  'E01710001': 'Recurring flag is not set for the order.',
  'E01710002': 'The specified transaction type does not exist.',
  'E01730001': 'Bonus payment amount is not specified.',
  'E01730005': 'The number of characters exceeds the limit for bonus payment amount.',
  'E01730006': '"0000990" is not specified for Item Code.',
  'E01730007': 'Wrong format (for bonus payment amount). Please use numbers only.',
  'E01740001': 'Terminal processing sequence number is not specified.',
  'E01740005': 'The number of characters exceeds the limit for terminal processing sequence number.',
  'E01740007': 'Wrong format (for terminal processing sequence number). Please use numbers only.',
  'E01750001': 'Usage date is not specified.',
  'E01750008': 'Wrong format (for usage date)',
  'E01770002': 'Invalid Value is set for transaction type.',
  'E01780002': 'Invalid value is set for card validity check. Please set "0" for this parameter.',
  'E01790007': 'Invalid value is set for check date.',
  'E01790011': 'The number of characters exceeds the limit for check date.',
  'E01800001': 'Password is not specified.',
  'E01800008': 'Wrong format (for password)',
  'E01800010': 'Invalid password',
  'E01800050': 'Invalid password (0000 is not available)',
  'E01810001': 'Magnetic stripe type is invalid',
  'E01810008': 'Magnetic stripe type is invalid',
  'E01820001': 'Magnetic stripe info is invalid',
  'E01820003': 'Magnetic stripe info is invalid',
  'E01820008': 'Magnetic stripe info is invalid',
  'E01840010': 'The specified parameters are not sufficient.',
  'E01850008': 'Wrong format (for "UpdateType")',
  'E01860008': 'Wrong format (for Card Number Masking Flag)',
  'E01870008': 'Wrong format (for TokenType)',
  'E01880001': '"MemberID" is not specified.',
  'E01880002': 'Neither the specified SiteID nor MemberID does not exist.',
  'E01880008': 'Wrong format (for "MemberID")',
  'E01890001': '"CardSeq" is not specified.',
  'E01890002': 'The specified "MemberID" does not exist.',
  'E01890006': 'Wrong format (for "CardSeq"). Please use numbers only.',
  'E01890009': 'Card cannot be registered for the specified MemberID. Please note that each MemberID can have up to 5 cards.',
  'E01999998': '"001" is not specified for "Format Version".',
  'E11010001': 'The specified Order ID has already completed its settlement.',
  'E11010002': 'The status cannot be changed for the specified OrderID because this order has not been settled yet.',
  'E11010003': 'The specified "JobCd" is not available for this OrderID. ',
  'E11010010': 'The status of this OrderID cannot be changed because it was settled more than 180 days ago.',
  'E11010099': 'This card is not available.',
  // 'E11010999': 'Null',
  'E11310001': 'Link type payment cannot be executed for this OrderID.',
  'E11310002': 'Link type payment cannot be executed for this OrderID.',
  'E11310003': 'Link type payment cannot be executed for this OrderID.',
  'E11310004': 'Link type payment cannot be executed for this OrderID.',
  'E11310005': 'Card registration failed because this MemberID has already registered a card.',
  'E21010001': 'There is something wrong with 3DS authentication. Please try again later.',
  'E21010007': 'There is something wrong with 3DS authentication. Please try again later.',
  'E21010999': 'There is something wrong with 3DS authentication. Please try again later.',
  'E21020001': 'There is something wrong with 3DS authentication. Please try again later.',
  'E21020002': '3DS authentication was cancelled. Please try again later.',
  'E21020007': 'There is something wrong with 3DS authentication. Please try again later.',
  'E21020999': 'There is something wrong with 3DS authentication. Please try again later.',
  'E21010201': 'Settlment process failed because the card is non-3DS compliant.',
  'E21010202': 'Settlement process failed because the card is non-3DS compliant.',
  // 'E31500014': 'Null',
  'E41170002': 'Settlement process failed because the card is not available on our system.',
  'E41170099': 'There is something wrong with card number.',
  'E61010001': 'Settlement process failed. Please try again later.',
  'E61010002': 'Invalid card is being used, or there is something wrong with card number.',
  'E61010003': 'Settlement process failed. Please try again later.',
  'E61020001': 'The specified payment method is not available.',
  'E61030001': 'Your request cannot be accepted under the current merchant contract.',
  'E61040001': 'Raw PAN (=card number) cannot be processed under the current merchant contract.',
  'E82010001': 'An error occurred and your request was declined.',
  'E90010001': 'Please wait until we complete processing.',
  'E91099996': 'An error occurred. Please ask GMO-PG to confirm the status by informing us of process date & time and the transmitted parameters.',
  'E91099997': 'There is something wrong with the API URL.',
  'E91019999': 'Settlement process failed. Please try again later.',
  'E91020001': 'Timeout occurred. Please try again later.',
  'E91029998': 'Settlement process failed. Please contact the merchant.',
  'E91029999': 'Settlement process failed. Please try again later.',
  'E91050001': 'Settlement process failed.',
  'E91060001': 'An error occurred. Please ask GMO-PG to confirm the status by informing us of process date & time and the transmitted parameters.',
  'E91099999': 'Settlement process failed. Please try again later.',
  'E92000001': 'The order failed to be processed because of heavy traffic. Please try again later.',
  'E92000002': 'The order failed to be processed because of heavy traffic. Please try again later.',
  'EX1000301': 'Settlement process failed. Please enter card number again.',
  'EX1000302': 'Settlement process failed. Please enter card number again.',
  'EX1000303': 'Settlement process failed. Please enter card number again.',
  'EX1000304': 'Settlement process failed. Please enter card number again.',
  '42C010000': 'Settlement process failed. Please try again later.',
  '42C030000': 'Settlement process failed. Please try again later.',
  '42C120000': 'Settlement process failed. Please try again later.',
  '42C130000': 'Settlement process failed. Please try again later.',
  '42C140000': 'Settlement process failed. Please try again later.',
  '42C150000': 'Settlement process failed. Please try again later.',
  '42C500000': 'Settlement process failed. Please try again later.',
  '42C510000': 'Settlement process failed. Please try again later.',
  '42C530000': 'Settlement process failed. Please try again later.',
  '42C540000': 'Settlement process failed. Please try again later.',
  '42C550000': 'Settlement process failed. Please try again later.',
  '42C560000': 'Settlement process failed. Please try again later.',
  '42C570000': 'Settlement process failed. Please try again later.',
  '42C580000': 'Settlement process failed. Please try again later.',
  '42C600000': 'Settlement process failed. Please try again later.',
  '42C700000': 'Settlement process failed. Please try again later.',
  '42C710000': 'Settlement process failed. Please try again later.',
  '42C720000': 'Settlement process failed. Please try again later.',
  '42C730000': 'Settlement process failed. Please try again later.',
  '42C740000': 'Settlement process failed. Please try again later.',
  '42C750000': 'Settlement process failed. Please try again later.',
  '42C760000': 'Settlement process failed. Please try again later.',
  '42C770000': 'Settlement process failed. Please try again later.',
  '42C780000': 'Settlement process failed. Please try again later.',
  '42G020000': 'Insufficient card balance',
  '42G030000': 'The card limit has been exceeded',
  '42G040000': 'Insufficient card balance',
  '42G050000': 'The card limit has been exceeded',
  '42G060000': 'Insufficient card balance',
  '42G070000': 'The card limit has been exceeded',
  '42G120000': 'Invalid card',
  '42G220000': 'Invalid card',
  '42G300000': 'Invalid card',
  '42G420000': 'Wrong password',
  '42G440000': 'Wrong security code',
  '42G450000': 'Security code is not entered',
  '42G540000': 'Invalid card',
  '42G550000': 'The card limit has been exceeded',
  '42G560000': 'Invalid card',
  '42G600000': 'Invalid card',
  '42G610000': 'Invalid card',
  '42G650000': 'Wrong card number',
  '42G670000': 'Wrong ItemCode',
  '42G680000': 'Wrong value is set for "Amount"',
  '42G690000': 'Wrong value is set for "Tax"',
  '42G700000': 'Wrong value is set for "Bonus Payment Times"',
  '42G710000': 'Wrong value is set for "Bonus Payment Month"',
  '42G720000': 'Wrong value is set for "Bonus Payment Amount"',
  '42G730000': 'Wrong value is set for "1st month for payment"',
  '42G740000': 'Wrong value is set for "PayTimes"',
  '42G750000': 'Wrong value is set for "Payment Amount for Installment"',
  '42G760000': 'Wrong value is set for the initial payment amount.',
  '42G770000': 'Wrong value is set for processing type',
  '42G780000': 'Wrong value is set for payment type',
  '42G790000': 'Wrong value is set for reference type',
  '42G800000': 'Wrong value is set for cancellation type',
  '42G810000': 'Wrong value is set for cancellation type',
  '42G830000': 'Wrong Expiry Month',
  '42G920000': 'Invalid card',
  '42G950000': 'Invalid card',
  '42G960000': 'Invalid card',
  '42G970000': 'Invalid card',
  '42G980000': 'Invalid card',
  '42G990000': 'Invalid card'
}

Pull Request Test Coverage Report for Build 212

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 96.957%

Totals

Change from base Build 206:
-0.03%

Covered Lines:
191

Relevant Lines:
195

💛  - Coveralls

Great job!


[wip] Prep for 1.0; also bump go to 1.10.3 / new build image and fixes

Prep for 1.0; also bump go to 1.10.3 / new build image and fixes
previous pr broke the build update and missed 1 file

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
Assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

there are more doc changes and build change I want to do but I need to get the linters fix in asap, ptal

screen shot update:


[Bilibili] Add subtitle converter

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[x] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[x] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Closes https://github.com/yt-dlp/yt-dlp/issues/1015, code taken from https://github.com/y2361547758/bcc2ass.

How can you be the original author as well as not the original author?
Fix it please.

@Ashish0804 He wrote some of it, while other parts are from another repo

btw, is there any code remaining from https://github.com/y2361547758/bcc2ass now? It looks to me like you completely rewrote everything

btw, is there any code remaining from https://github.com/y2361547758/bcc2ass now? It looks to me like you completely rewrote everything

no


Update translations in OperatorError

Description
Replace hard-coding in OperatorError with translations; update translation keys generally.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] Other

How should this be tested?
Not sure how to cause these errors - tested Gnosis flow (gasless trades).
Checklist:

[X] I have performed a self-review of my own code
[ ] I have commented my code where relevant, particularly in hard-to-understand areas
[X] My changes generate no new console warnings
[ ] The base of this PR is master if hotfix, develop if not

Some unrelated test seems to have failed, and after updating to current develop it failed again. Did I somehow break this, or is develop broken? Anyway not merging until Ev looks at it (including this failing test).

The test failure happened because the function require.context is injected by webpack when compiling, while the test runner (jest) runs the code without compiling first. It happened because plugins/i18n.ts was included which included @/locales. Just need to add a mock for the locales file so the test runner doesn't try and execute it and run require.context.
I've pushed a fix for it to this branch.


Issue on Input Shape of network

For the several networks in the build methods, the width and height may be of the wrong order.

Right, in the code we're supposed to have height before width for our data, but sometimes in q_network.py the width is listed first. But since we usually assume the images are square it's not too bad, though it might be nice to have height before width be consistently used for clarity.


Enable TLS communication for Prysm gRPC

gRPC client is configured with insecure transport and therefore makes it impossible to interact with nodes over TLS
https://github.com/attestantio/go-eth2-client/blob/a7129eecd62a309e6a934c39023833331e4459a3/prysmgrpc/service.go#L89

Funny enough, we were just working with this and I was about to open an issue. :)
Risking overloading the request here, but it would additionally be great to have a configuration option to add basic auth. Typically this would be a simple "WithHeaders" sort of thing, but with the Go GRPC implementation, it requires an interface. Yay.

@amir-blox I will take a look at this, however prysm is looking to fully implement the standard HTTP API, at which point I will most likely deprecate the grpc connection.
@BisonDee I am unaware of any of the standard HTTP API providers that have an option for authentication.  Where would you look to use this?

@BisonDee I am unaware of any of the standard HTTP API providers that have an option for authentication. Where would you look to use this?

Morning. Adding basic auth headers was in reference to the gRPC connection (along with TLS).  We have Prysm behind a proxy using TLS and basic auth. That being said we are now just using Lighthouse's beacon node API (and this go-eth2-client).
In general the gRPC API has been difficult to work with in many dimensions and would welcome a move to the standard HTTP API.

@BisonDee given the detail so far I'm assuming that per-connection headers passed in to the service will be sufficient, rather than per-request headers.  Does this sound okay to you?

@BisonDee Alternatively, it is possible to pass in your own context to each request that included the headers you wished to provide.  This would give you more flexibility, and avoid changes to the prysmgrpc codebase.  May this be a better approach?

Thanks @mcdee - Context passing is totally cool and sounds easy enough to use.

@amir-blox There is now a tls branch that contains the ability to create a TLS connection, along with options to use client and CA certs if required.  Please could you give it a go and see if it does what you need?
@BisonDee you can create a new context for requests with headers, along the lines of:
import "google.golang.org/grpc/metadata"
...
md := metadata.New(map[string]string{"Authorization","Bearer token"})
ctx = metadata.NewOutgoingContext(ctx, md)

and if you supply that context to the call it should post them.

@amir-blox any feedback on the TLS changes?
@BisonDee does the code above solve your issue?

Thanks Jim, I think this would work just fine. Appreciated. Any mechanism that allows for these headers over the connection is great.

Just wanted to circle back on this. I have written scripts against this branch and successfully connected to a Prysm Beacon API using TLS and the metadata.
For the client, it only required this:
prysmParameters := make([]prysmgrpc.Parameter, 0)
prysmParameters = append(prysmParameters, prysmgrpc.WithAddress(prysmURL))
prysmParameters = append(prysmParameters, prysmgrpc.WithTLS(true))
client, err := prysmgrpc.New(ctx, prysmParameters...)

And for the authenticated call:
md := metadata.New(map[string]string{"Authorization": fmt.Sprintf("Basic %s", basicAuth(username, password))})
ctx = metadata.NewOutgoingContext(context.Background(), md)

One quirk unrelated to this library is that the context cannot be passed into a function for some reason. I had to create this context in each function that called out.

Thanks for the update, I'll sort out a release with these changes.

Tagged release v0.7.2 with this functionality.


Conflict with SLAP

UniqueMemberList.java
   /**
     * Returns a new member with redeemed Points.
     */
    public Member createRedeemedPointsMember(Member member, List<Point> toRedeemPointsList) {
        Member outputMember = member;
        outputMember.addRedemptions(toRedeemPointsList);
        return outputMember;
    }

ModelManager.java
   /**
     * Returns a new member with redeemed Points.
     */
    public Member createRedeemedPointsMember(Member member, List<Point> toRedeemPointsList) {
        Member outputMember = member;
        outputMember.addRedemptions(toRedeemPointsList);
        return outputMember;
    }

Ezfoodie.java
   /**
     * Returns a new member with redeemed Points.
     */
    public Member createRedeemedPointsMember(Member member, List<Point> toRedeemPointsList) {
        Member outputMember = member;
        outputMember.addRedemptions(toRedeemPointsList);
        return outputMember;
    }

fixed


feaure request: parse git trailers like git-interpret-trailers would

I'd like to contribute parsing of git trailers! Git trailers are "lines that look similar to RFC 822 e-mail headers at the end of the otherwise free-form part of a commit message," according to https://git-scm.com/docs/git-interpret-trailers.  Parsing trailers would improve users' workflows by highlighting trailer keys and values differently, and exposing trailer key-value pairs for programmatic access.
Looking at the examples section of the git-interpret-trailers page, trailers can be configured to use arbitrary keys. To avoid parsing key-value pairs with an unknown delimiter, I'd propose recognizing only the most common trailer delimiters, /[:=#]/.

Sounds great!
I agree, let's allow just the most common delimiters 👍


Remove some unnecessary attackEffects. Add some missing damageRolls.

I'm sure you could pick the actors that were imported directly from PDF out of a lineup using clues like these that got left behind in the data


Remove any dependency on base styles

Ambient does not style components by default
Remove the dependency on base styles, you do not need to override Ambient core CSS to customize the design.
Once your semantic layout is in place, you can then customize the design with optional Ambient skin classes, or your own custom classes.

removed any remaining default styles. Now you can have the option to use Ambient skin classes, or your own custom classes for component design. ie: buttons, form inputs.


PL: change the order of one string

PL: change the order of one string

Description 🗒
Change the order of the string as suggested in https://github.com/the-hideout/tarkov-dev/commit/0702f0a51eea5bbefc61176624c36ff4a2c90519#r99871691 and Discord (thanks!)

Examples 📸

Related Issues 🔗
#175

 Expand for Help

Have questions about the review or deployment process? View our contributing docs
Need additional help and want to chat in real time? Join our community Discord

By submitting this pull request, you agree to our code of conduct

Please do not open new PRs for every change, you can commit to the other branch #371 and it will update the PR automagically.

Please do not open new PRs for every change, you can commit to the other branch #371 and it will update the PR automagically.

Yeah, originally wanted to do that, but was scared I'd break something because of tags (I guess you guys would still pick it up though); guess I can do it now though, as it should be fine. :)


how to import multiple svg files?

I have multiple svgs that need to import, how can I do it all at once

Hi, you could create an index.js file in your SVG folder:
export Svg1 from './1.svg';
export Svg2 from './2.svg';

Then you can import them like this:
import { Svg1, Svg2 } from './svg-folder'


error in gambling-porn list causing parsing issues in fpsense

Hi -
The gambling-porn list when read into DNSBL in pfsense is causing an error at line 236173 <IP_ADDRESS> version1-other.0.0. I believe the error is the trailing '0.0'.
Thank you!
Gary

Thank you!  Just tested the download to confirm the fix.

Testing if I have priv's to close the issue.


Silex 2.x fat download

On http://silex.sensiolabs.org/download both zip and tgz composer.json contains;
"require": {
"silex/silex": "~1.1",

I had the same problem.. But this isn't changeable within this repo, is it?

The archives have been removed. One should use Composer instead now.


page:finish hook won't be triggered

If ssr option is disabled, then page:finish hook won't be triggered.
https://github.com/ijkml/nuxt-umami/blob/6de77d16c3e98522e2f72ed9ee1365b4b2041eb0/plugins/umami.ts#L14-L19

Oh, boy... I'll look into this, thanks @sxzz.

Hello again, @sxzz.
I finally had a chance but I couldn't reproduce it. The hook seems to trigger with ssr: false :shrug:.
Anyway, could you take a look at this repro and let me know if I missed something?
https://stackblitz.com/edit/nuxt-umami?file=nuxt.config.ts
Thanks, again.

Seems not relate to SSR, but relate to Suspense
Minimal reproduction repo: https://github.com/sxzz/nuxt-page-finish

Yeah, you're right. It is related to Suspense.
But, the hook triggers when you add <NuxtPage />.
Repo: https://github.com/ijkml/nuxt-page-finish
Will look into how much of an effect this has 'cause the code is for autoTrack (useful when you have pages).
https://github.com/ijkml/nuxt-umami/blob/6de77d16c3e98522e2f72ed9ee1365b4b2041eb0/plugins/umami.ts#L14-L19
How did you find the bug, please?

I have an SPA project that doesn't automatically track pages. To fix this, I manually added another plugin using app:mounted hook.
https://github.com/sxzz/ast-explorer/blob/main/plugins/umami.ts

Absolutely right, it is a <NuxtPage> / Suspense thing.
I'm stuck. Do you have any suggestions on a fix for this?
Also, instead of a plugin, onMounted(() => umTrackView()) in app.vue might work, no?

Of course, it works. Can we use hook app:mounted (with 300ms delay), instead of page:finish?

Unfortunately, no.
app:mounted is only triggered once (https://nuxt.com/docs/api/advanced/hooks#app-hooks-runtime).
Mean time, I would add this behavior to faqs/quirks :+1:.


Training problem

Hi,
i've tried to train an example model using the example_cornell.yml configuration but after 6800 steps the model is responding to all the request with the same 'sentence' : ..............
it seem the the training isn't doing much since at step 200 it prints:
training loss = 5.797; training perplexity = 329.45
Validation loss = 5.764; val perplexity = 318.69
and at step 6800 the values are almost the same:
training loss = 5.597; training perplexity = 269.70
Validation loss = 5.692; val perplexity = 296.40
What can be the cause of this ? How can a reasonable output been obtained ?

That's definitely not the expected behavior. It's been some time since I last ran the project, so let me try and reproduce your results over the weekend. I'll let you know if I see the same issue and how you may be able to resolve it.

Hi @b789 , I was (unfortunately) able to reproduce your results! This is pretty surprising/annoying, but thanks for bringing my attention to it. My main GPU has been tied up with other work this weekend, so I wasn't able to explore much, but my best guess is that the AttentionDecoder is to blame. It uses a custom attention implementation I wrote back in the days of tf version ~1.1 when the API for doing that was very fragile and actually broke between minor releases.
With that said, and after skimming my loss plots in the wiki, you can get reasonable outputs if you just change AttentionDecoder to BasicDecoder in example_cornell.yml. I have confirmed on a smaller machine of mine that losses decrease as expected in that case.
I'm definitely not satisfied with this...hopefully I have some time soon to see what is going on with AttentionDecoder. It used to work! And of course, if you happen to find a fix for it, contributions are more than welcome! Let me know if I can help with anything else, and if I do find out what's going on with AttentionDecoder soon, I will post updates here (and push the corrections to master).

It's okay @Shaptic everything will be ok.

Thank @mckinziebrandon for the advice to use the BasicDecoder, in this way is actually working.
I'll try to look what's the problem with the AttentionDecoder if i can.

@b789 or anyone interested: BasicEncoder does not return it's full set of states over time (returns _, final_output only I believe) as BidirectionalEncoder. When designed, this was a feature, but it is now a bug! Happy to accept a PR that makes the returned tuple of BasicEncoder the same form as returned by BidirectionalEncoder.

@mckinziebrandon thank you for this wonderful library!
Can you elaborate on training proccess a little more? I mean, config file requires 'train_from.txt', 'train_to.txt', 'valid_from.txt', 'valid_to.txt' files, but I don't really understand what they should contain. I have one .txt file with Cornell Movies Corpus, it contains rows that look like "question, answer". How should I split it?


just so you know, I made a thing like this that has a bit more features :)

https://github.com/asottile/all-repos

https://github.com/asottile/all-repos

Awesome, thanks for sharing!


Kira branch

About the PR
Removed a Ninja name and title along with a Skeleton first name. (Boner, Throat, Deep.)
 "Boner" come on. I'm not staring at my monitor watching a Ninja named "Deep Throat" bro.
Technical details
Removed "Boner" from the Skeleton first name file. I also remove the "Deep" name along with "Throat" from the Ninja Titles file.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
None?
Changelog
Removed certain Skeleton and Ninja names.
:cl:

removed: Inappropriate names.

didnt do the cl right, but it probably doesnt need a cl

didnt do the cl right, but it probably doesnt need a cl

Was editing it.

but wait! there's more! you should be doing this changes on a fork, not on our main repo PLEASE.


Updated web socket specs to new Celluloid internal APIs

Fixed two older tests in the test suite.

Good catch @aayushranaut! Merged //


Proposed fix for issue #27

Hi there,
This is the proposed fix for issue #27
Regards,
-Santiago

Hi @santiagovm, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@santiagovm, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

Thanks - but we only accept PRs to the dev branch. Check the contribution guidelines. Could you please do another PR for dev?


New story content

Hi! Thanks for your submission.
Unfortunately it seems that there were changes in the main that conflict with yours.
Could you please perform a merge as described in Tutorial 3 slides 90-103 and integrate those changes?
Start with synchronizing your local main with my upstream main as described in slide 98.
We do not want to lose any existing content, so you should keep what others have written and add yours.
You're free to reorganize the content blocks so that it still makes a story, but please do minimal changes
to the content of what others have written to integrate them with yours.
You have time until the 10th of October at 12:00.
If you can't make it by that time or you are done before the deadline,
please add a comment in github so that I can progress with another student.

Resolved the conflict between my branch and upstream, should be ready to merge now

Thanks for your contribution! Task 2 completed! See canvas for results


Cut off strings to a 1000 characters when formatting arguments in stacktraces

When passing a very long string around(like the entire content of a web page) and an exception is thrown, the console floods with the entire contents of that string. When arguments are provided for a method, usually the full contents of a string is not relevant, so I decided at a arbitrary cut-off point of a 1000 characters.

@nunomaduro @owenvoke Thanks for approving this! How does getting this into a release work?

@owenvoke Can you release please?

@nunomaduro @PrinsFrank, I've released v5.4.0 with this change.

@owenvoke tx, that was quick!


Property tests for invariants

I would like to add some tests that check that structure invariants of the tree are not violated, if that sounds ok.
Functions <|, ><, insertAt, deleteAt seem to be violating invariants.

Sure, go ahead.


Replace slack with discord

Pull Request
Related issue
Closes #596
What does this PR do?

Replace every occurrence of Slack with Discord
Remove the now-useless Slack icons

PR checklist
Please check if your PR fulfills the following requirements:

[x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

bors merge


Reduce the speed of the scroller #73

https://github.com/user-attachments/assets/d6128f8a-0b85-4656-afb0-d6ce61ea9c3c
is this good or should i slow  it down more?

awesome @nishant0708
you can mention the issue next time, so it would be easy to reference the level


Upload core stats to qps_test

[trickle] No significant performance differences

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences


Video thumbnails not working

I like to add an thumbnail / poster to my mp4 video, but i only see the actual video.
This is the code in the page:   ![](test.mp4)
And these are the files located in the page directory:

test.mp4
test.mp4.thumb.jpg

As i said, it only returns the actual mp4 file

The video is played inline in the page unless you explicitly want to link to it. To do so, use
![](video.mp4?link)

and the page will show the thumbnail with a link to the video.

i like to use embedded video and a poster for preview:

i like to use embedded video and a poster for preview:
<video  poster="image.jpg" controls>

same for me


Charts not showing in IE9 or IE10  v2.x

Just for the v2 dev version using ie9 I'm not seeing the charts drawn into the canvas element (I tried line and bar charts). I tried tracking down where the issue is occurring without success.
I'm also seeing the issue in IE10... I'm using the sample files.
Am I doing something wrong or is this a known issue?

In 8,9 & 10 doesn't work too.

Ok then, I'm going hunting for the bug.
Wish me luck or even better give me some ideas about what might be wrong... anyone?

Just can wish U luck.

I have the same issue with Safari 9: charts are not showing on first page load. They are showing if I delete/re-create the canvas later in the script.

Has anyone got anywhere with why it's not working in IE9 or IE10?

andi-b, will try it out asap! if it works, you are my hero.

@andi-b if you have a fix for this, I'd be happy to merge a fix.

It looks likely to be something within this code:
// Support a jQuery'd canvas element
		if (context.length && context[0].getContext) {
			context = context[0];
		}

		// Support a canvas domnode
		if (context.getContext) {
			context = context.getContext("2d");
		}

		this.ctx = context;
		this.canvas = context.canvas;

		// Figure out what the size of the chart will be.
		// If the canvas has a specified width and height, we use those else
		// we look to see if the canvas node has a CSS width and height.
		// If there is still no height, fill the parent container
		this.width = context.canvas.width || parseInt(Chart.helpers.getStyle(context.canvas, 'width')) || Chart.helpers.getMaximumWidth(context.canvas);
		this.height = context.canvas.height || parseInt(Chart.helpers.getStyle(context.canvas, 'height')) || Chart.helpers.getMaximumHeight(context.canvas);

Thought I was getting closer with the resize function, but data appears to be the same. The difference I'm getting with the HTML:
Firefox:

IE9:

@andi-b try investigating the resize code

I've spent quite a lot of time on this but have found a workaround, although may not work with responsive, that may help others figure out what's happening. My workaround:
var ctx = document.getElementById("bar_chart").getContext("2d");

var canvasWidth= parseInt(document.getElementById("bar_chart").width);
var canvasHeight= parseInt(document.getElementById("bar_chart").height);

window.myBar = Chart.Bar(ctx, {
            data: chartData,
            options: {...
            }
 });

myBar.chart.canvas.height = canvasHeight;
myBar.chart.canvas.width = canvasWidth;

Yes I've got something similar working too. Fortunately we need to fix this asap for a client, so I will try to get some work done for a pull request. I will look into the responsive part too, since we use that also.
@andi-b thanks for pointing out the problematic part!

Thanks for merging this @etimberg! Hope this fixes this issue for all of you. I tested this fix on windows 7 using VirtualBox, IE9 and IE10, using modern.ie. Let me know if this issue still exists, it's important for us (client and company) this works. :)

@byCedric This update doesn't appear to have worked for me - I'm using IE11, emulating to IE9 and IE10.
I see the work has been done in the core.helpers.js in the retina function: Do I need to include this file or is this already included within chartjs? And do I need to 'switch on' the option to have it work with Retina displays in order for this fix to work?
Many thanks

@andi-b Did you tried to recompile or rebuild the main Chart.js file?
I did change some code in the helpers.core.js, that was the part that multiplied by 0 on old browsers. What resulted in the width="0" height="0" issue you described. You don't have to change anything within your configurations since the retina calculations are always executed. Unfortunately, if you want to have this fix straight out of the box you have to wait... Wait until the main Chart.js and Chart.min.js are rebuild in this repository. I have no clue when this will happen or when a next release is due.
But to do this manually, you have two options. You can clone this repository and rebuild it yourself. When doing this you have control over your own Chart.js file and you can rebuild whenever you would like. This will look like the code below inside your package.json
{
    "dependencies": {
        "chart.js": "<github name>/<repo name>#v2.0-dev"
    }
}

e.g. "chart.js": "byCedric/Chart.js#v2.0-dev"

The second option is to add a script to NPM (your own package.json) that actually compiles the library from the original repository. I recommend to add the whole command as a script, so you don't have to type it every time. The script will be something like this.
{
    "scripts": {
        "build-chartjs": "cd ./node_modules/chart.js/ && npm install && ./node_modules/gulp/bin/gulp.js build && cd ../.."
    }
}

call it like this $ npm run build-chartjs, and/or add it to the postinstall callback.

Personally I recommend to use the second option, until the main Chart.js is rebuild within this repo. With the second option you also get all future bugfixes. Let me know, by DM, if this also doesn't work for you.

Closing as #1690 was merged. An updated build with this change is available in the v2.0-dev branch.


Question about MBAR

Hello,
I'm interested in minimizing the objective function with a gradient optimization approach. While I comprehend how MBAR estimates and reweighs the property of interest, I'm currently puzzled about how MBAR calculates the derivative of the objective function (or the property of interest); this aspect isn't clear to me?
Any help would be appreciated.

Probably a question for pymbar, not here. The code there has moderately well-documented descriptions of the objective function and the calculation of the gradients and hessians - you can use any scipy minimizer (using gradients/hessians/etc) to solve MBAR.  Some of the papers of Levy, Tan, et al that call the same equation UWHAM (unbinned weighted histogram analysis method) go through the minimization in more detail.

Dear Dr. Shirts, I really appreciate your reply.
The challenge I'm facing is that I intend to improve the force field parameters for my system using a gradient-based optimizer. However, this requires calculating the gradient, which happens to be the costly component of the procedure. This is why I'm considering utilizing MBAR to compute the gradient that can be fed to the optimizer.
Is it possible to make small perturb to the parameters during each iteration, subsequently utilizing MBAR to estimate the properties for these altered parameters, and then computing the gradient with respect to each parameter?

Evaluator does have the capability to estimate finite differences in free energies and expectations using MBAR, by evaluating the energy with reweighting at around the current point.  @SimonBoothroyd can probably clarify how to access that functionality.


macOS support?

Hello.
So I tried running the imgui example on a Mac but I got this error:
Unhandled exception. System.InvalidOperationException: Attempted to initialize a Vulkan window using GLFW, which doesn't support Vulkan on this computer.
Is there support for macOS or not?

In theory it should support macOS, although i can not test it.
Windowing functionality is used without changes from the Silk.NET packages.
Vulkan needs special options set when using macOS which according to the docs i set all to the correct value.
Did you get any other information than the error message?

Thanks for your reply!
So this was the entire console output I got:
kian.schmalzl@MacBook-Air-von-Kian testproj % dotnet run Unhandled exception. System.InvalidOperationException: Attempted to initialize a Vulkan window using GLFW, which doesn't support Vulkan on this computer.    at Silk.NET.Windowing.Glfw.GlfwWindow.CoreInitialize(WindowOptions opts)    at Silk.NET.Windowing.Internals.WindowImplementationBase.CoreInitialize(ViewOptions opts)    at Silk.NET.Windowing.Internals.ViewImplementationBase.Initialize()    at Microsoft.Extensions.DependencyInjection.DependencyInjectionExtensions.AddWindow(ServiceCollection collection, ApplicationSpecification opts)    at Program.<Main>$(String[] args) in /Users/kian.schmalzl/dev/projects/testproj/Program.cs:line 14 kian.schmalzl@MacBook-Air-von-Kian testproj %
I hope this helps


Feature: Support Beanstalk: applications/environments, app versions

0.4.0rc2 supports beanstalk, features need to be verified.


Update CI to build on commits to master / PRs

It looks like CI doesn't run on commits to master or for PR.
At least the badge in ReadMe points to a different (previous) config of CI.
Edit: sorry for the label (can't remove it). It's from the issue-template.

Nice catch. This must have failed when we migrated the repo to /dotnet. I'll take a look today.

From: Günther Foidl<EMAIL_ADDRESS>Sent: Tuesday, March 31, 2020 7:22:01 AM
To: dotnet/Kerberos.NET<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [dotnet/Kerberos.NET] Update CI to build on commits to master / PRs (#143)
It looks like CIhttps://syfuhs2.visualstudio.com/Kerberos.NET/_build doesn't run on commits to master or for PR.
At least the badge in ReadMe points to a different (previous) config of CI.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/Kerberos.NET/issues/143, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAJHTYIT7CXB7X4CK5SAYALRKH4ATANCNFSM4LXS64LQ.

The build has been migrated to use the dotnet/ repo now.


[Error] Cloud flare clearance failed, please wait one minute and try again

[Error] Cloud flare clearance failed, please wait one minute and try again
I'm not sure how closely this tool is being updated anymore, but I was curious if there was a fix for this?
Thank you for any help.

Please test the 1.29.2 release and let me know if it is working for you again.  Thanks!


Add REA filters

Fixes #255
Very simple API

This PR needs to be updated to 1.19.4

Updated to 1.20

We will need this for 1.21.2 and the new fuel system. I finally though of a good way of doing it, and ill update the pr soon.


QR Code Static Content section

This should be static content coming from the word doc and placed in a section. No new block should be needed. This may require adding a few section styles.

Duplicate of #40


Make assert less timing sensitive

This is causing nodejs's CITGM to report a fail in testing regressions in winston
Ref: https://github.com/nodejs/node/wiki/CITGM-know-flakes

If you could consider removing this assert completely, since I'm just guessing with the numbers...

@refack thanks for reaching out. The referenced CITGM issue has been closed – is this still helpful? cc/ @mylesborins

What was done in https://github.com/nodejs/citgm/pull/420 is to mark the winston test suite as flaky, so if any tests in the suite fails it will show up as "yellow". This will shadow any real breakage that might occur.
If you get the test suite to play nice with CitGM, you can file to remove the "flake" marker, that way we all get better notification is case any node core changes break something in winston.
FYI smoke testing with CitGM is as easy as:
$ npm i citgm
$ .\node_modules\.bin\citgm winston

Pretty sure we can close this, looks like old 2.x issue, but CITGM for winston should hopefully be looking good once we push out this 3.2 release in the next few days or so.  cf https://github.com/winstonjs/winston/issues/1541

@DABH, thanks for the follow up.
I'll put an reminder for myself to verify.


Building/Compiling

Please note that this is developed against MSVC 2015, so other compilers may not work, and earlier versions of MSVC almost certainly won't due to C++11 support.

That's what the readme says, but Caprica.vcxproj is configured for ToolsVersion="15.0"  and <PlatformToolset>v141</PlatformToolset>.
The project also contains paths for boost_1_58_0, but CMakeLists.txt is looking for:
find_package(Boost 1.52.0 COMPONENTS filesystem program_options REQUIRED)

Just trying to open the project in VS2015 was a pain, but opening the project in VS2017 was a breeze. That said, I can't get Caprica to compile due to a wide assortment of errors. I was wondering if you could fix this project up so that it can be compiled, as well as some build instructions.

Looks like a number of changes were made recently to support VS2017.
Code Change
Line 65 in main.cpp:
      if (filenameRef != "." && filenameRef != "..") {

Change to:
      if (!pathEq(filenameRef, ".") && !pathEq(filenameRef, "..")) {

Project Changes

Add _HAS_AUTO_PTR_ETC;_LIBCPP_ENABLE_CXX17_REMOVED_AUTO_PTR; to preprocessor definitions. (Might need only the second one.)
Fix the include path to Boost.
Build Boost.

Building Boost

Run VS2017 Developer Tools.
Change the directory to where Boost was extracted (e.g., cd D:\dev\boost_1_58_0).
Run bootstrap.
Run b2 address-model=64.
Run b2 build-type=complete.
Add D:/dev/boost_1_58_0/stage/lib; to the linker library directories.

The code for Caprica hasn't been touched in > 2.5 years at this point, and I'd strongly recommend using the official Papyrus compiler included in the Creation Kit rather than Caprica. Caprica was only ever designed to be a workaround when the Creation Kit hadn't yet released.
I would accept PRs if you want to get it back up and running, but I have no plans to do so myself.


Add a Dockerfile

so it's easier for people to get this up and running and then, running a bunch of different commands.

PR submitted:Add dockerfile & docker compose


When will this be in store?

This board is perfect for our use case.
I would love to buy it.
When will it be availiable?

SimpleFOCMini is available in the shop. :D


Avoid rehashing when populating a hashtable with known number of items

It seems at the moment there is not an API to allow reserve space before inserting items. So rehashing cost become prohibitive when I tried to populate a microdict table with 32M items.
I also tried the .update method and the result is the same.
Can we add a method to allow reserve space so that we can avoid the rehashing cost?

This is a good use case. I am putting this on my TODO list for the next release, which unfortunately won't be coming out before at least a month or two.


Get fix IP for services for NAT access

To expose any services through NAT a fix IP address is needed through which services are exposed.
Options for this are:

kube-vip cloud provider
MetalLB

Couldn't get kube-vip cloud provider working, so MetalLB is the winner for this.


added variation attributes array to item

added attribute for item: that's variation attribute array.
For test, please use the following code:
List<string> AsinsList = new List<string>();
AsinsList.Add("B01MA3WIFX");
var authentication = new AmazonAuthentication
{
   AccessKey = "xxxxxxx",
   SecretKey = "xxxxxxxxx"
};

var wrapper = new AmazonWrapper(authentication, AmazonEndpoint.UK, "xxxxxxx");
AmazonItemResponse result = wrapper.Lookup(AsinsList, AmazonResponseGroup.Variations | AmazonResponseGroup.OfferFull | AmazonResponseGroup.Large | AmazonResponseGroup.VariationImages | AmazonResponseGroup.VariationSummary | AmazonResponseGroup.VariationMatrix | AmazonResponseGroup.VariationOffers);
var attributes = result.Items.Item[0].Variations.Item[0].VariationAttributes;

Thanks


Sass errors are not obvious as the kit uses previously compiled sass in .tmp

Description of the issue

I think this is a regression - we had this previously and fixed it: #295
If you have any error in your sass, the kit will continue to run using css compiled in .tmp. It will however fail to deploy as that involves rendering from scratch.
Steps to reproduce the issue

Run the kit without sass errors
Introduce a sass error

Actual vs expected behaviour

Actual:
The kit appears to run normally - new sass changes will not appear but that is not always obvious
Expected:
The error should be clear to the user - the kit will fail to deploy in this state
Environment (where applicable)

Operating system: Mac OS
Browser: Chrome
Browser version:  113.0.5672.63
GOV.UK Prototype Kit version: 13.7.0-rc.0

What I think this ticket asks for is:

If there is an error (not a warning) that leads to SCSS compilation failure then we should show that to the user in an error page

That means that when someone has a working kit breaks the SCSS they won't be able to render their pages until they've resolved the issue.
It also means that if someone clones a project which has an SCSS error in it they won't be able to see any pages until they've resolved the error.
The current behaviour is:
When cloning a kit with broken scss:
/Users/natalie.carey/projects/prototype-kits/2023-05-23/node_modules/govuk-prototype-kit/lib/utils/index.js:189
      throw new Error(`File ${filename} does not exist`)
            ^

Error: File /Users/natalie.carey/projects/prototype-kits/2023-05-23/.tmp/public/stylesheets/application.css does not exist
    at waitUntilFileExists (/Users/natalie.carey/projects/prototype-kits/2023-05-23/node_modules/govuk-prototype-kit/lib/utils/index.js:189:13)
    at async Object.runDevServer (/Users/natalie.carey/projects/prototype-kits/2023-05-23/node_modules/govuk-prototype-kit/lib/dev-server.js:36:3)
    at async runDev (/Users/natalie.carey/projects/prototype-kits/2023-05-23/node_modules/govuk-prototype-kit/bin/cli:399:3)

In this case the kit doesn't start and there's no in-browser error page
When there has previously been a successful sass build but now it's broken:
Pages are rendered with the old compiled css.
In these cases I believe we should be showing an error page rather than a page that looks correct but is not reflecting the current state of the project.
@joelanman do you agree with what I've put here?  I think it's the same thing you're expecting but I just want to make sure.


Allow a machine to configure the default Python interpreter version

Codespaces recently updated its base image to pre-install Jupyter along with a handful of ubiquitous ML libraries (e.g. pandas, torch, etc.). These libraries are installed into the context of the latest version of Python that's installed (currently 3.10.4), which is also set as the default Python version in the user's $PATH. Because of this, it would be ideal if when a user opened an *.ipynb file in a Codespace, that we could have it automatically select the kernel for the latest Python version. That way, there's a seamless continuity between the terminal and notebooks, without the user needing to select a kernel manually, and potentially get confused.
For example, the following is a screenshot of what the kernel picker looks like in a Codespace, and it would be awesome if we could somehow configure the environment to pre-select Python 3.10.4 64-bit.

I'm not quite following from this discussion what's not working or expected here from the Python extension side. Is it due to the fact that there are two Python 3.10 installs and we select the wrong one by default?

These libraries are installed into the context of the latest version of Python that's installed (currently 3.10.4), which is also set as the default Python version in the user's $PATH

As I understand the ask is to select the default Python version on $PATH automatically, in that case this is a dup of https://github.com/microsoft/vscode-python/issues/19818. Let me know if that's not the case and we can reopen the issue.


Improve error message if user couldn't be found

When providing a wrong username that's not available on Blossom, the bot currently throws a generic Blossom error:

Instead, the bot should say which username was incorrect and ask the user to fix it.

This has been fixed by #113.


Coverage has significantly dicreased after nx update

What happened?
The code coverage score has decreased by 30 points after Nx update.
What would you expect to happen?
The score would correctly update to the changes (no big fluctuation was expected).
Code PushUp package version
0.25.4
What operation system are you on?
Linux
Node version
20.0.0
Relevant information

commit link
portal link

The coverage is lower when running the plugin locally as well.

Check if related to #540

I found out what the issue is.
We are providing both unit test and integration test results from the CLI to the plugin.
However, inside the plugin, there is no logic that would merge results if the same source file is found in multiple reports.
So, currently, the score is calculated from unit tests and integration tests as if they belonged to different projects. And issues are created for both separately.
What needs to happen is to merge results should a file be covered by different types of tests. And calculate the coverage score and issues only once all results are merged.


idea - bind resolved data to controller

I'm trying to make everything in my app a component(directive), and resolve as much as possible in the ui-router state, to ensure the component has all it needs when the state is loaded.
This is an example of what I'm referring to:
.state('my-state', {
  template: '<my-component data="ctrl.data" type="ctrl.type"></my-component>',
  resolve: {
    data: function($http) {
      return $http.get('/api/getMyData');
    },
    type: function(myService) {
      return myService.getType();
    }
  },
  controller: function(data, type) {
    this.data = data;
    this.type = type;
  },
  controllerAs: 'ctrl'
});

I find my self needing to repeat the this.data = data, this.type = type parts for almost all my states.
I think that supporting a bindToController option, that will insert resolved data in the controller will be helpful here, similar to a directive's definition object.
What do you guys think? if this sounds right I can even try to implement it, as it looks like a simple addition.

I think it might be harder then you think it is. Have you looked to see if the feature-1.0 branch does this yet? If not, you can try taking a stab at it to see if its possible.

If you're writing ES6, you can just do angular.extend(this, { data, type }).

I am, but I'm want to remove the need to even to that.
I might be missing something, but it makes sense to me while attempting to treat each state as a component that receives data solely via resolves when it comes to external state.
It'll probably look like that:
.state('my-state', {
  template: '<my-component data="ctrl.data" type="ctrl.type"></my-component>',
  resolve: {
    data: function($http) {
      return $http.get('/api/getMyData');
    },
    type: function(myService) {
      return myService.getType();
    }
  },
  controller: angular.noop,
  controllerAs: 'ctrl'
});

The angular.noop + controllerAs might be dropped if the resolve params are added to the created $scope.
I'll fork and try to do achieve it. Will update so you guys can decide wether it fits the main branch or not. Worst case I'll stick to the fork :)

You could probably combine controllerProvider with some state introspection to do this automatically.

Huh, I thought I commented already...
I think the idea behind this request is reasonable.  I've considered something very similar myself. This is something we may want to consider post-1.0

I'd love to see this make it in too.  I think a bindToController option would be great here.  My controllers often directly take all those arguments and attach them right away to the controller.

:+1:

In 1.0, resolves are now much lazier than they are in 0.2.15.  For example, if a resolve is defined but never requested for injection, the resolve fn may never be called (we're calling this the "JIT" resolve policy).  We'd have to decide on some rules for behavior.
In 1.0, we've got a few building blocks that could help implement this idea:
We have a Resolvable object, which has a .get() fn which returns the resolved data, or a Promise for the resolved data.
We have a ResolveContext object, which has a .getResolvables() fn, which returns a map of all the resolvables for that context.
We have a Path object for the path in the state tree that is being entered.  Each node in the path corresponds to a nested state, and has a ResolveContext.
I think we could expose the ResolveContext object as an injectable object for all the ui-router injection points (similar to $stateParams), then let the callers explicitly use the resolve data.  I think I'd prefer this over another configuration option
Perhaps something like this:
.state({
  name: 'foo',
  resolve: {
    resolve1: ($http) => $http.get("/foo.json").then((resp) => resp.data) ,
    resolve2: ($http) => $http.get("/bar.json").then((resp) => resp.data)
  },
  resolvePolicy: { resolve2: "JIT" },
  controller: ($resolve$) => {
    let keys = Object.keys($resolve$); // [ "resolve1", "resolve2" ]
    let resolvedFoo = $resolve$.resolve1; // data is fully resolved
    let resolveBar = $resolve$.resolve2; // a JIT promise for the resolved data?
  }
})
.state({
  name: 'foo.bar',
  resolve: {
    resolve3: ($http) => $http.get("/baz.json").then((resp) => resp.data) ,
  },
  controller: ($resolve$, resolve2) => {
    let keys = Object.keys($resolve$); // [ "resolve1", "resolve2", "resolve3" ]
    let resolvedFoo = $resolve$.resolve1; // data is fully resolved
    let resolveBar = $resolve$.resolve2; // data is fully resolved because of injection
    let resolveBaz = $resolve$.resolve3; // data is fully resolved
    angular.extend(this, $resolve$); // resolved data is on controller
  }
})

summon @nateabele @wesleycho @eddiemonge

I think we could expose the ResolveContext object as an injectable object for all the ui-router injection points (similar to $stateParams), then let the callers explicitly use the resolve data. I think I'd prefer this over another configuration option

Concur 100%.

resolve: {
resolve1: ($http) => $http.get("/foo.json").then((resp) => resp.data) ,
resolve2: ($http) => $http.get("/bar.json").then((resp) => resp.data)
},
resolvePolicy: { resolve2: "JIT" },

I think I'd prefer a structure that involved less repetition, but that's sort of a minor thing.

I feel like users should explicitly choose to bind data in the controller.
bindToController, if implemented, should probably match how bindToController works in the DDO as part of the Angular API itself, and not handle resolves that way.

+1

I would like to add that if one is using TypeScript, one can easily bind to the controller by declaring public or private in the constructor for the controller.
IMO this shouldn't be supported in the library itself. UI Router is already very config heavy, and adding more minor config bloats up the library with what is supported & can potentially hurt extendibility down the road.

+1

-1 on this.
It would be better to just export $resolve to scope, especially since angular shifting to component-based approach. This is already done in ngRoute.
resolve: {
    resolve1: ($http) => $http.get("/foo.json").then((resp) => resp.data) ,
    resolve2: ($http) => $http.get("/bar.json").then((resp) => resp.data)
},
template: `<my-component foo="$resolve.resolve1" bar="$resolve.resolve2"></my-component>`

+1 for @fesor

@fesor thanks for the hint

dear @GabiGrin perhaps something like this will do the trick
state('route_param_state', {
    url: '/a_path/:anId',
    templateUrl: '/the_template.html',
    controller: 'The Name of the register controler',
    controllerAs: 'ctr', // keep it simple
    resolve: {
      "": ($http: ng.IHttpService, $stateParams: ng.ui.IStateParamsService) => {
        var parsedId =  +$stateParams["anId"]
        return $http.get("/your_api/v1/thing/" + parsedId).then((response) => {
          $stateParams["data"] = response.data
        })
      }
    }
   })

And you will have in $stateParams the data you required.


Add Floquet calibration docs

Same as internal colab with appropriate modifications for hardware (default to simulator) and website.
Note: Currently installs from particular branch - this should be updated when possible.

This is now merged: https://github.com/quantumlib/Cirq/pull/3752
You can update and fix method names.

This looks good, I would only wait/ping Matthew what's his opinion on Cirq install in the notebook.

oh one more thing: as this relies on external dependencies, we want to exclude the notebooks from the devsite testing pipeline - the only way to do that is to save the outputs for all cells in the notebook.

This is a nice walkthrough of all the floquet functionality. As such, it gets a bit overwhelmed by the FHM-style code. I added some suggestions for stripping the demo circuits down to the bare essentials, but I think it would benefit from an even more aggressive simplification of the example multi-qubit circuit

oh one more thing: as this relies on external dependencies, we want to exclude the notebooks from the devsite testing pipeline - the only way to do that is to save the outputs for all cells in the notebook.

What external dependencies? Just because it uses unreleased features?

oh one more thing: as this relies on external dependencies, we want to exclude the notebooks from the devsite testing pipeline - the only way to do that is to save the outputs for all cells in the notebook.

What external dependencies? Just because it uses unreleased features?

I should use a different word - I meant an API call. This notebook relies on Engine calls, right?

I should use a different word - I meant an API call. This notebook relies on Engine calls, right?

It can use Engine calls but defaults to PhasedFSimEngineSimulator so it can actually be run without authentication.
I like the pattern you suggested in tutorials/google/start.ipynb (https://github.com/quantumlib/Cirq/pull/3765#discussion_r573978650), but this throws an error on no authentication. Do we want to do this? An advantage of using PhasedFSimEngineSimulator was not having to answer "is it ok to include saved processor data in a public tutorial?" which was hard to get a consensus on. And I guess it can also be tested this way.

@balopat following up on previous comment, what do you think about

Try to authenticate as in tutorial/google/start.ipynb
If project_id is not provided, default to PhasedFSimEngineSimulator

This way we would continue to test the notebook, wouldn't have to save processor data and make it public, and provide an easy way to authenticate/use the engine (which is currently missing).

@balopat following up on previous comment, what do you think about

Try to authenticate as in tutorial/google/start.ipynb
If project_id is not provided, default to PhasedFSimEngineSimulator

This way we would continue to test the notebook, wouldn't have to save processor data and make it public, and provide an easy way to authenticate/use the engine (which is currently missing).

I really like that approach! Let's see if it works!

Ryan, I'm doing one more change in naming here: #3810 which will be more consistent with a small feature I'm adding now.

Ryan, I'm doing one more change in naming here: #3810 which will be more consistent with a small feature I'm adding now.

Thanks for the heads up. I'll update once #3810 is merged.

#3810 has been merged

@mpharrigan friendly ping for review


Feature play zoomlogin

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

I added a new play: zoom login and chatbot clone project.
I fixed an existing play 'schulte-tables' as it used plain class name '.flex' and overrided tailwind classnames and made mess. This can potentially happen to future work hence I editted it to have a more specific name (.flex -> .schulte-tables-flex)
dependencies: react-chatbot-kit

Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Screenshots or example output

thanks for fixing

I fixed an existing play 'schulte-tables' as it used plain class name '.flex' and overrided tailwind classnames and made mess. This can potentially happen to future work hence I editted it to have a more specific name (.flex -> .schulte-tables-flex)

@day-lee Could you please check the responsive design?


Board Review: Personalizer thick client story

Thank you for submitting this review request. Thorough review of your client library ensures that your APIs are consistent with the guidelines and the consumers of your client library have a consistently good experience when using Azure.
The Architecture Board reviews Track 2 libraries only. If your library does not meet this requirement, please reach out to Architecture Board before creating the issue.
Please reference our review process guidelines to understand what is being asked for in the issue template.
To ensure consistency, all Tier-1 languages (C#, TypeScript, Java, Python) will generally be reviewed together.  In expansive libraries, we will pair dynamic languages (Python, TypeScript) together, and strongly typed languages (C#, Java) together in separate meetings.
For Tier-2 languages (C, C++, Go, Android, iOS), the review will be on an as-needed basis.
Before submitting, ensure you adjust the title of the issue appropriately.
Note that the required material must be included before a meeting can be scheduled.
Contacts and Timeline

Responsible service team: Azure Personalizer
Main contacts: @johnhuang01
Expected code complete date: 02/21/2022
Expected release date: 02/22/2022

About the Service

Link to documentation introducing/describing the service:

Thick-client design doc
Model Put API

Link to the service REST APIs:

https://github.com/Azure/azure-rest-api-specs/blob/b6f54bbdbb64a9e7d27b49b4e1db5e56e40c310d/specification/cognitiveservices/data-plane/Personalizer/preview/v1.1-preview.3/Personalizer.json

Link to GitHub issue for previous review sessions, if applicable:

https://github.com/Azure/azure-sdk/issues/3124

About the client library

Name of the client library: Azure.AI.Personalizer
Languages for this review: C#

Artifacts required (per language)
Please read through “API Review” section here to understand how these artifacts are generated. It is critical that these artifacts are present and are in the right format. If not, the language architects cannot review them with the SDK Team’s API review tool.
.NET

APIView Link: https://apiview.dev/Assemblies/Review/5591b4c1c6ef46369ae25ec62bc1d058?diffRevisionId=bc708db2898e475db324fc2d686b1b34&doc=False&diffOnly=False
Link to Champion Scenarios/Quickstart samples:

Rank tests
Model tests

Java

APIView Link:
Link to Champion Scenarios/Quickstart samples:

Python

APIView Link:
Link to Champion Scenarios/Quickstart samples:

TypeScript

APIView Link:
Link to Champion Scenarios/Quickstart samples:

For all other languages, send a request to the Architecture Board to discuss the best format on individual basis.
Thank you!

Design doc:
Thick client:
https://microsoft.sharepoint.com/:w:/t/personalizr/EVXhfzFkZ5RHlLm8SK6C1xwBuUkLQSvDQqwoKuvAAI628Q?e=Oluwcv
Model Put API:
https://microsoft.sharepoint.com/:w:/t/personalizr/Ed0dN7HgEF9EhKj9Bx5BRfkBfu9Q6o9Fw_SeFW9X3F96EQ?e=ZP9W2X&CID=D24A1141-04ED-43CA-8278-74C8AC7BE91B&wdLOR=cC1B79B0D-2E02-47B5-ACAD-32C62A0B2799
Sample Codes:
\azure-sdk-for-net\sdk\personalizer\Azure.AI.Personalizer\src\Samples\SampleCode.cs

scheduled for 2/17 2-4pm pst

Responsible service team: Personalizer
Main contacts: @johnhuang01
Expected code complete date: 2/21/2022
Expected release date: 2/22/2022
Link to the service REST APIs:
https://github.com/Azure/azure-rest-api-specs/blob/b6f54bbdbb64a9e7d27b49b4e1db5e56e40c310d/specification/cognitiveservices/data-plane/Personalizer/preview/v1.1-preview.3/Personalizer.json

Microsoft.RL api view:  https://apiview.dev/Assemblies/Review/57da3635d2274aef8aad975074c414f7

Recording[MS INTERNAL ONLY]


Can't find optical drives

Hi,
I'm trying to rip some DVDs onto our NAS, running on Ubuntu 18.04.4, docker community edition 19.03.8.
The optical disc is on /dev/sr0 and /dev/sg0 as confirmed by running the container without passing any devices with the --device flag.  The only srX is sr0. Privileged mode doesn't help either.
After around 20 seconds after booting, the pane at the bottom states:

The program can't find any usable optical drives.

The container can extract MKVs from an ISO from the hard drive. By using your handbrake container, I can rip the DVD from /dev/sr0 but once I move onto the blurays I've got to do, handbrake won't work. I've tried v1.13.1 and latest of your makemkv container.
The logs are:
[cont-init.d] 90-makemkv.sh: exited 0.
[cont-init.d] 95-check-optical-drive.sh: executing...
[cont-init.d] 95-check-optical-drive.sh: looking for usable optical drives...
[cont-init.d] 95-check-optical-drive.sh: found optical drive [/dev/sr0, /dev/sg0], group 24.
[cont-init.d] 95-check-optical-drive.sh: exited 0.
[cont-init.d] 96-install-autodiscripper-srv.sh: executing...
[cont-init.d] 96-install-autodiscripper-srv.sh: automatic disc ripper disabled.
[cont-init.d] 96-install-autodiscripper-srv.sh: exited 0.
[cont-init.d] done.

Permissions for the device seem fine:
$ ls -la /dev/sg*
   crw-rw-rw-+ 1 root cdrom 21, 0 Apr 12 19:27 /dev/sg0
   crw-rw----  1 root disk  21, 1 Apr 12 19:27 /dev/sg1
   crw-rw----  1 root disk  21, 2 Apr 12 19:27 /dev/sg2
   crw-rw----  1 root disk  21, 3 Apr 12 19:27 /dev/sg3
   crw-rw----  1 root disk  21, 4 Apr 12 19:27 /dev/sg4

$ ls -la /dev/sr*
   brw-rw-rw-+ 1 root cdrom 11, 0 Apr 13 00:53 /dev/sr0

Have you got any advice I could try?
Many thanks,
James

If privileged mode didn't help, I'm not sure what could be the problem.
Could you provide the output of :
docker exec -ti <container name> /opt/makemkv/bin/makemkvcon -r --cache=1 info disc:9999

Also, try latest image, which have an updated version MakeMKV.

Hi,
I've attached the output of the command and updated to the newest version of the image.
$ docker exec -ti makemkv /opt/makemkv/bin/makemkvcon -r --cache=1 info disc:9999
MSG:1005,0,1,"MakeMKV v1.15.1 linux(x64-release) started","%1 started","MakeMKV v1.15.1 linux(x64-release)"
MSG:5074,0,0,"Automatic checking for updates is enabled, you may disable it in preferences if you don't want MakeMKV to contact web server.","Automatic checking for updates is enabled, you may disable it in preferences if you don't want MakeMKV to contact web server."
MSG:5042,0,0,"The program can't find any usable optical drives.","The program can't find any usable optical drives."
DRV:0,256,999,0,"","",""
DRV:1,256,999,0,"","",""
DRV:2,256,999,0,"","",""
DRV:3,256,999,0,"","",""
DRV:4,256,999,0,"","",""
DRV:5,256,999,0,"","",""
DRV:6,256,999,0,"","",""
DRV:7,256,999,0,"","",""
DRV:8,256,999,0,"","",""
DRV:9,256,999,0,"","",""
DRV:10,256,999,0,"","",""
DRV:11,256,999,0,"","",""
DRV:12,256,999,0,"","",""
DRV:13,256,999,0,"","",""
DRV:14,256,999,0,"","",""
DRV:15,256,999,0,"","",""
MSG:5010,0,0,"Failed to open disc","Failed to open disc"
TCOUNT:0

I've also reinstalled ubuntu which aside from changing the drive mappings (which I've updated) hasn't helped. I'm leaning towards thinking this is an issue with the specific drive I'm using and MakeMKV, as I tried MakeMKV with this drive on a windows laptop to no avail.
Thanks,
James

Looks like MakeMKV is not seeing the drive.  And if you tried on a laptop and the drive is still not seen, then it's definitely an issue/incompatibility with MakeMKV.

Yeah I think that's the most likely scenario unfortunately. I'll mark this as closed and do some more research before reporting a bug to MakeMKV directly.
Thanks


[mp] blocks api docs

Description
This adds documentation for the Blocks API and edits Pipelines API docs to be cohesive. It also makes use of Mintlify's RequestExample & ResponseExample to display requests and responses to the side of the request params/descriptions.
Add

Blocks API

Create
Delete
Update
Read
Overview

Edit

Pipelines API

Overview

How Has This Been Tested?

[ ] mintlify dev
[ ] mintlify broken-links

Checklist

[x] The PR is tagged with proper labels (bug, enhancement, feature, documentation)
[x] I have performed a self-review of my own code
[ ] I have added unit tests that prove my fix is effective or that my feature works
[x] I have made corresponding changes to the documentation

cc: @johnson-mage

@mattppal There were some changes needed in the Create pipeline section as well (docs/api-reference/pipelines/create-pipeline.mdx file), like removing the properties no longer relevant. Were you going to make those updates in this PR also?

@johnson-mage just checked, I think everything in there right now makes sense

You might be getting those properties confused with the Create block API. When creating a pipeline, you really only need name and type, and if you're cloning a pipeline, clone_pipeline_uuid. The type for a pipeline can be integration, python (i.e. standard/batch), pyspark, or streaming. The ones from the screenshot are for block types.

For block color, that's specifically for custom blocks. The other block types have set block colors.

Block language should also include markdown.

These block types are missing :conditional, global_data_product, and markdown. https://github.com/mage-ai/mage-ai/blob/master/mage_ai/data_preparation/models/constants.py#L42-L55

@johnson-mage just checked, I think everything in there right now makes sense

@mattppal Some of those properties can just be included in the Update pipeline API (e.g. callbacks, conditionals, extensions). When creating a pipeline, you really only need name and type, and if you're cloning a pipeline, clone_pipeline_uuid. The type for a pipeline can be integration, python (i.e. standard/batch), pyspark, or streaming. The ones from the screenshot are for block types.

Nice catch!


Allowing for different fonts for ground items

Hello
First off thanks for the absolutely amazing client.
I was just wondering if it would be possible to make an option to select different fonts for the ground items in the client. I found shrinking the font did make it a bit better, but I really prefer the osbuddy/runeloader fonts a bit more appealing, but I am not going to use those just for fonts. It really is only a small issue personally and really is no big deal. I'd love having the option though.
Thanks!

See #1651

@Kamielvf  Thank You for the reference!

Is that what you want? As OSB uses the bold font I think. And adding non-rs font support would destroy the look if that is your request.

@deathbeam #1605 #1651 I think answered my question. Sorry for the confusing post but yes the bold font option is really what i was looking for. I was under the impression that they were just different fonts. Shall I delete the issue?

I will close it as duplicate of #1605 then.


Devicemanager enhancements

Added two new fields to PmemDeviceInfo structure:

Mode : holds the device namespace mode
NumaNode: hods the numa node to which the device attached to

In LVM mode we use the volume group tags for storing these details.

Can you explain why this is useful?

Can you explain why this is useful?

NSMode:
As I made a note here: https://github.com/intel/pmem-csi/pull/383/files#diff-4a0caa0c2e37db715640b7cbf97d7a1fR263-R267 , the PMEM device should have a way to knowin which mode it was created, currently this information is with VolumeContext, but I feel the right place is PmemDeviceInfo structure.
NumaNode:
Its just an enabler change to make the driver numa aware, though the solution is still under investigation. Numa APIs in ndctl layer are useful to know a pmem region's numa  node, if we wants to support PMEM device creation in given numa node region.

@avalluri: do we still need this PR?

@avalluri: do we still need this PR?

Yes, I believe. It would be useful at least logging NUMA node related information of a device.

@avalluri : is this PR still relevant?

@avalluri : is this PR still relevant?

Yes if we need to track/log the numa node details of a volume. If not we can ignore and close the PR.

Yes if we need to track/log the numa node details of a volume

I don't think we have such a requirement. Are you aware of one? You were working with Sasha on NUMA.

Yes if we need to track/log the numa node details of a volume

I don't think we have such a requirement. Are you aware of one? You were working with Sasha on NUMA.

There is no such requirement enforced by CRI-RM. But in general, I feel like there is no easy way to know to which NUMA node a particular PMEM-CSI volume is attached to while debugging the performance of an application that using this volume.

I feel like there is no easy way to know to which NUMA node a particular PMEM-CSI volume is attached to while debugging the performance of an application that using this volume.

So you want to expose that to the user? That seems worthwhile, but then we also need to define how users actually get that information. Log file parsing IMHO shouldn't be the answer.

Log file parsing IMHO shouldn't be the answer.

Perhaps some metric? We should explore further what we can do with those.

Log file parsing IMHO shouldn't be the answer.

Perhaps some metric? We should explore further what we can do with those.

Yes, I agree.

@avalluri can we close this PR until there is a need for it?

@avalluri can we close this PR until there is a need for it?

@avalluri can we close this PR until there is a need for it?

Okay.

@avalluri can we close this PR until there is a need for it?

Okay.


use ubi8 container base image

Codecov Report

Merging #195 (1931813) into main (f13dc86) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
- Coverage   58.25%   58.19%   -0.07%
==========================================
  Files          58       58
  Lines        3349     3356       +7
==========================================
+ Hits         1951     1953       +2
- Misses       1269     1273       +4
- Partials      129      130       +1

Flag
Coverage Δ

unittests
58.19% <ø> (-0.07%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/confgen/grafana_jsonnet.go
0.00% <0.00%> (ø)

pkg/pipeline/ingest/ingest_collector.go
65.28% <0.00%> (+1.65%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f13dc86...1931813. Read the comment docs.

During testing:
#19 [builder 11/13] RUN rm -rf bin
#19 sha256:e43a290424418aed9f6c6df124a2219c17fe689013c400100d48d81d458e665e
#19 0.983 rm: cannot remove 'bin/golangci-lint-v1.43.0': Permission denied
#19 0.983 rm: cannot remove 'bin/kind-v0.11.1': Permission denied
#19 ERROR: executor failed running [/bin/sh -c rm -rf bin]: exit code: 1
Not sure why permission is denied.
Commented out the command RUN rm -rf bin.

@jotak can you please check this PR ... is there a better way to get golang 1.17 ???

about the go-toolset image and go1.17: we have the same workaround on other images. Maybe we can have our own "netobserv/go-toolset" image to avoid fixing all components one by one ...

@KalmanMeth @eranra the final stage here is still using ubuntu, I think we need either to change all stages to ubi8, or none (the whole purpose being to have a common base across components to make it easier to maintain / check vulnerabilities & upgrades).
But to be honest, I see also that there's included some net tools with the image, I don't want to force moving to ubi8 if you have the tooling you want with this current Dockerfile, the goal is not to make troubleshooting harder.

@KalmanMeth @eranra the final stage here is still using ubuntu, I think we need either to change all stages to ubi8, or none (the whole purpose being to have a common base across components to make it easier to maintain / check vulnerabilities & upgrades).
But to be honest, I see also that there's included some net tools with the image, I don't want to force moving to ubi8 if you have the tooling you want with this current Dockerfile, the goal is not to make troubleshooting harder.

@KalmanMeth what we want to make sure is that even with ubi8 we still have the simple tools to understand processes and networks. I also assume that the ubi8 image do not include or allow any package manager such as yum or apt so what I propose is to copy get those tools in the builder stage and make sure that we copy them into the ubi container. Exacely like what we are doing to the executables we compile https://github.com/netobserv/flowlogs-pipeline/pull/195/files#diff-e818f6b11598d2656922413d3912abb820c175e2f739549dbda55cc9559bd6fdL28
This will allow us on one hand to work with ubi8 as needed for security but have those tools handy if needed.
@jotak does this make sense and acceptable?

thanks @KalmanMeth @eranra and sorry for the delay 😬
/lgtm


Add files via upload

use os environment to disable last digest check

Unfortunately, I can't accept this patch as-is, because it introduces indentation issues of the Python code.
Also, it would be nice to have some rationale behind the change: Why disabling the remove digest check? What is the benefit? What are the situations in which this safety feature can be disabled with introducing a large risk?
BTW, I strongly recommend using Git, rather than editing the source on the GitHub web interface. That one is noce for wiki and documentation pages, but not a good choice for editing code.

To anyone involved in this issue, please see #16 "Future of bscp".

I'm closing and rejecting this pull request now, as there has been no activity for a long time to address the reported issues with the pull request.
@art0int Please feel free to open a new pull request if you like to continue this work.


Removed duplicate sections

The paragraphs with the title "Understand the basic features" and "Consider limits and cost" appeared twice on the page with the exact same content. Kept the first appearances that fit better in the section order.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: 0x1D-1983 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@0x1D-1983 : Thanks for your contribution! The author(s) have been notified to review your proposed change. @MikeWasson

#assign: @MikeWasson

MikeWasson is not a valid GitHub ID, or is not a collaborator on this repo.

#signoff