Feature Request: Extend Hotkeys or Allow Custom Ones

Is there an existing issue for this?

[X] I have searched the existing issues

Which Mux Elements/Packages does this apply to? Select all that apply
mux-player
Description
It would be great to have additional hotkeys for adjusting the playback speed (e.g. s) and enabling and disabling the picture-in-picture mode (e.g. p). If you don't want to add these hotkeys by default, it would be great if I could add them using e.g. JavaScript event handlers myself.
Expected Behavior
I can circle through the playback speed options using the s key and enable/disable picture-in-picture mode using the p key.

Oh boy this one's a bit trickier to add. Also not a bad request, but not sure if we'll be adding this one as soon. This would also be a Media Chrome feature. If we could provide you with a workaround at the app layer, would that be of interest to you for the interim?

Ah I see. Yes, if I could add a keybinding myself and change the playback speed programmatically, that'd be great and feasible for me. My only question would be: How can I know which playback speeds does the mux-player support? So, if I want to change the speed through an API call, I would need to know the possible options. I could also imagine an API that simply make the video one step faster or slower. That'd work as well. The changes would need to be reflected in the UI though. So, after I make the call, the playback speed UI in the player should update too. And possibly the settings should be persisted in LocalStorage as discussed in the other ticket.


Can't make  to render

Hi @yhatt - I'm facing an issue with the
 element, I wonder if you could help me? It looks to me like a bug related to jsx-slack.
Here is what I'm trying to do:
await client.chat.postMessage({
      token: botToken,
      channel,
      text: 'Sorry about that. Please report an issue to your administrator.',
      blocks: JSXSlack(
        <Blocks>

First item

Second item

        </Blocks>
      )
    });

and I'm getting the following error:
[ERROR]  bolt-app ERROR: TypeError: Cannot convert object to primitive value

Going further, if I remove the second item, and leave just the first one, I'm getting following error:
[ERROR]  bolt-app ERROR: TypeError: u[t].toString is not a function

If I rename
 to
 (and remove type of course), I'm getting properly displayed unordered list in Slack. So the problem seems to be only with an ordered list. The other elements and blocks are rendered fine.
Note: We recently switched from @speee-js/jsx-slack to jsx-slack - not sure if this is when an issue with ol started to happen, but I think it could be the case.
The project is written in typescript, here is tsconfig.json:
{
  "compilerOptions": {
    "target": "ESNext",
    "module": "commonjs",
    "lib": ["dom", "es6"],
    "allowJs": true,
    "jsx": "react-jsx",
    "jsxImportSource": "jsx-slack",
    "isolatedModules": false,
    "strict": true,
    "noImplicitAny": true,
    "moduleResolution": "node",
    "baseUrl": "src",
    "outDir": "dist",
    "esModuleInterop": true,
    "resolveJsonModule": true,
    "sourceMap": true,
    "paths": {
      "@/*": ["./*"]
    }
  },
  "include": ["src"],
  "exclude": ["dist", "node_modules"]
}

and package.json:
"dependencies": {
    "@sendgrid/mail": "^7.5.0",
    "@slack/bolt": "^3.8.1",
    "@types/mocha": "^8.2.0",
    "@types/node": "^14.17.27",
    "@types/puppeteer": "^5.4.4",
    "axios": "^0.24.0",
    "date-fns": "^2.25.0",
    "dotenv": "^8.2.0",
    "jsx-slack": "^4.5.2",
    "mixpanel": "^0.14.0",
    "module-alias": "^2.2.2",
    "puppeteer": "^10.4.0",
    "typescript": "4.5.2"
  },
  "devDependencies": {
    "@commitlint/cli": "^8.3.5",
    "@commitlint/config-conventional": "^8.3.4",
    "@typescript-eslint/eslint-plugin": "^3.2.0",
    "@typescript-eslint/parser": "^3.2.0",
    "assert": "^2.0.0",
    "eslint": "^7.2.0",
    "eslint-config-prettier": "^6.11.0",
    "eslint-plugin-prettier": "^3.1.3",
    "husky": "^4.2.5",
    "lint-staged": "^10.2.9",
    "mocha": "^8.3.0",
    "prettier": "^2.0.5",
    "ts-node": "^8.10.2",
    "ts-node-dev": "^1.0.0-pre.44",
    "ts-node-paths": "^1.0.1"
  },
  "engines": {
    "node": "14.x"
  }

Thanks!

Thank you for your report 😄
I found out a tricky edge case that came from difference of behavior between JSX runtime for react-jsx mode and JSX conversion for react mode.
I'll work to fix this, but if you are in a hurry, you can apply a workaround by switching to react mode temporarily.
{
  "compilerOptions": {
    "jsx": "react",
    "jsxFactory": "JSXSlack.h",
    "jsxFragmentFactory": "JSXSlack.Fragment",
    // ...
  }
}

When user had JSX like this:

a

b

In react mode, the above JSX will be transformed like this:
JSXSlack.h('ul', { type: '1' },
  JSXSlack.h('li', null, 'a'),
  JSXSlack.h('li', null, 'b'),
)

And in react-jsx mode:
import { jsx } from 'jsx-slack/jsx-runtime'

jsx(
  'ul',
  {
    type: '1',
    children: [
      jsx('li', { children: 'a' }, undefined),
      jsx('li', { children: 'b' }, undefined),
    ]
  },
  undefined
)

There are clear differences about how to pass children elements between react and react-jsx mode.
jsx-slack will try to convert JSX to HTML string for internal like '

'. The second argument in react mode has attributes only user specified (type), but react-jsx mode is including children as an children attribute.
A reported error has caused by trying jsx-slack to generate a string expression of children attribute forcibly, like `<ul type="1" children="${[<li>a</li>, <li>b</li>].toString()}">`. HTML tags such as
 will return an object with an empty prototype (Object.create(null)) so it cannot respond to Object.toString().

I've patched and shipped the latest release jsx-slack v4.5.3. Could you try to update your jsx-slack dependency, and confirm rendering of list?

Hey @yhatt - thanks a ton!
It works fine in v4.5.3


Added fire sword animation sprites.
Created player animator fire sword combo state.

 [FEATURE] Deadly Stab (Dagger + Roll/Dash) Combo

 [SOUND] Forest Ambience


[+0-all-args] Mark all tests that will need updates for +0 as requiri…

…ng a plus_one_runtime.
rdar://34222540

@swift-ci smoke test and merge

The test failures are due to my adding of the REQUIRES line at the top of all of the files resulting in some debug info line numbers getting knocked off slightly.

Ok. Lets try this again.

v

@swift-ci smoke test and merge

The driver test got kill -9. I can't reproduce the failure locally. Rerunning.

@swift-ci smoke test os x platform


lungo:activate does not exist

I'm using node v10.12.0 and I'm getting this error when running any lungo command.
Error: Command failed: open lungo:activate?
The file /Users/bukinoshita/github/lungo:activate? does not exist.

    at ChildProcess.exithandler (child_process.js:289:12)
    at ChildProcess.emit (events.js:182:13)
    at maybeClose (internal/child_process.js:962:16)
    at Socket.stream.socket.on (internal/child_process.js:381:11)
    at Socket.emit (events.js:182:13)
    at Pipe._handle.close (net.js:606:12)

Do you have https://sindresorhus.com/lungo installed?

Yup! I do

Restarted Lungo and now it's working just fine! Thanks


schema: all numbers are also valid as string, but integers arent

For example, users can write their version as a YAML number (e.g. 1.2 or 20190328)  or as YAML string (e.g. 1.12.3 or "1.2") using this part of the schema:
"version": {
    "anyOf": [
        {
            "minLength": 1,
            "type": "string"
        },
        {
            "type": "number"
        }
    ]

but for fields of type integer, this isn't done consistently. For example, one can write:
references:
  - type: generic
    start: 100

but not:
references:
  - type: generic
    start: "100"

even though it is unambiguous.
I think we should consider treating the remaining type: integers the same as type: numbers. I see at least 2 advantages of doing so:

additional leniency makes users' lives easier: if we allow strings for type integers, that means that users dont have to think about / look up what the expected type is, since they can count on all primitive-type fields at least (also) being a string
Any downstream tooling can internally cast to string and still have file contents that are valid according to the schema. I don't think there are any downsides to doing so, because as far as I'm aware there are no tools that depend on integer logic on the user inputs to accomplish their goals.

The affected keys are:

reference.end
reference.loc-end
reference.loc-start
reference.month
reference.number-volumes
reference.pages
reference.start
reference.volume
reference.year
reference.year-original

Perhaps there are other concerns though, happy to hear them

Good catch, thanks. I'll have a look at it, and perhaps @hainesr should do so to check against ruby-cff implementations?

I've done a quick check and it looks like ruby-cff can ingest either of the above examples with no issues. Integers input as strings will be preserved as strings. I guess we'd need a validation to catch people inputting "100.1" wouldn't we?

Fixed in PR #285.

@hainesr: For some keys, "100.1" (or indeed something like "e289" (see the principles paper page "number")) is actually a valid value. And in places where it isn't, we decided to give people the freedom to break the inention if they really want :).

"100.1" would be a valid number, but not a valid integer, surely?


Using Presets with presetAttributify , vitepress build no reponse

"unocss": "^0.37.4",
"vite": "^2.9.9",
"vitepress": "1.0.0-alpha.1"

import Unocss from 'unocss/vite'
import { presetAttributify, presetUno } from 'unocss'

export default defineConfig({
  ...
  plugins: [
    Unocss({
      presets: [
        presetUno(),
        presetAttributify()
      ]
    }),
  ]
})

When Using Presets with presetAttributify , vitepress build no reponse, like this
vitepress v1.0.0-alpha.1
⠇ building client + server bundles...

it's done well when i remove presetAttributify

We temporarily close this due to the lack of enough information.
Please provide a minimal reproduction to reopen the issue.
Thanks.

Why reproduction is required


Use right CCNP validation

Use right schema when validating CCNP in pre-flight upgrade step

Note for backporters, ping me if this does not apply cleanly for 1.6 branch

test-me-please

Coverage increased (+0.01%) to 37.081% when pulling eb8ec18d0b4440f558837af0a0a85479c590094e on aanm:pr/fix-ccnp-validation into 331aab47f35a4b7e329a2038658845134e362a75 on cilium:master.

test-me-please

k8s 4.19 hit https://github.com/cilium/cilium/issues/12120

@aanm what's the v1.6 aspect of this? CCNP didn't land until v1.7.


build with system leveldb

Take #140, rinse, wash, replace libtorrent with leveldb, repeat.

Hi,
I stumbled across this issue just now: Debian Bitcoin package has built with system-shared leveldb since 0.14.2~dfsg-1~exp1.


[blog] DRAFT Introducing MUI Base

Here grows the blog post with the MUI Base announcement.
Preview: https://deploy-preview-33778--material-ui.netlify.app/blog/introducing-mui-base/

This is a great introduction to MUI Base @michaldudak! I especially like how you describe components and slots here—very well put.
I have just a couple big-picture notes:

Is there a way that we can describe, exactly, what MUI Base is in a sentence or two? The introduction makes a lot of implications about what it is, but we never really get one singular concise description of it. We could draw from the Overview page in the docs for this.
The introduction offers some hints at the primary pain point that MUI Base aims to address. How can we translate this into a headline and tagline that will resonate with our target audience? (And who is the target audience here?)
The conclusion needs (no more than) one specific call to action for the reader. What is the one thing we want them to do after reading this post? Try out MUI Base and give feedback? Show us what you're building? Help us prioritize the roadmap for adding new components? I think we should pick one of these.

How can we translate this into a headline and tagline that will resonate with our target audience? (And who is the target audience here?)

The target audience is the developers who have used and know Material UI and need to build something more custom. Could the tagline be "easily build custom design systems with MUI-powered components"? TBH I'm open for ideas here :)

The conclusion needs (no more than) one specific call to action for the reader.

I think the most important part is getting feedback. But do you think we should drop the other two? Or just move them somewhere else?
Generally, if you see any room for improvement, feel free to edit this PR directly.

Added the social card, hero, and a revamped switch breakdown image there. Let me know your thoughts about the introduction image － I've been playing around with concepts to showcase the "unstyled" aspect of it but it's just so hard to not make it look horrible 😅 For the hero section of Base's dedicated marketing page, that will hopefully be clearer due to interactivity but for these images' sake, I've come up with fake components using only those that will be available by the time of release.

Thanks a lot, @danilo-leal!
So the furniture assembly manuals idea you had didn't look good in this case? I was also thinking about something like a blueprint or a technical sketch. On the other hand, having styled components does give readers an idea of what they can build.
Shouldn't the images be 1592px wide? As we're restricting the width to 796px, they should be 2x wide to stay sharp on retina screens.

I was trying to convey the furniture manual idea by having everything outlined, but it didn't look good. For the sake of curiosity, here's how I'm designing this idea to go through on the landing page:

About image dimensions, I was actually following the guidelines on Notion. Even though we force the 796px value, the container max-width is shorter, so it's being rendered with the correct image width.

I've added a "Why MUI Base" section that (hopefully) explains when the library should be used.
As for having more in-depth content - I'd rather point to the docs than explain the concepts here. It will be more future-proof (the documentation is more "live" and frequently updated).

@mui/core Can I please have a green check mark if everything's OK? :)


Update favicons to new logo

This is kind of an extension to #658, but since the deliverable is different, I decided to create a separate issue.
As part of changing our logo in #653, it's important for us to update the favicons we're using across sites to the new logo.
To start, we should update the favicon on https://hackclub.com and https://workshops.hackclub.com. Here's how to do it:

Create an ICO version of the new logo (the version with just the h on the red background) and submit a pull request to add it to the hackclub/meta:logos/ directory. Call the file favicon.ico.
Submit pull requests to update hackclub/website:app/assets/images/favicon.ico and hackclub/lecture-hall:app/assets/images/favicon.ico to the favicon.ico file you created in the previous step.

Let me know if you have questions!

https://github.com/hackclub/website/pull/267 fixes hackclub/website

https://github.com/hackclub/lecture-hall/pull/48 fixes hackclub/lecture-hall

Both favicons you submitted are 7.7MB, which is over 900 times as large as the previous favicons.
Can you update the PRs with much smaller favicons? The current one's 8KB.

Updated, is it better now?

Yup! Merged both.


[Run][Plugin] Rename projects/binaries to follow the required schema

WARNING: this needs to be coordinated with the localization team to avoid problems see  https://github.com/microsoft/PowerToys/pull/9196 and
https://github.com/microsoft/PowerToys/pull/9210
PT Run plugins should follow the same naming convention as the Service and System plugins.
See https://github.com/microsoft/PowerToys/pull/8974 for reference.
This task affects:

Visual Studio projects' names
Binaries' names
folders' hierarchy
projects' namespaces

Given this work impacts several projects, we should open individual PRs for each plugin:

[x] Calculator
[ ] Folder
[ ] Indexer
[ ] Shell
[ ] Uri
[ ] WindowWalker

This looks like a good one for newcomer. I'd like to contribute to it. Can you assign it to me, please?

This looks like a good one for newcomer. I'd like to contribute to it. Can you assign it to me, please?

Hi @dziadkiewicz
thanks for helping, feel free to choose one of the plugin (to start) and simply add a comment saying on which one you are working on.
It's important to open one PR per plugin, so it's easy to review and test each plugin individually.
Thanks.

Hi @dziadkiewicz
thanks for helping, feel free to choose one of the plugin (to start) and simply add a comment saying on which one you are working on.
It's important to open one PR per plugin, so it's easy to review and test each plugin individually.
Thanks.

I'll start with the Calculator.

I'll start with the Calculator.

Are there any devdocs to update?

Are there any devdocs to update?

@enricogior, @crutkas
Regarding the plugin namespace:
For core team plugins we have the namespace Microsoft.PowerToys.Run.Plugin.<PluginName>.
For community plugins @enricogior wrote here that the namespace should be Community.PowerToys.Run.Plugin.<PluginName>.

For me the main question is: When is a plugin a community plugin? (Who is the core team?)
E. g. is the registry plugin a core team or a community plugin.
Imo the namespace Community.PowerToys.Run.Plugin.<PluginName> is a bit strange because PTRun is from MS. I think the namespace Microsoft.PowerToys.Run.CommunityPlugin.<PluginName> makes more sense.

@enricogior, @crutkas
Regarding the plugin namespace:
For core team plugins we have the namespace Microsoft.PowerToys.Run.Plugin.<PluginName>.
For community plugins @enricogior wrote here that the namespace should be Community.PowerToys.Run.Plugin.<PluginName>.

For me the main question is: When is a plugin a community plugin? (Who is the core team?)
E. g. is the registry plugin a core team or a community plugin.
Imo the namespace Community.PowerToys.Run.Plugin.<PluginName> is a bit strange because PTRun is from MS. I think the namespace Microsoft.PowerToys.Run.CommunityPlugin.<PluginName> makes more sense.

@stefansjfw this work was done with the rename, correct?

No, actually this is what's left to be done.

Is this still an issue with the latest version? /needinfo

Is this still an issue with the latest version? /needinfo

Yes. Plugins still don't follow unified schema


Adding UvA-DL notebook "Activation Functions"

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
=> Discussed on Slack channel
[ ] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?

What does this PR do?
This PR adds a new tutorial of the UvA Deep Learning course, this time on Activation Functions. The tutorial is an adapted version of the original tutorial for the Deep Learning course at the University of Amsterdam (link).
No additional files like png or svg images are needed for this notebook.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Just thinking could be nice to set charts side-by-side with Torch activation so the reader is sure that the provided implementation is identical to the provided by PyTorch, what do you think @phlippe?

Just thinking could be nice to set charts side-by-side with Torch activation so the reader is sure that the provided implementation is identical to the provided by PyTorch, what do you think @phlippe?

If we have the different layout of one plot per activation function, then I think it fit nicely. In the current format, I wouldn't know where to put the torch plot.

I wouldn't know where to put the torch plot.

I think we can plot this implementation and Torch version in the same chart just different colour or line style

I wouldn't know where to put the torch plot.

I think we can plot this implementation and Torch version in the same chart just different colour or line style

Would you then have 6 activation functions * 2 plots, one for this implementation and one for the torch, or put the torch and activation function in the same plot? Because since they are identical, you will only see one of the two lines.

Because since they are identical, you will only see one of the two lines.

yes that is the main point to show the reader that the implementation and Torch version is identical


403

Hello I am constantly getting 403 from the back end, any idea why ?
Thank you

Hey @arnaudjuin, could you please provide the steps to reproduce the error you're experiencing?

I followed the instructions by launching both the backend API and the frontend. I opened the frontend in Chrome with security disabled to avoid CORS issues (using the --disable-web-security flag). Despite this, I’m consistently getting a 403 error when trying to access the /current_file endpoint on localhost:5000 from the frontend hosted on localhost:3000.
Hence the screenshot of the network request showing the 403 response.
Have you already had those kind of issues ?
Thanks !

hey @arnaudjuin, can you please provide the output of:
yarn start:api
after having the 403 error

So you started the frontend with yarn start and the backend with another terminal running yarn start:api is that right?
The web UI is on port 3000, the port 5000 is used for communcation between front and back.

Correct.


Create individual player pages

Title + connect to team page for respective players

Done basic version, add more details


Rename examples to recipies

And update readme with links to each recipie.

https://www.dictionary.com/browse/recipies ;)

Lol!
Fixed a few hours ago ;)
https://github.com/damianh/ProxyKit/commit/46a23052f6d1583b219c58d89616db0e7754eaa0

Oh; sneaky ;)


@conda-forge-admin, please restart ci

Issue:

Environment (conda list):

$ conda list

Details about  conda and system ( conda info ):

$ conda info

@conda-forge-admin, please restart ci


Add Traefik 2.x example

🗣 Description
Added docker-compose.yml for foundryvtt-docker and associated Traefik config examples.
💭 Motivation and Context
As a recent adoptee of this docker image I thought it would be useful for future users to have an example of how to integrate it with Traefik.
🧪 Testing

📷 Screenshots (if appropriate)
🚥 Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (causes existing functionality to change)

✅ Checklist

[ ] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Excellent!  Thank you for the contribution.
I'm currently working on a "cookbook" section.  This will fit in perfectly.  Once I get the layout figured out I'll merge this in.
It might take a while for me to get there, so don't worry if this sits for a few days.

No problem, I hope this is useful to someone!
On Sun, Oct 4, 2020 at 8:10 AM Mark Feldhousen<EMAIL_ADDRESS>wrote:

Excellent! Thank you for the contribution.
I'm currently working on a "cookbook" section. This will fit in perfectly.
Once I get the layout figured out I'll merge this in.
It might take a while for me to get there, so don't worry if this sits for
a few days.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/felddy/foundryvtt-docker/pull/77#issuecomment-703269285,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKEI2JNI4F5DAVNRMH5RANLSJCF4TANCNFSM4SDOQIZQ
.

Closing for now.  The cookbook has been delayed.  I've added at label to comeback to this when the cookbook branch gets moving again.


Initialize Velocity Engine per deployment of the mediator

Currently it creates Velocity Engine per request. Create velocity engine per deployment of the mediator.

committed with 7b954badbbbc72d86172143d7734a72a23fe7c52


client keeps saying "CLI is updating"

I'm on linux, have heroku upgraded to the latest version, but everytime I run heroku, the warning CLI is updating appears.
WARNING: CLI is updating
heroku-toolbelt/3.36.4 (x86_64-linux) ruby/1.9.3
WARNING: CLI is updating
heroku-cli/4.19.5-f1ed6e0 (amd64-linux) go1.4.2
WARNING: CLI is updating
=== Installed Plugins
heroku-repo
heroku-vim
papertrail-heroku-plugin

hmm I think something is stuck, try deleting ~/.heroku/heroku-cli

fixed, I see the following files:
autoupdate       heroku-cli.new         node_modules   usage
autoupdate.last  heroku-cli.old         plugins
error.log        iojs-v2.0.0-linux-x64  updating.lock

which ones should also be removed?

oh remove that updating.lock file
On Thu, May 7, 2015 at 11:18 PM, Di Wu<EMAIL_ADDRESS>wrote:

fixed, I see the following files:
autoupdate       heroku-cli.new         node_modules   usage
autoupdate.last  heroku-cli.old         plugins
error.log        iojs-v2.0.0-linux-x64  updating.lock

which ones should also be removed?
Reply to this email directly or view it on GitHub:
https://github.com/heroku/heroku/issues/1552#issuecomment-100115575

Done, thanks, is it possible for you guys to write some cleanup logic into the upgrade process?

yeah it should check to see if the updating file is still valid

I just ran into this as well. All I see is:
$ heroku help
WARNING: CLI is updating

And it hangs. Removing updating.lock allowed it to work.

I recently removed that warning, though it shouldn't have made it hang. I don't think it was actually hanging, I think it was installing iojs.

Oh weird. My download/upload monitor showed nothing happening for many
minutes. I didn't check my activity monitor. As soon as I removed that file
and re-ran the app, I saw it download/uploading, and then it eventually
finished updating...
On Wed, May 13, 2015 at 1:43 PM, Jeff Dickey<EMAIL_ADDRESS>wrote:

I recently removed that warning, though it shouldn't have made it hang. I
don't think it was actually hanging, I think it was installing iojs.
--
Reply to this email directly or view it on GitHub
https://github.com/heroku/heroku/issues/1552#issuecomment-101741219.

odd. Last week the updater ran synchronously, so that might've caused it to block while updating, but now there is a 2-stage updater that will only block for updates if it hasn't updated in over a week. Otherwise it will fork off an update task in the background after running a command. You use it often enough you will probably never see it block for updates. Also, when that updates happens, it tells you what it is doing.
This is all for the v4 updates btw, the v3 ones still update with that updating... updated to v3.xx.x text.
The only thing that downloads/installs in the background in the latest version is the iojs install, which I figured might be a bit verbose information. It should be pretty fast too. If you start seeing this again, could you try running it with HEROKU_DEBUG=true? That will print out information about downloading/installing iojs.
Apologies for the general flakiness around this stuff. When I moved the heroku git commands over to the new v4 stuff we got our first big chunk of people testing it and it helped iron out some of the issues with the autoupdater and setup. I think pretty much everything is solid now.

@Taytay are you in Europe by chance? I'm curious how quickly iojs installs there. You could roughly find out by deleting it: rm -rf ~/.heroku/iojs-v* and running time heroku version.
All of the other parts of the new CLI update via cloudfront, so it should be as fast there as it is here.

I'm actually in South America at the moment, so I'm afraid I can't help. I can in 3 weeks or so though. If any of our European friends stumble across this in the meantime, perhaps they can give that a shot.

South America is just as good! I want to know what it's like outside North America.


dismissWithOutsideClick does not dismiss the modal on iOS Safari

Visit the modal demo http://ef4.github.io/liquid-fire/#/modals
Scroll down to and press the "Try it" button - a modal pops up
Tap the background overlay

Result: Nothing happens, the modal remains in place
Expected: for the modal to be dismissed, as it is in desktop browsers (desktop Safari works fine, as does Chrome and Firefox).
It could be that there is merely some click vs. tap mobile incompatibility, but it would be ideal to have that handled at the framework level as the elements receiving the events are owned by the LF framework.

it seems that the "click" event is not getting fired on .lm-container on iOS Safari.

See perhaps https://developer.mozilla.org/en-US/docs/Web/Events/click#Safari_Mobile

Setting a CSS property of
.lm-container
  cursor: pointer

fixes it


watsonMiddleware.updateContextAsync is not a function

Is version 1.4 not available at the moment? If not how do use something similar? Thanks a lot in advance

I even tried 1.3.1 and it gives me watsonMiddleware.updateContext is not a function

updateContext is currently only available in master branch.
updateContextAsync is promisified version created by Promise.promisifyAll(watsonMiddleware);
@germanattanasio please release a new version.

@Naktibalda Thanks a lot for the reply.
Any idea when will there be a new version?
If it's not happening soon, are there any workarounds at the moment? I just want to update the context and get an alternate response from Watson

I can't answer a question about a new version.
Some workarounds:
a) modify context in after, send context from controller - https://github.com/watson-developer-cloud/botkit-middleware#using-middlewareafter-and-controller
b) require watson-botkit-middleware/lib/middleware/utils.js and use its updateContext method.
c) copy the updateContext function from utils to your bot.

I missed the easiest workaround - using master branch with npm:
"botkit-middleware-watson"<EMAIL_ADDRESS>

Thanks a lot. That fixes things. I am following the example in the README and it's still giving me error. Do you mind helping me out a bit? I am very new to this. Thanks a lot. I am getting this "TypeError: Converting circular structure to JSON"
`function search(context, callback){
context.action = "found";
if(context.entertainment == "movies"){
result_1 = movie_dict[context.movie_genre][0];
console.log(result_1);
context.search_result = movie_dict[context.movie_genre];
}
else if(context.entertainment == "music"){
result_1 = music_dict[context.music_genre][0];
console.log(result_1);
context.search_result = music_dict[context.music_genre];
}
callback(null, context);
}
var searchAsync = Promise.promisify(search);  searchAsync(message.watsonData.context).then(function (context) {
//update context in storage
return watsonMiddleware.updateContext(message.user, context);
}).then(function () {
//send message to watson (it reads updated context from storage)
console.log("before send");
console.log(newMesssage);
return watsonMiddleware.sendToWatson(bot, newMessage);
}).catch(function (error) {
console.log("error")
newMessage.watsonError = error;
}).then(function () {
//send results to user
console.log("after send");
console.log(newMessage);
return processWatsonResponse(bot, newMessage);
});`

The updatecontext function is giving error, I tried calling it like this:
watsonMiddleware.updateContext(message.user, watsonMiddleware.storage, {context: context})

You don't need to wrap context in an object.
try watsonMiddleware.updateContext(message.user, watsonMiddleware.storage, context);
I've seen this circular structure error once and it was happening in debug line at https://github.com/watson-developer-cloud/botkit-middleware/blob/master/lib/middleware/utils.js#L48

@Naktibalda is master ready for a release? if yes will it be patch or minor. I think that after your changes we will have to do a minor release.
Please write some lines in the CHANGELOG.md file and I will do a minor release.
Thanks!

Done #72

🎉 1.4.0 is out.
Thanks @Naktibalda!

Thanks a lot for the help @Naktibalda  @germanattanasio
Close #71

You have to click the button.


Adding codes for Polar Bear

I have added codes for Polar Bear.
However, there are a couple of difficulties:

The air conditioner does not have a temperature for the drying and ventilation modes - therefore, I simply duplicated the codes.
There is no "auto" mode in the ventilation mode - I copied the low there
I forgot that the air conditioner actually works up to 31, but forgot to copy these codes and set the maximum to only 30 >_<

Ooooops.
I tested this and noticed that the unit doesn't always accept temperature codes. (About 3/4 of the time.) The shutdown code works 1/10 of the time. I did tests and noticed that a different shutdown code is written each time. It seems that either I am making a mistake somewhere or this protocol is complex and not easy to copy.


health check matcher for alb ingress

Close https://github.com/cloudposse/terraform-aws-ecs-web-app/issues/191

/test all


Added cnn example and details

I would like to contribute to the ML cheatsheet document. I have added documentation with example for CNN layer

Awesome! This is great. Thanks for contributing!
Looking for fellow maintainers if you're interested!

Dear @bfortuner  - I am pleased to contribute. I am interested in this.  Thanks


Ability to use arrow keys

Immediately I thought this is a nice to have
Problem is that mc (Midnight Commander) arrow keys is not working
Running on Fedora 36
Here with my json config

It's also the case for Midnight Commander on Macos. I will need to read more about encoding key codes to fix this.

Fixed in master. I will release a new version tomorrow.

Fixed in master. I will release a new version tomorrow.

Any updates on this? May I also propose including a configurable config file? Maybe .mprocsrc. User can customize settings, theme, layout, etc. I think it would be a great feature. I would be happy to help.

Released 0.2.3 which includes the fix.

May I also propose including a configurable config file? Maybe .mprocsrc. User can customize settings, theme, layout, etc. I think it would be a great feature. I would be happy to help.

@o-az Yes, I'm planning to add a config file. But currently there are no global settings, so there is nothing to configure. But I want to add an ability to configure the key bindings which would be configurable either via global or local config.


fix: fix tests for node 11

Updating versions and fixing CI issues on node 11

:tada: This PR is included in version 1.5.9 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Youtube Search does not work when cookies are provided

Checklist

[ ] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2020.07.28
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

./youtube-dl-executable -v -- "ytsearch10:broken dreams"
[debug] System config: [u'--cookies=/home/<username>/cookies.txt', u'--force-ipv4']
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'--', u'ytsearch10:broken dreams']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2020.07.28
[debug] Python version 2.7.16 (CPython) - Linux-4.19.0-9-amd64-x86_64-with-debian-10.4
[debug] exe versions: ffmpeg 4.1.6-1, ffprobe 4.1.6-1
[debug] Proxy map: {}
[youtube:search] query "broken dreams": Downloading page 1
ERROR: An extractor error has occurred. (caused by KeyError(1,)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "./youtube-dl-executable/youtube_dl/extractor/common.py", line 530, in extract
    ie_result = self._real_extract(url)
  File "./youtube-dl-executable/youtube_dl/extractor/common.py", line 3005, in _real_extract
    return self._get_n_results(query, n)
  File "./youtube-dl-executable/youtube_dl/extractor/youtube.py", line 3183, in _get_n_results
    html_content = data[1]['body']['content']
KeyError: 1
Traceback (most recent call last):
  File "./youtube-dl-executable/youtube_dl/YoutubeDL.py", line 797, in extract_info
    ie_result = ie.extract(url)
  File "./youtube-dl-executable/youtube_dl/extractor/common.py", line 543, in extract
    raise ExtractorError('An extractor error has occurred.', cause=e)
ExtractorError: An extractor error has occurred. (caused by KeyError(1,)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Description

The Youtube Search currently does not work when there are session cookies for YouTube provided. Without a provided cookies file, the search works correctly. I implemented a proof-of-concept workaround that fixes the issue, but that just removes the cookies from the downloader during search and re-adds them afterwards: https://github.com/peet1993/youtube-dl/commit/56817eda8f90cfdee06170fbf0e59b43a0d3bbc4
The crash happens because with a valid login session, YouTube answers the search query with {"reload":"now"} instead of the search result as expected by youtube-dl. I'm not sure why that happens. However, it is reproducible with curl:
curl -v -b Desktop/cookies.txt 'https://www.youtube.com/results?search_query=test&spf=navigate&disable_polymer=true'
*   Trying 2607:f8b0:4002:c09::be:443...
* Connected to www.youtube.com (2607:f8b0:4002:c09::be) port 443 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
* successfully set certificate verify locations:
*   CAfile: /etc/ssl/certs/ca-certificates.crt
  CApath: none
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* TLSv1.3 (IN), TLS handshake, Server hello (2):
* TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
* TLSv1.3 (IN), TLS handshake, Certificate (11):
* TLSv1.3 (IN), TLS handshake, CERT verify (15):
* TLSv1.3 (IN), TLS handshake, Finished (20):
* TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1):
* TLSv1.3 (OUT), TLS handshake, Finished (20):
* SSL connection using TLSv1.3 / TLS_AES_256_GCM_SHA384
* ALPN, server accepted to use h2
* Server certificate:
*  subject: C=US; ST=California; L=Mountain View; O=Google LLC; CN=*.google.com
*  start date: Jul  7 08:04:38 2020 GMT
*  expire date: Sep 29 08:04:38 2020 GMT
*  subjectAltName: host "www.youtube.com" matched cert's "*.youtube.com"
*  issuer: C=US; O=Google Trust Services; CN=GTS CA 1O1
*  SSL certificate verify ok.
* Using HTTP2, server supports multi-use
* Connection state changed (HTTP/2 confirmed)
* Copying HTTP/2 data in stream buffer to connection buffer after upgrade: len=0
* Using Stream ID: 1 (easy handle 0x55cb713d19f0)
> GET /results?search_query=test&spf=navigate&disable_polymer=true HTTP/2
> Host: www.youtube.com
> user-agent: curl/7.71.1
> accept: */*
> cookie: <other cookies>; SIDCC=AJi4Q<truncrated>Zqi; <other cookies>
>
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
* old SSL session ID is stale, removing
* Connection state changed (MAX_CONCURRENT_STREAMS == 100)!
< HTTP/2 200
< x-frame-options: SAMEORIGIN
< content-type: application/json; charset=UTF-8
< cache-control: no-cache
< expires: Tue, 27 Apr 1971 19:44:06 GMT
< x-content-type-options: nosniff
< accept-ch: DPR
< accept-ch-lifetime: 2592000
< strict-transport-security: max-age=31536000
< content-disposition: attachment
< date: Sun, 02 Aug 2020 16:27:42 GMT
< server: YouTube Frontend Proxy
< x-xss-protection: 0
* Replaced cookie SIDCC="AJi4Q<truncrated>GGSM" for domain youtube.com, path /, expire<PHONE_NUMBER>
< set-cookie: SIDCC=AJi4Q<truncrated>GGSM; expires=Mon, 02-Aug-2021 16:27:42 GMT; path=/; domain=.youtube.com; priority=high
< alt-svc: h3-29=":443"; ma=2592000,h3-27=":443"; ma=2592000,h3-T050=":443"; ma=2592000,h3-Q050=":443"; ma=2592000,h3-Q046=":443"; ma=2592000,h3-Q043=":443"; ma=2592000,quic=":443"; ma=2592000; v="46,43"
<
* Connection #0 to host www.youtube.com left intact
{"reload":"now"}%

The issue was previously reported in #26204, but OP closed it after I added my workaround as reference.

It would be nice to at least have a reference to what this is a duplicate of so I can follow it.


In-editor Profile Viewer

All the complicated stuff was done by @MikeInnes, I just rebased and made some few improvements.
Depends on https://github.com/JunoLab/atom-ink/pull/133 and https://github.com/JunoLab/Juno.jl/pull/60.

Awesome!

Heads up, I rebased this to remove an unrelated change

Originally we just used the generic plot pane for this, which I think makes a lot of sense. Is there a reason to have a profiling-specific pane?

I found a profiler specific pane pretty nice since it doesn't destroy any plots then. In principle we could just update our plot pane to handle multiple plots, but that seems like to much trouble for the first iteration of this...
Not sure what doesn't work for you when clicking the profiler boxes -- is a wrong file opened or none at all?
That zooming took me forever to get right, but that was mostly because I tried to use random code from the internet instead of thinking for myself :D

It just opens a blank untitled-2fb38... file for me.
I partly worry that people will get used to having the new pane and we'll have to stick with it even once we have a better solution. But breaking that might be the lesser evil; it doesn't bother me but I don't do much plotting.

Ah, yeah, that's #350. Do you think that's blocking? I dunno how many people work regularly work with untitled buffers...

Doesn't have to block this pr, would be nice to get it into the release though

Alright, done :)
Re new pane vs PlotPane: I really think a new pane item is better for now, the other option is imho to annyoing if you have a plot open.

@MikeInnes Do you think this is good to go?

Yeah this looks good to me :+1:

*runs Pkg.checkout("atom-julia-client") *

Awesome, thanks for pushing this along

It works! Also great that you can zoom and pan with the mouse, jump into files, etc. This is IMO one of the best inventions after someone came up with toasting day-old bread.
Could there be a possibility of opting out of the top boxes where Atom, CodeTools etc deal process and send the command to julia?

Yeah, that should basically be the same scrubbing we already do for stacktraces.


feature: 项目设置支持

Codecov Report

Merging #843 (57c917e) into project_settings (8e9b7aa) will decrease coverage by 0.05%.
The diff coverage is 55.84%.

@@                 Coverage Diff                  @@
##           project_settings     #843      +/-   ##
====================================================
- Coverage             61.15%   61.10%   -0.06%
====================================================
  Files                   461      461
  Lines                 29292    29326      +34
====================================================
+ Hits                  17914    17919       +5
- Misses                11378    11407      +29

Impacted Files
Coverage Δ

itsm/iadmin/validators.py
37.23% <24.24%> (-3.05%)
:arrow_down:

itsm/project/serializers.py
86.66% <60.00%> (-1.71%)
:arrow_down:

itsm/project/views.py
68.22% <63.63%> (+5.39%)
:arrow_up:

itsm/iadmin/utils.py
46.15% <66.66%> (+3.29%)
:arrow_up:

itsm/iadmin/contants.py
100.00% <100.00%> (ø)

itsm/project/apps.py
92.85% <100.00%> (+11.90%)
:arrow_up:

itsm/project/urls.py
100.00% <100.00%> (ø)

itsm/task/models.py
56.36% <100.00%> (ø)

itsm/ticket/models/ticket.py
55.52% <100.00%> (ø)

itsm/project/models/project.py
75.96% <0.00%> (-11.54%)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e9b7aa...57c917e. Read the comment docs.


Ensure Netlify's deploy preview can build the site for icon pull requests

To be able to preview icons as they will appear on the site

@johnletey Can you maybe check in the netlify dashboard what we doing wrong?


Add error lable when no match found

fix #112
Show/hide label accordingly
Search using 'Enter' on the keyboard
Toggle label on empty input

@Anshuman71
Testing screenshot or video please

Good.


[Feature]: Support JSON Datatype

Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe.
Since 2.2.9, Milvus support JSON Datatype, we need support it in SDK
see https://milvus.io/docs/v2.2.x/release_notes.md#v229
Describe the solution you'd like.
No response
Describe an alternate solution.
No response
Anything else? (Additional Context)
No response

this has been supported while I refactoring this, so close it


Implement Resolve / Arbitration Portal

Fixes #issue_number
Description

Test scenarios

Checklist:

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have cleaned up the code in the areas my change touches
[ ] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have checked my code and corrected any misspellings
[ ] I have removed any unnecessary console messages

First of all, good job! very complete.
There are a couple of details that I would point out. Let me attach some screenshots to illustrate them:

The Elections section somehow got broken. Below I show how it looks broken first and then how it should be looking.

If you want to add a new Section to the header be sure to also add it to the side menu for low-resolution devices.


xt::variance() bug?

Any idea why this compiles without variance but not with it?
// [[Rcpp::depends(xtensorrr)]]
// [[Rcpp::plugins(cpp14)]]

#include <xtensor-r/rarray.hpp>
#include <Rcpp.h>
using namespace Rcpp;

// [[Rcpp::export]]
xt::rarray<double> xtensor_sum(xt::rarray<double> x) {
  std::vector<std::size_t> axes;
  axes.push_back(0);
  return xt::sum(x, axes);
}

// [[Rcpp::export]]
xt::rarray<double> xtensor_variance(xt::rarray<double> x) {
  std::vector<std::size_t> axes;
  axes.push_back(0);
  return xt::variance(x, axes);
}

In file included from test.cpp:4:
In file included from /Library/Frameworks/R.framework/Versions/3.5/Resources/library/xtensorrr/include/xtensor-r/rarray.hpp:17:
In file included from /Library/Frameworks/R.framework/Versions/3.5/Resources/library/xtensorrr/include/xtensor/xbuffer_adaptor.hpp:20:
In file included from /Library/Frameworks/R.framework/Versions/3.5/Resources/library/xtensorrr/include/xtensor/xstorage.hpp:21:
In file included from /Library/Frameworks/R.framework/Versions/3.5/Resources/library/xtensorrr/include/xtensor/xtensor_simd.hpp:14:
/Library/Frameworks/R.framework/Versions/3.5/Resources/library/xtensorrr/include/xtensor/xutils.hpp:1183:31: error: implicit instantiation of undefined template 'xt::rebind_container<long, xt::xbuffer_adaptor<int *, xt::no_ownership, std::__1::allocator<int> > >'
        using type = typename rebind_container<std::ptrdiff_t, S>::type;
                              ^
/Library/Frameworks/R.framework/Versions/3.5/Resources/library/xtensorrr/include/xtensor/xutils.hpp:1196:5: note: in instantiation of template class 'xt::get_strides_type<xt::xbuffer_adaptor<int *, xt::no_ownership, std::__1::allocator<int> > >' requested here
    using get_strides_t = typename get_strides_type<C>::type;
    ^
/Library/Frameworks/R.framework/Versions/3.5/Resources/library/xtensorrr/include/xtensor/xstrided_view.hpp:631:9: note: in instantiation of template type alias 'get_strides_t' requested here
        get_strides_t<shape_type> strides;
        ^
/Library/Frameworks/R.framework/Versions/3.5/Resources/library/xtensorrr/include/xtensor/xmath.hpp:1919:24: note: in instantiation of function template specialization 'xt::reshape_view<xt::xfunction<xt::detail::divides, xt::xreducer<xt::xreducer_functors<std::__1::plus<double>, xtl::identity, std::__1::plus<double> >, const xt::rarray<double> &, std::__1::vector<unsigned long, std::__1::allocator<unsigned long> > >, xt::xscalar<double> >, xt::xbuffer_adaptor<int *, xt::no_ownership, std::__1::allocator<int> > >' requested here
        auto mrv = xt::reshape_view(std::move(inner_mean), std::move(keep_dim_shape));
                       ^
test.cpp:20:14: note: in instantiation of function template specialization 'xt::variance<xt::rarray<double> &, std::__1::vector<unsigned long, std::__1::allocator<unsigned long> > &, xt::evaluation_strategy::lazy, xt::concept_check_successful>' requested here
  return xt::variance(x, axes);
             ^
/Library/Frameworks/R.framework/Versions/3.5/Resources/library/xtensorrr/include/xtensor/xutils.hpp:80:12: note: template is declared here
    struct rebind_container;
           ^
1 error generated.
make: *** [test.o] Error 1

Looks like a bug in either xtensor-r or xtensor.
I think the shape type of an rarray should be svector and the shape type of an rtensor should be std::array. Only the inner shape type should be a buffer adaptor.

Indeed the issue is that

xcontainer.shape() returns the inner shape type, which is an adaptor in the case of rarray
variance uses reshape_view with a shape returned by shape(), on which get_strides_type in instantiated.

The solution instead of changing any internal shape type might be to drop the use of get_strides_type in xtensor...

Small bump to have this fixed if you get the time. I was planning on doing an example that required stddev() to work.


Decide what to do with Smart TV Browser apps (Testing, Support)

Summary
We are seeing more and more issues pop up with Smart TV apps.  Smart TV will also only grow from here.  We have no testing , focus, or plan in place for any Smart TV environment.  This ticket could serve to get a discussion going about how we want to approach Smart TV apps moving forward
Possible Solution
Some options:

[ ] Introduce tests for Smart TV environments
[ ] Plan around smart TV environments (TV apps are almost entirely streaming focused, is there implementations we could make to better support streaming?)
[ ] Decide what Smart TV environments (if any) we support
[ ] Have platform specific tool for TV (built more around video?)
[ ] Do nothing

Additional context
Smart TV app development will only grow as more people have Smart TVs than ever before, and many companies are embracing a streaming video approach from home over other mediums.  We should at least consider our options for staying relevant with these apps and try to mitigate issues if we can.

In the past we have attempted to abort the agent by:

Setting a timeout after requesting the second half of the agent
Adding an event listener to the JSONP call to identify failed network requests

We could instrument these methods with a supportability metric to track how often the agent fails to load.
In the case where we aren't able to successfully abort the agent, we may need to identify other strategies for aborting the agent. It's also possible our current detection approaches are working, but we're not correctly aborting the agent and there are still memory leaks to be found.

@metal-messiah @aubreymasten We have a lot of trackers for streaming video built by @asllop that our Media customers are using in production for web environments - Smart TVs and Game Consoles included. It can be an adventure with those customers to get the browser agent working correctly in those environments, but I can confirm there is a huge use case here and more official support for Smart TV and Console environments could help us drive a lot of usage.

Hi @metal-messiah ! NR's main video telemetry engineer here. I have successfully integrated the browser agent in Chromecast, but haven't tested any other JS-based SmartTV. Actually, I have been told that some Smart TVs (especially old ones) can't run the browser agent, and this let me modify the video agent core to accept custom event loggers besides the NR browser agent. Regarding the subset of SmartTVs that should be supported, have a look at this market share investigation I made a few months ago: The main ones worldwide are Samsung (Tizen) and Smart Alliance based systems. If you feel that need my collaboration just give me a shout.
cc @cjmccarthy


Don't overwrite existing debian dir

Running make-deb when a debian sub-folder is present blows away that folder. This should at least prompt before doing so.

Good idea :). Hopefully everyone is on version control, but for the one time someone isn't...
I've committed a fix: https://github.com/nylas/make-deb/commit/130610d1a187af76892cfa7a628974717d6f9645
You can expect this to be released in 0.0.5
Thanks for the help!


Weekly build triage for the week starting Saturday 2023/09/09

This week's build triage summary:

Date
Day
JDK Version
Pipeline
Pass/Build Fail/Test Fail
Pass/Preventable/Unpreventable

2023/09/09
Saturday
JDK8
Link
10/1/0
6/7/8910

2023/09/09
Saturday
JDK11
Link
10/1/0
6/7/8910

2023/09/10
Sunday
JDK17
Link
9/1/1
6/7/8910

None
N/A
JDK21
N/A
N/A
N/A

2023/09/08
Friday
JDK22
Link
5/5/1
6/7/8910

Note: "Test Fail" is for when all the "build" jobs passed (build, sign, installer, etc) but one of the test jobs failed and the
status propagated upstream to the build job. Note that "unstable" test job status can be considered a pass, as these are
triaged in more detail here.
Comment template:
Triage breakdown for <Weekday>
List of failures:
<link to failing job>
<Problem summary>
New/Existing Issue: <Issue link>
Preventable: Yes/No
Repeat as needed.

Triage breakdown for Weekend and prior Friday
List of failures:
https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk/job/jdk-linux-ppc64le-temurin/219/console
https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk17u/job/jdk17u-linux-ppc64le-temurin/274/
https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-linux-ppc64le-temurin/357/
https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-linux-ppc64le-temurin/261/
PPCLE Image flaw
Existing Issue: https://github.com/adoptium/infrastructure/issues/3183
Preventable: Yes
https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk/job/jdk-linux-s390x-temurin/225/console
https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk/job/jdk-linux-arm-temurin/236/console
Sigsegv during build of jigsaw tools
Existing Issue: https://bugs.openjdk.org/browse/JDK-8314510
Preventable: No
https://ci.adoptium.net/job/Test_openjdk17_hs_extended.openjdk_aarch64_mac_testList_1/99/console
Exception: org.jenkinsci.plugins.workflow.support.steps.AgentOfflineException: Unable to create live FilePath for test-macstadium-macos11-arm64-1; test-macstadium-macos11-arm64-1 was marked offline: Connection was broken

New Issue: Network issue. Ignored. Machine: test-macstadium-macos11-arm64-1
Preventable: No
https://ci.adoptium.net/job/Test_openjdk22_hs_sanity.perf_x86-64_mac/9/console
Failed to connect to github.com port 443: Operation timed out
New Issue: Network issue. Ignored. Machine: test-macstadium-macos1014-x64-1
Preventable: No
Extra note: I'm sure I've seen macstadium several times now. An issue will be raised if this is a trend.

New/Existing Issue:
Preventable: Yes/No

New/Existing Issue:
Preventable: Yes/No


Overwritten values

When a key is already present in a measurement and is overwritten by aemeasure, it would be great to get some warning. I had the issue when measuring my own runtime in microseconds and saving with the key 'runtime' key.

The new library AlgBench does separate these things better (and is probably better in general). Don't know if I will invest time to fix this library.


PATCH: removing duplicate key (SilverStripe\Forms\Form->callfieldmeth…

we are removing duplicates key from yml as this causes errors in symphony

Merged in manually with https://github.com/silverstripe/silverstripe-framework/commit/8f03c7df050979c8ec65efb8d6a328fbd427c68f


Property:storageFootprintConfidence

Definition
The percentage confidence in the estimate of the storage footprint

Existing property

Existing class

Existing property identifier

Format
Percentage

Required
no

Repeatable
no

Constraints

Examples
5%

Notes

Definition: Confidence level on the estimation of the floor area

Deprecated in favour of MeasurementOrFact class


Parse ary and new_ary types in call-seq

Description
Lastest Ruby's array.c contains ary and new_ary return types which is not handled by yard for now. So @return for Array#map is missing from generated yard doc. This PR fixes it..!
Completed Tasks

[x] I have read the Contributing Guide.
[x] The pull request is complete (implemented / written).
[x] Git commits have been cleaned up (squash WIP / revert commits).
[x] I wrote tests and ran bundle exec rake locally (if code is attached to PR).

Coverage increased (+0.03%) to 93.496% when pulling f5a500deeca5067503e7b785ae4386450e504f38 on ypresto:new_ary into 3374f8cdb96fd7033eaee09f71f13c08c47693e2 on lsegal:master.

This seems to fail tests on the &. syntax, which we can't use.

Oh, I'll rewrite it with try() instead!

fixed!

Coverage increased (+0.04%) to 93.508% when pulling a4af5e175f759fa5998c458888b7cf7c90140d09 on ypresto:new_ary into 3374f8cdb96fd7033eaee09f71f13c08c47693e2 on lsegal:master.

Coverage increased (+0.04%) to 93.508% when pulling a4af5e175f759fa5998c458888b7cf7c90140d09 on ypresto:new_ary into 3374f8cdb96fd7033eaee09f71f13c08c47693e2 on lsegal:master.

Thanks for the PR!


Feat: Added Waiter addon

@pascalwilbrink is there any reason you use override in your render method in packages/open-scd/src/addons/Waiter.ts ?? It seems to be causing a building error

@pascalwilbrink is there any reason you use override in your render method in packages/open-scd/src/addons/Waiter.ts ?? It seems to be causing a building error

Not really, it failed because it's added in TS 3.4 (i think) and building uses an older version. Removed it


Exported C# variable not showing up in inspector

Tested versions

Reproducible in: v4.2.1.stable.mono.official [b09f793f5]

System information
Godot v4.2.1.stable.mono - Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2070 with Max-Q Design (NVIDIA; <IP_ADDRESS>33) - Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz (12 Threads)
Issue description
Exported variable in C# script not showing up in inspector
Steps to reproduce

Use the Export identifier for a variable in a C# script.
Build script successfully.
Check script attached to node in the inspector.
Notice the missing entry for the variable.

Minimal reproduction project (MRP)
using Godot;
using System;

public partial class OpenSceneOnPress : Button
{
    [Export]
    private string ScenePath;

    public override void _Pressed()
    {
        GetTree().ChangeSceneToFile(ScenePath);
    }
}

Have you also recompiled the project?
Because only then will the parameters be displayed in the inspector. It would be strange for me if that were a bug. Because I have almost the same system and also use Godot with .NET.

Yeah this is likely what @DevMimas mentions. Make sure to compile the project, then (re)select the node, and the new variable should be there.

@DevMimas
Yes, I've tried:

Build project
Rebuild project
Clean project -> build project.

I've tried this both in Godot and within Visual Studio. The problem still persists regardless.

Can you attach a reproduction project as a zip?

Export Bug Reproduction.zip

I can't reproduce the issue on Linux with 4.2.1.stable.mono, it shows the entry properly. This is the reproduction project right after opening it:

I'm seeing the field now. I was expecting the exported variable to show up under the script field rather than a separate section of the inspector.


find-up

Usually find-up-simple would be sufficient. And in many cases I've just written the code myself instead

havent' benched the simple variant, but escalade was significantly faster and smaller

walk-up-path is often enough too (a pretty old and battle tested package)
I would list that and escalade at least since they're not providing exactly the same functionality


Terra docs Components

Summary
Adding and relocating components for documentation and examples. This pr includes

a simple button
a 'notice' component
a placeholder component

Placeholder has been migrated from the terra-doc-template repo.
Button has been adapted from terra buttons neutral style (should the styling be more obvious that it's a 'placeholder' button?)
Notice for drawing attention to information on a doc page.

Closes #
Deployment Link

https://terra-core-deployed-pr-#.herokuapp.com/
Testing

Jest, WDIO
Additional Details

I've moved the doc for the components under tools instead of components since these are not intended for production use.

Thank you for contributing to Terra.
@cerner/terra

After this gets released we can embark on replacing placeholder from terra-doc-template with placeholder from terra-docs and finally deprecate that component

Should we support adding a link to notice components? it might be nice to be able to provide a link to the component that replaces it.. I'm not sure how to style that though since the component it self doesn't take markdown

I'll update once I get styles for the new variants.

UX +1


Add pukima.site

I have no idea where to ask for a missing instance but https://pukima.site (my own instance) is one of them and prettynew. Would love if you could add this to InstanceTicker. Great work btw!

I have no idea where to ask for a missing instance but https://pukima.site (my own instance) is one of them and prettynew.

ok!
add now!
https://miyon.miyon.org/@InstanceTicker/107715416271733806
attention to your browser’s cache.

Would love if you could add this to InstanceTicker. Great work btw!
very very thanks!


fix(packge.json): update to latest epsagon

:tada: This PR is included in version 1.17.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Arduino Freeze

Do you have any serial monitor output?
Alex Albino
Sr. Fullstack Developer
Zend Certified Engineer
https://github.com/zrecommerce
https://github.com/femtoduino
https://github.com/femtoio
(707) 246-6864
On Jul 22, 2015 10:01 AM, "mitko9000"<EMAIL_ADDRESS>wrote:

After I connect arduino zero + nrf8001 with any application it seems that
the test sketch freeze after receiving the Evt Pipe Status.
Any sugestion how to handle this ?
—
Reply to this email directly or view it on GitHub
https://github.com/sandeepmistry/arduino-BLEPeripheral/issues/23.

Well what I did is to change nrf8001.cpp file inside case ACI_EVT_PIPE_STATUS
and commented everything now read and write is working.

Also bonding for HID mouse is not working at all cant bond with device

@mitko9000 I've addressed this with 051765c ... it didn't like dereferencing an unaligned uint64_t pointer, so I switched to using memcpy.


Add a runtime check for the absence of window object

Had issues with server-side rendering (was crashing with "window is not defined"). Added check for the window object

@ivan-badmaev Thanks!

@ivan-badmaev I released it. You can update your dependencies from NPM.


Add Server Support for ReplacementProductList

📖 Description
The SDK needs to add support for setting and reading the ReplacementProductList attribute added in https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7224

The XML alignment issue seems to be https://github.com/project-chip/connectedhomeip/issues/27571


Update com.google.fonts/check/usweightclass

Check will now treat otfs, ttfs and variable fonts usWeightClass values differently.
For variable fonts we want Thin-Black to have 100-900
For static ttfs we will accept 250-900 but we prefer 100-900
For static otfs we want 250-900.
@tphinney I hope this is correct. I remember you saying in the last meeting that otfs with values less than <250 may cause some blurring on some Windows applications.
fixes #2788

I merged this because I know it is important to the team and the code seems correct. But I dislike that you did not thoroughly test all code-paths and removed usage of unique Message keywords for precise code-testing. Please try to adhere to these code-testing practices on your next PRs.

It would also be good if you could please send a followup PR with better code-testing for this check


Fix Windows NFS script when username has spaces, fixes #1452

The Problem/Issue/Bug:
OP #1452 reports that the Windows NFS installation script fails when there are spaces in the user's names.
How this PR Solves The Problem:
Use $HOME instead of ~, and put path in quotes.
Manual Testing Instructions:
Automated Testing Overview:

Related Issue Link(s):
Release/Deployment notes:

Per #1452 this needs to be tested on git-bash; look at the results there as well.

Please test https://github.com/drud/ddev/blob/e0fdc174813b2c5e0ef5aa8267ef6a9a022ce547/scripts/windows_ddev_nfs_setup.sh raw


How to convert seed to Mnemonic?

Hi,
is there any function / method to convert seed to Mnemonic?
Regards,
Ian

Hi Ian,
there is no way convert a seed into a mnemonic.
Best Christian

Hello Christian
I wanna get account id and secret seed from mnemonic
Is it possible?
I have created a wallet and I need to load user's data with these phrases
Thanks

Hi @AliKarimiENT
sure, look at this sdk example:
https://github.com/Soneso/stellar_flutter_sdk/blob/master/documentation/sdk_examples/sep-0005-key-derivation.md#generate-key-pairs-from-mnemonic
hope this helps!


Request: Add desktop version

I would like a desktop version of this counter because, whenever if you want to drag a player to a list, the among us windows minimizes and its really annoying. If there is a desktop version I will also like a stay on top function.

Duplicate of #28


fix: Remove duplicate committee element

Summary

There's two "apply to committee elements." I chose to keep the one on top for better visibility.
Page Preview

Test Plan
Hopefully it looks good
Issues
Closes #
Misc
Sorry for the big diff, I've got prettier 😭

Good catch! LGTM


Python calcCovarMatrix Documentation Wrong?

In the Operations on Arrays section of the OpenCV 3.0.0-dev documentation, the definition for Python calcCovarMatrix is:
Python: cv2.calcCovarMatrix(samples, flags[, covar[, mean[, ctype]]]) → covar, mean
However, for whatever reason, the definition that is actually present when calling help(cv2) is:
Python: cv2.calcCovarMatrix(samples, mean, flags[, covar[, ctype]]) → covar, mean
mean becomes a required argument, but this behaviour is not explained in any documentation.
OpenCV 3.0.0 is built running on Ubuntu.

OpenCV 3.0.0 and mentioned documentation are outdated and not supported anymore.


PSI Library: Implement Mean (Statistic) (Rust)

OpenAPI Definition

[ ] Write definition
[ ] Write comments/docs

Rust Runtime

[ ] Write runtime
[ ] Implement tests
[ ] Write comments/docs

Rust Validator

[ ] Write validator
[ ] Implement tests
[ ] Write comments/docs

Python bindings

[ ] Create bindings
[ ] Implement tests
[ ] Write docs

R bindings

[ ] Create bindings
[ ] Implement tests
[ ] Write docs

first attempt in commit 1d0877fd6e0a13e85784180d6e821ee56ef7be33

needs rewriting


VSIX package generated by 'vsce package' failing to install

This occurs in Insiders as well.

VSCode Version: 1.49.3
OS Version: MacOS 10.15.6

Steps to Reproduce:

At command-line run yo code like the extensions documentation states, name package my-extension, configure to use npm (not yarn), basic hello world extension gets created.
add a publisher property to package.json
At command-line run vsce package
At command-line run code ./my-extension.vsix to install the extension. See message: "The file is not displayed in the editor because it is either binary or uses and unsupported text encoding.  Do you want to open it anyway?"

Does this issue occur when all extensions are disabled?: Not applicable, this is an extension specific issue.

In step 4 you are telling VS Code to open the file.
There may be a CLI switch to install an extension, but I don't recall.
Another way is to open VS Code, switch to Extension activity, then drag the VSIX from Finder onto the drop target on the left.

There is a cli flag to install an extension https://code.visualstudio.com/docs/editor/command-line#_working-with-extensions
code --install-extension <ext>

Also, there is an extension that adds context menu for explorer: https://marketplace.visualstudio.com/items?itemName=fabiospampinato.vscode-install-vsix

Argh... I was looking at the wrong docs site, It doesn't show that flag here: https://vscode-docs.readthedocs.io/en/stable/extensions/install-extension/
It does show the flag on the actual docs site here: https://code.visualstudio.com/docs/editor/extension-gallery#_install-from-a-vsix
Thanks!


Fluid Splitter

Currently, Essentials has an Item Shifter, Fluid Shifter, Basic Item Splitter, and Redstone Item Splitter, but no block for splitting fluids between two outputs.
TODO:
Add a basic fluid splitter
Add a redstone fluid splitter

This has been implemented in the beta version.


Add Spring Boot support for predicate

There should be possibility to, on top of a predicate bean definition, it would be nice to be able to configure simpler cases of "ignore the endpoints", something like this:
logbook:
...
ignore:
- /health
- /info

What would be your exception in regards to query parameters? If you list /health as ignored, would you assume the following URL to be ignored or not? /health?check

Other question, let's say we look for a bean of a specific type or name to use a predicate. If the config in addition contains the ignore section, would you expect to combine them?

@whiskeysierra
I think it would be enough if we could use ant-style patterns (i.e. AntPathRequestMatcher), like Spring Security.
I would expect that the final configuration would be a combination of both.

I think it would be enough if we could use ant-style patterns

That's a great idea!


about local search

I found that local search can not be used...
like this.

It works for me.
Maybe try to verify these things:

Are there any errors in the Javascript console?
Is the search.xml file generated?
Does it work on https://probberechts.github.io/cactus-dark/search/?
Try to disable all your browser plugins


System Monitor Sensor Freeze

Describe the bug
Creating a system monitor widget on a panel with the type application causes the plasma to freeze. Rebooting doesn't help either. On boot, the entire workspace completely freezes. The only way to fix this is to switch to another user and manually edit ~/.config/plasma-org.kde.plasma.desktop-appletsrc to remove the widget.
This does not occur on Solus Linux with 6.1.5 of plasma.
I've also reproduced this on a fresh nixos install with a minimal config
services.xserver.enable = true;
services.displayManager.sddm.enable = true;
services.desktopManager.plasma6.enable = true;
services.displayManager.defaultSession = "plasma";
services.displayManager.sddm.wayland.enable = true;

Steps To Reproduce

Add a system monitor widget to your panel
Configure the widget and change the display style to "Applications grid"
Observe complete system freeze

Expected behavior
No lockup
Notify maintainers
@K900
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.10.14, NixOS, 24.05 (Uakari), 24.05.20241014.c0b1da3`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.8`
 - nixpkgs: `/nix/store/wdk3xa0vwx7swjdl1samf1bccvyyzfc1-source`

Add a :+1: reaction to issues you find important.

Again, have you tested this on unstable?

Okay huge improvement on unstable. No issues there. Sorry about the false reports.


Want to remove views

Hello,
I want to remove views form this project I only need restful API.
So I removed
// app.set("views", path.join(__dirname, "../views")); // app.set("view engine", "pug");
But it will show me an error like
500 Error: No default engine was specified and no extension was provided.

@ckukadiya Hi, that is not an error from the project, I guess you're calling the index enpoint this implement the render method from express, such method is using the template engine so you should change for res.rend({msg: "something"}); you can find more information here

@ckukadiya
Please close this issue. It's not the issue of this repository. Thanks
You can check same question at this link https://stackoverflow.com/questions/25267100/how-do-i-disable-jade-template-engine-in-express-4


Make a check if model has also some code inside

there should be at least one non-empty python file (or some other ML language for training) inside repository, reject those without

#30 30


Render error

Simple code, but got error.

Plugin worked some time and then any code not rendered anymore (((
Uninstall, install, reload Logseq - nothing help ((

Hi @yoyurec  What's the version of the Desktop app?

0.7.0, Windows

same error on Mac OS, Version 0.7.1 (0.7.1)

Does work for me on version 0.8.4 of the desktop app.
@yoyurec Do you still this issue on your side?

works good now!


Overriding str pretty-printing (for both pprint and cpprint in Jupyter)

PrettyPrinter version: 0.14.0
Python version: 3.7.0
Operating System: macOS 10.13.6

Description
I want to insert hyper_markdownify(s) into your code, and plan to make text-to-speech (TTS) on click in Jupyter Notebook.
What I Did
In this repo: https://github.com/patarapolw/pyrepr
import json
from markdownify import markdownify

def hyper_markdownify(s):
    while True:
        try:
            s = json.loads(s)
        except (json.decoder.JSONDecodeError, TypeError):
            break

    return markdownify(s)

Most importantly, how do I extract the formatted HTML? I am able to extract the string using
pprint(obj, StringIO())

But I cannot do the same with cpprint.

I'm not a 100% sure what you're asking, but prettyprinter is meant for pretty output of Python data, generally for humans to read—HTML markup and Markdown data that you seem to be working with are data embedded in strings, which prettyprinter does not pretty print other than as generic strings. Feel free to reopen if you provide more context as to what you are trying to achieve.


DecayingEstimatedHistogramReservoir.EstimatedHistogramReservoirSnapshot returns wrong value for size() and incorrectly calculates count

Committed as https://github.com/apache/cassandra/commit/8d443805f06e7abb25f768f6c800b7ae71bd4a41


Version2 development preprocessor nomenclature 847

This PR addresses #847 (partially).
In this patch we:

rename _area_pp.py  to _area.py
rename _volume_pp.py  to _volume.py
rename _time_area.py  to _time.py

It also renames some preprocessors that were previously imported under a different name. This should ensure that the recipes match the API.
As a bonus, I've added some basic documentation for these three preprocessor modules.

Cheers @valeriupredoi. It wasn't so bad, just a few find replace commands and a fairly heavy reliance on grep -ir. I feel some responsibility too as I wrote several of these preprocessors in the first place.

I've replaced several instances of the term depth in the documentation where appropriate.
Although this goes beyond the scope of this PR, your comment uncovered one thing I don't fully understand here. That's how this part of the function extract_volume works:
    subz = iris.Constraint(
        depth=lambda cell: float(zmin) <= cell <= float(zmax))

I don't get how iris knows to apply this to the depth dimension. depth is only used to name the lambda function, and python doesn't really care about object names. How does iris know to use this on the depth?
The other problem here is if iris is doing something clever using the name of the lambda function, then this can only apply to the ocean. We'd need to write a second constraint for the atmosphere. @valeriupredoi , can you help me make this work for other z direction fields (like air pressure, or whatever they use in the atmosphere)? I've changed it to:
    cube_dims = [c.standard_name for c in cube.coords()]
    if 'depth' in cube_dims:
        z_constraint = iris.Constraint(
            depth=lambda cell: float(zmin) <= cell <= float(zmax))

Once again, this is beyond the scope of this PR, but seems like as good a place as any to do this.

I've replaced several instances of the term depth in the documentation where appropriate.
Although this goes beyond the scope of this PR, your comment uncovered one thing I don't fully understand here. That's how this part of the function extract_volume works:
    subz = iris.Constraint(
        depth=lambda cell: float(zmin) <= cell <= float(zmax))

I don't get how iris knows to apply this to the depth dimension. depth is only used to name the lambda function, and python doesn't really care about object names. How does iris know to use this on the depth?

the iris.Constraint function uses the lambda function argument and matches it to the coordinate name that needs to apply the constraint on, see: https://scitools.org.uk/iris/docs/latest/iris/iris.html#iris.Constraint

The other problem here is if iris is doing something clever using the name of the lambda function, then this can only apply to the ocean. We'd need to write a second constraint for the atmosphere. @valeriupredoi , can you help me make this work for other z direction fields (like air pressure, or whatever they use in the atmosphere)? I've changed it to:
    cube_dims = [c.standard_name for c in cube.coords()]
    if 'depth' in cube_dims:
        z_constraint = iris.Constraint(
            depth=lambda cell: float(zmin) <= cell <= float(zmax))

Once again, this is beyond the scope of this PR, but seems like as good a place as any to do this.

very good point! I failed at noticing the ocean use only. It's easy to make it applicable to other z-coords by making the caller (lambda) func argument generic ie zcoords = list_of_all_possible_zcoords and then giving a specific constraint for each of those like in the example page above:
iris.Constraint(name='air_potential_temperature',
           cube_func=lambda cube: cube.units == 'kelvin',
           coord_values={'latitude':lambda cell: 0 < cell < 90},
           model_level_number=[10, 12])
           & Constraint(ensemble_member=2)

but let's do that in a new PR, shall we? :taxi:

Sure, I'll make and issue. This one is probably ready to go then!

So, we're good to go here?

@bouweandela and @mattiarighi you guys green light this?

mergy-merge?

Any comments from @bouweandela before we merge?

Can we merge this please?

just one second, I will merge it as soon as we fix an accidental push to version2_development that happened yesterday; I'd keep all the mergers on standby until that gets fixed first @mattiarighi @bjoernbroetz have you guys fixed it yet? Ill have a look now....


fix(loki): fix the deadlock in Loki integration

I believe this should be the fix for https://github.com/falcosecurity/falcosidekick/issues/646, but I'm still figuring out a way to test it locally.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

f1631bd fix(loki): fix the deadlock in Loki integration

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

There is not a label identifying the kind of this PR.
Please specify it either using /kind <group> or manually from the side menu.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: bsod90
Once this PR has been reviewed and has the lgtm label, please assign cpanato for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Welcome @bsod90! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bsod90, Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: cc3d9117460b639b38ae42541b004e150ee09662

can you sign-off your commit please

Thank you so much, @Issif !
Just added the sign-off
Also, didn't know about anonymous functions, Go isn't my first language :) Thanks!

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bsod90, Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

A quick follow-up question: when do you expect the next minor release to be cut? I'm asking because I'm trying to use Loki integration in our infra and it would be easier to just use the official image instead of forking, custom-building, etc.
Thanks! @Issif

@bsod90 I created an RC for you https://github.com/falcosecurity/falcosidekick/releases/tag/2.29.0-rc.3

Thank you!
On Thu, Sep 28, 2023 at 5:46 AM Thomas Labarussias @.***>
wrote:

@bsod90 https://github.com/bsod90 I created an RC for you
https://github.com/falcosecurity/falcosidekick/releases/tag/2.29.0-rc.3
—
Reply to this email directly, view it on GitHub
https://github.com/falcosecurity/falcosidekick/pull/647#issuecomment-1739095127,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AARPWEY26GU45NAEBK6QAMLX4VWSBANCNFSM6AAAAAA5GUH3RM
.
You are receiving this because you were mentioned.Message ID:
@.***>


Use routing table to determine container IP address

Using hostname -i relies on DNS, which doesn't seem to work reliably on all configurations:
routing-api/0:/# hostname -i
hostname: Name or service not known

This commit has been cherry-picked into #305 to aid in its testing on Jenkins


build against and require lru >= 0.3.0

As noted in #27 .

in https://github.com/mirage/mirage-nat/pull/28/files#diff-d05a517e7f6f4ce63b05a5790a81788bR79 you likely want to call LRU.trim to get rid of potentially too much data in the store...

One last nit -- one which concerns tcpip too: why is everybody using the functional structure just to stick it in a reference cell (and then wrap in lwt)?
Doing that just replicates what the mutable thing does. And as it says on the tin, using Lru.M is more efficient when applicable.
If the idea was to avoid collision-based complexity attacks, there's a seeded variant ofLru.M.

An alternative in #29.

@pqwy

One last nit -- one which concerns tcpip too: why is everybody using the functional structure just to stick it in a reference cell (and then wrap in lwt)?

I find functional APIs nicer. The Fragments module in the TCP/IP stack does not keep nor modify state :)
This is pretty nice for testing, although of course this can be done with a mutable LRU as well.

I mean to be sure, a functional representation of anything is a winner in my book, as long as you understand the price.
I must have confused tcpip with this. I thought I remembered a ref being involved there too.

Having merged #29 I'll close this.


5864 fixed thread pool limit insufficiency on do _execute_convergence

Resolves #5864

If this PR and #2 solve the issue of running out of memory when running builds in parallel, would it be possible to open them in https://github.com/docker/compose?


Adding "Played yesterday" to Training DataFrame.

Add a column to dataframe indicating whether a team played yesterday (1) or not (0).
This should add a "fatigue factor" to the model.

'Helper' has no attribute 'build_stats_per_game_csv'


fix: double modules hazard by preferring relative paths

close #631

Everything's passing, congrats!


Fix problem with parsing server url.

When passed urlString starts with ‘nats’ (like ‘nats.domain.com’ or 'natsserver.company.com') the protocol supplement will be skipped and connection will fail.

LGTM.  Thank you for the contribution!


fix(network): fix network error handling in main

Pull Request type
Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Does this introduce a breaking change?

[ ] Yes
[ ] No

Other information

This change is

Current dependencies on/for this PR:

#1742  👈
main

This stack of pull requests is managed by Graphite.


PBCore 2.1 updates

		<essenceTrackIdentifier source="ID (Mediainfo)">1</essenceTrackIdentifier>
		<essenceTrackIdentifier source="UniqueID (Mediainfo)">1</essenceTrackIdentifier>
		<essenceTrackIdentifier source="StreamKindID (Mediainfo)">0</essenceTrackIdentifier>
		<essenceTrackIdentifier source="StreamOrder (Mediainfo)">0</essenceTrackIdentifier>

I don't like the idea to have " (MediaInfo)", ID and UniqueID are not "created" by MediaInfo, they are from the file. "ID" and "UniqueID" without " (MediaInfo)"  would be better IMO. for StreamKindID and StreamOrder it is guessed from the file, but less obvious.
PS: "MediaInfo", not "Mediainfo" ;-).

<instantiationDataRate unitsOfMeasure="bits/second">468348</instantiationDataRate>

https://en.wikipedia.org/wiki/Data-rate_units indicates that unitsOfMeasure should be "bit/s"
<instantiationFileSize unitsOfMeasure="bytes">58602</instantiationFileSize>

I think that unitsOfMeasure is singular (e.g. from https://en.wikipedia.org/wiki/Bit_rate it is said "1 kbit/s = 1,000 bit/s", not "bits/s"), and for an attribute it is even more obvious IMO --> "byte" without "s".


Autocomplete only works when ran as root

Issue Report Checklist

[x] Searched the issues page for similar reports
[x] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[x] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[x] Could not reproduce inside jupyter qtconsole (if console-related)
[x] Tried basic troubleshooting (if a bug/error)

[x] Restarted Spyder
[x] Reset preferences with spyder --reset
[x] Reinstalled the latest version of Anaconda
[x] Tried the other applicable steps from the Troubleshooting Guide

[x] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
Autocomplete in the IDE only works when ran as root. The console works fine.
What steps reproduce the problem?

Open spyder as a non-root user
Type "imp" and press tab
"imp" isn't autocompleted to import

What is the expected output? What do you see instead?
That spyder correctly autocompletes the typed statement, as it does when spyder is ran as root.
Versions

Spyder version: 3.3.4
Python version: 3.7.3
Qt version: 5.12.3
PyQt version: 5.12.2
Operating System name/version: Ubuntu 19.04, Linux 5.0.0

Dependencies

IPython >=4.0     :  7.5.0 (OK)
cython >=0.21     :  0.29.7 (OK)
jedi >=0.9.0      :  0.13.3 (OK)
matplotlib >=2.0.0:  2.2.3 (OK)
nbconvert >=4.0   :  5.5.0 (OK)
numpy >=1.7       :  1.16.3 (OK)
pandas >=0.13.1   :  0.24.2 (OK)
psutil >=0.3      :  5.5.1 (OK)
pycodestyle >=2.3 :  2.4.0 (OK)
pyflakes >=0.6.0  :  2.0.0 (OK)
pygments >=2.0    :  2.3.1 (OK)
pylint >=0.25     :  2.2.2 (OK)
qtconsole >=4.2.0 :  4.4.3 (OK)
rope >=0.9.4      :  0.10.5 (OK)
sphinx >=0.6.6    :  1.8.5 (OK)
sympy >=0.7.3     :  1.4 (OK)

Sorry, this looks like an installation issue. We recommend you to use Anaconda instead or wait until Spyder 4, which will have much better code completion facilities.


Add a c# tutorial for an insecure cluster

Fixes #2020
Also:
Fixes #2108
Fixes #1888
Fixes #1679

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/378bfcb7240dc685c7409b9c3b61d4ba3291edd8/

There is no link the pulldown menu to the page.

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks pending.

v1.1/build-a-csharp-app-with-cockroachdb.md, line 19 at r1 (raw file):

{% include copy-clipboard.html %}
~~~ shell

So all of this is very linux/mac os centric.  Perhaps we should add instructions for windows as well.  (In a follow up PR perhaps.)  Most c# users will be windows users.

v1.1/build-a-csharp-app-with-cockroachdb.md, line 36 at r1 (raw file):

{% include copy-clipboard.html %}
~~~ shell
$ dotnet add package Npgsql --version 3.2.5

This version number will change.  Perhaps mention to use the latest stable.  I wonder if it will work without the version number.

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/0c01fe9af6432b50a076a392f2cbccfd9353ef98/

Added it to the sidenav. Thanks for catching that, Bram.

Review status: 4 of 6 files reviewed at latest revision, 3 unresolved discussions, some commit checks pending.

v1.1/build-a-csharp-app-with-cockroachdb.md, line 19 at r1 (raw file):
Previously, BramGruneir (Bram Gruneir) wrote…
So all of this is very linux/mac os centric.  Perhaps we should add instructions for windows as well.  (In a follow up PR perhaps.)  Most c# users will be windows users.

If you find that some commands differ on Windows, I can definitely add an OS toggle. Let me know.

v1.1/build-a-csharp-app-with-cockroachdb.md, line 36 at r1 (raw file):
Previously, BramGruneir (Bram Gruneir) wrote…
This version number will change.  Perhaps mention to use the latest stable.  I wonder if it will work without the version number.

Good point. It does work without the version number, for me at least, so I've removed the --version flag:
~/cockroachdb-test-app2$ dotnet add package Npgsql
  Writing /var/folders/5t/1rt6nzr17sjg87mz5n0fw15c0000gn/T/tmp60g0LB.tmp
info : Adding PackageReference for package 'Npgsql' into project '/Users/jesseseldess/cockroachdb-test-app2/cockroachdb-test-app2.csproj'.
log  : Restoring packages for /Users/jesseseldess/cockroachdb-test-app2/cockroachdb-test-app2.csproj...
info :   GET https://api.nuget.org/v3-flatcontainer/npgsql/index.json
info :   OK https://api.nuget.org/v3-flatcontainer/npgsql/index.json 128ms
info : Package 'Npgsql' is compatible with all the specified frameworks in project '/Users/jesseseldess/cockroachdb-test-app2/cockroachdb-test-app2.csproj'.
info : PackageReference for package 'Npgsql' version '3.2.5' added to file '/Users/jesseseldess/cockroachdb-test-app2/cockroachdb-test-app2.csproj'.

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/73114954d928d72c314966651941df158e14b638/

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/ea4624ce7c4715b3bc0d3309d18c94804a43be60/

Reviewed 34 of 38 files at r3.
Review status: 36 of 40 files reviewed at latest revision, all discussions resolved, some commit checks pending.

Comments from Reviewable


Feature/causal dependencies

Coverage decreased (-0.7%) to 98.813% when pulling 3000e977f825fd99a7bbcb271d03006c39176726 on feature/causal_dependencies into 74702bfdfe5290195bbf60078a15f3c83abca1b4 on develop.


ERROR: Service 'tedge' depends on service 'tedge_build' which is undefined.

could you please write a brief comment or explanation about the build order and details?

@yucelzengin : Could you pls. try again to build the docker imaghe. The service "tedge_build" was removed as a multistage build in the ../thin-edge.io_examples/management-ui/tedge/Dockerfile was used?

Closing due to lack of response. Please reopen if your problem still persists.


Entrypoint issues when using custom DEDICATED_CFG

Based on what I see on the entrypoint.sh file there are a couple of problems that I encountered when using my own supplied config and setting DEDICATED_CFG env.

Despite the dedicated server authorization infos (masterserver login+password) entered in my config file, the entrypoint still demands that MASTER_LOGIN and MASTER_PASSWORD envs are set. This can be worked around by supplying dummy values.
Despite using a different config file, the entrypoint still writes the defaults (and the aforementioned masterserver account dummies) to dedicated_cfg.txt, which is not necessary and can even be harmful if UserData volume is shared across multiple containers.

Fixed with https://github.com/EvoEsports/docker-trackmania/commit/13196a7ddba8dca5e6e35c31dfda87a4e05e178c


Add dialog state to Slackbot worker createDialog

To support: https://api.slack.com/dialogs#state

Thanks!


Exports ftp_entry.dart

Fixes issue #6

Hello @salim-lachdhaf could you please merge this pull request and release a new version of this package?

Any chances of this PR getting merged soon @salim-lachdhaf ? listDirectoryContent() now returns a  List, but FTPEntry is not exported.

The project does not seem to be maintained. Anyway, someone feel free to create a new PR with the fix if it is still needed.


Handle 'cut' events

Coverage decreased (-0.9%) to 93.676% when pulling 3fabe73168c2952bf45543f940c82007e5d1019a on xodio:master into dc54882fc0fd2aabc048e36281f1075929f172b0 on nadbm:master.

thank you @evgenykochetkov , mind adding this to the README as well? thanks


Invalidate cache entry for service instances by subscribing to curator TreeCache

Current ZookeeperLoadBalancerConfiguration implementation caches service instances for 35 seconds by default.
If any instance get down in this period we will load balance on it anyway.
Of course, we can disable service instance cache, but it is not good by performance reasons (and zookeeper possible downtime).
In our project we implemented ServiceInstanceListCacheInvalidator which is subscribed to TreeCache from ZookeeperServiceWatch.
It removes single service instances (one cache entry) from cache when it is notified about that service instances change.
With this feature we can safely increase cache ttl to a relative big value (15 minutes or more).
What do you think about it? Can i make pull request with this feature?

We also encountered a similar problem, can you take a look at your code?


Captive core peer port can clash with other stellar core instances running on the machine

On stellar core the peer port is configured to 11625 by default. When captive core is launched it will fail to start if the peer port is occupied by another process (e.g. a stellar core instance running on the same host). To mitigate this we could either disable the peer port if that's possible or we could select a random port which is available on the host.

I think by simply adding a switch in the configuration options, maybe something like:
--captive-core-peer-port=
CAPTIVE_CORE_PEER_PORT

This can be set manually or defaulted to 11625

stellar-core config supports PEER_PORT option whcih defaults to 11625. Maybe we can use it for this purpose?