[spring-boot] Runtime introduction is not correct

This text
Chapter 1. Runtime Details

Spring Boot Tomcat enables you to create opinionated Spring-based standalone applications. Check out Additional Resources for further reading on Spring Boot Tomcat.

The Spring Boot Tomcat runtime enables you to run Spring Boot Tomcat applications and services in OpenShift while providing all the advantages and conveniences of the OpenShift platform such as rolling updates, service discovery, and canary deployments. OpenShift also makes it easier for your applications to implement common microservice patterns such as ConfigMap, Health Check, Circuit Breaker, and Failover.

Spring Boot Tomcat has a version of its runtime that is tested and verified to run on OpenShift. Some components, for example, the Embedded Tomcat Container and the Java container image, are provided as part of a Red Hat subscription when used with Spring Boot Tomcat.

should be replaced by
The Spring Boot Embedded Apache Tomcat container, which is part of the RHOAR 1.0 GA release has been tested, controlled according to different use cases and starters currently shipped on OpenShift 3.5 using Spring Boot 1.5.8.RELEASE.

This RHOAR 1.0 GA version packages Spring Boot 1.5.8.RELEASE with the embedded Web Container Apache Tomcat 8.5 and the following different starters

Starter | Version
-- | --
spring-boot-maven-plugin | 1.5.8.RELEASE
spring-boot-starter-actuator | 1.5.8.RELEASE
spring-boot-starter-data-jpa | 1.5.8.RELEASE
spring-boot-starter-data-rest | 1.5.8.RELEASE
spring-boot-starter-jdbc | 1.5.8.RELEASE
spring-boot-starter-test | 1.5.8.RELEASE
spring-boot-starter-logging | 1.5.8.RELEASE
spring-boot-starter-tomcat | 1.5.8.RELEASE
spring-boot-starter-web | 1.5.8.RELEASE
cxf-spring-boot-starter-jaxrs | 3.1.12
spring-cloud-starter-kubernetes (core) | 0.2.0
spring-cloud-starter-kubernetes-netflix | 0.2.0
spring-cloud-starter-kubernetes-zipkin | 0.2.0

IMPORTANT: Some components, for example, the Embedded Tomcat jar files and the Java container image - OpenJDK 1.8, are provided as part of a Red Hat subscription when used with our Spring Boot Tomcat.

.  For our documentation, we put version related information for the Runtime in our Release notes. That is where  the starters and versions will be listed, along with the statement of testing/certification for OpenShift 3.5.

Release notes

So maybe, we could add here a link to the Release Notes to have one place where this content is managed ?

@cmoulliard  will see it a link for release notes can be added when available. We dont have the actual document currently. I was asked to include version information here by another team. So can mention the Spring Boot version here and leave other information in the Release notes.

Will update via follow on issue to add link for release notes when available

#856 closed. @lavernw1, feel free to add an issue labelled "Component | Release Notes" noting the necessary tatsks.

@inoxx03 I've updated follow-on issue 863  with this task.


revise some annnotations and fix fallback check bug

Revise some annotations and fix fallback check, originally,
1, Annotations above function is not well
2, Fallback check does not take effect
Checklist

[ ] When introducing a new scaler, I agree with the scaling governance policy
[x] I have verified that my change is according to the deprecations & breaking changes policy
[ ] Tests have been added
[x] Changelog has been updated and is aligned with our changelog requirements
[ ] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
[ ] A PR is opened to update the documentation on (repo) (if applicable)
[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)

related issue
https://github.com/kedacore/keda/issues/6355

@zroubalik @wozniakjan @SpiritZhou @psi @wonko @fivesheep @JorTurFer  hope you to review and discuss, thank you

hope you to review and discuss, much thanks.

I won't block anything if the consensus is reached and it goes the other way than I'm suggesting, but I would personally keep the webhook as is, that means print error but allow the SO. To improve feedback to the user, keda-operator should throw a WARNING event that fallback with CPU/memory scalers is not supported.
The discussion what would be the ideal desired behaviour is likely going to take time. As a KEDA user, I would like some form of fallback when using some external trigger together with CPU/memory too. Fallback is a great strategy to make autoscaling robust against partial system outages and CPU/memory is far too common of a trigger. If using CPU/memory trigger prevents users from setting fallback on other scalers, that would be imho bad UX. Now how it's going to be implemented and working, that might be challenging to figure out.

https://github.com/kedacore/keda/pull/6407, here new PR, which has followed your idea. Hope for your review.


Print timestamp in error messages

These lines are identical, which makes it hard to determine at a glance if we're actively looping & trying to connect. It would be good to have some difference between error lines, and timestamps would help.

I'm going to close this for now since it has a merge conflict and we're no longer using this plugin internally. Feel free to re-open if you want to rebase and fix the comment for merging.


Fixed test_dumpdata_progressbar to use the instantiated StringIO object.

I don't think this changes any behavior. new_io and options['stdout'] reference the same object as far as I see.

In this test, a StringIO object is instantiated twice. Also ``dumpdatais called twice. It is my impression that the twoStringIO` objects were each intended for the individual calls.
Before this change, the second new_io value is never passed to anything. So of course asserting the the contents are the empty string is true. The second dumpdata is writing stdout to the first new_io object. So again, asserting the the empty string is obvious.
It was my impression that the second call to dumpdata should use the second StringIOobject.
Further, before my change, if you comment out the line options['verbosity'] = 0, the test still passes. With my change, it does not. I believe this demonstrates the original intent of the second portion of the test.

My mistake. merged in cacc7e85e17b3d00e7ed856d8bbadb8f870bb5d6, thanks!


RYA-371 Added scripts to run MongoRyaDirectExample

Description
Added a .sh script for RyaDirectExample to match the .bat file in the indexingExample distribution.  Added similar scripts to run MongoRyaDirectExample.
Tests
Ran MongoRyaDirectExample .sh script against a MongoDB installation on a VM
Ran MongoRyaDirectExample .sh script against a Percona installation on a VM
Links
Jira
Checklist

[ ] Code Review
[ ] Squash Commits

People To Review
@pujav65 @amihalik @meiercaleb @amihalik

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/496/

looks good, not necessarily how i would have done it, but it gets the job done.  I will merge in a second.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/506/


Make esify an installable binary

This adds esify as an actual project into the JS repo, and moves things around so that it can work by being installed globally and running esify path/to/file.coffee from the root of the Shopify repo.
cc/ @GoodForOneFare @bouk

We probably shouldn't commit the compiled code

Yeah, I rolled back the compiling stuff because the other transforms we use need babel to work properly anyways :(

Does this belong in here?  It seems like we'll just delete it once the conversion is complete.

Code LGTM, and 🎩 went well.
Note that I couldn't lint this; if I roll back to before @d0ab34203de7fc25aa0bd476548de130e7df1faa, things work again.

@GoodForOneFare I think it's fine in here, simplifies how many repos we have and we can just delete it once it's no longer useful. I think the linting issues will probably go away with a fresh script/setup.


Denial and Resharing Default capability

2 missing capabilities from upstream

Resharing allows resharing, Resharing Default sets wether the other roles (editor, reader, etc) enable resharing or not (if not, you can use the custom permissions to set it.


Consider renaming the project

For once, "jobdsl" seems to be more common than "job-dsl" (although I agree the latter is slight better to read). Secondly, I believe it would be nice to somehow express the relationship to Jenkins in the name. Maybe "gradle-jenkins-dsl-plugin"?

I would go for "gradle-jenkins-jobdsl-plugin" instead to avoid confusion with the Pipeline DSL, do you agree?

Agreed. "gradle-jenkins-jobdsl-plugin" also was on my list of proposals, but I though you'd find it to be too long 😉

Renamed the repository already.


App crashes both on Android and iOS when input type text receives focus in webview

Bug description:
a web page loads successfully but as soon as input type text receives focus on webpage keyboard appears and app crashes both on Android and iOS giving 2 different error messages.
Please see the attached videos.
Here is my render method. What I am doing wrong?
render() {
return (
<View style={{flex:1, paddingTop:40}} >

<WebView
source={{uri: 'http://jsonviewer.stack.hu/'}}
style={styles.container}
javaScriptEnabled={true}
domStorageEnabled={true}
startInLoadingState={true}
keyboardDismissMode={'none'}
useWebKit={true}
automaticallyAdjustContentInsets={true}
/>

)
}
To Reproduce:

Expected behavior:

Screenshots/Videos:

Environment:

OS: Android and iOS
OS version:
react-native version: 0.59.0
react-native-webview version: 5.8.2

No idea about what happening 🤔

@sangyakhare Are you using react-navigation ? I'm experiencing the same issue whenever the screen including  Webview is on a stackNavigation and there are more than 2 steps (stacked views) to reach it.

@bestmazzo I am using wix react-native-navigation v2. And your observation is right. It is happening on Modal as well as on a stacked screen. Both involve 2 steps. I see keyboard appearing for a fraction of second and then the error occurs. Looks to me that the issue is with keyboard sliding content above to make space for itself. Not sure how to resolve it. :(
It happens when I click inside the input field in Webview, to write something.

Did anyone find any resolution on this?

@bestmazzo did you find any work around?

@Titozzz looks like when the keyboard tries to scroll the screen something with the calculation is causing this problem on both the platforms. And it is the bridge issue.

Hi @sangyakhare  and @bestmazzo , did you solved this issue ? I have same error as yours


Explicitly allow unwinding when panicking

This PR allows compilation using nightly rustc. As per rustc --explain E0633, allowed is already the default; this just squelches the error by making it explicit.

Thanks @nhynes !


chore: bdd-spring-1578926761 to 0.0.1

chore: Promote bdd-spring-1578926761 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[BUG] Negative RGB values for country colours appear garbled

Describe the bug
Countries with negative RGB values appear garbled.
To Reproduce
Set a country's rgb values to be negative
Expected behavior
Hoi4 lets you set countries' rgb values to be negative(max -256) so they act as offsets to the engine's post processing, i supposed the expected behaviour here would be for those values to default 0 within the preview.
Screenshots

Desktop (please complete the following information):

OS: Windows 10
VSCode version: 1.63
Extension version: 0.5.0

Console Logs
Not needed.

I didn't know that country color can have negative values.
Can you share me an article that describe how negative color values works?

I dont think there is a full article with an explanation(I picked this up from other modders) but what they do is they offset the colours the game would have rendered from post processing
For example:
You have a country with the colour 255,0,0
However ingame due to post processing it shows up as 255,43,60
Lets say you want that country to show up as 255,0,0 what you would would be to assign its colour code as 255,-43,-60 and thus offsetting the post processing of the game(tho its not universal since post processing depends on your camera distance, position, time of ingame day, and so on).
Since you only use this feature to achieve specific, generally vibrant, colours where one of your rgbs would be 0 its a thing that's rarely used. The solution like I suggested would be to just add a simple check if the rgb values are negative and if yes then set them to 0 for the display.

Let me explain with some screenshots.
Here the tag has the rgb value 255,0,0

and here with it set to 255.-255,-255

As you can see in the first image the post processing added some colouring to the green and blue channels

Yup, that works, the preview colours were already always gooing to be a little off due to post processing anyhow, but still serve their purpose as a general indication.
Thanks!


CHANGE TEXT DEF_CONVERSATION_WITHOU_DATA

Hello,
Would you know how I can customize the text "The requested information is not found in the retrieved data. Please try another query or topic." which is triggered in the def_conversation_without_data function, when the question asked does not have an answer within the cognitive search documents.

Hi @phfontes this message is not currently customizable. You could add some postprocessing on the message before it's displayed to the user to replace it with another string if you wanted though.

Hi,
Thanks for the feedback, I tried doing some tests.
Through the debug, I saw that the function below is responsible for taking the content and sending it.
In the else part where the deltatext is created, it ends in yield, triggering another function, def format_as_ndjson(obj: dict) -> str:
And then it goes back to yield and goes up to the for line
I believe you could put an if in the variable that stores the content sent to the body and check if it is different from "The requested information..."
But I can't understand where it collects the deltatext information and sends it to the body of the page
Could you clarify?
def stream_with_data(body, headers, endpoint):
s = requests.Session()
linhas = []
response = {
"id": "",
"model": "",
"created": 0,
"object": "",
"choices": [{
"messages": []
}]
}
try:
with s.post(endpoint, json=body, headers=headers, stream=True) as r:
#linha onde busca o conteúdo, acompanhar pela propriedade line, nas variaveis locais
for line in r.iter_lines(chunk_size=10):
if line:
lineJson = json.loads(line.lstrip(b'data:').decode('utf-8'))
if 'error' in lineJson:
yield format_as_ndjson(lineJson)
response["id"] = lineJson["id"]
response["model"] = lineJson["model"]
response["created"] = lineJson["created"]
response["object"] = lineJson["object"]
                role = lineJson["choices"][0]["messages"][0]["delta"].get("role")
                if role == "tool":
                    response["choices"][0]["messages"].append(lineJson["choices"][0]["messages"][0]["delta"])
                elif role == "assistant":
                    #adiciona chave role e content ao messages
                    response["choices"][0]["messages"].append({
                        "role": "assistant",
                        "content": ""

                    })
                else:
                    deltaText = lineJson["choices"][0]["messages"][0]["delta"]["content"]
                    if deltaText != "[DONE]":
                        #adiciona o conteúdo do deltatext ao content
                        response["choices"][0]["messages"][1]["content"] += deltaText
                        linhas.append(deltaText)

                #retorna para outra função formatar em json
                #yield

                yield format_as_ndjson(response)
        print(linhas)
except Exception as e:
    yield format_as_ndjson({"error": str(e)})

is it still not possible?


Add ability to upload files within http forms.

Note: buffered file can't be saved within vcr cassettes, thus integration test is marked for skipping. I work on solution

This seems to be a major breaking change, updating the create_request method. Is that correct?

Yes, that would be a breaking change, although it doesn't brake existing functionality. This change might break the client code if somebody creates requests manually, thus we can update major version if this solution is accepted.


support of cubic lookup files

Original ticket:
https://sourceforge.net/p/djv/feature-requests/6/

I've added support for OpenColorIO to DJV which reads the file formats mentioned in the original request:
https://opencolorio.org/FAQ.html#what-lut-formats-are-supported


server: Create File doesn't support custom Validation

ACH Version: v1.5.0-rc1, v1.4.x
What were you trying to do?
Creating an endpoint with the HTTP server (POST /files/create) doesn't allow you to set the ValidateOpts struct like it does if you use the Go library directly.
This impacts the ability for other languages (e.g. Java) to fully use our ACH http server.
What did you expect to see?
We should support all of the features in the Go library in our HTTP server.

One solution could be query parameters for each member of ValidateOpts.

requireABAOrigin
bypassOriginValidation
bypassDestinationValidation

This doesn't support the custom validation function coming in v1.5.0, but we can't transmit binary code over the HTTP server anyway.

Another option suggested was HTTP headers, but I'm not a fan of that. We should leverage query params as that's more in line with the HTTP standard.

Query params seem like a good solution, I can work on this.

We have two options for query params:

/files/create?requireABAOrigin=1&bypassOriginValidation=1
/files/create?validate=requireABAOrigin,bypassOrigin

I slightly prefer #2; what would you prefer?

I was thinking requireABAOrigin=true


[bug]: Crash when generating many images with Restore Face enabled

Is there an existing issue for this?

[X] I have searched the existing issues

OS
Linux
GPU
cuda
VRAM
8GB
What happened?
When using the web interface to generate lots of images ("lots" in this case is subjective as it seems to relate to the amount of VRAM) if you also enable the Restore Face option from the advanced options menu, InvokeAI will crash.
In my case I was generating 500 images with the Restore Face option enabled and at image 13 InvokeAI crashed with the message RuntimeError: CUDA out of memory.
If I disable the Restore Face option, I can generate seemingly as many images as I want - although I haven't tested with a batch size greater than 500 yet.
Here is the stack trace:
Traceback (most recent call last):
  File "/mnt/media/stable-diffusion/InvokeAI/ldm/generate.py", line 467, in prompt2image
    results = generator.generate(
  File "/mnt/media/stable-diffusion/InvokeAI/ldm/invoke/generator/base.py", line 90, in generate
    image = make_image(x_T)
  File "/mnt/media/stable-diffusion/InvokeAI/.venv/lib/python3.10/site-packages/torch/autograd/grad_mode.py", line 27, in decorate_context
    return func(*args, **kwargs)
  File "/mnt/media/stable-diffusion/InvokeAI/ldm/invoke/generator/txt2img.py", line 57, in make_image
    return self.sample_to_image(samples)
  File "/mnt/media/stable-diffusion/InvokeAI/ldm/invoke/generator/base.py", line 109, in sample_to_image
    x_samples = self.model.decode_first_stage(samples)
  File "/mnt/media/stable-diffusion/InvokeAI/.venv/lib/python3.10/site-packages/torch/autograd/grad_mode.py", line 27, in decorate_context
    return func(*args, **kwargs)
  File "/mnt/media/stable-diffusion/InvokeAI/ldm/models/diffusion/ddpm.py", line 1118, in decode_first_stage
    return self.first_stage_model.decode(z)
  File "/mnt/media/stable-diffusion/InvokeAI/ldm/models/autoencoder.py", line 421, in decode
    dec = self.decoder(z)
  File "/mnt/media/stable-diffusion/InvokeAI/.venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
    return forward_call(*input, **kwargs)
  File "/mnt/media/stable-diffusion/InvokeAI/ldm/modules/diffusionmodules/model.py", line 613, in forward
    h = self.up[i_level].block[i_block](h, temb)
  File "/mnt/media/stable-diffusion/InvokeAI/.venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
    return forward_call(*input, **kwargs)
  File "/mnt/media/stable-diffusion/InvokeAI/ldm/modules/diffusionmodules/model.py", line 134, in forward
    h = self.norm1(x)
  File "/mnt/media/stable-diffusion/InvokeAI/.venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1130, in _call_impl
    return forward_call(*input, **kwargs)
  File "/mnt/media/stable-diffusion/InvokeAI/.venv/lib/python3.10/site-packages/torch/nn/modules/normalization.py", line 272, in forward
    return F.group_norm(
  File "/mnt/media/stable-diffusion/InvokeAI/.venv/lib/python3.10/site-packages/torch/nn/functional.py", line 2516, in group_norm
    return torch.group_norm(input, num_groups, weight, bias, eps, torch.backends.cudnn.enabled)
RuntimeError: CUDA out of memory. Tried to allocate 384.00 MiB (GPU 0; 7.79 GiB total capacity; 5.54 GiB already allocated; 295.62 MiB free; 6.23 GiB reserved in total by PyTorch) If reserved memory is >> allocated memory try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF

Screenshots
No response
Additional context
For additional context about the batch of images I was generating:

Model: stable-diffusion-1.5
Steps: 200
CFG Scale: 15
Width: 512
Height: 768
Sampler: k_euler
Seed: <fixed, not random>
Variation Amount: 0.4
Restore Face Type: gfpgan
Restore Face Strength: 0.8
Upscale Scale: 4x
Upscale Strength: 0.75

I also tested this with Upscale enabled and Restore Face disabled and did not experience a crash. As far as I can tell the issue only occurs with Restore Face enabled.
Lastly, I'm not sure which version of InvokeAI I'm using, but it's the one that was available 5-7 days before the latest version with Canvas was released.
Contact Details
No response

So, face restoration is extremely resource consuming, it is quite normal that for 500 images, and with only 8gb of available VRAM, all the memory is consumed. I don't know exactly how memory is used, but I believe the whole batch of images has to remain in memory before face restoration starts working.

Yes, but if I had specified 14 images it would have still failed at image 13. The problem doesn't seem to be related to the total number of images being generated, it seems to be more so that VRAM isn't freed after the Restore Face process completes. This quickly consumes all available VRAM within just a handful of images.
The whole batch remaining in memory doesn't seem to be the case, because I can generate 500 images, then go to each one and click the button to Restore Face, it will generate another image in my library, but it works and won't run out of VRAM. When I use the Restore Face in the batch process, it must work differently because it doesn't generate a new image in the library and runs out of VRAM.


update presentation state, add August '22 archive folder

Added a folder for August in the presentations archive.
Shuffled presentation section on home page to reflect last meeting.
Respectfully,
J. Stelly

Will open new PR to make recommended changes.
Respectfully,
J. Stelly


bug: SDK typings broken on v3.1.0

Provide environment information
System:
OS: macOS 15.0.1
CPU: (10) arm64 Apple M1 Max
Memory: 415.19 MB / 64.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 22.0.0 - ~/.nvm/versions/node/v22.0.0/bin/node
Yarn: 4.5.0 - ~/.nvm/versions/node/v22.0.0/bin/yarn
npm: 10.5.1 - ~/.nvm/versions/node/v22.0.0/bin/npm
bun: 1.1.29 - ~/.bun/bin/bun
Describe the bug
Typings are broken on the 3.1.0 SDK release. Working on 3.0.13.

Reproduction repo
...
To reproduce
Install 3.1.0. In case it matters, I've got "type": "module", in my package.json file.
Additional information
No response

What's your tsconfig.json?

🤦♂  we've got "customConditions": ["workerd", "worker", "browser"] in there because historically we've mostly working in cloudflare environments. That was the issue - feel free to close. Thanks!

This has been fixed in 3.1.1


[Ionic v4] Button overflow hidden -> attribute contain as variable

Ionic Info
@ionic/angular: "4.0.0-beta.0"
Describe the Bug
To follow up my previous issue about text overflow in button https://github.com/ionic-team/ionic/issues/14839 I noticed that it isn't yet possible to overflow a text in a button
The property contain of shadow button is fix set to content. If I want to overflow a text, I should be able to set this attribute to inherit otherwise the text won't be displayed
Expected Behavior
Add a css4 variable in order to override the attribute contain of buttons
Rendered code screenshot

@brandyscarney sure
<ion-button class="big-button"
          no-margin no-padding>
<div>
  <ion-icon name="icon"></ion-icon>

  <ion-label text-wrap no-margin>Text of the action</ion-label>
</div>

ion-button.button.big-button {
  border-radius: 50%;
  border: 0;
  background: $color-right;
  background: -webkit-linear-gradient($direction, $color-left, $color-right);
  background: -moz-linear-gradient($direction, $color-left, $color-right);
  background: -o-linear-gradient($direction, $color-left, $color-right);
  background: linear-gradient($direction, $color-left, $color-right);
  --background: transparent;
 box-shadow: 0 1px 2px rgba(0, 0, 0, 0.3);
 --box-shadow: none;
 --margin-top: 0;
 --overflow: visible;

  // HERE I need the Css4 contain variable
 --contain: inherit;

  div {
    border-radius: 50%;

    ion-label {
      text-transform: none;
      white-space: normal;
      position: relative;
      margin: 0;
      overflow: inherit;
      font-weight: 300;
    }
 }
}

I provided the PR, hope it's correct -> https://github.com/ionic-team/ionic/pull/15011

@brandyscarney don't want to rush you but would it be possible to merge my related PR https://github.com/ionic-team/ionic/pull/15011 for next beta?
I've done some good progress in the (re)styling of my app and this attribute for my buttons becomes a missing chain

@brandyscarney you could forget this feature
I have rewrite my code in order to use button instead of ion-button and added an animation à la fab button which even gives a better result
Therefore I close my feature request and my PR https://github.com/ionic-team/ionic/pull/15011


Setting a stroke width for a Tex object gives "M" devil horns

Consider the following scene:
class Test(Scene):
    def construct(self):
        test = Tex("M")
        test.set_stroke(color = RED, width = 8)
        self.add(test)

This is the result with the cairo renderer:

I would expect those devil horns not to be there.  Interestingly, while the problem seems to be there in the opengl renderer as well, it's not nearly as pronounced.

If you scale up your code you can see exactly where those "horns" come from and that they are unavoidable.
LaTeX renders the output in order to only fill the outline of the font with no stroke - so expecting anything useful from showing the stroke seems strange to me, especially with a stroke width which is wider than the lines of the letters.
class Test(Scene):
    def construct(self):
        test = Tex("M").scale_to_fit_height(6)
        test.set_stroke(color = RED, width = 8)
        self.add(test)

actually I am not able to reproduce your un-scaled image on my system with Manim 0.17.3. Instead I get this output:

and here is some animated code showing what is happening:
class Test2(Scene):
    def construct(self):
        stroke = ValueTracker(0)
        test = always_redraw(lambda:
            Tex("M").scale_to_fit_height(2).set_stroke(color = RED, width = stroke.get_value())
        )
        self.add(test)
        self.play(stroke.animate.set_value(160), rate_func=rate_functions.linear, run_time=3)

https://github.com/ManimCommunity/manim/assets/8582807/b37b95aa-e6f1-4717-87cf-eb8febf1bdb0

#3321 Might fix this?

Having a thick stroke around a text letter in my view does not really make sense...
And yes, text rendering in opengl is currently kind-of broken and MrDiver is working on it.

This is the output of my animated script using --renderer=opengl 0n 0.17.3 - no horns there either...
https://github.com/ManimCommunity/manim/assets/8582807/ee7e9732-0ff9-47bd-8695-3b484b4ec079

Having a thick stroke around a text letter in my view does not really make sense...

I use it in my videos to have an outline around letters.  I draw the text twice, once with a thick, black stroke, and then another time normally on top of it.  It looks perfect in most situations, but this is the one situation where it looks weird.
I'm a bit surprised that some people aren't having this issue at all.  For the people not having this issue, are you using the cairo renderer?  If so, what is the information I should provide to help figure out where the difference lies?  I use ArchLinux, and my manim version is 0.17.3.

There is a thing called background_stroke

what is the information I should provide to help figure out where the difference lies?

...start by showing the version of all your libraries pip list and the update status of your LaTeX libraries.
I have no horns on two Windows 10 system (AMD and Intel) as well as a WSL-Ubuntu using cairo and opengl.

There is a thing called background_stroke

Aw man why didn't I hear about this sooner?  That would have saved me some headaches.  However, using background_stroke still creates horns.
Here's the output of pip list:
Package             Version                            Editable project location
------------------- ---------------------------------- ---------------------------------------
asttokens           2.2.1
attrs               22.2.0
autocommand         2.2.2
backcall            0.2.0
btrfsutil           6.3.2
cffi                1.15.1
chardet             5.1.0
click               8.1.3
click-default-group 1.2.2
cloup               0.13.1
colorama            0.4.6
colour              0.1.5
contourpy           1.1.0
cryptography        41.0.2
cycler              0.11.0
dbus-python         1.3.2
decorator           5.1.1
distlib             0.3.6
distro              1.8.0
executing           1.2.0
fastjsonschema      2.18.0
filelock            3.12.0
fonttools           4.40.0
glcontext           2.3.7
idna                3.4
inflect             7.0.0
ipython             8.13.2
isosurfaces         0.1.0
jaraco.context      4.3.0
jaraco.functools    3.8.0
jaraco.text         3.11.1
jedi                0.18.2
kingdon             0.1.0                              /home/sudgy/programs/python/kingdon
kiwisolver          1.4.4
lensfun             0.3.4
lensfun             0.3.4
libtorrent          2.0.9
llvmlite            0.40.0
louis               3.26.0
manim               0.17.3
manimgl             1.6.1                              /home/sudgy/programs/python/manim/manim
ManimPango          0.4.3
mapbox-earcut       1.0.1
markdown-it-py      2.2.0
matplotlib          3.7.1
matplotlib-inline   0.1.6
mdurl               0.1.2
moderngl            5.8.2
moderngl-window     2.4.3
more-itertools      9.1.0
mpmath              1.3.0
multipledispatch    0.6.0
netsnmp-python      1.0a1
networkx            2.8.8
noise               1.2.2
numba               0.57.1
numpy               1.25.1
ordered-set         4.1.0
packaging           23.1
parso               0.8.3
pexpect             4.8.0
pickleshare         0.7.5
Pillow              9.5.0
pip                 23.2.1
platformdirs        3.9.1
ply                 3.11
pocketsphinx        5.0.1
prompt-toolkit      3.0.38
ptyprocess          0.7.0
pure-eval           0.2.2
pycairo             1.23.0
pycparser           2.21
pydantic            1.10.9
pydub               0.25.1
pyenchant           3.2.2
pyglet              2.0.6
Pygments            2.15.1
PyGObject           3.44.1
PyOpenGL            3.1.7
pyparsing           3.0.9
pyperclip           1.8.2
pyrr                0.10.3
python-dateutil     2.8.2
PyYAML              6.0
Reflector           2<IP_ADDRESS>.36.1
requests            2.28.2
rich                13.4.2
scipy               1.10.1
screeninfo          0.8.1
setuptools          68.0.0
six                 1.16.0
skia-pathops        0.7.4
sounddevice         0.4.6
srt                 3.5.3
stack-data          0.6.2
svgelements         1.9.3
sympy               1.11.1
TBB                 0.2
tomli               2.0.1
tqdm                4.65.0
traitlets           5.9.0
trove-classifiers   2023.7.8
typing_extensions   4.7.1
uc-micro-py         1.0.2
urllib3             1.26.15
validate-pyproject  0.13.post1.dev0+gb752273.d20230520
validators          0.20.0
virtualenv          20.21.0
watchdog            2.3.1
wcwidth             0.2.6
wheel               0.40.0

How do I see the update status of my LaTeX libraries?  I just have the ArchLinux texlive-most package installed, and that's version 2023.66594-19.


This line of code returns an unexpected value when unmasking as number

https://github.com/RobinHerbots/Inputmask/blob/3.x/js/inputmask.js#L1853
The problem happens when you have a numeric mask with unmaskAsNumber = true and you want to retrieve the number 0 calling .unmaskedvalue()
In general: 0 || somethingElse = somethingElse so there is a problem when onUnmask returns correctly 0, because the || operator between 0 and the original masked value (lets say '0,00') causes this line to return '0,00' that is a string.
see this fiddle: https://jsfiddle.net/ufppk1te/8/

see fiddle https://jsfiddle.net/ufppk1te/7/

Hi @andrea-spotsoftware ,
Thx for reporting.  It is fixed, but I will submit the fix together with other fixes ;-) (soon)


auth.cfg and keypair-file

Since ssh-config defaults to ~/.ssh/config when un-configured in auth.cfg, should keypair-file also be optional?
It seems to me there should really be no reason to specify a ssh-config or keypair-file.  If you want to use different ssh settings for a given host, then update your .ssh/config with the appropriate Host entry.
However, I am sure there are valid use cases for this implementation.  If anything I feel it is silly for me to not define a ssh-config, yet have to define a keypair-file (which I already have defined in my default ssh config).

I hope that is better for you now.
Also, if you don't want to define a password, and only want to type it once for each node, just add to your ssh-config:
Host *
    ControlMaster auto
    ControlPath ~/.ssh/master-%r@%h:%p


ConfigDB registers itself over MQTT

The ConfigDB registers itself over MQTT. This is currently required so that the service registration includes an MQTT device UUID.

This is not quite straightforward: the ConfigDB cannot initially be registered over MQTT, as we need a ConfigDB service registration before MQTT will accept any connections.
The Directory HTTP registration API will accept a sparkplug Device ID, but currently the code supporting this is broken.

A fix for this is required for V3. The EDO and the edge-sync both monitor the ConfigDB over MQTT and both fail if the MQTT device registration isn't available.

This has been fixed entirely in the Directory code. The service registration override call made in the existing initContainer now registers a device UUID as well.


Introducing a secure software supply chain mechanism, such as in-toto, to Uptane

At our last 2020 Standards meeting, the issue was raised that Uptane Deployment Best Practices should discuss options for securing the supply chain for automotive software. The Secure System Lab's in-toto project has already proven successful in integrating with TUF for such purposes. This issue thread can serve as a forum for discussing how to utilize the in-toto framework to minimize attack surfaces, and extend the protections of Uptane through the lifecycle of a piece of software.

I think ITE-2 and ITE-3 should be decent start points for documentation on why and how to combine TUF and in-toto.

I think ITE-2 and ITE-3 should be decent start points for documentation on why and how to combine TUF and in-toto.

@trishankatdatadog Do you think we could extract some starter text from those documents to begin playing with a PR on this issue? I think discussion is always better when we can put some text in play.

@trishankatdatadog Do you think we could extract some starter text from those documents to begin playing with a PR on this issue? I think discussion is always better when we can put some text in play.

Can someone take a run at developing some starter text for this issue? It is flagged for 2.0.0, but I think it would be helpful to put together a proposal for text on the Deployment pages. Even if we are not ready to propose an actual solution, I believe in the wake of SolarWinds, we should acknowledge that this is an issue we are investigating.

This issue was discussed at some length at the 4/13/21 Uptane meeting. @JustinCappos recommended we look at the DataDog integration and/or software bill of materials (SBOM) entries. @iramcdonald pointed us towards the  NTIA Software Component Transparency (https://www.ntia.doc.gov/SoftwareTransparency).  We will be looking at various approaches and will add some copy to the Deployment pages on this topic.

Hi Lois,
For NTIA, the primary reference should be to their SBOM (Software Bill of
Materials) project:
https://www.ntia.gov/SBOM
The other NTIA reference was to a related conference, but does not include
the list of tools,
formats, and standards for SBOMs (which are listed at the above
reference).
My TCG colleague Henk Birkholz (Fraunhofer Security Institute) is actively
participating in
the NTIA SBOM project.
Cheers,

Ira

Ira McDonald (Musician / Software Architect)
Chair - SAE Trust Anchors and Authentication TF
Co-Chair - TCG Trusted Mobility Solutions WG
Co-Chair - TCG Metadata Access Protocol SG
Chair - Linux Foundation Open Printing WGSecretary - IEEE-ISTO Printer
Working GroupCo-Chair - IEEE-ISTO PWG Internet Printing Protocol WGIETF
Designated Expert - IPP & Printer MIBBlue Roof Music / High North
Inchttp://sites.google.com/site/blueroofmusic
http://sites.google.com/site/blueroofmusichttp://sites.google.com/site/highnorthinc
http://sites.google.com/site/highnorthincmailto: @.**
@.**>(permanent) PO Box 221  Grand Marais, MI 49839
906-494-2434
On Tue, Apr 20, 2021 at 9:30 PM Lois Anne DeLong @.***>
wrote:

This issue was discussed at some length at the 4/13/21 Uptane meeting.
@JustinCappos https://github.com/JustinCappos recommended we look at
the DataDog integration and/or software bill of materials (SBOM) entries.
@iramcdonald https://github.com/iramcdonald pointed us towards the NTIA
Software Component Transparency (
https://www.ntia.doc.gov/SoftwareTransparency). We will be looking at
various approaches and will add some copy to the Deployment pages on this
topic.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/uptane/deployment-considerations/issues/82#issuecomment-823709294,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE33UO2BVBPO5IPRUZXJGWDTJYTD7ANCNFSM4VRPVJ5A
.

Thanks for the update, Ira.

ITE-2 and ITE-3 might help...

As of the 8/3 Standards meeting, it was decided this topic will be addressed in our next whitepaper, which is to be released in December. Text will likely be added to the Deployment pages but possibly not in time for 2.0.0..

Note that @trishankatdatadog  opened PURE Issue #2 dealing with this topic (https://github.com/uptane/pures/issues/2), so in parallel with the whitepaper he and @mnm678 will be drafting a PURE as well.

Closing this via PR #121. I have left Issue #222 on the Standard page as a placeholder for additional thoughts on supply chain.


SkyConnect Thread Channel Mismatch Issue

I received a repair warning that the zigbee and thread channels were different. However, the repair warning is wrong.
It states my thread channel is 25 and ZHA is 15, but it is actually the reverse. My ZHA is channel 25 and Thread is 15 (see images below).
However, the instructions to fix a channel mismatch given herehttps://skyconnect.home-assistant.io/about-multiprotocol/#resolve-channel-conflict do not work either. I have tried Option 2 in that document, because I want my Thread channel to match my Zigbee channel but when I reset my Thread nothing happens, the channel stays at 15. Have also tried restarting after reset.
Repair Notification

ZHA

Thread (before and after reset)

Further on this, because the documentation repair instructions didn't work I had to do the following to get my Thread channel to match my Zigbee channel

Delete Thread and OBT integrations
Reboot (not restart) my HA server
Install Thread and OBT integrations again (defaulted to channel 15 again)
Reconfigure Thread

This then successfully matched the channels but it's not straightforward.

Further on this, because the documentation repair instructions didn't work I had to do the following to get my Thread channel to match my Zigbee channel

Which Option did you choose? And what version of HA were you using? Where/how did the instructions fail?

This adds some more logs when users of the multipan radio register: https://github.com/home-assistant/core/pull/94580

@c0nt4x it's good that you managed to manually resolve your problem, but it also makes it harder to understand and solve the root cause. Can you try to make this problem happen again? If not, I think we have to close this issue for now.
If the issue happens again, a log file is needed.

@c0nt4x When this issue happened, what version of Home Assistant Core were you using?


Karate 1.4 takes significantly longer to run tests than 1.2

@ptrthomas
Karate 1.4 is still significantly slower than 1.2 for large projects.
We're seeing between a +20% to +100% increase in time to run tests.
Haven't yet been able to identify most common examples of why tests are running longer.
If I run a benchmark on 1.2 vs 1.4 I'll submit results here
Likely related to synchronization in:
https://github.com/karatelabs/karate/issues/2204
Not sure if possible to do a deep copy of context to minimize synchronization code.

related issue to investigate: https://stackoverflow.com/a/76285986/143475
recommendation is to use Java instead of JS functions where possible. one suggestion to help you troubleshoot is place some obvious logging around the lock and then you can scan the logs to see how many times - and where in your tests it is invoked. for example, if you do ScenarioEngine.get() you can get the "active" scenario and introspect the feature, karate call stack etc.
will investigate, but this may take a while. I would recommend refactoring to Java, it may needed only for a few hotspots, most likely utility functions you may be using @ericdriggs

the lock is over here: https://github.com/karatelabs/karate/blob/v1.4.0/karate-core/src/main/java/com/intuit/karate/graal/JsValue.java#L307

To summarize concurrency issue
PolglotContextImpl::throwDeniedAccess throws for mult-threaded access for languages which don't have isThreadAccessAllowed == true
`...

 * By default every {@link #createContext(Env) context} only allows access from one thread at the
 * same time. Therefore if the context is tried to be accessed from multiple threads at the same
 * time the access will fail. Languages that want to allow multi-threaded access to a context may
 * override {@link #isThreadAccessAllowed(Thread, boolean)} and return true also for
 * multi-threaded accesses. Initialization actions for multi-threaded access can be performed by
 * overriding {@link #initializeMultiThreading(Object)}. Threads are
 * {@link #initializeThread(Object, Thread) initialized} and {@link #disposeContext(Object)
 * disposed} before and after use with a context. Languages may
 * {@link Env#newTruffleThreadBuilder(Runnable) create} new threads if the environment
 * {@link Env#isCreateThreadAllowed() allows} it.
 *
 *
...
public abstract class TruffleLanguage
https://github.com/oracle/graal/blob/master/truffle/src/com.oracle.truffle.api/src/com/oracle/truffle/api/TruffleLanguage.java`
Language implementation in graal-js doesn't override this value, so concurrent access throws.
It's possible to either fork/hard-code override this implementation, or to register a new version of js language which allows multi-threaded access, but doing so isn't supported and may introduce additional concurrency issues because the js language spec i

> can i change com.oracle.truffle.api.LanguageAccessor.LanguageImpl#isThreadAccessAllowed(com.oracle.truffle.api.TruffleLanguage.Env, java.lang.Thread, boolean) method for return always true? is there any example code, that fails after changing isThreadAccessAllowed method?

If you do, all support from our side is off. We don't give any guarantees what works if you change that. While you should be able to secure your own classes by proper synchronization, problems might occur in core classes like JavaScript's Object model (as stated above already).

So yes, that might work for some cases, but you will eventually run into typical multithreading problems like lost updates, corrupted objects, potentially even deadlocks. Again: this is a model we neither endorse nor support. You have been warned. The models we support have been quoted above.

see also
The right body to address this criticism to is the ECMAScript TC39, in charge of the ECMAScript/JavaScript specification. JavaScript, by design, is specified with single-threaded evaluation semantics. Unlike other languages, it is NOT designed to allow full multi-threading. There are some models still possible (as linked above).

https://github.com/oracle/graaljs/issues/481

@ericdriggs cc @joelpramos I hope I've figured out a reasonable solution. here we are discussing JS functions:

we avoid the lock by default, which is great
when we detect that the JS function originated in another scenario, we re-hydrate it, and avoid the lock again
since re-hydrating will not work when you do function "gymnastics" or refer to other functions in your function (see pic below) we introduce a karate.wrapFunction() helper. this will lock across all threads, so using this is at your own risk and you should try to use Java instead

would be great if you build locally and test

@eugeniooliveira would you be able to build locally and check if this solves the problem you reported here: https://stackoverflow.com/q/76284686/143475

another related conversation and fix attempt in the past: https://github.com/karatelabs/karate/issues/2222

@ptrthomas
It seems that what you are saying is that functions will need to use karate.wrapFunction to see performance improvements.
This doesn't seem like it's directly addressing the concurrency performance penalty if it requires code refactoring.

@ericdriggs no, actually most functions will NOT need karate.wrapFunction(). to clarify, you need to use karate.wrapFunction() only in cases where you depend on a JS function (variable) within a JS function body. who knows, you may need zero refactoring

1.4.1 released

@ericdriggs @joelpramos FYI about our intent to create a lightweight JS engine from scratch to replace Graal: https://twitter.com/ptrthomas/status/1775754727700996381
can't wait to get rid of 60MB of the JARs and get the exact behavior we want

Bravo, bravo, bravissimo!


Add filtering to /cards and /generate

?type
?name
Query params to render a subset of all cards. Would be handy for developing templates, or for generating one-offs.

Added filter syntax to /cards, which could be piped through to calls to Generator as well


Copying selected area to clipboard -- doesn't copy into the system clipboard (cannot paste outside of the VTM).

Both of these copy text into the internal clipboard.
However, there is no way to copy the text to any program outside of the vtm.

LeftDrag + RightClick to select and copy text to internal clipboard
Ctrl+MiddleDrag to select area and copy text to internal clipboard

Perhaps the copied text cold be put into the system clipboard as well.

The copied fragment is transferred to the system clipboard using the OSC 52 VT-command. Perhaps the terminal in which you run vtm does not support OSC 52, or this feature is disabled.

In this case, there is no option for this terminal.

Any terminal using VTE will have issues (since it looks like OSC 52 support was rejected due to security concerns).

We've discussed this a bit here https://github.com/netxs-group/vtm/issues/149#issuecomment-1105633359


App closes right after log in on Mac

Downloaded multiple previous versions of app and restarted but none of the versions going back to 7_4_52 have worked.
I've also tried the app via the website instead of Apple store with no luck.
No luck with restarts either.
Report.txt

Please write to<EMAIL_ADDRESS>and let us know what email you are using for your account so we can try to replicate this issue. Also mention that the data is for Indrek so it is forwarded to me.

Same issue case/640839

@aguerilla I've made some changes and built a new version. I would appreciate if you could test it out and let me know if these changes fixed the issue.
version 7.4.120

I've tried this new version and the old one.  The app is saying I no longer
have access to my workspace and I need to log in.  When I click on login to
toggl it opens a chrome page which is already logged in but the app does
not work.
On Fri, Feb 9, 2018 at 6:09 AM, Indrek V<EMAIL_ADDRESS>wrote:

@aguerilla https://github.com/aguerilla I've made some changes and
built a new version. I would appreciate if you could test it out and let me
know if these changes fixed the issue.
version 7.4.120
https://github.com/toggl/toggldesktop/releases/download/v7.4.120/TogglDesktop-7_4_120.dmg
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/toggl/toggldesktop/issues/2390#issuecomment-364429160,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Aij3yd0fRb6p7je8lF5H9likgLgYHv70ks5tTENugaJpZM4R9EOX
.

Thank you for the feedback. This helped me reproduce the issue reliably and fix it. As a last request can you confirm that this issue is fixed in the latest build 74.121

Lates build 7.4.122

.122 Works - thank you!
On Fri, Feb 9, 2018 at 1:54 PM, Indrek V<EMAIL_ADDRESS>wrote:

Lates build 7.4.122
https://github.com/toggl/toggldesktop/releases/download/v7.4.122/TogglDesktop-7_4_122.dmg
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/toggl/toggldesktop/issues/2390#issuecomment-364563480,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Aij3yS6-eK0hoeIId7FJjc_fklFFsQblks5tTLCEgaJpZM4R9EOX
.


Connecting multiple pre-exising databases via binds

Hi. I'm new to flask-sqlalchemy. I have multiple pre-existing mysql databases (for this example, two is enough). I have created a minimal example of what I'm trying to do below. I'm able to successful connect to one database using SQLALCHEMY_DATABASE_URI. For the second database, I'm trying to use SQLALCHEMY_BINDS to connect to the other database, but i am unable to access it. I've been unable to find an example that uses binding with pre-existing databases. Any help would be appreciated.
from flask import Flask
from flask_sqlalchemy import SQLAlchemy

app = Flask(__name__)

# db1 - works ok.
app.config['SQLALCHEMY_DATABASE_URI'] = 'mysql://user:password@localhost/SiPMCalibration'

# db2 - not working.
app.config['SQLALCHEMY_BINDS'] = {
    'db2': 'mysql://user:password@localhost/Run8Chan'
}

db = SQLAlchemy(app)
db.Model.metadata.reflect(db.engine)

# Setup the model for the pre-existing table.
class sipm_calibration(db.Model):
	__table__ = db.Model.metadata.tables['Calibration']

# Some code to retrive the most recent 100 entries and print their headers (i.e keys)
query = db.session.query(sipm_calibration).order_by(sipm_calibration.ID.desc()).limit(100)
print db.session.execute(query).keys() # Works fine.

#---------------------
# All ok so far - try again for the second database via binding.
class run_entry(db.Model):
    __bind_key__ = 'db2'
    __table__ = db.Model.metadata.tables['Runs']

query = db.session.query(run_entry).order_by(run_entry.ID.desc()).limit(100)
print db.session.execute(query).keys()

The actual problem is when looking for the 'Runs' database table at line:
__table__ = db.Model.metadata.tables['Runs']

Please use Stack Overflow for questions about your own code. This tracker is for issues with Flask-SQLAlchemy itself.

@daniel-saunders Have you resolved the problem? I voted that that was caused by Flask-SQLarchemy buggy implementation


Active/Inactive functionality for projects

Issue #581
Description
In ProjectPage the user should be able to see what projects are active and inactive. Also, be able to change the status of the project to inactive when editing the project information.

Update
Inactive projects now are being displayed in the ProjectPage.

Update
Active-Inactive switch when editing a project.


API

API and storage: Django
Search Engine: Whoosh
django-web3-auth

@Cali93 please assign me on this. I can't seem to assign myself.


Close the phantomjs_logger when the driver is quit

Poltergeist currently leaks open file descriptors.  This presents a problem when a single ruby process instantiates multiple capybara sessions and will eventually lead to OOM errors if hundreds/thousands of these are left open.  This commit calls #close on phantomjs_logger when the driver is quit.

Is this the reason setting the logger to Logger.new(dev/null) can cause timeouts?

@Deseao it may be related, but I have not encountered that specific behavior.  In my situation I open up thousands of new Capybara sessions.  Without this patch, each one of those sessions leaks an open file descriptor that eventually leads to "too many open files" and OOM errors on my server.
Try applying this patch and let me know if it eliminates the timeouts that you currently observe.

My concern with this is that the logger can be passed in as an option and I'm not sure closing a logger that was passed in is really the drivers responsibility, or a good idea.

since you pass Poltergeist a open IO object, it shouldn't be responsible for closing it.  You should do this in your own cleanup.

Closing this since it really is the users responsibility to close an IO object they open and pass in as phantomjs_logger, not Poltergeists


chore(docs): fix link to specification and adrs on homepage

@all-contributors add @cgarvis for docs


test delete after

I want to merge this change because...

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations

Docs

[ ] Link to documentation:

Pull Request Checklist

[ ] Privileged queries and mutations are either absent or guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migrations are either absent or optimized for zero downtime
[ ] The changes are covered by test cases
[ ] All new fields/inputs/mutations have proper labels added (ADDED_IN_X, PREVIEW_FEATURE, etc.)
[ ] All migrations have proper dependencies
[ ] All indexes are added concurrently in migrations
[ ] All RunSql and RunPython migrations have revert option defined

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Issue in machine_based_reading_order_integration branch

Hi,
I was looking at your branch regarding the computation of region ordering by neural network and I think I noticed a possible issue that I want to report you. Specifically, I tried the code on an image that has the following characteristics: in the center there is a large image going left to right and there are two columns broken from this image. Therefore, there are 4 paragraphs and one image.
The new sorting you want to implement does not read the paragraphs in a columnar way, but first reads the ones at the top of the image and then the ones at the bottom of the image from left to right. On the other hand, the previous sorting read them correctly. This seems to me to be an issue whenever an image is present.
If you want, I can share with you the image in issue, even though the language of the text is Italian and you might still not understand why it continues in this way by looking at the text.
I assume that the new network does not take into account the presence of images and therefore seeing paragraphs far apart does not understand that they should be read vertically as there is an aesthetic break and not first looking at the upper cluster and then at the lower cluster because of a contextual break.
I don't know if I misunderstood or if it is an intended behavior, but just in case it is not, it introduces this problem and I wanted to flag it for correction.
Apart from that, the new ordering is fantastic and when there are no pictures it is clearly superior to the previous one. Well done! :100:

Hi, I was looking at your branch regarding the computation of region ordering by neural network and I think I noticed a possible issue that I want to report you. Specifically, I tried the code on an image that has the following characteristics: in the center there is a large image going left to right and there are two columns broken from this image. Therefore, there are 4 paragraphs and one image.
The new sorting you want to implement does not read the paragraphs in a columnar way, but first reads the ones at the top of the image and then the ones at the bottom of the image from left to right. On the other hand, the previous sorting read them correctly. This seems to me to be an issue whenever an image is present. If you want, I can share with you the image in issue, even though the language of the text is Italian and you might still not understand why it continues in this way by looking at the text.
I assume that the new network does not take into account the presence of images and therefore seeing paragraphs far apart does not understand that they should be read vertically as there is an aesthetic break and not first looking at the upper cluster and then at the lower cluster because of a contextual break.
I don't know if I misunderstood or if it is an intended behavior, but just in case it is not, it introduces this problem and I wanted to flag it for correction.
Apart from that, the new ordering is fantastic and when there are no pictures it is clearly superior to the previous one. Well done! 💯

Thank you for taking the time to test the new model. As you're aware, machine-based reading order detection relies on ground truth (GT) for training, unlike heuristic methods. As you correctly pointed out, the machine-based approach doesn't perform well for certain document layouts because these layouts aren't represented in the training ground truth data. Other issues may also arise. For instance, newspapers with multiple articles where the articles can be read in any random order (although the text regions within articles have a unique reading order) are not covered in our ground truth dataset. This tool represents our initial attempt at a machine-based model for reading order, and we aim to enhance it in terms of both ground truth data and model structure.


[WIP] Improve config package

Related to https://github.com/mesg-foundation/core/pull/406
Closes https://github.com/mesg-foundation/core/issues/290
Stuck because of WIP PR of @antho1404 on using Docker Volume instead of Bind.

Closing in favor of a new PR that is coming soon!


JSX Spec has been updated (Fragment syntax)

The JSX spec has been updated to support Fragments, which are a shorthand syntax for using a specific opaque class from the React package. Spec PR is at https://github.com/facebook/jsx/pull/93.
Fragments are written by completely empty tags (only whitespace is allowed between < and >), and look like <>{'child1'}{'child2'}{'child3'}</>. This is not written down in the PR's text itself as it is only an AST update, but according to https://github.com/facebook/jsx/pull/93#issuecomment-333220513 it should desugar to <React.Fragment>{'child1'}{'child2'}{'child3'}</React.Fragment>.
The intent is to make returning multiple elements from a component more ergonomic -- instead of returning an array where each child needs to be keyed, return a fragment that preserves the optional key reconciling behavior.

Thanks for actually providing an explanation @Kovensky! I'll note that the author also elaborated here as well.

Just wanted to point out that since comments are treated as whitespace in Javascript, they're also allowed between < and >. For example, the following is valid:
< /*
 I'm a multiline comment
*/
>
</>

Sounds good. A few questions:

What's the emit under --jsx react ? React.createElement(React.Fragment, ...) ?
Under --jsx preserve, should we exactly preserve <>, or emit <React.Fragment> ?
Confirming that <> is not allowed to have any attributes

@RyanCavanaugh I think I can answer a few of those:

What's the emit under --jsx react ? React.createElement(React.Fragment, ...) ?

Yup.

Confirming that <> is not allowed to have any attributes

Yup.

Preserve <> would be best; but would be incompatible with tooling that has not yet been updated to support it. Emitting <React.Fragment> would be backwards-compatible but is not really preserving JSX, is it? :)
Maybe --jsx preserve-jsx1 (or just --jsx jsx1) for converting to <React.Fragment>, with --jsx preserve preserving the input as <>.

I think the EDIT above is the key point. Let's stick with <> for preserve emit.

Would a --jsxFragmentFactory option be needed as well for keeping compatibility with alternative JSX libraries?

Referencing https://github.com/facebook/jsx/pull/94 here so I don't forget about it. :)


RAG: Question Answering using Gemma, Elasticsearch & langchain

This is Ashish from Elastic. I'm interested in sharing a notebook that showcases RAG implementation using Elasticsearch. The notebook will illustrate how we generate vectors using Elastic's ELSER model and retrieve semantic results. We'll be utilizing Gemma for contextual question answering.

Hi Ashish! Feel free to add your notebook.


pattern \w cannot match Number?

when I used \w, it  can match just letter but not number or underline

http://jsfiddle.net/5um0mjta/5/
I can match number and underline.
Is there any misunderstanding ?

"\w",I wrote as "\w",thanks a lot @vip30


To be able to deactivate or activate the lua stealer at will

the title is quite explicit, it would be convenient to be able to sometimes disable the lua stealer via a command in the external console, personally I join a lot of server and it takes space on my disk

Note this is coming with the gui. I can make an option for the console with it as well tho

Also probably want a general "configs" file which will unify and be a third option for this in the autorun dir as a .toml file

Note this is coming with the gui. I can make an option for the console with it as well tho

it would be really nice to be able to adjust it in the external console


exception 'Zend\Http\Exception\InvalidArgumentException' with message 'Invalid URI passed as string' in vendor/Zend/library/Zend/Http/Request.php:176

This is just FYI, you can delete this if you like.
While running tests with http client (Behat/Mink), i got this error, when browsing to urls which contain a "#".
Filed a bug here: http://framework.zend.com/issues/browse/ZF2-69

Closing this ticket as the problem is the the upstream dependency.


Use correct preprocessor macro for Mac Catalyst

This was introduced in #7719 to fix a warning that was generated when using Remote Config on Catalyst, however, the PR was not using the correct preprocessor macro for Mac Catalyst, as defined in TargetConditionals.h
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion

Read the contribution guidelines (CONTRIBUTING.md).
If this has been discussed in an issue, make sure to link to the issue here.
If not, go file an issue about this before creating a pull request to discuss.

Testing

Make sure all existing tests in the repository pass after your change.
If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

At this time we cannot accept changes that affect the public API.  If you'd like to help
us make Firebase APIs better, please propose your change in a feature request so that we
can discuss it together.

@googlebot I signed it!

Looks like you may have signed the CLA with a different email than the one on your commits. Can you double check via the links in the description?
Note that by default the CLA website will use your Google account, but it looks like your commits are signed with a me.com email.

No worries. Understood.

I will close this PR and open a new one. Unfortunately it doesn't seem like I can to sign the CLA with a non-google email. Would be easier to keep things consistent with my company email anyway.


Add load_table array support for columnar method

this PR:

add load_table array support for columnar method
fix tests for load_table columnar method
include @jp-harvey load_table refactoring https://github.com/omnisci/pymapd/compare/master...jp-harvey:array-support?expand=1

it is ready for review. thanks!

thanks for the feedback @jp-harvey !
I will work on that. also I will improve the test to add the cases you commented. thanks!!

@jp-harvey I fixed some issues and add more tests.
I am still working to fix some issues.
just checking, for fixed length, ColumnDetails doesn't have this information, so probably it should be treat in follow up PR, is that right?

locally the tests for nullable cases worked (waiting for CI now).
probably would be good in a future do a refactoring in this code.

@jp-harvey it is ready again for review ... let me know if I can add any other case for the tests

@xmnlab I can't actually add another review for some reason. Looks pretty good, everything has been sorted out from what I can see except empty arrays not being inserted when there's only one column:
data = [
    {'ary': [2,3,4]},
    {'ary': [4444]},
    {'ary': []},
    {'ary': None},
    {'ary': [2,3,4]},
    ]

results in:
ary
2,3,4
4444
null
2,3,4

The [] values are not being inserted as empty arrays, there should be five rows not four.

mm interesting .. because there is a test for empty array: https://github.com/omnisci/pymapd/pull/311/files#diff-c518af4aa4697fe7c2932799f1655f53R159
could you share the code you used?

@jp-harvey
I tested it in a jupyter notebook .. and it worked: https://github.com/Quansight/ivan-sandbox/blob/master/pymapd/load-table-array-columnar.ipynb
if you could provide a complete example that is failing, I can work on that :)

This is the DDL
CREATE TABLE arraytest1 (
  ary INTEGER[]);

And this is the code:
import pymapd
import pandas as pd
import os

username = os.environ.get('username', 'admin')
password = os.environ.get('password', 'HyperInteractive')

con = pymapd.connect(user=username, password=password, dbname='omnisci', host='localhost', port=6278, protocol='http')

tablename = 'arraytest1'

data = [
    {'ary': [2,3,4]},
    {'ary': [4444]},
    {'ary': []},
    {'ary': None},
    {'ary': [2,3,4]},
    ]

df = pd.DataFrame(data)
con.load_table_columnar(tablename, df)

@jp-harvey ... it worked here ... as you can see in the test 4
what could be the reason for this difference?
currently I am using omniscidb version '5.2.0dev-20200329-cecceef8da'
and I am using connection protocol default (binary)

what is the version of omniscidb you are using?

what is the version of omniscidb you are using?

I'm using 5.2.1.

@jp-harvey I added some tests to test_integration that run load_table and check the result. it looks like it is working well :)

Tested on our open source and cannot replicate previous issue, must be something specific to my local OmniSci install.

sounds good. I will open a new PR that. also I will create an issue for that. thanks @andrewseidl

@andrewseidl is it ready to be merged? let me know if I am missing anything for this PR :)


Unable to scroll in the function query editor

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
When trying to edit a Function query, the code editor doesn't let a user scroll above line 7:
https://user-images.githubusercontent.com/19550456/185739578-7ed6ee56-d559-4588-a9de-b8664bf9cfcf.mov
Expected behavior 🤔
The scrollbar should let the user scroll to the top
Steps to reproduce 🕹
Steps:

Navigate to https://master--toolpad.mui.com/_toolpad/app/cl1on1bd80041a1pdrrfdt0rq/editor/pages/cl6ysktjz00023b6g8xkizxr8
Click on "query10"
Try scrolling the code in the editor

Context 🔦
No response
Your environment 🌎
No response

This has been solved in https://github.com/mui/mui-toolpad/pull/811 as I copied the layout and it suffered from the same problem.


Potential problems for autoloading and windows servers

There are around few reports that make me think there are issues with autoloading and windows servers.
At the moment I can't test on win, so if anyone can, it would be interesting to check this:
http://www.elkarte.net/community/index.php?topic=3922.0

what to test?

hmm... basically if the BBCode works.

it does, all I tried was the autolink.
On Wed, Sep 7, 2016 at 1:09 AM, emanuele45<EMAIL_ADDRESS>wrote:

hmm... basically if the BBCode works.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/elkarte/Elkarte/issues/2672#issuecomment-245207011,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAaWtyfv9k-YLDo5es2fQZJKJqEUeelqks5qnnEfgaJpZM4J1riE
.

Fair enough. :+1:


[OTHER] Login with google button style is odd

What would you like to share or ask?
I would like to improve the design of login with google button.

Checklist

[X] I have checked the existing issues.
[X] I have read the Code Of Conduct
[X] The changes don't break the code
[X] Please attach the screenshots and video of the development work once it is done

Please assign me this issue under gssoc-ext and hactoberfest-accepted.


optimize namespace more operation button UI

Coverage decreased (-0.05%) to 49.834% when pulling 9e1824129429261f7051ea293c4ccf3b957e53d6 on lepdou:modify_app_info into d5a9c5fedf3e751d2598e7360133299cf553fc14 on ctripcorp:master.


Implement server-side form validation feedback to React

Acceptance criteria

Form-level error messages generated by the server are displayed after a react form is submitted
Field-specific error messages generated by the server are displayed after a react form is submitted

Tasks

[x] Setup server side validation to work with Form schema
[x] Setup Message box component to display errors returned by the schema

Details
We've made this possible through Form->setValidationResponseCallback() on the server, but we need to communicate any server-side validation errors back to the client. This could be scoped to a field (highlight with error state and message), or scoped to the form (add message to top of form, or provide status message).
See https://github.com/silverstripe/silverstripe-framework/issues/5523 for client-side validation

Pull requests made
https://github.com/silverstripe/silverstripe-framework/pull/6205
https://github.com/silverstripe/silverstripe-asset-admin/pull/292

Re-updated based on feedback.

I've switch to the use of throwing a submission error, semantically incorrect though easier to implement than using a separate redux store for messages which is what would be needed.
Ref: https://github.com/erikras/redux-form/issues/94#issuecomment-143398399


Optimise import config file from CC

Imported wallet from cc config should skip registration for that particular vault. Handle the red dot notifications accordingly.

Closing as outdated


[WIP]: Adding a job that checks the PR and commit formats.

This job will make sure that:
* All commits in a PR were squashed to a single commit
* The PR title and commit title are identical
* the PR description and commit message are identical

Signed-off-by: Yoni Bettan<EMAIL_ADDRESS>

/cc @qbarrand
/cc @yevgeny-shnaidman
/cc @enriquebelarte

@ybettan why do we need the PR description and commit message to be identical? why is it a hard requirement?

@yevgeny-shnaidman I think that the commit message should be very descriptive and should include all the info required for understanding the code change.
By enforcing identical commit message and PR description, the reviewer of the PR can just look at the PR description without the need of also checking the commit message inside the PR in order to make sure the commit message wasn't neglected.
In addition, you can add additional info such as reviewers or any other text that is not relevant for describing the change by adding --- at the end of the PR description and all the text after that will be ignored by the API and doesn't have to match the commit message.

/hold
Hold while we compare those requirements with what the Kubernetes contributor cheat sheet recommends.

As agreed, this PR is going to be split into 2 PRs:

One PR to add a job to enforce a single commit per PR
One PR to enforce the sync between the PR description and the commit message

Both PR will start as optional jobs and the second one might be removed after some time if it causes more issues than benefits.

/ok-to-test

/unhold
/lgtm
/approved

/approve


Upgrade guide from v3 to v4

Describe the feature request
Is your feature request related to a problem?
I have a big project using this library, but upgrading from v3 to v4 seems impossible,
specially without documentation, I can't find anything.
current asp.net example is for v3
I'm stuck with v3
Please describe.
I just need a guide to upgrade.
Which project is your feature request related to?
I'm using ASP.net core 6
Describe the solution you'd like
a Wiki ?  yes
Describe alternatives you've considered
Additional context
Add any other context or screenshots about the feature request here.

Please check:

Release notes from version 4 (https://www.nuget.org/packages/MQTTnet/<IP_ADDRESS>#release-body-tab)
Upgrade guide in Wiki (https://github.com/dotnet/MQTTnet/wiki/Upgrading-guide)
Samples for version 4 (https://github.com/dotnet/MQTTnet/tree/master/Samples)


Will support for openvino runtime be added?

Hello @Sing303,
It can be added as a new package (e.g. Whisper.net.Runtime.OpenVINO ) but I don't have an ETA for it.

If someone want to create the build scripts for GitHub actions, that would be awesome and will gladly accept PRs.


Support user selection of Electron client certificates

opensphere-electron PR: https://github.com/ngageoint/opensphere-electron/pull/17

Add an Electron plugin to handle requests for client certificates.
Add an Electron preload script to establish IPC with the main process.
Transform confirm.js to ES6 so launchConfirm can be imported cleanly. The transform was done with opensphere-jscodeshift, then launchConfirm added as an export. os.ui.window.launchConfirm was added to the shim for backward compatibility, and deprecated.
Replace all deprecated references as a result of the transform.
Allow passing the window parent to launchConfirm. The Electron cert prompt uses the app container (#ng-app), because requests made before the default window container is available will not display a prompt.

Looks great!  Awesome rewrite with the ConfirmUI.


Add user defined descriptions for each experiment

It would be helpful for users to be able to include a short description of their datasets that would be visible somewhere in the tool.
One way I can envision this working is to have a flag in configure_dms_viz where users provide a short description of their dataset – either as markdown or as a plain string – and this would populate an information ( ⓘ ) icon next to the dataset dropdown.

I added a little button next to the Dataset selection menu that shows a short description of the dataset that you're looking at.
In the future I might add a more comprehensive version of this that would show up below the plot and allow markdown syntax for styling.


samba: 4.12.3 -> 4.12.5

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/samba/versions.
meta.description for samba is: "The standard Windows interoperability suite of programs for Linux and Unix"
meta.homepage for samba is: "https://www.samba.org"
meta.changelog for samba is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 4.12.5 with grep in /nix/store/sq4rbcrzrwr2w8afxs6a7hrkl4fgk07w-samba-4.12.5

directory tree listing: https://gist.github.com/19e18e3d3e460ceaa2475d3d0429601d

du listing: https://gist.github.com/efb1e6c2e50ffceacefa60b841951af6

Rebuild report (if merged into master) (click to expand)

533 total rebuild path(s)

179 package rebuild(s)

179 x86_64-linux rebuild(s)
170 i686-linux rebuild(s)
25 x86_64-darwin rebuild(s)
159 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
adapta-gtk-theme
almanah
atom
atom-beta
autofs5
calls
chrome-gnome-shell
cinnamon.cinnamon-control-center
clementine
clementineUnfree
deepin.dde-file-manager
deepin.startdde
deja-dup
dropbox-cli
elementary-planner
elisa
empathy
enum4linux
evolution-data-server
far2l
feedreader
ffmpeg-full
folks
gfbgraph
gnome-online-accounts
gnome-photos
gnome-recipes
gnome2.gvfs
gnome3.bijiben
gnome3.cheese
gnome3.empathy
gnome3.evolution
gnome3.evolution-data-server
gnome3.evolution_data_server
gnome3.file-roller
gnome3.folks
gnome3.geary
gnome3.gfbgraph
gnome3.gnome-applets
gnome3.gnome-books
gnome3.gnome-boxes
gnome3.gnome-calendar
gnome3.gnome-contacts
gnome3.gnome-control-center
gnome3.gnome-documents
gnome3.gnome-flashback
gnome3.gnome-initial-setup
gnome3.gnome-maps
gnome3.gnome-music
gnome3.gnome-notes

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/sq4rbcrzrwr2w8afxs6a7hrkl4fgk07w-samba-4.12.5 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A samba https://github.com/r-ryantm/nixpkgs/archive/5de4c73f41c85f33f65c81846f808654a23d4f58.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/sq4rbcrzrwr2w8afxs6a7hrkl4fgk07w-samba-4.12.5
ls -la /nix/store/sq4rbcrzrwr2w8afxs6a7hrkl4fgk07w-samba-4.12.5/bin

Security vulnerability report

Security report (click to expand)

CVEs resolved by this update:
none
CVEs introduced by this update:
none
CVEs present in both versions:

CVE-2018-1050
CVE-2018-1057

Pre-merge build results
NixPkgs review skipped

Maintainer pings
cc @aneeshusa for testing.

Fixes:

https://nvd.nist.gov/vuln/detail/CVE-2020-10730
https://nvd.nist.gov/vuln/detail/CVE-2020-10745
https://nvd.nist.gov/vuln/detail/CVE-2020-10760
https://nvd.nist.gov/vuln/detail/CVE-2020-14303

@GrahamcOfBorg test samba


Window covering - tilt angle

Hi,
Is it possible to tilt angle steering?
I have found in HAP specification below characteristics.
Current Horizontal Tilt Angle
Target Horizontal Tilt Angle

Hi,
Yes, you can change it in the settings of your window covering in Home app.
To make sure it's available for your device can you please log at https://dev.duboc.pro/tools/setup
Thanks

Hi,
Thanks for prompt answer!
I am not sure if I was clear enough. I want to use RPi, connected relay board and your homebridge gpio device plugin to steer roller shutter in my home.
I cannot see this in the settings in Home app so I think it should be add into plugin and configurable in config file. Or?

Oups, yes I mix two plugins :-). Sorry. How tilt angle could be modified electrically ? 1 pin or 2 needed ?

Angle tilt control can base on time of motor operating so the same pins in use.
In the roller shutter is only one motor to operate both: rolling and tilt angle. If you roll down shutter then tilt is 90 degrees. when roll up -90 degrees. so to get 0 (open shutters - horizontal slats position) you need to go back ~1s in opposite direction and this time should be adjustable in config file.
I don't know if you can understand me but I can make short movie to show how it works with current driver. This driver is not supported by HomeKit so I am looking for another solution.


Fix typo causing "hasRangeMatch" to always be true

It should be set to false initially until a match is found. Because of this error, checkInsideThunkFunction will always think there is a range match, which could cause disastrous results.

Sorry for the delay on this.
We are wondering if you have functionally witnessed an example program where this line has caused problems.
We agree that the line is suspicious, as the value is always true.  But the method that contains this line, checkInsideThunkFunction, as well as the the method after it, checkInsideThunkJump, are also in question.  We don't know that these methods serve any purpose at this point.  They probably were helpful in setting trampoline and thunk functions, but there are separate analyzers that take care of this at this time.
If you look at the applyTo method above these two methods, you will see a sequence of four tests for function == null.  The first part of this follows.
	Function function = listing.getFunctionAt(address);
	if (function == null) {
		function = createFunction(program, address);
	}

After the above code block has been processed, looking at this code, we cannot fathom any situation where any of the follow-on processing could create a function where the above block could not.  In other words, we think the earlier two functions might now be useless.
Have you witnessed a situation where function is still null after the above snippet?  What we are interested in is what the circumstances were that caused this?  Was the address possibly at the location of an import data table value or was it in External memory?
Moreover, did the subsequent processing methods somehow produce a non-null function?
It will take some study to see if we can eliminate some of this logic, but your input would be helpful.

I am not aware of any specific circumstances which triggered this line. However, I will try to see if the mentioned functions continue to serve any meaningful purpose.

@ryanmkurtz Any update on this?

It looks like in your last update you mentioned looking into something, and we were just waiting for you to report back.

It looks like in your last update you mentioned looking into something, and we were just waiting for you to report back.

I have not been able to find any examples of this.

checkInsideThunkFunction is called when suspected thunk functions are checked to serve no other purpose but to branch to another function after some change has been applied to selected functions, so yes it is still used.

Ok, I guess it's ready for a @ghizard review.

We can see that the call to createFunction(program, address) can return null.  And we can see where the checkInsideThunkFunction(program, address) has the issue as noted.  So we can see where the creation of a thunk is always attempted inside the try/catch.
If we had had a real example to test against, we posit that Ghidra might produce better results in general with more recent thunk analyzers that kick off after PDB.   With such an example we could have done comparisons of the original bad code against your fixed code and that against a modification where both of these calls (checkInsideThunkJump() and checkInsideThunkFunction) are eliminated, allowing the standard thunk analyzers produce those possibly better results.
Since your fix is better than what is there and since this MSDIA-based analyzer's support is waning, we will accept your PR and just won't be able to make the determination of whether we could have done even better than this.  Not doing full testing of this, so fingers crossed that there are no bad side effects.


master-next: Temporary workaround for llvm r315852.

The change in llvm r315852 is causing an assertion failure for Swift.
I've notified the author of that change and am hoping for a fix. In the
meantime, here is a workaround. I'm doing this instead of reverting the
offending commit from swift-llvm's upstream-with-swift branch in anticipation
of a merge conflict from the hoped-for fix. I'll remove this workaround when
there is a real fix.
rdar://problem/35017353

The workaround caused some LLVM tests to fail, so I've reverted it: https://github.com/apple/swift-llvm/pull/67


feat(tutorial): complete step 2

Closes #
React Carbon tutorial step 2
Changelog
New
Step 2
Changed
Step 2
Removed
Nothing

No updates in 90 days. Closing.