Tensorflow GRU cell error when fetching activations with variable sequence length

I want to run a GRU cell on some time series data to cluster them according to the activations in the last layer. I made one small change to the GRU cell implementation
`def call(self, inputs, state, scope=None):
"""Gated recurrent unit (GRU) with nunits cells."""
with vs.variable_scope(scope or type(self).name):  # "GRUCell"
with vs.variable_scope("Gates"):  # Reset gate and update gate.
# We start with bias of 1.0 to not reset and not update.
r, u = array_ops.split(1, 2, linear([inputs, state], 2 * self._num_units, True, 1.0))
r, u = sigmoid(r), sigmoid(u)
with vs.variable_scope("Candidate"):
c = tanh(linear([inputs, r * state], self._num_units, True))
new_h = u * state + (1 - u) * c
store the activations, everything else is the same
self.activations = [r,u,c]
return new_h, new_h`
After this I concatenate the activations in the following manner before I return them in the script which calls this GRU cell
`@property
def activations(self):
return self._activations
@activations.setter
def activations(self, activations_array):
print "PRINT THIS"
concactivations = tf.concat(concat_dim=0, values=activations_array, name='concat_activations')
self._activations = tf.reshape(tensor=concactivations, shape=[-1], name='flatten_activations')
`
I invoke the GRU cell in the following manner
outputs, state = rnn.rnn(cell=cell, inputs=x, initial_state=initial_state, sequence_length=s)
Where s is an array of batch length with the number of timestamps in each element of the input batch.
And finally I fetch using
fetched = sess.run(fetches=cell.activations, feed_dict=feed_dict)
When executing I get the following error
Traceback (most recent call last): File "xxx.py", line 162, in fetched = sess.run(fetches=cell.activations, feed_dict=feed_dict) File "/xxx/local/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 315, in run return self._run(None, fetches, feed_dict) File "/xxx/local/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 511, in _run feed_dict_string) File "/xxx/local/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 564, in _do_run target_list) File "/xxx/local/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 588, in _do_call six.reraise(e_type, e_value, e_traceback) File "/xxx/local/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 571, in _do_call return fn(*args) File "/xxx/local/lib/python2.7/site-packages/tensorflow/python/client/session.py", line 555, in _run_fn
return tf_session.TF_Run(session, feed_dict, fetch_list, target_list) tensorflow.python.pywrap_tensorflow.StatusNotOK: Invalid argument: The tensor returned for RNN/cond_396/ClusterableGRUCell/flatten_activations:0 was not valid.
Can someone give an insight as to how to fetch the activations from a GRU cell at the last step, with passing variable length sequences? Thanks.

rnn() assumes your cell is not stateful.  What you want to do is probably concatenate your activations into the output and then split then off after reading all the outputs off the rnn call.

Thanks for your response. Actually this doesn't explain why I this code actually works if I pass sequence_length=None into rnn(). Can you explain that?

I would need to see all your code and a longer stack trace to answer your question fully. For now, avoid creating stateful RNNCells. Treat them like functions.


Make error responses more RESTy

I was torn on a couple of them, notably when the Mojang API fails you COULD do a 424 as defined in the WebDAV RFC but realistically there's nothing the client can change about what they're doing to make the call succeed. If it's down, it's unavailable, so 503.
Likewise if there's no Economy plugin, that's a "server misconfiguration" sort of, so I did 500 for that.
Also sprinkled in a bunch of 404's when things aren't found, and 400's when the client made a mistake, missed a parameter, things like that.

I like 424 for missing Vault more than 500
500 should be reserved for unhandled errors

@Scarsz OK I changed the 500 to a 424 for Vault, and updated a few others. Also added some basic format validation when passing UUIDs around


Error in text

The sentence "If the Format Property (XMLports) of the XMLport is set to Both, the XMLport can be used to import or export data. " is wrong. The correct property would be "Direction", not "Format".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7a711ef0-24b9-ac80-d8ef-9c4b9dcb3eef
Version Independent ID: 4294d897-9241-e583-f65b-092696809996
Content: Request Pages (XMLPorts) - Dynamics NAV
Content Source: dynamics-nav/Request-Pages--XMLPorts-.md
Product: dynamics-nav-2018
GitHub Login: @jswymer

The same goes for the sentence "If the Format Property (XMLports) is set to either Import or Export, then the Direction list box is not displayed on the request page."

Thanks for the feedback! The article has been fixed and an update will be published soon.


Broker should store also subscriptions with QoS 0

This is a port from the issue in mosca:
https://github.com/mcollina/mosca/issues/693
It should be adjusted accroding to MQTT spec here as well

@mitsos1os , can you check if it now works with my patch?

I haven't really dealt with aedes in general (still using mosca), but I believe this should be enough for a fix.
However patches should be also made to other aedes repositories like: aedes-persistence-level, aedes-persistence

Yes they should. Would you like to send PRs?

@mitsos1os This can be closed with the latest changes on aedes-persistence-mongodb. I don't think this should happen with other persistences. Feel free to reopen just in case.


Add single-paragraph high-level version notes

In both Install and Developers, add a single paragraph highlighting additional software that may be required to run or text yamale, and providing direction for further reader research. Specific install instructions are not provided.

All changes made, another typo (of mine) fixed. Should be good to go.

Looks great, thanks for the contributions.


no_lazy_load false yields Chef::Exceptions::FileNotFound on cookbook_file/remote_directory resources

Description
Using no_lazy_load false causes cookbook_file/remote_directory resources to fail on Chef 13.
Chef Version
chef-client --version
Chef: 13.0.113

Platform Version
macOS 10.12.4
Replication Case

Edit /etc/chef/client.rb and set no_lazy_load false
Run a cookbook thats uses a remote_directory resource. For instance:

# Cookbook: default.rb
rd = remote_directory '/tmp/rd_test' do
  source 'some/folder'
  owner 'root'
  group 0
  mode 0755
  purge true
  recursive true
  action :nothing
end

rd.run_action(:create)

Client Output
Recipe: rd_test::default
  * remote_directory[/tmp/rd_test] action create

    ================================================================================
    Error executing action `create` on resource 'remote_directory[/tmp/rd_test]'
    ================================================================================

    Chef::Exceptions::FileNotFound
    ------------------------------
    cookbook rd_test has no directory files/default/some/folder

    Cookbook Trace:
    ---------------
    /etc/chef/local-mode-cache/cache/cookbooks/rd_test/recipes/default.rb:11:in `from_file'

    Resource Declaration:
    ---------------------
    # In /etc/chef/local-mode-cache/cache/cookbooks/rd_test/recipes/default.rb

      1: rd = remote_directory '/tmp/rd_test' do
      2:   source 'some/folder'
      3:   owner 'root'
      4:   group 0
      5:   mode 0755
      6:   purge true
      7:   recursive true
      8:   action :nothing
      9: end
     10:

    Compiled Resource:
    ------------------
    # Declared in /etc/chef/local-mode-cache/cache/cookbooks/rd_test/recipes/default.rb:1:in `from_file'

    remote_directory("/tmp/rd_test") do
      action [:nothing]
      default_guard_interpreter :default
      path "/tmp/rd_test"
      recursive true
      source "some/folder"
      purge true
      files_backup 5
      files_owner nil
      files_group nil
      files_mode 420
      overwrite true
      declared_type :remote_directory
      cookbook_name "rd_test"
      recipe_name "default"
      owner "root"
      group 0
      mode "0755"
    end

    System Info:
    ------------
    chef_version=13.0.113
    platform=mac_os_x
    platform_version=10.12.4
    ruby=ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-darwin14]
    program_name=chef-client worker: ppid=48297;start=12:43:12;
    executable=/opt/chef/embedded/bin/chef-client

  ================================================================================
  Recipe Compile Error in /etc/chef/local-mode-cache/cache/cookbooks/rd_test/recipes/default.rb
  ================================================================================

  Chef::Exceptions::FileNotFound
  ------------------------------
  remote_directory[/tmp/rd_test] (rd_test::default line 1) had an error: Chef::Exceptions::FileNotFound: cookbook rd_test has no directory files/default/some/folder

  Cookbook Trace:
  ---------------
    /etc/chef/local-mode-cache/cache/cookbooks/rd_test/recipes/default.rb:11:in `from_file'

  Relevant File Content:
  ----------------------
  /etc/chef/local-mode-cache/cache/cookbooks/rd_test/recipes/default.rb:

    4:    group 0
    5:    mode 0755
    6:    purge true
    7:    recursive true
    8:    action :nothing
    9:  end
   10:
   11>> rd.run_action(:create)
   12:

  System Info:
  ------------
  chef_version=13.0.113
  platform=mac_os_x
  platform_version=10.12.4
  ruby=ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-darwin14]
  program_name=chef-client worker: ppid=48297;start=12:43:12;
  executable=/opt/chef/embedded/bin/chef-client

Stacktrace
https://gist.github.com/natewalck/c20efd4da2ce0566d542785ebe436233

This may be of particular interest to @jaymzh

@lamont-granquist - this looks like a pretty bad regression.
Also, I should have requested we flip this default in 13... damn.

@jaymzh it is bad but tempered by the fact that almost no one changes this flag (all my cookbooks explode without it so I can vaguely gauge usage based on how many of those big reports I get :)

yeah except @jaymzh uses it a ton.  it is just a 13.0 regression we need to fix...   we should probably see about adding a chef-zero integration test to the specs around it when we do so it doesn't fail without blowing up any unit tests again...

Yeah, I'm working my way through this one at the moment. Integration tests are definitely on the radar!


invalid templates by exporting storage accounts

One thing this article doesn't mention is that Azure itself creates these invalid templates. If you create a storage account and add blob containers, then export that resource to an ARM template and then try to import that template again (via Deploy custom template) you'll get a "Bad request" on Microsoft.Storage/storageAccounts/fileServices, saying :"XML specified is not syntactically valid."
See https://learn.microsoft.com/en-us/answers/questions/340510/arm-templates-storageaccounts-fileservices-error-s?page=1&orderby=Helpful&comment=answer-341458#newest-answer-comment for the error, which is still 100% relevant.
The folowing gives problems:
"properties": {
"protocolSettings": {
"smb": {}
},
"cors": {
"corsRules": []
}

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 2d40dfd0-5910-65bf-b9c4-c06a91937714
Version Independent ID: b900fcc3-fd62-4d9a-1abf-ee1b62ece58d
Content: Invalid template errors - Azure Resource Manager
Content Source: articles/azure-resource-manager/troubleshooting/error-invalid-template.md
Service: azure-resource-manager
Sub-service: troubleshooting
GitHub Login: @davidsmatlak
Microsoft Alias: davidsmatlak

@FerryMan-Coder
Thanks for your feedback! We will investigate and update as appropriate.
I've delegated this to @davidsmatlak , a content author, to review and share their valuable insights.

Thanks for the feedback. I'll do some tests and if necessary, update the article. I created an internal work item and will close this issue as a request to update documentation.
When a template is exported it's best to review and edit the code before the template is used to deploy resources. In general, empty properties should be removed from ARM templates. The article Use Azure portal to export a template has guidance about exporting templates from a resource group or resource. You can also use the ARM template test toolkit to check if a template uses recommended practices.

#please-close


Update MAINTAINERS.md

@matthyx we will hold a meeting to approve new/exiting maintainers in the next two weeks, then we will approve new maintainers


xlsx only first column values are getting returned

sent the file.

This is because "FieldCount" is based off the number of columns in the first row. You can use RowFieldCount when the file contains variable number of columns, to get the number of columns in the current row.

this in turns generates exception
System.ArgumentOutOfRangeException: 'Index was out of range. Must be non-negative and less than the size of the collection. Arg_ParamName_Name'

I think this is the same issue that was exibiting in xlsx. Should be fixed in 0.1.8-b0002: https://www.nuget.org/packages/Sylvan.Data.Excel/0.1.8-b0002

tried but not working same behaviour


website: reload redraws objects

when website is reloaded, sometimes the website is redrawn.

fix in 1f7bdc689fc4132c9e79e59f09e9943b849fa664


Evalauate return types for operation methods

The new delete functions return booleans, but we want them to throw descriptive errors on failure, rather than simply returning false.  We should consider replacing boolean with void as the return type.

This will be easier to accomplish when we have already resolved #59


Use a separate network error type when polling fails because of a network error

Currently when connection polling fails in WSAPoll/poll the library throws a generic std::runtime_error.
This happen in various cases including

When the client keeps an open connection to the PostgreSQL server and the server is restarted. This causes the server to close the connection on its side, so when the client tries to read from the socket it gets POLLHUP (0x0002) or when it tries to write to the socket it gets POLLHUP | POLLERR (0x0003).
When there is a network error, e.g. "no route to host", attempts to write to the socket cause POLLHUP | POLLERR (0x0003).

It makes sense to differentiate network errors like the above and internal errors caused by other reasons. For network errors some kind of retry mechanism could be used, while internal errors should probably cause program termination and/or a crash dump.
This pull request adds a separate network error type which is used when polling yields unexpected event flags, thus allowing differentiation between network error and internal errors.

Codecov Report
Base: 99.65% // Head: 99.65% // No change to project coverage :thumbsup:

Coverage data is based on head (72491b4) compared to base (eba92ef).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #67   +/-   ##
=======================================
  Coverage   99.65%   99.65%
=======================================
  Files          68       68
  Lines        2297     2297
=======================================
  Hits         2289     2289
  Misses          8        8

Impacted Files
Coverage Δ

src/lib/pq/connection.cpp
98.66% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


WIP: keystone uwsgi support

Alright, I have a concern about the # of processes running, whether or not we get enough workers for the API services, and I'm curious what all this changes in monitoring  / logging land, but I'm going to merge this in so we can work on the next steps.

Actually no, I'm not going to merge.  A quick peek looks like a few things are looking for keystone-all, such as the logs and the monitoring. We should update those along with this PR to keep the whole thing working when committed.

I've set the default number of workers to 5 using the variable in keystone-defaults. I've also addressed the logging/monitoring concerns.

LGTM


BFS Graph Traversal

Description
BFS Graph Traversal
Fixes #176
Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have created a helpful and easy to understand README.md
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

@kumarshobhit your file is empty what is this mke new PR i will close this

yes apologies for the error. I will make a new one


cant skip onboarding

there should be an option to skip onboarding

I know why would you want that? the app is useless?


leaderboard update: use the pool key hash as the pair points boost multiplier key

a few adjustments:

make this points boost multiplier per-pool-key, so choosing the most popular pool results in higher multiplier
increase the rate at which a pool reaches max 10x multiplier (around 60k total swaps now)
start from a multiplier of 0

this means new pools created on popular pairs start with a multiplier of 0
this solves the attack vector of creating a pool for a popular pair, doing swaps against it and then withdrawing the liquidity in the same transaction, thus earning points for fees while paying only the withdrawal fee

the leaderboard would look like so with the updates applied
https://gist.github.com/moodysalem/132601afdf359e5999e8b33426b9a869


MRG: rethink time axis and test

Drop time axis of length 1 in NIfTI.

This one ready for review.


Announce import plan to community for review

mailing list to hit:

[x] talk-us
[x] SF bay area mappers
[x] imports-us
[x] imports

@bdon @chtnha
Draft email for discussion here: https://gist.github.com/maning/260559d3f1532ff03f061a7d76185c32
Once I get your 👍 , I'll post to the above lists.

@maning I forked and edited the post for ya. Readability is now grade 5 level, which should be good for the list. :) Feel free to use / edit / comment
https://gist.github.com/talllguy/914b20373d4043fec799dee7b58bb68d

We should also periodically send progress updates to the mailing list


Tab 'leaking' though to SelectFieldSet

Hi,
first of all I would like to thank you for this amazing library. I know it is a fork of existing code, but still... :-)
I have been trying to get the following to work: a array, with in it a fieldselectset. This is (a simplyfied) test-JSON:
{   schema: {     Vragen: {       type: "tabarray",       items: {         type: "object",         title: "Vragen",         properties: {           Type: {             title: "Type antwoord:",             type: "string",             "enum": ["Decimalen", "Formule", "Financieel"]           },           Decimalen: {             type: "string",             title: "Decimalen"           },           Formule: {             type: "tabarrary",             items: {               type: "object",               title: "Formule",               properties: {                 Naam: {                   type: "string",                   title: "Naam"                 },                 Definitie: {                   type: "string",                   title: "Definitie"                 }               }             }           },           Financieel: {             type: "string",             title: "Financieel"           },           Tekst: {             type: "string",             title: "Tekst"           },           BerekeningC: {             type: "string",             title: "Berekening antwoord"           },           Feedback: {             type: "string",             title: "Feedback"           },           Lengte: {             type: "string",             title: "Lengte invoervlak",             "enum": ["input-mini", "input-small", "input-medium", "input-large", "input-xlarge", "input-xxlarge"]           }         }       }     }   },   form: [  {       type: "tabarray",       key: "Vragen",       items: [         {           type: "section",           legend: "{{idx}}.",           items: [             {               key: "Vragen[].Type",               type: "selectfieldset",               items: [                 {                   key: "Vragen[].Decimalen"                 }, {                   type: "tabarray",                   key: "Vragen[].Formule",                   items: [                     {                       type: "section",                       legend: "{{idx}}. {{value}}",                       items: [                         {                           key: "Vragen[].Formule[].Naam",                           valueInLegend: true                         }, {                           key: "Vragen[].Formule[].Definitie"                         }                       ]                     }                   ]                 }, {                   key: "Vragen[].Financieel",                   type: "hidden"                 }               ]             }           ]         }       ]     }   ] }
(If you throw this in the playground, it should work.)
This shows the issue: if you make at lest 2 elements in the array, if you select the second tab, it will "under water" always select the second choice in the fieldselectset. It will not show in the select box, but it will show the second fields associated with that selection. This of course, is wrong. (If you browse back and forth you will see it flipping back all the time.)
I have been spending some days trying to fix this now, but I think I lack JS-knowledge :-)
I can see what goes wrong (I think, anyway). The change of tab triggers this code:
var activate = function (element, container)  [line 178]
In there, the .find('> .active') will deactiveate all the children and active the X-th one. This includes the select-items in the select-box for the SelectFieldSet...
I've tried to remedie this by limiting the depth of the > find by doing this:
  var activate = function (element, container) {
      container
          .children('.tab-pane, .active')
          .removeClass('active');
      container
          .children().children('.tab-pane, .active')
          .removeClass('active');
      container
          .children().children().children('.tab-pane, .active')
          .removeClass('active');
      element.addClass('active');
  };

But that this is no solution...
Can you help me? I thought also it might be because the data-idx-tags are the same, but I am not sure how they might be involved...?
Thanks for any help you might be able to offer,
Paul

Fixed in the dev branch, please try the new code (line 205 update)

Brilliant! I can confirm this fixes the issue I saw. Thank you!


PackageInfo: Invalid constraint (PyYAML (>=5.1.*)) found in omegaconf-2.1.0 dependencies, skipping

Describe the bug
When installing omegaconf with poetry command poetry add omegaconf, the follogin warning is issued:
PackageInfo: Invalid constraint (PyYAML (>=5.1.*)) found in omegaconf-2.1.0 dependencies, skipping

To Reproduce
Just install the package in an empty environment.
Expected behavior
To correctly get and install the pyyaml dependency.
Additional context

[X] OmegaConf version: 2.1.0
[X] Python version: 3.8
[X] Operating system: Windows
[ ] Please provide a minimal repro

Why is this an invalid constraints? pip likes it just fine.

I'm not sure it is invalid, if with pip is ok I'll open an issue in poetry repo about it and let you know.

I didn't hear or see any reports about it causing issues for anyone else.
This seems in line with https://www.python.org/dev/peps/pep-0440/
In particular, release segment below:
Public version identifiers are separated into up to five segments:

Epoch segment: N!
Release segment: N(.N)*
Pre-release segment: {a|b|rc}N
Post-release segment: .postN
Development release segment: .devN

They say >=5.1.* is not a valid PEP440. (Issue: https://github.com/python-poetry/poetry/issues/4206 and linked issues)
In fact reading PEP440 I see that the * is accepted only with == or with != and not with >=; moreover ==5.1.* is equivalent to >=5.1.0 but >=5.1.* is invalid.
What do you think?

Thanks. Sounds fine.
Go ahead and send a PR fixing it to >=5.1 or >=5.1.0.

Opened PR #761

@omry Hi, I just started using OmegaConf and ran into this error. It appears to be fixed now. PR #761. Is there any chance of a new release soon? I'm very excited to be using OmegaConf because it's making my newest ML project awesome. However, this error prevents it from working in Google Colab.

@Jasha10, do you want to try to release 2.1.1 with this fix?

Sure, I'll give it a try!


how to count the total value of a column, only for the rows which are visible

I have pagination for the ng2-smart-table so I want to show the total value of only 10 rows which are visible currently.

You can access the visible data using ViewChild:
Template:
<ng2-smart-table #report ...> </ng2-smart-table>

Component:
  @ViewChild('report', { static: false }) table;

  ngAfterViewInit(): void {
    this.table.grid.source.onChangedSource.subscribe((...args) => {
      console.log(this.smartTableView.grid.dataSet.data);
    });
  }


Create order details page

This is the page where it shows all job details, status, as well as a chat box for connecting with the customer/printer

For reference, the latest mockup which I will be implementing


Build Error

How can we reproduce this bug?
When running npm run build I get an error. The npm start still works fine.
What did you expect to happen?
Building (inlining) the email and loading in the browser.
What happened instead?

Unhandled rejection Error: ENOENT: no such file or directory, open '/Users/e159407/Sites/Inbox/dist/foundation-templates/css/app.css'
at Error (native)
[11:04:30] The following tasks did not complete: default, build, inline
[11:04:30] Did you forget to signal async completion?

What email clients does this happen in?
N/A

I realized what the error was with this. I have nested folders in /pages for different email categories. Going to either pipe the css to those sub CSS folders in dist or just prefix the page html files and not use subfolders.


Implement Generative Art Tool using Neural Networks

Develop a Python script using TensorFlow or Keras to generate unique artwork using neural networks. The tool should allow users to customize art styles, colors, and patterns.

Hey @king04aman ! Can u assign this task to me? I would like to work with that.

Sure @Iconic-Aman! Assigned, Happy Coding 🎉


Crash When attempting to load on server(Jenkins447)

The following paste is my crash report log.
https://pastebin.com/XjcS2GgN
When I try to load the mod in a server, it gives a crash. With singleplayer, it loads fine. In that instance of the crash report, I was testing it with only itself and forge.

Fixed!


Install script touch ups

@baptistecolin I've tried this script on a clean Docker image and it doesn't get past rustc.
docker run -i -t ubuntu /bin/bash
apt-get update
apt-get install curl
curl https://raw.githubusercontent.com/danielpclark/abrute/master/install.sh | bash

Output:
bash: line 3: rustc: command not found
bash: line 16: [: ==: unary operator expected

Maybe using which rustc to see if that produces a value would be better?

Would it be okay with you if I assign this to you?  I can label it Hacktoberfest for you if you're trying to get the free shirt.

oops, I have to fix that indeed.
I will take a look at this shortly.

I made a PR to fix this : #10


Fix typo

Objective
This PR fixes a typo in inferno-create-element docs.
Closes Issue
It closes Issue #570

Thank you.


Update boost windows documentation section to add toolset and Cmake notes

Customer request:

Update Boost Toolset
Update CMake FindBoost behavior

Updates:

Add a toolset name what was used at the building boost pre-cache artifact.
Add  CMake FindBoost section to describe new function behavior  from Boost 1.70.0

Example output:
Boost
1.69.0 [msvc-14.1]
Environment:

BOOST_ROOT_1_69_0: root directory of the Boost version 1.69.0 installation

1.72.0 [msvc-14.2]
Environment:

PATH: contains the location of Boost version 1.72.0
BOOST_ROOT: root directory of the Boost version 1.72.0 installation
BOOST_ROOT_1_72_0: root directory of the Boost version 1.72.0 installation

Notes:
Link: https://cmake.org/cmake/help/latest/module/FindBoost.html
If Boost was built using the boost-cmake project or from Boost 1.70.0 on it provides a package
configuration file for use with find_package's config mode. This module looks for the package
configuration file called BoostConfig.cmake or boost-config.cmake and stores the result in CACHE entry "Boost_DIR".
If found, the package configuration file is loaded and this module returns with no further action.
See documentation of the Boost CMake package configuration for details on what it provides.
Set Boost_NO_BOOST_CMAKE to ON, to disable the search for boost-cmake.

I tought that (according to https://github.com/actions/virtual-environments/issues/319) the BOOST_ROOT enviroment variable was deprecated, but this PR seems to document its usage on Windows platform.


RHDM-251: switch to wildfly11 from wildfly10 profile

This is needed when we merge all PRs referenced at https://github.com/kiegroup/droolsjbpm-build-bootstrap/pull/682

@mareknovotny there are three inoffensive wildfly10 issues in FlowJob.groovy too
https://github.com/kiegroup/kie-jenkins-scripts/blob/master/job-dsls/jobs/FlowJob.groovy#L430
https://github.com/kiegroup/kie-jenkins-scripts/blob/master/job-dsls/jobs/FlowJob.groovy#L504
https://github.com/kiegroup/kie-jenkins-scripts/blob/master/job-dsls/jobs/FlowJob.groovy#L601
Shouldn't they change once we moved to WildFly 11?

@mbiarnes yes, good catch!


host report: Remove "Indices and tables" section in PDF.

For the single system PDF remove the section "2 Indices and tables".
This has to be removed in the rst files before Sphinx run.

Done - http://sdp-services.sdp.kat.ac.za/servers/lab1/lab1.pdf

Done - http://sdp-services.sdp.kat.ac.za/servers/lab1/lab1.pdf


Unable to download APP with backslash in name

Downloading Symbols in my Test App
[2018-05-26 14:52:24.70] Error: Could not find a part of the path 'c:\AdvaniaGIT\Workspace\GIT\GitHub\businesscentral\ALTests.alpackages\Objects4NAV_G\L Source Names_<IP_ADDRESS>.app'.
[2018-05-26 14:52:28.66] Could not download reference symbols. Please ensure that:

The correct server name and instance are specified in the launch.json file.
The correct application version is specified in the app.json file.

Filename is: c:\AdvaniaGIT\Workspace\GIT\GitHub\businesscentral\ALTests.alpackages\Objects4NAV_GL Source Names_<IP_ADDRESS>.app

Hi @gunnargestsson, which version of the AL extension are you running? I tried to reproduce it and it seems to be fixed on our latest version.

using current bcsandbox container.

Does the app your are downloading include the / character in the name

I was able to reproduce the error when downloading symbols of a package with a forward slash in its name with the AL extension version: 0.15.18771 and the server version: W1 12.0 (21812), but not on our latest master. This has been fixed in the meanwhile. Updating to a newer version should fix your issue.


Merge branch 2.3.5

Codecov Report

Merging #653 into release-2.4.0 will increase coverage by 0.01%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##             release-2.4.0     #653      +/-   ##
===================================================
+ Coverage            32.66%   32.67%   +0.01%
  Complexity            1232     1232
===================================================
  Files                  170      170
  Lines                14981    14981
  Branches              2371     2371
===================================================
+ Hits                  4893     4895       +2
+ Misses                9363     9361       -2
  Partials               725      725

Impacted Files
Coverage Δ
Complexity Δ

...p/searchindex/elasticsearch/ElasticSearchUtil.java
48.49% <0%> (+0.54%)
52% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1e5b03...3ca974b. Read the comment docs.


[Potential test cycle fix]introducing separate error for ApiServer page not found

Sometimes, during initialisation, 404 is thrown by ApiServer with the message as page not found, even when the resource actually exists.
DbManager treats it as binding not found scenario and stops retrying for connection, which is incorrect behaviour. Modifying this flow by distinguishing between resource not found and page not found scenarios.

Pull Request Test Coverage Report for Build 3091

7 of 11 (63.64%)  changed or added relevant lines in 3 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.05%) to 89.866%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

common/errors.js
1
2
50.0%

data-access-layer/eventmesh/ApiServerClient.js
3
4
75.0%

data-access-layer/db/DBManager/DBManager.js
3
5
60.0%

Files with Coverage Reduction
New Missed Lines
%

data-access-layer/db/DBManager/DBManager.js
1
97.5%

common/utils/index.js
1
89.47%

Totals

Change from base Build 3085:
-0.05%

Covered Lines:
9330

Relevant Lines:
10036

💛  - Coveralls


Add Pandas integration (?)

It would nice to have intragation for pandas' objects such as DataFrames.
I have some data functions that I'd like to test; they fetch data from a SQL database and return a DataFrame.
def test_get_data():
    df = get_data()
    assert (df == snapshot()).all().all()

def test_get_data():
    df = get_data()
    assert (df == snapshot(pd.DataFrame([{"col_a": 10, "col_b": 11}, {"col_a": 11, "col_b": 23 }]))).all().all()

Enabling custom objects in the library can create lots of overhead, so I am not sure if you are planning to add this at some point or if you would rather have "extensions"  something like inline-snapshot-pandas .

I have no experience with pandas, but there might be some problems.
inline-snapshot assumes that == has a bool return type. The all() in your code tells me that this is not the case.
The other problem might be that DataFrames might be really big. Putting them into your code might not be a good idea in this case. One option might be to convert them into a csv and to use outsource().
I have currently no way to try things out, but one idea.
assert df_to_list(df) == snapshot([{"col_a": 10, "col_b": 11}, {"col_a": 11, "col_b": 23 }])

df_to_list should convert the data frame into a list of dicts. This would cause no problems with inline-snapshot and allow you to use dirty-equals for the values if you want.
creating a separate library with helper functions might be a good option. I don't know currently if it can be done without changes in inline-snapshot.

The other problem might be that DataFrames might be really big. Putting them into your code might not be a good idea in this case.

I think this is a very valid point. It's not in my case currently but I can see how it could cause problems.
Your idea actually fits better and I guess is simpler than having to create a whole new feature just for a DataFrame!


Adding fields breaks layout for existing fields

@tomalec
When you change one of the values on the custom fields, it breaks the layout as the content is refreshed.
The same thing happens when you add a field, be it custom, phone number, address or email. The layout for the existing fields becomes distorted as can be seen on the gif provided by @warpech

Reported at https://github.com/StarcounterSamples/People/pull/40#issuecomment-243708614

@tomalec
When you say blank page, you mean you can't see anything at all :o?
Cause, it can be reproduced in both develop, feature/people-improvements and feature/further-enhancement, those 3 I am sure of, I haven't tried any of the other builds.
But i suspect that you can't reproduce it on the Master build. I think the issue arose when @warpech fixed the Layout, because when the layout gets "broken", it basically "reverts" to how it was before the latest visual update.

That is all I can see with:

Starcounter: <IP_ADDRESS>04
StarcounterPrefabs/Launcher@9c506c66a6c
StarcounterSamples/People@e784dbfce

I dont know if it will make a difference, but I also start SignIn and UserAdmin, and log in ad admin/admin

Probably it does, however even after I run those I cannot login as admin/admin.
BTW, @warpech do we really want People app show blank page without a single message for not logged in users?

My bad, I missed https://github.com/StarcounterSamples/People#installation-instructions

BTW, @warpech do we really want People app show blank page without a single message for not logged in users?

No, we don't really want that. @joozek78 is working on more clever authentincation and authorization scheme. Then we can decide how to actually inform a user that they need to log in.

I have identified the problem, it was a bug in starcounter-include https://github.com/StarcounterPrefabs/launcher-include/issues/18 (fix is ready, I just need to add some tests).
It also showed up because of the fact People app replaces entire table instead of pushing one element. That's not the reason but I would also call it a bug https://github.com/StarcounterSamples/People/issues/42

Thanks!

@tomalec was the solution released with Starcounter?
I can still reproduce it at http://inside.starcounter.com/, which is using Starcounter <IP_ADDRESS>33 and Launcher 5.0.0-develop.2
Can you pls take a look?

Could you provide credentials for http://inside.starcounter.com/people/persons ?

So it seems either it's not this version of Starcounter or some other app overwrites the starcounter-include as the one from /sys is 1.3.0 but the one at http://inside.starcounter.com/sys/starcounter-include/starcounter-include.html is just 1.0.1

This was my bad. Launcher 5.0.0-develop.1 package included outdated starcounter-include.
I have re-released the package and updated http://inside.starcounter.com/
Works OK now


Set minimum permissions for workflows

Set minimum permissions to workflows helps keep the workflows more safe against supply-chain attacks. GitHub gives higher permissions to workflows by default but it's good practice to adjust them to the minimum permissions necessary.
To do that, we check what actions are used in the workflow and what permissions they need. In this case tests.yml uses actions/checkout and actions/setup-node, which need only contents: read permissions to read the repository code. If you agree with this setting, I can open a PR!
This setting is recommended by security tools, such as Scorecards and StepSecurity.
Additional Context
I'm Gabriela and I work on behalf of Google and the OpenSSF suggesting supply-chain security changes :)

Thanks for finding. Happy to accept a PR with this change.


Make dims.point a property

🚀 Feature
Currently, trying to set viewer.dims.point results in an error. The only way to set it is viewer.dims.set_point(axis, index), which is a bit clunky if one wants to modify the position on multiple axes. I propose making Dims.point a property that is settable.
Motivated by this question on image.sc

maybe not right place to discuss but are there any alternatives to point? maybe position of dimensions? or something else?

@jni the reason why that isn't currently done is that I don't think we know how to trigger an update of our event system if someone just modifies one element of that list, i.e.
viewer.dims.point[1] = 13

would have no effect, which I think will be confusing to people. If we can figure this out then I'd love to drop all the set_* methods on the dims model.
@AhmetCanSolak point was chosen to be a counterpart to interval which was we're not supporting yet, but I certainly prefer position too, I think redoing both at the same time makes sense, but we might also want to wait to bundle this api change with the 0.3 release then (and push more of our advanced 0.3 features that we havn't gotten to yet to 0.4)

I think position is more intuitive as well. Regarding the way the setters work right now - this also relates to my comment in the axis labels PR (https://github.com/napari/napari/pull/644#issuecomment-551401216). I think that you either need a helper class that deals with setting and getting the different Dims properties, or have smaller Interval, Position, etc. classes that can have more elaborate logic tied to them, and have these classes be composed into Dims.

Regarding the way the setters work right now - this also relates to my comment in the axis labels PR

☝ what he said. =P
We could make point/position (I don't have a strong opinion on this name, position is fine) a tuple, then no one should expect to modify a single element of it. And tuple makes sense anyway for indexing.

Making all of these tuples with a setter on the whole property could work. We'd probably still need to keep the set_* methods then as internally we often want to just modify one axis and trigger events only for that axis

Why not have a class (__slots__ included) with tuple-like behavior? If you want to add attrs as a dependency then these classes can be very easy to write, with all the needed dunder methods built in.

@HagaiHargil I generally prefer to compose simple, built-in data structures, which are familiar to most Python users. But I'm not totally opposed to the idea.

Came across this issue today: a lot has changed since it was opened!
The slider positions can be accessed using using current_step (related to the image.sc post linked in the OP)
Likewise, dims.point can be assigned directly.
I think we can close, @jni ?


Add ascii_only parameter to minification procedure

As per #39 UglifyJS breaks escape sequences for national symbols. This property tells the library to escape Unicode symbols.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@yaruson thank you for your pull request! As already mentioned in #39 I could think of a different solution.
In case this is something that also makes sense to you, please feel free to update this pull request accordingly.

Closing this on favor of #41


feature: bkmonitorbeat 增加自检功能

bkmonitorbeat self-check 增加自检功能
2.自检功能包括进程检测 读取 config 配置中指向的 pid 文件，从而进行特定 pid 检测 (pid 不在运行 不会重新拉起进程)
unix domain socket 文件检测 （检测内容包含 文件是否存在、尝试建立连接，仅建立连接确保 socket 文件可用，不会进行读写操作）

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Kimmy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[Add profile] -> [Chandula Janith]

If you're adding your profile, the title of this PR should be: [Add profile] -> [Your Name]
Add Chandula Janith

@Evavic44 now is it okay?


python311Packages.google-cloud-dlp: 3.12.1 -> 3.12.2

Changelog: https://github.com/googleapis/python-dlp/blob/v3.12.2/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 241897 run on x86_64-linux 1

4 packages built:

python310Packages.google-cloud-dlp
python310Packages.google-cloud-dlp.dist
python311Packages.google-cloud-dlp
python311Packages.google-cloud-dlp.dist


Possible to add a pip package?

Heya, I'm writing a langchain binding for exllama, I'd love to be able to pip install exllama and be able to access the libraries in python natively, right now I'm not really sure how I'd ship the langchain module without creating my own binding library in pip, which seems very awkward.

I'd love to package it up at some point, but a lot of it is still changing too much. The interface is mutating every other day, I'm adding in features, removing features, turning stateful stuff stateless and vice versa... I just don't think it's quite ready for a version number just yet.

Makes perfect sense, in the meantime I'll leave this example PR for people who wish to use exllama and langchain right now https://github.com/turboderp/exllama/pull/68#issue-1762326948
This seems like a good compromise for the time being I think.


Fix for rake error (#15)

The following patch fixes the issue reported in #15

Hi,
thanks for pointing out the issue and for submitting a PR but we should find another solution

coveralls relies on rake to send data (but this is not specified in runtime dependencies)
we cannot assume that rails test is present, because coveralls-ruby does not depend on rails.

Workaround: provide a default rake task which runs tests (this is pretty standard, comes by default with rails)
$ rails _<IP_ADDRESS>_ new test-rake
$ cd test-rake
$ bundle exec rake
2020-10-21 16:16:51 WARN Selenium [DEPRECATION] Selenium::WebDriver::Chrome#driver_path= is deprecated. Use Selenium::WebDriver::Chrome::Service#driver_path= instead.
Run options: --seed 1758

# Running:

Finished in 0.000479s, 0.0000 runs/s, 0.0000 assertions/s.
0 runs, 0 assertions, 0 failures, 0 errors, 0 skips

$ rails _<IP_ADDRESS>_ new test-rake-6
$ cd test-rake-6/
$ rails db:migrate
$ bundle exec rake
Run options: --seed 22541

# Running:

Finished in 0.065458s, 0.0000 runs/s, 0.0000 assertions/s.
0 runs, 0 assertions, 0 failures, 0 errors, 0 skips

Coverage remained the same at 0.0% when pulling 1a60ce2972d501cefecde1d156b6bc19e3cd9a5e on sylvainbx:master into 11a85a983560cea965043da21d535ff5885d7e46 on tagliala:master.

Ok, thanks for pointing out that this gem does not depends on rails.
I made a quick test using bundle exec rake test instead but... nothing happens, the command terminates immediately without any output.
I'll investigate more deeper later and keep you updated

After investigating, it was my fault.
I was missing require 'rails/test_unit/railtie' in config/application.rb (see this answer on SO).
Sorry for bothering, I'm closing this pull request.

@sylvainbx hi, don't worry, and thanks for the heads-up!


chapter2-devicetree-basics.rst refers to missing Appendix A

chapter2-devicetree-basics.rst and chapter1-introduction.rst refer to an Appendix A which does not exist:
".. note:: Most devicetrees in :abbr:DTS (Device Tree Syntax) (see Appendix A) will not
contain explicit phandle properties. The DTC tool automatically inserts
the phandle properties when the DTS is compiled into the binary DTB
format."
In chapter2-devicetree-basics.rst  I would have expected an example comparing the device-tree before DTC translation without phandle and with phandle after translation.

Cf. https://elinux.org/Device_Tree_Mysteries#Label_as_a_phandle_vs_Label_as_a_path

That's now chapter 6. Can you submit a fix? I take patches, but no one is actively working on the spec.


std::filesystem replacement for macOS

Avoid switching to xcode 11 if possible and find native functions. like NSBundle

NSBundle used on ios/macos. Callback mecanism for assets on Android. Closing.


Fix: increase timeout-keep-alive and send ping every 5 min to browser

To maintain SSE connection im setting keep-alive to 5min and sending ping from the server every 15s to keep it up. On client I'm waiting for ping for 20s and if not received or if there are any errors trying to reconnect every 3s.


navigate 2 screen back on single press

<Button
onPress={() => goBack()}
title="Go back from this HomeScreen"
/>
with this i am going one screen back. how can i go 2 screen back on single press

https://reactnavigation.org/docs/navigators/navigation-prop#goBack-Close-the-active-screen-and-move-back
<Button onPress={() => goBack('screen-123')}
               title="Go back from screen-123"
/>

using the code below i am going one screen back
<Button
onPress={() => goBack()}
title="Go back from this HomeScreen"
/>
how can i go 2 screen back on single press action
using the code below i am going one screen back
<Button
onPress={() => goBack()}
title="Go back from this HomeScreen"
/>
how can i go 2 screen back on single press action
I am using this code to initialize the navigator
const RouteConfigs = {
Login: {screen:Login},
Home: {screen:Home},
Chat: {screen:Chat},
Facebook: {screen:Facebook},
Facebookgallery: {screen:Facebookgallery}
}
const StackNavigatorConfig = {
headerMode: 'none',
}
export default StackNavigator(RouteConfigs, StackNavigatorConfig)
what is 'screen-123' here ?

You can do it with settimeout for your second navigate, so one to goBack, and a setTimeout with another one to go back in it, they need to execute at a different time. This should help guide you.

I tried something like this but only one goBack works ie it goes one screen back and not two screen back
_goback(){
const {goBack} = this.props.navigation
setTimeout(function(){ goBack() }, 500)
goBack()
}
onPress={ () => this._goback() }

This would be my best guess.
_goback(){
  const {goBack} = this.props.navigation;
  goBack();
  setTimeout(function(){ goBack() }, 500);
}

onPress={ () => this._goback() }

If it doesn't work, maybe someone else can jump in.

nopes its working same as my code. no difference. only one goBack() get called

If goBack() does not work, try dispatch instead.

already tried but there isn't much difference

If you see the source code
const backRoute = state.routes.find(
            /* $FlowFixMe */
            (route: *) => route.key === action.key
          );

So it's not routeNamethat you should passing. You need to find the route key (something like "id-1494508623037-2" in my case).

yes i just figured it out and i am able to move from a specific screen back but
how can i pass a param when i go back?

@ptmt - How did you look up the ID? I tried so view the states with no luck:
const { navigate, goBack, state } = this.props.navigation;
{state.routes}
I also tried goBack="Init" and that does not work also...

@abhitheawesomecoder

how can i pass a param when i go back?

Did you solve this? I suggest using Redux integration for that purpose.
@julesmoretti In my case, I was able to solve this by passing it via param, and yes, it should be contained in routes state, what's the output for console.log(state)?

this is my temporary solution:

export function navGoBack(navigation, routeName) {
  const { goBack } = navigation
  const { routes } = navigation.reduxState.nav

  let nToGoBack = routes.length+1
  let routeKeyToGoBackFrom = null
  for (let i = routes.length - 2; i >= 0; i--) {
    if (routes[i].routeName === routeName) {
      nToGoBack = routes.length-1 -i
      routeKeyToGoBackFrom = routes[i+1].key
     break
    }
  }
// choose one
// version 1
  for (let i = 0; i < 2; i++) {
    goBack(null)
  }

// version 2
  if (routeKeyToGoBackFrom !== null) {
    goBack(routeKeyToGoBackFrom)
  }
}

both versions work, but both versions animate both back actions, so instead of going "directly" 2 screens back, it shows it like you are "scrolling" back the screens one by one.

Hi,
I was having the same problem and the path I ultimately took was to send a special action to redux and generating a new state with the screen that I wanted to go back selected.
Very cumbersome, but if you do that, you avoid the animations of both back actions and works like a charm.

@boliveira do you have an example of the code you wrote that is working?

@antoinegrelard , sorry for the late response, I was in vacation.
Certainly, so I did something like this (I am omitting the parts that are not relevant):
//navigationReducer
export default function navigationReducer(state = initialState, action) {
...

//Handle special back case
if (
    action.type === "Navigation/BACK" &&
    action.key === "BACK_MARKETDATA_FROM_ADD_SECURITIES"
  ) {
newNavigationState = getMarketDataState(state.nav);
} else {
newNavigationState = AppNavigator.router.getStateForAction(
      action,
      state.nav
    );
}

...
}

function getMarketDataState(state) {
  const newState = { ...state };

  const drawerCloseRoute = newState.routes[0];

  const streamerRoute = { ...drawerCloseRoute.routes[0] };

  streamerRoute.index = 0;
  streamerRoute.routes.splice(1, 1);

  const newDrawerCloseRoute = { ...drawerCloseRoute };

  newDrawerCloseRoute.routes[0] = streamerRoute;

  newState.routes[0] = newDrawerCloseRoute;

  return newState;
}

Then in container component I just do:
this.props.navigation.goBack("BACK_MARKETDATA_FROM_ADD_SECURITIES");
If you have any questions about the code, please, be confortable to ask :)

I tried this and it's worked.
const goDoubleBack = () => {
    setTimeout(() => {
            this.props.navigation.goBack(null);
            this.props.navigation.goBack(null);
    }, 50);
};

Any idea why the previous answer by @vishaljadav24 was down voted that much? I tried it and it worked well for me, is there something else to it that makes it not desirable?

another alternative, if you are want to go back twice in a stack: this.props.navigation.pop(2)

Here's my 2 cents.
I have this: HomeScreen -> QrCodeScanner -> PaymentScreen
And target is go back to HomeScreenafter some event in PaymentScreen.
My original attempt is this.props.navigation.goBack('screen-key-of-QrCodeScanner'), as proposed here.
It works, however there will be 2 navigate back animation (QrCodeScanner will flash on screen for < 1s). Which I guess probably will happen for similar solution like invoking .goBack(null) twice or .pop(2).
Then my 2nd attempt is resetting the navigation state as if just HomeScreen exist.
const actions = [ NavigationActions.navigate({ routeName: 'HomeScreen' }) ]

const resetAction = NavigationActions.reset({
  index: actions.length - 1
  actions
})

this.props.navigation.dispatch(resetAction)

This work perfectly for me, without weird navigation animation. However, need to note that after reset, the HomeScreen will be brand new, e.g. you'll lost the scroll position. And it gonna mount again, e.g. APIs call in componentDidMount will fire again.

@ivan-ha - thanks for describing this, can you create a new issue that provides an example of both of these situations? we can then discuss further there. certainly sounds like something we should fix though, so i hope you get around to creating an issue for it!

i got the same problem and this is how i fix it:
const prevGetStateForActionAppNavigator = AppNavigator.router.getStateForAction; AppNavigator.router = {     ...AppNavigator.router,     getStateForAction(action, state) {       if(state && state.routes && state.routes.length > 2         && action.type === 'back_2_screen') {         let routes = state.routes.slice();         routes.pop();         routes.pop();         return {             index: routes.length - 1,             routes: routes         };      }       return prevGetStateForActionAppNavigator(action, state);     }, }
and then  props.navigation.dispatch({type: 'back_2_screen'}) to go back twice.

how can I go back the first screen from the third screen without second screen show up? eg:stack: A -> B -> C, now I want go back like C -> A

this.props.navigation.navigate("A").

Just a point. (for version ˆ3.x)
If you guys are using .reset to do it, remeber that function is not part of NavigationActions anymore. Use StackActions.reset instead.

In my case, I needed to go back from a child screen to the parent screen.
Adding resetOnBlur: true to createBottomTabNavigator options did the work for me.
https://reactnavigation.org/docs/en/bottom-tab-navigator.html#bottomtabnavigatorconfig

I ended up using this.props.navigation.navigate({
routeName: 'route-name',
key: 'route-key'
})
Per the documentation, https://reactnavigation.org/docs/en/navigation-actions.html
key - String - Optional - The identifier for the route to navigate to. Navigate back to this route if it already exists

How about navigate 2 screen back when swipe on iOS? Can I override the swipe behavior?

How about navigate 2 screen back when swipe on iOS? Can I override the swipe behavior?

Hmmm, interesting. Maybe you can pass a param when swiping, and on the screen if that param exists, you go back another time.

another alternative, if you want to go back twice in a stack: this.props.navigation.pop(2)

This solution worked for me. Tks!


merge develop to main

Codecov Report

Merging #368 (235ab69) into main (2b262f5) will increase coverage by 1.53%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
+ Coverage   86.00%   87.53%   +1.53%
==========================================
  Files          23       23
  Lines        1400     1348      -52
==========================================
- Hits         1204     1180      -24
+ Misses        196      168      -28

Impacted Files
Coverage Δ

splunk_connect_for_snmp/customtaskmanager.py
96.07% <ø> (ø)

splunk_connect_for_snmp/traps.py
0.00% <0.00%> (ø)

splunk_connect_for_snmp/walk.py
96.55% <ø> (+96.55%)
:arrow_up:

splunk_connect_for_snmp/snmp/manager.py
94.05% <89.47%> (-0.03%)
:arrow_down:

splunk_connect_for_snmp/common/inventory_record.py
96.33% <98.50%> (-1.13%)
:arrow_down:

splunk_connect_for_snmp/__init__.py
100.00% <100.00%> (ø)

splunk_connect_for_snmp/celery_config.py
100.00% <100.00%> (ø)

...unk_connect_for_snmp/common/custom_translations.py
86.66% <100.00%> (ø)

...nnect_for_snmp/common/customised_json_formatter.py
100.00% <100.00%> (ø)

splunk_connect_for_snmp/common/profiles.py
94.44% <100.00%> (ø)

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b262f5...235ab69. Read the comment docs.

:tada: This PR is included in version 1.5.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Lower bound on M in rationalapprox

Hi Christian,
Great package!
I've been looking into the literature on simultaneous diophantine approximation and found something curious about the Hanrot implementation you've used for rationalapprox.
It appears that you need to ensure a lower bound on M of 2^(n(n+1)/4 in order that q = abs(B[1,1]) is in fact always non-zero. Otherwise, it can be zero and will of course 'blow up' the result. I came across this is practical examples and found the theoretical reason, I believe.
I can explain more if interested, but basically if you compare to the equivalent proof in Schrijver, he proves that (in the notation of the passage) that ||B(:,1)|| < C implies q ! = 0 (Schrijver uses 0 < \epsilon < 1 and we have our M equals his 2^(n(n+1)/4 \epsilon^(-n).

James,
I will likely close this at some point if you have no more comments.
The rationalapprox function is not intended to be a powerful tool, rather as a simple demo of what one can do with lattice tools.  The function is not the primary focus of the package and I do not plan to do extensive work to improve it.

Hi Chris,
Happy if you want to close this, I'm not pushing any changes. Yes, the lower bound is 2^(n(n+1)/4) (bracket in the exponent). I just wanted to share the observation, which essentially boils down to a difference between a theoretical guarantee and practical use. On larger dimensional problems, the short basis is much more sparse and you can't rely on the initial q to not be zero, but a user should always test for such things anyway.
But thanks for putting together a nice reference implementation of this, it was very useful for me to see how it could be done.


Support files in Spec

The specs written in .md files should support loading any arbitrary files.
"""
file:worker.js
function onEvent() {
   // some js code
}

server:
schema @link(type: Script, src: "worker.js") {
  query: Query
}

"""
This would allow us to write the tests with linked files.
Technical Requirements

Test should always read files that are defined in the same .md file.
Tests should not be allowed to read any random file written anywhere else.
Drop fixtures in test and inject them directly into the required md files.

/bounty 100$

/attempt #1137


Move broadcast logic from KillTask into TransportAction

By moving the logic from KillTask to the TransportAction the
TransportKillAllNodeAction follows the pattern of
TransportKillJobsNodeAction.
In addition this commit also extracts some shared logic between those
two TransportActions into re-usable components like the
MultiActionListener

ack


⚠ Secret Website 3 has degraded performance

In 7006f14, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 3044 ms

Resolved: Secret Website 3 performance has improved in 66661b2.


Adding shader preprocessor support (rebased)

A rebased version of https://github.com/godotengine/godot/pull/54690 (by @TheOrangeDay). (#include feature is not working)

Thanks for reviving this PR!
iirc exposing defines to the editor inspector was never included in the original PR. Could you take a look at that? Would be really great for plugin authors if users could simply enable/disable shader features in the material editor ui.

iirc exposing defines to the editor inspector was never included in the original PR. Could you take a look at that?

I will look what I can do...

I've did a cleanup and fixed some bugs (#include is now worked) + added code completion (after # symbol and pragma) support. I think its fine to merge for now. Adding advanced features like switching #define in the inspector can be added later.

Wonderful! I'll test out the changes as soon as I can!

SO LOVE this feature！

Great work as always!
I am still not happy with how including works with shader types. For example, If I have a sprite with the following shader:
shader_type canvas_item;

#define CLAYD

#include "clay_include.gdshader"

void fragment() {
	COLOR = get_color();
#ifdef CLAY
	COLOR = vec4(0.5, 0.7, 0.95, 1.0);
#endif
}

And then the contends of clay_include.gdshader are:
shader_type spatial;

vec4 get_color() {
#ifdef CLAYD
	return vec4(1.0, 0.9, 0.4, 1.0);
#else
	return vec4(1.0);
#endif
}

The shader correctly compiles and outputs a color of vec4(1.0, 0.9, 0.4, 1.0);, however, the editor constantly shows an error saying "Constants cannot be modified" pointing to line 8 of the main shader COLOR = get_color();. So the error handling for spatial shaders is being used within a canvas_item shader.
Alternatively, you have the opposite problem if the spatial shader you include contains a processor function then the built ins will be evaluated as if it were a canvas_item shader.
For example, if the main shader is:
shader_type canvas_item;

#include "clay_include.gdshader"

and the contents of clay_include.gdshader are:
shader_type spatial;

void fragment() {
	ALBEDO = vec3(1.0);
}

When viewing the main shader you get an error Unkown identifier in expression "ALBEDO", but when viewing the clay_include.gdshader`` shader, there is no error at all.
To me this behaviour is very confusing and quite limiting for users. As pointed out in the previous PR, users will likely want to include the same file in both spatial shaders and canvas_item shaders, so we should support that somehow.
I can see two options (but you may be able to think of something better):

Ban including different shader types, but create a new shader type (called "include") than can be included from anything. I.e. canvas_item can include canvas_item or include, but not spatial, sky, or fog. Fog can include Fog or include etc.
Allow including other shader_types. but silently ignore processor functions from other shader types, this way any shader can be included from any other, but it makes it impossible to share processor functions

@clayjohn Will look to fix that on days, rebased for now...

@clayjohn I've added include shader mode - made it mandatory for the included files - now they will throw error when you can try to use built-ins from other shader modes inside them, fixed few mode bugs I found. Please check again how it looks.

We discussed this at length on RocketChat and in a subsequent video meeting.
The consensus was:

The general approach here is fine, while it is more complex than a simple preprocessor (which just inserts text from another file) the way this is presented to the user is both simple and effective
We should not have a shader_type include instead, we should create a new resource ShaderInclude which simply has a single property text which contains the text of the include shader. ShaderInclude would use a different extension from shaders as well. Perhaps "gdshader.inc". This would not be a full-fledged shader, but rather would be a resource that is editable in the shader editor while editing a proper shader that includes it. ShaderIncludes cannot define processor functions (vertex(), fragment() etc.) doing so will result in an error in the shader that includes them.
Shaders can include other shaders from their own type, and they can include ShaderIncludes

@clayjohn I think I'm done with all of these points:

Removed include shader type
Added ShaderInclude resource type and associate it with *.inc file extension (not sure about text property - maybe code sounds better? - if not please comment and I will change it back)
Shader editor will able to edit them freely, code coloring is correctly working but completion does not
Added a check to prevent included non-similar shader types

Check again.

@Chaosus You are amazing! I will check the PR right now.

Looks great so far!
Notes:

We should allow users to create new ShaderIncludes in the "File" menu in the Shaders tab

I get a crash after editing a ShaderInclude:

================================================================
handle_crash: Program crashed with signal 11
Engine version: Godot Engine v4.0.alpha.custom_build (06ad8fc4807714e3389b19ae015619fd66a906e4)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[1] /lib/x86_64-linux-gnu/libc.so.6(+0x42520) [0x7ff8eec2f520] (??:0)
[2] CowData<char32_t>::_ref(CowData<char32_t> const&) (??:0)
[3] String::String(String const&) (??:0)
[4] Resource::get_path() const (??:0)
[5] ShaderTextEditor::_validate_script() (??:0)
[6] CodeTextEditor::_text_changed_idle_timeout() (??:0)
[7] void call_with_variant_args_helper<CodeTextEditor>(CodeTextEditor*, void (CodeTextEditor::*)(), Variant const**, Callable::CallError&, IndexSequence<>) (??:0)
[8] void call_with_variant_args<CodeTextEditor>(CodeTextEditor*, void (CodeTextEditor::*)(), Variant const**, int, Callable::CallError&) (??:0)
[9] CallableCustomMethodPointer<CodeTextEditor>::call(Variant const**, int, Variant&, Callable::CallError&) const (??:0)
[10] Callable::call(Variant const**, int, Variant&, Callable::CallError&) const (??:0)
[11] Object::emit_signalp(StringName const&, Variant const**, int) (??:0)
[12] Error Object::emit_signal<>(StringName const&) (??:0)
[13] Timer::_notification(int) (??:0)
[14] Timer::_notificationv(int, bool) (??:0)
[15] Object::notification(int, bool) (??:0)
[16] SceneTree::_notify_group_pause(StringName const&, int) (??:0)
[17] SceneTree::process(double) (??:0)
[18] Main::iteration() (??:0)
[19] OS_LinuxBSD::run() (??:0)
[20] /home/clayjohn/dev/godot/bin/godot.linuxbsd.tools.64.llvm(main+0x1c8) [0x55ea11286df8] (??:0)
[21] /lib/x86_64-linux-gnu/libc.so.6(+0x29d90) [0x7ff8eec16d90] (??:0)
[22] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0x80) [0x7ff8eec16e40] (??:0)
[23] /home/clayjohn/dev/godot/bin/godot.linuxbsd.tools.64.llvm(_start+0x25) [0x55ea11286b65] (??:0)
-- END OF BACKTRACE --
================================================================

@clayjohn Check again - I've added menu button for create include file and possibly fixed a crash you've mentioned (I'm not sure about it since you didn't posted exact line of where in _validate_script it happen). I've also added a check to restrict user to define preprocessor directives before shader_type (I found it error-prone and leads to hard-detected errors)

@clayjohn Ok, I think I've fixed these issues - try again.

I think *.inc is not specific enough for shader includes, *.gdshaderinc would be better IMO, even though it appears long

I think *.inc is not specific enough for shader includes, *.gdshaderinc would be better IMO, even though it appears long.

If @reduz of @clayjohn agreed with it - I will change it

How do we set the defines? Do they automatically appear as toggles in ShaderMaterial for all the #if X found in the final shader? Or maybe do we "export" them explicitly with some special syntax?

There are not adding toggle to the inspector, for now (this feeature is already requested at the beginning of this PR topic). This PR bring a huge mess of code already, I would add it later.

I think *.inc is not specific enough for shader includes, *.gdshaderinc would be better IMO, even though it appears long.

If @reduz or @clayjohn agreed with it - I will change it

I think we should change to ".gdshaderinc". ".gdshader.inc" was reduz' original suggestion after all.

I think we should change to ".gdshaderinc". ".gdshader.inc" was reduz' original suggestion after all.

Done

Amazing work! I tested out before the name change and everything appeared to be working well. I will do an in-depth code review tomorrow, but I am fairly sure this will be ready to go :)

My feeling after seeing this PR again and again is that its too complicated in many aspects where it should really not be. My suggestion for simplifying and improving it would be as follows:
1: Remove the ability to edit the includes as sub-editors, allow .gshaderinc to be opened as any other shader

I know this looks cool but let's be honest. This was made for the previous shader editor where you could only edit one shader at a time. This is no longer the case now, so this feature is very redundant. Removing it simplifies the shader editor significantly.
Additionally, as I saw in code, the ability to optionally put a shader_type in an include to get proper compilation errors was so simple for the preprocessor to remove, that should let you edit the includes in a separate item in the list with proper code completion and without any issues.
2: Make the preprocessor really a preprocessor.
I know I insist a lot in this, but There is a lot of quite ugly code due to this. As a rule:

The preprocessor should be used ONLY from  ShaderLanguage and internally (unexposed). No other files should reference or use it (which is the case of ShaderCompiler now and ShaderEditorPlugin.
The preprocessor include files should be passed to the tokenizer as special tokens, which should maintain an include stack and use this for proper error reporting. I can help implementing this if you want, it can be done last as cleanup when everything else is working.

3: Settle on single extension (.gshaderinc or something else)
Godot is not designed to handle multiple extensions (.gshader.inc will not work properly), and changing it only to support this would be an immense amount of work that is unjustified.

.gshaderinc

I'd suggest .gdshaderinc, not .gshaderinc, as standard shader files use .gdshader.

I'd suggest .gdshaderinc, not .gshaderinc, as standard shader files use .gdshader.

I've already did .gdshaderinc as you've suggested


[Bug]: Repeated clicking on the same file eventually leads to server "Too many open files" error and session becomes unusable

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

Describe the bug and reproduction steps
Note, I searched for the error message "Too many open files" and didn't see any open issue against this error.
Repro steps:

Run with a prompt of do nothing
Add files to the /workspace, just a few files will do
In the Workspace UI, click open one of the files
Repeatedly click on the file quickly over and over again

Eventually, the UI and backend server becomes broken.
In the UI, the message "Failed to fetch file" will show up.
In the backend, when running with DEBUG=1 make run this error message shows up:
Traceback (most recent call last):
  File "/pypoetry/virtualenvs/openhands-ai-zQh2l52--py3.12/lib/python3.12/site-packages/uvicorn/protocols/http/httptools_impl.py", line 401, in run_asgi
    result = await app(  # type: ignore[func-returns-value]
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/pypoetry/virtualenvs/openhands-ai-zQh2l52--py3.12/lib/python3.12/site-packages/uvicorn/middleware/proxy_headers.py", line 60, in __call__
    return await self.app(scope, receive, send)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/pypoetry/virtualenvs/openhands-ai-zQh2l52--py3.12/lib/python3.12/site-packages/fastapi/applications.py", line 1054, in __call__
    await super().__call__(scope, receive, send)
  File "/pypoetry/virtualenvs/openhands-ai-zQh2l52--py3.12/lib/python3.12/site-packages/starlette/applications.py", line 113, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/pypoetry/virtualenvs/openhands-ai-zQh2l52--py3.12/lib/python3.12/site-packages/starlette/middleware/errors.py", line 187, in __call__
    raise exc
  File "/pypoetry/virtualenvs/openhands-ai-zQh2l52--py3.12/lib/python3.12/site-packages/starlette/middleware/errors.py", line 165, in __call__
    await self.app(scope, receive, _send)
  File "/pypoetry/virtualenvs/openhands-ai-zQh2l52--py3.12/lib/python3.12/site-packages/starlette/middleware/base.py", line 185, in __call__
    with collapse_excgroups():
  File "/Users/diwu/miniconda3/lib/python3.12/contextlib.py", line 158, in __exit__
    self.gen.throw(value)
  File "/pypoetry/virtualenvs/openhands-ai-zQh2l52--py3.12/lib/python3.12/site-packages/starlette/_utils.py", line 82, in collapse_excgroups
    raise exc
  File "/pypoetry/virtualenvs/openhands-ai-zQh2l52--py3.12/lib/python3.12/site-packages/starlette/middleware/base.py", line 187, in __call__
    response = await self.dispatch_func(request, call_next)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "openhands/server/listen.py", line 217, in attach_session
    request.state.conversation = await call_sync_from_async(
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "openhands/utils/async_utils.py", line 18, in call_sync_from_async
    result = await coro
             ^^^^^^^^^^
  File "/Users/diwu/miniconda3/lib/python3.12/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "openhands/utils/async_utils.py", line 17, in <lambda>
    coro = loop.run_in_executor(None, lambda: fn(*args, **kwargs))
                                              ^^^^^^^^^^^^^^^^^^^
  File "openhands/server/session/manager.py", line 52, in attach_to_conversation
    return Conversation(sid, file_store=self.file_store, config=self.config)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "openhands/server/session/conversation.py", line 31, in __init__
    self.runtime = runtime_cls(
                   ^^^^^^^^^^^^
  File "openhands/runtime/impl/eventstream/eventstream_runtime.py", line 162, in __init__
    self.docker_client: docker.DockerClient = self._init_docker_client()
                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "openhands/runtime/impl/eventstream/eventstream_runtime.py", line 241, in _init_docker_client
    raise ex
  File "openhands/runtime/impl/eventstream/eventstream_runtime.py", line 236, in _init_docker_client
    return docker.from_env()
           ^^^^^^^^^^^^^^^^^
  File "/pypoetry/virtualenvs/openhands-ai-zQh2l52--py3.12/lib/python3.12/site-packages/docker/client.py", line 94, in from_env
    return cls(
           ^^^^
  File "/pypoetry/virtualenvs/openhands-ai-zQh2l52--py3.12/lib/python3.12/site-packages/docker/client.py", line 45, in __init__
    self.api = APIClient(*args, **kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/pypoetry/virtualenvs/openhands-ai-zQh2l52--py3.12/lib/python3.12/site-packages/docker/api/client.py", line 207, in __init__
    self._version = self._retrieve_server_version()
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/pypoetry/virtualenvs/openhands-ai-zQh2l52--py3.12/lib/python3.12/site-packages/docker/api/client.py", line 230, in _retrieve_server_version
    raise DockerException(

OpenHands Installation
Docker command in README
OpenHands Version
main
Operating System
MacOS
Logs, Errors, Screenshots, and Additional Context
No response

I did some debugging into this, it appears that there's many unix sockets being opened per "click" to the docker daemon socket. There appear to be a leak somewhere.

 The issue is the same as what's reported in https://github.com/docker/docker-py/issues/3282
As far as I can tell, the best way to fix this would be to:

stop using container.logs(stream=True, follow=True) because the bug is in the generator
keep a timestamp of the last log retrieved time
poll the log each time from since to until
get rid of that extra background thread, just make this poll the log in [since -> until] segments every time get_and_clear is called

The other leak of the TCP socket is from requests.session() returning a response but never explicitly closing that response object, so it accumulates as leaked connection. Solutions are:

either refactor the way response are consumed to always call close() so the conn is returned to the pool (looks like a lot of refactor, not worth it IMO)
do session.headers['Connection'] = 'close' to automatically close the connection (this one worked with minimal change, I'd just fix it this way and it doesn't matter perf wise when the TCP to the sandbox doesn't get re-used)

This issue should now be resolved on main

Bug is less severe, but it's still fundamentally there, take a look at the output of lsof -p {pid of the uvicorn process}:
python3.1 12305 diwu   98u    IPv6 0xcc4fb2f8cb35a3a9       0t0                 TCP localhost:54187->localhost:30147 (CLOSE_WAIT)
python3.1 12305 diwu   99u    unix 0xcc4fb3072e10a861       0t0                     ->0xcc4fb3072e10a929
python3.1 12305 diwu  100u    IPv6 0xcc4fb2f8cb35b1a9       0t0                 TCP localhost:54191->localhost:30147 (CLOSE_WAIT)
python3.1 12305 diwu  101u    unix 0xcc4fb3072e1083a9       0t0                     ->0xcc4fb3072e108471
python3.1 12305 diwu  102u    IPv6 0xcc4fb2f8cb35fea9       0t0                 TCP localhost:54194->localhost:30147 (CLOSE_WAIT)
python3.1 12305 diwu  103u    unix 0xcc4fb3072e1089e9       0t0                     ->0xcc4fb3072e108ab1
python3.1 12305 diwu  104u    IPv6 0xcc4fb2f8cb3605a9       0t0                 TCP localhost:54198->localhost:30147 (CLOSE_WAIT)
python3.1 12305 diwu  105u    unix 0xcc4fb3072e108e99       0t0                     ->0xcc4fb3072e109411
python3.1 12305 diwu  106u    IPv6 0xcc4fb2f8cb360ca9       0t0                 TCP localhost:54202->localhost:30147 (CLOSE_WAIT)
python3.1 12305 diwu  107u    unix 0xcc4fb3072e108219       0t0                     ->0xcc4fb3072e1082e1
python3.1 12305 diwu  108u    IPv6 0xcc4fb2f8cb35d4a9       0t0                 TCP localhost:54205->localhost:30147 (CLOSE_WAIT)
python3.1 12305 diwu  109u    unix 0xcc4fb3072e108859       0t0                     ->0xcc4fb3072e108921
python3.1 12305 diwu  110u    IPv6 0xcc4fb2f8cb35e2a9       0t0                 TCP localhost:54209->localhost:30147 (CLOSE_WAIT)
python3.1 12305 diwu  111u    unix 0xcc4fb3072e108b79       0t0                     ->0xcc4fb3072e108c41
python3.1 12305 diwu  112u    IPv6 0xcc4fb2f8cb35f0a9       0t0                 TCP localhost:54213->localhost:30147 (CLOSE_WAIT)
python3.1 12305 diwu  113u    unix 0xcc4fb3072e109fc9       0t0                     ->0xcc4fb3072e10a091
python3.1 12305 diwu  114u    IPv6 0xcc4fb2f8cb3595a9       0t0                 TCP localhost:54262->localhost:30147 (ESTABLISHED)
python3.1 12305 diwu  115u    unix 0xcc4fb3072e1097f9       0t0                     ->0xcc4fb3072e109a51
python3.1 12305 diwu  116u    IPv6 0xcc4fb2f8cb359ca9       0t0                 TCP localhost:54267->localhost:30147 (ESTABLISHED)
python3.1 12305 diwu  117u    unix 0xcc4fb3072e108791       0t0                     ->0xcc4fb3072e108d09
python3.1 12305 diwu  118u    IPv6 0xcc4fb2f8cb3579a9       0t0                 TCP localhost:54270->localhost:30147 (ESTABLISHED)
python3.1 12305 diwu  119u    unix 0xcc4fb3072e108601       0t0                     ->0xcc4fb3072e1086c9
python3.1 12305 diwu  120u    IPv6 0xcc4fb2f8cb3533a9       0t0                 TCP localhost:54274->localhost:30147 (ESTABLISHED)
python3.1 12305 diwu  121u    unix 0xcc4fb3072e10a3b1       0t0                     ->0xcc4fb3072e10a479

TCP CLOSE_WAIT is the one that's easy to solve, by setting the connection header to CLOSE.
the other unix one is still the log tailing issue

The TCP isn't being leaked, so now the only remaining accumulating leak is the unix docker sockets.
You can repro it by repeated clicking on a file and then do lsof -p ... | grep unix

@diwu-sf is this bug finally resolved? tofarr put in a few fixes.

No there's still Unix socket leak to the docker socket due to the log streamer.
Use the same repo and you should see that Unix sockets are still being accumulated per click

Was able to see the leakage by following lsof -p for this process, and clicking on files
~/.cache/pypoetry/virtualenvs/openhands-ai-uYxnY0EM-py3.12/bin/python -c from multiprocessing.spawn import spawn_main; spawn_main(tracker_fd=5, pipe_handle=7) --multiprocessing-fork

Strange that the uvicorn proc itself doesn't own the leak, just this one. Which I guess points to the leak being in a thread?

It’s the docker log streamer thread. It never actually closed the log line
generator
On Thu, Nov 14, 2024 at 6:19 AM Robert Brennan @.***>
wrote:

Was able to see the leakage by following lsof -p for this process, and
clicking on files
~/.cache/pypoetry/virtualenvs/openhands-ai-uYxnY0EM-py3.12/bin/python -c from multiprocessing.spawn import spawn_main; spawn_main(tracker_fd=5, pipe_handle=7) --multiprocessing-fork
Strange that the uvicorn proc itself doesn't own the leak, just this one.
Which I guess points to the leak being in a thread?
—
Reply to this email directly, view it on GitHub
https://github.com/All-Hands-AI/OpenHands/issues/4538#issuecomment-2476473995,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BL3P7PSMDECPQFNMNPMLBQD2ASWPTAVCNFSM6AAAAABQP5ZOPSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZWGQ3TGOJZGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

OK I fixed several leakage issues, but this one persists 🙃
I did start calling log_generator.close() but no luck
for posterity, you can watch the leakage with
while true; do lsof -p $(pgrep -f "tracker_fd") | wc -l; sleep 1; done

All the leaks go away if you make LogBuffer a null class (replace all method logic with pass or return empty vars)

I've further confirmed that if you don't instantiate the log_generator in LogBuffer, the leak goes away.
I've also confirmed that we're closing every log_generator we create.
TBH at this point I'm assuming there's a bug in the docker SDK

There is a bug, look at the sdk reference I had earlier in this thread.
There’s also a workaround fix for the leak in that docker issues thread
On Thu, Nov 14, 2024 at 11:57 AM Robert Brennan @.***>
wrote:

I've further confirmed that if you don't instantiate the log_generator in
LogBuffer, the leak goes away.
I've also confirmed that we're closing every log_generator we create.
TBH at this point I'm assuming there's a bug in the docker SDK
—
Reply to this email directly, view it on GitHub
https://github.com/All-Hands-AI/OpenHands/issues/4538#issuecomment-2477294543,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BL3P7PQKBQZO74AJ6MIZOI32AT6D5AVCNFSM6AAAAABQP5ZOPSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZXGI4TINJUGM
.
You are receiving this because you were mentioned.Message ID:
@.***>


Translations using gettext PO

Translations can be added using gettext module so people can contribute translations in their native language

https://github.com/nlogozzo/NickvisionMoney/releases/tag/2022.11.0-beta2

@nlogozzo @zothma We should have two separate strings for "New": one for when it's referred to Group and one for Transaction since in some languages you translate them differently.

Also, for Group I would use a separate string too: in the shortcuts dialog it's better to use a plural form in my language.

Missing localization in string "Money Account (*.nmoney)" in open account dialog

Like Group, Income and outcome need two separate strings in my language: one for the Type in the transaction dialog and one for Overview.

Also, for Group I would use a separate string too: in the shortcuts dialog it's better to use a plural form in my language.

In some languages, both plural and singular form of group have the same word, like in Hindi

@securearth Yeah of course, you can still translate the strings the same way.

I just tested my Hindi translation and found out that you have hardcoded "Money", and added translation for "About", instead of using the string "About Money". In English, about is used before the app name, but in languages like Hindi, "बारे" is used after the app name, so it would be "Money बारे" or "Money के बारे में", but using the current schema, it is rendered as "बारे Money" and not "Money बारे". I think you should instead use the string "About Money" instead of hardcoding 'Money', you can add a comment there asking to not translate the word 'Money' and just keep it like "Money बारे" (generally whoever learns to translate, is taught on articles on Internet that as a convention you should not translate the app name).

FYI Please submit a PR with your translations by Nov 10, 2022 to be included in the V2022.11.0 stable release for this week.

@zothma Is also currently fixing the translation context with the changes mentioned here. Once that gets merged, I will be asking current PRs to update their translations to the new context before merging them :)

Thank you everyone for your help with translating this application, making it accessible to more people than ever before. A stable release will be released this week by Nov 10, 2022 with your translations :)
I'm closing this issue as completed since the translation infrastructure is complete.


刚开始运行正常也可以查询,然后python install steup.py就提示以下

Traceback (most recent call last):
File "/usr/local/bin/wafw00f", line 4, in
import('pkg_resources').run_script('wafw00f==2.1.0', 'wafw00f')
File "build/bdist.linux-x86_64/egg/pkg_resources/init.py", line 739, in run_script
File "build/bdist.linux-x86_64/egg/pkg_resources/init.py", line 1486, in run_script
pkg_resources.ResolutionError: No script named 'wafw00f'

Please use the issue template for pulling up new issues. Some info about the system (e.g. OS and platform) is required for troubleshooting issues.


Durable Objects example: Remove await from call to storage.put()?

Which Cloudflare product does this pertain to?
Durable Objects
Existing documentation URL(s)
https://developers.cloudflare.com/durable-objects/examples/build-a-counter/
What changes are you suggesting?
Near the bottom of the example is this line of code:
await this.state.storage.put("value", value);

Based on your explanation of Output Gates, I think the await at the start of the line here can be safely removed, right?
Additional information
No response

Addressed here: https://github.com/cloudflare/cloudflare-docs/pull/12047
Thank you!


Sometimes web pages does not load when in AP Mode, while Client Mode works as normal

First thing to check : DNS Queries from Mobile Phones may congest loop()
Possible solution : ?
What else to check ?

[ ] Add support for active low relays

Commenting out dnsServer.start(53, "*", apIP); fixes problem, clearly breaks Captive Portal feature.

dnsServer.setErrorReplyCode(DNSReplyCode::NoError); fixes this.

Still same

2914379 fixes this.


I suggest using grammar from RFC-5321 + RFC-6531 (specifically Mailbox) vs. RFC-5322

Since you're not attempting the validate email headers from the contents of messages (like From:) you probably want to validate using the SMTP grammar (RFC-5321) which would reject addresses with included white space and newlines, which I assume is what you (and most others) actually want.
You would also get better rules for the domain and IP address literal cases. And it would get rid of most of the obs_ stuff.
Why did you select RFC-5322 as the basis for your syntax? (vs. RFC-5321)

This is a good question. I think RFC 5322 allows plus addresses and quoted string etc. and I wanted to support those. The white space, you are mentioning, needs to be quoted AFAIR and thus can constitute completely valid email addresses.

I think RFC 5322 allows plus addresses and quoted string etc. and I wanted to support those.
As does RFC-5321. It allows the '+' char, and quoted white space in local-part. In fact, RFC-5321 allows every address that can be used on the public Internet to send or receive mail.

Feel free to submit a PR :)

I am starting to assume that the objective behind opening this issue has not driven by the urge of reporting a bug or improving this package. Thus, I am going to close this issue.


Added active requests and a basic array structure. Closes #10.

Ran locally. Really useful output:
  requests:
   [ { oncomplete: [Function: afterConnect],
       address: '<IP_ADDRESS>',
       port: 80,
       type: 'TCPConnectWrap' } ] }


FSI:Send-Selection shortcut not working on OSX

Hello,
it seems that the 'alt-enter' shortcut doesn't send the selection to FSI, but deletes the selection and insert a new line instead. That happens in OSX, in Windows there is no problem.
Output from the key binding resolver:

Also, out of curiosity, why is the 'send-line' mapped to alt-/ instead of alt-' (like in Visual Studio)? Is there any technical reason or just personal preference?

It was just my personal preference - it should be easy to change in Atom settings If You don't like it :)


Toolbox URL gitlab

Currently Repository.Gitlab.init () is setting gitlab URL like this:
"https://gitlab.freedesktop.org/{s}"

however this URL should be set in X11.zig and wayland.zig pckages

related PR: https://github.com/tiawl/toolbox/pull/46


Add sections to contributing, clarify CI/CD steps

Contributing DevOps updates
Checklist:
Before submitting your PR, please confirm that you have done the following:

[X] I have opened my PR against the staging branch, NOT against main
[X] I've run the relevant formatting and linting tools listed in the setup docs
[X] I have commented hard-to-understand areas in my code
[X] I've reviewed any merge conflicts to make sure they are resolved
[X] My changes generate no new warnings

Description
Added sections to part of contributing doc and itemized steps. Idea is for new devs to be able to easily understand flow from issue > prod.
Related Issue(s)
This PR addresses issue #634.
Type of change

[x] Bug fix
[ ] New feature
[ ] Breaking change

How Has This Been Tested?
N/A, seeking feedback on edits.

@nlebovits


improvment: Separate process initialization into a single method.

Current implementation will force any class inherit from emacsql-sqlite-connection create emacsql-sqlite process. please separate it into another method to make it customizable.

maybe it's better to make a superclass of emacsql-sqlite-connection and specialize process creation on different implementation

Don't worry about building on top of emacsql-sqlite, and especially
don't use inheritance. I only used eieio for the dynamic dispatch
(though it's since been replaced in Emacs by cl-generic) and its fancier
structs.
The only useful parts for you in that source file are the reserved
keywords, the :emacsql-types table, and maybe the condition alist, since
these are likely the same between the implementations. Just copy what
you need into your new source file. Maybe later they could go into a
common file required by both so that they could be kept in sync together
as SQLite changes.
However, if what you're trying to accomplish actually works, then it
would likely just replace the existing SQLite backend anyway.

On Wed, 28 Aug 2019 05:04:21 +0800,
Christopher Wellons wrote:

[1  <text/plain; UTF-8 (7bit)>]
[2  <text/html; UTF-8 (7bit)>]
Don't worry about building on top of emacsql-sqlite, and especially
don't use inheritance. I only used eieio for the dynamic dispatch
(though it's since been replaced in Emacs by cl-generic) and its fancier
structs.
The only useful parts for you in that source file are the reserved
keywords, the :emacsql-types table, and maybe the condition alist, since
these are likely the same between the implementations. Just copy what
you need into your new source file. Maybe later they could go into a
common file required by both so that they could be kept in sync together
as SQLite changes.
However, if what you're trying to accomplish actually works, then it
would likely just replace the existing SQLite backend anyway.
―
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks for your answer! :)


Bittrex no longer including updateExchangeState messages?

I'm not sure if this is the right place for this, but I have no idea where else to ask.  I've been doing development with this package against the Bittrex API/websocket endpoints all day.  I suddenly am no longer getting "updateExchangeState" messages via the websocket.  (I'm still receiving "updateSummaryState" messages just fine.)  I'm wondering if something changed or broke on their end, something broke in this package (I don't think that's the case since I tried various versions), or if perhaps I got throttled.

Never mind, I broke something on my end.  Some old code I rolled back to still works as expected.
I'll update this issue when I figure out what I broke.

Okay, I tracked this down, and I think it's worth reopening.  The documentation mentions that there's a connected serviceHandler.  I was using this for logging, but by doing so, it removed some built-in logic for subscribing to all the exchange state messages.  I also noticed that there is a reference to a bound service handler, but I don't see that being called anywhere.
It seems like there should a way to add a connected serviceHandler without losing the logic defined by calling websockets.subscribe(tickers).

the connected serviceHandler is firmly intertwined with the subscribe call in order to simlpyfy the process.
right at the moment you'll need to call the bare client and define 'connected' by yourself
var websocketsclient = bittrex.websockets.client();

websocketsclient.serviceHandlers.connected = function (conn) {}

It probably wouldn't be a bad idea to have an event emitter so people can perform their own logic on events without interrupting the normal logic. I assume this is what you're asking for @mhuggins?

@dparlevliet Exactly.

btw this has been implemented in https://github.com/dparlevliet/node.bittrex.api/issues/1


Proposal: Avoid passing the API KEY as ENV VAR

PROBLEM
Defining OPENAI_KEY as an env var, makes your chatgpt KEY available to any program.
SOLUTION
If instead we store the key in ~/chatgpt-shell-cli.apikey, the user will be able to manage file permissions.
Optionally, having a --update-key options could be a user friendly way to set the api key.

@Zeioth I left a comment to respond to the same issue in https://github.com/0xacx/chatGPT-shell-cli/issues/55 so I am closing this and the discussion can continue there. Thank you for the suggestion!


fix: patch version and run cargo update

fixes #156
relates to https://github.com/Homebrew/homebrew-core/pull/162831
cc @astrale-sharp

silly of me thank you!
had to yank that version so lets be careful!


Deploy Shaka Packager to the CI

As a developer I need to be able to run tests involving subtitle and audio track packaging on our CI agents.
Acceptance criteria

The shaka-package command can be run on each CI agent and returns a result.

Tasks

[ ] Add shaka-package command to the CI agents.

Follow-up
A follow-up for this task exists, see #499.

Just run the following:
$ mkdir ~/bin
$ cd ~/bin
$ curl -L -o shaka-packager https://github.com/shaka-project/shaka-packager/releases/download/v2.6.1/packager-osx-x64
$ chmod +x shaka-packager


prometheus: switch to Kubernetes 1.6 storage class specification

Ditching the alpha storage class annotation and using the 1.6 style specification instead brings the following benefits:

a standard way to specify the default provisioner
a mechanism to disble the dynamic provisioner

Unfortunately, go template makes the second one hacky.   See https://github.com/kubernetes/helm/issues/2600 for more details.   So instead of using an empty string to disable the dynamic provisioner, this PR uses "-".

/ok-to-test

/lgtm

Bumped to v4.0.0 since we've changed StorageClass behavior.


@xtina-starr => Migrate 'Clicked Gallery Website' event on mobile to 'Click' event

As per the discussion here, I'm migrating old event names to new ones. This PR should update the mobile partner page to send a click event from both mobile web/iOS app (eigen just uses WebView for it).

          2 Warnings

:warning:
Please include a PR summary

:warning:
Please assign someone to your PR

  Generated by :no_entry_sign: Danger

LGTM! I'll go ahead and merge.