cmd: {read,write}: Enable bounded access to RAM

The current motivation is to allow arbitrary writes to RAM for pre-loading data to be consumed by the secondary processor firmware.

I haven't looked at this closely, but from a brief skim I wonder if splitting it into multiple commits might make sense?  (And perhaps simplify review.)  In addition to the new {read,write} ram command support, it looks like there are also some more general code rearrangements included, like a change of opinions (?) about which direction of data transfer makes sense to call "in" vs. "out", and some changes to return-codes/errno conventions?  IMO it'd be nicer to split those out into their own commits, or if that's tricky for some reason a bit more explanation in the commit message could help.

Haha, this is why I added you on review :) I had a feeling I was pushing the boundaries a little bit too much with it. I'll rework it.

Ugh, it really is time to unravel all the command line parsing crimes.

@zevweiss if you have a moment to take another look, I think this is closer to merge-worthy.

The type ssize_t shall be capable of storing values at least in the
range [-1, {SSIZE_MAX}].

Interesting, hadn't been aware of that previously...hopefully we're paving the way for culvert to one day cleanly run on some truly obscure, bizarre architecture!
Anyway, looks alright to me now, just needs a little merge conflict resolution...


Charge customer profile - returning customer (and saved card)

The sample code here covers only a scenario when a customer profile and a customer payment profile are created.
What if I already have a customer profile id and a customer payment profile id?
How should I use the TransactionRequestType ?
From those ids I'm retrieving the customer profile and the customer profile id (when retrieving that data an instance of *MaskedType  is returned that is useless here), how can I set a customerProfileId and a customerPaymentProfileId in that object?

Hi @peppeocchi, you're absolutely right, that sample was not even demonstrating the correct concept.  I've updated it to simply charge a payment profile : https://github.com/AuthorizeNet/sample-code-php/blob/master/PaymentTransactions/charge-customer-profile.php
Thanks so much for the feedback,
Brian


Incomplete dependencies for types

Expected Behavior
Packages to correctly state their dependencies.
For example:

@jimp/bmp depends on @jimp/core
@jimp/plugin-blit depends on @jimp/core.

Current Behavior

@jimp/bmp does not depend on @jimp/core
@jimp/plugin-blit does not depend on @jimp/core

Failure Information (for bugs)
This is causing TypeScript errors, depending on how the packages are linked.
Note that I don't believe these packages have runtime dependencies, but they do have type dependencies in the TS declarations.
Steps to Reproduce
Screenshots
Context

Jimp Version:
Operating System:
Node version:

Failure Logs

@pauldraper Would you mind submitting a PR to fix this?

I think all of these have been fixed now


Allow passing config to jsdom.env

Example with jsdom:
var jsdom = require("jsdom");

jsdom.env({
  userAgent: 'Some user agent'
});

Possible solution

require('node-browser-environment')({
  // props: ['window', 'document', 'navigator'],
  userAgent: 'Some user agent'
});

@bfred-it Nice idea, I think it would be better to use a separate object for the jsdom config rather than mixing it in with our own though.
We could either have:
require('node-browser-environment')(['window'], true, { userAgent: 'Some user agent' });

Which would keep current API compatibility. Or:
require('node-browser-environment')({
  properties: ['window'],
  overwrite: true,
  jsdomConfig: {
    userAgent: 'Some user agent'
  }
});

Which is more a bit more readable but also much more verbose and is backwards incompatible. We also then loose the super simple syntax of:
require('node-browser-environment')(['window']);

Which I really like and I think most people will use. Thoughts?

You can support both signatures:

nodeBrowserEnviroment(<array> props[, <bool> override])
nodeBrowserEnviroment(<object> config)

Yeah good point. Tbh a breaking change might not be a bad thing, I don't really like how you need to specify props to be able to set the second two args.
I might change it to just an array of props or a config object. That way we keep the simple array syntax and more complex use cases can use the config object. Sound good?

Sounds good to me 👍

Ok, I decided to remove the overwrite option, I'm checking any conflicts between the jsdom window properties and global node properties when the module is loaded and blacklisting them to stop weird bugs. This means all the other properties can be safely overwritten every time so there's no need for an option to opt in.
I've replaced the overwrite arg with the jsdom config arg so it can be used like this:
require('node-browser-environment')(['window'], { userAgent: 'My User Agent' });

It can also be used on it's own without the properties arg:
require('node-browser-environment')({ userAgent: 'My User Agent' });

It's a breaking API change so I've published as v2. You'll need to manually bump the version in your package.json to get the new functionality.


After the training is finished （reach the step limit）, the program remains running instead of exit.

ctrl + c can not fully terminate all the python (sub) processs


Buble + Buba

What do you guys think of switching to using Buble + Buba for this repo? It seems like we could gain from the bytes saved with Bublé and then instead of running babel-node or using babel-register we can use Buba for the tests.. just a thought
/cc @briancavalier @TylorS

👍 I could see this being a path to ES6 for mostjs core as well.

i think we can close this issue?

Yep :)


Invert lat lon "Transformer"

Hello, using the "Transform" function, I realized that the input parameters were reversed, if you enter "x1, x2" the output positions do not match, while reversing the order of the inputs, "y1, y2", the output positions match the input positions (as you can see in the figure, the coordinates are different by changing the order of the inputs)
from pyproj import Transformer
inProj = 'epsg:4326'
outProj = 'epsg:32632'
x1, y1 = 12.48497983, 41.91058812
transformer = Transformer.from_crs(inProj, outProj)
lon, lat = transformer.transform(x1, y1)
print("bug_lon :", lon, "bug lat :", lat)
transformer_corr = Transformer.from_crs(inProj, outProj)
lon_corr, lat_corr = transformer.transform(y1, x1)
print("lon_correct :", lon_corr, "lat_correct :", lat_corr)

The documentation for migrating from pyproj 1 to pyproj 2 doesn't mention this at all and it's suggested code modification leads to bugs. Specifically the current example gives the example that the order of input parameters and output coordinates is the same as before. It is not.
I suggest updating that example to pass named variables as inputs and capture the outputs in named variables too for clarity.
https://pyproj4.github.io/pyproj/stable/gotchas.html#upgrading-to-pyproj-2-from-pyproj-1

Good suggestion. A PR with that addition is welcome.


[FEATURE] Liking polls functionality

Description
There will be an icon beside the copy icon for liking the posts, so that the users can like the post if they love it.
Screenshots
No response

Hey @Arnabdaz 👋, please assign me this issue.


Adding CI/CD security features and version CLI command

I worked on the project on my own fork https://github.com/louison77/k8s-kms-plugin.
Indeed, I did the fork before renaming the original draft project from https://github.com/ThalesGroup/k8s-kms-plugin to https://github.com/ThalesGroup/k8s-kms-plugin-tmp, and before doing a clean move of the original k8s-kms-plugin project from its original repo on https://github.com/orgs/ThalesIgnite to its new repo https://github.com/ThalesGroup.
Therefore, the states of commit hashes was messed up, and the pull request from https://github.com/louison77/k8s-kms-plugin was harder to merged. So we did a clean fork on @Nicolas-Peiffer profile, and incorporated the contributions from @louison77.
Proposed Changes

Github workflow file using Goreleaser tool for generating a release.
Publish action file releasing artifacts with Goreleaser.
Automate the publication of container images with ko-build tool integrated into Goreleaser.
Signing of binary and container images artifacts.
Generation of SLSA level 3 attestations for both kind of artifacts.
Verification of SLSA  images attestations.
Version CLI command for k8s-kms-plugin.
Gitlab-ci file equivalent for the Github workflow.
Detailed explanations of the changes in the Readme.

Types of Changes
These changes introduce a new feature with is a Github CI/CD workflow allowing the creation of release including artifacts signatures, provenance attestations.
Verification
These changes can be verified by tagging a commit and push the tag into Github. This tag will trigger the workflow which will creating release. For signing the artifacts, it is important to go on the Github project in the workflow previously triggered to sign manually the artifacts with OIDC authentication.
A verification of the provenance attestation is done in the pipeline but the detailed commands to verify the signatures are explained in the Readme file.
Testing
As it is CI/CD feature, there are no tests that covered it. But different examples are present on the fork project: https://github.com/louison77/k8s-kms-plugin.
Linked Issues
User-Facing Change
New command version:
k8s-kms-plugin version

{
  "major": 0,
  "minor": 6,
  "version": "0.6.0",
  "commitIdLong": "98026fbd433da5a81b5793db9d69f6b6bbddb895",
  "commitIdShort": "98026fbd",
  "goVersion": "go version go1.22.5 linux/amd64",
  "date": "2024-08-09T11:17:14+02:00",
  "plaform": "x86_64"
}

Further Comments

Great contribution ! Thank you. However, in case of no tag for a given build, a developer can end with this error :
./k8s-kms-plugin version
panic: 67dde6b is not in dotted-tri format
goroutine 1 [running]:
github.com/coreos/go-semver/semver.Must(...)
        /go/pkg/mod/github.com/coreos/go-semver@v0.3.1/semver/semver.go:65
github.com/coreos/go-semver/semver.New({0xbce8b8?, 0x0?})
        /go/pkg/mod/github.com/coreos/go-semver@v0.3.1/semver/semver.go:49 +0x34
github.com/ThalesGroup/k8s-kms-plugin/cmd/k8s-kms-plugin/cmd.CreateJsonVersion()
        /go/k8s-kms-plugin/cmd/k8s-kms-plugin/cmd/version.go:52 +0x25
github.com/ThalesGroup/k8s-kms-plugin/cmd/k8s-kms-plugin/cmd.generateOutput()
        /go/k8s-kms-plugin/cmd/k8s-kms-plugin/cmd/version.go:94 +0xaf
github.com/ThalesGroup/k8s-kms-plugin/cmd/k8s-kms-plugin/cmd.init.func8(0xc0000df300?, {0xad76d4?, 0x4?, 0xad7670?})
        /go/k8s-kms-plugin/cmd/k8s-kms-plugin/cmd/version.go:111 +0x78
github.com/spf13/cobra.(*Command).execute(0xfd7480, {0x1046e80, 0x0, 0x0})
        /go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:987 +0xa91
github.com/spf13/cobra.(*Command).ExecuteC(0xfd6060)
        /go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:1115 +0x3ff
github.com/spf13/cobra.(*Command).Execute(...)
        /go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:1039
github.com/ThalesGroup/k8s-kms-plugin/cmd/k8s-kms-plugin/cmd.Execute()
        /go/k8s-kms-plugin/cmd/k8s-kms-plugin/cmd/root.go:82 +0x10c
main.main()
        /go/k8s-kms-plugin/cmd/k8s-kms-plugin/main.go:29 +0xf

We should always have an output for the command version, even with no version number (or at least a 'snapshot' information in the version name), rather than a stack trace.

This has been fixed by https://github.com/ThalesGroup/k8s-kms-plugin/pull/39/commits/2a9cff09788284b029cbdc0b37d99d0b3ad2775a
Now the k8s-kms-plugin version command should be able to work even in when goreleaser is ran in --snapshot mode during developement. Now the k8s-kms-plugin version will be able to handle when the result of command git describe --tags --always does not match a semantic version tag.
git describe --tags --always
1096c2e

Notice 1096c2e does not follow semantic versioning.
$LDFLAGS should look like this:
echo $LDFLAGS
-X 'github.com/ThalesGroup/k8s-kms-plugin/pkg/version.RawGitDescribe=1096c2e' -X 'github.com/ThalesGroup/k8s-kms-plugin/pkg/version.GitCommitIdLong=1096c2ea3777b389583b658fe6919645334bcdf6' -X 'github.com/ThalesGroup/k8s-kms-plugin/pkg/version.GitCommitIdShort=1096c2ea' -X 'github.com/ThalesGroup/k8s-kms-plugin/pkg/version.GoVersion=go version go1.23.4 linux/amd64' -X 'github.com/ThalesGroup/k8s-kms-plugin/pkg/version.BuildPlatform=x86_64' -X 'github.com/ThalesGroup/k8s-kms-plugin/pkg/version.BuildDate=2024-12-16T16:46:15+01:00' -X 'github.com/ThalesGroup/k8s-kms-plugin/pkg/version.GitCommitTimestamp=2024-12-16T16:04:01+01:00'

Note: This particular git describe --tags --always example starts with a figure 1096, which makes the "github.com/hashicorp/go-version" module thinks this 1096 is a Major version. It is actually not a semantic version string. This is an edge case of the "github.com/hashicorp/go-version".
JSON pretty print
./dist/k8s-kms-plugin-linux-amd64_SNAPSHOT-1096c2e version -o json

{
  "k8s-kms-plugin-cli": {
    "major": 1096,
    "minor": 0,
    "patch": 0,
    "version": "1096c2e",
    "gitCommitIdLong": "1096c2ea3777b389583b658fe6919645334bcdf6",
    "gitCommitIdShort": "1096c2ea",
    "gitCommitTimestamp": "2024-12-16T16:04:01+01:00",
    "goVersion": "go version go1.23.4 linux/amd64",
    "buildDate": "2024-12-16T16:46:15+01:00",
    "buildPlatform": "x86_64"
  }
}

JSON without pretty print
./dist/k8s-kms-plugin-linux-amd64_SNAPSHOT-1096c2e version -o json --pretty=false

{"k8s-kms-plugin-cli":{"major":1096,"minor":0,"patch":0,"version":"1096c2e","gitCommitIdLong":"1096c2ea3777b389583b658fe6919645334bcdf6","gitCommitIdShort":"1096c2ea","gitCommitTimestamp":"2024-12-16T16:04:01+01:00","goVersion":"go version go1.23.4 linux/amd64","buildDate":"2024-12-16T16:46:15+01:00","buildPlatform":"x86_64"}}

YAML
./dist/k8s-kms-plugin-linux-amd64_SNAPSHOT-1096c2e version -o yaml

k8s-kms-plugin-cli:
  buildDate: "2024-12-16T16:46:15+01:00"
  buildPlatform: x86_64
  gitCommitIdLong: 1096c2ea3777b389583b658fe6919645334bcdf6
  gitCommitIdShort: 1096c2ea
  gitCommitTimestamp: "2024-12-16T16:04:01+01:00"
  goVersion: go version go1.23.4 linux/amd64
  major: 1096
  minor: 0
  patch: 0
  version: 1096c2e

Simple version STD OUT
 ./dist/k8s-kms-plugin-linux-amd64_SNAPSHOT-1096c2e version
k8s-kms-plugin: v1096.0.0

pretty print flag only applies to JSON YAML
./dist/k8s-kms-plugin-linux-amd64_SNAPSHOT-1096c2e version -o yaml --pretty=false
2024/12/16 15:57:01 ERROR Flag --pretty must NOT be used when output format is yaml. --pretty is only used when output format is json

only support json and yaml as version output format
./dist/k8s-kms-plugin-linux-amd64_SNAPSHOT-1096c2e version -o xml
2024/12/16 15:58:37 ERROR Invalid output format. Must be json or yaml. output=xml
k8s-kms-plugin: v1096.0.0

Here is another example:
git describe --tags --always
a289339

a289339 is not matching semantic versioning. "github.com/hashicorp/go-version" will parse this and detects it is not valid semver. So the output of major.minor.patch is arbitrary set to 0.0.0.
./dist/k8s-kms-plugin-linux-amd64_SNAPSHOT-a289339 version
2024/12/16 16:03:59 ERROR Raw git describe --tags --always version is not parsable as semantic versioning. Set major, minor and patch to 0  raw_git_describe=a289339 error="Malformed version: a289339"
k8s-kms-plugin: v0.0.0

./dist/k8s-kms-plugin-linux-amd64_SNAPSHOT-a289339 version -o json
2024/12/16 16:04:33 ERROR Raw git describe --tags --always version is not parsable as semantic versioning. Set major, minor and patch to 0  raw_git_describe=a289339 error="Malformed version: a289339"

{
  "k8s-kms-plugin-cli": {
    "major": 0,
    "minor": 0,
    "patch": 0,
    "version": "a289339",
    "gitCommitIdLong": "a289339fd186df0b6f00a69681ce0ab9710b941c",
    "gitCommitIdShort": "a289339f",
    "gitCommitTimestamp": "2024-12-16T17:01:45+01:00",
    "goVersion": "go version go1.23.4 linux/amd64",
    "buildDate": "2024-12-16T17:02:02+01:00",
    "buildPlatform": "x86_64"
  }
}

If the git describe --tags --always follows semver, then
Example
git describe --tags --always
0.1.6-56-g888baf5

k8s-kms-plugin version -o json
{
  "k8s-kms-plugin-cli": {
    "major": 0,
    "minor": 1,
    "patch": 6,
    "version": "0.1.6-55-g91fe0ba",
    "gitCommitIdLong": "91fe0bacef5b6df3532f9e0d7e7b33fc7a69e7b0",
    "gitCommitIdShort": "91fe0bac",
    "gitCommitTimestamp": "2024-12-16T15:47:10+01:00",
    "goVersion": "go version go1.23.4 linux/amd64",
    "buildDate": "2024-12-16T16:06:45+01:00",
    "buildPlatform": "x86_64"
  }
}

Also check goreleaser DEPRECATED recipe :
# goreleaser release --clean --snapshot --skip validate,publish,sign

  • only configurations files on  version: 2  are supported, yours is  version: 0 , please update your configuration
  • skipping announce, publish, sign and validate...
  • cleaning distribution directory
  • loading environment variables
  • getting and validating git state
    • ignoring errors because this is a snapshot     error=git doesn't contain any tags. Either add a tag or use --snapshot
    • git state                                      commit=67dde6bcc03533e9d05f5a15aedcbfe7e1011ed1 branch=master current_tag=v0.0.0 previous_tag=<unknown> dirty=false
    • pipe skipped                                   reason=disabled during snapshot mode
  • parsing tag
  • setting defaults
    • DEPRECATED:  snapshot.name_template  should not be used anymore, check https://goreleaser.com/deprecations#snapshotnametemplate for more info
  ⨯ release failed after 0s                          error=template: failed to apply "{{ .Env.GITHUB_REPOSITORY_OWNER }}": template: failed to apply "{{ .Env.GITHUB_REPOSITORY_OWNER }}": map has no entry for key "GITHUB_REPOSITORY_OWNER"

DEPRECATED:  snapshot.name_template is fixed by https://github.com/Nicolas-Peiffer/k8s-kms-plugin/commit/61b77d2da399a75dd740ade63d54278f646426d2.
And you need to provide a GITHUB_REPOSITORY_OWNER environment variable is you want to run goreleaser locally, since this value is actually set by Github Actions.


Please update PLOS Currents and PLOS Clinical Trials to show they are OA

Hello!
This is a very interesting project - I saw it on Hacker news.
Please can you update the journals listed in the title to show they are OA?
Yours,
Elliot
COI statement: I used to be employed by PLOS, but no longer.

Thanks @elliotrpage for reporting this issue. To illustrate the issue, here's a screenshot from the Journal Coverage Browser:

As reported, PLOS Currents and PLOS Clinical Trials are incorrectly not considered open access. We get our journal information from dhimmel/journalmetrics, which extracts data from Scopus. I did a Scopus search for PLOS-published journals to confirm that this is an upstream issue that hasn't yet been resolved:

In Scopus_Source_List.xlsx, the OA columns full column name is:

Open Acces status, i.e., registered in DOAJ and/or ROAD. Status April 2017

If we search DOAJ or ROAD, we see that  PLOS Currents and PLOS Clinical Trials are not included.
The ideal solution would therefore be to file an issue with ROAD & DOAJ to add these missing journals. This change will likely take years to trickle down to projects such as this... but given the burden of maintaining and implementing patches, I'm not to keen on fixing upstream data issues in this repo.
@elliotrpage, let us know if you make a ROAD or DOAJ request. I'd be interested to hear how easy or hard the process is.

Closing this issue as "Won't Fix" as these are upstream issues.


Add ImapEmail helper

PR includes:

New ImapEmail helper.

Based on imap-simple
Refactored for ES7 usage
Useful for email-related testing

Thanks, this looks nice but could you publish this as a standalone package?
I think we can create a wiki page so everyone could list their helpers


Chrome Debugger Console Unresponsive [0.24.1]

I'm surprised to not have seen anyone else complain about this yet, but yesterday we upgraded to react native 0.24.1 and now when we debug using chrome the console becomes unresponsive. Often, the console will close, too.
node 5.9.1
npm 3.7.3
Not sure what other information is relevant to this issue.
Please let me know! And thank you in advanced.

Does it just freeze w/o doing anything? Or during console.log? Or when it hits the breakpoint? When I was releasing 0.25-rc I tested all these things and didn't find any problems at all. Might be something related to the way your application works - hence extra information required.

So, it logs, initially, and then freezes so that you cannot click into the console nor receive additional logging.

we're having the same problem with 0.24.0 also if that helps.. we'll of course be looking into this ourselves as well.

Seeing the same behavior with 0.24.1

Seeing the same behavior with 0.30.0

Seeing the same behavior with 0.35.0

Seeing the same behavior with 0.37.0

Closing this issue because it has been inactive for a while. If you think it should still be opened let us know why.


add success message box with commit hash

fixes #3560
The commit hash is shown in a message box. Link to the commit is prepared but not yet implemented

@sbcgua any comments for the html/css?

The basic idea is to have a link to jump to jump to commit/branch/... of the online repo provider, so html would be cool.
And maybe there will be further stuff like create PR, URL to clipboard,....
Additionally I like the idea of actions for (error) messages and get rid of SAP GUI MESSAGE...
It would also make sense to have a global/general message container to hold several info/success/warning messages - some kind of current log function.
But start small...

The basic idea is to have a link to jump to jump to commit/branch/

Why not adding a link to the last commit at the repo header level ? The message will disappear ...

btw the "disappearing" is a weak point of html messages - e.g. with errors I can do some actions at the page and it does not disappear - this is very unintuitive and confusing (although the tech itself is very cool)

OK - I will remove HTML message and show the hash in SAP message. and also adjust the repo log handling a bit

ZCL_ABAPGIT_LOG now use multiton for repo logs.
success message now shows commit hash as standard message

I'll close this PR and split it into 3 smaller ones


Implement for puppeteer

Can you please implement the same for chrome puppeteer?

I don't personally use Puppeteer so it isn't something I would prioritize, but you are welcome to fork the project and create auto-puppeteer! :-)


Create system plugin

The chain plugin uses tables defined by the system contract, e.g. the upcoming changes in #3087. As per Dan, code which uses these tables should move to a new system plugin.

@tbfleming Is this issue still relevant, or has it become overcome by events?

It's OBE


recoverysigner/db: add signing keys migration

PR Checklist
PR Structure

[x] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[x] This PR's title starts with name of package that is most changed in the PR, ex.
services/friendbot, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.
[ ] I've updated any docs (developer docs, .md
files, etc... affected by this change). Take a look in the docs folder for a given service,
like this one.

Release planning

[ ] I've updated the relevant CHANGELOG (here for Horizon) if
needed with deprecations, added features, breaking changes, and DB schema changes.
[ ] I've decided if this PR requires a new major/minor version according to
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.

What
This PR adds a new signers table and its audit counterpart in order to prepare for having unique signing keys per registered account.
Why
The application uses a single signing key for all accounts that are registered. The issue with this is that anyone who knows that single signer can determine what accounts are registered with a recoversigner server. This public association may be undesirable for a user using a recoverysigner.
Known limitations
N/A

The first part of coding is here: https://github.com/stellar/go/pull/2659/
How did you turn a PR back to a draft? I know this is a new feature, but I couldn't find the button to do it.


Set ViUR session cookie only when necessary

There are considerations about providing a ViUR system that does not rely on a cookie that is always set.
An idea of this consideration and little discussion was, that ViUR should only set a session cookie in case something is written into the session. If this was once the case, the session should be kept, even if its content is being cleared.
This would allow to provide ViUR systems that don't use cookies, and only sets the cookie when really necessary.

Fixed by #1277


Calling Subscription.setOptions won't update the maxStreams count

Due to other recent changes (https://github.com/googleapis/nodejs-pubsub/issues/1712), the MessageStream class will only decide how many streams to use when it's constructed, so this setting will only work if passed to pubsub.subscription(). MessageStream.fillStreams() needs to pay attention to those config changes.

There's a fix in progress for this one.

We've decided not to pursue this fix, so I'll give some more context on the issue. Currently createSubscription() automatically makes a Subscription object and doesn't allow you to pass options for things like maxStreams. So the only way to create and also set that is to create, close, then open again with options.
Will be looking for another way to handle this case.

Just closing this in favour of v2 changes.


Document and make public add_my_tensors_from_gate

This is a (non-default) fallback for the tensor protocol. xref #503

note: now named _my_tensors_from_gate


link to release notes from upgrade docs

this pr adds the last para here:

Codecov Report

Merging #5308 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #5308      +/-   ##
============================================
- Coverage     82.77%   82.66%   -0.11%
+ Complexity    11040    11025      -15
============================================
  Files          1328     1328
  Lines         44861    44861
  Branches       5624     5624
============================================
- Hits          37132    37086      -46
- Misses         5132     5167      +35
- Partials       2597     2608      +11

Impacted Files
Coverage Δ
Complexity Δ

...exceptions/GroupByOnArrayUnsupportedException.java
66.66% <0%> (-33.34%)
1% <0%> (-1%)

...rc/main/java/io/crate/analyze/UnboundAnalyzer.java
70% <0%> (-20%)
2% <0%> (ø)

...o/crate/analyze/SafeExpressionToStringVisitor.java
83.33% <0%> (-16.67%)
7% <0%> (-1%)

...in/java/io/crate/data/CollectingBatchConsumer.java
69.23% <0%> (-15.39%)
4% <0%> (-1%)

...tor/transport/distributed/SingleBucketBuilder.java
71.42% <0%> (-14.29%)
4% <0%> (-1%)

...ration/collect/collectors/OrderedDocCollector.java
90% <0%> (-10%)
5% <0%> (-1%)

...peration/collect/BatchIteratorCollectorBridge.java
65.78% <0%> (-7.9%)
2% <0%> (ø)

.../distributed/TransportDistributedResultAction.java
70.31% <0%> (-7.82%)
7% <0%> (-1%)

core/src/main/java/io/crate/types/ArrayType.java
73.84% <0%> (-7.7%)
24% <0%> (-2%)

...crate/executor/transport/TransportShardAction.java
90% <0%> (-7.5%)
9% <0%> (-1%)

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 092cdbc...bda7335. Read the comment docs.


Macro produces declaration incompatible with GCC -Wstrict-prototypes option

We use GCC's -Wstrict-prototypes option in our project. However, it leads to issue a diagnostic about one of the declarations produced by the __flatcc_basic_scalar_accessors_impl macro:
/work/flatcc/include/flatcc/flatcc_endian.h:80:41: error: function declaration isn’t a prototype [-Werror=strict-prototypes]
  __flatcc_define_basic_scalar_accessors(flatbuffers_, flatbuffers_endian)
                                         ^
/work/flatcc/include/flatcc/flatcc_accessors.h:13:22: note: in definition of macro ‘__flatcc_basic_scalar_accessors_impl’
 static inline size_t N ## __size()                                          \
                      ^
/work/flatcc/include/flatcc/flatcc_accessors.h:70:1: note: in expansion of macro ‘__flatcc_define_integer_accessors_impl’
 __flatcc_define_integer_accessors_impl(N, T, W, E)
 ^
/work/flatcc/include/flatcc/flatcc_accessors.h:76:1: note: in expansion of macro ‘__flatcc_define_integer_accessors’
 __flatcc_define_integer_accessors(NS ## TN, T, W, E)
 ^
/work/flatcc/include/flatcc/flatcc_accessors.h:82:1: note: in expansion of macro ‘__flatcc_define_basic_integer_accessors’
 __flatcc_define_basic_integer_accessors(NS, char, char, 8, E)               \
 ^
/work/flatcc/include/flatcc/flatcc_endian.h:80:2: note: in expansion of macro ‘__flatcc_define_basic_scalar_accessors’
  __flatcc_define_basic_scalar_accessors(flatbuffers_, flatbuffers_endian)
  ^

The problem is that static inline size_t N ## __size() looks like it defines a zero-argument function, but that's only in C++. In C, that declares a function taking any number of arguments, which probably isn't the intention.
The fix is to add void in the middle: static inline size_t N ## __size(void). (C++ will continue to recognize it as a zero-argument function, just as before.)

I'll admit I have not carefully guarded against this problem, but I do not understand why the source is incorrect here.
The function is a definition, not a declaration (i.e. prototype with empty args). In C it is valid to have a function definition with empty args.
As an aside, the __size() can probably be replaced with a sizeof() call now that FlatBuffers no longer support empty structs.

For reference:
https://softwareengineering.stackexchange.com/a/287002
At least for C11:

An empty list in a function declarator that is part of a definition of that function specifies that the function has no parameters.

Clang raises no errors or warnings with -Wstrict-prototypes
While I'd be happy to fix this issue, the flatcc policy towards gcc warnings is moving towards disabling offending warnings in CMake, because gcc is starting to make warnings as errors that are near impossible to honour in portable code and because it keeps breaking code with every new release for no good reason. See also #120.

Could you please check commit cd97b11
This should fix __size() and also _get_len() in runtime library and generated code.
I enabled -Wstrict-prototype for clang but not for gcc because there might be code in the flatcc compiler that gcc would happily break which I am not inclined to deal with considering that it is perfectly valid C11 code. This passes all builds  that I have access to.

I see you're right about it being a definition. I wasn't aware of the "declaration as definition" exception to the "empty parameter list" rule, but I must also admit I didn't look very closely at the supposedly offending code because I've encountered the same warning so many other times for legitimate cases that I thought I already understood the issue.
Your changes look good to me.
I thought the exception to the rule might be something new for C11, which my organization doesn't use yet, but I see identical wording in the C90 and C99 standards, so it seems GCC's warning is just plain wrong in this case. That's ... frustrating. Thanks for handling it so graciously.


Notification on data upload and save

Give more feedback (popup or banner) as a user uploads data and saves it to verify it worked or show an error on failure.

https://github.com/Kitware/tangelohub/pull/139 addresses this issue.


catinabox project

Coverage increased (+5.7%) to 42.529% when pulling 47f4f15bb6f534086c38f322e726e9d66d13ceef on GalRavil:tutorial_wip into cad3d2ba400a71b24a6aee9b7ecf44938b97fa0a on keeppythonweird:master.

Coverage increased (+10.3%) to 47.126% when pulling 528b34a1a3ef1747d8df77572dd8ba3dfa5f7d01 on GalRavil:tutorial_wip into cad3d2ba400a71b24a6aee9b7ecf44938b97fa0a on keeppythonweird:master.

Coverage increased (+10.3%) to 47.126% when pulling 3acb913981185e727f268a999f7af22423b0979a on GalRavil:tutorial_wip into cad3d2ba400a71b24a6aee9b7ecf44938b97fa0a on keeppythonweird:master.

Coverage increased (+23.0%) to 59.77% when pulling 226e14c8685203fbfca515cff1e4ec745a687198 on GalRavil:tutorial_wip into cad3d2ba400a71b24a6aee9b7ecf44938b97fa0a on keeppythonweird:master.


PlaceAndBreakProtection not paying after CD

So i have set this to true in the config
PlaceAndBreakProtection: true
when this is set to true if the item i place is on the  restricted blocks config i just get the message that i need to wait X secs before i get paid.  however i never got paid for any of those blocks i even made sure that the cool down time had already passed and that the payout time had already passed too.
Am i using the feature incorrectly or is it a bug?
info you might need:
running on spigot-1.11.2
plugin version Jobs3.8.1
i have vault and core protection installed
The general config is uploaded below ( i changed the yml into txt so i can upload)
generalConfig.txt
Thanks in advance.

it seems as though in order to get paid for placing a restricted block you have to destroy it and put it again after the cool down has passed to get paid. the break protection seems to be working fine though.

Core protection is no longer supported as it was making more issues than solving. Currently there is build in block protection and some fixes will be added with next build too.


Use azure-sdk-for-net-track2 for validation

No. I've got an email out on this and just CC'd you.

And since you responded first, I'm going to reassign the other two changes (all in different branches) to you. Congrats. 🙂

@lmazuel the second attempt after @ShivangiReja's changes seems to have worked, but I'm not sure why it didn't update the checks: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1519441&view=logs&j=f5934c1f-9ec9-5119-b2dd-43d5040d4468
Could you help merge this?


fatal error: string_view: No such file or directory

Thanks for participating in the TVM community! We use https://discuss.tvm.ai for any general usage questions and discussions. The issue tracker is used for actionable items such as feature proposals discussion, roadmaps, and bug tracking.  You are always welcomed to post on the forum first :smile_cat:
Issues that are inactive for a period of time may get closed. We adopt this policy so that we won't lose track of actionable issues that may fall at the bottom of the pile. Feel free to reopen a new one if you feel there is an additional problem that needs attention when an old one gets closed.
Expected behavior
I want to build from tvm source code, but when I conduct: make -j4, some errors raise.
Actual behavior

error message:
/opt/SparseMatrixAnalysis/tvm/include/tvm/runtime/container/string.h:40:23: fatal error: string_view: No such file or directory
Environment
linux-ubuntu x86_64, gcc (GCC) 8.1.0
Steps to reproduce
Triage
Please refer to the list of label tags here to find the relevant tags and add them below in a bullet format (example below).

needs-triage

@yizhihenpidehou You should update the GCC version. std::string_view is a C++17 feature and GCC 8 did not support it.

@yizhihenpidehou You should update the GCC version. std::string_view is a C++17 feature and GCC 8 did not support it.

Thanks! I upgrade the GCC to 10.2 which seem to support c++17, but I still got the similar error.

When you upgraded the GCC version, are you now compiling with the stdlib implementation provided by the new GCC version?  This may require re-running cmake, if the old stdlib implementation is saved in CMakeCache.txt.

When you upgraded the GCC version, are you now compiling with the stdlib implementation provided by the new GCC version? This may require re-running cmake, if the old stdlib implementation is saved in CMakeCache.txt.

I do not find 'stdlib' thing in  CMakeCache.txt, and my gcc version is shown below, my operate system is ubuntu16.0.4

Can you show the output from the following commands?

make VERBOSE=1: Show the full command used to compile the analyzer.cc file
which g++: Where the g++ executable is located.
echo | g++ -xc++ -E -v -: Print out the defaults used by g++.  You'll want to look at the lines after #include <...> search starts here to see if it is looking for the new stdlib implementation.
ldconfig --print-cache | grep libstdc: Whether the linker is configured to find the new stdlib implementation.
echo LD_LIBRARY_PATH=$LD_LIBRARY_PATH: Whether the LD_LIBRARY_PATH is used to override the settings from ldconfig.

It's possible that the newer version of g++ is still using the stdlib headers provided by the system's default version of g++, and these should help in determining if that's the case.

root@ubuntu:/opt/SparseMatrixAnalysis/tvm# make VERBOSE=1
Re-run cmake no build system arguments
-- Forbidding undefined symbols in shared library, using -Wl,--no-undefined on platform Linux
-- Build with RPC support...
-- Build with Graph Executor support...
-- Build with profiler...
-- Build with AOT Executor support...
-- Could NOT find GTest (missing: GTEST_LIBRARY GTEST_INCLUDE_DIR GTEST_MAIN_LIBRARY)
-- Build Alloc alignment set to 64
-- Didn't find the path to CCACHE, disabling ccache
-- VTA build with VTA_HW_PATH=/opt/SparseMatrixAnalysis/tvm/3rdparty/vta-hw
-- Build VTA runtime with target: sim
-- Build with contrib.random
-- Build with contrib.sort
-- Build with contrib.hybriddump
-- Git found: /usr/bin/git
-- Found TVM_GIT_COMMIT_HASH=4330c110550242571da017a1b15ae0b765723ae8
-- Found TVM_GIT_COMMIT_TIME=2024-07-28 10:02:22 +0530
-- Could NOT find LIBBACKTRACE (missing: LIBBACKTRACE_STATIC_LIBRARY LIBBACKTRACE_INCLUDE_DIR)
-- Building libbacktrace from 3rdparty/libbacktrace
-- Building with TVM Map...
-- Build with thread support...
-- Added "-fuse-ld=lld" to linker flags
-- Build without FlashInfer
-- Configuring done
-- Generating done
-- Build files have been written to: /opt/SparseMatrixAnalysis/tvm/build
make[1]: Entering directory '/opt/SparseMatrixAnalysis/tvm/build'
/opt/cmake-3.18.0/bin/cmake -P /opt/SparseMatrixAnalysis/tvm/build/CMakeFiles/VerifyGlobs.cmake
/opt/cmake-3.18.0/bin/cmake -S/opt/SparseMatrixAnalysis/tvm -B/opt/SparseMatrixAnalysis/tvm/build --check-build-system CMakeFiles/Makefile.cmake 0
/opt/cmake-3.18.0/bin/cmake -E cmake_progress_start /opt/SparseMatrixAnalysis/tvm/build/CMakeFiles /opt/SparseMatrixAnalysis/tvm/build//CMakeFiles/progress.marks
make  -f CMakeFiles/Makefile2 all
make[2]: Entering directory '/opt/SparseMatrixAnalysis/tvm/build'
make  -f CMakeFiles/project_libbacktrace.dir/build.make CMakeFiles/project_libbacktrace.dir/depend
make[3]: Entering directory '/opt/SparseMatrixAnalysis/tvm/build'
cd /opt/SparseMatrixAnalysis/tvm/build && /opt/cmake-3.18.0/bin/cmake -E cmake_depends "Unix Makefiles" /opt/SparseMatrixAnalysis/tvm /opt/SparseMatrixAnalysis/tvm /opt/SparseMatrixAnalysis/tvm/build /opt/SparseMatrixAnalysis/tvm/build /opt/SparseMatrixAnalysis/tvm/build/CMakeFiles/project_libbacktrace.dir/DependInfo.cmake --color=
make[3]: Leaving directory '/opt/SparseMatrixAnalysis/tvm/build'
make  -f CMakeFiles/project_libbacktrace.dir/build.make CMakeFiles/project_libbacktrace.dir/build
make[3]: Entering directory '/opt/SparseMatrixAnalysis/tvm/build'
make[3]: Nothing to be done for 'CMakeFiles/project_libbacktrace.dir/build'.
make[3]: Leaving directory '/opt/SparseMatrixAnalysis/tvm/build'
[  1%] Built target project_libbacktrace
make  -f CMakeFiles/tvm_runtime_objs.dir/build.make CMakeFiles/tvm_runtime_objs.dir/depend
make[3]: Entering directory '/opt/SparseMatrixAnalysis/tvm/build'
cd /opt/SparseMatrixAnalysis/tvm/build && /opt/cmake-3.18.0/bin/cmake -E cmake_depends "Unix Makefiles" /opt/SparseMatrixAnalysis/tvm /opt/SparseMatrixAnalysis/tvm /opt/SparseMatrixAnalysis/tvm/build /opt/SparseMatrixAnalysis/tvm/build /opt/SparseMatrixAnalysis/tvm/build/CMakeFiles/tvm_runtime_objs.dir/DependInfo.cmake --color=
make[3]: Leaving directory '/opt/SparseMatrixAnalysis/tvm/build'
make  -f CMakeFiles/tvm_runtime_objs.dir/build.make CMakeFiles/tvm_runtime_objs.dir/build
make[3]: Entering directory '/opt/SparseMatrixAnalysis/tvm/build'
[  1%] Building CXX object CMakeFiles/tvm_runtime_objs.dir/src/runtime/c_runtime_api.cc.o
/usr/bin/c++ -DDMLC_USE_FOPEN64=0 -DDMLC_USE_LOGGING_LIBRARY="<tvm/runtime/logging.h>" -DNDEBUG -DNDEBUG=1 -DTVM_INDEX_DEFAULT_I64=1 -DTVM_KALLOC_ALIGNMENT=64 -DTVM_THREADPOOL_USE_OPENMP=0 -DTVM_USE_LIBBACKTRACE=1 -DUSE_FALLBACK_STL_MAP=0 -I/opt/SparseMatrixAnalysis/tvm/include -I/opt/SparseMatrixAnalysis/tvm/build/libbacktrace/include -I/opt/SparseMatrixAnalysis/tvm/3rdparty/libcrc/include -isystem /opt/SparseMatrixAnalysis/tvm/3rdparty/dlpack/include -isystem /opt/SparseMatrixAnalysis/tvm/3rdparty/dmlc-core/include -isystem /opt/SparseMatrixAnalysis/tvm/3rdparty/rang/include -isystem /opt/SparseMatrixAnalysis/tvm/3rdparty/compiler-rt -isystem /opt/SparseMatrixAnalysis/tvm/3rdparty/picojson -std=c++17 -O2 -Wall -fPIC  -o CMakeFiles/tvm_runtime_objs.dir/src/runtime/c_runtime_api.cc.o -c /opt/SparseMatrixAnalysis/tvm/src/runtime/c_runtime_api.cc
In file included from /opt/SparseMatrixAnalysis/tvm/include/tvm/runtime/ndarray.h:30:0,
from /opt/SparseMatrixAnalysis/tvm/include/tvm/runtime/device_api.h:28,
from /opt/SparseMatrixAnalysis/tvm/src/runtime/c_runtime_api.cc:27:
/opt/SparseMatrixAnalysis/tvm/include/tvm/runtime/container/string.h:40:23: fatal error: string_view: No such file or directory
compilation terminated.
CMakeFiles/tvm_runtime_objs.dir/build.make:94: recipe for target 'CMakeFiles/tvm_runtime_objs.dir/src/runtime/c_runtime_api.cc.o' failed
make[3]: *** [CMakeFiles/tvm_runtime_objs.dir/src/runtime/c_runtime_api.cc.o] Error 1
make[3]: Leaving directory '/opt/SparseMatrixAnalysis/tvm/build'
CMakeFiles/Makefile2:135: recipe for target 'CMakeFiles/tvm_runtime_objs.dir/all' failed
make[2]: *** [CMakeFiles/tvm_runtime_objs.dir/all] Error 2
make[2]: Leaving directory '/opt/SparseMatrixAnalysis/tvm/build'
Makefile:148: recipe for target 'all' failed
make[1]: *** [all] Error 2
make[1]: Leaving directory '/opt/SparseMatrixAnalysis/tvm/build'
Makefile:87: recipe for target '/opt/SparseMatrixAnalysis/tvm/build/all' failed
make: *** [/opt/SparseMatrixAnalysis/tvm/build/all] Error 2

/usr/local/bin/g++
sing built-in specs.
COLLECT_GCC=g++
Target: x86_64-pc-linux-gnu
Configured with: ../configure --enable-bootstrap --enable-shared --enable-threads=posix --enable-checking=release --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-linker-build-id --with-linker-hash-style=gnu --enable-languages=c,c++,go,lto --enable-plugin --enable-initfini-array --disable-libgcj --enable-gnu-indirect-function --with-tune=generic --disable-multilib
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 10.2.0 (GCC)
COLLECT_GCC_OPTIONS='-std=c++17' '-E' '-v' '-shared-libgcc' '-mtune=generic' '-march=x86-64'
/usr/local/libexec/gcc/x86_64-pc-linux-gnu/10.2.0/cc1plus -E -quiet -v -imultiarch x86_64-linux-gnu -D_GNU_SOURCE - -mtune=generic -march=x86-64 -std=c++17
ignoring nonexistent directory "/usr/local/include/x86_64-linux-gnu"
ignoring nonexistent directory "/usr/local/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../x86_64-pc-linux-gnu/include"
#include "..." search starts here:
#include <...> search starts here:
/usr/local/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../include/c++/10.2.0
/usr/local/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../include/c++/10.2.0/x86_64-pc-linux-gnu
/usr/local/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../include/c++/10.2.0/backward
/usr/local/lib/gcc/x86_64-pc-linux-gnu/10.2.0/include
/usr/local/include
/usr/local/lib/gcc/x86_64-pc-linux-gnu/10.2.0/include-fixed
/usr/include/x86_64-linux-gnu
/usr/include
End of search list.

1 ""
1 ""
1 ""
1 "/usr/include/stdc-predef.h" 1 3 4
1 "" 2
1 ""
COMPILER_PATH=/usr/local/libexec/gcc/x86_64-pc-linux-gnu/10.2.0/:/usr/local/libexec/gcc/x86_64-pc-linux-gnu/10.2.0/:/usr/local/libexec/gcc/x86_64-pc-linux-gnu/:/usr/local/lib/gcc/x86_64-pc-linux-gnu/10.2.0/:/usr/local/lib/gcc/x86_64-pc-linux-gnu/
LIBRARY_PATH=/usr/local/lib/gcc/x86_64-pc-linux-gnu/10.2.0/:/usr/local/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../lib64/:/lib/x86_64-linux-gnu/:/lib/../lib64/:/usr/lib/x86_64-linux-gnu/:/usr/local/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../:/lib/:/usr/lib/
COLLECT_GCC_OPTIONS='-std=c++17' '-E' '-v' '-shared-libgcc' '-mtune=generic' '-march=x86-64'
4.libstdc++.so.6 (libc6,x86-64) => /usr/lib/x86_64-linux-gnu/libstdc++.so.6

echo LD_LIBRARY_PATH=$LD_LIBRARY_PAT
LD_LIBRARY_PATH=
The LD_LIBRARY_PATH display nothing in the cmd

Everything looks reasonable for the g++ configuration.
It looks like cmake is calling the /usr/bin/c++ executable, which is usually a symlink to a specific compiler version.  Can you run realpath /usr/bin/c++ to see which compiler it ends up running?

Everything looks reasonable for the g++ configuration.
It looks like cmake is calling the /usr/bin/c++ executable, which is usually a symlink to a specific compiler version. Can you run realpath /usr/bin/c++ to see which compiler it ends up running?

Thanks !!!
I see /usr/bin/g++-5, now could to tell me how to relink c++ to g++-10.2.0

Should be doable with update-alternatives (SO link).

Should be doable with update-alternatives (SO link).

Thanks for your help!!! Now I can successfully compile and install tvm on my machine👍👍👍


Fix right conditional to stepping

Solves https://github.com/huggingface/accelerate/issues/435 by changing the conditional to !=, stepping at the right time.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


[POAE7-2432] Fix Old CiderBatch Memory Allocation for Group-By Result Fetching

What changes were proposed in this pull request?

Why are the changes needed?

Previous memory allocation of output old CiderBatch doesn't follow the schema in CiderOutputTableSchema or CiderAggHashTable, which works fine when the size of item less than 8 bytes. However, the size of VarChar type recently supported is 16 bytes, it leads memory problems.
Does this PR introduce any user-facing change?

No
How was this patch tested?

UTs and e2e test.
Which label does this PR belong to?

BugFix
Pls take a review @harborn @winningsix

#37 didn't pass the UTs but was merged, I have fixed it. Pls take review carefully and make the CI really in use.


simplify travis build, take 2

Reverts Smithay/wayland-rs#154
Apparently the failure where spurious from travis, and not a mistake on our side?

Coverage decreased (-2.6%) to 49.357% when pulling 714d08e8d532bd49fd42adb8dcdf2a7d51fd6e64 on revert-154-revert-153-master into fc5ad3b68cd8b9651907d3e95ca95b54aee4a8de on master.


Occasional failure on Windows of tests.test_simulator.TestSimulator.test_tid_pid

This occasionally happens on the github validation machine. I do not use Windows native to develop that much and I failed to reproduce this issue on my machine with some efforts.
I suspected that this is a racing issue with multithreads.
This is a branch feature(vdb + multithread) and will not affect the main usage as long as you do not use vdb on multithread logs. However, if you are interested in the error, I would appreciate if you could take a deeper look at this. Either figure out why this happens(even fix it with a PR), or find a reliable way to reproduce this.
If you are a contributor and found this error when you PR, you can ignore it for now and re-run the validations.
Traceback (most recent call last):
  File "c:\hostedtoolcache\windows\python\3.8.6\x64\lib\runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "c:\hostedtoolcache\windows\python\3.8.6\x64\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\hostedtoolcache\windows\Python\3.8.6\x64\Scripts\vdb.exe\__main__.py", line 7, in <module>
  File "c:\hostedtoolcache\windows\python\3.8.6\x64\lib\site-packages\viztracer\simulator.py", line 143, in main
    sim = Simulator(s, no_clear=options.no_clear, extra_newline=options.extra_newline)
  File "c:\hostedtoolcache\windows\python\3.8.6\x64\lib\site-packages\viztracer\simulator.py", line 29, in __init__
    self.snapshot = ProgSnapshot(json_string, self.print)
  File "c:\hostedtoolcache\windows\python\3.8.6\x64\lib\site-packages\viztracer\prog_snapshot.py", line 177, in __init__
    if not self.load(json_string):
  File "c:\hostedtoolcache\windows\python\3.8.6\x64\lib\site-packages\viztracer\prog_snapshot.py", line 194, in load
    self.load_event(event)
  File "c:\hostedtoolcache\windows\python\3.8.6\x64\lib\site-packages\viztracer\prog_snapshot.py", line 220, in load_event
    self.func_trees[pid][tid].add_event(event)
  File "c:\hostedtoolcache\windows\python\3.8.6\x64\lib\site-packages\viztracer\functree.py", line 88, in add_event
    self.curr.adopt(node)
  File "c:\hostedtoolcache\windows\python\3.8.6\x64\lib\site-packages\viztracer\functree.py", line 72, in adopt
    self.parent.adopt(other)
AttributeError: 'NoneType' object has no attribute 'adopt'

It's possible that this bug is fixed by #25 . We will observe for a couple runs before closing it

I think #25 fixed this. Never saw another occurrence again. Close it.

We have another incident so this is not gone.
https://github.com/gaogaotiantian/viztracer/runs/1339862659?check_suite_focus=true

One possible reason is Windows providing negative timestamp, which will make the root node of functree confuse. I will change the start time of root and see if this happens in the future

It seems like after https://github.com/gaogaotiantian/viztracer/commit/57f8db26564feeca395df96e68bb1e8bcae6e494 this never happened again. Probably the reason is the negative timestamp from Windows. We'll close this for now and reopen if it reproduces.


New Folder Dialog launches on wrong monitor

Storage Explorer Version: 0.9.6
OS Version: Windows 10
Steps to Reproduce:

Open Blob Container
Click New Folder

Notes:
If it doesn't reproduce try changing the monitor that Storage Explorer is running on.
Expected Experience:
New Folder Dialog launches on same monitor as Storage Explorer.
Actual Experience:
New Folder launches on different monitor.

Rename Dialog Also

erroneous link just prior, apologies.


SSL/TLS support

https is not supported yet.
Can you add this to your lib please ?

Wrong server config, sorry :s


Add test coverage for Kafka with SSL

Hopefully everyone is ok with adding another kafka itest module (I will likely add more soon). I think it's better to have these test scenarios isolated within their own module to keep things simple. Obviously it comes at the expense of adding some additional bloat the the project.
I'll address some of the duplication across the tests in a future issue / commit.

I think the xref checks failure in the functional-extension-test-and-docs check is fixed by https://github.com/apache/camel-quarkus/pull/2501.


Can I use resource deployment client to deploy a Azure Mysql with template?

Hi,
I can use resource deployment client to deploy a VM with template (like azure-sdk-for-go-samples/quickstart/deploy-vm/mai.go). But when I was using it to deploy a Azure mysql with a template (ServicePrinciple authentication as well), it threw out a exception of 'InvalidAuthenticationTokenAudience'.
The detail exception information as below:
Failed to deploy Azure MysQL: resources.DeploymentsClient#CreateOrUpdate: Failure sending request: StatusCode=401 -- Original Error: Code="InvalidAuthenticationTokenAudience" Message="The access token has been obtained for wrong audience or resource 'https://vault.azure.net'. It should exactly match with one of the allowed audiences 'https://management.core.windows.net/','https://management.core.windows.net','https://management.azure.com/','https://management.azure.com'."
I have a customer will integrate their IT management system with Azure, this is an obstacle. And they prefer using template to deploy all the resources. Can anybody help me out?
Thanks,
Jerry

Sorry, I used a wrong auth module, it should be "github.com/Azure/go-autorest/autorest/azure/auth".


RSA Encryption [Cryptography]

Aim

Implementing RSA encryption

Details

RSA is an asymmetric encryption algorithm widely used for secure communication and digital signatures. It relies on the mathematical difficulty of factoring large prime numbers. RSA encryption and decryption involve the use of public and private keys.

Do I want to work on this:

[x]  Yes
[ ] No

Hey @programerr01, please provide some more details regarding how will you go about implementing it.

RSA works by creating pair of public and private key. It works by encrypting message with public key, this message can only be decrypted with correct private key.
Key Generation Method

We pick two big prime numbers, let's call them p and q.
We multiply p and q to get a bigger number called n.
We calculate another number called φ(n) based on p and q.
Then we choose a small number called e that's between 1 and φ(n), and it doesn't have any common factors with φ(n).
We find another number called d, which is the "modular inverse" of e, meaning when we multiply e and d and divide by φ(n), - - we get a remainder of 1.

The public key is (e, n), and the private key is (d, n).
The security of RSA is based on the fact that it's really hard to factorize big numbers. Without knowing the prime factors of n (p and q), it's practically impossible to figure out the private key just from the public key.

Go Ahead, Add Decryption Script as well @programerr01


Add version tags to the repository

While trying to figure out which version of warcio first included some functionality (for specifying a minimum dependency version), I realised that this repository unfortunately has no version tags. It's therefore not easily possible to determine which version first contained a particular commit, which is usually done with git tag --contains COMMITID (and also displayed on the web interface on most Git hosting platforms). It also appears that the version bump in setup.py does not always coincide with the actual release, so that's not a reliable way to check either.
Would you consider retroactively adding tags for the releases, ideally back to version 1.0?

I am for it,  but it would require some sleuthing. Have you already made a list of the ids? Looks like it would require a bit of looking around, perhaps with a good ole' git log -p . > everything-ever.txt

I am for it,  but it would require some sleuthing. Have you already made a list of the ids? Looks like it would require a bit of looking around, perhaps with a good ole' git log -p . > everything-ever.txt

Yeah, it definitely would. Possibly some comparisons to the tars on PyPI as well.
I haven't done anything regarding this so far.

Yeah, it definitely would. Possibly some comparisons to the tars on PyPI as well.
I haven't done anything regarding this so far.


ols Breaks VSCode's Sticky Scroll

All scopes besides procs are ignored, and it chooses to show the second import in files as well.
ols off:

ols on:

Not sure how to add it to vscode sticky scroll. It right now uses the outline of all the functions, but there is no way to describe it for loop, etc.

Huh, looks like you're correct—neither Go nor Rust support more than that either. What an odd thing for it to be supported when the language servers are disabled, and to not provide a way to express it >_<
My apologies!


SPOI-10716 Sales Dimensions Tutorial: update screenshots

The dag in the first page is linear and looks different from the one in the monitoring page which has a side branch. Which is right ?

If the user is following the directions, they would yield the one on the right, the one that looks like a linked list. This is because the SalesDemo.java:96 line:
    store.setEmbeddableQueryInfoProvider(wsIn);

embeds the PubSubWebSocketAppDataQuery into the store operator. The example file SalesDemo.java was likely updated without updating the docs.
As for the dtAssemble part (second page), I do use the actual PubSubWebSocketAppDataQuery operator. They both do the same thing -- I'll add a line on this page to clarify.


store health check data in disk

[Healthcheck]Populate healthcheck data to to disk in file /mnt/deployd/env_status

Tested locally. If I delete the /mnt/deployd/env_status on devapp, it took about 12 minutes to complete the whole redeploy for all containers using this PR. And the time is similar if I delete the file using the current deploy-agent-pex. So, the change didn't affect the efficiency of deployment. The only extra work is: we store the container health status to the disk file each time when we querying the container status before sending the pingRequest to Agent server.
Here is the content in the /mnt/deployd/env_status using this PR:
{
  "beacon": {
    "build_info": {
      "build_branch": "origin/master",
      "build_commit": "c0e2ee123f1fc442a84f94c92263d05c4a29d193",
      "build_id": "B9BGW8LmTSWlUaSGkvbDLA_c0e2ee1",
      "build_name": "beacon",
      "build_repo": "pinternal/tower",
      "build_url": "https://soxrepo.pinadmin.com/beacon/beacon-c0e2ee12.tar.gz"
    },
    "op_code": "DEPLOY",
    "report": {
      "containerHealthStatus": null,
      "deployAlias": null,
      "deployId": "ODNR_A12T_G49nP8ENt2Ag",
      "deployStage": "SERVING_BUILD",
      "envId": "nS2GIXkgQnK4pR9qG5ZpFg",
      "envName": "beacon",
      "errorCode": 0,
      "errorMessage": null,
      "extraInfo": null,
      "failCount": 0,
      "stageName": "prod-aws-us-east-1d",
      "status": "SUCCEEDED"
    }
  },
  "envoy": {
    "build_info": {
      "build_branch": "origin/master",
      "build_commit": "8c8a4c0c37a13484f6e8d8b3db226c1f627e090e",
      "build_id": "4kVmfDTDQRKDn7ddp9y1AQ_8c8a4c0",
      "build_name": "traffic-envoy",
      "build_repo": "pinternal/envoy",
      "build_url": "https://soxrepo.pinadmin.com/traffic-envoy/traffic-envoy-8c8a4c0c37a13484f6e8d8b3db226c1f627e090e.tar"
    },
    "op_code": "DEPLOY",
    "report": {
      "containerHealthStatus": "envoy-B:healthy;envoy-endpoint-register:healthy",
      "deployAlias": null,
      "deployId": "fnNUyZqlS9mtqpddpISlvA",
      "deployStage": "SERVING_BUILD",
      "envId": "inbDfs6KQICpRRfuKQw_bQ",
      "envName": "envoy",
      "errorCode": 0,
      "errorMessage": null,
      "extraInfo": null,
      "failCount": 0,
      "stageName": "devapp",
      "status": "SUCCEEDED"
    }
  },
  "mcrouter": {
    "build_info": {
      "build_branch": "master",
      "build_commit": "e508d8c9bad67ee4403f818c912a6c24002136f1",
      "build_id": "4jyj9eEVTpCYmJoJ4Qt-jA_e508d8c",
      "build_name": "mcrouter",
      "build_repo": "pinternal/mcrouter",
      "build_url": "https://deployrepo.pinadmin.com/mcrouter/mcrouter-e508d8c.tar.gz"
    },
    "op_code": "DEPLOY",
    "report": {
      "containerHealthStatus": "mcrouter:healthy",
      "deployAlias": null,
      "deployId": "3zZuGjXbReqgsgwkAFcQPQ",
      "deployStage": "SERVING_BUILD",
      "envId": "2XwshUOHR36DGEAH4PzBwg",
      "envName": "mcrouter",
      "errorCode": 0,
      "errorMessage": null,
      "extraInfo": null,
      "failCount": 0,
      "stageName": "devapp",
      "status": "SUCCEEDED"
    }
  },
  "metrics-agent": {
    "build_info": {
      "build_branch": "master",
      "build_commit": "b3e1871e85d82fd6488ca74dcd42f5cbc729598a",
      "build_id": "zPod3DABTh-W7KKms3sZUQ_b3e1871",
      "build_name": "metrics-agent",
      "build_repo": "pinternal/metrics-agent",
      "build_url": "https://deployrepo.pinadmin.com/metrics-agent/metrics-agent-b3e1871.tar.gz"
    },
    "op_code": "DEPLOY",
    "report": {
      "containerHealthStatus": "metrics-agent:healthy",
      "deployAlias": null,
      "deployId": "IY7ClakMQhagIV94woUp5A",
      "deployStage": "SERVING_BUILD",
      "envId": "kwUx6aHWQo6R174lT-eawQ",
      "envName": "metrics-agent",
      "errorCode": 0,
      "errorMessage": null,
      "extraInfo": null,
      "failCount": 0,
      "stageName": "prod-aws-us-east-1d",
      "status": "SUCCEEDED"
    }
  },
  "pastis": {
    "build_info": {
      "build_branch": "master",
      "build_commit": "34d94ff3700c1144052c69f14e4741a18e3805ab",
      "build_id": "GxH3WocdT9auyVRSGlaUEA_34d94ff",
      "build_name": "pastis_proxy",
      "build_repo": "pinternal/magnus",
      "build_url": "https://soxrepo.pinadmin.com/pastis_proxy/pastis_proxy-34d94ff3700.tar"
    },
    "op_code": "DEPLOY",
    "report": {
      "containerHealthStatus": null,
      "deployAlias": null,
      "deployId": "fDXKA0UMQYaV07g0TYYHwA",
      "deployStage": "SERVING_BUILD",
      "envId": "typrFRIFR6-lDyaiNjAk9w",
      "envName": "pastis",
      "errorCode": 0,
      "errorMessage": null,
      "extraInfo": null,
      "failCount": 0,
      "stageName": "external-test",
      "status": "SUCCEEDED"
    }
  },
  "ratelimit": {
    "build_info": {
      "build_branch": "origin/master",
      "build_commit": "946cba44b7b6c895a43e314a6ad8748c1221ddd1",
      "build_id": "kle2VGLoQdy-zYGfv0SYKQ_946cba4",
      "build_name": "traffic-envoy-ratelimit",
      "build_repo": "pinternal/envoy",
      "build_url": "https://soxrepo.pinadmin.com/traffic-envoy-ratelimit/traffic-envoy-ratelimit-946cba44b7b6c895a43e314a6ad8748c1221ddd1.tar"
    },
    "op_code": "DEPLOY",
    "report": {
      "containerHealthStatus": "ratelimit-B:healthy",
      "deployAlias": null,
      "deployId": "rXqFmaubTIGROjX0XT4VAg",
      "deployStage": "SERVING_BUILD",
      "envId": "gu2DEmL4Tv2XOqDKFc7Axw",
      "envName": "ratelimit",
      "errorCode": 0,
      "errorMessage": null,
      "extraInfo": null,
      "failCount": 0,
      "stageName": "devapp",
      "status": "SUCCEEDED"
    }
  },
  "singer": {
    "build_info": {
      "build_branch": "master",
      "build_commit": "d5e571fc9694e746e133cc9ef860f0cb4ce9e474",
      "build_id": "GlmLPCVRTGypjsa6URQz4g_d5e571f",
      "build_name": "singer",
      "build_repo": "SINGER",
      "build_url": "https://soxrepo.pinadmin.com/singer/singer-d5e571f.tar.gz"
    },
    "op_code": "DEPLOY",
    "report": {
      "containerHealthStatus": null,
      "deployAlias": null,
      "deployId": "DcdD-aipRTKp4hmtmXg45g",
      "deployStage": "SERVING_BUILD",
      "envId": "7ib3xSHSR3unnLdN-ViGxw",
      "envName": "singer",
      "errorCode": 0,
      "errorMessage": null,
      "extraInfo": null,
      "failCount": 0,
      "stageName": "prod-aws-us-east-1d",
      "status": "SUCCEEDED"
    }
  },
  "tcollector": {
    "build_info": {
      "build_branch": "master",
      "build_commit": "abe3077cb493409e5265de35888389578d39ae9e",
      "build_id": "elKIwvRKRuCQFrrPvl7URA_abe3077",
      "build_name": "tcollector",
      "build_repo": "pinternal/tcollector-repo",
      "build_url": "https://deployrepo.pinadmin.com/tcollector/tcollector-abe3077.tar.gz"
    },
    "op_code": "DEPLOY",
    "report": {
      "containerHealthStatus": "tcollector:healthy",
      "deployAlias": null,
      "deployId": "E8U5leLLSmmmAtkiqqy-kQ",
      "deployStage": "SERVING_BUILD",
      "envId": "pZwvW9faQTW7vD19ER72Gg",
      "envName": "tcollector",
      "errorCode": 0,
      "errorMessage": null,
      "extraInfo": null,
      "failCount": 0,
      "stageName": "prod-aws-us-east-1d",
      "status": "SUCCEEDED"
    }
  },
  "telefig": {
    "build_info": {
      "build_branch": "master",
      "build_commit": "d0eb5f6963ba397b96e39d59d0ab32ab29395d3f",
      "build_id": "B-9E8Px9QCm7EqfCf4V3Sw_d0eb5f6",
      "build_name": "deploy-telefig",
      "build_repo": "pinternal/teletraan-config-manager",
      "build_url": "https://deployrepo.pinadmin.com/deploy-telefig/deploy-telefig-d0eb5f6.tar.gz"
    },
    "op_code": "DEPLOY",
    "report": {
      "containerHealthStatus": null,
      "deployAlias": null,
      "deployId": "lIq9RH-eS3miHvcUxURWiA",
      "deployStage": "SERVING_BUILD",
      "envId": "99xVHd7bSr608HSHqrCGbA",
      "envName": "telefig",
      "errorCode": 0,
      "errorMessage": null,
      "extraInfo": null,
      "failCount": 0,
      "stageName": "prod-aws-us-east-1d",
      "status": "SUCCEEDED"
    }
  },
  "zk_update_monitor": {
    "build_info": {
      "build_branch": "master",
      "build_commit": "17e4ede82b4e69028a43478a33458efc45e59b03",
      "build_id": "9I-kCkXBQBSbdzCkeeHUmg_17e4ede",
      "build_name": "zk_update_monitor",
      "build_repo": "pinternal/zk-update-monitor",
      "build_url": "https://deployrepo.pinadmin.com/zk_update_monitor/zk_update_monitor-17e4ede.tar.gz"
    },
    "op_code": "DEPLOY",
    "report": {
      "containerHealthStatus": null,
      "deployAlias": null,
      "deployId": "qXyg0uh1RpeHfUiTHo_Q8g",
      "deployStage": "SERVING_BUILD",
      "envId": "tLWOA1CsQ4W2Nu_kMFyYVA",
      "envName": "zk_update_monitor",
      "errorCode": 0,
      "errorMessage": null,
      "extraInfo": null,
      "failCount": 0,
      "stageName": "prod-aws-us-east-1d",
      "status": "SUCCEEDED"
    }
  }
}


DnsServer not a valid member

Using this on Azure and I get this error.

DnsServer = $dnsServerFqdn

'DependsOn', 'Ensure', 'Name', 'PsDscRunAsCredential', 'Target', 'Type', 'Zone'.

The latest version 1.8.0 doesn't have this member. The latest github code has this property added. When will it be made available please, or what is a workaround to mitigate this?

Closing this as per previous comment, that this is resolved in v<IP_ADDRESS> an that was release some time ago (we are now up to v.<IP_ADDRESS>). If this was closed in error, then please reopen or comment.


Conditionally run mix ecto.migrate

Might be worth considering to do this. Need to check though if running this affects the app in prod

Not possible!


Update manage-resources-containers.md

修改内存资源单位的描述：”证书“改为”整数“

Please sign a CLA before a reviewer jumps in.

Hey @wuyongpeng,
You have to sign the CLA so that we can review this PR and move forward.
Just click on the red NOT COVERED button in the first comment.
哈囉，你需要先簽署 CLA 貢獻者授權協議，我們才能 Review 並合併這個 PR
請點擊上方第一個留言的紅色 NOT COVERED 按鈕，並依網站指示操作
After signing the CLA, you may use this command to refresh the status:
/easycla
If you have any problem, please take a look at the CLA tutorial.
如果用起來還有問題，可以先看看 這篇教學 的操作截圖

Looks good to me as the first PR.
/lgtm

Nice catch, keep contributing
/lgtm


There is no way of inspecting the registered types programatically

In a Bootstrapper class in my project I have a simple mechanism that automatically registers all interfaces found in the assemblies of the current AppDomain with concrete implementations of that interface found found in the assemblies of the current appdomain into a TinyIoC container.
Be default this autoregistration should not override/change existing registrations that already have been done prior to the AutoRegister call.  Unfortunately this doesn't seem to be possible because there is no way of looking at the current registrations of the TinyIoC container (_RegisterdTypes is private).
Is there a way to inspect the current registrations? If not why not and can this feature be added? It would be very easy to implement (just a public facade around _RegisteredTypes).
Of course I could just add this myself in my local copy of TinyIoC.cs but that would break with the next update.

What is this doing that the existing AutoRegister doesn't already do?
As for it being accessible, it's an internal concern of the container, but the main container class is intentionally a partial class to allow for extensions like this without touching the main cs file, so if you create another partial with the method you want it will be able to access the private _RegisteredTypes field.

What is this doing that the existing AutoRegister doesn't already do?

It doesn't leave the existing registrations untouched.
The registration rules are very specific, and I don't see how to implemenet using the existing AutoRegister methods. These are the rules:

It should only look at the assemblies loaded into the current appdomain.
There are some assemblies of the current appdomain that should be ignored.
It should only register interfaces as keys (no concrete types, no abstract classes).
It sould only register interfaces as keys that are not declared in the ignored assemblies even if the found concrete implementations are declared outside the ingored assemblies.
If multiple concrete implementations are found, it should use RegisterMultiple.


Enhancing FAQ Section

Feature request:
I want to add transition in FAQ section (when questions are being opened and closed) and also when one question is opened, the other one should automatically close. Also changing the cursor to pointer when the user hovers over the question.
Describe the solution you'd like:
The changes will be made in CSS file i.e. transition will be applied and React Hooks will be used to add the feature of automatically closing a question, when other question is being opened.
Describe how this feature will be useful to our readers:
This feature will enhance the readability of faqs and also the design of the website.
Please assign me this issue as a part of GSSOC'21.

Note:

If you want to work on an issue, you should check if it has already been assigned to anyone.

@abdus @vaishali614 @Manvityagi Can I work on this issue?

Hey! I would really like to work on this please allow me to work on this as well...
-gssoc'21 participant

@abdus @vaishali614 @Manvityagi Can I work on this issue?

Go ahead @shriya030. Added the respective tags and assigned to you.
Good Luck and feel free to communicate any doubts or ideas.

Hey! I would really like to work on this please allow me to work on this as well...
-gssoc'21 participant

Hi @ShambhaviSharma0110, the issues assignment is on FCFS basis, please find another issue to work on.

@abdus @vaishali614 @Manvityagi Can I work on this issue?

Go ahead @shriya030. Added the respective tags and assigned to you.
Good Luck and feel free to communicate any doubts or ideas.

Thank you mam. I want you to review one thing. From where I can communicate with you?

@abdus @vaishali614 @Manvityagi Can I work on this issue?

Go ahead @shriya030. Added the respective tags and assigned to you.
Good Luck and feel free to communicate any doubts or ideas.

Thank you mam. I want you to review one thing. From where I can communicate with you? I had already started working on this issue. Should I make a pull request and then you can review it?

You can join our discord channels on GSSOC server.
#opportunity-calendar-frontend
#opportunity-calendar-backend

Yes, @shriya030. Make a PR, We can review it then.


UNO android app not receiving mqttclient subscribed topic

Hi,
I am using MQTTnet in my Android app. I have created an Android application on the UNO platform. The application is working fine in debug mode but when I publish my app and run it on my mobile phone, I am unable to receive subscribed topic after installing the "APK" file on my mobile phone. Unable to find out the cause behind it.
Steps:-

I am connected with "test.mosquitto.org".I am able to receive messages when I published anything under a particular topic.
In release mode or by installing the published "APK" file on my mobile phone, the app is not receiving published messages from "test.mosquitto.org".

Please provide me with a solution to it. Why my app is not receiving published messages in release mode?
Attaching a video for help.
https://user-images.githubusercontent.com/119324311/230410245-7615468b-88b6-473d-9654-d2860e41fb06.mp4
https://user-images.githubusercontent.com/119324311/230410280-39ffd412-1d40-4e19-b042-9b9ba1ef4c91.mp4

Without some code snippets you used I am afraid that we cannot help much.

If everything works in debug mode, there might be some object that is garbage collected, because you forgot to keep the reference to it. something like using
mqttFactory.CreateMqttClient()

instead of
var client = mqttFactory.CreateMqttClient()

If you provide your code we might be able to help more.


Align output variables for static, cdn and domain

Currently, all providers have different output namings.
They need to be aligned. What are the best names?
Outputs:
- cdnEndpoint                 : "https://cdn-xxxx.azureedge.net/"
- staticEndpoint              : "https://accountXXXX.z7.web.core.windows.net/"
- customDomainOutput          : "https://my-custom-domain.com/"

Implemented by #7


(maint) Document actual default SSH username

Ping @MFredette - how do we get this into production?

CLA signed by all contributors.


Draft: feat: disable kam with env variable

What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
https://issues.redhat.com/browse/GITOPSRVCE-424
Have you updated the necessary documentation?

[ ] Documentation update is required by this PR.
[ ] Documentation has been updated.

Which issue(s) this PR fixes:
https://issues.redhat.com/browse/GITOPSRVCE-424
Fixes #?
Test acceptance criteria:

[ ] Unit Test
[ ] E2E Test

How to test changes / Special notes to the reviewer:

Closing as not required anymore


Fix CORS issue with remote LFF API in development

I was missing the Vite way of doing things. The demo app, storybooks, and tests all work locally now and the tests pass in the GitHub checks.


It can't show the grid line when I use the Grid command like "yzGrid=True" or "xzGrid=True".

Hello
It can't show the grid line when I use the Grid command, like "yzGrid=True" or "xzGrid=True". Can you tell me how to solve this problem?
Thanks very much and best regards.

it should work...:
from vedo import *
show(Sphere(), axes=dict(yzGrid=True, zxGrid=True))

Hello,
I got it. If I run the same code by the vedo installed by the command "pip install vedo", it can show the grid line. But if I run it by the vedo installed by the command "conda install vedo", it can't show the grid line.
Thanks

I wonder then if the conda way installs the more recent vtk 9.1.0 which has a problem with transparent quad-meshes..

I wonder then if the conda way installs the more recent vtk 9.1.0 which has a problem with transparent quad-meshes..

Sorry, I don't know.


fix(stack): log success in finally block

What
Actually say we succeeded if the finally block succeeds
How
stack.js: fixed finally block
Why
This is currently broken (see https://ele-dreadnot.cm.k1k.me/stacks/chef/regions/iad2/deployments/401)

+1

me too me too :+1:

+1

+1


[Enhancement] Add support to multilingual

Hi,
Can add support for multilingual? The strings are hardcoded so first it's necesary to extract it. I never worked with Swift so I can't help with this problem but I can translate the app to Spanish.
Thanks!

Thanks!!!
In the next release, we'll be able to split up the other language files so we can translate them!

@RodrigoTomeES Thank you for your issue!
I did implement multilingual support to this release https://github.com/ObuchiYuki/DevToysMac/releases/tag/<IP_ADDRESS>
Now it supports only Japanese, but I'll continuously update the localizations!

@RodrigoTomeES Thank you for your issue!
I did implement multilingual support to this release https://github.com/ObuchiYuki/DevToysMac/releases/tag/<IP_ADDRESS>
Now it supports only Japanese, but I'll continuously update the localizations!

Hi,
Great, I saw it in the commits and I am already working to translate it to Spanish 🚀.

@RodrigoTomeES
Thank you very much! Lo estamos deseando.


Use path to current file as base for imports

Import/use paths are relative to the current file, so using the current file's path as the base for imported files fixes #66

Thanks


Conditional formatting for DataTable columns

Description
Adds conditional formatting as a content type in the Column component.
To do:

Clean up naming
Adjust colours

Options:

contentType=colorscale
colorMax - can pass a value to treat as the maximum of the column (e.g., if you set it to 100, anything above 100 would receive the max colour)
scaleColor - "green" (default), "blue", or "red"

Checklist

[x] For UI or styling changes, I have added a screenshot or gif showing before & after
[x] I have added a changeset

Considerations

Should we offer downIsGood like in BigValue, to reverse the direction of the colour scale?
Multi-colour scales/heatmaps

I think this could be done by combining 2 colour scales - basically we’d split the column’s data into 2 based on value and apply a different colour scale to each (e.g., above median values go on the green scale, below median values go on a reversed red scale)

Setting custom minimum for the scale (similar to colorMax)

Right now the colour is determined by the % of the max value in the column
If you have a lot of similar values - e.g., 122, 124, 125, 126 - the colours will look the same
We might want to offer a custom minimum like colorMax or we might need logic to use the min value as the floor for the scale calculation, rather than 0 as it’s doing now

If you have a small # of columns, the width of each column can vary a lot, so you might have 2 metric columns where the width of one is double the width of the other

For v1 of this, we're going to just add the color min functionality, and look at reversing the scale, creating diverging scales, and the comment on cell width in the future.

Added colorMin to default to lowest value of the column, original approach would get weird at negative values

Big +1 to multi-color scales, and the ability to add custom colors.

@jackwelty I think I know what you mean, but can you give an example of how you would use those?
For multi-color, I’m imagining a diverging scale (e.g., green to red).
For custom color, I’m imagining setting a color and having a gradient created from that color. The other way to do this one would be to manually set each color in the scale (e.g., 10 colors, effectively creating buckets)

so sorry for the delay here but that's exactly what I was thinking! One item I would add is custom diverging colors, i.e. red - white - blue, with white as the midpoint.


New package: NewickTree v0.1.0

Registering package: NewickTree
Repository: https://github.com/arzwa/NewickTree.jl
Created by: @arzwa
Version: v0.1.0
Commit: 57a04db558c798760b47cc60560206b00edc0e77
Reviewed by: @arzwa
Reference: https://github.com/arzwa/NewickTree.jl/issues/1

retry

I'll fix this

[noblock]
Retrigger Registrator.


August Recovery Endgame

[ ] Bump up the version in package.json @bpasero
[ ] Build stable for all platforms @bpasero
[ ] Verify all issues in Recovery Milestone team
[ ] Make rpm signing request @Tyriar
[ ] Sanity check of installable bits

[ ] Windows 64

[ ] signed installer
[ ] user installer
[ ] zip

[ ] Windows 32

[ ] signed installer
[ ] user installer
[ ] zip

[ ] OS X
[ ] Linux

[ ] deb package 64-bit
[ ] deb package 32-bit
[ ] rpm package 64-bit
[ ] rpm package 32-bit
[ ] archive 64-bit
[ ] archive 32-bit

[ ] Update release notes with milestone link @bpasero
[ ] Add a git tag to HEAD of release/<x.y> in format x.y.z @bpasero
[ ] Publish website Redmond
[ ] Publish to stable @bpasero
[ ] Publish deb and rpms to repositories manually @chrmarti

@bpasero Didn't want to pollute with yet another silly issue, so FYI here: on a macOS (fully updated), neither my "regular" nor insider 'see' the newly released August update. Updates have been coming in regularly before for years.

@ddotlic we temporarily stopped the update due to https://github.com/Microsoft/vscode/issues/47883

@bpasero Ah, seems like a very sensible thing to do 😉 , thanks! I was slightly confused (and more people are probably going to as well) because I've seen the tweet and release notes are up on the VS Code web site (maybe put a message there to avoid confusion)?

Yeah we can do that.

is it feasible to provide some extra status information after manually hitting "check for updates..."?
Something like "Automtatic Updates has been temporarily disabled due to issue #xxxxxx..."
I searched for local network releated proxy issues first and then disovered this issue :)

Website is updated btw.

Website is updated btw.

Great, I can also confirm that my insider has just been updated (am on a macOS so the fix should not concern me but good to know that insider updates are back).

Yes, unfortunately we cannot stop the update per OS (see https://github.com/Microsoft/vscode/issues/58043). Latest insiders on all platforms is 1.27.1 to test the fix.

Released.


invalid character '{' after top-level value" when running pod as resource

hey i am trying to run a pod in the workflow using kubernetes resource
where i am facing this error

pod is getting deployed but workflow is getting failed
name: tensorboard-template
inputs:
  parameters:
    - name: action
    - name: job_id
    - name: data_storage
outputs: {}
metadata: {}
daemon: true
resource:
  action: '{{inputs.parameters.action}}'
  manifest: |
    apiVersion: v1
    kind: Service
    metadata:
      labels:
        app: 'tb-{{inputs.parameters.job_id}}'
      name: 'tb-{{inputs.parameters.job_id}}'
    spec:
      ports:
      - port: 80
        targetPort: 6006
      selector:
        app: tb-{{inputs.parameters.job_id}}
      type: ClusterIP
    ---
    apiVersion: v1
    kind: Pod
    metadata:
      labels:
        app: 'tb-{{inputs.parameters.job_id}}'
      name: 'tb-{{inputs.parameters.job_id}}'
    spec:

      containers:
      - name: tensorboard
        command: ["/bin/sh", "-c"]
        args: ["tensorboard --logdir {{inputs.parameters.data_storage}}/tensorboard"]
        image: tensorflow/tensorflow:2.5.1
        ports:
        - containerPort: 6006

        resources:
          requests:
            cpu: 500m
            memory: 500Mi

          limits:

            cpu: 500m
            memory: 500Mi

I had the same problem. IIUC the problem is not pod but trying to apply multiple manifests in a single file.
The underlying implementation runs kubectl apply -f $file-o json and then tries to read the json output, but when the file contains more than one object - the json output is a simple concatenation of multiple jsons.
eg:
{
   "firstjson":...
}
{
  "secondjson":...
}

See https://github.com/argoproj/argo-workflows/issues/9463


[TRACKER] Vulkan GPUParticles issues

This is a tracker for issues with the GPUParticles implementation in Godot 4.x (Vulkan renderer).
This tracker does not list issues related to GPUParticles in Godot 3.x.
Bugs

[ ] https://github.com/godotengine/godot/issues/32803
[ ] https://github.com/godotengine/godot/issues/43643
[ ] https://github.com/godotengine/godot/issues/49170
[ ] https://github.com/godotengine/godot/issues/50824
[ ] https://github.com/godotengine/godot/issues/51318
[ ] https://github.com/godotengine/godot/issues/53851
[ ] https://github.com/godotengine/godot/issues/54478
[ ] https://github.com/godotengine/godot/issues/54964
[ ] https://github.com/godotengine/godot/issues/55511
[ ] https://github.com/godotengine/godot/issues/56691
[ ] https://github.com/godotengine/godot/issues/58525
[ ] https://github.com/godotengine/godot/issues/59072
[ ] https://github.com/godotengine/godot/issues/60994
[ ] https://github.com/godotengine/godot/issues/61014
[ ] https://github.com/godotengine/godot/issues/61066

Enhancements

[ ] https://github.com/godotengine/godot/issues/54773
[ ] https://github.com/godotengine/godot/issues/60909
[ ] https://github.com/godotengine/godot/issues/60910

Pull requests

[ ] https://github.com/godotengine/godot/pull/48385
[ ] https://github.com/godotengine/godot/pull/50442
[ ] https://github.com/godotengine/godot/pull/55382
[ ] https://github.com/godotengine/godot/pull/60992
[ ] https://github.com/godotengine/godot/pull/61068

#58410 and #56892

https://github.com/godotengine/godot/issues/65888

#67545


It doesn't seem to depend on the code. touching a file can make it happen or not happen.
Here's an example of the code it happened with: https://git.lubar.me/ben/tolpaha/src/commit/ac4aab9f17e1de34424a8836964c1deee659aff1
What did you expect to see?
Program compiles and runs
What did you see instead?
unexpected fault address 0x7fa5b6698538
fatal error: fault
[signal SIGBUS: bus error code=0x2 addr=0x7fa5b6698538 pc=0x4d8aed]

goroutine 1 [running]:
runtime.throw(0x690f28, 0x5)
        /usr/lib/go-1.13/src/runtime/panic.go:774 +0x72 fp=0xc000752fa8 sp=0xc000752f78 pc=0x42dc32
runtime.sigpanic()
        /usr/lib/go-1.13/src/runtime/signal_unix.go:391 +0x455 fp=0xc000752fd8 sp=0xc000752fa8 pc=0x442bd5
encoding/binary.littleEndian.PutUint64(...)
        /usr/lib/go-1.13/src/encoding/binary/binary.go:90
encoding/binary.(*littleEndian).PutUint64(0x8777c0, 0x7fa5b6698538, 0x30, 0x4a9ac8, 0xd423e0)
        <autogenerated>:1 +0x3d fp=0xc000752ff8 sp=0xc000752fd8 pc=0x4d8aed
cmd/link/internal/ld.relocsym(0xc0006e6000, 0xc00491c570)
        /usr/lib/go-1.13/src/cmd/link/internal/ld/data.go:556 +0xae0 fp=0xc000753258 sp=0xc000752ff8 pc=0x554f30
cmd/link/internal/ld.(*Link).reloc(0xc0006e6000)
        /usr/lib/go-1.13/src/cmd/link/internal/ld/data.go:570 +0xb4 fp=0xc0007532d0 sp=0xc000753258 pc=0x557c54
cmd/link/internal/ld.Main(0x84cdc0, 0x10, 0x20, 0x1, 0x7, 0x10, 0x69ac6f, 0x1b, 0x697756, 0x14, ...)
        /usr/lib/go-1.13/src/cmd/link/internal/ld/main.go:263 +0xd6e fp=0xc000753428 sp=0xc0007532d0 pc=0x5ab5ae
main.main()
        /usr/lib/go-1.13/src/cmd/link/main.go:65 +0x1d6 fp=0xc000753f60 sp=0xc000753428 pc=0x614606
runtime.main()
        /usr/lib/go-1.13/src/runtime/proc.go:203 +0x21e fp=0xc000753fe0 sp=0xc000753f60 pc=0x42f5ce
runtime.goexit()
        /usr/lib/go-1.13/src/runtime/asm_amd64.s:1357 +0x1 fp=0xc000753fe8 sp=0xc000753fe0 pc=0x45a501

The linker has changed quite a lot.  Is there a way that you could test this against the master branch?  Thanks.

I tried with the dev.link branch, and OP's github branch. It failed to compile for other reasons, but if it's too not too much to update the link to a working piece of code I'd be happy to take a look there as well.

To make it compile, you just need to go generate ./assets
I'm omitting the generated file for now to avoid a lot of source control churn.
I noticed my SSD was almost full, so this may be related to that rather than anything in Go.

I noticed my SSD was almost full

Probably related to #37310. It should be fixed on tip (Go 1.15 to be).

Hasn't happened again, so closing as a duplicate of #37310


[Bug] Paimon isn't writing data to s3

Search before asking

[X] I searched in the issues and found nothing similar.

Paimon version
I have tried the following versions with the same results

paimon-flink-1.17-0.5.0-incubating.jar
paimon-flink-1.17-0.6-20231105.002237-58.jar
paimon-flink-1.18-0.6-20231105.002237-43.jar

Compute Engine
flink:1.17.1 docker image
Minimal reproduce step
I use the following Docker Compose file to start Flink version 1.17.1:
version: '3.7'

services:

  mariadb:
    image: mariadb:10.6.14
    environment:
      MYSQL_ROOT_PASSWORD: rootpassword
    volumes:
      - ./sql/mariadb.cnf:/etc/mysql/mariadb.conf.d/mariadb.cnf
      - ./sql/seed.sql:/docker-entrypoint-initdb.d/seed.sql
    ports:
      - "3306:3306"

  jobmanager:
    image: flink:1.17.1
    container_name: jobmanager
    environment:
      - JOB_MANAGER_RPC_ADDRESS=jobmanager
    ports:
      - "8081:8081"
    command: jobmanager
    volumes:
      - ./jars/flink-sql-connector-mysql-cdc-2.4.1.jar:/opt/flink/lib/flink-sql-connector-mysql-cdc-2.4.1.jar
      - ./jars/flink-connector-jdbc-3.1.0-1.17.jar:/opt/flink/lib/flink-connector-jdbc-3.1.0-1.17.jar
      - ./jars/paimon-flink-1.18-0.6-20231105.002237-43.jar:/opt/flink/lib/paimon-flink-1.18-0.6-20231105.002237-43.jar
      - ./jars/flink-shaded-hadoop-2-uber-2.8.3-10.0.jar:/opt/flink/lib/flink-shaded-hadoop-2-uber-2.8.3-10.0.jar
      - ./jars/paimon-s3-0.6-20231027.002013-54.jar:/opt/flink/lib/paimon-s3-0.6-20231027.002013-54.jar
      - ./jobs/job.sql:/opt/flink/job.sql

  taskmanager:
    image: flink:1.17.1
    environment:
      - JOB_MANAGER_RPC_ADDRESS=jobmanager
    depends_on:
      - jobmanager
    command: taskmanager
    volumes:
      - ./jars/flink-sql-connector-mysql-cdc-2.4.1.jar:/opt/flink/lib/flink-sql-connector-mysql-cdc-2.4.1.jar
      - ./jars/flink-connector-jdbc-3.1.0-1.17.jar:/opt/flink/lib/flink-connector-jdbc-3.1.0-1.17.jar
      - ./jars/paimon-flink-1.18-0.6-20231105.002237-43.jar:/opt/flink/lib/paimon-flink-1.18-0.6-20231105.002237-43.jar
      - ./jars/flink-shaded-hadoop-2-uber-2.8.3-10.0.jar:/opt/flink/lib/flink-shaded-hadoop-2-uber-2.8.3-10.0.jar
      - ./jars/paimon-s3-0.6-20231027.002013-54.jar:/opt/flink/lib/paimon-s3-0.6-20231027.002013-54.jar
    deploy:
          replicas: 2

I then submit the following Flink SQL Job:
USE CATALOG default_catalog;

CREATE CATALOG s3_catalog WITH (
    'type' = 'paimon',
    'warehouse' = 's3://my-test-bucket/paimon',
    's3.access-key' = 'xxxxxx',
    's3.secret-key' = 'xxxxx'
);

USE CATALOG s3_catalog;

CREATE DATABASE my_database;

USE my_database;

CREATE TABLE myproducts (
    id INT PRIMARY KEY NOT ENFORCED,
    name VARCHAR,
    price DECIMAL(10, 2)
);

create temporary table products (
    id INT,
    name VARCHAR,
    price DECIMAL(10, 2),
    PRIMARY KEY (id) NOT ENFORCED
) WITH (
    'connector' = 'mysql-cdc',
    'connection.pool.size' = '10',
    'hostname' = 'mariadb',
    'port' = '3306',
    'username' = 'root',
    'password' = 'rootpassword',
    'database-name' = 'mydatabase',
    'table-name' = 'products'
);

INSERT INTO myproducts (id,name) SELECT id, name FROM products;

The products table has data in it, which looks like:
CREATE DATABASE IF NOT EXISTS mydatabase;

USE mydatabase;

CREATE TABLE IF NOT EXISTS products (
    id INT AUTO_INCREMENT PRIMARY KEY,
    name VARCHAR(255) NOT NULL,
    price DECIMAL(10,2) NOT NULL
);

INSERT INTO products (name, price) VALUES
    ('Product A', 19.99),
    ('Product B', 29.99),
    ('Product C', 39.99);

On s3, I see a folder for the catalog and table is created successfully, however it only holds the schema folder and file. No other data is written.
Inside the schema file I see the following JSON which reflects the structure of the table.
{
  "id" : 0,
  "fields" : [ {
    "id" : 0,
    "name" : "id",
    "type" : "INT NOT NULL"
  }, {
    "id" : 1,
    "name" : "name",
    "type" : "STRING"
  }, {
    "id" : 2,
    "name" : "price",
    "type" : "DECIMAL(10, 2)"
  } ],
  "highestFieldId" : 2,
  "partitionKeys" : [ ],
  "primaryKeys" : [ "id" ],
  "options" : { },
  "timeMillis" :<PHONE_NUMBER>055
}

I tried a table without the price DECIMAL(10,2) NOT NULL field in case that was a problem, no change.
There are no errors in the logs. The Job is running successfully in Flinks UI, just no records are being written to s3.

What doesn't meet your expectations?
I expect to see some table data in the s3 bucket. I only see the schema folder which indicates it is working at least partially.
Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

I'll close this issue, I was missing SET 'execution.checkpointing.interval' = '10 s';. Once I added that, data started to show up.


update .travis

add api in golint and go vet path

Coverage remained the same at 27.289% when pulling 1e3658ab3ecefa6dfecb6c244fcde7f38d16c6e3 on yhua123:dev into 944ad04982950f450249c5f258e817297544b420 on vmware:dev.

Coverage remained the same at 27.289% when pulling c69fffcca6bf1bf55e0426b7c7b64a53d9cf10a6 on yhua123:dev into 944ad04982950f450249c5f258e817297544b420 on vmware:dev.

Coverage remained the same at 27.289% when pulling c69fffcca6bf1bf55e0426b7c7b64a53d9cf10a6 on yhua123:dev into 944ad04982950f450249c5f258e817297544b420 on vmware:dev.


Add option to install extra packages/groups

Fixed primary functionality associated to #7, need to extend the package-selection functionality to make the fix for #7 complete.

In monthly-use (to date), functionality appears to be adequately reliable and complete.


ReactNativeJNI:Check failed :*m_isDestroyed JSCExecutor::destroy() must be called before its destructor

ReactNativeJNI:Check failed :*m_isDestroyed JSCExecutor::destroy() must be called before its destructor
Open confusion after the formal package, in the mobile phone testing, there is this problem, the Internet search a circle did not result, a friend met this problem? Hope to get your help!
this android and windows!

Any news?
I faced it after enabling PROGUARD

-keep class com.facebook.react.** { *; }
It helped me

I  encountered it also !

@facebook-github-bot label Icebox

@facebook-github-bot close

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/reactnativejnicheck-failed-misdestroyed-jscexecutordestroy-must-be-called-before-its-destructor
ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub.
Also, if this issue is a bug, please consider sending a PR with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.

I have the same error on iOS

I am facing same error on iOS, but after rebuilding app in xcode resolved the issue for while. Can anybody tell us how to resolve this issue permanently ?

Experiencing this on iOS but not Android


Bug - inkplayer not running with HTML export/Loads in Background turned off

Describe the bug
inkplayer create_story method throws "InkRuntime could not be found" error if run in HTML or "Loads In Background" turned off.
To Reproduce

Install inkgd plugin and create inkPlayer node and load with InkFile.
Turn "Loads in Background" off.
In code, have the inkplayer run the "create_story" method and run the scene.

Expected behavior
Scene should run as normal, with no errors.
Environment:

OS: Windows
Godot version: 3.4.3 vanilla
inkgd version: 0.4.5

Hey @GreenCloversGames, thanks for reporting and investigating this issue!


updated cudnn path

I faced an issue as neither CUDNN_INCLUDE_DIR nor CUDNN_HOME environment variables were set. This resulted in a "Found cuDNN" error. Therefore, I updated the path with /cuda, as it was most suggested installation path for installing cudnn.

Thanks :)


contextlib2 "latest" not building after switch from Mercurial to Git

I'm currently migrating contextlib2 development from Mercurial-on-BitBucket to git-on-GitHub, and am having trouble getting the "latest" docs to build correctly: they seem to keep building the old, pre-migration docs, even after I use "Wipe" on the build environment.
A new "master" version builds correctly, so I'm wondering if there may be a problem with the switch from "default" as the main branch in Mercurial to "master" in git.

Project: contextlib2
Build #: 3915890

@ncoghlan Did you try setting in "Advanced Project settings" the "Default branch" to "master" and save?

Then see if the rebuild works for latest.
Hopefully that should work. FYI - I forked your repo and everything built fine. I did notice a difference between my test deploy and your current settings.

Ahah, indeed, that got it. I was looking for a field that actually said "default", and missed that there was an empty "Default branch" field" in the Advance Settings.
Thanks!

@ncoghlan Glad it worked for you :sunflower:


logging: ping isn't rejecting missconfigured requests

This integration test would fail currently:
var (
        projID = testutil.ProjID()
        ctx    = testutil.Context()
)

func TestMissconfiguredPingFails(t *testing.T) {
        var (
                c   *logging.Client
                err error
        )

        if c, err = logging.NewClient(ctx, projID+"-bad-project-name", "logging-integration-test"); err != nil {
                t.Fatalf("error creating client: %v", err)
        }

        if err := c.Ping(); err == nil {
                t.Fatalf("expecting Ping() error for misconfigured client.")
        }
}

We're working on a new version of the logging client that won't have Ping. What's your use case for Ping?

@jba it was to verify the client configuration. With the current logging client, I can create a client, configure it, and not know if it is able to authenticate or authorized to write logs until my first log write. As ping is currently documented:

Ping reports whether the client's connection to Google Cloud Logging and the authentication configuration are valid.

This is not what it does. There is currently no way to fail fast if a logging client is misconfigured.

@jba definitely a use case for this. you want to fail in init() if anything is misconfigured. We should have something like this in the new logging client.

@broady Fine, but wouldn't this also be true for all other clients?

It's fine for most APIs to fail on the first call. Logging is a bit different since the logs are sent asynchronously. So the first call may appear to work, but the log entry is only sent later on.
I suppose you could log an entry synchronously just to test auth.

The problem with the current implementation of Ping is that it works by calling WriteLogEntries with an empty list of entries, and the logging service treats that as a no-op, with no checks. I'm working on a new implementation.


Diff Highlighting Marking HTML Tags as Line Deletions

Information:

Prism version: Test drive version
Plugins: 'none'
Environment: Test drive

Description
Hey @RunDevelopment 👋 (if you triage 🙂) Hope you're well!
Prism marks line 2 in the code below as a deleted line in the diff language:
Not in HTML element

Inside HTML element - incorrectly (?) marked as deleted

-
Inside HTML element - correctly marked as deleted

GitHub doesn't mark it as a deletion (see above).
However, I suppose this could be something that I'm unaware of about diff highlighting - maybe an angle bracket symbol means deletion in some context?
Example
https://prismjs.com/test.html#language=diff

Workaround: add a space at the beginning of the line:
Not in HTML element

Inside HTML element - incorrectly (?) marked as deleted

-
Inside HTML element - correctly marked as deleted

Hi!

maybe an angle bracket symbol means deletion in some context?

Exactly that. I was also confused by the < and > when I first looked at Prism's Diff language definition. This is used by a diff format (but I don't remember which one...), so Prism supports it.

Workaround: add a space at the beginning of the line:

That's not a workaround, you just fixed the diff. The unified diff format requires unchanged lines to start with a single space. This is to avoid ambiguity (e.g. the diff of a markdown file might contain unchanged lines starting with - (lists)).
All lines that don't start with a [ +-!<>@] are syntactically invalid AFAIK.

GitHub doesn't mark it as a deletion

Seems like GitHub doesn't support the <> diff format and just ignores all lines it doesn't understand (we do the same thing), hence no highlighting.

Wow, super fast and very deep explanation, thanks!!