Added example of how to change sprite at runtime

Objective
Fixes: https://github.com/bevyengine/bevy/issues/3130
Solution

Added an example on how to update sprites at runtime
Showing an example of how to alter the color value
Showing an example of how to swap the texture

Thanks for making this! So, the other thing you can actually do is fetch the Res<Assets<ColorMaterial>>, and then modify the underlying asset using Assets::get_mut or Assets::set. This will then update all of the entities that are using that handle.
This is a subtly distinct but powerful tool (especially when working with more tweakable assets like meshes). Understanding this distinction is really what made the assets system click for me when I was first learning, so I think it's valuable to highlight :)
The other question is where do we want this example to live. I had originally envisioned two examples, one for 2D and one for 3D. After chewing on it for a bit, I think this is fundamentally an assets example since we're trying to explain the subtleties of the assets and handles model, and the duplication would be redundant. Do you agree with my assessment there?

Thanks for making this! So, the other thing you can actually do is fetch the Res<Assets<ColorMaterial>>, and then modify the underlying asset using Assets::get_mut or Assets::set. This will then update all of the entities that are using that handle.
This is a subtly distinct but powerful tool (especially when working with more tweakable assets like meshes). Understanding this distinction is really what made the assets system click for me when I was first learning, so I think it's valuable to highlight :)
The other question is where do we want this example to live. I had originally envisioned two examples, one for 2D and one for 3D. After chewing on it for a bit, I think this is fundamentally an assets example since we're trying to explain the subtleties of the assets and handles model, and the duplication would be redundant. Do you agree with my assessment there?

Thanks for the feedback, ill work on updating this PR now, yep that definitely makes more sense 👍

Pinging again on this :) It came up again today, and I was hoping we had an example ready to show a beginner.

This PR adds a new example. Adding module and item level doc comments, as described in:

#3951 and
#4438,

would be really useful to those who will browse examples.

2. runtime example needs to be added to

Hey sorry I've been away for so long, at the end of last year I started a new job and moved to the other side of the country I live in and got a little burnt out of doing open source dev, ill fix this stuff up asap :)

@alice-i-cecile should this still be targeted at the pipelined-rendering branch? seems like its gone a bit stale and a few of the examples I was using as reference aren't running

@louisgjohnson another user was asking about this today. Are you able to fix this up so we can merge it? :)

Hey @alice-i-cecile, Just an updated:
I've removed the modify mesh example and just updated the modify sprite one.
I was having some small issues with the mesh example and to prevent the whole PR being blocked I thought I could just raise it as a separate one

I'm not sure I like this example:

it boils down to "if you change the value of the component, it changes what is rendered using the value of the component"
both changes happens on the same timer on the same entity, so it's hard to see what's changing what
as the same timer is used in two systems, it's ticked only in one which is not very clear

I'm not sure I like this example:

it boils down to "if you change the value of the component, it changes what is rendered using the value of the component"
both changes happens on the same timer on the same entity, so it's hard to see what's changing what
as the same timer is used in two systems, it's ticked only in one which is not very clear

Fair enough, I can add a seperate timer for the Color component and name them accordingly?

Oops, Ctrl + Enter closes the PR apparently 😅

I don't think this example is needed, and this is quite old. I propose we close this.


Cannot apply licenses to DB backed Kong gateways

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When we create a KongLicense, KIC can translate it to Kong license but cannot apply it to DB backed Kong gateway.
Internally tracked as FTI-5776.
This happens because GDR does not support diff of Kong's license entity: https://github.com/Kong/go-database-reconciler/issues/60.
Expected Behavior
KongLicense can be correctly translated and applied with both DBless and DB backed Kong gateway.
Steps To Reproduce
1. Deploy DB backed Kong gateway and KIC
2. Create a KongLicense resource
3. From the log we can see the KongLicense is correctly reconciled and translated
4. Call the GET /licenses API of Kong gateway and we can see no license applied

Kong Ingress Controller version
3.1.0

Kubernetes version
No response
Anything else?
No response

blocked by https://github.com/Kong/go-database-reconciler/issues/60


Remove the MeasurementType enumeration from Goal.proto since it always takes one value

Remove the MeasurementType enumeration
This PR removes the Goal::MeasurementType enumeration since it always take on the value of CENTRE. The MeasurementType was used once in GoalDetector which has also been removed. These changes have been made following discussion in issues #705 and #450.
This PR can only be merged following the merge of PR #712

Don't remove the measurement type, despite the fact that it's not used right now it very likely could be used in the future and it is best to make the ball and goal measurements match.
You can probably remove some of the enums here, but the point of this is to have different independent ways of measuring the goals. For example, using the width of the post, or projection to the bottom etc. For the ball as well width and projection-based measurements go in the type.

Don't remove the measurement type, despite the fact that it's not used right now it very likely could be used in the future and it is best to make the ball and goal measurements match.
You can probably remove some of the enums here, but the point of this is to have different independent ways of measuring the goals. For example, using the width of the post, or projection to the bottom etc. For the ball as well width and projection-based measurements go in the type.

I feel like having a unused enumeration in the proto file is not ideal, if different measurementTypes are needed in the future, it would not take much effort to implement them again and with correct understanding of what they actually mean.

You don't want to end up in the situation where each object type has its own way of doing things, e.g. ball has a measurement type and goal doesn't etc. That's just adding difficulty when people want to learn how to use them.
Also if someone now works on localisation without having this enum, they'll write code as if it doesn't exist.
Then adding it back in the future will be far more difficult because it wasn't accounted for.
On the other hand, if it does exist with a single value, at least those developing localisation will know it needs to exist and handle it.
You want the way these to protos to be used to match
https://github.com/NUbots/NUbots/blob/main/shared/message/vision/Ball.proto
https://github.com/NUbots/NUbots/blob/main/shared/message/vision/Goal.proto
And it wouldn't be an unused enum, it'd just be an enum with a single option, which I would comment in this PR so people know what it means.

If we want to keep this enum, I would like what each of the fields means documented. There's not a consensus on what the fields mean (#450), and if the enum is going to be useful, it should be clear.


refactored go sourcecode to conform to code conventions

https://codebeat.co/projects/github-com-appplant-goo/ratings
Generally: Unsure if abc issues are fixed, because of the unclear nature of the condition(|ABC| = sqrt((AA)+(BB)+(C*C)) Where A is any assignment, B is any branch like functioncall e.g. and C is any condition )
NOT fixed:

Block nesting too deep -  main.PrettyTableFormatter.normalizeTable
could still be at warning. Unsure about that.

Too many instance variables - main.opts
It's the whole purpose of this struct to carry variables. Any attempt to split it or nest it would only make the whole ordeal more complicated and confusing.

Too many instance variables - main.Planet
similar to main.opts, but not as strong.

Too many instance variables - Go::Build (ruby) (at github.com/appPlant/goo)
Don't really know what's meant with this one. Not inspectable.

👍 Ready to merge


Added TouchVisualizer for Design Review Demo

Did we decide to have a dedicated branch for the design review or will we just use the develop branch?

Did we decide to have a dedicated branch for the design review or will we just use the develop branch?

I discussed it shortly with @AlexExcellence back then and we decided that it'd be best to have another branch instead of just using the develop branch. If I understood correctly it should be possible to release the app from another branch other than develop, could you please confirm this @huber-florian ?


Use marisa-trie Python wrapper

Using the Python wrapper might help users: https://github.com/kmike/marisa-trie

What's the point? Faster compilation? I wouldn't bother, and focus more on better output delivery, like mobi format. :)

Now the user must installs MARISA via e.g. apt-get or other packet managers, or download its source code and compile it. Then, she has to modify the path in penelope.py.
The point of using the MARISA Python interface (instead of calling MARISA via subprocess) is to get (slightly) faster execution and, more importantly, a simpler, pip-based setup.

Done in v3.0.0


Adr16 high level regime abstractions

TP2000-170 ADR16 - High-Level Abstractions for Trade Policy Regimes
Why
As part of architectural discussions about the future design directions for TaMaTo, the TAP data team has agreed to open two related ADR-s for discussion - this one on high-level abstractions for trade policy regimes and the other for a new UK trade policy data specification for DIT
What
This PR contains the draft of ADR16.
Recommended to use this link for reading through the formatted ADR before commenting.
NB: Unfortunately, I got to my last day before I could ready this for PR. This means that likely I won't be able to respond to what I'm sure is going to be a wide range of questions and comments. However, I hope it provides a good enough basis for the direction I think this should be taking on! <3

Does anyone reading this PR know how much of this was already implemented in notebooks ?


Drag and Drop Issue IN IE 11

Hi
Drag and drop does not work in IE 11
Have you any one who solve this issue, please suggest.
Thanks.

can you share me your code ?


Verify Global Install Files & Set SDK Telemetry to Match VS Code Setting

Adds ability to detect when VS Code's telemetry setting has been changed
Disables the .NET SDK telemetry when VS Code or VS Code Extension Telemetry settings are off on windows, warns on osx and linux
Does not edit SDK telemetry if its already off
Also verifies hashes of .NET SDK Installer files and their download url, adds a box to accept the risk if no hash exists
Adds a warning pop up if we fail to disable SDK telemetry
Fixes Ubuntu Package Feed Repository Key downloading by adding sudo, so it can pass
Improves error message about how to install manually on WSL
Updates telemetry setting to mention you should restart VS Code for the setting to take effect
View the pipeline / main codeflow here: https://github.com/dotnet/vscode-dotnet-runtime/pull/1469

The global PR is merged so this origin to origin PR is no longer needed, and we will use the one above from origin to upstream.


Improve build script to not fail when there is JS warning

I have improve deploy.ps1 (Kudu App Services script) to

Not build fail when there is JS warning
Auto build with yarn when there is yarn.lock file in a modules/themes folders
Build support for MS build 16, so we can use a new C# syntax, e.g. tuple pattern matching

What you mean by JS warning? Because we run functional tests which should make the build fail.

@Skrypt  There are many times when we build node package/load a package, it send warning to a standard error and causes a build fail event though $exit code is 0.
Please check.
https://github.com/OrchardCMS/Orchard/blob/8156e23911f4492e24c5bb3d3c73bae29f672480/DeploymentUtility.psm1#L29

@Skrypt  I think I will deploy this project to Azure app service to make sure the build script work properly.
I have tested with my project but it is good to test with a clean/initial state project.
I will update a website link to you after the deployment is successful.
Thanks.

@Skrypt  FYI, I think I have problem of wrong indention displayed in GitHub.
Especially when we have pipe |.
If you checkout this branch to your local machine, you will find that the indention is correct.

Ok, I will take some time to review the PR and analyze what you are trying to achieve. I don't think we build the assets through the CI because we commit the built assets in the repository. So, I believe you are somehow trying to automate the build of assets through the CI.

I'm sorry I just saw that this is for Orchard and not Orchard Core. I'm totally lost on this for Orchard I don't remember the details at all.

@Skrypt  That's okay.
What I am trying to achieve is automate build a node project with yarn if there is a yarn.lock in themes or modules folders and improve the existing script for unnecessary &  call operation in script block.
It won't effect a project that build with.
The script act the same as before except build with yarn for a module that has yarn.lock.

LGTM as long as it is tested by more than one person

@sebastienros Thank you so much.
@Skrypt  I am working on deploy it Azure App Services, I will let you after I finish it ASAP.
FYI LGTM  is an acronym meaning "looks good to me".

Since we are here, I think it is good to update a nuget package from the latest version and make Kudu build script use it.
Therefore, I put a new commit to made PR.

@sebastienros  @Skrypt I 've already deployed this PR to Azure App Services. If this PR looks good to you, could you please merge it.
Thanks.
Here is the deployment information.
URL:
https://orchard-pr.azurewebsites.net/
Database:
SQL Server compact
Receipt:
Blog
No error in frontend

No error in admin dashboard

We will probably triage this on Thursday. Unless @sebastienros has time to review it up untill then.

@Skrypt  Could you please help following up for this repository.
Thanks.

@Skrypt @sebastienros  Any suggestion to this PR? I am happy to made some changes to get this PR merge.
Thanks.

Just noticed you have added NuGet.exe in the repository, you need to remove it.

@sebastienros  Nuget.exe has already exists in the project so what I did is only update it to the latest version.
This is because with the new nuget.exe version, I can control it to use a specific MS Build version.
Could you please explain the reason that I should remove it?
Thank you so much.

FYI @sebastienros

@sebastienros  @Skrypt  could you please help me finish this PR?
Thank you so much.


.Net: Clean up some extension method classes

Rename some to be specific to their domain
Make some internal
Delete some and move their functionality to the target type being extended

<!doctype html>

avsnr snake game
Loding....

 Created by: avsnr

Your Score :
0

^^^
<<<
>>><<<
^^^

I've added a few "Rename file to match" comments.
Is there a reason this wasn't done?

❤


[SPARK-37354][K8S][TESTS] Make the Java version installed on the container image used by the K8s integration tests with SBT configurable

What changes were proposed in this pull request?

This PR fixes an issue that the Java version installed on the container image used by K8s integration tests are not configurable in case the tests are launched by SBT.
bin/docker-image-tool.sh supports -b java_image_tag=<java image tag> option to the Java version installed on the container image configurable.
But project/SparkBuild.scala doesn't provide the way to pass the option so we can't change the Java version if the tests are launched by SBT.
To allow to change the version, this PR changes project/SparkBuild.scala to recognized the environment variable JAVA_IMAGE_TAG, which is the same manner that resource-managers/kubernetes/integration-tests/scripts/setup-integration-test-env.sh does.
Why are the changes needed?

The K8s integration tests should be launched by any supported Java versions.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Confirmed that the Java version installed on the container image.
In case JAVA_IMAGE_TAG is not set:
# Run the integration tests to create the container image
$ build/sbt -Phive -Pkubernetes  -Pkubernetes-integration-tests package "kubernetes-integration-tests/test"

# Create and login the container.
docker run -it <image>:<tag> /bin/bash

# Confirm the version in the container.
185@4023f49aa0b0:/opt/spark/work-dir$ java -version
openjdk version "1.8.0_312"
OpenJDK Runtime Environment (build 1.8.0_312-b07)
OpenJDK 64-Bit Server VM (build 25.312-b07, mixed mode)

In case JAVA_IMAGE_TAG is set:
# Run the integration tests to create the container image
$ JAVA_IMAGE_TAG=11-jre-slim build/sbt -Phive -Pkubernetes  -Pkubernetes-integration-tests package "kubernetes-integration-tests/test"

# Create and login the container.
docker run -it <image>:<tag> /bin/bash

# Confirm the version in the container.
185@fdf2d9d5ee26:/opt/spark/work-dir$ java -version
openjdk version "11.0.13" 2021-10-19
OpenJDK Runtime Environment 18.9 (build 11.0.13+8)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.13+8, mixed mode, sharing)

Test build #145324 has started for PR 34628 at commit 2a63f02.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49796/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49796/

Test build #145324 has finished for PR 34628 at commit 2a63f02.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145324/

LGTM, the K8s failures seem unrelated I've got a follow up PR for the decom failure - https://github.com/apache/spark/pull/34636

I'll merge this as I have one LGTM from @holdenk . But I'll rebase before merge,  just in case.

Test build #145485 has started for PR 34628 at commit 9b03228.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49957/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49957/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49957/

Test build #145485 has finished for PR 34628 at commit 9b03228.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class DayTimeIntervalType(AtomicType):
class DayTimeIntervalTypeConverter(object):
case class OptimizeSkewedJoin(ensureRequirements: EnsureRequirements)
  // When this is enabled, this class does additional lookup on write operations (put/delete) to

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145485/

Merging to master.
I think the failed Kubernetes integration tests are not related to this change and they are flaky ones. I saw those tests failed in another PR.
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49651/console
Thank you @holdenk for reviewing !


Add code coverage using nyc

For #12737
Opt in for some tests

@DonJayamanne aren't we already doing this?


Fixes issue when using Bugsnag on a WatchOS app

The code was trying to access an extension but on latest WatchOS we can have a standalone app. Related to this issue
Goal
Not crash when using Bugsnag on a standalone Apple watch app.
Design
Just added some checks to see if code is running on an app or extension.
Testing
See steps in related issue. With this branch the crash does not happen.

+1 to this. I noticed the SDK works fine with watch targets created prior to Xcode 14, but new targets and consolidated targets will crash.

Thanks @gpambrozio - the fix looks good. We're going to carry it on in #1588 to allow CI to run and to merge it down.


I have been studying NNI in Tsinghua University for one year. We want to know how to save the model and weight (note not only the model corresponding to JSON, but also the weight). In addition, how to give the saved model and weight to other friends. In particular, how to use it for friends who have not installed the NNI environment? Thank you. Thank you very much.

I have been studying NNI in Tsinghua University for one year. We want to know how to save the model and weight (note not only the model corresponding to JSON, but also the weight). In addition, how to give the saved model and weight to other friends. In particular, how to use it for friends who have not installed the NNI environment? Thank you. Thank you very much.

seems like a duplicated issue.

I’m closing this issue as it has no updates from customer for 3 months, please feel free to reopen if you are still seeing it an active issue.


feat(batch): support query data without checkpoint

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
In this pr, We can query data with barrier(checkpoint = false)'s epoch.
VISIBILITY_MODE == all: all epochs are visible
VISIBILITY_MODE == checkpoint: only checkpoin epochs are visible
Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)

https://github.com/risingwavelabs/risingwave/issues/5446 might be necessary after this PR. 👀

With VISIBILITY_MODE == all, after scaling batch executors are scheduled based on the new data partition, but old uncommitted data may not be accessible to new CN, will this be a problem?

With VISIBILITY_MODE == all, after scaling batch executors are scheduled based on the new data partition, but old uncommitted data may not be accessible to new CN, will this be a problem?

Good question. I think scale always comes with a checkpoint first so the uncommitted data prior to scale will become committed after scale. But that requires the new CN to wait epoch for scale epoch to make sure the checkpointed version is in place before batch query comes in. cc @BugenZhao I think the scaling process already makes sure that?
However, I am thinking whether there will be a problem if there are two rounds of scaling and the second round assigns back the data partition to the original CN.

Good question. I think scale always comes with a checkpoint first so the uncommitted data prior to scale will become committed after scale. But that requires the new CN to wait epoch for scale epoch to make sure the checkpointed version is in place before batch query comes in. cc @BugenZhao I think the scaling process already makes sure that?

Yes. We'll ensure all versions are checkpointed and synced to the latest before scaling. But there might be some race cases due to asynchronous notification, as described in #5446. Some changes need to be made to the batch scheduler.

However, I am thinking whether there will be a problem if there are two rounds of scaling and the second round assigns back the data partition to the original CN.

🤔 Not quite get that. Do you mean that there might be some stale data in the shared buffer?

About batch bench: one node with q12

VISIBILITY_MODE = all
VISIBILITY_MODE = checkpoint

58ms 65us 941ns
50ms 950us 684ns

72ms 338us 354ns
62ms 637us 613ns

6s 119ms 911us 845ns
6s 191ms 831us 520ns

8s 235ms 929us 778ns
7s 994ms 642us 785ns

one node with q20

VISIBILITY_MODE = all
VISIBILITY_MODE = checkpoint

56ms 439us 231ns
52ms 245us 688ns

165ms 7us 672ns
140ms 559us 962ns

169ms 882us 864ns
152ms 513us 607ns

4s 157ms 146us 347ns
4s 130ms 38us 444ns

4s 589ms 509us 819ns
4s 532ms 949us 997ns

one node with q1

VISIBILITY_MODE = all
VISIBILITY_MODE = checkpoint

23ms 852us 266ns
32ms 613us 837ns

58ms 358us 154ns
59ms 27us 27ns

68ms 548us 863ns
64ms 69us 408ns

6s 504ms 284us 984ns
6s 276ms 2us 792ns

Batch Query2:

create mv
concurrent run point query from mv query and insert data.

VISIBILITY_MODE = all：

queries performed:

    read:                            136322
    write:                           0
    other:                           136322
    total:                           272644

transactions:                        136322 (1361.85 per sec.)
queries:                             272644 (2723.70 per sec.)
ignored errors:                      0      (0.00 per sec.)
reconnects:                          0      (0.00 per sec.)

Throughput:

events/s (eps):                      1361.8480
time elapsed:                        100.1007s
total number of events:              136322

Latency (ms):

     min:                                   11.97
     avg:                                  110.09
     max:                                  513.11
     95th percentile:                      153.02
     sum:                             15007943.37

Threads fairness:

events (avg/stddev):           908.8133/2.99
execution time (avg/stddev):   100.0530/0.03

VISIBILITY_MODE = checkpoint：

queries performed:

    read:                            135366
    write:                           0
    other:                           135366
    total:                           270732

transactions:                        135366 (1352.28 per sec.)
queries:                             270732 (2704.57 per sec.)
ignored errors:                      0      (0.00 per sec.)
reconnects:                          0      (0.00 per sec.)

Throughput:

events/s (eps):                      1352.2836
time elapsed:                        100.1018s
total number of events:              135366

Latency (ms):

     min:                                    8.05
     avg:                                  110.85
     max:                                  780.38
     95th percentile:                      150.29
     sum:                             15005802.66

Threads fairness:

events (avg/stddev):           902.4400/2.86
execution time (avg/stddev):   100.0387/0.03

This PR has been suspended for a while. May I know the reason?

This PR has been suspended for a while. May I know the reason?

It need to wait https://github.com/risingwavelabs/risingwave/issues/5446

This PR is ready for review.
@xxhZs @BugenZhao @hzxa21


Add yaml pop-ups for objects that aren't flux primitives

Closes #2755

BACKEND:

In order to add non-primitive objects to the GetObject formula, they had to be freed from the shackles of the UnstructuredObject type. This mostly involved deleting, but there are results I'm still not sure about - such as certain objects not having a conditions value (we used to make that ourselves and assign it to UnstructuredObject), and the new way of retrieving images in the frontend (I'm not sure how to verify if this is working correctly)
The good news is that this led to me discovering that computeMessage just doesn't really do anything? So I made an issue to fix that: https://github.com/weaveworks/weave-gitops/issues/2796
I also added tenant in so they'd work with K8sToProto....I don't know what a tenant is so this could easily have been the wrong move.

getImage on FluxObject:
get images(): string[] {
    const spec = this.obj.spec;
    if (!spec) return [];
    if (spec.template) return spec.template.spec.containers.map((x) => x.image);
    if (spec.containers) return spec.containers.map((x) => x.image);
    return [];
  }

image of types with no conditions:

FRONTEND:

The largest change that doesn't revolve around removing the UnstructuredObject type is adding the GraphNode yaml state to AppContext. I can't put the dialog in GraphNode because then every single node renders it's own dialog. I don't want to put it in any of the graph components because it's reused, and I don't want to add any extra re-renders in there if I can avoid it. Putting it in AutomationDetail seems like the right move, as it's the parent of both graphs. Unfortunately the component that triggers the appearance of the dialog is in GraphNode. This is why I added the state to Context, to avoid passing it down all the way through to DirectedGraph AND DagGraph.
For the Secret stuff. I put some code in there but I haven't tested it. I can barely make a Kustomization let alone a Secret. It's a miracle I have a HorizontalPodAutoscaler. Or is it? I don't know.

Graph yaml video:
https://user-images.githubusercontent.com/65822698/192653706-43539d93-e2a1-4842-b3b2-bd434045290e.mov

Changes have been made -
@ozamosi - CRD showing incorrect status has been added to the computeMessage issue - both conditions show a status of True so I'm not sure why it's showing Not Ready
@opudrovs - I thought there used to be padding on the footer - I looked and it's not there anymore. There must have been a reason but I added it back in for now until I hear otherwise or see something ugly as a result of the change. I also added your great recommendations for get image on FluxObject - I needed to return [] at the end because some objects can have a spec but no template or container and thus return undefined, which crashes the app. Thought it would be better to handle in the class than in ImageLink

Two questions:

How is the width of the modal calculated?  Can we make it about 20% wider?
Why does the parent node "git repository" show no status?

@joshri

I thought there used to be padding on the footer - I looked and it's not there anymore. There must have been a reason but I added it back in for now until I hear otherwise or see something ugly as a result of the change.

The missing footer padding/spacing looks like an old issue which is not limited to the current branch. I have not been able to find where we lost it, maybe we didn't. Maybe it just seemed that the footer had a padding/spacing thanks to styling in some other components. On staging, I can see the footer without spacing on the Sources page, but not on Applications (probably because the table on the Sources page has more items). So, it's great you added the fix let's hope it solves the issue.

I also added your great recommendations for get image on FluxObject - I needed to return [] at the end because some objects can have a spec but no template or container and thus return undefined, which crashes the app. Thought it would be better to handle in the class than in ImageLink

Sounds good! My suggestions were mostly cosmetic, to improve readability. The most important thing was returning [] if the spec does not exist but adding a question mark as you suggested would work too, just with longer lines.

@JamWils

Why does the parent node "git repository" show no status?

@JamWils  @joshri has the parent node (rootNode) ever shown status at all? I checked out some older commits, don't see displaying the status for this node. If it's a new feature we need a separate ticket for this.

@JamWils @opudrovs The parent node (in this case on the ReconciliationGraph it's the source of the automation) has no status because we're pulling it's data from the sourceRef field of the automation, which only has apiversion, kind, name, and namespace. At least we can link the user to the source detail page now? Running a getObject request on the source seems like a lot - if you feel like it looks wrong maybe we better distinguish between the automation as the current node (I feel like the bold text doesn't read as well with the blue links) and the source as.....the source?

It's fine, I was just curious.  Thanks for the context.

@joshri

I feel like the bold text doesn't read as well with the blue links

💡 If after testing it we decide that it's not clear which object is the current object (after adding the links), we could try increasing font weight or adding an asterisk.

❔ Is it expected behavior that size (especially the popup width) of the YAML popup is different for different objects (I don't know if it's related to object type or content line length)?

If the PR is still in progress, sorry, just saw that review was requested and didn't check its state.

❔ Is it expected behavior that size (especially the popup width) of the YAML popup is different for different objects (I don't know if it's related to the object type or content line lengths)?

NOT EXPECTED - this is weird because I'm not getting this on my local. Could be another npm start vs. tilt situation. I added the maxWidth='md' and fullWidth props to Mui's Dialog component (https://mui.com/material-ui/react-dialog/#optional-sizes) which seemed to work for me.

⚠ A couple of minor issues:

When dragging graph with the pointer over a link in a graph node which has no linked details page and just a YAML popup and releasing the graph, the YAML popup for this node is displayed because the pointer stays over the link.

When attempting to drag the graph when the pointer is over a link in a node which has a linked details page, the mouse attempts to drag the link and the graph is not dragged.

⚠ A couple of minor issues:

When dragging graph with the pointer over a link in a graph node which has no linked details page and just a YAML popup and releasing the graph, the YAML popup for this node is displayed because the pointer stays over the link.
When attempting to drag the graph when the pointer is over a link in a node which has a linked details page, the mouse attempts to drag the link and the graph is not dragged.

Even if I change the onClick to a onMouseDown with a setTimeout or something, won't there still be some default browser behavior with dragging links? I get that it's annoying for dragging the graph but I'm not sure that overriding that behavior is a good idea (although I'm sure it's possible somehow). Is the expected behavior that a click and hold on a link doesn't do anything and you can drag the graph and release with no action?

In addition to the behavior noted above, when dragging a graph node with a details page by the link, the node is not dragged, but when releasing the mouse button somewhere it jumps to the pointer location and the graph stays attached to the pointer (it's hard to get the rid of it afterwards 😄  ).

Even if I change the onClick to a onMouseDown with a setTimeout or something, won't there still be some default browser behavior with dragging links? I get that it's annoying for dragging the graph but I'm not sure that overriding that behavior is a good idea (although I'm sure it's possible somehow). Is the expected behavior that a click and hold on a link doesn't do anything and you can drag the graph and release with no action?

It depends on which behavior of graph nodes with links is desired. Graph is not a standard browser element so I think we have some freedom in how it should behave.

In general the PR LGTM except for the minor issues above. 🎉

I've created a secret with kubectl and wanted to test it but have not found where to view it in the dashboard. @ozamosi how can I test a secret in the context of this PR?

@ozamosi how can I test a secret in the context of this PR?

Install weave-gitops through it's chart, and let it create an admin user secret.
The secret data still shows up right now - something like this would make all the secret data vanish, even though it'd still show a popup:
-func K8sObjectToProto(object client.Object, clusterName string, tenant string, inventory []*pb.GroupVersionKind) (*pb.Object, error) {
+func K8sObjectToProto(object *unstructured.Unstructured, clusterName string, tenant string, inventory []*pb.GroupVersionKind) (*pb.Object, error) {
        var buf bytes.Buffer

+       if object.GetKind() == "Secret" {
+               object.Object["data"] = "** redacted **"
+       }

@ozamosi thanks! I've installed it and can confirm that the secret displays the YAML popup.

I had secret un-clickable in the graph, but not in the ReconciledObjectsTable - fixed it.
Table:

Graph:

Secret data is now changed to {redacted: null} inside of GetReconciledObjects, so that it's not even being sent to the frontend. This could technically make Secret yaml viewable if we're interested in that @JamWils
@opudrovs if you could confirm for me that data from the secret in the test-gitops helm release has been changed it would be much appreciated!! Thanks!


Devise secret key is in source control

I was flipping through the source and noticed that we have the devise secret key committed to source control. This should be extracted as an environment variable.
https://github.com/OperationCode/operationcode_backend/blob/5df843a43619738df7900969b59c6edb009966bd/config/initializers/devise.rb#L9

Thank you, it looks like we had config/secrets.yml set but I'm uncertain if the device config or the secrets.yml would win in production.
The prod version of the secret key was different than the value in config anyways.


whenDestroyed

Hi, would it be possible to create a whenDestroyed(this) function the same way we have a untilDestroyed?

What for?

In order to detect when the component is destroyed. In my case, I used it to know when to destroy components created with a angular/cdk Portal.

Use ngOnDestroy, we don't have any plans to do it. Thanks for the suggestion.

I want to send an Observable, not calling it on the method destroy.. I can show you an example if you want.


Plex component doesn't remove clients/status.

Home Assistant release (hass --version):
0.56.1
Python release (python3 --version):
3.4.2
Component/platform:
plex
Description of problem:
When a player starts it gets the correct picture/status. When you pause it, it will work too. But when you stop/remove it and it is no longer visible in plex server the client/picture stays in Hass. If you have multiple clients/movies watched this can stack up. At some point i had 9 movies/series playing while there was only 1 in plex. See also thread https://community.home-assistant.io/t/plexdevices-custom-media-player-component/11246/275 not much activity, but more people complaining about the issue. Alternative is https://community.home-assistant.io/t/status-of-a-plex-client-useful-to-trigger-automation/18540 but this is not in Hass itself.
Expected:
I would like to see plex updated only showing the clients that are active/paused (but not stopped/off), sounds like something simple (but don't pin me on that) @ryanm101 was busy with some updates, tagging him here to as per his request so he can take a look too.

I'll look at this along side my refactor

https://github.com/home-assistant/home-assistant/pull/9988 has now been merged if you want to try running the dev branch against your config

please check 0.61 when released

I will for sure, thanks for the work!

Please try this branch
https://github.com/ryanm101/home-assistant/tree/machineID/homeassistant

sorry, newbie on hass.
Can somebody point me to a procedure how to get this specific plex hotfix to my server?
right now, I copied
https://github.com/ryanm101/home-assistant/tree/machineID/homeassistant/components/media_player/plex.py
to
\flashdrive\home\homeassistant\.homeassistant\custom_components\media_player\plex.py
and restarted server.
Is this OK?

yup that should be it

Small update.
My Clients also persist.
The status only seems to persist if the client "vanishes" i.e. is closed without 1st stopping playback

Partial fix for this in 0.65. Clients will persist but be marked "unavailable".
I plan to allow optional cleanup after X time as a configurable option for 0.66

Fix is in this branch: https://github.com/ryanm101/home-assistant/tree/plex_purge3 if anyone wants to check.. See https://github.com/home-assistant/home-assistant/pull/13156
I need to update docs but default will delete unavailable clients after 10min

Thanks for update, will wait next update of HA as no idea how to test that modification in my existing hassbian system :(


”Lelese” is listed in the drop-down menu

Description:
"Lelese" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Lelese" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Lelese, HUNEDOARA".


Emit docker network usage as cumulative counter

The network usage reported by docker stats is the number of bytes sent
or received since the container was started. This would be better
represented in SignalFx by a cumulative counter than a gauge.

+1 lgtm

:shipit:


Python pytest Test Discovery failed

Hello,
I'm having an issue where Test Dicovery fails in VS Code.
It worked without issues yesterday.
I have tried to re-install the Python Extension and also update pytest.
The Discovery works just fine outside of VS Code as well.
From the Python Test Log:
python c:\Users\USERNAME\.vscode\extensions\ms-python.python-2020.2.63990\pythonFiles\testing_tools\run_adapter.py discover pytest -- --rootdir d:\Path\To\Project -s --cache-clear Tests
Test Discovery failed:
Error: spawn C:\Users\USERNAME\AppData\Local\Programs\Python\Python38\python.exe ENOENT

VSCode Version: 1.42.1 (user setup)
OS Version: Windows_NT x64 10.0.18363
(Copied from Help > About, since Help > Report Issue didn't work)

Steps to Reproduce:

Open a Python project
Run Test Discovery

Does this issue occur when all extensions are disabled?:
This wouldn't really apply in this case as I need the Python extension enabled to run Test Discovery.

/causedByExtension
You need to file this issue in extension repo https://github.com/microsoft/vscode-python/issues/


Arte and ARD Alpha without EPG information in horizon.tv list for germany

Hi,
recently switched from the hd-plus.de.epg.xml to the more complete horizon.tv.epg.xml for german tv channels. Both lists include the channels channel id="ARDAlpha.de" and channel id="ARTEDeutsch.fr" but only the hd-plus.xml shows EPG information for them.
Is there any possibility to transfer the available information from hd-plus to horizon.tv to have one really complete EPG file?
Thanks :)

It's different German EPG sourcing.
I think that your request is not possible
Used one than the other!


Change TRACING_SET to static

if TRACING_SET is const, set_global_default does not work , as each invocation of sp_io::init_tracing will try to re-initialize the global logger, creating panics in wasm compiled with with-tracing flags. const copies while static is a unique location.

Don't we have a test for tracing in wasm?

There is this one:
https://github.com/paritytech/substrate/blob/cff25fbc37c9fc564f8816eefdcd8dce15e1606b/client/executor/src/integration_tests/mod.rs#L662

Don't we have a test for tracing in wasm?

There is this one:
https://github.com/paritytech/substrate/blob/cff25fbc37c9fc564f8816eefdcd8dce15e1606b/client/executor/src/integration_tests/mod.rs#L662
Guessing it didn't catch this because it only tests one enter/exit span

Can you please adapt it and verify that it failed before and now it works? Ty!

here's the result of the changed test:
as const:

as static:

Nice perfect! Now this error hopefully will not come back!


Zhangqiu/add crnn mini vgg 5e mj

add one_iter_test for crnn_mini-vgg_5e_mj

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: Zhang-ze-feng:x: NeosZhangYou have signed the CLA already but the status is still pending? Let us recheck it.


Dark Mode for concerto-ui

Signed-off-by: kanav<EMAIL_ADDRESS>Issue #46
Added a dark mode feature to concerto-ui

The contrast on the form is too low, is that part of this PR?

https://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast-contrast.html

Yes @Michael-Grover  I have set it to grey color ,
.
Changed back to white color

What do you think of making the form dark with white text when the UI is in dark mode to match the code on the left? Right now I think having the form not match the background makes it stand out too much.

should I also change the form to the dark mode?

yeah I think that makes sense

Okay @Michael-Grover.  I will also change it to dark.

Can we make sure the addition of dark mode doesn't affect the light mode at all?
I notice your version adds a gray box around the code in light mode, I don't think this is necessary.

Okay I will not modify the dark mode. I will just add changes to dark mode @Michael-Grover

Hi @kanav-raina , thanks for your PR, this is fun! However, unfortunately, I don't really understand what value this adds to this component.
Your changes are exclusively in the demo app (concerto-ui-react-demo), which although nice looking, don't help users of the concerto-ui-react component. There is already a rudimentary way to apply styling to the component through classes, https://github.com/accordproject/concerto-ui/blob/fe016997eb518ab5b2f03f49217d9c1e188eea67/packages/concerto-ui-react/src/concertoForm.js#L48
If you would like to contribute enhancements to the design of this component, please first open an issue where we can discuss your ideas. I wouldn't want your effort to be wasted in the future.


使用deepctr 包 DCN 训练模型没有报错，但是 model = tf.keras.models.load_model('model_657.h5') 会报错， ValueError: Unknown layer: DNN

Describe the question(问题描述)
A clear and concise description of what the question is.
Additional context
Add any other context about the problem here.
Operating environment(运行环境):

python version [e.g. 3.6]
tensorflow version [e.g. 1.4.0,]
deepctr version [e.g. 0.3.2,]

please use the following codes to load the model
from tensorflow.python.keras.models import  save_model,load_model
model = DeepFM()
save_model(model, 'DeepFM.h5')# save_model, same as before

from deepctr.layers import custom_objects
model = load_model('DeepFM.h5',custom_objects)# load_model,just add a parameter

When using custom_object like this:
model = keras.models.load_model(model_path, custom_objects=custom_objects)

The model is expected to be a FiBiNet instance and I got the following error:
Traceback (most recent call last):
  File "/home/tang/Code/kinrong/aScoreModel101/deep_cross.py", line 203, in <module>
    main('FiBiNET')
  File "/home/tang/Code/kinrong/aScoreModel101/deep_cross.py", line 123, in main
    model = load_keras_model('models/20190808-0802-fibinet/15.hd5')
  File "/home/tang/Code/kinrong/aScoreModel101/deep_cross.py", line 198, in load_keras_model
    model = keras.models.load_model(model_path, custom_objects=custom_objects)
  File "/home/tang/anaconda3/envs/fraudect/lib/python3.6/site-packages/keras/engine/saving.py", line 419, in load_model
    model = _deserialize_model(f, custom_objects, compile)
  File "/home/tang/anaconda3/envs/fraudect/lib/python3.6/site-packages/keras/engine/saving.py", line 225, in _deserialize_model
    model = model_from_config(model_config, custom_objects=custom_objects)
  File "/home/tang/anaconda3/envs/fraudect/lib/python3.6/site-packages/keras/engine/saving.py", line 458, in model_from_config
    return deserialize(config, custom_objects=custom_objects)
  File "/home/tang/anaconda3/envs/fraudect/lib/python3.6/site-packages/keras/layers/__init__.py", line 55, in deserialize
    printable_module_name='layer')
  File "/home/tang/anaconda3/envs/fraudect/lib/python3.6/site-packages/keras/utils/generic_utils.py", line 145, in deserialize_keras_object
    list(custom_objects.items())))
  File "/home/tang/anaconda3/envs/fraudect/lib/python3.6/site-packages/keras/engine/network.py", line 1022, in from_config
    process_layer(layer_data)
  File "/home/tang/anaconda3/envs/fraudect/lib/python3.6/site-packages/keras/engine/network.py", line 1008, in process_layer
    custom_objects=custom_objects)
  File "/home/tang/anaconda3/envs/fraudect/lib/python3.6/site-packages/keras/layers/__init__.py", line 55, in deserialize
    printable_module_name='layer')
  File "/home/tang/anaconda3/envs/fraudect/lib/python3.6/site-packages/keras/utils/generic_utils.py", line 147, in deserialize_keras_object
    return cls.from_config(config['config'])
  File "/home/tang/anaconda3/envs/fraudect/lib/python3.6/site-packages/keras/engine/base_layer.py", line 1109, in from_config
    return cls(**config)
  File "/home/tang/anaconda3/envs/fraudect/lib/python3.6/site-packages/keras/legacy/interfaces.py", line 91, in wrapper
    return func(*args, **kwargs)
  File "/home/tang/anaconda3/envs/fraudect/lib/python3.6/site-packages/keras/layers/core.py", line 848, in __init__
    self.kernel_initializer = initializers.get(kernel_initializer)
  File "/home/tang/anaconda3/envs/fraudect/lib/python3.6/site-packages/keras/initializers.py", line 508, in get
    return deserialize(identifier)
  File "/home/tang/anaconda3/envs/fraudect/lib/python3.6/site-packages/keras/initializers.py", line 503, in deserialize
    printable_module_name='initializer')
  File "/home/tang/anaconda3/envs/fraudect/lib/python3.6/site-packages/keras/utils/generic_utils.py", line 138, in deserialize_keras_object
    ': ' + class_name)
ValueError: Unknown initializer: GlorotUniform

Env info:
tensorflow-gpu=1.14.0
python=3.6
deepctr[gpu]=0.6.0

@SongRb
It worked with tensorflow keras
model = tensorflow.keras.models.load_model(model_path, custom_objects=custom_objects)


Git tag support in the UI

The UI is currently missing support for git tags. I propose the following additions:

A page that lists all tags /user/repo/tags
Handling of individual tag URLs /user/repo/tags/{tag}. They could either redirect to the tagged commit or present a individual page like GitHub does.

Show a counter of tags in the repository statistics.

Related: https://github.com/go-gitea/gitea/issues/5693 (possible prereq?)

Also add an easy-to-use button to git tag

We're also missing this feature. Is there any progress on this feature request so far?

I believe this has been mostly implemented.

list tags
currently redirect to code view using tag tree
This has not been implemented yet on the commits page, however it can be seen on the graph, and can be seen on an individual commit page


Added many redirects, trackers, and fixed some bugs.

If you have any questions or comments let me know!

Also, I'm not sure how to split this into multiple pull requests by separate commits.


How can I get more than 100 tokens in one day?

How can I get more than 100 tokens in one day?

There is no way to get more than 100 tokens for one wallet in one day as to ensure fairness.


For unsharded dml, fix inner subquery referencing outer symbol

We had a use case come by recently, and this should work as long as all tables are within the same keyspace. It was failing to find the symbol in the symtab, but I noticed processSelect can take an outer bldr. This fix applies to updates and deletes, but not inserts because there was no outer bldr to pass in. Also dont think it makes sense for inserts anyway.
@sougou @acharis

LGTM

@sougou mind taking a look?

LGTM

@alainjobart would you mind merging when you get a chance? (p.s. thanks for all the merges :))


Cleanup

closes #256
todo:

[ ] add flake8 and black to CI
[ ] check how to ignore long docstring tables with flake8

Currently waiting on https://github.com/PyCQA/flake8/issues/1837

I don't think I like flake8 and black, will look into yapf which is more configurable.


Require ColMajor or RowMajor for matrices

Fixes #4875

Require that matrices in laid out structs have RowMajor or ColMajor
set as per SPIR-V section 2.16.2 (shader validation)

The exclusive check is actually already checked elsewhere (in CheckDecorationsCompatibility).


increased tongue papilloma incidence

Add:
increased tongue papilloma incidence (child of increased tongue tumor incidence MP:0010272)
DEF: greater than the expected number of benign tumors consisting of villous or arborescent outgrowths of fibrovascular stroma covered by neoplastic epithelial cells in the tongue
SYN: tongue papilloma
SYN: lingual papilloma
J:69754

increased tongue papilloma incidence MP:0030257


Feature request: Refresh with event

I'm leaving this issue here after a chat with @nikolalsvk on Discord yesterday.
While it's great that render_async allows the rendered partial to be 'refreshed' (i.e. fetched and rendered) on a periodic basis with polling, it would be great if instead it could be refreshed in response to a JavaScript event.
For example, in my case I have a form on the user settings page that updates the user's status in Mailchimp. Because it integrates with a 3rd-party API, I render it asynchronously so that any failures/performance issues don't affect the rest of the page. When the user submits the form (using JavaScript) I want the resulting JS event to then refresh the entire partial to show the new status.
I imagine the API would be something like:
render_async mailchimp_form_path, refresh_event: 'refreshForm', container_id: 'mailchimp-form'

(or maybe you could have a default event name like refreshAsync and use the API only to override that name or disable the behaviour).
Then attach an event handler to the root element that refreshes every time it sees that event.
As an example of how to use it: inside my component, at the end of my form-handling code in JavaScript I could dispatch the event using standard JS. For example:
document.getElementById('mailchimp-form').dispatchEvent(new CustomEvent('refreshForm'))

Let me know if any of the above is not clear and I'll be happy to explain further!

Thanks a lot, @pedantic-git! It really is a pedantic description 😄
I will try to tackle this in the next batch of updates.

Awesome! Looking forward to it! Let me know how I can help!

Hey, @pedantic-git. I added support for dispatching an event with the name refresh on the render_async's container. There is more information in the 2.1.8 release and docs here.
Let me know if this is something you were looking for. Also, let me know if there are some improvements we could make to it so it's even better.
Cheers 🍻

@nikolalsvk Thanks for this! I haven't had a chance to test it in Stimulus because I implemented it in UJS and that implementation works - but I've replaced my hacky UJS view with one that raises the refresh event and it works beautifully!

Awesome, @pedantic-git. I am glad you like it, feel free to share any improvement ideas, it was nice working with you.


Request for reopening incorrectly closed issue

Apparently #2472 has been closed with an improper explanation and marked as resolved. Please review and explain.

Hi @shanto
Sorry for the confusion and thanks for reporting this back, I'll reopen the original issue and close this one, thanks again for using the Edge Devtools for VSCode extension.


add new erc20 token  Lcr

name:Loocar
symbol:Lcr
contract address:0xD4bDBBB9c3d221Ef59624Eb25F3eE84970E713e2

thank you

Please provide more info about the token.

help      What does it contain of  more info about the token

@makoshan  please


JS/TS/HTML Colors

A few things off with colors for JS, TS, HTML:

HTML tags are part purple and blue
Pink and green are slightly lighter
Object dot notation and bracket notation are different colors now (not sure if that was intentional)

Version 1.7.2

Version 2.1.2

Thank you very much! I'll look at it as soon as I can!

Hey ! I've fixed some of your problems in 2.2.0 version ! Can you tell me if its ok for you ? (i keep the objects accessors in orange, because in white/lightgrey, it break the reading for me :) )


community: add mention of git bugreport

Git 2.27 adds the git bugreport tool. Probably this should be mentioned on the "Community" page, and maybe featured in the "docs" page also.

Agreed that it is probably worth mentioning (post-2.27 release, obviously). It might be worth discussing wording with @nasamuffin on the list (and possibly getting an overall review of the bug-reporting advice on that page).

I think it's a great idea. @phil-blain, were you wanting to work on it? Otherwise I can do a little blurb - I've got a couple more outstanding bugreport topics anyways, so I can still make time for it.

@nasamuffin Oh good, I wasn't sure if you'd get the ping since you weren't already in the org (or at least the @-mention didn't autocomplete you :wink:). As somebody who's been thinking on this topic, I'd welcome any suggestions you have for improving the community page.

@nasamuffin you can go ahead.
While I have your attention, I noticed that MyFirstContribution, which I find is a really great resource, is not linked or mentioned from anywhere in the Git repo. I think it could be great to maybe mention it in Documentation/SubmittingPatches since it's linked to in the README, and probably also .github/CONTRIBUTING.md since that's what people are directed to on GitHub when they open a PR.
I added links to it in the website "Community" page and on Gitgitgadget's homepage but I think it deserves more exposure.

Sure. I'll see if I can spend a little time this week or next week to add pointers all over :) Thanks for noticing!

Should a patch for git/git-scm.com be reviewed on the list? Or should I just send a PR? I'm working on this today.

Should a patch for git/git-scm.com be reviewed on the list? Or should I just send a PR? I'm working on this today.

We've typically just used PRs for updates here. But then again, most of the changes aren't so community-oriented. The audience of Git devs here is way smaller than it would be on the list. So I'm happy to review a PR here, but it might be a good opportunity to get wider input by sending a patch to the list.

fyi<EMAIL_ADDRESS>

@nasamuffin you can go ahead.
While I have your attention, I noticed that MyFirstContribution, which I find is a really great resource, is not linked or mentioned from anywhere in the Git repo. I think it could be great to maybe mention it in Documentation/SubmittingPatches since it's linked to in the README, and probably also .github/CONTRIBUTING.md since that's what people are directed to on GitHub when they open a PR.

<EMAIL_ADDRESS>
Same thing for "MyFirstObjectWalk" (could be linked to at then end of MyFirstContribution maybe ?

I think it's a fine idea; might also want to refer to it somewhere in other object walking docs. I'll save this task for another rainy day, but I won't be offended if you want to add it yourself :)


Add Reeder.app v3.0b7

https://github.com/caskroom/homebrew-versions/pull/1240.

Whoops sorry, didn’t see that. Makes sense :+1:


⚠ Bofrost.at has degraded performance

In 0388fbf, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2276 ms

Resolved: Bofrost.at performance has improved in 36a8993 after 22 minutes.


Placeholder wouldn't hide until you press space/special character on Android

Repro steps:
1- Open the placeholder demo page in Chrome on Android. (I am testing on Android 7.1.1, Chrome 64).
2- Start typing non-special characters
Result:
Placeholder won't disappear.
I did a little bit of investigation on this. It looks like the compositionend event is not triggered unless you press space/a special character. One possible solution would be to listen for keyup event on Android rather than the compositionend event.

The typed content doesn't actually get added to the editor until a compositionend event, which is why the placeholder addon doesn't notice it until that point. That's not great, and in the next overhaul of the library we'll probably set things up so that each compositionupdate immediately updates the editor, but for now that's tricky to change.
Maybe we could add event handlers to the placeholder to hide the placeholder when a composition event starts, and when it ends, re-check whether it should be shown depending on the editor content. Would you be able to create a pull request to that effect?

Sure. I will give it a shot sometime next week.

@marijnh @hesamat was this issue ever resolved? I am not able to get the on change event to trigger on an ANDROID device unless a space or special character has been entered.

@dmortimer No it wasn't resolved. I ended up using a hack to address the issue back then.

As Marijn mentioned we are working on a rewrite (CodeMirror 6) that will overhaul input handling and he is planning to address this issue. We are currently raising money for this work: See the announcement for more information about the rewrite and a demo.
Note that CodeMirror 6 is by no means stable or usable in production, yet. It is highly unlikely that we pick up this issue for CodeMirror 5, though.


View Error

Question
Answer

Issue or Enhancement
Issue

Laravel Version
6.18.24

Project Version
3.4.2

Current Behavior

When navigating to a view using the extending the adminlte:page view the following error is thrown. I've checked the source code and the class no longer exists (did in previous versions). The functionality seems to have been moved to a helper file but perhaps there is still some reference to the old location.
Facade\Ignition\Exceptions\ViewException
Target class [JeroenNoten\LaravelAdminLte\Menu\Filters\SubmenuFilter] does not exist. (View: /home/srds/Projects/myacbl-laravel/vendor/jeroennoten/laravel-adminlte/resources/views/partials/navbar/navbar.blade.php)
Expected Behavior

Steps to Reproduce

Possible Solutions

Hi @srealm , please check if #652 helps... I believe the adminlte.php config file need an update...


Release tag version format

This is more of a question than an issue. In my project I am tagging releases in a format like 2018-01-01_1.2.3_456 (a date, followed by a version 1.2.3, followed by another release number 456).
I love how auto-changelog  lists the merge requests, but they all fall into "unreleased" category since it appears it is not using any of our tags as a version number. (Only a couple of very old tags from our repo appear listed, which are indeed in format 1.2.3).
Is there any way to specify the release tag format?
If not, a hint to where to do changes in the code would be also appreciated (I'll be happy to fork and work on the changes to contribute back with the feature).

Nevermind... I found our issue; most tags were being filtered out as not semver.valid().
Since our project uses non-semver tags, and we still find the tool really useful, I forked and added an option to disable validation via semver. The tool is the same; just filtering out "invalid" tags is disabled in that mode.
Please consider accepting pull request #70 . Closing this issue. Thanks!


Ruby 2.2 Support?

After I upgraded my Rails(4.1.8) to Ruby 2.2.0. I notice some error messages in my logs:
app web.1     - - E, [2015-01-02T04:19:12.265987 #12] ERROR -- : listen loop error: unknown key: old_object (ArgumentError)
app web.1     - - E, [2015-01-02T04:19:12.266103 #12] ERROR -- : /app/vendor/bundle/ruby/2.2.0/gems/gctools-0.2.3/lib/gctools/oobgc/unicorn_middleware.rb:14:in `run'
app web.1     - - E, [2015-01-02T04:19:12.266146 #12] ERROR -- : /app/vendor/bundle/ruby/2.2.0/gems/gctools-0.2.3/lib/gctools/oobgc/unicorn_middleware.rb:14:in `process_client'
app web.1     - - E, [2015-01-02T04:19:12.266177 #12] ERROR -- : /app/vendor/bundle/ruby/2.2.0/gems/unicorn-worker-killer-0.4.2/lib/unicorn/worker_killer.rb:51:in `process_client'
app web.1     - - E, [2015-01-02T04:19:12.266207 #12] ERROR -- : /app/vendor/bundle/ruby/2.2.0/gems/unicorn-worker-killer-0.4.2/lib/unicorn/worker_killer.rb:124:in `process_client'
app web.1     - - E, [2015-01-02T04:19:12.266237 #12] ERROR -- : /app/vendor/bundle/ruby/2.2.0/gems/unicorn-4.8.3/lib/unicorn/http_server.rb:670:in `worker_loop'
app web.1     - - E, [2015-01-02T04:19:12.266267 #12] ERROR -- : /app/vendor/bundle/ruby/2.2.0/gems/unicorn-4.8.3/lib/unicorn/http_server.rb:525:in `spawn_missing_workers'
app web.1     - - E, [2015-01-02T04:19:12.266296 #12] ERROR -- : /app/vendor/bundle/ruby/2.2.0/gems/unicorn-4.8.3/lib/unicorn/http_server.rb:140:in `start'
app web.1     - - E, [2015-01-02T04:19:12.266324 #12] ERROR -- : /app/vendor/bundle/ruby/2.2.0/gems/unicorn-4.8.3/bin/unicorn:126:in `<top (required)>'
app web.1     - - E, [2015-01-02T04:19:12.266354 #12] ERROR -- : /app/vendor/bundle/ruby/2.2.0/bin/unicorn:23:in `load'
app web.1     - - E, [2015-01-02T04:19:12.266381 #12] ERROR -- : /app/vendor/bundle/ruby/2.2.0/bin/unicorn:23:in `<main>'

I was wondering do we still suppose to use it on Ruby 2.2? Or it should only be used on Ruby 2.1?

oobgc is unnecessary in Ruby 2.2, since it includes an incremental GC (RIncGC) and will not pause the world for a long time.

Thank @tmm1 .

I'm going to leave this open (so others can find it) until I get a chance to update the README.

Any chance you might merge hale's pull request?   I, too, inferred that gctools was still relevant to Ruby >= 2.2, since the repo had recent commits but had no mention of being obsolete.  Thanks!

@tmm1 I believe v0.2.4 supports ruby >= 2.2 quite well now.

So if it's not needed in 2.2 what does it do when we run it in Ruby 2.2?

@thedrow I believe it "just works". I think this commit adds support for the ruby 2.2 symbol name.

I'm confused. It doesn't fail but it does nothing useful on 2.2? Or does it still provide a benefit when running under MRI Ruby 2.2?

The answer to "is there a benefit" is... wait for it... workload dependent. Tada! What a shocker!
RIncGC behaves differently from a web-request-based "Out-of-band GC", so you can't replace one with the other and expect the exact same performance behaviour.
If your app spawns a lot of temp vars and triggers multiple GC runs during every request, and you'd like to have a clean slate before every new request (and avoid triggering as many GC during requests--remember, RIncGC still slows your app down, they just won't block for the entire duration of a GC run), then OOBGC can still be helpful. If, on the other hand, you've kept your app pretty light and there isn't a lot of garbage created per request, and a GC is only triggered once every few requests, then OOBGC will actually hurt you (very slightly) than give any benefits.
However, these are broad stroke assumptions! You MUST profile your specific app!
Where assumption and reality diverge is where you'll have performance issues.


i2c: silabs: Fix I2C target crash on long ISR execution

Long I2C target callback functions could lead to an unresponsive I2C peripheral. This commit ports the official ISR implementation from Silicon labs to Zephyr:
https://github.com/SiliconLabs/peripheral_examples/blob/master/series2/i2c/i2c_follower/src/main.c#L179
The previous I2C target implementation I have done myself and it worked in most cases.
The I2C target callbacks should should return quickly because they are executed in an ISR. But user might not be aware of that and trigger an unresponsive I2C peripheral (Leader can not longer access follower).
The new implementation does not have this issue and is also able to handle bus error.

It is not important to me to see this in release 3.5.
I do not think I have the access rights to assign labels and milestone to my PR.
I am missing the Gear/Cog symbol next to labels section that I see on other projects:

I am sorry, I missed an unused variable warning.
I am surprised that the CI did not pick that up. Locally the following twister run was failing before my latest change:
./zephyr/scripts/twister --platform efr32bg22_brd4184a -T zephyr/tests/drivers/i2c/i2c_target_api

I am not very familiar with the GitHub CI. But to me it seems like twister never runs for board efr32bg22_brd4184a.
In jobs twister-build(1-4) the run step does not seem to use this board as a platform.
If this really is not build, I think it would make sense to add that. If so I would create a PR for that but I am not really sure how to add a new board to the GitHub CI.


change_the_code.py

Thanks for your contribution! However, Your code doesn't plot graphs via matplotlib. Also, I want people to learn by implementing the uniform function themselves, rather than using the black box uniform function in scipy.


Add SHA384 TBS hash

In some cases the Microsoft HVCI block list contains SHA384 of signature TBS issuer, would be useful to add that as well in the next version: https://github.com/magicsword-io/LOLDrivers/commit/41d88e260f26094f60656c0ddc23f5c9a3f3ff2b

Might have to regen the yaml files for this to kick in but I added your suggestion thank you!


Fix method errors from codacy

Coverage remained the same at 16.272% when pulling 5c3864109cfdf193c05f2700f59161b0eb49e601 on develop into abd898012e75f3f4b03777765668eb17aa7b2d4f on master.


Next.js page not overwritten by file in public/

We replaced a file that was served through pages/mypage.js with a file that is served through public/mypage. According to this thread, artifacts from the last 6 builds are restored on build unless specifically overwritten. When deploying the app, the old file pages/mypage.js is therefore still served instead of public/mypage because the new file does not overwrite the old one before the build. I think this is a bug, as the new file certainly overwrites the old file after the build as they use the same url.

Hi @adrian-kriegel can you provide region, appId, branchname, and example build number?
Also if you can provide a code sample with steps to repro it will help us investigate.

@adrian-kriegel we have reverted the behavior of storing the last 6 builds based on a lot of complaints. This should work for you now.


[Tooltip] Issue

Expected behavior:

Current behavior:

@kaiqueaguilar
Thanks for taking your time to report this issue. This will be fixed with a next Panda release https://github.com/cschroeter/park-ui/issues/264


Markdown data URLs are now broken

Issue Type: Bug
I frequently use base 64 encoding to embed images directly in a markdown document, this worked until some previous version. Now the links are broken because the constructed URL is prefixed with vscode-resource:; i assume for relative link resolution, as the prefix points to the current directory.
So you get rendered HTML like this:

When it should be:

VS Code version: Code 1.28.2 (7f3ce96ff4729c91352ae6def877e59c561f4850, 2018-10-17T00:23:51.859Z)
OS version: Windows_NT x64 6.1.7601

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4710MQ CPU @ 2.50GHz (8 x 2494)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
7.88GB (1.02GB free)

Process Argv
--disableExtensions

Screen Reader
yes

VM
0%

Extensions disabled

Have you added this code in your file ?
  <meta charset="utf-8" />

No, i have not, just regular markdown along the lines of:
![pic](data:image/png;base64,...)

This new mechanism also messes with some extensions, e.g. https://github.com/neilsustc/vscode-markdown/issues/296

Try to show the image with https:// but not data:image/


feat: network selector on explorer

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type

[ ] Bugfix
[x] Feature
[ ] Refactoring

Context

[x] Closes #4886
[x] branching from https://github.com/kodadot/nft-gallery/pull/4846
[x] related with #4474

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </bsx/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

powerful

Hiii, nice
one little change from the sort by issue

text to black - on k-accent(primary) we dont use white color because there is smaller contrast than with black.

can we please make the button work as in gallery chart; when you choose sub-option it became visible on the button.
so when I chose basilisk

the button should have the text - basilisk

Will we enable multi-select like on sort by? (not sure in this stage) If so, the number of activated options would be useful as well. cc @yangwao
Thanks!

can we make it to only display the network name without the "network:"

now the button is changing its width based on how long the name is - can we make it fixed?

otherwise alright! thanks

now the button is changing its width based on how long the name is - can we make it fixed?

are we sure about fixed width? it can have an impact on responsive mode

Will we enable multi-select like on sort by?

probably not in this

how about change the text to this for now: Network: Basilisk

yes, could be
Terms of stuff in button, I would keep for sake clarity end user "Network" there as prefix, yet on dropdown could be w/o
rarible

btw, sry disturbing lovely discussion, yet happy to move on and not get stuck on wording :D

can we make it to only display the network name without the "network:"

we can still use some sort of label. People outside of Ethereum barely knows what are names of other parachains in Polkadot, not even canary networks on Kusama

what are the other options how we can avoid button jumping? - there will be a layout change button in future - which would be influenced by this.

we can reflect in explorer feedback

pay 50 usd


De Bruijn: makes type A a parameter to the Steps data type

In the chapter on de Bruijn indices, this patch changes the Steps data type such that type A is its parameter instead of index. This makes it unnecessary to quantify over A in the data constructor steps, even more so because both L and N are of type ∅ ⊢ A. In other words, no need to unify two As because they are the same anyway.

Yep, that looks better!


[RFR] [OSF-7948] Delete subjects_acceptable list from PreprintProviderSerializer

Purpose
[#OSF-7948]
Preprint providers should not have subjects_acceptable in API response
Changes
Deprecated subjects_acceptable
New API version 2.5
Renamed PreprintProviderSubjectList to PreprintProviderTaxonomies as it is now only used by the taxonomies endpoint.
v2 API
curl -s http://localhost:8000/v2/preprint_providers/agrixiv/ | jq '.data.attributes
' | jq keys
[
  "additional_providers",
  "advisory_board",
  "allow_submissions",
  "banner_path",
  "description",
  "domain",
  "domain_redirect_enabled",
  "email_contact",
  "email_support",
  "example",
  "footer_links",
  "header_text",
  "logo_path",
  "name",
  "share_source",
  "social_facebook",
  "social_instagram",
  "social_twitter",
  "subjects_acceptable"
]

v2.4 API
curl -s http://localhost:8000/v2/preprint_providers/agrixiv/?version=2.4 | jq '.data.attributes
' | jq keys
[
  "additional_providers",
  "advisory_board",
  "allow_submissions",
  "description",
  "domain",
  "domain_redirect_enabled",
  "email_support",
  "example",
  "footer_links",
  "name",
  "share_source",
  "subjects_acceptable"
]

v2.5 API
curl -s http://localhost:8000/v2/preprint_providers/agrixiv/?version=2.5 | jq '.data.attributes
' | jq keys
[
  "additional_providers",
  "advisory_board",
  "allow_submissions",
  "description",
  "domain",
  "domain_redirect_enabled",
  "email_support",
  "example",
  "footer_links",
  "name",
  "share_source"
]

Side effects
None
Ticket
OSF-7948

@TomBaxter Could you add to the PR description a copy of the JSON for the original code, the current code at a version that shows this, and at version=2.5? Just copy the text and put in code blocks is fine.

@brianjgeiger  The output of "preprint_providers/agrixiv/" is very verbose. I thought it might be too much for the PR description. In fact it this over verboseness might have been the impetus for this ticket. I put in a curl/jq one liner that shows the difference created by this PR and also the cumulative changes since 2.0.
I think jq is a common utility, hopefully available on Mac. Let me know if this is sufficient, or if you still want the entire output in the PR description.


undefined reference to nvglImageHandle in nanovg_gl_utils.h

nanovg_gl_utils.h:67: undefined reference to `nvglImageHandle'

This is from the HEAD while trying to build the examples
All I did was pull the latest master
Steps to reproduce (?)
git checkout master
git pull origin master
# I had an old build folder
rm -rf build
premake4 gmake
cd build && make

Sorry about that, the PR #201 seemed to broke this, fixed. Thanks for reporting it! Fixed in b83cf926525e7cea8d2483da2a75852b8c7b6d28

@memononen Awesome, that was fast thanks!


feat: Add event_id to event response, move seamapi-types to prod dependencies

Typescript doesn't bundle types from seamapi-types, meaning that unless a consumer also installs seamapi-types events.list(...) will return Promise<any[]>.

@codetheweb Is there any precedent for adding types to a js package dependencies? I feel this is unusual and there should be a TS build-step solution.
Although I'm not sure if this will have dire consequences, It means that consumers will have types in their production dependencies which is not something they would expect to see.

Agreed, but I've looked before and there's not an easy solution to bundle external types with our current setup.
We have much heavier dependencies that also aren't needed in most cases (looking at you yargs 👀) so I don't see this as too problematic for now.


Why include FreeRTOS source code copies in NimBLE library

I just noticed that NimBLE has its own copied of FreeRTOS.h and .cpp included, whcih are not in sync with the version of FreeRTOS we used before including NimBLE into our project.
It also changes handling of logging of standard FreeRTOS functionality to use the NIMBLE_LOG methods.
Is there a specific reason for copying this code into the library, besides changing the logging structure?
Is there an easy way to exclude these files from being compiled when someone prefers using the original and updated ones?

Hi @Bascy it's just been here historically since this started because they were used by this library originally.
That is no longer the case but I have left them in up to now to not break anything for anyone that was using them.
These will simply be removed in the future. You can just delete the files for your use most likely, though it may cause conflict if the original BLE library gets linked in.

Removing them is indeed a working work-around .. but that won't work on my CI/CD pipeline as it will always retrieve the latest version of NimBLE from git. Also when I refresh libraries locally, I have to remember to manually delete the files ....
I'll have to figure out a way to remove the files on every build ...
Just out of curiousity .. as this lib is specifically for the esp32 architecture .. aren't the FreeRTOS files always there already?

For now I would suggest forking this repo and pointing your sources to your fork with the files removed.
Originally I was going to modify those to get rid of much of the excess in them but it wasn't a pressing concern. In the next release I will consider their removal.

Just in case you're interested the 2.0.0 branch has a lighter weight version of those files, also renamed the header.

How stable is the 2.0.0 branch?

It's quite stable in my testing so far, but you may need to make some code changes in your application. I still need to do the documentation on it and more commits are coming.

Sorry for stealing this issues but you made me curious :)
Can you already name some changes in the 2.0.0? And what code changes are needed for example?

I will have to go through my notes on it but there isn't much that I can think of right now. I've been in testing mode on it for a while and don't remember all of it. Most of the changes will show up on compilation if it's used by your app code. I have breaking changes in the works for future commits on it though.

Thanks for the info. Looks like I'll have to be patient. :grin:
The idea with just testing and looking for compilation errors was of course "too obvious" as I would have thought of it... :joy:

I'l go for the fork solution :)


Need to call page when using GCEList for pagination to work

Otherwise, the if self.gce_params: condition will evaluate to false as the dict remains empty.
This is a follow-up fix to https://github.com/apache/libcloud/pull/939

Coverage increased (+0.003%) to 88.978% when pulling f2395f361ae08b080f5e5daa3996de6456310056 on KMK-ONLINE:gce-500-images into 7c841938a191959ce926f81a3f6177df28d4682f on apache:trunk.

Thanks for the contribution @sayap please can you resolve the linting error https://travis-ci.org/apache/libcloud/jobs/269134539

Coverage increased (+0.003%) to 88.978% when pulling 8bb7e0c4161b3d3478ee2c739a126b3da7f68f8b on KMK-ONLINE:gce-500-images into 84735c8924f75394426e37106ed7db5070dd0071 on apache:trunk.

@tonybaloney I have got rid of the linting error with slightly better variable naming :)

Note that GCEList defines an __iter__ method, so it would be simpler to write for image in project_images_list: and remove the for image in page:.
But your fix works too and is more explicit about the pagination! 👍

@pquentin Actually, pagination only works after calling the page method.
We need this:
https://github.com/apache/libcloud/blob/8bb7e0c4161b3d3478ee2c739a126b3da7f68f8b/libcloud/compute/drivers/gce.py#L305
so that this evaluates to true and we get pagination:
https://github.com/apache/libcloud/blob/8bb7e0c4161b3d3478ee2c739a126b3da7f68f8b/libcloud/compute/drivers/gce.py#L125
I can't speak for the original author, but it seems like that's how it was designed to work in 1ed50204

Oh, you're right, sorry! Got confused by the return self hack. I now understand that __iter__ return sublists.

@tonybaloney @Kami this pull request is ready to be merged.

@sayap Thank you for your contribution! It has just been merged in trunk.


Budget App V1.0.0

Implement budget tracking app features
This PR implements all the main features of the budget tracking app:

User authentication with Devise
Categories CRUD
Transactions CRUD
Category show page with transactions
Transactions show page
Home page and dashboard
Styling with Bootstrap
Model validations and associations
Authorization with Pundit
RSpec specs

Changes:

Add Devise gem and set up user model
Generate Categories and Transactions controllers
Add category and transaction models
Build out CRUD actions in controllers
Add category and transaction views
Set up nested routes and links between pages
Add Bootstrap for styling
Configure database
Write model and feature specs
Add flash messages

Let me know if you would like any changes made to the implementation, tests, styling, etc! And please provide feedback on the code quality and architecture.
Thanks and looking forward to your review !

Hello Dear reviewer, If you encounter the following
ERROR: worker mode not supported on ruby on this platform
please comment out
workers ENV.fetch("WEB_CONCURRENCY") { 4 }
on the config/puma.rb file.
It was uncommented to make the deployment smoother.

Hello @naanmohammed ,
I have a suggestion for you.
The :confirmable was just an optional recommendation. I see that you have implemented it but the next reviewer couldn’t access the app. You may remove it for now and fix the major required changes that I recommended. You can enable the :confirmable later after the project has been approved.

Thank you @Whoistolu. I have removed the confirmable and resubmitted.

Dear Reviewer, please note the confirmable was optional as specified by my previous reviewer. Thank you and looking forward to your review.

Thank you tons, @Qoosim ! Have a great weekend!


Flake: git fetch packfile does not match index

During Travis run of analysis shard, saw the following git failure:
Running "flutter packages get" in complex_layout...
Git error. Command: git fetch
error: packfile ./objects/pack/pack-626e142fd37b210efcb529f5272d88034fb56397.pack does not match index
error: packfile ./objects/pack/pack-626e142fd37b210efcb529f5272d88034fb56397.pack does not match index

It's not clear that there is anything actionable here, re-open if you disagree

I haven't seen this in a long time, but the actionable item would be to provide a useful error message to the user. I'm fine leaving closed until someone else reports this.


Scenes corrupted when switching to "Import As" Animation Library.

Godot version
Version: v4.1.1.stable.mono.official [bd6af8e0e]
System information
Win 11 - Forward+
Issue description
This is my first Godot project, coming from Unity, so please bear with me.
Tested with multiple .glb files
Models are exported form Blender 3.3.10 but also tested 3.3.4 and had same issue.
Steps to reproduce
On the Import Panel,
Import As: Animation Library
Reimport
-editor closes and reopens-
"Scene corrupted"
Scene is no long accessible/usable.

Minimal reproduction project
Jump to \Project\Models\Characters
Depart(Godot).zip

I think this is "expected", in the sense that your inherited scene depends on a resource that doesn't exist anymore once you change the GLB's import type:
[ext_resource type="PackedScene" uid="uid://bbf56uaq1yg05" path="res://Project/Models/Characters/greyboxman.glb" id="1_bj302"]

This results in one of the scene's dependencies not being found when you open the scene, and Godot currently doesn't feature a way to resolve these issues from the editor.
Godot should probably warn when changing an import type of a resource that is depended upon in other scenes/resources, so that you can prepare for those situations in advance. Missing dependency resolution is also something that should be added: https://github.com/godotengine/godot-proposals/issues/6838

So this isn't as much a bug, as a missing implementation for warnings / prompts.
"You're about to orphan a scene or scenes that depend on this asset. Converting this asset to "Animation Library" will effectively break those scenes. Are you sure?"
I did warn that I was very new >_<
I am willing to test with other versions of Blender if you think that will help. Blender Launcher makes that fairly easy.

I would disagree that this is a matter of a missing prompt.  You shouldn't be able to break entire chains of scenes so easily, in such a way that the editor is unable to open the broken scenes.  In playing with this I broke three whole scenes because of the fact that the leaf scene was corrupted and deleting that scene caused the scenes in which it was instanced to fail to open with an unhelpful error message.  I did eventually go in manually and delete the offending references in a text editor to salvage my scenes, but this would be a terrible issue with deep nesting.
Instead of failing to open with an unhelpful error message it would be better if the editor could open the scene anyway but with some indication that a node is broken (perhaps red text, or a strikethrough).  If other corruption is detected then at the least it would be ideal to point us in the file to where the corruption is.


Fix botfront.io bad url

Fix botfront.io bad URL
Proposed changes:

fix type in botfront.io URL in the readme, previously it's being redirected to botront.io instead of botfront.io

Status (please check what you already did):

[ ] made PR ready for code review
[ ] added some tests for the functionality
[x] updated the documentation
[ ] updated the changelog

thanks :)


Add guidance for the PowerShell script to create sample

I have created the PowerShell script, so just need to write guidance and let folks know it exists.

@pkbullock Can you share more information about this issue? Where is the PowerShell script, what is the use of this script and how we can use it?

Completed


Swap interval ignored on macOS 13

OpenGL swap interval seems to have broken again, as reported in #1990, after having been fixed in 12.1.

I just noticed this bug today, since I recently updated to macOS Ventura (13.2). Looking into how SDL handled this issue, it appears they reintroduced their CVDisplayLink code for OpenGL contexts: https://github.com/libsdl-org/SDL/issues/4918

discovered this just now. even setting glfwSwapInterval to a ridiculously high number seems to have no effect. not sure of a good workaround for this

because glfw 3.4 is not on vcpkg yet, i built it from source to try the init hint:
glfwInitHint(GLFW_ANGLE_PLATFORM_TYPE, GLFW_ANGLE_PLATFORM_TYPE_METAL);

to make extra sure ANGLE wasn't choosing to use OpenGL, i did not include "-framework OpenGL" in target_link_libraries in CMakeLists.txt; only "-framework Cocoa and -framework IOKit" which i need otherwise I'll get linker errors. even with glfwSwapIntervals the loop is still running at hyper speed... like each loop time is a fraction of a millisecond, and is consuming 100% of the CPU.
interestingly, this does not happen when i use OpenGL to the same degree. perhaps this is a bug with the vcpkg unofficial port of ANGLE?

On a MacBook Pro 2019 and MacOS Ventura 13.0.1. ---- Using GLFW 3.3.8
When I enable vsync, I am seeing 120 FPS, even though the monitor's refresh rate is 60Hz.
It is also strange that even if I try glfwSwapInterval(2), I still see 120 FPS. In fact, the argument of glfwSwapInterval seems to be meaningless, as I see the same results even with something like glfwSwapInterval(100).
It looks like there is something wrong happening.

I've found this to be a somewhat urgent bug for me, so I've created a temporary fork. It's basically GLFW 3.3.8 with most of the changes in https://github.com/glfw/glfw/pull/2277 applied to it.
Note: I've broken Windows + Linux builds since I'm only using this for now.
The changes are here: https://github.com/RustyMoyher/glfw_MacVsyncFix/commit/7a5a9dcf1f3ecfe45ed831c1f024328717533214.
Hope anyone else finds this useful!

Are there any updates on when this may get resolved upstream without a fork? I am currently affected by this issue. When setting glfwSwapInterval(0) FPS is mostly unlimited. When setting glfwSwapInterval(1) or any value other than 0 then the FPS is locked around 120fps.

In the meantime, following @RustyMoyher's comment and #2277, I was able to implement a similar workaround externally from GLFW without needing to patch or fork. See https://github.com/deepmind/mujoco/commit/2f0fb1e4ef81ae4eb281e09fb67c6b36f27dc427.
It does require put macOS-specific, #ifdef-guarded stuff into your own code though.

Update: my attempt at fixing this in my temporary fork of 3.3.8 only partially worked. It still sometimes stutters, though the stutters are infrequent. I'm not sure if I failed to port the changes in #2277 correctly or if there is some kind of race condition in the mutex or something.
I may look into adding an external workaround as @saran-t's suggested.

I can confurm this bug on mac os Ventura 13.5.1. i5 2017

I found that calling glfwSwapBuffers on the DisplayLink thread can lead to sporadic, random crashes (hence https://github.com/google-deepmind/mujoco/commit/81ba9ec54a8ed1dfd10386a6afb7b3555c244d56).


Automatic block finalization

Right now, blocks are finalized only manually with RPC engine_finalizeBlock.
Allow immediate block finalization in swanky-node development.
See more details https://github.com/paritytech/substrate/pull/12106
This requires polkadot version uplifts to v0.9.30 as a premise.

Since we customize instant seal, there's no need for wait substrate base branch uplifts...


Error with subscripting way using path.

I found it is not work correctly when I make some playground examples.
The both ways below are written in README.
// Error
let path = ["users", 1, "info", "name"]
let feed = jsonArray[path].string

// Work well
let keys: [JSONSubscriptType] = ["users", 1, "info", "name"]
let feed = jsonArray[keys].string

JSON Example
// Example json
var jsonArray: JSON = [
    "array": [12.34, 56.78],
    "users": [
        [
            "id": 987654,
            "info": [
                "name": "jack",
                "email"<EMAIL_ADDRESS>            ],
            "feeds": [98833, 23443, 213239, 23232]
        ],
        [
            "id": 654321,
            "info": [
                "name": "jeffgukang",
                "email"<EMAIL_ADDRESS>            ],
            "feeds": [12345, 56789, 12423, 12412]
        ]
    ]
]

I believe the documentation is outdated 👍


pretrain data download

if is it possible to split pretrain data into multiple seperate zip files。
I download data from google drive : https://drive.google.com/drive/folders/1-3kAsyZIVFbNelRXrF93Y5tMgOypv2jV
i cannot download this data because of google drive time limit(less than 1 hours) and my limit network bandwidth。

Hi @zhouxingguang,
Please download the data in small chunks from https://drive.google.com/drive/folders/1YiudOuP9hTFEVsK_ntClWHljnc35W-WM?usp=share_link
Note that you have to merge all the zip files before unzipping. I hope it will be helpful. Thanks


Split APK is unsupported by the asset extractor

Later versions of the game transitioned to a split APK. These do not work as intended with the hardcoded pathing of the file extractor. No other changes to the files are expected (still boots, as per https://github.com/bullbin/widebrim_hd/issues/1) but necessary as a quality of life fix.

Closed with 0cd2ef8.


TfLite Generating the project issue

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 20.04
TensorFlow installed from (source or binary): https://github.com/tensorflow/tflite-micro.git
TensorFlow version (or github SHA if from source):

While running the command
make -f tensorflow/lite/micro/tools/make/Makefile TARGET=esp generate_hello_world_esp_project
facing the error as:
find: ‘../google/’: No such file or directory
tensorflow/lite/micro/tools/make/downloads/flatbuffers already exists, skipping the download.
tensorflow/lite/micro/tools/make/downloads/pigweed already exists, skipping the download.
tensorflow/lite/micro/tools/make/download_and_extract.sh "https://github.com/google/gemmlowp/archive/719139ce755a0f31cbf1c37f7f98adcc7fc9f425.zip" "7e8191b24853d75de2af87622ad293ba" tensorflow/lite/micro/tools/make/downloads/gemmlowp
The required 'curl' tool isn't installed. Try 'apt-get install curl'.
make: *** [tensorflow/lite/micro/tools/make/Makefile:583: tensorflow/lite/micro/tools/make/downloads/gemmlowp] Error 1
How Do I resolve this?

The required 'curl' tool isn't installed. Try 'apt-get install curl'.

Have you tried installing curl as mentioned in the logs?

Yes.

I am using Amazon FreeRTOs ESP IDF path


Run go mod tidy before verifying modules to lint modules

What this PR does / why we need it
Fixes a core issue that was missed as part of #2467 PR

Run go mod tidy before verifying modules to lint modules
Update the outdated go.mod and go.sum files

Details for the Release Notes (PLEASE PROVIDE)
NONE

Which issue(s) this PR fixes
Related - #2453
Fixes #2469 - related issue and gets fixed as this PR updates all outdated go.mod and go.sum files to pass the lint checks. cc @chenliu1993
Describe testing done for PR
make verify-modules

OR
make lint

Run twice and check there are no go.mod and go.sum diffs in the git repo and no errors in the execution of the above command(s). Also cd into any go modules directory and do go mod tidy and check if there are any diffs in go.mod and go.sum files
Special notes for your reviewer
--

ccing @seemiller @heww from https://github.com/orgs/vmware-tanzu/teams/pkg-harbor-owners , could you review this PR? 🙏 Or ping someone from harbor team who could? Thanks

ccing @seemiller @chenliu1993 from @vmware-tanzu/pkg-multus-cni-owners , could you review this PR? 🙏 Or ping someone from multus-cni team who could review? Thanks.

Hi @vmware-tanzu/pkg-harbor-owners and @vmware-tanzu/pkg-multus-cni-owners
Can we both get an approve from someone in these groups?

Sorry folks. I had to rebase the PR with main to resolve conflicts with 3 files (go.sum and go.mod files). I request everyone to try to review this soon so that we can merge this as soon as possible or else we are gonna be in the loop of - require-approval-from-all -> half-approved- > changes in main which conflicts with PR changes -> update PR nullifying all the approvals -> require-approval-from-all

@dvonthenen Can we use power of  @tce-owners  to get this merged to avoid the rebase cycle please? :)


Dynamic Lex Bots

Amplify CLI Version
11.0.0
Question

Says bot is not available even if I hard-code details in aws-exports. I'm using your waitUntilBotAvailable function, and it says it's available, but your chatbot UI says the bot doesn't exist.

Can I not build a bot on the front-end, and use it dynamically? Or do I need to hard-code every bot in aws-exports. I have different chatflows, that are dynamic, and I would like to spin up unique bots at runtime.

Using React + TypeScript

Hey, 👋 thanks for raising this! I'm going to transfer this over to our AmplifyJS repository for better assistance 🙂.


How to complete the authorization process of authorization-code?

Run Authorization Server、client and Resource Server.
I can go through the
http://<IP_ADDRESS>:8080/oauth2/authorization/messaging-client-oidc to complete the OIDC process, but when I use
http://<IP_ADDRESS>:8080/oauth2/authorization/messaging-client-authorization-code
I will encounter an error
When accessing http://<IP_ADDRESS>:8080/authorized?code=zbOg5l2FYSs0twPrzbqLidWx_5n7tQXslY8PBxgUNxH3Y157Kq1Ju9DGy4uh_k6dWHgua4L5k_HJYTivJ- zxarZsvr-lalIGA1ZP2D4ngblgkn_tGvwrxM8wTlopDDgL&state=mzy9FUw5GQbW9e2esIvMPAGn0fwOIjdYZIepiBX54Zs%3D
will be 302 to http://<IP_ADDRESS>:8080/authorized and will have StatusCode:400

add some http detail

when I use http://<IP_ADDRESS>:8080/authorize?grant_type=authorization_code
I need consent oidc first and then message.read.
How to bypass oidc？