message_view: Update autoscroll on message sent.

Updates the autoscroll behavior when sending a message. Will now autoscroll to the bottom of the message list if bottom of the view is visible, moving the message selection to the message at the top of the view.
Concerns message_list_view.js and message_viewport.js.
Fixes #23298
Design considerations
When designing the implementation, I had to move the code that reduces the scrolling depending on how much the compose box shrinks after being cleared. This is because it was now needed to determine whether the user had scrolled up at the beginning of the render function while taking into account the size of the written message. I was unsure whether to add an argument to is_scrolled_up() and offets_from_bottom(). Ultimately I decided to add arguments since this is the only context in which these functions are used. Please tell me if you'd like to me to handle this differently.
Screen capture:

@timabbott Thanks for the review and sorry for the late response on my part.
I've updated the commit to address your comments. I also removed the return value of _maybe_autoscroll since it is no longer necessary.

Sorry this got lost! There was no comment tagging me, so I was not aware that my review was the next step on this PR.

It's a bit hard to figure out how to test, but I was able to generate an example where the feed scrolled correctly when I sent a message, and the blue box moved down.

Anyway, I think we could try this on CZO. This issue was reported again today, and I'd love to see an improvement here.
I'm wondering if we'll actually want to be more aggressive with scrolling, and do so any time the bottom message in the feed is at least partially in view, rather than requiring the bottom of the feed to be visible. But we can start with this.
@timabbott tagging for another look from you / CZO deployment if/when it's ready.

@JoeyPriceless Would you be up for getting this PR rebased?

@amanagr Would you be up for doing a rebase? We just got another bump on #8021, and I'd love to get this tested.

Is there any hope of getting this PR merged? This is a much needed feature.

@timabbott Let's get this tested soon after the release. The current behavior has been regularly bugging me as well.

some folks on our team are also hoping for this feature.  as you mentioned, @alya, you wanted this to get tested "soon after the release".  I'm assuming you mean release 7.0, which as of this post is 1 month old; furthermore there's a 7.1 release 2 weeks old, now, which apparently still doesn't have this feature in it, going by the "open" status.
I understand product dev, and QA in particular, is a big process.  Just wondering if this is still something you're eyeing as part of that process or if it got kinda forgotten again.

Hey @timabbott, I've added this PR to your "integration review" list. If I'm getting it right, we'd like to give it some time to settle in CZO after the release.

looking forward to this issue being fixed — we have just started using Zulip as a Slack alternative and are all finding that you have to click scroll after sending a message really difficult to get past 🤞

Closing as this effort was finally integrated via https://github.com/zulip/zulip/pull/29398; thanks for the work on this @JoeyPriceless!


Update timeout for .github/workflows/ci.yml

This is an automated pull request to update default timeouts for all jobs in .github/workflows/ci.yml that do not currently contain a default timeout property.
Please review these changes closely to ensure that all jobs have sufficient time to run. If a job needs more time, please add a timeout property to that job to override the organization default.
Additionally, please be attentive to unintended changes to the workflow YAML file, as the parser is not perfect.
Lastly, note that it is up to the reviewer to merge this pull request and delete the PR branch once they are satisfied with the changes.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Consider using Disco API instead of Jabba

Consider using the Disco API for all the metadata about Java distributions, vendors, platforms, URLs, etc.
https://github.com/foojay2020/discoapi
Jabba is not kept up to date. ( https://github.com/coursier/jvm-index is currently being used, but then we wouldn't need to maintain it.)
EDIT: Jabba seems to be dead https://github.com/shyiko/jabba/issues/833

Closing in favor of https://github.com/coursier/coursier/issues/2057.


Submission-Group<PHONE_NUMBER>-2310365-2310381-2310251

Name
Commit

Doãn Phương Hùng Cường-2310381
Searching for algorithms, debugging.

Nguyễn Chu Nguyên Chương-2310365
Implementing policy

Nguyễn Võ Thiên Bảo - 2310250
Searching for algorithms, debugging.

Phan Gia Bảo - 2310251
Write report, dairy and support

2.Brief Description

BestFit:The Best-Fit Bin Packing heuristic can be adapted for use in the Cutting Stock Problem

(CSP), though the two problems have different structures. While CSP involves cutting

larger stock pieces into smaller pieces to meet demands, the Best-Fit algorithm focuses on

fitting items into bins with minimal unused space. However, the goal in both problems is

to minimize waste or unused material.

Step 1:Define Cutting Patterns

Step 2: Sort Cutting Patterns by Efficiency

Step 3: Place Items (Demand)

Step 4: Repeat until Demand is Met

Step 5: Adjust Stock Usage

Bottom Left Decreasing:Bottom left decreasing (BLD) algorithm. Rectangles given on the list L are

ordered according to nonincreasing sizes. Put the next element from L as low and as

much to the left as possible.

Step 1:Initialization

Step 2: Placement of Pieces

Step 3: Update the Available Space

Step 4: Repeat Until All Pieces Are Placed

3. Results summary:

Algorithm
Average Trim Loss

----------
-------------------

BF
0.2578

BLD
0.3566

Please revise the PR in Dec 16. Otherwise, your group will get 0 score for code.


spring-petclinic-customer-service

I took the latest code from git. I tried to compile the spring-petclinic-customer-service but it was failing for dependency "spring-petclinic-monitoring:jar:2.0.3". I tried to solve it but nothing worked for me.
Can you please suggest

Hi there,
I did the build it from root path but when I was trying to run spring-petclinic-customer-service and I was facing below error, I tried to use mvn install command in spring-petclinic-monotoring project but no use,
[ERROR] Failed to execute goal on project spring-petclinic-customers-service: Could not resolve dependencies for project org.springframework.samples.petclinic.client:spring-petclinic-customers-service:jar:2
.0.3: Failed to collect dependencies at org.springframework.samples.petclinic.monitoring:spring-petclinic-monitoring:jar:2.0.3: Failed to read artifact descriptor for org.springframework.samples.petclinic.m
onitoring:spring-petclinic-monitoring:jar:2.0.3: Failure to find org.springframework.samples:spring-petclinic-microservices:pom:2.0.3 in http://repo.spring.io/milestone was cached in the local repository, r
esolution will not be reattempted until the update interval of repository.spring.milestone has elapsed or updates are forced -> [Help 1]

Could you please try to go to the spring-petclinic-monitoring sub-directory and you manualy build the org.springframework.samples.petclinic.monitoring:spring-petclinic-monitoring:jar:2.0.3 artefact?

Any news?

No feedback. Please reopen this issue if your problem persists.


Add policy packs for GCP KMS

enforce_crypto_key_not_publicly_accessible

check_crypto_key_not_rotated_daily

@Subhajit97 I think we can set the time period of rotation to 90 days as in the GCP > CIS v2.0 it states that 1.10 Ensure KMS Encryption Keys Are Rotated Within a Period of 90 Days.

Policy Packs added with https://github.com/turbot/guardrails-samples/commit/469e16f78178bdd6a2e706ed24203adcc4090e0a


Unify icon slots

Composables with nullable icon slot:

ChoiceTile,
ChoiceTileCentered,
ClickableField,
PasswordTextField,
SelectField,
TextField and
FieldContent.

Composables with non-null icon slot:

ListChoice,
PillButton,
TopAppBar,
TopAppBarLarge and
FieldIcon.

@hrach, please review as mentioned in https://github.com/kiwicom/orbit-compose/pull/201#discussion_r932011182.

Basically, it is not only about icon slots, but all slots. Anyway, we need the null to do some advance composition so the answer is:

ChoiceTile - yes
ChoiceTileCentered - yes
ClickableField - no
PasswordTextField - no
SelectField - no
TextField - no
FieldContent - no


custom token address doesn't work on firefox

two screenshots were taken one after the other... custom token address works on chrome but not on firefox

Was able to add token with my setup

We were able to get the token info to appear on Firefox, likely a network mismatch


Add sensor properties for long term statistics

Version of the custom_component
0.3.4

Configuration
n/a
Describe the bug
Additional sensor properties should be added for long term statistics:

state_class
device_class
last_reset

these additional sensor properties are required to be able to select a sensor as a device in the new energy monitoring panel that was recently introduced in home assistant.


security/acme-client: Add the ability to specify domain key length

Hello,
I made few changes to add domain key length field to the GUI, giving the user the ability to specify the desired key length.
Also deleting --keylength paramter from acme client on revoke as it's not needed because the script will seek the cert installation path.
I tested on many scenarios and it's working properly.

@DonMcCoy Thanks!


Share page breaks if code used controlSprite (recently changed to moveSprite)

Describe the bug
Loading a game that contained the code controller.controlSprite, which was just changed to controller.moveSprite breaks the share page. The console reads out the following error: 'controlSprite' does not exist on type 'typeof controller'.
The game does work however if you switch to the view code section or edit the page, but the show game page, doesn't work.
It looks like the main.ts is being upgraded to the new function call, but the libraries are not.
To Reproduce
Steps to reproduce the behavior:
Load a game that used the block/function control sprite. (E.g. https://makecode.com/_Va2THxgeRYat)
Expected behavior
The simulator should upgrade its libraries to reflect the most recent change.

This needs a bump + pushing that version to be default.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Joey Wunderlich<EMAIL_ADDRESS>Sent: Tuesday, November 20, 2018 5:26 PM
To: Microsoft/pxt-arcade
Cc: Subscribed
Subject: Re: [Microsoft/pxt-arcade] Share page breaks if code used controlSprite (recently changed to moveSprite) (#362)
The main share screen seems to being ignoring the pxtarget.json compile options which do the conversions; the patches are applied when you view the editor (w/ the code switched to moveSprite by https://github.com/Microsoft/pxt-arcade/blob/dff5f34d3501af0f41b0de570b69e7993c130f89/pxtarget.json#L54-L64https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt-arcade%2Fblob%2Fdff5f34d3501af0f41b0de570b69e7993c130f89%2Fpxtarget.json%23L54-L64&data=02|01|jhalleux%40microsoft.com|f102555b78854e15108b08d64f5062e4|72f988bf86f141af91ab2d7cd011db47|1|0|636783604004196579&sdata=zvZuJJWfnQIlY0A4%2Flu2jghYj1nZVLN8Oszpwz2F1LI%3D&reserved=0), but the full screen view is either pre-compiled or just ignores the options
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt-arcade%2Fissues%2F362%23issuecomment-440493917&data=02|01|jhalleux%40microsoft.com|f102555b78854e15108b08d64f5062e4|72f988bf86f141af91ab2d7cd011db47|1|0|636783604004196579&sdata=3wscCos624NREcxYAblVeLg8BdaFtcLpmZNAMC69B7g%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KT-IW6z__AyWHqRAcgnQ8qoDRPBmks5uxKvOgaJpZM4YsOVS&data=02|01|jhalleux%40microsoft.com|f102555b78854e15108b08d64f5062e4|72f988bf86f141af91ab2d7cd011db47|1|0|636783604004206583&sdata=4jDMNFU18p1JEST2tA9tjakc6jF8LD%2BvM2%2Fxjiu%2BZ2g%3D&reserved=0.

fixed?

No. If you open the link the simulator still breaks, you have to click 'show code' to get the patches to apply (the simulator in the triple window view works properly, though)


Feature request: export regular expressions

I use this piece of software mostly in the context of latex writing a build tool in latex.
But I also want to integrate with latexmk which is in perl and also with splitindex which has an implementation in Lua.
So I am interested, to read in patterns in java, but export the according in other languages,
most notably in perl, python and lua.
It would be a great help to just create a pattern in java and then export that pattern as a pattern string
as required in the various languages.
If impossible to export something equivalent, an exception shall be thrown.

This is a feature that has nothing to do with this library, but would be an
additional tool, just for your specific purpose.
I give programming lessons. If you want to tackle that project in a paid
lesson, write an email to me @.***
On Fri, Sep 27, 2024 at 1:10 AM Ernst Reissner @.***>
wrote:

I use this piece of software mostly in the context of latex writing a
build tool in latex.
But I also want to integrate with latexmk which is in perl and also with
splitindex which has an implementation in Lua.
So I am interested, to read in patterns in java, but export the according
in other languages,
most notably in perl, python and lua.
It would be a great help to just create a pattern in java and then export
that pattern as a pattern string
as required in the various languages.
If impossible to export something equivalent, an exception shall be thrown.
—
Reply to this email directly, view it on GitHub
https://github.com/florianingerl/com.florianingerl.util.regex/issues/16,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE6YEWSKUEWZHWBUAK54VV3ZYSH7PAVCNFSM6AAAAABO6AL5Q2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGU2TCNRXGQ4TMNQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Hm, I feel since this library has all internal structures required,
it shall be easy to convert a pattern back to string.
This is already implemented by toString(), but of course only returns java representation.
If toString() is endowed with a parameter,
one can quite easily return pattern in any language.
Of course, sometimes not feasable throwning an exception.
On the other hand, a separate lib.. difficult,
without exposing the internal structure of a pattern.

Probably you know this: https://www.regular-expressions.info/

Another thought: Frequently, there are projects with inhomogeneous technologies and also languages.
Your library could be a means to bridge the technology gap in regex related aspects.


Make the view of the portal pages consistent

The icon should be beside the header
The filling should be the same
The font sizes should be the same

fixed

updated Statistics to the same Style

They all have the same font and style

Except for Farms, it feels different, bold, and maybe has a different font size? @ehab-hassan

Also, should my contract follow same style or not?

farm fixed here #1680
for the contract maybe we can create a new issue because these are buttons not card title header

@A-Harby As @ehab-hassan said, contracts headers' style should be different than the normal header. So, no need to change them.

Verified,
Devnet, a16e38d.
The farm font and style are fixed, and with previous comment all the Portal/Dashboard page views are consistent.

And for your contract page, the three tabs here are a tab with a click for expand and collapse.

TC2301 - UI component

Verified:

Devnet
ec2ed3d


Improvements

Improve "all" page downloading.

Support for quality parameter
Download more metadata (pages, pagebreaks, figures)
Use filenames that match names from server
Support 2 book formats, HTML and image

There actually are 2 book formats. One is just whole images of a page but other is whole book as proper HTML.
When you call /books/123/pages, you'll get JSON like
[{
    "path": "/pages/678/content",
    "absoluteURL": "/books/123/pages/678/content",
    "cfi": "/0",
    "cfiWithoutAssertions": "/0",
    "linear": null,
    "page": "Cover",
    "chapterTitle": "title",
    "number": 0
}, {...}]

This is for first book type and absoluteURL will contain an html with img tag like
<img id="pbk-page" src="/books/123/images/{ImageID}/encrypted/800" data-width="800"/>
Which will contain whole page as an JPG image.
Also by the way ImageID is created like hex(base64("Salted__" + hash(someData)))
For other book type you'll get
[{
    "path": "/OPS/loc_000.xhtml",
    "absoluteURL": "/books/123/epub/OPS/loc_000.xhtml",
    "cfi": "/6/2[idloc_000.xhtml-itemref]",
    "cfiWithoutAssertions": "/6/2",
    "linear": true,
    "page": "i",
    "chapterTitle": "title"
}, {...}]

Here absoluteURL will contain whole book page as proper HTML. So there inside will be all text with all images. Currently download_list and download_range doesn't work for these kinds of books. Also note that one this page can contain several "virtual" A4 pages.
This PR also adds BookExporter.py so it can create PDF from these downloaded books. If it's 2nd type book then it's created from HTML and is searchable and looks like proper book.
#2 is also fixed with this PR, but it all still begs for major rewrite.

:+1: :100:


[Access Change Request] table 167 Job - global variables "NoSeriesMgt" and "DimMgt"

Hi,
could you please mark the global variables NoSeriesMgt and DimMgt as protected?
Thanks.

Was fixed in version 22.


Fine-tuning?

Is there a recommended way to attempt fine-tuning the model? Or do you recommend just continuing training it on data related to your actual dataset?

iTransformer is supervisedly trained in the current version and we suggest training it on data related to your custom dataset.


How to achieve Superset SSO in a application which uses CAS Remote User

Make sure these boxes are checked before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if any
[ ] I have reproduced the issue with at least the latest released version of superset
[ ] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version
Expected results
Actual results
Steps to reproduce

Same issue!


[Feature]: Add the ability to bind clicks to different actions on the bag frame bag button.

Describe the feature
Right clicking on a bag window is not very UI friendly and there is no quick stash all reagent button either
Describe the implementation
As a user i would like 2 buttons somewhere on  a bank bag window

to switch between reagent tab and normal bank window
2 . to quick deposit reagent items

I realised last night that the one thing i missed from AdiBags is a button to deposit all regents to a bank with single click.

1. to switch between reagent tab and normal bank window

This exists as tabs on the bank window as of TWW.

   2 . to quick deposit reagent items

This has existed as a menu option on the bank window bag button for a while.

Might be added(or moved) to the Reagent Bank tab in the future


python310Packages.nextcord: 2.0.0 -> 2.1.0

Description of changes
https://docs.nextcord.dev/en/stable/whats_new.html#v2-1-0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

For me the result directory seems to be empty :O
[nix-shell:~/.cache/nixpkgs-review/pr-187102]$ fd . results/home-assistant-component-tests.discord
results/home-assistant-component-tests.discord/nix-support
results/home-assistant-component-tests.discord/nix-support/propagated-build-inputs

For me the result directory seems to be empty :O

It's a test and thus doesn't produce any output.


Wrong types for returns values of some methods

Description
The current typing for return values of post and options are incorrect. This seems to be just due to the typo in index.ts for the type parameters to coreFetch for post and options. (Probably like copy-pasta issue?)
Reproduction
Building the current source from master results in wrong return types for post and options.
Expected result
Checklist

[x ] I’m willing to open a PR (see CONTRIBUTING.md)

(The fix is trivial two line changes, and I'm happy to file the PR though I imagine the authors would be much faster in pushing up the fixes.)

D’oh! Yes that’s just a copypasta error. These types of type errors are so tricky to write tests for, too.
Will push a quick fix now, and think about a good regression test later so this doesn’t happen again.


Edit README.md and fix rnpm link issue

Hi @maxs15, I found some problems in latest release so I made some changes to correct these problems.
1.I added some information in README.md with my broken english, please feel to give me suggestion if rewrite/edit is necessary :p
2.In last pull request I added RNPM support, but just as I mentioned, RNPM does not automatically adds Jitpack repository to Android project. This means we still have to add it manually otherwise it results in build failure when developers link react-native-spinkit using RNPM. In order make it automatic I added a  node script to add Jitpack repository automatically.

Great @wkh237, this script is handy indeed !
Your Android guide is great but focused on users using Android studio, maybe it would be better for everyone to understand to talk about modifying the build.gradle & settings.gradle files ?
in android/app/build.gradle:
compile project(':react-native-spinkit')

in android/settings.gradle
include ':react-native-spinkit'
 +project(':react-native-spinkit').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-spinkit/android')

Ok @maxs15 , I think you're right, I will preserve the original part :D

PR merged :)
I've created a wiki to explain the manual Android/IOS installation, the README should be cleaner that way

Great ! 👍


Using series and parallel within a custom registry

When using Custom Registries with an Undertaker instance, is there a recommended way to use series and parallel within the custom registry?
Right now the only way I can figure out how to do so would be to pass in the Undertaker instance on instantiation
function CustomRegistry (taker) {
  DefaultRegistry.call(this)
  this.set('task1', function () {/* .. */})
  this.set('task2', function () {/* .. */})
  this.set('task3', taker.parallel('task1', 'task2'))
}
utils.inherits(CustomRegistry, DefaultRegistry)

and then to consume it...
taker.registry(new CustomRegistry(taker))

The only problem with this is that I get an error:
assert.js:86
  throw new assert.AssertionError({
        ^
AssertionError: Task never defined: task1

I assume this is because the Registry doesn't actually set the tasks, but just accrues them and passes them to Undertaker after instantiation, while parallel on the other hand, requires a task lookup immediately.
The current workaround I have for this is executing the parallel within a wrapper function:
  this.set('task3', function () {
    return taker.parallel('task1', 'task2')()
  })

Obviously this isn't exactly ideal, and all of these series and parallel tasks are labeled as <anonymous>
Is there a suggested approach to this? Passing in the taker instance feels kind of gross and hacky.

I forgot about this, but another reason you might need to pass in the taker instance is in the case of a gulp registry where you probably need access to src, dest and watch.

I'm noticing a bunch of issues related to this, many are related to the metadata generated and saved inside undertaker to keep the registries simple.  I'm not sure how to tackle this yet, but it does need to be addressed.

@webdesserts I have a potential solution, but I really don't like the API.
function CustomRegistry (taker, options) {
  DefaultRegistry.call(this)
  taker.set('task1', function () {/* .. */})
  taker.set('task2', function () {/* .. */})
  taker.set('task3', taker.parallel('task1', 'task2'))
}
utils.inherits(CustomRegistry, DefaultRegistry)

Notice how the registry never calls this.set and instead it calls taker.set which would allow undertaker to track the metadata for task names and dependencies.
The undertaker API for setting these would need to change to undertaker.registry(CustomRegistry, { custom: 'options' }) which would then new the CustomRegistry internally, passing this and the options to the constructor.  Do you have any thoughts on this API?  Any way to make it better?  A big problem with this is that the new tasks are registered on the old registry before the new registry is set as the registry to use.  After, they will still be reassigned through the transfer process but that causes a double registration and they might have already overridden previous tasks with the same name :frowning:

Another thought came to my mind.  What if the transferring weren't left up to undertaker, but were deferred to the custom registries?  It could be implemented in the DefaultRegistry so it would automatically happen if a custom registry inherits properly or they could implement their own transfer logic if they don't want to inherit.  Thoughts?

:+1: DefaultRegistry inheritance jazz

I guess my question would be, If we did start passing in the taker instance, what benefits would we be gaining over the common "just pass the object" plugin pattern?
var registry = function (options) {
  return function (taker) {/* ... */}
}

taker.use(registry({custom: "options"}))

The main benefit I see out of the current pattern is Registry inheritance. Moving the transfer logic sounds promising, though it would be nice to see what that API might look like. How would that handle things like parallel & series? Would a temporary parallel/series be defined on the Default Registry? Would we just be using Bach?

@webdesserts your sample code might have given me a really interesting idea.  Let me flesh it out a bit before I present it here.

@webdesserts here's what I am thinking.  It basically adds a wrapper function to allow options be passed in (like you suggested)
function configRegistry(options){

  class CustomRegistry extends DefaultRegistry {
    constructor(gulp){
      function clean(cb){
        del(options.dist, cb);
      }

      function js(){
        return gulp.src(options.src)
          .pipe(concat('build.js'))
          .pipe(gulp.dest(options.dist))
      }

      var build = gulp.series(clean, js);
      build.displayName = 'build';

      gulp.task(clean);
      gulp.task(js);
      gulp.task(build);
    }
  }

  return CustomRegistry;
}

This would allow undertaker to new up the registry and pass this in as the only argument but still allows the end user to pass in a config object.
This also allows the API to stay exactly the same gulp.registry(CustomRegistry(options)) with only a tiny wrapper overhead for registries that require configuration options.
I also played around with the idea of just using plain functions instead of inheritance but I don't think it looks as good.  See below:
function configRegistry(options){

  function customRegistry(gulp){

    function clean(cb){
      del(options.dist, cb);
    }

    function js(){
      return gulp.src(options.src)
        .pipe(concat('build.js'))
        .pipe(gulp.dest(options.dist))
    }

    var build = gulp.series(clean, js);
    build.displayName = 'build';

    gulp.task(clean);
    gulp.task(js);
    gulp.task(build);

    // these methods would replace the methods on the default registry instance
    return {
      get: get,
      set: set
      tasks: tasks
    };
  }

  return customRegistry;
}

@phated :+1:  I definitely like the first one. It's nice and clean.

Warning: I'm a bit scatter-brained right now. Read at your own risk

I've been thinking about this and one of the problems I see with wrapping the Registry with a function like that, is that it would make extending the registry a bit more difficult. This might be something that can be worked around with a few conventions for exposing the original class, but I honestly wasn't sure how useful extending a Registry other than the default might be so I played around with the idea a bit today.
Musings on Registry Inheritance
The first initial thought I had would be that it would probably be hard to reuse portions of a pipe sequence and insert your own plugins at specific points in that pipeline. For example
class BuildRegistry extends DefaultRegistry {
  constructor (gulp) {
    gulp.task(function build () {
      return gulp.src('src/*.js')
        .pipe(concat('alchemist.js'))
        .pipe(gulp.dest('dist/'))
        .pipe(uglify())
        .pipe(rename({suffix:'.min'}))
        .pipe(gulp.dest('dist/'))
    })
  }
}

class BabelRegistry extends BuildRegistry {
  constructor (gulp) {
    gulp.task(function build () {
      return gulp.src('src/*.js')
        .pipe(named())
        .pipe(webpack({
          output: {
            library: library_name,
            libraryTarget: "umd"
          },
          module: {
            loaders: [ { test: /\.js$/, loader: 'babel-loader?optional=runtime'} ]
          }
        }))
        .pipe(uglify())
        .pipe(rename({suffix:'.min'}))
    })
  }
}

If everything is in the constructor, then we have no way of overriding parts of the logic and making the Registry our own. We can work around that by moving parts of the pipeline into their own methods.
class BuildRegistry extends DefaultRegistry {
  constructor (gulp) {
    gulp.task(function build () {
      var source = gulp.src('src/*.js')
      var bundled = this.bundle(source).pipe(gulp.dest('dist/'))
      var minified = this.minify(bundled).pipe(gulp.dest('dist/'))
      return minified
    })
  }

  bundle (src) {
    return src
    .pipe(concat('alchemist.js'))
  }

  minify (src) {
    return src
    .pipe(uglify())
    .pipe(rename({suffix:'.min'}))
  }
}

class BabelRegistry extends BuildRegistry {
  constructor (gulp) {
    super()
  }

  bundle (src) {
    return src
    .pipe(named())
    .pipe(webpack({
      output: {
        library: library_name,
        libraryTarget: "umd"
      },
      module: {
        loaders: [ { test: /\.js$/, loader: 'babel-loader?optional=runtime'} ]
      }
    }))
  }
}

Pipeline Composition
What makes this possible is the ability to compose parts of the pipeline together in the constructor. I feel that pipeline composition would make developing Registries pretty fun, but I also feel that it's not very elegant at the moment. Passing the stream around in variables isn't very easy to follow once you start dealing with larger and more complex pipelines. I haven't seen any examples of other people trying to compose pipelines like this (maybe that's should be a sign to me) so I thought I'd throw out a few ideas on how one might approach this pipeline composition problem, specifically in the context of Registry Inheritance, and I'd like to hear your thoughts.
Composing with Functions
Again, we can just use a normal function that takes a stream, pipes it through some plugins and returns it:
function minify (src) {
  return src
  .pipe(uglify())
  .pipe(rename({suffix:'.min'}))
}

To use something like this you would have to "compose" the functions together:
gulp.task(function build () {
      var source = gulp.src('src/*.js')
      var bundled = this.bundle(source).pipe(gulp.dest('dist/'))
      var minified = this.minify(bundled).pipe(gulp.dest('dist/'))
      return minified
})

And again, this isn't my favorite.
Composing with _.flow()
I honestly didn't think of this until I used to word "compose", but you could also use something like lodash.flow(). I haven't really fleshed out what that would look like, but I'll drop what I got here anyway
// convenience wrappers

function src () {
  // not sure if this is right
  return gulp.src.bind(gulp, arguments)
}

function dest () {
  var args = arguments
  return (src) => src.pipe(gulp.dest.apply(gulp, args))
}

gulp.task('build', _.flow(
  src('src/*'),
  bundle,
  dest('dist/'),
  minify,
  dest('dist/'),
))

Composing with Promises
A fancier (and probably insane) way you could maybe approach this is with Promises that pass the gulp stream around.

gulp.task(function build () {
  return src('./alchemist.js')
  .then(BabelToUMD('Alchemist'))
  .then(dest('./dist'))
  .then(minify)
  .then(dest('./dist'))
})

function src () {
  var args = arguments
  return new Promise(function () {
    return gulp.src.apply(gulp, args)
  })
}

function dest () {
  var args = arguments
  return function dest (src) {
    return src.pipe(gulp.dest.apply(gulp, args))
  }
}

function minify (src) {
  return src
  .pipe(uglify())
  .pipe(rename({suffix:'.min'}))
}

function BabelToUMD (library_name) {
  return function (src) {
    return src
    .pipe(named())
    .pipe(webpack({
      output: {
        library: library_name,
        libraryTarget: "umd"
      },
      module: {
        loaders: [ { test: /\.js$/, loader: 'babel-loader?optional=runtime'} ]
      }}))
  }
}

For me, this is the most readable one. The problem with this right now is that I'm pretty sure async-done won't look for a stream in the return value of a promise and test for it's end, so this would have to be added in (if that's even possible). I'm also unsure of what this would mean for error handling.
I've heard a good bit about Observables, but have not checked them out yet, I'm sure a similar solution could be made with them as well? It would at the very least be interesting to see.
Final Thoughts
I'm actually probably going to use a similar solution on my current project with or without Registries. I think composing pipelines like this is extremely useful and is a nice way to keep plugins small while still being able to create larger reusable chunks of pipeline logic. I feel like pipeline composition is a middle ground between plugins and Registries. This also solves a problem for me that I've had with tasks in the past: they can't take parameters (without integrating the cli).
What are you're thoughts on pipeline composition like this? Is there a better solution out there? Is there a better way that you can think of to make Registries extensible without pipeline composition? Or is Registry Inheritance something you would even want users to do (past the Default Registry)?

Sorry for all the posts, but this one is a bit more on topic.
Another way you could approach the problem of passing in both the config and gulp is to make initialization of a Registry a two step process similar to how Twitter Flight handle's their components.
class DefaultRegistry {
  constructor (config) {
    this.config = config
  }

  attachTo(gulp) {
    // do any setup logic here
    this.initialize(gulp)
  }
}

// what the user would see (just use initialize instead of constructor)
class BuildRegistry extends DefaultRegistry {
  initialize (gulp) {
    var buildDir = this.config.buildDir || 'dist/'
    gulp.task(function build () {
      console.log('building to', buildDir)
    })
  }
}

gulp.register = function (registry) {
  registry.attachTo(this)
}

gulp.register(new BuildRegistry('app/public/'))

This would allow us to keep our Registry classes closure free and still keep configuring a Registry a one step process. It's also a bit more readable than the plugin pattern I suggested earlier

@webdesserts you are amazing.  I love the initialize (or maybe init) API.  It is so clean and allows the end user to constructor their registry with options but all the task transferring can be done before initialize is called.  :tada:
However, I think your other post is taking inheritance to the extreme.  The idea behind registries was to share common functionality (e.g. tasks across many common repos inside your company) or to add custom functionality that a minority of users were asking for (e.g. binding a this context to every task).  I like to view inheritance in the same light as the team behind React: only inherit a very small API from a base class (React.Component in their case and DefaultRegistry in this case) and don't inherit from more complex child classes (inheriting from a child React component is viewed as very bad).  I'm not going to be able to stop people from doing the things you suggested, but hopefully it can be discouraged and undertaker can provide an API that is simple and covers enough use cases that inheritance isn't abused.

@phated Glad I could help :) Most of the stuff you do is well over my head, so it's nice to be able to help where I can.
I was kinda expecting that to be the case with the first post. It interested me and I just wanted to tread the thought-path even if I knew it would probably be a dead end. I'll probably still look into ways to split up my gulp pipeline though. That's still got my interest peaked at the moment. However, I think that's well into gulp territory and a little off topic for this issue.

@webdesserts can you take a look at https://github.com/phated/undertaker/commit/21cafaa7981b1fc21d8a42debf10cf18e4308a6b and maybe even link it into any projects where you are using custom registries?  I'd like a sanity check before releasing this.

@phated Will do! I might be busy this weekend and I'll definitely be busy later next week. So I'm a little bit crunched for time, but I'll try it out as soon as I can.

Sorry to intrude here, but I wanted to add my grain of salt on this. Today I was trying to write a custom registry with the idea of having a common place for shared tasks on our organization. I was facing this very same problem, when I stumbled upon this issue on github.
I have tried the registry-init branch and though I'm not a big fan of the proposed API, I can say it works pretty well. At least, in my case it did, and it provided a solution. Here is my take on why I'm not entirely sold on it:

It forces you to follow some OOP conventions on your Javascript. This is not a bad thing per se. Coming from a JAVA background, I actually endorse it. But then again, you can't write a custom registry if you don't read and follow the docs thoroughly. And even then, it's not entirely intuitive what you are doing. IDEs don't really help you here, either.
It feels as if it represents too much boilerplate for such a simple thing.
It adds an unnecessary additional dependency to util in your project. I know you are not obligated to inherit from DefaultRegistry (and even if you do, you can achieve the same functionality without util). But if you don't, you'll need to write some additional functions that seem to be more private/internal to the framework than part of an API. More so if the official documentation shows the example like that. Copy-and-paste programming is an evil thing.
Talking about inheritance: if you accidentally misplace the util.inherits line and put it below the init override, then your object loses the function and nothing works. This_sounds_ obvious. It's not. I learned that the hard way.

Overall, my thoughts when using the implementation revolve around: "This does the job... but it feels somewhat hack-ish". Unluckily, I don't have the know-how of the inner works of gulp or undertaker to proposed something concretely different, but I perhaps I can contribute from a more conceptual side, if required.
My two cents.

@phated Sorry, it's taking so long to get back to you. I'll be looking at this tonight.

@phated I created a quick repo to try things out. For some reason series was only running the first task. Is this normal?

In gulp4, sync tasks are being removed. You have to pass in and call a callback

@webdesserts I had always intended on adding a "hey, your task hasn't finished, is it sync?" debug warning but I had forgotten all about. Maybe I need to look into that

@nfantone always open to API suggestions before we ship a 1.0 of this library

For anyone looking at this thread, please note that custom registries are supposed to be an advanced feature of gulp4 (probably the most advanced)

@phated oh interesting that will be quite the change. Do you have where the discussion on that is?

Nope, there was multiple and probably some in IRC. Magic sync is bad

@webdesserts 1 thread I could find while on my phone -  https://github.com/orchestrator/orchestrator/issues/29

And @nfantone's, I agree that it is a little awkward right now (though probably less awkward than the other solutions). I think as es6 is adopted and the class syntax takes hold it will be much more user friendly (btw gulp has babel support now! yay!). So I think it's worth it to wait out some of that awkwardness. JavaScript isn't really much of an IDE friendly language to begin with. Until types/traits are implemented, I'm not sure that should really be a goal for most js libs (especially for plugins).
@phated Thanks for the link, I'm going to test a few of things with a custom default registry tonight and I'll give you a summary of my thoughts.

@webdesserts any thoughts?

@nfantone always open to API suggestions before we ship a 1.0 of this library

@phated What about providing a convenience function on Undertaker (or even Gulp) that just receives a callback with the taker instance as an argument? Something along these lines:
gulp.register(function (taker) {
    taker.task('foo', taker.parallel(..., taker.series(...)));
    // ...
});

I believe this is similar to some other previous ideas in this thread. Bot now, you can think of that callback function as, essentially, the proposed registry.init method. Internally, we could then wrap this function on a CustomRegistry instance and call taker.registry with it. By doing this:

IMHO, it's already much cleaner and simpler.
It feels much more in tune with the already existent gulp API.
It encapsulates all off that DefaultRegistry inheritance jazz, without actually losing all that jazz.
It addresses (almost) all the issues I have pointed out before, including the addition of unnecessary dependencies that are now kept internally.

I can see this concept extended further, with something like a builder look-a-like:
gulp
    .registry()
    .register('foo', function(taker) {
        return taker.series(..., taker.parallel(...,)));
    }).register('bar', function(taker) {
        return taker.series(..., taker.parallel(...,)));
    })
    .create();

I think this is self explanatory. Of course, there would have to be a way of preventing the client from calling taker.task on that what I have called taker above.

@phated Thanks for the bump.
 I won't lie, past the "global config" example I couldn't come up with too many ideas of what you would do with a custom DefaultRegistry. The thought of providing helper functions for Registry developer did come to mind. I could easily imagine someone smarter than me taking this and doing something cool with it, though.
If you think the inheritance jazz is worth the extra lines of code, then I say go for it :+1:. It wasn't that much of a bother to me and will be a nice clean solution with es6. You've at the very least solved my issues with series and parallel :P

@nfantone I understand all your points but we don't want to create custom DSLs inside gulp, people can create those as user-land modules, which is where I think the register API you proposed would fit.  The get/set methods are super simple in the default registry, so inheritance isn't really required, just suggested.
@webdesserts I actually think I figured out how to use custom registry get/set methods to do forward referenced tasks, something a few people asked for but I don't think it belongs in core.  And like I've said before, custom registries are an advanced feature, so I like to expose these power tools to devs.

Agreed with @phated
as of @webdesserts

oh interesting that will be quite the change. Do you have where the discussion on that is?

Sync functions isn't a issue. You can just wrap them to look like a callbacks and then give it as argument to the .task method
i've created some libs for this
https://github.com/tunnckoCore/always-callback
https://github.com/tunnckoCore/make-callback
https://github.com/tunnckoCore/create-callback
I even can suggest @phated to look at the https://github.com/tunnckoCore/benz idea, which looks like bach, built on top of his core but handles all types of wanted cases - sync, async, callbacks, generators, returning/handling streams, child processes, promises, generators and etc.
And all that is optional through options. It also support all of them to have context on the fly, plus bonus to pass result to the next in stack. Just readme missing, but tests covers all.
@phated i know your point of co, but with benz you can just provide another generator flow to do the job. Or even other promisify-ing function. I've just put them as disabled defaults - i mean, the are there and will be used only if they are included in dependencies. Please look it, is a cool abstraction on top of same core lego blocks. :)

i've created some libs for this

actually.. the problem that i face is that promises and generators also looks as sync function, so its hard or too tricky to determine which is sync, which is promise or gen. btw thoughts?

As it stands, you seem to have your mind pretty made up at this point, @phated. Any chance you could merge the features to master?

@tunnckoCore After reading through the page @phated linked I didn't really have a problem with the removal of sync tasks as I could easily see the magic that would be necessary to make them work, how undesirable that magic would be, and how forcing the asynchronous tasks would encourage consistency anyway (which is why I didn't bring it up again).


arm: mpu: nxp: Set bus master 3 to full access

This patch adjusts the default permissions on the bus master 3 (NET).
Recent changes restricted this to supervisor only, and this caused
issues with the network controllers access to memory.
Restrictions on access should really be enforced on the ARM core bus
master.
Signed-off-by: Andy Gross<EMAIL_ADDRESS>

Codecov Report

Merging #6214 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6214   +/-   ##
=======================================
  Coverage   52.84%   52.84%
=======================================
  Files         412      412
  Lines       40300    40300
  Branches     7804     7804
=======================================
  Hits        21298    21298
  Misses      15784    15784
  Partials     3218     3218

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d790ed5...515cba0. Read the comment docs.

is this fixing #6194?

@nashif yes.


Refactor StakePoolBuilder tests

Context
Since Db Snapshot can be taken from different databases some autoincremental IDs can vary from db to db due to cases such rollbacks. So, instead of checking for every ID number, we would check only object's data by replacing every registry ID per a generic one
Proposed Solution

[x] Create RegEx to replace rows IDs per a generic one
[x] Apply to corresponding StakePoolBuilder queries
[x] Update Snapshot

Important Changes Introduced

Can you instead just strip these fields from the object altogether? Also, retaining the prettiness of the snapshot is important, as they're verified manually.

I've stripped them in most of tests. Except poolHashes query, where ids are the only result it expects.


Feature idea: Use pydantic for loading configuration

Today Slack Machine uses a plain python file for its config, which I find less than ideal.
I would like to put my bot in git, but I don't want to commit any secrets into git.
To solve this I tried to do a simple import of the yaml module in local_settings.py, and load my secrets from there, but this won't work when using Redis as storage backend.
The reason it won't work is that the config is pickled and put into the storage, so any object will yield the error message seen in issue #273.
Changing to Dynaconf provides the benefit of letting me store my secrets separately from the main config.
It will also provide a lot of other benefits and features that Dynaconf provides, like letting me choose which format I want to store my config in, multiple environments etc.
What do you think?

I'm not 100% convinced to be honest. I strongly believe in the 12-factor app guidelines, which is why you can configure Slack Machine using environment variables. This allows you to keep secrets out the local_settings.py. The reason why I still like the idea of configuration inside a Python file, is because it's programmable and allows for more complex data structures, should plugins need it.
Another thing to think of is that - while Slack Machine hasn't reached v1.0 yet, which technically means I could break backwards compatibility - quite a lot of people are already using SM, which would create quite an issue if I were to switch to something like Dynaconf. I don't see how I could do that now without breaking backwards compatability with people's SM installs.
Lastly, while the idea of Dynaconf is nice, it doesn't seem super easy nor intuitive. So it would introduce some complexity into SM. I'm hesitant to do that.
In short, I'm not against it up front, but I'd need some more convincing and alleviation of the aforementioned problems before I would accept a PR to do what you propose and/or work on it myself.
But I like that you're looking for ways to improve SM! Your input is much appreciated!
I will read up some more on Dynaconf in the coming week.

Dynaconf has support for multiple formats, so we could do python config called local_settings.py and keep everything working as it is now - even though I don't like config in code.
Dynaconf can also be configured via environment variables, but also via a ton of other different ways - e.g. Vault for secrets, .env, .secrets etc.
The feature I like the most about Dynaconf, is different environments, which keeps me from shuffling config variables when testing vs when deploying.
But checkout the docs to Dynaconf, it's really nice and can be customised into a perfect fit for Slack Machine.

I will look into it this week and get back to you about this.

In the mean time I have fallen completely in love with pydantic which solves more than than just the config loading - It could also replace dacite and add more strict type checking where ever it is needed.
On the config side pydantic also has support for secrets which would make deploying slack-machine to Kubernetes really easy.

Might indeed be useful. I dropped you an email to discuss Slack Machine in a more general sense.

Hey @davidolrik, I don't know if you're still using Slack Machine, but I'm working on it again. My first order of business is making it use asyncio (and in the process, generally refactoring it).
Configuration is another important topic I'd like to tackle soon. I've been reading over this issue again, and I wonder what the best approach is. I think Dynaconf and Pydantic are both valid options. I wonder if we'd use Pydantic, how we would deal with new settings required by plugins. Pydantic models are static, so the only think I can think of is to add a sort of "catch-all" dict setting on the Settings model. Do you have another idea?
If you moved past using Slack Machine, I also totally understand and won't bother you again!


Unable to complete request

Hi,
Good day! The login shows error 'Unable to complete request'.
Invalid_request: The provided value for the input parameter 'redirect_uri' is not valid. The expected value is a URI whihc matches a redirect URI registered for this client application.
I tried this folllowing under the credentials (didn't work):
const credentials = {
client_id: 'xxxxxxxxxxx',
client_secret: 'xxxxxxxxxxxxxxx',
redirect_uri: appAuth.OAuthRedirect + '://oauthredirect',
scope: 'openid profile email offline_access'
};
May I know how I can specify a redirect_uri for the react-native app for expo?

Check your redirect_url  in Azure settings and match same redirect_uri.


Provide two flags for Hive last updated extractor

Summary of Changes
Provide two flags to check hive last updated timestamp for partitioned and non-partitioned tables.
Tests
What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line
Documentation
What documentation did you add or modify and why? Add any relevant links then remove this line
CheckList
Make sure you have checked all steps below to ensure a timely review.

[ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[ ] PR includes a summary of changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

[ ] PR passes make test
[ ] I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message"

cc @jinhyukchang

Currently we capture the last updated timestamp for both partitioned and non partitioned table in single task. The task has long running time which often causes timeout. I am thinking to split it into two tasks to reduce the long running time.

Codecov Report

Merging #106 into master will decrease coverage by 0.02%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
- Coverage   82.78%   82.76%   -0.03%
==========================================
  Files          52       52
  Lines        2591     2599       +8
  Branches      271      273       +2
==========================================
+ Hits         2145     2151       +6
  Misses        359      359
- Partials       87       89       +2

Impacted Files
Coverage Δ

...der/extractor/hive_table_last_updated_extractor.py
73.64% <80%> (+0.07%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c3e717...f1d0ca0. Read the comment docs.

@feng-tao
If we are trying to improve performance by parallelizing partition vs non-partition, this would not work. Our case shows, partition table would take less than 30 sec where partitioned one takes hours.

got it. thanks @jinhyukchang. let's close the pr for now and think of any other way to improve the performance.


Empty output

Hy there. I wanted to use PcbDraw on my mac but that does not seem possible at the moment. However, I have a Linux Server (Headless) on which I did install kicad along with imagemagick and pcbdraw.
Now when I run PcbDraw I get a set of warnings about some components that can't be found.
At the end there is an output.png created and it has 1140 x 600 pixels the image itself is empty:
I would assume that even when the components aren't found that I would still see the board and the silk screen being rendered.
Update:
I did try other options and apparently only the png and jpg option result in an empty image. The svg output works fine.
I'll update my
output.png

output.jpg

output.svg

Install the Debian package, it will pull all the dependencies.


fix(build): update package.json files with correct "module" field

Closes: #698.

@ruijdacd thanks for your contribution. Have you tested this locally and confirmed that it works?
Best,
David

Yes, it worked on my case! However I've actually gotten around this issue with Parcel by "making it" look for the exports field and that worked.
Here's the link just in case someone else is facing this problem: https://parceljs.org/blog/v2-9-0/#new-resolver
I'll leave that with you and I guess the community to decide wether this is something that needs to be "fixed" or not as bundlers nowadays are prioritising the exports field over main and module anyways.

@ruijdacd even though the community is adopting exports more and more because it's more versatile, I think this PR is good because the module field should point to files that exist. Thanks for your contribution.


More changes of Dryville's story

I have added two more sections and fixed conflicts.

I think the first and third links are working, no?

Sorry for this late reply here and for not being clear ! The links are totally working and the super small change was to have them link to the words reservoir  and hydroelectric power plant (see below). Feel free to ping me if you continue going through the training! I hope it has been helpful so far.


Support default.nix too

Flakes is an experimental feature, so it would be nice to also support standard features.
https://github.com/edolstra/flake-compat is an easy way to do that.

Thanks for the issue. Sure, I added default.nix and shell.nix files using flake-compat with https://github.com/utdemir/nix-tree/commit/18d3443047c9da0b7d0f2d88115b29ca576ffc07.
My aim was nix-tree to be available on nixpkgs (it is), so the flake stuff was only for me to use when developing. But of course, having flake-compat doesn't hurt! Let me know if it now works for you.

Oh, I used to be fetching this via niv, but I can switch to nixpkgs. Thanks!


Get-OpenADUser erroring because contacts don't have sid/SAMAccountName

I am running Get-OpenADUser to get a list of users and it is erroring after receiving a few records with:
Get-OpenADUser: sid
It looks like this is because the default query for this command is "(objectCategory=person)" and this is pulling back both users AND contacts, and contacts don't have a sid/SAMAccountName.
This article states the query for retrieving users should be:
(&(objectClass=user)(objectCategory=person))
A workaround is therefore to run:
Get-OpenADUser -LDAPFilter "(objectclass=user)"
... but you might want to modify the default query.
Thanks & great work on this module, it is incredibly useful!

Thanks for the info, it should be simple to adjust the default query to also include (objectClass=user) as part of the original set. I'll have a play around with contacts to see how the MS Get-ADUser module handles them but it does seem like it avoids them.


Creation of new community does not refresh on list

Upon creating a new community, the community list does not refresh automatically unless you refresh the page.

it's working fine. Could you please double-check it, Dhaval?


Integration with Existing App CocoaPods not update

Integration with Existing App
There is not RCT_EXPORT_METHOD macro in RCTBridgeModule.h file  and 'RCT_EXPORT' exited.
How can I update?
In my podfile:
pod 'React'
pod 'React/RCTText'

I think RCT_EXPORT was supposed to be backwards compatible (but deprecated) but might have just broken - @a2 can you take a look and make sure the podfile is working?

Have you tried the following command?
$ pod update


Can I choose a font 'typeface' ?

Hi.
I am using the font "Fire Code", which comes with a few variants (typefaces), "Light", "Regular", "Retina", etc. I can only get the regular version to work with this config setting
  "editor.fontFamily": "Fira Code"

But I would like to use the "Light" version. If I try and change it to
  "editor.fontFamily": "Fira Code Light"

The some default non-monospace font is used. Is there a way to choose the font typeface?
For oldschool gui vim, the following font selection works in my .vimrc file
set guifont=Fira\ Code\ Light:h15

Hi @PeteProgrammer ,
Thanks for the issue. Which platform are you on? And just to confirm - are you using this version of Fira code? https://github.com/tonsky/FiraCode
I'm testing it out on Windows and it seems like the font is switching for me:

But there may be cases where we need to specify the font-weight CSS property for it to be picked up. We could potentially add an editor.fontWeight which would allow setting this. I noticed that for me, if I set editor.fontFamily to "Fira Code Bold", it didn't work - but if I set editor.fontFamily to "Fira Code" and font-weight directly in CSS as bold, it rendered correctly.

Hi @bryphe
I'm running on OS-X - and yes, that is the version of Fira Code I have installed.
However, I managed to find a workaround. I used the filename for the specific typeface, so, e.g. "Fira Code Light" is in the file "FiraCode-Light.ttf". So I got it to work by changing the setting to:
"editor.fontFamily": "FiraCode-Light"

Glad you got it working, @PeteProgrammer ! Thank you for the follow-up.
I'll close this out, but feel free to update our wiki if you have ideas on making that option clearer: https://github.com/onivim/oni/wiki/Configuration#editor

I tried updating the wiki, don't know if it is clearer :)

Hi there. I just noticed that this is also an issue in VS Code, AFAIK, both oni and VS Code are based on Electron?
So this must be an issue with electron itself, and not oni.
p.s. I changed my github account name, I used to be peteprogrammer ;)

Thanks for the follow-up, @stroiman ! Yes, both Oni and VS Code are based on Electron -  so it makes sense that we'd potentially both have the issue.

Hey y'all, if you want to find the PostScript font name for a font on OSX, you can open up the Font Book app, select the font you want to use, and type command-i. You should see something like this:

The entry for "PostScript name" is the one you want in your config.tsx! Fancy fonts ahoy!


Test branch contact

Mock-Get-EntraContact
Mock-Get-EntraContactMembership
Mock-New-EntraDomain
Mock-Remove-EntraDomain
Mock-Remove-EntraMSApplicationExtensionProperty
Mock-Select-EntraGroupIdsContactIsMemberOf

new pr raised #1036


Use click.Path for filenames

Currently, many commands use str for filename arguments.  Using click.Path instead should lead to nicer error messages and also improve shell completion.

I said “partially fixes”, not “fixes”, GitHub!


Introduce the resource control client

Introduce the resource control client and its interceptor
Should merge after https://github.com/tikv/pd/pull/5811.

https://github.com/tikv/pd/pull/5811 is ready. please continue the process

/merge

Ref https://github.com/pingcap/tidb/issues/38825


Migrate base receiver module to use ReactiveKafkaProducer instead of KafkaProducer (#3142)

Use ReactiveKafkaPro.. instead Vertx KakfaProducer

Signed-off-by: debasishbsws<EMAIL_ADDRESS>
Mock Producer and Producer Factory for Test

Signed-off-by: debasishbsws<EMAIL_ADDRESS>
Pom files updated

Signed-off-by: debasishbsws<EMAIL_ADDRESS>
RecieverVerticle test with Mock

Signed-off-by: debasishbsws<EMAIL_ADDRESS>
Change KafkaProducer with Mock ReactiveProduce

Signed-off-by: debasishbsws<EMAIL_ADDRESS>
Licence Header

Signed-off-by: debasishbsws<EMAIL_ADDRESS>
Fix all the tests

Signed-off-by: debasishbsws<EMAIL_ADDRESS>
VirticleTracing test abstract and implemented

Signed-off-by: debasishbsws<EMAIL_ADDRESS>
No specified tracing number

Signed-off-by: debasishbsws<EMAIL_ADDRESS>

build test jar of reciever

receiver_directory change to receiver-vertx

update profiler script to use receiver-vertx jar

Small fixes with formating and keywords

Change acording to suggestions

remove unnecessary codes as suggested

Update data-plane/receiver/src/test/java/dev/knative/eventing/kafka/broker/receiver/impl/handler/IngressRequestHandlerImplTest.java

Update data-plane/tests/src/test/java/dev/knative/eventing/kafka/broker/tests/DataPlaneTest.java

Signed-off-by: debasishbsws<EMAIL_ADDRESS>

OCF Webhook is merging this PR


[FEATURE] Allow admin users view the user information stored in monitors

Is your feature request related to a problem?
Currently admins have no idea on the user information stored on the different monitors, so they are not sure which users have access to the monitors if RBAC is enabled.
What solution would you like?
Allow admin users view the user information stored in monitors

The getMonitor and searchMonitors APIs need to be modified to user this xcontent to ensure the user information is being passed over.


How to Store Videos/Images Recorded/Captured by Drone in PC thru Node-RED?

Hi John,
Firstly I want to give you big thanks for Node-RED and Tello Drone implementation in such a easy and interesting way.
It would be great if you can suggest me how can I store drone Recorded/Captured videos/images in my laptop?
Please find some screen shots of Video streaming image by Drone.
Thanks & Regards,
Mudit Khare

You can easily use the Node-RED file node to save the image to your local laptop. Send the image in msg.payload and set the msg.filename to the local file you want to save as.
If you want to write the images to IBM Cloud Object Storage, there are nodes for that too.  I have not figured out how to configure the node-red-contrib-cos nodes however.

Hi John,
Now I am able to save Drone captured images to IBM Cloud Object Storage via using cos-put node  Cloud Object Storage  in my local Node-RED.
Thanks for your suggestion.


marketing: Update integration count.

https://zulip.com/integrations currently counts 91 integrations. This includes publicly featured bots in https://zulip.com/integrations/bots.

Updated to use a variable for the /integrations page counter. This has the nice side effect that every 10 new integrations, tests will fail and act as a reminder to update the remaining static numbers.

Nice, merged, thanks @roberthoenig!


[FEATURE REQUEST] Get access to method isLevelEnabled

I am using NestJS, pino and nestjs-pino.
Normally, I am injecting the PinoLogger like this to log my statements:
import { PinoLogger } from "nestjs-pino";

However, now I want to access the method logger.isLevelEnabled(level). Unfortunately, PinoLogger does not have this method.
How can I access isLevelEnabled with nestjs-pino?

Unfortunately not implemented yet. I'll convert this to feature request

closed in #439


Fixed a PHP7 warning.

I am not sure about PHP 5.5, but for PHP 7,
$response->getAlipayResponse(); will trigger the warning below:

Warning: Missing argument 1 for Omnipay\Alipay\Responses\AbstractAopResponse::getAlipayResponse(), called in .....

Closing this PR and Reopen to trigger Travis to re-build


Attribute of type logging.Logger only shows logging in HTML

def get_logger(level: str) -> logging.Logger:
    logger = logging.getLogger("my_package")
    logger.setLevel(logging.getLevelName(level.upper()))
    return logger

log: logging.Logger = get_logger("debug")
"""The logger used throughout this package."""

...though the return type of get_logger is correctly displayed as Logger.

Will likely not fix this as pytkdocs will be replaced by griffe.


fix: make material work with noUnusedParameters

Recently Angular core fixed most of their noUnusedParameters warnings in https://github.com/angular/angular/issues/15532 (this one is still left - https://github.com/angular/angular/issues/17131)
When using Angular with Material and the users has noUnusedParameters enabled the library will be checked and will throw right now.

Note: I don't plan to add the noUnusedParameters to any build tsconfig files yet, because it would make the watching & live-reloading extremely bad. The noUnusedParameters should / can be tested on the CI in a follow-up.
Fixes #4443

@jelbourn Addressed your feedback. Expect the one with the Iterator.


Validation issue with +77087702446 (KZ)

Thank you for using libphonenumber!
Please upgrade to the latest release, this is not a live issue. To check the latest behavior for yourself, see the demo (instructions in our contribution guidelines).
Ex: https://libphonenumber.appspot.com/phonenumberparser?number=%2B77087702446


Return the payload if it was processed already.

No need to wait for the payload if it has already been delivered. Push/AppNotificationManager no longer throw E_TIMEOUT if you call GetActivatedEventArgs twice.

/azp run


Refactor to cover all of the available bridges

Etherlink will have 3 bridges:

Canonical bridge to move XTZ between Tezos layer 1 and Etherlink
Wrapped asset bridge to move tokens from EVM chains to wrapped versions on Etherlink and back
FA bridge to move Tezos FA-compliant tokens between Tezos layer 1 and Etherlink

Withdrawn -- working on this in a new branch.


Change CI yarn installation method

Due to recent changes in one of yarn's npm dependencies, the our CI build broke temporarily, see https://github.com/yarnpkg/yarn/issues/2915.
To prevent this in the future I would suggest we remove the yarn dependency in the project's package.json and modify our .travis.yml file before install step to the suggested linux installation method.
Thoughts @denar90 ?
EDIT: Just noticed PR https://github.com/paulirish/pwmetrics/pull/79 could this change be made there to guarantee yarn stability?

I dunno, but using yarn 0.22.0 help - https://github.com/paulirish/pwmetrics/pull/79/files#diff-354f30a63fb0907d4ad57269548329e3R17

I noticed, I wonder if it wouldn't be better to use the recommended yarn install method via Linux repositories and bash commands.

Closing this as https://github.com/paulirish/pwmetrics/pull/79 has been merged. If yarn related installation problems occur again lets refer back to the https://github.com/paulirish/pwmetrics/issues/82#issue-216967014 solution


Class declaration should return transaction hash instead of class hash

Rationale:

class hash can be retrieved in other ways (contractFactory.getClassHash())
there is no way of getting the transaction hash if it failed

This would be a breaking change.

Hey @FabijanC as mentioned during our discussion, I'd like to try to fix this issue

Hey there, I'd love to tackle this issue


Resolve TypeCheck Error in Components -> vitals -> MetricsProvider.vue  ---------   <MetricsProviderInternal

Expected Behavior
No Type Check errors
Current Behavior
we are facing typecheck error in Components -> vitals -> MetricsProvider.vue
reproduce the issue
yarn run typecheck
Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

Version used:
Browser Name and version:
Operating System and version (desktop or mobile):
Link to your project:

Hi @zlr-raja ! Thanks so much for opening an issue to try and get this resolved.
Before we start investigating, can you let us know the version (or commit hash) you're running against, along with the OS, node, and yarn versions?
Currently on the main (commit hash a02c453), I'm seeing typecheck exit correctly.
Again thanks for opening an issue, and I hope we can get this sorted out for you.

HI @andrewwylde
please find the below version
Node: **v18.18.2**
Yarn : **1.22.19**

screenshot

Hi @zlr-raja Thanks for providing the node and yarn versions, that should start to help. Can you please run yarn install --frozen-lockfile to see if this helps to resolve this issue?
Some other thoughts:
Is this a fresh clone of the project, or are you working from a fork? Again, this check is succeeding on the main branch of this repository, so if you can provide any additional meaningful differences between your code and the code in main, that'd be very helpful.
To risk being overly prescriptive, a git diff with whatever you've set as Kong's git remote. For instance, I would run git remote -v to get:
origin  git@github.com:andrewwylde/konnect-portal.git (fetch)
origin  git@github.com:andrewwylde/konnect-portal.git (push)
upstream        git@github.com:Kong/konnect-portal.git (fetch)
upstream        git@github.com:Kong/konnect-portal.git (push)

and then git diff upstream/main to get a full diff between my fork and the source repository.
Then perhaps we can continue debugging.

@zlr-raja I know this issue has been open a while. It appears that there's a version mismatch between your @kong-ui-public/analytics-utilities and @kong-ui-public/analytics-metric-provider versions. Doing a fresh install (i.e. yarn install --frozen-lockfile) with the dependencies listed in main (or you could specify<EMAIL_ADDRESS>and @kong-ui-public/analytics-utilities@0.10.1), this should be resolved.


formContext getControl/getAttribute are not documented

getAttribute is used in a sample but isn't documented. getControl isn't documented on this page at all.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 27005d75-5062-c4cf-bfa8-bee6f0aeb28c
Version Independent ID: a3ce8627-2cf4-9eb6-8e36-f304c012b05c
Content: Client API form context in model-driven apps - PowerApps
Content Source: powerapps-docs/developer/model-driven-apps/clientapi/clientapi-form-context.md
Service: powerapps
GitHub Login: @KumarVivek
Microsoft Alias: kvivek

@ChrisGrohHS
Thanks for the feedback. We have updated the docs with the correct information and pushed to live. Closing the issue.


Add support for tab characters

I personally don't like tabs, but I guess a proper editor should support them after all... I should keep in mind that there are a bunch of places where I hardcoded spaces that should also include tabs (just use %s).
I'm not even sure what happens at the moment if you open a file with tabs.

Update: Currently it simply renders tab characters as a single whitespace. I mean, it's nice that it at least seems to not go up in flames, but support could definitely be improved here.


[20.09] pythonPackages.pillow: add patches for CVE-2020-35653, CVE-2020-35654, CVE-2020-35655

Motivation for this change
https://nvd.nist.gov/vuln/detail/CVE-2020-35653
https://nvd.nist.gov/vuln/detail/CVE-2020-35654
https://nvd.nist.gov/vuln/detail/CVE-2020-35655
Patches for the fix only apply if two prerequisite tiff-related patches are added first, but the result passes all its tests including the new ones covering the vulnerability, so I'm pretty confident the result is functioning correctly
Not done a full rebuild because ... massive. Will pick some key packages for ofborg.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@ofborg build python38Packages.cartopy python37Packages.pytesseract python38Packages.imageio

Shouldn't this target staging-20.09?

Shouldn't this target staging-20.09?

Absolutely

Interesting - someone once told me that the staging release branches were only used around release-time.

Hold up on this - it looks like the critical test in question relies on an image - a binary section of the patch, which is not supported by patch, and in this case the test suite helpfully just skips the test if it can't find the image :roll_eyes:
What is the suggested way of handling a patch with binary parts? Can always just use fetchurl...

This now includes patches for all three listed CVEs. I've had to create a dumb mechanism to fetch the accompanying binary parts of these patches because the tests need their example images to function (and backporting patches without working tests makes me unhappy).

Is this ready for merge into staging?

As far as I'm concerned.


E2e sweep

Now ensuring that the bridge process raw candidate sentences fetched from the index, exactly as was done for the best performing SM model.

merge reminder :P

@lintool merge reminder :)


Improve error reporting

Fennel provides fennel.traceback, which can provide more ergonomic, readable and pleasing error messages. This is already being used in aniseed.eval, where the errors will be printed nicely.
When using aniseed for the vim configuration however, errors don't run through traceback, thus showing rather ugly and unhelpful lua error messages.
Wrapping the configuration in an xpcall that defers errors to fennels traceback handler should be pretty simple to implement, and would already drastically improve the experience of configuring vim in fennel.
This would still not affect any deferred execution, and thus wouldn't affect anything that's called on keybinds, autocmds, or passed as callbacks to other functions. This could be improved in several ways:

Simply provide an easy-to-use function to wrap custom functions in, that wraps the function you're calling in xpcall for you. This would require actively doing it, and would make it an "always-on" thing, which is both suboptimal. BUT: it would be rather trivial.
Try to automatically wrap functions by possibly using the fennel compiler plugin API (?). This would work automatically and allow the user to toggle it on and off depending on "development" vs "in-use" state. It would however also bring more extreme performance issues, and probably also change behaviour of code in many places where code relies on how errors behave.
Try to intercept errors at a higher level, overriding the traceback handler that vim uses to print it's errors. lua has debug.traceback, but from what I can tell that's not what is being used here (although I can't be sure, haven't looked into it). At least from my primitive tests, just overriding that function changed nothing.

I'm running into this problem where on one of my machines my fennel config completely fails on startup with an unhelpful error message:

But on the other it works fine. Unfortunately I have no idea what is causing this and I don't really even know how to approach figuring out what is going on. Do you have any tips for how to get better error messages in the meantime? Its preventing me from using aniseed which has been amazing in the past...

🤔 I don't think I have enough information to go on here, I can't really make any guesses. First of all, are you on a stable release or develop? Since develop is fragile at the moment as I make sweeping changes.
You could also try removing ~/.config/nvim/lua entirely and have nvim rebuild it just in case something is hanging on that shouldn't be there or isn't recompiling?

First off, it was late when I posted that, so I want to reiterate that this is almost certainly an issue on my config or with the fact that I'm using windows. My question was more about how I might get some more useful debug information out of the system. Seems like neovim just eats the relevant information when getting errors from lua.
I have tried with both develop and master branches. And I have rebuilt the lua from scratch by deleting the lua folder and having nvim rebuild, with no luck... Is there a way to force aniseed to use the above aniseed.traceback on a temporary basis?

For some extra context, I reverted my config changes to the previous stable state and I still have issues. So I'm thinking there is something sticking around. I tried removing my nvim-data folder so that it is built from scratch with no luck. Is it possible that there is some other scripts/files sticking around somewhere that aniseed loads other than what is stored in the .config (actually appdata/local/nvim on windows) folder?

Ok I've figured out some more details. The issue seems to be windows specific and is unrelated to this issue. Sorry to hijack. I will create a new issue


Add InstanceMetadataOptions

Allow modifying Instance options so that users can disable IMDSv1 for higher security. In reference to this issue: https://github.com/buildkite/elastic-ci-stack-for-aws/issues/647
More information about this below:
https://aws.amazon.com/blogs/security/defense-in-depth-open-firewalls-reverse-proxies-ssrf-vulnerabilities-ec2-instance-metadata-service/
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/configuring-instance-metadata-service.html
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-launchtemplate-launchtemplatedata.html#cfn-ec2-launchtemplate-launchtemplatedata-metadataoptions
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-launchtemplate-launchtemplatedata-metadataoptions.html#cfn-ec2-launchtemplate-launchtemplatedata-metadataoptions-httpendpoint

Is there anything we can do to help this one go in? I have failed security checks waiting on this feature.

Hi @simonfong6 @jamesholmes-linktree!
I’m going to close this as the individual components have been adopted elsewhere:

Version 5.2.0 added support for making v2 tokens required.
The hop limit has been set to 2 to support Docker networks.
We would be unable to support the option to disable the Instance Metadata Endpoint as the Elastic CI Stack uses it itself for credentials.

Thank you for drafting and contributing this implementation, and taking the time to open this pull request 🙇🏻♂


M3-2469: fix backups state display when backup is scheduled

Type of Change

fix backups state display when backup is scheduled

The cloud icon is misaligned when some Linodes have backups enabled and some don't:

I left one other comment about the copy. Other than that, looks pretty good to me.


Restarting services with supervisord is really slow

Currently, restarting all Zulip services with supervisord takes about 40s to run.
This also means we spend about 40s in our Travis CI tests for the production suite restarting services using supervisord.  This time is not time spent in Zulip -- the time is essentially all supervisord overhead.  We should figure out how to either patch or replace supervisord to be reasonably efficient.
https://github.com/Supervisor/supervisor/pulls?q=is%3Apr+author%3Azbenjamin+is%3Aclosed has some work @zbenjamin did on supervisor performance a few years ago, but it seems despite some of that being merged, supervisor is still incredibly slow at restarting N processes.
The test case for this I would use is just running supervisord to start N sleep 10000 commands.

It appears supervisord got a lot faster in Ubuntu Xenial:
zulip@xenialtest:~/deployments/current$ time supervisorctl restart all
zulip-workers:zulip-events-signups: stopped
zulip-workers:zulip-events-confirmation-emails: stopped
zulip-workers:zulip-events-error_reports: stopped
zulip-workers:zulip-deliver-enqueued-emails: stopped
zulip-workers:zulip-events-slowqueries: stopped
zulip-workers:zulip-events-email_mirror: stopped
zulip-workers:zulip-events-missedmessage_mobile_notifications: stopped
zulip-workers:zulip-events-digest_emails: stopped
zulip-senders:zulip-events-message_sender-4: stopped
zulip-senders:zulip-events-message_sender-1: stopped
zulip-senders:zulip-events-message_sender-2: stopped
zulip-senders:zulip-events-message_sender-3: stopped
zulip-django: stopped
zulip-tornado: stopped
process-fts-updates: stopped
zulip-workers:zulip-events-user-presence: stopped
zulip-workers:zulip-events-user-activity-interval: stopped
zulip-workers:zulip-events-user-activity: stopped
zulip-workers:zulip-events-missedmessage_reminders: stopped
zulip-workers:zulip-events-feedback_messages: stopped
zulip-senders:zulip-events-message_sender-0: stopped
zulip-django: started
zulip-tornado: started
process-fts-updates: started
zulip-workers:zulip-events-user-presence: started
zulip-workers:zulip-events-user-activity-interval: started
zulip-workers:zulip-events-user-activity: started
zulip-workers:zulip-events-signups: started
zulip-workers:zulip-events-confirmation-emails: started
zulip-workers:zulip-events-error_reports: started
zulip-workers:zulip-deliver-enqueued-emails: started
zulip-workers:zulip-events-slowqueries: started
zulip-workers:zulip-events-email_mirror: started
zulip-workers:zulip-events-missedmessage_mobile_notifications: started
zulip-workers:zulip-events-digest_emails: started
zulip-workers:zulip-events-missedmessage_reminders: started
zulip-workers:zulip-events-feedback_messages: started
zulip-senders:zulip-events-message_sender-4: started
zulip-senders:zulip-events-message_sender-0: started
zulip-senders:zulip-events-message_sender-1: started
zulip-senders:zulip-events-message_sender-2: started
zulip-senders:zulip-events-message_sender-3: started

real	0m4.520s
user	0m0.312s
sys	0m0.024s

so I think we can just backport the package to Ubuntu Trusty to solve this problem.

Backporting complete; now our production tests run in under 5 minutes sometimes!
https://travis-ci.org/zulip/zulip/builds/140989369


About function: generate_anchor

I cannot figure out how to generate anchor, in function generate_anchor() code:
""
anchor = np.tile(anchor, score_size * score_size).reshape((-1, 4))
ori = - (score_size / 2) * total_stride
xx, yy = np.meshgrid([ori + total_stride * dx for dx in range(score_size)], [ori + total_stride * dy for dy in range(score_size)])
xx, yy = np.tile(xx.flatten(), (anchor_num, 1)).flatten(), np.tile(yy.flatten(), (anchor_num, 1)).flatten()
anchor[:, 0], anchor[:, 1] = xx.astype(np.float32), yy.astype(np.float32)
""
I print anchor. But output of anchor is very strange. Would you please explain these code?
My understanding is:
In feature map 17 * 17 * 256, therefore 289 anchors in total. Aera of every anchor's bbox is 64 * 64 in corresponding to ratios[0.33 , 0.5 , 1 , 2 , 3].
And mapped to  search image 255 * 255, each anchor generates 5 types of bbox(aera size: 64 * 64).
Stride is 255 / 17 = 16,  that is,  every 16 pixels exists one anchor,  uniformly distributing  in search image 255 * 255.
I got all regions of proposal.
Is that right?

The stride must be the same as the network, is 8. The anchor position is in [255//2 - 17/2 * 8, 255//2 + 17/2 * 8], which is center at the original image center. This is different from detection since our network do not have padding, so some border part is 'ignored' by the network

Thank you very much!!!  I have change my anchor position in stride:8
I came across another problem when training, I set batch_size in dataloader as 1,  the network in "SiamRPNBIG" worked and training loss dropped down .
But, if I set other batch_size( > 1) it appeals to wrong . It seems that, dimension of net mismatches with input image elements.
So could you give some suggestion to how to train SiamRPN net with larger patch_size?  Cuz it's not likely to use only 1 batch_size to train so big data...


Sdk 596 disable all instrumentation based on env variable bool

Codecov Report

Merging #97 (5ea53f1) into main (3837798) will increase coverage by 0.17%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   87.82%   88.00%   +0.17%
==========================================
  Files          13       13
  Lines         493      500       +7
==========================================
+ Hits          433      440       +7
  Misses         60       60

Impacted Files
Coverage Δ

cisco_telescope/consts.py
100.00% <ø> (ø)

cisco_telescope/tracing.py
92.00% <83.33%> (-0.46%)
:arrow_down:

cisco_telescope/options.py
98.03% <100.00%> (+0.53%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3837798...5ea53f1. Read the comment docs.


AttributeError: module 'discord' has no attribute 'version_info'

Please tick all applicable boxes.

[+ ] I am using Python 3.5 or higher (run python --version on the command line)
[+ ] I have followed the official guides to install the bot for my system
[+ ] I have updated my dependencies to the latest version using the appropriate update script

Which version are you using?

[+ ] The latest master version (1.9.8)
[+ ] The latest review version

What type of issue are you creating?

[+ ] Bug
[ ] Feature request
[+

] Question

Description of issue
Steps to reproduce

Log file
Please attach your MusicBot log file (located at logs/musicbot.log) to this issue. You can do so by dragging and dropping the file here. If you do not include your log file, you WILL be asked to provide one.
Hi, so my issue is that i cant run my bot. Everything was working fine yesterday. Seems like theres problem with run.py. Anyone else is having this problem or just me?

Well you're on Windows so for starters let's try running the appropriate file run.bat

Well you're on Windows so for starters let's try running the appropriate file run.bat

As i said, it was working yesterday. Im running appropriate run.bat.

Have you tried running the update file?
Can you send a log as well.

Have you tried running the update file?
Can you send a log as well.

Yeah, i tried updating. I even tried to reinstall the whole bot.

Type python -m pip install -U -r requirements.txt in that console

Type python -m pip install -U -r requirements.txt in that console

Nothing, tried to run that command on the same console aswell.

Please reinstall python

Please reinstall python

Yeah i though that would be the problem, Will do in a second.

Is it python 3.7 and did you install to path?

Is it python 3.7 and did you install to path?

Latest version python and it installed on my HDD

When installing did you pick install to path?

When installing did you pick install to path?

Yeah, still same issue

after that just same issue remains

When installing did you pick install to path?

Any help?

Your screenshot of python -m pip install -U -r requirements.txt wasn't the full thing, please ensure that you waited for it to put you back to something along the lines of D:\Program Files (x86)\discobot\MusicBot> before closing it.

It breaks everytime i try to stream this radio
https://www.liveonlineradio.net/estonia/raadio-star-fm.htm

It breaks everytime i try to stream this radio
https://www.liveonlineradio.net/estonia/raadio-star-fm.htm

It literally breaks the whole bot and you need to basically reinstall it.

that doesn't appear to be a direct link to a stream, and is just a webpage with a stream on it. You'd have to find the direct link, in this case being http://starfm.babahhcdn.com:8000/starfm

Closing due to inactivity. Ask for help in https://discord.gg/bots if you're still having issues.


[TwigComponent] Allow passing functions / array variables to HTML syntax

Hi!
This is something I keep wanting to do:
<twig:Button
    class="foo-bar">
    {{ stimulus_action('say', 'hello') }}
/>

I know why this doesn't work :). But from a user's perspective, I can't think of why it shouldn't. If we see a Twig {{ where we expect an attribute, then we should translate it effectively into a ...stimulus_action('say', 'hello') so its return value merges into the other props.

The closing > line 2  is a mistake.. or you suggest a new closing tag ?
Now for the stimulus_action method, it could be a ultra-easy... or a pure hell to implement.
The "context" there is the current template, not "in" the Button component (in a Twig-compiled-template point of vue)
Could you show an example with attributes, props before/after your suggestion ? I have something in mind but don't want to be "off-topic" :)

Update your src/Twig/TwigPreLexer.php
and add this block line 209 (before the variadic check)
            if ($this->check('{{ stimulus_') || $this->check('{{ stimulus_')) {
                $this->consume('{{ ');
                $attributes[] = '...' . trim($this->consumeUntil('}}'));
                $this->consume('}}');

                continue;
            }

            // rest of the file

            if ($this->check('{{...') || $this->check('{{ ...')) {
                $this->consume('{{...');

Is this the expected behaviour ?

I'm not sure to get... how could we handle this inside the function ?

I think I ran into the same problem.
I was trying to put symfony form stuff inside of a component like this:
<twig:ChipGroup {{ block('widget_container_attributes') }}>
    ....
</twig:ChipGroup>

It does not work which makes combining twig components and symfony forms quite difficult...


Question about preprocessing

A parameter of preprocessing seems different from the TensorFlow version.
In this Keras implementation, you subtract 1.0 from the image (https://github.com/kentsommer/keras-inceptionV4/blob/master/evaluate_image.py#L11).
On the other hand, in the TensorFlow implementation, they subtract 0.5 (https://github.com/tensorflow/models/blob/master/slim/preprocessing/inception_preprocessing.py#L273).
Why did you change this value?

I originally had left that value at 0.5, however, when I started crunching the performance numbers I noticed it performance increased somewhat if I used 1.0 instead. I'm not 100% sure why that would be the case, however, since I used it to achieve the performance metrics listed (which match the metrics here) I left the value at 1.0 for this release.

Thank you for your quick response!


Update json4s-jackson, json4s-scalap to 3.6.10

Updates

org.json4s:json4s-jackson
org.json4s:json4s-scalap

from 3.6.9 to 3.6.10.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.json4s" } ]

labels: library-update, semver-patch

https://github.com/json4s/json4s/compare/v3.6.9...v3.6.10