style: update look and feel of image animation on blog posts

Removed blog image fade in animations on featured post and cover image on post views

didn't like it without the animation


Item search not updating

When searching for items in Advanced Logistics System v0.12.12+, the list of items does not update.
I tried typing into the search field and waiting several seconds. I also tried pressing the "Enter" key. I also tried going to the "Settings" tab and clicking the "Update Logistic Data" button. I tried variations on search terms, eg uppercase/lowercase and partial words.
Tried v0.12.12 and v0.12.13 with Factorio v0.12.35 without any other mods.

I doubt anyone is still using 0.12 at this point, i just pushed an update for 0.13 that adds alot of new features and fixes most of the old bugs, and probably introduces new ones..
Please test it out and let me know if this is still an issue.


Feature/dewrangle volume hash

Pull Request Name

[X] partially closes https://d3b.atlassian.net/browse/D3B-192
[ ] README entry added if new functionality
[ ] fixup commits are appropriately squashed

[Description here]
This PR removes the dewrangle command and adds a volume command and hash subcommand. The hash command is largely a copy from https://github.com/d3b-center/dewrangle-python. I'm going to reorganize and document it in a later PR, but this serves as an initial copy.

@sickler-alex Is there any reason, why we don't use d3b dewrangle as the main command? I'm thinking there will be several sub-commands like hash volume, list volume...
I think the main commands should be structured around the key categories.
d3b validation
d3b dewrangle
d3b registration
...

That's a good question and I don't really have a good reason. I renamed it Dewrangle in #4.


sets up docker compose

fixes #121

@robacarp Agreed!

@robacarp I went ahead and fixed the REDIS_URL issue for development, it wasn't too hard. And I renamed "server" to "base" to make those commands a little clearer. That felt like a good balance of a service name that still makes sense within compose.yml but also makes sense when you're thinking of it as the thing you're executing arbitrary commands on. With that, I'm going to merge in!
I just discovered one more issue: chromedriver isn't installed in the docker image so you can't run the system tests:
docker compose run base rails test:system

Selenium::WebDriver::Error::WebDriverError: unable to connect to /root/.cache/selenium/chromedriver/linux64/121.0.6167.85/chromedriver <IP_ADDRESS>:9515

Issue #137

Has anyone bothered testing this recently?
When you do docker compose up now you get hit with:

Cannot render console from <IP_ADDRESS>! Allowed networks: <IP_ADDRESS>/<IP_ADDRESS>

So I went in and edited config/environments/development.rb and changed line 79 from
   config.web_console.permissions = "<IP_ADDRESS>/16"

to
   config.web_console.permissions = "<IP_ADDRESS>/16"

so that it, you know, runs on Docker networks...
But then I get hit with a big-ole Sprockets::Rails::Helper::AssetNotFound in Sessions#new
The asset "tailwind.css" is not present in the asset pipeline.
error.

Also, I want to run this via docker in production. How do I change the environment???
It seems you left stuff out of the README and/or the docker compose setup has bitrotted in just 3 months to the point of not being able to be setup on the first run.

@hopeseekr There are no known issues and I test regularly, but let me investigate a bit more. I'm going to convert this to an issue to keep us organized.


Need to create generic method for below point

1).  When I create a patient, an ID is generated for them, and I need to store that ID in a JSON file.
2). I always need to enter a unique employee ID, so instead of having to manually change the bar, generate a random ID and enter it
in place of the employee ID.
3)  When 10 patients are generated for one mobile number, automatically switch to the next mobile number or increment the current one.

And also need for Robotics class reusedable method


tags and capturing from objc, swift, and js

hi, right now we have an app with objc, swift and js with react native. currently we use sentry-swift, and we have a small wrapper that we can call from all three.
with react-native-sentry, can we still do that? do we need to make the wrapper call to the js part? or can we use Sentry.capture.. from js and [Sentry capture..], etc?
(we get some weird errors on the website when crashes happen and the stack is incomplete. so maybe this library will help with that.)

Hey, yeah this should be possible ...
For javascript SDK usage read: https://docs.sentry.io/clients/react-native/
For native SDK usage read: https://docs.sentry.io/clients/cocoa/
Also the example project is quiet helpful for sentry-swift https://github.com/getsentry/sentry-swift

so i have to install and link all both react-native and swift-sentry then?

If you install react-native-sentry you will get sentry-swift which you can then use in your custom native code.
Just import it @import Sentry

aha ok. so they i use the swift one for native code, and the other for js.
but can i set the tags and the dsn etc from js? or only native? or do i have to set it up from both?

If you want to use sentry in both your custom js code and swift code ... you have to set them up separately ... see docs.

ok. so i treat them as separate things. thanks. in the docs for react-native it doesnt say anything about using sentry in the native part, so i was confused.

@HazAT is @import Sentry still a thing thats possible? i cant seem to be able to import it.

@pvinis How did you install it?
@import should work if you install it via CocoaPods
If you use the latest version you have to import it like this
#import <KSCrash/KSCrash.h>
#import <Sentry/Sentry.h>

i am not using cocoapods.
i just installed via yarn, and linked.
on objc, i can import, but on swift i cant.


Fix for Issue #271

Small change, but may help if we're still wanting to get performance testing back up.

Also starting small seems like a good idea. I'm still getting used to the whole "Legit Project I Don't Control" workflow.

Thanks! Please remove console.logs. You can see a diff of what's changing by clicking on the "Files Changed" tab in GitHub: https://github.com/google/tie/pull/272/files -- it's a good idea to make sure that's correct and exactly what you intend, before getting a review.
(Also, passing to @eyurko for review, once you've got this PR finalized.)

Whoops! Forgot I'd done that.

Hi @BenjaminHolland, thanks! As a general rule, could you also try to make sure the diff is as minimal as possible? In other words, the stuff in the "Files changed" tab should contain a few changes from time.time to time.clock, and nothing else.

I'll check that in the future. A lot of times Im doing commits in quick
breaks during other projects, so I don't always check everything before the
commit as closely as i should.
On Apr 27, 2017 1:00 PM, "Sean Lip"<EMAIL_ADDRESS>wrote:

Hi @BenjaminHolland https://github.com/BenjaminHolland, thanks! As a
general rule, could you also try to make sure the diff is as minimal as
possible? In other words, the stuff in the "Files changed" tab should
contain a few changes from time.time to time.clock, and nothing else.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/tie/pull/272#issuecomment-297823023, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACYwXQ9RRyplL3sSTyHPmIly6b6NP0rLks5r0PPpgaJpZM4NKYLy
.

Regarding the referenced waiting pulls, would you prefer each one be done individually or have them merged into a single one?

Ah -- please see comment in https://github.com/google/tie/issues/277#issuecomment-297873487. Each should be done individually (especially if they're for unrelated things) so that they can be reviewed separately, but you can have multiple branches open at once.


Plan and Billing

Quite possible because I have no Pro account, I cannot make a request.  But there seems like no "free quota" at OpenAI.
Python: Traceback (most recent call last):
  File "/Users/jimmygunawan/Library/Application Support/Blender/3.4/scripts/addons/BlenderGPT-main-2/__init__.py", line 53, in generate_blender_code
    response = openai.ChatCompletion.create(
  File "/Users/jimmygunawan/Library/Application Support/Blender/3.4/scripts/addons/BlenderGPT-main-2/lib/openai/api_resources/chat_completion.py", line 25, in create
    return super().create(*args, **kwargs)
  File "/Users/jimmygunawan/Library/Application Support/Blender/3.4/scripts/addons/BlenderGPT-main-2/lib/openai/api_resources/abstract/engine_api_resource.py", line 153, in create
    response, _, api_key = requestor.request(
  File "/Users/jimmygunawan/Library/Application Support/Blender/3.4/scripts/addons/BlenderGPT-main-2/lib/openai/api_requestor.py", line 226, in request
    resp, got_stream = self._interpret_response(result, stream)
  File "/Users/jimmygunawan/Library/Application Support/Blender/3.4/scripts/addons/BlenderGPT-main-2/lib/openai/api_requestor.py", line 619, in _interpret_response
    self._interpret_response_line(
  File "/Users/jimmygunawan/Library/Application Support/Blender/3.4/scripts/addons/BlenderGPT-main-2/lib/openai/api_requestor.py", line 682, in _interpret_response_line
    raise self.handle_error_response(
openai.error.InvalidRequestError: The model: `gpt-4` does not exist

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/jimmygunawan/Library/Application Support/Blender/3.4/scripts/addons/BlenderGPT-main-2/__init__.py", line 146, in execute
    blender_code = generate_blender_code(self.natural_language_input)
  File "/Users/jimmygunawan/Library/Application Support/Blender/3.4/scripts/addons/BlenderGPT-main-2/__init__.py", line 65, in generate_blender_code
    response = openai.ChatCompletion.create(
  File "/Users/jimmygunawan/Library/Application Support/Blender/3.4/scripts/addons/BlenderGPT-main-2/lib/openai/api_resources/chat_completion.py", line 25, in create
    return super().create(*args, **kwargs)
  File "/Users/jimmygunawan/Library/Application Support/Blender/3.4/scripts/addons/BlenderGPT-main-2/lib/openai/api_resources/abstract/engine_api_resource.py", line 153, in create
    response, _, api_key = requestor.request(
  File "/Users/jimmygunawan/Library/Application Support/Blender/3.4/scripts/addons/BlenderGPT-main-2/lib/openai/api_requestor.py", line 226, in request
    resp, got_stream = self._interpret_response(result, stream)
  File "/Users/jimmygunawan/Library/Application Support/Blender/3.4/scripts/addons/BlenderGPT-main-2/lib/openai/api_requestor.py", line 619, in _interpret_response
    self._interpret_response_line(
  File "/Users/jimmygunawan/Library/Application Support/Blender/3.4/scripts/addons/BlenderGPT-main-2/lib/openai/api_requestor.py", line 682, in _interpret_response_line
    raise self.handle_error_response(
openai.error.RateLimitError: You exceeded your current quota, please check your plan and billing details.

I have the same problem as well. have you found the solution ?

Have you find solutions ??

I get this immediately, without having used it at all, which can't be, as I have not been using my quote or anything. Any explaination why this is happening? is this a bug that prevents the plugin from working in the first place?

You need to replace the line in the __init__.py file
model = "gpt-3.5-turbo"

to
model = "text-davinci-003"

You need to replace the line in the __init__.py file
model = "gpt-3.5-turbo"

to
model = "text-davinci-003"

That makes no difference on my end.

As the error says : You exceeded your current quota, please check your plan and billing details.
Do you pay for your GPT-4 API? Also, it seems that they have a waitlist now : https://openai.com/waitlist/gpt-4-api

It may sound stupid but can you clarify something for me? I pay for Chat-GPT-4. Is this not the same thing as GPT-4 and having API access? Do I also need to pay for the API access once I'm through the waitlist?
Also, the pro version of this plugin says it lets us use GPT-4 for free through a single payment of 29.99. That's fine but what are the limitations here? Do we have a limit of commands/ prompts per day?


How can I hide a minutes bar in date time picker

How can i hide a minutes bar in datetime picker??

date-only="true" as in README.md.

Sorry I could have asked you some what clearly. I need datetime picker with hours but not minutes bar..


App picker view

Should have two buttons: "De-identification" and "Visualisation"

Can You create a branch called user_interface so I can create a pull request?

@RichJackson, I have granted admin permissions to DEID group for this repository, so now you should be able to create branches. Going back to Git flow branching model discussed during a hackathon, please keep in mind naming conventions, e.g. feature/user-interface for UI developments.


CNV-41590: sysprep volume missing on creation of a VM with Sysprep

📝 Description
On create VM with IT flow (quick create) the sysprep was done after the VM was created, hence it wasn't added to the VM.
🎥 Demo
After:
https://github.com/kubevirt-ui/kubevirt-plugin/assets/67270715/0ec47272-82c6-499d-8749-52c2ef133322

/retest

/lgtm

/cherry-pick release-4.16


rename landsat to sentinel

Think I missed the notice of this PR, but thanks @samsammurphy, I'm changing it to merge vs develop, since we merge to develop first, then merge from develop to master upon a release.

ah, my bad.. thanks for changing to merge to develop :pray:


Rename callback blocks to completion to support Swift async and await

Fixes #91

Did you intend to include related changes to DaysUntilBirthday here?

n/m, I see #190 now.


Docs panel doesn't reset scroll position on navigation

Describe the bug
In the docs panel on the right, when I scroll down and click on some field (which has enough content to be scrollable), the scroll position remains the same on the vertical axis. Say, I scrolled down 200px, it remains at 200px in the new page rendered from clicking on a field. It's not visible when the new page doesn't have enough content to be scrollable, but reproducible otherwise.
To Reproduce
Steps to reproduce the behavior:

Open docs panel on the right
Click on any field which will have enough content to be scrollable
Notice that scroll position is still the same and not reset to 0 for a new page

Expected behavior
Scroll position should be reset for any new page render
Screenshots
Please view linked screenrecord: https://streamable.com/gvh2b
Desktop

OS: Ubuntu 18.04.3 LTS
Platform: snap
Version 2.4.3

Additional context
Nothing I can think of.

Thanks for reporting this! I'd look into it as soon as I can.

Thank you @imolorhe, although I feel this is more a bug than an enhancement. 🤔

I considered it an enhancement since it is the default behavior, and not because of an issue. I just need to change from that default behavior, to an "enhanced" one 🙂


When to set unit status

https://github.com/NucciTheBoss/charming-exercises/blob/20e2c30e57d8fb3d41dac342b6542f2f6d3b7b55/hot-potato/src/charm.py#L111
Is this the correct place to set the unit.status? What happens when this call is in the init()?

Fixed in the latest commit.


Add --force flag for validation on shopify theme dev if users are running the command in a theme directory

WHY are these changes introduced?

Fixes https://github.com/Shopify/shopify-cli/issues/2669
Addition to https://github.com/Shopify/shopify-cli/pull/2680

We want to…

ensure that partners execute shopify theme serve/dev in the correct directory
enforce the usage of the theme architecture directory structure

WHAT is this pull request doing?
Add --force flag for validation on shopify theme dev if users are running the command in a theme directory.
How to test your changes?
See https://github.com/Shopify/shopify-cli/pull/2680, but test with shopify theme dev, instead of shopify theme serve.
Make sure that your CLI 2.x version has the correct changes.
Post-release steps

[ ] Update shopify.dev docs, as --force flag has been added. (I will create an issue/a PR as soon as the --force flag idea has been accepted.)

Measuring impact
How do we know this change was effective? Please choose one:

[x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

[x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[x] I've considered possible documentation changes
[ ] I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

👋 depending on when this merges, keep this other PR in mind to allowlist force in dev.ts


Automate release of latest container image

With the current state of the project, we're still using the latest container image tag.
Although it's an anti-pattern, at every commit landing in the main branch (in our case, master), we should trigger a Docker CI build and push the artifact to our repositories with the tag latest.

Considering latest is an anti-pattern, and the connection with Docker Hub building upon any change on the main branch, we can close this.


add ability to comment out queries with cmd + /

Description

I had some extra time, and this has been bothering me, so I decided to add it. Doing cmd + / in the query console now will add/remove --   before the lines.
A video is probably best here

This doesn't handle resetting selection mostly because I didn't feel like going down that road. I think this is a good start for now for the query console.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

[ ] Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

[ ] Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

New configuration options
Deprecation of configurations
Signature changes to public methods/interfaces
New plugins added or old plugins removed

[ ] Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

Codecov Report

Merging #7841 (f727bd2) into master (1e25962) will decrease coverage by 57.04%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #7841       +/-   ##
=============================================
- Coverage     71.67%   14.62%   -57.05%
+ Complexity     4089       80     -4009
=============================================
  Files          1579     1534       -45
  Lines         80843    78981     -1862
  Branches      12010    11814      -196
=============================================
- Hits          57944    11554    -46390
- Misses        18995    66566    +47571
+ Partials       3904      861     -3043

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
?

unittests2
14.62% <ø> (-0.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e25962...f727bd2. Read the comment docs.


Recording Doesn't Work When Download the Stream body

If we turn on recording for async calls, the response body which is a stream will be loaded first, which means after we record the service returned stream is consumed, so when we want to consume the stream it becomes empty.
Here are some options to help us fix the async problem:

Make some changes to the async recording code:  wrap the recorded content in a new stream to pretend the consumer is reading from the service returned stream if the test is running in playback mode or recording mode, I guess @seankane-msft probably can help
Make changes to _aiohttp.py in azure-core so that users can opt in getting raw response body or decompressed response body. This would help because currently storage sdk is calling AioHttpTransportResponse.load_body() to get response body all the time. The reason we load the body into memory is: for client side encrypted blob, we have to load the whole chunk into memory to decrypt. Our default download blob chunk size is 4MB, which means only 4MB is loaded into memory at a time in a single thread, while this option would cause problem if user specify a larger chunk size. (for this one @xiangyan99 has more context)
We can wait for Mockup server feature to complete, while we are not sure if the Mockup server can support this

Also if we turn on recording for sync calls, the recording is always trying to decompress the content no matter if we want to get raw content or not. This is because the recording happens before calling stream_download(), and stream_download() is where we can control decompress or not in live mode test.

Hi @scbedd
We don't have existing test that encounters this problem, while we can push a branch, and by pulling that branch you can reproduce that in pytest. Let me know if you need that branch!

@xiafu-msft please do! Examples are awesome to work 👍

Hi @scbedd
Here is the branch you can check out https://github.com/Azure/azure-sdk-for-python/pull/19405/files
I added some comments so you can find where to test obviously. Let me know if you need any other info!

Hi @scbedd - do we have an updated status on this one?
The tests are blocking us from shipping a rather important bug fix, so it would be good to get a sense for what the timeline to resolve this might look like.

Confirmed solved ;)


Multiline output is covered by code

Description:
When the kernel is running and a multi line output is expected then it appears to occupy one line below but the other parts are invisible/covered
[Description of the issue]
Steps to Reproduce:
for example when I run this
import pygame
import numpy as np

I get an image like  this:
https://pasteboard.co/GzFD9wt.png
Versions:
Which OS and which version of Hydrogen and Atom are you running?
OS: Ubuntu 16.04 - Hydrogen: 1.19.0 - Atom: 1.19.0-beta2
You can get this information from copy and pasting the output of atom --version  from the command line.

Closing as a duplicate of #898
This will be fixed in the upcoming Atom: 1.19.0-beta3 release. Until that you can use the external output area with "Hydrogen: Toggle Output Area".


[Storage] [Typing] [File Share] Decoupled _share_client.py and _share_client_async.py

This PR contains these changes:

Annotated class APIs
Decoupled _share_client.py and _share_client_async.py
Formatted comments, # type: ignore and # pylint: disable=... to our existing convention

There are a few imports reordered, but all will be in order after resolving mypy issues :)

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-storage-file-share


Directives Parsing

Hi! Project falls on the follow example:
type Mutation {
    createUserOld(user: User!): User! @deprecated (reason: "Use 'createUserNew' instead")
    createUserNew(user: User!): User!
}

I will work on it. Thanks!

I've just released PR #8 to master branch. Please try again with it and let me know if you have any further error.

Works fine! Thank for such quick response!

Thank you is mine. I can build more codes for unexpected schema examples thanks to your issues.


/tp forgetting world dimension

but, after I do it with the world, the next time I do that command I don't have to put the world name. it's like it somehow doesn't know where I'm at

Closing as cannot reproduce


Updated the fira sans font files with encoding latin-extended

Fixed https://github.com/OpenSlides/openslides-client/issues/1172

I tested your new font files by creating a new motion with theses chars.
With current (upstream) latin font files:

With your extendet latin files:

There are a lot of new supported chars now. But also some unsupported chars. Can we ignore it?
User list PDF with your full name works as expected.

@emanuelschuetze We could also support all 7 character sets: latin, latin-ext, greek, greek-ext, cyrillic, cyrillic-ext, vietnamese. That would be my favorite.
For the font files in woff format this would mean:
Fira Sans, version 16 (2022-09-22)
Fira Sans Condensed, version 10 (2022-09-22)

As discussed with @emanuelschuetze: We include the latin and latin-ext charsets for the following fonts in the release:
Fira Sans, version 16 (2022-09-22)
Fira Sans Condensed, version 10 (2022-09-22)
For the charsets greek, greek-ext, cyrillic, cyrillic-ext and vietnamese I will create a FAQ.


Manually Delete Files

Is your feature request related to a problem? Please describe:
I can't manually delete a file, so when the AI moves the file to a new directory, sometimes it leaves the old file behind. telling it to delete that file usually deletes the wrong one.
Describe the solution you'd like:
I would like to be able to manually delete a file in the editor, or manually rename a file in the editor
Describe alternatives you've considered:
I wasted probably 11-12 prompts just to clear the file
Additional context:
No additional Context

Hi! 👋 Thanks for the comments!
I agree, it would be great to have this feature! We're tracking this internally. We'll keep you posted ✨


Release 1.0.0 part 1/3: CHANGELOG, README, Makefile

Part of Release v1.0.0

/approve
/lgtm

/approve cancel

/approve


could not demangle keypath type from '1���XD': file

Fatal error: could not demangle keypath type from '1���XD': file /BuildRoot/Library/Caches/com.apple.xbs/Sources/swiftlang/swiftlang-1<IP_ADDRESS>/swift/stdlib/public/core/KeyPath.swift, line 2611

Fix on pod 5.0.0
I update my pod support on swift5

Thankyou for quick response.
On Wed, 24 Apr 2019 at 08:36, Millman Yang<EMAIL_ADDRESS>wrote:

Closed #62 https://github.com/MillmanY/MMPlayerView/issues/62.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MillmanY/MMPlayerView/issues/62#event-2295881927, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ALVOI4445OSSYGNW64LCJYLPR7FDJANCNFSM4HHWTLVA
.

How did you update pod support to swift 5?

Thankyou for quick response.
…
On Wed, 24 Apr 2019 at 08:36, Millman Yang @.***> wrote: Closed #62 <#62>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#62 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/ALVOI4445OSSYGNW64LCJYLPR7FDJANCNFSM4HHWTLVA .

Fix on pod 5.0.0
I update my pod support on swift5

How?


transaction_id is not set when deleting a has_many association record.

Is this expected behavior?

I'm so sorry, transaction_id was actually set. My bad.


Compilation error in erlware_commons on Elixir v1.2.1

When trying to build master using Elixir v1.2.1, I get this:
==> erlware_commons
Error evaluating rebar config script ./rebar.config.script:16: evaluation failed with reason error:{badmatch,undefined} and stacktrace [{erl_eval,expr,3,[]}]
Any dependency defined in the script won't be available unless you add them to your Mix project

The fix is already in master of erlware_commons, but not yet published.

hey! faced similar problem, quick fix:
{:cf, "~> 0.2.1", override: true}, # remove this later  {:erlware_commons, github: "erlware/erlware_commons", override: true}, # remove this later

@parubets I tried that -- was depending on exrm master, and attempting your fix I get errors like:
WARN:  /Users/mrluc/projects/mine/elixir/convoke/_build/prod/lib/erlware_commons/ebin/erlware_commons.app has version "0.18.0"; requested regex was 0.15.0
Dependency not available: erlware_commons-0.15.0 (undefined)
ERROR: compile failed while processing /Users/mrluc/projects/mine/elixir/convoke/deps/relx: rebar_abort
** (Mix) Could not compile dependency :relx, "/usr/local/bin/rebar compile skip_deps=true deps_dir="/Users/mrluc/projects/mine/elixir/convoke/_build/prod/lib"" command failed. You can recompile this dependency with "mix deps.compile relx", update it with "mix deps.update relx" or clean it with "mix deps.clean relx"

@parubets's temporary fix worked for me, FWIW. @mrluc did you try deleting your _build and deps directories and running mix do deps.get, compile

@alco @parubets @mrluc @johnhamelink A fix is coming to relx for this, I'll update exrm to use the new version as soon as it's released.

Still getting the following:
mrluc@airy:someapp$ rm -rf deps/
mrluc@airy:someapp$ rm -rf _build/
mrluc@airy:someapp$ mix deps.get
... (successfully got) ...
mrluc@airy:someapp$ mix compile
... lots of output, then,
WARN:  .../_build/dev/lib/erlware_commons/ebin/erlware_commons.app has version "0.18.0"; requested regex was 0.15.0
WARN:  .../_build/dev/lib/erlware_commons/ebin/erlware_commons.app has version "0.18.0"; requested regex was 0.15.0
==> relx (compile)
WARN:  /Users/mrluc/projects/mine/elixir/convoke/_build/dev/lib/erlware_commons/ebin/erlware_commons.app has version "0.18.0"; requested regex was 0.15.0
WARN:  .../_build/dev/lib/erlware_commons/ebin/erlware_commons.app has version "0.18.0"; requested regex was 0.15.0
Dependency not available: erlware_commons-0.15.0 (undefined)
ERROR: compile failed while processing .../deps/relx: rebar_abort
** (Mix) Could not compile dependency :relx, "/usr/local/bin/rebar compile skip_deps=true deps_dir=".../_build/dev/lib"" command failed. You can recompile this dependency with "mix deps.compile relx", update it with "mix deps.update relx" or clean it with "mix deps.clean relx"

Will look at it later

@johnhamelink yeah, I just forgot that I also had to mix deps.update erlware_commons as they're github deps.
TL;DR: needed to add an override git dependency on relx, and then mix deps.clean --all && mix deps.update erlware_commons relx
Using tsloughter's pull request, above, it updated the error to:
 erlware_commons.app has version "0.18.0"; requested regex was 0.19.0
I forked erlware_commons and bumped its version to 0.19.0 to ensure that it was just the version number causing trouble, and that worked.
Since it's just version number causing problems, and since relx master already uses correct version, adding a git dependency for relx makes the following git dependencies all work together for me right now:
      {:exrm, git: "git://github.com/bitwalker/exrm.git"},
      {:relx, github: "erlware/relx", override: true}, # <-- depends on erlware_commons-0.18.0
      {:erlware_commons, github: "erlware/erlware_commons", override: true}, # <-- @0.18.0 right now
      {:cf, "~> 0.2.1", override: true},

Can't wait for updated packages though ... to make releases work in my umbrella app, each subapp also needs those deps! :)

+1
Mac OSX 10.11
Elixir 1.2.1
Erlang/OTP 18

+1
Ubuntu 14.04
Elixir 1.2.1
Erlang/OTP 18

The commit to relx master has been merged, so you no longer need to override erlware_commons, just relx for now. Once a new release of relx is pushed, I will update exrm.

I published a new relx to hex.

Thanks @tsloughter!
 Anyway, you all should be good to go now.

I get this same issue when I tried to upgrade build to use Erlang 1.9.

Can this be reopened pending release of a new relx, or is there another issue I should subscribe to for updates? My team has an app that can't compile against Erlang 19, seemingly because of this issue.

I published a new release today with an updated relx, should be good to go!


Transaction list api's

/usermanager/api/v1/transactions/
This above api is giving 11 records and it takes 30ms
This /api/v1/payments?limit=100&offset=0
This above api is giving me 41 records and it takes 31 seconds
Can you please make core api faster ?
and user manager api is returning only pending = true records.
Maybe a bug

Is this bug report for for the demo server (https://legend.lnbits.com/)
does it happen all the time, or just occasionally?

can you try again, payments endpoint was improved, the rest is related to usermanager endpoint?

Closed for inactivity


Fixed some spelling and grammar in readme.md

Fixed some spelling and grammar in readme.md

Fixed misspelling of "documentation"
Made a few things more consistent (comma usage, period after etc., period at the end of a line)
Removed some trailing spaces on several lines

Thank you @KellyWalker .


Feature request for CLI debugger: Disable "break on start"

Version:
v9.5.0
Platform:
Darwin joe.sph.ad.jhsph.edu 17.6.0 Darwin Kernel Version 17.6.0: Tue May  8 15:22:16 PDT 2018; root:xnu-4570.61.1~1/RELEASE_X86_64 x86_64
Subsystem:
OS X?

Desired CLI command
Something like: node inspect PATH/TO/FILE --break-on-breakpoints-only
Current behavior
node inspect PATH/TO/FILE results in:

...
Break on start in PATH/TO/FILE:1
...

Desired behavior
node inspect PATH/TO/FILE --break-on-breakpoints-only would result in:

...
Breaking on in PATH/TO/FILE:X
...
...where "X" corresponds to the line number in the file where debugger; first appears.

References

Previous request
Stackoverflow

Any updates on this?

@bag-man I don't think anybody is actively working on this unfortunately.

I get that break on start might be useful in certain situations*, but no other debugger I've ever used works this way so in it's dissimilarity it's a feature that further complicates debugging in Node.
Node feels to me like the platform most indifferent to existing (e.g. UNIX) standards and likes inventing it's own ways of doing things. I don't see this as a good thing. The debugger is key among my frustrations of this type.
*it seems mostly useful if you are working on Node itself(?)

Please don't take this as a random criticism, I'm only trying to communicate my viewpoint. If someone wants to point me in a direction towards contributing on something that aligns with my viewpoint of making the Node debugger feel more "standard" please do.

All CLI debuggers need to break early to give the user a chance to setup breakpoints. E.g. in GDB you would start, load the executable, set breakpoints then run. Sometimes this may be annoying, and the way to deal with it in GDB is to autoexecute commands on load. Maybe, node-inspect could do the same, provide a way to supply a script that would be executed on start? Then user can simply run node-inspect with “continue”

I always set breakpoints with a debugger statement in the actual code, so I never need it to break on start.
I think a good cli debugger for node would be really cool to have, and it's certainly possible to make. I think the problem is most node developers use the chrome inspector for their debugging porpoises :dolphin:, so it's never going to happen unless we make it ourselves.

Yeah, I personally use vscode or Chrome Devtools as my primary debug client. node inspect (like node debug before it) is effectively in maintenance mode. Nobody is actively trying to push it forward since nobody seems to both use it and have time to contribute to its evolution.

it seems mostly useful if you are working on Node itself(?)

I think this is trying to rationalize too much. I'm pretty sure that the current behavior is the consequence of two things:

It was the easiest way to implement the lldb / other CLI debugger flow of "start CLI debugger, configure / set breakpoints, run program" when the very first version of node debug was written.
Since then, the CLI debugger has consistently been something that was considered too important to remove but at the same time it was never used widely enough to motivate somebody to work on its UX.

For working on node itself, the CLI debugger isn't really useful because it can't capture C++ calls and it's not integrated with any editor. The only place that has been brought up consistently where people use it, is in environments where people have to debug a program on a locked-down production system that doesn't allow installation of additional tools or exposing any ports.

I guess the issue here is that Node didn't spawn the Javascript development environment since V8 and other engines were built before Node, which led to an atypical debugging setup. I feel like the debugging setup has snowballing effects that prevents Javascript from being maybe as useful as it could be outside of web development. Anyway I guess right tool <> right job, all that.


enable error-prone's DisableUnicodeInCode check

Previously this error-prone check was not enabled, requiring code to be simple ascii, because of violations in spatial3d. I used find-replace on the greek letters there and the tests pass.
Closes #12931

Thanks @rmuir!


No qemu_procfs connectors found

When I run cloudflow -ef it cannot find connector after issuing the command:
echo "my_qemu_vm qemu" >> /cloudflow/connector/new
According to your description the name "my_qemu_vm qemu" must be exactly like this because it would try to connect to the first windows vm found.
All of the following packages were installed with memflowup utility from source.
memflow-win32 - CorePlugin [installed: git 9d690f]
memflow-native - CorePlugin [installed: git 8b056b]
memflow-qemu - CorePlugin [installed: git 306636]
memflow-coredump - CorePlugin [installed: git 98f2eb]
memflow-kcore - CorePlugin [installed: git 2eea57]
memflow-pcileech - CorePlugin [installed: git edaca4]
memflow-kvm - CorePlugin [installed: git 3e782a]
Expected behaviour: cloudflow is able to find the connector after starting the daemon with -ef parameter.

this would be the detailed output on my debian trixie kvm hypervisor:
does anyone have an idea how to fix this? I tried a whole reinstall of debian with trixie but nearly everything from h33p s guide is different now.
This 2 error messages are most concerning for me right now:
outdated/mismatched Connector plugins where found at: /usr/local/lib/memflow
[ERROR] outdated/mismatched Connector plugins where found at: /usr/local/lib/memflow
user@srvhyp01:~/projects/memflow-applied/scanflow$ cloudflow -ef -vvv
20:17:08 [INFO] scanning "/usr/local/lib/memflow" for libraries
20:17:08 [WARN] MEMFLOW_OS_WIN32 has invalid ABI.
20:17:08 [WARN] MEMFLOW_CONNECTOR_COREDUMP has invalid ABI.
20:17:08 [WARN] MEMFLOW_CONNECTOR_KVM has invalid ABI.
20:17:08 [WARN] MEMFLOW_CONNECTOR_KCORE has invalid ABI.
20:17:08 [WARN] MEMFLOW_CONNECTOR_PCILEECH has invalid ABI.
20:17:08 [WARN] MEMFLOW_OS_NATIVE has invalid ABI.
20:17:08 [WARN] MEMFLOW_CONNECTOR_QEMU has invalid ABI.
20:17:08 [WARN] MEMFLOW_CONNECTOR_KVM has invalid ABI.
20:17:08 [INFO] scanning "/home/luky/projects/memflow-applied/scanflow" for libraries
Mounting FUSE filesystem on /cloudflow
20:17:08 [INFO] filesystem mounted at /cloudflow
20:17:08 [INFO] please use 'umount' or 'fusermount -u' to unmount the filesystem
Initialized!
20:17:08 [INFO] Mounting /cloudflow
20:17:08 [DEBUG] (2) fuse::request: INIT(2)   kernel: ABI 7.38, flags 0x73fffffb, max readahead 131072
20:17:08 [DEBUG] (2) fuse_mt::fusemt: init
20:17:08 [DEBUG] (2) fuse::request: INIT(2) response: ABI 7.8, flags 0x1, max readahead 131072, max write 16777216
20:17:08 [DEBUG] (2) fuse::request: ACCESS(4) ino 0x0000000000000001, mask 0o004
20:17:08 [DEBUG] (2) fuse_mt::fusemt: access: "/", mask=0o4
20:17:08 [DEBUG] (2) filer_fuse: access "/"
20:17:08 [DEBUG] (2) fuse::request: LOOKUP(6) parent 0x0000000000000001, name ".Trash"
20:17:08 [DEBUG] (2) fuse_mt::fusemt: lookup: "/", ".Trash"
20:17:08 [DEBUG] (2) fuse::request: LOOKUP(8) parent 0x0000000000000001, name ".Trash-1000"
20:17:08 [DEBUG] (2) fuse_mt::fusemt: lookup: "/", ".Trash-1000"
20:17:14 [DEBUG] (2) fuse::request: LOOKUP(10) parent 0x0000000000000001, name "connector"
20:17:14 [DEBUG] (2) fuse_mt::fusemt: lookup: "/", "connector"
20:17:14 [DEBUG] (2) fuse_mt::inode_table: adding 2 -> "/connector" with 0 lookups
20:17:14 [DEBUG] (2) fuse_mt::inode_table: lookups on 2 -> Some("/connector") now 1
20:17:14 [DEBUG] (2) fuse::request: LOOKUP(12) parent 0x0000000000000002, name "new"
20:17:14 [DEBUG] (2) fuse_mt::fusemt: lookup: "/connector", "new"
20:17:14 [DEBUG] (2) fuse_mt::inode_table: adding 3 -> "/connector/new" with 0 lookups
20:17:14 [DEBUG] (2) fuse_mt::inode_table: lookups on 3 -> Some("/connector/new") now 1
20:17:14 [DEBUG] (2) fuse::request: OPEN(14) ino 0x0000000000000003, flags 0x8401
20:17:14 [DEBUG] (2) fuse_mt::fusemt: open: "/connector/new"
20:17:14 [DEBUG] (2) fuse::request: FLUSH(16) ino 0x0000000000000003, fh<PHONE_NUMBER>44, lock owner<PHONE_NUMBER>502418424
20:17:14 [DEBUG] (2) fuse_mt::fusemt: flush: "/connector/new"
20:17:14 [DEBUG] (2) fuse_mt::fusemt: initializing threadpool with 8 threads
20:17:14 [DEBUG] (5) filer_fuse: flush "/connector/new"
20:17:14 [DEBUG] (2) fuse::request: WRITE(18) ino 0x0000000000000003, fh<PHONE_NUMBER>44, offset 0, size 16, flags 0x6
20:17:14 [DEBUG] (2) fuse_mt::fusemt: write: "/connector/new" 0x10 @ 0x0
20:17:14 [ERROR] unable to find plugin with name 'qemu'.
20:17:14 [ERROR] possible available Connector plugins are:
20:17:14 [ERROR] outdated/mismatched Connector plugins where found at: /usr/local/lib/memflow/libmemflow_coredump.dev.so, /usr/local/lib/memflow/libmemflow_kvm.x86_64.so, /usr/local/lib/memflow/libmemflow_kcore.dev.so, /usr/local/lib/memflow/libmemflow_pcileech.dev.so, /usr/local/lib/memflow/libmemflow_qemu.dev.so, /usr/local/lib/memflow/libmemflow_kvm.dev.so
20:17:14 [ERROR] EoF
20:17:14 [DEBUG] (2) fuse::request: RELEASE(20) ino 0x0000000000000003, fh<PHONE_NUMBER>44, flags 0x8401, release flags 0x0, lock owner 0
20:17:14 [DEBUG] (2) fuse_mt::fusemt: release: "/connector/new"

Cloudflow is currently using a fairly old memflow version, you could try running cargo update on the repo to have it switch to memflow 0.2.0-beta10, and try again.

Hey, thanks for the issue! This is a slight oversight on my part. https://github.com/memflow/cloudflow has had older memflow versions in the lockfile. I just pushed a new version of cloudflow that mounts it directly to latest version 0.2.0-beta10 (which also all plugins you installed have).
Please reinstall cloudflow from the latest master branch and let me know if that resolves your issue.
I also fixed the compilation errors in cloudflow on the latest rust version by updating the minidump dependency.

I tried it and at least I can read process by name with ls in /cloudflow/os/win/processes/by-name and also got a minidump from the windows os. So I guess the cloudflow is working as expected right now.
Thank you very much!

I'm glad to hear that! If you encounter anything else please let us know :+1:


support multiple google accounts?

Hi, thanks for maintaining this; having dealt with google sheets directly in the past this is a much nicer interface.
I have multiple accounts that I want to periodically back up, so I have multiple credential.json files, one which has API access to each google account.
Currently, this writes to the same static token.pickle file to save credentials, so I can't use multiple files.
It fails with an error like:
    events = self.service.events().list(calendarId=self.calendar,
  File "/home/sean/.local/lib/python3.8/site-packages/googleapiclient/_helpers.py", line 134, in positional_wrapper
    return wrapped(*args, **kwargs)
  File "/home/sean/.local/lib/python3.8/site-packages/googleapiclient/http.py", line 907, in execute
    raise HttpError(resp, content, uri=self.uri)
googleapiclient.errors.HttpError: <HttpError 404 when requesting https://www.googleapis.com/calendar/v3/calendars/email-here/events?timeMin=1900-01-01T00%3A00%3A00-07%3A53&timeMax=2100-01-01T23%3A59%3A59.999999-08%3A00&orderBy=startTime&singleEvents=true&alt=json returned "Not Found">

... presumably because the email I'm requesting doesn't match the old credentials.
I think this could be pretty easily fixed by adding another kwarg to the GoogleCalendar constructor to specify a different pickle filepath.
I can create a PR if you're willing to merge that in. I haven't worked with readthedocs before, but I would think I just add the parameter here?
Perhaps the default could be token.pickle  (which gets combined into os.path.join(self._credential_dir, 'token.pickle')?; if a kwarg is provided it overwrites that filepath. Save that as self._token_path in __init__ and then access that in get_credentials? Not too sure on how that should handle a filename like other_token.pickle vs a full path provided by the user/how that'd be documented in readthedocs.
Edit: realized its possible to do this if I put my credentials in different directories, but that seems like a bit of a hack.

Hi, thank you for the issue submission!
You are right, that needs to be resolved. Though I would prefer the ability to avoid specifying the name of the token file. So my initial idea (without much research) is to name it something like <email>_token.pickle if the email is available from the token or credentials (that should be unique). That could be discussed, not sure how to do it better yet.
If you have time to try it, I will appreciate a PR very much! Please do it towards the dev branch. I think it might lead to a new major version (1.0.0 is coming).
As for the docs, I'll need to add it to the note (here in code) about adding it to .gitignore.
I'll come back to it ASAP.

<email>_token.pickle seems like it could work. Though if not provided that'd just be primary, which could cause some name conflicts. That could also lead to some non-determinism, if you're using multiple accounts. First account might get primary_token.pickle and then the other would have to default to some other filename, but if it was the other way, that would be confusing.
Another option could be the project_id, since from what I can see, that cant be changed, and is what google uses to uniquely identify API keys. May be a bit dangerous to parse the JSON since not sure if google could change the standard. I'll experiment with the internals of the credentials/service object to see if thats exposed somewhere.

Actually, since it tries to read the pickle file before json to use flow.run_local_server, isn't an obvious way to do this.
Looking at some of my older google API credentials it doesn't have the same structure so I don't think its wise to depend on the json structure in the credentials.json file.
If I'm mistaken about <email>_token.pickle let me know, else I'll continue to think if there's some other way to do this without passing a kwarg to explicitly change the file location.

Yep. You are right. The email isn't retrievable from credentials. So the only logical solution I see right now is to have an argument token_path that defaults to the same directory as credentials.json and token.pickle filename. So if token_path is None it'll get its path from the credentials_path. Which will be backward-compatible.

Alright, I can take a shot at submitting a PR.

Merged PR; closing


HBASE-22899 logging improvements for snapshot operations w/large manifests

HBASE-22899 logging improvements for snapshot operations w/large manifests

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
33
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
346
master passed

+1
compile
58
master passed

+1
checkstyle
84
master passed

+1
shadedjars
272
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
38
master passed

0
spotbugs
257
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
254
master passed

_ Patch Compile Tests _

+1
mvninstall
294
the patch passed

+1
compile
56
the patch passed

+1
javac
56
the patch passed

-1
checkstyle
77
hbase-server: The patch generated 1 new + 22 unchanged - 0 fixed = 23 total (was 22)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
290
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
960
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
33
the patch passed

+1
findbugs
250
the patch passed

_ Other Tests _

+1
unit
8973
hbase-server in the patch passed.

+1
asflicense
33
The patch does not generate ASF License warnings.

12431

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/547

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux a51f30b27f54 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh

git revision
master / 5106f2826e

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/1/artifact/out/diff-checkstyle-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/1/testReport/

Max. process+thread count
4764 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
74
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
353
master passed

+1
compile
58
master passed

+1
checkstyle
92
master passed

+1
shadedjars
306
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
37
master passed

0
spotbugs
261
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
258
master passed

_ Patch Compile Tests _

+1
mvninstall
329
the patch passed

+1
compile
58
the patch passed

+1
javac
58
the patch passed

-1
checkstyle
89
hbase-server: The patch generated 1 new + 22 unchanged - 0 fixed = 23 total (was 22)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
302
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1040
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
36
the patch passed

+1
findbugs
259
the patch passed

_ Other Tests _

+1
unit
12775
hbase-server in the patch passed.

+1
asflicense
26
The patch does not generate ASF License warnings.

16498

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/547

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 25c844b2cf59 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh

git revision
master / 56980fb097

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/2/artifact/out/diff-checkstyle-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/2/testReport/

Max. process+thread count
4679 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

I made the necessary changes as suggested and fixed the check-style issues.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
38
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
339
master passed

+1
compile
56
master passed

+1
checkstyle
81
master passed

+1
shadedjars
286
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
38
master passed

0
spotbugs
242
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
240
master passed

_ Patch Compile Tests _

+1
mvninstall
302
the patch passed

+1
compile
54
the patch passed

+1
javac
54
the patch passed

+1
checkstyle
75
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
266
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
935
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
36
the patch passed

+1
findbugs
258
the patch passed

_ Other Tests _

+1
unit
9461
hbase-server in the patch passed.

+1
asflicense
27
The patch does not generate ASF License warnings.

12889

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/547

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 5a6b56fd9b51 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh

git revision
master / 56980fb097

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/3/testReport/

Max. process+thread count
4491 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
70
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
354
master passed

+1
compile
55
master passed

+1
checkstyle
89
master passed

+1
shadedjars
300
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
36
master passed

0
spotbugs
254
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
252
master passed

_ Patch Compile Tests _

+1
mvninstall
330
the patch passed

+1
compile
57
the patch passed

+1
javac
57
the patch passed

+1
checkstyle
89
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
300
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1035
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
36
the patch passed

+1
findbugs
267
the patch passed

_ Other Tests _

-1
unit
15151
hbase-server in the patch failed.

+1
asflicense
27
The patch does not generate ASF License warnings.

18862

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestFromClientSide3

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/547

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 1e4cf2f40257 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh

git revision
master / 56980fb097

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/4/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/4/testReport/

Max. process+thread count
4771 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/4/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@busbey Could you please also take a look as the creator of the ticket?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
75
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
411
master passed

+1
compile
58
master passed

+1
checkstyle
89
master passed

+1
shadedjars
304
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
43
master passed

0
spotbugs
279
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
275
master passed

_ Patch Compile Tests _

+1
mvninstall
333
the patch passed

+1
compile
58
the patch passed

+1
javac
58
the patch passed

+1
checkstyle
89
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
311
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1046
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
36
the patch passed

+1
findbugs
282
the patch passed

_ Other Tests _

+1
unit
14119
hbase-server in the patch passed.

+1
asflicense
24
The patch does not generate ASF License warnings.

17961

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/547

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 3118f2e2914e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh

git revision
master / 83e77940c5

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/5/testReport/

Max. process+thread count
5155 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/5/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
39
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
348
master passed

+1
compile
58
master passed

+1
checkstyle
77
master passed

+1
shadedjars
274
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
40
master passed

0
spotbugs
247
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
244
master passed

_ Patch Compile Tests _

+1
mvninstall
297
the patch passed

+1
compile
56
the patch passed

+1
javac
56
the patch passed

+1
checkstyle
75
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
270
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
941
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
36
the patch passed

+1
findbugs
327
the patch passed

_ Other Tests _

+1
unit
10395
hbase-server in the patch passed.

+1
asflicense
29
The patch does not generate ASF License warnings.

13891

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/547

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux e4dcc698ff5b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh

git revision
master / 090c55f3ff

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/6/testReport/

Max. process+thread count
4390 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/6/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
44
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
421
master passed

+1
compile
71
master passed

+1
checkstyle
107
master passed

+1
shadedjars
351
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
46
master passed

0
spotbugs
311
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
309
master passed

_ Patch Compile Tests _

+1
mvninstall
352
the patch passed

+1
compile
78
the patch passed

+1
javac
78
the patch passed

+1
checkstyle
110
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
357
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1116
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
40
the patch passed

+1
findbugs
302
the patch passed

_ Other Tests _

+1
unit
9655
hbase-server in the patch passed.

+1
asflicense
25
The patch does not generate ASF License warnings.

13796

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/547

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux af18517388e1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh

git revision
master / 090c55f3ff

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/7/testReport/

Max. process+thread count
4295 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/7/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
38
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
316
master passed

+1
compile
54
master passed

+1
checkstyle
80
master passed

+1
shadedjars
271
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
37
master passed

0
spotbugs
242
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
239
master passed

_ Patch Compile Tests _

+1
mvninstall
296
the patch passed

+1
compile
58
the patch passed

+1
javac
58
the patch passed

+1
checkstyle
77
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
276
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
952
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
34
the patch passed

+1
findbugs
268
the patch passed

_ Other Tests _

-1
unit
9499
hbase-server in the patch failed.

+1
asflicense
31
The patch does not generate ASF License warnings.

12897

Reason
Tests

Failed junit tests
hadoop.hbase.master.assignment.TestOpenRegionProcedureHang

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/547

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 504bfe3606f5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh

git revision
master / ee5cf0d209

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/8/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/8/testReport/

Max. process+thread count
4286 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/8/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
89
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
339
master passed

+1
compile
63
master passed

+1
checkstyle
90
master passed

+1
shadedjars
297
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
40
master passed

0
spotbugs
278
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
275
master passed

_ Patch Compile Tests _

+1
mvninstall
312
the patch passed

+1
compile
57
the patch passed

+1
javac
57
the patch passed

+1
checkstyle
80
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
288
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
966
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
34
the patch passed

+1
findbugs
266
the patch passed

_ Other Tests _

-1
unit
15908
hbase-server in the patch failed.

+1
asflicense
62
The patch does not generate ASF License warnings.

19556

Reason
Tests

Failed junit tests
hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController

hadoop.hbase.client.TestFromClientSideWithCoprocessor

hadoop.hbase.master.assignment.TestOpenRegionProcedureHang

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/547

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux a259b9e93339 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh

git revision
master / b642ee0418

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/9/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/9/testReport/

Max. process+thread count
4666 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/9/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
41
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
375
master passed

+1
compile
66
master passed

+1
checkstyle
92
master passed

+1
shadedjars
286
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
37
master passed

0
spotbugs
248
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
245
master passed

_ Patch Compile Tests _

+1
mvninstall
295
the patch passed

+1
compile
57
the patch passed

+1
javac
57
the patch passed

+1
checkstyle
76
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
269
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
928
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
35
the patch passed

+1
findbugs
253
the patch passed

_ Other Tests _

-1
unit
10241
hbase-server in the patch failed.

+1
asflicense
34
The patch does not generate ASF License warnings.

13704

Reason
Tests

Failed junit tests
hadoop.hbase.regionserver.TestEndToEndSplitTransaction

hadoop.hbase.master.assignment.TestOpenRegionProcedureHang

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/547

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux a32937347c8b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh

git revision
master / 97fbaa658e

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/10/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/10/testReport/

Max. process+thread count
4684 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/10/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
36
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
447
master passed

+1
compile
74
master passed

+1
checkstyle
106
master passed

+1
shadedjars
348
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
43
master passed

0
spotbugs
332
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
329
master passed

_ Patch Compile Tests _

+1
mvninstall
402
the patch passed

+1
compile
69
the patch passed

+1
javac
69
the patch passed

+1
checkstyle
110
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
370
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1233
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
43
the patch passed

+1
findbugs
296
the patch passed

_ Other Tests _

+1
unit
10197
hbase-server in the patch passed.

+1
asflicense
29
The patch does not generate ASF License warnings.

14595

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/547

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 90ac87c0f59e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh

git revision
master / 345c21dbe7

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/11/testReport/

Max. process+thread count
4295 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/11/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
73
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
433
master passed

+1
compile
59
master passed

+1
checkstyle
97
master passed

+1
shadedjars
302
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
37
master passed

0
spotbugs
286
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
283
master passed

_ Patch Compile Tests _

+1
mvninstall
330
the patch passed

+1
compile
59
the patch passed

+1
javac
59
the patch passed

+1
checkstyle
88
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
305
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1076
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
37
the patch passed

+1
findbugs
282
the patch passed

_ Other Tests _

-1
unit
17346
hbase-server in the patch failed.

+1
asflicense
24
The patch does not generate ASF License warnings.

21245

Reason
Tests

Failed junit tests
hadoop.hbase.namespace.TestNamespaceAuditor

hadoop.hbase.client.TestFromClientSide

hadoop.hbase.util.TestFromClientSide3WoUnsafe

hadoop.hbase.client.TestFromClientSideWithCoprocessor

hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController

hadoop.hbase.master.TestSplitWALManager

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/12/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/547

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 30cf7b2cdd62 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh

git revision
master / a5ef6b287c

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/12/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/12/testReport/

Max. process+thread count
4863 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/12/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
77
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
363
master passed

+1
compile
66
master passed

+1
checkstyle
96
master passed

+1
shadedjars
392
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
58
master passed

0
spotbugs
347
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
343
master passed

_ Patch Compile Tests _

+1
mvninstall
444
the patch passed

+1
compile
60
the patch passed

+1
javac
60
the patch passed

+1
checkstyle
90
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
303
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1121
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
43
the patch passed

+1
findbugs
295
the patch passed

_ Other Tests _

-1
unit
16428
hbase-server in the patch failed.

+1
asflicense
27
The patch does not generate ASF License warnings.

20697

Reason
Tests

Failed junit tests
hadoop.hbase.namespace.TestNamespaceAuditor

hadoop.hbase.client.TestFromClientSide

hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush

hadoop.hbase.client.TestFromClientSideWithCoprocessor

hadoop.hbase.master.TestSplitWALManager

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/13/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/547

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 08aa7cec5e77 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-547/out/precommit/personality/provided.sh

git revision
master / 8e8bd8b254

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/13/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/13/testReport/

Max. process+thread count
4777 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-547/13/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Merged to Master.


navigator fails to find modules in lib/perl5/x86_64-linux/

I have the Mouse.pm and Imager.pm modules installed via local::lib which installs in local_lib/lib/perl5/x86_64-linux/
The navigator reports any modules in x86_64-linux as unknown and needing to be installed.
Configuration is:
    "perlnavigator.perlPath": "/opt/perlbrew/perls/perl-5.34.0/bin/perl",
    "perlnavigator.includePaths": [
        "$workspaceFolder/local_lib",
        "$workspaceFolder/code",
    ],
    "perlnavigator.perltidyProfile": "/home/dev/.perltidyrc",
    "perlnavigator.perlcriticEnabled": false,
    "perlnavigator.includeLib": false,
    "perlnavigator.enableWarnings": false,

Using a wrapper for Perl as follows and perltidy now works but there is no navigation support - no definitions:
#!/bin/bash

# FindBin for bash!
readonly Bin=$(cd -- "$(dirname "$0")" && pwd)

/opt/perlbrew/perls/perl-5.34.0/bin/perl -Mlocal::lib=${Bin}/../local_lib $@

"perlnavigator.perlPath": "/home/dev/work/util/perl_run"

language server log shows:
Starting perl compilation check with the equivalent of: /home/dev/work/util/perl_run -c -Mwarnings -M-warnings=redefine -I /home/dev/work/code -I /home/dev/work/treeplan/perl -I /home/dev/.vscode-server/extensions/bscan.perlnavigator-0.5.5/server/src/perl -MInquisitor /home/dev/work/code/DMS/SiteUtils.pm
Compilation Time: 0.031 seconds
[Trace - 4:05:54 PM] Received notification 'textDocument/publishDiagnostics'.
Params: {
    "uri": "file:///home/dev/work/code/DMS/SiteUtils.pm",
    "diagnostics": []
}

[Trace - 4:05:54 PM] Received notification 'textDocument/publishDiagnostics'.
Params: {
    "uri": "file:///home/dev/work/code/DMS/SiteUtils.pm",
    "diagnostics": []
}

Hi @Deracination, perhaps you can try adding the full path of the perl modules to your includePaths? Something like:
"perlnavigator.includePaths": [
        "/home/Deracination/local_lib/lib/perl5/x86_64-linux/",

In any case, you can usually get more info by manually running the "equivalent of" command shown. The navigator runs something slightly different because it needs to pass the code over stdin (since the file modifications may not be saved yet), but it's close enough. Including  -MInquisitor causes it to dump symbols from the symbol table that are used for navigation purposes. You could leave that argument out if just checking to see if modules are found and the code compiles.
/home/dev/work/util/perl_run -c -Mwarnings -M-warnings=redefine -I /home/dev/work/code -I /home/dev/work/treeplan/perl -I /home/dev/.vscode-server/extensions/bscan.perlnavigator-0.5.5/server/src/perl -MInquisitor /home/dev/work/code/DMS/SiteUtils.pm

If none of this works, you may need https://github.com/bscan/PerlNavigator/pull/68, which allows passing arguments to the perl executable. I think many people want that feature for docker, local::lib, WSL, Carton, etc.  I just need to finish reviewing it and then push a new release.

Thanks, I'll watch for the new release


[Design] API Proposal 20201231-preview

This is proposed API changes for the next API release.
Stories still need to be created and flushed once we agree on API structural changes.

@mjudeikis we need to add FIPS as an additional feature in this API

@mjudeikis we need to add FIPS as an additional feature in this API

FIPS... Good old 2001... :D Will add...

I am basically fine with this doc, but in general I feel like we should standardise on storing architecture docs in the team sharepoint (same place as the egress/dbtoken docs)

I am basically fine with this doc, but in general I feel like we should standardise on storing architecture docs in the team sharepoint (same place as the egress/dbtoken docs)

My challenge with other location is transparency. Or to lack of it. And the fact that depending on who you are you see different folders and structure. If mojo is our place to "get lost", sharepoint is MSFT..

sharepoint path is Documents > General > Current design docs > ARO API Design 20201231.docx , closing this


Can you add smoke reversed?

Not sure what you mean :-) Can you add some more explanation? You can also easily convert https://shadertoy.com/ shaders , so I would look there first if you want something specific.


Add SlashRemover plugin

This new plugin redirects requests to proper paths if they contain excessive slashes, including trailing slashes, or duplicate slashes. Both can be enabled independently from one another.
Example of a trailing slash: 'example.com///home///' -> 'example.com///home'
Duplicate slash: 'example.com///home///' -> 'example.com/home/'
Both: 'example.com///home///' -> 'example.com/home'

The license information on lib/inc/drogon/plugins/SlashRemover.h should be checked.

@Mis1eader-dev Thanks so much for your patch, I've merged the PR #1606, please rebase this branch on the master.

I think it's better to add an option to control the behaviors after removing slashes, that is to return a redirect response or forward the request internally.

@an-tao That's a good idea.
Can you elaborate on internal forwarding?

I believe you mean something like this?
if(redirect_)callback(HttpResponse::newRedirectionResponse(redirectedPath));
else app().forward(req, std::move(callback), redirectedPath);

Does drogon::HttpAppFramework::forward take absolute urls without the host part?

It seems drogon::HttpResponse has a setter method for path, it may be possible to do:
req->setPath(redirectedPath);
app().forward(req, std::move(callback));

The reason for having too many repetitive functions is runtime speed, to avoid if(redirect_), if(trailingSlashes_), if(duplicateSlashes_) checks every time. They are constant.

@Mis1eader-dev

The reason for having too many repetitive functions is runtime speed, to avoid if(redirect_), if(trailingSlashes_), if(duplicateSlashes_) checks every time. They are constant.

Do you mean by constant, those parameters are NOT determined at runtime, unlike user inputs or config files? I do not know how Json::Value are parsed, possibly compilers can optimize this unless those are not runtime params?
https://godbolt.org/z/4j98TWdYP

@Mis1eader-dev

The reason for having too many repetitive functions is runtime speed, to avoid if(redirect_), if(trailingSlashes_), if(duplicateSlashes_) checks every time. They are constant.

Do you mean by constant, those parameters are NOT determined at runtime, unlike user inputs or config files? I do not know how Json::Value are parsed, possibly compilers can optimize this unless those are not runtime params?
https://godbolt.org/z/4j98TWdYP

They are determined at runtime, but they don't have setters, and won't change through the life cycle of the plugin.
We could say it will not be an issue as the branch predictor sees after many invocations it is always true, or always false.
I will make it non-repetitive once I get home. Since the redirect_ is checked inside the function always anyway.

Function pointer: b04aebb
If and switch: a5a087e
@an-tao @ken-matsui Either one can be merged, I suggest going with if and switch.

I prefer the second implementation, it's more intuitive and the difference in performance is negligible considering the logic is simple

I'd second what @an-tao said.


MNIST-Keras cannot be deployed properly

I want to run the example of mnist-keras, However, the following error occurs when running Node 1. Here's how I did it.
Firstly, I use the swarm-learning/bin/run-apls script to start the License Server, and visit https://<IP_ADDRESS>:5814/autopass/login_input to install licenses.

Next, I run init-workspace script, and it’s working fine. I also try running a 'docker ps | grep swarm' and ensure all the swarm learning containers are running.

I'm new to the field. Can I get some advice and help to solve this ,thanks. @dgstangel @peholland

Did you close the tab in which you run the APLS command?
Looks like the license server is not running.
Can you provide some more details?

Yes, it seems APLS not running.

I would like to ask whether the tab in which I run the APLS command refers to the url https://<IP_ADDRESS>:5814/autopass/login_input ? I didn't close this web page or any of the other terminals.
Maybe there are some problems in my web，however i find something weird, after I install the license file, the License Usage page does not show these two licenses.Is this normal?

In addition,For the environment variable APLS - IP, which IP should i use, <IP_ADDRESS> (https://<IP_ADDRESS>:5814/autopass/login_input) or <IP_ADDRESS> (https://<IP_ADDRESS>:5814Autopass/login_input)?
All the swarm learning containers are running as the figure bellow.

Last ,How can I confirm that APLS is running

From above screen, APLS is running. Use complete IP to point APLS (no local host or 127...) .
Your License Management console screen shows you have installed license properly.
Lets restart setup.
Follow delete work space command.
Start again -
Make sure APLS still running, License server shows License as installed. If not start APLS and install license. License Usage page refreshes only when Licenses are being used, in your attempt so far licenses are not used so it didn't show up.
Run init-workspace, then run-sl command on both the nodes.

i don't understand what exactly complete IP means, so I run the ifconfig command, could you tell me which one is correct, thanks for your timely reply

thank you, maybe i fix it


[Key Vault Keys] Local Cryptography Client

This PR adds a Local Cryptography Client to the KeyVault-Keys package. This client is created with a JWK and provides the very minimal set of local cryptography operations we currently support. The existing CryptographyClient now uses this new LocalCryptographyClient without having to change its API.
The LocalCryptographyClient has been designed to make it easier to add new cryptography operations.
Feedback is welcome.
Fixes #7278

Alright, I'll remove this for now. Please send me any further request directly, or through issues, and I'll make a new PRs ASAP.


Decide whether unused AEB bits must be zero

The argument encoding bitmap requires (as of its current definition) 2 bits per non-required parameter. For macro signatures with numbers of non-required parameters not a multiple of 4, this leaves some unused bits in the argument encoding bitmap byte(s).
Should implementation(s) require these unused bits to be zero, or simply ignore them? Currently ion-java ignores them. The spec should probably take a stance here as well.
The following data illustrates this:
  0x01, // Macro invocation 1 ($ion::values, when system macros are in scope)
  0xF0  // The argument encoding bitmap, with the lowest 2 bits (`00`) required by the single zero-to-many parameter

If unused bits are ignored, this is valid and expands to nothing (i.e., (:values)). If unused bits must be zero, then this must raise an error.

Hello, we tried to solve the issue.
This is what we did:
Modified the IonRawBinaryWriter class to ignore unused bits in the argument encoding bitmap for macro invocations. This change allows for more flexible handling of macro signatures with numbers of non-required parameters not a multiple of 4.
You can review changes in this commit: https://github.com/wwqwq2313/amazon-ion-ion-java-1020/commit/e745c0d1a2d1b4d7746dd69b04dac9caf0d965b2.

[!CAUTION]
Disclaimer: The concept of solution was created by AI and you should never copy paste this code before you check the correctness of generated code. Solution might not be complete, you should use this code as an inspiration only.

If you no longer want Latta AI to attempt solving issues on your repository, you can block this account.


let your $PATH do all the work

Make the out of the box config work if you have ipmitool in another place in your path.
@Primer42 @schallert @defect @roymarantz

LGTM. Unless we think there's other changes we want to pull in we can probably bump the version here as well, or we can do that on our end before we publish.

LGTM - yeah it would be nice if you bumped the version.

I'm not a big fan of this.  The default is a pretty standard place for ipmitool and if you want something special, you can, and IMO, should hack the config.  I don't feel that strongly about it, so if I'm in the minority that ignore my dislike.  In general I prefer having the path specified so "everyone" gets the same value.

@Primer42 i wanted the upstream maintainers to make the decision about when to release a new version :)
@roymarantz i would rather not make assumptions about where a tool is located. For example, installing ipmitool via brew in OS X places it in /usr/local/bin/ipmitool. The $PATH is there exactly to provide this looseness

@byxorna while that is true, my preference is for the config to be the source of truth about rather than my personal environment.  I've found that my environment often differers from other people's and even each project needs a different environment.  We are not likely to convince each other to change our minds, so we can continue to differ :-)  As I said, I don't have an issue if this is merged or not.

@roymarantz you can still override in the config. This change only makes the default executable sans path. You are still free to set in the config whatever path to a binary you would like.

@Primer42 bump


Hash initialization with ? : condition generates bad code

Hash initialization with ? : condition generates bad code.  For example:
%entity2char = (
 # Some normal chars that have special meaning in SGML context
 amp  => '&',     # ampersand
 'gt' => '>',     # greater than
     # PUBLIC ISO 8879-1986//ENTITIES Added Latin 1//EN//HTML
 AElig	=> chr(198),  # capital AE diphthong (ligature)
 Aacute	=> chr(193),  # capital A, acute accent
 'emsp;' => chr(8195), # always include this key-value pair
 # Add some more to modern perls only
 ( $] > 5.007 ? (
  'OElig;'    => chr(338),  # comment OElig
  'diams;'    => chr(9830), # comment diams;
  ) : ())
);

Fixed in v1.021


Error while reading bundle file

Describe the bug
Error while reading bundle file
Screenshots

Version
For example v1.36.00+latest version.
Game/Sample
Assetbundle files.zip
Game folder

send userassembly/gameassembly.dll global-metadata.dat unityplayer.dll from game folder
or just way to download client

send userassembly/gameassembly.dll global-metadata.dat unityplayer.dll from game folder or libil2cpp.so/libunity.so if thats android or just way to download client

Thank you for the reminder. I have re uploaded the game files

hm it seems encrypted try asking in unitypy discord


Issue / Logo and Readme

Create logo for the product and an initial readme file.
Tasks

[x] prepare logo assets: > do_
[x] place logo in docs site
[x] prepare logo-mark to be used in nuget
[x] readme with logo and intention of the product

Additional Tasks

[x] update prebuild

Wrong name, reopened :point_right: #8