Adds integration workflow to CicleCI config

We should first ensure that #1246 is resolved before this is merged otherwise things might not work properly.
Closes #1216

@andrevmatos since this doesn't directly block our PRs being a nightly, I would argue that it is better to enabled it to see how it goes.


Making it easier to understand dependency review for public versus private repos

Why:
Making it easier to understand where Dependency Review is available. This has caused some confusion. Hopefully, the proposed changes make it easier to understand but I welcome feedback 👍

What's being changed:

Check off the following:

[x] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[ ] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@NickLiffen
Thanks so much for opening a PR! I'll get this triaged for review :zap:

Thanks, @ramyaparimi 💯 I also welcome someone better at grammar than me to propose changes
For example, another way of maybe phrasing this is:
Dependency review is available for all public repositories, as well as private repositories owned by organizations where ...

I very much welcome feedback on the proposed changes 👍

@NickLiffen - thank you for highlighting that this sentence was confusing. I hadn't realized until you mentioned it.
Will apply the suggestion and merge this PR.
Thanks again 💖


Help needed with ApplyFilters in grid.

base.ApplyFilters(query);
{
var user = (UserDefinition)Serenity.Authorization.UserDefinition;
query.Where((fld.OwnerId == user.UserId) | (fld.AssignedId == user.UserId));
}
in above code, i was ok when the records are seen only where OwnerId or AssignedId is equal to logged in User's Id
Now I have UpperLevel Column in Users Table, now in Apply Filters, I want to allow user.UserId to see records wherever user.UserId is set as UpperLevel in Users
Waiting for valuable suggestions(hoping I have written clearly to understand my concern :-) )

protected override void ApplyFilters(SqlQuery query)
{
base.ApplyFilters(query);
           var user = (UserDefinition)Serenity.Authorization.UserDefinition;

           var data = new UsersList();

           using (var connection = SqlConnections.NewFor<UserRow>())
           {
               var od = UserRow.Fields;
               data.Users = connection.List<UserRow>(q => q
                   .SelectTableFields()
                   .Select(od.UserId)
                   .Where(od.UpperLevel == user.UserId));
           }

           query.Where((fld.OwnerId == user.UserId) | (fld.AssignedId == user.UserId));

           foreach (var item in data.Users)
           {
               //Here i want to add another criteria to query.where, please help me out with it, following overwrites the previous criteria
               //query.Where((fld.OwnerId == item.UserId.Value) | (fld.AssignedId == item.UserId.Value));
           }
       }


Interstitial ad fails to show in Flutter modules. "The provided view controller is already presenting another view controller." [iOS]

Plugin Version
2.3.0
Steps to Reproduce

Run flutter create bug -t module.
Update the files as follows: Show an Interstitial ad
Create a host app: https://docs.flutter.dev/development/add-to-app/ios/project-setup
Add a flutter screen: https://docs.flutter.dev/development/add-to-app/ios/add-flutter-screen?tab=initial-route-without-pre-warming-objective-c-tab
Open the flutter screen and then open the interstitial ad in flutter

Expected results: The Interstitial ad is shown in fullscreen.
Actual results: The view fails to show. Error message: "The provided view controller is already presenting another view controller."
The view controller used to present to interstitial ad view is not the "Flutter view controller" when flutter is running in a host app.
The viewcontroller used is the rootviewcontroller of the host app, i.e the main view of the host app.
https://github.com/googleads/googleads-mobile-flutter/blob/main/packages/google_mobile_ads/ios/Classes/FLTGoogleMobileAdsPlugin.m#L196
Possible solution:
Is there any reason not to use the view controller that is on top of the stack? When a host app opens flutter it's convenient to keep the rootviewcontroller as the main native/host VC so it is easy to navigate back to the host app from flutter.

Logs
FullScreenContentCallback.onAdFailedToShowFullScreenContent: "The provided view controller is already presenting another view controller."
flutter doctor -v:
[✓] Flutter (Channel stable, 3.3.8, on macOS 12.6 21G115 darwin-x64, locale en-SE)
• Flutter version 3.3.8 on channel stable at /Users/rickard/Dev/flutter/sdk
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 52b3dc25f6 (7 days ago), 2022-11-09 12:09:26 +0800
• Engine revision 857bd6b74c
• Dart version 2.18.4
• DevTools version 2.15.0
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
• Android SDK at /Users/rickard/Dev/Android/sdk
• Platform android-31, build-tools 31.0.0
• ANDROID_HOME = /Users/rickard/Dev/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 14B47b
• CocoaPods version 1.11.3
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2021.2)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
[✓] VS Code (version 1.73.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.52.0
[✓] Connected device (2 available)
• macOS (desktop)        • macos                                • darwin-x64     • macOS 12.6 21G115 darwin-x64
• Chrome (web)           • chrome                               • web-javascript • Google Chrome 107.0.5304.110
[✓] HTTP Host Availability
• All required HTTP hosts are available
• No issues found!

Hi @rckrd-proguitar
Please provide a completed and minimal reproducible code sample so that we may verify this. In this case, the issue relates to native side, it will be better if you can push the sample code into a Github repository and make it public.
Also, please provide the output of flutter doctor -v as well. Thank you!

Here you go @huycozy : https://github.com/rckrd-proguitar/googleads-mobile-flutter-issue-700
The example generates this log when the interstitial ad is opened:
flutter: Instance of 'InterstitialAd' onAdFailedToShowFullScreenContent: AdError(code: 17, domain: com.google.admob, message: The provided view controller is already presenting another view controller.)
You find the output of flutter doctor -v under "Logs" above.

If there is no other workaround or error on my part, the following could maybe be a solution to find the view controller on top.
- (UIViewController *)rootController {   UIViewController *rootViewController = UIApplication.sharedApplication.delegate.window.rootViewController;   if(rootViewController.presentedViewController != nil){     return rootViewController.presentedViewController;   }   return rootViewController; }

@rckrd-proguitar Sorry for replying late. I can reproduce this issue with provided sample code at https://github.com/googleads/googleads-mobile-flutter/issues/700#issuecomment-1317200825.
Labeling this issue for further investigation from the team. Thanks!

Demo video
https://user-images.githubusercontent.com/104349824/202974292-d5319d4f-7559-4964-bb62-d309a4f4d3f1.mov

Log
2022-11-21 12:41:47.641029+0700 googleads-mobile-issue-700[36290:1158896] flutter: Instance of 'InterstitialAd' onAdFailedToShowFullScreenContent: AdError(code: 17, domain: com.google.admob, message: The provided view controller is already presenting another view controller.)

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.3.8, on macOS 13.0 22A380 darwin-x64, locale en-VN)
    • Flutter version 3.3.8 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 52b3dc25f6 (23 hours ago), 2022-11-09 12:09:26 +0800
    • Engine revision 857bd6b74c
    • Dart version 2.18.4
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] IntelliJ IDEA Community Edition (version 2022.2.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 70.0.5
    • Dart plugin version 222.4167.21

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.73.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.52.0

[✓] Connected device (3 available)
    • iPhone 14 Pro Max (mobile) • 332079AF-E895-4685-910E-7B1E18B0C6B8 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-0 (simulator)
    • macOS (desktop)            • macos                                • darwin-x64     • macOS 13.0 22A380 darwin-x64
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 107.0.5304.110

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[!] Flutter (Channel master, 3.6.0-6.0.pre.29, on macOS 13.0 22A380 darwin-x64, locale en-VN)
    • Flutter version 3.6.0-6.0.pre.29 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ee9bc784b5 (2 hours ago), 2022-11-20 19:32:24 -0500
    • Engine revision 271461837e
    • Dart version 2.19.0 (build 2.19.0-406.0.dev)
    • DevTools version 2.19.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] IntelliJ IDEA Community Edition (version 2022.2.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 70.0.5
    • Dart plugin version 222.4167.21

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.73.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.52.0

[✓] Connected device (3 available)
    • SM T225 (mobile) • R9JT3004VRJ • android-arm64  • Android 12 (API 31)
    • macOS (desktop)  • macos       • darwin-x64     • macOS 13.0 22A380 darwin-x64
    • Chrome (web)     • chrome      • web-javascript • Google Chrome 107.0.5304.110

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

I am facing this issue in version 3.1.0
Instance of 'InterstitialAd' onAdFailedToShowFullScreenContent1: AdError(code: 17, domain: com.google.admob, message: The provided view controller is not being presented.)
Anyone Resolve this?

Hello
I am receiving the same error in version 3.1.0 (I cannot downgrade due to compatibility issues).
In my case the first interstitial displays fine, however the 2nd one fails. Then the 3rd works fine, then the 4th fails, and so on.

I also have this issue.
It doesn't seem to be solved.

Check if you are accidentally disposing the ad at a wrong place.
The best practice for when to call dispose() is in the FullScreenContentCallback.onAdDismissedFullScreenContent and FullScreenContentCallback.onAdFailedToShowFullScreenContent callbacks.

That is exactly when I do that and it still does not work.
Only when I downgrade...

I am still getting "The provided view controller is not being presented." as described in previous post.. please is there any solution for this ? It only works as expected at version 2.4.0 .. but at this version CMP is not implemented, which we need in our app. Please let us know as soon as problem is solved.

Same here, the problem is definetly not solved.

Same here, multiple occurrences!!

This happens the first time I show the ad. But I moved the code to an external file, and that's when it all started happening.

Mark,same question in newest sdk version 5.1.0, anyone has some way to fix it?

I have re-opened the case and have shared with engineering to take another look

This has been resolved with #1153 and will be included in the next google_mobile_ads plugin release


fix(manager): update VoiceState payload

Changes:

Added missing fields to VoiceState payload.
Added description for each field in VoiceState and VoiceServerUpdate payloads.
Fixed some fields' types

Why add descriptions for each field of the Voice State/Server updates?

Why add descriptions for each field of the Voice State/Server updates? Very unnecessary imo

It provides a concise description of what the fields are actually for to new maintainers... this is not for the users, but for the maintainers


[5.2] Proposal for using mysql json fields with query builder

With mysql 5.7 introducing a json field type we can currently do the following:
User::selectRaw('name->"$.en"')
    ->whereRaw('contacts->"$.phone.home" = 123')
    ->orWhere(DB::raw('contacts->"$.phone.mobile"'), 123)
    ->get();

This PR is a suggestion that'll allow us to use the fluent query builder with this type of fields:
User::select('name->en')
    ->where('contacts->phone->home', 123)
    ->orWhere('contacts->phone->mobile', 123)
    ->whereBetween('specs->height', [100, 120])
    ->orderBy('specs->weight')
    ->get();

Can we do this for Postgres as well?
http://www.postgresql.org/docs/9.3/static/functions-json.html
http://clarkdave.net/2013/06/what-can-you-do-with-postgresql-and-json/

@djtarazona seems like a good idea.

Can we do this for Postgres as well?

:+1:


column headers obscure unread information after page down

I'm using phanpy with the multiple columns feature enabled. At the top of the column there is a header. Sometimes, a post will be partially visible at the bottom of the screen. I press page down to view the rest. But that moves the rest of the post to be underneath the header, so I cannot read it.
See attached screenshot demonstrating the problem. I highlighted the affected post with a red outline.

Desktop (please complete the following information):

OS: linux
Browser firefox
Version 120

The "Tab/Menu bar" view for Shortcuts also has the problem though less so since the tabs take up less space. Phanpy's default header interface thingy auto-hides, which avoids the problem when not using the Shortcuts feature.


Textfield set validity

I do not seem to be able to set the validity of a textfield programatically or trough props
given the following input
<TextField label="Street Address" id="street_name" helperTextValidationMsg="Invalid" valid="false" required/>
Checked the issues before and this one https://github.com/prateekbh/preact-material-components/issues/332 lead to a merge in which the valid prop could be set to a textfield, i am using the latest version 1.3.5 and it is not working nor i see any method in the textfield input element to trigger/set it.
Any hint on how this can be done?

Ok it seems that validity={false} and not validity="false" works but isn't there any method that we can call on the input element that triggers it ?

You'd probably want to store a valid variable in your app state somewhere and set its value via an onChange handler on the TextArea component

import { h, Component } from "preact";

export default class TextArea extends Component {
  constructor() {
    this.state = {
      valid: true;
    }
  }

  validateTextField(e) {
    // validate your text content (e.target.value)
    // if necessary, toggle valid state
    this.setState(prevState => {
      this.setState({
        valid: !prevState.valid
      });
    });
  }

  render() {
    <TextArea
      valid={this.state.valid}
      onChange={this.validateTextField.bind(undefined, e)}
    />
  }
}

Humm, ok but that means onde need to have app states for each textfield used right ?
Also when using helperTextValidationMsg it does not seem to show when the field goes invalid

Only if you wish to control validation. You could always store this state in a parent component and pass it down via props.
We'll definitely need to look at the helperTextValidationMsg issue

<TextField ref={txtField=>{this.txtField = txtField}} label="Street Address" id="street_name" helperTextValidationMsg="Invalid" valid="false" required/>
this.ref.txtField.MDComponent.valid = false

Thank to you both, i will figure out a way to manage with the ref attribute, but the 'helperTextValidationMsg' not appearing is a known issue of the current version right ?

yep will check

its mostly adding a condition here:
https://github.com/prateekbh/preact-material-components/blob/master/TextField/TextField.jsx#L166

@7Ds7 try this
            helperText="helper text validation message"
            helperTextValidationMsg
            required
          />```

Yes that seems to work, thank you @prateekbh

With the last markup format everything works, also without the ref attribute works by setting the input parent mdc-text-field like so
input.closest('.mdc-text-field').classList.add('mdc-text-field--invalid');
I understand that this might not change Input component state, but it might be helpful to leave here if someone was just interested in the display functionality of the component, as i was

a manual call to classList.add might get overridden by preact's diffing algo


Radio-specific hint copy masks the error message

With a component which has hints for individual radio inputs associated via aria-describedby (see https://design-system.service.gov.uk/components/radios/#radio-items-with-hints), this masks an error tied to the fieldset via aria-describedby in Voiceover Mac.
The error message does not get announced when the hint aria is referenced from the inputs directly.
When moving direct to the input, the hint is read out but the error message is not.
Works as expected on NVDA and JAWS
Possible solution: Add error message id to the aria-describedby of the radio inputs alongside the hint id.

Seems to be working in Voiceover now.


Fix binning param acquisition bug

It is currently impossible to set binning to zero using launch file params

Binning of 1 gives the full image from the sensor.  What does binning of 0 do?

I don't know - my mistake!


fix: add missing show_historic_incidents to component bulk edit form

Closes #472

Hello,
I am on v2.1.1 and your fix do not seems to be applied/there.
Merge did not work ?

I've merged this PR after v2.1.1 was released, that is why this fix isn't available yet.


ScalaMock doesn't properly override all class members

ScalaMock doesn't seem to properly override all members of a class. In the example below, no test should pass (no expectations were set), yet the first two pass:
import org.scalamock.scalatest.MockFactory
import org.scalatest.FreeSpec

class TestSpec extends FreeSpec with MockFactory {
  "toString" in {
    val test = stub[Test]
    assert(test.toString === "test")
  }

  "hi" in {
    val test = stub[Test]
    assert(test.hi === "test")
  }

  "hello" in {
    val test = stub[Test]
    assert(test.hello === "test")
  }
}

class Test {
  override def toString = "test"
  val hi = "test"
  def hello = "test"
}

$ sbt test
[info] TestSpec:
[info] - toString
[info] - hi
[info] - hello *** FAILED ***
[info]   null did not equal "test" (CrazyTest.scala:17)
[info] Run completed in 191 milliseconds.
[info] Total number of tests run: 3
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 2, failed 1, canceled 0, ignored 0, pending 0
[info] *** 1 TEST FAILED ***

You cannot mock inherited methods from java.lang.Object. It would be nice to narrow it only to finals but by now you can't and toString has it's proxy in mock/stub.
You cannot mock vals and lazy vals. I think that it is caused by it's complex nature.
null in last test case is good because you need to stub this method.

So for me everything is good except that maybe some information is missing on the website.

also see discussion on #148 on val


Allow rich configuration and editing of simOption properties

Originally captured in #10

[ ] An optionsConfigValidator that checks for legal shapes
[ ] Merge a top-level options object for simulator into simConfig and render it
[ ] A 'setPropertyInObject' util function that takes a dotted property name list and sets that property (there's one in card-web I think?)
[ ] Start rendering out number control
[ ] Start rendering out boolean control
[ ] Start rendering out string control
[ ] Start rendering out object control (which will allow simOptions)
[ ] Start rendering out array controls
[ ] Render description help hovers
[ ] Support advanced flag


Fix for upserts, question pages (WIP), history

So this is a mix of several changes, some are unfinished:

question pages (still unfinished)
history api in graphql (mostly working)
fix for upserts which I lazily implemented in the same branch (maybe I should've built it on top of master instead, but I disabled the links to question pages for now, so it should be ok)

Fix for upserts - kinda urgent
I was working on adding foreign keys from history to questions table when I discovered that fetchers were broken in prod due to the unfortunate combination of: (1) frontpage table is now implemented with foreign keys to questions table now; (2) fetched questions are inserted with delete+recreate trick.
But foreign keys forbid the questions from being deleted, so deletes failed, and cron job skipped the platform entirely if it had any questions on the frontpage. At least that's what I assume have happened, I haven't checked the full logs.
defaultdb=> select date(timestamp) as d, count(1) from questions group by d order by d desc limit 5;
     d      | count
------------+-------
 2022-04-27 |  1805
 2022-04-25 |   191
 2022-04-23 |   110
 2022-04-22 |  2189
 2022-03-30 |   168
(5 rows)

What's worse is that there's no easy to fix this while keeping the same performance. The only fix I could come up with quickly negates the benefits of #30: in this PR I just delete the questions which don't exist any more, create the new ones and update the ones which existed. But there's no bulk update API in Prisma (or in SQL, actually), so all updates are done in separate SQL queries. Or, to be more precise, in 5 queries per question:
prisma:query BEGIN
prisma:query SELECT "public"."questions"."id" FROM "public"."questions" WHERE "public"."questions"."id" = $1
prisma:query UPDATE "public"."questions" SET "extra" = $1, "timestamp" = $2, "title" = $3, "url" = $4, "platform" = $5, "description" = $6, "options" = $7, "qualityindicators" = $8, "id" = $9 WHERE "public"."questions"."id" IN ($10)
prisma:query SELECT "public"."questions"."id", "public"."questions"."title", "public"."questions"."url", "public"."questions"."platform", "public"."questions"."description", "public"."questions"."options", "public"."questions"."timestamp", "public"."questions"."qualityindicators", "public"."questions"."extra" FROM "public"."questions" WHERE "public"."questions"."id" = $1 LIMIT $2 OFFSET $3
prisma:query COMMIT

It shouldn't be that bad, though, since our DB is now geographically close to Heroku's instance. And this can be optimized further:

by doing deep comparison and updating only the questions which have actually updated
or we could insert questions into a temporary table and then do UPDATE ... FROM ... (but this is impossible with Prisma, so we'll have to drop back to the raw SQL...)

On other stuff in this PR:

question pages are on /questions/[id]; there's an icon linking to them in DisplayQuestion, but I disabled it for now
also, only the question title links to the original url now (is this ok?)
history API is mostly working, but I haven't used it on the frontend yet

Ok, I'll just merge it.
@NunoSempere, let me know if you're not ok with this:

only the question title links to the original url now

(instead of an entire question card)

Hey, this looks good to me


[Bug] (preset-create-react-app) Incompatible babel-loader versions

Describe the bug
When creating a fresh react app using the typescript template and then initializing the storybook, the cra preflight check complains about babel-loader not being present in the desired version.
Steps to reproduce the behavior
create-react-app proof --template typescript \
  && cd proof \
  && npx sb init \
  && yarn start

Expected behavior
I'd expect a bare-bones setup of cra to work.
Screenshots and/or logs
$ yarn start
yarn run v1.22.10
$ react-scripts start

There might be a problem with the project dependency tree.
It is likely not a bug in Create React App, but something you need to fix locally.

The react-scripts package provided by Create React App requires a dependency:

  "babel-loader": "8.1.0"

Don't try to install it manually: your package manager does it automatically.
However, a different version of babel-loader was detected higher up in the tree:

  /path/to/proof/node_modules/babel-loader (version: 8.2.2)

Manually installing incompatible versions is known to cause hard-to-debug issues.

If you would prefer to ignore this check, add SKIP_PREFLIGHT_CHECK=true to an .env file in your project.
That will permanently disable this message but you might encounter other issues.

To fix the dependency tree, try following the steps below in the exact order:

  1. Delete package-lock.json (not package.json!) and/or yarn.lock in your project folder.
  2. Delete node_modules in your project folder.
  3. Remove "babel-loader" from dependencies and/or devDependencies in the package.json file in your project folder.
  4. Run npm install or yarn, depending on the package manager you use.

In most cases, this should be enough to fix the problem.
If this has not helped, there are a few other things you can try:

  5. If you used npm, install yarn (http://yarnpkg.com/) and repeat the above steps with it instead.
     This may help because npm has known issues with package hoisting which may get resolved in future versions.

  6. Check if /path/to/proof/node_modules/babel-loader is outside your project directory.
     For example, you might have accidentally installed something in your home folder.

  7. Try running npm ls babel-loader in your project folder.
     This will tell you which other package (apart from the expected react-scripts) installed babel-loader.

If nothing else helps, add SKIP_PREFLIGHT_CHECK=true to an .env file in your project.
That would permanently disable this preflight check in case you want to proceed anyway.

P.S. We know this message is long but please read the steps above :-) We hope you find them helpful!

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Environment

OS: Ubuntu 16.04.7 LTS
Node.js version: v14.17.2
NPM version: y7.19.1
Yarn version: 1.22.10

Btw. my create-react-app version is 4.0.3


Add Architecture graphic from DS readme to BE readme

Description
Adds the architecture graphic from the Data Science readme to this repo. Provides a valuable, visual description of the interactions between Oka, Heroku, AWS, Postgres, and more.

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have removed unnecessary comments/console logs from my code
[ ] I have made corresponding changes to the documentation if necessary (optional)
[x] My changes generate no new warnings
[x] I have checked my code and corrected any misspellings
[x] No duplicate code left within changed files
[x] Size of pull request kept to a minimum
[x] Pull request description clearly describes changes made & motivations for said changes

The diagram is clean, well organized, and easy to read. Great visual descriptions between the connections.


notifications

can i move the notifications cuz its over the minimap

i hav the same prblem

Its default Gta5 notification if u want to move the notifications use a different notification script


Easy way of adding new exchanges

There should be an easy way for other developers to implement new exchanges and include them into the repo.

how can i add bcc(bhc)?

@zzks I think Bitcoin Cash is already there (on Kraken)


Adjust formatting errors

Proposed changes
While browsing the docs I found some formatting errors, like two whitespace symbols in a row, missing whitespace etc.

Thanks @simeg !


Add AnimatedScoreboard support

Add ability to restore AnimatedScoreboard scoreboard

This literally makes no sense. We should avoid adding different plugins that occur more than once. Looking at this PR, you shouldn’t add ASB as a resource to the plugin, as there are also 8 different scoreboard plugins that require even more code.
This should be addressed in a different way. Currently, Jobs uses reflection to avoid conflict with various similar scoreboard resources.


loss_mask is not reducing

loss_mask is not reducing after 30k iters .
i have folowed all the solutions in issues
**loss_mask: 0.0535 (0.0562) **

loss_mask is not reducing after 30k iters .
i have folowed all the solutions in issues
**loss_mask: 0.0535 (0.0562) **

It seems many of us are facing the truth that the val_loss is not satisfying.


fix a typo in README

Please note that for legal reasons we require you to sign the
Contributor Agreement
before we can accept your pull requests.
Code changes and contributions in the VelocyPack library should use
the "Google" style and conventions as used by clang-format.

Coverage remained the same at 96.238% when pulling eddb6fe2e66e5de554161d069d875625bb476293 on gamtiq:patch-1 into 73d822effb383d870285628c103b622ac61ce23f on arangodb:master.


Deploy with CircleCI - less screenshots

Deploy android app via circleci. Ignoring automated screenshots for now

Deploy not working, now trying with Mobile Hub


Countries id set to -1

Check why some countries were set to -1 in export icon

probably missing in countries list, but I skipped the warning, so I should recreate the mapping

This will fix 37dadafaf5a6fa50d610d6b1d988503c5011842b .
Now every missing country in the timezone dataset is assigned to UTC.


Bug: Delegation tooltip appears underneath modal

Overview

Additional Info
No response
Version
Dev (app.dev.fractalframework.xyz/)

This issue also occurs in the user dropdown


account_assignments variable fails to be parsed

Problem
The following HCL snippet:
module "sso" {
  source = "avlcloudtechnologies/sso/aws"

  permission_sets = {
    developers = {
      description      = "Developer permissions",
      session_duration = "PT12H",
      managed_policies = [
        "arn:aws:iam::aws:policy/1",
        "arn:aws:iam::aws:policy/2",
        "arn:aws:iam::aws:policy/3",
        .................................................................
      inline_policy = data.aws_iam_policy_document.additional-dev-perms.json
    },
  }
  account_assignments = [
    {
      principal_name = "developers"
      principal_type = "GROUP"
      permission_set = "developers"
      account_ids    = ["1234567890", "2345678901"]
    },
  ]
}

Fails with the following reason specifically when running terraform import on an unrelated resource:
Error: Invalid for_each argument
│
│   on .terraform/modules/sso/main.tf line 96, in resource "aws_ssoadmin_account_assignment" "this":
│   96:   for_each = { for assignment in local.account_assignments : "${assignment.principal_name}.${assignment.permission_set.name}.${assignment.account_id}" => assignment }
│     ├────────────────
│     │ local.account_assignments is tuple with 2 elements
│
│ The "for_each" map includes keys derived from resource attributes that cannot be determined until apply, and so Terraform cannot
│ determine the full set of keys that will identify the instances of this resource.
│
│ When working with unknown values in for_each, it's better to define the map keys statically in your configuration and place
│ apply-time results only in the map values.
│
│ Alternatively, you could use the -target planning option to first apply only the resources that the for_each value depends on, and
│ then apply a second time to fully converge.

Workaround
Comment out the module, run terraform import, then uncomment the module.

Could someone apply a fix here? This also happens when you're trying to create a new iam-policy and add it to permissions set in the same TF apply run.


chore: remove superfluous imports from runLinter

Mathlib.Data.Array.Defs is currently an empty file, because its contents have been upstreamed to Std, but it had import Std in it which means that building the linter requires compiling all of Std, which is not necessary. This is especially obvious now that builds are being cached since the only part that is not cached is the compilation of the C files.

bors r+


Network switcher

There is a way to switch between LP opportunities (markets) on different networks (Mainnet and Fairground (Testnet)) in line with / reusing the pattern from console front end.

Dashboard sketch for reference https://miro.com/app/board/uXjVOs_PBKk=/?moveToWidget=3458764531971937952&cot=14
Visual styles (only) can be used from this early version of a design https://www.figma.com/file/qgCd4r61Z1r3tUkxKehhmu/Website-Design-Updates?node-id=399%3A20530

Decided not to do in the context of the website


test on macos too

@lukewilliamboswell I wanted to set up testing of the examples on macos and also ran into problems with the go example like you mentioned earlier, I tried to re-use some stuff from https://github.com/roc-lang/examples/pull/173 but I'm still encountering:
+ go build -C examples/GoPlatform/platform -buildmode=c-archive -o libhost.a
+ cp examples/GoPlatform/platform/libhost.a examples/GoPlatform/platform/macos-arm64.a
+ roc build --prebuilt-platform ./examples/GoPlatform/main.roc
Undefined symbols for architecture arm64:
  "_main", referenced from:
      <initial-undefines>
ld: symbol(s) not found for architecture arm64
./examples/GoPlatform/main: No such file or directory
thread 'main' panicked at crates/compiler/build/src/program.rs:1043:17:
not yet implemented: gracefully handle `ld` (or `zig` in the case of wasm with --optimize) returning exit code Some(1)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Can you take a look?

Looks like the tests passed because I did a bad copy-paste... I'll fix that.

Ok, now I get the Undefined symbols error:
 + roc build --prebuilt-platform ./examples/GoPlatform/main.roc
ld: Undefined symbols:
  _main, referenced from:
      <initial-undefines>
./examples/GoPlatform/main: No such file or directory
thread 'main' panicked at crates/compiler/build/src/program.rs:1043:17:
not yet implemented: gracefully handle `ld` (or `zig` in the case of wasm with --optimize) returning exit code Some(1)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Have you seen this error before @lukewilliamboswell?
+ roc build --prebuilt-platform ./examples/GoPlatform/main.roc
Undefined symbols for architecture arm64:
  "_main", referenced from:
      <initial-undefines>
ld: symbol(s) not found for architecture arm64

When I try and run the tests locally on main branch using ROC=roc EXAMPLES_DIR=examples bash ci_scripts/all_tests.sh I get the following error...
+ roc build --lib ./examples/GoPlatform/main.roc --output examples/GoPlatform/platform/libapp.so
0 errors and 0 warnings found in 129 ms
 while successfully building:

    examples/GoPlatform/platform/libapp.so
+ go build -C examples/GoPlatform/platform -buildmode=pie -o dynhost
go: errors parsing go.mod:
/Users/luke/Documents/GitHub/examples/examples/GoPlatform/platform/go.mod:3: invalid go version '1.21.5': must match format 1.23

Have you seen this error before @lukewilliamboswell?
+ roc build --prebuilt-platform ./examples/GoPlatform/main.roc
Undefined symbols for architecture arm64:
  "_main", referenced from:
      <initial-undefines>
ld: symbol(s) not found for architecture arm64

Is it because of #cgo CFLAGS: -Wno-main-return-type that the main symbol isn't included in the library?


Cannot clone into a project in a different region, code 422

When compiling a WDL file while logged into a non-default region (in this case, Sydney), I get the following error:
$ dxWDL compile  mutect2.wdl
Warning: insufficient permissions to retrive the instance price list. This will result in suboptimal machine choices, incurring higher costs when running workflows.
STDOUT:
STDERR: WARNING:dxpy:name "sortBam" should be all lowercase
Error: Cannot clone into a project in a different region, code 422. Request Time=1500350898.27, Request ID=1500350898382-175354

Build attempt 1 failed
Sleeping for 5 seconds

Currently, dxWDL works only for your default region. I haven't started working on making other regions work as well; I suspect it will not be trivial.
To get more information on the problem, please add --verbose to to the command line. I think what is happening is the following:

Files cannot be cloned from one region to another, because that would incur invisible egress charges for each access to the remote file.
There is some piece of underlying machinery that is compiled and placed in the default region, and cannot later be cloned to Sydney.

The root cause for the pricing list warning, is that dxWDL decides what platform instance to use based on the declared runtime attributes of a task. It looks for the lowest cost instance that has sufficient resources (memory, disk-space, cpu cores). This choice is inaccurate without access to the price list.
I hope that helps.

After mulling it over, I may have an idea for the root cause. I will try to fix it.

@TMiguelT, I believe release 0.34 solves this problem. Supported regions, right now, are Sydney and US-east.

Thanks for your help, it's looking closer to working. Unfortunately I still get the following output (with latest toolkit and dxWDL):
$ dxWDL compile mutect2.wdl --destination '/Workflow Evaluation/dxWDL/' --verbose --force
Warning: insufficient permissions to retrieve the instance price list. This will result in suboptimal machine choices, incurring higher costs when running workflows.
Topological sort pass
Performing default 'scatter collapsed' topological sort
Recursively performing toological sort on scatter: mutect2.$scatter_0
    mutect2.id -> mutect2.sortBam
    mutect2.sampleIDs -> mutect2.id
    mutect2.$scatter_0 -> mutect2.reads
    mutect2.$scatter_0 -> mutect2.align
    mutect2.genomeIndices -> mutect2.align
    mutect2.align -> mutect2.sortBam
    mutect2.$scatter_0 -> mutect2.indexBam
    mutect2.reads -> mutect2.align
    mutect2.$scatter_0 -> mutect2.sortBam
    mutect2.genomeReference -> mutect2.align
    mutect2.sortBam -> mutect2.indexBam
    mutect2.samples -> mutect2.reads
    mutect2.id -> mutect2.align
    mutect2.$scatter_0 -> mutect2.id
    Sorted nodes: mutect2.id, mutect2.reads, mutect2.align, mutect2.sortBam, mutect2.indexBam
End recursion
mutect2.genomeIndices -> mutect2.callVariants
mutect2.$scatter_0 -> mutect2.callVariants
mutect2.sampleIDs -> mutect2.$scatter_0
mutect2.genomeReference -> mutect2.$scatter_0
mutect2.gatk -> mutect2.callVariants
mutect2.normalSamples -> mutect2.samples
mutect2.tumourSamples -> mutect2.samples
mutect2.samples -> mutect2.$scatter_0
mutect2.genomeReference -> mutect2.callVariants
mutect2.genomeIndices -> mutect2.$scatter_0
Sorted nodes: mutect2.sampleIDs, mutect2.genomeReference, mutect2.gatk, mutect2.tumourSamples, mutect2.genomeIndices, mutect2.normalSamples, mutect2.samples, mutect2.$scatter_0, mutect2.callVariants
Wrote WDL to /tmp/dxWDL_Compile/mutect2.sorted.wdl
Preprocessing pass
simplifying scatters
simplifying workflow top level
Not moving definitions Set(sortBam, align, indexBam)
Wrote WDL to /tmp/dxWDL_Compile/mutect2.simplified.wdl
FrontEnd pass
Accessed tasks = Set(callVariants, sortBam, align, indexBam)
FrontEnd: compiling tasks into dx:applets
Compiling task align
Compiling task callVariants
Compiling task indexBam
Compiling task sortBam
FrontEnd: compiling workflow
Compiling common applet mutect2_common
compiling scatter scatter_1
Compiling evaluation applet mutect2_eval1
Wrote intermediate representation to /tmp/dxWDL_Compile/mutect2.ir.yaml
Backend pass
[Force] Removing old workflow
Compiling applet callVariants
Building applet callVariants
dx build /tmp/dxWDL_Compile/callVariants --destination project-F5fg6z05yzfVX1jJ2b5j07F5:/Workflow Evaluation/dxWDL/callVariants -f
Build attempt 1 failed
Sleeping for 5 seconds
dx build /tmp/dxWDL_Compile/callVariants --destination project-F5fg6z05yzfVX1jJ2b5j07F5:/Workflow Evaluation/dxWDL/callVariants -f
Build attempt 2 failed
Sleeping for 10 seconds
dx build /tmp/dxWDL_Compile/callVariants --destination project-F5fg6z05yzfVX1jJ2b5j07F5:/Workflow Evaluation/dxWDL/callVariants -f
Build attempt 3 failed
Sleeping for 20 seconds

If I run one of the build commands myself manually, I get:
$ dx build . --destination 'project-F5fg6z05yzfVX1jJ2b5j07F5:/Workflow Evaluation/dxWDL/callVariants' -f
WARNING:dxpy:name "callVariants" should be all lowercase
Error: No accessible project could be found containing the entity record-F5k6ZKj5BQ1k2gjX69gK0Y0z, code 401. Request Time=1500879540.6, Request ID=1500879540707-114291

The asset that this is referring to is in the dx-app.json file:
{
  "name": "callVariants",
  "runSpec": {
    "assetDepends": [{
      "id": "record-F5k6ZKj5BQ1k2gjX69gK0Y0z"
    }],
   ...
}

@TMiguelT, that's my bad, I didn't give sufficient permissions to the shared asset. I believe I fixed it now. Can you please try again?

It's now failing from dxWDL compile, but succeeding if I manually run dx build /tmp/dxWDL_Compile/callVariants --destination 'project-F5fg6z05yzfVX1jJ2b5j07F5:/Workflow Evaluation/dxWDL/callVariants' -f (with quotes).
My guess is that dxWDL is not quoting the --destination arguments? Because the command it says it's running is this, which isn't escaping spaces:
dx build /tmp/dxWDL_Compile/callVariants --destination project-F5fg6z05yzfVX1jJ2b5j07F5:/Workflow Evaluation/dxWDL/callVariants -f

My guess seems to be correct. If I run the following command (with spaces in the --destination path), it fails:
dxWDL compile mutect2.wdl --destination '/Workflow Evaluation/dxWDL/' --verbose --force

If I run the following, without spaces, it succeeds:
dxWDL compile mutect2.wdl --destination '/' --verbose --force

Good catch. This is an oversight, I didn't consider the user may include spaces in the project (or folder) path. I will fix it in the next release.

I believe release 0.35 allows white spaces in the destination folder.


8 - Betatest ICES data portal

DIG to provide beta testers for testing developments on new ICES data portal

Mehdi hasuploaded Data.ices.dk mini workshop plan
And will use Github board to collect feedback.

If you want a person that is interested in data but does not have very much data portal knowledge as a test person I can volunteer. Malin W

Many thanks, @MalinWerner. We need your expertise in data. Looking forward to seeing you in DIG and Data Portal workshop

will be in breakout session on Thursday morning 20th May

Hi @mehdiabbasi, I've been working on the user expectations for Data Criteria behaviour. My starting point was 'what do people in general expect when they select multiple data'. The 'AND' and 'OR' are technical 'AND' and 'OR', so from a programmer's perspective. Where 'AND-OR', both options should be allowed, when only one option is mentioned, this is basically the only option. Could you check if you get more or less my point: http://community.ices.dk/Committees/DIG/DIG 2021/02. Background documents/user_expectation_dataportal_20210521.xlsx

Finally, we get rid of the Beta label on https://data.ices.dk/ and it is officially released on production on 31st August 2021. Thank you for all the DIG member feedbacks. We will use the board to follow up on the issues https://github.com/ices-tools-dev/ICES_DataPortal/issues.  We will work to improve the ICES Data portal and also will start the development of an extended phase next year.


DJ012 triggers one violation per missplaced database field. Could be grouped as one single one?

Hi all.
I' m using Ruff with a django project.
Whenever DJ012 is triggered (which in my case  is when Meta Class is before the database fields fields), each violation of the same rule in the same model is counted as one.
Would it be possible to group them all tgether, as they are technically the same, so to report only one?
Here' s a short example:
class Activity(models.Model):
    """
    Define an activity
    """

    class Meta:
        verbose_name_plural = "Activities"
    name = models.CharField(max_length=50, blank=True)
    temp = ArrayField(
        models.PositiveSmallIntegerField(blank=True, default=0, null=True),
        default=list,
    )

will trigger two violations, as they are two fields after the class Meta that will trigger the rule.

Yeah, I think this would be better behavior. Nice idea.

Wow! that' s an amazing time to fix a very minor issue that I only reported because I thought it might be a good idea!
Thank you so much!


Oneflow fronted support more model and fix bug

This pr do :

[x] simplify oneflow fronted code.
[x] fix oneflow fronted python api doc display unnormal.
[x] add more ops and fix a lot of op convert bug.
[x] support squeezenet, shufflenet, ghostnet, vision transformer, etc and add test examples.

@masahi This pr need to be merged, ci passed. Thanks!


Add more Unit Tests

Ideally, we should cover the RoslynTypeSystem with tests. The current implementation just works in the sandbox app, other scenarios aren't tested. Also worth covering such classes as NameParser.cs and NameReceiver.cs.

A bunch of unit tests was added in https://github.com/worldbeater/XamlNameReferenceGenerator/pull/10 so should be a good starting point for writing those.

Yet another bunch of unit tests was added in https://github.com/AvaloniaUI/Avalonia.NameGenerator/pull/20

Probably worth covering the entire generator with tests as documented at https://github.com/dotnet/roslyn/blob/master/docs/features/source-generators.cookbook.md#unit-testing-of-generators
We now have a heavy bunch of unit tests, so the only class that is not covered now is the ISourceGenerator implementation.


Formatted files according to new prettier-config

Hey @codepunkt !
To finalize your repository cleanup I'd introduce the new formatting not only to package.json but to the source files.
OT: Thanks for the great work and reviews! If you one time need help with this plugin, feel free to summon me ❤. Maybe I'll have the time.
And ofc I'll take the time to respond to issues regarding excludes.
Nice release!

Thanks, Robin! ❤


Update documentation for Mathematical Language Understanding in README.md

Description
In recent commit problem mathematical_language_understanding was renamed to algorithmic_math_two_variables, but this isn't reflected in the root README.md

Thanks for your suggestion! I have updated the readme in this pull request: https://github.com/tensorflow/tensor2tensor/pull/1442


Use snippet-id instead of index into ft-table.

As addressed in #33, this doesn't rely on the indices into the ft-table only changing on an LuasnipSnippetsAdded.
The snip.id is unique for each snippet.

lgtm! should I merge?

Yup, go ahead👍

Just remembered that this should be changed too, hope it's okay to just tack on to this PR :sweat_smile:

@L3MON4D3 yup all good merging now :)


plant-website-enhanced

Related Issue
[Cite any related issue(s) this pull request addresses. If none, simply state "None”]
write issue no. here
#196
Email id used to regsiter for VSoc'24
<EMAIL_ADDRESS>Description
[Please include a brief description of the changes or features added]
had made the overall website responsive and added various effects including hover as well as animation
Type of PR

[ ] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Security enhancement
[ ] Other (specify): _______________

check in issue by entering [X] in boxes
Screenshots / Videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist

[x] I have performed a self-review of my code.
[x] I have read and followed the Contribution Guidelines.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have followed the code style guidelines of this project.
[x] I have checked for any existing open issues that my pull request may address.
[x] I have ensured that my changes do not break any existing functionality.
[x] Each contributor is allowed to create a maximum of 4 issues per day. This helps us manage and address issues efficiently.
[x] I have read the resources for guidance listed below.
[x] I have followed security best practices in my code changes.

check in issue by entering [X] in boxes
Additional Context
[Include any additional information or context that might be helpful for reviewers.]
Contribution Guidelines
Thank you for considering contributing to our project! To ensure smooth collaboration and effective contribution management, please adhere to the following guidelines:
Issue Creation

Limit on Issues:

Each contributor is allowed to create a maximum of 4 issues per day. This helps us manage and address issues efficiently.

Contribution Levels

Basic Contributions:

This project is primarily focused on documentation. Most of the setup has been completed, so contributors will generally need to work on basic code tasks, such as writing tests.
For these tasks, issues will be assigned the Easy label.

Acknowledging Hard Work:

If a contributor puts in significant effort on a task, the issue will be upgraded to Medium. This is our way of recognizing and appreciating extra effort.

Feature Additions and Component Work:

Contributors working on new features or components using JSX/TSX will be assigned a level based on the complexity and quality of their work.
The more complex and valuable the contribution, the higher the level assigned.

Level Definitions

Easy:

Tasks are straightforward, such as fixing minor bugs, writing tests, or making simple documentation updates.

Medium:

Tasks require more effort, such as addressing complex bugs, improving existing features, or making substantial documentation improvements.

Hard:

Tasks are highly complex and involve significant new feature development, major refactoring, or extensive contributions to the project’s core components.

We look forward to your contributions and appreciate your effort in helping us improve the project!

done @Ayushswirlon


Elite Font Support

Is there any chance for this project to support Elite font?

Sure.  Let me know if this looks okay: https://github.com/common-nighthawk/go-figure/pull/8
What are you using it for? :)

Sure. Let me know if this looks okay: #8
What are you using it for? :)

Yes it looks fine.
Using it for a project, elite font looks like ANSI art. So... :)


Semver?

Hello,
The new release (v14.0.0) has suddenly changed the semantic versioning (previous version was v0.13.8) from an initial development version to a major version.
Is it wanted?

This matches the versioning of the reference implementation and is intended: https://github.com/graphql/graphql-js/tags?after=v14.0.0

OK thanks for the answer.


Corrects connector usage within Helm charts

uses Artifactory API to download latest available pre-built artifacts (snapshots or releases)
corrects (again?) the configuration calls used to initialize the connectors
updates the connector jar filenames based on new connector assembly mechanisms

Should address the issue identified in #2348, but does not resolve the lack of audit logging that makes identifying this issue problematic.


aws-cpp-sdk-transfer problem with upload file to s3 when target object key contains '?' sign

Hi,
I tried to upload file to S3 using aws-cpp-sdk-transfer. when target object key contains '?' sign, the object key is being truncated.
i.e. I requested to upload a file to an object key named 'a?txt', file was uploaded, but the object key name was 'a' (i.e. the '?' and all other characters where truncated).
I tried also to give the url encoded string for '?' (%3F), but then I got an object key name was a%3Ftxt and not a?txt as I wanted
Eliyahu

See #546

Hi,
According to http://docs.aws.amazon.com/AmazonS3/latest/dev/UsingMetadata.html any utf8 characters are valid. there is recommendation not to use question mark, or url encode it, "The following characters in a key name may require additional code handling and will likely need to be URL encoded or referenced as HEX"
but I understand this is still a valid object key name. As the SDK shall support valid usage of S3, I think it shall be added the ability to support question mark at object name.

Content after '?' is treated as url query string, so ? is not encoded. Users can encode the key's name by themselves, but on S3 you will see %3F, because SDK will encode it again, then in url it becames %253F. on S3's service end, it will treat it as %3F.  What you could do is to decode the key's name after you download it If you don't care about how it shows on S3.

@Eliyahu-Machluf Hi, this has been solved.


extend smoke tests to try pushing

to catch bugs in macos implementation that would otherwise remain hidden
push to the dothub instead!

also make the smoke tests run every hour.

Moved running them once an hour out into https://github.com/dotmesh-io/dotmesh/issues/402.
Found the following failures with it:

https://github.com/dotmesh-io/dotmesh/issues/403
https://github.com/dotmesh-io/dotmesh/issues/404


Remove support for ruby 1.8

Remove support for ruby 1.8. Introduce the following changes:

Use 1.9 hash syntax
Remove Faraday version lock (current version is 0.9.2, previously locked at 0.7)
Remove MultiJSON runtime dependency (JSON ships w/ >= 1.9, only use MultiJSON if defined)

2.0 roadmap: #110
@nextmat lmk if any other improvements/oversights come to mind

👍

We should probably add a required ruby version to the gemspec.

This generally looks good to me. Total nit but in the future you might want to do something like this in two pieces:
PR 1) functional changes
PR 2) formatting changes (hashrockets, etc)
Just to make review a bit more manageable.
Also we should make sure the full integration suite passes before this is merged (not run by Travis), lmk if you need any help to run this.

@nextmat added required version in 33c00151775cf438148505110e7c61b729e424ed and refactored SmartJSON w/ tests in 58bf7ae957de241793175288e2ecc64927da22bc, PTAL.
:+1: on breaking it out into functional/style changes in the future to prevent larger diffs.
RE: integration tests, they appear to have already been failing on master, unrelated to recent changes. Will get those passing in another PR and merge into 2.0 branch.


[BPF] CgroupV2Path override for operator installs

Description
refs https://github.com/projectcalico/calico/issues/7892

Related issues/PRs

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

TBD

Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one docs-* label.

docs-pr-required: This change requires a change to the documentation that has not been completed yet.
docs-completed: This change has all necessary documentation completed.
docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

release-note-required: This PR has user-facing changes. Most PRs should have this label.
release-note-not-required: This PR has no user-facing changes.

Other optional labels:

cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

Any progress since May 3?
Getting this solved in the operator would not force us to go back to manifest-style installation.


Schema

Better schema checking

Codecov Report
Base: 94.93% // Head: 94.45% // Decreases project coverage by -0.48% :warning:

Coverage data is based on head (0a3cb27) compared to base (861ef19).
Patch coverage: 98.92% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   94.93%   94.45%   -0.48%
==========================================
  Files           7        7
  Lines         375      361      -14
  Branches       11       11
==========================================
- Hits          356      341      -15
- Misses          8        9       +1
  Partials       11       11

Impacted Files
Coverage Δ

src/sg/flybot/pullable/schema.cljc
98.94% <98.92%> (-1.06%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Very nice!
I am not sure why this schema is not valid:
(m/explain
   (pattern-schema-of [:map [:a [:map [:b :int]]]])
   {(:a :with [1]) {:b '?}})

;; it returns:
{:schema ...
 :value {[1] {:b ?}}
 :errors
 ({:path [[1]]
   :in [[1]]
   :schema ...
   :value {:b ?}
   :type :malli.core/extra-key})}

Very nice!
I am not sure why this schema is not valid:
(m/explain
   (pattern-schema-of [:map [:a [:map [:b :int]]]])

This looks like just a normal nested map, :a is a map, it can not have :with option, only function type can have.

{(:a :with [1]) {:b '?}})
;; it returns:
{:schema ...
:value {[1] {:b ?}}
:errors
({:path [[1]]
:in [[1]]
:schema ...
:value {:b ?}
:type :malli.core/extra-key})}

It seems that if one key has option (default, with etc), we cannot select deeper. Or maybe I made a mistake with how I wrote the schema?


Project Home page - link to the M1 Project page

Estimated hours worked 2 hours
https://clubs-at-manoa.github.io/


Mutating include takes slow path while typing

Input
Mutating include takes slow path while typing. This is not evident on sorbet.run, but is evident on large codebases.
→ View on sorbet.run
# typed: true
extend T::Sig

module LongLongName

end

class B
  include Lo
  #       ^ mutating the above seems to take slow path even if module doesn't exist
end

Observed output
New characters added/deleted take the slow path.

Expected behavior
Autocomplete is fast unless you complete to an existing module name.

I will need to investigate if this problem is possible to solve or not. I think if we can hash all non-existent includes to the same canonical value it will work.

This isn't possible to fix. When hashing the file, we don't know if a given ident will resolve.


Improve NEON rot16/rot8

On MacBook Air M1:
$ time dd if=/dev/zero bs=1048576 count=1024|./target/release/b3sum
1024+0 records in
1024+0 records out
1073741824 bytes transferred in 0.713978 secs<PHONE_NUMBER> bytes/sec)
94b4ec39d8d42ebda685fbb5429e8ab0086e65245e750142c1eea36a26abc24d  -
dd if=/dev/zero bs=1048576 count=1024  0.00s user 0.08s system 11% cpu 0.718 total
./target/release/b3sum  0.66s user 0.04s system 98% cpu 0.717 total

before:
$ time dd if=/dev/zero bs=1048576 count=1024|./target/release/b3sum
1024+0 records in
1024+0 records out
1073741824 bytes transferred in 0.793620 secs<PHONE_NUMBER> bytes/sec)
94b4ec39d8d42ebda685fbb5429e8ab0086e65245e750142c1eea36a26abc24d  -
dd if=/dev/zero bs=1048576 count=1024  0.00s user 0.08s system 9% cpu 0.798 total
./target/release/b3sum  0.76s user 0.03s system 99% cpu 0.798 total

I'm seeing an error on some other ARM targets in CI:
  running: "arm-linux-gnueabihf-gcc" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-gdwarf-4" "-fno-omit-frame-pointer" "-march=armv7-a" "-mfpu=vfpv3-d16" "-Wall" "-Wextra" "-std=c11" "-mfpu=neon-vfpv4" "-mfloat-abi=hard" "-o" "/target/armv7-unknown-linux-gnueabihf/debug/build/blake3-f22b00965a848420/out/c/blake3_neon.o" "-c" "c/blake3_neon.c"
  cargo:warning=c/blake3_neon.c: In function 'rot8_128':
  cargo:warning=c/blake3_neon.c:47:31: warning: implicit declaration of function '__builtin_shufflevector' [-Wimplicit-function-declaration]
  cargo:warning=   return vreinterpretq_u32_u8(__builtin_shufflevector(vreinterpretq_u8_u32(x), vreinterpretq_u8_u32(x), 1,2,3,0,5,6,7,4,9,10,11,8,13,14,15,12));
  cargo:warning=                               ^
  cargo:warning=c/blake3_neon.c:47:31: error: incompatible type for argument 1 of 'vreinterpretq_u32_u8'
  cargo:warning=In file included from c/blake3_neon.c:3:0:
  cargo:warning=/usr/lib/gcc-cross/arm-linux-gnueabihf/5/include/arm_neon.h:14673:1: note: expected 'uint8x16_t' but argument is of type 'int'
  cargo:warning= vreinterpretq_u32_u8 (uint8x16_t __a)
  cargo:warning= ^
  cargo:warning=c/blake3_neon.c:48:1: warning: control reaches end of non-void function [-Wreturn-type]
  cargo:warning= }
  cargo:warning= ^
  exit status: 1

The correct way to write this is
INLINE uint32x4_t rot8_128(uint32x4_t x) {
  static const uint8x16_t r8 = {1,2,3,0,5,6,7,4,9,10,11,8,13,14,15,12};
  return vreinterpretq_u32_u8(vqtbl1q_u8(vreinterpretq_u8_u32(x), r8));
}

The downside is, of course, that this (vqtbl1q_u8) is AArch64-specific. For 32-bit ARM we need to split the vector into two halves and do two separate vtbl1_u8 and recombine into a 128-bit vector.
All that being said, while it seems clear that the vrev32q_u16 is a win in general, the table lookup is less clear. The M1 is an outlier in that it can do 4 vqtbl1q_u8 per cycle, which is much higher than most, so the above numbers for it may or may not reflect an improvement on the rest of the ARM landscape...

On that note, implementing the generic rotations as follows:
INLINE uint32x4_t rot12_128(uint32x4_t x) {
  // return vorrq_u32(vshrq_n_u32(x, 12), vshlq_n_u32(x, 32 - 12));
  return vsriq_n_u32(vshlq_n_u32(x, 32-12), x, 12);
}

might also be an improvement on the M1, but once again in other chips it varies.

Thanks for the advice!
I change the code to use __builtin_shuffle on GCC. On Godbolt it seems this can generate two vtbl1_u8 instructions for 32-bit ARM.
Additionally using shl+sri for rot7+rot12, user time is reduced to 0.64s. On M1 icestorm core this effect is more significant:
Original:
$ time dd if=/dev/zero bs=1048576 count=1024|taskpolicy -c background ./target/release/b3sum
1024+0 records in
1024+0 records out
1073741824 bytes transferred in 3.648963 secs (294259444 bytes/sec)
94b4ec39d8d42ebda685fbb5429e8ab0086e65245e750142c1eea36a26abc24d  -
dd if=/dev/zero bs=1048576 count=1024  0.00s user 0.17s system 4% cpu 3.654 total
taskpolicy -c background ./target/release/b3sum  2.92s user 0.32s system 88% cpu 3.654 total

rot8/rot16:
$ time dd if=/dev/zero bs=1048576 count=1024|taskpolicy -c background ./target/release/b3sum
1024+0 records in
1024+0 records out
1073741824 bytes transferred in 3.011343 secs (356565766 bytes/sec)
94b4ec39d8d42ebda685fbb5429e8ab0086e65245e750142c1eea36a26abc24d  -
dd if=/dev/zero bs=1048576 count=1024  0.00s user 0.12s system 4% cpu 3.015 total
taskpolicy -c background ./target/release/b3sum  2.67s user 0.32s system 99% cpu 3.015 total

rot8/rot16+rot7/rot12:
$ time dd if=/dev/zero bs=1M count=1K |taskpolicy -c background ./target/release/b3sum
1024+0 records in
1024+0 records out
1073741824 bytes transferred in 2.691741 secs (398902355 bytes/sec)
94b4ec39d8d42ebda685fbb5429e8ab0086e65245e750142c1eea36a26abc24d  -
dd if=/dev/zero bs=1M count=1K  0.00s user 0.12s system 4% cpu 2.697 total
taskpolicy -c background ./target/release/b3sum  2.22s user 0.32s system 94% cpu 2.697 total

Wow, that's a huge improvement. I'll try to test these changes on one of my Raspberry Pis tonight.

Here are some test results on a Android Xiaomi Mi Note Qualcomm Snapdragon 801 'Krait 400' ARMv7 core:
User time for dd if=/dev/zero bs=1M count=1K|b3sum
commit 3f396d: 4.28s
commit 7a9a32: 4.38s
commit 6040c7: 3.96s
Based on commit 6040c7, if the two table lookup instructions in rot8_128 are replaced with shl+sri, the time will be reduced to 3.49s.
So according to the tests on M1 Firestorm, Icestorm and this 'Krait 400' core, for rot7/rot12/rot16 vrev32q_u16 and shl+sri is a win in general. As for rot8, on Firestorm and Icestorm vqtbl1q_u8 is better, but on 'Krait 400' ARMv7 core shl+sri wins. So the rot8_128 perhaps should be implemented as:
INLINE uint32x4_t rot8_128(uint32x4_t x) {
#if defined(IS_AARCH64)
  static const uint8x16_t r8 = {1,2,3,0,5,6,7,4,9,10,11,8,13,14,15,12};
  return vreinterpretq_u32_u8(vqtbl1q_u8(vreinterpretq_u8_u32(x), r8));
#else
  return vsriq_n_u32(vshlq_n_u32(x, 32-8), x, 8);
#endif
}

Let's see what happens on Raspberry Pis' ARM cores……

Here's my RPi3 (Cortex-A53) on master, all measurements median of 5 runs:
$ cargo +nightly bench --features=neon bench_many_chunks_neon
...
test bench_many_chunks_neon            ... bench:      20,101 ns/iter (+/- 31) = 203 MB/s

And the RPi3 on sdlyyxy/neon (6040c73):
$ cargo +nightly bench --features=neon bench_many_chunks_neon
...
test bench_many_chunks_neon            ... bench:      15,286 ns/iter (+/- 40) = 267 MB/s

Here's my RPi4 (Cortex-A72, in 32-bit/armv7l mode) on master:
$ cargo +nightly bench --features=neon bench_many_chunks_neon
...
test bench_many_chunks_neon            ... bench:      13,844 ns/iter (+/- 53) = 295 MB/s

And the RPi4 on sdlyyxy/neon (6040c73):
$ cargo +nightly bench --features=neon bench_many_chunks_neon
...
test bench_many_chunks_neon            ... bench:      14,093 ns/iter (+/- 40) = 290 MB/s

@sneves mentioned some AArch64-specific instructions above, so I'm curious whether getting a proper 64-bit Linux kernel onto my RPi4 might lead to a better result. The improvement on the RPi3 is quite dramatic (~1.3x), in line with what you reported for the M1.

Wow, yes. I reimaged my RPi4 with ArchLinuxARM-rpi-aarch64-latest.tar.gz, and now I see the improvement. On master:
$ cargo +nightly bench --features=neon bench_many_chunks_neon
...
test bench_many_chunks_neon            ... bench:      11,744 ns/iter (+/- 28) = 348 MB/s

And on sdlyyxy-neon (6040c73):
$ cargo +nightly bench --features=neon bench_many_chunks_neon
...
test bench_many_chunks_neon            ... bench:      10,676 ns/iter (+/- 16) = 383 MB/s

A 10% speedup there.

Sure, why not. I probably wouldn't remove the old rotations but comment them out or something, seeing that ARM is a tower of babel of microarchitectures and you never know what's fast or not there.

Thank you for reviewing and testing :)


support bash style assignment

support the following syntax
VAR=value do-something

after evaluation of do-something, restore VAR

implement as the following syntax sugar
{
    let _old_VAR = $VAR
    try { $VAR='value'; do-something; } finally { $VAR = $_old_VAR; }
}


ORC-772: Fix Spark benchmark jar creation

What changes were proposed in this pull request?
This PR aims to fix Spark benchmark jar creation by using the default Maven shade plugin configurations explicitly. Otherwise, the parent pom's configuration is applied.
Why are the changes needed?

Manually.
$ cd java/bench

$ mvn clean package -pl spark --am

$ ls -alh spark/target/*.jar
-rw-rw-r-- 1 dongjoon dongjoon 130M Mar 23 05:56 spark/target/orc-benchmarks-spark-1.7.0-SNAPSHOT.jar
-rw-rw-r-- 1 dongjoon dongjoon  62K Mar 23 05:55 spark/target/original-orc-benchmarks-spark-1.7.0-SNAPSHOT.jar

cc @omalley and @pgaref

Thank you!


Confirmation Alert

For #26 I added a confirmation alert when closing a tab while uploading.

Thanks! This seems good.

Merged in with 5d517f69ad5df84c1c6174c09e7fb7b2a2e8cf64


Support flit

The description says it supports pyproject.toml but actually it supports only poetry. However Flit (https://flit.readthedocs.io/en/latest/) also uses pyproject.toml but with different keys.
It would be nice if that is also supported..

Thank you for the suggestion.
I implemented a support for Flit in #83.
But the current implementation is very naive and it may miss something.  Please let me know if you find something wrong.


mobilerobot source code unavailable

Hello, i'm trying to follow the tutorial "Drag and drop (aka inverse kinematics)", but I can't access to the mobilerobot module. In fact, in the tutorial, it is specified that the module is available on this link : https://gepettoweb.laas.fr/doc/stack-of-tasks/pinocchio/master/doxygen-html/mobilerobot_8py_source.html
But when I click on the link I have a 404 error. I guess I can't perform the tutorial witheout this module. Thank you for your feedback :)

@gabrielebndn I think this issue issue is coming from your side. Could you provide some help please?

@jcarpent he is actually referring to https://gepettoweb.laas.fr/doc/stack-of-tasks/pinocchio/master/doxygen-html/md_doc_d-practical-exercises_3-invkine.html, which is not my work. There is currently some confusion and overlap between the different tutorials and examples etc.
The link is inside the webpage, but it is currently not working. I think the best person to answer this is @nmansard. Either him or @nim65s

@gabrielebndn I found the bug and I think you did want it, but it seems your made the modifications that lead to the current behavior ;) Please see https://github.com/stack-of-tasks/pinocchio/commit/68bed7b27b95e9e9569474bf02a4b420309cfd8f
I will provide a fix.

Oooh, I see... I will comment on the PR.
Speaking of which, wouldn't it be time to manually update the uploaded doc, at least partially addressing #1007 before an automatic solution is put back in place?

Meanwhile, @mohamdev, while waiting for the fix, all Python sources for the preactical exercises can be found in the Pinocchio repo, in the subfolder doc/d-practical-exercises/src. You can either copy and paste the files one by one from Github when you need them, or you can clone the repo. This is the most convenient solution, I think: you don't even need to build it, just clone the repo and and then copy the files somewhere else

Solved by #1071.
@mohamdev We will provide a new release of the doc soon. Thanks a lot for raising this very helpful issue.

That's fine, thank you very much for your feedback :)


Warnings issued for functional conversion prefixes

Billions of these:
WARNING:root:IRI: dc:title - dc not a valid prefix
Appear in the output

Turns out that these were being issued in a branch, not the original


Idea: Make site "Tutorials > Using Babel with Typescript" work

Improvement Idea: Make site Tutorials > Using Babel with Typescript work again.

Why:

Link in navigation sidebar is not working
Navigating to site Using Babel with Typescript gives the error "The resource you are looking for has been removed, had its name changed, or is temporarily unavailable."

Alternative ideas: none

Thanks!


Review: MyEvents.jsx and MyAccount.jsx

Overview
The focus for this code review will be centered around the files in this project.
Please pay attention too:

Javascript issues
React components

Review Branch
review-10
Files to review

MyEvents.jsx
MyAccount.jsx

Checklists

Architecture
Design
JS
React
Testing

Due date
04/08
For more information
The review process is documented at: http://courses.ics.hawaii.edu/ics414s21/morea/review/reading-idpm-review.html

MyEvents.jsx
JS-06: Remove console.logs from L28-32
L42-51: Can we replace this code with the LoadingSpinner container instead?
L52: Add style code to the CSS file instead
MyAccount.jsx
JS-06: Remove console.logs from L12-15 (probably used for testing)
L57: Update code to get phone number from the collection
L58: Update code to get email from the collection
L84-86: Update code to get interests from the collection

MyEvents.jsx
Design-04 : Large commented sections
JS-07 : Console logs for debugging present; should be removed
MyAccount.jsx
L57: code phone number from the collection

MyEvents.jsx
DE-05: unnecessary comment on L13
JS-06: L28-32 remove console.logs
MyAccount.jsx
DE-04: L69-81 large amount of comment out code
JS-06: L14 Remove console.logs
L57-58 update to get the data from collection

MyEvents.jsx
L28-30 remove console.logs
MyAccount.jsx
L14 remove console.logs
L57-58 update to get email/phone number from collection

MyEvents.jsx
DE-: unnecessary comment
JS-06: L28-32 console.logs
MyAccount.jsx
DE-04: L69-81 useless code
JS-06: L14 Remove console.logs

MyEvents.jsx
JS-06: L28-32 Remove console.logs
MyAccount.jsx
JS-06: L14 Remove console.logs


Add ECR upload

FFQ is a handy utility, but seems largely unmaintained and I'm not optimistic that PR requests will be honoured.
So I propose we work with a fork for the moment, but that leaves us to handle distribution so we can use the tool with the likes of Nextflow et al. This PR adds ECR upload to the CI, so we we'll get new images when PRs are merged and we can deploy them via nextflow.
(FYI this has been tested and works- I just reset the git history when I was done)

Thanks @pedrocr83 !


There is a problem with tiff and webp conversion in the CUI program. (Image files are image files in yuv420p pixel format extracted with ffmpeg.)

I tried to convert a tiff using the yuv420 pixel format for testing, but an error occurred.
However, the waifu2x-caffe GUI program completes the conversion without error.
Also, for webp, it displays a Japanese langauge to message that the conversion is complete, but no conversion is done.
The CUI program does not seem to be compatible with tiff and webp image formats.
In waifu2x-converter-cpp, the operation worked fine.
I would like to do the same thing with TTA and cudnn, but the error occurred and there was a problem with the conversion.
Is this a problem with the command? Or is it a problem with the CUI program?
The command is as follows:
D:\Utility\video2x\dependencies\waifu2x-caffe\waifu2x-caffe-cui.exe --output_extention tiff --mode noise_scale --scale_ratio 2.0 --noise_level 0 --process cudnn --crop_size 1024 --output_quality -1 --output_depth 8 --batch_size 1 --input_path D:\Utility\video2x\1 --output_path D:\Utility\video2x\2

Regarding webp, you need to add the -l webp option. The default value of input_extention_list(-l) is "png: jpg: jpeg: tif: tiff: bmp: tga",  it seems that webp is not contained, so *.webp is skipped.

What should I do with a tiff file?

Ented "png: jpg: jpeg: tif: tiff: bmp: tga" in input_extention_list.
but "tiff" file too, it displays a Japanese language to message that the conversion is complete, but no conversion is done.

And nted "png:jpg:jpeg:tif:tiff:bmp:tga" in input_extention_list.
To "cudaSuccess (2 vs 0) out of memory" error.

Oops, the cause of the error was excessive crop_size.
Fixed crop_size to 128.


stacer: init at 1.1.0

Description of changes
Resolves #188921.
NOTE: Should we include a warning in longDescription that this tool might not work as expected under NixOS and can cause unintended side effects?

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

NOTE: Should we include a warning in longDescription that this tool might not work as expected under NixOS and can cause unintended side effects?

Did you test the tool and what kind of side effects did it cause?

I built stacer from this branch and it built successfully.
I use stacer mostly for the System Cleaner tab.
It successfully cleaned 10Go of Application Logs and Application cache.
It seems Crash Report option does not find the items in /var/lib/systemd/coredump, where I had 5 additional Go of dumps.
@dit7ya, are you around?

I just saw that someone requested this package again two weeks ago. I'm also interested.
@dit7ya, are you there?

Result of nixpkgs-review pr 188986 run on x86_64-linux 1

1 package built:

stacer


Separate solr port for tests

It'd be nice be able to run tests, and then come back and still have an earlier big ingest available.

@mccalluc Yes, I was about to make this same ticket. Why not use a development and test core. I think Blacklight w/ blacklight-jetty is set up to make that easy.


📝 Fix Hub Deno Import

I was going through the Hub documentation and noticed that the Deno import was HInference

Thank you for the clarification.
I've incorporated your suggested changes.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


TypeError: type() argument 1 must be string, not unicode

On Python 2.7.13 the package does not seem to work:
[...]
env/lib/python2.7/site-packages/health_check/contrib/celery/apps.py", line 16, in ready
    celery_class = type(celery_class_name, (CeleryHealthCheck,), {'queue': queue})
TypeError: type() argument 1 must be string, not unicode

using celery 4.1.0 and amqp 2.2.2.

Hi @akellne that might be correct, but we no longer support legacy Python versions. You can find the last Version with Python 2 support here: https://github.com/KristianOellegaard/django-health-check#supported-versions


Add client-event webhook support

This satisfies the request in #201
See: https://pusher.com/docs/client_api_guide/client_events#trigger-events
I apologize if this isn't quite Ruby-idiomatic, but it adds the necessary functionality and I verified it works with our production code as a drop in replacement for Pusher's official implementation.
If you approve the merge it would be a big help if you could deploy a new version to rubygems.

FYI https://github.com/stevegraham/slanger/commit/8307f0ed8a71c7e29a0b66e40c3ce444866132aa?w=1

Useful, thanks!
On Sat, Jan 30, 2016, 12:31 AM Mark Burns<EMAIL_ADDRESS>wrote:

FYI 8307f0e?w=1
https://github.com/stevegraham/slanger/commit/8307f0ed8a71c7e29a0b66e40c3ce444866132aa?w=1
—
Reply to this email directly or view it on GitHub
https://github.com/stevegraham/slanger/pull/202#issuecomment-177075701.

Thanks for the PR! Now in 0.5.0

Just a followup - I have a Docker image that installs slanger from rubygems - it works great with the new release. Thanks!

Nice. Examples would be good if there's anything you can share

I'll try and come up with something. It works exactly the same as the
official pusher implementation, except pusher supports different webhook
URLs for three kinds of events, but its easy enough to just use one.
On Tue, Feb 2, 2016, 10:59 AM Mark Burns<EMAIL_ADDRESS>wrote:

Nice. Examples would be good if there's anything you can share
—
Reply to this email directly or view it on GitHub
https://github.com/stevegraham/slanger/pull/202#issuecomment-178653408.


bump version librepcb-unstable: 2018-06-28 -> 2018-10-31

Motivation for this change
update
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@ikarulus could you amend your commit message according to guidelines please?
librepcb-unstable: 2018-06-28 -> 2018-10-31
LGTM otherwise.

Can I actually also PR this to the release-18.09 branch without further evaluation? It seemed to me as librepcb changed the syntax of their libraries which renders the current available version unusable.

@GrahamcOfBorg build librepcb

@ikarulus yes if the current version in 18.09 is not fully working then the backport is justified.
You can make another PR targeting release-18.09 branch and cherry-pick the commit from this PR

Success on x86_64-linux (full log)
Attempted: librepcb
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/473b5nlbs31yfmd8v4b09s65gdqipmlb-librepcb-20181031
shrinking /nix/store/473b5nlbs31yfmd8v4b09s65gdqipmlb-librepcb-20181031/bin/librepcb
shrinking /nix/store/473b5nlbs31yfmd8v4b09s65gdqipmlb-librepcb-20181031/bin/librepcb-cli
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/473b5nlbs31yfmd8v4b09s65gdqipmlb-librepcb-20181031/bin
patching script interpreter paths in /nix/store/473b5nlbs31yfmd8v4b09s65gdqipmlb-librepcb-20181031
checking for references to /build in /nix/store/473b5nlbs31yfmd8v4b09s65gdqipmlb-librepcb-20181031...
postPatchMkspecs
postPatchMkspecs
/nix/store/473b5nlbs31yfmd8v4b09s65gdqipmlb-librepcb-20181031

Success on aarch64-linux (full log)
Attempted: librepcb
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/qmg4djqxlj55jp38fxsjm69i18cbmybp-librepcb-20181031
shrinking /nix/store/qmg4djqxlj55jp38fxsjm69i18cbmybp-librepcb-20181031/bin/librepcb-cli
shrinking /nix/store/qmg4djqxlj55jp38fxsjm69i18cbmybp-librepcb-20181031/bin/librepcb
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qmg4djqxlj55jp38fxsjm69i18cbmybp-librepcb-20181031/bin
patching script interpreter paths in /nix/store/qmg4djqxlj55jp38fxsjm69i18cbmybp-librepcb-20181031
checking for references to /build in /nix/store/qmg4djqxlj55jp38fxsjm69i18cbmybp-librepcb-20181031...
postPatchMkspecs
postPatchMkspecs
/nix/store/qmg4djqxlj55jp38fxsjm69i18cbmybp-librepcb-20181031


Zoom in Zoom out features are needed

Is your feature request related to a problem? Please describe.

Describe the solution you'd like:

Describe alternatives you've considered:

Additional context:

Closing as incomplete. Please feel free to add more information if you have any and we can re-open the issue.


Fix CooMatrix.to_dense for duplicate indices

Fixes https://github.com/chainer/chainer/issues/6543.

Discussed with @asi1024 that we should do some performance benchmarks before proceeding with the review. If this implementation is too slow, we might reconsider the expected behavior (e.g. keep the current behavior).

@hvy A discussion about performance is left, but this PR looks good for a temporary fix. Can I merge this PR?

Jenkins, test this please.

Jenkins CI test (for commit 1fbaebf4d0f47b85ed27408b152b7908bd50db79, target branch master) succeeded!

/test

LGTM.


Miscellaneous Fixes

Add group option to create user (Section 6.1)
Fix Link (Section 6.5)
Add header row and column to API overview table (Section 7)
Improve intro text (Section 7.7)
Fix inline literals in filtering tables (Section 8.1)
Fix SQL comment description (Section 11.5)
Update version variable to 23.12.1

Fantastic, thanks!


Added RP2350 SVD

First contribution, got SVD from here.
The RP2350 is a newly released MCU from Raspberry Pi, released along side the Raspberry Pi Pico 2.

Hey! @VincentDary could you outline why this was closed without merging?

This is an error on my part, I am working on the issue 4 and I have force push on the repository, the issue has been closed automatically, I can't reopen the issue, Github block the reopen buton, but I am working to merge your commit and other closed automatically.

@AverseABFun I have a branch with your commits prepared on my fork. They aren't lost. It just got too late yesterday while investigating the situation. Once the mentioned issue #4 has been resolved, we'll work on merging #5, #6, #7, #9 and this one, which were all affected. Issue #10 will receive a replacement with another implementation though (working on that one too).

Alright, sounds good! Thanks for informing me.

SVD file contribution verified against original file provider, OK.
$ git clone https://github.com/raspberrypi/pico-sdk.git
$ cd pico-sdk/src/rp2350/hardware_regs/
$ sha512sum RP2350.svd > ../../../../hash_from_raspberrypi.txt
$ cd ../../../../
$ sed -i -e 's/RP2350.svd/rp2350.svd/g' hash_from_raspberrypi.txt
$ git clone https://github.com/BenBE/cmsis-svd-data.git
$ cd cmsis-svd-data
$ git checkout rp2350
$ cd data/RaspberryPi
$ sha512sum -c ../../../hash_from_raspberrypi.txt
rp2350.svd: OK
$ echo $?
0

@AverseABFun thank you very much for your contribution.
hash_from_raspberrypi.txt


Login - JS: Send data to API, recive Authorization code

If validated: Show two buttons? create new post or edit former post? Link them to appropriate page
If not validated:
User doesnt exist, register new user? link to register


Task - comprehensive specimen: transcribed coordinates from label outlined in red

The map indicates the correct position, but the user is left thinking something is worng.

@jrflood Please screenshot

Pushed, can you test again and see if still getting the validation error?

This fixed the issue :)

Thanks!


Support advanced PiP integration

As a developer integrating Pillarbox I want to be able to implement PiP deeper in my application, so that users can browse the application while continuing playback using PiP.
As a Pillarbox user I want to be able to use the app while watching content.
Acceptance criteria

An API is provided so that developers can perform advanced PiP integration with dismissal and restoration.
The Pillarbox demo can be browsed while using PiP, for all the players supporting PiP (custom player, playlist, multi-player demo).

Hints

A unified API be compatible with #610 should be provided.
PiP is not integrated in other demos (stories, simple, etc.).

Tasks

[x] Implement PiP lifecycle for SwiftUI and add dedicated modifiers.
[x] Implement for custom player:

[x] Modal dismissal when entering PiP.
[x] Modal restoration when exiting PiP.

[x] Make it work with the multi-player demo.
[x] Add PiP button:

[x] Provide observable states for UI integration.
[x] Add PiP button to relevant players.

[x] Ensure that PiP and usual in-app playback do not conflict:

Start PiP playback.
Open simple example without PiP support. The PiP session should end.

[x] Ensure that PiP is exited when navigating to the currently playing item again (instead of interrupting playback).
[x] Check that no resources are leaked.

I finally could understand why sometimes we observed Picture in Picture being paused during restoration, not from the PiP overlay itself, but by starting playback of another content. This investigation and the related fix were made as part of #702.
The problem
Sometimes

Here are a few use cases as a reminder of expected behaviors that should possible to implement and test in the demo. This is of course no perfect replacement for proper unit testing but at least better than having nothing.
Restoration via button
Restoration by opening the same content
Restoration to another content


Timezone change week/day view bug

Do you want to request a feature or report a bug?
bug
What's the current behavior?
The current behavior is that if you change the timezone on your machine, week/days hour rows will be collapsed.
The bug can be tracked on Big Calendar DEMO and Docs.
A bug screencast added.

What's the expected behavior?
The expected behavior is that week/days hour rows won't be collapsed.

@Grosscorp Is this a bug or an issue with implementation? Seems like it would not be common for someone using the app to change their timezone in the middle of using it. Does it work on refresh?

@arecvlohe I'm sorry, I'm not sure whether it is a bug or issue with implementation, but I think its a bug. Yes, I agree it's not a common case of usage, and this bug is hard to catch and test, but we can think of it like timezone can change automatically in the middle of usage, and then this bug can occur. Yes, it's work on refresh, but we creating SPA with react, and we want to avoid update in our web application, maybe some other solution can be found and it can improve this great project. Thank you.

@Grosscorp Thanks for the feedback. Because of the narrowness of the issue it probably won't be something library authors can address any time soon. We are open to accepting a PR if you want to give it a try! Closing the issue for now.


supervenn._plots.supervenn returns chunks

Changes

Added return statement in supervenn._plots.supervenn to return the chunks list of sets.
Updated docstring for supervenn._plots.supervenn to reflect the change.

Side effects

No impact on other functions nor tests.

This would close https://github.com/gecko984/supervenn/issues/4


Detox header button test fail

I am relative new to Detox E2E testing.  I have header one button which will go back to the previous screen. I made testID for this button but I got one Detox error:  Test Failed: No elements found for “MATCHER(identifier == “close_button”)”.  I really don't know how to test the header button.  I am sharing my code, hope someone will help me.
this is the component where I have button

  const closeScreen = useCallback(() => {
    navigation.pop();
  }, [navigation]);

  useLayoutEffect(() => {
    navigation.setOptions({
      headerLeft: () => <View />,
      headerRight: () => (
        <CloseContainer>
          <TouchableOpacity onPress={closeScreen} testID={'close_button'}>
            <Text>hhhh</Text>
          </TouchableOpacity>
        </CloseContainer>
      ),
    });
  }, [closeScreen, navigation]);

This is my Detox test

 it('close button', async () => {
    const button = await element(by.id('close_button'));
    const text = await element(by.id('previous_page'));
    await button.tap();

    expect(text).toBeVisible();
  });

@alakdam07  did you solve it ?


Fix Bug: Stop Propagation

Stop Propagation of event 'markerClick' in Overlay with on event 'mapClick' in Map

Way too many unnecessary code edits. I'll accept you are new. I don't want most of your text edits. So now I have to take time to cut out the code I do want.
I'll accept this pull request sometime today. If you had only made the fixes, I might have already accepted this request but now I have to edit it.

Sorry, my editor adjusted the spaces in automatic according to the norms of writing, in fact only edit 1 line per file.

Understood. I will accept this request today.

Thank you, greetings, excellent work yours helped me a lot in what I needed to generate

I made just the single change I think you made and published as version 1.4.0
I could not accept this pull request because it made too many unnecessary edits


jdk-windows-aarch64-hotspot : incorrect boot jdk

https://ci.adoptopenjdk.net/view/Failing Builds/job/build-scripts/job/jobs/job/jdk/job/jdk-windows-aarch64-hotspot/38/console
21:07:56  checking for version string... 17+10-202102242107
21:07:56  configure: Found potential Boot JDK using configure arguments
21:07:57  checking for Boot JDK... /cygdrive/c/workspace/openjdk-build/jdk-16
21:07:57  checking Boot JDK version... openjdk version "16" 2021-03-16 OpenJDK Runtime Environment AdoptOpenJDK (build 16+36-202102231320) OpenJDK 64-Bit Server VM AdoptOpenJDK (build 16+36-202102231320, mixed mode, sharing)
21:07:57  checking for java [Boot JDK]... $BOOT_JDK/bin/java
21:07:57  checking for javac [Boot JDK]... $BOOT_JDK/bin/javac
21:07:57  checking for javadoc [Boot JDK]... $BOOT_JDK/bin/javadoc
21:07:58  checking for jar [Boot JDK]... $BOOT_JDK/bin/jar
21:07:58  checking if Boot JDK is 32 or 64 bits... 64
21:08:01  checking for local Boot JDK Class Data Sharing (CDS)... yes, created
21:08:01  configure: Found potential Build JDK using configure arguments
21:08:01  configure: Potential Build JDK found at /cygdrive/c/workspace/openjdk-build/jdk-16 is incorrect JDK version (openjdk version "16" 2021-03-16
); ignoring
21:08:01  configure: (Your Build JDK must be version 17)
21:08:01  checking for Build JDK... no
21:08:01  configure: error: Could not find a suitable Build JDK

fixed


'attach-bridge' feature to link an existing bridge netdev with the weave bridge

In order to continue progressing #1940 in an incremental fashion, we need to reimplement create_bridge in the weave script with weaveutil. Unfortunately weave create-bridge, intended for use when docker isn't running (so that users can configure docker to use weave's bridge), relies on this function; consequently we need to provide another way for such users to continue using weave for L2 bridging between docker bridges. This PR implements weave attach-bridge for linking an existing docker0 bridge netdev with the weave bridge, obtaining the same functionality; furthermore, it has the advantage of working with fast datapath, which the previous create-bridge method did not.

Addressed comments.

Is weave attach-bridge idempotent? It should be.

I think it's worth up to ~1 hour of our time trying to write a test for this. e.g. check that two containers on different hosts can communicate, and also check the idempotence. Tricky bit is (re)starting docker with custom allocation ranges.

Tricky bit is (re)starting docker with custom allocation ranges.

This will require #1747, which I have just spent some time investigating, however the best solution I can come up with depends on #1212.

I think it's worth up to ~1 hour of our time trying to write a test for this

Not going to happen, given the above.

Tested with --fixed-cidr=<IP_ADDRESS>/24 and --fixed-cidr=<IP_ADDRESS>/24 on different hosts.