Read Timeout Value from http.Server

Issue: #410
Server timeout implementation, mostly following http2 implementation.
Also two extra HandleFunc has been added to example/main.go server, to test the write timeout.
Thanks,
Omid.

@ohoushar, thank you for the PR! I don't think we need to make any changes to the quic package. Can we just set the AfterFunc in the http3 package?

Codecov Report

Merging #2562 into master will decrease coverage by 0.09%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##           master    #2562      +/-   ##
==========================================
- Coverage   86.17%   86.08%   -0.09%
==========================================
  Files         122      122
  Lines        9550     9590      +40
==========================================
+ Hits         8229     8255      +26
- Misses        983      992       +9
- Partials      338      343       +5

Impacted Files
Coverage Δ

http3/server.go
65.81% <70.00%> (+0.72%)
:arrow_up:

server.go
82.98% <0.00%> (-0.61%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa69438...7c26dea. Read the comment docs.

@marten-seemann did you have a chance to review the changes? Any comment?
Thanks.

Can you please remove the unneccessary commits? First of all, there's no need to modify the .gitignore. Then, please don't merge master into a feature branch. Please do a rebase instead.

Sure.


Unable to connect to HTTPS Jira server

The following curl command to Jira works:
curl -X GET -H "Authorization: Basic XXX" -H "Content-Type: application/json" "https://xxx/rest/api/2/issue/{ISSUE}"
However from the code it throws this exception:
at fr.mmarie.resources.HookResource.lambda$hook$0(HookResource.java:53) ~[gitlab-jira-integration-application-0.5.0-SNAPSHOT.jar:na]
! at java.lang.Thread.run(Thread.java:745) ~[na:1.8.0_60]
! Suppressed: javax.net.ssl.SSLProtocolException: handshake alert:  unrecognized_name
! 	... 28 common frames omitted
WARN  [2015-10-21 11:23:12,487] fr.mmarie.core.IntegrationService: Issue  has been mentioned, but does not exists
It looks like you're building the OKHttpClient correctly

My bad, it's not and issue. I need to add SSL certificate to the server


yubikey-manager: rework packaging

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 247883 run on x86_64-linux 1

5 packages built:

gen-oath-safe
yubikey-manager
yubikey-manager.dist
yubioath-flutter
yubioath-flutter.debug


Cannot run "Blur using Framebuffer Depth" example

Most appropriate sections of the p5.js website?
Examples
What is your operating system?
Mac OS
Web browser and version
Chrome: 114.0.5735.198 (Official Build) （arm64）
Actual Behavior
Cannot run "Blur using Framebuffer Depth" example.
Cause 1:
https://p5js.org/assets/js/p5.min.js version is 1.6.0
Cause 2:
Demo source code has 2 errors.
Expected Behavior
Can run "Blur using Framebuffer Depth" example.
for cause 1
Is cause 1 a server problem?
I could not find out.
for cause 2
I will send you a pull request for cause 2.
It has been tested on a Japanese translation test site we are working on.
(Sorry, only English and Japanese work here.)
https://p5js-i18n-ja.pages.dev/examples/3d-blur-using-framebuffer-depth
Steps to reproduce
open https://p5js.org/examples/3d-blur-using-framebuffer-depth.html
Would you like to work on the issue?
Yes. I will pull request for "Cause 2".

Does anyone know where https://p5js.org/assets/js/p5.min.js comes from? It seems like the file in this repo is already 1.7.0: https://github.com/processing/p5.js-website/blob/4dccc99006f66bd14ed7e73328c181899db4a89e/src/assets/js/p5.min.js#L1

Hey @davepagurek, you can find more info about the release process in this release_process.md doc and the p5.js release GitHub action.

Hi!
I have found additional info:
The header information of https://p5js.org/assets/js/p5.min.js is as in the image below:

Is there a cache of the file on cloudflare?
I was able to retrieve v.1.7.0 by accessing https://p5js.org/assets/js/p5.min.js?v=unique-yyyymmddhhmmdd

Adding @limzykenneth to this discussion as well!

It probably is cloudflare still caching the file. To fix it for now a cache clear can be done on Cloudflare, @Qianqianye let me know if you are not sure how that is done.
For longer term fix, we can either include query string like we do for some other assets on the website, or we can reduce the cache valid time which is rather long at the moment.

I just cleared the cache on Cloudflare for now. https://p5js.org/assets/js/p5.min.js is now v.1.7.0
Yes, let's fix this issue for next release.

Great catch @shibomb!

Just to follow up on this issue, since we are planning the 1.8.0 release. Shall we fix it for the upcoming release or this is something we can hold off till the upcoming p5.js website redesign and redevelopment project? @limzykenneth @davepagurek @shibomb

The example source code can be corrected with a PR. I'll see if the Cloudflare cache need to be modified later.

@Qianqianye @limzykenneth @davepagurek
I have made a pull request for ideas to solve this problem.
https://github.com/processing/p5.js-website/pull/1427
Could you please check?

Hi @shibomb, please see comment on the PR. In short I think the main thing to fix will just be the second problem instead of the first. Thanks!

Hi @shibomb, please see comment on the PR. In short I think the main thing to fix will just be the second problem instead of the first. Thanks!

Thank you for your quick reply.
It looks like you were able to change the cache settings in cloudflare.
It is indeed a good idea to solve the problem on the environment side.
Thanks.


export_core_vtk_line error

I am sorry but when I try mydholedb.export_core_vtk_line('CMP', 'cmp.vtk') in the tutorial, the result is
AttributeError                            Traceback (most recent call last)
<ipython-input-29-09f1873a59b1> in <module>()
      3 #mydholedb.export_core_vtk_line('CMP', 'cmp.vtk', nanval=0, title = '')
      4 #see(mydholedb.export_core_vtk_line)
----> 5 mydholedb.export_core_vtk_line('CMP', 'cmp.vtk')

cython_code/drillhole.pyx in pygslib.drillhole.Drillhole.export_core_vtk_line (cython_code/drillhole.c:32985)()

cython_code/drillhole.pyx in pygslib.drillhole.Drillhole.export_core_vtk_line (cython_code/drillhole.c:32636)()

AttributeError: SetInputData

Can you please check the VTK version you are using? For example, using this code:
from __future__ import print_function
import vtk
print(vtk.vtkVersion.GetVTKSourceVersion())

I was not able to reproduce this error with VTK 6.3 and Python 2.7 or VTK 7. and Python 3.5.

Ok, it don't work with VTK  5.10.1 but yes with VTK 7 (Python 2.7.x)

Hi mlaloux,
Thank you for let me know. I added requirement for VTK >= 6 at conda recipes (*.yaml files).

I am getting similar error while using  pygslib <IP_ADDRESS>.0 and vtk 7.1.1.
Please suggest me a solution, thanks
Traceback (most recent call last):
File "", line 1, in
runfile('C:/Users/MSI/.spyder/temp.py', wdir='C:/Users/MSI/.spyder')
File "C:\Users\MSI\Anaconda2\envs\py2.7\lib\site-packages\spyder_kernels\customize\spydercustomize.py", line 704, in runfile
execfile(filename, namespace)
File "C:\Users\MSI\Anaconda2\envs\py2.7\lib\site-packages\spyder_kernels\customize\spydercustomize.py", line 93, in execfile
exec(compile(scripttext, filename, 'exec'), glob, loc)
File "C:/Users/MSI/.spyder/temp.py", line 35, in
mydholedb.export_core_vtk_line('CMP', 'cmp.vtk', title = 'Drillhole created in PyGSLIB')
AttributeError: 'pygslib.drillhole.Drillhole' object has no attribute 'export_core_vtk_line'

Hi @lltnryn export_core_vtk_line was renamed intervals2vtk. Sorry for any inconvenient, I should probably create an alias function to ensure back compatibility.


Holidays for Malta

Good morning :)
Can we get holidays for Malta please?

Good morning!
Unfortunately, this ain't no restaurant, so no orders accepted, sorry :-)
In order to have your request satisfied, I would suggest you to provide your preferred degree of contribution to the project (holidays information / code implementation / unit tests): the more contribution you provide, the more likely to see the work done in a short time.
Best regards, have a nice day!


How to get stable set of properties from the Spring Cloud Config Server when trying to fetch properties from multiple sources

I have a requirement to fetch stable set of properties from Spring cloud config server. Example : I have configured multiple like spring.profiles.active=jdbc,git. So, as per the priority the cloud config server fetches properties from JDBC i.e, from properties table and later it will fetches from git repository. The org.springframework.cloud.config.server.environment.CompositeEnvironmentRepository#findOne(java.lang.String, java.lang.String, java.lang.String, boolean) method is consolidating in to a Environment object containing List propertySources. In this case the list is multiple PropertySource objects. Problem statement: I have a property called app.scheduler.timeout=9000 in properties table(JDBC backend) and the same property is also present in the git -profile.properties file as app.scheduler.timeout=9001. If you see the final Environment object, it will have the properties in both the PropertySources. I know that the merging will be done at the Cloud Config Client Side by preparing the bootstrap property source.
Is there any way we can prepare or get only stable set of propertySource from the Spring Cloud Config Server itself? i.e, single propertySource object in the List.
Note: In the above example I have mentioned only one property but I want this merging should happen for all the properties in response sent to the cloud config client.

I am not sure what you mean by "stable set of propertySource".  Depending on the order of the backends specified that will determine the order of the property sources and which ones will take priority.

Thank you for replying @ryanjbaxter. Let me elaborate the scenario.
Based on the property spring.profiles.active=jdbc,git the cloud config server fetches the List propertySources (based on the order configured for the respective profile) and returns org.springframework.cloud.config.environment.Environment object in response to the Cloud Config Client.
Consider, I have a property configured for the application i.e., "app.scheduler.timeout=9000" and inserted same in the properties table as I am fetching from JDBC Backend. I have added the same property in the -.yml present in the git repository with a different value i.e., "app.scheduler.timeout=9999". If I request for latest properties from the Cloud Config Client then the Cloud Config Server will return org.springframework.cloud.config.environment.Environment object containing List propertySources. In this scenario, I will have atleast 2 PropertySource in the list(One from the JDBC and another one from git .yml file). As per the design the property value "app.scheduler.timeout=9000" from JDBC will take precedence due to the higest priority/precedence order given to it. In the Cloud Config client side it will consider this property and the property from the git file will be ignored for the property "app.scheduler.timeout".
Here my question is: Can we get single PropertySource inside the environment response object instead of List?
Do we have any option to merge the List (in my case there are more than 2 PropertySource objects inside the List) into a single PropertySource based on the priority in Cloud Config Server side?
Or any hook points to customize the code to get the desired result?
As I feel it's a redundant property for the git source which is going to be ignored by the Cloud Config Client anyways.
Is there any other way to achieve this in Cloud Config Server so that I will get consolidated/single PropertySource inside the Environment object from the Cloud Config Server which will have properties merged from both JDBC backend and Git(redundant properties will be discarded based on priority)?
Please let me know if you need any other details.
Thanks in advance!

Can we get single PropertySource inside the environment response object instead of List?

Why?  It sounds like you just want to discard properties that wont be used by the Spring Boot app.

No, Not exactly. Here I am just trying to suppress/ignore the redundant properties from the List of PropertySources.
Below is the example code what I wrote(just for reference).
I have added a custom Environment controller and called the Spring cloud config server EnvironmentController from this:
`@RequestMapping(path = "/{name}/{profiles}/{label:.*}", produces = MediaType.APPLICATION_JSON_VALUE)
public Environment labelled(@PathVariable String name, @PathVariable String profiles, @PathVariable String label) {
Environment environment = environmentController.labelled(name, profiles, label);
return mergeProperties(null);
}
private Environment mergeProperties(Environment environment) {
    if(null != environment.getPropertySources() && !environment.getPropertySources().isEmpty()){
        List<PropertySource> propertySources = environment.getPropertySources();
        Collections.reverse(propertySources);
        Map<String, String> sourceMap = new LinkedHashMap<>();
        propertySources.forEach(propSource -> {
            if(null != propSource.getSource() && !propSource.getSource().isEmpty()){
                propSource.getSource().forEach((propName, propVal) -> sourceMap.put(String.valueOf(propName), String.valueOf(propVal)));
            }
        });
        String name = isEmptyString(environment.getName()) ? "" : environment.getName();
        String profile = isEmptyString(String.join(",", environment.getProfiles())) ? "" : String.join(",", environment.getProfiles());
        PropertySource propertySource = new PropertySource(name +"-"+profile, sourceMap);
        environment.getPropertySources().clear();
        environment.getPropertySources().add(propertySource);
    }
    return environment;
}`

The above code will reverses the PropertySource list and creates new propertySource from that by overriding the existing keys and values in the map.
I know the above implementation looks dirty. I am looking for some way of hook point or customization option to handle the above scenario.

Additional Information:
Let me give you an example:
Exactly, If the Cloud Config Client anyways going to discard the properties which are already present in the PropertySource of higher precendence then that property is no longer required for the cloud config client.
Consider the below example:
The cloud Config Client is making below call to the Cloud Config Server.
http://localhost:8888/sample-service/dev
The Cloud Config Server has spring.profiles.active=jdbc,git
I have created and added below properties to the PROPERTIES table:
ibs.threadpool_min_size=10
ibs.threadpool_size=50
app.scheduler.timeout=9000
In the same way I have git cloned in the Cloud Config Server and have sample-service-dev.yml file in the cloned repo.
ibs.threadpool_max_size=100
ibs.threadpool_queue_size=100
ibs.threadpool_core_size=25
app.scheduler.timeout=9999
If I execute the above URL, Firstly the properties will be fetched from JDBC as the order for JDBC is 1 and later it will fetch from the git location as the order is given is 2. The cloud config server is going to return an Environment object which contains list of PropertySources one from JDBC and another one from class path source from git location.
Here what I am expecting is the PropertySource from JDBC should only have all the 3 properties from the table. And the second PropertySource from Git repo should have only 3 properties i.e,
ibs.threadpool_max_size=100
ibs.threadpool_queue_size=100
ibs.threadpool_core_size=25
as these properties are not fetched from the JDBC table.
the last property i.e, app.scheduler.timeout=9999 should be ignored/removed in the Cloud Config server itself before returning to the Cloud Config Client application. as these property is only referred/used in the client application which was provided by the JDBC propertySource.
Is there any way to do this? what I feel is, the PropertySources should be merged based on the order/priority (into single propertySource or list of PropertySource). I want only final set of properties here from the Cloud Config server.
Currently, I am trying to customize this but unable to get proper hook point to do this.
Any help will be appreciated to achieve the above.

I would start here
https://github.com/spring-cloud/spring-cloud-config/blob/main/spring-cloud-config-server/src/main/java/org/springframework/cloud/config/server/environment/CompositeEnvironmentRepository.java#L62

Thank you for replying ryanjbaxter.
Can you please give a sample code? I tried to do customization for the above mentioned class but It didn't help.
Can you please give me more inform with same sample code?
Thanks in advance.

If you provide your own CompositeEnvironmentRepository bean our default configuration should not kick in
https://github.com/spring-cloud/spring-cloud-config/blob/b62216d814f8bfccb8c0c27024f82175a8993282/spring-cloud-config-server/src/main/java/org/springframework/cloud/config/server/config/CompositeConfiguration.java#L38

Thank you for replying Ryan. But still the flow goes through the CompositeEnvironmentRespository class. and \my CustomCompositeEnvironmentRespository bean repository has been added to the repository list of CompositeEnvironmentRespository class for iteration. Below is the bean I have added:
@Bean     @ConditionalOnMissingBean(SearchPathLocator.class)     public CustomCompositeEnvironmentRepository customCompositeEnvironmentRepository() {         return new CustomCompositeEnvironmentRepository(this.environmentRepos, properties.isFailOnCompositeError());     }
I have also added CustomCompositeEnvironmentRepository class(which is a code replica of CustomCompositeEnvironmentRepository class)
as per your above comment It should go through my custom code for fetching the properties to run in loop similar like .CompositeEnvironmentRepository's findOne method.
Do I am missing anything here? Please let me know. Thank you!

Can you try returning CompositeEnvironmentRepository in your Bean declaration instead of CustomCompositeEnvironmentRepository?
If that doesn't work can you provide a sample so I can take a look?

@ryanjbaxter
I tried returning CompositeEnvironmentRepository in your Bean declaration instead of CustomCompositeEnvironmentRepository. But it didn't help.
I am able to create a CustomCompositeEnvironmentRepository bean and CompositeEnvironmentRepository bean is not getting called from CompositeConfiguration class.
But from the environment controller, the call is still going to org.springframework.cloud.config.server.environment.CompositeEnvironmentRepository#findOne(java.lang.String, java.lang.String, java.lang.String, boolean)
ans newly added CustomCompositeEnvironmentRepository object is being added to the environmentRepositories and iterated further.
you can refer to the code in the below link:
https://github.com/Santhoshinftech/cloud-config-custom-svc
Please correct me if I am doing anything wrong. thanks!

CustomCompositeEnvironmentRepository should extend ComponsiteEnvironmentRepository.
Then in your configuration class add @AutoConfigureBefore(EnvironmentRepositoryConfiguration.class).
And you bean should be defined as follows
    @Bean
    @Primary
    @ConditionalOnMissingBean(SearchPathLocator.class)
    public CompositeEnvironmentRepository customCompositeEnvironmentRepository() {
        return new CustomCompositeEnvironmentRepository(this.environmentRepos, properties.isFailOnCompositeError());
    }

That appears to work.

Hi @ryanjbaxter ,
Thank you! the above solution worked for me. Now I am able to configure CustomCompositeEnvironmentRepository.
The code changes for the same is updated in the below Github repo for reference:
https://github.com/Santhoshinftech/cloud-config-custom-svc
Thanks again.

Great glad that helped!

Hi @ryanjbaxter ,
I continued with integrating other profiles like Git and Vault.
Here, I am seeing an issue with the above code changes.
Previously, I only integrated JDBC and Native profiles and it worked fine.
Now, If I add Git profile with JDBC and Native profile in the Cloud Config Server I am getting the below error in the application start:
`***************************
APPLICATION FAILED TO START

Description:
Parameter 0 of method resourceRepository in org.springframework.cloud.config.server.config.ResourceRepositoryConfiguration required a single bean, but 2 were found:
- nativeEnvironmentRepository: defined by method 'nativeEnvironmentRepository' in class path resource [org/springframework/cloud/config/server/config/NativeRepositoryConfiguration.class]
- defaultEnvironmentRepository: defined by method 'defaultEnvironmentRepository' in class path resource [org/springframework/cloud/config/server/config/GitRepositoryConfiguration.class]
Action:
Consider marking one of the beans as @Primary, updating the consumer to accept multiple beans, or using @Qualifier to identify the bean that should be consumed
`
Without the previous custom code changes it is working without any issues.
I tried to find a solution, but nothing helped.
Can you please help me in fixing this issue?
I have added the application.properties change and pushed to the below repository:
https://github.com/Santhoshinftech/cloud-config-custom-svc
Thanks in advance.

@ryanjbaxter , Tried the solving the issue by referring https://github.com/spring-cloud/spring-cloud-config/issues/984 but this also didn't help.
Can you please help me in this?

I am busy getting ready for Spring One this week I will try and get back to you next week

Can you try defining your composite configuration using spring.cloud.config.server.composite? https://docs.spring.io/spring-cloud-config/docs/current/reference/html/#composite-environment-repositories

Hi @ryanjbaxter ,
Not sure how, but after defining composite configuration using spring.cloud.config.server.composite it worked.
Thanks a lot.


launch browser example

Overview
Add a button that launches the Edge browser. This demonstrates that the browser slate can be launched while your application continues running. The web page that is launched contains controls modeled after the Unity GUI controls in the examples, showing a button, checkbox, slider, dropdown, and edit box. This demonstrates the option of integrating with existing web tools or of creating simple form UI using HTML and shows what this kind of interaction would feel like.
Note that I originally implemented this by calling the UWP LaunchUriAsync API, but later found out that is unnecessary because Unity's Application.OpenURL seems to work just as well.
Changes

Fixes: #2934.

Verification
Note that this references a web page in order to demonstrate using web controls from within a browser. Because I didn't want to host a web site for this purpose, I am linking to a page on github. That page won't exist unless this PR is first merged to mrtk_development.
If you would like to try this change locally, you can change the URL to point to the HTML file in my fork as follows:

In HandInteractionExamples.unity, select the SceneContent/LaunchBrowserButton object.
In the inspector, scroll down to the Interactable OnClick event. Change the URL to the following: http://htmlpreview.github.io/?https://raw.githubusercontent.com/ForrestTrepte/MixedRealityToolkit-Unity/feature/launchBrowser/Assets/MixedRealityToolkit.Examples/Demos/HandTracking/WebForm/SampleWebForm.htm.

Note that I originally implemented this by calling the UWP LaunchUriAsync API, but later found out that is unnecessary because Unity's Application.OpenURL seems to work just as well.

Could you please still include the LaunchUriAsync example as well (perhaps a button next to the webpage button that opens settings by launching ms-settings://)? That will teach people that you can actually launch any UWP as long as it implements a protocol.

Could you also please include a screenshot of the new button you added to the scene as part of this PR, so we can find it and also visually review the code? Even better would be a gif of the new behavior, if you have time. For example, here's a really nice PR that demonstrates new features: https://github.com/microsoft/MixedRealityToolkit-Unity/pull/4532

I'd be happy to capture a gif if there's an easy way to do that. Is there a tool that folks recommend for converting the .mp4 from a mixed reality capture into a gif? Would I need to make it super-short so that the file size isn't too large for github? @Cameron-Micka, please let me know if you have any tips for doing this.

@ForrestTrepte I've just been using the tool @jwittner recommends called LICEcap. GitHub only accepts files up to 10Mbs, so if I find I'm over that limit I resize and/or compress my gif from LICEcap with this online tool: https://ezgif.com/resize

The latest implementation includes two buttons for launching aka.ms/mrdocs and settings.

@julenka: Ready for re-review.

/azp run mrtk_pr

/azp run mrtk_pr

How to locate the launched browser to the specified location？

@csxbwang - in my experience the window is spawned by the OS in a "follow" mode and stays in my view until I pin it.

@csxbwang - in my experience the window is spawned by the OS in a "follow" mode and stays in my view until I pin it.

Can I write codes to control the launched window, for example, automatically pin it and translate it to pre-defined location by attaching a world anchor?

...I'm not to sure, but I think so
**FirstLostLastFound°°
On Tue, Sep 22, 2020, 4:16 AM csxbwang<EMAIL_ADDRESS>wrote:

@csxbwang https://github.com/csxbwang - in my experience the window is
spawned by the OS in a "follow" mode and stays in my view until I pin it.
Can I write codes to control the launched window, for example,
automatically pin it and translate it to pre-defined location by attaching
a world anchor?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/MixedRealityToolkit-Unity/pull/5047#issuecomment-696656522,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKK4QQNPQATDNWMHJV2LMULSHCBQJANCNFSM4H3L3RQA
.

@csxbwang - not something I've tested, but looking at the APIs I don't believe so. You're effectively launching a URI directly into the system and then letting it do it's thing. I'm not certain there aren't APIs for controlling external applications, but due to the sandbox nature of UWP I'm not optimistic they exist.

In addition to not being able to position the launched program/browser. It seems you can only launch one (at least using  LaunchUri). Any thoughts on how to launch multiple?

In addition to not being able to position the launched program/browser. It seems you can only launch one (at least using  LaunchUri). Any thoughts on how to launch multiple?

Note that this is an old (merged) pull request. @paulparkinson, for posterity, if you don't receive an answer here you may want to open a feature request issue.

Note that this is an old (merged) pull request. @paulparkinson, for posterity, if you don't receive an answer here you may want to open a feature request issue.


Streamline install process

This branch reduces the number of steps to get the app up and running from scratch.
It changes installs, and adds a Makefile with the make setup shortcut to get everything running.
It allows the following install and setup process (also written in README.md):

Quick local installation using Make
First, create a virtualenv and activate it. Then:
git clone git@github.com:codeforamerica/pittsburgh-purchasing-suite.git
# create the 'purchasing' database
psql -c 'create database purchasing;'
# set environmental variables - it is recommended that you set these for your
# your virtualenv, using a tool like autoenv or by modifying your activate script
export<EMAIL_ADDRESS>export CONFIG=purchasing.settings.DevConfig
# this next command will do all installs, add tables to the database,
# and insert seed data (note that this needs an internet connection to
# scrape data from Allegheny County)
make setup
# start your server
python manage.py server

:+1: thanks @bengolder !


RuntimeError: CUDA failed with error CUDA driver version is insufficient for CUDA runtime version

Occurs in the third cell of demo_part3.ipynb. How do I fix it?
python3.9
OpenVoice v2
Windows 11 Pro 64 bit
GPU: Radeon RX 580 Series
CPU: AMD Ryzen 5 3600 6-Core Processor
RAM: 32 GB

设置 vad=True
target_se, audio_name = se_extractor.get_se(reference_speaker, tone_color_converter, vad=True)


Recent changes (v0.3.3 and v0.3.4) might have made plasnet slow for very large graphs

... we might need to optimise how we get blackhole plasmids

this is being investigated

Confirmed, this has to be fixed


Edge Padding

Is there a way to make the edge padding only on a side where there are more slides available.
i have for example the autoplay and loop set to false. and edgepadding to 30 now in initial state it's showing half a slide on the left hand side, while there shouldn't be any.
Don't know if this feature is available at the moment and if i'm doing something wrong?

edgePadding works a little bit different with what you expected.
When it's set to true, there are always half of slides on the left and right even in initial status.

We had a similar issue, but we actually did something like this:
{ 	480: { 		items: 1.2 	}, 	768: { 		items: 2.2 	}, 	992: { 		items: 2.2 	}, 	1200: { 		items: 3.2 	}, }
This produces a negative margin on the right item but not on the last item in the slider.

@viktorlarsson
Your idea is interesting. I didn't expect it can be used this way, but it seems a good solution.

We we're actually joking like "it would be nice to do this" and put the number in and accidently pressed save and live reload kicked in and then it worked :D

It would make sense that the edgePadding only on right side if loop set to false refer to OwlCarousel2 stagepadding.
I will work on this when I have more time recently.

Removed left edgePadding when loop: false from v2.3.8


GPUImageView over 2048x2048 doesn't show GPUImagePicture

Hi Brad,
First of all I would like to thank you so much for this awesome framework.
So, I'm having this problem and I can't figure out what's going on, I would really appreciate if you could help me out.
I'm loading an image from the camera roll and resizing it so it's size is smaller than GPUImageContext.maximumTextureSizeForThisDevice() and creating a thumbnail so I can preview the filters, which are being              filterOperation.filter.forceProcessingAtSizeRespectingAspectRatio(SizeOfThumbnail). After that I go to another view and create a GPUImageView with the size of the original image (lesser than GPUImageContext.maximumTextureSizeForThisDevice()) and then I add it to a scroll view. The problem is that the image doesn't appear after I do a processImage, but if I resize the image to be lesser than 2048 the image appears. Below it's the code.
   if GLint(image.size.width) > GPUImageContext.maximumTextureSizeForThisDevice() ||
       GLint(image.size.height) > GPUImageContext.maximumTextureSizeForThisDevice() {
        let biggestSize = (image.size.width > image.size.height) ? image.size.width : image.size.height

        let newSize = CGSizeMake(image.size.width * CGFloat(GPUImageContext.maximumTextureSizeForThisDevice()) / biggestSize, image.size.height * CGFloat(GPUImageContext.maximumTextureSizeForThisDevice()) / biggestSize)
        UIGraphicsBeginImageContextWithOptions(newSize, false, 0.0)
        image.drawInRect(CGRectMake(0, 0, newSize.width, newSize.height))
        self.originalImage = UIGraphicsGetImageFromCurrentImageContext()
        UIGraphicsEndImageContext()
    }
    else {
        self.originalImage = image
    }

    self.sizeOfImage = CGSize(width: self.originalImage!.size.width, height: originalImage!.size.height)

    let newSize = CGSizeMake(1024.0 , image.size.height * 1024.0/image.size.width)
    UIGraphicsBeginImageContextWithOptions(newSize, false, 0.0)
    image.drawInRect(CGRectMake(0, 0, newSize.width, newSize.height))
    self.thumbnail = UIGraphicsGetImageFromCurrentImageContext()
    UIGraphicsEndImageContext()

    self.media = GPUImagePicture(image: self.thumbnail)

    for filterOperation in filterOperations {
        self.media?.addTarget(filterOperation.filter as! GPUImageInput)
        filterOperation.filter.forceProcessingAtSizeRespectingAspectRatio(newSize)
    }

The other view
    self.media = GPUImagePicture(image: self.originalImage)

    self.imageView = GPUImageView(frame: CGRectMake(0, 0, self.sizeOfImage.width, self.sizeOfImage.height))

    media?.addTarget(choosenFilter.filter as! GPUImageInput)
    choosenFilter.filter.addTarget(self.imageView)

    self.scrollView.addSubview(self.imageView)
    self.view.sendSubviewToBack(self.scrollView)

    self.imageView.backgroundColor = UIColor.clearColor()
    self.imageView.setBackgroundColorRed(0.0, green: 0.0, blue: 0.0, alpha: 0.0)

    self.setMainScrollViewZoom()
    self.scrollView.contentSize = CGSizeMake(self.sizeOfImage.width, self.sizeOfImage.height)
    (self.media as? GPUImagePicture)?.processImage()

As I've said before, if I change GPUImageContext.maximumTextureSizeForThisDevice() for 2048, everything work's perfectly.
Thanks

Having the same issue here, if I initiate GPUImageView with a size higher than 2048x2048, I get no image. I think it might be related to screen scale being 2 which gives 4048x4048 which is the maximum texture size.
You might want to look into forceProcessingAtSize; as discussed here, https://github.com/BradLarson/GPUImage/issues/1387. You may be able to get rid of the bound checks that way

If I do a forceProcessingAtSize it doesn't change anything, I still got nothing.
I've been testing on my iPhone 4, and it has the same problem BUT instead of 2048 it passes to 1024, so I believe it really does have something to with the screen scale, as on different devices the limitation is always maximum texture divided by 2.

For iPhone 6 plus the maximum size at which GPUImageView keeps working is 4096 divided by 3 = 1365 points in any dimension, which is significant limitation IMO. Looking forward to this issue being fixed!

I had to use UIImageView instead of gpuimageview and render an image and set it to imageView every time a filter/effect is changed. This is definitely not the best solution but its better than 1650px resolution for iPhone 6 plus

Here is a workaround I found:
NSInteger maxSize = [GPUImageContext maximumTextureSizeForThisDevice] / [UIScreen mainScreen].scale;
if (self.bounds.size.width > maxSize || self.bounds.size.height > maxSize) {
   // For hack it, set lower frame, and apply transform scale
   CGFloat scale = MIN(maxSize / self.bounds.size.width, maxSize / self.bounds.size.height);

   CGFloat xInset = (self.bounds.size.width - scale * self.bounds.size.width) / 2.0;
   CGFloat yInset = (self.bounds.size.height - scale * self.bounds.size.height)  / 2.0;
   CGRect frame = UIEdgeInsetsInsetRect(self.bounds, UIEdgeInsetsMake(yInset, xInset, yInset, xInset));

   self.overlayGPUImageView.frame = frame;
   self.overlayGPUImageView.transform = CGAffineTransformScale(CGAffineTransformIdentity, 1/scale, 1/scale);
} else {
   self.overlayGPUImageView.transform = CGAffineTransformIdentity;
}


Generalise get_, fetch_ and find_* functions

Summary:
Currently, in OpenHiven.py the get_* and fetch_* functions are used to fetch cached instances, while the get_*  functions were supposed to bring the data from the Hiven Server and then return the updated versions of the cached models.
This was useful since sometimes data was missing and the system was not finished yet, so using the requests as backup seemed like the right solution. Still, after new updates and with the release of version v0.1.3 this will become a deprecated solution since it slows down the finding process and does not utilise the cache as wanted.
Therefore, a new planned-out system is needed that should align with the planned cache system (#53), where data is not stored anymore in entire instances but instead just in simple plain JSON / dictionary format.
Planned Generalisation:
The newly planned system will then use three functions which one of will be entirely new:

First the standard get_* function, which is also used in discord.py to fetch instances. This method will likely stay the same but receive a new system under the hood, where the data is fetched directly from the cache and then returned in the instance form so the user can utilise the function of the class.

Second the async fetch_* function, which will be the updated then used to fetch and request the Hiven Server's data. This function should then be used to fetch data that might be not entirely complete. The function will return the new instance of the requested data.

Third and last the new find_* function, which is a relatively low-level function and will also be used inside the get_* function to find the requested object's cached dictionary. The process is relatively simple, and it will simply return a new copied dictionary of the cached data.
The function should be used for usage cases where instances and functions are not important and for example only the name or the location of an Hiven object is needed since you only get the raw data and not an instance of the object class.
If the user then requires an instance with the data, they can create themselves a new instance of the object based on the data, still for readability and ease it will be recommended to use get_* in the first place whenever functions of the class might be needed!

Added with 01efbdaff216a698f38b4629807a7d924bd56a4f the basic Structure in HivenClient


[FLINK-10205] [JobManager] Batch Job: InputSplit Fault tolerant for DataSource…

…Task
Today DataSource Task pull InputSplits from JobManager to achieve better
performance, however, when a DataSourceTask failed and rerun, it will
not get the same splits as its previous version. this will introduce
inconsistent result or even data corruption.

Furthermore,  if there are two executions run at the same time (in batch
scenario), this two executions should process same splits.

we need to fix the issue to make the inputs of a DataSourceTask
deterministic. The propose is save all splits into ExecutionVertex and
DataSourceTask will pull split from there.

Change-Id: Ifd9ac2639d0a3a919269552dbd3b7f0b689f1c25
Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.
Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.
Contribution Checklist

Make sure that the pull request corresponds to a JIRA issue. Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.

Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where FLINK-XXXX should be replaced by the actual issue number. Skip component if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: [hotfix] [docs] Fix typo in event time introduction or [hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator.

Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.

Make sure that the change passes the automated tests, i.e., mvn clean verify passes. You can set up Travis CI to do that following this guide.

Each pull request should address only one issue, not mix up code from multiple issues.

Each commit in the pull request has a meaningful commit message (including the JIRA id)

Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.

(The sections below can be removed for hotfixes of typos)
What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)

The TaskInfo is stored in the blob store on job creation time as a persistent artifact
Deployments RPC transmits only the blob storage reference
TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (100MB)
Extended integration test for recovery after master (JobManager) failure
Added test that validates that TaskInfo is transferred only once across recoveries
Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@isunjin Please fill out the PR template.

In the JIRA a design document was explicitly requested. Is this accessible anywhere?

I have my document ready, but I don’t have permission to edit the wiki, Stephan, could you grant me the permission?
https://cwiki.apache.org/confluence/display/FLINK/Flink+Improvement+Proposals https://cwiki.apache.org/confluence/display/FLINK/Flink+Improvement+Proposals
Jin

On Sep 5, 2018, at 8:47 PM, Chesnay Schepler<EMAIL_ADDRESS>wrote:
In the JIRA a design document was explicitly requested. Is this accessible anywhere?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/apache/flink/pull/6657#issuecomment-418717373, or mute the thread https://github.com/notifications/unsubscribe-auth/ACjL1YBHKtmJAUaB3uv-rM3ccFpo0YRQks5uX8fFgaJpZM4WaIOt.

@isunjin It seems that you don't need to have permission to edit the wiki right away. You can write the document through Google Doc and give others access permission, and then others can discuss and review it. When the community feels that the design document is ok, it is not too late to edit the wiki. @zentol right?

I have put the the document here, note that the document not only include this issue, but includes other failover improvements:
https://docs.google.com/document/d/1FdZdcA63tPUEewcCimTFy9Iz2jlVlMRANZkO4RngIuk/edit?usp=sharing


Repeating Items, and ListSettingsDialog title changed

I changed the title of the ListSettingsDialog from "Enter a List Title" to "Edit List Settings."
Points, questions, etc.:

Design change:
Before this PR, the app would load all the list models every build. However, in this PR, I changed that because that means that the previously loaded Item objects (each of which could potentially have a timer object which is not stored in (and loaded from) the database) would be thrown away each build, which could leave Timer objects running outside of the program's reach and which can't be cancelled.
What I decided to do instead was create a future which loaded all the ListModels into a field, called data. Then, when a ListModel is added or deleted, we add/delete that ListModel from data. What do you think of this design?
Code smell:
I put the scheduledTimeStamp, scheduledTimer, and repeatConfiguration fields all in Item. All of them are "independently" nullable, but, in a correctly functioning program, repeatConfiguration and scheduledTimer should always be null if scheduledTimeStamp is null. Do you think we should group them together into a single object? Something like:

@embedded
class ItemScheduling{
  DateTime scheduledTimeStamp;
  Timer? scheduledTimer; // Maybe non nullable?
  RepeatConfiguration? repeatConfiguration;
}

Possible feature:
Do you think we should make the chip which shows the next scheduledTimeStamp, when pressed, pull up the RepeatDialog?

Edit:
One last thing:
At the current moment, when displaying the scheduledTimeStamp in an item, I am using a very simple DateFormat, just displaying the month and day unconditionally. I see Google Tasks does something a little more complex, displaying the time (if it was selected), possibly the year, or just displaying "Today" or "Tomorrow."
Closes #32

Do you think we should group them together into a single object?
Yes!

Do you think we should make the chip which shows the next scheduledTimeStamp, when pressed, pull up the RepeatDialog?

That sounds nice

Sorry I'll be pretty busy with the other project this week so no promises about when I can review this.

Sorry I'll be pretty busy with the other project this week so no promises about when I can review this.

Of course! That's much more important. Besides, you have no obligations to tend to me anyway.

Another "last thing": should the scheduledTimer's callback reset the scheduledTimer?

I think I found a bug in my code. Looking into it...

Alright, I think I fixed it. I am starting to see why a project needs unit tests...

Sorry for the delay on this one, it's a bigger one and I haven't had time to look through it yet. There are some merge conflicts.

Phew! I think I fixed it.
Is it too late for adding unit tests for repeating items? If not, how would you advise I go about it? Where should I begin? How would the tests be structured?

You could try unit tests, but I would probably do it in a separate issue. Repeated items would fall outside of the normal scope of unit tests though, because they rely on time. Unit tests work best for testing that a thing gives the expected output, given some inputs. Repeated items rely on time, so their behavior would change based on the current time. It's not easily unit tested, it is more of what would be called an "integration" testing.
There are probably ways you could test repeated items using fake time somehow, but that would be an advanced topic and not something I would recommend trying when you are new to unit testing. Try adding unit tests for simpler parts of the app first.
I don't have a lot of experience with flutter unit testing. From working with other frameworks, the normal way to unit test things is to have a separate unit test file for each UI component file.

It is kind of strange that the UI allows you to set up repeat configuration on non-checkable items, but we can improve that in the future.

Oh, yeah, doesn't make much sense :)


Slow performance: possibly broken pdf

Tested environment:
Online demo ( Extension build number: 23 at the time )
Mac OS 10.9.2
Firefox 28.0
Safari 7.0.3(9537.75.14)
Chrome 34.0.1847.116
Opera 20.0.1387.82
Qt 5.2.0 (AppleWebKit/538.1)
Page-8 of the following file ( 63.98 MB ) takes very long to render.
https://www.dropbox.com/s/lytvx5og80zpwo1/testmat4.pdf
The page contains
Warning: Unsupported radial gradient.
during one of the test runs in Qt 5.2.0 environment I observed that after
Info: graphic state operator op
there's no output for some time until it finally finished rendering
Info: page=8 - getOperatorList: time=916877ms, len=0
Render results:
Firefox: loads fast, radial gradient missing
Safari: loads very slow, r g missing
Chrome: loads fast, r g missing
Opera: loads fast, r g missing
Qt 5.2.0: loads extremely slow, r g shown as plain filled circle
the issues I'd like to report are:

Slow loading in Safari
Broken image (missing pig face - http://imgur.com/ZIirwCk )

2.11.253 💖 seems to fix all missing Hangeul characters (syllabic blocks) still present in 2.8., 2.10.

I'm not really asking for some magical solution to make the problem go away instantly,
but rather "What the author should not be doing to their document" in layman's terms so
I can make suggestions to them.

Pages 8 and 13 have several thousands tiny images.

It could be similar too https://bugzilla.mozilla.org/show_bug.cgi?id=1731514.
@brendandahl wdyt ?

That one has 1289 patterns.


[WIP] Added new colors to labels palette for cvat-core

Motivation and context

This PR changed palette to make colors more distinct
Resolved #1584

How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[x] I have added description of my changes into CHANGELOG file
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
[x] I have linked related issues (read github docs)
[x] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Pull Request Test Coverage Report for Build 6059

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 65.415%

Totals

Change from base Build 6058:
0%

Covered Lines:
10994

Relevant Lines:
16394

💛  - Coveralls


Targeted fix for ok button

Targeted fix for https://github.com/microsoft/azuredatastudio/issues/9079

https://github.com/microsoft/vscode/pull/90269


Feature: Add manual approval process to verify members profile picture

Profile picture needs to be approved by Super User before uploading it to Cloudinary

but the profile picture has to be uploaded somewhere before the superuser approves it.
Maybe just upload it and then if the superuser disagrees we can revert back the changes and delete the profile picture from Cloudinary or we can add a key-value pair in the user object and it will turn true when the super user approves the picture.


Node.js: Support for breadcrumbs

Description
It'd be awesome to have official support for Breadcrumbs on Node.js.
Describe the solution you'd like
If I'm not mistaken, it should be as simple as removing some lines of code from the @bugsnag/node package.
Describe alternatives you've considered
Being sad - but I didn't like that option... so I hope that's not the route you take. 😂
Additional context
I wasn't even aware that it was disabled until recently - as I was under the impression that it had been supported for years now. At work we use an in-house framework for our microservices, that has a bundled version of Bugsnag built-in. The way this framework makes use of the @bugsnag/js package meant that we avoided creating a client that had the leaveBreadcrumb method disabled (due to the way the clone client function works). It was a pure coincidence that we avoided this limitation when integrating Bugsnag in our framework.
For the past two years (almost to the date), in production, we've been making use of breadcrumbs on Node.js. To ensure that the breadcrumbs contained useful information, upon each request we enter a Node.js domain, and attach a new Bugsnag client to it. This means that no matter where (within that async call stack) we throw/catch an error, we have the ability to send it off to Bugsnag using the same client that was present at the beginning of the request. We override the console logger to look for this Bugsnag client and automatically leave console-type breadcrumbs. This has given us many many years of happy debugging and has no doubt saved countless hours of engineer's time.
I hope that the fact we've been running this in production for the past 2 years, in 39 services, is reason enough to count breadcrumbs a viable feature to (in my opinion) very easily enable - by removing a few lines of code.

:wave: @jmshal
Thanks for the additional context. The lack of breadcrumb support for Node.js is something we're hoping to revisit when priorities allow 👍

:wave: @jmshal
Thanks for the additional context. The lack of breadcrumb support for Node.js is something we're hoping to revisit when priorities allow 👍

👋 @jmshal
Thanks for the additional context. The lack of breadcrumb support for Node.js is something we're hoping to revisit when priorities allow 👍

Please add it's support in nodejs. It will be very helpfull.

Hi @himanshufize, this is still on our product roadmap but I don't have any further updates at this time. We'll be sure to update this thread when the feature becomes available.

I don't really understand why this hasn't been added already, tbh. We've (at my work) been using breadcrumbs with the Node.js client for over 3 years now. Will you accept PRs, @yousif-bugsnag? I wouldn't be able to use the client without breadcrumbs - I am surprised more people aren't voicing their frustration.

Hi @jmshal - at this stage we don't want to build any additional functionality on top of the deprecated domain API. We do have an item on our roadmap to look at replacing that library in the future, at which point we'll be able to revisit Node.js breadcrumbs when priorities allow.

@luke-belton By just enabling breadcrumbs (which is simply removing an arbitrary restriction) would allow developers to use breadcrumbs in a context/domain agnostic fashion. Do the two need to be conflated?

Hi @jmshal! This is still on our product roadmap, but I have no updates on it as of now. We will update this thread when we have more news on it.

+1 really annoying that we don't have this

👍 I agree, this would be great.

+1


Add LinkedTo method to IIssueClient Interface

API Changes:
Adding the following method:
        /// <summary>
        /// Get all Issues that are linked to a particular issue of particular project.
        /// </summary>
        /// <param name="projectId">The project id.</param>
        /// <param name="issueId">The id of the issue in the project's scope.</param>
        /// <returns>The list of Issues linked to this issue.</returns>
        IEnumerable<Issue> LinkedTo(int projectId,int issueId);

Open Issues:

[ ] Public API analyzer: needs action to resolve finding.
[ ] Mock class returns empty collection:   public IEnumerable<Models.Issue> LinkedTo(int projectId, int issueId)
   {
       using (Context.BeginOperationScope())
       {
           return Enumerable.Empty<Models.Issue>();
       }
   }

Tests:

Tested locally on personal repository. Linked issues are fetched correctly
recursive test (linked issues of fetched linked issues) probably should be blocked due to ciruclar reference?

Related Issues:
Fix #482

Could you also add a test to validate the method is correctly implemented in https://github.com/ubisoft/NGitLab/blob/main/NGitLab.Tests/IssueTests.cs?
This is quite important as the behavior of GitLab can change when you upgrade the server. So, the tests allow us to detect breaking changes.

the Issue class has no Linked property so not sure what the test logic should be. basically the link https://docs.gitlab.com/ee/api/issue_links.html#list-issue-relations
just fetch list of issues that related to a specific issue. There is no array property in the Issue model.

Maybe I'm wrong, but does the following flow works:

Create 1 issue
Create another issue with the description blocks #1
Get all links for the first issues => The collection must contain 1 item

The build fails. You need to fix the public API file. You can use Quick Actions in VS to update the file and fix the warning.

Added the unit test and updarted the public API file

Hi,
I hve no idea why the unit test fails and don't reaaly have a way to test it locally.

Ok , it seems link linking by description does not work even manually (I created manually 2 issues and try linking by comments/description).
it does not work.
But we can Add post command to link issues:
https://docs.gitlab.com/ee/api/issue_links.html#create-an-issue-link

But adding ability to Create Linked Issues should be different PR...

the trx show 200 result for get linked:
----------------------------------------------------------------------------------------------------
GitLab request: GET http://localhost:48624/api/v4/projects/59/issues/1/links
Accept-Encoding: gzip
Private-Token: ******
User-Agent: NGitLab.Tests/1.0.0
----------
200 OK
Server: nginx
Date: Tue, 18 Jul 2023 21:17:09 GMT
Connection: keep-alive
Cache-Control: must-revalidate, max-age=0, private
ETag: W/"4f53cda18c2baa0c0354bb5f9a3ecbe5"
Vary: Origin
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Request-ID: 01H5NDTD001NG2C2AM5W4B9THZ
X-Runtime: 0.074998
Strict-Transport-Security: max-age=63072000
Referrer-Policy: strict-origin-when-cross-origin
Content-Type: application/json
Content-Length: 2

[]

Added second new API:
        /// <summary>
        /// Create links between Issues.
        /// </summary>
        /// <param name="sourceProjectId">The project id.</param>
        /// <param name="sourceIssueId">The id of the issue in the project's scope.</param>
        /// <param name="targetProjectId">The target project id.</param>
        /// <param name="targetIssueId">The target id of the issue to link to.</param>
        bool CreateLinkBetweenIssues(int sourceProjectId, int sourceIssueId, int targetProjectId, int targetIssueId);

with this api we can update the test to create and get linked issues.
Tested both API on my presonal Gitlab repository

Looks good!
You need to fix the Stylecop error and rename the new method with the "Async" suffix to fix the test.

I'll fix those. Why aren't those set as error in the .editorconfig?

Why aren't those set as error in the .editorconfig?

For the analyzer: they are available locally, but only as warning. On CI, it uses TreatWarningsAsErrors, so it fails the build.
For the Async suffix, I'm not sure it could be part of the naming convention (editorconfig) as it only concerns methods returning GitLabCollectionResponse. Also, it hard to apply rules in this old and non-consistent codebase.

Updated the public api again . Hopefuly last commit :)

Thanks for your contribution 🚀


Added sentry to support error on Portal

ref PLG-204

Added a sentry capture so we know when and if the support error component gets triggered.

@ronaldlangeveld just a heads up, last I checked we didn't have Sentry enabled on portal!

@ronaldlangeveld just a heads up, last I checked we didn't have Sentry enabled on portal!

Thanks for the heads up! Wasn't aware of it, since there's loads of Sentry related code inside Portal. 😅


Ruffles not updated causing network discovery to not work

Because Ruffles has not been updated since  v7.1.2, I am unable to use some of the newer features such as Network Discovery. It would be really nice if a build with v9.1.0 is made.

Fixed


⚠ Jenkins Plugins Artifactory has degraded performance

In 75da8ce, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 2470 ms

Resolved: Jenkins Plugins Artifactory performance has improved in dfd021f.


Including new CartoAssets as module

Please take a look @CartoDB/frontend @rochoa @piensaenpixel, does it make sense?

@CartoDB/frontend ready to be merged people :), more comments? If not, fasten your seatbelts.


A user couldn't load the attached save (button disabled) in 1.0.1 under windows (saved by them)

No idea why, it works for me.

saveMoM.vSave.zip

Closing as cannot reproduce.


Make sure processPostCollection is called in case of early termination

Description
Backport https://github.com/opensearch-project/OpenSearch/pull/14208 to 2.15 branch
Check List

[x] Functionality includes testing.
[x] API changes companion pull request created, if applicable.
[x] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Closing in favor of https://github.com/opensearch-project/OpenSearch/pull/14214


💄upgrade pytorch, torch-lightning and cp10 CI

What do these changes do?

modified setup to use setup.cfg
requirements files are now not used by setup.py to set dependencies
added cp10 to CI, removed cp7

Related issue/s

How to test

Checklist

@pcrespov this is a minor MR where I introduced the setup.cfg, and reinterpret the meaning of requirements files


belindas-closet-nextjs_6_365_edit-user-role-buttons-menu

Resolves #365
This PR makes it so that pressing the "Edit" button changes it to "Done" and pressing "Done" closes the menu. The page reloads to reflect these changes when the user role is successfully updated and presses "Done".
https://github.com/SeattleColleges/belindas-closet-nextjs/assets/77607212/0b3b662d-d804-419e-97aa-e21c67aae540
Related to #364

Works as described:

Is there a plan to add more edit features? I feel that having to click two buttons to get to the edit role popup (rather than just clicking the main "Edit" button) is a bit redundant unless there's more things to edit. This is obviously out of the scope of your user story though, but I was just curious.

This would be a good question to bring up with the product owner!

Works as described:

Is there a plan to add more edit features? I feel that having to click two buttons to get to the edit role popup (rather than just clicking the main "Edit" button) is a bit redundant unless there's more things to edit. This is obviously out of the scope of your user story though, but I was just curious.

This is a good question to bring up with the product owner!

This feature is great. It allows roles to be edited from admins, creators and users. Looks good to me.


Lazy load node_modules to speed up Flow when in dependency hell

With recent versions of npm, node_module dependencies are flattened, which creates a massive amount of top-level directories that Flow descends into at startup. Could this be done lazily, right as the app under test tries to import something that Flow needs to analyze? I think this would also address https://github.com/facebook/flow/issues/719
As an example of how npm flattening affects Flow, my package.json defines 38 dependencies but my node_modules folder has 700 top-level modules :fire: . When I auto-generated ignore rules for these folders (https://github.com/facebook/flow/issues/719#issuecomment-180616534), the Flow server would start up twice as fast.

Related suggestion: #869.

@kumar303 Are you running 0.22? As of that version, we no longer parse non-@flow files, so large node_modules directories should have a much better experience.

oh wow, it is a big improvement in 0.22, thanks! Feel free to close this issue. Funny enough, my startup time is faster now without my auto-generated ignore rules (probably because it's not doing so much regex).

Closing, but we will continue thinking about not typechecking files in node_modules 👍


HTTP status code

This REST API does not return HTTP status code properly. For example when I call:
http://dev.markitondemand.com/MODApis/Api/v2/Quote/json?symbol=nonsense
it returns 200 OK, but should return 404 Not Found. Can you fix it please? It would make usage of this API much smoother and better.

You're right that the API isn't very RESTful in this sense.  That said, we aren't planning on making enhancements to this particular API, though teams within the company are looking at building new ones with full support.


DOC: <Issue related to /prompt_engineering/how_to_guides/prompts/manage_prompts_programatically>

The documentation states that to pull a private prompt from a private repository in LangSmith Cloud, you do not need to specify the repository owner handle.
see link quote

To pull a private prompt you do not need to specify the owner handle (though you can, if you have one set).

However, when I try to make a request to the URL https://api.smith.langchain.com/commits/-/foo/, I get a 404 error with the following response:
{
  "detail": "Repo None/test not found"
}

Could this be an issue with outdated documentation, or am I missing something in the request process?

Is your API key connected to the workspace in which the 'foo' prompt resides?

@hinthornw yes

Does it have commit ?

@hinthornw yes


fix(curriculum): make logical AND step more concise

removed grammatical mistakes stated in #49484
Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #49484

Hey @azr-arch
This PR seems to make similar changes as the existing PR <#49494>. As such, we are going to close this as duplicate.
If you feel you have additional changes to expand upon this PR, please feel free to push your commits and request this PR be reopened.
Thanks again! 😊
If you have any questions, feel free to ask questions on the 'Contributors' category on our forum or the contributors chat room.

do they even get merged or they are just for educating newcomers?

Is this PR a different file than the other one (logical OR vs logical AND)? Really, one issue should  generally be one PR, but this is 2 PRs for one issue, which is confusing.

I prefer one PR, if it's two files.
It will be confusing for maintainers to see an PR for closed issue one, if one of them is merged.

I prefer one PR, if it's two files.
It will be confusing for maintainers to see a PR for closed issue one, if one of them is merged.

i didnt know that i was supposed to fix all similar changes in one file sorry about that

I prefer

This is subjective opinion, don't worry about it.

i did commit suggestion does that fix the issue ? or should i have to make my own changes

Change line 14 as mentioned here https://github.com/freeCodeCamp/freeCodeCamp/pull/49495#discussion_r1117318012, then press Ready for review button

Hi,
We are closing old issues/pull requests that we think are stale. If you still need help or are fixing this, please open a new issue/pull request.
Thanks for your understanding.
Happy contributing.


Download button: write .inp files after editing

Add a download button, and write a .inp file with the current
changes. Assemblies, rodmaps and cells so far, no coremaps
or fuels/materials.
Update stable to 1.0.1, to get the tooltip fix.

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[FEATURE] Create @MediaQueries so the page is responsive!

Description
I noticed that the website is not responsive at all. I would love to be able and work on this. :)
In tho photo it shows what the website looks on small screens.
Screenshots

I would love to be working on this. :)

No worries, thank you so much for the issue :)


P1 - "Deployment Bugs"

Acceptance Criteria:
GIVEN "When I see bugs while deploying"
THEN "I find and fix them"

done


⚠ File access has degraded performance

In 7592e59, File access (https://fyle.uk/file/fish) experienced degraded performance:

HTTP code: 200
Response time: 2478 ms

Resolved: File access performance has improved in 2a8e538 after 8 minutes.


URL doesn't preserve map coords/markers for place_id

Describe the bug
When loading a page, with a place_id (and taxon_id) in the url, it does't preserve the maps coords, bounds or markers.
NOTE. observations are as expected, just not rendering on the map.
Potentially related, console message.
Loading the Google Maps JavaScript API without a callback is not supported: https://developers.google.com/maps/documentation/javascript/url-params#required_parameters
To Reproduce
Bug.

Visit https://www.inaturalist.org/observations?place_id=40469&subview=map&taxon_id=131669

Expected view.

Visit https://www.inaturalist.org/observations
Search Species : Cyathea dealbata, Location : Christchurch, New Zealand

Duplicate of #3636

I'll close this as I agree this is a duplicate of #3636


Fix tests fails on windows occasionally

:+1:
This PR seems to increase tests stability on Windows.
In my Windows 7 environment, this patches makes dramatically improves test stability! :smile:


[IconButton] Fix tooltip on hover

[ ] PR has tests / docs demo, and is linted.
[ ] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[ ] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Fixes #3862.

@andrejunges Good catch!

Looks like this is stuck 'checking' merge status, probably due to earlier github outage. Could you re-push?

@andrejunges - sorry to be pedantic, but please could you update the commit title to match the PR title (remove the issue #), then we can merge.

@mbrookes We can amend the messages now. Have a look at https://github.com/callemall/material-ui/commit/36efb172b4b3f151a08f4e573ad25d80b36aef12 :).

Oh, nice! :+1:


failure configuring imake on Mavericks

When installing imake 1.0.7 the configure process fails with following message:
==> ./configure --prefix=/usr/local/Cellar/imake/1.0.7
checking for cpp... /usr/local/Library/ENV/4.3/cpp
checking if /usr/local/Library/ENV/4.3/cpp requires -undef... clang: error: no input files
clang: error: no input files
clang: error: no input files
configure: error: /usr/local/Library/ENV/4.3/cpp defines unix with or without -undef.  I don't know what to do.
GIST: https://gist.github.com/e3e1dfd90cea0f2bdc3c

Do you still have this issue?

Yes, the issue is still present.

There was an identical issue Homebrew/homebrew#34550 . I see that your brew doctor is good, but could you manually check that your Xcode, SDK's, Command Line Tools(if you have some) are up to date?

I opened Homebrew/homebrew#34550 originally, and interestingly, I am running into the same problem again on a different computer. It seems that after upgrading to Yosemite, things are broken somehow. Since there was no Xcode update available this time, I fixed it by installing the command line tools and pointing code-select at them.

I've modified #20 to fix your case.
Please see if
brew install https://raw.githubusercontent.com/veprbl/homebrew-x11/imake-fix/imake.rb

works for you.

Thanks for your effort. I will test it on Monday when I have access to the affected machine.
Am 31.01.2015 um 16:29 schrieb Dmitry Kalinkin<EMAIL_ADDRESS>
I've modified #20 to fix your case.
Please see if
brew install https://raw.githubusercontent.com/veprbl/homebrew-x11/imake-fix/imake.rb
works for you.
—
Reply to this email directly or view it on GitHub.

Yes, the new recipe works for me.
Thanks for your work.
Von:  Dmitry Kalinkin<EMAIL_ADDRESS>Antworten an:  Homebrew/homebrew-x11
<reply+00a082e4d643082730dd7ab8e77a72ff92df275ac37794d392cf0000000110e4b6c69
<EMAIL_ADDRESS>Datum:  Samstag, 31. Januar 2015 16:29
An:  Homebrew/homebrew-x11<EMAIL_ADDRESS>Cc:  Thomas Gimpel<EMAIL_ADDRESS>Betreff:  Re: [homebrew-x11] failure configuring imake on Mavericks (#16)
I've modified #20 https://github.com/Homebrew/homebrew-x11/pull/20  to fix
your case.
Please see if
brew install
https://raw.githubusercontent.com/veprbl/homebrew-x11/imake-fix/imake.rb
works for you.
‹
Reply to this email directly or view it on GitHub
https://github.com/Homebrew/homebrew-x11/issues/16#issuecomment-72322060 .


Need customising webview color and keyboard color

Hello talkjs team!
I am working on an application and I have faced to some problems:

On screen loading or when I am scrolling the view up or down, I can see white background. I think it is webview background and I found some possible solutions here and here.
My application is in dark mode but I can't open a keyboard in ChatBox using necessary styles. Global setting in themeData brightness: Brightness.dark doesn't help with the situation. I need to be able to change keyboard color to Brightness.dark.

Could you please help me and fix it as soon as possible?
Here is a video of the problem.
https://user-images.githubusercontent.com/24383434/214597541-e6ec7b2c-3850-453b-8b9c-33df5c3f1143.mp4
And part of my code (build):
  Widget build(BuildContext context) {
    final themeData = Theme.of(context);
    return Scaffold(
      appBar: AppBar(
        // title: Text(conversation?.subject ?? ''),
      ),
      body: Container(
        padding: const EdgeInsets.only(bottom: 20),
        color: themeData.scaffoldBackgroundColor,
        child: FutureBuilder(
          future: getChatBasicInfo(),
          builder: (_, snapshot) {
            if (!snapshot.hasData || session == null) {
              return Container();
            }
            return LayoutBuilder(
              builder: (BuildContext context, BoxConstraints constraints) => Column(
                children: <Widget>[
                  Visibility(
                    visible: !_chatBoxLoaded,
                    child: SizedBox(
                      width: min(constraints.maxWidth, constraints.maxHeight),
                      height: min(constraints.maxWidth, constraints.maxHeight),
                      child: Center(
                        child: SizedBox(
                          width: 16,
                          height: 16,
                          child: CircularProgressIndicator(
                            color: themeData.primaryColor,
                            strokeWidth: 2,
                          ),
                        ),
                      ),
                    ),
                  ),
                  Visibility(
                    maintainState: true,
                    visible: _chatBoxLoaded,
                    child: ConstrainedBox(
                      constraints: constraints,
                      child: ChatBox(
                        session: session!,
                        conversation: conversation,
                        theme: 'dark_theme',
                        onLoadingStateChanged: (state) {
                          setState(() {
                            _chatBoxLoaded = state == LoadingState.loaded;
                          });
                        },
                        messageField: const MessageFieldOptions(
                          enterSendsMessage: true,
                        ),
                        showChatHeader: false,
                      ),
                    ),
                  ),
                ],
              ),
            );
          },
        ),
      ),
    );
  }

Hey, any updates?

Hi,
At the moment we're transitioning to a new WebView implementation, which will have a transparent background, and a colleague of mine is testing the dark theme keyboard issue.
We'll keep you updated when the new release with all the fixes will be released.

Hi,
Thank you! I'm looking forward to getting news

Hi,
We released version 0.7.0 of our Flutter SDK, please test it and let me know if it fixes these problems.

@bugnano Hi,
There is a transparent background, thank you. However the problem with light keyboard is still here.
Also you can see from the attached video that content doesn't scroll to the last message.
https://user-images.githubusercontent.com/24383434/218121814-ef661879-2736-43f5-ab05-0d0bb62ce335.mp4

Hi, any updates?

We have upgraded the underlying webview to fix the keyboard color issue. The release will happen shortly.


Registered nodes / Super nodes?

Consider having a registration for nodes - so that nodes which are registered in the blockchain get some additional functionality. Maybe data transactions are handled by such more trusted nodes or something like that. Maybe these nodes get a vote in something etc

superseded by fast transaction system


Removed all todos.

What does this PR do?
Fixes #1484

I removed the todos
  Before submitting

[ ] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
[yes ] Did you read the contributor guideline, Pull Request section?
[ yes] Did you make sure to update the docs?
[no ] Did you write any new necessary tests?

PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?
Make sure you had fun coding 🙃

The issue stated that we have to remove each todo one by one
So I did it
Please guide me though
I'm just very new to this

The issue stated that we have to remove each todo one by one So I did it Please guide me though I'm just very new to this

sure, so pls remove just one line with todo and run pre-commit --all-files and fix all raised issue :)


AlpineComponent is actually the component's data

I've looked more in the source and turns out that was named to be AlpineComponent, is only the data of that component,
The Component {} type in Alpine.js source is different, and yesterday we used it on methods of the Alpine type.
This leave us with 3 types:

Alpine aka window.Alpine
Component actual Alpine component
ComponentData which contain the magic helpers and other user data.

I realized this is a breaking change since it renames types, so I didn't make a pull  request.
What do you think? If you want to keep it like it is now it works great, the only affected part is types used by plugins-which is what I'm using it on.
If so, I can put up another package with types only.
I already wrote the types out:

// window.Alpine type
export declare interface Alpine {
	version: string;
	pauseMutationObserver: boolean;
	magicProperties: { [name: string]: (el: HTMLElement) => void };
	ignoreFocusedForValueBinding: boolean;
	onComponentInitializeds: Array<(component: Component) => void>;
	onBeforeComponentInitializeds: Array<(component: Component) => void>;
	onComponentInitialized: (
		callback: (component: Component) => void
	) => void;
	onBeforeComponentInitialized: (
		callback: (component: Component) => void
	) => void;
	listenForNewUninitializedComponentsAtRunTime: () => undefined;
	discoverUninitializedComponents: (
		callback: (rootEl: HTMLElement) => void,
		el?: HTMLElement
	) => void;
	discoverComponents: (callback: (rootEl: HTMLElement) => void) => void;
	start: () => void;
	addMagicProperty: (
		name: string,
		callback: ($el: HTMLElement) => void
	) => void;
	clone: (component: Component, newEl: HTMLElement) => void;

	[key: string]: any;
}

// Actual Alpine Component{} type. will be accessed by plugins.
export declare interface Component {
	$el: HTMLElement;
	$data: ProxyConstructor;
	$nextTickStack: CallableFunction[];
	$showDirectiveStack: any[];
	$watchers: { [name: string]: CallableFunction };
	unobservedData: ComponentData;
	getUnobservedData: () => ComponentData;
	updateElements: (rootEl: HTMLElement, extraVars?: () => {}) => void;
	updateElement: (el: HTMLElement, extraVars?: () => {}) => void;
	evaluateReturnExpression: (
		el: HTMLElement,
		expression: string,
		extraVars?: () => {}
	) => void;
	[key: string]: any;
}

// The data that you can access within a component.
export declare abstract class ComponentData {
	/** Retrieve the root component DOM node. */
	$el: HTMLElement;
	/** Retrieve DOM elements marked with x-ref inside the component. */
	$refs: {
		[name: string]: HTMLElement;
	};
	/** Retrieve the native browser "Event" object within an event listener. */
	$event: Event;
	/** Create a CustomEvent and dispatch it using .dispatchEvent() internally. */
	$dispatch: (event: string, data: object) => void;
	/** Execute a given expression AFTER Alpine has made its reactive DOM updates. */
	$nextTick: (callback: (_: any) => void) => void;
	/** Will fire a provided callback when a component property you "watched" gets changed. */
	$watch: (property: string, callback: (value: any) => void) => void;
	[key: string]: any;
}

Open a PR with the added type being called something like ComponentController or ComponentHandler. The ComponentData should always be named Component, because most people only ever interact with that.

Alright! Also, one thing, why are members of AlpineComponent optional?
I've got some errors about them so I had to use the null-safe operator, even though it always have those properties.
Even in here: https://github.com/LeanAdmin/alpine-typescript/blob/5104b5c62df97c7564cf5c869ef2a30befb43bbc/src/index.ts#L98-L100
It's used without the operator and the IDE gives an error for $el being possibly undefined.

If they weren't optional, you'd have to define the methods in class components: https://github.com/LeanAdmin/alpine-typescript#class-components
I don't have any IDE errors when working on this project, so that might be editor config

I see, I'm going to use class components, i think definite assignment assertion is the alternative here. It tells typescript that these values are indeed assigned even though it wasn't done by us, which is the case

Also, component() function checks if the class is instanceof AlpineComponent. I want to extend AlpineComponent to add more magic helpers. But it fail to register it because obviously the component isn't an instance of AlpineComponent but ExtendedAlpineComponent
is there a way around this or I have to implement copy the component function changing that line for this case?

instanceof supports inheritance

definite assignment assertion

How would you do that in a class?

instanceof supports inheritance
oh i get why it didn't now, I was extending my own type not one provided by this package. Sorry for that I'm still new to JS in general

definite assignment assertion

How would you do that in a class?
Simply by replacing ? with !
$el!: HTMLElement;


plot_compare_evokeds should have the same defaults for combine

Currently the function mne.viz.plot_compare_evokeds creates two different plots depending on the number of selected channels:

If one channel is selected (or present in the evoked), it will plot the ERP.
If two or more channels are selected (or present), it will plot the GFP.

I think this behaviour is potentially misleading, and I would expect the function to have the same defaults for different channels, i.e. mean of the evokeds. As you can see in #10465 , this created quite a bit of confusion for me (probably mainly due to me being new to ERP analysis and not knowing what GFP meant).
I see this has previously already spiked a bit of discussion (e.g. #3393) and was introduced in #6166.
By now, the gfp=... parameter has been removed in favor of the combine=None parameter, which defaults to a different value depending on the present/chosen channels.
I would suggest either

make combine have the same default for all cases
make combine an arg, i.e. make users forcefully choose a combination mode

Additionally, the docstring should reflect the importance of the combine parameter.
What are your thoughts on this?

@skjerns the docstring at https://mne.tools/stable/generated/mne.viz.plot_compare_evokeds.html says:

so maybe the API in counterintuitive but I think the docstring is explicit no?

@skjerns the docstring at https://mne.tools/stable/generated/mne.viz.plot_compare_evokeds.html says:
so maybe the API in counterintuitive but I think the docstring is explicit no?

yes, would it make sense, given the importance of the parameter, that it should be one of the first, not in between various other minor plotting parameters? Also I think there could be a hint in the docstring of pick to the combine parameter.

let's not reorder parameters and it's a painful deprecation cycle but yes
please send us a PR to put this
information in docstring header and/or in pick docstring

Message ID: @.***>

You can tag me on any PR for reviews cause I think I wrote this.

Ok note that the picksdocstring starts
    %(picks_all_data)s
        * If picks is None or a (collection of) data channel types, the
          global field power will be plotted for all data channels.
          Otherwise, picks will be averaged.

Ok note that the picksdocstring starts
    %(picks_all_data)s
        * If picks is None or a (collection of) data channel types, the
          global field power will be plotted for all data channels.
          Otherwise, picks will be averaged.

Which is not the current behaviour, as it plots the GFP even when specifying two channels, right?
Would it make sense to plot the GFP when selecting data channel types and the average when giving a list of ch indices? I'm not familiar with GFPs, but from the name alone it seems not so applicable when i.e. selecting two neighbouring channels from a set of 306, and in this case the average would be more appropriate?

Yes IIRC GFP should only be done if you take all the channels. With a selection averaging would be better. @drammock thoughts?

Yes, GFP only makes sense for all channels. If we plot it for lists of channels, I would consider this a bug we should fix without a deprecation cycle.

I agree w/ @jona-sassenhagen and @hoechenberger, this would be a bugfix. I'll tag it for the sprint for later this month, maybe someone will get to it?  But in the meantime @skjerns feel free to tackle it yourself if you have time.

On a tangent, I am thinking of simplifying the nave proportions algebra in evoked. comment for the results from plot_compare_evokdes to make a more informative legend. Here is an, e.g., output screenshot

The text in evoked.comment renders unusable image file formats unless figure legends are dealt with on the fly. If that's the intended usage, then disregard this. Otherwise, I am curious if a fix is a suitable task to piggyback here?
Resulting .png

😆 PR welcome @ktavabi. That has got to be one of the worst MNE-Python default plot outputs I've ever seen.


Change the icon's color whenever the current conversation's sentiment changes

This is a cool idea. Let's do this.

When we display the messages, we'll just check if the last two messages have the same sentiment impact sign. If not, call chrome.browserAction.setIcon(details) to change the icon programatically.
https://stackoverflow.com/a/6940093/8740440


Support custom views in other locations

Support custom views in other locations

[ ] Debug
[ ] SCM

@sandy081 Any way to get this bumped up -- the GitLens view is just BEGGING to be on the SCM activity. Or is there some guidance on what would need to be done here if a PR would be accepted?

I would request @joaomoreno to reply since he owns SCM viewlet.

I'm not entirely convinced that this is the way to go... I would like to keep the SCM viewlet clean, though I do see that a Gitlens view is wrong in the File Explorer.

I thought I could simply drag an extension's view into any activity I like. That would be ideal since I can fully control what goes where. But if it's something that's not acceptable, I'll settle with allowing developers to plug in their extension views into other activities.
Although, how about giving extensions the ability to add their own activities? That would be totally awesome and the best use of the wasted vertical space on the Activity Bar between the five built-in activities and the settings cog.
PS: Really want to see GitLens and Git History in the SCM activity (or with their own activities) so that my explorer activity focuses on just exploring.

Closing this as there are no plans to contribute views to SCM viewlet.

How about allowing extensions to create custom viewlets?

@ADTC above request is in plan - https://github.com/Microsoft/vscode/issues/43645


RSP-1701: Clean up for Tooltips

Closes
✅ Pull Request Checklist:

[ ] Included link to corresponding Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Team:

bottom/top tooltip slides diagonally when open for the first time... need to check it

From testing:

can't mouse over the tooltip and have it stay up (don't know if that's a requirement)
if i click on the trigger, it'll cause the tooltip to go away and put it into a state where the animations and timers don't seem quite right anymore
disabled trigger story doesn't seem to have a disabled button?

From testing:

can't mouse over the tooltip and have it stay up (don't know if that's a requirement)
if i click on the trigger, it'll cause the tooltip to go away and put it into a state where the animations and timers don't seem quite right anymore
disabled trigger story doesn't seem to have a disabled button?

@snowystinger

mouse over tooltip fixed
timers and animations have followup task https://jira.corp.adobe.com/browse/RSP-1367
I think that isDisabled story only disables triggering logic, will not affect button (overaly trigger also does that)... any suggestion?


Petition to make a 222V Contributor Event

haha epic yes

And how will this work?

cool stuff

we get free mod in every gaem!!!


Allow action contributions to depend on server's API version

When the ObjectScript extension contributes the Launch WebSocket Terminal button to namespaces in the Server Manager tree it is unable to discriminate between namespaces on servers that support the necessary version of the Atelier API (v7, which landed with 2023.2) and namespaces on older servers. This results in a poor UX, as the user may click a promising-looking button only to be told that their server doesn't support the feature.
I propose adding the API version number as a prefix on the viewItem context keys of all tree folders / leaves below the "Namespaces" folder of a server. It is only when "Namespaces" gets expanded that Server Manager attempts the connection. One of the properties of the response object it gets if successful is the API version number.
Existing when-clauses that check viewItem to spot a namespace item already use the /namespace$/ regex in order to match both namespace and sysnamespace (the latter being what SM marks the %SYS namespace with). This means the proposed numeric prefix shouldn't break these.
For consistency and future-proofing I propose also propagating the version prefix down into the the Projects and Web Apps subtrees, in case SM or other extensions want to contribute commands there but only conditional upon the server supporting a new enough Atelier API.
@isc-bsaviano any comments on this proposal?

@gjsjohnmurray I think this sounds reasonable


Error in TAGConv in batch mode of static graph

🐛 Bug
Hello, I have a static graph and I want to use TAGConv in batch mode. More precisely, I followed the instruction on this link. Imagine I have batched node features x with shape [B, N, in_channels], where B is the batch size and N is the number of nodes. Here is the sample code:

import torch
import torch_geometric
B = 2  # batch size
N = 3   # number of nodes
in_channels = 4
out_channels = 8
K = 2   # Number of hops
conv = torch_geometric.nn.TAGConv(in_channels=in_channels, out_channels=out_channels, K=K, node_dim=1)
edge_index = torch.tensor([[0, 1, 1, 2], [1, 0, 2, 1]])
x= torch.randn(B, N, in_channels)
out2 = conv(x, edge_index)

I get the following error:

File "/site-packages/torch_geometric/nn/conv/tag_conv.py", line 50, in norm
deg = scatter_add(edge_weight, row, dim=0, dim_size=num_nodes)
RuntimeError: Invalid index in scatterAdd at /pytorch/aten/src/TH/generic/THTensorEvenMoreMath.cpp:721
The above operation failed in interpreter.
Traceback (most recent call last):
File "/site-packages/torch_scatter/scatter.py", line 27
size[dim] = int(index.max()) + 1
out = torch.zeros(size, dtype=src.dtype, device=src.device)
return out.scatter_add_(dim, index, src)
~~~~~~~~~~~~~~~~ <--- HERE
else:
return out.scatter_add_(dim, index, src)

I am not sure, but when I see inside the forward method of tag_conv.py I see that in the first line it is written:

edge_index, norm = self.norm(edge_index, x.size(0), edge_weight, dtype=x.dtype)

Is it correct to use x.size(0)? Shouldn't it be x.size(self.node_dim)?
Moreover, something funny that I don't understand the reason is that I get this error with B=1 and B=2, but for B >=3 I don't have this error anymore.
Environment

OS: 16.04.6 LTS (Xenial Xerus)
Python version: Python 3.6.2 :: Continuum Analytics, Inc.
PyTorch version: 1.4.0 + cu9.2
CUDA/cuDNN version: No CUDA
GCC version:
Any other relevant information:

Additional context

Thanks for reporting. Should be fixed in master.

Now that you are fixing, I see in the norm method of tag_conv.py you are using

deg = scatter_add(edge_weight, row, dim=0, dim_size=num_nodes)

I don't know if this is again the same problem or not, but dim=0, to me, it looks like the same problem.
**More importantly, I see similar problem in SGConv (gcn_conv.py). **

This is no problem since edge_index is also expected to be of shape [2, num_edges].

Thank you for your answer.
What about SGConv (gcn_conv.py)? I get the same error with this convolution as well.

Should be fixed there as well.

Thanks,
One last question in this regard. Since I am not familiar with packaging, am I going to see all the new changes you made in the master repository if I do

pip install torch-geometric

Or it takes time to change the code on pip?

Yeah, those changes are not on pip yet. But you can always clone the repo and just run python setup.py install.


noctua_sgd.gpad has a space in the PMID field, typo in PMID field

Sorry to be the bearer of bad news, but we have strange things in our GPAD just obtained from http://release.geneontology.org/2020-05-02/products/annotations/noctua_sgd.gpad.gz
There are several cases of spaces in the "PMID: 0000000" field (expect PMID:0000) and an errant PMD: prefix elsewhere.  Seems these should trigger some checks somewhere:

SGD	S000003464	enables	GO:0044183	PMID: 19412159	ECO:0000314			20200429	SGD		model-state=production|noctua-model-id=gomodel:5e72450500002948|contributor=http://orcid.org/0000-0001-5472-917X

SGD	S000001905	acts_upstream_of_or_within	GO:0043335	PMID: 32320318	ECO:0000315			20200428	SGD		noctua-model-id=gomodel:5e72450500002870|model-state=production|contributor=http://orcid.org/0000-0001-5472-917X

Also fun is

SGD	S000003214	part_of	GO:0010494	PMD:26359986	ECO:0000314			20200127	SGD		contributor=http://orcid.org/0000-0001-9799-5523|model-state=production|noctua-model-id=gomodel:5df932e000001486

There are two steps here then. The first would be to fix the (likely) typos in the original annotations (I'm guessing copy/paste errors). The second would be to make sure that minerva is validating IDs at least to the extent of making sure spaces are not present.

I've gone through and manually fixed the spaces/typos.  But I suspect this will still be an issue im the future as more curators copy/paste into Noctua, as PubMed (and other sources) provide the "PMID: 11111" format, space included.

It happens all the time for ontology developers too. One check that I always do when using the graph editor is to look at the evidence statement once I've made the annotation. The title appears. This helps not only for the space case above but also when you miss a digit on the end or just make a typo if you are entering the PMID by hand. The title will be from a completely unrelated paper.


type RuleSetRule.generator is vaguely defined.

Bug report

What is the current behavior?
I'm looking through webpack's type definition documentation.
In interface RuleSetRule , the type of generator property is defined vaguely.
(https://github.com/webpack/webpack/blob/v5.50.0/types.d.ts#L9488)
Can I contribute by referring to the document below?
https://webpack.js.org/configuration/module/
If the current behavior is a bug, please provide the steps to reproduce.

What is the expected behavior?
will have to extract the interface and add a comments, but roughly:
interface RuleSetRule {
  // ...
  generator?: {
    dataUrl?: AssetInlineGeneratorOptions;
    emit?: boolean;
    filename?: string;
    publicPath?: string;
  }
}

Other relevant information:
webpack version:  5.50.0
Node.js version:
Operating System: macOS Big Sur 11.4
Additional tools:

I'll close the issue with options that depend on the loader.


Load WebWorker using Webpack 5 API

Use webpack 5 compatible web worker API

This won't work out of the box and needs more work.
The new Worker API requires ESM instead of commonjs.