Support blocked dot operand layout conversion to linear layout

Goal
Support FMA/Blocked dot operand layout in linear layout converter.
DoD
Implemented LinearLayout converter and related tests are implemented and passing, switch to Linear layout converter do not break python tests.
Existing Linear Layout converters for dot operands
Nvidia MMA dot operand
AMD MFMA dot operand
Both of these examples are fully functional, but I want to refactor MFMA and WMMA converters in similar to Nvidia MMA fashion soon. Please try to follow MMA style.
In progress PRs
WMMA dot operand
Legacy SharedLayout->dotOperand converter examples

Shared Layout -> Blocked/FMA dot operand
Shared Layout -> MFMA dot operand
Shared Layout -> WMMA dot operand

Implementation details

Implement linear converter similar to WMMA/MFMA (I am going to refactor these converter a little soon) in LinearLayoutConversions.cpp; Add appropriate call in DotOperandEncodingAttr::toLinearLayout function
Add blocked layout in MemoryOpToLLVM.cpp:isSupportedDotOpLayout to enable shared->blocked dotOperand conversion with LL; check all test_core.py tests work.
Enable LL converter in ConvertLayoutOpToLLVM.cpp:transferWithinBlock to enable ttg.convert_layout operation conversion with LL. Maybe you need to rework some other places as well, we will clarify this during implementation.
Implement ctest tests in LinearLayoutConversionsTest.cpp and few lit tests to specifically verify ttg.convert_layout operation conversion

+cc @simonidaa
please, consider this task next

+@lezcano Maybe you can offload this to AMD? Or there's something you've already done but not pushed yet?

Thank you @Jokeren! this is good to know, I will consider removing getCSwizzleOffset from our converters.

Very good to hear for this work!
(For my experimental project, using LL for non-GPUs, yeah, this was a missing feature. I hacked badly just to make it passable for unit tests, but looking forward to seeing this support.)

I did not start with this, so feel free to take over.

@lezcano told me this task is blocking him, so I am going to implement it asap,
@simonidaa I will look for something else, but still related to LL for you

I've made a draft PR: #5469
Along the way I understood that current FMA implementation does not align with the rest of layouts, so I decided to rework it. Currently some tests are failing probably will finish this work tomorrow.


[feature] whichkey

This plugin, https://github.com/folke/which-key.nvim, can let user familiar with neovim easily. But I don't know I should add it or not because I don't need it.

Telescope is enough.


pallet-contracts: cache ContractInfo

At the moment, each time we need to info from ContractInfo we fetch ContractInfo. Furthermore, if we need to alter any key-value pairs in the storage of a contract, we fetch ContractInfo, update and store back each time.
This is rather wasteful since the code is structured in a way that most of the actions performed within a call to that contract. Therefore, we could get away with fetching the ContractInfo and storing it ~once per a call.
Notable exceptions to this would be:

Calling a contract which is already on a contract call stack. In this case we could unconditionally try to reload the contract info (we know that it exists, thanks to the invariant that you cannot destroy a contract if it is on the contract call stack).
Before each call to a contract we need to check if there was a call to that contract and if not then collect rent.

FWIW, this is not a huge problem since only the first load (which, as was indiciated above, in necessary anyway) will hit the trie, but nevertheless the overhead is still present in the form of serialization, deserialization of ContractInfo, host calls and allocations.
Related https://github.com/paritytech/substrate/issues/2793

undesired reverts of storage modifications by storage tx
Presently, before execution of a contract a new storage transaction is created for the execution context. If the contract call succeeds, the tx is committed. Should it fail and the tx will be reverted.
The problem is that there are some modifications that should not be reverted:
The first access within a block to a contract could potentially lead to its removal. If that happened within a storage transaction, then this removal can be potentially rolled back. This is not incorrect per se, since that doesn't make the contract accessible. However, it won't get removed from the storage and there would be unnecessary back and forth removing and restoring the child trie.


Line numbers in error messages

A line number would be convenient in the error message below.
In general a standard error-message format would be great (with line numbers when applicable) in order to set up my editor to jump to errors automatically (in this case vim).
PASS #1: TypeCheckerSnowcat                                       I@21:37:44.350
 > Running Snowcat .::.                                           I@21:37:44.350
Parsing error in the type annotation:  P -> [P -> Bool]           E@21:37:44.430
<unknown>: type input error: Parser error in type annotation of m2: ':' expected but -> found E@21:37:44.450
It took me 0 days  0 hours  0 min  0 sec                          I@21:37:44.451
Total time: 0.564 sec                                             I@21:37:44.451
EXITCODE: ERROR (255)

Thank you for the report!
This relates to #955 and #943.


Added a Gym-Landing Page

It is a Gym-Landing Page made using HTML and CSS.
#3483
Close #3483

Checklist:

[X] I have mentioned the issue number in my Pull Request.
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have created a helpful and easy to understand README.md

@MohitGupta121  kindly please review this pull request.


feat: use appendContext to perform (hack) builtins.storePath in a pur…

For discussion. Using this admitted hack is far more precise than a blanket "--impure". Also note that further expected changes in Nix will make this unnecessary.

Is there any reason not to do this?

Is there any reason not to do this?

I'm not aware of any difference that would be visible evaluation time. As noted, this hack can be replaced once storePath and/or fetchClosure can be used purely. At the moment the performance cost of non-stop injecting "--impure" is just too much.

Next steps:

bump floxpkgs lock in template
remove impure from most commands
inject impure into specific floxEnv building internal calls


problem with galaxy rise time for 2017-03-01

I'm trying to figure out the rise/set times for a bunch of sources at the GBT and think I have found a bug in the rise/set time for a particular source for the date 2017-03-01. When I select the date 2017-03-04, I get the following times:

Rise:  2017-03-04 05:19:03.776147
Transit: 2017-03-04 06:33:16.235763
Set:  2017-03-04 07:47:30.688286

However, when I select the date 2017-03-01, I get the following times:

Rise: 2017-03-02 05:26:58.095280
Transit:  2017-03-01 06:45:03.964774
Set:  2017-03-01 07:59:15.481768

I believe that the date on the rise time should be 2017-03-01, NOT 2017-03-02 (to match the results on 03-04). Changing to previous and next rise times doesn't help:

Previous:2017-02-28 05:34:48.990694
Next: 2017-03-02 05:26:58.095280

This only happens with one relatively low declination source (-18deg). All my other source rise/set times look good.
I've put test code below showing the issue.
from astroplan import Observer, FixedTarget
from astroplan.plots import plot_airmass

from astropy.coordinates import SkyCoord, EarthLocation
from astropy.time import Time
from astropy.table import Table
import astropy.units as u

# setup observing
location = EarthLocation.from_geodetic(lon='-79d50m23.406s',lat='38d25m59.236')
gbt = Observer(location=location, elevation=807.43*u.m,name='gbt',timezone='US/Eastern')
time = gbt.midnight(Time('2017-03-04 5:00:00'))

coordinates = SkyCoord(180.47086*u.deg, -18.867990*u.deg, frame='fk5')
galaxy = FixedTarget(name='NGC4038', coord=coordinates)

galaxy_rise = gbt.target_rise_time(time, galaxy,horizon=30*u.deg)
galaxy_transit = gbt.target_meridian_transit_time(time,galaxy)
galaxy_set = gbt.target_set_time(time, galaxy,horizon=30*u.deg)

print galaxy_rise.datetime
# 2017-03-04 05:19:03.776147
print galaxy_transit.datetime
# 2017-03-04 06:33:16.235763
print galaxy_set.datetime
# 2017-03-04 07:47:30.688286

time = gbt.midnight(Time('2017-03-01 5:00:00'))
galaxy_rise = gbt.target_rise_time(time, galaxy,horizon=30*u.deg)
galaxy_transit = gbt.target_meridian_transit_time(time,galaxy)
galaxy_set = gbt.target_set_time(time, galaxy,horizon=30*u.deg)

print galaxy_rise.datetime
# 2017-03-02 05:26:58.095280
print galaxy_transit.datetime
# 2017-03-01 06:45:03.964774
print galaxy_set.datetime
# 2017-03-01 07:59:15.481768

galaxy_rise_prev = gbt.target_rise_time(time, galaxy,horizon=30*u.deg,which='previous')
galaxy_rise_next = gbt.target_rise_time(time, galaxy,horizon=30*u.deg,which='next')

print galaxy_rise_prev.datetime
# 2017-02-28 05:34:48.990694
print galaxy_rise_next.datetime
# 2017-03-02 05:26:58.095280

Hi @aakepley. It looks like from that location (South Pole?) NGC 4038 doesn't go above 30 degrees on that date. It just skirts it at 29 degrees and then the next day goes back above 30. Changing your horizon to 29 degrees will give you the correct answer:
time = gbt.midnight(Time('2017-03-01 5:00:00'))
galaxy_rise = gbt.target_rise_time(time, galaxy,horizon=29*u.deg)
galaxy_transit = gbt.target_meridian_transit_time(time,galaxy)
galaxy_set = gbt.target_set_time(time, galaxy,horizon=30*u.deg)

print(galaxy_rise.datetime)
# 2017-03-01 05:17:22.505081
print(galaxy_transit.datetime)
# 2017-03-01 06:45:03.962682
print(galaxy_set.datetime)
# 2017-03-01 07:59:15.483498

Hi @wtgee  -- The GBT is in West Virginia (lat=~38.5). What physical effect is causing this difference? If it's refraction, why would it be different on one day from a day 3 days later?

Sorry @aakepley, you are quite right that the galaxy goes up to 32.5 degrees and I think you are also right that you found a subtle bug.
In Observer._calc_riseset a 24 hour time grid is created which is then passed to Observer._horiz_cross to get the time when the target crosses the horizon. For your target, this happens twice in a 24 hour period. _horiz_cross successfully finds these two times (here: https://github.com/astropy/astroplan/blob/master/astroplan/observer.py#L559) but slightly later it only grabs the first index for a given target, assuming there will only be one (here: https://github.com/astropy/astroplan/blob/master/astroplan/observer.py#L593).
@bmorris3 might want to chime in on a possible solution to that. It seems like the logic on line 593 would need to incorporate whether it was rising or setting and which (nearest, next, previous) you wanted in order to determine whether you wanted the first or last occurrence within the 24 hour period. If line 593 adds all of them then _horiz_cross will happily return the time and altitude limits back to _calc_riseset which could figure out that logic.

Hi @aakepley! I'm trying to sort through this issue. Do you think it's related to these other ones, #261 #155, and the caveats noted in the astroplan FAQ? Our rise/set approximations are known to fail in some corner cases.

It doesn't seem to be directly related to these issues. The most closely associated one is #155 (the midnight within 30s of input time). The galaxy rise time is within ~30s of midnight. See code below:
galaxy_rise_prev = gbt.target_rise_time(time, galaxy,horizon=30*u.deg,which='previous')
galaxy_rise_next = gbt.target_rise_time(time, galaxy,horizon=30*u.deg,which='next')

print galaxy_rise_prev.datetime
# 2017-02-28 05:34:48.990694
print galaxy_rise_next.datetime
# 2017-03-02 05:26:58.095280

# estimating the rise time on 2017-03-01
time_diff =  galaxy_rise_next - galaxy_rise_prev
bet_time = galaxy_rise_prev + time_diff/2.0

print gbt.altaz(bet_time,galaxy).alt
# 30d00m33.5923s
# so az looks okay on date (>30deg).

# rise time on 3-01
bet_time.iso
# '2017-03-01 05:30:53.537'

# midnight (see earlier test case for code).
time.iso
# '2017-03-01 05:31:31.350'

mid_diff = bet_time - time
mid_diff.sec
# -37.81329318881035

# galaxy rise time is close to midnight.

@aakepley - can you give the version of python, numpy, and astroplan you were seeing this with?  I think I agree with https://github.com/astropy/astroplan/issues/276#issuecomment-269834425 that this is a bug due to subtle violations of expectations in the algorithm... but to do a fix I need to be able to reproduce, and when I do it (python 3.6, numpy 14.2, astropy 3.0, and astroplan 0.4), I get the right answer (i.e. 3/1 and 3/2 instead of 2/28 and 3/2)

@eteq -- Unfortunately, I think this information is lost to the mists of time. I didn't report them when I first reported the issue  like a good tester should, either. boo. I've also completely changed computers between then and now... For what it's worth, I also now get the correct values with python 2.7.13, numpy 1.12.1, astropy 1.3.2., astroplan 0.2.1.

Ok, thanks @aakepley - I think we'll consider this closed unless the problem comes back or @wtgee can reroduce (in which case feel free to reopen!)


Increase the max length of FacilityListItem.geocoded_address

Overview
We were running into crashes in the geocoding process because we were trying to insert more than 200 characters into the geocoded_address field. The value of this field comes from the formatted_address field in the Google geocoder response. We could not find any documentation mentioning how long this field might be so we took a guess and made the field 5x larger that it was.
Connects #342
Connects #292
Testing Instructions
I was not able to reproduce the issue with 14.csv as reported in #292. I was able to reproduce it with
handm-long-geocode-test.csv.txt

On develop, upload handm-long-geocode-test.csv.txt and run it through parse and geocode Verify that an exception is raised.
Checkout this branch and ./scripts/manage migrate
Run the geocode process again and verify that it completes without error (some items may "fail" because they were previously geocoded successfully)

I updated the test instructions and attached a file that can be used to reproduce the error.

Taking a look now.

Unfortunately I'm unable to reproduce the issue on develop. Tried both 14.csv and handm-long-geocode-test.csv.

Interesting. I assume that the responses from the Google are changing out from under us.
I used this diff to force the error on develop.
diff --git a/src/django/api/processing.py b/src/django/api/processing.py
index eec5036..e5d6745 100644
--- a/src/django/api/processing.py
+++ b/src/django/api/processing.py
@@ -92,7 +92,7 @@ def geocode_facility_list_item(item):
                     data["geocoded_point"]["lng"],
                     data["geocoded_point"]["lat"]
                 )
-                item.geocoded_address = data["geocoded_address"]
+                item.geocoded_address = ('A' * 150) + data["geocoded_address"]
             else:
                 item.status = FacilityListItem.GEOCODED_NO_RESULTS
             item.processing_results.append({

Great, I'll try that.

Thanks for the review.


fix(ssl): minor code change

There was a minor code fix in the SSL config setup
fixes issue #208

It seems like this change got made already in the form of server.ssl being checked as the first clause in the boolean expression. If I am mistaken please open another issue.

Hmm,then. I think i didn't tell it clearly. In the below script, the value of USE_HTTPS gets the value of server.ssl.cert instead of server.ssl. That creates the problem, when it is used by helmet config
this.env = {
IS_PRODUCTION: !process.env.NODE_ENV || process.env.NODE_ENV === 'production',
USE_HTTPS: server.ssl && server.ssl.key && server.ssl.cert,
};

Hope you get my point now!


Type definition for defineComponent in capi.legacy.ts is any

Environment

Operating System: Linux
Node Version: v18.18.0
Nuxt Version: 2.17.2
CLI Version: 3.10.0
Nitro Version: 2.7.2
Package Manager<EMAIL_ADDRESS>Builder: webpack
User Config: bridge, typescript, nitro
Runtime Modules: -
Build Modules<EMAIL_ADDRESS>
Reproduction
https://stackblitz.com/edit/github-heoruj?file=defineComponent.ts
Describe the bug
Even with bridge.capi: true, the aliases for the legacy @nuxtjs/composition-api are still defined in .nuxt/tsconfig.json.
The return value of defineComponent in there is any, so the types for Vue components are not inferred correctly.
Additional context
https://github.com/nuxt/bridge/blob/3c40b3f363f7f3c8b72322a8d6e89f9bb5389bb5/packages/bridge/src/runtime/capi.legacy.ts#L220-L227
It looks like this could fix the issue. What do you think?
import {defineComponent as defineComponentVue } from "vue"

export const defineComponent: typeof defineComponentVue = (options) => {
  if (!('head' in options)) { return options }

  return {
    ...options,
    ...getHeadOptions(options)
  }
}

Logs
No response

I think the solution described in the description is a good one!

Fixed at https://github.com/nuxt/bridge/pull/994


Device certificate generator encrpytion

Encryption of the returned certificates. #50
According to the previous design, if the user does not provide a vault, instead of upload the certificates to a S3 bucket, the certificates would be passed back to the user.
This modified version requires the user to provide a key for AES encryption and the certificates would be encrypted.

Please resolve conflict files


Driver scans table schema on every query run

Separating https://github.com/starburstdata/metabase-driver/issues/71 on 2 issues for convenience.
If you see the logs, the driver is syncing the table schema on every query run. This doesn't happen when connecting the DB directly without Trino

Do you see this issue only with Postgres through Trino or any db through Trino? When I run a question I see the query being executed once with no table schema syncing (I do see some DESCRIBE calls made, but run every hour)

@paoliniluis do you have a response to my comment?

Was never able to reproduce the issue. The Metabase connector does refresh the metadata on a regular basis, but not when running a query.


reintroduce wandb support with a few improvements

by default wandb is off
extract wandb code in a logging_utils.py
reduce the amount of new code in downloader.py
remove useless download one file function

The code from this is mostly from @borisdayma 's https://github.com/rom1504/img2dataset/pull/40

could you please have a look @borisdayma and tell me if that looks good to you ?
I tested it and it seems to be doing the same as before. Here's an example run https://wandb.ai/rom1504/img2dataset/runs/3ief4osx?workspace=user-rom1504

I think I'm going to go ahead and merge/release, but please still have a look and tell me if you see anything wrong, thanks

It worked great! I like the counter implementation!


push.on('notification') callback is not called on coldstart on iOS

Expected Behaviour
The callback push.on('notification') should be called on coldstart on iOS
Actual Behaviour
The callback push.on('notification') is not called on coldstart on iOS
Reproduce Scenario (including but not limited to)
Steps to Reproduce

Open your app on iOS
Register for PN
Put the app in background
Trigger a PN
PN successfully arrives and on tapping on it the notification callback will be called.
Close the app
Trigger a PN again
Tap on the PN
The notification callback will not be called now

Platform and Version (eg. Android 5.0 or iOS 9.2.1)
iOS 9.1
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
Cordova CLI version and cordova platform version
cordova --version                                    6.0.0
cordova platform version ios                     4.0.1

Plugin version
cordova plugin version | grep phonegap-plugin-push   1.6.0

Sample Push Data Payload
Sample Code that illustrates the problem
Logs taken while reproducing problem

I have found the solution for this one. The reason for this issue is that in PushPlugin.m the callbackId property is set to nil on killing the app. As a result, the check on line#441 is not satisfied in the - (void)notificationReceived callback. The fix for the issue is to instantiate the PushPlugin class on opening the push notification every time your app starts. This can be done by registering the push notification plugin on app start.
Call the PushPlugin.init method in your javascript everytime your app starts, and this will instantiate the plugin and assign the appropriate callback and callbackid in the plugin. I have added the below code to my Ionic app's app.run() section
window.PushNotification.init({
    ios: {
       "badge": false,
       "sound": true,
       "alert": true,
       "clearBadge": true
   }
})

Let me know if anyone still faces this issue.

If placed in app.run() is window.PushNotification defined? (we dont have to wait for device.ready?)


Implementing PushSource on top of Source

Changes:

Modified the PushSource interface to change to an abstract function
Change

setConsumer(Function<Record, CompletableFuture> consumer)
->
setConsumer(Consumer<Record> consumer)
Since record already has a ack method to indicate acknowledgement. We don't need to completable future mechanism any more

@sijie @srkukarni please review

Since this is a smallish change, would rather do it here itself? It actually simpifies the code of kafka source

@srkukarni are you suggesting we poll one tuple at a time?
e.g.
onsumerRecords = consumer.poll(1);
is that efficient?

@srkukarni user a push source might be more efficient since not we are doing async reads in a sense.  Remember the actual source synchronous.  It can only process on tuple at a time

So the main interface is the Source<> interface which has a read() blocking call. Since kafka is also a pull interface, kafkasource can just basically extend source<> directly and implement read() as kafkaclient.poll(). The mechanics of internal buffering is for efficiency reasons, but it would be something like this
read() {
if bufferedQueue.empty  bufferedQueue = kafkaclient.poll(some reasonable number);
pop and return back;

@srkukarni but isn't that just the same as using the PushSource but instead you a pulling the queuing logic back into the KafkaSource?

Not really. Infact this is closer to Storm's KafkaSpout which is a pull model

I discussed with @srkukarni and we are going to leave the KakfaSource as it is for now


slot length based sleep duration

Issue Number

#460
Overview

[x] I have added getInitialSlotDuration to Jormungandr layer and based slot length calculation in Jormungadr based on config
[x] added SlotLength to Cardano.Wallet and added it as argument to newWalletLayer and later used for sleep duration in restoreSleep
[x] I have defined slotLength in Cardano.Wallet.HttpBridge.Binary - 20 seconds and used this throughout http-bridge

Comments

@Anviking @KtorZ  I married getInitalFeePolicy and getInitialSlotDuration. Just pushed and notice that getBlock probably can also go under this hood ...

@paweljakubas
getBlock is actually used independently in quite some other parts, so it makes sense for this one to live on its own. However, factoring the resolution of the genesis block in getInitialConfigParams makes sense.

I'd like to merge after #534 in case any of the two merge fails, such that we can get some debugging information in CI :man_shrugging:


Fix rat plugin configuration for json files

Signed-off-by: xstefank<EMAIL_ADDRESS>Oversight included with WG changes.

this is just a config revert so I will merge. We can revert later if needed..


Remove jupyterlab from requirements

This requirement caused some installation issues in a managed environment. The code doesn't actually need jupyterlab as far as I can tell. My fork is working for me, but may be useful to upstream.

Looks good, thanks!


Allow guzzle 7

Hi,
We have recently tagged a new version 7 of guzzle.
https://github.com/guzzle/guzzle/releases/tag/7.0.0
🎉

:+1:


fake test

Current coverage is 95.00% (diff: 100%)

No coverage report found for master at 5cad1d9.

Powered by Codecov. Last update 5cad1d9...b443291


Add NavigationCardStack example after React Native 0.32 release

This is issue for not yet committed code :-)
RN 0.32 finally allows header size defined by content size, as Este uses it for now, so I don't want to rewrite already existing code, so that's why I add NavigationCardStack example next week.

Startups don't need that yet. Subview can be replaced with another tab. I don't want to add any custom code. Let's wait for https://github.com/jmurzy/react-router-native to be finished.


[capture] Simple script for OTBN

As the old capture.py file is not working anymore due to the repo restructure, we need to implement the OTBN capture.
Please use capture_aes.py as a boilerplate.

Can we close this issue, or is there anything missing?

The PR is successfully merged and there shouldn't be anything missing.
We can close this issue.


Ionic-select or datetime error when i click it : ORIGINAL EXCEPTION: TypeError: activeNav.getActive is not a function

Github URL :
https://github.com/ahmaddzidan/bookingapp
Short description of the problem
When i click on ion-select or ion-datetime and the error appear. ORIGINAL EXCEPTION: TypeError: activeNav.getActive is not a function. what should i do ? i have googling this problem wholeday but zero result.
sorry i not good in english language.
Log Console
EXCEPTION: Error in build/pages/home/home.html:16:13
app.bundle.js (line 44013)
ORIGINAL EXCEPTION: TypeError: activeNav.getActive is not a function
......
Steps to reproduce:

Start new proejct with ionic cli ionic start bookappv2 blank --v2
Copy ion-select from documentation
and the problem appear,

Which Ionic Version?
<EMAIL_ADDRESS>Run ionic info from terminal/cmd prompt:
Cordova CLI: 6.3.0
Ionic Framework Version: 2.0.0-beta.11
Ionic CLI Version: 2.0.0
Ionic App Lib Version: 2.0.0-beta.20
Node Version: v4.4.7
OS : Windows 10

Hello, thanks for opening an issue with us! Would you mind posting a minimal code snippet that i can use to reproduce this issue? Thanks!

 Room Type

Standard
Studio
Villa
Penthouse

......
import { Component } from '@angular/core';
import { NavController, LoadingController, AlertController } from 'ionic-angular';
@Component({
templateUrl: 'build/pages/home/home.html'
})
export class HomePage {
roomType: any;
nights: any;
rooms: any;
from: any;
to: any;
constructor(public navCtrl: NavController, private alertCtrl : AlertController, private loadingCtrl : LoadingController) {
let today = new Date();
let tomorrow = new Date();
tomorrow.setDate(+1);
this.roomType = 'standard';
this.nights = 1;
this.rooms = 1;
this.from = today.toISOString();
this.to = tomorrow.toISOString();
}
}
it's my code, thanks before.

html code
<ion-content padding class="homePage"> <ion-list no-lines> <ion-item> <ion-label><ion-icon name="key"></ion-icon> Room Type</ion-label> <ion-select [(ngModel)]="roomType"> <ion-option value="standard">Standard</ion-option> <ion-option value="studio">Studio</ion-option> <ion-option value="villa">Villa</ion-option> <ion-option value="penthouse">Penthouse</ion-option> </ion-select> </ion-item>
TS Code
import { Component } from '@angular/core'; import { NavController, LoadingController, AlertController } from 'ionic-angular'; @Component({ templateUrl: 'build/pages/home/home.html' }) export class HomePage { roomType: any; nights: any; rooms: any; from: any; to: any; constructor(public navCtrl: NavController, private alertCtrl : AlertController, private loadingCtrl : LoadingController) { let today = new Date(); let tomorrow = new Date(); tomorrow.setDate(+1); this.roomType = 'standard'; this.nights = 1; this.rooms = 1; this.from = today.toISOString(); this.to = tomorrow.toISOString(); } }
Thanks before.

Hello, thanks for using Ionic! Unfortunately I cannot reproduce this issue. Would you mind pulling this test I made https://github.com/jgw96/selectExample and testing? Thanks!

Ok. I will try soon ..

after comparing code a few days,  finaly i found the problem, i have some code in app.html, tab not working and make select and another component error,  thank you for your support.


Total values in asset share common statistics component

Hi Team,
In below asset share component
asset-share-commons/components/search/statistics
we a statistics html file
/apps/asset-share-commons/components/search/statistics/statistics.html
which gives runningtotal and total properties.
Total property  is actually giving the guess total values, it doesn't give the exact total count of assets. Is there a way that we can get exact total count also?

See docs here:
https://adobe-marketing-cloud.github.io/asset-share-commons/pages/search/results/
I believe there is a hard allowed maxvalue for guessTotal of 10,000.
So you can increase the guessTotal and youll get accurate results UP to that number - be very careful as this can significantly impact performance though. So performance test against your largest possible result sets. It is NOT recommended to make this number large due to potential performance impact.


Update Docker Images to support M1 Mac

I added multi-architecture support for docker images.

#1469

ToDo:

[ ] Update deploy tag file accrodingly

Hi, @alshedivat
I have fixed the docker problem in M1 (and M2) macbooks but since I do not have write access I can not resolve it. Could you give the write access in order to merge docker-related issues more quickly?

@pourmand1376, thanks for the PR with the changes. I gave you write access, so you should be able to merge.


sipsess: allow sending of "100 Trying" messages

This allows sending "100 Trying" messages

@maximilianfridrich Can you review this, I'm not sure if "100 Trying" can be used here:
rfc3262:

100 (Trying) responses are hop-by-hop only.  For this reason, the
reliability mechanisms described here, which are end-to-end,
cannot be used.

That is correct, 100 responses may not be sent reliably.
I am wondering, what is the motivation behind this change? @pitti98 If I am not mistaken, 100 Trying responses are usually sent by proxy servers.
Section 21.1.1 of RFC 3261:

100 Trying
This response indicates that the request has been received by the
next-hop server and that some unspecified action is being taken on
behalf of this call (for example, a database is being consulted).
This response, like all other provisional responses, stops
retransmissions of an INVITE by a UAC.  The 100 (Trying) response is
different from other provisional responses, in that it is never
forwarded upstream by a stateful proxy.

please read the spec carefully regarding 100 usage and 101-199 replies:
https://datatracker.ietf.org/doc/html/rfc3261#section-21.1.1
100 Trying should only be sent by a SIP Proxy...

Basically, we're implementing a SIP-to-something-else gateway, so 100 Trying seemed like a natural choice. I was surprised the library does not allow this. And I see no reason why this should not be allowed, unless the library's purpose is strictly limited to implement a "phone" and nothing else. But it seems powerful enough to implement a server/proxy. We also implemented our own registrar to handle REGISTER messages.
But I guess a 180 would also do the trick.

please read the spec carefully regarding 100 usage and 101-199 replies:
https://datatracker.ietf.org/doc/html/rfc3261#section-21.1.1
100 Trying should only be sent by a SIP Proxy...

I did read the spec again, and I didn't find any indication for that anywhere. It only says that stateful proxies must not forward it (because they generate their own 100 Trying locally). That doesn't mean that only proxies are allowed to send it. Rfc 3261 rather says that stateful proxies behave like UASes in that they generate their own reponses. So any UAS can send a 100 Trying, even a physical phone. It also says that the To-tag may be missing (in the case of a proxy), but the fact that it can contain a to-tag means that it comes from the called UAC, which means it may send a 100 Trying.
Rfc 3262 says that 100 is excluded from the 100rel mechanism, and that also makes sense because if it doesn't arrive, then the INVITE is simply resent. That also does not mean only proxies may send it.
On the contrary, 3261 specifially says in 17.2.1:

When a server transaction is constructed for a request, it enters the
"Proceeding" state.  The server transaction MUST generate a 100
(Trying) response unless it knows that the TU will generate a
provisional or final response within 200 ms, in which case it MAY
generate a 100 (Trying) response.

and that part is about server transactions in general, not specificly about proxies.
If the library is lacking the ability to send a 100 Trying, then it is missing an important part of the SIP protocol, even when you are not trying to implement a proxy.
We've had this patch in the library for 10 years now and it works. maximilianfridrich even confirmed that the code does the right thing.


Multi-select items in CtrlInventoryStacked

I love your inventory system. It saves so much work on development time.
I saw in https://github.com/peter-kish/gloot/issues/110 that multi-selection is not yet supported. Will this be added in the future? Right now we would have to select an item and then click the transfer button for each of the items we want to transfer.

Actually, never mind. I see now we're supposed to make our own UI and the one provided is for testing purposes. At least I got to tell you I really appreciate your work

Reopening this one as a reminder to implement this at some point.

I see now we're supposed to make our own UI and the one provided is for testing purposes.

Yeah, that was the initial idea. But since a lot of people are making heavy use of the provided UI controls, at some point I decided to flesh them out and make them more useful. That, of course, still doesn't stop anyone from creating their own UI based on the core functionality of the addon.

At least I got to tell you I really appreciate your work

Thanks!

Multi select mode for CtrlInventory, CtrlInventoryStacked, CtrlInventoryGrid and CtrlInventoryGridEx is implemented in v2.4.6 (holding down CTRL should allow you to select multiple items).


membrane tubulation/curvature

GO:0097320 membrane tubulation
is defined
A modification in a plasma membrane resulting in formation of a tubular invagination.
(check: maybe should this really be "plasma membrane curvature" to fit the definition, it sounds as though it might be describing the 'membrane curvature' process which results in invagination  ?)

add new term
GO:XXXXXX membrane curvature

GO:0071787 endoplasmic reticulum tubular network assembly
(probably should be renamed 'formation'?  it isn't really "assembly' as such?)
Name    endoplasmic reticulum tubular network assembly

And made  a descendent  of GO:1990809
GO:1990809 endoplasmic reticulum tubular network membrane organization

New term
GO:xxxxxx membrane curvature involved in  endoplasmic reticulum tubular network formation
(membrane curvature can then be used for all of the proteins like BAR domain and reticulon which introduce membrane curvature in various contexts (cytokinesis, tubulation etc)

Hi Val,
Sounds good, but could you please add more details, especially for the proposed new terms. See our recent guidelines below - please understand that we have to deal with many requests and that eliminating guesswork benefits both parties, editors as well as curators.
https://github.com/geneontology/go-ontology/blob/master/CONTRIBUTING.md
Thanks!

Also
GO:0070583	spore membrane bending pathway
(Paola I'll put this on my todo list but no hurry for me so it will probably sit for a while unless anyone needs it sooner).
There appear to be 3 mechanisms for the introduction of membrane curvature by proteins:
https://en.wikipedia.org/wiki/Membrane_curvature
(PomBase has a number of papers in this area, but they are  not on our immediate priority lists).

I can't find the ticket  or e-mail which prompted me to open this ticket as a 'placeholder'. It was a discussion about "membrane curvature/invagination/bending" the same day, or day before I opened this ticket.....
I don't suppose anyone else remembers.......
"lipid tube assembly" sounds like the same thing too.....

@ValWood I found the email, I'll send it to you

PMID: 27170174 is relevant to processes of sensing, bending, and stabilizing curved membranes, involving endophilin

Hi @ValWood ,
Summarising all comments in this request:
“1.
GO:0097320 membrane tubulation
is defined
A modification in a plasma membrane resulting in formation of a tubular invagination.
(check: maybe should this really be "plasma membrane curvature" to fit the definition, it sounds as though it might be describing the 'membrane curvature' process which results in invagination ?)”
To me, it sounds like GO:0097320 ‘membrane tubulation’ (“A modification in a plasma membrane resulting in formation of a tubular invagination.”) should be is_a GO:0099024 ‘plasma membrane invagination’ (“An infolding of the plasma membrane.”). This is confirmed by the abstracts of the PMIDs used as dbxrefs for the term (PMID: 15252009 and PMID: 20730103). Whether it should more specifically refer to the plasma membrane curvature step which eventually results in invagination, I’m not sure, would need to read the full text and see how it’s been used in annotations. It has 55 manual experimental annotations, plus 9 to regulation terms, mostly from FlyBase and UniProt.
“2.
add new term
GO:XXXXXX membrane curvature”
To me, ‘curvature’ sounds more like a quality than a process. It’s used in GO as such (e.g. def of ‘endoplasmic reticulum tubular network’: “A subcompartment of the endoplasmic reticulum consisting of tubules having membranes with high curvature in cross-section.”). We may wish to use a different wording, but I gladly accept suggestions from native speakers ;-) Maybe ‘membrane bending’ with ‘membrane curvature’ as a related synonym? Similar to GO:0070583 ‘spore membrane bending pathway’ that you also pointed to in this ticket.
In defining this process, we could refer to https://en.wikipedia.org/wiki/Membrane_curvature#Proteins_can_Induce_Curvature (as you also suggested). I’d have to look in more detail to see if we’d need specific children too. And of course there are recent reviews on the subject. Plus, @Pauldenny  suggested that “PMID: 27170174 is relevant to processes of sensing, bending, and stabilizing curved membranes, involving endophilin.”
At a first glance, I’m not sure if or how we’d want to link ‘membrane curvature’ and ‘membrane tubulation’, if the latter becomes is_a GO:0099024 ‘plasma membrane invagination’.
“3.
GO:0071787 endoplasmic reticulum tubular network assembly
(probably should be renamed 'formation'? it isn't really "assembly' as such?)”
‘endoplasmic reticulum tubular network formation’ is already an exact synonym, but I’m happy to swap it with the primary name if that better reflects community usage
“4.
And [GO:0071787 endoplasmic reticulum tubular network assembly] made a descendent of GO:1990809
GO:1990809 endoplasmic reticulum tubular network membrane organization”
Not really, as GO:0098826 ’endoplasmic reticulum tubular network membrane’ is bounding_layer_of GO:0071782 ’endoplasmic reticulum tubular network’.
“5.
New term
GO:xxxxxx membrane curvature involved in endoplasmic reticulum tubular network formation
(membrane curvature can then be used for all of the proteins like BAR domain and reticulon which introduce membrane curvature in various contexts (cytokinesis, tubulation etc)”
Sounds good, pending point 2 above.
I will now look at the related ticket https://github.com/geneontology/go-ontology/issues/12583 (opened by @BarbaraCzub.

Agree
Agree, "membrane bending" is a better term name (curvature related synonyms)
Eventually as required 'membrane bending involved in x' could be added to processes which have a 'membrane bending' component.
Are assembly and formation equivalent in GO, if so yes I think the swap would work
Ah OK its 'membrane' organization
Yes, see my response to 2.

That all seems to work out. That should give a framework that any of the unconnected terms can be placed under.

I wonder if "membrane bending"
should be a Molecular function, rather than a biological process?
https://en.wikipedia.org/wiki/Membrane_curvature#Proteins_can_Induce_Curvature
@ukemi @thomaspd

It seems like even in the cases described here, a single instance of bending is carried out by the action of more than instance of a gene product. I think that would make it a process.

Of course. So  what are the individual proteins doing?
lipid binding part_of membrane bending?

That is what I had in mind, but we need to be careful if there are cases where the protein is lipid modified. If the binding is being done by a lipoprotein that inserts itself into the membrane, is it still lipid binding?  I guess it is. I'm not sure if this is ever the mechanism for bending, but it is certainly the way some proteins interact with membranes.

I don’t think the number of one type of gene product is the right distinction between MF and BP.  I think the number of distinct types of activity is the right distinction.  For example, one way to increase the activity is to increase the number of gene products (of the same type) that each perform the process.  So “instance” of a gene product in general refers to a population, as is generally assumed in biochemical representations.
From: David Hill <notifications<EMAIL_ADDRESS>Reply-To: geneontology/go-ontology <reply<EMAIL_ADDRESS>Date: Wed, 19 Oct 2016 04:21:41 -0700
To: geneontology/go-ontology <go-ontology<EMAIL_ADDRESS>Cc: Paul Thomas <pdthomas<EMAIL_ADDRESS>Mention <mention<EMAIL_ADDRESS>Subject: Re: [geneontology/go-ontology] membrane tubulation/curvature (#12387)
Resent-From: Paul Thomas <pdthomas<EMAIL_ADDRESS>Resent-Date: Wed, 19 Oct 2016 04:21:49 -0700
It seems like even in the cases described here, a single instance of bending is carried out by the action of more than instance of a gene product. I think that would make it a process.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_geneontology_go-2Dontology_issues_12387-23issuecomment-2D254784905&d=DQMCaQ&c=clK7kQUTWtAVEOVIgvi0NU5BOUHhpN0H8p7CSfnc_gI&r=33hhNKh7WpvJRiaXHf366Q&m=LFveSlS1OzutLm1x-r8UaNvsPsEW-5-X_Oq8j-gpKCs&s=KX5MLDEeq3mo6UMuXc_aI-83uUzjHpHVzQkjzzcf_JA&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ALaXeNs-5FY9wBSUvKCILMmvc20Yg7-2DAm0ks5q1f1FgaJpZM4IAzfr&d=DQMCaQ&c=clK7kQUTWtAVEOVIgvi0NU5BOUHhpN0H8p7CSfnc_gI&r=33hhNKh7WpvJRiaXHf366Q&m=LFveSlS1OzutLm1x-r8UaNvsPsEW-5-X_Oq8j-gpKCs&s=9vuVdYiWm0zXQAP1d31-7A4ieKn0XdHdec4PGEuvmsc&e=.

DPH
It seems like even in the cases described here, a single instance of bending is carried out by the action of more than instance of a gene product. I think that would make it a process.

PDT
I don’t think the number of one type of gene product is the right distinction between MF and BP.  I think the number of distinct types of activity is the right distinction.

Sorry for side track.  Just want to note that this is a general issue that it would be useful to resolve as there are big implications for the way we model regulation in LEGO.

I agree. We have always had this problem. DNA polymerase is a single activity spread among a number of genes. We also have problems describing the activity of, for example a  "ribosome". It usually ends up with a mish-mash of RNA binding, structural activity molecular functions (which are sometimes also valid functions). However, the primary elemental activity of the ribosome is
as a "peptidyl transferase". Remarkably, this term only has 4! experimental annotations!
I guess some issues will be resolved by the ability to annotate "complex objects" in addition to "gene product objects".  Still, we need better guidelines about what constitutes an activity. Its independent of the number of genes for sure. I think of it as  an elemental part of a process which cannot be decomposed further....I'm sure there's a better way to articulate this ;)
I this case I do think "membrane bending" might be a  valid molecular function...

When I was at SGD, I remember wanting a term for "membrane bending". It's been a while, so I'm a little hazy on details and no longer remember which gene this was, but I definitely thought that "membrane bending" was the accurate description of its function.
-Karen
P.S. There's probably an old SourceForge ticket on this because I requested terms, but I think that ticket stalled.

Hi @krchristie ,
You were probably thinking of this old ticket, see your comment here https://github.com/geneontology/go-ontology/issues/11280#issuecomment-124916490. I think it's fine to continue the discussion we started on 'membrane bending' here (as soon as I have a chance to do so...), but if there's anything from that old ticket that you'd like to report/summarize here, please feel free. Thanks.

Hi @ValWood ,
I addressed point 1) in my comment https://github.com/geneontology/go-ontology/issues/12387#issuecomment-252883795 by doing the edits in https://github.com/geneontology/go-ontology/issues/12583#issuecomment-268312161.
I'll address the other points after the holidays.

Have o great break, speak to you in the New Year.
Val

Hi @ValWood,
Back to point 2 in https://github.com/geneontology/go-ontology/issues/12387#issuecomment-252883795 i.e. “add new term GO:XXXXXX membrane curvature”. Summarising input from you and others in this ticket, so far we agreed on:
name: membrane bending
synonym: membrane curvature [related]
Open questions:

Should ‘membrane bending’ be a BP or an MF? What are the individual proteins doing? ‘lipid binding’ part_of ‘membrane bending’?
Based on the examples in https://en.wikipedia.org/wiki/Membrane_curvature#Proteins_can_Induce_Curvature, it seems to me that the mechanisms can be multiple and diverse enough that it would be difficult to say that ‘membrane bending’ has_part e.g. ‘lipid binding’. And I wouldn’t say that ‘lipid binding’ is part_of ‘membrane bending’ either - lipids may also form micelles - we probably wouldn’t capture that in GO, but it’d still be true that lipids can bend without forming membranes. Looking at the clathrin example, I’d say that clathrin-mediated membrane bending involves recruitment of clathrin to the membrane through signaling molecules (a process), assembly of clathrin molecules into larger polymeric structures that form a rigid structure which serves as a frame for the membrane (protein binding? i.e. a function), binding of clathrin to its receptors in the membrane (again protein binding, but a different event than the previous one). To me, all this makes ‘clathrin-mediated membrane bending’ a BP. It seems that the safest way to go would be to create a generic BP term for ‘membrane bending’ with specific children for the mechanisms we know (such as the clathrin one). A recent review on the subject, PMID:25774051, points in the same direction (“…it is very likely that additional mechanisms underlying membrane shaping will be uncovered in the near future…”). If we can reach agreement on this shortly, I could start on a basic structure:

[ ] add
GO:NEW membrane bending
is_a membrane organization
Def: A membrane organization process resulting in the bending of a membrane.
GOC:pr, GOC:vw, https://en.wikipedia.org/wiki/Membrane_curvature
synonym: membrane curvature [related]

GO:NEW membrane bending, and its regulation terms (easy to create via TG), could respond to some annotation needs e.g. @krchristie’s. 'membrane bending involved in x' terms could also be created via TG if/as needed. E.g., @ValWood could create GO:NEW ‘membrane bending involved in endoplasmic reticulum tubular network formation’ once I have done the following:

[ ] Swap primary name and exact synonym of GO:0071787 ‘endoplasmic reticulum tubular network assembly’ so it becomes ‘endoplasmic reticulum tubular network formation’.

With these edits, I’d have addressed the key requests from @ValWood in this ticket.

[ ] A careful examination of PMID:25774051 could provide tips on further dissecting ‘membrane bending’ and suggest proteins to annotate to it or to its regulation. This could be done in a second stage and by others if I can’t get to it.

[ ] I could also add
GO:NEW clathrin-mediated membrane bending
is_a GO:NEW membrane bending
has_part clathrin coat assembly
Def: A membrane bending process mediated by clathrin.
GOC:pr, https://en.wikipedia.org/wiki/Membrane_curvature

But if this topic needs more extensive discussion, I will need to leave it at that and unassign myself from this ticket. :-)

I agree with all of your points above. I think these basic changes would be useful, and allow us to
incrementally make any adjustments required. It addresses the overall problem.

Done. The new terms are
[Term]
+id: GO:0097753
+name: membrane bending
+namespace: biological_process
+def: "A membrane organization process resulting in the bending of a membrane." [GOC:krc, GOC:pr, GOC:vw, http://en.wikipedia.org/wiki/Membrane_curvature]
+synonym: "membrane curvature" RELATED []
+is_a: GO:0061024 ! membrane organization
+[Term]
+id: GO:0097754
+name: clathrin-mediated membrane bending
+namespace: biological_process
+def: "A membrane bending process mediated by clathrin." [GOC:pr, http://en.wikipedia.org/wiki/Membrane_curvature]
+is_a: GO:0097753 ! membrane bending
+relationship: has_part GO:0048268 ! clathrin coat assembly

Left to do for this ticket, and not urgent:

[ ] A careful examination of PMID:25774051 could provide tips on further dissecting ‘membrane bending’ and suggest proteins to annotate to it or to its regulation. This could be done in a second stage and by others if I can’t get to it.

Hi @ValWood ,
The only task remaining for this ticket is low priority and pertains to annotation as well as ontology. I'll assign it to you since you opened the ticket originally and so it doesn't fall through the cracks. Thanks.

I'll close this one (effectively un-assigning myself).
I'm going to open a new ticket though :(


Fixed #3664

What does the pull request do?
Fixes incorrect order of parameters for DataGrid.SelectionChangedEventArgs event
What is the current behavior?
Added and removed items are passed in incorrect order to SelectionChangedEventArgs
What is the updated/expected behavior with this PR?
Added and removed items are passed in correct order to SelectionChangedEventArgs
Fixed issues
Fixes #3664

Hey @ingvar1995 - sorry I think I might be missing something. The order of arguments to SelectionChangedEventArgs is removedItems, selectedItems:
https://github.com/AvaloniaUI/Avalonia/blob/master/src/Avalonia.Controls/SelectionChangedEventArgs.cs#L21
So it looks like the order is already correct, and this PR is making them incorrect? What am I missing? :)

Ah I understand: this was already fixed on master by #3526, but that hasn't been backported to a stable release. Looks like you swapped the order of parameters without checking if they're already correct?

Heh, sorry, seems that it was swapped since latest nuget release, my fault :)

No, problem, thanks anyway!


Proposal: Support for callback_url

We would like to implement a mechanism to allow Task submitters to specify a callback_url that will be used by TES to POST any change in status to the callback_url.
Requirements:

Task submitter must be able to specify a single callback_url as part of the TesRequest
TES will POST the full TesResponse to the callback_url on change in status using any (optional) auth headers

Related Issue: WES#133

One thing to think about is whether the task submitter/client should be required/encouraged to send a secret alongside the callback_url that could then be sent back to the client together with the TesResponse. This might help prevent third parties from messing with task states.

PR available: #176


Serverside Export of Presentation in BBB 2.6

Is there an option to do an pdf export of all presentations with annotations in 2.6? (Serverside - like described in pdf-export-serviside branch)?

BBB 2.6 natively supports exporting presentations with annotations; this is done server-side. If I understand it correctly, you want to automatically run the export as soon as the meeting is over?


[Feature request] Show cursor location in packge editor

Can we have the cursor position shown in the bottom bar in the package editor, as it's shown in the SQL editor?

Good point.
Thanks for noticing.


open_dataset with chunks="auto" fails when a netCDF4 variables/coordinates is encoded as NC_STRING

What is your issue?
I noticed that open_dataset with chunks="auto" fails when netCDF4 variables/coordinates are encoded as NC_STRING.
The reason is that xarray reads netCDF4 NC_STRING as object type, and dask cannot estimate the size of a object dtype.
As a workaround, the user must currently rewrite the netCDF4 and specify the string DataArray(s) encoding(s) as a fixed-length string type (i.e "S2" if max string length is 2) so that the data are written as NC_CHAR and xarray read it back as byte-encoded fixed-length string type.
Here below I provide a reproducible example
import xarray as xr
import numpy as np

# Define string DataArray
arr = np.array(["M6", "M3"], dtype=str)
print(arr.dtype) # <U2
da = xr.DataArray(data=arr, dims=("time"))
data_vars = {"str_arr": da}

# Write dataset with NC_STRING
ds_nc_string = xr.Dataset(data_vars=data_vars)
ds_nc_string["str_arr"].encoding["dtype"] = str
ds_nc_string.to_netcdf("/tmp/nc_string.nc")

# Write dataset with NC_CHAR
ds_nc_char = xr.Dataset(data_vars=data_vars)
ds_nc_char["str_arr"].encoding["dtype"] = "S2"
ds_nc_char.to_netcdf("/tmp/nc_char.nc")

# chunks="auto" does not work when string arrays are saved as NC_STRING
# --> NC STRING is read as an object, and dask can not estimate chunk size !!!
ds_nc_string = xr.open_dataset("/tmp/nc_string.nc", chunks="auto")  # NotImplementedError
ds_nc_char = xr.open_dataset("/tmp/nc_char.nc", chunks="auto")      # Works

# NC_STRING is read back as object
ds_nc_string = xr.open_dataset("/tmp/nc_string.nc", chunks=None)
ds_nc_string["str_arr"].dtype  #  object

# NC_CHAR is read back as fixed length byte-string representation (S2)
ds_nc_char = xr.open_dataset("/tmp/nc_char.nc", chunks=None)
ds_nc_char["str_arr"].dtype            #  S2
ds_nc_char["str_arr"].data.astype(str) #  U2

Questions:

open_dataset should not take care of automatically deserializing the NC_CHAR fixed-length byte-string representation into a Unicode string?
open_dataset should not take care of automatically reading NC_STRING as Unicode string (converting object to str)?

Related issues are:

https://github.com/pydata/xarray/issues/7652
https://github.com/pydata/xarray/issues/2059
https://github.com/pydata/xarray/pull/7654
https://github.com/pydata/xarray/issues/2040

@ghiggi Thanks for getting this back into action. I got tracked away from the one string object issue in #7654. I'll split this out and add a PR.

@ghiggi I'd appreciate if you could test your workflows against #7869. Your example and the one over in #7652 are working AFAICT.

Thanks @kmuehlbauer ! https://github.com/pydata/xarray/pull/7869 solve the issues !
Summarizing:

With #7869, netCDF4 with NC_STRING variable arrays are now read into xarray as Unicode dtype (instead of object)
As a consequence dask can estimate the array's size and xr.open_dataset(fpath, chunks="auto") does not raise anymore the NotImplementedError.
NC_CHAR variable arrays continue to be read into xarray as fixed-length byte-string dtype. Maybe something more could be done to deserialize also NC_CHAR to Unicode. However, this might cause some backward incompatibilities and might be better to address this in a separate PR.

Thanks again @kmuehlbauer  for having resolved the problem in less than 2 hours :1st_place_medal:

@ghiggi Glad it works, but we still have to check if that is the correct location for the fix, as it's not CF specific.

Thanks @ghiggi for your comment.
The problem is we have at least two contradicting user requests here, see #7328 and #7862.
I'm sure there is a solution to accommodate both sides.

UPDATE
I updated the reproducible code snippets after seeing https://github.com/pydata/xarray/pull/7948.
By using chunks={} instead of chunks="auto" is already possible to read NC_STRING arrays into a (single chunk) dask array.  If https://github.com/pydata/xarray/pull/7948 is merged, then using chunks={} would allow obtaining a dask.array with the same chunk size as in the netCDF file.
NOTE:
PR https://github.com/pydata/xarray/pull/7948 does not the problem related to ``chunks="auto" ` nor the decoding of the string.


CSR Creation seg faults when running with pragma enable_verification

What happens?
see title
To Reproduce
Set pragma enable_verification and create a CSR
OS:
macOs 13 - Apple M1 Pro
DuckDB Version:
latest
DuckDB Client:
CLI
Full Name:
Daniel ten Wolde
Affiliation:
CWI
Have you tried this on the latest master branch?

[X] I agree

Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?

[X] I agree

This will be fixed whenever we introduce the path-finding operator in #93 since the CSR will be a structure contained in the physical operator. Not closing this for now as it is currently still a bug.


Validate maxAge appropriateness before use

Addresses issue #3935 .

@dougwilson I've added tests.

Thanks. The conversation in the issue needs to be resolved first so we know what the appropriate fix is. Then I will review the PR once that is known :+1:

I'll do so once we officially decide how we'd like to handle this.


bot requesting feedback for a completed recruit

made sure that only active recruits are pushed into remainingRecruits array.  all active/complete recruits still returned with getCurrentRecruits


Delete book directory

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.333%

Totals

Change from base Build<PHONE_NUMBER>0:
0.0%

Covered Lines:
14

Relevant Lines:
15

💛  - Coveralls


Point to a live documentation

Summary of changes
The previous link, https://packaging.python.org/en/latest/specifications/declaring-project-metadata/, ends with 404.
Update the link to point to the actual documentation

Thank you @befeleme.


[fix] SS_TreeNavi : error occured when number only filename node exists

Coverage decreased (-12.2%) to 70.542% when pulling 1fa22602c6992bf411e6b9b36fbe9bdb1f1f3ca6 on itowtips:fix-tree-navi into 34ed489faa97c69afdd79b428be02889fca1b3ef on shirasagi:master.


Fixing assertion from stuck items in high contention race condition

Fixing assertion trying to release lock in race condition with high contention. The assertion resulted in an item that was stuck and locked by a previous transaction, but was in a safe state consistent with all other items in the transaction.
The resulting exception had the message: 'Item should not have been applied.  Unable to release lock'. This exception resulted in an item that could not be unlocked automatically by the library. However when an item got into this state, the transaction lock attributes could safely be deleted from the stuck item manually, and future transactions involving this item would continue.
This change makes all operations to the Transaction Item use conditional writes on the version number, whereas before there was one unlock case that was trying to be too clever and use other conditions instead of the version number.

The crux of this problem is that, what a transaction looks like in a coordinator's data structure is different from the truth. The solution to this problem given by the algorithm is that:

If we read a transaction whose state is either committed or rolledback, we are guaranteed that this read state is the true state at all times, since it never changes after a commit or rollback.

Therefore, implementation wise, this bug can also be fixed by invoking loadRequests in
https://github.com/awslabs/dynamodb-transactions/blob/master/src/main/java/com/amazonaws/services/dynamodbv2/transactions/TransactionItem.java#L510 .
In fact, we also always be calling loadRequests whenever we update txItem, since conceptually speaking we should always update our internal representation of a transaction whenever we read a refreshed version of it.


Comment color in Zen theme is very low contrast

It feels that the current comment color in Black Zen is unnecessarily dark, compared to the (non-Zen) Black theme:
https://github.com/moegi-design/vscode-theme/blob/0fb906b2727e6447dfa14ab06c70243749f8ef38/themes/moegi-black-zen-color-theme.json#L242
Black Zen:

Black:

Both Black and Dark themes use a different shade of gray, so maybe it's worth using the same for Zen?
https://github.com/moegi-design/vscode-theme/blob/0fb906b2727e6447dfa14ab06c70243749f8ef38/themes/moegi-dark-color-theme.json#L242
https://github.com/moegi-design/vscode-theme/blob/0fb906b2727e6447dfa14ab06c70243749f8ef38/themes/moegi-black-color-theme.json#L242

Yes, I think you are right, the comment color is indeed so dark. Thanks!
There's a bit of work to do next before going live. The color of keywords(#747476) is needed to be adjusted, otherwise they would be similar to the comments.


Split wasm-metadata into separate files

I'm planning to file a number of patches to wasm-metadata, but I realized those would probably be easier to review if I split the file into separate files first. This splits the original 1500+ line file into separate files library and test files. This PR intentionally does not include any logic changes, all code is otherwise left unmodified. Thanks!
edit: I guess I did add a one-line doc comment at the top of lib.rs. So technically that's one change :)

CI is failing because of #1918

Filed a fix for #1918 in https://github.com/bytecodealliance/wasm-tools/pull/1919. Once that's been merged we can rebase this PR and CI should pass.

Looks like this should be good to merge now!


Deactivate completly global SLAM in offline mode

Update: changed title and edits for clarity
Hello,
Is it possible to deactivate the final optimization step for easy tuning of local slam
In order to see the result of the tuning of the local slam, I deactivated the global slam as recommended in the documentation with the following parameter.
POSE_GRAPH.optimize_every_n_nodes = 0
However, when using offline mapping, at the end of the process there is a final optimization which is realigning all the submaps. It is working superbly hence it doesn't allow to see the result of the local slam tuning.
I would like to desactivate this optimization. I did not fine a parameter controlling it. Is there any?
There is the parameter POSE_GRAPH.max_num_final_iterations  (200 by default), but it cannot be set to 0.

Coming back on this.
Or alternatively, any efficient method to test the results of local slam tuning?

Any news so far on that issue? I am having the same problem (but I am using the cartographer_ros package). I looked up the source code (offline_node.cc) and saw the following lines in the end:
// Here is the loop where bag msgs are published. And here is the crucial part I guess:
...
if (is_last_message_in_bag) {
node.FinishTrajectory(trajectory_id);
}
}
// Ensure the clock is republished after the bag has been finished, during the
// final optimization, serialization, and optional indefinite spinning at the
// end.
clock_republish_timer.start();
node.RunFinalOptimization();
...
// After this some logs are printed and so on...
There is no option to run (or not run) the final optimization. So there seems to be no choice in the offline node at this point. As I want to compare several datasets / configurations based on accuracy, it would be great to have other options for automizing several runs in a row and using only local SLAM by choice.
Does anyone know if there is another way of making sure global SLAM is disabled in the offline node (e.g. using the lua file or launch file)?

I just commented out node.RunFinalOptimization() for first and it works as quick and dirty solution. If any better (selectable) solution is found I would prefer that of course.

Commenting this old post because I think this could be very helpful for sistematic Local SLAM evaluation and tuning
I'll probably modify
https://github.com/cartographer-project/cartographer/blob/105c034577220268cd28a304a185adbec46b729f/cartographer/mapping/internal/3d/pose_graph_3d.cc#L811-L829
and
https://github.com/cartographer-project/cartographer/blob/105c034577220268cd28a304a185adbec46b729f/cartographer/mapping/internal/2d/pose_graph_2d.cc#L841-L859
to something like this
void PoseGraphnD::RunFinalOptimization() {
  if (options_.max_num_final_iterations() > 0) {
    AddWorkItem([this]() LOCKS_EXCLUDED(mutex_) {
      // etc
    });
    AddWorkItem([this]() LOCKS_EXCLUDED(mutex_) {
      // etc
    });
  }
  WaitForAllComputations();
}

If this does have the intended effect, I could make a pull request
Cheers,
Luca

Greetings @lucamozza! Must one rebuild the workspace after changing this file?

Greetings @lucamozza! Must one rebuild the workspace after changing this file?

Absolutely, you need to build again cartographer.
cheers, Luca


How to draw a Rectangle at an angle

Is there any way I can create rectangle at an angle like this one?

@codeofsumit can this be implemented using leaflet pm?

Hi @mohammedzamakhan, not right now, no. But it's a nice feature to have. I think it could be done with a rotating feature but I have to think about it. Will close to wait for upvotes in order to prioritize it


Active Record Wallet Adapter

Store tx and utxo in database via activerecord when the transaction is broadcasted.
Search the utxo from database to build transactions or to get balances.
Not support to manage tx and utxo that are generated by out of glueby library.

tasks

Implement ActiveRecordWalletAdapter as a class inherited from AbstractWalletAdapter, and

Implement Wallet, Key, Utxo classes as an ActiveRecord
Implement generators for the migration database tables.

Implement state transition

Utxo should be unspendable when the transaction will use it as an input.
Utxo should change its state to "broadcasted" when the transaction will be broadcasted.
Utxo should change its state to "finalized" when the transaction will be finalized.
Utxo should be deleted when the transaction that uses it as an input will be finalized.

Implement other utilities.

rake task to synchronize tapyrus blockchain and import Utxos from external transactions.

Implement other utilities.
- rake task to synchronize tapyrus blockchain and import Utxos from external transactions.

I will implement rake task which has following interface
rails glueby:contract:wallet_adapter:sync_block <block_hash>

if <block_hash> is specified, it calls getblock RPC and store utxos to the database.
if not specified, it calls getbestblockhash, then call getblock recursively.
To do so, we need to keep track of the block height, which represents how long it has synced up.


[AllowNull()] should be usable with value-type parameters too

When you declare a non-mandatory parameter and do not pass an argument on invocation, the parameter variable is implicitly $null - even if its declared type is a (non-numeric) value type (instances of which cannot contain $null).
PS> & { param([datetime] $dt) $null -eq $dt } # no value is passed to -dt

True  # $dt was $null, even though a [datetime] instance cannot be $null

Note: By contrast, numeric value types default to 0, i.e. the type's default value. This inconsistency is problematic in itself, but it's presumably too late to change that.
However, if you want to allow explicit passing of $null, the same approach does not work:
PS> & { param([AllowNull()] [datetime] $dt) $null -eq $dt } -dt $null # !! FAILS

Cannot process argument transformation on parameter 'dt'. Cannot convert null to type "System.DateTime".

Similarly, numeric value-type parameters effectively coerce the $null to the type's default value, 0, meaning that $null as a "signal value" is lost:
PS> & { param([AllowNull()] [int] $i) $null -eq $i } -i $null

False # !! $false, because $i becomes 0

The - cumbersome - workaround is to use [Nullable[datetime]] as the parameter type instead - and note that if the parameter is mandatory, you also need AllowNull().
Explicit use of nullable types in the context of parameter declarations shouldn't be necessary in PowerShell; I suspect that many PowerShell users may not even be aware of the distinction between reference types and value types.
As for a real-world use case: It's conceivable to have a mandatory parameter - one you want to force the users to pass a value intentionally to - that still supports $null - even with value types - as an explicit signal that a default value should apply.
Steps to reproduce
{ & { param([AllowNull()] [datetime] $dt) $null -eq $dt } -dt $null } | Should -Not -Throw

& { param([AllowNull()] [int] $i) $null -eq $i } -i $null | Should -Be $true

Expected behavior
The tests should pass.
Actual behavior
The 1st test fails:
Expected no exception to be thrown, but an exception "Cannot process argument transformation on parameter 'dt'. Cannot convert null to type "System.DateTime"." was thrown ...

The 2nd test fails:
Expected $true, but got $false.

That is, $i became 0 rather than being retained as $null.
Environment data
PowerShell Core 7.0.0-preview.4

So, to summarize in brief -- you're proposing that [AllowNull()][int] automatically implies we should transform that parameter into [Nullable[int]]?
I mean, that seems fairly sensible.

@vexx32:
Conceptually that is a good summary.
However, I don't think that it is technically necessary:
What seems to be happening in the implicit case is that the parameter variable is simply not initialized, which is what makes its value $null by default.
However, the type constraint is in effect, and is enforced if you later try to assign to that variable (although you typically wouldn't do that with a parameter variable):
PS> & { param([datetime] $dt) $dt = $null } # FAILS, because $dt, despite being initially $null, IS type-constrained

Cannot convert null to type "System.DateTime".

While I'm not familiar with the plumbing, my guess is that we can apply this non-initialization technique in the explicit case too - without needing to involve Nullable<T>.

@vexx32: I've since realized that the non-initialization to $null only applies to non-numeric value types. With numeric ones you get 0, which presents a different problem with [AllowNull()]: passing $null quietly converts to 0 - I've updated the OP accordingly.

Hmm, interesting. Given that [nullable[T]] doesn't let Mandatory parameters accept null values, and with the odd behaviour with numeric inputs there...
I'm not really sure what the optimal solution is there. I think I'm still partial to having [AllowNull()] make it a [nullable[T]] implicitly, I think, as that would probably be a fairly minimal and least-likely-to-break-something change, and neatly skirts the slightly awkward syntax for [nullable[int]]$Count etc.
But yes, it's not necessarily the idea solution. I'm also not sure simply "not initializing" the value is something we can do without taking some extra care, because I wouldn't be surprised if trying to do that excludes it from $PSBoundParameters; and for those parameters where you want to be able to detect the difference between "not specified" and "null", that is a fairly critical piece of plumbing.

@vexx32:
First, as an aside: that non-bound value-type parameters behave differently depending on whether they're numeric (default to 0) or not (default to $null) is problematic in itself, but it's probably too late to fix that inconsistency.

[nullable[T]] doesn't let Mandatory parameters accept null values

Maybe I'm misreading your comment, but [Nullable[T]] does work as a workaround even with numeric value types:
PS> & { param([Parameter(Mandatory)] [AllowNull()] [nullable[int]] $i) $null -eq $i } -i $null

True

I'm also not sure simply "not initializing" the value is something we can do without taking some extra care

Fair point - we certainly want $PSBoundParameters to continue to tell the truth.
I don't know enough about PowerShell's variable plumbing to be of help there, but I do see that trying to initialize a [datetime] variable with $null does not work:
# Borrow a [datetime] argument-transformation attribute from a regular variable.
[datetime] $dt = 0; $ta = (Get-Variable dt).Attributes[0]

# !! FAILS
[psvariable]::new(
  'foo',
  $null,  # initial value
 'None',
 [System.Collections.ObjectModel.Collection[System.Attribute]] $ta
)

That said, the .Value property of System.Management.Automation.PSVariable instances is object-typed, so I think it's at least possible to initialize to $null.
But perhaps [Nullable[T]] is indeed the answer. If it is, we should make sure it doesn't peek from behind the curtain or at least not cause obscure variations in behavior.

@mklement0 I mean that [nullable[T]] without using [AllowNull()] doesn't work. But yes, that is a currently available workaround, if one that feels very redundant. 🙂
Your example with datetime there makes me wonder if we may simply are missing some checks for the [allownull()] attribute when setting variables, though, if we can't even initialize them like that. Note that this also fails:
[AllowNull()][datetime]$value = $null

Potentially we need to simply add a check for whether the variable has the [AllowNull()] attribute before we try to create an instance of [datetime] (or anything else) with a null value...

Yes, I've noticed that [AllowNull()][datetime]$value = $null fails, and so does later assigning $null to a parameter variable declared this way.
So it sounds like in a manner of speaking we could roll our own nullable types, without actually needing to use [Nullable[T]], correct?
That is, if the [AllowNull()] attribute is set on a value-type-constrained variable, allow assigning $null as-is (make .Value return null) rather than attempting to convert $null to the type.

Aye, I think either we need to do that, or if that is unfeasible or ends up being more misleading, we may want to make [AllowNull()] imply the use of [nullable[T]] instead.


Hacky way to run ZoeDepth with modern timm (e.g. timm==0.9.8)

Instead of
import torch

repo = "isl-org/ZoeDepth"
model_zoe_nk = torch.hub.load(repo, "ZoeD_NK", pretrained=True)

Run the following monkey-patching code:
import torch

repo = "isl-org/ZoeDepth"
model_zoe_nk = torch.hub.load(repo, "ZoeD_NK", pretrained=False)
pretrained_dict = torch.hub.load_state_dict_from_url('https://github.com/isl-org/ZoeDepth/releases/download/v1.0/ZoeD_M12_NK.pt', map_location='cpu')
model_zoe_nk.load_state_dict(pretrained_dict['model'], strict=False)
for b in model_zoe_nk.core.core.pretrained.model.blocks:
    b.drop_path = nn.Identity()

Tested with timm==0.9.8

I'm getting an error running this "name 'nn' is not defined"

OK, this is working for me with:
import torch

repo = "isl-org/ZoeDepth"
model_zoe_nk = torch.hub.load(repo, "ZoeD_NK", pretrained=False)
pretrained_dict = torch.hub.load_state_dict_from_url('https://github.com/isl-org/ZoeDepth/releases/download/v1.0/ZoeD_M12_NK.pt', map_location='cpu')
model_zoe_nk.load_state_dict(pretrained_dict['model'], strict=False)
for b in model_zoe_nk.core.core.pretrained.model.blocks:
    b.drop_path = torch.nn.Identity()

@decamun thanks for the catch, I forgot import torch.nn as nn. Your solution is works as well, obviously.

Hey @ducha-aiki, any chance you know of a workaround for the issue I'm having in #84?

Hi, I noticed that the issued keys are:

The above monkey patch seems ignore the atten layers.


[PORT] Fix bot state so that the context service key is used consistently to access the cached state

Port this change from botbuilder-dotnet/master branch:
https://github.com/microsoft/botbuilder-dotnet/pull/3727

Fixes #3643
A bot state class's "context service key" is used to access the cached bot state in the turn state collection. Because the context service key is usually the name of the type (e.g. "UserState") there were some cases where the SDK was just using the type name instead of the actual context service key. This fails when a bot state class has a context service key that's different from the name of the type, as my new tests show.
In the case of a bot state memory scope, I also fixed the code to not rely on reflection to access the cached bot state. BotStateMemoryScope<T>.GetMemory now accesses the bot state instance in the same way that BotStateMemoryScope<T>.LoadAsync and BotStateMemoryScope<T>.SaveChangesAsync do, and once it has the bot state instance it can simply call BotState.Get. Because the classes that call GetMemory are expecting a dictionary and not a JObject, I modified BotState.Get to return an IDictionary<string, object>. I believe this is an improvement because that's the form that the cached bot state is already in and there's no need to convert it to a JObject. While it may seem like a dangerous change, the only place that BotState.Get is used is in one InspectionMiddleware method, and if any customers are using it and expecting a JObject then the compiler will just tell them to convert it to a JObject on their end, so there won't be any surprising behavior changes. I'm confident that the code is better this way and I can't imagine this breaking anything because the tests are all passing.
I have discovered that the problems I was seeing in BotStateMemoryScope<T> were not about GetMemory returning a JObject instead of a dictionary, they were about BotState.Get returning a copy of the of the state, which means any modifications wouldn't persist. I have also discovered that my "best option" to fix BotStateMemoryScope<T> by having Get return the original dictionary instead of a JObject will not work because it violates the contract. I see four other options:

Create a new public Get method (with a different name) to return the actual dictionary instead of a copy
Create an internal Get method and have the Bot Builder assembly share its members with the dialogs library
Create a private Get method and have BotStateMemoryScope<T>.GetMemory access it using reflection
Don't create any new methods and have BotStateMemoryScope<T>.GetMemory use reflection twice

I went with option 4 because it's the most similar to the way things are currently set up. The reason we need to use reflection twice is because the CachedBotState class is private and the context service key we need to access it is also private.
EDIT: I've thought of a fifth option. Since bot state is meant to be accessed using bot state property accessors, we could try to rework the adaptive dialogs library to access bot state using bot state property accessors. This would probably represent significant work/changes so I would not attempt it without some kind of go-ahead from the SDK team.
Changed projects

Microsoft.Bot.Builder.Dialogs
Microsoft.Bot.Builder
Microsoft.Bot.Builder.Dialogs.Tests
Microsoft.Bot.Builder.Tests

@v-kydela, does this apply to JS? Can you close it if it doesn't?
Thanks

@gabog - It looks like state storage is implemented differently in JS, and the original bug looks like it was caused by copying some code from JS to C#. I don't think this issue applies, so I'll close it.


cyclohexane_water packmol box leads to unstable simulation

Expected Behavior
Parameterizing systems/packmol_boxes/cyclohexane_water.pdb (a box with one cyclohexane and a few hundred waters) should lead to a straightforward simulation.
Actual Behavior
Taking steps of 1 or 2 femtoseconds, hydrogens on the cyclohexane molecule move rapidly and, after <10 steps, cause the simulation to crash. Investigating the parameters by eye shows the correct bond connectivity, with reasonable k and d values, and a quick look at angles and torsions doesn't show anything out of place either. The starting geometry of the cyclohexane looks reasonable, and measuring the bonds and angles numerically shows values close to equilibrium.
Taking steps of 0.1 femtoseconds, the simulation completes, but the cyclohexane has far more kinetic energy than other molecules in the system. Video below:

Removing all molecules except the cyclohexane from the starting PDB leads to an unremarkable simulation that is stable with steps of 2 fs.
Removing all molecules except the cyclohexane and one water from the starting PDB leads to an unremarkable simulation that is stable with steps of 2 fs.
Ideas
Given that the simulation is totally stable when less particles are present, this may be a heating/thermostat issue. One thought is that the only PeriodicTorsions in the system are in the cyclohexane, and maybe that's leading to an unequal distribution of energy.
Minimal Reproducible Example
from simtk.openmm.app import PDBFile
from openforcefield.utils import get_data_file_path
pdb_file_path = get_data_file_path('systems/packmol_boxes/cyclohexane_water.pdb')
pdbfile = PDBFile(pdb_file_path)
from openforcefield.topology import Molecule
cyclohexane = Molecule.from_smiles('C1CCCCC1')
water = Molecule.from_smiles('O')
from openforcefield.topology import Topology
from openforcefield.typing.engines.smirnoff import ForceField

# Create the Open Force Field Topology from an OpenMM Topology object.
omm_topology = pdbfile.topology
off_topology = Topology.from_openmm(omm_topology, unique_molecules=[cyclohexane, water])

# Load the smirnof99Frosst force field.
forcefield = ForceField('smirnoff99Frosst.offxml')

# Parametrize the topology and create an OpenMM System.
system = forcefield.create_openmm_system(off_topology)
from simtk import openmm, unit

# Propagate the System with Langevin dynamics.
time_step = 1*unit.femtoseconds  # simulation timestep
temperature = 300*unit.kelvin  # simulation temperature
friction = 1/unit.picosecond  # collision rate
integrator = openmm.LangevinIntegrator(temperature, friction, time_step)

# Length of the simulation.
num_steps = 1000  # number of integration steps to run

# Logging options.
trj_freq = 1  # number of steps per written trajectory frame
data_freq = 1  # number of steps per written simulation statistics

# Set up an OpenMM simulation.
simulation = openmm.app.Simulation(omm_topology, system, integrator)

# Set the initial positions.
positions = pdbfile.getPositions()
simulation.context.setPositions(positions)

# Randomize the velocities from a Boltzmann distribution at a given temperature.
simulation.context.setVelocitiesToTemperature(temperature)

# Configure the information in the output files.
pdb_reporter = openmm.app.PDBReporter('trajectory.pdb', trj_freq)
state_data_reporter = openmm.app.StateDataReporter('data.csv', data_freq, step=True,
                                                   potentialEnergy=True, temperature=True,
                                                   density=True)
simulation.reporters.append(pdb_reporter)
simulation.reporters.append(state_data_reporter)

simulation.step(num_steps)

Optionally:
from simtk.openmm import XmlSerializer
from pprint import pprint
pprint(XmlSerializer.serialize(system))

Specifications

Version: current master

@SimonBoothroyd points out that, if we minimize the system beforehand, using simulation.minimizeEnergy(), the simulation can be run at a 2 fs timestep with no problems. I am able to reproduce this, but I see that the cyclohexane coordinates after minimization are quite different than before. This is confusing, as I inspected the geometry by eye and did several measurements of bond lengths and angles and didn't find anything severely out of place.

A useful step forward would be to investigate the energy by component, to help narrow down what to check by eye.

You should always minimize the energy prior to simulation to ensure stable simulations. It's likely that the packmol-generated boxes have atom-atom contacts much tighter than equilibrium simulations, so simulating directly from these will dump a huge amount of energy into the system that the Langevin thermostat isn't able to remove quickly enough.
If you're using constraints, the bonds to hydrogen are being reset to their constrained bond lengths in the first step, likely leading to further injection of energy into the system.
If we want users to be able to simulate from our initial structures right away, we will need to pre-minimize them in smirnoff99Frosst and write out those files for use.

This... explains why I've never had problems iwth that box, since I always minimize first. We COULD deposit a minimized box for starting these I suppose.
I'd change the title to something about "test boxes could be minimized before deposition" and mark it as a low priority fix.

I can reproduce the above (crashes w/o minimization, starts well enough w/). I agree saving energy minimized structures (with smirnoff99Frosst, parsely, whatever) would be worthwhile.

Sounds good. Glad to hear it wasn't a technical issue. Let's save minimized
structures with Parsley (openff-1.1.0).
On Tue, Mar 31, 2020 at 7:21 PM Matt Thompson<EMAIL_ADDRESS>wrote:

I can reproduce the above (crashes w/o minimization, starts well enough
w/). I agree saving energy minimized structures (with smirnoff99Frosst,
parsely, whatever) would be worthwhile.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openforcefield/openforcefield/issues/324#issuecomment-606823220,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD4STV2HZXERIA25KZXKWQLRKI7CJANCNFSM4HNRU7RQ
.


Trivy misconfig : Cluster Admin0 Role Only Used Where Required

Issue: https://avd.aquasec.com/misconfig/kubernetes/general/avd-ksv-0111/
Cluster Admin0 Role Only Used Where Required
User with admin access
Either cluster-admin or those granted powerful permissions.
Links  - https://kubernetes.io/docs/concepts/security/rbac-good-practices/

The helm template will invoke a job which creates the pod which in turn calls mas cli functions to install MAS.
This mas cli install command will install operators in different namespace and expect cluster-admin role.
Without this cluster-admin role, the mas cli install command will not execute


[Model] Heterogeneous graph support for GNNExplainer

Description
Add Heterogeneous Graph support for GNNExplainer
Checklist
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage
[x] Code is well-documented
[x] To the best of my knowledge, examples are either not affected by this change,
or have been fixed to be compatible with this change
[ ] Related issue is referred in this PR
[x] If the PR is for a new model/paper, I've updated the example index here.

Changes
Added a new class HeteroGNNExplainer for Heterogeneous graph explanation.
The output of the model has been manually verified on MUTAG dataset. Unfortunately there's no ground truth for the explanation, so we cannot quantify the model's performance. Instead, we manually investigated the results and confirms that it aligns well with human intuition.
Link to the MUTAG Hetero GNNExplainer notebook
The code has also been verified on several datasets DGL officially provides, see this repo for details.
Inline documentation is added following the original style, and an example of using the module is included in the documentation.

How about adding comments into https://github.com/ahadjawaid/Syssec/blob/main/data_converter/MUTAGHetro_Graph_Explainer.ipynb so that it could be used as both an example and a kickstart guide.
https://github.com/ahadjawaid/Syssec/tree/main/Explainer_Notebooks. Let's have readme.md file to explain the notebooks .

How about adding comments into https://github.com/ahadjawaid/Syssec/blob/main/data_converter/MUTAGHetro_Graph_Explainer.ipynb so that it could be used as both an example and a kickstart guide.
https://github.com/ahadjawaid/Syssec/tree/main/Explainer_Notebooks. Let's have readme.md file to explain the notebooks .

Agreed.


SQL Database - Fix typo in Long-Term Backups article

SQL Database - Fix typo in Long-Term Backups article

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@tomkerkhove : Thanks for your contribution to the Azure documentation! The author, @anosov1960, has been notified to review your proposed change.

@anosov1960 what is the status of this review?

@tomkerkhove, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

@jomolnar Do you know what the status is here?

@tomkerkhove The status is that the pull request is awaiting review by the author. @anosov1960 please review these proposed contributions and sign off if it looks okay. Thanks.

#sign-off

Merged latest in and is no longer required - Sorry for this.


Bug/vector loading

Codecov Report
Patch coverage: 71.83% and project coverage change: -0.45% :warning:

Comparison is base (e27ade0) 80.26% compared to head (b75f2e7) 79.82%.

:exclamation: Current head b75f2e7 differs from pull request most recent head 9c4cd10. Consider uploading reports for the commit 9c4cd10 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #657      +/-   ##
==========================================
- Coverage   80.26%   79.82%   -0.45%
==========================================
  Files          77       78       +1
  Lines        4885     4937      +52
==========================================
+ Hits         3921     3941      +20
- Misses        964      996      +32

Files Changed
Coverage Δ

superduperdb/container/listener.py
80.35% <ø> (ø)

superduperdb/db/base/db.py
64.37% <28.57%> (-0.63%)
:arrow_down:

superduperdb/db/mongodb/data_backend.py
61.76% <50.00%> (-6.10%)
:arrow_down:

superduperdb/db/mongodb/metadata.py
75.00% <57.14%> (-4.52%)
:arrow_down:

superduperdb/db/mongodb/artifacts.py
84.21% <62.50%> (-15.79%)
:arrow_down:

superduperdb/db/base/artifact.py
84.61% <66.66%> (-2.35%)
:arrow_down:

superduperdb/db/base/data_backend.py
81.48% <66.66%> (-1.86%)
:arrow_down:

superduperdb/db/base/metadata.py
54.90% <66.66%> (+0.35%)
:arrow_up:

superduperdb/base/config.py
100.00% <100.00%> (ø)

superduperdb/container/vector_index.py
84.03% <100.00%> (-0.45%)
:arrow_down:

... and 3 more

... and 3 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


TypeError: '>' not supported between instances of 'str' and 'int'

Reproduction
./tools/dist_train.sh configs/obb/fcos_obb/fcos_obb_r50_caffe_fpn_gn-head_4x4_1x_dota10.py 2
Environment
the environment uesd to be ok.
Error traceback
If applicable, paste the error trackback here.
Traceback (most recent call last):
  File "./tools/train.py", line 153, in <module>
    main()
  File "./tools/train.py", line 149, in main
    meta=meta)
  File "/home/deep/colors/OBBDetection-master/mmdet/apis/train.py", line 133, in train_detector
    runner.run(data_loaders, cfg.workflow, cfg.total_epochs)
  File "/home/deep/Libraries/anaconda3/envs/obbdetection/lib/python3.7/site-packages/mmcv/runner/epoch_based_runner.py", line 127, in run
    epoch_runner(data_loaders[i], **kwargs)
  File "/home/deep/Libraries/anaconda3/envs/obbdetection/lib/python3.7/site-packages/mmcv/runner/epoch_based_runner.py", line 54, in train
    self.call_hook('after_train_epoch')
  File "/home/deep/Libraries/anaconda3/envs/obbdetection/lib/python3.7/site-packages/mmcv/runner/base_runner.py", line 309, in call_hook
    getattr(hook, fn_name)(self)
  File "/home/deep/colors/OBBDetection-master/mmdet/core/evaluation/eval_hooks.py", line 64, in after_train_epoch
    if not self.every_n_epochs(runner, self.interval):
  File "/home/deep/Libraries/anaconda3/envs/obbdetection/lib/python3.7/site-packages/mmcv/runner/hooks/hook.py", line 56, in every_n_epochs
    return (runner.epoch + 1) % n == 0 if n > 0 else False
TypeError: '>' not supported between instances of 'str' and 'int'
Traceback (most recent call last):
  File "./tools/train.py", line 153, in <module>
    main()
  File "./tools/train.py", line 149, in main
    meta=meta)
  File "/home/deep/colors/OBBDetection-master/mmdet/apis/train.py", line 133, in train_detector
    runner.run(data_loaders, cfg.workflow, cfg.total_epochs)
  File "/home/deep/Libraries/anaconda3/envs/obbdetection/lib/python3.7/site-packages/mmcv/runner/epoch_based_runner.py", line 127, in run
    epoch_runner(data_loaders[i], **kwargs)
  File "/home/deep/Libraries/anaconda3/envs/obbdetection/lib/python3.7/site-packages/mmcv/runner/epoch_based_runner.py", line 54, in train
    self.call_hook('after_train_epoch')
  File "/home/deep/Libraries/anaconda3/envs/obbdetection/lib/python3.7/site-packages/mmcv/runner/base_runner.py", line 309, in call_hook
    getattr(hook, fn_name)(self)
  File "/home/deep/colors/OBBDetection-master/mmdet/core/evaluation/eval_hooks.py", line 64, in after_train_epoch
    if not self.every_n_epochs(runner, self.interval):
  File "/home/deep/Libraries/anaconda3/envs/obbdetection/lib/python3.7/site-packages/mmcv/runner/hooks/hook.py", line 56, in every_n_epochs
    return (runner.epoch + 1) % n == 0 if n > 0 else False
TypeError: '>' not supported between instances of 'str' and 'int'

Could you provide the config by running tools/print_config.py


Fix bug with handling paranthesis in 0302 rule

Fixes #558

Codecov Report

Merging #596 (902a39b) into master (4098b18) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #596      +/-   ##
==========================================
- Coverage   97.34%   97.15%   -0.19%
==========================================
  Files          23       23
  Lines        2637     2637
==========================================
- Hits         2567     2562       -5
- Misses         70       75       +5

Impacted Files
Coverage Δ

robocop/checkers/naming.py
99.05% <100.00%> (ø)

robocop/checkers/misc.py
96.96% <0.00%> (-2.17%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4098b18...902a39b. Read the comment docs.


Opps

My bad guys, I mean to merge into our fork of this, github automatically did this. Sorry for the email.


Support for extensions of colmena / provisioning ?

Hello,
One of the features of nixops is the ability of provisioning nixos environment on e.g. google cloud, amazon aws, libvirt… In nixops 1.*, the code was deemed too monolithic, so to encourage users to contribute new provisioning environments, nixops 2.* adopts a more modular architecture with plugins.
I was wondering two things:

Do you plan to implement provisioning directly in colmena ?
Do you think it would be possible to have some kind of plugin interface for colmena, allowing to develop code for provisioning machines as plugins ? Having such a plugin system would allow to keep colmena effectively stateless, putting the (probably needed) state in the hands of plugins.

Thanks,
Rémy

Can't speak for the future for Colmena, but as an alternative you could consider managing your infra using Terraform, and then using its state data in your Colmena deployments. I've blogged about this. The article uses Morph rather than Colmena for demonstration, but there should be no big differences.

Thanks, i'll have a look :)

To install onto bare-metal hosts from Colmena, I've been using this script in the past weeks. It requires you to have already finished partitioning, mounted everything onto /mnt, and retrieved the hardware-configration.nix from the remote host (it only replaces the final nixos-install command). The workflow is as follows:

Partition the disk, mount everything onto /mnt (or your favorite mountpoint)

May be automated using systemd-repart or similar

nixos-generate-config --root /mnt, copy the hardware-configuration.nix back
Set up the node in your Colmena configuration
Run ./install.sh nodeName /mnt

It will build the profile locally, nix copy it to the remote chroot store at /mnt, then activate it with NIXOS_INSTALL_BOOTLOADER=1 like what nixos-install does

Just like nixos-install, it's idempotent and can be re-run. It makes use of colmena eval to evaluate and build the system profile outside of the normal deployment flow.


Preview evaluating large integers incorrectly

Hello,
When using this addon as part of VScode, it appears that large mathematical calculations appear to be incorrect.
For example, I used this code:
def even_bigger(x):
return (2 * x) ** x
even_bigger(12)
In preview mode, the answer is:

x
12

Returnvalue
36520347436056580

Running this through the IDLE and Wolfram Alpha produces the correct answer:
36520347436056576
Is there a rounding error? I am using Python 3.7.2 on Win10 via VSCode 1.30.2 with ver 0.0.4 of this great addon.

I'd guess this is the same error as https://github.com/Almenon/AREPL-vscode/issues/219
Basically javascript doesn't handle big numbers very well and we need to wait for vscode to upgrade their node version for big number support


Rtc timer mode & standby operation of timers

Introduces a driver for running the RTC in timer compare mode. Also enables even lower power operation of both the RTC and the normal timer module. This tweaks the public API of set_gclk_divider_and_source. Tested both examples on feather_m0 and they worked as expected in standby.

This contains a lot of formatting only changes. These are probably already handled by your PR #294. This makes it harder to spot the actual changes,

Yeah my editor automatically reformatted files in which I needed to change the clock API call I modified, and agreed it'll probably conflict with the other PR. I'll back out and reapply those changes to clean this PR up

cleaned up

Rather than changing the public API of set_gclk_divider_and_source, could you add another method to modify the standby mode? Also, please rebase instead of merging master into your branch.

@sajattack I'll give that a shot. It would be nice if I could avoid modifying the public API if possible.

@sajattack done & working on feather_m0

@sajattack let me know if you have anymore thoughts on this one

Lgtm


Add missing semicolon when emitting return statement.

Fixes #6824.

Hi @T18970237136, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Hey @T18970237136 thanks for the PR! You'll need to run jake runtests and then jake baseline-accept to accept changes to the generated tests.

@DanielRosenwasser Thanks! I have now run these commands to fix the test files.

:+1: