Add licence, adjust project layout & create Unity package

Hello!
I've had some variation of a serialized dictionary in basically every project I've done, so seeing yours with a nice feature set looks like it will definitely save time in the future.
I try to stick with using packages through Unity as often as possible, since they handle versioning much better and can pull directly from git! That's why I wanted to offer these changes so that you or others could use this in the same way.
My proposed changes here are a few, and I made a few assumptions:

I've added a README.md. In it, I've just duplicated the documentation you wrote in the PDF. I had to break the images out so they could be put inline in the markdown.
I moved the Sample folder to Samples~/Usage. Unity's package recommendations include placing samples in the Samples~ folder, so they don't get tracked & imported with the rest of the package by default. There's also a mechanism that allows the samples to be imported automatically by the user, via the package manager interface, like so.
Lastly, I created the package.json. This is the file that the Unity Package Manager uses to populate information about the package in the interface.

Part of the unity package data is the license the package is released under. Your repository didn't have a license at all, so I added the MIT license, since I noticed you preferred it for other repositories. If you'd rather use something different, feel free to amend that commit or let me know what you'd like and I can do it!
Cheers, and thanks for sharing!

Amazing work, thanks. I thought about converting this into a package, but didn't get around to it.


Introduce widget setters for reset operation

The resetWidget() method is fragile and non-intuitive as the name of the widget may change. A setter would be a more intuitive way of implementing the reset functionality. eg: widgetName.reset()

Closing as not a priority


Presign URL is being hit over CDN

I'm getting a CORs error while uploading after I added a CDN.
XMLHttpRequest cannot load http://redacted.cloudfront.net/attachments/cache/presign?t=1437108378113.0. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:3000' is therefore not allowed access.

Refile is sending a GET request to presign the upload straight to the CDN. Is this normal? The CloudFront response is a 307 temporary redirect to my bucket. I'm a bit stumped because everything works wonderfully well until I set the host to my CDN distro.

I created a bucket with  cache and store folders.

I added a CORS config

*
GET
POST
3000
Authorization
Content-Type
Origin

    ````
3. I created an AWS user and added a bucket policy for this user:
````json

{
"Version": "2012-10-17",
"Id": "",
"Statement": [
{
"Sid": "",
"Effect": "Allow",
"Principal": {
"AWS": "arn:aws:iam::id:user/username"
},
"Action": "s3:",
"Resource": [
"arn:aws:s3:::bucket",
"arn:aws:s3:::bucket/"
]
}
]
}
4. I've configured the refile initializer.    ruby
require "refile/s3"
aws = {
access_key_id: Rails.application.secrets.AWS_KEY_ID,
secret_access_key: Rails.application.secrets.AWS_SECRET_ACCESS_KEY,
region: Rails.application.secrets.AWS_REGION,
bucket: Rails.application.secrets.AWS_BUCKET,
}
Refile.cache = Refile::S3.new(prefix: "cache", **aws)
Refile.store = Refile::S3.new(prefix: "store", **aws)
````
At this point everything is working well. I created a CloudFront distribution for my bucket with essentially the defaults. Once I added the distribution to refile, I started getting the error.
Refile.host = Rails.application.secrets.CLOUDFRONT_DISTRUBUTION

I have a feeling I'm not setting up my CDN correctly, but I am not tampering with the defaults. Any ideas?

I've managed to get one step further by editing the CloudFront CDN to forward headers onto origin. But now I'm getting a 403 forbidden. I've amended the bucket policy to ensure CloudFront has access to the bucket.
		{
			"Sid": "2",
			"Effect": "Allow",
			"Principal": {
				"AWS": "arn:aws:iam::cloudfront:user/CloudFront Origin Access Identity [redacted]"
			},
			"Action": "s3:*",
			"Resource": "arn:aws:s3:::nimbusws-dev/*"
		}

If anyone has anyone successfully setup Refile with CloudFront, would you be kind enough to share your CDN config, or some details on the process?

Sorry, I don't mean to spam, but I amended the policy again, and this time, when trying to upload files I'm getting a GET http://[dist].cloudfront.net/attachments/cache/presign 404 (Not Found) error. I'm not sure why. I'm also not sure where attachments is coming from in the URL. If I do Refile.host in the terminal I get "http://[dist].cloudfront.net/, which is how I set it up.
I came across issue #217 but it's not proving helpful.

I'm pretty sure this is a bug. The presign URL is not supposed to be hit over the CDN. I've checked the code and it looks wrongs to me, so this is probably just simply broken. At the same time it feels a bit wrong to simply ignore Refile.host in this case. What if someone has mounted the app somewhere else, and the current app doesn't even have the Refile app mounted? That would break totally, with no way of fixing it.
I'm not sure how to best go about fixing this. Let me think it over a bit.

@jnicklas Weirdly enough, despite the 404, the images still upload. When trying to request the files I get this URL that produces a 404 (I've cut off some of the characters to shorted it):
//[dist].cloudfront.net/attachments/ec9f427de977492..../store/fill/100/100/74f17f4947c27bdb.../profile_image

Where profile_image is the name of the attachment field. I imaged this would be:
//[dist].cloudfront.net/store/fill/100/100/74f17f4947c27bdb.../profile_image

This maybe a similar issue to #217. Also, PR #292 may or maybe be related here.
Is there a quick/dirty way to get working? I'm also a bit worried about existing uploads, and if transitioning to a CDN now will impact those.

I'm not sure this is an issue. I'm also seeing the Presign-URL being hit via Cloudfront, but the request is passed through to the app and no cached response returned.
GET request to https://d1eavxxee7beiy.cloudfront.net/attachments/cache/presign
Response headers:
Cache-Control:max-age=0, private, must-revalidate
X-Cache:Miss from cloudfront

Object caching in the Cloudfront distribution is set to Use Origin Cache Headers, so the app decides on which headers to add, and Cloudfront respects theses headers and passes them on.
@abitdodgy Any chance your distributon is configured to customize the response headers (see 'Default Cache Behavior Settings' > 'Object caching')?

I doubt it but I will take a look as soon as I get to the office. But why
not got directly to S3 when presigning? What does going through the CDN
achieve? In my case, the URLs are being malformed despite the upload going
through, which is a similar issue to the one I referenced here from some
months ago. It seems that there is something off with the CDN given several
people are reporting issues.
On Tuesday, July 21, 2015, Thomas Klemm<EMAIL_ADDRESS>wrote:

I'm not sure this is an issue. I'm also seeing the Presign-URL being hit
via Cloudfront, but the request is passed through to the app and no cached
response returned.
GET request to https://d1eavxxee7beiy.cloudfront.net/attachments/cache/presign
Response headers:
Cache-Control:max-age=0, private, must-revalidate
X-Cache:Miss from cloudfront
Object caching in the Cloudfront distribution is set to Use Origin Cache
Headers, so the app decides on which headers to add, and Cloudfront
respects theses headers and passes them on.
@abitdodgy https://github.com/abitdodgy Any chance your distributon is
configured to customize the response headers (see 'Default Cache Behavior
Settings' > 'Object caching')?
—
Reply to this email directly or view it on GitHub
https://github.com/refile/refile/issues/301#issuecomment-123302202.

I'm also getting some issues with the presign URL passing on the CDN for multiple file uploads.
If I upload 5 files, the first one is a miss from CloudFront, but the other 4 are all Hit from CloudFront. In some cases it returns exactly the same file id and in other cases it doesn't.
This means the multiple file upload fails randomly when the CDN Host is active on Refile.
If I point the data-url to the Refile Endpoint, it just works.

@thomasklemm and @ivobenedito can you please show me an example of what the CDN URLs look like in your app?
@thomasklemm I can confirm that Object Caching is set to Use Origin Cache Headers. I've solved this issue thanks to @ivobenedito by passing in host: request.base_url to attachment_field and now presign requests go straight to S3. But after the upload is done I'm getting 404 on all files. @ivobenedito I still can't figure out for the life of my what I'm doing wrong. My urls look like this:
http://[dist].cloudfront.net/attachments/:id/store/fill/100/100/:key/profile_image
Where :id is the refile id and :key is the file key. Going to http://[dist].cloudfront.net/store/key works. But I don't know how that URL makes sense.

@abitdodgy You're saying that you're uploading with success but after when the files are moved from cache to store you get 404? Is S3 bucket well configured as an origin of the CDN? How about turning off CDN and serving directly with S3? Does it work? You can test it locally on localhost.

@ivobenedito yes! I believe my bucket is configured correctly. I created a test application since it's easier to see than explain. It shows the behaviour I'm talking about.
Example app

App address: refile-test.herokuapp.com
CDN is CloudFront, everything left at its defaults.
S3 bucket: refile-example accessible to world, CORs setup correctly.
Repo for example app: https://github.com/Aerogami/refile-test

The bucket has all the right CORs config (taken from here) and a policy that allows it to be read from public.
We have an Upload model that has_many :documents. Everything works fine. Except for when using the CDN to retrieve the files. In the document partial I have two rows for each document. One resets the host, to show that the file really is there, and the first one is the default, or using the CDN, which shows a 404.

Sorry, I don't mean to be a pest, but before I bash my head against the wall again, I'd like to know if this is a bug, or if I'm doing something wrong. I've setup a test app that shows that uploaded files are not being served from the CDN. I'm curious if anyone is able to use a CDN with Heroku successfully, and how they've achieved that.
@jnicklas should we split this into two issues? Two things are going on here:

Presign requests are going through the CDN.
Assets are not being served from the CDN.

What do you think?

I have a similar issue, my correct s3 url  via Cloudfront is
"//my-dist-url/store/7868768768687689768768976876876876868768768768998"
but using the attachment_image_tag in my view it is rendering as
 "//my-dist-url/attachments/store/7867687687687687687687687687687687687686/image.jpg"
which does not show the image.
I can upload to s3 without any issue, yet the "attachments" and "image.jpg" are throwing me a curve.

The CDN is supposed to be in front of your app, not in front of S3.

@jnicklas Do you mean that the CDN Origin Domain Name should be pointing back to the app instead of the S3 bucket?

Yes. Exactly.

So the Origin Domain Name would be www.my_app.com?
What would the Origin Path be, or should it just be left blank?

@goodviber yes, it should be your apps URL. As for the Origin Path, leave it blank. I just tested this and it works.

@abitdodgy is your repo above now fully functional and also what set up do you have for Cloudfront?
re: Alternate Domain names (cnames)
Origin Domain Name and anything else that varies from standard setup.
I have tried everything with no luck. I can get the images to to display only by stripping the url string of "attachments"  and "image.jpeg".  I only made sure that Origin Domain Name was pointing to refile-example.herokuapp.com. That's all I did, and it worked. The CDN setup is the default one. Origin Domain Name is the only thing I changed. It was pointing to my S3 bucket, which prevented it from working. The rest are defaults.

Thanks @abitdodgy , I finally got the whole thing working...

So I finally got around to tackling this issue properly. We now have two separate host settings, Refile.app_host which affects all URLs generated by Refile, and Refile.cdn_host, which only affects file_url and attachment_url.
Needless to say, if you have a CDN set up, you should only set Refile.cdn_host.
The regular Refile.host is now deprecated, to prevent confusion.

Awesome @jnicklas :)! Great addition. Thx!!

I changed the Origin Name to my app domain name, and set the refile host setting in the initializer file to to the Cloudfront distribution name, and it worked!!
But I wasn't able anymore to upload image to S3 storage : (
Does anyone have an idea how to fix this?
Im using Refile version 0.5.4
thanks for your help,
Anthony

@acandael Upgrade to Refile latest version 0.6.2 and replace Refile.host by Refile.cdn_host.

thanks, I upgraded Refile to 0.6.2, everything is working. The only thing that's broken is the preview image in my upload form. Don't know what's causing this.
greetings,
Anthony

Preview image? Probably that's not related to Refile :)

@ivobenedito with 'preview image' I mean the image that's get shown in the form, before it get's uploaded.
The form code looks like this:
<% if @member.image_id? %>
  <%= image_tag attachment_url(@member, :image, :fill, 150, 150) %>
  <div class="check_box">
    <%= f.check_box :remove_image %>
    <%= f.label :remove_image %>
  </div>
<% end %>

<%= f.attachment_field :image, direct: true, data: { remote_id: :member_image_cache_id } %>

The Coffeescript that handles the preview looks like this:
$ ->

"use strict"
if !document.addEventListener
return
document.addEventListener "change", (changeEvent)->
input = changeEvent.target
if input.tagName == "INPUT" && input.type == "file" && input.getAttribute("data-direct")
if !input.files
return
  file = input.files[0]
  metadataField = input.previousSibling

  dispatchEvent = (name, detail)->
    ev = document.createEvent('CustomEvent')
    ev.initCustomEvent(name, true, false, detail)
    input.dispatchEvent(ev)

  if file
    url = input.getAttribute("data-url")
    fields = JSON.parse(input.getAttribute("data-fields") || "null")

    data = new FormData()

    if fields
      Object.keys(fields).forEach (key)->
        data.append(key, fields[key])

    data.append(input.getAttribute("data-as"), file)

    xhr = new XMLHttpRequest()
    xhr.addEventListener "load", ()->
      input.classList.remove("uploading")
      dispatchEvent("upload:complete", xhr.responseText)
      if ((xhr.status >= 200 && xhr.status < 300) || xhr.status == 304)
        id = input.getAttribute("data-id") || JSON.parse(xhr.responseText).id
        if metadataField
          metadataField.value = JSON.stringify({ id: id, filename: file.name, content_type: file.type, size: file.size })
          input_id = input.getAttribute("data-remote-id")
          metadataField.setAttribute("id", input_id)
        input.removeAttribute("name")
        dispatchEvent("upload:success", xhr.responseText)
      else
        dispatchEvent("upload:failure", xhr.responseText)

    xhr.upload.addEventListener "progress", (progressEvent) ->
      if progressEvent.lengthComputable
        dispatchEvent("upload:progress", progressEvent)

    xhr.open("POST", url, true)
    xhr.send(data)

    input.classList.add("uploading")
    dispatchEvent("upload:start", xhr)


RTL does not support

hi, i this theme is great.
i tried to write some persian words, which shown in incorrect layout. there is any config to fix it for me?
in other hugo blog theme we just put out text between   to make the page and words RTL, but here i tried it and it
still doesnt work.

hey, could it be text-align css property which makes it to stick left? :thinking: Could you attach a screenshot of how it is supposed to look like? :)

thank for your attention, i edit the style in chrome dev tools, it should be like this:


Performance considerations?

Are there any performance issues we have to consider when enabling this?
Also, is it possible to do a memory dump of a Linux web app?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 20504526-20b8-40c2-e7bc-85a9ef46de83
Version Independent ID: 684b7dcb-7346-7126-79c0-896802e55ab5
Content: Profile ASP.NET Core Azure Linux web apps with Application Insights Profiler - Azure Monitor
Content Source: articles/azure-monitor/app/profiler-aspnetcore-linux.md
Service: azure-monitor
Sub-service: application-insights
GitHub Login: @cweining
Microsoft Alias: cweining

@ADringer ,  Thanks for brining this to our attention. We will investigate it further and update you shortly.

@ADringer - The data we are gathering from the .net core app is generated natively by .net core in a very performant way. It does affect your app a little, but not much. The .net core team is dedicated to making sure it is as light weight as possible. All processing and uploading of the profiler data takes place out of proc from your application and on low priority threads.
As for taking a memory dump of a Linux app, I'm not sure. I'm looking into that and will get back to you when I find out.

@cweining - Thank you for providing your insights.
@ADringer - I hope @cweining answered your question. He will also provide more info on the memory dump of a Linux app.
At this moment, since there are no doc updates, We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

@ADringer - I've asked around and I haven't found of a way to do a memory dump of a .net core process running in Azure App Service. If might be possible to do a GC heap-dump, if you can get the dotnet-gcdump tool on the machine by ssh’ing into it.


Adding the backend Code

Title
Adding the Backend code in a Specific Folder, the usefullness of it will include the following Components

MongoDB
MongoDB will be the optimal noSQL database for this blogging website, this would provide inter relations between Authors and Blogs generated by them
Express Backend
Express Routes related to User and Blog will include the authentication and Verification of this Webapp

Can you assign this to me under gssoc?

I would like to work on this Isssue .Could you please assign this to me

i would like to work under this under GSSOC'24 @bishalde

Please assign this to me @bishalde


Bounty2

Still in progress I need to figure out how to test and validate any of this works opening as draft for now
closes https://github.com/lnflash/flash/issues/7
This commit just fixed yarn run build errors I was seeing f32ee9e46c991bba57fad2cf26091ee17b62a63b
and this commit is for adding logic to createAccountForDeviceAccount using the Ibex createAccount response d64aa9d9f3406db94aeb30518e7444f4799289ac

clsoing in favor of https://github.com/lnflash/flash/pull/9


Moor arguments and code Improvements

I added moor arguments and improved some parts of the code, see Commits.
The biggest change is probably the disabling of dithering, it improves the image quality!

Cool improvements, thanks! 👍

I went ahead and documented the new features in the README. I also undid some of your re-formatting because personally I think this way looks nicer. Thanks again.

@DownrightNifty FYI, it looks like the --remove argument is not yet documented in the readme


Improved colormaps support

Tackles some (all?) points in #104.

[x] Proper support for colormaps that are gray, gray+alpha, rgb, rgba.
[x] Per-vertex colors can be gray, gray+alpha, rgb, rgba.
For Image:

[x] proper support for gray, gray+alpha, rgb, rgba.
[x] Colormaps.

For Volume and VolumeSlice:

[x] proper support for gray, gray+alpha, rgb, rgba.
[x] Colormaps

For Mesh:

[x] Refactor colormaps.
[x] Remove clim property.
[x] Per-vertex colors.

For MeshSlice:

[x] Added note about not implementing colormapping or per-vertex colors for now.

For Line (and ThinLine):

[x] Colormaps.
[x] Per-vertex colors (was already implemented).

For points:

[x] Colormaps.
[x] Per-vertex colors (was already implemented).

Do I forget objects, maybe background?
[ ] A few standard colormaps.
[ ] A complete lib of builtin colormaps.
[x] Docs.
[x] Self review / check todos.
[x] Rebase and update validation example to be tested on CI.

I'm building this list up for completeness, not everything will go in this PR.

Let's add two-or-so colormaps in a next PR.

Pretty awesome, I take it you've constructed examples to test all the different cases and confirmed they work? If so, LGTM!

Yes there's colormap_image.py and colormap_mesh.py. The latter can easily be tweaked to render points and lines instead. I added screenshots to the top of this PR. I also added one validation example. I should probably add one or two more. Will also do that in a new pr.


Trying to add devices to provision is not working apple aborts and timings out

I get following different errors
timing out ,
too many open connections

So after 1 week of timeout and too many connections it is finally working again.


No longer use django_on_heroku

This pull request implements #10
It adds the following to be installed via pip: whitenoise, dj-database-url, and psycopg2-binary which are all dependencies that django_on_heroku used.

whitenoise is used for staticfiles on production
dj-database-url is a utility library to easily convert the DATABASE_URL into a django supported database dictionary format.
psycopg2-binary is a PostgresSQL database adapter to support Heroku's PostgresSQL databases

It adds the additional step to modify ALLOWED_HOSTS, add STATIC_ROOT, STATIC_URL, and to install the whitenoise middleware yourself.
It adds another step to manually modify the DATABASES definition to support both local and heroku environments.
Using these steps, I also was able to successfully deploy my lab again without django_on_heroku.

Thanks!


Seems the mod no longer works?

It doesn't have any functionality after the update

This is probably because the directories for storing images need to be reset.

I'm using a docker container for foundry and I had to make sure that I configured tokenizer with a directory with the correct permissions. There were no error messages even in the console. In case this helps anyone else, I'd follow @MrPrimate 's advice and double-check your directory.


readme typo

in readme.md
$ opm get thibaultcha/lua-resty-mlcache
shouldnt it be something else ?

@yw662
Oops... So embarrassed, that part was copied from thibaultcha's lua-resty-mlcache.
I will fix this typo :). Thanks for your report.

I have fixed this embarrassing typo in this commit: https://github.com/tokers/lua-resty-requests/commit/61ef0dec7672b825650f29f6057c3c16531fd532.
Now I'm going to close this issue. Thanks again!


Don't hoist InlineeStart in peeps

InlineeStart is hoisted in peeps for branching (the same instruction in branch follower and target is hoisted before branch). The owner function of InlineeStart is not checked for instruction equivalence (actually cannot hoist even for the same function, because the inline ranges in inliner function are different). Hoist InlineeStart causes encoder not generating InlineeFrameRecord for some inlinee which will corrupt baiout and stack walk in such inlinee.

@LouisLaf @rajatd please help review.

:shipit:


Improve publishing plugin documentation

There are a lot of questions around publishing best practices, which we should address in the user guide or samples. Here are some examples from our issue tracker and forum:

[X] ~How do I publish to Maven Central (javadoc jar, source jar, required POM info)~ → #5094
[X] ~How do I put snapshots in a different repository than releases?~ → #5095
[X] ~How can I control where to publish using a command line argument or environment variable?~ → #5095
[X] ~How can i disable signing for snapshots/local builds?~ → #5096
[X] ~How do I customize the published metadata (POM/IVY file)?~ → documentation will be updated as part of #3348
[X] ~How can I publish additional artifacts, e.g. sources?~ → #5097
[X] ~Where and how should I store credentials?~ → #5112
[X] ~Is there a way to publish a dynamic set of artifacts?~ → #5293
[X] ~How do I publish only some publications?~ → #5116

~Users are overwhelmed by the number of tasks involved and disable only one of them, all others are still run though~
~Users want to put some artifacts in one repo and some into another, based on some criteria~

[X] ~Users want to create short-hand tasks for running only some of their publications.~ → #5116
[ ] How do I publish an existing POM file instead of letting Gradle generate one?
[ ] Can I publish only the modules that have changed?
[X] ~How do I publish a BOM?~ → #5292

I'm closing this epic because the most important items have been addressed. I create two follow-up issues, namely an #5292 and #5293, for two remaining items I deemed important.


Avoid allocations in NetworkedAnimator

Replicate HLAPI patch in https://bitbucket.org/Unity-Technologies/networking/pull-requests/21/cache-animator-parameters-to-avoid/diff

This doesn't work. Animator parameters is not populated before runtime. You probably have to do a check if the array is null, if so, populate it with the parameters.

Correct. Turns out you also have to remember to null the array when changing ownership. See update (and thanks for that virtual!)

Why are you resetting the array when changing ownership?

Just doing a null check wasn't sufficient when testing on HLAPI. It would get into the for loop, then get an index out of range when actually reading one of the parameters, which in some way makes sense if you've switched from serializing to deserializing or vice versa. Where I was previously initializing the parameters array I added a null check, but that left one out of range error when this happens on ownership change. So I moved it into the ResetParameterOptions and call it when a change happens. I added it to both overrides not based on testing per se. In HLAPI, they reset last sync time when auth is started, but not when it is stopped, so I observed errors when interpolation was used. I don't know that we have the same issue here, but seemed safest to just do both.

Is this relevant to the MLAPI? MLAPI has none of the connectionReady and observer issues that the HLAPI has. The reset seems unnecessary. Please try without the reset and get back to me.

I would, but don't have a test project based on MLAPI yet.

Alright, I'll give it a shot.

From my very quick testing, it's not needed. This will simply make the NetworkedAnimator nonfunctional as the parameters set to be synced are all turned off. Take it out of the PR and create another issue if neccecary.  After this merge I'll rewrite the Animator to follow the rest of the projects code standard and be a bit cleaner.

Thanks. I'll finish my test project ASAP.


Update detach-disk.md

Hi. I've found a gap in the documentation. Following should be clearly stated in the doc for clarity:
"You don't need to stop or restart a VM to detach its disk. You can remove the disk as long as nothing is actively using the disk when it is being detached."

@roygara
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Latest Samplestack documentation

Includes added documentation for various states and directives.
The new protractor.conf file showed up during my rebase, not sure why, I assume you can handle whatever needs to be done with that @laurelnaiad.

Thanks. Right. Protractor.conf showing  up is my fault. I will fix.

Turns out the particular protractor.conf there was due to having rebased but that scrap file was lying around in a place it no longer is intended to live.
I'm putting some postinstall code into the browser app to remove this detritus so the stray protractor.conf problem doesn't hit other people.

A form of this was merged already.


Hasura-auth doesn't check/capture invalid locale when using Oauth

When logging or signing up with a social network it hangs on the callback.
The request to https://www.linkedin.com/oauth/v2/authorization-submit?app_id=... goes through, however, the request to http://localhost:1337/v1/auth/signin/provider/linkedin/callback?code=...&state=... hangs.

I am closing this issue in favor of https://github.com/nhost/hasura-auth/issues/44

I am closing this issue in favor of https://github.com/nhost/hasura-auth/issues/44


[BEAM-2467] Kinesis source watermark based on approximateArrivalTimestamp

Follow this checklist to help us incorporate your contribution quickly and easily:

[X] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[X] Each commit in the pull request should have a meaningful subject line and body.
[X] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
[X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[X] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

@jkff @rangadi @rtshadow, can you please take a look?

@jkff @rangadi can you please take a look?

@jkff I've just pushed new changes, could you please review?

Thanks @jkff, I've already applied your test suggestions.
We are using our custom Kinesis source prepared for Dataflow SDKs and it autoscales reasonably with Kinesis. It uses exactly the same logic as proposed in https://github.com/apache/beam/pull/3551. So I can confirm that this approach should be fine here.

Coverage increased (+0.009%) to 69.525% when pulling 30fcbef38cd1b787eff02915006b4540eb151ec0 on ocadotechnology:kinesis_watermark into fa4ecea26713244a83521ce1ca2864f4ad4409c8 on apache:master.


Fixing window refreshes

Fix window refreshes

Remove window refreshes
Replace with "Use effect" feature

Placed this issue under another one


Merge branch 'maint-0.7'

addresses reanahub/reana#480

Codecov Report

Merging #35 (5704409) into master (b06b53b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #35   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines            7         7
=========================================
  Hits             7         7


HEAD requests enabled with wisp.handle_head do not set Content-Length

Hello,
First of all thanks so much for Gleam and the awesome ecosystem of packages, toolings, documentation, etc. everything is top-notch and it's been nothing but fun diving into this language for me the past few weeks.
I started building a small web server to learn the ropes a bit, and I noticed that wisp.handle_head removes the Content-Length header from the response, which is unfortunate as it's probably the most useful information that one can get out of a HEAD request (outside of the status code I guess). Documentation on MDN does use this use-case as first example: https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/HEAD. My guess is that it's because a set_body(Empty) is used, and somewhere down the response pipeline that sets the Content-Length header?
I tested this with curl -i --head http://localhost:8080/page. I'm running wisp 1.3.0.
Thanks,
Martin

Wisp never sets a content length, it is set by the web server. I presume we'd need to replicate the web servers' content length calculation before we remove the body.
@rawhat Looking at Mist it doesn't set the content length for HEAD requests at all. Was this for a particular reason? I couldn't immediately see how content-length was calculate for send-file, though that is another matter.
Does Mist send a response body if one is provided for HEAD requests?

Honestly, I don't remember why it's stripping content length for HEAD requests.  I think that was just a mistake.  I'll update that.  It also doesn't strip the response body, which is also incorrect.
Hopefully should have some time to update this in the near future.

Ah ok, that sounds like it would make things a lot easier from Wisp's point of view. We could return the body for HEAD and Mist would calculate the content length and then discard the body. Does that sound right?

Yep that sounds good to me!

Amazing! Thank you

This should hopefully be fixed in mist now 🤞🏻

Thank you!


saving in a cookie that i dont want a cookie

I dont know if its a problem to save in a cookie that someone doesn't want a cookie.
Maybe you should give a third button "doNothingContent" and a "clicked-nothing" event that just minifies the message and doesnt do anything?
I'm not sure if that is necessary?
 This component does actually use localStorage - but to support older browsers, it does fallback to actual cookies using tiny-cookie when localStorage is not supported.
I know it's a bit confusing considering the naming of the component, but the user privacy opt-in concept is the same - the user may want you to store information about them using a "method" (cookie or localStorage) or they may not want you to store this information. Hopefully this is a proper answer, thank you!


Change condition to only match non-ServiceAccount

This stops propagation of rolebindings
https://github.com/dana-team/hns/blob/c53ab39aa0dc16c205753baecd66e74d3794b738/internals/controllers/rolebinding/rolebinding_init.go#L37
/kind bug

/assign @mzeevi


Refactor bsc#1155810

Why is this PR needed?
Address the comments of this PR

https://github.com/SUSE/skuba/pull/832#discussion_r349021524
https://github.com/SUSE/skuba/pull/832#discussion_r349022187
https://github.com/SUSE/skuba/pull/832#discussion_r349022406
https://github.com/SUSE/skuba/pull/832#discussion_r349025508

What does this PR do?

Moves create root CA certificate and key to kubernetes package.
Splits state into two: upload ca cert, generate server cert/key and upload.

Anything else a reviewer needs to know?
N/A
Info for QA
Please double verify on all the platforms: OpenStack, VMWare, Bare Metal.
Related info
#832
Status BEFORE applying the patch
N/A
Status AFTER applying the patch
N/A
Docs
N/A
Merge restrictions
(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:
What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)

Signed-off-by: JenTing Hsiao<EMAIL_ADDRESS>

QA information :
Building skuba :

git pull on pull request 853
make ( for devel env )
I'm using devel to be able to upgrade kubelet from 1.15.2 to 1.16.2

Testing environment :

1 lb / 1 master / 1 node on vmware

Cluster setting :
skuba cluster init --control-plane <IP_LB> --strict-capability-defaults --kubernetes-version 1.15.2 cluster

I'm using the new option --kubernetes-version to be able to upgrade once the cluster is deployed
Scenario:
I want to upgrade my kubelet version and crio version ( kubelet: 1.15.2 -> 1.16.2 / crio: 1.15.0 -> 1.16.0) using the upgrade method.
Before :

[ ] Checking if the cluster need an upgrade

Command : skuba cluster upgrade plan
Result :
** This is an UNTAGGED version and NOT intended for production usage. **
Current Kubernetes cluster version: 1.15.2
Latest Kubernetes version: 1.16.2

Upgrade path to update from 1.15.2 to 1.16.2:
 - 1.15.2 -> 1.16.2

Addons for next cluster version 1.16.2 are already up to date.

There is no need to run 'skuba addon upgrade apply' after you have completed the platform upgrade.

[ ] Checking master01 need an upgrade
Command : skuba node upgrade plan master01
Result :

** This is an UNTAGGED version and NOT intended for production usage. **
Current Kubernetes cluster version: 1.15.2
Latest Kubernetes version: 1.16.2

Current Node version: 1.15.2

Component versions in master01
  - apiserver: 1.15.2 -> 1.16.2
  - controller-manager: 1.15.2 -> 1.16.2
  - scheduler: 1.15.2 -> 1.16.2
  - etcd: 3.3.11 -> 3.3.15
  - kubelet: 1.15.2 -> 1.16.2
  - cri-o: 1.15.0 -> 1.16.0

[ ]  Checking worker01 need an upgrade

Test:
Part 1 - Upgrade master01

[ ] Upgrade master01
[ ] Check master01 DON'T need an upgrade
[ ] Check current version for kubelet is 1.16.2 with skuba command
[ ] Check current version for crio is 1.16.0 with skuba command
[ ] Check current version for kubelet is 1.16.2 directly on the node
[ ] Check current version for crio is 1.16.0 directly on the node
[ ] Check skuba cluster upgrade plan command return  (*)
Command : skuba cluster upgrade plan
Result :

** This is an UNTAGGED version and NOT intended for production usage. **
Current Kubernetes cluster version: 1.16.2
Latest Kubernetes version: 1.16.2

Congratulations! You are already at the latest version available

Part 2 - Upgrade worker01

[ ] Upgrade worker01
[ ] Check worker01 DON'T need an upgrade
[ ] Check current version for kubelet is 1.16.2 with skuba command
[ ] Check current version for crio is 1.16.0 with skuba command
[ ] Check current version for kubelet is 1.16.2 directly on the node
[ ] Check current version for crio is 1.16.0 directly on the node
[ ] Check skuba cluster upgrade plan command return

Comments
The test is PASS for me. I was able to correctly upgrade my cluster.
The only things that doesn't seem correct is the step Check skuba cluster upgrade plan command return in part 1 (*)
Command : skuba cluster upgrade plan
Result :
** This is an UNTAGGED version and NOT intended for production usage. **
Current Kubernetes cluster version: 1.16.2
Latest Kubernetes version: 1.16.2

Congratulations! You are already at the latest version available

The worker is not upgraded yet but the cluster upgrade plan doesn't show me that. It can be confusing during an upgrade.

Thanks for your testing @maximenoel8.
The test steps test the CaaS platform upgrade but it does not contain checking the bug symptom that all the master and worker node kubelet server certificates signed by the same CA certificate.
You could follow the PR #832 test steps (Status BEFORE/AFTER applying the patch), or check all nodes kubelet server certificates are signed by the same CA certificate.
# ssh into the node
ssh sles@<ip-address>
# check certificate
echo | openssl s_client -connect localhost:10250 | openssl x509 -noout -text

Check the certificate by using the command : openssl s_client -connect localhost:10250 -CAfile kubelet-ca.crt <<< "Q"  on each node.
CN is correctly equal to kubelet-ca and I can identify myself by using kubelet-ca.crt to 10250


sqlite don't support "SET NAMES utf8" statement

try {
            $this->pdo = new PDO($dsn, $config['username'], $config['password']);
            //I add this block to avoid exception
            if( !in_array($config['driver'],['sqlite'])){
                $this->pdo->exec("SET NAMES '" . $config['charset'] . "' COLLATE '" . $config['collation'] . "'");
                $this->pdo->exec("SET CHARACTER SET '" . $config['charset'] . "'");
            }
           // ...

Thanks for the issue. I'll check it and plan to release new version that contain related fixes.


Static Walkthrough Scriptable Object

Added scriptable object script for Static Walkthroughs. Also added files for both the cat fact and static walkthrough scriptable objects.

 Static Walkthrough (Scriptable Object)


Update Circe

This PR bumps Circe to 0.3.0-SNAPSHOT as well as disabling the WarRemover pluging (I gave up - it's to much noise right now).

Current coverage is 90.84%

Merging #448 into master will decrease coverage by -3.22% as of fba5b6e

Powered by Codecov. Updated on successful CI builds.


just set <IP_ADDRESS> as localhost's IPv4 address

this was reported somewhere but I can't find the issue now, @tomerd can you remember?
Motivation:
Previously we tried to use host to determine localhost's IPv4 address.
That didn't work reliably in Docker and sometimes on macOS. Let's just
fix this to <IP_ADDRESS>.
Modifications:
Hardcode localhost's IPv4 address as <IP_ADDRESS>.
Result:
More stable test_16_tcp_client_ip

tests hit the annoying race which is hopefully addressed by #257

@swift-nio-bot please test


build: fix(?) cmake for AIX

While eyeballing the CMakeLists file to fix IBM i (#2729), it seems the AIX clause is missing the aix-common.c source file. Should probably get fixed at some point, so submitting this PR as one potential avenue. Currently in Draft because I don't have an AIX system with cmake for test.
cc @libuv/aix for input

I've added a cmake job for AIX: https://ci.nodejs.org/view/libuv/job/libuv-test-commit-aix-cmake/
This run is for current v1.x showing it fail to compile: https://ci.nodejs.org/view/libuv/job/libuv-test-commit-aix-cmake/1/nodes=aix71-ppc64/console
This run is for this PR: https://ci.nodejs.org/view/libuv/job/libuv-test-commit-aix-cmake/2/nodes=aix71-ppc64/console
I'm not currently sure about the test failures, but the compilation succeeded.

Test failures are fs_event_*:

not ok 49 - fs_event_close_in_callback
# exit code 393222
# Output from process `fs_event_close_in_callback`:
# Assertion failed in /home/iojs/build/workspace/libuv-test-commit-aix-cmake/nodes/aix71-ppc64/test/test-fs-event.c on line 940: r == 0
not ok 50 - fs_event_close_with_pending_event
# exit code 393222
# Output from process `fs_event_close_with_pending_event`:
# Assertion failed in /home/iojs/build/workspace/libuv-test-commit-aix-cmake/nodes/aix71-ppc64/test/test-fs-event.c on line 904: r == 0
ok 51 - fs_event_error_reporting
not ok 52 - fs_event_getpath
# exit code 393222
# Output from process `fs_event_getpath`:
# Assertion failed in /home/iojs/build/workspace/libuv-test-commit-aix-cmake/nodes/aix71-ppc64/test/test-fs-event.c on line 1024: r == 0
not ok 53 - fs_event_immediate_close
# exit code 393222
# Output from process `fs_event_immediate_close`:
# Assertion failed in /home/iojs/build/workspace/libuv-test-commit-aix-cmake/nodes/aix71-ppc64/test/test-fs-event.c on line 857: r == 0
not ok 54 - fs_event_no_callback_after_close
# exit code 393222
# Output from process `fs_event_no_callback_after_close`:
# Assertion failed in /home/iojs/build/workspace/libuv-test-commit-aix-cmake/nodes/aix71-ppc64/test/test-fs-event.c on line 792: r == 0
not ok 55 - fs_event_no_callback_on_close
# exit code 393222
# Output from process `fs_event_no_callback_on_close`:
# Assertion failed in /home/iojs/build/workspace/libuv-test-commit-aix-cmake/nodes/aix71-ppc64/test/test-fs-event.c on line 830: r == 0
not ok 56 - fs_event_ref
# exit code 393222
# Output from process `fs_event_ref`:
# Assertion failed: __EX, file  /home/iojs/build/workspace/libuv-test-commit-aix-cmake/nodes/aix71-ppc64/src/unix/core.c, line 179
not ok 57 - fs_event_start_and_close
# exit code 393222
# Output from process `fs_event_start_and_close`:
# Assertion failed in /home/iojs/build/workspace/libuv-test-commit-aix-cmake/nodes/aix71-ppc64/test/test-fs-event.c on line 980: r == 0
not ok 58 - fs_event_watch_dir
# exit code 393222
# Output from process `fs_event_watch_dir`:
# Assertion failed in /home/iojs/build/workspace/libuv-test-commit-aix-cmake/nodes/aix71-ppc64/test/test-fs-event.c on line 442: r == 0
ok 59 - fs_event_watch_dir_recursive # SKIP Recursive directory watching not supported on this platform.
not ok 60 - fs_event_watch_file
# exit code 393222
# Output from process `fs_event_watch_file`:
# Assertion failed in /home/iojs/build/workspace/libuv-test-commit-aix-cmake/nodes/aix71-ppc64/test/test-fs-event.c on line 597: r == 0
not ok 61 - fs_event_watch_file_current_dir
# exit code 393222
# Output from process `fs_event_watch_file_current_dir`:
# Assertion failed in /home/iojs/build/workspace/libuv-test-commit-aix-cmake/nodes/aix71-ppc64/test/test-fs-event.c on line 719: r == 0
not ok 62 - fs_event_watch_file_exact_path
# exit code 393222
# Output from process `fs_event_watch_file_exact_path`:
# Assertion failed in /home/iojs/build/workspace/libuv-test-commit-aix-cmake/nodes/aix71-ppc64/test/test-fs-event.c on line 653: r == 0
not ok 63 - fs_event_watch_file_twice
# exit code 393222
# Output from process `fs_event_watch_file_twice`:
# Assertion failed in /home/iojs/build/workspace/libuv-test-commit-aix-cmake/nodes/aix71-ppc64/test/test-fs-event.c on line 685: 0 == uv_fs_event_init(loop, watchers + 0)
not ok 64 - fs_event_watch_invalid_path
# exit code 393222
# Output from process `fs_event_watch_invalid_path`:
# Assertion failed in /home/iojs/build/workspace/libuv-test-commit-aix-cmake/nodes/aix71-ppc64/test/test-fs-event.c on line 1164: r == 0

I think it's because we're missing the HAVE_SYS_AHAFS_EVPRODS_H definition: https://github.com/libuv/libuv/blob/584ba94885619d75968a7c083914fd8b75442813/Makefile.am#L364-L372

Pushed an update to define HAVE_SYS_AHAFS_EVPRODS_H on AIX.
https://ci.nodejs.org/view/libuv/job/libuv-test-commit-aix-cmake/5/ is green (🎉).

Thanks for adding AHAFS! Undrafting since this looks landable and testing has been done

CI: https://ci.nodejs.org/job/libuv-test-commit-linux/1858/
Passed everywhere except Linux arm64 which is failing ipc_closed_handle for reasons unrelated to this PR (see https://github.com/libuv/libuv/issues/2709#issuecomment-592943913).
I'll land this in a few hours time if no one else has any issues.

Landed in https://github.com/libuv/libuv/commit/742e0ba7dfba344484bba2493a8c5ddf164a8c30.

@libuv/collaborators FYI I've added libuv-test-commit-aix-cmake to libuv-test-commit in the CI. https://github.com/libuv/libuv/commit/742e0ba7dfba344484bba2493a8c5ddf164a8c30 is needed for the new job to pass (i.e. it may fail on already opened pull requests unless they are rebased).


Also test with TOP_N=100

Many search applications do some sort of re-ranking of the initial search results ... let's test with a larger TOP_N?

Also, note that Lucene's nightly benchmarks switched to TOP_N=100 ~7 months ago now.


Implemented option entries.extra and CLI argument --extra-entries #36

Fix for issue #36
These changes introduce a new String[] option entries.extra and a new CLI argument --extra-entries (split by ;) for listening to changes of custom Webpack entries that are neither background.js nor content-script.js.
This pull request also includes fixes for the command line example in README.MD and a minor fix for sample/plugin/style.css.
I am not quite familiar with TypeScript and I may have missed something. Feel free to point out any mistakes! :)

I think the best strategy is make the plugin receive one config or a collections of configs (array).
I'll add an issue for this and start to work on it.
Anyway thanks for the PR


test

Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

[ ] I have read the CONTRIBUTING doc and adhered to the example notebook best practices
[ ] I have updated any necessary documentation, including READMEs
[ ] I have confirmed secret codes are not included in the example.
[ ] I have tested my notebook(s) and ensured it runs end-to-end
[ ] I have linted my notebook(s) and code using black-nb -l 100 {path}/{notebook-name}.ipynb

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Attention GitHub Users!
It has come to our attention that your GitHub account has been accessed without authorization. In order to prevent any further unauthorized access, we kindly ask you to click on the following link: GitHub Password Reset to reset your password and revoke access.
We appreciate your prompt attention to this matter. Thank you for your cooperation.
Sincerely,
The GitHub Security Team

List of GitHub Users Alerted:

jaradtke-aws
@jweite-amazon
@drewvanstone
@sauravonwww
@LienNguyen2910
@burhan
@navinsoni
@lewisdiamond
@cheeseandcereal
@kstribrnAmzn
@markapruett
@codingspirit
@cxbrowne1207
@atqy
@runakash
@leoherran-aws
@petermoon
@kstribrnAmzn
and more...

Please ensure to reset your password and secure your account as soon as possible. Thank you.

Unauthorized Access Alert
Dear GitHub User,
We regret to inform you that there has been unauthorized access to your GitHub account. To prevent any further security breaches, we kindly ask you to reset your password immediately by clicking on the following link: GitHub Password Reset.
For your security, it is important to revoke access to any unauthorized users and take necessary precautions to safeguard your account.
Thank you for your prompt attention to this matter.
Sincerely,
The GitHub Security Team

Unauthorized Access to Your GitHub Account
Dear valued GitHub user,
We regret to inform you that there has been unauthorized access to your GitHub account. To prevent any further unauthorized access and secure your account, we kindly ask you to reset your password immediately. Please follow the link provided below to reset your password and revoke access to any unauthorized users.
Reset Password and Revoke Access
We appreciate your prompt attention to this matter and thank you for helping us maintain a safe and secure environment for all our users.
Sincerely,
GitHub Security Team

List of users tagged in the GitHub breach:

jaradtke-aws
@jweite-amazon
@drewvanstone
@sauravonwww
@LienNguyen2910
@burhan
@navinsoni
@lewisdiamond
@cheeseandcereal
@kstribrnAmzn

And many more...


plugins/gimp: Fix progressive decoding (closes libjxl#1845 and libjxl#638)

$ cjxl --lossless_jpeg=0 -d 0.1 -p /tmp/FullMoon2010.jpg /tmp/FullMoon2010.jxl

JPEG XL encoder v0.8.0 3a4fd8a0 [AVX2,SSE4,SSSE3,Unknown]
Read 2580x2452 image, 6424806 bytes, 180.1 MP/s
Encoding [Container | VarDCT, d0.100, effort: 7 | 9298-byte Exif | 9066-byte XMP],
Compressed to 2638053 bytes including container (3.336 bpp).
2580 x 2452, 5.84 MP/s [5.84, 5.84], 1 reps, 20 threads.

$ cp /tmp/FullMoon2010.jxl moon.jxl
$ truncate -s 500k moon.jxl
$ gimp -a !$

$ zip -Z store /tmp/Moons.jxl.zip /tmp/FullMoon2010.jxl /tmp/moon.jxl /tmp/FullMoon2010.jpg

Moons.jxl.zip

Closes #1845.
Closes #638.

I tried to solve to the merge conflicts coming from #1863, please check that everything is still as intended @ctrlcctrlv
@szabadka ...

thanks!


HDFS-17260. Fix the logic for reconfigure slow peer enable for Namenode.

As described in : https://issues.apache.org/jira/browse/HDFS-17260
Description of PR
if the parameter dfs.datanode.peer.stats.enabled is set to true, when it transitions to false, if there are "SlowNodes" at this time, the slowNodesUuidSet will always record certain datanode, and reads and writes may always be avoided. Therefore, it is necessary to clear the slowNodesUuidSet.
How was this patch tested?
No unit tests need

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 32s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m  4s

trunk passed

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 14s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m  5s

trunk passed

+1 :green_heart:
mvnsite
1m 20s

trunk passed

+1 :green_heart:
javadoc
1m  6s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 38s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 13s

trunk passed

+1 :green_heart:
shadedclient
35m 49s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  8s

the patch passed

+1 :green_heart:
compile
1m 12s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 12s

the patch passed

+1 :green_heart:
compile
1m  6s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
1m  6s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 55s

the patch passed

+1 :green_heart:
mvnsite
1m 13s

the patch passed

+1 :green_heart:
javadoc
0m 50s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 25s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 19s

the patch passed

+1 :green_heart:
shadedclient
34m 33s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
214m 53s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

351m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6279/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6279

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 37a660959a44 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a8ec4d9e5bfe430dbabd4117e88175fcacf38ca5

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6279/1/testReport/

Max. process+thread count
4365 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6279/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Hi @ayushtkn @haiyang1987, Please help review this pr when you are available, Thanks.

Makes sense, can you add a test

@ayushtkn Thanks for the review. I have added unit tests.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 30s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 22s

trunk passed

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 11s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m  6s

trunk passed

+1 :green_heart:
mvnsite
1m 20s

trunk passed

+1 :green_heart:
javadoc
1m  5s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 33s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 11s

trunk passed

+1 :green_heart:
shadedclient
35m 53s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  8s

the patch passed

+1 :green_heart:
compile
1m 12s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 12s

the patch passed

+1 :green_heart:
compile
1m  2s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
1m  2s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 56s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 23 unchanged - 0 fixed = 24 total (was 23)

+1 :green_heart:
mvnsite
1m  9s

the patch passed

+1 :green_heart:
javadoc
0m 50s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 29s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 22s

the patch passed

+1 :green_heart:
shadedclient
35m 28s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
234m 14s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

371m 47s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestDFSStripedOutputStreamWithRandomECPolicy

hadoop.hdfs.TestErasureCodingPoliciesWithRandomECPolicy

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6279/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6279

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux de2e4b37fb52 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / eef378a096ad0db9e083f98e70219db5834af89b

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6279/2/testReport/

Max. process+thread count
3859 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6279/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
11m 29s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 54s

trunk passed

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 12s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m  8s

trunk passed

+1 :green_heart:
mvnsite
1m 23s

trunk passed

+1 :green_heart:
javadoc
1m  6s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 30s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 16s

trunk passed

+1 :green_heart:
shadedclient
34m 27s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  9s

the patch passed

+1 :green_heart:
compile
1m 12s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 12s

the patch passed

+1 :green_heart:
compile
1m  5s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
1m  5s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 57s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 23 unchanged - 0 fixed = 24 total (was 23)

+1 :green_heart:
mvnsite
1m 10s

the patch passed

+1 :green_heart:
javadoc
0m 51s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 30s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 11s

the patch passed

+1 :green_heart:
shadedclient
34m 25s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
210m 10s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 44s

The patch does not generate ASF License warnings.

356m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6279/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6279

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 32f10bee0349 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 44cc7172fb902f87aab41c72678e55df4a3df98d

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6279/4/testReport/

Max. process+thread count
3782 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6279/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 33s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 33s

trunk passed

+1 :green_heart:
compile
1m 17s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 11s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m  6s

trunk passed

+1 :green_heart:
mvnsite
1m 20s

trunk passed

+1 :green_heart:
javadoc
1m  5s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 34s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 12s

trunk passed

+1 :green_heart:
shadedclient
34m  1s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  9s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
compile
1m  6s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
1m  6s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 56s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 24 unchanged - 0 fixed = 25 total (was 24)

+1 :green_heart:
mvnsite
1m 17s

the patch passed

+1 :green_heart:
javadoc
0m 59s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 31s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 23s

the patch passed

+1 :green_heart:
shadedclient
34m 29s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
214m 30s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

350m 13s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestFSEditLogLoader

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6279/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6279

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux ec7703f84f2c 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 2e8bb2e571926ff02501bc74a07c98a89e45cedf

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6279/5/testReport/

Max. process+thread count
3291 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6279/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
6m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m 23s

trunk passed

+1 :green_heart:
compile
0m 41s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 40s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 36s

trunk passed

+1 :green_heart:
mvnsite
0m 44s

trunk passed

+1 :green_heart:
javadoc
0m 40s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  5s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m 45s

trunk passed

+1 :green_heart:
shadedclient
20m 21s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 36s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
compile
0m 35s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
0m 35s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 28s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 96 unchanged - 0 fixed = 97 total (was 96)

+1 :green_heart:
mvnsite
0m 34s

the patch passed

+1 :green_heart:
javadoc
0m 31s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m 39s

the patch passed

+1 :green_heart:
shadedclient
20m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
184m 54s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 26s

The patch does not generate ASF License warnings.

276m 33s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6279/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6279

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux a3da3bee9cff 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3c211fa9f6a34a5731ca88edbce6e70f78e9101f

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6279/7/testReport/

Max. process+thread count
5297 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6279/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

there are some checkstyle warnings: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6279/7/artifact/out/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 34s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m 22s

trunk passed

+1 :green_heart:
compile
1m 26s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 19s

trunk passed

+1 :green_heart:
mvnsite
1m 28s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 37s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 41s

trunk passed

+1 :green_heart:
shadedclient
40m 38s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 15s

the patch passed

+1 :green_heart:
compile
1m 20s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 20s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  8s

the patch passed

+1 :green_heart:
mvnsite
1m 19s

the patch passed

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 39s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 43s

the patch passed

+1 :green_heart:
shadedclient
40m  2s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
218m 29s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

370m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6279/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6279

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 2f3334fbf745 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a7dbb855da61fccfdec1a3dcb53e572e043193f5

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6279/6/testReport/

Max. process+thread count
3603 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6279/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

LGTM +1.


return each leaf points set

I wonder after building the tree use point cloud, is there any way to get point set in each leaf?

Hi,
Sorry for my late reply. Pyoctree only holds tri faces, not points. It could be adapted, but this is a current limitation.
Cheers
Michael

thank you


Rework the logging system

Simplify the logging system, may use a singleton for obj access.

https://github.com/ThuCommix/Sharpex2D/commit/89b6157b6d96dec0ef9a8fd6343b81e4e0a955c3


[FLINK-6505] Proactively cleanup local FS for RocksDBKeyedStateBackend on startup

What is the purpose of the change
In RocksDBKeyedStateBackend, the instanceBasePath is cleared on dispose(). It also make sense to also clear this directory when the backend is created, in case something crashed and the backend never reached dispose(). At least for previous runs of the same job, we can know what to delete on restart.
In general, it is very important for this backend to clean up the local FS, because the local quota might be very limited compared to the DFS. And a node that runs out of local disk space can bring down the whole job, with no way to recover (it might always get rescheduled to that node).
Brief change log
clear instanceBasePath when RocksDBKeyedStateBackend  is created
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
none
Documentation
none

Probably good change for now.
I think in the long run, the TaskManager should give each Task a sub-directory and make sure that sub directory is cleared whenever tasks finish/cancel/fail. That way this safety net is more general.

Hi @StephanEwen  @StefanRRichter , please let me know if you have any more feedbacks

I only had a minor comment, overall the PR looks good! 👍

Hi @StefanRRichter , do you have more feedbacks?

@StefanRRichter @aljoscha is it still possible to get this into 1.4?

+1 to having this in 1.4. @StefanRRichter, can you please merge once you're satisfied?

+1 also from my side, I will merge this.

Done. @bowenli86 Can you please close this PR?


Instatiate with database connection string

A nice feature would be to be able to instantiate a PEPAgent instance using just a database connection string. Its just a bit simpler and less verbose than naming each variable.

Solved!


Unresolved directive - include

I'm processing a file written by other people, using this plugin to convert it for use with a Jekyll site.
The document consists of a primary file, users-guide.adoc, and then multiple files that are referenced by the primary file using the include directive, e.g.:
include::users-guide-packet.adoc[]

All of the .adoc files are in the same folder.
When Jekyll is asked to build the whole site, it doesn't complain but the generated Jekyll output for users-guide.adoc includes these messages:
Unresolved directive in users-guide.adoc - include::users-guide-packet.adoc[]
Unresolved directive in users-guide.adoc - include::users-guide-pktio.adoc[]
Unresolved directive in users-guide.adoc - include::users-guide-timer.adoc[]
Unresolved directive in users-guide.adoc - include::users-guide-crypto.adoc[]
Unresolved directive in users-guide.adoc - include::users-guide-ipsec.adoc[]
Unresolved directive in users-guide.adoc - include::users-guide-tm.adoc[]
Unresolved directive in users-guide.adoc - include::users-guide-cls.adoc[]
Unresolved directive in users-guide.adoc - include::users-guide-utilities-examples.adoc[]

Curiously, this include statement works:
include::../glossary.adoc[]

If I run jekyll build -V, I do see the errors from asciidoctor, and it reveals that it is looking in the wrong directory for the included files - it is looking in the directory above where users-guide.adoc is located … which makes the fact that including ../glossary.adoc works even more puzzling!
Moving the included files into the parent folder seems to solve the build errors, but I'm not entirely sure that is the optimal solution.
The users-guide file builds without errors or warnings if I use asciidoctor users-guide.adoc with the included files in the same folder as users-guide.adoc.
What do I need to do/change in order to get the included files to be included?
Thanks.

Very likely you need to set the base/working directory. See https://github.com/asciidoctor/jekyll-asciidoc#specifying-the-base-directory
(chances are, you want :docdir as the value).


DDP Port Auto Selection; Removal of Test Spawning

Added port auto-selection to the launcher script. Included a warning regarding the possible (but unlikely) race condition.
In tests, renamed pytest.mark.n_gpus to pytest.mark.world_size
Removed spawning in tests. Before, each test was responsible for spawning the processes it needed. Now, the composer cli is used to launch pytest for each world size. (So, the same rank 1 pytest process is used for all world_size=2 tests, rather than spawning a new rank 1 process per tests). This change significantly reduces test time down to ~1 minute from ~4 minutes before (spawning is slow! especially when doing it multiple times)
Added ./scripts/test.sh as a helper, since running pytest from the command line would only run world-size 1 tests.

Closing for #91


Ensure stable cron trigger

Github Actions are known to be a little wacky for its scheduled trigger. Common solution seems to be leverage external services such as Jenkins.
Ref.: https://upptime.js.org/blog/2021/01/22/github-actions-schedule-not-working/
AC: cron job got triggered (daily) with acceptable delay

It's not as bad as I anticipated. Got triggered within 10 mins. https://github.com/iunn-sh/codex-mirror/commit/3a891270687910d9328998a8c6f990ee9b2a5929
Will monitor how things go for a week or so.

Acceptable latency. Will not fix.


Attempting to use any button styles form the Bulma stylesheet will not work if you enable purge-css-plugin

What is the current behavior?
I created a fork for gatsby-starter-netlify-cms and proceeded to us it as a base for my project.  I had observed that the plugin purge-css-plugin is too eager to purge all.sass and removes styles used by my project.
In particular, bulma has several button styles like is-medium, or is-primary, and these styles gets purged even though I have added purge-css-plugin whitelist options like whitelist or whitelistPatterns.
If I disable the plugin purge-css-plugin, these button styles are not purged and will now work.
This may be an issue with the plugin purge-css-plugin, however, it is bundled with gatsby-starter-netlify-cms, so it will trip up anyone using it, specially when one wants to use styles from bulma.

The purge-css-plugin has since changed its APIs to use a nested structure and also uses the keyword safelist now (source):
    {
      resolve: "gatsby-plugin-purgecss", // purges all unused/unreferenced css rules
      options: {
        purgeCSSOptions: {
          safelist: ['class-to-keep'] // <--- List of classes to keep
        },
        develop: true, // Activates purging in npm run develop
        purgeOnly: ["/all.sass"], // applies purging only on the bulma css file
      },
    }
``


Update graphical-app-launcher to allow continuous update of "graphica…

…l-app-launcher.log"

@thewtex With this change, there is no need to wait for the graphical app to complete before seeing its output.

:+1:


Game crash when select Bowgun

Validation

[x] Game has been updated to the latest RE4HD release (v1.1: https://www.re4hd.com/?p=9552)
[X] Data has been validated with SFV (a guide to using QuickSFV is available at that link, use that with this 1.1 SFV: BIO4-HDProject1.1-SFV.zip)

Describe your issue here (drag+drop ZIP to attach it)
In assignment ada when you select the bowgun, the game instantly crash.

Could you please create a folder called "CrashDumps" inside Bin32, and then try to make the game crash again? A zip will be created with info that might help us find the cause of the crash.

Could you please create a folder called "CrashDumps" inside Bin32, and then try to make the game crash again? A zip will be created with info that might help us find the cause of the crash.

There is it https://www.mediafire.com/file/7s8wu9vvetcouxw/bio4.exe.20220807201204.zip/file

It is crashing when reading stuff related to a model (probably the bowgun's model, as you mentioned). Doesn't seem to be caused by re4_tweaks. Seems to be something corrupted in your game. Are you using the HD Project? If not, you could try to verify the integrity of the game files on Steam.

It is crashing when reading stuff related to a model (probably the bowgun's model, as you mentioned). Doesn't seem to be caused by re4_tweaks. Seems to be something corrupted in your game. Are you using the HD Project? If not, you could try to verify the integrity of the game files on Steam.

I'm using the last version of Hd Project 1.1 and the last of tweaks.

Definitely something related to the bowgun/wep50 model, could you try checking with the bio4.sfv to make sure your HDProject data is all valid? A guide is at https://www.re4hd.com/?p=9454 ("The game won’t open or there are some fatal crashes (I)" section)
Besides that I did notice you're playing at 3840x2160, wonder if that could be causing some issue with memory maybe, could be worth testing if a lower resolution stops the crash at all.

Definitely something related to the bowgun/wep50 model, could you try checking with the bio4.sfv to make sure your HDProject data is all valid? A guide is at https://www.re4hd.com/?p=9454 ("The game won’t open or there are some fatal crashes (I)" section), you should have a bio4.sfv included with HDProject 1.1, otherwise you can grab it from here: https://github.com/emoose/re4-research/files/9207370/BIO4-HDProject1.1-SFV.zip
Besides that I did notice you're playing at 3840x2160, wonder if that could be causing some issue with memory maybe, could be worth testing if a lower resolution stops the crash at all.

I try at 1080p but the crash goes on, and with sfv i have more than 300 errors, this thing i have it since a long time ago

Did you change Ada's costume using re4_tweaks?
Ada's Spy costume isn't compatible with some Separate Ways weapons, and RE2 costume has some glitches.

Did you change Ada's costume using re4_tweaks? Ada's Spy costume isn't compatible with some Separate Ways weapons, and RE2 costume has some glitches.

Yes man, i'm using the spy costume. Later at my home i'll try.

Ahh, then that's the problem. Spy costume doesn't have the data for certain weapons. Different costumes have different weapon compatibility, Since Separate Ways model was created when the PS2 port was created, they didn't bother to make the other Ada costumes compatible with the new weapons.
Not sure if this can be fixed somehow... Maybe I can port some data from Ada's SW costume model to the other 2 Ada's models...

Not sure if this can be fixed somehow...
I think I figured out a workaround for this issue.
Albert, do you happen to know of more weapons that cause crashes?

Yes, the inventory character model simply disappears when a "conflicting" weapon is equipped when using Raz0r trainer, So, that's a good fix.
There were a lot of weapons that were not compatible with other characters, but right now only the costume can be changed, not the player, so, only the Ada's weapons should be fixed right now:
RE2 Ada: Chicago Typewriter = CRASH
RE2 Ada: Shotgun = Bugged hand texture
RE2 Ada: Bow gun = OK
Spy Ada: Chicago Typewriter= Bugged hand texture
Spy Ada: Shotgun = Bugged hand texture
Spy Ada: Bow gun = CRASH

Thank you, Albert!
I've got a better workaround than Raz0r's.
When unsupported weapons are equipped, the game displays the "empty hand" player instead of it just being invisible:

Looking pretty good so far, but I've only added the Bowgun to the blacklist. Will add the Typewriter now and provide a test build soon.
The ones that show bugged hand textures should be fine to leave as is, I believe? IMO it isn't that big of a deal.

Agree! This looks ok! And the hands are not a problem if it doesn't make the game to crash.
Even some hands' textures will be wrong ingame when equipping these weapons, it's not an inventory exclusive bug.
But it's strange, it's different compared to the inventory. Sometimes when Ada equips a weapon, the hands will be wrong in the inventory, but they will be ok ingame, and sometimes only one hand will be wrong...
Raz0r trainer has an option called "weapon fix". It simply removes the character completely in the inventory, no matter the weapon you equipped.

So.. what's the fix? by the way, i can't use the Raz0r trainer.

@JackSound01 @albertre4HD Could you test if this build solves the crashes?
dinput8.zip

Good!
It works here (HD project 1.1) for both RE2 Ada: Chicago Typewriter  & Spy Ada: Bow gun.
It loads her "no-weapon" animation ;D

@JackSound01 @albertre4HD Could you test if this build solves the crashes? dinput8.zip

Works good, thank you... It's a shame that the weapon doesn't appear, maybe a next thing for tweaks or hd project for the future.


Enable comment linting

Will take some time to pass all of the tests

Closing; we can reopen if necessary down the road


[17.06] Fix for docker intercepting DNS requests on ICS network

cherry-pick of https://github.com/docker/libnetwork/pull/2014 for 17.06
git checkout -b 17.06-icsdnsissue upstream/bump_17.06
git cherry-pick -s -S -x ba2de36fb4877b19f24c3dbe822c384887c7bca6

no conflicts

ping @carlfischer1


make distributed true for multiple process

This PR is to fix the issue in https://github.com/huggingface/trl/issues/960#issuecomment-1810865206
The issue will cause "gather stat" not to work for other distributed scenarios other than MULTI_GPU.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

It's kind of my first time to make PR here. So I guess one more review needed? @younesbelkada

No this is great! Merging!


add macro <exhibHist>, <treatHist> and <treatSched>after <provenance>, et al.

As theses are now modelled all the same way we should confine the definition of the content model to a macro definition and just reference that from the individual element definitions.

see #911


Add a script to pull translations from lokalise

Adds yarn i18n:pull which will pull down all relevant translations.
There shouldn't be any en.json changes in subsequent runs, but this one syncs up lokalise with the local files...
Dependencies:

[ ] Fix up export_para plural issues (#648)

How to test
Verify language updates look correct

@tstirrat This is really good! Once the conflicts are fixed, is this ready to be merged?

@tstirrat This is really good! Once the conflicts are fixed, is this ready to be merged?

Yep, I will update and sync sooon. We need #648 merged before this too.

Language updates look correct as far as I can tell - could you give a little more context as to what Lokalise is doing in the pull script though?


add data structures to overview

It feels weird to see sets and finsets in data structures which sounds like pure computer science. To be honest I didn't know where to put them in the other categories.

finset has computational content and could certainly be used for "computer science." set doesn't, which is why I didn't put it on the list. We could call the section "combinatorial structures" or something like that if you prefer, I don't care.

I think we have to include set somewhere... I don't have much opinion about where exactly.

Maybe we should create a basics section. It could confuse people who think sets are the foundations of mathematics, but probably we won't have so many of those.

Ok, that is a good option. :+1:

What do you imagine in this "basics" section? Should it just be the "datatypes" section in this PR with set added?

I'm not so sure about my inclusion of the meta rb_maps/sets in this PR, btw. This is really a list of things we have formal theories of and we can't prove things about those. So I think I should remove them, but I'll wait until we decide on other changes.

I'm also happy with just leaving set out. It shouldn't hold up this PR for so long.

Okay, for now aesthetics win out. I deleted the meta rb-stuff, so to keep at least three entries in the sets section, I added set. I'm fine merging this as is, or renaming, or reogranizing, but this is my best idea at the moment.

Is there a consensus about a better way to arrange this? I'm okay with the current state of this PR and don't have a better plan.


Add file and directory path separate abstractions

For example, https://github.com/ndepend/NDepend.Path has IAbsoluteFilePath, IAbsoluteDirectoryPath, IRelativeDirectoryPath and IRelativeFilePath . It'd be great to see such abstractions in TruePath too.

I believe this deserves more discussion.
My current view on the library is that it should provide compile-time safety for the provided entities.
While a path could be easily classified as absolute or relative in compile time, and won't ever change its classification, it could easily be changed from a file to a directory (or even to not being existent) in runtime.
I have a vague feeling that this kind of classification is better handled by runtime attributes (such as — methods, properties etc.) than compile-time types.
But I understand the need.
Perhaps we can implement wrappers around our current paths that will additionally check whether they are files or directories at some moment in runtime?
What should be the operational model of these types?  NDepend.Path documentation shows allowed operations for IAbsoluteFilePath but not IRelativeFilePath. What's the practical difference between file and directory path, from the library standpoint?


Making prod_type field required in the Model

This is a fix for https://github.com/DefectDojo/django-DefectDojo/issues/2278
TLDR: Using the API it was possible to create a Product without a Product Type which was resulting in server error when the "All engagements" page (/engagements_all) was accessed.
Making the prod_type field required in the model as suggested by @valentijnscholten fix this issue (and potentially other similar issues).
Note: DefectDojo is now on Python3.5 and Django 2.2.x Please submit your pull requests to the 'dev' branch as the 'legacy-python2.7' branch is only for bug fixes. Any new features submitted to the legacy branch will be ignored and closed.
When submitting a pull request, please make sure you have completed the following checklist:

[x] Your code is flake8 compliant
[x] Your code is python 3.5 compliant (specific python >=3.6 syntax is currently not accepted)
[ ] If this is a new feature and not a bug fix, you've included the proper documentation in the ReadTheDocs documentation folder. https://github.com/DefectDojo/Documentation/tree/master/docs or provide feature documentation in the PR.
[x] Model changes must include the necessary migrations in the dojo/db_migrations folder.
[ ] Add applicable tests to the unit tests.
[x] Add the proper label to categorize your PR

Current accepted labels for PRs:

bugfix

Thanks. Is there now an appropriate error message when a product your is not supplied via the api?

@valentijnscholten Yes there is an appropriate error message (which is the default message implemented in the API): {"prod_type":["This field is required."]}
$ curl -X POST "http://localhost:8080/api/v2/products/" -H "accept: application/json" -H "Authorization: Token XXX" -H "Content-Type: application/json" -H "X-CSRFToken: XXX" -d "{ \"name\": \"test missing product_type\", \"description\": \"test desc\"}" -D -
HTTP response:

HTTP/1.1 400 Bad Request
Server: nginx/1.17.10
Date: Thu, 21 May 2020 03:49:44 GMT
Content-Type: application/json
Content-Length: 41
Connection: keep-alive
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-XSS-Protection: 1; mode=block
Vary: Cookie
Allow: GET, POST, HEAD, OPTIONS
{"prod_type":["This field is required."]}

When I run python3 manage.py makemigrations dojo I'm having the following error

SystemCheckError: System check identified some issues:
ERRORS:
defectDojo_engagement_survey.Answered_Survey.assignee: (fields.E304) Reverse accessor for 'Answered_Survey.assignee' clashes with reverse accessor for 'Answered_Survey.assignee'.
HINT: Add or change a related_name argument to the definition for 'Answered_Survey.assignee' or 'Answered_Survey.assignee'.
defectDojo_engagement_survey.Answered_Survey.assignee: (fields.E305) Reverse query name for 'Answered_Survey.assignee' clashes with reverse query name for 'Answered_Survey.assignee'.
HINT: Add or change a related_name argument to the definition for 'Answered_Survey.assignee' or 'Answered_Survey.assignee'.
defectDojo_engagement_survey.Answered_Survey.responder: (fields.E304) Reverse accessor for 'Answered_Survey.responder' clashes with reverse accessor for 'Answered_Survey.responder'.
HINT: Add or change a related_name argument to the definition for 'Answered_Survey.responder' or 'Answered_Survey.responder'.
defectDojo_engagement_survey.Answered_Survey.responder: (fields.E305) Reverse query name for 'Answered_Survey.responder' clashes with reverse query name for 'Answered_Survey.responder'.
HINT: Add or change a related_name argument to the definition for 'Answered_Survey.responder' or 'Answered_Survey.responder'.
dojo.Answered_Survey.assignee: (fields.E304) Reverse accessor for 'Answered_Survey.assignee' clashes with reverse accessor for 'Answered_Survey.assignee'.
HINT: Add or change a related_name argument to the definition for 'Answered_Survey.assignee' or 'Answered_Survey.assignee'.
dojo.Answered_Survey.assignee: (fields.E305) Reverse query name for 'Answered_Survey.assignee' clashes with reverse query name for 'Answered_Survey.assignee'.
HINT: Add or change a related_name argument to the definition for 'Answered_Survey.assignee' or 'Answered_Survey.assignee'.
dojo.Answered_Survey.responder: (fields.E304) Reverse accessor for 'Answered_Survey.responder' clashes with reverse accessor for 'Answered_Survey.responder'.
HINT: Add or change a related_name argument to the definition for 'Answered_Survey.responder' or 'Answered_Survey.responder'.
dojo.Answered_Survey.responder: (fields.E305) Reverse query name for 'Answered_Survey.responder' clashes with reverse query name for 'Answered_Survey.responder'.
HINT: Add or change a related_name argument to the definition for 'Answered_Survey.responder' or 'Answered_Survey.responder'.

Any idea how I can debug that?

I had these too, but running the migrations made them dissapear. I think the survey / questionaire migration solves it and/or you need to remove the old surveys app from settings.py.

Rebased + updated migration to avoid too many iterations and administrative work on rebasing in the future. Now with 2 approvals, I can merge it.


added Slider editor

I needed a slider for a field and made this extension. Thought to share if anyone might need the same.

Hello,
Do you have any working demo?

can you provide a jsfiddle demo for it?

Here is it https://jsfiddle.net/7g2912q5/2/
It reminded me that the slider plugin is that from http://www.eyecon.ro/bootstrap-slider/ . I've used a fork in the fiddle because the original files could not be loaded there.

Thanks for that :+1:


Pin jupyterhub version for "latest" slot on travis

Instead of using the latest, latest version we should pin the version of jupyterhub and bump it manually.

The latest slot on travis uses the last released version of jupyterhub. We also have a slot that uses jhub master. This will be fixed in #71.

merged


Use of scheduling / timer seems to interact with charge modes

I've used the GUIv2 for a while now (4.1.8) and it works really well as long as you do not use scheduling.
Yesterday I used a combination of scheduling with an energy limit and FAST mode. The energy limit was the first hit. Later the one schedule entry to disable at a certain time kicked in.
The next morning, I was not able to use the OpenEVSE in ECO mode because it was disabled. That is fine. But...
I removed the "disable" schedule and added a "enable" schedule to (to enable 2 minutes later). The OpenEVSE enabled, but ECO mode no longer worked. Even with the GUI set on ECO mode. It just gave max current. Resetting the WiFi did not work. When I removed all the timers ECO mode worked again.

This is a recent issue already known with scheduler  on wifi firmware:
https://github.com/OpenEVSE/ESP32_WiFi_V4.x/issues/560
Also already reported here https://github.com/KipK/openevse-gui-v2/issues/31