clr-tree-node expanded by default and not responding

[x] bug
[ ] feature request
[ ] enhancement

Expected behavior
The <clr-tree-node> should be minimized by default and hiding it's children, also clicking on the arrow on the left should expand/reduce it
Actual behavior
The <clr-tree-node> is expanded by default and clicking on the left arrow only trigger the rotate animation of the arrow, nothing else.
Reproduction of behavior
https://plnkr.co/edit/lSOn1DbZpO6nSJs46zph?p=preview
also in our app  : https://github.com/TraceSoftwareInternational/HostMyDocs/blob/master/FrontEnd/src/ts/components/projects-tree/template.html
Environment details

Angular version: 4.1.3

Clarity version: 0.9.7

OS and version: Linux Mint 18.1 Cinnamon edition 64-bit

Browser: [Chrome Beta 59.0.3071.83 &&  Firefox Nightly 55.0a1 (2017-06-01) (64 bits)]

@MattMattV: Thanks for reporting this. We will take a look and get back to you.

@MattMattV: We took a look at this and found out that this is happening because of the ng-container not being projected at the right place. You will have to add ngProjectAs="clr-tree-node on ng-container to make this work. Here is a plunkr showing this: https://plnkr.co/edit/kZp2yDYm62PmTF1jfKOq?p=preview I am closing this issue but feel free to reopen this if you feel that the issue is still unresolved.

Thank you for your answer !1

where is the demo ? my tree node not work too! error->'clrTreeNodeExpandable' since it isn't a known property of 'clr-tree-node'

@icepoint0
Please take a look at the Plunkr @adityarb88 posted here:
https://plnkr.co/edit/kZp2yDYm62PmTF1jfKOq?p=preview
Thanks.

@icepoint0: Not sure what happened to the plnkr but you should find the demos in our documentation: https://vmware.github.io/clarity/documentation/tree-view Please note that this documentation is for v0.9. It seems that you are using one of the alpha versions of 0.10 which has a breaking in tree view. You can find more info about migrating from 0.9 to 0.10 here: https://vmware.github.io/clarity/news/0.10.0-alpha

@adityarb88 thank u , by the way, document is v0.9 now?

@icepoint0: Yes the documentation is on v0.9 because 0.10 is still in alpha.


add maven wrapper

Adds maven wrapper script to the directory-server project.  See https://maven.apache.org/wrapper/
From the Maven Wrapper page:
"The Maven Wrapper is an easy way to ensure a user of your Maven build has everything necessary to run your Maven build.
Why might this be necessary? Maven to date has been very stable for users, is available on most systems or is easy to procure: but with many of the recent changes in Maven it will be easier for users to have a fully encapsulated build setup provided by the project. With the Maven Wrapper, this is very easy to do and it's a great idea and initial implementation borrowed from Gradle."
I also updated the wrapper properties to specifically use Maven 3.8.6.
Note: This should not affect any tool or environment using traditional maven to build; it only adds an additional option to run maven via the script and auto-downloaded maven version.

Merge done. Thanks for the PR !


Migrate bcrypt APIs

Removed all evil blanks :)

Fixed :)

Could you update your three PRs now that I fixed the issue causing the CI failures?


HBASE-24546 CloneSnapshotProcedure unlimited retry

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 20s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 30s
the patch passed

+1 :green_heart:
compile
1m  9s
the patch passed

+1 :green_heart:
javac
1m  9s
the patch passed

+1 :green_heart:
shadedjars
6m 22s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 42s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
196m 42s
hbase-server in the patch passed.

225m 26s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1900/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1900

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a4fc6554aa5e 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d0f190bdf0

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1900/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1900/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1900/1/testReport/

Max. process+thread count
2893 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1900/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 13s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 49s
the patch passed

+1 :green_heart:
compile
1m 15s
the patch passed

+1 :green_heart:
javac
1m 15s
the patch passed

+1 :green_heart:
shadedjars
6m 47s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 49s
hbase-server in the patch failed.


Reserved word 'enum' used as name

I noticed a small detail in the repository and wanted to bring it to your attention to enhance the code. In the file rules/index.js, I noticed that you are using the reserved JavaScript word "enum" in the export of a function.
export { enumeration as "enum" } from './enum';
However, according to the JavaScript specification (see link), "enum" is a reserved keyword and may cause issues in certain situations. I would suggest considering a modification to avoid potential inconveniences.
Thanks for your commitment to improving the project.

You are allowed to use a reserved word in an object property.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Lexical_grammar#identifiers
That is why the validation function is created as enumeration in enum.js and renamed to enum on exporting.


feat: url builder

Implementation of a URL Builder per the discussion in #798
Had 1 conceptual question, should this support mailto, tel, ftp, ftps just like templ.URL? If so, how do you envision the functions? Change urlbuilder.New to urlbuilder.NewURL, then addurlbuilder.NewMailto, etc?

This looks great. My only reluctance is to merge it into the templ mainline straight away.
Was thinking it might be a good idea to create a new module github.com/templ-go/x and add this package into that where there's no expectation of stable APIs, then get feedback from users, before merging into templ.

I like that idea, I could go ahead and do that, just need the repo to be created in the templ-go organization

See https://github.com/templ-go/x for experimental repo.
If you're able, I would love a PR that updates the docs to:

Point at the new experimental repo,
Documents the experimental URL builder in the templ docs
Links to a Github discussion about the URL builder to collect community feedback


[Event Request] Database::"Purchase Line" - Function GetOverheadRateFCY - OnBeforeGetOverheadRateFCY

We like to request the following Event:
Object: Database::"Purchase Line"
Function: GetOverheadRateFCY
Publisher Event: OnBeforeGetOverheadRateFCY
Reason: To implement custom business logic
Where is the event placed:
local procedure GetOverheadRateFCY(): Decimal
var
Item: Record Item;
QtyPerUOM: Decimal;
IsHandled: Boolean;
ExitValue: Decimal;
begin
IsHandled := false;
OnBeforeGetOverheadRateFCY(Rec, QtyPerUOM, ExitValue, IsHandled);
if IsHandled then
exit(ExitValue);
if "Prod. Order No." = '' then
QtyPerUOM := "Qty. per Unit of Measure"
else begin
GetItem(Item);
QtyPerUOM := UOMMgt.GetQtyPerUnitOfMeasure(Item, "Unit of Measure Code");
end;
Event Code:
[IntegrationEvent(false, false)]
local procedure OnBeforeGetOverheadRateFCY(var PurchaseLine: Record "Purchase Line"; var QtyPerUOM: Decimal; var ExitValue: Decimal; var IsHandled: Boolean)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Sustain Note Ends Fix

Changes 'end' to 'tail' to prevent crash.

my phone does not want to work but i must test 5his first


Setting sync word - incorrect registers?

I think there's a bug setting the sync word to the correct registers.
In sx127x.cpp, under int16_t SX127x::setSyncWord(uint8_t* syncWord, size_t len), it looks like all bytes of the sync word are only written to RegSyncValue1 (line 804):
  _mod->SPIwriteRegisterBurst(SX127X_REG_SYNC_VALUE_1, syncWord, len);
However, each byte of syncWord should be written to RegSyncValue1 through RegSyncValue8 respectively (see screenshot of sx1272 datasheet below).

The method used there is SPIwriteRegisterBurst - it will write in "burst" mode, i.e. write len bytes of data to len registers, starting at SX127X_REG_SYNC_VALUE_1. It's more convenient and faster than calling SPIwriteRegisterBurst multiple times.

Got it - thanks!


Failure to build using current (1.59) nightly

Rust version:
$ rustup run nightly rustc --version
rustc 1.59.0-nightly (e2116acae 2021-12-05)

Build output):
$ cargo +nightly install papyrus
### many properly compiling packages ellided ###
   Compiling rustc-ap-rustc_span v722.0.0
error[E0635]: unknown feature `thread_local_const_init`
  --> /home/jaskij/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_span-722.0.0/src/lib.rs:23:12
   |
23 | #![feature(thread_local_const_init)]
   |            ^^^^^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0635`.
error: could not compile `rustc-ap-rustc_span` due to previous error
warning: build failed, waiting for other jobs to finish...
error: failed to compile `papyrus v0.17.2`, intermediate artifacts can be found at `/tmp/cargo-installDt6oKN`

Caused by:
  build failed

Crates.io link to failing crate and version: https://crates.io/crates/rustc-ap-rustc_span/722.0.0

Same issue when trying to install racer
error[E0635]: unknown feature `thread_local_const_init`
  --> /home/adam/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_span-722.0.0/src/lib.rs:23:12
   |
23 | #![feature(thread_local_const_init)]
   |            ^^^^^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0635`.
error: could not compile `rustc-ap-rustc_span` due to previous error
warning: build failed, waiting for other jobs to finish...
error: failed to compile `racer v2.1.48`, intermediate artifacts can be found at `/tmp/cargo-installcXsaZj`

same issue when compiling racer
error[E0635]: unknown feature `thread_local_const_init`
  --> /home/adam/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_span-722.0.0/src/lib.rs:23:12
   |
23 | #![feature(thread_local_const_init)]
   |            ^^^^^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0635`.
error: could not compile `rustc-ap-rustc_span` due to previous error
warning: build failed, waiting for other jobs to finish...
error: failed to compile `racer v2.1.48`, intermediate artifacts can be found at `/tmp/cargo-install8olDbb`

Caused by:
  build failed

Looking at the racer-rust issues it seems that I just needed to use a different version of the nightly compiler. I can confirm this worked for me. Please look at https://github.com/racer-rust/racer/issues/1173 and see if that version of the nightly compiler fixes your issues

It appears that racer is still using an old nightly compiler
this is what worked for me
rustup toolchain add nightly-2021-06-07

cargo +nightly-2021-06-07 install papyrus

After trying with the above suggestion from @anantasty I'm getting:
error[E0635]: unknown feature `proc_macro_span_shrink`
  --> /home/heyset/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-1.0.51/src/lib.rs:92:30
   |
92 |     feature(proc_macro_span, proc_macro_span_shrink)
   |                              ^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0635`.
error: could not compile `proc-macro2`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error[E0635]: unknown feature `proc_macro_span_shrink`
  --> /home/heyset/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-1.0.51/src/lib.rs:92:30
   |
92 |     feature(proc_macro_span, proc_macro_span_shrink)
   |                              ^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0635`.
error: failed to compile `papyrus v0.17.2`, intermediate artifacts can be found at `/tmp/cargo-installcI1oxP`


Question About Initial sync Behavior Without Prior arrive in Warpgroup Scheduling

I have a question regarding the diagram below:
At the very beginning, the sync function is called directly, but there is no prior arrive. Wouldn't this cause the program to deadlock? (Assuming for argument's sake that the first sync does not result in a deadlock.)
In this case, isn’t it uncertain which warp group starts first? For example, it’s not necessarily Warpgroup 1 that begins. The startup sequence seems random, doesn’t it?
That said, it seems to work either way. Even if the roles of Warpgroup 1 and Warpgroup 2 are reversed, the ping-pong mechanism would still function as intended. Could someone clarify this behavior?

The first arrive is in mma_init

Wow, I get it. This is really very bueatiful!


Cleanup wireguard tunnel address

Description

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

Fix that deleting a node didn't release its wireguard tunnel address

/merge-when-ready

OK, Adding "merge-when-ready" label and will merge the PR when it's ready.

Hey Marvin get to work

/remove-merge-when-ready

OK, removing "merge-when-ready" label, PR will need to be manually merged when ready

/merge-when-ready

Its OK @marvin-tigera, you tried. Better luck next time.


Allow for custom metric during Monte-Carlo

Currently using L2, but we could use cosine or anything else.

Fixed in https://github.com/Dref360/spectral_metric/commit/6d8be4e46e66e4c65e743e4fac0653315b3b92f8


How to handle series name / number?

CGSpace is wondering how to handle series name and number. We currently use something of a convention like "series name; series number" for dc.relation.ispartofseries. For example:

ELKS Technical Bulletin;2
Livestock Exchange Think Piece;22
IFAD Research Series;35
Annual Report;2006.2
ILRI Policy Brief;
Spore;89

Currently the draft CG Core v2 suggests using cg.series. Do we think it is important to keep series name and number together or should we use a separate field?

if it is used, I propose that we add cg.seriesName et rename cg.serie to cg.seriesNumber. Would that solution work for you?

if it is used, I propose that we add cg.seriesName et rename cg.serie to cg.seriesNumber. Would that solution work for you?

what about you @olatunike, would that work for your system?

what about you @olatunike, would that work for your system?

Yes, it can still work for me. I'll modify the schema to reflect the modification if that's what we opt for.

Yes, it can still work for me. I'll modify the schema to reflect the modification if that's what we opt for.

Thanks for the responses! On CGSpace we are planning to do the following:

dcterms.isPartOf for series name (see dcterms guidance)
cg.number for series number¹ (currently indicated for issue number)

Our preference is to always use a DC field where possible, then a CG Core one, then a CGSpace custom one.

¹ I propose to amend the description of cg.number to add "series":

The issue number of a journal, magazine, series or tech-report

Thanks for the responses! On CGSpace we are planning to do the following:

dcterms.isPartOf for series name (see dcterms guidance)
cg.number for series number¹ (currently indicated for issue number)

Our preference is to always use a DC field where possible, then a CG Core one, then a CGSpace custom one.

¹ I propose to amend the description of cg.number to add "series":

The issue number of a journal, magazine, series or tech-report

I posted an update to my message above based on some testing in DSpace. I had suggested using cg.number for both issue number and series number, but that is problematic in DSpace because we have two separate fields for those currently and DSpace gets confused.
@marieALaporte May I suggest that we use cg.issue for journal issue, which would be in the same line of thinking as using cg.volume anyways. Then we could use cg.number or something else for series number.
This is one area where DC can't help us at all because they are really generic and our metadata is very academic/publishing oriented. We have to forge our own path.

I posted an update to my message above based on some testing in DSpace. I had suggested using cg.number for both issue number and series number, but that is problematic in DSpace because we have two separate fields for those currently and DSpace gets confused.
@marieALaporte May I suggest that we use cg.issue for journal issue, which would be in the same line of thinking as using cg.volume anyways. Then we could use cg.number or something else for series number.
This is one area where DC can't help us at all because they are really generic and our metadata is very academic/publishing oriented. We have to forge our own path.

I think these are good suggestions on how CG Core can be improved, so maybe to create the next version. I assume the main reason why we have CG Core is because DC does not have it all.


More justification for the sinusoidal density function

Make it super super clear in the text that we're not dumb and think that this is a real world case. It's for testing the algorithm to its limits.

Include the disclaimer everywhere that we mention "sinusoidal density", particularly the abstract.

Mention that we need the sinusoidal case to test the results to the extreme and be able to extrapolate the delta values to simpler realistic cases.


Refactor most of the Dashboard firestore user data converter to user-data.ts

Summary
There are way too many things happening in Dashboard.vue right now, which makes it hard to reason about what's the data flow. This diff factors out most of the data converters into user-data.ts, so it can results in a shorter Dashboard.vue.
Test Plan
Data still loads and displays correctly:

Definitely a good call on factoring those functions out! I am noticing though that there is a console error preventing new courses from being added because createCourse was moved... could you please fix that?
Otherwise it looks good, just make sure to mention this change to all the devs during standup!

Fixed by temporarily add it back. It should eventually be changed to use emit, but I'm not in the mood of fixing it in this diff. I will probably create a another diff in the future that fixes all of this kind of bad encapsulation code.


expose crypto/tls.alert type in API

In order to provide nicer feedback to users, the Let's Encrypt boulder project attempts to determine if a TLS error was the cause for the HTTP domain validation failure. However, it has to do it in a hack-y way because the crypto/tls.alert error type is not exposed in the API.
Currently, that hack-y way is:
} else if fmt.Sprintf("%T", netErr.Err) == "tls.alert" {

as seen in the validation authority code.

You did state the problem but you jumped to the solution pretty quickly (exporting a type). Let's try to understand the problem more and think about all possible solutions before doing anything here.

Open to suggestions!

You only call parseHTTPConnError twice in the boulder codebase.

Your first use is after a call to *http.Client.Do, where you create the http.Client on the line immediately before the call, and the http.Transport right above it. But http.Transport has a DialTLS hook you can use. Implement that hook (with a normal tcp.Dial followed by a tls.Conn+tls.Handshake (without VerifyHostname) and return any specific error value you want for TLS errors.

Your second call is after tls.DialWithDialer. But you don't need to do that all in one step. Dial first with your Dialer, and then give the connection to the crypto/tls package after you have it (with tls.Conn+tls.Handshake again), and then you know which step failed.

Both of your problems are because you call some convenience method that does N things and then try to infer from the error value which step of N failed, instead of just doing N things in serial.
Yes, it's possible we could make the error values from those convenience methods better typed, but it's probably not worth the API pollution & mental overhead for readers new to the packages.


Make kairos-sysext be generic enough to include on all flavors

It will not install the systemd-sysext package if the binary is not there

Test ongonig for this: https://github.com/kairos-io/kairos/pull/1904

Expected: On systems that do not support systemd-sysext becuase they are older, its not installed, on systems that support it, it is.
Outcome of the test:
on ubuntu-20-lts (no sysext available): +base-image | dracut: dracut module 'kairos-sysext' will not be installed, because command 'systemd-sysext' could not be found!
on ubuntu-22-lts (no sysext available): systemd-sysext module was NOT added to initramfs. Silent skip due to the comments in the code, mainly it has the binary but not the dracut module, so we add extra checks and fail in a different place.
on opensuse-tumbleweed (sysext available),  systemd-sysext module was added to initramfs
on opensuse-leap (sysext available),  systemd-sysext module was added to initramfs
on ubuntu (sysext available),  systemd-sysext module was added to initramfs
on almalinux (sysext available),  systemd-sysext module was added to initramfs
on fedora (sysext available),  systemd-sysext module was added to initramfs
on debian (sysext available),  systemd-sysext module was added to initramfs
on rockylinux (sysext available),  systemd-sysext module was added to initramfs
So as a side effect of this generic approach of adding if its there, we GAIN sysext support in all newer distros :D


Period budget

This intends to implement the ticket 'Inline action to transfer DAO period budget for DAO budget throttling'
Feedback much appreciated!

Really no need to apologize. I know how the creative process works. Happy to change even more stuff around if you get more good ideas! 👍


add python 3.9 support

Codecov Report

Merging #5 (1851057) into master (e91bd14) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master        #5   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            4         4
  Lines           60        60
  Branches        10        10
=========================================
  Hits            60        60

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e91bd14...1851057. Read the comment docs.


Problem with the homography data in calibration json

I am working on the 1_field_calibration_ccbv.json to extract frames from the video using the corresponding video.ini file under the assumption that a HQ video is 50 fps downsampled to 2 fps.
Using the start time second present in .ini file & count of frames present, I am mapping the homography matrix to the corresponding frame. However, it seems to have homography data present for replay frames with high confidence score.
Attached is an example,

is a frame present at 0:09:41 (calculated using the above assumption) has following data present in calibration.json
"homography": [
3334.76123046875,
-1385.3936767578125,
-23787.22265625,
-74.32776641845703,
260.42376708984375,
31227.6171875,
-0.8536908626556396,
-1.3100050687789917,
85.80413818359375
],
"conf": 0.931109577411863
and I am using the Task1-ActionSpotting/Calibration_GCN/src/dataset.py (https://github.com/SilvioGiancola/SoccerNetv2-DevKit/blob/deda7eaae95de2637d43730a7708fc8199245ad9/Task1-ActionSpotting/Calibration_GCN/src/dataset.py) file
& the following code to draw the calibration cone :
`                # Visualization
#for i, frame in enumerate(representation_half1):
#    cv2.imwrite("outputs/test/"+str(i)+".png", frame)
            representation_half2 = np.zeros((feat_half2.shape[0], self.representation_height, self.representation_width, self.representation_channel), dtype=np.uint8)
            bbox_predictions = bbox_half2
            ratio_width = bbox_predictions["size"][2]/self.representation_width
            ratio_height = bbox_predictions["size"][1]/self.representation_height
            for i, bbox in enumerate(bbox_predictions["predictions"][0:feat_half2.shape[0]]):
                if self.args.calibration:
                    confidence = calibration_half2["predictions"][i][0]["confidence"]
                    if confidence < self.calibration_threshold:
                        continue
                    homography = calibration_half2["predictions"][i][0]["homography"]
                    homography = np.reshape(homography, (3,3))
                    homography = homography/homography[2,2]
                    homography = np.linalg.inv(homography)
                    # Draw the field lines
                    if self.args.calibration_field:
                        representation_half2[i,int(0.025*self.representation_height): int(0.025*self.representation_height) + self.radar_image.shape[0], int(0.025*self.representation_width): int(0.025*self.representation_width) + self.radar_image.shape[1] ] =self.radar_image

                    # Draw the calibration cones
                    if self.args.calibration_cone:
                        frame_top_left_projected = unproject_image_point(homography, np.array([0,0,1]))
                        frame_top_right_projected = unproject_image_point(homography, np.array([calibration_half2["size"][2],0,1]))
                        frame_bottom_left_projected = unproject_image_point(homography, np.array([0,calibration_half2["size"][1],1]))
                        frame_bottom_right_projected = unproject_image_point(homography, np.array([calibration_half2["size"][2],calibration_half2["size"][1],1]))
                        frame_top_left_radar = meter2radar(frame_top_left_projected, self.dim_terrain, (self.representation_height, self.representation_width, self.representation_channel))
                        frame_top_right_radar = meter2radar(frame_top_right_projected, self.dim_terrain, (self.representation_height, self.representation_width, self.representation_channel))
                        frame_bottom_left_radar = meter2radar(frame_bottom_left_projected, self.dim_terrain, (self.representation_height, self.representation_width, self.representation_channel))
                        frame_bottom_right_radar = meter2radar(frame_bottom_right_projected, self.dim_terrain, (self.representation_height, self.representation_width, self.representation_channel))

                        pts = np.array([frame_top_left_radar[0:2], frame_top_right_radar[0:2], frame_bottom_right_radar[0:2], frame_bottom_left_radar[0:2]], np.int32)

                        representation_half2[i] = cv2.polylines(representation_half2[i], [pts], True, (255,255,255), 1)`

It seems that either the homography data present for this frame is incorrect or it's confidence value, or is there a problem with my mapping logic of homography data to the field_calibration_ccbv.json?

Hi @PranshuAgrawal86,
If the problem only occurs for some frames, but that most of them seem aligned with the calibration data, then it is that you probably have a correct alignment. This issue might simply come from the calibration predicting network (CCBV) that we used to generate these calibration data (just a reminder that the calibration data dos not correspond to manually annotated ground-truths! ). Of course, since the calibration network is not perfect it can make mistakes sometimes.
Otherwise, if you see a misalignment for most frames, then I would suggest you take a look at the function extracting the frames for the feature extraction (https://github.com/SilvioGiancola/SoccerNetv2-DevKit/blob/0119a163a10d8cc7d3c1c5f76c5ef976542f11d8/Features/VideoFeatureExtractor.py#L74). If you use the FrameCV function from the devkit with a 25fps video, and setting the FPS parameter to 2, you should get the exact frames that you need.
Another option is to do it manually in a loop, still from a 25fps video. Check out this code:
import cv2
import numpy as np
import json
import os
import sys

def unproject_image_point(homography, point2D):
	pitchpoint = homography @ point2D
	pitchpoint = pitchpoint/pitchpoint[2]
	return pitchpoint

def meter2radar(dim, point2D):
	return np.array([int(point2D[0] + dim[1]/2), int(point2D[1] + dim[0]/2), 1])

if __name__=="__main__":

	video_path = sys.argv[1]
	features_path = sys.argv[2]
	predictions_path = sys.argv[3]
	calibration_path = sys.argv[4]

	# Read the video
	video = cv2.VideoCapture(video_path)

	# Read the features
	features = np.load(features_path)
	print("Shape of the features:", features.shape)

	# Read the predictions
	file = open(predictions_path,'r')
	predictions = json.load(file)
	file.close()
	print("number of predictions: ", len(predictions["predictions"]))
	print("shape of the prediction video: ", predictions["size"])

	# Read the calibration
	file_c = open(calibration_path,'r')
	calibrations = json.load(file_c)
	file_c.close()
	print("number of calibrations: ", len(calibrations["predictions"]))
	print("shape of the calibration video: ", calibrations["size"])

	ret, frame = video.read()
	index = 0
	prediction_index = 0
	correct_indexes = np.ceil(np.arange(len(predictions["predictions"])+1)*12.5).astype(int)

	dim_terrain = (68,105,3)
	size_radar_point = 2

	while ret:

		index += 1

		if not index in correct_indexes:

			ret, frame = video.read()
			continue

		# Retrieve the correct prediction
		bboxes = predictions["predictions"][prediction_index]["bboxes"]
		colors = predictions["predictions"][prediction_index]["colors"]
		fields= predictions["predictions"][prediction_index]["onfield"]

		homography = calibrations["predictions"][prediction_index][0]["homography"]
		homography = np.reshape(homography, (3,3))
		homography = homography/homography[2,2]
		homography = np.linalg.inv(homography)
		confidence = calibrations["predictions"][prediction_index][0]["confidence"]

		original_width = predictions["size"][2]
		original_height = predictions["size"][1]
		new_width = frame.shape[1]
		new_height = frame.shape[0]

		radar = cv2.imread("outputs/radar.png")

		frame_top_left_projected = unproject_image_point(homography, np.array([0,0,1]))
		frame_top_right_projected = unproject_image_point(homography, np.array([original_width,0,1]))
		frame_bottom_left_projected = unproject_image_point(homography, np.array([0,original_height,1]))
		frame_bottom_right_projected = unproject_image_point(homography, np.array([original_width,original_height,1]))
		frame_top_left_radar = meter2radar(dim_terrain, frame_top_left_projected)
		frame_top_right_radar = meter2radar(dim_terrain, frame_top_right_projected)
		frame_bottom_left_radar = meter2radar(dim_terrain, frame_bottom_left_projected)
		frame_bottom_right_radar = meter2radar(dim_terrain, frame_bottom_right_projected)

		pts = np.array([frame_top_left_radar[0:2], frame_top_right_radar[0:2], frame_bottom_right_radar[0:2], frame_bottom_left_radar[0:2]], np.int32)

		radar = cv2.polylines(radar, [pts],True, (int(255*confidence), int(255*confidence), int(255*confidence)), 1)

		for box, color, field in zip(bboxes, colors, fields):

			if field == 0:
				continue

			x_top_left = int(box[0]*new_width/original_width)
			x_bottom_right = int(box[2]*new_width/original_width)
			y_top_left = int(box[1]*new_height/original_height)
			y_bottom_right = int(box[3]*new_height/original_height)

			projection_point = np.array([int((box[0]+box[2])/2), box[3], 1])
			projected_point = unproject_image_point(homography, projection_point)
			radar_point = meter2radar(dim_terrain, projected_point)

			frame = cv2.rectangle(frame, (x_top_left,y_top_left), (x_bottom_right,y_bottom_right), (color[0],color[1],color[2]),2)
			radar = cv2.rectangle(radar, (radar_point[0]-size_radar_point//2,radar_point[1]-size_radar_point//2), (radar_point[0]+size_radar_point//2,radar_point[1]+size_radar_point//2), (color[0],color[1],color[2]),-1)

		frame[0:radar.shape[0], frame.shape[1]//2-radar.shape[1]//2:frame.shape[1]//2+radar.shape[1]//2+1] = radar
		cv2.imwrite("check_imgs/"+str(prediction_index)+".png", frame)

		ret, frame = video.read()
		prediction_index +=1

More precisely, the correct indexes to take from the 25fps videos are given by:
correct_indexes = np.ceil(np.arange(len(predictions["predictions"])+1)*12.5).astype(int) with the first frame of the 25fps video corresponding to the index 1, and not 0 (sorry about that, I know it's not practical) !!!
Also, len(predictions["predictions"]) should simply be the total number of frames at 2fps.
Hope this helps, don't hesitate to get back to me if you run into any issue.

Hi,
Thank you for sharing the response.
We ran the script you posted on a low quality 25 fps video to visualize homography data using value of prediction_index = 0 and observed that homography looks misaligned with frames, in order to correct indexes, we noticed using minus -1 as prediction index results looks better with exception of first frame.
(For your reference, attached here are the results & the corresponding calibration.json used to read homography).
Video tested on : /england_epl/2016-2017/2016-08-14 - 18-00 Arsenal 3 - 4 Liverpool/1.mkv
Calibration.json used - /england_epl/2016-2017/2016-08-14 - 18-00 Arsenal 3 - 4 Liverpool/1_field_calibration_ccbv.json
Result 1 : Visualization using prediction index = 0

Result 2 : Visualization using prediction index = -1

Does these results seem to be accurate? or a misalignment still persists in these frames?
Also, tried using FrameCV to extract frames which results in the same frames as this script.
Let us know your thoughts.

Hi @PranshuAgrawal86,
I'm sorry but it is a bit difficult to say for sure that they are perfectly aligned by looking at the frames you sent.
Anyway, FrameCV is the correct way to go to extract the frames from a 25fps video and you should not have a misalignment with this technique. It should also be aligned with the ResNET features provided that way.
To make sure that your alignment is correct, try looking at a lot of camera changes, if you see that a calibration from the previous camera is projected to the next one, then it means that there is a temporal misalignment. Of course, the predicting network can make mistakes, but it can be obvious that the radar printed corresponds to the previous camera, for instance if a lot of players are predicted on a close-up shot.

Hi @PranshuAgrawal86
I believe this issue is linked to https://github.com/SilvioGiancola/SoccerNetv2-DevKit/issues/16 .
Note that any field calibration method has his flaw, CCBV is no exception. You can imagine that when there is no line visible in the frame, the estimation can go terribly wrong. AFAIK, CCBV does no check for temporal consistency between frames.
Feel free to check the code of CCBV from EVS Broadcast for further analysis: https://github.com/evs-broadcast/CCBV .
Cheers


VS Code is showing suggestion even if they are not related to words and apparently also applying them after entering shift + 9?

I am trying to learn gulp and so I am using rename() method but VS Code is showing those unrelated suggestion as shown in the image and as I am typing shift + 9 to make brackets for the method but instead of brackets its replacing what I am writing with the first suggestion and so it is changing rename to requestAnimationFrame. Why this behavior is happening and how can I fix this ?

( is treated as commit character for method suggestion. Typing it will accept the current suggestion
Press escape to cancel out of the current suggestion before pressing ( or disable commit characters entirely by setting "editor.acceptSuggestionOnCommitCharacter": false

thanks a lot, it works :D


Sims and some minor refactors

All commits should be individually tested to make sure they do not break any functions. Goals of this are primarily cleanup + refactors

Because i suck at git i'm gonna keep the color changes in this PR, but going forwards i'll try to do more PRs instead of just having one

Summary of changes and @TODO:

Combined FMS/DS changes into one commit for clarity
Removed simulation stuff (added it to gitignore)

Todo:

Change fundamental backbone of leaveline to run in meters (tune accordingly)
Figure out how to streamline controller configuration
Test all changes thoroughly!

Closed, see #2, #3, #4, and #5


FlagRemoveUnnecessaryHostDots doesn't remove extra dots between parts

It seems like FlagRemoveUnnecessaryHostDots only removes extra leading and trailing dots in the hostname part of the URL. For instance a URL like "http://host..com" doesn't get the extra dots removed.

Just looked at the code and saw this comment:
// Trim the leading and trailing dots
So I guess that's the expectation given that comment.

I think that's a failure to check, adding a support for it would be welcome.

Ran into this again...I'll be posting a PR with my fix, but I've never posted a PR to GitHub, so hopefully I'm doing it correctly.

I posted a PR for this issue, but seems like this project isn't getting much love anymore. :(

Ah. sorry, I've been busy lately. I'll take a look this weekend!


Add mlbox-example SciML benchmark

Assigned to vibhatha
https://github.com/mlperf/box_examples

Hi Subin et al,
Can you please clarify what this issue is supposed to be about?
Best,
Peter
On Fri, Oct 2, 2020 at 9:38 AM Subin Modeel<EMAIL_ADDRESS>wrote:

Assigned #112 https://github.com/mlperf/mlbox/issues/112 to
@petermattson https://github.com/petermattson.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/mlperf/mlbox/issues/112#event-3834778308, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AIIVUHNNYGDRNZDWQ46D3YTSIX6W7ANCNFSM4SB46AOA
.

@petermattson This issue was assigned to a grad student who is creating mlbox for a SciML workload.
The example would be pushed to mlperf/box_examples repo.

@sub-mod I added a draft PR to https://github.com/mlperf/box_examples/pull/3


📝 (Contributing) Fixing a reference to SQL Ops Studio

:memo: (Contributing) Fixing a reference to SQL ops studio to match new branding of Azure Data Studio.

@kstolte thanks for fixing.


fix(headers) admin api and proxy server headers adjustment

Summary
This commit contains following things:

it removes Server header setting from kong.response.exit
admin api now sets Server header according to conf.headers on header_filter
proxy does not add Server header in case Via header contains the same value and request is short-circuited (this is for aws-lambda, azure-functions etc. plugins that kinda proxy, but do not use the proxy module, and skip balancer)

Issues Resolved
Fix #6367

to whom do need to assign pr?

to whom do need to assign pr?

Hi, did you have time to try this PR? Does it fix your issue?

to whom do need to assign pr?

Hi, @xichengliudui did you have time to try this PR?


[Improvement] [20] Exercise & Training Program edit on other user's items

[x] Exercise list allows the edit of not owned exercise

[x] Training Program list allows the edit of not owned Training Program

The problem was solved after intorduction of the copy option on Exercise 2da515cbbb4b1573f6510fd8cc4f34ddaf232684 and on Training Program f586c96c17937e772edff057a9b74d2b5dbdb57a


onUpdateVisitedHistory not calling every time when navigation state changes

**Flutter version:1.17.1
**Plugin version:^3.3.0+3
**iOS version:13.3.1
**Xcode version:11.4
**Device information:*iPhone 6 *
I have updated inAppWebView plugin from 2.1.0+1 to 3.3.0+3, I have used onNavigationStateChange method from previous version, In current version this method is removed so I have used onUpdateVisitedHistory method which is called when the navigation state of the InAppWebView changes as per documentation which is same as onNavigationStateChange but onUpdateVisitedHistory is not calling every time. Any solution to call method everytime when navigation state of the InAppWebView changes

Could you make an example, please?


Development v0.1.1

Creating pull request to test deployment of v0.1.1.

Ready to test next deployment.


Controller support

Hi,
First I wanted to thank you for your awesome mod, a real bag of tricks :)
I've done my new dlc run with it (only to respec 1 character and few quality of life option) and now that I am level 5/6 the spell selection is broken.
I know it's weird but no problem without it with a non moded save and it can be reproduced easilly.
The problem is I have to restart the whole dlc, so if you have any idea for a easy fix, you'll be my hero
Thank you very much

“Spell selection is broken” isn’t very helpful. Screenshots, saves, etc.
We are Warriors here, not Wizards

Not bugging at all but we need a save as it’s very time consuming to create one.

Any chances you can share a save? I got a controller ready to test?

Sure, sorry for the delay, you can find it here,

I passed this to TA as it will also happen once they release the DLC. Meanwhile we will have to wait.


Windows Support (WTF?!)

Current coverage is 82.90%

Merging #109 into develop will increase coverage by +0.01% as of dba376e

@@            develop   #109   diff @@
======================================
  Files            58     58
  Stmts          1286   1287     +1
  Branches          0      0
  Methods
======================================
+ Hit            1066   1067     +1
  Partial           0      0
  Missed          220    220

Review entire Coverage Diff as of dba376e

Uncovered Suggestions

+0.70% via ...c/formatter/json.cpp#455...463
+0.62% via ...c/formatter/json.cpp#422...429
+0.54% via ...detail/sink/file.hpp#32...38
See 7 more...

Powered by Codecov. Updated on successful CI builds.

:umbrella: The latest upstream changes (presumably a27d699) made this pull request unmergeable. Please resolve the merge conflicts.

@3Hren Any update on windows support?

@cobexer Windows is not is the list of target platforms ATM. However, it's not so hard to fix that as I thought.
If you submit a PR, I'll be glad to accept it

Hi, is Windows not a supported platform by Blackhole?


[SPARK-20796] the location of start-master.sh in spark-standalone.md is wrong

https://issues.apache.org/jira/browse/SPARK-20796
the location of start-master.sh in spark-standalone.md should be "sbin/start-master.sh" rather than "bin/start-master.sh".

@srowen
I will try my best to slove this type of problem.But I only found one this time.Please help me to merge it.Thanks.

Can one of the admins verify this patch?

Test build #3722 has started for PR 18027 at commit 14f0ba9.

Test build #3722 has finished for PR 18027 at commit 14f0ba9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

merged to master/2.2/2.1


RequirementMachine: Reduction order on symbols should compare associated type name before protocols

The canonical order on associated types compares the name before the
protocol, so for example T.[P2:A] < T.[P1:B]. Make sure the reduction
order does the same so that we correctly compute canonical types in
this case.

@swift-ci Please smoke test


Cypress Testing v12.8.1 - Trace Analytics (Services & Traces) fixes

Description
[Describe what this change achieves]
Fixes for cypress testing for Trace Analytics Services & Traces
Added assertion checks to allow page to load in place of waits.
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

All 20 test passing.

All 10 test passing.


build: prebuilt fixups

Don't omit frame pointers
Compile symbols
Compile optimized version of boringssl (oops)

Fixes https://github.com/lyft/envoy/issues/898

@htuch @PiotrSikora

@mattklein123 maybe we should put all those common CFLAGS and CXXFLAGS in ci/build_container/Makefile instead?

@mattklein123 btw: for the CMake, there is also RelWithDebInfo (-O2 -g -DNDEBUG), which we might want to use instead of Release (-O3 -DNDEBUG) to keep the flags consistent across all dependencies.
FWIW, that's why I prefer "Bazel-all" approach to dependencies ;)

maybe we should put all those common CFLAGS and CXXFLAGS in ci/build_container/Makefile instead

Yeah I thought about this, I guess there is no harm. Will do that.

btw: for the CMake, there is also RelWithDebInfo (-O2 -g -DNDEBUG), which we might want to use instead of Release (-O3 -DNDEBUG) to keep the flags consistent across all dependencies.

OK will switch (though FYI it looks to be already setting -ggdb).

@mattklein123 yeah, I mentioned RelWithDebInfo mostly for context, it's fine if you want to leave Release instead.

@PiotrSikora updated

At some point, we can can consider also passing down these options from repository.bzl.  This will allow us to have the external deps reflect the intended built options. This would be useful when we eventually want to support MSAN, since the external deps also need to be built with MSAN (as well as lib[std]c++, but that's another story).

@PiotrSikora @htuch updated


Problem retrieving prestige level

@SunDwarf
Ran into an issue retrieving prestige level from 2 people. (haven't tested others)
Player 1 Xuja#11513
https://owapi.net/api/v2/u/Xuja-11513/stats/general
https://playoverwatch.com/en-us/career/pc/us/Xuja-11513
Player 2 Lexonic#1601
https://owapi.net/api/v2/u/Lexonic-1601/stats/general
https://playoverwatch.com/en-us/career/pc/us/Lexonic-1601
Each player has 1 prestige level but the API is returning null for each. Any ideas?
Thanks!

Their rank (028) appears to be new.
I'll fix/add this as another one for 1 Soon™.

Should be fixed.

I do believe it changed...again. What the hell is even happening with Blizzard.
https://blzgdapipro-a.akamaihd.net/game/playerlevelrewards/0x0250000000000924_Rank.png

As I mentioned the star image is linked to the border image (same ids) and
you get a new border every 10 levels, so in order to determine the rank you
will need all 10 ids that correlate to the rank for each border

Re-opened as there's lots of borders to get.

I wrote a script to fetch the top ids from Master Overwatch (sorted by level) but it only returns like the top 500 users which are all high levels, no way to get lower levels from MO

Using some serious sourcery and scripting, I'm fairly certain these are accurate and should be all ranks from 0 to 5, rank 6 uses a silver portrait
"0x0250000000000918": 0
"0x0250000000000919": 0
"0x025000000000091A": 0
"0x025000000000091B": 0
"0x025000000000091C": 0
"0x025000000000091D": 0
"0x025000000000091E": 0
"0x025000000000091F": 0
"0x0250000000000920": 0
"0x0250000000000921": 0
"0x0250000000000922": 1
"0x0250000000000924": 1
"0x0250000000000925": 1
"0x0250000000000926": 1
"0x025000000000094C": 1
"0x0250000000000927": 1
"0x0250000000000928": 1
"0x0250000000000929": 1
"0x025000000000092B": 1
"0x0250000000000950": 1
"0x025000000000092A": 2
"0x025000000000092C": 2
"0x0250000000000937": 2
"0x025000000000093B": 2
"0x0250000000000933": 2
"0x0250000000000923": 2
"0x0250000000000944": 2
"0x0250000000000948": 2
"0x025000000000093F": 2
"0x0250000000000951": 2
"0x025000000000092D": 3
"0x0250000000000930": 3
"0x0250000000000934": 3
"0x0250000000000938": 3
"0x0250000000000940": 3
"0x0250000000000949": 3
"0x0250000000000952": 3
"0x025000000000094D": 3
"0x0250000000000945": 3
"0x025000000000093C": 3
"0x025000000000092E": 4
"0x0250000000000931": 4
"0x0250000000000935": 4
"0x025000000000093D": 4
"0x0250000000000946": 4
"0x025000000000094A": 4
"0x0250000000000953": 4
"0x025000000000094E": 4
"0x0250000000000939": 4
"0x0250000000000941": 4
"0x025000000000092F": 5
"0x0250000000000932": 5
"0x025000000000093E": 5
"0x0250000000000936": 5
"0x025000000000093A": 5
"0x0250000000000942": 5
"0x0250000000000947": 5
"0x025000000000094F": 5
"0x025000000000094B": 5
"0x0250000000000954": 5

#29 should fix this, hopefully, thanks to @Js41637


Quickstart issues

Just started going through the Quickstart page on a fresh setup and encountering some issues.
While going through the CLI setup on https://docs.hatchet.run/getting-started/setup/quickstart/#creating-your-first-module, I made a mistake when running the config set-address command and wrote https instead of http. This worked without any errors, so perhaps some validation would be good there. I know that it will validate once you run hatchet init, but maybe an earlier check is worth it.

Another issue I encountered is that the Team I set up during the registration phase wasn't actually set up properly. I didn't notice that and ran through the Quickstart commands (with the incorrect https address):
cd smoke-test
hatchet config set-address https://localhost:8080
hatchet config set-api-token $token

The return of the set-api-token command did not include a default team (I only noticed later):
$ hatchet config set-api-token '$token'
Set the current api token successfully
Set the current organization as 6145face-98c9-4566-b0a6-582caf6cfe69

When I then run hatchet init it results in:
$ hatchet init
team id must be set: run [hatchet config set-team]

Running hatchet config set-team then results in an index out of range panic.
$ hatchet config set-team
panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]:
github.com/hatchet-dev/hatchet/cmd/hatchet-cli/cli.glob..func5(0x2154c60?, {0x22d8920?, 0x0?, 0x0?})
	/home/runner/work/hatchet/hatchet/cmd/hatchet-cli/cli/config.go:68 +0xda
github.com/spf13/cobra.(*Command).execute(0x2154c60, {0x22d8920, 0x0, 0x0})
	/home/runner/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:920 +0x847
github.com/spf13/cobra.(*Command).ExecuteC(0x2153840)
	/home/runner/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:1044 +0x3bd
github.com/spf13/cobra.(*Command).Execute(...)
	/home/runner/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:968
github.com/hatchet-dev/hatchet/cmd/hatchet-cli/cli.Execute()
	/home/runner/work/hatchet/hatchet/cmd/hatchet-cli/cli/root.go:38 +0x7f
main.main()
	/home/runner/work/hatchet/hatchet/cmd/hatchet-cli/main.go:8 +0x17

When I later to go check on my teams in the UI it's empty, despite having created an initial team in the registering phase. So perhaps there's an issue creating the initial team?
After creating a team on the http://localhost:8080/organization/teams page, it no longer paniced when I ran hatchet init. It timed out since I had incorrectly configured the hatchet URL, but after changing the URL it worked fine.
It was hard to figure out what I needed to do to fix it, so I ended up deleting the ~/.hatchet/hatchet.yaml file and start over.
It looks like if I just run hatchet config set-api-token again it will fetch the team correctly the second time, but it uses the Hatchet URL from the JWT token, so even if the URL is incorrect, you won't know because the hatchet config set-api-token successfully fetches your Org and Team.
The URL in the token should either be used to populate the URL in the ~/.hatchet/hatchet.yaml file or it should at least throw a warning if it detects that they differ. Maybe use the ~/.hatchet/hatchet.yaml URL when looking up Org/Team and ignore the JWT URL?

Thanks for the report @leosunmo! Working through these issues this week, will keep you updated. Some comments:

Running hatchet config set-team then results in an index out of range panic.

The hatchet config set-team command should require 1 argument, with the team ID. I'll push a quick PR to enforce this.

When I later to go check on my teams in the UI it's empty, despite having created an initial team in the registering phase. So perhaps there's an issue creating the initial team?

This might be because Temporal can't be reached, which can leave the team in a bit of a dirty state, as a new namespace in Temporal is created for the team.

It looks like if I just run hatchet config set-api-token again it will fetch the team correctly the second time, but it uses the Hatchet URL from the JWT token, so even if the URL is incorrect, you won't know because the hatchet config set-api-token successfully fetches your Org and Team.

hatchet config set-api-token should also require an argument, so I'm not quite sure what's going on here.  With regards to using the URL from the JWT token - that definitely isn't expected behavior, so I'll take a closer look.


update docs for upgrade

Description

Release required?

[x] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

:tada: This PR is included in version 1.29.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


how to use the server part of zardak:soap

I tried this module and was able to get values out of a wsdl end point by calling the url. Next i tried the soap server part but did not know how to proceed.
I was trying to host a wsdl but am not sure how to use it.
I have a soap xml file in my server which i am trying to expose as a wsdl using zardak soap.
I am not sure what URL to use to get the book author. I know i have to put the book id and get the book author
My code on server start up is
        var service = {
           Catalog: {
             3000: {   // i don't know what MyPort is. I just added the default port my application is on.

                GetAuthor: function(args) { // GetAuthor is MyOperation
                  if(!args.Request) {
                  throw { Fault: {
                        Code: {
                          Value: "soap:Sender",
                          Subcode: { value: "rpc:BadArguments" }
                        },
                         Reason: { Text: "Processing Error" }
                     } };
                  }
                    console.log("asdf"+ args.Request);
                  return { Response: args.Request };  // will this give my book author value?
                }

              }
              }
         };

          var wsdl = Assets.getText('wsdl.xml');  //this is my soap xml file
          var soapServer = Soap.listen('/soap', service, wsdl);

Refer to this example
https://github.com/zardak/meteor-soap/blob/master/tests/data.js#L12-L79
Your service definition has to correspond to WSDL. The data-processing part is totally unrelated to this package, better use stackoverflow for questions.


fix(ci): fix standalone tests startup

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
They need to wait for the minio service to start, before they can run. Otherwise the meta node just panics and we cannot start.
Honestly, this is a quick fix, rather than a proper fix. We should do #16601, but I don't have time recently..

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wcy-fdu we need a proper fix to allow meta starts before minio in standalone mode. Please help to fix it.

Can we merge this in first? Let the main-cron pass.

I'm trying to decouple minio and standalone startup, but I found it a bit difficult. If you have any ideas, please let me know.

I'm trying to decouple minio and standalone startup, but I found it a bit difficult. If you have any ideas, please let me know.

https://github.com/risingwavelabs/risingwave/issues/16601#issuecomment-2227935760


Handle and report errors of key source, do not write out key if keyCommand failed

So I thought that it might be nice to log out a proper error if keyCommand fails. I also made it so the output is buffered. This way, the key is not partially written if the keyCommand fails in the middle. So there is no possibility to clobber an existing key with a malformed one.
Example output (non-existent keyFile):

Example output (keyCommand = ["date" "-Ins" "foobar"] (extraneous argument to the date command)):

If stderr contains multiple lines, it does not print out nicely, especially with the progress bar mode. Not sure how to deal with that.

Neat, thanks! It would be nice to add the error logs to the Host's logs as well, but I can take care of that in a bit.


File structured

###Fixes
Fixes Issue #13
###Description
I restructured the website's file organization, housing HTML files in "Html-files," CSS files in "Css-Files," and JavaScript files in "Js-Files" Additionally, I updated all relative paths within the files for smoother navigation. This optimization enhances efficiency and facilitates future scalability.
###Checks
I have checked locally , all the relative paths which were there before are working same.

@nandu-99 Thanks for your contributtion

Wait I will take a look into it


WIP: Class transform with property initializer

I added a new codemod file (property-initializer.js) but I wasn't sure if it'd be better to overwrite the existing class one instead -- feel free to let me know if you want me to change it. I think the diff would be easier to read in that case.
A few steps left:

[x] no --no-super-class option

[x] Fix readme

[x] Support react-addons-pure-render-mixin
[x] Fix flow annotations (the return type of arrow functions is missing for now)

See benjamn/recast#289

[x] Remove var ReactComponentWithPureRenderMixin = require('ReactComponentWithPureRenderMixin') when transformation happens

[x] Check the scope before removing it (for cases where there are multiple components in a single file)

Update: discussed with @spicyj in person and here are the changes/required steps to finish before shipping this:

[ ] Transform propTypes to Flow annotations (props: ...)

We want to keep both propTypes and flow annotations so we only makes it stricter
also transforms properties like count: (12: number), to count: number = 12;

[x] Support primitives as properties
[x] Do not sort properties/methods so that the diff stays clean
[x] Transform every method except lifecycle methods to arrow functions to make sure we don't break anything

[ ] Introduce a lint rule after this to prevent from over-binding

[x] Drop context and/or props in constructor(props, context) whenever possible
[ ] Add and fix no-use-before-define linter rule

Updated to change the existing class codemod instead of creating a new one.

@keyanzhang Is that the best idea? The benefit I see to keeping the existing class codemod is that it will better support es6 users who aren't using babel. Class properties and initializers are a stage 1 proposal for es7.

More food for thought -- if you want to combine them, could the stage-1 items such as property initializers be optional?

@nathanmarks Yeah, I think we could keep the both or them. Updating the existing one makes it much easier to review the diff, but I can switch to create new files later if necessary.

For us, I think it makes the most sense to keep the version we're planning to use at Facebook in this repo. If people want the older version without property initializers it's easy to check out an old version – but I don't anticipate that many people will want this codemod script and convert all of the components until property initializers are more stable.

@gaearon: I added a temporary shrinkwrap file to pin recast to my fork and the tests pass locally. As soon as benjamn/recast#289 gets merged it will disappear 😃

👍 I’ll review later today, thank you.

Do we need the --no-super-class option?

No, not anymore. Component base class is required in 15.0+.

Remove var ReactComponentWithPureRenderMixin = require('ReactComponentWithPureRenderMixin') when transformation happens

I think we might want to also support removing import PureRenderMixin from 'react-addons-pure-render-mixin' and var PureRenderMixin = require('react-addons-pure-render-mixin');.

Please correct me if I’m wrong but I think this would be broken:
import React from 'react';

const App = React.createClass({
  getInitialState() {
    const state = {
      whatever: this.context.whatever
    }
    return state
  },
  render() {
    return

  }
})
App.contextTypes = {
  whatever: React.PropTypes.object
}

It becomes
import React from 'react';

class App extends React.Component {
  constructor() {
    super();
    const state = {
      whatever: this.context.whatever
    }
    this.state = state;
  }

  render() {
    return

  }
}

App.contextTypes = {
  whatever: React.PropTypes.object
}

but this.context is not available in the constructor because we haven’t passed it to super, so this.context.whatever would throw.

Here is another example that I think would be broken by this:
import React from 'react';

const App = React.createClass({
  getInitialState() {
    const state = this.calculateState()
    return state
  },
  calculateState() {
    return { color: this.props.color }
  },
  render() {
    return

  }
})

It becomes
import React from 'react';

class App extends React.Component {
  constructor() {
    super();
    const state = this.calculateState()
    this.state = state;
  }

  calculateState = () => {
    return { color: this.props.color }
  };

  render() {
    return

  }
}

but this.props is not yet available by the time calculateState is called.
It seems like if getInitialState exists and its body contains references to this, it is unsafe to just call super() and you have to call super(props, context) instead.

Ahhhhh, I didn't know that you can assign static properties outside of createClass (like App.contextTypes = ...)!
Yeah you are right. Actually I talked to @spicyj yesterday about this -- I'll change the logic to to search for this.context in getInitialState instead. To quote Ben, "It's only strictly necessary if this.context is accessed in the constructor, but it seems sensible to do it whenever contextTypes is defined because we assign .context from outside regardless of what you pass to super: https://github.com/facebook/react/blob/master/src/renderers/shared/stack/reconciler/ReactCompositeComponent.js#L246 right after instantiation." But since it's possible to do an assignment after creating a class I think it makes more sense to just scan getInitialState.

I'll change the logic to to search for this.context in getInitialState instead.

getInitialState may call another function which may use this.context. So I think if getInitialState uses this (e.g. to call that function), it is already unsafe.

Also didn't know that would work but I guess I'm not surprised. :)
I don't want to add context to the super call except when needed because most people don't know about context and shouldn't have to think about it. If we're concerned about this case let's only add the context arg if "this" is referenced alone or in a direct method call this.x() -- but this.props or this.props.foo() should not cause a context arg to be added.
You could also grep to see how often that pattern comes up. Guessing we only have a dozen or two cases of ".contextTypes =" and maybe all are React.Component. So probably also okay to punt on it.

I don't want to add context to the super call except when needed because most people don't know about context and shouldn't have to think about it.

I agree but most components would not have constructors anyway. They are only generated when you’re doing something non-trivial in getInitialState.

If we're concerned about this case let's only add the context arg if "this" is referenced alone or in a direct method call this.x() -- but this.props or this.props.foo() should not cause a context arg to be added.

This sounds good. 👍

this.calculateState(this.props) is mildly common so that you can call it in WillReceiveProps and update your state the same way.

You could also grep to see how often that pattern comes up. Guessing we only have a dozen or two cases of ".contextTypes =" and maybe all are React.Component. So probably also okay to punt on it.

Fair enough. It’s not just about the context though—we have the same potential issue with props (https://github.com/reactjs/react-codemod/pull/54#issuecomment-227594381). I guess always emitting super(props) could be a good solution if you’re up for it.

Yeah, I'm fine with writing super(props); whenever we're a little unsure or even just for all components regardless.

Should we add getChildContext to AUTOBIND_IGNORE_KEYS?

Should we add getChildContext to AUTOBIND_IGNORE_KEYS?
Good catch. I'll add a test for it.

Not sure if this is a pattern anybody uses but the use of arguments seems unsafe to transform:
class Stuff {
  doSomething(a, b, c) {
    console.log(arguments);
  }
}

let x = new Stuff()
x.doSomething(1, 2, 3) // {0: 1, 1: 2, 2: 3}

class Stuff {
  doSomething = (a, b, c) => {
    console.log(arguments);
  }
}

let x = new Stuff()
x.doSomething(1, 2, 3) // {}

This looks broken. Input:
'use strict';

var React = require('react')

var Loader = React.createClass({
  getInitialState() {
    if (this.props.stuff) {
      return { x: 1 }
    }

    switch (this.props.wow) {
      case 1:
        return this.props.lol ?
          { x: 2 } :
          this.whatever(this.props)
    }

    return this.lol()
  },

  render() {
    return null;
  }
});

module.exports = Loader;

Output:
'use strict';

var React = require('react')

class Loader extends React.Component {
  constructor(props) {
    super(props);
    if (props.stuff) {
      return { x: 1 }
    }

    switch (props.wow) {
      case 1:
        return props.lol ?
          { x: 2 } :
          this.whatever(props)
    }

    this.state = this.lol();
  }

  render() {
    return null;
  }
}

module.exports = Loader;

As you can see, all return statements inside if or switch branches are not transformed, but they should be—they should become assignments to this.state with an immediate return.

Here is an issue with duplicate declaration:
'use strict';

var React = require('react')

var Loader = React.createClass({
  getInitialState() {
    const props = this.props
    return { x: props.x }
  },

  render() {
    return null;
  }
});

module.exports = Loader;

It becomes:
'use strict';

var React = require('react')

class Loader extends React.Component {
  constructor(props) {
    super(props);
    const props = props
    this.state = { x: props.x };
  }

  render() {
    return null;
  }
}

module.exports = Loader;

In this case const props = props is a compile error.

This looks incorrect, we should bail out if mixins is anything other than array literal.
Input:
'use strict';

var React = require('react');

const mixins = [ClassNameMixin, PureRenderMixin]

var Loader = React.createClass({
  mixins: mixins,

  render() {
    return
;
  }
});

module.exports = Loader;

Output:
'use strict';

var React = require('react');

// oops!
const mixins = [ClassNameMixin, PureRenderMixin]

class Loader extends React.Component {
  render() {
    return
;
  }
}

module.exports = Loader;

We should probably bail out if user calls this.getInitialState() anywhere in the component.
(Yes, apparently this pattern is a thing.)
Input:
'use strict';

var React = require('react');

var Loader = React.createClass({
  getInitialState() {
    return { x: 42 }
  },

  reset() {
    this.setState(this.getInitialState())
  },

  render() {
    return
;
  }
});

module.exports = Loader;

Output (will crash!)
'use strict';

var React = require('react');

class Loader extends React.Component {
  state = { x: 42 };

  reset = () => {
    this.setState(this.getInitialState())
  };

  render() {
    return
;
  }
}

module.exports = Loader;

I think we should bail from lifting state if it references this at all—not just this.props.
Here is another example that seems broken now.
Input:
'use strict';

var React = require('react');

var Loader = React.createClass({
  something: 42,

  getInitialState() {
    return { x: this.something }
  },

  render() {
    return
;
  }
});

module.exports = Loader;

Output (I think it would be broken because something hasn’t been assigned yet):
'use strict';

var React = require('react');

class Loader extends React.Component {
  state = { x: this.something };
  something = 42;

  render() {
    return
;
  }
}

module.exports = Loader;

To sum up the todos I found so far.
These need to be fixed:

Need to fix early returns in getInitialState (https://github.com/reactjs/react-codemod/pull/54#issuecomment-227606687)
Need to call super with props when getInitialState uses only this.props or this.props.foo but has no other usage of this (https://github.com/reactjs/react-codemod/pull/54#issuecomment-227594381)

These are less severe so we can maybe live with them, but it would be better to fix (at least some of) them:

Consider calling super with props and context when getInitialState uses this in any other way (https://github.com/reactjs/react-codemod/pull/54#issuecomment-227596217)
Consider always creating a constructor if getInitialState has any references to this (https://github.com/reactjs/react-codemod/pull/54#issuecomment-227612143)
Consider bailing out for dynamic mixins (https://github.com/reactjs/react-codemod/pull/54#issuecomment-227610288)
Consider bailing out if user calls this.getInitialState() anywhere (https://github.com/reactjs/react-codemod/pull/54#issuecomment-227611630)
Consider bailing out if arguments is used inside React methods (https://github.com/reactjs/react-codemod/pull/54#issuecomment-227605441)
Consider fixing compile error with const props = this.props in getInitialState (https://github.com/reactjs/react-codemod/pull/54#issuecomment-227607544)

Note that almost all of them can lead to potential crashes even though patterns themselves may not be super common.

Need to fix early returns in getInitialState

Yeah, I just changed the way we inline initialState (https://github.com/reactjs/react-codemod/pull/54/commits/0cfad0acd405c5d39b7b7c99f45c5e862ffbb8d8). It works now but I'm not happy with the implementation -- will improve it later.

Consider fixing compile error with const props = this.props in getInitialState

What do you think is a good way to fix this? I can think of 3 approaches -- rename the constructor's parameters when necessary (make them hygienic), make state an IIFE (state = function() { ... }()), or just bail out.

Consider bailing out for dynamic mixins

Fixed in https://github.com/reactjs/react-codemod/pull/54/commits/ada3fb81819159241cd091ced8a7f24c0259e0e6.

I think we should bail from lifting state if it references this at all—not just this.props. Here is another example that seems broken now.

Thanks for catching this. I'll say I'm down with bailing out here -- an alternative approach is to move state all the way down until all the other property initializers have been initialized. It's doable but uh it doesn't feel clean. https://github.com/reactjs/react-codemod/pull/54/commits/3936f555c7f0da4c1ddc14cce20e11fd60fe552f improved the constructor and lifting logic, but I think it makes sense to make it more strict.

I can think of 3 approaches -- rename the constructor's parameters when necessary (make them hygienic); make state an IIFE (state = function() { ... }()) which actually solves a lot of problems but the code doesn't look good; or just bail out.

If the right hand side is just this.props, I think you can safely remove the assignment. Otherwise, bail out completely for the class.

I'll say I'm down with bailing out here -- an alternative approach is to move state all the way down until all the other property initializers have been initialized.

I think this might be reasonable. Having non-whitelisted and non-function properties is a rare case anyway so moving state below such properties should solve such cases.

This PR is ready for review. This is quite a big diff so I added some new comments in class-initial-state.input.js to explain the test cases.
Seems like Travis has trouble understanding npm-shrinkwrap.json (it's pointing to my own fork of recast now) but the tests pass locally. Feel free to ping me if there's anything unclear. Thanks @gaearon! cc @spicyj

Shouldn't constructor() and super() be also passed context as argument ?

It doesn’t have to be passed unless you’re reading this.context in the constructor. React will set those fields automatically. So we opt for not surfacing context whenever possible. See also discussion above on this.

Ok, thanks for the explanation !

Congratulations!


feat: DOI reserved for version table

@Aydawka Recheck. Broke on merge

broke? is there any error occurs on deployment?

All datasets started showing 500 errors

@megasanjay  so reset the db -> checkout staging branch -> create the db ( stamp head here) -> add one study (also add an invite here if possible) -> switch to your branch -> run migration (upgrade head) here -> verify data is good and migration succeds
This workflow has been tested and work.

Migration still fails on my side

@megasanjay errors were fixed and pushed

Can confirm migrations work


Hero3 white takes Photo with name GOPRO0001 but calls it GOPRO0002, something killed the filemanagement

Going to need more info.
Can you post the output of:
[gpcam].listMedia(format=False)

HTTP/1.1 ÿûAllow: GET
None
HERO3/3+
There are six pictures taken....


Calculate disk size based on rootfs size

In raw images creation, Instead of change the disk size  manually would be better to calculate the disk size.
It is need to find a way to do it:
Some disk space is reserved in ext4
After partition the disk , the available space in the partition is not the same as the full disk (alignment) an other factors make this a bit variable.

Fixed by #30.


karma continuous crash when I add a vendor library

Hi guys,
I'm trying to get familiar with angular, grunt, bower, etc... and there might be something that I didn't understand.
I try to add a vendor library (angular-google-maps) in my project. In order to do that I did
bower install angular-google-maps --save
this command install the library in vendor directory and update the bower.json adding a line in dependencies section.
When then I run grunt watch,
when I add the angular-google-maps dependency ( angular.module(['google-maps']),
the karma:continuous task crashes
Firefox 32.0.0 (Mac OS X 10.9) AppCtrl isCurrentUrl should pass a dummy test FAILED
        minErr/<@/Users/jeremy/Projets/ng-boilerplate/vendor/angular/angular.js:78:5

And the angular-google-maps library is not copied in the build directory.
I also noticied that the build.config.js file is not updated and a line in section vendor_files (js) has not been added for angular-google-maps.
Is that file supposed to be edited manually every time a library is added ? I'm convinced that it shouldn't be like that.
Well, I'm sure that I'm missing or misunderstanding something but I don't know what.
Thanks in advance for your suggestions.

Hi, I know this is closed but I would like to add on this, because it's been repeatedly quite a pain in the last few months. More to add a point of view then to get a fix, especially thinking about Warlock, because I think it's the only thing unfriendly and unproductive of ngbp...
In my team often someone add various bower libraries just to test them and choose the one that adapts better to us. They obviously always have to modify the build.config.js but many times they forgot to use --save-dev when installing with bower. The result is that everytime there's a merge because bower install didn't add the files there's someone that gets that
AppCtrl isCurrentUrl should pass a dummy test FAILED
with no other indication about the missing module.
The first few times we lost a lot of time on this, now we know we just need to completely comment out app.spec.js so grunt build will build no matter what and then run the application and in the browser we get a very easy to read error specifying which module can't be found.
I don't know if it's a problem with angular-mocks or karma logging, but it's clearly a bad thing if the fastest way to debug it is to comment out our tests.
I tried to solve it with some different approaches, but to no avail at the moment. I'll try again in my spare time but my understanding of karma is not as good as it should.
My best bet would be to check if the files listed in build.config.js exists before running the test (since they are loaded singularly in karma conf)
files: [
      <% scripts.forEach( function ( file ) { %>'<%= file %>',
      <% }); %>
      'src/**/*.js',
      'src/**/*.coffee',
    ],

but I haven't been able to get even close to a solution...


Fixes manually enter table name due to await

This PR fixes #19436.
We were not awaiting the inputBox result and as a result, we went straight to the function name prompt.

(not related to this PR, we can get this in).
@VasuBhog @Charles-Gagnon isn't there some sort of (linting?) rule that can help us detect async calls that aren't handled properly?

Yes, and we have it. But sadly in this case I don't know of any way to detect this scenario since it was saving the promise to a var which is a very valid thing to do (maybe awaiting later or something). The check we do is only for dangling promises.


Add maven build

I created a maven pom file as an alternative way of building so that it is easy to build a local artifact for use as a maven dependency in other projects. Also made the param argument to SVGImage#snapshotImpl final since it it is used in the FutureTask.

Thanks! I merged!!


Should we default to OpenBLAS?

The OpenBLAS implementation seems to be all-round better (at least on macos), owing to concurrency and hardware-specific optimizations.
A (perhaps too) simple comparison:
With system (macos) default BLAS
(time (progn (reduce #'magicl:multiply-complex-matrices (mapcar (lambda (_) (quil::random-special-unitary 1000)) (list 1 2 3 4))) 1))

Evaluation took:
  53.799 seconds of real time
  53.642728 seconds of total run time (53.109868 user, 0.532860 system)
  [ Run times consist of 0.618 seconds GC time, and 53.025 seconds non-GC time. ]
  99.71% CPU
  145,903,290,806 processor cycles
  28 page faults
  5,055,004,624 bytes consed

1

With OpenBLAS
(time (progn (reduce #'magicl:multiply-complex-matrices (mapcar (lambda (_) (quil::random-special-unitary 1000)) (list 1 2 3 4))) 1))

Evaluation took:
  6.386 seconds of real time
  8.379127 seconds of total run time (7.713601 user, 0.665526 system)
  [ Run times consist of 0.482 seconds GC time, and 7.898 seconds non-GC time. ]
  131.21% CPU
  17,310,196,679 processor cycles
  5,078,847,024 bytes consed

1

I don’t find this simple example too simple at all.

OpenBLAS is the direct descendant of GotoBLAS. Intel hired Kazushige Goto, the original author of  GotoBLAS and, shortly thereafter, the Intel MKL BLAS implementation started to be as performant as GotoBLAS. I think OpenBLAS and Intel MKL's BLAS are the fastest in town at the moment.

I think OpenBLAS and Intel MKL's BLAS are the fastest in town at the moment.

Neat. The former is FOSS, the latter is FAIB (free as in beer).

Also, this reminds me that I have a PR to submit that would allow us to reduce the consing significantly. Example (perhaps module row-major vs column-major order):
CL-USER> (defparameter *vector* (magicl:random-matrix 2048 1))
CL-USER> (time (let* ((matrix-data (magicl::matrix-data *matrix*))
                      (m (magicl:matrix-rows *matrix*))
                      (n (magicl:matrix-cols *matrix*))
                      (vector-data (magicl::matrix-data *vector*))
                      (result (make-array n :element-type '(complex double-float) :initial-element #c(0.0d0 0.0d0))))
                 (magicl.blas-cffi:%zgemv "N" m n #c(1.0d0 0.0d0) matrix-data m vector-data 1 #c(0.0d0 0.0d0) result 1)))
Evaluation took:
  0.007 seconds of real time
  0.048209 seconds of total run time (0.047635 user, 0.000574 system)
  685.71% CPU
  19,543,927 processor cycles
  8,576 bytes consed
CL-USER> (progn
           (sb-ext:gc :full t)
           (time (magicl:multiply-complex-matrices *matrix* *vector*))
           (values))
Evaluation took:
  0.041 seconds of real time
  0.063840 seconds of total run time (0.047902 user, 0.015938 system)
  [ Run times consist of 0.003 seconds GC time, and 0.061 seconds non-GC time. ]
  156.10% CPU
  111,235,118 processor cycles
  67,141,680 bytes consed

Yowza! That CPU usage is impressive. Is that MKL?

According to dtruss, SBCL is picking up /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib which should be the library bundled with Mac OS


Use pyarrow to write parquet files

Addresses: #123
On SCALE_FACTOR=10:

Lineitem Parquet file before the change have 20k rowgroups
Lineitem Parquet file after the change only has 57 rowgroups

This does affect benchmark results quite a bit, depending on how resilient the Parquet reader implementations are to these poorly written Parquet files. However I think for the sake of having a benchmark that represents the expected/common case we should write the Parquet files properly!

I think we should fix the culprit upstream instead of bandaid it here.

That makes sense @ritchie46, I'll close this PR in favor of an upstream fix


Index implicit documentation comments. [phab:D416]

Created by zarko at 2015-07-20 23:18:08:
The interesting parts of this change come
from a change that was applied upstream.

fromberger accepted this revision at 2015-07-21 14:53:52

zarko closed via commit 9ae62f4b102c313aae763b7755e669c2c2e31c10 at 2015-07-21 17:22:02


[BEAM-10635] Fix forward the google-api-core version

For the Python container base image, moved the google-api-core
version from 1.20.0 to 1.21.0 since the google-cloud-bigquery 1.26.1
has requirement google-api-core<2.0dev,>=1.21.0.
The google-cloud-bigquery version advancement happened in commit:
https://github.com/apache/beam/commit/a315672dbe2b82e013e8120ac5398c623c7b13a7

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @aaltay
PTAL, thx!

LGTM


Web updates (JS/Canvas)

JS/Canvas support
Updated Web Sample:

-Loading animation
-CanvasBasedWindow -> ComposeViewport
-unsupported browser notification (WASM)

Compose Multiplatform 1.6.10
Also:

-Pinned topBar in scaffold example (for better visual blur tests)
-Some edits in index.html (Sample)

@chrisbanes Hi!
Fix of "kotlin yarn lock": delete kotlin-js-store folder in root (what I usually do) or run "kotlinUpgradePackageLock" task

:check works on my windows machine except ios (for obvious reasons)

@chrisbanes do you know how to fix it?
Reason: Task ':haze:metalavaCheckCompatibilityRelease' uses this output of task ':haze:generateResourceAccessorsForJsMain' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.

I'll fix this in a follow up 👍. Thanks!


Upstream patch on HaikuPorts

https://raw.githubusercontent.com/haikuports/haikuports/master/haiku-apps/masterpiece/patches/masterpiece-r742.patch

Is this still relevant, I think most of this patch is already included? (or I missed some things) :)


Create Tree factory method of(T...)

Tree.of(1, 2, 3, 4) would produce:
   1
 / | \
2  3  4

This would be the solution:
@SuppressWarnings("varargs")
@SafeVarargs
static <T> Tree<T> of(T... values) {
    final List<T> list = List.of(values);
    return list.isEmpty() ? empty() : of(list.head(), list.tail().map(Tree::of));
}

However, IntelliJ IDEA 15.0.1 does not compile calls like Tree.of(1, Tree.of(2), Tree.of(3)) now with the error message:
Could not resolve method 'of(int, javaslang.collection.Tree.Node<java.lang.Integer>, javaslang.collection.Tree.Node<java.lang.Integer>)'

But jdk1.8.0_66 and Eclipse Neon M2 do compile it.
I will defer this addition until 2.0.1 and hope that this issue will be fixed by IntelliJ. Maybe we should create an issue on the bug tracker...

I did this as part of #659, Tree.of was needed to implement the tabulate method.

Yes, I've seen it. It is ok - IntelliJ IDEA 15.0.2 has still compile errors. I will file close this issue and file a bug.

Issue: IDEA-150224


Request Body matching does not remove array brackets from field name when converting request to hash for formdata.

When setting up a provider state as:
 ... .with(method: :post,
        path: 'some_path',
        headers: { 'Content-Type' => 'application/x-www-form-urlencoded' },
        body: { key: [ "123", "456"] })

and passing the hash body:
{ key: [ "123", "456"] }

the comparison fails as the request body is deserialized as:
{ "key[]": [ "123", "456"] }

I believe this is due to the way the formdata is encoded by adding the "[]" to the end of the key but it not being removed again during parsing.

Can you provide the failure output from the logs including the diff?

Poke.

I am encountering the same issue. The failure output looks like this:
 Missing requests:
            	GET /questions?question_ids=1&question_ids=2

            Unexpected requests:
            	GET /questions?question_ids[]=1&question_ids[]=2

My expectation looks like this:

        some_service.given('some scenario')
          .upon_receiving('a request for questions')
          .with(method: :get, path: '/questions', query: {question_ids: [1,2]})

Can you open this in the mock service project please? https://github.com/bethesque/pact-mock_service/issues

Closing, moved to https://github.com/bethesque/pact-mock_service/issues/60


Extra pronunciation (transliteration) sources

Hindi and Urdu/Shahmukhi are present in the DB. Needs an option in settings > layout to add to the presenter and also to be added to the overlay.

[ ] Hindi requires Noto Sans Devanagri (Medium, Semibold, Bold choice requires testing against punjabi translit, stroke thickness should be same/similar)
[ ] Urdu/Shahmukhi requires Noto Sans Nastaliq Urdu Regular

Related: #186 #159 #85 #158

Urdu requires CSS text-align: right;
Can go before this declaration https://github.com/ShabadOS/desktop/blob/dev/app/frontend/src/Presenter/Line.css#L12

Yea Urdu is Right to Left

Also related to  #271 this moves it to settings > display

text-align: right;

Why does it require this? I'll push it and you can mess about, I can't actually tell if ltr or rtl is automatically set

Semi bold seems ok. And the font/using unicode already seems to set RTL.


[server] Fix suppressing bug on the server

It is possible that the start line and end line of a bug reported by the analyzer are different.
Example:
int main()
{
  // codechecker_suppress [all] This will not be suppressed because of a bug.
  int x = 1 /
    0;
  return x;
}

In the above example the bug start line is where x variable is declared and the end line is in the next line.
On the server we stored the start line as the line where the report can be found but for suppression we checked whether there is a source code comment above the end line. So if someone inserted a source code comment above the start line the server hasn't suppressed that report.
With this patch we will solve this problem and we will check the source code comment above the start line and not the end line.

This change seems reasonable for me, but I can't reproduce the issue. The report is suppressed for me even before this change.

Make sure two things:

the server you are running is not built from this PR.
after analysis check the plist files and see whether it contains a range where the start and end lines are different and you inserted the suppress commend above the start line.

Also check the example in the modified test case.

Please use older client/server than 6.18.0. >=6.18.0 releases contained another bug (#3576) which hided this problem.


Bugfix/signature verification fix

Another issue created on the QZIG board for this. So closing this PR.


attrs installs a module attr which collides with with the PyPI project attr

Our project has one dependency that installs https://pypi.org/project/attr/ and another dependency that installs your project which also installs a module called attr.
We have no real control over the code in either dependency.
Is there some way to fix, remedy or work around this problem?
Thanks in advance!
https://github.com/SuperDuperDB/superduperdb/issues/983

this is a fun bug in lancedb: #508
they wanted to use attrs, but depended on the wrong project. It still worked because they got it thru AIOHTTP + chance, I guess.

I think you ment to refer to this one https://github.com/lancedb/lancedb/issues/509#issue-1906537730

the number was correct, I just forgot to add the project :)

Either way, fixed upstream. 🤓
—not an AI


🏗 [ADMIN] - matthiask

DSF member

[X] I am a DSF member

Why do you want to join?
I want to help out and I also think I want to propose a move of some of my own projects here since I think that django-commons would be a better place than my personal profile. I'm going to follow the official procedure for this of course and not just move projects into the organization because I can.
Please tell us about your packaging experience?
TBH I don't yet have experience using e.g. trusted publishing using PyPI. That's something I'm going to learn soon-ish. I certainly have a lot of experience when it comes to releasing Python packages generally.
Please tell us about your GitHub Actions experience?
I have been using GitHub actions for a long time; I haven't authored my own reusable action, but done about everything else.
How long do you expect to be involved with Django Commons?
I except to work with and on Django for years to come, and I expect to stay an active member of Django Commons for the same time, except if things change (as they did with Jazzband). I'm also happy if I can step back, and let others do the work and take the blame/praise for it so maybe the involvement won't be as long.
Code of Conduct

[X] I agree to follow Django Commons's Code of Conduct

Thanks Matthias! I'm going to let this sit for a week to give time to other folks to apply.

Please see https://github.com/orgs/django-commons/discussions/19. I'm not sure if the tag actually pinged you.

Hi Matthias, would you be willing to get on the Code of Conduct team for the org? It would be managed via a Google Group, where upon a report occurring, we'd collect the details of the incident, discuss how to handle things, then come to an agreement on a path forward.
At the conclusion of each report, we would send an email to the admin team and the CoC team with our decision (provides accountability and transparency). As you can likely imagine, the involvement will be low until there's an incident.
Please let me know if this is something you'd be interested and available to do? We're looking at a 9-12 month cycle before we reassess team structures. Though you're free to step down at any point.

Yes, I'm interested in that! Thank you. (I think I've already been invited to the google group?)

Great, thank you! And yes, we had a slight mistiming on our end. The next steps will be posted to that google group in the next month or so pending people's availability.


Add GH Pull Request template

I would like to have this to keep a stricter discipline with my PRs, without the need of having everything in mind.

I don't want to impose anything. I'm not sure what's everybody else's workflow, and I thought these would be steps useful to everybody opening PR. It's a common thing in many projects.

It's just... very verbose. I'd be ok with 2-3 items to check, but this is overwhelming for me. If we can slim it down a bit, I think we could ship it.

No worries. I'll keep it as a local personal checklist 👍🏻


[BUG]  It is possible to create a user via REST API with restricted characters encoded using URL encoding.

What is the bug?
It is possible to create a user both for PUT and PATCH with restricted characters encoded using URL encoding.
Do you have any screenshots?
If applicable, add screenshots to help explain your problem.
Do you have any additional context?
Add any other context about the problem.

Merged so closing.


CSS function linear-gradient() break binding functionality

Even you can not set the button a class name. Just write linear-gradient() function inside the block "fx:Style".
Example:
<?xml version="1.0" encoding="utf-8"?>
<js:Application xmlns:fx="http://ns.adobe.com/mxml/2009"
				xmlns:js="library://ns.apache.org/royale/basic"
				xmlns:local="*" pageTitle="HelloWorld">
	<fx:Script>
		<![CDATA[
			[Bindable]
			private var test: String = "BINDING TEST";
		]]>
	</fx:Script>

	<fx:Style>
		@namespace js "library://ns.apache.org/royale/basic";

		.testClass {
			background: linear-gradient(#FF0000, #00FF00)
		}
	</fx:Style>

	<js:valuesImpl>
		<js:SimpleCSSValuesImpl />
	</js:valuesImpl>

	<js:beads>
		<js:ApplicationDataBinding/>
	</js:beads>

	<js:initialView>
		<js:View width="100%" height="100%">
			<js:Container width="100%" height="100%">
				<js:beads>
					<js:HorizontalFlexLayout/>
				</js:beads>
				<js:Label text="{test}"/>
				<js:TextButton text="{test}" className="testClass" width="100" height="24"/>
			</js:Container>
		</js:View>
	</js:initialView>
</js:Application>

Which version of Royale are you using?  I think this is fixed in the nightly build because it is working for me and we've made some changes to have the compiler accept linear-gradient and some other CSS functions.  You can try the nightly builds by following the links near the bottom of this page https://royale.apache.org/download/

linear-gradient is used extensively in Jewel component set, but as Alex said is not still in latest release. Use nightly or wait till 0.9.3 is released. Thanks


Extraction fails for a metaprogram with a spec

If I add a spec to the fail primitive, then this code:
let skip_guard () : Tac unit =
    if is_guard ()
    then smt ()
    else fail ""

Fails extraction with:
FStar.Tactics.Effect.fst(26,20-26,41): (Error 76) Ill-typed application: application is ((match a with
            | true  -> (reify (smt ()))
            |_  -> (reify (fail ""))) (decr_depth (set_proofstate_range ps' (prims_to_fstar_range FStar.Tactics.Derived.fst(130,4-132,16)))))
remaining args are (decr_depth (set_proofstate_range ps' (prims_to_fstar_range FStar.Tactics.Derived.fst(130,4-132,16))))
ml type of head is Obj.t

Others work fine it seems. See: ae448aa800cd2176fd2fac1b3ef952cf4f5f5a4d

The WP parts of the OCaml types for each branch differ. Here's a workaround
let skip_guard () : Tac unit =
    if is_guard ()
    then smt () <: TAC unit (fun _ _ -> False)
    else fail ""

Looking into a fix

I've been looking into this but I'm not yet entirely sure what the cause is. In extraction (FStar.Extraction.ML.Term.check_term_as_mlexpr), the body of the match in skip_guard is expected to have type Prims.bool  ->  (unit, unit) FStar_Tactics_Effect._dm4f_TAC_repr. This is the case when there's no spec, but when there is, its type is Prims.bool  ->  (unit, Obj.t) FStar_Tactics_Effect._dm4f_TAC_repr, which triggers a coercion, which turns the whole application into an Obj.t, hence the ill-typed application error.

I think we're reifying the computation before translating, getting a _DM4F_TAC_repr a wp, and translating Tm_let/Tm_match as a type just returns Obj.t. Maybe translate_term_to_mlty could do better, but who cares? Why not nuke all effect arguments into Prims.unit? I just tried that and it seems to work, but running CI to be sure. I suppose it might generate some ill-typed if we had indexed DM4F effects, but we don't.

Merged to master.. hope no one curses at me for it : )