Support for quantized models?

Does nntrainer support quantized models?

:octocat: cibot: Thank you for posting issue #854. The person in charge will reply soon.

:octocat: cibot: Thank you for posting issue #854. The person in charge will reply soon.

Can you please elaborate on the kind of support you require, as there can be multiple user scenarios?

The model is quantized like TfLite/TensorFlow/PyTorch model and the application wants to train a part of the model like transfer learning. This is possible with NNTrainer - refer to https://github.com/nnstreamer/nntrainer/tree/main/Applications/TransferLearning examples.
You want to finetune a quantized model. This can be done with NNTrainer, however, converting the quantized model weights to floating-point will have to be done manually. This will be soon supported with NNTrainer as an API.
You want to quantize a model trained/finetuned with NNTrainer. This is not yet supported but it will be this year.

Can you please elaborate on the kind of support you require, as there can be multiple user scenarios?

The model is quantized like TfLite/TensorFlow/PyTorch model and the application wants to train a part of the model like transfer learning. This is possible with NNTrainer - refer to https://github.com/nnstreamer/nntrainer/tree/main/Applications/TransferLearning examples.
You want to finetune a quantized model. This can be done with NNTrainer, however, converting the quantized model weights to floating-point will have to be done manually. This will be soon supported with NNTrainer as an API.
You want to quantize a model trained/finetuned with NNTrainer. This is not yet supported but it will be this year.

Sorry for the late reply, I needed to discuss with the team to understand a bit more our needs.
I think what we'd like to know is whether nntrainer has to work with float32 (at the cost of some performances) or if it can train directly a quantized model, or maybe a mixture of both (like having non trainable part quantized and trainable part float32).
What isn't clear as well is wether there can be a difference in the format during inference and training.
Our goal is to get the best performances possibles and we'd like to minimize the use of float32.

Sorry for the late reply, I needed to discuss with the team to understand a bit more our needs.
I think what we'd like to know is whether nntrainer has to work with float32 (at the cost of some performances) or if it can train directly a quantized model, or maybe a mixture of both (like having non trainable part quantized and trainable part float32).
What isn't clear as well is wether there can be a difference in the format during inference and training.
Our goal is to get the best performances possibles and we'd like to minimize the use of float32.


Android's certificate verification JNI layer

Cronvoy: preparation to unittest certificate verification JNI
Properly testing Android certificate verification logic requires calling
into framework code. That cannot be done through Robolectric (framework
APIs are faked). Hence, actual instrumentation tests are needed.
Having said that, after some exploration on the state of Bazel/Android
instrumentation tests, I've realized that the current state of things is
non-optimal. As a stopgap solution (until the infrastructure improves),
we've decided to test the JNI layer through unittests which fake
X509Util. This should be a reasonable middle ground, as X509Util is mostly a
compatibility layer on top of Android's API.
This CL introduces FakeX509Util and adds allows tests to swap that in by
adding a test-only API to AndroidNetworkLibrary.
FakeX509Util is not particularly clever: from its perspective a
certificate is just a string and for a verification to succeeds, all
certificates in a chain must be root certificates (weird, but we don't
really care about its logic).
Add utility functions to translate between C++ and Java std constructs
Add utility functions to translate between:

C++ strings and Java strings
C++ vector of bytes and Java array of bytes

These utility functions will be used in the next commit to implement the
JNI layer for certificate verifications (and its unit tests).
Implement JNI layer for Android's certificate verification
Add native hooks for AndroidNetworkLibrary Java APIs.
Write unittests that mimic calls from native to Java for these new
hooks, by making use of a fake X509Util and additional test-only Java
-> C++ JNI calls.

@RyanTheOptimist I'm not sure who's going to review this code, sending over to you for the time being, feel free to redirect.
Note: this is still rough around the edges (I still need to look into the lifetime of JNI objects) but I wanted to touch base to make sure we don't have are on the same page. My idea is that once these JNI calls are in place, the async C++ cert verifier (yet to be built) will simply synchronously call into this.
Main type of feedback I'm looking for is: general shape of things and where we want the code to live. The PR is composed by 3 commits which you should be able to look at independently (I can't create child PR afaik).

It's late for me right now, but I'll do a full pass on this tomorrow during my a.m.

(I forgot to mention the associated bug)


Bug: no-shadow hoist functions section zh-cn translation incorrect

URL(s)
http://eslint.cn/docs/rules/no-shadow#hoist-functions
What did you do?
After the first sample in "hoist: functions", the here is a sentence as below:
虽然 if 语句中的 let b 在 function声明之前，该示例是正确的。
But in the English version (https://eslint.org/docs/latest/rules/no-shadow#hoist-functions), the sentence is:
Although let b in the if statement is before the function declaration in the outer scope, it is incorrect.
What did you expect to happen?
So, the zh-ch translation should be:
... ，该示例是不正确的。
What actually happened?
The current translation is:
... ，该示例是正确的。
Participation

[ ] I am willing to submit a pull request for this issue.

Additional comments
No response

Sorry, we don’t own or maintain eslint.cn so we can’t help.


Fix bug with _ANY Flag value. It's supposed to be 0 not 8.

Without this map.Put() sets flag = 8 and bpf sysclal returns with EINVAL.

Thanks!


[FEAT]: Update _reusable-check-api-for-breaking-changes.yml to take advantage of new public griffe features

Description
There are some new, public griffe features that should be used to make the output more user-friendly.

https://mkdocstrings.github.io/griffe/guide/users/checking/#markdown
https://mkdocstrings.github.io/griffe/guide/users/checking/#github

Additional Information
No response

The markdown may not be as useful, it seems to be more adapted for changelogs, but it would still be worth it to look into.


"Transfer size per second" graph is misaligned except during mouse-over

I'm using the latest ArangoDB of the respective release series:

[ x] 3.2.0

On this operating system:

[ x] Windows, version:

I'm using the web interface with this browser:     running on this OS:

[x ] _system database?

I am seeing this using Chrome Version 59.0.3071.109 (Official Build) (32-bit)
These are the steps to reproduce:

open the browser on http://<IP_ADDRESS>:8529
use database [ x ] _system
The transfer size per second graph is misaligned. It aligns correctly on mouse over.

See attached gif

Instead the columns should all be aligned.

I just double checked. This does not occure with Firefox 54.0 (32-bit)

Thanks for your report.
I've tested with: Version 59.0.3071.115 (Official Build) (32-Bit) - which is slightly newer as your tested version. There I'm not able to reproduce this. Could you please re-try if this is still an issue?
Note: Also tested version 60.0.3112.90 (Official Build) (32-Bit) - current version. No misalignments there as well.

I just looked into this again for a few minutes. It seems to be dependent on the screen resolution. What resolution did you test with? When i have my screens at native resolution i see the offset if i turn on windows' scaling feature i don't.

Tried some resolutions between 1024x768 and 1920x1200. What resolution are you using?

I think it starts beyond 1920 widths. At home i am running 2880x1620 not sure about work but i think it is 2560x1440

@mpv1989 could you check that with your display?

It works for 2560x1440. I can later check on my 4k display.

@hkernbach I was able to reproduce this on my 4k display. Adding the following css fixed this issue.
.dashboard-row {
    width: 100%;
}

already commited?

no

@hkernbach @mpv1989 @mchacki can you please follow up on this so the fix can be accepted?

pr opened: https://github.com/arangodb/arangodb/pull/5216

PR merged. Should be fixed. If not, please re-open the issue.


Add a note about emojis

I'll defer to Rick on this one for quick merge. I'm OOF most of the rest of today.


Revert "#1: add support for horses in database initialization"

Reverts SABARI0603/pet-clinic#2

/paulo - can you please review this pull request?

/paulo - can you check now?


Chapter 7: Fails to build docker image with Tilt

Hi,
I can successfully build the catalog-service image locally when I run the maven command. All is fine, and testcontainers ITs are ok.
However, when I try to build the image with Tilt, I get a problem with testcontainers when running integration tests :
2024-01-25T09:27:58.911+01:00  WARN 2867 --- [catalog-service] [containers-ryuk] o.t.utility.RyukResourceReaper           : Can not connect to Ryuk at <IP_ADDRESS>:32768

java.net.ConnectException: Connection refused
	at java.base/sun.nio.ch.Net.pollConnect(Native Method) ~[na:na]
	at java.base/sun.nio.ch.Net.pollConnectNow(Net.java:682) ~[na:na]
	at java.base/sun.nio.ch.NioSocketImpl.timedFinishConnect(NioSocketImpl.java:549) ~[na:na]
	at java.base/sun.nio.ch.NioSocketImpl.connect(NioSocketImpl.java:592) ~[na:na]
	at java.base/java.net.SocksSocketImpl.connect(SocksSocketImpl.java:327) ~[na:na]
	at java.base/java.net.Socket.connect(Socket.java:751) ~[na:na]
	at org.testcontainers.utility.RyukResourceReaper.lambda$null$1(RyukResourceReaper.java:105) ~[testcontainers-1.19.3.jar:1.19.3]
	at org.rnorth.ducttape.ratelimits.RateLimiter.doWhenReady(RateLimiter.java:27) ~[duct-tape-1.0.8.jar:na]
	at org.testcontainers.utility.RyukResourceReaper.lambda$maybeStart$2(RyukResourceReaper.java:101) ~[testcontainers-1.19.3.jar:1.19.3]
	at java.base/java.lang.Thread.run(Thread.java:1583) ~[na:na]

Any idea ?
Thanks a lot !

I've tried with the gradle command, and it seems the test are not run. According to this, the equivalent maven command to gradle bootBuildImage is mvn spring-boot:build-image but the latter run all the preceding phases to package phase, so also the test phase. According to Spring Boot Maven documentation, the equivalent command would be instead mvn spring-boot:build-image-no-fork. In this case, no tests are run and just the image is built.
@ThomasVitale does it make sense for you to update the Gradle and Maven section ?

@elR1cu thanks a lot for reporting this inconsistency between Gradle and Maven. I have updated the table in the README.md file accordingly: https://github.com/ThomasVitale/cloud-native-spring-in-action/commit/3b19d02bea585c376501c1c10412f2bba0ecbff0


RMI-00009: Moderator edits a comment

The moderator sees a comment that is unrelated to the discussion or contains an inappropriate word. He edits the comment and saves the changes.


feat(hmr): custom socket host

Description
Solve the problem of socket host splicing error caused by using proxy domain name without port during development
Additional context
fix: #5998

What is the purpose of this pull request?

[ ] Bug fix
[x] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

Hi, this is also required to embed an application on a VSCode extension webview, as the url of the page (iframe) is not the url of vite server

Hi, this is also required to embed an application on a VSCode extension webview, as the url of the page (iframe) is not the url of vite server
Is there any timeline for this feature to be available?

It seems that https://vitejs.dev/config/#server-hmr is all I needed to configure this.
Thanks anyway ;-)

@ivangsa you reminds me that I can use the default port 80，The PR can closed


Handle Range requests for content

Also, while doing this, the http.ServeFile command will also finish the ETag support by returning 304 status codes when nothing has changed.


Number sort with 0 puts 0 at the end

When sorting a list like this:
[0, 5, 1]
it returns:
[1, 5, 0]
It should know that 0 is 0 and not false and sort accordingly.

In the latest version, this is no longer an issue. Closing.


Can't Download mobile streamed streams

I was just viewing a friends mobile stream and wanted to download it and it doesn't appear on the downloading area.
honestly I preferred the downloading when live version, because it's nice to download in chunks espescially when it's a long video
But please fix this error
TL:DR I can't download my friends stream because it was streamed on their mobile device

#733


⚠ SceneTime has degraded performance

In e6e0b04, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 13920 ms

Resolved: SceneTime performance has improved in 4e9046f after 5 minutes.


Incorrect country details json loaded from factbook

For example, the "Nicaragua" page displays the world factbook country details for Nigeria.
It seems that there is an encoding mismatch here. From the factbook repo README:
"Note: All country profiles use the "official" two-letter GEC (formerly FIPS) codes and NOT the ISO codes (you might be used to) e.g. au for Austria (and not at), gm for Germany (and not de), and so on."
ooni-explorer appears to be using: https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2

Hmm, that would explain all of the mismatches @hellais has been steadily fixing. I'm not sure if there's a quick way to find all the wrong ones and convert them? I'd prefer to stick to ISO as GEC is a US Government thing.
Here's a list comparing them, says last updated two years ago: http://www.statoids.com/wab.html

This should now have been fixed.


pango-view don't work

Describe the bug
I want to preview a font (https://github.com/NixOS/nixpkgs/issues/93108). pango-view fails to do that.
To Reproduce
pango-view works with different backends. all don't work
nix-env -iA nixos.fira-code
nix run nixpkgs.pango

pango-view --backend=cairo ~/.nix-profile/share/fonts/truetype/FiraCode-Bold.ttf

pango-view --backend=xft ~/.nix-profile/share/fonts/truetype/FiraCode-Bold.ttf

$ pango-view --backend=ft2 ~/.nix-profile/share/fonts/truetype/FiraCode-Bold.ttf
pango-view: When running ImageMagick 'display' command: Failed to execute child process “display” (No such file or directory)

$ pango-view --backend=x ~/.nix-profile/share/fonts/truetype/FiraCode-Bold.ttf
pango-view: Available --backend options are: cairo/xft/ft2

so https://linux.die.net/man/1/pango-view is wrong :|
with cairo and xft, a tiny window opens with white background. that can even be exported

pango-view --no-display --output=foo.png --backend=cairo ~/.nix-profile/share/fonts/truetype/FiraCode-Bold.ttf
Expected behavior
get font preview
Additional context
I use the Pantheon desktop. Any reason why that could lead to this problem? @worldofpeace elementary OS even use pango and cairo themselves https://elementary.io/open-source
Notify maintainers
cc pango maintainer @7c6f434c
Metadata

system: "x86_64-linux"
host os: Linux 5.7.8, NixOS, 20.03.2611.bb8f0cc2279 (Markhor)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.6
channels(root): "home-manager-20.03, nixos-20.03.2611.bb8f0cc2279, nixos-hardware, nixos-unstable-20.09pre234242.c71518e75bf"
nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: pango
# a list of nixos modules affected by the problem
module:

pango-view is for viewing texts, not font files. The file it expects is a text file so when you pass it a binary file it will not do anything.
You can use it for installed fonts like: pango-view --font 'Fira Code Bold' --text 'Quick brown fox jumped over the lazy dog.'. Or you can use some other tool like font-manager or gnome-font-viewer.

Thanks. Then it's not really useful for the intended usecase.


Mounting unix domain sockets does not work

Description
Hi,
while I'm loving lima so far, here's a usecase that I haven't gotten to work yet:
I have an SSH agent (https://github.com/maxgoedjen/secretive) running which has a unix domain socket in ~/Library/Containers/com.maxgoedjen.Secretive.SecretAgent/Data/socket.ssh.
F.ex., I can do this in a regular shell (not docker):
# SSH_AUTH_SOCK=$HOME/Library/Containers/com.maxgoedjen.Secretive.SecretAgent/Data/socket.ssh ssh<EMAIL_ADDRESS>Hi cfstras! You've successfully authenticated, but GitHub does not provide shell access.

Also, this works from my host:
# python3 -c 'import socket; sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM); sock.connect("socket.ssh")'
(no output)

Now, I want to use that socket from within my docker containers to securely pull git repositories.
However, when I try to use the socket from inside the lima VM:
# limactl shell docker -- bash -c "SSH_AUTH_SOCK=$HOME/Library/Containers/com.maxgoedjen.Secretive.SecretAgent/Data/socket.ssh ssh<EMAIL_ADDRESS><EMAIL_ADDRESS>Permission denied (publickey).

SSH seems to ignore the socket. If I try it manually from within limactl shell, I see why:
# python3 -c 'import socket; sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM); sock.connect("socket.ssh")'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ConnectionRefusedError: [Errno 111] Connection refused

I'm guessing this is because we are using sshfs, which does not seem to properly support Unix domain sockets? (Only found https://github.com/libfuse/sshfs/issues/236)
Is there some recommended route I should go to use SSH within lima?

workaround: ssh -R


[Doc only] Adding reference to onnx-mlir-serving

Started a list of projects that use/are based on onnx-mlir. Maybe others can add their projects too, if they feels it would be valuable to them.
Signed-off-by: Alexandre Eichenberger<EMAIL_ADDRESS>

Are we going to use Projects tab in GitHub?

@chentong319 I am not familiar with the Project tab, I think it is an alternative way to have dialogs rather than using issues.
This PR is trying to make a list of external project that have a connection with ONNX-MLIR. If you believe there is a better place to put this info than on the README.md, I have no problem exploring another avenue.

Jenkins Linux s390x Build #7975 [push] adding reference to onnx... started at 11:23

Jenkins Linux amd64 Build #7959 [push] adding reference to onnx... started at 10:23

Jenkins Linux ppc64le Build #7023 [push] adding reference to onnx... started at 11:26

Jenkins Linux amd64 Build #7959 [push] adding reference to onnx... passed after 1 hr 6 min

Jenkins Linux ppc64le Build #7023 [push] adding reference to onnx... passed after 1 hr 29 min


Avoid crash in debug statement (happened on Zeta)

oops, looks like it doesn't compile

crap, I cackported the fix from another branch, but skpped one occurrence


renaming of typeclasses to make intent more clear

Proposal for a scheme to organize and name dimensionality related type classes, in order to make their purpose more clear.
Mainly intended as a basis for discussions.

Closing this PR - the solution will be part of a separate PR.


Update README.md

Updated year from 2016 to 2017.

@Laakso ah, sorry, i've made the same change, just haven't pushed it.


[Feature]: Graph in Cards

Is your feature request related to a problem?
Please add option to show a graph in cards like in Minimalist UI.
Describe the solution you'd like
Reference: https://ui-lovelace-minimalist.github.io/UI/usage/cards/card_graph/
Describe alternatives you've considered
No response
Additional context
No response

Pr already opened #308

Duplicate https://github.com/piitaya/lovelace-mushroom/issues/74


Allow Optionally Reducing The Instruction Sighash Length Or Matched Bytes

Overview
Solana transaction sizes are fairly restrictive right now, with sufficiently complex instructions, it can be quite trivial to reach the maximum transaction size. Part of this is that the anchor instruction sighash takes up 8 bytes of space, as opposed to the traditional approach with vanilla programs often only needing 1 byte of space to indicate which instruction is being used.
While not exceedingly large, I'm aware of at least ~3 instructions in various Tulip programs that were larger than the transaction size limitation, which required some refactoring and breaking up the instruction into two different ones, which would've been possible to avoid if the instruction sighash length was reduced by 50% (from 8 bytes -> 4 bytes).
Suggested Workaround
There are four workarounds I can think of

use the fallback function + vanilla program approach whereby instructions are generally indicated with an enum using a u8 representation, thus only consuming 1 byte. This is non-ideal as it kind of invalidates on of the biggest selling points of anchor (imo)
Optional feature flag that allows for a "shortened" instruction sighash (ie: reducing the generated sighash from 8 bytes to 4 bytes).
Optional feature flag that allows for matching incoming instructions against a partial sighash (ie: only comparing against the first 4 bytes of the sighash instead of the 8)
Macro that allows specifying how many bytes to include for an instruction sighash. For example you could tag a function with a macro like #[sighash(bytes = N)] which only match against the first 4 bytes of the isntruction sighash.

#[sighash(bytes = 4)]
pub fn wao(ctx: .....) -> Result<()> {

}

When the sighash is generated by running sha256(global:wao), only the 4 bytes of the generated hash will be used as the instruction sighash.
My preferred option is 4
Note On Instruction Collision
Because the sighash is really a truncated sha256 hash, care needs to be taken that developers are not exposed to a realistic chance of a hash collision in the instruction sighash. The current 8 byte sighash pretty much guarantees this will never happen, however once the sighash length/matched bytes gets dropped by more than 50% the odds of a collision start increasing rather significantly.
Matching against a 4 byte sighash still maintains pretty high guarantees that a collision will not happen as per the following image taken from here.

Custom discriminators (https://github.com/coral-xyz/anchor/issues/3097) solved this problem.


Address entry issue

Whatever address I enter I get an error saying "Maps API error: Keyless access to Google Maps Platform is deprecated. Please use an API key with all your API calls to avoid service interruption. For further details please refer to http://g.co/dev/maps-no-account"

Having the same issue. I noticed a user mentioned the fix had to do with the address format you supply as 'your address' but I have not been able to figure out what that format is, yet!

Figured it out. I entered an address for the CN Tower in Toronto in Google maps.  I then took a look at the URL that was generated.  The address in question is:
301 Front Street W, Toronto ON M5V 2T6
and the URL writes it as:
+301+Front+St+W,+Toronto,+ON+M5V+2T6
Once I used the plus signs and cut and paste the address from the URL I was able to bypass this error. Hope this helps you NipBoss.

Thanks @zachatkinson


Make loaded,mounted and removed Futures on FlameGame instance working

Problem to solve

Knowing when the game has finished loading/mounting or was removed.
Although one can argue the removed Future isn't really useful, so we can omit this maybe.
Proposal

As Component already has the mounted,loaded,removed Futures with their respective Completers, we just need to access the completers _mountCompleter,_loadCompleter,_removeCompleter and mark them as completed. Right now these member variables are private and cannot be accessed by subclasses, so maybe we can introduce a protected getter for them.
For the mount case we can complete _mountCompleter in FlameGame.mount, after the super.mount() call.
For the loading case we can complete _loadCompleter in GameWidgetState.loaderFuture, before the game.mount() call.
One note: This way both _mountCompleter and _loadCompleter would complete before the mounting/loading bit is set through setMounted(), which is probably undesirable.
I think it would be best to make _finishLoading protected and introduce a similar function _finishMounting, which does the same things (set state bit, call completer). Then we can use these methods inside FlameGame to propagate loading/mounting completion events, and it would handle the state bits as well. The setMounted then is a bit unnecessary, as loading/mounting bits were already set (by _finishdLoading/_finishMounting), but setMounted is only used by FlameGame, so we can maybe change the behaviour or API there a bit.
We maybe could use the new _finishMounting function inside Component._mount as well, altough the order of _clearMountingBit and _setMountedBit are reversed there. Is there any reason why _mount does this:
// inside Component._mount:
    onMount();
    _setMountedBit();
    _mountCompleter?.complete();
    _mountCompleter = null;
    _parent!.children.add(this);
    _reAddChildren();
    _parent!.onChildrenChanged(this, ChildrenChangeType.added);
    _clearMountingBit();

instead of this:
// inside Component._mount:
    onMount();
    // clear mounting bit here instead of at the end
    _clearMountingBit();
    _setMountedBit();
    _mountCompleter?.complete();
    _mountCompleter = null;
    _parent!.children.add(this);
    _reAddChildren();
    _parent!.onChildrenChanged(this, ChildrenChangeType.added);

For the remove case i have no proposal yet, but it should be similar.
More information

The relevant methods are:
class Component {
  // [...]
  void _finishLoading() {
    _clearLoadingBit();
    _setLoadedBit();
    _loadCompleter?.complete();
    _loadCompleter = null;
  }
}

class GameWidgetState<T extends Game> extends State<GameWidget<T>> {
   // [...]
  Future<void> get loaderFuture => _loaderFuture ??= (() async {
        final game = currentGame;
        assert(game.hasLayout);
        final onLoad = game.onLoadFuture;
        if (onLoad != null) {
          await onLoad;
        }
        game.mount();
        if (!game.paused) {
          game.update(0);
        }
      })();
}

class FlameGame<W extends World> extends ComponentTreeRoot with Game implements ReadOnlySizeProvider {
  // [...]
  @override
  @internal
  void mount() {
    super.mount();
    setMounted();
  }
}

I can work on a PR for this.
This would unblock #2971.

Knowing when the game has finished loading/mounting or was removed.

I am unsure I understand why we need to change here, The futures mounted, loaded, etc exists exactly for that reason so you can know that already.
What am I missing?

Yeah, but exactly these futures (mounted, loaded, etc) are not working on the FlameGame instance, only on real Components. Thats what we try to fix now.

It should be possible to get it to go through the component lifecycle without having to add any methods.
The problem here is that the Game mixin can't call super.mount since it isn't applied on something that it knows has those methods, so we probably just need to create an interface that Component and Game implements so that mount and the rest of those lifecycle methods can be called.

It should be possible to get it to go through the component lifecycle without having to add any methods.

I am not entirely sure what you meant with "to get it to go through the component lifecycle".
In case you meant literally sharing the "component lifecycle methods" between Game and Component: i don't think this can be done easily. All lifecycle methods (Component.handleLifecycleEvent* and their called functions such as _mount, _startLoading, _remove, ...) are called through ComponentTreeRoot.processLifecycleEvents, which in turn is only called after the game finished loading and mounting. So the only thing that manages the component lifecycle of the game is GameWidgetState with its loaderFuture. Moreover, _mount for example assumes that this component is not the componentTreeRoot, by asserting _parent != null for example. Based on this knowledge i don't think we can share component lifecycle methods and their logic.
In the more probable case you meant to have some generalized mount/load, etc. methods in Component: i think this is a good idea. Though as stated above, we can't just simply use the existing component lifecycle methods in Component for the lifecycle management of Game. So we have to come up with some generalized lifecycle API in Component that can be reused/extended in Game. Maybe have some mount/load method which (only for mounting in this example):

calls _setMountingBit
calls _doMounting
calls clearMountingBit
calls _setMountedBit
calls _mountCompleter?.complete
sets _mountCompleter = null

with one new method _doMounting, which can be overridden by Component and Game to match the logic needs.
Currently i don't see a way to achieve the desired features without adding new methods, or at least without adding new internal methods.

I think the interface idea would probably have worked, but I had a quick look at the code yesterday and since its already using  setMounted when mounting the game, I figured we could just move the call to the completer in there and use that method inside of the component too. Will have a closer look at that today.

Alright, now they should be working in #3007 @tibotix, can you give it a try? :)

yes its working now. Thanks :)


Bug fix

Fixes #
Describe the changes you have made in this PR -
Screenshots of the changes (If any) -
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Coverage remained the same at 87.843% when pulling 676f5e23cee93fdf1f500e32a0b8183118884029 on Raghavan098:patch-1 into 4a422b37f94443eb0ba328a066715736b346082c on CircuitVerse:new_UI.


help request: parse in-telegram data / identifying esp format

Holger
in 2019 you helped me through the transition from FHEM into node-red with my eltako enocean devices.
I could still use some help though, with the parsing/identification of the incoming status telegrams, since Eltako telegrams seem to be very proriatry ...
It is therefor not always possible to just "teach-in" a device with its id and the eep (like f6-01-01).
I basically just need a hint on how (programatically, within a function node) I could parse/dissect the incoming telegrams into usable parts.
Maybe you find some time for this ?

sorry for the very long delay... i do have some more time now...


✨ feat: add an option to reset to default document title on unmount for useDocumentTitle

Close #345

Thanks for the review and the merge @juliencrn 😃


Cannot build release

The following error happens when attempting to compile:
% cargo build --release
  Downloaded rand_chacha v0.2.2
  Downloaded unicode-width v0.1.5
  Downloaded libc v0.2.69
  Downloaded getopts v0.2.18
  Downloaded 4 crates (519.8 KB) in 7.06s
   Compiling libc v0.2.69
   Compiling getrandom v0.1.14
   Compiling cfg-if v0.1.10
   Compiling ppv-lite86 v0.2.6
   Compiling unicode-width v0.1.5
   Compiling getopts v0.2.18
   Compiling rand_core v0.5.1
   Compiling rand_chacha v0.2.2
   Compiling rand v0.7.3
   Compiling markovpass v1.0.1 (/home/aaron/src/markovpass)
error[E0554]:  may not be used on the stable release channel
 --> src/main.rs:1:1
  |
1 | #![feature(test)]
  | ^^^^^^^^^^^^^^^^^

error: aborting due to previous error

For more information about this error, try Feature attributes are only allowed on the nightly release channel. Stable or
beta compilers will not comply.

Erroneous code example:

```
#![feature(non_ascii_idents)] // error: `#![feature]` may not be used on the
                              //        stable release channel
```

If you need the feature, make sure to use a nightly release of the compiler
(but be warned that the feature may be removed or altered in the future)..
error: could not compile .

To learn more, run the command again with --verbose.

Commenting out #![feature(test)] from src/main.rs and extern crate test; from src/lib/mod.rs allows the build to succeed.

I need to dig into this. Last I checked the #[feature(test)] is required for the benchmarking code to work, but I guess it only works on nightly.
So for the moment, I guess this only works on nightly. It probably doesn't make sense to require nightly just for the benchmarking though. I'll see what I can do!

Ok! This should be fixed. I ended up gating the benchmarking code behind a feature so that it can be manually run using cargo bench --feature benchmarks, but the benchmarking support won't get built by default.
I would like a way to make the gating automatic on being on nightly, but it looks as if there's not a good option for that.


zeros_like problems

I tried to implement a constructor similar to numpys zeros_like.
I added the following code.
pub fn zeros_like(array: ArrayBase<S, D>) -> ArrayBase<S, D>
        where A: Clone + Zero,
    {
        Self::zeros(array.shape())
    }

But it complains about some trait bounds that I do not understand.
   Compiling ndarray v0.6.0 (file:///Users/paul/rust/rust-ndarray)
src/impl_constructors.rs:166:9: 166:20 error: the trait bound `Shape<D>: std::convert::From<&[usize]>` is not satisfied [E0277]
src/impl_constructors.rs:166         Self::zeros(array.shape())
                                     ^~~~~~~~~~~
src/impl_constructors.rs:166:9: 166:20 help: run `rustc --explain E0277` to see a detailed explanation
src/impl_constructors.rs:166:9: 166:20 help: the following implementations were found:
src/impl_constructors.rs:166:9: 166:20 help:   <Shape<D> as std::convert::From<D>>
src/impl_constructors.rs:166:9: 166:20 note: required because of the requirements on the impl of `std::convert::Into<Shape<D>>` for `&[usize]`
src/impl_constructors.rs:166:9: 166:20 note: required by `impl_constructors::<impl ArrayBase<S, D>>::zeros`
error: aborting due to previous error
error: Could not compile `ndarray`.

Can anyone give me some hints on how to resolve this?

shape() but the constructors need a value that fits the D parameter (a tuple or Vec). You'd use the .dim() method to get that.


HBASE-24079 [Flakey Tests] Misc fixes and debug; fix BindException in…

… Thrift tests; add waits on quota table to come online; etc.
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientAsyncPrefetchScanner.java
Refactor to avoid NPE timing issue referencing lock during Construction.
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
Comment
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java
Refactor. Catch NPE during startup and return it instead as failed initialization.
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java
Catch IndexOutOfBounds exception and convert to non-split request.
hbase-server/src/test/java/org/apache/hadoop/hbase/TestCachedClusterId.java
Make less furious. Make it less flakie.
hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerSideScanMetricsFromClientSide.java
Debug. Catch exception to log, then rethrow.
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncRegionAdminApi.java
Guess that waiting longer on compaction to succeed may help make this
less flakey.
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java
Be explicit about timestamping to avoid concurrent edit landing
server-side and messing up test expectation.
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMasterRegistry.java
Add wait on meta before proceeding w/ test.
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestScannersFromClientSide.java
Be explicit that edits are distinct.
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCacheRefCnt.java
Add @Ignore on RAM test... Fails sporadically.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionMoveAndAbandon.java
Add wait for all RegionServers going down before proceeding; was
messing up RS accounting.
hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/BalancerTestBase.java
Make balancer test sloppier; less restrictive; would fail on occasion
by being just outside test limits.
hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaObserverChoreRegionReports.java
Add wait on quota table coming up; helps make this less flakie.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
Be explicity about timestamps; see if helps w/ flakie failure.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicas.java
Catch and ignore if issue in shutdown; don't care if after test.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerReportForDuty.java
Comment.
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java
Add retry to see if helps w/ odd failure; grant hasn't propagated?
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestCellACLWithMultipleVersions.java
Explicit w/ timestamps so no accidental overlap of puts.
hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftHttpServer.java
hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java
Hack to deal w/ BindException on startup.
hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThrift2ServerCmdLine.java
Use loopback.
hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
Disable flakie test.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 52s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
8m 59s
branch-2 passed

+1 :green_heart:
checkstyle
3m  2s
branch-2 passed

+1 :green_heart:
spotbugs
5m 34s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
8m  1s
the patch passed

+1 :green_heart:
checkstyle
0m 40s
hbase-client: The patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)

-0 :warning:
checkstyle
1m 31s
hbase-server: The patch generated 3 new + 174 unchanged - 8 fixed = 177 total (was 182)

-0 :warning:
checkstyle
0m 52s
hbase-thrift: The patch generated 2 new + 5 unchanged - 1 fixed = 7 total (was 6)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
16m 45s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.

-1 :x:
spotbugs
2m 57s
hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
asflicense
0m 43s
The patch does not generate ASF License warnings.

67m 35s

Reason
Tests

FindBugs
module:hbase-server

Possible null pointer dereference of r in org.apache.hadoop.hbase.regionserver.CompactSplit.requestSplit(Region)  Dereferenced at CompactSplit.java:r in org.apache.hadoop.hbase.regionserver.CompactSplit.requestSplit(Region)  Dereferenced at CompactSplit.java:[line 203]

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1388

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux e209afe85a3f 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 227bcaeb88

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt

spotbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/1/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html

Max. process+thread count
84 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-thrift U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/1/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 48s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 32s
branch-2 passed

+1 :green_heart:
compile
1m 59s
branch-2 passed

+1 :green_heart:
shadedjars
4m 51s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 35s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 18s
the patch passed

+1 :green_heart:
compile
1m 58s
the patch passed

+1 :green_heart:
javac
1m 58s
the patch passed

+1 :green_heart:
shadedjars
4m 35s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 32s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m  5s
hbase-client in the patch passed.

-1 :x:
unit
66m 12s
hbase-server in the patch failed.

+1 :green_heart:
unit
2m 20s
hbase-thrift in the patch passed.

102m 13s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1388

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 24dddb0528a2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 227bcaeb88

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/1/testReport/

Max. process+thread count
5077 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-thrift U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/1/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  9s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
10m  3s
branch-2 passed

+1 :green_heart:
compile
3m 27s
branch-2 passed

+1 :green_heart:
shadedjars
8m 25s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 42s
hbase-client in branch-2 failed.

-0 :warning:
javadoc
0m 59s
hbase-server in branch-2 failed.

-0 :warning:
javadoc
1m 20s
hbase-thrift in branch-2 failed.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
9m 46s
the patch passed

+1 :green_heart:
compile
2m 43s
the patch passed

+1 :green_heart:
javac
2m 43s
the patch passed

+1 :green_heart:
shadedjars
6m 24s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 29s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 41s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 55s
hbase-thrift in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
2m 18s
hbase-client in the patch passed.

-0 :warning:
unit
68m 50s
hbase-server in the patch failed.

+1 :green_heart:
unit
2m 27s
hbase-thrift in the patch passed.

124m 51s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1388

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d25af8db0073 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 227bcaeb88

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/1/testReport/

Max. process+thread count
5745 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-thrift U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/1/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 19s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
6m  5s
branch-2 passed

+1 :green_heart:
checkstyle
2m 42s
branch-2 passed

+1 :green_heart:
spotbugs
4m 41s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 40s
the patch passed

+1 :green_heart:
checkstyle
0m 35s
hbase-client: The patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)

-0 :warning:
checkstyle
1m 18s
hbase-server: The patch generated 3 new + 178 unchanged - 8 fixed = 181 total (was 186)

-0 :warning:
checkstyle
0m 46s
hbase-thrift: The patch generated 2 new + 5 unchanged - 1 fixed = 7 total (was 6)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 50s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.

-1 :x:
spotbugs
2m 18s
hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

48m 55s

Reason
Tests

FindBugs
module:hbase-server

Possible null pointer dereference of r in org.apache.hadoop.hbase.regionserver.CompactSplit.requestSplit(Region)  Dereferenced at CompactSplit.java:r in org.apache.hadoop.hbase.regionserver.CompactSplit.requestSplit(Region)  Dereferenced at CompactSplit.java:[line 203]

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1388

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 6f4acd1c8497 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 34ebdd6c9d

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt

spotbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/2/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html

Max. process+thread count
83 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-thrift U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/2/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 34s
branch-2 passed

+1 :green_heart:
compile
1m 59s
branch-2 passed

+1 :green_heart:
shadedjars
4m 31s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 36s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 16s
the patch passed

+1 :green_heart:
compile
2m  0s
the patch passed

+1 :green_heart:
javac
2m  0s
the patch passed

+1 :green_heart:
shadedjars
4m 30s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 33s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m  7s
hbase-client in the patch passed.

+1 :green_heart:
unit
65m  6s
hbase-server in the patch passed.

+1 :green_heart:
unit
2m 17s
hbase-thrift in the patch passed.

100m 17s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1388

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6ccb43dc0226 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 34ebdd6c9d

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/2/testReport/

Max. process+thread count
5358 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-thrift U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/2/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

New push. Fixes checkstyles and findbugs. Includes accommodation of the helpful @bharathv review (Thanks for the review!)

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m  0s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
8m 46s
branch-2 passed

+1 :green_heart:
compile
2m 43s
branch-2 passed

+1 :green_heart:
shadedjars
6m 34s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 29s
hbase-client in branch-2 failed.

-0 :warning:
javadoc
0m 41s
hbase-server in branch-2 failed.

-0 :warning:
javadoc
0m 59s
hbase-thrift in branch-2 failed.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
6m 49s
the patch passed

+1 :green_heart:
compile
2m 24s
the patch passed

+1 :green_heart:
javac
2m 24s
the patch passed

+1 :green_heart:
shadedjars
5m 53s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 27s
hbase-client in the patch failed.

-0 :warning:
javadoc
0m 40s
hbase-server in the patch failed.

-0 :warning:
javadoc
0m 56s
hbase-thrift in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
2m 21s
hbase-client in the patch passed.

+1 :green_heart:
unit
104m 42s
hbase-server in the patch passed.

+1 :green_heart:
unit
2m 42s
hbase-thrift in the patch passed.

153m 58s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1388

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 21a437c68a01 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 34ebdd6c9d

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/2/testReport/

Max. process+thread count
4196 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-thrift U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/2/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 29s
branch-2 passed

+1 :green_heart:
checkstyle
2m 28s
branch-2 passed

+1 :green_heart:
spotbugs
4m 21s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  7s
the patch passed

+1 :green_heart:
checkstyle
0m 32s
hbase-client: The patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)

+1 :green_heart:
checkstyle
1m 12s
hbase-server: The patch generated 0 new + 171 unchanged - 15 fixed = 171 total (was 186)

+1 :green_heart:
checkstyle
0m 43s
hbase-thrift: The patch generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
10m 34s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.

+1 :green_heart:
spotbugs
4m 48s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 37s
The patch does not generate ASF License warnings.

44m 33s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1388

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux b38341d8832f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 34ebdd6c9d

Max. process+thread count
93 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-thrift U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/3/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Nice @bharathv  Let me add it in and then push up new patch...

Or, just let me push this w/ the above amendment.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 22s
branch-2 passed

+1 :green_heart:
compile
2m  1s
branch-2 passed

+1 :green_heart:
shadedjars
4m 34s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 31s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 21s
the patch passed

+1 :green_heart:
compile
1m 58s
the patch passed

+1 :green_heart:
javac
1m 58s
the patch passed

+1 :green_heart:
shadedjars
4m 33s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 32s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m  6s
hbase-client in the patch passed.

-1 :x:
unit
108m 40s
hbase-server in the patch failed.

+1 :green_heart:
unit
3m 17s
hbase-thrift in the patch passed.

145m  3s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1388

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 67010c0659bd 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 34ebdd6c9d

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/3/testReport/

Max. process+thread count
5168 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-thrift U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/3/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
6m 43s
branch-2 passed

+1 :green_heart:
compile
2m 28s
branch-2 passed

+1 :green_heart:
shadedjars
5m 38s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 30s
hbase-client in branch-2 failed.

-0 :warning:
javadoc
0m 40s
hbase-server in branch-2 failed.

-0 :warning:
javadoc
0m 51s
hbase-thrift in branch-2 failed.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
6m 16s
the patch passed

+1 :green_heart:
compile
2m 20s
the patch passed

+1 :green_heart:
javac
2m 20s
the patch passed

+1 :green_heart:
shadedjars
6m 11s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 44s
hbase-client in the patch failed.

-0 :warning:
javadoc
1m  2s
hbase-server in the patch failed.

-0 :warning:
javadoc
1m 17s
hbase-thrift in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
2m 46s
hbase-client in the patch passed.

-0 :warning:
unit
109m 37s
hbase-server in the patch failed.

+1 :green_heart:
unit
2m 28s
hbase-thrift in the patch passed.

153m 52s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1388

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 91bf842e7dcf 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 34ebdd6c9d

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/3/testReport/

Max. process+thread count
5802 (vs. ulimit of 10000)

modules
C: hbase-client hbase-server hbase-thrift U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1388/3/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Merged manually. Closing. Thanks for reviews @bharathv


crypto/x509: untrusted intermediates are not used on macOS

What version of Go are you using (go version)?

$ go version
go version go1.13.4 darwin/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/xhp9/Library/Caches/go-build"
GOENV="/Users/xhp9/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/xhp9"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.13.4/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.13.4/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/xhp9/src/github.com/nordstrom/kubelogin/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/qy/p4t6xtws5yv8llv3wg15ck9rztrl8v/T/go-build395049258=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
Open http connection to a remote server using internal certificate. Web browsers have no issue accepting the certificate.
A workaround is to set the issuing CA to Always Trust in the keychain. Using system defaults does not work.
Basically this seems to be the same issue as https://github.com/golang/go/issues/30471 or https://github.com/golang/go/issues/30672 except I get a failure even with CGO_ENABLED=0.
What did you expect to see?
No error.
What did you see instead?
x509: certificate signed by unknown authority

@FiloSottile I think we're still having issues with certificate trust settings on mac os.

Thanks for the report, can you give us the output of GODEBUG=x509roots=1 go test -v -run TestSystemRoots crypto/x509?

The test passes in both cases. However, when the certificate is set to "Use System Defaults" it does not even appear in the debug output. It does appear when set to "Always Trust."

I'm experiencing the same issue on macOS Mojave, running go 1.13.4.
The certificate chain in our environment has two intermediate CAs between the Root CA and the site certificate. If the site certificate's issuing CA isn't marked as Always Trusted, then trust isn't inherited, even though the Root CA is always trusted.
I was going to post the code snippet that was failing, but even just http.Get("https://www.google.com") fails with the same error.

@EmberQuill is the intermediate served by the TLS server, or is it relying on finding it in the keychain? Because that's something we don't do (and maybe should): take untrusted certificates from the keychain and pour them into the intermediates pool.
As a workaround you can make sure the server provides a full chain to the root.

It's an issue with my employer's local network rather than the site I'm trying to access. Our network proxy performs TLS inspection, so traffic ends up signed by an internal CA, and the root and intermediaries are all in the Keychain. The Root CA is always trusted, but the two intermediate CAs are set to "Use System Defaults" in the Keychain and thus trigger this error in Go.
Changing the intermediate CAs to Always Trusted is a sufficient workaround for me.

Can you confirm that the proxy doesn't send the intermediate in the TLS handshake?

I thought I saw an overhaul to how Go interacts with the keychain, but lost the link. Would that change solve this issue?

CL 227037 changed how the macOS API is called, but didn't change how intermediates in the keychain are treated, they are still ignored.

Coming here from #40370. I have a user claiming x509: certificate signed by unknown authority from inside a docker container. Same image is working fine for me, user says no proxy installed. Might there be more causes than Mac API?

@andig If this is inside a Docker container, it's a different issue, this issue is about macOS (and Docker runs Linux).
(You should check what certificate chain the Docker container is served. Docker being Docker, this is likely to be a proxy the user is unaware of.)

You should check what certificate chain the Docker container is served

Sorry for the OT response- any hint how I would do that? The confusing part here is that the image works fine for me...

@andig You'd make your application print the PeerCertificates, and check if they match the ones that you see when things work correctly. If not, they might point to what proxy is involved. If you need more help with that, you can try the golang-nuts mailing list or the crypto channel on the Gophers Slack.


New changes for g10

This is a g10 certification example with auth0 as the IDP. Was able to get all tests passing with the following configurations.
The fhir-server used is the SMART-LINE branch from aws-fhirwork
The environment context are:

US CORE 3.1.1
SMART-LINE v3.1.1

changes:

bumps node versions (12 is being deprecated)
adds additional capability statements (may not be necessary if generated via FWOA router package)
handles g10 ehr launch sequence
handles practitioner scope without picking a specific patient.

I agree we'll probably want a separate branch- while I think I could easily merge in nearly all of this- there are a few areas that I'd like to generalize a bit before putting into the main branch.


feat: adds release drafter

Summary

Adds release drafter action and config file to draft GitHub releases with change notes generated on PR merges

How-to Use
Configuration
.github/release-drafter-conig.yml configures the format and behavior of release drafter according to configuration parameters (see configuration-options)
Change note categories are drafted based on labels applied to PRs. The current config will put changes under three categories (Features, Bug Fixes, or Maintenance) based on labels and all unlabeled PRs are categorized under a generic Changes.
Auto labeling
There is an autolabeler config that will automatically label PRs that use conventional commit types (e.g. fix, feat, chore, etc.) in the PR title or branch name with the appropriate label so that the changes are categorized in the release draft appropriately
Releasing
To publish a drafted release. Edit the release in GitHub releases, manually format anything if desire and then publish release. For signed tags, push the appropriate signed tag for the drafted release prior to publishing (or the release tag will be signed by GitHub)
If there are any other workflows that need to run during a release, they can be triggered with the release event.

resolves https://github.com/openpubkey/openpubkey/issues/165

It looks like the CI check will fail until the config file is merged to main.

Error: Configuration file .github/release-drafter-config.yml is not found. The configuration file must reside in your default branch.

Let me know when this is ready for a review and merge. Looking forward to getting this in

Let me know when this is ready for a review and merge. Looking forward to getting this in

It's good to go! 👍


Adv usage docs

Current coverage is 100% (diff: 100%)

Merging #125 into master will not change coverage

@@           master   #125   diff @@
====================================
  Files           7      7
  Lines         139    139
  Methods         0      0
  Messages        0      0
  Branches        0      0
====================================
  Hits          139    139
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update 88b9e3a...c3d6b37

I did make html and got:
sphinx-build -b html -d _build/doctrees   . _build/html
Running Sphinx v1.4.5
making output directory...

Extension error:
Could not import extension sphinxcontrib.autorun (exception: No module named 'sphinxcontrib.autorun')
make: *** [html] Error 1

I was able to fix that by adding:
sphinxcontrib-autorun

to the list of packages in requirements.txt.

:+1:

:+1:


Support inverting autoselection

Proposed improvement description
Basically, you could do this by allowing the autoselection field to accept negative numbers (either percentages or numbers of features, depending on what's selected). This would work the same as with the corresponding positive number, but instead the numerator and denominator would be flipped.
As an example, if you do auto-selection right now of the top and bottom 10% in the example red sea dataset temperature differentials, you get this:

With this proposed functionality, you'd also be able to put down -10% to instead make the numerator be the bottom 10% and the denominator be the top 10% (essentially, just flipping the log-ratio around).
As a result, you'd just see the same plot but flipped vertically -- i.e. with a negative rather than a positive correlation. This could be useful in a few cases.
Considerations
This isn't that important of a feature to add (doubly so if #247 can get done first, since this is really just an easier way to do that sort of stuff), but it could be cool.
One last thing -- we'd need to document this functionality well to make sure people even know that this is a feature and not a bug. I imagine the autoselection tooltips (see #225) should mention this.

Just for reference, here's what this looks like on the same dataset as above in practice:


Add Dolma Counter script

This PR adds a new dolma processor that can be used to count the number of (whitespace delimited) tokens in a data source.
You can point it at a directory and it will find all the .jsonl.gz files in it or it's subdirectories.
It can be used from the root dir via python -m licensed_pile.count or from anywhere with count-tokens-dolma.
One weird aspect is that it uses prefixed like giga or tera "tokens" instead of a billion, a trillion, etc.

One weird aspect is that it uses prefixed like giga or tera "tokens" instead of a billion, a trillion, etc.

Thats just what tqdm defaults to if you use unit_scale = True iirc

You're right, it not really configurable in dolma tho https://github.com/allenai/dolma/blob/64886d9db15bd99acea9e28740ae20a510875dfb/python/dolma/core/parallel.py#L268
I think it fine to leave it as is lol, plus the unit_divisor defaults to 1000 https://github.com/tqdm/tqdm?tab=readme-ov-file#parameters so it'll give us the right values :woman_shrugging:

Very cool, thank you for doing this. Since "token" is sort of an overloaded term, and since I'm suggesting you also report the decompressed text-only (non-json-overhead) byte count, perhaps we can call this something about "size statistics" instead of tokens.


Storage: Get only files of certain type from directory

Hey,
I did not find it, so please let me know if it is already possible. I think it would be useful, to get the possibility to retrieve only files of a certain type from a folder.
I see two possibilities, either:
Storage::files('articles', true, ['md','txt'])

or with read:
Storage::read('articles/*.md')

I think this would be very helpful. Cheers.

Something like this could work?
/**
     * Get an array of all files in a directory.
     *
     * @param  string  $directory
    *  @param  array  $extensions
     * @return array
     */
    public function files($directory, $extensions = [])
    {
        $pattern = $directory.'/*';
        $flags = 0;

        if ($extensions) {
            $pattern .=  '{' . implode(',', $extensions) . '}';
            $flags = GLOB_BRACE;
        }

        $glob = glob($pattern, $flags);

Maybe I am getting your wrong @StefanPrintezis  but this is just a method, without using Storage, or are suggesting this as an implementation to make this possible with storage?

The issues here are strictly for bugs only please.


Remove project recipe reference in audit recipe

Description
Removed the reference that audit recipe is doing to the project recipe. This will avoid future duplication of variables at variables.tf and terraform.tfvars

The description says it removes references to the project recipe, but in the first file I see
name = var.project.project_id

Am I misunderstanding the description?

/gcbrun

/gcbrun


concurrent logging files empty

Hello,
We are running ModSecurity@1edd3570e11e9bb2b6d86b249232b24917a4b0ac and ModSecurity-nginx@abbf2c47f6f3205484a1a9db618e067dce213b89 with nginx 1.13.1.
I'm attaching the rule set + modsecurity configuration as well.
From the SecAuditLog:
www.cyberprosconsulting.com <IP_ADDRESS> - - [25/Aug/2017:04:02:37 +0000] "GET / HTTP/1.1" 200 16384 - "Pingdom.com_bot_version_1.4_(http://www.pingdom.com/)"<PHONE_NUMBER>66.543193 - /var/log/nginx/modsec_audit/33062/12763/20170825/20170825-0402/20170825-040237-150363375766.543193 0 0.000000 md5:d41d8cd98f00b204e9800998ecf8427e

The files that appear are all zero bytes, which modsecurity appears to understand/expect as it says its writing 0 bytes and the md5 hash is d41d8... (the md5 hash of an empty string).
rules.zip

Make sure you have YAJL support enabled, otherwise the logs file will be empty.

https://github.com/SpiderLabs/ModSecurity/wiki/Reference-Manual#secauditlogformat
Does this option no longer exist at all for ModSecurity 3 with the only option being for json-format logging?

Hi @AdamJacobMuller This option is available on the latest version. You can choose between JSON and old native format. Also, you can compile libModSecurity to support the JSON. Just install the yajl developer packages and re-compile libModSecurity. The compilation process should detect the developer packages and enable the support by default.

hi @zimmerle,
I'm not even seeing the keyword SecAuditLogFormat in the source for v3/master, should I be using another branch?


Refactor and add tests

PR uses https://github.com/nickschuch/puppet-rancher/pull/5 by @petems as a starting point.
Fixes tests.
Newer boilerplate.
v4-compatible spec_helper_acceptance.rb
rancher::node fails compilation if empty input provided.
Updated nodeset for latest PL CentOS 7 box (CentOS 7.2).
Removes Gemfile.lock from git.
Modified .travis.yml.

Thanks, @alexharv074 That's a real big improvement.

@alexharv074 Looks good! Got some questions about some of your changes, but I agree with most of it! :smile:

Ok, I just had a look into the puppet install helper gem.  It's controlled by environment variables by the looks of it.  I'll refactor to use the puppet install helper.  Glad someone's finally cleared this up for me. :)

@petems   I have rebased including most of your suggestions.

Is there any agreed upon version of .travis.yml ?  All the Puppet Labs modules seem to have something different in there.

This serverspec test is failing:

    describe docker_container('rancher/server') do
      it { is_expected.to be_running }
    end

I believe there's a bug in serverspec and I'm still investigating.

I'm awaiting feedback re: expected output from curl <IP_ADDRESS>:8080.  I'm getting this and I'd like someone who knows more about Rancher to advise:

{
  "type": "collection",
  "resourceType": "apiVersion",
  "links": {
    "self": "http://<IP_ADDRESS>:8080/",
    "latest": "http://<IP_ADDRESS>:8080/v1"
  },
  "createTypes": {},
  "actions": {},
  "data": [
    {
      "id": "v1",
      "type": "apiVersion",
      "links": {
        "self": "http://<IP_ADDRESS>:8080/v1"
      },
      "actions": {}
    }
  ],
  "sortLinks": {},
  "pagination": null,
  "sort": null,
  "filters": {},
  "createDefaults": {}
}

Still to do, I see the build is still broken and I'll investigate why.  Probably because I'm testing against old Puppets.

Ok, to the Serverspec bug.
I have confirmed that a new feature is to be released in Docker 1.11 release notes:

docker inspect now also returns a new State field containing the container state in a human readable way (i.e. one of created, restarting, running, paused, exited or dead)(#18966)

The version of Docker that has installed is 1.10.3 and it doesn't have this feature.
Meanwhile Serverspec has a method running? here that assume that the State field already exists.
The really weird part is that this was added into Serverspec on Oct 12, 2014.
I am tempted to simply not do this test, or use a command instead.
Any feedback on this would be welcome, as this doesn't make any sense to me.

Ok, I have removed the troublesome test, which is really redundant anyway considering the test that follows it.

@petems @nickschuch  AFAICT, the only outstanding issue is Pete's expectation that curl <IP_ADDRESS>:8080 should contain /\<title>rancher<\/title>/ whereas I'm really seeing what I posted above.

Oh, I should add that Rancher seems to be working fine when I point a browser at port 8080.

Yeah it is working, when I test it, it's running. But depending on the speed of your VM it might not be ready at the time of the spec running.
For example, see my history of it not running during the test, but OK a few seconds after the acceptance test:
Failures:

  1) rancher::management puppet apply is expected to be running on the default port Command "curl <IP_ADDRESS>:8080" stdout should match /self.*<IP_ADDRESS>:8080/
     Failure/Error: its(:stdout) { is_expected.to match /self.*<IP_ADDRESS>:8080/ }
       expected "" to match /self.*<IP_ADDRESS>:8080/
       Diff:
       @@ -1,2 +1,2 @@
       -/self.*<IP_ADDRESS>:8080/
       +""

     # ./spec/acceptance/management_spec.rb:22:in `block (5 levels) in <top (required)>'

Finished in 2 minutes 55.2 seconds (files took 1 minute 35.4 seconds to load)
2 examples, 1 failure

Failed examples:

rspec ./spec/acceptance/management_spec.rb:22 # rancher::management puppet apply is expected to be running on the default port Command "curl <IP_ADDRESS>:8080" stdout should match /self.*<IP_ADDRESS>:8080/

10:38:25  ! ~/projects/puppet-rancher (refactor_2 *$) $ cd .vagrant/beaker_vagrant_files/default.yml/
10:42:45 ~/projects/puppet-rancher/.vagrant/beaker_vagrant_files/default.yml (refactor_2 *$) $ vagrant ssh centos-72-x64
Last login: Fri Apr  1 09:35:15 2016 from <IP_ADDRESS>
[vagrant@centos-72-x64 ~]$ sudo -s
[root@centos-72-x64 vagrant]# curl <IP_ADDRESS>:8008
curl: (7) Failed connect to <IP_ADDRESS>:8008; Connection refused
[root@centos-72-x64 vagrant]# curl <IP_ADDRESS>:8080
{"type":"collection","resourceType":"apiVersion","links":{"self":"http://<IP_ADDRESS>:8080/","latest":"http://<IP_ADDRESS>:8080/v1"},"createTypes":{},"actions":{},"data":[{"id":"v1","type":"apiVersion","links":{"self":"http://<IP_ADDRESS>:8080/v1"},"actions":{}}],"sortLinks":{},"pagination":null,"sort":null,"filters":{},"createDefaults":{}}[root@centos-72-x64 vagrant]# exit
exit
[vagrant@centos-72-x64 ~]$ exit
logout
Connection to <IP_ADDRESS> closed.

@petems
I set up the following test to establish whether Liam's code works:
  describe command('date') do
    it {
      t = Time.now; puts "Sleeping at #{t}"; sleep 10
      o = subject.stdout; puts "subject.stdout is #{o}"
    }
  end

The output I got:
  Command "date"
Sleeping at 2016-04-03 00:59:52 +1100

centos-72-x64 01:00:02$ /bin/sh -c date
  Sat Apr  2 14:00:01 UTC 2016

centos-72-x64 executed in 0.01 seconds
subject.stdout is Sat Apr  2 14:00:01 UTC 2016

Accordingly I believe I can write the test using:
    context 'is expected to be running on the default port' do
      describe command('curl <IP_ADDRESS>:8080') do
        it {
          sleep 5 # Give Rancher time to start.
          expect(subject.stdout).to match /self.*<IP_ADDRESS>:8080/
        }
      end
    end

Hmm ok. Are you running the acceptance tests locally? It doesn't seem to work when I try.

I'm not sure what you mean by running the tests locally?  I only know one way to run them.  Do you mean you tried the exact same code and got a different result?

Ah, sorry about that, I misread, I just tried pulling from this PR and re-running it and still got the error. Didnt realise you'd not added in the updated code above yet! :smile:
I'm just running it now with the updated code, it looks like it does work from your test, I must've written it wrong in my test or there's something different about my setup that causes the sleep not to work.

Ok, just ran with Vagrant and still got the failure using the code from above:
context 'is expected to be running on the default port' do
      describe command('curl <IP_ADDRESS>:8080') do
        it {
          sleep 30 # Give Rancher time to start.
          expect(subject.stdout).to match /self.*<IP_ADDRESS>:8080/
        }
      end
    end

Perhaps you could add in the time-related puts statements to establish if it's failing because of timing or something else?

I changed it to the following code:
    describe command('date') do
      it {
        t = Time.now; puts "Sleeping at #{t}"; sleep 10
        o = subject.stdout; puts "Before subject.stdout is #{o}"
      }
    end

    context 'is expected to be running on the default port' do
      describe command('curl <IP_ADDRESS>:8080') do
        it {
          sleep 30 # Give Rancher time to start.
          expect(subject.stdout).to match /self.*<IP_ADDRESS>:8080/
        }
      end
    end

    describe command('date') do
      it {
        t = Time.now; puts "Sleeping at #{t}"; sleep 10
        o = subject.stdout; puts "After subject.stdout is #{o}"
      }
    end

    context 'is expected to be running on the default port (after the previous sleep)' do
      describe command('curl <IP_ADDRESS>:8080') do
        it {
          sleep 30 # Give Rancher time to start.
          expect(subject.stdout).to match /self.*<IP_ADDRESS>:8080/
        }
      end
    end

And it passed successfully, but I think that's because the sleep happens in a separate rspec subject, and I'm not sure the benefit between doing the sleep within the machine or doing it as a sleep outside in a seperate block. It's your call, I'm cool with either as long as the test passes! :smile:

@alexharv074 To make things easier, I PR'd to add the ability to run the acceptance tests in Travis automatically (docker in docker in docker... inception) https://github.com/alexharv074/puppet-rancher/pull/1
When that's merged it should make proving the acceptance tests work easier :+1:

To be honest I'm having trouble getting it to work too but seems like it's another issue.  I'm going to play around a bit more tomorrow (2.10am here in Sydney!).    I like rspec, and that kind of issue will cause me to dislike it! :)

No worries! I don't think it's an issue with rspec tbh, probably with the way beaker-rspec handles the examples.
I also forgot to add in the new acceptance spec rake task, so just PR'd a new one: https://github.com/alexharv074/puppet-rancher/pull/2

Ok, I timed it.  It took 42 seconds for Rancher to start up.  Now that I've set the wait time to 1 minute it seems fine.

Ok, looks like the outstanding issue is the build's red because our new docker in docker in docker in Travis isn't working.

Now the build is failing with:
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
The build has been terminated

Investigating ways to raise the time out.

tbh, it's possible that you can't run docker in docker in docker inside travis instances...
I say, leave the acceptance tests in for people to run manually to confirm things are working, remove them from the travis.yml and get this merged in. We can investigate the feasibility of doing the acceptance tests as part of Travis afterwards :+1:

I agree. This is WAY more than what we had before, happy to see the acceptance tests get debugged in a seperate PR.

I also agree, and feel free to merge from my end.

I also agree, and feel free to merge.


[Feature] Being able to edit the range of event in week view

Your calendar is awesome, modern, pretty, works great.
I would be very happy to implement it for my company. But they require to be able to edit the range of an event on the week view (like FullCalendar kinda).
Do you plan to implement it anytime ?
Thanks in advance !

The library used for drag and drop also supports resizing of objects as well so I guess it wouldn't be too difficult to implement. Will try and find some time over the weekend to add it.

Done in https://github.com/mattlewis92/angular-bootstrap-calendar/commit/fba268747a311fb519b82dcd99b30c9c2e5c3279 and will be released in 0.12


Correction for raw affiliation Department of Toegepast Praktijkonderzoek, Aeres University of Applied Sciences, De Drieslag 4, NL, 8251 JZ Dronten, Netherlands

Correction needed for raw affiliation Department of Toegepast Praktijkonderzoek, Aeres University of Applied Sciences, De Drieslag 4, NL, 8251 JZ Dronten, Netherlands
raw_affiliation_name: Department of Toegepast Praktijkonderzoek, Aeres University of Applied Sciences, De Drieslag 4, NL, 8251 JZ Dronten, Netherlands
new_rors: 03jnx2c74
previous_rors: 015d5s513
works_examples: W4283808096
contact: 94bc11a4c6bcff7065f5fe1387f63a8b:8ccdd8291bd76bd7 @ aeres.nl

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


Reference Viewer

Is there a way to access the Reference Viewer or even just find out if an asset is referenced by any other objects via UEPython? This would be handy to find unused assets in a project. Thanks.

Assets dependencies/references functions have been added:
https://github.com/20tab/UnrealEnginePython/blob/master/docs/ManagingAssets.md#asset-dependenciesreferencers


Schema compare against project shows differences that are not when comparing against dacpac

Azure Data Studio Version:
OS Version:

Steps to Reproduce:

Create db project from AdventureWorks 2019
Open Schema compare
compare the project with db
Expected: no differences
Actual:
Extended property is different:
EXECUTE sp_addextendedproperty @name = N'MS_Description', @value = N'AdventureWorks 2016 Sample OLTP Database';
GO

Does this issue occur when all extensions are disabled?: Yes/No

Investigation: does this repro in SSDT as well?  I suspect it's resulting from how DacFx builds the model from loose script files.

closing as I'm not able to repro this. Might have been fixed by https://github.com/microsoft/sqltoolsservice/pull/1727


don't use octal escapes

they are deprecated and will be removed in Scala 2.13
this came up at https://github.com/scala/scala/pull/6324

LGTM, we should pull this change into 3.1.x and 3.2.x branch after it is merged into 3.0.x.

the Travis timeout appears unrelated


Does make sense to have a base class for EventBroker, CommandBroker and CommandReplyBroker

Currently, there is an abstract base class in minos.common  known as MinosBaseBroker with an abstract method send(...). This base class is used in minos.network as the base class for the corresponding brokers (the ones for Event, Command and CommandReply).
As the reason this abstract class exists is to be used by another modules different than minos.networks (like minos.common in the Aggregate class o minos.saga in the PublishExecutor class) with different purposes (the first case is to publish events but the second one is to publish commands that may have a counterpart response).
So, thinking about the objective of each broker call, I propose to have separate base classes for each one in order to enforce that (at least at typing level).

What do you think about that @Clariteia/core-devs?

As we talked during the daily, (at least for the moment), we'll use a single common broker class for all cases.


Updating the Linux Kernel branches for WSL2

The next Linux longterm release kernel is already approaching.
With the upcoming default support of the latest Linux longterm release (currently version 5.15) in WSL2, can you please also update it on https://github.com/microsoft/WSL2-Linux-Kernel/branches ?

Yes, we will be updating to 5.15 (hopefully) soon.

Great, but why are you closing this ticket meanwhile updating to 5.15 is not yet done?

Congratulation to have solved the blocking 9p issue and published a first version of the Kernel 5.15 source code.


sortable multiple choice widget

is such a thing possible? i would be happy to help implement such a thing if it is feasible.

+1

I think before you get into the UI of this, you'd have to do some thinking about custom ordering. Should django taggit support ordering apart from alphabetical or usage frequency? Will this have database implications?

#370


Size of the Font

Hello,
Everything is working well with HTMLQ except the size of the font during step 1. The size of the statements are too big for the boxes, the participants can't read all the statements properly. So I tried with this =

<item id="smallFont">false</item>

But It doesn't change anything.
So does someone know how to reduce the size of these statements? It would be really really helpful for my survey...

Hello,
Try to modify the size of the statements by changing (adding "font-size" option) in htmlq.css (which can locate in the stylesheets folder).
I think this is the part of the code you have to change by adding "font-size" style:
/* step1 /
/ hide all except the first statement */
#step1 {
padding-top: 50px;
}

Thank you very much for the quick answer, you've solved my problem!
Have a nice day


Could your code be adapted to work with 915 MHz transceivers?

Obviously, this post is not creating an issue with ESPSomfy-RTS, which is awesome & appreciated greatly!
My wife asked me last night if it's possible to create simple way to turn on/off our whole house vacuum.  The system uses a 915 MHz remote that's integrated into the handle to turn the power unit on/off.  However, when she is just using tools & doesn't have the handle with her, she needs to go to a hose outlet, turn the system on/off, & then return to where she's cleaning.  I have zero experience with 915 MHz systems. E.g., I don't even know if all 915 MHz devices are LoRa
Of course, Vacuvision, the company that makes the power controller for our unit, offers a fob that can be added to do exactly what my wife is looking for, but it's priced like a ZRTSI, $80.00 for a 2 button key fob.  OMG!  And it's yet another dongle to misplace.
I started looking around for transceivers, & of course, they're available with antennas for around $2.50 from the slow boat company.  I assume one could connect it to an ESP32, figure out how sniff codes, & hopefully stumble upon away to use HA to turn the beast on & off.
I also found this development board which is a combo ESP and 915 MHz transceiver:
https://www.amazon.com/MakerFocus-Development-Bluetooth-0-96inch-Display/dp/B076MSLFC9/ref=sr_1_2?crid=3077DGV7YX1NF&keywords=esp32+915mhz+transceiver&qid=1682265536&sprefix=esp32+915mhz+transceiver%2Caps%2C92&sr=8-2
My question is, with minimal guidance & assuming I could sniff the codes with the transceiver, could I create a toggle in HA to turn the big  sucker on & off?  It looks like there are some Arduino libraries to help sniff packets, etc.  Alternatively, should I just take my lumps & get her the ridiculously priced fob.  Of course, my wife is lobbying for the latter.
Your thoughts & suggestions are most welcome!!!

Is the CC1101 capable of 915 MHz?  I'm thinking it might be...  I have an extra E07-M1101D & antenna that could possibly be used in a separate box than the Somfy unit.

The CC1101 is capable of receiving that frequency.   I have to say I have never seen such a thing.  Why would anyone use wireless when you have to run 2 inch pipes all over the house.  Mine is hardwired and the communication comes from the handle and the dustpans in the baseboards.  I am just confused as to what that advantage is.
I digress though.  How are your C/C++ skills?  With some of those, you could go in and modify the code to receive and transmit on the that frequency.  On line 194 of Somfy.h is where this initial frequency is set.
The bigger issue will be decoding and encoding the frames.  Line 1792 of Somfy.cpp is the decoding algorithm and the transmit is on line 1711.  The Somfy protocol was a bit of a challenge due to the way it pulses the preamble.  So all of the code uses a bit-banging strategy.  This could be LoRa and use some protocol standards though in which case this codebase would be the long road.
Perhaps if you are tinkering.  https://randomnerdtutorials.com/esp32-lora-rfm95-transceiver-arduino-ide/

Thanks for your quick & helpful response!
I think they used wireless for our vacuum because it has "hide a hose" (hideahose.com) where the hose(s) get sucked into the wall when not in use.  You just pull out as much hose as you need from the wall plate, vacuum away, & when finished, the vacuum system pulls the hose back into the wall (PVC pipe, actually).  You don't have to lug the hose around the house-- we have 2 hose outlets, one  has a 50' hose & the other 40'.  The hoses are just that--no power in them like the Beam system we had in our previous house.  So, I guess the easiest way to turn the vacuum on/off is via a wireless switch in the handle.  It's a trade-off, like everything is.
Once upon a time, many decades ago, I programmed in C quite a bit.  Rusty as heck, but I  may give it a whirl.  I also found an inexpensive LoRa tap remote that my wife is excited about.
https://www.amazon.com/LoraTap-915MHz-2-button-Remote-Receiver/dp/B07MXWNYCG?ref_=ast_sto_dp
Since it's returnable to Bezos, I may order one today & fall back to doing the ESP Somfy hack as well.  We shall see.
As always, I appreciate your helpful suggestions!

I guess it has no beater head on it.  Ours has power to every port and there are 8 of them strewn around the house.  The retractable hose is a neat idea but the maids would have torched that for sure by now.

Yep.  The carpet beater bar is "air" powered, not with an electric motor, which is certainly a more powerful and better option.  Since the "maids" here are my wife primarily and me secondarily, we've not had any issues with the retractable hoses.  When my wife saw the retractable hoses were an option, she said it's the only one for her.  She wasn't a fan of lugging the hose around our previous house & really hated storing it.  To each, their own, of course.
With two adults, two small dogs, and mostly tile flooring with a few area rugs, the retractable hoses work pretty well overall for us.  We have a couple of baseboard dustpans, too.  My wife said she rarely uses them, however.  Having a car kit that can be attached to the power unit in the garage is really useful.    We also have a Dyson stick vacuum for small cleanups & a shop vac, of course for outdoor/wet/messy stuff.