[Bug] R CI failing

r-ci.yml has been failing on main since mid-June.

The first 4 failures (#5418, #5419, #5422, #5423; Jun 17-18) began with #2732
#5426 and #5427 then passed (Jun 19-20)
Since #5442 (Jun 28), all 78 runs have failed (as of 2024-08-21T09:00:58Z: #9)

Example output
The last output is typically 70 | ScalarMap, before a segfault:
✔ |         70 | ScalarMap

 *** caught segfault ***
address 0x1019, cause 'memory not mapped'
An irrecoverable exception occurred. R is aborting now ...
/home/runner/work/_temp/c0e3d832-8dfe-4[52](https://github.com/single-cell-data/TileDB-SOMA/actions/runs/9713375174/job/26810031898#step:14:53)3-ac62-7a65da1f7dad.sh: line 1:  9642 Segmentation fault      (core dumped) Rscript testthat.R
Error: Process completed with exit code 139.

The segfault messages vary; memory not mapped, bad_function_call, invalid permissions, address (nil), cause 'unknown'. ryan-williams/tdbs-r-ci-dbg contains some analysis of the logs of failing runs, including frequencies of various error messages.

Breakdown by error message
Updated at 2024-08-21T09:00:58Z (by #9)
"memory not mapped"
Seen 50x, most recently #5785 (at 2024-08-19T15:12):
 *** caught segfault ***
address <ADDRESS>, cause 'memory not mapped'
An irrecoverable exception occurred. R is aborting now ...
/home/runner/work/_temp/<UUID>.sh: line <LINE>:  <ID> Segmentation fault      (core dumped)
##[error]Process completed with exit code 139.

All runs
#5419, #5422, #5423, #5442, #5444, #5449, #5451, #5452, #5464, #5476, #5486, #5492, #5512, #5521, #5523, #5537, #5538, #5552, #5559, #5563, #5571, #5582, #5586, #5588, #5602, #5603, #5604, #5605, #5618, #5621, #5623, #5634, #5635, #5640, #5641, #5644, #5646, #5648, #5686, #5690, #5693, #5696, #5698, #5706, #5711, #5727, #5736, #5743, #5784, #5785

"invalid permissions"
Seen 12x, most recently #5790 (at 2024-08-20T13:45):
 *** caught segfault ***
address <ADDRESS>, cause 'invalid permissions'
An irrecoverable exception occurred. R is aborting now ...
/home/runner/work/_temp/<UUID>.sh: line <LINE>:  <ID> Segmentation fault      (core dumped)
##[error]Process completed with exit code 139.

All runs
#5418, #5459, #5518, #5556, #5568, #5616, #5688, #5714, #5724, #5729, #5737, #5790

"bad_function_call"
Seen 11x, most recently #5786 (at 2024-08-19T15:13):
terminate called after throwing an instance of 'std::bad_function_call'
  what():  bad_function_call
/home/runner/work/_temp/<UUID>.sh: line <LINE>:  <ID> Aborted                 (core dumped)
##[error]Process completed with exit code 134.

All runs
#5467, #5527, #5560, #5615, #5637, #5654, #5673, #5707, #5738, #5764, #5786

"address (nil), cause 'unknown'"
Seen 7x, most recently #5787 (at 2024-08-19T16:45):
 *** caught segfault ***
address (nil), cause 'unknown'
An irrecoverable exception occurred. R is aborting now ...
/home/runner/work/_temp/<UUID>.sh: line <LINE>:  <ID> Segmentation fault      (core dumped)
##[error]Process completed with exit code 139.

All runs
#5511, #5532, #5550, #5657, #5746, #5750, #5787

Occasional successful runs
A few runs have passed on PR branches (e.g. 1, 2). However, I tried re-running the first one, and it failed, so it seems like it's just non-deterministic, and usually fails. The dark/images branch did pass 3x in a row, 8/8-11.
Plan for debugging / fixing?
Several folks on the team have made some progress debugging it, but a fix remains elusive.
From discussions with @johnkerl, ongoing work to remove our dependency on TileDB-R may resolve it.
Change workflow to 24hr cron?
It's been causing "spurious" ❌'s on PRs (and main) for 2 months, which can mask other failures.
Disabling it altogether feels too aggressive; it's good to have some visibility into the state of the R tests.
Setting it to run against main every 24hrs might be a good compromise.

I want to acknowledge work over time by @nguyenv @mojaveazure @eddelbuettel and myself here. There has been significant investigation in this direction. I would note that these tend to be CI-only failures, not occurring in sandbox development, and thus more difficult to debug.
I also note that non-trivial time investment has already been done.
The proposal to temporarily move to a 24-hour cadence is that -- temporary -- and we will revisit once the R/cppification work is complete.

There is a Heisenbug that has driven a few of us to madness.  But when you e.g. do (in the apis/r directory)
cd tests
CI=true Rscripts testthat.R

then all 3500+ tests pass.  No skip, no fail.  But it is frail, there is a possible interaction with the testrunner software (the widely-used testthat package, but it does some things behind the scence so @mojaveazure and I have planned to eventually replace it with tinytest (which eg tiledb-r uses, and which has a simpler setup).   So when developing we adhere to a testing process.  But CI is has been throwing a consistent spanner for years as also seen in the fact that macOS runs fewer tests as does coverage.

I ran the following on an Ubuntu EC2 instance (m4a.4xlarge, AMI ami-0b33ebbed151cf740), mimicking r-ci.yml:
git clone https://github.com/single-cell-data/TileDB-SOMA
cd TileDB-SOMA/apis/r
tools/r-ci.sh bootstrap

Rscript <(cat <<EOF
rversion <- paste(strsplit(as.character(getRversion()), split = '\\.')[[1L]][1:2], collapse = '.')
codename <-  system('. /etc/os-release; echo ${VERSION_CODENAME}', intern = TRUE)
repo <- "https://tiledb-inc.r-universe.dev"
(opt <- sprintf('options(repos = c("%s/bin/linux/%s/%s", "%s", getOption("repos")), timeout = 300L)', repo, codename, rversion, repo))
cat(opt, "\n", file = "~/.Rprofile", append = TRUE)
EOF
)

Rscript tools/install-tiledb-r.R
tools/r-ci.sh install_bioc SingleCellExperiment
Rscript -e "remotes::install_deps(dependencies = TRUE, upgrade = FALSE)"
R CMD build --no-build-vignettes --no-manual .
R CMD INSTALL $(ls -1tr *.tar.gz | tail -1)

cd tests
Rscript testthat.R  # non-CI mode: OK ✅
export CI=true; Rscript testthat.R  # ❌
export CI=true; Rscript testthat.R  # ❌
export CI=true; Rscript testthat.R  # ❌

The 3 failing test runs had identical output (modulo timings):
Failing test output
tiledbsoma:    <IP_ADDRESS>
tiledb-r:      0.29.0
tiledb core:   2.25.0
libtiledbsoma: 2.25.0
R:             R version 4.4.1 (2024-06-14)
OS:            Ubuntu 22.04.4 LTS
✔ | F W  S  OK | Context
✔ |         25 | Arrow-utils
✔ |        140 | Blockwise [5.8s]
✔ |         14 | ConfigList
✔ |        115 | CoordsStrider
✔ |         26 | EphemeralCollection
✔ |         14 | EphemeralExperiment
✔ |         17 | EphemeralMeasurement
✔ |          5 | example-datasets
✔ |         49 | Factory
✔ |         35 | IntIndexer
✔ |          9 | membership-caching
✔ |         11 | OrderedAndFactor
✔ |         26 | PlatformConfig
✔ |        277 | reopen [1.4s]
✔ |         70 | ScalarMap
✔ |        172 | SCEOutgest [14.4s]
✔ |        379 | SeuratIngest [24.2s]
✔ |         99 | SeuratOutgest-assay [5.0s]
✔ |        169 | SeuratOutgest-command [9.2s]
✔ |         49 | SeuratOutgest-graph [2.9s]
✔ |        134 | SeuratOutgest-object [10.1s]
✔ |        180 | SeuratOutgest-reduction [5.5s]
✔ |         29 | SingleCellExperimentIngest [11.5s]
✔ |         13 | SOMAArrayReader-Arrow
✔ |         80 | SOMAArrayReader-Iterated [7.2s]
✔ |         16 | SOMAAxisQuery
✔ |         22 | SOMACollection [3.3s]
✔ |        161 | SOMADataFrame [9.9s]
✔ |         52 | SOMADenseNDArray [1.5s]
✔ |         80 | SOMAExperiment-query-m-p [4.7s]
✔ |         33 | SOMAExperiment-query-matrix-outgest [2.6s]
✔ |         62 | SOMAExperiment-query [5.8s]
✔ |         12 | SOMAExperiment [1.3s]
✔ |         11 | SOMAMeasurement
✔ |          9 | SOMAOpen
✔ |        156 | SOMASparseNDArray [2.7s]
✔ |         57 | SOMATileDBContext
✔ |          2 | Stats
✔ |         26 | SummarizedExperimentIngest [3.3s]
✔ |         16 | TileDBArray
✔ |         52 | TileDBCreateOptions
✔ |         37 | TileDBGroup
✔ |         21 | TileDBURI
✔ |         50 | utils-matrixZeroBasedView
✔ |         24 | utils-uris
✔ |         13 | utils
✔ |          3 | version
✔ |        190 | write-soma-objects [5.7s]
✖ | 2      252 | write-soma-resume [33.8s]
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Error (test-write-soma-resume.R:493:3): Resume-mode Seurat
<<not available>/C++Error/error/condition>
Error: [TileDB::C++API] Error: Failed to create context
Backtrace:
     ▆
  1. ├─base::suppressWarnings(...) at test-write-soma-resume.R:493:3
  2. │ └─base::withCallingHandlers(...)
  3. └─SOMAExperimentAxisQuery$new(expc, "RNA")$to_seurat(...)
  4.   ├─base::withCallingHandlers(...)
  5.   ├─base::tryCatch(...)
  6.   │ └─base (local) tryCatchList(expr, classes, parentenv, handlers)
  7.   │   ├─base (local) tryCatchOne(...)
  8.   │   │ └─base (local) doTryCatch(return(expr), name, parentenv, handler)
  9.   │   └─base (local) tryCatchList(expr, names[-nh], parentenv, handlers[-nh])
 10.   │     └─base (local) tryCatchOne(expr, names, parentenv, handlers[[1L]])
 11.   │       └─base (local) doTryCatch(return(expr), name, parentenv, handler)
 12.   └─tiledbsoma:::.load_seurat_command(uns, ms_names = private$.measurement_name)
 13.     └─xdf$read(column_names = "values")
 14.       └─tiledbsoma:::sr_setup(...)

Error (test-write-soma-resume.R:636:3): Resume-mode SingleCellExperiment
Error in `(function (cond)
.Internal(C_tryCatchHelper(addr, 1L, cond)))(structure(list(message = "[TileDB::C++API] Error: Failed to create context",
    call = NULL, cppstack = NULL), class = c("<not available>",
"C++Error", "error", "condition")))`: error in evaluating the argument 'x' in selecting a method for function 't': [TileDB::C++API] Error: Failed to create context
Backtrace:
    ▆
 1. ├─SOMAExperimentAxisQuery$new(expr, "RNA")$to_single_cell_experiment(...) at test-write-soma-resume.R:636:3
 2. │ └─base::lapply(...)
 3. │   └─tiledbsoma (local) FUN(X[[i]], ...)
 4. │     ├─Matrix::t(self$to_sparse_matrix(collection = "X", layer_name = layer))
 5. │     └─self$to_sparse_matrix(collection = "X", layer_name = layer)
 6. │       └─layer$read(coords = coords)
 7. │         └─tiledbsoma:::sr_setup(...)
 8. ├─base::stop(`<<navlbl>>`)
 9. └─base (local) `<fn>`(`<<navlbl>>`)
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

══ Results ═══════════════════════════════════════════════════════════════════════════════════════════════════════════
Duration: 176.8 s

── Failed tests ──────────────────────────────────────────────────────────────────────────────────────────────────────
Error (test-write-soma-resume.R:493:3): Resume-mode Seurat
<<not available>/C++Error/error/condition>
Error: [TileDB::C++API] Error: Failed to create context
Backtrace:
     ▆
  1. ├─base::suppressWarnings(...) at test-write-soma-resume.R:493:3
  2. │ └─base::withCallingHandlers(...)
  3. └─SOMAExperimentAxisQuery$new(expc, "RNA")$to_seurat(...)
  4.   ├─base::withCallingHandlers(...)
  5.   ├─base::tryCatch(...)
  6.   │ └─base (local) tryCatchList(expr, classes, parentenv, handlers)
  7.   │   ├─base (local) tryCatchOne(...)
  8.   │   │ └─base (local) doTryCatch(return(expr), name, parentenv, handler)
  9.   │   └─base (local) tryCatchList(expr, names[-nh], parentenv, handlers[-nh])
 10.   │     └─base (local) tryCatchOne(expr, names, parentenv, handlers[[1L]])
 11.   │       └─base (local) doTryCatch(return(expr), name, parentenv, handler)
 12.   └─tiledbsoma:::.load_seurat_command(uns, ms_names = private$.measurement_name)
 13.     └─xdf$read(column_names = "values")
 14.       └─tiledbsoma:::sr_setup(...)

Error (test-write-soma-resume.R:636:3): Resume-mode SingleCellExperiment
Error in `(function (cond)
.Internal(C_tryCatchHelper(addr, 1L, cond)))(structure(list(message = "[TileDB::C++API] Error: Failed to create context",
    call = NULL, cppstack = NULL), class = c("<not available>",
"C++Error", "error", "condition")))`: error in evaluating the argument 'x' in selecting a method for function 't': [TileDB::C++API] Error: Failed to create context
Backtrace:
    ▆
 1. ├─SOMAExperimentAxisQuery$new(expr, "RNA")$to_single_cell_experiment(...) at test-write-soma-resume.R:636:3
 2. │ └─base::lapply(...)
 3. │   └─tiledbsoma (local) FUN(X[[i]], ...)
 4. │     ├─Matrix::t(self$to_sparse_matrix(collection = "X", layer_name = layer))
 5. │     └─self$to_sparse_matrix(collection = "X", layer_name = layer)
 6. │       └─layer$read(coords = coords)
 7. │         └─tiledbsoma:::sr_setup(...)
 8. ├─base::stop(`<<navlbl>>`)
 9. └─base (local) `<fn>`(`<<navlbl>>`)

[ FAIL 2 | WARN 0 | SKIP 0 | PASS 3494 ]
Error: Test failures
Execution halted

Is that familiar to anyone?

That's two out of 3496, they are in code undergoing current changes (timestamped read-write) so maybe we should just park these two.   The Heisenbug is that things do fail earlier for some of us (SCEOutgest is a common one, sometimes later ones).  One can run these test files individually too (that is tedious, and a fault of the overcomplicated testthat we use) and then they pass while they may fail when run with all others -- which is also maddening.
This may all be related to Context and I have a change to handle that differently.  Or it could be another race condition.
Anyway -- also details below for a run on my end (Ubuntu 24.04, current) which always passes.  (This is from my laptop, it also works with slightly new parts on my main server but I am in a middle of a branch there....)

edd@ahmad:~/git/tiledb-soma/apis/r/tests(main)$ CI=TRUE Rscript testthat.R
tiledbsoma:    <IP_ADDRESS>
tiledb-r:      <IP_ADDRESS>
tiledb core:   2.26.0
libtiledbsoma: 2.26.0
R:             R version 4.4.1 (2024-06-14)
OS:            Ubuntu 24.04 LTS
✔ | F W  S  OK | Context
✔ |         25 | Arrow-utils
✔ |        140 | Blockwise [4.3s]
✔ |         14 | ConfigList
✔ |        115 | CoordsStrider
✔ |         26 | EphemeralCollection
✔ |         14 | EphemeralExperiment
✔ |         17 | EphemeralMeasurement
✔ |          5 | example-datasets
✔ |         49 | Factory
✔ |         35 | IntIndexer
✔ |          9 | membership-caching
✔ |         11 | OrderedAndFactor
✔ |         26 | PlatformConfig
✔ |        277 | reopen [1.0s]
✔ |         70 | ScalarMap
✔ |        172 | SCEOutgest [10.5s]
✔ |        379 | SeuratIngest [16.3s]
✔ |         99 | SeuratOutgest-assay [3.2s]
✔ |        169 | SeuratOutgest-command [5.9s]
✔ |         49 | SeuratOutgest-graph [2.2s]
✔ |        134 | SeuratOutgest-object [7.2s]
✔ |        180 | SeuratOutgest-reduction [4.2s]
✔ |         29 | SingleCellExperimentIngest [11.0s]
✔ |         13 | SOMAArrayReader-Arrow
✔ |         80 | SOMAArrayReader-Iterated [6.0s]
✔ |         16 | SOMAAxisQuery
✔ |         22 | SOMACollection [2.8s]
✔ |        161 | SOMADataFrame [7.2s]
✔ |         52 | SOMADenseNDArray [1.3s]
✔ |         80 | SOMAExperiment-query-m-p [4.1s]
✔ |         33 | SOMAExperiment-query-matrix-outgest [1.9s]
✔ |         62 | SOMAExperiment-query [4.5s]
✔ |         12 | SOMAExperiment [1.1s]
✔ |         11 | SOMAMeasurement
✔ |          9 | SOMAOpen
✔ |        156 | SOMASparseNDArray [2.2s]
✔ |         57 | SOMATileDBContext
✔ |          2 | Stats
✔ |         26 | SummarizedExperimentIngest [2.8s]
✔ |         16 | TileDBArray
✔ |         52 | TileDBCreateOptions
✔ |         37 | TileDBGroup
✔ |         21 | TileDBURI
✔ |         50 | utils-matrixZeroBasedView
✔ |         24 | utils-uris
✔ |         13 | utils
✔ |          3 | version
✔ |        190 | write-soma-objects [3.7s]
✔ |        315 | write-soma-resume [37.4s]

══ Results ════════════════════════════════════════════════════════════════════════════════
Duration: 144.5 s

[ FAIL 0 | WARN 0 | SKIP 0 | PASS 3557 ]
edd@ahmad:~/git/tiledb-soma/apis/r/tests(main)$

It's possible that #2926 reduces the frequency of these failures; two runs there I re-ran several times this weekend:

Run #5814 passed 12x in a row before failing on attempt #13
Run #5815 passed 6 of 9 attempts.

This is in contrast to main having failed the last 81 of 81 runs.
I don't think there's a known reason for #2926 to reduce the frequency of these failures, and @eddelbuettel mentioned separately that the R CI has gone through previous phases of failing with more or less frequency, just flagging. The failure frequency may be about to decrease (or we will have some evidence that something about the branch name is affecting things?).
There's also discussion around disabling failing tests on #2922.

I updated the issue description, but posting here as well for visibility:

Update: #2926 seems to have mitigated the failures significantly (though brute-force re-running R CI on that PR still failed 4 of 22 attempts: #5814, #5815).
R CI currently shows mostly successes, though run #5864 (from #2919, commit 9cd956fb166f1fc618c1b596513a9545daaddb25, which includes #2926) failed.
We can continue using this issue to track failures as we see them. My understanding is we don't expect #2926 to have actually fixed the issue, it has just made the failures less frequent.
@jp-dark also flagged recently that ASAN was inadvertently broken in #2773; fixing that (and running it as part of CI) may help root-cause the issue here. Related internal tracking: sc-34306, sc-53780.

I haven't seen R CI flakiness in a long time -- @ryan-williams , thoughts?

Sure, closing


[sil] Rename TermInst::{getSuccessorBlockArguments,getSuccessorBlockArgumentLists}()

This method returns argument lists, not arguments! We should add in the future
an additional API that returns a flap mapped range over all such argument lists
to cleanup some of this code. But at least now the name is more accurate.

@swift-ci smoke test


[Bug] Binary analysis fails for tackle-testapp

Konveyor version
0.3.0-rc.3
Current Behavior
Binary analysis fails
Analysis details
id: 2
createTime: 2023-12-28T12:36:50.708566999Z
name: app1-bin2.2.windup
addon: analyzer
data:
    mode:
        artifact: ""
        binary: true
        withDeps: false
    rules:
        labels:
            excluded: []
            included:
                - konveyor.io/target=cloud-readiness
        path: ""
        tags:
            excluded: []
    scope:
        packages:
            excluded: []
            included: []
        withKnownLibs: false
    sources: []
    tagger:
        enabled: true
    targets: []
    verbosity: 0
application:
    id: 2
    name: app1-bin2
state: Failed
image: quay.io/konveyor/tackle2-addon-analyzer@sha256:72cfb9e945fd634abddb6c70b3dae57e96af9224e4e8796ab9e48cea6994d014
pod: konveyor-tackle/task-2-kjgqz
started: 2023-12-28T12:36:51.239658406Z
terminated: 2023-12-28T12:36:56.420449135Z
bucket:
    id: 4
    name: ""
errors:
    - severity: Error
      description: exit status 1
    - severity: Error
      description: 'Pod failed: Error'
activity:
    - Fetching application.
    - '[CMD] Running: /usr/bin/ssh-agent -a /tmp/agent.1'
    - '[CMD] /usr/bin/ssh-agent succeeded.'
    - '[SSH] Agent started.'
    - '[MVN] Using credentials (id=3) shveta22.'
    - '[FILE] Created /addon/settings.xml.'
    - '[MVN] Using settings file(path=/addon/settings.xml).'
    - '[MVN] Fetch artifact io.konveyor.demo:customers-tomcat:0.0.1-SNAPSHOT:war.'
    - '[CMD] Running: /usr/bin/svn dependency:copy -Dartifact=io.konveyor.demo:customers-tomcat:0.0.1-SNAPSHOT:war -Dmdep.useBaseVersion=true -DoutputDirectory=/addon/bin/maven -Dmaven.repo.local=/cache/m2 -s /addon/settings.xml'
    - '[CMD] /usr/bin/svn failed: exit status 1'
attached:
    - id: 346
      name: ssh-agent.output
      activity: 2
    - id: 347
      name: svn.output
      activity: 9

How Reproducible
Always
Steps To Reproduce
Analyze tackle-test app with the configuration available in the Environment section.
Environment
- Konveyor 0.3.0-rc.3
- Binary source application: io.konveyor.demo:customers-tomcat:0.0.1-SNAPSHOT:war
- Analysis configuration:
  - Binary
  - cloud-readiness
  - Application and internal dependencies only
  - No custom rules
  - No additional advanced options

What are the contents of the svn.output attached file?

svn: invalid option character: D
Type 'svn help' for usage.

https://github.com/konveyor/tackle2-addon/pull/51


Add dependency diff report workflow

Issue

close #ISSUE_NUMBER

Overview (Required)

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before
After

Movie (Optional)

Before
After

Sorry. I mistook it for my own forked repository 🙏


add link to select c# language version

Summary
Add reference link to select required C# language version for the sample code.
Fixes #7123

Thanks, @Niladri24dutta, for making the additional changes. I'll merge your PR now. Your changes should be live on docs.microsoft.com in the next day or two.

@rpetrusha Thanks a lot.


React Native Scanner

Would be great to be able to detect if the project was a React Native app and set up the workflow accordingly.
Off the top of my head for detection:

[ ] Look for index.ios.js or index.android.js
[ ] Look for package.json

Steps to set up:

[ ] activate ssh key
[ ] git clone repo
[ ] npm install
[ ] npm test (maybe)
[ ]  Install react native
[ ]  react native bundle
[ ]  if Android drop into Gradle detector
[ ] if iOS drop into iOS detector

Awesome, thank you for the details! We definitely plan to add RN support to the scanner in the near future, your list will help a lot! 😉

I've stumbled upon a really annoying issue while RN + fastlane setup. When RN packager is run at the end of the build process, if it fails for some reason (error in your code, missing files), you end up with a cryptic error message from xcode which looks smth like this:
The following build commands failed:
PhaseScriptExecution Bundle\ React\ Native\ code\ and\ images /Users/vagrant/Library/Developer/Xcode/DerivedData/PokemonMap-hitodhodyhmznpfhbsqsddrmkusj/Build/Intermediates/ArchiveIntermediates/PokemonMap/IntermediateBuildFilesPath/PokemonMap.build/Release-iphoneos/PokemonMap.build/Script-00DD1BFF1BD5951E006B06BC.sh
(1 failure)
[12:09:27]: Exit status: 65

it would be great to be able to have more context on this: either prerun the bundler to see if everything is ok or make sure that PhaseScriptExecution spits out some info regarding what went down

Sorry @callmephilip , but how is this related to the scanner / to this repository? I might be wrong, but you most likely get the error from the Fastlane step, so you should create a bug report there instead. Let me know if I'm mistaken and your comment should actually be here.

@godrei pointed me here to share my experience with RN + Fastlane on Bitrise saying it might be useful. I guess what I was trying to suggest is that verifying RN bundler is working would be a cool feature in the scanner 😄

@callmephilip I see, no problem at all.
Re: you report: it seems that this is related to fastlane itself, its own output formatter what omits details in this case, so you should create a bug report on their GitHub page https://github.com/fastlane/fastlane
Re: verifying RN bundler is working: it's a bit out of scope right now, and I'm not sure if that's sensible to do at all. The problem is: the scanner can run on any platform, e.g. on Linux where Xcode is not available, or on Mac OS platform where another Xcode is installed, not the one your project requires. So, at least for now, the scanner's purpose is to try to generate a sensible configuration which then, if executed on the right platform, will produce a successful build for you.
There are other issues with verifying whether bundler or any other tools works, during the scan, e.g. what should it do if it does not? Our current practice is to try to generate the best starter workflow with the scanner, so that you can run a build. If it fails, there you can change your settings, the environment or anything else. If the scanner itself would not allow your project to be configured, e.g. because of a configuration issue in your fastlane file or anywhere else, all you could do is to start the process over and over again, without having any control over the environment or configuration.
Personally I think that the scanner should remain as it is today, a tool which tries to detect certain requirements (as many as possible) and provide the required information (environment & configuration) so that your build will pass. If it does not pass, then you have full control over fixing / changing things.
Does that make sense? Would you still implement the check in the scanner? If yes, what should happen if the validation can't pass (e.g. you forgot to include a crucial file in your repository)?

@viktorbenei : yeah thanks for the clarifications. i think this does make sense. making fastlane more verbose with PhaseScriptExecution is what needs to be done here

@callmephilip I agree, that would improve the process / help you to get your first green build when you have an issue like the one you reported. Could you please create a bug report on their GitHub? They're usually quite fast to fix/change things.


Expose current_entity in ChildBuilder

Fixes #594
I just appended a check to a pre-existing test, but can also create a new one, if that's prefered.

Looks good. Thanks!


web security scans

review:
https://community.qualys.com/blogs/securitylabs/2015/09/16/blindelephant--then-and-now

review:  https://dzone.com/articles/troy-hunts-ultimate-list-of-security-links-1?utm_medium=feed&utm_source=feedpress.me&utm_campaign=Feed: dzone%2Fjava

Try finding some models that we can adhere to such as:
https://community.qualys.com/blogs/securitylabs/2015/06/08/introducing-tls-maturity-model

I'm not following this one - is this just a check to see if HTTPS is set up
up correctly on a site?
-jgl
On Sat, Oct 10, 2015 at 6:42 AM, Andy White<EMAIL_ADDRESS>wrote:

Try finding some models that we can adhere to such as:
https://community.qualys.com/blogs/securitylabs/2015/06/08/introducing-tls-maturity-model
—
Reply to this email directly or view it on GitHub
https://github.com/Gadreel/divconq/issues/157#issuecomment-147078138.

--
-- Jonathan Lampe, CFTP http://www.cftpcert.com, CISSP
https://www.isc2.org/CISSP
-- File Transfer Consulting http://www.filetransferconsulting.com, LLC
--<PHONE_NUMBER> -<EMAIL_ADDRESS>- @ftexperts
https://twitter.com/ftexperts
"Are you a Certified File Transfer Professional (CFTP)
http://www.cftpcert.com yet?"

Partly (cynically speaking) it is something to talk about at conferences:
https://community.qualys.com/blogs/securitylabs/2015/10/09/implementing-the-tls-maturity-model
But I think the point is having an organization wide commitment to TLS 1.2+ so this applies probably to larger businesses.  I just wanted a note about that model as I think about security issues.


Updated DwC-MIxS mapping

This PR and issue in the SSSOM repo showed that - by following the old SSSOM guidance - we have sometimes used the SKOS predicates for narrow match and broad match incorrectly.
In issue #77 we reviewed the mapping predicates.
In this PR we will update our mapping files to fix this.
Updates for v2.0.0 of the mapping
Mapping predicates

value for predicate_id updated to skos:narrowMatch for the terms listed here: https://github.com/tdwg/gbwg/issues/77#issuecomment-995806725
value for predicate_id updated to skos:broadMatch for the terms listed here: https://github.com/tdwg/gbwg/issues/77#issuecomment-995840816
value for syntax_predicate_id updated to skos:broadMatch for the terms listed here: https://github.com/tdwg/gbwg/issues/77#issuecomment-997932073, https://github.com/tdwg/gbwg/issues/77#issuecomment-998646738

Associated metadata

values for mapping_date/syntax_mapping_date and creator_id were updated to reflect the updates in the mapping predicates

Additional metadata

v2.0.0 additionally includes a confidence value confidence/syntax_confidence for the mapping between 0 and 1 (0 no confidence, 1 100% confidence; see The SSSOM 5-Star System For Mappings).

Removed metadata

DwC-MIxS_mappingSemantic-2.0.0.sssom.tsv no longer includes the additional column on predicate_label as there was no clear guidance on what those are for skos:narrowMatch and skos:broadMatch.

The review of the semantic mapping (following the update of the SSSOM guidance and @raissameyer's implementation thereof) is done above.
You'll notice that this was done in a line-by-line fashion as we think this should be the norm for a mapping file that links standards organisations: very thorough, with approvals explicit.

Thank you for the in depth review @pbuttigieg. I have addressed the comments as discussed, and updated the semantic and syntactic mapping file accordingly.
Please let me know if there are any further comments.
Once we are good to go, I'll go ahead and also update the Support mapping file to reflect the changes in the semantic and syntactic mapping.


[Bug] Discord Client Crashes With BD

Describe the Bug
My discord client crashes everytime I open discord with BD (without plugins and themes), poping up the message shown in Screenshots
To Reproduce
Install BD.
Open Discord
Screenshots

Discord Version
Stable
Additional Context
It happens with every version of BD, from 1.0.0 to latest

You most likely have some outdated plugins. Please join the Discord Server to get further assistance.

You most likely have some outdated plugins. Please join the Discord Server to get further assistance.

You most likely have some outdated plugins. Please join the Discord Server to get further assistance.

Glad they are reading the issue before responding ^^

Thank you, passive aggressive comments are very helpful.


The "get" method do not synced with Redis extension

Hi, we found the problem with using get method. In original documentation, the method get returns false if the key does not exist in service. But the PRedis library returns NULL.
I think what the library should be synced with all return types with original extension.
<?php

namespace Acme;

use Predis\Client;

include_once __DIR__.'/vendor/autoload.php';

$client = new Client('redis://redis:6379');
$client->connect();

var_dump($client->get('some-foo-bar'));

$redis = new \Redis();
$redis->connect('redis');

var_dump($redis->get('some-foo-bar'));

Result:
$ root@82b65207bed9:/code# php test.php
NULL
bool(false)
$ root@82b65207bed9:/code#

As per Redis documentation for the GET command:
Bulk string reply: the value of key, or nil when key does not exist.
Which is the reason why Predis returns NULL when the key does not exists, it doesn't make sense to return FALSE.


test only, don't merge

@burtbeckwith thanks for looking into this. Once this pass. We should merge it and then create separate PR with 3.4.0-SNAPSHOT. We have to test everything is fine with 3.4.0.

@sdelamo I'm closing this one, it was to verify that https://github.com/micronaut-projects/micronaut-guides/pull/826 would fix issues in other PRs, but since you merged that I merged master into the 3.3.4 PR


Error during running it locally on  system   [documentation error]->According to me

When I used to run it locally in my ubuntu system it was giving me error.
Bug Report 🐛
Expected Behavior
Following the steps in the read me to run locally ,it should have run fine .
Current Behavior
But now it's giving error in the ubuntu system.
Possible Solution
In the steps to run it locally ,we should include one more step .We should first initialise lerna by lerna init.
Steps to Reproduce

1.sudo npm install -g lerna
2.lerna init
3.lerna clean && lerna bootstrap && lerna run build
4.cd packages/storybook
5.npm run storybook
Context (Environment)
I was trying to run it locally on my ubuntu system version 20.04
Detailed Description
I am just adding another step to initialise lerna by lerna  #init.

Possible Implementation
We should first initialise lerna by lerna init in the first step
The it will run fine.

When I used to run it locally in my ubuntu system it was giving me error.
Bug Report
Expected Behavior
Following the steps in the read me to run locally ,it should have run fine .
Current Behavior
But now it's giving error in the ubuntu system.
Possible Solution
In the steps to run it locally ,we should include one more step .We should first initialise lerna by lerna init.
Steps to Reproduce
1.sudo npm install -g lerna
2.lerna init
3.lerna clean && lerna bootstrap && lerna run build
4.cd packages/storybook
5.npm run storybook
Context (Environment)
I was trying to run it locally on my ubuntu system version 20.04
Detailed Description
I am just adding another step to initialise lerna by lerna #init.

Possible Implementation
We should first initialise lerna by lerna init in the first step
The it will run fine.

[``](

[ ] ### url

)

I don't understand why lerna init would have anything to do with OS permissions; it is usually used to create a new lerna monorepo.
https://github.com/lerna/lerna/tree/main/commands/init#readme
Are you sure that installing lerna using sudo was not enough to fix your permissions issue?

No ,whenever I run it without initialising lerna on ubuntu (as I don't use windows),I get error .To confirm this I ran this repo about 3 times without initialisng which in result given error but after initialising lerna It works fine.

Can you please run 'lerna --version' before and after you run 'lerna init'?
Also does package.json get modified?

Actually sudo fixed my permission issue but without lerna init it didn't work.And version and package.json remains same .Why version of lerna and package.json  would  change after and before initialising lerna ?It's obvious that it will remain same.

I am sorry but now , i didn't use lerna init and it ran fine.


Android - Loans Tab has a delayed response

What would you like to be added:

The tabs in Loans have a slight delay when changing the active tab

Why is this needed:

I don't think that the delay when changing tabs in the loans area is more than in any other are of the application.


Add support for grpc server.

Is your feature request related to a problem? Please describe.
Currently, interceptors which will capture and replay the responses for API testing are not added by keploy/go-sdk. Please add support for gRPC server.
Describe the solution you'd like
Add gRPC server interceptor that could help in integration with keploy/go-sdk.
Describe alternatives you've considered
I thought of using Echo or WebGo(version 6 or 4) router for routing in my app.
Hope support for gRPC server would added soon.

Added changes in #148 PR. Closing this issue


Change how Private is implemented to better support type checkers

This PR changes how Private is implemented to add support for type checkers, now:
import strawberry

x: strawberry.Private[int]

reveal_type(x)

returns int
This is better as now type checkers won't complain about Private fields :)

Hi, thanks for contributing to Strawberry 🍓!
We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!
So as soon as this PR is merged, a release will be made 🚀.
Here's an example of RELEASE.md:
Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)
Here's the tweet text:
🆕 Release (next) is out! Thanks to Patrick Arminio for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)


KubeApiServer Discovery : False Negative

On my machine, I have successfully authenticated the Kubernetes API server. However, when I receive a response from the server, it shows an Unauthorized error code (401), but the response header does not include the term "Kubernetes." As a result, the network scanner fails to detect the KubeApiServer.
Response
{
  "kind": "Status",
  "apiVersion": "v1",
  "metadata": {},
  "status": "Failure",
  "message": "Unauthorized",
  "reason": "Unauthorized",
  "code": 401
}

To address this issue, I have implemented a workaround. I parse the response as JSON and then examine the kind field. This field is commonly present in Kubernetes API responses.
For status response with code as 200 K - kind field is equal to APIVersions
{
  "kind": "APIVersions",
  "versions": [
    "v1"
  ],
  "serverAddressByClientCIDRs": [
    {
      "clientCIDR": "<IP_ADDRESS>/0",
      "serverAddress": "<IP_ADDRESS>:443"
    }
  ]
}

For status response as 401 or 403 K - kind field is equal to Status
Let me know if this sounds okay to you, I'll push the fix! @slashben


telegram-notify 1.0.1

New Pull Request Checklist
Please mark the points which you did / accept.

[x] I will not move an already shared step version's tag to another commit
[x] I read the Step Development Guideline
[x] I have a test for my Step, which can be run with bitrise run test (in the step's repository)
[x] I did run bitrise run audit-this-step (in the step's repository - note, if you don't have this workflow in your bitrise.yml, you can copy it from the step template.)
[x] I read and accept the Abandoned Step policy

@mcaldas please close this pr, remove the branch of this PR in your fork and re-run the share.


build: do basic gcc build in CI

As of this week we no longer test GCC in CI. Optimally, we should at least do a server (non-test) build with GCC to make sure we don't have any compile issues.

cc @lizan

FWIW, the Bazel CI we setup uses GCC from Ubuntu 18.04.
https://buildkite.com/bazel/envoy


doc/design: Update the release documentation

Update release.md now that the repository uses goreleaser to
automatically produce draft releases for new tags.
Signed-off-by: timflannagan<EMAIL_ADDRESS>
Description of the change:
Motivation for the change:
Reviewer Checklist

[ ] Implementation matches the proposed design, or proposal is updated to match implementation
[ ] Sufficient unit test coverage
[ ] Sufficient end-to-end test coverage
[ ] Docs updated or added to /doc
[ ] Commit messages sensible and descriptive

/approve

/lgtm

rebased against master to make branch protection happy.

Ah - the PR had already been approved by @perdasilva, adding an lgtm.
/lgtm

Force merging as this PR only affects the release documentation and we don't need to continuously run the e2e-tests workflow to get a successful check for this be automatically merged.


add a description in the "about this repository" section

possibly something like "A game in COBOL using SDL2", maybe with adding a link to the video

Yeah, I should have put those there. Down now. Thanks!


Component integration tests failing in phantomjs

Any word on this TODO here?
I'm trying to create component tests for my project using phantomjs and the test runs fine in the Chrome browser, but fails with phantom. The error is "TypeError: undefined is not a function (evaluating 'Number.parseInt(offset, 10)')" from this function call in ember-scrollable

@Syzygy24 please check out #343


Support for mobile

Thanks for the neat extension :)
Linkding's support on mobile is very limited right now. Regardless, this would be a great extension to also use on mobile devices. Right now the injector doesn't seem to appear?
I did a rough mockup of what this could look like:

Hey, thanks for the suggestion and the nice mockup!
Unfortunately I have no experience with developing and debugging browser extensions for mobile browsers, so don't expect to see this any time soon. Or are you offering to implement this via PR?

Right now the injector doesn't seem to appear?

Did you try out the extension in a mobile browser? If so, which one did you use?

Did you try out the extension in a mobile browser? If so, which one did you use?

Firefox Nightly, which has an option for untested extensions.

Unfortunately I have no experience with developing and debugging browser extensions for mobile browsers, so don't expect to see this any time soon. Or are you offering to implement this via PR?

Totally OK, I don't have a ton of time either I just wanted to check if it's something you've tried yet, and if you'd accept a PR (?). When I get some free time I'll try to put this together. I suspect it's not appearing because mobile Google/DDG is missing the sidebar element

if you'd accept a PR (?)
definitely. If you do decide to work on it I'd greatly appreciate some testing/debugging instructions, since like I said I don't have experience with this and would have to maintain this in the future.

I suspect it's not appearing because mobile Google/DDG is missing the sidebar element

That's would be my first guess as well. The content script locates the sidebar element via document.querySelector() and the relevant id of the sidebar and then injects the html.
In the case of google it actually constructs the sidebar element, since google completely removes it if there is no sidebar content (other search engines just have an empty sidebar element)
https://github.com/Fivefold/linkding-injector/blob/b3d55b40b3648af07358744ab124d0959d53f11b/src/searchInjection.js#L156-L172
So if you can debug on mobile firefox you could try to search in the source code for a div with id "rhs" on google to see if the injection works at all.

You can now install the extension on regular Firefox for Android as well, using a (clunky) workaround:

Go to the firefox extension page for the injector extension.
Switch to desktop mode (by clicking on the three dots next to the address line and then on "Desktop site").
You can now install the extension.
Navigate to the extension settings directly through the firefox settings (Settings > Extensions > linkding injector > Settings). Accessing the injector settings via the cogwheel in the injection box won't work.
Add your connection data and configure the extension.

Unfortunately, injector results will only be shown if you also access the search pages in desktop mode, as the sidebar is hidden in the mobile view. Maybe I can add a different injection method for mobile views (injecting into the regular results area), but it won't happen anytime soon. Pull requests are welcome however, as always.


Backwards Compatibility

I don't know if this is an 'issue' or not, but using this library to parse for, say, an Android device will have non-optimal results if a Unicode 8.0 emoji comes in.
Though fitzpatrick modifiers can be removed, 'unsupported' emoji may want to have an alternative (for example, for those parsing from, and then back to, emoji). A zipper-face emoji could be transformed to a regular face, as one example.
This issue will hopefully EVENTUALLY be overcome by events when Android has up-to-date emoji support, but will also be necessary for at least some time for iOS devices without the latest update after they are added, after Unicode 9.0 comes out sometime this year.

One of the solutions would be to add this information in the emojis.json file and to provide a way to specify which compatibility level we want.
The "code" part should be pretty easy but the hard work will be to enter the information in the json file... Thoughts?

The easiest change is the fitzpatrick modifier ignorer. With some sort of flag, perhaps, you can lop off any of those modifiers.
The harder one is exactly what you alluded to, the manual selection of "appropriate" covered emoji for those platforms that don't have all of them in.

No movement on this issue, I'm closing for now.


[#106] Address new url.Parse behavior during setup

These changes should address the new url.Parse behavior. The relative SSH URL portion is treated as a port. Since ports parsed by url.Parse must now be numeric, this breaks relative SSH URLs.
The approach I took was to inject a temporary port number, parse the URL, and remove the injected port. All tests pass. That being said, this code needs more eyes on it to make sure all edge cases are addressed by these changes.

Does this fix #106?

Does this fix #106?

It resolves the issue for me and is the most minimal approach I could come up with to address the issue. There's no telling when the author may rule on this PR, so feel free to use the master branch in my fork until then. My master branch is diverged from this repo only insofar as the import paths are concerned and to include my changes in this PR.


Cannot login SSL certificate verify failed

Trying to login with the latest build of PixivDownloader2. But got an error only:
Log:
"
PixivDownloader2 version 20160613
https://github.com/Nandaka/PixivUtil2/releases
Donate at https://bit.ly/PixivUtilDonation
Reading d:\Soft\Network\Download\pixivutil\config.ini ...
done.
using default DB Path: d:\Soft\Network\Download\pixivutil\db.sqlite
Creating database... done.
Only process member where day last updated >= 7
Using Username: 13666999
Logging in...
Error at login(): (<class 'urllib2.URLError'>, URLError(SSLError(1, u'[SSL: CERT
IFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:590)'),), <traceback ob
ject at 0x01041698>)
Error at doLogin(): (<class 'urllib2.URLError'>, URLError(SSLError(1, u'[SSL: CE
RTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:590)'),), <traceback
object at 0x010514E0>)
Cannot Login!
"

I can login from my pc. Can you open the site from browser or other PC?

Yes, I can login from browser in both my PC. But got this error and cannot login from Pixivutil2 on WIndows XP. Windows 7 seems login normally with PixivUtil2.

I don't have xp machine anymore, so I'm not sure why. I suspect the root certificate is not updated? Try to login using internet explorer in your xp machine?

it's login normally on xp: http://f4.s.qip.ru/cMfvWyIA.png
Seems site even don't needs ssl certificate to login.

Nope, it requires https for the login part. I don't do any special handling for that.
One way of doing is by using cookie method for login.


Rails/SaveBang should flag update_attributes

update_attributes is an alias for update and should trigger Rails/SaveBang under the same conditions. I think :update_attributes just needs to be added here.

Expected behavior
Rails/SaveBang should error on update_attributes in the same conditions as update (as it is an alias).
Actual behavior
It permitted it.
Steps to reproduce the problem
Turn on Rails/SaveBang and lint against model.update_attributes.
RuboCop version
-> rubocop -V
0.46.0 (using Parser <IP_ADDRESS>, running on ruby 2.3.3 x86_64-darwin16)

The problem is that update is a super generic name and this will trigger A LOT of false positives in any codebase...

@bbatsov

The problem is that update is a super generic name and this will trigger A LOT of false positives in any codebase...
But it is the other way around, it already complains about update, but it doesn't complain about update_attributes

LOL! Silly me! Thanks for pointing this out @Ana06! :-) Yeah, fixing this should be trivial then.


[Question] Which phase should we submit to evaluate the VisWiz in the paper?

Question
As described by the paper, I see there many phases for VisWiz benchmark to submit. Could anyone point out the exact phase we should submit?

I choose the test-standard2024-VQA phase, and then submit my json file. Then I go to the My Submission page to check the result file for the results. I get 54.3 on ''overall'' metric with llava-1.5-13b, which is close to the 53.6 in the paper.

Thanks for your data point. However, I tried the test-dev2024-VQA and got "overall" 51.36, which is close to llava-1.5-7B's 50.0. So I am still confused lol.

Based on Vizwiz's official page, test-dev consists of 4,000 test visual questions and test-standard contains all 8,000 visual questions in the test dataset. I found that there are 8,000 questions in llava_test.jsonl, so I think test-standard2024-VQA phase is the correct one.


change icon

We ended up with a lot of people confused by RM's icon being so similar to CruiseMonkey's (especially since they're both published in the app stores as my account).  RM should be changed to something visually distinct from CM.

I landed a new icon. Might update it again if someone has better artwork.


Not enough space for displaying all children

I either get a black screen or visual glitches of the underlying windows. I have tried setting fullscreen=1 in config.ini as in #83 but this changes the monitor resolution completely and results in a permanently zoomed-in screen. Running Ubuntu 14.04.
[INFO              ] Kivy: v1.9.1
[INFO              ] Python: v2.7.6 (default, Jun 22 2015, 17:58:13)
[GCC 4.8.2]
[INFO              ] Factory: 179 symbols loaded
[INFO              ] Image: Providers: img_tex, img_dds, img_gif, img_sdl2, img_pil (img_ffpyplayer ignored)
[INFO              ] Text: Provider: sdl2
[INFO              ] OSC: using <multiprocessing> for socket
[INFO              ] Window: Provider: sdl2(['window_egl_rpi'] ignored)
[INFO              ] GL: OpenGL version <3.0 Mesa 10.1.3>
[INFO              ] GL: OpenGL vendor <Intel Open Source Technology Center>
[INFO              ] GL: OpenGL renderer <Mesa DRI Intel(R) Broadwell >
[INFO              ] GL: OpenGL parsed version: 3, 0
[INFO              ] GL: Shading version <1.30>
[INFO              ] GL: Texture max size <8192>
[INFO              ] GL: Texture max units <32>
[INFO              ] Window: auto add sdl2 input provider
[INFO              ] Window: virtual keyboard not allowed, single mode, not docked
[INFO              ] Clipboard: Provider: gtk3(['clipboard_dbusklipper'] ignored)
[INFO              ] Cutbuffer: Provider: xclip
[INFO              ] CutBuffer: cut buffer support enabled
[INFO              ] Base: Start application main loop
[INFO              ] GL: NPOT texture support is available
[WARNING           ] Accordion: not enough space for displaying all children
[WARNING           ] Accordion: need 220px, got 100px
[WARNING           ] Accordion: layout aborted.
[WARNING           ] Accordion: not enough space for displaying all children
[WARNING           ] Accordion: need 176px, got 100px
[WARNING           ] Accordion: layout aborted.
[WARNING           ] Accordion: not enough space for displaying all children
[WARNING           ] Accordion: need 220px, got 100px
[WARNING           ] Accordion: layout aborted.
[WARNING           ] Accordion: not enough space for displaying all children
[WARNING           ] Accordion: need 176px, got 100px
[WARNING           ] Accordion: layout aborted.
[WARNING           ] Accordion: not enough space for displaying all children
[WARNING           ] Accordion: need 176px, got 100px
[WARNING           ] Accordion: layout aborted.
[WARNING           ] Accordion: not enough space for displaying all children
[WARNING           ] Accordion: need 176px, got 100px
[WARNING           ] Accordion: layout aborted.
[WARNING           ] Accordion: not enough space for displaying all children
[WARNING           ] Accordion: need 176px, got 100px
[WARNING           ] Accordion: layout aborted.
[WARNING           ] Accordion: not enough space for displaying all children
[WARNING           ] Accordion: need 176px, got 100px
[WARNING           ] Accordion: layout aborted.
[WARNING           ] Accordion: not enough space for displaying all children
[WARNING           ] Accordion: need 176px, got 100px
[WARNING           ] Accordion: layout aborted.
[WARNING           ] Accordion: not enough space for displaying all children
[WARNING           ] Accordion: need 176px, got 100px
[WARNING           ] Accordion: layout aborted.
[WARNING           ] Accordion: not enough space for displaying all children
[WARNING           ] Accordion: need 176px, got 100px
[WARNING           ] Accordion: layout aborted.
[INFO              ] Base: Leaving application in progress...

Hi,
You should be able to run kivy designer with these warning (it's ok to have these warns now). Does it crash ? Have you ever used any kivy app/example ?

Kivy designer crashes. I have tried a simple hello world program. In that, the window loads fine, but only displays black. This is probably a kivy problem. I am running on Acer Chromebook C740, and a google search tells me there may be problems with the device and kivy.

Hi @wxv ,
I'm closing this issue, because it seems to be a problem with your env. If necessary, feel free to reopen it.
Thank you


How to get the current value of the fuse change from the FusesSet event log?

After the ENS FusesSet event log has been cleaned, it is no longer possible to retrieve the current value of the fuse change from the log.
Is there any solution to this problem?
Related event log link: https://etherscan.io/tx/0xf0d11296e8954146a7e7e21ce2f17f120b72af134194412931bb4402487dcab4#eventlog

Do you mean the value before the change? You're right, the log only contains the value after the change.

Do you mean the value before the change? You're right, the log only contains the value after the change.

Yes. Including the value before the change and/or the changed value in the event log would be beneficial.

yes
Historical Data: If you have access to a historical data service or blockchain explorer that records and archives all events, you might be able to retrieve the past logs from there. These services often store historical data, allowing you to access events that occurred before the log was cleaned.
It's important to note that the availability and feasibility of these solutions depend on the specific circumstances and infrastructure of your system.


Screen reader user is unable to differentiate current date and previously selected date in the date picker

Clarity Version: 3.1.1
WCAG 2.1 Guideline: 4.1.2 Name, Role, Value
Test Environment:

Test URL: https://clarity.design/documentation/datepicker
OS: Windows 10
User Agents/Assistive Technologies: Firefox 76.0
Screen reader: NVDA 2020.1

Steps to reproduce:

Open the test URL.
Go to toggle datepicker button and press it.
Select any random date from the date picker for current month.
Open the datepicker again and observe spoken feedback for non selected dates, selected default and current/actual date.

Expected result:
Screen reader user should be able differentiate current date and previously selected date from other dates in that calendar month.
Actual result:
Screen reader user cannot distinguish different states of date, whereas same info is communicated to the sighted user visual cues.

Hi there, this is an automated message.
In an effort to dedupe and track accessibility reports consistently, this issue is being closed and tracked internally with our Accessibility team. It will still be triaged and addressed as part of ongoing work.


Object store access control - private data

We need people to be able to store private / unpublished data in their own area of the object store, even if this is stored locally.

Locally we could do this with file permissions. Otherwise it's dependent on the cloud platform and management for that object store, like bringing Acquire ACLs into play.

A user could also now do this with their own personal object store. Closing.


required md-select is not higlighted as error on form submit

Bug, feature request, or proposal:
Bug
What is the expected behavior?
Select should be red same way as md-input
What is the current behavior?
Select is not highlighted it stay as untouched
What are the steps to reproduce?
https://plnkr.co/edit/jEvWLqsrlUrnBjkUUBes?p=preview click submit and you will see that input is showing error but select is not
What is the use-case or motivation for changing an existing behavior?
Should be same way as other components
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
@angular/animations: 4.3.2
@angular/cdk: 2.0.0-beta.8
@angular/common: 4.3.2
@angular/compiler: 4.3.2
@angular/core: 4.3.2
@angular/forms: 4.3.2
@angular/http: 4.3.2
@angular/material: 2.0.0-beta.8
@angular/platform-browser: 4.3.2
@angular/platform-browser-dynamic: 4.3.2
@angular/router: 4.3.2
@angular/cli: 1.2.6
@angular/compiler-cli: 4.3.2
Is there anything else we should know?
In addition if required validator is applied md- controls should have asterix so user understand that fields are required. In Example md-input has required validator but label doesn't have *

This is resolved in master by https://github.com/angular/material2/pull/4754.

+1


Add concurrent package validation

Use multiprocessing from the std lib to concurrently validate
packages.  Add a cli argument num-threads setting the number of
concurrent processes to be used.

Add test for three concurrent scenarios:  num_threads=0 using all
available cores, num_threads=1 for serial validation,
num_threads=4 explicitly using four processes.

Adapt Travis script to properly measure test coverage with concurrent
validation.

This is a cleaned-up version of #45.

works locally. Thanks @willirath ! Merging, tagging and deploying a new version to pypi/conda-forge

Outstanding! :+1:

should be able to pip install 0.7.0 which has the additional command line flag --num-threads that allows you to do concurrent package validation.

conda package for 0.7.0 should be available in the next week or so.


Smooth normals on imported USD files

Hello, first of all Thank you for bringing USD compatibility with Unity.
I just want to inform that I found that when I import a USD file with this SDK, everything looks good, except that the normals are smooth.
this is what I would expect to see:

this is what I get:

Hey @Baruchware! Thank you for reporting. Do you have a file you could share as a reproduction case to help us investigate this issue?

Yes I have it, I can share with you the ".usd" and the ".usda" files!
usd_files.zip

@Baruchware Thank you for sharing! I will test this out and file a bug internally. Could you please also share:

your Unity version
whether your project uses Built-in Render Pipeline, URP or HDRP?

Hello! Thank you a lot for the response!
Of course I can share these info, sorry if I didn't do that before.
Unity Version: 2022.3.5f1
Rendering Pipeline: URP
Yes I am importing using Preview Surface
hope this can help you out :blush:

Hello @Baruchware, thank you for the additional information!
Sadly at the exact moment, the URP is not supported, but @vickycl has created PR which will add a bit of support to importing on URP - could you please try your workflow on that branch?
Also about the transparency, the package does not automatically set the following settings at the moment:

Transparency
Double sided

you need to set them manually after importing - sorry about the trouble
Thank you once again, and let us know if you have more questions or problems!

hello @lee-aandrew and thank you so much for the details,
Please forgive my ignorance, but it is not clear to me how to install in Unity a custom branch, I tried uploading the "package.json" from disk but seems it is not different from the main branch.
can you please what are the steps in order to install it?
Thank you in advance!

hey @Baruchware!
Sorry for not being specific on how to have the package set a branch!
So assuming you aren't too familiar with git

Install git
Clone this repository by opening your windows commandline and entering in git clone https://github.com/Unity-Technologies/usd-unity-sdk.git
This will create a folder called usd-unity-sdk
Now open up Unity, and install the package via Package Manager -> Install Package from Disk... ->
Go into your usd-unity-sdk folder, open up another commandline from that folder, and enter in the command git checkout exp/urp-import-support
This should set your package to the branch i mentioned

Or if this is all a bit too much for you, I've zipped up the package on that branch Google Drive Link (sorry its too big to attach here), unzip this and install it to Unity by Package Manager -> Install Package from Disk... ->
But having said all that, I have to say this package at the moment does not support GeomSubsets or multiple materials on a single mesh - but it is on our radar
Thank you once again, and please let us know if you have any more problems / questions!

I am very very very sorry for the late reply.
I was on holiday and upon my return I had emergencies to manage on other projects.
I am so sorry for that!
I Just want to thank you for this detailed information, soon I will resume all my tests concerning this package!!


readme: add new project setup example

Closes #117
Show in the readme how you can create a new project and use mx in-tree as a CMake subdirectory.

Problem with xcode seems likely to be unrelated, created #119

Problem with xcode seems likely to be unrelated, created #119


Mod Robert Hayes

Robert Hayes was originally a moderator of the Regis Discord Server, but it seems that some sort of error has rendered his moderation privileges obsolete. It might be wise to investigate how his moderation privileges were removed.

BAZINGA boi approves of such a noble investigation! May our one true mod be remodded soon.
haha LOL

for confirmation of this, ask me in person


Improve manage_all.py code

Signed-off-by: DTadrzak<EMAIL_ADDRESS>

@PiotrProkop

manage_all raise exception No such file or directory without any information when kubectl is no available /usr/bin/.
Maybe make more descriptive exception?

it's not a manage_all issue. It should be handled by stackanetes code. Mange_all only execute stackanetes.

Actually if you're improving manage_all.py, it'd be nice to explain this:
services = [file_name[:-4] for file_name in services]
(os.path.splitext would do the job)


Fix onchain payment QR codes according to BIP21

According to BIP21, Bitcoin URIs start with bitcoin: scheme component. Also, there is no point in uppercasing address part here, as only benefit is smaller QR codes if string contains only uppercase letters, but that is not the case, as amount= and label= are required to be lowercase.
Also, existing code would not work properly if user has legacy or psh-segwit configured as addresstype in Bitcoin Core, as only bech32 addresses are case insensitive.

thanks!


StaticFile.fromFile — handle empty file

resolves #429

:+1: This looks good to me. It would be good to have a second review considering the very imperative nature of that section of code, but barring objections I'll merge this tonight.

The question: "who would want to serve an empty static file?" bugs me though...

It at least shouldn't throw an exception resulting in a 500 right?

Well, for me, the idea is you catch these things early... if it was dynamic content, sure, you should be able to send out empty bodies, but StaticFile isn't for dynamically generated contents. Personally, getting a 500 because I have an empty static file somewhere is something I would like as I am developing and doesn't really bother me.
And a very strong argument could be made against using StaticFile for dynamically generated content, you could just wrap the file in a process, etc. there is no need to read E-Tags, or any other file metadata if the content is supposed to be fresh anyways...
I mean, I understand your position, when I was working on this file I was tempted to lax the constraint myself. I could go either way, just wanted to offer the counter argument for consideration...

So is there objection to merging this? While they seem pointless in this
context a zero length file is a thing.
I'm inclined to merge this.
On Oct 14, 2015 3:55 PM, "Rodolfo Hansen"<EMAIL_ADDRESS>wrote:

Well, for me, the idea is you catch these things early... if it was
dynamic content, sure, you should be able to send out empty bodies, but
StaticFile isn't for dynamically generated contents. Personally, getting a
500 because I have an empty static file somewhere is something I would like
as I am developing and doesn't really bother me.
And a very strong argument could be made against using StaticFile for
dynamically generated content, you could just wrap the file in a process,
etc. there is no need to read E-Tags, or any other file metadata if the
content is supposed to be fresh anyways...
I mean, I understand your position, when I was working on this file I was
tempted to lax the constraint myself. I could go either way, just wanted to
offer the counter argument for consideration...
—
Reply to this email directly or view it on GitHub
https://github.com/http4s/http4s/pull/430#issuecomment-148177724.


not sure why this happened

Description
A description of the PR, should include a decent explanation as to why this change was needed and a decent explanation as to what this change does
Review Instructions
Describe if this ticket needs review and if so, how one may go about it in qa and/or staging environments.
For example, a ticket based on Security Hub, Snyk, or Dependabot may not need review since those services
will generate new warnings if the issue has not been resolved properly. On the other hand, an infrastructure
ticket that results in visible changes to the end-user will definitely require review.
Many tickets will likely be between these two extremes, so some judgement may be required.
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5558
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!

[ ] Check that you pass the basic style checks and unit tests by running ./mvnw clean install
[ ] If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

INFO ['docker', 'pull', 'java:7']

;grumble:


Can I add my dinosaur Javascript video game in this repository?

Can I add my dinosaur Javascript video game in this repository?

Sure :)


pull request for e2e test at 12/26/2016 14:45:06

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Comparing the performance differences between the official dash.js and LoL+ code base

There are likely some differences in terms of performance between two code bases. We should conduct a through comparison.

https://github.com/Dash-Industry-Forum/dash.js/pull/3663 should address some of the issues in dash.js codebase. This one is for v4, though the same update can be used for v3 clients.


Show all tasks in related_to select box when creating task

I thought the task controller already accept taskable_type and taskable_id 2 parameter, which allow pulling tasks from all 3 resources?

Oops, wrong description. Fixed the title


Issue when using transparent network with sql container images

I have been working with the latest sqlexpress and sql vNext container images on docker hub and have identified what appears to be an issue only when using a transparent network (2 issues actually):
1 - minor issue - ip address is not visible when using docker inspect but I can ping the container by name successfully
2 - only when using transparent network, I receive "login failed for user sa;' when attempting to conntect to the sql instance.  I can use the exact same docker run command (minus --network) and I can login and access sql just fine.
I am using the run command specified on docker hub, just added the --network=lan (and removed -p 1433:1433).  Also confirmed that the password is complex (cap, lowercase, number and special character, 8 characters long):
docker run -d --network=lan -e sa_password=<SA_PASSWORD> -e ACCEPT_EULA=Y -v C:/temp/:C:/temp/ -e attach_dbs="[{'dbName':'SampleDb','dbFiles':['C:\temp\sampledb.mdf','C:\temp\sampledb_log.ldf']}]" microsoft/mssql-server-windows

Removing the option to run in detached mode seems to resolve the problem.  Are detached mode and transparent network incompatible?  Thanks

Firewall?

Maybe you need to --expose the port 1433 (actually you have correctly removed the port mapping which is incompatible with transparent network type; instead you need to expose the port or I suppose you have to do so).


Overlay does not cover the entire screen, status bar still visible, how can I fix that?

Just change "applicationFrame" to "Bounds" where it occurs in two places - in init and longPressDetected


Improvement Request: Explorer Find should automatically unfold folders

To get an overview of a new project's structure I was searching for a particular file extension in Explorer.
I was very surprised to see that the Explorer Find "filter" option ("workbench.list.defaultFindMode": "filter") doesn't automatically unveil files in folded directories:

I believe this is confusing as in larger projects it's easy to have a directory folded and miss files when using the Explorer Find operation.
So, I'd like to propose to add a new option to File Explorer to have Find mode "filter" …

automatically unfold folders containing matched files (with a detain delay of 300 ms to keep the unfolding algorithm from expanding all folders when the first letter has been typed by the user)
automatically restore all folders fold/unfold state when Find input dialog is closed; except when one or more of these files are currently selected. Then the folders of the selected files should be expanded after restoring the previous folded/unfolded state.

The name of that enum setting may be similar to: "workbench.list.expandMatchingFolders" and possible values may be:

no  -- current behaviour, no folder expansion is taking place
yesAndRestore  -- unfold all matching folders; restore all folders when Find dialog is closed, but keep selected files' folders expanded
yesAndKeepExpanded  -- unfold all matching folders; keep all folders containing matched files open when Find dialog is closed (regardless of files being selected), restore all other folders to their previous state

This is essentially duplicate of #66971 with additional text and options.

Ah, yes. I guess someone at GitHub needs to invent semantic search. I'd never have searched for "resolve folders".

The suggested algorithm would be quite simple and easy to implement:

Filter dialog opens, initialize:

Store the paths (resp. Ids) of all folders currently being expanded in Explorer into an array (e.g. expandedFolders: string[] = …;).

While searching:

When the first character is being typed into Filter text input box, expand all folders in Explorer. (This will boost overal filtering performance.)
Perform filtering as you do already.

Filter dialog closes, finalize:

switch (config.workbench.list.expandMatchingFolders)
{
  case expandMatchingFoldersType.yesAndRestore:
    expandedFolders.concat(selectedFolders);
    break;

  case expandMatchingFoldersType.yesAndKeepExpanded :
    expandedFolders.concat(matchingFolders);
    break;
}

Collapse all folders. (This task already exists in the Explorer toolbar.)
Expand all folders listed in expandedFolders.
Select all matching files.

Will close as duplicate of #66971 here these folders have already been resolved, but the filter is still just a visual one meaning collapsed nodes aren't acted upon. This is highly requested fix and it is on our radar.


[WFLY-18012] Do not attempt to load the ConfigurationFactory during u…

…ndeploy if the deployment is not a REST deployment.
https://issues.redhat.com/browse/WFLY-18012

Thanks @jamezp and @fjuma


Does not work in iOS

hey, there have  a issue in my project.
error message:
'WebViewBridge' has no propType for native prop 'RCTWebViewBridge.keyboardDisplayRequiresUserAction' of native type 'BOOL' If you haven't changed this prop yourself, this usually means that your versions of the native code and JavaScript code are out of sync. Updating both should make this error go away.
I checked the Issues, and I don't find what I need.
And my RN version is "react-native": "0.41.2" . Have some one can help me?

Need to delete this line:
https://github.com/alinz/react-native-webview-bridge/blob/master/ios/RCTWebViewBridgeManager.m#L53


interval(TimePoint when) ambiguity

Actual implementation of interval(TimePoint when) waits for the specified time point and then starts emitting integers infinitely:
    auto scheduler = rxcpp::identity_current_thread();
    auto start = scheduler.now();
    auto values = rxcpp::observable<>::interval(start, scheduler);
    auto s = values.
        map([&](int prime) {
            return std::make_tuple(std::chrono::duration_cast<std::chrono::milliseconds>(scheduler.now() - start).count(), prime);
        });
    s.
        take(3).
        subscribe(
            rxcpp::util::apply_to(
                [](__int64 t, int v){printf("OnNext: %d. %ld ms after the first event\n", v, t);}),
            [](){printf("OnCompleted\n");});

OnNext: 1. 0 ms after the first event
OnNext: 2. 0 ms after the first event
OnNext: 3. 0 ms after the first event
OnCompleted

It happens because the default value of period is rxsc::scheduler::clock_type::duration::max(), and that causes integer overflow on the next occurence time calculating: *target += period;. So we schedule the next integer in deep past and emit it immediately.
Is this the intended behavior or an issue?

P.S. On Rx.NET, there is interval(period) instead of interval(when). This choice looks more useful, probably we should switch our implementation to this.

This is an issue. The max value for period is intended to be invalid. This would mean that on_next is called only once in this case and then on_completed is called.
I think that we should support only passing the period, only passing the initial time and passing both. What do you think?

Intervals with the period and with both initial&period look good and conform with interval interface on RxNET and RxJava. As for interval with the initial time, RxNET and RxJava has timer operator that does exactly the same:

The Timer operator creates an Observable that emits one particular item after a span of time that you specify.

So, if we implement interval with the initial time, it could be confusing for people who is migrating from .NET/Java. In addition, timer is well described on introtorx and reactivex. Thereby I propose to modify interval to accept either the period or initial&period and make a new operator timer(when, [scheduler]).

Yes, that is a good idea.

timer added in cf345e3f5c82e26ea434e287fe4974412f7f69d8


Banner label for publications release/archive and preview

Team will need to be able to set a parameter at publication which populates blue banner on home page for previews, actual releases and for archive.
Parameter/capability to trigger use of different stylesheets for the different publication types.

This is already in place (Archive publication is an example)
@maxChappell @AngelaFaulding Can we close?

This is already in place, there is a separate ticket for previews when 3++ is live.

This is already in place, there is a separate ticket for previews when 3++ is live.


i18n for Static Generators, like Hugo

That ^

@ToyoDAdoubi, I've got some new stuff for you (https://github.com/hacdias/filemanager/commit/da4fd84002f4cac1d4e04f65c96237a553203d83#diff-fe6ccd8f0bf41f00b9ff5d61b8e0e3e9) 😄 Thank you!

@hacdias What is "Hugo New"?
Also, why is there "post"?
Functional misunderstanding can cause translation barriers.

Hello, Hugo New will only show up when the user activated the Hugo module (a static website generator). Hugo New is a command of Hugo CLI so I think that the best option is to leave it as it is.
Post is not the verb, but the name (equivalent to article).

@hacdias complete!
Before specific function is not clear, it may be not accurate enough.
https://github.com/hacdias/filemanager/pull/196

Thanks 😄


Docs improvement: Explain plan model

I primarily work in python, but some recent work in the node.js world introduced me to TAP. Specifically, node-tap, which has explicit plan counts. eg,
import tap from 'tap';

tap.test('some test description', function(t) {
    t.plan(2);
    t.ok(true);
});

In addition to the other benefits of TAP, the plan count is a great sanity check. In the above, the test case fails because it's expected that two assertions be made.
In tappy (and other python TAP implementations), there doesn't seem to be an explicit plan count check. However, it looks like tappy tries to infer some plan count, although it's not immediately clear how it works, what it does, or what the count is for. So,

could you explain how plan works in tappy? :)
is the plan count the number of TestCases, the number of test_methods, the the number of self.assert()s?
would it make sense to add an explicit self.plan() method to TestCase?
also, if plan is supposed to infer how many assertions should be made, the below is a false positive. I would expect a plan count of 1, but the assertion is never executed.

    def test_with_assert_raises(self):
        with self.assertRaises(Exception):
            raise Exception('')

            self.assertTrue(False)

@rpkilby, great questions, thanks for asking. Whatever the outcome of this discussion, it sounds like the documentation needs to be beefed up on this topic. :smile:

could you explain how plan works in tappy? is the plan count the number of TestCases, the number of test_methods, the the number of self.assert()s?

The plan is purely generated from the count of test methods that are within the suite. The plan is there to comply with the TAP spec.
I made the design decision to base TAP lines on test methods because that is the default expectation within the Python ecosystem. unittest, nose, pytest, trial, etc. all report their results (i.e. ., F, E) at the method level. Per assertion could be pretty cool, but I didn't want to diverge from that expectation.
As you may know, TAP originates from Perl's ecosystem. In Perl's Test::More, the plan could either be a number or a special noplan string. Given those options, that led to a few mental models for thinking about the plan. Conceptually, plans can:

be at the top of the stream and be like "there should be this many tests"
be at the bottom of the stream and be like "there should have been this many tests"
be at the bottom of the stream and be like "there were this many tests"

Of those modes, tappy adopts the last one. The reason for that choice is because of how Python test runners work. In a Python test run, each test method runs, regardless of whether previous tests failed or erred. Since tappy reports at the test method level and runners will run all tests, the plan should always match the count. If there is a mismatch, it would indicate a broken runner and not a broken test suite.
Let's quickly contrast this with Test::More. In a Test::More test run, the test runs as a top to bottom script. Any error (i.e., E in Python-land) causes the entire test script to "crash" and the rest of the tests do not run. It's hopefully clear how the plan becomes super valuable in that environment.

would it make sense to add an explicit self.plan() method to TestCase?

Typing all this out is leading me to a conclusion that supporting a plan() method would not make much sense to me. If test runners guarantee to run all tests even if there's an error, what would an explicit plan buy a developer? If I'm missing some use case here, I'm all ears.

also, if plan is supposed to infer how many assertions should be made, the below is a false positive. I would expect a plan count of 1, but the assertion is never executed.

Because plans are method based, the example is not a false positive. Hurray!
I hope this is a satisfactory answer. Let me know if you have questions. I'll leave the issue open as a reminder to make the plan documentation better. Thanks!

Hi @mblayman - thanks for the in-depth answer. I looked into the possibility of an assertion based plan mechanism, but agree that it's not really feasible. Each assert method would have to increment some counter. This doesn't seem like it would actually work out that well:

wouldn't work with pytest's use of plain assert (probably, unless unittest's assertion methods are called under the hood).
custom TestCases with custom assert methods would now have to increment this new counter.
Some assertions work by calling other assertion methods. This practice fails when an assertion methods calls other assertion methods. eg, assertDictEqual. It would be very confusing to users to call assertDictEqual once, then have to increment the plan by two.

Of those modes, tappy adopts the last one

And this makes sense. I believe node-tap adopts something like the first implementation. eg,
import tap from 'tap';

tap.test('test a thing', function(t) {
    t.plan(2);
    t.ok('yep');

    t.test('this is a subtest', function(s) {
        s.ok('yyeepp');
    };
});

is equivalent to
import tap from 'tap';

t.plan(2);
t.ok('yep');
t.ok('yeepp');

The test structure is more there for readability (and some utility w/ setup teardown methods), but each ok/not ok assertion is its own line.

Since tappy reports at the test method level and runners will run all tests, the plan should always match the count. If there is a mismatch, it would indicate a broken runner and not a broken test suite. [...] If test runners guarantee to run all tests even if there's an error, what would an explicit plan buy a developer?

If they're running tappy's output through a higher-level parser, a plan at the top (option 1) would help them quickly identify malfunctioning test runners. This isn't incredibly useful with small, self-contained test suites, but if a huge number of TAP-based suites are being aggregated into a single stream, I could see it being very useful. (I've worked on such an aggregator in the past.) Having a false positive because something SIGKILL'd tappy in the middle of a four-hour test run wouldn't be very fun.
For the record, though, if such an option were added to tappy, I'd like for it to be as hands-off as possible. Manually updating an explicit plan count wouldn't be very friendly; other TAP producers I've used have collected and counted the tests automatically before they're run.

That sounds like it could be useful. Unfortunately, support for multiple plans in a single stream is not part of the spec. I even proposed such support last year for the next version of the spec and it was shown to be backwards incompatible (https://github.com/TestAnything/testanything.github.io/pull/36#discussion_r47317814)
Given that TAP won't be supporting single stream parsers, I don't think I have much personal interest in moving the plan to the top of the report. I suspect it would require some introspection magic across the various frameworks that would differ in method per framework. I'll opt for KISS here unless someone proposes an amazing PR that proves me wrong. :grinning:

Unfortunately, support for multiple plans in a single stream is not part of the spec. I even proposed such support last year for the next version of the spec and it was shown to be backwards incompatible

Right, but that's for the aggregator/multiplexer to deal with, not tappy. By moving the plan to the top, tappy simply makes it possible for aggregators to catch those problems in large systems. It makes the entire system more robust.
(I share your desire for subplans in TAP, by the way; that would remove the need for multiplexers entirely.)

I suspect it would require some introspection magic across the various frameworks that would differ in method per framework. I'll opt for KISS here unless someone proposes an amazing PR that proves me wrong.

That sounds fair to me. :smile:


tainning voc dataset error

conda create --name pointrend python=3.6
conda install pytorch==1.1.0 torchvision==0.3.0 cudatoolkit=9.0 -c pytorch
CUDA_VISIBLE_DEVICES=2 python -u tools/train.py --config-file configs/pascal_voc_deeplabv3_plus.yaml
[THOP Defined] Conv2d
[THOP Defined] BatchNorm2d
[THOP Defined] ReLU
[THOP Defined] Conv2d
[THOP Defined] BatchNorm2d
[THOP Defined] ReLU
[THOP Defined] Conv2d
[THOP Defined] BatchNorm2d
[THOP Defined] ReLU
[THOP Defined] Conv2d
[THOP Defined] BatchNorm2d
[THOP Defined] ReLU
[THOP Defined] Conv2d
<class 'torch.Tensor'>
2020-04-10 15:14:51,053 Segmentron WARNING: get flops and params error: new() received an invalid combination of arguments - got (list, dtype=torch.dtype), but expected one of:

(torch.device device)
(torch.Storage storage)
(Tensor other)
(tuple of ints size, torch.device device)
didn't match because some of the keywords were incorrect: dtype
(object data, torch.device device)
didn't match because some of the keywords were incorrect: dtype

2020-04-10 15:14:51,054 Segmentron INFO: Not use SyncBatchNorm!
2020-04-10 15:14:51,054 Segmentron INFO: Set bn custom eps for bn in encoder: 0.001
2020-04-10 15:14:51,060 Segmentron INFO: Start training, Total Epochs: 50 = Total Iterations 9150
<class 'torch.Tensor'>
Traceback (most recent call last):
File "tools/train.py", line 221, in
trainer.train()
File "tools/train.py", line 133, in train
outputs = self.model(images)
File "/home/yangwx/anaconda2/envs/pointrend/lib/python3.6/site-packages/torch/nn/modules/module.py", line 493, in call
result = self.forward(*input, **kwargs)
File "/mnt/data2/yangwx/GIT/SegmenTron/segmentron/models/deeplabv3_plus.py", line 36, in forward
c1, _, c3, c4 = self.encoder(x)
File "/home/yangwx/anaconda2/envs/pointrend/lib/python3.6/site-packages/torch/nn/modules/module.py", line 493, in call
result = self.forward(*input, **kwargs)
File "/mnt/data2/yangwx/GIT/SegmenTron/segmentron/models/backbones/xception.py", line 131, in forward
x = self.conv1(x)
File "/home/yangwx/anaconda2/envs/pointrend/lib/python3.6/site-packages/torch/nn/modules/module.py", line 495, in call
hook_result = hook(self, input, result)
File "/home/yangwx/anaconda2/envs/pointrend/lib/python3.6/site-packages/thop/vision/basic_hooks.py", line 27, in count_convNd
m.total_ops += torch.DoubleTensor([int(total_ops)], dtype=torch.float64)
TypeError: new() received an invalid combination of arguments - got (list, dtype=torch.dtype), but expected one of:

(torch.device device)
(torch.Storage storage)
(Tensor other)
(tuple of ints size, torch.device device)
didn't match because some of the keywords were incorrect: dtype
(object data, torch.device device)
didn't match because some of the keywords were incorrect: dtype

You can try to comment these lines: https://github.com/LikeLy-Journey/SegmenTron/blob/master/tools/train.py#L65-L69


An error about GLFW

Hello,dear authors of lambda!
We have meet a strange problem when we first finished my pip3 install . ,and run the commend on the server as you suggested:
python3 experiments/train.py --log_dir results/la_mbda/point_goal2/314 --environment sgym_Safexp-PointGoal2-v0 --total_training_steps 1000000 --safety
There exists a 'GLFWError' as the follows:
GLFWError: (65544) b'X11: Failed to open display :1'
Then ,the tqdm began and suddenly shut down at 0%. After that ,there come another problem about GLFW:
 GLFWError: (65537) b'The GLFW library is not initialized'.The whole process is then shut down.
We run the code on the server without any display device. So i wonder if the problem comes from the lack of the display as the GLFW is strongly related to 3D graph. Also,we'd appreciate if you can tell us how to run the code on a server without a display device!

Yes, GLFW doesn't work on headless machines (as par https://github.com/deepmind/dm_control).
I guess you are running the code on a headless machine with a GPU. If that's the case, I suggest the following:

Make sure you have GLEW installed on your server.
Before running the code, make sure to set the MUJOCO_GL environment variable to egl. That signals deepmind control suite to render with GLEW instead of GLFW.

Let me know if it didn't work out.
Good luck with your experiments! :mushroom:

Thanks for your carefully explaination!
I try to search the interface of the MUJOCO_GL, but I fail. So I wonder if the setting can be set in the configs or it shall be put directly before the train code in 'train.py' , like:
if __name__ == '__main__':
    config = train_utils.make_config(train_utils.define_config())
    from la_mbda.la_mbda import LAMBDA
    MUJOCO_GL="egl"
    train_utils.train(config, LAMBDA)

I have solved this error，thanks for your help！
I just add :
import os
os.environ['MUJOCO_GL'] = 'egl'
and it works perfectly!

Great! Nice that you could solve it.


Sequel 5.0 deprecation warning

Got a lot of these warnings today while running this benchmark inside a Heroku app:
SEQUEL DEPRECATION WARNING: Calling a dataset filtering method with a plain string is deprecated and will be removed in Sequel 5.  Use Sequel.lit("people.id = people.id") to create a literal string and pass that to the dataset filtering method, or use the auto_literal_strings extension.
/app/vendor/bundle/ruby/2.4.0/gems/sequel-4.46.0/lib/sequel/dataset/query.rb:1315:in `filter_expr'
/app/vendor/bundle/ruby/2.4.0/gems/sequel-4.46.0/lib/sequel/dataset/query.rb:1249:in `add_filter'
/app/vendor/bundle/ruby/2.4.0/gems/sequel-4.46.0/lib/sequel/dataset/query.rb:1034:in `where'
/app/vendor/bundle/ruby/2.4.0/gems/sequel-4.46.0/lib/sequel/dataset/query.rb:218:in `filter'
/app/vendor/bundle/ruby/2.4.0/gems/sequel-4.46.0/lib/sequel/model/plugins.rb:33:in `filter'
/app/models/sequel.rb:120:in `eager_graph_party_people'
simple_orm_benchmark.rb:110:in `block (2 levels) in <main>'
simple_orm_benchmark.rb:110:in `times'
simple_orm_benchmark.rb:110:in `block in <main>'
simple_orm_benchmark.rb:207:in `instance_eval'

The command was:
$ ruby simple_orm_benchmark.rb -a -l 6

Thanks for the heads up. simple_orm_benchmark will probably need to be updated for that.  I'll try to get to it today or tomorrow.


feat(API): create a single prototype for all APIs

Including utility functions: shuffle #83 and post.
Add a utility function to PI APIs that saves data to the questionnaires #91


router: Return explicit error rather than 404 for experimental.

Instead of not adding experimental routes at all, fail with an explicit
message if the daemon is not running in experimental mode.
Added the router.Experimental which does this automatically.
/cc @vieux @thaJeztah @icecrime @mstanleyjones

root@0670cd012822:/go/src/github.com/docker/docker# docker service logs -f redis
Error response from daemon: This experimental feature is disabled by default. Start the Docker daemon with --experimental in order to enable it.

/cc @mlaventure

Should we do this for other experiment endpoint ? (like checkpoints, …)

The only other one I could find is checkpoint.
But checkpoint is not a route, it's an entire router...
Should we mark every single route in that router as experimental?

@aluzzardi to keep things consistent I would say yes :angel:

I like this, much cleaner!

Should we do this for other experiment endpoint ? (like checkpoints, …)

Yes, we should, I think those were missed when making the endpoints conditional

Also, I noticed that we did not add a note to the service-logs endpoint that it's experimental. For those endpoints we should also document the 501 status code; https://github.com/docker/docker/blob/master/docs/reference/api/docker_remote_api_v1.25.md#get-service-logs

Updated. PTAL

The major downside is we have to pass the daemon to routers in addition to the backend.
There's another (cleaner but more complex) proposal, tell me what you think @vieux @mlaventure:

We add an ExperimentalRoute interface, which inherits Route and adds Enable / Disable
in daemon.initRouter, after creating all routers, if we are running in experimental, we iterate over all routers' routes, and if they match the ExperimentalRoute interface, we call Enable on them
Done

In that scenario, we don't need to pass the daemon around.
Thoughts?

@aluzzardi the new interface sgtm

@mlaventure Okay, taking a stab at that

PTAL

LGTM


Issue with event node on device activity

Hi all,
I'm creating this issue because since 2 days i'm not able to use event node based on my device activity.
I have a flow triggered by this node. For example when i'm saying "alexa, i'm leaving"  the flow starts and close all my shutter.
before 2 days i was able to see the payload from event node with description.summary and all needed stuff.
Now... nothing there is no payload but the node is in listening state.
i've checked my account, recreate the cookie even reinstalled applestrudel package nothing is working.
am i the only one with this ?
thanks for your advise

It's still working for me. I've setup some flows to create some activity during the next hours to see how reliable it is and whether it stops working at one point.

Still working 👍

I also installed node-red-contrib-alexa-remote2-applestrudel I see it works to hear commands but it doesn't work to send voice on my devices alexa accaunt alexa ita

also suffering from this issue,
removed old node-red-contrib-alexa-remote2-v2 and installed applestrudel 5.0.7
after proxy login, and after each deploy my flows,
i have ""failed to load routines: "routines.map is not a function"" from the alexa account node
Device activity node doest recieve anything anymore - the rest are working fine.

unfortunately I also have a problem with "device activity".
I'm using the latest version (5.0.7)
All other nodes of "applestrudel" work perfectly.
just just not listening to that.

Can i do anything?


Always set header in batch mode

Fixes #702

The client libraries save new token information that is returned with each response.
Will this PR require modifications to the client libraries?

Both of changing header on each request and batch mode, client should receive auth headers in response.

Hi @lynndylanhurley!
Did you have chance to look into it?

Hi @lynndylanhurley, any news about this PR?

+1 for merging this

/cc @booleanbetrayal @olleolleolle @cbliard

Can we merge this please? And my other question is what is the status of this, there are plenty of PRs open, do you need some help on this repository to handle all that PRs and issues?

Is anyone running this with ng-token-auth atm? Since these libraries are frequently paired, I don't want to break the response handling. Can someone confirm?

@booleanbetrayal yes  with ng-token-auth

@nijikon we'd love some help to handle PRs and issues - @bartes as well! If you have time to review open PRs and tell us if you think they're good to go, feel free to respond here :)

Changes look good to me and address a long standing issue. All checks are passing and approved by @MaicolBen ...going to merge this one

I'm not sure if it was just a bugfix, but it introduced a breaking change and IMO it shouldn't be released as a patch version. Unfortunately, redux-auth doesn't work with v0.1.43 and @lynndylanhurley is not active anymore so it's very bad.

Maybe we should rollback this, release v1.0.0, branch v1 and follow semver? Breaking changes should be only in major releases. It would be also great to have smaller releases and more often (e.g. one per month) instead of big ones. What do you think?

@krzysiek1507 Agreed, but I am not in charge of releasing the gem. I asked Lynn, and we agreed to rollback this and release 0.2.0. The next release will be 1.0.0

0.2.0 was released with this rollback, and 1.0.0rc1 is released with the current master, sorry for the delay!


Domain objects populated from MyBatis SQL doesn't get @FSM injected

I'm populating Account object with MyBatis and it has following events, states and transitions. (not fully defined) The issue I'm having is that after MyBatis mapper returns the object, @FSM doesn't work. fsm property is still null after object population. Could you share some insights on this please? Thanks.
@StatefulController(
	value = BEAN_ID, clazz = Account.class, startState = Account.STATE_ACTIVE
)
public class Account extends DomainEntity<Account> {
	public final static String BEAN_ID = "Account";

	// States
	public static final String STATE_ACTIVE = "1";
	public static final String STATE_BANNED = "2";
	public static final String STATE_CANCEL_REQUESTED = "3";
	public static final String STATE_SEGREGATED = "4";

	// Internal Events
	final static String EVENT_BAN = "ban";
	final static String EVENT_SEGREGATE = "segregate";

	@FSM(BEAN_ID)
	StatefulFSM<Account> fsm;

	@State
	String state;

	private AccountOption accountOption;

	public void ban() {
		onEvent(EVENT_BAN);
	}

	@Transition(from= STATE_ACTIVE, event= EVENT_BAN, to= STATE_BANNED)
	protected void doBan() {
		setAccountFlag(AccountFlagsEnum.BAN, true);
		setState(STATE_BANNED);
	}

	@Override
	protected StatefulFSM<Account> getFSM() {
		return this.fsm;
	}

    (...)
}

Can you provide some logging from the startup of the app?  I have logging that shows what SJ discovers and some debugging around the wiring - that would be the first place to start.

Also, are you using Spring Data with MyBatis?  SJ supports Spring Data and JPA - so I'm not exactly sure how you have things set up - but SJ may not support your setup as-is.

The issue is that in my demos, I use the StatefulJ framework to load the entities (via the binder endpoints).  The StatefulJ framework invokes Spring's autowireBeanProperties to wire the entity.  If you aren't using StatefulJ to load the entities, then you will need alternate way to access the FSM.
What I typically do in this case is create a Singleton object which instantiated by Spring, which has the FSM injected.  Then access the FSM from the non-Spring instantiated object via the Singleton method.