error CTC1030: Parameter name: path2

Description
I'm seeing this error when building in Azure DevOps on Microsoft Hosted Agents. I don't see the error when I build locally on Visual Studio Pro Version 17.10.1.
The error exists in the following image:
https://github.com/actions/runner-images/releases/tag/win22%2F20240603.1
Here is the full error:
##[error]C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Sdks\Microsoft.Docker.Sdk\build\Microsoft.VisualStudio.Docker.Compose.targets(329,5): Error CTC1030: Value cannot be null.
Parameter name: path2
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Sdks\Microsoft.Docker.Sdk\build\Microsoft.VisualStudio.Docker.Compose.targets(329,5): error CTC1030: Value cannot be null. [D:\a\1\s\MyProject\src\LocalDevOnly\docker-compose.dcproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Sdks\Microsoft.Docker.Sdk\build\Microsoft.VisualStudio.Docker.Compose.targets(329,5): error CTC1030: Parameter name: path2 [D:\a\1\s\MyProject\src\LocalDevOnly\docker-compose.dcproj]
Done Building Project "D:\a\1\s\MyProject\src\LocalDevOnly\docker-compose.dcproj" (default targets) -- FAILED.

I've also opened a bug with the DockerTools repo because I'm not sure where the error is originating:
https://github.com/microsoft/DockerTools/issues/430
Platforms affected

[X] Azure DevOps
[ ] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] Ubuntu 24.04
[ ] macOS 11
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[ ] Windows Server 2019
[X] Windows Server 2022

Image version and build link
I was able reproduce this with a minimal example:

Create a Blazor Project
Add Docker Support
Add Docker Compose Orchestration
Create a minimal Azure DevOps build script

I've attached a project using the above sequence. The Azure build pipeline file is azure-pipelines.yml.
BlazorApp.zip
Is it regression?
https://github.com/actions/runner-images/releases/tag/win22%2F20240514.3
Expected behavior
No error
Actual behavior
error CTC1030: Parameter name: path2
Repro steps

Create a Blazor Project
Add Docker Support
Add Docker Compose Orchestration
Create a minimal Azure DevOps build script

I've attached a project using the ab
BlazorApp.zip
ove sequence. The Azure build pipeline file is azure-pipelines.yml.

HI @DaveBubenik , we're working on your issue will share the workaround ASAP.

Hi @DaveBubenik , Please look into below provided link by developer community . the vs 17.10.1 is not working, they rolled out the version to 17.9.6 as latest . try to re-run the pipeline by taking below link as reference.
https://developercommunity.visualstudio.com/t/Cannot-build-any-project-after-update-to/10664111?viewtype=solutions

Hi @DaveBubenik ,
Please share your comments on your issue to proceed  to next step.

I re-ran the pipeline, but it's still broken.
I opened a bug with the DockerTools repo as well here:
https://github.com/microsoft/DockerTools/issues/430#issuecomment-2165009584
They advised I add "msbuildArchitecture: 'x64'" to my vsbuild argument. This got me past the path2 error, but now the image is complaining that I'm trying to build Linux containers but only Windows containers are available.
We don't actually use the Docker containers that are built using vsbuild. So I'm not actually sure they were being built before the regression occurred.
I can create custom configurations to prevent the docker-compose project from being built in the build pipeline, but it would be nice to not have to maintain this.
Do you know if there is some other workaround? Or is there a way switch the runner to use Linux containers?

@DaveBubenik ,
Do you know if there is some other workaround? Or is there a way switch the runner to use Linux containers?
pool:   vmImage: 'ubuntu-latest'
could you please try run the pipeline with linux agent as AZ pipelines takes windows agents by default . if you're already running on ubuntu machines , we request you to share your pipeline to understand the issue .

@kishorekumar-anchala the pipeline script is in the project I attached when I originally opened this ticket. It's azure-pipelines.yml
Here it is again for your reference:
azure-pipelines.zip
The VSBuild task only works on Windows agents. I'm trying to use VSBuild to build my sln file, but my sln file contains a docker compose project that has Linux containers. Previously, my project built without any problems, but now it's failing dues to an update in the runner-image.

@DaveBubenik ,
By configuring docker compose task in your pipeline after vsbuild task , it would be work , kindly try to re run your pipeline by adding the docker compose task .
task like this
- task: DockerCompose@0   inputs:     containerregistrytype: 'Azure Container Registry'     dockerComposeFile: '**/docker-compose.yml'     action: 'Run a Docker Compose command'
step 2 : if fails with windows-latest runner images , please try to run with ubuntu agents as mentioned above.
Please revert us if you're facing the same issue, thankyou !

@kishorekumar-anchala the vsbuild step fails when I do this because of the error I listed in this defect.
I can't use ubuntu-latest because it does not support vsbuild.

HI @DaveBubenik ,
@DaveBubenik ,
Have you tried with the below task ?
- task: DockerCompose@0 inputs: containerregistrytype: 'Azure Container Registry' dockerComposeFile: '**/docker-compose.yml' action: 'Run a Docker Compose command'
please try to run your pipeline to build your docker compose .

@kishorekumar-anchala I added the docker compose step, but VSBuild still fails

HI @DaveBubenik ,
I have tried locally , now it got succeeded. try with below workarounds.
`
FROM mcr.microsoft.com/dotnet/framework/aspnet:4.8-windowsservercore-ltsc2022 AS base
USER app
WORKDIR /app
EXPOSE 8080
EXPOSE 8081
FROM mcr.microsoft.com/dotnet/framework/sdk:4.8-windowsservercore-ltsc2022 AS build
ARG BUILD_CONFIGURATION=Release
WORKDIR /src
COPY ["BlazorApp3/BlazorApp3.csproj", "BlazorApp3/"]
RUN dotnet restore "./BlazorApp3/BlazorApp3.csproj"
COPY . .
WORKDIR "/src/BlazorApp3"
RUN dotnet build "./BlazorApp3.csproj" -c $BUILD_CONFIGURATION -o /app/build
FROM build AS publish
ARG BUILD_CONFIGURATION=Release
RUN dotnet publish "./BlazorApp3.csproj" -c $BUILD_CONFIGURATION -o /app/publish /p:UseAppHost=false
FROM base AS final
WORKDIR /app
COPY --from=publish /app/publish .
ENTRYPOINT ["dotnet", "BlazorApp3.dll"]`

Updated dcproj target OS  as below
<DockerTargetOS>Windows</DockerTargetOS>

I have run the pipeline with msbuid x64

trigger:

master

pool:
vmImage: 'windows-latest'
variables:
solution: '**/*.sln'
buildPlatform: 'Any CPU'
buildConfiguration: 'Release'
steps:

task: NuGetToolInstaller@1
inputs:
versionSpec:
checkLatest: true

task: NuGetCommand@2
inputs:
command: 'restore'
restoreSolution: '$(solution)'
feedsToUse: 'select'

task: VSBuild@1
inputs:
solution: '$(solution)'
msbuildArgs: '/p:DeployOnBuild=true /p:WebPublishMethod=FileSystem /p:PublishUrl="$(Build.ArtifactStagingDirectory)\BlazorApp3"'
platform: '$(buildPlatform)'
configuration: '$(buildConfiguration)'
clean: true
msbuildArchitecture: 'x64'
`

Note :  We're not going to handle these type of issues, Could you please raise bug issues with appropriate repo.
we hope the above workaround will resolve your issue, Thankyou !


The two "security" issues open

@Spuds please have a look at the search part, I think it should work, but with search you never know. :laughing:

That looks good to me, and from a couple of test cases is doing what it should.
Since you are changing the loadMessagesRequest function you could also inner joint => join there like you did elsewhere in this PR.


DateFormat parse year with 2 digits

Hello,
I have a date in the format dd/MM/yy I would like to parse.
However, following code
DateFormat('dd/MM/yy').parse('24/04/19');
generates a DateTime object
0019-04-24
I would expect this to be
2019-04-24
Is this a bug or am I misunderstanding the documentation?
Tnx

When parsing a date string using the abbreviated year pattern ('yy'), DateFormat must interpret the abbreviated year relative to some century. It does this by adjusting dates to be within 80 years before and 20 years after the time the parse function is called. For example, using a pattern of 'MM/dd/yy' and a DateFormat instance created on Jan 1, 1997, the string '01/11/12' would be interpreted as Jan 11, 2012 while the string '05/04/64' would be interpreted as May 4, 1964. During parsing, only strings consisting of exactly two digits will be parsed into the default century. Any other numeric string, such as a one digit string, a three or more digit string will be interpreted as its face value. Tests that parse two-digit years can control the current date with package:clock.
If the year pattern does not have exactly two 'y' characters, the year is interpreted literally, regardless of the number of digits. So using the pattern 'MM/dd/yyyy', '01/11/12' parses to Jan 11, 12 A.D.

After updating to the latest version from 0.16.0 this seems to be working ok


Misc slf4j-simple fixes and enhancements

Java 5 syntax
add SimpleLoggerAccess class to enable to change logger levels at runtime
update documentation (including example simplelogger.properties file)
restore ability to completely turn off logging for a given logger (level "off")
force output file (if any) to UTF-8 to avoid platform-dependent surprises while logging to a file

any chance adding 'off' back to SimpleLogger could be pulled into it's own request? i'd find that option very useful to turn off logging in some of my unit tests.


Display PR owner in 'review-requested' slack msg

When sending a slack msg for 'review-requested' events include the PR
creator.
Often times I'm looking out for a PR from a specific person. This will be helpful with hopefully
little impact to anyone elses Octobot usage.

i think you need to enable github actions on your fork for the build to run.

@matthauck They're enabled. I think by default Github now blocks people from running actions that aren't main contributors or something to prevent spamming the CI tools.

ah interesting, good to know.


Change rgbaArray type definition to a tuple

Feature Request
More of a tiny typedef improvement suggestion.
I accidentally imported  rgbaArray from index.d.ts of this module today, and noticed that its a ReadonlyArray<number>.
This type can have n number of items, while I'd expect an rgba type to have only 4 number items.
Code sample
Changing
export type rgbaArray = ReadonlyArray<number>;
to
export type rgbaArray =Readonly<[r:number, g: number, b: number, a: number]>;

This type has been removed as a part of https://github.com/software-mansion/react-native-svg/pull/1726, so I believe this is not a problem anymore. Thanks for your contribution though! I will close this issue. Feel free to comment here if something is wrong and we can always reopen it then.


format of prompt answers

we can change from
answers=[{'World': 'World News'}, {'Sports': 'Sports'}, {'Business': 'Business'}, {'Science and Technology': 'Science and Technology'}]

to
answers={'World': ['World News']}, {'Sports': ['Sports']}, {'Business': ['Business']}, {'Science and Technology': ['Science and Technology']}

signal_type should be a list instead of a string.

fixed.


replacement for tap.tearDown

Trying to upgrade from tap 0.4.13 to the latest and a lot of our tests are using tap.tearDown to clean up after themselves (remove files created on the file system, close servers and sockets, etc), but the latest version gives:
TypeError: Object #<Test> has no method 'tearDown'
Is there a replacement for this? I didn't see one in the docs and the github search doesn't show an upgrade path for it.
Thanks!

Never mind. It seems tests run sequentially only after the previous test ends or the plan is fulfilled.


Thrust/CUB should be run-exported

This affects RMM because the Cython layer also needs to include Thrust (and therefore CUB too) headers. It's better that librmm exports it to ensure the same version is seen when building RMM.

This need is revealed after @kkraus14's recent fix in Thrust/CUB's cmake support (https://github.com/conda-forge/thrust-feedstock/pull/15, https://github.com/conda-forge/cub-feedstock/pull/17).

Findings learned from #31 and https://github.com/conda-forge/rmm-feedstock/pull/11:

In librmm to set to an external Thrust, we need to use -DCPM_Thrust_SOURCE. But in rmm, we need to use -DThrust_ROOT.
However, we currently do not apply the CPM trick to librmm because it doesn't seem to be the most elegant solution to the include path issue (https://github.com/conda-forge/librmm-feedstock/pull/31#issuecomment-1138988403)
As a result, and librmm downstream, including rmm better use the Thrust bundled in librmm to not be stripped by the version mismatch error.

I don't think this is an issue in practice anymore. The package ships thrust and cub in a rapids subdirectory so they exist as needed. I believe it is done this way since other RAPIDS packages have had the need to patch thrust and cub.

That sounds right to me. Thanks Keith! 🙏


CreatedAtAction(string, string, object) fails when actionName ends with "Async"

Describe the bug
In an API Controller (.NET CORE V3)
When using CreatedAtAction(string, string, object, object)  or CreatedAtAction(string, object, object)
If the actionName ends with Async the call fails and a

System.InvalidOperationException: No route matches the supplied values.

is thrown and error 500 is returned.
To Reproduce
[HttpPost(Name = "CreateCity")]
[ProducesResponseType(typeof(City), 201)]
public async Task<ActionResult<City>> AddCityAsync([FromBody] AddCityRequest newCityRequest)
{
    // ......
    // Create the city somewhere using an Async method while awaiting.
    return CreatedAtAction(nameOf(GetCityAsync), new { cityId = city.id }, city);
}

[HttpGet("{cityId}", Name = "GetCityById")]
[ProducesResponseType(typeof(City), 200)]
public async Task<ActionResult<City>> GetCityAsync([FromRoute] Guid cityId)
{
    // get the city from somewhere using await
   return Ok(city);
}

Expected behavior
The route should be resolved properly even if the actionName contains Async.
Additional context
dotnet --info
`.NET Core SDK (reflecting any global.json):
Version:   3.0.100
Commit:    04339c3a26
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.18362
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\3.0.100\
Host (useful for support):
Version: 3.0.0
Commit:  7d57652f33
.NET Core SDKs installed:
3.0.100 [C:\Program Files\dotnet\sdk]
.NET Core runtimes installed:
Microsoft.AspNetCore.All 2.1.13 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.13 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.0.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.13 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.0.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 3.0.0 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]`

Thanks for the issue report @Adelzu. This is a documented breaking change in 3.0: https://docs.microsoft.com/en-us/aspnet/core/migration/22-to-30?view=aspnetcore-3.0&tabs=visual-studio#async-suffix-removal-from-controller-action-names. We're tracking addressing improving the experience around this as part of the 5.0 release: https://github.com/aspnet/AspNetCore/issues/14103


Error p. 84: The module firewalld was redirected to community.general.firewalld, which could not be loaded

$ ansible db -b -m firewalld -a "zone=database state=present permanent=yes
> "
<IP_ADDRESS> | FAILED! => {
    "msg": "The module firewalld was redirected to community.general.firewalld, which could not be loaded."
}

With Ansible 2.10 use ansible.posix.firewalld for module name:
ansible db -b -m ansible.posix.firewalld -a "zone=database state=present permanent=yes"

Ansible docs for reference.

Also, I first had to make sure Firewalld was running before that command would work.
ansible db -b -m service -a "name=firewalld state=started enabled=yes"

Also, I first had to make sure Firewalld was running before that command would work.
ansible db -b -m service -a "name=firewalld state=started enabled=yes"

Weird... that redirect seems like it should be going through correctly just calling firewalld. Right??

Opened a bug report in community.general for this... https://github.com/ansible-collections/community.general/issues/1940

Maybe this is the proper place for it: https://github.com/ansible/ansible/pull/73689

Glad this is here.  Is it safe to assume it needed to be done for any adhoc command that calls for the module firewalld?

It shouldn't be needed since the redirect has been fixed.
Someday I'll update book examples to use FQCN's, but that is not this day.


Add dep-collector to the list of required tools in Gopkg.toml

We need it as a tool, but not its dependencies.
For details, see https://github.com/knative/build/pull/487#issuecomment-443476057

/retest


Requests for error that cannot solve for pressure yet

Hello, when I called class PretreatmentReactorSystem, I changed self.reactions.adiabatic_reaction(liquid) in the code to self.reactions(liquid) (https://github.com/BioSTEAMDevelopmentGroup/Bioindustrial-Park/blob/master/biorefineries/cellulosic/units.py). At the same time, I added V=0 in def init(self, ID='', ins=None, outs=(), T=130+273.15, V=0, thermos=None, tau=0.166, V_wf=0.8, length_to_diameter=2, vessel_material='Stainless steel 316', vessel_type='Horizontal',reactions=None, run_vle=True) and added self.V = V after self.T = T.
Because I want the gas fraction of the outlet stream to be zero, and I don't want the reaction to be adiabatic (I want to look at the heat duty of the pretreatment reaction). But when I do that, an error (NotImplementedError: <PretreatmentReactorSystem: R201> cannot solve for pressure yet) was reported. I analyzed the reason, it’s because that dH_bubble = (H - H_bubble) if dH_bubble <= 0: raise NotImplementedError('cannot solve for pressure yet') was set in the VLE source code (https://biosteam.readthedocs.io/en/latest/_modules/thermosteam/equilibrium/vle.html#).
Does that mean that when having an exothermic reaction, an error that cannot solve for pressure yet was reported? Because I want to see the heat duty of the actual pretreatment (not necessarily 0), I don't want to set the reaction under adiabatic condition. But if I don't set the adiabatic, the above error will be reported. May I ask if you have any solution for that. Thank you very much. Wish you a good day.

Hi @zasddsgg, setting V and T is not implemented in thermosteam yet. I will add it sometime this weekend. In the mean time that this gets added, you can use V=0 and P=some value (replace T for P). V is the vapor fraction and setting V=0 sets the mixture to the bubble point. I will leave this issue open until I add the feature.
Thanks!

Thank you for your help, but in class pretreatment system，adiabatic reactions needed to be set ，or the above error will be reported. If I don't want to set adiabatic conditions，what should I do for solving that error. Thank you a lot for your help.

From: Yoel @.>
Sent: Wednesday, February 22, 2023 10:50:02 PM
To: BioSTEAMDevelopmentGroup/Bioindustrial-Park @.>
Cc: Dexin ZHANG 张德鑫 @.>; Mention @.>
Subject: Re: [BioSTEAMDevelopmentGroup/Bioindustrial-Park] Requests for error that cannot solve for pressure yet (Issue #61)
Hi @zasddsgghttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fzasddsgg&data=05|01|zhangdexin%40westlake.edu.cn|b4adaba8f62844711eac08db14e416fc|7e82de2f7ef644169b9644c1457be81b|1|0|638126742089913039|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=GWC47i9AfT0X2IT1mPaDfYK7fYKbSWF4gSSPUtJPoUo%3D&reserved=0, setting V and T is not implemented in thermosteam yet. I will add it sometime this weekend. In the mean time that this gets added, you can use V=0 and P=some value (replace T for P). V is the vapor fraction and setting V=0 sets the mixture to the bubble point. I will leave this issue open until I add the feature.
Thanks!
―
Reply to this email directly, view it on GitHubhttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBioSTEAMDevelopmentGroup%2FBioindustrial-Park%2Fissues%2F61%23issuecomment-1440174598&data=05|01|zhangdexin%40westlake.edu.cn|b4adaba8f62844711eac08db14e416fc|7e82de2f7ef644169b9644c1457be81b|1|0|638126742089913039|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=zqukwrMk04OKdI9HE5aHsaRe5rcP7MMWNZABGenVdXc%3D&reserved=0, or unsubscribehttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA57G2RPYZZ7QZCVBQCJ3LHLWYYRRVANCNFSM6AAAAAAVELNHXA&data=05|01|zhangdexin%40westlake.edu.cn|b4adaba8f62844711eac08db14e416fc|7e82de2f7ef644169b9644c1457be81b|1|0|638126742089913039|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=u5Pv5tZhDoOAhgTTzl5K4JMyfneiGLuMPsLonq1SVXw%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

@zasddsgg, I updated my reply regarding setting V and T above.

Thank you for your help and suggestions. Compared to the original code, I changed T and V, as well as some conversion rates, and changed self.reactions.adiabatic_reaction(liquid) to self.reactions(liquid). My source code and error information are as follows:
import biosteam as bst
bst.nbtutorial()
from biosteam.units.decorators import cost
from biosteam import Unit
from biosteam import units
from biosteam.units.design_tools.geometry import cylinder_diameter_from_volume
from thermosteam import MultiStream
import thermosteam as tmo
from biorefineries import cellulosic
cs = cellulosic.Biorefinery('corn stover ethanol')
chemicals_cs = cs.chemicals
bst.settings.set_thermo(chemicals_cs)
bst.main_flowsheet.set_flowsheet('corn stover_ethanol')
cornstover = bst.Stream(
'cornstover',
Glucan=0.28,
Xylan=0.1562,
Galactan=0.001144,
Arabinan=0.01904,
Mannan=0.0048,
Lignin=0.12608,
Acetate=0.01448,
Protein=0.0248,
Extract=0.1172,
Ash=0.03944,
Sucrose=0.00616,
Water=0.2,
total_flow=104229.16,
units='kg/hr',
price=0.05158816935126135,
)
sulfuric_acid = bst.Stream(
'sulfuric_acid',
P=5.4*101325,
T=294.15,
Water=130,
H2SO4=1800,
units='kg/hr',
price=0.0897171175961359
)
U101 = cellulosic.units.FeedStockHandling('U101', Cornstover)
@cost('Dry flow rate', 'Pretreatment reactor system', units='kg/hr',
S=83333, CE=522, cost=19812400 * 0.993, n=0.6, kW=4578, BM=1.5)
class PretreatmentReactorSystem(bst.units.design_tools.PressureVessel, Unit):
_N_ins = 1
_N_outs = 2
_graphics = bst.Flash._graphics
_units = {'Residence time': 'hr',
'Reactor volume': 'm3'}
def __init__(self, ID='', ins=None, outs=(), T=110+273.15, V=0, thermo=None,
             tau=0.166, V_wf=0.8, length_to_diameter=2,
             vessel_material='Stainless steel 316',
             vessel_type='Horizontal',
             reactions=None,
             run_vle=True):
    Unit.__init__(self, ID, ins, outs, thermo)
    self._load_components()
    vapor, liquid = self.outs
    vapor.phase = 'g'
    self.T = T
    self.V = V
    chemicals = self.chemicals
    if reactions is None:
        self.reactions = ParallelRxn([
    #            Reaction definition                 Reactant    Conversion
    Rxn('Glucan + H2O -> Glucose',                   'Glucan',   0.0990),
    Rxn('Glucan -> HMF + 2 H2O',                     'Glucan',   0.0030),
    Rxn('Galactan + H2O -> Galactose',               'Galactan', 0.9000),
    Rxn('Galactan -> HMF + 2 H2O',                   'Galactan', 0.0500),
    Rxn('Mannan + H2O -> MannoseOligomer',           'Mannan',   0.0240),
    Rxn('Mannan -> HMF + 2 H2O',                     'Mannan',   0.0500),
    Rxn('Mannan + H2O -> Mannose',                   'Mannan',   0.9000),
    Rxn('Sucrose -> HMF + Glucose + 2H2O',           'Sucrose',  1.0000),
    Rxn('Xylan + H2O -> Xylose',                     'Xylan',    0.9000),
    Rxn('Xylan + H2O -> XyloseOligomer',             'Xylan',    0.0240),
    Rxn('Xylan -> Furfural + 2 H2O',                 'Xylan',    0.0500),
    Rxn('Arabinan + H2O -> Arabinose',               'Arabinan', 0.9000),
    Rxn('Arabinan + H2O -> ArabinoseOligomer',       'Arabinan', 0.0240),
    Rxn('Arabinan -> Furfural + 2 H2O',              'Arabinan', 0.050),
    Rxn('Acetate -> AceticAcid',                     'Acetate',  1.0000),
    Rxn('Furfural + 3 H2O -> Tar',                   'Furfural', 1.0000),
    Rxn('HMF + 3 H2O -> 1.2 Tar',                    'HMF',      1.0000),
    Rxn('Lignin -> SolubleLignin',                   'Lignin',   0.0500)
        ])
        self.glucan_to_glucose = self.reactions[0]
        self.xylan_to_xylose = self.reactions[8]
        self.glucose_to_byproducts = self.reactions[1:3]
        self.xylose_to_byproducts = self.reactions[9:12]
    else:
        self.reactions = reactions
    self.tau = tau
    self.V_wf = V_wf
    self.length_to_diameter = length_to_diameter
    self.vessel_material = vessel_material
    self.vessel_type = vessel_type
    self.run_vle = run_vle

def _load_components(self):
    thermo = self.thermo
    self._multistream = MultiStream(None, thermo=thermo)

def _run(self):
    feed = self.ins[0]
    vapor, liquid = self.outs
    liquid.copy_like(feed)
    self.reactions(liquid)
    if self.T:
        if self.run_vle:
            ms = self._multistream
            ms.copy_like(liquid)
            ms.vle(T=self.T, H=ms.H)
            vapor.mol[:] = ms.imol['g']
            liquid.mol[:] = ms.imol['l']
            vapor.T = liquid.T = ms.T
            vapor.P = liquid.P = ms.P
        else:
            liquid.T = self.T

def _design(self):
    Design = self.design_results
    ins_F_vol = self.F_vol_in
    V_reactor = ins_F_vol * self.tau / self.V_wf
    P = self.outs[0].P * 0.000145038 # Pa to psi
    length_to_diameter = self.length_to_diameter
    D = cylinder_diameter_from_volume(V_reactor, self.length_to_diameter)
    D *= 3.28084 # convert from m to ft
    L = D * length_to_diameter
    Design['Residence time'] = self.tau
    Design['Reactor volume'] = V_reactor
    Design.update(self._vessel_design(float(P), float(D), float(L)))
    self._decorated_design()

def _cost(self):
    Design = self.design_results
    self.baseline_purchase_costs.update(
        self._vessel_purchase_cost(
            Design['Weight'], Design['Diameter'], Design['Length']
        )
    )
    self._decorated_cost()

Rxn = tmo.reaction.Reaction
ParallelRxn = tmo.reaction.ParallelReaction
M201 = units.Mixer('M201', [sulfuric_acid, U101-0])
P201 = units.Pump('P201', M201-0, P=1.5101325)
H201 = units.HXutility('H201', P201-0, T=110+273.15, V=0)
P202 = units.Pump('P202', H201-0, P=2101325)
R201 = PretreatmentReactorSystem('R201', P202-0)
A_sys = bst.main_flowsheet.create_system('A_sys')
A_sys.simulate()
A_sys.diagram('thorough', format='png')
error information:
NotImplementedError                       Traceback (most recent call last)
Cell In [5], line 2
1 A_sys = bst.main_flowsheet.create_system('A_sys')
----> 2 A_sys.simulate()
3 A_sys.diagram('thorough', format='png')
File D:\anaconda\envs\zddx\lib\site-packages\biosteam_system.py:2200, in System.simulate(self, update_configuration, **kwargs)
2198     elif self._facility_loop:
2199         self._facility_loop.converge()
-> 2200 return outputs
File D:\anaconda\envs\zddx\lib\site-packages\biosteam_flowsheet.py:36, in TemporaryFlowsheet.exit(self, type, exception, traceback)
34 def exit(self, type, exception, traceback):
35     main_flowsheet.set_flowsheet(self.original)
---> 36     if exception: raise exception
File D:\anaconda\envs\zddx\lib\site-packages\biosteam_system.py:2192, in System.simulate(self, update_configuration, **kwargs)
2190         outputs = self.simulate(update_configuration=True, **kwargs)
2191     else:
-> 2192         raise error
2193 else:
2194     if (not update_configuration # Avoid infinite loop
2195         and self._connections != [i.get_connection() for i in self.streams]):
2196         # Connections has been updated within simulation.
File D:\anaconda\envs\zddx\lib\site-packages\biosteam_system.py:2183, in System.simulate(self, update_configuration, **kwargs)
2181 else:
2182     try:
-> 2183         outputs = self.converge(**kwargs)
2184         self._summary()
2185     except Exception as error:
File D:\anaconda\envs\zddx\lib\site-packages\biosteam_system.py:1904, in System.converge(self, material_data, update_material_data)
1902     for i in range(self._N_runs): method()
1903 else:
-> 1904     method()
1905 if update_material_data:
1906     if reset_material_data:
File D:\anaconda\envs\zddx\lib\site-packages\biosteam_system.py:1803, in System.run(self)
1801 f = try_method_with_object_stamp
1802 for i in self._path:
-> 1803     if isa(i, Unit): f(i, i.run)
1804     elif isa(i, System): f(i, i.converge)
1805     else: i()
File D:\anaconda\envs\zddx\lib\site-packages\thermosteam\exceptions.py:90, in try_method_with_object_stamp(object, method, args)
88     raise StampedKeyError(message_with_object_stamp(object, repr(error.args[0])))
89 except Exception as error:
---> 90     raise_error_with_object_stamp(object, error)
File D:\anaconda\envs\zddx\lib\site-packages\thermosteam\exceptions.py:80, in raise_error_with_object_stamp(object, error)
78     error.args = (message_with_object_stamp(object, msg), *args)
79 except: pass
---> 80 raise error
File D:\anaconda\envs\zddx\lib\site-packages\thermosteam\exceptions.py:84, in try_method_with_object_stamp(object, method, args)
82 def try_method_with_object_stamp(object, method, args=()):
83     try:
---> 84         return method(*args)
85     except StampedKeyError as error:
86         raise StampedKeyError(message_with_object_stamp(object, error.args[0]))
File D:\anaconda\envs\zddx\lib\site-packages\biosteam_unit.py:1258, in Unit.run(self)
1256         if self.run_after_specifications: self._run()
1257 else:
-> 1258     self._run()
Cell In [3], line 71, in PretreatmentReactorSystem._run(self)
69 ms = self._multistream
70 ms.copy_like(liquid)
---> 71 ms.vle(T=self.T, H=ms.H)
72 vapor.mol[:] = ms.imol['g']
73 liquid.mol[:] = ms.imol['l']
File D:\anaconda\envs\zddx\lib\site-packages\thermosteam\equilibrium\vle.py:368, in VLE.call(self, T, P, V, H, S, x, y)
366         thermal_condition.T = T
367 elif H_spec:
--> 368     self.set_TH(T, H)
369 elif S_spec:
370     self.set_TS(T, S)
File D:\anaconda\envs\zddx\lib\site-packages\thermosteam\equilibrium\vle.py:797, in VLE.set_TH(self, T, H)
795 dH_bubble = (H - H_bubble)
796 if dH_bubble <= 0:
--> 797     raise NotImplementedError('cannot solve for pressure yet')
799 # Guess overall vapor fraction, and vapor flow rates
800 V = dH_bubble/(H_dew - H_bubble)
NotImplementedError: <PretreatmentReactorSystem: R201> cannot solve for pressure yet

@zasddsgg, vle is run on this line:
ms.vle(T=self.T, H=ms.H)
T and H is being set, but T is below the bubble point and there is no pressure at which H would be satisfied. I think you meant to pass T and V.

Thank you for your reminding. I changed ms.vle(T=self.T, H=ms.H) to ms.vle(T=self.T, V=ms.V). After running, the vapor fraction of R201 outlet stream is not 0 set by me, but I have set V=0 in  def init, why is there still gas phase in outlet stream. R201 outlet stream information is as follows:
phase: 'g', T: 383.15 K, P: 135818 Pa
flow (kmol/hr): Water       0.00475
AceticAcid  0.00475
Furfural    0.00475

@zasddsgg, you should be running ms.vle(T=self.T, V=self.V), then you should get no vapor.

Thank you for your reminding and help. The problem has been solved. Thank you again for your help. Wish you a good day.


Object doesn't support this action - IE8

I get this error: "Object doesn't support this action" refering to moment/meteor/export.js at line 3.
I suggest to change this line to something like this:
try {
    delete this.moment;
} catch(e) {
    this['moment'] = undefined;
}

@dandv.

Funnily enough, @alethes submitted a patch for that two days ago.

Ok, awesome!


What type of spam/actions is this target?

Likes?
Follows?
Dm?

Hey there! So, I get likes, retweets, quoted retweets, @ mentions, and follows from accounts that simply want me to come to their profile to click on a link. I rarely get actual spam tweets. It's normally just a shell profile that has their link in the bio. I manually go to their profile and report them as spam then block them. The "why" of the project is to automate that so I don't even see the notification.
There are several things that make these bots easy to classify. I want to start simple and small and work our way up. Even if we just start with the logic to identify 70% of this kind of spam and turn that into a chrome extension that'd be awesome. Then we could iterate on that.
Hopefully that helps explain my vision for this project.

OK, got. Except for reporting spam, which I believe is not allowed by the api,  np. And I assume you error on the side of not blocking some spam and not blocking some legit people. @d3viant0ne

It is possible I believe: https://dev.twitter.com/rest/reference/post/users/report_spam
I would definitely err on the side of not blocking/reporting someone, yes.

I stand corrected.  Nice ,one api call report and block.
On Tue, Jul 5, 2016, 1:47 PM Kent C. Dodds<EMAIL_ADDRESS>wrote:

It is possible I believe:
https://dev.twitter.com/rest/reference/post/users/report_spam
I would definitely err on the side of not blocking/reporting someone, yes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kentcdodds/twitter-spam-autoblocker/issues/3#issuecomment-230550468,
or mute the thread
https://github.com/notifications/unsubscribe/AEZlcBDF4Krdsas14M6vGJ42kfcAkBigks5qSpiqgaJpZM4JD-jN
.


PLT-5611 Add Channel Name to thread view title

Summary
This PR adds the channel name to the title of the thread to let the user know which channel the thread is part of
Ticket Link
https://mattermost.atlassian.net/browse/PLT-5611
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] Added or updated unit tests (required for all new features)
[ ] All new/modified APIs include changes to the drivers
[x] Has UI changes
[x] Includes text changes and localization file updates

Make sure you are running the branch

I was on the right branch. :)
But because I switched to it without restarting the packager, it didn't detect the file changes. This is the first time I've seen it happen silently. Normally there are errors in the terminal when this happens. After I restarted the packager, it worked.

Im AFK but will rebase in a couple of hours


[flutter release] strategy on better ways to merge cherry pick PR

For the longest time I thought cherry pick author should be the one tuning the tests and merging the PR, but today I read https://github.com/flutter/flutter/wiki/Flutter-Cherrypick-Process and realized that it says "The release engineering team will merge the cherry-pick pull request"
In this week's release https://github.com/flutter/flutter/issues/145184 and https://github.com/flutter/engine/pull/51425 were merged by me, and I had to rerun tests and stamp LGTM on one of them. However, I didn't realize https://github.com/flutter/flutter/pull/145181 was also left open as a cherry pick PR and not merged.
Would it be possible to change the policy, so that PR authors are the one merging cherry pick PRs?

@XilaiZhang we have the automated cherry-pick action.  Wouldn’t we rather just write another action that adds the autosubmit label once the approved label is added?  This takes the burden off of both parties.

Yeah the 3 PRs aren't opened through the automated action because, one of them has a merge conflict, and the two others don't have a corresponding PR merged into main/master.
my understanding is that even if they are opened through automated cherry pick PR, if we submit based on approved status, then:

If author approves the bot PR, it can merge it without reviewer / TL approval
the tests could still be failing when approval is given, and autosubmit label would be removed.
if the cps are manually created, then it is also possible that:
approval is granted on cherry pick issue, but not granted on cherry pick PR.

If we are okay with the risks, I think submitting based on approval would resolve 1 of the 3 PRs from this week. Are we good with accepting the risks (mostly the potential of skipping TL review?)

from triage: still better to leave to release engineer to merge. not release engineer's fault if pr missed cutoff due to failed tests. kevin will kindly help update the wiki page.


Bug report: subtracting dates equalling zero does not return zero.

What happened?
I tried subtracting dates expecting it to return 0, however, it did not return anything, as far as I can tell.
I would like the subtraction of dates that should equal zero to equal zero.
DQL
date("2022-01-01") - date("2022-01-01")
JS
No response
Dataview Version
0.5.46
Obsidian Version
v1.0.3
OS
Linux

Possible duplicate of #1504

Possible duplicate of #1504

No, I don't think so, but its related. This is due to
`$=dv.luxon.Duration.fromMillis(0).normalize()`

which seems to be the implementation for date calculation evaluating to no output. toHuman() would produce a 0 Milliseconds (in system locale) output, but change the output in general. Safest fix would be a separated if, I guess.

I managed to circumvent this issue by using (date("2022-01-01") - date("2022-01-01")).days


🐛 Biome not properly formatting workspace files

VS Code version
1.93.1
Extension version
2.3.0
Biome version
1.9.3
Operating system

[ ] Windows
[ ] macOS
[ ] Linux

Description
Our team has been struggling with Biome inconsistently formatting workspace files. On save, sometimes it uses the default biome settings, and sometimes it uses our biome.json settings. In addition, when pressing Ctrl + Shift + P, we are able to see a bunch of Biome formatters, which did not seem to be the case in previous versions.

Occasionally, restarting VSCode or closing out of the current file and reopening seems to fix it, but not consistently as well.
Steps to reproduce

Attempt to format a file (potentially in a large monorepo which has biome.json's that depend on each other, but may be unrelated)
See that the formatting is inconsistent.

Expected behavior
The formatting was consistent in Biome 1.7.0, but after we updated to 1.9.3, the formatting has not been consistent at all.
Does this issue occur when using the CLI directly?
Not sure / Not applicable
Link to a minimal reproduction
No response
Logs
No response

Would you mind trying the pre-release of the extension to see if it solves it for you? The current version has a couple of issues with regards to sockets that sometimes results in multiple session being created.

I'm experiencing the same issues in large workspaces (both on release and pre-release versions):

The folder configuration is sometimes not picked up at all from the start, and a default config is used.
The extension sometimes initially picks up on the correct folder configuration, but then seems to forget it later on and uses a default configuration.
It also sometimes lists multiple formatters in the command palette.
Sometimes files are ignored entirely with The file [file path] was ignored..
The same monorepos work fine in Webstorm with biome, as well as via the cli.

Overall, this makes the extension very difficult to use in monorepos as the output becomes unpredictable.

I had similar problems with workspaces but was showered with errors:


Updating packages

Hi,
Would be great if we could update packages! Prometheus/Grafana/Node-exporter all to latest versions.
Best,
Samir.

The bigest shift would probably be Grafana 5 -> 6, but the data migration should happen smoothly. See https://grafana.com/docs/grafana/latest/installation/upgrading/.

is this project death or are planed updates?


Improve documentation

As suggested by @mgedmin
Fixes aymericbeaumet/symlink.vim#1

Thanks for the effort! LGTM


avoid synchronization on segment creation

ok to test

Merged by https://github.com/droolsjbpm/drools/commit/1e50f13e6


Read DD_GIT_REPOSITORY_URL and DD_GIT_COMMIT_SHA env vars

What does this PR do?
Make the agent read the containers DD_GIT_REPOSITORY_URL and DD_GIT_COMMIT_SHA environment variables to populate the git.repository_url and git.commit.sha tags.
Motivation
Those git.repository_url and git.commit.sha tags are currently filled from the values of the org.opencontainers.image.source and org.opencontainers.image.revision docker labels.
But those labels are not used by the APM tracer libraries.
In order to ease the setup for the customers, it would be simpler to have one way to configure the repository URL and the commit sha that would work for both the agent and the APM tracer libraries.
Additional Notes
Possible Drawbacks / Trade-offs
This works only for the env vars set at the container level. If the env var is set by a script running inside the container, it won’t be seen by the agent.
Describe how to test/QA your changes
Start a container with the repository URL and commit sha set as docker labels DD_GIT_REPOSITORY_URL and DD_GIT_COMMIT_SHA.
Check that all the data coming from this container are properly tagged with git.repository_url and git.commit.sha.

I'm not sure about the feature.

@clamoriniere Hi, so the goal is to be able to tag events (like logs) with the repo. This would allow to search logs by repository which would be useful for IDE plug-ins where association services with code is not easily doable.
Also this would unify (and simplify) the configuration: Source Code Integration already needs this environment variable and agent was using OCI labels, now consumers will only have to set these environment variables.

/merge


Implement HTTP/2 graceful shutdown

According to https://httpwg.org/specs/rfc7540.html#GOAWAY

A client that is unable to retry requests loses all requests that are in flight when the server closes the connection. This is especially true for intermediaries that might not be serving clients using HTTP/2. A server that is attempting to gracefully shut down a connection SHOULD send an initial GOAWAY frame with the last stream identifier set to 2^31-1 and a NO_ERROR code. This signals to the client that a shutdown is imminent and that initiating further requests is prohibited. After allowing time for any in-flight stream creation (at least one round-trip time), the server can send another GOAWAY frame with an updated last stream identifier. This ensures that a connection can be cleanly shut down without losing requests.

Just wondering, was this fixed by #1392?

Fixed by #3715


The fallback content for a slot  for using Composition API ，Can't render normally

Vue version
3.2.47
Link to minimal reproduction
https://stackblitz.com/edit/vue-urpeut?file=src/App.vue
Steps to reproduce
step1:  define a component Test.vue, create a slot for fallback content 'BBB'
<template>
  <div>
    <slot> BBB </slot>
  </div>
</template>

step2: using Composition API by

When the is value is a string, it must be the registered name of the component. But in the syntactic sugar of setup, it seems that the component will not be registered automatically, so the alternative is to use :is

Correct. You need to pass the component itself as the value with v-bind:is, because in script setup, there is no local component registration -  we just directly use the variable in the template.

Also, the reproduction uses Vue 2.6, for some reason?


Update Export-ActivityExplorerData.md

Added back OutputFormat parameter

Learn Build status updates of commit 5b5d474:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Export-ActivityExplorerData.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Added compatibility with php7 error handling

Hello !
I recently stumbled upon an issue with php7 and error handling. In php7 a \Error class was introduced (to convert warning and fatal errors to exceptions). The problem is that \Error is not inheriting \Exception and, as a consequence, is not catched correctly.
Here is a fix for that, I checked on older php versions, it should not breaking anything (as catching on an unknown class will not generate any error : https://3v4l.org/Hb5HH ).

Coverage decreased (-0.1%) to 92.275% when pulling d022b19b4ea256573ca92fc33cb48a91d9d3c1e3 on OwlyCode:php7-errors-handling into 5be0944453728746ae7dd5d3100d20b3088f1b89 on webonyx:master.

Thanks for PR!


Add a way to compare my fireteam to the enemy's fireteam.

It would be nice if in destinytrialsreport.com if I could put my name in at the beginning to load my fireteam, and then put the enemy's name in at the start of each match to compare basic information from my fireteam to theirs. It would also be nice if the fireteams were sorted by elo level. For example, a view like this would be nice:

Along this train of thought, in guardian.gg you can look at your match history and expand the view to see the average elo levels for both teams. (Look at the bottom of the image).

It would be nice if when comparing my fireteam to their fireteam if we could see the team's elo and get an idea of who should win according to elo level.

We are actually currently working on this exact feature :)
The only thing we have left is to figure out the user flow and placement for your own fireteams stats.
Having the condensed cards isn't a bad idea but we dont want to more scrolling in the view so we might move that data to a modal instead.

Man you are on top of things! I look forward to seeing how you decide to implement this. =]


Update webfactory/ssh-agent to v0.7

Updating to >= v0.6 updates the action to use Node 16 instead of Node 12 which addresses the warning we've been seeing in the CI logs.

The following actions uses node12 which is deprecated and will be forced to run on node16<EMAIL_ADDRESS>For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

@2rueSid, q quick review? Any reason why we shouldn't make this change? (I can't approve my own PRs and don't want to force it either)


Improve API validation so openapi.yaml file utilizes schemas from API model Python classes

We need to improve / fix API validation so all the inputs are correctly validated based on the schema defined in openapi.yaml / API model.
Right now we have schemas from API models copy and pasted to openapi.yaml file and that's a maintenance nightmare (things will get out of sync, etc.).
We need to decide which place we want as an authoritative source (either API model Python classes or openapi.yaml file) and then write a generator which either writes schema to openapi.yaml file based on API model class definitions or vice-versa.
See https://github.com/StackStorm/st2/pull/3573#issuecomment-315697541 for context.

I would personally prefer to use API model as authoritative source, because:

We already have a process which generates final openapi.yaml file based on the Jinja template definition.
API model schemas definitions are already used in other places - e.g. when content comes into the system outside API (via st2-register-content).

If we want with the other approach, we would then have multiple files which are auto-generated and I would prefer to limit auto-generation to openapi file.


Made buttons green in some places

CHANGES

Change "Save" buttons in settings to green color
Changed "Save" button in create/edit listing to green color
Changed "Return" button in transaction section
Cleaned up some copy

@jjeffryes I made a few small changes. this is ready whenever you get a chance.

As part of this PR, could you update the buttons to use the processing template?

If the button wasn't using the processing template before, it means the js code to update the processing state isn't in place. Wouldn't it be better to make a separate PR to wire in processing buttons and their functionality where needed, rather than just put in impotent processing markup?

I thought I saw in some places save buttons were getting processing classes that weren't doing anything, so the wiring was there, but the template wasn't.
We could make that separate though.

Since it was just two places, I pushed the change to update to the processing buttons.

Perfect, thank you

@morebrownies I just found a couple things in my review. Should be quick fixes.

Ok great thank you. I'll circle back to this when I can.

This should be ready for review again @rmisio @jjeffryes

@jjeffryes this lgtm.


Install a specific version of the CLI so we have control over the introduction of breaking changes

The CLI can introduce breaking changes which could make the tests fail until they are rewritten.  If we use a fixed version of the CLI instead then we can know the tests will continue to work whilst we upgrade them to the new version.

Is it okay by fixing it @4.2.0?

Yep, although you could also use @^4.2.0 in order to automatically pick up minor/patch changes (which are non-breaking)


Added new rule MiKo_1079 for DDD repositories

@CodiumAI-Agent /describe

Title
Added new rule MiKo_1079 for DDD repositories

User description
@CodiumAI-Agent /describe

PR Type
Enhancement, Tests, Documentation

Description

Introduced a new analyzer MiKo_1079_RepositorySuffixAnalyzer to enforce naming rules for repository classes in DDD.
Added a corresponding code fix provider MiKo_1079_CodeFixProvider to suggest and apply better class names.
Extended the Pluralizer logic and tests to correctly handle pluralization of "Child" to "Children".
Updated project configuration files to include the new analyzer and code fix provider.
Updated the README to document the new rule and increment the rule count.
Added resources for the new rule, including title, description, and message format.

Changes walkthrough 📝
Relevant filesTests2 files

MiKo_1079_RepositorySuffixAnalyzerTests.csAdd unit tests for MiKo_1079 repository suffix analyzer

MiKo.Analyzer.Tests/Rules/Naming/MiKo_1079_RepositorySuffixAnalyzerTests.cs
Added unit tests for the new MiKo_1079_RepositorySuffixAnalyzer.  Verified correct behavior for repository and non-repository class names.  Included test cases for code fixes to rename repository classes.

+72/-0

PluralizerTests.csExtend Pluralizer tests with "Child" case

MiKo.Analyzer.Tests/Linguistics/PluralizerTests.cs

Added a test case for pluralizing "Child" to "Children".

+1/-0

Enhancement3 files

MiKo_1079_RepositorySuffixAnalyzer.csImplement MiKo_1079 repository suffix analyzer

MiKo.Analyzer.Shared/Rules/Naming/MiKo_1079_RepositorySuffixAnalyzer.cs
Implemented MiKo_1079_RepositorySuffixAnalyzer to enforce naming rules for repository classes.  Added logic to detect and suggest better names for classes suffixed with Repository.

+35/-0

MiKo_1079_CodeFixProvider.csAdd code fix provider for MiKo_1079 repository suffix rule

MiKo.Analyzer.Shared/Rules/Naming/MiKo_1079_CodeFixProvider.cs
Added MiKo_1079_CodeFixProvider to provide automatic fixes for repository class names.  Implemented logic to suggest and apply better names for classes.

+17/-0

Resources.resxAdd resources for MiKo_1079 repository suffix rule

MiKo.Analyzer.Shared/Resources.resx
Added resources for MiKo_1079 rule, including title, description, and message format.

+12/-0

Bug fix1 files

Pluralizer.csFix pluralization logic for "child" to "children"

MiKo.Analyzer.Shared/Linguistics/Pluralizer.cs
Fixed logic for pluralizing words ending with "child" to "children".

+1/-1

Configuration changes2 files

MiKo.Analyzer.Shared.projitemsInclude MiKo_1079 analyzer in project items

MiKo.Analyzer.Shared/MiKo.Analyzer.Shared.projitems

Added MiKo_1079_RepositorySuffixAnalyzer to the project items.

+1/-0

MiKo.Analyzer.Shared.CodeFixes.projitemsInclude MiKo_1079 code fix provider in project items

MiKo.Analyzer.Shared/MiKo.Analyzer.Shared.CodeFixes.projitems

Added MiKo_1079_CodeFixProvider to the project items.

+1/-0

Documentation1 files

README.mdUpdate README with MiKo_1079 rule details

README.md
Updated the rule count to 472.  Documented the new MiKo_1079 rule in the rules table.

+2/-1

Additional files (token-limit)1 files

Resources.Designer.cs...

MiKo.Analyzer.Shared/Resources.Designer.cs
...

+1814/-1778

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

(resolves  #1171)


Dashboard suggestions

Hi,
I would like to suggest the following modifications for the dashboard:

a menu where one can select the problem suite that one is interested in, the budget, the algos, etc.
I think of this as being a menu where one can click the settting that one is interested in, and then gets the results, similar to what we have at https://iohprofiler.liacs.nl/ in the Load Data from Repository menu

rename "Raw data" to "Raw data " so one can more easily find it

Gold-standard would be if there was a link to the algos, so that one immediately jumps to their description and check the details (or copy code for own experiments, etc)

Probably more to come, but in particular (1) and (2) would already boost the user experience.
Thanks for all your hard work, it is nice to have such a benchmarking environment!
Carola

1: I'll probably have to do an entirely new dashboard, so there will be a refactoring. However a website with menus etc is probably more than I can do.
For 2 I'm not sure I get it, the extra-space is for a better Ctrl-F experience ?
For 3 just using the github search-box for Nevergrad does the job I think.

Thanks for your response.
I do not remember any more the issue with (2), now it seems fine.
As for (1), ok, will wait for your new design then. (you are raising expectations here ;-) )


Remove the comment that says "Hourly backup frequency is in preview" because is not.

Hey there,
Regarding this piece of the documentation: https://learn.microsoft.com/en-us/azure/backup/backup-azure-vms-enhanced-policy?tabs=azure-portal#create-an-enhanced-policy-and-configure-vm-backup .
It says:
"Note that Hourly backup frequency is in preview".
But it is no longer in preview based on this documentation: https://learn.microsoft.com/en-us/azure/backup/whats-new#multiple-backups-per-day-for-azure-vms-is-now-generally-available .
Please make the necessary change.
Regards,
-Saul

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b630d454-ef81-a16d-7117-cfdafe5c0bf6
Version Independent ID: 0712fd6b-f226-5ce0-3568-76120332bfdd
Content: Back up Azure VMs with Enhanced policy - Azure Backup
Content Source: articles/backup/backup-azure-vms-enhanced-policy.md
Service: backup
GitHub Login: @jyothisuri
Microsoft Alias: jsuri

@scaravacap Thanks for bringing this to our notice. We will review the doc and make necessary changes.

@scaravacap Appreciate your patience in this matter. As of now, there is no official public announcement from the product owners yet. Once GA is announced publicly, the document will be updated accordingly.
FYI: For a week, the doc repository has been frozen, and no updates will permitted till 23rd May.


chore(pkg): use builtin min/max

Go 1.21 introduced min/max functions so there is no need to have our own implementation. We only need to keep MinInt64 as it's used by scanner.
https://tip.golang.org/ref/spec#Min_and_max
Description

[x] CHANGELOG update is not needed
[x] Documentation is not needed

Testing

[x] inspected CI results

Automated testing

[x] modified existing tests
[x] contributed no automated tests

How I validated my change
CI

/retest


Fork the lockdown test to reflect its also testing namespace overrides.

A future patch set will change the lockdown test to drop out the namespace override test bits.

This is ready to go, but needs the version bump reverted. It was put in place to ensure all the changes work.

Trying to maintain history. the existing lockdown test is doing 2 things. testing production values, and namespace-override testing. To follow the established principal of one pr doing just one thing, we need to fork the test into the two so its obvious where the test came from. We then can continue to enhance both test separately in separate pr's.


[Icon Request] drawio files

Extensions: drawio drawio.svg drawio.png drawio.html
Icon: https://github.com/jgraph/drawio/blob/dev/src/main/webapp/images/drawlogo-color.svg

will be handled in v1 :) (coming soon ™ )

closing this, will be available as soon as v1 is published! :)


fix(sbb-calendar): fix wrong width when orientation changes in iOS

Due to a Safari iOS rendering bug we need to define min-width as well.
Otherwise, after orientation change, there is a wrong width if placed in an sbb-dialog.

Codecov Report

Merging #2044 (a013f85) into master (ab917b0) will decrease coverage by 18.25%.
Report is 1732 commits behind head on master.
The diff coverage is 30.54%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@             Coverage Diff             @@
##           master    #2044       +/-   ##
===========================================
- Coverage   54.85%   36.60%   -18.25%
===========================================
  Files          49      288      +239
  Lines        1659    10928     +9269
  Branches      406     2387     +1981
===========================================
+ Hits          910     4000     +3090
- Misses        671     6668     +5997
- Partials       78      260      +182

Files
Coverage Δ

...c/components/sbb-action-group/sbb-action-group.tsx
100.00% <100.00%> (ø)

...mponents/sbb-alert-group/sbb-alert-group.events.ts
100.00% <100.00%> (ø)

src/components/sbb-alert/sbb-alert.events.ts
100.00% <100.00%> (ø)

...onents/sbb-autocomplete/sbb-autocomplete.events.ts
100.00% <ø> (ø)

src/components/sbb-card-badge/sbb-card-badge.tsx
100.00% <100.00%> (+11.11%)
:arrow_up:

src/components/sbb-card/sbb-card.stories.tsx
0.00% <ø> (ø)

src/components/sbb-card/sbb-card.tsx
90.00% <ø> (ø)

.../sbb-checkbox-group/sbb-checkbox-group.stories.tsx
0.00% <ø> (ø)

...mponents/sbb-checkbox-group/sbb-checkbox-group.tsx
33.33% <ø> (ø)

src/components/sbb-checkbox/sbb-checkbox.events.ts
0.00% <ø> (ø)

... and 55 more

... and 239 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


3937 events with idaklu output variables - solver edit

Description
This is an alternative to #4150 (old pull request will be closed)
Simulations using the IDAKLU solver with output variables specified which terminated with an event rather than the final time step would crash trying to find the termination event.
Termination events are found in the Solution class by using the state vector of the final time-step to evaluate each potential termination event and find the minimum (the event which caused the termination). When output variables are specified in the IDAKLU solver only those variables are output in y_out, not the entire state vector, so the events could not be evaluated outside the solver.
This PR edits the IDAKLU solver to add an additional return value containing the state vector for the final timestep only ('y_term') when output variables are specified. This value is used to fill the Solution.y_event attribute and allows termination events to be calculated as normal, while not impacting the performance advantages of selecting only a few output variables. When output variables are not specified, this returns an empty array as it copies part of the provided state vector.
Fixes #3937
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

[ ] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[x] Bug fix (non-breaking change which fixes an issue)

Key checklist:

[x] No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
[x] All tests pass: $ python run-tests.py --all (or $ nox -s tests)
[x] The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).
Further checks:

[ ] Code is commented, particularly in hard-to-understand areas
[x] Tests added that prove fix is effective or that feature works

As mentioned in the previous PR (https://github.com/pybamm-team/PyBaMM/pull/4150#discussion_r1639840070), specifying output variables in the IDAKLU solver doesn't currently work with experiments. This bug fix should enable that behaviour to be added, but I think it should be a separate issue/PR for a new feature, rather than added to this one.

@all-contributors please add @pipliggins  for code and test


Honda CR-V 5G fails to fingerprint without comma power

          please feel free to re-open with a route so we can check this out

Originally posted by @sshane in https://github.com/commaai/openpilot/issues/31006#issuecomment-1918317971

Wish I knew how to put a route in here for you. Any steps I can take to get Dashcam mode to recognize my car? Would love to see what comma 3X can help me do…

In the device settings it will have a dongle ID. You can post that here

It has the dongle ID: 54f2cff3e445c51e
On the 3X but I see no way to download drives…
Can you send a screenshot or more detailed directions?

It has the dongle ID: 54f2cff3e445c51e On the 3X but I see no way to download drives… Can you send a screenshot or more detailed directions?

You can find the drives on connect.comma.ai
1. Click on a drive and you will see two menu items (Select menu item More info:

2. Select the preserve toggle

3. Select menu item Files
4. Upload all logs (Make sure your comma device is connected to wifi)

Is there a reason you tried to fingerprint as a Civic Bosch?

Please try this branch and let me know if it works:
Installer URL: https://installer.comma.ai/commaai/civic-bosch-no-obd

I did not intend for to fingerprint as a civic...
YES the civic-bosch-no-obd branch is working. Thank you.
Are there any next steps you recommend so that I can take full advantage of the tech?

Make sure you put your device on WiFi so we can check out the logs.

Whenever the car is home it connects to WiFi.

Done in https://github.com/commaai/openpilot/pull/31259!
I noticed a few routes your camera and radar failed to respond (each in separate routes). Can you let me know when the device is on WiFi again?


How can I change the colour/style of the item separator line

Please indicate to peeps that
    xmlns:sys="clr-namespace:System;assembly=mscorlib"

needs to be added to the xmlns statements for the line
       <Label Text="{Binding Source={x:Static sys:DateTime.Now}, StringFormat='{0:MMMM dd, yyyy}'}"

Otherwise how will noobs like me know!!! Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 05d3c8f0-3066-5129-e6cd-3c3d05fcbb59
Version Independent ID: 05d3c8f0-3066-5129-e6cd-3c3d05fcbb59
Content: .NET MAUI Shell flyout - .NET MAUI
Content Source: docs/fundamentals/shell/flyout.md
Product: dotnet-mobile
Technology: dotnet-maui
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @gfmoore I think you made a mistake here. The content of the issue doesn't match your subject and I'm unsure what you're referencing exactly.


adds rijksregisternummer

This will generate a Belgian social security number. I've added tests as well.

I'm adding documentation

Thanks!


Add examples section to ockam tcp-outlet create command's help

Current Behaviour
ockam tcp-outlet create --help

does not display any examples
Desired Behaviour
As part of the help show the following examples section:
EXAMPLES

    # Create a target service, we'll use a simple http server for this example
    python3 -m http.server --bind <IP_ADDRESS> 5000

    # Create two nodes
    ockam node create n1
    ockam node create n2

    # Create a TCP outlet from n1 to the target server
    ockam tcp-outlet create --at /node/n1 --from /service/outlet --to <IP_ADDRESS>:5000

    # Create a TCP inlet from n2 to the outlet on n1
    ockam tcp-inlet create --at /node/n2 --from <IP_ADDRESS>:6000 --to /node/n1/service/outlet

    # Access the service via the inlet/outlet pair
    curl <IP_ADDRESS>:6000

LEARN MORE

References
Here's an example of command that currently shows examples
ockam node create --help

Here's the code for the ockam node create command
https://github.com/build-trust/ockam/blob/e6813de8c0cd5c10b438a7b1ff11d40b97d39c40/implementations/rust/ockam/ockam_command/src/node/create.rs#L39-L54
Here's the code for the ockam tcp-outlet create command
https://github.com/build-trust/ockam/blob/develop/implementations/rust/ockam/ockam_command/src/tcp/outlet/create.rs

We love helping new contributors!
If you have questions or need help as you work on your first Ockam contribution, please leave a comment on this discussion.
If you're looking for other issues to contribute to, checkout this discussion and labels -  https://github.com/build-trust/ockam/labels/good first issue or https://github.com/build-trust/ockam/labels/help wanted

Addressed in https://github.com/build-trust/ockam/pull/3350
Thank you @chrischiedo


Please share the step by step details to enable teams automatic reocrding

Please share the step by step details to enable teams automatic reocrding

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 733c7b3e-1daa-7569-9059-c3c335262155
Version Independent ID: 733c7b3e-1daa-7569-9059-c3c335262155
Content: Manage Microsoft Teams meeting recording options for sensitive meetings - Microsoft Teams
Content Source: Teams/manage-meeting-recording-options.md
Service: msteams
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

Duplicate of https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/10587


Implement new operator: has_substring within in_collection

Not sure how broad the use case is for this, but I ran into an application this morning.
Example query: all companies in the US whose names include the name of any of the presidents sculpted into the side of Mount Rushmore.
Would be pretty sweet to run this as one query! As of writing, there are only four faces on the side of Mount Rushmore. But in the future, who knows! Other examples could require many more in_collection too that would be tedious to write out as individual queries.

from @chewselene: "might make sense to just have the input of @has_substring be a list, which would allow for single of multiple substrings without requiring a second directive"

We unfortunately can't change has_substring to take a list instead of a single string, since that'd break all current uses of has_substring that use only a single string. And allowing has_substring to take both a string and a list of strings would be problematic since we would then have to infer something like union StrOrList = String | [String] as the type of the input argument, which would introduce its own complexities.
The cleanest way forward is probably a new operator dedicated to this purpose. Any suggestions on what it should be named? has_substrings sounds like it would require all substrings instead of any of them, and everything else I can think of feels too verbose...

How about has_any_substring?

Another example, less fun, more business -- say I wanted to query for all the board members of companies that received funds from the Paycheck Protection Program.

Original Financial Times article
Small Business Administration - raw data.

Or better: if I already had a list of all elected members of congress, state and federal (thanks wikidata), find me the overlap between these thousands of organizations, their board members, and the elected officials. Here's the catch, the raw data released by the SBA may not match the organization name in my board member data set. Granted, this is a very expensive query and has_any_substring might not be a better solution than running a linking service first, but this is a very practical example that I'm sure journalists all over the country are currently sleuthing through.

Let's take discussions like this to slack or plain old email. Not sure if
we should be cc-ing<EMAIL_ADDRESS>On Wed, Jul 8, 2020 at 1:18 PM Julian An-Khang Goetz <
<EMAIL_ADDRESS>wrote:

Another example, less fun, more business -- say I wanted to query for all
the board members of companies that received funds from the Paycheck
Protection Program.

Original Financial Times article
https://sba.app.box.com/s/wz72fqag1nd99kj3t9xlq49deoop6gzf
Small Business Administration - raw data
https://sba.app.box.com/s/wz72fqag1nd99kj3t9xlq49deoop6gzf.

Or better: if I already had a list of all elected members of congress,
state and federal (thanks wikidata), find me the overlap between these
thousands of organizations, their board members, and the elected officials.
Here's the catch, the raw data released by the SBA may not match the
organization name in my board member data set. Granted, this is a very
expensive query and has_any_substring might not be a better solution than
running a linking service first, but this is a very practical example that
I'm sure journalists all over the country are currently sleuthing through.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kensho-technologies/graphql-compiler/issues/878#issuecomment-655649136,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACCHGKMLRY2QLHOAL4Y7AJ3R2SS43ANCNFSM4OS7ZHKQ
.


FIX change tilesize to float input to enable typing in the GUI

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Add a link to the CLA to CONTRIBUTING.md

Add a note in CONTRIBUTING about accepting the CLA.
:warning: This cannot be merged yet :warning:
@bkeepers is going to add an appropriate route to the CLA app, once that's done we can merge this.

:+1: anyone should now be able to accept the CLA by visiting: https://cla.github.com/github/git-lfs/accept

:heart: you're the best @bkeepers

This link seems to have disappeared. Is accepting the CLA still required for new contributions?

Thanks, filed PR https://github.com/git-lfs/git-lfs/pull/2997 to address this in the contributor's guide.


[KOGITO-5976] - Kogito operator de-scoping - support for AllNamespaces

Many thanks for submitting your Pull Request :heart:!
Jira issue : https://issues.redhat.com/browse/KOGITO-5976
remove leftover code of KOGITO-5976.
Please make sure your PR meets the following requirements:

[ ] You have read the contributors' guide
[ ] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[ ] Pull Request contains a link to the JIRA issue
[ ] Pull Request contains a description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket
[ ] Your feature/bug fix has a unit test that verifies it
[ ] You've ran make before-pr and everything is working accordingly
[ ] You've tested the new feature/bug fix in an actual OpenShift cluster
[ ] You've added a RELEASE_NOTES.md entry regarding this change

How to retest this PR or trigger a specific build:

Run operator BDD testing
Please add comment: /jenkins test

Run RHPAM operator BDD testing
Please add comment: /jenkins RHPAM test

@vaibhavjainwiz can you please check the OLM tests?

@vaibhavjainwiz can you please check the OLM tests?

This issue is already reported to OLM team.
https://github.com/redhat-openshift-ecosystem/operator-test-playbooks/issues/305

/jenkins test

PR job #562 was: UNSTABLE
Possible explanation: This should be test failures
You can find test error logs here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/562//artifact/test/logs/error/
Please look here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/562/display/redirect or see console log:

Console Logs
                                FAIL	github.com/kiegroup/kogito-operator/test	1474.669sFAILTests finished with code 1-------- Pruning namespacesI0224 10:22:09.749322   60042 request.go:655] Throttling request took 1.048204887s, request: GET:https://<IP_ADDRESS>:443/apis/app.kiegroup.org/v2?timeout=32s{"level":"info","T":"2022-02-24T10:22:11.291Z","logger":"kogito-operator-system","msg":"Deleting namespace","namespace":"kogito-operator-system"}{"level":"error","T":"2022-02-24T10:22:11.315Z","logger":"kubernetes_client","msg":"Failed to delete resource.","name":"kogito-operator-system","error":"namespaces \"kogito-operator-system\" not found"}{"level":"error","T":"2022-02-24T10:22:11.315Z","logger":"main","msg":"Error in deleting namespace","error":"Cannot delete namespace kogito-operator-system: namespaces \"kogito-operator-system\" not found"}Pruning namespaces done./home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test-------- Delete stucked namespacesProjects deleted:-------- Clean Cluster operators--- Clean subscriptions in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean clusterserviceversions in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean subscriptions in operatorsNo resources found in operators namespace.--- Clean clusterserviceversions in operatorsNo resources found in operators namespace.-------- Clean dependencies CRDsDelete cluster crds grafanadashboards.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadashboards.integreatly.org" deletedDelete cluster crds grafanadatasources.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadatasources.integreatly.org" deletedDelete cluster crds grafananotificationchannels.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafananotificationchannels.integreatly.org" deletedDelete cluster crds grafanas.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanas.integreatly.org" deletedDelete cluster crds backups.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "backups.infinispan.org" deletedDelete cluster crds batches.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "batches.infinispan.org" deletedDelete cluster crds caches.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "caches.infinispan.org" deletedDelete cluster crds infinispans.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "infinispans.infinispan.org" deletedDelete cluster crds restores.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "restores.infinispan.org" deletedDelete cluster crds kafkabridges.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkabridges.kafka.strimzi.io" deletedDelete cluster crds kafkaconnectors.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkaconnectors.kafka.strimzi.io" deletedDelete cluster crds kafkaconnects.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkaconnects.kafka.strimzi.io" deletedDelete cluster crds kafkamirrormaker2s.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkamirrormaker2s.kafka.strimzi.io" deletedDelete cluster crds kafkamirrormakers.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkamirrormakers.kafka.strimzi.io" deletedDelete cluster crds kafkarebalances.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkarebalances.kafka.strimzi.io" deletedDelete cluster crds kafkas.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkas.kafka.strimzi.io" deletedDelete cluster crds kafkatopics.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkatopics.kafka.strimzi.io" deletedDelete cluster crds kafkausers.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkausers.kafka.strimzi.io" deletedmake[2]: *** [Makefile:8: run-tests] Error 1make[2]: Leaving directory '/home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test'make[1]: *** [Makefile:16: run-smoke-tests] Error 2make[1]: Leaving directory '/home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test'make: *** [Makefile:327: run-smoke-tests] Error 2[Pipeline] sh+ rm -rf console.log[Pipeline] sh

/jenkins test

PR job #564 was: UNSTABLE
Possible explanation: This should be test failures
You can find test error logs here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/564//artifact/test/logs/error/
Please look here: https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/564/display/redirect or see console log:

Console Logs
                               FAIL	github.com/kiegroup/kogito-operator/test	1458.612sFAILTests finished with code 1-------- Pruning namespacesI0224 15:06:17.386212   48578 request.go:655] Throttling request took 1.041268044s, request: GET:https://<IP_ADDRESS>:443/apis/discovery.k8s.io/v1beta1?timeout=32s{"level":"info","T":"2022-02-24T15:06:19.003Z","logger":"kogito-operator-system","msg":"Deleting namespace","namespace":"kogito-operator-system"}{"level":"error","T":"2022-02-24T15:06:19.114Z","logger":"kubernetes_client","msg":"Failed to delete resource.","name":"kogito-operator-system","error":"namespaces \"kogito-operator-system\" not found"}{"level":"error","T":"2022-02-24T15:06:19.114Z","logger":"main","msg":"Error in deleting namespace","error":"Cannot delete namespace kogito-operator-system: namespaces \"kogito-operator-system\" not found"}Pruning namespaces done./home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test-------- Delete stucked namespacesProjects deleted:-------- Clean Cluster operators--- Clean subscriptions in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean clusterserviceversions in openshift-operatorsNo resources found in openshift-operators namespace.--- Clean subscriptions in operatorsNo resources found in operators namespace.--- Clean clusterserviceversions in operatorsNo resources found in operators namespace.-------- Clean dependencies CRDsDelete cluster crds grafanadashboards.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadashboards.integreatly.org" deletedDelete cluster crds grafanadatasources.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanadatasources.integreatly.org" deletedDelete cluster crds grafananotificationchannels.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafananotificationchannels.integreatly.org" deletedDelete cluster crds grafanas.integreatly.orgcustomresourcedefinition.apiextensions.k8s.io "grafanas.integreatly.org" deletedDelete cluster crds backups.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "backups.infinispan.org" deletedDelete cluster crds batches.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "batches.infinispan.org" deletedDelete cluster crds caches.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "caches.infinispan.org" deletedDelete cluster crds infinispans.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "infinispans.infinispan.org" deletedDelete cluster crds restores.infinispan.orgcustomresourcedefinition.apiextensions.k8s.io "restores.infinispan.org" deletedDelete cluster crds kafkabridges.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkabridges.kafka.strimzi.io" deletedDelete cluster crds kafkaconnectors.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkaconnectors.kafka.strimzi.io" deletedDelete cluster crds kafkaconnects.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkaconnects.kafka.strimzi.io" deletedDelete cluster crds kafkamirrormaker2s.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkamirrormaker2s.kafka.strimzi.io" deletedDelete cluster crds kafkamirrormakers.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkamirrormakers.kafka.strimzi.io" deletedDelete cluster crds kafkarebalances.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkarebalances.kafka.strimzi.io" deletedDelete cluster crds kafkas.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkas.kafka.strimzi.io" deletedDelete cluster crds kafkatopics.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkatopics.kafka.strimzi.io" deletedDelete cluster crds kafkausers.kafka.strimzi.iocustomresourcedefinition.apiextensions.k8s.io "kafkausers.kafka.strimzi.io" deletedmake[2]: *** [Makefile:8: run-tests] Error 1make[2]: Leaving directory '/home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test'make[1]: *** [Makefile:16: run-smoke-tests] Error 2make[1]: Leaving directory '/home/jenkins/agent/workspace/kogito/kogito-operator-PR-check/test'make: *** [Makefile:327: run-smoke-tests] Error 2[Pipeline] sh+ rm -rf console.log[Pipeline] sh+ wget --no-check-certificate -qO - https://jenkins-kogito-tools.kogito-cluster-0ad6762cc85bcef5745bb684498c2436-0000.us-south.containers.appdomain.cloud/job/kogito/job/kogito-operator-PR-check/564/consoleText+ tail -n 100


mike: codereview

is forex_python your module? missing in repository

forex-python is not my module. I've added requirements.txt file so you can use that now.


Edit bugs in mod mark all display message

Codecov Report

Merging #152 (a256322) into master (a0c86bc) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #152   +/-   ##
=========================================
  Coverage     70.19%   70.19%
  Complexity      596      596
=========================================
  Files            94       94
  Lines          1899     1899
  Branches        245      245
=========================================
  Hits           1333     1333
  Misses          480      480
  Partials         86       86

Impacted Files
Coverage Δ

...a/seedu/masslinkers/logic/commands/ModCommand.java
100.00% <ø> (ø)

src/main/java/seedu/masslinkers/ui/HelpWindow.java
0.00% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


fix(shipper): update DHL for Germany

Fixed German DHL sensor
Breaking change
none
Proposed change
German DHL sensor did not work. I adjusted the patterns so hopefully it will now detect mails correctly.
Type of change

[x] Bugfix (non-breaking change which fixes an issue)
[x] Update existing shipper

You'll need to make the edits off the dev branch rather than the master branch you created this from.


Support for TLS certificate authentication

Adding "tls_certificate_path" & "tls_certificate_password" as input options for logstash plugin.
I will do the corresponding change to "logstash-mixin-rabbitmq_connection" & "march_hare" code as well.
-Sunil

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then  say 'jenkins, test it'.

Closing this because adding these options at https://github.com/logstash-plugins/logstash-mixin-rabbitmq_connection/pull/12 will provide these settings for this plugin.


Fix log for Grafana URL

When user wants to access Grafana dashboard listening to 3000, this method helps to achieve it easily.

Hi @eddumelendez , I want to query tempo programatically using below sample and also I want to use LGTMContainer as testcontainers in dev-mode so that I can play in UI
 given().contentType(ContentType.URLENC)
                .body("q={span.http.response.status_code=\"200\"}")
                .when()
                .post("/api/datasources/proxy/uid/tempo/api/search")
                .then()
                .statusCode(HttpStatus.SC_OK)
                .contentType(ContentType.JSON)
                .body("metrics.completedJobs", is(1))
                .body("metrics.totalJobs", is(1));

Ok, understood! and I just noticed we are logging the url but not for grafana 😢, so we should fix that. Currently, we are not exposing ports for Tempo and Loki, we can add those as well. I didn't include them at the beginning since couldn't built test for those and was looking for feedback from the community. So, your feedback is great! WDYT about fixing the log? and if you have time to add proper validation for Tempo then it would be very much appreciated

@eddumelendez , just fixed log before your comment. I will work on test cases over the weekend

Thanks for your contribution, @rajadilipkolli !


⚠ ClamAV has degraded performance

In 8e51222, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 199 ms

Resolved: ClamAV performance has improved in 7e896e3.


fix: resource_group_id is only required if creating KP instance

Description
resource_group_id is only required if creating KP instance
Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

:tada: This PR is included in version 4.8.2 :tada:
The release is available on:

GitHub release
v4.8.2

Your semantic-release bot :package::rocket:


livecheck: add --extract-plist

[X] Have you followed the guidelines in our Contributing document?
[X] Have you checked to ensure there aren't other open Pull Requests for the same change?
[X] Have you added an explanation of what your changes do and why you'd like us to include them?
[X] Have you written new tests for your changes? Here's an example.

Running brew livecheck --cask --eval-all downloads all casks using the ExtractPlist strategy. This takes up a significant amount (~20GB) of bandwidth and cache space.
If this flag is added, it will allow maintainers to check taps more quickly and with less resources consumed.

Out of curiosity I looked it up and this would affect 275 core casks. Outside of memory savings is this faster as well?

It is significantly faster to run brew livecheck if you skip the extract_plist.
The strategy downloads the binary and checks the contents for a version number, whereas most of the time we are checking HTML webpage contents, or a curl response header.
As some of the files are quite large the network requests can take some time to complete. Note that we only use this strategy when all other alternatives are not possible.
I have my own script locally that runs livecheck on a tap after filtering out the extract_plist casks, which could be replaced with this flag.

Maybe this could work similarly to audit with --only and --except flags, so it can also be used more generically to validate changes e.g. when changing a strategy.

--extract-plist is added instead so it's opt-in

I like this idea. Do we have to worry about backwards compatibility with this command though. If so, we'll have to go through the whole deprecation cycle and the way it's currently written would be the fastest way to get access to it. It seems like more of an internal command so we're probably fine though.

Do we have to worry about backwards compatibility with this command though.

100% not.

It seems like more of an internal command so we're probably fine though.

Agreed.

We could even perhaps have a documented policy that some/all developer commands do not require deprecation periods at all.

Thank you all for the suggestions! I've reworked this.

The default behavior has been changed to skip ExtractPlist casks.
Single cask checks maintain current behavior.
Added --extract-plist flag to opt-in to the livecheck strategy.

Thanks @razvanazamfirei!

There does seem to be a problem with the generated man page and shell completions. It's deleting info related to a few commands. I think these were commands that @dduugg moved to the new command DSL recently so maybe that's related somehow. I really have no idea.

Thanks for flagging, i'll take a look.

There does seem to be a problem with the generated man page and shell completions. It's deleting info related to a few commands. I think these were commands that @dduugg moved to the new command DSL recently so maybe that's related somehow. I really have no idea.

Thanks for flagging, i'll take a look.

Looks like I fat-fingered Homebrew::DevCmd::BumpUnversionedCask, should be Homebrew::DevCmd::BumpUnversionedCasks. I'll fix that and a test to validate classes map to their file/cmd names as expected.


Gradescope Integration

Initial plan:

There will also be the option to automatically sync a class's assignments (opt-in)

It will sync every time the user opens gradescope (i.e. to submit an assignment), I think this is the only way to do it since no official API is provided

There will be a global option to disable this feature entirely
Gradescope synced assignments will be stored in local storage

Identified by (course, index on page)
Linking to the correct course will be a challenge, I'm thinking just compare names and allow the user to edit for the ones that don't get matched/are matched incorrectly

Just let the user pick the class (1-3 extra clicks), but suggest a recommended based on name matching

Assignment info will just be scraped (name, link, status, due date)

When adding to Canvas, compare it with existing assignments and only add if there is no assignment with the same due date, course, and similar name

Nothing will be fetched while the user is taking a quiz (the submit button is present)

Not sure if this is necessary, just don't want it to interfere with anything important

Maybe a "Tasks for Gradescope" sidebar on the Gradescope dashboard

I think this update needs to go out after editing custom tasks.
Users will be able to delete the tasks just like custom tasks, editing isn't a problem since task name, course, and due date should be accurate.

Identified by (course, index on page)
Could you use the assignment ID number in each assignment's link instead of the index on the page? I don't know if it's important to store assignments with no links (e.g. ones that are locked or weren't submitted)

I'm thinking if we just scrape all the assignments for the course at once, we don't really need to keep track of individual assignments, just update the whole list in storage when the script runs. I'd also like having the ones without links (but with a due date) to still show up, it'll just link to the course's gradescope page instead of the submission page.

Just tried it in Edge, and I like the implementation (though maybe a warning for "You haven't opened Gradescope in 3 days. Click here to open it in the background and sync" or something like that would be helpful). I don't think I had any issues at all.

Actually, one issue: a lot of people use Gradescope in the respective Canvas course's "Gradescope" tab. The extension doesn't seem to be able to access this iframe at all (I don't see the "Synced with Tasks for Canvas" button in the iframe).

Actually, one issue: a lot of people use Gradescope in the respective Canvas course's "Gradescope" tab. The extension doesn't seem to be able to access this iframe at all (I don't see the "Synced with Tasks for Canvas" button in the iframe).

There's a manifest key to enable the extension to run in iframes which should resolve this, I just need to check if it creates any new permissions warnings when updated


Error when used with html-webpack-plugin@v4

ERROR in   TypeError: Cannot read property 'hash' of undefined

  - compiler.js:265
    [aurox-client-web]/[html-webpack-plugin]/lib/compiler.js:265:30

  - runMicrotasks

  - task_queues.js:93 processTicksAndRejections
    internal/process/task_queues.js:93:5

When I disable the speed-measure-webpack-plugin the error goes away, might be related to:
https://dev.to/jantimon/html-webpack-plugin-4-has-been-released-125d#performance

Can you check that this happens with 1.3.3?

This is weird, I had updated my dependencies and got that error. But to be safe I cleaned my node_modules and reinstalled everything. and the issue is gone.
Sorry for the trouble, but I guess this is good for future reference in case someone else gets the same error.

Wait actually, it came back. seems like it happens randomly. I'm guessing it has something to do with the new apis the plugin has started using from version 4. And maybe this tool interferes with them.

latest libs, latest webpack, same error as two years ago


Don't check if INVALID bugs are regressions

Coverage remained the same at 27.263% when pulling 1f0d6dd021d4f5d446e0262c210dc006eb0edfd3 on marco-c:ignore_invalid_regression into 04bd8db5812436a8a13f3749130fa57564381672 on mozilla:master.


NOTICK: update pipeline logic to ensure we use corda-dependencies Artifactory repo

logic  in the Jenkins shared lib, checks to see if publishRepoPrefix equals 'corda' . if this is true AND its a build coming from a tag the Artifactory repo used is corda-dependencies.
Update the Jenkins file to use the expected prefix corda, therefore ensuring tag builds on Jenkins go to corda-dependecies  rather than corda-dependencies-dev

Draft while verifying


Error with updating modules when scripts are defined on the composer.json file

Hi,
I've come across an issue when defining a custom script on one of my modules. Here is the composer.json file:
{
    "name": "creode/externalapiauthentication",
    "description": "",
    "authors": [
        {
            "name": "Creode",
            "email"<EMAIL_ADDRESS>        }
    ],
    "extra": {
        "laravel": {
            "providers": [],
            "aliases": {

            }
        }
    },
    "autoload": {
        "psr-4": {
            "Modules\\ExternalApiAuthentication\\": ""
        }
    },
    "scripts": {
        "build-docs": "npx redoc-cli --output Docs/api/docs.html build Docs/api/document-retrieval-api.yml"
    }
}

Upon running the php artisan module:update command I get an error stating: array_merge(): Argument #1 must be of type array, string given.
This is when using PHP 8.0.21.

just like in composer.json the scripts expect an array so yous can be changed to:
"scripts": {
        "build-docs": [
            "npx redoc-cli --output Docs/api/docs.html build Docs/api/document-retrieval-api.yml"
        ]
    }

This will then run the command

Perfect, thank you for this. 👍


Add to negative prompt dynamically

When using dynamic prompts it would be handy to be able to insert values into the negative prompt at the same time.  For example, say I want to randomly select between 2 characters.  {character1|character2}
in  character1 has 'female, (Black hair with {red|green|blue|purple} tips), blue eyes'
in  character2 has 'female, (white hair), blue eyes'
Sometimes character1 will generate a result with white stripes in the hair for some reason (SD is funny that way). Usually I'd add ((white hair)) into the negative prompt to correct that. But it would then also subtract from character2 whenever it's randomly selected.
So it would be handy if wildcards supported something like this;
in character1 has 'female, (Black hair with {red,|black|blue|purple} tips), blue eyes, --((white hair))--'
so that whenever character1  is randomly selected it will automatically insert ((white hair)) into the negative prompt, but it would never be inserted if character2 is randomly selected.
I hope that explains my idea??

never mind, I just found https://github.com/acorderob/sd-webui-prompt-postprocessor that can do pretty much this feature


Changes to support the ALLCAPS spec change in XVIZ

This is dependent on https://github.com/uber/xviz/pull/477 and makes the expectation it will be published as beta.16.  This cannot land until that is published.
This covers places in the code where any enumerated types where being referenced directly and will normalize them to UPPERCASE to support both existing data as well as new data.  This should be backwards compatible with previously generated data but will have a hard dependency on the new xviz module version.
Testing was ran as follows:

get-started

yarn start-local using local modules hitting AWS hosted data
yarn start-streaming-local using local modules hitting local XVIZ server with UPPERCASE data

website-demo

yarn start-local using local modules hitting local XVIZ server with UPPERCASE data
built and tested bundled in website which is local modules hitting AWS hosted data

playground

yarn start-local using local modules and updated embedded test cases

Coverage decreased (-0.08%) to 39.479% when pulling a65f33329ad2756adef9a7120b101fbe7a8aa701 on tpw/spec-allcaps into 5d422ab4be3ad1d51cdb904471f243ee7ea44daa on master.


Movie Poster Blocks Part of Trailer

Describe the bug
When playing a trailer, the post poster moves to the side, but still appears over the playing video.
To Reproduce
Steps to reproduce the behavior:

Play a trailer.

Expected behavior
The trailer should be the foreground.
Screenshots

Desktop (please complete the following information):

OS: Windows
Browser: Chrome
Version: 88.0.4324.190

Yeah this isn't an issue it's literally taking up at most like 30px

Yeah this isn't an issue it's literally taking up at most like 30px

50 pixels, actually.  Why do you want to cover up any portion of the trailer?  What purpose does it serve?


[DOR-67][AO] export question for route type

This PR provides most of the export questions infrastructure, but only aims for route type completeness.

Looks good to me and the build and integration tests pass