I implemented Password Generator using Python. I also added a read me file explaining the code. Hoping to get the PR merged and getting the Hacktoberfest and hacktoberfest- accepted badge

Type of change

[ ] Added new project
[ ] Bug fix
[ ] New features
[ ] Enhanced documentation

Changes proposed in this pull request

Project name :

Short description :

Checklist

[ ] The code is Python 3 compatible
[ ] I have added relevant comments in my file to make code understandable
[ ] I have added my project in a folder which includes all the necessary files

Already exists


Old documentation URLs are referenced in exception message when adding desktop support to existing app

Steps to Reproduce

Execute flutter config --enable-macos-desktop on a project that does not support desktop or does not have a macos folder.

Exception is thrown that says
Exception: No macOS desktop project configured. See
https://flutter.dev/desktop#add-desktop-support-to-an-existing-flutter-app to learn about adding macOS support to a
project.

The link does not work anymore with the new website update. It should be redirected to "https://docs.flutter.dev/desktop#add-desktop-support-to-an-existing-flutter-app"

[✓] Flutter (Channel stable, 2.5.1, on macOS 11.2.3 20D91 darwin-x64, locale en-IN)
    • Flutter version 2.5.1 at /Users/poojab/dev/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ffb2ecea52 (2 months ago), 2021-09-17 15:26:33 -0400
    • Engine revision b3af521a05
    • Dart version 2.14.2

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/poojab/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/poojab/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] IntelliJ IDEA Community Edition (version 2021.2.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.62.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 11.2.3 20D91 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 96.0.4664.55

• No issues found!

Hi @PoojaB26, I tested this on an old project that does not support desktop and the issue is not reproducible. I'll label this for further investigation

logs
Setting "enable-macos-desktop" value to "true".

flutter doctor -v
[✓] Flutter (Channel stable, 2.5.3, on macOS 11.6.1 20G224 darwin-x64, locale en-US)
    • Flutter version 2.5.3 at /Users/flo/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 18116933e7 (6 weeks ago), 2021-10-15 10:46:35 -0700
    • Engine revision d3ea636dc5
    • Dart version 2.14.4

[!] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/flo/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 13.1, Build version 13A1030d
    • CocoaPods version 1.11.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.62.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.28.0

[✓] Connected device (4 available)
    • SM G975U (mobile)            • R58M95MA95E   • android-arm64  • Android 11 (API 30)
    • sdk gphone64 x86 64 (mobile) • emulator-5554 • android-x64    • Android 12 (API 31) (emulator)
    • macOS (desktop)              • macos         • darwin-x64     • macOS 11.6.1 20G224 darwin-x64
    • Chrome (web)                 • chrome        • web-javascript • Google Chrome 93.0.4577.63

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 2.6.0-12.0.pre.854, on macOS 11.6.1 20G224 darwin-x64, locale en-US)
    • Flutter version 2.6.0-12.0.pre.854 at /Users/flo/fvm/versions/master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 8b1cf766e7 (18 hours ago), 2021-11-28 10:47:02 -0500
    • Engine revision 4536092a7f
    • Dart version 2.16.0 (build 2.16.0-55.0.dev)
    • DevTools version 2.8.0

[!] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/flo/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[✓] Xcode - develop for iOS and macOS (Xcode 13.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.62.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.28.0

[✓] Connected device (4 available)
    • SM G975U (mobile)            • R58M95MA95E   • android-arm64  • Android 11 (API 30)
    • sdk gphone64 x86 64 (mobile) • emulator-5554 • android-x64    • Android 12 (API 31) (emulator)
    • macOS (desktop)              • macos         • darwin-x64     • macOS 11.6.1 20G224 darwin-x64
    • Chrome (web)                 • chrome        • web-javascript • Google Chrome 93.0.4577.63

! Doctor found issues in 1 category.

Thank you

You weren't able to reproduce because the repro steps are incorrect; this message is printed when trying to build or run for a desktop platform that hasn't been added to a project.
(config is machine-scoped, not project-scoped, so cannot even be run "on a project".)

Please also file a bug on the website to make sure we correct the redirects so that people who follow these links from older versions of Flutter get to the right page. cc @RedBrogdon @sfshaza2

@mamuseferha my bad, updated the reproduction steps! The exception is thrown when you run the project.

see what ? https://github.com/flutter/flutter/pull/95075


Can't install add-on repository.

I try to add the add-on repository and I get this error message.
I'm at the latest version of home assistant, supervisor-2021.12.2 and core-2021.12.6

This is what I can see in Supervisor logs

I try to ping google.com and github.com and both of them respond so it's not the internet connection that is in trouble.
Does anyone has same problem ?

Try this:
https://github.com/thejeffreystone/hassio_addons

Thanks it work. Someone need to update the read me page with the good link.

Readme Updated - bb31c440e728c012c5bee3cdc196ee0fb194d370


Uses implicit behavior in storage regression

NOTE: Uses #570 as diffbase.

Changes Unknown when pulling 36a161719af0f56ad15b9644a2c8ba5ffa529a74 on dhermes:use-implicit-behavior-in-storage into ** on GoogleCloudPlatform:master**.

LGTM.  My question about a mapping could be addressed in a future PR.

For posterity, here is the comment. (I forgot where I had seen it momentarily.)
On that note, I am considering having an _Environ class and using an instance of it as _implicit_environ.DEFAULTS in the same way _implicit_environ is currently used (as a namespace).

Coverage remained the same at 100.0% when pulling 5722c8fa511fb1d9263c2bc8070bc161d056f461 on dhermes:use-implicit-behavior-in-storage into 168d3e531271726321d287601a02136d47ab7caf on GoogleCloudPlatform:master.


Ensures pandas_datareader dependencies are installated on CI

Fixes #4986.

[ ] Tests added / passed
[ ] Passes flake8 dask

Thanks @jrbourbeau! 😄


Missing Kmods for RHEL 8.10 - 4.18.0-553.16.1.el8_10

RHEL 8.10 release a new kernel within the last week. Version: 4.18.0-553.16.1.el8_10
When running yum update, I receive the following error:
NVIDIA driver: some kernel packages have been filtered due to missing precompiled modules.
Please run "dnf nvidia-plugin" as a command to see a report on the filter being applied.

Running dnf nvidia-plugin shows:
Excluded kernel packages during update (4.18.0-553.16.1.el8_10):
  kernel-tools-libs-devel-4.18.0-553.16.1.el8_10.x86_64
  kernel-4.18.0-553.16.1.el8_10.x86_64
  kernel-abi-stablelists-4.18.0-553.16.1.el8_10.noarch
  kernel-core-4.18.0-553.16.1.el8_10.x86_64
  kernel-cross-headers-4.18.0-553.16.1.el8_10.x86_64
  kernel-debug-4.18.0-553.16.1.el8_10.x86_64
  kernel-debug-core-4.18.0-553.16.1.el8_10.x86_64
  kernel-debug-devel-4.18.0-553.16.1.el8_10.x86_64
  kernel-debug-modules-4.18.0-553.16.1.el8_10.x86_64
  kernel-debug-modules-extra-4.18.0-553.16.1.el8_10.x86_64
  kernel-devel-4.18.0-553.16.1.el8_10.x86_64
  kernel-doc-4.18.0-553.16.1.el8_10.noarch
  kernel-headers-4.18.0-553.16.1.el8_10.x86_64
  kernel-modules-4.18.0-553.16.1.el8_10.x86_64
  kernel-modules-extra-4.18.0-553.16.1.el8_10.x86_64
  kernel-tools-4.18.0-553.16.1.el8_10.x86_64
  kernel-tools-libs-4.18.0-553.16.1.el8_10.x86_64

NOTE: Several old kernels have been excludes as they are not applicable.

The kmod-nvidia-550.90.07-4.18.0-553.16.1-550.90.07-3.el8_10.x86_64 is now available.


Edit AODN altimetry catalog

add NetCDFAODNStackSource driver
Add time filter to AODN catalog

Actually is it possible for you to add a couple of tests too? Maybe a couple of pre-defined catalog entry requests where you know the length of the urlpath list and another where you know the length of the returned dataset.

Actually is it possible for you to add a couple of tests too? Maybe a couple of pre-defined catalog entry requests where you know the length of the urlpath list and another where you know the length of the returned dataset.

Sure, I have now these two new tests in test_intake.

Thats good, thats how it works - any commits you add to your fork will come into this PR. That is why in general it is better to create a branch in your fork specific to the changes you want included in the PR

You will also need to pull updates from main. I have fixed the github actions so that the tests get run on the PR

I added geopandas and merged upstream/main with your new changes.

The tests are still failing - thats because there is a separate requirements file that is used to setup the testing environment. Probably there is a better way to configure this so that there isnt duplication, but you also need to add to: https://github.com/rfonsecadasilva/rompy/blob/main/scripts/ci/environment-pip.yml
To see your tests you can look here:
https://github.com/rfonsecadasilva/rompy/actions

And now the tests are running here so we should be able to monitor within this PR thread

The tests are still failing - thats because there is a separate requirements file that is used to setup the testing environment. Probably there is a better way to configure this so that there isnt duplication, but you also need to add to: https://github.com/rfonsecadasilva/rompy/blob/main/scripts/ci/environment-pip.yml
To see your tests you can look here:
https://github.com/rfonsecadasilva/rompy/actions

Thanks, that's good to know. I've included geopandas and intake-geopandas and not the tests successfully passed on my fork.

And now the tests are running here so we should be able to monitor within this PR thread

I couldn't find new tests running here in the PR (maybe you first have to approve them before it starts testing?)

Yeah that seemed to be because you hadnt made a commit to this repo before. I had to approve the CI run.
This all looks good - merging! 🎉


Move ohif-dicom-services out of Meteor and into a separate NPM package

Take everything in here:
https://github.com/OHIF/Viewers/tree/master/Packages/ohif-dicom-services

Keep it as es6 modules: no build or transpilation step necessary since it's only useful for Node.js anyway (No point in using DIMSE in a browser)
Add some index.js and package.json
Create a repository on https://github.com/OHIF/ as something like DIMSE.js
Move the code there, create an npm package, publish it, replace the Meteor package in this repository with the NPM package.

Voila, one less Meteor-specific thing in our codebase.

hey @swederik I'm really glad to see this issue! We are evaluating the viewer for several projects at Stanford, and my one ug moment was when I saw meteor. Do you have a roadmap for this work?


Calibre-web package and service

Calibre-web
Calibre-Web is a web app providing a clean interface for browsing, reading and downloading eBooks using an existing Calibre database.
It is a python package, using versionned releases, with optional dependencies to add support for GDrive, OAuth, LDAP, etc...
A NixOS specific issue for this program would be the integration with calibre, which requires providing a path to its converter tool in the webui.
Metadata

homepage URL: https://github.com/janeczku/calibre-web
source URL: https://github.com/janeczku/calibre-web
license: GPLv3
platforms: all python platforms

I'm interested in running calibre-web on NixOS as well. I've created an initial PR that adds calibre-web package: #113994.
Once it's merged, I'm planning to introduce a service with basic declarative config for it.

@pborzenkov you might be interested by the issue I opened here

@Ambroisie Yeah, I've seen the issue. I hope it gets implemented, so the configuration process won't need to modify the DB. Until then, it looks like the only way to configure calibre-web declaratively is gonna be via sqlite3...

Once it's merged, I'm planning to introduce a service with basic declarative config for it.

Note that it's easier to review with a module.

Note that it's easier to review with a module.

@symphorien  Ok. Should I update the PR with the module itself? It's my first contribution to NixOS, so I'm not yet familiar with the process.

I think adding the module as a separate commit is fine.

This was closed by #113994


Example Report Generation

Hi @bthomas2622 @jonjozwiak ,
We are interested in using copilot-metrics-export-action and was curious if you had example report outputs for member and team level reports? Would love to take a look at what's included in the output.
Thanks!

Here are some examples I'm using from the outputs (just created in Excel):

Thanks @199874 does it include user level metrics?

Thanks @199874 does it include user level metrics?

This output does not contain user level data. There is fairly limited data that can be obtained for an individual user:
https://docs.github.com/en/rest/copilot/copilot-user-management?apiVersion=2022-11-28#get-copilot-seat-assignment-details-for-a-user


request multiple spectograms

Is it possible to send an API request to my local IQEngine with one or more meta and data files and receive a set of spectograms for these files?
Where can I find all the available API calls?

Not currently, the closest thing would be the API call that the client uses to get a spectrogram thumbnail of a recording, but that only includes the first million samples.  But what you're describing wouldn't be hard to add, but I'm curious if you would want the spectrogram to span the entire recording, or would this potential API call include the start-sample and stop-sample to use when creating the spectrogram?


No-pdl instruction update

Gives galleryitem publishers the instructions on how to make their apps compatible with the no-pdl changes

Sorry for the late reply.
This change will get overwritten at the next deployment. Please make your change in the dev branch in the "portal-sdk/template" folder (rather than the "portal-sdk/generated" folder)


Minor changes to "Designing resilient applications for Azure"

@alexbuckgit,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/mspnp/architecture-center, working directory: W:\j4gj-s, target branch: master, target branch commit: 3148ed3cbb7d86eee14c4d975b76946e1fa543c5, source branch: minor, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/mspnp/architecture-center, working directory: W:\i0bs-s, target branch: master, target branch commit: 3148ed3cbb7d86eee14c4d975b76946e1fa543c5, source branch: minor, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Inconsistent Resource nomenclature

I was reading through the main specification and found that it uses the term "Subject Resource" (See section 4.3) to describe what in the notification specification we call "Topic Resource". I am guessing we should rename it here, but it might need bikeshedding.

What's the URI of the closest thing that you're referring to?

https://solidproject.org/ED/protocol#auxiliary-resources

(hereafter referred as the subject resource)


Move ctxerr.Visited in its own package

Signed-off-by: Maxime Soulé<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build 317

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.697%

Totals

Change from base Build 315:
0.0%

Covered Lines:
4938

Relevant Lines:
4953

💛  - Coveralls


Hip windows sdk

This pull request adds supports for HIP-VS, and supersedes https://github.com/amd/rocm-examples/pull/19, https://github.com/amd/rocm-examples/pull/16 and https://github.com/amd/rocm-examples/pull/12. It also implements the required VS changes for https://github.com/amd/rocm-examples/issues/17, as factoring that out leads to a nasty merge conflict and I felt like it was not that much additional overhead.
I applied the patch from #19 internally, and unfortunately it got squashed during the merge.

cc @emankov @hchevanne


Torch not compiled with CUDA enabled

Hi,
I wanted to test qlora but have issue with bitsandbytes this is my code :
from transformers import AutoModelForCausalLM
import torch
print(torch.cuda.is_available())
model = AutoModelForCausalLM.from_pretrained(
'llama-13b-hf',
device_map='auto',
load_in_8bit=True,
max_memory=f'{int(torch.cuda.mem_get_info()[0]/1024**3)-2}GB')
and i get
True
Overriding torch_dtype=None with torch_dtype=torch.float16 due to requirements of bitsandbytes to enable model loading in mixed int8. Either pass torch_dtype=torch.float16 or don't pass this argument at all to remove this warning.
.
.
.
CUDA SETUP: Something unexpected happened. Please compile from source:
git clone git@github.com:TimDettmers/bitsandbytes.git
cd bitsandbytes
CUDA_VERSION=116 make cuda11x
python setup.py install
CUDA SETUP: Setup Failed!
.
.
.
Inspect the output of the command and see if you can locate CUDA libraries. You might need to add them
to your LD_LIBRARY_PATH. If you suspect a bug, please take the information from python -m bitsandbytes
My setup is ;
Processor: 11th Gen Intel(R) Core(TM) i7-11700KF @ 3.60GHz (16 CPUs), ~3.6GHz
Memory: 32768MB RAM
Card name: NVIDIA GeForce RTX 3060
Display Memory: 28431 MB
Dedicated Memory: 12129 MB

I think this has been fixed in a recent release. Please upgrade and report back if you still face the issue.


Add upper bound to compatible Rails versions

Rails::VERSION::MAJOR >= 3 implies this is a future proof gem that will work with rails ~>12.3.4 whenever it is released in the future. This proposed change errors on the side of caution to better outline which known major versions of rails are known to be compatible with this specific version of this gem.

I asked for this change intentionally. I understand that it may fail, but it also may work too. Rails 7 has been out for how long now and this gem has silently been disabled for how many hundreds of thousands of developers in that time when there were zero compatibility issues. The railtie we're using is quite minimal and is using public and supported APIs. I think the harm is greater in keeping a maximum bound.
If I were to entertain reintroducing a maximum bound I would say: It needs to be violently noisy. It needs to raise an exception or add 100 log lines of warning or something when it's not being loaded. I would also say we need a way to disable the check and force loading the railtie, likely via env var. Even then, that's adding extra work for the maintainers, me. And for the users (millions?).
My preference would be to keep it without a max bound until/if it blows up in our face and then revisit whether the cost of that blowup was less expensive/painful than the cost to mitigate the problem. I'm happy to entertain differing opinions and perspectives, however I'm fairly strong in my opinion to not add this check back in.

I am glad the gem has been verified to work with Rails 7 and I too hope this gem will continue to run unverified without such a safety net in the future because of the reliability of your dependencies.

It’s not a bad idea. Sorry to come across as harsh. It’s just the realities
and trade offs make it very costly in practice (in my experience). Thanks
for raising the PR.
On Wednesday, June 8, 2022, Erik Ekberg (Good Dog) @.***>
wrote:

I am glad the gem has been verified to work with Rails 7 and I too hope
this gem will continue to run unverified without such a safety net in the
future because of the reliability of your dependencies.
—
Reply to this email directly, view it on GitHub
https://github.com/zombocom/rack-timeout/pull/187#issuecomment-1150506208,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAOSYELHXXS3ZW7ZQULY6LVOESTPANCNFSM5YHHUA5Q
.
You are receiving this because you commented.Message ID:
@.***>

--
Richard Schneeman
https://www.schneems.com
he/him


Update to node 20 and enviroment files

Would it be possible to update this workflow so that it still works, given deprecations of some of the actions used?

Just to clarify I think you're talking about actions such as add-path?
Error: The `add-path` command is disabled.

Yeah it would be nice to update this as the build is currently failing as is.


(suggestion) feat: withComponent API

Implemented withComponent() API

Emotion docs: https://emotion.sh/docs/styled#change-the-rendered-tag-using-withcomponent
styled-comopnents docs: https://styled-components.com/docs/api#withcomponent

styled-components says it's going to be deprecated, but it's still worth it. It's easier to understand than as prop, and TypeScript typing is more stable and fast.
Uses can reuse styles while simultaneously restricting bindings from being dynamically changed at runtime.
It is a useful tool for defining components for the same styles and adds only 70 characters of code based on minified results. (even better result if it reuses code with the proxy below)
const Icon = styled('svg', {
  width: '24px',
  height: '24px',
});

const FacebookIcon = Icon.withComponent(FacebookSvg);
const TwitterIcon = Icon.withComponent(TwitterSvg);

<FacebookIcon />
<TwitterIcon />
{/* vs */}
<Icon as={FacebookSvg} />
<Icon as={TwitterSvg} />

const Button = styled('button', {
});
const ButtonLink = Button.withComponent(Link);

<ButtonLink />
{/* vs */}
<Button as={Link}/>

@cometkim thanks so much for taking the time to suggest this
One of Stitches goals is to keep the API surface as thin as possible.
We spent along time discussing whether between the as prop and withComponent already, and we've decided to stick with the as prop.
Main reason being is that the majority of people preferred to see the rendering element inline with the context.
In any case, we already have a few ways of achieve this:
const Button = styled('button', {})

// 1.
const ButtonLink = styled(Button, {})
ButtonLink.defaultProps = { as: 'a' }

// 2.
const ButtonLink = props => <Button as="a" {...props} />

// 3.
<Button as="a" />

Until we reach stable v1 I'd like to refrain from introducing new APIs, unless totally necessary.

TypeScript typing is more stable and fast.

I don't know much about this, but this could be a legit reason to introduce it. If we can run some benchmarks we can add this under consideration.
But, we can't drop the as prop, that is the best developer experience for majority of users.
Cheers!

As props in many cases fail inference and the remaining props are extremely slow to compute.
for example in stitches-site:

If we can replace the tag without using the as prop, We can avoid of inferring the rest of the prop from as tag because the inference ends at the as?: never.

@cometkim we've these typing improvements, but not released them yet.
This codesandbox should be using that already: https://codesandbox.io/s/stitches-ci-nextjs-ufdek?file=/pages/index.tsx

// 1.
const ButtonLink = styled(Button, {})
ButtonLink.defaultProps = { as: 'a' }

This doesn't match the use case.
const TwitterIcon = styled(Icon, {})
TwitterIcon.defaultProps = { as: TwitterSvg };

const FacebookIcon = styled(Icon, {})
TwitterIcon.defaultProps = { as: FacebookSvg };

And corrected example is a little verbose.
// 2.
const ButtonLink = props => <Button as="a" {...props} />

// 3.
<Button as="a" />

And this example is still using the as prop I wanna avoid using.
There is an assumption that withComponent will not change the style, so we can skip expensive calculations when copying via some internal flags.
And unlike the as prop, it's already efficient because it's mostly done outside of render.

@peduarte Hmm, I am wondering we already have a way to avoid cloning of internal instance on rerendering when using the as prop static.

defaultProps is being deprecated (https://github.com/facebook/react/pull/16210) so, seems we should try to come up with a first-class approach to this whatever it may be.

Not sure whether making TS work with these is possible, but here are some ideas for a defaultProps replacement:
1.
const Button = styled('button', {
  variants: {
    color: {
      violet: {
        default: true,
        backgroundColor: 'blueviolet',
      },
      gray: {
        backgroundColor: 'gainsboro',
      },
    },
  },
});

render(<Button>Button</Button>);

2
const Button = styled('button', {
  defaultProps: {
    color: 'violet'
  },
  variants: {
    color: {
      violet: {
        backgroundColor: 'blueviolet',
      },
      gray: {
        backgroundColor: 'gainsboro',
      },
    },
  },
});

render(<Button>Button</Button>);

3
const Button = styled('button', {
  variants: {
    color: {
      violet: {
        backgroundColor: 'blueviolet',
      },
      gray: {
        backgroundColor: 'gainsboro',
      },
    },
  },
}, { color: 'violet' }); // third arg for defaultProps

render(<Button>Button</Button>);

As a user, I'd prefer the last one. Would be also ideal for composition:
const ButtonLink = styled(Button, {}, { color: 'gainsboro', as: Link })

Also, I think the following is nicer than withComponents:
const CardLink = (props) => <Card as="a" {...props} />

This is well inferred as correct type without any annotations:
const CardLink = Card.withComponent(Link);

This is way more verbose and also expensive to infer:
const CardLink = (props: React.ComponentProps<typeof Card>) => <Card as={Link} {...props} />

and inference could fail when the card itself is already polymorphic.

As mentioned above, I made some evaluations skipped when cloning with withComponent. This is safe as it only changes only the element and reuses the style.

@cometkim thanks for all this. much appreciated. I've opened up a discussion which is somewhat related to this: https://github.com/modulz/stitches/discussions/242

@cometkim we're doing a bunch of refactoring and will consider this. But this PR won't work with our new codebase. Thanks so much <3


Prodist PR

Pull Request Checklist
Go through the check boxes given below and make sure you mark the relevant ones.
To check put x inside [ ] eg. [x] Extension
Is your project an

[x] Extension
[ ] Application

Given below are the mandatory requirements we expect from your project. Your Pull Request will be reviewed only if all the minimum requirements relevant to your project are satisfied.

[x] Added readme.md to my project folder with relevant information.
[x]  I have provided the demo video link (showing the functionality in action) or the public deployment link of my extension of application within the readme.md (if Applicable).
[x] I have explained the process in a readable manner within readme.md.

Terms and Conditions
Plagiarism check from Team Crio will be solid and if your code is found to be plagiarized, the team has every right to reject your Pull Request and take necessary actions.

[x] I can assure you that this is my own contribution and I did not involve in any kind of plagiarism activities.

Buckle up and wait till you recieve communication from the review team. Keep a tab on this pull request page for comments on your project. Any necessary suggestions will also be provide here. All the best :)
Once your PR get's merged, take some time ⏲, celebrate 🥳 and share it with the community on slack.

Hey @kichloo nice work👏
But there are many site blockers available, and you have hardcoded websites that can be blocked like Quora, Facebook, Instagram, and Twitter. Can you add extra features that make it more productive?

Still, there are tools that do that for us? can you come up with something not there in those extensions?

Hi @kichloo!
great project 👍 but ,

I tried to test it, but it cannot locate the manifest file and there is no src file!
Even after trying every single directory inside your project, the problem hasn't been solved!
It would be great if a user could select which sites to block instead of blocking every single one of them!

By src, I was referring to the source file(Extension file). Pl select that and then let me know it works or not. And can the other people see the extension?

Regarding the other functionality, I would have to research on that because I am new to this domain

Hi @kichloo!
great project +1 but ,

I tried to test it, but it cannot locate the manifest file and there is no src file!
Even after trying every single directory inside your project, the problem hasn't been solved!
It would be great if a user could select which sites to block instead of blocking every single one of them!

By src, I was referring to the source file(Extension file). Pl select that and then let me know it works or not. And can the other people see the extension?

@kichloo
I attempted to open the extension files at first, but that didn't unload, so I had to look at other folders in the project

@kichloo
I attempted to open the extension files at first, but that didn't unload, so I had to look at other folders in the project
It's working fine in my system, don't know what's the problem in this case

It's working fine in my system, don't know what's the problem in this case

had you used .gitnore type while uploading the files ?

had you used .gitnore type while uploading the files ?

I had used Github for making the PR (did not use Git) and had uploaded the files in that case

had you used .gitnore type while uploading the files ?

I had used Github for making the PR (did not use Git) and had uploaded the files in that case

No problem you work on the requested changes we will let you know if this problem persists!

No problem you work on the requested changes we will let you know if this problem persists!

Yeah, it will take some time and I would try to extend the functionality

When I tried the extension, Twitter behaves differently Instead of blocking the page. So, Check this one also!

@SulthanNK Yes, I had encountered that problem with Twitter many times! The system needs to be restarted in case of Twitter, just in case of Twitter only though!

I have added the extended functionality of timer in the blocker, as suggested by Archit and have added the screenshots and the updated code also.

@kichloo The timer is set automatically right? Can we have as an user provided input so that that restriction timer can be set by themselves?

@kichloo The timer is set automatically right? Can we have as an user provided input so that that restriction timer can be set by themselves?

Yes, the user can set the time by himself also by changing the start and end

I have added the functionality and updated README.md

Hey @kichloo I tried your extension and as soon as I loaded the extension, it asked me for starting and ending time, I really don't get it, and then I looked for video and readme and there also it was not mentioned.

Update the video and readme regarding starting and ending time
In my case only site it blocked is Twitter that too when I accessed Twitter by searching twitter.com but when I used the shortcut or bookmark to open twitter then the extension is not able to block it and other socials are not blocked like I opened youtube and quora they were opening.

@Nitesh-thapliyal In the above threads, Archit had asked for adding the functionality of timer, which could block sites from start to end. Those fields refer to that. In addition to that, regarding the blocking, I would advice use you to do a system restart after enabling the extension. And I would update these in README.md

What if I have to update the times?
Can you make the suggested changes before today evening(you have 5-6 hours)

You could simply reload the extension or you could update the time by changing the start and end in background.js. And frankly speaking, it would take a large amount of time for me to research and implement it(beginner level in this domain)

@all-contributors Please add @imnishanth for code, design, infra

@all-contributors Please add @kichloo  for code, design, infra


TimeoutError: Could not get a message from the queue after 600 attempts

Hi, I've checked all previous issues related to this; I've tested the below steps from ai2thor works fine, and have set the multiprocessing to False. But I still cannot connect to Unity. I've also tried to turn on and off my VPNs. Could you tell me how to debug this? I'm using Mac Somona 14.4

Traceback (most recent call last):
File "/opt/anaconda3/envs/holodeck/lib/python3.10/site-packages/ai2thor/wsgi_server.py", line 48, in queue_get
res = que.get(block=True, timeout=queue_get_timeout_per_try)
File "/opt/anaconda3/envs/holodeck/lib/python3.10/queue.py", line 179, in get
raise Empty
_queue.Empty
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/Users/Holodeck/connect_to_unity.py", line 32, in
controller = Controller(
File "/opt/anaconda3/envs/holodeck/lib/python3.10/site-packages/ai2thor/controller.py", line 547, in init
self.start(
File "/opt/anaconda3/envs/holodeck/lib/python3.10/site-packages/ai2thor/controller.py", line 1548, in start
self.last_event = self.server.receive(timeout=self.server_start_timeout)
File "/opt/anaconda3/envs/holodeck/lib/python3.10/site-packages/ai2thor/wsgi_server.py", line 281, in receive
return queue_get(
File "/opt/anaconda3/envs/holodeck/lib/python3.10/site-packages/ai2thor/wsgi_server.py", line 62, in queue_get
raise TimeoutError(
TimeoutError: Could not get a message from the queue after 600 attempts

It should has nothing to do with the VPNs. Did you open the Unity and click the play button? Also, have you reinstall some packages by following this?
pip uninstall Werkzeug
pip uninstall Flask
pip install Werkzeug==2.0.1
pip install Flask==2.0.1


CODEOWNERS Update

Test PoC

@OctoSabercat @chschrae can you please give context on why these entries were commented out?


Installation problem

Hi,
I'm struggling to instal the plugin. I can't find find what the "localisation folders" refers to. And unzipping the main file in HDT plugins folder does'nt do anything after relauching HDT as admin.  I found 2 .dll folders and tried to put them there too but it doesn't do anything. Can anyone help ? I've been trying to make this thing work for hours and it's super frustrating not understading this thing.
Thanks <3

if u updated ur heartstone deck tracker go to this urlhttps://github.com/HearthSim/Hearthstone-Deck-Tracker/releases dowland https://hearthstone.deck.tracker-v1.22.10.zip/ make suredelete old  heartstone deck tracker, after u open deck tracker  go to options-tracker-plugins click then click plugins folder button  put the dll file there and  make sure from tracker settings close check for uptades.

is there any "tutorial" to build the source code ?  google search are very generalist about it, not really helping when it come to do that with files from here, sorry for the noob question


[THREESCALE-2236] Add methods option on Keycloak policy.

This commits add the methods option on the keycloack policy. That
allow users to define a new policy from any jwt claim, resource and
method.
To be backwards compatible 'ANY' method is in place, and if methods are
not defined this global method will be used and all will work as normal.
Example policy:
"policy_chain": [
  {
    "name": "apicast.policy.keycloak_role_check",
    "configuration": {
      "scopes": [
        {
          "realm_roles": [ { "name": "director" } ],
          "resource": "/confidential",
          "methods": ["POST"]
        }
      ],
      "type": "blacklist"
    }
  },
  { "name": "apicast.policy.apicast" }
]

Signed-off-by: Eloy Coto<EMAIL_ADDRESS>

Good job @eloycoto :+1:
I think that extracting a Scope module might simplify some code and also the tests, but there's no need to do that now. We can evaluate that in the future if we need to add more functionality to this policy.
I think the PR could be merged after  #1041

Code rebased with master branch, should be ready to merge.


Obscure error on TextResponse with binary content-type

If response is binary according to it's content-type, but can be decoded using some encoding, it becomes TextResponse in scrapy. But _change_response_class in the splash middleware looks at the content type, so if it's binary, but response was a TextResponse, the following error occurs:
In [1]: response.body
Out[1]: b'\xb8\xfe\xff'

In [2]: response
Out[2]: <200 http://<IP_ADDRESS>:8050/execute>

In [3]: type(response)
Out[3]: scrapy.http.response.text.TextResponse

In [4]: response.headers
Out[4]:
{b'Content-Type': b'application/pdf',
 b'Date': b'Thu, 09 Mar 2017 10:02:21 GMT',
 b'Server': b'TwistedWeb/16.1.1'}

In [5]: responsetypes.from_args(headers=response.headers)
Out[5]: scrapy_splash.response.SplashResponse

In [6]: respcls = responsetypes.from_args(headers=response.headers)

In [7]: response.replace(cls=respcls, request=request)
---------------------------------------------------------------------------
_DefGen_Return                            Traceback (most recent call last)
/Users/kostia/shub/memex/undercrawler/venv/lib/python3.5/site-packages/twisted/internet/defer.py in _inlineCallbacks(result, g, deferred)
   1298             else:
-> 1299                 result = g.send(result)
   1300         except StopIteration as e:

/Users/kostia/shub/scrapy/scrapy/core/downloader/middleware.py in process_request(request)
     42                     defer.returnValue(response)
---> 43             defer.returnValue((yield download_func(request=request,spider=spider)))
     44

/Users/kostia/shub/memex/undercrawler/venv/lib/python3.5/site-packages/twisted/internet/defer.py in returnValue(val)
   1275     """
-> 1276     raise _DefGen_Return(val)
   1277

_DefGen_Return: <200 http://<IP_ADDRESS>:8050/execute>

During handling of the above exception, another exception occurred:

TypeError                                 Traceback (most recent call last)
/Users/kostia/shub/scrapy-splash/scrapy_splash/middleware.py in <module>()
----> 1 response.replace(cls=respcls, request=request)

/Users/kostia/shub/scrapy/scrapy/http/response/text.py in replace(self, *args, **kwargs)
     52     def replace(self, *args, **kwargs):
     53         kwargs.setdefault('encoding', self.encoding)
---> 54         return Response.replace(self, *args, **kwargs)
     55
     56     @property

/Users/kostia/shub/scrapy/scrapy/http/response/__init__.py in replace(self, *args, **kwargs)
     79             kwargs.setdefault(x, getattr(self, x))
     80         cls = kwargs.pop('cls', self.__class__)
---> 81         return cls(*args, **kwargs)
     82
     83     def urljoin(self, url):

/Users/kostia/shub/scrapy-splash/scrapy_splash/response.py in __init__(self, url, *args, **kwargs)
     31                 self.real_url = url
     32                 url = _url
---> 33         super(_SplashResponseMixin, self).__init__(url, *args, **kwargs)
     34
     35     def replace(self, *args, **kwargs):

TypeError: __init__() got an unexpected keyword argument 'encoding'

In [8]: response.encoding
Out[8]: 'cp1252'

I'm not sure what would be the best fix in this case: making sure SplashTextResponse is used if original response is TextResponse?

I'm also not sure about the fix, but your proposed solution sounds ok.

I was waiting on this pull request in hopes it would fix my issue. Please see my stackoverflow post. http://stackoverflow.com/questions/43090352/proxy-servers-with-scrapy-splash  At least the error I'm getting is different :) You'd be my savior if you could tell me what I'm doing wrong.

One known issue from http://stackoverflow.com/questions/43090352/proxy-servers-with-scrapy-splash
I've checked, and yeah, the error is gone when I turn off Crawlera. It's so sad it doesn't work well with Crawlera.


Fix config import.

I included a fix on "connect".

Sorry for the noise, I was not on the right branch.


FLW-1106 Calculate completion time for targetEra

Codecov Report

Merging #334 (9ba2f02) into develop (7920849) will increase coverage by 3.24%.
The diff coverage is 39.83%.


Add Game Networking

https://github.com/MFatihMAR/Awesome-Game-Networking
A curated list of Awesome Game Networking resources which is continuously being updated!
Includes articles, talks, tutorials, libraries, projects mostly in C/C++, C#, Java using Unity and UE4 game engines.
By submitting this pull request I confirm I've read and complied with the below requirements.
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

I have read and understood the contribution guidelines and the instructions for creating a list.
This pull request has a descriptive title.For example, Add Name of List, not Update readme.md or Add awesome list.
The entry in the Awesome list should:

Include a short description about the project/theme of the list. It should not describe the list itself.Example: - [Fish](…) - User-friendly shell., not - [Fish](…) - Resources for Fish..
Be added at the bottom of the appropriate category.

The list I'm submitting complies with these requirements:

Has been around for at least 30 days.That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
It's the result of hard work and the best I could possibly produce.
Non-generated Markdown file in a GitHub repo.
Includes a succinct description of the project/theme at the top of the readme. (Example)
The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
Not a duplicate.
Only has awesome items. Awesome lists are curations of the best, not everything.
Includes a project logo/illustration whenever possible.

Either fullwidth or placed at the top-right of the readme. (Example)
The image should link to the project website or any relevant website.
The image should be high-DPI. Set it to maximum half the width of the original image.

Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
Includes the Awesome badge.

Should be placed on the right side of the readme heading.
Should link back to this list.

Has a Table of Contents section.

Should be named Contents, not Table of Contents.
Should be the first section in the list.
Should only have one level of sub-lists, preferably none.

Has an appropriate license.

That means something like CC0, not a code licence like MIT, BSD, Apache, etc.
WTFPL and Unlicense are not acceptable licenses.
If you use a license badge, it should be SVG, not PNG.

Has contribution guidelines.

The file should be named contributing.md. Casing is up to you.

Has consistent formatting and proper spelling/grammar.

The link and description are separated by a dash. Example: - [AVA](…) - JavaScript test runner.
The description starts with an uppercase character and ends with a period.
Drop all the A / An prefixes in the descriptions.
Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

Doesn't include a Travis badge.You can still use Travis for list linting, but the badge has no value in the readme.

Go to the top and read it again.

Thanks for making an Awesome list! 🙌
It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

Hey @sindresorhus, thanks for the review.
However only thing I can see is Include a short description about the project/theme of the list. It should not describe the list itself.
Can you point me out a few things that are problematic please?

Also going to update big/full-width logo with small right-aligned icon-like logo soon.

I also updated the logo, @sindresorhus I think it's ready to go now!
Please let me know if there is any other problem.

Thanks for noticing me about the description problem @sindresorhus!
Updated description again, now with concept of the list -not list description itself.

Any thoughts on that? ☹ @sindresorhus

@legodude17 There is no "relevant website" for game networking topic. It's linking back to repo right now (which is fine). Also I had review from @sindresorhus already, just waiting for him to find some time to look into this PR again.

Includes a succinct description of the project/theme at the top of the readme. (Example)

This is not done. Should be a short description of what game networking is.

Updated, any chance? ☹ @sindresorhus


refactor(rust): extract the output of request results from the rpc code

This PR extracts the printing of responses from an RPC code itself and refactors the Rpc API.
Printing responses
The ability to print responses directly from the Rpc struct has been removed and pushed to the CommandOpts struct (via the OutputFormat). This opens the possibility to later refactor the code so that the terminal can be used instead of a straight println to the console.
Rpc
The API of the Rpc struct is modified to avoid 2 part calls where we first send the request, then parse the response:

tell means that you are making a request and don't care about decoding a response
tell_status is for the rare case where you don't want to decode the response body but you still want to know if the request succeeded or not
ask means that you want to decode the response. In that case you need to mention the expected type so that the response body is deserialized to the right value. If the value cannot be produced, whether because the response is not ok, or  because there is a more serious error, like a decoding error, we return an Err
ask_or_fail is for the case when we are also interested to surface a failure if the request returns a response with a non-OK code. In that case a special Reply data type has been defined

Note that the support of a timing out the call has been made orthogonal to those 3 methods, this is now a property of the Rpc client itself.
Further directions
There will be further PRs to refactor the RpcBuilder/Rpc code with the intent of:

removing the "Embedded" mode
being able to create a Rpc client directly from the ockam_api crate

Love what the ask and tell functions are doing!
But wish they had more descriptive name 🤔

But wish they had more descriptive name 🤔

I thought they would speak to your Elixir / Erlang heart where tell means "send a message to an actor and don't care about the response", whereas ask is "send a message and wait for a response".

@mrinalwadhwa I attempted something which unfortunately doesn't work. I thought I could replace both ask and tell with call (Remote Procedure "Call") and have compiler happily infer a Unit type for the decoded value when we don't care.
The program compiles but unfortunately the decoding fails at runtime because when no response body exists, the minicbor decoder cannot decode this to ().
I tried to work around this limitation but I don't know if the type system would allow to special case some behaviour just for the Unit type. And even if that was the case, I'm not sure if it is worth the additional complexity.


http/2 graceful drain support

The connection manager goes into a drain sequence where we issue a shutdown
notice, wait 5s, then do a full shutdown.

@lyft/network-team


Creating a Flutter Project won't allow you to select your own directory

Reproduce:
Step 1: Create a project

Step 2: The path chooser dialog shows up

Step 3: Try changing the path, it's not possible

Atom Version:

Flutter Version


Add base locales before providing dialects

While trying to use the locales d3 provides, I noticed that there are quite some dialects (en_US, en_GB, pt_BR...) but not the base locales. I.e. it is missing en, fr, de, pt, es locales that allow you to show something even if the specific dialect is not yet localized.
Can you please change this? In my view, dialects should be the second step after a base locale has been provided, to allow to show something at least understandable to a native speaker, even if his specific locale is not yet supported.
This request comes from the fact that almost all localization frameworks are able to fall back to a more generic locale if the specifically requested locale is not available, but are unable to use a specific locale as fallback if a another specific locale is asked for.
I did provide some pull requests that add german and french base locales.
Is there a reason you would not want to provide base locales (first)?
Would you take my pull requests for more languages?

I don’t want to be responsible for picking which country (or dialect) is considered the base language. For example, it’s not obvious to me that “en” should be an alias for “en-US”. This imposes a hierarchy on top of the locale definitions that, while common in other software, is not a fundamental truth of localization.
Related, as of d3-format 0.4 and d3-time-format 0.2, the locales are exposed as symbols rather than strings (e.g., localeEnUs instead of localeFormat("en-US")). See d3/d3-shape#23 for a discussion regarding strings versus symbols, but in addition to being the natural representation, symbols enable Rollup to pull in locales selectively in custom builds.


Fix the state of the correct subclass in the service order factory

This needs the API PR that I just closed (https://github.com/ManageIQ/manageiq-api/pull/771) to work but I think it's a better fix than Brandon's factory change that just got merged because Brandon's doesn't address the state issue and even if he did change it to do so it changes the behavior of that factory which I don't think was right.
the api says the default state for a service order is 'cart' so we shouldn't be using the factory with the default set to ordered for the API tests
this and the API would bring our total failing tests down to five

@bdunne sorry but I don't think your change was right


Bind task object itself before calling task()

Binds the 'task' object itself to task() function so that the 'task' object can use inner variables, etc.
e.g.
class SampleTask {
    private n: number
    constructor(n: number) { this.n = n }
    title = "SampleTask"
    task(ctx: any, task: any) { task.skip(`${this.n}`) }
}

Without the bind, the variable n is references else where.

Codecov Report

Merging #84 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   96.29%   96.29%
=======================================
  Files           7        7
  Lines         189      189
=======================================
  Hits          182      182
  Misses          7        7

Impacted Files
Coverage Δ

lib/task.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d28fb95...b71890f. Read the comment docs.

Thanks for your PR! Could you write an extra test to verify that this works?


Disable dates using a function instead of an array

By analyzing the blame information on this pull request, we identified @ndrisso, @asharbitz and @bierdok to be potential reviewers


(PUP-7603) Make StringFormatter use single quotes more diligently

Prior to this commit, the StringFormatter would use double quotes for
all strings that contained control-, non-ascii-, dollar, or backslash
characters. Double quoting is however only needed for strings that
contain control- or non-ascii characters.
This commit changes how the detection is made so that single quotes are
used whenever possible.

Could you update the scheduled_task and user managing home acceptance tests to expect single or double quotes?

@joshcooper I tested all acceptance tests under tests/resource/user and tests/resource/scheduled_task. They pass without modification so I guess they all are resilient against quote changes now. Perhaps you have other tests in mind?

They pass without modification so I guess they all are resilient against quote changes now.

I had to modify the tests to accept both single or double quotes (see https://github.com/puppetlabs/puppet/commit/fabc26d59c15b182d6c1683d3cfbb374e2435e8f
https://github.com/puppetlabs/puppet/commit/64ea8da09352a70df2de54a96f11617968999872) , and escaped backslashes, but now that the output is consistently single quotes with single backslashes, I'm thinking the tests should be reverted to how they were before (requiring single quotes with single backslashes)?

Ah, yes, that makes sense. I'll revert them to single quotes.

CLA signed by all contributors.

I think the appveyor issues are https://github.com/appveyor/ci/issues/1579


Converting fine-tuned whisper model for faster-whisper, using safetensors

How can I convert https://huggingface.co/primeline/whisper-large-v3-german to be used with faster-whisper?
Also, can faster-whisper use safetensors and can I convert the above to it?
EDIT: When using
ct2-transformers-converter --model primeline/whisper-large-v3-german --output_dir whisper-large-v3-german --copy_files tokenizer.json --quantization float16
I get
ValueError: Non-consecutive added token '<|0.02|>' found. Should have index 50365 but has index 50366 in saved vocabulary
After upgrading ctranslate and transformers it works.
I got it to work with model.feature_extractor.mel_filters = model.feature_extractor.get_mel_filters(model.feature_extractor.sampling_rate, model.feature_extractor.n_fft, n_mels=128)
Yet the model stops after about 20 words, whereas the large-v2 does the whole file. No error message, but a freezing tqdm as step 1 to skip to the end that I wrapped around for segment in segments:

@ErfolgreichCharismatisch did you managed to translate large-v3? how?

I have the same issue. Iarge-v3 works as expected but whisper-large-v3-german stops the output after processing the first part. If you log it you can see that it processes the orther parts, too but it does not output the text:
'''
#first convert model like this

ct2-transformers-converter --force --model primeline/whisper-large-v3-german --output_dir C:\opt\whisper-large-v3-german --copy_files special_tokens_map.json tokenizer_config.json preprocessor_config.json vocab.json added_tokens.json --quantization float16
'''

from faster_whisper import WhisperModel
import os
import logging

logging.basicConfig()
logging.getLogger("faster_whisper").setLevel(logging.DEBUG)

model_size = "C:\opt\whisper-large-v3-german"
#model_size = "large-v3"

# Run on GPU with FP16
model = WhisperModel(model_size, device="cuda", compute_type="float16")

# or run on GPU with INT8
# model = WhisperModel(model_size, device="cuda", compute_type="int8_float16")
# or run on CPU with INT8
# model = WhisperModel(model_size, device="cpu", compute_type="int8")

segments, info = model.transcribe(os.path.dirname(__file__) + "/audio.mp3", beam_size=5, word_timestamps=False)

print("Detected language '%s' with probability %f" % (info.language, info.language_probability))

for segment in segments:
    print("[%.2fs -> %.2fs] %s" % (segment.start, segment.end, segment.text))

Try:
import ctranslate2
from ctranslate2.converters import TransformersConverter

model_name_or_path = "primeline/whisper-large-v3-german "
output_dir = "whisper-large-v3-german --copy_files"

converter = TransformersConverter(model_name_or_path)
converter.convert(output_dir, quantization="float16", force=True)

small corrections:
import ctranslate2
from ctranslate2.converters import TransformersConverter

model_name_or_path = "primeline/whisper-large-v3-german"
output_dir = "whisper-large-v3-german"

converter = TransformersConverter(model_name_or_path)
converter.convert(output_dir, quantization="float16", force=True)

but no difference in result

Any news on this? Ran into the same issue trying to convert this particular model to implement it in WhisperX

Would not be enough converting safetensors to bin?
from safetensors.torch import load_file
import torch
lora_model_path = 'adapter_model.safetensors'
bin_model_path = 'pytorch_model.bin'

torch.save(load_file(lora_model_path), bin_model_path)

source: https://huggingface.co/docs/safetensors/api/torch

@ErfolgreichCharismatisch I'm going to do something similar with Czech fine-tuned model.
I notice your German model is in bfloat16, while other whisper models are FP16 (float16). Could not this be your issue? From what I understand the convertor should work with both safetensors and bin.
Try this example to load model in bfloat16 and then quantize to float16:
import ctranslate2
from transformers import WhisperForConditionalGeneration
import torch

# Ensure PyTorch can handle bfloat16
if not torch.cuda.is_available() or not torch.cuda.is_bf16_supported():
    raise RuntimeError("bfloat16 requires CUDA GPU with Ampere architecture or later")

# Load your bfloat16 Whisper model
whisper_model = WhisperForConditionalGeneration.from_pretrained(
    "path/to/your/bfloat16/model",
    torch_dtype=torch.bfloat16
)

# Convert to CTranslate2 format, quantizing to float16
converter = ctranslate2.converters.TransformersConverter(whisper_model)
converter.convert(
    "path/to/save/ctranslate2_model",
    quantization="float16",
    force=True
)

@ErfolgreichCharismatisch Your issue is that German model is in bfloat16. The support was added here: https://github.com/OpenNMT/CTranslate2/issues/1121
Instead of float16 quantization use bfloat16 or int8_bfloat16
Models that are trained with bfloat16 can have numerical issues when run with float16

@ErfolgreichCharismatisch  by the way someone already converted german:
https://huggingface.co/GalaktischeGurke/primeline-whisper-large-v3-german-ct2
https://huggingface.co/flozi00/whisper-large-v3-german-ct2

@ErfolgreichCharismatisch by the way someone already converted german: https://huggingface.co/GalaktischeGurke/primeline-whisper-large-v3-german-ct2 https://huggingface.co/flozi00/whisper-large-v3-german-ct2

They all suffer from premature ending. I used both with
model = WhisperModel(model_name_or_path, device="cuda", compute_type="bfloat16")
and
model = WhisperModel(model_name_or_path, device="cuda", compute_type="int8_bfloat16")
only
model_name_or_path = "large-v3"
model = WhisperModel(model_name_or_path, device="cuda", compute_type="float16")

works.

@ErfolgreichCharismatisch Yes, I am experimenting with whisper-large-v3-vi and have same problem. I tried to keep it float32 as original. Quantize to float16 and also copy the missing tokenizer.json before converting.
Nothing helps and it crashes on some exception during inference :-/
I try to debug it, it only writes: "list index out of range" in the console. (that will be from my boilerplate code around faster-whisper).

@trungkienbkhn Anh ơi, I want to use vietnamese with higher precision, would you know why we cannot convert this? I see you are one of maintainers. Cảm ơn!!!

I guess the converter is just faulty. Did you try the supplied source code for some models by the model creators?

from transformers import WhisperForConditionalGeneration, WhisperTokenizer
from ctranslate2.converters import TransformersConverter

model_name_or_path = "Your model name or path here"
output_dir = "where do you want to store your model in memory"

#Manually download your model from huggingface
model = WhisperForConditionalGeneration.from_pretrained(model_name_or_path, cache_dir=output_dir)
del model.config.max_length
del model.config.begin_suppress_tokens

converter = TransformersConverter(output_dir)
converter.convert(output_dir, quantization="float32", force=True)

Once the model is saved into the output directory you desire, add the tokenizer, special_tokens file and preprocessor_config.json files into the stored location which you will find in the base model’s location which in my case was https://huggingface.co/openai/whisper-large-v3, before integrating it with the whisperX pipeline.

Doesn't work either.

@ErfolgreichCharismatisch What do you mean? The code you provided does not convert anything and faster-whisper-large-v3-turbo-ct2 is already available here https://huggingface.co/deepdml/faster-whisper-large-v3-turbo-ct2 !
I cloned latest /SYSTRAN/faster-whisper repository already and still encounter the issues. Can you please elaborate more? Thanks.


language support

Hi,
Thanks for the amazing work. Could you please tell me how I can extract instructions and responses in a specific language?

Hi,
Thanks for the question. Technically there are two ways. One way is to extract as much data as possible, and apply a language filter, like what we did in this Chinese dataset.
Another possible solution is to apply a logit processor at the beginning of the generator, which punishes all tokens that do not belong to a specific language. However, it is quite hard for some low-resource languages as they might share similar tokens. We plan to add a logit processor for low-resource language generation but it may take some time to figure out the most elegant solution. Once we have the solution, I will ping this issue and let you know!
Here are some cases of using Magpie to extract Japanese and Korean dataset, which might be of your interest.
Hope this response helps! 😀

Hi,
It seems that there is another simple way to generate a specific language! You can refer to this gist for details. Basically, they just append 'spanish:' at the end of the pre-query template.

@fly-dust thx for the great work!
Do you think that adding a system message could help with generating data in a specific language or this would deteriorate the results?

For anyone seeking information on this topic, I have written a simple article on it:
🇮🇹🇯🇵🇧🇷 Generating multilingual instruction datasets with Magpie 🐦⬛

Hi @anakin87, that's really nice work! Sorry for the delay in responding, as I was working on other projects...
BTW, we also found that whether system prompts can control the language effectively depends on the model's data distribution. For example, we found that for multilingual tasks, the Qwen family seems to perform better. We hypothesize this is because they used more multilingual data for instruction tuning.


Make client-side span tagging customisable

I need to be able to add custom tags to the spans created on the client
side of my thrift calls. Currently this is not possible since the tags
are added in a static method that cannot be extended. Add an extensible
class, ClientSpanDecorator, which can be set on a SpanProtocol which is
used to decorate the spans. The default implementation of
ClientSpanDecorator delegates to the static methods of SpanDecorator to
ensure backwards compatibility. The ClientSpanDecorator can be extended
by consumers of the library when creating SpanProtocols to customise how
the spans are tagged.

@Froodulous please also update README

thanks @Froodulous

Thanks for the reviews.


Adds support for select instructions to pyqir-parser

LGTM, great job!
Tiny typo on test_parser_pyhthonic_select() (extra h after py).
Note: LLVM select allows for vectors of conditions and values, which llvm_ir does not.


chore(cli): add spa/generate warning

Resolves https://github.com/nuxt/nuxt.js/issues/4036

Codecov Report

Merging #4165 into dev will decrease coverage by 0.1%.
The diff coverage is 0%.

@@           Coverage Diff            @@
##             dev   #4165      +/-   ##
========================================
- Coverage   81.8%   81.7%   -0.11%
========================================
  Files         29      29
  Lines       1561    1563       +2
  Branches     409     410       +1
========================================
  Hits        1277    1277
- Misses       224     225       +1
- Partials      60      61       +1

Impacted Files
Coverage Δ

packages/cli/src/commands/generate.js
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5530ad...9382b30. Read the comment docs.

Closed because of #4036 has been closed as well (misunderstanding)


Add .gitignore for new projects

Added git ignore, to ignore the node_modules and dist folder for new projects
What are you trying to accomplish with this PR?
This adds a gitignore file by default so that node_modules and dist don't get commited to sc by accident
#126

Thanks @adrhumphreys for the PR - just a small comment. @NathanPJF I've also assigned you for some 👀.

Awesome, @chrisberthe I've add the trailing slashes

Hey @adrhumphreys 👋 - have you had a chance to test this out? The .gitignore file you've added won't do anything because the dist/ and node_modules/ don't live inside the src/ folder, they live inside the root folder. We have a .gitignore file for the root directory that ignores both node_modules/ and dist/.
Is the existing setup not working for you? Care to elaborate as to how you ended up with dist/ and node_modules/ in the src/ folder?

Looks like the issue is that .gitignore is not being copied over when we create a new theme.

As @t-kelly mentioned, this doesn't solve the issue of ignoring the node_modules and dist folder - the .gitignore should be placed inside of the root theme directory, not src.
Closing this PR for now, but we'll definitely revisit this soon - maybe we could initialize this with a flag upon running slate theme and/or slate migrate... but don't necessarily want to clutter up options for each of those commands either. We'll 🤔.


Share insights on handling layout reading order

I am curious to understand your insights into the algorithm for creating the final markdown order based on layout predictions. Are you planning to add some ML model for this in future? How complex document layouts can be handled? It seems there is very limited research in this domain with open use license.

@mllife Yes, it is there but a bit hidden in a cumbersome way. We are currently trying to first re-visit the types in this package (too much tied to legacy) and then clean up this topic.
stay tuned!

@mllife This is now resolved in v2. A good function to look at is here: https://github.com/DS4SD/docling-core/blob/main/docling_core/types/doc/document.py#L1427


Not possible to build examples anymore with zig 0.11.0-dev.2652+

I am just getting started with Zig, and the first version I got is  0.11.0-dev.2652. With it, it's not possible to build your wasm examples anymore:
lib.setOutputDir(webCachedir); https://github.com/ryupold/examples-raylib.zig/blob/main/build.zig#L123
error: no field or member function named 'setOutputDir' in 'Build.CompileStep'

Also lib.install doesn't work anymore, but this one I managed to changed to b.installArtifact(lib). But still, due to not being able to setOutputDir, it's not possible to build for web anymore.
I tried installing Zig 0.10, but then there's even more incompatibilities. Which version of 0.11.* are you targeting currently?
Thanks!

It was removed last week: https://github.com/ziglang/zig/commit/5a8b1bde5b3ce2628a8e490c3cef9fcc95f94ab5

Hey, thanks for testing with the newest version. My last update was with the 0.11 version from 21th March and until now I did not update. I see that this problem is also in the build.zig of the raylib repository as they are also using setOutDir. But where can I now set the output directory?

I'm new to the zig ecosystem too.
It seems that now we have to use b.installDirectory(.{ .source_dir = "", .install_dir = .{ .custom = webCachedir }, .install_subdir = webCachedir });
But then how to mimic what was a simple single directory with "setOutputDir"? It seems complicated now.

I couldn't figure out how to set the output dir otherwise but with installArtifact as you mentioned in the beginning.
const libraryOutputFolder = "zig-out/lib/";
// this installs the lib (libraylib-zig-examples.a) to the `libraryOutputFolder` folder
b.installArtifact(lib);

then I pass this folder also to the emcc build so it can find the static library.
I liked it better the way it was before but now it works again at least.

Thanks for sharing, I'm learning alongside about the zib builder.


pricing question

I was looking at the docs, in particular at this page. In the price table, there is a mention that the selected region is us-east-1 that the cost includescompute and storage costs. I was wondering, which price are you considering for the compute part: on-demand, spot, etc...
Thanks!

Hello,
The prices displayed are for spot. You can view both on-demand and spot in the calculator tab.
Thanks,
Cyril
On Thu, Oct 24, 2024, at 19:11, Fraccaroli Gianmarco wrote:

I was looking at the docs, in particular at this page https://runs-on.com/pricing/. In the price table, there is a mention that the selected region is us-east-1 that the cost includescompute and storage costs. I was wondering, which price are you considering for the compute part: on-demand, spot, etc...
Thanks!
—
Reply to this email directly, view it on GitHub https://github.com/runs-on/runs-on/issues/154, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAABPYRA3NVRMWGWIZTWLIDZ5ES5ZAVCNFSM6AAAAABQRRV46CVHI2DSMVQWIX3LMV43ASLTON2WKOZSGYYTEMJUHE4DIMI.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Ahhh thanks for totally missed it! Ill close the issue :)


op-amp benchmark prelim

Op-amp benchmark - first draft

cool, thanks. can you please rebase on master?


Cannot get example_branch_operator to perform any executions.

Hi
I have AirFlow version 1.2 set up, with the four example DAGs.  When I try to run example_branch_operator like so
airflow run example_branch_operator follow_branch_a 2015-01-01
or with any other date, then when I refresh the DAGs view in the web-server UI, I see no change in its executions.  The successful executions does not increment, but neither do any of the others.  It's as if nothing happened.
When I run example_python_operator like so
airflow run example_python_operator print_the_context 2015-01-01
then I get a successful execution for that date.  As I re-run it with other dates, the successful executions increment.  Why does the example_branch_operator DAG not exhibit this same behavior?  Thanks

If the dependencies aren't met, the task won't execute and record any state. It will print something about the reason it isn't running in the log file though. Is that the case?

Yes, it is.  I misunderstood. I thought in the checking of dependencies, airflow run ensure that upstream tasks also get run.  Evidently, that is not the case.  It seems that airflow run behaves more like airflow test and less like airflow backfill.  I think what I want to do in order to test a whole DAG, "from soup to nuts" is to use airflow backfill.  I'm curious what the use cases for airflow test and airflow run are.

airflow test: test a single task instance, get the logs printed out as stdout, no dependency checks, status of run doesn't get recorded. Typically you'd be working on a local branch and making sure you tasks work.
airflow run: trigger a single task instance as it would run in production. I has flags to force a run or ignore the dependencies. Note that airflow run is used internally by the scheduler and backfill.


Data labels displaying log value in logarithmic scale instead of actual value

Bug report
Data labels showing log value in a logarithmic scale
Codepen
https://codepen.io/ericpresas/pen/OJVpJLV
Turn datalabels flag to true and see the result
Explanation

What is the behavior you expect?
Actual value of y axis, not log value
What is happening instead?
log value is displayed
What error message are you getting?
no error message

You're correct. I will look into this soon.

@junedchhipa
Any updates on this?


Fix self-closing tags on server (closes #16)

Thanks for your help, looks good!
Can you maybe add a test for this, too?

Sorry, couldn't merge your request because of a major rewrite.
But I fixed the problem with 011b504

Awesome, thank you.


Fixed #31410 -- Added check for fields of UniqueConstraints and CheckConstraint.

https://code.djangoproject.com/ticket/31410

@hramezani Thanks :+1: After reconsideration I think we should limit this check only to UniqueConstraint's, it's not worth to add complex and error prone logic for CheckConstraint's, we can fail of custom expressions etc.

@felixxm, I've just removed the CheckConstraint part. Should I move the release note to 3.2 :thinking: ?

Release notes are not necessary.

@hramezani Thanks :+1: I pushed minor edits and added docs changes.


When Support Unigram?

Not implement Unigram, when support it?

I planned but really no bandwidth atm. Feel free to PR. Thanks.


fix outut typo

Fix your email

I've added the email address to my account, if you'd rather have me to create a new pull request with another email that's fine too :-)


Enum description

Related to #145

show enum names even if property description is defined.
for enum items show their Description attribute

I'm curious, can I see a result?

thanks
@JFDionne sample:


fix: Fluent Icons makes app unable to build in Maui Blazor Android

🐛 Bug Report
When making the changes to csproj requested here the MAUI .NET does not deploy on Android anymore with the error message "cannot open file"

Everything is working fine when deploying the app to windows.
💻 Repro or Code Sample
Create a MAUI .NET App.
Initialize Fluent UI as explained here
add the following to the csproj :
 		<PublishFluentIconAssets>true</PublishFluentIconAssets> 		<FluentIconSizes>10,12,16,20,24,28,32,48</FluentIconSizes> 		<FluentIconVariants>Filled,Regular</FluentIconVariants> 		<PublishFluentEmojiAssets>true</PublishFluentEmojiAssets> 		<FluentEmojiGroups>Activities,Animals_Nature,Flags,Food_Drink,Objects,People_Body,Smileys_Emotion,Symbols,Travel_Places</FluentEmojiGroups> 		<FluentEmojiStyles>Color,Flat,HighContrast</FluentEmojiStyles>
Deploy to android and see app not launching.
🤔 Expected Behavior
The app should launch as it does in windows.
😯 Current Behavior
Build error :

💁 Possible Solution

🔦 Context

🌍 Your Environment

I'm guessing this is caused by the emoji and NOT by the icons. Can you verify that the file causing the issue is called 'piñata' or something like that?

Indeed removing the emokis fixed the issue !


Price Concessions calculations need updating

There have been a couple of changes to the price concessions calculations, which means that we are possibly underestimating the effect on NHS organisations:

From April 2023 price concessions are not subject to a discount deduction.  We have not taken this into account when calculating the price difference between the tariff price (which does have a deduction) and the concession price - but are still using the average National Average Discount Percentage (NADP) from when we implemented the tool.
From April 2024 there is a new discount model (with caveats, see $ below), which (for tariff price) depends on the category of the Drug Tariff the item is in.  See here for details.

Consequently we need to make some changes to the price concessions calculation.  Having discussed with @evansd we agreed that the SQL would be the best place to make amendments.
I've created a draft SQL query below in BigQuery, will need some amendments, but does show that the concept works.
  ncso.date AS date,
  vmpp.bnf_code AS bnf_code,
  tariff.price_pence AS tariff_price,
  CASE
    WHEN ncso.date >='2024-04-01' THEN
      (CASE
        WHEN tariff.tariff_category IN (1,11) THEN
          COALESCE(ncso.price_pence - (tariff.price_pence *0.8), 0)
        WHEN tariff.tariff_category IN (5,6,7,8,10) THEN
          COALESCE(ncso.price_pence - (tariff.price_pence *0.9015), 0)
          ELSE
          COALESCE(ncso.price_pence - (tariff.price_pence *0.95), 0)
        END)
    WHEN ncso.date BETWEEN '2023-04-01' AND '2024-03-01' THEN
      COALESCE(ncso.price_pence - (tariff.price_pence *0.928), 0)
      ELSE
      COALESCE(ncso.price_pence - tariff.price_pence, 0)*.928
      END
      AS price_increase,
#CASE WHEN presentation.quantity_means_pack THEN
# 1
# ELSE
  vmpp.qtyval
# END
  AS quantity_per_pack
FROM
  dmd.ncsoconcession AS ncso
JOIN
  dmd.tariffprice AS tariff
  ON
  ncso.vmpp = tariff.vmpp AND ncso.date = tariff.date
JOIN
  dmd.vmpp AS vmpp
  ON
  vmpp.id=ncso.vmpp
JOIN
  hscic.presentation AS presentation
  ON
  presentation.bnf_code = vmpp.bnf_code
  #WHERE
  #ncso.date >= %(min_date)s AND ncso.date <= %(max_date)s

One further question - now that the NADP has been changed, shall we take the opportunity to add a table with the values from previous years, and use the actual value rather than the value (7.2%) we have used for all years?
$ Technically this is for pharmacy contractors only - dispensing doctors get a different discount rate, but this is probably too complicated to work out, and the differences are likely to be small for estimation purposes.
Also technically there has been a transition period for the new discount method since October 2022, but there has still been a NADP value available.

We also need to consider retrospective top-up payments, although we should add these onto the page somewhere, and refer to them in emails and on the tool.


More DateTimes accessors

I find it bizarre that in Dates the uppercase functions are defined in terms of the lowercase functions, but only for the specific concrete types in Dates.


eliminate errors on churn startup, with some other logging cleanup

Mostly, this eliminates the nasty uncaught exception for every churn connection.
Also, a few other bits and bobs I would have appreciated recently when debugging churn. We have been logging mostly at DEBUG but INFO also has a place.

:+1:

Tiny change: log browser socket, remote endpoint, and mirror address separately. Now everything you would need to verify obufscation with Wireshark is in INFO logs. This was not the case in demo earlier today...


Can we print the landscape picture and share with others ?

Like the title, can we print the landscape picture and share with others in our technology sharing conference for free without any changes ?

Yes, please do so. The static landscape is distributed under the Creative Commons Attribution license, so you're welcome to distribute it as long as you leave the CNCF logo on it.
https://github.com/cncf/landscape#license
We prefer printing it with the cloud native trail map on one side and the landscape on the other. Please be sure to use the PDF to get acceptable resolution for print.
https://github.com/cncf/landscape#formats
I would be curious to hear what event you'll be distributing it at.


Categorical HM integration with Spatial kernel implementations

For example, can we do something like:
def innerProdMatMult(tileA: SRAM2[T], tileB: SRAM2[T], tileC: SRAM2[T]): Void = {
  Foreach(...){...} // fill tileC using inner products
}

def outerProdMatMult(tileA: SRAM2[T], tileB: SRAM2[T], tileC: SRAM2[T]): Void = {
  Foreach(...){...} // fill tileC using outer products
}

Accel{
  ...
  innerProductMatMult(tileA, tileB, tileC) (innerProductMatMult, outerProductMatMult)
  ...
}

This may be problematic with Spatial's staging.  Maybe you can use blackboxes as containers for kernel switching since those won't get dropped.  Maybe there can be a generic BlackBoxUse node and store the possible drop-in replacements as Parameter metadata

To add some more motivation: Aetherling (https://github.com/David-Durst/embeddedHaskellAetherling) has multiple options for the same operation with different performance-resources trade-offs. This feature would allow treating both options as a single operator that can be configured by HM,


Add style to titlebar

I would like the titlebar to have the style applied to it as well. It looks a little bit out of place when using the dark theme and having the white titlebar. I was thinking along the lines of how ModernUI did their titlebar.

Absolutely! This is already on my to-do list right after the .NET Core 3.0 support.

It looks like this issue has been fixed with/after the net core 3.0 addition.

This is the major part of the 1.12 release (.NET Core support was v1.11). It is merged into the master already and available via NuGet as pre-release 1.12.0-preview2.
I did not close this issue because I am still testing if it works fine on different versions of Windows, different screen resolutions and different UI scalings. But it's fine to close it as well. Additionally, it is still missing documentation.
I am optimistic to finish it very soon, though.


feat: always keep date picker calendar popup inside of viewport

FX-4445
Description
This pull request makes DatePicker popper to fit the viewport in the most extreme cases when the screen is small, so overlapping the input is allowed (confirmed with Design Team).
How to test

Temploy
Navigate to https://picasso.toptal.net/FX-NULL-fit-date-picker/?path=/story/overlays-modal--modal and trigger the date picker from the Default case modal on different screen sizes

Screenshots
https://github.com/toptal/picasso/assets/1390758/e5e64eec-0ff8-4e18-b2c6-66eb195207e1
Development checks

[x] Add changeset according to guidelines (if needed)
[x] Read CONTRIBUTING.md and Component API principles
[x] Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
[N/A] Annotate all props in component with documentation
[N/A] Create examples for component
[x] Ensure that deployed demo has expected results and good examples
[x] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[x] Self reviewed
[N/A] Covered with tests (visual tests included)
[ ] ⚠ Revert changes made in Storybook

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

@toptal-bot run package:alpha-release - Release alpha version
@toptal-anvil ping reviewers - Ping FX team for review

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

@toptal-bot run package:alpha-release

@toptal-bot run package:alpha-release

@toptal-bot run package:alpha-release

@toptal-anvil ping reviewers


[NTI] Array prototype methods don't typecheck well due to {length: number} alternative in receiver

The following NewTypeInferenceTest case is broken:
typeCheck(LINE_JOINER.join(
    "function f(/** !Array<number> */ arr) {",
    "  arr.push('asdf');",
    "}"),
    NewTypeInference.NOT_UNIQUE_INSTANTIATION);

The cause is that Array.prototype.push is defined as
/**
 * @param {...T} var_args
 * @return {number}
 * @this {{length: number}|!Array.<T>}
 * @template T
 * @modifies {this}
 */
Array.prototype.push = function(var_args) {};

which ends up as <T> function(this: !Object, ...T), which unifies just fine with function(Array<number>, ...string).  This is a general problem with many Array methods due to the way they accept non-parametrized alternatives.

Perhaps the problem is just that NewTypeInferenceTest is providing its own externs and gets them wrong? In es3.js the method is annotated as @this {IArrayLike<T>}.


quickstart commands for fm/install/test

Add those that ensure people use only vendored copies for fmt/install/test.
That allows developers to get a full Compile-Edit-Run-Cycle using only vendored packages directly from the quickstart.
It took us a day to discover those simple command + argument combinations.

@kardianos Please consider adding it.

thx!


Trouble Getting Activation Bytes

Hello, I'm out of my league trying to follow these instructions, but I believe I'm about 90% of the way there and I just need a little direction.
To set the table, my goal is to obtain my Audible Activation Bytes so that I can convert my .aax audio book files to .m4b while retaining the chapter info.
I installed Brew, FFMPEG, and Bash 4.4.23 enroute to attempting to follow instructions.
In an attempt to get my Audible Activation Bytes I ran the following lines in my macOS 10.13.5 Terminal
brew install chromedriver ffmpeg
sudo easy_install pip
pip install selenium requests
git clone https://github.com/inAudible-NG/audible-activator
cd audible-activator
sed -i '' 's,chromedriver_path = "./chromedriver",chromedriver_path = "/usr/local/bin/chromedriver",' audible-activator.py
./audible-activator.py
Everything seems to go fine until I get to the last command (./audible-activator.py) ...when I run that I get the response: env: python2: No such file or directory
So I'm not sure what to do, but if someone could help I would greatly appreciate it. Please let me know if there are any other details I can provide.  Thanks! - Ben

I am not sure that this is the right place to ask this. The audible-activator repo might be a better place.
The error message tells you that the env command cannot find python2. See the shebang in the first line:
#!/usr/bin/env python2
Check which versions are installed (one if the simplest ways is probably to just enter python in a terminal and use auto completion to let the auto completion list all versions.
If you have a version of python 2 installed (maybe named python2.7) find all files which refer to python2 by using grep -rnw python2 in the root folder of the activator and change python2 to whatever python 2 is called on your system.
If you dont have a version of python 2 installed you can most likely install it via brew.

Well it looks like audible-activator updated a few days ago to support python 3. The shebang on the python script is either wrong or they didn't update that file to python3. You can try changing the shebang from
#!/usr/bin/env python2

to
#!/usr/bin/env python

and see if that works for your system. Otherwise follow b0wter's advice and see if the upstream project can help.


issue with 1.0.0 release

i try with 1.0.0 release and got the following issue
Error: Cannot find module '/tmp/libxmljs/node_modules/libxmljs/dist/index.js'. Please verify that the package.json has a valid "main" entry

this is the content of libxmljjs's package.json
"main": "dist/index.js",
  "types": "dist/index.d.ts",

looks like dist is being ignore during npm publish?
@rchipka

@tuananh Thanks for catching this! Can you try v1.0.1?


Service Bus Outbound Push to Function App

Does service bus has outbound and push to function app when a message is created?
Does service bus has similar feature like app service vnet integration to allow outbound to reach out to my private endpoint?
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c362e8fa-107b-8aa6-ae81-d1d622a74498
Version Independent ID: 56b83f30-3937-6a3c-e21b-b0c005d6240d
Content: Network security for Azure Service Bus - Azure Service Bus
Content Source: articles/service-bus-messaging/network-security.md
Service: service-bus-messaging
GitHub Login: @axisc
Microsoft Alias: aschhab

@RonnieQuan Thanks for the feedback! We will review and update accordingly.

Does service bus has outbound and push to function app when a message is created?

Messages have to be "pushed" and "pulled" from Service Bus by an external service. So, a function app would have to pull messages from a service bus entity, which can be achieved by using the official service bus trigger binding.

Does service bus has similar feature like app service vnet integration to allow outbound to reach out to my private endpoint?

Since service bus have "pull" schematics, the service should be able to access service bus. If this service does not have open access, then you could opt for the premium tier of service bus which supports service endpoints and private link. You can read more about these options in the official doc for the same.

@RonnieQuan Just following up here... Hope my previous comment clears things up.

@RonnieQuan Hope my previous comment clears things up.
Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


subscribeToRoomMultipart Issue

Good day! Yesterday start to get errors when fetching messages by subscribeToRoomMultipart method. The old one is working fine. 5 days ago had no errors.

Oh no! What errors exactly?

Scratch that. We've found the problem and will have a fix out very shortly. It's purely a server side issue. Sorry about this!

Should be fixed now.

Fixed. Thanks!


Add Vanilla.app :latest

If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.
After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

[x] Named the cask according to the token reference.
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.
[x] Checked there are no open pull requests for the same cask.
[x] Checked the cask was not already refused in closed issues.
[x] Checked the cask is submitted to the correct repo.

Derp; I swear I searched for this in the repo but didn't find it...


map reduce using url

When I trying to run the example of map_reduce_url I get an error about chunk_size that is not pass to the function "split_object_from_url" and I look the code and it seems that the call to that function from partitioner (executer.py line 524) mismatch the arguments

Fixed in #20


with() does not handle null values for dates properly

class DatedThing extends ValueObject.define({
  date: Date,
}) {}

const dated = new DatedThing({date: new Date()}).with({date: null})

# expected
dated.date //=> null

# actual
dated.date //=> 1970-01-01T00:00:00.000Z

Ouch!

Already?! You're amazing! ❤


Use yield instead of (timeout 0)

(timeout 0) resolves to using js/setTimeout which will actually take 4+ msecs in browsers. This is an eternity. The nextTick approach was proposed by Patrick O'Brien and implemented here.
Docs on nextTick from Closure library:

Fires the provided callbacks as soon as possible after the current JS execution context. setTimeout(…, 0) takes at least 4ms when called from within another setTimeout(…, 0) for legacy reasons.

This will not schedule the callback as a microtask (i.e. a task that can preempt user input or networking callbacks). It is meant to emulate what setTimeout(_, 0) would do if it were not throttled. If you desire
microtask behavior, use goog.Promise instead.

Unfortunately when I use this pull request against the Todo MVC example, and an internal Day8 project, I get this error. @pkobrien do you have any thoughts or ideas on this?

Apologies @pkobrien, I think I had some stale caches which were causing conflicts. Running from a clean slate, this seems to be fine now. More testing is needed, but it's not obviously broken.

No problem. Glad you have it working. I was surprised to see that little function giving you trouble. :-)

The new router loop solves this problem. It no longer uses core.async. See 420e42a
Will be a part of v0.5.0 release.


Build require WDK but not written in dev docs

Provide a description of requested docs changes
Since VCM is added and it requires WDK to build, this should be added to devdocs for building PT.
(It was there before bit it gets removed. 😕 )

this should have been removed with the direct show pivot.  @yuyoyuppe correct?

I've failed to build PT on a clean workspace until WDK is installed...

Even on a fresh clone?

Yes, that's correct.

I just tested on a one of our eval win11 dev VM and only needed what was the items from the .vsconfig.  VCM compiled fine

also i know for a i didn't include the WDK install step for new release.yml update and that is something i'm 99% sure we need to manually install on the agent

Yes, we shouldn't require WDK, unless something from the previous version sneaked in.

@franky920920 , are you by any chance on a Windows N machine?

@jaimecbernardo This is on a Windows Server 2022 machine.

i don't think we've ever really tested / verified server for building.  There could be something not in server but it is in client

I don't think we officially support server as well.  It should work but currently, this isn't a requirement we can verify on a VM a fresh copy of windows 'just works'.
I'm going to close this out as external since server i believe has a bunch of quirks to it and this is the first report of it to date.


Simple markdown editor

- Summary
The current slate based editor is not performant enough to handle real life articles, content, etc. This seems to be a problem with Slate itself, and it will quite possibly be a lot of work to fix. Meanwhile we should have a robust solution for markdown editing. This PR replaces Slate with a much simpler textarea based markdown editor without an intermediary content model, but with menu bar and custom block support.
- Test plan
This is still work in progress and the menus are very roughly styled, but it's already workable for long posts, dragging images and files work, bold and italics works and there's an option to add link, although this one relies on a prompt.
- A picture of a cute animal (not mandatory but encouraged)

have you looked into yabwe.github.io/medium-editor?


angular tests break typescript compilation in angular2-cli

Error: Typescript found the following errors: tmp/broccoli_type_script_compiler-input_base_path-qtGuLt77.tmp/0/public/bower_components/vaadin-date-picker/test/angular2/main.ts (3, 30): Cannot find module '@vaadin/angular2-polymer'.

It is wrong that in angular2-cli projects something tries to compile the typescript files in our elements. Can we prevent it? Maybe add an { "exclude": "bower_components" } line to tsconfig.json?


⚠ ClamAV has degraded performance

In df29c0b, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 648 ms

Resolved: ClamAV performance has improved in 561607c after 14 minutes.