NodeNetworkPolicy not creating logs

Describe the bug
NodeNetworkPolicy type policies do not create logs in /var/log/antrea/networkpolicy/np.log even with enableLogging: true is set
To Reproduce
Create a NodeNetworkPolicy with enableLogging: true
Generate traffic
Expected
Log entry /var/log/antrea/networkpolicy/np.log similar to other ClusterNetworkPolicy
Actual behavior
Nothing is logged
Versions:

Antrea version
2.0.1
Kubernetes version:
v1.28.8+rke2r1
Container runtime:
containerd
Linux kernel version on the Kubernetes Nodes (uname -r).
6.4.0-150600.10-default
-->

Additional context

@notsrch traffic logging for NodeNetworkPolicy is not implemented, though it should be technically feasible.
@hongliangl could you confirm the feasibility? And before it's supported we should prevent this configuration and document it.

enableLogging

Will investigate that.

@notsrch traffic logging for NodeNetworkPolicy is not implemented, though it should be technically feasible. @hongliangl could you confirm the feasibility? And before it's supported we should prevent this configuration and document it.

Will investigate that.

The data path of NodeNetworkPolicy is iptables, which supports logging matched packets information to system log (/var/log/syslog or /var/log/messages). Unfortunately, iptables does not natively support logging directly to a specific file. IMO, it is not easy for Antrea to read the corresponding log from the system log file.
It is easy for Antrea using iptables to log the packet information to system log if enableLogging of a ACNP is true, but it is not friendly to users. @tnqn

Tools like rsyslog may redirect logs to specific files, but not sure whether it can be easily configured and works for all OS. If it's too complex, logging to syslog sounds not bad too as long as we document it clearly whether to find the logs.

For us at least, having it logged somewhere/anywhere is better then nothing.   When having some deny NodeNetworkPolicy, it is near impossible to troubleshoot anything without some form of log as to the permit/deny action taken with traffic.

#6626 is merged, we can close this issue.
@hongliangl I saw you used 'For #6525' instead of 'Resolved #6525' in the PR summary. Please check if there is any follow up. If not, I would suggest to use ' 'Resloved #***' in the PR summary next time, which can help to close the corresponding issue automatically without a manual intervention. Thanks.


Iterate through the live NodeList instead of copying to an array in $generateNodesFromDOM

The HTML deserialization design is partially predicated on the user having the ability to manipulate the DOM tree in the conversion functions - this provides virtually limitless flexibility in how incoming HTML can be processed.
Previously, we copied the DOM nodes at the top level to an array, then iterated through that to initiate the HTML -> Lexical transformation. This works fine in most cases, but it can cause an issue in a couple of edge cases where you're trying to combine sibling DOM nodes into a single LexicalNode. There's no way to prevent those sibling nodes from being processed, since they have already been copied to an array, removing them from the DOM does nothing.
Alternative proposed solution was to mark the nodes as "processed" and then ignore them in the next pass, but this doesn't prevent their children from being processed. Also considered allowing the conversion to return "true" to stop further processing, but finally decided that this is just a bug.

Tables e2e tests are broken on safari at the moment.


The model cannot be loaded into the gpu

What is the issue?
After updating to version 0.2.5, the gemma2:9b model cannot be loaded into the GPU.
After I downgraded the version back to 0.2.4, the model was successfully loaded into the GPU.
OS
Windows
GPU
Nvidia
CPU
Intel
Ollama version
0.2.5

Hi there, try re-pulling the model: ollama pull gemma2:9b
May I ask what ollama ps shows for you with gemma2:9b loaded? Sorry you hit this issue

I reinstalled Ollama and it worked.


I think there are bugs in train_pose.py

Hi,
I ran train.sh, but I had some errors.
I think there are bugs.
Should I add "input = input.cuda()" to around line 138 in train_pose.py and change line 63 "params_dict = dict(model.module.named_parameters())" in train_pose.py to "params_dict = dict(model.named_parameters())" .

If you use one gpu to train and change line 49 "model = torch.nn.DataParallel(model, device_ids=args.gpu).cuda()" to "model = model.cuda()", you're right.

Thank you for your replying.
Yes, I use one gpu to train.
Should I change other codes ?

No, I think. If you find something error, please let me know. Thank you.

Thank you !

@tugumi911  you are right!
if one gpu is used, "input = input.cuda()" and "params_dict = dict(model.named_parameters())"  should be modified!
thanks

If we want to use only one GPU, there is another way can achieve it.

Remove the line "os.environ['CUDA_VISIBLE_DEVICES'] = '2,3'" in the train_pose.py.
Modify the value of --gpu in train.sh to 0.


Add patch to update x/net to 0.7.0 in livenessprobe

Issue #, if available:
Description of changes:
Test bumping the livenessprobe x/net requirement to 0.7.0 for fixing x/net vulnerability. If it doesn't break liveness image push to other versions.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/lgtm

/lgtm


Error using Hydra

Hi all,
Thanks a lot for the awesome library. I'm trying to use Hydra with pytorch-lightning. I'm using the last release of pytorch-lightning.
However, I got the following error after my training step:
...
  File "/home/.local/lib/python3.8/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 241, in on_validation_end
    self._do_check_save(filepath, current, epoch)
  File "/home/.local/lib/python3.8/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 275, in _do_check_save
    self._save_model(filepath)
  File "/home/.local/lib/python3.8/site-packages/pytorch_lightning/callbacks/model_checkpoint.py", line 142, in _save_model
    self.save_function(filepath)
  File "/home/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/training_io.py", line 260, in save_checkpoint
    checkpoint = self.dump_checkpoint()
  File "/home/.local/lib/python3.8/site-packages/pytorch_lightning/trainer/training_io.py", line 353, in dump_checkpoint
    raise ValueError(
ValueError: ('The acceptable hparams type is dict or argparse.Namespace,', ' not DictConfig')
Exception ignored in: <function tqdm.__del__ at 0x7f1f9e379a60>

It says that Dictconfig are not supported for saving, but I saw in a pull request that this problem has been corrected.
Can you point me to direction on how to correct this?
Code
@hydra.main("config/config.yaml")
def main(cfg=None):
    wrap_tb_logger()
    model = hydra.utils.instantiate(cfg.model, cfg)

    trainer = pl.Trainer(
        gpus=list(cfg.gpus),
        max_epochs=cfg.epochs,
        train_percent_check=0.4
    )

    trainer.fit(model)

What's your environment?

OS: Linux
Packaging pip
Version 0.7.1

@Borda can you add this fix?

@williamFalcon @Borda I solved this problem by converting hparams to a flat dictionary after I initialized my model.
import omegaconf

def _to_dot_dict(cfg):
    res = {}
    for k, v in cfg.items():
        if isinstance(v, omegaconf.DictConfig):
            res.update(
                {k + "." + subk: subv for subk, subv in _to_dot_dict(v).items()}
            )
        elif isinstance(v, (str, int, float, bool)):
            res[k] = v

    return res

@pvnieo check master?
i pushed a fix last night

@williamFalcon Yes thank you, I just tested with the last dev version and It's working!
However, I got this warning, and I don't where is it called!
UserWarning: you called `module.module_arguments` without calling self.auto_collect_arguments()

we can just disable it haha. submit a PR?

Sorry, I submit a PR for what?

disabling the warning

Ok.
I just discovered that (I don't know if it's related the last dev version, but I hadn't this problem before) when I kill my program using Ctrl+C, the process isn't killed and it continue training (before it's says that it's trying "to kill the process gracefully" or sth like this).
I found in this stack over flow question that it's maybe related to using multiple threads and the killing isn't handled well.
Is this a known issue?

this is fixed on #2029


bitmap_agg error ERROR 1064 (HY000): No matching function with signature: bitmap_agg(bigint(20)).

Steps to reproduce the behavior (Required)

CREATE TABLE

CREATE TABLE IF NOT EXISTS event (
`user_id` bigint not null
) ENGINE=OLAP
DUPLICATE KEY(`user_id`)
DISTRIBUTED BY HASH (`user_id`)
PROPERTIES ("storage_type" = "column", "replication_num" = "1");

INSERT

insert into event values (1);

SELECT

select bitmap_agg(`user_id`) from event;

Expected behavior (Required)
Expect bitmap data
Real behavior (Required)
ERROR 1064 (HY000): No matching function with signature: bitmap_agg(bigint(20)).

StarRocks version (Required)
2.5.4
Docker Compose And SQL
docker-compose.yaml
version: '3.7'
services:
  starrocks:
    image: starrocks/allin1-ubuntu:2.5.4
    restart: always

sql
CREATE TABLE IF NOT EXISTS event (`user_id` bigint not null) ENGINE=OLAP DUPLICATE KEY(`user_id`) DISTRIBUTED BY HASH (`user_id`) PROPERTIES ("storage_type" = "column", "replication_num" = "1");
insert into event values (1);

select bitmap_agg(`user_id`) from event;

Could you upgrade the all-in-1 to the latest version?

The latest version is correct.

I use starrocks 2.5.6 version, and trigger the same issue.
is bug in the version?
which version fix this bug?


transaction isolation level

Hello, could you tell me, if it is possible to set Transaction Isolation Level in hibernate reactive for some native queries?

Ah yeah, this is a good question. There's no "bottled" way to do it rn, it's something I forgot we had to come back to. I forget whether the Vert.x guys ended up adding an API for it or whether it has to be done by executing SQL on the connection. Either way, we need to expose that in some way in our APIs.
I will look into this.

So the issue in Vert.x is this one:
https://github.com/eclipse-vertx/vertx-sql-client/issues/432
If I'm not mistaken, there's not much we can really do here other than wait for them to add this functionality.
Because we're not starting the transaction ourselves, that's buried within the Vert.x API.

is this still an issue? Given:
emf.withTransaction((session, tx) -> {...});

How do I set the transaction isolation level in {...}?


Incorrect Results?

HI, thankyou for your contribution. I ran the pre-trained models REDS_L1 and GOPRO_L1 on my own images and even the example images you provided but i am getting bad results. Any idea what it could be? I am running this on windows.  Thanks in advance.
Orig Image

Deblurred with REDS

DeBlurred with GOPRO

Your orig example Flower

Deblurred with REDS

Deblurred with GOPRO

Your orig example istanbul

Deblurred with REDS

Deblurred with GOPRO

Hi @Abrar3616
Your GTA image has ghost artifacts instead of blur.
Deblurring methods will not work with it.
To make a more realistic blur, you should increase the frame rates before averaging the successive frames.

Oh ok thanks. Ill look into it


[modify] add "#contact_charge" to ss/contact (v1.18向け)

and also add "#contact_group_name" to contact/addon/page.

merged: https://github.com/shirasagi/shirasagi/commit/c1ded648eae2be3c60f2fb31b1b1fa1ed0ead296


Need to update! NO SKIN NO SKILL!

That's a fact, tag me when the update is out please

https://github.com/sansbruhgaming/R3nzSkin/releases/tag/v3.1.5

dont download hes link nice bitcoin usage

dont download hes link nice bitcoin usage

I’m going to get suspended if I say what I want to

dont download hes link nice bitcoin usage

i Allready did, but it is working is it a harmfull or somthing ?

13.16 Update has been pushed to the main branch.


Add a method to delete an annotation without unbinding listeners

The backbone API for destroying models also removes all event listeners. To avoid regenerating an annotation model (and updating all views that listen to it), this adds a new public that performs the rest request but does not destroy the model object itself.  Very little code is changed here; it is mostly an additional test for the new public method.

Codecov Report

Merging #222 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   89.42%   89.43%   +<.01%
==========================================
  Files          53       53
  Lines        3414     3417       +3
  Branches       97       97
==========================================
+ Hits         3053     3056       +3
  Misses        361      361

Impacted Files
Coverage Δ

web_client/models/AnnotationModel.js
68.81% <100%> (+1.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67f33ef...422d180. Read the comment docs.


Version for Swift 2.3?

I tried 0.1.2 on Swift 2.3 and apparently I get errors. Is there a version supported by Swift 2.3?

@waseefakhtar Not at the moment. I'll see what i can do about that. Should be pretty easy to support Swift 2.3.

Sorry. Given Xcode no longer supports Swift 2.3, I'll not put effort in supporting it as well. Thanks for the understanding.


How to translate Polymer.Base.transform to Polymer.dart?

https://github.com/PolymerElements/iron-list/blob/master/demo/index.html#L149

I guess I found it with PolymerBase


Cut release 0.26

[ ] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes

Verification

I made a boo boo, making new PR :)


BWT plugin not showing on electrum

I already pasted the bwt file from the compressed file on the directory said, I wasn't sure if it is /electrum/plugins like the root dir or ~/.electrum/plugins home dir one, both seems doesnt work atleast on my end, maybe I am missing something thanks!
I am using a standalone executable electrum 3.3.8

You cannot install external plugins with the standalone executable. See here:

Note that it is not possible to install external plugins with the Electrum AppImage or standalone Windows executable. You will need to run from tar.gz on Linux, use the Windows installer, or run from source.

oops, okie, sorry my bad didn't recognized that


Add back keep alive configuration

This line was missing as a result of a recent merge. I am adding it back to fix the keep alive configuration.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/2152/
Test PASSed.

@calvinjia PTAL.


Update EmojiTest's it('should put a less frequent and recent used emoji behind' test to not be flakey

This test failed here: https://github.com/Expensify/App/actions/runs/6533171700/job/17737811302
And the only failure was that the lastUpdatedAt timestamp was off by 1 ms.
Let's update the test so we don't test time diffs, so this test should never fail incorrectly
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017418578e73d69510
Upwork Job ID:<PHONE_NUMBER>548019712
Last Price Increase: 2023-10-16

meh maybe later

not prioritizing

Closing b/c I haven't seen this in a while


added yarn.lock file

Minor, but important

@omerlh
Thank you for your PR. I'm not using yarn here, so I doubt how yarn.lock would help. Could shed some light on it?

The main advantage (at least in my opinion) of yarn over npm is the yarn.lock. It is simmilar to npm`s shrinkwrap, but it has better integration with the tool. Meaning, any command in yarn update the lock file, where in npm you had to run additional command. So if you consider using yarn, this is a nice addition (with the better perfomance). Otherwise, it will be just outdated next time you will change something in the packages.
Also, I noticed that this PR contains my personal profile, so if you are thinking of moving to yarn I can close this and open a PR from the dev branch in my fork.
BTW - thanks for this repo. I used it and it was very easy to setup.

@omerlh
Thanks for clarification:) Yes, I would love to merge the PR and switch to yarn if you can clean up the PR a little bit.

Sure. I am closing this and open a new PR from the dev branch.


Ability to override default enchantment recipes

Minecraft Version: 1.20.1
Mod Version: 1.2.2
I wanted to customize the recipe for Fortune, and make it more expensive. But after adding the recipe, the default recipe and the new one I'd created both showed up in the table. I understand this is intended but is it possible to add a way to disable the default recipes?

You already can do this, read the wiki


Support DEFAULT value / auto-UUID column in CREATE (similar to SERIAL)

Discussed in https://github.com/kuzudb/kuzu/discussions/3125

Originally posted by sapalli2989 March 23, 2024
It would be great, if we could declare within CREATE/DDL, that ids of a UUID column are to be auto-created via gen_random_uuid(). This feature would be analogue to SERIAL for integer sequences.
Currently Kuzu provides gen_random_uuid() for UUIDv4 auto-creation. But the need to invoke this function manually for new nodes  with UUID primary key is inconvenient and sometimes not easily possible - as seen with MERGE in https://github.com/kuzudb/kuzu/issues/3014. Actually I think proposal here is more useful than linked one.
PostgreSQL provides DEFAULT value keyword within CREATE in combination with equally named gen_random_uuid() for these cases (more examples in 1, 2):
CREATE TABLE table_name (
    unique_id UUID DEFAULT gen_random_uuid(),
    ...
    PRIMARY KEY (unique_id)
);

or with directly prepended PRIMARY KEY:
CREATE TABLE table_name (
    unique_id UUID DEFAULT gen_random_uuid() PRIMARY KEY,
    ...
);

, requested for Kuzu in  https://github.com/kuzudb/kuzu/issues/2911.
I think this would be a nice addition to usability of UUIDs.

For this, the COPY FROM statement would need to handle UUIDs as a special case as we need to evaluate gen_random_uuid() inside COPY, which isn't supported yet. This will require some updates to the COPY statement rules as a result.

DEFAULT is supported now.


Build failure with gcc v11.*

Describe the bug
Failing to build Device Client while using GCC 11.
ERROR LOGS:
 25%] Building C object aws-iot-device-sdk-cpp-v2-build/crt/aws-crt-cpp/crt/s2n/CMakeFiles/s2n.dir/pq-crypto/kyber_90s_r2/ntt.c.o
/home/ubuntu/1.2/aws-iot-device-client/build/aws-iot-device-sdk-cpp-v2-src/crt/aws-crt-cpp/crt/s2n/pq-crypto/kyber_90s_r2/ntt.c:92:44: error: argument 1 of type ‘int16_t[256]’ {aka ‘short int[256]’} with mismatched bound [-Werror=array-parameter=]
   92 | void PQCLEAN_KYBER51290S_CLEAN_ntt(int16_t poly[256]) {
      |                                    ~~~~~~~~^~~~~~~~~
.
.
.

To Reproduce
Steps to reproduce the behavior:

Install GCC v11
Build Device client by following the Quick Start guide from README.

Expected behavior
Successfully build Device Client binary
Actual behavior
Build failure with error on aws-iot-device-sdk-cpp-v2 side. (Error mentioned above)
Full Error Logs
[ 24%] Building C object aws-iot-device-sdk-cpp-v2-build/crt/aws-crt-cpp/crt/s2n/CMakeFiles/s2n.dir/pq-crypto/kyber_90s_r2/kyber_90s_r2_kem.c.o
[ 25%] Building C object aws-iot-device-sdk-cpp-v2-build/crt/aws-crt-cpp/crt/s2n/CMakeFiles/s2n.dir/pq-crypto/kyber_90s_r2/ntt.c.o
/home/ubuntu/1.2/aws-iot-device-client/build/aws-iot-device-sdk-cpp-v2-src/crt/aws-crt-cpp/crt/s2n/pq-crypto/kyber_90s_r2/ntt.c:92:44: error: argument 1 of type ‘int16_t[256]’ {aka ‘short int[256]’} with mismatched bound [-Werror=array-parameter=]
   92 | void PQCLEAN_KYBER51290S_CLEAN_ntt(int16_t poly[256]) {
      |                                    ~~~~~~~~^~~~~~~~~
In file included from /home/ubuntu/1.2/aws-iot-device-client/build/aws-iot-device-sdk-cpp-v2-src/crt/aws-crt-cpp/crt/s2n/pq-crypto/kyber_90s_r2/ntt.c:1:
/home/ubuntu/1.2/aws-iot-device-client/build/aws-iot-device-sdk-cpp-v2-src/crt/aws-crt-cpp/crt/s2n/pq-crypto/kyber_90s_r2/ntt.h:9:45: note: previously declared as ‘int16_t *’ {aka ‘short int *’}
    9 | void PQCLEAN_KYBER51290S_CLEAN_ntt(int16_t *poly);
      |                                    ~~~~~~~~~^~~~
/home/ubuntu/1.2/aws-iot-device-client/build/aws-iot-device-sdk-cpp-v2-src/crt/aws-crt-cpp/crt/s2n/pq-crypto/kyber_90s_r2/ntt.c:116:47: error: argument 1 of type ‘int16_t[256]’ {aka ‘short int[256]’} with mismatched bound [-Werror=array-parameter=]
  116 | void PQCLEAN_KYBER51290S_CLEAN_invntt(int16_t poly[256]) {
      |                                       ~~~~~~~~^~~~~~~~~
In file included from /home/ubuntu/1.2/aws-iot-device-client/build/aws-iot-device-sdk-cpp-v2-src/crt/aws-crt-cpp/crt/s2n/pq-crypto/kyber_90s_r2/ntt.c:1:
/home/ubuntu/1.2/aws-iot-device-client/build/aws-iot-device-sdk-cpp-v2-src/crt/aws-crt-cpp/crt/s2n/pq-crypto/kyber_90s_r2/ntt.h:10:48: note: previously declared as ‘int16_t *’ {aka ‘short int *’}
   10 | void PQCLEAN_KYBER51290S_CLEAN_invntt(int16_t *poly);
      |                                       ~~~~~~~~~^~~~
cc1: all warnings being treated as errors
aws-iot-device-sdk-cpp-v2-build/crt/aws-crt-cpp/crt/s2n/CMakeFiles/s2n.dir/build.make:781: recipe for target 'aws-iot-device-sdk-cpp-v2-build/crt/aws-crt-cpp/crt/s2n/CMakeFiles/s2n.dir/pq-crypto/kyber_90s_r2/ntt.c.o' failed
make[3]: *** [aws-iot-device-sdk-cpp-v2-build/crt/aws-crt-cpp/crt/s2n/CMakeFiles/s2n.dir/pq-crypto/kyber_90s_r2/ntt.c.o] Error 1
CMakeFiles/Makefile2:1561: recipe for target 'aws-iot-device-sdk-cpp-v2-build/crt/aws-crt-cpp/crt/s2n/CMakeFiles/s2n.dir/all' failed
make[2]: *** [aws-iot-device-sdk-cpp-v2-build/crt/aws-crt-cpp/crt/s2n/CMakeFiles/s2n.dir/all] Error 2
CMakeFiles/Makefile2:722: recipe for target 'CMakeFiles/aws-iot-device-client.dir/rule' failed
make[1]: *** [CMakeFiles/aws-iot-device-client.dir/rule] Error 2
Makefile:181: recipe for target 'aws-iot-device-client' failed
make: *** [aws-iot-device-client] Error 2

Environment (please complete the following information):

OS: [Ubuntu]
Version [18]
Architecture: [x86-64]
Device Client commit: Failing for latest commit i.e. release 1.2 and also for release 1.1

We are currently looking into this issue and we will post an update here when we resolve this issue for GCC v11. A possible workaround is to use the previous version of gcc. After downgrading the gcc version from 11 to 9, the issue was resolved and I was able to build the Device Client binary successfully.

This should still build if the compiler configuration treats these as warnings, not errors.
However I had another unrelated build failure on my side that I will make a PR for.


Roll Engine from d3b81f19fc98 to 5a25a2817439 (28 revisions)

https://github.com/flutter/engine/compare/d3b81f19fc98...5a25a2817439
2020-07-16<EMAIL_ADDRESS>Makes IOS dispatch showOnCcreen action for header semantics nodes (flutter/engine#19788)
2020-07-16<EMAIL_ADDRESS>Roll Skia from 4e105e2e06c8 to 7479eda3b6d2 (6 revisions) (flutter/engine#19807)
2020-07-16<EMAIL_ADDRESS>Roll Dart SDK from 92f4eb58c808 to 2e05e6c94a05 (6 revisions) (flutter/engine#19806)
2020-07-16<EMAIL_ADDRESS>Roll Skia from 9d02a4c0a9ae to 4e105e2e06c8 (3 revisions) (flutter/engine#19804)
2020-07-16<EMAIL_ADDRESS>Fix NullPointerException in FlutterTextView (flutter/engine#19501)
2020-07-16<EMAIL_ADDRESS>Roll Skia from 88f65ceefdae to 9d02a4c0a9ae (1 revision) (flutter/engine#19803)
2020-07-16<EMAIL_ADDRESS>Roll Dart SDK from ab958bee577b to 92f4eb58c808 (2 revisions) (flutter/engine#19802)
2020-07-16<EMAIL_ADDRESS>Desktop embedder ComputePlatformResolvedLocale entrypoint (flutter/engine#19597)
2020-07-16<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from vTuql... to UAgiE... (flutter/engine#19801)
2020-07-16<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from 7jcmd... to 39EKo... (flutter/engine#19800)
2020-07-16<EMAIL_ADDRESS>Roll Dart SDK from 1e78bd069ee7 to ab958bee577b (7 revisions) (flutter/engine#19799)
2020-07-16<EMAIL_ADDRESS>Roll Skia from 7d4fbc5f64c9 to 88f65ceefdae (2 revisions) (flutter/engine#19798)
2020-07-16<EMAIL_ADDRESS>Roll Skia from cd11a51a11df to 7d4fbc5f64c9 (1 revision) (flutter/engine#19797)
2020-07-16<EMAIL_ADDRESS>Re-enable logging. (flutter/engine#19756)
2020-07-16<EMAIL_ADDRESS>Manual Dart SDK roll (flutter/engine#19791)
2020-07-16<EMAIL_ADDRESS>Roll Skia from 14982c8e1594 to cd11a51a11df (1 revision) (flutter/engine#19795)
2020-07-16<EMAIL_ADDRESS>Roll Skia from c0693db3f525 to 14982c8e1594 (3 revisions) (flutter/engine#19790)
2020-07-16<EMAIL_ADDRESS>Prevent that removeActivityResultListener() is causing an ConcurrentModificationException (flutter/engine#19702)
2020-07-15<EMAIL_ADDRESS>Roll Skia from 3de2a5640722 to c0693db3f525 (3 revisions) (flutter/engine#19784)
2020-07-15<EMAIL_ADDRESS>Add all system cursors (engine) (flutter/engine#19550)
2020-07-15<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from Nvy8A... to vTuql... (flutter/engine#19783)
2020-07-15<EMAIL_ADDRESS>[null-safety] update use of dot packages to package_config.json (flutter/engine#19780)
2020-07-15<EMAIL_ADDRESS>Roll Skia from e80a5954018b to 3de2a5640722 (2 revisions) (flutter/engine#19782)
2020-07-15<EMAIL_ADDRESS>Roll Dart SDK from 06183779d7aa to<PHONE_NUMBER>00 (7 revisions) (flutter/engine#19781)
2020-07-15<EMAIL_ADDRESS>Roll Skia from cd241f1b6a64 to e80a5954018b (4 revisions) (flutter/engine#19779)
2020-07-15<EMAIL_ADDRESS>[web][3/3] Handle surrogate during line break detection (flutter/engine#19745)
2020-07-15<EMAIL_ADDRESS>Roll Skia from 1846ba3f08ed to cd241f1b6a64 (7 revisions) (flutter/engine#19777)
2020-07-15<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from hHZAK... to 7jcmd... (flutter/engine#19774)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from hHZAK2r0ujhB to 39EKoer0Z6eq
fuchsia/sdk/core/mac-amd64 from Nvy8AXgJtuyw to UAgiEIYnwCtO
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Commit queue failed; closing this roll.


Bug: unable to setup indexes

Users are reporting an issue when they apply their JobSet, the JobSet object is created but it never starts running. After examining the logs we found the following error:
2023-08-22T21:19:59Z    ERROR    Reconciler error    {"controller": "jobset", "controllerGroup": "jobset.x-k8s.io", "controllerKind": "JobSet", ....  "error": "Index with name field:.metadata.controller does not exist"}

The index on .metadata.controller is created in SetupIndexes which is called from main.go here. If the indexes cannot be built, we would expect to see this error logged. Looking further in the logs, we do indeed see this error:
2023-08-21T14:37:20Z    ERROR    setup    unable to setup indexes    {"error": "failed to get API group resources: unable to retrieve the complete list of server APIs: batch/v1: Get \"https://<IP_ADDRESS>:443/apis/batch/v1\": dial tcp <IP_ADDRESS>:443: i/o timeout"}

/kind bug

Perhaps adding retry logic with some kind of exponential backoff policy here would be sufficient

@kannon92 I notice Kueue has a helper utilruntime.Must(...) in which they call SetupIndexes. Perhaps we should implement something similar? This bug has been popping up a lot lately so I want to fix it asap.

Yea I think that is a good idea.

Interesting. I wouldn't have expected SetupIndexes to fail.
For whatever reason, we haven't hit these issues. From the message, it looks like the apiserver was down.
Indeed it seems best to exit.

Correct - I've seen this several times, usually when I install / uninstall something and the only fix is to delete and re-create the entire cluster.


Alpine Ruby 2.5 Stack Size Issue

Just noticed your repo from 'Discover Repositories'
Highlighting a problem with Alpine Linux and Ruby 2.5.
Just so that users do know there is a current issues around this.
https://qiita.com/koshigoe/items/7acebbab7b44fa2b35bc
https://bugs.ruby-lang.org/issues/14387#change-69850
Your ruby version is 2.5, so your users have to be aware of this issue.
Cheers

@Starefossen I am afraid no patch will be done for this issue.
https://github.com/docker-library/ruby/issues/196

I am working on patch. Its a bit messy so it may take a bit time.


Don't show pages in explorer that user has no permissions to access

This PR fixes an issue where having add/edit/publish access to two sibling pages allows the user to see every page at that level, even if they don't have explicit access to it.

I added two tests, but there's still one use-case that is bugged, which is the following:
If you have a structure like:
Root
    - Stories [with EDIT permissions]
        - Story A
        - Story B
    - Galleries
        - Gallery A [with EDIT permissions]
        - Gallery B

In this scenario, where edit permission is granted on Stories and Gallery A, you cannot navigate to Gallery A because the Galleries node does not appear in the explorer view (due to having neither ADD, EDIT, nor PUBLISH permissions).
I need to add an additional rule to the explorable_pages method that shows the parents of explorable pages up to the first common ancestor.

This will fix #4660

Thanks @mike-hearn! Merged in 7c9c00ab7c791e69dc3476a7298783f875f00c21.


Is is possible to automatically save error log?

I don't know how to save error log like laravel, Laravel just automatically saved everything to "runtime/log" but how could Slim to achieve the same thing?
Thanks

I could not get the error from errorHandler nor phpErrorHandler, I just got 500 error, I really want to know how could I get all these messages

You can supply a logger that conforms to the PSR-3 standard, such as one from the popular Monolog package.
See: Slim 4 Error Logging

Closing this as resolved


Added support for server-side IP filtering

This is in reference to Issue #984
Basically this allows for you to disallow traffic to the management console from everywhere except certain IP addresses or CIDR ranges, while still allowing for clients to report to MunkiReport.
When someone tries to access the MR URL, it will check the IP address of the client against the $conf['manage_ipwhitelist'] array of IP's or CIDR addresses.
If the client is whitelisted, it will let them through. Otherwise it will send them to the 403 page.
If the custom 403 page is setup with $conf['403_unauth'] then it will send them to that page. Otherwise it will send them to the webhost with /403.html at the end (the default location for a 403 page.

I like the idea, but this should be part of the auth mechanism

That makes sense, I am assuming you mean implement it into the auth view instead of adding it to the head partial file correct?

Yes, same as the Captcha code. Maybe there's room for pre-auth plugins?

It'd be cool to have two factor authentication. (But that's beyond the scope of this issue.)

I agree, that would be awesome to have down the road.

@bochoven I moved the check to the pre-auth section

I will update everything shortly, please let me know if my comment on config_default.php is acceptable and if so I will update the ip_blocker.php and the config_default.php to reflect that change

Alright I integrated it with AuthHandler and the auth controller so it will do everything asked
I think I covered everything, but let me know if anything else needs changes!

Is everything fixed or do you still need more changes?

Sorry about that, I did look at your changes. Things are better, but I would like to have the checking code in it’s own class and file like the other auth mechanisms.

Sure! I'll work on moving that over and let you know. I don't want to upgrade our production instance until this is working fully.

Please check the most recent push - I moved it completely out of the AuthHandler to its own class as requested


Tree::create_item does not append item to root if parent is not given

Operating system or device, Godot version, GPU Model and driver (if graphics related):
master
Issue description:
Noticed this when adding a new parameter to specify insertion index. From the documentation:
TreeItem create_item ( TreeItem parent=NULL )
"Create an item in the tree and add it as the last child of parent. If parent is not given, it will be added as the last child of the root, or it’ll the be the root itself if the tree is empty."
This is wrong, if a root exists, and another item is created without a parent specified, it becomes the new root.

The if branch handling a NULL parent also invalidates the documentation:
if (root)
	ti->childs = root;
root = ti;

While I'm at it, should I fix it to behave as mentioned in the documentation? Rerooting the tree doesn't make much sense to me. Then again I wonder if this breaks existing code everywhere.

Duplicate of #12118 I think.

I would probably just throw an error if you want to create an item without passing a parent and a root already exists, any other behavior seems counterintuitive


Add error handling in ec-cli

This commit implements error handling in ec-cli. An error var should be
constructed for a given "type" and "indicator" of error and the calling
function should return an ec_errors.Error pointer instead of an error
object itself.
Signed-off-by: Rob Nester<EMAIL_ADDRESS>

I've gone back and forth and worked through about four different solutions to this, but this solution suggested by @zregvart is probably the most flexible / lightweight so I'm going to just implement it.


Node creation is not being logged

When we bootstrap a node, we don't see this back in the audit trail.
Only when we change something to the object it's being recorded.
Looks like we don't catch the node creation calls.

Fixed by PR #75


v2: Allow to run acceptance tests from main Helm repo

This is a cherry-pick from v3 #6256
What this PR does / why we need it:
This allows to run the acceptance tests directly from the v2 repo as we have for v3.
As more acceptance tests are developed, it is necessary to test them with both v3 and v2, therefore it would be helpful to have these make targets in v2 also.
To run the acceptance tests, one can now do:
    make test-acceptance

To run the completion tests, one can now do:
   make test-acceptance-completion

Special notes for your reviewer:
Currently, only the acceptance completion tests actually run with v2.  The others are skipped and marked as passed.
Also, https://github.com/helm/acceptance-testing/pull/34 is required to have all the acceptance tests pass with the current v2.

This change isn't very important anymore as no new features will be include in v2.
The acceptance tests can still be run against v2 manually instead.


feat: support using <port> in dev.assetPrefix

Summary
fix: #3094
Note that <port> is also available in output.assetPrefix. But I can't think of any situation in which it should be used.
Related Links

Checklist

[x] Tests updated (or not required).
[x] Documentation updated (or not required).

Nice! 👍


bug:  No option to turn on TLS in ClusterOutput for elastic search.

Describe the issue
currently getting received plaintext http traffic on an https channel, closing connection Netty4HttpChannel on elastic search logs. i'm unable to turn on tls in the ClusterOutput for elastic search resource to see if this will fix this because the option to enable tls is not available in the spec section for elastic search (es) => https://github.com/fluent/fluent-operator/blob/master/docs/plugins/fluentbit/tls.md
To Reproduce
Below is my ClusterOutput resource
apiVersion: fluentbit.fluent.io/v1alpha2
kind: ClusterOutput
metadata:
name: k8s-app-es
labels:
fluentbit.fluent.io/enabled: "true"
fluentbit.fluent.io/mode: "k8s"
spec:
matchRegex: (?:kube|service).(.*)
es:
host: elastic-search-es-http.elastic-system.svc.cluster.local
port: 9200
generateID: true
index: fluent-bit
logstashPrefix: fluent-app-log-fb-only
logstashFormat: true
timeKey: "@timestamp"
traceError: true
replaceDots: true
type: _doc
httpUser:
valueFrom:
secretKeyRef:
name: elastic-creds
key: user
httpPassword:
valueFrom:
secretKeyRef:
name: elastic-creds
key: password
Expected behavior
the fluent operator docs provides the specs for the ClusterOutput resource for elastic search as seen here => https://github.com/fluent/fluent-operator/blob/master/docs/plugins/fluentbit/tls.md but an option to enable TLS is not available.
Your Environment
- Fluent Operator version: v2.5
- Container Runtime: crio
- Operating system: linux
- Kernel version:

How did you install fluent operator?
No response
Additional context
No response

@anthonyoride You can refer to each plugin's code: https://github.com/fluent/fluent-operator/blob/master/apis/fluentbit/v1alpha2/plugins/output/elasticsearch_types.go#L100
The tls config is included in almost every output's spec

@benjaminhuo i know there is a TLS config. the question is how do i set it on?

@benjaminhuo i know there is a TLS config. the question is how do i set it on?

Add tls config fields to https://github.com/fluent/fluent-operator/blob/master/manifests/logging-stack/output-elasticsearch.yaml
@wenchajun @wanjunlei Is it correct to add tls config to es like below?
Do we have examples?
apiVersion: fluentbit.fluent.io/v1alpha2
kind: ClusterOutput
metadata:
  name: es
  labels:
    fluentbit.fluent.io/enabled: "true"
    fluentbit.fluent.io/component: logging
spec:
  matchRegex: (?:kube|service)\.(.*)
  es:
    host: elasticsearch-logging-data.kubesphere-logging-system.svc
    port: 9200
    generateID: true
    bufferSize: 20MB
    traceError: true
    logstashPrefix: ks-logstash-log
    logstashFormat: true
    timeKey: "@timestamp"
    caPath: xxx
    keyFile: xxx

https://github.com/fluent/fluent-operator/blob/master/apis/fluentbit/v1alpha2/plugins/output/elasticsearch_types.go#L100
The TLS enabled when tls is not nil.

@wanjunlei Alright that's the response i want. thanks


Install errors... plugin directory issue as well as failed to download package during install

When installing, first issue I noticed was the plugin directory was not correct. Selecting the correct folder threw \notepadd++ at the end of the plugins directory making it look as follows:
C:\Program Files (x86)\Notepad++\Plugins\Notepad++
which is invalid.
Even when fixing this, I get the following error after one step:
"Downloading the packages failed: Unagle to find package for
hl7.fhir.core#4.0.0 at http://build.fhir.org/: http/1.1 404 Not Found
Try Again? (can be done later through installed applications)
Selecting Yes gives the same error.

Having the same issue


Closed Captions messed up

Subtitles are messed up when closed captions are chosen.
First line always shows centered below the second line, which shows on the top and offset. See Friends for instance.

Hello, I have this exact same issue but I am having problems finding it on Kodi's issue tracker. Does anyone have a link?
@jacoghi did you manage to solve this issue?
Thanks :)

@tyrion, Nah, not yet man. I learned to live with it, lol.


Ship getting randomly flinged millions blocks out

Describe the bug and how to make it happen:
Ship getting randomly flinged millions blocks out as the title says I cant get more info about this, tho I found out when trying to turn the boat I think im not fully sure

Does the bug happen without other mods?
Yes

you weren't flung millions of blocks out, you were teleported millions of blocks out
you have been warped to the shipyard, and that structure you see there is probably your ship in the shipyard
what MC version did you use?

1.18.2 forge most recent version of the mod

Random occurrences like this are difficult to debug. Please try and find out what is causing you to be transported to the shipyard.

probably fixed in beta10


Site Support: Academy Hacker

Checklist

[x] I'm reporting a new site support request
[x] I've verified that I'm running youtube-dl version 2019.09.28
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that none of provided URLs violate any copyrights
[x] I've searched the bugtracker for similar site support requests including closed ones

Example URLs

Single video: https://academyhacker.com/courses/215041/lectures/3336242
Single video: https://academyhacker.com/courses/215041/lectures/3336260
Playlist: https://academyhacker.com/courses/enrolled/215041

Description

Additional information:
Account credentials will be provided in a private message.

Already supported,

Already supported,

Please add it to youtube-dl supported sites list

It's already added as Teachable.


Mintable Common Season 1 NFTs

Is your feature request related to a problem? Please describe.
As a new player of the game, I would like to be able to mint an NFT to access multiplayer on-demand.
Describe the solution you'd like
There should be UI added to the game to mint a new common Season 1 Kart NFT on the home menu. The NFT should be of nominal cost, and should be not offer color customization. It will have a trait that notes that it is not an original 100.
Describe alternatives you've considered
We have considered minting another fixed quantity batch of NFTs, but have deemed this the better route - as the NFT holder count scales, we will scale our multiplayer hosting plan in response to support the growth.

Completed


Use gopkg.in/yaml.v2 to fix parsing of embeded k0s cluster config

The k0s dig package is only compatible with the gopkg.in/yaml.v2 package.
When using embeded k0s cluster configuration the config isn't parsed correctly and result in the wrong data.
As an example this config:
apiVersion: k0s.k0sproject.io/v1beta1
kind: ClusterConfig
metadata:
    name: lab

results in the following k0s.yaml file (ignoring the spec.api section):
# generated-by-k0sctl 2022-07-03T20:22:58+01:00
apiVersion: k0s.k0sproject.io/v1beta1
kind: Cluster
metadata: map[name:lab]

Thanks for the PR!


Plotly doesn't render correctly

As @vertexcite noted, when writing the following code in haskell.do, one should get a correct plotly render when writing:
\`\`\`html_header
<script src="https://cdn.plot.ly/plotly-latest.min.js"></script>
\`\`\`

# HaskelDoPlay05

Write text using **markdown**.

Top-level definitions with `haskell top` blocks:

\`\`\`haskell top
import Graphics.Plotly hiding (text)
import Graphics.Plotly.Lucid
import Lens.Micro
import Data.Text (Text, pack)

f :: Int -> Int
f x = x * 2 + 30

plotData :: [(Int, Int)]
plotData = [(0,0),(0,1),(1,2),(3,4)]

\`\`\`

And evaluate them with `haskell eval` blocks:

\`\`\`haskell eval
plotly (pack "p2") [line (aes & x .~ fst & y .~ snd) plotData]
\`\`\`

\`\`\`haskell eval
show (map (f.fst) plotData)
\`\`\`

But nothing happens

I've tracked the bug, and what happens, is that when we add <script> tags they don't get executed, so the Plotly JS file is not include, nor the script generated by plotlyhs is executed.
@mdibaiee you have way more experience than I do in JS, do you have any idea?

@NickSeagull ah yeah, sadly setting innerHTML of a div element, which would then include script/css tags doesn't work as expected, script tags should either be appended using JavaScript (document.head.appendChild(document.createElement('script'))), or we should probably use an iframe, I'll make a PR :+1:

Fixed! Closing


test-database is public right now

remember to switch that back to private when this test is done...

It's back to private and the connection still works.


task/kernel: run apt-get clean before updating to avoid 15090

Signed-off-by: Samuel Just<EMAIL_ADDRESS>

nitpick: could you add the issue URL to the commit message? :)

Yes

@zmc updated


integrity not working

When I have the data-integrity="sha384" option enabled on the module: <link data-trunk rel="rust" data-integrity="sha384" data-bin="ui" data-cargo-features="ui" data-wasm-opt="z" /> it does not generate the checksum for this module include:
  <script type="module">import init from '/ui-327b61ff6dc8826f6d632d0cdc6e0c183dbbb2151d239ca540676b278602adff89f3e975448a0ac90e10369e79d13bf7.js';init('/ui-327b61ff6dc8826f6d632d0cdc6e0c183dbbb2151d239ca540676b278602adff89f3e975448a0ac90e10369e79d13bf7_bg.wasm');</script>

With a CSP set it will reject the loading of the init file.
Also the data-integrity on css files <link data-trunk rel="tailwind-css" data-inline="true" data-integrity="sha384" href="/index.css" /> is ignored.
Also the hotload reload script does not calculate a integrity check. Did I overlooked a feature?

Did I overlooked a feature?

Probably not, it need to dig into this. It seems to work fine for the default case (no "rust" link element).

I just tried this with the vanilla example:
<link data-trunk rel="rust" href="Cargo.toml" data-wasm-opt="z" data-bin="vanilla-example" data-integrity="sha384"/>

I get this:
<link rel="preload" href="/vanilla-example-5554b3fb0263ecc163a8c2b0186bdcb31d9fddfa44db6530a6999dce478e1fbd9bd49b619ad1f2810436b68c084cb3b2_bg.wasm" as="fetch" type="application/wasm" crossorigin="anonymous" integrity="sha384-VVSz-wJj7MFjqMKwGGvcsx2f3fpE22UwppmdzkeOH72b1JthmtHygQQ2towITLOy">
<link rel="modulepreload" href="/vanilla-example-5554b3fb0263ecc163a8c2b0186bdcb31d9fddfa44db6530a6999dce478e1fbd9bd49b619ad1f2810436b68c084cb3b2.js" crossorigin="anonymous" integrity="sha384-GhQUkuAgVkhAQOVN0EBEfiqgu4FIIWWolV9m84zBa_dcJ3j2I6KioIs9cxZFTI-s"></head>
<body>
    <script type="module">import init from '/vanilla-example-5554b3fb0263ecc163a8c2b0186bdcb31d9fddfa44db6530a6999dce478e1fbd9bd49b619ad1f2810436b68c084cb3b2.js';init('/vanilla-example-5554b3fb0263ecc163a8c2b0186bdcb31d9fddfa44db6530a6999dce478e1fbd9bd49b619ad1f2810436b68c084cb3b2_bg.wasm');</script>

The <script module> tag is inline. So a digest doesn't seem to make sense there. But the two included files are covered be the previous link elements.
For CSS and additional JavaScript snippets it's a different story. That's not (yet) covered.

I get the same, but the issue is when you enable in you CSP the checks, all scripts and stylesheets are ignored if they don't have it set. So also the type=module will be rejected because it does not have it.

Ok, I see that this will be an issue for the external content. That needs more time, or some helping hands (PRs).
For the type=module I would really double check if that's a case (do you have some kind of error report/failure). Because from what I read here, that's only for content which is "fetched":

Subresource Integrity (SRI) is a security feature that enables browsers to verify that resources they fetch (for example, from a CDN) are delivered without unexpected manipulation. It works by allowing you to provide a cryptographic hash that a fetched resource must match.

— https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity
And while it's not explicitly mentioned, the CSP policy also mentions values for *-src, which this tag doesn't have.
I am not saying that is the case, I didn't test. But I think it would be good to test, to be sure.

Is you have this in a branch I can do a check if this fixes the issues?

Yes, it's in the trunk-ng branch already.

I just pushed another commit, which enables this also for the snippets.

This was released with trunk-ng 0.17.14. Please let me know if there is more to be done.

I have an issue with the integrity checks of the wasm module.
When I run:
cat dist/kixz-app-ui-695b1ccbfb5a435a94e9e843fc370aef3215852814b2a662fb818c5a281cca99fa6b5577accf25cbc1a00c23154bea0f_bg.wasm | openssl sha384 -binary | openssl base64 => cmkr0nk99WBmV7l5Skco2msVPCcKUhkjxVv5suJWXKMd8hEhjYtoAd4y8pWaMHer.
But in the html it says: aVscy_taQ1qU6ehD_DcK7zIVhSgUsqZi-4GMWigcypn6a1V3rM8ly8GgDCMVS-oP.
The html include is:
 <link data-trunk rel="rust" data-integrity="sha384" data-bin="kixz-app-ui" />

Any idea why these checks are not the same?

Depends on which version of trunk you're using. IIRC there was an issue where wasm-opt wasn't considered and the digest was generated before running it. That should be solved in all releases of trunk (not trunk-ng).

Mixed up the repo. Looks like we can switch back again now most features are implemented 👍


Aggregation helpers

I tried a few different strategies. First I thought this would be a knex monkey patch, but no. It's a QueryBuilder update. I think the best strategy is to wrap whatever the knex query is rather than attempting to modify it by adding a .count() to it.
Example:
await User.rowsCount()

Produces
select count(*) as "total" from (select * from "users") as "__count"

That way, no matter how complex the original query is, it just gets turned into a subquery and a row count is returned.
Since this terminates QueryBuilder chaining without actually calling fetch(), I don't know what the implications are. Should I duplicate what the fetch() method does?

Related docs https://github.com/adonisjs/docs/pull/175

Coverage increased (+0.01%) to 96.767% when pulling 3df44dfd42066aab52bcc1a2ce63caa121dc344d on benallfree:aggregates into 38587fabc6b0f7387e198512bb76dd5795a6353e on adonisjs:develop.

Coverage increased (+0.03%) to 96.789% when pulling 561e6e447a09cb237f94a1fbbf86b26cf69ee327 on benallfree:aggregates into 38587fabc6b0f7387e198512bb76dd5795a6353e on adonisjs:develop.

Ready to merge along with https://github.com/adonisjs/docs/pull/175

Coverage increased (+0.03%) to 96.789% when pulling 67e73d70af826fcbd7ce4f8b909045c9ed860d5f on benallfree:aggregates into 38587fabc6b0f7387e198512bb76dd5795a6353e on adonisjs:develop.

Coverage increased (+0.03%) to 96.789% when pulling 00bcc206ea606df2cab60066f5e88245b676ab2e on benallfree:aggregates into 38587fabc6b0f7387e198512bb76dd5795a6353e on adonisjs:develop.

What you think of moving actual query builder methods from src/Lucid/QueryBuilder/index.js to src/Database/index.js.
This way it doesn't matter whether I am using Lucid or the actual query builder from Database provider.

I like it. And combine with docs here? http://dev.adonisjs.com/docs/4.0/query-builder#_aggregates

Yeah, move the docs there

Ok that was a good idea. I still need to update docs, but please take a look at this first.
One question I have... I don't understand why QueryBuilder needs to explicitly wrap these functions. https://github.com/adonisjs/adonis-lucid/pull/205/files#diff-13ef6d505395ea241aa8a59803cc7315R1347
await User.query().getCount() does call KnexQueryBuilder.getCount() but it returns the result from QueryBuilder.query (which is select * from users) instead of the result from getCount().

Hold on this..bad push

Coverage increased (+0.06%) to 96.816% when pulling 30bcf4532e9f428a039bfa8d0353ab0c203f80c0 on benallfree:aggregates into 05caeb32575151ac3c7110768793e69a71f29301 on adonisjs:develop.

Coverage increased (+0.06%) to 96.816% when pulling 2489d12a9c038261b16e60482aaeaa7c0520f002 on benallfree:aggregates into 05caeb32575151ac3c7110768793e69a71f29301 on adonisjs:develop.

Coverage increased (+0.05%) to 96.809% when pulling 67a67f722ccc0cc4d0eb60653cdb6a9c80f03af6 on benallfree:aggregates into 05caeb32575151ac3c7110768793e69a71f29301 on adonisjs:develop.

Coverage increased (+0.05%) to 96.809% when pulling b27aadeb2ab94902d2de9db7ec5542e902795984 on benallfree:aggregates into 05caeb32575151ac3c7110768793e69a71f29301 on adonisjs:develop.

Coverage increased (+0.04%) to 96.799% when pulling b5ea8a76d26fc77f8660adb49924c70715e78a5d on benallfree:aggregates into 05caeb32575151ac3c7110768793e69a71f29301 on adonisjs:develop.

Ok this is working great now.
@thetutlage Please carefully examine my change to https://github.com/adonisjs/adonis-lucid/pull/205/files#diff-254364470b0e90c9cfcca5ff2433e8f2. I made this change so I wouldn't have to add getXXX() wrappers to QueryBuilder. All tests pass, but I don't know if what I am doing is a good design. To me the "bug" behavior was the QueryBuilder was returning an instance of itself for chaining even if the underlying knex call returned a value and ended chaining.

Coverage increased (+0.05%) to 96.806% when pulling 02465ceb06586877e166d6fadbd347d1f5942990 on benallfree:aggregates into 05caeb32575151ac3c7110768793e69a71f29301 on adonisjs:develop.

Coverage increased (+0.06%) to 96.813% when pulling 139a276483a16037463dc5b6095fcdb30a3df7a1 on benallfree:aggregates into 05caeb32575151ac3c7110768793e69a71f29301 on adonisjs:develop.

Here you go https://github.com/benallfree/adonis-lucid/pull/1

Coverage increased (+0.08%) to 96.83% when pulling dd164aabd951b414b8db37dc6d8f6dbd72829b5b on benallfree:aggregates into 05caeb32575151ac3c7110768793e69a71f29301 on adonisjs:develop.

Coverage increased (+0.06%) to 96.813% when pulling 2099e6186fc41e6b79213a0e1ed20ce71ddbbf0b on benallfree:aggregates into 05caeb32575151ac3c7110768793e69a71f29301 on adonisjs:develop.

Coverage increased (+0.06%) to 96.813% when pulling 504ff1d6d408cdb98501f7be960dca5ad684419a on benallfree:aggregates into 05caeb32575151ac3c7110768793e69a71f29301 on adonisjs:develop.

Coverage increased (+0.07%) to 95.952% when pulling 19bebff4224246b0ba715db0c66d20d4bdd03a38 on benallfree:aggregates into dfc438cd66b5928c53e1e56e04a369acbf82c765 on adonisjs:develop.

Coverage increased (+0.02%) to 96.321% when pulling 1f1bff77d3d69f6fb38a2c3e5261c56a9db032ca on benallfree:aggregates into bb64d8c1bb2315ac6acc32487df751abf64899e9 on adonisjs:develop.

Coverage increased (+0.2%) to 96.526% when pulling 302b03eff7a5b2293e989bc729441bdaf1cfe990 on benallfree:aggregates into bb64d8c1bb2315ac6acc32487df751abf64899e9 on adonisjs:develop.

I addressed #226 too. Please review #226 notes and carefully review this commit, because I changed how aggregate queries are prepared. All tests pass, I think this is the way to go https://github.com/adonisjs/adonis-lucid/pull/205/commits/302b03eff7a5b2293e989bc729441bdaf1cfe990

Coverage increased (+0.4%) to 96.745% when pulling cb3571b3c4a9fc4dcf0fa44e1861afa401e4327d on benallfree:aggregates into bb64d8c1bb2315ac6acc32487df751abf64899e9 on adonisjs:develop.

Coverage increased (+0.4%) to 96.745% when pulling 50bbcefef906656b13343a5fd82ac42b8fca50cd on benallfree:aggregates into bb64d8c1bb2315ac6acc32487df751abf64899e9 on adonisjs:develop.

@benallfree Sorry it took a while to look into it. I 100% reviewed the PR, but there are some merge conflicts now, you can please fix them and I will merge it.
Also all code from develop inside merge conflicts is required, since that was added after your PR

Conflicts fixed, please give it one final check! :)

Coverage increased (+0.4%) to 96.711% when pulling 6a90dd907bbf1f7783961ea285851851dc38bfa9 on benallfree:aggregates into 01a6fa756ba22b3341c507d656959ad86f76cdea on adonisjs:develop.

Coverage increased (+0.4%) to 96.701% when pulling 6a90dd907bbf1f7783961ea285851851dc38bfa9 on benallfree:aggregates into 01a6fa756ba22b3341c507d656959ad86f76cdea on adonisjs:develop.

Thanks @benallfree for keeping the patience


Add namespace kwarg to Contaienr#merge

:+1:

I'm interested to know why you chose to use a proc for PREFIX_NAMESPACE instead of just a regular private method, @AMHOL?


Add ToBytes trait for colors

Hi! Thank you for helping out with Embedded Graphics development! Please:

[ ] Check that you've added passing tests and documentation
[ ] Add a simulator example(s) where applicable
[ ] Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, etc) and appropriate crate (embedded-graphics, simulator, tinytga, tinybmp) if your changes affect the public API
[ ] Run rustfmt on the project
[ ] Run just build (Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.

PR description
This PR adds an easier method to convert colors to byte arrays that was suggested in #423.

Do we want to allow into LE bytes as well? If not, we should at least clarify that the to_bytes is big endian in its docs, or even call it to_be_bytes to mirror Rust's core API IMO. There's also to_ne_bytes which we might want to consider too.

Oops, on looking again the endianness is indeed in the trait docs. My other points still stand though :)

Do we want to allow into LE bytes as well?

The original intention was to provide an easy method of creating a byte array which has the same layout as described by the type name. Rgb888::new(1, 2, 3) should be converted into [1, 2, 3]. And this is achieved by using big endian.
But you are right that it would be better to also support the other variants. I've added the additional functions and a note that to_be_bytes should be used to get the same memory layout as described by the type name.


CPU 100%

I just upgraded to Brackets 1.6 without Extract (from 1.5). But when I open the Brackets it gets really slow and eventually it does nothing and freezes. CPU usage shoots up to 100%. I tried to remove all the extensions and cache, but still the same thing.
I am using Linux Mint 64bit version.

 You could try https://github.com/zaggino/brackets-file-tree-exclude to alleviate some problems caused by node_modules, temporary files and other folders that potentially contain tons of stuff.

Well, it tried to open a directory with few html files only. No npm, bower or composer files...

Little update. It might not be a problem of Brackets. I installed 1.5 again and the problem remains. I'll try 1.4 or older and see.

I ran into the same problem on Ubuntu 15.  My CPU went to 100% percent, my laptop got super hot and shut off...  I'm running Brackets 1.6

Ok, weird. But I installed 1.4 that was OK, so I uninstalled it and installed 1.6 again and deleted Brackets config file in ./config/Brackets in my home folder and now it seems to work. So it's probably really a problem of some extension not playing nicely with 1.6 version. Because when I put original config folder back in place, Brackets starts to freeze after start again.

@instantaphex Do you have installed gruehle.exclude-folders extension? I did and now installed File Tree Exclude from link @petent sent. On their page, they say that old gruehle.exclude-folders is now not functioning. Some maybe that's the problem. Haven't tested though.

One more note. I've been using https://github.com/zaggino/brackets-file-tree-exclude and it helps to fix opening large projects.
Only one problem though. In the past, when I tried to open large project, Brackets gave me an error. Something like: "You are trying to open more than 30 000 files...", and just failed. But now, if I forgot to exclude some folders in my project and try to open it, Brackets freezes imediatelly after start and no error messages ever show up. Not sure whether it's a problem of Brackets itself or the extension above.


Need to tab select in select2

I want select2 selected option select in tab click time at select2 focusing time.

+1, and the up and down keys when focusing.

+1, this is in issue, you can not tab into select2, when multiple=false.  The text box should open to allow typing when tabbing to field.


[roi] ROIs could be refactored to avoid to recreate items all the time

Method _createPlotItems and _removePlotItems.
Items could be created only once and anchor only when switching to edit mode.

Closing, this is no longer be the case with current implementation.


Fixed issue #5463

Issue Reference
#5463
How To Test This?
Add a filter to the product or category page and then click on clear all

Fixed

@akathuria289
there is no need for the clear all  option If there is only one applied filer, please find the screenshot [Hee(https://prnt.sc/1-S2CPrRcT1S)
And the color of the clear all text should be blue.


feat: Allow switching between light clients

[x] Create a LightClient interface to be implemented by all wasm light clients
[x] Create a @substrate/light package which will hold light client of various chains
[x] Add a switching provider mechanism on the background scripts
[ ] Finalize UI to cater for switching providers (blocked by https://github.com/paritytech/Nomidot/pull/196)

Switching between providers works 🎉  This PR is ready for review.
The current behavior is:

Always load WsProvider to remote node at launch (temporary measure, just to be able to test)
On the top right side, choose another provider (extension's light client)
See the UI connect to the new provider (you need of course the extension running at the same time)

I would just want that nomidot PR to get in before merging.


QUESTION: "HAZING" (PHYSICAL HARM) as part of joining SCHOOL "FRAT" FRATERNITY/SORORITY?

in response to news reports of hazing incidents
--> leading to DEATH in CEBU and LAGUNA;
--> notes: March of Year 2023

QUESTION: "HAZING" (PHYSICAL HARM) as part of joining SCHOOL "FRAT"?
Cebu City incident; Marine Engineering
Laguna City incident; Chemical Engineering
Pattern? Engineering; EXCESSIVELY DIFFICULT
due to:  select subjects, e.g. Mathematics,
--> based on examination system;
Reference:
SAMPLE EXAMS; Engineering Students
OUTPUT#1: NEED of SAMPLE EXAMS,
--> where: questions shall be reused in ACTUAL EXAM;
--> objective: PASS EXAM
OUTPUT#2: "HAZING" as COST to receive SAMPLE EXAMS
--> where: COST's PRICE increased
--> via: "FRAT" groups opting NOT to share know-how without PAYMENT
--> where: COST : "HAZING" (PHYSICAL HARM)
Reminder: students NEED to PASS EXAMS,
--> due to: SALARY after accepted for EMPLOYMENT,
--> where: SALARY shared with current FAMILY UNIT
Additional Notes

LIST of "FRAT" members,
--> who: after graduation CAN provide "assistance"
--> where: "assistance" is of receiving JOBS/EMPLOYMENT

MANLOLOKO/SMUGGLER/CARNAPPER/BUDOL-BUDOL/LIAR group,
--> creates: FAKE "FRAT" group
--> executes: "assistance" to EVADE TAX,
--> via: showing that LIAR group controls LAW ENFORCEMENT,
--> e.g. TRAFFIC ENFORCERS;
--> example: Using TRAFFIC ENFORCERS' SCHEDULE,
--> TARGET is notified of "QUICKEST" PATH to destination,
--> notes: however, PATH has TRAFFIC ENFORCER
-->  to stop TARGET's vehicle;
--> LIAR group's objective: "LAHAT MUKHANG PERA
--> (ALL are IN-NEED of MONEY)";
--> adds: IF TARGET gives BRIBE, shall be used
--> to emphasize INCORRECT ACTION by TARGET,
--> when: TARGET attempts to NOT anymore obey LIAR group;

Related INFORMATION

LIAR group's "ARRANGED MARRIAGE" technique

From SCHOOL to WORK HABITS
--> continuous: NEED of "assistance";
--> OUTPUT: TAX EVASION via ILLEGAL ACTIONS,
--> e.g. SMUGGLING, INVASION of PRIVACY;
--> due to: NEED of QUICK MONEY

References

BULGAR Tabloid (Taon 31・BLG.087); 20230303
BULGAR Tabloid (Taon 31・BLG.086); 20230302


DCOS-48402 - Add new EnvironmentFiles to Mesos systemd units

High-level description
These three EnvironmentFiles will enable the setting of custom MESOS_DEFAULT_ROLE through the Universal Installer.
See Design Doc: https://docs.google.com/document/d/1-V_cyUJ9WL0OMmnguKheP0L11ZBrk-PaC9AoUCB8etk/edit#
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

[DCOS-49092] Add three new EnvironmentFiles to Mesos systemd units - JIRA

Related tickets (optional)
Other tickets related to this change:

Feature: [DCOS-47319] Configure custom mesos role with DC/OS Provisioner (install binary) on (some, not all) private agents at install time - JIRA
Epic: [DCOS-48454] Configure custom mesos role with DC/OS Provisioner (install binary) on (some, not all) private agents at install time - JIRA

Checklist for all PRs

[x] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change: we do not want to expose this to users for now, only use it through Universal Installer
[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and review process
What is the review process and when will my changes land?
All PRs require 2 approvals using GitHub's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@mesosphere-mergebot label Ready For Review

@mesosphere-mergebot override-status teamcity/dcos/test/test-e2e/group1 https://jira.mesosphere.com/browse/DCOS_OSS-4844


Bugfix for setType

Fixes a small copy and paste error.
Tests are already written/available. Why did they not fail?

Thanks, @podcasthosting!


[stable/metabase] Allowing nodePort to be specified

Signed-off-by: Yu Ichijo<EMAIL_ADDRESS>
Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

No
What this PR does / why we need it:
I have a Load balancer created by cloud provider.
And I want to fix the output port of the Load balancer.
This change allows one to fix nodePort in the values.yaml
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
No
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/ok-to-test
/assign

/lgtm


[Bug] Fix null map handling in BuildServiceForHeadPod function

Why are these changes needed?
This PR addresses a bug in the BuildServiceForHeadPod function where a nil map was not properly handled when building the head service for a Ray cluster. This caused a panic when attempting to add labels and annotations to uninitialized maps.
Changes include:

A fix in the BuildServiceForHeadPod function to correctly initialize the Labels and Annotations maps if they are nil.
A unit test that specifically tests the scenario of nil maps in the input HeadService.

With this fix, the function can safely handle nil maps and ensures that the Labels and Annotations of the head service are always properly initialized, which prevents runtime errors when attempting to modify these maps.
Related issue number

Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[ ] Manual tests
[ ] This PR is not tested :(

@kevin85421 I tested manually with this gist:
https://gist.github.com/architkulkarni/f137e6cba878c1908e15ce8c93dd0126
Ran the following commands:
kind create cluster
cd ray-operator
make docker-image
kind load docker-image controller:latest
cd ../helm-chart/kuberay-operator
helm install kuberay-operator --set image.repository=controller,image.tag=latest .
kubectl apply -f /Users/archit/kuberay/ray-operator/config/samples/ray-cluster.custom-head-service.minimal.yml
kubectl describe service custom-ray-head-service-name

The service was created successfully.  I then uncommented the custom labels and annotations and reran the commands, and I saw the labels and annotations upon running the final command.

Thank @architkulkarni for the update!


Fix: Toggling off Funding Cycle Duration now ensures the Funding Cycle is set to recurring

Comment left in code: If toggling off Funding Cycle Duration when set to "one-time", revert it to "recurring"

Adding additional content: UI issue caused a misconfiguration of the project where by the duration property was turned off and the recurring property was turned off locking the project owner from making any mods to project config.
See triage and bug report threads.

agree with the nit—there's probably a lot of room for improvement here. for now let's push this fix and come back to other changes in another PR


Long timeout when stats server is not accessible

In certain strict security environments the networking is such that the stats plugin can't even access the internet, unfortunately right now it 'hangs' while waiting for a timeout (I'm sure the corporate proxy is more to blame here for not following HTTP).

From CocoaPods/issues/4032

The hanging has been fixed by sending stats asynchronously and out of process on master already.

Oh, cool


Reference elixirkoans.io

We've been getting quite a lot of traffic on elixirkoans.io recently and we're combining efforts with other koan authors (including @iamvery whose koans are currently referenced on this page).
@iamvery I see that you've started to directing your users to elixirkoans.io on your repo already. Are you OK with this page doing the same? I want to make sure we're on the same page with this :)

Absolutely. You actually beat me to it :joy:

Bump

Ah, sorry, thought this was the same as the previous pull request! Merging now.


field name conflicts during lookups

Doing lookups across multiple resources that share a field name results in error like:
error calling lookup: multiple potential matches for Destination

Repro below:
samples/fieldNameCollision.hcl:
param "filename" {
  default = "hello.txt"
}

file.content "hello" {
  destination = "{{param `filename`}}"
  content = "hello"
}

file.mode "hello-mode" {
  destination = "{{param `filename`}}"
  mode = 0777
}

file.content "hello-log" {
  destination = "{{param `filename`}}.log"
  content = <<EOF
wrote         {{lookup `file.content.hello.destination`}}
with mode {{lookup `file.mode.hello-mode.mode`}}
  EOF
}

$ ./converge plan --local samples/fieldNameCollision.hcl
2016-09-22T08:45:22-04:00 |INFO| serving        addr=:47740 component=rpc
2016-09-22T08:45:22-04:00 |WARN| skipping module verification   component=client
root/file.content.hello-log got a non-unresolvable error: template: content:2:12: executing "content" at <lookup `file.mode.he...>: error calling lookup: multiple potential matches for Destination2016-09-22T08:45:22-04:00 |ERROR| could not render    component=rpc error=template: content:2:12: executing "content" at <lookup `file.mode.he...>: error calling lookup: multiple potential matches for Destination location=samples/fieldNameCollision.hcl runID=28149e45-08dc-4df3-9822-e2134523e527
2016-09-22T08:45:22-04:00 |FATAL| could not get responses       component=client error=error getting status response: rpc error: code = 2 desc = rendering samples/fieldNameCollision.hcl: template: content:2:12: executing "content" at <lookup `file.mode.he...>: error calling lookup: multiple potential matches for Destination file=samples/fieldNameCollision.hcl

Interestingly, I am not getting a collision when using file.directory even though it also shares a field named Destination. Maybe related to the different implementation of file.directory described in issue #292?
samples/fieldNameNoCollision.hcl:
param "filename" {
  default = "hello.txt"
}

file.directory "tmp-dir" {
  destination = "/tmp/hello"
  create_all = true
}

file.content "hello" {
  destination = "{{param `filename`}}"
  content = "hello"
}

file.mode "hello-mode" {
  destination = "{{param `filename`}}"
  mode = 0777
}

file.content "hello-log" {
  destination = "{{param `filename`}}.log"
  content = <<EOF
wrote     {{lookup `file.content.hello.destination`}}
in dir    {{lookup `file.directory.tmp-dir.destination`}}
  EOF
}

$ ./converge plan --local samples/fieldNameNoCollision.hcl
2016-09-22T09:01:04-04:00 |INFO| serving        addr=:47740 component=rpc
2016-09-22T09:01:04-04:00 |WARN| skipping module verification   component=client
2016-09-22T09:01:04-04:00 |INFO| got status     component=client file=samples/fieldNameNoCollision.hcl id=root/param.filename run=STARTED stage=PLAN
2016-09-22T09:01:04-04:00 |INFO| got status     component=client file=samples/fieldNameNoCollision.hcl id=root/file.directory.tmp-dir run=STARTED stage=PLAN
2016-09-22T09:01:04-04:00 |INFO| got status     component=client file=samples/fieldNameNoCollision.hcl id=root/file.content.hello run=STARTED stage=PLAN
2016-09-22T09:01:04-04:00 |INFO| got status     component=client file=samples/fieldNameNoCollision.hcl id=root/file.mode.hello-mode run=STARTED stage=PLAN
2016-09-22T09:01:04-04:00 |INFO| got status     component=client file=samples/fieldNameNoCollision.hcl id=root/file.content.hello-log run=STARTED stage=PLAN
2016-09-22T09:01:04-04:00 |INFO| got status     component=client file=samples/fieldNameNoCollision.hcl id=root run=STARTED stage=PLAN

root/file.directory.tmp-dir:
        Messages:
        Has Changes: yes
        Changes:
                /tmp/hello: "<absent>" => "<present>"

root/file.content.hello:
        Messages:
                hello.txt: File is missing
        Has Changes: yes
        Changes:
                hello.txt: "<file-missing>" => "hello"

root/file.mode.hello-mode:
        Messages:
                "hello.txt" does not exist
        Has Changes: yes
        Changes:
                hello.txt: "----------" => "-rwxrwxrwx"

root/file.content.hello-log:
        Messages:
                hello.txt.log: File is missing
        Has Changes: yes
        Changes:
                hello.txt.log:
                before:
                        <file-missing>
                after:
                        wrote     hello.txt
                        in dir    /tmp/hello

Summary: 0 errors, 4 changes

I'll look into it a bit this afternoon but I suspect that you're exactly right- because we can't pull the fields out of an interface there are no fields to actually collide.

fixed by #301


[embedded] Start flagging AllocRefDynamicInst usage in embedded Swift

IRGen for AllocRefDynamicInst uses the metadata to look up the size of the instance, but in embedded Swift we either don't have metadata at all (for structs), or they don't contain instance sizes (for class metadata). Let's start flagging AllocRefDynamicInst use in PerformanceDiagnostics to prevent IRGen compiler crashes or miscompiles.

@swift-ci please test

@swift-ci please test Windows platform

@swift-ci please test

@swift-ci please test


Using the Params of CNVW1A1

First of all if you dont know about this guide you can close this Issue.
Hi, im using this guide/tutorial from Xilinx:
https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/18841949/Zynq+UltraScale+MPSoC+Accelerated+Image+Classification+via+Binary+Neural+Network+TechTip
This Tutorial use a CNVW1A1 for Road Signs. I'm trying to change the weights and thres with another training, for example the params of BNN-PYNQ, but i saw some problems to  use it.
The params in this proyect ( /aic/src_hw/bnn-pynq-mpsoc/params/road-signs )have a different format that Params used in the Git of BNN-PYNQ( https://github.com/Xilinx/BNN-PYNQ/tree/master/bnn/params/road-signs/cnvW1A1 ) so, How can i make a training for this Tutorial or reuse the Params in BNN-PYNQ ?

Hi,
we do have support to generate weights for run-time updates, as shown in this repo, or to generate .h files to be used directly in the HLS code, thus fixing the values at compile time (in the bitstream).
The feature is not officially supported in this repo and not shown, but if you're willing to check it yourself the code call is just commented out in the script to export weights  like in lines 106 and 166.

Okay thank you so much, i will try it.


Fix resetting zone on exception [skipci]

Signed-off-by: Andy Neff<EMAIL_ADDRESS>

Do you need to do the same thing here:
https://github.com/VisionSystemsInc/terra/blob/70b9266215eee33fabc67a65b1ae4d74c5165c46/terra/executor/dummy.py#L33
I know that's just dummy code, but someone else might copy it as an example.


typo: recevie -> receive

@drewbatgit The PR passed the acceptance checklist. Please evaluate further and approve/complete the PR if appropriate. Thanks!


ScreenSpaceEventType.RIGHT_DOUBLE_CLICK does not work

As noted in this forum post.  We should either fix this or do as we've talked about in the past and deprecate ScreenSpaceEventHandler since it adds nothing to the public API (and recommend users just use standard mouse events).

I mostly agree, but I should clarify there is one thing that ScreenSpaceEventHandler does offer users:  It combines the separate mouse, touch, and pointer events that browsers currently use.  Perhaps this problem will take care of itself when browsers standardize someday, but for now touch will continue to be the only solution on iOS, and pointer events on IE, etc.  Using our event API is perhaps less cumbersome than implementing all three standards in user code.  Our own Sandcastle demos would need to deal with this, if ScreenSpaceEventHandler became private.

@emackey while your point is valid, I would argue that unifying input functionality is outside of the scope of Cesium.  Anyone writing an app should just use PEP or one of the other polyfills to unify input interaction (though PEP seems to have quickly become the de factor one).  The only reason we can't use a polyfill in Cesium is because we don't want to do anything that modifies the global scope.  We aren't anywhere near experts in web interaction and our users would be better served with a polyfill.

We may be straying off topic, but I have to offer a counterpoint here.  Cesium needs something internally to be able to offer support for mouse, touch, and pointer events for its own purposes.  If we force Cesium client apps to use anything other than what Cesium itself is using, that is going to lead to inconsistent app behaviors and generally bad UX.  I think we should encourage apps to use the same input system that Cesium itself uses, or allow them to somehow replace all of Cesium's input system.
That said, the current system is very badly organized (my fault for adding features organically to a previously simple design).  Someday I may take a shot at rewriting the input system, unless you think a polyfill could be incorporated into core Cesium to take its place.  I think a newly written system could be more unified, app configurable, with events-per-frame aggregation built in (which is a feature we use and need, that polyfills are unlikely to have).  We should build a roadmap.
This issue though is simple:  RIGHT_DOUBLE_CLICK will never work in a browser, and should be removed from the current API.

I think there may be a chance we can use PEP in Cesium without polluting the global scope.  Someone should definitely look into that.  It would allow us to code only against PointerEvents and remove all other handling.

I've confirmed that we can't use PEP in Cesium proper without modifying external state.  That being said, I think we should still consider using it anyway and changing Cesium to only work against the PointerEvent API.  Our lack of good unified support for touch/pointer/other input is becoming a more common problem on the forum every day.
I still think we should remove ScreenSpaceEventHandler from the public API, but we can certinaly provide default implementations for controls that people can wire up to events as they see fit.

Not that I would know, but this all sounds OK to me - can we submit a new issue or rename this one?

We should still remove RIGHT_DOUBLE_CLICK, regardless of making this private etc.
I'm fine with private APIs and PEP and whatever else.  Here's my main concern:  Cesium's default use of input events is almost overwhelming.  We use all three buttons for drag, we use the primary click, we use modifier keys, and touch, tap, and three forms of two-finger touch, all by default.  I feel we have to throw the app devs a bone here.  We can't expect them to just wire up whatever input they feel like, without the slightest integration with the system Cesium already imposes on them.  We need to give them good control over Cesium's mapping of input events to actions, and freedom to add their own custom actions among that mapping, such that the newly added actions "feel" like they integrate smoothly with Cesium's extensive input handling.

MIDDLE_DOUBLE_CLICK is also not working for me anymore.

"Double" clicking is a relic of the desktop icon era, not modern UX for the age of mobile and touch input.

If removing it is the right move, let's do it.

I started to remove these from the 3d-tiles branch. What would the deprecation timeline look like if this were removed from master?

1 release should be OK; I don't think this is widely used.


RESEARCH: Search within libraries

Description
This research explores the effort required to offer residents the ability to search the contents of a specific library for specific keywords.
If you visit library.kiwix.org and navigate to a library you’ll see a search box is available

You can see what the results look like. Search: experiment. We want to offer a capability like this to Residents so it becomes easier for them to locate information inside of these ZIM files.
Ideally the research addresses:

If we can leverage the existing search that Kiwix offers or need to build our own.
What search interface we add to UnlockEd for users.
How to continue to log/track links and libraries that the user accesses.

The outcome of this research will be a draft issue outlining the implementation approach, including task breakdowns for development.
Note: There is a separate issue that involves looking into RESEARCH: Search across libraries.
Tasks

[x]  Explore options that Kiwix already offers for search
[x]  If necessary, explore alternative options for searching libraries.
[x]  Determine what changes need to be made to the Knowledge Center page/components to support searching within libraries.
[x]  Identify API changes or additions that need to be made for Knowledge Center search.

Acceptance Criteria

A detailed draft GitHub issue is created, outlining the proposed approach and effort for implementing “Search within Libraries” based on the research here.
The draft issue includes:

Whether or not we can build off of the Kiwix implementation of search.
Backend and frontend development tasks with clear objectives (e.g., components, API handlers, migration changes needed, etc.)
Identified risks or challenges that we foresee would come with this integration path.
Options that we considered and chose not to do.

The issue also identifies if there are any dependencies (e.g., technical debt or other issues) that must be addressed before implementing search.

Created draft issue per Chris:  https://github.com/UnlockedLabs/UnlockEdv2/issues/585
Also created gist with same info:  https://gist.github.com/carddev81/8c0faba3101293724442c7a54fb95ea7


Adding fixed script

Purpose

Resolving issues with archived script, adding the storageAccountId variable, and putting it in the right command.
https://github.com/Azure/azure-docs-powershell-samples/blob/master/virtual-machine/create-managed-disks-from-vhd-in-different-subscription/create-managed-disks-from-vhd-in-different-subscription.ps1
Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type
What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

@roygara Is this sample used in a doc? If so, please note that the out-of-repo reference is azure_powershell_scripts. powershell_scripts points to the archived repo.
For example: :::code language="azurepowershell" source="~/azure_powershell_scripts/<path-to-sample.ps1>"
Let me know when you're ready for the archived version to be removed.
Thank you!


python311Packages.fastapi-mail: 1.2.8 -> 1.3.0

Changelog: https://github.com/sabuhish/fastapi-mail/releases/tag/1.3.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 239870 run on x86_64-linux 1

4 packages built:

python310Packages.fastapi-mail
python310Packages.fastapi-mail.dist
python311Packages.fastapi-mail
python311Packages.fastapi-mail.dist


TVM support in APPLib added

TVM support in APPLib added

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fixed IndexOutOfRange error in DocketReport::_set_metadata_values method

Court: District of New Jersey
Case Number:	2:23-cv-01194
Pacer CaseID:	509180
Court Code: njd

For this case docket report page has different format.

This difference causes Index out of range error because function expects Date Filed instead of Filed Date.
Added Filed Date as alternative to xpath() method

I went ahead and merged, but a test case would prevent this from regressing. Want to add one?

Sure, I will do that.
But when I run tox command, I get this error:
UserWarning: Unknown distribution option: 'test_suite'
  warnings.warn(msg)
usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
   or: setup.py --help [cmd1 cmd2 ...]
   or: setup.py --help-commands
   or: setup.py cmd --help

error: invalid command 'test'

The output of python setup.py --help-commands is:
lezh1k@lezh1k-laptop juriscraper_lezh1k_fork ±|main ✗|→ python setup.py --help-commands
/home/lezh1k/.local/share/virtualenvs/juriscraper_lezh1k_fork-0HyxVOno/lib/python3.12/site-packages/setuptools/_distutils/dist.py:268: UserWarning: Unknown distribution option: 'test_suite'
  warnings.warn(msg)
Standard commands:
  build             build everything needed to install
  build_py          "build" pure Python modules (copy to build directory)
  build_ext         build C/C++ extensions (compile/link to build directory)
  build_clib        build C/C++ libraries used by Python extensions
  build_scripts     "build" scripts (copy and fixup #! line)
  clean             clean up temporary files from 'build' command
  install           install everything from build directory
  install_lib       install all Python modules (extensions and pure Python)
  install_headers   install C/C++ header files
  install_scripts   install scripts (Python or otherwise)
  install_data      install data files
  sdist             create a source distribution (tarball, zip file, etc.)
  register          register the distribution with the Python package index
  bdist             create a built (binary) distribution
  bdist_dumb        create a "dumb" built distribution
  bdist_rpm         create an RPM distribution
  check             perform some checks on the package
  upload            upload binary package to PyPI

Extra commands:
  testnetwork       run isolated tests that hit the network
  alias             define a shortcut to invoke one or more commands
  bdist_egg         create an "egg" distribution
  bdist_wheel       create a wheel distribution
  develop           install package in 'development mode'
  dist_info         DO NOT CALL DIRECTLY, INTERNAL ONLY: create .dist-info directory
  easy_install      Find/get/install Python packages
  editable_wheel    DO NOT CALL DIRECTLY, INTERNAL ONLY: create PEP 660 editable wheel
  egg_info          create a distribution's .egg-info directory
  install_egg_info  Install an .egg-info directory for the package
  rotate            delete older distributions, keeping N newest files
  saveopts          save supplied options to setup.cfg or other config file
  setopt            set an option in setup.cfg or another config file
  upload_docs       Upload documentation to sites other than PyPi such as devpi

usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
   or: setup.py --help [cmd1 cmd2 ...]
   or: setup.py --help-commands
   or: setup.py cmd --help

Anything I missed from README?

Looks like the best way to run tests is here: https://github.com/freelawproject/juriscraper/blob/main/.github/workflows/tests.yml
I'd try following that? I'm not sure we even use tox anymore, actually...maybe we should remove it. @grossir, do you know or have an opinion?

Pytest is totally fine. I'll make new PR once I finish with this, thank you.

Finally added this html to tests.
Please, take a look:  https://github.com/freelawproject/juriscraper/pull/1125.


[BUG] count(distinct float_col) produces different results from CPU, for Float columns with NaNs

The following was discovered as part of the tests added in #181
SELECT a,
       COUNT(DISTINCT float_col)
FROM mytable
GROUP BY a

If long_col has NaN values, the COUNT returns a value different from that on CPU.
Note to self: Check that the DISTINCT involves normalization for NaN/0.

That was quick, PR is up for review: apache/spark#28876

Uh-oh!
https://github.com/apache/spark/commit/92f3877b0f4451100ba2aa6cac6b66900f870951
@abellina, it appears that your user-id and mine were checked in as part of the test code. :]

That's it for us @mythrocks, we need to change our names. That said, it all seems OK now:
scala> spark.sql("select uid, count(distinct score), count(score) from mytable group by uid order by uid asc").explain
== Physical Plan ==
*(4) Sort [uid#2 ASC NULLS FIRST], true, 0
+- Exchange rangepartitioning(uid#2 ASC NULLS FIRST, 10), true, [id=#239]
   +- *(3) HashAggregate(keys=[uid#2], functions=[count(1), count(distinct knownfloatingpointnormalized(normalizenanandzero(score#3))#105)])
      +- Exchange hashpartitioning(uid#2, 10), true, [id=#235]
         +- *(2) HashAggregate(keys=[uid#2], functions=[merge_count(1), partial_count(distinct knownfloatingpointnormalized(normalizenanandzero(score#3))#105)])
            +- *(2) HashAggregate(keys=[uid#2, knownfloatingpointnormalized(normalizenanandzero(score#3))#105], functions=[merge_count(1)])
               +- Exchange hashpartitioning(uid#2, knownfloatingpointnormalized(normalizenanandzero(score#3))#105, 10), true, [id=#230]
                  +- *(1) HashAggregate(keys=[uid#2, knownfloatingpointnormalized(normalizenanandzero(score#3)) AS knownfloatingpointnormalized(normalizenanandzero(score#3))#105], functions=[partial_count(1)])
                     +- *(1) LocalTableScan [uid#2, score#3]

scala> spark.sql("select uid, count(distinct score), count(score) from mytable group by uid order by uid asc").show
+--------+---------------------+------------+
|     uid|count(DISTINCT score)|count(score)|
+--------+---------------------+------------+
|abellina|                    2|           2|
| mithunr|                    1|           4|
+--------+---------------------+------------+

And the original case:
scala> spark.sql("select uid, count(distinct score) from mytable group by uid order by uid asc").explain
== Physical Plan ==
*(4) Sort [uid#2 ASC NULLS FIRST], true, 0
+- Exchange rangepartitioning(uid#2 ASC NULLS FIRST, 10), true, [id=#319]
   +- *(3) HashAggregate(keys=[uid#2], functions=[count(distinct knownfloatingpointnormalized(normalizenanandzero(score#3))#145)])
      +- Exchange hashpartitioning(uid#2, 10), true, [id=#315]
         +- *(2) HashAggregate(keys=[uid#2], functions=[partial_count(distinct knownfloatingpointnormalized(normalizenanandzero(score#3))#145)])
            +- *(2) HashAggregate(keys=[uid#2, knownfloatingpointnormalized(normalizenanandzero(score#3))#145], functions=[])
               +- Exchange hashpartitioning(uid#2, knownfloatingpointnormalized(normalizenanandzero(score#3))#145, 10), true, [id=#310]
                  +- *(1) HashAggregate(keys=[uid#2, knownfloatingpointnormalized(normalizenanandzero(score#3)) AS knownfloatingpointnormalized(normalizenanandzero(score#3))#145], functions=[])
                     +- *(1) LocalTableScan [uid#2, score#3]

scala> spark.sql("select uid, count(distinct score) from mytable group by uid order by uid asc").show
+--------+---------------------+
|     uid|count(DISTINCT score)|
+--------+---------------------+
|abellina|                    2|
| mithunr|                    1|
+--------+---------------------+

That said, it all seems OK now:
Yep. The Rapids Plugin had this right. I'm closing this out. Thanks, @abellina.

I'll raise a separate PR to introduce a conditional xfail test for DISTINCT aggregations.

I'll raise a separate PR to introduce a conditional xfail test for DISTINCT aggregations.

NVIDIA/spark-rapids#261


Names must match /^[_a-zA-Z][_a-zA-Z0-9]*$/ but "oauth-type" does not.

Strapi Version 4.4.0
After I installed this package to my strapi, I got this issue "Names must match /^[_a-zA-Z][_a-zA-Z0-9]*$/ but "oauth-type" does not."
Can you guys help to find what exactly the problem?
https://capture.dropbox.com/kJHleEF83uNLQLG0

@odera89
Hello, thank you for getting back to us.
I see that you are using GraphQL.
It seems to me that the problem is caused by the use of hyphens in the plugin.
If you give us a little more time, we will try to find a solution here.
In that case, you probably need to increase the version of the plugin.

Thank you for the fast reply, I will wait sure. You mean to upgrade my strapi to a higher version?

@odera89
No, I am considering modifying the plugin.
I am not familiar with Strapi's GraphQL as I have never used it, but at what point does this error occur?

installed this plugin with sso
added lines to the config plugins.js
npm run strapi develop and error, doesn't start the strapi. so when i want to run the strapi...

Okay, I understand the situation.
Please give us 1-2 days to fix it.

@odera89
I had time to do it, so I fixed it now.
Could you please upgrade the plugin version and try it?
The latest version is 0.1.6

I had a bit time, and i checked. Thank you so much. It works very well. You have a beer :) I think you can close this ticket.


Compile error

Thank you for your great project.
When I compile this project, it shows:
unable to execute ':/usr/local/cuda/bin/nvcc': No such file or directory
error: command ':/usr/local/cuda/bin/nvcc' failed with exit status 1
my environment is: ubuntu18.04, python3.6.9, pytorch-1.4.0, cuda10.0. When I run other projects on the same platform, it is ok.
I don't know why this issue happens, could you show me your environment settings please? Thank you very much!

It seems you didn't install cuda. You can try "nvcc" to check whether it's installed.

Thank you for your great project. After I run setup.py and it successfully compile the Guideconv lib, I run train.py and it shows the error:
File "/home/xth824/GuideNet-master/models.py", line 17, in
import encoding
ModuleNotFoundError: No module named 'encoding'
How can I fix this issue? Thanks very much.

@xth3000 You need to install the package PyTorch-Encoding

Thx for your reply!
ImportError: /home/xth824/.cache/Python-Eggs/GuideConv-0.0.0-py3.7-linux-x86_64.egg-tmp/GuideConv.cpython-37m-x86_64-linux-gnu.so: undefined symbol: cudaSetupArgument
How can I fix this issue? Thanks very much.


Add Upsert for services

Why don't you have upsert for your services. This is a very import feature for syncing data, and that is all I need this gem for is syncing information to base.

I also would love upsert support. Sometimes I have an error when making calls and I end up creating hundreds of copies of the same Lead for our sales team.
Upserts would solve that problem.

+1

+1

Any updates from the team when/if this will be available for services?

@struniu @kcht hi 👋 tagging you two as the most recent contributors - we're looking to use the upsert feature of the the Deals and Contacts endpoint, but its not available in the gem. Im looking to add it but wondering
a) is it anywhere on a roadmap for this gem in the next few months
b) if forking and sending a PR it to add to services is safe to do so as the code mentions it is autogenerated here https://github.com/zendesk/basecrm-ruby/blob/master/lib/basecrm/services/deals_service.rb#L1
Thanks!

Ive added a PR to make a start on this https://github.com/zendesk/basecrm-ruby/issues/52