chore: Rework CrateGraph to only have one root crate

Description

Problem*

Towards #2238
Summary*

This reworks the CrateGraph to only have one root crate. This allows us to lookup the root crate when building an ABI for it. I also cleaned up the Dummy case so we aren't storing a std::usize::MAX for each dummy id.
This significantly cleans up my prototype solution in #2374
Documentation

[ ] This PR requires documentation updates when merged.

[ ] I will submit a noir-lang/docs PR.

[ ] I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

RE, Results versus panicking, I think we can create another issue to return results here and panic further up the stack or possibly not panic and keep bubbling it up the stack -- We were already panicking which is why I think its okay to leave that for another PR


Implement support to the RESPONSE_* variables in libmodsecurity

The following variables needs to be implemented inside libModSecurity:

RESPONSE_PROTOCOL
RESPONSE_STATUS

More information about these variables can be found at ModSecurity reference manual: https://github.com/SpiderLabs/ModSecurity/wiki/Reference-Manual

All RESPONSE_ variables should be supported:

RESPONSE_BODY
RESPONSE_CONTENT_LENGTH
RESPONSE_CONTENT_TYPE
RESPONSE_HEADERS
RESPONSE_HEADERS_NAMES
RESPONSE_PROTOCOL
RESPONSE_STATUS

Implemented.


rRNA export from nucleus

rRNA export from nucleus
I'm still wondering if this term should exist?
Are rRNAs ever exported when they are not part of the ribosome precursors?
So we annotate in 2 ways:

https://github.com/geneontology/go-ontology/issues/11457

There are several terms:
GO:0006405 RNA export from nucleus
[is_a relation] GO:0006406 mRNA export from nucleus
[is_a relation] GO:0097064 ncRNA export from nucleus
[is_a relation] GO:0035281 pre-miRNA export from nucleus

some regulation terms.

Are you proposing to obsolete the entire branch? I suppose these may be various substrates of the same process?

No, i'm not proposing to obsolete the entire branch.
The ones you list above are exported independently as RNAs. rRNA is different, it is only exported as part of the related preribosomal complex.
I don't see a difference between
descendants of
GO:0071426 ribonucleoprotein complex export from nucleus
I clearly uploaded the wrong image here!
You can assign this to me because it will need to be assessed as part of the whole surveillance and export picture which I am still trying to understand. It's incredibly complicated.
I'm collecting potential problems I notice so that they can all be included in the solution.

GO:0071426 ribonucleoprotein complex export from nucleus

was obsoleted 2 years ago https://github.com/geneontology/go-ontology/issues/22246

Sorry I meant more specific  terms:
https://www.ebi.ac.uk/QuickGO/term/GO:0000054
ribosomal subunit export from nucleus
Is the rRNA ever exported when it is not part of the ribosome biogenesis pathway? I don't think so but I'm not 100% sure.
These seem to be describing the same thing:

interestingly, 21/26 of the EXP annotations to "rRNA export from the nucleus"  are to ribosomal proteins....

@pgaudet  any thoughts on this?
@krchristie  might know.
Summary, I am assuming that ribosomal RNA are only exported when assembled into pre ribosomes and there is no pathway for just rRNA export, is this the case?

@ValWood - My recollection is that rRNA is processed during ribosome assembly in the nucleolus and thus not exported from the nucleus until the ribosomal subunits are exported.
Regarding other types of RNAs, I doubt that all of the other RNAs are exported as pure RNAs. Many RNAs are protected by being folded into complexes with proteins. For example, snRNAs, e.g. U1, U2, etc., are folded into snRNPs and it seems more likely to me that this happens in the nucleus than exporting an uncoated RNA into the cytoplasm. I think mRNAs may have proteins that travel with them from the nucleus to the cytoplasm as well. Basically, I doubt there is much free RNA being exported from the nucleus unless the structure is capable of folding into a stable protected structure.
I would think that tRNAs probably are exported as a folded RNA and I'm not aware of any need for a protein component to protect or maintain the folded structure for those. I could ask Harold Drabkin to check on that.

Since we already have this term:

ribosomal subunit export from nucleus - GO:0000054

it might be good to make "rRNA export from nucleus" from nucleus a RELATED synonym

I think that makes sense.

Please provide as much information as you can:
Reason for deprecation Put an x in the appropriate box:
The reason for obsoletion is that the term is redundant with [GO:0000054] ribosomal subunit export from nucleus
(rRNA is not know to exit the nucleus unless part of the preribosome)
"Consider" term(s) (ID and label)
Suggestions for reannotation
Annotations will be migrated to
ribosomal subunit export from nucleus - GO:0000054

Checklist for ontology editor
Check term usage and metadata in Protégé

[ ]  check term usage in the ontology
[ ]   check internal mappings: RHEA, EC, MetaCyc
[ ]   check subset usage
[ ]   check taxon constraints
Check annotations

create Annotation Review spreadsheet
Annotation Review template: https://docs.google.com/spreadsheets/d/1izV3q1jnq_Ybg5MJ53O_b5BCTkGtjl_Fi-cOg3-7eBE/edit#gid=0
Instructions: https://wiki.geneontology.org/Annotation_Review_Request
create annotation review ticket: https://github.com/geneontology/go-annotation/issues/new?assignees=&labels=annotation+review&template=annotation-review-for-obsoletion.md&title=Review+annotations+to+[INSERT+GO+TERM]
find external mappings (via IEAS), include in obsoletion notice
tag curators in Annotation Review ticket. Responsible annotator for each group: https://github.com/geneontology/go-site/blob/master/metadata/group-contacts.csv
Notification
create obsoletion announcement
announce to GO friends<EMAIL_ADDRESS>paste the text in the ontology ticket


test(state): add TestHelmState_setStringFlags for setStringFlags method

This pull request includes a new test function to the pkg/state/state_test.go file. The new function, TestHelmState_setStringFlags, tests the setStringFlags method of the HelmState struct.
New test function:

pkg/state/state_test.go: Added TestHelmState_setStringFlags to test various scenarios for the setStringFlags method, including single value, multiple values, and rendered value error cases.

/cc @zhaque44


fix(eslint): address warnings

This PR addresses the problem of eslint warnings for our repo: there were 55 warnings previously reported:

These warnings are turning into errors in production environment (NODE_ENV being equal to production), and this has prevented us from running CI scripts agains PROD. Now the issue is fixed.

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS


ASS Fixes - All-in-One

The other PRs might not all build and in order to save you from combining all the pieces, this is the full range of ASS fixes combined  in a single PR (not for merging).

A bit of branch management here:
This PR should target winui-build branch, as that's where we split the config file into smaller configuration classes.
If you merge this you will break master.
@lukasf  I am personally happy with the winui-build branch, been using it in my own app, and I think that can go for the merge, if we find other smaller bugs we could just fix them individually. We can distribute a preview version of the next version in nuget and prepare for  stable release maybe around April?

I would recommend creating the branches directly in this repo, you should be able to do so, so you do not need to keep your version in sync.

AFAIK, only members of a repository can create branches and only when they have been assigned a role which allows this.

 You should have the same rights as me.

 You should have the same rights as me when it comes to branching.
Give it a try.

Pushing submit_ass_fixes_all
Remote: Permission to ffmpeginteropx/FFmpegInteropX.git denied to softworkz.
Error encountered while pushing to the remote repository: Git failed with a fatal error.
Git failed with a fatal error.
unable to access 'https://github.com/ffmpeginteropx/FFmpegInteropX.git/': The requested URL returned error: 403

A contributor doesn't have push rights to a repository. You need to be added as a collaborator with at least Write access:

Then you get an invitation which you can accept or deny. Hence I was pretty sure that I don't have the permission (no invitation) 😄

Well, then you're gonna have to do this the hard way :)

Why hard? There's not really a difference whether a PR branch is in my own repo or here.

You based the branch on master branch but the code seems to be written to work with the winui-build branch. Can you build your branch in your repo?

@softworkz I have invited you as member of this repo with write access. Feel free to join. It would make it easier for us to test your PRs and collaborate on them, if they are created directly on this repo, instead of being on a fork of yours.
@brabebhin Why do you think that this needs to be done on the WinUI branch? The WinUI branch only contains some fixes for sub flickering. It should not affect any of these styling/layout related things. I think all the ASS improvements can continue to target the main branch.
For the current state of the WinUI branch: I don't think that this is ready to merge yet. It contains UWP, WinUI and Desktop build configs. But we decided that we don't want/need a WinUI build config, only UWP and Desktop. The Desktop build config should get an optional HWND (IntPtr) parameter, so we can get the WindowId from that, if we are running on WinUI. That way, we can ship without WinUI dependency, but still use WinUI (especially for HDR detection) if we run in a WinUI context. Additionally, the NuGet packages are not how they are planned. So there is still some work to do over there.

@lukasf
Because the winui-build branch contains the split configuration classes, which are used in this PR.

The Desktop build config should get an optional HWND (IntPtr)

I thought we already did this. Guess I need to check the code again xD

@softworkz I have invited you as member of this repo with write access. Feel free to join. It would make it easier for us to test your PRs and collaborate on them, if they are created directly on this repo, instead of being on a fork of yours.

Great. Thanks!

Edit: You don't need to transfer all PRs. But it would help if you could push the all-in-one PR to a local branch over here, for simplified testing.

Transferring is not a big thing with a good Git client. But I guess I'll have to rebase them. I had somehow thought that the configuration split would already be in the main branch, that's why I thought it would be better not to load more and more things onto the winui branch.
Please let me know with which branch you want to proceed with this, then I'll rebase all PRs and the all-in-one one. (one one one... 😆 )

superceded by #410


docs: correct path of examples link.

What I did

Corrected the path of the examples link.

thaaankkk you 🙇♂


Typo in feature gates page: “fine-tuing”

This is a Bug Report

:information_source: If you have already worked on a docs issue for Kubernetes, you should strongly consider leaving this good first issue for someone who has not.

Problem: The feature gates page has a typo in it, repeatedly: “fine-tuing”
Proposed Solution:

find files within content/en/docs/reference/command-line-tools-reference/feature-gates/ that contain the typo
correct the spelling

Page to Update:
https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/

Additional Information:
/language en
/good-first-issue

/triage accepted

We have a policy of “no cookie licking”. Anyone is welcome to open a pull request that fixes this - and @dev-johnn I hope you will do so. See https://kubernetes.io/docs/contribute/docs/ for extra guidance.
It's polite to mark when you start work, just like @dev-johnn has; if another contributor wants to work on this as well, you can - but the polite thing to do is to liaise with the person who's already working on that. Maybe they are already well on their way to submitting a change.
Welcome to Kubernetes docs @dev-johnn.

Hey , I'm a first time contributor , can i take up this issue if it hasn't been already solved?

@hiirrxnn you should read https://github.com/kubernetes/website/issues/44625#issuecomment-1876129669 which covers your question.
TL;DR: yes, but it might be a bit unhelpful if you do.

Okay , are there other good first issues that i can work on ?

@hiirxnn to find issues labelled as “good first issues”, start from https://github.com/kubernetes/website/issues?q=is%3Aissue+is%3Aopen+label%3A"help+wanted"
(this includes all languages, so you might want to filter it further, and it also includes issues where people have said they have begun work)

Hey, @dev-johnn!
How is it going on?


UPSTREAM::move to test pkg to avoid linking test flags in binaries

Give this a shot and regen completions

Yep, that did the trick! Cherry-picked in the rebase PR, thanks!


When groups are synced using config-cli, all remote groups are removed

Current Behavior
By default we have remote state enabled for the config-cli, but when using groups, the remote groups are removed when running the sync. So, I have one config which should sync 2 groups, after the cli runs, all remote groups are removed.
Expected Behavior
Because the remove state is enabled, the remote groups should not be removed. Only the changed / added groups should be affected. Especially important in a microservice architecture, where each service would own part of the realm configuration, so it should not affect all other configuration.
Steps To Reproduce
1. Add manually one group inside a realm
2. Add in the cli config another group
3. Run the config-cli with the above configuration from point 2
4. The initial added groups from point 1 are removed.

Environment

Keycloak Version: 18.0.2
keycloak-config-cli Version: 5.5.0
Java Version: 17.0.5

Anything else?
No response

Found in the code the problem. Was not aware we could setup --import.managed.group=NO_DELETE, which will not delete the existing groups. By default it will delete them, but can be configured to not.


Packer extraconfig plugin [Feature Request/bug]

Plugin affected: plugins.packer
Nixpkgs channel: N/A
Home-manager version: N/A
Description
Not entirely a bug-report, more a feature request, but installing simple plugins with packer is easy, but anything that is more than one line creates errors. the way I would like to use it, is to allow packer plugins to be a set, where you then have extra config options.
as an example: here is a plugin i would like to install, and the recommended way to do so is:
use {'tpope/vim-dispatch', opt = true, cmd = {'Dispatch', 'Make', 'Focus', 'Start'}}

but i cannot simply add this to the packer.plugins as a string, as it wont get recognized as lua.
I instead suggest adding another option that takes a list of sets, and converts them into its own use(, )
packer = {
  enable = true;
  plugins = [
    "nvim-lua/plenary.nvim"
    "MunifTanjim/nui.nvim"
    "nvim-telescope/telescope.nvim"
    {
       name = "tpope/vim-dispatch";
       extraConfig = ''
         opt = true,
         cmd = {'Dispatch', 'Make', 'Focus', 'Start'}
         # Extra config for the plugin
       '';
    }
  ];
};

Hopefully this isn't a big-ask, and i might try my hand at implementing it myself, but im somewhat new to this.
Thanks for developing the fantastic project i hope to see it grow!

Was just running into this same problem with silicon.nvim, it requires a 'run' option, but that doesn't seem to be possible in the current iteration of nixvim.

I made an update to the packer module.
It now supports all of the keys that you might want to use.
You will be able to find several examples here: https://github.com/pta2002/nixvim/blob/e89d919e4da844137b060c7bc7dc930c7e098d3c/tests/plugins/packer.nix

For completeness's sake, is  there any reason you still use packer ? nixvim should implement everything packer does more tightly into nixos I think.

For completeness's sake, is there any reason you still use packer ? nixvim should implement everything packer does more tightly into nixos I think.

good point, i should look into how to better integrate with nix, but, for quick testing of a plugin or just not wanting to bother with setting something up long term. I think its nice to have the ability to use packer.
im still figuring everything out. just out of curiosity, how would you suggest installing such a plugin with nixvim?

just out of curiosity, how would you suggest installing such a plugin with nixvim?

Either it has already been packages, and then, you can do:
programs.nixvim = {
  plugins.foo = {
    enable = true;
    optionA = valueA;
    ...
  };
};


Add Hello There with TypeScript

Add the TypeScript code that would display Hello There! on screen.
Follow the instructions on Contribute file to add a TS version of "Hello There!".

Check to see if the language has a been assigned yet.
If the issue has not been assigned, ask to be assigned that language.
This is mainly meant for new to development people so please leave the issues for them.

Once assigned.

Fork this repository.
Clone the forked repository to your machine.
Create a new branch titles Hello_There.extension, with the extension being the language you are adding. (EX Hello_There.ts)
Write the code for Hello There! in the chosen language.
Add a comment with a link to documentation.
Push the code and open a pull request.

Hey, I have added Hello There in Typescript, please check it once...!!


Fastroute with make wire parasitics

Fixes #3039.
Currently the slack is estimated on the beginning of global routing, and never considers the changes made during the fastroute that can make a non-critical net to become one with a large detour from their original routing.
This changes update the slack estimates during the fastroute when the critical_nets_percentage is set, also for the nets in the critical percentage if they have a large detour from their original routing and weren't chosen for a rip up, decrease their search area and select them to be re-routed so they have another chance to get a routing closer to their original.

It feels like this option should be on by default, and have an option to turn it off.

It feels like this option should be on by default, and have an option to turn it off.

Currently the slack is only considered if the critical_nets_percentage is set, so I decided to keep this property, but it culd be added a default percentage.

There is a public design failing and it is on investigation.

Is this resolved?  Has this been through secure CI?  Is there a default percentage?

There is a public design failing and it is on investigation.

Is this resolved? Has this been through secure CI? Is there a default percentage?

The public design failing was resolved, and it has been through a secure CI, I am waiting for @eder-matheus report on this run. As a default perecentege I didn't look that much into it, but for the test case attached to the issue 5% of critical nets seemd to be the best alternative, the secure run also used 5%.

There is a public design failing and it is on investigation.

Is this resolved? Has this been through secure CI? Is there a default percentage?

The public design failing was resolved, and it has been through a secure CI, I am waiting for @eder-matheus report on this run. As a default perecentege I didn't look that much into it, but for the test case attached to the issue 5% of critical nets seemd to be the best alternative, the secure run also used 5%.

We actually have 2 separate runs in the CI. When using the default percentage of 0% (i.e., the updates from this PR are not executed), public and private CI are passing.
When using 5%, we still have some metric failures.
From the CI side, I'm fine with merging this PR and do the fix for the matric failures with 5% in a future PR.

From the CI side, I'm fine with merging this PR and do the fix for the matric failures with 5% in a future PR.

agreed


dcos_installer: Don't run genconf validation twice [1.10 backport]

High Level Description
1.10 backport
When a user runs ./dcos_generate_config.sh they'll get messages produced by gen package twice, i.e.
====> EXECUTING CONFIGURATION GENERATION
Generating configuration files...
Generating configuration files...

This patch is a minimal change that prevents dupes in the logging output. This PR addresses the issue discovered in https://github.com/mesosphere/dcos-enterprise/pull/1391#issuecomment-327164903
Related Issues

DCOS-18206 gen_extra: Add installer warning for private key on node when installing cluster with custom CA cert

Checklist for all PR's

[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[ ] Read the DC/OS contributing guidelines
[ ] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

@mesosphere-mergebot label [Ready For Review]

@mesosphere-mergebot bump-ee


Compilation error egui

I tried reproducing the article below, unfortunately  I am getting compilation errors (98 errors)
https://tauri.app/blog/2022/09/19/tauri-egui-0-1/
Since the log is quite big I've included a file with build result.
debug.txt
Thank you.

A new version has been released, please try again. don't forget to run cargo update inside the project.


Enable programmatic forwarding from Go apps (relates to #15 and #50)

I have taken #50 to the next logical step, such that I can call this code directly from another Go app. As well as re-working the ring buffer, I have extracted the functionality into a package pkg/forward.
I appreciate this is a broader scope than the original #15 ticket. The motivation is that app deployment is significantly simplified. This change means that there's no need to install oklog on our app servers, no need to alter service definitions, and (in my case) a lot less puppet to deal with.
Please see this working example of how I can use pkg/forward, to forward logs programmatically from within a Go app - in this example I'm using logrus, but I haven't needed to write a logrus-specific solution. The same could be done with the stdlib log package (log.SetOutput(w)):
https://github.com/laher/oklogrus/blob/master/examples/oklogrus1ps/oklogrus1ps.go#L24:L32
That highlighted code:
l := logrus.New()
f := forward.NewBufferedForwarder(urls, "oklogrus: ", 5)
r, w := io.Pipe()
go func() {
	err := f.Forward(r)
	if err != nil {
		log.Fatalf("Error forwarding: %v", err)
	}
}()
l.Out = w

oklog/cmd/oklog/forward.go invokes pkg/forward as follows:

https://github.com/laher/oklog/blob/feature/pkg-forward/cmd/oklog/forward.go#L128:L143

Note that I'd like to add some features in the near future, i.e. there ought to be a 'cancel' feature, and I think it would be useful to somehow report on messages dropped - either via prometheus, or maybe even by injecting a 'messages dropped' message into the buffer...

So, if you're keen on this feature, it feels like there's a lot of little decisions to agree on. Maybe a conversation would help to push it forwards at some stage.
If this feature isn't something you'd like to do for the moment, that's also cool, I can either create a separate repository, or even just merge to laher/oklog master and offer that for the time being.
Cheers, Happy Seasonal egg-related Holiday.

Thank for the helpful feedback @peterbourgon .

Give me a couple days and I'll see about refactoring it a bit.

That would be awesome, thanks. All in good time.
In the meantime I have addressed some issues you raised, added tests and fixed bugs. Note, I haven't found a way to avoid the channel+mutex yet, but I do agree it's an uncomfortable mixture.
Changes:

The implementation no longer drops incoming records. They always go onto the buffer. So, the buffer contains the most recent records.
This revealed some other bugs in the implementation. Fixed and relevant tests added.
The channel now purely exists to allow Get() to block whenever the buffer is empty. The channel is now a chan struct{}, and the message just signifies a 'there's data now, check the buffer'.
The 'unblock' from the Put method (in a select/default) is invoked after putting the record onto the buffer.
That channel-receive is no longer synchronised by a lock. (oops!)
Good news - the benchmarks are showing 444ns instead of about 1000ns previously.

I'm really interested to see what you can propose. Today I also tried a buffer with 2 channels (1 for incoming + 1 for outgoing). I ran a separate goroutine for managing the state with an infinite for{ select {} } receiving into the buffer in and sending back out from the buffer, but I couldn't make it work in a straightforward way (i.e. conditionally blocking on the Get method), so I'm parking it for the moment. :/
Ta.

Zoiks, I wrote an alternative implementation with a buffered channel, it's so simple and seems to work just right. See RingBufferBCH in pkg/forward/ringbuffer_bch.go. It's faster too. 333ns vs 440ns on the put+get benchmark
Funny, I dismissed this idea weeks ago without trying it.

I'm closing this for now.
I think it was a worthwhile exercise to try this out, but it seems like it's not really close to acceptance, and meanwhile my personal motivation for this feature diminished when I changed jobs this month (we use Kubernetes at my new job, and our log forwarding is already sorted).
Hopefully the ring buffer itself in #50 is closer to resolution, and I'm sure some variant of #62 will be added at some point in the future. I'll leave the fork and branch in place for reference.
Cheers.


import fails after renaming "PopupService" to "popupService"

Hi ceolter,
After you renamed the file, all of the code I have was broken because the imports still link to "PopupServer" not "popupService". I am running on Linux so the code is case-sensitive.
I patched temporary so I can run my code.
I would greatly appreciate if you could file the case-sensing issue.
Best Regard,

please advise, where is it referencing PopupService? (and not popupService)
btw, the class is PopupService and the file is popupService

are you looking at the latest?
as this was a problem i fixed a few days ago i though.

Hi Niall,
There are two files were renamed:

.../widgets/popupService (from PopupService)
.../dist/lib/interfaces/iMenuFactory (from IMenuFactory)

You need to also change the case in all the files which refer to the files.
It works in Windows as the OS is case-insensitive for file names. But Mac
and Linux do.
Thanks a lot,
Son Lam.
Sơn Quang Lâm
Cell:<PHONE_NUMBER>
On Tue, Mar 15, 2016 at 1:40 AM, Niall Crosby<EMAIL_ADDRESS>wrote:

are you looking at the latest?
as this was a problem i fixed a few days ago i though.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/ceolter/ag-grid/issues/784#issuecomment-196720870

yes i understand what you are saying. my point is, i cannot see where in my code this is still a problem. can you advise if you are looking at the latest code, and if so, which file has the issue?

headerRendering\standardMenu.d.ts:
import { IMenuFactory } from "../interfaces/iMenuFactory";
but \interfaces contains IMenuFactory.d.ts

So, it appears that your code is correct, but you may not be updating the dist folder with the changes.  The npm package for ag-grid ends up with a node_modules/ag-grid/dist/lib/interfaces/IMenuFactory.d.ts instead of iMenuFactory

Hi Niall.
You need to rename to file from "PopupService" to "popupService" and
"IMenuFactory" to "iMenuFactory" then it will be OK. Just change the first
letters from-upper case to lower-case.
Thanks,
Sơn Quang Lâm
Cell:<PHONE_NUMBER>
On Thu, Mar 17, 2016 at 2:06 PM, Jared Youtsey<EMAIL_ADDRESS>wrote:

So, it appears that your code is correct, but you may not be updating the
dist folder with the changes. The npm package for ag-grid ends up with a
node_modules/ag-grid/dist/lib/interfaces/IMenuFactory.d.ts instead of
iMenuFactory
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/ceolter/ag-grid/issues/784#issuecomment-198082495

all renamed now to start with lower case.

Is this in 4.0.5 or 4.0.6?

@jkyoutsey
this is where i'm looking
https://github.com/ceolter/ag-grid/tree/4.0.5/src/ts/widgets


Readme for accumulate doesn't match the tests.

The Readme for accumulate uses an example of a numeric list, but the test cases all use strings. The Readme should be rewritten.

Given the collection of strings:
"the", "cat", "sat", "on", "the", "mat"

And the operation:
Capitalise a string ("cat" => "CAT")
Your code should be able to produce the collection of words:
"THE", "CAT", "SAT", "ON", "THE", "MAT"

@zeimusu excellent observation. Sorry I missed this one last week! Since this exercise has no canonical test cases over at problem-specifications we can modify the README as we see fit.
Would you like to submit a PR to fix the README? We should probably add a .meta/  directory and handle it there...

Hello, I made a few edits to the README to fix this issue. I closed the first PR and created a second one because I messed up the Git structure or something like that.


Added hyphens to UrlPattern

Added hyphen to character classes in the UrlPattern.
Closes #707

Could you escape the hyphen inside the regex? Otherwise at some later date, someone's going to add another character to the character class, then it'll become a .-? range in the character class and do the wrong thing

Sure, done!

Looks good to me


Deadlock when reaching channel limit in DirectMessageListenerContainer

In what version(s) of Spring AMQP are you seeing this issue?
2.4.11 (Reproduction example is present for 3.1.2)
Describe the bug
We use convertSendAndReceive for asynchronous RPC in our project. Invoking such a method requires getting a new consumer (and thus requiring a channel to communicate with the broker).
In case when the load is high and all the channels are occupied, the consumers are tried to be created under consumersLock in the while loop, always failing to create a new one (DirectMessageListenerContainer.adjustConsumers). With the lock being acquired by the adjustConsumers, the timed out consumers can't be cancelled in DirectMessageListenerContainer.checkConsumers thus never releasing any channels.
To Reproduce
Run the example RabbitmqDeadlockApplication and observe that TaskSubmitter never has its futures completed. main thread is blocking asyncRabbitTemplate-1 thread that tries to check the consumers and probably cancel some of them.
Expected behavior
Timed out requests release underlying channels leading to eventually completing all futures.
Sample
https://github.com/utikeev/spring-amqp-directmessagelistenercontainer-deadlock
The sample has a limit for channels set to 2 to make it easier to reproduce (with just 5 convertSendAndReceive). In our case, we hit the broker limit of 2047 channels per connection.
We also set the MessageListener programmatically, but that shouldn't be the issue as far as I understand.

The problem might be about the wrong usage of Spring AMQP API. In that case, if you could recommend a better way to handle that use-case, I'd consider that a solution as well.

Thank you for the report!
Modified your application to this simple unit test:
	@Test
	public void limitedChannelsAreReleasedOnTimeout() {
		CachingConnectionFactory connectionFactory = new CachingConnectionFactory("localhost");
		connectionFactory.setChannelCacheSize(1);
		connectionFactory.setChannelCheckoutTimeout(500L);
		RabbitTemplate rabbitTemplate = new RabbitTemplate(connectionFactory);
		rabbitTemplate.setReceiveTimeout(100L);
		AsyncRabbitTemplate asyncRabbitTemplate = new AsyncRabbitTemplate(rabbitTemplate);
		asyncRabbitTemplate.start();

		RabbitConverterFuture<String> replyFuture1 = asyncRabbitTemplate.convertSendAndReceive("noReply1");
		RabbitConverterFuture<String> replyFuture2 = asyncRabbitTemplate.convertSendAndReceive("noReply2");

		assertThatExceptionOfType(TimeoutException.class)
				.isThrownBy(() -> CompletableFuture.allOf(replyFuture1, replyFuture2).get(2, TimeUnit.SECONDS));

		asyncRabbitTemplate.stop();
		connectionFactory.destroy();
	}

And it indeed never ends:
2024-03-14 10:46:50,711  WARN org.springframework.amqp.rabbit.listener.DirectReplyToMessageListenerContainer [main] : basicConsume failed, scheduling consumer for queue amq.rabbitmq.reply-to for restart
org.springframework.amqp.AmqpTimeoutException: No available channels
	at org.springframework.amqp.rabbit.connection.CachingConnectionFactory.obtainPermits(CachingConnectionFactory.java:556) ~[classes/:?]
	at org.springframework.amqp.rabbit.connection.CachingConnectionFactory.getChannel(CachingConnectionFactory.java:522) ~[classes/:?]
	at org.springframework.amqp.rabbit.connection.CachingConnectionFactory$ChannelCachingConnectionProxy.createChannel(CachingConnectionFactory.java:1503) ~[classes/:?]
	at org.springframework.amqp.rabbit.listener.DirectMessageListenerContainer.consume(DirectMessageListenerContainer.java:793) ~[classes/:?]
	at org.springframework.amqp.rabbit.listener.DirectMessageListenerContainer.doConsumeFromQueue(DirectMessageListenerContainer.java:759) ~[classes/:?]
	at org.springframework.amqp.rabbit.listener.DirectMessageListenerContainer.adjustConsumers(DirectMessageListenerContainer.java:358) ~[classes/:?]
	at org.springframework.amqp.rabbit.listener.DirectMessageListenerContainer.setConsumersPerQueue(DirectMessageListenerContainer.java:176) ~[classes/:?]
	at org.springframework.amqp.rabbit.listener.DirectReplyToMessageListenerContainer.getChannelHolder(DirectReplyToMessageListenerContainer.java:180) ~[classes/:?]
	at org.springframework.amqp.rabbit.AsyncRabbitTemplate.convertSendAndReceive(AsyncRabbitTemplate.java:498) ~[classes/:?]
	at org.springframework.amqp.rabbit.AsyncRabbitTemplate.convertSendAndReceive(AsyncRabbitTemplate.java:437) ~[classes/:?]
	at org.springframework.amqp.rabbit.AsyncRabbitTemplate.convertSendAndReceive(AsyncRabbitTemplate.java:408) ~[classes/:?]
	at org.springframework.amqp.rabbit.AsyncRabbitTemplateTests.limitedChannelsAreReleasedOnTimeout(AsyncRabbitTemplateTests.java:438) ~[classes/:?]

As you pointed correctly we never exit from the adjustConsumers() loop because the downstream consume() swallows exceptions and returns back to the loop.
So, that scheduled checkConsumers() is never able to release idled channel because it cannot this.consumersLock.lock();.
I'll try to play with a ReadWriteLock instead for more fine-grained concurrency control.
Any other ideas?

Yeah, I think a fair-locking is a way to go, allowing other operations with consumers (either it be normal dispose or cancellation) to change the state.

Will it also be possible to backport the fix to 2.4.x version? Or are they no longer maintained with non-security fixes? 3.x requires Spring update which we can do, but it'd be nice if this bug wasn't the main call to action :)

That version is out of Open Source support: https://spring.io/projects/spring-amqp#support.
So, it really might be better for your project to upgrade to the latest Spring version and so on.

Hi @utikeev !
Please, take a look into PR I propose: https://github.com/spring-projects/spring-amqp/pull/2655.
Thanks


Loading plugins in docker devopsfaith/krakend

Hi!
Im trying to run krakend using the docker image provided from devopsfaith/krakend.
The application starts, but my plugins (which are build outside of the docker image, as it's an alpine image), have trouble being loaded.
Initially I encountered the problem with CGO_ENABLED, which I've now set to 0.
Then there was a problem with the GO_VERSION being different from what krakend had been built with (I found the version in the Makefile on this github repo), so that was fixed too.
But now I've encountered a problem with the "net" package being a different version too.
It feels to me like I'm going to wrong way about this. How would you add plugins to the docker image?
The specific errors I'm seeing for my plugins now are:
2022/05/04 07:59:56 KRAKEND DEBUG: [SERVICE: Plugin Loader] Starting loading process 2022/05/04 07:59:56 KRAKEND DEBUG: [SERVICE: Executor Plugin] plugin #0 (/plugins/krakend-debugger.so): plugin.Open("/plugins/krakend-debugger"): plugin was built with a different version of package net 2022/05/04 07:59:56 KRAKEND DEBUG: [SERVICE: Handler Plugin] plugin #0 (/plugins/krakend-debugger.so): plugin.Open("/plugins/krakend-debugger.so"): plugin was built with a different version of package net (previous failure) 2022/05/04 07:59:56 KRAKEND DEBUG: [SERVICE: Modifier Plugin] plugin #0 (/plugins/krakend-debugger.so): plugin.Open("/plugins/krakend-debugger.so"): plugin was built with a different version of package net (previous failure) 2022/05/04 07:59:56 KRAKEND DEBUG: [SERVICE: Plugin Loader] Loading process completed
Thanks!

Hi @peturssonstefan-ikea
Things to take into account when developing plugins:

You NEED CGO.
You need to build the plugin using the EXACT same GO version used to compile the binary that will load the plugin.
You need to build the plugin using the same GLIBC (MUSL on alpine)
Any dependency being used in the plugin, that also is used in the binary, need to be the exact same version.
You can check the differences between dependencies using the check-plugin subcommand from KrakenD.

The easiest way to achieve the required environment is to check all the required versions in the Makefile we use to build KrakenD.
https://github.com/devopsfaith/krakend-ce/blob/master/Makefile#L22 <-- GOLANG VERSION
https://github.com/devopsfaith/krakend-ce/blob/master/Makefile#L24 <-- ALPINE VERSION
Resulting docker image: golang:${GOLANG_VERSION}-alpine${ALPINE_VERSION}
Check the Dockerfile since alpine need to install some tools to be able to build correctly:
https://github.com/devopsfaith/krakend-ce/blob/master/Dockerfile#L5

Thanks for the quick response taik0, it's much appreciated! I'll try it out and hopefully get it up and running!

Alright, it's up and running. Thanks again for the help.
In relation to:
Any dependency being used in the plugin, that also is used in the binary, need to be the exact same version.
Does anyone have any recommendations on tools that can keep the two .mod files in sync? Or is this better handled manually?

I'm glad that it helped.
It's a very cumbersome process, what usually works is to check with the check-plugin KrakenD command:
➜ [my-plugin-directory]%  krakend check-plugin -l DARWIN-11.6.3
11 incompatibility(ies) found...
github.com/Shopify/sarama
	have: v1.31.0
	want: v1.27.2
github.com/golang/snappy
	have: v0.0.4
	want: v0.0.3
github.com/klauspost/compress
	have: v1.13.6
	want: v1.13.1
github.com/pierrec/lz4
	have: v2.6.1+incompatible
	want: v2.6.0+incompatible
github.com/rcrowley/go-metrics
	have: v0.0.0-20201227073835-cf1acfcdf475
	want: v0.0.0-20200313005456-10cdbea86bc0
...

Uusually setting the same version is enough, but you can encounter problems if a lot of common deps are used by KrakenD and the plugin. An "easy" way is to put replace directives in your plugin go.mod to make it match the KrakenD ones.

Hi @peturssonstefan-ikea,
I am closing this issue as I understand there is nothing else actionable in this issue. Let me know otherwise


Change to community supported parser

I've tested running surya parse **/*.sol on repos with solidity versions  from 0.5.0 to 0.6.8.
It's not guaranteed to be an exhaustive sampling of possible grammars, but it is working.

LGTM, merging


Uncaught Error: Unable to find node on an unmounted component. [After update to react 18]

I don't know why it is not working anymore, my code is very simple, but after updating to react 18 stopped working:
code: https://github.com/foxhound87/mobx-react-form-devtools/blob/master/src/components/Draggable.jsx#L11
Version: 4.4.5
these errors are appearing:
Uncaught Error: Unable to find node on an unmounted component.
    at findHostInstanceWithWarning (react-dom.development.js:24281:1)
    at Object.findDOMNode (react-dom.development.js:24804:1)
    at DraggableCore.findDOMNode (DraggableCore.js:389:1)
    at DraggableCore.componentDidMount (DraggableCore.js:352:1)
    at commitLayoutEffectOnFiber (react-dom.development.js:23305:1)
    at commitLayoutMountEffects_complete (react-dom.development.js:24688:1)
    at commitLayoutEffects_begin (react-dom.development.js:24674:1)
    at commitLayoutEffects (react-dom.development.js:24612:1)
    at commitRootImpl (react-dom.development.js:26823:1)
    at commitRoot (react-dom.development.js:26682:1)

react-dom.development.js:18687 The above error occurred in the <DraggableCore> component:

    at DraggableCore (http://localhost:8888/main.js:75147:5)
    at Draggable (http://localhost:8888/main.js:74645:5)
    at observerComponent (http://localhost:8888/main.js:40445:73)
    at div
    at div
    at div
    at div
    at Dock (http://localhost:8888/main.js:49158:5)
    at div
    at observerComponent (http://localhost:8888/main.js:40445:73)
    at UI
    at div
    at observerComponent (http://localhost:8888/main.js:169213:73)

The above error occurred in the <Draggable> component:

    at Draggable (http://localhost:8888/main.js:74645:5)
    at observerComponent (http://localhost:8888/main.js:40445:73)
    at div
    at div
    at div
    at div
    at Dock (http://localhost:8888/main.js:49158:5)
    at div
    at observerComponent (http://localhost:8888/main.js:40445:73)
    at UI
    at div
    at observerComponent (http://localhost:8888/main.js:169213:73)

react-dom.development.js:24281 Uncaught Error: Unable to find node on an unmounted component.
    at findHostInstanceWithWarning (react-dom.development.js:24281:1)
    at Object.findDOMNode (react-dom.development.js:24804:1)
    at DraggableCore.findDOMNode (DraggableCore.js:389:1)
    at DraggableCore.componentWillUnmount (DraggableCore.js:366:1)
    at callComponentWillUnmountWithTimer (react-dom.development.js:22852:1)
    at safelyCallComponentWillUnmount (react-dom.development.js:22873:1)
    at commitDeletionEffectsOnFiber (react-dom.development.js:24129:1)
    at recursivelyTraverseDeletionEffects (react-dom.development.js:23989:1)
    at commitDeletionEffectsOnFiber (react-dom.development.js:24133:1)
    at recursivelyTraverseDeletionEffects (react-dom.development.js:23989:1)

Yes, I'm also facing the same issue too!

for me as well


i18n(pt-BR): update tutorial/3-components/1.mdx file

Description (required)
update i18n/docs/pt-br/tutorial/3-components/1.mdx

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

pt-br
tutorial/3-components/1.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


[beta] Bump curl

Beta backport of #9809 to fix #9788

r? @Eh2406
(rust-highfive has picked a reviewer for you, use r? to override)

:warning: Warning :warning:

Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.55.0. Please double check that you specified the right target!

@bors: r+

:pushpin: Commit ac44893b1965da0d4fe3a6d4467c3a2e4c65228b has been approved by alexcrichton

@bors: r+

:bulb: This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #9774

:pushpin: Commit ac44893b1965da0d4fe3a6d4467c3a2e4c65228b has been approved by alexcrichton

:hourglass: Testing commit ac44893b1965da0d4fe3a6d4467c3a2e4c65228b with merge ecec07573ad9c3b32dd2ec686df14e17decef207...

:sunny: Test successful - checks-actions
Approved by: alexcrichton
Pushing ecec07573ad9c3b32dd2ec686df14e17decef207 to rust-1.55.0...


Error on restart following uninstall

Hi,
I installed TaskbarX. I then uninstalled it. Now every time I login I get a command prompt followed by a error message:
shell:AppsFolder\40210ChrisAndriessen.FalconX_y1dazs5f5wq00!TaskbarX. Make sure you've typed the name correctly, then try again.

In your startmenu search for "Task Scheduler".
On the left menu click on "Task Scheduler Library". In the middle a list will appear.
Right click on the "TaskbarX" or "FalconX" entry and click "Delete".

Thanks for the prompt response. It fixed the problem. Do you not think that the uninstall should remove this task entry?

The next update will do that ;)
Sadly the store version can't do this as it has no option to do something on uninstall. Like stopping the application and removing the taskschedule.

Ok. Shame it is not fixable for the store version. Thanks again.


StdPatch.qc not found

The injector is telling me that StdPatch.qc cannot be opened causing it to close and not work

You're doing something wrong


Error: Cannot read property 'offsetHeight' of null

Hello everyone. I started to use vue-notification, everything is ok, but when I opened browser's console, I saw this message Cannot read property 'offsetHeight' of null . It happens after notification's disappearance.
I use vue-notification without any options, do you have any idea?

Hey.
This error occurs somewhere in vue framework/webpack stuff and has nothing to do with the plugin.


AWSM without API gateway

I can't work it out as any changes in awsm.json got overriden while deploy. Can we create module that will contain only lambda? For instance, when I want lambda used by other lambdas via SNS?

coming in next the release ;)

See #198 as well. Possible duplicate.


🐛 Compatibility issues with flutter 3.13.0

Describe the bug
Error (Xcode): ../../../../.pub-cache/hosted/pub.dev/fluent_ui-4.7.2/lib/src/controls/form/selection_controls.dart:121:30: Error: The parameter 'clipboardStatus' of the method '_FluentTextSelectionControls.buildToolbar' has type 'ClipboardStatusNotifier?', which does not match the corresponding type, 'ValueListenable<ClipboardStatus>?', in the overridden method, 'TextSelectionControls.buildToolbar'.

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

so am I when upgrade 3.10.6 to 3.13.0
hence , I downgrade to 3.10.6 is working properly

Hi! Already working on it: https://github.com/bdlukaa/fluent_ui/pull/915
For now you can switch to the git version (make sure to set ref to the branch name), but make sure to switch to the release version once it is released.

Duplicate of #865


Get closer to 100% test coverage

Please select a category the issue is focused on?
No response
Let us know where something needs a refresh or put your idea here!
Get closer to 100% test coverage by running tests from covr package and writing tests for anything not covered there.

Can also use opportunity to format checks better using the admiral add-in.


[3.3] Stop curl from trying to POST stdin

https://github.com/arangodb/release-3.4/issues/102

CI reported a failure here, I'm investigating if this has anything to do with this PR.

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/1792/


#237 Handle null res object when server is not responding.

This PR address #237 for handling when server doesn't respond.
I am using a 503 HTTP response code as that seems appropriate, but I am open to suggestions.
The test case I added is skipped, because I can't get it to pass because of a connection error outside of supertest.
  51 passing (276ms)
  1 failing

  1) request(url) should fail if the server is off:
     Error: connect ECONNREFUSED
      at exports._errnoException (util.js:746:11)
      at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1000:19)

I am not sure if there is a way to handle this use case as I believe the error is now outside of supertest / superagent. Any suggestions?

Don't take status codes out of the thin air which may potentially cause false passes, use 0 if you really want to have a status code.
I would actually solve the issue by skipping the assertions and invoke the final callback with an error that explains that the other end is down.

Closing this as PR #260 is a better implementation.


MGMT-17477: Show dev preview badge when select custom OCP versions

Related to https://issues.redhat.com/browse/MGMT-17477
https://github.com/openshift-assisted/assisted-installer-ui/assets/11390125/fba5ade4-73e3-4243-973d-5d5f5a4af4fa

While we're at it, I think we should show the Please note that this version is not production-ready. warning when a dev-preview version is selected trough the modal. (It's currently missing.)

I agree with @jgyselov
Selecting the same version, eg. 4.16.0-ec.4-multi, should work the same way whether it's selected via the custom or main dropdown.
Currently, with the custom dropdown, the badge is missing. It's OK to add the "dev preview" label, but I think the badge is more relevant.

@jgyselov @celdrake now it works. It was a problem with the updating of helper text.


Register Json, Xml, and Yaml engines with pippo-jackson

Jackson supports reading/writing multiple formats using the same set of annotations.  In many cases you may not need any data annotations at all to read/write.
This PR refactors the Jackson integration to register Json, Xml, and Yaml engines.  It's a one-stop dependency for all three content types.
What do you think of this approach?

The idea is good but I see some problems when I want to use pippo-jackson for __ JSON__ and other pippo modules (pippo-xstream) for XML (an example). In this case JacksonInitializer registers JacksonXmlEngine automatically and I cannot use another XmlEngine.
Probably a solution is to declare optional the jackson-dateformat-xml and jackson-dateformat-yaml and to use some reflections to register or not JacksonXmlEngine and JacksonYamlEngine.

optional is a good compromise.  I'll make it so.

:+1:


Suggested addition for the tool

Hi, first of all I want to say this is a great tool and I thank you very much for your work. I see however that this tool cannot be used in the case of moving a Windows co-op save to another Windows co-op save. This scenario can happen for instance when two friends are playing on a co-op server (not dedicated server just the classical game mode), but the host wants to transfer the world to his friend for some reason (e.g. for performance issues or because the friend wants to be able to play without the current host). In that case, the host (let's call him player A and the friend player B) can't just send the folder the B and let him run it on his PC, because for the same reason as why this doesn't work on the other kinds of world transfer, the host has guid 0...1 and not his actual guid. This was my case, so I downloaded your tool but it can't really do this kind of operation. From my understanding, with your tool, if player B were to use the tool to get his character set as the host (so guid 0...1), it would erase the progress of player B, since his data was stored in the file with guid  0...1. I will try to make it work for myself by tweaking your python code, but I think adding it to your code yourself could be a nice addition because it can probably help a lot of people.
Note : This is how I plan to implement this functionality for myself, but since I am not very good in python, I sum it up here in case someone has remarks. I don't plan on doing the guild part since in my case I can just leave the guild beforehand to avoid any problems :
First, we need to get player A (the current host)'s actual guid by making join a server hosted by someone else. Once we have it, we can run the python program with 4 arguments  (or 5 if we add the guild fix) : <uesave.exe> <save_path> <player_a_guid> <player_b_guid>.
Just like in your program, we will convert the files to JSON, but this time we do it for the level_save, the player_b save and the host_save (always 1 so not an input), which contains player A's info.
Then, we just edit the host_save's guid to set it to player_a_guid, the player_b_save's guid to set it to 0...1, and we do the same for the level_save using the instance id's. Then we rename the files to the corresponding guids and convert them back to .sav.
Do you think this will work ?

Update : I tried modifying the fix-host-save.py file to solve my problem, but even with that, the old host (player A) had to create a new character when he joined the world even though I thought I had transferred his character to his actual guid. Here's the code if someone wants to take a look (I apparently can't attach a python file so it's a .txt).
coop-to-coop-transfer.txt


Bug: Weird empty white box in quick input page in dark mode

Describe the bug
In dark mode if we go to quick input and click on body(or header/params) we see a white empty box.
To Reproduce
Steps to reproduce the behaviour:

Go to 'quick input page' ans turn on dark mode
Click on 'body'
See error

Expected behaviour
The color of the box should the match the color of the rest of the page in both dark/light mode.
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: Ubuntu 20.04

I would like to work on this if approved.

Actually, that's not weird @iamkryptonite, the problem is that in dark mode, the text color is changed to white and the JSONfied response box doesn't change its background which results in an empty white box.

As you can see that when I selected the text it's there, so we just have to toggle color appropriately for this issue.

Actually, that's not weird @iamkryptonite, the problem is that in dark mode, the text color is changed to white and the JSONfied response box doesn't change its background which results in an empty white box.

As you can see that when I selected the text it's there, so we just have to toggle color appropriately for this issue.

Correct!


WSL suddenly couldn't find it

Version
Windows Feature Experience Pack 1000.25151.1010.0
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
5.4.72
Distro Version
Debian
Other Software
No response
Repro Steps
Unable to open, WSL command can not be executed
Expected Behavior
WSL Debian is running properly
Actual Behavior
In fact, WSL is not working properly and there is no way to fix it.
Diagnostic Logs

/logs


Cut new release

👋🏼  any chance of a new release, which would include all the updated dependency specs?
Thanks :)

also, please consider merging https://github.com/colibris-xyz/strapi-plugin-site-publisher/pull/107 as axios <1.5.1 contains a moderate security vulnerability: https://github.com/advisories/GHSA-wf5p-g6vw-rhxx

Hi @chohner,
I hope to release a new version this week.


can't load pre-trained model in eval_protonet

model.load_state_dict(torch.load(args.model_path)['params'])
Hi, I got an error in the above line of code, saying that the loaded model (downloaded from the proposed google drive)has no key of 'params'. I checked and found that the key should be 'model'. So I changed to model.load_state_dict(torch.load(args.model_path)['model']), another error occurred, saying there are missed keys. What's wrong with the pre-trained model or the code, please?

Hey @YIYIZH
The pre-trained models provided here are the pre-trained SSL for the general purpose embedding network
You cannot evaluate it as is, but instead - you should first fine-tune the network, using this pre-trained weights as initialization, using one of the 3 provided few-shot datasets (or even make your own custom dataset), using train_protonet.py
For me, it took ~15 hours to train on a single 8GB RTX 2080, but it was really tight on the GPU's RAM.. I'd consider a 12+GB GPU for this task
Once you've got the training done - you'll have a new model weights file for evaluation


chore(makefile): don't pull outdated dependencies

This probably should have been part of https://github.com/operator-framework/operator-lifecycle-manager/pull/793. It just removes downloading of older kubernetes deps now that we've updated to 1.12 and are using go.mod.

This has been superceded by https://github.com/operator-framework/operator-lifecycle-manager/pull/805.


Update mappings for generic XR SDK controller

Overview

Flips the generic handling of thumbstick / touchpad as primary / secondary axes to a more common case.

Overrides this flip in the WMR motion controller class correspondingly

Re-serializes a scene profile to match the repo's build state
Refactors out a WindowsMRUsage into an MRTK-defined CustomUsage, as the pointerPosition and pointerRotation features are shared across several packages.

/azp run


[STM32F4 STM32F7] Overwrite HAL_Delay to allow SD example

The weak function HAL_Delay is overwritten to use mbed function
'wait_ms'.
Thanks to this, the user can use stm32f[4/7]xx_hal_sd.c that calls
HAL_Delay
This will allow us to add an example detecting / writing / reading an SD
card on DISCO_F469NI and DISCO_F746NG
(cherry picked from commit d491e3cd8b1d973793e6168a5037a812eadea961)

wait_ms() is not yet here in HAL. It's in the common API, therefore we rather use what HAL provides. We can define our own internal wait_ms() for this:
#include "us_ticker_api.h"

static void wait_ms_internal(uint32_t ms)
{
    ms = ms * 1000; // us ticker operates on us
    uint32_t start = us_ticker_read();
    while ((us_ticker_read() - start) < (uint32_t)ms);
}

In the future, we should create common HAL implementation, for instance this wait_ms() could be moved there.
@adustm What do you think?

Hello,
I would prefer to use the already existing wait_ms than duplicate it.
I thought that if it is in common API, we could use it. I've seen it is used at several locations in mbed library.
What would be the impact of moving wait_ms in HAL ? If no impact, I think it would be good to move wait_ms there. Let me know if you want to move wait_ms or if I should duplicate wait_ms.
Kind regards,

Hello,
HAL_Delay() is impemented in stm32f4xx_hal.c as follows,
__weak void HAL_Delay(__IO uint32_t Delay)
{
  uint32_t tickstart = 0;
  tickstart = HAL_GetTick();
  while((HAL_GetTick() - tickstart) < Delay)
  {
  }

and HAL_GetTick() is incremented in hal_tick.c.
Why dose HAL_Delay() have to be reimplement using wait_ms() ?
dinau

Hello @dinau , It seems we are blocked in the  while((HAL_GetTick() - tickstart) < Delay)
and that uwTick is never incremented. That's why I wanted to use wait_ms.
I'll try to figure out the reason why uwTick is not incremented.

Hello @dinau @0xc0170
I have a clearer view on the issue.
I have created a class for SD card, that calls HAL_Delay during its init phase. If I use a global variable for this class, it will be initialised at the RAM init, between SystemInit function and mbed_sdk_init function.
(refer to this example : https://developer.mbed.org/teams/ST/code/DISCO-F469NI_SD_demo/file/c802bce0ce54/main.cpp
SD_DISCO_F469NI sd; is a global variable )
At this moment, the timer is off (it is switched off at the end of SystemInit, and restarted in mbed_skd_init).
Then the HAL_Delay is stuck into a while loop  while((HAL_GetTick() - tickstart) < Delay)
(because the timer is not incremented)
Using wait_ms instead of HAL_Delay initializes again the timer and restarts it. This is the reason why it solves the issue I have.
In case I use a local sd  variable (inside the main function), the timer has been restarted by mbed_sdk_init and HAL_Delay works fine.
Could you let me know how you usually use a wait function between the SystemInit and the mbed_skd_init function, when timer is supposed to be off ?

Hello,
After an internal discussion within stm team, we think that the cleanest way of fixing our issue is to rewrite HAL_Delay function, as it is done in the PR.
The timer needs to be stopped during the RAM initialization.
It avoids us to apply a modification of the official STM Cube release.
It allows anyone to use global variables.
Please @0xc0170, could you proceed into merging this PR as is ?
Cheers
Adu

As I understand, you dont want to change HAL_Delay. Why not reimplement HAL_Delay as you did, but instead of using code from the upper layer, to just reinit ticker to get the same job done?

Hello @adustm @0xc0170,

If I use a global variable for this class, it will be initialised at the RAM init, between SystemInit function and mbed_sdk_init function.

Why is the global variable cleared "between SystemInit function and mbed_sdk_init function" ?
I think the system design like this is very weird.
STM team and we must reconsider this issue,
otherwise we would need "many workarounds" like this in the featur.
Probably the root cause would be alike as this ( I mentioned before about gcc ),
https://github.com/mbedmicro/mbed/pull/1432.
dinau

@dinau Create an issue with this problem, and you can paste there the info you shared about GCC

@adustm What do we do, considering this is workaround for now. I am not in favour of using wait_ms in HAL for now.

Hello, sorry for the long silent period.
I just read again the #1432 comment.
This startup sequence is out of my scope... it's always been there. I consider it is normal to initialize variables between the system_init and the main... It has to be done anyway...
This is the reason why we have investigated a workaround.
What do you think ?
@0xc0170 , I'll check again how to avoid using the top level code.

@0xc0170 , I'll check again how to avoid using the top level code.

Any luck?

Hello, I just commited this new version that uses mbedhal instead of mbed common.
Let me know if it's ok.
Kind regards

Thanks, Lets merge this. Please @adustm create an issue why this was added


Weird text after directory name in nerdtree.

Self-Diagnosis
Before creating an issue, take some time to search these resources for an answer. It's possible that someone else has already seen and solved your issue.

old NERDTree issues
NERDTree documentation - :h NERDTree
NERDTree Wiki
Other resources: https://stackoverflow.com, https://vi.stackexchange.com, etc.

Environment

Operating System: Pop!_os
Vim/Neovim version :version: Vim 8.2
NERDTree version, found on first line of quickhelp ?: 6.10.16
Are you using any of these NERDTree-dependent plugins?

[x] Xuyuanp/nerdtree-git-plugin
[x] ryanoasis/vim-devicons
[x] tiagofumo/vim-nerdtree-syntax-highlight
[ ] scrooloose/nerdtree-project-plugin
[ ] PhilRunninger/nerdtree-buffer-ops
[ ] PhilRunninger/nerdtree-visual-selection
[ ] jistr/vim-nerdtree-tabs
[ ] Others (specify):

Provide a minimal .vimrc file that will reproduce the issue.

autocmd VimEnter * NERDTree | wincmd p
autocmd BufEnter * if winnr('$') == 1 && exists('b:NERDTree') && b:NERDTree.isTabTree() | quit | endif

filetype plugin on

call plug#begin('~/.vim/plugged')

Plug 'https://github.com/ycm-core/YouCompleteMe.git'
Plug 'mbbill/undotree'
Plug 'vim-airline/vim-airline'
Plug 'vim-airline/vim-airline-themes'
Plug 'preservim/tagbar'
Plug 'jreybert/vimagit'
Plug 'tpope/vim-fugitive'
Plug 'pangloss/vim-javascript'
Plug 'elzr/vim-json'
Plug 'terryma/vim-multiple-cursors'
Plug 'scrooloose/nerdtree'
Plug 'ryanoasis/vim-devicons'
Plug 'Xuyuanp/nerdtree-git-plugin'
Plug 'tiagofumo/vim-nerdtree-syntax-highlight'
Plug 'preservim/nerdcommenter'

call plug#end()

Steps to Reproduce the Issue

Use zsh & kitty full screened (Do Ctrl + Shift + F11)
Make sure you have nerdtree open on startup
Open a file

Current Behavior (Include screenshots where appropriate.)

It shows strange text after the file directory, however, it doesn't show up when I use bash. Instead, it only shows up when I use zsh.
Expected Result
The expected result should be what it is when I click on the other window and it goes back to normal.

Since this issue has gone stale I'm going to close it.
As for the problem itself, It needs further information for debugging and needs the original author's cooperation to find the actual issue. Feel free to reopen it if you are experiencing this issue.


Allow SAS token to be refreshed

Completes the engineering work for #160
We still need to add a sample azure function to show how to vend SAS tokens.

@bsiegel is this PR ready to be merged?

@bsiegel what needs to be done to get this PR merged?

I think this is ready to go. I will add the sample function in a separate PR.


UK Bearer Token Expired

So the UK Bearer Token doesn't work anymore. Anyone got a new Bearer Token?

same i need one too

Here:
Bearer : eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1c2VySWQiOjE3MzQ2NjgzLCJ1c2VybmFtZSI6IkFudXNoUGF0ZWwiLCJhdmF0YXJVcmwiOiJzMzovL2h5cGVzcGFjZS1xdWl6L2EvYTUvMTczNDY2ODMtbVhZbGpJLmpwZyIsInRva2VuIjoiS2M1SnhYIiwicm9sZXMiOltdLCJjbGllbnQiOiIiLCJndWVzdElkIjpudWxsLCJ2IjoxLCJpYXQiOjE1MzM3NjAxMTUsImV4cCI6MTU0MTUzNjExNSwiaXNzIjoiaHlwZXF1aXovMSJ9.KLYTMKf4Q8S8gSxAVzyjupAebJKqGYqDE8y3KtzTyxo
User : 17346683
:)

Are you guys serious? Your bearer token is unique to you - using this guy's bearer token is earning him money!

No its not. As this bot doesn't answer the questions...


lanelet2 validation error

Hello , I just built a lanelet map , and I modified all id positive. and I also can visualize it in JOSM, and the longitude and latitude is almost matching the real world. but when I ran  (rosrun lanelet2_validation lanelet2_validate /home/gxf/catkin_ws/src/lanelet_related/osm_edit/src/2020-8-12.osm --lat 31.0281529127 --lon<PHONE_NUMBER>08
), many error occurred:
Error: 	- Error parsing primitive 10750: Longitude 121.439d more than 60d from center of UTM zone 31 [general]
Error: 	- Error parsing primitive 10751: Longitude 121.439d more than 60d from center of UTM zone 31 [general]
Error: 	- Error parsing primitive 10752: Longitude 121.439d more than 60d from center of UTM zone 31 [general]
Error: 	- Error parsing primitive 10753: Longitude 121.439d more than 60d from center of UTM zone 31 [general]
Error: 	- Error parsing primitive 10754: Longitude 121.439d more than 60d from center of UTM zone 31 [general]
Error: 	- Error parsing primitive 10755: Longitude 121.439d more than 60d from center of UTM zone 31 [general]
Error: 	- Error parsing primitive 10756: Longitude 121.439d more than 60d from center of UTM zone 31 [general]
Error: 	- Error parsing primitive 10757: Longitude 121.439d more than 60d from center of UTM zone 31 [general]
Error: 	- Error parsing primitive 10758: Longitude 121.439d more than 60d from center of UTM zone 31 [general]
Error: 	- Error parsing primitive 10759: Longitude 121.439d more than 60d from center of UTM zone 31 [general
Just like all the node is not correct.
This is some of my map:

<way id="12567" action="modify" visible="true" version="1">
    <nd ref="13925" />
    <nd ref="13924" />
    <nd ref="13923" />
    <nd ref="13922" />
    <nd ref="13921" />
    <nd ref="13920" />
    <nd ref="13919" />
    <nd ref="13918" />
    <nd ref="13917" />
    <nd ref="13916" />

looking forward to your reply. Thank you

'''

'''

node id="13925" action="modify" visible="true" lat="31.026585048929316" lon="121.43558994482319" version="1"
node id="13924" action="modify" visible="true" lat="31.026585478737257" lon="121.43559516246113" version="1"
I just delete <>,or I cannot write the 'node'

Sorry, I can not reproduce your problem. When I run lanelet2_validate with --lat 31.0281529127 --lon<PHONE_NUMBER>08, the selected UTM zone is 51. Are you sure this is how you ran the program?

I have found the error place, it is in  lanelet2_interface_ros/launvh/set_lanelet_map.launch, and modify the lat_origin and lon_origin.Thank you all the same
---Original---
From<EMAIL_ADDRESS>Date: Fri, Aug 7, 2020 15:33 PM
To<EMAIL_ADDRESS>Cc: "Author"<author<EMAIL_ADDRESS>Subject: Re: [fzi-forschungszentrum-informatik/Lanelet2] lanelet2 validation error (#140)
Sorry, I can not reproduce your problem. When I run lanelet2_validate with --lat 31.0281529127 --lon<PHONE_NUMBER>08, the selected UTM zone is 51. Are you sure this is how you ran the program?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

it's so strange  that  it runs fine  this time,just has some warnings  ,    linestring 12567 should have a type attribute .  But when I run lanelet_rviz_plugin_ros , map cannot plugin correctly, and error says  :  Error parsing primitive 348: Longitude 121.439d more than 60d from center of UTM zone 32.  Should I point the UTM ZONE number directly in somewhere of the code? I will give you my file,  if you could check it , I will appreciate it greatly
------------------ 原始邮件 ------------------
发件人:                                                                                "fzi-forschungszentrum-informatik/Lanelet2"<EMAIL_ADDRESS>发送时间: 2020年8月7日(星期五) 下午3:33
收件人<EMAIL_ADDRESS>抄送: "Snowm"<740297955<EMAIL_ADDRESS>主题: Re: [fzi-forschungszentrum-informatik/Lanelet2] lanelet2 validation error (#140)
Sorry, I can not reproduce your problem. When I run lanelet2_validate with --lat 31.0281529127 --lon<PHONE_NUMBER>08, the selected UTM zone is 51. Are you sure this is how you ran the program?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

When launching https://github.com/coincar-sim/lanelet2_interface_ros/blob/release/launch/set_lanelet_map.launch you have to set the origin correctly. The values in there are "default" values, these are only valid for the mapping example. I'll remove them soon, to avoid such confusion

I  think you should just warn somebodyelse in the README.md  file, not to remove it.
---Original---
From<EMAIL_ADDRESS>Date: Fri, Aug 7, 2020 19:23 PM
To<EMAIL_ADDRESS>Cc: "Author"<author<EMAIL_ADDRESS>Subject: Re: [fzi-forschungszentrum-informatik/Lanelet2] lanelet2 validation error (#140)
When launching https://github.com/coincar-sim/lanelet2_interface_ros/blob/release/launch/set_lanelet_map.launch you have to set the origin correctly. The values in there are "default" values, these are only valid for the mapping example. I'll remove them soon, to avoid such confusion
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

see https://github.com/coincar-sim/lanelet2_interface_ros/commit/d7891b4578deff67f025edbdeabe87b72a23dfc8


bug59153_CSVDataSetFilesExceptions

More clear message for CSV Data Set with
filename empty
wrong filename (not readable, not exist)
I don't have made formating to help reviewing
If anybody is ok, I will format it
Antonio

Ok
I will wait other review or a go before modify my PR to avoid problem like in my previous PR about this bug
Antonio

New commit with formating and swap else branch


Adds feature to add remote repository. Fixes #694

Description
A feature request for this was made in #694
This change allows the user to add a remote repository from the side bar. Prompts for the desired branchName and remoteUrl are shown in the command palette area, and pressing esc cancels at any time
Screenshots

Checklist

[x] I have followed the guidelines in the Contributing document
[x] My changes are based off of the develop branch
[x] My changes follow the coding style of this project
[x] My changes build without any errors or warnings
[x] My changes have been formatted and linted
[x] My changes include any required corresponding changes to the documentation
[x] My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
[x] My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

I just realized the first screenshot displays the "Press Enter to confirm or Escape to cancel" message twice. I've been looking back over the code and cannot seem to find the reason for this - it may be that my build environment is slightly off or the current state of the dev branch contains this functionality. I think it is the second reason, since the other functions in viewCommands.ts that I modeled mine after have the same prompt and also display this double message

@zaboyle Thank you so much for your contribution!

There was some git issue with this PR -- for some reason when trying to check it out the commit showed way too many changes (although it looked fine on GitHub). So I just cherry-picked the commit and merged it in manually.

Awesome! That was most likely because my Git skills are still a work-in-progress, so I appreciate it!

Awesome, thanks for contributing this, a huge quality of life improvement, IMO!


No known vulnerabilities found

Hi!
I would love to involve DevAudit into pipeline as scanner for known vulnerability. However I have issues with finding issues available in OSS Index e.g. I've added following line in csproj file:
<PackageReference Include="Microsoft.AspNetCore.All" Version="2.1.0" />
As it comes from these links:
https://ossindex.sonatype.org/vuln/27f6fcf5-3c1d-4174-8cda-21bf32e3be0e
https://ossindex.sonatype.org/vuln/e3fce117-b46e-4d5c-960f-ed0f77849a8b
This version is vulnerable. But on the output of DevAudit:
microsoft.aspnetcore.all no known vulnerabilities.
I am using following command:
./devaudit netcore /file.csproj
Cheers,
Artur

Just letting you know that we are looking into your issue.

Thanks!

@schreddies The issue should be fixed, I've attached a build from my repo. We'll make an official release soon.
DevAudit_<IP_ADDRESS>.zip

An official release has been made since then. Hopefully you found your problem resolved in Allister's patch version he provided. I am going to close the issue at this point.


Allow custom config file

Coverage decreased (-3.2%) to 65.517% when pulling 91190ac3dcba952e570f25693cb6f60d37df30f3 on config-location into ab69763879810bc5b9c45399cd40c6497377cadb on master.


Cannot get certificates for subdomains

Hello module author,
obtaining certificates for my https://domainname.dev works perfectly fine, but I am not able to get them for any subdomain, including https://www.domainname.dev.
This is my Caddyfile:
{
    debug
}

domainname.dev, www.domainname.dev {
    root * /usr/share/caddy/public
    file_server

    # Redirect HTTP to HTTPS
    @http {
        protocol http
    }
    redir @http https://{host}{uri} 301

    tls {
        dns inwx {
            username ${INWX_USERNAME}
            password ${INWX_PASSWORD}
        }
    }
}

home.domainname.dev {
    # root * /usr/share/caddy/public
    # file_server

    respond "Hello" 200

    # Redirect HTTP to HTTPS
    @http {
        protocol http
    }
    redir @http https://{host}{uri} 301

    tls {
        dns inwx {
            username ${INWX_USERNAME}
            password ${INWX_PASSWORD}
        }
    }
}

This is my Dockerfile:
FROM caddy:builder AS builder

RUN xcaddy build \
    --with github.com/caddy-dns/inwx

FROM caddy:latest

COPY --from=builder /usr/bin/caddy /usr/bin/caddy

And my compose.yml to start my docker docktainer:
services:
  caddy:
    image: caddy-inwx
    restart: unless-stopped
    container_name: caddy
    ports:
      - "80:80"
      - "443:443"
      - "443:443/udp"
    volumes:
      - ./Caddyfile:/etc/caddy/Caddyfile
      - ./public:/usr/share/caddy/public
      - caddy_data:/data
      - caddy_config:/config
    environment:
      - INWX_USERNAME=${CADDY_INWX_USERNAME}
      - INWX_PASSWORD=${CADDY_INWX_PASSWORD}

volumes:
  caddy_data:
  caddy_config:

Of course there are A records for www.domainname.dev and home.domainname.dev!
Since I get the certificate for https://domainname.dev, I dont think there is an issue with incorrect credentials and the are properly served by my .env file.
However, there seems to be something wrong with the authentication, see caddy log output below:
caddy  | {"level":"error","ts":1729447364.3561056,"logger":"tls.obtain","msg":"will retry","error":"[www.domainname.dev] Obtain: [www.domainname.dev] solving challenges: presenting for challenge: adding temporary record for zone \"domainname.dev.\": (2200) Authentication error (order=https://acme-v02.api.letsencrypt.org/acme/order/2009592577/315493xxx) (ca=https://acme-v02.api.letsencrypt.org/directory)","attempt":1,"retrying_in":60,"elapsed":5.068295076,"max_duration":2592000}

Any help is appreciated, thanks in advance!
Best

Ran into this issue today and fixed it by explicity setting endpoint_url as stated in their docs:
{
	acme_dns inwx {
		username ${INWX_USERNAME}
		password ${INWX_PASSWORD}
		shared_secret
		endpoint_url https://api.domrobot.com/jsonrpc/
	}
}

The README says:

If you don’t provide an endpoint_url the URL of the production environment (https://ote.domrobot.com/jsonrpc/) is used by default. If you want to use the test environment, set endpoint_url to https://api.ote.domrobot.com/jsonrpc/.

I assume this plugin uses an old url (https://ote.domrobot.com/jsonrpc/), although libdns/inwx uses the current one.
@ihmels you seem do manage both repos, do you have an idea?

I assume this plugin uses an old url (https://ote.domrobot.com/jsonrpc/), although libdns/inwx uses the current one.

@david-askari This plugin uses the URL that is stored in libdns/inwx if endpoint_url is not set.
@GabrielZirk Do you have two-factor authentication enabled in your INWX account?


[Event change request] Codeunit 225 OnBeforeSelectCustLedgEntry

To migrate a NAV ISV add-on to BC:
We need the OnBeforeSelectCustLedgEntry event updated to pass in the CustLedgEntry variable.

It does not make sense as CustledgEntry is not initialized at this stage.

This is a valid request.  There is no "RESET" before the CustLedgEntry.SETCURRENTKEY, so if you pass the CustLedgEntry variable into OnBeforeSelectCustLedgEntry, i can add my additional filter which will be persisted through the function.
Can you please reopen this?

Hi Alexander –
I posted the reply below on issue 1815.  I don’t think I have the ability to reopen it though…can you?  Another option would be to add a new event right after the “CustLedgEntry.SETRANGE(Open,TRUE)” line.
This is a valid request. There is no "RESET" before the CustLedgEntry.SETCURRENTKEY, so if you pass the CustLedgEntry variable into OnBeforeSelectCustLedgEntry, i can add my additional filter which will be persisted through the function.
Can you please reopen this?
Regards,
Rob Hansen, CPA, CMA
epimatic
PH:<PHONE_NUMBER> | FAX:<PHONE_NUMBER>
rhansen<EMAIL_ADDRESS>| http://www.epimatic.comhttp://www.epimatic.com/ | Skype: rhansen74
From: Alexander Yakunin<EMAIL_ADDRESS>Reply-To: Microsoft/ALAppExtensions<EMAIL_ADDRESS>Date: Thursday, March 28, 2019 at 9:29 AM
To: Microsoft/ALAppExtensions<EMAIL_ADDRESS>Cc: Rob Hansen<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [Microsoft/ALAppExtensions] [Event change request] Codeunit 225 OnBeforeSelectCustLedgEntry (#1815)
It does not make sense as CustledgEntry is not initialized at this stage.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/ALAppExtensions/issues/1815#issuecomment-477594782, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Aqm9wqZe3T4rwt8RipidSkAWdTSqga_3ks5vbMOcgaJpZM4cEAOP.

You mwill not get OnBeforeSelectCustLedgEntry , this is against of our best practices. Instead you will get OnAfterSetFilters event to add you filters. You will see it in next builds I suppose.

That's perfect - thanks Alexander.


🍒[cxx-interop] Conform std::string to Hashable

Explanation: This adds a conformance to Swift.Hashable protocol for std::string and std::u16string types.
Scope: Only has an effect when experimental C++ interop is enabled.
Risk: Low, C++ interop is an experimental feature, and this change is covered by tests.
Testing: Added execution tests.
rdar://107709149

@swift-ci please smoke test

@swift-ci please test

@swift-ci please smoke test

@swift-ci please test


Brave Leo AI using Ollama and Intel GPU

Hello.
I'm trying to use Brave Leo AI with Ollama using an Intel GPU.
The instructions from Brave using local LLMs via Ollama are here:
https://brave.com/blog/byom-nightly/
The instructions from Intel using Ollama with Intel GPU are here:
https://www.intel.com/content/www/us/en/content-details/826081/running-ollama-with-open-webui-on-intel-hardware-platform.html
How could I combine those ?
I want to use Brave Leo AI (not Open WebUI) running on Intel GPU via Ollama.
My system:
Windows 11/ Intel ARC A380
Thank you.

@NikosDi you should do one at a time , make sure when you do, ollama run #model , runs succesfully on your gpu , if it works then its easy to use it with brave , you just need to , ollama serve in a terminal and go to brave , & add local model ، for using ollama just copie the a description link they give you in the bracket , then use leo & select your model ، &thats it , to automate this i.e to have ollama serve automatically on boot you need a windows service i dont know if its possible to write one , in linux i did it , & it works fantastically.
I recommend to you using page assist for configuring some basic ollama stuff , have a nice day

@user7z thanks for your reply.
What is the exact name you put in Brave settings for "Model request name" of your model and what is the exact path of "Server endpoint" using ollama for Intel GPU configuration.
TIA

@NikosDi , youve miss guided or there is a windows bug ,read here carefully step by step , & see if you did something wrong , ollama should use llm-cpp as a backend wich it uses ipex-llm , plz forget about brave right know , & dont run the script , open the terminal yourself ، & serve , & try to chat on another terminal , this way you could debug the probleme more preciselly

hi @NikosDi , could you please provide full logs that returned on ollama server side?

Hello @user7z, @sgwhat
As I wrote above I have followed a different guide based on the PDF which doesn't install/ use conda environment.
It's a PDF from Intel.
https://www.intel.com/content/www/us/en/content-details/826081/running-ollama-with-open-webui-on-intel-hardware-platform.html
My exact system specifications are:
Windows 11 24H2 (26100.2033) - Intel ARC A380 - Drivers v6079.
The full log file of Ollama server is this:
Command-line.txt
TIA

@NikosDi you should install visual studio 2022 & select desktop C++ , as the guide suggest , then do ollama serve , then open another terminal and execute : ollama run llama3.2:1b & see if it runs
Makw sure you did follow the guide that @sgwhat mentioned , the PDF is out dated bro , always check github guides because they gets updates often

@user7z
What is your GPU running Leo AI ?
All the guides are referring to A770, mine is A380.
Looks like a hardware incompatibility eventually.

@NikosDi I think ipex-llm ollama supports A380,  you may follow up our github guide to try it.

@sgwhat
I think I found out the problem, it is mentioned in your guide.
https://github.com/intel-analytics/ipex-llm/blob/main/docs/mddocs/Quickstart/llama_cpp_quickstart.md
Number 14 says:
14. Native API failed error
On latest version of ipex-llm, you might come across native API failed error with certain models without the -c parameter. Simply adding -c xx would resolve this problem.
Where should I add this -c parameter and what is -c xx ?

Hi @NikosDi , -c xx is the size of the prompt context, but I believe that ollama does not need to consider -c xx because it is a parameter used for llama.cpp.
Could you please provide the detailed log returned by ollama serve and the script you used to run ollama?

Hi @NikosDi , I have checked your runtime log, please follow our github guide only to run ipex-llm ollama, and you may run it again without executing "C:\Program Files (x86)\Intel\oneAPI\setvars.bat" before you running ollama serve.

Hello @sgwhat.
I have already installed Ollama from the official page https://ollama.com/download on two of my PCs (1 Windows 11, 1 Linux Ubuntu 24.04.1) and Brave Leo AI works like a charm on both of them using the CPU.
It has extreme SIMD CPU optimizations, but CPUs are slow for such tasks.
Ollama installer has built-in support for NVIDIA CUDA and AMD ROCm but no Intel GPU support.
For Intel GPU I followed the guide from June 2024, I don't know if it's already obsolete.
I have already installed Intel's AI Playground on my Win 11 system, Ollama original CPU setup and the above Python environment for Intel GPU (Intel oneAPI, Python)
The truth is that it would be a lot more convenient if there was a single setup like AI Playground or similar in order to avoid manual installations for Ollama Intel GPU setup, since it's not built-in.
I'm not in a mood to follow another guide and install more environments (miniforge, conda etc)
If troubleshooting is impossible following Intel's guide from June 2024, then I have to stop here because we are doing circles.
Maybe it would be useful if you could tell me what I asked before, regarding the Native API failed error.
I'm using LLama3.1 as model and I would like to try adding -c xx and see the results, if you could assist where to add this parameter.
Thank you.

Hi @NikosDi , I have tested running ipex-llm ollama on windows11 Arc380 laptop and it works fine.
Please follow the guide I mentioned before, and set OLLAMA_NUM_PARALLEL=1 before you running ollama serve.

@sgwhat
Oh man!
This is insane!
It was just this "set OLLAMA_NUM_PARALLEL=1" parameter I have to add in the script.
Everything works like a charm now.
The utilization of A380 is more than 90% sometimes even 99% and the speed of response is unbelievable, compared to my Core i7 9700, many times faster.
Thank you very much for the effort.

@sgwhat
Well...
Unfortunately, even using the exact same model (Llama 3.1 - 8B) for CPU and Intel GPU on the exact same page, the results are completely different using Leo AI to summarize the page.
A380 is ~9x times faster than Core i7 9700, but the results are almost garbage sometimes.
It hallucinates a lot and always give me very short summaries compared to CPU version which is perfect.
Extremely slow but perfect, in both size and accuracy.
I don't know if there is anything that I could change in the parameters to enhance Intel GPU results in terms of quality, even slowing down the speed.
Thank you.

Hi @NikosDi , based on my tests, I haven't observed any noticeable difference in answer quality when running ipex-llm ollama on GPU or CPU, nor have I encountered issues with poor output on the A380. Could you provide the detailed responses from Leo AI?

I'm interested in testing your comparison too, how could I run IPEX using my CPU ?

You may set OLLAMA_NUM_GPU=0 before you strating ollama serve.

Hello @sgwhat
I did various test during weekend regarding different models using Brave Leo AI built-in cloud options, Ollama CPU, IPEX-LLM Intel GPU and now from your above suggestion, I added one more - IPEX-LLM Intel CPU.
So, using my Windows 11 PC and Intel ARC A380 I downloaded four different LLMs or we should call them SLM (Small Language Models)
Qwen2.5:7B, Mistral, LLama3.1:8B, Gemma2:9B
Using CPU mode I can run all of them obviously (I have 32GB of RAM)
Using GPU mode I can run all of them besides Gemma2, as it needs more than 6GB VRAM
Regarding speed the results are extremely obvious.
IPEX CPU is definitely not on par with native Ollama CPU.
IPEX CPU is V E R Y slow, Ollama CPU on the other hand is extremely AVX2 optimized.
I mean the difference is huge ~7 times faster Ollama CPU compared to IPEX CPU running on Intel Core i7 9700.
Intel GPU on the other hand is also ~9 times faster than Ollama CPU, so the differences are huge and clear.
Regarding quality, I can not say for sure.
Using the same model, Ollama CPU, IPEX CPU and IPEX GPU give more or less similar results.
I couldn't reproduce hallucinations, short answers and garbage output using my benchmark (small) page.
As a personal preference, probably I prefer Mistral as my favorite model running on Intel GPU of course.
Two questions:

In order to run Mistral on Intel GPU I had to change the parameter OLLAMA_NUM_PARALLEL > 1 (it works flawlessly for 2,3 and even 4)
But if I set OLLAMA_NUM_PARALLEL > 1 then llama3.1 and Qwen2.5 do not work!

In order to run these models, I have to set again OLLAMA_NUM_PARALLEL=1 strictly.
Is it possible to change the script in a way to include support for Mistral and the other models using the same script ?

I installed Ubuntu 24.04.1 LTS on the above machine (Core i7 9700. ARC A380) and I would like to test IPEX-LLM on this Linux OS.
Your guide and the PDF I mentioned above have instructions for Ubuntu 22.04, especially your guide is very strict about that.

I don't want to degrade my Kernel or install older Ubuntu version.
Are there newer instructions for Ubuntu 24.04 regarding IPEX-LLM installation ?
Thank you.

Hi @NikosDi, we do not provide instructions for Ubuntu 24.04. Please follow our official documentation to install it.

@sgwhat
One last thing to add.
Maybe you could add in your research the possibility to embed IPEX-LLM inside official Ollama installer, just like nVidia CUDA and AMD ROCm.
Thank you

Hi @NikosDi. Regarding your previous question 1, we tested and found that when OLLAMA_NUM_PARALLEL=1, ipex-llm ollama can run mistral correctly on Arc380, which means OLLAMA_NUM_PARALLEL=1 is compatible with multiple models. Also we are curious why you have to change the OLLAMA_NUM_PARALLEL to be greater than 1.

@sgwhat
You are right.
I can't reproduce the error, but it was the same like in the beginning using llama3.1 when I didn't have OLLAMA_NUM_PARALLEL=1 at all.
The same complain about native API failed error.
So, I found out the issue.
I was changing models from inside Leo settings to test them and I was getting the error, but not only for Mistral.
It was Mistral by coincidence that I noticed the issue.
If you load a model with the script for "Ollama serve" you have to stick with this model using Intel GPU IPEX-LLM, until it unloads from VRAM memory.
Then, after memory unloading, you can change model for Leo AI without errors, using OLLAMA_NUM_PARALLEL=1 for all models, including Mistral.
If you don't want to wait for the default 5 minutes, you can close and run again "Ollama serve" script or kill instantly the loaded model with this command:
curl http://localhost:11434/api/generate -d "{"model": "$selected_model", "keep_alive": 0}"
where selected model is the one mentioned in "ollama ps" command.
When I was trying CPU models using IPEX-LLM and "ollama serve" script using OLLAMA_NUM_GPU=0, I didn't have such issues.
All models were loaded in RAM at the same time and I could change the current model from Leo settings.
I don't know if the problem exists due to limited VRAM vs RAM (6GB vs 32GB) or it's a limitation of IPEX-LLM (GPU) vs IPEX-LLM (CPU)

@NikosDi, it's because the A380 only has 6GB of VRAM available.

@user7z @sgwhat
**Windows:**
I managed to make a Windows service of the batch file (.bat) and now the Ollama IPEX-LLM is running automatically as a service.
**Ubuntu 24.04:**
I managed also to create two different scripts (using conda and python directly) under Ubuntu 24.04 which both work flawlessly.
But I'm really struggling to make these scripts run from inside a script in order to that script a service (to run automatically.
So this question is rather Linux related than Ollama or IPEX-LLM
How do I make these scripts (either one or both) run from inside a script ?
(they both run directly from Terminal)

Python

python3.11 -m venv llm_env
source llm_env/bin/activate
init-ollama
export OLLAMA_NUM_GPU=999
export no_proxy=localhost,<IP_ADDRESS>
export ZES_ENABLE_SYSMAN=1
source /opt/intel/oneapi/setvars.sh
export SYCL_CACHE_PERSISTENT=1
export OLLAMA_NUM_PARALLEL=1
./ollama serve

Conda

conda activate llm-cpp
init-ollama
export OLLAMA_NUM_GPU=999
export no_proxy=localhost,<IP_ADDRESS>
export ZES_ENABLE_SYSMAN=1
source /opt/intel/oneapi/setvars.sh
export SYCL_CACHE_PERSISTENT=1
export OLLAMA_NUM_PARALLEL=1
./ollama serve

@NikosDi i understand what your trying to do , i spend days on this reading systemd man pages , i well go to my laptop where i have the service & give to you here .

.config/systemd/$user/conda-ipex.service
#########################
[Unit]
Description=Ollama Service
Wants=network-online.target
After=network.target network-online.target
[Service]
ExecStart=/usr/bin/bash -c 'source /opt/intel/oneapi/setvars.sh && /home/user/ollama serve'
WorkingDirectory=/var/lib/ollama
Environment="HOME=/var/lib/ollama"
Environment="OLLAMA_MODELS=/var/lib/ollama"
Environment="OLLAMA_NUM_GPU=999"
Environment="no_proxy=localhost,<IP_ADDRESS>"
Environment="BIGDL_LLM_XMX_DISABLED=1"
Environment="ZES_ENABLE_SYSMAN=1"
Environment="SYCL_CACHE_PERSISTENT=1"
Environment="ONEAPI_DEVICE_SELECTOR=level_zero:0"
Restart=on-failure
RestartSec=3
RestartPreventExitStatus=1
Type=oneshot
[Install]
WantedBy=default.target
########################

After many hours of "chatting" with ChatGPT (the free without subscription model of ChatGPT 4o mini) it finally works, using the conda environment:
Shell Script:
#!/bin/bash

# Activate conda environment
source /home/nikos/miniforge3/etc/profile.d/conda.sh  # Update this with the correct Conda path
conda activate llm-cpp

# Ensure init-ollama is in the PATH (adjust as needed)
export PATH="/home/nikos/llm_env/bin:$PATH"

# Initialize Ollama
init-ollama

# Set environment variables
export OLLAMA_NUM_GPU=999
export no_proxy=localhost,<IP_ADDRESS>
export ZES_ENABLE_SYSMAN=1
source /opt/intel/oneapi/setvars.sh
export SYCL_CACHE_PERSISTENT=1
export OLLAMA_NUM_PARALLEL=1

# Start Ollama
./ollama serve

Service script:
[Unit]
Description=Ollama using IPEX-LLM for Intel GPUs
After=network.target

[Service]
EnvironmentFile=/home/nikos/Documents/ollama_env
User=nikos
Group=nikos
WorkingDirectory=/home/nikos
ExecStart=/bin/bash -i -c 'source /home/nikos/miniforge3/etc/profile.d/conda.sh && conda activate llm-cpp && /home/nikos/Documents/Script_Intel_GPU_Linux.sh'
ExecStartPre=/bin/bash -i -c 'source /home/nikos/miniforge3/etc/profile.d/conda.sh && conda activate llm-cpp'
StandardOutput=journal
StandardError=journal

[Install]
WantedBy=multi-user.target

EnvironmentFile called by service script:
HOME=/home/nikos
CONDA_BASE=/home/nikos/miniforge3

# Ensure that Conda is in the PATH
PATH=$CONDA_BASE/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:$PATH

# Set library paths
LD_LIBRARY_PATH=$CONDA_BASE/lib:$LD_LIBRARY_PATH

@user7z
Thank you for your answer and time!

@user7z
Next step is to find a nice gui for chatbox which can be used as client/ server app.
Because I want use other devices in the same LAN which have no dGPU inside (only extremely slow iGPUs) in order to have Ollama hardware acceleration.
Have you tried to use Brave Leo AI via LAN (using the PC with dGPU as a server) ?
Have you found out any nice GUI app for the same use (client/ server) via LAN ?

@NikosDi all what i did is for local use , just for my laptop ,but here is a nice portable gui i used before , its named open-webui

@NikosDi if it is what your looking for & you use podman instead of docker , i have a nice config if you need so

For brave to use ollama it doesnt need https


New version crashes on wake from sleep

macOS 10.12.1 (16B2555)
Scroll Reverser 1.7.3
Is there a way for me to gather the debug log?

With the debug window open, check Pause, and the the table rows will become selectable and copiable to the clipboard.

Or do you mean the crash log? This should be in Console.app.

My apologies, I meant crash log.
There is not report for Scroll Reverser. I tried to put the laptop to sleep and wake it, but I couldn't immediately reproduce the issue. But at least twice since the update to the latest version, after the laptop wakes from sleep, there is no Scroll Reverser icon in the menu bar.
Is there a debug build I could install to collect more information? Or I am just not finding the right location where do you write the logs?

Oh dear, it sounds like my relaunch code is failing. The relevant commit is:
https://github.com/pilotmoon/Scroll-Reverser/commit/176a2a89290fd5c57bf3ca4b72ef625e2413e89d
If so, it is not actually crashing but simply quitting itself. I wonder if the relaunch script sleep time is too short on your machine for some reason. Or perhaps it's not the timeout but something else. Maybe need a more robust relaunch method...

Thanks for a pointer, Nick. I think this code can be improved to wait until the current PID is not active:
while kill -0 $1 >/dev/null 2>&1
do
    sleep 0.01
done

echo "process '${1}' has exited"

other options: http://stackoverflow.com/questions/11425876/bash-using-while-or-until-to-wait-until-a-pid-doesnt-exist
I made a quick test, here is how it works: https://www.youtube.com/watch?v=RM7I7cpe3-8&feature=youtu.be
Never did Obj-C development before, but I try to make PR for this change.


Configure References caused side bar to hang

Installed the add-on and then click on the configure references menu option and it didn't finish loading. I left it for 10 minutes and it still never became active.

Same here. Console shows some javascript errors:
Unrecognized feature: 'ambient-light-sensor'.
userCodeAppPanel:1 Unrecognized feature: 'speaker'.
userCodeAppPanel:1 Unrecognized feature: 'web-share'.
userCodeAppPanel:1 Unrecognized feature: 'vibrate'.
userCodeAppPanel:1 Unrecognized feature: 'vr'.
900225109-warden_bin_i18n_warden.js:105 Net state changed from IDLE to BUSY
900225109-warden_bin_i18n_warden.js:217 Vp {message: 'There was an error during the transport or process…this request. Error code = 10, Path = /wardeninit', name: 'TransportError', stack: 'TransportError: There was an error during the tran…t/js/900225109-warden_bin_i18n_warden.js:206:361)'}
900225109-warden_bin_i18n_warden.js:105 Net state changed from BUSY to IDLE

I'm also experiencing this problem. Identical console errors as miguelfreitas.
Is there any way to configure the labels without this sidepanel perchance while we wait for a fix?

Exact Same issue here. It was working on Firefox, but I noticed it stopped working about three weeks ago. It is working in chrome.