Homebase3 (s380) chime api call not working

Trying to send the chime command call via the API to an S380 home base when a driveway sensor outside the eufy ecosystem pops off,  The client trace returns 'device_not_supported'.  To isolate, wrote some python directly call the ws client api.  Can send an alarm command and have it go off just fine, but not chime the base station.
With logging set to debug, the relevant portion of the trace:
    await self._api.chime(ProductType.station, Config.station, ringtone)
  File "~/eufy/eufy_security_api/api_client.py", line 258, in chime
    await self._send_message_get_response(OutgoingMessage(OutgoingMessageType.chime, serial_no=serial_no, ringtone=ringtone))
  File "~/eufy/eufy_security_api/api_client.py", line 333, in _send_message_get_response
    return await future
eufy_security_api.exceptions.FailedCommandException: {'type': 'result', 'success': False, 'messageId': 'station.chime.344886388073415fbd86db61c58e51a1', 'errorCode': 'device_not_supported'}

Have yet to start digging around debug traces in the Node.js code, but it's acting like the API for an S380 is different.  The eufy app has settings for Prompt Volume in the Audio Settings tab, and I can see it in the the dict as promptVolume, but there's another tab for Ringtone Settings , which has a switch for Homebase Alert, Homebase Ringtone Volume, and Homebase Alert Tones (which I take to be the ringtone int with metadata for 9 sounds plus default).  None of these are in the api, so I figure these parameters are uncharted territory.  So, Homebase Ringtone Volume, Homebase Alert Tones, and the command index to chime seem to be part of a newer schema.
I don't have the tools to sniff out the outgoing message type for the new chime command and the property for chime volume, if someone does, I can plug these into the test bench to see if they make it ring.
edit:  Add eufy-security-ws trace:
`2024-04-17 04:20:31.555 ERROR   eufy-security-ws        Message error
NotSupportedError  This functionality is not implemented or supported, , [object Object], NotSupportedError
error stack:
• station.ts  Station.chimeHomebase
/node_modules/eufy-security-client/src/http/station.ts:9393
• message_handler.ts  Function.handle
/src/lib/station/message_handler.ts:185
• task_queues processTicksAndRejections
internal/process/task_queues:95
• server.ts   async Client.receiveMessage
/src/lib/server.ts:125
2024-04-17 04:20:32.163 INFO    eufy-security-ws        Client disconnected with ip: <IP_ADDRESS> port: 45660 code: 1006 reason: Abnormal Closure
`

Just tried this using the node.js interactive client, it appears to be a missing set of APIs on eufy-security-ws server related to S380.  Issue filed over there, too...  will report back as this progresses

Thanks, integration is mostly a pass through between node server and home assistant, so fixing it on node side would fix it here, hopefully

Related issue is here: https://github.com/bropat/eufy-security-ws/issues/324


Do not include memory in provisioned/used storage

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1499553
It's been this way since the beginning but doesn't really make sense.
It's possible that we modeled it after VMware metrics that took into account
potential swap storage, and therefore we added disk space to memory.
This is not the norm and we can generate this VMware metric using our
existing storage and memory values.
Here is where it was added:
commit 6c6daf0f67b644889daa55d6abf59c70b29a8416
Date:   Thu Aug 13 20:06:40 2009 +0000
Added VM virtual columns for: provisioned_storage, used_storage, used_storage_by_state, uncommitted_storage

BugzID: 6394,6395

@miq-bot add_label gaprindashvili/yes
@miq-bot add_label fine/yes

It looks like stakeholders want to simplify the storage calculation to not include memory into it.  This is fine but it changes how our quotas work.  I don't know if this will cause other side effects.

cc @tinaafitz We were just talking about this yesterday.
@jrafanie You are correct that this logic was originally modeled after VMware which stores the VM memory on disk when the VM is running (I think it is the .vmem file) and we wanted to account for this file since it would allocate disk space on the datastore.
It is unclear to me if this still makes sense to apply this logic to all providers and provider types.  For example, infra vs cloud.

ok - alias_attribute did not work. #17315 shows the necessary changes to hardware.rb
As for vm_or_template, the virtual attributes do not look like they are used in our code, so the virtual delegate definitions may not be necessary. The uses clause should probably be changed.
hmm. I noticed that you changed those methods but did not change any tests - those 2 methods probably are untested.
Let me know where you are going and I'll add some tests to those methods.

It is unclear to me if this still makes sense to apply this logic to all providers and provider types. For example, infra vs cloud.

This seems pretty clear:  https://bugzilla.redhat.com/show_bug.cgi?id=1499553#c10, "Memory is not referred to as storage ever, we should not include it in the sum if we are doing the math"

I believe everything I read on the internet, so ok.
Honestly, I understand the remark but, at least for VMware, memory will use space on the datastore that cannot be used by other files.  Do we need to consider that at all?  ¯_(ツ)_/¯

hmm. I noticed that you changed those methods but did not change any tests - those 2 methods probably are untested.

yup

ok - alias_attribute did not work. #17315 shows the necessary changes to hardware.rb

I don't mind if you take the deletions.  You're way too + and not enough - ;-)

I don't mind if you take the deletions. You're way too + and not enough - ;-)

Of course I'm adding a bunch of tests, so I'm probably not going to get the full +12/-85

@gmcculloug your statement makes sense. Why it was originally included.
Performance considerations:
Lets please make this the same for all vendors. I think not including ram in disk space makes more sense here.
If we make this different for different vendors, then we need to make this a pure ruby function - and sorting / filtering will force all vms to be loaded into memory (not so good)
I added some tests (will cause merge conflicts?) and fixed the implementation of this virtual attribute - the old version potentially was returning the wrong value when it was optimized into sql.

@gmcculloug I am concerned about back-porting this change because customers using quota will see a difference in the used provisioned_storage value. It'll actually be reduced by the ram_size_in_bytes * the number of VMs for the quota source.

@tinaafitz @gmcculloug @kbrock @gtanzillo let's have a discussion next week.  Another options is to deprecate the current behavior and log that we're still doing the disks + memory for now and that we will change the current methods to do just disks and would add some new methods/virtual columns for the "old disks + memory" behavior.

@jrafanie thinking we should tear the bandaid off and just give them disk space when they ask for disk space. I do see why we would have written it the old way, but I feel we were being too clever and should just give them what they asked for.
I just want to make sure that if you change the ruby method, you also change the virtual attribute (sql) version

I think this is wrong to drop, personally, as provisioned_storage is about how much space the VM uses in entirety from the host perspective including non-guest stuff like the xml files, memory files, snapshots, etc. Unless that calls is displayed elsewhere?

I don't disagree.  It seems like it's wrong for some people and right for others.  Who's right?  Depends I guess.


Replace "MaxCDN" with "StackPath".

Only thing left is the GitHub organization and the Travis notification email.

C:\Users\XhmikosR\Desktop>curl -ILl https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0/js/bootstrap.min.js
HTTP/2 200
accept-ranges: bytes
access-control-allow-origin: *
cache-control: max-age=31104000
content-length: 48944
content-type: application/javascript; charset=utf-8
date: Tue, 27 Mar 2018 17:56:35 GMT
etag: "14d449eb8876fa55e1ef3c2cc52b0c17"
expires: Fri, 22 Mar 2019 17:56:35 GMT
last-modified: Tue, 20 Feb 2018 05:58:03 GMT
server: NetDNA-cache/2.2
vary: Accept-Encoding
x-cache: HIT
x-hello-human: Say hello back! @getBootstrapCDN on Twitter

C:\Users\XhmikosR\Desktop>curl -ILl https://stackpath.bootstrapcdn.com/bootstrap/4.0.0/js/bootstrap.min.js
HTTP/1.1 200 OK
Accept-Ranges: bytes
Access-Control-Allow-Origin: *
Cache-Control: max-age=31100565
Connection: Keep-Alive
Content-Length: 48944
Content-Type: application/javascript; charset=utf-8
Date: Tue, 27 Mar 2018 17:56:37 GMT
ETag:<PHONE_NUMBER>
Last-Modified: Tue, 20 Feb 2018 05:58:03 GMT
X-Hello-Human: 'Say hello back! @getBootstrapCDN on Twitter'
X-HW:<PHONE_NUMBER>.dop008.lo4.t,1522173397.cds043.lo4.shn,1522173397.dop008.lo4.t,1522173397.cds030.lo4.c

http/2
why the difference in cache control header
server, if it's going to stay like that, we need to fix our tests
x-cache, the same as above
the x-hello-human header has single quotes around it

Let's wait until tests are green :)
I have disabled the x-cache and server headers checks; we should decide what to with them.
PS. I think we are still hitting the timeout issue...

All right, so this PR as is, we just hit the timeout issue only. Should we merge?

There's a blocking issue with gzip not being enabled so we need to wait until this is fixed.
Apart from that, we should decide if we will leave server to say Amazon S3, replace it with something else, or just hide it.

The timeouts as usual... I'm not sure if it's the CDN's fault after all. But I don't have any solid proof for anything. I mean, locally it works, but I'm on Windows, so we still don't have the ability to run the same number of tests.


How to extract the baseline model?

Thank you for your awesome work.
Could you kindly help point out which part I can modify to extract the baseline network?
Thanks

Good question, I have been having the same doubts recently and I hope the author can provide some guidance.


Include test files

Hello @amoh-godwin! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file test_pyffmpeg.py:

Line 10:80: E501 line too long (83 > 79 characters)


core[patch]: preserve inspect.iscoroutinefunction with @beta decorator

Adjusted deprecate decorator to make sure decorated async functions are still recognized as "coroutinefunction" by inspect
Addresses #16402

thanks @Lord-Haji! could we add some simple unit tests?

Probably done here I think @baskaryan . Weird thing from the first commit was. ruff didnt throw any sort of error locally but somehow ruff seemed to fail on the GitHub Actions Workflow

Idk why I did that. Should be all good now

I'm not sure how ruff didn't throw me the error when I ran it locally.


Locked message

In my postal there is a queued message which just stays there for a week:

Message is currently being processed.
No delivery attempts yet.

According to _deliveries.html.haml this message is locked.
What is the proper way to deal with this message?

This sounds like https://github.com/atech/postal/issues/287#issuecomment-331081922
Unfortunately there isn't really a workaround at this time other than manually intervening in the database and for what its worth, so far the problem seems to be quite rare.

update queued_messages set locked_by = NULL, locked_at = NULL, retry_after = NULL;


leaderboard-content.html ToDo

[x] podium to contain media contact
[ ] add search for https://localhost:7080/leaderboard/leaderboard.html
[ ] add filters for https://localhost:7080/leaderboard/leaderboard.html

Final search optimizations:

The search doesn't work properly. When we're searching the columns of the table don't collapse, nor podium disappears if search cannot find anyone on podium
search on front page should search all athletes even if they aren't loaded there (gonna be slightly more difficult

Question for filters:

should we implement use filters from the search? maybe if it doesn't look good on the left side?


Lookout: yarn package manager

In an effort to speed up builds we should move to using yarn as the package manager.

I can't seem to get around this error -- yarn forces a breaking change in tsconfig.json:
``docker run --rm -v /Users/gwilson/Projects/armada-suprjinx:/go/src/armada -w /go/src/armada/internal/lookout/ui -e npm_config_disturl -e npm_config_registry node:16.14-buster yarn build
yarn run v1.22.18
$ react-scripts build
The following changes are being made to your tsconfig.json file:

compilerOptions.jsx must be react-jsx (to support the new JSX transform in React 17)

Creating an optimized production build...
Failed to compile.
/go/src/armada/internal/lookout/ui/src/components/job-sets/DurationPlotsTable.tsx
TypeScript error in /go/src/armada/internal/lookout/ui/src/components/job-sets/DurationPlotsTable.tsx(129,8):
'Table' cannot be used as a JSX component.
Its instance type 'Table' is not a valid JSX element.
The types returned by 'render()' are incompatible between these types.
Type 'import("/go/src/armada/internal/lookout/ui/node_modules/@types/react-virtualized/node_modules/@types/react/index").ReactNode' is not assignable to type 'import("/go/src/armada/internal/lookout/ui/node_modules/@types/react-transition-group/node_modules/@types/react/index").ReactNode'.
Type '{}' is not assignable to type 'ReactNode'.  TS2786
127 |       }}
128 |     >

129 |       <Table
|        ^
130 |         height={props.height}
131 |         width={props.width}
132 |         rowCount={props.durations.length}

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
make: *** [build-dev-lookout] Error 1

Hey team! Please add your planning poker estimate with Zenhub @ClifHouck @richscott @suprjinx @dejanzele @Sharpz7

worked for me.
docker run --rm -v /home/ubuntu/armada/:/go/src/armada -w /go/src/armada/internal/lookout/ui -e npm_config_disturl -e npm_config_registry node:16.14-buster yarn build
yarn run v1.22.18
$ react-scripts build
Creating an optimized production build...
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
Why you should do it regularly:
https://github.com/browserslist/browserslist#browsers-data-updating
Compiled successfully.
File sizes after gzip:
215.03 KB  build/static/js/2.1b9acce0.chunk.js
40.02 KB   build/static/js/main.4f568cd8.chunk.js
2.23 KB    build/static/css/main.2dc6f2d5.chunk.css
1.39 KB    build/static/js/3.92d6cc51.chunk.js
1.17 KB    build/static/js/runtime-main.ab27fb8a.js
403 B      build/static/css/2.b0c8ef5b.chunk.css
The project was built assuming it is hosted at /.
You can control this with the homepage field in your package.json.
The build folder is ready to be deployed.
You may serve it with a static server:
npm install -g serve
serve -s build
Find out more about deployment here:
https://cra.link/deployment
Done in 45.89s.

The PR is about switching to use yarn instead of npm in our build. If it works for you could you switch it as part of this PR?


Translate casts.md

the change looks good to me. thx as always.
I see a conflict in SUMMARY.md. can you rebase?

actually I can resolve and I did.


Implement clock and pwm modes

Hi there.
I managed to add third pin mode - clock.
It is just clock (using CM_GPnDIV and CM_GPnCTL registers) - no pwm (yet).
Suggestions about better method/function naming are welcomed.
I tried to be consistent with current ideology, but not sure if it makes sense.
So this:   PinMode(pin, rpio.Clock) <=> pin.Mode(rpio.Clock) <=> pin.Clock()
is analogical to:   PinMode(pin, rpio.Output) <=> pin.Mode(rpio.Output) <=> pin.Output()
and this:   SetFreq(pin, 10000) <=> pin.Freq(10000) <=> ???
is analogical to:   WritePin(pin, rpio.High) <=> pin.Write(rpio.High) <=> pin.High()
Also not sure if it might make sense to add more public methods eg. for stopping/resetting clocks.
Please merge this if you like it.

So I also implemented simple pulse width modulation functionality.
For example, to set pin to 38kHz with 1/4 duty cycle you can do:
pin.Pwm()
pin.DutyCycle(1, 4)
pin.Freq(38000 * 4)

Dimming led example:
package main

import (
        "os"
        "time"
        "github.com/stianeikeland/go-rpio"
)

func main() {
        err := rpio.Open()
        if err != nil {
                os.Exit(1)
        }
        defer rpio.Close()

        pin := rpio.Pin(19)
        pin.Mode(rpio.Pwm)
        pin.Freq(60000)
        pin.DutyCycle(0, 32)

        for i := 0; i < 5; i++ {
                for i := uint32(0); i < 32; i++ { // increasing brightness
                        pin.DutyCycle(i, 32)
                        time.Sleep(time.Second/32)
                }
                for i := uint32(32); i != 0; i-- { // decreasing brightness
                        pin.DutyCycle(i, 32)
                        time.Sleep(time.Second/32)
                }
        }
}


More of a request related to custom designs.

Can you maybe possibly add a way to edit custom designs and pro designs? specifically a way to unlock them so I can edit them in game?
I've been unable to find any existing updated tool that can do this one task...
NLSE can import and export them, tho even it seems to be unable to transfer ownership of the designs to me...
Maybe just add a way to view each existing design, and have a button to click on the ones you want to "unlock" so you can edit them in game,
I mostly only want to edit the ownership of designs I've made on https://acpatterns.com/editor that were sent to my game via the Nintendo owned phone app.
[kinda not related, but I wish someone made a bot of sorts, that uses sys_botbase, that can read the files exported from acpatterns.com, and have it automate "drawing" the designs in game, that would be heckin' neat! lol]

There’s already something for this.
https://github.com/FluffyFishGames/ACNHDesignPatternEditor

Yeah he updated that recently, but even it can't unlock the custom designs to be edited in game. oof. oh well, thanx for the input!

Yeah he updated that recently, but even it can't unlock the custom designs to be edited in game. oof. oh well, thanx for the input!

Designs are lock for a reason that are not your. If you want to edit locked designs maybe learn some coding and other things. Stop asking for things that could steal other people's hard work.

Yeah he updated that recently, but even it can't unlock the custom designs to be edited in game. oof. oh well, thanx for the input!

You can edit your current designs in the Pattern Editor from GitHub and then just change the name. When you start up your game you will then be able to edit them.

Yeah he updated that recently, but even it can't unlock the custom designs to be edited in game. oof. oh well, thanx for the input!

You can edit your current designs in the Pattern Editor from GitHub and then just change the name. When you start up your game you will then be able to edit them.

Yeah for some reason that's not working for me, But when I import a new design, it sets the name correct, but remains locked. not sure why that's happening.

Poker had another fork that has the custom designs thingy before. Not sure if that guy is still working on it or not.
I heard someone was using it to "take other people's designs and claim as their own". And got into trouble with the developer.
In other words, the feature would raise ethical questions similar to dream island dumping.
I most likely would not work on it unless I find an interest in it.


Ionic some issues on ios9

My app works completely fine in android and ios10. But I have some strange issues in ios9. In somewhere $state.go doesn't work!
I searched a lot and found this patch. But still the same issue.
Note: I use ionic package for building ios, hence I can't see the errors.
Any idea?

Hello! While we appreciate you opening an issue with us i am going to close this issue and ask that you open a new one that has the issue template filled out please. Thanks for using Ionic!

Thank you. But what do you mean by issue template?

@jgw96
Oh my god. After struggling for some days, finally I found out the solution.
I'm using default function parameters. This is supported from From ES6/ES2015. As I used this syntax:
$scope.showActionSheet = function(indexPic = false, width = 500, height = 500, allowEdit = true) {
}

ios 9 may not supporting this. (more detail here)


Patch operation Model: value part missing

With the latest NSwag/Swagger the shown Example Model has changed.
Former version:
{
"operations": [
{
"value": {},
"path": "string",
"op": "string",
"from": "string"
}
]
}
New version:
{
"operations": [
{
"path": "string",
"op": "string",
"from": "string"
}
]
}
So it seems that the value part is missing.

Is this with api explorer gen?

We changed from UseSwaggerUi to UseSwaggerUi3.

This seems to be a general Swagger 3 UI problem:
https://github.com/swagger-api/swagger-ui/issues/3642


Bug fix on: virtctl image-upload fails when a trailing slash is added to the upload proxy URL

virtctl image-upload fails when a trailing slash is added to the upload proxy URL

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

bug fix on: virtctl image-upload fails when a trailing slash is added to the upload proxy URL

Good catch!
Can you add a unit test to imageupdate_test.go so we don't inadvertently break this in the future?

Done, please review - had to add gorilla/mux package for testing

@annastopel Can you please add some positive and negative unittests for it?

Done, please review - had to add gorilla/mux package for this purpose

@davidvossel @cynepco3hahue  please review


[Bug]: GCP : ResourceId empty, _Required or _Default.

Steps to Reproduce
prowler gcp --credentials-file path
Expected behavior
A unique id should appear
Actual Result with Screenshots or Logs
"AssessmentStartTime": "2023-03-31T10:26:43.162116",
    "FindingUniqueId": "prowler-gcp-logging_log_metric_filter_and_alert_for_sql_instance_configuration_changes_enabled-gcp-goat-",
    "Provider": "gcp",
    "CheckID": "logging_log_metric_filter_and_alert_for_sql_instance_configuration_changes_enabled",
    "CheckTitle": "Ensure That the Log Metric Filter and Alerts Exist for SQL Instance Configuration Changes.",
    "CheckType": [],
    "ServiceName": "logging",
    "SubServiceName": "",
    "Status": "FAIL",
    "StatusExtended": "There are no log metric filters or alerts associated.",
    "Severity": "medium",
    "ResourceType": "MetricFilter",
    "ResourceDetails": "",
    "Description": "Ensure That the Log Metric Filter and Alerts Exist for SQL Instance Configuration Changes.",
    "Risk": "Monitoring changes to SQL instance configuration changes may reduce the time needed to detect and correct misconfigurations done on the SQL server.",
    "RelatedUrl": "",
    "Remediation": {
        "Code": {
            "NativeIaC": "",
            "Terraform": "",
            "CLI": "",
            "Other": "https://www.trendmicro.com/cloudoneconformity/knowledge-base/gcp/CloudLogging/enable-network-route-changes-monitoring.html"
        },
        "Recommendation": {
            "Text": "It is recommended that a metric filter and alarm be established for SQL instance configuration changes.",
            "Url": "https://cloud.google.com/monitoring/alerts"
        }
    },
    "Compliance": {},
    "Categories": [],
    "DependsOn": [],
    "RelatedTo": [],
    "Notes": "",
    "ProjectId": "gcp-goat-",
    "ResourceId": "",
    "ResourceName": "",
    "Location": "global"
},

How did you install Prowler?
Cloning the repository from github.com (git clone)
Environment Resource
CodeBuild and Docker container locally
OS used
MacOs
Prowler version
3.3.2
Pip version
23.0.1
Context
No response

Thanks for opening this issue @taniateixeira-codsec, I'll take a look at this shortly and I'll get back to you.
Thanks for using Prowler 🚀

Hi @taniateixeira-codsec, thank you for reaching us out!
The Resource ID is empty since you don't have any metrics. What we can do is to assign the ProjectID in that case, what do you think?

Closing this issue since it is a expected behavior, agreed by @taniateixeira-codsec via Slack.


Project Restructure

Restructure projects folder in ML and Data Analyst to that of the restructure used in Deep Learning and AI.

Restructuring completed.


Uploaded Video Displaying Different Video In Canvas

Bug Description
A different video is loading on to the canvas even though it is not in the media library.
Expected Behaviour
The video uploaded on media library should be in editor media library without interference from outside video files and load on to canvas appropriately.
Steps to Reproduce

Upload video in media library
Create new story
Drag video onto canvas
A different video that isn't in the library populates. After a few seconds the true video loads.

Screenshot of current media library: https://jmp.sh/Q8CESem
Recording of the issue: https://recordit.co/vSfOVbB0tA

Plugin Version: from PR #4039
Operating System: macOS Mojave 13-inch v. 10.14.6
Browser: Safari v. 13.1.2.

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

@LuckynaSan is this happening with all videos or just this particular video?

Also, it's not clear to me which of the items in your media library corresponds to the video you're inserting in the editor 🤔

is this happening with all videos or just this particular video?
It doesn't seem specific to the video. Here is another example.

Also, it's not clear to me which of the items in your media library corresponds to the video you're inserting in the editor 🤔
The video it's inserting doesn't existing in my media library. I've tried emptying out my media library so that the editor media library doesn't pull from there.

So I was debugging this together with @LuckynaSan and I think I found the issue(s).
The first, smaller issue noticed here is that the media library in the editor does not refresh when uploading media via the WordPress media modal (can be reached via the 'Upload' button). I think #1201 covers that bug.
The main issue reported here is a bit of an edge case, but can be reproduced as follows
Prerequisites:

it's easiest to reproduce when the media library is completely empty.
two videos, a.mp4 and b.mp4

First, upload a.mp4 to the site. It does not matter how the video is uploaded. The important part is that you then head to the editor and insert the video in a new story. This will cause the story editor to generate a poster image for the video in the background. The poster image will be named image.png  and it will be added to the video in the library on the left-hand side.
Next, head to the WordPress media library at /wp-admin/upload.php. You should see the poster image of the video with an a.mp4 overlay on it. Delete the video.
After that, ideally staying on /wp-admin/upload.php, upload b.mp4. Once done, head to the editor and insert the video in a new story. This will cause the story editor to generate a poster image for the video in the background. The poster image will be named image.png  and it will be added to the video in the library on the left-hand side.
Now you might see where I'm getting at...
Because in the first part the browser has already displayed the video poster (image.png), and the new poster has the same file name, the browser will display a cached version of that poster.
The issue goes away with a hard refresh to clear the cache.
The issue could be prevented from happening in the first place by using more unique file names for the poster.
Coincidentally, I've suggested optimizing poster image names in #3228 a while ago. While I did so more for aesthetic reasons, it could nicely fix this bug too.
So we can probably fix this issue in favor of #3228


Sometimes messages fail to open

"Something went wrong" when opening messages view

This issue is too vague. It sounds like a networking issue. I have been thinking of a retry algorithm to catch most hiccups though. Reopen if you can reliably do this.


Remove quiver dependency

Many packages use quiver as dependency. This increases the risk of having dependency conflicts. Since dartx only uses a tiny fraction of quiver it is rather easy to prevent those conflicts by copying the used code.
This PR copies DelegatingList and DelegatingIterable to dartx. Both classes are private.
This change is not breaking.

This is what I did in the first place but code coverage will suffer badly and Dart has no option to ignore files :/

The tests are nonsense but I added them 😉

Thank you very much :)


user:create Error - Ambiguous options. Pass either -o,--org or -i,--instance

Hello I am getting below error while creating a new user in Account Manager
Error: Ambiguous options. Pass either -o,--org or -i,--instance.
I am on windows and using sfcc-ci-win exe
My command is as follows. please note that my orgnization has space in the name
sfcc-ci-win user:create --org "org name" --login<EMAIL_ADDRESS>--user '{"firstName":"firstname", "lastName":"lastname", "roles": ["xchange-user","doc-user"]}'
Appreciate any help

Hi @anigandhe, you've posted this already and I've replied there at https://github.com/SalesforceCommerceCloud/sfcc-ci/issues/147#issuecomment-637394272:

the error Error: Ambiguous options. Pass either -o,--org or -i,--instance. is returned, in case you don't pass a value to --org or --instance or if you pass a value to both at the same time (non valid use case).
can you try quoting your value like this:
sfcc-ci user:create --org 'my org name' ...

As the issue seems to be solved, I will close it.


Update raw_mesh screenshot to include texture

What
Update raw_mesh screenshot to include texture.
I also removed some elements from the top bar while taking a screenshot.
When we take a screenshot we temporarily change the zoom factor to get high-res screenshots. To match, we should also be resizing the window, but we weren't. This PR also fixes this. There is a wgpu error generated, but the screenshot still works.
Before

After

Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[x] I have tested the web demo (if applicable):

Using newly built examples: app.rerun.io
Using examples from latest main build: app.rerun.io
Using full set of examples from nightly build: app.rerun.io

[x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
[x] If applicable, add a new check to the release checklist!

PR Build Summary
Docs preview
Examples preview
Recent benchmark results
Wasm size tracking

but yours is a bit nicer

let's land this after https://github.com/rerun-io/rerun/pull/5118. You probably also need my thumbnail script update


OTBR Docker Firewall

Hi @jwhui,
This still needs a review from @Vyrastas, but I wanted to run it by you first.
OTBR firewall/Docker:

Added the steps to Docker Overview
Mentioned it again in Docker Run, in case developers skipped the setup
Added a blub under features (I can take this out if it doesn't make sense here)

Happy to make any changes; just let me know.
Thanks,
Sarah

@jwhui No problem - @Vyrastas - this is ready for a review...thanks!


liboqs r3 update

dilithium names and OIDs updated
DRBG warning comment added
CCI environment upgraded
test framework patch upgraded

Looks good to me. OIDs are aligned with OpenSSL 1.1.1 and BoringSSL.

Looks good to me. OIDs are aligned with OpenSSL 1.1.1 and BoringSSL.

It better be as also all that is generated (wget -c https://raw.githubusercontent.com/open-quantum-safe/openssl/OQS-OpenSSL_1_1_1-stable/oqs-template/generate.yml :-) Then please feel free to click Approve (Review).


Add application membership methods

add application membership methods
Change-type: patch
Signed-off-by: Andrea Rosci<EMAIL_ADDRESS>
Contributor checklist

[ ] Includes tests
[ ] Includes typings
[ ] Includes updated documentation
[ ] Includes updated build output

@balena-ci rebase

@balena-ci rebase

@JSReds I think this v PR will help you get your tests passing
See: https://github.com/balena-io/balena-sdk/pull/1052

@balena-ci rebase


Unable to get ListId of source channel

Hi,
First off thanks for this script, hopefully will save people a lot of time! Unfortunately it's not working for us, it's failing on step 3:
$requestUri = $baseUri + "/sites/$($source.SiteId)/lists/?$filter=displayName eq '$($source.ChannelId)_wiki'&$select=id"
Add-Member -InputObject $source -MemberType NoteProperty -Name 'ListId' -Value $((Invoke-MgGraphRequest -Uri $requestUri).Value.Id)
The request here is failing to populate the ListId parameter, but I'm not sure why. I'm not familiar with MS graph at all. Any help much appreciated!

Hi just wanted to bump this one :)

@JordanStopford  I'm sorry I didn't see your Issue and comments earlier.
Hmm, there might be a bug when trying to copy a Wiki which is not the first Wiki that was created in that team. The data of the Wikis in Teams are stored in a List in the Site Contents of the connected SharePoint Site, and I think the list gets its name based on the channelId of the channel where the first Wiki is created in a Team.
However, the Wiki list is hidden in the GUI, so the easiest way to find it, is by using PowerShell or Graph.
Try editing the script and hardcode the List ID manually.
If you are familiar with PnP.PowerShell, you should be able to fin the list Id by doing Get-PnPList, when connected to the source team's connected SharePoint Site.
Example:
Connect-PnPOnline -Url "http://contoso.sharepoint.com/sites/sourcesite"
Get-PnPList
Now look for the list that contains the wiki data. The DisplayName of the List should be a channel ID followed by "_wiki".
You want the Lists GUID (List ID), not the DisplayName. Put in the List ID after the "-Value" Property in step 3.
I haven't tested it, so I can't confirm that this is the issue, but it's worth a try.
Let me know how it goes!


Add tremor for charts

In this PR:

I suggest adding @tremor/react for super nicely styled charts along with a few other helpful components. The library uses Tailwind + Recharts so the APIs are almost 1:1 to swap out.

The only note is that it doesn't cover ComposedChart, ScatterChart, RadarChart, RadialBarChart, Treemap, and FunnelChart.
In the scenario that the chart doesn't exist in Tremor, we're still wrapping it in the card (white background) as well as inserting a custom Tooltip component that replicates the one in Tremor.

There are some styles cleaned up. Several classes had competing utilities
For unity, I added the card to the info section as well as the Hero/Input section. Open to removing this if requested as it's a divergence from the current design.
I also swapped out the red error text for an alert banner.

Before:

After:

@whoiskatrin Can we add a linting script with prettier to normalize the style choices? This diff looks way bigger than it actually is only because I'm not sure of your settings.

@whoiskatrin Even i do have similar thoughts with respe

@whoiskatrin Can we add a linting script with prettier to normalize the style choices? This diff looks way bigger than it actually is only because I'm not sure of your settings.

@whoiskatrin even I have similar thoughts on following specific code standards mentioned in contribution guidelines. What do you think?


Bot only buying

I tried many settings and the bot is only doing "Bid" and buying and he never make "Ask" orders, so he never sells anything. Do you know what could be the reason?
I am using it on BTC/EUR, it was the same with ETH/EUR with GDAX/Coinbase.

I had the same issue. I had to set apMode to EwmaBasic to start the "Ask" orders.


chore: remove stubbed docs

Little utility pr that removes jsdoc headings that were not being used.
Originally started just doing the ones within the avm ( as there were many ) but decided to do a full find and replace

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

master

PR #4142

PR #4150

PR #4195

PR #4194

PR #4196   👈

This stack of pull requests is managed by Graphite.

Benchmark results
Metrics with a significant change:

note_trial_decrypting_time_in_ms (8): 16.5 (-84%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 6dac6504 and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,412
179,524
716,068

l1_rollup_calldata_gas
221,656
866,512
3,448,276

l1_rollup_execution_gas
314,075
984,184
3,667,865

l2_block_processing_time_in_ms
1,450 (+4%)
5,380
21,349 (+3%)

note_successful_decrypting_time_in_ms
303 (+4%)
892 (+1%)
3,215

note_trial_decrypting_time_in_ms
:warning: 16.5 (-84%)
120 (+7%)
172 (+16%)

l2_block_building_time_in_ms
16,325 (+1%)
65,171 (+2%)
257,859 (+1%)

l2_block_rollup_simulation_time_in_ms
11,906 (+1%)
47,365 (+1%)
188,104 (+1%)

l2_block_public_tx_process_time_in_ms
4,380 (+1%)
17,708 (+3%)
69,463 (+1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
15,895 (-7%)
30,033 (-3%)

note_history_successful_decrypting_time_in_ms
1,982 (-2%)
4,156 (+8%)

note_history_trial_decrypting_time_in_ms
155 (-9%)
225 (-4%)

node_database_size_in_bytes
3,514,603
3,551,325

pxe_database_size_in_bytes
29,923
59,478

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
214
44,681
25,561

private-kernel-ordering
166
43,753
14,809

base-rollup
1,198
128,338
881

root-rollup
79.3
4,088
677

private-kernel-inner
291
71,208
25,561

public-kernel-private-input
206
31,863
25,561

public-kernel-non-first-iteration
204
31,905
25,561

merge-rollup
7.74 (+1%)
2,608
881

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
15,455
32,223

Transaction processing duration by data writes.

Metric
0 new commitments
1 new commitments

tx_pxe_processing_time_ms
375 (+1%)
1,090

Metric
1 public data writes

tx_sequencer_processing_time_ms
538 (+1%)


Changlog histroy for rpms not working

When the script checks out the copr git it try to get the *.spec file from a branch name fc<fedora_version>, while it is stored in a branch named f<fedora_version>.
Since the package for fedora 28 and RHEL 8 is not uploaded to copr, there will never be a f28 branch on the repository.
A workaround for this is needed.

Fixed with V1.16.2


Add a script to generate assets

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

https://github.com/colbyfayock/next-cloudinary#uploading-example-images
https://github.com/colbyfayock/next-cloudinary/tree/main/scripts
Describe alternatives you've considered

Additional context

@Baroshem i was considering the idea of maintaining this script and the assets from https://github.com/colbyfayock/cloudinary-util
then in each of the documentation sets, we can simply refer to that, rather than repeating it everywhere
thoughts?

This sounds really good @colbyfayock.
This would allow other libraries like Next, Nuxt, or Svelte to share common code.

@colbyfayock
Do you think that I should add these scripts to the Nuxt Cloudinary package for easier local development?

i think it ideally live in each but for the sake of resuability im okay with it being in Cloudinary Util, i just haven't migrated it over there yet
as long as there's an easy way for someone to run it for any project they want to work on and its clear how to do that


Feature(strategy):  Pisa-Proxy mysql read_write_splitting config

Development Task
In Pisa-Proxy, maybe the config of read_write_spliting is like this:
[proxy.config.read_write_spliting]

[proxy.config.read_write_spliting.static]
default_target = "read"

[[proxy.config.read_write_spliting.static.rule]]
name = "read-rule"
type = ["regex"]
regex = ".*"
target = "read"
algorith_name = "random"

[[proxy.config.read_write_spliting.static.rule]]
name = "write-rule"
type = "regex"
regex = [".*"]
target = "read_write"
algorith_name = "roundrobin"

The structure of config is as follows
pub struct ReadWriteSplitting {
    #[serde(rename = "static")]
    pub undynamic: Option<ReadWriteSplittingStatic>,
}

#[derive(Debug, Serialize, Deserialize, Clone, Default)]
pub struct ReadWriteSplittingStatic {
    pub default_target: TargetRole,
    #[serde(rename = "rule")]
    pub rules: Vec<ReadWriteSplittingRule>,
}

#[derive(Debug, Serialize, Deserialize, Clone)]
#[serde(untagged)]
pub enum ReadWriteSplittingRule {
    Regex(RegexRule),
}

#[derive(Debug, Serialize, Deserialize, Clone)]
pub struct RegexRule {
    pub name: String,
    #[serde(rename = "type")]
    pub rule_type: String,
    pub regex: Vec<String>,
    pub target: TargetRole,
    pub algorithm_name: AlgorithmName,
}

#[derive(Debug, Serialize, Deserialize, Clone, PartialEq)]
#[serde(rename_all = "lowercase")]
pub enum TargetRole {
    Read,
    ReadWrite,
}

After toml parse, we can get the data is as follows:
read_write_splitting: Some(
                ReadWriteSplitting {
                    undynamic: Some(
                        ReadWriteSplittingStatic {
                            default_target: Read,
                            rules: [
                                Regex(
                                    RegexRule {
                                        name: "read-rule",
                                        rule_type: "regex",
                                        regex: [
                                            ".*",
                                        ],
                                        target: Read,
                                        algorithm_name: Random,
                                    },
                                ),
                                Regex(
                                    RegexRule {
                                        name: "write-rule",
                                        rule_type: "regex",
                                        regex: [
                                            ".*",
                                        ],
                                        target: ReadWrite,
                                        algorithm_name: RoundRobin,
                                    },
                                ),
                            ],
                        },
                    ),
                },
            ),

#88

Refers to #121


Create a security policy

What constitutes a security vulnerability in wlroots, and what should someone do if they find one?

Any suggestions?

I consider the following to be security vulnerabilities if they can be triggered by a client

Memory corruption and/or code execution
Information disclosure
Access control bypass, such as being able to use protocols that the client should not be able to use

There are probably others but those are the ones that come to mind immediately.

Note that:

Code execution in the compositor is only a vulnerability if it can bypass sandboxing or escalate privileges.
Information disclosure is also only a vulnerability if it can bypass sandboxing or disclose information requiring higher privileges.
We don't currently have any access controls on protocols, but when/if, of course.

Any bugs should of course be fixed, and it's better to err on the side of caution when handling possible vulnerabilities, but we also shouldn't scream wolf if the prerequisite for exploitation mean that the attacker could just read /proc or overwrite your profile, hence emphasis on possible sandbox bypass.
On the other hand, I don't see any need to define what a vulnerability is or listing what CWE categories we consider relevant. Instead, all we need to define is the process for reporting suspected or confirmed vulnerabilities. This will likely just involve sending an encrypted email to emersion.


Update descriptions for images in "Navigating the application" section

Codecov Report
Base: 69.90% // Head: 69.90% // No change to project coverage :thumbsup:

Coverage data is based on head (9a81924) compared to base (0f26557).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #399   +/-   ##
=========================================
  Coverage     69.90%   69.90%
  Complexity      717      717
=========================================
  Files           106      106
  Lines          2429     2429
  Branches        322      322
=========================================
  Hits           1698     1698
  Misses          610      610
  Partials        121      121

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update docs to reflect removal of LBs from addons

In istio/istio#406, we removed the load balancers for all addons. This PR updates the docs to reflect those changes.

Jenkins job istio.github.io/presubmit passed

Jenkins job istio.github.io/presubmit passed

Jenkins job istio.github.io/presubmit passed

Jenkins job istio.github.io/presubmit passed

Jenkins job istio.github.io/presubmit passed


Fix for supporting AssignmentPattern. Closes #229.

Reviewed by @tolmasky.

Needs tests.

it seems that tests are added. Nice :)


some fixes

SwiftLayoutPrinter now print multiplier information
improve IdentifierUpdater searching logic
if there is no superview in view information, it ignore calling removefromsuperview of view

fixing bugs


Extending rvsteel-api to rvsteel-soc

Added functionality for working with uart, timer.
Wrote up the memory card in rvsteel-soc.h and more.
I'm sorry, but I seem to have made changes that greatly affect the change documentation section. But I think adding this functionality will set a strategy for expanding the source code.
But I haven’t checked how it works :) I hope for you, until I added a simulation for the SoC in Verilator.

I'll try running the new code on Arty. All looks good. Do you have an FPGA board? Sometimes I do a basic check just by running the new code.

Well, it looks like I fixed what I planned :)

Cool, a guy from Brazil made a pull request a few months ago adding a version of the demo project for a Tang Nano 20k, it would be nice to have the demo project ported to the 9k variant also ;)

I just brought the latest changes in main to this branch. I'll try running on the FPGA now.

I returned the old api as it was before in rvseel-api. That's probably why everything is fine. But I also left a new API in case it is needed. If this is unnecessary functionality, then I think you can close this pull request.

I still doubt how correctly I placed the static inline functions in the header files rvsteel_mtimer.h, rvsteel_uart.h. Maybe it would be better to move them to some plib or hal. Leaving only the structure with registers.

Hello @rafaelcalcada, I'll probably leave it as it is for now. I won't split it into plib or hal.


Added option client_authentication_mode.

The current code uses client_secret_post - sending the client ID and secret in the POST body when communicating with the OP. I needed to test with an OP that only supports client_secret_basic so I added a new config option to allow for either mechanism to be used.
To do that I needed to pass the config changes into openidc_call_token_endpoint - I wound up passing "opts" in as a new first argument. That change allowed me to remove the 3rd argument (ssl_verify) argument since that value is already in opts.
If client_authentication_mode option is omitted in nginx.conf then my code will use the first value in the metadata.
Please let me know if you want me to do this in a different way.

thanks, I like it :-), a few remarks though:

the ssl_verify parameter in the openidc_call_token_endpoint function signature is now obsolete
I prefer the opts name token_endpoint_auth_method instead of client_authentication_mode to stay in line with the metadata element name
I don't think you handle the case where neither client_authentication_mode is set nor token_endpoint_auth_methods_supported is set in metadata (null pointer exception?)

if you could take care if this I'd be happy to pull

All three suggestions included. I decided to default to client_secret_basic since the spec says that should be the default.

thanks for this; I may refactor it in due time so that client authentication creds & method are passed in as parameters to the openidc_call_token_endpoint method explicitly and it is reusable across both token endpoint requests as well as token introspection

Understood. If we're talking about futures then we'll probably also have to adjust the code to restrict values to either post or basic since that's all we've implemented.
Thanks for accepting the changes.

I refactored the code in 43e8e18efff68e4a820cc3c21b797429dbc785d7; it would be nice if you could confirm that this works for you as well.

I didn't do extensive testing but a quick smoke test shows that it works. Here's the relevant portion of the log:
2016/05/10 07:41:36 [debug] 14890#0: *2 [lua] openidc.lua:417: openidc_get_token_auth_method(): no configuration setting for option so select the first method specified by the OP: client_secret_basic 2016/05/10 07:41:36 [debug] 14890#0: *2 [lua] openidc.lua:428: openidc_get_token_auth_method(): token_endpoint_auth_method result set to client_secret_basic

I'll take it for now ;-) thanks!


Edit Alias' improperly displaying typed Content' value

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:
[-] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[-] I have searched the existing issues and I'm convinced that mine is new.
Describe the bug
The Content column in the Edit Alias screen only displays the last, vertical half of the character typed in.
Tip: to validate your setup was working with the previous version, use opnsense-revert (https://docs.opnsense.org/manual/opnsense_tools.html#opnsense-revert)
To Reproduce
Steps to reproduce the behavior:

Go to Firewall > Aliases
Click on '+' to create a new alias
Set the Type to Host(s)
See the error as you attempt to enter <IP_ADDRESS> in the Content field.

Expected behavior
The entire string typed in should be displayed left to right as it is being typed.
Environment
OPNsense 20.1.5 (amd64/OpenSSL)

browser issue?

Interesting!  I'm using Brave:  Version 1.7.98 Chromium: 81.0.4044.113 (Official Build) (64-bit) - I'm on openSUSE.
This is a screenshot as I enter input:

This is a screenshot after I've entered it (you can see the values I entered):

Hi again,
I gathered some more data.
TL;DR
I see the problem even with a new profile.
Details
I created a new Linux user and ran Brave.  In this invocation no extensions or anything.  Plain vanilla Brave.
Unfortunately the problem is still there.

Hmm, as I'm new to OPNsense, I tore down and rebuilt my set up.  The problem is gone.  Hmmm.


Port wdio-concise-reporter

Proposed changes
Port wdio-concise-reporter
TO-DO:

[x] port wdio-concise-reporter
[x] cover with unit-tests

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)

Further comments
Reviewers: @webdriverio/technical-committee

Codecov Report

Merging #83 into master will increase coverage by 0.18%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage    91.9%   92.08%   +0.18%
==========================================
  Files          81       83       +2
  Lines        1655     1694      +39
  Branches      360      369       +9
==========================================
+ Hits         1521     1560      +39
  Misses        110      110
  Partials       24       24

Impacted Files
Coverage Δ

packages/wdio-concise-reporter/src/index.js
100% <100%> (ø)

packages/wdio-concise-reporter/tests/fixtures.js
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2817b3b...c7ee6b6. Read the comment docs.

Thanks for porting the reporter @andriilazebnyi 👍


Make Char Shift Function

Make a Function that Shifts the Chars in a Chunk
e.g.
abc123 => 3abc12

circular buffer type beat


Introduce vw and vh in addition to px as threshold units

I wanted a specific threshold of viewport width instead of a fixed pixel value. Thought I'd share the simple feature as a pull request.

Example:
<div data-swipe-threshold="33"
     data-swipe-unit="vw"
     data-swipe-timeout="500"
     data-swipe-ignore="false">
     Swiper, get swiping!
</div>

This sets a threshold of 33vw.

Updated the documentation accordingly.
Updated the package-lock.json while I was at it.

This is very nice, thank you @Enkrod


Downsampling in ordered point set

https://github.com/schillij95/ThaumatoAnakalyptor/blob/85e7c54ae7192e08cee0d438e6824f81e6d042cb/ThaumatoAnakalyptor/sheet_generation/pointcloud_processing.cpp#L950
What's the impact of this?

It selects only the closest and most accurate ts for a specific vector ray + angular value


Prevent Docker image rebuild on every run

Thanks for the workflow!
I've identified a potential optimization. Reviewing the workflow timing from a run , I see it currently takes 1 minute to build before spending 30 seconds on the actual edits.
We can(?) improve the overall time by prebuilding the image and reusing it in subsequent runs, rather than rebuilding the image every time we call the workflow
Thanks

@arjunbazinga Good to see you're using it! and nice idea!
I've published the built image to GitHub Container Registry. Based on my quick search results I'm hoping that is enough for GitHub workflows to find the publicly published image. Could be that you need to use @main as action version.
Could you re-trigger your workflow and let me know if this worked, please?

Hey just ran another flow, it still seems to recompute the docker image , takes more time now ~3 mins

I went down the rabbit hole of Docker GitHub actions and now understand their design decision better.
In an attempt to pull pre-built action from registry I can see that its either possible to use a GitHub repository as an action in which case the GitHub action will be rebuilt everytime, or use a docker image directly. When pulling Docker image, you need to pass all the env vars and args directly.
While both solution could work, for now I choose to not use the docker image to keep the development/testing process simpler. Specifically for the case where a new commit is published but no docker image is released. If by any chance this library became more popular I will consider the use of a pre-built docker image.
Meanwhile, if you really want to use a pre-built image, you can create a fork of this repo and change the step "Apply changes with Aider" like so:
      - name: Apply changes with Aider
        uses: docker://ghcr.io/mirrajabi/aider-github-action:latest
        timeout-minutes: ${{ inputs.chat-timeout }}
        env:
          OPENAI_API_KEY: you_openai_api_key # Optional
          ANTHROPIC_API_KEY: you_anthropic_api_key # Optional
          GEMINI_API_KEY: you_gemini_api_key # Optional
          GROQ_API_KEY: you_groq_api_key # Optional
          COHERE_API_KEY: you_cohere_api_key # Optional
          DEEPSEEK_API_KEY: you_deepseek_api_key # Optional
          OPENROUTER_API_KEY: you_openrouter_api_key # Optional
          FEATURE_REF: 'main' # The branch to run Aider on.
          MODEL: 'gpt-4o'
          AIDER_ARGS: '--yes --message "This PR is auto-generated by Aider Workflow."'

I will close this issue for now.


fix(material/dialog): don't wait for animation before moving focus

For a long time we used to move focus into the dialog after the opening animation was finished, because it allowed for the content to settle in case something like an autocomplete needed to open. This approach has caused us accessibility issues in the past, because we've had to find ways to prevent the user from interacting with content behind the dialog while the opening animation is running.
Initially we used to move focus to the dialog container before transferring it into the dialog, but that ended up interrupting the screen reader. In a later change we started returning the previous dialog ref if the same kind of dialog is opened while the animation is still running. The problem with this approach is that it doesn't allow for multiple dialog to be opened quickly (see #24037).
These changes aim to address the root cause by moving focus immediately after the dialog content is attached. If this causes regressions with autocompletes inside dialogs, we now have APIs that allow users to customize the focus behavior.
Fixes #24037.

@Splaktar the bot should post a link to the deployed dev app soon.

I'll test in ChromeVox since that was what the original a11y fix was meant to address in https://github.com/angular/components/issues/21840.

This caused 105 failures on an internal test run from 5 days ago. I looked at a sample of 12 of them and they were all screenshot diff changes where a different element was focused after opening a dialog. Most of the changes looked reasonable to me, but there was one case that was questionable. There's some example of highlighting the text of an input field on opening a dialog. With this change, it no longer highlights that text.

Given that a lot of folks seem to be blocked by this externally and that the current behavior is difficult to land internally, I've pushed an extra commit to make the instant focus opt-in. Hopefully this makes the change easier to land.


Response sequencing issue when using Session.delay()

Bot Info

SDK Platform: Node.js
SDK Version: 3.14.0
Active Channels: Facebook Messenger
Deployment Environment: AWS

Issue Description
In certain cases, users receive responses from the chatbot in the wrong order. Specifically, this occurs when typing ahead – i.e., sending a message to the bot before seeing the response from the previous one. I discovered the cause of this issue, and it relates to the use of Session.delay() to slow down the flow of responses, typically in conjunction with sendTyping().
Consider the following sequence:

ChatConnector: message received
Session.sendTyping()
Session.delay(2000)
Session.send("First response")
Session.sendTyping()
Session.delay(3000)
Session.send("Second response")
Session.sendBatch() sending 6 message(s)
ChatConnector: message received
Session.sendTyping()
Session.delay(1000)
Session.send("Third response")
Session.sendBatch() sending 3 message(s)

Assume there’s no delay between the first and second utterances from the user because they were typed quickly.  Here’s what should happen:
After 0 sec – typing dots appear
After 2 sec – “First response” appears
After 5 sec – “Second response” appears followed by typing dots
After 6 sec – “Third response” appears
Here’s what actually happens:
After 0 sec – typing dots appear
After 1 sec – “Third response” appears
After 2 sec – “First response” appears followed by typing dots
After 5 sec – “Second response” appears
The reason for this is that the third delay isn’t queued behind the first two.  The framework treats it as a fresh message and sends it immediately.
Code Example
See above for details.  I also have a proposed BotBuilder code fix for this.  I'd be happy to share it.  I'm currently applying a patch from my application code.  See attached "patches.js" file.
patches.js.zip
Reproduction Steps

Type two utterances one after the other. The first utterance should elicit a response or series of responses that include delays (e.g., for pacing). The second utterance should elicit a response or responses without delays or with a smaller delay.
Observe that responses arrive out of order.  If you look at the logs, you can see they are also sent in the wrong order.

This is reproducible on the emulator as well.
Expected Behavior
Responses should be sent in the correct order.
Actual Results
See attached video for an example of this.  First I type “help” which has a 10-second response delay (for the sake for demonstrating the issue).  While the clock is ticking, I type “bye” which has a 1-second response delay.  As you can see, the “bye” response comes out first and eventually the two-part help response appears.  Very confusing from a user standpoint.
Msg_ordering_issue.mov.zip

We recommend bots be developed in a way that is resilient and account for users sending messages quickly in succession.  Your middleware solution looks good.  Thank you for sharing.

Thanks, @EricDahlvang.  Would you like me to make a pull request, or is this something Microsoft plans to address?

It seems to me that this is something left to the bot developer by design.  It is specific to the bot implementation, and does not necessarily apply to every bot.  With that in mind, it feels like it should not be in the sdk directly. What are you thoughts?

Can you please let us know if the issue still persists?

I've been using a workaround, so I'm not sure.  Has a fix been added to the framework?

Sorry @dan-cohn but we have not yet added something like this to the sdk.  I've labeled this as a feature request.

Thank you for opening an issue against the Bot Framework SDK v3. As part of the Bot Framework v4 release, we’ve moved all v3 work to a new repo located at https://github.com/microsoft/botbuilder-v3. We will continue to support and offer maintenance updates to v3 via this new repo.
From now on, https://github.com/microsoft/botbuilder repo will be used as hub, with pointers to all the different SDK languages, tools and samples repos.
As part of this restructuring, we are closing all tickets in this repo.
For defects or feature requests, please create a new issue in the new Bot Framework v3 repo found here:
https://github.com/microsoft/botbuilder-v3/issues
For Azure Bot Service Channel specific defects or feature requests (e.g. Facebook, Twilio, Teams, Slack, etc.), please create a new issue in the new Bot Framework Channel repo found here:
https://github.com/microsoft/botframework-services/issues
For product behavior, how-to, or general understanding questions, please use Stackoverflow.
https://stackoverflow.com/search?q=bot+framework
Thank you.
The Bot Framework Team


Fish hatched dual equip does not work in the Crypt

8cb3611 should make the Crypt work, but there is an underlying issue in the outfit code somewhere.

the tryCape function appends its inputs onto the end of the inputted array. The Outfit.create() method runs outfit.equip() in order of items' appearance in the Task's associated items. The outfit.equip() method assigns weapon to the first weapon inputted, and off-hand to the second.
The simplest fix would be to use .unshift() in tryCape rather than .push(). A more complex but possibly more rewarding fix would be to allow Task.equip to specify slot-item pairs, although you would have to make outfit.equip() be able to account for that more complex logic. phccs has moved towards a slightly different setup as it used to--it stores outfits as Objects rather than as Maps, which may? make this easier?
I think switching to unshift is probably good enough. Although I'm also not entirely convinced fish hatchet beats carnivorous potted plant in the offhand for the cranny, so it may be a moot point. Still probably worth fixing in case that code gets recycled later on in life.

Thanks for debugging this! I will take a crack at refactoring the outfit code more generally later today.


Fix npm vulnerabilities

Fix issues reported by npm audit of jupyter-web-app component.

Created a new branch: https://github.com/StatCan/kubeflow/tree/try-npm-fix to solve these vulnerabilities.
I am still unable to fully test these changes so did not create a PR for this issue yet either.

Closing as duplicate of StatCan/jupyter-apis#1.


feat: allow go publishing for non-public git repos

Fixes #664

Hi, change seems simple enough. But I'm having a hard time figuring out why this limitation exist in the first time. Not keen to remove it before I get to the bottom of it. Please bear with me.

Closing this. We can't just remove the check because we are cloning the repo with credentials so we can later publish (push) the release as a tag.
This makes a (large) assumption that the auth is for GitHub.
It might actually work for other providers as well, but we will need to check and potentially warn.


Import issues on ttn v3

Export of live V2 device could not be imported on V3.
Errorcode included below.
The issue is caused by the “session”-part of the json-object. If removed the session part it works fine.
{
“code”: 3,
“message”: “error:pkg/networkserver:field_mask (invalid field mask)”,
“details”: [
{
“@type”: “type.googleapis.com/ttn.lorawan.v3.ErrorDetails”,
“namespace”: “pkg/networkserver”,
“name”: “field_mask”,
“message_format”: “invalid field mask”,
“correlation_id”: “16fbb93b94fd49efab19e36ed5815f6f”,
“cause”: {
“namespace”: “pkg/ttnpb”,
“name”: “prohibited_field”,
“message_format”: “field {field} is prohibited”,
“attributes”: {
“field”: “session.keys.nwk_s_enc_key.key”
},
“code”: 2
},
“code”: 3
}
],
“request_details”: {
“url”: “/ns/applications/showcase/devices/leonardo005”,
“method”: “put”,
“stack_component”: “ns”
}
}

Hi @edhowork, thanks for reporting. This is a known issue, see also https://github.com/TheThingsNetwork/lorawan-stack-migrate/issues/23#issuecomment-805665046.
For the time being, the solution is to export devices with --ttnv2.with-session=false.
Hope this helps.

The documentation states that migrating active sessions will be available only from the incoming v3.12.0 release. Hence, I'm closing this issue. @neoaggelos please indicate if anything else needs to be done here.


Block edge 4.3.33

4.3.33 needs to be disabled:
2 clusters currently failing (14%),  0 gone ( 0%),and 12 successful (86%), out of 14 who attempted the update over 7d
Currently failing classification:
* Untriaged: 2

4.3.33 needs to be disabled:
12 clusters currently failing (29%),  8 gone (20%),and 19 successful (46%), out of 41 who attempted the update over 7d
Currently failing classification:
* API crashlooping: 1
* Logging issues: 1
* SDN issue: 1
* Single master: 1
* Slow etcd: 2
* UPI router degraded: 1
* Untriaged: 8

4.3.33 needs to be disabled:
15 clusters currently failing (25%), 13 gone (22%),and 30 successful (51%), out of 59 who attempted the update over 7d
Currently failing classification:
* Logging issues: 1
* SDN issue: 1
* Single master: 2
* Slow etcd: 3
* UPI router degraded: 1
* Untriaged: 11


[DUOS-1971][risk=no] Use the V2 Algorithm for DAR match generation

Addresses
https://broadworkbench.atlassian.net/browse/DUOS-1971
This PR:

Adds a version to the match table to denote which algorithm we used to store the results
Updates DAR/Dataset matching logic to query the v2 endpoint and store the results with the v2 version
Significant match service class test refactoring. The mocking was excessive and unnecessary.
DOES NOT make any changes to consent/dataset matching. Those code paths are completely deprecated at present and do not need to be touched until we start removing the relevant code altogether.

Have you read CONTRIBUTING.md lately? If not, do that first.

Label PR with a Jira ticket number and include a link to the ticket
Label PR with a security risk modifier [no, low, medium, high]
PR describes scope of changes
Get a minimum of one thumbs worth of review, preferably two if enough team members are available
Get PO sign-off for all non-trivial UI or workflow changes
Verify all tests go green
Test this change deployed correctly and works on dev environment after deployment

Can I ask about the switch from the uuid format to the DUOS formatted dataset id for the consent column? (These are the updates that occurred when testing locally, viewed on Postico)

Can I ask about the switch from the uuid format to the DUOS formatted dataset id for the consent column? (These are the updates that occurred when testing locally, viewed on Postico, for match-entity)

Datasets don't have a UUID, so we have to store something relatively unique and dataset-centric instead. This was the best choice I could think of at the moment without adding a new UUID column to datasets.

Can I ask about the switch from the uuid format to the DUOS formatted dataset id for the consent column? (These are the updates that occurred when testing locally, viewed on Postico, for match-entity)

I'm more concerned about the values for V2 failed entries. That means the ontology endpoint wasn't able to process the provided JSON.

Can I ask about the switch from the uuid format to the DUOS formatted dataset id for the consent column? (These are the updates that occurred when testing locally, viewed on Postico, for match-entity)

I'm more concerned about the values for V2 failed entries. That means the ontology endpoint wasn't able to process the provided JSON.

I think the failure here makes sense. I chose 'Other' on the DAR Form to see if the match_failure_reason inserts worked as expected (which they did).

I think the failure here makes sense. I chose 'Other' on the DAR Form to see if the match_failure_reason inserts worked as expected (which they did)

There was a legit bug here in the deserialization of ontology's response. I think I introduced it after testing functionality and didn't re-test well enough. The match column stores whether there was a match or not. The failed column stores whether consent could make a successful call to ontology which in effect tells us that there was some unknown error when making the match.

I think the failure here makes sense. I chose 'Other' on the DAR Form to see if the match_failure_reason inserts worked as expected (which they did)

There was a legit bug here in the deserialization of ontology's response. I think I introduced it after testing functionality and didn't re-test well enough. The match column stores whether there was a match or not. The failed column stores whether consent could make a successful call to ontology which in effect tells us that there was some unknown error when making the match.

Ah that explains the choice of words in for the error message contents. The corrected version is a bit more specific.

That said, for this data access request I clicked on Other, so the messages are a little confusing, but that's outside the purview of this ticket. With the recent update the PR is saving the match_entity failed status correctly and inserting failures correctly into match_failure_reason


Added resolve method to length.

Adds the .resolve(styles) method to length to allow retrieving a length as absolute (without the em part) when in the right context.
This changes fixes packages like tablex (https://github.com/PgBiel/typst-tablex) that use the following code:
#let measure-pt(len, styles) = {
    let measured-pt = measure(box(width: len), styles).width

    if measured-pt > 0pt {
        return measured-pt
    }

    measured-pt = -measure(box(width: -len), styles).width
    return measured-pt
}

measure, but as a method?

measure, but as a method?

We discussed this on Discord quickly with @laurmaedje and agreed that to-absolute was a better name since resolve is too generic and measure carries a different meaning.

Thanks!


feat: add file resource provider for EG standalone mode

What type of PR is this?

What this PR does / why we need it:
This PR implement two component for file resource provider: Notifier and ResourceStore.

Notifier monitors paths(files or dirs) on host via fsnotify, and send Write/Remove event to ResourceStore
ResourceStore load and store resources according to the received event

Which issue(s) this PR fixes:

related #1393

There're some TODOs in this PR, tracked by #3213 #3207

As discussed in today's meeting, I prefer to remove the EnvoyGatewayCustomProvider and add a flat EnvoyGatewayFileProvider(or a better name).

Custom is needed to allow for different resource and infra provider

As discussed in today's meeting, I prefer to remove the EnvoyGatewayCustomProvider and add a flat EnvoyGatewayFileProvider(or a better name).

Custom is needed to allow for different resource and infra provider

Add it later when a use case comes out?

As discussed in today's meeting, I prefer to remove the EnvoyGatewayCustomProvider and add a flat EnvoyGatewayFileProvider(or a better name).

Custom is needed to allow for different resource and infra provider

Add it later when a use case comes out? The File/Host Provider is not a custom provider, it's a known one.

use case exists today - file resource provider and host infra provider to implement standalone case, running EG in a docker container or bare metal directly w/o any API server

/retest

Do we plan on releasing this in v1.1.0 ?
cc @arkodg

yeah I'm a +1 for this, prioritizing other PRs right now, will get to this one soon

Some tests will be added after the first round of reviews.

will split changes of api/v1alpha1/validation/envoygateway_validate.go into a separate PR, since it's only a refactor and easy to conflict.

Hi, does it set -c or --config-path to switch to file-mode? how to implement the config file?

hey @shawnh2 this PR looks good, added some minor comments !

Hi, does it set -c or --config-path to switch to file-mode? how to implement the config file?

You can start file-provider mode like envoy-gateway server -c config.yaml, with config.yaml:
apiVersion: gateway.envoyproxy.io/v1alpha1
kind: EnvoyGateway
gateway:
  controllerName: gateway.envoyproxy.io/gatewayclass-controller
provider:
  type: Custom
  custom:
    resource:
      type: File
      file:
        paths: ["test/"]
logging:
  level:
    default: info

/retest


MET public home - Changing text on buttons

As a user I would like to feel more involved with issues at stake by hitting a "Take action" button instead of a "share your thoughts" button. This choice of words makes me seem more involved in community concerns.
Other examples of CTA text:
"Get started"
"Discover now"
"Explore further"
"Find out how"
"Take the next step"
"Uncover the details"
"See for yourself"
"Dig deeper"
"Start your journey"

After talking to Josh, we decided to keep the buttons as is.


[Delivers #158791587] Edit User API Endpoint

What does this PR do?
Adds edit user endpoint to the API
Description of Task to be completed
A user should be able to edit their details
PUT /api/v2/users
Tasks achieved in this PR

[x] PUT /api/v2/users

How should one test this endpoint?

Clone this repo using git clone https://github.com/JoshuaOndieki/ridemyway-api.git
Check the ReadMe for instructions on setting up the project.
git checkout ft-edit-user-158791587
Run nosetests to see the tests pass. Alternatively, run pytest

How can you help?
Review my work and let me know any semantic, technical or syntax/standards errors I may have.
I will greatly appreciate any feature/change suggestions too :smiley:
Resources & Libs
This Pivotal Tracker board was used to plan and manage the tasks.
Relevant PIvotal Tracker Stories?
#158791587

Pull Request Test Coverage Report for Build 234

246 of 270 (91.11%)  changed or added relevant lines in 15 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.8%) to 94.723%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

ridemyway/tests/tests_v2/test_auth/test_logout.py
15
16
93.75%

ridemyway/tests/tests_v2/test_user/test_fetch_user.py
14
15
93.33%

ridemyway/tests/tests_v2/test_auth/test_login.py
28
29
96.55%

ridemyway/tests/tests_v2/test_user/test_edit_user.py
38
39
97.44%

ridemyway/api/v2/resources.py
46
48
95.83%

ridemyway/api/v2/controllers/user.py
31
36
86.11%

ridemyway/api/v2/jwtblacklist.py
0
5
0.0%

ridemyway/utils/errors.py
16
24
66.67%

Totals

Change from base Build 202:
-1.8%

Covered Lines:
736

Relevant Lines:
777

💛  - Coveralls


Searching with more than 1 tag by anime-pictures.net doesn't work in a normal way

Bug description
When you want to search on anime-pictures they use 2 different deviders between tags (&& and ||). When you use just a space or one of those deviders you aren't getting the correct results from anime-pictures.net. You only get them when you use %7C%7C for || and %26%26 for &&.
Expected behavior
When you use those deviders with the source anime-pictures.net you expect them to work like they do there. (But probably only for this source and not for the others and you want it to stay a & when there is only one of them to use &denied_tags= and &aspect=)
System information
Windows 10 with the latest nightly version

How does it work if you want to mix OR and AND operators?
Does it allow parenthesis?
a && b || c v. (a && b) || c v. a && (b || c) (either might be the default depending on which operator precedence is used in anime-pictures backend)

If I look at anime-pictures.net it will accept a && b || c


feat: label quicklink

Closes #425

Updated the behavior of this PR to be a little more intuitive I think if anyone wants to give it a shot

Does this PR require some migration code for existing quick links? @kevmo314

Good catch, added a migration path in the json parsing.


nuscenes data visualization fails

Can anyone tell me how to fix it?
command:
python tools/demo.py --cfg_file tools/cfgs/dsvt_models/dsvt_plain_1f_onestage_nusences.yaml --data_path demo --ckpt ckpt/DSVT_Nuscenes_val.pth
The following error occurs when I run demo.py to test the Lidar data for nuscenes:
2024-07-31 10:22:55,076   INFO  -----------------Quick Demo of OpenPCDet-------------------------
2024-07-31 10:22:55,076   INFO  Total number of samples:        3
/home/user/anaconda3/envs/dsvt/lib/python3.9/site-packages/torch/functional.py:504: UserWarning: torch.meshgrid: in an upcoming release, it will be required to pass the indexing argument. (Triggered internally at /opt/conda/conda-bld/pytorch_1695392035629/work/aten/src/ATen/native/TensorShape.cpp:3526.)
  return _VF.meshgrid(tensors, **kwargs)  # type: ignore[attr-defined]
2024-07-31 10:22:55,186   INFO  ==> Loading parameters from checkpoint ckpt/DSVT_Nuscenes_val.pth to CPU
2024-07-31 10:22:55,213   INFO  ==> Done (loaded 449/449)
Traceback (most recent call last):
  File "/home/user/Pycharm_Project/DSVT-master/tools/demo.py", line 112, in <module>
    main()
  File "/home/user/Pycharm_Project/DSVT-master/tools/demo.py", line 94, in main
    for idx, data_dict in enumerate(demo_dataset):
  File "/home/user/Pycharm_Project/DSVT-master/tools/demo.py", line 59, in __getitem__
    data_dict = self.prepare_data(data_dict=input_dict)
  File "/home/user/Pycharm_Project/DSVT-master/pcdet/datasets/dataset.py", line 180, in prepare_data
    data_dict = self.point_feature_encoder.forward(data_dict)
  File "/home/user/Pycharm_Project/DSVT-master/pcdet/datasets/processor/point_feature_encoder.py", line 29, in forward
    data_dict['points'], use_lead_xyz = getattr(self, self.point_encoding_config.encoding_type)(
  File "/home/user/Pycharm_Project/DSVT-master/pcdet/datasets/processor/point_feature_encoder.py", line 48, in absolute_coordinates_encoding
    assert points.shape[-1] == len(self.src_feature_list)
AssertionError

I've tried removing the 'timestamp' field from POINT_FEATURE_ENCODING in nuscenes_dataset.yaml, but it still doesn't run!
POINT_FEATURE_ENCODING: {     encoding_type: absolute_coordinates_encoding,     used_feature_list: ['x', 'y', 'z', 'intensity', 'timestamp'],     src_feature_list: ['x', 'y', 'z', 'intensity', 'timestamp'], }
The error is as follows:
2024-07-31 10:34:15,288   INFO  -----------------Quick Demo of OpenPCDet-------------------------
2024-07-31 10:34:15,288   INFO  Total number of samples: 	3
/home/user/anaconda3/envs/dsvt/lib/python3.9/site-packages/torch/functional.py:504: UserWarning: torch.meshgrid: in an upcoming release, it will be required to pass the indexing argument. (Triggered internally at /opt/conda/conda-bld/pytorch_1695392035629/work/aten/src/ATen/native/TensorShape.cpp:3526.)
  return _VF.meshgrid(tensors, **kwargs)  # type: ignore[attr-defined]
2024-07-31 10:34:15,368   INFO  ==> Loading parameters from checkpoint /home/user/Pycharm_Project/DSVT-master/ckpt/DSVT_Nuscenes_val.pth to CPU
2024-07-31 10:34:15,387   INFO  Not updated weight vfe.pfn_layers.0.linear.weight: torch.Size([64, 10])
2024-07-31 10:34:15,387   INFO  ==> Done (loaded 448/449)
2024-07-31 10:34:15,543   INFO  Visualized sample index: 	1
Traceback (most recent call last):
  File "/home/user/Pycharm_Project/DSVT-master/tools/demo.py", line 112, in <module>
    main()
  File "/home/user/Pycharm_Project/DSVT-master/tools/demo.py", line 100, in main
    V.draw_scenes(
  File "/home/user/Pycharm_Project/DSVT-master/tools/visual_utils/open3d_vis_utils.py", line 70, in draw_scenes
    vis = draw_box(vis, ref_boxes, (0, 1, 0), ref_labels, ref_scores)
  File "/home/user/Pycharm_Project/DSVT-master/tools/visual_utils/open3d_vis_utils.py", line 109, in draw_box
    line_set.paint_uniform_color(box_colormap[ref_labels[i]])
IndexError: list index out of range

Please note that the demo.py file is cloned directly from the original pcdet repository and has not been validated or tested by our team.


Update numpy comparators

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (2c98879) 100.00% compared to head (ae30422) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #220   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           40        40
  Lines         1584      1585    +1
  Branches       276       276
=========================================
+ Hits          1584      1585    +1

Files Changed
Coverage Δ

src/coola/comparators/__init__.py
100.00% <100.00%> (ø)

src/coola/comparators/numpy_.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


HBASE-24401 Cell size limit check on append should consider 0

or less value to disable the check

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 38s
branch-2 passed

+1 :green_heart:
checkstyle
1m 14s
branch-2 passed

+1 :green_heart:
spotbugs
1m 58s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 10s
the patch passed

+1 :green_heart:
checkstyle
1m 12s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 50s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m  4s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

33m 14s

Subsystem
Report/Notes

Docker
Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1744/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1744

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 23f01e298e85 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / fbe0da2672

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1744/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 20s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m  4s
branch-2 passed

+1 :green_heart:
compile
0m 59s
branch-2 passed

+1 :green_heart:
shadedjars
5m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 38s
the patch passed

+1 :green_heart:
compile
0m 58s
the patch passed

+1 :green_heart:
javac
0m 58s
the patch passed

+1 :green_heart:
shadedjars
5m 32s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 34s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
204m  0s
hbase-server in the patch passed.

230m  5s

Subsystem
Report/Notes

Docker
Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1744/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1744

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e11429ecae93 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / fbe0da2672

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1744/1/testReport/

Max. process+thread count
2611 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1744/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Sorry ,i will close this pr.


updated documentation to include elevator pitch

Codecov Report

Merging #23 (321fc82) into main (056b946) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #23   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           12        12
  Lines          662       662
=========================================
  Hits           662       662


Add a dependabot configuration

This does automated version updates on go, docker and github actions ecosystem.

Thanks for the contribution and sorry for the delay. Happy new year! :tada:
In an impulse I think I would prefer to stick to the current "update once before a release" schedule of doing updates of Go, dependencies, etc.
The reason for this is that I don't like the clutter in notifications, PRs and commits the automatic updates introduce to a low-traffic project like this. I will give it another thought over the next days though, just letting you know my current thoughts already.

Coming back to this ... It took me a while to take a second look at this, but I think I'll stick to the manual updating routine for now. I might reevaluate this in the future though, thanks for the idea. :bulb:


API v3 still used in manage_gitlab_project.py?

I am currently using the development branch, and it seems that as of 73bd66e2e566eb557a455032e2666e2bca6bec85 the gitlab API v3 is still used.
I was getting this error trying to add a mirror:
gitmirror@git-box:~/gitlab-mirrors$ ./add_mirror.sh --git --project-name XXX --mirror XXX
Resolving gitlab remote.
/home/gitmirror/.local/lib/python2.7/site-packages/requests/__init__.py:83: RequestsDependencyWarning: Old version of cryptography ([1, 2, 3]) may cause slowdown.
  warnings.warn(warning, RequestsDependencyWarning)
Traceback (most recent call last):
  File "lib/manage_gitlab_project.py", line 138, in <module>
    if needs_transfer(gitlab_user, gitlab_namespace, found_project):
  File "lib/manage_gitlab_project.py", line 124, in needs_transfer
    if type(project.namespace) == gitlab.v3.objects.Group:
AttributeError: 'module' object has no attribute 'v3'
There was an unknown issue with manage_gitlab_project.py

I simply changed v3 to v4 on line 124 and I was then able to add a mirror. Not sure if the issue is deeper but I could not find any other occurrences of v3 in the script. Also, in my config.sh I am specifying gitlab api v4.
Can submit a merge request if needed but first I would like to be sure that this is indeed the root cause of the issue.

Just on master.  I need to release from develop branch.

Hmm go for it.  I see what you mean now.

0.6.0 released which uses v4 GitLab API.

Hey, just a heads up. https://github.com/samrocketman/gitlab-mirrors/blob/dd28d50faf46a2744c49b90bfda8b521b79afcd6/lib/manage_gitlab_project.py#L124 appears to still use gitlab.v3 from python-gitlab which appears to have been removed in the 1.5.0 release.

Might be time to simply use raw REST.  The 3rd party libs don’t always react well and tend to be overkill for some specific needs of the project.

@kadimgh pull requests are welcome to fix it.  There’s no good reason I haven’t fixed it.  I spread myself thin across many projects and haven’t prioritized time to fix and test it.


Use cross-platform library instead of System.Drawing

https://github.com/JimBobSquarePants/ImageProcessor looks like a great cross-platform alternative -- once this is implemented, we can even go native for super performance action!

Alternatively, https://github.com/mono/SkiaSharp looks promising...

Completed, thanks to @ktos!


Don't register successRedirect route if custom one is passed in

Otherwise the developer can rename the route but they'll still get our default token page.

Closed by #70


Any plan to support mobile VR and touch inputs (virtual joystick)?

Hey @andyhall,
I am currently looking into adding VR support for mobile headsets and some touch inputs for allowing users to play with their phones.
Are these things in your list?
It would be interesting to have them. Let's see if I can make something conclusive 😄

The short answer is no, I have not done any thinking about this. However, on the mobile side it's "just" a matter of grabbing touch events and wiring them up to noa.inputs in some way. That is to say, I think you could support it without any changes to this library but I haven't tried.
For VR, I think Babylon has some kind of support for it but I don't know any details, or what it entails. I think there's a camera for it? So my guess is that a first-blush effort might involve removing the regular camera from noa.rendering._scene and adding a different one that's derived from the VR camera? But that's purely guessing!


Adds a reorderable component

This work is a component-wrapped version of @tqwewe 's leptos_drag_reorder. I think it would be a valuable addition to the thaw component library. Would you be interested in merging this?
I updated the demo, so if you trunk serve out of /demo there should be a new page named Reorderable where you can try out the UI and DX.
I'm sure there's a million tweaks we could do, namely with default styling. I'm happy to incorporate suggestions.
The initial discussion on what the UI/DX should expose is located here: https://github.com/tqwewe/leptos_drag_reorder/pull/1
If you don't want this component in Thaw, it can stay stand-alone, although my preference is of course to get it incorporated into Thaw.

Why put the Reorderable component in Thaw? Because the Reorderable component seems to be a logical component and has no strong association with UI components.

I appreciate the effort @alyjak ! I also think it could be more useful being a standalone library so its not tied to any UI specifics, and can be used with any UI library for Leptos.

Closing this pull request. Let's review the work via https://github.com/tqwewe/leptos_drag_reorder/pull/2
Thank you both.


Converting type definitions from typescript to Bridge

I think that this belongs on the Bridge Forums but I can't find any way of making posts. I have made a tool called TypeScriptToCS for Bridge.

Hi @michaelcheers
Are you logged into the forums? Top-right:

Then you should be able to post in the forums. Probably the Extensions and Plugins forum would be best for this topic:

Hope this helps.

Well,
 I can't find that button.

That is really strange. I'll check a few things.

Your forum account was waiting for the email confirmation. Maybe the email was trapped by your spam filter.
I manually approved your account. You should see the button now.

@geoffreymcgill, thank you so much.


BP-3784-Remove-Giropay-Magento-2

make sure to create the same ticket in hyva checkout

There is @vegimcarkaxhija
BP-3786 is for M2 Refactor.
CC: @AlbinaBaraliu


Maintainable API docs

context:
https://github.com/rdkit/rdkit/discussions/5178
https://github.com/MichelML/rdkit-js/issues/60
Ideas for the strategy will be added eventually

#154 this might help in semi-automating api documentation :+1:

closing in favor of #164


feat(p2p/dht): disable dht server on Light node

Implementation ideas
Currently Light node is configured in the way it runs both client and server. This seems to be not necessary, as there are Full nodes and bridge nodes that already act as servers and have much more resources to do so. We can disable dht server on LN, in favour of making it lighter.

Currently Light node is configured in the way it runs both client and server.

This is not exactly true. The LN is configured to run in the AUTO mode, which becomes the server only if dialable(detected by the AutoNAT protocol). This, in turn, ensures that LNs are real dialable servers that can contribute to the DHT network. Such a case is quite common, as Rollup FNs are Celestia LNs.
Before proceeding with this, we should prove that keeping the mode to AUTO causes some real issue or harm LNs, because it this point it does not look to me.

agree with a testing-first approach

Before proceeding with this, we should prove that keeping the mode to AUTO causes some real issue or harm LNs, because it this point it does not look to me.

I agree with having some metrics first, but with so many different purposes to run Celestia's LNs, each use case affects node churn in quite different ways, and it's hard to correlate the use cases to behaviours.
I'd say that the safest approach would be to set LNs as DHT Clients by default, making it up to the LN's configuration to alter that decision. It should be clear to Rollups' dev-teams that they should run those nodes with the DHT server flag activated to ensure an optimal performance

I'd say that the safest approach would be to set LNs as DHT Clients by default, making it up to the LN's configuration to alter that decision. It should be clear to Rollups' dev-teams that they should run those nodes with the DHT server flag activated to ensure an optimal performance

Agree, that LN are not good for being dht servers simply because they are not reliable. They also might be running in resource constraint environment or on low-end hardware. Enabling AUTO mod can contribute to less stable dht because of it.


Questions about Sdk

Tysm for sharing this repo and the detailed comments! I’ve just started working with unitree robot and was wondering if you’d have some time to chat. I have some questions about the reason for LCM and the sdk itself and your help would be greatly appreciated. Lmk if I can contact you via email or wechat.

Feel free to contact me via email or wechat(Ldt000708). I am a beginner in the field of robot RL, and I'm eager to engage in discussions and learn from our interactions. Looking forward to connecting with you all!


[BUG] Telegram: help command does not show commands for admins

Describe the bug
The "help" command does not show commands for admins, unless the "all" parameter is specified.
To Reproduce
Steps to reproduce the behavior:

Start the private chat with the Bot.
Write '/help'
See what the bot replies.

Actual behavior
The Bot does not provide help for some commands. For example, for /setprefix
Expected behavior
Since the user is the admin in the private chat, the Bot should provide help for all commands by default.

Fixed by 122d2acaf8721752706d70489041f98eeb240c2d


End to End Confidential Support for Devnet 2.0

This is already taken care of by https://github.com/oasislabs/oasis.js/pull/151


Write tests for monadic server functions

Tests can be written using Test.QuickCheck.Monadic.
Tests for pure server functions are being written as a part of #58

Will hold of with this until #80 is done.


E0d/updated review

@feanil

Where is AlertConfigApi defined? It's not in alert_config.py and good ol' git grep isn't finding it. Did you rename it and not update the examples?

Idle thought: If you structured the sdk around the models, and the models had methods like get_all, get, create, delete, etc., then you could have them all inherit from the same class and avoid the repetitive methods in cm_api.py. Not sure that's actually superior, but an interesting thought nonetheless.

In general, missing tons of docstrings

Is there any purpose to the my_api_attributes/children/etc. framework other than to prevent people from mistakenly setting nonexistent attributes of these classes? You could avoid all of that by simply making the model objects immutable, unless there's a compelling use case for them not to be.


Unify transaction cleanup in driver BDDs when opening new transactions

Usage and product changes
We add unconditional transactions cleanup when opening new transactions in driver BDDs to allow writing BDD descriptions in a direct usage fashion.

The CI won't work until we update artifacts with the new server.