Gulp AssertionError: missing path

I can't get JSHint plugin to work in my gulp.js file.
After installing the plugin: npm install gulp-jshint --save-dev and include the: var jshint = require(gulp-jshint); in my gulp.js file I get an error trying to run gulp.
assert.js:89
throw new assert.AssertionError({
^
AssertionError: missing path
at Module.require (module.js:364:3)
at require (module.js:385:17)
at Object. (/Users/felix/GitHub/gulp-test/gulpfile.js:12:14)
at Module._compile (module.js:425:26)
at Object.Module._extensions..js (module.js:432:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:311:12)
at Module.require (module.js:366:17)
at require (module.js:385:17)
at Liftoff.handleArguments (/usr/local/lib/node_modules/gulp/bin/gulp.js:116:3)
at Liftoff. (/usr/local/lib/node_modules/gulp/node_modules/liftoff/index.js:192:16)
at module.exports (/usr/local/lib/node_modules/gulp/node_modules/flagged-respawn/index.js:17:3)
at Liftoff. (/usr/local/lib/node_modules/gulp/node_modules/liftoff/index.js:185:9)
at /usr/local/lib/node_modules/gulp/node_modules/liftoff/index.js:159:9
at /usr/local/lib/node_modules/gulp/node_modules/v8flags/index.js:99:14
at /usr/local/lib/node_modules/gulp/node_modules/v8flags/index.js:38:7
Could it be something wrong with my node installation? I hade som problem in the beginning to get it all up because I hade previous installed node through there web package and now I tried to update it from the terminal and install gulp, which did not work. So I removed Node (following this: http://stackoverflow.com/questions/11177954/how-do-i-completely-uninstall-node-js-and-reinstall-from-beginning-mac-os-x) and reinstalled it via the Terminal and everything work good until this error.
I use node v5.0.0
Any ideas?

You have to quote the module name you pass to require:
var jshint = require("gulp-jshint");


Use keyword arguments when publshing messages

Hello 👋
This PR changes the signature of the publish and publish_async methods to use keyword arguments instead of positional arguments.
Currently those methods accept 5 arguments, which makes it harder to know in which order those arguments should be specified. The use of keyword arguments makes it easier to use Phobos when producing messages.

Hi @dorner 👋 I gave it a try and came up with something like this:
      def publish(p_topic = nil, p_payload = nil, p_key = nil,
                  p_partition_key = nil, p_headers = nil,
                  topic: nil, payload: nil, key: nil, partition_key: nil, headers: nil)
        topic         ||= p_topic
        payload       ||= p_payload
        key           ||= p_key
        partition_key ||= p_partition_key
        headers       ||= p_headers

        raise MissingRequiredArgumentsError if [topic, payload, key].any?(&:nil?)

        class_producer.publish(
          topic: topic, payload: payload, key: key, partition_key: partition_key, headers: headers
        )
      end

I had to set all positional arguments as optional as well, otherwise there's no way to call the method using only keyword arguments, as the arity would be wrong.
The problem is when we want to call publish like this:
subject.producer.async_publish('topic', 'message', 'key', nil, { foo: 'bar' })

The last argument are the headers, however Ruby has no way of telling whether that should be the headers argument or the start of the keyword arguments, so it complains with:
 ArgumentError:
       unknown keyword: foo

I'm not sure how to have an implementation where positional and keyword arguments coexist without having problems like the above. Any ideas?

Funnily enough this is exactly the situation that the changes in Ruby 2.7 are meant to address :)
We can try this maybe?
      def publish(*args, **kwargs)
        p_topic, p_payload, p_key, p_partition_key, p_headers = *args
        topic = kwargs[:topic] || p_topic
        payload = kwargs[:payload] || p_payload
        key = kwargs[:key] || p_key
        partition_key = kwargs[:partition_key] || p_partition_key
        headers = kwargs[:headers] || p_headers || {}

        raise MissingRequiredArgumentsError if [topic, payload, key].any?(&:nil?)
        kwargs.each do |k, v|
         next if %i(topic payload key partition_key headers).include?(k)
         headers[k] = v
        end

        class_producer.publish(
          topic: topic, payload: payload, key: key, partition_key: partition_key, headers: headers
        )
      end

@dorner But then the new version would only work with Ruby > 2.7, it would defeat the point of keeping both APIs available. Thoughts?

@cassiomarques ah, sorry if I was unclear. This works now with Ruby 2.0. 2.7 will be making some changes but what I pasted isn't using those changes.

Btw one thing I realized is although we would need the **kwargs we would not need the *args - you can leave them as individual optional arguments.

@dorner Thanks for your suggestion 👍 I think I've found a way to make it work ✅  Let me know what you think!

LGTM!

This is going to go into a 1.9.0-beta1 as per our earlier discussion.

Nice job!


python3Packages.nested-lookup: init at 0.2.23

Description of changes
Init new python module as a dependency for the upcoming package ansible-later/ansible-doctor
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@SuperSandro2000 I have applied your requested changes.

@ofborg build python3Packages.nested-lookup

Please apply the following patch to fix ofborg
diff --git a/pkgs/development/python-modules/nested-lookup/default.nix b/pkgs/development/python-modules/nested-lookup/default.nix                                                            index fb25c5e4d65..7e56158ff14 100644                                                                                --- a/pkgs/development/python-modules/nested-lookup/default.nix+++ b/pkgs/development/python-modules/nested-lookup/default.nix
@@ -1,8 +1,7 @@
 { buildPythonPackage
-, fetchPypi
+, fetchFromGitHub
 , lib
-
-# pythonPackages
+, pytestCheckHook
 , six
 }:

@@ -10,15 +9,22 @@ buildPythonPackage rec {
   pname = "nested-lookup";
   version = "0.2.23";

-  src = fetchPypi {
-    inherit pname version;
-    sha256 = "sha256-e4kAyOcG5PjDMJ694imxCfSHsVuajK4nuZAmrRHktkw=";
+  src = fetchFromGitHub {
+    owner = "russellballestrini";
+    repo = "nested-lookup";
+    # https://github.com/russellballestrini/nested-lookup/issues/47
+    rev = "c1b0421479efa378545bc71efa3b72882e8fec17";
+    sha256 = "sha256-jgfYLSsFLQSsOH4NzbDPKFIG+tWWZ1zTWcZEaX2lthg=";
   };

   propagatedBuildInputs = [
     six
   ];

+  checkInputs = [
+    pytestCheckHook
+  ];
+
   pythonImportsCheck = [ "nested_lookup" ];

   meta = with lib; {

Thanks


feature - transformer plugins

allow the usage of utterance/metadata transformers in hivemind-core before forwarding the utterance to OVOS
as an example https://github.com/JarbasHiveMind/ovos-user-id could be used to assign a user coming from a voice satellite, or more relevantly, a hivemind bridge could map users from a chat service to a internal user_id  (eg, from matrix chat)

closed by #13


Support for returning a tool result

Hi there!
First off, I just wanted to express my regards for creating the best Anthropic API client I've seen so far - early days but I hope for the best, especially with the new rush of excitement around 3.5 Sonnet 🙂
Anyhow, I noticed that the library only supports one half of the tool calling interaction at this point (as far as I can tell) - there's no way to supply a tool call result after a request. From looking at the docs, I think this is as easy as adding ToolResult(ToolResult { tool_use_id: String, content: String }) to misanthropy::Content.
I can do this tomorrow in a PR, but I just wanted to check in and see if you had any plans for this before I do it (including updating examples and docs). Cheers 🚀

Thanks for the report! Yes, that's a bit of an oversight. :) I have seen your PR - it looks good at first blush, but I want to think about the Clone on MessagesRequest. I'll merge tomorrow.


Adding up incorrect values to daily sensor on reboots

My daily total energy sensor keeps adding a certain value when rebooting my Home Assistant server, I have checked all other sensors, which do seem correct. It seems to be the same as #919

Below is a screenshot from the Home Assistant db, it happens at the red lines as you can see, but also not always

Also see: https://community.home-assistant.io/t/powercalc-virtual-power-sensors/318515/459

@Steephsel I am interested in the state history of the energy sensor sensor.alle_huishoudelijke_energy as this is probably the root cause of the issue.

@Steephsel I am interested in the state history of the energy sensor sensor.alle_huishoudelijke_energy as this is probably the root cause of the issue.

Hi Bram, see below both graph as database entries, it dips below ~4.95 on reboots

That's what I suspected. And it's the root cause of the utility meter spiking.
The energy sensor should be around 136 and stay there, but after restart you see it becoming lower values (with a few seconds in between). I think this is because after restart not all underlying energy sensors are directly available yet, and powercalc skips these from the sum.
The solution seems to be for powercalc to only listen for state changes of the individual sensors after HA is fully started. Right now it immediately starts after the group sensor is created.
My guess is the following happens.

Powercalc setup is ran. Group sensor is created. State is restored from last HA session. State = 136
EnergySensorA is created by other integration (4kwh). State = 4
EnergySensorB is created by other integration (14kWh). State = 18
EnergySensorC is created by other integration (61kW). State = 79
Home assistant is fully started. State = 136

So with my potential solution step 2-4 will not be hit anymore.
Will see what I can do, it's not an easy one because I'm unable to reproduce this myself easily.

My guess is that would be the virtual power sensor for my fridge, I tried removing it from the alle_huishoudelijk config but it doesnt let me for some reason. I'll try again at work tomorrow, give it a reboot and let u know if it dips again.

As I expected, removing the virtual power sensor solves this issue. Easy solution for me would be to leave it as it is. But my guess is more people would have this bug sooner or later, so probably best if you fix it ;)
Gap on reboot but no dip

State is unavailable

Thanks for the update. Glad this resolved it for you.
I have made a new issue #1030 to improve upon this in the future and make things more robust.
Closing this issue now.


kie-issues#886: On the DMN Editor, adding waypoints to edges that don't have a corresponding DMNEdge associated with it should create the DMNEdge and add the waypoint normally

Closes: https://github.com/apache/incubator-kie-issues/issues/886
Checklist

[x] Adding a waypoint on the edge between internal nodes
[x] Adding a waypoint on the edge targeting an external node
[x] Adding a waypoint on the edge from external node targeting internal node
[x] In non default DRD,  Adding a waypoint on the edge between internal nodes
[x] In non default DRD, Adding a waypoint on the edge targeting an external node
[x] In non default DRD, Adding a waypoint on the edge from external node targeting internal node
[x] Delete edge between internal nodes and recreate it
[x] Delete edge targeting external node - should be recreated automatically
[x] Delete edge from external node targeting internal node and recreate it
[x] In non default DRD, delete edge between internal nodes and recreate it
[x] In non default DRD, delete edge targeting external node - should be recreated automatically
[x] In non default DRD, delete edge from external node targeting internal node and recreate it

Current Behavior
In non default DRD, notice the edges waypoints

@jomarko I think this PR is fixing the problem in the wrong place. There's a mutation that adds waypoints... we only need to create an Edge at that moment, if the edge doesn't exist.

@jomarko @tiagobento The code makes sense to me, but I'm not certain about the solution. I'm just joining the discussion on this issue, so I might have missed something. Why are we adding the edge lazily? Can't we add the DMNEdge to the DRD at the same time we add the Node?

@ljmotta We could, but it's more places to handle, as there are multiple places that can add a node to a DRD. If a DMNEdge doesn't exist in the DRD, we render a default edge between the nodes, based on the DRG. Now when we want to add the waypoint, that's when the DMNEdge becomes necessary, otherwise there's no place to add the waypoint to.

@tiagobento I understand, but we will have an inconsistency between the model and what is visualized in the editor. I mean, the DRD depicts something that isn't on it. Taking a look into another issue, like https://github.com/apache/incubator-kie-issues/issues/1450 we will fall into the same problem, as it wouldn't be possible to tweak the edge properties.

Thanks @ljmotta. As we discussed, the DRG should be understood as the primary source of truth, and the DRD should be used to provide a customized depiction of it. DMNEdges, like all DMN DI elements, are optional, so we need to do the best we can to have the DRG correctly depicted even if the DRD doesn't contain visual information about it.

After private discussion with @tiagobento converted to draft and will adopt another solution for this issue.

I didn't find any issues in the manual tests. I tried some not-common scenarios too using external models and it seems everything is working.

@jomarko Conflicts...


Adapted source files to enable build in ros2 humble

Hey, these were some adaptions I had to make to get the build running with ROS2 Humble. Its probably not possible to merge right away but maybe you have some ideas how to incorporate them so we can use the master again.

Many thanks for your adaptations and pull request. We are planning the next more advanced release for august. There we will integrate your adaptations. As a reminder we leave this pull request open until then.

This will also need some adaptation in the ldmrs includes (include/sick_scan/ldmrs) for ldmrs support

@janklatte Sorry for a late reply. Your pull request is integrated in sick_scan_xd. ROS-2 humble is supported since version 2.8.3. Thanks!


Signatures 'wrapResponse' returns invalid type parameter string #90

Just wraps more than one argument in parentheses, so type parameter will be:
[(A,B) => C] instead of  [A,B => C].

@jedesah What is your take on this? :)

I see that Travis failed but there was ConnectionException. Looks like flaky test or 'works on my machine' ;)
Seems not related Signatures.

Solved by https://github.com/oncue/remotely/commit/21edf825880e2727ccab436b28de9441d7ff3070


Consider showing compiler warnings in CLI

Currently compiler warnings are not visible during pulumi up, e.g.:
//> using options "-Wunused:privates,locals"

On the other hand "-Werror", "-Wunused:privates,locals" works as expected:
Diagnostics:
  pulumi:pulumi:Stack (besom-tutorial-tutorial):
    Compiling project (Scala 3.3.1, JVM)
    [error] ./Main.scala:151:7
    [error] unused local definition
    [error]   val addLambdaPermission = lambda.Permission(
    [error]       ^^^^^^^^^^^^^^^^^^^
    Error compiling project (Scala 3.3.1, JVM)
    Compilation failed

    error: an unhandled error occurred: '/usr/local/bin/scala-cli /usr/local/bin/scala-cli run .' exited with non-zero exit code: 1

Need to re-test, after the logger fix that was merged recently.


Some integration tests are flaky

Almost all of the integration tests fail infrequently due to timeouts, refused connections or hangs. Those are probably separate issues.

[ ] Timeouts
[x] Refused connections
[x] Hangs

68478ed3f14009496c8fa8ab378631bf52947011 should have fixed the timeout. Integration tests ran 200 times (~10k requests) on my machine without an issue.


test(BigInputComponent): created unit test for BigInputComponent

fixes #271

Hi @hhubik !
Thank you for your PR! Please, can you put fixes into the commit message so that it looks like test(BigInputComponent): created unit test for BigInputComponent, fixes #271 and GitHub can auto close issue once merged.
Also please fix prettier issues in Travis CI build by running npm run prettier and commiting and rebasing (git rebase -i HEAD~1 and then use f flag to squash extra commit) changes so that we end up with the single commit, thank you!

@tomastrajan I got the prettier issue resolved in my local work branch big-input-test.  However, I am struggling a bit with the git part.  Specifically, squashing everything into one commit.  What did you mean by f flag?  Sorry, I am just starting with git.

I will open a new PR using a new branch that has only the commit we want with correct comment syntax.

@hhubik ok that will work too! And for that git thing, if you have a branch with multiple commits, you can squash them together so you will end up with the single commit. It is possible to do that on the command line with git rebase -i HEAD~2. The -i means interactive and HEAD~2 mens last 2 commits so you can do it also for more if necessary. This opens a interactive command line editor (usually vi or notepad based on the OS) which contains those commits all prepended by a flag (by default it is pick) and you can change the flag to f for the commits you want to squash so their content is preserved by commit message is removed from the history.


Use Polkascan API as oracle for certain historic data

Use cases:

Metrics to help users keep some score of Validator reliability
Data visualizations like Validator uptime over time, txn history/volume over time
Allow users to view past referenda/proposals/txns, especially ones they were involved with, without having to know exactly what block number it happened at.

Played around with this a little bit today and looks pretty straightforward, at least for the testnets it currently supports.
To show all past referenda and proposals on Alexander for example would be some filtering on this query fetch('https://polkascan.io/alexander/api/v1/system/extrinsic?filter[module_id]=democracy').then(...)
To get details about an address on Alexander, e.g. if curious about a particular council candidate's onchain information, would just be: fetch('https://polkascan.io/alexander/api/v1/system/extrinsic?filter[address]=5GBfCxEnxVcjeXidWDFoJXHroCWKhwcp6iahxFx84MWFZ7EM&page[size]=25')
So I think the appropriate way to handle this for arbitrary Substrate nodes is just check if it exists on Polkascan, if it does, then display the data, otherwise show an option to get included by raising an issue or whatever the deicsion making process is for them.

I think this applies more to Nomidot, let's keep SLUI decentralized


SecurityGroup groupName setting from UserIdGroupPair spec not working as expected

Describe the bug
We are creating/grouping multiple SecurityGroups ACK objects into a single helm chart, along with other ACK objects (VPC, Subnets, etc). Some of these SGs need to be referenced in other SGs that are part of the same chart. Based on https://aws-controllers-k8s.github.io/community/reference/ec2/v1alpha1/securitygroup/ there are few options via userIDGroupPairs when a SG needs to be referenced in another SG: groupID or groupName. Given the SG ID is not known beforehand the only option left in this case is groupName. During our testing we found out that this option doesn't work as expected and we started getting errors like:
- lastTransitionTime: "2024-04-19T20:41:14Z"
  status: "True"
  type: ACK.ReferencesResolved
- message: "InvalidParameterCombination: An IP permission for a VPC security group may only include a group ID, not a group name.\n\tstatus code: 400, request id: de0f7840-4f3d-4b8d-8e38-d7107e9a318f"
  status: "True"
  type: ACK.Recoverable
- lastTransitionTime: "2024-04-19T20:41:15Z"
  message: Unable to determine if desired resource state matches latest observed state
  reason: "InvalidParameterCombination: An IP permission for a VPC security group may only include a group ID, not a group name.\n\tstatus code: 400, request id: de0f7840-4f3d-4b8d-8e38-d7107e9a318f"
  status: Unknown
  type: ACK.ResourceSynced

or
- lastTransitionTime: "2024-04-19T20:41:15Z"
  status: "True"
  type: ACK.ReferencesResolved
- message: "VPCIdNotSpecified: No default VPC for this user\n\tstatus code: 400, request id: 1ae9d2e2-a5dc-439f-b323-909a12bfea29"
  status: "True"
  type: ACK.Recoverable
- lastTransitionTime: "2024-04-19T20:41:16Z"
  message: Unable to determine if desired resource state matches latest observed state
  reason: "VPCIdNotSpecified: No default VPC for this user\n\tstatus code: 400, request id: 1ae9d2e2-a5dc-439f-b323-909a12bfea29"
  status: Unknown
  type: ACK.ResourceSynced

Steps to reproduce
Create a security group object like:
❯ k get securitygroup ci-sbx -oyaml | k neat
apiVersion: ec2.services.k8s.aws/v1alpha1
kind: SecurityGroup
metadata:
  annotations:
    services.k8s.aws/region: us-west-2
  name: ci-sbx
spec:
  description: Applied to all instances
  egressRules:
  - fromPort: 1
    ipProtocol: tcp
    toPort: 65535
    userIDGroupPairs:
    - description: Allow all nodes to communicate
      groupName: ci-sbx-2
      userID: "<accountID>"
  ingressRules:
  - fromPort: -1
    ipProtocol: icmp
    toPort: -1
    userIDGroupPairs:
    - description: Allow all nodes to communicate ICMP
      groupName: ci-sbx-2
      userID: "<accountID>"
  name: ci-sbx
  tags:
  - key: Name
    value: ci-sbx-k8s
  - key: AckName
    value: ci-sbx
  vpcRef:
    from:
      name: ci-sbx

Check the status of the newly created object:
❯ kubectl describe securitygroup ci-sbx

Expected outcome
Security group should be created without issues.
If VPC ID is not specified inside the userIDGroupPairs, use the one referenced via the vpcRef setting.
Other options might include adding support for securitygroupref or vpcRef settings inside the userIDGroupPairs .
Environment

Kubernetes version: 1.28
Using EKS (yes/no), if so version?: yes, 1.28
AWS service targeted (S3, RDS, etc.): security groups

Should be fixed in https://github.com/aws-controllers-k8s/ec2-controller/releases/tag/v1.2.9
/close


Add region to Mailgun driver

Added ability to set region for Mailgun driver.
Added ENV var to config.
Added tests.

Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] Lint and unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added necessary documentation (if appropriate)

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Coverage decreased (-8.4%) to 84.314% when pulling 53438cea66c2838afa4afa3d04ac8835648af490 on keeross:develop into c0f565a51c837a896da0a436ce3acd05f9634907 on adonisjs:develop.

Looks neat 👌


Allow configuring additional entries for native image classpath

It would be great to have the ability to configure additional entries for the native-image --class-path option.
For some reasons I ended up writing [programmatic registration] (https://www.graalvm.org/reference-manual/native-image/Reflection/) for Graal runtime reflection via org.graalvm.nativeimage.hosted.Feature interface, where implementation needs to use external dependency.
In this situation, I will like to have the ability to configure that dependency as compileOnly, but still be able to provide it as part of the classpath for the native-image tool. I guess something like an additional Gradle configuration like graalNativeImageDependencies would solve the problem if the plugin takes it into account during the generation of the native-image classpath.
The current workaround is to use the implementation configuration for that external dependency, which is not ideal, I think.
Tnx.

This plugin is going to use, at some point, the official GraalVM native image plugin. This plugin offers an extension, NativeImageOptions which lets you add things on classpath. However, I think it's a good idea to have an additional configuration which is used to declare dependencies which are only required at image build time. Would you mind creating an issue on the official GraalVM plugin for this?


How to set date text size?

The text size I want to make larger is here: [http://prntscr.com/alhi6n]
It's for a tablet display.

Is that a screenshot from the tablet?
The library includes separate styling for sw600 which should account for most things.
In case you really want to tweak it, you can override mdtp_day_number_size

Yes it's from a tablet.

In case you really want to tweak it, you can override mdtp_day_number_size

Will you be able to create a method that sets the text size for day number display?
Also, thank you so much for creating this library, and thank God that you're replying to inquiries such as mine.

I'm not going to create a method to set this text size.
I'm on the hook to make sure that such a method works and gives sensible results with every future version of the application. This is a burden I don't want.
As I mentioned earlier, nothing prevents you from overwriting mdtp_day_number_size with a value you like more in your own application.

Okay in case someone else would want want a bigger text, I was able to increase the text size by declaring the mdtp_day_number_size on my values folder, dimen.xml and on sw600dp/dimens.xml with 12sp, and 18sp respectively for the sizes.
Normal Text Size on tablet:
[http://prntscr.com/anunf3]
Larger Text Size on tablet:
[http://prntscr.com/anunpd]
Thank you so much for this library, wduallaer.

Just for the aesthetics you might want to increase the label size as well

Already did. Thank you very much!


Allow screen scrollbar to scroll  tag contrainer

Currently (on a 1080p screen) you can only see the top 17 tags. The side navigation does not allow for you to scroll further down the list. You need to click on the side navigation and use the keyboard arrows to navigate down the list.
This PR is to allow for the main page scrollbar to scroll the tag list content as well
Current state:
Heavy tagged memo shows only 17 tags

Many memos with unique tags shows only 17 tags

PR state:
Heavy tagged memo shows all tags on scroll

Many memos with unique tags shows all tags on scroll

From testing the right side column only scroll one the center column reaches its end (reaches the load more text).

Closing the PR for now, will try to create a scroll bar that only scrolls the tags if they overflow


Add v2ld copy

Proposed changes
This PR adds feature to copy  NGSIv2 entities as NGSI-LD entities.
Types of changes
What types of changes does your code introduce to the project: Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Update only documentation, not any source code.

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

[X] I have read the CONTRIBUTING doc
[ ] I have signed the CLA
[X] I have added tests that prove my fix is effective or that my feature works
[X] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
N/A

Coverage decreased (-0.02%) to 99.984% when pulling aa96654d4ce801832b37e4439ac1e9d4e6ccd3dd on fisuda:hardening/copy_v2ld into 73c4f9c37fd41068e90ba0b09d34cbed3b6ca976 on lets-fiware:main.


Migrate toml to be on toml_edit

toml_edit already provides a toml-like API so that cargo would have just one toml API.
We'd like to move towards maintaining a single parser, moving toml_edit::easy into being the new toml
Blockers

[ ] https://github.com/toml-rs/toml_edit/issues/327
[ ] https://github.com/toml-rs/toml_edit/issues/302
[ ] https://github.com/toml-rs/toml_edit/issues/303

@samuelcolvin

How does toml_edits performance compare to toml-rs?

Last time we looked at this was when deciding if cargo could switch to toml_edit and we found micro-benchmarks to show toml_edit was up to 5% slower.  See https://github.com/rust-lang/cargo/pull/10086#issuecomment-1006751490

@epage I don't understand why you've closed all the issues and pull requests on toml-rs?
If the library is no longer maintained, mark it as such, but just closing all issues makes it harder to understand what issues toml-rs had, and harder to maintain it going forward.
You've effectively just destroyed the fastest rust toml parser.
I don't think this is a sensible or considerate way to "maintain" an open source library that many people rely on.
It would be bad enough if you were the sole or primary author, but you're not afaik.
Quite disappointed by this 😞.

Alex was looking for a new maintainer for toml and accepted my proposal for me to maintain it by moving the toml crate to be on top of toml_edit (toml_edit already duplicated tomls API).  To make development easier, I wanted to merge the repos as the two sides will be tightly integrated.  Alex and I were planning on archiving the old repo.  Closing out the Issues and PRs was to help let the authors know that the repo was being archived and development has moved to a new repo.
The toml crate will still exist.  It will receive only a negligible performance hit.  We will not have to duplicate effort between these crates anymore.

I understand that sometimes projects become unmaintained and need to be archived.
However, toml-rs/toml-rs#460 was only created 5 months ago - for a project as widely used as toml-rs, I don't think that's long enough to go from "Anyone else want to maintain this?" to "issues and pull requests deliberately closed, repo archived, no one can comment or contribute in any way!".
I think the decision to close every issue and pull request was a profound mistake, it destroys knowledge (about what issues toml-ts has/had) - or at least makes it much harder to find that knowledge. It's not like toml-rs was toxic, had major security bugs or licensing issues.
I'm also pretty surprised and worried that toml-ts has been archived so soon. There are still a significant number of packages which rely on toml-rs, which suddenly have an obsolete dependencies. Including a library I maintain rtoml. Does the new, slower library have an identical API so I can switch over easily?
How do you expect people to report bugs to toml-rs now??? You've blocked new issues and PRs. If a security vulnerability is discovered (unlikely I know), how would you propose it be reported?
@alexcrichton do you agree with what @epage has done here?

To be constructive, here's my proposal for a reasonable way to go about deprecating a library like this:

Add a prominent message to the README, explaining what's happening, and how to migrate to a new library, including any associated API changes
If the change is really urgent, comment on all/some issues saying something similar
Wait ... wait a reasonably long time for users of the library to realise and migrate way, for a library like this, perhaps a year
Archive the repo unless anyone brings up major problems with that choice during the notice period

I propose that issues closed today are re-opened and the repo is un-archived for a while, with a prominent message explaining the plan.

The package is not made obsolete by moving repositories. It is not being replaced by toml_edit, it is being rewritten to build on toml_edit. If another release without that is warranted, it can be created in this repository (you can find the crate here, as of the time of writing this it's still the same old crate, not depending on toml_edit).
Issues can be posted on this repo. I don't really understand the problem...

wait, so the code is still being used here?!
Well I'm pleased it's not completely forgotten.
That's not clear at all from the message on https://github.com/toml-rs/toml-rs.
I also think that the disruption caused by archiving the toml-rs repo isn't worth the questionable benefits of a mono-repo, but if that is going to happen, why not migrate the issues to this repo, rather than summarily closing them???

@samuelcolvin

wait, so the code is still being used here?!

Yes.
@samuelcolvin

That's not clear at all from the message on https://github.com/toml-rs/toml-rs.

I might not have been too clear in the PRs but I thought this was fairly clear for Issues,

Maintenance of this crate has moved

Meaning the crate will still exist.

we plan to move toml to be on top of toml_edit

Again, the crate will still exist, it will just depend on toml_edit.
@samuelcolvin

why not migrate the issues to this repo, rather than summarily closing them???

I've used a script in the past to migrate issues (e.g. from structopt to clap) and I considered it here but there were a lot of stale (and soon to be stale) issues over there and the work to triage all of them was going to be large.  I decided to crowd source it by asking people to check if they still care about it and migrate it over.
There are many users and only 1-2 maintainers; we can't do it alone.

I totally hear you on limited maintainers but clicking "Transfer Issue" and selecting a repo barely takes longer than closing the issue.
I'm pleased th toml-rs codebase will still be maintained, and I really appreciate the work it takes (I know how thankless open-source maintenance can be).
But I think you might have under-estimated how disruptive marking a repo with a 1k stars that is (and will remain) the top (or one of the top) links when searching "toml-rs" or "rust toml" will be.
Who knows, that might not be the case, and I might be wrong. I hope I am.

Sorry if this has been asked already, I'm sure it could be a really annoying question to get repeatedly, but I didn't see it mentioned in the existing comments, and wanted to ask rather than assume one way or the other.
Is there any intention for mitigating the compile time impact of this?
I have some crates that read toml files in build.rs (which might seem weird, but is also the plan for metabuild, FWIW), and I would very much prefer not to add 5-10s[^1] to the time before the build script even can run (because it's in a build script, this sadly must happen even for check builds). The toml crate as-is is already slow enough to make me not really want to use the format for such a purpose in the future (unfortunate, given that it's a de-facto standard for most Rust configuration and tooling).
Neither here nor there, but I care a lot more about compile-time performance than runtime in... basically all the code I have that parses toml. Large toml files are quite rare in my experience, and I'm not sure I've ever seen them outside of Cargo.lock (although they likely exist).
To be clear: I'll totally understand if the answer is "no, the maintenance burden is too much" (and I'd happily accept it if you don't think that this will ultimately necessitate a compile time hit -- you'd be in a better position than I to judge that).
Sorry to bother you if this isn't something you're interested in worrying about as a maintainer, I do get it.
[^1]: On my fastest machine, currently toml compiles in ~5s, toml_edit in ~10s, and toml_edit = {..., features=["serde", "easy"]} (which seems like the equivalent to what the future toml crate will be) in ~15s. (All times are from a clean cargo build of an otherwise empty binary that just has a single toml/toml_edit dep).

On my fastest machine, currently toml compiles in ~5s, toml_edit in ~10s, and toml_edit = {..., features=["serde", "easy"]} (which seems like the equivalent to what the future toml crate will be) in ~15s. (All times are from a clean cargo build of an otherwise empty binary that just has a single toml/toml_edit dep).

You'll notice that #327 is the first blocker listed and I am working on it right now.

Yep, sorry! Not sure how I missed that!

From comment on #327:

We plan to move toml_edit::easy into the toml crate, providing nearly the same API at nearly the same performance while reducing overall maintenance effort and allowing people who have both needs to have a common parser.

We plan to move toml_edit::easy into the toml crate, providing nearly the same API at nearly the same performance while reducing overall maintenance effort and allowing people who have both needs to have a common parser.
We do not want toml_edit in tomls public API as toml is easier to maintain compatibility on and I'd like for it to be something people can rely on not changing. Or in other words, I want to take toml to 1.0 soon after this change over happens.

So there will be another crate that does the parsing, which is used by both toml and toml_edit?

toml_edit will be the parser crate.  Just toml_edit::easy will change (be removed) and instead it will be in the toml crate, calling into toml_edit.

toml_edit will be the parser crate. Just toml_edit::easy will change (be removed) and instead it will be in the toml crate, calling into toml_edit.

Thanks for the explanation, though I am a bit worried about the extra compilation time and the increase in binary size caused by this.
I just replace toml_edit with toml in cargo-binstall and that removes 3 dependencies while reducing the size of the debug build https://github.com/cargo-bins/cargo-binstall/pull/610 , but if toml is to use toml_edit, I guess it will be no difference from just keep using toml_edit.

We can't say much about either until #327 is complete but once it is, I'd recommend trying it out and reporting back (as new issue) concrete build time and release binary size numbers for us to evaluate if the impact is bad enough and what we can do about it.
I say release binary size as that is what I expect most end-users will care about (that is what is generally distributed).  If you have a use case for debug binary size, feel free to also share that.

We can't say much about either until #327 is complete but once it is, I'd recommend trying it out and reporting back (as new issue) concrete build time and release binary size numbers for us to evaluate if the impact is bad enough and what we can do about it.

Sure

I say release binary size as that is what I expect most end-users will care about (that is what is generally distributed).  If you have a use case for debug binary size, feel free to also share that.

TBH, I also don't care about debug binary size much, I just use it to check whether a PR might increase the final release build.

I'd like to join in the conversation by saying that debug builds will matter for constraint machines.
It seems that the crate can be made no_std so it still makes sense not to bloat the size.

Once toml-rs/toml#435 is merged, all of the blockers will be resolved and we can move forward with changing out tomls parser.

#470 takes care of ser support.
That just leaves

moving around tests
identifying serde issues this fixes and closing them out
marking deprecations in 0.5


Single file usage of nix-buffer

Right now, I don't think there is a way to get nix-buffer to work without a separate dir-locals.nix. It seems like there should be a way to set it up entirely through the `file local variables'.
For instance, I have a Haskell file that doesn't have any Stack/Cabal/etc. dependencies associate with it. Is there a way I can include dependencies in it?
I basically want to setup something like this:
-- Local Variables:
-- nix-buffer-script: "with import <nixpkgs> {}; nixBufferBuilders.withPackages [
--   haskellPackages.ghcWithPackages (pkgs: with pkgs; [ random QuickCheck parsec ])
-- ]"
-- eval: (and (require 'nix-buffer nil t) (nix-buffer))
-- End:

and have it work out of the box. Is that seem reasonable? This is just me brainstorming  how to do this right now.

You could possibly use nix-buffer--nix-build for this already, but I wouldn't object to a better interface

Do you think it's okay to bypass the safety checks? In this case there's not really a "file" in the same way as for dir-locals.nix. I guess I can make it just use the file name alternatively.

Yeah, you can bypass the security checks, you're already running a file-local eval

@matthewbauer Let me know if you plan to pick this up again, or we can close it out for now.


fix typos in documents

PR Type
Documentation

Description
This PR addresses several documentation typos and formatting issues:

Corrected typos in the installation guide, PR Agent Pro overview, and custom labels documentation.
Ensured consistent formatting by adding newlines at the end of files.

Changes walkthrough 📝
Relevant filesDocumentation

index.mdCorrect typos and formatting in installation guide

docs/docs/installation/index.md
Fixed a typo in the word "your".  Ensured consistent formatting with a newline at the end of the file.

+2/-2

pr_agent_pro.mdFix typos and formatting in PR Agent Pro overview

docs/docs/overview/pr_agent_pro.md
Corrected typos in the words "committing" and "committable".  Ensured consistent formatting with a newline at the end of the file.

+3/-3

custom_labels.mdCorrect typos and formatting in custom labels documentation

docs/docs/tools/custom_labels.md
Fixed a typo in the word "your".  Ensured consistent formatting with a newline at the end of the file.

+2/-2

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

cool


allow storm topologies to use the heron state interface

To use the heron state interface uses will need to add these configs:
conf.put(com.twitter.heron.api.Config.TOPOLOGY_RELIABILITY_MODE, com.twitter.heron.api.Config.TopologyReliabilityMode.EFFECTIVELY_ONCE);
conf.registerSerialization(com.twitter.heron.api.state.HashMapState.class);
in addition to implementing the stateful component interface:
public static class AckingTestWordSpout extends BaseRichSpout implements IStatefulComponent<String, String>{
.
.
.
}

@kramasamy

Ok. Can we have the two configs at heron also available in storm namespace - users in storm namespace should not use heron namespace.
Implementing a stateful interface is fine.

The configs don’t make sense for storm though
On Sat, Mar 31, 2018 at 3:07 PM Karthik Ramasamy<EMAIL_ADDRESS>wrote:

Ok. Can we have the two configs at heron also available in storm namespace

users in storm namespace should not use heron namespace.

Implementing a stateful interface is fine.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-heron/pull/2832#issuecomment-377726795,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADcir_1wH0rnHB6-QxeT9GpGH2ENYscTks5tj_4NgaJpZM4TCoIB
.

It feels weird to use Heron namespace config - which is always needed for stateful topologies.
The second call is needed for serializing the state? If the state is always a hash map - should we register it rather than letting the programmer to do it. Again we don't want to expose anything in Heron API at the storm level.

@kramasamy this is kinda of a hack to begin with.  Storm doesn't have exactly once state.  If users want exactly once state and eloquence of the API they should use the Heron API to begin with.  This just unblocks users that want to use the heron state api with the storm api

@jerrypeng - my key argument the user needs to be aware that a configuration from Heron API required for using with Storm API - which is not a good developer experience. API namespace should be clean.

@jerrypeng I'm not sure if this is the right approach to take. You are breaking storm compatibility as well as breaking abstractions


Additional McLighting Slave Nodes

Hi guys!
I have a little problem. I've installed the McLighting v.2.2.5 as described in the wiki.
I would like to control four Mclighting nodes in sync, each one connected to its strip.
I did the steps showed in this @toblum video:
https://www.youtube.com/watch?v=lryDPMA2qpY

opened the browser digiting <McLighting_Host_name>/index2.htm
option icon >> Additional McLighting Slave Nodes (experimental) >>  typed in "McLighting HOSTNAME that I want to chain" >> SAVE
McLighting connected +1 appears in the upper right corner

but i've been able to control only the McLighting Host opened in the browser.
How can i do?
Thanks for sharing this beautiful project!

Hi @hawk090535,
this is indeed not very reliable due to the way the ESPs respond to the calls made by the browser. That's why I didn't go further with that function.
But that only one node works looks strange to me. Would the other nodes work separately?
Did you have a look at the browser console? Any erros there?
Apart from that: I you use some kind of home automation software like Node red, you may be able to control many nodes with one frontend using scripts there.
Best regards
Tobias


CPU vs GPU performane comparison for distance calc

@njit
def srch(compare_desc,  pe_descs, ): #### Process de çoklanabilir diye düşünüyorum
tupZ = [(1, 18.265, 100, 0.1)]
    for x in range(peo_descs.shape[0]):
        sim = np.dot(compare_desc, pe_descs[x].T)
        if float(dist) < threshold:
            # a_string = people_namesTUPLE[x]
            name_number = x
            a_float = dist
            an_int = x
            small_float = sim
            tupZ.append((name_number, a_float, an_int, small_float))

    return tupZ

pe_desc = nd.random_normal(0, 1, shape=(5000000, 256))
compare_desc=nd.random_normal(0, 1, shape=(1, 256))
above code is running find and at good speed in CPU .
I donw know how to write above for GPU numb version. But is it worth to try ? Is it possibly run faster in GPU ?
Is there nay body can make an GPU/Numba version for above to test speed ?
BEST

As this is a question, it would be best to start a thread on the Numba discourse: https://numba.discourse.group
When you post there, could you please post a complete executable sample code? This will make it easier to understand the example and make suggestions for implementing a GPU version. Many thanks!

Relevant discussion on discourse: https://numba.discourse.group/t/cpu-vs-gpu-version/138
Closing this issue as the discussion continues there.


Remove deprecated render attribute in widget

Hi, in file forms/boundfield.py there is a deprecated option used according this documentation https://docs.djangoproject.com/en/2.1/releases/2.1/#features-removed-in-2-1 .
I deleted "renderer=self.form.renderer" because it returned an error 500 when the function was called.
Thanks !

Looking at the documentation

Support for Widget.render() methods without the renderer argument is removed.

I'm pretty sure it's the other way around. You probably have a Widget subclass that declares a render method that doesn't accept a renderer argument.


Add net feature source

This PR adds net feature souce net_speed_xxxxxx.
For 10000Mb/s, net_speed_10000 label is set to true.
For 1000Mb/s, net_speed_1000 label is set to true.
This PR is based on #72 and must be accepted after #72 .
/cc @davidopp @dchen1107 @balajismaniam @ConnorDoyle

I can get to this post v1.8

Could you rebase on top of #72 after we merge it? That should fix the tests.

Needs rebase

@ConnorDoyle comments addressed. I have also add some unit test for net source. PTAL

Do you have docs to support the "em" prefix? Besides the old "eth" names it looks like we should consider supporting all of these: https://github.com/systemd/systemd/blob/master/src/udev/udev-builtin-net_id.c#L29
Stepping back a bit, what is the prefix list trying to prevent? You've already filtered lo and down interfaces via flags. IMO there's no harm in iterating other NICs like virtual functions.
Sorry for the late review on that part, I missed it first time through.

On Sep 6, 2017, at 12:01 AM, Ning Xie<EMAIL_ADDRESS>wrote:
@ConnorDoyle comments addressed. I have also add some unit test for net source. PTAL
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@ConnorDoyle FYI about em

https://en.wikipedia.org/wiki/Consistent_Network_Device_Naming
http://fedoraproject.org/wiki/Features/ConsistentNetworkDeviceNaming#User_Experience
http://tdt.rocks/linux_network_interface_naming.html
http://tdt.rocks/linux_network_interface_naming.html

IMO there's no harm in iterating other NICs like virtual functions.

In the previous impl, i only consider the physical network interface which must be run through for an CNI network scheme.
What is the reason to consider virtual function network interfaces as they seems have unlimited speed(correct me if i am wrong).

@ConnorDoyle It seems that there are three possible physical network interface naming schemes:

original eth
biosdevname em
systemd udev en

@ConnorDoyle @balajismaniam PTAL.

virtual function network interfaces as they seems have unlimited speed

I can only speak for VFs on Intel NICs which do report speed.
I would like to know the answer to the previous question I asked, which is: what specific problem does the prefix check solve?

I would like to know the answer to the previous question I asked, which is: what specific problem does the prefix check solve?

@ConnorDoyle For now, i think we should only consider up and none localhost physical network interfaces speed and as far as i known physical network interface name may start with eth and em. The reason for why i suggest to only collect physical network interface speed is that all network flow must be sent and receive through physical NIC. It is the bottleneck. The common question asked by developer is that "does this machine 1000M-based ethernet or 10000M-based ethernet".

virtual function network interfaces as they seems have unlimited speed
I can only speak for VFs on Intel NICs which do report speed.

First, i am not sure if VFs stands for virtual network interface, like docker0. If then, actually, i ask one of my colleagues, he told me that virtual network interface actually has unlimited speed. IIRC, i have encountered an situation that virtual network interface has a speed stated to 1000M, but can actually exceeded that easily.

Closing due to inactivity.


const bm unused in blocks.ts file

const bm = editor.Blocks
is unused and editor.Blocks is directly being called inside the addBlock function. We can remove the line.

or alternatively we can use bm at the place of editror.Blocks.add call by changing it to bm.add.


How to use contentlayer with Jest?

Is there a way to make contentlayer work with Jest?
What I have done so far:
import { render, screen } from "@testing-library/react";
import { mockRouter } from "../../../__mocks__/next";

import SomePage, { getStaticProps } from "../../../pages/some-page";

describe("SomePage", () => {
  beforeEach(() => {
    mockRouter();
  });

  test("should render hero heading", async () => {
    const { props } = await getStaticProps();
    render(<SomePage {...props} />);

    const heading = screen.getByText(/Some title/);
    expect(heading).toBeInTheDocument();
  });
});

Outputs error: Cannot find module 'contentlayer/generated' from 'pages/some-page.js'
My assumption is that the configuration of the moduleNameMapper in jest.config.js is wrong. Yet, not able to figure out.
{
  moduleNameMapper: {
    "^contentlayer/generated/(.*)$": "<rootDir>/.contentlayer/generated/$1",
  },
}

Any tips on this matter?

@kouliavtsev I haven't seen this come up yet, but my guess is that you're right in that it's an issues with your moduleNameMapper config. contentlayer/generated has a slash after it, so it likely won't match contentlayer/generated.
If you did something like this, does it work?
{
  moduleNameMapper: {
    "contentlayer/generated": "<rootDir>/.contentlayer/generated",
  },
}

@seancdavis  For some reason I am getting this error. If I try the implementation above.
Configuration error:

Could not locate module contentlayer/generated mapped as:
/Users/antonkouliavtsev/Projects/clients/appsignal/appsignal.com/.contentlayer/generated.

Please check your configuration for these entries:
{
  "moduleNameMapper": {
    "/contentlayer\/generated/": "[project-folder]/.contentlayer/generated"
  },
  "resolver": undefined
}


Folders/tag support

I admire the elegance and light-weight design of unforget.
I'm a Google Keep user as well as a Notes user. Keep doesn't support end-to-end encryption and Notes doesn't yet support syncing between multiple instances. I make heavy use of the folder functionality supported in both apps.
I read the thread on Hacker News explaining why folder support was not implemented in unforget.
Although I really prefer folders, I could almost get by with hash tags in unforget except for one thing - I can't think of an obvious way to list all the distinct hash tags in currently in use. You would have to memorise the ones you have used.

Hi Vlad, I'm happy to hear that you like Unforget. It should be fairly easy to add a separate page that lists all the tags in use where you can click on one and show all the notes with that tag. I'll add this one soon.Does this meet your needs?Adding autocompletion for tag in the search box and note editor could be the next step for later.Regards,SeanOn 20 Jun 2024, at 16:01, Vlad Lasky @.***> wrote:
I admire the elegance and light-weight design of unforget.
I'm a Google Keep user as well as a Notes user. Keep doesn't support end-to-end encryption and Notes doesn't yet support syncing between multiple instances. I make heavy use of the folder functionality supported in both apps.
I read the thread on Hacker News explaining why folder support was not implemented in unforget.
Although I really prefer folders, I could almost get by with hash tags in unforget except for one thing - I can't think of an obvious way to list all the distinct hash tags in currently in use. You would have to memorise the ones you have used.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

In the new version, when importing from Google Keep and Apple Notes, we can choose to import the folders/labels as tags.


Question: Possible to have an even-thirds layout?

I know yabai is based on BSP layout. I'm wondering if it is possible in any way to have a layout with three windows side-by-side. I haven't been able to figure out a way.

You can change the split-type/orientation before opening a window using e.g yabai -m window —insert east or afterwards using yabai -m window —toggle split, followed by yabai -m space —balance to make them all equal in size.


Bokeh server and datashader

This PR adds bokeh server and datashader to help load a large set of data (tested on 5 years of simulated exposures). It also updates bokeh to the latest version.

I'm getting this error:

@crisingulani you have to rebuild the frontend. The radio button should be a checkbox after the rebuild.


Questions about deleting messages

Is it possible to configure mox in such a way that messages are never fully deleted, or can not be deleted (only trashed) by users? I'm interested in using it in a small business setting, and this is desirable. I poked around the data dir a bit, but I'm not 100% sure what happens with deleting messages and I don't want to guess.

I unfortunately don't know how other server software is doing it. For my needs at least saving a copy of the message file in a retention folder on the server is sufficient, it doesn't have to be accessible over IMAP as long as the server admin(s) can access it. Sometimes this is a regulatory requirement, other times it's a client request for some projects (with mox, I can spin a separate email server for each project for inter-team communication, which is great!)


Added support to display aliases of command

Issue: https://github.com/fisher60/Friendo_Bot/issues/122

Pull requests should target the develop branch, not master.

Sorry! Changed it


Dynamic comment prefix based on file type?

As I can see in the code here:
https://github.com/microsoft/vscode-eslint/blob/master/server/src/eslintServer.ts#L1666-L1680
The actions for disabling are always using // or /*, but in some cases, like with files of type .yaml, a # needs to be used instead of //.
What do you think? Is that a valid use case? If so, I can open a PR ;)

Actually that does make sense and someone already started to look into this for Coffeescript. So may be you can simply extend the PR https://github.com/microsoft/vscode-eslint/pull/857/files


[FLINK-22494][ha] Introduce PossibleInconsistentStateException

What is the purpose of the change
Updating the Checkpoint Metadata store of ZooKeeper and Kubernetes might lead into situations where the data was actually written but the request still failed (due to network issue for instance). In these cases, we end up in an inconsistent state where a reference exists in ZooKeeper or the k8s ConfigMap but the corresponding Checkpoint's state is discarded due to the failure. That might cause problems during recovery.
I rejected the idea of doing the cleanup entirely in the CheckpointCoordinator since we also use the StateHandleStore implementations in the DefaultJobGraphStore.
Brief change log

Introduces PossibleInconsistentStateException
Fabric8FlinkKubeClient translates network issues into PossibleInconsistentStateException
StateHandleStore and its implementing classes handle and forward PossibleInconsistentStateException
Extends TestingLongStateHandleHelper to work with reference instead of saving the state in the handle itself. The previous implementation caused problems when deserializing the StateHandles not referencing the actual data but providing a copy of the state.
CheckpointCoordinator handles PossibleInconsistentStateException

Verifying this change
The following tests were extended:

CheckpointCoordinatorFailureTest checks the failure handling for PossibleInconsistentStateException and another exception
KubernetesStateHandleStoreTest and ZooKeeperStateHandleStoreTest were extended to cover the relevant exceptions
Fabric8FlinkKubeClientTest was extended to cover both failure cases

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: yes
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

Build failures for 02f469d and 14a487 have been addressed in the following tickets:

FLINK-22568 RescalingITCase.testSavepointRescalingInPartitionedOperatorStateList
FLINK-22571 SavepointITCase.testSavepointForJobWithIteration
FLINK-22312 YARNSessionFIFOITCase.checkForProhibitedLogContents
FLINK-22567 OrcFsStreamingSinkITCase
FLINK-22572 JsonFsStreamSinkITCase.testPart
FLINK-22566 Running Kerberized YARN application on Docker test e2e test

Thanks @rkhachatryan for your comments. I addressed all of them either through the code or with a response. Please have a look.

I finally rebase happened. I created the backports for release-1.12 and release-1.13

The reported build failure happened due to the unrelated issue FLINK-22595

Thanks for updating the PR @XComp. Merging it now.

Hey all, just found this amazing PR for fixing an issue that I have been hitting for quite a long time. I'm running Flink 1.13.2 with Kube HA enabled and filesystem storage.
I've seen this issue for the past 6 months and resolved it by cleaning up the ConfigMap since it effectively does get deleted in the filesystem but not in the CM as stated at the top of the issue?
Caused by: org.apache.flink.util.FlinkException: Could not retrieve checkpoint 9702 from state handle under checkpointID-0000000000000009702. This indicates that the retrieved state handle is broken. Try cleaning the state handle store.

I'm just looking for some clarification if this PR does fix this problem or the newly raised suggestion from @rmetzger fixes it. Thanks so much for your help!

@EnriqueL8 This PR made it into 1.13.1. With you using 1.13.2 I would say it's a new issue and might be related to what @rmetzger came up with. It's hard to come up with conclusions right away without any additional logs. May you create a ticket with the logs of a run where you experienced something like that and we could start looking into the issue.

This is the original ticket with logs https://issues.apache.org/jira/browse/FLINK-25098 and happy to provide a more up-to-date ticket with the new logs we are seeing but it's the same issue. Let me know if you need debug logs turned on or any other configuration that might help you diagnose!

Interesting that somebody else is running into this issue too. I think this issue indeed deserves a separate Jira ticket to properly investigate it. I'll file one now.

Here's the ticket, let's continue the discussion there: https://issues.apache.org/jira/browse/FLINK-28265


Possibility to customize the organization login

Now organizations can customize their login pages. Changing the background color and showing their logo in that page.

Fixes #4026.

Frontend tests were OK :+1: (details)

@juanignaciosl could you check ruby code please?

Frontend tests were OK :+1: (details)

I've made a couple of non critical comments, do whatever you want with them. :+1:

Thanks @juanignaciosl, taking them into account for sure :).

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

@javierarce could you take a look of the JS part? Thanks!

Frontend tests were OK :+1: (details)

Front-end code looks good to me :dancers:
Cool feature, by the way!

Yay! thanks @javierarce

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)


feat(messages): add Message Pact support

Adds support for invoking the pact-message binary from the
latest standalone package
Upgrades standalone to 1.33.1

NOTE: I also noticed an issue with our linting setup, and have adjusted the PR to accommodate as I was unable to run linting locally before pushing. I made the assumption that the 160 chars character was what was originally intended, and modified the source to suit. Interestingly, this meant some other lint issues weren't found, which I fixed in commit 9c0637ccbf2d02b461a77f71b975ace799a18ced.

you should always run npm test before committing/pushing ;)

Can you merge my latest changes to this PR?  I think I've fixed some more windows issues with appveyor (yay windows file locking for no reason!)

Weirdly enough, I did run npm t before pushing, but that didn't cause any issues! It now correctly runs the linting.
And yes, will rebase and push now.

All rebased and ready to go!

There was a weird build failure before - just needed to re-run it. Thanks for the approval - merging!

You going to create a new release?

Yep, should be done by now


RNA-Seq job did not produce html file as promised

Here's my job.
694bffa0-70b8-41bb-a822-4ff842f19a73
I was trying to help Josh look at the html file, but this job, run on Tuxedo with the A baumanni workshop example, did not produce an html file.  Sad.

This is because it was the old pipeline.


Create command to automatically update newrelic.yml

When adding a new configuration option to default_source.rb, we currently need to manually update newrelic.yml. It would be beneficial to add a new rake task that can automatically do this for us.

Hey team! Please add your planning poker estimate with Zenhub @fallwith @kaylareopelle @tannalynn


Unable to reproduce dtuscan65 depth values

Describe the bug
I am trying to regenerate the depth npys found inside data/sdfstudio-demo-data/dtu-scan65. I used the below command and provided the latest omnidata repo and weights. The produced npys have very similar values to the original dataset with errors in the range of ~0.001. However, when I train monosdf using these depth, the depth loss does not converge and the resulting mesh is just a flat surface without any artifact resembling a skull.
python extract_monocular_cues.py
--omnidata_path {omnidata_path}
--pretrained_model {pretrained_models}
--img_path {output_dir} --output_path {output_dir}
--task depth
To Reproduce
Use the command above to produce the depth npys inside data/sdfstudio-demo-data/dtu-scan65
Expected behavior
I should get the same results as that of the original npys.

@iAhmedMaher I think 0.001 differences is acceptable. For why using the depth loss is not working well, please refer to https://github.com/autonomousvision/sdfstudio/issues/68#issuecomment-1484270533

@niujinshuchong  Thanks for you reply. What I do not understand is why the default data works well, but my depth data generated using omnidata does not do the trick. Do you have any thoughts on what could be happening?

@iAhmedMaher Do you mean you train the default data with mono depth loss and it works well?

yes exactly. With the default data, a skull is clear in the produced mesh after 2000 iterations. With my depth, the mesh is just a flat plane.

That's very strange. Could you try to replace the provided depth *.npy files with your newly generated depth files and try again? Or is that what you did?

that's what I did, and surprisingly, if I add a Gaussian noise of mean 0 and std of 0.0005 to the default depth npys (the ones that work well), I get a mesh which looks like a flat plane.

Could you share your training command?

Sure, here it is
ns-train monosdf --trainer.max-num-iterations 2000 --trainer.steps-per-save 100 \ --pipeline.model.sdf-field.inside-outside False \ --vis viewer --experiment-name exp_name sdfstudio-data \ --data <path to modified data folder> \ --include_mono_prior True

You need to add --pipeline.datamanager.train-num-images-to-sample-from 1 --pipeline.datamanager.train-num-times-to-repeat-images 0 to the command to use monocular depth loss since we need to compute the scale and shift between the rendered depth map and monocular depth map and therefore all the rays should come from the same image. (But still surprise that in some datasets e.g. replica it also works even we sample training rays across all images.)

Thanks, did not know that, will use this command and write here if it solves the issue


white spaces should not be engaged to enter in the username and password field during login

[x] #74

@AnjaliVellookkaran please check and close

email field accepts white spaces along with it

Email field not done @zahidmuhammed @saranya13-tech

issue fixed!


[JavaScript] Getters returning nulls instead of default values for primitives

What language does this apply to?
JavaScript
Describe the problem you are trying to solve.
Currently, all generated getters for primitives in _pb.js files call to jspb.Message.getFieldWithDefault and there seem to be no way to tell generator to simply call jspb.Message.getField instead.
This is particularly problematic when using proto2 syntax with required/optional numeric fields. If an optional field is not set, it will default to "0".
Describe the solution you'd like
Ideally there would be an option passed to the js_out parameter of protoc where we could say whether or not to use defaults.
Describe alternatives you've considered
One could potentially leverage hasMyField() to determine if the field has been set or not, but it would make the mapping layer between proto and internal app model even more verbose, as this would need to be done on all optional fields, which we have quite a few.

Our plan is to add alternate accessors that allow you to treat absence as undefined values.


spring feature management - recurring time window filter

Description
add filters parameter in time window filter to support recuring time window.
filters parameter should be a list of string. Each string should be a crontab expression. The crontab format have five time fields separated by at least one blank:
{minute} {hour} {day-of-month} {month} {day-of-week}

Crontab Expression Example
Recurring Time Window

* 6-9,16-19 * * *
6:00-10:00 and 16:00-20:00 every day

* * * 7-8 Wed,Fri
Every Wednesday and Friday in July and August

* 18-21 25 12 *
18:00-22:00 on Dec 25th

* * 1-7 9 Mon
The first Monday in September

API change check
APIView has identified API level changes in this PR and created following API reviews.
spring-cloud-azure-feature-management


Option to alter directory paths

Hi!
I have a setup where my site has no write permissions to vendor/php-ai/php-ml/var. The SupportVectorMachine class tries to write to this folder and fails.
My suggestion (to keep BC as well) is to add a 'public function setVarPath($varPath)' method to the class to allow overriding the variable.
There might be other classes that need to write to the filesystem, so adding something like this to them as well would probably be great.

This make sense. I will take this into consideration in the near future :)

Same issue here, I temporarily added permissions for this path but it will be great to being able to change it.

I need to add some path validation but for now i merged #73 and you can use this new methods.

Yes, saw this on master branch, I used the latest release before. Thanks.


As a careless user who keyed in wrong information for a meeting, I can edit the meeting

so that I can correct the wrong information

Deleting as this is a duplicate of #78


Mobile os version not working

Description
Getting the os version for a mobile client request is not working
How to reproduce
calling browser.platform.version
What do you expect
The proper mobile os version
What happened instead
calling browser.platform.version is returning 0 for both ios and android clients:
https://github.com/fnando/browser/blob/master/lib/browser/platform/ios.rb#L8
The regex seems to be out of sync with what headers are sending through now.
Software:

Rails version: 4.2.6
Browser gem version: 2.2.0

Report
http://user-agent.herokuapp.com/?ua=Mozilla%2F5.0+(Macintosh%3B+Intel+Mac+OS+X+10_11_4)+AppleWebKit%2F537.36+(KHTML%2C+like+Gecko)+Chrome%2F55.0.2883.95+Safari%2F537.36&accept_language=en-US%2Cen%3Bq%3D0.8

That's because, with this user agent informed on the report url, we can't extract anything related to the platform.


Knight No Scanlation

Source name
Knight No Scanlation
Source link
https://knightnoscanlation.com/
Source language
Español
Other details
Acknowledgements

[x] I have checked that the extension does not already exist by searching the GitHub repository and verified it does not appear in the code base.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a meaningful title with the source name.
[X] I will fill out all of the requested information in this form.

I hope it added


Doesn't work with .env

For the cli feature I added I realized I shot myself in the foot when using the dotenv module for local execution: env vars are loaded after startup, but startup fails.
I'd like to add a switch to the CLI that will read a .env if one is present and consider those variables as well when determining whether a variable is absent.

I think this might be a bit out of scope for this little project - sorry! Besides, if you're already requiring dotenv in code, why not just require check-env as well?


Statistics number formatting

The statistics box is displaying zeros for my ROI for example_spec_ascii. I suspect it might be just because the display is not using scientific notation and my fluxes are a few x 10**-15. We probably want the stats box to display 3 significant figures when possible.

Fixed in c6b0d2cc6236436268296a16ff1c07a7f00679dd.


Create a Business Service with Node.js using Visual Studio Code

Tutorial URL: https://developers.sap.com/tutorials/cp-apm-nodejs-create-service.html
Hello and thanks a lot for the great tutorial!
This node-functionality for the application programming model was exactly what we are looking for to migrate our products to the SAP cloud platform.
I have one question though:
We rely heavily on Function Imports for our OData services. Is there a way to implement a custom handler for function imports in node.js yet? Like the srv.on("READ", "Books"... in the tutorial?
If you could point me in the right direction or confirm that the functionality will be implemented, it would help us a lot!
Kind regards,
Dominik Trefzer

Hi @dtrefzer,
thank you for asking the question.
I just looked it up at help.sap.com: https://help.sap.com/viewer/65de2977205c403bbc107264b8eccf4b/Cloud/en-US/a3c9699ea82a42d4bae0b1babf231015.html
Does this help you?

Hi @Apfohlmann,
thanks for your fast reply.
You pointed me in the right direction there: we will handle function imports with a call of srv.use((req, res, nect) =>...) for the time being. Maybe they will be added to srv.on() directly in the future.
But we can work with that and thanks again for your help.
Kind regards,
Dominik Trefzer

Hi @dtrefzer,
I am happy to help.
@thecodester you can close this issue.
Best regards,
André

@dtrefzer If you are happy with Andre's help, feel free to close the issue. Thanks for the feedback.


arch/stm32h7: Add SocketCAN FDCAN driver

Summary
This PR adds a SocketCAN FDCAN driver for STM32H7.  Features include standard and extended IDs, classic and FD frames, timeout / tx cancellation, and automatic configuration of nominal- and data-phase bit timing from CONFIG-defined bitrates.
A socketcan config has been added to the nucleo-h743zi2 board; the Kconfig options should be the same or similar to other SocketCAN drivers.
Impact
A few bug fixes are included for net/can regarding CONFIG's.
Note that this was developed independently prior to https://github.com/apache/incubator-nuttx/pull/5419, so the Kconfig settings and overall structure are likely to be similar, but I did not expend a significant amount of effort to match this driver to the (very similar) driver under arch/stm32.
Testing
Initial development and testing was performed using the Nucleo-H743ZI2 board + external transceiver + PEAK USB-FD.  Testing was performed using canutils - cansend, candump.  More recent testing has been performed by running this driver within PX4 on several STM32H7 boards: Cubepilot Orange Cube, and mRobotics Control Zero H7 OEM, both of which support at least 4Mbps CAN-FD with 2 CAN buses.  For the PX4 boards, both the canutils applications + UAVCAN v1 have been tested successfully with both classic CAN and CAN-FD.  See: https://github.com/PX4/PX4-Autopilot/tree/dev/socketcan-nuttx-10.3.0 for PX4 board support (To test with UAVCANv1, use pyUAVCAN + Yakut on your local PC).  This PX4 branch includes effectively the same branch of NuttX as this branch here, with two additional backports needed by PX4.
Future Work

Hardware-level CAN ID filtering (placeholders exist; not yet implemented)
If desired, we could add Kconfig options to disable extended ID support, like is done in some other drivers
Enable error interrupts; add additional error counters?

@JacobCrabill could you rebase your patch set?

@xiaoxiang781216 do you know why nxstyle would show 0 errors locally but the Github "Check" action shows errors?

@xiaoxiang781216 do you know why nxstyle would show 0 errors locally but the Github "Check" action shows errors?

How do you run nxstyle locally? or could you check whether the warning make sense?

@xiaoxiang781216 do you know why nxstyle would show 0 errors locally but the Github "Check" action shows errors?

How do you run nxstyle locally? or could you check whether the warning make sense?

I've been doing this to check the style of my work: gcc tools/nxstyle.c -o nxstyle && ./nxstyle <file>

I've been doing this to check the style of my work: gcc tools/nxstyle.c -o nxstyle && ./nxstyle <file>

./nxstyle -f <file> ?

I've been doing this to check the style of my work: gcc tools/nxstyle.c -o nxstyle && ./nxstyle <file>

./nxstyle -f <file> ?

There isn't a -f option for nxstyle.  At least, not the one under tools.
jacob@pop-os:~/Codes/nuttx$ ./nxstyle -v 1 arch/arm/src/stm32h7/stm32_fdcan_sock.c
/home/jacob/Codes/nuttx/arch/arm/src/stm32h7/stm32_fdcan_sock.c: PASSED nxstyle check
jacob@pop-os:~/Codes/nuttx$ ./nxstyle -v 1 arch/arm/src/stm32h7/stm32_fdcan_sock.h
/home/jacob/Codes/nuttx/arch/arm/src/stm32h7/stm32_fdcan_sock.h: PASSED nxstyle check

Could you try this:
./tools/checkpath.sh -g HEAD~6...HEAD

@JacobCrabill look like the last six patch should be squashed into the first patch. Could you run:
git rebase --interactive HEAD~9
and reorder and squash the patch in editor?

@JacobCrabill The 4th and 7th patch is better to merge into first one, since both correct the error in the first, I think.

@JacobCrabill The 4th and 7th patch is better to merge into first one, since both correct the error in the first, I think.

Ok, done.
If we have the style issues taken care of now, a review of the content of the driver would be appreciated.

@JacobCrabill the follow error need be fixed before merging:
warning: (CANUTILS_CANDUMP && CANUTILS_CANSEND) selects CANUTILS_LIBCANUTILS which has unmet direct dependencies (NET_CAN && ALLOW_GPL_COMPONENTS)
  Disabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
  Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
warning: (CANUTILS_CANDUMP && CANUTILS_CANSEND) selects CANUTILS_LIBCANUTILS which has unmet direct dependencies (NET_CAN && ALLOW_GPL_COMPONENTS)
warning: (CANUTILS_CANDUMP && CANUTILS_CANSEND) selects CANUTILS_LIBCANUTILS which has unmet direct dependencies (NET_CAN && ALLOW_GPL_COMPONENTS)
  Building NuttX...
Error: syslog/syslog_channel.c:142:3: error: excess elements in array initializer [-Werror]
  142 |   &g_ramlog_channel,
      |   ^
syslog/syslog_channel.c:142:3: note: (near initialization for 'g_syslog_channel')
cc1: all warnings being treated as errors
make[1]: *** [Makefile:91: syslog_channel.o] Error 1
make[1]: Target 'libdrivers.a' not remade because of errors.
make: *** [tools/LibTargets.mk:89: drivers/libdrivers.a] Error 2
slcan.c: In function 'slcan_main':
Error: slcan.c:359:40: error: 'union <anonymous>' has no member named 'ifru_can_data'; did you mean 'ifru_mii_data'?
  359 |                           ifr.ifr_ifru.ifru_can_data.arbi_bitrate =
      |                                        ^~~~~~~~~~~~~
      |                                        ifru_mii_data
Error: slcan.c:361:40: error: 'union <anonymous>' has no member named 'ifru_can_data'; did you mean 'ifru_mii_data'?
  361 |                           ifr.ifr_ifru.ifru_can_data.arbi_samplep = 80;
      |                                        ^~~~~~~~~~~~~
      |                                        ifru_mii_data

The CAN-utils library requires ALLOW_GPL_COMPONENTS=y. Should we allow this in upstream NuttX ? I'm not sure what is Apache policy in this matter.

Commit https://github.com/apache/incubator-nuttx/pull/6057/commits/b16ad669bc6a6a1a7863082c33da01f48dc866cb should be definitely divided into smaller patches.
There are many changes not related to the description of the commit

@JacobCrabill the follow error need be fixed before merging:

The slcan portion, at least, is coming from apps when I renamed irfu_can_data_s per @pkarashchenko 's request.  Would you prefer I revert the name, or create a PR for nuttx-apps?
For the CONFIG errors, which build target / what config is this error coming from?  Is this coming from inside nuttx-apps?  It's not immediately clear to me where the error is coming from / how to fix it.

Commit b16ad66 should be definitely divided into smaller patches. There are many changes not related to the description of the commit

I had it split out into smaller pieces, but @xiaoxiang781216 requested I consolidate them into one commit.  Should I split it back out?

The CAN-utils library requires ALLOW_GPL_COMPONENTS=y. Should we allow this in upstream NuttX ? I'm not sure what is Apache policy in this matter.

The ucans32k146 board already in this repo also contains CONFIG_CANUTILS_x=y.  Not sure what the policy is on board configs that refer to the use of GPL'd code in an independent repository.

I had it split out into smaller pieces, but @xiaoxiang781216 requested I consolidate them into one commit. Should I split it back out?

Sorry, I but I didn't see the previous version. But I think we shouldn't combine:

stm32h7 specific driver implementation
changes related to general SocketCAN interface
fixes for flexcan implementation related to point 2

At least 1 should be separated from 2 and 3.

The ucans32k146 board already in this repo also contains CONFIG_CANUTILS_x=y. Not sure what the policy is on board configs that refer to the use of GPL'd code in an independent repository.

Yes, that's true. I see there are more configurations with GPL enabled.
Maybe someone more familiar with licenses issues can help ? @jerpelea ?
Is it allowed to enable GPL components in upstream configurations?

Regarding GPL, I don't see any issues with referring to the use of external GPL'd code in order to build a specific board config.  If the GPL'd code was within this repository, I would agree with you.  As it stands, a few lines of text that make an indirect reference to code that might be GPL'd should be totally fine.

Regarding GPL, I don't see any issues with referring to the use of external GPL'd code in order to build a specific board config. If the GPL'd code was within this repository, I would agree with you. As it stands, a few lines of text that make an indirect reference to code that might be GPL'd should be totally fine.

Actually the canutils code is dual licensed see /* SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) */ thus technically BSD-3-Clause should apply as well, but apparently it's chosen not to recognize that.

@JacobCrabill your patch need fix the issue I reported four days ago:
To fix the ci error:

Error: syslog/syslog_channel.c:142:3: error: excess elements in array initializer [-Werror]
  142 |   &g_ramlog_channel,
You need:

Select one and only one channel(remove CONFIG_RAMLOG_SYSLOG or CONFIG_SYSLOG_DEFAULT)
Set CONFIG_SYSLOG_MAX_CHANNELS to 2 at least

Just a quick note - I have not yet tested moving the frame reception from interrupt context to work-queue context.  I would like to test that on hardware before finishing this PR.  I'll squash that commit into the main commit once it's been tested.  Also, I'm open to suggestions on the transmission-complete interrupt as well - right now, transmission completion is handled from within the interrupt context.  Should that be switched to HPWORK queue as well?

@JacobCrabill I mask this PR as draft to avoid merge it accidentally, please undo my change after you finish the test.

@xiaoxiang781216 do you want me to do a rebase on top of master, or just squash the last few commits but leave the base the same?

@xiaoxiang781216 do you want me to do a rebase on top of master, or just squash the last few commits but leave the base the same?

either is fine.


Empty Entry and Accent Marks on Vowels

WARNING Entry ID=26033, concept=OLDER SISTER (OF WOMAN), language=Guajajara is empty

This is the only error I received now. But it seems that the tone marks are inconsistent: you have many cases with "á", etc., which is not our preferred way to mark tone, as it is merging tone and vowel and it is often also confused with stress and accent. Also, dipthong segmentations are not clear to me: "ua" is in my opinion in most situations rather a "w a", same as "ia". So I suggest to look into vowels in tuled more systematically, as these are important for alignments.

I'm checking this concept oin Guajajara. Guajajara has no tones, so this is
just an indicator of which syllable is accented.  Perhaps we could start
using the ipa stress marker.
On Sat, Jan 22, 2022 at 9:36 PM Johann-Mattis List @.***>
wrote:

WARNING Entry ID=26033, concept=OLDER SISTER (OF WOMAN), language=Guajajara is empty
This is the only error I received now. But it seems that the tone marks
are inconsistent: you have many cases with "á", etc., which is not our
preferred way to mark tone, as it is merging tone and vowel and it is often
also confused with stress and accent. Also, dipthong segmentations are not
clear to me: "ua" is in my opinion in most situations rather a "w a", same
as "ia". So I suggest to look into vowels in tuled more systematically, as
these are important for alignments.
—
Reply to this email directly, view it on GitHub
https://github.com/tupian-language-resources/tuled/issues/48, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ALNZPK5EXZFPOJVMSTLETJTUXMIK7ANCNFSM5MSM67XA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

the concept
Entry ID=26033, concept=OLDER SISTER (OF WOMAN) in Guajajara
is fine. Length and etc. all fine!
regarding the vowels, I will talk to Carolina about this. I also do
not like it the way it is
On Sat, Jan 22, 2022 at 9:38 PM Fabrício @.***> wrote:

I'm checking this concept oin Guajajara. Guajajara has no tones, so this
is just an indicator of which syllable is accented.  Perhaps we could start
using the ipa stress marker.
On Sat, Jan 22, 2022 at 9:36 PM Johann-Mattis List <
@.***> wrote:

WARNING Entry ID=26033, concept=OLDER SISTER (OF WOMAN), language=Guajajara is empty
This is the only error I received now. But it seems that the tone marks
are inconsistent: you have many cases with "á", etc., which is not our
preferred way to mark tone, as it is merging tone and vowel and it is often
also confused with stress and accent. Also, dipthong segmentations are not
clear to me: "ua" is in my opinion in most situations rather a "w a", same
as "ia". So I suggest to look into vowels in tuled more systematically, as
these are important for alignments.
—
Reply to this email directly, view it on GitHub
https://github.com/tupian-language-resources/tuled/issues/48, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ALNZPK5EXZFPOJVMSTLETJTUXMIK7ANCNFSM5MSM67XA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

If you have stress, and want to annotated it, if you can only annotate
it for one language, it is not consistent. So I'd say it should be
placed into a separate column, where you indicate stress for each sound:
t o x t e r
1 1 1 0 0 0
You see?
Mixing stress in IPA is never really useful, as machines do not know the
syllable boundaries, etc.

then I will delete the accents and keep only tones. You can let me know how
to annotate the tones
On Sat, Jan 22, 2022 at 9:48 PM Johann-Mattis List @.***>
wrote:

If you have stress, and want to annotated it, if you can only annotate
it for one language, it is not consistent. So I'd say it should be
placed into a separate column, where you indicate stress for each sound:
t o x t e r
1 1 1 0 0 0
You see?
Mixing stress in IPA is never really useful, as machines do not know the
syllable boundaries, etc.
—
Reply to this email directly, view it on GitHub
https://github.com/tupian-language-resources/tuled/issues/48#issuecomment-1019355421,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALNZPK3IUVRTPIHGFSIGYHDUXMJYHANCNFSM5MSM67XA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

for Munduruku I have started to annotate glottalized vowels. Apparently
they did not cause a problem
On Sat, Jan 22, 2022 at 9:49 PM Fabrício @.***> wrote:

then I will delete the accents and keep only tones. You can let me know
how to annotate the tones
On Sat, Jan 22, 2022 at 9:48 PM Johann-Mattis List <
@.***> wrote:

If you have stress, and want to annotated it, if you can only annotate
it for one language, it is not consistent. So I'd say it should be
placed into a separate column, where you indicate stress for each sound:
t o x t e r
1 1 1 0 0 0
You see?
Mixing stress in IPA is never really useful, as machines do not know the
syllable boundaries, etc.
—
Reply to this email directly, view it on GitHub
https://github.com/tupian-language-resources/tuled/issues/48#issuecomment-1019355421,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALNZPK3IUVRTPIHGFSIGYHDUXMJYHANCNFSM5MSM67XA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

I recommend to use the slash-construction if you do not want to loose information: instead of t á k a n, you write t á/a k a n. This means: lingpy interprets only a, but knows that á is what is intended for the reader. Edictor renders this in superscript. I recommend to use this also for your tone marks. For accents, you could write 'a/a, so it is distinguished from vowels with tones.

can you change that automatically or should we do it manually?
On Sun, Jan 23, 2022 at 10:42 AM Johann-Mattis List <
@.***> wrote:

I recommend to use the slash-construction if you do not want to loose
information: instead of t á k a n, you write t á/a k a n. This means:
lingpy interprets only a, but knows that á is what is intended for the
reader. Edictor renders this in superscript. I recommend to use this also
for your tone marks. For accents, you could write 'a/a, so it is
distinguished from vowels with tones.
—
Reply to this email directly, view it on GitHub
https://github.com/tupian-language-resources/tuled/issues/48#issuecomment-1019447888,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALNZPKZN2IZVBUJMHF3VPSLUXPEOTANCNFSM5MSM67XA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

I prefer you doing it manually, also to learn the slash construction for
future uses (we use it for other things as well that may come in handy
when I make the partial cross-semantic cognate check).

Ok, I'll do that.
Johann-Mattis List @.***> schrieb am So. 23. Jan. 2022
um 10:47:

I prefer you doing it manually, also to learn the slash construction for
future uses (we use it for other things as well that may come in handy
when I make the partial cross-semantic cognate check).
—
Reply to this email directly, view it on GitHub
https://github.com/tupian-language-resources/tuled/issues/48#issuecomment-1019448857,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALNZPKYUD7AVHFA7TKXUWFLUXPFEZANCNFSM5MSM67XA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

--
Fabrício Gerardi

How about the annotation of tones?
On Sun, Jan 23, 2022 at 10:48 AM Fabrício @.***> wrote:

Ok, I'll do that.
Johann-Mattis List @.***> schrieb am So. 23. Jan.
2022 um 10:47:

I prefer you doing it manually, also to learn the slash construction for
future uses (we use it for other things as well that may come in handy
when I make the partial cross-semantic cognate check).
—
Reply to this email directly, view it on GitHub
https://github.com/tupian-language-resources/tuled/issues/48#issuecomment-1019448857,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALNZPKYUD7AVHFA7TKXUWFLUXPFEZANCNFSM5MSM67XA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

--
Fabrício Gerardi

Depending on your tones. If you have high, mid, and low, you could
write: a³/a a²/a etc.


link for wiki added in readme.md

The wiki has a very good content.
When someone sees the project for the first time, not to know that the wiki is being used. So I think valid to add a link in the readme.md.
I changed the "Contribute" by "Want to Contribute?" For more friendly tip :)

LGTM. Thank you @afonsopacifer

@surma :D


Unit tests

Merge with https://github.com/OrifInformatique/ci_packbase_v4/tree/unit_tests

update azure ad
adapt azure ad for unit test
add unit test

Pull request for branch "Release 1.6" will be reopened


onEnter called multiple times

EDIT: A much simpler way to reproduce
<IndexRoute component={Home} onEnter={() => console.log('Home page')}/>

Shows Home page 3 times. Twice on the client console, and once on the server side.
I'm keeping the below just for reference, otherwise the above is enough to replicate the problem.

I've seen some references to this issue elsewhere, but the fixes outlined (using react-router-redux, check for multiple dispatches) seem to be taken care of.
I've added this to my routes file:
<Route path="/verify-email/:token" onEnter={verifyEmailAndRedirect(store)} component={Email} />

And this is the onEnter function
import {verifyEmail} from 'redux/modules/user';
import {createFlashMessage} from 'redux/modules/flash';

export function verifyEmailAndRedirect({dispatch}) {
  return ({params: {token}}) => {
    dispatch(verifyEmail(token))
      .then(
        // Success
        ({message}) => {
          dispatch(createFlashMessage(dispatch, message, 'info', true));
        },
        // Failure
        message => {
          dispatch(createFlashMessage(dispatch, message, 'danger', true));
        }
      );
  };
}

The URLs associated with this route are never linked to in the app, so a fresh app load will always occur. Therefore, whenever I test this, I refresh the page with a URL that will trigger this route. What I've noticed however, is 3 flash messages are always created.
If I use react-router's async done callback, I get 2 rendering, and a warning in my console telling me that the server render and the client render are different.
Anyone have any idea where I might start troubleshooting this issue? I'd rather not hack around the problem with debounces.

this fixed it for me https://github.com/ReactTraining/react-router/issues/3016


Error when saving a scene using native file dialog

Tested versions
master[4a0160241fd0c1e874e297f6b08676cf0761e5e8]
System information
Arch Linux
Issue description
When "Use Native File Dialogs" is enabled, saving a scene produces these errors:
ERROR: Do not use progress dialog (task) while flushing the message queue or using call_deferred()!
   at: add_task (editor/progress_dialog.cpp:155)
ERROR: Condition "!tasks.has(p_task)" is true. Returning: canceled
   at: task_step (editor/progress_dialog.cpp:188)
ERROR: Condition "!tasks.has(p_task)" is true. Returning: canceled
   at: task_step (editor/progress_dialog.cpp:188)
ERROR: Condition "!tasks.has(p_task)" is true. Returning: canceled
   at: task_step (editor/progress_dialog.cpp:188)
ERROR: Condition "!tasks.has(p_task)" is true. Returning: canceled
   at: task_step (editor/progress_dialog.cpp:188)
ERROR: Condition "!tasks.has(p_task)" is true. Returning: canceled
   at: task_step (editor/progress_dialog.cpp:188)
ERROR: Condition "!tasks.has(p_task)" is true.
   at: end_task (editor/progress_dialog.cpp:215)

The scene is saved nevertheless.
Steps to reproduce

Turn on interface/editor/use_native_file_dialogs in editor settings.
Create a new scene.
Save the scene.

Minimal reproduction project (MRP)
N/A

I can't reproduce it on macOS, probably related to the fact native file dialog are non-blocking on Linux (API limitation).