Triggering of "Autopilot off" by RC override during mission start

Describe the bug
For triggering the "autopilot off" the current RC inputs are compared to the last time the vehicle was in a manual mode.
Thus, when the RC sticks are not in neutral when the switch into mission happens, the failsafe is triggered and the warning appears. The vehicle though proceeds in it's mission.
On the other hand, if the RC sticks are really moved during the transition, then the mission is correctly aborted and control returned to the pilot.
To Reproduce
In sitl:

plan a mission
take off in manual mode (e.g. position controlled)
give some stick inputs and at the same time switch into mission mode
let go of the sticks immediately
the warning "Autopilot off. Return control to pilot" appears.
the mission is still executed

Expected behavior
The mission shouldn't  be continued/started when the "Autopilot off. Return control to pilot"-warning appeared

@julianoes could you have a look at this?

Ok thanks for reporting, that sounds like a bug. Now the question is if:

The behaviour should be changed, so we actually go back into manual mode.
Or the warning should not be printed but we tolerate that the sticks need to go into neutral position.

I would probably vote for 2. because it sounds like a real use case when going from fixedwing manual congtrol to an auto mode.

@julianoes I agree, also would prefer 2. Maybe we should only consider stick inputs that increase the absolute value of the stick i.e. abs(stick-value)

@sfuhrer you have fixed this, right?

No I haven't. @MaEtUgR was looking briefly into it if I remember correctly.

I didn't yet. Could it be that the message is just delayed a bit? Otherwise it's a commander glitch depending on timing. Maybe because of low prio, high prio thread.


fixes typos and corrects links in the minikube guide

the pr fixes issues I noticed while referring to the minikube document.

This change is

Thanks! Sorry for the delay.


Unused Dialects Requiring Packages in Webpack Build

I am using the MySQL dialect with this library but whenever I bundle my app using webpack, the calls to import('pg') and import('better-sqlite3') prevent my project from building.
I'm not sure why bundling the project triggers a call to these two imports. I only use the MySQL dialect class where the connection is established. If I comment out the import statements, my code builds and runs fine. However, I'm creating a build pipeline in our repository which will not have the commented-out code and I'm trying to figure out if:

I need to fork this repo and maintain a version of it, or
if there is a quick fix you can provide, or
if you might know something I could do differently with webpack to resolve this issue

Let me know if I need to provide examples of my setup for you to review.
Thanks a ton!
P.S. this library is absolutely freaking gold. I LOVE it!

I'm actually releasing a new version today that has absolutely no dependencies to anything whatsoever. All dependencies are passed from the outside, so this won't be a problem anymore.
For example, you'll create a Kysely instance like this:
import { createPool } from 'mysql2'

const kyselt = new Kysely<DB>({
  dialect: MysqlDialect({
    pool: createPool(mysqlConfig)
  })
})

It's now released.


Fix log

What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix log that print incorrect message.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

/lgtm
/approve


Rebased #380

Rebased Josh's documentation commits from #380 onto master

Pull Request Test Coverage Report for Build 636

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.166%

Totals

Change from base Build 634:
0.0%

Covered Lines:
2500

Relevant Lines:
2627

💛  - Coveralls


Songcrawler params aren't passed to Request

When instantiating the request class, all parameters initialised in the super().__init__() are the default parameters, not what you pass to it. Need to find a way to deal with this...
Might have found a way to print out all the genius_ids, but it's hard to use without solving this first
—
Created via Raycast

fixed ✅


[release/v1.5] Bring the release/v1.5 branch in-sync with the master branch

What this PR does / why we need it:
Bring the release/v1.5 branch in-sync with the master branch.
What type of PR is this?
/kind cleanup
Does this PR introduce a user-facing change? Then add your Release Note here:
- Merge the CCM/CSI migration steps for updating the control plane static pod manifests and Kubelet configuration into a single step. This fixes an issue with the CCM/CSI migration failing on clusters running Kubernetes 1.24+ when the API endpoint is one of the control plane nodes.
- Mount `/usr/share/ca-certificates` to the Azure CCM container to fix CrashLoopBackoff on clusters running Flatcar
- Update Flatcar to 3227.2.1 in the example Terraform configs for Azure
- Enforce the NFT iptables backend for Canal and Calico VXLAN on RHEL
- Use the same image reference and plan for the initial Azure MachineDeployment as for the control plane

Documentation:
NONE

/lgtm
/approve


[Bug] TQC Hyperparameter optimization: Results do not match the reference. This is likely a bug/unexpected loss of precision.

🐛 Bug
Hi,
When I try to run TQC hyperparameter optimization with multiple jobs (n-jobs>1) with a GPU (this also happens with multiple CPU cores and n-jobs=1), it gives me this error:
2024-04-07 14:35:59.992779: E external/xla/xla/service/gpu/buffer_comparator.cc:143] Difference at 0: -inf, expected -0.000287323
2024-04-07 14:35:59.992804: E external/xla/xla/service/gpu/buffer_comparator.cc:143] Difference at 1: -inf, expected -0.000267224
2024-04-07 14:35:59.992808: E external/xla/xla/service/gpu/buffer_comparator.cc:143] Difference at 2: -inf, expected -0.000226477
2024-04-07 14:35:59.992811: E external/xla/xla/service/gpu/buffer_comparator.cc:143] Difference at 3: -inf, expected -0.000281823
2024-04-07 14:35:59.992813: E external/xla/xla/service/gpu/buffer_comparator.cc:143] Difference at 4: -inf, expected -0.000262532
2024-04-07 14:35:59.992815: E external/xla/xla/service/gpu/buffer_comparator.cc:143] Difference at 5: -inf, expected -0.000252724
2024-04-07 14:35:59.992818: E external/xla/xla/service/gpu/buffer_comparator.cc:143] Difference at 6: -inf, expected -0.000250007
2024-04-07 14:35:59.992820: E external/xla/xla/service/gpu/buffer_comparator.cc:143] Difference at 7: -inf, expected -0.000265674
2024-04-07 14:35:59.992823: E external/xla/xla/service/gpu/buffer_comparator.cc:143] Difference at 8: -inf, expected -0.00021464
2024-04-07 14:35:59.992825: E external/xla/xla/service/gpu/buffer_comparator.cc:143] Difference at 9: -inf, expected -0.000204733
E0407 14:35:59.992828  798907 triton_autotuner.cc:766] Results do not match the reference. This is likely a bug/unexpected loss of precision.

To Reproduce
python rl-baselines3-zoo/train_sbx.py --algo tqc --env Pendulum-v1 -n 5000 --n-trials 50 --num-threads 1 --n-jobs 4 --log-interval 4900 --eval-episodes 16 --n-eval-envs 8 --seed 8 --vec-env "dummy" -optimize --sampler tpe --pruner median --n-startup-trials 10

[W 2024-04-07 14:36:00,208] Trial 16 failed with parameters: {'gamma': 0.995, 'learning_rate': 0.23149128592335125, 'batch_size': 1024, 'buffer_size': 10000, 'learning_starts': 1000, 'train_freq': 16, 'tau': 0.08, 'log_std_init': -0.3684256821552643, 'net_arch': 'medium', 'n_quantiles': 32, 'top_quantiles_to_drop_per_net': 30} because of the following error: XlaRuntimeError('INTERNAL: All algorithms tried for %dot.384 = f32[1024,512]{1,0} dot(f32[1024,32]{1,0} %broadcast.2180, f32[512,32]{1,0} %parameter_0.14), lhs_contracting_dims={1}, rhs_contracting_dims={1}, metadata={op_name="jit(_train)/jit(main)/while/body/cond/branch_1_fun/jit(update_actor)/transpose(jvp(Critic))/Dense_2/dot_general[dimension_numbers=(((1,), (1,)), ((), ())) precision=None preferred_element_type=None]" source_file="/scratch/network/.../rl-baselines3-zoo/rl_zoo3/exp_manager.py" source_line=793} failed. Falling back to default algorithm.  Per-algorithm errors:\n  Results do not match the reference. This is likely a bug/unexpected loss of precision.

Traceback (most recent call last):
  File "/home/.conda/envs/.../lib/python3.10/site-packages/optuna/study/_optimize.py", line 196, in _run_trial
    value_or_values = func(trial)
  File "/scratch/network/.../rl-baselines3-zoo/rl_zoo3/exp_manager.py", line 793, in objective
    model.learn(self.n_timesteps, callback=callbacks, **learn_kwargs)  # type: ignore[arg-type]
  File "/home/.conda/envs/.../lib/python3.10/site-packages/sbx/tqc/tqc.py", line 183, in learn
    return super().learn(
  File "/home/.conda/envs/.../lib/python3.10/site-packages/stable_baselines3/common/off_policy_algorithm.py", line 347, in learn
    self.train(batch_size=self.batch_size, gradient_steps=gradient_steps)
  File "/home/.conda/envs/.../lib/python3.10/site-packages/sbx/tqc/tqc.py", line 220, in train
    ) = self._train(
jaxlib.xla_extension.XlaRuntimeError: INTERNAL: All algorithms tried for %dot.384 = f32[1024,512]{1,0} dot(f32[1024,32]{1,0} %broadcast.2180, f32[512,32]{1,0} %parameter_0.14), lhs_contracting_dims={1}, rhs_contracting_dims={1}, metadata={op_name="jit(_train)/jit(main)/while/body/cond/branch_1_fun/jit(update_actor)/transpose(jvp(Critic))/Dense_2/dot_general[dimension_numbers=(((1,), (1,)), ((), ())) precision=None preferred_element_type=None]" source_file="/scratch/network/.../rl-baselines3-zoo/rl_zoo3/exp_manager.py" source_line=793} failed. Falling back to default algorithm.

Traceback (most recent call last):
File "/scratch/network/.../.../rl-baselines3-zoo/train_sbx.py", line 19, in <module>
train()
File "/scratch/network/.../.../rl-baselines3-zoo/rl_zoo3/train.py", line 275, in train
exp_manager.hyperparameters_optimization()
File "/scratch/network/.../.../rl-baselines3-zoo/rl_zoo3/exp_manager.py", line 874, in hyperparameters_optimization
study.optimize(self.objective, n_jobs=self.n_jobs, n_trials=self.n_trials)
File "/home/.../.conda/envs/.../lib/python3.10/site-packages/optuna/study/study.py", line 451, in optimize
_optimize(
File "/home/.../.conda/envs/.../lib/python3.10/site-packages/optuna/study/_optimize.py", line 99, in _optimize
f.result()
File "/home/.../.conda/envs/.../lib/python3.10/concurrent/futures/_base.py", line 451, in result
return self.__get_result()
File "/home/.../.conda/envs/.../lib/python3.10/concurrent/futures/_base.py", line 403, in __get_result
raise self._exception
File "/home/.../.conda/envs/.../lib/python3.10/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
File "/home/.../.conda/envs/.../lib/python3.10/site-packages/optuna/study/_optimize.py", line 159, in _optimize_sequential
frozen_trial = _run_trial(study, func, catch)
File "/home/.../.conda/envs/.../lib/python3.10/site-packages/optuna/study/_optimize.py", line 247, in _run_trial
raise func_err
File "/home/.../.conda/envs/.../lib/python3.10/site-packages/optuna/study/_optimize.py", line 196, in _run_trial
value_or_values = func(trial)
File "/scratch/network/.../.../rl-baselines3-zoo/rl_zoo3/exp_manager.py", line 793, in objective
model.learn(self.n_timesteps, callback=callbacks, **learn_kwargs) # type: ignore[arg-type]
File "/home/.../.conda/envs/.../lib/python3.10/site-packages/sbx/tqc/tqc.py", line 183, in learn
return super().learn(
File "/home/.../.conda/envs/.../lib/python3.10/site-packages/stable_baselines3/common/off_policy_algorithm.py", line 347, in learn
self.train(batch_size=self.batch_size, gradient_steps=gradient_steps)
File "/home/.../.conda/envs/.../lib/python3.10/site-packages/sbx/tqc/tqc.py", line 220, in train
) = self._train(
jaxlib.xla_extension.XlaRuntimeError: INTERNAL: All algorithms tried for %dot.384 = f32[1024,512]{1,0} dot(f32[1024,32]{1,0} %broadcast.2180, f32[512,32]{1,0} %parameter_0.14), lhs_contracting_dims={1}, rhs_contracting_dims={1}, metadata={op_name="jit(_train)/jit(main)/while/body/cond/branch_1_fun/jit(update_actor)/transpose(jvp(Critic))/Dense_2/dot_general[dimension_numbers=(((1,), (1,)), ((), ())) precision=None preferred_element_type=None]" source_file="/scratch/network/.../.../rl-baselines3-zoo/rl_zoo3/exp_manager.py" source_line=793} failed. Falling back to default algorithm.

### System Info
Describe the characteristic of your environment:

Library installed through pip

GPU models and configuration
+---------------------------------------------------------------------------------------+
| NVIDIA-SMI 545.23.08              Driver Version: 545.23.08    CUDA Version: 12.3     |
|-----------------------------------------+----------------------+----------------------+
| GPU  Name                 Persistence-M | Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |         Memory-Usage | GPU-Util  Compute M. |
|                                         |                      |               MIG M. |
|=========================================+======================+======================|
|   0  NVIDIA A100 80GB PCIe          On  | 00000000:0D:00.0 Off |                    0 |
| N/A   40C    P0              67W / 300W |   3508MiB / 81920MiB |      0%      Default |
|                                         |                      |             Disabled |
+-----------------------------------------+----------------------+----------------------+
|   1  NVIDIA A100 80GB PCIe          On  | 00000000:B5:00.0 Off |                    0 |
| N/A   38C    P0              49W / 300W |      5MiB / 81920MiB |      0%      Default |
|                                         |                      |             Disabled |
+-----------------------------------------+----------------------+----------------------+

Python 3.10.14

pytorch                   2.2.2           py3.10_cuda12.1_cudnn8.9.2_0
pytorch-cuda              12.1                 ha16c6d3_5    pytorch
pytorch-mutex             1.0                        cuda    pytorch
torchtriton               2.2.0                     py310    pytorch

Gym version
gymnasium                 0.29.1

Versions of any other relevant libraries
jax                       0.4.25             pyhd8ed1ab_0    conda-forge
jax-jumpy                 1.0.0              pyhd8ed1ab_0    conda-forge
jaxlib                    0.4.23          cuda118py310h8c47008_200    conda-forge

Additional context
I've noticed there's no bug when n-jobs=1, only when running multiple jobs. Maybe something with the way Optuna runs multiple jobs?
Checklist

[x] I have checked that there is no similar issue in the repo (required)
[x] I have read the documentation (required)
[x] I have provided a minimal working example to reproduce the bug (required)

I did this again with an new version of jax (jaxlib  0.4.23 cuda120py310h3cc97ca_20) and it gives a new error now:
'''
[I 2024-04-07 15:55:02,691] A new study created in memory with name: no-name-0da03417-c265-43a2-a55b-10d9750abcca
2024-04-07 15:55:23.576297: W external/xla/xla/service/gpu/runtime/support.cc:58] Intercepted XLA runtime error:
INTERNAL: Failed to launch CUDA kernel: triton_gemm_dot_74; block dims: 256x1x1; grid dims: 32x1x1; shared memory size: 24576: CUDA_ERROR_STREAM_CAPTURE_INVALIDATED: operation failed due to a previous error during capture
2024-04-07 15:55:23.576337: W external/xla/xla/service/gpu/runtime/support.cc:58] Intercepted XLA runtime error:
INTERNAL: CaptureGpuGraph failed (Failed to launch CUDA kernel: triton_gemm_dot_74; block dims: 256x1x1; grid dims: 32x1x1; shared memory size: 24576: CUDA_ERROR_STREAM_CAPTURE_INVALIDATED: operation failed due to a previous error during capture; current tracing scope: triton_gemm_dot.86): INTERNAL: Failed to end stream capture: CUDA_ERROR_STREAM_CAPTURE_INVALIDATED: operation failed due to a previous error during capture
2024-04-07 15:55:23.576394: E external/xla/xla/pjrt/pjrt_stream_executor_client.cc:2732] Execution of replica 0 failed: INTERNAL: Failed to execute XLA Runtime executable: run time error: custom call 'xla.gpu.graph.launch' failed: CaptureGpuGraph failed (Failed to launch CUDA kernel: triton_gemm_dot_74; block dims: 256x1x1; grid dims: 32x1x1; shared memory size: 24576: CUDA_ERROR_STREAM_CAPTURE_INVALIDATED: operation failed due to a previous error during capture; current tracing scope: triton_gemm_dot.86): INTERNAL: Failed to end stream capture: CUDA_ERROR_STREAM_CAPTURE_INVALIDATED: operation failed due to a previous error during capture; current profiling annotation: XlaModule:#prefix=jit(_train)/jit(main)/while/body,hlo_module=jit__train,program_id=116#.
INTERNAL: Failed to execute XLA Runtime executable: run time error: custom call 'xla.gpu.graph.launch' failed: CaptureGpuGraph failed (Failed to launch CUDA kernel: triton_gemm_dot_74; block dims: 256x1x1; grid dims: 32x1x1; shared memory size: 24576: CUDA_ERROR_STREAM_CAPTURE_INVALIDATED: operation failed due to a previous error during capture; current tracing scope: triton_gemm_dot.86): INTERNAL: Failed to end stream capture: CUDA_ERROR_STREAM_CAPTURE_INVALIDATED: operation failed due to a previous error during capture; current profiling annotation: XlaModule:#prefix=jit(_train)/jit(main)/while/body,hlo_module=jit__train,program_id=116#.
Sampled hyperparams:
{'batch_size': 1024,
'buffer_size': 100000,
'ent_coef': 'auto',
'gamma': 0.9999,
'gradient_steps': 1,
'learning_rate': 0.004315216575412321,
'learning_starts': 0,
'policy_kwargs': {'log_std_init': -1.4239746627852474,
'n_quantiles': 31,
'net_arch': [64, 64],
'top_quantiles_to_drop_per_net': 25,
'use_sde': False},
'target_entropy': 'auto',
'tau': 0.02,
'top_quantiles_to_drop_per_net': 25,
'train_freq': 1}
2024-04-07 15:55:23.577027: E external/xla/xla/stream_executor/cuda/cuda_driver.cc:1883] could not synchronize on CUDA context: CUDA_ERROR_STREAM_CAPTURE_UNSUPPORTED: operation not permitted when stream is capturing :: *** Begin stack trace ***
_PyObject_MakeTpCall
_PyEval_EvalFrameDefault
_PyFunction_Vectorcall
_PyEval_EvalFrameDefault
_PyFunction_Vectorcall
_PyEval_EvalFrameDefault
_PyFunction_Vectorcall
_PyEval_EvalFrameDefault
_PyFunction_Vectorcall
_PyEval_EvalFrameDefault
_PyFunction_Vectorcall

_PyObject_MakeTpCall
_PyObject_MakeTpCall
_PyEval_EvalFrameDefault
_PyFunction_Vectorcall
PyObject_Call
_PyEval_EvalFrameDefault
_PyFunction_Vectorcall
_PyEval_EvalFrameDefault
_PyFunction_Vectorcall
PyObject_Call
_PyEval_EvalFrameDefault
_PyFunction_Vectorcall

_PyEval_EvalFrameDefault
_PyFunction_Vectorcall
PyObject_Call
_PyEval_EvalFrameDefault
_PyFunction_Vectorcall
_PyEval_EvalFrameDefault
_PyFunction_Vectorcall
_PyEval_EvalFrameDefault

PyObject_Call
_PyEval_EvalFrameDefault
_PyFunction_Vectorcall
_PyEval_EvalFrameDefault
_PyFunction_Vectorcall
_PyEval_EvalFrameDefault
_PyFunction_Vectorcall

_PyEval_EvalFrameDefault

_PyEval_EvalFrameDefault

_PyEval_EvalFrameDefault

PyObject_Call
_PyEval_EvalFrameDefault

_PyEval_EvalFrameDefault
_PyFunction_Vectorcall
_PyEval_EvalFrameDefault
_PyFunction_Vectorcall
_PyEval_EvalFrameDefault
_PyFunction_Vectorcall
_PyEval_EvalFrameDefault
_PyFunction_Vectorcall
_PyEval_EvalFrameDefault
_PyFunction_Vectorcall
_PyEval_EvalFrameDefault
_PyFunction_Vectorcall
_PyEval_EvalFrameDefault
clone

*** End stack trace ***
[I 2024-04-07 15:55:23,577] Trial 1 pruned.
[W 2024-04-07 15:55:23,606] Trial 3 failed with parameters: {'gamma': 1, 'learning_rate': 0.03739146141228411, 'batch_size': 256, 'buffer_size': 100000, 'learning_starts': 1000, 'train_freq': 1, 'tau': 0.02, 'log_std_init': -1.1735175685607313, 'net_arch': 'small', 'n_quantiles': 26, 'top_quantiles_to_drop_per_net': 24} because of the following error: XlaRuntimeError('INTERNAL: Failed to synchronize GPU for autotuning.').
jax.errors.SimplifiedTraceback: For simplicity, JAX has removed its internal frames from the traceback of the following exception. Set JAX_TRACEBACK_FILTERING=off to include these.
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/home/.../.conda/envs/...1/lib/python3.10/site-packages/optuna/study/_optimize.py", line 196, in _run_trial
value_or_values = func(trial)
File "/scratch/network/.../.../rl-baselines3-zoo/rl_zoo3/exp_manager.py", line 793, in objective
model.learn(self.n_timesteps, callback=callbacks, **learn_kwargs) # type: ignore[arg-type]
File "/home/.../.conda/envs/...1/lib/python3.10/site-packages/sbx/tqc/tqc.py", line 183, in learn
return super().learn(
File "/home/.../.conda/envs/...1/lib/python3.10/site-packages/stable_baselines3/common/off_policy_algorithm.py", line 347, in learn
self.train(batch_size=self.batch_size, gradient_steps=gradient_steps)
File "/home/.../.conda/envs/...1/lib/python3.10/site-packages/sbx/tqc/tqc.py", line 220, in train
) = self._train(
jaxlib.xla_extension.XlaRuntimeError: INTERNAL: Failed to synchronize GPU for autotuning.
[W 2024-04-07 15:55:23,607] Trial 3 failed with value None.
[I 2024-04-07 15:55:44,276] Trial 2 finished with value: -149.14224087500003 and parameters: {'gamma': 0.995, 'learning_rate': 0.005830150992686316, 'batch_size': 2048, 'buffer_size': 10000, 'learning_starts': 0, 'train_freq': 8, 'tau': 0.01, 'log_std_init': -3.101106181907312, 'net_arch': 'medium', 'n_quantiles': 13, 'top_quantiles_to_drop_per_net': 1}. Best is trial 2 with value: -149.14224087500003.
[I 2024-04-07 15:55:44,442] Trial 0 finished with value: -1286.9111508125 and parameters: {'gamma': 0.995, 'learning_rate': 0.03380452664776398, 'batch_size': 128, 'buffer_size': 1000000, 'learning_starts': 1000, 'train_freq': 4, 'tau': 0.02, 'log_std_init': -3.2686941182290763, 'net_arch': 'big', 'n_quantiles': 45, 'top_quantiles_to_drop_per_net': 13}. Best is trial 2 with value: -149.14224087500003.
[I 2024-04-07 15:55:44,610] Trial 4 finished with value: -408.14151849999996 and parameters: {'gamma': 0.99, 'learning_rate': 0.022024554072114278, 'batch_size': 512, 'buffer_size': 100000, 'learning_starts': 1000, 'train_freq': 8, 'tau': 0.02, 'log_std_init': 0.9307981026739451, 'net_arch': 'big', 'n_quantiles': 35, 'top_quantiles_to_drop_per_net': 29}. Best is trial 2 with value: -149.14224087500003.
jax.errors.SimplifiedTraceback: For simplicity, JAX has removed its internal frames from the traceback of the following exception. Set JAX_TRACEBACK_FILTERING=off to include these.
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/scratch/network/.../.../rl-baselines3-zoo/train_sbx.py", line 19, in
train()
File "/scratch/network/.../.../rl-baselines3-zoo/rl_zoo3/train.py", line 275, in train
exp_manager.hyperparameters_optimization()
File "/scratch/network/.../.../rl-baselines3-zoo/rl_zoo3/exp_manager.py", line 874, in hyperparameters_optimization
study.optimize(self.objective, n_jobs=self.n_jobs, n_trials=self.n_trials)
File "/home/.../.conda/envs/seniorthesis1/lib/python3.10/site-packages/optuna/study/study.py", line 451, in optimize
_optimize(
File "/home/.../.conda/envs/seniorthesis1/lib/python3.10/site-packages/optuna/study/_optimize.py", line 99, in _optimize
f.result()
File "/home/.../.conda/envs/seniorthesis1/lib/python3.10/concurrent/futures/_base.py", line 451, in result
return self.__get_result()
File "/home/.../.conda/envs/seniorthesis1/lib/python3.10/concurrent/futures/_base.py", line 403, in __get_result
raise self._exception
File "/home/.../.conda/envs/seniorthesis1/lib/python3.10/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
File "/home/.../.conda/envs/seniorthesis1/lib/python3.10/site-packages/optuna/study/_optimize.py", line 159, in _optimize_sequential
frozen_trial = _run_trial(study, func, catch)
File "/home/.../.conda/envs/seniorthesis1/lib/python3.10/site-packages/optuna/study/_optimize.py", line 247, in _run_trial
raise func_err
File "/home/.../.conda/envs/seniorthesis1/lib/python3.10/site-packages/optuna/study/_optimize.py", line 196, in _run_trial
value_or_values = func(trial)
File "/scratch/network/.../.../rl-baselines3-zoo/rl_zoo3/exp_manager.py", line 793, in objective
model.learn(self.n_timesteps, callback=callbacks, **learn_kwargs) # type: ignore[arg-type]
File "/home/.../.conda/envs/seniorthesis1/lib/python3.10/site-packages/sbx/tqc/tqc.py", line 183, in learn
return super().learn(
File "/home/.../.conda/envs/seniorthesis1/lib/python3.10/site-packages/stable_baselines3/common/off_policy_algorithm.py", line 347, in learn
self.train(batch_size=self.batch_size, gradient_steps=gradient_steps)
File "/home/.../.conda/envs/seniorthesis1/lib/python3.10/site-packages/sbx/tqc/tqc.py", line 220, in train
) = self._train(
jaxlib.xla_extension.XlaRuntimeError: INTERNAL: Failed to synchronize GPU for autotuning.
'''

This might be related to Jax not handling multi-threading/multi-processing well.
You should probably have a look at distributed tuning using a shared database (I would recommend the log format): https://rl-baselines3-zoo.readthedocs.io/en/master/guide/tuning.html


Add isSelected and isHighlighted to render prop

Adds isSelected and isHighlighted to the render prop options. This adds some flexibility to the result item renderer (children render prop).
<Omnibar>
    {({ item, isSelected, isHighlighted, ...rest }) => {
        const style = { backgroundColor: '#fff' };

        if (isSelected) { style.backgroundColor = '#ccc'; }
        if (isHighlighted) { style.backgroundColor = '#999'; }

        return (
            <div style={style} {...rest}>
                {item.title}
            </div>
        );
    }
</Omnibar>

Coverage decreased (-1.8%) to 83.036% when pulling 353c81828f527fba1578e5605b709f5446cfbcfc on more-children-args into 7880f791cf543db68168f663fb883e3bb5d8f1d3 on master.

Coverage decreased (-3.6%) to 81.25% when pulling cd4e4463617d6503deb8095f9a17c80e3f0543f9 on more-children-args into 7880f791cf543db68168f663fb883e3bb5d8f1d3 on master.

Coverage decreased (-1.8%) to 83.036% when pulling d02a7c8a12bcfc9814668f85b8221ac76596ea2b on more-children-args into 7880f791cf543db68168f663fb883e3bb5d8f1d3 on master.

Coverage decreased (-1.8%) to 83.036% when pulling d02a7c8a12bcfc9814668f85b8221ac76596ea2b on more-children-args into 7880f791cf543db68168f663fb883e3bb5d8f1d3 on master.

Coverage decreased (-1.8%) to 83.036% when pulling 4e2e8b98dcab941c52aff5db82a7396a6c126721 on more-children-args into 7880f791cf543db68168f663fb883e3bb5d8f1d3 on master.

Coverage decreased (-1.8%) to 83.036% when pulling 4e2e8b98dcab941c52aff5db82a7396a6c126721 on more-children-args into 7880f791cf543db68168f663fb883e3bb5d8f1d3 on master.

Coverage decreased (-1.8%) to 83.036% when pulling 4e2e8b98dcab941c52aff5db82a7396a6c126721 on more-children-args into 7880f791cf543db68168f663fb883e3bb5d8f1d3 on master.


Platform Tip Share of Payment Processor Fees

Problem
For transactions with Platform Tips, we introduced the notion of share of Payment Processor Fees.
Unfortunately:

for third party Hosts, the Payment Processor fee is not gonna match what is reported on Stripe
for most Hosts we don't have the opportunity to invoice it back, because there is no settlement invoice

Solution
For now, it seems it's more future proof to remove this complexity and move to a simpler model that is easier to maintain.

I have noticed the refunding processor fees on tips transactions and I agree that's confusing and most hosts won't really understand what's going on. What would a simpler model be like? OC just covers the processing fees?


feat: added support for type negation with z.not() and .not() method …

Added support for type negation using z.not() and the .not() method in schema validation. This enhancement allows schemas to explicitly reject specific types, offering greater flexibility in data validation.
This implementation was done for ticket #2862
Changes:
Introduced the z.not() method to create schemas that reject a specified type.
Enabled the .not() method to be used directly on existing schemas for easier exclusion of types.
Added comprehensive test cases to validate the new z.not() functionality.
Updated the documentation to include examples and usage guidelines for z.not().

@matthewfallshaw @mitchwd @aaronjensen @cbenz Can I know review process of PR?

@colinhacks Could you please help me with review of my PR and merging it(if everything is fine)?


runtime-proxy: support cri v1 api

Ⅰ. Describe what this PR does

add cri v1 api to koord-runtime-proxy
Ⅱ. Does this pull request fix one issue?

fix #1051
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews

runtime-proxy registry cri server according to the cri verion supported by backendruntime.
RuntimeResourceExecutor move up to cri v1 api
v1alpha2 cri server uses RuntimeResourceExecutor by converting v1alpha2 object to v1 object

V. Checklist

[x] I have written necessary docs and comments
[ ] I have added necessary unit tests and integration tests
[x] All checks passed in make test

/hold

How to deal with community API changes, how does our version correspond to the community version, any suggestions? @FillZpp

/hold cancel

Referring to kubelet's approach(1.23), we need to design a compatibility solution, first detect whether v1 is supported, and fall back to v1alpha2 if it is not supported

IMO, runtime-proxy just forwards the cri request and response. The compatibility of the cri depends on kubernetes and backend runtime (containerd). This patch creates corresponding cri server according to the version supported by the backend runtime. For example:

backend runtime(eg. containerd v1.5.5): v1alpha2 , runtime-proxy: v1alpha2 .
backend runtime(eg. containerd v1.5.11): v1alpha2 and v1, runtime-proxy: v1alpha2 and v1.

Do you mean that the logic of runtime-proxy should be like this?

backend runtime(eg. containerd v1.5.11): v1alpha2 and v1, runtime-proxy: v1 only.

please tell me if i missed something.

Referring to kubelet's approach(1.23), we need to design a compatibility solution, first detect whether v1 is supported, and fall back to v1alpha2 if it is not supported

Sorry, I have a little trouble understanding. I think cri server should be consistent with containerd/dockerd:

backend runtime: v1alpha2 , runtime-proxy: v1alpha2 .
backend runtime: v1alpha2 and v1, runtime-proxy: v1alpha2 and v1.

I will continue to work on this pr. @maaoBit

/close


[Bug]: Metal Hardware reservations are hanging without timing out during delete

Terraform Version
1.7
Equinix Provider Version
1.26
Effected Terraform Resources
equinix_metal_device
Terraform Config Files
No response
Debug Output
No response
Panic Output
No response
Expected Behavior
A deprovision should succeed or timeout
Actual Behavior
A failed deprovision hangs indefinitely
Steps to Reproduce

create an instance from a hardware reservation
attempt to delete the instance
experience a timeout

I didn't expect a search for context.TODO to be as obviously helpful as it seems to be (with only 2 matches):
https://github.com/equinix/terraform-provider-equinix/blob/11dbb2b4741991b6db133c52ed0250d3623c6d52/equinix/helpers_device.go#L115
context.Background matched 1 non-testing result which could also be related:
https://github.com/equinix/terraform-provider-equinix/blob/11dbb2b4741991b6db133c52ed0250d3623c6d52/equinix/data_source_metal_devices.go#L54-L91
context.Background and context.TODO should be replaced with calls that pass the Terraform context into the EM API requests.
The user-defined resource timeouts should be tested and honored, for ondemand instance deprovision and reservation instance deprovisions.

hwReservationStateRefreshFunc could take ctx as a parameter since waitUntilReservationProvisionable has a context that it could send along. This seems familiar and we may have intentionally removed that context in the past.
https://developer.hashicorp.com/terraform/plugin/sdkv2/resources/retries-and-customizable-timeouts#statechangeconf has some notes on how to treat CRUD operations within a StateChangeConf refresh.

Closed by #581


Microsoft Teams meeting add-on for Google Workspace. for free accounts

Is that procedure also applieable for free microsoft accounts? I am not able to find that app also not able to activate it as mentioned i a tutorial over the powershell because ps isn't available on free accounts!
But Teams works fine with the free account.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 00c3be94-d640-a20c-ac06-2653f443b74e
Version Independent ID: 4760af98-c4e9-ab6a-6745-1381ffc068cc
Content: Set up Microsoft Teams meeting add-on for Google Workspace - Microsoft Teams
Content Source: Teams/google-workspace-addon-teams.md
Service: msteams
GitHub Login: @cichur
Microsoft Alias: v-cichur

Hello @hsynkrtl ,
Thank you for your question. This plug in works only with org or school account. Not free accounts. - Cindy


Update from original

Update from original

Please ignore this pull request. I was attempting to bring my local repo up to date...


Directly apply transformers models

Following the same pattern as with ultralytics.YOLO models, this integrates image classification and object detection models from the Hugging Face transformers library.
In particular:

Adds transformers utils for converting any transformers.models.<submod1>.<submod2>...ForImageClassification and any transformers.models.<submod1>.<submod2>...ForObjectDetection models to FiftyOne fo.Model objects
Allows these models to be entered directly into a sample collection's apply_model() method, and will "auto-magically work".

Example Usage

import fiftyone as fo
import fiftyone.zoo as foz

dataset = foz.load_zoo_dataset("quickstart")

## detection model
from transformers import DetrForObjectDetection
detr = DetrForObjectDetection.from_pretrained("facebook/detr-resnet-50", revision="no_timm")
dataset.apply_model(detr, label_field="detr", batch_size=10)

## classification model
from transformers import BeitForImageClassification
beit = BeitForImageClassification.from_pretrained("microsoft/beit-base-patch16-224")
dataset[:100].apply_model(beit, label_field="beit")

Classification models
This should work without any modification for any of the models listed here
Detection models
Here is a subset of the detection models it should work for without modification:

https://huggingface.co/facebook/detr-resnet-50
https://huggingface.co/facebook/detr-resnet-101
https://huggingface.co/docs/transformers/model_doc/deta
https://huggingface.co/docs/transformers/model_doc/conditional_detr
https://huggingface.co/docs/transformers/model_doc/deformable_detr
https://huggingface.co/hustvl/yolos-tiny
https://huggingface.co/hustvl/yolos-small
https://huggingface.co/docs/transformers/model_doc/table-transformer

Notes
There are of course many ways to extend this. Here are the next steps I would propose:

Support loading from name with HF's from_pretrained via a custom syntax
Add in support for other traditional tasks: transformers has analogous ForSemanticSegmentation like this and ForInstanceSegmentation like this. These are likely the most important to add next. They also have ForDepthEstimation, which is something cool that we don't have much content for yet, to my knowledge.

Also worth noting that this will need to be merged with the YOLO branch.
Release Notes
Is this a user-facing change that should be mentioned in the release notes?

[ ] No. You can skip the rest of this section.
[ ] Yes. Give a description of this change to be included in the release
notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)
What areas of FiftyOne does this PR affect?

[ ] App: FiftyOne application changes
[ ] Build: Build and test infrastructure changes
[x] Core: Core fiftyone Python library changes
[ ] Documentation: FiftyOne documentation changes
[x] Other

@jacobmarks awesome! The example snippets in the PR description work for me 💯
I went ahead and rebased this branch onto apply-yolo-models, so that merge is taken care of.
What do you think about adding a Hugging Face integration page that documents this new superpower, analogous to https://docs.voxel51.com/integrations/ultralytics.html?

Yep, absolutely I can do this. Will write the integration doc once the code is finalized :)

@brimoor integration docs added :)


Support pip install pydantic[settings]

Change Summary
I have added a line to [project.optional-dependencies] in pyproject.toml to support the use of pip install pydantic[settings] to install both pydantic and pydantic-settings.
If/when this is merged, we should update the pydantic-settings docs here to mention this convenience method of installation.
Related issue number
N/A
Checklist

[X] The pull request title is a good summary of the changes - it will be used in the changelog
[X] Unit tests for the changes exist
[X] Tests pass on CI
[X] Documentation reflects the changes where applicable
[X] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@Viicos Thanks for the heads up! Just patched.

@Viicos: Any idea why the CI is failing here?

I reckon it's weird to add an extra dep when it's pydantic-settings that depends on pydantic, not the other way around.
It's an anti-pattern

That's fair. I was torn about it and am open to closing if that's the consensus.


cmd/go: add signal for go get -u to track branch?

Hi everyone,
I already posted an issue regarding go.mod files.
https://github.com/golang/go/issues/26640
This one is a little bit different but little bit linked to that old one.
I'm actually developping multiple repositories using 2 branches master and dev. Those branches are defined for each repositories. Lets assume I have the following ones:

myrepo1 (dev and master) using myrepo2
myrepo2 (dev and master)

I was wondering if there is a way to specify a branch for a specific repository inside the go.mod file.
For instance:
module github.com/myrepo1

require (
	github.com/myrepo2 v@sometag or @somebranch
}

The reason why I'm asking that is that, when I'm actually runing the go mod -sync cmd in my repo2, it will always check for the last commit in master (or maybe I'm wrong?). But I would like that it looks into my dev branch for the last commit.
So I was thinking that maybe I can tag my dev branch and then specify the version I want to grab but it means that I will need to tag everytime I want to test my dev branch.
Does anyone have already face that pb?
Hope my explanations are clear :s
Thanks in advance ! :)
@rsc

@bcmills

@maeglindeveloper: There might well be a better answer, but I think one approach would be to run go get myrepo2@dev in myrepo1 just before you want to test myrepo1. I suspect that would update the go.mod file in myrepo1 to record the current meaning of the dev branch for myrepo2 as a pseudo-version in the corresponding require directive (without you needing to have tagged myrepo2 just before testing, which I think is part of your concern).
I have not tested your specific case before, but some related snippets from the documentation:

The go command accepts a "module query" in place of a module version both on the command line and in the main module's go.mod file. (After evaluating a query found in the main module's go.mod file, the go command updates the file to replace the query with its result.)

and (with emphasis added):

A revision identifier for the underlying source repository, such as a commit hash prefix, revision tag, or branch name, selects that specific code revision. If the revision is also tagged with a semantic version, the query evaluates to that semantic version. Otherwise the query evaluates to a pseudo-version for the commit.

and:

go get github.com/gorilla/mux@master    # records current meaning of master

Those snippets are from a few different sections of the doc, but this section is perhaps most relevant:
https://tip.golang.org/cmd/go/#hdr-Module_queries
Sorry if that is off base, but what do you think about trying that?

@maeglindeveloper and there is a little more background here:
https://github.com/golang/go/wiki/Modules#how-to-upgrade-and-downgrade-dependencies
I think part of the intent of modules is:
"Day-to-day adding, removing, upgrading, and downgrading of dependencies should be done using 'go get', which will automatically update the go.mod file."
In addition, my understanding is the default behavior of a go.mod file is that it locks the versions of dependencies into place until a human takes some action (in order to have reproducible builds).
Taking all of that together, maybe it is not crazy that go get is a mechanism to tell one of your modules to update which version of your second module should be used at a given point in time?

(And go get is one option, but I think a more-or-less equivalent option is editing the go.mod directly to include the @dev module query, which I think then would be automatically converted and recorded back to the go.mod file as a pseudo-version... Between those two workflows, it would then depend whether you prefer to run a command like go get vs. edit a file).

The tricky part about a “use this branch” annotation is transitive dependencies.
If module A depends on B and C, and B depends on D@master, and C depends on D@dev, what should happen if I go get -u within A?
For replace directives, at least there is a clear answer: we use whichever branch A specified explicitly, and otherwise we use the master branch.
So I think if we support this sort of branch redirect, it — like replace — should be local to the module in which it appears.

We definitely can't respect those annotations in dependencies. We might respect an annotation like that in the current go.mod.

Linking back the other way, I think this is probably related to/dup of https://github.com/golang/go/issues/26853

go get -u myrepo2@dev

This doesn't seem to work right if there is a replace directive.
In our case we need to support the use of Gitlab subgroups, so we have to use a replace directive like:
require gitlab.acmecorp.uk/foo/bar/project v0.0.0-20190225143601-609ef8e30e26
replace gitlab.acmecorp.uk/foo/bar/project => gitlab.acmecorp.uk/foo/bar/project.git  v0.0.0-20190225143601-609ef8e30e26

Using go get -u gitlab.acmecorp.uk/foo/bar/project@master will change the go.mod file so it's:
require (
    gitlab.acmecorp.uk/foo/bar/project v0.0.0-20190225143601-609ef8e30e26
    gitlab.acmecorp.uk/foo/bar/project.git v0.0.0-20190225153601-12312312312
)
replace gitlab.acmecorp.uk/foo/bar/project => gitlab.acmecorp.uk/foo/bar/project.git  v0.0.0-20190225143601-609ef8e30e26

At least it's generating the version string so I can copy that into the right place, but usability-wise it's a bit of a nightmare.

@Xiol, the behavior you are describing is #28176, but the particular use-case (resolving an import of /git to the repository at /project.git) is better suited to go-import tagging than to replace directives.

I have a same problem. But I fixed it by making sure there are no Go files using or refer to master.
I hope it can help you too.

I'm using OpenAPI Generator trying to merge different language SDKinto same repo,that cause I need go get can track on specified branch or it will take the wrong commit with other language....


chore(cypress): Update the cypress to version 10

:tada: This PR is included in version 1.5.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Remove AI boats in testnet

when visiting the site https://move-and-whap.netlify.app/, first impression is the game is broken as some boats show up but do not move. I think we should remove AI boats when not testing the game locally.

The boats are from real players. They will not move until the owner of that boat trigger the move button


Cosmetic issue with rules beginning with "@" (font-face, media, etc.)

Apologies if this is the wrong place, but I'm experiencing this new issue ever since the recent upgrade.
Whenever I add a comment before a rule beginning with "@", the selectors immediately afterwards are no longer highlighted correctly as shown in the screenshot below (normally I like to write "Media queries begin here" or something similar).

I encounter this issue when the syntax is set to HTML. Changing the syntax to CSS3 does fix the problem (see screenshot below) but obviously when you're working on a page which has HTML/JavaScript etc. the CSS3 syntax messes up the rest of the highlighting.

As I said, it only affects the first selectors - if I added more rules to the media query then they would be highlighted correctly.
Let me know if I've been unclear and I'll provide more information.
Thanks.

No worries - thanks for the reply.

The problem is caused by the highlighter mismatching the comment as a rule. I can't thank you enough for reporting this. This was a pretty big bug. I also found another subtle bug with the rule context while I was debugging this problem. So good job, @FL-KJ!
The fix should be out shortly.

No problem. If I encounter any more bugs I'll let you know.
I'm sure it goes without saying, but thanks for all your hard work on this plugin. As a front-end dev I use this every day and I can't imagine how tedious my job would become without it - your efforts are greatly appreciated.


Add reannotator query and k8s configuration

This change adds the reannotator query (which produces the list of daily archive URLs that need to be reprocessed) as well as a k8s Job configuration for the reannotator and initialization of the job-server.
For now the job is initialized with a single date as a proof of concept until we are ready for full production deployment.
The sample date was processed without error: https://console.cloud.google.com/storage/browser/annotation2-output-mlab-sandbox/ndt/annotation2/2023/02/10

This change is

Pull Request Test Coverage Report for Build 231

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.451%

Totals

Change from base Build 229:
0.0%

Covered Lines:
625

Relevant Lines:
648

💛  - Coveralls

Thank you!

Thank you!

Part of:

https://github.com/m-lab/uuid-annotator/issues/48


TR Autoverlad - Empty TripId

Expected a value for TripResult/Id and TripResult/Trip/Id nodes, got empty nodes instead:
<TripResult>
    <Id />
    <Trip>
        <Id />
        <Duration>PT39M59S</Duration>
        <StartTime>2024-08-15T22:12:00Z</StartTime>
        <EndTime>2024-08-15T22:51:59Z</EndTime>
        <Transfers>2</Transfers>
        <Distance>33990</Distance>

Request / response (PROD, but is broken also on TEST)
https://gist.github.com/vasile/97f6c21222a332903863ecfbbdf6682d
Test URL: https://tools.odpch.ch/ojp-demo-v2/search?from=8576367&to=46.320059,7.754451&mode_types=monomodal&transport_modes=self-drive-car

Already fixed on PROD


Insufficient Unique ID Message when clicking the RDT and Sample Collection Form

When clicking the RDT Form and Sample Collection Form there is Insufficient Unique ID Message appeared so the form can't be accessed.
Steps to reproduce the behavior:

Go to the home page
Click on one of the clients
Click the RDT Form or Sample Collection (Pengambilan Sampel) Form
See error message: ID unik tidak cukup. Mohon nyalakan koneksi internet Anda dan lakukan sinkronisasi manual untuk mengambil perintah.

If we click either RDT or Sample Collection, it is supposed to proceed to the next page

Device: Samsung Galazy A50s Android 10; Redmi 5 Plus Android 7

Done by setting identifier-source through API.


SSL error when trying to fetch data

First things first
Thanks for the brilliant package, folks! The setup has been easy and I love the predefined styles!
Setting
However, I'm running into an issue. I've defined the JSON locally and loaded it from the bundle. This works but when the screen appears it gives me SSL errors. The same happens when trying to tap the vote button.
Error message
NSURLErrorDomain Code=-1200 "An SSL error has occurred and a secure connection
 to the server cannot be made." UserInfo{NSErrorFailingURLStringKey=
https://api.countapi.xyz/get/<my-bundle-id>/feature2, NSLocalizedRecoverySuggestion=
Would you like to connect to the server anyway?, _kCFStreamErrorDomainKey
=3,_NSURLErrorFailingURLSessionTaskErrorKey=LocalDataTask
<0D7EC436-7228-497B-A1CF-28DCE78A28D3>.<3>, _NSURLErrorRelatedURLSessionTaskErrorKey=()

Tried fixes
I thought it may be due to the fact that I need to allow to bypass App Transport Security (although it is an HTTPS domain) and both whitelisting everything as well as specifying the domain to be exempted doesn't work.
Other thoughts
I'm not sure what other reasons it might have, maybe it is due to me having it only locally as files and it is therefore not correctly registered with the countapi?
Anyways: Looking forward to any other ideas you might have. Thanks again for the package!

Might be related to #70. It previously worked.

Yep, unfortunately countapi went down (again). Im in touch with their ceo, they're looking into it. Sorry about that!
Added the warning back.

No need to be sorry for anything.
 :)
Thanks for the quick answers, and if there's anything you need help with let me know!

Unfortunately they won't be able to solve it anytime soon.
An update to the matter.
I checked with our team and we might not be able to restore this in the near future.
I realize this is not the response you were
hoping for and am sorry for any inconvenience caused.
Best,
Aleksa
Customer Success Manager
If anyone has any suggestions for alternatives that would be great!


login to authenticated registry failing

When using downstream authenticated registry vars, the images pulls still fail. When I looked at the playbook, the login process is in ceph-container-common, but for the dashboard this role is not included?
ceph-ansible-4.0.2-1.el8cp.noarch
group_vars/all.yml
---
alertmanager_container_image: registry.redhat.io/openshift4/ose-prometheus-alertmanager:4.1
ceph_conf_overrides:
  global:
    osd_crush_chooseleaf_type: 0
    osd_pool_default_size: 1
ceph_docker_image: rhceph-beta/rhceph-4-rhel8
ceph_docker_registry: registry.redhat.io
ceph_docker_registry_auth: true
ceph_docker_registry_password: <my password>
ceph_docker_registry_username: <my user>
ceph_origin: repository
ceph_repository: rhcs
ceph_repository_type: iso
ceph_rhcs_iso_path: /usr/share/ansible-runner-service/iso/RHCEPH-4.0-RHEL-8-20191007.6-x86_64-dvd.iso
ceph_rhcs_version: 4
cluster_network: <IP_ADDRESS>/24
containerized_deployment: false
dashboard_enabled: true
grafana_container_image: registry.redhat.io/rhceph/rhceph-3-dashboard-rhel7:3
ip_version: ipv4
monitor_address_block: <IP_ADDRESS>/24
node_exporter_container_image: registry.redhat.io/openshift4/ose-prometheus-node-exporter:v4.1
prometheus_container_image: registry.redhat.io/openshift4/ose-prometheus:4.1
public_network: <IP_ADDRESS>/24
radosgw_address_block: <IP_ADDRESS>/24

@pcuzner could you share a full log?

rerunning now with latest stable branch (instead of downstream rpm)

@guits  The task that fails is the grafana startup. I've attached the stdout from the run and also the grafana-server systemd log that shows the issue trying to pull from the auth'd registry
grafana-startup.log
play_stdout.log

That's a valid issue. The ceph-container-common role isn't executed when deploying the dashboard with rpms.
I'm only surprise that it's not failing on node-exporter or prometheus because both roles are executed before grafana.
@pcuzner Could check both node-exporter and prometheus logs ? I think we should see the same issue than grafana


Output the source archive's SHA512..

so that [VOTE] mail archives point to the exact archive that was validated

I took the liberty of making a small change to your patch @bdelacretaz.


cert-manager is auto-renewing the Let's Encrypt certificates every 24hr

Describe the bug:
cert-manager seems to be renewing wildcard certificates every 24hrs. We haven't configured any renewalTime on the certificate spec and are using the defaults, which according to the documentation is 2/3 of the duration. For Let's Encrypt certificates, the duration is 90 days and hence renewal should have been attempted 30 days prior.
From cert-manager logs, we can see two statements claimingRenewing certificate as renewal was scheduled at wice, with different renewalTime:
I1211 01:11:18.992472 ... Renewing certificate as renewal was scheduled at 2022-02-08 00:09:58+0000 UTC
I1211 01:11:19.295191 ... Renewing certificate as renewal was scheduled at 2021-12-06 14:09:37+0000 UTC
I1210 17:16:13.993510       1 setup.go:202] cert-manager/controller/issuers "msg"="skipping re-verifying ACME account as cached registration details look sufficient" "related_resource_kind"="Secret" "related_resource_name"="letsencrypt-prod-account-key" "related_resource_namespace"="internal-proxy" "resource_kind"="Issuer" "resource_name"="letsencrypt-prod-issuer" "resource_namespace"="internal-proxy" "resource_version"="v1"
I1211 01:11:18.992472       1 trigger_controller.go:181] cert-manager/controller/certificates-trigger "msg"="Certificate must be re-issued" "key"="internal-proxy/gacert-xyz-wildcard-cert" "message"="Renewing certificate as renewal was scheduled at 2022-02-08 00:09:58+0000 UTC" "reason"="Renewing"
I1211 01:11:18.992534       1 conditions.go:201] Setting lastTransitionTime for Certificate "gacert-xyz-wildcard-cert" condit
ion "Issuing" to 2021-12-11 01:11:18.992527439 +0000 UTC m=+28546.410864656
I1211 01:11:19.294129       1 controller.go:161] cert-manager/controller/certificates-trigger "msg"="re-queuing item due to optimistic locking on resource" "key"="internal-proxy/gacert-xyz-wildcard-cert" "error"="Operation cannot be fulfilled on certificates.cert-manager.io \"gacert-xyz-wildcard-cert\": the object has been modified; please apply your changes to the latest version and try again"
I1211 01:11:19.295191       1 trigger_controller.go:181] cert-manager/controller/certificates-trigger "msg"="Certificate must be re-issued" "key"="internal-proxy/gacert-xyz-wildcard-cert" "message"="Renewing certificate as renewal was scheduled at 2021-12-06 14:09:37+0000 UTC" "reason"="Renewing"
I1211 01:11:19.295237       1 conditions.go:201] Setting lastTransitionTime for Certificate "gacert-xyz-wildcard-cert" condit
ion "Issuing" to 2021-12-11 01:11:19.295227555 +0000 UTC m=+28546.713564792
I1211 01:11:20.019256       1 conditions.go:261] Setting lastTransitionTime for CertificateRequest "gacert-xyz-wildcard-cert-
kp4q6" condition "Approved" to 2021-12-11 01:11:20.019241023 +0000 UTC m=+28547.437578274
I1211 01:11:20.379464       1 conditions.go:261] Setting lastTransitionTime for CertificateRequest "gacert-xyz-wildcard-cert-
kp4q6" condition "Ready" to 2021-12-11 01:11:20.379445459 +0000 UTC m=+28547.797782716
I1211 01:11:20.456761       1 conditions.go:261] Setting lastTransitionTime for CertificateRequest "gacert-xyz-wildcard-cert-
kp4q6" condition "Ready" to 2021-12-11 01:11:20.456752998 +0000 UTC m=+28547.875090225
I1211 01:11:20.504741       1 controller.go:161] cert-manager/controller/certificaterequests-issuer-acme "msg"="re-queuing item due to optimistic locking on resource" "key"="internal-proxy/gacert-xyz-wildcard-cert-kp4q6" "error"="Operation cannot be fulfilled on certificaterequests.cert-manager.io \"gacert-xyz-wildcard-cert-kp4q6\": the object has been modified; please apply your changes to the latest version and try again"

Certificate spec as initially created:
└─ $ ▶ kubectl describe certificate gacert-xyz-wildcard-cert
Name:         gacert-xyz-wildcard-cert
Namespace:    internal-proxy
Annotations:  maintainer:
API Version:  cert-manager.io/v1
Kind:         Certificate
Metadata:
  Creation Timestamp:  2021-12-09T11:58:22Z
  Generation:          1
  Resource Version:<PHONE_NUMBER>
  UID:               5d1d194c-23c6-41a5-9596-3b95184790a5
Spec:
  Dns Names:
    *.xyz.io
  Issuer Ref:
    Kind:       Issuer
    Name:       letsencrypt-prod-issuer
  Secret Name:  gacert-xyz-wildcard
Status:
  Conditions:
    Last Transition Time:  2021-12-09T11:58:22Z
    Message:               Certificate is up to date and has not expired
    Observed Generation:   1
    Reason:                Ready
    Status:                True
    Type:                  Ready
  Not After:               2022-03-10T00:09:58Z
  Not Before:              2021-12-10T00:09:59Z
  Renewal Time:            2022-02-08T00:09:58Z
  Revision:                2
Events:                    <none>

As we can see the renewal time is Feb 2022, but since Friday it has got renewed twice already.
The current spec has the below status:
Status:
  Conditions:
    Last Transition Time:  2021-12-09T11:58:22Z
    Message:               Certificate is up to date and has not expired
    Observed Generation:   1
    Reason:                Ready
    Status:                True
    Type:                  Ready
  Not After:               2022-03-13T00:14:10Z
  Not Before:              2021-12-13T00:14:11Z
  Renewal Time:            2022-02-11T00:14:10Z
  Revision:                5
Events:                    <none>

Expected behaviour:
I expected it to renew on the Renewal Time mentioned in the Certificate status.
Steps to reproduce the bug:

Anything else we need to know?:
Environment details::

Kubernetes version: 1.20
Cloud-provider/provisioner: On-prem cluster
cert-manager version: 1.6.1
Install method: helm

/kind bug

I've been trying to reproduce this issue (with a LetsEncrypt prod issuer on a 1.20.12-gke.1500 Kubernetes cluster) and  a wildcard cert with no renewal time/duration explicity specified- have run this for 3 days, but haven't seen any unexpected renewals.
It might be worth to look at the full cert-manager controller debug log (you can increase log level with --v=5 flag to controller) and also look at the CertificateRequests created for this Certificate.

I'm facing this issue now, any suggestions?


Add trailing_visual_label to SegmentedControlItem

Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
Sometimes it is useful to add a trailing label to items in the Segmented Control Item. One use case is displaying a discount when selecting between different billing intervals, eg "Monthly / Yearly (-8%)"
Screenshots

Integration

This is additive, so no changes are necessary.
Risk Assessment

[x] Low risk the change is small, highly observable, and easily rolled back.
[ ] Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
[ ] High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?
I thought of three different ways, each have their own drawbacks.

Expose a more general button slot. (This would require interface changes, and is generally more awkward for callers).
Add a trailing_visual slot. This mimics the button trailing_visual slot, but doesn't have control over placement. (Is there some way we can pass through this information to the button trailing_visual slot?) It looks visually okay, but the label ends up being in the content span.
Pass through label params as a top level item parameter. This produces the most correct markup, but is a little awkward in the signature. (This PR)

Anything you want to highlight for special attention from reviewers?

I'm open to other alternatives that give us the ability to add a trailing label.
Accessibility

No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

[x] Added/updated tests
[ ] Added/updated documentation
[x] Added/updated previews (Lookbook)
[x] Tested in Chrome
[x] Tested in Firefox
[x] Tested in Safari
[x] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.
Testing Instructions

script/dev
Visit http://localhost:4000/lookbook/inspect/primer/alpha/segmented_control/trailing_label
script/test /workspaces/view_components/test/components/primer/alpha/segmented_control_test.rb

Let me know if there's anything else I need to prep for the vis-diff test.
The new screenshots look okay, and the dismissible test looks like it's dependent on timing for if we want the tooltip to appear or not as a reference shot. Would recommend moving the focus in that test, unless it's intended.

Thanks for the great suggestions @jonrohan!


Laravel 11.x Compatibility

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 11.x.
Before merging, you need to:

Checkout the l11-compatibility branch
Review all comments for additional changes
Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

:warning: Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 11. However, you should review these changes to ensure the desired combination of versions are built for your package.

:alembic: Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.
To do so, temporarily add Shift's fork to the repositories property of your composer.json:
{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/pipeline-query-collection.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:
{
    "require": {
        "l3aro/pipeline-query-collection": "dev-l11-compatibility",
    }
}

Finally, run: composer update


Dataset properties that are not valid OData identifiers are always empty in entities table

If the name of a dataset property is not a valid OData identifier, then a different name will be used for the property in the OData feed (via sanitizeOdataIdentifier() in Backend). In Frontend, the entities table uses the OData feed, but right now, if the name of a property differs from its OData identifier, the property's value is never shown. For example, I created a dataset with a property named circumference.cm, and the property is empty in the table: https://staging.getodk.cloud/#/projects/23/datasets/trees/entities. Yet if you access this entity using the REST API, you can see that its circumference.cm property is not empty: https://staging.getodk.cloud/v1/projects/23/datasets/trees/entities/c3e0d5f0-2af5-44bb-ad3f-26fb9f93288b. I think the issue is that we try to access property data using the name of the property, not its OData identifier:
https://github.com/getodk/central-frontend/blob/1e7902b988ed7ba8cbaf661d5415ab849ff32506/src/components/entity/data-row.vue#L14-L15
This isn't an issue in the submissions table because Frontend specifies a query parameter of odata=true when it sends a request to the form fields endpoint. As a result, the endpoint returns OData identifiers for Frontend to use. I think we could have Backend do something similar for dataset properties, or we could import sanitizeOdataIdentifier() to Frontend and use it here.

@sadiqkhoja, I think we still need to use odataName in Frontend. Would you mind creating a PR for that?


Better explanation of how running job on GCP (Google Cloud Platform)

Greetings folks, I've a small suggestion to improve the explanations about running a model on the Google Cloud Platform, (section Run training job in the README.md)  for the newbies. Do whatever you want with it...
In order to submit the training job to the Google Cloud Machine Learning Engine from your laptop:

Install the GitHub tensorflow-rl-pong code and requirements on your laptop
Get a Google Cloud Account and enable billing (credit card)
Create a Google Cloud Platform project on Google Cloud
Install the GCP command line tools on your laptop
Create a Google Cloud Data bucket in order to store the code and the trained model on Google Cloud
On your laptop, you should edit the submit.sh and change the commented line
# GCS_BUCKET="gs://my-bucket/"
and replace my-bucket by your bucket id you've created in 5)
On your laptop, do bash submit.sh  or eventually sudo bash submit.sh

Thank you for the suggestion. I will improve the instructions. And thanks for sharing.


Minor changes after code review

@metamatik, as discussed those are the changes to requirements I'd like to propose.

@maikhoepfel › I rebased this PR. Can you pick a quick eye on it, so I can merge changes to develop? Thank you very much for your response.

Will do on Thursday or Friday. Thanks.


Adding missing features for Swift_Message > Email

Adds support for Swift_Message::getId
Adds support for Swift_Message::addPart

Just found a bug for multiple addresses, working on it

Thank you @stefantalen


Update theme encoder for checkbox, radio and switch themes

Description

Currently encodeThemeData doesn't encode checkboxTheme, radioTheme and switchTheme. This PR updates the method to encode these themes.
Closes #32

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[X] I read the Code Style Guide and followed the process outlined there for submitting PRs.
[X] All existing and new tests are passing.
[X] I updated/added relevant documentation (doc comments with ///).
[X] The analyzer (flutter analyze) does not report any problems on my PR.
[X] I updated pubspec.yaml, build.properties, and ios/Podfile with an appropriate new version according to the pub versioning philosophy.
[X] I updated CHANGELOG.md to add a description of the change.
[X] I am authorized to release this code under the MIT License and agree to do so

UI Change
Does your PR affect any UI screens?

[ ] Yes, the relevant screens are included below.
[X] No, there are no UI impacts with this PR.

Build doesn't pass but I don't think they're relevant to my changes. I ran the tests locally and they all passed 🙂

Hey there, thanks for the PR.  The issues were not related to your code, they were due to Flutter 2.10 being released just before your PR, and now some of the code had analysis issues.
I fixed those issues, and merged your PR.


⚠ Bofrost.lu has degraded performance

In 792bda3, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1286 ms

Resolved: Bofrost.lu performance has improved in 8c5d898.


Stratagem scans should be removed from MDS nodes after transfer to mailbox

Stratagem scans should be removed from MDS nodes after transfer to mailbox, they currently are not.

Superseded by #1329.


Chrysler Pacifica 2017 being fingerprinted as 2018

Discord ID: @mbuboltz#4220
dongle_id
4798c754e5a85bac
car doesn't match any fingerprints: {0: {324: 8, 344: 8, 368: 8, 416: 7, 500: 8, 520: 8, 559: 8, 532: 8, 571: 3, 564: 4, 625: 8, 544: 8, 658: 6, 660: 8, 680: 8, 760: 8, 993: 7, 258: 8, 264: 8, 288: 7, 280: 8, 294: 8, 290: 6, 514: 8, 308: 8, 55: 8, 274: 2, 746: 5, 1891: 8, 671: 8, 632: 8, 832: 8, 268: 8, 284: 8, 292: 8, 320: 8, 331: 8, 332: 8, 388: 4, 501: 8, 512: 8, 669: 3, 1251: 8, 448: 6, 736: 8, 729: 5, 257: 5, 792: 8, 384: 8, 863: 8, 672: 8, 800: 8, 1031: 8, 764: 8, 376: 3, 766: 8, 992: 8, 300: 8}, 1: {512: 8, 544: 8, 576: 8, 608: 8, 640: 8, 644: 8, 648: 8, 652: 8, 656: 8, 672: 8, 704: 8, 736: 8, 768: 8, 800: 8, 816: 8, 832: 8, 864: 8, 880: 8, 896: 8, 898: 8, 900: 8, 902: 8, 904: 8, 906: 8, 908: 8}, 2: {324: 8, 344: 8, 368: 8, 416: 7, 500: 8, 520: 8, 559: 8, 532: 8, 571: 3, 564: 4, 625: 8, 544: 8, 658: 6, 660: 8, 680: 8, 760: 8, 993: 7, 258: 8, 264: 8, 288: 7, 280: 8, 294: 8, 290: 6, 514: 8, 308: 8, 55: 8, 274: 2, 746: 5, 1891: 8, 671: 8, 632: 8, 832: 8, 268: 8, 284: 8, 292: 8, 320: 8, 331: 8, 332: 8, 388: 4, 501: 8, 512: 8, 669: 3, 1251: 8, 448: 6, 736: 8, 729: 5, 257: 5, 792: 8, 384: 8, 863: 8, 672: 8, 800: 8, 1031: 8, 764: 8, 376: 3, 766: 8, 992: 8, 300: 8}, 3: {}}

I'm not sure what the issue is. Did you split them out into two separate cars on your fork? Because in openpilot the 2017 and 2018 is the same car.

You are right. I split them some time ago.


IPv6 Inner/Outer Hardware Offload

Can one of the admins verify this patch?

bot:retest

bot:retest

bot:retest

Test FAILed.

Test PASSed.

Test PASSed.

Test FAILed.

Test FAILed.

Test PASSed.

Tests PASSed.

Tests PASSed.

Tests PASSed.

Tests FAILed.

Tests PASSed.

Tests FAILed for https://github.com/Mellanox/OVS/pull/26.
See http://hpc-master.lab.mtl.com:8080/job/_OVS_team/job/OVS_Baidu/149//console for details.

Tests PASSed for PR#https://github.com/Mellanox/OVS/pull/26.
See http://hpc-master.lab.mtl.com:8080/job/_OVS_team/job/OVS_Baidu/150/console for details.

Please see my comments.
In general, make sure to run checkpatch and update the code accordingly.

Yes, I actually forgot to do that.

Besides the commit header, need also to add text to the body, giving more info on the patch itself.
For now, it's ok and once you prepare the patches for the community need to take that into consideration.
The commit header should start with a capital letter after the ':' and should end with '.'.

Ok, though in general the first line of commit message shouldn't end with period, and there isn't any note about this in OVS contributing guidelines. But I see most commits end with a period, so it's a convention I didn't know about, I'll be following it.
I don't suppose there is a way to amend a commit inside a PR and not lose reviewers' comments?

With our newly code we indeed use VLOG_ERR_RL.
Regards,
Asaf Penso
From: Eveline Raine<EMAIL_ADDRESS>Sent: Sunday, March 24, 2019 12:59 PM
To: Mellanox/OVS<EMAIL_ADDRESS>Cc: Asaf Penso<EMAIL_ADDRESS>Review requested<EMAIL_ADDRESS>Subject: Re: [Mellanox/OVS] IPv6 Inner/Outer Hardware Offload (#26)
@evelineraine commented on this pull request.

In lib/netdev-rte-offloads.chttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMellanox%2FOVS%2Fpull%2F26%23discussion_r268428296&data=02|01|asafp%40mellanox.com|30a16ee7bbdf49c2032808d6b047a79a|a652971c7d2e4d9ba6a4d149256f461b|0|0|636890219136555657&sdata=2jm%2BGUaicpAiHbQqmR6WtHMlimdeyowN0HRmdi%2F9B0o%3D&reserved=0:

 } else {

   VLOG_ERR("tunnel L3 header is neither IPv4 nor IPv6");

In the netdev_dpdk_validate_flow() we are already checking which offload patterns we do and don't support. After this check, all invalid patterns for outer header are filtered out. This leaves us with either IPv4 or IPv6 as outer L3 protocols. If for some reason here we get neither, this is a real error.
VLOG_ERR_RL would be an option. Any reason we shouldn't make this a default and use everywhere in place of VLOG_ERR?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMellanox%2FOVS%2Fpull%2F26%23discussion_r268428296&data=02|01|asafp%40mellanox.com|30a16ee7bbdf49c2032808d6b047a79a|a652971c7d2e4d9ba6a4d149256f461b|0|0|636890219136565622&sdata=%2BsgMmiFWSRNat1zItEUTPG2nikn2zVSFilNTTErRiAQ%3D&reserved=0, or mute the threadhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAoqtvFSDaptk3aAOwsrphRLYFnQ9Lwfnks5vZ1pWgaJpZM4b4YWo&data=02|01|asafp%40mellanox.com|30a16ee7bbdf49c2032808d6b047a79a|a652971c7d2e4d9ba6a4d149256f461b|0|0|636890219136565622&sdata=qk3ZXdyIwLUsRLh%2Fxr3O7ZHfxlWi%2B6MHY%2F4EGQX%2FP7U%3D&reserved=0.

Ophir and I discussed that in the past and we prefer to update the patches themselves, and not adding a new patch to fix the comments.
Afterwards to push -f , which will maintain the comments for the previous commits and will show the new patches as well.
I hope it is clear 😊
Regards,
Asaf Penso
From: Eveline Raine<EMAIL_ADDRESS>Sent: Sunday, March 24, 2019 1:12 PM
To: Mellanox/OVS<EMAIL_ADDRESS>Cc: Asaf Penso<EMAIL_ADDRESS>Review requested<EMAIL_ADDRESS>Subject: Re: [Mellanox/OVS] IPv6 Inner/Outer Hardware Offload (#26)
Please see my comments.
In general, make sure to run checkpatch and update the code accordingly.
Yes, I actually forgot to do that.
Besides the commit header, need also to add text to the body, giving more info on the patch itself.
For now, it's ok and once you prepare the patches for the community need to take that into consideration.
The commit header should start with a capital letter after the ':' and should end with '.'.
Ok, though in general the first line of commit message shouldn't end with period, and there isn't any note about this in OVS contributing guidelines. But I see most commits end with a period, so it's a convention I didn't know about, I'll be following it.
I don't suppose there is a way to amend a commit inside a PR and not lose reviewers' comments?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMellanox%2FOVS%2Fpull%2F26%23issuecomment-475948834&data=02|01|asafp%40mellanox.com|1adf6787bfdf45b9f17608d6b0497eab|a652971c7d2e4d9ba6a4d149256f461b|0|0|636890227042735054&sdata=EN3hxX2HTK5YZBRVS3mCRhqxHIAVwjTlr281hkP6rQg%3D&reserved=0, or mute the threadhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAoqtvMQFxKgSLEjS3ehQGlvtc3k0PpZUks5vZ11tgaJpZM4b4YWo&data=02|01|asafp%40mellanox.com|1adf6787bfdf45b9f17608d6b0497eab|a652971c7d2e4d9ba6a4d149256f461b|0|0|636890227042745059&sdata=S1K6N%2Fc%2FVVwEBeSITDMsdtY3rRZh6uKbL9M73apro3A%3D&reserved=0.

Comments regarding commit: ("dpif-netdev: Improve ufid logging")

Same comment as before (and for the remaining commits): commit message body should be filled in.
A title only is not sufficient.

A comment added inside the code

Please fix checkpatch warnings:

== Checking cc409080a341 ("dpif-netdev: Improve ufid logging") ==
WARNING: Line is 81 characters long (recommended limit is 79)
#20 FILE: lib/dpif-netdev.c:2155:
VLOG_WARN("Masked megaflow ufid "UUID_FMT" is not associated with a mark?\n",
WARNING: Line is 117 characters long (recommended limit is 79)
#38 FILE: lib/dpif-netdev.c:2187:
VLOG_DBG("Associated dp_netdev flow ufid "UUID_FMT" with mark %u", UUID_ARGS((struct uuid *) &flow->ufid), mark);
Lines checked: 45, Warnings: 2, Errors: 0

Tests PASSed for PR#26.
See http://hpc-master.lab.mtl.com:8080/job/_OVS_team/job/OVS_Baidu/169/console for details.

Tests PASSed for PR#26.
See http://hpc-master.lab.mtl.com:8080/job/_OVS_team/job/OVS_Baidu/170/console for details.

Regarding commit: ("packets: Add IPv6 printf pattern")

Commit title: printf --> printout
Should elaborate in the commit message body about the contents of
the commit. A title only is not sufficient.
This is a preceding commit to another one which is several commits
away: "netdev-rte-offloads: Add flow dumping for IPv6".
The two commits should be consecutive.
Please note in file lib/packets.c that there is already an API for
printing IPv6 addresses:

/* Stores the string representation of the IPv6 address 'addr' into the
 * character array 'addr_str', which must be at least INET6_ADDRSTRLEN
 * bytes long. If addr is IPv4-mapped, store an IPv4 dotted-decimal string. */
 const char *
 ipv6_string_mapped(char *addr_str, const struct in6_addr *addr)

Let's keep the same format in our code. Can you use this API for Baidu
code?

1-3: Fixed
4:
I know this function exists. However there is another approach - to use *_FMT macros. I think this has a better precedent - we use this approach to print UUIDs in log messages like so:
VLOG_WARN("Masked megaflow ufid "UUID_FMT
                  " is not associated with a mark?\n",
                  UUID_ARGS((struct uuid *)mega_ufid));

In addition to this we already have such formatting macros in lib/packets.h for IPv4:
#define IP_FMT "%"PRIu32".%"PRIu32".%"PRIu32".%"PRIu32
#define IP_ARGS(ip)                             \
    ntohl(ip) >> 24,                            \
    (ntohl(ip) >> 16) & 0xff,                   \
    (ntohl(ip) >> 8) & 0xff,                    \
    ntohl(ip) & 0xff

So this makes sense to me to add parity for IPv6.
However the two approaches differ in that *_FMT macros always prints 39 characters (zeroes or not) but ipv6_string_mapped() can compress addresses.

Comments regarding commit: ("dpif-netdev: Improve ufid logging")

Same comment as before (and for the remaining commits): commit message body should be filled in.
A title only is not sufficient.
A comment added inside the code
Please fix checkpatch warnings:

== Checking cc409080a341 ("dpif-netdev: Improve ufid logging") ==
WARNING: Line is 81 characters long (recommended limit is 79)
#20 FILE: lib/dpif-netdev.c:2155:
VLOG_WARN("Masked megaflow ufid "UUID_FMT" is not associated with a mark?\n",
WARNING: Line is 117 characters long (recommended limit is 79)
#38 FILE: lib/dpif-netdev.c:2187:
VLOG_DBG("Associated dp_netdev flow ufid "UUID_FMT" with mark %u", UUID_ARGS((struct uuid *) &flow->ufid), mark);
Lines checked: 45, Warnings: 2, Errors: 0

1,3: Fixed

bot:retest

Tests PASSed for PR#26.
See http://hpc-master.lab.mtl.com:8080/job/_OVS_team/job/OVS_Baidu/173/console for details.

/* Stores the string representation of the IPv6 address 'addr' into the
 * character array 'addr_str', which must be at least INET6_ADDRSTRLEN
 * bytes long. If addr is IPv4-mapped, store an IPv4 dotted-decimal string. */
 const char *
 ipv6_string_mapped(char *addr_str, const struct in6_addr *addr)

Let's keep the same format in our code. Can you use this API for Baidu
code?

4:
I know this function exists. However there is another approach - to use *_FMT macros. I think this has a better precedent - we use this approach to print UUIDs in log messages like so:
VLOG_WARN("Masked megaflow ufid "UUID_FMT
                  " is not associated with a mark?\n",
                  UUID_ARGS((struct uuid *)mega_ufid));

There is a difference between ufid and IPv6 addresses. The former is condense. Every bit counts. We want to see all bits. The later is very sparse. We want to see only the few non-zero bits. This is why a standard was defined for printing IPv6 addresses in RFC 4291. https://tools.ietf.org/html/rfc4291.
The API used in OVS for printing IPv6 addresses is
ipv6_string_mapped()

and it is used dozens of times and uniquely in the OVS code. Can you please use it?
We should follow the OVS community standards. This is one of them.

In addition to this we already have such formatting macros in lib/packets.h for IPv4:
#define IP_FMT "%"PRIu32".%"PRIu32".%"PRIu32".%"PRIu32
#define IP_ARGS(ip)                             \
    ntohl(ip) >> 24,                            \
    (ntohl(ip) >> 16) & 0xff,                   \
    (ntohl(ip) >> 8) & 0xff,                    \
    ntohl(ip) & 0xff

The end result is that IPv4 is printed according to the IPv4 standard even though it uses this formatting macros. We are not sparse for IPv4. Still for IPv6 we need to be sparse.

However the two approaches differ in that *_FMT macros always prints 39 characters (zeroes or not) but ipv6_string_mapped() can compress addresses.

Yes...in order to be sparse.

Changes the print format from PRIx8 to PRIu8.

Whenever there is a fix for a previous commit, just before Signed-off-by ... at the end of the commit message you should add:
Fixes: <12 characters hash> ("<commit title>").

For example:
Fixes: b10d46a60013 ("tests: Check dpif-netdev odp_actions consistency.")
Signed-off-by: Ian Stokes<EMAIL_ADDRESS>
You can find the fixed commit details by running 'git blame "file_name"', then receive the fixed commit SHA1 number, then run 'git show "SHA1 number"' for the full details

Previously the code looked at decapsulated packet's Ethernet type to
determine tunnel L3 protocol is IPv4. The fix involves checking tunnel
address masks for IPv4 source and destination. If non-zero, the protocol
is IPv4.

Same comment as before: there is a fix here, so should add "Fixes: ..." at the end of commit message just before "Signed-of-by..." line.

OphirMunk 2 days ago  Member
When adding VLOG messages on an expected positive case we may be overwhelmed with printouts.
For example during high insertion rate. Instead of VLOG printouts we should take care of adding
statistics that will inform of the successful operation.
evelineraine 8 hours ago  Author Member
Without this printout, I discovered, it is difficult to determine the location of errors during offloading.

Have you checked an option to enhance error messages during offloading such that you it will be easy to determine the location of errors during offloading?

Besides, we are printing multiple debug messages with all the flow patterns we add. How does adding
this message make it worse?

One of our goals is to be best in flow insertion rate. VLOG_DBG adds additional code (even with a low log level and no printouts) and may reduce the insertion rate (should be measured and verified). If you are right and there are multiple VLOG_DBG on the fast path - they should all be removed as well (but don't do it yourself now). Any VLOG_DBG that is on  an error path or on a non-fast path - is OK. We are only measured on successful fast path.
By the way, looking at netdev-dpdk.c before it was split into netdev-rte-offloads.c - I notice no VLOG_DBG on the fast path.

packets: Add IPv6 printout pattern.

As mentioned previously we should use
ipv6_string_mapped()

for printing IPv6 addresses. Therefore I suggest omitting this commit.

Tests PASSed for PR#26.
See http://hpc-master.lab.mtl.com:8080/job/_OVS_team/job/OVS_Baidu/176/console for details.

@OphirMunk
I have changed flow dumping to print compresses IPv6 addresses using ipv6_string_mapped() and the removed the commit that adds *_FMT patterns.
I have also added the Fixes tags to my commits. Thank you for pointing that out!
I still don't agree about debug prints. In our code (in addition to multiline pattern dumps) we have this message printed for each flow being offloaded:
VLOG_DBG("second flow of decap created");

Without it, we wouldn't be able to debug all the issues we did on virtio since February. We have this line, same as the lines I added, to increase visibility into what is actually happening inside OVS.
It does impact performance, of course. In the same way counting marked and hardware offloaded packets that you added does as well. But it was done for the same reason - to increase visibility.
Regarding the fast path vs slow path - flows offloading is not really fastpath, just like inserting rules into the kernel module in OVS-kernel is not fastpath either. I don't think it makes sense to optimize it as hard as to drop debug information in order to save cycles. In dpif-netdev.c several debug messages are being printed for each flow even before it reaches netdev-rte-offloads.c.
If we want to squeeze the last bit of performance (while sacrificing some visibility in live production environments), we should add a way to compile-out debug messages with a #define flag like DPDK does.
All this being said, we really want to have this PR merged ASAP. If you still think I should remove the prints, I will and then we can follow up on this discussion later.

Merged into hwol-mlnx-dpdk17.11 branch


WIP master <- develop

Merge the develop branch into the master branch and deploy

Build log
Preview build with this PR (c7970943e77e50397e6fcf16cc8503a5b35228f7)

more info:cloud: Storage Free space   3.61 GiB    24.08%:open_file_folder: 61.47 MiB  CI_WORK/GitHubActions/roki-web

Build log
Preview build with this PR (4587f5679af3919f8e5ff90f000ee75b77f8189a)

more info:cloud: Storage Free space   3.44 GiB    22.95%:open_file_folder: 61.47 MiB  CI_WORK/GitHubActions/roki-web


Remove failed-backport label after successful backport

Often a backport fails because there's some other commit that needs to be backported first.
In that case, I typically toggle the backport label on/off to tell octobot to try the backport again.
In that case, it would make sense for octobot to clear the failed-backport label.

What should be done if multiple backports fail? There's only a single failed-backport label...

Ah, good point. That makes it more complicated ...


Missing latest release

Hi @theseer
Could you quickly write a GitHub release for the latest version ?
Just for users to see there is something new in 2021 since 2017

Done.


git ignore .crane.json

Current coverage is 40.87% (diff: 100%)

No coverage report found for master at 413f383.

Powered by Codecov. Last update 413f383...9c54135


Update MANIFEST.in

Hi  I am the maintainer of mkdocs in Fedora/epel I am working in the packaging of this theme and I want to include the License and Readme in the pypi tarball

I don't think you want to package this theme - it is intended as an example for theme authors only. However, that being said I am happy to accept it.
I would recommend packaging https://github.com/squidfunk/mkdocs-material - this is a particularly nice theme!

done: https://bugzilla.redhat.com/show_bug.cgi?id=1307149


Enhancement: Create labels for core keptn tags

Create labels for the core keptn tags:
keptn_project:sockshop, keptn_service:carts and keptn_stage:dev.

Completed in https://github.com/keptn-sandbox/jira-service/pull/4/commits/033cab6f2164e354a8594640bf7ba8dc65e3d79d

I am seeing the labels that are in the cloud event.

I suggest having just the keptn-project, keptn-service, keptn-stage, keptn-result.

I am seeing the three labels OK in JIRA for he PROBLEM.OPEN event.

But for the EVALUATION, in JIRA I am seeing these plus the labels from the cloud event.  I think we want just the keptn-project, keptn-service, keptn-stage.  But if, if you need to into the code adding a keptn-result label would be nice to have too.


Fix a crash if an empty JSON configuration file is specified.

If you pass an empty file to swift test --configuration-path, we crash on an unexpected nil value. Fix it fix it fix it!
Checklist:

[ ] Code and documentation should follow the style of the Style Guide.
[ ] If public symbols are renamed or modified, DocC references should be updated.

@swift-ci please test


parser for batch events

added simple parser for batch events

@homeyjd did as requested. I saw you already created a batch even parser so I took yours. But still you could close/merge this PR

Thanks @lehneres!


ts_lua -- Exposes the TS API function TSHttpTxnNextHopAddrGet()

This change exposes the TS API function TSHttpTxnNextHopAddrGet()
to the Lua plugin as ts.server_request.server_addr.get_nexthop_addr().

[approve ci]

question: Under what situation is this result going to be different from TSHttpTxnServerAddrGet() ?

When this is called from the context of a child cache in a parent/child hierarchy. We need to determine what the next hop cache is going to be.


How to use with 2FA

Would I have to remove 2FA to use this, looks really good and could help people use their proton accounts with next cloud.
Thanks for the work

Glad it's useful! When enabled, 2FA will generate a code during the login attempt which the user will have to manually retrieve and input into the bridge application. This means the role would require user action. I could add it as a non-default variable... let me play around with it this weekend :)

hi @boiUneedAwash , this has been implemented. see the updated readme for additional information.


Plain text

How do we just grab the plain text of the content?
Thanks!

In version 0.2.0 you can subscribe to the onChange event which sends html and text like this:
handleEditorChange(html, text) {}
render() { return <TrixEditor onChange={this.handleEditorChange} />; }


README-recommended nightly version for main vs release

Hi, thanks for building this tool!
I just tried to run this locally for the first time (in a long time? don't remember) and failed. The README:

It was last tested against nightly-2024-10-29.

(From #190.)
But, 0.1.13 (the last release on crates.io) apparently predates the merge of #190. It would be nice to communicate the nightly version for the last released version in the README as well.
(I recovered nightly-2024-06-30 from the rustls CI setup.)

I made a PR to update the messaging. What do you think? https://github.com/awslabs/cargo-check-external-types/pull/201/files


how to recover from that issue

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 396c23ca-a799-032b-527b-d9362e44b514
Version Independent ID: 884704df-8e4c-2dde-8c2d-96287f8d673d
Content: Compiler Error CS0229
Content Source: docs/csharp/language-reference/compiler-messages/cs0229.md
Product: dotnet-csharp
Technology: csharp-diagnostics
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Hi @PRITIPATEL02
I can't tell the answer from the screenshot you added here.
In general, this error is because a name could resolve to multiple objects. You have to specify which of the types are in use.
In COM interop, it can also be caused by importing multiple versions of the same interface.
I'd check both of those, and if neither help resolve the issue, you should post a follow up on our Q & A section. That area is better for specific support questions.
I'll close this as a support request.


"working" flag + device names

Working flag is True while devices are created.
Devices name will be downloaded from CCU if the XML-API is installed

For the working flag: This does not work for me. Within the RPCFunctions-object it is working as designed. But the purpose of this flag is to test it by doing something like if homematic._server.working:, which always is set to False in my tests.
It seems like the value is bound to its scope within the object, even though global is being used. Not sure why that happens.
I can't test the device names functionality. I assume it is working for you. If you devide the code of this pullrequest into two, I would pull the one with the XML-API and have a look at the working-topic.

Correction: The flag does change. But only for a brief moment while the deviceobjects are actually created, not during the time we are waiting for them. So the implementation does not provide any benefits. And thinking of it, waiting for the devices is not "working". We're essentially just waiting for a new_devices-event, which can occur anytime, and is handled already.
Since this is needed for HA I suggest to let the HA-component attatch a callback which waits for the new_devices-event, and creates the HA platforms as soon as the event gets triggered.
I'll habe a look at your HA-related code and see what I can work out.

This is how I apply the working flag:
pyhomematic.create_server(...) pyhomematic.start() while not pyhomematic.devices or pyhomematic._server.working:     pass
This behavior might not be obvious but from my understanding it matches good to the term 'working' (while the app is waiting for the first call of addDevices this would be not be 'working' but 'waiting' for me).
Other interpretations and implementations are possible but than I would vote for a renaiming the flag (e.g. 'initializing') or introducing a function instead (e.g. waitForDevices()). The advantage I see in the current implementation is that it is possible to react to the situation that no decives are created...
Please note: The createDeviceObjects call in init does never create any devices for me, as _devices_raw is always empty at this point of time...

Because of the switch from homematic to pyhomematic this can't be merged. I've copied the code manually, fixed a bug, und pushed it into the repository. Closing the PR.


Make macs happy

Two changes were required to make the docker-compose up build process work on apple sillicon machines as well.
Please double-check whether these changes do not break the flow on Linux/Intel hosts of course 😜 .

Sorry, failure
Step 8/32 : RUN sudo ln -s /proc/self/mounts /etc/mtab
 ---> Running in 1fd87548e7b4
ln: failed to create symbolic link '/etc/mtab': File exists
The command '/bin/sh -c sudo ln -s /proc/self/mounts /etc/mtab' returned a non-zero code: 1
ERROR: Service 'builder' failed to build

Seems like an exists check could solve it for both of us ;)

Just pushed the check I was talking about yesterday @Qqwy , please check if it still works on mac now :p


organization/space: added created and updated dates to summary

Besides adding those info there was a slightly change in the data
display itself. Instead of a single list of attributes we splitted
that into two columns in order to utilize better the white space.
Signed-off-by: Vítor Avelino<EMAIL_ADDRESS>Fixes #3452

I've seen the usage of the app-metadata and app-metadata__two-cols being used around. Maybe it's time to extract those into <app-metadata> and <app-metadata-col>? What do you think?


Tenancy on sub-domains

I've written a Laravel route filter that bases the tenancy on the sub-domain.
public function filter(Route $route, Request $request)
{
    $subdomain = null;
    $host = $request->getHost();
    $parts = explode('.', $host);

    if (count($parts) > 2) {
        $subdomain = $parts[0];

        // Set the tenant scope.
        if ($tenant = $this->partner->findBySlug($subdomain, $host)) {
            TenantScopeFacade::addTenant('partner_id', $tenant->id);
        } else {
            // TODO: No tenant was found, so we need to return an error.
            TenantScopeFacade::addTenant('partner_id', 0);
        }
    }
}

The problem is that before this code can even be called on my routes, the package is telling me off:
AuraIsHere\LaravelMultiTenant\TenantScope: tenant column "partner_id" NOT found in tenants scope "[]"

Even if I modify the TenantScope.php file to disable it immediately, I get this error.
What can I do to avoid this?

CC @HipsterJazzbo.

It's difficult for me to diagnose this sort of thing without more code, but in general, no scoping should happen until the first time addTenant() is called. Is that what's happening?

It seems to be.
Before the filter is even called my app blows up with the code above.

I wonder if it could be something to do with missing $tenantColumns on a model? Do you have a situation where $model->tenantColumns is empty as well as default_tenant_columns in the config?

I set the config and have the column in the table ready. That's it?
Sent from my iPhone

On 26 Jan 2015, at 20:51, Caleb Fidecaro<EMAIL_ADDRESS>wrote:
I wonder if it could be something to do with missing $tenantColumns on a model? Do you have a situation where $model->tenantColumns is empty as well as default_tenant_columns in the config?
—
Reply to this email directly or view it on GitHub.

My guess is that it'll be the global scope attempting to apply before any tenants are added.
This is sort of (not really) a feature, in that I thought it'd be better to have a failure in this case than silently not scope anything.
You could avoid this issue (I think) by checking count($this->getTenants()) in apply(), but it'd have the side effect of failing silently to scope in an instance where no tenants were added.
Not sure what the best fix is for that. Thoughts?

Further thought: Is it possible that this (apply being called when no tenants are set) could be the cause of #22 as well?

I'd say fail silently. The package shouldn't make itself the end of everything, but rather a helper to tenancy applications. At least, that's how I'd do it.
Regarding 22, it quite possibly could be the issue, at least in it makes sense.

I'm using this package and also tenancy on subdomains with no problems now, but I remember running into this issue (or at least similar) at start. I will look at which I did to fix this.

@jbrooksuk (Back from lunch) Could you have a go, replacing apply() with this:
public function apply(Builder $builder)
{
	if (! $this->enabled) return;

	$model = $builder->getModel();

	if (count($this->getTenants()) > 0)
	{
		// Use whereRaw instead of where to avoid issues with bindings when removing
		foreach ($this->getModelTenants($model) as $tenantColumn => $tenantId)
		{
			$builder->whereRaw($model->getTenantWhereClause($tenantColumn, $tenantId));
		}
	}
}

and see if it behaves correctly?

I'd appreciate if someone would test with this commit ("aura-is-here/laravel-multi-tenant": "dev-master") and report back :)

I'll be able to test in a couple of hours. 6AM here :)
Sent from my iPhone

On 27 Jan 2015, at 02:32, Caleb Fidecaro<EMAIL_ADDRESS>wrote:
I'd appreciate if someone would test with this commit ("aura-is-here/laravel-multi-tenant": "dev-master") and report back :)
—
Reply to this email directly or view it on GitHub.

Ha, fair enough.
On Tue, Jan 27, 2015 at 7:03 PM, James Brooks<EMAIL_ADDRESS>wrote:

I'll be able to test in a couple of hours. 6AM here :)
Sent from my iPhone

On 27 Jan 2015, at 02:32, Caleb Fidecaro<EMAIL_ADDRESS>wrote:
I'd appreciate if someone would test with this commit ("aura-is-here/laravel-multi-tenant": "dev-master") and report back :)
—
Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHub:
https://github.com/AuraEQ/laravel-multi-tenant/issues/29#issuecomment-71594209

Giving this a go now :)

Darn it. I need the facade stuff changed too. I'll make a PR now.


useModal调用 vue-final-modal 隔了一个组件后，useModal的emit就绑定不上了，现在用useAttrs来调用

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context
[home.vue]

vs-final-modal.vue

search-modal.vue

search-modal.vue

vs-final-modal.vue

结果会注册成

vs-final-modal.vue

结果会注册成


Use string templates instead of format function

@SuperChange001 Please take quick look at the new expand_template function in the elasticai.creator.vhdl.templates.utils module, because it will change very little how to write the placeholders in VHDL templates and how to fill them in the component class.