Add tests to improve code coverage of viz module 🧪

This issue has been tagged for a bounty during unitaryHACK.
Tasks

Create a new set of unit tests (potentially in test_viz.py) that covers all possible configuration options of the functions on the viz module. To see the current coverage of the module check codecov.

Explanation
The viz utility module contains helper functions to draw various graphs and generate plots using Matplotlib. This module provides several ways to personalize and configure the resulting figures via the use of function parameters.
The complete set of possible configurations has not been added to the FlamingPy test suite.
Requirements

Instead of using image comparison to evaluate the output of the functions of the module I would instead recommend using mocking to mock matplotlib's methods and check that appropriate calls with appropriate arguments are passed to those (mocked) methods.
The implementation of this test should cover >99% of the viz module.

We can archive this till we work on different backends or next HACK competitions.


Update pull_request_template.md

Issue template for worktrolly has been updated
Functionality:
<-- please enter the functionality introduction -->
Solution:
<-- please enter brief solution -->
Risk level:

[ ] high
[ ] medium
[ ] low

How to test:
<-- please tell us how to test functionality/bug -->

sent by mistake


Update distribution.yaml

Manually opening pull request following failure of bloom-release step with the following errors in logfile:
SSLError: ('The read operation timed out',)
[error] Failed to open pull request: SSLError - ('The read operation timed out',)

For future reference you can ask bloom to retry just opening the PR with the -p option. We highly recommend that so that all the meta data gets recorded here, not just "Update distirbution.yaml"

For future reference you can ask bloom to retry just opening the PR with the -p option. We highly recommend that so that all the meta data gets recorded here, not just "Update distirbution.yaml"

Thank you for the tip, I was unaware of that option. It would be helpful to add something about this in the tutorial http://wiki.ros.org/bloom/Tutorials/FirstTimeRelease#Notifying_the_Build_Farm


Readme shows incorrect outputs(?)

I believe the readme documentation lists the improper output of the cloud metadata plugin
Rationale
Shows:

An array containing:

cloud/instance-type: echo input instance-type
cloud/vendor: echo input vendor
physical-processor: physical processor used in the given instance
vcpus-allocated: number of vCPUs allocated to this instance
vcpus-total: total number of vCPUs available to this instance

Should show:

An array containing:

cpu/thermal-design-power: [your chosen description]
memory-available: [your chosen description]
physical-processor: physical processor used in the given instance
vcpus-allocated: number of vCPUs allocated to this instance
vcpus-total: total number of vCPUs available to this instance

based on what I see in this file
'vcpus-allocated': parseInt(instance['cpu-cores-utilized']),
'vcpus-total': parseInt(instance['cpu-cores-available']),
'memory-available': parseInt(instance['memory-available']),
'physical-processor': instance['cpu-model-name'],
'cpu/thermal-design-power': parseFloat(instance['cpu-tdp']),

Yes, with the following inputs:
- timestamp: 2023-07-06T00:01
   duration: 10
  cloud/vendor: aws
  cloud/instance-type: m5n.large

the plugin yields the following outputs:
            "timestamp": "2023-07-06T00:01",
            "duration": 10,
            "cpu/utilization": 80,
            "cpu/thermal-design-power": 210,
            "cloud/vendor": "aws",
            "cloud/instance-type": "m5n.large",
            "cpu/energy": 0.00025568089430894314,
            "vcpus-allocated": 2,
            "vcpus-total": 96,
            "memory-available": 8,
            "physical-processor": "Intel® Xeon® Platinum 8259CL"

I'll update the docs page.

Closing as complete


Fix for alpha value out of range

Do you have a specific scenario where alpha in this methods is outside the 0..1 range?

Not really. These pull requests come from 8 years of experience and testing with Substance+Flamingo 😄
I've seen this error and fixed it. This guy also made a lot of fixes including this one:
https://github.com/Icy-imaging/Icy-Insubstantial/commit/b1f6c8d3cb0b8f81e1806af738696a13f693cae0
https://github.com/Icy-imaging/Icy-Insubstantial/commit/07a58b0e26418f41fb23936dccf5576098ca0d1a

The first fix doesn't seem to be right. It should be Math.min there.
As for doing it defensively, my strong preference is to do that only when it's actually shown to happen. Otherwise you're treating the symptom and not the core - which would be somewhere in Trident. And you can go really far with treating the symptoms, wrapping every method call to catch every kind of exception :)

The first fix doesn't seem to be right. It should be Math.min there.
Yes, my version is better :) (I must say I was using Math.max(0.0f, Math.min(1.0f, alpha)); in my code)

I saw you followed a similar approach on LafWidgetUtilities.getAlphaComposite(). I can't tell you the root cause, what I could tell you is that I didn't have any other error regarding the alpha.

That code in LafWidgetUtilities is indeed there. It's been a while, so I can't really say why it's there.
Having said that, what do you mean by "any other error"? Does this mean that you are seeing alpha values outside the 0..1 range without this fix in SubstanceImageCreator? If not, then I won't be making this change.

What I meant is that without the fix I was having the "alpha value out of range" exception (sporadically), but after controlling the alpha range (by overriding your class in my project) I didn't have any other error regarding the alpha.

Is that under the latest 7.0?

Is that under the latest 7.0?

No, this comes from previous version, I just found out about Substance back in the game today 👍
Here is another user with the same issue: https://github.com/Insubstantial/insubstantial/issues/138
He posted the exception:
java.lang.IllegalArgumentException: alpha value out of range
    at java.awt.AlphaComposite.<init>(AlphaComposite.java:618)
    at java.awt.AlphaComposite.getInstance(AlphaComposite.java:683)
    at org.pushingpixels.substance.internal.utils.SubstanceImageCreator.getRadioButton(SubstanceImageCreator.java:880)
    at org.pushingpixels.substance.internal.ui.SubstanceRadioButtonUI.getIcon(SubstanceRadioButtonUI.java:206)
    at org.pushingpixels.substance.internal.ui.SubstanceRadioButtonUI.getDefaultIcon(SubstanceRadioButtonUI.java:311)
    at org.pushingpixels.substance.internal.ui.SubstanceRadioButtonUI.paint(SubstanceRadioButtonUI.java:346)
    at javax.swing.plaf.ComponentUI.update(ComponentUI.java:161)
    at org.pushingpixels.substance.internal.ui.SubstanceRadioButtonUI.__org__pushingpixels__substance__internal__ui__SubstanceRadioButtonUI__update(SubstanceRadioButtonUI.java)
    at org.pushingpixels.substance.internal.ui.SubstanceRadioButtonUI.update(SubstanceRadioButtonUI.java)
    at javax.swing.JComponent.paintComponent(JComponent.java:777)
    at javax.swing.JComponent.paint(JComponent.java:1053)
    at javax.swing.JComponent.paintToOffscreen(JComponent.java:5223)
    at javax.swing.RepaintManager$PaintManager.paintDoubleBuffered(RepaintManager.java:1572)
    at javax.swing.RepaintManager$PaintManager.paint(RepaintManager.java:1495)
    at javax.swing.RepaintManager.paint(RepaintManager.java:1265)
    at javax.swing.JComponent._paintImmediately(JComponent.java:5171)

As I stated on Insubstantial bug 138, I saw this bug a few times, and I fixed it in my fork by adding a check to make sure the value was between 0.0 and 1.0.  I never had a reliable way to trigger the bug, and I have never seen the problem again since my fix.

I must say that I didn't really like putting in that fix without understanding why it was happening, but since I couldn't reproduce it reliably and don't understand the code sufficiently, I didn't see any other option.

In theory even with floating arithmetic imprecisions you should never end up with a product of positive numbers being less than zero, and with a product of <= 1 numbers being more than one.
For this one I'm taking a more pragmatic stance and doing range clamp. This is the same as in the above-mentioned alpha composite method, as well as in the color interpolation code in SubstanceColorUtilities (used to be direct linear interpolation of each color channel, and is now using gamma space).

"In theory ..."  I wonder whether the bugs could be related to threading.  Maybe non-atomic operations are happening with them on Swing and non-Swing threads.
But, whatever, I'm happy with the pragmatic "clamp" approach which has worked well for me for several years.


finetune time travel handling

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

23 of 23 (100.0%)  changed or added relevant lines in 6 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.01%) to 99.666%

Files with Coverage Reduction
New Missed Lines
%

src/modules/olMap/handler/draw/OlDrawHandler.js
1
98.59%

Totals

Change from base Build<PHONE_NUMBER>2:
0.01%

Covered Lines:
12969

Relevant Lines:
12971

💛  - Coveralls


fix cli: make rpc port Option again

Follow-up on https://github.com/paritytech/substrate/pull/13384
It changed the rpc_port from a  Option<u16> -> u16 which broke overriding it in cumulus (see https://github.com/paritytech/cumulus/issues/2529) and the default value was used instead
polkadot companion: https://github.com/paritytech/polkadot/pull/7192
cumulus companion: https://github.com/paritytech/cumulus/pull/2539

bot merge


crate internal 10 k limit cuts of graph

at the moment we hit the crate internal 10 k limit when want to visualize a table grouping by a field and going for seconds over a longer time span like an hour or something.
the graph then stops at one point.
do you have an idea what we can do about this? e.g.:

run several queries to complete the graph.
automatically change the resolution when we know the cardinality of the group by column.

The main problem is that Grafana don't knows how many points will be returned. So we can check it only after handling request.

I was thinking on the resolution. E.g. if we'd know we got a timespan from 11 to 17:30 which are 6 hours 30 minutes or ~ 23.000 seconds. it wouldn't make sense to get the second results and therefor it might switch to the minute resolution.
might this be a way to go?

You can set Auto time interval which works similarly.

@Node0 we're discussing arbitrary group by intervals. as intermediate workaround, if the grafana query overrides the default limit of 10k by specifying LIMIT 20000 - would this help?

This issue appears due database can returns different sets of series. For example, you request CPU load for all servers in group database for the last two hours and use minute resolution. This group can contains, for instance, 5 servers or 100 servers. In first case database returns 60 * 2 * 5 = 600 points and 60 * 2 * 100 = 12000 points. And we cannot predict number of series to use corresponding resolution.

Hi @jodok!
As an intermediary workaround, I'd say providing a field in the datasource plugin configuration view
where the user can configure the value specified e.g. 10k (default if no value entered), 20k, etc
@alexanderzobnin , I was thinking that a count (*) aggregation statement executed before the main statement-series (I say "statement series" as the count aggregation results would then be able to provide the number of rows necessary to determine how many iterations (each one with a different offset) of the original query statements to run).
Without that count aggregation query, there's no way to know how many rows will need to be fetched. So it becomes essential to first run a modified version of the original query whereby the select clause is replaced by the count(*) clause.
So it's a 'multi-pass' solution, first a count aggregation, which will provide the number of rows necessary to then loop through and request N number of versions of the original query each with an incremented offset (incremented by 10k rows each time).
This solution will handle any number of rows, it's not the fastest solution, however it is stable even when dealing with huge datasets.
To be honest speed in crate is a function of distributed compute, so the speed of the cluster can be increased by scaling. From a data acquisition perspective (from the Grafana side) it seems appropriate to adopt the most reliable way to get ALL the data for a given analytics query, and let the question of response time be left to the configuration of the crate installation (cluster size, replica count, shard count, etc).
Does this approach make sense @alexanderzobnin ?

@Node0 yes, I think it's stable solution, so we can try this way.

@Node0 i agree - that's a really nice workaround right now. @alexanderzobnin let's do it that way and let's get out the beta version of the datasource on grafana.net as soon as possible.

@alexanderzobnin did you work on this issue?

@joemoe I've added workaround for this issue, so you can set Group By Time Interval to Auto in query editor and check result.

Excellent, I'll attempt to test this.


Microsoft.Network/privateEndpoints

Describe the noise
Resource type (i.e. Microsoft.Storage/storageAccounts)
Microsoft.Network/privateEndpoints
apiVersion (i.e. 2019-04-01)
2019-11-01
2020-04-01
Client (PowerShell, Azure CLI, or API)
PowerShell
Relevant ARM Template code (we only need the resource object for the above resourceType and apiVersion, but if it's easier you can include the entire template
Expected response (i.e. "I expected no noise since the template has not been modified since the resources were deployed)
No change in privateLinkServiceConnections property
Current (noisy) response (either include a screenshot of the what-if output, or copy/paste the text)
 ~ Microsoft.Network/privateEndpoints/production-keyVault [2019-11-01]
    ~ properties.privateLinkServiceConnections: [
      ~ 0:

        - id: "/subscriptions/<subscription id>/resourceGroups/test-vnet-rg-1/providers/Microsoft.Network/privateEndpoints/production-keyVault/privateLinkServiceConnections/serviceConnection-production-keyVault"

      ]

  ~ Microsoft.Network/privateEndpoints/production-keyVault [2020-04-01]
    - properties.customDnsConfigs: [
        0:

          fqdn: "lz-kv-prd.vault.azure.net"
          ipAddresses: [
            0: "<IP_ADDRESS>"
          ]

      ]
    ~ properties.privateLinkServiceConnections: [
      ~ 0:

        - id: "/subscriptions/<subscription id>/resourceGroups/test-vnet-rg-1/providers/Microsoft.Network/privateEndpoints/production-keyVault/privateLinkServiceConnections/serviceConnection-production-keyVault"

      ]

Additional context
Add any other context about the problem here.

[w25?]

This fix should be fully deployed. Let us know if you are still seeing this noise.


Refs #21442 -- Added content-type aware request.data property.

Hey @adamchainz — I broke ground on the request.data PR for ticket-21442.

[x] Currently just adds the request.data property, aliases request.POST back to that, and adds a couple of new tests for the behaviour.

Next up for me:

[ ] Add tests for application/json handling, and make that work.
[ ] Do the same for the multipart parser.

Then there's a big tidy-up and rename, and I need to get some thoughts on the changes you suggested for the body parsing errors. As I've blocked it out (thus far, which isn't far) any change would propagate back to POST, but there's a space there for a try/except.
I'm opening early to see if I could get your view, and if you wanted to input on the other request attributes from your #13764?
I think, and I think @apollo13 thinks, that we need to do it in one batch — it would be weird to introduce request.data in one release but not request.query_params &co in the same one. (To be clear: If you wanted to input, that would be very welcome! 🎁)
Just from a committing POV, as I start to eyeball it though, there's no obvious natural boundaries between changes: everything starts to leak into a big do-it-all at once. I thinking by discussing it with you, we can perhaps find some boundaries between changes that make sense. (Once it's laid down, it'll likely be clearer.)
No urgency here: I'm planning on chipping away at it over the next couple of weeks, and the feature freeze is not until Jan 16th. (Worse case is it goes into 5.0. 😜)
Thanks 🦄

If request.data and request.POST are not staying semantically same I am wondering if aliasing request.POST to request.data makes sense. Can't we just leave request.POST with the old behavior and (really) slowly deprecate it instead of trying to keep it backwards compatible?

Given other things on the agenda I'm going to just state now that I'm targeting this for 5.0. I'm in no mood for a stressful Christmas 🎄😜

I'm going to move this to my fork to continue work. I'll reopen when it's further along.


Add Robin Lashof-Regas to contributors list

Hi  @RLashofRegas, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

@Roshanjossey Hi, thanks for making this project, it was really helpful. The one thing I'd say is that it's not quite clear from the tutorial what each of the terminal commands is actually doing. For example, what is the difference between git clone and git checkout? Overall a great tutorial though, thanks! :)

I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://goo.gl/PM1Jdh


Remove hardcoded success message from Traffic Portal when creating/updating and deleting a delivery service

This PR removes hardcoded success message from Traffic Portal when creating/updating and deleting a delivery service.
It also updates associated integration tests that check for validationMessage.

Which Traffic Control components are affected by this PR?

Traffic Portal

What is the best way to verify this PR?

Create, Update and Delete a DS using curl and TP UI and ensure that the success message matches on both fronts.
If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

[x] This PR has tests
[ ] This PR has documentation
[ ] This PR has a CHANGELOG.md entry
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Looks like a string in a test file needs to be updated to pass the unit tests:
--- FAIL: TestDeleteHandler (0.00s)
    shared_handlers_test.go:347: Expected body {"alerts":[{"text":"tester was deleted.","level":"success"}]}
         got {"alerts":[{"text":"tester [ testerInstance:1 ] was deleted.","level":"success"}]}


Capture image after edge not detection -only blue line display

as per image , only image with blue line display but cant  set in edge (blue circle) .

@nileshdhola  have you identified the issue

@nileshdhola Without black baground object edges are not coming properly it takes the edges position as whole image size (width*height)
how can i resolve it??

@nileshdhola thanks for the answer. solved the issue.


Fix disconnect on currently connecting cluster

Signed-off-by: Sebastian Malton<EMAIL_ADDRESS>This PR fixes the following bugs:

If you use the hotbar to disconnect from a cluster while it is connecting. It now correctly navigates you back to the catalog
If connecting is stuck and you navigate away and back to the same cluster, the cluster is now forced when activating

If you use the hotbar to disconnect from a cluster while it is connecting. It now correctly navigates you back to the catalog

how do you initiate disconnect while it is connecting? The hotbar context menu offers Connect

The hotbar context menu offers Connect

Interesting... that must be a bug because it should offer disconnect let me see if I can reproduce/do about it.

how do you initiate disconnect while it is connecting? The hotbar context menu offers Connect

It is a race condition, you need to keep opening and closing the menu. I was able to reproduce this on master on the second attempt.

Might be easier to just not allow disconnect while it is connecting? (show Connect greyed out in the context menu?)

Might be easier to just not allow disconnect while it is connecting? (show Connect greyed out in the context menu?)

No I think it is good to support this because then there is no other way (besides starting the entire app) for retrying the connection.

Well, a connection attempt should timeout after a reasonable time, so that it can be retried

Well, a connection attempt should timeout after a reasonable time, so that it can be retried

Fair, but what if something else needs to be recomputed and then written to disk?

Furthermore, if a connection is just failing. There is no other way to stop lens from continuing to try and connect.

I'm seeing some strange behaviour, when I disconnect while it is connecting I find that the cluster is not always actually disconnected. kubectl proxy process is still running, as are any port-forwards:

Is that on dev or prod? I was not able to see this on dev...

Maybe you need to have port-forwards active?

Will try with that then

@jim-docker I was unable to reproduce that issue using make dev. I had port forwards active too.

@jim-docker I was unable to reproduce that issue using make dev. I had port forwards active too.

Ok I'll see if I can reproduce again

I still see issues:
https://user-images.githubusercontent.com/40840436/153481296-e0439a30-e788-4cd8-a7d9-d1de075e30b7.mov

Will try again to fix this after the DI work (and removing of iframes) is done


Accidental delete, not sure what happened in this commit/pr

https://github.com/AY2021S2-CS2103T-T11-4/tp/commit/a24b5f2bfda99f1d12ec57d33ac7b4a21158cac4#diff-37166fa670f1691fbeea29e77bd8279f25f455ac01f6e5d6e1e5f9ae4c51d3ca

fixed


[DO NOT MERGE] this PR is only for testing the CI

Close it, because it was only a test case for PR #3


fix: bump version to 1.3.1

Bump version from 1.3.0 to 1.3.1
#minor

Coverage remained the same at 54.901% when pulling 89bf67151ed85428efd5c9d2d4d8f4171177b117 on donglei/1.3.1 into c7a932266b4be0a099a1cedd70573d4334927d43 on main.

Coverage remained the same at 54.901% when pulling 89bf67151ed85428efd5c9d2d4d8f4171177b117 on donglei/1.3.1 into c7a932266b4be0a099a1cedd70573d4334927d43 on main.


Add aerialways to roads layer.

Adds aerialways to the roads query. This means altering the roads level, again. The migration I used was to update the functions, then run:
DROP TRIGGER mz_trigger_line ON planet_osm_line;

UPDATE planet_osm_line SET
  mz_road_level = mz_calculate_road_level(highway, railway, aeroway, route, service, aerialway, way)
  WHERE
    aerialway IS NOT NULL;

CREATE OR REPLACE FUNCTION mz_trigger_function_line()
RETURNS TRIGGER AS $$
BEGIN
    NEW.mz_road_level := mz_calculate_road_level(NEW.highway, NEW.railway, NEW.aeroway, NEW.route, NEW.service, NEW.aerialway, NEW.way);
    NEW.mz_transit_level := mz_calculate_transit_level(NEW.route);
    RETURN NEW;
END;
$$ LANGUAGE plpgsql VOLATILE;

CREATE TRIGGER mz_trigger_line BEFORE INSERT OR UPDATE ON planet_osm_line FOR EACH ROW EXECUTE PROCEDURE mz_trigger_function_line();

DROP FUNCTION mz_calculate_road_level(text, text, text, text, text, geometry);

Requires mapzen/TileStache/pull/82. Connects to #189.
@rmarianski could you review, please?

:+1:


[Event Request] codeunit 415 "Release Purchase Document" - OnAfterPerformManualCheckAndRelease

Please add a new Publisher Call OnAfterPerformManualCheckAndRelease in Fct. PerformManualCheckAndRelease of codeunit 415 "Release Purchase Document"
Add Publisher Call in Fct. PerformManualCheckAndRelease:
        IsHandled := false;
        OnBeforePerformManualRelease(PurchHeader, PreviewMode, IsHandled);
        if IsHandled then
            exit;

        CODEUNIT.Run(CODEUNIT::"Release Purchase Document", PurchHeader);

+      OnAfterPerformManualCheckAndRelease(PurchHeader);
    end;

Add new Publisher:
+   [IntegrationEvent(false, false)]
+   local procedure OnAfterPerformManualCheckAndRelease(var PurchHeader: Record "Purchase Header")
+   begin
+   end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: .


ac-go-live

Docs Build status updates of commit cc9d296:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/design/personal-apps.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/design/understand-use-cases.md
:white_check_mark:Succeeded
View

msteams-platform/includes/landing-page.html
:white_check_mark:Succeeded
View

msteams-platform/samples/app-templates.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/how-to/authentication/auth-silent-aad.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Documentation Questions

I've been looking at the story documentation which does a great job of explaining what the JS components are (I'm going to have to remember this doc framework for other projects)-but I'm no seeing anything on how to configure Sampo to fit specific use cases. For example, I think that to customize Sampo, I should be modifying the json files in src/client/configs/, but this isn't mentioned anywhere in the docs (that I've seen). I'm also a little confused about how much of the javascript in the src/client/components I should be modifying. Since this is the central part of documentation for users, I'm assuming that most of the customization work will be in this area-but the code looks fairly general which makes me think twice. From the main Sampo paper it looks like I can create facets from the more general facet components?
In short, I may be looking at the wrong documentation. Are there any docs that go over the architecture of how the config files relate to the user interface along with details on where the SPARQL queries should go?  I'll also note that due to the size of the graph (>5 billion triples) I'm specifically looking at the ClientFS rather than ServerFS.
edit: After some playing around, it looks like I do create facets based on the components, and then link them to text in the translations files. The SPARQL query gets linked through the ID and the propertiesQueryBlock in the perspective JSON file.

Thanks for your interest! I heavily refactored the Sampo-UI codebase last year, and documenting all that work is still on the todo list. I'll write some points here, maybe these can be expanded into proper documentation text later. The main idea now is that new portals could created by editing only the following files:

main JSON config files in src/configs/<PORTAL_ID>/
translations in src/client/translations/<PORTAL_ID>/
SPARQL queries in src/server/sparql/<PORTAL_ID>/

So to use the current functionalities, there would be no need to touch any actual JavaScript files. Still, there are some portal specifc JS files usually in src/client/componets/perspectives/<PORTAL_ID>/
The example portal ID is sampo, so one way of creating a new portal is that you re-create those 4 folders with a new portal ID. Then all work would be carried out by modifying the portal specific JSON configs and SPARQL queries.
A major caveat is that we have been using only Apache Jena Fuseki as a triplestore. This means that especially code and queries related full text search works only with the Jena Full Text Search index. Another caveat is that the whole Sampo-UI codebase is a experimental product of various research projects, so using it for implementing any production level portals is definetely not recommended. :sweat_smile:

About the faceted search implementations (ClientFS and ServerFS): ClientFS code was developed in a research project in 2018-2019, and it has not been developed further since that. All recent work has been related to ServerFS in recent years.
In ServerFS, which is the "purist" way of doing faceted search over RDF graphs, the main thing to consider is that how many instances (meaning possible search results) there are in the RDFS class that you are targeting. There may be millions or billions triples in the graph, but you have to split those into meaningful classes, which then act as a base for perspectives in a Sampo-UI based portal.  In our experiments, the maximum number of instances in one RDFS class has been around 1 million instances. If you go well over that, this sort of faceted search based on SPARQL queries becomes too much to handle for the triplestore. We are running our Fusekis on virtual machines with 128GB RAM (multiple Fusekis on the same virtual machine).

Wow thank you so much for all of this information! I totally understand the WIP documentation and appreciate the overview of how to customize an instance. Given that we're doing text search with GraphDB's Elasticsearch connector, which is interacted with through SPARQL queries, we might be able to work around the text search-but I'll keep an eye out.
There's a good chance that I see if I can use this as a frontend for gnis-ld.org too (it's also backed with GraphDB). Thanks a million for this great software!


Add vm security group operations

Needed by https://github.com/ManageIQ/manageiq-providers-openstack/pull/79
Tested from rails console.

As far as I can tell, the hash items are aligned.

Looks good to me!

@durandom, can you review?
I'm in mobile and it won't let me select a reviewer.


feat(project): add support for offline mode

Add basic support for offline mode (no pagination, no search, no sort).

@jeremyvergnas Pager works with offline data, right? It just needs the length (which we have). Also, pretty sure we could add sort. It's not a complex method I think.

We can make pagination and sorting work with offline mode too indeed. This PR was just the basics for offline mode. Should I continue on it so it supports pagination and sorting?

@jeremyvergnas For the basics this is fine. If you could create two tickets for the pagination and sorting, I can merge this.

@RWOverdijk issues created


hello noob, you not fixed Advanced Drill in IC2 3x3 mode, lol kek, destroying all blocks and bedrock

Checks

[X] I checked for duplicate issues and there were none found.
[X] I have made sure this program is the source of the problem.

Carbon Config Lib Version
hello noob, you not fixed Advanced Drill in IC2 3x3 mode, lol kek, destroying all blocks and bedrock
Java Version
hello noob, you not fixed Advanced Drill in IC2 3x3 mode, lol kek, destroying all blocks and bedrock
The Problem
hello noob, you not fixed Advanced Drill in IC2 3x3 mode, lol kek, destroying all blocks and bedrock
Relevant logs
No response

You banned me and my friends because your mod is a masterpiece that has no bugs and you deny their appearance in your mod, even when you fix the mod you break it again.


Set SO_NOSIGPIPE on all sockets on Apple systems.

Previously this option was only set for UDP sockets but is equally important for TCP. Like libstd this PR enables the option on all sockets if compiled for Apple systems.

Thanks @twittner.


Update meta.yaml

I created a new release which will hopefully fix the conda recipe build bugs. The main issue was the use of os.environ['HOME'], which does not work on all OSes. Also removed two unnecessary module dependencies.

Thanks @awellpott! You will also need to update the sha256 value in the meta.yaml file -- it is used in the build process for checking the downloaded tarball is what it says it is and as it currently hasn't been updated the build will fail.
Unfortunately there's no automated way to update the sha256, so the best way is to download a copy of the source tarball and run the sha256sum command on the downloaded tarball to generate an updated value for the meta.yaml file.

Superseded by #2.


Does not complete for git pull --prune and git --version

System Details

posh-git version/path: 1.0.0  ~\Documents\WindowsPowerShell\Modules\posh-git\1.0.0
PowerShell version: 5.1.19041.1151
git version 2.33.0.windows.2
OS: Microsoft Windows NT 10.0.19042.0

Issue Description
Completion works well for branches, common commands like pull/push/etc., but something isn't working.
Type either of the following, and press tab:
git --<cursor>
git pull --pru<cursor>

Expect the first to be completed with something, e.g. --version, and the other to be completed with --prune.
Actually nothing happens.

git --v<cursor> is not autocompleted either.

Thanks for the report! Looks like prune is indeed missing:
https://github.com/dahlbyk/posh-git/blob/396d726b69ceff6897897987249593e2034885e3/src/GitParamTabExpansion.ps1#L69
I don't know if we've ever tried to complete generic git options, so that will be a larger change.


Prepare Search October 2023 Beta Release

Prepare Search Beta release for October 2023

API change check
API changes are not detected in this pull request.


Kubeconfig context chooser, UI tests

Description
Changes proposed in this pull request:

Refactor kk upload, add context chooser

To create kubeconfig with multiple contexts:

export KUBECONFIG=<path_to_kk_1>:<path_to_kk_2>...<path_to_kk_n>, n ∈ ℕ
kc cluster view --flatten > kubeconfig--combined.yaml

Add UI tests for

...?

Related issue(s)

/test pre-busola-ui-test

/test pre-busola-ui-test


Collection Full scan despite of filter condition

my environment running ArangoDB
I'm using the latest ArangoDB of the respective release series:

[x] 3.2

Mode:

[x] Single-Server

Storage-Engine:

[x] rocksdb

On this operating system:

[x] Windows, version:

this is an AQL-related issue:
I'm issuing AQL via:

[x] web interface with this browser:     running on this OS:
[x] arangosh

I have a collection named broadcast. It has index like below
db.broadcast.ensureIndex({type : "skiplist", fields : ["reg_title"], deduplicate:true})
broadcast collection has 24,518 documents.
create index result is below
{
  "deduplicate" : true,
  "fields" : ["reg_title"],
  "id" : "broadcast/8597935",
  "isNewlyCreated" : true,
  "selectivityEstimate" : 0.8486480886770952,
  "sparse" : false,
  "type" : "skiplist",
  "unique" : false,
  "code" : 201
}

here is my AQL. so simple
FOR b IN broadcast
  FILTER NOT_NULL(b.reg_title)
  return b

my explain is below
Execution plan:
 Id   NodeType                   Est.   Comment
  1   SingletonNode                 1   * ROOT
  2   EnumerateCollectionNode   24518     - FOR b IN broadcast   /* full collection scan */
  3   CalculationNode           24518       - LET #1 = (b.`reg_title` != null)   /* simple expression */   /* collections used: b : broadcast */
  4   FilterNode                24518       - FILTER #1
  5   ReturnNode                24518       - RETURN b

Indexes used:
 none

Optimization rules applied:
 none

despite of has index, explain result show me full scan plan. why?

AFAIK no indexes are being used for operator !=.
Turning the filter condition of the query into b.reg_title > null should fix this.

Hi @HackingJ,
Just a quick follow-up. Was latest message from @jsteemann useful? Have you had a chance to try the proposed workaround?
Many thanks,

@jsteemann If there's a skiplist index, couldn't != null automatically be optimized to > null?
Same appears to be possible for a hash index, although I'm surprised that a hash index is suitable for a range check:
Indexes used:
By  Type  Collection  Unique  Sparse Selectivity  Fields     Ranges
 7  hash  Characters  false   true       68.75 %  [ `age` ]  ((c.`age` > null) && (c.`age` < 13))

@Simran-B : != null could be converted to > null with the current datatypes.
For a hash index, this conversion could also be done, but would be useless for MMFiles. It would however work for RocksDB where we can exploit the sortedness of the keyspace even for the hash index.


[HUDI-4412] Multiple writers NPE when Insert_overwrite

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
There are two minor issues fixed here;

When the insert_overwrite operation is performed, the clusteringPlan in the requestedReplaceMetadata will be null,
Calling getFileIdsFromRequestedReplaceMetadata will have a null pointer

When insert_overwrite operation, inflightCommitMetadata!=null, getOperationType should be obtained from getHoodieInflightReplaceMetadata, the original code will have a null pointer

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

cc @fengjian428 Can you also help to review and verify this PR?

@codope  please take it, thanks

@hudi-bot run azure

@hudi-bot run azure

@hudi-bot run azure

@hudi-bot run azure

cc @fengjian428 Can you also help to review and verify this PR?

will test this tmr or on Monday

22/07/30 23:35:16 INFO ApplicationMaster: Unregistering ApplicationMaster with FAILED (diag message: User class threw exception: java.lang.NullPointerException
    at org.apache.hudi.client.transaction.ConcurrentOperation.getFileIdsFromRequestedReplaceMetadata(ConcurrentOperation.java:162)

this PR can fix the above NPE bug, but I got another error after some successful commit
Caused by: org.apache.hadoop.ipc.RemoteException(java.io.FileNotFoundException): File does not exist: /xxxx/.hoodie/20220731151951392.replacecommit.requested
I will keep Investigate the root cause, should not be relevant

@hudi-bot run azure

@hudi-bot run azure

22/07/30 23:35:16 INFO ApplicationMaster: Unregistering ApplicationMaster with FAILED (diag message: User class threw exception: java.lang.NullPointerException
    at org.apache.hudi.client.transaction.ConcurrentOperation.getFileIdsFromRequestedReplaceMetadata(ConcurrentOperation.java:162)

this PR can fix the above NPE bug, but I got another error after some successful commit Caused by: org.apache.hadoop.ipc.RemoteException(java.io.FileNotFoundException): File does not exist: /xxxx/.hoodie/20220731151951392.replacecommit.requested
I will keep Investigate the root cause, should not be relevant

I don't think the above issue is due to this patch as it does not attempt to change the timeline in any way. At worst, it can abort a transaction but it won't remove the requested replacecommit.


[$250] Rules - Expense rules are not empty by default

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?: Yes
Reproducible in production?: Yes
Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/424689
Issue reported by: Applause - Internal team
Action Performed:

As the admin of a collect workspace - Navigate to "More Features"
Enable Rules
On the paywall - Click upgrade to enable the Control plan in the policy
Navigate to the Rules page in workspace edito

Expected Result:
When rules are first enabled no default will be set for Require receipt amount, Max expense amount, and Max expense age (days). As Described in the design doc in the "Individual expense rules" in "UI Additions & Changes Figma".
Actual Result:
Require receipt amount, Max expense amount, and Max expense age (days) have default values.
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub
CC @JmillsExpensify @marcaaron - I think this should be/should have been implemented in the following issue https://github.com/Expensify/App/issues/47013
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021834670232070295133
Upwork Job ID:<PHONE_NUMBER>070295133
Last Price Increase: 2024-09-13
Automatic offers:

suneox | Reviewer | 103951620
CyberAndrii | Contributor | 103951623

Issue OwnerCurrent Issue Owner: @suneox

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx

Proposal
Please re-state the problem that we are trying to solve in this issue.
Expense rules are not empty by default
What is the root cause of that problem?
We set default values when a workspace is being upgraded
https://github.com/Expensify/App/blob/0e9f918425fb6c4a742516ea1aaa02a68a19527b/src/libs/actions/Policy/Policy.ts#L3413-L3415
What changes do you think we should make in order to solve the problem?
Remove the 3 lines mentioned above. Additionally remove DEFAULT_MAX_EXPENSE_AGE, DEFAULT_MAX_EXPENSE_AMOUNT, and DEFAULT_MAX_AMOUNT_NO_RECEIPT from the CONST
file as they will be no longer used.

@marcaaron should we keep this internal as part of the on-going implementation or handle externally?

Posted in Slack.

I think the solution proposed above will work so we can make this External. There's no BE changes needed AFAICT. We just need to update these values to the DISABLED_MAX_EXPENSE_VALUE.

Hm, when I went to record videos, my fix worked fine on the desktop app, but then in Safari it didn't. There seems to be a bug that prevents applying onyx data from the BE which tricked me into thinking this is a FE only issue. I managed to reproduce it by creating a workspace while offline. This causes the CreateWorkspace request to wait indefinitely for a response (you can see a loading indicator in devtools), which stalls the update queue.
So this also needs a fix on the backend. Should I still submit a PR?
https://github.com/user-attachments/assets/5d01c8a3-6d3f-42ca-9e19-d65213920f70

@marcaaron  We need the backend to update the response value without the maxExpense... values

then we can apply FE change to update optimisticData without default values

Ah bummer. Ok, I will raise the PR to fix this.

So this also needs a fix on the backend. Should I still submit a PR?

I mean we are still setting the optimistic data incorrectly so yes?

Also just to make sure this is needed...
@JmillsExpensify the doc actually says:

We won’t set a default for Require receipt amount, Max expense amount, and Max expense age (days) when Rules are first enabled.

I'm not sure that was intended to mean "when a user upgrades", but just when they "enable" rules - which is kind of distinct in that you could already be upgraded and enable or disable rules. It also seems like the "upgrade" path has logic to reset these back to defaults cc @youssef-lr who implemented the UpgradeToCorporate.
My question is whether we still want those defaults baked in? I'm seeing that's the existing behavior on OldDot. Which makes me wonder whether we need to do anything here or if we can just close this one out.

Still deciding if we want to do this, but I will make it a Weekly for now. The changes are pretty minor.

I'm gonna make this a monthly and try to get to it when I return from OOO. If we are passionate about it then we can get someone to help sooner.

We’re still waiting to the internal team to make a decision regarding the default value.

Same above

We have both daily and monthly labels here. Let's remove the daily one?

@MelvinBot Not overdue

Same above https://github.com/Expensify/App/issues/48387#issuecomment-2383559786

Not a high priority.

No update yet.

No update yet.

Same above, we’re still waiting to the internal team to make a decision regarding the default value.

@marcaaron if we haven't gotten to this yet, I'm also just fine closing it.

Ok, let's revisit this one later.


Expose database port in Dockerfile

I would like to use this image as service in GitLab CI, but for this to work the image has to expose the ports by default via the EXPOSE command in Dockerfile. See https://docs.gitlab.com/ee/ci/services/#how-the-health-check-of-services-works.

Hi @EmteZogaf,
Please use the --port command as explained over here in the excellent finding by @maacarbo who can perhaps also offer further help, if required.


iOS Safari / Chrome with TextInput - Keyboard not showing

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
You can find the original issue here: https://github.com/flutter/flutter/issues/110284.
I've opened a new one as the issue above is closed, but the bug is still present.
Expected results
Textfield is tapped by user, gets focus and keyboard is opened.
Actual results
Textfield is tapped by user, gets focus and keyboard is not opened.
Code sample
Logs
Widget build(BuildContext context) {
  return Title(
    [...]
    child: SingleChildScrollView(
      child: ConstrainedBox(
        constraints: [setting maxWidth...]
        child: IntrinsicHeight(
          child: _body,
        ),
      ),
    ),
  );
}

Widget get _body {
  return Form(
    key: _formKey,
    child: Column(
      [...]
      children: [
        [...]
        TextFormField(
          autofillHints: [...],
          decoration: [...],
          focusNode: [...],
          keyboardType: TextInputType.number,
          onChanged: [...],
          onFieldSubmitted: [...],
          textInputAction: TextInputAction.done,
          validator: [...],
        ),
      ],
    ),
  );
}

Screenshots or Video
No response
Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.7.7, on macOS 13.4 22F66 darwin-arm64, locale en-BY)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.1)
[✓] VS Code (version 1.79.2)
[✓] Connected device (3 available)
[✓] HTTP Host Availability

• No issues found!

My bad. I've dig a bit and found out, that the issue is with suffix icon. So if suffix icon is something clickable like IconButton, then TextField is focused and keyboard is not shown. The usecase for it, for example, is show/hide password icon.

Code
Spoiler text. Note that it's important to have a space after the summary tag. You should be able to write any markdown you want inside the <details> tag... just make sure you close <details> afterward.
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';

void main() {
WidgetsFlutterBinding.ensureInitialized();
RendererBinding.instance.setSemanticsEnabled(true);

runApp(MyApp());
}

class MyApp extends StatelessWidget {
@override
Widget build(BuildContext context) {
  const String title = 'TextInput not showing Keyboard on mobile WEB - Issue';
  return MaterialApp(
    title: title,
    debugShowCheckedModeBanner: false,
    theme: ThemeData(
      primarySwatch: Colors.blue,
    ),
    home: const MyHomePage(title: title),
  );
}
}

class MyHomePage extends StatefulWidget {
final String title;

const MyHomePage({
  Key? key,
  required this.title,
}) : super(key: key);

@override
State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
final GlobalKey<FormState> _formKey = GlobalKey<FormState>();

@override
Widget build(BuildContext context) {
  return Scaffold(
    appBar: AppBar(
      title: Text(widget.title),
    ),
    body: Center(
      child: Form(
        key: _formKey,
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          crossAxisAlignment: CrossAxisAlignment.start,
          children: [
            const Text(
              'please enter a number',
            ),
            TextFormField(
              keyboardType: TextInputType.visiblePassword,
              onChanged: (value) {},
              decoration: InputDecoration(
                suffix: IconButton(
                  onPressed: () {},
                  icon: const Icon(Icons.visibility),
                ),
              ),
            ),
          ],
        ),
      ),
    ),
  );
}
}

Hi @vodemn. I'm still unable to reproduce this issue with the sample code on the latest master and stable channels
Video

https://github.com/flutter/flutter/assets/53122008/af6d4d10-f568-418c-b86d-4d5861c78247

Are you on the latest versions? If yes, can you help with a video reproducing the issue?


add disabled-by-default warning for self.x = x in init

Also:

Commit a few things that should have been in the last PR but that I forgot to commit
Test that disabling-by-default works.

CI is going to fail for typeshed until python/typeshed#1017 is merged.


Issue with autocomplete UX

Describe the Problem
Just a UI bug for the combo form, when you're selecting a generic card, when the generic template you're selecting for doesn't fall into one of the current categories the dropdown doesn't give any way of hiding itself, and it blocks the buttons below it

I don't see this behavior, is there better test data?

I can't reproduce it anymore, apparently the bug has been removed


Problem computing glyph bounds of attached marks

I have a glyph ڊ, which is decomposed using mark attachment to dotbelow-ar=0@221,-25+0|dal-ar=0+3391. calcGlyphLineBounds calculates its bounding box like so:
https://github.com/BlackFoundryCom/black-renderer/blob/76eed169368f90bca617f29c095644d5316d2428/Lib/blackrenderer/render.py#L110-L121
If we annotate this:
Original bounds of dotbelow-ar are (112, -194, 248, -55)
Offset bounds of dotbelow-ar are (333, -219, 469, -80)
Union bounds so far are (333, -219, 469, -80)
Original bounds of dal-ar are (34, 0, 372, 398)
Offset bounds of dal-ar are (34, 0, 372, 398)
Union bounds so far are (34, -219, 469, 398)

According to this, the addition of the dotbelow-ar glyph pushes out the maxX of the bounds from 372 to 469.
Except it doesn't: the ink of the dotbelow-ar glyph is entirely contained within the ink of the dal-ar:

There is some trick to computing the bounds of a mark-positioned glyph, but unfortunately I can't exactly remember what it is. :-/
(This matters because comparing renderings of a precomposed and a decomposed glyph fails because even though they have the same content, the canvases end up having different widths.)

Interesting. However, if I visualize those numbers, I get this:

(Red: original bounding box, blue: offset bounding box)
I'm not sure what this means, but it suggests the "original" bounds for dotbelow-ar are already offset.
Any way I can play with (a subset of) this font? Privately would be fine, too.

I wonder if I misunderstood HB's get_glyph_extents:
https://github.com/BlackFoundryCom/black-renderer/blob/76eed169368f90bca617f29c095644d5316d2428/Lib/blackrenderer/font.py#L427-L436

It's a new version of Noto Naskh Arabic. Attached.
nnu-reengineer.zip

Unfortunately I cannot reproduce it. If I add a print to calcGlyphLineBounds() like so:
diff --git a/Lib/blackrenderer/render.py b/Lib/blackrenderer/render.py
index 4455311..d4fc05c 100644
--- a/Lib/blackrenderer/render.py
+++ b/Lib/blackrenderer/render.py
@@ -119,6 +119,7 @@ def calcGlyphLineBounds(glyphLine, font):
             bounds = glyphBounds
         else:
             bounds = unionRect(bounds, glyphBounds)
+        print(f"line bounds after adding {glyph.name}:", bounds)
     return bounds

...and then invoke blackrenderer with ccmp=0 and ccmp=1, the respective outputs are:
$ blackrenderer NotoNaskhArabic-Regular.ttf ڊ nna_ccmp0.png --features ccmp=0
line bounds after adding dalDotbelow-ar: (34, -197, 372, 398)
$ blackrenderer NotoNaskhArabic-Regular.ttf ڊ nna_ccmp1.png --features ccmp=1
line bounds after adding dotbelow-ar: (139, -197, 275, -58)
line bounds after adding dal-ar: (34, -197, 372, 398)

The resulting images have the same dimensions.

Any updates on what may have caused your observations?

I don't know; I think I was doing something wrong. We got things working on our end. Sorry to bother!


UofT-DSI | Shell - Assignment 1

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist

[x] I can confirm that my changes are working as intended

you did a great job here!
A few things to notice:
The rm command works better with braces {} if properly expanded, but for clarity and flexibility, it’s better to break it into two commands:
rm ./data/raw/*ipaddr*
rm ./data/processed/user_logs/*ipaddr*

The ls command doesn’t expand ** without the right options. It's better to use find instead:
find ./data/processed/ -type f > ./data/inventory.txt
Please go ahead and close this pull request now. Thanks!


Track the overall frame time (latency) between the start of VSYNC (in the UI thread) and the end of Rasterizer::Draw (in the GPU thread)

Currently our flutter driver performance tests only have UI thread VSYNC times (frame_build_time_millis in timeline_summary.json), and GPU thread Rasterizer::Draw times (frame_rasterizer_time_millis in timeline_summary.json).
Tracking them separately and ensuring them to be no more than 16ms (for 60fps) only guarantees smoothness, but not latency.
Moreover, something could happen between VSYNC and Rasterizer::Draw.
So as a first step, we could simply track the sum of  VSYNC and  Rasterizer::Draw times for a frame. In the end, we should directly compute the latency by comparing two timestamps.

It looks like a bunch of work was done here.  Should this still be open?

@liyuqian
we're thinking about using this as a measure of the FPS：https://github.com/flutter/flutter/issues/32447
but worry  that the FPS value calculated here (frame UI time + frame Raster time < 16.66ms)  is lower than what the user really feels due to multiple sharedBufferStack mechanisms
Do you have any Suggestions？


Renaming group using characters doesn't work

link to #5099
Step:

rename existing group users as $x<=>[y*z^2]! or 50%pass

Actual: code response - 204 but groupName has not changed
Expected: groupName has changed

@ScharfViktor  We have the issues for those scenario:
=: https://github.com/owncloud/ocis/issues/5966, https://github.com/owncloud/ocis/issues/5970, https://github.com/owncloud/ocis/issues/5969, https://github.com/owncloud/ocis/issues/5968
%: https://github.com/owncloud/ocis/issues/5083
PR to change the issue in expected failure list: https://github.com/owncloud/ocis/pull/5971

fixed by: https://github.com/owncloud/ocis/pull/6004


Fix WeChat

n/t
Microsoft Reviewers: Open in CodeFlow

I just used WeChat when giving examples, please do not close my issue immediately. Thx

Okay, that's strange. When i created the fix, the Hash was different from what has been committed previously. As described in https://github.com/microsoft/winget-pkgs/issues/848, the given hash WAS invalid and during my tests, the new hash worked.
Let's see, if it works now.


test: use new mock.get_last_params() for public storage writes

This uses the new mock features implemented in https://github.com/noir-lang/noir/pull/4789 to test calls to storage writes. It's not incredibly exciting, but is a nice example of how such an oracle is used and nicely adds to the completeness of the ~SharedMutable~PriblicMutable tests.

Benchmark results
No metrics with a significant change found.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
64 txs

l1_rollup_calldata_size_in_bytes
772
772
772

l1_rollup_calldata_gas
6,844 (+1%)
6,844
6,844

l1_rollup_execution_gas
587,325
587,325
587,325

l2_block_processing_time_in_ms
1,450 (-2%)
5,438 (+1%)
10,425 (+1%)

note_successful_decrypting_time_in_ms
249
545 (-2%)
942 (-1%)

note_trial_decrypting_time_in_ms
49.7 (+1%)
53.0 (-19%)
57.9 (-17%)

l2_block_building_time_in_ms
18,211 (+1%)
70,979 (-1%)
140,922 (-1%)

l2_block_rollup_simulation_time_in_ms
17,969 (+1%)
70,107 (-1%)
139,250 (-1%)

l2_block_public_tx_process_time_in_ms
8,294 (+1%)
32,080
63,894 (-1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
16,083 (-3%)
29,758 (-1%)

note_history_successful_decrypting_time_in_ms
1,166 (-7%)
2,309 (-8%)

note_history_trial_decrypting_time_in_ms
35.7 (-48%)
83.5 (-29%)

node_database_size_in_bytes
19,189,840
35,795,024

pxe_database_size_in_bytes
29,859
59,414

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
149 (-2%)
45,173
27,384

private-kernel-inner
164 (-1%)
73,608
27,384

private-kernel-ordering
120 (-1%)
53,138
41,123

base-parity
45.4
128
311

root-parity
7.17 (-4%)
1,244
311

base-rollup
19,100 (-1%)
110,928
957

root-rollup
47.2 (-1%)
4,551
821

public-kernel-app-logic
92.3 (-2%)
50,319
42,853

public-kernel-tail
376 (-1%)
159,352
7,493

merge-rollup
6.83 (-3%)
2,760
957

public-kernel-teardown
87.4 (-1%)
50,319
42,853

public-kernel-setup
85.7 (-1%)
50,319
42,853

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
512 leaves
1024 leaves
2048 leaves
4096 leaves
32 leaves

batch_insert_into_append_only_tree_16_depth_ms
11.0 (-2%)
17.7 (-1%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.6
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.638 (-1%)
0.547 (-1%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
51.8 (-1%)
80.2 (-1%)
261
500 (-3%)
972 (-3%)
1,940
N/A

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
96.0
159
543
1,055
2,079
4,127
N/A

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.531 (-1%)
0.495 (-1%)
0.475
0.468 (-3%)
0.462 (-3%)
0.464
N/A

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
60.6 (-2%)
119 (-2%)
378
738 (-3%)
1,454 (-2%)
2,895 (-1%)
N/A

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
105
207
691
1,363
2,707
5,395
N/A

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.536 (-1%)
0.536 (-1%)
0.513
0.509 (-3%)
0.505 (-2%)
0.505 (-1%)
N/A

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
67.3 (-2%)

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
109

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
0.588 (-1%)

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
42,886
535,757

Transaction size based on fee payment method

Metric
native fee payment method
fpc_public fee payment method
fpc_private fee payment method

tx_with_fee_size_in_bytes
897
1,145
1,345

Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes
2 new note hashes

tx_pxe_processing_time_ms
1,237 (-1%)
834 (-3%)
3,515 (+2%)

Metric
1 public data writes
2 public data writes
3 public data writes
4 public data writes
5 public data writes
8 public data writes

tx_sequencer_processing_time_ms
796 (-2%)
669
1,275 (-1%)
871
1,951
1,130 (+1%)


Get to version 1

This serves as a checklist of what we need to do to get to version 1.

[ ] implement all standard components we're aware of
[ ] example site should show usage of all exported components
[ ] all form components and validation should be working with final form in example site as expected
[ ] collaborator review of all markup/props used by example site
[ ] storybook review
[ ] generate list of all exported components + props (api documentation)
[ ] working usage in an internal tool
[ ] decision on grid tooling
[ ] API documentation #64

implement all standard components we're aware of
i'll start a list of standard components so we're clear what we're considering

[ ] input text

[ ] input radio

[ ] input checkbox

[ ] input file upload

[ ] textarea

[ ] date

[ ] select

[ ] button

recommendation from Steve on Grid

Export grid from govuk-react as it is based on existing govuk styles, but this is optional and expect parent project to be able to use it's own grid tooling.

tabs: https://reform-pattern-library.herokuapp.com/components/tabs

modal/lightbox: https://govuk-accessibility-sandbox.herokuapp.com/
https://github.com/alphagov/govuk-design-system-backlog/issues/30

The example site could copy the prototype toolkit? Would help be some form of benchmark/validation target.


Formalize Webhooks Subscribe/Unsubscribe

Webhooks were added in addition to callbacks in OAS 3.1 with this proposal:
https://github.com/OAI/OpenAPI-Specification/pull/1974
I understand callbacks to be typically delayed responses to a request - hence one provides a dedicated callback URL in order to identify the matching request a delayed response belongs to.
Webhooks are different in that unrelated events/messages are sent to the client. Great to see that this was added in OAS 3.1.
I was wondering whether an option could be added to formalize a client subscribing to events as well as unsubscribing from them. There likely will be an API to do so, but it won't be possible for a OAS tool chains to figure out what APIs to call to subscribe/unsubscribe to events and what parameters to use to identify a subscription. This could be as simple as the client's webhook URL, but there are implementations that use a different subscription identifier.
For the "newPet" webhook example, it would be good to have a reference to a path elements that performs the subscription on the server or the path elements a decorator identifying which webhook and whether it's a subscribe/unsubscribe.

to me formalizing the client subscription model is outside of the scope of OAS, as it is touching the architecture of the software
for instance in some case you subscribe during the application creation (as same time you create client id/secret) you subscribe to the event you want to get .
in other implementation you subscribe at run time
also you might want to subscribe to a particular semantic of an event , for instance subscribing only to pet jumping and not running , so the subscription itself can have semantics
What you may use is the Link object ( https://spec.openapis.org/oas/latest.html#link-object )


Use parking_lot instead of std::sync::RwLock on aarch64?

Seems that this can bring huge performance improvements.
 It is only a benchmarking and correctness-testing comparison. It is not used in „production“ setup at all.


SkiaSharp.Views.Forms.WPF does not target .Net Core / .Net 5

The SkiaSharp.Views.Forms.WPF package only targets .NETFramework 4.6.2.
https://github.com/mono/SkiaSharp/blob/b43c95f604040246229828ccd9a9537991600b26/nuget/SkiaSharp.Views.Forms.WPF.nuspec#L30
However, the components they depend on all support .Net Core or .Net standard.

OpenTK (>= 3.1.0)
OpenTK.GLControl (>= 3.1.0)
SkiaSharp (>= 2.80.3-preview.18)
SkiaSharp.Views.Desktop.Common (>= 2.80.3-preview.18)
SkiaSharp.Views.Forms (>= 2.80.3-preview.18)
SkiaSharp.Views.WindowsForms (>= 2.80.3-preview.18)
SkiaSharp.Views.WPF (>= 2.80.3-preview.18)
Xamarin.Forms (>= <IP_ADDRESS>2)
Xamarin.Forms.Platform.WPF (>= <IP_ADDRESS>2)

It should be possible to release a .net core or .net 5 target.
I'd be willing to submit a PR if someone could point me to the build files that need updating.

Any response? @mattleibow

Are there any news about this? Or is there an alternative package?

I did not realise that forms was now running on netcore, so I can do that.

I have updated to the latest v4.x of Forms. v5.0 is out, but I don't need that and also I can let people update if need be.
The next preview on the preview feed should now be .NET Core friendly :)


Deploy Laravel 4.2 behind proxy server

My scenario as below:

Public domain: example.com
Private IP: <IP_ADDRESS>
Laravel is deployed to server addressed <IP_ADDRESS> behind proxy server addressed example.com
URL::to('/') return <IP_ADDRESS>. I expected that I am able to defined base url for Laravel when I set app.url = 'example.com'.

app.url must be a valid url. That is not a valid url. 'https://example.com is a valid url.

@GrahamCampbell , thanks for your quick response.
I used a valid URL (http://example.com). But URL::to('/') return <IP_ADDRESS>. How can I change it?

The app.url config is only used in the route:list artisan command.
I think your best bet is using Url::forceRootUrl('http://example.com').
But I assume there is a better way...


rpc error: code = Internal desc = the sidecar container terminated due to ContainerStatusUnknown

I'm using this driver to mount a gcs bucket to a local folder in the pod and I'm seeing the error below:
kubelet  MountVolume.SetUp failed for volume "XXX" : rpc error: code = Internal desc = the sidecar container terminated due to ContainerStatusUnknown

I'm running a GKE cluster and this issue happens only on pods running on preemptible nodes that are restarted due to node replacement.

Hi @franciscocpg , thanks for reporting this issue.
This is actually expected since workloads on preemptible nodes can be interrupted. However, we can improve the error code and the documentation.
I have a question: Is your workload affected due to this error? If so, could you share more information?

Hi @songjiaxun.

I have a question: Is your workload affected due to this error? If so, could you share more information?

Yes, the pods got stuck in ContainerStatusUnknown or ContainerCreating or Error status and the number of running replicas is not respected, eg:
$ kubectl get deploy my-deploy
NAME         READY   UP-TO-DATE   AVAILABLE   AGE
my-deploy    4/6     6            4           6y176d

$ kubectl get po -l app=my-deploy
NAME                          READY   STATUS                   RESTARTS   AGE
my-deploy-859b7469ff-5bt8v    0/2     Error                    1          101m
my-deploy-859b7469ff-69jdr    0/2     Error                    1          96m
my-deploy-859b7469ff-rqdbq    0/2     ContainerStatusUnknown   2          102m
my-deploy-859b7469ff-tbg4h    0/2     Error                    1          100m
my-deploy-859b7469ff-tppbc    0/2     ContainerStatusUnknown   1          95m
my-deploy-859b7469ff-zq6gm    0/2     ContainerStatusUnknown   1          95m
my-deploy-898c96857-5j69g     0/2     ContainerCreating        2          90m
my-deploy-898c96857-72g5m     2/2     Running                  0          90m
my-deploy-898c96857-bdff8     2/2     Running                  0          89m
my-deploy-898c96857-c7cvm     2/2     Running                  0          89m
my-deploy-898c96857-phggw     0/2     ContainerCreating        2          89m
my-deploy-898c96857-z6vhk     2/2     Running                  0          89m

So I need to manually delete the pods with issues to have the 6  replicas available again.

@franciscocpg thanks for the info! Let me try to repro on my side and get you updated.

Thank you @songjiaxun.
My current workaround is to install gcsfuse in the docker image that the pod is running and mount/unmount the local folder from the gcs bucket using the lifecycle hooks, eg:
(...)
spec:
  template:
    spec:
      containers:
      - lifecycle:
          postStart:
            exec:
              command:
              - /bin/sh
              - -c
              - mkdir -p /local/folder && gcsfuse --implicit-dirs -o allow_other my-bucket /local/folder
          preStop:
            exec:
              command:
              - /bin/sh
              - -c
              - fusermount -u /local/folder
(...)

Hi @franciscocpg ,
We recently root-caused a similar issue: https://github.com/GoogleCloudPlatform/gcs-fuse-csi-driver/issues/113#issuecomment-1836705618
Could you confirm if you are also using 1.26 clusters, and the errors happen during node preemption?
If so, upgrading to 1.27 clusters may fix the issue.

This issue should have been resolved in the current CSI driver. Closing for now. Please re-open if similar issues are seen.


Use reviewdog in CI (and locally)

https://github.com/reviewdog/reviewdog

We're already using golangci-lint, which also does more than this.


style.css not enqueued

the main editable isn't loaded into wordpress.

@vkotek that is not a problem because we keep our styles in css folder. If you want to change or add styles it would be best to use one of plugins or create your own child theme. Currently we don't have prepared child theme for Briar but you can take a look into Pine child theme https://github.com/themejack/pine-child.


Minor UI issues in TCMenu Designer

Hi Dave,
I just wanted to point out a few minor issues in the designer. None of this effects functionality, but addressing these issues would make the UI a bit more polished.
These issues are all present in 3.0.0

The preview for default value seems to lag one keystroke behind input in any field (here showing RP instead of RPM). This is particularly confusing when the updates don't immediately reflect changes in Offset or Divisor

Scroll bars can be cut off entirely if the UI window is too small. Probably best if the minimum window size is increased, or scroll bars are made to always stick to the right edge of the screen. Shown here partially obscured, but it can be completely hidden.

Also shown: some text labels are truncated with "..." when there is still enough room to view the whole field

Long menu variable names are obscured by the "X". This effects at least the last 2 characters of names that exceed the width of the text box. Both cursor and characters are obscured

Obviously nothing critical here, I just thought it might be helpful to bring these to your attention. Thanks!

I've fixed first one, scroll bar wise I've made the layouts work a bit better, but window sizing, I'll see if I can prevent it getting too small but this is very minor.
For the cross in text fields- https://github.com/davetcc/tcMenu/issues/306


Bugfix for double-click detection, added helper method to get lays index based on y coordinate.

Hello,
Thanks for your input.
The codebase is refactored and more changes are coming,
so this one cannot be merged.
click fix is reimplemented but I don't like the idea to get index by a coordinate.
My proposal is to get row by a coordinate, then you can find an index.
Also, your model can include an index.
P.s. mouse events will give you all clicked elements so it might be that this method will be obsolete.

Refactoring is started, there are few things left to do, but this one is reimplemented.


Yesterday all devices (DW2-Wi-Fi-L SONOFF) fell off -

SonoffLAN v.3.7.3
"installation_type": "Home Assistant OS",
"version": "2024.7.3",
"os_version": "6.6.33-haos",
"supervisor": "2024.06.2",
"host_os": "Home Assistant OS 12.4"

If you enable only the cloud in the integration settings, we see this error:
"Cannot connect to host cn-apia.coolkit.cn:443 ssl:default [[SSL] record layer failure (_ssl.c:1000)]"
If you enable both local connection and cloud in the integration settings, we see that the devices are not available!

Figured it out myself, the address cn-apia.coolkit.cn was not resolved by the upstream DNS server. Added a local DNS entry in Mikrotik and everything worked. Maybe it will be useful to someone.

Thanks! same for me my pihole DNS was blocking traffic to cn-apia.coolkit.cn added to the witelist and it came back :) <3


Fsync directory after created and fix other not atomic operations that may make the underlying data broken

Currently we only fsync normal file after finishing write to it. But we also need to fsync directory after they are created, otherwise if the system crash before the directory's data flushing to disk, the storage data represented by the directory may be in a broken state.
And we also need to find and fix other non-atomic operation that may make the underlying data broken.

Lower the severity, since we cannot prove that it can really cause issues.


Errors are collected twice

Description:

Steps to reproduce:
Have an object and function interfaces without function implementations.
Affected Versions:
Ballerina 0.970.0-beta6-SNAPSHOT
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

I tried with below sample code with master branch
function main(string... args) {
        Person p = new;
}

type Person object {
        public {
                int age,
        }

        function test1();

        function test2();
};

it gives the following error, which is correct without any duplicates
error: ./test1.bal:3:13: cannot initialize object 'Person', no implementation for the interface 'Person.test1'
error: ./test1.bal:3:13: cannot initialize object 'Person', no implementation for the interface 'Person.test2'
compilation contains errors
hence closing the issue


feat: support latest and asset type filter

Adds library search API endpoint support for:

latest=true - filters the assets to the latest assets only
assetFilter=[js|css|images|fonts] (can be comma separated) - only include assets matching the filter type (to help exclude assets like images from material-design-icons libraries, etc)

Note that I've tried to keep the code in ES5 flavour (wasn't sure if that was right or not).
Reasoning: I'm doing a big rewrite of jsbin, and I've included cdnjs integration, but searching for libraries like "react" doesn't give me "react-dom" unless I request the assets, which doesn't allow for finer filtering (hence this PR).

+1

Anyone look for this, but can't wait (or it doesn't get merged), you can do this using jq and curl:
curl -s https://cdnjs.com/packages.min.json | jq '.packages | .[] | .version as $version | { name: .name, version: .version, assets: .assets | .[] | select(.version == $version) | (.files | map(select( . | endswith(".js") )) ) }'

Broken up for legibility:
curl ... | jq '
.packages | # select the packages
.[] | # forEach
.version as $version | # store the latest version as $version
{ name: .name, version: .version, assets: .assets | # pick some fields, and generate assets from…
  .[] | # forEach asset item
  select(.version == $version) | # select where version === latest version
    (.files | # pick the files…
      map(select( . | endswith(".js"))) # filter for only the .js files
 ) }'

There's probably a better way of the doing the jq select, but it's my first time using jq in anger. Certainly gives me the result I needed.

Oh wow ... sorry for my late response ... there are too many notifications in my box 😭

Hey, just checking in - I was away for work then birthday, then just settling back in. I'll fix these review points (ideally this week). Thanks.

@remy thanks a lot!

hmmm, anything I can help here?

@remy is this still being worked on?

Ah, no. I remember hitting some weird issue that was deep inside the
system, and possibly lost the thread of work I was doing at the time.
On Thu, 6 Jun 2019, 01:45 Drew Freyling<EMAIL_ADDRESS>wrote:

@remy https://github.com/remy is this still being worked on?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cdnjs/new-website/pull/191?email_source=notifications&email_token=AAADLBBIY4YZASVNL7JU6X3PZBM37A5CNFSM4DVSOUP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXBNFMI#issuecomment-499307185,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAADLBHV5JLYXCHRQ72DL5DPZBM37ANCNFSM4DVSOUPQ
.

Hey @remy, if you're interested in picking this up again, we have a new API server now, which can be found in https://github.com/cdnjs/api-server :)
As this API server here is no longer used, I'll close this PR.


cmd/go: using a module path without dot fails to build after toolchain selection

Similar to #61871, but:
$ cd $(mktemp -d)
$ go mod init example/m
go: creating new go.mod: module example/m
$ go get<EMAIL_ADDRESS>go: downgraded go 1.21.0 => 1.20
$ echo "package main; func main() {}" > main.go

$ GOTOOLCHAIN=go1.20.7 go run .
ambiguous import: found package example/m in multiple modules:
	example/m (/tmp/LpbXADzD)
<EMAIL_ADDRESS>$ echo $?
1

It works fine without toolchain selection, or if a dot is used in first path element.
I noticed because I usually type something short (i.e., without a dot in first path element) when running a throwaway program locally. I know import paths without a dot are reserved for the standard library and shouldn't be used, but example/... and test/... are reserved for user progams per #37641.
CC @bcmills, @matloob, @rsc.

@gopherbot, please backport to Go 1.21. This is a very confusing failure mode.

I think this is actually a bug in go1.20.7, with a workaround for Go 1.21 in https://go.dev/cl/504119 and a proper fix pending in https://go.dev/cl/504063.

If so, that should imply that if you install go1.20.7 locally (so that it can be found via $PATH instead of in the module cache), then you will not observe this odd failure.
It should also not be present if you set GOTOOLCHAIN to, say, go1.21rc3.

should imply that if you install go1.20.7 locally (so that it can be found via $PATH instead of in the module cache), then you will not observe this odd failure.
It should also not be present if you set GOTOOLCHAIN to, say, go1.21rc3.

Both statements are true based on a quick local run.
I think it would be fine to close this issue in Go 1.22 and request a backport of it to Go 1.21. But since it's being repurposed to be a backport issue, I'll update the title and labels accordingly.

This is fixed as far as Go 1.20. @dmitshur, I think there is still one final release planned for Go 1.19 — do you think this is worth fixing on that branch, given that Go 1.19 would normally be past its support window?

@bcmills I tested out the original repro steps with Go 1.19 instead of 1.20, and it's hard for me to tell if it's affected by the same bug as described in this issue or a different one. It doesn't work with a different error:
$ cd $(mktemp -d)
$ go mod init example/m
go: creating new go.mod: module example/m
$ go get<EMAIL_ADDRESS>go: downgraded go 1.21.0 => 1.19
$ echo "package main; func main() {}" > main.go
$ GOTOOLCHAIN=go1.19.12 go run .
import "": import of unknown directory
$ echo $?
1

There's some connection to #61871, but that issue is about error text in invalid programs, while this issue was about valid programs with a dotless import path not running when an older toolchain is selected.
It's hard for me to say, so leaving the decision to you. In general I think it's better not to break Go 1.19.13 at this point, even if it means some inconvenience (i.e., need to include a "." in the import path of short example or test programs when trying to use it via toolchain selection). On the other hand if you're very confident in the safety of the fix and the same CL will work despite the error being seemingly different, you do have that opportunity to still fix it up.

My inclination is that it's not worth the risk to mess with the final 1.19 release: as a workaround, folks can always install it in $PATH to prevent it from being loaded from the module cache.


Add ability to skip resources within template when applying

As a user,
I want the ability to select/unselect resources from a template on application,
so that I can install only the resources I am interested in
Acceptance Criteria

[ ] HTTP API is extended with the following root field

{
  ... existing fields
  "selection": [
      {
           action: "skipResource",
           properties: {
                resourceTemplateName: RESOURCE_TYPE_NAME,
                kind: RESOURCE_KIND,
           }
      },
      {
           action: "skipKind",
           properties: {
                kind: RESOURCE_KIND,
           }
      },
      ...
   ]
}

note: I really don't like the key selection here... tbd what that key will be

[ ]  each resource provided in the selection collection that has an action "skipResource" will be skipped when applying the pkg
[ ]  all resources matched in the selection collection that has an action "skipKind" will be skipped when applying the pkg

worth exploring before making a decision

[ ] saving selections of last application in stack (doubting we need this, think the merging of templates makes this likely though)

I really like the shape of this API, not specifically what I wrote out above, but the overarching ability to provide selection criteria for resources. There has been an ask for converging resources together (common labels), which we can do transparently, but what we don't have an answer for, until now potentially is the ability to merge dashboards together from different templates(@samhld / @rbetts  have mentioned before). This would enable the skipping of a resource pave the way for that possibility.  Something like the following:
{
  "selection": [
      {
           "action": "mergeResources",
           "properties": {
                "kind": "Dashboard",
                "resourceTemplateNames": [
                      "DASH_TEMPLATE_NAME_1",
                      "DASH_TEMPLATE_NAME_2"
               ]
           }
      }
   ]
}

In the example above is a simplified API for allowing dashboards to be merged, by this I mean the cells can be merged.


Support custom adapter config

Hi,
i want to load my custom config bellow
  dap.adapters.custom = {
    type = "server",
    host = "<IP_ADDRESS>",
    port = 2345,
  }

but the plugins only support the go adapter type

Hi @YogiPristiawan,
This project is mainly a Go extension for the nvim-dap plugin. I am not sure what is the intention with custom adapter. Which use cases are you willing to cover with this proposal?

Because I have constraints when using the defined go adapters configurations:

I can't use a debugger if my main package is not in the root directory. Therefore, I can't use debug_test.
I want to connect to my running delve instance that runs together with Air. I run my project using Air because I need hot reload for local development, and I also need to load my .env file.


Bug: sdkman detects more recent Java version as older if multiple versions available

Bug report

When I run sdk upgrade and I have multiple Java versions installed if one of those is older than the current 'latest' sdkman suggests to upgrade to an 'older' version.
sdk upgrade

Upgrade:
java (16.0.0.hs-adpt, 8.0.282.hs-adpt, 11.0.11.hs-adpt, 21.1.0.r11-grl < 11.0.10.hs-adpt)

Upgrade candidate(s) and set latest version(s) as default? (Y/n): n

To reproduce

Install the Java versions above and run sdk upgrade
System info

Linux Ubuntu 20.04.2
zsh 5.8 (x86_64-ubuntu-linux-gnu)
SDKMAN 5.11.0+644

I have the same bug:
sepp@box:~/Schreibtisch$ sdk ug
Upgrade:
java (11.0.11-open, 16.0.1-open, 16.0.1-librca, <IP_ADDRESS>-ms, 11.0.11.hs-adpt, 6.0.119-zulu, 17.ea.18-open, 8.0.292-zulu, 21.1.0.r16-grl, 11.0.11-librca, 8.0.292.hs-adpt, 8.0.292-open, 7.0.302-zulu < 11.0.10.hs-adpt)
Ubuntu 20.10, bash, SDKMAN 5.11.0+644

Same issue on:
macOS Big Sur (11.3.1)
zsh 5.8 (x86_64-apple-darwin19.6.0)
SDKMAN 5.11.2+698

This is not a bug. SDKMAN has a default version for every candidate. The default version for Java is set to the current LTS version, which happens to be the latest in the series of 11 right now.
The name upgrade was not very well chosen, as it implies that the latest should be installed. I'm open to suggestions for a better name for this command.

The default version for Java is set to the current LTS version, which happens to be the latest in the series of 11 right now.

In my case (it should maybe not appear in this issue :innocent:), I don't understand why the default version 11.0.10.hs-adpt is older than my installed version, 11.0.11.hs-adpt:

11.0.11.hs-adpt, 16.0.1.hs-adpt, 8.0.292.hs-adpt; default: 11.0.10.hs-adpt


Chronograf and Telegraf 1.1 docs

@beckettsean, the Chronograf skeleton for 1.1 is about ready.
@gunnaraasen, what I did to create the deprecated page seems not great. It shows up in the Versions menu and I can click on it to get to the page - but the Chronograf versions section doesn't load on the page and I see an error in the logs:
ERROR: 2016/11/03 template: partials/chronograf/sidebar.html:26:35: executing "partials/chronograf/sidebar.html" at <.Identifier>: range can't iterate over <*hugolib.Menu Value> in partials/chronograf/sidebar.html.
Any advice?


ddev start suggests "you can run this command with the --remove-orphans flag" but that's not a valid flag

Is there an existing issue for this?

[X] I have searched the existing issues

Output of ddev debug test
Expand `ddev debug test` diagnostic information
[COPY-PASTE HERE THE OUTPUT OF `ddev debug test`]

Expected Behavior
DDEV shouldn't tell the user to do something that's impossible.
Actual Behavior
Doing ddev start said:
Error response from daemon: network with name ddev-thewsd_default already exists
time="2024-01-30T15:00:17Z" level=warning msg="Found orphan containers ([ddev-thewsd-frontend-1 ddev-thewsd-test_report_creator-1 ddev-thewsd-web ddev-thewsd-db ddev-thewsd-redis-1]) for this project. If you removed or renamed this service in your compose file, you can run this command with the --remove-orphans flag to clean it up."

Doing ddev start --remove-orphans said:

Error: unknown flag: --remove-orphans

Steps To Reproduce
No response
Anything else?
No response

See https://stackoverflow.com/questions/62997751/found-orphan-containers-when-starting-ddev-project

The only thing I can thing of is to tweak the error message specifically when saying '--remove-orphans' isn't a valid flag, to say something like:

Error: unknown flag: --remove-orphans. If you've passed this flag because of a message about orphan containers, then [SOME SORT OF ADVICE ABOUT WHAT TO DO INSTEAD].

Up to the maintainer to balance the ick of adding babysitting code to do this vs having to deal with future duplicates of this issue :)

Can you please show how to recreate this? I assume it's an invalid docker-compose.*.yaml, happy to take a look if you have a recreation scenario.

Same issue: https://github.com/ddev/ddev-sqlsrv/blob/623bfa61588adbb18980d01f86daf94fa58a145d/docker-compose.sqlsrv.yaml#L16-L17

I have no idea how to recreate it, sorry. My best guess is that I had some test projects from the ddev debug command which I had not deleted, or not correctly deleted by deleting only the folder and not DDEV's definition of them.

It turns out there is a COMPOSE_REMOVE_ORPHANS and COMPOSE_IGNORE_ORPHANS
I think we should just set COMPOSE_REMOVE_ORPHANS=true


using Az.Resources module

Using azure/powershell@v1 module it gives error on using Get-AzResources:
The term 'Get-AzResource' is not recognized as the name of a
     | cmdlet, function, script file, or operable program. Check the
     | spelling of the name, or if a path was included, verify that
     | the path is correct and try again.

It seems like Az.Resource module is not installed in the powershell. How do i ensure that ? I have specified azPSVersion as 4.5.0 which should contain this module.

where are you running your workflow? self hosted runner / github hosted runner?

latest az module installed on hosted runner is 4.4.0. can you try with this version? available versions on runner are updated in this document https://github.com/Azure/powershell#available-versions-of-az-module-on-runner


Missing ReadMe in Body Tracking Samples

Where is the read me for the body tracking samples? I cannot find it.

@Greta-A : it is not in the sensor sdk repo. You can find all our body tracking samples here: https://github.com/microsoft/Azure-Kinect-Samples/tree/master/body-tracking-samples. And the readmes are in each folder.


June 20 updates

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.gitignore
:white_check_mark:Succeeded

mixed-reality-docs/creating-3d-models-for-use-in-the-windows-mixed-reality-home.md
:white_check_mark:Succeeded
View

mixed-reality-docs/design.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holograms-100.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holograms-101.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holograms-101e.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holograms-210.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holograms-211.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holograms-212.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holograms-220.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holograms-230.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holograms-240.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mixed-reality-213.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mixed-reality-250.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


removing unused eindex depencency

CI is currently broken because the eindex dependency just changed its name to eindex-callum (see commit), so our dependencies are now incorrect and we can't install our project. It looks like this dependency is never used in our project anyway, so this PR just removes it as a dependency entirely.

Thanks. We used to use it but stopped.


Update README.md

How about "Add Babbler" instead of "Update README" ? Sure here it doesn't much but for other projects I would like to encourage you to use commit messages that are more descriptive.

Ouch, sorry, I simply forgot to change the title in this particular PR :)

You changed the title of the PR but not the commit message.

Done


how to hide the weekdayview?

is there a method to hide the weekdayview?
i can't find it.

ok i delete _WeekDayFormatter()_invoke ,and its work.

ok i delete buildWeekDays(resetAndGetWorkingCalendar());   invoke ,and its work.

i have same problem ，but i dont want change source code

It will be available in next release.


Add test

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

/home/conda/feedstock_root/build_artifacts/mir-flare_1684991179318/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.8/site-packages/flare/bffs/sgp/sparse_gp.py:14: UserWarning: Cannot import _C_flare: ImportError: /home/conda/feedstock_root/build_artifacts/mir-flare_1684991179318/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.8/site-packages/flare/bffs/sgp/_C_flare.so: undefined symbol: _ZTI6Kernel

@conda-forge-admin, please rerender


Override function focusInvalid

As discussed on StackOverflow I am trying to override the default behaviour of focusInvalid. When I try to use my own invalidHandler to focus on the first invalid element in a form, all of a sudden the form can be submitted by pressing the ENTER key.
Steps to reproduce:

Launch https://jsfiddle.net/kfopux67/3/
Enter a valid email address
Press the ENTER key

Basically I am trying to go from the default:
focusInvalid: function() {
	if ( this.settings.focusInvalid ) {
		try {
			$( this.findLastActive() || this.errorList.length && this.errorList[ 0 ].element || [])
			.filter( ":visible" )
			.focus()
			// manually trigger focusin event; without it, focusin handler isn't called, findLastActive won't have anything to find
			.trigger( "focusin" );
		} catch ( e ) {
			// ignore IE throwing errors when focusing hidden elements
		}
	}
},

...to something like...
focusInvalid: function() {
    if ( this.settings.focusInvalid ) {
        try {
            var firstInvalidElement = $(this.errorList[0].element);
            $('html,body').scrollTop(firstInvalidElement.offset().top);
            firstInvalidElement.focus();
        } catch ( e ) {
            // ignore IE throwing errors when focusing hidden elements
        }
    }
}

...by changing the invalidHandler to something like:
invalidHandler: function(form, validator) {
    var errors = validator.numberOfInvalids();
    if (errors) {
        var firstInvalidElement = $(validator.errorList[0].element);
        $('html,body').scrollTop(firstInvalidElement.offset().top);
        firstInvalidElement.focus();
    }
},

Is there - as assumed in the StackOverflow discussion - an issue in the code that allows submitting the form using the ENTER key or did I do something wrong in my adaptations?

I'm sorry for the lack of activity on this issue. Instead of leaving it open any longer, I decided to close old issues without trying to address them, to longer give the false impression that it will get addressed eventually, especially after several years with no activity. It doesn't mean I'm abandoning the project, just that I'm unable to work through 200+ open issues with the little time I can afford to spend on this project.
To the reporter (or anyone else interested in this issue): If you're still affected by the same issue, please consider opening a new issue, with a testpage that demonstrates the issue with a current version of the plugin. Even better, make an attempt to fix the issue yourself, and improve the project by sending a pull request. This may seem daunting at first, but you'll likely learn some useful skills that you can apply elsewhere as well. And you can help keep this project alive. We've documented how to do these things, too. A patch is worth a thousand issues!

@staabm any insight on this based on what I referenced above?
For arguments sake, I've updated @subsecond jsfiddle to the latest release (1.17.0)
Using .focus() in the invalidHandler: https://jsfiddle.net/kfopux67/51/
Using focusInvalid: true: https://jsfiddle.net/kfopux67/52/
To replicate:

Type<EMAIL_ADDRESS>into email field
Press ENTER key

Actual Result:
Form submits by itself
Expected Result:
Validation message shows stating password is required

@bytestream I created a new issue with you comment as the body. We will look into it as soon as possible.
Thanks!