Reference Unsloth in header

Summary
Reference Unsloth in header section

Testing Done

Hardware Type:
[x] run make test to ensure correctness
[x] run make checkstyle to ensure code style
[x] run make test-convergence to ensure convergence

@ByronHsu @helloworld1 @yundai424 @qingquansong ptal

In apache license, it says If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute must include a readable copy of the attribution notices contained within such NOTICE file, excluding those notices that do not pertain to any part of the Derivative Works, in at least one of the following places: within a NOTICE text file distributed as part of the Derivative Works; within the Source form or documentation, if provided along with the Derivative Works; or, within a display generated by the Derivative Works, if and wherever such third-party notices normally appear. The contents of the NOTICE file are for informational purposes only and do not modify the License. You may add Your own attribution notices within Derivative Works that You distribute, alongside or as an addendum to the NOTICE text from the Work, provided that such additional attribution notices cannot be construed as modifying the License.  Are those two files considered derived work? If so, we also need to change the NOTICE file.

In apache license, it says
If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute must include a readable copy of the attribution notices contained within such NOTICE file, excluding those notices that do not pertain to any part of the Derivative Works, in at least one of the following places: within a NOTICE text file distributed as part of the Derivative Works; within the Source form or documentation, if provided along with the Derivative Works; or, within a display generated by the Derivative Works, if and wherever such third-party notices normally appear. The contents of the NOTICE file are for informational purposes only and do not modify the License. You may add Your own attribution notices within Derivative Works that You distribute, alongside or as an addendum to the NOTICE text from the Work, provided that such additional attribution notices cannot be construed as modifying the License.
Are those two files considered derived work? If so, we also need to change the NOTICE file.

Sure will followup with another ticket to change NOTICE file accordingly.

We are glad to announce that Unsloth and LinkedIn have fully resolved disagreements regarding references!


Have option to remove the overlay from the primary(red) loading spinner

The problem
We are considering putting loading spinners on secondary buttons as an indication that the user action from the click is happening for certain workflows. We have a small loading spinner that works well in a button but it applies an overlay internally to the button but not the button padding that looks rather strange. We also have an "on background" loading spinner that does remove the overlay but the spinner portion itself is white, which won't be visible on a secondary button.
The solution
Create a property to remove the semi-transparent overlay from the primary red loading spinner
Alternatives considered
Use other button types such as primary.
Additional information
Current UX with a loading spinner on a disabled secondary button

In my view this might stretch the intended use case of the loading spinner as-designed. If we intend to extend to these hyper-focused uses, we might consider doing a broader revisit to ensure the design is as supportive as it can be (vs. e.g. adding a no-overlay prop or something)


Out of the box use of bundled plugins when MuJoCo is used as a pure C/C++ library

Is your feature request related to a problem? Please describe.
I am working on the packaging of MuJoCo 2.3.0 for conda-forge, and I had doubt (that then can be a enhancement proposal, hence the type of issue).
From what I understand, the new plugin system, can be used out of the box in the following contexts:

When using the Python bindings, as in that case the plugins are loaded by this Python code https://github.com/deepmind/mujoco/blob/2.3.0/python/mujoco/init.py#L61
When using the simulate program, as in that case the plugins are loaded by this C++ code: https://github.com/deepmind/mujoco/blob/2.3.0/simulate/main.cc#L173

Instead, if one is using MuJoCo C++, as of 2.3.0 plugins can not be loaded out of the box, unless copy and adapts the code in https://github.com/deepmind/mujoco/blob/2.3.0/simulate/main.cc#L173  to her/his application. Is my understanding correct? If not, please ignore the rest of the issue, thanks!
Describe the solution you'd like
It would be great if the bundled plugins loaded out of the box also in the C++ library. How to do it is a bit more tricky, basically as long MuJoCo is compiled as a shared library it would be possible to implement a mechanism similar to the one used for simulate, while if MuJoCo is compiled as static library this is not possible, leaving the option either to hardcoded the install path used as compilation, or use an environment variable.
Describe alternatives you've considered
That each executable using MuJoCo implemented its own code to load the bundled plugin, similar to what simulate  does.
Additional context
Some interesting pointers on relocatability in C++ libraries can be found in:

https://indico.cern.ch/event/848215/contributions/3591953/attachments/1923018/3181752/HSFPackagingRelocation.pdf
https://github.com/drbenmorgan/Resourceful
https://github.com/gazebosim/gz-sim/issues/626

The original intention was that if someone is writing a new application that links against MuJoCo then they should decide for themselves how they would like to link and register their plugins. The logic that you point out in simulate is primarily for applications that are supposed to be general, which might expect users to be able to bring precompiled plugins along without having to rebuild the application itself.
Since it's still early days for plugins, I don't know how people will end up using the system. It's possible that the simulate way of working where all plugins in a particular directory are scanned and loaded is more suitable across the board.
We will likely add the loading loop like the one we use in simulate as a MuJoCo API function in our next release. User code will still be responsible for calling the loading loop function however.

Since version 2.3.1, we have the function mj_loadAllPluginLibraries which scans a directory for plugins. Hopefully that solves the issue.


Stacked Taskbar icons

Description of the new feature / enhancement
Drag and drop taskbar shortcuts onto another in order to create folder/groups/stacks of shortcuts.
Scenario when this would be used?
As a web developer, I have at least 4 different browsers and lots of apps, like Photoshop and Illustrator, VSCode etc. that I frequently use and want to have pinned to my taskbar for quick access. But the taskbar is too small to hold them all. I don't want to have four browser shortcuts there and three Adobe CC app shortcuts, and VSCode, Xampp, etc. I want them to be able to be organised in groups. Like, I drag and drop two browser shortcuts onto each other, a folder is created like in the Start menu. I click on this folder icon (which should be customisable) and then a small folder pops  up, just like in the Start menu. Same behavior, just on the Taskbar. This would only save me doing one click, you might say, but I have many more items in the Start menu, so I always have to look a bit for the item I want. If I had one folder for the browsers on the Taskbar, and one for the Adobe apps, and one for stuff like VSCode, Xampp, DBeaver etc, my Taskbar wouldn't be so cluttered always, offer more space and be more convenient to use. It would change the Taskbar so that it offered the ability to set up multiple small Start menus, each for one group of apps with a similar purpose, instead of having one Start menu with everything inside it (which should not be replaced by this), and instead of having 20 shortcuts which could roughly be packed into 4 or 5 groups (like system apps, productivity, browsers, Adobe, web development, 3d).
Supporting information
MacOS has a similar feature, where you can click on for example documents in the dock, and a window pops up with your recent documents.

/feedbackhub


How to catch an EVM/Transaction error correctly

New Feature Request
Checklist

[x] I am not disclosing a vulnerability.
[x] I have searched through existing issues and the Moralis Forum.

Current Limitation
If an EVM error is being thrown if the user communicates with a contract through MetaMask then inside of NextJS the error is not being captured.
Is there any way to have a proper async error handling in place?
Feature / Enhancement Description
Add possibility to watch for errors of web3.ether.contract. The Transaction error is correct but I could not find a way how to handle the error.

Currently I am using following block to solve it, first I use .call and that seems to be catched correctly. .send does not seem to be able to show the error correctly  :
try{
  await contract.methods.mint(selectedAmount)
                    .call({ value: contractDescription.getCurrentCost })
  await contract.methods.mint(selectedAmount)
                    .send({ value: contractDescription.getCurrentCost })
} catch(e){
  console.log("error is thrown while trying to ming..", e)
}

This is how web3.js works. The send call is successfully sent, but you will need to wait until it is confirmed or rejected. Check the docs from web3.js on how to do this properly: https://web3js.readthedocs.io/en/v1.2.11/web3-eth-contract.html#methods-mymethod-send
Will close this issue as it is related to web3.js, not react-moralis


Added an about page

Added an about page

@anushkashukla Can you attach a screenshot of it, please?


Sorting is not deterministic

See below for the reoccurence

The fix for issue #13 revealed that sorting is not stable.
In case of sorting by time, when two times are identical, we also need to take the entity name/source location into account, I'm afraid.
For VCs, the total_proof_time, the maximum_proof time and then the entity location should be compared.
It's a bit unclear what to do with single proof paths, though. They all reference the same location and entity, even sorting by prover name could result in undeterministic behaviour.

I tried adding steps to the sorting criteria, now the templates fail again.
Although unlikely, I am suspecting some floating point to fixed point conversion issues.
See fix_sorting branch which currently fails templates and they differences should not actually be there, unless the time values are actually different.

think I found the issue. It's not the sorting between the proof attempts, but between the proof items. They don't know about steps, and the offending entries have all the same value (max time, total time, rule, severity, and location), so unstable sorting is to be expected. I guess, to stabilize that we need to create unique ids to make these guys different, assuming that (at least for the tests) we can guarantee the order in which the entries are inserted.

Fixed in #28


fix: migration generator when run with :revoke

BAM! It was super annoying to figure out, but this fixes rails destroy model ModelName and rails destroy migration MigrationName so that the associated migration file is properly removed. Personally, I regularly add a model or migration, immediately decide I want to rename it, try to destroy it, and then get annoyed when I need to manually remove the migration file.

The diff coverage is 80%.

@@            Coverage Diff             @@
##           master    #1420      +/-   ##
==========================================
- Coverage   96.88%   96.86%   -0.03%
==========================================
  Files         205      205
  Lines       12430    12440      +10
==========================================
+ Hits        12043    12050       +7
- Misses        387      390       +3

Impacted Files
Coverage Δ

lib/rails/generators/neo4j_generator.rb
65.45% <80%> (+1.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52b0b57...587a5b5. Read the comment docs.

Released as 8.2.4.  Thanks so much for this!


Support for Dreambooth Weights

I've been experimenting with supporting weights from dreambooth in this model:
diff --git a/predict.py b/predict.py
index 5630646..2d23a87 100644
--- a/predict.py
+++ b/predict.py
@@ -10,6 +10,7 @@ from diffusers import (
     StableDiffusionPipeline,
 )

+USE_WEIGHTS = os.path.exists("weights")
 MODEL_ID = "stabilityai/stable-diffusion-2-1"
 MODEL_CACHE = "diffusers-cache"

@@ -18,11 +19,18 @@ class Predictor(BasePredictor):
     def setup(self):
         """Load the model into memory to make running multiple predictions efficient"""
         print("Loading pipeline...")
-        self.pipe = StableDiffusionPipeline.from_pretrained(
-            MODEL_ID,
-            cache_dir=MODEL_CACHE,
-            local_files_only=True,
-        ).to("cuda")
+        if USE_WEIGHTS:
+            self.pipe = StableDiffusionPipeline.from_pretrained(
+                "weights",
+                safety_checker=None,
+                torch_dtype=torch.float16,
+            ).to("cuda")
+        else:
+            self.pipe = StableDiffusionPipeline.from_pretrained(
+                MODEL_ID,
+                cache_dir=MODEL_CACHE,
+                local_files_only=True,
+            ).to("cuda")

     @torch.inference_mode()
     def predict(

The only other major difference between this and dreambooth-template is that it has a hardcoded scheduler:
    scheduler = DDIMScheduler(
        beta_start=0.00085,
        beta_end=0.012,
        beta_schedule="scaled_linear",
        clip_sample=False,
        set_alpha_to_one=False,
    )

The default scheduler seems to work - although I don't know if those "magic numbers" in the DDIMScheduler in dreambooth-template are to maximize the quality from the dreambooth generations?

With the above patch all you have to do unzip the weights generated by this api https://replicate.com/replicate/dreambooth into cog-stable-diffusion and cog build

Samples of dreambooth weights in cog-stable-diffusion schedulers:

K_EULER - https://replicate.com/p/tl3etpeouzhttlkad4yyzhcsde
DPMSolverMultistep - https://replicate.com/p/5t43x5ytxfekzovctkmibe2o7i
DDIM - https://replicate.com/p/gdfutv6knnev3oypczoqwx2ixa

On the plus side it looks like negative prompts works...
NO BLUE!

https://replicate.com/p/ox5orxd3ubb67mdjp5twcgm6tu
https://replicate.com/p/5cpkw66l3fdizjoiirfhceu6mu
https://replicate.com/p/jytb6qszcjczpd3ovhintpp7m4
https://replicate.com/p/pfm74qiiljdg3kxtvtobfvp24y

(although there is some blue in a couple images)

dreambooth-template

cog-stable-diffusion DDIM scheduler

The only other major difference between this and dreambooth-template is that it has a hardcoded scheduler:
    scheduler = DDIMScheduler(
        beta_start=0.00085,
        beta_end=0.012,
        beta_schedule="scaled_linear",
        clip_sample=False,
        set_alpha_to_one=False,
    )

The default scheduler seems to work - although I don't know if those "magic numbers" in the DDIMScheduler in dreambooth-template are to maximize the quality from the dreambooth generations?

@chenxwh do you know the answer to this?

Opened a PR to default to local pretrained DB weights and fall back to HF: https://github.com/replicate/cog-stable-diffusion/pull/60


added dependency for MTurkRequestError

Seems like there's a new dependency that requires this explicit import for the example in README.md to work.

Good catch. Thanks!


ActiveInstance does not support interceptors/decorators and does not destoy @Dependent dependencies correctly

io.thorntail.ActiveInstance does not support interceptors/decorators as stated in io.thorntail.Thorntail.activate() javadoc. In fact, if you try to "activate" an instance of a class that should be decorated, you'll get java.lang.ClassCastException.
I'm not aware of any way how to support decorators ATM. For interceptors we could probably reuse the code we have for CDI 2.0 InterceptionFactory. However, I'm not sure it is worth the effort.
Furhtermore,  ActiveInstance does not destroy @Dependent dependencies correctly because CreationalContext.release() is not called.

So this isn't doing what I'd hoped?
https://github.com/thorntail/thorntail/blob/4.x/core/kernel/src/main/java/io/thorntail/ActiveInstance.java#L42-L48
I may have discovered that, but then worked around without decorators.  I don't actually recall.

@bobmcwhirter Nope. I have a fix for interceptors. I don't think decorators are that important.

Resolved via #995


Error trying to execute karate tests from the Main folder - Java

All the best!
I am currently developing an api in Java with Javalin, Reactor-core and Guice.
What my api does is expose an endpoint to run some Karate tests.
Because of this, we had to move the Karate folder that was normally found in Test to the Main Folder in order to call it from a main class:
Project structure:
-src
--main
---java
----com.myproject
-----controllers
------Controller.java
-----Main.java
----features
-----Scenario.feature
-----karate-config.js
The way I'm trying to call the karate tests from the Controller.java class is as follows:

public String runTestsParallel() {
    final Results results = Runner.path("./src/main/features")
        .outputCucumberJson(Boolean.TRUE)
        .tags("~@ignore")
        .parallel(10);
    generateReport(results.getReportDir());
    final String errorMessage = String.format(
        "Errors count: %s. Errors messages: %s",
        results.getFailCount(),
        results.getErrorMessages()
    );
    if (results.getFailCount() > 0) {
        throw new IllegalStateException(errorMessage);
    }
    return String.format("ALL TESTS COMPLETED SUCCESSFULLY. %s", errorMessage);
}

private static void generateReport(final String karateOutputPath) {
    final Collection<File> jsonFiles = FileUtils.listFiles(new File(karateOutputPath), new String[] {"json"}, true);
    final List<String> jsonPaths = new ArrayList<>(jsonFiles.size());
    jsonFiles.forEach(file -> jsonPaths.add(file.getAbsolutePath()));
    final Configuration config = new Configuration(new File("target"), "my-project");
    final ReportBuilder reportBuilder = new ReportBuilder(jsonPaths, config);
    reportBuilder.generateReports();
}

This implementation works when I manually run the Main.java class, but when running the app with gradle run I get this error:

Caused by: java.lang.IllegalArgumentException: Could not find option with name js.ecmascript-version.
at com.oracle.truffle.polyglot.PolyglotEngineException.illegalArgument(PolyglotEngineException.java:131)
at com.oracle.truffle.polyglot.OptionValuesImpl.failNotFound(OptionValuesImpl.java:274)
at com.oracle.truffle.polyglot.OptionValuesImpl.failNotFound(OptionValuesImpl.java:274)
at com.oracle.truffle.polyglot.PolyglotContextConfig.findObjectForContextOption(PolyglotContextConfig.java:479)
at com.oracle.truffle.polyglot.PolyglotContextConfig.(PolyglotContextConfig.java:284)
at com.oracle.truffle.polyglot.PolyglotEngineImpl.createContext(PolyglotEngineImpl.java:1732)
at com.oracle.truffle.polyglot.PolyglotEngineDispatch.createContext(PolyglotEngineDispatch.java:162)
at org.graalvm.polyglot.Context$Builder.build(Context.java:1861)
at com.intuit.karate.graal.JsEngine.createContext(JsEngine.java:79)
at com.intuit.karate.graal.JsEngine$1.initialValue(JsEngine.java:63)
at com.intuit.karate.graal.JsEngine$1.initialValue(JsEngine.java:60)
at java.base/java.lang.ThreadLocal.setInitialValue(ThreadLocal.java:195)
at java.base/java.lang.ThreadLocal.get(ThreadLocal.java:172)
at com.intuit.karate.graal.JsEngine.local(JsEngine.java:99)
at com.intuit.karate.report.Report$Builder.build(Report.java:122)
at com.intuit.karate.report.SuiteReports.timelineReport(SuiteReports.java:68)
at com.intuit.karate.Results.(Results.java:98)
at com.intuit.karate.Results.of(Results.java:57)
at com.intuit.karate.Suite.buildResults(Suite.java:384)
at com.intuit.karate.Runner$Builder.parallel(Runner.java:497)

The versions of karate and cucumber that I am using are:

implementation 'com.intuit.karate:karate-junit5:1.3.1'
implementation 'net.masterthought:cucumber-reporting:5.7.4'

I tried to set the environment variable of js.ecmascript-version=11 but it didn't work
Is there any specific configuration that needs to be taken into account for this to work with the gradle run command?

@juanfelipemontoyac never seen this before sounds very specific to your environment. can reopen if you follow this process: https://github.com/karatelabs/karate/wiki/How-to-Submit-an-Issue

Hi @ptrthomas !
Yes, it's a very specific need, but I managed to find the error, that's why I closed the issue.
The problem was in the configuration that I had done for the gradle run task, I just put a default configuration and it works fine!

@juanfelipemontoyac oh okay, glad it works !


Allow disabling sorting with Collections.Get Dictionary Keys/Values

My dict:
{'February 1, 2019': <MainDir.SubDir.Class object at 0x03CE4650>,
'February 4, 2019': <MainDir.SubDir.Class object at 0x03C71490>,
'January 22, 2019': <MainDir.SubDir.Class object at 0x03CD8B90>,
'January 23, 2019': <MainDir.SubDir.Class object at 0x03C710F0>,
'January 24, 2019': <MainDir.SubDir.Class object at 0x03CD8AF0>,
'January 25, 2019': <MainDir.SubDir.Class object at 0x03CD8BF0>,
'January 28, 2019': <MainDir.SubDir.Class object at 0x03CE4370>,
'January 29, 2019': <MainDir.SubDir.Class object at 0x03CE4B70>,
'January 30, 2019': <MainDir.SubDir.Class object at 0x03CE4670>,
'January 31, 2019': <MainDir.SubDir.Class object at 0x03CE4730>}

This is NOT expected behavior. Not any user will expect, that getting values forces sorting!
Approach is anti=pattern, where function should do only one thing
In many cases sort will not work as intended (see the one above -yes, keys are strings, not date, this is intended). What will happen if dict will have object type as key?
User cannot use this keyword without sorting
(This can be solved by simple: Get Dictionary Values  ${dict}  sort=True)

I disagree that sorting is a bad idea or antipattern in this case, but would be fine making it configurable. We actually even have a comment about that in Collections.get_dictionary_keys that get_dictionary_values uses internally. Anyone interested to implement that? Ought to be easy and could be included already in RF 3.1.2.

Hi @1dziubo1 , @pekkaklarck. Could You take a look at #3094 ?

One a very quick look #3094 looks pretty good. No time for real review but I add this issue to RF 3.1.2 scope so that it won't be forgotten.


I18n fallback fails due to submitting the options twice

I18n.translate only expects 2 args

Turns out i18n itself would not fail because it takes args* as a parameter. I'm pretty sure it would not do what it is supposed to do neve the less.


Compiler not yelled at me when assign null value to null-safe variable

Steps to Reproduce
I have this following model or data class after I migrate with dart migrate:
class Article {
  Article({
    required this.author,
    required this.title,
    required this.description,
    required this.url,
    required this.urlToImage,
    required this.publishedAt,
    required this.content,
  });

  String author;
  String title;
  String description;
  String url;
  String urlToImage;
  DateTime publishedAt;
  String content;

  factory Article.fromJson(Map<String, dynamic> json) => Article(
        author: json["author"] == null ? null : json["author"],
        title: json["title"],
        description: json["description"] == null ? null : json["description"],
        url: json["url"],
        urlToImage: json["urlToImage"] == null ? null : json["urlToImage"],
        publishedAt: DateTime.parse(json["publishedAt"]),
        content: json["content"] == null ? null : json["content"],
      );
}

Compiler not telling me error at me after I assigned author: json["author"] == null ? null : json["author"],. So, I feel safe to run my app without checking my code again, until I found out that the app gives me error: type 'Null' is not subtype of type 'String'. But, it still shows error when I directly assign author: null,.
I don't know if it is a valid issue, or I have any misconception about null safety. Will be glad to have new insight about it. Thanks.
Expected results:
Compiler should forbid me because of assigning null value to null-safe variable.
Actual results:
It compiles fine but shows error on the app.

flutter doctor -v
[✓] Flutter (Channel stable, 2.0.5, on Linux, locale en_US.UTF-8)
• Flutter version 2.0.5 at /home/dicoding/opt/flutter
• Framework revision adc687823a (3 weeks ago), 2021-04-16 09:40:20 -0700
• Engine revision b09f014e96
• Dart version 2.12.3
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at /home/dicoding/Android/Sdk
• Platform android-30, build-tools 29.0.2
• Java binary at: /home/dicoding/.local/share/JetBrains/Toolbox/apps/AndroidStudio/ch-0/192.6392135/jre/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
• All Android licenses accepted.
[✓] Chrome - develop for the web
• Chrome at google-chrome
[✓] Linux toolchain - develop for Linux desktop
• clang version 10.0.0-4ubuntu1
• cmake version 3.16.3
• ninja version 1.10.0
• pkg-config version 0.29.1
[✓] Android Studio (version 3.6)
• Android Studio at /home/dicoding/.local/share/JetBrains/Toolbox/apps/AndroidStudio/ch-0/192.6392135
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
[✓] IntelliJ IDEA Ultimate Edition (version 2020.3)
• IntelliJ at /home/dicoding/.local/share/JetBrains/Toolbox/apps/IDEA-U/ch-0/203.5981.41
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin version 201.6668.13
[✓] IntelliJ IDEA Community Edition (version 2020.2)
• IntelliJ at /home/dicoding/.local/share/JetBrains/Toolbox/apps/IDEA-C/ch-0/202.7660.26
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin version 202.8443
[✓] Connected device (3 available)
• AOSP on IA Emulator (mobile) • emulator-5554 • android-x86    • Android 9 (API 28) (emulator)
• Linux (desktop)              • linux         • linux-x64      • Linux
• Chrome (web)                 • chrome        • web-javascript • Google Chrome 90.0.4430.93
• No issues found!

Hi @LittleFireflies
This is an issue with Dart, please file an issue on their GitHub
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


feat: the include-component-in-tag should default to false

Thanks for stopping by to let us know something could be better!
PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.
Is your feature request related to a problem? Please describe.
From google-github-actions/release-please-action#889, this seems should be default to false. The action is default to false, so it is reasonable to set advanced config corresponding to the action.
Describe the solution you'd like
Set the include-component-in-tag default to false.
Describe alternatives you've considered
Set it manully.
Additional context
#2076
Related documents:
https://github.com/googleapis/release-please/blob/72b0ab360c3d6635397e8b02f4d3f9f53932e23c/schemas/config.json#L77-L80
https://github.com/googleapis/release-please/blob/72b0ab360c3d6635397e8b02f4d3f9f53932e23c/docs/manifest-releaser.md?plain=1#L314-L337

This behavior is for historical reasons and changing the default would be a breaking change (and a large disruption to existing users).
Originally, release-please-action was targeted only for single component repositories (i.e. 1 repository : 1 library). So the default behavior was to assume the repository only has a single component and thus have no component name in the created tag. FWIW, https://github.com/google-github-actions/release-please-action/pull/889 was to fix a regression to restore the default to false for the action.
The manifest configuration file was originally only for monorepos that have > 1 component and so the default was to include the component name in the tags.


Add cross-api resource references to all resources

Description of changes:
Adds IAM, KMS and EC2 resource references to all applicable fields
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/lgtm


Missing video in Programming with Text section

"1.3: Getting Text form User: Text Input - Programming with Text" video is missing in the site

I will be working on it.


How to register Data Flow with Eureka?

How to register Spring Cloud Data Flow for CF with eureka?

You will need to checkout the tagged version of the server from github and add the dependency spring-cloud-services-starter-service-registry to the spring-cloud-dataflow-server-cloudfoundry-autoconfig  pom.xml file.  We don't include it by default I believe since a fatal error is thrown if the application can't find the discovery service and we don't want to make it a requirement for deploying SCDF.
The docs (when using the spring cloud services tile are here -
http://docs.pivotal.io/spring-cloud-services/1-3/common/client-dependencies.html#service-registry
If you want to use Eureka outside the spring cloud services tile, then you will need to modify the pom.xml as you would for any app that uses OSS eureka.


Added compose tests

Fixes #601

Build fails with java.lang.IllegalStateException: file:///opt/buildAgent/temp/buildTmp/android-compose-9217210215907867154/settings.gradle.kts:18:1: Unexpected pluginManagementblock found. Only onepluginManagement block is allowed per script.

In any case, this test is not passing completely now


Most paper endpoints are broken.

For example in the Paper.php class:
$endpoint = "https://api.dropboxapi.com/2/docs/download";
should be
$endpoint = "https://api.dropboxapi.com/2/paper/docs/download";

Pushed https://github.com/lukeb2014/Dropbox-v2-PHP-SDK/commit/9c6e7fdce05478611d91c1394d4e7e93a81d1084, please let me know if this fixes the issue.
Luke


Update packaging.yml

There has been no change on LICENSES for PyPI::packaging, which allows us to just increase the version to the current latest number, 23.2.

Thanks for the contribution @brunopacheco1. Could you update the commit message to be a little bit more telling? Like, update to what? (The most recent release.)
See e.g. 7f2f13dc5f75724865de899706328924e4f7338f for how a commit message for a similar case could look like.

@sschuberth Hey, thanks for your reply. Can you please review it again?

@sschuberth Hey, thanks for your reply. Can you please review it again?

Much better, thank you!


Add default to _after_request_fn

If the flask app has a before_request method that shortcuts request execution, the request will not be present in the _current_spans dict but the tracer will still try to finish the span. Adding this default prevents an exception on those calls.

Hi @gravelg , can you please kindly rebase off master?

Sure thing, rebased!

Seems fine with me. Let's see what Carlo thinks.

Hey @gravelg thanks for the PR - this definitely looks fine (we do the same for the Django instrumentation, for example).
But I'm wondering, if the scenario you talk about, is probable another bug (in our side)? If you have a simple test case, I'd love to see it (as to me it sounds you are instrumenting your code and also wrapping some handler of yours through @app.before_request(), which we should handle just fine).
Let me know and I will check ASAP ;)

Hey @carlosalberto, I don't think I'm doing something out of the ordinary, I just have a global before_request method like this:
@app.before_request
    def _before_request():
        # max 10mb body size
        if request.content_length is not None and request.content_length > 10485760:
            return make_response(jsonify({"error_code": "REQUEST_ENTITY_TOO_LARGE",
                                          "error_message": "Request of size {} larger than maximum size of {}".format(
                                              request.content_length, 10485760)}), 413)

This follows the flask docs that say that if a before_request method returns a value, it's interpreted as the return value for the call. This is the case that my PR is trying to fix.

Hey @gravelg thanks for the reply and sorry for the delayed answer.
Nice, I was afraid for a second there was a bug in the actual instrumentation (our side). Would you mind putting a one-line comment (in the code) regarding the situation/condition? After that we can merge it (I'd love to have a note for future maintainers to know in which case we are not having Spans) ;)
Thanks again for the PR (and the patience)!

Lovely, thanks again for the PR and for the patience!


New version: NanoDates v0.1.7

Registering package: NanoDates
Repository: https://github.com/JuliaTime/NanoDates.jl
Created by: @JeffreySarnoff
Version: v0.1.7
Commit: 7c99fa598645b9ca174b87463aceb39710cfe845
Reviewed by: @JeffreySarnoff
Reference: https://github.com/JuliaTime/NanoDates.jl/commit/7c99fa598645b9ca174b87463aceb39710cfe845#commitcomment-92741489
Description: Dates with nanosecond resolved days

delete this, please
replaced by https://github.com/JuliaRegistries/General/pull/73933

Please close this PR without merging.


Participant not disconnected from the Room when pressing the browser back button

Hi,
I'm having some issues with LocalParticipant on pressing the browser back button still being connected to the room even though the docs say:

NOTE:
On some platforms (JavaScript and Swift), Room. disconnect is called automatically when the application exits
Even if I'm trying using useEffect unmount method to try to disconnect myself from the room I can see in the logs I'm connected to that room still.
The interesting thing is by pressing the LIvekit default end call button and doing this:
<LiveKitRoom
onLeave(async () => {
await roomCall?.disconnect();
history.push('/somewhere')
})
/>
I'm disconnected from the rooms so everything is ok, so there might be an issue here @lukasIO @davidzhao  what do you think?

discussed this further with @Mihai-github on slack, he said it's reproducable on example.livekit.io

the “bug” with disconnecting and reconnecting to the room I reproduced it also with the example you guys are hosting over here


Updated twitterSignInRetrieve code to respect who twitter user follows

👍  Thank you Anisha! I look forward to going through this code together Friday morning.


Trying to see if "react": "*" solves the problem with npm >=3.6

It's a solution for the #17
Apparently it's an npm bug, since as per the documentation https://docs.npmjs.com/misc/semver "" (empty string) := * := >=0.0.0 both an empty string and a * must behave the same
Relevant:

https://github.com/npm/npm/issues/11511

@zerkms thx!

@zerkms fixed in v0.9.5


test: get friends of friends

write a test to verify a user's ability to get friends of friends

closing see #20


New Release

Thanks for the plugin
Is it possible to push a new release with the fixes by @binarin?

 I'm going to be fixing the AWS tag support before the next release.

I'm particularity interested in #72 which is a deal breaker for me, but you're right, let's wait for @binarin finish his sprint...

@gmr will there be release cut any time soon?
thanks

@gmr We'd love to use this plugin and leverage the ec2 tags but sadly we're not able to atm due to #75.  Since the fix was merged, any chance on getting a release out soon?

I made an interim release from a fork of master from today that seems to work for me.

@rhoegg I tried to use your interim release, but as soon as I added it to my image, I lost SSH capabilities into the box. Not sure if it is related, but it's the only change I made from one version to the next.

a friendly reminder. there was no new release since June last year.
should we expect for new one anytime soon?

@shamil here you can find the version (0.7.0-rc1) released by the RabbitMQ team

This plugin was forked by the RabbitMQ team and is now part of RabbitMQ. More information can be found @ https://github.com/rabbitmq/rabbitmq-autocluster


fix: Improve katex render performance in responses

Pull Request Checklist

[x] Description: Briefly describe the changes in this pull request.
[x] Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.

[x] Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?

Description
Improve render performance of katex by making ResponseMessage only call katex auto_render on its children, instead of the entire document.
This is much faster since every time a token is received, every ResponseMessage is rendered again.
Related: #1740

Changelog Entry
Fixed

Improved render performance of katex

LGTM, Thanks!


[7.17] [filebeat] add missing rolebing and cluster role rules (#1602)

Backports the following commits to 7.17:

[filebeat] add missing rolebing and cluster role rules (#1602)

ok to test


Make hash_newtype evocative of the output

The API guidelines say macro input should be evocative of the output.
hash_newtype didn't have this property.
This change makes it look exactly like the resulting struct, $len
parameter was removed since it's not needed, reversing is controlled
using an attribute. The macro is also better documented and ready to be
extended in the future.
The tagged SHA256 newtype is not yet modified because it has a more
complicated input parameters.
Closes #1648

Looks good to me!
I'm ambivalent about whether we try to get this in before release. But ACK for now.

@tcharding looks like your nits are mostly about documentation -- ok if I merge this?

@tcharding looks like your nits are mostly about documentation -- ok if I merge this?

Go for it! Thanks for checking.

Oops, looks like we reversed the direction of SegwitV0Sighash here, and possibly others. When reviewing I misread the old macro as being "default to serializing forward" but I think it was actually "default to serializing same as the wrapped type".

Damn! I need to go now so don't have time to investigate, hopefully later.

No worries. We did this almost a year ago and this is the first complaint I've gotten about it (the Liquid team is working through several versions of rust-bitcoin now and reporting problems they bump into). So we can wait a few more days. But we should fix this for 0.32 (or at least, make a deliberate decision for each hashtype).
Unfortunately this'll be a little annoying/tedious to deal with. We probably want to create encoding unit tests for all of the hash types in rust-bitcoin 0.28 and then check that the same test passes today.

I think we should also backport the fix.


add technical committee

Following the steering group committee meeting 22 February 2024, a request to the technical committee should be  done if consensus can't be reached

@yarikoptic @arokem @cmaumet @dorahermes as discussed

can't assign reviewers?? @Remi-Gau @effigies thx

These changes raise more questions than they resolve.
Currently, the governance states:

Upon a successful Draft BEP review, the BEP will be converted from a google document to a markdown file and entered as a pull request on the BIDS standard. This will enable further community feedback on the Proposed BEP. Tools may begin integrating the Proposed BEP specification.
The criteria for merging a Proposed BEP into the BIDS Standard:

Proposal positively reviewed by representative community members. The definition of “representative” will differ depending on the scope of the extension and will be reviewed as part of the steering group’s final approval.
BIDS Steering Group final approval.

This is particularly unclear regarding when a proposal can be deemed as positively reviewed by representative community members, because it doesn't clarify when that review happens. My interpretation is that reviewed here is linked to 'pull-request review', so I interpret that this is applicable in the last PR phase.
The changes make the interpretation of the governance harder: how exactly should If alternative proposals are made among members and no consensus is reached be interpreted? By the looks of the current governance, the procedure is that the proposal must be positively reviewed by representative community members. IMHO, this wants to preempt BEPs from being accepted (PR merged) unless those representative community members deliver a positive review (of the PR, on GitHub). When an alternative proposal becomes an alternative and to which point is just the due discussion over a particular BEP aspect?
Then the you can ask the technical committe to take a decision (BIDS steering group + maintainers) phrasing is really problematic. First, who is you? When this mechanism can be triggered? Can it be triggered before the BEP reaches the PR phase?
However, the most worrying aspect to me is the spirit. This seems intended to shut down conversation and overrule opposing views rather than promote consensus.
Finally, if this is the outcome of the idea to unlock BEP038 that I shared with some representative community members two weeks ago, it doesn't address the issues I raised regarding the transparency of the BEP discussion and how the BEP lifecycle could be improved.

the sterring group decided that the bep leads decide when stuck -- I will add this info

I agree it's out of the scope, but this PR is not applicable if those
problems are not addressed first.
So, either that is addressed in a different PR that gets merged before this
one or else it's addressed within this one.
Otherwise it's adding obscurity to something already unclear.
On Mon, Feb 26, 2024, 22:12 Yaroslav Halchenko @.***>
wrote:

@.**** commented on this pull request.
On docs/assets/img/bep_process.png
https://github.com/bids-standard/bids-extensions/pull/29#discussion_r1503305370
:
all of that IMHO is outside the scope of this PR, which is the
clarification on how to deal with a "stale mate" situation and being unable
to proceed forward. So let's address 1 item at a time.
FWIW, for the background -- one of the examples I used to support such
proposal is https://www.debian.org/devel/tech-ctte to which Debian
project getting referred to in similar cases
—
Reply to this email directly, view it on GitHub
https://github.com/bids-standard/bids-extensions/pull/29#discussion_r1503305370,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAESDRXMGWSB3RHRC4OBZTLYVT3DPAVCNFSM6AAAAABD2PXAYCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMBSGAZDCNZRHE
.
You are receiving this because you commented.Message ID:
@.***>

updated - thx for feedback

why has this moved to draft? this was changes decided by the steering groups and conflicts above were resolved @sappelhoff

this was changes decided by the steering groups

This is incorrect. At most, this may try to reflect decisions by the SG, but it cannot be "changes decided by" because of the simple fact that it is written after the meeting happened, as far as I understand.
There is a great deal of difference between the SG voting on a set of specific changes (i.e., they are written beforehand) and the SG voting on something, and someone then takes care of putting that into writing (which I believe is what happened here).
IMHO (and as expressed in my comments) these changes open more questions than they respond and it would be irresponsible to merge the PR as it is. I also think the SG should decide on a concrete proposal (i.e., revert the workflow described above -- first write the proposal and have the SG vote on the specific changes).

This is a PR reflecting change in the process, which falls under the 'general decisions regarding the standard'. It was discussed by SG to improve that part of the process (along with another PR running along side with one).  Nothing wrong before/after.
I addressed the specific issues raised above. There is nothing I can do about the general comment (people who do not like what an elected group decide should themselves go on being elected). Unless a specific issue that conflicts with the general process, we should move forward.

The SG could not issue a nuanced decision because there was no specific set of changes being proposed. If the SG had made the decision on a specific proposal already commented by the community I would agree the PR would be implementing such a decision.

There is nothing I can do about the general comment

I disagree. My comments warn about negative aspects of these particular changes. As an SG member you should reconsider this and strive for consensus instead of push it without considering.

(people who do not like what an elected group decides should themselves go on being elected)

This is a dangerous view: running to the SG should be a generous decision with the intent of helping BIDS forward instead of a way of passing personal agendas.
In addition, some people run for SG and do not get elected. Some people don't feel they will be able to serve and give BIDS time or guarantee they will act unbiased and they do not run for it.

why has this moved to draft? this was changes decided by the steering groups and conflicts above were resolved @sappelhoff

Based on all posts until here, I was under the impression that this specific proposal (and/or the process in which it is brought forward) needs further discussion before it can be merged, as it seems to be surprising to some.
That's why I converted it to "draft" (and would recommend to do so again).
cc @bids-standard/steering @bids-standard/maintainers

Note that most if not all of this repo will be transferred to the new BIDS website:

bids website repo: https://github.com/bids-standard/bids-website/tree/main
pages from the bids-extension repo as rendered in the website: https://bids-website.readthedocs.io/en/latest/extensions/docs/index.html

If the move is confirmed / community approved, I would suggest closing this PR.


Athletic Strategist RE is incorrect, bad predicates

Reported on Discord 2 years ago and 1 hour ago.
Looks like the predicate needs to only apply for specific athletics actions taken while using a relevant weapon.

I believe there are two things going on here: first, the predicate for Athletic Strategist is trying to use weapon roll options, which are not available when using the Trip action macro, or the athletics skill in general for that matter, so the predicate is never met.
And second, and this part may be a rather recent bug, it looks like the Flat Modifier is suppressing Strength if Intelligence is higher even when the predicate is false.


removed node 7, added node 8

removed node 7, added node 8 from travis testing

Not touching 6 because appliance still supports it?  @chriskacerguis

@AllenBW correct.  I think it is best to always test LTS (which is what the appliance will run) and the latest Node version.


The Antlr dependency is not like the others.  Is that a problem?

I believe all of our non-antlr dependencies are obtained via submodules.  Antlr, on the other hand, is downloaded from github via custom cmake. I think the reasoning behind this discrepancy is that these are the instructions suggested by Antlr itself.  Or perhaps it is that Antlr requires java?
Part of me thinks that having these things be consistent will make it easier to understand and maintain for future developers.  Is there any particular reason we can't have it as a submodule?

Part of the reasoning is the Java dependency.  You don't need to pull in a Java compiler to use the prebuilt JAR tool (just the JRE).  (For reference, the tool is what converts the grammar into C++ code.  There's also the C++ runtime which does the evaluation at runtime.).  As a C++ developer having to install a Java compiler to build a C++ library is a bit of a stretch.
That said it will work as a submodule and we can certainly try it.  Now that we have a version in it'll be easier to compare what happens with a PR.


"Copy to Clipboard' not working

Sorry, for not following the Issue Template as the template was not according to my issue that I want to file. As, I wasn't able to find the repository for https://marketplace.visualstudio.com.
Visiting any extension webpage on marketplace website, there is an option copy to clipboard that copies the execution command that installs the extension to VSCode. That option isn't working. Can we have a fix for that? Or I would like to solve it, if allowed!
For example, https://marketplace.visualstudio.com/items?itemName=danwahlin.angular2-snippets

Seems issue on Marketplace website @kesane-msft FYI

Thanks @KVGarg for reporting. I have created a bug on the Marketplace backlog. Till we roll out the fix, would suggest you to manually copy paste the command. Sorry for the trouble.


Upgrade Rails to <IP_ADDRESS>

See commits for details.

Worth noting that I upgraded to Ruby 2.6.1 as it's the latest version supported by the CloudFoundry Ruby buildpack (1.7.32) - they don't have 2.6.2 yet.


Streaming: Add support for OAuth card to get token to bot

Fixed as part of https://github.com/microsoft/botbuilder-js/pull/1284


Field Conversion Error

So have following scenario:
Below are two classes to convert.

        @Data         class A {                 private String testGooGo;         }

        @Data         class B {                 private String testGooGo;         }
If you run the following code in both classes,
Conversion does not work normally.
`
ModelMapper modelMapper = new ModelMapper();
    A a = new A();
    a.setTestGooGo("abcd");

    B result = modelMapper.map(a, B.class);

`
Can you solve this problem?
Junhoi

Thanks for the report.
I think this was really a bug that ModelMapper didn't think the source's testGooGo and the destination's testGooGo match.
The workaround before I fixed this please use PropertyMap if you are urgent with this case.
modelMapper.addMappings(new PropertyMap<A, B> {
  public void configure() {
    map().setTestGooGo(source.getTestGooGo());
  }
});

@jungrammer - This had been release at modelmapper v1.0.0!


I'm getting build error

This is the error I"m getting
Severity	Code	Description	Project	File	Line	Suppression State
Error		The project file "............\source\XamarinForms\Xamarin.Auth.Forms\Xamarin.Auth.Forms.csproj" was not found.	ComicBook
Severity	Code	Description	Project	File	Line	Suppression State
Error		The project file "............\source\Xamarin.Auth.Portable\Xamarin.Auth.Portable.csproj" was not found.	ComicBook

What are you trying to build?

I'm trying to build Evolve16Labs project

And I cant find "............\source\XamarinForms\Xamarin.Auth.Forms\Xamarin.Auth.Forms.csproj" anywhere in my project.

I have posted it on https://forums.xamarin.com/discussion/comment/327047#Comment_327047 aswell. Still no fix.

Sorry it was a simple mistake i didn't see  Xamarin.Auth.Forms and Xamarin.Auth.Portable in my reference. I removed these file and it worked successfully.

hey @moljac  why I'm getting github page when I'm clicking on google oauth. Will i get google authorization in this your app.

Samples are being rewritten as part of the current job of work


Not mobile responsive

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
The current website is not mobile responsive make it responsive
Add ScreenShots
No response
What browsers are you seeing the problem on?
No response
Record

[X] I agree to follow this project's Code of Conduct
[ ] I'm a GSSOC contributor
[ ] I want to work on this issue
[X] I'm willing to provide further clarification or assistance if needed.

I would like to work Pls assign it to me


[Trappist on Rococo] Add pallet for maintenance mode

Add a pallet to Trappist's runtime to allow for a maintenance (aka emergency) mode.
Moonbeam and Acala, among others, have a similar feature.

I have analyzed both pallets and my vote goes for Moonbeam since seems to be more generic and better structured.
It also contains XCMP handles.

Maintenance mode pallet spec
The pallet logic itself will be very basic and it will just expose two extrinsics that will handle the on/off property for the maintenance mode. But the specific part goes in the impls exposed from the pallet. The traits implementations frame_support::traits::Contains and cumulus_primitives_core::DmpMessageHandler will help to a list of defined runtime calls and XCM messages respectively:
Runtime Call Filtering (Contains<RuntimeCall>)
The Contains<RuntimeCall> trait implementation twill be set to be used by the the BaseCallFilter feature of the frame_system pallet. The logic is not hard to follow:
	impl<T: Config> Contains<T::RuntimeCall> for Pallet<T> {
		fn contains(call: &T::RuntimeCall) -> bool {
			if MaintenanceMode::<T>::get() {
				T::FilteredCalls::contains(call)
			}  else {
                             return false;
                         }
		}
	}

From the runtime the FilteredCalls type will be provided to the pallet so we can filter which calls we want:
pub struct RuntimeFilteredCalls;
impl Contains<RuntimeCall> for RuntimeFilteredCalls {
	fn contains(call: &RuntimeCall) -> bool {
		match call {
			RuntimeCall::Assets(method) => match method {
				pallet_assets::Call::transfer { .. } => true,
				pallet_assets::Call::transfer_keep_alive { .. } => true,
                                  ...
				_ => false,
			},
	                ....
		}
	}
}

XCM messages (cumulus_primitives_core::DmpMessageHandler)
From the XCM messages perspective, the DMP Queue messages will be filtered by relying on the cumulus_primitives_core::DmpMessageHandler::handle_dmp_messages(iter, limit). By providing Weight::zero() to the second argument, basically the  messages are queued for next iteration.
From the runtime perspective, the struct MaintenanceDmpHandler will be a wrapper of the DmpQueue::handle_dmp_messages and it will be provided as a type to the pallet:
pub struct MaintenanceDmpHandler;
impl DmpMessageHandler for MaintenanceDmpHandler {
	fn handle_dmp_messages(
		iter: impl Iterator<Item = (RelayBlockNumber, Vec<u8>)>,
		limit: Weight,
	) -> Weight {
		DmpQueue::handle_dmp_messages(iter,limit)
	}
}

Then from the pallet side, the DmpMessageHandler will use the MaintenanceDmpHandler in the following way:
	impl<T: Config> DmpMessageHandler for Pallet<T> {
		fn handle_dmp_messages(
			iter: impl Iterator<Item = (RelayBlockNumber, Vec<u8>)>,
			limit: Weight,
		) -> Weight {
			if MaintenanceMode::<T>::get() {
				T::MaintenanceDmpHandler::handle_dmp_messages(iter, Weight::zero())
			} else {
				T::MaintenanceDmpHandler::handle_dmp_messages(iter, limit)
			}
		}
	}

Pallet adjustments over the runtime

construct_runtime! {
	pub enum Runtime where
		Block = Block,
		NodeBlock = opaque::Block,
		UncheckedExtrinsic = UncheckedExtrinsic
	{
                	MaintenanceMode: pallet_maintenance_mode::{Pallet, Call, Config, Storage, Event} = 50,
         }
}

impl frame_system::Config for Runtime {
        ...
	type BaseCallFilter = MaintenanceMode;
        ...
}

impl cumulus_pallet_parachain_system::Config for Runtime {
	...
	type DmpMessageHandler = MaintenanceMode;
        ...
}

Transaction pool
Finally we should filter as well the calls in the transaction pool so they are not included during the maintenance:
	impl sp_transaction_pool::runtime_api::TaggedTransactionQueue<Block> for Runtime {
		fn validate_transaction(
			source: TransactionSource,
			tx: <Block as BlockT>::Extrinsic,
			block_hash: <Block as BlockT>::Hash,
		) -> TransactionValidity {
			if !<Runtime as frame_system::Config>::BaseCallFilter::contains(&xt.0.function) {
				return InvalidTransaction::Call.into();
			}
			Executive::validate_transaction(source, tx, block_hash)

		}
	}

CC: @stiiifff

@hbulgarini Looks good, thanks for spec-ing this out before.

	impl<T: Config> Contains<T::RuntimeCall> for Pallet<T> {
		fn contains(call: &T::RuntimeCall) -> bool {
			if MaintenanceMode::<T>::get() {
				T::FilteredCalls::contains(call)
			}  else {
                             return false; // <-- should be true here if you are whitelisting
                         }
		}
	}

Would it be useful to be able to select which pallets/calls are whitelisted when the Lockdown mode is active? This feature would enable us to gradually enable pallets during testing and isolate any problematic pallets for individual testing purposes.
By selectively choosing which pallets are allowed in the whitelist, we can thoroughly test the node as we progressively enable more pallets.
I was just thinking about it, but I'm not fully sure how much extra value it would provide to the pallet.


chore: add redirect for old docs link to message types

Description
Fix broken link to message types docs with a redirect

Update: Original broken link has been updated in Control


AUI-1900

Hey @mairatma,
Attached is an update for http://issues.liferay.com/browse/AUI-1900.
Please let me know if you have any questions.
Thanks!

Just started reviewing :) :octocat: Sent from GH.


Updated section for reporting

Removed redundant sections

@chrisda and @MSFTTracyP could you please approve this for me?

@MSFTTracyP, formatting, spelling, etc. are OK for me. Do you have any SEO input regarding 'questionalbe' vs. 'suspect' vs. something potentially better we should use?


Editor.cursorSurroundingLines broken with update to 1.86

Type: Bug
After updating to 1.86, the editor always gives a minimum of 5 context lines above the cursor rather than the value set in editor.cursorSurroundingLines. I confirmed this by downgrading to 1.85.2, and the setting worked as expected. I upgraded again to 1.86 and disabled all extensions, and the problem still exists. Setting editor.cursorSurroundingLines to numbers higher than 5 works as expected, and numbers lower than 5 work below the cursor as expected, just not above it.

I'm having the same issue with vscode 1.87.1

This is still present in v1.87.2 (863d2581ec).

This is still present in:
Version: 1.88.1
Commit: e170252f762678dec6ca2cc69aba1570769a5d39
Date: 2024-04-10T17:43:08.196Z
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Darwin arm64 23.4.0

This bug is still present in:
Version: 1.89.1
Commit: dc96b837cf6bb4af9cd736aa3af08cf8279f7685
Date: 2024-05-07T05:16:23.416Z
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Linux x64 6.8.9-200.fc39.x86_64

I guess this is conflict with Sticky Scroll. When I disabled it, the surrounding lines setting become working.

good find. turning sticky scroll off helped. thanks.

it was making me crazy for months! i was for so long looking for the source of the issue!
for giving more context on how to reproduce it:

show the bottom panel
make it bigger than the center of the screen
start typing
you are typing in the centered line which is over the editor viewport, so you don't see anymore what are you typing. it looks like the center line is calculated without considering the bottom panel height

another issue the original one mentioned from the guys (already considering cursorSurroundingLines and scrollBeyondLastLine, which are unrelated to what i want to say):

use the keyboard arrows for for moving the cursor up and down
you should now have the ability to scroll up and down
the last line is correct
while the first line appears to be in the center of the screen when the editor starts to scroll already (it should to be on the first visible line instead, with cursorSurroundingLines: 0)

tested in a sandbox with a fresh installation

The bug is still present I have to deactivate sticky scroll (editor.stickyScroll.enabled)
Version: 1.92.1 (Universal)
Commit: eaa41d57266683296de7d118f574d0c2652e1fc4
Date: 2024-08-07T20:16:39.455Z
Electron: 30.1.2
ElectronBuildId: 9870757
Chromium: 124.0.6367.243
Node.js: 20.14.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 23.2.0

I continue to see this frustrating bug. The line the cursor is on falls outside the viewport of the editor when the editor height is below a certain threshold. Exactly as described above by iannacone. You can muck around with the "editor.stickyScroll.maxLineCount" setting to change this threshold or completely disable Sticky Scroll, but those are not optimal solutions.
Version: 1.93.0-insider
Commit: 26a90463972295bcb960b7487a7c69afa06626eb
Date: 2024-08-19T10:25:17.637Z
Electron: 30.3.1
ElectronBuildId: 9960165
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22631


Scope CSS code

Pull Request Description

Fix #10470

Fix scoped styles for GUI
Add scoping back to dashboard's Tailwind styles

Important Notes
None
Testing instructions

All visualizations (and the checkbox widget) should be tested.
On the dashboard side:

The settings sidebar should no longer be incorrectly hidden
The "upgrade" button on the top right should not be a hyperlink

Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] The documentation has been updated, if necessary.
[x] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[x] All code follows the
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
[x] Unit tests have been written where possible.

dunno whether inlining base.css is the best option, but :deep() does not seem to work in imports (of course)
and idk whether there's a way to nest an import...


Viewer hangs and eventually does not respond

When reading files that are greater than a thousand kilobytes, the viewer becomes unresponsive for a few seconds, eventually not responding at all.

What are the dimensions of the tables you want to load?

I can reproduce the issue. It seems like a bug. I will try to fix this within the next days.


Adding a versionintroduced variable to the frontmatter of connector pages

Adding versionintroduced variable to frontmatter of connector pages, and updating the single.html file to display a "Since v0.0.0" message if it is set.
I don't know when each connector was introduced, so @sagikazarmark, @nabokihms please suggest one using the  ```suggest notation for each of the files updated.
closes: https://github.com/dexidp/website/issues/92

Deploy preview:

Since visible: https://deploy-preview-93--dexidp.netlify.app/docs/connectors/ldap/
Since not present: https://deploy-preview-93--dexidp.netlify.app/docs/connectors/

last force-push uses a sane if statement 😅

I have a question. Do we want to change the version in this field if we changed the config of the connector, e.g., added a new option?
For example, the LDAP connector was added a long time ago, but in the release v2.23.0 its settings were rearranged. Thus, documentation on the website is only valid since dex v2.23.0.

I had the following in mind:

add a since version "badge" to pages
add "badges" within pages for new features

I think that would answer your question @nabokihms
Also, I don't think we have to add it to every page/connector.

So something that could be added (almost like a label) next to a line of copy or a paragraph?

Either that, or something like this on the Symfony website: https://symfony.com/doc/current/routing.html

I understand now.
On their site, the following
.. versionadded:: 5.2

    The ability to use PHP attributes to configure routes was introduced in
    Symfony 5.2. Prior to this, Doctrine Annotations were the only way to
    annotate controller actions with routing configuration.

generates this

I like that, but it's a bit more involved. I think I can piggyback off the note or warning annotations to achieve this. (We may want to pull them (notes and warnings) in from upstream as well, but that's probably a separate issue)

Yeah, something like that would be great. I think we can create custom shortcodes/snippets in Hugo.
For example, a custom version admonition could accept a version as a parameter and use that internally to compare it to the current version in the config file. I don't know if Hugo templates has a semver function for that though.
This is still very much just an idea, so if there are other, better patterns out there, I'm all ears.

@nate-double-u I started something very simple in #132
Do you think you could help finishing it (adding some style, etc)

Hi--I'm on vacation this week, but can take a look when I'm back 🙂

I'm going to close this PR. Now we've moved to Docsy we'd need a different implementation I think.


Use Helm mode by default

The time has come.

success

✅ EKS (tunnel) https://github.com/cilium/cilium-cli/actions/runs/5367480115?pr=1762
✅ EKS (ENI) https://github.com/cilium/cilium-cli/actions/runs/5367480117?pr=1762

time to 🚀


Commander: Fall back to GPS enabled modes once GPS becomes available

Replaced by https://github.com/PX4/Firmware/pull/6595


Split.IO Add 2024-07-01-preview

ARM (Control Plane) API Specification Update Pull Request

[!TIP]
Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.
[x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix OpenAPI spec quality issues in S360.
[ ] Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

 Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Pl fix the Typespec validation and model validation failures

@rkmanda I don't think the model validation failure is right.

The latest typespec update makes Update parameters a tracked resource that requires "location" property, which doesn't make sense for update parameters. Since we don't support update of region.
Even after I added location to the example, the model validation still fails and suggests me to add location inside the properties of Update parameter

@hahahahahaiyiwen Can you fix the ModelValidation failure? There're still two violations.

/azp run

/pr merge


Fix build status badge img src, link on README.md

Found Travis build status badge in README.md unknown.
Modify the src and link of the badge image in README.md.

Closing in favor of https://github.com/toptal/gitignore.io/pull/507


[Blitz] AdaBoost ensemble

Closed, but added #1606 to track adding AdaBoost once other design considerations have been made :)


CDPD-34514: DataHub compaction configs update

CDPD-34041: Standardize compaction configuration across all form factors

Thanks!


Response BlackList

Coverage remained the same at 100.0% when pulling 8c8964ad485b289294a6844cc9aba0f136c38f18 on black-response-list into ac179407764d6ae8b934ed9aa08125cd2598fca3 on master.