Run management command in tox.

Run the celery management command, to detect breakage there.
This should be more exaustive (though I'm not sure which commands will work with the celery config here?), it should be enough to check if the management command fails.
This is to try and detect bugs like #573
It looks like there have been similar bugs recently in the tracker too.
NOTE:  I can't run tox here to see if this works.
This fails in tox, so seems to be correct.

Hi,
This will fails, but only because the management command is broken.
S

can help to fix the management command as well

can help to fix the management command as well


Better transparent proxying support

I spent a little bit of time looking at how redsocks supports transparent proxying of all TCP to a SOCKS proxy, and the code is really quite straight forward: https://github.com/darkk/redsocks/blob/2e3f648809e27cc19cb7a8702f19b553a7ef9a81/base.c#L102
I was hoping this could be integrated into mitmproxy to allow better transparent proxying.
I'm looking to use mitmproxy to see/alter the data that malware running inside a VM gets (with the MITM script being different for each of my 25 VMs) and at the moment the only real way I can do this is to setup 25 separate ip tables, run 25 instances of redsocks and 25 instances of mitmproxy.
This is all doable, but I would much rather configure 1 iptable, run 1 instance of mitmproxy and have a script that alters its behaviour based on the source IP.
I'm happy to write the patch myself is anyone has any pointers on how to integrate it with the existing codebase.

Hi there. It sounds like you have a very interesting project going there. Let me try to understand exactly what the limitation is that you're working around, here. If you're using NAT, we already have a set of platform modules that will extract the original address from the host translation table:
https://github.com/mitmproxy/mitmproxy/tree/master/libmproxy/platform
The particular function you linked to above is for ipf - if you're using iptables, the matching redsocks function is here:
https://github.com/darkk/redsocks/blob/2e3f648809e27cc19cb7a8702f19b553a7ef9a81/base.c#L211
You can see from our host module, that we do almost exactly the same thing:
https://github.com/mitmproxy/mitmproxy/blob/master/libmproxy/platform/linux.py
So, if you have a set of VMs with traffic redirected into mitmproxy, and mitmproxy is run in transparent mode, you should already have all the pieces to have a single script that alters behaviour based on the source address.
I'm sure I'm missing something here, but what? :)

You know, I think I just missed that in the docs, sorry about that. This looks like it solves my problem perfectly.

Great. Let me know if you hit any other hurdles.


Nexus 5 Android M Preview 3

When recording video on Nexus 5 Android M Preview 3 the video file that results is empty (0 bytes in length).

Do you still encounter this with the consumer release of Android 6.0?

I run into this issue with released Android 6.0 and latest Camera2Video on a Nexus 5.

Seeing the same issue.

This sample has been migrated to a new location where we can accept Pull Requests (check README for more information).
As recommended by GitHub, we are closing all issues and pull requests now that this older repo will be archived.
If you still see this issue in the updated repo, please reopen the issue/PR there. Thank you!


Status fields should be public: they are currently private

Describe the bug
The file paddle-php-sdk\src\Entities\Shared\Status.php has private "Active" and "Archived" fields when they should be public
Steps to reproduce
Try to list products by using the specific status const
Expected behavior
The fields should be accessible as public
Code snippets
No response
PHP version
PHP 8.2
SDK version
1.20
API version
Paddle Version 1
Additional context
No response

Understood. Thanks.
In that case, shouldn't the "Prices" const in paddle-php-sdk\src\Resources\Products\Operations\List\Includes.php be private then ?

Indeed those consts do look to have the incorrect visibility. It would not impact the functionality here with the static method still being the expected usage, however it's possible due to the array usage on the operation that a consumer would expect to pass in the string constant value instead of the enum instance. We'll use this issue to track ensuring the enums consts have the correct visibility throughout the package 👍
Thanks for spotting this.


HBASE-25447 remoteProc is suspended due to OOM ERROR

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 16s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  3s
master passed

+1 :green_heart:
checkstyle
1m 27s
master passed

+1 :green_heart:
spotbugs
2m 42s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 53s
the patch passed

+1 :green_heart:
checkstyle
1m 24s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
19m  6s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
2m 59s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 22s
The patch does not generate ASF License warnings.

45m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2824

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 65cff0148f54 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d963342f8a

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 40s
master passed

+1 :green_heart:
compile
1m 17s
master passed

+1 :green_heart:
shadedjars
6m 34s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 54s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 27s
the patch passed

+1 :green_heart:
compile
1m 14s
the patch passed

+1 :green_heart:
javac
1m 14s
the patch passed

+1 :green_heart:
shadedjars
6m 33s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 51s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 50s
hbase-procedure in the patch passed.

+1 :green_heart:
unit
139m  4s
hbase-server in the patch passed.

169m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2824

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 43ff844eeba9 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d963342f8a

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/1/testReport/

Max. process+thread count
4695 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 14s
master passed

+1 :green_heart:
compile
1m 27s
master passed

+1 :green_heart:
shadedjars
7m  4s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  2s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  5s
the patch passed

+1 :green_heart:
compile
1m 33s
the patch passed

+1 :green_heart:
javac
1m 33s
the patch passed

+1 :green_heart:
shadedjars
6m 50s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 57s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 44s
hbase-procedure in the patch passed.

+1 :green_heart:
unit
146m 30s
hbase-server in the patch passed.

178m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2824

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2474440aa7ed 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d963342f8a

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/1/testReport/

Max. process+thread count
3848 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

In general, if there is an OOME, we can not assume that our handler can still be executed correctly, as we do not know where is the OOME thrown out, it may break the assumptions in our code and cause unexpected behavior.
IIRC, we have '-XX:OnOutOfMemoryError="kill -9 %p"' in our command line when start daemons? It does not work in your deployment?
Thanks.

In general, if there is an OOME, we can not assume that our handler can still be executed correctly, as we do not know where is the OOME thrown out, it may break the assumptions in our code and cause unexpected behavior.
IIRC, we have '-XX:OnOutOfMemoryError="kill -9 %p"' in our command line when start daemons? It does not work in your deployment?
Thanks.
we can enhance OutOfMemoryError, if some users do not use '-XX:OnOutOfMemoryError="kill -9 %p"', or TimeOutThread exits due to other reasons, master should be able to abort...

Have we observed errors other than OOME which cause the TimeoutExecutorThread to hang there?

Have we observed errors other than OOME which cause the TimeoutExecutorThread to hang there?

now, we have not seen anything else except OOM,  but we think there are other errors

In general, if there is an OOME, we can not assume that our handler can still be executed correctly, as we do not know where is the OOME thrown out, it may break the assumptions in our code and cause unexpected behavior.
IIRC, we have '-XX:OnOutOfMemoryError="kill -9 %p"' in our command line when start daemons? It does not work in your deployment?
Thanks.

and in our env, -XX:OnOutOfMemoryError="kill -9 %p" exists...
https://github.com/apache/hbase/blob/c96fbf04077fa37555033f88939fdd69ac810b35/bin/hbase#L811

In general, if there is an OOME, we can not assume that our handler can still be executed correctly, as we do not know where is the OOME thrown out, it may break the assumptions in our code and cause unexpected behavior.
IIRC, we have '-XX:OnOutOfMemoryError="kill -9 %p"' in our command line when start daemons? It does not work in your deployment?
Thanks.

and in our env, when OOME occurs, -XX:OnOutOfMemoryError="kill -9 %p" exists, but active master is not stopped.
https://github.com/apache/hbase/blob/c96fbf04077fa37555033f88939fdd69ac810b35/bin/hbase#L811

So we need to find out why this opinion does not work first? OOME can happen at any place and break the assumptions in code, there is no way to fix it cleanly just by adding more checks in code...

So we need to find out why this opinion does not work first? OOME can happen at any place and break the assumptions in code, there is no way to fix it cleanly just by adding more checks in code...

ok, mybe -XX:OnOutOfMemoryError="kill -9 %p",
if there is no '', jvm executes kill instead of "kill -9 pid" when oom occurs.

i tested unable to "create new native thread" by "ulimit -u 100",
but jvm didn't stop..

So the problem is OnOutOfMemoryError flag does not work for "Unable to create new native thread"?

I guess the problem is that, since you set ulimit to a very low value, once there is no new thred allowed, the 'kill' command itself can not be executed either...

https://www.codementor.io/@suryab/outofmemoryerror-related-jvm-arguments-w6e4vgipt

I guess the problem is that, since you set ulimit to a very low value, once there is no new thred allowed, the 'kill' command itself can not be executed either...

but I can "kill -9" it manually...
steps:

ulimit -u 100
hbase  com.xxxx.xxx.xxx.Test &
Wait for "unable to create new native thread" to be printed.
kill -9 pid

Could you please try other options to see if it works?

I guess the problem is that, since you set ulimit to a very low value, once there is no new thred allowed, the 'kill' command itself can not be executed either...

if this,  in hbase, the 'kill' command itself can not be executed either

Could you please try other options to see if it works?

i will continue to analyze. thank you @Apache9

I guess the problem is that, since you set ulimit to a very low value, once there is no new thred allowed, the 'kill' command itself can not be executed either...

if this, in hbase, the 'kill' command itself can not be executed either

Yes, I think this is the root problem here. We need to find a way to kill the hbase process if OOME happens, not only for TimeoutExecutor.

Agree. If OOME, process should go down... die. We can't keep going. It is a fatal condition.

analyze and verify the java native code, some OMME do not cause the JVM to exit, like "java.lang.OutOfMemoryError: Direct buffer memory", "java.lang.OutOfMemoryError: unable to create new native thread", they dont call vmError#next_OnError_command.

According to the communication with the maintenance, this problem that jvm does not exit exists in many OS components. No better solution is available.

if we don't have a better way to solve the issue or circumvent the issue, we can fix timeoutThread first, and at least the Proc is correct.

if we don't have a better way to solve the issue or circumvent the issue, we can fix timeoutThread first, and at least the Proc is correct.

OK. Then since TimeoutExecutor is just a Thread, I suggest we use uncaughtExceptionHandler to deal with this? If we hit an uncaught exception, we abort master. It will be cleaner than the current solution.
Thanks.

when throw "unable to create new native thread", the Thread does not run, uncaughtExceptionHandler is invalid.

According to the JVM specifications, the subsequent actions of OOM are "undefined behaviors", that is, after OOM occurs, it is uncertain what must be or will not be done.
https://stackoverflow.com/questions/7606953/behavior-of-a-java-process-in-case-of-outofmemoryerror

when throw "unable to create new native thread", the Thread does not run, jvm does not call uncaughtExceptionHandler

I do not get your point here. The current PR is to catch Throwable inside the run method of the TimeoutExecutor, which means it has already been started? Did I miss something?

when throw "unable to create new native thread", the Thread does not run, jvm does not call uncaughtExceptionHandler

I do not get your point here. The current PR is to catch Throwable inside the run method of the TimeoutExecutor, which means it has already been started? Did I miss something?

TimeoutExecutor is ok,  the new thread is created in the threadPool and fails to be created,  the threadPool passed the OOME to the TimeoutExecutor#run

when throw "unable to create new native thread", the Thread does not run, jvm does not call uncaughtExceptionHandler

I do not get your point here. The current PR is to catch Throwable inside the run method of the TimeoutExecutor, which means it has already been started? Did I miss something?

TimeoutExecutor is ok, the new thread is created in the threadPool and fails to be created, the threadPool passed the OOME to the TimeoutExecutor#run

So I suggest you to call setUncaughtExceptionHandler on TimeoutExecutor...

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m 43s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 30s
master passed

+1 :green_heart:
checkstyle
1m 36s
master passed

+1 :green_heart:
spotbugs
3m  6s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 19s
the patch passed

+1 :green_heart:
checkstyle
1m 35s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
20m 13s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
2m 47s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

52m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2824

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 7cb487035689 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / fbf00f9c28

Max. process+thread count
94 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 23s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  2s
master passed

+1 :green_heart:
compile
1m 17s
master passed

+1 :green_heart:
shadedjars
7m 10s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 54s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 55s
the patch passed

+1 :green_heart:
compile
1m 17s
the patch passed

+1 :green_heart:
javac
1m 17s
the patch passed

+1 :green_heart:
shadedjars
7m  5s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 51s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 55s
hbase-procedure in the patch passed.

+1 :green_heart:
unit
227m 20s
hbase-server in the patch passed.

259m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2824

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 11abd3b1dd93 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / fbf00f9c28

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/2/testReport/

Max. process+thread count
3245 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

I like how this PR is coming along.

I like how this PR is coming along.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 54s
master passed

+1 :green_heart:
checkstyle
1m 24s
master passed

+1 :green_heart:
spotbugs
2m 42s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 42s
the patch passed

+1 :green_heart:
checkstyle
1m 22s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 51s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
3m  3s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 24s
The patch does not generate ASF License warnings.

43m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2824

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 2e97a08b9c6d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2e21da7597

Max. process+thread count
94 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/3/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 54s
master passed

+1 :green_heart:
checkstyle
1m 24s
master passed

+1 :green_heart:
spotbugs
2m 42s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 42s
the patch passed

+1 :green_heart:
checkstyle
1m 22s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 51s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
3m  3s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 24s
The patch does not generate ASF License warnings.

43m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2824

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 2e97a08b9c6d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2e21da7597

Max. process+thread count
94 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/3/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 57s
master passed

+1 :green_heart:
compile
1m 29s
master passed

+1 :green_heart:
shadedjars
6m 43s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  8s
the patch passed

+1 :green_heart:
compile
1m 28s
the patch passed

+1 :green_heart:
javac
1m 28s
the patch passed

+1 :green_heart:
shadedjars
6m 42s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 42s
hbase-procedure in the patch passed.

+1 :green_heart:
unit
131m  6s
hbase-server in the patch passed.

162m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2824

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2f63615f31cd 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2e21da7597

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/3/testReport/

Max. process+thread count
3938 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 28s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 57s
master passed

+1 :green_heart:
compile
1m 29s
master passed

+1 :green_heart:
shadedjars
6m 43s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  8s
the patch passed

+1 :green_heart:
compile
1m 28s
the patch passed

+1 :green_heart:
javac
1m 28s
the patch passed

+1 :green_heart:
shadedjars
6m 42s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 42s
hbase-procedure in the patch passed.

+1 :green_heart:
unit
131m  6s
hbase-server in the patch passed.

162m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2824

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2f63615f31cd 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2e21da7597

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/3/testReport/

Max. process+thread count
3938 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 18s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 41s
master passed

+1 :green_heart:
compile
1m 16s
master passed

+1 :green_heart:
shadedjars
6m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 54s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 26s
the patch passed

+1 :green_heart:
compile
1m 15s
the patch passed

+1 :green_heart:
javac
1m 15s
the patch passed

+1 :green_heart:
shadedjars
6m 32s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 52s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 48s
hbase-procedure in the patch passed.

+1 :green_heart:
unit
139m 14s
hbase-server in the patch passed.

169m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2824

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 85be80d4c01b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2e21da7597

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/3/testReport/

Max. process+thread count
4493 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 18s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 41s
master passed

+1 :green_heart:
compile
1m 16s
master passed

+1 :green_heart:
shadedjars
6m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 54s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 26s
the patch passed

+1 :green_heart:
compile
1m 15s
the patch passed

+1 :green_heart:
javac
1m 15s
the patch passed

+1 :green_heart:
shadedjars
6m 32s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 52s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 48s
hbase-procedure in the patch passed.

+1 :green_heart:
unit
139m 14s
hbase-server in the patch passed.

169m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2824

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 85be80d4c01b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2e21da7597

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/3/testReport/

Max. process+thread count
4493 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 49s
master passed

+1 :green_heart:
checkstyle
1m 19s
master passed

+1 :green_heart:
spotbugs
2m 33s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 26s
the patch passed

+1 :green_heart:
checkstyle
1m 17s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 29s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
2m 50s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

41m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2824

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux daf28bc2bf60 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2e21da7597

Max. process+thread count
94 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/4/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 49s
master passed

+1 :green_heart:
checkstyle
1m 19s
master passed

+1 :green_heart:
spotbugs
2m 33s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 26s
the patch passed

+1 :green_heart:
checkstyle
1m 17s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 29s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
2m 50s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

41m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2824

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux daf28bc2bf60 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2e21da7597

Max. process+thread count
94 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/4/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  1s
master passed

+1 :green_heart:
compile
1m 28s
master passed

+1 :green_heart:
shadedjars
6m 40s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 59s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  3s
the patch passed

+1 :green_heart:
compile
1m 27s
the patch passed

+1 :green_heart:
javac
1m 27s
the patch passed

+1 :green_heart:
shadedjars
6m 40s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 43s
hbase-procedure in the patch passed.

+1 :green_heart:
unit
130m 42s
hbase-server in the patch passed.

162m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2824

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux eea1d7f9dab5 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2e21da7597

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/4/testReport/

Max. process+thread count
4078 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  1s
master passed

+1 :green_heart:
compile
1m 28s
master passed

+1 :green_heart:
shadedjars
6m 40s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 59s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  3s
the patch passed

+1 :green_heart:
compile
1m 27s
the patch passed

+1 :green_heart:
javac
1m 27s
the patch passed

+1 :green_heart:
shadedjars
6m 40s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 58s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 43s
hbase-procedure in the patch passed.

+1 :green_heart:
unit
130m 42s
hbase-server in the patch passed.

162m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2824

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux eea1d7f9dab5 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2e21da7597

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/4/testReport/

Max. process+thread count
4078 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 31s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 30s
master passed

+1 :green_heart:
compile
1m 17s
master passed

+1 :green_heart:
shadedjars
6m 37s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 53s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 26s
the patch passed

+1 :green_heart:
compile
1m 17s
the patch passed

+1 :green_heart:
javac
1m 17s
the patch passed

+1 :green_heart:
shadedjars
6m 35s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 53s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 49s
hbase-procedure in the patch passed.

+1 :green_heart:
unit
138m 44s
hbase-server in the patch passed.

168m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2824

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3c3e065def05 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2e21da7597

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/4/testReport/

Max. process+thread count
4599 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 31s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 30s
master passed

+1 :green_heart:
compile
1m 17s
master passed

+1 :green_heart:
shadedjars
6m 37s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 53s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 26s
the patch passed

+1 :green_heart:
compile
1m 17s
the patch passed

+1 :green_heart:
javac
1m 17s
the patch passed

+1 :green_heart:
shadedjars
6m 35s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 53s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 49s
hbase-procedure in the patch passed.

+1 :green_heart:
unit
138m 44s
hbase-server in the patch passed.

168m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2824

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3c3e065def05 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2e21da7597

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/4/testReport/

Max. process+thread count
4599 (vs. ulimit of 30000)

modules
C: hbase-procedure hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

thank all for reviewing the code

thank all for reviewing the code


Where clauses and other Chalk improvements

This adds support for where clauses to the Chalk integration; it also adds FnDef lowering and partly handles auto traits.
One thing I'm not sure about is the error handling -- what do we do if we can't
resolve a trait reference in a where clause? For impls, I think it's clear we
need to disregard the impl for trait solving. I've solved this for now by
introducing an 'unknown trait' that has no impls, so if we encounter an unknown
trait we can use that and basically get a where clause that's always false. (The
alternative would be somehow not returning the impl to Chalk at all, but we
would need to know that we need to do that in impls_for_trait already, and we
don't resolve anything there.)
A bit surprisingly, this has almost no impact on the type inference stats for RA, probably because of missing edge cases. Probably impl Trait support and closure support will do more.

Hmm I forgot to handle inline bounds (as in impl<T: Foo>), which results in a few too many blanket impls. I should add that before this is merged :sweat_smile:

Hmm that causes us to become very slow while type-checking collect_tests... I'll need to look into that.

Presumably, this is ready?
bors r+

Well, it's going to be very slow in some cases without Chalk fuel :sweat_smile: I've got another workaround though, which I'll PR with a few other fixes.


Mining quantities and repeat button is broken

🐛 Bug Report
When clicking repeat mining trips, it does not repeat the quantity you had chosen. The quantity is also different to what you set originally too. See here, where setting my quantity to 100 made it mine 250 and then repeating that trip made it mine 625.

At a quick glance it looks like this might be due to the offhand volcanic pickaxe, adding 150% onto 100 = 250
Then adding 150% onto 250 = 625

If it's just a bonus to quantity from the offhand in the same amount of time that's probably fine then, but it definitely shouldn't modify the quantity when repeating

If the trip length is too close to max trip length the repeat trip will send a max length trip instead. This was implemented to prevent manipulating the RNG.


Introduce data section inside sechub configuration file

Situation
We currently provide only source code uploads inside codeScan configuration areas.
But we have planned to support also

secretScan
codeScan (with binaries)
dependencyScan (with sources and binaries)
licenseScan
... more ...

Which contains binary content as well - and this is currently not possible inside the configuration.
Also it is not possible to reuse an upload for all kind of scan types (e.g. when defining a secretScan and a codeScan in same configuration file )
Wanted
As a SecHub user I want to define a configuration file where I define my data (binary and/or source content), upload it once and use this for different kind of scans in ONE job.
Existing job configurations for users currently only performing code scans shall still work.
Solution
Codescan can be defined as before
We will provide following as before:
{
      "apiVersion": "1.0",
      "server"    : "https://sechub.example.org",

      "project"   : "gamechanger",

      "codeScan": {
         "fileSystem": {
              "folders": ["gamechanger-android/src/main/java",
                          "gamechanger-server/src/main/java"]
         },
         "excludes": ["**/mytestcode/**","**/documentation/**"],
         "additionalFilenameExtensions": [".cplusplus",".py9"]
      }
}

But the segment for code scan ("fileSystem" ) is only a shortcut for:
{
      "apiVersion": "1.0",
      "server"    : "https://sechub.example.org",

      "project"   : "gamechanger",

      "data" : {
           "sources": [
             {
                "fileSystem": {
                    "folders": ["gamechanger-android/src/main/java",
                            "gamechanger-server/src/main/java"]
                 },
              "excludes": ["**/mytestcode/**","**/documentation/**"],
              "additionalFilenameExtensions": [".cplusplus",".py9"]
            }
          ]
      },

      "codeScan": {

      }
}

New possiblities for multiple scans for same upload or binary content
While introducing "data" as new element inside our json configuration, we will also

provide optional name attribute inside data object elements ( when not defined a random will be generated on server side)
we introduce also files inside fileSystem so we can define also single files
we can reference named object elements via "use" attribute inside different scan type configurations (when nothing defined, all data objects are referenced automatically)

Here a full blown example (with massive configurations):
{
  "apiVersion" : "1.0",
  "server" : "https://sechub.example.org",
  "project" : "gamechanger",
  "data" : { // contains the different kind of data objects ( sources, binaries)
    "sources" : [ {
      "name" : "android-sources",
      "fileSystem" : {
        "folders" : [ "gamechanger-android/src/main/java", "gamechanger-server/src/main/java" ]
      },
      "excludes" : [ "**/mytestcode/**", "**/documentation/**" ],
      "additionalFilenameExtensions" : [ ".cplusplus", ".py9" ]
    }, {
      "name" : "openapi-reference",
      "fileSystem" : {
        "files" : [ "gamechanger-webapp/src/main/resources/openapi3.json" ]
      }
    }, {
      "name" : "secret-scanner-config",
      "fileSystem" : {
        "files" : [ "gamechanger-data/src/main/resources/secret-scanner-dictionary.json" ] // new: files
      }
    } ],
    "binaries" : [ { // new: binaries!
      "name" : "android-libraries",
      "fileSystem" : {
        "folders" : [ "gamechanger-android/lib/dlls", "gamechanger-server/lib/so" ]
      },
      "excludes" : [ "**/*.jpg/**", "myimages/**" ]
    } ]
  },
  // Define wanted scan and reference - if wanted the named data object
  "codeScan" : {
    "use" : [ "android-sources","android-libraries","openapi-reference"]
  },
  "dependencyScan" : { // fictional: currently this scan type does not exist, just an example
    "use" : [ "android-sources", "android-libraries" ]
  },
  "secretScan" : {// fictional: currently this scan type does not exist, just an example
    "use" : [ "secret-scanner-config" ],
    "featureToggle" : {
      "entropy" : "off"
    }
  },
  "licenseScan" : {// fictional: currently this scan type does not exist, just an example
    "use" : [ "android-sources","android-libraries" ]
  },
  "webScan" : {
    "url" : "https://example.com",
    "openApi" : {
      "use" : [ "openapi-reference"]
    }
  }
}

The names of referenced data configuration objects must be unique. There must be a validation inside the model.

Remark: This issue is a precondition for #1152


How to enable iree-compiler, iree-runtime as iree building from source.

Hello!
Following the build from source in iree-python-bindings .
And it success in
python -c "import iree.compiler"
python -c "import iree.runtime"

Coming to install iree-jax from source, it requires the package iree-compiler, iree-runtime.
I think these above two library (eg. iree.compiler to iree-compiler) are almost same except the module name (correct me if i'm wrong).
During pip install -e . will download iree_compiler-xxx.whl,
How can I use the local iree build python library? Since I'd like to code with iree .
I also see the common routine when iree dealing with tensorflow and pytorch Integration, IREE package can be installed from pip or
building from souce, although in fact the building from souce linkage is broken .

although in fact the building from souce linkage is broken .

Argh. Thanks for noticing. Fixing in https://github.com/openxla/iree/pull/13643

How can I use the local iree build python library? Since I'd like to code with iree .

See https://github.com/iree-org/iree-jax/tree/main#using-an-iree-development-tree
(Seems that all you need to do is set up your PYTHONPATH, without already having the .whl packages installed from pip)

-DIREE_BUILD_LEGACY_JAX=OFF was removed in https://github.com/openxla/iree/pull/8031... that should no longer be needed anywhere (someone should update the docs in this repo)

I'd need to see more repro steps for what you're trying to offer concrete suggestions... I think the local dev steps don't want you running any pip commands at all (so https://github.com/iree-org/iree-jax/blob/main/setup.py doesn't get involved and look into the version_info.json file)

Sounds all good and I'll send a PR to review the legacy comment from readme.


[Bug]: Need to change data type

Connector Name
module/cosmosdb (Cosmos DB)
What happened?
Gives a compile time error which is mentioned bellow.
Relevant log output
incompatible types: expected 'map<json>', found 'record {| anydata...; |}'

Closing since its done


User rate limit changed to captures per minute

Quote from the Save Page Now changelog
2023-01-22
The user rate limit mechanism changed from counting concurrent captures to limiting captures per minute.
Anonymous users can do 4 captures per minute and authenticated users can do 12 captures per minute
It's "captures per minute", measured over the last 60 seconds, see page 11 of API doc

By “concurrent captures”, we mean captures performed in the last 60 sec.

However, it is now much easier to hit this limit. Can you take this into account?
Thank you.

If this has actually been implemented (I didn't even notice until you pointed it out), I think it's being done by giving the user the "overloaded" status message and delaying the relevant captures so that (without authentication) about 4 to 5 captures are processed each minute, or about 270 captures per hour. You can definitely still make more than 4 requests per minute without authentication, although there is also still a limit on concurrent captures that can kick in.
I think it would make the most sense to take this into account by properly handling the edge case where you have to wait more than 10 minutes for the capture to start, i.e. #19.

The "overloaded" message is a bit different.
If I recall correctly, the user limit says something about "you" having reached your limit of something.
Then there's yet another message, about the archive having received too many requests for a specific website, like github.com
So, it's 3 different things:
overloaded in general
too many requests about a website
too many requests by the user
For the general overloading, there's an API, mentioned in the changelog
2022-04-05
New API endpoint http://web.archive.org/save/status/system to notify applications if SPN is overloaded.
For the specific website, see page 9 of the API doc
I don't know the error code

Artificial delays for multiple concurrent captures on the same host.
When we run more than 20 concurrent captures on the same host, we introduce an artificial delay on subsequent captures to avoid overloading the target and blocking SPN2.
The delay algorithm is:
When concurrent_capture_number > 20 for the same host, delay concurrent_capture_number/5 sec.
For example: if concurrent_capture_number = 50, delay a new capture by 50/5 = 10 sec.

For the capture limit, it's measured over the last 60 seconds, as stated on page 11 of the API doc

By “concurrent captures”, we mean captures performed in the last 60 sec.


Reference types fixes

Fixes #2830, as well as some other bugs I found while working on it.
See the commit messages for more detailed descriptions of each fix.

Also fixes #2860.

Sorry it took me so long to get to this, but this all seems reasonable enough to me!
Unfortunately the --reference-types argument was added pretty early in wasm-bindgen's history and I never went back and re-tested it and got it fully working with 100% of features, so it's great to see that it's getting some usage and bugs are getting fixed!


Added message regeneration ability.

Users can now regenerate a previous message response in the conversation history. This allows users to adjust model params like temperature or even switch models entirely and then regenerate a previous response.

Users can now regenerate a message anywhere in the conversation chain.
Code Syntax highlight adjustment to github-dark-dimmed.
Simplified message-items html template DOM logic and layout.
Message bubble color theme updates to align closer to the general site theme.

I've investigated myself and found myself innocent


(Newbie here)

makes no sense to me what do i have to do, to turn my usb into badusb what do i do and what do i need plz need help

Well, my good sir, the first thing to do, In My Hackish Opinion, is to learn some English :) since communication is essential in our daily life.
Now about the testing because, I think that your question is about it, my solution protects not only from BadUSB, but also from social engineering.
Fewer examples are USB Rubber Ducky, LAN Turtle, USB armory and so on.
Have fun :)


RoadMap

Roadmap until v1

[x] Metrics
[ ] Collapsing
[x] Sigma-Gap
[x] Similiarity of Paths for Collapsing
[x] Full-Processing from Test

:star: :


How can I set to default the orientation of the App to Landscape?

How can I set to default the orientation of the App to Landscape? then actually just locking and never allowing the user to put the app into portrait mode?

Hi, what platform? or Forms?
If you want to lock orientation on the whole app you need to use platform-specific practice, like this: https://docs.microsoft.com/en-us/xamarin/xamarin-forms/user-interface/layouts/device-orientation?tabs=vswin (just select supported orientation what you want)

Thanks for pointing this out for me, you were really helpful!


Fix proximity precision telemetry

The proximity precision telemetry was partially missing in the global setting route.
This PR adds the missing field and return the default value when the value is not set.

bors merge


"npm run build" breaks local folders

When running npm run build locally, the build function does:
"build": "copyfiles -E -V -f docs/doc_imgs/* static/doc_imgs/. && replace 'doc_imgs' '/doc_imgs' docs/* --include='*.md*' && docusaurus build",

This has two issues:

Replacing the relative links from 'doc_imgs' to '/doc_imgs' in the md files locally changes all the files, so git detects all of them as changed.
static/doc_imgs/* gets added to the repo, which are detected as new files by git. This can probably be fixed easily by adding static/doc_imgs to .gitignore.

With this issues, if you test the build locally then you need to revert before adding files to staging and committing.

Why did we change the behaviour we had? Modifying the md files inplace is bad.
The pr: https://github.com/demisto/content-docs/pull/18 doesn't provide a clear example to the problem it tries to solve

It was determined that the addition of a trailing slash (such as those contained in Algolia search result links) was causing relative asset paths to reference assets in the wrong location.
For example, given the following URL (with an added trailing slash):
https://demisto.pan.dev/docs/integration-docs/
...And the following relative asset path: doc_imgs/example.png (used somewhere in the page)
...The browser would attempt to load the asset from https://demisto.pan.dev/docs/integration-docs/doc_imgs/example.png instead of the correct location: https://demisto.pan.dev/doc_imgs/example.png.
The trailing slash was first noticed when following an Algolia search result link (reproducible) but it was also sometimes observed when visiting doc pages directly (currently unable to reproduce this behavior).
A Discord chat with a Docusaurus maintainer validated that updating the link references would be a viable solution to allow assets to render in both GitHub and the static generated site (please see snippet of chat history below).

What about adding a redirect from urls ending with slash to non-slash? I think netlify supports redirects.

I considered this approach but, AFAIK, _redirects doesn't support the removal of trailing slashes. I'll investigate again to be certain.

@sserrata that is correct, no support of trailing slashes. If you add the rule it will create an infinite redirect.

To close the loop on this I reached out to Netlify for an answer. Please find the response below:

What about configuring Algolia to not index with trailing slashes? They might have a configuration for this. Google search brought some results about this. For example: https://github.com/algolia/docsearch-configs/issues/744

I contacted Algolia support to inquire how this might be accomplished or if it's supported. I'll update the thread when I hear back.
I wanted to circle back to the original issues to make sure we're all on the same page:

Replacing the relative links from 'doc_imgs' to '/doc_imgs' in the md files locally changes all the files, so git detects all of them as changed.
static/doc_imgs/* gets added to the repo, which are detected as new files by git. This can probably be fixed easily by adding static/doc_imgs to .gitignore.
Modifying md files in place is bad.

Issue 1 and 2 can be avoided by not running npm run build locally. Ideally, in the majority of cases, the development server (npm run start) should be sufficient for previewing/testing locally.
Concerning 3, I agree that it's definitely bad if we're performing builds locally. IMO, running npm run build locally is an optional step, to be used (perhaps) in special cases. Instead, use Netlify's build preview feature to preview a production build.

Since we have a workaround and we can work locally, closing this because it's good for now.


CopyAllParts fails with invalid UUID patterns

The little snippet fails due to invalid UUID patterns (in hdf5).
import resqpy.model as rq
model = rq.Model('d:/dev/resqpy/tests/test_data/UGRID_GRID.epc')
new_model = rq.Model('d:/new.epc', new_epc=True)
new_model.copy_all_parts_from_other_model(model)
new_model.store_epc('d:/new.epc')

It fails with:
Traceback (most recent call last):
  File "D:\DEV\resqpy\test_local\rewrite_ugrid.py", line 14, in <module>
    new_model.copy_all_parts_from_other_model(model)
  File "D:\DEV\resqpy\resqpy\model.py", line 3348, in copy_all_parts_from_other_model
    self.copy_part_from_other_model(other_model,
  File "D:\DEV\resqpy\resqpy\model.py", line 3232, in copy_part_from_other_model
    hdf5_count = whdf5.copy_h5(other_h5_file_name, self_h5_file_name, uuid_inclusion_list = [uuid], mode = 'a')
  File "D:\DEV\resqpy\resqpy\olio\write_hdf5.py", line 167, in copy_h5
    uuid = bu.uuid_from_string(group)
  File "D:\DEV\resqpy\resqpy\olio\uuid.py", line 111, in uuid_from_string

because it encounters
'Fault_4346bb9c-68a5-4591-86df-9284316d0dd3' or
'UnstructuredGrid_492f069b-888a-4a17-8cc1-cdc845774f18_Geometry'
I think the issue arises from the hdf paths:
<eml20:PathInHdfFile xmlns:xsd="http://www.w3.org/2001/XMLSchema" xsi:type="xsd:string">RESQML/UnstructuredGrid_492f069b-888a-4a17-8cc1-cdc845774f18_Geometry/USER_CELL_INDEX</eml20:PathInHdfFile>
or
<eml20:PathInHdfFile xmlns:xsd="http://www.w3.org/2001/XMLSchema" xsi:type="xsd:string">RESQML/Fault_4346bb9c-68a5-4591-86df-9284316d0dd3/Fault_Cells</eml20:PathInHdfFile>
It could well be that  a very well-known vendor is ignoring standard or business rule with regard to naming the hdf path within the h5 file. I have always treated PathInHdfFile as is rather than assuming some semantics.
ugrid.zip

Thanks for highlighting this @mgimhof – I think your analysis is correct.  There are probably parts of resqpy code that make assumptions about the semantics or structure of hdf5 internal paths.  We should treat that as a bug and modify the code so that it always reads the hdf5 internal paths from the xml and does not make any unnecessary assumptions.

@andy-beer
Thanks Andy!


Fix attempt for #13

Fixes #13

This change is

Codecov Report

Merging #16 into dev will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             dev     #16   +/-   ##
=====================================
  Coverage   3.48%   3.48%
=====================================
  Files          3       3
  Lines         86      86
=====================================
  Hits           3       3
  Misses        83      83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b00d76...7b92213. Read the comment docs.

Awesome work on the tests! Thank you! Just minor comments.

Review status: all files reviewed at latest revision, all discussions resolved.

Tests/Unit/xBitlockerCommon.tests.ps1, line 1 at r1 (raw file):

<#

Could you please

Delete all template comments (TODOs, etc.)
Remove any unused BeforeAll-, AfterAll-, BeforeEach- and AfterEach-blocks.
Remove this comment-based help.

Tests/Unit/xBitlockerCommon.tests.ps1, line 21 at r1 (raw file):

# Unit Test Template Version: 1.2.1
$script:moduleRoot = Split-Path -Parent (Split-Path -Parent $PSScriptRoot)
if ( (-not (Test-Path -Path (Join-Path -Path $script:moduleRoot -ChildPath 'DSCResource.Tests'))) -or `

Since we are testing a helper module (and not a resource), the header is not necessary, so you can just keep line 20 and remove the rest of #region HEADER. Basically, keep what you need to be able to run the test.

Tests/Unit/xBitlockerCommon.tests.ps1, line 30 at r1 (raw file):

# TODO: Insert the correct <ModuleName> and <ResourceName> for your resource
#$TestEnvironment = Initialize-TestEnvironment `

You can remove this row.

Tests/Unit/xBitlockerCommon.tests.ps1, line 42 at r1 (raw file):

function Invoke-TestCleanup {
#    Restore-TestEnvironment -TestEnvironment $TestEnvironment

You can remove this row.

Tests/Unit/xBitlockerCommon.tests.ps1, line 79 at r1 (raw file):

                    -ModuleName 'xBitlockerCommon' `
                    -MockWith {
                        param (

We can move the param block inside Get-BitlockerVolume so that you only need to specify that once.
Suggest changing to this so we align with the style guideline.
function Get-BitlockerVolume
{
    param
    (
        [Parameter()]
        [System.String]
        $MountPoint
    )
 }

Tests/Unit/xBitlockerCommon.tests.ps1, line 111 at r1 (raw file):

                Mock -CommandName Get-BitlockerVolume -ModuleName 'xBitlockerCommon' -MockWith {
                            # Encrypted with TPM and Recovery Password Key Protectors
                            param (

Remove this, see previous comment.

Tests/Unit/xBitlockerCommon.tests.ps1, line 144 at r1 (raw file):

                    -MockWith {
                            # Encrypted with TPM and Recovery Password Key Protectors
                            param (

Remove this, see previous comment.

Tests/Unit/xBitlockerCommon.tests.ps1, line 176 at r1 (raw file):

finally
{
#    Invoke-TestCleanup

Please uncomment this, or remove if the function was not used.

Comments from Reviewable

Review status: 2 of 3 files reviewed at latest revision, 8 unresolved discussions.

Tests/Unit/xBitlockerCommon.tests.ps1, line 1 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could you please

Delete all template comments (TODOs, etc.)
Remove any unused BeforeAll-, AfterAll-, BeforeEach- and AfterEach-blocks.
Remove this comment-based help.

Done.

Tests/Unit/xBitlockerCommon.tests.ps1, line 21 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Since we are testing a helper module (and not a resource), the header is not necessary, so you can just keep line 20 and remove the rest of #region HEADER. Basically, keep what you need to be able to run the test.

Done.

Tests/Unit/xBitlockerCommon.tests.ps1, line 30 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
You can remove this row.

Done.

Tests/Unit/xBitlockerCommon.tests.ps1, line 42 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
You can remove this row.

Done.

Tests/Unit/xBitlockerCommon.tests.ps1, line 79 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
We can move the param block inside Get-BitlockerVolume so that you only need to specify that once.
Suggest changing to this so we align with the style guideline.
function Get-BitlockerVolume
{
    param
    (
        [Parameter()]
        [System.String]
        $MountPoint
    )
 }

Done.

Tests/Unit/xBitlockerCommon.tests.ps1, line 111 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Remove this, see previous comment.

Done.

Tests/Unit/xBitlockerCommon.tests.ps1, line 144 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Remove this, see previous comment.

Done.

Tests/Unit/xBitlockerCommon.tests.ps1, line 176 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Please uncomment this, or remove if the function was not used.

Done.

Comments from Reviewable

Just two tiny changes then I think this is good to go.

Review status: all files reviewed at latest revision, all discussions resolved.

Tests/Unit/xBitlockerCommon.tests.ps1, line 9 at r2 (raw file):

    InModuleScope "xBitlockerCommon" {

        function Get-BitlockerVolume {

We should have this open brace on a separate row.
That style guideline does not apply to InModuleScope-, Describe, Context-, It-blocks because how Pester is built. For Pester commands the open brace needs to be on the same row.

Tests/Unit/xBitlockerCommon.tests.ps1, line 72 at r2 (raw file):

                }
            }
            Context 'When OS Volume is Decrypted, but has TPM and Recovery Password Protectors assigned' {

Could we add a blank row before this one to, to be consequent?

Comments from Reviewable

Review status: 2 of 3 files reviewed at latest revision, 2 unresolved discussions.

Tests/Unit/xBitlockerCommon.tests.ps1, line 9 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
We should have this open brace on a separate row.
That style guideline does not apply to InModuleScope-, Describe, Context-, It-blocks because how Pester is built. For Pester commands the open brace needs to be on the same row.

Done.

Tests/Unit/xBitlockerCommon.tests.ps1, line 72 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could we add a blank row before this one to, to be consequent?

Done.

Comments from Reviewable

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/636 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-archive-test-target.git

Docs Build status updates of commit 71da2a5:
:clock10: Pending: waiting for processors (38 builds ahead of you)
:warning: Docs Build is busy, currently there are 38 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 71da2a5:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-ServiceAccountCannotAccessRepository] Your repository https://github.com/VSC-Service-Account/docs-archive-test-source has enabled Docs Build service account. It seems that at least one of the accounts, e2ebd4, does not have Read permission to the repo. Please ask your repo admin to grant correct permission to service accounts (refer to this document: https://review.docs.microsoft.com/en-us/engineering/projects/ops/engdocs/how-to-grant-service-account-permission-in-your-repository?branch=master#ops-e2e-ppe) and then retry the build. Don't know who to contact? Refer https://repos.opensource.microsoft.com/VSC-Service-Account/repos/docs-archive-test-source/permissions/ to get admin list of the repo if the repo is in one of the organizations Microsoft owns.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Make textures clearly belong to blocks

Enhancement for #2
Right now, there are like 3 different places where we import/define textures.
It will involve some digging into pyglet, but we definitely need to de-duplicate that.
I'm imagining a "texture" object, that has textures for more then one block.
Blocks return coordinates and a reference to their texture in it.
I think heightmaps could lead to some very interesting effects, and in the future we might want to support dynamic textures (maps) or layered textures (signs).
But we don't need a perfect solution off the bat. Just a quick system for defining a texture in one place, and having the renderer read them.

Would it be useful to have blocks 'owning' their textures via having the textures split into separate files? I'm not sure what difficulties that could bring into the rendering setup logic, but I know minecraft uses separate files for each texture and allows blocks and items to 'inherit' the textures and models of other blocks/items.
I'm not suggesting we take the same organizational route minecraft has taken (in fact, I'd argue vehemently against it), but splitting textures into separate files seems like a win for modularity.

True.

This may be useful:
class Block(object):
    tex = []
    files = []
    colorizeable = False

    def get_tex(self,file):
        tex = pyglet.image.load(file).get_texture()
        glTexParameterf(GL_TEXTURE_2D,GL_TEXTURE_MIN_FILTER,GL_NEAREST)
        glTexParameterf(GL_TEXTURE_2D,GL_TEXTURE_MAG_FILTER,GL_NEAREST)
        return pyglet.graphics.TextureGroup(tex)

    def __init__(self):
        for nme in self.files:
            self.tex.append(self.get_tex(nme))

    def draw(self, position, batch):
        x, y, z = position
        return self.cuboid(*position, self.tex, batch)

    def cuboid(self, x, y, z, textures, batch):
        '''
        Draws a cuboid from x1,y1,z1 to x2,y2,z2 and covers each side with tex
        tex format:
            (side, top, bottom)
        Facing in the -z direction
        '''
        tex = textures
        front = tex[0]
        back = tex[0]
        left = tex[0]
        right = tex[0]
        top = tex[1]
        bottom = tex[2]

        tex_coords = ("t2f", (0, 0, 1, 0, 1, 1, 0, 1))
        x1, y1, z1 = x, y, z
        x2, y2, z2 = x + 1, y + 1, z + 1
        if self.colorizeable:
            color = self.colorizer.colorize(y)
        else:
            color = None
        if color:
            cube = (batch.add(4, GL_QUADS, right, ('v3f', (x1, y1, z1, x1, y1, z2, x1, y2, z2, x1, y2, z1)), tex_coords),
                batch.add(4, GL_QUADS, left, ('v3f', (x2, y1, z2, x2, y1, z1, x2, y2, z1, x2, y2, z2)), tex_coords),
                batch.add(4, GL_QUADS, bottom, ('v3f', (x1, y1, z1, x2, y1, z1, x2, y1, z2, x1, y1, z2)), tex_coords),
                batch.add(4, GL_QUADS, top, ('v3f', (x1, y2, z2, x2, y2, z2, x2, y2, z1, x1, y2, z1)), tex_coords, color),
                batch.add(4, GL_QUADS, back, ('v3f', (x2, y1, z1, x1, y1, z1, x1, y2, z1, x2, y2, z1)), tex_coords),
                batch.add(4, GL_QUADS, front, ('v3f', (x1, y1, z2, x2, y1, z2, x2, y2, z2, x1, y2, z2)), tex_coords))
        else:
            cube = (batch.add(4, GL_QUADS, right, ('v3f', (x1, y1, z1, x1, y1, z2, x1, y2, z2, x1, y2, z1)), tex_coords),
                batch.add(4, GL_QUADS, left, ('v3f', (x2, y1, z2, x2, y1, z1, x2, y2, z1, x2, y2, z2)), tex_coords),
                batch.add(4, GL_QUADS, bottom, ('v3f', (x1, y1, z1, x2, y1, z1, x2, y1, z2, x1, y1, z2)), tex_coords),
                batch.add(4, GL_QUADS, top, ('v3f', (x1, y2, z2, x2, y2, z2, x2, y2, z1, x1, y2, z1)), tex_coords),
                batch.add(4, GL_QUADS, back, ('v3f', (x2, y1, z1, x1, y1, z1, x1, y2, z1, x2, y2, z1)), tex_coords),
                batch.add(4, GL_QUADS, front, ('v3f', (x1, y1, z2, x2, y1, z2, x2, y2, z2, x1, y2, z2)), tex_coords))
        return cube


Problem with image indexation

Hi.
I have an image pb. The indexation works fine and I see the image name in the Solr Admin panel, but when I query (simply) my collection, the hydratation of the image fails:

Type error: Argument 1 passed to TT\GuidesBundle\Entity\Guide::setImage() must be an instance of TT\GuidesBundle\Entity\Image, string given

I even tried to create a special getter to get the object in my image class, but when I try to index it it says that a string is awaited.So, I have to index a string  relation, I guess that's pretty logical.
I tried with either DOCTRINE or INDEX hydratation modes
Any idea why I get this problem ?
Thanks a lot for your help
Guillaume

Please find below my relation declaration in my Guide class:

/**

 *
 * @Solr\Field(type="string", getter="getName")
 * @ORM\ManyToOne(targetEntity="TT\GuidesBundle\Entity\Image", cascade="persist")
 */
private $image;

Cheers,
G

Can you remove the type-hint in setImage?


generate_docs.sh error

generate_docs.sh tries to install jsdoc2md should be jsdoc-to-markdown

Oops, I don't want it install globally when they both install local binaries...


Plesk and Postal Clash

Hello
In my server, Plesk is installed and now I am trying to install postal I got an error. I think because of MySQL and MariaDB
Is there are any idea about this two clash? and how to resolve?

Install Postal on a clean server. We cannot support installing it alongside any other service I'm afraid.


Installation not possible

I'm currently not able to install the declarative lookup rollup helper into a production org. After the Status changes to "completed" following error occurs:

Deployment

CompleteTest failure, method: fflib_SecurityUtilsTest.readonly_field_access -- System.QueryException: List has no rows for assignment to SObject stack Class.fflib_SecurityUtilsTest.setupTestUser: line 38, column 1
Class.fflib_SecurityUtilsTest.readonly_field_access: line 56, column 1

Test failure, method: fflib_SecurityUtilsTest.readonly_objectAndField_access -- System.QueryException: List has no rows for assignment to SObject stack Class.fflib_SecurityUtilsTest.setupTestUser: line 38, column 1
Class.fflib_SecurityUtilsTest.readonly_objectAndField_access: line 153, column 1

Test failure, method: fflib_SecurityUtilsTest.readonly_object_access -- System.QueryException: List has no rows for assignment to SObject stack Class.fflib_SecurityUtilsTest.setupTestUser: line 38, column 1
Class.fflib_SecurityUtilsTest.readonly_object_access: line 99, column 1

Test failure, method: fflib_SecurityUtilsTest.sysadmin_objectAndField_access -- System.QueryException: List has no rows for assignment to SObject stack Class.fflib_SecurityUtilsTest.setupTestUser: line 38, column 1
Class.fflib_SecurityUtilsTest.sysadmin_objectAndField_access: line 238, column 1

Test failure, method: RollupControllerTest.testDeployedStatus -- System.DmlException: Insert failed.  If you are attempting to use a custom field, be sure to append the '__c' after the custom field name.  First exception on row 0; first error: FIELD_CUSTOM_VALIDATION_EXCEPTION, Field does not exist.: [AggregateResultField__c] stack Class.RollupServiceTest.testCountById: line 385, column 1

Test failure, method: RollupServiceTest.testLimitsConsumedWithConditions -- System.DmlException: Insert failed. First exception on row 1; first error: FIELD_CUSTOM_VALIDATION_EXCEPTION, Field does not exist.: [AggregateResultField__c] stack Class.RollupServiceTest.testLimitsConsumedWithConditions: line 819, column 1

Test failure, method: RollupServiceTest.testCountByType -- System.DmlException: Insert failed. First exception on row 0; first error: FIELD_CUSTOM_VALIDATION_EXCEPTION, Field does not exist.: [AggregateResultField__c] stack Class.RollupServiceTest.testCountByType: line 327, column 1

Test failure, method: RollupServiceTest.testMultiRollupNoConditions -- System.DmlException: Insert failed. First exception on row 0; first error: FIELD_CUSTOM_VALIDATION_EXCEPTION, Field does not exist.: [AggregateResultField__c] stack Class.RollupServiceTest.testMultiRollupNoConditions: line 270, column 1

Test failure, method: RollupServiceTest.testMultiRollup -- System.DmlException: Insert failed. First exception on row 1; first error: FIELD_CUSTOM_VALIDATION_EXCEPTION, Field does not exist.: [AggregateResultField__c] stack Class.RollupServiceTest.testMultiRollup: line 124, column 1

Test failure, method: RollupServiceTest.testLimitsConsumedWithoutConditions -- System.DmlException: Insert failed. First exception on row 1; first error: FIELD_CUSTOM_VALIDATION_EXCEPTION, Field does not exist.: [AggregateResultField__c] stack Class.RollupServiceTest.testLimitsConsumedWithoutConditions: line 930, column 1

Test failure, method: RollupServiceTest.testMultiRollupWithTwoParents -- System.DmlException: Insert failed. First exception on row 1; first error: FIELD_CUSTOM_VALIDATION_EXCEPTION, Field does not exist.: [AggregateResultField__c] stack Class.RollupServiceTest.testMultiRollupWithTwoParents: line 478, column 1

Test failure, method: RollupServiceTest.testMultiRollupSumAndAvg -- System.DmlException: Insert failed. First exception on row 1; first error: FIELD_CUSTOM_VALIDATION_EXCEPTION, Field does not exist.: [AggregateResultField__c] stack Class.RollupServiceTest.testMultiRollupSumAndAvg: line 197, column 1

Test failure, method: RollupServiceTest.testMultiRollupWithTwoParentsTenChunks -- System.QueryException: No such column 'NumberOfLocations__c' on entity 'Account'. If you are attempting to use a custom field, be sure to append the '__c' after the custom field name. Please reference your WSDL or the describe call for the appropriate names. stack Class.RollupServiceTest.testMultiRollupWithTwoParentsTenChunks: line 598, column 1

Test failure, method: RollupServiceTest2.testChangeInRelationship -- System.DmlException: Insert failed. First exception on row 0; first error: FIELD_CUSTOM_VALIDATION_EXCEPTION, Field does not exist.: [AggregateResultField__c] stack Class.RollupServiceTest2.testChangeInRelationship: line 541, column 1

Test failure, method: RollupServiceTest2.testChangeInCriteriaReferencedField -- System.QueryException: No such column 'NumberOfLocations__c' on entity 'Account'. If you are attempting to use a custom field, be sure to append the '__c' after the custom field name. Please reference your WSDL or the describe call for the appropriate names. stack Class.RollupServiceTest2.testChangeInCriteriaReferencedField: line 500, column 1

Test failure, method: RollupServiceTest2.testMultiRollupBothScheduledWithConditions -- System.DmlException: Insert failed. First exception on row 1; first error: FIELD_CUSTOM_VALIDATION_EXCEPTION, Field does not exist.: [AggregateResultField__c] stack Class.RollupServiceTest2.testMultiRollupBothScheduledWithConditions: line 89, column 1

Test failure, method: RollupServiceTest2.testMultiRollupOneScheduled -- System.DmlException: Insert failed. First exception on row 1; first error: FIELD_CUSTOM_VALIDATION_EXCEPTION, Field does not exist.: [AggregateResultField__c] stack Class.RollupServiceTest2.testMultiRollupOneScheduled: line 173, column 1

Test failure, method: RollupServiceTest2.testUnDeleteRealtime -- System.QueryException: No such column 'NumberOfLocations__c' on entity 'Account'. If you are attempting to use a custom field, be sure to append the '__c' after the custom field name. Please reference your WSDL or the describe call for the appropriate names. stack Class.RollupServiceTest2.testUnDeleteRealtime: line 626, column 1

Test failure, method: RollupServiceTest3.testDateRollupInsertConditionalChild -- System.DmlException: Insert failed. First exception on row 0; first error: FIELD_CUSTOM_VALIDATION_EXCEPTION, Field does not exist.: [AggregateResultField__c] stack Class.RollupServiceTest3.testDateRollupInsertConditionalChild: line 542, column 1

Test failure, method: RollupServiceTest3.testDateRollupDeleteChild -- System.DmlException: Insert failed. First exception on row 0; first error: FIELD_CUSTOM_VALIDATION_EXCEPTION, Field does not exist.: [AggregateResultField__c] stack Class.RollupServiceTest3.testDateRollupDeleteChild: line 494, column 1

Test failure, method: RollupServiceTest3.testScheduleCalculateJob -- System.AssertException: Assertion Failed: Expected: Die Ausführung des Apex-Auftrags mit der Bezeichnung "rollup_a060O00001L5kJv" ist bereits geplant., Actual: The Apex job named "rollup_a060O00001L5kJv" is already scheduled for execution. stack Class.RollupServiceTest3.testScheduleCalculateJob: line 370, column 1

Test failure, method: RollupServiceTest3.testRollupWithInAccessibleParent -- System.NullPointerException: Attempt to de-reference a null object stack Class.RollupServiceTest3.testRollupWithInAccessibleParent: line 624, column 1

Test failure, method: RollupServiceTest4.testDefaultUserSharingRollup -- System.NullPointerException: Attempt to de-reference a null object stack External entry point
Class.RollupServiceTest4.testDefaultUserSharingRollup: line 31, column 1

Test failure, method: RollupServiceTest4.testUserUserSharingRollup -- System.NullPointerException: Attempt to de-reference a null object stack External entry point
Class.RollupServiceTest4.testUserUserSharingRollup: line 35, column 1

Test failure, method: RollupServiceTest4.testSystemUserSharingRollup -- System.NullPointerException: Attempt to de-reference a null object stack External entry point
Class.RollupServiceTest4.testSystemUserSharingRollup: line 39, column 1

Test failure, method: RollupServiceTest5.testCheckboxRollupWithNoChildren -- System.DmlException: Insert failed. First exception on row 0; first error: FIELD_CUSTOM_VALIDATION_EXCEPTION, Bitte entweder E-Mail oder Telefonnummer oder Mobilnummer hinterlegen: [] stack Class.RollupServiceTest5.testCheckboxRollupWithNoChildren: line 583, column 1

Test failure, method: RollupSummariesTest.testInsertBadFieldTypeSumNotValid -- System.AssertException: Assertion Failed: Expected: Sum/Avg doesnt looks like valid for dates ! Still want, then implement the IRollerCoaster yourself and change this class as required., Actual: Field does not exist. stack Class.RollupSummariesTest.testInsertBadFieldTypeSumNotValid: line 392, column 1

Test failure, method: RollupSummariesTest.testInsertCountByCloseDateNoErrors -- System.AssertException: Assertion Failed: Expected: 0, Actual: 1 stack Class.RollupSummariesTest.testInsertCountByCloseDateNoErrors: line 517, column

1

It looks like you are trying to push the code directly into production? Perhaps via the Deploy to Salesforce button on the README? Or Ant or such like?
Basically, this is not the recommended route. Unless you are a developer or want to take on the code directly in your org? Instead, I would recommend you go to the README file and use the latest Package install link.
FYI the reason you are getting the errors btw is tests in this repo are not compatible with most production environments due to likely customizations in those orgs, they are designed to work in scratch / empty DE orgs for developers.