For viewers, default to comment mode and hide non-read-only modes and actions

Fix #4608
Problem:
Viewers cannot do or use most of the regular actions and modes, but the UI still shows them.
Also, the default mode when opening a project in view mode would make sense to be comment mode.
Fix:

Switch to comment mode when loading the editor as a viewer
Hide the toolbar buttons for insert mode and text mode
Hide the secondary toolbar for edit mode
Disable the insertion, text, swap, etc. hotkeys for viewers

how do I reproduce? opening my own project in a private tab did not seem to work properly


Request for Article Abstract

Hello!
I was wondering if it would be possible for you to provide the abstract section of your article? This would greatly help me in understanding the key points and significance of your work without having to go through the entire piece immediately.
Looking forward to your reply. Wish you all the best!

Hello!
Thank you for your interest in my research. The abstract of our paper is below.
Bundle recommender systems aim to recommend suitable collections (i.e., bundles) of items to each user, meeting their diverse
needs with all-in-one convenience. Typically, they utilize three distinct types of information: user-bundle purchase interactions (U-B view), user-item purchase interactions (U-I view), and bundle-item affiliations (B-I view). Our focus is on better integrating these three perspectives (i.e., views) to deliver more accurate bundle recommendations. Our examination of different role (main or sub-views) combinations of the views reveals two key observations: (1) the best combination varies across target users (i.e., who receive recommendations), and (2) the U-I view is relatively weak as the main role. Driven by these observations, we propose PET, which synergizes the three views through (1) personalized view weighting, (2) U-I view enhancement, and (3) two-pronged contrastive learning. Our extensive experiments demonstrate that PET significantly outperforms existing methods in all popular benchmark datasets.
Best regards,
Kyungho

Thanks a lot.


Use the fastest demo site in docs

Casdoor has multiple demo sites: https://github.com/casdoor/casdoor#online-demo , it's also embedded into: https://casdoor.org/
We want mainland users to use: https://door.casdoor.com/ and international users to use: https://door.casdoor.org/ , how to detect and do the switch in this docs site?

@Selflocking


Confusion among multiple languages on sa.iogt.site

Accessing https://sa.iogt.site redirects properly to /en/
Once on the English homepage:

The logo clicks to /en/None/
Selecting BN language leads to /en/bn/
Selecting other languages afterward leads to unpredictable results eg I am now on /en/bn/bn/None

@istride @sheralim012 can you please look into this?

The Bengali language wasn't supported in the current codebase so created a PR to add it


[NewPlugin]  EliseZeroTwo Switch-Binja-Loader v1.0

Please add my plugin to the repository.
Yes, I've read the instructions, especially the part about creating an actual release and creating the tag.
I either used the UI, or the hub command to create a real release.
Author: EliseZeroTwo
Repo name: Switch-Binja-Loader
Release: v1.0

Can you use either the github UI or the hub release command to actually make the release? It's weird quirk that creating the tag makes it show up on the release page but it's not actually considered a "release". Also, for future reference you can use https://github.com/Vector35/release_helper which automates the process (though it's still very beta)

I did already do this, did I not do it correctly?

Nevermind, I typoed something. 😛

Rather, for the next release, please remove the v from the tag if you don't mind, our original examples/documentation used it but we realized afterward that was a bad idea. :-)
Done!

Sure. You might want to update the readme of this repo as it is what I followed.

Oh, thanks! I updated it a few other places but missed that one. Fixed.


Not working in mozila firefox + angular 4 + cli 1.0.4 [ubutnu 16]

I made a test with the same configuration and it seems to work fine now. Can you provide me more information?

`

Home

What We Do

Why Us

Packages

Blog

FAQ's

`
package.json
"dependencies": {     "@angular/animations": "^4.1.3",     "@angular/common": "^4.1.3",     "@angular/compiler": "^4.1.3",     "@angular/core": "^4.1.3",     "@angular/forms": "^4.1.3",     "@angular/http": "^4.1.3",     "@angular/material": "^2.0.0-beta.5",     "@angular/platform-browser": "^4.1.3",     "@angular/platform-browser-dynamic": "^4.1.3",     "@angular/router": "^4.1.3",     "core-js": "^2.4.1",     "ng2-auto-complete": "^0.12.0",     "ng2-scroll-to": "^1.0.7",     "ng2-toastr": "^4.0.1",     "ngx-pagination": "^3.0.0",     "rxjs": "^5.1.0",     "zone.js": "^0.8.4"   },   "devDependencies": {     "@angular/cli": "1.0.4",     "@angular/compiler-cli": "^4.1.3",     "@types/jasmine": "2.5.38",     "@types/node": "~6.0.60",     "codelyzer": "~2.0.0",     "jasmine-core": "~2.5.2",     "jasmine-spec-reporter": "~3.2.0",     "karma": "~1.4.1",     "karma-chrome-launcher": "~2.1.1",     "karma-cli": "~1.0.1",     "karma-coverage-istanbul-reporter": "^0.2.0",     "karma-jasmine": "~1.1.0",     "karma-jasmine-html-reporter": "^0.2.2",     "ng2-scrollable": "^0.8.0",     "protractor": "~5.1.0",     "ts-node": "~2.0.0",     "tslint": "~4.5.0",     "typescript": "~2.2.0"   }

thank you. i will try to fix this issue this evening after work.

@drusso85 I am waiting for your next release. Please look in to this issue.
Thanks

the html provided is not based on this module; anyway i made a test based on your package.json and it works.

    Home
    What We Do
    Why Us
    Packages
    Blog
    FAQ's

home section

wwd section

whyForex section

packages section

blog section

faq section

// app.module.ts
import { BrowserModule } from '@angular/platform-browser';
import { NgModule } from '@angular/core';
import { FormsModule } from '@angular/forms';
import { HttpModule } from '@angular/http';
import { AppComponent } from './app.component';
import { ScrollToModule } from 'ng2-scroll-to';

@NgModule({
  declarations: [
    AppComponent
  ],
  imports: [
    BrowserModule,
    FormsModule,
    HttpModule,
    ScrollToModule.forRoot()
  ],
  providers: [],
  bootstrap: [AppComponent]
})
export class AppModule { }

@drusso85 Can you give me your skype ID please? I can share screen with you so.
Thank you

I am very busy with work in this period so is very difficult for me to schedule a call. If you create a github project, I'll take a look after work.


reverse the order of instance.Stop() and onShutdown() calls on Restart

1. What does this change do, exactly?
reverse the order of instance.Stop() and onShutdown() calls on Restart. See more details at https://github.com/coredns/coredns/issues/1666#issuecomment-380624422
2. Please link to the relevant issues.
https://github.com/coredns/coredns/issues/1666
3. Which documentation changes (if any) need to be made because of this PR?
none
4. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[ ] I am willing to help maintain this change if there are issues with it later

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Well, I'm going to simplify the fix. I will keep only Stop/onShutdown reordering and will revert error processing related stuff. The error processing could be improved later in separate PR if needed

Looks like #2262 will be merged soon; might be worth checking if that conflicts with this.


pseudo_labeling function missing

Hi, I read your paper and would like to try your approach on my data.
However, I realized the pseudo_labeling function is missing. The file pseudo_labeling.py seems to be empty. Would you be able to add it?

Hi, the pseudo_labeling.py file was added, it has the KNN function computing k nearest neighbor and pseudo_labeling function that gives pseudo labels according to similarity matrix and KNN (if given a KNN list).


Refactor pmp sync

Refactoring pieces of the "PMP sync-post" process to address some long underlying issues.

More debug statements (tied to a PMP_DEBUG constant)
Ensure updating a Post is exactly the same as creating from scratch
Better differentiate between Posts and Attachments (and cleanup Attachments when the PMP-Post goes away)
Check for audio/image changes, both in the cron-updates and push-notifications.  Trigger a refresh of the parent Post (probably a Story) when the child items change.

This looks good to me. Made some minor changes to get the tests running and added a note about defining PMP_DEBUG.


Added Ai-Driven Sentiment Analysis for Customer Review

To make this code Properly work make sure:-
API Key Configuration is correct
Ensure that the huggingface and slack integrations are correctly configured within Julep. For huggingface, specify the correct model name.
For slack, set up a valid Slack workspace and channel configuration. Adjust Tool Call Parameters:
Modify the tool calls to match the exact input format for hugging face and Slack APIs.
Could you kindly review the code and suggest if any changes or improvements are needed? Your feedback would be greatly appreciated!

[!IMPORTANT]
Adds AI-driven sentiment analysis script using Julep, Hugging Face, and Slack integrations for customer reviews.

New Feature:

Adds 14-AI-Driven Sentiment Analysis for Customer Reviews.py for sentiment analysis using Julep, Hugging Face, and Slack.
Initializes Julep client with API keys and sets up agent and task UUIDs.

Agent and Task Setup:

Creates an agent named "Sentiment Analysis Assistant" using gpt-4-turbo model.
Defines sentiment analysis task with input schema for reviews and integrates Hugging Face and Slack.

Task Logic:

Uses Hugging Face to analyze sentiment and categorizes feedback as "Positive Feedback" or "Negative or Neutral Feedback".
Sends insights to Slack channel sentiment-insights.

Functionality:

Implements analyze_sentiment(review) function to execute sentiment analysis task.
Includes example usage with a sample review.

This description was created by  for 536630e0e8280767787b2b899aec50846df158b8. It will automatically update as commits are pushed.

Please refer to this part of the README to read about the integrations that are supported by Julep. We are currently not supporting HuggingFace or a Slack integration tools.
Closing this PR for now. Please test your code before opening a new PR.


feat: reexport protocol_types from aztec-nr

This PR rexports protocol_types from aztec-nr so that users of aztec-nr don't need to have a direct dependency on protocol_types

Benchmark results
Metrics with a significant change:

note_successful_decrypting_time_in_ms (8): 460 (+44%)
note_trial_decrypting_time_in_ms (8): 69.7 (+132%)
note_trial_decrypting_time_in_ms (32): 30.6 (-76%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 60b59dac and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,444
179,588
716,132

l1_rollup_calldata_gas
223,020
868,316
3,449,684

l1_rollup_execution_gas
936,353
3,970,979
24,793,409

l2_block_processing_time_in_ms
1,328
5,125
21,023 (-1%)

note_successful_decrypting_time_in_ms
:warning: 460 (+44%)
1,002
3,683 (+1%)

note_trial_decrypting_time_in_ms
:warning: 69.7 (+132%)
:warning: 30.6 (-76%)
141

l2_block_building_time_in_ms
14,933
59,575
238,661

l2_block_rollup_simulation_time_in_ms
10,609
42,386
170,273

l2_block_public_tx_process_time_in_ms
4,294
17,099
68,066

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
15,854 (+6%)
29,441 (+2%)

note_history_successful_decrypting_time_in_ms
2,530 (+2%)
5,122 (+12%)

note_history_trial_decrypting_time_in_ms
88.6 (+14%)
155 (+10%)

node_database_size_in_bytes
3,619,305
3,715,271

pxe_database_size_in_bytes
29,923
59,478

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
212
44,709
25,561

private-kernel-ordering
138
30,953
14,809

base-rollup
1,081
128,374
881

root-rollup
83.1 (+1%)
4,088
889

private-kernel-inner
288
71,236
25,561

public-kernel-private-input
203
31,891
25,561

public-kernel-non-first-iteration
201
31,933
25,561

merge-rollup
9.84 (+2%)
2,608
881

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
2 leaves
8 leaves
16 leaves
32 leaves
64 leaves
128 leaves
512 leaves
1024 leaves
2048 leaves
8192 leaves

batch_insert_into_append_only_tree_ms
11.2 (+1%)
95.6 (+12%)
16.5 (+13%)
17.9 (+1%)
23.8 (-1%)
50.1 (+1%)
90.6 (+4%)
243
487 (+2%)
913
3,565

batch_insert_into_indexed_tree_ms
N/A
N/A
N/A
64.9 (+2%)
N/A
60.2 (+2%)
111 (+1%)
359
742 (+2%)
1,407
5,555 (-4%)

Miscellaneous
Transaction sizes based on how many contracts are deployed in the tx.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
15,487
31,904

Transaction processing duration by data writes.

Metric
0 new commitments
1 new commitments

tx_pxe_processing_time_ms
344
968

Metric
1 public data writes

tx_sequencer_processing_time_ms
530

This is cool - should we modify noir-contracts and other docs too?
I like that this is a non breaking change


[Bug]: Broken listeners in metadata perspective

Apache Hop version?
2.10.0-SNAPSHOT
Java version?
17
Operating system
macOS
What happened?
Tested all the listeners in the Metadata perspective following are not working

Data profile

Adding/deleting a sampler

Neo4j

Protocol

Unit Tests

replace DB connection
Varialbes

Web Service

run configuration

Issue Priority
Priority: 2
Issue Component
Component: Hop Gui

.take-issue


Skip some more tests that fail with Salt Bundle

As a follow-up of https://github.com/openSUSE/salt-test-skiplist/pull/4, this new PR temporary adds to the skiplist a couple more tests that are currently failing for the Salt Bundle in some OSes.
We need to investigate these tests failures further and then fix them in the testsuite itself. Since fixes are not obvious, we add them here for now until fixed in the testsuite (to allow green executions for now until we fix these detected issues)
Getting rid of these skiplist entries is tracked here: https://github.com/SUSE/spacewalk/issues/23536

Can you update the PR description to explain why we add the tests to the skiplist instead of fixing these now?

All new entries must include a comment that explains why a given test is failing. The pull request description should explain why a test case is not getting fixed and instead added to this skiplist. Pull request reviewers are asked to critically review this explanation.

Thanks for the review @agraul and sorry for the initial empty description! Now it is filled with the required information.


Kat's CSS adds

added google fonts and css code; modified some of the HTML; added some divs

mmmm... not sure if we need an additional comment here... but just in case.


unable to compile native unpacker

I am using android-ndk-r10d,
under "native-unpacker " dir,
using "make" command, at first it prompts:
[armeabi] Compile thumb  : kisskiss <= kisskiss.c
./kisskiss.c: In function 'main':
./kisskiss.c:110:3: error: 'for' loop initial declarations are only allowed in C99 mode
   for(int i = 0; i < found; i++) {
   ^
./kisskiss.c:110:3: note: use option -std=c99 or -std=gnu99 to compile your code

then I added "LOCAL_CFLAGS += -std=c99" in Android.mk
and it passed,  but when I "make" again, it says:
[armeabi] Compile thumb  : kisskiss <= kisskiss.c
./kisskiss.c: In function 'peek_memory':
./kisskiss.c:341:3: warning: implicit declaration of function 'pread64' [-Wimplicit-function-declaration]
   int read = pread64(memory_file, buffer, 8, address);
   ^
[armeabi] Executable     : kisskiss
./kisskiss.c:341: error: undefined reference to 'pread64'
./kisskiss.c:378: error: undefined reference to 'pread64'
collect2: error: ld returned 1 exit status
make[1]: *** [obj/local/armeabi/kisskiss] Error 1

any suggestion?

I suggest repulling the directory and potentially using a more up to date ndk. Works fine for me on a fresh macbook which I've installed the ndk via brew;
[100%]tstrazzere@rocksteady:[~/repo/android/other-test/android-unpacker/native-unpacker] $ ls -l /usr/local/bin/ndk-build
lrwxr-xr-x  1 tstrazzere  admin    47B Jan  6  2018 /usr/local/bin/ndk-build -> /usr/local/Caskroom/android-ndk/16b/ndk_exec.sh

[100%]tstrazzere@rocksteady:[~/repo/android/other-test/android-unpacker/native-unpacker] $ make
ndk-build NDK_PROJECT_PATH=. APP_BUILD_SCRIPT=./Android.mk
Android NDK: APP_PLATFORM not set. Defaulting to minimum supported version android-14.
make[1]: Entering directory `/Users/tstrazzere/repo/android/other-test/android-unpacker/native-unpacker'
[arm64-v8a] Compile        : kisskiss <= kisskiss.c
./kisskiss.c:371:79: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
  printf(" [+] Attempting to search inside memory region 0x%llx to 0x%llx\n", memory->start, memory->end);
                                                           ~~~~               ^~~~~~~~~~~~~
                                                           %lx
./kisskiss.c:371:94: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
  printf(" [+] Attempting to search inside memory region 0x%llx to 0x%llx\n", memory->start, memory->end);
                                                                     ~~~~                    ^~~~~~~~~~~
                                                                     %lx
./kisskiss.c:395:92: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
      printf("  [+] Memory region 0x%llx to 0x%llx contained anticipated class path %s\n", memory->start, memory->end, class_path);
                                    ~~~~                                                   ^~~~~~~~~~~~~
                                    %lx
./kisskiss.c:395:107: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
      printf("  [+] Memory region 0x%llx to 0x%llx contained anticipated class path %s\n", memory->start, memory->end, class_path);
                                              ~~~~                                                        ^~~~~~~~~~~
                                              %lx
4 warnings generated.
[arm64-v8a] Executable     : kisskiss
[arm64-v8a] Install        : kisskiss => libs/arm64-v8a/kisskiss
[armeabi-v7a] Compile thumb  : kisskiss <= kisskiss.c
[armeabi-v7a] Executable     : kisskiss
[armeabi-v7a] Install        : kisskiss => libs/armeabi-v7a/kisskiss
[x86] Compile        : kisskiss <= kisskiss.c
[x86] Executable     : kisskiss
[x86] Install        : kisskiss => libs/x86/kisskiss
[x86_64] Compile        : kisskiss <= kisskiss.c
./kisskiss.c:371:79: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
  printf(" [+] Attempting to search inside memory region 0x%llx to 0x%llx\n", memory->start, memory->end);
                                                           ~~~~               ^~~~~~~~~~~~~
                                                           %lx
./kisskiss.c:371:94: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
  printf(" [+] Attempting to search inside memory region 0x%llx to 0x%llx\n", memory->start, memory->end);
                                                                     ~~~~                    ^~~~~~~~~~~
                                                                     %lx
./kisskiss.c:395:92: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
      printf("  [+] Memory region 0x%llx to 0x%llx contained anticipated class path %s\n", memory->start, memory->end, class_path);
                                    ~~~~                                                   ^~~~~~~~~~~~~
                                    %lx
./kisskiss.c:395:107: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat]
      printf("  [+] Memory region 0x%llx to 0x%llx contained anticipated class path %s\n", memory->start, memory->end, class_path);
                                              ~~~~                                                        ^~~~~~~~~~~
                                              %lx
4 warnings generated.
[x86_64] Executable     : kisskiss
[x86_64] Install        : kisskiss => libs/x86_64/kisskiss
make[1]: Leaving directory `/Users/tstrazzere/repo/android/other-test/android-unpacker/native-unpacker'

so sorry for the late reply,  I didn't know you reply so quickly. will try it now and update the result.

yep it's the ndk version caused the problem. I used brew to install ndk too and it works now, thanks alot for your time!

Not a problem, glad it worked!


[MAINT] split physio metadata tables

Closes #1745
Just for consistency with other datatypes.

to merge in 5 days...


VS Code with NVM

Hi, thank you for great app.
So, I hope VS Code sets specified environment variables when it starts.
I use a NodeJS Version Manager such as nvm, then a path to NodeJS is not added to PATH until nvm do it. (Also NODE_PATH, NODE_HOME, etc.)
That is, CLI of modules such as Gulp, Grunt, UglifyJS, etc. are not work as Task of VS Code. (VS Code can't find out these.)
When I add to PATH a path to these CLIs such as /path/to/nvm/v4.2.4 and call code command, these Tasks work fine. Or when I add a following line to VS Code DIRECTORY/bin/code.js.
process.env['PATH'] += require('path').delimiter + '/path/to/nvm/v4.2.4';

But, When VS Code is started from launcher such as Windows Start Menu, these are not work because Code.exe is called directly.
As everyone knows, NodeJS is updated frequently. A better solution I think is that VS Code sets environment variables written in settings.json that was specified by user. Or user is given a chance such as "Startup Script(or Command)" to do something.

This should only happen on Windows. Other OSs work properly.

This issue occurred in Ubuntu also.
I think that it occurs regardless of which OS.
Paths to node and CLI commands such as gulp are not added to PATH until nvm do it. VS Code can't find out these.

Code does find these in Linux and OS X. Please try it one more time in Linux and confirm that it doesn't work. If that's the case, it's a separate issue.

Yes, I confirmed it again, and I got same result.
For example, I did Tasks: Run Task, and VS Code said "Gulp is not installed on your system".
Of course Gulp is already installed.
I think that getUserEnvironment() makes the process take over environment variables from parent process.
But path to Gulp is not added to PATH yet. VS Code can't find out these because PATH does not include Gulp.
The cause of this issue is unrelated to getUserEnvironment(). The cause is that necessary paths are not added to PATH when VS Code starts.

getUserEnvironment() exists for the specific purpose that Code cannot rely on inheriting the environment from its parent process. It spawns a shell and reads the environment from it.
In Linux, what do you get when you run $SHELL -ilc env? This should print out the correct PATH, one that points to gulp.

Ok, I checked PATH again:
starman@blue3:~$ $SHELL -ilc env
  :
  :
SHELL=/bin/bash
  :
  :
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
  :
  :
NVM_NODEJS_ORG_MIRROR=https://nodejs.org/dist
NVM_IOJS_ORG_MIRROR=https://iojs.org/dist
  :
  :
starman@blue3:~$ printenv PATH
/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
starman@blue3:~$ echo $0
/bin/bash

Of course PATH does not include a path to Gulp, as I said repeatedly. Because Node Version Manager such as nvm adds these paths to the PATH. It in Windows also do the same.
starman@blue3:~$ nvm use v4.2.1
Now using node v4.2.1 (npm v2.14.7)
starman@blue3:~$ gulp -v
[18:06:56] CLI version 3.9.0
starman@blue3:~$ printenv PATH
/home/starman/.nvm/versions/node/v4.2.1/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games

gulp -v above works correctly because the PATH includes /home/starman/.nvm/versions/node/v4.2.1/bin that includes gulp after nvm use.
We can avoid this issue temporarily in Windows rather than Linux, by using bin/code.js (in some cases).
So, the point of this issue is NOT that these paths are not already added to PATH, it is that we have no way to do it when VS Code starts. For example, VS Code sets environment variables a user specified when it starts, or it gives a chance such as "Startup Script(or Command)" to do something. (This Startup Script(or Command) makes nvm run, or it adds these paths to PATH.)
https://github.com/Microsoft/vscode/issues/1895#issue-125768845

Now here's what I don't understand. getUserEnvironment() was implemented to fix this issue: by calling  $SHELL -ilc env, it should've picked up .bash_profile or .bashrc which contains the call to nvm, which would set the variables correctly. I can confirm that works because I also use nvm every day on OS X. It works for me. And my others.
We just have to figure out what is different in your system that makes it not work. Where did nvm configure itself in your system? .bash_profile, .bashrc, some other config file?

Yes, .bashrc loads nvm in my system. And it seems that nvm.sh was done correctly.
I think that you might set nvm alias default before?, or you wrote .nvmrc?
That is, in your system, the paths were already added to PATH before you run nvm use, right? nvm use was already called automatically in some way.
Anyway, nvm default is not set in my system, and nvm use doesn't run automatically in my system. Also, some managers such as nvmw (for Windows) do not have an option that makes it run automatically, as default.
The paths may be already added to PATH when VS Code runs if a manager was called automatically in some way, otherwise these are not.

Maybe, does your system have a default node? (node that was installed without nvm)

I see. So, when you spawn a shell in your system you don't have a node in the PATH? You always need to run nvm use every time you want to use Node?

In some cases, Yes.
In a machine I everyday use, I configured the "auto-run" version manager. In others, for example, I was using nvmw before, but nvmw has some issues for me, then I removed the setting for auto-run. (nvmw doesn't support auto-run itself, then I used "startup" of Windows.) Also, In another machine (Ubuntu), I didn't configure auto-run because I used it to compile some versions of node.
Maybe I think that cases that the auto-run is not used are not uncommon, because this option of many managers is turned off as default. And node is updated frequently.

Got it. I argue your situation doesn't happen often. People usually either have node installed globally or just have a default node set up in nvm. I suggest you do the same.
An environment variable setup in settings.json wouldn't work for your, since you want to add to the PATH variable, not set it. A startup script could work, but you can always achieve that outside of vscode by doing nvm use 0.12 ; code.
Another alternative would be to use a specific node as the task command and point it to the gulp or grunt entrypoints inside the node_modules folder.

Ok.
I made a shell script that sets PATH and calls code, and I am using it instead of code.
I think that this is safety way to avoid using node of involuntary version.
So, my English is very poor. I couldn't explain well, but you interacted very patiently and kindly. Thank you  :smiley:

Thanks for your ideas and feedback!

I'm still a little bit confused by the resolution here. Are you saying users that use nvm must launch VS Code via the terminal in order to have it use the nvm version of node? This is currently the way I have to launch VS Code on OSX to have it use the nvm version.

@vprasanth, no. @anseki seems to not have a default alias in nvm. You are maybe in the same position. You should run nvm alias default node to set up a default. It should work then.

Hi @vprasanth,
If you use a version manager that doesn't support default version such as Windows nvm, as you said, you must call nvm in a terminal before you start VS Code.
But if you use a version manager that supports default version, as @joaomoreno said, you can set default version to start VS Code without calling nvm. And I think that you use that on OSX.

@joaomoreno @anseki sweet thanks! I didn't even know I could do that. I was using nvm use xxxx within my bash_profile. Thanks!

@joaomoreno - It would be great if VS Code ran nvm use before running a node script. This allows each project to specify the version of node to use for that project.

What do you mean by _ running a node script_? Where does this happen?

All of the tools, Gulp, Grunt, UglifyJS, mentioned by the OP in this issue are node.js scripts.
In particular when launching a task to run one of these tools, from VS Code, the editor must be running them via an instance of the node.js runtime.
Since there is now a range of node.js runtime versions available with breaking changes between them, different projects that I work on use different versions. NVM as a tool is great for selecting a version for a particular project, and with the .nvmrc file NVM can automatically set the necessary version by simply running nvm use (i.e. not specifying a version).
So for a concrete example, in the launch.json debug configuration file, I might have
  "configurations": [
    {
      "name": "Protractor",
      "type": "node",
      "request": "launch",
      "program": "${workspaceRoot}/node_modules/protractor/bin/protractor",
      "stopOnEntry": true,
      "args": ["protractor.conf.js"],
      "cwd": "${workspaceRoot}",
      "preLaunchTask": null,
      "runtimeExecutable": null,
      "runtimeArgs": [
        "--nolazy"
      ],
      "env": {
        "NODE_ENV": "development"
      },
      "console": "internalConsole",
      "sourceMaps": true,
      "outDir": null
    }
]

The protractor tool is a node.js script that will currently be run under the default installation of node.js on the system. But if this project requires a different version of node in order to run the protractor script it is stuffed.
Does that make sense?

Here's how you can do it, at least for debugging:

Change runtimeExecutable in your debug configuration to ${workspaceRoot}/node.sh.
Create a node.sh executable file at the root of your workspace with the following contents (adapt to your own shell):

#!/bin/zsh
source ~/.zshrc
nvm run $*

It isn't a great experience, but we don't want to hardcode the notion of nvm into Code. You could maybe convince the vscode-node-debug extension to do so, though.

@joaomoreno thanks for the workaround. I'll take a look at the node-debug extension people.

This issue also affects me. On Ubuntu 16.04 using nvm, I use a node module that checks for /usr/bin/env node, but that doesn't get called properly within VSC, though it works fine in terminal when I run which node since it is properly configured in my $PATH.
Would it be possible to add a custom path to VSC's user settings? We currently have:
"git.path": null,
"php.validate.executablePath": null,

Perhaps it would help to add a custom path for node that way it gets called properly.

Hi @theetrain,
For your information, this is my solution:
I use a shell script that sets environment and starts VS Code.
Since Node.js uses some variables other than PATH, it sets these also:

NODE_HOME : The path to directory that contains node
NODE_PATH : NPM global node_modules directory (e.g. npm root -g)

Or you could execute this before opening code
nvm alias node
Eg:
nvm alias node v4.8.1
nvm alias node v6.10.1

The following worked for me too:
$ nvm use <node_version>
$ code

It would be nice if there is an easier way to switch node versions while you are in the IDE.

The workaround by @joaomoreno worked well for me. I was using bash instead of zsh so I posted the updated script and details over on my blog: NVM and VS Code for anyone who's interested.

After reading this, I got the impression that it would make sense to add "nvm" support to node-debug. So something like "nvm": "6.5".
I've created this feature request.

The above approach (nvm use then launch code) worked nicely for me too.
I've also being specifying the node executable too for the times that I forget to launch code via a terminal. For example:
        {
            "type": "node",
            "request": "launch",
            "name": "generator scribble",
            "runtimeExecutable": "${env:HOME}/.nvm/versions/node/v4.6.1/bin/node",
            "program": "${workspaceRoot}/generators/index.js"
        }

Thanks @biddster
"runtimeExecutable": "${env:HOME}/.nvm/versions/node/v4.6.1/bin/node", worked for me.

Thanks @biddster
I just went into my command line, did a which node to give me my nvm's node location and used that path. For now, I'm very happy.

(Sorry guys, pretty long discussion, maybe I missed what I would like to ask)
My environment:

I have nvm installed (Arch Linux)
I have nvm sourced from .bashrc: source /usr/share/nvm/init-nvm.sh (.bash_profile sources .bashrc)
Node can be found in PATH
I configured its default: nvm alias default node
I do not have global node
Visual Studio Code 1.15.1

So when I run my Node.js project in debug mode in Visual Studio Code (Code was opened via icon) I get an error "Cannot find runtime 'node' on PATH. Make sure to have 'node' installed.". I checked process.env in developer tools and there is no nvm mention. While integrated terminal knows node command and has correct env. variables.
But when I run Code from terminal it works fine and process.env has all nvm related stuff.
Not sure if I should create a separate issue as there were many issues on this topic but I can not find a clear answer why Code running from GUI does not set nvm variables correctly.
Thank you.

Similar issues to @gg-berdzenishvili. I have Linux Mint 18.2 with bash. nvm is sourced in ~/.bashrc but when launching code from the menu or desktop, any extension that relies on node doesn't function correctly such as flow-for-vscode will show an error that node cannot be found in the path.
As others have said, I'm sure I could hack around and make a shell script to set the env variables and then launch code, but I feel this is something one would expect to work out of the box. With the large number of people using nvm to manage node installs, it may be worth it to better the support for nvm out of the box.

I found a way to use nvm-exec to override the default node.js version with the one specified in the project's .nvmrc: https://github.com/Microsoft/vscode/issues/16173#issuecomment-343223708


Please add theme "Vec"

The Repo:
https://github.com/IvanChou/hugo-theme-vec
Vec is a minimal, clean theme for Hugo.
It uses a brief personal page as home, and supports disqus and TOC per-post.

Hello @IvanChou,
thank you for submitting the theme. One last thing before merging it: could you please add the screenshot.png inside the images folder in the required dimensions of 1500×1000 pixels?

I am sorry I have not noticed that. Thank you for reminding me.
I have fixed that already.

Thanks. I've added your theme in 416e974fc9ba46c9016f75c3ef8d4bc3dd5b2d76. The theme site should list your theme soon.
Cheers,
Digitalcraftsman.

Hi, I'm sorry to bother you again
I just find the Hugo Basic Example site doesn't fit my theme, so I add a exampleSite to solve this problem.
Thanks for your hard work ~ 😄😄

I've updated all themes - the demo will be rebuild with the exampleSite.


Make sure downstream sub claim is globally unique even for multi-tenant LDAP servers

I noticed this is somewhat weird for Jumpcloud, since all users have the same ldaps://ldap.jumpcloud.com/?sub=XYZ-style URL, and any sub collisions would be the same across different search bases. Maybe we should encode the search base somehow?
Originally posted by @mattmoyer in https://github.com/vmware-tanzu/pinniped/pull/620#r636518757

We could consider using RFC2255 to put enough data into the URL to make it unique. Note that RFC2255 already defines the sub query to mean subtree search, although maybe we could just ignore that little detail. :)


[REQ] fix license file

Hi there, 1st of all thanks for your cool work !
Since we've "doxed" it in our HyMPS project (under the AUDIO \ Libraries \ Others subsection), can you replace the license with a "GH-compliant" one ?
Although it may sounds like a minor aspect, a "uncompliant" license file causes an inconsistent generation of the relative badge:

(badge-generator URL: https://flat.badgen.net/github/license/mmende/soundengine/?label=LICENSE)
You can easily set a "correct" (= compliant) one through the GH's license wizard tool.
Last but not least, let us know how - in your opinion - we could improve categorization/sorting of collected projects in order to push their evolution by favouring collaborations between developers (and not only).
Thanks in advance.

Bump.
Request updated.

I updated the license file using GH's MIT template. Hope this helps

Thanks a lot, as you can see it works now (click the badge-generator URL) !


[v2.9] No v1.30.x version available for gke cluster

there is no v1.30 version available in rancher  v2.9-head. for gke So testing is blocked for gke cluster for v1.30

@kkaempf / @mbologna , sending it to Highlander team to review and determine next steps.
My (very limited) understanding is we're using release channel that doesn't have 1.30 in there yet (https://cloud.google.com/kubernetes-engine/docs/release-schedule). Will 1.30 automatically appear once it's available in that channel?
If so, we should probably move this issue to v2.9-Next2 milestone and test then when it's available.

/cc @mjura

Additional info:
Current versions list on UI seems matching with GKE NoChannel versions.

Everything is fine according to https://cloud.google.com/kubernetes-engine/docs/release-schedule GKE v1.30 will be released in August this year, after releasing it Kubernetes list in Rancher will be updated automatically.

Nothing to do it can fixed


Atom editor bounces up and down when editing last line

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
The Atom editor bounces up and down when I try to edit on the last line (see GIF below). It does this for any (and every) file type. This problem only occurs on my laptop and never on my desktop.

Versions
OS: Windows 10
C:\Users\Peter>atom --version

Atom    : 1.24.0
Electron: 1.6.16
Chrome  : 56.0.2924.87
Node    : 7.4.0

C:\Users\Peter>apm --version
apm  1.18.12
npm  3.10.10
node 6.9.5 x64
atom 1.24.0
python 2.7.11
git 2.9.0.windows.1
visual studio 2015

Thanks for contributing!
Based on your description and GIF I think this looks like a duplicate of https://github.com/atom/atom/issues/15786 so you can subscribe there for updates if you'd like.  If you have any other details that you can share (e.g. what video card are you using?), please let us know in https://github.com/atom/atom/issues/15786.

Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


⚠ Bofrost.at has degraded performance

In a4508b9, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1855 ms

Resolved: Bofrost.at performance has improved in 94e6b59.


WIP: nixos: update system.stateVersion disclaimer

Motivation for this change
A year ago I asked on discourse if I should ever want to change my system.stateVersion (https://discourse.nixos.org/t/when-should-i-change-system-stateversion/1433). I got my answer, but I thought the comment on the default configuration.nix is a bit misleading. It's meant to tell the user that the user doesn't need to change this value ever, but instead left me to wonder if it should regularly be changed.
Many new users seem to have this exact confusion. By a quick search I found at least 4 threads on discourse where someone asks the same question. I also periodically get hearts on discourse to my last message in the thread, where I state that I understand now that I should never change system.stateVersion. The thread also has more than 1 200 views, which is way more than a simple question should get. I think this is an indication that many users search for an answer to this same question.
I propose that the message to be reworded, but am unsure about the best wording. My current change is just an example, which I intend to replace with a better text. Any ideas about a better message?

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/when-should-i-change-system-stateversion/1433/12

Here's another official place that documents stateVersion: https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/misc/version.nix#L54

I created https://github.com/NixOS/nixpkgs/issues/88948 not knowing that this PR already existed.
I think that this PR moves in the right direction, but I would make two suggestions:

The updated comment doesn't explain why stateVersion should never need to change. OTOH, that setting's description does it quite well: https://github.com/NixOS/nixpkgs/blob/147aded7df024288a387e1dde290f79f964e41bf/nixos/modules/misc/version.nix#L56-L73 Why don't we simply use this description as the comment? IMHO, the description should first be updated to make it a little more beginner-friendly as it assumes a high level of knowledge about NixOS' internal structure (e.g., "You should only bump this option, if you are sure that you can or have migrated all state on your system which is affected by this option").
We should get rid of the "Did you read the comment?" parenthetical. At best, it has a bad doc smell--if you have to tell the reader to reread the previous section, there's a more fundamental problem. At worst, it has a somewhat passive-aggressive tone and could even be interpreted as condescending toward the reader.

I it is worth noting that the comment in the configuration.nix has been changed in january 2020:
https://github.com/NixOS/nixpkgs/pull/77279

I will close this, since it is about changing an out-dated version. Please feel free to open again or a new PR if you want to improve on the status quo.


minipro-updater: init at unstable-2022-03-04

Description of changes
I used this package to upgrade the firmware of my minipro TL866A programmer.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Please also use the unstable- prefix in the commit title


change go api package

remove  old genernate operation in CI  & change package

The next step should move the dependency to skywalking-goapi repo, @EvanLjp gets blocked by his network issue.

Consider adding satellite/internal folder into goapi repo, and move proto with generated source codes there. Is this better?

Consider adding satellite/internal folder into goapi repo, and move proto with generated source codes there. Is this better?

import paths containing internal is not available outside of the goapi module, this is restricted by Go compiler if I remember correctly

Consider adding satellite/internal folder into goapi repo, and move proto with generated source codes there. Is this better?

import paths containing internal is not available outside of the goapi module, this is restricted by Go compiler if I remember correctly

Any suggestion? My point is only hosting generated codes in goapi repo.

Now the import path in this repo is github.com/apache/skywalking-satellite/protocol/gen-codes/satellite/protocol, I think adding satellite folder in goapi repo is enough, now

@EvanLjp Take a look.

Now the import path in this repo is github.com/apache/skywalking-satellite/protocol/gen-codes/satellite/protocol, I think adding satellite folder in goapi repo is enough, now

add a proto file in go-API rather than download the proto file?

Now the import path in this repo is github.com/apache/skywalking-satellite/protocol/gen-codes/satellite/protocol, I think adding satellite folder in goapi repo is enough, now

add a proto file in go-API rather than download the proto file?

Create a folder satellite in goapi repo, and add the proto files (i.e. Event.proto), and their generated .go files there. Then we import the goapi module in this repo.

okay


Add dev recipes for all Links

Today we have dev recipes for Redis and Mongo. We need dev recipes for the remainder of the Links:

Applications.Link/rabbitMQQueues
Applications.Link/sqlDatabases
Applications.Link/daprPubSubBrokers
Applications.Link/daprSecretStores
Applications.Link/daprStateStores

Definition of Done

CLI code updated to handle other resource types (today each resource type is hardcoded in the CLI logic)
Dev recipe added to the recipes repo under the dev directory

AB#8413

This is now complete with the completion of https://github.com/radius-project/recipes/pull/52


uv pip compile --no-header flag should delete existing headers for feature parity with pip-compile

If I have headers already in my requirements.txt and run pip-compile with --no-header, the headers will be deleted in the output requirements.txt
With uv pip compile --no-header, the existing header still persists.
My use case is that I expect there to be no header when I pass --no-header, so that I can write my own custom header.
Currently on uv 0.1.22

Are you writing to the requirements.txt with -o? In my testing we do clear the header, so I can't reproduce this.

No, not using -o. I'll see if I can reproduce it in a simpler setup!

Unlike pip-compile, we don't output to a requirements.txt implicitly. You have to specify -o. Could that be it?

Yeah that sounds like it's probably it. Thank you!


Fix ~160 invalidations from partially-inferred kwargs to Header

These get invalidated by loading Static.jl, specifically the method
Base.convert(::Type{T}, ::StaticInt{N}) where {T<:Number,N} = convert(T, N)

CC @ChrisRackauckas

Actually, the original fix isn't complete: now, a smaller number of invalidations happen due to https://github.com/SciML/Static.jl/blob/bf61620eeeb0ca0d66be5fb6fe0838f6f85bf200/src/int.jl#L26.
But it looks like the value-types of paths are always String, Symbol, or Int64, so that makes life easier.


deploy project to github pages

lot of changes whoops:

moves front-end folder to root
removes any local anchor redirection
remove browser router and changed to hash router
no more cors error that's nice
project deployed here: https://tangym27.github.io/DrinkingBuddies-Proj/

Are you able to do dynamic pages in github pages?

Are you able to do dynamic pages in github pages?

What do you mean by dynamic? Our pages make API calls and will change based off of user interactions (ie compiled page & quiz page) but most of it is generally static.


[CM][CI] Enable regular CI for TVM

The problems described in #1 arose due to the fact that the pipeline for TVM was launched only when opening PRs against branches test and dev (link).
This is due to the fact that this pipeline uses building of TVM from the source code, which takes ~50 minutes. It was too long to run this pipeline against master branch.
Recently, to avoid long build times, a new pipeline has been added that uses pip to install a pre-built TVM. However, this pipeline only runs on test branch (link).
It is necessary to check this pipeline and make it run against master branch.

@KJlaccHoeUM9l

I opened a PR where tvm-onnx CI check for ResNet50 inference is enabled against master branch and looks like it works correctly.
Because of the problem mentioned above and in order to reduce the working time of this workflow the _short variation was specified for test in submission mode. Also, I removed some default batchsizes that were set for tvm-onnx and tvm-pytorch backend in this commit as it caused an old error with model shapes mismatch so without it workflow seems to work properly, at least all CI checks have been passed

I think it can be closed as this PR has been merged


Add example for distributed learning

Signed-off-by: Diwen Zhu<EMAIL_ADDRESS>
What do these changes do?
This example demonstrates a distributed learning example using dask + horovod + v6d, which extends a real-world keras example with few lines of modifications.
Related issue number

Fixes #issue number

In favour of #487.


[Docs] Translate functionality section to Spanish

Current State:
Documentation is in English
Desired State:
Translate funcionality section to Spanish
Contributor Resources

Meshery documentation site
Meshery documentation source
Instructions for contributing to documentation

I will to translate it :)

Excellent. 😄 Thank you, @jlcastrogro


Deprecate daml navigator

Part of https://github.com/digital-asset/daml/issues/18650
Daml PR: https://github.com/digital-asset/daml/pull/18748
docs.daml.com PR: https://github.com/digital-asset/docs.daml.com/pull/658
Originally, this PR also removed daml navigator from the 3.0.0 docs. However, that's a larger piece of work since the navigator is heavily referenced from a few tutorials so they will need to be reworked. I've thus split that off as https://github.com/digital-asset/docs.daml.com/pull/659.

Originally, this PR also removed daml navigator from the 3.0.0 docs. However, that's a larger piece of work since the navigator is heavily referenced from a few tutorials so they will need to be reworked. I've thus split that off as #659.

Sounds good -- thank you. Also a reminder that the 3.x docs will be re-created from scratch from 2.9.0 soon, so it's probably better to hold off on making any changes to 3.0.0 (or you'll need to redo them later).

Originally, this PR also removed daml navigator from the 3.0.0 docs. However, that's a larger piece of work since the navigator is heavily referenced from a few tutorials so they will need to be reworked. I've thus split that off as #659.

Sounds good -- thank you. Also a reminder that the 3.x docs will be re-created from scratch from 2.9.0 soon, so it's probably better to hold off on making any changes to 3.0.0 (or you'll need to redo them later).

Yes I've heard about this before. It should be possible to cherry-pick the commits though, right?

Originally, this PR also removed daml navigator from the 3.0.0 docs. However, that's a larger piece of work since the navigator is heavily referenced from a few tutorials so they will need to be reworked. I've thus split that off as #659.

Sounds good -- thank you. Also a reminder that the 3.x docs will be re-created from scratch from 2.9.0 soon, so it's probably better to hold off on making any changes to 3.0.0 (or you'll need to redo them later).

Yes I've heard about this before. It should be possible to cherry-pick the commits though, right? @marciw-da


Import multiple only loads one

The import prompt shows imported several and to save each - but only one shows in the dropdowns.

W10 20H2 (OS Build 19042.867)
Chrome Version 89.0.4389.128 (Official Build) (64-bit)
They do save properly one at a time.

BTW - Midnight-Lizard is one of the most amazing works of Code in digital history.

That's correct. You can find all imported color schemes in the drop-down menu but only one can be saves at a time.


WPF Support

Is that work in WPF?
I have created a project in xamarin form for wpf, android and ios. I need this feature in android. but it's ok, if that will not work in WPF with out any library missing error. Will that work ?

You wanna just add some missing error?

I have not implement this lib yet. Just want to confirm that is that work on WPF project ?

No, wpf doesnt supported


Optimize 2D Delaunay and make it more readable

Co-authored: Dimitri Tabatadze<EMAIL_ADDRESS>(Supersedes #65280)
To summarize:
Around 2.85x speedup
Original PR:

Triangle now stores the circumcircle's center and circumcircle radius squared. Both are stored in create_triangle() and don't have to be recalculated.
Stores edges in a sorted manner so they are easy to compare.
Simplifies the main loop in the triangulation routine by marking polygons edges as bad instead of triangles.

The first bullet point is a major optimization, while the other two are small optimizations. Together, they add up to a 2.85x speedup.
My additions:

Returns the empty triangles vector immediately if there are less than 3 points, making the routine "free". Otherwise we know there are points, which simplifies finding the bounding rect.
Implements vector filtering when the fake triangles are being removed.

With a minimum of 6 elements to be removed from the final triangles vector, filtering is always a speedup (microbenchmarked to make sure). This optimization is usually not noticeable, but in best case scenario (where vertices are on the outline of a squircle) the performance gain I measured was about 5%. I hoped for better, but I'll take it.

Also small code simplifications and improved comments in both the original and mine. Note that the optimization changed the order in which triangles are returned and their vertices are ordered (although triangles are still always oriented CCW). The order was never expected to be meaningful, so this shouldn't break any existing user code; this algorithm isn't even used in our codebase.

Co-authored: Dimitri Tabatadze<EMAIL_ADDRESS>(#65280)

Note you haven't added co-author in the commit, see: Creating a commit with multiple authors.

Did I do it right? :cold_sweat:

Did I do it correctly now? :cold_sweat:

No, you can see still only your GH account is attributed:

Almost all good, you've just missed the angle brackets around the email (should be <an_email> instead of an_email).

Thanks!


Suggestion for detecting spam

You know, I can usually pick spam just from the thread title. Here are some examples from today:

Forward my lap you're right this
He continued in his exercise equipment room
Buy Real/Fake Passports,Driver’s License,ID Cards,Visas, USA
Top Quality Documents Homes - Purchase Real and Novelty Passports,id cards,
Buy Real/Fake Passports,Driver’s License,ID Cards,Visas, USA Green Card,Citizens
Best Counterfeit EURO & DOLLAR NOTES,PASSPORTS,ID,
Buy Real Genuine data base Registered and driving licenses

How about this?
For moderators, show a list of new threads, started by people with no posts (ie. this is their first post) with the thread title and a link to check the thread out. Then have a big button: [ SPAM ]
This could appear at the top of every page. And maybe have a [ NOT SPAM ] button, so we can quickly eliminate posts that are genuine.
I'm still surprised that with this new forum, we can't auto-detect spam, like "passports".  Come on, this isn't rocket science.

The first spam post reads:

Forward my lap you're right this in the mirror image process gauge place attorney he loved his engage in the cafe and loss walking %eh answer me on Reach Out grab the ball usual czar power on remember stern are back drop the ball this is all dynamic
alpha shred
just rose leveled up imaginary ball grapples this cable and again we're going to work live sax triceps NHS here cable fully and work a lot goal 3 shoot what Ashley's .

 But really, can't we outsmart these guys? They might be smart, but we are smarter, right?

An effective mechanism would be a simple honey pot on the 'New topic' page. Combine that with another text box containing some text saying "Remove this text to post" (possible language problem).
Then on the server, a check to ensure the honey pot is still empty, and the text has been removed from the second field will allow the server to reject bots effectively.
Of course its useless against targeted attacks, but I would argue that it will eliminate almost all of the random spam/advertising posts which is what we seem to be viewing. (targeted attacks would be in high volume, like in the past where 100,000 users were registered in a short time).

@matteosuppo please give us a time evaluation for this task. It could be very handful.

Or we could add a captcha for the first message someone posts.
Il giorno lun 12 gen 2015 12:26 Luca Cipriani<EMAIL_ADDRESS>ha
scritto:

@matteosuppo https://github.com/matteosuppo please give us a time
evaluation for this task. It could be very handful.
—
Reply to this email directly or view it on GitHub
https://github.com/arduino/forum-issues/issues/162#issuecomment-69557178
.

I think spammers are able to work around captchas by now. They are probably working from home being paid practically nothing, and getting paid per message they manage to post. If they have to type in a captcha they will. What we need is a quick way of responding. Plus, as I have said many times, and I'll say it again, how come a message with "fake passport" in the title is even allowed to be posted?

After seeing another spam post, I think "testosterone" is another word that doesn't generally appear in electronics or programming circles.

One thing that would be useful in combating spam here is to identify the nature of our attackers. My first questions would be:

Are most spammers humans, or bots?
Are most spammers attacking SMF forums in general, or this forum in particular?

Now if we find that most spammers are bots, then a simple question that is easy for a human to answer but hard for a bot, would help. For example, show pictures of a dog, a train and an aeroplane, and ask them to "tick" the dog (randomizing the order of the images, of course).
A human can answer that easily, a bot would have to interpret the image.
And if SMF is being attacked (but not us in particular) then fudging a "signature" that identifies us as an SMF forum, or changing the field names on forms, might slow bots down.
If we are not being attacked specifically (only because we use SMF) then an extra page that people have to negotiate for their first few posts might slow bots right down, because that is not standard SMF procedures. Such as, "what is 5 + 7?". Or "click on the ostrich".
To answer my questions, and therefore fine-tune our spam response, we could trial something like the idea of identifying the picture of the dog. If that slows spam down, then we are being attacked by bots. If it doesn't, then we are being attacked by humans.

I just saw an interesting variation on the captcha:

The letters are fairly easy to read, but you don't type all of them in. This might slow down computer-recognition schemes because they have to "look up" to see which letters are to be incorporated in the response.

With the new filter in place can I close this issue?

The new system seems to be working well, so yes you can close it. (Or I will).


[full-ci] [tests-only] Bump commit ids for tests

Bump core and web commit ids for tests
part of https://github.com/owncloud/QA/issues/684

waiting for PR https://github.com/owncloud/core/pull/39102 to be merged (it fixes the failing test apiWebdavUpload2/uploadFileUsingOldChunking.feature:103)


Adapt intrinsic-jsx for React 19

CC @Abse2001
/bounty $10

The PR should update the @types/react dep to a 19+ version (it's locked at 18 atm)

The PR should update the @types/react dep to a 19+ version (it's locked at 18 atm)

@seveibar Already done that I will PR

/attempt #98


Publish docker image to dockerhub.

This would greatly facilitate users to use pre-built image.
I guess we need to package for debain first so that we can configure through docker-jitsi-meet.

We are still beta testing this.

Hey @saghul, is there update on this?

Not yet, sorry.

https://hub.docker.com/r/jitsi/excalidraw-backend


Integration Test - Release - 2019/02/22 12:58:20

Auto create for integration test. CommentIssueFlow

#pri1

Just type '#backlog'

#pri2

#backlog

#please-close


Improve WindowController drawing code

Look at the TODOs for more info, the file is littered with it.

Somewhat better, but there are still a lot of todos


[ZEPPELIN-1828] Flaky Test: RemoteInterpreterTest hanged in zeppelin-interpreter

What is this PR for?
When interpreter.close() occurs in code it shuts down RemoteInterpreterEventPoller and then tries to close thrift connection. While closing thrift client will wait until events queue is empty. If RemoteInterpreterEventPoller has not processed all thrift events before the shutdown signal comes, thrift client will wait forever. As a result Travis will terminate the build after code is not responding for 10 minutes.
What type of PR is it?
[Bug Fix]
Todos
We need to:

[x] - write a test that checks that event queue is empty after RemoteInterpreterEventPoller is done,
[x] - clear unread events on RemoteInterpreterEventPoller shutdown signal.

What is the Jira issue?
ZEPPELIN-1828
How should this be tested?
This issue can be reprodused if you put Thread.sleep(3000L); to  RemoteInterpreterEventPoller.java
...
} else if (event.getType() == RemoteInterpreterEventType.OUTPUT_UPDATE_ALL) {
    Thread.sleep(3000L);
    ...
}

and run RemoteInterpreterTest.java.
Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

Thanks @AlexanderShoshin for the fix!
LGTM and merge to master if no further comment!


asyncCallback - performance and related questions

Context: How would callback heavy code perform under GHCJS? For example, most Elm-like architectures require a callback to triggered on almost every user-interaction to update the model state (eg. keypress in an input, on-hover to add/remove classes, etc.)

If said callbacks are JS => Haskell callbacks, what kind of performance can one expect?
When should one call releaseCallback on such callbacks? Would they be automatically released if the underlying DOM node (on which click/keypress/hover callbacks are registered) is destroyed?

My approach is to export one callback at application startup, capture events at the root of the document (ie. add a single event listener to document.body), and dispatch the event manually to the correct place inside the Haskell code. That way JS/DOM doesn't have to retain any references to Haskell values, and I don't have to export/release tons of callbacks while the application is running.


Allow strings for S3

This pull request allows strings for S3 buckets.

@dnicolson you've used oneOf incorrectly here. Please look at #48


Merging back SymphonyOSF onto upstream symphonyoss before public announcement

Creating this PR since @lneir and @mike-symphony  confirmed full access to the https://github.com/symphonyoss/SFE-Minuet-DesktopClient open source repo.
We are sending out a public announcement today via blog.symphony.foundation about the Minuet contribution, so if you were able to merge this PR today the optics would be much better.
Appreciate if you could also drop this branch once contributed.
Thanks!

lgtm

Great. Was this merged then @lneir? Still shows open to me (but am on mobile)


chore: maintenance

clippy delints
add deny(clippy::pedantic) to make lint warnings stricter
make code more idiomatic
improve logic in some places or partial rewrites

@pewsheen @wusyong if one of you is available, please review this.

Hey sorry for the late reply. I'm been busy on my work recently.
We haven't decided if we should follow any clippy rules yet.
And I would like to keep compositor as close to servo's one as possible.
This PR might not be the right time to merge yet.
But feel free to open more if there's any bug fix.

I could then remove deny(clippy::pedantic) from the code. Is there anything else you'd like me to change before this becomes useful?


Revert some PRs, fix master

Let's see if this works

@wilzbach Apologies, I had to revert 3 of your today's PRs to urgently get master green again. I've also fixed the bug which caused DAutoTest to vet bad PRs that had hidden dependencies which it previously did not detect (the problematic PRs were #1671 and #1590). Please rebase and resubmit them.

@wilzbach Apologies, I had to revert 3 of your today's PRs to urgently get master green again.

Oh I am terribly sorry about this.

I've also fixed the bug which caused DAutoTest to vet bad PRs that had hidden dependencies which it previously did not detect

Good to know :)

Please rebase and resubmit them.

Ok.

Please rebase and resubmit them.
Ok.

They are #1684, #1685, #1686 - I rebased them individually to master, which has the disadvantage that I probably need to rebase them again once you start merging them, but OTOH isolating the passing from the faulty ones is easier this way.


expose google provisioning model to be able to acquire spot instances

Signed-off-by: Tomas Lamr<EMAIL_ADDRESS>What this PR does / why we need it:
Hello, we wanted to expose node selection API from google (SPOT/STANDARD) so that we can create a node pool of spot instances as in aws.
Special notes for your reviewer:
I'll happily change it the way you want :) just please let me know how you would prefer it to look like.
I'm new to go and even unsure about that ref to bool.
Cheers,
Tomas

Difference between preemptible and spot according to them:
However, Spot VMs provide new features that are not supported for preemptible VMs. For example, preemptible VMs can only run for up to 24 hours at a time, but Spot VMs do not have a maximum runtime. This page describes preemptible virtual machine (VM) instances.

/ok-to-test
/hold

@tlamr can you please look into the failing CI jobs?

Hello @ahmedwaleedmalik, I'm not an expert but I can see 20x this error and then it seems to give up.
`Error: network limit reached (resource_limit_exceeded)
with hcloud_network.net,
on hetzner.tf line 10, in resource "hcloud_network" "net":
10: resource "hcloud_network" "net" {
...
Creating cloud provider env failed!
Cleaning up machines.`

Error: network limit reached (resource_limit_exceeded)

This is unrelated to your PR. I'll take care of this issue.
Meanwhile can you check the logs for https://public-prow.loodse.com/view/gs/prow-dev-public-data/pr-logs/pull/kubermatic_machine-controller/1252/pull-machine-controller-lint/1514635654829445120

/test pull-machine-controller-e2e-aws-arm

/retest

@tlamr I have updated the description of your PR and made it compliant with the required template.

@ahmedwaleedmalik Awesome, thank you! :)

@tlamr Thank you for the awesome work, it's a very valuable addition to the GCE config.
I have made some amendments with https://github.com/kubermatic/machine-controller/pull/1252/commits/1383ada7c828c12a4be73d3168edbc4c40d516e6. Can you please take a look? This is what I was trying to suggest earlier. Do let me know if that makes sense for you.

/retest

1383ada

ah, ok, thanks a lot! :)


Issue: Prevent Novel Editor from Overwriting Tailwind CSS Styles #184

Hi everyone,
I've noticed an issue with the Novel Editor that's causing it to overwrite Tailwind CSS styles in my projects. This is causing some unexpected behavior and conflicts.
I believe it would be beneficial to find a solution to prevent this overwriting. It could improve the overall compatibility and usability of Novel Editor with projects using Tailwind CSS.
I'd appreciate your thoughts and suggestions on how best to tackle this issue.

We have the same issue with our app and using shadcn/ui. Also dark mode doesn't play nicely because shadcn/ui uses "dark" and "light" classes on html and Novel uses "dark-theme" and "light-theme"

you just need to update your config
see: https://github.com/steven-tey/novel/blob/main/apps/web/app/providers.tsx

PR #161 will fix this, I think. Not sure the progress on that though. It's been sitting waiting for integration for about 3 weeks now. @steven-tey


Add eslint

As ESLint to project

https://eslint.org/docs/user-guide/configuring
Tests: mocha, browser
Code: browser, es6, amd (because of Browserify)
Maybe use this one: https://github.com/google/eslint-config-google
"extends": ["eslint:recommended", "google"]
But this is mostly up to you


Setting authorize_params resource to https://outlook.office365.com/ breaks auth

Hi @simi! I've been using your gem to integrate our app with office 365, and I really appreciate the work you're doing maintaining this :heart:
I have a small niggle though. In our app we want to access tokens for the Mail, Contacts and Calendar API at https://outlook.office365.com/ - mostly for https://outlook.office365.com/api/v1.0/me/messages - which means we have to pass that as the resource (otherwise we'll get tokens we can't use).
However, that breaks raw_info because there's no API at https://outlook.office365.com/Me?api_version=1.5. When raw_info breaks it takes the rest of the auth with it and all we get is an obtuse OAuth2::Error with no message.
I've fixed this in my app by switching raw_info back to what it was in your initial commit. Then I can pass  option :authorize_params, resource: 'https://outlook.office365.com/' just fine and everything works.
I don't know exactly how to fix this here. But I'd definitely wish for more documentation (which I'll gladly help out with if you want).
Thanks again :heart:
===========
Another point that I'd love to have documented is that the resource must end with a slash, otherwise raw_info is again broken because it will create a URL like .comMe?api_version=1.5, which you get an equally obtuse error from Net::HTTP for.

Hello @kaspth. Thanks for info. I'm going to review this and try to fix it. But I'm not sure if my Office365 account is still valid. Let me inspect first.


Enable single transaction groups

Waiting for confirmation from the Foundation

recheck

I have read the CLA Document and I hereby sign the CLA

recheck


datepicker-popup does not heed min-date when manually inputting date (0.13.3)

When min-date is set, the user can still manually input a date before min-date, and it gets succesfully bound to the model. I would expect that the model would not get bound when a date outside the allowed range is inputted manually, and the field would be set $invalid.
See plunker demonstration.

I believe this was always an issue - the datepicker does not clear the model like the timepicker.
The validation should definitely occur though, so that is a missing functionality.

This appears to be a usage issue: http://plnkr.co/edit/U60gYOY0jRHQHAQZbp3Z?p=preview - one should not be able to manually input a prior date to the min date.
The documentation needs updating to be clearer, but this is planned for the 1.0 release.


Small fix to docs

Description
Services names in getting-started guide are outdated.

@josemigallas That is blocked by actual release. We haven't released that yet.
If you are interested in contribution take look on contributing guide.
User guide is just template that will need to be adjusted when we release.
We have ticket to cover this work and then we will provide actual names

+1 on what @wtrocki we should close that for now and revisit in the future

@wtrocki @danielpassos We could keep it coherent in the meanwhile


flatMap Deprecation and Overlapping accesses issues

Class:
XCGLogger -> Core -> URL+XCGAdditions.swift
Issues:

I'm receiving the following warning using Pod version 6.0.2
'flatMap' is deprecated: Please use compactMap(_:) for the case where closure returns an optional value
'Overlapping accesses to 'data', but modification requires exclusive access; consider copying to a local variable' Lines 26 & 70

There's already a patch for it, but the updated pod is not released yet.
Meanwhile, you can change your Podfile and use the master branch:
pod 'XCGLogger', :git => 'https://github.com/DaveWoodCom/XCGLogger.git'
Then do a pod install and the warnings should be gone.

Ok, thank you @ijaureguialzo. I appreciate the advice and look forward to the update.

The overlapping access is now a failure with the new Xcode beta released today.  Any chance of getting a release?

Yes. Working on it.

Excellent, thank you.

6.0.4 is now available as a pod etc. Fixes these issues (and a few more).


Develop certificate provider module that can reach out to Istiod CA over gRPC and fetch and rotate certificates

The "fetching certs" part is done. Now we need something to cache them and rotate them.
What we want:

In SecretManager, store a cache of certificates we own
For each cert, at 50% of its lifetime, refresh it. See secretcache.go in agent for prior art here, although it can likely be a bit simpler here (I think we can just spawn a task with sleep(TTL); refresh or something)
When a new workload on the node is discovered, pre-fetch its cert (if we don't have it yet)
SecretManager.fetch_certificate uses the cache when possible.
If we race on explicit fetch_certificate call and pre-fetch, we should only have 1 request to the CA and both await it; a CA request has high cost

zTunnel can request cert on behalf of workload
Certs are pre-fetched on workload discovery
Certs are cached and re-used
Certs in cache are automatically rotated

first PR merged o Fri 11/19

Split cache on discovery into separate issue, then mark this one done.


chore(deps): refresh deps and pin releasetool version

Release PRs were not getting updates due to an issue with cryptography major version upgrade since version 39. This issue was fixed in newer version of gcp-releasetool.
Confirmed the new commits fixed reporting back, albeit a failed result but expected (it has already been successfully published): https://github.com/googleapis/sphinx-docfx-yaml/pull/335.

[x] Tests pass

Kokoro failure can be ignored as it was a re-run of the already released binary, which is expected to fial.


ET1 PDF update

The ET1 form has been update & in order for the application to be brought up to date the PDF template we use to inject content into needs to be replaced along with the syncing up of any respective changes made in the new PDF.
The new document removes an acas exemption reason which requires the same radio selection to be removed from the application.
With the removal of one of the acas exemption reasons we now have claims that people can return to(i.e not submitted to jadu yet) that have the old acas reason associated with one or more of the respondents. This shouldn't be a problem though as the save and complete forces a user to go through all of the form pages when the user returns. As the old reason is no longer in the the accepted reasons lists the respondents & additional respondents pages will fail validation, showing the user an inclusion error message prompting them to select a new reason.
Claims that have been marked as submitted or payment required needn't be concerned with this legacy change as the claim is locked out & besides Jadu would have already received the claim.

Like I mentioned in person to @dan-palmer the code looks fine, it's mostly business logic here...


resentobel

resentobel created by<EMAIL_ADDRESS>on 2017-02-28 12:52:02

<EMAIL_ADDRESS>replied, Any ideas on the word resentobel? Â This is the title of an old song, with the opening phrase: Â "resentobel kersos era renguk, chelebuul el ngara kokyo"
kokyo is Japanese for "home town, birthplace, etc."
Maybe the plural of "sentobel"? Â but I don't know that one either

<EMAIL_ADDRESS>replied, in any case it looks like a nonindigenous word in Palauan, because it contains N. the first i had thought after reading this topic was also the plural of sentobel.

<EMAIL_ADDRESS>replied, I donâ€™t recognize this word at all. I donâ€™t even know how I would say it. Even if it had an â€œngâ€ I just donâ€™t know.
ï£¿souang

<EMAIL_ADDRESS>replied, Could you share a clip with the song please?
I'm in Palau now and I just asked what resentobel means.. And an older man
who used to sing in the older days say it's not resentobel but that the
song actually says "bresento el kesos ra renguk." The word "bresento" is
the word "present" as in gift but is pronounced like that. So, essentially
it means "the gift which is precious to me" or close to my heart.
Perhaps, over time as people sang the song it eventually changed to
risentobel...
Jelg

<EMAIL_ADDRESS>replied, Various recordings along with other information can be found hereÂ https://ouchacha.wordpress.com/2017/03/04/resentobel/
Sent from Yahoo Mail on Android


The "Latest" header on the homepage

I notice that my 5th newest blog article and older are listed under the "Latest" section below the "Subscribe" section on the home page. I am using the "Highlight" header style. I am running Ghost v5.70.1, and Source v1.1.0.

Is this "Latest" header referring to the items below it, or above it?

The Highlight header shows the first 4 posts (1 on the left, 3 in the middle). Then the Latest section displays the posts starting from fifth which is intended.


Cherry-pick formatter fixes to releaes/3.1.x

Description of changes
We need #856 for smooth cherry-picking.

#867
#861
#870

I thought our policy was to support the latest minor in supported majors? If that's the case, then the fixes only need to be in 3.2.x.

I thought our policy was to support the latest minor in supported majors? If that's the case, then the fixes only need to be in 3.2.x.

I thought the same but saw #865 is included in a 3.1.x release.

Closed as we don't support 3.1 as of now.


TypeScript error if imported package contains <reference types="node" />

$ yarn run build
yarn run v1.22.17
warning package.json: No license field
$ build-figma-plugin --typecheck --minify
info Type checking...
error TypeScript error

    node_modules/@figma/plugin-typings/index.d.ts:10:9 - error TS2649: Cannot augment module 'console' with value exports because it resolves to a non-module entity.

    10   const console: Console
               ~~~~~~~

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Fixed as of 1.7.2

What exactly was the fix here?


feat: add style for cards

Covers mobile, tablet & desktop views.
Fixes #6
Test URLs:

Before: https://main--macquarie-help-centre--hlxsites.hlx.live/personal
After: https://cards-layout--macquarie-help-centre--hlxsites.hlx.live/personal

In desktop view, the left and right padding for the cards should be more

@asthabh23 for which width exactly you see this? Maybe it's because of the new breakpoints?
The way I've mapped them is:

568px → 600px
768px → 900px
1024px → 1200px

@volteanu , so basically I am talking about margin around icon+text on the cards. if you see on the original site, the icon and text collectively have a margin around them so the text is more compact.
can you please align it that way?
basically instead of adding margins individually to icon and text, add margin to both combined

so basically I am talking about margin around icon+text on the cards
got it! I was looking at the margin of the cards themselves. Will adjust.

so basically I am talking about margin around icon+text on the cards
got it! I was looking at the margin of the cards themselves. Will adjust.

Figured out what the problem is: I've initially mapped the padding for min-width: 1024px to min-width: 1200px. I've now adjusted to match the original min-width: 1280px, but we're losing the style for 1024px. (we have only 4 views compared to originally 5).


Push updates

@lbbrhzn, progress towards updating metrics when data is received rather than awaiting the poll. There may be a better way to do this.

Because we already have callbacks when new data arrives eg @on(Action...) and multiple entities per device we know when sensors need updating without adding a listener on the sensor which is perhaps better but more complicated. I took the approach of updating all metrics as we don't have many entities rather than trying to update specific metrics based on data received.
Maybe rather than use the entity components update, it could be better to use Entity.async_schedule_update_ha_state(force_refresh=True) not sure though...
I kept polling on for now as a backstop in case something is missed in the push

By making metric a class (with value and unit properties) that allows subscriptions, you can inform subscribers when there are changes.
Something like this (Pseudo code):
ChargePoint:
self.metrics[current].value=new_value

Metric:
@value.setter
def value(self, new_value)
  self.value=new_value
  self.notify_subscribers()

Sensor:

add_to_hass():
  metric.subscribe(self.async_notify)

def async_notify(self)
  await self.async_write_ha_state()

@lbbrhzn, your approach is more elegant. Up to you whether to merge this as an interim while you work on the subscriber approach.

Ok, let's use this as an interim approach.


Add Calcified rocks

Varlamore update introduce Calcified Rocks to mine

I'm currently working on adding it to the plugin.
I will update when I have added it and waiting it for the plugin to be updated on runelite.

I've submitted for review and will be updated as soon as possible. It's only basic support for it but I will hopefully get it working fully soon.


Polymer 3 support

This may be a bit premature, but are there any plans for this element to support Polymer 3, i.e. ship as an ES6 module published on the NPM registry?

Yeah, it is in the plans, but it might take a while. The other option i am
thinking is a complete re-write to be only Polymer 3 compatible and to only
provide the pop-up part. The input field part should be handled by the
user, but they are just my first thoughts on this. What do you think?
On Sat, May 12, 2018, 23:59 Oliver Hamlet<EMAIL_ADDRESS>wrote:

This may be a bit premature, but are there any plans for this element to
support Polymer 3, i.e. ship as an ES6 module published on the NPM registry?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ellipticaljs/paper-autocomplete/issues/121, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAUumdEVyMHE6HXkAQXcYutrMFCDh-Vzks5txvjjgaJpZM4T8cdc
.

I think that would be more flexible, but I don't have any strong opinion either way. The element works well for me as it is. 🤷♂

Hi @jhuesos It would be nice to publish v3.0 with the same API and only after that adding new features. Developers already requiring v3.0. Thanks.

Noted. I'm this week on holidays outside the country. I will do my best to
do this once I'm back. Of course, PR are always welcome :)
On Tue, May 22, 2018, 03:10 Makhambet<EMAIL_ADDRESS>wrote:

Hi @jhuesos https://github.com/jhuesos It would be nice to publish v3.0
with the same API and only after that adding new features. Developers
already requiring v3.0. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ellipticaljs/paper-autocomplete/issues/121#issuecomment-390736264,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUumTsGZkryaSElEg3w0pHz-RGse8Zhks5t0wMpgaJpZM4T8cdc
.

@jhuesos https://github.com/stat92/paper-autocomplete/tree/3.0-preview

I'm also interested in a Polymer 3 version (npm package).
I agree with your idea to only handle the popup part, that provides more flexibility - you could add autocompletion to any arbitrary elemtent that way.

is this still in the works or stalled? Just asking as we migrate to Polymer 3 and rely on paper-autocomplete (which is fine as is). Eventually we'll do the migration ourselves.

Someone made a Polymer 3 version, it works okay for me:
https://www.webcomponents.org/element/@fluidnext-polymer/paper-autocomplete/


Maximum execution time of 30 seconds exceeded

Hi, @m1ome whenever i call $message->pack() in my code i always getting this error:
Fatal error:  Maximum execution time of 30 seconds exceeded in D:\Repository\iso8583-tester\vendor\miome\iso8583\src\Message.php on line 73

below is my code when i try to pack my ISO8583 message:
$app->post('/send', function($request, $response, $args) {
    $params = $request->getParams();
    $iso = new Protocol();
    $message = new Message($iso, ['lengthPrefix' => 0]);
    $message->setMTI($params['mti']);

    foreach($params['fields'] as $field => $value) {
        $message->setField($field, $value);
    }

    $message->pack();

    $data = ['success' => true, 'message' => 'Request Success'];
    return $response->withJson($data, 200);
});

Any idea?

i'm trying to figuring out the cause of the problem and it seem (from the error message above) this code is the cause of the problem (but still i don't know why):
https://github.com/m1ome/iso8583/blob/master/src/Message.php#L71-L75
if ($i % 64 == 0) {
      for($i=0; $i<64; $i+=4){
            $bitmap .= sprintf('%01x', base_convert(substr($tmpBitmap, $i, 4), 2, 10));
      }
}

every time my code reach that block it always freeze and then the error Maximum execution time of 30 seconds exceeded is shown.

@devsalman  have you got the solution ? because i getting the same issue.

have you got the solution ? because i getting the same issue.


How to enable Envoy proxy on istio-ingress gateway?

I am try to deploy kubeflow on kind. (with Ubuntu 20.04 on AWS EC2)
But the istio-ingressgateway is not working with Envoy proxy is NOT ready
Is there any way to solve this?

The log (istio-ingressgateway) is attached here.

kubectl logs  istio-ingressgateway-589ff776dd-tp6tk -n istio-system

log.txt

The instruction for deploying is here.

kubeflow_deploy.txt

Current pods status is here

NAMESPACE            NAME                                                           READY   STATUS             RESTARTS   AGE
cert-manager         cert-manager-5d849b9888-vhg65                                  1/1     Running            0          20m
cert-manager         cert-manager-cainjector-dccb4d7f-rj8mg                         1/1     Running            0          20m
cert-manager         cert-manager-webhook-695df7dbb-qsm5g                           1/1     Running            0          20m
istio-system         cluster-local-gateway-7bf56777fb-fd4rq                         0/1     Running            0          20m
istio-system         grafana-86f89dbd84-nrjvl                                       1/1     Running            0          20m
istio-system         istio-citadel-74966f47d6-tpvc8                                 1/1     Running            0          20m
istio-system         istio-cleanup-secrets-1.1.6-4vj4n                              0/1     Completed          0          20m
istio-system         istio-egressgateway-5c64d575bc-5zdfq                           0/1     Running            0          20m
istio-system         istio-galley-784b9f6d75-p97cc                                  1/1     Running            0          20m
istio-system         istio-grafana-post-install-1.1.6-k9bhp                         0/1     Completed          0          20m
istio-system         istio-ingressgateway-589ff776dd-tp6tk                          0/1     Running            0          20m
istio-system         istio-pilot-677df6b6d4-m2h2f                                   1/2     Running            0          20m
istio-system         istio-policy-6f74d9d95d-r9v6q                                  1/2     CrashLoopBackOff   11         20m
istio-system         istio-security-post-install-1.1.6-gsdm7                        0/1     Completed          0          20m
istio-system         istio-sidecar-injector-866f4b98c7-7nsrb                        1/1     Running            0          20m
istio-system         istio-telemetry-549c8f9dcb-cktf4                               1/2     CrashLoopBackOff   11         20m
istio-system         istio-tracing-555cf644d-mj8lq                                  1/1     Running            0          20m
istio-system         kfserving-ingressgateway-64c7bd9b76-7t8ql                      0/1     Running            0          20m
istio-system         kiali-7db44d6dfb-xj4wj                                         1/1     Running            0          20m
istio-system         prometheus-d44645598-dc78l                                     1/1     Running            0          20m
knative-serving      activator-6dc4884-vd58z                                        0/2     CrashLoopBackOff   7          17m
knative-serving      autoscaler-69bcc99c79-jcsrx                                    0/2     CrashLoopBackOff   6          17m
knative-serving      autoscaler-hpa-68cc87bfb9-98xm4                                1/1     Running            0          17m
knative-serving      controller-95dc7f8bd-2dbdr                                     1/1     Running            0          17m
knative-serving      networking-istio-5b8c5c6cff-dqk88                              1/1     Running            0          17m
knative-serving      webhook-67847fb4b5-zf64k                                       1/1     Running            0          17m
kube-system          coredns-5d4dd4b4db-hrwd4                                       0/1     CrashLoopBackOff   10         26m
kube-system          coredns-5d4dd4b4db-jhzkr                                       0/1     CrashLoopBackOff   9          26m
kube-system          etcd-kind-control-plane                                        1/1     Running            0          25m
kube-system          kindnet-mt88h                                                  1/1     Running            0          26m
kube-system          kube-apiserver-kind-control-plane                              1/1     Running            0          25m
kube-system          kube-controller-manager-kind-control-plane                     1/1     Running            0          25m
kube-system          kube-proxy-jcrfh                                               1/1     Running            0          26m
kube-system          kube-scheduler-kind-control-plane                              1/1     Running            0          25m
kubeflow             admission-webhook-bootstrap-stateful-set-0                     1/1     Running            0          17m
kubeflow             admission-webhook-deployment-569558c8b6-ssl7w                  1/1     Running            0          16m
kubeflow             application-controller-stateful-set-0                          1/1     Running            0          20m
kubeflow             argo-ui-7ffb9b6577-vf88h                                       1/1     Running            0          17m
kubeflow             centraldashboard-659bd78c-87lhx                                1/1     Running            0          17m
kubeflow             jupyter-web-app-deployment-679d5f5dc4-lwvc4                    1/1     Running            0          17m
kubeflow             katib-controller-7f58569f7d-wnrtb                              1/1     Running            1          17m
kubeflow             katib-db-manager-54b66f9f9d-lgg2f                              0/1     Running            6          17m
kubeflow             katib-mysql-dcf7dcbd5-dt4xg                                    1/1     Running            0          17m
kubeflow             katib-ui-6f97756598-mmfzx                                      1/1     Running            0          17m
kubeflow             kfserving-controller-manager-0                                 2/2     Running            1          17m
kubeflow             metacontroller-0                                               1/1     Running            0          17m
kubeflow             metadata-db-65fb5b695d-qv5ss                                   1/1     Running            0          17m
kubeflow             metadata-deployment-65ccddfd4c-xgkfv                           0/1     Running            0          17m
kubeflow             metadata-envoy-deployment-7754f56bff-gn6z4                     1/1     Running            0          17m
kubeflow             metadata-grpc-deployment-5c6db9749-88nj8                       0/1     CrashLoopBackOff   6          17m
kubeflow             metadata-ui-7c85545947-sqnt4                                   1/1     Running            0          17m
kubeflow             minio-6b67f98977-lmktn                                         1/1     Running            0          17m
kubeflow             ml-pipeline-6cf777c7bc-kmplt                                   1/1     Running            1          17m
kubeflow             ml-pipeline-ml-pipeline-visualizationserver-6d744dd449-lzb6n   1/1     Running            0          17m
kubeflow             ml-pipeline-persistenceagent-5c549847fd-kwwp5                  1/1     Running            4          17m
kubeflow             ml-pipeline-scheduledworkflow-674777d89c-x4n9v                 1/1     Running            0          17m
kubeflow             ml-pipeline-ui-549b5b6744-bvch9                                1/1     Running            0          17m
kubeflow             ml-pipeline-viewer-controller-deployment-fc7f7cb65-swfqk       1/1     Running            0          17m
kubeflow             mysql-85bc64f5c4-lxjg6                                         1/1     Running            0          17m
kubeflow             notebook-controller-deployment-5c55f5845b-b2d6j                1/1     Running            0          17m
kubeflow             profiles-deployment-c775584c7-qksqm                            2/2     Running            0          17m
kubeflow             pytorch-operator-cf8c5c497-mmlsf                               1/1     Running            0          17m
kubeflow             seldon-controller-manager-6b4b969447-8zw65                     1/1     Running            0          17m
kubeflow             spark-operatorsparkoperator-76dd5f5688-6xzhb                   1/1     Running            0          17m
kubeflow             spartakus-volunteer-5dc96f4447-mkzvl                           1/1     Running            0          17m
kubeflow             tensorboard-5f685f9d79-8jvss                                   1/1     Running            0          17m
kubeflow             tf-job-operator-5fb85c5fb7-665l7                               1/1     Running            0          17m
kubeflow             workflow-controller-689d6c8846-ltt4r                           1/1     Running            0          17m
local-path-storage   local-path-provisioner-d4947b89c-858f7                         1/1     Running            0          26m

If you are using AWS why not run on EKS?
It looks like the problem is with installing ISTIO on your system and not Kubeflow per se.
You might have better luck trying a well supported combination of K8s and ISTIO and ensuring that is deployed correctly.