Update .travis.yml

@KSlachta this will fix the problem with Bluemix not reporting the right status when the app starts

LGTM


Sample application

Hi,
Is there any sample project or tutorial showing how to setup a Spine backed application?
That would be really helpful to get a clearer picture of its features.
Thanks,
BQ.

There is currently no up to date sample project. I had an example but didn't have the time to keep updating it, so I removed it altogether. It's still on the todo list to create a new one though.
The quick start in the README should give you a pretty good overview of the basic features, but I agree that examples of how to connect this to a UI for example would be helpful.

I would second the need for an example project.  I would like to see one that utilizes a public datasource.

Using a public jsonapi would be nice indeed. If you know of a usable datasource, please let met know.


Is splunk-hec compatible with http_parser.rb(0.6.0) & tzinfo(2.0.1) gems?

Hi,
I'm building a docker image with td-agent-3.6.0 rpm and installing latest fluent-plugin-splunk-hec.
What happened:
I see this error while listing or installing any gems.
bash-4.2# td-agent-gem list
WARN: Unresolved specs during Gem::Specification.reset:
      http_parser.rb (< 0.7.0, >= 0.5.1)
      tzinfo (< 3.0, >= 1.0, >= 1.0.0)
WARN: Clearing out unresolved specs.
Please report a bug if this causes problems.

This is happening because multiple versions of the same gems are getting installed.
With td-agent rpm, these gems get installed:
http_parser.rb (0.6.0)
tzinfo (2.0.1)

But while installing fluent-plugin-splunk-hec, it installs its dependencies that are older versions of these gems - http_parser.rb-0.5.3.gem and tzinfo-1.2.6.gem.
Ques 1 : Why is splunk plugin using older gems as dependencies? Another example I see is its dependency on active-support-5.2 while the latest active-support version available is 6.x. Any specific reason to stay at older versions?
 td-agent-gem install --no-document --source http://rubygems fluent-plugin-splunk-hec
Fetching: http_parser.rb-0.5.3.gem (100%)
Building native extensions.  This could take a while...
Successfully installed http_parser.rb-0.5.3
Fetching: thread_safe-0.3.6.gem (100%)
Successfully installed thread_safe-0.3.6
Fetching: tzinfo-1.2.6.gem (100%)
Successfully installed tzinfo-1.2.6
Fetching: i18n-1.8.2.gem (100%)

HEADS UP! i18n 1.1 changed fallbacks to exclude default locale.
But that may break your application.

If you are upgrading your Rails application from an older version of Rails:

Please check your Rails app for 'config.i18n.fallbacks = true'.
If you're using I18n (>= 1.1.0) and Rails (< 5.2.2), this should be
'config.i18n.fallbacks = [I18n.default_locale]'.
If not, fallbacks will be broken in your app by I18n 1.1.x.

If you are starting a NEW Rails application, you can ignore this notice.

For more info see:
https://github.com/svenfuchs/i18n/releases/tag/v1.1.0

Successfully installed i18n-1.8.2
Fetching: activesupport-<IP_ADDRESS>.gem (100%)
Successfully installed activesupport-<IP_ADDRESS>
Fetching: aes_key_wrap-1.0.1.gem (100%)
Successfully installed aes_key_wrap-1.0.1
Fetching: bindata-2.4.6.gem (100%)
Successfully installed bindata-2.4.6
Fetching: json-jwt-1.11.0.gem (100%)
Successfully installed json-jwt-1.11.0
Fetching: attr_required-1.0.1.gem (100%)
Successfully installed attr_required-1.0.1
Fetching: rack-2.2.2.gem (100%)
Successfully installed rack-2.2.2
Fetching: rack-oauth2-1.10.1.gem (100%)
Successfully installed rack-oauth2-1.10.1
Fetching: webfinger-1.1.0.gem (100%)
Successfully installed webfinger-1.1.0
Fetching: swd-1.1.2.gem (100%)
Successfully installed swd-1.1.2
Fetching: activemodel-<IP_ADDRESS>.gem (100%)
Successfully installed activemodel-<IP_ADDRESS>
Fetching: mini_mime-1.0.2.gem (100%)
Successfully installed mini_mime-1.0.2
Fetching: mail-2.7.1.gem (100%)
Successfully installed mail-2.7.1
Fetching: validate_email-0.1.6.gem (100%)
Successfully installed validate_email-0.1.6
Fetching: validate_url-1.0.8.gem (100%)
Successfully installed validate_url-1.0.8
Fetching: openid_connect-1.1.8.gem (100%)
Successfully installed openid_connect-1.1.8
Fetching: connection_pool-2.2.2.gem (100%)
Successfully installed connection_pool-2.2.2
Fetching: net-http-persistent-3.1.0.gem (100%)
Successfully installed net-http-persistent-3.1.0
Fetching: fluent-plugin-splunk-hec-1.2.1.gem (100%)
Successfully installed fluent-plugin-splunk-hec-1.2.1

Ques 2:
Is fluent-plugin splunk-hec compatible with http_parser.rb (0.6.0) and tzinfo (2.0.1) (i.e. latest gems coming from td-agent-3.6.0)?
Can we remove the older gem versions of http_parser & tzinfo coming from splunk plugin?
Do you foresee any issues with this?
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):

Install td-agent-3.6.0 rpm
Install fluent-plugin-splunk-hec  gem (i.e. 1.2.1) using  td-agent-gem install --no-document --source http://rubygems fluent-plugin-splunk-hec
Check td-agent-gem list

Anything else we need to know?:
Environment:

Ruby version (use ruby --version): ruby 2.4.9p362
OS (e.g: cat /etc/os-release): CentOS Linux 7
Splunk version: fluent-plugin-splunk-hec (1.2.1)

This issue is causing my deployment to have an error
/usr/lib/ruby/2.5.0/rubygems/specification.rb:2325:in `raise_if_conflicts': Unable to activate fluent-plugin-splunk-hec-1.2.2, because http_parser.rb-0.6.0 conflicts with http_parser.rb (= 0.5.3) (Gem::ConflictError)

It looks like fluentd allows:
gem.add_runtime_dependency("http_parser.rb", [">= 0.5.1", "< 0.7.0"])

I'm running into the same issue where I cannot use the plugin due to the http_parser conflict.

I created PR to fix it. https://github.com/splunk/fluent-plugin-splunk-hec/pull/132
once it is merged, we will make another release with other security fix.
Thank you!

one more comment, above removes http_parser 0.5.6 requirements, but activesupport library we are using requres tzinfo ~>1.1. so we cannot use tzinfo 2.x

@rockb1017  Thx for the http_parser requirement fix. When will this fix (version fluent-plugin-splunk-hec v1.2.3.gem) be released?

@aggarwalShivani, @rabem00  fluent-plugin-splunk-hec v1.2.3.gem available on rubygems.org. Currently, the release version of fluent-plugin-splunk-hec is v1.2.9.

FYI, looks like this is related to #144


Move shutdownfns, terminatefns and hammerfns out of separate goroutines

Coalesce the shutdownfns etc into a list of functions that get run at shutdown
rather then have them run at goroutines blocked on selects.
This may help reduce the background select/poll load in certain
configurations.
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

Codecov Report

Merging #15686 (8d3464a) into master (8c8471e) will decrease coverage by 0.02%.
The diff coverage is 22.36%.

@@            Coverage Diff             @@
##           master   #15686      +/-   ##
==========================================
- Coverage   43.90%   43.88%   -0.03%
==========================================
  Files         678      678
  Lines       81868    81883      +15
==========================================
- Hits        35946    35934      -12
- Misses      40075    40096      +21
- Partials     5847     5853       +6

Impacted Files
Coverage Δ

modules/graceful/manager.go
25.56% <15.94%> (-3.47%)
:arrow_down:

modules/graceful/context.go
18.18% <66.66%> (-46.11%)
:arrow_down:

modules/graceful/manager_unix.go
36.63% <100.00%> (ø)

modules/charset/charset.go
71.71% <0.00%> (-4.05%)
:arrow_down:

modules/notification/mail/mail.go
41.83% <0.00%> (+3.06%)
:arrow_up:

modules/util/timer.go
85.71% <0.00%> (+42.85%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c8471e...8d3464a. Read the comment docs.

I'm gonna close this to move its changes in to #15693


Don't backup any files on android

@keybase/react-hackers

Is this kind of doing the same thing twice? Or are there two different kinds of backup to disable?

yeah same thing twice. We really only need one of these


matching brackets as bold instead of border

When highlighting matching brackets, Can we have some provision to make font-weight as bold.
Steps to create:
When user click near any of '<' ,'>','{','}','(',')'  and the matching element will be highlighted as  '<' ,'>','{','}','(',')'
Why ask? -> Because working with bordered brackets is sometimes difficult.

ok thanks


Throw exception when a conditional or iteration is started without end

If an [$if(x)] is added to HTML without a respective [$end if]
or a [$foreach x] without a [$end for]
throw a clear exception

Reworked in https://github.com/medusa-ui/medusa/commit/3aa18988dcfbf07de66ac3abf20f3d204de10f98

Reworked in https://github.com/medusa-ui/medusa/commit/3aa18988dcfbf07de66ac3abf20f3d204de10f98


Protection Keys

Would it be possible for external (or internal) keys for properly dumping DVD, HD-DVD, and BluRay discs? Unfortunately, some DVD's (especially) will crash immediately even with the /cmi flag.

I can confirm that DVDs with protection now dump properly, keeping the protection intact.

I mean.. Maybe instead of basing this over DeCss, libdvdcss was better?


[]byte vs io.Reader for message contents

Hey @Jeffail
First of all, this looks like an awesome project, thanks for building this!
I was wondering if Benthos should support io.Reader in the future for large message contents.
This could be useful for sources with large files (S3. files, etc.), where reading the whole content in at once is not desirable.
I realise this might be a rather large change and if it's not in the scope of the project to support this that is perfectly understandable.
Edit: This would probably only be useful for plugins(?)

Hey @markus-wa, this is definitely possible and probably not too much effort since things like structured parsing to/from JSON is already lazily evaluated, so we could expand that concept to include byte consumption being lazily read and offer the io.Reader interface as an advanced API.
However, this will need to wait for a major version bump as it'd definitely involve chopping and restructuring some of the fundamental component APIs. I'm currently in the loose planning phase for a new plugin API (just created a ticket for it) that would start the ball rolling on Benthos V4. Once that's done we can take a look at this and weigh in the pros/cons and think about how the APIs should look.

Cool, I'd be happy to help out (if I have the time for it). Feel free to give me a ping here whenever you think this is ready to be designed / worked on 🙂

Yes, it makes sense to have "io.Reader" exposed else, @Jeffail  is it possible to provide configuration options like reading line by line or number of bytes to be read at once, and base on that we can emit one or more messages. I feel this way we don't need to change API drastically, I am still understanding this library so my understanding might be incomplete. Please forgive me in case this is misunderstood.

We've been having a problem processing large, compressed batches of messages from S3. Benthos tries to read in and decompress the entire file before processing any of the messages.
I believe switching to io.Reader should enable Benthos to process these files incrementally, including both reading and decompressing.
This is a high priority for us.

Just realised that I forgot to update this issue, but as a short term measure I've added a new codec field to a few file-based inputs, which currently includes file as well as the new aws_s3 which will eventually replace s3. These codecs are currently quite limited (line-by-line, tar archives, and csv) but the interface is fairly straight forward to implement so I'm hoping I'll be able to keep on top of any requests for new codecs coming in.
The long term plan is to gradually expand codecs and eventually, once we're happy that their common interface is stable, I will allow you to add codec plugins the same way processor and other plugins are possible now, which would allow you to build custom definitions for how an io.Reader can be streamed into benthos messages.

nice one @Jeffail - thanks for the update


Implement "Add to Course Reserve List" function for Audio Edit, Listing, and Search Results page

@VivianChu
Testing on staging, I created a course reserve list, added audio objects and then got a confirmation email. However, the email is missing the Titles of the audio in the playlist.
Please add a link on Ares to the playlist for Professor Lee, Jason's GAM Test CR List course for Winter 2016. The titles in the playlist for this course are: The path to this DMR course reserve list is: http://librarytest.ucsd.edu/dmr/courses/53/Winter/2016/gam_test_cr_list  Thanks!

Note: Vivian has not yet worked on the playlist/email functionality so this is a non-issue at this time.


[Workflow] Update icons

Updates the icons used for workflow/workflow tasks

I debated that, but fell back to keeping the icons to their official fontawesome name:
https://fontawesome.com/icons/tasks?style=solid
https://fontawesome.com/icons/thumbtack?style=solid


variable assignment not same as expected

var1:= "var1"
var2:= var1/ "var2"

target1 var1= "t1":
  echo {{var2}}

target2 :
  echo {{var2}}

❯ j target1
echo var1/var2
var1/var2
❯ j target2
echo var1/var2
var1/var2
what i want is ,
just target1 output t1/var2

The var1 outer variable and the var1 argument are distinct variables, and the outer var1/"var2" uses the outer one.
I'm not sure it works for your use-case, but you can always try:
target1 var1= "t1":
  echo {{var1/"var2"}}

target2 :
  echo {{var1/"var2"}}

The var1 outer variable and the var1 argument are distinct variables, and the outer var1/"var2" uses the outer one.
I'm not sure it works for your use-case, but you can always try:
target1 var1= "t1":
  echo {{var1/"var2"}}

target2 :
  echo {{var1/"var2"}}

this works, but , i dont want write {{var1/"var2"}} again and again , it will be better define a variable for it


Feature request: configuration by server response

Hello and thank you for the wonderful software.
What I would like to see is the ability to adjust some settings by server responses, e.g.
{ "result": "ok",
  "command": {
     "sendInterval": 20
     }
}

This would allow to track approach to a point of interest wich cannot be triggered by "significant location change".
Related to #94

Closing as duplicate of #94

This is done now! Check out the readme for details:
https://github.com/aaronpk/Overland-iOS?tab=readme-ov-file#configuration-by-server-response


Doc for the Qt GUI

Rendered

I created links that redirect to the latest binaries, however I am not sure they work. Can you try the mac and windows links?


NASNetLarge Keras Model - accuracy is very very low

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):  No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: Issue happening on the Server while training
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): tensorflow-gpu==2.0.0
Python version: 3.6.9
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: CUDA 10.0 and cuDNN 7.6.5
GPU model and memory: 2 GPU Tesla K80 and total memory 22 GB

Describe the current behavior
Keras version 2.3.0
Tensorflow-gpu version 2.0.0
Dataset: Imagenet cars dataset
Preprocessing : Resizing images to 331 * 331 pixel using custom code and saving as new files, no other preprocessing
I tested the NASNetLarge Keras model with parameters as below
from keras.applications.nasnet import NASNetLarge
model=NASNetLarge(input_shape =  (331, 331, 3),include_top = False,  weights = 'imagenet')
model.trainable = False

and created combined model using Sequential
Training Data and valid data processed through flow_from_directory and fed fit_generator
Loss : approx 5.0
val_acc: approx 0.00813

@suresh-s,
In order to expedite the trouble-shooting process, could you please provide the complete code to reproduce the issue reported here and the dataset you are using.
Also, please update TensorFlow to the latest version v2.3 and check if you are facing the same issue. Thanks!


please update root-zone trust-anchors in dnssec_test.py file

Users of your software that enable DNSSEC will not be able to validate DNS after October the 11th 2018.
Your repository contains a dnssec_test.py file without the new DNSSEC trust-anchors:
resolver.add_ta(".   IN DS   19036 8 2 49AAC11D7B6F6446702E54A1607371607A1A41855200FD2CE1CDDE32F24E8FB5")
It should also include:
resolver.add_ta(".   IN DS   20326 8 2 E06D44B80B8F1D39A95C0B0D7C65D08458E880409BBC683457104237C7F8EC8D")
More information can be found at: https://www.icann.org/resources/pages/ksk-rollover
Please don’t hesitate to get in touch.
Warmly,
Roy Arends
ICANN

I originally planned to create some upstream patches for dns over tls, but never finished them. It was not intended to be used by end-users. I will archive this repository to make this more clear.


core: updating node-forge from vulnerability

Unit tests ✅
Integration tests ⌛

Coverage remained the same at 100.0% when pulling 99da7b6a3af5e61a6a94bc2fa677392d3ce983b6 on gaillota:core/node-forge-upgrade into 38a357ed0c153aad09c2857e48a710527e685bfc on node-apn:master.

Coverage remained the same at 100.0% when pulling 99da7b6a3af5e61a6a94bc2fa677392d3ce983b6 on gaillota:core/node-forge-upgrade into 38a357ed0c153aad09c2857e48a710527e685bfc on node-apn:master.

Anything preventing this from being merged? 🙏

If anyone wants to use this in the meantime I forked it and updated it: https://github.com/danthegoodman1/node-apn


Errors using the syscall package when importing github.com/kidoman/embd/host/rpi

There's a bunch of errors when I import github.com/kidoman/embd/host/rpi saying:
undefined: syscall... I think this is to do with the note mentioned in the overview of: https://golang.org/pkg/syscall/

NOTE: This package is locked down. Code outside the standard Go repository should be migrated to use the corresponding package in the golang.org/x/sys repository. That is also where updates required by new systems or versions should be applied. See https://golang.org/s/go1.4-syscall for more information.

I'm developing on Windows 10 and using go version go1.5.3 windows/amd64

Hi,
Did it start working?
 I was developing in atom using the go-plus package which builds files on save. I didn't have GOOS=linux set so when it got to building files with the syscall package imported, it couldn't find the linux variables (because I'm on windows).
Moral of the story: If you want to use anything that uses the syscall package on anything other than linux, set GOOS=linux.


[4.0.0-beta.16] [iOS] Swipe Back (go back): how to disable?

I realize this feature was newly added to beta.16 - however it may not be wanted all the time.
How can I disable this behavior?
Both in the template (categorically) for eg the home page of an app (to avoid swiping back to the login page, which is what happens now!)
But also programmatically?
Thanks,
Oliver
EDIT:
I did skim across the last commits and searched the source...couldn't find anything..

@olivermuc If you use ionic/angular then set [swipeGesture]="false" for ion-router-outlet.

@mmlleevvyy is right! you should use the swipeGesture input of ion-router-outlet!

Works like a charm, thx @mmlleevvyy


Beta update/Library rewrite

This PR isn't going to merge cleanly as I've rewritten large parts of the library. This PR is intended to be used for discussion on how to improve the code.
As I already said, this is a very large rewrite of the entire library and it depends on the latest flutter beta (1.4.9-hotfix.1). Not everything has been reimplemented yet, but flutter apps do work fine. Some parts are still being worked on.

I've merged the latest changes from master into this branch and fixed some more issues. The app demo is not yet complete, but otherwise this should work now :)

Good job. Let's merge into master once, 1.4.9-hotfix.1 is on stable channel.

Is this patch ready to merge into beta?

I've been using this branch for quite a while now and I do feel that this is ready for beta.
The problem is that this branch absolutely requires using flutter beta. Due to changed ffi interfaces this branch will segfault if used with flutter stable.


Alignment of members

Describe the bug
The Members arent displayed
To Reproduce
Steps to reproduce the behavior:

Go to 'https://faceaseb.com/ACMW_Members'
Scroll down to 'The team'
See error

Expected behavior
Should be Inside well aligned boxes

The issue has been resolved. New code doesn't have any bugs.

The issue has been resolved. New code doesn't have any bugs.

@PriyaaIyer

Alignment is irregular

Few images are missing

resolved.

@Shreya1304 your photo is missing

Also @Shreya1304 , this photo is not straight:

And this irregular:


bug: navigateBack and navigateForward doesn't work

Check the following:

[X] I have checked the behavior after setting "vscode-neovim.neovimClean" in VSCode settings.
[X] I have read the vscode-neovim docs.
[X] I have searched existing issues.

Neovim version (nvim -v)
0.10.0
Operating system/version
Windows 11
Describe the bug
navigateBack and navigateForward / Ctrl-o and Ctrl-i not work in some files, I play with .js and .ts, jump to specific line and then Ctrl-o nothing happen except if I open another file it will bring back to the file. Play with .py and .json it work as expected.
I've disabled this extension, just normal vscode navigateBack and navigateForward work as expected.
Steps To Reproduce

Open VSCode with the Neovim extension.
Open .js or .ts file
Go to specific line
navigateBack and navigateForward

Expected Behavior
when jump to specific line and then Ctrl-o it will bring back to previous line.

I've tested this with .ts files and nvim 0.9.5 and can't reproduce it.

Now it's work as expected, thanks @ollien


fix(jsexecutor): fix jexecutorSelector to nodeSelector

background
・The js-excuter node selector is supported, but it is incorrect and the js-excuter Pod cannot be placed on a specific node.
・If a Pod cannot be placed on a specific node, it may affect the resources of that node if it is placed on another node, so I would like to fix this.
Fixes
Change the description of "jexecutorSelector" in js-excuter to "nodeSelector"

@dmitry-midokura
Could you please review this?


BAI-133 Investigate why additional fields are not being deleted from boolean questions

Subject of the issue
When you select "yes" on a boolean question in the upload/deployment forms, if there's a dependency it will sometimes append an additional question (usually a text field prompting users to explain why they selected "yes") object. If you then change your answer to "no", the formData will keep the additional text object, meaning it causes validation issues. These have been band-aid fixed for now so that the validator ignores dependency errors, but we need to find out if we can remove the additional question objects completely from the form data if the user selects "no".
Steps to reproduce

Select "Yes" on any boolean question that has a dependency
Enter a value in the dependency question field that appears (usually a text field)
Change "Yes" to "No"in the parent question field

Expected behaviour
The dependency question should disappear from the form and the object removed from the form data
Actual behaviour
The dependency question disappears from the form, but the answer entered still exists in the form's data.

Fixed by #60


improve readability of test criteria validation

Currently test validation output just shows evaluated expressions like this:
        $0003 = #$3089 --> PASS
	$0005 = #$FF38 --> PASS
	$0007 = #$9F40 --> PASS
	$0040 = #$FFFF --> PASS
	$0009 = #$3089 --> PASS
	$000B = #$00C8 --> PASS
	$000D = #$9F42 --> PASS
	$0042 = #$00C7 --> PASS
	$0013 = #$AFE9 --> PASS
	$002D = #$9F54 --> FAIL $002D (4E3F) != #$9F54 (9F54)

It's difficult to figure out which criterion actually failed (in this case it was ;! x7+4 = #$9F54)
The output should show the original text of the criterion and maybe the line number.

Improved format of test validation output:
	x3+2 = #$7F          ($0019 = #$7F)   --> PASS
	x4 = #$3089          ($001A = #$3089) --> PASS
	x4+2 = #$0080        ($001C = #$0080) --> PASS
	x5 = #$3080          ($001E = #$3080) --> FAIL $001E (3089) != #$3080 (3080)
	x5+2 = #$80          ($0020 = #$80)   --> FAIL $0020 (FF) != #$80 (80)
	x6 = #$3089          ($0022 = #$3089) --> PASS
	x6+2 = #$FF7F        ($0024 = #$FF7F) --> PASS

And a "result line" (test criterion) no longer has to start with ";" in the first column of the line so you can make your criteria easier to read in your code:
    stx     tbl+14  ; should be 9F 4E and tbl+14 should contain $FFFF
                    ;! x7+3 = #$9F4E
                    ;! tbl+14 = #$FFFF

see above


Benchmark test should be avoided

When selecting -all in gotests, Benchmark functions should be avoided for test generation purposes.

@zerjioang: This does sound like a bug. Can you please provide an example code file where this happens?

When I execute the gotests with -all flag, the functions with following header definition:
func BenchmarkGetState(b *testing.B){}
are also treated as test candidate generating following code snippet:
func TestBenchmarkGetState(t *testing.T) {
	type args struct {
		b *testing.B
	}
	tests := []struct {
		name string
		args args
	}{
		// TODO: Add test cases.
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			BenchmarkGetState(tt.args.b)
		})
	}
}

I wont consider this as a bug, but could be a great improvement for those project that have Test functions and Benchmarks.
The way I found to fix this is using the regular expression option an running it via:
${GOPATH}/bin/gotests -excl Benchmark.* -w ${file}


python3Packages.openhomedevice: 2.0.1 -> 2.0.2

Description of changes
https://github.com/bazwilliams/openhomedevice/releases/tag/2.0.2

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 168592 run on x86_64-linux 1

2 packages built:

python310Packages.openhomedevice
python39Packages.openhomedevice


Remove unused internal packages and run all internal tests

Also includes https://github.com/pachyderm/pachyderm/pull/6454
Looking at all the tests in the internal subpackages, we only seemed to be running tests for 13 out of 22. This reworks how we bucket tests to run all the internal subtests in a single bucket, which has a comparable runtime (14m) to the PPS buckets. The internal bucket replaces the object bucket, and runs some tests that were formerly covered by MISC and PFS/
The bloom package was failing because it depended on the size of the hash used in pachhash, but on further inspection it wasn't used anywhere in the codebase. discovery and localcache have also been removed because they're ununsed.
Long-term we should work on bucketing the entire set of tests for the codebase - our current bucketing code only works for a single package.
Affected packages and the number of missed tests:
  # We were running tests for these
   1 "github.com/pachyderm/pachyderm/v2/src/internal/migrations"
   1 "github.com/pachyderm/pachyderm/v2/src/internal/storage/track"
   2 "github.com/pachyderm/pachyderm/v2/src/internal/storage/fileset/index"
   2 "github.com/pachyderm/pachyderm/v2/src/internal/obj"
   3 "github.com/pachyderm/pachyderm/v2/src/internal/storage/chunk"
   3 "github.com/pachyderm/pachyderm/v2/src/internal/cert"
   3 "github.com/pachyderm/pachyderm/v2/src/internal/deploy/cmds"
   3 "github.com/pachyderm/pachyderm/v2/src/internal/grpcutil"
   5 "github.com/pachyderm/pachyderm/v2/src/internal/obj/integrationtests"
   6 "github.com/pachyderm/pachyderm/v2/src/internal/storage/fileset"
   7 "github.com/pachyderm/pachyderm/v2/src/internal/work"
   11 "github.com/pachyderm/pachyderm/v2/src/internal/collection"

   # We weren't running tests for these, but they're still in use
   1 "github.com/pachyderm/pachyderm/v2/src/internal/uuid"
   2 "github.com/pachyderm/pachyderm/v2/src/internal/ancestry"
   2 "github.com/pachyderm/pachyderm/v2/src/internal/pacherr"
   4 "github.com/pachyderm/pachyderm/v2/src/internal/deploy/assets"
   4 "github.com/pachyderm/pachyderm/v2/src/internal/errors/testing"
   6 "github.com/pachyderm/pachyderm/v2/src/internal/serde"
  15 "github.com/pachyderm/pachyderm/v2/src/internal/backoff"

  # Removed because they're unused
   2 "github.com/pachyderm/pachyderm/v2/src/internal/discovery"
   4 "github.com/pachyderm/pachyderm/v2/src/internal/localcache"
   6 "github.com/pachyderm/pachyderm/v2/src/internal/bloom"

Good cleanup. I wonder if we can maybe print somewhere what tests have been selected (go list -json ./src/example/... | jq .TestGoFiles before running go test ./src/example/...) and then see which _test files in the repo don't show up there? Out of scope for this PR, but it would be good to have some way of avoiding this problem.

I think the dream is being able to partition the tests in ./... such that we run a single go test ./... in each bucket and it runs a subset of all the tests for the codebase, such that all the buckets have roughly equal runtime and cover the entire codebase. The only solution I've seen has been to add a hook into every individual test that condiitonally skips, which feels very onerous.


Open glow when not in path

I would like to have :Glow work even when glow is not in my path but it exists in g:glow_binary_path. Currently it opens the terminal up and says command not found. I believe it could be fixed by changing https://github.com/ellisonleao/glow.nvim/blob/ae61bac7a4ec720b247d016473d6214d0e8aa0cc/lua/glow.lua#L197 line to vim.fn.termopen(string.format("%s/glow %s", bin_path, vim.fn.shellescape(path)))

good catch! will fix it ASAP

@ellisonleao I have added a PR for the above issue.


Create DLL for .NET 4.5

See Punit Ganshani's article on 5 steps to targeting multiple .NET frameworks and Microsoft's Framework Design Guidelines.

Relevant StackOverflow Posts

What is the effect of setting a “Target framework” in Visual Studio
What does it really mean to target a framework, and how do I maximize compatibility?

What's The Real Issue?
In 3.x versions of Grapevine, I restricted access to elements of HttpListenerContext, HttpListenerRequest and HttpListenerResponse. While no one really complained, I felt like this hindered adoption. So, in 4.x I completely opened this up (for multiple reasons), but did so by creating an interface that completely mirrored the .NET 4.0 versions of the aforementioned classes. This worked great in many respects, until I realized that the API for these classes changes between .NET 4.0 and 4.5.
Now I've created a bigger problem, as 4.x versions of Grapevine are plagued with compatibility issues on other platforms and versions of the .NET framework.
What's The Best Solution?
I was admittedly rather hasty in getting 4.0 out of alpha. As a result, some of the API - including the parts of the API that are causing compatibility issues here - is not what I would like it to be. Altering the API means updating the major version to 5.0, and if I'm going to do that, I've also been wanting to rebrand Grapevine under a different project name...


Are you will support to angular?

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

We currently only support React for this plugin. However, it should be easy to use this plugin as a reference and create an exact replica which supports Angular as well.
We could guide you in creating a new plugin that renders a minimap in Angular. Would you be willing to create a plugin for this purpose?

What would be a good approach if someone were to create a new version of this plugin for angular? To have a different version of the plugin for each framework (react, angular, vue, etc.) or to convert it to vanilla js only?


Change images repo and version

(+) Change Prometheus related images from quay.io repo to docker.io
(+) Change prometheus-auth from maiwj lib to rancher lib, referred: https://github.com/rancher/prometheus-auth/pull/1
(+) Change maiwj/curl to rancher/prometheus-auth in root values.yaml

LGTM


How does one actually query db data in KS5?

 In KS4 there was keystone.list("foo").model.find (mongoose queries). I can't figure out what functions actually accepts the new GraphQL strings 😬 The TODO demo in this repo doesn't enlighten me either... and the GraphQL API page in the docs is blank... Do you use keystone.executeQuery?
I can't figure out the whole business with Apollo either. Is that only necessary with the Next integration, but not static?

This is a great question! One we need to do a better job of answering in the docs.

keystone.executeQuery is what you'll use 99% of the time - it accepts a GraphQL query string and does all the heavy lifting for you in terms of optimising queries for the particular database adapter in use and resolving relationships, etc. I highly recommend trying this method first. Except when;
You can use the query action which is passed to hooks in the last argument. This is the same as keystone.executeQuery except it executes the query as the currently authenticated user (if your provide the skipAccessControl: true option to the second argument of query, it will behave identically to keystone.executeQuery.
To get access directly to the adapter and construct your own queries, there's no "official" API (really you should be using keystone.executeQuery wherever possible), but the escape hatch for now is the keystone.adapters object which you can play around with to do raw mongoose or SQL queries.

Apollo comes in two halves;

A GraphQL server implementation. We use this to power the app-graphql server. The fact that it's Apollo should be treated as an implementation detail.
A client library for making complex cached requests to any GraphQL API. While we use this in the Admin UI, it is 100% not necessary. In fact, the simplest was to query a GraphQL API is by sending a string in the body of a fetch(). The next simplest way is using the graphql-request npm library which has no caching or any other smarts. Then you get up into the kind-of smart query builders such as urql and draqula, and finally into the really complex caching mechanisms as used by apollo & relay.

Ah, thanks! (Sorry about the title - middle of the night frustration >_<).
So basically, you can either use executeQuery (I'm presuming you can require your index.js to get the running keystone instance) or fetch() for almost all common cases.
That does lead to a second question, though. Am I correct that the old "handle route, create a new keystone.View object, call view.render("foo")" workflow is no more? That is, all the stuff (like db querying) can now just be handled however you choose in your actual page code (using React, appendChild, etc)?

Sorry about the title - middle of the night frustration

I can 100% relate! That's why it's a good question, not a dumb question; if you can't figure it out then we have more work to do on the docs 👍

So basically, you can either use executeQuery (I'm presuming you can require your index.js to get the running keystone instance) or fetch() for almost all common cases.

Yes, this is correct - the keystone instance can be passed around / required where needed and it'll have everything ready to run executeQuery. For all your client-side or not-on-the-same-server needs, you can use a fetch (or other client-side GraphQL libraries).

Am I correct that the old "handle route, create a new keystone.View object, call view.render("foo")" workflow is no more?

Yeah, we've removed the opinionated view layer from Keystone v5. We wanted to open the door to more client side libraries and frameworks (such as Next, Nuxt, Ember, Angular, etc). It also allowed us to rethink some architectural things inside Keystone which means we can focus more effort on providing a solid API layer.
It does, however, mean that you no longer get a view layer for free. We've tried to make it a bit easier by providing different "Keystone apps" which have a simple interface ready to hook into the Express pipeline (for example, see the @keystone-alpha/app-next package).

IIUC, you still need a custom server setup (your server.js file) for additional custom route handling beyond what the apps offers (such as for an SPA), right? And I'm guessing if you have a custom server, you won't need to use the apps either?

@Vultraz, yes a custom server could replace apps but you can also use a custom server with apps. I'd suggest using apps might be a better first approach before replacing the default server.
I'd save using a custom server until you really need it. Ie; When you need to do something you can't with apps. See some of the examples here: https://v5.keystonejs.com/guides/custom-server

BTW is you are after a SPA - the StaticApp is probably what you want.  https://v5.keystonejs.com/keystone-alpha/app-static/ Set the fallback route to your SPA index file and all routes will be redirected there.


Review hover state of buttons and links

Hover states and ripples and transitions to review:

[ ] Every use of Button in our JSX
[ ] Every use of IconButton in our JSX
[ ] Every use of :hover in our CSS/JSS
[ ] Every use of transition in our CSS/JSS
[ ] ...

@nagas018-ken & @FarzanaPrianka can you please collaborate and establish hover states and links for updated button components.

Could not start working on it yet. Hope to start from tomorrow.

ETA: Monday, 19 July 2021
Blockers: None

Hi team, @FarzanaPrianka has updated our button system to meet accessibility standard and matches the styling of Material UI.
Presented would be the recommended styling to move towards. Can revisit after MVP.

@FarzanaPrianka @chalimar can you confirm this is now an issue to be reviewed by the dev team?


which model is best of text generation?

Feature request
I am able to run the text generation model locally via docker but the model (bigscience/bloom-560m) seems to be small size for local test and does not generate good quality response for the prompt. Which model is best for the text generation. I have noticed there are lots of models like "bigscience/bloom-7b1" which seems for translation.
can anyone let me know which is the best model for text generation.
Motivation
To test the text generation for different prompts
Your contribution
n/a

Currently the new leader is https://huggingface.co/tiiuae/falcon-40b
However, it seems like a couple of us are having issues running it at the moment.

You can have a look at the Huggingface LLM Leaderboard to see which model is the best for each task.


feat(config): add vault provider

resolve https://github.com/fermyon/spin/issues/661

Hello maintainers, I would like to add a new vault config provider, but I'm not sure where is the best place to put it to the Engine. Do you have any suggestion? Thank you!

@FrankYang0529 Thanks for this - great to see a secrets-friendly provider!
Re your question, config providers are currently wired up in the TriggerExecutorBuilder: https://github.com/fermyon/spin/blob/13f7916523f1fd4ab4b6c46d098c28e50baf2843/crates/trigger/src/lib.rs#L104
I believe you'd need to provide a way for an operator to add non-default config providers and specify their settings, e.g. a command line option.
It might be worth briefly writing up a proposal, either here or on the original issue, before diving into the code for that.  The reason I suggest that is that we're likely to have other non-default config providers in future, and it's worth planning the Vault UI with one eye on scaling it to those as yet unknown providers.  (For example, I'd be wary of a Vault-specific command line option a la --vault-config-source.)

We have discussed in the past having some sort of "environment" or "profile" configuration outside of the application manifest for this sort of thing. This would also be useful for splitting "dev" vs "prod" config a la https://github.com/fermyon/spin/issues/389.

Hi @itowlson and @lann, thanks for your suggestion! I will do some surveys and give a proposal first. 👍

For issue https://github.com/fermyon/spin/issues/389 and https://github.com/fermyon/spin/issues/661, my proposal is as following:

Add a --config argument to TriggerExecutorCommand, so users can use it to load different settings in different environments like dev / prod.
The config file format will be like

[spin.config.provider.vault]
vault_addr = "http://<IP_ADDRESS>:8200"
vault_token = "root"

[wasm.config]
wasm_backtrace_details = true

Update update_wasmtime_config function for other configurations in wasmtime.
Update build function to handle other spin_config providers.

Hi @itowlson, I updated the PR and added --config-file to load vault configuration in TriggerExecutorCommand. May you help me take a look? If it looks good, I will add a new e2e test case tomorrow. Thank you.
For wasmtime config like wasm_backtrace_details in #389, I will add in a follow-up PR.
Test step

Start vault

$ vault server -dev -dev-root-token-id root

Set a password

$ export VAULT_TOKEN=root
$ export VAULT_ADDR=http://<IP_ADDRESS>:8200
$ vault kv put secret/password value="test_password"
$ vault kv get secret/password

Start config-test app

$ cargo build
$ cd tests/http/config-test
$ ../../../target/debug/spin build
$ ../../../target/debug/spin up --config-file builder_config.toml

Test the app

$ curl -i http://<IP_ADDRESS>:3000
HTTP/1.1 200 OK
content-length: 26
date: Tue, 18 Oct 2022 12:34:40 GMT

Got password test_password

Looking pretty good to me. I'd like some others to review as well since --config-file is likely to be reused for some other things. We're pretty busy for the next couple of weeks with KubeCon so apologies if this takes a bit longer yet.

Hmm, not sure why we have following error in CI. I can run make test and make test-e2e on my laptop.
LINK : fatal error LNK1201: error writing to program database 'D:\a\spin\spin\target\debug\deps\spin.pdb'; check for insufficient disk space, invalid path, or insufficient privilege

@vdice if you get the chance could you check this out?

I moved config test from e2e-tests feature to config-provider-tests, so we don't need to install Vault in CI. Probably, let's see how to create a larger runner in the feature. Thanks.

@lann @FrankYang0529 would it help to split out some/all of the tests into separate workflow(s) from the main build, so they run on a separate runner?  Or would we continue to run into space issues with the default drive size?
Either way, we'd want to track upgrading to larger runners in a separate issue, as it brings billing/cost implications:

Note: The larger runners do not use included entitlement minutes, and are not free for public repositories.

@lann @FrankYang0529 would it help to split out some/all of the tests into separate workflow(s) from the main build, so they run on a separate runner? Or would we continue to run into space issues with the default drive size?

Yeah, I think we still have space issues, because we still need to install dependencies like bindle, hippo, nomad, etc.

Either way, we'd want to track upgrading to larger runners in a separate issue, as it brings billing/cost implications:

If we want to use larger runners, it's good to separate all tests, because it is calculated by minutes. We can try to minimize the cost.

This all looks great! My only suggestion is to replace references to "config-" as "runtime-config-" (i.e flags and toml sections) to more precisely reflect the "usage semantics" of these configuration values (i.e. runtime). However, if people like it as is, consider this comment an ignoreable -nit.

Do we want to add an example app that demonstrates use of the vault config provider as well -- for better visibility/awareness of the functionality?
Would be great to get some docs around this feature as well, perhaps with the aforementioned example; something along the lines of https://github.com/fermyon/spin/pull/798#issuecomment-1282316548 (or whatever the latest flow might be).  However, since we're now housing Spin documentation in fermyon/developer, this will have to be a follow-up.

This all looks great! My only suggestion is to replace references to "config-" as "runtime-config-" (i.e flags and toml sections) to more precisely reflect the "usage semantics" of these configuration values (i.e. runtime). However, if people like it as is, consider this comment an ignoreable nit.

Yeah, rumtime-config-file sounds better to me. Updated it. Thank you.

Do we want to add an example app that demonstrates use of the vault config provider as well -- for better visibility/awareness of the functionality?

Create a draft PR in https://github.com/fermyon/developer/pull/191. Thanks!

Thanks!

This is looking GREAT, thank you so much for your contribution!


Roadmap

[ ] Release version 1.0 (#4)
[ ] Improve structure

[ ] Replace Paperclip (#6)

[ ] Improve plugins

[ ] Taxon processor (for products)
[ ] Options processor (for products)

[ ] Admin UI (#3)

[x] Import listing
[x] Import details with import rows
[x] Import row details
[x] Pagination and filters to improve search functionalities
[x] Basic specs (at least load every new route)

[ ] Improve background processing

[ ] Attachment processor: transfer the files in separate jobs
[ ] Process rows in the background to improve concurrency
[ ] Group the rows by common changes (ex. for products by product slug)

[ ] Miscellaneous

[ ] Be independent from CSV (ex. JSON source)
[ ] Tests with Magento
[ ] Tests with other solutions

All the points in this Roadmap have been transferred to issues, appropriately assigned to milestones, and added to the progress board. All of this to match the need for better collaboration tools within a bigger team.


Adapt ui to branding guidelines

Solves #173

Current coverage is 86.86% (diff: 100%)

Merging #174 into develop will increase coverage by 0.34%

@@            develop       #174   diff @@
==========================================
  Files           123        123
  Lines          2204       2231    +27
  Methods          62         62
  Messages          0          0
  Branches        164        165     +1
==========================================
+ Hits           1907       1938    +31
+ Misses          230        227     -3
+ Partials         67         66     -1

Powered by Codecov. Last update de1e1f7...6e9bc04


airsonic: fix virtualHost option

The webplayer was not working with the services.airsonic.virtualHost
option because of missing proxy headers. This sets these headers up as
described in the airsonic documentation.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@aanderse Sorry, took a while until I found some time to try this. Unfortunately setting recommendedProxySettings breaks when there are other virtual hosts configured on the same machine and renders airsonic completely inaccessible.

No problem. This looks fine to me then. We should find someone familiar with nginx to approve this and then we can merge :+1:

@aanderse Sorry, took a while until I found some time to try this. Unfortunately setting recommendedProxySettings breaks when there are other virtual hosts configured on the same machine and renders airsonic completely inaccessible.

It seems all right to use their settings, though I wonder what's going on here: what if other services are affected as well?
A diff between ours recommendedProxySettings and airsonic recommendation shows that:

we set an extra proxy_set_header Accept-Encoding "", probably unrelated
they set proxy_max_temp_file_size 0, probably unrelated
we set an extra proxy_set_header X-Forwarded-Server $host, not sure but probably harmless
finally, we disagree on the value of X-Forwarded-Host: we use $host while they use $http_host.

The nginx docs says the following about $host

in this order of precedence: host name from the request line, or host name from the “Host” request header field, or the server name matching a request

On the other hand $http_host:

The value of the HTTP request header HOST when converted to lowercase and with 'dashes' converted to 'underscores'

The two could be different and thus break the connection if

The server is not on port 80 or 443, or
The virtual host has several names

ping @flyfloh

I couldn't reproduce the breakage when using recommendedProxySettings when trying to investigate this further just now. Since everything works with that setting now I have updated this PR to use it.

So, can we go forward with this? Should it be backported?

Everything still works from my side. Is there anything I need to do before this can be merged?

Since @Ma27 approved of this and you can't reproduce the issue with recommendedProxySettings I think it's good to go.

Backported to 20.03 in e393449b434.


feat: Generative Replace (#68)

Description

Added Generative Replace. Can be utilized in one of two ways:
{
  replace: {
    from: "apple",
    to: "orange",
  }
}

or
{
  replace: [ "apple", "orange" ]
}

Both options provide the preserve-geometry boolean parameter via the preserveGeometry property or as third option in the array.
This also includes 5 new tests for the plugin (and various ways of using it.)
Issue Ticket Number
Fixes #68
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Fix or improve the documentation
[ ] This change requires a documentation update

Checklist

[x] I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
[x] I have created an issue ticket for this PR
[x] I have checked to ensure there aren't other open Pull Requests for the same update/change?
[x] I have performed a self-review of my own code
[x] I have run tests locally to ensure they all pass
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes needed to the documentation

this looks spot on @michaeljolley! thanks for putting this together, i'm excited to get it into the downstream projects

@all-contributors please add @michaeljolley for code

@michaeljolley congrats on the merged PR! since it's officially October, you've always qualified for Hacktoberfest swag! please email<EMAIL_ADDRESS>with your github username and a link to your contribution where I'll follow up to request more information for getting you your swag
https://cloudinary.com/blog/hacktoberfest-celebrate-open-source-sdks

https://github.com/colbyfayock/cloudinary-util/pull/80#issuecomment-1787939670
hey @michaeljolley, haven't seen you reach out about the Hacktoberfest swag. please do as the cutoff to claim swag will be end of day this Friday 11/17. thanks

Oh dude! I didn't read the comment. I was wondering if you/Cloudinary would reach out. On it now. Thanks @colbyfayock!


Clean ABIs precommit

Currently, files in the build/contracts folder have a bunch of extra stuff (including the full byte code and parse tree of the contract). This adds a git hook that runs pre-commit that will check if there are any staged files from build/contracts, and if so, it will filter out everything except for "contractName, abi, networks, schemaVersion, and updatedAt". This reduces each build file's size by about 98%. WOOT!
update: this no longer modifies the originals at build/contracts, but instead puts the cleaned versions into build/abis

@ajm13 what is going on with this PR?


date picker doesn't open in the browser

I have this in my ionic template:
<ionic-datepicker input-obj="datepickerObject" class="itemParameters dateButtonContainer">
   <button class="dateButton button button-block button-light icon icon-left ion-ios-calendar-outline buttonWithBlueIcon"> {{datepickerObject.inputDate | date:datepickerObject.dateFormat}}
   </button>
</ionic-datepicker>

but when I run my app in the browser (chrome) using ionic serve and click on the datepicker button, it doesn't open the datepicker.
version in www/lib/ionic-datepicker/bower.json::
 "name": "ionic-datepicker",
  "version": "1.2.1",
  "authors": [
    "rajeshwarpatlolla<EMAIL_ADDRESS>  ],
...

That's an old version. Please use the latest version as mentioned in the documentation.


[App] Make it possible to run Memento without an Openai API key

If an user does not need the LLM stuff

Closed by #64


Cleanup builder pattern

Now that we have building of the gsplot object for each additional call, we can split out the functions that gathered all this for the render call and move to a more single responsibility pattern where functions only are concerned with sections of the gsplot object.  For example an axis() config might have a gather.side() called on it to get the xlim and ylim from the axis call and then this can be combined with the existing config for that side.
This will remove or greatly simplify the calc_views and group_views functions.

@jiwalker-usgs is this still relevant? calc_views doesn't exist anymore

Yeah, I think this can be closed with #320 and subsequent work


Callable for Swift

It would be nice to provide a Callable that can proxy directly to a Swift method, like the native C# binding does.
This is not currently possible with the Godot extension API, as this requires access to the CustomCallable
version of Callable which is just not exposed there.

This is now available in Godot 4.2

Work in progress: 398f0eefd25ac707bbe9367cf087ac220fe05f4c
The above should work, the next step would be to make a macro to allow for nice strongly typed values, rather than just forcing folks to accept a Variant array and returning an optional variant.


How can I restarted thread again?

I try to use labml in my project. I run my code, it produced error. Try to fix it and run again but in the second time run it produced the following error:

RuntimeError                              Traceback (most recent call last)

[<ipython-input-42-c44305bd3335>](https://localhost:8080/#) in <module>()
    428 #
    429 if __name__ == '__main__':
--> 430     main()

10 frames

[/usr/lib/python3.7/threading.py](https://localhost:8080/#) in start(self)
    846
    847         if self._started.is_set():
--> 848             raise RuntimeError("threads can only be started once")
    849         with _active_limbo_lock:
    850             _limbo[self] = self

RuntimeError: threads can only be started once

I think the previous thread stills running!
How can I reset/kill/restart the thread to run again from starting point?

You are running it from a notebook right? If you restart the kernel it'll stop the thread.
We will see if we can solve this problem when running on notebooks.


Fix docs crud examples error

Fix

[ ] Add a unit test to verify that the fix works.
[x] Explain briefly why the bug exists and how to fix it.

[ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes https://github.com/apache/skywalking/issues/.
[x] Update the CHANGES log.

Codecov Report

Merging #271 (f5ff329) into main (e6d8953) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #271   +/-   ##
=======================================
  Coverage   46.51%   46.51%
=======================================
  Files          89       89
  Lines        9315     9315
=======================================
  Hits         4333     4333
  Misses       4577     4577
  Partials      405      405

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


twister: Use flash options also for serial_pty

Use flash options also for serial pty option and code cleanup.

@finikorg, thank you, I missed to adjust this. Please mention in your commit message that both options are now applicable for device_serial_pty.

ammended commit message


feat: added customClientLocalePath property

I'm currently working on a project where we're using next & next-i18next within a nx monorepo. and in this case we needed a custom path property to load the translation files in the client.

Hey @hochitom – not sure I understand the purpose of this PR. You can just modify the localePath config option itself to achieve this behaviour, that's what it's there for.

yeah I know, my description was maybe a bit unclear. when working with nx monorepos, the destination of the locales is for example under apps/somename/public/static/translations/en/common.json which I need to configure with localePath. When doing this the client tries to load the files also from apps/somename/public/static/translations/en/common.json which in this case need to be just /static/translations/en/common.json. that's why we added this additional parameter to get nx + next + next-i18next working.

Still not sure I understand. It sounds like you just need to do:
localePath = typeof window === 'undefined' ? serverPath : clientPath

Is that the behaviour you are hoping for?

you are totally right -> the new parameter is not necessary.


Just asking about goodbyedpi

I live in iran and most of sites like Facebook, tweeter, everything that we are blocked by government
I was looking for a way to unblock sites without vpn and i found this on a fourm:
Stubby+Goodbyedpi.zip
This version is all about double click and most of sites are unblocked and was fine and one day my friend scan this and told this has a trojan and since i am not developer, i wanted to ask if it's safe to use or not....

Well, at least GoodbyeDPI and WinDivert are original files, haven't been modified.
Didn't check stubby.


WS-Federation remote login failure ASP.NET Core 2.1+

Context
ASP.NET Core 2.1
ASP.NET Core 2.2 Preview
The app is configured to use cookie authentication through WS-Federation. It is remote authentication.  In the Startup.ConfigureServices I have this configuration
services.AddAuthentication(sharedOptions =>
            {
                sharedOptions.DefaultScheme = CookieAuthenticationDefaults.AuthenticationScheme;
                sharedOptions.DefaultSignInScheme = CookieAuthenticationDefaults.AuthenticationScheme;
                sharedOptions.DefaultChallengeScheme = WsFederationDefaults.AuthenticationScheme;
            })
            .AddWsFederation(options =>
            {
                options.MetadataAddress = "https://address/metadata.xml";
                options.Wtrealm = "urn:sp.Realm";
            })
            .AddCookie();

Problem
The first time context.ChallengeAsync() is invoked, the app flashes the remote authentication screen but then immediately directs to the default WsFederationOptions.CallbackPath, which is /signin-wsfed. It displays the following exception
System.Exception: An error was encountered while handling the remote login. ---> System.Exception: No message.
   --- End of inner exception stack trace ---
   at Microsoft.AspNetCore.Authentication.RemoteAuthenticationHandler`1.HandleRequestAsync()
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.StaticFiles.StaticFileMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)

After this, I can successfully see the remote authentication screen. Once I see the remote authentication screen, there are still two ways I see the same exception on the /signin-wsfed page

Enter invalid credentials. This is despite my remote authentication having a workflow to handle this; the workflow is to prompt for credentials again.

Cancel the login on step 2 of the multi-factor authentication. This is despite my remote authentication having a workflow to handle this; the workflow goes back to step 1 of the multi-factor authentication.

Expectation
I should not be directed from the remote authentication screen to the /signin-wsfed, especially with an exception. I expect to be at my remote authentication.

Regarding the initial auto redirect, I do see a difference in the remote authentication requests.
The first request flows as follows:

Request to my Web API. The response is a 302 that includes the Location of the remote authentication
Request for the metadata
Request for the remote authentication redirect indicated in the first request's response. This response is 200
Request for the /signin-wsfed, which has a 500 response as indicated in the original post for this issue.

Now, without stopping the app, I hit the Web API again. This time the remote authentication stays active. The request flows as follows:

Request to my Web API. The response is a 302 that indicates the Location of the remote authentication
Request for the remote authentication redirect indicated in the first request's response. This response is 200

The main difference I am seeing in the requests is:

The request for metadata is only in the first attempt for authentication
The request for the remote authentication redirect only includes a cookie in the second attempt for authentication. This cookie includes an ASP.NET_SeesionId4 and ASP.NET_SessionId50 along with some other entries

@GoFightNguyen if you can provide Fiddler (or similar) traces, that would be most helpful for us to investigate.

I was working with our IdP and discovered it is rejecting the remote authentication request because it does not contain a wct field. Here is the request
https://passportdev.domain.com/login/?wtrealm=urn%3Asp.Realm&wa=wsignin1.0&wreply=https%3A%2F%2Flocalhost%3A44399%2Fsignin-wsfed&wctx=CfDJ8PvrOyMP_WpGklq96IQEtSCkD_3VKjV7xhO8lsZa0ROi9BTDcPJFXyVBSQ2LnPF--5yAnza3iUGnbjt4HSLFgV_02ySGV06o9TZk74UXc_e9pU9fUxGKFR93LkwXwj3ivp8vGVYo6eQlNQaMUgpw7KLEinj8edepoFsrjxDZbnUjRkIv262a2_AIIxQG2f34BXX1zk-vViPrKWkOpxU0TD3eIG4URPjn-XJtMJ63d2zJxAxVY5-Q2TYGPq-YIJZVyQ
Looking at the WsFederationOptions class, it is not obvious to me how to set the wct.

Hmm, wct is, by the spec, optional. @brentschmaltz can we get the identity model WSFed support to include a timestamp somehow?

Something like this, though you'd need to work out the correct date format.
           .AddWsFederation(options =>
            {
                ...
                options.Events.OnRedirectToIdentityProvider = context =>
                {
                    context.ProtocolMessage.Wct = DateTimeOffset.UtcNow.ToString();
                    return Task.CompletedTask;
                };
            })

By setting the Wct, and having the IdP correct a couple of other issues, problem 1 is now resolved.
I believe problem 2, cancelling the login on step 2 of the multi-factor authentication, is also something specific with how this IdP handles a cancellation.
In other words, both problems were actually because of nuances with the IdP; neither issue was because of the WsFederation middleware. Thanks all for the help!


Localize method should be derived from object

Pull Request
Hi,
Thanks for helping us improve the Predix UI platform by submitting a Pull Request.
To help us merge your Pull Request as fast as possible, please fill out the following sections:

A description of the changes proposed in the pull request:

Removing the 3rd argument  localize as this is not used
Using this.localize in all required methods

A reference to a related issue (if applicable):

https://github.com/PredixDev/px-inbox/commit/8f4e1ec827eb78066e329298e1190ab250d597dc

@mentions of the person or team responsible for reviewing proposed changes:

@randyaskin

working tests:

Waiting for the build result from https://travis-ci.org/sks/px-inbox/builds/337798492
Will make any fixes as required

@mdwragg : Not sure I got this right, Thanks

OK :) No problem! I'll let people I know more about it test the actual change, I just saw the .travis.yml and knew that would cause oddities in the unit tests.


Do not restore CI aritfacts on HIP tests

Update the CI script to not restore CI artifacts to avoid accumulated caches.
Fixes https://github.com/ROCm/triton-internal/issues/103
The core Triton is a small number of people, and we receive many PRs (thank
you!).  To help us review your code more quickly, if you are a new
contributor (less than 3 PRs merged) we ask that you complete the following
tasks and include the filled-out checklist in your PR description.
Complete the following tasks before sending your PR, and replace [ ] with
[x] to indicate you have done them.

[x ] I am not making a trivial change, such as fixing a typo in a comment.

[x] I have written a PR description following these
rules.

[x] I have run pre-commit run --from-ref origin/main --to-ref HEAD.

Select one of the following.

[ ] I have added tests.

/test for lit tests
/unittest for C++ tests
/python/test for end-to-end tests

[x] This PR does not need a test because it doesn't add new features.

Select one of the following.

[x] I have not added any lit tests.
[ ] The lit tests I have added follow these best practices,
including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)

Fixes https://github.com/ROCm/triton-internal/issues/103

This is not publicly-visible.

[x] I have written a PR description following these rules.

Not sure you actually did this.  :)

[x] I have written a PR description following these rules.

Not sure you actually did this. :)

Thank you for the comments. I've updated the PR description to include the problem details. This PR is still a work in progress and is primarily for experimental purposes. I'll provide a clearer description in the final version.


fix: support file names with .

fix: https://github.com/privatenumber/pkgroll/issues/87

Thanks! Appreciate the PR and reproduction 🙌

:tada: This PR is included in version 2.4.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Additional light bulbs for ikea sensors and switches

Hi Erik!
I successfully switched to the deconz plugin!
All lights an sensors are working great! Thx for your work! Great Plugin!
One question: for certain switches and sensors i get an additional light 💡.  It is for ikea products mainly but not for aqara sensors e.g
Whats that for?

Thx, Paul

It's probably the group bound to the switch.  Check the Serial Number in Home, or the Device Settings service in another HomeKit app.

You are right its a "LightGroup" !  only with the sensor in it i guess.
Is there a way i can change that ? the groups don't show up in Phoscon App.

Deselect Expose on the Device Setting of the group accessory.

Hi @ebaauw,
just going through migrating my devices from homebridge-hue. Thanks for your work on the new platform!
I have the same "issue" with the light group being displayed. I set "Expose Groups" = Off in the Gateway setting, so I wonder why the groups get displayed anyways - as lights?
Interestingly, the switches (Tradfri Open/Close remotes) get recognised as such, but I can't blacklist them on gateway level, e.g. by an "Expose Switches" setting. Is there a reason why you only have Groups, Lights Schedule and Sensors on Gateway level?
Last, the blacklisting of individual devices using Expose on the Device Setting doesnt seem to have any effect. For example, Phoscon has this virtual daylight sensor in Sensors. I have Expose Sensors -> Off and I have Expose -> Off on Device level, but I still see the sensor in Home.

The Expose Groups and equivalent are more like “automatically expose new groups”.  Once expose, you need to clear Expose in the _ Device Settings_ to stop exposing the group.
As for the daylight sensor, there’s two possible causes:

Homebridge deCONZ is still exposing the sensor, even though it shows Expose as off.  Make sure to refresh the screen in Eve, so it shows the current value instead of some stale value.  If it still shows Off, set Expose, wait a minute or so, and unset it.
HomeKit still shows the old accessory, even though it has been removed.  As mentioned in the README, HomeKit really doesn’t like changes to the configuration, and it might take a while for these to be synced over iCloud to all your Apple devices.  There is also a limit on the size of the configuration, typically around 180 accessories, but I’m not entirely sure what counts towards this limit. Best check on different Apple devices, reboot the one that isn’t updated, or if that doesn’t help, sign out of iCloud and back into it.

Ok, thank you! That explains some of the other behaviour I observed with the toggles as well.
I have now moved everything over from Hue to deCONZ. All working happily and I find the IKEA blinds to be more responsive than with the previous plugin. Thank you again.


[skia] DLL link error

Dynamic library build fails with default features disabled.
Host Environment

OS: Windows 11
Compiler: Visual Studio 2022
Triplet: x64-windows, x86-windows (non-static)

To Reproduce
./vcpkg install skia[core]
Failure logs
[806/806] link skia.dll skia.dll.lib skia.dll.pdb
FAILED: skia.dll skia.dll.lib skia.dll.pdb
"C:\Program Files\Microsoft Visual Studio\2022\Community\VC/Tools/MSVC/14.34.31933/bin/HostX64/x64/link.exe" /nologo /IMPLIB:./skia.dll.lib /DLL /OUT:./skia.dll /PDB:./skia.dll.pdb @./skia.dll.rsp
   Creating library ./skia.dll.lib and object ./skia.dll.exp
skia.SkWGL_win.obj : error LNK2019: unresolved external symbol __imp_wglCreateContext referenced in function "public: __cdecl <lambda_14b72b2011eb3d2e63916489eb00913e>::operator()(void)const " (??R<lambda_14b72b2011eb3d2e63916489eb00913e>@@QEBA@XZ)
skia.SkWGL_win.obj : error LNK2019: unresolved external symbol __imp_wglDeleteContext referenced in function "public: virtual __cdecl SkWGLPbufferContext::~SkWGLPbufferContext(void)" (??1SkWGLPbufferContext@@UEAA@XZ)
skia.SkWGL_win.obj : error LNK2019: unresolved external symbol __imp_wglGetCurrentContext referenced in function "public: __cdecl <lambda_14b72b2011eb3d2e63916489eb00913e>::operator()(void)const " (??R<lambda_14b72b2011eb3d2e63916489eb00913e>@@QEBA@XZ)
skia.SkWGL_win.obj : error LNK2019: unresolved external symbol __imp_wglGetCurrentDC referenced in function "public: __cdecl <lambda_14b72b2011eb3d2e63916489eb00913e>::operator()(void)const " (??R<lambda_14b72b2011eb3d2e63916489eb00913e>@@QEBA@XZ)
skia.SkWGL_win.obj : error LNK2019: unresolved external symbol __imp_wglGetProcAddress referenced in function "public: __cdecl <lambda_14b72b2011eb3d2e63916489eb00913e>::operator()(void)const " (??R<lambda_14b72b2011eb3d2e63916489eb00913e>@@QEBA@XZ)
skia.SkWGL_win.obj : error LNK2019: unresolved external symbol __imp_wglMakeCurrent referenced in function "public: __cdecl <lambda_14b72b2011eb3d2e63916489eb00913e>::operator()(void)const " (??R<lambda_14b72b2011eb3d2e63916489eb00913e>@@QEBA@XZ)
skia.SkWGL_win.obj : error LNK2019: unresolved external symbol __imp_wglShareLists referenced in function "struct HGLRC__ * __cdecl create_gl_context(struct HDC__ *,class SkWGLExtensions const &,enum SkWGLContextRequest,struct HGLRC__ *)" (?create_gl_context@@YAPEAUHGLRC__@@PEAUHDC__@@AEBVSkWGLExtensions@@W4SkWGLContextRequest@@PEAU1@@Z)

.\skia.dll : fatal error LNK1120: 7 unresolved externals

ninja: build stopped: subcommand failed.

Does this also occur for skia[core,gl]?

No.

I see, these function are always used defined(SK_BUILD_FOR_WIN) && !defined(_M_ARM64) && !defined(WINUWP) in src/utils/win/SkWGL_win.cpp`. (No regression from #28007.)

Can you test #28971?

I'm still getting the same error.

I'm still getting the same error.

To clarify: did you test with that PR applied or were you checking against master? (We just merged https://github.com/microsoft/vcpkg/pull/28971 so you should be able to check master again now)

AFAICT the initial test was early. After that response, I did skia[core] tests via vcpkg CI, test port vcpkg-ci-skia. This history was force-pushed out of the PR history after the CI checks passed.
But external validation is really welcome. Still no MSVC toolchain on my side ;-)

I have tested this issue and it has been fixed by PR https://github.com/microsoft/vcpkg/pull/28971.


Registry search misses some results

When searching for modules, some of the results are missing or incorrect.
There's a module called bbc-microbit-classic-gcc however a search for this:
http://yotta.mbed.com/#search/bbc-microbit-classic-gcc
doesn't show the module. It does appear to erroneously show bbc-microbit-classic-armcc

Instad, searching for a substring from the module name:
http://yotta.mbed.com/#search/bbc-microbit-classic
..turns up the correct result
Doing the same game with bbc-microbit-classic-armcc does show all the results, so I wonder if this is the result of some overlapping metadata from copy/paste in the modules?
@jamessheppard @finneyj

There's a PR about to land on the registry will fix this.
The cause of this strange behaviour is that your search query is split into separate words based on the dashes, but the names of the modules it's being matched against aren't (currently) split in the same way.

Should be fixed now :+1:


esp_http_server websocket send message to all connected clients (IDFGH-3444)

Requirement send  notification to all ws server connected clients
Can not find any function in esp_http_server ->httpd_ws.c to send message to all connected client.
by adding following function in httpd_ws.c work for me
esp_err_t httpd_ws_send_frame_to_all_clients(httpd_req_t *req, httpd_ws_frame_t *frame)
{
esp_err_t ret = httpd_ws_check_req(req);
if (ret != ESP_OK)
{
return ret;
}
struct httpd_data *hd = req->handle;
int fd = httpd_req_to_sockfd(req);
int i;
for (i = 0; i < hd->config.max_open_sockets; i++)
{

    if (fd != hd->hd_sd[i].fd)
    {
        httpd_ws_send_frame_async(hd->hd_sd[i].handle, hd->hd_sd[i].fd, frame);
    }
}
return ESP_OK;

}
In above function  struct httpd_data *hd = req->handle; give me access to all connected clients and we can send message through httpd_ws_send_frame_async
BUT if if try to access  struct httpd_data *hd = req->handle; in my project file mean outside of http server component give me
error: dereferencing pointer to incomplete type 'struct httpd_data'
I think httpd_data defined as private or I am doing something wrong .
Describe alternatives you've considered
or declare struct httpd_data public or make connected client public so we can send message to all clients if we want

Hi, ghtech
Maybe when you call  the function esp_err_t httpd_start(httpd_handle_t *handle, const httpd_config_t *config), you can set the open_fn and the close_fn in the httpd_config_t  structure. Then you can maintain these HD/FD by youself.
    /**
     * Custom session opening callback.
     *
     * Called on a new session socket just after accept(), but before reading any data.
     *
     * This is an opportunity to set up e.g. SSL encryption using global_transport_ctx
     * and the send/recv/pending session overrides.
     *
     * If a context needs to be maintained between these functions, store it in the session using
     * httpd_sess_set_transport_ctx() and retrieve it later with httpd_sess_get_transport_ctx()
     *
     * Returning a value other than ESP_OK will immediately close the new socket.
     */
    httpd_open_func_t open_fn;

    /**
     * Custom session closing callback.
     *
     * Called when a session is deleted, before freeing user and transport contexts and before
     * closing the socket. This is a place for custom de-init code common to all sockets.
     *
     * Set the user or transport context to NULL if it was freed here, so the server does not
     * try to free it again.
     *
     * This function is run for all terminated sessions, including sessions where the socket
     * was closed by the network stack - that is, the file descriptor may not be valid anymore.
     */
    httpd_close_func_t close_fn;

Hi,
I need the same requirement.
https://github.com/espressif/esp-idf/issues/5602

Here is possible solution (at least it's working):
httpd_handle_t server_handle = nullptr; // this variable should be set by httpd_start(…) function

esp_err_t httpd_ws_send_frame_to_all_clients(httpd_ws_frame_t *ws_pkt) {
    static constexpr size_t max_clients = CONFIG_LWIP_MAX_LISTENING_TCP;
    size_t fds = max_clients;
    int client_fds[max_clients] = {0};

    esp_err_t ret = httpd_get_client_list(server_handle, &fds, client_fds);

    if (ret != ESP_OK) {
        return ret;
    }

    for (int i = 0; i < fds; i++) {
        auto client_info = httpd_ws_get_fd_info(server_handle, client_fds[i]);
        if (client_info == HTTPD_WS_CLIENT_WEBSOCKET) {
            httpd_ws_send_frame_async(server_handle, client_fds[i], ws_pkt);
        }
    }

    return ESP_OK;
}


Compiler crash

It's my fault for not updating a reference after renaming a function, and the error was clear enough to me to fix my code (within an imported function, I was calling a function that did not exist) but I'll report anyway. I had --main installed, commit 180f6e7b.
The application panicked (crashed).
Message:  no entry found for key
Location: src/compile.rs:427

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.
Run with RUST_BACKTRACE=full to include source snippets.
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
                              ⋮ 10 frames hidden ⋮
11: core::option::expect_failed::hfc92202fffb4ec7f
    at <unknown source file>
12: <std::collections::hash::map::HashMap<K,V,S> as core::ops::index::Index<&Q>>::index::h3b24bcfc41640ed8
    at <unknown source file>
13: uiua::compile::Compiler::items::hfa8d41ee6d068b0f
    at <unknown source file>
14: std::panicking::try::h6884f0563b1a1647
    at <unknown source file>
15: uiua::compile::Compiler::load_impl::h4e8fb1167f189fe6
    at <unknown source file>
16: uiua::compile::Compiler::load_file::hb9eab788eb8bdebe
    at <unknown source file>
17: uiua::run::Uiua::compile_run::hf5b0aa431b1087b6
    at <unknown source file>
18: uiua::main::h92b1f986b4b0bbc7
    at <unknown source file>
19: std::sys_common::backtrace::__rust_begin_short_backtrace::h10edddde2e4bbc16
    at <unknown source file>
20: std::rt::lang_start::{{closure}}::h4926783816a5d60e
    at <unknown source file>
21: std::panicking::try::h0f4fc6a6c293a630
    at <unknown source file>
22: std::rt::lang_start_internal::h87f8a3eec40cef68
    at <unknown source file>
23: std::rt::lang_start::h6084fd599ee2a7f4
    at <unknown source file>
24: _main
    at <unknown source file>
Error: Unknown identifier `NthPrime`
  at ../lib/prime.ua:20:23
20 | MaxNthPrime ← +1⌈×Phi NthPrime
                           ────────
Error: The compiler has crashed!
Hooray! You found a bug!
Please report this at http://github.com/uiua-lang/uiua/issues/new

code:
Primes ← &i "../lib/prime.ua" "SieveTo"
NthPrimeBelow ← &i "../lib/prime.ua" "MaxNthPrime"

Sol ← Primes NthPrimeBelow
Sol 7

Do you know of a way I can reproduce this crash?

Sure, here's a pretty minimal repo. Trying to interpret bar.ua causes a crash.
Files
repro/foo.ua
AnythingThatWouldBeInvalidCode

repro/bar.ua
A ← &i "foo.ua" "A"
B ← &i "foo.ua" "B"

The new module system should handle this correctly.


Is it necessary for electron-prebuilt to be a hard dependency?

I am running into issues in our CI with this specific dependency failing to download every so often, and it's not something we ever use.  We use chromedriver exclusively.  Can electron & electron-prebuilt be moved to optional dependencies?

+1 running into issues with this as well. The download task inside electron-prebuild to grab from github releases is unreliable on my build machines


Add Pi0 2 W support, switch to honister syntax compat

Known issues in this PR:

 console is not applied to cmdline in development images - addressed
BALENA_STORAGE is set to overlay2 for all boards- not an issue

@resin-jenkins test this please

@balena-ci retest

Let's not merge this PR since it's making use of unmerged PRs - https://github.com/balena-os/balena-raspberrypi/pull/725/commits/fb867f40c4ad09389afc3d132c4a9fdf35bc356c / https://github.com/balena-os/balena-raspberrypi/pull/725/commits/1785de4dbdba9827ccc6fd19f59f3b0b2626e515

@resin-jenkins test this please

@resin-jenkins test this please

Adding Pi0 2W in https://github.com/balena-os/balena-raspberrypi/pull/733
There is not enough rootfs space on Pi4 with honister. Too many files libraries and binaries in the rootfs have small increases in size which add up, and the Pi4 is already very tight on space: balena-image-1.0-r0 do_image_size_check: The disk aligned root filesystem size 282624 exceeds the available space 274432. In Dunfell the rootfs dir in the build directory is 271M and with Honister it is 283M. Firmware directory size is the same.

Superseded by https://github.com/balena-os/balena-raspberrypi/pull/755


Add function to create Transaction object from hex data

Half finished. Need to figure out how to deal with EIP1559 next.

Closing due to inactivity. If there is more to do here, please feel free to re-open with new contributions.


[no-ticket] Fix creating registrations and forks

Purpose
Fix a bug introduced in #387 that broke reloading paginated lists.
Alternative fix to #393

Summary of Changes
The problem is we want paginated-list/* to own their data and be in charge of loading logic, to avoid duplication, but also want to trigger a reload from the parent scope. The solution used here is calling an action to send a bound function upward:
{{paginated-list/... bindReload=(action (mut this.reload))}}

From the parent scope, this.reload() will trigger a reload.
This pattern of passing component actions upward could get messy if used more generally, though. We should probably avoid it in most circumstances. It seems acceptable in this specific situation: Telling a data-loading component to refresh itself.

Reviewer Checklist

[ ] meets requirements
[ ] easy to understand
[ ] DRY
[ ] testable and includes test(s)
[ ] changes described in CHANGELOG.md

Pull Request Test Coverage Report for Build 1574

5 of 11 (45.45%)  changed or added relevant lines in 4 files are covered.
18 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.06%) to 66.427%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/guid-node/forks/controller.ts
1
4
25.0%

app/guid-registration/forks/controller.ts
1
4
25.0%

Files with Coverage Reduction
New Missed Lines
%

lib/osf-components/addon/components/node-list/component.ts
2
67.57%

lib/osf-components/addon/components/paginated-list/base-data-component.ts
2
73.44%

app/guid-node/forks/controller.ts
7
40.0%

app/guid-registration/forks/controller.ts
7
33.33%

Totals

Change from base Build 1567:
-0.06%

Covered Lines:
3177

Relevant Lines:
4420

💛  - Coveralls


Manual set version number

Hi there.
We had splitted our WPF project in several nuget packages that share a common library containing our version number. In HockeayApp, we set the version number by retreving it manualy from the shared library. This way, we don't have to build our main application, if we just updated one of our sub projects. Unfortunable we didnt found a way to set the version number manualy with AppCenter like we did in hockey. Can you give us a hint or implement a similar option for these target?
Greetings
Daniel

@Moccassins We will look into your question and someone from the team will reach out to you soon.
Thanks!

Hi @Moccassins - are you looking for a way to set a version number when making a release? If you upload a .zip or .msi package to App Center, you should see an input field for you to manually set the version number. Is that what you're referring to?
Thanks!

No, we dont upload anything. We want to set the current version that is reported by a crash report from c# code at runtime.

anything new?

Hi @Moccassins - apologies for the delay. I'm not sure I completely understand your request. Are you looking for a way to manually upload crash logs and then set the version for those logs?
If not, can you send a screenshot or walk me through the steps you're going through in HockeyApp? I appreciate it!

We developed our own way to send our data to HockeApp. With that method, we could change the Version number at runtime like we want. Currently, using the AppCenter SDK there is no way to change the Version number manualy, as i can see, it uses allways the file version. We want to set the Version number to use manual on app startup. For this, we need some method to call at app startup or an extra method parameter. Maybe in the Method AppCenter.Start. It could look like: AppCenter.Start("secret app key", typeof(Analytics), typeof(Crashes), version: "<IP_ADDRESS>");
This topic needs to be handled by the AppCenter SDK developers.

Hi @Moccassins - just checked with the SDK team and confirmed we don't currently support this scenario. I'll label this issue as a feature request and keep it open to track community interest.
Thanks!

@winnie  I second this request. We currently don't use the app center for distribution since we push our releases to an Azure storage blob, but we still use the app center for crash reports. It would be nice to be able to set the version number without having to manually upload an MSI or add another release step to our pipeline.

Looks like it's duplicate of #1313
Let's track this feature request there


lbry.io mobile version issue

There is an issue on the mobile version of the website, at the very lower button, below the what's next, the Get LBRY button is separated, making the LBRY barely visible.
Url https://lbry.io/news/lbry-development-community-update-mar-2018

@ceoger thanks for filing this, sent you a few LBC on Discord :)

#715

@tzarebczan close close... hehehe.


error running script compile.m on windows , matlab2015

I am trying to run the compile script on a windows machine , with MATLAB 2015.
However, I am facing the following error with the compile.m script:
>> compile
Building with 'Microsoft Visual C++ 2013 Professional'.
Error using mex
resize.cc
C:\Users\Pallavi\Documents\Khimya\voc-release3.1\resize.cc(36) : error C2057: expected        constant expression
C:\Users\Pallavi\Documents\Khimya\voc-release3.1\resize.cc(36) : error C2466: cannot allocate   an array of constant size 0
C:\Users\Pallavi\Documents\Khimya\voc-release3.1\resize.cc(36) : error C2133: 'ofs' : unknown size
C:\Users\Pallavi\Documents\Khimya\voc-release3.1\resize.cc(70) : error C3861: 'bzero': identifier not found

Error in compile (line 1)
mex -O resize.cc

I did follow the read me and tried all three convolution options as mentioned in step 3
"(you may need to edit compile.m to use a different convolution routine depending on your system) "
Could you please suggest if this code would work in windows ? Also, how could one fix the above issue ? It will be of great help. Thanks.

This below two links help me get rid of all the errors related to resize.cc and dt.cc

http://blog.csdn.net/jiyangsb/article/details/38713119
http://www.mathworks.com/matlabcentral/answers/157130-compiling-mex-on-win7-x64

If anyone faces the same error. Hope it helps.
However, I am still facing a mex related errors while compilint
Error using mex
Unknown MEX argument '-o'.

Error in compile (line 9)
mex -O fconvblas.cc -lmwblas -o fconv

Any suggestions ?
Thanks

Fixed the above problem by following the below steps
Edit the compile.m script by replacing
mex -O fconv.cc -o fconv

with
mex -O fconv.cc

If you are using the third option(the above convolution option), running the compile script now leads to the following error
Error using mex
fconv.cc
error C4716: 'process' : must return a value

This link here - https://code.csdn.net/snippets/128261 , helped resolve this issue, and I successfully ran the compile script and hence the demo script for detection :relieved:
P.S. I am using the version 3 release as I am using this code only as a prerequisite for http://people.csail.mit.edu/tjudd/WherePeopleLook/index.html

how to solve for
error C4716: 'process' : must return a value


Using @RequestHeader with HttpHeaders throws a ClassCast Exception

Using @RequestHeader with HttpHeaders as a method parameter causes a ClassCast Exception. This issue does not appear if using MultiValueMap<String, String> instead.
Apparently, this pull request  over at OpenFeign fixes the issue.
In short, the version of OpenFeign just needs to be updated.
Do you have any idea when approximately you are planning on updating the version of OpenFeign?
Thanks

Closed via 9fc19bb


added untriaged and nolabel badges

Signed-off-by: Shenoy Pratik<EMAIL_ADDRESS>Description
Update readme badges
Issues Resolved

added untriaged and nolabel badges

Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #259 (02ae414) into main (6f30fc4) will increase coverage by 11.81%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #259       +/-   ##
=============================================
+ Coverage     65.29%   77.11%   +11.81%
=============================================
  Files            94       30       -64
  Lines          3922     1866     -2056
  Branches        608      374      -234
=============================================
- Hits           2561     1439     -1122
+ Misses         1220      424      -796
+ Partials        141        3      -138

Flag
Coverage Δ

dashboards-reports
77.11% <ø> (ø)

reports-scheduler
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...tsscheduler/action/DeleteReportDefinitionAction.kt

...reportsscheduler/model/GetReportInstanceRequest.kt

...portsscheduler/model/GetReportDefinitionRequest.kt

...tsscheduler/model/InContextReportCreateResponse.kt

...rtsscheduler/model/GetAllReportInstancesRequest.kt

...search/reportsscheduler/settings/PluginSettings.kt

...rch/reportsscheduler/index/ReportInstancesIndex.kt

...search/reportsscheduler/security/SecurityAccess.kt

...heduler/resthandler/ReportDefinitionRestHandler.kt

...duler/resthandler/ReportInstanceListRestHandler.kt

... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f30fc4...02ae414. Read the comment docs.


Arrow key up should place cursor at end of input

Right now, when going up, the cursor remains at index 0, but it should be at the end of the input.

will be out in next release

new version is out 4.0.0


Audit integration tests for 5.0

We need to audit all the integration tests before we can release 5.0.
Any integration test that is failing for all (or nearly all) connectors should have an individual issue opened and 💀'd. This is likely a qscript bug.
Any integration test that is failing for a small set of connectors should have an individual issue per connector (assuming the qscript is correct). These should be provisionally 💀'd until we determine the importance of that query to run on that connector for 5.0.

@djspiewak while you're doing this, we also have the option of closing out the "make all the integration tests work" issues we have open for individual connectors. At this point most tests are working for most connectors, so I think having individual issues makes sense in lieu of the giant issues.
These are somewhat out of date anyways:
ML: https://github.com/quasar-analytics/quasar/issues/1948
CB: https://github.com/quasar-analytics/quasar/issues/1607
mimir: https://github.com/quasar-analytics/quasar/issues/2542
mongo: https://github.com/quasar-analytics/quasar/issues/2532
I couldn't find one for spark.

As a side note, I do think it's useful to be able ask and immediately answer the question: "Which integration tests / demo environments are not working for connector X?". But this isn't something that should ever be maintained manually; we'd have a dashboard or something for this that updates automatically each time we release quasar.

If we had slamdata running somewhere and a current copy of the quasar source tree, we could dogfood a dashboard for this.

I audited everything… And then accidentally deleted all the work right before a backup cycle.  So we get the roughly-reconstructed version of the ones that are actually relevant:

tests/subqueryGroupBy.test

bizarre distinct recognition thing, I think

tests/groupByFlatten.test

❌ [ReifyBuckets] Expected to find a mappable region in 'qsu23 based on one of NonEmpty['extract34]

tests/flattenOrElseField.test

❌ The flattenable dataset is just missing; I think @rintcius forgot to add it

tests/unsupportedTests.test

This one is concerning. No idea why it's not working on mimir and mongo

tests/multitypeFlatten.test

Hits the Both case
Several others in this category


CopyN with net.Conn oddness

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?
1.6

What operating system and processor architecture are you using (go env)?
win10, intel i5

What did you do?

package main

import (
	"log"
	"io"
	"net"
	"fmt"
)

func main() {

	l, err := net.Listen("tcp", ":4444")
	if err != nil {
	    log.Fatal(err)
	}

	defer l.Close()

	for {
		// Wait for a connection.
		conn, err := l.Accept()
		if err != nil {
			log.Fatal(err)
		}

		fmt.Println("new connection")

		go func(c net.Conn) {
			// Echo all incoming data.
			n, err := io.CopyN(c, c, 5);

			if err != nil {
				fmt.Println(err)
			}

			fmt.Println(n)
			fmt.Println("connection closed")
			// Shut down the connection.
			c.Close()
		}(conn)
	}
}

What did you expect to see?
using telnet

1 -> 1
2 -> 2
3 -> 3
4 -> 4
5 -> 5

new connection
5
connection closed

What did you see instead?

1 -> 1
2 ->

new connection
5
connection closed

I don't see a bug here. Let's move questions to a forum. See: https://golang.org/wiki/Questions Thanks!

what do you mean you don't see a bug, CopyN it takes each single byte as 3 bytes
can you elaborate please

Let's move this to the mailing list and I and others can help there. Again, there's no bug here. Telnet is sending a carriage return and newline after each byte you enter. Those count towards your 5.

Thank you sir, approval is pending on the forum.


Migrating docs to NEXT JS as same as new React js docs 💫

Migrating the old documentation website to Next js as same as new react js docs :)

Bro we need to code the site next js


Auth testing

We added tests for authentication in the auth module. We can't really test to see if credentials will log us in since we don't know what usernames, passwords, and team names jama software has a hold of. We ended up just testing out the promises returned for our stubbed out pagination.

These changes are in #73, too. Which pull request is the right ones for authentication testing?

Dang! Looks like the commits are the same. I'd probably just pull in #73 and close this one out


Fix #102 - Add vuepress as dev dependency. Import vuecode as node_module

This fixes #102 (I was having the same issue when trying to run the vuesax docs locally).

In docs/.vuepress/enhanceApp.js Instead of importing vuecode.common.js from ./vc, import it directly from node_modules

import Vuecode from './vc/dist/vuecode.common.js' -> import Vuecode from 'vuecode.js/dist/vuecode.common.js'
import './vc/dist/vuecode.css' -> import 'vuecode.js/dist/vuecode.css'

vuepress recently removed the pathToComponentName function from utils, so I added the code to ./utils, which leads to why I added vuepress as a dev dependency.

https://github.com/vuejs/vuepress/blob/master/lib/app/util.js -> now missing pathToComponentName

Add vuepress as a dev dependency.

Instead of requiring contributors to install vuepress globally, as a dev dependency, you can be sure everyone is using the same version. The build script will still work, it now just looks at the vuepress in node_modules instead of the globally installed one.

Thank you very much for solving this problem 👍


Fix y axis title of 'System services Memory usage'

Cores -> Memory
How to categorize this PR?

/area TODO
/kind TODO
/priority normal
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you @gadisn for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

/assign @istvanballok @wyb1
/ok-to-test