⚠ Bofrost.be has degraded performance

In 0c4ea66, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2283 ms

Resolved: Bofrost.be performance has improved in c11854b.


Build error

version: 0.5.0-2
error[E0063]: missing fields `__bindgen_padding_0` and `__bindgen_padding_1` in initializer of `bpf_object_open_opts`
  --> src/bpf/object.rs:41:9
   |
41 |         libbpf_sys::bpf_object_open_opts {
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `__bindgen_padding_0` and `__bindgen_padding_1`

For more information about this error, try `rustc --explain E0063`.

why are these paddings explicit? it is a breaking change that makes CI broken. please consider using another versioning scheme to avoid this kind of problems.

I've added explicit padding like this because it turns out that libbpf checks that struct padding is zero, for some bizarre reason.
This is the relevant PR: https://github.com/alexforster/libbpf-sys/issues/25
Once libbpf goes 1.0 (soon!) we'll start following SemVer.

thanks


write read_chunk methods

the specific read_chunk methods need to be written and documented
methods have to be in the NAMESPACE that they are correctly recognised
methods:

read_chunk.text
read_chunk.parameter
read_chunk.data

We have  done this :-)


Implements PQ hybrid shared secret derivation for TLS 1.3

Please note that while we are transitioning from travis-ci to AWS CodeBuild, some tests are run on each platform. Non-AWS contributors will temporarily be unable to see CodeBuild results. We apologize for the inconvenience.
Resolved issues:
N/A
Description of changes:

Implements PQ hybrid shared secrets derivation for TLS 1.3: s2n_tls13_compute_pq_hybrid_shared_secret()
For now, defines two kem_groups: s2n_x25519_sike_p434_r2 and s2n_secp256r1_sike_p434_r2
Adds structure to struct s2n_crypto to be used during hybrid 1.3 handshakes
Adds s2n_kem_group_free() that is analogous to s2n_kem_free()

Call-outs:
None of the hybrid 1.3 client or server functionality has been implemented, so there are no integration tests yet. This change should be completely backward compatible with classic 1.3.
Testing:

Unit/known answer test for s2n_tls13_compute_pq_hybrid_shared_secret()
Unit test for s2n_kem_group_free()

Small refactor in the way s2n_kem_test tests s2n_kem_free() to accommodate code re-use

Ran tests locally while building with S2N_NO_PQ=1

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #2064 into master will decrease coverage by 0.31%.
The diff coverage is 92.45%.

@@            Coverage Diff             @@
##           master    #2064      +/-   ##
==========================================
- Coverage   80.77%   80.45%   -0.32%
==========================================
  Files         233      234       +1
  Lines       17609    17660      +51
==========================================
- Hits        14224    14209      -15
- Misses       3385     3451      +66


Trusted certs pulled over insecure channel

https://github.com/Lukasa/hyper/blob/7a4d51e9be65adee677f566a05f4a787cad7ba0d/Makefile#L4 The CA bundle should only be pulled over encrypted channels during the build to reduce the likelihood of someone man-in-the-middling the request and injecting their own trusted CA into the bundle.

Certs are not pulled over an insecure channel, they're obtained from mkcert.org, as with certifi (explained in certifi/python-certifi#23). However, agreed that I should update the makefile.

Resolved in 0741b55c3e1ede9e0c902cd82bb3dd2fd25f21f1. Thanks @Prandium!

Glad to hear it, thanks for the info.


Fix Stopwords/Antiprompt

The original break was breaking out of the inner for loop, but not the outer while loop. Repurpose (?) the existing unused variable is_antiprompt to terminate the while loop if any antiprompt was found. We can still break out of the for loop, since we already found one antiprompt, finding others is not useful. Fixes  #183

This also silences an unused variable warning, so I assume this was always the intent at some point.


IllegalArgumentException: timeout value is negative

The following error occurs in long during searchAll queries:
07:19:55.057 [main       ] INFO   i.g.r.t.h.AbstractRequestHelper Rate limit exceeded, new retry in  at 07:19
07:19:55.058 [main       ] ERROR  c.z.n.b.twitter.TweetsCatcher ERROR catched in main, wait 60s and restart
java.lang.IllegalArgumentException: timeout value is negative
at java.base/java.lang.Thread.sleep(Native Method)
at io.github.redouane59.twitter.helpers.AbstractRequestHelper.makeRequest(AbstractRequestHelper.java:104)
at io.github.redouane59.twitter.helpers.AbstractRequestHelper.makeRequest(AbstractRequestHelper.java:76)
at io.github.redouane59.twitter.helpers.AbstractRequestHelper.makeRequest(AbstractRequestHelper.java:54)
at io.github.redouane59.twitter.helpers.RequestHelperV2.getRequestWithParameters(RequestHelperV2.java:50)
at io.github.redouane59.twitter.TwitterClient.getTweetsRecursively(TwitterClient.java:910)
at io.github.redouane59.twitter.TwitterClient.searchAllTweets(TwitterClient.java:899)
The problem is since version 2.20 since the AbstractRequestHelper reads 'x-rate-limit-reset' in line 92.
solution: check retryAfter for negative values and don't sleep if retryAfter is negative.
Thanks for this great project!

Hello, thanks for the issue.
Do you think you could submit a PR ? Then I'll be able to release a new version as talked here :
https://github.com/redouane59/twittered/issues/438

yes, I can do that. where can I commit?

Just fork the project, do your job, and then submit a Pull Request to this repository :)

done, thanks.


feat: support public test patch 0.218.12

Fixes #96
https://steamdb.info/patchnotes/14182885/

Awesome, thanks! 🥳


Adjusted stripping menu size and order

About the PR
Closes #10424
Someone had a PR about this and it got closed for some reason, so I figured I'd pick it up. Comments in the PR said that hard coding a height increase of the window is fine for now. So I did that.
Also I'm adjusting the order of the inventory. Basically flipping everything in the stripping menu so that the equipment is sorted from top to bottom and from inner to outer. This has the side effect of also changing the order inventory interface at the bottom of the screen. This might rub folks the wrong way, but I'm going to take the chance now to include it because I think it's better this way. (I'll change it back if requested).
Screenshots

Stripping menu with new default height and reordered
(UPDATE: I moved the ID to below the pockets to preserve the bottom inventory order [pocket 1, pocket 2, id])

New proposed order for inventory

Changelog

:cl:

tweak: Increased stripping menu height and reordered inventory

About the PR
Closes #10424
Someone had a PR about this and it got closed for some reason, so I figured I'd pick it up. Comments in the PR said that hard coding a height increase of the window is fine for now. So I did that.
Also I'm adjusting the order of the inventory. Basically flipping everything in the stripping menu so that the equipment is sorted from top to bottom and from inner to outer. This has the side effect of also changing the order inventory interface at the bottom of the screen. This might rub folks the wrong way, but I'm going to take the chance now to include it because I think it's better this way. (I'll change it back if requested).
Screenshots
Stripping menu with new default height and reordered (UPDATE: I moved the ID to below the pockets to preserve the bottom inventory order [pocket 1, pocket 2, id])
New proposed order for inventory
Changelog
🆑
* tweak: Increased stripping menu height and reordered inventory

You might want to make it slightly bigger to accommodate for both handcuffs and ensnares (coming soon, PR is open for it)

You might want to make it slightly bigger to accommodate for both handcuffs and ensnares (coming soon, PR is open for it)

Could you please link me to that PR? I'd like to look at it to accommodate.

#9968

the last time this pr was opened, it was brought up the it should just automatically scale to fit all of the buttons. Making prs upping the size every time someone adds a new clothing slot is just strange. Additionally, it'll appear weird with entities that don't have as many slots (such as monkeys).

im fine with this until it just gets replaced with hud refactor and electro's PR


URL Encoding problem !!!

Hi, I was trying to encode the URL containing 'SPACE' but it is converting into '%2B' instead of '%20'
Expected outcome
URL should contain '%20' (decode from = 'SPACE')
Actual outcome
URL having '%2B' (decode from = '+')
Versions
App: <IP_ADDRESS>8-stable
Chrome: 54.0.2840.99
Platform: Windows (7)
Steps to reproduce

Put this in the request URL 'http://google.com/?q=Rajul Mondal'
Encode the URL from the Encode option
URL will be converted into 'http://google.com/?q=Rajul%2BMondal'

Hi,
The bug is already patched and it will be released in next 2 days (have to test it first on real live APIs).
For some reason (my fault of course) the app encodes the URL twice when you click on the menu button.
Sorry about that.

Yes, I have tested in real live APIs which I don't want to share in public.
Thanks for you support.


Add test which breaks on WindowsOS

Description
This test succeeds on MacOs, and according to OP of #2781 it breaks on Windows OS. Verify whether this test also breaks in build pipeline.
Checklist
Before submitting the PR, please check following (checks which are not relevant may be ignored):

[X] Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
[ ] At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
[X] Tests are added
[ ] KtLint format has been applied on source code itself and violations are fixed
[ ] PR title is short and clear (it is used as description in the release changelog)
[ ] PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

[ ] Snapshot documentation in case documentation is to be released together with a code change
[ ] Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

See #2781 why no changes are needed.


Bug: Code Editor + Jest not working

Hey! Thanks for this library.
The Code Editor does not work when using Jest. One reason is Jest not supporting import statements natively but what I am not understanding is that it should be using cjs - but it is not.
I created a down-to-earth, super-easy repository (it literally does nothing but importing your library and console.log). Just do npm i and run yarn jest to trigger jest.
https://github.com/activenode-bugs/uiw-react-textarea-code-editor-jest
You will see the error message of Cannot use import statement outside a module.
I googled this for hours and tried multiple things but maybe I'm overlooking something.  It will always end up in trying to load unified from the rehype library with an import statement instead of going for a non-module approach.
What works (which is not a satisfying solution):
I've looked into your package folder which contains esm, cjs AND a dist folder. If you use jest with moduleNameMapper and then map @uiw/react-textarea-code-editor to @uiw/react-textarea-code-editor/dist/editor.js it will work / run.
moduleNameMapper: {
    // if you use the following, it will work
    // '@uiw/react-textarea-code-editor':
    //<EMAIL_ADDRESS>  },

But the question is WHY? My first thought then is: Shouldn't your repo point main: "dist/editor.js" if this works seamlessly?
Which triggers my follow up question why there even is esm, cjs AND dist (can you clarify the differentiation?) and why does dist/editor.js work but cjs does not?
I feel like there is something weird going on which you can probably clarify as I am not as deep into this as you are :) Thank you so much in advance!

You'll find easy reproduction steps in the README file of https://github.com/activenode-bugs/uiw-react-textarea-code-editor-jest

@activenode

dist The ones in dist belong to UMD,  UMD builds can be used directly in the browser via a

Thanks for clarifying the difference. Can you imagine why the error of import appears even though commonjs shouldn't lead to that? Like this is really confusing. I've tried it in at least 5 different setups, with and without TypeScript, with and without nextjs and it's always the exact same thing.
Once you are using your library anywhere with jest (no matter if just jest, babel-jest or ts-jest or both) it will always lead to this exact problem that you face when you run the related repo.

The current repo test case is running fine, it has nothing to do with the library. This has a lot to do with build tools.
@activenode

Hey @activenode which suggestion did you end up going with?

Actually, since this is a bigger problem, we had a large discussion and there are only 3 things I can recommend simply because of their convenience:
Try:

Switch on experimental ESM support in Jest (https://jestjs.io/docs/ecmascript-modules)
Switch to vitest which in many cases is super low effort because it's mainly compatible to Jest

Or else:
We and the teams switched to vitest but also we  switched to @codemirror as we experienced more and more problems we couldn't solve with this react-textarea-code-editor .
@codemirror is freaking good but it's documentation isn't that easy. Everything's an extension in the newest CodeMirror but feel free to ping me directly for further questions. We basically switched to CodeMirror and used the useCodeMirror hook as a basis.

I managed to fix this issue by changing the import.
Instead of
import CodeEditor from '@uiw/react-textarea-code-editor';
used:
import CodeEditor from '@uiw/react-textarea-code-editor/esm';


'Free' label on Exhibition and Events

The logo in the global nav has been moved to the right (was this intentional?) and it's overlapping with 'Free' label on Exhibition and Events.
I suggest we move the 'Free' label to above the hero image to make it more noticeable and revisit the global nav when we tackle the navigation.
(

Can I suggest the label movement happens separately to bug fix please? We have the label movement logged here, along with other research questions relating to the free messaging: https://github.com/wellcometrust/wellcomecollection.org/issues/3517

@jennpb Are you suggesting that we move the logo back to the center as it was originally for now?

Yes, I don't know why the logo would have moved. It certainly wasn't a design decision.


cache Node data via single unified Node data

The Pod is cached in one scheduling cycle.
https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/blob/main/guest/internal/cyclestate/cyclestate.go#L17-L19
And we can do the similar with Nodes.
There are currently two types for Nodes.

nodeList in PreScore https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/blob/main/guest/prescore/prescore.go#L93
nodeInfo in Filter https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/blob/main/guest/filter/filter.go#L81

We can unify them and cache Nodes as well like a Pod.
/kind feature

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/assign

/triage next-release

/priority next-release


Notebook-related views have blank empty state

Examples: https://emptystat.es/
Generally, instead of having a blank list when a list is empty (e.g. no saved books), you want to have a button to create a new book to help the user along

Duplicate of #8053 We are already working on create book experience and open-book had been added to the view to open any existing books.


add collection search extension

Related Issue(s):

#135

Description:
Adds the collection search extension by pointing the all_collections method at the pgstac function collection_search instead of all_collections.
I have not tested to see if paging is implemented yet, need to upload a bunch of collections to my local db I guess! :sweat_smile:
PR Checklist:

[x] pre-commit hooks pass locally
[x] Tests pass (run make test)
[ ] Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
[x] Changes are added to the CHANGELOG.

A queryables link seems to be missing in GET /collections

Great work. A queryables link seems to be missing in GET /collections, right?

@m-mohr correct, we will get the changes we just pushed to main from #89

@vincentsarago #89 didn't solve it for Collection Search, that was only for Item Search. So getting #89 doesn't change anything with regards to my request.

Great work. A queryables link seems to be missing in GET /collections, right?

@m-mohr correct, we will get the changes we just pushed to main from #89

I rebased on main so this branch should be up-to-date with the queryables link now.

@vincentsarago are you worried about the possibility of inconsistencies between the arguments in PgstacSearch and the collection-search GET request model? I believe the collection-search GET request should have a subset of the parameters from item-level search and never any extra parameters. If I pass a collections_get_request_model that should limit the args that get passed to PgstacSearch in the all_collections method to the ones that are available in the collection-search endpoint with all of the enabled extensions.
I'm sorry about all of the force pushes, I had to clean some things up in order to make the changes mergeable with main :sweat_smile:

@vincentsarago I think we need a new release of stac-fastapi with the changes from https://github.com/stac-utils/stac-fastapi/pull/745 in order to properly configure the collection-search extension with the other configured extensions.

It looks like I am having some datetime json issues in Python 3.10, I'll figure out a fix.

@vincentsarago thanks for your help getting this cleaned up, I think everything is looking good. I added some commits based on @alukach's suggestions. The only outstanding conversation is about the ids parameter which might be occasionally convenient but I think it would be ok to proceed without it since it's not in the collection search extension spec.


Update notebook for tensorforce change

Rename 'actions' to 'action' in execute(), in line with changes to tensorforce: https://github.com/reinforceio/tensorforce/commit/fd30c0fd7faa64f5df9232bfa75907b09dc377e9#diff-4e26d3175bf321b40c3eaaea94bafe1c

lgtm


Multiple characteristics and multiple services in each for ESP32 Dev Kit (IDFGH-9014)

Is your feature request related to a problem?
Hello All,
Is it possible to create Multiple services with Multiple characteristics in each?
I am trying to create 4 characteristics with 3 services in each.
I am trying to merge the Service Table and Gatt_Client_Demo Example.
Please any suggestions are welcome, please help with the same.
Regards,
Akash Rao
Describe the solution you'd like.
I'd like an example where users learn to create Multiple services and Multiple characteristics in each service (3 Services with 3 characteristics in each would be great)
Describe alternatives you've considered.
I tried merging the Gatt_Client_Demo with Gatt_Server_Table_Demo, but I keep encountering runtime bugs and my BLE App wont start and ESP would keep rebooting itself.
Additional context.
No response

Here is a simple example of two services that you can refer to for modification.
ble_ftms.c.zip

Thank You, this solves it.
Regards,
Akash Rao


Remove redundant iteration in EntitySelectionTree merging algorithm

#308  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @AnthonyMDev and the rest of your teammates on  Graphite


AudioNav dataset not found

I followed the install instruction and I encounter the issue that AudioNav dataset is not found. I didn't find the solution. Where should I download it? Thanks!
Detailed Message:
2023-10-18 17:54:35,435 Initializing dataset AudioNav
Traceback (most recent call last):
  File "/ceph/home/zhanghaotian/multi-modal-mas/sound-spaces/scripts/interactive_demo.py", line 244, in <module>
    main()
  File "/ceph/home/zhanghaotian/multi-modal-mas/sound-spaces/scripts/interactive_demo.py", line 233, in main
    dataset = make_dataset(id_dataset=config.TASK_CONFIG.DATASET.TYPE, config=config.TASK_CONFIG.DATASET)
  File "/ceph/home/zhanghaotian/multi-modal-mas/habitat-lab/habitat/datasets/registration.py", line 21, in make_dataset
    return _dataset(**kwargs)  # type: ignore
  File "/ceph/home/zhanghaotian/multi-modal-mas/sound-spaces/soundspaces/datasets/audionav_dataset.py", line 86, in __init__
    with gzip.open(datasetfile_path, "rt") as f:
  File "/ceph/home/zhanghaotian/anaconda3/envs/ss/lib/python3.9/gzip.py", line 58, in open
    binary_file = GzipFile(filename, gz_mode, compresslevel)
  File "/ceph/home/zhanghaotian/anaconda3/envs/ss/lib/python3.9/gzip.py", line 173, in __init__
    fileobj = self.myfileobj = builtins.open(filename, mode or 'rb')
FileNotFoundError: [Errno 2] No such file or directory: 'data/datasets/audionav/mp3d/v1/val_telephone/val_telephone.json.gz'

@ChanganVR I have downloaded the datasets, metadata, pretrained_weights and sounds. However, the scene_datasets and scene_observations are not available for download. I have emailed in and submitted the Term of Use a long while ago but no one got back to me after that. I wonder how may I get the dataset or use the pretrained_weights to recreate the audionav video?
Thank you in advance!


Minor Changes:

Inline var
reuse function

Coverage increased (+0.0001%) to 99.521% when pulling 0148a0f44b8d86ec7eed781f96887ca4685e6dbe on arturobernalg:feature/minor_changes into 59b14533180f2cbc15e23726478eef7d630ed042 on apache:master.

mm Ok. I think it's better close this pr.
TY


chore: remove useless dependencies

:tada: This PR is included in version 6.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


When using @ignore for some fields, there is no create method in the model

Bug description
When using @ignore for some fields, there is no create method in the model. I'm ignoring just two fields but the rest should be available.
How to reproduce
Define this model:
model User {
  id        Int       @id @default(autoincrement())
  email     String    @unique
  password  String
  createdAt DateTime  @default(now()) @ignore
  updatedAt DateTime  @updatedAt @ignore
  remarks   String?
}

Then generate it. Then you cannot create a user using this code:
await this.prismaService.user.create({ data: newUser });

Because of this error:
Property 'create' does not exist on type 'UserDelegate<RejectOnNotFound | RejectPerOperation | undefined>'.ts(2339)

Expected behavior
The create method should be there!
Prisma information

Environment & setup

OS: Ubuntu 21.10
Database: PostgreSQL
Node.js version: 16.13.1

Prisma Version
3.8.1

That's odd. If you remove the @ignore and re-generate does create show up?

@matthewmueller
Yes

same issues, too

I can reproduce:
model Foo {
  id  Int    @id @default(autoincrement())
  foo String
  bar String?
}

    await prisma.foo.create({
        data: {
            foo: "lala",
        }
    });

Works fine.
As soon as I add @ignore on foo the create is underlined red.
(Note that I needed to reload the TS server after generate to make this visible)

This is a pretty serious problem, as it prevents people from removing columns safely by ignoring them first in the client. See related discussion here.
Without something like @ignore for fields, there's currently no way AFAICT to delete columns without causing some downtime.

Please open a feature request for what you need if there is none for it yet, otherwise link to it. This is really just a bug issue about unexpected behavior when using @ignore how it was currently designed.

Maybe I'm not understanding how @ignore was designed to be used. @ignore would in theory achieve this desired outcome according to the docs, so it doesn't feel like a feature is missing?
It seems like the bug goes away when the field is marked optional, FWIW.
// no `create`
model Test {
  id  Int    @id @default(autoincrement())
  foo String @ignore
}

// has `create`
model Test {
  id  Int    @id @default(autoincrement())
  foo String? @ignore
}

That then explain what is happening: Without providing a value to a non optional field, a modle can not be created in the database - hence a required field being marked with @ignore removes the create method in the Client API.
We probably should confirm this internally, and if true and intentional, add this to the documentation.
@AndrewSouthpaw That we have this discussion in a bug issue (that is potentially just a misunderstanding, not a real bug - or missing documentation) shows that this is not the right place to get the behavior you want or need. If it turns out that the feature indeed does already do what you want, we can still close the feature request. (And if not, figure out why it is like that or if it can be adapted etc)

Yeah, once I realized making it optional fixed the issue, it was a "ok, I guess that makes sense" moment, I can see how it wouldn't work with the Prisma machinery. I think it's reasonable to assume String @ignore would've worked fine as well, so a note in the docs would definitely fix the issue.
I opened a PR with some propose changes, to try to make things easier for you all. 😄
I've tested it out locally, and using @ignore on an optional field does give us what we need for zero-downtime migrations to delete a column. In the same way that Rails has self.ignored_columns, and you need to set that before deleting the column to avoid downtime, Prisma would achieve this with @ignore.
Orthogonal but related to this issue, I think it'd make sense to create a little guide on safely deleting columns, since it's an easy mistake to make. What do you think about me contributing a new section next to here, maybe something like "Deleting columns" perhaps?

FYI there is now a rule forbid-required-ignored-field in prisma-lint to prevent confusion here:
https://github.com/loop-payments/prisma-lint/blob/main/src/rules/forbid-required-ignored-field.ts


Update evse.cpp

Add fix for Wifi disconnect issue #27

Fix for sporadic disconnects requiring power cycle or using the menu on the EVSE to manually turn wifi off and on again.

Two remarks:
-you talk about check every 120 seconds, but in the code you check every 5 secs. Is that long enough for the firmware to let it try to reconnect itself (autoreconnect=true)?
-perhaps change status == !WL_CONNECTED to status != WL_CONNECTED, a bit cleaner code?

No, it doesnt check every 120 seconds - thats just the time the EVSE needed (in my tests) to reconnect once its dropped out of the WiFi (artifically). The check is done every 5 seconds. I havent made further analysis why it needs 120 seconds - as my EVSE is installed far appart i cant access TX/RX console to debug. But it works and i am fine with this timeframe.
As for the code: yes thats probably a bit cleaner. Might change it, lets see if there is more feedback on this in general.

You're right, I'll read better next time!

Thanks @jonasf21 for the PR. If you don't mind I prefer going with https://github.com/serkri/SmartEVSE-3/pull/32 as soon as we can confirm this works. I'll leave this open until then

@koen-serneels yes, @dingo35 's fix is working better than mine in terms of reconnect time. Please use his fix and close this pull.


issues with shabang

Can't be used as a script dirrectly due to some encoding issue:
/usr/bin/env: ‘python3\r’: No such file or directory
/usr/bin/env: use -[v]S to pass options in shebang lines
Windows encoding is probably the issue.

#58

Please specify the running platform
And a screenshot of the output?
I believe its a OS issue i know

Oh, its probably because windows end line with \r\n
What a pain. I'll test and patch


update dsc chapter and add team profile

Updated DSC header and added team's profile

victor please do note that the files you are expected to change are in the src/ folder, not the root folder. Do not touch the files in the root directory. We make use of gulp to process our css,js, and html files and at the end are bundled and created at the root. A few changes have been made after your pull request,please revert to only editing files inside the src folder and send in your PR again.


UIAutomationCore.h error C2146

In Visual Studio 2019, UIAutomationCore.h causes compile errors C4430 then C2146:
Severity	Code	Description	Project	File	Line	Suppression State
Error	C4430	 missing type specifier - int assumed. Note: C++ does not support default-int	UIXPathLib	C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\um\UIAutomationCore.h	41
then
Severity	Code	Description	Project	File	Line	Suppression State
Error	C2146	 syntax error: missing ';' before identifier 'IRawElementProviderSimple'	UIXPathLib	C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\um\UIAutomationCore.h	41

Please reopen if you're still facing this issue on the latest version of VS2019.


Fix double-encoding of URL Paths

This is a bug only present on the qt4 version, this change tries to
emulate what seems to be the default behaviour in qt5.

Current coverage is 84.40%

Merging #314 into master will decrease coverage by -1.09% as of 3b263ae

@@            master   #314   diff @@
=====================================
  Files           40     40
  Stmts         4384   4431    +47
  Branches       567    606    +39
  Methods          0      0
=====================================
- Hit           3748   3740     -8
- Partial        143    157    +14
- Missed         493    534    +41

Review entire Coverage Diff as of 3b263ae

Powered by Codecov. Updated on successful CI builds.

Thanks!


Local build option for offline analysis

Constructed workflows should be robust to bandwidth-limited or intermittent internet access. The current build process outputs link to workflow modules on github; there should be a local build option so that workflows can be run offline (flatten workflow and pull required resources ahead of time).

Closed as superceeded by #88


Advice on obstacle detection

ISSUE TEMPLATE ver. 0.2.0

Which TurtleBot3 you have?

[x] Burger
[ ] Waffle
[ ] Waffle Pi

Which SBC(Single Board Computer) is working on TurtleBot3?

[x] Raspberry Pi 3
[ ] Intel Joule 570x
[ ] etc (PLEASE, WRITE DOWN YOUR SBC HERE)

Which OS you installed in SBC?

[ ] Ubuntu MATE 16.04 or later
[x] Raspbian
[ ] etc (PLEASE, WRITE DOWN YOUR OS)

Which OS you installed in Remote PC?

[x] Ubuntu 16.04 LTS (Xenial Xerus)
[ ] Ubuntu 18.04 LTS (Bionic Beaver)
[ ] Linux Mint 18.x
[ ] etc (PLEASE, WRITE DOWN YOUR OS)

Please, describe detailedly what difficulty you are in

Hello again ROBOTIS team, I don't have an issue but just a question about turtlebot 3 and hoping you could give me some guidance. I want to know if I can implement a PID control system on the robot speed aka dynamixels using the lidar to avoid collision with obstacles. The idea is the turtlebot would follow a line using the IR sensors I attached and while following the line it would use lidar sensor to detect anything in front of it and it would slow down or stop according to the distance in between. While doing this the object in front can move too but the turtlebot must move accordingly.

Question: How can I use the Obstacle Detection Here to adjust the speed of the dynamixels rather than stopping immediately. I want to use Arduino IDE for this and vary the speed of dynamixels according to the distance detection made from lidar. I found in the machine learning section about this however there is no such information. I am looking forward to your help and would gladly answer questions to clear any confusion.

Hi again @Hellsgone :)
You can control the speed according to the value of LDS. I recommend that modified this code.
https://github.com/ROBOTIS-GIT/turtlebot3/blob/master/turtlebot3_example/nodes/turtlebot3_obstacle#L43
This code is simple. The value of front LDS is less than 0.2m, the speed is 0 m/s. Otherwise the speed is 0.05 m/s. For example, if you want to add that the value of front LDS is 0.2 to 0.5, the speed is 0.02 m/s.
elif 0.2 < min(self.scan_filter) < 0.5:
self.twist.linear.x = 0.02
self.twist.angular.z = 0.0
self._cmd_pub.publish(self.twist)
Thanks,
Gilbert

Hello, thank you for taking the time to reply.
Yes this is perfectly what I needed, I have modified the degree and distance speed parameters and it is working all good. I have another question. Can I use the library used in this application for arduino IDE? I want the turtlebot to follow a line and scan for obstacles at the same time and I need to implement a PID control to the speed of the turtlebot but I don't know how to adjust the motor speed apart from using dxl_wb.goalSpeed which is only static speed. Also I have both programs but how can I make them into one. I also want to know the code for the LDS and dynamixels for arduino IDE that is of course if my idea can be possible. Thank you so much you are so helpful. Looking forward to this reply as now this is the most important part I am stuck with.
Kind Regards,
Arda

Hi :)
You can find the example of LDS in OpenCR library.
File -> Examples -> OpenCR -> Etc -> LDS -> drawLDS
And I recommend PWM Control Mode with PID control. You can get an idea how to use this in turtlebot3_segway example.
File -> Examples -> TurtleBot3 -> turtlebot3_friends -> turtlebot3_segway

Thank you for the help I really appreciate it. Managed to do both goals I wanted the robot to achieve.
:)

Nice! If you have any further questions, please feel free to open issue.

Could you please link, File -> Examples -> TurtleBot3 -> turtlebot3_friends -> turtlebot3_segway ? Where Can I find this folder?


1r1s

Refactor for lambda-cfn v2

Finished my code review - this looks good, all I could find were the minor grammar issues in https://github.com/mapbox/patrol-rules-github/pull/13#discussion_r133318961.
The points I brought up about docs shouldn't delay merging or release this. Let's 🚢 .


Return full SSID name

This returns everything after the heading instead of the second word on the line.

Hi @Japh could you please merge the small PR? I tested it and it's safe to apply.


Provide a good way to have singleton views and windows

A lot of class have UI classes that are for a special screen. These might as well be singletons.

Consider singletons through UIBehaviour instead of views and windows. Should provide much more value.

Duplicate of #31


conda-forge CDN cloning last updated ~869mins ago

Looks like we are running into an issue with CDN cloning for the conda-forge channel
According to the conda-forge.org/status page, it has been ~869mins since that last update (screenshot below):

xref: https://github.com/conda-forge/status/issues/176

A recent example of this is libtorch. The oldest package here was uploaded ~4hrs ago and still has a download count of 0

Another example is pyarrow-core / pyarrow-all which saw their first builds a few hours ago.

The conda-forge status page is now showing the CDN as having synced recently

Do see some improvements with libtorch, but still a lot of packages are being missed

IOW this is still a live issue, but it does seem like the CDN is trying to do something

All the pyarrow-core packages have now made it through the CDN.

Yes, this was a temporary problem that @dholth has fixed within the cloning system.

Thanks Jannis! 🙏
Do we know what the cause was?

We are working on a permanent fix that does not fill the disk.
When the clone process is working, it takes about 8-12 minutes per iteration. There may be delays in other parts of the process like anaconda.org or the CDN. Do we have a way to measure the time that individual packages take to clone?

Thanks Daniel! 🙏
Ok gotcha. So this is the disk overfilling issue we have seen before. Good to know it's a familiar issue
I don't think we have measurements collected external to Anaconda. Though I would be happy to be wrong. @wolfv or @beckermr is this something either of you have looked at before? No worries if not
Is this measured on the Anaconda side somehow?


indexer: pipeline download, checkpoint commit and epoch commit

Description
Pipeline Indexer by adding 2 pairs of Sender & Receiver

checkpoint sender & receiver
epoch sender & receiver

Test Plan

local run indexer
CI

realized that after splitting this into steps, each step needs to retry. otherwise checkpoints / epochs can be discarded

error: could not compile sui-framework due to previous error
error: failed to compile sui v0.29.1 (https://github.com/MystenLabs/sui.git?branch=devnet#d6ebeaa3), intermediate artifacts can be found at /var/folders/0n/qf6zhxcj13v72vysfy40tbzw0000gn/T/cargo-installR8xmCG


Flutter in Docker - cannot seem to work

Hello,
I have an issue regarding Flutter in Docker. I cannot seem to be able to access

flutter

I tried putting flutter into regular directory, under /usr. Issues still there.
Here is my Dockerfile

FROM ubuntu:18.04
ARG PROJECT_DIR=/srv/api
RUN mkdir -p $PROJECT_DIR
WORKDIR $PROJECT_DIR
RUN apt-get -y upgrade
RUN apt-get update
RUN apt-get install -y xz-utils
RUN apt-get install -y curl
RUN curl https://storage.googleapis.com/flutter_infra/releases/stable/linux/flutter_linux_v1.7.8+hotfix.4-stable.tar.xz -o /flutter.tar.xz
RUN tar xf /flutter.tar.xz
#RUN mv flutter /srv/api/flutter
RUN ls /srv/api/flutter
RUN chmod a+x /srv/api/flutter
RUN flutter doctor
RUN flutter upgrade
RUN flutter packages pub global activate webdev
RUN flutter packages upgrade
COPY ./ ./

It fails at RUN flutter doctor.
If I put in path /srv/api/flutter I receive error flutter: not found.
If I put in path /usr/local/bin/flutter I receive error flutter: Permission Denied..
What do I do wrong here?

Flutter binaries are in the bin subdirectory; see https://flutter.dev/docs/get-started/install/linux for instructions on correctly configuring your path to use Flutter.

Flutter binaries are in the bin subdirectory; see https://flutter.dev/docs/get-started/install/linux for instructions on correctly configuring your path to use Flutter.

Thank you for reply, Stuart. I was following this tutorial and I was not able to make it work. However, I just got help from StackOverflow. Guys helped me to fix this. Full solution is here. https://stackoverflow.com/questions/57747795/cannot-get-flutter-running-in-docker/57747991?noredirect=1#comment101934344_57747991


objection: init at 1.11.0-unstable-2024-09-13

Runtime mobile exploration toolkit, powered by Frida.
https://github.com/sensepost/objection
Related to #81418
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 347930 run on x86_64-linux 1

2 packages built:

objection
objection.dist

@FliegendeWurst I have made some changes, I have included the build-tools path in the package as it was necessary to include zipalign. I have tested it and there should be no more problems when signing or patching apks. I have a doubt if it is the best option to specify directly the version of the android build-tools in the package itself or if there is another better option. Another thing to mention, is that now when using android build-tools it is necessary to accept the license either through nixpkgs configuration or through environment variables:
       You must accept the following licenses:
         - android-sdk-license

       a)
         by setting nixpkgs config option 'android_sdk.accept_license = true;'.
       b)
         by an environment variable for a single invocation of the nix tools.
           $ export NIXPKGS_ACCEPT_ANDROID_SDK_LICENSE=1

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 347930

x86_64-linux

:white_check_mark: 2 packages built:

objection
objection.dist


Add authentication credentials to request headers when client is launed

Related to the optional authentication layer in this PR of the oteapi-services, it would be benfitical that a user authenticates while the client is launed.
This could directly make use of the fastapi.security-package so that the token/credentials are automatically added to the request headers when the get-method of a stragety is called in a pipeline.
Suggestions for implementations will follow up soon.

Could this not be done with the config pathway of setting headers in an OTE Service client as of now? Or are you thinking of something more specialized/pre-configured options?
For the config pathway, I mean something like:
from otelib import OTEClient

auth_client = OTEClient("https://api.ote-service.app", headers={"Authorization": "Bearer <token>"})


Text node sometimes duplicated (after initial render) if its preceded by an empty node in IE9-11

This issue seems to have been introduced since 7.0.1. I guess this may be what is causing the tests to fail on Saucelabs (although I can't figure out what test it is from that output).
Example: http://jsfiddle.net/28ckgyzj/13/

@rmales Yes, good catch. We are investigating this behavior.

Ahh perfect, now we have an issue to track it under. Thanks 👍

If it helps at all reinstating the instanceof clause removed from this conditional seem to fix the bug (although I don't know if that affects the aim of the rest of the commit):
https://github.com/developit/preact/commit/c5553cefd67c4dc2ad262df2cfcb986114ef15a9#diff-a0896fa5d65b1d80ca4d496badbae50fL149

Ahh - awesome!

It's possible this is a Text node normalization issue in IE.  I have a potential fix for that, will test it out ASAP.

OK, Windows test setup working fine with preact. The problem seems to be related to __preactattr_ not always being correctly set in Text nodes on IE. Then it ends up using insertBefore creating the duplicated nodes because the node reference check doesn't match. Couldn't figure out where is the origin of this behavior yet. Guess I need to get familiar with the codebase :)

Hmm.  I wonder if Text nodes can't accept properties in IE?

I seem to have found the fix. For some reason this bit was removed:

Humm, so in this patch you never reach the part of the code I was talking about. Seems fixed. Can you upload it to another branch so I can play with it in my local env?

yup!

Alright, it's up as bug/ie

I could be missing something, but having done a (quick) test that change doesn't seem to fix the issue in my example case (in IE11).

@rmales how did you test the change?

@developit Manually in IE11 on Browserstack using my example code with a local version of Preact compiled (with npm run transpile:main) from your 'bug/ie' branch.

can you try running with npm run build?

@developit I think @rmales is right. The fix works to stop IE from throwing the nodeValue error, but the duplicated TextNode still appears and some unmount related tests still fail in IE11.
1 test was greened, but we still have some tests failing. All tests green on your env? (IE9?)
I can upload some screenshots from the karma reporter here if you want.

@developit Using npm run build doesn't seem to make a difference.
This is the output of failed tests I get from running the tests on Browserstack IE11 if that helps at all (although I'm not sure I have it configured correctly):
https://gist.github.com/rmales/cccaf39971757250b9ef2828412bd66d
I'm not sure if the tests actually hit the specific case in my example (and I haven't been able to figure out how to write an equivalent test). Weirdly if I toggle memory profiling on and off in the IE dev tools the (currently rendering) text node is duplicated again.

Yes, I can confirm the duplicated text node. It seems flakey. Sometimes I get the expected behavior when debugging too. Something going on in the event loop?

Ahhh! These are the few tests marked as "flakey"! The tests themselves were bailing in IE, but I couldn't reproduce the underlying issues, so I have them bypassed on SauceLabs (FLAKEY=false npm test).  I think it's time to tackle them and get rid of that flag :)

Random morning thought: maybe it's TextNode normalization kicking in?

@developit Text node normalisation sounds plausible, although I don't understand why it should be (periodically) occurring. Fiddling about, it seems like if you keep a reference to the text node the problem doesn't occur (in IE11).
Also, I guess https://github.com/developit/preact-portal/issues/2 may be the same bug.

Ooooh good catch, yeah that looks like really similar symptoms.

@developit From my quick test it doesn't seems like a circular reference helps. I was literally just keeping a global array of text nodes from the idiff function as a test.

Another thing I'd wondered:  maybe "filling" empty TextNodes with an zero-length space '\u200b' would work?

In my tests the circular reference on dom[ATTR_KEY] = dom doesn't work.
It's probably working in @rmales' tests because keeping the reference with ATTR_KEY already set to true works.
The problem is that IE doesn't set custom properties in TextNodes reliably when appending them to the DOM, sometimes it reaches #L204 with props undefined because child[ATTR_KEY] === undefined.
It seems like a bug in IE we'll have to workaround.
I wonder if we explicitly need the ATTR_KEY in TextNodes, if we don't need it we can just go back to 6.4.0 behavior.
Test this forked bug/ie branch with the changes (bringing back some 6.4.0 code).

Hmm - probably can't go back to 6.x behavior, that would break SSR again. We might be able to special-case TextNodes and have them always be included in child diffing, rather than using ATTR_KEY to flag them as being rendered by Preact.  This was what I had originally done in the 7.0.x betas I think.

I believe there are, have to check. Easiest simulation is to set scratch.innerHTML=renderToString(<Foo />) and then attempt to diff against it.

@developit are the bugs with IE 11 fixed? The tests seem to pass.
I wonder if you have plan to release a new version with these fixes then :)

Yes! I've been going back and forth on whether it'd be acceptable to publish the current changes from master as a 7.2 release while we're still nailing down the 8.0 breaking set of changes. I'd raised the question in the Preact Slack and people seemed inclined towards that approach.

@developit Do you have a timeline for a 7.2 release?

I'll put up a beta right now.

Released as 7.2.0 (beta).

Is this still an issue? I think it was fixed in 7.2, which is now out of beta.

@developit I think its fixed, thanks.

<3

Unfortunately, it still happens for me when using preact-portal (see issue #2). Not sure where the blame falls, though.

I think we need to render a comment node for empty component roots, there's a PR open for it that is just missing a couple edge cases.


Proxy release 2024-05-08

Proxy release 2024-05-08
Please merge this Pull Request using 'Create a merge commit' button

Reviewed for changelog.


Split up deconstructing message with actually sending one

Ideally it'd be great if each client knew how to deconstruct a message and could simply pass it to other clients that actually know how to send it. Instead of having a pointer to each live client, they have a handler function they pass the message to which redirects to the various places that things could be sent to.

Done in dc69a7f56126d70d9e37a54ea224e6f65bbfcc99


Missing autocomplete for TypeScript

VSCode Version: 1.14.1 (1.14.1)
OS Version: macOS 10.12.5 (16F2104)

When editing *.ts files, code autocomplete misses many hints like datatypes, const, let, etc.
Steps to Reproduce:

In a TypeScript file, type some code.
like below:

There should be const instead of ctor(constructor)

No hint for boolean, or number, or string.
In 1.13, everything is fine.
Plus, when I refer to developer tools, there are errors:

[Extension Host] Activating extension vscode.typescript failed:  [vscode.typescript]: Proposed API is only available when running out of dev or with the following command line switch: --enable-proposed-api vscode.typescript
h.logExtensionHostMessage @ extensionHost.ts:320

Reproduces without extensions: Yes

Duplicate of #30716


class Neuron does not convert soma from morphio-> neurom

If I do the following:
from neurom import Neuron
from neurom import viewer
import morphio.mut

neuron = morphio.mut.Morphology('my_neuron.h5')
neuron_nm = Neuron(neuron)
viewer.draw(neuron_nm)

I get:
File "/home/arnaudon/codes/NeuroM/neurom/view/view.py", line 146, in plot_soma
    ax.add_artist(Circle(soma.center[[plane0, plane1]], soma.radius,
AttributeError: 'morphio._morphio.mut.Morphology' object has no attribute 'center'

get functions don't work either:
  File "/home/arnaudon/codes/NeuroM/neurom/features/__init__.py", line 148, in get
    return _np.array(list(feature(obj, **kwargs)))
  File "/home/arnaudon/codes/NeuroM/neurom/features/neuritefunc.py", line 90, in total_area_per_neurite
    return [neurite.area for neurite in iter_neurites(neurites, filt=is_type(neurite_type))]
  File "/home/arnaudon/codes/NeuroM/neurom/core/_neuron.py", line 89, in iter_neurites
    neurite_iter = iter(neurites) if filt is None else filter(filt, neurites)
TypeError: 'NoneType' object is not iterable

Everything works fine for me.
I have tried with the following snippet
    from neurom import viewer
    import matplotlib.pyplot as plt
    from neurom import get

    filename = os.path.join(SWC_PATH, 'simple.swc')

    neuron = Neuron(Morphology(filename))
    viewer.draw(neuron)
    length = get('total_length_per_neurite', neuron)
    print("length: {}".format(length))
    plt.show()

Only difference is I have .h5, did you use mut.Morphology? I have NeuroM 1.4.20.

Ahhh. No, all morphio related features only work with the mut_morphio branch.

Ok, my bad.


API Conventions & Analyzers should always be on

Talked to @pranavkm  and @glennc about this. The work here is to make sure as soon as you reference a package (NSwag, Swashbuckle) which produces swagger documents, the analyzer is automatically enabled.

As of now - the work to put the Analyzer into WebSDK is already done. So the only work pending here is to submit PRs to the partners to add the flag so referencing these packages automatically enables API analyzer. That work is tracked as part of: https://github.com/aspnet/AspNetCore/issues/8418


How to set PDF to render A4

Hi
I'd love to use your pdf-plugin but it renders a different aspect ratio than A4, probably 'Letter'. How can we change this ratio in the output?

Hi,
plugin renders A4 format by default.
Check this topic how you can change it: https://github.com/mplodowski/DynamicPDF/issues/31


Make each section collapsible to make navigation easier

I'm adding this as an issue so that there is a discussion.
As of now, the list is quite long and while it is quite organized, it can be hard to navigate.  the Index, all main titles, and even some subsections (e.g. basic, advanced for backend) could be made collapsible to facilitate that.
If you believe this is a good idea, I can go make the PR :)

That's so dope Maryam jan. I highly believe that it used to be collapsible but after some PRs, it's been removed for some reason. As it grows, it becomes harder to follow. Totally agree with that. Feel free to add this feature. Much appreciate your love btw. <3 :)

Hi, I believe this issue has not been fully solved.
We can make each section collapsible, I believe what @reganto really meant was something like this
Can I work on this ?

@bobycloud :)

Any updates @lnxpy ?

Hello, thanks for your suggestion @SepehrRasouli and @evakdev. I'm not sure if it's useful or not because it reduces scrolling but also hides many things from the eyes at first glance. What do you think, @lnxpy and @smoeinbbp?

@evakdev maybe it's better to create a PR first and take a look at it and after that we can take a better decision.

#146

@bobycloud @smoeinbbp I guess we should close this issue as not planned yet maybe. Adding this capability would cause the README.md file to have a very complex nested HTML-integrated structure which is not a good practice for the new contributors. You make the move.
– Btw, thank you @ManiMozaffar for working on this PR and making your implementation. :)


Cannot create MUD project from PNPM

Hi all, I am new to this framework. But I am running into an error when running:
pnpm create mud my-mud-project

The following is the error (starting from the section of the minimal template, everything is running smoothly before this):
? Template minimal

Creating a new package in /Users/adrianli/dev/my-mud-project.

Initializing a git repository
> git init

Installing dependencies using pnpm
> pnpm install --dir /Users/adrianli/dev/my-mud-project
 WARN  The "workspaces" field in package.json is not supported by pnpm. Create a "pnpm-workspace.yaml" file instead.
Packages: +4
++++
Packages are hard linked from the content-addressable store to the virtual store.
  Content-addressable store is at: /Users/adrianli/Library/pnpm/store/v3
  Virtual store is at:             node_modules/.pnpm
<EMAIL_ADDRESS>Running install<EMAIL_ADDRESS>Running install script, failed in 85msed 4, reused 3, downloaded 0, added 0
.../node_modules/node-pty install$ node scripts/install.js
│ node:internal/child_process:420
│     throw errnoException(err, 'spawn');
│     ^
│ Error: spawn ENOTDIR
│     at ChildProcess.spawn (node:internal/child_process:420:11)
│     at spawn (node:child_process:757:9)
│     at Object.<anonymous> (/Users/adrianli/dev/my-mud-project/node_modules/.
│     at Module._compile (node:internal/modules/cjs/loader:1267:14)
│     at Module._extensions..js (node:internal/modules/cjs/loader:1321:10)
│     at Module.load (node:internal/modules/cjs/loader:1125:32)
│     at Module._load (node:internal/modules/cjs/loader:965:12)
│     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/ru
│     at node:internal/main/run_main_module:23:47 {
│   errno: -20,
│   code: 'ENOTDIR',
│   syscall: 'spawn'
│ }
│ Node.js v20.1.0
└─ Failed in 85ms at<EMAIL_ADDRESS> ELIFECYCLE  Command failed with exit code 1.
Progress: resolved 4, reused 4, downloaded 0, added 4, done
Failed to install dependencies: 1

Node version: v20.1.0
NPM Version: 9.6.4
PNPM version: 8.2.0

Our templates aren't yet up to date with pnpm and still use yarn. Mind trying yarn create mud ... instead?

I tried npx mud create my-mud-project and it worked. Yarn gave me an error, but it might have been a network issue:
➜  dev yarn create mud
yarn create v1.22.5
[1/4] 🔍  Resolving packages...
error An unexpected error occurred: "https://registry.npmjs.org/create-mud: Socket connection timeout".
info If you think this is a bug, please open a bug report with the information provided in "/Users/adrianli/.config/yarn/global/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/create for documentation about this command.

Thanks. I'd suggest updating the README for now.


引入bootstrap的时候报错

It's seems like bootstrap can't  distinguish $btn-line-height
 node_modules/bootstrap/scss/_buttons.scss
Error: Undefined variable: "$btn-line-height".
        on line 10 of node_modules/bootstrap/scss/_buttons.scss
>>   line-height: $btn-line-height;

just forget to install gulp-sass


Added code for reversing number without using string in Java

@ephremdeme Added my code for reversing number. Please review it.

Already implemented


feat: Updating the count with PromoCode

For gamification, updating the count of document uploads through the form with PromoCode. PromoCodes will be kept in lowercase and auto conversion can be applied.
** discord username: @MustafaBolat#4560 **

Closing, will re-open once we are done with p0 stuff.


Change copyright year to current year - to fix #67

A simple change to fix #67

Nobody really agrees on what copyright here should be (initial creation? current date? etc.). I'm using creation here.

@delroth I don't really care, but generally copyright dates should be a range to most useful.
For example 2014-2018 would be what I would expect if the site was created in 2014 and maintained until the current year of 2018. If any years had no changes like say 2015 it could be represented like, 2014, 2016-2018. This is how its generally done with software and package management at least.

Yes but they don't have to be useful, they provide no value, and frankly I should just remove this copyright header altogether because other than generating noise I'm not sure what it's doing.

+1 for removing the date or the whole copyright notice.


Update Help for Coords to reflect presence of The Handbook and other needed changes

Have made some changes, ready for review.  Unable to link to the Handbook (links needed both in the links near the top, and in the final section).

Have made some changes, ready for review.  Unable to link to the Handbook (links needed both in the links near the top, and in the final section).

@AlOneill to see if she can figure out what Pat is doing wrong in linking to the Handbook page

@AlOneill to see if she can figure out what Pat is doing wrong in linking to the Handbook page

@PatReynolds The DRAFT page is a copy of 'Information for Transcribers' rather than for Coords (see lead para, for instance). What would you like to do about this?
The Handbook page is not listed when using the 'Insert Link' button (I do not know why not), so the link will need to be inserted manually (in the HTML pane).

@PatReynolds The DRAFT page is a copy of 'Information for Transcribers' rather than for Coords (see lead para, for instance). What would you like to do about this?
The Handbook page is not listed when using the 'Insert Link' button (I do not know why not), so the link will need to be inserted manually (in the HTML pane).

@PatReynolds to look at the new version of 'abridged' on the Coords mailing list

@PatReynolds
Did you mean test 2 or test 3? I was not able to log in on test 2 but found this page on test 3:
https://test3.freecen.org.uk/cms/information-for-coordinators/draft-information-for-coordinators
The image link shown below points at the FreeCEN home page — is this what was intended? The markup is altogether a little strange, so please have another look.

@PatReynolds
There is no point in reviewing for accessibility until the content is signed off. My comment above was just something that jumped out at me while trying to find the correct page :-)

Pat
If I looked at this as a new person I would be baffled.
How about – ‘We use two reference files in our work, the PARMS file and the Gazetteer.’ Then your text follows.
Geoff
From: PatReynolds @.>
Sent: Thursday, April 7, 2022 2:32 AM
To: FreeUKGen/FreeCENMigration @.>
Cc: geoffj-FUG @.>; Mention @.>
Subject: Re: [FreeUKGen/FreeCENMigration] Update Help for Coords to reflect presence of The Handbook and other needed changes (#1054)
Version in Test2 (DRAFT Help for Coordinators) now ready for proofing. Could you take a look @geoffj-FUG https://github.com/geoffj-FUG  for content and @AlOneill https://github.com/AlOneill  for accessibility
—
Reply to this email directly, view it on GitHub https://github.com/FreeUKGen/FreeCENMigration/issues/1054#issuecomment-1090469866 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKCPIFLFPFAPOWEH4R3BE3LVDW37FANCNFSM4UR3MYXA .
You are receiving this because you were mentioned.Message ID: @.***>

Have replaced my intro sentence with yours.

I don't see any image like tha, Alison.
there is an image missing (called a table here), but I need Geoff's sign off to get it drawn by someone who can draw (and can add that to a later version, I think it helps understanding rather than being essential).
There is a link missing in Enquiries from New Volunteers(  to "Enquiries from potential new volunteers"  that needs to be added (I think this may be the Abbreviated Handbook - so won't be available to potential new volunteers as they won't have access to it.  Do we tell Coords to download and send to potential new volunteers?

Pat
The missing link is I think to the Introduction for new transcribers.
I have access to test3 but have never used test2.
I have just tried to sign in but do not have permissions. Denise, can you set me up please?
Geoff
From: PatReynolds @.>
Sent: Thursday, April 7, 2022 8:08 PM
To: FreeUKGen/FreeCENMigration @.>
Cc: geoffj-FUG @.>; Mention @.>
Subject: Re: [FreeUKGen/FreeCENMigration] Update Help for Coords to reflect presence of The Handbook and other needed changes (#1054)
I don't see any image like tha, Alison.
there is an image missing (called a table here), but I need Geoff's sign off to get it drawn by someone who can draw (and can add that to a later version, I think it helps understanding rather than being essential).
There is a link missing in Enquiries from New Volunteers( to "Enquiries from potential new volunteers" that needs to be added (I think this may be the Abbreviated Handbook - so won't be available to potential new volunteers as they won't have access to it. Do we tell Coords to download and send to potential new volunteers?
—
Reply to this email directly, view it on GitHub https://github.com/FreeUKGen/FreeCENMigration/issues/1054#issuecomment-1091482296 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKCPIFODEGMGUEEGHO6MYNLVD2XXXANCNFSM4UR3MYXA .
You are receiving this because you were mentioned.Message ID: @.***>

Hello Geoff,
The page for checking is on test3. Only developers use test2 - it is essentially there to make sure that a new piece of Ruby code plays nicely with the existing code, and functions properly - if it does, the developer moves it to test 3 for wider review.
The html pages only exist on test 3 (and then are copied to live irregularly, when there is something to publish.
With the new version of the handbook, is there any other updating needed?  There are also some areas highlighted by the documentation team which I can address - unless you want to.
If you are signed in to test 3 this page link should work: https://test3.freecen.org.uk/cms/information-for-coordinators/draft-information-for-coordinators

@PatReynolds
While tidying up the page, I noted a missing link:
"Enquiries from volunteers will start to come directly to you from FreeCEN2.  A short Introduction booklet LINK HERE is available to assist you to get new Transcribers started."
What is the short introduction referred to here? The Abbreviated Handbook seems unlikely as it could not be described as short! I am stumped.

@PatReynolds page tidied and some typos fixed. Only the missing link to resolve.

@PatReynolds DRAFT page promoted and sync-ready.

Pat
(Denise, Found it on test3 so don’t need access to test2. Geoff)
Typo as follows: be ualso pdated
I am wondering why some of this is going online. I know it was there on FC1 but we now have the Handbooks. FC1 had very rudimentary guidelines.
I am updating the handbooks. The Abbreviated Handbook will become Transcribers and Proofreaders Handbook next issue. The Full Handbook will become that plus two or three supplements.
The Validators Supplement will be issued in about a week. I am just waiting on Story #1384 as it is written for after that story is completed.
Then there will be a Coordinator’s supplement.
It means that the Supplements will not contain the info in the Transcribers Handbook such as the field descriptions.
The nett result is that there will only ever be one version of anything published. At the moment we have redundancy as there is a Transcribers version and a Full version which contain the same info. If they get out of synch there will be confusion about instructions. So I am going for a do it only once model.
Some of the Info in this text is a duplicate of what is in the Handbook. Are we building in redundancy?
Geoff
From: PatReynolds @.>
Sent: Thursday, April 7, 2022 8:08 PM
To: FreeUKGen/FreeCENMigration @.>
Cc: geoffj-FUG @.>; Mention @.>
Subject: Re: [FreeUKGen/FreeCENMigration] Update Help for Coords to reflect presence of The Handbook and other needed changes (#1054)
I don't see any image like tha, Alison.
there is an image missing (called a table here), but I need Geoff's sign off to get it drawn by someone who can draw (and can add that to a later version, I think it helps understanding rather than being essential).
There is a link missing in Enquiries from New Volunteers( to "Enquiries from potential new volunteers" that needs to be added (I think this may be the Abbreviated Handbook - so won't be available to potential new volunteers as they won't have access to it. Do we tell Coords to download and send to potential new volunteers?
—
Reply to this email directly,  https://github.com/FreeUKGen/FreeCENMigration/issues/1054#issuecomment-1091482296 view it on GitHub, or  https://github.com/notifications/unsubscribe-auth/AKCPIFODEGMGUEEGHO6MYNLVD2XXXANCNFSM4UR3MYXA unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


i18n(ko-KR): update overrides.md

Description

update overrides.md
#1842

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

ko
reference/overrides.md
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Added connection type to terminal header, aligned all page items

Added connection type to terminal header, aligned all page items, moved hint text to bottom of screen for all pages.

History columns should have two spaces between columns. Currently seeing only one.
Rather then having an input field for spending passphrase, is there a popup dialog that can be used?

History columns should have two spaces between columns. Currently seeing only one.
Rather then having an input field for spending passphrase, is there a popup dialog that can be used?

Noted the instructions and i will get to work on them in a separate PR or even separate PRs


[jvm-packages][bug-fix] Predict in XGBoostModel to handle mapPartitions correctly.

Currently, the predict returns RDD[Array[Array[Float]]] where in the elements in RDD equates to the number of partitions rather than the original number of elements in testRDD - RDD[Vector].
This patch would fix the bug and return RDD[Array[Float]], where the number of elements in the testRDD and the return RDD would match. Test cases have been updated appropriately.

close stale PR


changed cf cli to use a per agent config.

this PR will fix issues #32

@madhurig eta on a review?

@mozts2005 - I am not maintaining this repo now, adding @leantk

@leantk Any ETA?

@lkillgore is going to take a look


Wip/altran/default shortcuts

Add default shortcuts to existing actions and add some new actions (close tab, switch next/prev tab) with default shortcuts.

Could you also bind:

Ctrl+G to "jump to address"
More shortcuts to 3d view (e.g. switching between visualization modes)


No Prerequisites section

Hello Team,
Shouldn't this documentation consist of a 'Prerequisites' section mentioning the permissions needed to delete a project?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5a614791-0c5d-4373-3194-11695e40e1d1
Version Independent ID: 737e5a3b-d7be-9d36-7b5a-638976406d74
Content: Delete, remove project - Azure DevOps
Content Source: docs/organizations/projects/delete-project.md
Product: devops
Technology: devops-accounts
GitHub Login: @chcomley
Microsoft Alias: chcomley

Hi @Kasikka-MS, Thanks for your feedback, you're absolutely right! I've created a user story to address this on my backlog. Thanks again.


Property hooks

Added post-write hooks to the protocol property implementation.
This allows hooking in updates for derived parameters. For example, when writing to the encoder bandwidth parameters, it can update the encoder gains.

Yep I checked the change in size of .bss section and checked the remaining stack size, both were acceptable IMO.
Thanks for reviewing this, I'll address the input_length based determination of written value.


[OAS3] Schemas with external references fail to resolve properly

swagger-parser version: io.swagger.parser.v3:swagger-parser-v3:2.0.3-SNAPSHOT latest from Maven Central.

Code snippet used to load OpenAPI definition:
OpenAPI oai = new OpenAPIV3Parser().read("/path/to/index.yaml");

The attached tarball is a minimal sample which exhibits the issue:

index.yaml uses external $refs to refer to a response, (components/response-with-reference.yaml)
this in turn refers to a schema (components/schema-with-reference.yaml)
this in turn refers to another schema to define the type of items in an array (components/referent.yaml)

On running the code and examining the toString() output of the OpenAPI object obtained (see attached), the $ref for items becomes ./components/components/referent.yaml, which is incorrect. This appears to be due to the invocation of constructRef in ExternalRefProcessor#processRefSchema.
Attempting to run openapi-generator-cli with this definition results in the error
java.lang.RuntimeException: Could not find ./components/components/referent.yaml on the classpath
...
[main] WARN  io.swagger.v3.parser.OpenAPIV3Parser - Exception while reading:
java.lang.RuntimeException: Unable to load RELATIVE ref: ./components/components/referent.yaml

Finally, we would like to understand which path is used to process relative references, is it the root location (the location containing the index.yaml), or is it the location containing the current document?

The swagger.io documentation states that "Remote Reference...Uses the whole document located on the same server and in the same location". The phrase "same location" is a little unclear here but my interpretation is that it refers to the "current" file, eg the one containing the $ref.
The OpenAPI 3 Spec states that "Relative references used in $ref are processed...using the URL of the current document as the base URI".

If the spec means that the current document should be used as the base URI, then why does the $ref in components/response-with-reference.yaml have to be ./components/schema-with-reference.yaml? Surely it should just be schema-with-reference.yaml since components is already on the "current path"?
You can surely see that there is an inconsistency between the way the reference is made from response-with-reference.yaml and schema-with-reference.yaml, in that to currently get generation to work, one has to contain components and the other not.
oapi-reference-test.tar.zip
parser-output.txt

@webron that makes perfect sense to me but that doesn't seem to be happening in practice.
If you look at the attached tar you will see that response-with-reference.yaml has the contents:
---
description: Response with schema containing reference
content:
  application/json:
    schema:
      $ref: "./components/schema-with-reference.yaml"

This correctly resolves ./components/schema-with-reference.yaml despite the fact that response-with-reference.yaml is also in the components directory. If your assertion were correct then the $ref line should be
      $ref: "./schema-with-reference.yaml"

but this fails.

@tomblench Aha, thanks for the clarification, we'll look into it.

$ref: "./schema-with-reference.yaml"

This fails, not because parser can't resolve the response with reference file, but because it's trying to solve the schema inside the response with the parent Directory of the index file.
Parser looks for ./schema-with-reference.yaml but not inside the components folder but outside in the main folder. Parser solves the schema inside the response in the middle of the resolving the ref response it self, so it takes the parent directory of index, instead of the one provided in the $ref.
meaning he looks for ./schema-with-reference.yaml in oapi-reference-test folder.
+ oapi-reference-test
   index.yaml
   + components
     - response-with-reference.yaml
     - schema-with-reference.yaml
     - referent.yaml

@gracekarina I am still confused:

Both JSON Schema and OpenAPI state that $refs are processed according to JSON Reference
JSON reference states that "Resolution is performed relative to the referring document"

but

When I make a reference from a schema in components to another schema in components, I do not need to give components as the leading part of the relative reference
When I make a reference from anything else (in my case, from a response) in components to anything else (in my case a schema) in components, I do need to give components as the leading part of the relative reference.

Furthermore, if all OpenAPI references (leaving schema→schema references aside for one moment) are resolved relative to the root, then I think the spec is incorrect where it states "Relative references used in $ref are processed as per JSON Reference, using the URL of the current document as the base URI. See also the Reference Object"

Hi, I did a little testing and came up with this result: Would this be the expected result?
openapi: 3.0.0
info:
  title: Test
  license:
    name: Test
    url: http://test.com/test
  version: 0.0.1
externalDocs:
  description: Test
  url: http://test.com/test
servers:
- url: http://test.com/test
paths:
  /:
    get:
      summary: Test
      description: Test
      operationId: getTest
      responses:
        200:
          description: Response with schema containing reference
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/schema-with-reference'
components:
  schemas:
    referent:
      type: object
    schema-with-reference:
      type: object
      properties:
        reference_array:
          type: array
          items:
            $ref: '#/components/schemas/referent'
  responses:
    response-with-reference:
      description: Response with schema containing reference
      content:
        application/json:
          schema:
            $ref: '#/components/schemas/schema-with-reference'

Yeah that looks about right, assuming that copying response-with-reference inline to responses/200 is the "right" thing to do.

hi @tomblench  please check the new parser's release. If this issue persists let us know throw a new issue. Thanks!

@gracekarina (sorry for commenting on a closed ticket - something I wouldn't normally do)
Thanks for the quick response and fix, unfortunately we have a related with our schema in #834

Hi, Can somebody help me get this.
is there a way to validate a json request or response file against a given OpenApi json file.
I am trying to see if i can use OpenAPIV3Parser to do this ?

@sivagithub2019 can you please add a new issue, and please add an example so we can discuss, this is a closed issue, so It will be hard to follow in here. thanks!

HiI have create this new issue
need to write a java code for validating a json response against a OpenApi json schema · Issue #1126 · swagger-api/swagger-parser
|
|
|
|  |  |
|
|
|
|  |
need to write a java code for validating a json response against a OpenA...
need to write a java code for validating a json response against a OpenApi json schema. For example the petstore...
|
|
|
your help is much appreciated in this. thanks.
On Friday, June 14, 2019, 06:30:48 PM GMT+1, Grace Karina Gonzalez Diaz<EMAIL_ADDRESS>wrote:
@sivagithub2019 can you please add a new issue, and please add an example so we can discuss, this is a closed issue, so It will be hard to follow in here. thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Comparisons between scipy spmatrix and can sparse.SparseArray return scalar bool

This issue is about interop with scipy sparse and pydata sparse. scipy.sparse doesn't let pydata/sparse overload __eq__ according to https://github.com/pydata/sparse/issues/305#issuecomment-560317183 (I'm still a little fuzzy on when __array_priority__ and __array_ufunc__ get used). This ends up returning a scalar for != or ==.
Reproducing code example:
In [1]: import sparse
sra
In [2]: import scipy

In [3]: scipy.__version__
Out[3]: '1.5.0.dev0+5958e9f'

In [4]: coo = sparse.random((10, 10))

In [5]: csr = coo.tocsr()

In [6]: csr == coo
Out[6]: False

I'd expected this to broadcast and not be False, especially since interop seems to be a goal (#10901).

If someone can tell me where scipy.sparse.spmatrix.__eq__ and so on are defined, I can try to make this change.

I don't remember outright where it is, but I guess grep should point you to about the right place. The spmatrix comparisons are probably quite old code, and might not follow sane convention.
On December 2, 2019 10:21:24 AM UTC, Hameer Abbasi<EMAIL_ADDRESS>wrote:

If someone can tell me where scipy.sparse.spmatrix.__eq__ and so on
are defined, I can try to make this change.

It looks like it's effectively under `sparse/compressed.py
https://github.com/scipy/scipy/blob/2ba80dc11ffe931495ec054070e601ae3d8edd03/scipy/sparse/base.py#L369-L373
https://github.com/scipy/scipy/blob/2ba80dc11ffe931495ec054070e601ae3d8edd03/scipy/sparse/compressed.py#L217

Looks like it's specialized to each format, which isn't surprising. I'll try to figure this out, but I might not get to it too soon.

I think I've got something working. It's not particularly elegant though.


tdComp is blank when data is passed at the time of mount

Hi,
I am using a components actions to display buttons in a column of the datatable. When I am passing data through an ajax call(which makes it wait for sometime before updating) everything works fine, but
as soon as I am passing it directly into the data it shows blank.
Shows blank when passed like this:

but works fine when i put a setTimeout of say 1 sec before sending/updating the data

Didn't workout. Actually I have tried importing it both locally and globally after seeing this issue https://github.com/OneWayTech/vue2-datatable/issues/9
but nothing helped till now

would you mind providing an online demo (jsbin etc)? i cant reproduce myself

This might work:
tdComp: require('path/to/DatatableActions').default
or eg.
export default { Foo: require('./td-Foo').defaults }


txn-builder: masternode-create and masternode-resign

What kind of PR is this?:

/kind feature
/kind fix
What this PR does / why we need it:
Add masternode create and resign to txn builder
Update rpc createmn test
Some fixes on createmn transaction
Which issue(s) does this PR fixes?:

Fixes #504

Requesting some changes after eunosPaya,
also refactor the test fixtures, if you need to test the behaviour before eunosPaya, you might need to use another container without eunosPaya flag set.

@surangap
I couldn't reason this as personally i think this is not that necessary unless that has critical i need to fix
first, the txn fixture only be involved in buffer composer and serialization logic, it doesn't really care whether the fixture is correct, eg: putting invalid in the fixture, it will still pass, but for better document wise, we will ensure the fixture is correct, some we pick those from mainnet, if have. I added the default timelock 0000 fixture with desc, i think that is clear enough.
second, the before/after eunospaya logic can still work fine, so if create another old fork container to test the old fork logic, seems like really not necessary, unless this
eg: the before/after params order different, then need another build to test
before { ownerAddr: string, opeAddr: string }
after { ownerAddr: string, timelock?: string, opeAddr?: string }
feel free to advice if i'm miss something

Requesting some changes after eunosPaya,
also refactor the test fixtures, if you need to test the behaviour before eunosPaya, you might need to use another container without eunosPaya flag set.

@surangap
I couldn't reason this as personally i think this is not that necessary unless that has critical i need to fix
first, the txn fixture only be involved in buffer composer and serialization logic, it doesn't really care whether the fixture is correct, eg: putting invalid in the fixture, it will still pass, but for better document wise, we will ensure the fixture is correct, some we pick those from mainnet, if have. I added the default timelock 0000 fixture with desc, i think that is clear enough.
second, the before/after eunospaya logic can still work fine, so if create another old fork container to test the old fork logic, seems like really not necessary, unless this
eg: the before/after params order different, then need another build to test
before { ownerAddr: string, opeAddr: string }
after { ownerAddr: string, timelock?: string, opeAddr?: string }
feel free to advice if i'm miss something

I think you missed the main point from my comments. https://github.com/DeFiCh/jellyfish/pull/534/files#r687649278
For the fixtures, yes you can use anything as long as it accords with the serialization logic. eunosPaya flag is additional information I mentioned, which might not need for this test. ignore that.
let me explain more about the main point, https://github.com/DeFiCh/jellyfish/pull/534/files#r687649278
let's say with the current jellyfish implementation, after eunosPaya, if someone craft a createMasternode tx without a timelock, the serialized scriptPubkey will be 6a 1a 44665478 43 01 b684e2095bcdfb63f1265f35775da23ca8e8aaff. But if you create the the same tx using createmasternode defid RPC, it will give you 6a 1c 44665478 43 01 b684e2095bcdfb63f1265f35775da23ca8e8aaff 0000
notice the difference in length. also refer https://github.com/DeFiCh/ain/blob/d04337ff3e884b4fb240ca65218c2c13d923f2ad/src/masternodes/rpc_masternodes.cpp#L167 for more info.
As i mentioned in my previous comment, 6a 1a 44665478 43 01 b684e2095bcdfb63f1265f35775da23ca8e8aaff might still be parsed by the nodes and populate the timelock as 0000 since it is the default value in c++ side. refer https://github.com/DeFiCh/ain/blob/d04337ff3e884b4fb240ca65218c2c13d923f2ad/src/masternodes/mn_checks.h#L159
But I would prefer to have the same implementation as the c++ side.

Requesting some changes after eunosPaya,
also refactor the test fixtures, if you need to test the behaviour before eunosPaya, you might need to use another container without eunosPaya flag set.

@surangap
I couldn't reason this as personally i think this is not that necessary unless that has critical i need to fix
first, the txn fixture only be involved in buffer composer and serialization logic, it doesn't really care whether the fixture is correct, eg: putting invalid in the fixture, it will still pass, but for better document wise, we will ensure the fixture is correct, some we pick those from mainnet, if have. I added the default timelock 0000 fixture with desc, i think that is clear enough.
second, the before/after eunospaya logic can still work fine, so if create another old fork container to test the old fork logic, seems like really not necessary, unless this
eg: the before/after params order different, then need another build to test
before { ownerAddr: string, opeAddr: string }
after { ownerAddr: string, timelock?: string, opeAddr?: string }
feel free to advice if i'm miss something

I think you missed the main point from my comments. #534 (comment)
For the fixtures, yes you can use anything as long as it accords with the serialization logic. eunosPaya flag is additional information I mentioned, which might not need for this test. ignore that.
let me explain more about the main point, #534 (comment)
let's say with the current jellyfish implementation, after eunosPaya, if someone craft a createMasternode tx without a timelock, the serialized scriptPubkey will be 6a 1a 44665478 43 01 b684e2095bcdfb63f1265f35775da23ca8e8aaff. But if you create the the same tx using createmasternode defid RPC, it will give you 6a 1c 44665478 43 01 b684e2095bcdfb63f1265f35775da23ca8e8aaff 0000
notice the difference in length. also refer https://github.com/DeFiCh/ain/blob/d04337ff3e884b4fb240ca65218c2c13d923f2ad/src/masternodes/rpc_masternodes.cpp#L167 for more info.
As i mentioned in my previous comment, 6a 1a 44665478 43 01 b684e2095bcdfb63f1265f35775da23ca8e8aaff might still be parsed by the nodes and populate the timelock as 0000 since it is the default value in c++ side. refer https://github.com/DeFiCh/ain/blob/d04337ff3e884b4fb240ca65218c2c13d923f2ad/src/masternodes/mn_checks.h#L159
But I would prefer to have the same implementation as the c++ side.

yes i understand the changes before/after the eunospaya....
but i don't quite get the request for the test...
hmm.. can you pseudo how does the changes should be?
it's great if you can straight away contribute the changes

I think by that effect, making timelock a non-optional value where it always defaults to0x0000.
- timelock?: number // -----------------------------| 2 bytes, 0x0401 = 5 years, 0x0802 = 10 years
+ timelock: number // -----------------------------| 2 bytes, 0x0401 = 5 years, 0x0802 = 10 years

I think by that effect, making timelock a non-optional value where it always defaults to0x0000.
- timelock?: number // -----------------------------| 2 bytes, 0x0401 = 5 years, 0x0802 = 10 years
+ timelock: number // -----------------------------| 2 bytes, 0x0401 = 5 years, 0x0802 = 10 years

Quite annoying we can't get backward compatibility..., how do we know which format to use without knowing block height?

I think by that effect, making timelock a non-optional value where it always defaults to0x0000.
- timelock?: number // -----------------------------| 2 bytes, 0x0401 = 5 years, 0x0802 = 10 years
+ timelock: number // -----------------------------| 2 bytes, 0x0401 = 5 years, 0x0802 = 10 years

i see.. is this what @surangap you mean??

@fuxingloh if we make it default to 0000, won't it produce a different OP_RETURN? then the serialization/deserialization won't line up

@fuxingloh if we make it default to 0000, won't it produce a different OP_RETURN? then the serialization/deserialization won't line up

Damn it...

When ain deserializes, it checks for end of stream and omits timelock if it's not there
When it serializes, it checks block height

Perhaps if timelock was optional, then when we deserialize we know that this was a pre Eunos tx, and when we serialize again we omit timelock.

Perhaps if timelock was optional, then when we deserialize we know that this was a pre Eunos Paya tx, and when we serialize again we omit timelock.

I really hope we can omit to carrying the height flag around when parsing DfTx. More and more reasons where that's not the case...
Another e.g. where there just lack of consistency: https://github.com/DeFiCh/jellyfish/pull/556

@fuxingloh if we make it default to 0000, won't it produce a different OP_RETURN? then the serialization/deserialization won't line up

Exactly, thus we may endedup with PreEunosCreateMasterNode and PostEunosCreateMasterNode, upto user (eg whale indexer) to decide what to do.

When ain deserializes, it checks for end of stream and omits timelock if it's not there
When it serializes, it checks block height

This is not exactly correct I think.

when create masternode via RPC it checks for height and write timelock or not when writing tx metadata
But when deserialize, if EOS, then it will be the default value 0 for timelock. even inside defid, it expects pre EunosPaya to have timelock value of 0. refer https://github.com/DeFiCh/ain/blob/d04337ff3e884b4fb240ca65218c2c13d923f2ad/src/masternodes/mn_checks.cpp#L699
need to do another check/test from c++ side for serialized output for pre eunosPaya without timelock. getrawtransaction might be returning from the mempool. need to check otherwise.

understand, even on preEunosPaya, timelock must equal to 0

When ain deserializes, it checks for end of stream and omits timelock if it's not there
When it serializes, it checks block height

This is not exactly correct I think.

when create masternode via RPC it checks for height and write timelock or not when writing tx metadata
But when deserialize, if EOS, then it will be the default value 0 for timelock. even inside defid, it expects pre EunosPaya to have timelock value of 0. refer https://github.com/DeFiCh/ain/blob/d04337ff3e884b4fb240ca65218c2c13d923f2ad/src/masternodes/mn_checks.cpp#L699
need to do another check/test from c++ side for serialized output for pre eunosPaya without timelock. getrawtransaction might be returning from the mempool. need to check otherwise.

pre eunosPaya timelock 0 at decerialization inside defid, can be seen with this PR https://github.com/DeFiCh/ain/pull/679

pre eunosPaya timelock 0 at decerialization inside defid, can be seen with this PR DeFiCh/ain#679

hmm.. which docker image i should refer for this update huh??


Access token logged in server and ts client package

In the Server-Side package and the TS Client-Side package (and possibly other Client-Side packages) the access token gets logged. This is because the token is sent as a query parameter.

Versions of Server-Side NuGet Packages: 1.0.0
Versions of Client-Side NuGet/NPM Packages: 1.0.0
Are you using the C# client or the JavaScript client: JavaScript (TS)

This is because the token is sent as a query parameter.

This isn't going to change in the short term see https://github.com/whatwg/html/issues/3062.

Maybe, as a workaround you could filter out the token in the log call? At least on the client side the logger is directly called from the signalr package, so it might be possible. On the server side it might be a bit harder.

Do you mean that you turned logging on and you want the token to be excluded from those logs? On the SignalR the token is logged by ASP.NET Core infrastructure, not from SignalR.

I didn't turn logging on for SignalR explicitly for both the Server and the TS Client package. Just using the default logging configuration for ASP.NET Core and whatever's the default for the browser.
When I connect the following is logged on the server side:
2018-06-22 19:18:26 [Information] Microsoft.AspNetCore.Hosting.Internal.WebHost Request starting HTTP/1.1 GET http://localhost:5000/Monitor?access_token={access token here}
And in the browser console:
signalr.min.js:16: Information: WebSocket connected to ws://localhost:5000/Monitor?access_token={access token here}
It'd be nice if the token could be excluded from this logs, or be replaced by redacted or something like that.

I didn't turn logging on for SignalR explicitly for both the Server and the TS Client package. Just using the default logging configuration for ASP.NET Core and whatever's the default for the browser.

I'm saying that the layer that logs doesn't know that the query string is an access token so it would be difficult to do any filtering. That would be an entirely new feature to either disable all query strings or letting users disable specific query strings. I'm not sure this is realistic.
For the client, we can redact the access token (we can reuse the flag we have for logging message content).

I'm not sure this is realistic.

Totally understandable. :)
Shall I leave this issue open to see if there's enough interest in this?

Shall I leave this issue open to see if there's enough interest in this?

Which part of the issue?

Not sure actually. Client-side only filtering is probably less important than server side. But that one is a lot more difficult to accomplish.
Any preference? Honestly it sounds to me that it's not realistic enough anyway.

Also, if you are using IIS, it will log the querystring and ASP.NET Core has no way to affect that. Unfortunately right now the only way to avoid this is to strip the token out of the relevant logs yourself. We've talked about doing #1802 to help make this cleaner.

We periodically close 'discussion' issues that have not been updated in a long period of time.
We apologize if this causes any inconvenience. We ask that if you are still encountering an issue, please log a new issue with updated information and we will investigate.


Selenium Grid Not Working

Hi @burakkaygusuz,  Thanks for the awesome projects. I had a quick question:
I followed the set up and tests run in parallel but on selenium console, i don't see the sessions.
Normally we need to start AndroidDriver on grid url but in your case, you start it on localhost:4723
When i change the line on base test to below this
driverThreadLocal.set(new AndroidDriver(new URL("http://localhost:5555"), options));
then test fail with error below
[ERROR]   LoginTest>BaseTest.setUp:33 » SessionNotCreated Could not start a new session. Possible causes are invalid address of the remote server or browser start-up failure.
However, in this case, i see the sessions started on grid url : http://localhost:5555/ui#/sessions
I am on a mac and followed all steps to set up Appium 2.0 and start grid with same toml code you have.
Any idea how to make it work with selenium grid via relay?

@burakkaygusuz Thanks for looking into this. I am also seeing the same error even with the updated docker file.
Please keep me updated if you find solution.
Thanks.

hey @burakkaygusuz Did you get this work? I tried latest changes but still see an error
[ERROR]   LoginTest>BaseTest.setUp:33 » SessionNotCreated Could not start a new session. Response code 500. Message: Could not start a new session. New session request timed out
Any idea what could be causing the issue?

@primitivetypo Could you please review the configuration in this example? https://github.com/jlipps/appium-grid-example

@burakkaygusuz I think it is an issue with selenium core rather than the configuration. I build locally the selenium trunk code and generate latest selenium.jar and it works very well with the config. I expect the issue to be fixed in the next selenium release via docker and we should be good to go.
Until then building latest from trunk and manually running without docker works as expected.

https://github.com/appium/appium/issues/17445

https://github.com/appium/appium/issues/17445

@burakkaygusuz I think you will get better feedback in selenium or selenium-docker repositories as this appears not be related to appium.

https://github.com/SeleniumHQ/docker-selenium/issues/1669

@burakkaygusuz I had an unrelated question. How dod you convert appium server commands to the yaml file? I am trying to add arguments for allow-insecure . It works with CLI but not using the config.yaml.
Here is the command that works if starting appium from CLI
appium server --allow-insecure=adb_shell,chromedriver_autodownload
And from appium logs i see correctly the two non default server arguments updated:
info Appium Welcome to Appium v2.0.0-beta.21 (REV 3748bed378401ed75abdf32bcb3d2674d854a6f9)
info Appium Non-default server args:
info Appium   allowInsecure: {
info Appium     0: adb_shell
info Appium     1: chromedriver_autodownload
info Appium   }
info Appium Attempting to load driver uiautomator2...

However, issue is with starting from config as below:
server:
  port: 4723
  keep-alive-timeout: 80
  session-override: true
  allow-insecure: ['adb_shell', 'chromedriver_autodownload']
  use-drivers:
    - uiautomator2

When i run
 appium server --config appium_1.yml   don't see those server arguments activated
Any idea what i might be missing?

@burakkaygusuz Have you looked into Appium device farm? ? it appears to be build for Appium 2.0 and has better functionality than selenium hub without the complexities that come with selenium hub. What do you think?

I have delete the project on my repo. It was never my intention to copy it as one of my own. I always fork the project. I apologies for any disrespect on my part if any.

Also @burakkaygusuz I don't need to fork it since I moved to implementing the parallel test using appium-device-farm plugin that i had shared with you that you deleted. I am sorry again.

Feel free to delete this issue too.


No Current Line Highlight with Helm

Whenever I switched to a base16 theme, there's no highlighting of the selected line when using Helm.
Video:
https://asciinema.org/a/4lunmxz4cmmpcr0c700pm8c6m

It looks like this is another strange interaction with a 256-color terminal and base16-shell.
See #12 as well. Can you confirm what terminal you're using?

I didn't mean to close this... in a few hours, there will be a new build on melpa... can you test that and let me know if it fixes this for you?

Fixed


[image_picker][iOS] Exception is thrown when picking image on simulator

image_picker: 0.8.5+3 has issue in iOS when I tried to select the first image in the gallery.
The error occurs only when selecting the first image, but other images can be selected without error.
Steps:

Select the first image (the pop-up will close, but no images will return)
Reselect the image above (an error is thrown)

Closing this as a duplicate of https://github.com/flutter/flutter/issues/82602#issuecomment-1092475129.
Kindly follow up in the linked issue for updates.
Thank you