Windows tray installation fails

General information

OS: Windows 10 Pro
Hypervisor:Hyper-V
Did you run crc setup before starting it (Yes/No)? Yes

CRC version
CodeReady Containers version: 1.19.0+94b0362
OpenShift version: 4.6.3 (embedded in executable)

CRC status
Machine 'crc' does not exist. Use 'crc start' to create it

CRC config
- pull-secret-file                      : XXXX

Host Operating System
Host Name:                 CRCQE-WIN10
OS Name:                   Microsoft Windows 10 Pro
OS Version:                10.0.18363 N/A Build 18363
OS Manufacturer:           Microsoft Corporation
OS Configuration:          Standalone Workstation
OS Build Type:             Multiprocessor Free
...
Hyper-V Requirements:      A hypervisor has been detected. Features required for Hyper-V will not be displayed.

Steps to reproduce

crc setup --enable-experimental-features
enter the user password

Expected
Windows tray should be installed
Actual
Got a fail trying to install the tray, some problem with the temporary script for installation
Logs
INFO Checking if podman remote executable is cached
INFO Checking if goodhosts executable is cached
INFO Checking if CRC bundle is cached in '$HOME/.crc'
INFO Checking minimum RAM requirements
INFO Checking if running as normal user
INFO Checking Windows 10 release
INFO Checking Windows edition
INFO Checking if Hyper-V is installed and operational
INFO Checking if user is a member of the Hyper-V Administrators group
INFO Checking if Hyper-V service is enabled
INFO Checking if the Hyper-V virtual switch exist
INFO Found Virtual Switch to use: Default Switch
INFO Checking if tray executable is present
INFO Checking if tray is installed
INFO Installing CodeReady Containers tray
? Enter account login password for service installation [? for help] *******                                            INFO Will run as admin: Installing System Tray for CodeReady Containers
Installation script didn't execute successfully: CreateFile C:\Users\crcqe\AppData\Local\Temp\crc121645543\success: The system cannot find the file specified.

can you check if C:\Users\crcqe\AppData\Local\Temp\crc121645543 got created?

No, the folder does not exist.

This is supposed to be a temporary folder that gets created in a user writable area. it is best to verify this immediately afte the run as it could have been cleared already.
We nneed this to store a placeholder/marker to indicate the elevated privileges were succesful or not. So eiither the perrmissions were denied for this temp folder creation, or the steps beforehand really failed. In either case, best to include a debug log

Thank you for the clarification;
I checked the folder right after the execution, not when you asked me but when I got the error (as it was the first think I thought to check), anyway I executed it back again in case I missed something the first time (so double checked: fail and folder does not exist right after the execution.
On the other hand I also checked logs with debug, that is true it adds a couple of traces but nothing related with the temporary folder, so as there was no difference there I assumed they were not relevant. Anyway here is the log with the debug level:
PS C:\Users\crcqe> crc setup --enable-experimental-features --log-level debug                                           DEBU CodeReady Containers version: 1.19.0+94b0362
DEBU OpenShift version: 4.6.3 (embedded in executable)
INFO Checking if podman remote executable is cached
DEBU Currently podman remote is not supported
INFO Checking if goodhosts executable is cached
DEBU goodhost executable already cached
INFO Checking if CRC bundle is cached in '$HOME/.crc'
INFO Checking minimum RAM requirements
DEBU Total memory of system is<PHONE_NUMBER>0 bytes
INFO Checking if running as normal user
INFO Checking Windows 10 release
INFO Checking Windows edition
DEBU Running on Windows Professional edition
INFO Checking if Hyper-V is installed and operational
INFO Checking if user is a member of the Hyper-V Administrators group
INFO Checking if Hyper-V service is enabled
INFO Checking if the Hyper-V virtual switch exist
INFO Found Virtual Switch to use: Default Switch
INFO Checking if tray executable is present
INFO Checking if tray is installed
DEBU Ignoring check and forcing installation of System Tray
INFO Installing CodeReady Containers tray
? Enter account login password for service installation [? for help] *******                                            INFO Will run as admin: Installing System Tray for CodeReady Containers
Installation script didn't execute successfully: CreateFile C:\Users\crcqe\AppData\Local\Temp\crc216549775\success: The system cannot find the file specified.

The temporary directory is removed after the setup happens, so it'll not be possible to check for the actual script without modifying the code to not remove the dir after this setup preflight check has run.
https://github.com/code-ready/crc/blob/94b0362a6c6ed753c634b4d7970a3548bb9d9eb9/pkg/crc/preflight/preflight_checks_tray_windows.go#L45-L48
I think commit 71088d7771f0232ebfef06f496ec2f325e769eac will fix this, have tested it, but need to verify it again!

This is still a current issue in 1.21.0 and 1.20.0...
With the 1.20.0 installer:
DEBU CodeReady Containers version: 1.20.0+ef3f80d
DEBU OpenShift version: 4.6.6 (embedded in executable)
INFO Checking if podman remote executable is cached
DEBU Currently podman remote is not supported
INFO Checking if goodhosts executable is cached
DEBU goodhost executable already cached
INFO Checking if CRC bundle is extracted in '$HOME/.crc'
INFO Checking minimum RAM requirements
DEBU Total memory of system is<PHONE_NUMBER>0 bytes
INFO Checking if running as normal user
INFO Checking Windows 10 release
INFO Checking Windows edition
DEBU Running on Windows Professional edition
INFO Checking if Hyper-V is installed and operational
INFO Checking if user is a member of the Hyper-V Administrators group
INFO Checking if Hyper-V service is enabled
INFO Checking if the Hyper-V virtual switch exist
INFO Found Virtual Switch to use: Default Switch
INFO Checking if tray executable is present
INFO Checking if tray is installed
DEBU Ignoring check and forcing installation of System Tray
INFO Installing CodeReady Containers tray
? Enter account login password for service installation [? for help] **************
INFO Will run as admin: Installing System Tray for CodeReady Containers
Installation script didn't execute successfully: CreateFile C:\Users\ahand\AppData\Local\Temp\crc838561755\success: The system cannot find the file specified.

and with the 1.21.0 installer:
DEBU CodeReady Containers version: 1.21.0+68a4cdd7
DEBU OpenShift version: 4.6.9 (embedded in executable)
DEBU Running 'crc setup'
INFO Checking if podman remote executable is cached
DEBU Currently podman remote is not supported
INFO Checking if admin-helper executable is cached
DEBU Running 'C:\Users\ahand\.crc\bin\admin-helper-windows.exe --version'
DEBU Found admin-helper-windows.exe version 0.0.2
DEBU admin-helper executable already cached
INFO Checking if CRC bundle is extracted in '$HOME/.crc'
INFO Checking minimum RAM requirements
DEBU Total memory of system is<PHONE_NUMBER>0 bytes
INFO Checking if running as normal user
INFO Checking Windows 10 release
INFO Checking Windows edition
DEBU Running on Windows Professional edition
INFO Checking if Hyper-V is installed and operational
INFO Checking if user is a member of the Hyper-V Administrators group
INFO Checking if Hyper-V service is enabled
INFO Checking if the Hyper-V virtual switch exist
INFO Found Virtual Switch to use: Default Switch
INFO Checking if tray executable is present
INFO Checking if tray is installed
DEBU Ignoring check and forcing installation of System Tray
INFO Installing CodeReady Containers tray
? Enter account login password for service installation [? for help] **************
INFO Will run as admin: Installing System Tray for CodeReady Containers
Installation script didn't execute successfully: CreateFile C:\Users\ahand\AppData\Local\Temp\crc900730823\success: The system cannot find the file specified.

Is there any way to skip the systray service installation?

Seems like there are no skip-xxx options to skip it .

I've been running into this same failure, I haven't quite figured it out yet.
❯ .\crc.exe setup --enable-experimental-features --log-level=debug
DEBU CodeReady Containers version: 1.21.0+68a4cdd7
DEBU OpenShift version: 4.6.9 (embedded in executable)
DEBU Running 'crc setup'
INFO Checking if podman remote executable is cached
DEBU Currently podman remote is not supported
INFO Checking if admin-helper executable is cached
DEBU Running 'C:\Users\craig\.crc\bin\admin-helper-windows.exe --version'
DEBU Found admin-helper-windows.exe version 0.0.2
DEBU admin-helper executable already cached
INFO Checking if CRC bundle is extracted in '$HOME/.crc'
INFO Checking minimum RAM requirements
DEBU Total memory of system is<PHONE_NUMBER>2 bytes
INFO Checking if running as normal user
INFO Checking Windows 10 release
INFO Checking Windows edition
DEBU Running on Windows Professional edition
INFO Checking if Hyper-V is installed and operational
INFO Checking if user is a member of the Hyper-V Administrators group
INFO Checking if Hyper-V service is enabled
INFO Checking if the Hyper-V virtual switch exist
INFO Found Virtual Switch to use: Default Switch
INFO Checking if tray executable is present
INFO Checking if tray is installed
DEBU Ignoring check and forcing installation of System Tray
INFO Installing CodeReady Containers tray
INFO Will run as admin: Installing System Tray for CodeReady Containers *********
Installation script didn't execute successfully: CreateFile C:\Users\craig\AppData\Local\Temp\crc641201395\success: The system cannot find the file specified.

After trying a few different things, multiple reboots and what not, i decided to try on a fresh windows install. I was changing my ssd, i wouldn't just do that for this problem 😉
Anyway, I did a fresh install of windows 10 pro on the new ssd and once all updates were applied i ran crc setup --enable-experimental-features. I had to reboot obviously because hyper-v wasn't activated yet, reran setup and getting the same failure again.
I'll have a look through the code and see if i can spot what's happening.
All the best,
Craig
Winver: 20H2 OS Build 19042.789

As a workaround, i was able to get this running by
.\crc config set enable-experimental-features false
.\crc.exe setup --log-level=debug

I was able to crc start after that.
Note according to my debug logs i'm running v1.21 however the output of my logging matches the strings in the preflight_windows.go at v1.20 tag in this git repo. master and the v1.21 branch would log forcing installation of daemon whereas my crc cli said forcing installation of System Tray - even though it claims to be a v1.21 release. Possible issue in packaging / building of crc for windows?

This is now fixed for me in
❯ crc version
CodeReady Containers version: 1.22.0+6faff76f
OpenShift version: 4.6.15 (embedded in executable)

We have changed the way the tray is installed, its still under experimental features (i.e crc setup --enable-experimental-features)
but the issue reported here should be fixed, does it also work for you now @thinko

Closing this as tray installation is very different now. Please open a new issue if you are still seeing this.


Cannot disarm with HA when alarmed trigger via service

Hello,
First thanks for this great work.
Secondly I ran the tests as recommended (with configuration.yaml, I did not try with a new install). All worked as expected.
Today, I've decided to make a couple of automation (standard and red-node) which trigger the alarm via a service Call.
Both work i.e. trigger the alarm. I've tried with both panic type (Police and Fire). They are triggered as expected.
My only problem was when I tried to stop the alarm I realized that HA panel was in "Disarmed" mode. Hence I wasn't able to enter the code and stop the alarm from HA.
I've run several tests and I noticed that each time I send the service call, for half a second the HA alarm panel shows that the alarm is triggered but immediately comes back to "Disarmed" mode.
I've got a DSC 1864 with an Envisalink 4 FW 01.04.176

I assume this works correctly when you manually trigger these alarms via the UI?
Could you provide some debug logging of this happening?  You can enabling with something like the following in your configuration.yaml:
logger:
  default: info
  logs:
    custom_components.envisalink_new: debug

Actually the same issue happens when triggered manually from the UI.
Here below is the log file. The alarm was triggered at 20:39:04
home-assistant_envisalink_new_2023-04-11T01-39-53.738Z.log

Thanks for the logs.  It looks like what's happening is that the EVL is sending an update that the "Fire" key has been pressed followed by an update that the alarm has been triggered followed by an update indicating that the "Fire" key has been restored - all within the same second.
The code appears to treat that last update ("key restored") as an indication to clear the alarm.  It clears the "fire" attribute and clears the fact that the panel is in alarm.  I didn't write this code and don't use the this functionality myself so can't say why it currently works this way.  From the logs, my guess would be that it should not clear the alarm when the "key restored" update is received.  That would fix your issue but it would also clear the "fire" attribute even while the panel is still in alarm - which is maybe okay?

@Damien2s I'm trying to figure out what to do about this.  There seems to be Fire, Aux, and Panic keys as well as a Duress code and a "2-Wire Smoke/Aux Alarm" as ways that can trigger some form of alarm.  Do you know whether all of these will activate the alarm such that they require it to be disarmed like is the case with the Fire case you have been testing?

@Damien2s Sorry for the delay.  I've posted a beta release which I hope will fix your issue.  I don't have an easy way to test it on my physical alarm but using the logs you provided I was able to simulate the behaviour.  You will need to enable Show beta versions in the Redownload menu for the integration in HACS in order for it to show up as an installable version.
Could you please give it a try and let me know if it fixes the issues?  If there are still issues, can you capture debug log of the failures so I can have a look?  Thanks!

@ufodone thanks for the support. so I've tested the beta and it's almost fixed: now the HA panel turns into "triggered" mode when I use the panic keys. I can enter the code and disarm the alarm (it shows disarmed on the DSC UI) but the HA panel stay stuck on "triggered" mode (flashing red). It doesn't switch to disarmed mode.
When stuck on triggered mode:

if I re-trigger the alarm, I can still disarmed it via the stuck HA panel, but it remain stuck.
if I arm then disarm both from the DSC UI, the HA panel get back to normal in "Disarmed" mode and I can operated the HA panel properly.

The log follow the sequence described above:
home-assistant_envisalink_new_2023-06-09T16-20-24.111Z.log

Glad things are looking better and thanks for the logs.  I've pushed a new beta release which I believe should fix the issue.
It seems that when you disarm the alarm when it has been activated by the Fire/Panic keys, it sends a different update to indicate the alarm has been disarmed than is usually the case for a disarm action.

omg yes fixed my issue


Named import from module http. This module has no named export called Server.

Having such file
// @flow
import type { Server } from "http";

I receive this error on flow check
Error: src/file.js:2
  2: import type { Server } from "http";
                   ^^^^^^ Named import from module `http`. This module has no named export called `Server`.

in the very same time I have declarations for express 4:
$ cat ./flow-typed/npm/express_v4.x.x.js | grep 'import type { Server } from "http";'
import type { Server } from "http";

And this import should work.
Could you please help with this problem?
node v8.7.0
flow 0.57.2 (global and as flow-bin in project dependencies")
"http" comes from path like this "/private/tmp/flow/flowlib_219bb066/node.js"
I removed caches in /tmp/flow already and it didn't help

While not an answer, I got closer to finding out the likely source of the trouble through searching and testing.  Looks like there is connection between the existence of the Express 4 flow-typed defn file and the problem; getting rid of the file gets rid of the problem.  Digging deeper is the existence of the line import type { Server } from "http"; in that file that is triggering the behavior. No idea why this might be happening (I am new to flow myself).

Last bit on this, spend some time troubleshooting this and found a number of curious things.

I can replicate this problem writing my own module and library definition using the http module and exported class Server.
I can likewise replicate this problem using the Node.js url module and the exported class URL.
In the case of the url module and URL class, I can get things working as expected by NOT importing the URL type in the library definition (somehow Flow is able to resolve the type URL without importing it).
Trying the same fix for http module and Server class, I get different behavior; cannot seem to use Server without importing it.
Looking at the http module library definition, it is not entirely clear why I can import anything; it does not show any exports.

https://github.com/facebook/flow/blob/v0.61.0/lib/node.js#L1091

@chmanie: I'm experiencing the same error with Flow v0.69.0:
Cannot import Server because there is no Server export in http.

     16│ import type { Server as NodeServer } from 'http';  // nodejs.org/api/http.html

I can confirm that removing this line from flow-typed/npm/express_v4.x.x.js prevents the bug from occurring:
import type { Server } from 'http';

@rogeriopvl: flowtype/flow-typed#1767 fixes #4198 which is related to this issue but is apparently not the same. The change of return type of express$Application.listen() from Server to ?Server doesn't seem to solve this issue.
I found this related comment and PR by @keplersj:
https://github.com/facebook/flow/issues/3685#issuecomment-293489863

The issue come from the next.js libdef from flow-typed. The libdef has a import type { Component } from 'react'; outside of a declare module block. The messes up the type checker in a major nearly untraceable way.

In flowtype/flow-typed#775, the import type { Component } from 'react'; was moved inside declare module "..." { ... } which apparently was a successful workaround for the issue.

Got this issue, can't Import Server from http :/
Pretty sad :(

Has this been resolved?

As a workaround: if you're writing libdefs yourself, you can alias the imported type in the libdef, and that will permit importing it in other files. E.g.: import {IncomingMessage as IncomingMessageType} from 'http'; in your libdef prevents imports of IncomingMessage in other files from failing.
Not sure yet if this will make similarly aliased imports fail, but doesn't seem so.

This was fixed by #7448


Draw only once for better exploration

The constant redrawing of the graph when opening a new note with the related elastic animation makes exploring the graph really uncomfortable in my opinion. Since there is already a "Redraw Graph" button, I think it would be nice to have a tick to avoid redrawing next to it. Clicking a topic would only recenter the graph to it. This way you can use the graph as a semi-persistent map to navigate your content.
Later on, it would probably be a good idea to have the option to store the layout, so it will always present itself in the same way after closing the tab or the program.

@treymo , Can I pick any issue from this repo and work to it? Also Could you please let me know if there are any issues that are beginner friendly?
PS: I'm sorry if this is not the right place to ask about this


[nrf noup] boot: zephyr: Do not lock PCD region with TF-M

Previously PCD memory was locked as read-only, non-secure in MCUboot. Given that TF-M also needs write to PCD to communicate with b0n, the memory is left unlocked and locked to read-only, non-secure in TF-M.
Edit: Added fix to MCUboot upgrade image handling with CONFIG_NRF53_MULTI_IMAGE_UPDATE.

@nvlsianpu: Could you take a look at this?

@nordicjm: Could you review this?
The manifest PR is green and is only pending our discussion about: https://github.com/nrfconnect/sdk-nrf/pull/17093#discussion_r1808303091

Can you details your test case for the issue mentioned in the second commit?

@nordicjm: Sure, this was manually tested following the guidance in https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/samples/tfm/tfm_psa_template/README.html.
First, set the keys for the sample according to: https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/samples/tfm/tfm_psa_template/README.html#firmware_update.
Then flash the provisioning sample and tfm_psa_template according to: https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/samples/tfm/tfm_psa_template/README.html#building_and_running.
Then perform the following steps from the https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/samples/tfm/tfm_psa_template/README.html#bootloader_firmware_update:
cd ~/ncs/
west build -b nrf5340dk/nrf5340/cpuapp/ns nrf/samples/tfm/tfm_psa_template
-Dmcuboot_CONFIG_FW_INFO_FIRMWARE_VERSION=2
mcumgr --conntype serial --connstring dev=/dev/ttyACM1,baud=115200,mtu=512 image list
mcumgr --conntype serial --connstring dev=/dev/ttyACM1,baud=115200,mtu=512 image upload
build/signed_by_mcuboot_and_b0_s1_image.bin
Now, instead of flagging the image to be tested/confirmed on the next reboot, reset the device.

The reason for the failure was that the boot_validate_slot failure did not clear the values that were set.

@nordicjm: This is the result when you perform the steps using my PR's, without the commit for fixing the issue:
*** Booting nRF Connect SDK v2.7.99-15677cea39aa ***
*** Using Zephyr OS v3.7.99-8d6fc59bf40a ***
Attempting to boot slot 0.
Attempting to boot from address 0x8200.
I: Verifying signature against key 0.
I: Hash: 0x18...fc
I: Firmware signature verified.
Firmware version 1
*** Booting My Application v2.1.0-dev-0a58adb35ccb ***
*** Using nRF Connect SDK v2.7.99-15677cea39aa ***
*** Using Zephyr OS v3.7.99-8d6fc59bf40a ***
I: Starting bootloader
I: Image index: 0, Swap type: none
I: Image index: 1, Swap type: none
I: Bootloader chainload address offset: 0x14000
�ERROR: Cannot fulfill EXT_API request.
Note the bootloader chainload address offset which points to s1_image, instead of application. With the changes in PR's the network core image is build automatically, but we are not trying to update it here.
I am not sure how you expect me to reproduce this using https://github.com/nrfconnect/sdk-mcuboot/pull/338. The PR does not compile against main. And it does not set the CONFIG_NRF53_MULTI_IMAGE_UPDATE, which is not set by the sample, before the changes in my PR's.
If you want to reproduce this with my PR's:

Fetch the PR from: https://github.com/nrfconnect/sdk-nrf/pull/17093
Run west update.
Go to ncs/bootloader/mcuboot/ and git checkout HEAD~1.

After which you run the steps that I gave previously.

The PR does not compile against main

Pasted one of linked PRs but not the ncs one, use https://github.com/nrfconnect/sdk-nrf/pull/17567

The PR does not compile against main

Pasted one of linked PRs but not the ncs one, use nrfconnect/sdk-nrf#17567

@nordicjm: I was not able to reproduce the failure with https://github.com/nrfconnect/sdk-nrf/pull/17567. I think that the changes that you have done for checking the netcore image area prevent this from happening.
Furthermore, I cherry-picked my changes on top of you PR's and I was able to simultaneously update network core and application core.
Is the https://github.com/nrfconnect/sdk-nrf/pull/17567 coming to 2.8? If it is, then I should remove the fix from this PR.

Is the https://github.com/nrfconnect/sdk-nrf/pull/17567 coming to 2.8? If it is, then I should remove the fix from this PR.

Yes, it is urgently needed to fix some issues with sysbuild image IDs. @nvlsianpu @de-nordic please review https://github.com/nrfconnect/sdk-nrf/pull/17567 and https://github.com/nrfconnect/sdk-mcuboot/pull/338


Add an option to not set click listener on the header by default

I wanted to keep track of the expanded item position.
Using the default expansion listener didn't work.
So I had to write my own onClickListener which was not possible because you set it by default in the header class.
I had to create my custom header to remove the clickListener and add my own clicklistener in the recyclerview adapter.
Can you also please make it that when calling .expand() or .collapse() with false as the parameter to reset the indicator without animation too.
        if (isExpanded)
            holder.binding.expansionLayout.expand(false);
        else
            holder.binding.expansionLayout.collapse(false);
        expansionsCollection.add(holder.binding.expansionLayout);
        holder.binding.ehHeader.setActivated(isExpanded);
        holder.binding.ehHeader.setHeaderRotationCollapsed(0);
        holder.binding.ehHeader.setHeaderRotationExpanded(180);
        holder.binding.ehHeader.setOnClickListener(v -> {
            if (isEnabled){
                mExpandedPosition = isExpanded ? -1: position;
                holder.binding.expansionLayout.toggle(true);
            }
        });

I also was looking for a way to set a custom click handler on the header. I ended up setting it in .doOnAttach because the default is set in onAttach and mine would be set after.


I just wanted to say thanks.

Absolute godsend of an extension. I used to have Gmail Offline installed purely for this purpose, but having this saves me a bit of system resources, and it doesn't get in my way.

Cheers!


Can regex compilation errors be caught before applying the regex?

I am trying to do something like:
compileMatches :: Text -> Either String (Text -> Bool)

where any regex compilation errors should be caught before the regex is actually applied.
Is it possible?

Not currently.  The recommendation is to use [regex|...|], in which case any compilation errors are caught during Haskell compilation, rather than a monad at runtime.
I'm open to suggestions for why the latter would be good to include.

Not currently.  The recommendation is to use [regex|...|], in which case any compilation errors are caught during Haskell compilation, rather than a monad at runtime.
I'm open to suggestions for why the latter would be good to include.

I suppose something getting access to Text -> Bool by itself doesn't buy you much. My usecase is "I'm trying to mimic another library's interface using pcre2 as the backend", but it's not a common usecase.
It does occur to me, though, that without an opaque data Regex type it seems to be impossible to write a reusable regex that a) would be checked at compile-time and b) would be usable both for matches and for pcre-native sub. Which is a slightly different issue.

I suppose something getting access to Text -> Bool by itself doesn't buy you much. My usecase is "I'm trying to mimic another library's interface using pcre2 as the backend", but it's not a common usecase.
It does occur to me, though, that without an opaque data Regex type it seems to be impossible to write a reusable regex that a) would be checked at compile-time and b) would be usable both for matches and for pcre-native sub. Which is a slightly different issue.

Re: "seems to be impossible", I agree.  The closest we can get currently is [_regex|...|], which is a) checked at compile-time and b) usable for both matching and subbing.
But yeah, the subbing is over a Traversal' rather than native, so it's slower and lacks the concise "$1" syntax.  On the other hand, capture group references are validated at compile time.

Re: "seems to be impossible", I agree.  The closest we can get currently is [_regex|...|], which is a) checked at compile-time and b) usable for both matching and subbing.
But yeah, the subbing is over a Traversal' rather than native, so it's slower and lacks the concise "$1" syntax.  On the other hand, capture group references are validated at compile time.

FWIW,
{-# LANGUAGE OverloadedStrings #-}
{-# LANGUAGE TypeApplications #-}

import Control.Exception (displayException, evaluate, try)
import Data.Text         (Text)
import Lens.Micro
import System.IO.Unsafe  (unsafePerformIO)
import Text.Regex.Pcre2  (Pcre2CompileException, matches)

compileMatches :: Text -> Either String (Text -> Bool)
compileMatches patt = unsafePerformIO $ do
    let r = matches patt

    try (evaluate $ r "")
        <&> _Left %~ displayException @Pcre2CompileException
        <&> _Right .~ r

main :: IO ()
main = do
    let test patt = putStrLn $ show patt ++ ": " ++ case compileMatches patt of
            Left e  -> e
            Right r -> "matches \"foo\": " ++ show (r "foo")

    test "foo"
    test "bar"
    test ")"

FWIW,
{-# LANGUAGE OverloadedStrings #-}
{-# LANGUAGE TypeApplications #-}

import Control.Exception (displayException, evaluate, try)
import Data.Text         (Text)
import Lens.Micro
import System.IO.Unsafe  (unsafePerformIO)
import Text.Regex.Pcre2  (Pcre2CompileException, matches)

compileMatches :: Text -> Either String (Text -> Bool)
compileMatches patt = unsafePerformIO $ do
    let r = matches patt

    try (evaluate $ r "")
        <&> _Left %~ displayException @Pcre2CompileException
        <&> _Right .~ r

main :: IO ()
main = do
    let test patt = putStrLn $ show patt ++ ": " ++ case compileMatches patt of
            Left e  -> e
            Right r -> "matches \"foo\": " ++ show (r "foo")

    test "foo"
    test "bar"
    test ")"

Closing due to inactivity.


Request form update

Create a public version of NGO_request_form with following changes:
(a) remove volunteer count option
(b) Add a toggle question: Are you from any NGO?
If no, then make source = "covidsos" in API call. If yes, show source dropdown. Add an "others" option on the bottom of that list.
(c) If answer to (c) was no, Add a toggle question: "Are you filling form on behalf of someone else?"
If user says no - then nothing, they can just do "submit". You can pass the filled_by_name and filled_by_number same as requestor name & number.
If user says yes - Show two fields

"Your Name"
"Your Mobile number"
If answer to (c) was yes, Add a toggle question: "Enter your Name & Number"
"Your Name"
"Your Mobile Number"

For this public detailed request form which opens publicly, hit a new API - /full_request_form

For later:
Change request form to pop-up view similar to "Volunteer Form" / figma view.

On page 3 of public Request form, add a button "Add more details" button next to "Submit" button. These should be next to each other instead of one above the other.
Under "Add more details" put a "⚡ FAST HELP".


Change to f strings for readability

This PR has:

[ ] Appropriate testing (molecule, python unit tests)
[ ] Appropriate documentation (README in the role, main README is up-to-date)

/lgtm


Auto generated CRD to golang struct

Feature Request
Auto generated CRD to golang will be very useful while integration between 2 operators ,so in case we have one operator written in java and another written in go.
we can take the java crd input and auto generated golang struct so the operator SDK will generate the appropriate golang struct.
This feature is very useful so in case the java operator crd is changing its auto generated in the operator sdk
Describe the solution you'd like
A clear and concise description of what you want to happen. Add any considered drawbacks.

Auto generated CRD to golang

If I understand correctly you want a custom resource struct to be generated for you based on java equivalent input? Not sure we currently have plans to add support for java operators, but can you elaborate a bit on that, what would the end result look like and what would the input be.

basically i would like to perform integration between operators ,main operator is written in go and it expect to create CRD and run it for another operator that is written in java.
so instead of creation the CRD struct manually as part of my project i would like to have the option to generate this struct in golang automatically during build/generation so in case any change in the crd the struct will be updated during build time


Bug Forbid adding array key columns

Proposed changes
mysql> desc array_test;
+-----------+----------------+------+-------+---------+-------+
| Field     | Type           | Null | Key   | Default | Extra |
+-----------+----------------+------+-------+---------+-------+
| id        | INT            | Yes  | true  | NULL    |       |
| c_array   | ARRAY<INT(11)> | Yes  | false | NULL    | NONE  |
+-----------+----------------+------+-------+---------+-------+

Before:
mysql> ALTER TABLE array_test ADD COLUMN add_arr_key array<int> key NULL DEFAULT NULL;
Query OK, 0 rows affected (0.00 sec)

After:
mysql> ALTER TABLE array_test ADD COLUMN c_array array<int> key NULL DEFAULT NULL;
ERROR 1105 (HY000): errCode = 2, detailMessage = Array can only be used in the non-key column of the duplicate table at present.

mysql> ALTER TABLE array_test MODIFY COLUMN c_array array<int> key NULL DEFAULT NULL;
ERROR 1105 (HY000): errCode = 2, detailMessage = Array can only be used in the non-key column of the duplicate table at present.

Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[x] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[x] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

LGTM


Handle labels

Add function to turn castep labels into dicts
Add function to turn strings/dicts into NamedTuples (in new processing.py)
Add parsing for labels on Born Charges
Add test for the above

Addresses #104

Thanks for this!
I've added one comment - about standardising to the  (Sp:tag [label])  form.
The only other thing I noticed was the output to json (possibly other formats?) makes these keys look like this:
"H [H1]_1" which could be a bit clunky later on (?) when dealing with these json files. Is there a better alternative, I wonder? (I guess this is handled in the json_safe function?).

Thanks for this!
I've added one comment - about standardising to the (Sp:tag [label]) form.
The only other thing I noticed was the output to json (possibly other formats?) makes these keys look like this: "H [H1]_1" which could be a bit clunky later on (?) when dealing with these json files. Is there a better alternative, I wonder? (I guess this is handled in the json_safe function?).

There're a few approaches we could take to this.

Strip the label notation out before dumping to json/yaml, which would be fine as there'd be the label mapping block, but may be quite clunky.
Separate the label by an underscore rather than a space
Remove the space leaving ("H:tag[label]")
Leave it as-is

Most of these affect the recovery of the original data from the json negatively. In general, I think leaving as-is is the best option as this leaves the user the ability to quickly run a "split on _" and parse the second element as an int, and recover the original data. The problem is that json doesn't permit tuples as indices for a dict. The _ is just a quick, reversible way around that.


Adding Compatibility for Cohere Command-R model family API

Cohere's Command-R and Command-R-Plus models have a different API than the Command model provided on Bedrock.
This pull request adds compatibility based on model ID instead of the provider exclusively.
closes https://github.com/langchain-ai/langchain-aws/issues/66

@keshavd
I am not able to test the cohere model with these changes. Here is the sample code I used.
params = {
    "region_name": "us-west-2",
    "model_id": "cohere.command-r-v1:0"
}
model = BedrockLLM(**params)
response = model.invoke("Hello!")

Here is the exception thrown in _prepare_input_and_invoke
try:
      response = self.client.invoke_model(**request_options)

      (
          text,
          tool_calls,
          body,
          usage_info,
          stop_reason,
      ) = LLMInputOutputAdapter.prepare_output(provider, response).values()

  except Exception as e:
>           raise ValueError(f"Error raised by bedrock service: {e}")
E           ValueError: Error raised by bedrock service: 'NoneType' object is not subscriptable

Closing this PR because of inactivity.


Support for partitioned tables

What feature are you requesting?
Today, CREATE TABLE ... USING columnstore is incompatible with partitioned tables.
Why are you requesting this feature?
Want to keep a history of up to 90 days in the DB, but to start archiving data after that period.
What is your proposed implementation for this feature?
No response

It would be good to have this. One of the 2 things that keep us from using pg_mooncake

https://github.com/Mooncake-Labs/pg_mooncake/commit/373bfc5d6cd8f425b7bab069e2e249e8aecc092c
should cover most use cases of partitioned tables in postgres.
For time series use cases, each file will likely only contain data from similar time range.
So at query time, based on the filter, most data files will be skipped.


openssl passwd in rhel 7 does not support sha512 based password algorithm

Adding user account does not work on rhel 7 because openssl passwd in rhel 7 does not support sha512 based password algorithm.
https://github.com/weldr/welder-web/blob/12584fb192dd4ce9f8f874e07d5ebf37e98c6fed/components/Modal/UserAccount.js#L185
openssl passwd output:
[root@m1 ~]# openssl passwd -6 -stdin
Usage: passwd [options] [passwords]
where options are
-crypt             standard Unix password algorithm (default)
-1                 MD5-based password algorithm
-apr1              MD5-based password algorithm, Apache variant
-salt string       use provided salt
-in file           read passwords from file
-stdin             read passwords from stdin
-noverify          never verify when reading password from terminal
-quiet             no warnings
-table             format output as table
-reverse           switch table columns

Unfortunately it's ridiculously complicated to encrypt a password on the command line; openssl passwd is pretty much the only way; chpasswd knows how to encrypt, but only operates on the /etc/shadow file, not on stdout. There are a few ways using python or perl, but these all mean additional dependencies, or mucking around with python2-only vs. python3-only distros.
With that much trouble, I think it would actually make more sense to do it on the JavaScript side with bcrypt.

Fixed in PR #661, just got wrongly referenced in the commit message. (@henrywang : This should be "Fixes #xxxx")


IRR support

Are you planning on supporting IRR?

Hi! Thanks for reaching out. Currently, we don’t have plans to support IRR in this gem, as we’re focused on keeping it lightweight and optimized for XIRR calculations specifically. However, forking this repository to extend it for IRR calculations would be fairly straightforward if you’d like to explore that.
I may be able to look into it when time allows! But I can’t commit to a timeline just yet 😅


Request to add feature to limit types of files to be uploaded via file upload

Hi there,
We have been using Admin bro for quite a while now and have been super helpful on dev and turnaround time. Kindly allow us to have this feature so that we can close our VAPT requirements as well.

@shubhambhartiya08  currently this feature is available nicely through Upload Feature for AdminBro it's so easy and straightforward you just need to
const validation = {   mimeTypes: ['audio/mpeg'], };
and then in your array of features just add validation
module.exports = {   options,   resource: Mp3,   features: [     uploadFeature({       provider: new MyProviderForMp3(),       properties: {         key: 'mp3File.path',         bucket: 'mp3File.folder',         mimeType: 'mp3File.type',         size: 'mp3File.size',         filename: 'mp3File.filename',         file: 'mp3File',       },       uploadPath: (record, filename) => ${filename},       validation,     }),   ],


[Property Set Removal] Prefilter IfcRelDefinesByProperties before transforming

A root IfcRelDefinesByProperties causes an exception
System.NotSupportedException: Invaild IfcRelDefinesByProperties #315720

since it's not dropped by inverse relationships of products

IFC4 allows multiple sets to be assigned by a single relation instance.
Since IfcRelDefinesByProperties may reference a single IfcPropertySetDefinition or a set of it (as a select), the transform as to deal with it in two ways:

for IFC2x3 & IFC4: if a single, it's already dropped before while passing the filter criteria
for IFC4: if it is a set (with at least one set passing the filter), the set has to be modified

Fixed


fix: update CI

uses the v2 of goreleaser to fit with the configuration.
remove useless workflows
use stable and oldstable as Go version
groups updates of GitHub actions

Thanks @ldez!
But I think I used an old version of macos because it failed to install yamllint.
And why have you removed the release pipeline? Is making the release by hand better than by using a pipeline?


Make a “might be them, but not sure” button + interface

Should there be a “might be them, but not sure” button + interface to bubble these up for review by others for confirmation?

+1 on this suggestion—it would be very helpful at times.
Originally posted by @kcopas in https://github.com/dshorthouse/bloodhound/issues/65#issuecomment-515748104

Agreed that this would be helpful!

The reason this issue has been sitting here for some time is the additional complication wrt persistence of these sorts of annotations in the face of refreshes from GBIF, the structure of these annotations, the UI enhancements required, and what to do with these for others to later discover and help take action. In other words, there's a swirl of new features required to make this work well.


Map validation failing with ISO Codes

[x ] I have looked at the documentation here first?
[ x] I have looked at the examples provided that may showcase my question here?

Package version eg. v10:  v10.23.0
Question:
How can I validate the following map[string]string? It's failing me always with the ISO code but everything is correct.
Code sample, to showcase or reproduce:
Translations map[string]string `validate:"min=1,dive,keys,iso3166_1_alpha2,endkeys,required"`

Could you provide a test case in which your data does not pass the iso3166_1_alpha2 validation?
Similar to https://github.com/go-playground/validator/blob/6c3307e6c64040ebc0efffe9366927c68146ffba/validator_test.go#L12612-L12614


Question Please, Is it possible to use react in same project?

Hi Daniel,
I love this repo. I keep coming back to it because I find it so interesting.
I have a question for you please,
Do you think its possible to combine react together in this project? Or would it make the Webpack config tooooo crazy?
Did you ever experiment with using a central store? maybe using LocalStorage hooked up to Vuex so the different isolated Vue apps could still talk to each other? Maybe to do this there would need to be some kind of eventing system which is shared between the different SPAs I suppose?
Your Answers would be very much appreciated If you have the time
Kind Regards

Hi @nigel-dewar ,
first, thank you for the support, I'm glad this repo is of help to you.
To answer your questions.

I don't believe adding React support would complicate things too much. It should be a minor change of adding support for jsx and including additional entry files.
Since transition between multiple SPA's includes page refresh, you are right, store data should be persisted. You are on the right track, best way I see to implement persisted storage without going to the API for the data is to SAVE and READ from the storage first.

Sorry for the late reply.
Happy developing 🚀


[ACR] Incorporate API review feedback from Arch Board

[ ] Rename GetTagProperties to GetTag (or language appropriate)
[ ] Remove LoginServer and Name properties from ContainerRegistryClient
[ ] Come up with better name for ArtifactManifestReference
[ ] Remove the DeleteRepositoryResult type, and return a success result from DeleteRepository operation even when a 404 is received.
[ ] Evaluate FullyQualifiedName with regard to 1) what we do in other Track 2 libraries wrt to the qualified name concept and 2) what this is commonly called in the Docker/containers community.
[ ] Replace TagOrDigest with Digest.
[ ] Ensure functional parity of Python library with others
[ ] Rename PATCH service methods from Set.. to Update..
[ ] Discuss parallelizing the delete sample across languages

@pallavit, would you add Java-specific action items to this issue?

The feedback has been addressed.


DRAFT: collector operations optimisation

This PR introduces the CollectorUtils library to improve the routine operations of the Collector:

adds explicit naming of parameters
wrapping up repeating actions: swap collector funds, deposit to v3, open a stream

moved to aave-helpers


Feedback for “Configuration”

The link to the TypeScript API Reference is broken, it should link to "https://github.com/autometrics-dev/autometrics-ts/tree/main/packages/autometrics/reference". The current link is directed to "https://github.com/autometrics-dev/autometrics-ts/tree/main/packages/lib/reference", which does not exist.. Specifically, /lib/ -> /autometrics/.

Hey @frankdejonge thanks for reporting these! We've recently moved a lot of things around in the TypeScript repo and I'm still catching up with some broken links. Will fix these up shortly!


How to restrict the length of string generated

If I am generating username in the following way
generic.person.username('UU_d')
How can I restrict the length of string generated to say only 8 characters or 10 characters?

I'm afraid that you need to cut them using slice because at this moment there is no such feature.
Like this:
person = Person('en')
person.username()[:8]

The problem here that it can generate usernames with length of of less than 8 characters.

Thank you.
Is it possible to add this feature and make a release as I feel this feature would be really helpful?

I think we can add something like this:
person.username(max_length=8)
'UserName'

So, my answer is yes we will add such a feature. The release of 4.0.0 will be not really soon but we will add such a feature to it.
Thank you for your interest and suggestion we appreciate it.

Thanks for your support.

@lk-geimfari with the current implementation, I think that is a bit complicated to generate usernames of a given length or of a certain maximum length. There are too much variables such as the chosen template and the number of digits. To implement this feature, I think that this method needs to be changed

@ceccoemi I have tried today and yes, you're totally right. It's too complicated. I don't think the effort is worth it.


Conservative renderer

I don't feel that graph based development is yet ready for realizing all the detailed behaviors that are needed to implement a proper text renderer, so this PR converts all the code to a more classic / conservative design: An application produces shapes, that are converted to wgpu "primitives" using a few caches, which are then are rendered to a surface.

First results dont look that bad considering the size of the refactoring (SDF switching seems to work, too):


[RFC] Allow packed types to transitively contain aligned types

Rendered
This issue was introduced in the original implementation of #[repr(packed(N))] and have since underwent extensive community discussions:

#[repr(align(N))] fields not allowed in #[repr(packed(M>=N))] structs
repr(C) does not always match the current target's C toolchain (when that target is windows-msvc)
repr(C) is unsound on MSVC targets
E0587 error on packed and aligned structures from C
E0587 error on packed and aligned structures from C (bindgen)
Support for both packed and aligned (in repr(C)
bindgen wanted features & bugfixes (Rust-for-Linux)
packed type cannot transitively contain a #[repr(align)] type
structure layout using aligned attribute is incorrect

The solution proposed in this RFC mostly reflects what was proposed here

Do C/C++ toolchains for mingw address the #[repr(system)] issue in any way?
What do they do when they need to interoperate with msvc-style layouts?

@petrochenkov
My understanding is that MinGW doesn't really do anything, and attempting to call MSVC APIs from MinGW will result in ABI issues.

Yay, finally some progress on this front! I haven't dug into the details of this RFC, but based on a quick skim I am generally in favor.

An alternative, more minimal spot fix could be as such:

Allow #[repr(align(N), packed(M))] on structs with the semantics of packed(M) wrapped in align(N).
Allow #[repr(align(N))] on fields to request a higher alignment for the field without introducing a type wrapper.

This would allow tools like bindgen to implement the odd MSVC packing rules without putting them into the language.

What changes is that packed(M) types no longer have an alignment of exactly M, but instead have an alignment of at least M.

…Actually, if we want to exactly match the semantics of #pragma pack on MSVC, the "correct" behavior would actually be to allow the type to have alignment less than M still. MSVC's #pragma pack does not raise the alignment of a struct to the packing width, and in fact, x64 and ARM64EC operates under #pragma pack(16) by default. (x86, ARM, and ARM64 default to #pragma pack(8).)
There is actual utility in #[packed] working this way in Rust for generic containers. I don't think that the utility is anywhere near enough for the change, but it bears keeping in mind.

MSVC's #pragma pack does not raise the alignment of a struct to the packing width

Neither does our attribute?

Oh, I, uh, misremembered overconfidently. Oops.


Question about MONDO_0008840 ataxia telangiectasia

the subclass assertion below seems wrong, but I can't determine what the underlying cause is.

Good catch, you can see that this has a low prob associated with it, so this is ranked high in the list of things to investigate

I can't determine what the underlying cause is.

See the editors manual. You can see the provenance of the xrefs that were used as seed interpretation as axioms. You will see that Orphanet called Orphanet:100 - OMIM:208900 as 'e'. But I think this is a common problem to interpret the OMIM as more generic than it is based on name.

actually in this case we agree with the 'e'. we should treat the variant using the variant pattern

note also, Orphanet includes http://www.orpha.net/consor/cgi-bin/OC_Exp.php?lng=EN&Expert=251347 "ataxia-telangiectasia-like disorder". It would seem from the name this would be a good grouping for the variant term. However, Orphanet has no children here. It also says it is neonatal which conflicts with typical onset for variant.
this orphanet xrefs https://omim.org/entry/604391 ATAXIA-TELANGIECTASIA-LIKE DISORDER 1; ATLD1
we also have https://omim.org/entry/208910 "ATAXIA-TELANGIECTASIA WITH GENERALIZED SKIN PIGMENTATION AND EARLY DEATH"
is this at AT-like disorder? or an AT-variant? Or is it a subtype of AT?


max_bytes_before_external_group_by not working with DBT

Describe the bug
I am running a dbt model with max_bytes_before_external_group_by settings. Still, I am getting Memory Error. If the run the same query on ClickHouse cloud it works perfectly fine
SELECT invoice_id,
        reason,
        argMax(message, date) AS message,
        MAX(_synced_at) AS _synced_at
FROM stg_invoices_invoicelog
GROUP BY invoice_id, reason
SETTINGS max_bytes_before_external_group_by=1000000000;

DBT model definition
{{
    config(
        materialized='incremental',
        incremental_strategy='delete+insert',
        order_by='invoice_id',
        unique_key='invoice_id',
        query_settings={'max_bytes_before_external_group_by':<PHONE_NUMBER>}
    )
}}

SELECT invoice_id,
        reason,
        argMax(message, date) AS message,
        MAX(_synced_at) AS _synced_at
FROM stg_invoices_invoicelog
GROUP BY invoice_id, reason

Expected behaviour
It should not give error
Configuration
Environment

dbt version: <IP_ADDRESS>.11
dbt-clickhouse version:  1.8.1
clickhouse-driver version (if using native)
clickhouse-connect version (if using HTTP): 0.7.8
Python version: 3.8
Operating system: macOs

ClickHouse server

ClickHouse Server version: <IP_ADDRESS>10
ClickHouse Server non-default settings, if any:
CREATE TABLE statements for tables involved:
Sample data for these tables, use clickhouse-obfuscator if necessary

Can you check the ClickHouse query log (system.query_log)  for the dbt version of the query?  The query log should include the settings and you can compare the two queries directly.

There's also a major difference between a DBT "incremental" model and a simple ClickHouse SELECT.

Can you check the ClickHouse query log (system.query_log) for the dbt version of the query? The query log should include the settings and you can compare the two queries directly.

This is the query that I got from the log. It is not applying the query settings. @genzgd
/* {"app": "dbt", "dbt_version": "1.8.5", "profile_name": "ottimate", "target_name": "dev", "node_id": "model.ottimate.int_invoices_invoicelog"} */

        create table `ottimate`.`int_invoices_invoicelog`

  engine = MergeTree()
        order by (invoice_id)

                    -- end_of_sql
                    SETTINGS  replicated_deduplication_window=0

            empty
          as (

SELECT invoice_id,
        reason,
        argMax(message, date) AS message,
        MAX(_synced_at) AS _synced_at
FROM stg_invoices_invoicelog
GROUP BY invoice_id, reason
          )

There's also a major difference between a DBT "incremental" model and a simple ClickHouse SELECT.

This is kind of full refresh. I have cleaned the logic for incremental model to test if the simple query works.

Thanks for the detailed log data!  That looks like a bug in "full refresh", where an "intermediate" table is created and then swapped, but that intermediate table doesn't appear to have the query_settings applied.  We'll see if we can pin down the actual problem over the next few days.


Polymorphic decoding?

Say I have a class that has a number of subclasses (finite, known). Now I'd like to map those subclasses to received JSON, however the JSON for different subclasses arrives under same key. The general structure would look something like this:
{
  "children": [
    {
      "id": 1,
      "name": "Foo",
      "attributeA": "Bar",
      "type": "ChildA",
    },
    {
      "id": 2,
      "name": "Baz",
      "attributeA": "Quux",
      "type": "ChildA"
    },
    {
      "id": 3,
      "name": "Lorem",
      "attributeB": "Ipsum",
      "type": "ChildB"
    }
  ]
}

I have a parent class, that has common properties (like id and name):
class Parent {
    let id: Int
    let name: String
}

and a few child classes:
class ChildA: Parent {
    typealias DecodedType = ChildA
    let attributeA: String
}

class ChildB: Parent {
    typealias DecodedType = ChildB
    let attributeB: String
}

Every child class have different attributes. I have no problem writing Decodable extensions for subclasses, however the part where I trip up is implementing Decodable for parent class. Each of the child's payload has a type key that basically maps to subclasses. This is how decodable looks for parent class:
enum ChildType {
    case ChildA, ChildB

    init(_ type: String) {
        switch (type) {
        case "ChildA":
            self = .ChildA
        case "ChildB":
            self = .ChildB
      }
}

extension Parent: Decodable {
    static func decode<T: Decodable>(json: JSON) -> Decoded<T> {
        let type : String = (json <| "type").value!
        let typeClass = ChildType(type)
        switch typeClass {
        case .ChildA:
            return ChildA.decode(json)
        case .ChildB:
            return ChildB.decode(json)
        }
    }
}

Now syntactically it's correct. But each time I try to build I segfault the compiler. My gut says that I have done something wrong with Parent's decode function (because it returns a generic decoded type which is probably nonsense). Any help is much appreciated.

Hmm this is an insteresting case. It would be nice if every element in the array was the same child type, then decoding would be easy. With them all being different you'll have to decode the array as a [Parent]. Your decode function on Parent should figure out which child to call decode on then execute that. It looks like you've done that. I think the type signature of decode should look like this: static func decode(j: JSON) -> Decoded<Parent>

I did try using
static func decode(j: JSON) -> Decoded<Parent>

for Parent class, but then I get the error saying
Decoded<ChildA> cannot be converted to Decoded<Parent>

when returning decodable subclasses in parent's decode function.

I changed this to your suggested signature, but now I get a EXC_BAD_ACCESS when executing the code because of recursion that is 'caused by parsing the child from Parent's class:

give child's JSON to a parent's class
parent tries to parse the child and passes JSON to child's class: ChildA.decode(son)
for some reason the class that get's the call is parent, not ChildA.
Go to step 1.

@eimantas It's been a while since your last message. Are you still having this issue?

I am not sure if it's still present. I have migrated my usage down to array of homogenous elements. Thus now listings are only for [ChildrenA] or [ChildrenB].
I would still be interested in seeing it working (best as a decoding example in Argo's readme).

Sounds good. I think that's easier anyways and is how we intend Argo to work. I'd also be interested in what this might look like. I'll close this for now and we'll look into an example of this later.


cell adhesion molecule

Hi Pascale
I have opened a ticket to discuss the issue you raised in https://github.com/geneontology/go-ontology/issues/14324 where you express concern about the term: 'GO:0086080 | protein binding involved in heterotypic cell-cell adhesion'
this may lead to an explosion of terms if we allow this pattern (unless there is something specific about this term that isn't immediately obvious). In this case would the MF term GO:0098631 'cell-cell adhesion mediator activity' represent the function you are trying to capture ?
The main reason this term was created was because the cell adhesion molecule activity term was obsoleted and this was a way of creating the term required to capture this data. The  'cell-cell adhesion mediator activity' term meets this need. However, it is possible that some of the annotations are no associated with cell adhesion molecules. So these will need to be checked before removing this term.
As this term has 5 cardiac child terms can we delay the removal of this term and the revision of the annotations until after news about the cardiac paper please?
please add GO:0098631 'cell-cell adhesion mediator activity' in the list of replace by for
GO:0005194 obsolete cell adhesion molecule activity
Thanks
Ruth

I notice we have used
"cell adhesion molecule binding" to represent this (presumably because any adhesion molecule must bind to another adhesion molecule!)
http://pombase-dev.bioinformatics.nz/term/GO:0050839
I didn't know about
GO:0098631 'cell-cell adhesion mediator activity
Maybe  GO:0050839 is not really required  either if this is how it has been used?

please  add GO:0098631 'cell-cell adhesion mediator activity' in the list of replace by for
GO:0005194 obsolete cell adhesion molecule activity

DONE

Hi @RLovering
Paul and I renamed 'GO:0098631 protein binding involved in cell adhesion' -> 'cell adhesion mediator activity' in September when we started the MF refactor.
We also changed the definition from 'Any protein binding that is involved in cell adhesion.' to 'Any binding by a cell surface protein to a molecule external to the cell, that meditates adhesion of the cell to that external substrate.' I am just now noticing that the former parent (protein binding) is therefore be incorrect; I now to moved it up to 'binding'. Same for cell-matrix adhesion mediator activity. (Neither term have any direct annotations).
I suspect there are a large number of different combinations of cells that can bind to each other; isn't it possible to capture that information as an extension, which would then cover 'protein binding involved in heterotypic cell-cell adhesion'?
@ValWood
I agree that 'cell adhesion molecule binding' is not very informative regarding the protein function: it may be binding a ligand, or a regulator, or a member of the complex... but we have many types of x-binding, for now I prefer not to open that.


Hubitat Port

I am attempting to port this over to hubitat, and I am running into an issue where I get a 500 error when I attempt to select devices.  I have been trying to figure out what is going on for 3 days now.
Can you give me any advice on how to debug this?
Here is the debug info I've added.
Would you give me more logs(Full log)?
It seems that there is no log when you select device.
Did you means that ‘select device’ is ‘Select Device’ menu after ‘Add a device’ -> ‘Select Hub’?

That is correct.  So I add the harmony api server IP and port, then the menu to add devices shows up.  I click on add Devices and immediately get a 500 error.
Let me see if there is a way to get more information from the logs.

Well...
Although hubitat' is almost same architecture with SmartThings,
it seems that there is a little difference at SDK.
The code you mentioned is below.
        section("") {
            app( name: "harmonyDevices", title: "Add a device...", appName: "KuKu Harmony", namespace: "turlvo", multiple: true, uninstall: false)
        }

Yeah.  I found that line, but I couldn't figure out which function was being called to create the list of devices.  Or even what was causing the 500 error.

Where is that function called from here:
section("") {
            app( name: "harmonyDevices", title: "Add a device...", appName: "KuKu Harmony", namespace: "turlvo", multiple: true, uninstall: false)
        }

I have a debug line in mainChildPage and that never shows up in the log, so I am inclined to believe it is not running.

Hello,
Great!!. You did porting to Hubitat.
I saw your github and hubitat commnunity post.
I’ll close this issue.
Thank you.


Chat not showing on iOS chrome

On iOS safari and Firefox the chat does show and does work.

Really need a decent browser shots system to test


RS migration - trymerge to upload merge records to s3

Companion to https://github.com/pytorch/pytorch/pull/129503

@pytorchbot merge -f "mergebot changes"


Group all RealVectorStateSpaces together to improve performance

In #36 we switched away from a single RealVectorStateSpace to a CompoundStateSpace to support continuous joints. @cdellin pointed out that this introduces a considerable amount of overhead and @mklingen found that the overhead causes a significant performance degradation on the RRT.
We should group all of the RealVectorStateSpaces together to improve performance when planning with non-continuous joints.

One thing I'm concerned about is keeping the order intact while also compressing as many DOFs as possible into a single state space. If we have a robot that has continuous->limited->continuous->limited->... for instance it should be merged into a single RealVectorStateSpace plus some number of SO2 state spaces, but I need to be careful to keep the order intact. Shouldn't be too difficult.

try this one https://github.com/personalrobotics/or_ompl/pull/40


Remove default commit message from stage_all_files_and_commit

Update usage to explicitly pass 'Inital commit'
Update tests

The unittests pass. I couldn't get the system tests to run.

Fixes CGP-19, which has been on my backlog for a while now.

Coverage decreased (-0.02%) to 88.046% when pulling 7e87912e95f382c999d85134d6593aaae8c3e9ec on default-commit into 56fab012d81663b49066000a4b249019cad94004 on master.

Hold on, why couldn't you get the system tests to run?

I get this:
Traceback (most recent call last):   File "push_required_repos.py", line 6, in <module>     from dls_ade import Server ImportError: No module named dls_ade
I can fix that by adding the full path to the dls_ade egg to the PYTHONPATH, but the I get
Traceback (most recent call last):   File "push_required_repos.py", line 6, in <module>     from dls_ade import Server   File "/scratch/work/common/python/RHEL7-x86_64/dls_ade/prefix/lib/python2.7/site-packages/dls_ade-0.0-py2.7.egg/dls_ade/__init__.py", line 1, in <module>     from gitoliteserver import GitoliteServer as Server   File "/scratch/work/common/python/RHEL7-x86_64/dls_ade/prefix/lib/python2.7/site-packages/dls_ade-0.0-py2.7.egg/dls_ade/gitoliteserver.py", line 8, in <module>     from dls_ade.gitserver import GitServer   File "/scratch/work/common/python/RHEL7-x86_64/dls_ade/prefix/lib/python2.7/site-packages/dls_ade-0.0-py2.7.egg/dls_ade/gitserver.py", line 5, in <module>     from dls_ade.vcs_git import Git, git   File "/scratch/work/common/python/RHEL7-x86_64/dls_ade/prefix/lib/python2.7/site-packages/dls_ade-0.0-py2.7.egg/dls_ade/vcs_git.py", line 3, in <module>     import git ImportError: No module named git
I discussed this with @skyfrench at one point. She managed to get it to work without the require("git") in vcs_git and removed it, but I can't remember what the fix was.

Well, let's get the instructions adequate...

Agreed. I have put in an issue.

Will need some investigation to work out what is causing the instructions not to work for Gary. The instructions work for me when followed on both my old and new linux workstations (both RHEL6), so it's not repeatable everywhere.

I've run the system tests - just one test fix needed (and the repo_test_num.txt file wasn't up to date for the start_new_module tests).

Could you try with the updated setup_testing_environment.sh script I've just committed? I logged into your workstation and reproduced the errors you were getting. I then got it to run after modifying the bash setup script to setup the path more explicitly. The new script still works on my machine too. I don't however understand why it needs the egg files explicitly in the path ...

@GDYendell, you should be able to rebase on master now and then we can merge this.

Only (13/29 of) the tests on start-new-module fail now.

All of the system tests seem to be passing on the python3_wsystests branch now. However, it is by no means obvious why the ones on this branch are failing still.
I talked briefly to @MJGaughran about the system tests. At the moment they are a bit of a burden. Also, at some point we will be moving to a different server and some of them will break as a result. I guess either:

we ditch them altogether
someone (possibly Gary and Martin as the original authors (?)) take a bit of time to get rid of the more brittle ones and understand what features would be useful and how to make the tests more robust

But let's not hold up everything because of that.


Use pintrest_description field for meta_data.description in RawPixel.py

We're currently not making a meta_data field for the RawPixel provider.  We should consider whether pulling the pintrest_description field from the json for an image would make a good description meta data field.

Blocking this till the rewrite for RawPixel is done.

Hey, @mathemancer when would be #256 be completed? I wanted to start on this if possible.

@Nikitag0329IITkgp I think that one should be sorted by #321 in the relatively near future (it's still in the review / cleanup process).  You can follow the progress of that PR, if you'd like to.

@mathemancer Why is this blocked? #321 seems to be completed. If possible can I work on this?

@dravadhis I think you're correct.  I'll unblock the issue.  Please make sure not to take too many things onto your plate at once :smiley:

@dravadhis I think you're correct. I'll unblock the issue. Please make sure not to take too many things onto your plate at once

I will make sure to tackle them one at a time so that I don't mess up things. Thanks for your guidance.

@mathemancer While going throught the script raw_pixel.py I found that the _get_foriegn_id_url function checks if the image is CC0 licensed or not by using if image.get('freecc0'):.

However this seems unnecessary to me because while making the request to get the list of images, freecc0: 1 is passed as a query parameter in the _get_image_list function.

Please clarify if it is required for some other reason. If not should I remove it here or make a new issue for the same?

Also the pinterest_description that is returned has character entities like /" or &ndash in the description (for e.g.  ...by Joseph August Knip (1777–1847)... This may be because the default responses are meant to be HTML. Should this be handled to display the symbols they are meant to or left as it is?

@dravadhis You can leave it as-is.  It's not actually displayed, but rather used for search indexing.
For the CC0 redundancy, I think we should leave it in for the moment.  It's not hurting anything (performance is a non-issue, since we're limited by a rate limit on the API, not by processing speed), and it may have been added for some reason (perhaps there is some bug resulting in non-CC0 images being returned even when the flag is given in the Query String Parameters).


chore: initial node fork

nothing here until we eventually patch everything

I am going to close this one, since @juliemr is working on proper Node.js support now.


Adding an auto index page.

Description & motivation
Leveraging a new docusaurus feature for adding landing pages (that are auto-generated) to certain places in the docs.
To-do before merge
@JKarlavige I don't quite understand what magic is going on with the styles to make this new page looks so bad. This is just experimental FWIW.
Here's the link to the page with the changes.
Pre-release docs
Is this change related to an unreleased version of dbt?

[ ] Yes: please

update the base branch to next
add Changelog components: <Changelog>[New/Changed] in v0.x.0</Changelog>
add links to the "New and changed documentation" section of the latest Migration Guide

[x] No: please ensure the base branch is current
[ ] Unsure: we'll let you know!

Checklist
If you added new pages (delete if not applicable):

[ ] The page has been added to website/sidebars.js
[ ] The new page has a unique filename

If you removed existing pages (delete if not applicable):

[ ] The page has been removed from website/sidebars.js
[ ] An entry has been added to _redirects

@runleonarun Nice catch! Fixed the blog header card and added back the blue styling for cards. I have one more build running which will have the cards at the original blue and then darker on hover.

@JKarlavige It looks GREAT! Thank you!


Add more supported models

Hi!
Can you add the SP14S004 (50A) to the compatibility list? I use it and it definitely works.

@Benni1123 Could you create a new issue and mention your device is working properly? I don't want to reference this MR at the README.


Update MD file on new branch 2017-11-14_04-25-41

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


File previous name is inconsistent with name

https://github.com/OTRF/OSSEM-CDM/blob/dacbc880b04e9b8ca0ae07b42614c1e0f9bcc8bf/schemas/entities/file.yml#L103
previous_name includes path, while name does not. I suggest adding previous_path.

Hey @oshezaf @Cyb3rWard0g Hope you guys are doing well. Here some ideas about this issue 😃
I think we have two options:

Modifying previous_name to previous_path
The schema will consider this structure: file_name, file_path, file_previous_path
Modifying previous_name to previous_path AND Adding previous_name
The schema will consider this structure: file_name, file_previous_name, file_path, file_previous_path.

I would go with the second one. Even though it may involve more pre-processing of data to get the previous_name, it provides a complete schema.

Weekend here and already the summer break.... i will probably get to that Aug 29th or so.

https://github.com/OTRF/OSSEM-CDM/commit/c55ba06b14198f66c8755f5a738e496e61a9b8af


Change the way Queue and Stack add elements

Make it so it works like the Linked List ones, with pointer to pointer of a node

Add remove function to Queue


High GPU usage in editor

Godot version:
Godot v3.1.1
OS/device including version:
Windows 10 Pro 1809 (build 17763.805)
Intel(R) UHD Graphics 620 (driver version: <IP_ADDRESS>35)
NVIDIA GeForce MX150 (driver version: <IP_ADDRESS>15)
Issue description:
Running Godot on the dedicated Intel GPU

I have a 2D scene with a node with few sprites. When that tab is open and displayed on the screen the GPU usage increases from 0 to 30-40% (even if I have the program running in the background). The update spinner is constantly spinning.
If I switch to other tab the GPU usage drops back to 0 and the update spinner works fine.

I deleted the node with the sprites and created it back as it was before and everything works fine.
The GPU and spinner update works normal.

EDIT
I found the reason:

All of this is happening when I have selected VBoxContainer or TextureRect in the scene menu.

Steps to reproduce:
Just select TextureRect or VBoxContainer in editor.
Video Capture: https://imgur.com/a/XqupVCm
Old video capture: https://imgur.com/a/4uDq1VN

I updated the original issue.
Added: reason and steps to reproduce.

Running Godot on the dedicated Intel GPU

It's either an integrated Intel GPU, or a dedicated NVIDIA GPU :slightly_smiling_face:

You're running Godot on either an integrated Intel GPU, or a dedicated NVIDIA GPU 🙂
Dedicated NVIDIA GPU. I change it now, sorry 👼
Can you reproduce this on 3.2alpha3?
I just tested. This issue doesn't exist in 3.2alpha3

I just tested. This issue doesn't exist in 3.2alpha3

If it is fixed in the master branch, then this issue should be closed because 3.2 designed to replace 3.1.1 in the near future.


Adds 'teams meeting get' command. Closes #3900

Adds teams meeting get command. Closes #3900
Needs additional permissions OnlineMeetingArtifact.Read.All and OnlineMeetings.Read.All

Great job with the PR @nanddeepn 🚀
@waldekmastykarz could you add the following permissions to the app: OnlineMeetingArtifact.Read.All and OnlineMeetings.Read.All

Merged manually, thank you! 👏

@waldekmastykarz PR is merged
Could you add the new needed permissions OnlineMeetingArtifact.Read and OnlineMeetings.Read to the app registration please?
Much appreciated!


Redo CI to test mysql 5.7, 8.0, and mariadb on macOS and Ubuntu

Leverage the matrix strategy feature of GitHub workflows to generate 9 different tests:

mysql 8.0 on xenial, bionic, macos
mysql 5.7 on xenial, bionic, macos
mariadb latest on xenial, bionic, macos

Uses Homebrew to get a local MySQL server on macOS.

Seems like we're actually broken on MariaDB at the moment - whether that's our fault or theirs I have no idea.

Related to https://github.com/vapor/mysql-nio/issues/21. We should add these CI improvements there, too.

Closing this out; it is now superseded by the CI changes made as part of #176


Someone’s Been Messing With My Subnormals!

URL
https://moyix.blogspot.com/2022/09/someones-been-messing-with-my-subnormals.html
When was this post released
Sept 6th, 2022
Summary
Fast math compilation options lead to incorrect floating point math results. When you use gcc to compile, you can use an option to ask it to drop precision to speed up the compilation, but when the shared library is loaded it also sets a CPU flag to use less numerically precise methods for speed. This flag should only be set during compilation, and not carry to the produced code. The linked blog post investigates packages on pip and found 2500 packages that exhibit the degraded numerical precision if complied fast.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thanks for contributing this story! I've reworded the text to match the style of other items a bit but included the original copy below:

Fast compilation option -> Incorrect math?!
Note this is technically broader than Python, but this blog post used packages from pip to demonstrate the vulnerability.

When you use gcc to compile, you can use an option to ask it to drop precision to speed up the compilation. Sounds reasonable, but what happens is that when the shared library is loaded when the package it also sets a CPU flag to use less numerically precise methods for speed. This should not happen as the flag should only be set during compilation, and not carry to the produced code. The blog post linked above investigates packages on pip and 2500 packages (some with more than 1 million downloads a month) can exhibit the degraded numerical precision if complied fast.
It's a fairly niche case, but if you compile packages from source, it's a fun edge case to avoid :)


Latest DJL dependencies cause incompatibility for PyTorch in MacOS x86_64

DJL versions >= 0.29.0 doesn't support PyTorch for MacOS x86_64.
Additional context: https://github.com/spring-projects/spring-ai/commit/df17f08f5b7c22b31ac73893b90d621180856774#commitcomment-146828827

Checking DJL documentation, they added a comment about this topic here.

Thank you for checking it out.
Looks like DJL is not going to try to provide some form of backward compatibility for  MacOS x86_64.
The explicit downgrading to 0.28.0 seems to be the only workaround i can think of. Thanks for confirming it works.
I'm coping it here for are reference. Perhaps we can add it to the Spring Ai docs as well:
		<dependency>
			<groupId>org.springframework.ai</groupId>
			<artifactId>spring-ai-transformers-spring-boot-starter</artifactId>
			<exclusions>
				<exclusion>
					<groupId>ai.djl.pytorch</groupId>
					<artifactId>pytorch-engine</artifactId>
				</exclusion>
				<exclusion>
					<groupId>ai.djl</groupId>
					<artifactId>api</artifactId>
				</exclusion>
				<exclusion>
					<groupId>ai.djl</groupId>
					<artifactId>model-zoo</artifactId>
				</exclusion>
				<exclusion>
					<groupId>ai.djl.huggingface</groupId>
					<artifactId>tokenizers</artifactId>
				</exclusion>

			</exclusions>
		</dependency>

		<dependency>
			<groupId>ai.djl.pytorch</groupId>
			<artifactId>pytorch-engine</artifactId>
			<version>0.28.0</version>
		</dependency>
		<dependency>
			<groupId>ai.djl</groupId>
			<artifactId>api</artifactId>
			<version>0.28.0</version>
		</dependency>
		<dependency>
			<groupId>ai.djl</groupId>
			<artifactId>model-zoo</artifactId>
			<version>0.28.0</version>
		</dependency>
		<dependency>
			<groupId>ai.djl.huggingface</groupId>
			<artifactId>tokenizers</artifactId>
			<version>0.28.0</version>
		</dependency>

Nothing to resolve on Spring AI side. Please use the https://github.com/spring-projects/spring-ai/issues/1371#issuecomment-2358364212 instructions to downgrade the dependencies if neeed.


property.setter problem / Python 2.5

From<EMAIL_ADDRESS>on 2010-06-24T21:55:27Z
What steps will reproduce the problem?

Install spyder-1.1.0_py25.exe

Run spyder.py What is the expected output? What do you see instead? Spyder stops with following message.
-----------------------------------------------------------------------
Traceback (most recent call last):
File "C:\Python25\Scripts\spyder.py", line 2, in <module>
from spyderlib import spyder
File "C:\Python25\lib\site-packages\spyderlib\spyder.py", line 60, in <module>
from spyderlib.plugins.projectexplorer import ProjectExplorer
File "C:\Python25\lib\site-packages\spyderlib\plugins\projectexplorer.py", line 20, in <module>
from spyderlib.widgets.projectexplorer import ProjectExplorerWidget
File "C:\Python25\lib\site-packages\spyderlib\widgets\projectexplorer.py", line 94, in <module>
class Project(object):
File "C:\Python25\lib\site-packages\spyderlib\widgets\projectexplorer.py", line 119, in Project
@relative_pythonpath.setter
AttributeError: 'property' object has no attribute 'setter'
----------------------------------------------------------------------- What version of the product are you using? On what operating system? PC1: Windows XP sp3 (x86), python2.5.2
PC2: Windows 7 (x64), python2.5.4

Please provide any additional information below
. spyder_1.1.0beta5_py25.exe and spyder_1.1.0beta7_py25.exe worked fine.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=243

From pierre.raybaut on 2010-06-25T09:56:23Z
Fixed here: https://code.google.com/p/spyderlib/source/detail?r=eb25ecd1938e4034a85b7697afbd2ff7e24fa168&repo=v11
Status: Fixed

From pierre.raybaut on 2010-06-25T01:20:36Z
Damned, this feature (property's attribute "setter") has been introduced in Python 2.6....
I'll fix this as soon as possible.
In the meantime, you may disable the Project Explorer plugin. Edit the file .spyder.spyder.ini in your Home directory: search for project explorer section, and write "False" instead of True in option "enable".
Thanks for the report.
Summary: property.setter problem / Python 2.5
Status: Accepted
Labels: -Priority-Medium Priority-HIgh


Add a header?

I naively tried to add a header to a webpage by using H1, H2 etc. and all of the text is the same size. Are these outdated concepts?
Should I use Tailwind instead like this? My only problem with this is I'm unsure how to pick a font size in absolute pixels that will be an appropriate header.
P(text='Hello World!', style=f'font-size: 30px')

Tailwind overrides the default h tags styles.
I would recommend using one of the tailwind classes for font size:
https://tailwindcss.com/docs/font-size/
The appropriate font size is a design issue. Try experimenting with the different tailwind classes and go with the option that you like best.


Cannot open include file: "opencv2/opencv.hpp": No such file or directory

I follow the instruction as below:
To compile on Windows open yolo_mark.sln in MSVS2019, compile it x64 & Release and run the file: x64/Release/yolo_mark.cmd. Change paths in yolo_mark.sln to the OpenCV 4.1.0 installed on your computer:
(right click on project) -> properties -> C/C++ -> General -> Additional Include Directories: C:\C:\Opencv\opencv-4.1.0\opencv-4.1.0\include
(right click on project) -> properties -> Linker -> General -> Additional Library Directories: C:\Opencv\build\x64
but the error still appear

I think you got your directories wrong. Check your opencv directories.
(right click on project) -> properties -> C/C++ -> General -> Additional Include Directories:  your opencv dir\build\install\include
you should have the file "opencv.hpp" within  your include directory
(Linker) your opencv dir\build\install\x64\vc16\lib
you should have the "lib" files within your linker directory.
With these out of the way, I'm stuck with:

I think you got your directories wrong.
With these out of the way, I'm stuck with:

solved by copying the dll into the same directory


fix db memory data race

see ticket https://github.com/hyperledger-labs/fabric-smart-client/issues/276
Signed-off-by: Mathilde Ffrench<EMAIL_ADDRESS>

@mffrench , please can you add a unit-test to check that the race condition is gone? Thanks :)

@adecaro : would love to add such tests but need to rush on our app stack now :/ Currently only test for me to validate we don't get that datarace again is on our app stack...
Regarding tests validating no more datarace, we should handle all func available from db interface, run them in appropriate way in several go routine and test it against memory driver or other one and ...

what I don't get is why there was a race condition before. Can you explain the rational of your changes, please?


Reconcile az aro with Azure/azure-cli

Which issue this PR addresses:
Reconcile some changes that should've been in upstream az aro extension but were only in downstream (Azure/azure-cli)
What this PR does / why we need it:
Same as above
Test plan for issue:
N/A
Is there any documentation that needs to be updated for this PR?
No

/lgtm


DisableAll option is not exist actually, but seemed in README

"DisableAll": true is written in README as example of configuration file but no code like reading the property seemed.

Yes, from what I can tell just using a config always effectively triggers a DisabledAll. The key is ignored.

Fixed so I close here. Thank you!


How do I access the pool of knex?

I'm using fastify and trying to set up session handling with connect-pg-simple. The docs for this module say that I can create the session store object passing

pool - The recommended one – Connection pool object (compatible with pg.Pool) for the underlying database module.

Can I access the pool object of knex to pass it to the connect-pg-simple constructor?
Essentially, I would want something like:
store: new pgSession({
    pool : knex.pool, // how do i access the pool?
    tableName : 'user_sessions'
  }),

knex.client.pool
I'm not sure about connect-pg-simple, but beware that some libraries (such as node-postgres) have their own pool. But it seems as though using pools other than the knex/tarn one is discouraged.

@officer-rosmarino , in the same boat right now. Did you ever figure it out? Accessing .client.pool throws an exception this.pool.query is not a function. I assume this is due to connect-pg-simple expecting to operate on the pg pool, not the wrapped object from knex.

Knex isn't using pg.Pool under the hood, but a pool based on tarn.js. So it won't be possible to straight up get the pg.Pool from Knex, as that doesn't exist.
So I think the only way to go about this is to write (or find) a wrapper around knex.client.pool that's compatible with pg.Pool.

I had a similar issue with LangGraph and decided to publish an adapter to enable using knex like a pg.Pool:
https://github.com/patrick-petrovic/pg-pool-adapter
It supports the basic query/connect API which should be enough for most applications.


adding T1w fsLR surfaces to ciftify output

This need two steps -

add --resample-to-T1w32k flag to ciftify run

change cifti-parcellate scripts to use /T1w/fsaverageLR32k/ surfaces instead of /MNINonLinear/fsaverage32k surfaces when calculating surface area and volume.

Done.


Url encode values which are used in the query for views

Lets say I want to query a view using this code:
$key = 'some_key';

$query = \CouchbaseViewQuery::form('my_document', 'view_name', array(
    'key' => $key,
    'limit' => 1,
));
$bucket->query($query);

This will work without problem. Now, if I change $key to 'some&key', I get the following error:
{
    "error": "bad_request",
    "reason": "invalid UTF-8 JSON: {{error,insufficient_data},\"\\\"some\"}"
}

This is caused by the query parameter values which are not urlencoded. My PR fixes that.

nice +1

sweet +1

Any chance you can review and merge this, @brett19 ?

I need this change to

This change was incorporated through other fixes to the SDK.


Feature Request - Tagging releases on hub.docker.com

Perhaps having an entirely different image name for each architecture would be better than having one image with different tags for architectures.  The result would be the ability to use the tags for version numbers.
Like this:

its/minecraft-server (for x86)
itzg/minecraft-server-rpi3:latest
etc

Then within those a tag for the version number with latest being the most recent version.  You could then split your different architectures out on GitHub as well each with versioning and releases there.

I like that idea. I think I would need to move away from doing the build on Docker Hub to pull that off. That’s quite doable since I do some other app image builds directly on CircleCI.
The manifest associated with the “multiarch” tag actually auto adapts to the host platform. I need to improve the automation of updating that tag.


tiller is deprecated in version 3 and also the install command is changed

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thank you @ashwinkumar12345. The changes look apt.


Migrate NPS response data into KPI database in BigQuery

Migrate our NPS response data from cloud datastore to the main Key Performance Indicator metrics database in BigQuery. This is needed for two things:

Driving a dashboard of our key success metrics:

Total NPS interactions (overall, by month)
NPS response rate (overall, by month)
Avg response score (overall, by month)
Number of promoters (those who answered 9 or 10), neutrals (7 or 8), detractors (0-6)
NPS (overall, by month)

Creating cohorts of 'Promoters', 'Neutrals', 'Detractors' and looking for different usage/experience patterns among these cohorts.

This process can be manual or automatic, but we should be able to migrate these data at least once per week, without an excessive drain on developer productivity

Reviewing and finishing a PR (https://github.com/broadinstitute/workbench-analytics/pull/6) that will add Rex to the nightly Jenkins job that will pull from Datastore and import to BQ.

Data has been migrated to prod! Pending final review of Jenkins PR but this is just about complete and unblocks #1122 and #1123.


Add documentation in code

Fairly self explanatory

Hi, I am interested in this issue

Feel free to submit a PR. Make sure you use JSDOC comments and have at least the summary and param fields filled in for each method.


NOISSUE - UI Group fix

Signed-off-by: Filip Bugarski<EMAIL_ADDRESS>What does this do?
Which issue(s) does this PR fix/relate to?
Put here Resolves #XXX to auto-close the issue that your PR fixes (if such)
List any changes that modify/break current functionality
Have you included tests for your changes?
No
Did you document any new/modified functionality?
No
Notes

Codecov Report

Merging #1515 (7014c5b) into ui (c9d3664) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##               ui    #1515      +/-   ##
==========================================
- Coverage   65.51%   65.50%   -0.02%
==========================================
  Files         136      136
  Lines       11214    11216       +2
==========================================
  Hits         7347     7347
- Misses       3272     3274       +2
  Partials      595      595

Impacted Files
Coverage Δ

ui/api/endpoint.go
0.00% <0.00%> (ø)

ui/api/transport.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9d3664...7014c5b. Read the comment docs.


calcHazWaste.R progress

Cleaned some functions, created functions for downloading and prelim processing on the RSEI model data.

Linking issues through the Development option in the sidebar makes it so that the PR will close the issue then you merge it, which is not what we want.
To link an issue to a PR without closing it I think we just use #25


fix: fix prefix-only modules not marked as builtin

Following @ljharb's feedback in https://github.com/import-js/eslint-import-resolver-typescript/pull/295#issuecomment-2231939714, a different version of isBuiltin function has been implemented.

This will still be a false positive on a node version that lacks the builtin module - node:sqlite before node 22.5, for example.

Block for now, I still prefer porting Node.js implementation:

it just checks if the module id is in the lists, very similar to what is-core-module does
https://github.com/nodejs/node/blob/e0e0b1a70ebf2b7c6c384771e3f746e9236c4737/lib/internal/bootstrap/realm.js#L293-L299

@SukkaW the problem is that node doesn't expose which core modules exist at runtime, so to do it without is-core-module, you'd need to require.resolve it inside a try/catch or similar, which has a much larger runtime impact than dozens of dependencies, let alone 1-3.


So how to generate

I guess need to run some kind of command to generate java code, the doc only said change xml and gradle files, I doubt java code can be generated just because of changing gradle and xml files

While using this plugin, you will find a task named mbGenerator and then it will generate what you need.
You can refer to the integration test.


Use youki libcontainer crate for all shims

The work in #78 enabled youki's libcontainer for the WasmEdge shim.
The Issue #110 intents to repeat the same work for the wasmtime shim.
During #78, @rumpl 's comment mentioned that we could enable youki's libcontainer in a lower level in runwasi, so that all shims can benefit from it.
Any thoughts?

I did try to use libcontainer functions for adding support for OCI devices and seccomp. The seccomp code is at https://github.com/ipuustin/runwasi/commits/seccomp and the devices code is here: https://github.com/ipuustin/runwasi/commits/oci-devices. My finding was that libcontainer can very well be used on this level, but it is a lot of effort and will bring a lot of duplicated code to runwasi. I mean, the seccomp code I needed to add in the seccomp branch alone is hundreds of lines of code, a lot of it unsafe.
However, what would make sense IMHO would be to go through the libcontainer initialization code and figure out what exactly is needed for running Wasm/WASI modules securely. For example, do we really need a PID namespace if the Wasm module will not even have the concept of a process? Or does it make sense to have the Masked Paths OCI feature, if we anyway control precisely which files are available? If the result of this study is that the optimal Wasm initialization path is a lot different from traditional container initialization, we might want to contribute to libcontainer a different way for loading the container, or maybe just do it using the lower-level primitives as you suggest.
I'm myself curious to what we could do in runwasi shared mode using just threads for running the Wasm VMs -- would we get anywhere close to a working "container"?

Most of the seccomp code is in containerd-shim-wasm (see https://github.com/ipuustin/runwasi/commit/78c3c4d9e3eef9d04e0835e81576de96fc62b41b). It's just being called from the WasmEdge and Wasmtime shims. The reason there needs to be some code in shims is that the open FD for seccomp notification needs to be passed over socket to main process and then to the external notifier process.

However, what would make sense IMHO would be to go through the libcontainer initialization code and figure out what exactly is needed for running Wasm/WASI modules securely

The main thing here is we are using linux containerization as an extra boundary, plus it also helps wasm play nicely with other linux containers/processes.

I'm myself curious to what we could do in runwasi shared mode using just threads for running the Wasm VMs -- would we get anywhere close to a working "container"?

Primarily we can't use memory cgroups with threads.
There may be some other things (such as pid namespaces) that just don't make sense in a threaded mode as well.

I have implemented the integration with libcontainer on both the wasmtime shim and the spin shim (see this PR). I've seen a few places where there are a lot of duplicate code blocks that could be moved into the containerd-shim-wasm crate, thus requiring an explicit dependency on libcontainer.
Implement the libcontainer::workload::Executor trait
This is provided by libcontainer to implement any container runtime as an executor. For example, in the spin shim, I had to implement exec() function to get the Wasm module path and then invoke wasmtime API to call this module. I believe this is handled similarly in the WasmEdge shim. In the spin shim, I built spin triggers and then run the spin trigger with spin manifestation file found on the rootfs.
This trait is REQUIRED to be implemented by any shim author. Thus I believe it's reasonable to expose this trait in the containerd_shim_wasm::sandbox::Instance trait to inform it how to build a youki Container instance.
kill, delete and wait all should have a default implementation
The code for Instance::kill / delete / wait are all the same. They invoke the respective Container APIs given self.id, self.exit_code and self.rootdir. I think we can provide them default implementation in the Instance trait itself.
start has the same procedure
The Instance::start() function has a very similar sequence of steps to start a container. It first builds a container by providing it its std I/O, and Wasm runtime. Then it calls container.start() to start the container. Finally it spawns a thread to handle the exit of the child process, and notify the condition variable which is waiting in the set_up_exit_code_wait() function.
I believe this entire thread code could be abstract away and be provided as a default implementation.
What do y'all think?

Tha ks for the analysis, it's very useful. I'm all in for moving as much as possible into containerd-shim-wasm and simplify writing new shims.
Do you know if there is any incompatibility between the way libcontainer does things and the daemon based shim?


fix(deps): add mkdirp to package.json

Motivation
mkdirp is used throughout the project.
This currently works because npm and Yarn create flat node_modules.
Docusaurus fails though with pnpm, which creates a strict
node_modules.

@zkochan Thanks for catching this!