Resque_Job::create() ignores return value of Resque::push

Line 71 in Resque_Job. If Resque::push returns false, you should throw an exception or something. Now you are just going on as nothing is wrong - but the job is not stored to the queue.
json_encode() fails because we had bytes in the string, I think. That is our problem... but your problem is that Resque did nothing, and the jobs is just gone...

 I think you should do something like this.
https://github.com/jasverix/php-resque/commit/8a6b3aa040941950ea870d930aea0fe803f7eeca

We have discussed this issue a large number of times, with several PRs addressing it.

I'm not the project maintainer, just a user who knows the project pretty well. But setting aside the very rude response, here - I'm sorry you've spent so much time making changes that have already been suggested, but that's not a reason to lash out at volunteer devs on a project nobody pays for - a review of the time between the latest tag and the present, a look through the existing issues and pull requests, and even a look at time between the most recent commits to master, would clearly indicate this project isn't being maintained at the level you appear to expect. This is a fairly important consideration to make before deciding to use it in projects of your own. I might suggest investigating other queue engines (the Laravel project has one that works very similarly to PHP-Resque) if your project relies on active dependencies.

I am sorry, had a long and quite frustrating day today.
As I said, I am in general very happy about this package. Thank you for the good job.
For our part it works good now, from my fork.


improve error message

When developing python plugin with a remote plugin engine, we cannot see much error information. This PR will improve the situation by sending traceback stack to ImJoy.

Note that this PR will have merge conflict with https://github.com/oeway/ImJoy-Engine/pull/30.

Should me merge #31  first, I can comment on #31 and we can then cancel this one.

Do you mean merge #30 first?

Yes, a quick question, this PR aims to pass all necessary error information to the ImJoy web interface, we can either directly pass traceback.format_exc() to the frontend, or if there is better way to send more error information, we can also send an dictionary with for example, error name, line number, traceback etc to ImJoy, we can then pass the error information to show in the ImJoy interface. Potentially, we can highlight the error line in the plugin code editor, and this will help a lot for debugging.

Test code:
from imjoy import api

def lumberjack():
    bright_side_of_death()

def bright_side_of_death():
    return tuple()[0]

class ImJoyPlugin():
    def setup(self):
        api.log('initialized')

    def run(self, ctx):
        lumberjack()

api.export(ImJoyPlugin())

The traceback sent to the front end was:
Error: Traceback (most recent call last): File "/Users/weiouyang/workspace/ImJoy-Engine/imjoy/imjoyUtils3.py", line 60, in task_worker result = method(*args) File "<string>", line 15, in run File "<string>", line 5, in lumberjack File "<string>", line 8, in bright_side_of_death IndexError: tuple index out of range

This is generated by traceback.format_exc(), we just need to remove second line and replace File "<string>" to Plugin "{PLUGIN_NAME}", such that we will get:
Error: Traceback (most recent call last):
Plugin "{PLUGIN_NAME}", line 15, in run
Plugin "{PLUGIN_NAME}", line 5, in lumberjack
File "<string>", line 8, in bright_side_of_death
IndexError: tuple index out of range

A further improvement would be calculate the line number offset such that we will have the actual line number.


How automatically update JProgressBar?

I want to implement a download progress bar torrent file on the panel. to display the boot process using JProgressBar.
The question is how to take data from the Client that would automatically update JProgressBar.

Look at Client.java's info() method: https://github.com/mpetazzoni/ttorrent/blob/master/core/src/main/java/com/turn/ttorrent/client/Client.java#L443
It shows how to get the most up-to-date information about the progress of the download. You can use that to update your progress bar as often as you need to, but ttorrent isn't going to do that automatically for you (you can use a thread on the side to do that for example).
HTH

Thank you very much for taking the time to answer my question.
Please tell me the answer to another question.
how to increase the download speed of the file? I get that a torrent file
is the average size of up to 1 GB shakes on average 3 - 4 hours, but if you
use the conventional Torenth downloads 5 minutes. tell me how to increase
the speed?
2015-12-21 2:53 GMT+02:00 Maxime Petazzoni<EMAIL_ADDRESS>
Look at Client.java's info() method:
https://github.com/mpetazzoni/ttorrent/blob/master/core/src/main/java/com/turn/ttorrent/client/Client.java#L443
It shows how to get the most up-to-date information about the progress of
the download. You can use that to update your progress bar as often as you
need to, but ttorrent isn't going to do that automatically for you (you
can use a thread on the side to do that for example).
HTH
—
Reply to this email directly or view it on GitHub
https://github.com/mpetazzoni/ttorrent/issues/158#issuecomment-166169093
.

--
С уважением, Максим Джежело.
+38(095)-337-35-38


sbt-tpolecat is conflict with scalafix

scalafix has to use -Ywarn-unused for removing the unused things, but tpolecat uses -Werror. And conflict happens

Hi @UkonnRa, a lot of users use sbt-tpolecat because it ensures that code with warnings can't be committed. Could you potentially use something like the following to resolve this conflict?
scalacOptions.in(Compile, scalafix) ~= { options: Seq[String] =>
  options.filterNot(Set("-Werror"))
}

scalacOptions.in(Test, scalafix) ~= { options: Seq[String] =>
  options.filterNot(Set("-Werror"))
}

Cool! THX a lot!


[Database Request] Hollow Knight

APP_ID: 367520
WM_CLASS: "hollow_knight.x86_64", "hollow_knight.x86_64"
Icon Theme: Numix (Square)

Added. Should be fixable now.

it works, tyy


DataClassification property for table field

I am trying to figure out what values DataClassification can be set to for a table field, and what the values mean.
Clicking on DataClassification for "- Table" and " -Table field" leads me to a generic page with no help at all for this question.
Pretty basic requirement for help is to provide this type of info.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 79016d40-4bc6-49b0-4275-9641cf17071e
Version Independent ID: 79016d40-4bc6-49b0-4275-9641cf17071e
Content: Table, Table Fields, and Table Extension Properties - Business Central
Content Source: dev-itpro/developer/properties/devenv-table-property-overview.md
Service: dynamics365-business-central
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: solsen

Do you have recommendations for a support channel?  Any community sites or blogs I can search?

Looks like this commit broke the links https://github.com/MicrosoftDocs/dynamics365smb-devitpro-pb/commit/9d563b0aecd0d3f2baddfd83f89232c5129b084a

I am also looking for this documentation


inner-loop timeout

Note: Asked here: https://stackoverflow.com/questions/65173084/timeout-and-skip-a-block-of-code-inside-a-python-iteration
How can I skip and continue when a step of a loop takes too long?
Below are a few desirable interfaces I'd like:
for x in some_collection:
    with Timeout(2.5):  # time out after 2.5 seconds
        do_something(x)

Would be nice (and even better -- but might be harder):
with TimeoutLoopStep(2.5):  # time out after 2.5 seconds
    for x in some_collection:
        do_something(x)

Possibly an equivalent timeout_loop_step decorator to consume iterators in that manner:
timeout_loop_step(2.5)(map(do_something, some_collection))

The following (based on SO answers) doesn't do the job since this Timer thing just "Call a function after a specified number of seconds". What we want is a means to "interrupt the call of a function after a specified number of seconds".
from threading import Timer

class Watchdog(Exception):
    def __init__(self, timeout, callback=None):  # timeout in seconds
        self.timeout = timeout
        self.callback = callback if callback is not None else self.raise_self
        self.timer = Timer(self.timeout, self.callback)

    def __enter__(self):
        self.timer.cancel()
        self.timer = Timer(self.timeout, self.callback)
        self.timer.start()
        return self

    def __exit__(self, *args):
        self.timer.cancel()

    def raise_self(self):
        raise self

def wait_and_return(x):
    time.sleep(x)
    return "computed"

def callback():
    print('callback is being called')
    return "timedout"

r = None
with Watchdog(1, callback):
    r = wait_and_return(0.5)
assert r == 'computed'

Another solution route: https://stackoverflow.com/questions/492519/timeout-on-a-function-call

Timeout on code execution:

https://stackoverflow.com/questions/492519/timeout-on-a-function-call
(https://pypi.org/project/func-timeout/, untried)

Python and functional programming
The advice from the core team on how to do functional programming in Python:

https://docs.python.org/3/howto/functional.html


plausible: do not use generated yarn.nix

Motivation for this change
I just became aware that yarn2nix does not require a yarn.nix file. If not provided it will just generate it from the yarn.lock file.
I tested on plausiblle and it build without a problem.
the yarn.nix file is 8k lines.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[X] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Ok, this seems to be rejected by hydra, so this is probably using IFD then.
I will close this for now.


Plotting Digital Logic Lines

How can set custom point in x-axis for plotting digital logic lines?
the entry data should be something like this (x,y) and labels should set customize by x-axis but I don't know how?
current:

should be:

This is not supported, technically you can't have 2 y values for 1 x


No docs about the toolchain needed

There are no docs about what toolchain is needed to build this stuff. Could we get some.. i just tried GCC 6 and vbcc ... neither work.

Stuff means specifically systest I imagine. I have not ported this to bebbo's amiga-gcc yet, instead it uses m68k-elf gcc toolchain to generate a binary blob which then gets Amiga hunk info slapped on by a script.
Specifically, try binutils 2.28 and gcc 7.1.0 configured for target m68k-unknown-elf.

Instructions added to the main README.


Improve trim method to accept color to be cut off and hor/ver alignment options

Hi,
The PR looks very good. Please make a few things, and I'll merge it:

Make all arguments after threshold optional. Just check that they're not empty before parsing. You can look at applyWatermarkOption as an example.
Make Smart true by default. Make it false if a user sets a custom color.
Add documentation for the new arguments.

Make all arguments after threshold optional. Just check that they're not empty before parsing. You can look at applyWatermarkOption as an example.
It seems to me that they are optional now: every check in applyTrimOption has a check if nArgs > N.

Make Smart true by default. Make it false if a user sets a custom color.
My bad, it's a bug after final refactor :(

Add documentation for the new arguments.
Will do.

Also, I hope you've checked C code thoroughly (although it's quit simple).

It seems to me that they are optional now: every check in applyTrimOption has a check if nArgs > N.

This only checks that argument doesn't exist but doesn't check if it's empty. For example, it's currently not possible to do something like this trim:::1 (skipping the first two args).

Also, I hope you've checked C code thoroughly (although it's quite simple).

Yep, LGTM

All done.

Thanks for your contribution again!


bypass original payload for kinesis publisher

add documentation and maybe rename method - up to you. otherwise LGTM


Improve AssemblyScript

My new results after improvments:
    SuperFastHash (js): 510.595ms
    ✔ 1,000,000 hashes
    SuperFastHash (wasm): 338.338ms
    ✔ 1,000,000 hashes
    MD5 (native): 4805.007ms
    ✔ 1,000,000 hashes
    SHA-1 (native): 4914.026ms
    ✔ 1,000,000 hashes
    SHA-256 (native): 6061.682ms
    ✔ 1,000,000 hashes
    RIPEMD-160 (native): 5946.572ms
    ✔ 1,000,000 hashes

Hey, thanks for the patch!
It does seem to speed up the WebAssembly version.

Could you update screenshot in readme? Pretty interesting how this improve results on your machine

I have updated the screenshot now.


Correction for raw affiliation CSC Victoria BC V8W 3R4; Centre for the Study of Globalisation and Regionalisation; Department of Political Science University of Victoria PO Box 3060 STN; University of Warwick Coventry, CV4 7AL, UK

Correction needed for raw affiliation CSC Victoria BC V8W 3R4; Centre for the Study of Globalisation and Regionalisation; Department of Political Science University of Victoria PO Box 3060 STN; University of Warwick Coventry, CV4 7AL, UK
raw_affiliation_name: CSC Victoria BC V8W 3R4; Centre for the Study of Globalisation and Regionalisation; Department of Political Science University of Victoria PO Box 3060 STN; University of Warwick Coventry, CV4 7AL, UK
new_rors: 01a77tt86;04s5mat29
previous_rors: 01a77tt86
works_examples: W2232199713
contact: b5673c7dc636cc1ea06c9ffa3363ae55:15c8825d @ ourresearch.org

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


Clarified pearson correlation return value

As title. It wasn't obvious to me (by the docs) that this function returned two values. It's return value doc format also didn't seem consistent with the other functions in the library.

@@            master   #6081   diff @@
======================================
  Files          238     238
  Stmts        43863   43863
  Branches      8218    8218
  Methods          0       0
======================================
- Hit          34295   34293     -2
- Partial       2602    2603     +1
- Missed        6966    6967     +1

Review entire Coverage Diff as of 5f9a9c2

Powered by Codecov. Updated on successful CI builds.

Merged, thank you @hlin117! And congrats with what I believe is your first scipy commit. Keep them coming :-).

Thanks @ev-br! Yes, it is my first scipy commit. I'm happy to have contributed to scipy.


Fix int overflow in EditorResourcePreview::_preview_ready

Fixes #31232
to_int() function cannot be used for uint32_t because they have different scope of values
int32  -2,147,483,648 <-> 2,147,483,647
uint32_t 0 <-> 4,294,967,295

Thanks!


XSS Vulnerability on the Guestbook example for php-redis

Someone reached out to me about this possible path of exploitation through XSS on this part of the code:
https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/blob/master/guestbook/php-redis/guestbook.php#L39
$_GET here is not recommend, since you could override any value just by guessing a key, or setting arbitrary keys.
The recommendation I make it is maybe to do an API endpoint?

Hi @gabidavila.
First, thanks for bringing up this concern!
I realize that it's been a long time since you reported this issue — so I'm sorry to make you jog your memory back so far.
Here's a refresher:

This sample app just keeps track of a list of names (a guestbook).
It comprises of:

an AngularJS webpage;
a PHP guestbook.php HTTP endpoint; and
a Redis key-value database.

The guestbook names are stored in the Redis key-value database, under the messages key like so: "Katy Perry, John Lenon, Paul McCartney".
The a PHP guestbook.php HTTP endpoint allows for retrieval and modification of values at any key — not just the messages key.
The AngularJS webpage talks to the guestbook.php endpoint to save and retrieve names (the guestbook).

If possible, could you please elaborate on what you mean by:

The recommendation I make it is maybe to do an API endpoint?
Do you mean we should replace guestbook.php with an HTTP endpoint that only allows for retrieval and modification of values at the messages key?

Let me know if you have any questions (and feel free to ping me on Google Chat).
Thank you!

I'm closing this issue as it has been addressed by https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/pull/202.
@gabidavila Feel free to ignore the above question(s). Thank you! :)


[Event Request] in codeunit 99000770 "Where-Used Management"

We need a subscriber in line 120 bevore if ProdBOMComponent.FindSet() then statement.
OnBeforeFindSetProdBOMComponent(var ProdBOMComponent) because of setting ProdBOMCompoenten.SetLoadFields for a better performance.
    ProdBOMComponent.SetCurrentKey(Type, "No.");
    ProdBOMComponent.SetRange(Type, Type);
    ProdBOMComponent.SetRange("No.", No);
    if CalcDate <> 0D then begin
        ProdBOMComponent.SetFilter("Starting Date", '%1|..%2', 0D, CalcDate);
        ProdBOMComponent.SetFilter("Ending Date", '%1|%2..', 0D, CalcDate);
    end;
    OnBeforeFindSetProdBOMComponent(ProdBOMComponent)
    if ProdBOMComponent.FindSet() then
        repeat
            if VersionMgt.GetBOMVersion(
                 ProdBOMComponent."Production BOM No.", CalcDate, true) =
               ProdBOMComponent."Version Code"
            then begin
                OnBuildWhereUsedListOnLoopProdBomComponent(ProdBOMComponent, TempWhereUsedList, NextWhereUsedEntryNo, No, CalcDate, Level);
                if IsActiveProductionBOM(ProdBOMComponent) then
                    BuildWhereUsedList(
                      Enum::"Production BOM Line Type"::"Production BOM",
                      ProdBOMComponent."Production BOM No.",
                      CalcDate,
                      Level + 1,
                      CostCalcMgt.CalcCompItemQtyBase(ProdBOMComponent, CalcDate, Quantity, '', false));
            end;
        until ProdBOMComponent.Next() = 0;

    OnAfterBuildWhereUsedList(Type, No, CalcDate, TempWhereUsedList, NextWhereUsedEntryNo, Level, Quantity, MultiLevel);

With our extension this findset produce the following sql statement
SELECT TOP (@0) "5410"."timestamp"
,"5410"."Status"
,"5410"."Prod_ Order No_"
,"5410"."Requested Only"
,"5410"."Routing No_"
,"5410"."Routing Reference No_"
,"5410"."Operation No_"
,"5410"."Line No_"
,"5410"."Type"
,"5410"."No_"
,"5410"."Work Center No_"
,"5410"."Work Center Group Code"
,"5410"."Date"
,"5410"."Starting Time"
,"5410"."Ending Time"
,"5410"."Allocated Time"
,"5410"."Send-Ahead Type"
,"5410"."Time Type"
,"5410"."Needed Time"
,"5410"."Needed Time (ms)"
,"5410"."Lot Size"
,"5410"."Concurrent Capacities"
,"5410"."Efficiency"
,"5410"."Starting Date-Time"
,"5410"."Ending Date-Time"
,"5410"."Worksheet Template Name"
,"5410"."Worksheet Batch Name"
,"5410"."Worksheet Line No_"
,"5410"."Active"
,"5410_e3"."KVSKW"
,"5410"."$systemId"
,"5410"."$systemCreatedAt"
,"5410"."$systemCreatedBy"
,"5410"."$systemModifiedAt"
,"5410"."$systemModifiedBy"
FROM "BCTest".dbo."PIA Automation Austria GmbH$Prod_ Order Capacity Need$437dbf0e-84ff-417a-965d-ed2bb9650972" "5410" WITH (READUNCOMMITTED)
JOIN "BCTest".dbo."PIA Automation Austria GmbH$Prod_ Order Capacity Need$769d0762-06b1-42a0-aebe-3028d86cb96a" "5410_e3" WITH (READUNCOMMITTED) ON ("5410"."Status" = "5410_e3"."Status")
AND ("5410"."Prod_ Order No_" = "5410_e3"."Prod_ Order No_")
AND ("5410"."Requested Only" = "5410_e3"."Requested Only")
AND ("5410"."Routing No_" = "5410_e3"."Routing No_")
AND ("5410"."Routing Reference No_" = "5410_e3"."Routing Reference No_")
AND ("5410"."Operation No_" = "5410_e3"."Operation No_")
AND ("5410"."Line No_" = "5410_e3"."Line No_")
WHERE (
"5410"."Worksheet Template Name" = @1
AND "5410"."Worksheet Batch Name" = @2
AND "5410"."Worksheet Line No_" = @3
)
ORDER BY "Status" ASC
,"Prod_ Order No_" ASC
,"Requested Only" ASC
,"Routing No_" ASC
,"Routing Reference No_" ASC
,"Operation No_" ASC
,"Line No_" ASC
OPTION (FAST 50)
We have many data in this table and this statement takes over 20 seconds time. So we do not need this join therefore we want to use SetLoadFields

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 10836.


[Bug]: [Bug]: Last 2 fields and both reset and submit button cannot be accessed in the Insert modal in generated page with data section.

Is there an existing issue for this?

[X] I have searched the existing issues

Description
In the insert modal, both reset and submit button is not visible. Also, the last 2 fields in the form is also missing.
Steps To Reproduce

Create a postgres datasource
Generate page with data
Click on + button to add a new record.

Observe - The last 2 fields are not visible along with the reset and submit button.
Public Sample App
No response
Environment
Release
Issue video log
https://www.loom.com/share/56f47798e4484044a2528633ee701be1
Version
1.9.17

This is not a bug, its intended behaviour as scroll contents property is off by default here. We can enable scroll contents by default in CRUD apps, but that can be taken separately.

Not able to insert any row into the datasource because of this. Any workaround ?

https://github.com/appsmithorg/appsmith/assets/94514895/5b0ed57b-7285-4206-b2fe-1f135c98da17
not reproducible anymore


Review 23929

Fixes:

Screenshots and screen captures:
https://user-images.githubusercontent.com/12359771/225930971-fd3d63e8-84b4-4c46-8aa4-f60be6b65b92.mov
This is just a rebase of the work done by @Deekshith-S-Shetty.
Sometimes the page still reloads after clearing the selection highlighting, but I couldn't reproduce this consistently.
I tried changing e.clearSelection(); to the following:
if (window.getSelection) {
  if (window.getSelection().empty) {  // Chrome
    window.getSelection().empty();
  } else if (window.getSelection().removeAllRanges) {  // Firefox
    window.getSelection().removeAllRanges();
  }
} else if (document.selection) {  // IE?
  document.selection.empty();
}

This removed text selection/highlighting without a reload in Chrome and Safari, but it didn't remove highlighting in Firefox.  Therefore I restored the original code and retested.  It seems to be removing text selection/highlighting without a reload right now.
I searched for information regarding e.clearSelection(); causing page reloads, but couldn't find anything.  The page reload may be unrelated, and my manual testing results may have been a coincidence.

Self-review checklist

[x ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ x] Explains differences from previous plans (e.g., issue description).
[ x] Highlights technical choices and bugs encountered.
[x ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ x] Visual appearance of the changes.
[x ] Responsiveness and internationalization.
[ x] Strings and tooltips.
[x ] End-to-end functionality of buttons, interactions and flows.
[x ] Corner cases, error conditions, and easily imagined bugs.

UPDATE
PR #24756 fixes the reload issue which is unrelated to the code in this PR.
This PR is just a rebase of @Deekshith-S-Shetty's original PR #23929.

Closed because this is duplicative of PR #23929.


lib: couple block height and time

This PR aims to resolve #35.
I hope I'm on the right path here. Please let me know in case I need to make further changes.
Thanks.

Concept ACK. From a quick skim through the diff i think you are on the right path. Will review more in details later today.

Thanks!
utACK 89eb1572e955548886bf0c00c5e64b69f9f8cb32

For next time: it'd be cleaner for the two first commits to be merged, since the second one is undoing part of the diff from the first one.

Thanks for your review, @darosior. Ah yes sorry, I was planning to squash at the end once you'd checked the changes. I should have mentioned that.


package-lock.json downgrades from v2 (newly released npm@7) to v1

Package manager/ecosystem
npm (newly released 7!)
Manifest contents prior to update
Irrelevant.
Updated dependency
Any?
What you expected to see, versus what you actually saw
I expected dependabot to see "lockfileVersion": 2, in package-lock.json and use npm@7.
Images of the diff or a link to the PR, issue or logs
https://github.com/AviVahl/ts-tools/pull/92

Somehow it even does not actually bump the version: https://github.com/w3c/webidl2.js/pull/500

Same happening on my private repos, better to take care of this soon, because now I manually upgrade the deps :/

Yeah this one is annoying. I've had to disable dependabot now for Javascript.

I'm observing similar but slightly different behaviour when using NPM 7 in combination with the Workspaces feature.
In this scenario, for dependencies inside of one of the workspace folders, Dependabot ignores entirely the root package-lock.json file. It only bumps the version number or range in the package.json for the relevant subdirectory.
In my case I've even specified NPM 7 under the engines option in the root package.json but Dependabot seems to ignore this entirely as indicated by prior posts.

I can confirm the reported behavior. Very annoying. When the bot runs, it downgrades my lockfile to v1. Then when I pull the latest code and npm install, I get a package-lock.json change because NPM converts the lock file back to v2. And it's not just the internal version code that changes. The entire structure of the lock file changes because of significant changes made to the v2 format with npm@7.
The bot should detect the lock file version and use the corresponding NPM CLI.

Even more concerning is whether NPM <=6 is actually recreating the lock file at v1 rather than downgrading it. That would be very bad. Means every time the bot runs, my locks are voided and replaced with current, defeating the purpose of the lock file... I can see NPM 7 converting, but NPM 6 or less wouldn't know about this new format, so I wouldn't be surprised if it's an overwrite rather than a downgrade that doesn't alter any of the locked versions...

I really want to use dependabot. Like some here, I have to disable dependabot for now. I’m waiting for this to be done before enabling. 😞

I really want to use dependabot. Like some here, I have to disable dependabot for now. I’m waiting for this to be done before enabling. 😞

Hey everyone here, u can try a feature I guess, GitHub actions itself keeps npm V6, so I added a postinstall script to update npm to npm@latest (V7) and then reinstall it, so you can try that in your repos if possible...

Alternative way is to manually check for updates through this:
https://www.npmjs.com/package/npm-check-updates

https://github.com/dependabot/dependabot-core/blob/main/CHANGELOG.md#v01301-14-january-2021 states that dependabot is compatible with npm v7
However I'm using dependabot native GitHub integration and for me it does not detect npm v7 lockfiles and overwrites it...

https://github.com/dependabot/dependabot-core/blob/main/CHANGELOG.md#v01301-14-january-2021 states that dependabot is compatible with npm v7

That's maybe a little confusingly worded on our side, apologies. We are working on adding npm 7 support and that release allowed us to detect if we should be using npm 7, but it doesn't actually run the update against npm 7 yet. We hope to land it soon though! You can follow along here: https://github.com/dependabot/dependabot-core/pull/3011

Thank you for the clarification @jurre
Is GitHub's native Dependabot always using the latest dependabot-core version?
It would be helpful to know, because once the PR is merged we would like to upgrade npm once GitHub supports npm v7.

Is GitHub's native Dependabot always using the latest dependabot-core version?

Yeah we track it pretty closely although there is a delay between releasing a version and rolling it out into production. It's a semi-manual process so sometimes we release a version and roll it out the next day.
We'll publish an update on the GitHub changelog when support has landed though, and I'll make sure to ping folks here as well.

@jurre is there also perhaps a way we can get an command line version of dependabot that we can deploy ourselves that increments all updates (if any) at once within github actions and bundle all updates into a single pr using the create-pull-request action that way we do not need to worry about the one built into github whenever new releases land and then make an setup-dependabot action that any workflow can basically use with the type of updates they need to run on the project (that would accept what settings are possible in the dependabot.yml file without needing to supply that file to the action)?

@AraHaan yeah that's totally possible and people do this, https://github.com/dependabot/dependabot-script is a good place to start for inspiration on how to run dependabot standalone, and here is a more full fledged example of running Dependabot as an action: https://github.com/CGA1123/dependabot-lein-runner

Npm 7 support should be available now, if you run into issues please do let us know so we can fix them 🎉

Awesome. Closing issue then.
I wonder, which version of npm is dependabot using? or is it using @npmcli/arborist directly?
I got a weird PR from dependabot today. That lock file was just generated from scratch (using<EMAIL_ADDRESS>which comes with latest node@15), and I already use<EMAIL_ADDRESS>https://github.com/AviVahl/ts-tools/pull/152
Reasons I can imagine causing this:

differences of versions (npm/arborist) generating that lock file.
mishandling of npm's new workspaces feature.
or just bugs with the new lock file v2 handling.

Probably a separate issue though.

I wonder, which version of npm is dependabot using? or is it using @npmcli/arborist directly?

We look at the lockfileVersion in the package.json and then run the npm cli for most operations. There are a few things we run arborist for, but typically we won't update the lockfile directly using arborist.
We'll take a look at the PR you linked to, thanks for pointing to it! I wouldn't expect it to be related to different aroborist/npm versions, they should all result in the same lockfile, but workspaces or general bugs are also my initial suspicion.

@AviVahl thanks for the report, it looks like this issues is related  to npm workspaces where dependabot has incorrectly tried to update yargs in your nested package but installed it top-level instead.
We're working on a couple of fixes.

npm needs an option to update a dependency inside a single workspace (which correctly updates package-lock.json)...

npm needs an option to update a dependency inside a single workspace (which correctly updates package-lock.json)...

This is possible but not well documented, you'll have to update the requirement in the nested package.json then run npm install without any arguments in the folder with the package-lock.json.
Working on a fix here https://github.com/dependabot/dependabot-core/pull/3106

@feelepxyz btw letting you know that every run of the github hosted dependabot now complains about updating npm even when the project does not use npm (.net core with nuget).

@feelepxyz btw letting you know that every run of the github hosted dependabot now complains about updating npm even when the project does not use npm (.net core with nuget).

Oh thanks for letting us know, we'll get that fixed up 👍

Maybe a silly question, but to enable npm v7, would you just include a dependabot.yml file with package-ecosystem: "npm" configured and that's it to get the latest version? Based on the documentation, I don't see how to specify the npm version.

Yep! Dependabot will pick the npm version based on the lockfile version.
On Fri, 28 May 2021 at 16:42, Trey Piepmeier @.***>
wrote:

Maybe a silly question, but to enable npm v7, would you just include a
dependabot.yml file with package-ecosystem: "npm" configured and that's
it to get the latest version? Based on the documentation, I don't see how
to specify the npm version.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dependabot/dependabot-core/issues/2643#issuecomment-850507261,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAE5RISHFKBSNPDXVVR5I3TP62XVANCNFSM4SRXVIEQ
.

@feelepxyz Thanks! Then is the dependabot.yml necessary at all, or will it just pay attention to the existing lockfile?

@trey ah it depends. You'll need to check in the config file to enable Dependabot version updates but won't need to do this for security updates. For version updates you just need the following to enable npm6/7:
.github/dependabot.yml
version: 2
updates:
  - package-ecosystem: "npm"
    directory: "/" # directory with package.json/package-lock.json
    schedule:
      interval: "daily"

@feelepxyz Thanks! I think that makes sense. But even without the dependabot.yml file, the security updates will honor the lockfileVersion found in package-lock.json?

@feelepxyz Thanks! I think that makes sense. But even without the dependabot.yml file, the security updates will honor the lockfileVersion found in package-lock.json?

Yes that's right 👍  we pass the same options to the update and dependabot-core figures out the version of npm to use.

@feelepxyz Thanks again for answering my (probably silly) questions!


chore(deps): Bump dependencies 2021.07.27

What does this change?
Updates dependencies

Seems like more came through!


What low level controller do you use?

Hey,
aweasome project! I just wannted to ask what low level controller do you use to connect the motors do you use a cc3d board?

Hello. Sorry for the very long answer. I use pwm on board rpi3 or odroid. But for rpi you need third-party lib for control pwm.


Allow vite.alias to be an array

Before submitting the PR, please make sure you do the following

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

I'm not sure how to test this, would like to be enlightened.
Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

What is this SyntaxError: Unexpected token '.' error? Tests passed on my local machine.

It's because ?. doesn't work on Node 12

Thanks, fixed.


是GOTleader board上的吗？

为什么hz这么低

We adopt multi-process and multi-GPU and multi-process testing to accelerate the testing process, thus reducing the speed of a single sequence. Currently, you can refer to Stark for more details.

有单线程的数据吗？

有单线程的数据吗？

Sorry for the late reply. I will update the speed of the single thread soon. Our code will also be available soon. the tracker on the GOT-10k leaderboard is different from the original OSTrack and may be available later.


make OperaDriver executable during installation

Fix should be available in version 3.1.3 as soon as maven repo gets updated

cool


Suggested clarifications on running factory

It took me a while to understand how to use the app factory to create the app.  These instructions from the flask app factories page will help.

I think it would make sense to put this in {{cookiecutter.app_name}}/README.rst, which is the template for the README in the generated project. @marcosfelt Would you mind moving these docs there?


COPY GRANTS option fails on new views

Terraform CLI and Provider Versions
TF v1.5.2
Snowflake TF 0.80.0
Terraform Configuration
resource "snowflake_view" "CustomerView" {
  provider = snowflake.READER_ACCOUNTADMIN
  for_each = local.customer_views
  database = snowflake_database.CustomerDatabase[split(".", each.key)[0]].name
  schema = snowflake_schema.CustomerSchema[join(".", [split(".", each.key)[0], split(".", each.key)[1]])].name
  name = split(".", each.key)[2]
  statement = <<-SQL
    -- Force a change to the view so that it is recompiled ${timestamp()}
    SELECT * FROM DB_SHARE.${split(".", each.key)[1]}.${split(".", each.key)[2]}
  SQL
  is_secure = true
  copy_grants = true
}

Expected Behavior
View is created successfully
Actual Behavior
verbose TF_LOG shows that the CREATE VIEW statement includes the COPY GRANTS clause since copy_grants = true above.  However, since this is a brand new view and NOT a CREATE OR REPLACE, COPY GRANTS is invalid and you get a SQL error of: "Invalid operation COPY GRANTS without specifying source object".  Therefore, if the Snowflake provider knows this is a brand new view, then it should omit COPY GRANTS even if copy_grants = true so that valid SQL is produced.
Steps to Reproduce

terraform apply

How much impact is this issue causing?
Medium
Logs
No response
Additional Information
No response

Also, I see you are using "." splitting in your configurations. Snowflake identifiers are a bit more complex; it's possible to have the dot character as part of the identifier if you have a fully qualified part (wrapped in double quotes). We have the identifiers rework incoming. We want to address the issues our users have with identifiers.
This is just a FYI because these identifiers can really hurt sometimes.

Hey @scastria . We have released the fix as part of v0.87.0 release. Please follow the migration guide during the update. Please confirm that the issue is resolved in the newest version. Thanks!

Closing due to inactivity. Please create a new ticket with the newest provider version if the problem is still encountered.


Subtitle support

How do you think we could add support for subtitles? May be support for WebVVT (S_TEXT/WEBVTT) tracks as specified in:
https://www.matroska.org/technical/subtitles.html
I know this is long shot, just starting the discussion here...

I know it might feel like a long shot, but I think this is the natural next step for a library aiming to provide a complete muxing experience - so thanks for bringing it up! I'll read into the matter when I have time, but if it's just about adding a WebVVT file into the muxed file, that sounds very doable. Creating the WebVVT itself would not be in the scope of the muxer, the same way encoding video isn't.

Cool! Strange enough, WebM seems not to support subtitles by official spec, but at the same, their website comes with a full sub-chapter explaining how to add a subtitle track...
https://www.webmproject.org/docs/container/#webvtt-guidelines
SRT subtitles seems the easier to add on the other hand... as it is just S_TEXT/UTF-8 in the data block with correct timestamp set.

Yea, I've read that it now supports WebVTT only. Seems like a good move to allow any text codec and just encourage the user to use type 'matroska' for everything that isn't WebVTT.
The WebM support thing is wack anyway, since I assume most players just use their MKV player for WebM files anyway. But still, important to at least tell the user what's right.

If you feel up for it, you could already try and play around with adding subtitle support to the muxer. I was thinking a method addTextChunk might be good, along with a text track config in the options. Alternatively, we could call it Subtitle instead of Text.

My knowledge in JS is very basic... I trust you whatever solution you think it is better!
And I agree... most of the demuxers are based on the full matroska demuxer anyway, so there is a high chance that all the common subtitles types might just work.

I see! I'll look into it when I got the time. Which languages do you usually work with?

Mostly C.
But I'm helping in a JS audio editor, which is pretty cool indeed (and I'm using webm-muxer):
https://github.com/ColmenaDev/colmena-waveform-playlist/

Looking into it, adding subtitles does seem like a good amount of effort. Adding the individual Blocks for subtitle tracks is easy, but you also need a way to go from a full subtitle document to these blocks, per subtitle format. I could write an additional VTT helper library to assist with these tasks, but I'm not sure that I'd want to include that in the main library.
All of this is definitely possible, but I'm not sure if it'd be worth the effort as it's quite a niche feature - therefore I'll be closing this issue for now.
If you happen to require this feature urgently and are willing to invest in its development, please feel free to reach out to me!

I agree. Lets keep this on hold for now.

My idea with subtitles was to add export feature with subtitles for an audio editor:
https://naomiaro.github.io/waveform-playlist/annotations.html

I hate to necrobump here, but we are in need of subtitle support and would be willing to invest some effort into it. You mentioned adding VTT support as a separate library. Do you have any ideas/recommendations on how such an external add-on could integrate with webm-muxer?

No shame in necrobumping! Only problem is that I've forgotten most of the details of my reasoning here, so let's hope I can remember it somewhat.
I think the problem was that WebVTT subtitle tracks, just like video and audio, needs to be chunked before being included in the final file. This chunking happens naturally when using video and audio encoders, but there is no "subtitle encoder", therefore there would have to be additional code which chunks a WebVTT file into smaller segments. I remember that this felt out of scope for this library and therefore closed the issue.
This external library would have to play the role of a subtitle encoder, chunking the file into smaller blocks which would then be sent to the muxer via a method like addSubtitleChunk, addTextChunk or whatever.
Since it is still quite a niche feature, I'd be willing to add subtitle support to webm-muxer for $100. Is that okay for you?

Yes, we would be interested in that arrangement. When you say 'add support', what would be the scope of that? Adding the chunking logic and everything or adding the 'addTextChunk' method only? We would be getting the text in chunks in near real-time anyway. Would the chunks have to align to certain time boundaries? If so, how would we know what those are?
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Vanilagy @.>
Sent: Friday, December 22, 2023 10:05:28 AM
To: Vanilagy/webm-muxer @.>
Cc: justin0mcateer @.>; Comment @.>
Subject: Re: [Vanilagy/webm-muxer] Subtitle support (Issue #11)
No shame in necrobumping! Only problem is that I've forgotten most of the details of my reasoning here, so let's hope I can remember it somewhat.
I think the problem was that WebVTT subtitle tracks, just like video and audio, needs to be chunked before being included in the final file. This chunking happens naturally when using video and audio encoders, but there is no "subtitle encoder", therefore there would have to be additional code which chunks a WebVTT file into smaller segments. I remember that this felt out of scope for this library and therefore closed the issue.
This external library would have to play the role of a subtitle encoder, chunking the file into smaller blocks which would then be sent to the muxer via a method like addSubtitleChunk, addTextChunk or whatever.
Since it is still quite a niche feature, I'd be willing to add subtitle support to webm-muxer for $100. Is that okay for you?
—
Reply to this email directly, view it on GitHubhttps://github.com/Vanilagy/webm-muxer/issues/11#issuecomment-1867850353, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAT4Q7OBJN6EA3LNW54CC3TYKWVURAVCNFSM6AAAAAAVQCQZI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRXHA2TAMZVGM.
You are receiving this because you commented.Message ID: @.***>

Within the $100 I'll include the chunking logic, I think I'll just add it to this library unless it grows way too large. What did you mean with getting the chunks in real time, by the way? How are you getting them?
You can donate to my Ko-fi here: https://ko-fi.com/vanilagy
Once I get the payment, I'll get to it as soon as I can ^^

Hey! Nice to see activity here! We are still very interested in adding subtitles support tru wem-muxer for audio+subtitle export in our audio editor: https://github.com/ColmenaDev/colmena-waveform-playlist

Once it lands, we should make sure it works for your use case @rafael2k

@Vanilagy We would be recording communication sessions in near real-time. We could have multiple text streams, which would come from the application. Examples might be: a stream for transcription of audio, another for textual user generated messages.

@Vanilagy check your Ko-fi

@justin0mcateer Thank you!! I'll keep in touch with you.

After a decent grind, subtitle support has landed in v3.2.0! Please check it out and test it.
Took a bit longer than expected but I wanted to get it right. I kept the API as close to the other methods and WebCodecs API as possible. Check out this example from the README:
import { Muxer, SubtitleEncoder, ArrayBufferTarget } from 'webm-muxer';

let muxer = new Muxer({
    target: new ArrayBufferTarget(),
    subtitles: {
        codec: 'S_TEXT/WEBVTT'
    },
    // ....
});

let subtitleEncoder = new SubtitleEncoder({
    output: (chunk, meta) => muxer.addSubtitleChunk(chunk, meta),
    error: e => console.error(e)
});
subtitleEncoder.configure({
    codec: 'webvtt'
});

let simpleWebvttFile =
`WEBVTT

00:00:00.000 --> 00:00:10.000
Example entry 1: Hello <b>world</b>.
`;
subtitleEncoder.encode(simpleWebvttFile);

// ...

muxer.finalize();


withdraw issue

i have 2 days waiting for withdraw and nothing....IOTA address: ARCJPOWQCIFMZQGYHPN9WJVBCGKQZYYJFYZVCRRSNMHDAEV9MZJZ9NTFXJNOMTZZPTNBYGTA9GHLFBTOWDOISYOWYW

Hi, there is no issue on my side. IOTA tangle is broken, confirmation time for transaction is more than 2 hours, I cannot send more transaction until previous 10 is confirmed. So make a count how long you will be wating. So go to iota slack and spam devd, they make iota bad. More transactions in tangle more time to confirmations. Theyr wait papier  is peace of lie, because they use coordiator.
I will soon add function to get your position when you leave page and return back soon.

Thanks and good luck!!


Fix cloud-function-netty-fun sample

Seems broken with Spring Cloud 2020.0.0-RC1.

Fixed in c7c043235 but could be improved by moving that hint to the feature.


Create Stub Doc for Contact Section and Update Contact Link to Point to It.

Contact page mock: https://chanzuckerberg.invisionapp.com/share/B8M7GFUXJGS#/screens/305992561


The Charts presentation in the report downloaded by locust is problematic

Prerequisites

[X] I am using the latest version of Locust
[X] I am reporting a bug, not asking a question

Description
When I used the V1.0.0 version, the downloaded charts appeared fine

When I used the newer version (2.27, 2.25), the downloaded chart was not fully displayed, and I tried the lower version 2.19, which had the same problem

Command line
locust --tag post/pipelines
Locustfile contents
class QuickstartUser(HttpUser):
    wait_time = constant(1)

    @task
    @tag("post/pipelines")
    def create_pipeline(self):
        self.client.post("/pipelines", json={
            "name": f"pressure_test_pipeline_{int(time.time())}",
            "version": "1.0.0",
            "title": "pressure_test_pipeline_title",
            "detailLink": "",
            "maintainer": "tester",
            "dag": "pipeline-bidsapp-bidsinfo",
            "isPublic": True
        })

Python version
3.9
Locust version
2.27
Operating system
Windows11

Hi!
Is this an issue with the downloaded report or also the live view?

When I click on "Download Report" and then preview the html report I have a problem with Charts, and of course the same thing happens after the download.
I think it's caused by the run time being too short, because I only ran it for 5 seconds, and when I ran it for 10s the charts were displayed properly
[run time: 5s]

[run time: 10s]

@andrewbaldwin44 if you have time, can you have a look at what happens in the RPS graph with short run times? Super-short run times arent that common I think, but the line/dot should not be missing completely or be zero.


Only transpile if the script is the entry point.

Also be more selective about which files to pick
up in typings, as our TS compiler now accepts all
file types, not just .ts files.

@alexeagle FYI, merging this now.

LGTM


When creating an ubuntu VM, see that the VM memory is less than the actual allocated

yaml
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: ubuntu-template
spec:
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 200Gi
  storageClassName: local-path
---
apiVersion: kubevirt.io/v1alpha3
kind: VirtualMachine
metadata:
  name: ubuntu
spec:
  running: false
  template:
    metadata:
      labels:
        kubevirt.io/domain: ubuntu
    spec:
      domain:
        cpu:
          cores: 8
        devices:
          disks:
          - bootOrder: 1
            disk:
              bus: virtio
            name: harddrive
          - bootOrder: 2
            cdrom:
              bus: sata
            name: cdromiso
          - cdrom:
              bus: sata
            name: virtiocontainerdisk
          interfaces:
          - bridge: {}
            model: virtio
            name: default
        machine:
          type: q35
        resources:
          requests:
            memory: 16G
      networks:
      - name: default
        pod: {}
      volumes:
      - name: cdromiso
        persistentVolumeClaim:
          claimName: ubuntu
      - name: harddrive
        persistentVolumeClaim:
          claimName: ubuntu-template
      - containerDisk:
          image: kubevirt/virtio-container-disk
        name: virtiocontainerdisk

The situation is as follows

In order to make sure the ububtu system don't reserve memory(such as crashkernal) and I think you can check the gurb.cfg.

Because you're using units of G（16G），switch to Gi（16Gi） test. @ILoveYou00

Switching to Gi is a little bigger than G shows, but there are still missing, is it normal to have missing?

In order to make sure the ububtu system don't reserve memory(such as crashkernal) and I think you can check the gurb.cfg.
It's not just ubuntu,centos too, is there some kind of loss in the middle, or is part of the memory used as cache and buffer, which won't show up in the free -g result.


Does HNSW support Jaccard distance on binary vector inputs?

Hi, We searched previous posts #306 and found that HNSW supports "bit_hamming". We suppose the input can be binary vectors because the distance name has a "bit" there.
Then, does HNSW also supports Jaccard distance on binary vectors? We have a concern that the algorithm itself (not the implementation) does not work for Jaccard distance on binary vectors. If it works, the code in the notebook (https://github.com/nmslib/nmslib/blob/master/python_bindings/notebooks/search_generic_sparse_jaccard.ipynb) can also be adapted (or directed used) for binary inputs, right? Thanks!

@chunjiangzhu to see if the algorithm works for bit vectors, you can use the sparse Jaccard space. You just need to convert binary vectors to a set of IDs. But we do not support computation of the Jaccard over binary vectors directly, sorry.
It's surprising to hear that HNSW doesn't work for Jaccard, which is a nice metric. Could you provide a sample?

Thank you, for your prompt reply. Yes, we have applied your code on binary vectors with the sparse Jaccard space. The results look nice. But we were not 100% sure theoretically whether the algorithm works for Jaccard  on binary inputs, so we posted the question to get a quick answer.
BTW, a naive question: the name "non-metric space library" does not mean that the algorithms there are designed for non-metric space only?

Hi @chunjiangzhu no problem. Just to make sure, there are two sides of the problem:

Whether an algorithm works with Jaccard in principle
Whether we have an implementation that computes the Jaccard-based distance given two binary dense vectors.
I would emphasize that in both cases, we have the same distance function. However, the difference will be in the encoding only. For example, if you have no more than 32 IDs, a sparse representation of
the set {0, 5, 13, 31} will be just a set of space-separated integers: 0 5 13 31. Internally, it will be stored as a sparse vector with 4-byte vector-element IDs.

A binary representation would be a 32-bit integer with the binary representation:
00001000000001......1
There is no theoretical difference between these two cases, only the difference in representation. Also, there is no implementation that would take binary vectors and correctly compute the Jaccard between them. I hope this is clear.
Regarding the name question: it merely means we are more general than most other libraries. In fact, most algorithms for non-metric spaces are also applicable to metric spaces.


Update cassandra-driver-extras to 3.10.2

Updates com.datastax.cassandra:cassandra-driver-extras from 3.8.0 to 3.10.2.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.datastax.cassandra", artifactId = "cassandra-driver-extras" } ]

labels: library-update, semver-minor

Superseded by #271.


codeberg-cli: Init at 0.3.5

Description of changes
This PR inits the ~cod~ berg  package for nixpkgs.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests -> the binary doesn't have any tests yet
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage This PR adds a new binary which doesn't have any dependents
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[x] (Package updates) Added a release notes entry if the change is major or breaking
[x] (Module updates) Added a release notes entry if the change is significant
[x] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Oh woops, sorry for the inconvenience. That was my lsp autoformatting the code. Although it is strage that something was completely missing 🤔

Thanks ! Don't forget to add your app to all-packages.nix :) As a tip you can test your build by going to nixpkgs root and running nix-build -A yourpackage.

Sorry for the many force pushes. I just want to keep the history clean.
I noticed that there is another package that is called cod so I renamed mine to codeberg-cli, the name of the repo, which is also fine I guess. Other than that I added the package to the all-packages.nix file and did a test build as described by the last comment. It went through without errors.

Since I discovered that there already is a tool called cod we renamed the projects binary and introduced a major change with it. I need to update this PR here when I find the time to do so.

@JulienMalka Can you please help me making progress with this PR? It's my first time contributing to nixpkgs and I don't know what to do since the PR seems stuck. Is there anything I need to check/change?

Sure, there are several things that we need to fix before this is mergeable. First, you made some accidental formatting to the maintainer-list.nix file, which you need to remove. Secondly you need to squash the commits so that this PR is only two commits, one where you add yourself as maintainer and one where you add the package. If you are unsure on how to do these task with git, I'm available on matrix for help. https://matrix.to/#/#community:nixos.org

Oh man, I didn't notice the LSP was messing with the maintainers list again. Should be fixed now and I cleaned up the history aswell!

Result of nixpkgs-review pr 215987 run on x86_64-linux 1

1 package built:

codeberg-cli

Thanks for the review @Lord-Valen! I took over your remarks and amended it on the "init ..." commit

Build is failing on Darwin
       >   = note: ld: framework not found CoreServices

Does anyone have an idea why the aarch64-darwin is stuck? 👀

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2436

we should generate the completions scripts, too

Thanks that was a cool suggestion :+1:


Guides location (BIOS, etc)

https://pcsx2.net/guides/ points to nowhere
https://pcsx2.net/guides/basic-setup/ points to the BIOS setup
In the future this could be expanded but it's not really exposed as easily to the user checking the site and not everyone uses or watches Discord.

This was intentional - to be able to make articles easily via markdown that aren't shown in the lists and can instead be linked directly to.

it's not really exposed as easily to the user checking the site and not everyone uses or watches Discord.

It's exposed via the relevant sections on the downloads page

There is an argument we could add a menu link for 'Setup' or something like that. From a UX perspective it makes distinct sections download (Where to get) Compat list (What works) setup (How to make work). This would mean we could remove the current text from the downloads page.
Not something I'm super passionate about either way however it makes to me that it be split out and like Red says we could always expand it later on.


Per-sample-gradient: Get gradient 0 when using grad(params_tograd, params) with respect to part of model's parameters

Hi Pytorch team, recently I need to calculate per sample's gradient with respect to part of model's parameters. The problem is that for the toy example, it works. But for the Wide & Deep model, it doesn't work and returns me all  0 gradients. I don't know why.
Here is the toy example:
import torch
from functorch import grad
from functorch import make_functional_with_buffers, vmap, grad
import torch.nn.functional as F
import torch.nn as nn

class SimpleCNN(nn.Module):
    def __init__(self):
        super(SimpleCNN, self).__init__()
        self.conv1 = nn.Conv2d(1, 32, 3, 1)
        self.conv2 = nn.Conv2d(32, 64, 3, 1)
        self.fc1 = nn.Linear(9216, 128)
        self.fc2 = nn.Linear(128, 10)

    def forward(self, x):
        x = self.conv1(x)
        x = F.relu(x)
        x = self.conv2(x)
        x = F.relu(x)
        x = F.max_pool2d(x, 2)
        x = torch.flatten(x, 1)
        x = self.fc1(x)
        x = F.relu(x)
        x = self.fc2(x)
        output = F.log_softmax(x, dim=1)
        output = x
        return output

device = 'cuda'
num_models = 10
batch_size = 64

data = torch.randn(batch_size, 1, 28, 28, device=device)
targets = torch.randint(10, (64,), device=device)

model = SimpleCNN().to(device=device)
model=model.eval()
fmodel, params, buffers = make_functional_with_buffers(model)

def loss_fn(predictions, targets):
    return F.nll_loss(predictions, targets)

def compute_loss_stateless_model (params_tograd,params, buffers, sample, target):
    for key, value in params_tograd.items():
        params[key]=value
    batch = sample.unsqueeze(0)
    targets = target.unsqueeze(0)

    predictions = fmodel(params, buffers, batch)
    loss = loss_fn(predictions, targets)
    return loss

ft_compute_grad = grad(compute_loss_stateless_model)

ft_compute_sample_grad = vmap(ft_compute_grad, in_dims=(None,None, None, 0, 0))

params_tograd={}
for i in [-2,0]:
    params_tograd[i]=params[i]
ft_per_sample_grads = ft_compute_sample_grad(params_tograd,[p for p in params], buffers, data, targets)
print(ft_per_sample_grads)

The result is :

However, when I apply this method to the real scenario, it doesn't works and all return 0 gradient.
      model.load_state_dict(w_tao)
      fmodel, params, buffers = make_functional_with_buffers(model)

      def loss_fn(predictions, targets):
          return F.mse_loss(predictions, targets)

      def compute_loss_stateless_model (params_tograd,params, buffers, sample, target):
          for key, value in params_tograd.items():
              params[key]=value
          batch = sample.unsqueeze(0)
          targets = target.unsqueeze(0)

          predictions = fmodel(params, buffers, batch)
          loss = loss_fn(predictions, targets)
          return loss

      ft_compute_grad = grad(compute_loss_stateless_model)
      ft_compute_sample_grad = vmap(ft_compute_grad, in_dims=(None,None,None, 0, 0))
      params_tograd={}
      if dataset=='lastfm-1k':
          params_tograd[-1]=params[-1]
          params_tograd[4]=params[4]
      else:
          params_tograd[0]=params[0]

      prod_all=[]
      for batch_idx, (inputs, targets) in tqdm(enumerate(train_data_loader)):
          inputs, targets = inputs.to(self.device).float(), targets.to(self.device).float()

          ft_per_sample_grads = ft_compute_sample_grad(params_tograd,[p for p in params], buffers, inputs, targets)
          print(ft_per_sample_grads)
          sys.exit()
          if dataset!='lastfm-1k':
              params_grads=ft_per_sample_grads[-1].reshape(ft_per_sample_grads[-1].shape[0] ,-1)
          elif dataset=='lastfm-1k':
              params_grad_dnn=ft_per_sample_grads[-1].reshape(ft_per_sample_grads[-1].shape[0] ,-1)
              params_grad_linear=ft_per_sample_grads[4].reshape(ft_per_sample_grads[4].shape[0] ,-1)
              params_grads=torch.cat([params_grad_dnn,params_grad_linear],-1)

          prod=torch.mm(params_grads,grad_mean.unsqueeze(1)).squeeze().detach().to('cpu').numpy()
          prod_all.extend(prod)
      return dict(zip(range(1,len(prod_all)+1), prod_all))

Also, in the Wide & Deep module, the shape of linear_logit should be (batch_size,1), but when apply this method, the error will happened here, and the system said the shape of linear_logit and sparse_feat_logit is not match, here I attached the print out result. (I suppose when using this method, the X.shape[0]=0, but why?)
        linear_logit = torch.zeros([X.shape[0], 1]).to(self.device)
        if len(sparse_embedding_list) > 0:
            #torch.Size([1000, 1, 7])
            sparse_embedding_cat = torch.cat(sparse_embedding_list, dim=-1)
            if sparse_feat_refine_weight is not None:
                # w_{x,i}=m_{x,i} * w_i (in IFM and DIFM)
                sparse_embedding_cat = sparse_embedding_cat * sparse_feat_refine_weight.unsqueeze(1)

            sparse_feat_logit = torch.sum(sparse_embedding_cat, dim=-1, keepdim=False)
            try:
                linear_logit += sparse_feat_logit
            except:
                print(linear_logit.shape)
                print(sparse_feat_logit.shape)
                print('linear_logit\n',linear_logit)
                print('sparse_feat_logit\n',sparse_feat_logit)
                sys.exit()
                linear_logit=sparse_feat_logit

When I want to calculate the gradients of the embedding layer,:
RuntimeError: a leaf Variable that requires grad is being used in an in-place operation.


Calling sort().first().find() doesn't work

Want to sort a list and retrieve the first one with sort().first().find() but it doesn't work.
Using sort().find().firstOrNull() will work instead.

@ganfra When you say it doesn't work, what do you mean exactly? Can you share an example?

Yes sorry, I was not clear.
So the result is not returned sorted as I'd have expected.
But if I just call find().firstOrNull()instead it respects the sort operator.
Exemple:
class Task : RealmObject {
    @PrimaryKey
    var id: Long = 0,
    var name: String = ""
    var lastEditTs: Long = 0
}

If I want to get the latest edited task:
realm.query(Task::class).sort("lastEditTs", Sort.DESCENDING).first().find() => will return the first edited
realm.query(Task::class).sort("lastEditTs", Sort.DESCENDING).find().firstOrNull() => will return the last edited

@ganfra Thanks for the clarification, we were able to reproduce the issue.


Remove sprockets version dependency (setup testing against multiple versions of Rails and Sprockets)

Currently this gem has a requirement for sprockets being version 3.0.0.beta.6, can this be generalised?

Absolutely.  I intend to set up testing against multiple gemfiles for multiple versions of Rails and Sprockets.
Currently I need to resolve issue https://github.com/bolandrm/sassc-rails/issues/8 before proceeding with anything else.

@jlaw90 I've set up testing across multiple versions of Rails and Sprockets.  It should now support:
  spec.add_dependency 'rails', '>= 4.0.0'
  spec.add_dependency 'sprockets', '> 2.11'

Does this help?

@bolandrm that should do it, thanks!


Kubeflow resource requirement

It would be really helpful if resource(cpu, memory) requirement is also given for kubeflow.

Will this help?
https://www.kubeflow.org/docs/started/k8s/overview/#minimum-system-requirements

Hi,
The link which you have sent is the minimum resource requirement for
kubernetes, I need resource requirement for kubeflow.
Please help me with this.
Regards,
Navodita Jaiswal
On Thu, Apr 9, 2020, 10:33 PM Jane Man<EMAIL_ADDRESS>wrote:

Will this help?
https://www.kubeflow.org/docs/started/k8s/overview/#minimum-system-requirements
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kubeflow/website/issues/1878#issuecomment-611639789,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APBOALBCIV75X7H6I3UIDD3RLX5XBANCNFSM4MC2LC5Q
.

/area docs
/priority p2

Could you please clarify this address path for me?
On Fri, Apr 10, 2020, 8:36 AM Jeff Fogarty<EMAIL_ADDRESS>wrote:

/area docs
/priority p2
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kubeflow/website/issues/1878#issuecomment-611855096,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APBOALBIXQ7QWGUPZYQ5MH3RL2EKHANCNFSM4MC2LC5Q
.


Update parsing IPFS link for NFT

Requested by BitPunkz team. The IPFS link format is /ipfs/QmRNAjTqfP4P5qk28mACsxCow1t4h5Sy2CJrENdWfUcNV7/251.json

Resolved in #795

version test: https://file.cdmteck.com/s/4oimk9zDJ8R5Aai/download?path=%2F&files=./795-merge-build-0.6.9-1667643361868.zip
Validation passed.


Re-order tabs of Circuits

Is your feature request related to a problem? Please describe.
It's not a huge problem, but typically my students have a preferred order of circuits -- e.g. such that a new sub-circuit sits next to the circuit that uses it.
Describe the solution you'd like
Like in modern web browsers, it would be great if you could click and drag on Circuit tabs to re-order.
Describe alternatives you've considered
A less preferred solution would be to allow re-ordering of tabs with some sort of numeric priority indication.
My current workaround is to Shift-Drag to copy/paste the entire contents of circuits to re-order tabs. Doing that workaround is tedious and not usually worth the effort.
Screenshots
Circuit tabs:

Are you working on this? (Yes/No)
No

Good Idea 👍 . I will be working on it.

I would love to work on this issue : )

This issue is already solved. I guess @tachyons we can close this one : )


Default to using the openstack hostname for event monitoring.

Related to #1936 and #1800
We need to use the hostname column and not the ipaddress.  Users can specify an ipv4/ipv6 address in the hostname column if they need to get around DNS issues or other issues.
We originally defaulted to ipaddress with this code in 99d6c2dd8f6:
  def event_monitor_available?
    begin
      require 'openstack/openstack_event_monitor'
      options = {}
      options[:username] = self.authentication_userid(:amqp)
      options[:password] = self.authentication_password(:amqp)
      options[:hostname] = self.ipaddress
      OpenstackEventMonitor.available?(options)
    rescue => e
    end
  end

cc @blomquisg, thanks @himdel!

@blomquisg @Ladas Please review.  I think this is ok, but I just want you guts to eyeball it and make sure nothing is missing.  Do we need to do something with verifying SSL?

Looks good to me. Same change has been done in other places and it works for me.
@Fryguy what do you mean with verifying SSL in this context?

I'm not sure how to denote this, but this will require a change to the docs.  Specifically, when using QPid and SSL, since we were previously using ipaddress for the connection information, the SSL certificate needed to be created for the IPAddress of the QPid broker host (because SSL certs do not integrate with DNS).  And, I'm fairly sure that's doc'd.
With this change, the docs need to be updated to indicate that the SSL cert needs to be created with hostname (which is the industry standard).

@blomquisg note:  this isn't requiring that the hostname field contain a hostname, only that we're using the hostname column.  For example, you can specify an ipv4/ipv6/hostname in the hostname field.

@blomquisg Is there anything else needed on this PR?  I don't think there's anything new here.  We have the needs changelog label, is there something else?  I mean, we can use ips in the hostname column.

@blomquisg Also, see related #/2127, where we're going to be changing the Host/Ems/Provider new/edit screens.

Bump @blomquisg @Fryguy @gmcculloug please review/merge


Refactor file operator code and complete git init level

level intro/init is used to teach someone to use git init, but for them to do that, the current directory should not be a git repo. In order to do that,we would need to add several layers of convolution to get the file operators but instead, let's just refactor
Task:

Remove ownership of file operators from the GitGud object
Never pass file operators, get it from operations.get_operator() instead (Never re-initialize)
Make sure git init acts as if we aren't in a git repo when the level is initialized
Refactor existing code that uses file operators to reflect changes
Fix anything else that's relevant to this and you think makes sense. You're at liberty to change the structure of the code here if you think it'd help

Base changes on and merge into https://github.com/benthayer/git-gud/tree/intro

@sahansk2 Can you tackle this?

@benthayer Yep!


HDFS-16430. Validate maximum blocks in EC group when adding an EC policy

HDFS EC adopts the last 4 bits of block ID to store the block index in EC block group. Therefore maximum blocks in EC block group is 2^4=16, and which is defined here: HdfsServerConstants#MAX_BLOCKS_IN_GROUP.
Currently there is no limitation or warning when adding a bad EC policy with numDataUnits + numParityUnits > 16. It only results in read/write error on EC file with bad EC policy. To users this is not very straightforward.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 32s

trunk passed

+1 :green_heart:
compile
1m 25s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
1m 26s

trunk passed

+1 :green_heart:
javadoc
1m  3s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 35s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 15s

trunk passed

+1 :green_heart:
shadedclient
23m 21s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 16s

the patch passed

+1 :green_heart:
compile
1m 20s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 20s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 52s

the patch passed

+1 :green_heart:
mvnsite
1m 20s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 23s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 18s

the patch passed

+1 :green_heart:
shadedclient
22m 17s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
225m  8s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

324m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3899/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3899

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 8de9f2ccad41 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 300f4d35e03a7bdaf8bde78a2144c5dfa76dbde2

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3899/1/testReport/

Max. process+thread count
3359 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3899/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanks for your review! @ayushtkn

Thanx @cndaimin for the contribution and @tomscut for the review!!!


Update urls to project in documentation

🤔 What's changed?
Updated all references to common/.../messages/.....
♻ Anything particular you want feedback on?
Had to change the ruby doc uri:
'documentation_uri' => 'https://www.rubydoc.info/github/cucumber/messages',

But it doesn't look like rubydoc.info works with mono-repos.

Superseded by #105


flatbuffers is missing in vanilla poky build

Setting up a build with just poky and meta-flutter in it, fails with
ERROR: Required build target 'meta-world-pkgdata' has no buildable providers.
Missing or unbuildable dependency chain was: ['meta-world-pkgdata', 'firebase-cpp-sdk', 'flatbuffers']

flatbuffers is served by meta-oe
I see two options here

make meta-oe (aka openembedded-layer) mandatory
move everything that invokes flatbuffers (from a quick check that would be firebase and therefore flutter-auto) to a dynamic-layer

What would be the preferred option? (I'm willing to post a patch)

Hi @kwavnet,
glib, libxml, dbus, etc are in meta-oe.  I never called it out as a hard dependency, as meta-oe is required to build a generic linux image.
I'll accept a PR on scarthgap with meta-oe as a required layer if you like.

Looks like the LAYERDEPENDS is already set correctly - I think that was happening to me on kirkstone, potentially not with the latest - just double checked, on all supported branches the dependencies are set.
Consider this fixed


Update ENHSP version

Codecov Report
Patch and project coverage have no change.

Comparison is base (251213f) 85.06% compared to head (244536b) 85.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #443   +/-   ##
=======================================
  Coverage   85.06%   85.06%
=======================================
  Files         198      198
  Lines       25699    25699
=======================================
  Hits        21862    21862
  Misses       3837     3837

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Use proxy instead of load balancer for Elasticsearch and Kibana

This change:

Removes the external load balancer from the Elasticsearch and Kibana services for cluster level logging and uses the proxy instead (are you happy now @thockin ?).
Updates our kubernetes/kibana image to specify the Elasticsearch service using its proxy address and removes the nginx proxy_pass config which is no logner needed.
Updates the reporting text in util.sh to report the URL of the cluster level services.

If the trailing lash is missing from  https://MASTER/api/v1beta1/proxy/services/kibana-logging/ the Kibana page will not load properly. Something is broken -- either with us or Kibana.
FYI: @vishh @piosz

A heads up to @jeffmendoza  @mikedanese @justinsb
After this change merges I hope I can work with you guys to enable cluster level logging for AWS and Azure which might work now that we will no longer need an external load balancer.

@satnam6502: With this change, will users be able to specify a public IP on the 'kibana-logging' service and be able to access kibana UI directly?

LGTM

...should I have asked for an e2e run before merging this? I guess we'll find out.

@vishh : no, setting a public IP in the service spec will not wok for Kibana (although fine for Elasticsearch). This is because the Kibana image has this URL for Elasticsearch:
"https://"+window.location.hostname+"/api/v1beta1/proxy/services/elasticsearch-logging"

which is expressed in terms of the proxy.

@lavalamp : I am now finally unblocked for writing the actual e2e test for cluster level logging.


[bug] Support for /dev/serial/by-path/

Version
Build/Run method

[X ] Docker
[ ] PKG
[ ] Manually built (git clone - npm install - npm run build )

Zwave2Mqtt version: 1.2.3
Openzwave Version: 1.4.1
Describe the bug
/dev/serial/by-path isn't supported by zwave. This is a problem since the ttyACMx port number may change after a reboot, and (at least for aeotec z-sticks), /dev/serial/by-id isn't able to separate between two sticks in the same computer.
To Reproduce
Steps to reproduce the behavior:

Assign a port to zwave2mqtt
Reboot
Sometimes it gets the same port number, sometimes it doesn't.

Expected behavior
A clear and concise description of what you expected to happen.
Additional context
Add any other context about the problem here.

Have you tried just pasting in the full path to the node in /dev/serial/by-path/... ?
On SmartOS the library used does not discover the ports so I have to manual specify the full path, it works fine afterwards.

@hmorkemo Did @sjorge suggeestion fixed your problem?

I have tried pating the full by-path with no good effect. Someone in the hassio community says that the problem is docker-relateed, that docker cannot handle device names with : in them.

@hmorkemo I'm using docker like this and it works great:
from my docker-compose.yml file:
devices:
    - /dev/serial/by-id/usb-Silicon_Labs_HubZ_Smart_Home_Controller_612017D9-if00-port0:/dev/ttyACM0

Thanks @plasticrake . @hmorkemo Does the fix suggested works for you?
Anyway this is not a problem related to my lib but something on docker side so I'm going to close this.


about F-score

Sorry to bother you again. I use your setting in scannet on 4090 torch 1.13.1 cuda1.17.1，but I can't get same result in your paper.My results are as follow.I have no idea about this prob as the performance should not be so degraded that caused by the difference of cuda and torch.

Hi Mingzhi,
Thanks for your attention to our work.
I can share our experiment data with you.

In the table above, the Left side is our experiment in the original paper. That should align with our table on paper.
The right side is the experiment I tested before the code release. That's even better than the original paper when I tested this code several days before.
I run this scene just for one time during my testing, and maybe you also run this for one time. There may be some random issue with each running.
If you need me to release my checkpoint for evaluation, I can help to give a guideline. (But the matrics maybe a little higher than the original paper.)

It seems that scan4 is the main degenerating scene.
I can give you the visualization of this scene's reconstruction for your reference, which was produced just a few days ago.

Empirically,
this scene has the possibility to degenerate because of improper initialization.
If you wish to get the result with your machine, I suggest to rerun the code.
If you strongly wish to access our checkpoint, please tell me.
Recently, I've been a little busy with examinations; I will prepare to release the checkpoint when I'm convenient.

Hello Mingzhi,
I have just updated our official checkpoint for evaluation.
Please check out https://github.com/DavidXu-JJ/DebSDF?tab=readme-ov-file#official-checkpoint-evaluation.
All these evaluations should align with our paper.
Issue closed.


Function name much more verbose than before

I updated recently to g3log 2.1.0 from 1.3.4 in order to support C++20.
Since then, I realised that our logs are much more verbose. Here an example.
1.3.4
2022-03-23-08:11:47,521327 | INFO            | Workstation ID: 1 activated | AssemblerHardwareControler.cpp->adam::AssemblerHardwareControler::makeHardwareControler:125
2.1.0
2022-11-23-08:50:43,603630 | INFO            | Workstation ID: 1 activated | AssemblerHardwareController.cpp->static Result<unique_ptr_qobjectadam::WorkstationsList> __cdecl adam::AssemblerHardwareController::makeHardwareControllerDrf(const adam::SoftwareOptions &, const QJsonDocument &):154
Some of our methods have arguments based on Boost units and since it is very templated, it takes several lines in our logs. Example:
2022-11-22-11:04:27,635036 | ERROR           | VacuDAP: Failed setting voltage. Only voltage values between 30 and 150 are allowed. Value sent: 29 | VacuDapHandler.cpp->struct adam::detail::DefaultResult __cdecl adam::VacuDapHandler::SetParameterTubeVoltage(const class boost::units::quantity<class boost::units::unit<struct boost::units::list<struct boost::units::dim<struct boost::units::length_base_dimension,class boost::units::static_rational<2,1> >,struct boost::units::list<struct boost::units::dim<struct boost::units::mass_base_dimension,class boost::units::static_rational<1,1> >,struct boost::units::list<struct boost::units::dim<struct boost::units::time_base_dimension,class boost::units::static_rational<-3,1> >,struct boost::units::list<struct boost::units::dim<struct boost::units::current_base_dimension,class boost::units::static_rational<-1,1> >,struct boost::units::dimensionless_type> > > >,struct boost::units::heterogeneous_system<struct boost::units::heterogeneous_system_impl<struct boost::units::list<struct boost::units::heterogeneous_system_dim<struct boost::units::si::meter_base_unit,class boost::units::static_rational<2,1> >,struct boost::units::list<struct boost::units::heterogeneous_system_dim<struct boost::units::scaled_base_unit<struct boost::units::cgs::gram_base_unit,struct boost::units::scale<10,class boost::units::static_rational<3,1> > >,class boost::units::static_rational<1,1> >,struct boost::units::list<struct boost::units::heterogeneous_system_dim<struct boost::units::si::second_base_unit,class boost::units::static_rational<-3,1> >,struct boost::units::list<struct boost::units::heterogeneous_system_dim<struct boost::units::si::ampere_base_unit,class boost::units::static_rational<-1,1> >,struct boost::units::dimensionless_type> > > >,struct boost::units::list<struct boost::units::dim<struct boost::units::length_base_dimension,class boost::units::static_rational<2,1> >,struct boost::units::list<struct boost::units::dim<struct boost::units::mass_base_dimension,class boost::units::static_rational<1,1> >,struct boost::units::list<struct boost::units::dim<struct boost::units::time_base_dimension,class boost::units::static_rational<-3,1> >,struct boost::units::list<struct boost::units::dim<struct boost::units::current_base_dimension,class boost::units::static_rational<-1,1> >,struct boost::units::dimensionless_type> > > >,struct boost::units::list<struct boost::units::scale_list_dim<struct boost::units::scale<10,class boost::units::static_rational<3,1> > >,struct boost::units::dimensionless_type> > >,void> const ,double> &):211
Is it a feature or a bug? ;-)
Did anything change? I did not find anything in the release notes of 2.0.1 and 2.1.0 mentioning a change in behaviour.

Nothing has changed in how G3log is retrieving and writing thr stack trace.
I suspect that when you updated your C++ tool chain this came with it

Not really. We are using both Visual studio and clang-cl. With clang-cl, we are still using the same version (14.0.6). I just pass the C++20 flag now instead of C++17. But even with passing C++17 (I did the test), I have the same output in the logs. As for Visual we went from 17.3 to 17.4 recently yes, but it seems a minor change.
I will do another test and compare between 1.3.4 and 2.1.0. I will change only this parameter (same compiler with C++17). I will let you know.

I did a test compiling from scratch my code (with standard C++17) linking with g3log 1.3.4. And then I recompiled from scratch linking with g3log 2.1.0. So that is the only parameter that changes (standard and compilers are the same). I confirm what I said earlier. This is g3log 2.1.0 that is more verbose.
You sure it is not related to this? https://github.com/KjellKod/g3log/pull/424

Interesting @morph208  so it's a Windows system?
Yes __FUNCSIG__ was introduced then and it could absolutely be the culprit. Have you tried just removing that from your g3log build and replace it with __func__ or __FUNCTION__?
I don't have a windows machine at the moment so testing this out for me would be very slow as I have to set up this environment (or rely on clunky cloud-CI)

Could you do something like this @morph208  and let me know what comes out of it?
https://github.com/KjellKod/g3log/pull/468/files

You can just replace the gcc/clang msvc branches with FUNCTION. That's what is what it was doing before.
Both PRETTY_FUNCTION and FUNCSIG give more verbose/accurate info. I can confirm for both.
It's actually mentioned in #424 that the stuff is more verbose with pretty func. FUNCTION will just give the name of the function.

I'll address this in a PR shortly. __PRETTY__FUNCTION__ and __FUNCSIG__ can be enabled via Cmake options. By default only __FUNCTION__ will be on (which I think as the case before #424). This way more verbose LOG output can be used or the terse one

@landwehrj + @morph208 please review if you have time: https://github.com/KjellKod/g3log/pull/470

@KjellKod Thanks for resolving this elegantly.

Of course. I'll wait a bit and then release a version with this in


Update content for the duplicate matching email

Context
This current email is not correct. It talks about "withdrawing" the "duplicate application". Whereas in fact we remove access to whichever candidate account was created latest. This PR addresses this.
Before

After

Link to Trello card
https://trello.com/c/1CrwwvTt/4247-rewrite-the-initial-duplicate-match-email

The email states access will be removed 5.business_days.from_now, i'm not sure this is accurate... The submission will be blocked immediately but unsure what the process is for locking the account. Are you able to shed some light @duncanjbrown?