suppress unwanted bracket matching

Fixes #792, but depends on atom/bracket-matcher#176.
You'll notice that there's a lot of _to-do_s for specs which I'll be happy to add once this whole approach is approved.
To do:

[ ] get atom/bracket-matcher#176 merged
[ ] add specs

As stated in the README, this package is no longer maintained and is deprecated. We recommend that people use the vim-mode-plus package instead. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!


Add WindowResizeOptions.Fit and implementation.  Fits RenderOutput to…

… the window using padding to maintain aspect ratio.
Same change as previous PR to master, but this time to Develop-8 branch.

Thanks!


[SPARK-40519] Add "Publish" workflow to help release apache/spark image

What changes were proposed in this pull request?
The publish step will include 3 steps:

First build the local image.
Pass related test using image of first step.
After pass all test, will publish to ghcr (This might help RC test) or dockerhub

It's about 30-40 mins to publish all images.
Add "Publish" workflow to help release apache/spark image.

Why are the changes needed?
One click to create the apche/spark image.
Does this PR introduce any user-facing change?
No
How was this patch tested?

Set default branch in my fork repo
Run workflow manually, https://github.com/Yikun/spark-docker/actions/workflows/publish.yml?query=is%3Asuccess

After some considerations, we'd better only expose the Spark version and Publish repo, and move inputs.scala/java in to matrix, because:

It's simpler, the release manager just need to select the version to publish and ignore the java/scala verison, it should be integrated in developer process.
we can simple to use matrix to generate all jobs, such as if we support the multiple java version in future, the workflow looks like:

Publish test to ghcr (ghcr/yikun): https://github.com/Yikun/spark-docker/actions/runs/3434472592/jobs/5725812762
Publish test to dockerhub (yikunkero): https://github.com/Yikun/spark-docker/actions/runs/3434473749/jobs/5725814930

cc @HyukjinKwon @zhengruifeng ready to go

Due to slow progress of docker official image, we might want to publish apache/spark first (3.3.0/3.3.1), if no more objection, I will merge this  today (The ability to publish with one click).
And I will also send a mail list later to see feedback about publishing apache/spark image first.

@HyukjinKwon @martin-g Thanks! Merge to master. Looks like no more feedback about publishing. Maybe let's publish after docker official image review completed.


No listeners executed; falling back to catch-all

Hi,
I am trying to test the adapter out of box. I registered my bot on dev.botframework and sideloaded it through teams.
I run hubot with adapter:
$ ./bin/hubot -a BotFramework --alias !
When I go into a channel and type:
@Rosie badger,
I expect a response from example.coffee:
robot.hear /badger/i, (res) ->
    res.send "Badgers? BADGERS? WE DON'T NEED NO STINKIN BADGERS"

Snippet of just running through shell without adapter ./bin/hubot:
rosie2> rosie2 badger

rosie2 badger

rosie2> [Mon Sep 18 2017 14:48:08 GMT-0400 (Eastern Daylight Time)] DEBUG Message 'rosie2 badger' matched regex //badger/i/; listener.options = { id: null }

[Mon Sep 18 2017 14:48:08 GMT-0400 (Eastern Daylight Time)] DEBUG Executing listener callback for Message 'rosie2 badger'

Badgers?  BADGERS? WE DON'T NEED NO STINKIN BADGERS

However, using MSTeams adapter,  I always get no listeners executed, falling back to catch all:
[Mon Sep 18 2017 14:28:49 GMT-0400 (Eastern Daylight Time)] INFO hubot-botframework-adapter: onBotEvents

[Mon Sep 18 2017 14:28:49 GMT-0400 (Eastern Daylight Time)] INFO hubot-botframework-adapter: Handling activity Channel: msteams; type: message

[Mon Sep 18 2017 14:28:49 GMT-0400 (Eastern Daylight Time)] INFO hubot-botframework-middleware: creating middleware...

[Mon Sep 18 2017 14:28:49 GMT-0400 (Eastern Daylight Time)] INFO hubot-msteams: toReceivable

[Mon Sep 18 2017 14:28:49 GMT-0400 (Eastern Daylight Time)] INFO hubot-botframework-adapter:
{
	"user": {
		"id": "2xxA",
		"name": "Will W",
		"tenant": "efc88xxxx3f835af",
		"activity": {
			"text": "rosie2  badger",
			"textFormat": "plain",
			"attachments": [
				{
					"contentType": "text/html",
					"content": "
Rosie badger
"
				}
			],
			"type": "message",
			"timestamp": "2017-09-18T18:28:36.619Z",
			"localTimestamp": "2017-09-18T14:28:36.619-04:00",
			"entities": [
				{
					"mentioned": {
						"id": "28:7db26xxxxxxx7ef3e9",
						"name": "Rosie"
					},
					"text": "<at>Rosie</at>",
					"type": "mention"
				},
				{
					"locale": "en-US",
					"country": "US",
					"platform": "Windows",
					"type": "clientInfo"
				}
			],
			"sourceEvent": {
				"teamsChannelId"<EMAIL_ADDRESS>				"teamsTeamId"<EMAIL_ADDRESS>				"channel": {
					"id"<EMAIL_ADDRESS>				},
				"team": {
					"id"<EMAIL_ADDRESS>				},
				"tenant": {
					"id": "efc8xxxxxxca3f835af"
				}
			},
			"address": {
				"id": "150xxxxx6511",
				"channelId": "msteams",
				"user": {
					"id": "29:1F9J5Oxxxxxxxxxxxxxxxxe476TUrYl9vgA",
					"name": "Will"
				},
				"conversation": {
					"isGroup": true,
					"id": "19:638xxxxxxxxxxx469ba@thread.skype;messageid=150xxxx6511"
				},
				"bot": {
					"id": "28:7db26cxxxxxxxxxxxxef3e9",
					"name": " rosie2"
				},
				"serviceUrl": "https://smba.trafficmanager.net/amer-client-ss.msg/"
			},
			"source": "msteams"
		},
		"room": "19:63860xxxxxxxxxxxxx6469ba@thread.skype;messageid=1505xxxxxx6511"
	},
	"text": "rosie2  badger",
	"id": "150xxxx16511",
	"done": false,
	"room": "19:6386079a42xxxxxxxba@thread.skype;messageid=1505xxxxxxx11"
}

[Mon Sep 18 2017 14:28:49 GMT-0400 (Eastern Daylight Time)] DEBUG No listeners executed; falling back to catch-all

Does it have to do with the text field having two spaces between 'rosie2' and 'badger'
"text": "rosie2  badger"
The mention is to Rosie, but the text has rosie2 badger.

I guess no one else has this problem :(

Hey Will. Sorry this issue slipped my mind. I'll take a look at it today. Are you by any chance copying and pasting the message into teams or typing it out directly?

Hi Matt, thanks for getting back, I am typing it out directly every time

The rosie2 part is because the adapter replaces the mentioned bot name in teams with the hubot name the all of the regexes have been registered with. Let me try to reproduce the issue locally and see if I can get a fix out.

okay, thanks a bunch, if you have trouble reproducing the bug, then just confirm with me that you have no problems, and i'll register another bot from scratch.
I am assuming since the adapter does a name replace, the BotFramework name DOES NOT have to match the local hubot name

You are correct in that the bot framework name does not need to match. Looking at your issue now.

This seems to be working for me.

I set up the bot using yo hubot and chose botframework as the adapter.
Then I updated the example.coffee script to uncomment the badger script.
Here is a zip of my bot: HubotBot.zip

Okay, I guess I messed up somewhere, and I'll start again tomorrow. I'll update on my progress then.

make sure you're running the latest hubot-botframework package

Ok, it works for me now too:

Somethings that I noticed that I did differently was:
1)
    "hubot-botframework": "^0.10.0",
vs
    "hubot-botframework": "^0.10.1",

and
2)
I also used npm link rather than static files in node_modules/

In the above image you can see my version, the symbolic link (8/29/2017) vs your new version (9/26/2017)
See if you have the same error if you use a symbolic link as per described:
https://hubot.github.com/docs/adapters/development/

The version might actually do the trick. There were quite a few large changes in the teams code between v 0.10.0 and 0.10.1

Oh I see. You probably grabbed the code because we hadn't published the latest version. you should be okay with just grabbing the npm package instead of pulling the code and doing a symbolic link. Not sure of any reason why you would want the symbolic link.

I'm going to go ahead and close this issue since it is working for you now.


Add support for HTTP status 419

resolves issue #1238

@kgriffs note that issue #1238 has been closed for the time being.


Added specLink method and changed href: "?" to href: window.location.search in reporter

Fixes bug where any query strings specified by the user (Example use case: specifying a jQuery version to include using a url query string) are overwritten when clicking on links.

What is the use case for this? And do you have tests that demonstrate the problem?

If you go to https://github.com/wheresrhys/jQuery-flickbook/tests/testSuite.php you'll see that a get parameter is passed in to the test page in order to specify the version of jQuery to include. At present clicking on any individual test/subsuite link replaces the entire GET query string, thus leading to jQuery not being included.
So that was the problem I had, but in general the links break if the user, for whatever reason, accesses the test page using a query srtring in the URL.

It seems OK to preserve the query params. We'll need to rewrite this for the HTML reporter and get some spec coverage around it.

This story in Pivotal Tracker: https://www.pivotaltracker.com/story/show/25484381


WebJob stopping and won't restart after scale down

This is a bit of a strange one - not sure if it will be easily reproducible.  My continuous webjob was running until this happened:
[06/02/2016 16:18:05 > 47a949: SYS INFO] WebJob is stopping due to website shutting down
[06/02/2016 16:18:06 > 47a949: SYS INFO] Status changed to Stopping
[06/02/2016 16:18:06 > 47a949: INFO] Job host stopped
[06/02/2016 16:18:06 > 47a949: SYS INFO] Status changed to Success
[06/02/2016 16:18:06 > 47a949: SYS INFO] Status changed to Stopped

This coincided with my server auto scaling down an instance.  I have a settings.job file in my project to force the webjob to run on a single instance:
{
    "is_singleton": true
}

So I assume the webjob was running on the instance that was shut down.  However, it did not start automatically on another instance, and nothing I did would make it start again.  Instead, its status remained at Initializing.  I couldn't stop it or start it.  I tried stopping and starting the website to no avail.  Eventually I decided to walk away from it for a bit, and a few hours later there were a bunch of HTTP errors on my server (possibly unrelated, this frustratingly seems to happen regularly) - I got the 'Http Server Errors GreaterThan 10 (Count) in the last 5 minutes' has been resolved for xxx' email.  At which point my webjobs started again:
[06/02/2016 19:32:17 > 61d75b: INFO] Job host started
It's a continuous webjob written in C#, that was published to the app service.
So this is the issue I experienced, and would like to confirm whether anyone else has experienced this issue of scaling down the number of instances of their app, and having their continuous jobs stop and not able to start them again?

Is there anything interesting (like errors) in the log files under D:\home\data\jobs\continuous\YourWebJob?

I have the following files:
job_log.txt (which has the messages from my original post)
Two status_ files (not sure why there would be two of them)
WebJobsSdk.marker
singleton.job.lock does have an error - here are the contents:
{
"OperationName": "Acquiring continuous WebJob singleton lock",
"AcquiredDateTime": "2016-06-02T21:27:52.9539855Z",
"StackTrace": "   at System.Environment.GetStackTrace(Exception e, Boolean needFileInfo)\r\n   at System.Environment.get_StackTrace()\r\n   at Kudu.Core.Infrastructure.LockFile.WriteLockInfo(String operationName, Stream lockStream)\r\n   at Kudu.Core.Infrastructure.LockFile.Lock(String operationName)\r\n   at Kudu.Core.Jobs.ContinuousJobRunner.TryGetLockIfSingleton()\r\n   at Kudu.Core.Jobs.ContinuousJobRunner.<>c__DisplayClass19_0.b__0()\r\n   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)\r\n   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)\r\n   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)\r\n   at System.Threading.ThreadHelper.ThreadStart()"
}
The error timestamp indicates that this occurred a couple of hours after my webjob started again.  Any thoughts on whether this may have contributed to the issue?

That's actually not an error, but is just a marker that tells us the stack at the time the lock was acquired.
Not sure what's going on, and will need to investigate in more depth later.
BTW, please use code blocks to make things more readable. :)

OK, thanks David.  When I saw the stack trace, I just assumed it was an error :).
I've updated the posts to use code blocks :).

This is the normal stack where the lock is acquired, in StartJob (code).
What the logic is supposed to do is:

each instance tries to get the lock for the singleton job every 5 seconds
one instance has the lock
if that instance dies, another is supposed to pick it up

Possible theories why it wouldn't happen:

singleton.job.lock is still locked by something for some reason
There is no other instance to pick it up

If you hit this again, check if you are able to delete the lock file.

OK, thanks for that David.  Good to know for the future, and hopefully if anyone else experiences the issue they can find this thread and report back as well.

Hi
If the problem persists and is related to running it on Azure App Service, please open a support incident in Azure:
https://learn.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request
This way we can better track and assist you on this case
Thanks,
Joaquin Vano
Azure App Service


Add syslog to metron_agent_windows

A/C: As an operator I should be able to see logs from metron_agent in
syslog destination syslog_daemon_config defined in my cf manifest.
The support for the new environment variables has been added to AWS
stemcell version 0.0.73 and above.
[#133698951]
https://www.pivotaltracker.com/story/show/133698951
Signed-off-by: Natalie Arellano<EMAIL_ADDRESS>

hey @ahevenor @wfernandes , any thoughts on this pr? thanks!

@mavenraven thanks for your patience. This got moved to our icebox despite being marked as schedule. I just dragged it in for review in our next planning meeting.

@mavenraven we are going to hold off on this until we get the windows stem cell for GCP.  I will schedule once that is complete.

@ahevenor have you been able to test this out on the GCP stemcell?

We are trying to migrate to using syslog-release and removing this functionality from metron. Can we use syslog-release here?

@jasonkeene Windows stemcells do not have rsyslog or any other syslog forwarder outside of the one in the bosh agent so we cannot use syslog-release for this functionality as of yet

@cppforlife We would like to move this functionality out of metron_agent. I saw your comment on the linked story. Did anything come from your discussion?

Hey @jasonkeene. @aminjam and I chatted with @cppforlife about this. We agreed that using syslog-release is the "right" solution, but it's not urgent for the upcoming GA of BOSH Windows.
Would you mind to merge this in so we can have full syslog support for CF?
We'll prioritize the syslog-release work on our end for post-GA.


Exporters intro: add data field?

Originally posted by @chalin in https://github.com/open-telemetry/opentelemetry.io/pull/3931#discussion_r1481284558

@svrnm - instead of {{ if in (slice "python" "js" "java") $lang -}} should a field be added to the data file?

Originally posted by @chalin in #3931 (comment)

@svrnm - instead of {{ if in (slice "python" "js" "java") $lang -}} should a field be added to the data file?

I hope for that being not needed eventually, so it like to keep it in place, but we can make it look better :D


rename lastIDKey

#1182
I think the only place to rename lastIDKey is in importAutoIncrementID function.

🚨 fyi: please see https://twitter.com/CosmWasm/status/1620783214125256704

Thank a lot for your PR and welcome as a contributor hugs
Please see #1198

Such a sad news

Thank you very much for doing chore work. This is not always rewarding but I appreciate this a lot! 🥇


Multistage Docker Build

This is a proposal how Multistage Docker Build can be used instead of using build.sh in a potentially undefined environment.
Additionally it support cloning a certain branch/tag/commit hash of the repo instead of cloning the latest commit from master branch.

Hi Torsten,
Happy to hear that you like the concern separation that i tried to create with separated images.
I see that you propose a different style to create the images. I would like to share with you an idea that needs your attention. I purpose to use a build script and to do the workspace clone locally and not into the docker image in order to copy only the files that we really need for the image to work and prevent any node_modules, git files to be added into the image. For example the security scans red flagged different node_modules that we don't really need but are installed during installation process by browserify, ionic and other deps. So, in order to avoid any security related problems and because we don't need that code we do the cloning and installation locally and after that we pick and add only the files that we really need for the purpose of the image.
One other thing, i understood that Sinica was not able to explain why we use the npm run dev-install command and not the npm install one. I refactored the entire build process that is happening for the Wallets, SSApps and bundles. The build process is contained into the octopus.json file and will be released into octopus-freeze.json with the first new release. Once the build process will be available to be used we will change from npm run dev-install into npm install as it should be. So the npm run dev-install command is temporary used.
What do you think about the points that i shared with you?


Bug: Install fails with ZSH

Bug report

Install using ZSH and the installer script fails with the error:
* Copying archive contents...
zsh: no matches found: /root/.sdkman/src/*
'': command failed with exit code 1.

Inspecting the directory shows that there indeed is no src folder under /root/.sdkman/:
$ ls ~/.sdkman/
candidates  etc  ext  tmp  var

It continues to work with bash.
To reproduce

$ curl -s "https://get.sdkman.io" | zsh

System info

Ubuntu 20.04.6 LTS
zsh 5.8 (x86_64-ubuntu-linux-gnu)
sdk script: 5.18.1
sdk native: 0.2.8

Hi @jsundqvist!
Note that the SDKMAN! installer script must not be run as root! In fact, it is strongly discouraged to install/run SDKMAN! as root, and doesn't work out of the box.
It is intended to be run as a user-level script, installed in your HOME directory.

@marc0der I wonder if it wouldn't be easier if we would just fail the installation when the install script is ran as root.
We could maybe do something like
if [[ $EUID == 0 ]]; then
    echo "SDKMAN! is not intended to be installed as root. Try running the installation as an unprivileged user. "
    exit 1
fi

I'm not sure that running it as root is the problem. I often do this when installing it in a Docker container without issues. I suspect that the real problem is that @jsundqvist is piping the install script through zsh. We do not support this, so imo is not a bug.
I'm not at a computer right now so will confirm this later.

Hey guys, thanks for your replies.
I have a nightly container build that has been piping the install script through zsh for over 3 years and it has been working flawlessly until May 9. The first paragraph of the install page says "We also support Bash and ZSH shells.", so assuming this should work is not completely unreasonable IMO.
I understand that not everything can be officially supported, but from my point of view this is clearly a regression, as I hope you can understand :). I admit I don't know if it's the installer script or zsh that has changed, but I really think it should keep working as it has for a very long time.
(It might even be that I had pipe through zsh to get things to work properly in the container, but I can't say for sure, I don't remember).

@marc0der
The problem is this line
rm -f foo/*

It works fine in Bash but in zsh it asks for confirmation if -f is used in conjunction wit *
weilero@158269S0 ~ % rm -f foo/*
zsh: sure you want to delete all the files in /Users/weilero/foo [yn]? n

If you prefix some of the rm's with a test the script works with zsh again. These are the 3 places which need to be fixed:
# copy in place
echo "* Copying archive contents..."
[[ -f "$sdkman_src_folder" ]] && rm -f "$sdkman_src_folder"/*

echo "* Cleaning up..."
[[ -f "$sdkman_tmp_folder" ]] && rm -rf "$sdkman_tmp_folder"/sdkman-*

echo "* Copying archive contents..."
[[ -f "$sdkman_libexec_folder" ]] && rm -f "$sdkman_libexec_folder"/*

Great find @helpermethod!
Indeed these are changes that I made recently. The short-term solution would be always to install using bash, but we can certainly look at making this compatible with zsh if needed. In my defence, all the instructions on our site do suggest installing SDKMAN with the following command ¯_(ツ)_/¯
curl -s "https://get.sdkman.io" | bash

@marc0der
The problem is this line
rm -f foo/*

It works fine in Bash but in zsh it asks for confirmation if -f is used in conjunction wit * 😕
weilero@158269S0 ~ % rm -f foo/*
zsh: sure you want to delete all the files in /Users/weilero/foo [yn]? n

If you prefix some of the rm's with a test the script works with zsh again. These are the 3 places which need to be fixed:
# copy in place
echo "* Copying archive contents..."
[[ -f "$sdkman_src_folder" ]] && rm -f "$sdkman_src_folder"/*

echo "* Cleaning up..."
[[ -f "$sdkman_tmp_folder" ]] && rm -rf "$sdkman_tmp_folder"/sdkman-*

echo "* Copying archive contents..."
[[ -f "$sdkman_libexec_folder" ]] && rm -f "$sdkman_libexec_folder"/*

@helpermethod I did the same thing before look here for a solution...  🤣

Since the script would write to your .zshrc anyway, you are good to switch over to bash to run the curl command as shown in the Installation instruction, and once successfully installed switch over to zsh to run the source and sdk version commands.


Wallet crashes when receiving coins from mining

App crashes when receiving coins generated from mining. Not when receiving coins from pools that mine to their address and then transfer to your address, but when mining directly, like p2pool or solo mining.
When a block is found and coins credited to the loafwallet address, the app crashes and keeps looping. Have to delete app and download it again to work. Very frustating.

Dont mine to Loaf Wallet, Mine to your core Wallet.    Send the coin from Loaf out to your core wallet and resync.    SPV isnt always able to handle mining activity.     We experienced this with Slice Wallet on Sumcoin.

@ikolubr  Agree with @sumcoinlabs .  Realize Loafwallet is an SPV Wallet that maintains a fraction of the transactions onto your mobile.  A full-node will be a better way of having a full, fresh copy of the blockchain....  You could run a legacy PC running onto your network setup to run Litecoin-QT.
Note also the network quality will affect the mobile for any app....for a peer-to-peer network the bar is far higher.


Blob.setBinaryStream and write() fetches column entirely + side effects ResultSet.getBlob/Clob

Driver version
8.2.2.jre8
SQL Server version
Microsoft SQL Server 2014 - 12.0.4100.1 (X64)
Client Operating System
Windows 7 x64
JAVA/JVM version
1.8
Table schema

CREATE TABLE table ( id numeric(10,0) primary key ,data1 VARBINARY(MAX) ,data2 VARBINARY(MAX) ,data3 VARBINARY(MAX) )
Problem description
I need to append to a blob columns. They are very large to fetching every time (~50mb).
When I use JPA and have an Entity with two fields Blob a; Blob b; the first is always fetched fully. This is reproduced in PROBLEM2.
And PROBLEM1 is I even cant do this with plain JDBC.
try(ResultSet r = conn.createStatement().executeQuery("select data1, data2, data3 from table where id = 1")) {
Blob b = r.getBlob("data1");
try(OutputStream o = b.setBinaryStream(b.length() + 1)) {
o.write((byte)1); //triggers load all data (50Mb) from data1 column PROBLEM1
o.flush();
}
r.getBlob("data2");
r.getBlob("data3");//triggers load all data from data2 column PROBLEM2
}
Expected:
PROBLEM1 - blob payload is not fetched totally. Only appended bytes go to DB
PROBLEM2 - no side effects
How can i append only bytes to columns without fetching them entirely? Thank you.

When I use JPA and have an Entity with two fields Blob a; Blob b; the first is always fetched fully

This is expected behavior, the mssql-jdbc driver does not support streaming for multiple LOB objects at the same time. Users must finish their work with the first LOB before moving the ResultSet cursor via ResultSet.next() or moving onto other LOBs within the same ResultSet. In such situations, users should also call LOB.free() or the LOB will be loaded into memory.
Regarding PROBLEM1, it seems you're attempting to write data into a BLOB object you recieved from the server. The correct way to do this is to read the server's BLOB object byte by byte via Blob.getBinaryStream(), append the necessary bytes to the local buffer object, and then create a new Blob via Connection.createBlob(). You can then use Blob.setBinaryStream() and set the local byte buffer.
Pseudo code:
try (Connection c = DriverManager.getConnection(connString);Statement s = c.createStatement;ResultSet rs = s.executeQuery("select data1, data2, data3 from table where id = 1") {
    Blob b1 = rs.getBlob("data1");
    byte[] blobBuff = readInputStreamToByteArray(b1.getInputStream());
    byte[] desiredBuff = concatTwoByteArrays(blobBuff, appendBuff);
    Blob blobToSend = c.createBlob();
    try (OutputStream o = blodToSend.setBinaryStream(desiredBuff.length())) {
        o.write(desiredBuff);
        o.flush();
    }
    b1.free();
}

Thank you for the response.

This is expected behavior, the mssql-jdbc driver does not support streaming for multiple LOB >objects at the same time. Users must finish their work with the first LOB before moving the >ResultSet cursor via ResultSet.next() or moving onto other LOBs within the same ResultSet. In such >situations, users should also call LOB.free() or the LOB will be loaded into memory.
Problem is that I cannot do that with JPA. But thats not that crytic as I hoped I can manage this manually wth JDBC.

And the second answer is that the real nice way to handle Blobs? I need to load entire blob in memory always? Why there is a need to fetch all data if only want to append several bytes? And what if I have 100Mb in Blob? Transfer all data to app server append and back? Its useless. Dont you think?

The JDBC API objects were designed with Oracle database in mind, these APIs seem sub-optimal at times when working with a different server such as SQL Server. The concept of LOBs are directly supported in Oracle and these APIs behave differently on Oracle server, e.g. they directly support LOB streaming and the server communicates differently with the driver. SQL Server has no concept of Blob/Clob/NClobs, and their mapping is currently varbinary(max)/varchar(max)/nvarchar(max). In the case where a LOB object is too large to be loaded into memory, LOB objects can be used to read the LOB object section by section.

Thats sad. Thank you.


Lane transparency

What feature do you want to get added on the base engine?
When in middlescroll up or down theres no option to have a lane transparency and it makes it a little difficult to see the colors would be a nice addition. Also an option to disable the opponents side transparent middle scroll would be nice since its distracting! Good engine keep up the good work!
To test your sight, and reliability, please select the option of what should NOT be requested.
Stage Editor, 6K+ support, and winning icons.

https://prnt.sc/25mmp19

https://prnt.sc/25mmp19


Fix exception 'Read access is allowed from inside read-action' with 2023.3

Closes https://github.com/getappmap/appmap-intellij-plugin/issues/503
Closes https://github.com/getappmap/appmap-intellij-plugin/issues/507
Closes https://github.com/getappmap/appmap-intellij-plugin/issues/509
Closes https://github.com/getappmap/appmap-intellij-plugin/issues/510
Closes https://github.com/getappmap/appmap-intellij-plugin/issues/511
This PR fixes the required read accerss. It's unclear if the SDK is supposed to handle this or not, but we're safe-guarding it now to work with the changed behavior of 2023.3

:tada: This PR is included in version 0.54.0 :tada:
The release is available on:

v0.54.0
GitHub release

Your semantic-release bot :package::rocket:


[Bug] App crashes when add something to the shopping list from the home menu

The app crashes when I add something to the shopping list from the home menu.
It doesn't matter what I add.
Device: Google Pixel 5
OS: Android 12.1 - GrapheneOS
App version: v.1.3.5

We already fixed that bug on the dev branch here we just did not want to push a new version live yet due to the small amount of changes, thanks for letting us know anyway, I will push the new version live in the next few days.

The update 1.3.6 is now live in the playstore.


Messaging creates new config where it should not

Messaging interface (line 351) uses Config.create()
This method should never be used from inside Helidon components, as it may produce invalid config (or even throw an exception - such as with invalid meta configuration).
Please use Config.empty() instead, or find another way of obtaining a valid configuration.

@tomas-langer The change is backward incompatible, this fix should be targeted for 3.0.0


353 pr

Coverage decreased (-27.6%) to 34.457% when pulling 259f3cd19241f74b3e2f27bf40e0ce8749d5f20e on 353-pr into 0e03421b5602cada19836324a66dfdb57001bd47 on dev.


[1.8.0]OTP22 or OTP-<IP_ADDRESS>  generate config fail

Environment

VerneMQ Version: 1.8.0
OS: centos7
Erlang/OTP version (if building from source): 22 or <IP_ADDRESS>
VerneMQ configuration (vernemq.conf) or the changes from the default
Cluster size/standalone:1

Expected behavior

Please describe the expected behaviour.

Actual behaviour

Please include minimal steps to reproduce the issue, if possible.

./vernemq start
./vernemq: line 172: /root/vernemq-1.8.0/_build/default/rel/vernemq/bin/../erts-<IP_ADDRESS>: Is a directory

./vernemq config generate`
./vernemq: line 385: /root/vernemq-1.8.0/_build/default/rel/vernemq/bin/../erts-<IP_ADDRESS>: Is a directory

Thanks for the report. Does it still work with older versions of OTP, like OTP 21.2?

@larshesel
OTP21.3 and OTP21.2 also fail

what is the last commit you see for the tag? We had to bump the tag due to some package pipeline issues. Perhaps you caught the tag before we bumped it? The commit at the tag 1.8.0 should be f639ba9148a4d8d1a50c5182adbc201b0523559b

make rel
===> Running cuttlefish schema generator
===> Starting relx build process ...
===> Resolving OTP Applications from directories:
          /root/vernemq-1.8.0/_build/default/lib
          /root/vernemq-1.8.0/apps
          /usr/local/lib/erlang/lib
          /root/vernemq-1.8.0/_build/default/rel
===> Resolved vernemq-fatal: Not a git repository (or any of the parent directories): .git+build./bin/sh:line1:syntaxerrornearunexpectedtoken`('/bin/sh:line1:`(gitrev-list--countfatal:Notagitrepository(oranyoftheparentdirectories):.git..HEAD'.reffatal:Notagitrepository(oranyoftheparentdirectories):.git
===> Including Erts from /usr/local/lib/erlang
===> release successfully created!

and _build/default/rel/vernemq/releases/start_erl.data is bad
10.2 fatal: Not a git repository (or any of the parent directories): .git+build./bin/sh:line1:syntaxerrornearunexpectedtoken`('/bin/sh:line1:`(gitrev-list--countfatal:Notagitrepository(oranyoftheparentdirectories):.git..HEAD'.reffatal:Notagitrepository(oranyoftheparentdirectories):.git

so ...

Can you try from a fresh clone and paste the enture output from start to finish of make rel ?

I'm not able to replicate this, btw.

i download the https://github.com/vernemq/vernemq/releases/tag/1.8.0 tar.gz file
ok， i try to clone the repository

It doesn't work correctly when building from the tar.gz as the build system relies on the files to be in a git repo - I think that's the problem you experience.

Yes ,this time ,make rel is correct, Thank you!


[HUDI-5095] Flink: Stores a special watermark(flag) to identify the current progress of writing data

Change Logs
AbstractStreamWriteFunction could process watermark from StreamWriteOperator and send WriteMetadataEvent with the watermark of write function to StreamWriteOperatorCoordinator. StreamWriteOperatorCoordinator stores the min watermark of WriteMetadataEvents from subtasks into the extra metadata of HoodieCommitMetadata. Meanwhile,  StreamWriteOperatorCoordinator advances the min watermark for subtasks in which no data has written, and does not advance watermark for commit on empty batch.
Impact
StreamWriteOperatorCoordinator stores the min watermark of write function into the extra metadata of HoodieCommitMetadata to identify the current progress of writing.
Risk level (write none, low medium or high below)
None.
Documentation Update
None.
Contributor's checklist

[x] Read through contributor's guide
[x] Change Logs and Impact were stated clearly
[x] Adequate tests were added if applicable
[x] CI passed

Can you elaborate a little more what is the end-2-end user story here?

The watermark could identify the current progress of writing data and infer the committed partition

Can you sketch the inference details a little more?

@danny0405, we could use watermark to infer the partitions need to commit  and need to create as follows:
hiveBeforeCommitEndTime = waterMarkToCurrentPartitionTime(hiveBeforeCommitEndTime, commitType);
hiveAfterCommitEndTime = waterMarkToCurrentPartitionTime(convertReadyCommitTime(hiveAfterCommitEndTime, watermark, partitionInterval), commitType);
List<List<String>> hiveBeforeNeedCommit = getNeedCommitList(hiveBeforeCommitStartTime, hiveBeforeCommitEndTime, partitionInterval, commitType);
List<List<String>> hiveAfterNeedCommit = getNeedCommitList(hiveAfterCommitStartTime, hiveAfterCommitEndTime, partitionInterval, commitType);

@danny0405, could you help to review this implementation again?


Can uncertainty be factored into quantities, and carried through transformations/manipulations?

https://en.wikipedia.org/wiki/Measurement_uncertainty

All measurements are subject to uncertainty and a measurement result is complete only when it is accompanied by a statement of the associated uncertainty, such as the standard deviation. By international agreement, this uncertainty has a probabilistic basis and reflects incomplete knowledge of the quantity value. It is a non-negative parameter.

The BIPM publishes the "Guide to the expression of uncertainty in measurement", which is widely accepted as the standard.

This how-to guide breaks it down in a much more digestible way.

Wonderful tool to help confirm test results: https://uncertaintycalculator.com/


Hyperx to Snabbdom

I created hyperx-to-snabbdom a few months ago as an approach to solving substack/hyperx/issues/36 in a non-opinionated manner that could satisfy as many library authors as possible.
It works for my use case, but I'd be curious to hear your feedback about it.
Cheers and thanks for the awesome work you're doing here.

Have a look at my fork of your solution (i did it like this as you only have a gist) , the original adds space everywhere, and it should probably just in text nodes

Thanks! @graforlock I'll update my gist and publish a new minor.

It may have more cases like these and needs some testing I believe

@graforlock I am not really using this anymore, having moved to Hyperapp, but I should really make a repo for this and add tests proper. 😅

@graforlock Published 1.1.0. 🎉


remove tool tip

What does this PR do and why?
Remove Tooltip from MemoFormInput, this was an unrelated comment in https://github.com/jbx-protocol/juice-interface/pull/1297/files/2ade91865d8ebdece5355eb373fb9f6ebc3be033#r925329483.
I'm addressing this change in another diff because it's unrelated to the sticker icon change in the previous diff.
Screenshots or screen recordings
It's hard to screen shot, if you go to http://localhost:3000/p/ganggangdao, go to payment, hover sticker icon, it will not longer show tooltip

[x] I have evaluated the Approval Guidelines for this PR.
[x] I have tested this PR in all supported browsers.
[x] I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #1297

PR #1506   👈

This comment was auto-generated by Graphite.

Graphite Merge Job
Current status: ⏳ Queued to merge
This pull request is currently queued to be merged as part of a stack.
This comment was auto-generated by Graphite.

Job Reference: FBdSlkLHRNUzrDzyrjTF


We need to advisitor this PureLB！

I think that the LB is very useful.

Thank you for letting us know!
This repo is a mirror so we don't check it that often. The primary repo is https://gitlab.com/purelb/purelb and we have a slack channel for discussion at https://kubernetes.slack.com/archives/C01BCB7U031


ssh-agent module: run in foreground as upstream recommends

I'm using it here and it works perfectly fine.
Systemd's official recommendation is that everything should run in the foreground.
Things done

[X] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] OS X
[ ] Linux

[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

Things should only run in the foreground if they provide startup notification to systemd. Otherwise the unit will reach "started" state despite not being ready. (Of course the unit may not be ready if it forks either, but that's generally the convention.) Does ssh-agent do startup notification?

Thank you for the quick feedback @edolstra. ssh-agent does not use sd_notify to signal readiness (which would change the type from "simple" to "notify").
This issue is similar to the thread on #14881 - the same arguments on that PR would apply here.
If we keep it forking shouldn't we review all the other services that are set to simple or blank to verify that the forking approach actually finishes initializing before forking and then changing them to forking instead?

@peterhoeg such a review makes sense. If there are simple services that are not actually ready upon exec(), that's a bug waiting to happen. Using simple wherever possible makes sense, but we must take care not to break unit ordering.
Waiting for the ssh-agent socket to appear means the unit will at least be closer to a true "ready" state, but I'm not familiar enough with ssh-agent to say whether that's acceptable. It's more code to accomplish what the previous definition did out of the box, though.

I was thinking about this earlier, and in general (regardless of simple or forking), wouldn't it make sense to ship an extremely small helper binary that can either probe a port, socket or check for the presence of a file and simply exit(0); when it appears and just sleep in-between in increments.
This could be executed as a Post action for pretty much all the services as without a code review for every service, there is really no way to know if a particular service is ready.
The other way to approach this is to simply say - I don't care. Services can come and go, so if you are depending on a service, you also need to gracefully be able to deal with it not being there and simply try again a bit later. Systemd should be restarting any failed services, but there will be a window where that service is not ready. I must admit, I'm leaning towards this...

Inferring a daemon's internal state from the existence of files or sockets seems brittle, in general. It seems impossible to get around knowing a fair bit about the daemon the service unit is executing, and this proposal seems to increase the need to know what the daemon is doing under the hood. Being ready upon fork() is at least idiomatic, not sure the same can be said about "this file exists".
For existing simple services, adding ExecStartPost to ensure readiness using your proposed helper to avoid boilerplate sounds like a good plan, but it's not quite clear to me what is gained by doing so for forking services, except in cases where the daemon forks "just because" and can be made not to.

Just because something is forking, doesn't mean it's ready. And a standardized way to at least let us WaitForSomething(tm) would make things easier to maintain.
Do you have an example of units where we absolutely can only continue if the service is actually ready?

Just because something is forking, doesn't mean it's ready.

Sure, I still hold that you need to know quite a lot about what a daemon is doing to sanely infer anything from the existence of files, whereas fork() is a long-standing convention.

Do you have an example of units where we absolutely can only continue if the service is actually ready?

No. The issues I typically encounter have to do with ordering, not readiness. Most of the services I use don't appear to expect anything more than "this process is running and will eventually respond".

We basically have the following options when it comes to services and readiness:

Socket activation
Readiness signalling via sd_notify
Readiness signalling by taking a dbus BusName
Double forking, where the forking only happens when init is done
simple services where we don't care about state

Of those 5 options only the first is guaranteed to work as the kernel will buffer connections to the socket.
Options 2 and 3 will indicate the service is up, but will not make a difference if the service goes down.
Option 4 may only continue if the service is up, but there are no guarantees.
Option 5 - whatever basically.
But the only time this actually makes a difference in the way things are currently implemented is during startup. If a dependent service goes down, anything depending on that STILL needs to handle that situation.
So us adding ExecStartPost only deals with with startup scenario anyway, which is why I find the whole ordeal a little pointless.

@peterhoeg I agree that readiness without an explicit protocol is hopeless in general. I disagree that the potential for run-time failures invalidates readiness, though. My understanding is that readiness mainly factors into the creation of optimal activation plans. If "ready" doesn't mean "actually ready", then invalid plans may result --- embracing the systemd way means caring about readiness. Anyway, I don't think there's much point in taking this further here (I must confess that I find the topic as such more interesting than this PR itself, I don't mean to be difficult).

Closing this because it's not an improvement. Type=simple is worse than Type=forking if the latter forks after reaching readiness, which is the case for ssh-agent (I just checked the source). In fact Type=simple is almost never a good idea because of the race condition it introduces. The critical postcondition of a systemd service is that when it reached "started" stage, it's ready to accept connections. Otherwise units or scripts that depend on the service will fail randomly, e.g.
systemctl --user start ssh-agent
ssh-add ...

With Type=simple, the latter call will fail randomly, so you'd have to introduce a loop to wait for readiness. And of course that loop will hang forever if the service dies in the meantime.
What would be an improvement is to add a one-line patch to ssh-agent to call sd_notify() at the appropriate time, or (more complicated) support socket activation.


Update comparison.go

Describe your changes
Added NotEqMatcher and associated methods to comparison.go

@roxanne-mackinnon thank you for your contribution. I see that you have closed it, was that by mistake?

@ovaistariq No, i intended to close it, my work is not complete. I did not mean to make a pull request to the main repository. There are still some other files that need to be changed, so please do not merge this.

Sounds good. Thanks for clarifying


Content issues on Whack-the-mole completion dialog

Whack-the-Mole capitalization, and overflowing button label see marked up screenshot:

It looks like the title of this skillmap is pulling from the wrong place.  We should be using the Skillmap name there, not the section name.  Section names are supposed to be all lowercase and hyphenated, skillmap names don't need to be.
Not sure how to fix the button issue.  I thought I saw the titles wrapping in testing Friday?


Failed to connect to Jupyter notebook.  TypeError: Only absolute URLs are supported

Bug: Notebook Editor, Interactive Window, Editor cells
Steps to cause the bug to occur

load file.ipynb (which had previously work)
Run first cell
Above error reported

Actual behavior
Only the error appeared
Your Jupyter and/or Python environment
Please provide as much info as you readily know

Jupyter server running: Local
Extension version: 2020.5.80290
VS Code version: 1.45.1
Setting python.jediEnabled:  false
Setting python.languageServer:  Microsoft
Python  version: 3.8.1
OS: Windows
Virtual environment:  N/A | ...
 Is this a notebook that is running locally? Would you be able to provide the notebook so we can attempt to reproduce the error?

Yes it is running locally and had been working fine  really confused

I see in the stack trace you provided above that the error is being thrown by the Azure Dev Spaces extension. Is what you're currently trying to do dependent on the Azure Dev Spaces extension? If not, could you try disabling that extension, reloading VS Code, and letting me know if that changes anything?

here is the file

I did get an error to install that in in the hope that it might resolve the issue I did happy to remove.  I Not only restarted, I rebooted ... I will now remove that and restart

:( no good

Ahh I uninstalled Azure CLI Tools and bingo.  All working again!

Glad to hear it! :)

This was the exact same issue for me. Note, that Spark & Hive Tools is dependent on Azure Account, so that has to be uninstalled too.


VOD issue, does not fully download full stream.

@Franiac I have a slight issue, i was trying to download an old vod from twitch and it only downloads a portion of it, it only downloads maybe 9-10 minutes of the stream, im not sure if its because the stream is older or something else is affecting it, but it dosent happen on any of the new streams, atleast not yet just wondering if it can be fixed in an update or something or it just has something to do with the stream, also heres the link to the stream VOD that wont fully download https://www.twitch.tv/joshimuz/v/50458662      By the way thats not the only one that dosent fully download a lot of the older streams have that issue as well which is why i think it may have something to do with them being older VOD'S not sure though.

@DarkOblivion This issue is very common, but I cannot do anything about it. It only happens to VODs that are older than 2014. I have never seen this related to newer VODs.
The thing is that FFMPEG throws some weird errors in the encoding process that I basically do not understand. I am not the video-audio-media-kinda-guy when it comes to software development.
I will close this issue knowing that it will popup again. But the only thing I could do is restricting TL to VODs newer than 2014.

@Franiac ok thanks for the information, i appreciate it.


Update homematic add-on to use Bashio #725

Change bash to bashio.
Replace jq with bashio.

There are unrelated commits in this branch. Please start a fresh branch each time you start working on something new.


Theme fixes for Button style and footer

New Mockup
Please check assets/css/global.css, design-assets folder images, and figma files for updated style guides. Any new pull request should use the updated color, spacing, and sizing variables.
No Bootstrap or jQuery
Please refrain from adding Bootstrap or jQuery to the site. These pr's will be closed. They overwrite global styles. Vanilla CSS and JS is way better now anyways 😊
New Task:
What is the task
<Detail the problem/task>
Fixed Dark and light theme backgrounds for the footer section and the subscribe button.
Who is the task for?

[x] I created this task for me to complete, I will create a PR soon.
[ ] I created this task for someone else to claim.
[ ] I think this is a task that multiple people can do

Confirm all of the following:

[x] I have looked at all the issues currently available and this does not exist or overlap with another ticket

⚠ PLEASE ONLY SUBMIT A PR FOR THIS TASK IF THIS TASK WAS AVAILABLE FOR YOU TO CLAIM

This issue is for Blog.html page


EvaluationFrequency cannot be greater than MuteActionsDuration

Describe the bug
Running az monitor scheduled-query create, specifying --evaluation-frequency 1h and omitting --mute-actions-duration, returns EvaluationFrequency cannot be greater than MuteActionsDuration.
If we do not wish to mute actions for any duration, how could the evaluation frequency ever not be greater than the mute action duration?
Related command
az monitor scheduled-query create
Errors
InvalidRequestContent: The request content was invalid and could not be deserialized: 'EvaluationFrequency cannot be greater than MuteActionsDuration'
Issue script & Debug output
n/a
Expected behavior
The scheduled query to be created as specified.
Environment Summary
azure-cli                         2.49.0
core                              2.49.0
telemetry                          1.0.8
Extensions:
aks-preview                       0.5.41
scheduled-query                    0.2.2
Dependencies:
msal                              1.20.0
azure-mgmt-resource               22.0.0
Additional context
No response

Thank you for opening this issue, we will look into it.

@AllyW, please help look at the issue.


Create locale_el-GR.ini

Start building locale_el-GR.
Most text missing but it's a start

This will not be accepted. It seems you did not read the contributing document, specifically the one for locales.

I've uploaded file to Crowdin for you this time, next time please directly edit on https://crowdin.com/translate/gogs/1/enus-el.


Be friendly with special html chars in values

Hey guys, I’ve stumbled over the case where I wanted to select a value containing an ampersand (“&”) from the autocomplete box, and the escaped value (“&”) was inserted into the text input.
This PR fixes the issue.
I would appreciate if you could push a release to pip soon. Thanks!

Coverage remained the same at 86.6% when pulling a65e198af54a805c8726e5690067967a73085579 on davidaurelio:master into aaeeeba9a0546c6f8f369a45e3bef3268d56ff8d on yourlabs:master.

Thanks!
Do you feel like adding a test for this by any chance? :)

Could you point me to your JS tests, please? I took a quick look at the project structure, but didn’t discover them immediately. Thanks!

Probably because they are in python due to my lack of Js tdd skills.
See tests/widget.py
Le 26 févr. 2015 21:30, "David Aurelio"<EMAIL_ADDRESS>a écrit :

Could you point me to your JS tests, please? I took a quick look at the
project structure, but didn’t discover them immediately. Thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/yourlabs/django-autocomplete-light/pull/378#issuecomment-76263983
.

Guys, I’ve been looking very hard at tests/widget.py, but cannot figure out how JavaScript is supposed to be tested there. Probably because it isn’t? Did I fail to see something?

I tried to get test.sh to run, but I’m on OS X without xvfb-run. I’m sorry, but it seems I won’t be able to contribute a test.

@davidaurelio
Thanks for your fix, which has now been merged.
@jpic has added a test for it, which wasn't trivial.

\o/ thanks a lot


Compiler Warning CS0618 usage of IStringLocalizer.WithCulture

The current dev branch outputs warning regarding the deprecated usage of WithCulture as documented here: https://docs.microsoft.com/en-us/dotnet/api/microsoft.extensions.localization.istringlocalizer.withculture?view=dotnet-plat-ext-3.0
This warning popped up due to the upgrade to .NET Core 3.0.
In this StackOverflow article is a possible implementation on remedying the issue.
Personally I feel code is to be at least compiler warning free.

Thanks, I will fix it. 👍🏼


Display in random order

Hello!
I think it might be nice to display servers in a random order on each page view — that way people will see a different list and it might help cut down on the first few servers listed getting overloaded/spread out sign ups?

I actually quite like this idea, and so does @hack13. We'll be adding this.

Awesome! Thank you 🙏🏻

Closing as this has been patched and applied by @Pokefan5

Fantastic! Thank you for implementing this suggestion!


Persistent GPU memory errors

I'm working with the L_Passthrough project and I can't seem to find a way to provide Unreal with a sufficient amount of GPU memory. I have the same issue on two different machines, one with an 8GB card and another with 16GB. No clear reason as to why it might be lacking resources and Task Manager doesn't show any other applications consuming extraordinary amount of GPU memory? Is there something I can do to allocate more GPU memory to Unreal? Simply executing again will yield a positive result, but this is both frustrating and time consuming. TIA.

Hi TimFinn
Indeed this is a known issue when using the Zed Unreal Plugin. It's still in our backlog since it's not blocking and limited to Unreal Editor use, but as you said it's very frustrating and happen quite often when developing.
The issue seems for to come from the interaction between Unreal Editor and our SDK, thus I don't think you can do something on your side to fix it.
I'll keep you updated, we should work on this soon.


Give all as an pagination options to show all the records present in an table

Give "all" as an pagination options to show all the records present in an table.

Thank you for the help.


Pallets: Colilson for stacking

Pallets are missing collision.
When using autoload they are stacked together.

Fixed


LND support

Builds on #1718 and #1717
So far this implements outgoing payments and tests them in cil-test.sh and has fully working tmuxinator environment, too.
TODO:

[ ] Route hints
[ ] Subscribe HTLCs
[ ] Intercept HTLCs

Notes:

Split out tmuxinator windows more: 1 cli window, 1 fedimintd window, 1 lightning window with cln. + lnd + gatewayd for both, and 1 bitcoind window
Got rid of "ln1" and "ln2" and instead calling them roughly "cln" and "lnd".
I'm finding inding the ILnRpcClient very clunky because it's really intended to speak to cln-extension. Nothing like this exists for LND. I think we should consider refactoring this trait to not use cln-extension GRPC types as arguments and return types.

Codecov Report
Base: 63.78% // Head: 63.84% // Increases project coverage by +0.06% :tada:

Coverage data is based on head (94f0d79) compared to base (72b6e03).
Patch coverage: 23.78% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1719      +/-   ##
==========================================
+ Coverage   63.78%   63.84%   +0.06%
==========================================
  Files         132      131       -1
  Lines       24372    24290      -82
==========================================
- Hits        15545    15509      -36
+ Misses       8827     8781      -46

Impacted Files
Coverage Δ

client/cli/src/main.rs
0.25% <ø> (ø)

gateway/cli/src/main.rs
0.62% <ø> (ø)

gateway/gateway/src/bin/cln_extension.rs
0.26% <0.00%> (ø)

gateway/gateway/src/bin/gatewayd.rs
1.29% <0.00%> (ø)

gateway/gateway/src/cln.rs
0.00% <ø> (ø)

gateway/gateway/src/config.rs
0.00% <ø> (ø)

gateway/gateway/src/ln.rs
0.00% <ø> (ø)

gateway/gateway/src/lnd.rs
0.00% <0.00%> (ø)

gateway/gateway/src/lnrpc_client.rs
1.78% <0.00%> (ø)

gateway/gateway/src/rpc/mod.rs
83.33% <0.00%> (ø)

... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

In tmuxinator, sometimes we exercise lncli before lnd's RPC server is ready to handle commands:
[lncli] rpc error: code = Unknown desc = the RPC server is in the process of starting up, but not yet ready to accept calls

Replaced by other PRs


Move recipes to external repos

Closes #8
Note to reviewer:

Submodules ml-recipe-course-* contain submodules themselves (linking to fastai repo). Please test and confirm how nested submodules are working and if needed make adjustments directly in this PR.

@astaff I made the changes we discussed: removed submodules and updated README accordingly. I will test each of the recipes separately in their repositories.

Edits are happening in the same PR with structural changes and are impossible to review


A load test of the exported model

It will be helpful to have a component (dedicated of extension to the InfraValidator TFX Pipeline Component) that performs a load test of the exported model.
The expected behavior is to load the exported model, create a TensorFlow Serving endpoint, send requests to the prediction endpoint, and measure the response time. The load test may be performed using the common open-source software like Locust / Vegeta for HTTP or ghz for gRPC protocol.
The motivation behind it is that the prediction time may vary on the model type and structure. With this component, we can initially check if the model will meet the prediction time's business requirements.

Larry and Hannes both confirmed that they have a requirement for low-latency serving that would be benefitted by this. Questions about pushing and how to structure the pipeline. No blessing on test Serving instance, but would be a required blessing for production Push. Difficulty with exactly reproducing the production environment. InfraValidator does something similar, might be using TF.Serving. Similar to Evaluator, we could perhaps compare two models to assess the performance difference with the current test infra.

See project proposal

Is this currently being worked on?


Custom adjacency graph from bipartite graph

Useful for bicoloring to avoid allocations
Related:

#23

i think that we can close this issue.


update docs/Question

Perhaps I'm misunderstanding, but based on the documentation and the nature of the assertions, isn't this the correct structure of the test?
If not, why are these assertions not nested under the assert?

Hi Ben, you're absolutely correct.  Thanks for fixing the formatting here, not sure how it got mangled.


hipcc fails for kernels with no input arguments

I am currently porting a CUDA application that exclusively uses hipMemcpyToSymbol for its kernels (attached below).  When I run hipcc on the hip'ified code, I am getting errors like the following:
error: expected expression
hipLaunchKernelGGL((Kernel1), dim3(numBlocks), dim3(numThreadsPerBlock), 0, 0);
^
/opt/rocm/include/hip/hcc_detail/grid_launch_GGL.hpp:984:6: note: expanded from macro 'hipLaunchKernelGGL'
hipLaunchNamedKernelGGL(
^
/opt/rocm/include/hip/hcc_detail/grid_launch_GGL.hpp:970:9: note: expanded from macro 'hipLaunchNamedKernelGGL'
make_kernel_functor_hip_(function_name, kernel_name, VA_ARGS)
^
/opt/rocm/include/hip/hcc_detail/grid_launch_GGL.hpp:958:9: note: expanded from macro 'make_kernel_functor_hip_'
overload_macro_hip_(make_kernel_functor_hip_, VA_ARGS)
^
note: (skipping 2 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
/opt/rocm/include/hip/hcc_detail/helpers.hpp:127:58: note: expanded from macro 'overloaded_macro_expand_hip_'
#define overloaded_macro_expand_hip_(macro, arg_cnt) macro##arg_cnt
If I add a dummy input arg to the kernel, the error goes away.  So it appears that hipcc does not allow kernels with 0 input arguments, even though I believe this should be allowed.
Matt

@mattsinc thank you for reporting this. It is a known issue / temporary limitation, which shall be removed relatively soon - #246 includes the correction, so you may want to track its merging / evolution. Unfortunately, for the time being, you will have to rely on the rather unpleasant workaround you have already identified. Apologies for the inconvenience.

Thanks @AlexVlx

PR #246 has been merged. So closing this issue.


Spawners should use a range for maximum population

Updated the related resources
Random now provides a nextInteger with a lower bound too
Wrote tests for ExpandableIntegerSet and SpawnerPreset
Closes #106

Current coverage is 24.90%

Merging #261 into master will increase coverage by +0.22% as of b36f2fe

@@            master   #261   diff @@
=====================================
  Files          173    173
  Stmts         4711   4721    +10
  Branches       772    776     +4
  Methods          0      0
=====================================
+ Hit           1163   1176    +13
- Partial         93     95     +2
+ Missed        3455   3450     -5

Review entire Coverage Diff as of b36f2fe

Powered by Codecov. Updated on successful CI builds.

@rultor merge

@rultor merge

@mafagafogigante OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@mafagafogigante Done! FYI, the full log is here (took me 4min)


statichtmloutput_post_deploy_trigger  hook

I found that statichtmloutput_post_deploy_trigger doens't exist but wp2static_post_deploy_trigger. is working, but if i use this hook to trigger my git pipeline i have got error Failed during "Performing post-deployment actions", please consult the Help tab for where to get assistance.
This is my code. Am I doing something wrong or?
function static_deploy_trigger($archive)
{
    $ch = curl_init();
    curl_setopt($ch, CURLOPT_URL, '<pipeline trigger>');
    curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
    curl_setopt($ch, CURLOPT_POST, 1);
    $result = curl_exec($ch);
    if (curl_errno($ch)) {
        echo 'Error:' . curl_error($ch);
    }
    curl_close($ch);
    echo $archive;
}

add_filter('wp2static_post_deploy_trigger', 'static_deploy_trigger');

i tried this too:
function static_deploy_trigger()
{
    $ch = curl_init();
    curl_setopt($ch, CURLOPT_URL, '<pipeline trigger>');
    curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
    curl_setopt($ch, CURLOPT_POST, 1);
    $result = curl_exec($ch);
    if (curl_errno($ch)) {
        echo 'Error:' . curl_error($ch);
    }
    curl_close($ch);
}

add_filter('wp2static_post_deploy_trigger', 'static_deploy_trigger');

Thanks for reporting, @Kammi638 - I'll test and get back to you. The rename from wp2static to statichtmloutput isn't live in wp.org plugin yet, so should only be if you used from the source code here or got a recent release from this GitHub repository.
Besides that, code sample looks good. Will get back to you

Thanks for your response.
I don't care about hook name in fact. I will change this when you will update this in wp.org. Just reported that i found it.
I will wait for your tests. Thank you!

I'm rly sorry.
It's looks like that is my local problem. I tried it on webserver and it works.


[WIP] Added new component for detail reveal and updated vm details screen

miq-bot add_label wip

Here is a copy of what the current view of this component looks like.  I am needing help to figure out how to get each alternating row to be striped with an alternating color.

Updated view of the styling of the component.  Some changes that are worthy of note.
1. On hovering over a row, there is a color change for the row
2. If any extra details have been included the arrow on that row turns black, otherwise it will turn light grey.
3. If extra data exists the whole row switches over to cursor hand and accepts onclick event.

@miq-bot remove_label wip

removing WIP label since the bot seems to be having issues.

Waiting for Travis...


Add 325 release notes

Closes https://github.com/prestosql/presto/issues/1931

We should start adding the date of the release..

We should start adding the date of the release..

Agreed. We need to figure out how to got about doing it. Currently, it's a chicken-and-egg problem, as the release notes are currently part of the codebase, so they get added before the release is done (and possibly not on the same day)

How about just doing something like "Week of someMonday" . Also you can probably guess up front .. or add it into the work of doing the release ..

We should start adding the date of the release..

Can we write some plugin to sphinx to retrieve that from github or maven repo?


React native server doesn't start

[X] Review the documentation: https://facebook.github.io/react-native
[X] Search for existing issues: https://github.com/facebook/react-native/issues
[X] Use the latest React Native release: https://github.com/facebook/react-native/releases

Environment
React Native Environment Info:

 System:
 OS: macOS High Sierra 10.13.6
 CPU: x64 Intel(R) Core(TM) i5-7500 CPU @ 3.40GHz
 Memory: 27.39 MB / 8.00 GB
 Shell: 3.2.57 - /bin/bash

Binaries:
 Node: 10.6.0 - /usr/local/bin/node
 Yarn: 1.7.0 - /usr/local/bin/yarn
 npm: 6.1.0 - /usr/local/bin/npm
 Watchman: 4.9.0 - /usr/local/bin/watchman

SDKs:
 iOS SDK:
   Platforms: iOS 11.4, macOS 10.13, tvOS 11.4, watchOS 4.3
 Android SDK:
   Build Tools: 23.0.1, 23.0.3, 25.0.1, 25.0.2, 25.0.3, 26.0.1, 26.0.2, 27.0.3
   API Levels: 23, 24, 25, 26, 27

IDEs:
 Android Studio: 3.1 AI-173.4819257
 Xcode: 9.4.1/9F2000 - /usr/bin/xcodebuild

npmPackages:
 @types/react: 16.4.6 => 16.4.6
 @types/react-native: 0.56.3 => 0.56.3
 react: 16.4.1 => 16.4.1
 react-native: 0.56.0 => 0.56.0
 npmGlobalPackages:
 create-react-native-app: 1.0.0

Description
When i run "yarn jest && react-native start" command babel gives me this error:
Plugin 0 specified in "/Users/***/Documents/***/Sviluppo/**-native/node_modules/babel-preset-react-native/index.js" provided an invalid property of "default" (While processing preset: "/Users/***/Documents/***/Sviluppo/**-native/node_modules/babel-preset-react-native/index.js")
Reproducible Demo
After upgrading react-native to 0.56

I see you are running Node: 10.6.0, Can you try running with Node LTS (8.11.x) and see if you get the same error?

Same error as -> https://github.com/facebook/react-native/issues/19859


Storage Fluent API

Improve storage fluent API by narrowing to storage value and storage map operations
For example
// specific to a storage value
const storageValue = createStorageValue(client, pallet, name)
storageValue(blockHash?) // or storageValue.read(blockHash?)
storageValue.raw(blockHash?)
storageValue.watch(listener)

// specific to a storage NMap
const storageMap = createStorageMap(client, pallet, name)
storageMap(...keys).keys(count, start?, blockHash?)
storageMap(...keys).values(count, start?, blockHash?) // note: the return value will need the last key to request the next key page
storageMap(...keys).rawValues(count, start?, blockHash?)
storageMap(...keys).watchValues(listener, count, start?)

// not specific but could be an alternative because storage values and NMap are storage items
const storage = createStorageItem(client, pallet, name)
storage.value(blockHash?)
storage.rawValue(blockHash?)
storage.watchValue(listener)
storage.map(...keys).keys(count, start?, blockHash?)
storage.map(...keys).values(count, start?, blockHash?)
storage.map(...keys).rawValues(count, start?, blockHash?)
storage.map(...keys).watchValues(listener, count, start?)

Note: the StorageNMap key is encoded as follows in substrate
Twox128(Prefix::pallet_prefix())
  ++ Twox128(Prefix::STORAGE_PREFIX)
  ++ Hasher1(encode(key1))
  ++ Hasher2(encode(key2))
  ++ ...
  ++ HasherN(encode(keyN))

And the StorageValue
Twox128(Prefix::pallet_prefix()) ++ Twox128(Prefix::STORAGE_PREFIX)

I believe we've tackled most of this functionality in a fairly expressive manner. For any future readers: if you see limitations in the current storage API, please open shortcoming-specific issues.


Bring in local open source contributors for guest speakers/guest mentoring

Kurtis / Ruby
RVM
Hoodie

Shannon Skipper - mainrainier of RVM & CHRuby

https://github.com/jdorfman/awesome-help-wanted


bower / npm conflict?

Hello,
If I use something like; https://github.com/angular-ui/bootstrap which I install with bower, it also includes angular and installs it, so then i have a copy of angular in node_modules and another in bower_modules and then it breaks.
If I remove angular from the node_modules folder, then the app doesnt start either, and it does seem that most bower components I wanted to use, also install angular.
Any ideas on a solution, ideally one I can port back into my copy of this fine boilerplate.

Unfortunately, I don't know of any solutions to this problem. The two package managers have no knowledge of each other, so redundant dependencies is unavoidable as far as I know. My only solution would be to manually download and include the library rather than using Bower. A similar issue was discussed in #20

Has anyone found a good solution for this? Even including angular locally causes problems, as other dependencies look for angular in node_modules from what I have seen.

I've tried to add the "dist" folder content of the bower package manually inside "js/third_party" folder and add the styles inside "styles" folder to get them from gulp.
This is a kind of solution for me, not the optimal but at least one.
I'm trying to use bower mainly for for bootstrap angular components.

For this specific package (ng ui bootstrap) try using NPM instead of bower.
Ideally you want to avoid using bower at all.
angular-ui-bootstrap depends on angular-animate and bootstrap (or bootstrap-sass), so install all of them.
$ npm install angular-ui-bootstrap angular-animate bootstrap-sass --save

then add bootstrap to your main.scss
@import '../../node_modules/bootstrap-sass/assets/styles/bootstrap/_bootstrap.scss'

and to your main.js
require('angular-animate');
require('angular-ui-bootstrap');
...
angular.module('app', ['ngAnimate', 'ui.bootstrap', ... ]);

It'll be nice to be able to add sass' includePaths in the config. I'll create a new issue with this suggestion.

@varmint09 @jakemmarsh @hoodsy @esouto
To get angular to load from bower instead of npm add the following to your package.json and npm install browserify-shim --save
My package.json
"browser": {
    "angular": "./bower_components/angular/angular.js",
    "jquery": "./bower_components/jquery/dist/jquery.js"
  },
  "browserify-shim": {
    "angular": "angular",
    "jquery": "$"
  },
  "browserify": {
    "transform": [
      "browserify-shim"
    ]
  }

Ah right, that's a good solution! Thanks @StrikeForceZero. That will work, although I would still personally advise against using Bower components if at all possible to avoid extra steps like this.


[Enhancement] Wait starmgr address ready when get shard info from starmgr

When BE restarts and receives new queries, starlet may not have received the heartbeat from starmgr, and does not know starmgr address, queries will be failed with error "server address is still unknown".
Starlet retries getting shard info until 5 seconds (heartbeat interval) to solve above problem.
Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.1
[x] 3.0
[ ] 2.5
[ ] 2.4

@Mergifyio backport branch-3.1

@Mergifyio backport branch-3.0


[Event Request] Codeunit 396 NoSeriesManagement - OnAfterInitSeries

Hi team,
Codeunit 396 NoSeriesManagement procedure InitSeries we would like to run some additional code at end of procedure, for that an event at the end of procedure code would be a good idea:

[IntegrationEvent(false, false)]
procedure OnAfterInitSeries(var NoSeries: Record "No. Series"; DefaultNoSeriesCode: Code[20]; NewDate: Date; var NewNo: Code[20])

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Cxxopts changes

Codecov Report

Merging #5 (a9f861a) into main (453836a) will increase coverage by 24.29%.
The diff coverage is 0.00%.

:exclamation: Current head a9f861a differs from pull request most recent head db89a81. Consider uploading reports for the commit db89a81 to get more accurate results

@@             Coverage Diff             @@
##             main       #5       +/-   ##
===========================================
+ Coverage   45.42%   69.72%   +24.29%
===========================================
  Files         115       49       -66
  Lines       20595     9497    -11098
  Branches    11224     5804     -5420
===========================================
- Hits         9356     6622     -2734
+ Misses       9458     1856     -7602
+ Partials     1781     1019      -762

Flag
Coverage Δ

packgen-cov
81.72% <ø> (ø)

svdconv-cov
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

tools/buildmgr/cbuild/src/CbuildLayer.cpp
76.04% <0.00%> (ø)

tools/buildmgr/cbuild/src/CbuildModel.cpp
68.23% <0.00%> (ø)

tools/buildmgr/cbuild/src/CbuildMsgs.cpp
100.00% <ø> (ø)

tools/buildmgr/cbuild/src/CbuildProject.cpp
40.12% <ø> (ø)

tools/buildmgr/cbuildgen/src/AuxCmd.cpp
57.74% <ø> (ø)

tools/buildmgr/cbuildgen/src/Console.cpp
73.49% <ø> (ø)

tools/svdconv/SVDGenerator/include/SfdGenerator.h

... and 65 more

Codecov Report

Merging #5 (db89a81) into main (453836a) will increase coverage by 24.29%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main       #5       +/-   ##
===========================================
+ Coverage   45.42%   69.72%   +24.29%
===========================================
  Files         115       49       -66
  Lines       20595     9497    -11098
  Branches    11224     5804     -5420
===========================================
- Hits         9356     6622     -2734
+ Misses       9458     1856     -7602
+ Partials     1781     1019      -762

Flag
Coverage Δ

packgen-cov
81.72% <ø> (ø)

svdconv-cov
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

tools/buildmgr/cbuild/src/CbuildLayer.cpp
76.04% <0.00%> (ø)

tools/buildmgr/cbuild/src/CbuildModel.cpp
68.23% <0.00%> (ø)

tools/buildmgr/cbuild/src/CbuildMsgs.cpp
100.00% <ø> (ø)

tools/buildmgr/cbuild/src/CbuildProject.cpp
40.12% <ø> (ø)

tools/buildmgr/cbuildgen/src/AuxCmd.cpp
57.74% <ø> (ø)

tools/buildmgr/cbuildgen/src/Console.cpp
73.49% <ø> (ø)

tools/svdconv/SVDModel/src/SvdField.cpp

... and 65 more

Codecov Report

Merging #5 (a9f861a) into main (453836a) will increase coverage by 24.44%.
The diff coverage is 75.93%.

:exclamation: Current head a9f861a differs from pull request most recent head db89a81. Consider uploading reports for the commit db89a81 to get more accurate results

@@             Coverage Diff             @@
##             main       #5       +/-   ##
===========================================
+ Coverage   45.42%   69.87%   +24.44%
===========================================
  Files         115       50       -65
  Lines       20595     9564    -11031
  Branches    11224     5857     -5367
===========================================
- Hits         9356     6683     -2673
+ Misses       9458     1861     -7597
+ Partials     1781     1020      -761

Flag
Coverage Δ

buildmgr-cov
75.07% <75.93%> (+0.34%)
:arrow_up:

packgen-cov
81.72% <ø> (ø)

svdconv-cov
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

tools/buildmgr/cbuild/src/CbuildLayer.cpp
76.04% <0.00%> (ø)

tools/buildmgr/cbuild/src/CbuildModel.cpp
68.23% <0.00%> (ø)

tools/buildmgr/cbuild/src/CbuildProject.cpp
41.66% <ø> (+1.54%)
:arrow_up:

tools/buildmgr/cbuildgen/src/CbuildGen.cpp
75.33% <75.33%> (ø)

tools/buildmgr/cbuild/src/CbuildMsgs.cpp
100.00% <100.00%> (ø)

tools/buildmgr/cbuildgen/src/AuxCmd.cpp
62.02% <100.00%> (+4.27%)
:arrow_up:

tools/buildmgr/cbuildgen/src/Console.cpp
100.00% <100.00%> (+26.50%)
:arrow_up:

tools/svdconv/SVDModel/src/SvdField.cpp

tools/svdconv/SVDGenerator/src/HeaderData.cpp

... and 64 more

Codecov Report

Merging #5 (43e3129) into main (453836a) will increase coverage by 24.29%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main       #5       +/-   ##
===========================================
+ Coverage   45.42%   69.72%   +24.29%
===========================================
  Files         115       49       -66
  Lines       20595     9497    -11098
  Branches    11224     5804     -5420
===========================================
- Hits         9356     6622     -2734
+ Misses       9458     1856     -7602
+ Partials     1781     1019      -762

Flag
Coverage Δ

packgen-cov
81.72% <ø> (ø)

svdconv-cov
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

tools/buildmgr/cbuild/src/CbuildLayer.cpp
76.04% <0.00%> (ø)

tools/buildmgr/cbuild/src/CbuildModel.cpp
68.23% <0.00%> (ø)

tools/buildmgr/cbuild/src/CbuildMsgs.cpp
100.00% <ø> (ø)

tools/buildmgr/cbuild/src/CbuildProject.cpp
40.12% <ø> (ø)

tools/buildmgr/cbuildgen/src/AuxCmd.cpp
57.74% <ø> (ø)

tools/buildmgr/cbuildgen/src/Console.cpp
73.49% <ø> (ø)

tools/svdconv/SVDModel/include/SvdPeripheral.h

... and 65 more

Codecov Report

Merging #5 (0bb6b72) into main (453836a) will increase coverage by 24.44%.
The diff coverage is 75.93%.

:exclamation: Current head 0bb6b72 differs from pull request most recent head 43e3129. Consider uploading reports for the commit 43e3129 to get more accurate results

@@             Coverage Diff             @@
##             main       #5       +/-   ##
===========================================
+ Coverage   45.42%   69.87%   +24.44%
===========================================
  Files         115       50       -65
  Lines       20595     9564    -11031
  Branches    11224     5857     -5367
===========================================
- Hits         9356     6683     -2673
+ Misses       9458     1861     -7597
+ Partials     1781     1020      -761

Flag
Coverage Δ

buildmgr-cov
75.07% <75.93%> (+0.34%)
:arrow_up:

svdconv-cov
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

tools/buildmgr/cbuild/src/CbuildLayer.cpp
76.04% <0.00%> (ø)

tools/buildmgr/cbuild/src/CbuildModel.cpp
68.23% <0.00%> (ø)

tools/buildmgr/cbuild/src/CbuildProject.cpp
41.66% <ø> (+1.54%)
:arrow_up:

tools/buildmgr/cbuildgen/src/CbuildGen.cpp
75.33% <75.33%> (ø)

tools/buildmgr/cbuild/src/CbuildMsgs.cpp
100.00% <100.00%> (ø)

tools/buildmgr/cbuildgen/src/AuxCmd.cpp
62.02% <100.00%> (+4.27%)
:arrow_up:

tools/buildmgr/cbuildgen/src/Console.cpp
100.00% <100.00%> (+26.50%)
:arrow_up:

tools/svdconv/SVDModel/src/SvdSauRegion.cpp

tools/svdconv/SVDGenerator/include/CodeGenerator.h

... and 64 more

Codecov Report

Merging #5 (43e3129) into main (453836a) will increase coverage by 24.44%.
The diff coverage is 75.93%.

:exclamation: Current head 43e3129 differs from pull request most recent head f35d45d. Consider uploading reports for the commit f35d45d to get more accurate results

@@             Coverage Diff             @@
##             main       #5       +/-   ##
===========================================
+ Coverage   45.42%   69.87%   +24.44%
===========================================
  Files         115       50       -65
  Lines       20595     9564    -11031
  Branches    11224     5857     -5367
===========================================
- Hits         9356     6683     -2673
+ Misses       9458     1861     -7597
+ Partials     1781     1020      -761

Flag
Coverage Δ

buildmgr-cov
75.07% <75.93%> (+0.34%)
:arrow_up:

packgen-cov
81.72% <ø> (ø)

svdconv-cov
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

tools/buildmgr/cbuild/src/CbuildLayer.cpp
76.04% <0.00%> (ø)

tools/buildmgr/cbuild/src/CbuildModel.cpp
68.23% <0.00%> (ø)

tools/buildmgr/cbuild/src/CbuildProject.cpp
41.66% <ø> (+1.54%)
:arrow_up:

tools/buildmgr/cbuildgen/src/CbuildGen.cpp
75.33% <75.33%> (ø)

tools/buildmgr/cbuild/src/CbuildMsgs.cpp
100.00% <100.00%> (ø)

tools/buildmgr/cbuildgen/src/AuxCmd.cpp
62.02% <100.00%> (+4.27%)
:arrow_up:

tools/buildmgr/cbuildgen/src/Console.cpp
100.00% <100.00%> (+26.50%)
:arrow_up:

tools/svdconv/SVDGenerator/src/SfrccInterface.cpp

tools/svdconv/SVDModel/include/SvdDimension.h

... and 64 more


Change TS template .wasm file default using ts and not js

It makes sense to call the .wasm output file using the template name, as this is the convention we have for other templates.
A potential addition could be to parameterize this to use {{project-name | kebab_case}}.wasm, like the component id.
Marking this a draft until we agree on whether this should be parameterized.

I think parameterizing the name of the output file sounds like a good idea to me.

Some templates (e.g. Rust) parameterise the name of the output file.  Others (e.g. Go) do not.  I like to imagine it depends on what is convenient in the language/toolchain, though it is probably really historical accident inherited from whoever wrote the example the template was adapted from.  In any case, parameterising the Wasm file name is definitely not an established convention, and template authors should not feel any obligation or pressure to do it.

And... to be clear... that is not a "don't parameterise"... that is a "parameterise if it is more convenient or if you prefer it that way."

I'd love for this to be a convention, it just makes spin.toml much easier to read, if the wasm modules don't have generic names. but get your point @itowlson :-)

BTW - the handle bar templating works really nicely 👍🏻


adding JSON response doesn't seem to work

I'm trying to add the following to my stubs, which comes from your own examples (https://github.com/dukeofharen/httplaceholder/blob/master/docs/RESPONSE.md#json):
- id: situation-json
  conditions:
    method: GET
    url:
      path: /text.json
  response:
    statusCode: 200
    json: {"msg": "All OK!"}

This gives the following errors from the UI:

Stub with ID 'situation-json' could not be added.
Something went wrong while contacting the server.

Running HttPlaceholder 2<IP_ADDRESS>. Also, the previous version gave me the exact same error response.
Here's the verbose logging from the application:
2021-01-06 16:32:21.773 +01:00 [DBG] Connection id "0HM5IB11A2C00" accepted.
2021-01-06 16:32:21.776 +01:00 [DBG] Connection id "0HM5IB11A2C00" started.
2021-01-06 16:32:21.827 +01:00 [INF] Request starting HTTP/1.1 POST http://<IP_ADDRESS>:5000/ph-api/stubs application/json;charset=UTF-8 136
2021-01-06 16:32:21.832 +01:00 [DBG] Wildcard detected, all requests with hosts will be allowed.
2021-01-06 16:32:21.846 +01:00 [DBG] POST requests are not supported
2021-01-06 16:32:21.848 +01:00 [DBG] POST requests are not supported
2021-01-06 16:32:21.849 +01:00 [DBG] POST requests are not supported
2021-01-06 16:32:21.872 +01:00 [DBG] Initializing Razor view compiler with no compiled views.
2021-01-06 16:32:21.914 +01:00 [DBG] 1 candidate(s) found for the request path '/ph-api/stubs'
2021-01-06 16:32:21.923 +01:00 [DBG] Endpoint 'HttPlaceholder.Controllers.v1.StubController.Add (HttPlaceholder)' with route pattern 'ph-api/stubs' is valid for the request path '/ph-api/stubs'
2021-01-06 16:32:21.933 +01:00 [DBG] Request matched endpoint 'HttPlaceholder.Controllers.v1.StubController.Add (HttPlaceholder)'
2021-01-06 16:32:21.945 +01:00 [INF] Executing endpoint 'HttPlaceholder.Controllers.v1.StubController.Add (HttPlaceholder)'
2021-01-06 16:32:21.961 +01:00 [DBG] Registered model binder providers, in the following order: ["Microsoft.AspNetCore.Mvc.ModelBinding.Binders.BinderTypeModelBinderProvider", "Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ServicesModelBinderProvider", "Microsoft.AspNetCore.Mvc.ModelBinding.Binders.BodyModelBinderProvider", "Microsoft.AspNetCore.Mvc.ModelBinding.Binders.HeaderModelBinderProvider", "Microsoft.AspNetCore.Mvc.ModelBinding.Binders.FloatingPointTypeModelBinderProvider", "Microsoft.AspNetCore.Mvc.ModelBinding.Binders.EnumTypeModelBinderProvider", "Microsoft.AspNetCore.Mvc.ModelBinding.Binders.DateTimeModelBinderProvider", "Microsoft.AspNetCore.Mvc.ModelBinding.Binders.SimpleTypeModelBinderProvider", "Microsoft.AspNetCore.Mvc.ModelBinding.Binders.CancellationTokenModelBinderProvider", "Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ByteArrayModelBinderProvider", "Microsoft.AspNetCore.Mvc.ModelBinding.Binders.FormFileModelBinderProvider", "Microsoft.AspNetCore.Mvc.ModelBinding.Binders.FormCollectionModelBinderProvider", "Microsoft.AspNetCore.Mvc.ModelBinding.Binders.KeyValuePairModelBinderProvider", "Microsoft.AspNetCore.Mvc.ModelBinding.Binders.DictionaryModelBinderProvider", "Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ArrayModelBinderProvider", "Microsoft.AspNetCore.Mvc.ModelBinding.Binders.CollectionModelBinderProvider", "Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexObjectModelBinderProvider"]
2021-01-06 16:32:22.076 +01:00 [INF] Route matched with {action = "Add", controller = "Stub"}. Executing controller action with signature System.Threading.Tasks.Task`1[Microsoft.AspNetCore.Mvc.ActionResult`1[HttPlaceholder.Dto.v1.Stubs.FullStubDto]] Add(HttPlaceholder.Dto.v1.Stubs.StubDto) on controller HttPlaceholder.Controllers.v1.StubController (HttPlaceholder).
2021-01-06 16:32:22.087 +01:00 [DBG] Execution plan of authorization filters (in the following order): ["None"]
2021-01-06 16:32:22.097 +01:00 [DBG] Execution plan of resource filters (in the following order): ["Microsoft.AspNetCore.Mvc.ViewFeatures.Filters.SaveTempDataFilter"]
2021-01-06 16:32:22.104 +01:00 [DBG] Execution plan of action filters (in the following order): ["Microsoft.AspNetCore.Mvc.Filters.ControllerActionFilter (Order: -2147483648)", "Microsoft.AspNetCore.Mvc.ModelBinding.UnsupportedContentTypeFilter (Order: -3000)", "Microsoft.AspNetCore.Mvc.Infrastructure.ModelStateInvalidFilter (Order: -2000)", "HttPlaceholder.Authorization.ApiAuthorizationAttribute (Order: 0)"]
2021-01-06 16:32:22.135 +01:00 [DBG] Execution plan of exception filters (in the following order): ["None"]
2021-01-06 16:32:22.137 +01:00 [DBG] Execution plan of result filters (in the following order): ["Microsoft.AspNetCore.Mvc.ViewFeatures.Filters.SaveTempDataFilter", "Microsoft.AspNetCore.Mvc.Infrastructure.ClientErrorResultFilter (Order: -2000)", "HttPlaceholder.Authorization.ApiAuthorizationAttribute (Order: 0)"]
2021-01-06 16:32:22.142 +01:00 [DBG] Executing controller factory for controller HttPlaceholder.Controllers.v1.StubController (HttPlaceholder)
2021-01-06 16:32:22.148 +01:00 [DBG] Executed controller factory for controller HttPlaceholder.Controllers.v1.StubController (HttPlaceholder)
2021-01-06 16:32:22.160 +01:00 [DBG] Attempting to bind parameter 'stub' of type 'HttPlaceholder.Dto.v1.Stubs.StubDto' ...
2021-01-06 16:32:22.186 +01:00 [DBG] Attempting to bind parameter 'stub' of type 'HttPlaceholder.Dto.v1.Stubs.StubDto' using the name '' in request data ...
2021-01-06 16:32:22.189 +01:00 [DBG] Rejected input formatter 'Microsoft.AspNetCore.Mvc.Formatters.NewtonsoftJsonPatchInputFormatter' for content type 'application/json;charset=UTF-8'.
2021-01-06 16:32:22.194 +01:00 [DBG] Selected input formatter 'Microsoft.AspNetCore.Mvc.Formatters.NewtonsoftJsonInputFormatter' for content type 'application/json;charset=UTF-8'.
2021-01-06 16:32:22.203 +01:00 [DBG] Connection id "0HM5IB11A2C00", Request id "0HM5IB11A2C00:00000002": started reading request body.
2021-01-06 16:32:22.208 +01:00 [DBG] Connection id "0HM5IB11A2C00", Request id "0HM5IB11A2C00:00000002": done reading request body.
2021-01-06 16:32:22.353 +01:00 [DBG] JSON input formatter threw an exception.
Newtonsoft.Json.JsonReaderException: Unexpected character encountered while parsing value: {. Path 'response.json', line 1, position 118.
   at Newtonsoft.Json.JsonTextReader.ReadStringValue(ReadType readType)
   at Newtonsoft.Json.JsonTextReader.ReadAsString()
   at Newtonsoft.Json.JsonReader.ReadForType(JsonContract contract, Boolean hasConverter)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
2021-01-06 16:32:22.378 +01:00 [DBG] JSON input formatter threw an exception.
Newtonsoft.Json.JsonReaderException: After parsing a value an unexpected character was encountered: :. Path 'response.json', line 1, position 123.
   at Newtonsoft.Json.JsonTextReader.ParsePostValue(Boolean ignoreComments)
   at Newtonsoft.Json.JsonTextReader.Read()
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.SetPropertyValue(JsonProperty property, JsonConverter propertyConverter, JsonContainerContract containerContract, JsonProperty containerProperty, JsonReader reader, Object target)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
2021-01-06 16:32:22.393 +01:00 [DBG] JSON input formatter threw an exception.
Newtonsoft.Json.JsonReaderException: After parsing a value an unexpected character was encountered: :. Path 'response.json', line 1, position 123.
   at Newtonsoft.Json.JsonTextReader.ParsePostValue(Boolean ignoreComments)
   at Newtonsoft.Json.JsonTextReader.Read()
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.HandleError(JsonReader reader, Boolean readPastError, Int32 initialDepth)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)
2021-01-06 16:32:22.418 +01:00 [DBG] Done attempting to bind parameter 'stub' of type 'HttPlaceholder.Dto.v1.Stubs.StubDto'.
2021-01-06 16:32:22.425 +01:00 [DBG] Done attempting to bind parameter 'stub' of type 'HttPlaceholder.Dto.v1.Stubs.StubDto'.
2021-01-06 16:32:22.428 +01:00 [DBG] Attempting to validate the bound parameter 'stub' of type 'HttPlaceholder.Dto.v1.Stubs.StubDto' ...
2021-01-06 16:32:22.431 +01:00 [DBG] Done attempting to validate the bound parameter 'stub' of type 'HttPlaceholder.Dto.v1.Stubs.StubDto'.
2021-01-06 16:32:22.435 +01:00 [DBG] The request has model state errors, returning an error response.
2021-01-06 16:32:22.440 +01:00 [DBG] Request was short circuited at action filter 'Microsoft.AspNetCore.Mvc.Infrastructure.ModelStateInvalidFilter'.
2021-01-06 16:32:22.446 +01:00 [DBG] List of registered output formatters, in the following order: ["Microsoft.AspNetCore.Mvc.Formatters.HttpNoContentOutputFormatter", "Microsoft.AspNetCore.Mvc.Formatters.StringOutputFormatter", "Microsoft.AspNetCore.Mvc.Formatters.StreamOutputFormatter", "Microsoft.AspNetCore.Mvc.Formatters.NewtonsoftJsonOutputFormatter", "HttPlaceholder.Formatters.YamlOutputFormatter"]
2021-01-06 16:32:22.459 +01:00 [DBG] Attempting to select an output formatter based on Accept header '["application/json", "text/plain", "*/*"]' and explicitly specified content types '["application/problem+json", "application/problem+xml"]'. The content types in the accept header must be a subset of the explicitly set content types.
2021-01-06 16:32:22.466 +01:00 [DBG] Selected output formatter 'Microsoft.AspNetCore.Mvc.Formatters.NewtonsoftJsonOutputFormatter' and content type 'application/problem+json' to write the response.
2021-01-06 16:32:22.477 +01:00 [INF] Executing BadRequestObjectResult, writing value of type 'Microsoft.AspNetCore.Mvc.ValidationProblemDetails'.
2021-01-06 16:32:22.560 +01:00 [INF] Executed action HttPlaceholder.Controllers.v1.StubController.Add (HttPlaceholder) in 414.7998ms
2021-01-06 16:32:22.564 +01:00 [INF] Executed endpoint 'HttPlaceholder.Controllers.v1.StubController.Add (HttPlaceholder)'
2021-01-06 16:32:22.567 +01:00 [DBG] Connection id "0HM5IB11A2C00" completed keep alive response.
2021-01-06 16:32:22.576 +01:00 [INF] Request finished HTTP/1.1 POST http://<IP_ADDRESS>:5000/ph-api/stubs application/json;charset=UTF-8 136 - 400 574 application/problem+json;+charset=utf-8 753.8996ms

Hi Rick, good catch, I will fix the docs.
If you want to add JSON to the stub, you can add single quotes around the JSON or make it multi line. Something like this:
- id: situation-json
  conditions:
    method: GET
    url:
      path: /text.json
  response:
    statusCode: 200
    json: '{"msg": "All OK!"}'

or
- id: situation-json
  conditions:
    method: GET
    url:
      path: /text.json
  response:
    statusCode: 200
    json: |
        {
            "msg": "All OK!"
        }

Hi Rick, good catch, I will fix the docs.
If you want to add JSON to the stub, you can add single quotes around the JSON or make it multi line. Something like this:
- id: situation-json
  conditions:
    method: GET
    url:
      path: /text.json
  response:
    statusCode: 200
    json: '{"msg": "All OK!"}'

or
- id: situation-json
  conditions:
    method: GET
    url:
      path: /text.json
  response:
    statusCode: 200
    json: |
        {
            "msg": "All OK!"
        }


Upgrade to cylc 6.8.1, rose 2016.02.0

resolution_fixed   |    by<EMAIL_ADDRESS>
Upgrade cylc, rose and fcm to latest versions

Issue migrated from trac:262 at 2024-01-31 18:23:07 +1100

<EMAIL_ADDRESS>changed _comment0 which not transferred by tractive

<EMAIL_ADDRESS>changed owner from `` to mrd599

<EMAIL_ADDRESS>commented

Modify cylc on raijin as described in https://accessdev.nci.org.au/trac/ticket/199#comment:7
Cylc can now retrieve log files, replacing the functionality of our rose-task-hook2. To automatically fix the permissions so that rose bush can see them, add
        retrieve job logs command = rsync -a --chmod=Du=rwx,Dgo=rx,Fu=rw,Fgo=r

to the localhost section of the cylc global.rc file.
If this change is made to the cylc 6.7.2 config file, cylc seems to hang on job submission, so it's necessary to have old and new versions in the puppet configuration.
It's also possible to set the configuration to automatically retrieve files and to set retry delays (alternative is to set something like this in every suite),
     retrieve job logs = True
     retrieve job logs retry delays = PT10S,  PT30S, PT1M, PT3M

Making it a default would make it more likely that suites from the Met Office would do the right thing without change. It could still be turned off on a per suite basis (or in a user site config file).

<EMAIL_ADDRESS>changed status from new to assigned

<EMAIL_ADDRESS>changed _comment1 which not transferred by tractive

<EMAIL_ADDRESS>commented

Setting retrieve job logs = False in a suite doesn't work properly at the moment. This will be fixed in the next release https://github.com/cylc/cylc/pull/1728.
Setting a limit with retrieve job logs max size doesn't behave as expected. If the limit means that the job.out or job.err file isn't retrieved it will keep trying until the retry delays are exhausted.
https://groups.google.com/forum/#!topic/cylc/CNIdwwOJo9g
https://github.com/cylc/cylc/pull/1747 changes this to test either job.out or job.err which should fix things in most cases.
Next release will also fix the high CPU load issue
https://github.com/cylc/cylc/issues/1744
Next release expected March 9 so better to wait.

<EMAIL_ADDRESS>commented

Now using rose 2016.02.1

<EMAIL_ADDRESS>commented

Now using cylc 6.9.1 and rose 2016.03.0
Setting retrieve job logs = False in either the root section of a suite or for a particular task works.
Setting log file size limit works now works as expected with no retry delay. Size limit set to 1M initially.

<EMAIL_ADDRESS>changed _comment0 which not transferred by tractive

<EMAIL_ADDRESS>changed status from assigned to closed

<EMAIL_ADDRESS>changed resolution from `` to fixed


Move github workflow test tweaks to separate installation script

There are currently three post-installation configuration steps that are required to make github actions work:

building of krakendb database
building of krona taxonomy
reducing malt runtime memory

These steps should be placed in a separate post-(test?)-installation script as these steps are also required for local tests but currently not implemented.

One has to also manually build bowtie2 index, right? Like this:
bowtie2-build --large-index ref.fa ref.fa --threads 4

@LeandroRitter I actually added the bowtie build dependency to bowtie align, so that shouldn't be necessary.


add small benchmark to determine the performance of builtin functions

I try to call directly builtin functions like this benchmark. Unfortunately, I am not to include directly the crate.

@jbreitbart I added a benchmark, which directly calls memcpy and memset. Currently, I use the version of compiler_builtin. In the meantime, I am able to use the assembly version. The performance of these functions is on my test system good.

bors r+

bors r+