documentation improvements

This is a work in progress and seeking advise on improvements to make. Not supposed to be merged just now.
Things done:

Reset the style to the doxygen standardthe documentation. Old style was very pretty but no navigation bar or tree search. I tried working with it but was pretty hard to customize.
Made some changes to the standard style to make it look more clean.
Made general install.md readme that points at all the possibilities
Made folder in doc to throw some general readme, should revise it.

Things that I'm planning to do:

Change the font to something better looking and more modern.
Populate readme files better.
Add doxygen class documentation (big task). Suggestions on how to organize class documentation welcome.

Rendered documentation in: https://marinagmoreira.github.io/astrobee/html/index.html

Also, I just realized, this was made to master and not develop.


[WIP][Misc] Add Travis CI support

WIP WIP

Hmm I think I'll just merge this one first.

Note: Travis only runs a build on the commits you push after adding the repository to Travis. Note: If your project already has a .travis.yml file, you need to push another commit to trigger a build.

http://docs.travis-ci.com/user/getting-started/


Fixed achievements in right-to-left layout

Fixed the broken achievements when layout is rendered in locales where text flows from right to left.
Fixes #2545 Achievements broken in right-to-left languages
What changes did you make and why?
Used Gravity#START and Gravity#END instead of Gravity#LEFT and Gravity#RIGHT to better support
right to left layouts.
Tested betaDebug on Realme 2 pro (Android Version 8.1.0) with API level 15.
Screenshots showing activity_achievements.xml in forced right-to-left layout

Codecov Report

Merging #2557 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2557   +/-   ##
======================================
  Coverage     5.9%    5.9%
======================================
  Files         258     258
  Lines       12300   12300
  Branches     1104    1104
======================================
  Hits          726     726
  Misses      11515   11515
  Partials       59      59

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8022536...f20f9ab. Read the comment docs.

The result looks great, thanks :-)


Clean up clippy suggestions

... and an additional find_map simplification

I suggest we enable clippy in the pipeline instead of check? :) Like as mandatory I mean.

I suggest we enable clippy in the pipeline instead of check? :) Like as mandatory I mean.

I think these things just pop up for me because I use nightly clippy to check. It can actually have false positives (I have one right now), so we probably should be fine with the current state of the world.


import AppKit instead of Cocoa (and update links in docs)

This library has no need for CoreData, and AppKit imports Foundation for us! 🎉

Man that's some quality work right there!

@lhecker Gotta show my appreciation somehow! 😊

Honestly this project is basically just a hack to make my life with my pixel-perfectionistic designer buddy easier. Because back then when I created this (many many years ago), NSTextField always took the values you gave it more as a guideline rather than an actual specification. This class turned out to be much more reliable and often easier to use. ¯\_(ツ)_/¯
But considering that in the end it's such a hacky project I'm actually surprised it garnered that much attention at all. 😄


Stop console before closing

Fixes #4970

Hello @impact27! Thanks for submitting the PR.

In the file spyder/plugins/ipythonconsole.py, following are the PEP8 issues :

Line 1215:9: E265 block comment should start with '# '
Line 1217:1: W293 blank line contains whitespace

Thanks a lot for this @impact27! Please fix the reported style issues, then I'll merge.


Suggestion: Add link to this GitHub issues page directly from Controls Gallery app

Is this a totally new sample, an addition to an existing sample page, or a modification of an existing sample page?

[ ] New sample
[ ] Addition to existing sample
[x] Modification to existing sample

If this is an addition/modification to an existing sample page, which one?
All of them
The suggestion is to make the link to GitHub issues page available directly from the controls' pages just like guidance doc having it on the bottom of each pages.
Describe the sample

Is your sample request related to a problem? Please describe it

Additional context

@chigy, to confirm, is this the link you'd like to see added to the Gallery? https://github.com/microsoft/microsoft-ui-xaml/issues/new/choose

@YuliKl , no I was thinking to the Controls Gallery issue since it is about it.
https://github.com/microsoft/Xaml-Controls-Gallery/issues/new/choose

Got it. Thank you for clarifying.

PR with fix is merged.


Fixed two failing tests

Coverage remained the same at 73.936% when pulling dca7082ac49ea0492a3c24cd7597d7f82bfacfc7 on yitam:failingTests into 3b6b076c1fb17e2cb6e06e736cef561bf5387ab4 on microsoft:dev.

Codecov Report

Merging #991 into dev will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #991      +/-   ##
==========================================
- Coverage   78.65%   78.59%   -0.07%
==========================================
  Files          25       25
  Lines        8133     8133
==========================================
- Hits         6397     6392       -5
- Misses       1736     1741       +5

Impacted Files
Coverage Δ

...php-7.1.29-src/ext/pdo_sqlsrv/shared/core_stmt.cpp
77.42% <0%> (-0.46%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b6b076...dca7082. Read the comment docs.

What is the problem with pdo_035?

It failed in AE test when the first column was supposed to be integer but the original test tried to bind param with binary encoding


Some Bytecode fixes

See changelog

Merging as-is, remind me on the 7th to release 3.0.1 as I don't have access to all credentials until then.


Video player not working on Win 10 with latest VLC installed

I understand that is necessary to have the VLC player installed to be able to use this lib.
I had a previous version of VLC which worked fine with the player, but some videos could not load probably due to the version of VLC I had, so I have uninstalled VLC, and installed the newest version, but now the app crashes all the time looking for the VLC lib.

I have added the VLC folder to the environment variables but then it crashes again:

The problem I see is that the users need to have the VLC player installed to be able to use any app using this lib. If any user faces this same issue, it will stop using the app.
Is it possible for you guys to embed the necessary vlc libs directly into the lib?
Thanks!

At the end I had to download an another VLC installer, but the problem of needing to have the VLC player on the client side still remains. Is it possible to bundle it with the lib?

Does the framework use the path variable to find VLC? Could use a modified startup script and add it to the path.

@adnanjelic @Frontrider Please check same in latest version and let us know!

I only added a hint that I could think of, I don't own any computers with windows on it.

@ctn-mobile-innovation unfortunately the same error with missing toolkit still persists


add ARD channel In Germany

please add the channel ard in de.json, country :: germany
url<EMAIL_ADDRESS>

@chezsick Are you sure this is a live broadcast? I constantly see only just a screensaver.

Yes Is A Broadcast From ARD
For Example, A Movie Passed In This Channel :::::::: https://mamot.fr/web/statuses/102254599876752449

Heuuu No Is Fix Video :disappointed: Maybe Too Later?

ARD aka Das Erste is already in the list https://github.com/iptv-org/iptv/blob/8d78fede0f166f9fb2c9da14a3873454d1096c59/channels/de.m3u#L46

Im sorry ::: i no see because, is not write ard

I Closing This Issue For A Screenshot Stream, URL From @Chow89


remove request/response value objects from log context

Q
A

Bug fix?
no

New feature?
yes

BC breaks?
no

Deprecations?
no

Related tickets
fixes #16

Documentation
if this is a new feature, link to pull request in https://github.com/php-http/documentation that adds relevant documentation

License
MIT

In my opinion you cannot say it fixed #16 when the reported problem there is Request and response in context always empty and your MR is removing it from context.
The other thing is what we discussed inside the thread there but really hard to say it fixes problem reported by author :)


add traefik integration

Issue
Closes #3.

Mmmm not sure what's going on here but afaiu we're not using the ingress address anywhere.
What was the goal of this pr?


Fix a number of bugs in the QT UI

This PR resolves a number of issues present in the QT UI following the initial work to port the UI to 0.13.x.
Further, the trading interface is considered incomplete and following discussion with @dexX7 it was agreed that the trading UI would be disabled and hidden in this version in order to move forward with release in a timely fashion.
Thanks
Z

Very nice, thanks @zathras-crypto!
Is this ready to go, and was this the last blocker for 0.2, besides bumping the version and adding release notes?

Is this ready to go

The fixes should all be safe to merge yep :)

was this the last blocker for 0.2

I ran through some sends myself on regtest and I think I caught the main & obvious UI problems I could see.
I've also been running the daemon up at OE for months now and it's solid as a rock when hit with lots of data retrieval RPCs sequentially.
We do still have that locking issue with the inputs cache and parallel requests though as experienced by the Jaxx guys - do you think we should try and ship a fix with 0.2?
I can't speak to transaction creation RPCs as OE doesn't use them, but if @achamely has been happily using it up at OmniWallet for a while then I believe we're good on that side too.


ChatGPT GitHub Action for gene-associated modification

Description of the issue:
We are thinking that we can make ChatGPT as  github action so that it can double check the modification made in the pull request.

Go to Uniprot extract the annotation for the modified gene
check wether the gene is associated with the subsystem and the substrates
according to the output, then define pass/fail for the model modification

Some more clarifications would be appreciated:

What is a modified gene? A gene entry in the yaml that was added in that PR?
What is implied by "go to UniProt"?
How does one check whether a gene is associated with the system and substrates? Just ask ChatGTP?

Here is a random example:

And here is the Bing answer to the same question:

@guozhetao Could you handle this task?

In my previous tests with publicly-available AI models, the responses I would get were not trustworthy. I'd be curious to see how this changed since, and perhaps if the question can be formulated differently for a more accurate answer.

Yes, it seems much better right now with the development of LLMs. Will update soon.


traffic_ops_scripted.js doesn't work with newer versions of grafana

traffic_ops_scripted.js which is used to create custom graphs works with grafana 2.0.2 but does not work with newer versions of grafana (specifically 2.13).  It should be updated to work with newer versions.

Apparently you can't use "type" as a variable name anymore. Renaming it to typeGraph works (but you also need to rename the query string). Why not separating them in 3 scripts and drop that type? Would probably make it easier to change/debug in the future as well. If agreed, I'll send a pull request.


LNK2001: unresolved external symbol __imp_strncpy

Hello guys,
Here i am facing linker issue i attached supported lib like 1.soem.lib, ws2_32.lib, Packet.lib,Packet.lib, winmm.lib all lib attached but still i am facing these issue "Visual studio 2022" version.
simple_test.c(351,5): warning C4098: 'ecatcheck': 'void' function returning a value
1>LINK : warning LNK4098: defaultlib 'MSVCRT' conflicts with use of other libs; use /NODEFAULTLIB:library
1>soem.lib(ethercatcoe.obj) : error LNK2001: unresolved external symbol __imp_strncpy
1>soem.lib(oshw.obj) : error LNK2001: unresolved external symbol __imp_strncpy
1>soem.lib(nicdrv.obj) : error LNK2001: unresolved external symbol pcap_close
1>soem.lib(nicdrv.obj) : error LNK2001: unresolved external symbol pcap_next_ex
1>soem.lib(nicdrv.obj) : error LNK2001: unresolved external symbol pcap_sendpacket
1>soem.lib(nicdrv.obj) : error LNK2001: unresolved external symbol pcap_open
1>soem.lib(oshw.obj) : error LNK2001: unresolved external symbol pcap_findalldevs

1>soem.lib(oshw.obj) : error LNK2001: unresolved external symbol pcap_freealldevs
thanks & Regards
Ananth

This does not appear to have anything to do with OpenBLAS, looks like you need to link to msvcrt.lib (or ucrt) for the strncpy and probably wpcap.lib for all the pcap things.

Here I inserted properties-->linker-->Input-->msvcrt.lib, but only one error is gone; the remaining errors are there.
1>soem.lib(nicdrv.obj): error LNK2001: unresolved external symbol pcap_close
1>soem.lib(nicdrv.obj): error LNK2001: unresolved external symbol pcap_next_ex
1>soem.lib(nicdrv.obj): error LNK2001: unresolved external symbol pcap_sendpacket
1>soem.lib(nicdrv.obj): error LNK2001: unresolved external symbol pcap_open
1>soem.lib(oshw.obj): error LNK2001: unresolved external symbol pcap_findalldevs
1>soem.lib(oshw.obj): error LNK2001: unresolved external symbol pcap_freealldevs
How to fix it These are errors.

please ask somewhere where they know whatever program that is you are trying to build - this has nothing to do with OpenBLAS. Like I already wrote, you will probably need to insert something like wpcap.lib as well to get rid of the pcap errors

I appreciate your help. @martin-frbgI finished, and this problem was once more resolved. Many thanks!


Fix status RestURL type

Made it consistent with the other URL types.
Code was also regenerated, so there are some changes from the previous container type change in a previous commit.
Signed-off-by: Paul Van Eck<EMAIL_ADDRESS>

/lgtm
/approve


Note that higher replication factors are recommended for local disks

As brought up in the review of #2896.

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/512bbe91b72b3a186046dd1da4d83c314a2efdf7/


[BUG #5268] Fix bug when registering with Eureka through EurekaInstanceRegisterRepository#persistInstance.

ref #5268.

Codecov Report

Merging #5269 (c67ee80) into master (8a2a23d) will decrease coverage by 0.11%.
The diff coverage is 73.33%.

@@             Coverage Diff              @@
##             master    #5269      +/-   ##
============================================
- Coverage     61.12%   61.02%   -0.11%
+ Complexity     8659     8653       -6
============================================
  Files          1252     1252
  Lines         38544    38588      +44
  Branches       3685     3688       +3
============================================
- Hits          23560    23547      -13
- Misses        12915    12962      +47
- Partials       2069     2079      +10

Files
Coverage Δ

...istry/eureka/EurekaInstanceRegisterRepository.java
75.67% <73.33%> (+10.15%)
:arrow_up:

... and 13 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


feat(Sidebar): closing sidebar on blur

This is a follow up to the abandoned #1473. This implementation is very similar to the original PR.
The biggest remaining gap is in testing. The use of <Ref> breaks the standard test methods like isConformant as well as tests that presume to affect the root node.
I'm interested in suggestions regarding a path forward. Should standard methods be updated to support <Ref> or should Sidebar have its own, more specific series of tests.

I'm interested in suggestions regarding a path forward. Should standard methods be updated to support  or should Sidebar have its own, more specific series of tests.

It appears the Portal also renders a <Ref /> and our solution there was to skip common.isConformant(Portal) and only run common.hasValidTypings(Portal).

Closing in favor of #2845.


add_widget should not add a widget if grid is full

I set the height + width to have a max size. If I have a grid full if widgets and call add_widget once more, it creates a new row, but shouldn't

this.add_new_widget = function () {
var node = this.items.pop() || {
x: 0,
y: 0 ,
width: 1,
height: 1
};
if (this.grid.will_it_fit(node.x, node.y, node.width, node.height, true)) {
this.grid.add_widget($('Delete me'), node.x, node.y, node.width, node.height, true);
}
else {
alert('Not enough free space to place the widget');
}
            }.bind(this);

            $('#add-new-widget').click(this.add_new_widget);

I dont know if this helps you, but it works on me...

Yea, in the end that's what I did.


switch to pull request reviewers who has approved as method of unblocking PR

Currently we work off of the "APPROVED" label but once github exposes the usernames of the approvers of a PR we can switch to that to change the status
I pinged github about this a few months ago and they said it was coming up but :man_shrugging: its been a while

Is it a label or a comment?

@cramforce currently as label, didn't want to have to parse and normalize comments =X

How do 2 people approve then? Like in our case for an ads and build change.
I don't want to have to 2 that as root approver.
On Jan 18, 2017 6:33 PM, "erwin mombay"<EMAIL_ADDRESS>wrote:

@cramforce https://github.com/cramforce currently as label, didn't want
to have to parse and normalize comments =X
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/github-owners-bot/issues/10#issuecomment-273665403,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFeT18q2_wfvHmId7reKDE6IIgM0v_yks5rTstlgaJpZM4Lnnoq
.

@cramforce good point. I'll have to switch to comments for now then.

Lets make the magic word "LGTM"
On Wed, Jan 18, 2017 at 8:01 PM, erwin mombay<EMAIL_ADDRESS>wrote:

@cramforce https://github.com/cramforce good point. I'll have to switch
to comments for now then.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/github-owners-bot/issues/10#issuecomment-273676455,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFeT6YRD4SCYPy3w35AalvePWAZXtyoks5rTuAjgaJpZM4Lnnoq
.

obsolete.


Manifesto update 2 - Pillars & Initiative

Added Pillars (Proposed) - representing the nature of tasks one can volunteer for.
Tasks right follow some bounty framework for future use-cases.

Added Initiatives and and encapsulated some text in {{}} to suggest it is placeholder.


My (with electron develloped) application is not centered when I put it into the Mac-OS-Autostart.

I wrote this small application https://github.com/ndsvw/Unofficial-Qwant-web-search , but I noticed something.
When I put this application into the Mac-OS-Autostart (System-Settings -> Users and Groupd -> ...), I realized that the application is not centered when it starts automaticly.

Is it a bug or am I doing sth wrong?
(Mac OS High Sierra 10.13.6)

Thanks for reaching out!
You've opened an issue on the repo for the Electron website, which doesn't contain the code for making Electron applications. For most questions about Electron there are a lot of options.
Check out the Electron community. There are also a bunch of helpful people in this community forum that should be willing to point you in the right direction.


Can I pass state between modifiers/assertions?

I'd like to store a value, and then have other elements in the chain act on that value.
Example;
local r = http:get( ... some request ...)
assert.response(r).has.status(200)
local value = assert.response(r).has.header("Content-Length")
assert.are.equal(123, value)

So basically status and header assertions (which I can write myself and add to luassert) would operate on the value provided by the response modifier.
It's related to/prerequisite for #135 I think
I tried to add a value to the state parameter that is passed along the chain, but is was unreliable due to all the meta-table magic the state object has.
What would be the right approach to implement this?

apologies, I meant it's related to #131, not 135

closing this since I create #145


workspace issue

I have no idea how many items are in this workspace. It would be useful to know from the website.  I do know that there are >5000 jobs.

I need to find "SRR3664859" and the only way to do that from my workspace page is by sorting and scrolling.

I have 2 versions of this private genome. From which workspace directory  did they originate? This should exist on the genome page (see second picture).

I have had to reannotate these genomes twice, and will probably have to do it again a 3rd time before it gets made public because there is no "update annotation" button.   I will jam them back into the queue in a day or two.  Sooner or later, this will begin to interfere with new annotation jobs.

Jim triage comment: There are actually four bugs wrapped up in this ticket.
#1.  Medium
#2.  Medium
#3.  High
#4.  High
This user account showing all of the problems that that are occurring once you have assembled more than 50 or so genomes.
As a matter of fact, Maulik and I actually encountered #3 yesterday.  You have no path from a private genome on the website back to the job directory from which came.

1: This is covered in another ticket: https://github.com/PATRIC3/patric3_website/issues/1839 . I'm adding the count either way.
2: Search isn't supported by the workspace service.  Note that using the usual browser search (cmd-f) gets you half way there for this particular scenario.
3: Yeah, this is larger issue that would need team discussion.
4:  Bob was working on a CLI command to re-run jobs.  The plan that we would add it to the UI afterwards, IIRC.
In summary, 2-4 are not currently possible.

@rkenyon shouldn't this get burst into separate issues for the four distinct problems?

Bursted into 4 tickets: #1839  #2083  #2084  #2085
Best guesses for assignees.

I'll close this since there are separate tickets.   Thanks, @rkenyon.


docs: Cleanup (and fix) docker installation instructions

Signed-off-by: Ryan Northey<EMAIL_ADDRESS>Commit Message: docs: Cleanup (and fix) docker installation instructions
Additional Description:
Currently the install page shows docker images that dont exist. This PR will fix that
It will also fix #15730 - ie make clear in all docs how to run latest stable and current dev
In addition it shifts the windows docker install instructions into the docker section and out of the host install sections (and thus bringing parity)
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

reading the comments above im hearing a lot of appeals for special casing (and some borderline insults)
the facts as i understand:

this image is not open source - unlike everything else distributed within CNCF and envoy namespace
the image is huge - everywhere else that a huge (ie > 1GB) image is documented it comes with a warning
the image is not well-tested - it had ~170 downloads last time i checked, comapred to >100 million for the envoy linux image

i understand the desire for parity - but that means playing by the same rules as everyone else
my own opinion is that this image should not be distributed within the CNCF namespace as it is misleading to end users (not to mention the increased maintenance burden that cant be checked/supported if you dont use closed-source code)
regardless, i have done my best to accommodate - which (i hope) @davinci26 will attest
currently the windows docker install section is placed amongst the host installs - it needs to move to the docker section
this pr also provides a bunch of ~unrelated cleanups regarding the publishing of docker images
whatever my own opinion - im trying to bring actual parity to the documentation, and that means giving users fair warning when they are being encouraged to download binaries which are closed, huge or relatively untested

/assign from @envoyproxy/senior-maintainers

/assign-from @envoyproxy/senior-maintainers


Custom Shader Used From StandardMaterial

easy way to make  Custom Shader Used From StandardMaterial
I need test something in Playground so this PR for that

Hello, I cannot validate this PR. I try to keep the Standard material under control :)
But you can inherit from the Standardmaterial and either provide a custom material in the material lib or directly insude ShaderBuilder:)

it is not depend any for shader Builder or BABYLONX
i can inherited from Standard Material  like Custom Material
any way if you accepted this i can make new PR again
ps i feel you don't agree  with this stuff any way i like to know about that

I don't agree because the StandardMaterial is defined around a specific shader. if you want to use a custom shader you can either use a ShaderMaterial directly or create a custom material.
Does it make sense? (I do not want to look like rude of course and I hope I did not upset you :))

so we r good :D  ( am i right )
What about CustomMaterial ??? that is good name or not ?? i wanna inherited that from StandarMaterial
I personally see my self like student in BABYLONJS area and you r master so help me to find a good solution please

I don't clearly understand what you try to achieve :)

i wanna make new class with standard material options and change that
so i wanna say it like custommaterial (or any name)
but i try say " i wanna commit that in Babylon not BABYLONX "

Ok gotcha but this seems too advance for the core engine. The main issue is that users will have to implement in their own shaders a lot of properties (the Stdmaterial is huge) and this will cause a lot of trouble and questions on the forum if this is in the core engine ;)

i feel your sensitive and that is correct .
we mix shadermaterial with standardmaterial
both in core so that can be good .
if you accept we do it in babylon
or not we do it in BABYLONX
my recommended let we do it in babylon
that is important for me because i wanna inherited exactly from standardmaterial
so when standard material if update my work is ok always

But you can still do it in BABYLONX right? I mean you can inherit with no problem.
Unless you want to provide a better shader? in this case you should do a PR for the shader it self
What do you plan to do in this customMaterial?

i wanna append all lights and shadow and all setting  for custom shader
so i wanna help for user to make BaseColor and remove diffuse Color and diffuse Texture
and let user write this part  i can do this now but i hacked BABYLON.StandardMaterial.IsReady
i just add one function for replace default shader with new shader (in Shaderstore ) and when we define that standard material work with all option but with new diffuse (we define that in that function )

and we can call that customMaterial that make new shader but still is a standard material with new diffuse

But why not doing something simpler?
We can expose the defaultShaderName (by default == "default") as a static property. People can then change it to their own shader (So no need for an interface and all the associated code)

but how he/she can append scene lights and shadow and all other setting like ambiant color ....
in this new shader?

i wanna use all we have in standard material but have my own shader :)

So it is a custom material and it could be added to the material library :)

:(  let we have that in beta version
and if you can't see good result i do that in BABYLONX
but i am 99 percent  sure that is easy and you enjoy that after you see last result

not in BABYLONX. In the material library, This is where all materials go :)

ok win win solution
so we r still good friend ? :)

In your next ShaderBuilder,  could you not make a StandardMaterial subclass?  Then have BuildMaterial() use that?  I like where this might go if then you could use a skeleton & animation

i have other method now
that is Build
that make part of shader i need that for this

lol this has never changed :) Friend forever!

thanks  a lot @deltakosh

but i need have very little changes in standard material ok?
let me make new PR

In made DK, it'd be to merge a standardMaterial in ShaderBuilder with splatmap use of ShaderBuilder which can use up to 8 textures diffuse, but can have shadows, lights, fog and other... of standardMaterial.
This will create a terrain that would be evolve with more options.

I think we find a way:)


can define a value from inside a shader

Objective

Fixes #7494
It is now possible to define a ShaderDef from inside a shader. This can be useful to centralise a value, or making sure an import is only interpreted once

Solution

Support #define <SHADERDEF_NAME> <optional value>

How does this interact with ShaderDefs defined outside the shader?
Could we (ab)use this to set default values for ShaderDefs?

It overwrites them which seems the right behaviour to me
you can do something like
#ifndef MY_SHADER_DEF
  #define MY_SHADER_DEF 5
#endif

Alright, Makes sense to me

bors try

bors r+


⚠ WSINGRESOS - RECIBOPAGO has degraded performance

In 3d074c9, WSINGRESOS - RECIBOPAGO (https://srvshyweb.yucatan.gob.mx/cgi-bin/wspd_cgi.sh/WService=wsingresos/internet/servicios/wsRecibosPagosWeb.r) experienced degraded performance:

HTTP code: 200
Response time: 6261 ms

Resolved: WSINGRESOS - RECIBOPAGO performance has improved in b73ec5b after 10 minutes.


Add ueberauth_vk support

Is it a good idea to this provider? https://github.com/sobolevn/ueberauth_vk
I have a concern since it is not widely known outside of Russia.
Thanks!

Does it provide any different information than what is already there about how to set things up? Do you think there's value to adding it?

I think we should refrain from adding third party packages to the example application because:

We do not maintain them and don't want to increase the maintenance efforts of this project chasing down maintainers and having them update packages.

We have to sign-up for and maintain the apps on the individual providers since this is deployed to Heroku.  Given this one is in Russian, it will be even more difficult to obtain.

We can add links to our README pointing to other example applications.

Reasonable points! Thanks!


How to send custom data with Authourization code after login

Im using google oauth authentication, for only singup rather than logging in, so i wanted to send the code  along with user typed password to server after google login but before sending the code to server.

authenticate function takes a second param, user data.

Yeah, i have seen this, but i want to ma


Connector: Handle +1000 stakes for proposal queries

The graph only lets you to query up to 1000 entities per query, so when querying for a proposal, we need to handle pagination for proposals that have more than 1000 active stakes.

We need to update the connector.

Look at examples on how to implement cursors (for pagination) in subgraph.
Link: https://graphql.org/learn/pagination/#pagination-and-edges


[Git Directory Explorer] - Easily navigate through directories containing Git repositories.

 Seamlessly open directories in your preferred code editor and streamline your development workflow.

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

I'm open to collaboration and who knows, it might help to improve this extension.

Hi!
Is this ready for another review?

Yes, I made the corrections that were requested

Hi! Thanks again for your contribution! Now, it seems to work as expected. One little improvement I'd like to see is on the first load. There, I can see only a "Load More" button which might be confusing to the user. Do you mind adding some loading state?

Yes, I can add and request a new review, thanks for the recommendation.

Hi @patriciomartinns. I tried this extension and found that it's not quite what I expected.

you can only select a file and access the Git repository in the current folder; if the Git repository is in a subfolder, it won't be scanned out
This extension only seems to be able to view Git Commit information.

So I have a few suggestions

Wouldn't it be better to rename this extension to Git Commits Explore?
can we use List.Item.Detail to display the first 30 commits directly on the List page, and then go to the secondary page if we want to see more?
Can we use the Pagination function provided by Raycast to achieve the Commit information, which will be more natural and smooth?


Alan Wake: Flashing lights and coloured frames

When playing Alan Wake using DXVK on Windows, when looking in some directions there are flashing lights at the top of the screen, and some frames are black or a filtered colours. These anomalies are linked to framerate so are difficult to capture screens of.

Software information
Alan Wake (Steam)
Settings: 4x AA and the rest in the screenshot.

System information

GPU: AMD RX 6700 XT
Driver: 21.7.2 (latest)
Wine version: NA
DXVK version: 1.9.1 (latest binary)

Apitrace file(s)
https://mega.nz/file/uNtQHDwZ#V5iSB9z7z5fzWFLMErw9MHg4ebC3OLEEingz5bCvVxs
Log files
AlanWake_d3d9.log
Thanks for making DXVK, its very useful for working around AMD not optimizing older APIs in the Windows drivers for their newer cards.

I can't reproduce the problem and there are no validation errors either. This is probably an AMD Windows driver bug.

What are appropriate next steps other than a bug report with AMD?

try with DXVK 1.7.3

Thanks for the suggestion, the issues don't appear with 1.7.3.

Probably the same as #2179

It is indeed. Feedback loop.

@NotBigIntoBooks Friendly ping.
Could you try this again with 1.10.2 and latest driver?

@NotBigIntoBooks Friendly ping. Could you try this again with 1.10.2 and latest driver?

Unfortunately not, I'm not near my desktop and won't be for a while

@Blisto91 I've now had the opportunity to check. With 1.10.3 the issue appears to be resolved.


Statistical Analysis

MZmine 3.0.11-beta
I cannot find the Data Analysis section that was in Feature List Methods in MZmine 2 that allowed you to do PCA, Heat map plot etc.
Is it gone in MZmine 3?

Hi markokkini,
yes they have been disabled because they were not updated yet.
Feel free to contribute if you like! :)

They were not really maintained and needed updating.
It would be great if someone would join to add more interactive statistical analysis in MZmine.
What modules did you use from MZmine 2?

I was mostly using PCA and Heat map plot. What was missing from MZmine 2 was the scree plot to be able to see the contributions of each principal component when generating the PCA plot.
I would like to help but I only have knowledge as a user :)

In case you ever find some students who are interested to help, feel free to direct them to this GitHub, and we also have a Slack


feat(auth): Unified log in/out both API/classic

Revert the commits that changed the components that refer to the logged in user to use
the response from the actions API endpoint.  IOW, those components now, once again, use
the Bearer token instead.  Preserves all the other improvements made to the code along
the way.
The new branch for the plone.restapi includes the API changes to the PAS plugin needed
to set both the Plone classic session cookie and the Bearer token cookie that Volto can
optionally use to initialize authentication without using the Volto login component.
All this put together means that:

the Volto components related to logged in users now behave largely as they did before
in terms of interpreting state
logging in to or out of either classic or Volto also does so in the other

One edge case that remains is when logging in via the Volto UI component as a user from
the Zope root acl_users (e.g. admin or SITE_OWNER_NAME), they aren't logged into
Plone classic.  The other direction is fine, logging in as admin to Plone classic
results in a new request to the Volto UI being logged in.  Digging into that now.
These changes do not address any of the issues that happen when logged in via the ZMI at
the Zope root.  A user logged in that way will still appear logged in to classic Plone,
but won't be recognized by Volto components as logged in but API responses will still
reflect their Manager access rights.  Tackling that is coming up.
This PR supersedes both #2535 #2687.

I'm trying to see if I can't reproduce the CI check failures locally.  I'll request review later when I think it's ready.

K, ready for review now.

For whoever merges/releases this, see details on what changes/PRs/releases in other packages are required for this PR

@rpatterson So, as far as I can see in this PR, the changes are "trivial": the main change is the introduction of the userLoggedIn as a signal that a user is authenticated, instead of having it based on the existence of the token. All the other changes are cosmetic, right?
(It's another bug, but the existence of the token doesn't make the user logged in, the token could be "expired").

Needs https://github.com/plone/plone.restapi/pull/1303 and https://github.com/plone/plone.volto/pull/39

@rpatterson So, as far as I can see in this PR, the changes are "trivial": the main change is the introduction of the userLoggedIn as a signal that a user is authenticated, instead of having it based on the existence of the token. All the other changes are cosmetic, right?

Yeah, with the change of approach to do everything server-side in the PAS plugins and to preserve the JWT token, this PR is now essentially just all the cleanup, refactoring, and build improvements made along that way that I thought were still valuable.  Sorry for not spelling that out more clearly in the PR description.

Ok, so the related PRs in plone.volto and plone.restapi are not actually needed, correct? This could be merged into Volto without waiting for the others.

Ok, so the related PRs in plone.volto and plone.restapi are not actually needed, correct? This could be merged into Volto without waiting for the others.

Oh, right.  Yeah, I misspoke, sorry.  I'll leave it up to you, but I've been testing locally against those PR branches so I've not confirmed that they're not needed, but AFAIK they shouldn't be needed.

Ok, the PRs this was built on top of have all been reviewed, approved and merged.  So AFAIK, this can be merged.  LMK if I'm missing anything.  CC: @tiberiuichim @sneridagh

For future reference, here's a ./Makefile target I've been using to reproduce upgrade/migration issues with existing ZODBs:
.PHONY: test-upgrades
test-upgrades:  ## Test upgrading existing ZODBs
# Start out before the PR changes
	git checkout master
# Delete and recreate the Zope instance ZODB
	rm -r "./api/.installed.cfg" "./api/var/filestorage/" "./api/var/blobstorage/"
	$(MAKE) build
# Activate job control so back-grounded process get their own PGID so we can kill all
# their descendant processes: https://stackoverflow.com/a/6552484/624787
	set -m
# Start the clean instance
	$(MAKE) start &
	set +x
	until nc -vz "localhost" "3000"; do sleep 1; done
	echo "In the browser, log into the Volto/React UI as the Zope root"
	echo "'/acl_users' user 'admin' to ensure the browser has a JWT token."
	read -p "Hit <ENTER> when done."
	set -x
	kill %1
	while nc -vz "localhost" "3000"; do sleep 1; done
# Force the backend Plone classic UI to be served on the same port so the browser will
# send the same cookies, etc..
	rm -v "./api/.installed.cfg"
	$(MAKE) -C "./api/" INSTANCE_PORT=3000 start &
	set +x
	until nc -vz "localhost" "3000"; do sleep 1; done
	echo "In the browser, visit the Zope root ZMI:"
	echo "http://localhost:3000/manage_main"
	read -p "Hit <ENTER> when done."
	set -x
	kill %1
	while nc -vz "localhost" "3000"; do sleep 1; done
# Checkout the branch that changes the plugins
	git checkout fix-unify-auth
# Start the backend again on the same port, but don't install the `plonesite` part to
# avoid updating/upgrading the ZODB
	cd "./api/"
	"./bin/buildout" instance:http-address=3000 install instance
	"./bin/instance" fg &
	set +x
	until nc -vz "localhost" "3000"; do sleep 1; done
	echo "In the browser, visit the Zope root ZMI:"
	echo "http://localhost:3000/manage_main"
	read -p "Hit <ENTER> when done."
	set -x
	kill %1

mag Inspect the deploy log: https://app.netlify.com/sites/volto/deploys/6218aeab225ab70008a1c0a6

The error message there is about a missing ./Makefile target, netlify, but from the logs I can't see any changes of mine that could have removed such a target.  Can someone help me understand how my changes might have affected that or may I ignore that message?

mag Inspect the deploy log: https://app.netlify.com/sites/volto/deploys/6218aeab225ab70008a1c0a6

The error message there is about a missing ./Makefile target, netlify, but from the logs I can't see any changes of mine that could have removed such a target. Can someone help me understand how my changes might have affected that or may I ignore that message?

It fails because the version of the Makefile in this PR does not include the netlify target that was added within the last couple of weeks to the master branch to preview the build of docs.
You could ignore it, but it might be a good idea to rebase your branch on master, then force push, or merge master onto your branch then push, in order to get any of the goodies that have come through in the last two months since opening this PR.

It fails because the version of the Makefile in this PR does not include the netlify target that was added within the last couple of weeks to the master branch to preview the build of docs.

Doh!  I should have checked for new commits on master before asking for help there, sorry!  Thanks for the helping hand.  I've merged and pushed.

I pushed commit https://github.com/plone/volto/pull/2959/commits/ffc731ed4480eefab37fada07e907489d788d903 for review.
I also commented on the function name: https://github.com/plone/volto/pull/2959#discussion_r817466767


Fresh Install longhorn volumes not getting attached to pods

Describe the bug
I have created an 3 node RKE2 cluster on bare metal azure VM's and I have installed longhorn as per the documentation through kubectl method
Each machine has one 256 GB SSD attached to it and this is how I have partitioned each disk and attached the same via longhorn UI
Now to testing the working of it , I have created an volume as per the documentation
kubectl create -f https://raw.githubusercontent.com/longhorn/longhorn/v1.0.0/examples/pod_with_pvc.yaml
but the PVC just got stuck in attached state, it's getting attached and detached again, Attaching -> Attached -> Detached -> Attaching -> looping forever
mkfs -t ext4 /dev/sdc
mkdir -p /mnt/sdc
mount /dev/sdc /mnt/sdc

curl -sfL https://get.rke2.io --output install.sh
chmod +x install.sh
INSTALL_RKE2_CHANNEL=latest ./install.sh

cat /etc/rancher/rke2/config.yaml

selinux: false
server: https://xx.xx.122.14:9345
token:
ae70e::server:0a83109039dc25b19b2b16481a419967
tls-san:
  - xx.xx.122.14

Expected behavior
PVC should get attached to the pod
Please find the support bundle attached with the ticket.
Environment:

Longhorn version: Tried both 1.0.0 and 1.1.1
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: RKE2

Number of management node in the cluster: 3
Number of worker node in the cluster: 0

Node config

OS type and version: RHEL 8.2
CPU per node: 8 Core
Memory per node: 32
Disk type(e.g. SSD/NVMe): SSD
Network bandwidth between the nodes: All Nodes are within the same VPC

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): Azure VM's
Number of Longhorn volumes in the cluster: 3

Please find the attached support bundle for both 0.8.0 and 1.1.1 versions and please let us know how to get it working
longhorn-support-bundle_3c9f69e8-1d79-4735-8296-b0c85dbd53c4_2021-02-06T14-46-50Z.zip
longhorn-support-bundle_9909a827-5083-43ed-87dd-83d798eb91f5_2021-02-06T13-17-31Z.zip

Events:
  Type     Reason            Age   From               Message
  ----     ------            ----  ----               -------
  Warning  FailedScheduling  29s   default-scheduler  0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims.
  Warning  FailedScheduling  29s   default-scheduler  0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims.
  Normal   Scheduled         23s   default-scheduler  Successfully assigned default/volume-test to rke2-3
[root@rke2-3 longhorn]#
[root@rke2-3 longhorn]#
[root@rke2-3 longhorn]#
[root@rke2-3 longhorn]# kubectl get pvc
NAME                STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   AGE
longhorn-volv-pvc   Bound    pvc-657777db-3829-42ce-ad1b-fccf30c3f425   2Gi        RWO            longhorn       40s
[root@rke2-3 longhorn]# kubectl get pv
NAME                                       CAPACITY   ACCESS MODES   RECLAIM POLICY   STATUS   CLAIM                       STORAGECLASS   REASON   AGE
pvc-657777db-3829-42ce-ad1b-fccf30c3f425   2Gi        RWO            Delete           Bound    default/longhorn-volv-pvc   longhorn                43s

One quick question, have you installed iscsi on all of your worker nodes? https://longhorn.io/docs/0.8.0/install/requirements/
To debug the issue, we need to check the info of the stuck pod volume-test (by using kubectl describe), and the logs of longhorn manager pods or instance manager pods (by using kubectl logs).

yes, I have installed yum install iscsi-initiator-utils on all the nodes and I have verified the setup through the shell script that has been documented
To share the logs, I no longer have that environment, but with the ticket, I have attached the support dump, wouldn't it contain the logs that are required to debug the issue ?

I see tons of the iscsi related errors in your cluster. Can you check if the iscsi service is started among all of your nodes?:

2021-02-06T14:37:59.604753678Z time="2021-02-06T14:37:59Z" level=warning msg="pvc-97ad64ce-99b2-4bc0-ac52-e8ae30b4b568-e-0220a350: time=\"2021-02-06T14:37:55Z\" level=warning msg=\"FAIL to discover due to Failed to execute: nsenter [--mount=/host/proc/1/ns/mnt --net=/host/proc/1/ns/net iscsiadm -m discovery -t sendtargets -p <IP_ADDRESS>], output , stderr, Failed to connect to bus: No data available\\niscsiadm: can not connect to iSCSI daemon (111)!\\nFailed to connect to bus: No data available\\niscsiadm: can not connect to iSCSI daemon (111)!\\niscsiadm: Cannot perform discovery. Initiatorname required.\\niscsiadm: Could not perform SendTargets discovery: could not connect to iscsid\\n, error exit status 20\""
2021-02-06T14:37:59.604781179Z time="2021-02-06T14:37:59Z" level=warning msg="pvc-97ad64ce-99b2-4bc0-ac52-e8ae30b4b568-e-0220a350: time=\"2021-02-06T14:37:55Z\" level=warning msg=\"Nodes cleaned up for iqn.2019-10.io.longhorn:pvc-97ad64ce-99b2-4bc0-ac52-e8ae30b4b568\""
2021-02-06T14:37:59.604799079Z time="2021-02-06T14:37:59Z" level=warning msg="pvc-97ad64ce-99b2-4bc0-ac52-e8ae30b4b568-e-0220a350: time=\"2021-02-06T14:37:58Z\" level=error msg=\"Failed to startup frontend: Failed to execute: nsenter [--mount=/host/proc/1/ns/mnt --net=/host/proc/1/ns/net iscsiadm -m node -T iqn.2019-10.io.longhorn:pvc-97ad64ce-99b2-4bc0-ac52-e8ae30b4b568 -p <IP_ADDRESS> --login], output , stderr, iscsiadm: No records found\\n, error exit status 21\""
2021-02-06T14:37:59.604803279Z time="2021-02-06T14:37:59Z" level=warning msg="pvc-97ad64ce-99b2-4bc0-ac52-e8ae30b4b568-e-0220a350: 2021/02/06 14:37:58 failed to start up frontend: Failed to execute: nsenter [--mount=/host/proc/1/ns/mnt --net=/host/proc/1/ns/net iscsiadm -m node -T iqn.2019-10.io.longhorn:pvc-97ad64ce-99b2-4bc0-ac52-e8ae30b4b568 -p <IP_ADDRESS> --login], output , stderr, iscsiadm: No records found"

I don't know why there are volumes using the non-existing v0.8.0 engine image. And I am not sure if this old engine image is still compatible in v1.1.0. If possible, can you upgrade them to the default engine image?

2021-02-06T14:38:29.202969774Z time="2021-02-06T14:38:29Z" level=warning msg="Error syncing Longhorn replica longhorn-system/pvc-02ec116d-889a-48de-8376-e54c95c1fe9f-r-5d7abbb2: fail to sync replica for longhorn-system/pvc-02ec116d-889a-48de-8376-e54c95c1fe9f-r-5d7abbb2: failed to cleanup the related replica process before deleting replica pvc-02ec116d-889a-48de-8376-e54c95c1fe9f-r-5d7abbb2: failed to get engine image object based on image name longhornio/longhorn-engine:v0.8.0: engineimage.longhorn.io \"ei-e10d6bf5\" not found"

possibly related to iscsci installation on redhat #1741

This user found that they are missing a library on rhel, might help with open-iscsi problems.
#2163

Based on our QA test result in RHEL8.3, RHEL 8.3 will not start iscsid service automatically then lead to errors like iscsiadm: No records found and the users need to start it manually. Can you check if there is a similar case in RHEL8.2?

I have observed this on few installs where it started automatically but on few it didn't , it's very random

We will check back this issue once we're done with https://github.com/longhorn/longhorn/issues/1741

@khushboo-rancher or @cclhsu I assume this should be already tackled in https://github.com/longhorn/longhorn-manager/pull/840 because of the prerequisite installation already verified in CentOS 8.x. Can you double confirm? Thanks.

The logs which user provided are the same as described in https://github.com/longhorn/longhorn/issues/2319.  Solution was tested on Centos 7.8 and 8.2.  @kaskavalci Can you confirm if it is the same for RHEL 8.2?

https://github.com/longhorn/longhorn/issues/2319 is validated with RHEL7.8 and RHEL8.2

Closing, resolved by #2319


Replace setup.py and setup.cfg (#170)

Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

/verified


How to turn off grab and slide to right & left sliding effect! And use the controllers only!

Could you help me, please?

you just have to set the "simulateTouch" option to false


Too many files open

At times, I see the following error:
java.nio.file.FileSystemException: /Users/enderlej/Desktop/Topic Modeling/output/output_html/Docs/Doc491.html: Too many open files in system
	at sun.nio.fs.UnixException.translateToIOException(UnixException.java:91)
	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
	at sun.nio.fs.UnixFileSystemProvider.newByteChannel(UnixFileSystemProvider.java:214)
	at java.nio.file.spi.FileSystemProvider.newOutputStream(FileSystemProvider.java:434)
	at java.nio.file.Files.newOutputStream(Files.java:216)
	at java.nio.file.Files.newBufferedWriter(Files.java:2860)
	at cc.mallet.topics.gui.HtmlBuilder.buildHtml2(HtmlBuilder.java:166)
	at cc.mallet.topics.gui.HtmlBuilder.createHtmlFiles(HtmlBuilder.java:283)
	at cc.mallet.topics.gui.TopicModelingTool.outputCsvFiles(TopicModelingTool.java:1265)
	at cc.mallet.topics.gui.TopicModelingTool.runMallet(TopicModelingTool.java:1181)
	at cc.mallet.topics.gui.TopicModelingTool$TrainButtonListener$1.run(TopicModelingTool.java:468)

I've looked through the code, and haven't found an obvious point where files aren't being closed properly. However, the logic of the function that does this work (buildHtml2 in HtmlBuilder) is truly clunky and obviously bug-prone. I'll need to investigate further. This is a hard bug to reproduce since it only happens sometimes, even for models with lots of files.

It turns out there were lots of places where files weren't being closed. I found them and closed the files.


Cannot load gallery item detail from specific collection /snek

While browsing https://beta.kodadot.xyz/snek/collection/807893860, I cannot load the item detail when I click on any of the items, I get loaded just the placeholder. Happens specifically with this collection, not sure why (most of the others)

Hey, I have fixed this bug in #4008 https://github.com/kodadot/nft-gallery/pull/4008/commits/703c29da7554aec522cc2dbb249a19339b6f1cfb
preview:

https://deploy-preview-4008--koda-nuxt.netlify.app/snek/gallery/807893860-4


Question. How to include dynamic args to live_grep

I want to include dynamic args for live_grep, for example in vim-clap plugin in grep provider input you can specify actions *.ts and it will translate  query to rg -g "*.ts" "actions".  Or in emacs world there is an ivy-plugin  where in rg you can specify actions -- -t ts and achieve the same behaviour.  Can we have something like this?

You can modify rg_opts or even send an entire new command to live_grep, one of these options should work for your use case:
:lua require'fzf-lua'.live_grep({ rg_opts = “…” })

Another example:
:lua require'fzf-lua'.live_grep({ cmd = “rg …” })

You can even provide raw_cmd instead which will be sent without any processing or escaping to fzf directly (so you have to shell escape it yourself).

Okay, but lua require'fzf-lua'.live_grep({ rg_opts = “-g '*.ts'” }) is a prefiltering command. I want to be able to use it dynamycally in input like this
Rg> actions -q "*.ts"<
or something like Rg> actions  | *.tx<

I see, I think you might need a custom script for that, see this discussion about using the glob feature https://github.com/ibhagwan/fzf-lua/issues/31

Yeah, I guess that's the only way for now, thanks.

@ibhagwan
Thank you very much for a nice feature.
I have just tested live_grep_glob. It works well even with multiple globs. 💯
However, I had to escape \- for the dash. Is there anyway to avoid escaping for dash character?

@ibhagwan
Thank you very much for a nice feature.
I have just tested live_grep_glob. It works well even with multiple globs. 💯
However, I had to escape \- for the dash. Is there anyway to avoid escaping for dash character?

You don’t have to escape dash as a separator (see my screencast, it’s not escaped), but you do have to escape it to search for it literally as it’s a regex special character like + or *, etc.

Works great for me.

Great!

if you wanna add dash into the glob I can make sure the glob arguments are escaped, lmk.

Before I close this, @fanliver can you let me know which character's you'd like escaped inside the glob and what is the use case? what is the exact use case for adding - in the glob? simple inlcude/exclude?

Sometimes, I look for the command line argument in shell script or some text in the code with hyphen in the name.
It's totally OK for me to use regex for search and escape the special characters. So don't worry. :) Thank you for the nice feature.

Alright, then I guess we can close this.

Could we have something like live_grep_glob_resume?

Could we have something like live_grep_glob_resume?

Don't need a special command for that, just change your mapping to:
:lua require'fzf-lua'.live_grep_glob({ continue_last_search = true })
-- live_grep_resume is just a shortcut too:
:lua require'fzf-lua'.live_grep({ continue_last_search = true })

@ibhagwan Thank you!

@ibhagwan How to use glob without manually adding * between the path keyword I want to search, i.e. I can write ' -- foo' instead of  -- *foo*?

@ibhagwan How to use glob without manually adding * between the path keyword I want to search, i.e. I can write ' -- foo' instead of  -- *foo*?

You’d have to create your own custom implementation, the * is standard wildcard syntax and is controlled by rg, not FzfLua, *foo means match any character before foo.

@ibhagwan What I meant is not to change the syntax of rg, but with the help from fzf-lua to complete the syntax to let a user(e.g. me) be able to type -- foo to mean -- *foo*. This way when -- * in the middle of typing a glob, the live_... feature won't use this -- * to overwrite those excluded paths I have written in the config.

Then we can further design that -- ... means wrapped by wildcard by default. Then when users doesn't want this behaviour they can use another syntax, e.g. --x ... to mean the current -- ....

@ibhagwan My idea is that this can be done without changing the syntax of rg. But if we can let users type -- foo to mean -- foo. This way the -- * will not appear in the middle of typing a glob. In this way, those pre-excluded paths from the config won't be overwritten.

You can see that most of the time we need wildcard, so why not wrap the keyword with it for the users?

I understood what you meant and of course it can be done, anything can be done and you can make the parser do whatever you want and adjust to rg commands in any way you wish by writing your own glob parsing function.
I just personally think it's too much of a narrow use case and also very specific, it requires knowing how the format works and additonal "manual", I prefer to stay with the default syntax, as long as users know the argument passes "as is" into an --iglob they know what to do.

Want to search the only tmux folder

I'm not even sure if this is possible, I think --iglob only supports filenames at the end of the path, or it requires  to be written in a different way, I don't have enough experience with it, try man rg to see if this is even possible.

Wait, why still match?

Once the matches stop and the command returns no results I think the last known result is still displayed, use debug=true and use the underlying command in the shell and see what it returns, there really is nothing I can do about what rg returns.


Code in separate files

This is proposal for splitting code into several files. It currently contains following files:

jvm.jl - all code related to initializing and destroying JVM, as well as related functions and local types
jnienv.jl - JNI environment, no changes from previous version
types.jl - core (JavaObject and JavaMetaClass) and exported types (jint, JString, etc.); all related functions (e.g. bytestring() or jvalue) also reside here
jcall.jl - jcall(), jnew(), @jimport and all helper functions
convert.jl - all conversion functions, including convert_args() and convert_results()
reflect.jl - reflection API minus Java types which were moved to types.jl

Many functions equally belong to 2 or more files, so corrections / updates are welcome.

Thanks!.
Looking at this, I think types.jl and jcall.jl belong together. Maybe call it core.jl or something. The trouble with too fine a dividing line is that over time, that line will get more and more difficult to maintain, and then you will be left rooting through multiple files to find something.
jvml.jl and convert.jl are clear what they contain.
I think bytestring should go into convert.jl.

The trouble with too fine a dividing line is that over time, that line will get more and more difficult to maintain, and then you will be left rooting through multiple files to find something.

I usually use grep :) But of course, splitting different and combining related things is always a good idea, and core methods look pretty much related to the types they use.
I created core.jl and moved bytestring() to convert.jl.

Looks good. I'll leave it open overnight if there are any other comments, and merge tomorrow. Thanks again!


Rewrite GM queries for INFRA-AWSEBSVOLUME

Relevant information
Rewrite GM queries for INFRA-AWSEBSVOLUME to display write/read bytes instead of write/read time. cc. @josemore
Checklist

[ ] I've read the guidelines and understand the acceptance criteria.
[ ] The value of the attribute marked as identifier will be unique and valid.
[ ] I've confirmed that my entity type wasn't already defined. If it is I'm providing an
explanation above.

Waiting for cloud integrations review

LGTM


May I ask a question

How to decrypt with JAVA?

@luoqingping1234 There is no js lib doing the "sm2 decrypt/encrypt" thing.For now, you have to do it yourself.


feat: add MarkSignLineHL

(Thanks great plugin.)
I want to highlight the rows where sign is set.
Default is set to NONE so as not to break the current configuration,

sample


GCC warning re string truncation

Currently using GCC10 on Fedora32, however I believe this warning was added in GCC8
In member function ‘void io::error::with_file_name::set_file_name(const char*)’,
    inlined from ‘char* io::LineReader::next_line()’ at /home/user/app/thingbase/ext/csv.hpp:472:34,
    inlined from ‘bool io::CSVReader<column_count, trim_policy, quote_policy, overflow_policy, comment_policy>::read_row(ColType& ...) [with ColType = {char*, char*, char*, char*, char*, char*, char*, char*}; unsigned int column_count = 8; trim_policy = io::trim_chars<'\011'>; quote_policy = io::double_quote_escape<',', '\"'>; overflow_policy = io::throw_on_overflow; comment_policy = io::no_comment]’ at /home/user/app/thingbase/ext/csv.hpp:1245:44,
    inlined from ‘virtual void xtemplate::XTrader::Initialize()’ at /home/user/app/thingbase/src/templates/XTrader.cpp:87:22:
/home/user/app/thingbase/ext/csv.hpp:78:28: warning: ‘char* strncpy(char*, const char*, size_t)’ output may be truncated copying 255 bytes from a string of length 255 [-Wstringop-truncation]
   78 |                     strncpy(this->file_name, file_name, sizeof(this->file_name));
      |                     ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Nothing critical - still compiling and working it seems.
Full version gcc version 10.2.1 20200723 (Red Hat 10.2.1-1) (GCC)
Thanks!

In theory, GCC should detect the 0-assignment in the next line and silence the warning. However, this part of GCC seems to be buggy and not always sees the 0-assignment.
Related: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87028
Adding superfluous parenthesis suppresses the warning. I added that.


Custom pyclient event response

Closes https://github.com/G-Research/armada/issues/1198

I am going to redesign the Objects so that there is an Event Object, and a Message Object that will only accept parameters. This will make documenting it a lot cleaner

Depending on what features are kept / removed based on https://github.com/G-Research/armada/pull/1239, more docstrings might be required to explain the subtle differences between how the python client handles these proto objects vs Golang or C#


Periodic isotropic channel flow with the simplified equation system, which conserves kinetic energy (based on overleaf doc), make this a unit test. ClimaCore

See https://github.com/CliMA/ClimaCore.jl/pull/1098

@akshaysridhar should we close this?

Yes ; I think we can close this - we are tracking longer term testing outcomes in #1455.


Yaml support for Keras Sequential models

Sequential now has to_yaml() method to dump models as yaml strings.
models module has sequential_from_yaml() method to load from such strings
Models can be stored with and without parameters.
It's possible to (de-)serialize non-standard optimizers, constraints and regularizers.
Includes a test that checks for equality of configs before and after serialization.

I believe this would not work with Sequential models that include one or several Merge layers. What is your take on that?

I haven't thought about Merge layers much. In fact, I was under the impression that a Sequential shouldn't allow for that. For now, this PR is meant as serialisation of sequential (in its literal meaning) models. Merging Sequentials would need a description language of graphs, i.e. how to connect Sequentials. Right now I'm not sure how to do this properly. Any thoughts on your side?

Actually I believe your code could be reused for serializing / loading multi-branch sequential models (and Graph models as well) very easily. First you identify the Merge layers, then for each Merge layer you serialize the merged containers, as a list. Recursively.

I've tried to integrate all your suggestions in the latest update. Notably, we can now de-/serialize general Sequential and Graph models, which is also reflected in tests. The namespace of models.py is kept clean and it is possible to serialize both compiled and uncompiled models. With very little changes we could get rid of the compiled one, if you insist.

Thank you for the update!
I merged it, with the following modifications:

Style standardization
Python3 compatibility (used a few Python2-only features)
Made pyyaml a dependency in setup.py (yaml support is not part of the Python stdlib)
Removed weight saving in yaml files.

The last point was motivated by the following reasons:

Readability: the main point of yaml files for storing model configuration is that humans can read and edit them. Storing weights alongside the model structure would break this.
Efficiency: we already have a very efficient way to save weights (HDF5), whereas dumping them to yaml would be quite inefficient both time-wise and space-wise. It is also always preferable to only have one obvious way to do something, not two.
Avoiding redundancy in the codebase: weight saving required a set of layer_to_yaml methods that were effectively the same as get_config, with weights. We should only have one get_config. Additionally, the naming was rather misleading since these methods did not in fact return a yaml object but instead a Python dictionary. Besides, the intuitive naming for these methods would have been to_yaml rather than layer_to_yaml (since they are methods of Layer/Container objects, therefore they obviously apply to a layer-like), which would then have caused recursion issues since they would have had a different behavior than Model.to_yaml (which does return a yaml string).

TL;DR: layer_to_yaml is gone, we're using get_config instead. Weight saving will be done in HDF5:
graph_yaml = graph.to_yaml()
graph.save_weights('temp.h5')

reloaded_graph = model_from_yaml(graph_yaml)
reloaded_graph.load_weights('temp.h5')

Thank you for the valuable contribution!

This fixes #376, so closing. This is awesome, thanks!


Docker and distillery deployement

I'm running into an issue deploying with docker and distillery.
Running a local deployment with distillery works fine. However when I do the same deployment with docker then I get this error.
web_1         | 2018-07-12 23:43:16 crash_report
web_1         |     initial_call: {supervisor,kernel,['Argument__1']}
web_1         |     pid: <0.2238.0>
web_1         |     registered_name: []
web_1         |     error_info: {exit,{on_load_function_failed,'Elixir.Union.ConsolidatedExecution'},[{init,run_on_load_handlers,0,[]},{kernel,init,1,[{file,"kernel.erl"},{line,217}]},{supervisor,init,1,[{file,"supervisor.erl"},{line,294}]},{gen_server,init_it,2,[{file,"gen_server.erl"},{line,365}]},{gen_server,init_it,6,[{file,"gen_server.erl"},{line,333}]},{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,247}]}]}
web_1         |     ancestors: [kernel_sup,<0.2214.0>]
web_1         |     message_queue_len: 0
web_1         |     messages: []
web_1         |     links: [<0.2215.0>]
web_1         |     dictionary: []
web_1         |     trap_exit: true
web_1         |     status: running
web_1         |     heap_size: 610
web_1         |     stack_size: 27
web_1         |     reductions: 235
web_1         | 2018-07-12 23:43:16 supervisor_report
web_1         |     supervisor: {local,kernel_sup}
web_1         |     errorContext: start_error
web_1         |     reason: {on_load_function_failed,'Elixir.Union.ConsolidatedExecution'}
web_1         |     offender: [{pid,undefined},{id,kernel_safe_sup},{mfargs,{supervisor,start_link,[{local,kernel_safe_sup},kernel,safe]}},{restart_type,permanent},{shutdown,infinity},{child_type,supervisor}]
web_1         | 2018-07-12 23:43:17 crash_report
web_1         |     initial_call: {application_master,init,['Argument__1','Argument__2','Argument__3','Argument__4']}
web_1         |     pid: <0.2213.0>
web_1         |     registered_name: []
web_1         |     error_info: {exit,{{shutdown,{failed_to_start_child,kernel_safe_sup,{on_load_function_failed,'Elixir.Union.ConsolidatedExecution'}}},{kernel,start,[normal,[]]}},[{application_master,init,4,[{file,"application_master.erl"},{line,134}]},{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,247}]}]}
web_1         |     ancestors: [<0.2212.0>]
web_1         |     message_queue_len: 1
web_1         |     messages: [{'EXIT',<0.2214.0>,normal}]
web_1         |     links: [<0.2212.0>,<0.2211.0>]
web_1         |     dictionary: []
web_1         |     trap_exit: true
web_1         |     status: running
web_1         |     heap_size: 376
web_1         |     stack_size: 27
web_1         |     reductions: 213
web_1         | 2018-07-12 23:43:17 std_info
web_1         |     application: kernel
web_1         |     exited: {{shutdown,{failed_to_start_child,kernel_safe_sup,{on_load_function_failed,'Elixir.Union.ConsolidatedExecution'}}},{kernel,start,[normal,[]]}}
web_1         |     type: permanent
web_1         | {"Kernel pid terminated",application_controller,"{application_start_failure,kernel,{{shutdown,{failed_to_start_child,kernel_safe_sup,{on_load_function_failed,'Elixir.Union.ConsolidatedExecution'}}},{kernel,start,[normal,[]]}}}"}
web_1         | Kernel pid terminated (application_controller) ({application_start_failure,kernel,{{shutdown,{failed_to_start_child,kernel_safe_sup,{on_load_function_failed,'Elixir.Union.ConsolidatedExecution'}}},{ke
web_1         |
web_1         | Crash dump is being written to: erl_crash.dump...done

when I try to start the release with the foreground command
Here is my docker file
FROM elixir:1.6.6-alpine

ARG APP_NAME=union
ARG MIX_ENV=prod
ARG APP_VERSION=0.0.0
ARG PHOENIX_SUBDIR=.
ENV MIX_ENV ${MIX_ENV}
ENV APP_VERSION ${APP_VERSION}
ENV REPLACE_OS_VARS true

WORKDIR /opt/app
# use yarn instead of npm to reduce from 180s to 60s
# add git since one dependency pulls from git
RUN apk update \
  && apk --no-cache --update add nodejs yarn rust cargo git build-base \
  && mix local.rebar --force \
  && mix local.hex --force
COPY . .
RUN mix do deps.get, deps.compile, compile

RUN cd ${PHOENIX_SUBDIR}/assets \
  && yarn install \
  && yarn deploy \
  && cd .. \
  && mix phx.digest
RUN mix release --env=${MIX_ENV} --verbose \
  && mv _build/prod/rel/${APP_NAME} /opt/release \
  && mv /opt/release/bin/${APP_NAME} /opt/release/bin/start_server

# minimal runtime image
FROM alpine:3.8
# bash is required by distillery
RUN apk update && apk --no-cache --update add bash openssl-dev
ENV REPLACE_OS_VARS true
WORKDIR /opt/app
COPY --from=0 /opt/release .
CMD ["/opt/app/bin/start_server", "foreground"]

I have checked in the docker container that the priv/native contains the .so files
Somebody pointed me to this issue https://github.com/riverrun/argon2_elixir/issues/5
However I have check that smp is enabled though, and dirty schedulers is enabled since otp 19
I'm not really sure where to look next, any clues/pointers would be appreciated.
I understand that this might not be the right place to post this issue. If you feel strongly against it, feel free to close it.

Try adding musl-dev to your apk add since you are using Alpine.

@scrogson thanks for the advice. Unfortunately I still get the same error

@happysalada are you sure that elixir:1.6.6-alpine and alpine:3.8 are both Alpine 3.8 images? That would be my first guess as to a potential problem, since compiled artifacts across Alpine versions may not load. The fact that the release will boot within the same container, but not when brought across to another container indicates that this is more likely an issue with something missing in the target container, rather than a build issue per se.
You could try setting -loader_init and/or -init_debug in your vm.args to see if that yields more information during boot about what might be causing the failure.

@bitwalker thanks for this! Indeed they are not the same versions. I was lazily waiting for the next version of distillery to be able to release the next version of elixir which is 3.8. (I'll try dowgrading instead)
thanks also for the vm.args tip, I'll give it a try!

That experiment yielded some interesting results.
elixir 1.6.6-alpine is based on erlang-20-alpine which was originally alpine 3.7, but was bumped to alpine 3.8. If there is a need to stay consistent with the alpine version, everytime a new version comes out, you have to watch out if one of your docker image doesn't get updated without you knowing it.
adding the two flags in vm.args, yielded the following informations
| {progress,applications_loaded}
web_1         | {apply,{application,start_boot,[kernel,permanent]}}
web_1         | {running_on_load_handler,'Elixir.Union.ConsolidatedExecution'}
web_1         | {on_load_function_failed,'Elixir.Union.ConsolidatedExecution'}
web_1         | 2018-08-08 01:31:19 crash_report
web_1         |     initial_call: {supervisor,kernel,['Argument__1']}
web_1         |     pid: <0.2243.0>
web_1         |     registered_name: []
web_1         |     error_info: {exit,{on_load_function_failed,'Elixir.Union.ConsolidatedExecution'},[{init,run_on_load_handlers,0,[]},{kernel,init,1,[{file,"kernel.erl"},{line,217}]},{supervisor,init,1,[{file,"supervisor.erl"},{line,294}]},{gen_server,init_it,2,[{file,"gen_server.erl"},{line,365}]},{gen_server,init_it,6,[{file,"gen_server.erl"},{line,333}]},{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,247}]}]}
web_1         |     ancestors: [kernel_sup,<0.2219.0>]
web_1         |     message_queue_len: 0
web_1         |     messages: []
web_1         |     links: [<0.2220.0>]
web_1         |     dictionary: []
web_1         |     trap_exit: true
web_1         |     status: running
web_1         |     heap_size: 610
web_1         |     stack_size: 27
web_1         |     reductions: 235
web_1         | 2018-08-08 01:31:19 supervisor_report
web_1         |     supervisor: {local,kernel_sup}
web_1         |     errorContext: start_error
web_1         |     reason: {on_load_function_failed,'Elixir.Union.ConsolidatedExecution'}
web_1         |     offender: [{pid,undefined},{id,kernel_safe_sup},{mfargs,{supervisor,start_link,[{local,kernel_safe_sup},kernel,safe]}},{restart_type,permanent},{shutdown,infinity},{child_type,supervisor}]
web_1         | 2018-08-08 01:31:20 crash_report
web_1         |     initial_call: {application_master,init,['Argument__1','Argument__2','Argument__3','Argument__4']}
web_1         |     pid: <0.2218.0>
web_1         |     registered_name: []
web_1         |     error_info: {exit,{{shutdown,{failed_to_start_child,kernel_safe_sup,{on_load_function_failed,'Elixir.Union.ConsolidatedExecution'}}},{kernel,start,[normal,[]]}},[{application_master,init,4,[{file,"application_master.erl"},{line,134}]},{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,247}]}]}
web_1         |     ancestors: [<0.2217.0>]
web_1         |     message_queue_len: 1
web_1         |     messages: [{'EXIT',<0.2219.0>,normal}]
web_1         |     links: [<0.2217.0>,<0.2216.0>]
web_1         |     dictionary: []
web_1         |     trap_exit: true
web_1         |     status: running
web_1         |     heap_size: 376
web_1         |     stack_size: 27
web_1         |     reductions: 213
web_1         | 2018-08-08 01:31:20 std_info
web_1         |     application: kernel
web_1         |     exited: {{shutdown,{failed_to_start_child,kernel_safe_sup,{on_load_function_failed,'Elixir.Union.ConsolidatedExecution'}}},{kernel,start,[normal,[]]}}
web_1         |     type: permanent
web_1         | {apply,{application,start_boot,[stdlib,permanent]}}
web_1         | {"Kernel pid terminated",application_controller,"{application_start_failure,kernel,{{shutdown,{failed_to_start_child,kernel_safe_sup,{on_load_function_failed,'Elixir.Union.ConsolidatedExecution'}}},{kernel,start,[normal,[]]}}}"}
web_1         | Kernel pid terminated (application_controller) ({application_start_failure,kernel,{{shutdown,{failed_to_start_child,kernel_safe_sup,{on_load_function_failed,'Elixir.Union.ConsolidatedExecution'}}},{ke
web_1         |
web_1         | Crash dump is being written to: erl_crash.dump...done
union_web_1 exited with code 1

it seems that the on_load function is failing
looking at it, it is trying to get the nif_path from priv_dir
could it be that the code for getting a priv_dir doesn't work with a release? ie: otp_app |> :code.priv_dir() |> to_string()
just a thought.
I feel we are getting closer.
Wondering how to debug this. Is there a way to compile a local version of the library with inspect statement to check what is happening? (just a thought)

@happysalada The :code.priv_dir/1 function works in releases (as does Application.app_dir/2), and is in fact the recommended way of getting assets in a release, so that isn't the issue.
More likely is that the .so file it is trying to load, can't be loaded. This could happen if the compiled artifact references dynamic libraries that are unavailable, not at the paths expected (i.e. not in LD_LIBRARY_PATH), or are different versions (i.e. the .so expects 1.3.4 of X, but the available version of X is 1.4.0).
One thing you can try is run bin/myapp console_clean, then:
iex> Application.load(:myapp)
...> priv_dir = Application.app_dir(:myapp, "priv")
...> nif_path = Path.join([priv_dir, "path", "to", "nif"])
...> load_data = # Whatever this would be set to for this NIF
...> try do
:erlang.load_nif(String.to_charlist(nif_path), load_data)
catch
  kind, err ->
    {kind, err}
end

This will catch the load error and let you see more detail (ideally). You do need to figure out what load_data would be for this NIF, but you should be able to work backwards in the Rustler code you linked to find out what that value would be.

I didn't know about the console_clean trick!
Bingo!
{:error,
 {:load_failed,
  'Failed to load NIF library: \'Error loading shared library libgcc_s.so.1: No such file or directory (needed by ./lib/union-0.3.3/priv/native/libconsolidated_execution.so)\''}}

so adding apk add build-base solved that problem
trying that again I ran into
:error,
 {:bad_lib,
  'Library module name \'Elixir.Union.ConsolidatedExecution\' does not match calling module \'erl_eval\''}}

it seems from this post that you can't call nifs from the shell
so trying it again with a normal start and all boots well!
@bitwalker thanks a lot for the help!


Remove Custom Font

An initial stab at #134
If we go this way, I'm happy to continue before we merge this by adding dynamic type support to the high traffic screens etc where applicable.

This should probably be considered a WIP PR until I've done a pass for dynamic type, etc.

Would love so see some screenshots as you progress.

Closing this for now as @mattbischoff is going to take it over 👍


v6 - support season packs in data based matching by using Sonarr's grab history

Does an existing issue/feature request already exist?

[X] I've searched far and wide!

Does your feature request solve a problem you're facing?
Currently, data based matching doesn't find season packs if the season folder has been renamed.
It's "pretty normal" for Sonarr to just create a folder called "Season 2".
While it's probably possible restore a potential folder name from episode names inside and then using data based matching the same way it works on movie folders or files, I think now that Sonarr's implementation in v6 is pretty solid, this would be the way to do it.
What would you like for cross-seed to do?
Sonarr's grab history contains the original torrent, usenet grab or manual import (and where from). It contains info about grabs, renames, etc.
It should be fairly "easy" to use this info to do something like:

(temporary) hardlinks for episodes in an originally named folder
check if torrent (hash?) matches on the files and if yes inject to client
delete folder (with hardlinks) if no matches were found at all

Obviously you do know better and I'm not too familiar with cross-seed's code to tell you exactly what to do. But I think this would be somewhat of a workaround for the problem with data based matching.
Granted, this would be a new "source" for your data to begin with. You're looking at the *arrs to find the data they (and their folders) contain, rather than scanning the file system. If no history is available, I don't think there's anything to do.
What are you currently doing, if anything, to solve or work around the issue?
I sit it out and accept that some older files on my drives may never be seeded back because I can't recall where I got them.
Additional comments
https://sonarr.tv/docs/api/#/History
I do something similar to check if files are still seeding in Janitorr.

So in searching "far and wide" - did you miss the entire open PR that solves what I think you are asking for?
#695

I looked at open issues, not at open PRs.
Having a look at the PR, I see that it re-enables Season 0X folders on your file system.
Assuming that fuzzy matching will work here, it may solve what I asked.
I'm not sure the percentage of matches will be nearly as high as looking at Sonarr's history for original names.
Working from Sonarr as a starting point, or from a folder (matched to Sonarr show via path), you could:

Make an API call to get available seasons
Look for rename events in that season's history upon import
recreate (temporarily and match against that

I don't see that in the PR and this wouldn't require any web hooks to be implemented by Sonarr first.

Ignoring the not-so-great example, this is Sonarr's visual representation of their per-season history API:

Assuming you are using a halfway reasonable naming scheme for the renamed media, we recommend this from the trash-guides - you shouldn't have any issues.
If you do the above, there is no need to reconstruct the folder structure as you are describing for searching or querying any additional information from Sonarr.

I do use the TRaSH Guides naming scheme. The instance of Sonarr I had available remotely to give you that example has renaming turned off, but I do use it locally, which is what promoted this issue.
I'll keep an eye out on the PR being merged and will report back whether it catches season folders with data based matching after the merge.

I mean...that's exactly what it's designed (and tested) to do so... ;P

I figured I'd give it a shot and used the :season-folder-webhook image this morning.
Would season folders have to be registered via Sonarr webhooks for this to work at all? Or do I have to delete my cross-seed database so it doesn't skip season folders?
Because out of the box on my existing config, it unfortunately ignores season folders still.

I'd advise you to get on the Discord and message me - I've had a couple of people test this branch and they have found matches.
https://cross-seed.org has a icon in the top right or if you want to give em your IRC details I can message you there alternatively.

Tested that branch thoroughly enough. Works for me.


(PUP-8748) Configure connection verify mode when making a request

This commit makes the SSL configuration of the Puppet::Rest::Client
configurable by the caller. By default, the client is not configured to
use any certs but has VERIFY_PEER enabled, which will result in an SSL
Error if a caller tries to make a request without first properly
configuring the client. If the client is configured to use VERIFY_NONE,
the state will reset to VERIFY_PEER after the request is made.
This ensures that we will not make insecure requests by mistake.

Should this be mutable? Should it be possible to use different ssl settings on the same client?

I've heard a lot of different opinions on this along the way; Josh has gone back and forth. What are your thoughts? It would simplify things to make it immutable, I think, but in previous iterations we have moved away from immutable clients. Could be that this is the place to draw the line.

CLA signed by all contributors.

Opened #6885 to make this immutable within the client.


Confirm dependencies

Whilst playing around and testing the code I had to install a few things to see what worked.
Now I need to go back and see what was actually needed.
Here is what a ran/installed:

npm init -y
npm install express uuid
npm install base62

This was for the Java script. I have decided to remove all of this code and we now have a working proof of concept with Rust.


Line-wrapping in comments

I turn on auto-fill so that my comments wrap after a while. However, in the fstar-mode, every time auto-fill wraps into a new line, I get:
(* foo ... long line
  (* ⬚

Where ⬚ is the position of the cursor. Notice 1) the extra indentation and 2) the undesired (*.
Desired behavior: either
(* foo ... long line
 * ⬚

or
(* foo ... long line
   ⬚

Thanks,
Jonathan

I've pushed a tentative fix for this. It should be on MELPA in a few hours; let me know if it works!

Yes it does. Thanks!