symbolic backend

adding examples
alternative way of using the SymbolicBackend
complete tests for symbolic backend

Please go ahead
On Mon, 28 Sep 2020 at 04:05, Roland Kaminski<EMAIL_ADDRESS>wrote:

@rkaminsk requested changes on this pull request.

In clingox/backends.py
https://github.com/jorgefandinno/python-clingox/pull/3#discussion_r495786222
:

@@ -0,0 +1,361 @@

+'''
+This module provides a backedn wrapper to work with symbols instead of integer literals.
+'''
+from typing import Iterable, Tuple
+from itertools import chain
+from clingo import HeuristicType, Symbol, Backend, TruthValue

+# pylint: disable=line-too-long
I already put the line length limit quite high. In the file it is mostly
the comments that go beyond the limit. With my editor it is rather easy to
auto textwrap the comments. If you want to, I can do it quickly. We should
not disable it.

In clingox/backends.py
https://github.com/jorgefandinno/python-clingox/pull/3#discussion_r495786819
:

       List of program symbols forming positive part of the condition

   neg_condition : Iterable[Symbol]

       List of program symbols forming negated part of the condition

   Returns

   -------

   None

   '''

   condition = chain(self._add_symbols(pos_condition), self._add_negated_symbols(neg_condition))

   return self.backend.add_acyc_edge(node_u, node_v, condition)

TODO: can this get negative literals?

def add_assume(self, literals: Iterable[Symbol]) -> None:

   '''

   Add assumptions to the underline backend.

   :param literals: The list of symbols to assume true.

We should not switch between docstring styles. Better stick to numpy style
comments.

In clingox/backends.py
https://github.com/jorgefandinno/python-clingox/pull/3#discussion_r495787035
:

       Program atom to heuristically modify.

   type : HeuristicType

       The type of modification.

   bias : int

       A signed integer.

   priority : int

       An unsigned integer.

   pos_condition : Iterable[Symbol]

       List of program literals forming the positive part of the condition.

   neg_condition : Iterable[Symbol]

       List of program literals forming the negated part of the condition.

   Returns

   -------

   None

'''

Misplaced '''

In clingox/backends.py
https://github.com/jorgefandinno/python-clingox/pull/3#discussion_r495787732
:

   return self

def exit(self, type_, value, traceback):

   '''

   Finalize the backend.

   Notes

   -----

   Follows Python's __exit__ conventions. Does not suppress exceptions.

   '''

   return self.backend.__exit__(type_, value, traceback)

TODO: are node_u and node_v literals? do they need to be Symbols?

def add_acyc_edge(self, node_u: int, node_v: int, pos_condition: Iterable[Symbol], neg_condition: Iterable[Symbol]) -> None:

   '''

   Add an edge directive to the underline backend.

You write "underline backend" here but it should be "underlying backend".
This happens also a lot elsewhere.

In clingox/backends.py
https://github.com/jorgefandinno/python-clingox/pull/3#discussion_r495788072
:

   node_u : int

       The start node represented as an unsigned integer.

   node_v : int

       The end node represented as an unsigned integer.

   pos_condition : Iterable[Symbol]

       List of program symbols forming positive part of the condition

   neg_condition : Iterable[Symbol]

       List of program symbols forming negated part of the condition

   Returns

   -------

   None

   '''

   condition = chain(self._add_symbols(pos_condition), self._add_negated_symbols(neg_condition))

   return self.backend.add_acyc_edge(node_u, node_v, condition)

TODO: can this get negative literals?

Yes. Positive literals are assumed true and negative literals false.

In clingox/backends.py
https://github.com/jorgefandinno/python-clingox/pull/3#discussion_r495788805
:

   '''

   Add a project statement to the underline backend.

   Parameters

   ----------

   atoms : Iterable[Symbol]

       List of program symbols to project on.

   Returns

   -------

   None

   '''

   atoms = (self._add_symbols(symbols))

   return self.backend.add_project(atoms)

TODO: can the head also have negative literals?

No, all literals have to be positive.

In clingox/backends.py
https://github.com/jorgefandinno/python-clingox/pull/3#discussion_r495789568
:

   If the given symbol does not exist in the atom base, it is added first. Such

   atoms will be used in subequents calls to ground for instantiation.

   Parameters

   ----------

   symbols : Iterable[Tuple[Symbol,int]]

       The symbols associated with the atoms.

   Returns

   -------

   Iterable[Tuple[int,int]]

       The pairs representing the weighted atoms.

   '''

   return ((self.backend.add_atom(symbol), w) for (symbol, w) in weighted_symbols)

def _add_negated_symbols_weights(self, weighted_symbols: Iterable[Tuple[Symbol, int]]):

I would solve such things with a flag and just have one function to keep
the code compact. Also you should spell check your docstrings.

In clingox/backends.py
https://github.com/jorgefandinno/python-clingox/pull/3#discussion_r495792172
:

   If the given symbol does not exist in the atom base, it is added first. Such

   atoms will be used in subequents calls to ground for instantiation.

   Parameters

   ----------

   symbols : Iterable[Symbol]

       The symbols associated with the atoms.

   Returns

   -------

   Iterable[int]

       The program atoms representing the atoms.

   '''

   return (self.backend.add_atom(symbol) for symbol in symbols)

def _add_negated_symbols(self, symbols: Iterable[Symbol]):

I would combine with the previous function to keep the code compact. _add_symbols(self,
sign: bool, symbols: Iterable[Symbol]) should do.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jorgefandinno/python-clingox/pull/3#pullrequestreview-497311600,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADF3ZUSCEWPVTDH5MH5GI3LSIBGVDANCNFSM4R33IVOA
.


Execution Order attributes

This PR adds the ExecuteAfter and ExecuteBefore attributes, as well as a solver which applies these attributes to Unity's Script Execution Order.  This solver is invoked automatically upon each script reload, and so there should be no effort on the developers side (apart from adding the attribute to a class).
The ExecuteAfter attribute enforces that the tagged behavior executes after another behavior.  This affects the order in which many unity callbacks, such as Awake / Start / Update / LateUpdate are called during each frame.  The ExecuteBefore attribute works in the same way.
@RandomOutput
@GabrielHare
@yuwilbur
Testing is a bit annoying, as it requires the manual creation of new scripts and placing attributes onto them to inspect the behavior.
For each case verify that the ScriptExecutionOrder tab shows an order that satisfies the attributes.
Valid orderings

[ ] Script1 executes before Script2
[ ] Script1 executes after Script2
[ ] Script1 executes before Script2 executes before Script3 executes before Script4
[ ] Script1 executes after Script2 executes after Script3 executes after Script4
[ ] Script1 executes before Script2.  Script3 executes after Script4.  Script4 executes before Script1.

Invalid orderings.  Verify that an error dialog pops up and it reports the correct cycle.

[ ] Script1 executes before Script1
[ ] Script1 executes before Script2 executes before Script1
[ ] Script1 executes before Script2.  Script1 executes after Script2.
[ ] Script1 executes after Script2 executes after Script3 executes after Script4 executes after Script1.

NOTE: I have not deleted EnableUpdateOrdering nor have I used the Execute attributes on any existing class.  I think that should be done in a later PR.

This looks great! If I have a chance I’ll merge this and then start clearing out the EnableUpdateOrdering use.

On 14 Aug, 2015, at 11:11 AM, Amarcolina<EMAIL_ADDRESS>wrote:
This PR adds the ExecuteAfter and ExecuteBefore attributes, as well as a solver which applies these attributes to Unity's Script Execution Order. This solver is invoked automatically upon each script reload, and so there should be no effort on the developers side (apart from adding the attribute to a class).
The ExecuteAfter attribute enforces that the tagged behavior executes after another behavior. This affects the order in which many unity callbacks, such as Awake / Start / Update / LateUpdate are called during each frame. The ExecuteBefore attribute works in the same way.
@RandomOutput https://github.com/RandomOutput
@GabrielHare https://github.com/GabrielHare
@yuwilbur https://github.com/yuwilbur
Testing is a bit annoying, as it requires the manual creation of new scripts and placing attributes onto them to inspect the behavior.
For each case verify that the ScriptExecutionOrder tab shows an order that satisfies the attributes.
Valid orderings
Script1 executes before Script2
Script1 executes after Script2
Script1 executes before Script2 executes before Script3 executes before Script4
Script1 executes after Script2 executes after Script3 executes after Script4
Script1 executes before Script2. Script3 executes after Script4. Script4 executes before Script1.
Invalid orderings. Verify that an error dialog pops up and it reports the correct cycle.
Script1 executes before Script1
Script1 executes before Script2 executes before Script1
Script1 executes before Script2. Script1 executes after Script2.
Script1 executes after Script2 executes after Script3 executes after Script4 executes after Script1.
NOTE: I have not deleted EnableUpdateOrdering nor have I used the Execute attributes on any existing class. I think that should be done in a later PR.
You can view, comment on, or merge this pull request online at:
https://github.com/leapmotion-examples/LeapMotionCoreAssets/pull/119 https://github.com/leapmotion-examples/LeapMotionCoreAssets/pull/119
Commit Summary
Importing execution order util from home
Cleaned up some commends on the Node class
Added additional comments
Improved the cycle error message
Added large doc at the top, added Editor defines
Added logic for the event system
Improved cycle reporting
File Changes
A Assets/LeapMotion/Scripts/Utils/ExecutionOrder.cs https://github.com/leapmotion-examples/LeapMotionCoreAssets/pull/119/files#diff-0 (552)
A Assets/LeapMotion/Scripts/Utils/ExecutionOrder.cs.meta https://github.com/leapmotion-examples/LeapMotionCoreAssets/pull/119/files#diff-1 (12)
Patch Links:
https://github.com/leapmotion-examples/LeapMotionCoreAssets/pull/119.patch https://github.com/leapmotion-examples/LeapMotionCoreAssets/pull/119.patch
https://github.com/leapmotion-examples/LeapMotionCoreAssets/pull/119.diff https://github.com/leapmotion-examples/LeapMotionCoreAssets/pull/119.diff
—
Reply to this email directly or view it on GitHub https://github.com/leapmotion-examples/LeapMotionCoreAssets/pull/119.

Coped branch locally, and will begin testing...

Execute before self is caught.
Execute after self is caught.

Adding a node with inconsistent order relative to a valid order is caught. Example:
A before B
B after A
then add C with C before A and C after B

Multi-stage loop was caught. However, the error message did not describe the loop....

Found another issue, it is actually not possible to set the execution order of built-in behaviours such as UnityEngine.UI.Button, but this method will occasionally (depending on requirements) try to change their execution index, resulting in a warning and no effect.  Working on a fix right now.

The script has been updated, there were two issues that existed:

You cannot change the execution index of built-in behaviors.  The script occasionally tried to do so to satisfy orderings.
Not all built-in behaviors can be found using the MonoImporter.  Trying to execute relative to these behaviors caused an error.

The following changes have been made:

Nodes have been refactored to have a single enum type instead of 3 booleans.  They can be ordered, unordered, anchored, or locked.  All built-in behaviors now belong to locked nodes, and their execution index cannot be changed.
Added ExecuteAfterDefault and ExecuteBeforeDefault attributes.  These came for free once locked nodes were created.
You can now execute before or after behaviors that are not found in the monoimporter.  When you execute before or after a built-in behavior that is not found, it is the same as using ExecuteAfterDefault or ExecuteBeforeDefault.
Cycle detection has been fixed.  The findCycle method now only reports actual cycles, not tail+cycle structures.
Cycle reporting has been touched up so that if you cause a cycle with the default node, it shows up as [Default] instead of a giant string of hundreds of characters.
constructRelativeNodes has been refactored to remove code duplication.

Really good changes. There is just one more issue that I found. To reproduce it update to the force-pushed head of test-execution-order-attributes and open the TESTExecutionOrder.unity scene.
(1) Apply the execution ordering.
(2) Play, and examine the "Call Order" fields of the TextNode objects to see that the call ordering is correct.
(3) Open the "Script Execution Ordering" panel and break the ordering. (There is only one acceptable ordering - try moving BridgeFrom12To21 above Side1Node2) then run.
(4) You will get a message stating "Unapplied Execution Order" and can choose "Revert" or "Accept".
(5) If you choose "Revert" everything works.
(6) If you choose "Accept" then there will be warnings about a missing behavior and the call ordering can be seen to be incorrect. My guess is that an attempt to resolve the call ordering has hung.

I do not see any warnings following the same steps.  After pressing 'Accept' the scene begins as normal, and a recompile occurs to apply the execution order.  Once the recompile finishes, the ExecutionOrder callback is triggered and I see the second recompile, after which I see the execution order become correct in the execution order window.
I do notice that the call-order for all of the nodes is set to zero, but I think that has more to do with a recompile happening during play mode, triggering a hot-reload.  The hot-reload fails to serialize the isCalled delegate, so all of the nodes have their onUpdate set to null, resulting in the callOrder to be set to zero on the next Update cycle.
What I did was simply have each OrderedNode Debug.Log(this) in the Update method.  Then I pressed the collapse button on the console.  The order in which the logs are output is the same as the order they are executed, so it makes for a nice and easy way to verify the callback order.  (You just have to clear the console every time you want to check).  Using this method, I verified that after the second recompile finished, the scripts executed in the correct order.


How to add an obstacle?

Hi experts here
Super love this. I want the liquid to avoid an obstacle, let's a rectangle at certain x and y. Any hints how can it be done?

same for me, look at this one https://sandspiel.club/ and it has that but i dont know how to do that.

您好，我已经收到你的信件！我会及时阅读并作出回应！


What is "options"?

Hello! What should I insert in object "options" from second part of guide "Payments from bank cards without authorization"?
Here:

var options = {
    // pattern_id, etc..
};

externalPayment.request(options, function requestComplete(err, data) {
    if(err) {
        // process error
    }
    var requestId = data.request_id;
});```

It`s not explained.. Which pattern_id?

@Khuzha Hi, full list of "options" you can see on this page https://tech.yandex.com/money/doc/dg/concepts/protocol-rights-docpage/


TypeError: Cannot read property 'clients' of undefined - 5.4.0

Hi,
Today, a socket.io server (2.3.0) which is using this Redis adapter (5.4.0), crashed unexpectedly with the following error and stacktrace:
TypeError: Cannot read property 'clients' of undefined
    at Timeout._onTimeout (/opt/app/node_modules/socket.io-redis/index.js:485:133)
    at listOnTimeout (node:internal/timers:555:17)
    at processTimers (node:internal/timers:498:7)

From what I've been able to see, the timeout around that line (485) was triggered and the retrieved request did not exist (I guess because it was removed somewhere else from the array), causing the above crash.
Thank you.

Closed due to inactivity, please reopen if needed.


Add new RSpec/EmptyHooks cop

Closes #811

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Updated documentation.
[x] Added an entry to the changelog if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

[x] Added the new cop to config/default.yml.
[x] The cop documents examples of good and bad code.
[x] The tests assert both that bad code is reported and that good code is not reported.

Ping

@pirj Fixed. Please review.

@pirj Changes done.

You can add autocorrect that removes the offending node

Do you want to give it a shot, @tejasbubane? Otherwise let’s open a new issue so we don’t forget to implement it.

@bquorning Added autocorrect.

I’d like a second review from @pirj or @Darhazer before merging.

@pirj Added spec for semicolon - it is a little ugly though - since it does not remove the semicolon.

Added spec for semicolon - it is a little ugly though - since it does not remove the semicolon.

No worries, it's less ugly than before {}; after { delete_users } 😄


ClusterSecret doesn't create secret across all namespaces

Documentation says that
"You can specify multiple matching or non-matching RegExp. By default it will match all, same as defining matchNamespace = *"
I'm using the following ClusterSecret manifest to create secret in all namespaces
`kind: ClusterSecret
apiVersion: clustersecret.io/v1
metadata:
name: regcred-secret
avoidNamespaces:

default
data:

`
kubectl -n test apply -f clustersecret.yaml

and pod throws the error
Handler 'create_fn' failed with an exception
Full error here
https://pastebin.com/SeEFsUUe

Hi, I can confirm that this is not a valid regex, and the operator uses a wrong default value (and no validation whatsoever). As a work-around I'd suggest using .* (dot-star) value to match all namespaces.

fixed by #88


Responsive problems Chrome vs Firefox low resolutions

I'am testing new version js-es6 and on low resolutions, the design is not the same, and I can't see where the problem is.
The first one is on Firefox and it's ok, and the second it's on chrome.

It's in the border-radius properties. The style is the same but when it gets resized, the border radius appears to be more cirlce-ish because the number containers are smaller. You could change or get rid of the border-radius on the following classes altogether or comment out the properties in the original css file. Below are the classes I changed to make the number containers have regular 90 degree corners again.
.flip-clock .flip-clock-group .flip-clock-list .flip-clock-list-item-inner .top {           /*border-radius: .75rem .75rem 0 0;*/           line-height: 1.33333; }           .flip-clock .flip-clock-group .flip-clock-list .flip-clock-list-item-inner .top:after {             /*border-radius: .75rem .75rem 0 0;*/ }           .flip-clock .flip-clock-group .flip-clock-list .flip-clock-list-item-inner .top:before {             background: #333;             opacity: .4;             bottom: 0; }         .flip-clock .flip-clock-group .flip-clock-list .flip-clock-list-item-inner .bottom {           /*border-radius: 0 0 .75rem .75rem;*/           line-height: 0; }           .flip-clock .flip-clock-group .flip-clock-list .flip-clock-list-item-inner .bottom:after {             /*border-radius: 0 0 .75rem .75rem;*/ }

It would probably be better to change those to em values versus rem values so that they scale correctly.

@brianespinosa I didn't change those units btw. It is in the source.

@tbone849 yes, I am aware. I am the one who committed those styles about 8 years ago. ;)
This was more just a helpful comment if someone wants to keep the rounded corners and have them scale properly. The styles probably need to be updated in the project itself... but I suspect this project has become dormant.


RaCoCo fails when tests passed

Hi!
I am not sure if this a RaCoCo issue, however - http://sparrowhub.io:2222/report/37
HTH
Aleksei

Hello. Thank you for your interest in RaCoCo.
As I see the log, there is a warning from prove6 about t/03-warn.t. This means that prove6 returned nonzero exit code and RaCoCo failed too, accordingly.
In general, such warnings are if a test file uses subtests with output to STDOUT. It is known issue (https://github.com/Raku/tap-harness6/issues/33) and they decided that it is a feature.
But in our situation with Timezones::ZoneInfo, it is because some module's output mess with TAP specific output. Anyway, prove6 returns a nonzero exit code. On the other way, prove t --exec "raku -Ilib" work like a charm with this TAP output.
@melezhik what do you think, is it an issue?

@atroxaper  thanks for explanation, looks like this is Timezones::ZoneInfo issue, not RaCoCo, that's ok.
I am using RaCoCo as a part of SparkyCI. This is great tool, thanks!

@melezhik Thank you!

In general, such warnings are if a test file uses subtests with output to STDOUT. It is known issue (https://github.com/Raku/tap-harness6/issues/33) and they decided that it is a feature.

If you don't want this behavior, you can always pass --loose to prove6.

@Leont Thank you! I didn’t see the option in the readme. And don’t see now too :)


KOGITO-7491: Setting SVG commands ID as optional at Editor creation

JIRA: https://issues.redhat.com/browse/KOGITO-7491
Currently startExtension requires SVG commands ID. These are useful in case the editor supports SVG creation. yard doesn't require it, so I put these as optional parameters.

@yesamer I believe we could apply the same changes for the PMML Editor extension, as it also doesn't have SVG generation.


Add notifications when changing privacy preferences

fixes #3253

I'm thinking of combining the anonymous.json and privacy.json endpoints into one. They aren't mentioned anywhere in our API documentation, so I guess this shouldn't be a problem?

I'm thinking of combining the anonymous.json and privacy.json endpoints into one.

Seems like a good refactoring to me, go for it.


Add a simple gui for testing or control

Is the motion commands working for you? I was able to duplicate this and get centering working, but setting rotation has the gimbal in an oscillation loop.

Thanks @TianmingLi for your PR.
Sorry for the late reply as I have been extremely busy.
Although, I am not able to test your GUI as I don't have an SIYI camera for now, I will merge as it's a nice feature, and can be enhanced further.
Thank you.


Macro to resolve type of field

A macro that expands into the type of a field in a struct.
struct Foo {
    bar: Bar,
}

fn make_foo(bar: field_type!(Foo, bar)) -> Foo {
    Foo { bar }
}

I thought this is a common use case for macro libraries, but I can't find any RFCs that have discussed on this.

this sounds like typeof.
and if you are a #[derive]-macro author, you already know the Bar type from the input tokens

this sounds like typeof.
and if you are a #[derive]-macro author, you already know the Bar type from the input tokens

I'm referring to accessing it from another macro expansion.


Function Mocks

This issue facilitates discussions about builtin function mocks design. First of all, we believe that using mocks is so common that making them part of the library is a sane thing to do.
Sinon’s Spy
const spy = sinon.spy(() => 5)

// and for asserts with chai-sinon:
expect(mySpy).to.have.been.calledWith("foo");

What I don’t like about this design is that it doesn’t have support for easy creation of a spy that returns different values for different calls.
Another thing is that I always felt like there is way too many sinon-spy matchers but some really useful were missing.
Jest’s fn.mock()
const mock = jest.fn(x => 42 + x)
expect(mockFunc).toHaveBeenCalledWith(arg1, arg2);

What I like about its design:

clear design of .mock property exposing all the details - makes it possible to write custom expectations by hand,
Simple helpers to mock different values for different calls:mock.mockReturnValueOnce(‘x’)

Proposed design
In my experience, I quite often want to return different values for different calls, thus something like Jest’s mock.mockReturnValueOnce  (internal queue of returned values) is a must. But this leads us to this weird state where we define returned values in one place but write expectations in a totally another. What if we combined it to something like this:
import {mockFn} from "earl"

const getSizeMock = mockFn([{inputs: [expect.a(Fs), "/path/file.txt"], out: 217}])

This mock expects to be called exactly once with a object of type Fs and string /path/file.txt and returns 217.
There are at least few cool things about this:

can throw expectations as soon as unexpected call happens,
inputs is just an array of args so one can use all matchers that would work with beEqual (arrayContaining if you don't care about details, or anything if you really don't care ;d). This API design is just an example, we could utilize helpers like mockReturnValueOnce etc but I wanted to present here that I believe that expectations on a mock can be defined as a part of a mock.

Furthermore, it should be possible to do something like expect(mock).toBeExhusted() to verify if a mock's internal queue of values to return is empty. So there is no need for something like expect(mock).toHaveBeenCalledTimes(5).
I imagine that this could be even further simplified with optional integration with test runner (this needs another proposal) which would ensure all mocks created in a testcase are exhausted after each test run.
There is only one thing that I don't like about this idea - implementing autofix (for inputs) will be challenging as expectations are defined first and execution happens later.
To clarify, this could be preferred way of using mocks but for sure there are cases where more traditional interface like:
const mock = jest.fn(x => 42 + x)
expect(mockFunc).toHaveBeenCalledTimes(3);

is needed and thus should be supported as well.
Thoughts?

How about a system of overrides that allows you to modify things at a later date?
const callMeMaybe = mockFn().returns(3)
expect(callMeMaybe()).toEqual(3)

callMeMaybe.throwsOnce(new Error('booyah'))
expect(() => callMeMaybe()).toThrow('booyah')
expect(callMeMaybe()).toEqual(3)

callMeMaybe
  .given(1, 3).returns(4)
  .given(2, 4).returns(6)

expect(callMeMaybe()).toEqual(3)
expect(callMeMaybe(1, 3)).toEqual(4)
expect(callMeMaybe(2, 4)).toEqual(6)

callMeMaybe.reset().returns(5)

expect(callMeMaybe()).toEqual(5)

specifying mock results/expects/etc
:point_up: I very much like the above idea to have a compact way to (1) mock the returned value/error, (2) define the expected call arguments, (3) check the number/arguments of calls, (4) reset/restore the mock at the end of the test. In jest, these 4 things have to be done manually, which leads to loads of boilerplate, or writing complicated helper utils that encapsulate them.
The mock.given(...).returns(...) syntax looks cool, especially if there was a stackable sequential variant, ie. the mock should first be once called with 1, 3 and return 2, then once with 2, 4 and return 6 -- this should also fail if it was not called enough times. Example idea:
// regular variant
callMeMaybe.calledWith(2).returns(1);
// variant that after the test verifies it indeed was called with the expected args (and/or expected number of times)
callMeMaybe.expectCalledWith(2).returnsOnce(1);

creating mocks
Explicit const mock = jest.fn is only one of the multiple ways to create a mock function. I also extensively use const spy = jest.spyOn(serviceInstance, 'someMethod').
Side wild idea: when using a mock that's a spy of an actual function, it would be nice to have a way to call or wrap the original function.
Another wild idea for creating mocks is mocking whole class instances:
const mockSvc = mockInstance(RickRollerService);
// or
const mockSvc = mockInstance(new RickRollerService(...someParams));

// mock a single method
mockSvc.rick.given(1).returnsOnce('pickle')
// or even use matchers in expected args?
mockSvc.roll.given(expect.stringMatching('xyz')).callsOriginal()
// unmocked methods should probably fail the test with a precise message like
// 'unexpected unmocked call to Xxx:yyy <stacktrace>'
// (note "fail the test", not "throw an error", since that could be caught by the tested code)

I like given syntax. But just to clarify, @sz-piotr, in your example above:

callMeMaybe
  .given(1, 3).returns(4)
  .given(2, 4).returns(6)

expect(callMeMaybe(2, 4)).toEqual(6)

throws, right?
Ie. given doesn't do "matching of arguments" but simply expects a call with given args.

The mock.given(...).returns(...) syntax looks cool, especially if there was a stackable sequential variant, ie. the mock should first be once called with 1, 3 and return 2, then once with 2, 4 and return 6 -- this should also fail if it was not called enough times. Example idea:

As mentioned in the first post. I believe mocks should have isExhausted() (or verify) method which checks if internal queues of inputs and outputs are empty. It's hard for me to understand why I would want to create mock that is not entirely "used" during a test, thus I don't see a valid reason for expectCalledWith that you mentioned. I am not sure if I understood your example.
@quezak what you mentioned in creating mocks section are great points but I think they belong to a different issue - this one is about function mocks. Wanna scribble something? ;) I was also thinking about how class mocks should look like.

@krzkaczor

in your example above [...] throws, right?

This example does not throw. My understanding of a mock is: a function which calls you can inspect and does not require an implementation.
The reason for the given syntax is to provide an ability to override the return value given some arguments. The real life example would be something like this. You have a class that needs to process employees. This class receives a function that returns salaries for those employees. Instead of passing the real calculation function you pass the mock that returns predefined values.

It's hard for me to understand why I would want to create mock that is not entirely "used" during a test

Sometimes you create a mock not to spy on it but to mock some part of the system. The simple mockFn().returns(3) can never be exhausted, since it has no internal queue.

Sometimes you create a mock not to spy on it but to mock some part of the system. The simple mockFn().returns(3) can never be exhausted, since it has no internal queue.

I agree, it's also sometimes useful. But I think we certainly should have a variant that automatically expects the calls to be exhausted directly in the mock given/return declaration. I find it very annoying if I have a dozen mocks and have to manually verify them all -- that's why I proposed to have two ways to declare mock returns.
@sz-piotr your case with two simultaneous non-exhaustive given options could be rewritten with .mockImplementation and a trivial switch-case-return, so it it worth to have a special syntax for that?

This example does not throw. My understanding of a mock is: a function which calls you can inspect and does not require an implementation.

Okay, I get it, small suggestion: next time you can add some text commentary to your code example to make it clear, especially that you ignored what I proposed in the previous post 😆

@sz-piotr your case with two simultaneous non-exhaustive given options could be rewritten with .mockImplementation and a trivial switch-case-return, so it it worth to have a special syntax for that?

Isn't mockImplementation jest's thing to override mock created by another module? I think that with what we have discussed now here the better parallel would be a mockFn with custom function with switch-case-return, right? Anyway, I think there is still a value in a possiblity to define this case in a more declarative way but I am not sure if this is a right syntax.
To facilitate a little bit our discussion:

We have mockFn with nice API to define internal return queues WITH possible overrides using given. Exactly what @sz-piotr wrote in it's the original post with code sample.

Features:

"infinite" returns using .returns(x)
return value queues with returnOnce(x)
support for throw values with throw/throwOnce
override return for specific args given(args).returnOnce(x)
isExhausted check
ability to define mockFn using function: mockFn(() => 5)

My opinion: it's good and needed, it's basically an evolution of what jest provides. I am just worried that MAYBE "infinite" mocks should be separate from "well defined" mocks.

I mentioned that I feel like it's often useful to have "stricter" mocks which would expect calls and throw if something expected is called. This is what I believe what @quezak refers to as well (suggesting expectCalledWith).

Maybe it should be a separate type of mock like strictMockFn?
I can write a proposal combining all of these ideas so we can talk it through. My gut feeling is that these should be separate kind of mocks rather than one mock with shit load of methods because you wouldn't use them all at once.

Isn't mockImplementation jest's thing to override mock created by another module?

No, it's used to use a more complex function for the mock than a simple return x. One of the primary use cases is the one I mentioned, ie. fn.mockImplementation(arg => arg > 4 ? 2 : 0).

fn.mockImplementation(arg => arg > 4 ? 2 : 0).

@quezak how is this different from
jest.fn((arg => arg > 4 ? 2 : 0)

@quezak how is this different from jest.fn((arg => arg > 4 ? 2 : 0)

You can't use this with spies / mocks constructed in other ways than a literal fn declaration (e.g. jest.spyOn(someSvc, 'someMethod').mockImplementation(...). Also, it could be useful to have a way to change the mock fn implementation at some point.

Yesterday I dove into various mocking frameworks outside JS to steal some good ideas. I even visited PHP land - but I couldn't find any good patterns there 😆
Good news is that it turns out that I didn't invent the concept of strict/loose mocks 😆
Here's what I propose:

strictMocks (preferred) - functions with a sequence of expected calls and return values specified UPFRONT. They will throw on unexpected calls. They should be always verified by the end of the test (can be done automatically by integration with test runner TBD).

mocks (or looseMocks) - functions with dummy implementation/return value, that you can call as many times as you want. They have nice API to override return values for given args. At the end of the test can be verified by set of custom matchers.

(2) is much more similar to what sinon.spy / jest provides but I feel like (1) is be more useful IRL (at least this is how I often use mocks). I also propose to implement (1) in the first place.

@all-contributors please add @sz-piotr for code


Error ToElementPropertyNotFound: double-click-delay

I have a list displayed with a custom theme and when I double-click on an item in the list, I have a ToElementPropertyNotFound error: double-click-delay.
I have the impression that the handler is looking for the token called #'double-click-delay', which must be in the BeeTheme by default, but that I do not have in my theme.

just adding the missing token in your theme in not working ?

It works :) I forgot to close the ticket


Feature Request - List what is boosting what

When you get to the later stages, it's hard to see what is being boosted by what.
I have gotten to Elementaries, but it's hard to know what to set my Fermions too, to get the most out of them. It'd be helpful to see something along the lines of
You have e896 K rockets (+e896 K/sec) ...
Boosted by:
Inf x;x - 3x
Inf x;x - e^12
Fermions - e^x
Achievements - x
etc.
Might be a better way of doing that?
The real issue is I'm not always sure what's holding me back the most in getting more EP, knowledge gain? cadavers? etc.

I would like to agree but there a few things that would make this change a little... difficult, such as the following:
1. Where would this system be displayed?
2. I would need to add this for every single upgrade, achievement, and feature in the game
3. I don't think doing all of that is worth the visual help.
As for the whole EP thing, I would need to know more about your situation.
If you would like more help in that regard, come ask in Distance Incremental's Discord server (link is at the bottom of the options menu in-game).

Yea, I realize this would be incredibly difficult.  Haven't played Antimatter in a year or more.
As for EP, I figured that out - just wait a lot longer between resets. Now I have the issue of not enough distance, though I'm pretty close to unlocking theory.
You can just close this issue, and I'll check out the discord!

Alrighty, thanks for letting me know!


how to add one footer row static

how to add one footer row static for fill in the total number of column contents like total price, total sum,
thx

It is not possible yet, but I will surely add functionality to do it because it is a fantastic feature. Thanks

thx for your replay

Done :)


DPWA status update

Whoops!
There were 1 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/updates/2018/05/dpwa.md#L30 - Line must be at most 100 characters


YARN-11226. [Federation] Add createNewReservation, submitReservation, updateReservation, deleteReservation REST APIs for Router.

JIRA: YARN-11226. [Federation] Add createNewReservation, submitReservation, updateReservation, deleteReservation REST APIs for Router.
In PR (#4892), we completed the four methods createNewReservation, submitReservation, updateReservation, deleteReservation, In this PR, we improved the code to use FederationActionRetry. After improvement, the code is more readable.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 22s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 20s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
29m 16s

trunk passed

+1 :green_heart:
compile
4m 22s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
3m 35s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 28s

trunk passed

+1 :green_heart:
mvnsite
1m 28s

trunk passed

+1 :green_heart:
javadoc
1m 28s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 13s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 39s

trunk passed

+1 :green_heart:
shadedclient
23m 34s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m  6s

the patch passed

+1 :green_heart:
compile
4m  6s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
4m  6s

the patch passed

+1 :green_heart:
compile
3m 26s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
3m 26s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 13s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 2 new + 11 unchanged - 0 fixed = 13 total (was 11)

+1 :green_heart:
mvnsite
1m 10s

the patch passed

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 33s

the patch passed

+1 :green_heart:
shadedclient
23m 27s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m 11s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
0m 36s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

132m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5175

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux eb8874a24f4e 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / af6214577dc1f062b2b1233365a744541917ace6

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/1/testReport/

Max. process+thread count
532 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 28s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 39s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
29m 42s

trunk passed

+1 :green_heart:
compile
4m 23s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
3m 33s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 28s

trunk passed

+1 :green_heart:
mvnsite
1m 34s

trunk passed

+1 :green_heart:
javadoc
1m 30s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 12s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 42s

trunk passed

+1 :green_heart:
shadedclient
23m 45s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m  3s

the patch passed

+1 :green_heart:
compile
4m  4s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
4m  4s

the patch passed

+1 :green_heart:
compile
3m 24s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
3m 24s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 15s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 0 new + 10 unchanged - 1 fixed = 10 total (was 11)

+1 :green_heart:
mvnsite
1m  9s

the patch passed

+1 :green_heart:
javadoc
0m 59s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 31s

the patch passed

+1 :green_heart:
shadedclient
23m 33s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m 12s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
0m 35s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

133m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5175

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 5a4f1b933a87 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9da4655b86ee6ba7deb97b51fac5e4db0d089ed5

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/2/testReport/

Max. process+thread count
535 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 22s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 27s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
30m 43s

trunk passed

+1 :green_heart:
compile
5m  9s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
3m 36s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 32s

trunk passed

+1 :green_heart:
mvnsite
1m 46s

trunk passed

+1 :green_heart:
javadoc
1m 35s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 17s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m  1s

trunk passed

+1 :green_heart:
shadedclient
24m 16s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m  8s

the patch passed

+1 :green_heart:
compile
4m 35s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
4m 35s

the patch passed

+1 :green_heart:
compile
3m 41s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
3m 41s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 17s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 1 new + 10 unchanged - 1 fixed = 11 total (was 11)

+1 :green_heart:
mvnsite
1m 10s

the patch passed

-1 :x:
javadoc
0m 27s
/results-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt
hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5)

-1 :x:
javadoc
0m 24s
/results-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt
hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5)

+1 :green_heart:
spotbugs
2m 34s

the patch passed

+1 :green_heart:
shadedclient
23m 23s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m 13s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
0m 35s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

138m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5175

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 9fe6f5f9adeb 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4effa2c391e428f181cd9d11e0f76bb5b416b80f

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/4/testReport/

Max. process+thread count
602 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri Can you help review this PR? Thank you very much!

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m  6s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 41s

trunk passed

+1 :green_heart:
compile
4m  5s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
3m 22s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 16s

trunk passed

+1 :green_heart:
mvnsite
1m 11s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 55s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 22s

trunk passed

+1 :green_heart:
shadedclient
23m  9s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
23m 27s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
0m 55s

the patch passed

+1 :green_heart:
compile
4m  0s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
4m  0s

the patch passed

+1 :green_heart:
compile
3m 15s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
3m 15s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
checkstyle
1m  6s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 0 new + 10 unchanged - 1 fixed = 10 total (was 11)

+1 :green_heart:
mvnsite
0m 57s

the patch passed

+1 :green_heart:
javadoc
0m 51s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 44s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 22s

the patch passed

+1 :green_heart:
shadedclient
23m 19s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 58s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
0m 28s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

126m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5175

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 19893b6a98d7 4.15.0-192-generic #203-Ubuntu SMP Wed Aug 10 17:40:03 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 523985f4788175f786b25ab1e0fd5d3bc2c8ccc4

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/6/testReport/

Max. process+thread count
607 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 21s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 11s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
29m 28s

trunk passed

+1 :green_heart:
compile
4m 22s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
3m 39s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 30s

trunk passed

+1 :green_heart:
mvnsite
1m 37s

trunk passed

+1 :green_heart:
javadoc
1m 37s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 22s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 49s

trunk passed

+1 :green_heart:
shadedclient
24m 10s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
24m 33s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m  9s

the patch passed

+1 :green_heart:
compile
4m 17s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
4m 17s

the patch passed

+1 :green_heart:
compile
3m 25s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
3m 25s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 15s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 0 new + 10 unchanged - 1 fixed = 10 total (was 11)

+1 :green_heart:
mvnsite
1m 13s

the patch passed

+1 :green_heart:
javadoc
1m  5s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  1s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 35s

the patch passed

+1 :green_heart:
shadedclient
24m  0s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m 16s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
0m 40s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 44s

The patch does not generate ASF License warnings.

134m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5175

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 41fce937be11 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 083010d22fbf31057247aece0bae5a9b7e4e117a

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/7/testReport/

Max. process+thread count
552 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri Can you help review this PR? Thank you very much!
In PR (https://github.com/apache/hadoop/pull/4892), we completed the four methods createNewReservation, submitReservation, updateReservation, deleteReservation, In this PR, we improved the code to use FederationActionRetry. After improvement, the code is more readable.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m  3s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 57s

trunk passed

+1 :green_heart:
compile
4m  6s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
3m 17s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 14s

trunk passed

+1 :green_heart:
mvnsite
1m  9s

trunk passed

+1 :green_heart:
javadoc
1m  6s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 52s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 18s

trunk passed

+1 :green_heart:
shadedclient
22m 48s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
23m  5s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
0m 54s

the patch passed

+1 :green_heart:
compile
3m 58s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
3m 58s

the patch passed

+1 :green_heart:
compile
3m 13s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
3m 13s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  6s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 0 new + 10 unchanged - 1 fixed = 10 total (was 11)

+1 :green_heart:
mvnsite
0m 59s

the patch passed

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 44s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 19s

the patch passed

+1 :green_heart:
shadedclient
22m 57s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 56s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
0m 27s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

125m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5175

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 2c32bb0ba967 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ba31b8569eabbe9c125f8194b1fa3ecae08d4af6

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/8/testReport/

Max. process+thread count
594 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri Can you help to review this PR again? Thank you very much!

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  2s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 24s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 42s

trunk passed

+1 :green_heart:
compile
4m  7s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
3m 18s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 15s

trunk passed

+1 :green_heart:
mvnsite
1m 10s

trunk passed

+1 :green_heart:
javadoc
1m  7s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 53s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 19s

trunk passed

+1 :green_heart:
shadedclient
22m 58s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
23m 14s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
0m 55s

the patch passed

+1 :green_heart:
compile
4m  1s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
4m  1s

the patch passed

+1 :green_heart:
compile
3m 14s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
3m 14s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  6s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 0 new + 10 unchanged - 1 fixed = 10 total (was 11)

+1 :green_heart:
mvnsite
0m 59s

the patch passed

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 45s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 22s

the patch passed

+1 :green_heart:
shadedclient
22m 46s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 56s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
0m 27s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

125m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5175

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 57c65c41f4aa 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a46673c9d03bde999732d6f340ea28543b9f49ed

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/9/testReport/

Max. process+thread count
536 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
2m 17s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  2s

codespell was not available.

+0 :ok:
detsecrets
0m  2s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
0m 22s

Maven dependency ordering for branch

-1 :x:
mvninstall
14m  9s
/branch-mvninstall-root.txt
root in trunk failed.

-1 :x:
compile
0m 25s
/branch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-server in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
compile
8m  9s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 44s

trunk passed

+1 :green_heart:
mvnsite
1m 18s

trunk passed

+1 :green_heart:
javadoc
1m 12s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 53s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 21s

trunk passed

+1 :green_heart:
shadedclient
23m 42s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
24m  1s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
4m 53s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
0m 54s

the patch passed

+1 :green_heart:
compile
3m 57s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

-1 :x:
javac
3m 57s
/results-compile-javac-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 generated 439 new + 0 unchanged - 0 fixed = 439 total (was 0)

+1 :green_heart:
compile
3m 15s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
3m 15s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
checkstyle
1m  6s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 0 new + 10 unchanged - 1 fixed = 10 total (was 11)

+1 :green_heart:
mvnsite
0m 59s

the patch passed

+1 :green_heart:
javadoc
0m 51s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 21s

the patch passed

+1 :green_heart:
shadedclient
22m 56s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m  1s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
0m 29s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

104m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5175

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 447c582022b9 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 7915430e6f7f4db73e441f4e6959ebe5ae281c37

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/10/testReport/

Max. process+thread count
536 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/10/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  1s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 12s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 25s

trunk passed

+1 :green_heart:
compile
4m  4s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
3m 21s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 15s

trunk passed

+1 :green_heart:
mvnsite
1m 11s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 53s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 23s

trunk passed

+1 :green_heart:
shadedclient
23m 15s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
23m 31s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
0m 54s

the patch passed

+1 :green_heart:
compile
3m 57s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
3m 57s

the patch passed

+1 :green_heart:
compile
3m 14s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
3m 14s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  6s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 0 new + 10 unchanged - 1 fixed = 10 total (was 11)

+1 :green_heart:
mvnsite
1m  1s

the patch passed

+1 :green_heart:
javadoc
0m 50s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 24s

the patch passed

+1 :green_heart:
shadedclient
22m 59s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m  0s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
0m 29s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

125m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5175

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 9cb0d2238db8 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 69ac19eccacf842988634b838fa5a6ff614f885b

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/11/testReport/

Max. process+thread count
532 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/11/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 12s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  2s

codespell was not available.

+0 :ok:
detsecrets
0m  2s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m  2s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
29m 48s

trunk passed

+1 :green_heart:
compile
4m 27s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
3m 33s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 20s

trunk passed

+1 :green_heart:
mvnsite
1m 19s

trunk passed

+1 :green_heart:
javadoc
1m 14s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 59s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 43s

trunk passed

+1 :green_heart:
shadedclient
23m 35s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
23m 58s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m  4s

the patch passed

+1 :green_heart:
compile
4m 42s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
4m 42s

the patch passed

+1 :green_heart:
compile
3m 38s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
3m 38s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  7s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 0 new + 10 unchanged - 1 fixed = 10 total (was 11)

+1 :green_heart:
mvnsite
1m  4s

the patch passed

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 50s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 39s

the patch passed

+1 :green_heart:
shadedclient
24m 30s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m 19s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
0m 31s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 36s

The patch does not generate ASF License warnings.

132m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/12/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5175

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux d31b4b300c39 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d1547af63e51dffbe55e1b49b5c8fce6da64a108

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/12/testReport/

Max. process+thread count
601 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/12/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 33s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
17m 30s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
31m 46s

trunk passed

+1 :green_heart:
compile
5m  2s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
3m 57s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 21s

trunk passed

+1 :green_heart:
mvnsite
1m 23s

trunk passed

+1 :green_heart:
javadoc
1m 13s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
1m  4s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 40s

trunk passed

+1 :green_heart:
shadedclient
24m 39s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
24m 56s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
0m 57s

the patch passed

+1 :green_heart:
compile
4m 14s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
4m 14s

the patch passed

+1 :green_heart:
compile
3m 20s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
3m 20s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  6s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server: The patch generated 0 new + 10 unchanged - 1 fixed = 10 total (was 11)

+1 :green_heart:
mvnsite
1m  0s

the patch passed

+1 :green_heart:
javadoc
0m 50s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 45s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 38s

the patch passed

+1 :green_heart:
shadedclient
24m 46s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
4m 32s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
0m 29s

hadoop-yarn-server-router in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

139m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/13/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5175

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 8f31f87d39ee 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3a082c2882372ff71d6f5db6fb707fbb00f1c87f

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/13/testReport/

Max. process+thread count
599 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5175/13/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri Can you help to merge this pr into the trunk branch? Thank you very much! I will continue to follow up YARN-11225.

@goiri Thank you very much for helping to review the code!


Create patch/content/primary branch from develop branch

I have to create patch/content/primary branch from develop branch.

I have created the branch. Switching the task to "Done". Closing the issue.


Fixed buffer size checks in h264_decompress

The buffer size checks in h264_decompress were broken.
The assumption, that the decoded h264 frame must be smaller than the output buffer is wrong.
Instead check, that the desired output rectangle is a valid region in the decoded h264 frame as well as the output buffer.

+1

+1


chore: bdd-spring-1575214742 to 0.0.1

chore: Promote bdd-spring-1575214742 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[fix] mobile_size_check: absolute path

Coverage remained the same at 84.476% when pulling 80c127cfda2c2d542b1f4920208f668032535f57 on itowtips:fix-word into ee1c29968f5881da646ee08e6fbaae0a778ac24f on shirasagi:master.


2018 Edition, nalgebra support and more flexible imports

edition = "2018"
Release 0.4.0
cgmath 0.17
Added support for nalgebra Vector and Matrix types.
Made Uniform proc-macro more flexible, now an undefined glsl_layout namespace is used, allowing using e.g. reexports.

This change is

Thanks


Cannot Remove "babel-plugin-transform-es2015-modules-commonjs"

Hey - I am also having this issue - same as #9. Except it's on the egghead series. I've also tried cloning the master branch and doing npm install then npm run validate but that also gives the error

Yeah, I still need to update things with a recent breaking change with babel. For now, you can swap out babel-preset-es2015-webpack with babel-preset-es2015 with configuration like this: https://github.com/kentcdodds/es6-todomvc/compare/FEM/03.0-es6ify...FEM/04.0-tree-shaking


ReactSortable MultiDrag is not a constructor

Describe the bug

Once i install react-sortablejs node module with react app and then proceed with dependency works, I had caught with below mentioned issue
To Reproduce
Steps to reproduce the behavior:

Run npm i react-sortablejs
Run you react app with npm run start
After importing the required dependencies
See error "Uncaught TypeError: _reactSortablejs.MultiDrag is not a constructor" in your console

Expected behavior

Once i import the dependencies for react-sortablejs in a class component it should be working as expected
Information

Below i attached the code block for your reference
import section
import { ReactSortable, Sortable, MultiDrag, Swap } from "react-sortablejs";

After import dependency, but before starting class component
Sortable.mount(new MultiDrag(), new Swap());

Within render method
<ReactSortable
multiDrag // enables mutidrag
// OR
swap // enables swap
>
{qrFormat.map((item, index) => (

{item}

))}
</ReactSortable>

Versions - Look in your package.json for this information:
react = ^16.10.2
react-dom = ^16.8.5
sortablejs = ^2.0.11
Browser Information
browser = Chrome Version 81.0.4044.113 (Official Build) (64-bit) / Firefox Version 75.0 (64-bit)
Additional context
This was the first i tried using react-sortablejs and it is throwing me these type of errors
Screenshot from browser console

@sriramgroot  There's no need to post it here if you've posted it in the react repo. https://github.com/SortableJS/react-sortablejs/issues/143

@sriramgroot There's no need to post it here if you've posted it in the react repo. SortableJS/react-sortablejs#143

@waynevanson Thanks for writing it to me.


M24H-67 use a delegate state to prevent double submissions in case of timeouts

When a USSD session timeouts or aborts, the state machine picks up at
the start of the state where it left off. That may, in certain
situations mean it'll do an API call twice.
Using a delegate state prevents that from happening.

@KaitCrawford & @bruskiza ready for review.

:+1:


[Enhancement] Please add support for older iOS and 32-bit devices

Would it be possible to add support for e.g. iOS 7 and iPhone 4S to Ultrasound? I'd love to use a better volume HUD, but afaik there are no tweaks like this that support older devices.

Due to the APIs currently required by Ultrasound, this is not an enhancement request that is deemed in scope for the project. I appreciate your request, but unfortunately it would permanently slow progress on the tweak for newer versions. While others are free to create forks doing so, they won't be merged upstream due to the negative effect they would have on the source.


Hosts file resolve failed

I can't find C:\windows\system32\drivers\etc\hosts file on my system

This is what I found in my hosts file
This is a sample HOSTS file used by Microsoft TCP/IP for Windows.

This file contains the mappings of IP addresses to host names. Each
entry should be kept on an individual line. The IP address should
be placed in the first column followed by the corresponding host name.
The IP address and the host name should be separated by at least one
space.

Additionally, comments (such as these) may be inserted on individual
lines or following the machine name denoted by a '#' symbol.

For example:

<IP_ADDRESS>     rhino.acme.com          # source server
<IP_ADDRESS>     x.acme.com              # x client host
localhost name resolution is handled within DNS itself.

This file contains the mappings of IP addresses to host names. Each
entry should be kept on an individual line. The IP address should
be placed in the first column followed by the corresponding host name.
The IP address and the host name should be separated by at least one
space.

Additionally, comments (such as these) may be inserted on individual
lines or following the machine name denoted by a '#' symbol.

For example:

<IP_ADDRESS>     rhino.acme.com          # source server
<IP_ADDRESS>     x.acme.com              # x client host
localhost name resolution is handled within DNS itself.
<IP_ADDRESS>       localhost
::1             localhost
<IP_ADDRESS>       localhost
::1             localhost
Thank you for your help looks like a great product

Please try this version: https://github.com/derekhe/msfs2020-google-map/releases/tag/2.2.5

Hi:
I have tried version 2.2.5 and I don't get the error message, but the
program won't work.  I have turned off the antivirus and firewall and it is
still not working.
Thank you,
Gerry
On Fri, Nov 12, 2021 at 5:31 AM hesicong @.***> wrote:

Please try this version:
https://github.com/derekhe/msfs2020-google-map/releases/tag/2.2.5
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/derekhe/msfs2020-google-map/issues/47#issuecomment-966954592,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARE5DHSKIX3ESK74SSTMU2DULTNFVANCNFSM5HW3V5TA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Can you do a screen recording about all you doing and let me have a look?

Hi:
I don't know how to do a video screenshot, here is a screenshot of after I
open (with admin rights) and press the Run button.
Thank you,
Gerry
On Sat, Nov 13, 2021 at 9:34 PM hesicong @.***> wrote:

Can you do a screen recording about all you doing and let me have a look?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/derekhe/msfs2020-google-map/issues/47#issuecomment-968187016,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARE5DHX6RXHUUD5RHLNC35TUL4G2PANCNFSM5HW3V5TA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

There is no screenshots?

sorry
On Sun, Nov 14, 2021 at 10:48 AM hesicong @.***> wrote:

There is no screenshots?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/derekhe/msfs2020-google-map/issues/47#issuecomment-968304637,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARE5DHQ4366KXDQ4EHMFK5DUL7D2ZANCNFSM5HW3V5TA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.