When only selecting two waypoints TspOptimizationType.TravelTime reverses the order

I've been using this toolkit to create route between multiple locations, but I have now noticed that if I specify a list of Waypoints in a RouteRequest that only contains two locations then the order of them (IE the starting point) is not respected.
Normally it respects the starting point but in this case it seems like it is choosing the second item as the starting point.
My route request is as so:
      var routeRequest = new RouteRequest
      {
        Waypoints = waypoints.ToList(),
        WaypointOptimization = TspOptimizationType.TravelTime,
        RouteOptions = new RouteOptions
        {
          TravelMode = travelMode,
          RouteAttributes = new List<RouteAttributeType>
          {
            RouteAttributeType.RoutePath,
          }
        },
        BingMapsKey = _distanceMatrixKey
      };

With the serialized version of my route request being:
{
  "Waypoints": [
    {
      "latitude": 30.25495,
      "longitude": -97.73267
    },
    {
      "latitude": 30.26879,
      "longitude": -97.74172
    }
  ],
  "RouteOptions": {
    "Avoid": null,
    "DistanceBeforeFirstTurn": 0,
    "Heading": null,
    "Optimize": 1,
    "TravelMode": 0,
    "DateTime": null,
    "TimeType": 1,
    "RouteAttributes": [
      2
    ],
    "DistanceUnits": 0,
    "Tolerances": null,
    "MaxSolutions": 1,
    "VehicleSpec": null
  },
  "BatchSize": 25,
  "WaypointOptimization": 0,
  "BingMapsKey": "AmhE6jTOn3QD5NV6JIM2OWRFgZ_LdgHRq0ix8rWbQYeukiW-Q9JY9d50XG3CS-30",
  "Culture": null,
  "UserMapView": null,
  "UserLocation": null,
  "UserRegion": null,
  "UserIp": null,
  "Domain": "https://dev.virtualearth.net/REST/v1/"
}

And I get back
{
  "copyright": "Copyright © 2018 Microsoft and its suppliers. All rights reserved. This API cannot be accessed and the content and any results may not be used, reproduced or transmitted in any manner without express written permission from Microsoft Corporation.",
  "brandLogoUri": "http://dev.virtualearth.net/Branding/logo_powered_by.png",
  "statusCode": 200,
  "statusDescription": "OK",
  "authenticationResultCode": "ValidCredentials",
  "traceId": "ba2365db3a7345b8a446709f4b9441e3|HK20300156|<IP_ADDRESS>|HK20230323, HK20251119",
  "resourceSets": [
    {
      "estimatedTotal": 1,
      "resources": [
        {
          "id": "v69,h-823779366,i0,a0,cen-US,dAAAAAAAAAAA1,y0,s1,m1,o1,t4,w6X3ja89EPkCBsilXeG9YwA2~AjOI157RvpwSAADgAR4mDz8A0~RSA3dGggU3Q1~~~~v11,wfh04Z0RBPkCpMLYQ5G5YwA2~AjOI155RSKsSAADgASgNfD4B0~TmF2YXNvdGEgU3Q1~~~~v11,k1",
          "distanceUnit": "kilometer",
          "durationUnit": "Second",
          "travelDistance": 2.452,
          "travelDuration": 320.0,
          "travelDurationTraffic": 481.0,
          "trafficCongestion": "Heavy",
          "trafficDataUsed": "None",
          "routeLegs": [
            {
              "travelDistance": 2.452,
              "travelDuration": 320.0,
              "description": "E 7th St, N I-35",
              "actualStart": {
                "type": "Point",
                "coordinates": [
                  30.268788,
                  -97.741721
                ]
              },
              "actualEnd": {
                "type": "Point",
                "coordinates": [
                  30.254879,
                  -97.732527
                ]
              },
              "itineraryItems": [
                {
                  "compassDirection": "east",
                  "details": [
                    {
                      "compassDegrees": 105,
                      "maneuverType": "DepartStart",
                      "startPathIndices": [
                        0
                      ],
                      "endPathIndices": [
                        1
                      ],
                      "roadType": "Street",
                      "locationCodes": [
                        "112+13137"
                      ],
                      "names": [
                        "E 7th St"
                      ],
                      "mode": "Driving"
                    }
                  ],
                  "exit": "",
                  "iconType": "Auto",
                  "instruction": {
                    "maneuverType": "DepartStart",
                    "text": "Depart E 7th St toward Brazos St"
                  },
                  "maneuverPoint": {
                    "type": "Point",
                    "coordinates": [
                      30.268788,
                      -97.741721
                    ]
                  },
                  "sideOfStreet": "Unknown",
                  "tollZone": "",
                  "towardsRoadName": "Brazos St",
                  "transitTerminus": "",
                  "travelDistance": 0.71,
                  "travelDuration": 90.0,
                  "travelMode": "Driving"
                },
                {
                  "compassDirection": "south",
                  "details": [
                    {
                      "compassDegrees": 200,
                      "maneuverType": "TurnRight",
                      "startPathIndices": [
                        1
                      ],
                      "endPathIndices": [
                        3
                      ],
                      "roadType": "Arterial",
                      "locationCodes": [
                        "112-16864",
                        "112-16863",
                        "112-16862"
                      ],
                      "names": [
                        "N I-35"
                      ],
                      "mode": "Driving"
                    }
                  ],
                  "exit": "",
                  "hints": [
                    {
                      "hintType": "Landmark",
                      "text": "Gulf on the corner"
                    }
                  ],
                  "iconType": "Auto",
                  "instruction": {
                    "maneuverType": "TurnRight",
                    "text": "Turn right onto N I-35"
                  },
                  "maneuverPoint": {
                    "type": "Point",
                    "coordinates": [
                      30.26683,
                      -97.73467
                    ]
                  },
                  "sideOfStreet": "Unknown",
                  "tollZone": "",
                  "transitTerminus": "",
                  "travelDistance": 0.959,
                  "travelDuration": 121.0,
                  "travelMode": "Driving"
                },
                {
                  "compassDirection": "south",
                  "details": [
                    {
                      "compassDegrees": 190,
                      "maneuverType": "KeepToStayLeft",
                      "startPathIndices": [
                        3
                      ],
                      "endPathIndices": [
                        6
                      ],
                      "roadType": "Arterial",
                      "locationCodes": [
                        "112-16862"
                      ],
                      "names": [
                        "N I-35"
                      ],
                      "mode": "Driving"
                    }
                  ],
                  "exit": "",
                  "iconType": "Auto",
                  "instruction": {
                    "maneuverType": "KeepToStayLeft",
                    "text": "Keep left to stay on N I-35"
                  },
                  "maneuverPoint": {
                    "type": "Point",
                    "coordinates": [
                      30.25862,
                      -97.73772
                    ]
                  },
                  "sideOfStreet": "Unknown",
                  "tollZone": "",
                  "transitTerminus": "",
                  "travelDistance": 0.131,
                  "travelDuration": 13.0,
                  "travelMode": "Driving"
                },
                {
                  "compassDirection": "east",
                  "details": [
                    {
                      "compassDegrees": 104,
                      "maneuverType": "TurnLeft",
                      "startPathIndices": [
                        6
                      ],
                      "endPathIndices": [
                        8
                      ],
                      "roadType": "Arterial",
                      "locationCodes": [
                        "112N17013",
                        "112-17013"
                      ],
                      "names": [
                        "Holly St",
                        "River St"
                      ],
                      "mode": "Driving"
                    }
                  ],
                  "exit": "",
                  "iconType": "Auto",
                  "instruction": {
                    "maneuverType": "TurnLeft",
                    "text": "Turn left onto Holly St / River St"
                  },
                  "maneuverPoint": {
                    "type": "Point",
                    "coordinates": [
                      30.25745,
                      -97.73771
                    ]
                  },
                  "sideOfStreet": "Unknown",
                  "tollZone": "",
                  "transitTerminus": "",
                  "travelDistance": 0.567,
                  "travelDuration": 81.0,
                  "travelMode": "Driving"
                },
                {
                  "compassDirection": "south",
                  "details": [
                    {
                      "compassDegrees": 194,
                      "maneuverType": "TurnRight",
                      "startPathIndices": [
                        8
                      ],
                      "endPathIndices": [
                        10
                      ],
                      "roadType": "Street",
                      "names": [
                        "Navasota St"
                      ],
                      "mode": "Driving"
                    }
                  ],
                  "exit": "",
                  "iconType": "Auto",
                  "instruction": {
                    "maneuverType": "TurnRight",
                    "text": "Turn right onto Navasota St"
                  },
                  "maneuverPoint": {
                    "type": "Point",
                    "coordinates": [
                      30.25559,
                      -97.73221
                    ]
                  },
                  "sideOfStreet": "Unknown",
                  "tollZone": "",
                  "transitTerminus": "",
                  "travelDistance": 0.085,
                  "travelDuration": 14.0,
                  "travelMode": "Driving"
                },
                {
                  "compassDirection": "south",
                  "details": [
                    {
                      "compassDegrees": 194,
                      "maneuverType": "ArriveFinish",
                      "startPathIndices": [
                        10
                      ],
                      "endPathIndices": [
                        10
                      ],
                      "roadType": "Street",
                      "names": [
                        "Navasota St"
                      ],
                      "mode": "Driving"
                    }
                  ],
                  "exit": "",
                  "hints": [
                    {
                      "hintType": "PreviousIntersection",
                      "text": "The last intersection is Holly St"
                    },
                    {
                      "hintType": "NextIntersection",
                      "text": "If you reach Haskell St, you've gone too far"
                    }
                  ],
                  "iconType": "Auto",
                  "instruction": {
                    "maneuverType": "ArriveFinish",
                    "text": "Arrive at Navasota St on the right"
                  },
                  "maneuverPoint": {
                    "type": "Point",
                    "coordinates": [
                      30.254879,
                      -97.732527
                    ]
                  },
                  "sideOfStreet": "Right",
                  "tollZone": "",
                  "transitTerminus": "",
                  "travelMode": "Driving"
                }
              ],
              "routeSubLegs": [
                {
                  "endWaypoint": {
                    "description": "Navasota St",
                    "locationIdentifier": "2|51|136|215|158|81|72|171|18|0|0|224|1|40|13|124|62|1|30.254879,-97.732527",
                    "routePathIndex": 10,
                    "type": "Point",
                    "coordinates": [
                      30.254879,
                      -97.732527
                    ]
                  },
                  "startWaypoint": {
                    "description": "E 7th St",
                    "locationIdentifier": "2|51|136|215|158|209|190|156|18|0|0|224|1|30|38|15|63|0|30.268788,-97.741721",
                    "type": "Point",
                    "coordinates": [
                      30.268788,
                      -97.741721
                    ]
                  },
                  "travelDistance": 2.452,
                  "travelDuration": 320.0
                }
              ]
            }
          ],
          "routePath": {
            "line": {
              "type": "LineString",
              "coordinates": [
                [
                  30.268787,
                  -97.74172
                ],
                [
                  30.26683,
                  -97.73467
                ],
                [
                  30.266205,
                  -97.734906
                ],
                [
                  30.25862,
                  -97.73772
                ],
                [
                  30.258415,
                  -97.737755
                ],
                [
                  30.25804,
                  -97.737799999999993
                ],
                [
                  30.25745,
                  -97.73771
                ],
                [
                  30.257406,
                  -97.737539
                ],
                [
                  30.25559,
                  -97.73221
                ],
                [
                  30.25544,
                  -97.73225
                ],
                [
                  30.254879,
                  -97.732525999999993
                ]
              ]
            },
            "generalizations": [

            ]
          },
          "bbox": [
            30.254879,
            -97.741721,
            30.268788,
            -97.73221
          ]
        }
      ]
    }
  ]
}

Notice how the first route leg actual starting point is in fact the second waypoint....

Found the issue. In the middle of getting the next update ready already, but will make sure this is in it.

This is now fixed in update 1.1.2. Get the latest NuGet package and it should resolve your issue.

Thanks for the quick turn around!


Initialization of moving average of entropy

Hello author,
Thanks for the release of the code of your paper.
The (pseudo) code shows that the moving average value of entropy loss is not initialized to 0 after the model recovery.
I think the value should be initialized to 0. Could you give me an answer?
Thank you in advance:-)

Hi e0jun,
The e_0 should be re-initialized after each time recovery (as we did in sar.py). We missed this in the pseudo-code. Thank u for pointing this out!
Best,

Thank you for your quick reply!
In sar.py, the ema value is returned with reset_flag in line 49.
If reset_flag is True, the self.ema is re-initialized in line 51.
But, in line 52, the returned ema is re-allocated to self.ema, making the re-initialization negligible.
It could be my misunderstanding, but could you explain the re-initialization process? If you give me an answer, I really appreciate it!!

Hi,
To make the re-initialization of $e_m$ effective, line 52 should actually be placed before line 50.
However, I think that the performance would not be clearly affected whether we reset $e_m$ or not. This is because, once the model is reset, the entropy of the new predictions $e$ will be much higher than $e_m$ , causing $e_m$ to quickly become large after a few iteration steps of ema update.
Hope that helps

I understand! I really appreciate your reply:)


warsow: fix src url

Motivation for this change
Warsow doesn't build anymore.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Manually checked that the hashes are the same.

Manually checked that the hashes are the same.


document stable branch management

closing, let's track through https://github.com/kata-containers/documentation/issues/237


Verify replica is closed by checking both spec.DesireState and status.CurrentState

To avoid running into a case that status.CurrentState is stopped but spec.DesireState is not stopped. verifyVolumeDependentResourcesClosed() needs to check status.CurrentState as well as spec.DesireState.
Longhorn/longhorn#6776

I agree that this seems safer, to conclude that a volume's status of stopped (engine and replicas) is not just transient, but matches the desired state.  I'm not sure yet how that helps address https://github.com/longhorn/longhorn/issues/6776, though.
Also, why wouldn't the same logic apply in areVolumeDependentResourcesOpened(), say?  Shouldn't we check that the engine and the (at least one) running replica are desired to be in state "running"?

@james-munson
The draft might be incorrect for https://github.com/longhorn/longhorn/issues/6776. Please ignore it.


net/http: ServeMux excess locking

In #25383, a lock contention regression was brought up in ServeMux.    I believe this lock contention is still present in the mux, and could be removed.  Making ServeMux have an atomically loaded handler map can help reduce latency of serving at the cost of more expensive mutations.
A sample CL that fixes this regression is https://go-review.googlesource.com/c/go/+/149377 and shows promising speedups on the benchmarks:
$ benchstat /tmp/old.txt  /tmp/new.txt
name                   old time/op    new time/op    delta
ServeMux-12              76.3µs ± 3%    64.0µs ± 7%  -16.14%  (p=0.000 n=30+30)
ServeMux_SkipServe-12    28.4µs ± 2%    19.8µs ± 3%  -30.49%  (p=0.000 n=28+28)

name                   old alloc/op   new alloc/op   delta
ServeMux-12              17.3kB ± 0%    17.3kB ± 0%     ~     (all equal)
ServeMux_SkipServe-12     0.00B          0.00B          ~     (all equal)

name                   old allocs/op  new allocs/op  delta
ServeMux-12                 360 ± 0%       360 ± 0%     ~     (all equal)
ServeMux_SkipServe-12      0.00           0.00          ~     (all equal)

However, this change depends on using CompareAndSwap, which is only available for unsafe.Pointer values.    The reviewer of the CL expressed that using unsafe is unacceptable, though I am not really sure why.   I have previously proposed that atomic.Value should gain these methods in #26728, but the proposal was also declined.
Options
Thus, there are a few ways forward that I can think of, but need a decision from the Go team:

Accept the use of unsafe in ServeMux, and gain the extra efficiency.
Accept that there is a valid use case for  atomic.Value.CompareAndSwap(), and prioritize it being added as a public (or private) API, and use it instead.
Come up with some other solution to improve the serving speed of ServeMux, that is neither of the above two.
Disagree that performance of the ServeMux matters or is worth optimizing, close the CL, and pay the extra 10us per request.

I feel rather helpless with regards to options 1 and 2.  I have suggested both, but have received differing reasons for why they aren't acceptable from different Go team members.  I'd rather the Go team just pick one of the 4 options above, because the requirements for changing Go are opaque from my POV.
cc: @bradfitz @rsc

I was in the meeting with @rsc, @gri, @ianlancetaylor, et al when we closed #26728 with text:

It would be fine for someone who has a compelling use for these to create a new issue proposing to add Swap and CompareAndSwap (or to reopen this one, if you have permission). For now, given the lack of a real-world use case for them, we will err on the side of leaving it out.

You're not going to find disagreement on the team there.
You seem to have a real-world use case for it, so do what I said on the CL: implement both (with unsafe, which we won't accept, which we also agree on), and with atomic.Value CAS, and show that atomic.Value with CAS is the way to get the same performance without using unsafe.
But it's not a priority for us to investigate this ourselves so if you want to pursue this, please do.


Support install_only_stripped PBS flavor.

Closes #76

Still ~3x bigger than a skinny scie on Linux but used to be ~7x bigger:
:; ls -sSh1 dist/science* dist/stripped/*
 64M dist/science-fat-linux-x86_64
 25M dist/stripped/science-fat-linux-x86_64
9.3M dist/science-linux-x86_64
1.2M dist/science.pyz


fix wrong preprocessors serialisation

This PR attempt to solve the problem caused by the serialisation of the FeaturePreprocessor object.
The fix could and should be improved but I could not find out quickly how
When running the tagger using a model that has been trained with features, it will fail because features=None in the DataGenerator creation.
CC @de-code @kermitt2

Just a general comment:
I was banging my head against JSON serialization a while ago after I attempted to port your JSON serialization. Mostly because I am still using my preprocessor which isn't as JSON friendly. I didn't know that you experienced issues too?
__getstate__ and __setstate__ are Python method names designed to extract the data / state (not sure if you want to adopt them). It's mostly deserializing that was causing issues (i.e. doing it in a less bespoke way).
In the end I used jsonpickle (see PR). While that works relatively easily, it does make the JSON specific to jsonpickle. I wish it was easier.

Thanks @de-code your comment is exactly what I was looking for. I set this PR back to draft and try to work this out.
I will probably do without jsonpickle, as I would prefer to maintain compatibility with the current JSON formats.

I updated and simplified a bit... I'm not sure I could do better than this

One issue I encountered was that features_map_to_index (initialised as a list) will be a dictionary with integers as keys. But JSON only allows string keys. I had to do some mapping for those. I didn't spot any specific handling for that and your test appear to be covering deserialization. But maybe worth double checking?

After some modifications of tagger.py to support feature input (and for DataGenerator), I did some tests via the GROBID integration, and it works!
(I also had to modify GROBID to provide the features when calling tag()).
But, the models without feature could not be saved anymore because feature_preprocessor was None, so I had to modify preprocess.py line 361
            if var == 'feature_preprocessor' and variables['feature_preprocessor'] is not None:

One issue I encountered was that features_map_to_index (initialised as a list) will be a dictionary with integers as keys. But JSON only allows string keys. I had to do some mapping for those. I didn't spot any specific handling for that and your test appear to be covering deserialization. But maybe worth double checking?

I tested the date model which has some integer values as features (for the boolean features), would it cover the this case?

One issue I encountered was that features_map_to_index (initialised as a list) will be a dictionary with integers as keys. But JSON only allows string keys. I had to do some mapping for those. I didn't spot any specific handling for that and your test appear to be covering deserialization. But maybe worth double checking?

I tested the date model which has some integer values as features (for the boolean features), would it cover this case?

Actually any model with features would do because it's an internal integer (the feature index I believe). But you would need to test serialising and deserialisation. In a unit test I reproduced it by fitting the preprocessor with some dummy data (including features).

I got it, finally.

features_map_to_index is initialised as list, should be initalised as dictionary
indeed when you load back the model as the features indexes are strings and not integer we need to map them back to integer.

OK, the test was not even running thanks to the @fixture annotation. Not sure why.
Now should be working fine using tmp_path.

OK, the test was not even running thanks to the @fixture annotation. Not sure why.

I think that will be, because it declared the test method as a fixture. The @fixture annotation would go on a function that provides a fixture value. For the tmpdir_factory example, the image_file fixture uses the tmpdir_factory fixture to provide the path to a temporary image file, as a fixture value. (pytest fixtures can depend on other fixtures)


Unit test

Added unit tests to the following:

/roles

add
delete

/remember

rememberMessages

src/utils/schedule.js

parseDaysList

src/utils/help.js

help
helpRemember
helpAvailability

src/utils/availability.js

newAvailabilityEntry
createAvailability
createUnavailability
displayAvail
displayUnavail

Can't test the following

/remember

The rest of the subcommands - Although it's doable, most of the commmands require multiple async calls that would require a lot of mocking. We may need to refactor to have more digestible util functions and test those instead

/check-in-interface - All inplementation is done inside execute(). A seperate method could return the creation of the ActionRowBuilder/ButtonBuilder and what is replied.
/schedule-check-in - All inplementation is done inside execute(). These can be broken up into differnt methods from utils.
src/utils/schedule.js

displaySchedule - never used
createSchedule - never used
mergeSchedules - never used
parseTime - never used

src/utils/availability,js

all the other methods are saving to file with no returns which isn't really feasible to unit test or are async

Although it is possible to create unit tests for the methods that are not used anywhere, it would be a possible waste of time if they are never used in the future. It is also difficult to write tests since the paramters' data type aren't explicit, especially when it's an object. We may need to require inline doucmentation for all methods in future inplementations.

displaySchedule()
createSchedule()
parseTime()

are actually used in the daily check in commands.
Other than that, ready to merge


Lovely patch for G.GAME.pack_size matches unintended lines

One of your lovely patches modifies the value of G.GAME.pack_size.
This pattern unfortunately not only matches in Card:open (the presumed function you're trying to patch) but also:

Card:redeem: the voucher redeem function. While this is no immediate issue, this does not seem intended
Card:start_materialize: the card appear function. In short, this causes crashes for any mod that reads G.GAME.pack_size during booster pack opening (e.g. Betmma's, CardSleeves)

Could be fixed by choosing a different line for the lovely pattern to match, or turning it into e.g. a hook instead of lovely patch.

fixed


BROOKLYN-404: fix ConcurrentModificationException in BrooklynProperties

As discussed in https://issues.apache.org/jira/browse/BROOKLYN-404, the fix is to change BrooklynProperties so it no longer exposes the map interface. This means we can much more easily control its mutators and its accessors to avoid such ConcurrentModificationExceptions.
This PR does not do anything about @neykov's additional suggestion in jira: "Taking a step back I think we should either let users update the properties in a non-hackish way (that is include the mutators in the interface which getConfig() returns) or introduce an alternative "scratch" space to serve the same purpose."
Currently, if someone wants to modify the BrooklynProperties, it needs to be cast to BrooklynProperties (whereas managementContext.getConfig() returns StringConfigMap, which is a super-interface of BrooklynProperties).

@aledsage could you rebase on master?

Looks good; will merge.


Cleanup old Branches

@johnridge, @GrantPDonnelly Now that all of our outstanding PRs are closed, the next thing I ask you to do is to delete obsolete branches.  I was able to delete one that I owned, but you own the other two that remain.  Go to rotseana and select Pull Requests and then ‘Closed’.  Go to each PR and if you own the branch that PR is related to, it will ask you if the branch should be deleted.  If it is not okay to do so, it will tell you.  Click the Delete button and then the branch will no longer appear.
In general, this kind of pruning is important because it gets confusing when multiple branches are up, sometimes with different tasks and timetables.  I am assigning @gdhungana this Issue since he is more expert on the ‘delete branch’ issue that I.  If you have any questions, ask them here and we can converge.

@johnridge. What is the status of this Issue?  Can it be closed?

@johnridge  I will close this issue as it appears to be done, but please follow the above instructions to close your open but finished old branches.


fix: failing config tests

Description
Please explain the changes you made here. Reference related issues if applicable.
Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update

Checklist

[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Related Issues
Fixes # (issue number)
How Has This Been Tested?
Describe how the changes were tested.
Additional Context
Add any other relevant information or screenshots about the PR.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.03%. Comparing base (5d1de2c) to head (80ff9a3).
Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   71.05%   69.03%   -2.02%
==========================================
  Files          16       17       +1
  Lines         608      662      +54
==========================================
+ Hits          432      457      +25
- Misses        166      191      +25
- Partials       10       14       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


delete usages of toSet for determinism

While working on https://github.com/freechipsproject/firrtl/pull/1665 I noticed that between different runs the results of LoweringCompilersSpec would change. Getting rid of these .toSet calls fixes the issue.
Contributor Checklist

[x] Did you add Scaladoc to every public function/method?
[ ] Did you update the FIRRTL spec to include every new feature/behavior?
[ ] Did you add at least one test demonstrating the PR?
[x] Did you delete any extraneous printlns/debugging code?
[x] Did you specify the type of improvement?
[x] Did you state the API impact?
[x] Did you specify the code generation impact?
[x] Did you request a desired merge strategy?
[x] Did you add text to be included in the Release Notes for this change?

Type of Improvement

bug fix

API Impact

none
Backend Code Generation Impact

none
Desired Merge Strategy

Squash

Release Notes

fix determinism bug in transform ordering
Reviewer Checklist (only modified by reviewer)

[ ] Did you add the appropriate labels?
[ ] Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
[ ] Did you review?
[ ] Did you check whether all relevant Contributor checkboxes have been checked?
[ ] Did you mark as Please Merge?

@seldridge is this a 1.3.x backport?

Yeah, this should be backported. Updated the milestone just now.


[Low-bit optim] Add Llama2-7B finetune benchmarks

Update: change Llama3.1-8B-instruct to Llama2-7B
Fine-tune Llama2-7B on Alpaca dataset. Full BF16, 1 epoch, A100, fixed random seed. Benchmark is done with torchtune.
Summary

AdamW impl
Max memory (GB)
toks/s
truthfulqa_mc2 acc
Compile time

Not fine-tuned
-
-
38.95
-

PyTorch (fused)
52
~4500
42.12
~4 min

bnb 8-bit
39
~4000
41.98
~4 min

ao 8-bit
39
~4000
42.41
~12 min

ao 4-bit
33
~3600
42.34
~4 min

NOTE:

lpmm's 4-bit AdamW does not support BF16 weights -> not include in benchmark
A100 does not support FP8 -> not include FP8 AdamW

Observations

The reduction in peak memory looks correct: going from 16-bit to 8-bit -> 52 - 39 = 13GB reduction. Going from 8-bit to 4-bit -> 39 - 33 = 6GB reduction.
Our 8-bit AdamW is only slightly slower than bnb, which is nice.
The compile time for 8-bit is HUGE (12 min). Might need to find ways to mitigate this.
Our 4-bit AdamW is quite slow, but compile fast. This is expected because we compile w/ dynamic shape for each param, while in 8-bit AdamW, we compile w/ static shape for all params. We do this way because 4-bit AdamW will have a memory bug when compiling for all params.

Command used (change optimizer and checkpointer.output_dir across runs)

tune run full_finetune_single_device --config llama2/7B_full optimizer=torch.optim.AdamW optimizer.fused=True optimizer_in_bwd=False compile=True metric_logger=torchtune.utils.metric_logging.WandBLogger log_peak_memory_stats=True batch_size=16 log_every_n_steps=10 epochs=1 seed=2024 checkpointer.output_dir=experiments/adamw_baseline

Fancy graphs!
Compare across different n-bit optimizers

Compare 8-bit AdamW between ao and bnb. The fact that the two graphs overlap show that our implementation is correct and competitive in speed (except compile time 😭)!

@msaroufim Any blockers to merge this? The failing CPU test is unrelated, though I'm probably in charge of it since it's FP6-LLM 🌚. Seems like something change with CPU inductor.
Some thoughts on reducing compile time. There are 2 approaches to compile optimizer step in low-bit optim:

Compile optim step for single param i.e. torch.compile(single_param_adam)
Compile optim step for all params i.e. torch.compile(param_groups_adam)

Currently Adam8bit and AdamFp8 use approach (2) (with static shape) since it is faster (but compile much slower), while Adam4bit uses approach (1) (with dynamic shape) since there are excessive memory usage for "Adam4bit + approach (2)". Approach (1) requires dynamic shape to avoid hitting recompiles limit.
Now looking back, perhaps we can do approach (1) with static shape + temporarily remove recompile limit? I have seen FlexAttention doing this
https://github.com/pytorch/pytorch/blob/76710d4f95d1f920bdf56e4db4d6d71ef6c9aea2/torch/nn/attention/flex_attention.py#L989
It's probably safe to do so, since for a given model, the number of recompiles for single_param_adam() is fixed, though some models may have more recompiles than others (e.g. ViT vs LLM).

I'm gonna add some of your comments here to the README since they're helpful


Update 1.4.1.md

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ x ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ x ] Removes existing feature or API

Seems like a mistake PR.  Unintelligible changes to old release notes 🤷


Add DSMR Toolkit

Insert URLs to the project here: https://github.com/nielsbasjes/dsmr-tools

[x] The projects is active, documented, open source licensed, shows usage from external parties and is directly targeting environmental sustainability. Find more details in the Contribution Guide.

All issues labeled as Good First Issue of the project listed on OpenSustain.tech will be visible on ClimateTriage.com. This is a great way to welcome new community members to your project.
All new projects listed will be posted on our Mastodon channel.

@nielsbasjes


Cannot launch after update - Manjaro KDE

Error when launching:
/usr/lib/chromium/chromium: error while loading shared libraries: libavcodec.so.60: cannot open shared object file: No such file or directory
How can I solve this error?
Tried to downgrade but got another error:
errore: '/var/cache/pacman/pkg/ungoogled-chromium-110.0.5481.177-1-x86_64.pkg.tar.zst': il pacchetto non è valido oppure è corrotto (firma PGP)

Manjaro doesn't have ffmpeg 6 yet, see #220. You need to download the -1 package manually wget https://github.com/ungoogled-software/ungoogled-chromium-archlinux/releases/download/111.0.5563.64-1/ungoogled-chromium-111.0.5563.64-1-x86_64.pkg.tar.zst and install it using pacman -U ungoogled-chromium-111.0.5563.64-1-x86_64.pkg.tar.zst

Thank you very much @networkException !!!
You saved my day :)


Removing deprecated puppetlabs-apt properties to remove deprecation notices

The key_source and required_packages properties are deprecated and key should now be a hash instead of a string. I'm not sure the best way to handle the required packages so I've moved them to an ensure_packages call for now and made that a requirement of the apt resource.
Addresses #455.

Also discussed in #315

Is it going to be merged?

+1 ... can this be merged


microdrop.gui.config_controller plugin crashed processing on_app_options_changed signal (Trac #181)

The config controller is crashing with the error:
'ascii' codec can't encode character u'\xae' in position x

This seems to be caused by a registered trademark symbol in the name of some webcams (e.g., Microsoft LifeCam) but also depends on the version of Windows (happens under Windows 10, but the same webcam did not have a registered trademark in it's description under Windows 7).
Migrated from http://microfluidics.utoronto.ca/microdrop/ticket/181
{
    "status": "new",
    "changetime": "2016-02-10T15:49:52",
    "description": "The config controller is crashing with the error:\n{{{\n'ascii' codec can't encode character u'\\xae' in position x\n}}}\nThis seems to be caused by a registered trademark symbol in the name of some webcams (e.g., Microsoft LifeCam) but also depends on the version of Windows (happens under Windows 10, but the same webcam did not have a registered trademark in it's description under Windows 7).",
    "reporter": "ryan",
    "cc": "",
    "resolution": "",
    "_ts": "1455119392926510",
    "component": "microdrop",
    "summary": "microdrop.gui.config_controller plugin crashed processing on_app_options_changed signal",
    "priority": "major",
    "keywords": "",
    "version": "1.0",
    "time": "2016-02-10T15:44:15",
    "milestone": "",
    "owner": "",
    "type": "defect"
}

Trac update at 20160210T15:49:52: ryan commented:

Fixed in commit changeset 1347a95022 (v1.0.23).


eoxcloudless as BYOA into public collections

dont know if the custom key: https://github.com/eurodatacube/public-collections/blob/update_eoxcloudless_to_byoa/collections/eoxcloudless-s2-global-mosaic-10.yaml#L17-L19 will work like this
also merge after launching the BYOA at EDC

Moved the price information into additional information readme.md

@Dorothyrono this is now ready to be merged and deployed. Does a merge trigger an automatic deploy or is there a manual step needed? Thanks.

@Schpidi  yes, merging  triggers  an automatic deploy.
but the changes can take upto max 1 hr to take effect .
but after merging,  you can check the changes after  2 mins or so  under :
https://s3.eu-central-1.amazonaws.com/collections.eurodatacube.com/eoxcloudless-s2-global-mosaic-10/index.html
https://s3.eu-central-1.amazonaws.com/collections.eurodatacube.com/eoxcloudless-s2-global-mosaic-10/readme.html

@Schpidi do you mean automatic deploy on EDC browser ?
Most probably so,,
but @dthiex can give a sure confirmation

The collection will be automatically available at https://collections.eurodatacube.com/ after the merge.
As collection within the EDC Browser it will also be available automatically (though only if we are able to create a STAC compliant JSON from the YAML file). As there are some mandatory metadata fields missing in the YAML file this will not happen until those are added.

We tested locally that nothing breaks and as the change only affects one collection we added I'm going to merge and see what happens.

@dthiex thanks for the details. we need it in the "On demand data" tab of the EDC browser, there it should be fine.
how long does the deploy typically take? I see that the old images are not available anymore at https://collections.eurodatacube.com/eoxcloudless-s2-global-mosaic-10/readme.html and the new ones are there like https://collections.eurodatacube.com/eoxcloudless-s2-global-mosaic-10/S2cloudless-2020_website_smaller.jpg but the text is not yet updated. thanks for your help.

is there maybe an invalidation step missing on the cloudfront distribution? we use this in the dashboard https://github.com/eurodatacube/eodash/blob/staging/.github/workflows/production_deploy.yml#L52

how long does the deploy typically take?

normally  it takes upto 1 hr max  for all changes to be updated  . should be all updated soon @Schpidi

is there maybe an invalidation step missing on the cloudfront distribution? we use this in the dashboard https://github.com/eurodatacube/eodash/blob/staging/.github/workflows/production_deploy.yml#L52

@Developer1510 , you probably are the right person to know this

I just checked again and both the html as well as the collection overview page are both updated now.

confirmed, thx a lot


Fix group deletion behavior in server

While porting code to the permissions plugin, I noticed this logic was wrong, would be nice to have it fixed until plugins hit.

This change is

:lgtm:


Add API calls within React

Vanessa will go to each component and create the api calls for the react apps to connect to the database.

added axios based get requests in inspirations and viewMyEscapes components


Document generics in responses correctly

This is an attempt to port this fix from swagger-core:
https://github.com/swagger-api/swagger-core/pull/1119
This way, when an API function returns, for example, a List, the
output will be docmented as a list of Persons rather than a list of
Objects.

@kongchen @who Can you guys take a look at this and see what else needs to be done to merge this? It would be really helpful if we had this.

I've imported new versions of the swagger core, and this is no longer an issue.


Integrate boot file make into top level

Description
Lift the rules from installer/alpine/Makefile into rules.mk.j2 so that the top-level make can handle building the alpine files itself. Also cleanup/fix the Dockerfile & build.sh files that are responsible for building the Alpine boot files.
Why is this needed
Extracted out of #72 for better reviewability.
How Has This Been Tested?
Builds kernel, initramfs, and modloop files as needed.

@splaspood PTAL at the last 2 commits. These setup a way to skip building the Alpine files and adds some updated docs to the README.

Trying to figure out why drone/make is still trying to rebuild the alpine assets.

Finally got the "skip building alpine assets" stuff correct.
@splaspood @DavidHwu one more looksie please.


esp32boot.avm got bigger than the partition that contains it

The recent addition of a number of Elixir modules likely made esp32boot.avm bigger than the partition that contains it.
It must be shrinked or partitioning schema must be reviewed.

It won't solve the problem but we can safely remove libs/eavmlib/src/network_fsm.erl, this module has been documented as deprecated since before the v0.5.0 release.
In the interest of supporting OTA updates this might be a good time to add a second application partition and adjust the size of the boot.avm partition. I would propose the following layout:
# Name,   Type, SubType,   Offset,      Size,  Flags
nvs,      data, nvs,       0x9000,     0x6000,
phy_init, data, phy,       0xf000,     0x1000,
factory,  app,  factory,  0x10000,   0x1C0000,
boot.avm, data, phy,     0x1D0000,    0x60000,
app1.avm, data, phy,     0x230000,    0xE8000,
app2.avm, data, phy,     0x318000,    0xE8000

This increases the boot.avm partition from 256k to 512k, and gives each application partition approximately 928k which is only slightly smaller than the size currently used by our single main.avm application partition.
Another option would be to make the boot.avm even smaller (just including esp32boot and esp32devmode), and publish atomvmlib.avm to hex and have users include it as a dependency, much like the stm32 platform does now. The atomvm_packbeam tool does a fine job of pruning unnecessary modules if the --prune option is used. If we take this approach the default behavior of the atomvm_rebabr3_plugin can be changed to have the packbeam task prune unless an option is passed to prevent it.

I tried to figure out every bit we can save, and reality is that we cannot fit anyway: we get very close, but we cannot fit into boot partition anyway. Even if we can make it, as soon as we merge any fix or small addition (such as adc PR) we run out of space again.
Given this I rather push for a breaking change limited to Elixir, we'll properly document this, and we'll make sure esp32-mkimage.yaml will make both erlang only and elixir enabled images with 2 different partitioning schemas.
We'll make some kind of different discussion about what we should do for main.

This sounds like a perfectly reasonable short term solution to me.


[RFE] Optionally build with debugger-friendly compile settings

Is your feature request related to a problem? Please describe.
In order to use a debugger such as Delve, binaries have to be compiled with debugging symbols and disabling some optimizations.
Describe the solution you'd like
Pass the DEBUG variable to build scripts and, if set, make sure -gcflags="all=-N -l" is set and -ldflags -s -w is not set.
Describe alternatives you've considered
Another new variable could be added to the build scripts. That would be more granular but perhaps more redundant.
Additional context
Fleet and k3s already accepted similar patches:
https://github.com/rancher/fleet/pull/961
https://github.com/k3s-io/k3s/pull/6147

Tried this twice and ended up with the following output:
Please wait for the line "debug layer=debugger continuing" to appear...

Targeting container "rancher". If you don't see processes from this container it may be because the container runtime doesn't support this feature.
Defaulting debug container name to debugger-zt6t8.
Forwarding from <IP_ADDRESS>:4000 -> 4000
Forwarding from [::1]:4000 -> 4000
If you don't see a command prompt, try pressing enter.
Error attaching, falling back to logs: unable to upgrade connection: container debugger-zt6t8 not found in pod rancher-5699dcb9f6-96gxg_cattle-system
++ pgrep rancher
+ PID=34
++ stat -c %u /proc/34
+ USER_ID=0
++ stat -c %g /proc/34
+ GROUP_ID=0
+ ((  0 != 0  ))
+ ((  0 != 0  ))
+ echo 'root    ALL=(ALL:ALL) ALL'
+ exec sudo -u#0 -g#0 dlv attach 34 --continue --accept-multiclient --api-version 2 --headless --log --listen :4000
API server listening at: [::]:4000
2022-12-22T01:29:27Z warning layer=rpc Listening for remote connections (connections are not authenticated nor encrypted)
2022-12-22T01:29:27Z info layer=debugger attaching to pid 34
Could not attach to pid 34: this could be caused by a kernel security setting, try writing "0" to /proc/sys/kernel/yama/ptrace_scope

I built an image with the command sudo TAG=v2.7-head DEBUG=true make.
I then docker tagged it for my own repo with the tag "v2.7-head-debug".
I installed kubernetes using that image with the command
helm install rancher rancher-latest/rancher \
  --namespace cattle-system \
  --set hostname=<url> \
  --set bootstrapPassword=<pw> \
  --set rancherImage=<my-repo> \
  --set rancherImageTag=v2.7-head-debug

Then I ran pointed KUBECONFIG to the kubeconfig path for the local cluster and ran the script located here.
I'm assuming this should work as is without any intervention by me in the container. Moving to reopened for now, please let me know if I missed something.

Could not attach to pid 34: this could be caused by a kernel security setting, try writing "0" to /proc/sys/kernel/yama/ptrace_scope

It seems like ptrace could not attach to the process. Did you try applying the suggestion there in the host?

No I did not, I figured this was meant to work with no intervention.

Well, IIUC kernel settings cannot be changed by an unprivileged container - if that is really the root problem in your case.
Anyway, I'd track that as a separate problem - this issue is about adding debugger-friendly compile settings which is another necessary, but not sufficient, condition in order to debug successfully.

I took a look at your setup and can confirm that:

/proc/sys/kernel/yama/ptrace_scope is a host kernel setting, default value depends on your distro and configuration. One should normally change it on the host via echo 0 >/proc/sys/kernel/yama/ptrace_scope as root on the node running the delve pod. I added this to the delve-debugger README
if one does not have SSH access to the host but can run privileged containers, one possibility is to run a pod with the host's /proc mounted inside of the container and changing the flag there. I made a gist to explain how to do that.
there was a bug in the delve-debugger script which was pulling the wrong image, now fixed.

After that I could connect the debugger successfully to your instance, feel free to double check:
cd delve-debugger
git checkout master
git pull
./util/debug-rancher.sh

You should see a line like the following after 30 seconds or so:
2023-03-16T08:51:25Z debug layer=debugger continuing

That means the debugger has connected successfully.

Awesome, worked. I will close this issue.


Roll Flutter Engine from 460df6caef0e to 8db9aa635bd1 (3 revisions)

https://github.com/flutter/engine/compare/460df6caef0e...8db9aa635bd1
2024-05-16<EMAIL_ADDRESS>Roll Skia from 0bbcd8152d32 to dafbdcc7f1fd (1 revision) (flutter/engine#52875)
2024-05-16<EMAIL_ADDRESS>Roll Dart SDK from 1600c3bae731 to b64b487c9967 (1 revision) (flutter/engine#52874)
2024-05-16<EMAIL_ADDRESS>Roll Skia from 9c3b296f7b58 to 0bbcd8152d32 (1 revision) (flutter/engine#52873)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Also about the post-train models

Can you also release the BERT-DK models, as is mentioned in your paper?
It will be very kind of you to provide the post-trained models which targeting at the specific domains!

sure. we will.


Separate recv and sendto, on the server socket, to different threads

As of now, the servers socket receives and sends on the same thread, with a nonblocking action. It's implemented with asyncio datagram protocol, and it is performance heavy. As of now, the send speed averages around 130b/s on Intel i7-4770 (8) @ 3.900GHz

After further investigation, the asyncio.sleep is to slow for this sleeping interval, and runs approxly on a quater of the wanted speed
https://github.com/steinwurf/steinloss/blob/937249ff69dd40582e43bd0406d31bde093a01bd/steinloss/server.py#L145


Intro to Channel video 2nd voice/face

Charise is going to hook @Billflorio  up with Kenya!

@Billflorio were you able to connect with Kenya or should I ping her again?

All set


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_7fruns2hi1/clone/recipe/meta.yaml:16: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_7fruns2hi1/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
Errors were found


Add more tests and docs for issue indexer, add db indexer type for searching from database

This PR add more tests and docs for issue indexer and added a new indexer type db which will only search database table issue and comment via SQL like. It's not effective but for a small deployment is enough.

Codecov Report

Merging #6144 into master will decrease coverage by <.01%.
The diff coverage is 38.02%.

@@            Coverage Diff             @@
##           master    #6144      +/-   ##
==========================================
- Coverage   38.85%   38.85%   -0.01%
==========================================
  Files         352      354       +2
  Lines       50049    50112      +63
==========================================
+ Hits        19449    19472      +23
- Misses      27784    27822      +38
- Partials     2816     2818       +2

Impacted Files
Coverage Δ

modules/indexer/issues/queue.go
0% <0%> (ø)

modules/indexer/issues/queue_channel.go
0% <0%> (ø)
:arrow_up:

modules/indexer/issues/db.go
0% <0%> (ø)

modules/setting/indexer.go
100% <100%> (ø)
:arrow_up:

modules/indexer/issues/indexer.go
59.63% <14.28%> (-3.12%)
:arrow_down:

modules/indexer/issues/queue_disk.go
52.63% <66.66%> (+3.45%)
:arrow_up:

models/issue.go
48.33% <79.31%> (+0.74%)
:arrow_up:

models/repo_list.go
66.84% <0%> (-1.06%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0751153...40d6ba2. Read the comment docs.

Will fix #5798

Will fix #5798


structMap/div/@ID

This ID is used for? Remove?

Used for referencing to it if needed? The current spec states that it's mandatory, if we remove it becomes by default optional --> need to have a DILCIS Board review of the proposal to remove..

Would say this is a mandatory element in the profile for SIP not for CS IP.

More investigation needed. Connected to issue #83

Handled


Pick a date for comms to go out in the new year

What
We previously were aiming for 20 December for releasing the survey, but there's potential that it gets swept up in end of year activities and doesn't get a good uptake.
We have decided we want to instead target January for release.
Done When

[x] We have a date for release of the survey
[ ] This has been communicated to relevant stakeholders

Thu 9th Jan confirmed.


Api calls should return more info than a boolean variable

Most of the Api calls return a boolean variable to indicate if it was successful. I want to display the error message from the server in my java api testing app.
I will fix this for Android as well.

This was fixed a while ago.

Hi everyone,
Where is there documentation for these results objects?

This is not on the web side. This is on the java API side. Specifically for the java API testing application I made.

public class UploadInfo {
public int dataSetId = -1;
public int mediaId = -1;
public int projectId = -1;
public String errorMessage = "Failure";
public Boolean success = false;
};
This was the class I made to pass back the results from the web api calls in the java api to the testing app.

The issue was the server was passing back a lot of information to the java API but the java API was only returning true or false to the testing app. I made this object to pass back some more information that the server returned. That way if it fails to upload I can get the error message or if it succeeds I can get the id of the data set or media object.

/api/v1/docs
On Jan 26, 2015 5:21 PM, "Fred Martin"<EMAIL_ADDRESS>wrote:

Hi everyone,
Where is there documentation for these results objects?
--
Reply to this email directly or view it on GitHub
https://github.com/isenseDev/iSENSE-API/issues/8#issuecomment-71550966.

http://isensedev.github.io/iSENSE-API/Java-iSENSE-API-1.0/doc/edu/uml/cs/isense/api/API.html - Java API docs auto generated with eclipse.
http://isensedev.github.io/iSENSE-API/Java-iSENSE-API-1.0/doc/edu/uml/cs/isense/api/UploadInfo.html
This page is for this object.


[STA-495] Create tax rates for 2023 Open API

Description
Add 2023 tax rates for Singapore
Release Notes

Keep inline with Xero accounting application

Screenshots (if appropriate):
Types of Changes

[ ] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

@RettBehrens Could you please add the do-not-merge label, as the planned release date for this is 1 Dec as per the release schedule.

Hey @MichaelTranXero merging this to the spec does not make it immediately available in our 6 SDKs as those are regenerated and deployed manually. With enum updates we try to have the value added in a release ahead of time to avoid breaking the serialize/deserialize on a GET call. That said, I can wait until the week before thanks giving to action this update, but I'll want it released to all 6 SDKs before I'm offline for the week of thanksgiving to be on the safe side of not missing the mark


A few good changes to incorporate

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Replace/remove Init-focused content in @obewds/vue-el files

Replace/remove Init-focused content in @obewds/vue-el files so all can be removed after init:as is/was run.

Resolved: https://github.com/obewds/vue-el/commit/a450ebe3e877b107c2545647f5b8b645a88b4ad4


Update dependencies

And some other little cleanups

Thank you @lu-zero!

Released as v0.2.0: https://crates.io/crates/toml-cfg/0.2.0


does not import the values in columns with a header which is not a single word

The gem works perfectly importing all the data BUT the data contained in columns named with two words.
Example
the data in the column "animated" is correctly imported
the data in the column "linkUrl" (displayed in the CSV as "Link Url") in ignored
changing the header in the CSV to linkUrl does not work either.
Any ideas?
Thank you!

The column "Link URL" is going to be converted to :linkurl in the row hash.


Not Working on windows

Its Not Working on windows

Congratulations for the most useful bug report ever 🎉

https://github.com/cocur/background-process/pull/23


Whitespace Improvements

Issue
There's no whitespace between the docker logo and the version. Everything else has nice spacing apart from that.
Screenshot

Environment
Spaceship version: 3.2.0
Zsh version: zsh 5.4.2 (x86_64-apple-darwin17.3.0)
Zsh framework: oh-my-zsh
Zsh plugin manager: antigen
Terminal emulator: iTerm2
Operating system: macOS
Font: Meslo LG L DZ for Powerline
Relevant .zshrc
n/a

This is related to Unicode character rendering of your terminal emulator and this is documented on Troubleshooting page.
Closing this now, Feel free to reopen if there is anything else.

I feel the troubleshooting page could have also included a workaround "add more spaces yourself", for those terminals that don't support configuring character widths.
In this particular example, one could put this in their .zshrc and define as many spaces as needed to make it look nice:
export SPACESHIP_DOCKER_SYMBOL="🐳         "

Thanks for the prompt reply @salmanulfarzy. The trouble shooting page helped me out. All fixed! What I didn't realise is that I could use Fira Code as the terminal font. The README gave off the impression I had to stick with a Powerline font.
Cheers!

Current we required powerline font only for SPACESHIP_GIT_SYMBOL and Firacode indeed supports powerline characters from v0.6.


Embracing the Product Mindset

If anyone wants to spend their three working days in the sprint working with Plutarch on a smart contract protocol that is pushing the absolute limits of PlutusCore and practical design patterns on Cardano, than please feel free to reach out.
The project is Midgard, an optimistic rollup scaling solution where the state of the layer 2 lives in a smart contract on the Cardano L1, and a very, very large number of validators collectively ensure the correctness of the transitions of the L2 state data.

I appreciate the goal of fostering a deeper understanding of the product domain among our engineers.  Personally I'd be happy to explore the ecosystem and learn from it.
However, I'd also like to highlight the importance of not overdoing this activity, the same way it doesn't make much sense for a product role to go and invest more time learning engineering, except maybe some low hanging low investment opportunities which deliver useful high-level insights / learnings.

I appreciate the goal of fostering a deeper understanding of the product domain among our engineers. Personally I'd be happy to explore the ecosystem and learn from it.
However, I'd also like to highlight the importance of not overdoing this activity, the same way it doesn't make much sense for a product role to go and invest more time learning engineering, except maybe some low hanging low investment opportunities which deliver useful high-level insights / learnings.

Regardless of whether anyone decides to spend the time on Midgard or not, I think it would be helpful if during those three days you could pair-program with an experienced smart contract developer. Many of these developers would benefit greatly from the plutus core team being empathetic to the pains of production smart contract development on Cardano, and as such have a big incentive to offer to pair (myself included). I can recommend a number of such developers who would be willing to do such a pairing, and personally I would be happy to.


Generalize marshalSelfLinkFromMetadata

We ended up adding some custom functionality to our hal plugin by extending the existing Hal.php. We also use the metadata to marshal links of other links than 'self' links. Would it be possible to generalize the marshalSelfLinkFromMetadata to marshalLinkFromMetadata with as default value for $relation 'self'. This allows users to use the method for rendering other links with the same method.

Merged to develop for release with 1.1.


Resolve syncing conflicts from privateToPublicToPrivate-pr-conflict-working to privateToPublicToPrivate-pr-conflict

Pull request opened by Docs to resolve syncing conflicts from privateToPublicToPrivate-pr-conflict-working to privateToPublicToPrivate-pr-conflict.

Docs Build status updates of commit 3b742e6:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 816784a:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 96a8098:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 398a49f:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 987cd70:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 6e79184:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 1bf7a27:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 3b7c40c:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Create DNS alias for showcase

Order the following domains.

Domain
Stage
Application

onyx.schwarz
prod
Docs

storybook.onyx.schwarz
prod
Storybook

dev.onyx.schwarz
dev
Docs

dev.storybook.onyx.schwarz
dev
Storybook

Although we currently only have DEV deployments, they should temporarily be linked to onyx.schwarz and storybook.onyx.schwarz until we have a prod stage. This is to prevent users from bookmarking the dev URLs in the meantime

Currently waiting for DNS team to create the domains and SSL certificates

New ticket: NSR4306239


Update README.md

Q
A

Bug fix?
no

New feature?
no

New sample?
no

Related issues?
-

What's in this Pull Request?
Used for taking screenshots on the PR submission process.

Hi @VesaJuvonen, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Vesa Juvonen). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Created for showing template handling and to take screenshots on the process.

Was used for template demo. Closed for now.


remove depguard

Summary
This linter is failing.

coverage: 69.347%. remained the same when pulling 77fe013baa6f7ce723295487fe341e741568ef3c on cdoxsey/depguard into d4a75bbdb237253578301353b0d2f3c0110b3089 on main.


Change default for Razor Class Libraries to be component class libraries that work with client and server

The work here is to add an option to the Razor Class Library template to include or exclude the ASP.NET Core Shared Framework

@danroth27 any progress in here?
All runtime work is done already, other than switching the default.
https://github.com/aspnet/AspNetCore/blob/master/src/ProjectTemplates/Web.ProjectTemplates/content/RazorClassLibrary-CSharp/.template.config/template.json#L56

Related VS tracking issue: https://developercommunity.visualstudio.com/idea/575690/show-checkbox-option-for-aspnet-core-razor-class-l.html

What's the status on this? The issue you filed hasn't gone anywhere, so I assume it's blocked?

The VS issue is no longer relevant. We can now surface UI for template options ourselves through template authoring like we are doing for the "hosted" option for the Blazor WebAssembly App template. So there should be nothing blocked here.


Undertale [PCSB01157]

Game summary

Game name: Undertale
Game serial: PCSB01157

Vita3K summary

Version: v0.1
Build number: 240-f804620
Commit hash: https://github.com/vita3k/vita3k/commit/3137d1f

Test environment summary

Tested by: Zangetsu38
OS: Windows 10 17.134.5
CPU: AMD Ryzen 7 2700X
GPU: Nvidia MSI GTX 1080 Ti Trio
RAM: 16 GB DDR4

Issues
On Decrypted version Keep rose screen with spam infinite loop after last pr stub net
[02:46:38.964] |I| [write_file]:  *** TTY: libnetctl event: XXX, state = Disconnected
[02:46:39.072] |I| [write_file]:  *** TTY: libnetctl event: XXX
On Mai Dump crash after open few file.
Screenshots
Not for moment
Log
Mai Decrypted vita3k.log
Mai Dump vita3k.log
Recommended labels
Crash

Vita3K summary

Version: v0.1
Build number: 696
Commit hash: https://github.com/vita3k/vita3k/commit/b915fa1

Test environment summary

Tested by: waterflame
OS: Windows 7
CPU: Intel i7-2600
GPU: AMD Radeon HD 6700 Series
RAM: 8 GB

Issue
It now soft locks on load.
Screenshot

Log
vita3k.log

Same report on USA version, full works now, just is slow and bad sound

Vita3K summary

Version: v0.1.5
Build number: 2680
Commit hash: https://github.com/vita3k/vita3k/commit/6dd6576d
CPU backend: Dynarmic

Test environment summary

Tested by: othmanead
OS: Windows 11
CPU: Intel i5-10300H
GPU: RTX 3060 mobile
RAM: 16 GB

Issue:

Game plays with no issues

Screenshots:

Log
vita3k.log
Recommended labels

Playable


Properly define the members of spv_position_t

The message consumer takes a struct spv_position_t as a parameter to help indicate which part of the code caused the message to be generated.  This is nice except that the members are not well defined and, as a result, are used inconsistently.
For example, the member line, is used to related the line number in the OpLline instruction associated with an instruction in replace invalid opcode (replace_invalide_opc.cpp:163).  However, the ir loader, line is used as the number of the instruction in the spir-v file (ir_loader.cpp:42).
To make the matter more confusing, the validator uses the index member in the same way that the ir loader uses line.  Then other places uses index to be the number of bytes into the binary file (linker.cpp:687).
We need to fix the design to make it more consistent.

I've been thinking about this.  In general, spirv-tools asks on spir-v binary files.  A line number and column number do not make sense for the binary file.  So anytime the messages refers to a location in a binary file it should use the index field.  That will be interpreted as the instruction index the same way it is used by the validator.
If the message want to refer to a position original source file, say an hlsl source file or spvasm file, that is available through the debug information then it can use the line and column fields.  However, for this to make sense, we will also need a new field that contains the name of the file.
If we go with this idea there would be a few changes that are needed:

[ ] Add comments to the header file defining spv_position_t to describe the fields.
[ ] Add a filename field to position
[ ] Update the message consumers to output the information in a meaningful way including dxc and shaderc
[ ] Update places that generate messages to place information in the correct fields.  The biggest one is the validator, and it should not require too many change because its behaviour already matches the design.

@antiagainst  @greg-lunarg @dneto0 @dj2 Let me know if there is a reason this will not work in any of the other projects that use spirv-tools.


Support shadow DOM

Currently variables are generated in this fashion:
:root {
  --scale-0: 1rem;
  --scale-1: 1.125rem;
  --scale-2: 1.25rem;
  --scale-3: 1.5rem;
  --scale-4: 1.875rem;
  --scale-5: 2.25rem;
  --scale-6: 3rem;
  --scale-7: 3.75rem;
  --scale-8: 4.5rem;

Would it be possible to omit :root { to support scoped usage? Eg. in shadow DOM.

Upon further reading, it seems :host { is recommended over :root { for this very reason.

Ah okay good catch. Is :host supported in all evergreens, and functionally the same as :root outside shadow dom? If so happy to accept a PR. Definitely keen to support shadow dom if there’s no cost to the majority use case.
Otherwise it’d be trivial to make the selector used configurable, which might be a good idea regardless actually, no matter what default we ship

Only IE doesn't like it. https://caniuse.com/?search=%3Ahost
The only difference between :root and :host AFAIK is that the latter is scoped to the element where it's used.

In that case it wouldn’t work in shadow dom anyway would it? Because the :host would be global? I don’t really know though, I’d need to test.
I think a good first step would be making the selector configurable, but only if there’s value in it. At least it would be a non-breaking change

The :host option works in shadow DOM just like it would outside of it. That's how I'm using Pollen. I copy pasted the css and changed :root to :host. Unfortunately that prevents me from using CDN, which is why I opened this issue. 😅

Gotcha, didn’t realise you could link a style sheet in shadow dom. You’d still need to duplicate that link in every shadow root, but I’d that’s workable happy to support it.
Opening up the selector used as a config option would make this a non-breaking change, but not sure if that config is actually useful or if it’s just noise. So might be better to just change to host if there are absolutely zero ramifications or differences outside shadow dom

I would consider it a breaking change since there's a theoretical possibility that someone could be loading pollen inside an element without the intention of scoping it.
The solution to that scenario is to load pollen where you need it. For 99% that would be in html->head->link.
https://css-tricks.com/saving-the-day-with-scoped-css/


Fixed packages script install custom repo for llvm-3.7 on Ubuntu 14.04

This is for #663
https://www.youtube.com/watch?v=XMe0PTYDnXw

Coverage increased (+0.002%) to 71.457% when pulling e46d3cb47cc0757021d946dbdc832cc204009045 on apavlo:master into f9238733916b3f42c0ed7e947b4a1c3ce24f846e on cmu-db:master.

Is there a reason for the dependency on LLVM 3.7 specifically?  As you've already clearly noticed, it adds a minor complication to the build system and binary versions of that package are not supplied in the official upstream repositories for several supported platforms.  I expect that the situation will get even worse over time.


"--gpus N" option must be at the end of the command line

If the "--gpus n" option is in the middle of the command line, the parameter next to "N" is also taken as a part of the gpus option.. that complains about a bad argument. With this functioning, to make it working, it must be at the end of the command line.

Hi @EtienneAb3d,
Yeah, I confirm that if an argument can contain multiple values, it must be at the end of the command line.
This is required by the argparse Python library that we use for parsing command line arguments.
Andrea

If this is a comma-separated value, wouldn't it be possible to handle it as a single value: no space in it, only one token.

Hello @EtienneAb3d,
I'm just writing to add some more details on this.
You can actually use an argument with multiple values in the middle of your command.
The only constraint is that arguments with multiple values must occur after all positional arguments.
For instance, you can run something like this:
./mmt create en it examples/data/train/ --neural --gpus 0 1 2 3 --steps clean_tms preprocess --debug
But you can not run something like this:
./mmt create en --gpus 0 1 2 3 it examples/data/train/ --neural
because the parsing library can not understand if positional arguments it and examples/data/train/ are
a part of the –gpus argument or separate arguments.
Your suggestion would be a good alternative. For the time being, however, we would like to keep the syntax as it is, since it is the argparse default behaviour (and it is quite a standard convention).
However, thank you for your feedback and your great support!
I am closing this issue now. As usual, if you need more details on this topic, feel free to re-open it :)
Andrea


Remove editor splash screen with sponsors logo

The Godot Project Leadership Committee has decided to update the sponsoring
tiers so that the Platinum Sponsorship no longer includes a logo on the
editor splash screen.
This lets us reclaim the editor splash screen space for community-related
content instead of sponsors (e.g. a different community-designed splash
screen for each stable branch?).

For the record, this has been in discussion and approved by the PLC for several months, but we wanted to wait for existing sponsorships (typically paid for a year) to expire before changing the terms of what the Platinum Sponsorship provides. The remaining active Platinum Sponsor approved the change.

Cherry-picked for 3.5.

Cherry-picked for 3.4.1.


[fix](alter table property) fix alter property if rpc failed

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.16 seconds
stream load tsv:          512 seconds loaded<PHONE_NUMBER>9 Bytes, about 139 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          66 seconds loaded<PHONE_NUMBER> Bytes, about 15 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size:<PHONE_NUMBER>6 Bytes

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.23 seconds
stream load tsv:          512 seconds loaded<PHONE_NUMBER>9 Bytes, about 139 MB/s
stream load json:         21 seconds loaded<PHONE_NUMBER> Bytes, about 107 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size:<PHONE_NUMBER>7 Bytes


Rockets crash

having an issue when running after starting the script rcs is enable and it tries to land upside down engine is facing up and goes to full throttle

After a bit of debug switching rockets fixed it the default SatX ship that comes preinstalled with KSP doesn't like the script


https://dubbo.incubator.apache.org/ is very slow

Can't bear. Please fix it asap. Thanks very much!

Yes, I have encountered the same issue. I think the problem here is it loaded all the pages, including the documentation/blog posts, when access for the first time.
We should support on demand load of such pages.

Fixed.

Still slow

http://dubbo.apache.org/#/docs/user/quick-start.md?lang=en-us

In the documentation page, by default it will load all the documentation. I think this cause the slow page load. I will reopen this issue.


Long messages are cut off in irc

Hey Raine, This seems to be another client specific thing.
When using IRCCloud, a very long message is split across several messages.

This also usually works for me in Pidgin. Which client are you using @raine?

How about when using gitter? Will people who use irc clients get long messages in multiple parts?
Sent from my iPhone
--
Raine

On 21.11.2015, at 18.56, Eric Eastwood<EMAIL_ADDRESS>wrote:
Hey Raine, This seems to be another client specific thing.
When using IRCCloud, a very long message is split across several messages.
—
Reply to this email directly or view it on GitHub.

Yes, usually long messages are broken up into multiple IRC messages.

@raine Are you still running into this?
There was a couple fixes to splitting mesages a while ago. I suspect you were running into the colon : issue looking at your screenshots which was fixed in that PR https://github.com/gitterHQ/irc-bridge/pull/67


Kafka source pod keep recreating for multi-partition kafka topic

Describe the bug
Kafka source pod fails to Terminate on default heartbeat and keeps recreating the pods when configured with Kafka topic which is having multiple partitions.
To Reproduce
Local environment setup:

Installed Minikube locally
Added Numaflow to the cluster from https://numaflow.numaproj.io/quick-start/#installation
Added helm chart of Kafka from here: https://bitnami.com/stack/kafka/helm
Created a Kafka topic with the name input-topic-partition and the config looks like the below (having 2 Partitions).

Pipeline:
Installed a sample Kafka pipeline consisting of 3 vertices with the name sample-kafka-pipeline,

Kafka source vertex to read the message from a Kafka topic
UDF to do some processing over the message (set the expression to always true)
Kafka sink to push message to a different Kafka topic

kind: Pipeline
metadata:
  name: sample-kafka-pipeline
spec:
  # Kafka Pipeline
  vertices:
    # Sources
    - name: input
      source:
        kafka:
          brokers:
            - 'local-kafka-0.local-kafka-headless.default.svc.cluster.local:9092'
          topic: input-topic-partition
          consumerGroup: numaflow-consumer-group

    # User defined functions
    - name: filter-messages
      udf:
        builtin:
          name: filter
          kwargs:
            expression: 1 < 100

    # Sinks
    - name: output-sink
      sink:
        kafka:
          brokers:
            - 'local-kafka-0.local-kafka-headless.default.svc.cluster.local:9092'
          topic: output-topic

  # The relationship between the vertices
  edges:
    - from: input
      to: filter-messages
    - from: filter-messages
      to: output-sink

Steps to reproduce the behaviour:

After installing the pipeline in the cluster (in default namespace), add a few messages to the topic input-topic-partition.
Wait for some time so that numaflow-controller will kill those vertices pods because of 10 heartbeats.
Trigger a new message again and watch the pods in the cluster.
Can be seen that multiple pods keep recreating with the name prefix sample-kafka-pipeline-input-*

Expected behaviour
There should be one pod for the source as configured. but the pods keep creating whenever the controller tries to Terminate the pods and create those back.
Screenshots
Pods:

Logs:
kubectl logs sample-kafka-pipeline-input-0-jahju

kubectl logs sample-kafka-pipeline-daemon-9cb96c99f-gwhrb

Environment (please complete the following information):

kubeletVersion: v1.25.3
Minikube: v1.28.0
Numaflow: v0.7.2

Additional context
Add any other context about the problem here.

Message from the maintainers:
Impacted by this bug? Give it a 👍. We often sort issues this way to know what to prioritize.

it looks like this is a problem due to auto-scaling. since this is a test env with very low TPS, the auto-scaling is causing this nuisance. Could you please try with auto-scaling turned off https://numaflow.numaproj.io/user-guide/autoscaling/#numaflow-autoscaling ?

Thanks @vigith, for looking at the issue.
To add to your point, what I observed is that auto-scaling is working fine with all other vertices and also with this Kafka source vertex when it is configured with a Kafka topic of a single partition. Seems like auto-scaling is failing to scale down and up when the partition is more than one.
Btw I will check to turn off auto-scaling for that vertex and come back with my observation.

We do use numaflow autoscaling on multi partitioned Kafka in production. Please let us know what behavior you see.

it looks like this is a problem due to auto-scaling. since this is a test env with very low TPS, the auto-scaling is causing this nuisance. Could you please try with auto-scaling turned off https://numaflow.numaproj.io/user-guide/autoscaling/#numaflow-autoscaling ?

Tried turning off auto-scaling for the source pod only keeping everything else as before, works fine(recreation not happening). All other pods are Terminating and coming back as expected and the Kafka source pod is keep running.
Though we might require auto-scaling for kafka sources as well in production.

we do run with autoscaling in production with a multi partitioned topic. how many partitions do you have in your topic?
and whats the TPS in the topic?

I had set the partitions to 2 and TPS should not be the issue as I am testing this locally with just <5 messages moreover the issue occurs if the pods are ideal and hit 10 heartbeats.

Investigation Notes
I use a k3d cluster to try to reproduce the issue.
When I specify my input kafka topic to have 2 partitions, when there is the no traffic, the source vertex DOES NOT scaled down to 0 pod. When 1 partition, it can scale down to 0.
I didn't see the pod re-creating case.

Hey @bichitra95 ,
Thank you for raising this issue.
As mentioned above, I was able to replicate the issue in which the Kafka source vertex is unable to scale down to 0 pods even when there are no input messages. This is due to an error in our pending Kafka message calculation, specifically when there are multiple Kafka input topic partitions but few messages, resulting in some partitions being empty. This miscalculation affects our auto-scaling feature.
I have addressed this issue by submitting a PR that fixes the bug. You can find more details about the fix in the PR: #666
Unfortunately, I was unable to reproduce the problem of the pod continuously recreating itself. However, I believe it could be related to the bug I just fixed. We provide a nightly build for numaflow, so once my PR is merged, you can try it out to see if the recreating issue persists.
Please let me know if you require any additional assistance with this issue.
Thanks,
Keran Yang

Thanks, @KeranYang for the PR. I will try to test once the PR gets merged.


Improve community health

There is no material to encourage community participation. We need to add all of it

[x] license
[x] Contribution guide
[x] README
[x] issue template
[x] pull request template
[x] Code of Conduct.

License and README were added in #8.
As this repo will probably be merged with another component it may be enough for the time being.

https://github.com/EGI-Foundation/nagios-plugins-bdii provides files that can be used to implement this.

all done.


only source utils.sh if exist

test existing utils.sh before sourcing it

ok, done. But author doesn't looks like it's interested in


Add profile for NEO SmartPlug/Button device

Type of Change

[ ] WWST Certification Request

If this is your first time contributing code:

[ ] I have reviewed the README.md file
[ ] I have reviewed the CODE_OF_CONDUCT.md file
[ ] I have signed the CLA

[ ] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com

[ ] Bug fix
[x] New feature
[ ] Refactor

Checklist

[x] I have performed a self-review of my code
[ ] I have commented my code in hard-to-understand areas
[ ] I have verified my changes by testing with a device or have communicated a plan for testing
[ ] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change
CHAD-14507
Add a new profile in the matter-switch driver for NEO plug + button device (see WWSTCERT-4757). Note that this profile was originally going to be added by PR 1799, but that PR was split into two, so that the profile could be expediated into production to support the WWST certification.
Summary of Completed Tests

This is the only profile that is needed, right? I noticed there were a few more in the other PR, but I assume those were just added for completeness, not for other WWST devices

Yes, that's correct. The other profiles will be added by PR 1807.


Use valid code signing certificate to prevent SmartScreen blockage

Description of the new feature/enhancement

Windows Defender SmartScreen tried to block installation of container-desktop on my work laptop. In my environment I am allowed to disregard this but not everyone might be allowed due to group policies and such.
Proposed technical implementation details (optional)
I believe if you purchase a valid code signing certificate from a known CA SmartScreen will stop complaining.

I know, but those certificates are very expensive. Since this is an open source project and not backed by an organization it is too expensive for us.

@rouke-broersma  more details can be found at the FAQ:  https://container-desktop.io/v1.0.4/faq/faq/

Sorry I just have missed that.


UI Performance Issue with Secrets

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

Open chrome developer tools, goto "Network" tab, sort by size.
Navigate to your cluster project homepage
All secrets are pulled from an API call regardless if you're viewing a route on the ui that displays secrets.

Result:
Homepage of cluster (workloads shown) fetches all project level secrets. This causes, in my scenario, 8MB of
data to be returned via v3/project/c-vtxqr:p-n8f7b/namespacedsecrets?limit=-1&sort=name
This is causing very slow initial page loads (upwards of 60s)
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):
Installation option (single install/HA):
2.5.5 via k3s

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported):
Machine type (cloud/VM/metal) and specifications (CPU/memory):
Kubernetes version (use kubectl version):

(paste the output here)

Docker version (use docker version):

(paste the output here)

This is part of the data model for Cluster Manager to track relationships between resources and secrets (among other common types that are always loaded on page load) and is not going to change.
The Cluster Explorer UI does less of this in general with a few more efficient ways in the API it uses to track relationships.
But for types where some related info is needed that aren't covered by that, "n" calls to get individually referenced records quickly becomes slower than loading the whole set.  And for the list pages the only way to do arbitrary sorting/filtering/paging/live updating is to have the whole collection in memory, render the appropriate subset and update it from watch events.


Select field question

Regarding this line: https://github.com/martndemus/ember-form-for/blob/66180d8d8175e896cc477c805fa3a68a02f6f0c6/addon/components/form-controls/select.js#L92
On select, you select the object that is clicked -> if I pass in optionValuePath, should it not set the Ember.get(object, optionValuePath) as the value? If not, is there a default way of doing this?

Ah, this code has been removed in master.


[wanda] change cache prefix to z-

so that we can use prefix for more aggressive ecr tag garbage collection for non-cache, temp tags.

the idea is that we will recycle all 0-9a-f in like 3 days, and z- ones in maybe longer periods.
this allow us to cache longer (like switch back to 1-week cache) but won't hit the tag per image limit.

Is there a way to tell ecr to clean up old tag automatically?

Or clean old tags programmatically before retag? This re-cycling logic for tagging might be hard to debug and maintain?

Discuss offline, it's actually not that hard to understand and maintain

this is basically to separate the cache's tag namespace from the non-cache, temp tag namespace in terms of prefix space.
after the change, cache tag namespace has prefix 'z-', and non-cache, temp tags have [0-9a-z]