Implement cleaner for unused ips

If ip is not being used by any service - remove it from a link

IPs cleanup on service removal https://github.com/Mirantis/k8s-externalipcontroller/pull/25 was merged. Now, IPs removal on service update should be implemented.

IPs cleanup on service update https://github.com/Mirantis/k8s-externalipcontroller/pull/32 was merged. Integration test and some refactoring is included in there. So, this task can be closed.


add functional tests to travis

It's possible to have Travis CI use Docker for builds. Would be great if we could get the functional tests working with a full Postgres instance.

closed in #234


Attempt to read property "name" on null in Manage Company

Providing only your error message doesn't really help me track down what the issue could be. Can you provide more context on when this error occurs? Can you provide the stacktrace for me? Is this error with the latest release? Everything is working perfectly fine for me when visiting the "Manage Company" page. Have you created a company? If you have created a company, is the "name" column in the database null even though you provided a name when creating one?

I'm sorry, I managed to solve it, apparently when making the changes and migrations something was not done correctly with my db but I executed the php artisan migrate:fresh command and it was solved


24 intake

I'll take care of the conflicts.

Removed intakeStatus and wheelsStatus variables since you said that was just for testing. Not necessary anymore since your code works.


return data after adding fields

should fix #3, not tired it though.

Please correct me if I'm wrong but I'm certain this won't change anything at all.
the extend() helper allows you to work with the return value but doesn't do anything with that you return https://github.com/flarum/core/blob/c6aeeeb3c1d5cf92c586c9f8ee43d2127d0fb933/js/lib/extend.js#L27 Because the object is passed as reference the changes from any extensions should be preserved.
You would have to use override() for that. I notice that you create a "copy" of the object and return it in the recaptcha extension. I believe this code does nothing, you could just add the value directly to the original object.

Thanks for the heads up, in this case I'm going to use override instead, altering the reference seems hacky and not very clean.

I notice that you create a "copy" of the object and return it in the recaptcha extension. I believe this code does nothing, you could just add the value directly to the original object.

yea, my old linter used to say to do not do anything to input parameters.


Multiple logging fixes, including #126 and #134

See each commit to get the gist of it.

Actually Stoa doesn't respect the log level either...


Alps ygilquin multiresolution geometry

Same as #79, but in the correct branch

 All committers have signed the CLA.


bug: ion-tab-button doesn't call navigation when active

Bug Report
Ionic version:
[x] 5.x
Current behavior:
If you have ion-tabs setup like below.
<ion-tabs>

  <ion-tab-bar slot="bottom">
    <ion-tab-button tab="tab1" class="ion-activatable ripple-parent">
      <ion-icon name="home"></ion-icon>
      <ion-label>Dashboard</ion-label>
      <ion-ripple-effect></ion-ripple-effect>
    </ion-tab-button>

    <ion-tab-button tab="tab2" class="ion-activatable ripple-parent">
      <ion-icon name="search"></ion-icon>
      <ion-label>Search</ion-label>
      <ion-ripple-effect></ion-ripple-effect>
    </ion-tab-button>

    <ion-tab-button tab="tab3" class="ion-activatable ripple-parent">
      <ion-icon name="key"></ion-icon>
      <ion-label>Keys</ion-label>
      <ion-ripple-effect></ion-ripple-effect>
    </ion-tab-button>

    <ion-tab-button tab="tab4" class="ion-activatable ripple-parent">
      <ion-icon name="settings"></ion-icon>
      <ion-label>Settings</ion-label>
      <ion-ripple-effect></ion-ripple-effect>
    </ion-tab-button>

  </ion-tab-bar>

</ion-tabs>

And navigate to "tab2", which has the following child routes.
const routes: Routes = [
  {
    path: "",
    component: Tab2Page,
    children: [
      {
        path: "search",
        children: [
          {
            path: "",
            loadChildren: () =>
              import("../pages/search/search.module").then(
                (m) => m.SearchPageModule
              ),
          },
        ],
      },
      {
        path: "issue/:issue",
        children: [
          {
            path: "",
            loadChildren: () =>
              import("../pages/search/detail/detail.module").then(
                (m) => m.DetailPageModule
              ),
          },
        ],
      },
      {
        path: "",
        redirectTo: "/tabs/tab2/search/issue",
        pathMatch: "full",
        data: { index: 0 },
      },
    ],
  },
  {
    path: "",
    redirectTo: "/tabs/tab2/search/issue",
    pathMatch: "full",
    data: { index: 0 },
  },
];

Navigate to /tabs/tab2/issue/1234
Now Click tab2
Nothing appears to happen.

Expected behavior:
When clicking on an active tab I would expect that it navigate to the base route for that tab. In the above example this would be /tabs/tab2.
Steps to reproduce:
It's pretty well documented above.

Your routes are quite messy, one of the issue for tab2 is that you don't have a default ** route. I'd suggest instead of using the children array just write them out on top level with their own path having
    path: "**",     component: Tab2Page, at the bottom as a default path.

@NikolaPeevski Thanks for the response.  I changed all the children so they look like this.
{
        path: "search",
        loadChildren: () =>
          import("../pages/search/search.module").then(
            (m) => m.SearchPageModule
         ),
},

And I added
{ path: "**", component: Tab2Page },

This doesn't fix the issue. When I click on tab2 in an active state the route doesn't change.

@selected-pixel-jameson Can you provide me with a full repo I can take a look at ?

@NikolaPeevski Sorry. This if for a private commercial project. I can't share the source code.

This is my tab2-routing.module.ts.
import { NgModule } from "@angular/core";
import { RouterModule, Routes } from "@angular/router";

import { Tab2Page } from "./tab2.page";

const routes: Routes = [
  {
    path: "",
    component: Tab2Page,
    children: [
      {
        path: "search",
        loadChildren: () =>
          import("../pages/search/search.module").then(
            (m) => m.SearchPageModule
          ),
      },
      {
        path: "issue/:issue",
        loadChildren: () =>
          import("../pages/issue-detail/issue-detail.module").then(
            (m) => m.IssueDetailPageModule
          ),
      },
      {
        path: "issue/:original/variants",
        loadChildren: () =>
          import("../pages/search/detail/detail.module").then(
            (m) => m.DetailPageModule
          ),
        data: { store: "issue", endpoint: "issues", id: "original" },
      },
      {
        path: "series/:series",
        loadChildren: () =>
          import("../pages/search/detail/detail.module").then(
            (m) => m.DetailPageModule
          ),
        data: { store: "issue", endpoint: "series", id: "series" },
      },
      {
        path: "series/:series/publisher/:publisher",
        loadChildren: () =>
          import("../pages/search/detail/detail.module").then(
            (m) => m.DetailPageModule
          ),
        data: { store: "issue", endpoint: "series", id: "series" },
      },
      {
        path: "category/:category",
        loadChildren: () =>
          import("../pages/search/detail/detail.module").then(
            (m) => m.DetailPageModule
          ),
        data: { store: "issue", endpoint: "categories", id: "category" },
      },
      {
        path: "character/:character",
        loadChildren: () =>
          import("../pages/search/detail/detail.module").then(
            (m) => m.DetailPageModule
          ),
        data: { store: "issue", endpoint: "characters", id: "character" },
      },
      {
        path: "publisher/:publisher",
        loadChildren: () =>
          import("../pages/search/detail/detail.module").then(
            (m) => m.DetailPageModule
          ),
        data: { store: "series", endpoint: "publishers", id: "publisher" },
      },
      {
        path: "artist/:artist",
        loadChildren: () =>
          import("../pages/search/detail/detail.module").then(
            (m) => m.DetailPageModule
          ),
        data: { store: "issue", endpoint: "artists", id: "artist" },
      },
      {
        path: "writer/:writer",
        loadChildren: () =>
          import("../pages/search/detail/detail.module").then(
            (m) => m.DetailPageModule
          ),
        data: { store: "issue", endpoint: "writers", id: "writer" },
      },
      {
        path: "",
        redirectTo: "/tabs/tab2/search/issue",
        pathMatch: "full",
        data: { index: 0 },
      },
      { path: "**", component: Tab2Page },
    ],
  },
  {
    path: "",
    redirectTo: "/tabs/tab2/search/issue",
    pathMatch: "full",
    data: { index: 0 },
  },
  { path: "**", component: Tab2Page },
];

@NgModule({
  imports: [RouterModule.forChild(routes)],
  exports: [RouterModule],
})
export class Tab2PageRoutingModule {}

This is the tabs-routing.module.ts
import { NgModule } from "@angular/core";
import { RouterModule, Routes } from "@angular/router";
import { TabsPage } from "./tabs.page";
import { AuthGuard } from "../core/services/guards/auth.guard";

const routes: Routes = [
  {
    path: "tabs",
    component: TabsPage,
    children: [
      {
        path: "tab1",
        loadChildren: () =>
          import("../tab1/tab1.module").then((m) => m.Tab1PageModule),
      },
      {
        path: "tab2",
        loadChildren: () =>
          import("../tab2/tab2.module").then((m) => m.Tab2PageModule),
      },
      {
        path: "tab3",
        loadChildren: () =>
          import("../tab3/tab3.module").then((m) => m.Tab3PageModule),
      },
      {
        path: "tab4",
        loadChildren: () =>
          import("../tab4/tab4.module").then((m) => m.Tab4PageModule),
      },
      {
        path: "",
        redirectTo: "/tabs/tab1/dashboard/1",
        pathMatch: "full",
      },
    ],
  },
  {
    path: "",
    redirectTo: "/tabs/tab1/dashboard/1",
    pathMatch: "full",
  },
];

@NgModule({
  imports: [RouterModule.forChild(routes)],
  exports: [RouterModule],
})
export class TabsPageRoutingModule {}

{ path: "", component: Tab2Page }, ->   { path: "", component: Tab2Page, pathMatch: "full" },

@NikolaPeevski  https://angular.io/guide/lazy-loading-ngmodules

@NikolaPeevski I see what you are saying. I'll give that a try and see what I get.

Sure, hmu with the results.

I got it working. Thank you for your help @NikolaPeevski

@selected-pixel-jameson Awesome, this is closable now I guess..?


[CARBONDATA-86] Value displayed as Null after increase in precision for decimal datatype after aggregation

Problem: While creating a table if user specifies a precision for decimal datatype column and then executes an aggregation query on that column then in case if after aggregation the precision of the resulted value becomes greater than the user configure precision value, spark displays the aggregated value as null
Fix: Set the precision of the aggregated result as the precision for the decimal type while sending the aggregated result to spark

LGTM


Language verification testing and general feedback - Spanish

Background on the problem the feature will solve/improved user experience
The Five Fifths Voter site has been translated into twelve languages. The project is looking for you to verify the translated strings
for Spanish on the website. Multiple contributors are welcome to participate.
Describe the solution you'd like
Click through the site and verify correctness in Spanish.
Tasks

Create an issue for corrections required.
Take a screenshot of the error and add to the issue.
Describe the error in the issue and recommended changes.

Acceptance Criteria
The fix address any grammatical issues and spelling mistakes in the translations.
@demilolu @Sabine-Justilien

Hi @upkarlidder , I am an IBMer from Mexico, so I can help with this! I could also help fixing the error that could be found.
I would only need to know exactly which text I would need to verify. I can only find this: https://www.fivefifthsvoter.com/ and I am not sure that is the correct one.

Wonderful and thanks @alanverdugo! Are you in the call for code workspace? Can you please ping @Sabine-Justilien and she can get you the link. I am out on vacation this week. I will msg you when I get back. Thanks again!
Fyi @demilolu


Profile Updated in UDBHAV

Updated my profile in data.js file

HERE IS A PREVIEW: https://anand911.github.io/sushiksha-first-contributions/Teams/udhbhav.html


Crash when i clean the Trash

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS Version: [e.g. Windows 10 1903 18362.175]
App version: [v0.11.0]

Additional context
Add any other context about the problem here. Does this problem occur again after restarting the app?
Log file
Please upload the log file here so that we can understand your issue better. You can access it from Settings->About->Open log location. You can also find this file by going to %localappdata%\Packages\49306atecsolution.FilesUWP_et10x9a9vyk8t\LocalState, you should see a file in this directory called debug.txt or/and debug_fulltrust.txt.

Please upload the log file here so that we can understand your issue better. You can access it from Settings->About->Open log location. You can also find this file by going to %localappdata%\Packages\49306atecsolution.FilesUWP_et10x9a9vyk8t\LocalState, you should see a file in this directory called debug.txt or/and debug_fulltrust.txt.

2021-02-20 17:01:05.8865|INFO|.ctor|App launched|
2021-02-20 17:01:06.3273|INFO|.ctor|Drive added: C:, Fixed|
2021-02-20 17:01:06.3651|INFO|.ctor|Drive added: D:, Fixed|
2021-02-20 17:01:06.4097|INFO|.ctor|Drive added: E:, Removable|
2021-02-20 17:01:06.4425|INFO|.ctor|Drive added: F:, Removable|
2021-02-20 17:01:06.4756|INFO|.ctor|Drive added: X:, Network|
2021-02-20 17:01:06.5111|INFO|.ctor|Drive added: Y:, Network|
2021-02-20 17:01:06.5469|INFO|.ctor|Drive added: Z:, Network|
2021-02-20 17:01:09.3892|INFO|.ctor|Running on ARM: False|
2021-02-20 17:01:58.8518|ERROR|.ctor|Null strings may not be marshaled in Windows Runtime arguments.
Parameter name: sourceString|System.ArgumentNullException: Null strings may not be marshaled in Windows Runtime arguments.
Parameter name: sourceString
at System.Runtime.InteropServices.McgMarshal.StringToHStringReference(Char*, String, HSTRING_HEADER*, HSTRING*) + 0xd3
at __Interop.ForwardComStubs.Stub_133[TThis, TArg0](_ComObject, TArg0, String, Int32) + 0x8b
at Files.UserControls.StatusCenter.StatusCenter_obj17_Bindings.Update_FullTitle(String, Int32) + 0x9a
at Files.UserControls.StatusCenter.StatusCenter_obj17_Bindings.Update(StatusBanner, Int32) + 0x61
at Files.UserControls.StatusCenter.StatusCenter_obj17_Bindings.ProcessBindings(Object, Int32, Int32, Int32&) + 0x11e
at Windows.UI.Xaml.Markup.IDataTemplateComponent__Impl.Vtbl.ProcessBindings__n(IntPtr, Void*, Int32, Int32, Int32*) + 0x64
at System.Runtime.InteropServices.McgMarshal.ThrowOnExternalCallFailed(Int32, RuntimeTypeHandle) + 0x21
at __Interop.ComCallHelpers.Call(__ComObject, RuntimeTypeHandle, Int32) + 0xb8
at __Interop.ForwardComStubs.Stub_19[TThis](__ComObject, Int32) + 0x24
at Microsoft.AppCenter.Utils.ApplicationLifecycleHelper.<.ctor>b__17_1(Object, UnhandledErrorDetectedEventArgs) + 0x3d
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x21
at Microsoft.AppCenter.Utils.ApplicationLifecycleHelper.<.ctor>b__17_1(Object, UnhandledErrorDetectedEventArgs) + 0x75
at System.EventHandler`1.Invoke(Object, TEventArgs) + 0x2e
at __Interop.Intrinsics.HasThisCall__24[TArg0](Object, IntPtr, Object, TArg0) + 0x36
at Files!+0x14958f0
2021-02-20 17:02:04.0773|INFO|.ctor|App activated|
2021-02-20 17:02:04.5903|INFO|.ctor|Drive added: C:, Fixed|
2021-02-20 17:02:04.6312|INFO|.ctor|Drive added: D:, Fixed|
2021-02-20 17:02:04.6761|INFO|.ctor|Drive added: E:, Removable|
2021-02-20 17:02:04.7145|INFO|.ctor|Drive added: F:, Removable|
2021-02-20 17:02:04.7507|INFO|.ctor|Drive added: X:, Network|
2021-02-20 17:02:04.7842|INFO|.ctor|Drive added: Y:, Network|
2021-02-20 17:02:04.8221|INFO|.ctor|Drive added: Z:, Network|
2021-02-20 17:04:01.0061|INFO|.ctor|Running on ARM: False|
Rui Oliveira
www.linkedin.com/in/ruiolliveirahttps://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.linkedin.com%2Fin%2Fruiolliveira&data=02|01||5c7de4e64f294d0ebe6b08d69be7b527|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636867817415950429&sdata=lM3wp0U8Hm%2B8F6oacPYuZJw4NVg3aoAHEoLYgxkc37Q%3D&reserved=0
www.instagram.com/ruiolliver/http://www.instagram.com/ruiolliver/
www.twitter.com/rui_olliveirahttps://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.twitter.com%2Frui_olliveira&data=02|01||5c7de4e64f294d0ebe6b08d69be7b527|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636867817415970439&sdata=OXAG7%2FpBvxC00tmwnvTN7NYuoMxBTpoHu4HfkhxwyMU%3D&reserved=0
Telegram: busque por @ruiolliver
De: Marco<EMAIL_ADDRESS>Enviado:sábado, 20 de fevereiro de 2021 17:17
Para<EMAIL_ADDRESS>Cc:Rui do Nascimento de<EMAIL_ADDRESS><EMAIL_ADDRESS>Assunto: Re: [files-community/Files] Crash when i clean the Trash (#3658)
Please upload the log file here so that we can understand your issue better. You can access it from Settings->About->Open log location. You can also find this file by going to %localappdata%\Packages\49306atecsolution.FilesUWP_et10x9a9vyk8t\LocalState, you should see a file in this directory called debug.txt or/and debug_fulltrust.txt.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ffiles-community%2FFiles%2Fissues%2F3658%23issuecomment-782743363&data=04|01||dc649143c7034594ebc108d8d5dc94d5|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637494490650358121|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=HhVQ%2FCKFGnifNCNlfqTeFX8Nmh1TB%2Fx4hevAkfsZndA%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOAX25OZ7SMUZLUQJM6KNNTTAAKGNANCNFSM4X6GIVWA&data=04|01||dc649143c7034594ebc108d8d5dc94d5|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637494490650368116|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Lf1rINtdNBpRPQ5VA5iX%2Fmo9z7PkKVcQ5YLkTZLTLME%3D&reserved=0.

Related/Duplicate: https://github.com/files-community/Files/issues/3493

OS Version: [e.g. Windows 10 1903 18362.175]
I think you NEED to upgrade to at least 1909 as 1903 is end of life since december (https://docs.microsoft.com/en-us/lifecycle/announcements/windows-10-1903-end-of-servicing)
App version: [v0.11.0]
If you are still using the v0.11, upgrade to the last publised version asap.
The v1.2.2 is known to have an issue with opening the recycle bin, but this is fixed in 1.2.3 and 1.3.
And there is no crash with emptying recycle bin in v1.3.

Merging with #3493.

This is a completely different stack trace from #3493 , so reopening

@rui-n-oliveira is this an issue in v2.0.34?

no problem for me in 2.0.42


Duplicate index argument in PHP templates for Nginx

The various PHP templates that overrides the index block add too much information since the prefix index and the end-of-line colon are already present in default-site.j2.
This result in a corrupted Nginx configuration file.

Dropped in favor of #134


Update how-to-deploy-a-custom-theme-in-sharepoint.md

Fixed link to SharePoint Team Blog: Show off your style with SharePoint theming
Category

[x] Content fix
[ ] New article
Related issues: fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?
Fixed link to SharePoint Blog article.
Guidance
N/A

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/general-development/how-to-deploy-a-custom-theme-in-sharepoint.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

thx Simon, appreciated.


Add CI to the project

We have some Ruby scripts in the repo that can perform some testing for us, but there's not a ton of things that it covers. Let's discuss the hurdles to be leaped in this issue and design an approach:

What's the state-of-the-art for testing these sort of plugins for Vim?
Can we automate the testing of the syntax rendering?
Is there a particular service / GitHub action that works "the best"?
Is there a way for it to be run locally as well? (Creating a PR just to run the tests is annoying)
Will the errors be clear to the developer so they can easily understand what needs fixing?
What's the appropriate minimum to test? We should avoid testing "too much" and venture into the world of flakey tests.

Anything else?

@ches and anyone else... let's get some expert advice on this one :)

I would recommend taking a look at some of ALE's CI infrastructure—I don't agree with all the style guidelines, but they have a very comprehensive test suite.


Use PSR-1 for PHPUnit TestCase

Use PSR-1 while extending PHPUnit TestCase class. This will help us when to migrate to PHPUnit 6, that no longer support snake case namespaces.

Have you tested this with PHPUnit 6? I highly doubt that these 2 lines are the only changes we'd need to make it work. Your brief PR description is the only place where PHPUnit 6 is mentioned and that really makes it seem you're suggesting this only for the sake of PSR-compliance.

@narfbg These are not the only changes that PHPUnit 6 has. Only change the namespaces are the first steps. PHPUnit has deprecated methods, requires PHP 7, etc. If you want, I can work on that in master branch :smile:

Just so you know, we only merge in master after releases. For anything else - target develop, or 3.1-stable if the patch only applies to 3.1.x.
But that aside, this still looks like just changes for the sake of PSR compliance. If PHPUnit 6 requires PHP 7 and we don't ... why would we want to work towards PHPUnit 6?
I mean, if the changes don't break PHPUnit 5 - sure, maybe give v6 support to whoever wants it, but it a) is that the case?; and b) if so, make it work entirely.

@narfbg I'll change to develop branch, and work on that migration in another PR :sweat_smile:


Barback should allow secondary inputs to be overwritten

Right now, if a transformer reads a secondary input and emits an output with the same name, that's considered an error, since the output conflicts with the pass-through version of that asset. This should instead be allowed as long as the output asset is read by the transformer as a secondary input (it's already allowed for primary input, since those are consumed and rendered unavailable).

This issue has been moved to dart-lang/barback#17.


add basic github templates

Hey I was the guy that responded about possibly contributing back.
I figured I would go ahead and start off by helping with some basic GitHub templates to make collecting issues, requests and PRs a little cleaner and more organized.
I submitted my thoughts on a few templates tailored a bit for a  swift project. Let me know your thoughts.
You can see what these will look like in my fork https://github.com/LucasCarioca/ToastUI/issues/new/choose

Thank you so much for your first contribution. I truly appreciate it. I've read all the templates and have some thoughts:

but_report_template.md has a typo. It should just be bug_report.md to be consistent with the name that GitHub sets by default when you create the template.
Add a full stop to all inline comments that consist of more than one sentence.

Alright sounds good ill make the file name change.
Not sure what you mean by this though:

Add a full stop to all inline comments that consist of more than one sentence.

Add a full stop to all inline comments that consist of more than one sentence.

I meant block comments, sorry for being wordy here. I just made suggested changes in #1.
Moreover, I'm seeing in #2, bug_report.md still has typo in its filename. Could you fix that?

Oops totally overlooked that. Fixed as well.

Moreover, I'm seeing bug_report.md still has typo in its filename in the last commit. Could you fix that?

Anymore changes on this?

@LucasCarioca Apologies for my tardy response. Looks all good to me! Once again, thank you so much for your suggestion and contribution.


Russian localization

Just adding the Russian locale for Munkireport

Why did you remove the english language file?
Could you send the pull request against the wip branch.

Arjen, I'm sorry, that was a mistake, my bad!
Please, cancel it I'll do it right this time around in wip branch!


dodo-starterkit: npm install dodo-starterkit does install to wrong place if path doesn't have node_modules

If directory where going to install doesn't have node_modules, npm will find first node_modules lower in path and run installer there...

Found out only ugly way to prevent this, by requiring INSTALL_PATH environment variable to be set to directory where project is initialized... If there is no way to around this with npm, maybe I need to toss install with npm idea away completely...
something like this :(
INSTALL_PATH=$PWD npm install ../../dodo-starterkit

Fixed for now... Gladly this feature is used so rarely that setting install_path and template variables is not big issue... Sadly this is usually the first touch with end user giving bad impression.


Add Login and Contact page to StudentzSynergy website

Issue Type

[x] Feature Request

Description
The StudentzSynergy website doesn't have a Login and Contact page
Proposed Solution (For Feature Requests)
Creation of Login and Contact page
Tasks

[ ] Create the Login page using Html, Css and Js.
[ ] Create the Contact page using Html, Css and Js.

I would like to work on this issue, So please assign it to me.

assigned to you @AmanSingh494

@AmanSingh494  any update,
you've havent raised any pr yet?

@AmanSingh494 any update, you've havent raised any pr yet?

I have made login page and working on contact page.

okay i have raise a pr for home page #30
@AmanSingh494

any update @AmanSingh494 ?

any update @AmanSingh494 ?

I will create a pull request today

Hey @AmanSingh494 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇

Hey @AmanSingh494 ! Thank you so much for your raising the issue💗 It’s all yours, you can come anytime again and make some contributions! 🚀 Alone, we can do little, but together we can do so much! 😇

Thanks @4darsh-Dev , I would love to make more contributions.


CB-4455. Support shipping Freeipa logs to cloud storage.

Support fluentd log shipping for freeipa:

as different logs needs to be monitored, different input.conf.j2 is used for freeipa and cm salt definitions (those are merged on salt-common scripts, see: https://github.com/hortonworks/cloudbreak/pull/6582)
altus iam service is moved to auth-connector, and that is used directly from core & freeipa
fill identity in cloud stack object for freeipa (that should work with both s3 and abdfs, tested only s3 for now)
make freeipa telemetry support disabled by default (maybe it can be changed later)
machine user creation is happening during salt config creation (we can access credentials once, we do not want to pass that really anywhere), the machine user deletion happening in a flow step (not too strict so i did not add a failed event there)

update: i will movethe machine user deletion stuff to stack termination flow

manual tests:

delete was done successfully
s3 output looks like this:


Adds upcoming features to top of README.

Fixes #69
Named this Upcoming Features.

@parkjam4 hey jimmy, what do you think of this format? We want to tell users that only JARs  are supported now and not WARs so we're including this section in here to tell everyone what we don't support yet (but in a nice positive coming-soon way :smile:).


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 3.0.37 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


jaraco.context 6.0.0

{package} {version} {:snowflake:}
Destination channel: {Snowflake | defaults}
Links

{ticket_number}
Upstream repository
Upstream changelog/diff
Relevant dependency PRs:

...

Explanation of changes:

...

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_26057sy4r7/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:43: missing_description: The recipe is missing a description
clone/recipe/meta.yaml:42: invalid_url: https://jaracocontext.readthedocs.io/ : Not reachable: 403
===== Final Report: =====
0 Errors and 2 Warnings were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_03ff537jov/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:42: invalid_url: https://jaracocontext.readthedocs.io/ : Not reachable: 403
clone/recipe/meta.yaml:43: missing_description: The recipe is missing a description
===== Final Report: =====
0 Errors and 2 Warnings were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_b2h3222ej_/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:43: invalid_url: https://jaracocontext.readthedocs.io/ : Not reachable: 403
clone/recipe/meta.yaml:44: missing_description: The recipe is missing a description
===== Final Report: =====
0 Errors and 2 Warnings were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_1ed4w_c5xh/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:43: invalid_url: https://jaracocontext.readthedocs.io/ : Not reachable: 403
clone/recipe/meta.yaml:44: missing_description: The recipe is missing a description
===== Final Report: =====
0 Errors and 2 Warnings were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_3bshc4pe3_/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:44: missing_description: The recipe is missing a description
clone/recipe/meta.yaml:43: invalid_url: https://jaracocontext.readthedocs.io/ : Not reachable: 403
===== Final Report: =====
0 Errors and 2 Warnings were found


responsive bug (left-sidebar)

When you narrow your window, the left-sidebar (with the list of streams) disappears to leave more space.
At this point there are two symptoms:
-When you click on the "3 points menu" of one of the top navigation-menu, if you click on one of this item a menu is supposed to appear ("mark all messages as read" for example), in our case, this menu is badly display (only for the top filters, the stream menu is displayed normally).

-The other symptoms is that the sidebar also disappears at the same time (if you do the same thing with a stream, this sidebar will not disappear).

For more clarity, attached two gifs showing the two bugs and the link to the discussion

@zulipbot claim


Automatically Run CI and Upload lib to Charmhub when merged to main

Description
This adds a workflow file to automatically run CI and upload lib to Charmhub when merged to main.
Checklist

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have made corresponding changes to the documentation.
[x] I have added tests that validate the behaviour of the software.
[x] I validated that new and existing unit tests pass locally with my changes.
[x] Any dependent changes have been merged and published in downstream modules.
[x] I have bumped the version of any required library.

This will need a CHARMCRAFT_AUTH secret


Migrate from unmaintained xz2 to liblzma

Hello,
It seems xz2 is unmaintained and the maintainer has stepped down: https://github.com/alexcrichton/xz2-rs/issues/128#issuecomment-2214139875. https://github.com/Portable-Network-Archive/liblzma-rs seems to be the replacement, including a newer version of xz, wasm support and test updates.
I've kept the module called xz2 for now. All tests still pass.

Hmmm it seems that the fork is done about 10 months ago, I'm worried about if the maintainer is malicious just like the one in xz-utils.
I suggest that to add it as a separate feature lzma-new, xz-new, people who trust the new maintainer can opt-in to it, while other remains on xz-rs which is outdated but trusted.
If eventually there's enough evidence that the new fork is trustworthy then we'd switch the existing feature to use the fork.
cc @Nemo157 @robjtede

potentially calling the new module LibLzma and LibLzmaXz?

I prefer lower-kerbab-case, otherwise it looks good to me

I prefer lower-kerbab-case, otherwise it looks good to me
Oh, I meant the modules, not the features

Oh, I meant the modules, not the features

For modules, I think lower_case makes sense

Hmmm, it looks like having them added concurrently won't work, even if neither are enabled, since they both link lzma :(.
If you don't have any ideas, I'm fine with just using [patch].

Yes, I was attempting to do that, but it seems cargo will refuse to have both of them as a dependency (even optional?) because of the links field (doc):

The links field is used to ensure only one copy of a native library is linked into a binary. The resolver will attempt to find a graph where there is only one instance of each links name. If it is unable to find a graph that satisfies that constraint, it will return an error.

Ohh right I forgot that😅
That's unfortunate, so maybe we can guard the fork against a custom cfg cfg(liblzma_fork)?
That'd allow us to only enable one of the dependency, without introducing new features.

Agreed, I'm apprehensive to swap it out completely, but a cfg-based approach to the fork would be acceptable.

cc @xbjfk We discussed about this and we think using cfg(async_compression_unstable_liblzma_fork) to guard against the new fork makes sense.
That'd allow us to only pull one version of it, and remove it in the future without breaking backwards compatibility.

@NobodyXu thanks, I agree and think that is the best way forward.
I'm still confused on how to satisfy cargo - I'll make my PR a draft so that we can test things out, and push my failed attempt at getting them to both be features.

I'm still confused on how to satisfy cargo

I think you can do
[target.'cfg(not(async_compression_unstable_liblzma_fork))'.dependencies]
xz = ...

[target.'cfg(async_compression_unstable_liblzma_fork)'.dependencies]
xz-fork = ...

I think you can do

Thanks!
Unfortunately, cargo seems to still complain about the linkage :(. I've just pushed my code with the cfg option.
Manually adding/removing a dependency seems to work however, and all tests still pass.

@xbjfk I think maybe we should open an issue in rust-lang/cargo?
It seems that the linkage - the dependency resolution is done before cfg selection?
It's originally intended for cfg target expression, so I kind of understand why it doesn't work, but I believe this can be supported in cargo.

Yeah, I agree.
This does seem simpler for cargo to support than linkage conflicts between optional dependencies.


Bug - Error 404 on working RTSP source

Which version are you using?
v0.21.6
Which operating system are you using?

[X] Linux amd64 standard
[ ] Linux amd64 Docker
[ ] Linux arm64 standard
[ ] Linux arm64 Docker
[ ] Linux arm7 standard
[ ] Linux arm7 Docker
[ ] Linux arm6 standard
[ ] Linux arm6 Docker
[ ] Windows amd64 standard
[ ] Windows amd64 Docker (WSL backend)
[ ] macOS amd64 standard
[ ] macOS amd64 Docker
[ ] Other (please describe)

Describe the issue
Description Please closed issue https://github.com/aler9/rtsp-simple-server/issues/1607 which Github keeps closing
Describe how to replicate the issue

start the server
publish with ...
read with ...

Did you attach the server logs?

yes
Did you attach a network dump?

yes

replied in #1607


Purpose of String#keyify

May I find out the purpose of String#keyify? It seems to me that you are doing what String#to_sym does?

It'll make sense when the code is done. :)


OSC 52 support

OSC 52 to copy

Do not forget https://github.com/tmux/tmux/wiki/Clipboard#terminal-support---kitty about config
https://chromium.googlesource.com/apps/libapps/+/master/nassh/doc/FAQ.md#Is-OSC-52-aka-clipboard-operations_supported

Implemented in https://github.com/dluciv/cccp/commit/16fd49a04ec327121906c7c055088993208e7fba


Instanceof check in resolveType bug

I have created a test case that reproduces the bug outlined in issue #362.
I have been searching for a solution to this bug for quite a while but I cannot find it unfortunately.
I was wondering if someone could help me locate and fix this bug:)

Any update on the status of this PR?

Hmm, looking at this reproduction nothing comes to mind right away as a reason this would be broken. I'd appreciate if you could take one more look to see if you can find the cause!

Hey @stubailo! The bug does seem to be well hidden;) No problem, I will take another look as soon as I find some time!

Hey @stubailo. I fixed the bug! Turns out that when merging the mocked and resolved value returned from the resolve function that the prototype of the resolved values was not passed to the newly created merged object.


Getting redirection forbidden error occasionally

Since today I noticed that sigh fails to download profile from time to time. Upgrading sigh to latest 0.5.2 didn't help.
The stack trace looks like this. Probably this is a timeout, I can't say for sure.
[18:01:35]: Login into iOS Developer Center
[18:01:49]: Login successful
[18:01:49]: Fetching all available provisioning profiles...
[18:01:50]: Checking if profile is available. (21 profiles found on page 1)
[18:01:51]: Downloading profile...
/Users/****/.rvm/rubies/ruby-2.0.0-p643/lib/ruby/2.0.0/open-uri.rb:223:in `open_loop': redirection forbidden: https://developer.apple.com/account/ios/profile/profileContentDownload.action?displayId=45HB57MMCL -> http://developer.apple.com/account/selectTeam.action (RuntimeError)
	from /Users/****/.rvm/rubies/ruby-2.0.0-p643/lib/ruby/2.0.0/open-uri.rb:149:in `open_uri'
	from /Users/****/.rvm/rubies/ruby-2.0.0-p643/lib/ruby/2.0.0/open-uri.rb:689:in `open'
	from /Users/****/.rvm/rubies/ruby-2.0.0-p643/lib/ruby/2.0.0/open-uri.rb:34:in `open'
	from /Users/****/.rvm/gems/ruby-2.0.0-p643/gems/fastlane_core-0.7.5/lib/fastlane_core/developer_center/developer_center_helper.rb:17:in `download_file'
	from /Users/****/.rvm/gems/ruby-2.0.0-p643/gems/sigh-0.5.2/lib/sigh/developer_center.rb:271:in `download_profile'
	from /Users/****/.rvm/gems/ruby-2.0.0-p643/gems/sigh-0.5.2/lib/sigh/developer_center.rb:95:in `block in maintain_app_certificate'
	from /Users/****/.rvm/gems/ruby-2.0.0-p643/gems/sigh-0.5.2/lib/sigh/developer_center.rb:75:in `each'
	from /Users/****/.rvm/gems/ruby-2.0.0-p643/gems/sigh-0.5.2/lib/sigh/developer_center.rb:75:in `maintain_app_certificate'
	from /Users/****/.rvm/gems/ruby-2.0.0-p643/gems/sigh-0.5.2/lib/sigh/developer_center.rb:18:in `run'
	from /Users/****/.rvm/gems/ruby-2.0.0-p643/gems/sigh-0.5.2/lib/sigh/manager.rb:6:in `start'
	from /Users/****/.rvm/gems/ruby-2.0.0-p643/gems/sigh-0.5.2/bin/sigh:36:in `block (2 levels) in run'
	from /Users/****/.rvm/gems/ruby-2.0.0-p643/gems/commander-4.3.4/lib/commander/command.rb:178:in `call'
	from /Users/****/.rvm/gems/ruby-2.0.0-p643/gems/commander-4.3.4/lib/commander/command.rb:178:in `call'
	from /Users/****/.rvm/gems/ruby-2.0.0-p643/gems/commander-4.3.4/lib/commander/command.rb:153:in `run'
	from /Users/****/.rvm/gems/ruby-2.0.0-p643/gems/commander-4.3.4/lib/commander/runner.rb:428:in `run_active_command'
	from /Users/****/.rvm/gems/ruby-2.0.0-p643/gems/commander-4.3.4/lib/commander/runner.rb:68:in `run!'
	from /Users/****/.rvm/gems/ruby-2.0.0-p643/gems/commander-4.3.4/lib/commander/delegates.rb:15:in `run!'
	from /Users/****/.rvm/gems/ruby-2.0.0-p643/gems/sigh-0.5.2/bin/sigh:67:in `run'
	from /Users/****/.rvm/gems/ruby-2.0.0-p643/gems/sigh-0.5.2/bin/sigh:74:in `<top (required)>'
	from /Users/****/.rvm/gems/ruby-2.0.0-p643/bin/sigh:23:in `load'
	from /Users/****/.rvm/gems/ruby-2.0.0-p643/bin/sigh:23:in `<main>'

Can you update sigh to the pre-release by running sudo gem update sigh --pre and let me know if that solves the issue?

I'm installing sigh as a native extension dependency for another in-house gem. Actually, the whole fastlane.
"fastlane", "~> 1.3.1"

Is there a way to specify pre-release in the naive extensions config?
If not I'll figure out the way to do it manually and see how it goes.

@mgrebenets probably by specifying 1.0.0.beta2

I will try, thanks.
Actually, error message varies as well, just got his one
security: failed to add data to decoder: UNKNOWN (-8183(d)
security: problem decoding
/Users/****/.rvm/gems/ruby-2.0.0-p643/gems/sigh-0.5.2/lib/sigh/profile_analyser.rb:7:in `run': undefined method `count' for nil:NilClass (NoMethodError)

Will let you know how it goes with beta.

@KrauseFx
Trying with beta3 atm. I noticed that team_id option changed, not I have to use the one that matches string displayed in Member Center. However, this time I get No existing profiles found, creating a new one for you message. But I can clearly see a number of certificates in developer portal.
In my case I want to download existing provisioning profile. The profile is for In-House (Enterprise) distribution and wildcard app id, so my command is something like this
sigh --username myappleid --team_id TEAMID --provisioning_name "Enterprise In House Profile" --app_identifier "*" --skip_install

@mgrebenets The team ID should be the same. Could you try updating sudo gem update spaceship to be sure to use the latest version?
The error message you mentioned: Are you talking about certificates or profiles?
I tried installing it on Ruby 2.0.0. Which version doesn't work? Could you share more error information?

OK, here's a bit more info.
Installing beta on 2.0.0 doesn't look like an issue, I tried again and it installed with no problem.
However, here's what I have with sigh version 0.5.2 vs 1.0.0-beta3.
I am using RVM and selected 2.2.2 as current ruby, but got the same results with 2.0.0-p643 as well.
gem list sigh
# sigh (1.0.0.beta3, 1.0.0.beta1, 0.5.2)

sigh -v
# sigh 0.5.2

Then I go to developer portal, my account is member of In-House (Enterprise) and AppStore teams, I select Enterprise team. I go and have a note of team ID there.

So I'm trying command like this
sigh --username myappleid \
--team_id ENT_TEAM_ID_FROM_MEMBER_CENTER \
--provisioning_name "Enterprise In House" \
--app_identifier "*" --skip_install

It fails with this error
[22:44:32]: Login into iOS Developer Center
[22:44:45]: Could not find given Team. Available options:
1. "DEV_TEAM_ID_FROM_SIGH" My Company (iOS Developer Program)
2. "ENT_TEAM_ID_FROM_SIGH" My Company Pty Ltd (iOS Developer Enterprise Program)
[22:44:45]: Error finding given team ENT_TEAM_ID_FROM_MEMBER_CENTER.

It also creates a screenshot of "Select Team" web page.
OK, so I use ENT_TEAM_ID_FROM_SIGH as a team ID and then it works, while still failing occasionally with error which I described in the very first message. This is successful output.
[22:50:28]: Login into iOS Developer Center
[22:50:46]: Login successful
[22:50:48]: Fetching all available provisioning profiles...
[22:50:49]: Checking if profile is available. (21 profiles found on page 1)
[22:50:51]: Downloading profile...
[22:50:52]: Successfully downloaded provisioning profile
[22:50:52]: Provisioning profile of app 'Xcode: Wildcard AppID' with the name 'Enterprise In House' successfully generated and analysed.
./Distribution_*.mobileprovision

Now I want to try with pre-release beta. So I'm removing 0.5.2 version of sigh.
gem uninstall sigh --version 0.5.2
# Successfully uninstalled sigh-0.5.2

gem list sigh
# sigh (1.0.0.beta3, 1.0.0.beta1)

sigh -v
# /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/spaceship-0.0.4/lib/spaceship/app.rb:68: warning: circular argument reference - bundle_id
# /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/spaceship-0.0.4/lib/spaceship/app.rb:68: warning: circular argument reference - name
# /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/spaceship-0.0.4/lib/spaceship/certificate.rb:228: warning: circular argument reference - csr
# sigh 1.0.0.beta3

gem list spaceship
# spaceship (0.0.4)

gem update spaceship
# Updating installed gems
# Nothing to update

This time I actually get 3 warnings every time I call sigh, which you can see above.
Anyway, now I'm trying again to download provisioning profile, just like I did it before
sigh --username myappleid \
--team_id ENT_TEAM_ID_FROM_SIGH \
--provisioning_name "Enterprise In House" \
--app_identifier "*" --skip_install

But I get this error (I've added few newlines there)
/Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/spaceship-0.0.4/lib/spaceship/app.rb:68: warning: circular argument reference - bundle_id
/Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/spaceship-0.0.4/lib/spaceship/app.rb:68: warning: circular argument reference - name
/Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/spaceship-0.0.4/lib/spaceship/certificate.rb:228: warning: circular argument reference - csr
[22:52:19]: Starting login
[22:52:22]: Successfully logged in
/Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/spaceship-0.0.4/lib/spaceship/client.rb:386:in
`parse_response': {"responseId"=>"3c606f03-f609-4987-86b8-89284e7a661b", "resultCode"=>3100,
"resultString"=>"No team found for teamId 'ENT_TEAM_ID_FROM_SIGH' ",
"userString"=>"Unable to find a team with the given Team ID 'ENT_TEAM_ID_FROM_SIGH' to which you belong.
Please contact Apple Developer Program Support.\nhttps://developer.apple.com/support",
"creationTimestamp"=>"2015-06-01T12:48:10Z", "protocolVersion"=>"QH65B2", "requestId"=>nil,
"userLocale"=>"en_US",
"requestUrl"=>"https://developerservices2.apple.com/services/QH65B2/ios/listProvisioningProfiles.action",
"httpCode"=>200} (Spaceship::Client::UnexpectedResponse)
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/spaceship-0.0.4/lib/spaceship/client.rb:285:in `provisioning_profiles'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/spaceship-0.0.4/lib/spaceship/provisioning_profile.rb:224:in `all'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/spaceship-0.0.4/lib/spaceship/provisioning_profile.rb:245:in `find_by_bundle_id'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/lib/sigh/spaceship/runner.rb:57:in `fetch_profiles'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/lib/sigh/spaceship/runner.rb:15:in `run'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/lib/sigh/manager.rb:8:in `start'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/bin/sigh:36:in `block (2 levels) in run'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/commander-4.3.4/lib/commander/command.rb:178:in `call'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/commander-4.3.4/lib/commander/command.rb:178:in `call'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/commander-4.3.4/lib/commander/command.rb:153:in `run'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/commander-4.3.4/lib/commander/runner.rb:428:in `run_active_command'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/commander-4.3.4/lib/commander/runner.rb:68:in `run!'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/commander-4.3.4/lib/commander/delegates.rb:15:in `run!'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/bin/sigh:67:in `run'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/bin/sigh:74:in `<top (required)>'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/bin/sigh:23:in `load'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/bin/sigh:23:in `<main>'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/bin/ruby_executable_hooks:15:in `eval'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/bin/ruby_executable_hooks:15:in `<main>'

OK, so I try to use team ID which is displayed in member center.
sigh --username myappleid \
--team_id ENT_TEAM_ID_FROM_MEMBER_CENTER \
--provisioning_name "Enterprise In House" \
--app_identifier "*" --skip_install

This time it seems to be able to find a team ID, but then I'm told there are no provisioning profiles at all. Even though I just got list of 21 profiles with 0.5.2 a while ago (but at that time I had to use a different team ID suggested by sigh).
/Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/spaceship-0.0.4/lib/spaceship/app.rb:68: warning: circular argument reference - bundle_id
/Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/spaceship-0.0.4/lib/spaceship/app.rb:68: warning: circular argument reference - name
/Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/spaceship-0.0.4/lib/spaceship/certificate.rb:228: warning: circular argument reference - csr
[22:56:32]: Starting login
[22:56:35]: Successfully logged in
[22:56:37]: No existing profiles found, creating a new one for you
/Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/lib/sigh/spaceship/runner.rb:113:in `certificate_to_use': Could not find a matching code signing identity for Spaceship::ProvisioningProfile::AppStore. You can use cert to generate one (https://github.com/fastlane/cert) (RuntimeError)
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/lib/sigh/spaceship/runner.rb:62:in `create_profile!'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/lib/sigh/spaceship/runner.rb:33:in `run'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/lib/sigh/manager.rb:8:in `start'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/bin/sigh:36:in `block (2 levels) in run'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/commander-4.3.4/lib/commander/command.rb:178:in `call'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/commander-4.3.4/lib/commander/command.rb:178:in `call'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/commander-4.3.4/lib/commander/command.rb:153:in `run'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/commander-4.3.4/lib/commander/runner.rb:428:in `run_active_command'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/commander-4.3.4/lib/commander/runner.rb:68:in `run!'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/commander-4.3.4/lib/commander/delegates.rb:15:in `run!'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/bin/sigh:67:in `run'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/bin/sigh:74:in `<top (required)>'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/bin/sigh:23:in `load'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/bin/sigh:23:in `<main>'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/bin/ruby_executable_hooks:15:in `eval'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/bin/ruby_executable_hooks:15:in `<main>'

Thank you so much @mgrebenets, that was the best submitted issue yet. I found the issue and have a fix live in a few minutes :rocket:

Fixed with https://github.com/KrauseFx/spaceship/commit/3bfc8e1efcf197915c3de92f62da7f0cf7f1817d, please update spaceship and let me know if that fixes the problem :+1:

Unfortunately it did not help. Here's what I get with spaceship 0.0.5.
/Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/spaceship-0.0.5/lib/spaceship/app.rb:68: warning: circular argument reference - bundle_id
/Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/spaceship-0.0.5/lib/spaceship/app.rb:68: warning: circular argument reference - name
/Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/spaceship-0.0.5/lib/spaceship/certificate.rb:228: warning: circular argument reference - csr
[23:45:56]: Starting login
[23:46:00]: Successfully logged in
[23:46:02]: No existing profiles found, creating a new one for you
/Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/lib/sigh/spaceship/runner.rb:113:in `certificate_to_use': Could not find a matching code signing identity for Spaceship::ProvisioningProfile::AppStore. You can use cert to generate one (https://github.com/fastlane/cert) (RuntimeError)
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/lib/sigh/spaceship/runner.rb:62:in `create_profile!'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/lib/sigh/spaceship/runner.rb:33:in `run'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/lib/sigh/manager.rb:8:in `start'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/bin/sigh:36:in `block (2 levels) in run'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/commander-4.3.4/lib/commander/command.rb:178:in `call'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/commander-4.3.4/lib/commander/command.rb:178:in `call'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/commander-4.3.4/lib/commander/command.rb:153:in `run'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/commander-4.3.4/lib/commander/runner.rb:428:in `run_active_command'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/commander-4.3.4/lib/commander/runner.rb:68:in `run!'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/commander-4.3.4/lib/commander/delegates.rb:15:in `run!'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/bin/sigh:67:in `run'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/bin/sigh:74:in `<top (required)>'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/bin/sigh:23:in `load'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/bin/sigh:23:in `<main>'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/bin/ruby_executable_hooks:15:in `eval'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/bin/ruby_executable_hooks:15:in `<main>'

And the same error message with that "undocumented" team ID.
/Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/spaceship-0.0.5/lib/spaceship/app.rb:68: warning: circular argument reference - bundle_id
/Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/spaceship-0.0.5/lib/spaceship/app.rb:68: warning: circular argument reference - name
/Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/spaceship-0.0.5/lib/spaceship/certificate.rb:228: warning: circular argument reference - csr
[23:45:49]: Starting login
[23:45:52]: Successfully logged in
/Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/spaceship-0.0.5/lib/spaceship/client.rb:429:in `parse_response': {"responseId"=>"aeb6845f-ac34-4973-9ab9-fa60c1435596", "resultCode"=>3100, "resultString"=>"No team found for teamId 'ENT_TEAM_ID_FROM_SIGH' ", "userString"=>"Unable to find a team with the given Team ID 'ENT_TEAM_ID_FROM_SIGH' to which you belong.  Please contact Apple Developer Program Support.\nhttps://developer.apple.com/support", "creationTimestamp"=>"2015-06-01T13:41:40Z", "protocolVersion"=>"QH65B2", "requestId"=>nil, "userLocale"=>"en_US", "requestUrl"=>"https://developerservices2.apple.com/services/QH65B2/ios/listProvisioningProfiles.action", "httpCode"=>200} (Spaceship::Client::UnexpectedResponse)
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/spaceship-0.0.5/lib/spaceship/client.rb:308:in `provisioning_profiles'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/spaceship-0.0.5/lib/spaceship/provisioning_profile.rb:224:in `all'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/spaceship-0.0.5/lib/spaceship/provisioning_profile.rb:245:in `find_by_bundle_id'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/lib/sigh/spaceship/runner.rb:57:in `fetch_profiles'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/lib/sigh/spaceship/runner.rb:15:in `run'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/lib/sigh/manager.rb:8:in `start'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/bin/sigh:36:in `block (2 levels) in run'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/commander-4.3.4/lib/commander/command.rb:178:in `call'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/commander-4.3.4/lib/commander/command.rb:178:in `call'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/commander-4.3.4/lib/commander/command.rb:153:in `run'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/commander-4.3.4/lib/commander/runner.rb:428:in `run_active_command'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/commander-4.3.4/lib/commander/runner.rb:68:in `run!'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/commander-4.3.4/lib/commander/delegates.rb:15:in `run!'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/bin/sigh:67:in `run'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/gems/sigh-1.0.0.beta3/bin/sigh:74:in `<top (required)>'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/bin/sigh:23:in `load'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/bin/sigh:23:in `<main>'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/bin/ruby_executable_hooks:15:in `eval'
	from /Users/maksym.grebenets/.rvm/gems/ruby-2.2.2/bin/ruby_executable_hooks:15:in `<main>'

Can you try again with the most recent release and let me know if that works? If it doesn't please submit a new issue, as the original issue is resolved.

I will. Can you tell me what's the relation between fastlane and sigh in terms of releases? I can see that last release for fastlane was 4 days ago, while sigh was updated just 2 hours ago.
I was planning to stick with latest fastlane version and though it would also include latest sigh.

The tools have dependencies. If I update the dependency of sigh in fastlane, sigh will also be updated when you update fastlane.


threadpool: fix thread starvation bug

Commit 0f1bdb6 ("threadpool: send signal only when queue is empty")
introduces a regression where work is not evenly distributed across
the thread pool because the work queue's condition variable is only
signalled when the queue is empty, even when there are waiting workers.
It doesn't turn into outright deadlock because there is always
at least one thread making forward progress but it does degrade
throughput, sometimes massively so.
Signalling whenever there are waiting workers fixes the throughput
issue while still keeping the number of uv_cond_signal() calls low,
which was the motivation for commit 0f1bdb6.
Fixes: https://github.com/libuv/libuv/pull/490
Fixes: https://github.com/libuv/libuv/issues/492
R=@saghul
Sorry for the delay.  I got distracted yesterday halfway through writing the commit log.
CI: https://jenkins-iojs.nodesource.com/view/libuv/job/libuv+any-pr+multi/137/

LGTM
Thanks for the fix Ben!

New release tomorrow then!


[#2148] improvement(server): Rename ShuffleBufferWithLinkedList to DefaultShuffleBuffer

What changes were proposed in this pull request?
Rename ShuffleBufferWithLinkedList to DefaultShuffleBuffer
Why are the changes needed?
Fix: #2148
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Needn't

cc @maobaolong

@zuston Would you like to solve this conflicts?


Created .md file

Learning
created a branch, created a file and made a commit, and opened a pull
request

test


As a Korifi kubectl user I want my app routes to be serviced by Gateway API resources, so that I can use any Gateway API compatible networker

Background
As the Gateway API is now v1.0.0 we should abstract the Contour newtworker away from Korifi, so that users can deploy Korifi with their own newtworker (i.e Istio).
Acceptance
GIVEN I have deployed a Gateway API compatible networker
AND I have defined a gatewayclass
WHEN I deploy Korifi by passing the gatewayclass as a networking.gatewayClass helm value
THEN I can deploy and access new apps
AND I can access existing apps without downtime
Dev Notes
In CF when we delete an app its route gets leakes by design, so that I can be reused later. This means that in Korifi the legacy httpproxy resources will not be dleted until the route is deleted. We have decided that this is not a problem for now and it is not worth adding complexity to the cf route controller to deal with this garbage. The garbage object may be deleted manually or may be clean up by deleting the route that owns them.

What's left to do:

[ ] Run go mod tidy and make sure contour references are gone
[ ] Annotate httproutes with effective uri for readability
[ ] Make sure there is no app downtime when upgrading from last relese to current state
[ ] Check if the http listener is really needed
[ ] Make sure cfroutes for legacy apps (ones that have backing httproxies) can be deleted (no finalizer is holding then back)
[ ] Remove the contourRouter.include helm value
[ ] Create a chore to cut a release and put all breaking changes in
[ ] Check if postfacto is operaitonal (if websocket support is working) once the change makes it to acceptance

[ ] Delete old http proxies and check that websockets still work


Possibility to run Fabio on Apple M1

Hi,
Is it possible to provide Fabio version that is compatible with Apple M1 arm64 architecture ?
I was checking on Docker Hub and I see that currently https://hub.docker.com/r/softwaremill/fablo image supports only linux/amd64 architecture.
Regards

Hi @Lucas1983 Fablo actually works on Apple M1 (I have one and use Fablo on daily basis). Did you try? Did you have some issues with that?

Actually it works, but while startup I constantly getting info about architecture incompatibility e.g. The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested.  Was wondering if this has any impact ob Fabio performance ?

I build the fablo containers myself for ARM.  I follow these instructions:  https://www.polarsparc.com/xhtml/Hyperledger-ARM-Build.html
I am currently running 2.4.9 using this workaround https://github.com/hyperledger-labs/fablo/issues/372#issuecomment-1382080918
Following the instructions above I was able to build fabric.  I could not build fabric-ca but I am able to run successfully with fabric-ca 1.5.6.


Exclude dune itself from DuneConstraintMissing

That is, it is ok for dune to have a dune-project file but not to depend on dune.

Sounds fair. Thanks a lot!

I was just looking at the PR thinking "we should probably exclude Dune from that check" 🙂


rtorrent-flood

I would like to se a intergration of rtorrent-flood, somelike qbittorent, added to the dashboard :-)

Hi @davidnewhall
The only thing i have is : https://github.com/jesec/flood

Thanks! We'll start there.

Iirc flood is just a UI wrapper so this is more for rurorrent in general

Closing this in favor of #236. Seems more reasonable. @klapvogn If you have an objection, I don't mind entertaining it.


How to make a-la webpack "multiple entries" scenario?

Does fuse-box support multiple entries scenario?
Like this in webpack:
// webpack config
const config = {
    entry : {
        "main": [
            path.join(SRC_PATH, "main.js")
        ],
        "admin": [
            path.join(SRC_PATH, "admin", "main.js")
        ],
        "vendor": [
            "react",
            "react-dom",
            "react-redux",
            "react-router",
            ...
        ]
    }
}

You can bundle anything without an entry point
http://fuse-box.org/#arithmetic-instructions
In essence, entry point is not required

Thanks for quick reply :)
I guess there is a lack in documentation.
My goal is not to exclude an entry point, but to have several "bundles" as output at once.
The config above defines that I after executing I want to have three output bundles:

"main.js" - one SPA application.
"admin.js" - second independent SPA application
"vendor.js" - common third-party code

Where "main" and "admin" - are separate entry points.
There's still not clear how to achieve this scenario from provided docs.
It could be fine to see some example how to do it.

Hi! I am on my phone now, but you can try using FuseBox.import() your entire bundle is available via that API

You can bundle everything using ./.** and then use
http://fuse-box.org/#import This API to call any files Within that bundle.
Or you can have 2 bundles (they will share the scope)
FuseBox provides much more flexible API than webpack :) read up :)

I'm experimenting with all it now, but without much success yet.

Use globbing to make sure it's all there, then try window.FuseBox.import

Try where? In build script or at the client side entry point file?

Again: I need two files as output, not single one.

You can access any file in a bundle (after it has been bundled) via FuseBox.import
(In browser and on server). Include it as a script tag (your bundle) open developer console and try using FuseBox.import (runtime)

As for now, I cann't see other way than simple calling FuseBox twice:
let fuseBox = FuseBox.init({
    homeDir: "js",
    cache: false,
    outFile: "_build/out1.js",
    ...
});

fuseBox.bundle(">app1/react.jsx ...", false);

let fuseBox = FuseBox.init({
    homeDir: "js",
    cache: false,
    outFile: "_build/out2.js",
    ...
});

fuseBox.bundle(">app2/react.jsx ...", false);

If you need 2 files use 2 instances (you can share your config)

That's what I guessed from beginning :(
I end up with this:
const fsbx = require("fuse-box");

const FuseBox = fsbx.FuseBox;

let config = {
    homeDir: "js",
    cache: false,
     plugins: [
        fsbx.BabelPlugin({
            config: {
                sourceMaps: true,
                presets: ["es2015", "react"]
            }
        })
    ]
}

let config1 = Object.assign({}, config, { outFile: "_build/out1.js" })
let fuseBox1 = FuseBox.init(config1);
fuseBox1.bundle(">app2/react.jsx -react -react-dom", false);

let config2 = Object.assign({}, config, { outFile: "_build/out2.js" })
let fuseBox2 = FuseBox.init(config2);
fuseBox2.bundle(">app2/react.jsx -react -react-dom", false);

Problems:

How to make third output file with all "vendor" libs? (react, react-dom, react-router etc)
So all imports should works in above main bundles?

If there's common code it will be duplicated and parsed twice :(

I guess FuseBox should support such scenario, that is provided by webpack out-of-the-box.
Seems this is not so uncommon case.

Turning caching on greatly improved re-building times:
let config = {
    homeDir: "js",
    cache: true,
     plugins: [
        fsbx.BabelPlugin({
            config: {
                sourceMaps: true,
                presets: ["es2015", "react"]
            }
        })
    ]
}

let config1 = Object.assign({}, config, { outFile: "_build/out1.js" })
let fuseBox1 = FuseBox.init(config1);
fuseBox1.bundle(">app2/react.jsx +react +react-dom", false);

let config2 = Object.assign({}, config, { outFile: "_build/out2.js" })
let fuseBox2 = FuseBox.init(config2);
fuseBox2.bundle(">app2/react.jsx +react +react-dom", false);

But how now to make 3rd-party separate "vendor" file?
Just create 3rd out file like above with some "package" config magic and all "requires" will magically work?

Finally got it working with the following:
const fsbx = require("fuse-box");

const FuseBox = fsbx.FuseBox;

let config = {
    homeDir: "js",
    cache: true,
     plugins: [
        fsbx.BabelPlugin({
            config: {
                sourceMaps: true,
                presets: ["es2015", "react"]
            }
        })
    ]
}

let config1 = Object.assign({}, config, { outFile: "_build/out1.js" })
let fuseBox1 = FuseBox.init(config1);
fuseBox1.bundle(">app2/react.jsx -react -react-dom", false);

let config2 = Object.assign({}, config, { outFile: "_build/out2.js" })
let fuseBox2 = FuseBox.init(config2);
fuseBox2.bundle(">app2/react.jsx -react -react-dom", false);

let config3 = Object.assign({}, config, { outFile: "_build/vendor.js" })
let fuseBox3 = FuseBox.init(config3);
fuseBox3.bundle("+react +react-dom", false);

But it seems like boilerplate (((
I guess there is need in some plugin like webpack's "CommonsChunkPlugin" that could handle such scenario and automatically extracts all commons into separate output bundle.
I could try to hack on this, but it seems FuseBox plugins has no API to create/specify additional output files :(

yes, currently there is only one source, but we can and will improve it :)

#312

Thanks. Will follow it. It seems promising.

Implemented in 1.4.1


Detect when binary is for the wrong architecture

Currently, cargo-flash will try to flash binaries for any architectures.
Based on the cargo information, we should be able to detect if the user tries to flash a binary compiled for an unsupported architecture, and show an error message.

This has been fixed in #1694 I believe


demo PR, please ignore

Current dependencies on/for this PR:

main

PR #55   👈

This comment was auto-generated by Graphite.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/27624

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/27624

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/29450

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/29578

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/29925

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/38431

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/76899

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/77675


Configure MongoDB with Express

Set-up mongodb module in the express server.
Provide key for the connection.

All Setup Done.


TypeError: _to_copy() takes from 2 to 3 positional arguments but 4 were given

I use the following code
from transformers import PaliGemmaForConditionalGeneration

model = PaliGemmaForConditionalGeneration.from_pretrained(
    "google/paligemma-3b-mix-224",
    torch_dtype=torch.float16,
    device_map="auto",
).eval()

from optimum.quanto import quantize, qint8, freeze

quantize(model, weights=qint8, activations=qint8)
freeze(model)

with torch.amp.autocast("cuda"):
    text_features = model.generate(
        input_ids=input_ids_batch,
        pixel_values=pixel_values_batch,
        attention_mask=attention_mask_batch,
        max_new_tokens=100, do_sample=False,
    )

it results in the error (don't pay attention to Thread[127], it is all inside trition inference server
Thread [127] had error: in ensemble 'ensemble_model', Failed to process the request(s) for model instance 'generator_0_0', message: TypeError: _to_copy() takes from 2 to 3 positional arguments but 4 were given

At:
  /usr/local/lib/python3.10/dist-packages/optimum/quanto/tensor/qbytes.py(130): __torch_dispatch__
  /usr/local/lib/python3.10/dist-packages/optimum/quanto/tensor/qtensor.py(93): __torch_function__
  /usr/local/lib/python3.10/dist-packages/transformers/models/paligemma/modeling_paligemma.py(314): _merge_input_ids_with_image_features
  /usr/local/lib/python3.10/dist-packages/transformers/models/paligemma/modeling_paligemma.py(435): forward
  /usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py(1562): _call_impl
  /usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py(1553): _wrapped_call_impl
  /usr/local/lib/python3.10/dist-packages/transformers/generation/utils.py(2982): _sample
  /usr/local/lib/python3.10/dist-packages/transformers/generation/utils.py(2024): generate
  /usr/local/lib/python3.10/dist-packages/torch/utils/_contextlib.py(116): decorate_context
  /usr/src/app/model_repository/generator/1/model.py(80): execute

On the current main, this works:
import torch
import requests

from PIL import Image
from transformers import AutoProcessor, PaliGemmaForConditionalGeneration
from optimum.quanto import quantize, qint8, freeze

model_id = "google/paligemma-3b-mix-224"

processor = AutoProcessor.from_pretrained(model_id)
prompt = "What are the cats doing ?"
url = "http://images.cocodataset.org/val2017/000000039769.jpg"
image = Image.open(requests.get(url, stream=True).raw)
inputs = processor(text=prompt, images=image, return_tensors="pt").to('cuda')

model = PaliGemmaForConditionalGeneration.from_pretrained(
    model_id,
    torch_dtype=torch.float16,
).to('cuda').eval()

quantize(model, weights=qint8)
freeze(model)

generate_ids = model.generate(**inputs, max_new_tokens=30)
print(processor.batch_decode(generate_ids, skip_special_tokens=True, clean_up_tokenization_spaces=False)[0])

But it does not work if you also quantize the activations (see #299 ).

@arseniybelkov did you empty the CUDA cache after freezing the model ? Not all saved GPU memory might have been released after quantization.

yeah, I emptied that


chore: add release-please automation

Release automation from https://github.com/googleapis/release-please
As of now, this will only create release PRs based on conventional commits. It will still be up to maintainers to actually push the release to NPM after it is merged. After we are sure the bot is doing what we are expecting, the github action will be extended to actually push releases to NPM automatically.
Changes:

Remove version.ts files
Add version.ts files to gitignore
Generate version.ts files on precompile step
Add manifest file to tell release-please what the most recent version of each package is
Add config file to tell release-please where to find each package
Change lerna version to "independent"
root package.json version is no longer relevant since packages could have different versions
Add release-please github action

Waiting on https://github.com/open-telemetry/community/issues/809


Sway Lend

What version of Wallet are you using?
0.7.2
What is happening?
after borrowing not showing borrowed balance
steps to reproduce
borrowed balance
How it should behave?
need to shhow borrowed balance
What os are you seeing the problem on?
Windows Desktop
What browser?
Brave
What is your browser version?
No response

didn't Active repay button as well


[INLONG-2271] move TDMsg to InLongMsg

Title Name: [INLONG-XYZ][component] Title of the pull request
where XYZ should be replaced by the actual issue number.
Fixes #2271
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Will TDMsg format be normal Inlong format?

@luchunliang Yes, the name of TDMsg is confused for developers. We rename it as InLongMsg, and will add more description for it.

Codecov Report

Merging #2273 (30f1d85) into master (2557dcb) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2273   +/-   ##
=========================================
  Coverage     12.54%   12.54%
  Complexity     1217     1217
=========================================
  Files           420      420
  Lines         36235    36235
  Branches       5674     5674
=========================================
  Hits           4545     4545
  Misses        30881    30881
  Partials        809      809

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2557dcb...30f1d85. Read the comment docs.


Fix compilation warning of implicit declaration of 'waitpid'

Codecov Report

Merging #24 (7e38d29) into master (1dc02fe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   96.91%   96.91%
=======================================
  Files           8        8
  Lines         518      518
=======================================
  Hits          502      502
  Misses         16       16

Flag
Coverage Δ

unittests
96.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dc02fe...7e38d29. Read the comment docs.


reproduciblity compared with vanilla pytorch

🐛 Bug
I am trying to compare a vanilla pytorch code which I refactored as a part of my learning pytorch-lightning but I see that the training_step is iterating through a different order of my dataset inspite of me setting seed_everything and deterministic=True and benchmark=False
Please reproduce using [the BoringModel and post here]
I have this as the base, common for both vanilla mode and pytorch-lightning mode:
        train_loader = torch.utils.data.DataLoader(\
        MyDataSet(cfg=cfg, mode="train"), \
                            batch_size=16, \
                            shuffle=True)

In lightning I do:
    def training_step(self, batch, batch_idx):
        x, y, paths = batch

        if Pathlib("check_input_path_pl").is_file():
            append_write = 'a+' # append if already exists
        else:
            append_write = 'w' # make a new file if not
        with open("check_input_path_pl", append_write) as f:
            f.write(str(batch_idx) + " ==> " +str(paths[0]) + "\n")

        y_hat = self(x)
        loss = self.loss_func(y_hat, y)
       return loss

in vanilla pytorch mode I do:
    for batch_idx, (data, target, paths) in enumerate(train_loader):
        data, target = data.to(device), target.to(device)
        if Pathlib("check_input_path").is_file():
            append_write = 'a+' # append if already exists
        else:
            append_write = 'w' # make a new file if not
        with open("check_input_path", append_write) as f:
            f.write(str(batch_idx) + " ==> " +str(paths[0]) + "\n")

but when I compare check_input_path  with check_input_path_pl I see that after the first epoch, the order of the input file paths is different :(
I do:
seed_everything(111)
torch.backends.cudnn.deterministic = True
torch.backends.cudnn.benchmark = False

in both vanilla and lightning mode.
Expected behavior
both should yield same order. To make a simple check, I iterate through the train_loader as soon as I create it in both pytl and pyt like so:
        for epoch in range(0, 2):
            for batch_idx, (data, target, paths) in enumerate(train_loader):
                if Pathlib("paths2load").is_file():
                    append_write = 'a+' # append if already exists
                else:
                    append_write = 'w' # make a new file if not
                with open("paths2load", append_write) as f:
                    f.write(str(batch_idx) + " ==> " +str(paths[0]) + "\n")

and in both pyt and pytl the files show the same order. yet, when training, they load in different order. What could the reason be?
Environment
pytorch-lightning==1.0.6
torch==1.6.0
torchvision==0.7.0
Debian Linux
PS: both pyt and pytl are running with the same virtualenv

Hello, just to clarify, you say that your data loader and the one inside PL do not produce the same order of samples with both set shuffle=True, correct?

@Borda exactly that.

ok, mind adding this kind of test to our parity testing?
https://github.com/PyTorchLightning/pytorch-lightning/blob/master/benchmarks/test_parity.py

@Borda I also found something else which I found a bit strange. If I seed_everything (in both pyt and pytl), and called a Dataset within which I print out np.random.rand(2,2) and torch.rand(2,2), I see that the numpy random numbers in both pyt and pytl are the same, but not for the torch random numbers. So I manually again seed everything within the dataset (then I do get the exact same numbers in pyt and pytl), but it still iterates through a different order. Strange.

ok, mind adding this kind of test to our parity testing?
https://github.com/PyTorchLightning/pytorch-lightning/blob/master/benchmarks/test_parity.py

I can, but can someone else confirm that they encounter the same problem please?

for the sake of completeness, here is the dataset classes (in case there is something unusual in what I am doing):
class ImageFolderWithPaths(datasets.ImageFolder):
    # subclass to generate path names aside from data.
    def __getitem__(self, index):
        original_tuple = super(ImageFolderWithPaths, self).__getitem__(index)
        path = self.imgs[index][0]
        tuple_with_path = (original_tuple + (path,))
        return tuple_with_path

class MyDataSet(torch.utils.data.Dataset):
    def __init__(self, cfg=None, mode=None, transform=None):
        seed_everything(111)
        torch.backends.cudnn.deterministic = True
        torch.backends.cudnn.benchmark = False

        self.labels, self.file_paths=[],[]
        self.mode=mode
        if self.mode=="train":
            data_path = Pathlib(cfg.data_root).joinpath(cfg.train_str)
        elif self.mode=="test":
            data_path = Pathlib(cfg.data_root).joinpath(cfg.test_str)
        else:
            print("Mode  not recognised, exiting..")
            sys.exit()
        datasets = ImageFolderWithPaths(  root=data_path    )
        # print("datasets.classes: ",    datasets.classes)
        # print(np.random.rand(2,2))
        # print(torch.rand(2,2))
        # import sys
        # sys.exit()

        for idx, (sample, target, path) in enumerate(datasets):
            self.labels.append(  target  )
            self.file_paths.append(path)

        # write_list_to_file("./filepaths.txt", self.file_paths)
        # write_list_to_file("./labels.txt", self.labels)
        # sys.exit()

        self.train_data_transforms = A.Compose([
            ### some img transforms
        ])
        self.test_data_transforms = A.Compose([
            ### some img transforms
        ])

    def __len__(self):
        return len(self.file_paths)

    def __getitem__(self, idx):
        label = self.labels[idx]
        file_path = self.file_paths[idx]

        # Read an image with OpenCV
        image = cv2.imread(file_path)

        # By default OpenCV uses BGR color space for color images,
        # so we need to convert the image to RGB color space.
        image = cv2.cvtColor(image, cv2.COLOR_BGR2RGB)
        if self.train_data_transforms:
            if self.mode=="train":
                augmented = self.train_data_transforms(image=image)
            else:
                augmented = self.test_data_transforms(image=image)
            image = augmented['image']
        return image, label, file_path

@annongitter Hi, I am also facing the same problem. But I have another use case, where I am using separate data loaders for both renders and query dataset. But I am unable to figure out how can I wrap both the dataloaders in pytorch-lightning because we only have the option of train, val and test dataloaders and I want two dataloaders for the test or val.

@adityak2920 mind reproduce it with https://colab.research.google.com/drive/1HvWVVTK8j2Nj52qU4Q4YCyzOm0_aLQF3?usp=sharing??

This issue is still relevant.

This issue is still relevant.


Manually edit GearSets/Gear

Any way to be able to assign gear that people are wearing manually from a drop-down or list or something without relying on something like etro or the game or lodestone? It can just be batches of raid gear instead of needing to accommodate every single piece of gear. Alternatively, there can be an option to have assigned gear be also from etro as well, so the raid leader doesn't need everyone around in order to set it up and etc.

[ ] Create interface to show and edit a gearset
[ ] Create interface to how and edit gear item including materia
[ ] Create structure to easily select gear (filter by iLvl, Slot, etc)

Implemented Ui to edit gear manually (see screenshot). This provides functionality described above. For changes and improvements regarding the Ui please comment in #11


fix: Explicitly set the rel=canonical of the OpenTelemetry blog post

Duplicate content is frowned upon by Google. This blog post has been already published on the OpenTelemetry web site. To avoid being flagged as duplicate and incur a SEO penalty, we need to reference the "original".
Alternatively, we could ask the OpenTelemetry team to point to our post. But it will probably take more time and it's not worth it IMHO.

Looks good to me

I don't think it's a good idea. Canonical Tags specify the URL that should be shown in search results. It should be used to specify the version of a page in our website, not other websites.

@SkyeYoung It makes sense. Are you willing to ask (and follow up) the OpenTelemetry team to update their page?

Technically they are two articles with different titles and contents. Adding it wouldn't hurt, but I think it is also fine to leave it as it is.
https://opentelemetry.io/blog/2022/apisix/
https://apisix.apache.org/blog/2022/02/28/apisix-integration-opentelemetry-plugin

@yzeng25 No. Canonical Tags mean which URL should be indexed. If merged this, https://apisix.apache.org/blog/2022/02/28/apisix-integration-opentelemetry-plugin may never be indexed.

@yzeng25 Technically, I'm afraid that Google might disagree with you 😅

Duplicate content generally refers to substantive blocks of content within or across domains that either completely match other content in the same language or are appreciably similar
-- Avoid creating duplicate content

(Emphasis is mine)

@nfrankel @yzeng25 we can read the HTML Standard

Canonical Tags mean which URL should be indexed

Can you please provide references to this statement @SkyeYoung

we can read the HTML Standard

Unfortunately, it has nothing to do with HTML standard but everything to do with how Google indexes documents

Canonical Tags mean which URL should be indexed

Can you please provide references to this statement @SkyeYoung

@nfrankel Pls read https://datatracker.ietf.org/doc/html/rfc6596.

Unfortunately, it has nothing to do with HTML standard but everything to do with how Google indexes documents

We may need to know the members of WHATWG. :D

Authors who declare the canonical link relation ought to anticipate that applications such as search engines can:

Index content only from the target IRI (i.e., content from the context IRIs will be likely disregarded as duplicative).

(Emphasis mine).
@SkyeYoung If I understand correctly, your point is that if we set the rel=canonical, our page may not be indexed.
My point is that I don't care, because it will be flagged as duplicate by Google, thus our domain will lose PageRank or whatever secret metric Google uses nowadays and our page may not be indexed anyway.
I stand by my position: we need to set the rel=canonical.

The best would definitely be to add the canonical on their side and point to our blog (as I mentioned in the PR description).

The best would definitely be to add the canonical on their side and point to our blog (as I mentioned in the PR description).

Say if I had a pull request opening in OpenTelemetry's side, and I'll add something like this to it.
`<head>
    <link rel="canonical" href="https://apisix.apache.org/blog/2022/02/28/apisix-integration-opentelemetry-plugin//" />
</head>`

And that is it, right?

@yzeng25 I don't know if they are using Docusaurus too, but if they are, yes, something like that could work. But in the meanwhile, Google would flag us as duplicate. So it depends a lot on how fast they can merge the PR.

@nfrankel adding the above code block to this pull request should solve all problems, right?
https://github.com/open-telemetry/opentelemetry.io/pull/1254

I had a quick look and it's a bit involved. It seems you cannot just add a snippet: you'd need to actually to change the template.

@yzeng25 Nope

This is the source repo for the website and project documentation. The site is using Hugo and hosted on Netlify.
-- https://github.com/open-telemetry/opentelemetry.io

We need to understand:

If we can override the canonical link with Hugo
How to do it

There you go, I think it is totally feasible.

Amazing @yzeng25! Then by all means, please open a PR. But let's watch it, and if it's not merged within a reasonable time frame, we shall get back to this one.

Please read my above comment. To make it easier, I'll again paste and emphasize the important bits:

Duplicate content generally refers to substantive blocks of content within or across domains that either completely match other content in the same language or are appreciably similar
-- Duplicate content

Sorry, I didn't see that. Interesting. They don't seem to like following their own standards.
But, I found:

Duplicate content on a site is not grounds for action on that site unless it appears that the intent of the duplicate content is to be deceptive and manipulate search engine results. If your site suffers from duplicate content issues, and you don't follow the advice listed in this document, we do a good job of choosing a version of the content to show in our search results.
-- Duplicate content

Maybe we don't have to do anything

They don't seem to like following their own standards

They don't have "standards". They are Google. They do whatever they want.

Maybe we don't have to do anything

Definitely no. I'm not an SEO expert, but I've dabbled a bit into it, and duplicate content is just plain bad.

They don't have "standards". They are Google. They do whatever they want.

So I use DDG, but not Google. :p

DDG?

@yzeng25 yes, if it's merged fast

@SkyeYoung Ah yes. Unfortunately (or not), Google is ubiquitous everywhere outside of China (and perhaps Russia with Yandex)

Good job!

发件人: yilinzeng @.>
发送时间: Thursday, March 31, 2022 5:58:51 PM
收件人: apache/apisix-website @.>
抄送: SkyeYoung @.>; Mention @.>
主题: Re: [apache/apisix-website] fix: Explicitly set the rel=canonical of the OpenTelemetry blog post (PR #995)
@nfrankelhttps://github.com/nfrankel @SkyeYounghttps://github.com/SkyeYoung I have it done herehttps://github.com/open-telemetry/opentelemetry.io/pull/1254/commits/cda39aab4149ebd5d18539e21939a776aaa5a749. Normally it takes a couple of days. I will track it.
―
Reply to this email directly, view it on GitHubhttps://github.com/apache/apisix-website/pull/995#issuecomment-1084354510, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALRIROFAZD63G4VPWO7CTKDVCVZNXANCNFSM5SERCO4A.
You are receiving this because you were mentioned.Message ID: @.***>

Thanks a lot @yzeng25!

Thanks a lot @yzeng25!

No problem. Do you mind converting this pull request to draft for now? I want to see how it goes on the other side first. In this way, this pull request won't get merged or need re-approval.

https://github.com/open-telemetry/opentelemetry.io/pull/1254#discussion_r839675423 solves part of our concerns in this issue.
This pull request will solve the rest of our concerns.
https://github.com/open-telemetry/opentelemetry.io/pull/1258

@nfrankel @SkyeYoung, since both https://github.com/open-telemetry/opentelemetry.io/pull/1258 and https://github.com/open-telemetry/opentelemetry.io/pull/1254 are merged now, canonical url is added on OpenTelemetry's side. See https://opentelemetry.io/blog/2022/apisix/#summary.
I think we can close this pull request.

Sorry, but I don't see any canonical link in the deployed page...

Sorry, but I don't see any canonical link in the deployed page...

It is here.
https://raw.githubusercontent.com/open-telemetry/opentelemetry.io/main/content/en/blog/2022/apisix.md

@yzeng25 @nfrankel It seems to be more like a variable, and not parsed to canonical tag

Ok. Take Medium as an example, after adding canonical_url, we are expecting something like this to show up.

I checked all blog posts on OpenTelemetry's site, all blogs with canonical_url are not reflecting similar changes as above.

So we need to go back to the second option, add canonical_url via this pull request, right?

@yzeng25 Maybe they just have not intended to support Canonical Tag. 🤔
I remember that hugo did not have related FrontMatter (I used to be a user of it)

@yzeng25 Maybe they just have not intended to support Canonical Tag. 🤔
I remember that hugo did not have related FrontMatter (I used to be a user of it)

This is hilarious 😂。I spend hours to work on it and ask their community to merge pull requests, and it is not working as expected.
Positive side: we found a bug for them.
Negative side: we need an alternative to solve canonical_url issue.

Positive side: we found a bug for them.

Maybe this is the behavior they expect...

@yzeng25 Please merge this PR. We tried, we failed. Now it's time to fix.

It is a completely new case for me. As we discussed, tried and encountered failures, let's agree to disagree.

I would like to get this pull request merged. Giving it a shot wouldn't hurt.
We should review GA stats after a month or so, to see if canonical_url actually works. If it works, then we should do it for each cross-posted blog that is posted on platforms other than Medium. If it does not work,  we should rollback the change in this pull request.

2. We should review GA stats after a month or so, to see if canonical_url actually works. If it works, then we should do it for each cross-posted blog that is posted on platforms other than Medium. If it does not work,  we should rollback the change in this pull request.

Let's create an issue to track this.

@yzeng25 Perfect for me

We should review GA stats after a month or so, to see if canonical_url actually works. If it works, then we should do it for each cross-posted blog that is posted on platforms other than Medium. If it does not work,  we should rollback the change in this pull request.

Let's create an issue to track this.

@nfrankel @SkyeYoung , just created an issue to track this: https://github.com/apache/apisix-website/issues/999. We can discuss over there.


conformance: Conformance tests need a way to test that a percentage of requests succeed or fail

What would you like to be added:
In #1243, I added some conformance testing around new BackendRef tests, but one case we couldn't catch is the following:

There are two backendRefs in the HTTPRoute backendRef list, with equal weights
One is invalid
Half of the requests sent through the implementation must get a 500.

Why this is needed:
Part of the spec is weighted load balancing, having some tooling to allow us to test this as part of conformance will help a lot.
Downside: It's going to be tricky to write the tests to be not flaky. I suspect that we'll need to provide a target percentage value, add some wiggle room to it, and then send some number of requests. It seems likely to me that the details will matter a lot here.
May need to be a GEP, let's discuss here first.

This definitely feels like it would be flaky to test - would using filters to direct 100% of traffic to each of a valid and invalid backend for the same route be a viable alternative to this?

Well, in the spec for backendRef, the above behavior is mandated (that is, if there are multiple backends, and one is invalid, then the invalid one should instead produce an equivalent percentage of 500 errors), so ideally we should have a way to test implementations do that in conformance.
That's why I put a target percentage value, and some wiggle room (maybe 50% plus minus 5% or something for the two-backend case).
Having filters direct traffic doesn't meet the spec item that we're trying to test, unfortunately.

I agree that we should create another issue for the test Mike described.

Well, looking at HTTPRouteFilter it appears the functionality I was envisioning doesn't really exist (so I'm not opening an issue to test it hah) - HTTPRequestMirrorFilter is somewhat similar but would ignore the actual configured backendRefs on the HTTPRoute, I was thinking of something like an HTTPRequestLabelSelectorFilter configuring https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/ to filter backendRefs by metadata.


Snowflake: VARIANT and ARRAY type not parsed

System information:

Operating system: WIndows 10
DBeaver version: 6.3.2 (EE)

Connection specification:

Database name and Version: Snowflake 3.56.4
Driver name: snowflake-jdbc-3.11.1.jar
Do you use tunnels or proxies (SSH, SOCKS, etc)? : Yes: HTTPS proxy

Describe the problem you're observing:
Columns of type VARIANT and ARRAY (and supposedly OBJECT) are not parsed/interpreted by DBeaver, but displayed as formatted text only.
VARIANT:

ARRAY:

I'd expect Dbeaver to display VARIANT type as parsed JSON, just like it does for Postgres' JSONB type.
The ARRAY type should accordingly be shown and editable like it can be done in Postgres ARRAYs.
Postgres example for JSONB type:

Steps to reproduce, if exist:
Create a table with ARRAY and or VARIANT column and display its contents

Still reproducible in DBeaver 23.0.5