WaterDog Error

ater: io.netty.channel.ConnectTimeoutException
[13:38:43] [Netty Worker IO Thread #12/INFO]: [Toan31] disconnected with: Could not connect to a default or fallback server, please try again later: io.netty.channel.ConnectTimeoutException
[13:38:43] [Netty Worker IO Thread #12/INFO]: [quiludan] disconnected with: Could not connect to a default or fallback server, please try again later: io.netty.channel.ConnectTimeoutException
[13:38:43] [Netty Worker IO Thread #3/INFO]: [Nhanvnfca1212] disconnected with: Could not connect to a default or fallback server, please try again later: io.netty.channel.ConnectTimeoutException
[13:38:43] [Netty Worker IO Thread #9/INFO]: [GoGoBeDe] disconnected with: Could not connect to a default or fallback server, please try again later: io.netty.channel.ConnectTimeoutException
[13:38:43] [Netty Worker IO Thread #9/INFO]: [TLGM2308] disconnected with: Could not connect to a default or fallback server, please try again later: io.netty.channel.ConnectTimeoutException
[13:38:43] [Netty Worker IO Thread #0/INFO]: [/<IP_ADDRESS>:49989|yennhi2906] -> UpstreamBridge has disconnected
[13:38:43] [Netty Worker IO Thread #9/INFO]: [/<IP_ADDRESS>:45318|SimMinYuu] -> UpstreamBridge has disconnected
[13:38:43] [Netty Worker IO Thread #0/INFO]: [/<IP_ADDRESS>:32874|SecondWord13430] -> UpstreamBridge has disconnected
[13:38:43] [Netty Worker IO Thread #3/INFO]: [/<IP_ADDRESS>:36035|Nhanvnfca1212] -> UpstreamBridge has disconnected
[13:38:43] [Netty Worker IO Thread #9/INFO]: [/<IP_ADDRESS>:46284|TLGM2308] -> UpstreamBridge has disconnected
[13:38:43] [Netty Worker IO Thread #12/INFO]: [/<IP_ADDRESS>:38053|quiludan] -> UpstreamBridge has disconnected
[13:38:43] [Netty Worker IO Thread #3/INFO]: [/<IP_ADDRESS>:51335|AXC990] -> UpstreamBridge has disconnected
[13:38:43] [Netty Worker IO Thread #3/INFO]: [/<IP_ADDRESS>:40155|Yuu5743] -> UpstreamBridge has disconnected
[13:38:43] [Netty Worker IO Thread #9/INFO]: [/<IP_ADDRESS>:55233|GoGoBeDe] -> UpstreamBridge has disconnected
[13:38:43] [Netty Worker IO Thread #1/INFO]: [/<IP_ADDRESS>:50007|AXC989] -> UpstreamBridge has disconnected
[13:38:43] [Netty Worker IO Thread #0/INFO]: [/<IP_ADDRESS>:56756|ThermicOrca4257] -> UpstreamBridge has disconnected
[13:38:43] [Netty Worker IO Thread #12/INFO]: [/<IP_ADDRESS>:35544|Toan31] -> UpstreamBridge has disconnected
[13:38:44] [Netty Worker IO Thread #6/INFO]: [/<IP_ADDRESS>:32468|HeadyKibbles957] -> UpstreamBridge has disconnected
[13:38:44] [Netty Worker IO Thread #1/INFO]: [/<IP_ADDRESS>:35961|Noob_LH] -> UpstreamBridge has disconnected
[13:38:47] [Netty Worker IO Thread #0/ERROR]: [DuyVN2004|/<IP_ADDRESS>:64626] <-> ServerConnector [lobby] - encountered exception
java.lang.ClassCastException: class network.ycc.raknet.packet.ServerHandshake cannot be cast to class net.md_5.bungee.protocol.PacketWrapper (network.ycc.raknet.packet.ServerHandshake and net.md_5.bungee.protocol.PacketWrapper are in unnamed module of loader 'app')
at net.md_5.bungee.netty.HandlerBoss.channelRead(HandlerBoss.java:96) ~[Waterdog.jar:git:Waterdog-Bootstrap:1.15-SNAPSHOT:fa600ba:303]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:374) ~[Waterdog.jar:git:Waterdog-Bootstrap:1.15-SNAPSHOT:fa600ba:303]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:360) ~[Waterdog.jar:git:Waterdog-Bootstrap:1.15-SNAPSHOT:fa600ba:303]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:352) ~[Waterdog.jar:git:Waterdog-Bootstrap:1.15-SNAPSHOT:fa600ba:303]
at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:102) ~[Waterdog.jar:git:Waterdog-Bootstrap:1.15-SNAPSHOT:fa600ba:303]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:374) ~[Waterdog.jar:git:Waterdog-Bootstrap:1.15-SNAPSHOT:fa600ba:303]

Expiriencing the same, can't connect to the default server. Tried localhost <IP_ADDRESS> the external IP. Few different port numbers, forced_default true and false


Add omatadd_batch operator

This patch add the blas extension operator omatadd_batch.
Co-authored-by: @OuadiElfarouki<EMAIL_ADDRESS>

Squashed all commits history for convenience when merging. PR still stacked on top of matcopy_batch_pr


module 'peewee' has no attribute 'RESULTS_NAIVE'

when run in docker ,i receive the error;

Same.

Probably #78 ?

@rudyryk Looks like it.

Yeah that's exactly the "result handling" issues I mentioned it my comment. I've adjusted my requirements file accordingly for the time being, as I haven't had time to work on a PR or anything to fix this. 😕

Thank you very much.  I've dealt with it already. Replace 3.* with peewee==2.10.2


New settings editor: workspace does not inherit settings

Issue Type: Bug

Change a setting globally.
View the setting in a workspace.

Expected: The setting will not show up with 'show modified only', but will have the value from the global settings.
Actual: The setting had the default value.
Note: I was trying to override a setting I had changed back to the default value in a workspace, and was not able to do this in the new settings menu.


Create blog post on correct way of encoding reviewer comments (in tables, etc.)

From @anermina:

I believe the initial markup that I used for adding the reviewer's comments is wrong and shouldn't be used. As shown in Manuel's example, a standalone comment was added to the table, which doesn't make sense, because standalone comments are rendered at the end of the section (if specified) - they are not rendered where they are placed. Moreover, these should not be standalone, but rather ranged comments.

Markup has been updated in https://github.com/metanorma/S-102-Product-Specification/pull/11/commits/8c1ebf365fd1b4078a49d68d4b353f91ec5f2f6a, so I'm closing this issue.
Originally posted by @anermina in https://github.com/metanorma/isodoc/issues/471#issuecomment-1362164857

@ronaldtse there is already a blog post and a section in the Author's Documentation about this subject:
Annotations now available in all Metanorma outputs
Annotations (editor notes, reviewer notes, to-dos)


Variadic function

Functions with argument list ([a b]{}) are always non-variadic. It should be possible to make them variadic too.

The syntax is [a b @xs]{}, where xs takes the rest of the arguments. This is consistent with #81.


Add pull_requests attribute to Story

In order to get it populated, fields: 'pull_requests' is required when
calling the method that retrieves the story(ies) - otherwise it's nil

read access is enough for my needs but I suppose we could extend the PullRequest class with methods to modify it

Coverage increased (+0.04%) to 97.028% when pulling 54ae0488d6baf8df129b6cc1e68a7d811b85007b on gobetti:feature/pull_requests into 2c656e692821931cd2e5bbfd6d283be2e108aa0c on dashofcode:master.

Coverage increased (+0.04%) to 97.028% when pulling 54ae0488d6baf8df129b6cc1e68a7d811b85007b on gobetti:feature/pull_requests into 2c656e692821931cd2e5bbfd6d283be2e108aa0c on dashofcode:master.

Good PR and great add. Sorry we haven't gotten to this sooner - we've just taken ownership of this gem and are still getting ramped up.
To make this PR complete, there would be some tests added that exercise reading the pull requests of a story. Do you mind adding some tests to the PR?

Good PR and great add. Sorry we haven't gotten to this sooner - we've just taken ownership of this gem and are still getting ramped up.
To make this PR complete, there would be some tests added that exercise reading the pull requests of a story. Do you mind adding some tests to the PR?


shipper check number of chunk files in remote match local block

Changes
When shipper uploads blocks, it is possible that not all chunk files will upload successfully, but the metafile and block will exist in block storage when a failure occurs, such as network or block storage outage. In such a case, when the shipper syncs again it will not see the failed block in its 'uploaded blocks' list, but will see the block and meta file in block storage and assume it has already been uploaded.
Added logic to the shipper sync method to check that the same number of chunk files exist in block storage as well as the existence of the block and meta file.
Verification

ran: make test-local
ran: 2 prometheus, 2 sidecars, and block storage service. Then removed a chunk file from uploaded block and verified the file was re-uploaded.

Yes I see now that the meta file is uploaded last, however I would argue that this change would provide some level of self healing in case of a failure during compaction. For such an infrequent operation it would have no impact, but would help maintain data consistency.

self-healing in case of a failure during compaction.

You mean during sidecar upload rather?
I totally understand this point, but there is some harm to add it if it's totally unnecessary. We have chosen to do "full block" check by checking meta.json as it is uploaded as a last one.
Some partial ensuring like this:

increases some net traffic a bit
does not check everything (e.g index file)
does not check if chunk or any file is not partially uploaded (!)
is not consistent with many other upload cases we do (compactor, repair processes)

In my eyes, overall if uploading meta.json is not enough or there is a bug: it will hit us in many other places anyway, so we want to rely on one safeguard and make it strong. If we start to add small safeguards in many places we:

Maybe loose focus on the main safeguard as there are extra checks so yolo (:
Get lost what is checked and where, so it's prone to bugs.

Super silly comparison but in a similar way, we don't log the same error 3 times, just in case we did not log it in this place, and just in case we did not handle error in another, we log here as well, etc (:
Sorry for being super strict, but this is my opinion in order to keep the project clean and understandable! (:

I suppose this cannot happen though since compactor won’t delete anything until after upload completes anyway. Will close request.

Sorry missed your last comment. Yes you are right. No worries.

I probably ran into that issue that you've mentioned @bwplotka, thanks for the comments here - makes sense and I agree.


Installing poedit on Mint22, not finding lucene++

./configure, gives me this:
`
configure: error: missing Lucene++ library
brianr@brian-Mint21:~/Downloads/poedit-3.5.1$ sudo apt install liblucene++0t64
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
liblucene++0t64 is already the newest version (3.0.9-3.1build1).
0 to upgrade, 0 to newly install, 0 to remove and 0 not to upgrade.
brianr@brian-Mint21:~/Downloads/poedit-3.5.1$
`

Do you have liblucene++-dev installed?

ok, that got me to the end of the ./configure - thanks.

Closing as RTFM.


SvelteKit not working on mobile phone default browser (non chrome) but Svelte only is working.

Describe the bug
SvelteKit not working property on mobile default browser (non chrome), and working as expected on chrome. Svelte still working on same device & browser. So I think the problem is in svelte-kit, but I still don't know the exact issue. Any guidance?
Is there any way to make it work since my user mostly using their default browser without installing chrome? Perhaps install some polyfills needed?
This is a real blocker to use svelte kit since I can't force all users to use chrome and not using their default browser.
Reproduction
https://github.com/niwasmala/sveltekit-bug-mobile-default-browser
This is the steps i take to create sveltekit reproduction

npm init svelte@next my-app
cd my-app
yarn install
Edit src/routes/index.svelte as mentioned below
yarn dev

https://github.com/niwasmala/svelte-working-on-mobile-default-browser
And this is step I take to create svelte repro

npx degit sveltejs/template my-svelte-project
cd my-svelte-project
yarn install
Edit src/App.svelte as mentioned below
yarn dev

Logs
No response
System Info
System:
    OS: Windows 10 10.0.19042
    CPU: (4) x64 Intel(R) Core(TM) i5-6200U CPU @ 2.30GHz
    Memory: 7.46 GB / 15.88 GB
  Binaries:
    Node: 14.18.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.4 - ~\node_modules\.bin\yarn.CMD
    npm: 6.14.15 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: 44.19041.423.0
    Internet Explorer: 11.0.19041.1
  Mobile Phone:
    Device: Vivo 1807
    OS: Android 8.1
    Browser: Default Browser (non chrome)

Severity
blocking all usage of SvelteKit
Additional Information
Svelte Kit Repro

Source code: src/routes/index.svelte

Welcome to {name}

{browser} {isBrowser}

Expected: After mounting, display "Welcome to world", browser true, and isBrowser = true
Actual: display "Welcome to hello", browser false, and isBrowser = false
Svelte

Source code: src/App.svelte

Hello {name}!

Visit the Svelte tutorial to learn how to build Svelte apps.

Working as expected. After mounting, display "Hello hello"

I see the device is a Vivo 1807 using the device's default browser. Is it possible that the browser is blocking Javascript somehow? Because that's exactly what I'd expect to see if Javascript is disabled (and, in fact, I can reproduce those results in Firefox on Linux by just turning off Javascript and reloading the page). The server-side rendering will produce "Welcome to hello", and once the client has loaded it, the Javascript code will change "hello" to "world". But if Javascript is disabled, then none of the client-side code runs.
Could you check whether Javascript is somehow disabled by default on the device? If turning Javascript on makes the site run correctly, then this isn't a Svelte-Kit bug. Svelte-Kit is designed so that you can server pages to browsers that have Javascript disabled (see the "todos" example in the Svelte-Kit demo project), but you do have to design your pages around the fact that you expect browsers to turn off Javascript. It's not a bug when client-side code fails to run in a browser with Javascript disabled.

If that's not what the problem is, then this sounds like a duplicate of #12.

Will check immediately is the browser blocking javascript.
But if the browser is blocking the javascript, svelte-only repo should display hello world, since name is set from src/main.js, isn't it?

I'm adding app.html

%svelte.body%

    You don't have javascript enabled.  Good luck with that.

And it shows the alert, so the javascript should be running right? If you need any things need to clarify, feel free to tell me.

I can report a similar experience.
I currently have a SvelteKit app that's running on both the dev server using dev --host and deployed on vercel for testing. I'm visiting the app on multiple iOS devices using multiple browsers: mobile: firefox, chrome, brave, safari; desktop: firefox and brave.
Everything works as expected on desktop browsers. However on every mobile browser I've tried, some props are updated when data is fetched (and the view re-renders) while others are not.

I'm willing to bet this is a duplicate of #12, so I'll close this


Use fallback when current version is unavailable

It's otherwise blocking builds, see also https://github.com/sass/dart-sass/issues/2110
The plugin should fallback to previous version when current version fails to download. If that also fails then fallback further to last successfully used locally cached version.

you rock @cleydyr !

The proposed implementation to make this plugin more resilient is to iterate through each release and each release artifact and check if an artifact name matches what's expected (dart-sass-[VERSION]-[OS]-[ARCH].[EXTENSION]). If there's a matching artifact, we'll use its release as the autodetected version.
Note: the results returned by the GitHub API seem to be sorted by the date of the tag/commit [1], though it's not documented on the API doc itself.
The plugin should not fall back to the locally cached version, as the Dart Sass autodetection is intended to be used in environments with an Internet connection [2], which means it's also able to download at least one version with a matching artifact for all supported os-arch combinations (1.68.0 is one such version). Also, if there was a locally cached release to begin with, it would already be used, and the release download wouldn't be attempted.

Issue fixed on version 1.2.0, already deployed and soon to be published on Maven Central.

Confirmed its in Maven Central.

Closing this now.

fab


Register in General

@tjjarvinen  --  I see project version is set to 0.1.0. Is it really ready for this?

The main point of 0.1.0 is that we can have non breaking releases. With 0.0.1 we only have breaking releases. And I don't see us making breaking changes that much.

Ok Inwill merge as 0.1 then, not the end of the world if we need a few minor releases

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/99001
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" 1aee70823f8a7874f97cc85cdd01c43cd40b6adf
git push origin v0.1.0

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/99206
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.1 -m "<description of version>" cb3d906cc8e700e9345dd2aaf3da721f600e1d91
git push origin v0.1.1

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/106901
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.2 -m "<description of version>" 9da3261ee8da41f5b56affbc52809ffba9dad583
git push origin v0.1.2

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/107115
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.3 -m "<description of version>" ca2e012b5c1951103b5e9be05c1ed73970213786
git push origin v0.1.3

@JuliaRegistrator register

Error while trying to register: "Pre-release version not allowed"

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/113906
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.0 -m "<description of version>" d07212af66e0251472634b2628b653abb45de7bd
git push origin v0.2.0

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/114466
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.1 -m "<description of version>" aff9548b0508cdce1c40cde1f2a01c2b20e446d4
git push origin v0.2.1

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/115178
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.2 -m "<description of version>" 1bc32f7d69b8d991f35112351c05f75d96954368
git push origin v0.2.2

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/115469
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.3 -m "<description of version>"<PHONE_NUMBER>37b43ef3661a491d277db060a06871
git push origin v0.2.3

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/121742
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.4 -m "<description of version>" f43c4a7f64579dad37113105596a55640d5d9811
git push origin v0.2.4


[Feature Request] Chat notice alternative to popup box

I think it could be pretty unobtrusive but also sufficiently remindery if there was an alternative option to the popup box, where a link just popped up in chat after a death/wipe, maybe akin to 'view death report.'

This is a good idea. I'll add an option for this in the next release.

Awesome, thank you!
On Tue., Feb. 8, 2022, 5:22 a.m. Ben Ludewig, @.***>
wrote:

This is a good idea. I'll add an option for this in the next release.
—
Reply to this email directly, view it on GitHub
https://github.com/Kouzukii/ffxiv-deathrecap/issues/6#issuecomment-1032550000,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALXG4FF2ABZ5BWURDXC3HPTU2EDG3ANCNFSM5NNXDJEQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

Took a while, but 1.6.0 finally allows you to customize the popup.


Cherry-pick the fix of limit instantiation recursion for all type instantiation onto main

@dariorussi I disabled a failed check in [instantiation_tests.rs](https://github.com/move-language/move/pull/816/files#diff-5044214598ad2c43accebabcd4aca93a8c2304d6545ca7986195acb40d05155b). I think it may related to a code change here. Could you take a look and give a hint on how to fix it? Thanks

or if that unblocks you faster I can just accept and I'll do the cleanup later.
Still let's talk about it, but maybe I'll just accept your PR....

Thanks!


Xnero: Watch vitecloud.com

Xnero requests the watch of the watch_keyword vitecloud\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

vitecloud\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by double-beep in Charcoal HQ


Query Widget Not working

Dev Home version
0.701.323.0
Dev Home Azure Extension version
0.200.323.0
Windows build number
10.0.22621 Build 22621
Steps to reproduce the bug

Add Widget
Query Results
Chose Account + add Query URL
Submit + Pin

Expected result
Widget shows the Correct Query Results
Actual result
Widgets says 'No results match the query'

Included System Information
Not sure if I'm using the wrong URL
What I tried:

https://dev.azure.com/{Organization}/{Project}/_queries/query/{QueryId}

Not Working

On the query website clicking on Copy query URL and using that link
https://dev.azure.com/{Organization}/{Project}/_queries?tempQueryId={tempQueryId}

Not Working

Does your project name have a space in it? It looks like the project / repo names are parsed from the URL (which will be URL encoded), but that doesn't match the names in devops (which are not), so none of the widgets where the project or repo name has a space in it are working for me either.

Yes, the project name have a spaces

Just updated to the latest version, PRs are working but unfortunately the queries are still not working
It gets the query names automatically but doesn't show any results.


Fetch Cert Win Store

Fetch Cert from Windows Store, and then return the cert as PEM format

Adds getWindowsCert in Auth Folder

Linked Issue: https://github.com/pnp/cli-microsoft365/issues/1960

Seems like a good approach. Let's hook it up to the login command so that we can see it in action. Also, let's include tests to maintain the full coverage. I'll mark the PR as draft for now and let's mark it as ready for review when we can test it.
Thank you!

Thanks I will look at integrating this into the Login flow, as well after Thanksgiving.

Awesome! Appreciate your help @yumoraby 👏

Hey @yumoraby, could you revert your changes and not reformat the affected files? It makes it impossible for us to see what has actually changed. Thank you!

Hi @waldekmastykarz I will revert tonight, and ensure that (prettier) doesn't run when i save which reformats everything.

Thank you @yumoraby! That will make it so much easier to review your work ❤

Awesome! Looks good! We'll go through it shortly. Appreciate your help 👏

@waldekmastykarz did you get time to review the latest changes?

Sorry, since the PR was marked as draft, I was under the impression that you were still working on it. If it's ready for review, let's mark it as such

Before we proceed with the review, let's fix the broken tests and ensure we have full coverage of the changes in this PR.

@waldekmastykarz updated the test, their are 2 lines I need help with:
Auth.ts                              |   99.48 |     99.3 |     100 |   99.48 | 314-316
they dont seem to get parsed through the tester. Need some help

Hey @yumoraby, sorry for the late reply. It seems like I missed your message.

The reason these lines are uncovered is because apparently there are no certs being returns so the whole block on line 309 is not executed. You'd need to have another look at how you mock the cert store (the caApi call).

Hey @yumoraby, sorry for the late reply. It seems like I missed your message.

The reason these lines are uncovered is because apparently there are no certs being returns so the whole block on line 309 is not executed. You'd need to have another look at how you mock the cert store (the caApi call).

Hey @yumoraby, sorry for the late reply. It seems like I missed your message.

The reason these lines are uncovered is because apparently there are no certs being returns so the whole block on line 309 is not executed. You'd need to have another look at how you mock the cert store (the caApi call).

I have addressed this issue, in the test. Using the caApi methods, pull certs from windows store, and then run the test on the first returned personal cert.

Hey @yumoraby, sorry for the late reply. It seems like I missed your message.

The reason these lines are uncovered is because apparently there are no certs being returns so the whole block on line 309 is not executed. You'd need to have another look at how you mock the cert store (the caApi call).

I have addressed this issue, in the test. Using the caApi methods, pull certs from windows store, and then run the test on the first returned personal cert.

Hey @yumoraby, if I look at the latest build, we have failing tests and the coverage is not 100%.

Hey @yumoraby, if I look at the latest build, we have failing tests and the coverage is not 100%.

@waldekmastykarz  this is my output:

What failures are you seeing?

@waldekmastykarz  this is my output:

What failures are you seeing?

I saw a failed test in this build but that could be caused by a timeout. If you're ready, we can proceed with reviewing the PR

I saw a failed test in this build but that could be caused by a timeout. If you're ready, we can proceed with reviewing the PR

I saw a failed test in this build but that could be caused by a timeout. If you're ready, we can proceed with reviewing the PR. Is your work complete and can we review the PR?

This is the test error, not from my  changes. I believe we are good to go:
 1 failing

  1) spfx project rename
       replaces project name in README.md:

      AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert(writeFileSyncSpy.calledWith(sinon.match.string, replacedContent, 'utf-8'))

      + expected - actual

      -false
      +true

      at F:\GitHub\cli-microsoft365\dist\m365\spfx\commands\project\project-rename.spec.js:346:17
      at SpfxProjectRenameCommand.commandAction (dist\m365\spfx\commands\project\project-rename.js:183:9)
      at SpfxProjectRenameCommand.action (dist\m365\base\AnonymousCommand.js:7:14)
      at Context.<anonymous> (dist\m365\spfx\commands\project\project-rename.spec.js:344:17)
      at processImmediate (node:internal/timers:463:21)

I saw a failed test in this build but that could be caused by a timeout. If you're ready, we can proceed with reviewing the PR. Is your work complete and can we review the PR?

This is the test error, not from my  changes. I believe we are good to go:
 1 failing

  1) spfx project rename
       replaces project name in README.md:

      AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert(writeFileSyncSpy.calledWith(sinon.match.string, replacedContent, 'utf-8'))

      + expected - actual

      -false
      +true

      at F:\GitHub\cli-microsoft365\dist\m365\spfx\commands\project\project-rename.spec.js:346:17
      at SpfxProjectRenameCommand.commandAction (dist\m365\spfx\commands\project\project-rename.js:183:9)
      at SpfxProjectRenameCommand.action (dist\m365\base\AnonymousCommand.js:7:14)
      at Context.<anonymous> (dist\m365\spfx\commands\project\project-rename.spec.js:344:17)
      at processImmediate (node:internal/timers:463:21)

This is a known issue on Windows indeed, and like you mentioned, not related to your changes. In that case, we'll get your PR reviewed. Thank you! 👍

This is a known issue on Windows indeed, and like you mentioned, not related to your changes. In that case, we'll get your PR reviewed. Thank you! 👍

Hey @yumoraby, we've got some conflicts when trying to rebase this PR. Would you mind syncing your branch with the latest upstream master so that we don't lose any of the recent changes and get your additions on top as intended? Appreciate your help 👏

@waldekmastykarz  how would I do this? Create another PR? if i do a rebase how do I not lose my changes?

Hey @yumoraby, we've got some conflicts when trying to rebase this PR. Would you mind syncing your branch with the latest upstream master so that we don't lose any of the recent changes and get your additions on top as intended? Appreciate your help 👏

@waldekmastykarz  how would I do this? Create another PR? if i do a rebase how do I not lose my changes?

The easiest would be to:

checkout your master branch
pull the latest from upstream (git pull upstream master); if you don't have upstream defined, you'd need to do that first by calling git remote add upstream https://github.com/pnp/cli-microsoft365
create a new branch and move your work over
create new PR

Alternatively, you could do:

checkout master branch
pull latest from upstream master
checkout your yumoraby branch
git rebase master > here you will get the same conflicts we do and you'd need to be careful how you merge them not to lose anything we've changed and include everything you've done

The easiest would be to:

checkout your master branch
pull the latest from upstream (git pull upstream master); if you don't have upstream defined, you'd need to do that first by calling git remote add upstream https://github.com/pnp/cli-microsoft365
create a new branch and move your work over
create new PR

Alternatively, you could do:

checkout master branch
pull latest from upstream master
checkout your yumoraby branch
git rebase master > here you will get the same conflicts we do and you'd need to be careful how you merge them not to lose anything we've changed and include everything you've done

The easiest would be to:

checkout your master branch
pull the latest from upstream (git pull upstream master); if you don't have upstream defined, you'd need to do that first by calling git remote add upstream https://github.com/pnp/cli-microsoft365
create a new branch and move your work over
create new PR

Alternatively, you could do:

checkout master branch
pull latest from upstream master
checkout your yumoraby branch
git rebase master > here you will get the same conflicts we do and you'd need to be careful how you merge them not to lose anything we've changed and include everything you've done

Hopefully it worked. If not may need to reset as there were some changes to the same function.

The easiest would be to:

checkout your master branch
pull the latest from upstream (git pull upstream master); if you don't have upstream defined, you'd need to do that first by calling git remote add upstream https://github.com/pnp/cli-microsoft365
create a new branch and move your work over
create new PR

Alternatively, you could do:

checkout master branch
pull latest from upstream master
checkout your yumoraby branch
git rebase master > here you will get the same conflicts we do and you'd need to be careful how you merge them not to lose anything we've changed and include everything you've done

Hopefully it worked. If not may need to reset as there were some changes to the same function.

I don't think it did work as intended. The PR shows over 50 files modified :(

I don't think it did work as intended. The PR shows over 50 files modified :(

I don't think it did work as intended. The PR shows over 50 files modified :(

Hi Waldek can you reject the PR, and I'll re add the code changes back. As going through the merges there were so many changes and conflicts that would be easier to apply the updates fresh.

I don't think it did work as intended. The PR shows over 50 files modified :(

Hi Waldek can you reject the PR, and I'll re add the code changes back. As going through the merges there were so many changes and conflicts that would be easier to apply the updates fresh.

Will do. Thanks for your help 👍

Will do. Thanks for your help 👍


cached nonces, key rotation, automatic retries in open sourced repo

https://github.com/near/pagoda-relayer-rs/pull/25


Share heads from cache on peer connected

Possibly to speed up replication, share heads on peer join from cache when available vs waiting for the log to be loaded. Peer only needs heads to start syncing instead of waiting for other peer to finish loading db.
More relevant probably to pinning services (3box for example), where when a db wants to pin the log or sync it tells the pinning service to open that db. Then peer has to wait for that service to load and open log.
Also related to https://github.com/orbitdb/orbit-db/pull/688 where the heads are shared on connecting, but they are sometimes null (and not loaded yet). So we want to share heads on connect still, but make sure available at that time (from cache instead of log) (pr also good reference for which lines of code this references)
implementing in 3box first, and will likely share pr here soon as well

Thanks for quickly getting it into a release! closing issue now


Improve the documentation about sign in with OAuth in React Native and React VR environments

Currently on the site is written that sign in with Facebook, Github, Google, etc. is not supported on React Native environment. Since https://github.com/wedeploy/api-js/issues/119, this is no more true and we have to update the documentation.
More explanations should be added, since achieving sign in with OAuth requires some efforts on the client side too.

Hey @zenorocha, @jonnilundy,
Here is the draft. Now we have to decide where to put it. The point is that it is valid for all three providers - Facebook, Google and Github.
We either have to make it a separate page and reference it, or we have to copy it to the pages for Facebook, Google and Github. How would you suggest to proceed?
oauth-react-native-vr.md.txt
Thanks,

Okay, meanwhile I went ahead and sent the PR :)

Closing now that this content is on the help center.


Add missing - to protocol IDs

@GrantMeStrength : PR passed acceptance checklist. Please evaluate proposed changes and approve/merge if appropriate. Thanks!


The editor doesn't work for me at all :(

The editor doesn't work for me at all :(

Because I only attached the edited .exe
If you want to edit an aiv-castle you should get the official download first and then overwrite the .exe with the patched version.
http://stronghold.heavengames.com/downloads/showfile.php?fileid=7534#

@Sh0wdown Ok Sorry


⚠ Bofrost.fr has degraded performance

In 62e21e2, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 888 ms

Resolved: Bofrost.fr performance has improved in 405cec6 after 6 minutes.


Update README.md

Hi,
This small PR adds a button to get your app on F-Droid 👍
It also adds a link to get the latest APK from the Releases Section.
You can now eventually add the fdroid and/or f-droid tags that will appear on the right side of the repo.

thanks for the help changes have been added. thanks for the contribution


Migrate to Jakarta EE 10 and update all related libs

Now ready for review, but depends on #102
Although JEE 10 is compatible with JDK 11, Jetty 12 has upgraded the minimum supported version to  JDK 17, so this comes with a bump to java as well.

Manually merged.


Add support for background URLSessions

Description:
The App Programming Guide for watchOS recommends the use of background sessions when making network-based operations.
The library uses URLSessionConfiguration.default by default, but it would be good to be able to use URLSessionConfiguration.background(withIdentifier:) when needed.

I add a global configuration object OAuthSwift.session where you can change the configuration (URLSessionConfiguration)

That was fast! Thanks!!

Thanks for adding this - just what I was looking for too.  Can you help me to know how I should configure background session?  I am trying with
   let config = URLSessionConfiguration.background(withIdentifier: "bgConfig")     OAuthSwift.session.configuration = config
but this will not compile - it gives me error " 'configuration' is inaccessible due to 'internal' protection level

I do it to fast maybe. Not tested yet. So maybe there is an access problem.
Then I do it in a static way so there is no way to configure by OAuthSwift object or even by request

@phimage - yes - I think there is an access problem.  It does seem that my fix works for me...when I set the elements of the struct as public I can set them OK from my code - so do not be too quick to implement it some other way!
Still - it is important for me to have some sessions working with default settings (do that I can use callbacks) and others with background settings (which need to work with delegate methods)....so it is important that any implementation allows this configuration.  Hope this helps and I am happy to help test anything going forward!

an other big change has been done to be able to update it by OAuthSwift instance,
more precisely in OAuthSwiftClient instance oauthSwift.client.sessionFactory
You can create a new one or assigning one instance of your choice
oauthSwift.client.sessionFactory = URLSessionFactory(....)

or you can update it
oauthSwift.client.sessionFactory.configuration = ...

N.B.: This URLSessionFactory (from client instance) is passed to request Config object

Thanks for this update....but I am having problems using it - I get runtime error:
2016-11-25 10:47:25.746 API-Sandbox[66217:5638450] *** Terminating app due to uncaught exception 'NSGenericException', reason: 'Completion handler blocks are not supported in background sessions. Use a delegate instead.'
My calling code is:
`....
backgroundOauthswift.client.sessionFactory.configuration = URLSessionConfiguration.background(withIdentifier: "meetupApp")
backgroundOauthswift.client.sessionFactory.delegate = self
backgroundOauthswift.client.postMultiPartRequest(
requiredURL,
method: .POST,
parameters: ["sign":"true", "photo-host": "secure"],
headers: [:],
multiparts: [multipart],
checkTokenExpiration: true,
success: nil,
failure: nil
)
dismiss(animated: true, completion: nil)
}
}
func urlSessionDidFinishEvents(forBackgroundURLSession session: URLSession) {
print("DID FINISH: urlSessionDidFinishEvents, (session.description)")
}
`
I think I am NOT passing closures since I set success and failure to nil instead
I have set my calling class as URLSessionDelegate and provided the three optional methods...
What am I doing wrong?

OAuthSwift use the builded session with a completion handler, maybe not authorized in background session...
"self.session.dataTask(with: usedRequest) { (data, resp, error) in"

So...indeed, this looks like a bug?
data task convenience methods.  These methods create tasks that      * **bypass the normal delegate calls for response and data delivery**,      * and provide a simple cancelable asynchronous interface to receiving      * data.  Errors will be returned in the NSURLErrorDomain,       * see <Foundation/NSURLError.h>.  The delegate, if any, will still be      * called for authentication challenges..
Can you do a fix or point me to how to avoid the problem?

That's a lot of change and I have not time to do it now

OAuthSwitHttpRequest must implement URLSessionDataDelegate
"self.session.dataTask(with: usedRequest) { (data, resp, error) in" must become "self.session.dataTask(with: usedRequest) " and all the code completionhandler must be executed into URLSessionDataDelegate implementation
the delegate provided by user to build session must be replace by OAuthSwitHttpRequest. But in OAuthSwitHttpRequest URLSessionDataDelegate implementation, all functions could be mapped to  delegate provided by user

in case this helps....  I tried modifying your code:
if self.session.delegate == nil { 	//do all the existing code as normal with callbacks   } else {  	self.task = self.session.dataTask(with: usedRequest)  }
But I get then called with the delegate call didReceive challenge: completionHandler and I am not sure how to handle that properly...although it does work for the other foreground calls...

After a very long time (sorry) I add useDataTaskClosure in URLSessionFactory
If false, then we call self.task = self.session.dataTask(with: usedRequest) without the closure
It is not sufficient because in delegate you have to do a lot of work, same as OAutSwift framework do
A first step maybe is to call OAuthSwiftHTTPRequest.completionHandler but success and failure handler are overriden internally ( to extract token before calling the handler passed by developper)

Any update on this matter? I also have to keep requests running in background. Looking for an example with OAuthSwift.
Thanks in advance.

no
if you really need it and have code to test background session, you could make PR


validation and key-word extraction in the same user input

Describe the bug

I have been trying to do validation (other-> validation->validation rules) and key word extraction (in user input) but the entity extraction somehow did not work (the entity is extracted but the property was not set to the value). I tried to track it with the bot framework emulator and found out every time the entity extraction is conducted, the LuisV3 trace happens twice one right after another (I assume the second time the entity extraction is set to an empty string, but not sure about it).
I also have a question about the order of validation and entity extraction that is not directly related to this bug: which is goes first? Will the user input get extracted first and then validated?
Version

Bot framework composer (v2.1.2)
SDK v4

OS

[x] macOS
[ ] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Create a new question
In 'User Input', set property to user.email, value to =coalesce(@email), add @ prebuilt email in expected reponses
I think we can forget about validation for now as it works on my end (it is just a regex email validation)
See error

Expected behavior
 The property should be set to the extracted entity and get validated.
Screenshots

This is the section for reproduction of the bug:

Here you can see the first time the entity did get extracted:

But the second time the entity is set to an empty string:

I am investigating.

Hi @chia-lun Apologies for the delay. I am still investigating this.

No worries! Thank you for taking time to investigate.

Hi @chia-lun

Will the user input get extracted first and then validated?

That is correct. But you should use turn.extracted.text instead of user.email.
Regarding the two LUIS traces, do you have interruptions enabled on the prompt for text or dialog?

Hi @chia-lun
Do you still need assistance on this issue?

Closing due to lack of reply. If you still need assistance on this, please comment with the pertinent information and we can reopen to continue.


Similar Repo

Inspired by this repo, I create Amazing Windows Apps that sync with gitbook.
Please do take a glance and tell me how you require me or maybe we could combine.
For further discussion, drop me an email

Hi. thanks for creating this issue. yes, we can combine! how shall we proceed?


Using a variable passed from parent runner for the loop count specifier

It seems that runn does not support the following situation. I'm afraid that this might be a bug.
❯ runn run parent.yml
F

1) parent.yml 1d64130a3907ffc6d5d330a45e189ce85aa06de9
   └── included.yml
  Failure/Error: invalid count: evaluated vars.count, but got uint64(3)
  Failure step (included.yml):
  6   -
  7     dump: vars.hello
  8     loop: vars.count

1 scenario, 0 skipped, 1 failure

parent.yml
steps:
-
  include:
    path: included.yml
    vars:
      hello: HELLO
      count: 3

included.yml
vars:
  hello: hello
  count: 2

steps:
  -
    dump: vars.hello
    loop: vars.count

@h6ah4i Thank you for your report!


Extraction failed

I was not able to extract information from these sites too:

For this one:
https://www.devex.com/news/report-dozens-of-nations-might-struggle-to-fund-health-after-covid-19-101560
I get an error as a result: "Error: Could not retrieve content"

For this one:
https://www.mentalhealth.org.uk/coronavirus/staying-home-and-abusive-relationships
I get null as a result

Resolved since v5.0.0rc1


Generated WorkerExtensions.csproj project is restored at build time

In many CI scenarios, in particular ones internal to Microsoft, the network is disabled via firewall during the "build" phase of a build and only allow network access (and only in a very restrictive way) during the "restore" phase. This helps secure the build supply chain.
Because WorkerExtensions.csproj is generated on demand and is restored as part of the build of the parent project, this breaks this requirement and these project types are effectively unusable by many Microsoft-internal teams.
Please ensure all activity that required network access happens during "restore".
PS. You shouldn't ever need to dynamically produce a project and then build it. You should be able to do all the necessary work within the parent project. Reach out offline if you need help with this.

This is a known drawback of our SDK, unfortunately it is unavoidable. We have already worked with the NuGet, dotnet, and MSBuild team to brainstorm ways to avoid this inner build, but there is no way around it. The issue is our design mandates a 2 stage restore. Extensions have 2 packages really, the worker package - which you reference in your csproj. And the host/webjobs package, which is explicitly NOT part of your projects restore graph, instead it is discovered post-restore from the first worker package you referenced. This leaves us with a 2 stage restore: we must first restore the worker packages, then scan them to discover and restore the webjobs packages. Additionally, this scanning can only happen as part of the build target and not during the restore target (for multiple reasons, but primarily we rely on reference assembly resolution).
The recommended workaround today is to add a dummy project to your solution which contains the webjobs packages and restore that ahead of time, so when the inner-build restore occurs it will discover the locally cached packages and not reach out to the network.

Closing this as we will track the official workaround in #1888


More methods for Option

Why do we need this improvement?
We had a use case where we return an Option value and in case that was unsuccessful we wanted to return an empty Option. The issue is that in the code in which that function was used we wanted to obtain the value, within an if in which we knew it could not be None.
To do this we had to use the getOrElse method with an empty string, which may be a bit surprising or strange.
function exampleOption() {
  try {
     // some code
     return Option.of(response.data.clone_url);
  } catch (error) {
    // some code
     return Option.of(null);
  }
}

function main() {
    const option = await exampleOption();
    if (option.isSome()) {
        const newRepoUrl = optionNewRepoUrl.getOrElse("") as string;
        // some code
    }
}

Maybe there could be two new methods that help with this problem:

get: Method that returns the value directly
ofNone: Method that below makes you an Option.of(null)

This way the code would look like this:
function exampleOption() {
  try {
     // some code
     return Option.of(response.data.clone_url);
  } catch (error) {
    // some code
     return Option.ofNone();
  }
}

function main() {
    const option = await exampleOption();
    if (option.isSome()) {
        const newRepoUrl = optionNewRepoUrl.get();
        // some code
    }
}

How will this change help?
I think this can help make the Option API a lot richer, as well as give a little more clarity and semantics to the code.

get: This method can help us obtain a value if we previously know that we have something
ofNone: This method provides more semantics when creating an Option that does not represent any value

Screenshots
No response
How could it be implemented/designed?
For the ofNone method, a method that returns a None could be added to the Option abstract class.
abstract class Option<T> implements Monad<T>, Matchable<T, undefined> {
    //some code
    static ofNone(): Option<None> {
      return new None();
  }
}

And for the get method I am not sure what the solution could be, as a possible idea (although I am not sure if it is the best) you could create an abstract method and you would see something like this implemented in Some and None:
abstract class Option<T> implements Monad<T>, Matchable<T, undefined> {
    //some code
    abstract get(): T;
}

class Some<T> extends Option<T> {
  get(): T {
    return this.value;
  }
}

class None<T> extends Option<T> {
  get(): T {
    // Throw an Exception ??
  }
}

I don't know if it would be a good idea to throw an exception in the None, Java's Optional, if you do a get and you have not previously checked that it may not have a value in the ide, it shows you a warning, warning that it can throw a NullPointer, but it does not I know if it makes sense here.
We can discuss possible solutions and make a PR adding these methods if necessary 😄
🚧 Breaking changes
No
👀 Have you checked for similar open issues?

[X] I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

[X] I have read the Contributing Guidelines

Are you willing to work on this issue?
Yes I am willing to submit a PR!

I made a PR to add the ofSome and ofNone methods 😄


iOS fix

According to AppStore requirements we can't open browser as a separate app in iOS, our last app has been declined because of this. So I've added a possibility to be able to use SafariView under iOS for this. So the integration is seemless and works out of the box. Now the library is fully compatible with both platforms.

However I guess README.md should not be commited, sorry :)

Hi, apologies for the delay getting back to you. I'm surprised that Linking.openURL would not work for any iOS react-native app - I can't see any mention of that in the docs (http://facebook.github.io/react-native/docs/linking.html#openurl).
I'm not really keen on introducing react-native-safari-view as a dependency. That said, you should be able to compose a login function that does what you want - so I'd be happy to accept a PR that allowed the user to pass in a urlOpener function as part of the options.
So the dance function would look something like:
export const dance = (authUrl, urlOpener = Linking.openURL) => {
   ...
  return urlOpener(authUrl)
    .then(...

I think this is more of an issue now, see this thread: https://github.com/openid/AppAuth-iOS/issues/120#issuecomment-307872606


oc/kubectl get doesn't work for kind 'NetworkAttachmentDefinition'

Hey guys.
When listing nads with oc get NetworkAttachmentDefinition the command results with an error: error: the server doesn't have a resource type "NetworkAttachmentDefinition".
It works as expected when net-attach-def shortcut is used instead of the KIND NetworkAttachmentDefinition. It should be possible to use the KIND as well
What happend:
error: the server doesn't have a resource type "NetworkAttachmentDefinition
What you expected to happen:
NAME            AGE
<nad_name>   2h
How to reproduce it (as minimally and precisely as possible):
apiVersion: "k8s.cni.cncf.io/v1"
kind: NetworkAttachmentDefinition
metadata:
  name: ovs-net-1
spec:
  config: '{
      "cniVersion": "0.3.1",
      "type": "ovs",
      "bridge": "testbridge"
    }'
EOF
# oc get NetworkAttachmentDefinition

Anything else we need to know?:
Environment:

Multus version
multus-cni:v1.4.0
image path and image ID (from 'docker images')
Kubernetes version (use kubectl version):
Client Version: version.Info{Major:"1", Minor:"11+", GitVersion:"v1.11.0+d4cacc0", GitCommit:"d4cacc0", GitTreeState:"clean", BuildDate:"2018-10-10T16:38:01Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"11+", GitVersion:"v1.11.0+d4cacc0", GitCommit:"d4cacc0", GitTreeState:"clean", BuildDate:"2019-03-06T12:06:48Z", GoVersion:"go1.10.8", Compiler:"gc", Platform:"linux/amd64"}
Primary CNI for Kubernetes cluster:
OS (e.g. from /etc/os-release):
NAME="Red Hat Enterprise Linux Server"
VERSION="7.7 (Maipo)"
ID="rhel"
ID_LIKE="fedora"
VARIANT="Server"
VARIANT_ID="server"
VERSION_ID="7.7"
PRETTY_NAME="Red Hat Enterprise Linux Server 7.7 Beta (Maipo)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:redhat:enterprise_linux:7.7:beta:server"
HOME_URL="https://www.redhat.com/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"

REDHAT_BUGZILLA_PRODUCT="Red Hat Enterprise Linux 7"
REDHAT_BUGZILLA_PRODUCT_VERSION=7.7
REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="7.7 Beta"

File of '/etc/cni/net.d/'
openshift-network.conf:

{
  "cniVersion": "0.2.0",
  "name": "openshift-sdn",
  "type": "openshift-sdn"
}

File of '/etc/cni/multus/net.d'
NetworkAttachment info (use kubectl get net-attach-def -o yaml)

apiVersion: v1
items:
- apiVersion: k8s.cni.cncf.io/v1
  kind: NetworkAttachmentDefinition
  metadata:
    creationTimestamp: 2019-03-29T09:30:40Z
    generation: 1
    name: ovs-net-1
    namespace: default
    resourceVersion: "939292"
    selfLink: /apis/k8s.cni.cncf.io/v1/namespaces/default/network-attachment-definitions/ovs-net-1
    uid: 513374e5-5205-11e9-89a0-fa163eb2fcd4
  spec:
    config: '{ "cniVersion": "0.3.1", "type": "ovs", "bridge": "testbridge" }'
kind: List
metadata:
  resourceVersion: ""
  selfLink: ""

Target pod yaml info (with annotation, use kubectl get pod <podname> -o yaml)
Other log outputs (if you use multus logging)

Currently we use "network-attachment-definition (network-attachment-definitions)" for custom resource name, so that is why we do not use "NetworkAttachmentDefinition" for its name, as Spec defines as following:
apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
  name: network-attachment-definitions.k8s.cni.cncf.io
spec:
  group: k8s.cni.cncf.io
  version: v1
  scope: Namespaced
  names:
        plural: network-attachment-definitions
        singular: network-attachment-definition
        kind: NetworkAttachmentDefinition
        shortNames:
        - net-attach-def
  validation:
    openAPIV3Schema:
      properties:
        spec:
          properties:
            config:
              type: string

You could also add an extra short name:
        shortNames:
        - net-attach-def
        - NetworkAttachmentDefinition


Cannot properly type Props for Higher Order React components

Given the following wrapper react component
class Wrapper extends React.Component {
   constructor(props) {
        super(props);
   }
   onChangeHandler() {
   }
   render() {
       return React.cloneElement(this.props.children, {onChange: this.onChangeHandler});
   }
}

and the following wrapped component
type CompProps = {
   onChange: ():void
}

class WrappedComp extends React.Component<void, CompProps, void> {
   render() {
      return

  }
}

When the following hierarchy is being rendered:
<Wrapper>
    <WrappedComp />
</Wrapper>

Flow 0.22.1 keeps on complaining about missing onChange prop.
We have loads of patterns very similar to this in our projects.
Is there a way to have Flow recognize that the onChange prop is being passed by means of React.cloneElement and not directly as component prop ?
Making the onChange nullable is not  an option as it would force lots of checks all over the place for the props existance when this is not really an issue in reality.

Related: #1523

I think this issue should be closed in favor of #1523

I found a fix. Caveat. It needs the undocumented magic type $Diff.
Just put something like this in a .flow file next to your HOC file.
declare function inject<Config> (
  dependencies: any,
  Komponent: ReactClass<Config>
): ReactClass<$Diff<Config, InjectedProps>>

module.exports = inject

Update: React doesn't seem to work very well with $Diff is most cases.
When writing an object as in:
const obj: $Diff = { ... }

It works correctly. But in all other cases, it doesn't seem to be working at all.

UPDATE: Good News. Found a solution that actually works.
Instead of explaining here's an example with the errors
/* @flow */
import React from 'react'

type Props = {abacus: string, bear: number}

class Test extends React.Component<void, Props, void> {
  render () {
    return
Hello

  }
}

// It incorrectly warns that Test is not of type `Class<React$Component<D, P, S>>`
declare function hoc<D, P, S>(component: Class<React$Component<D, P, S>>, config: any): Class<React$Component<D, $Diff
, S>>

const HOCTest = hoc(Test, {})

// This works correctly, it knows you don't need `bear`
const y = <HOCTest abacus='sd' />

// These are errors
const y = <HOCTest /> // missing prop
const y = <HOCTest abacus={12} /> // incorrect type for abacus

So, this solution needs one surpassing comment, but is overall the best solution I've found. It actually type checks the components correctly.

@nmn Did you mean bear: number where it says bb: number ?

@namuol Thanks! fixed.

Unfortunately this doesn't work with functional components and I looking at https://github.com/facebook/flow/commit/a66c76453fb105bbaa250874a6d65c70d08300c8 it seems it's impossible to use the type for React components in "userland".

@andreypopp It CAN be made to work for functional components:
/* @flow */
import React from 'react'

type Props = {abacus: string, bear: number}

class Test extends React.Component<void, Props, void> {
  render () {
    return
Hello

  }
}

type Hoc = <D, P, S, C: React$Component<D, P, S>>(
  component: Class<C>,
  config: any
): Class<React$Component<D, $Diff
, S>> &

(
  component: (props: P) => any,
  config: any
): Class<React$Component<void, $Diff
, void>>

declare var hoc: Hoc

const HOCTest = hoc(Test, {})

// This works correctly, it knows you don't need `bear`
const y = <HOCTest abacus='sd' />

// These are errors
const y = <HOCTest /> // missing prop
const y = <HOCTest abacus={12} /> // incorrect type for abacus

So essentially just overloading the type of the HOC to accept a function instead of a React$Component.
Bonus: This works with flow 0.24-0.25. Which don't otherwise type check functional components.
I'll take a look at flow 0.26 and see if something needs to be changed to make it work correctly there.
Note: Your function component will have to be typed correctly to make default props optional as functional components don't come with some special object to declare default props.

@nmn thanks, will try it, I tried to do a union of class and function component types but it is clear to me now why you do intersection here instead.

@nmn @samwgoldman This is a different case than the HOC in #1523; that example uses a decorator function, whereas this uses a wrapper component that injects props with cloneElement.  There is nothing in the docks about wrapper-style HOCs like the example in the OP is there?

@jedwards1211 You're absolutely right, the above solutions don't actually work for the OP case. I took a crack at it tonight, and came up short. But Maybe someone could point me in the right direction?
type Props = {
  foo: string,
  bar: string,
};

type DefaultProps = {
  foo: string,
};

declare class React2$Element<Config, DP> extends React$Element{
  type: _ReactClass<DP, *, Config, *>;
}

declare function Hoc<Config, DP: DefaultProps, R: React$Element<Config>>(props: {children: R}) : React2$Element<Config, DP>

function TestComponent({foo, bar}: Props){
  return
{bar}
;
}

function Hoc(props){
  return React.cloneElement(props.children, {foo: 'form2wr'});
}

function Test(){
  return <Hoc children={<TestComponent bar='yo' />}></Hoc>;
}

Technically, this is cheating because I'm replacing the default props with the hoc props, but I'm willing to sacrifice default props if it gives me a solution here.
This is all based off of https://github.com/facebook/flow/blob/v0.29.0/lib/react.js#L121


Implement retry mechanism for failing DB queries

Description
Caused by the increased isolation level in PG, it can happen that particualr queries are failing caused by colliding DB transactions.
Postgres expectes that the client is retrying such queries by its own when using an isolatio level >= repeatable read (see PG docs):
Applications using this level must be prepared to retry transactions due to serialisation failures.
The DB layer of the mothership reconciler has to consider such error and retry such issues automatically.
Expected result
DB error indicating a colliding DB transaction (e.g. pq: could not serialize access due to read/write dependencies among transactions) have to be catched and a retry has to happen.
Actual result
DB retry errors are ignored and lead to errors in the log.
Steps to reproduce

Troubleshooting

Fix is part of https://github.com/kyma-incubator/reconciler/pull/757


git plugin do not use git.exe in the path anymore

VSCode Version: Code - Insiders 1.19.0-insider (0c60476e5167d4bdcf01cc48558b2e1faf0edae1, 2017-11-23T06:12:57.338Z)
OS Version: Windows_NT ia32 10.0.16299
Extensions:

Extension
Author (truncated)
Version

markdown-toc
Ala
1.5.6

pascal
ale
0.10.0

vscode-markdownlint
Dav
0.11.1

vscode-eslint
dba
1.4.3

gitlens
eam
6.1.2

tslint
eg2
1.0.23

shell-format
fox
1.1.1

nim
kos
0.5.27

expand-region
let
0.1.2

sublime-keybindings
ms-
3.0.3

vshaxe
nad
1.9.3

vscode-icons
rob
7.18.1

code-settings-sync
Sha
2.8.6

pegjs-language
Sir
0.1.0

shellcheck
tim
0.2.1

gitflow
vec
1.1.1

expand-selection-to-scope
vit
0.2.0

haxe-extension-pack
vsh
1.0.0

codedox
wig
1.2.5

change-case
wma
1.0.0

join-lines
wma
0.2.2

JavaScriptSnippets
xab
1.5.0

(1 theme extensions excluded)

Steps to Reproduce:

Have git installed via scoop.sh and in the PATH (it was working in previous VSCode versions)
Start VS Code and see output windows for git

Reproduces without extensions: Yes

I've found a workaround:
insert in ..user/settings.json
{ ...,
    "git.path": "git"
}

Please consider to patch the function in git.js from this:
function findGitWin32(onLookup) {
    return findSystemGitWin32(process.env['ProgramW6432'], onLookup)
        .then(void 0, () => findSystemGitWin32(process.env['ProgramFiles(x86)'], onLookup))
        .then(void 0, () => findSystemGitWin32(process.env['ProgramFiles'], onLookup));
}

to this:
function findGitWin32(onLookup) {
    return findSystemGitWin32(process.env['ProgramW6432'], onLookup)
        .then(void 0, () => findSystemGitWin32(process.env['ProgramFiles(x86)'], onLookup))
        .then(void 0, () => findSystemGitWin32(process.env['ProgramFiles'], onLookup))
        .then(void 0, () => findSpecificGit('git', onLookup));
}

We had that since inception. It happens to break a lot of people: https://github.com/Microsoft/vscode/issues/32739#issuecomment-341177471 (and a lot of duplicate issues)

@joaomoreno Have you already tried the standard node which module for finding git on the system path? It works well on all of my machines (famous last words), and I never install git in those three locations vscode currently checks. It had almost 20 million downloads last month alone.
https://www.npmjs.com/package/which


[CI Problem] ci_gpu fails to build trying to use missing GPG Key

Raising to track: https://github.com/NVIDIA/nvidia-docker/issues/1631
Branch/PR Failing
#11162
Jenkins Link
https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-11162/7/pipeline/62

Looks like we need to add some steps to Dockerfile.ci_gpu:
https://forums.developer.nvidia.com/t/notice-cuda-linux-repository-key-rotation/212772


up arrow on wrong place

sometimes when you open a link, the top arrow appear under the divider

try opening this: https://canary.kodadot.xyz/ksm/explore/items?listed=true&page=2

sometimes when you open a link, the top arrow appear under the divider

It is a page-turning button used to load the previous page manually : )

sometimes when you open a link, the top arrow appear under the divider

It is a page-turning button used to load the previous page manually : )

So is it bug?

sometimes when you open a link, the top arrow appear under the divider

It is a page-turning button used to load the previous page manually : )

So is it bug?

We put the button there to avoid some wired bug on the infinite scroll while scrolling up, so it's by design. However, we could set a better UI for this pagination button.


Illustrate performance gain of each pretrained models & how each models got lighter

For each pretrained models, display

wandb log
table which consists of maximum f1 score in 100 epochs and FLOPS(either inference time)
percentage gain in both metrics of f1 score and FLOPS(either inference time)

It seems important which device(CPU or GPU, v100 or smaller) will measure the inference time.

@lkm2835
I am thinking of Colab basic as a barometer for computing power.
According to stackoverflow post, Colab's computing power is

GPU: Teska K80
CPU: 1xsingle core hyper threaded Xeon Processors @2.3Ghz i.e(1 core, 2 threads)

But torch's version compatibility might cause a problem.
Affixing torch and torchvision version to colab's version is one of the candidate I am considering on.


juicefs rmr should not fatal when file not exists

What would you like to be added:
juicefs rmr /jfs/abc
2022/12/05 02:48:04.937860 juicefs[135] <FATAL>: RMR /jfs/abc: no such file or directory [rmr.go:105]

Why is this needed:

Similar to rm -r , exit 1 if dir not exist


Clarify dependencies for installation on Ubuntu

I experimented with running curl https://cli.nexus.xyz | sh on a fresh E2 GCP instance running Debian Ubuntu, but faced a few challenges. First, it seems that the CLI requires build-essential, pkg-config, libssl-dev (OpenSSL),  and git as dependencies.
So installation on Ubuntu would look like this:

sudo apt update
sudo apt upgrade
sudo apt install build-essential pkg-config libssl-dev git-all
curl https://cli.nexus.xyz | sh

We may want to add this to docs.nexus.xyz.

Nice its working!

Fixed in #18


Adding support for Java 8 metaspace to fix #1790

See #1790 for summary of the issue. While testing I also found that there is java 8 code in ShellUtils that I fixed to be compatible with Java 7.

@objmagic I cache the result of _get_jvm_version so I don't need to keep spinning up new JVMs to check the version repeatedly. The cached value is self.jvm_version.

@billonahill oh I misread and thought self.jvm_version was already added before. This is good choice 👍

@kramasamy the bin/java approach is what's used in a number of places in the existing code. I'd prefer for that change to be tackled in a PR of it's own, to keep the changes and scope clean.
Regarding the version string, yes java -version can output just about anything. That's why I wrote com.twitter.heron.instance.util.JvmVersion which just outputs the version string. This makes parsing much more resilient and reliable.

putting this into 0.14.7 for OSS testing. Is it OK? @billonahill

@objmagic yes. Just got the final approval and merges. Timur has identified other params that we might want to add as well fyi.


fix(graphql): detect resource update on graphql api auth mode change

Description of changes
Bug fix for auth mode updates not detected as resource change.
Description of how you validated changes

yarn test
manual test

Checklist

[x] PR description included
[x] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Can you link to the original GH issue in the PR description?

Codecov Report

Merging #8782 (c02f314) into releaseGQLE2E (8a308a8) will decrease coverage by 0.01%.
The diff coverage is 21.42%.

@@                Coverage Diff                @@
##           releaseGQLE2E    #8782      +/-   ##
=================================================
- Coverage          57.02%   57.01%   -0.02%
=================================================
  Files                757      757
  Lines              42949    42962      +13
  Branches            9566     9575       +9
=================================================
+ Hits               24491    24493       +2
- Misses             16544    16553       +9
- Partials            1914     1916       +2

Impacted Files
Coverage Δ

...-awscloudformation/src/transform-graphql-schema.ts
14.02% <10.00%> (-0.13%)
:arrow_down:

...rc/graphql-transformer/transform-graphql-schema.ts
15.57% <33.33%> (-0.13%)
:arrow_down:

...tils/awscloudformation/cfn-api-artifact-handler.ts
85.93% <100.00%> (+0.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a308a8...c02f314. Read the comment docs.

It's this one: https://github.com/aws-amplify/amplify-cli/issues/4914
Updated the PR description with it


Request: Add eralchemy to nixpkgs

I'm sadly not doing any work with Python, but it would be very cool if anybody is able to add eralchemy to Nixpkgs.
Different things (just as question):
Is it possible to change the font size and lowercase the types in the output image?
Is it possible to color the table name background in any way?

I currently came up with the following two nix derivations.

The first one to be used with nix-build.
This is the one I think I could possibly add to the nix store if anyone interested.
The second one was just my first attempt to get eralchemy quickly working within nix-shell.

{ pkgs ? import <nixpkgs> }:
{
  eralchemy = pkgs.python27.pkgs.buildPythonPackage rec {
    pname = "ERAlchemy";
    version = "1.2.10";

    src = pkgs.python27.pkgs.fetchPypi {
      inherit pname version;
      sha256 = "be992624878278195c3240b90523acb35d97453f1a350c44b4311d4333940f0d";
    };

    propagatedBuildInputs = [
      pkgs.graphviz
      pkgs.python27Packages.psycopg2
      pkgs.python27Packages.sqlalchemy
      pkgs.python27Packages.pygraphviz
    ];
  };

  eralchemy_shell = pkgs.mkShell {
    buildInputs = [
      pkgs.python37
      pkgs.python36Packages.pip

      pkgs.graphviz
      pkgs.python36Packages.psycopg2
      pkgs.python36Packages.sqlalchemy
      pkgs.python36Packages.pygraphviz
    ];
    shellHook = ''
      mkdir -p _build/pip_packages
      alias pip="PIP_PREFIX='$(pwd)/_build/pip_packages' \pip"
      export PYTHONPATH="$(pwd)/_build/pip_packages/lib/python3.6/site-packages:$PYTHONPATH"
      unset SOURCE_DATE_EPOCH

      pip install eralchemy --no-warn-script-location
      export PATH="$(pwd)/_build/pip_packages/bin:$PATH"
    '';
  };
}

By the way thank you very much for this cool tool.
I'll use it now to automatically generate ERDs for my project documentation.

I'm closing this as it is not really an issue.


add twitter scraper

wip

write a comment and tag me when i should review this

@gabrieltorresgamez pls review scraper


"replace"  issue

Hi,
I have an issue with the replace method of Cobol85PreprocessorImpl class.
The problem could happen when there are two identifiers in currentReplaceableReplacements whose name is a substring of each other. Example:
REPLACE
==TEST1== by =='VAL1'==
==TEST1-SECOND-PART== by =='VAL2'==

Depending on the order of substitution, you could have this kind of results
'VAL1'-SECOND-PART  instead of 'VAL2' when processing TEST1-SECOND-PART
I'll try to order the substitution (sort on lenght of tokens and process the longest first)
Thanks

Hi @acaramia,
yes, please feel free to make a pull request. Currently, I am making refinements to the grammar. So, if you are missing features or find bugs, let me know.
Thanks,
Ulrich

merged pull request


issues with conda version of scaden

Hi :)
I have been trying to use Scaden lately and I ran into a number of things. A tool like scaden which may need a minimum RAM of 16GB is usually used on a cluster, where majority of the users would not have the root privilege. So I personally insist the developer to mention all the dependencies required by the tool. How to use the tool is pretty well documented but not how to install it and other requirements. So long story short I managed to install it using conda and scaden example doesn't seem to work (needed to understand the basic input format to the tool). I get the following response :
(scaden) urangasw@valis:~/scaden_example$ scaden example
/home/urangasw/miniconda3/envs/scaden/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:455: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_qint8 = np.dtype([("qint8", np.int8, 1)])
/home/urangasw/miniconda3/envs/scaden/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:456: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_quint8 = np.dtype([("quint8", np.uint8, 1)])
/home/urangasw/miniconda3/envs/scaden/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:457: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_qint16 = np.dtype([("qint16", np.int16, 1)])
/home/urangasw/miniconda3/envs/scaden/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:458: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_quint16 = np.dtype([("quint16", np.uint16, 1)])
/home/urangasw/miniconda3/envs/scaden/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:459: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  _np_qint32 = np.dtype([("qint32", np.int32, 1)])
/home/urangasw/miniconda3/envs/scaden/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:462: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
  np_resource = np.dtype([("resource", np.ubyte, 1)])
/home/urangasw/miniconda3/envs/scaden/lib/python3.6/site-packages/anndata/core/anndata.py:17: FutureWarning: pandas.core.index is deprecated and will be removed in a future version.  The public classes are available in the top-level namespace.
  from pandas.core.index import RangeIndex

     ____                _
    / ___|  ___ __ _  __| | ___ _ __
    \___ \ / __/ _` |/ _` |/ _ \ '_ \
     ___) | (_| (_| | (_| |  __/ | | |
    |____/ \___\__,_|\__,_|\___|_| |_|

Usage: scaden [OPTIONS] COMMAND [ARGS]...
Try 'scaden --help' for help.

Error: No such command 'example'.

Please let me know how I can go about it, be it using pip or conda and the respective versions of various dependencies that scaden is compatible with.

Hi @me37uday ,
Scaden actually doesn't need a lot of resources, and 16 GB should be more than enough in most cases. Most modern workstations/laptops that are used for bioinformatics should have enough power.
Every dependency of Scaden is listed in the setup.py file, if you want to install them manually.
I think there is documentation for installation, you can just use pip or conda, both should hopefully work (at least on Linux).
I recommend using some form of environments. In your case you seem to have installed an older version of Scaden which lacks the scaden example command.
By the way, there is also a Docker container you could use. So plenty of options :-)
Let me know if that helps!
Cheers,
Kevin

Thanks for your response :)
Is conda version of Scaden working? I am using a Linux machine as well. I created a conda environment with python 3.6.13 and used the command conda install -c bioconda scaden and the above version was installed.
Should I mention the scaden version to be installed in the above mentioned conda command? Please let me know :)
Thanks,
Uday

Hi @KevinMenden ,
Thanks for your response.
I got it working by simply using pip :)
The procedure and command was as follows :

created a conda environment with specific python version using  :

conda create -n scaden python=3.9

installed pip in the environment (if need be)

conda install pip

installed scaden using :

pip install scaden==1.1.2
scaden example is working as mentioned in the manual :)
Thanks,
Uday

Cool, nice to see that you got it working!
I did experience some issues with installing from conda in the past but couldnt pinpoint the issue. Pip is the easiest way indeed 👍


Add photo

Closes #16

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:


Compatibility with FVTT V11

Hi, I love this module and would really appreciate if you could upgrade it to V11

Yes, please!

It looks like that might be dead. Too bad, it was a great module. I forced it into V11 by editing the module.json and unfortunately the functionality is completely broken.

Ack, I did enjoy this module. :(

Beholder, Dragon, Aarakocra, Wizard and Fly spell, Birds, Imps...
Since I upgraded to version 11 of Foundry, I miss this module a lot!

Works in V12 if you turn on all tokens can fly.

I'll give it a shot. Thanks for the tip !


feature(productProjection): add "old" process method

copied it from here: https://github.com/sphereio/sphere-node-sdk/blob/v1.3.7/src/coffee/services/base.coffee#L321
adaptions:

use createdAt for sorting, since sorting by ID is not supported by the search endpoint
fallback to the process function of base if the endpoint is not 'search'

@emmenko @hajoeichler

I just talked to @OlegIlyenko and @agourlay about using the search-endpoint for exporting. As it turns out this is not a good and performant way of exporting and we should not encourage making use of the search-endpoint as a way to get loads of data out of CTP.


Include Eloquent Model Observers in model:show command

(@jessarcher  Resubmitting PR 43470 as the suggested code changes don't seem to sync on closed PRs)
This PR builds on the new artisan model:show command to also list Model Observers. They could be handy to see on the Model information as it's not always obvious that a Model is being observed.
It handles cases where multiple observers are attached to an action.

Thanks!


Make the effect transparent

fixes #46
I was thinking it would be much better if the effect was transparent and we could overlay the effect over anything we wanted. Say for example on a website where it could be playing over the UI, or perhaps as a wallpaper where the background doesn't have to be so monotonously bland and you had the option to set a background image.
overview of what I did:

Set alpha of pallettePass, stripePass, imagePass and mirrorPass to 0 (i think 💀) and remove the backgroundColor variables
I didn't do the same for the "Debug View" effect
renamed url to glyphURL and bgURL to glyphBGURL
added a new config option bgURL and config property pageBGURL
implemented backgroundColor and pageBGURL to set the color or image of the page body

A cool idea would be to use bgURL to show a normal city and glyphURL to show a matrix version of the same city, but I wouldn't know how to make such images tho :')

Thanks for this! I promise I'll pore over it soon.

Sorry for the delay @FieryRMS !
I did a git checkout of this PR and tested it locally, but in Mac Firefox, Mac Safari or Mac Chrome Canary, all I see is a black window (unless I change the alpha in the final passes' outputs back to 1.0). What browser/OS combo, or other context, are you able to get this PR to work in?
I wonder if this is like ANGLE in Chrome doing something on Windows. I'd love to find out.
Anyway, I certainly get the intent of the change— use CSS to load up a background image, rename the existing URL-accepting parameter to fill in glyphs or something, and make sure the canvas winds up transparent, at least in places.
I'll admit that I've intentionally dodged the issue of alpha in the past, just because it's easier to pretend it doesn't exist. It invites questions about occlusion, like how much light can pass through a glyph. To my knowledge, in the movies, if Matrix code shows up on or in front of a thing, it glows on top of the thing; it's transparent, but it's order-independent. So I've held the rationale that all anyone might want to do with this project would boil down to setting mix-blend-mode on an iframe or something.
This PR is much more intentional. Again, I can't see it in action yet, but presumably it resembles the current mirror effect, except instead of a camera feed it displays a background image (and there's no ripples, but that's unimportant for now). What I don't yet comprehend is how the colors in the output-with-zero-alpha get composited onto that image. I thought I knew this stuff. 😄
I have a hunch that we'll want to channel glyph brightness into opacity by the end of this, with a multiplier param. More on that later.
One other thing to get around to after we figure out how I can get it to work on my machine is, how can this be introduced while still supporting the old config? I have no guide for contributors yet— oops— but one challenge to the design of this project is that I don't break any existing URLs. In other words, we can't get rid of the params that drive the current "background color", we can just expand the config to express a broader range of options.
Sorry for rambling! I look forward to getting it working on my machine 👍

Hey @Rezmason,
I am using Windows 10 Pro N 19044.2251 as my OS and as for my browsers I tested on the following versions,
Google Chrome: 107.0.5304.107 (Official Build) (64-bit) (cohort: Stable)
Google Chrome:	110.0.5443.0 (Official Build) canary (64-bit) (cohort: Clang-64)
As for visual changes I found minimal differences between them.
Screenshots
(no params)

(?renderer=webgpu)

(?backgroundColor=1,1,1&effect=stripes&stripeColors=1,1,1)

for some reason setting everything white doesn't set everything white on the original, it's slightly grey.
Screenshots showcasing changes
(?bgURL=bg.jpg&version=megacity&volumetric=true&forwardspeed=0.2&density=2)

(?bgURL=bg.jpg&bloomStrength=1&bloomSize=1)

The glyphs seems to be slightly transparent and is glowing on top of the image like you said.
As shown above, the original implementation of backgroundColor can be completely replaced by the new implementation, as it really doesn't have much difference. In fact, I think original one introduces some artifacts, where the background has some grainy noise and doesn't show the actual color when set, as shown by the 3rd screenshot above. Perhaps instead of setting the color or image of the body, we can set them on the canvas, hence removing any issues that people who are already using the project might face, preventing break of existing urls. I actually tried this before, but didn't like that it showed the black background for a split second when going full screen on double click. On hindsight, perhaps I was being petty and it really wasn't that big of a deal.
Another thing that might break existing urls is the renaming of the url param, although its a simple fix, thought I should still mention it again. I couldn't think of anything else at that moment that would be a less confusing name for the background url so I opted to change the name the existing param.
Not that I knew any of this before (in fact I am a complete noob), I, too, don't understand how setting alpha to 0 is producing an image 💀💀
On a separate topic, what does glintColor do? I couldn't find any difference when I set this variable, hence couldn't test if it worked after I made the changes.

Where's the red text skull image from? It looks fantastic.
To answer your question, glintColor is used when isolateGlint is set to true. For instance, in the Bugs variation, the blue glowing bits are the glint. Glint was added to the matrix code in the Resurrections opening titles; a related but distinctly different glint effect was used in Resurrections' on-screen code.
Anyway, those screenshots look good! It's almost definitely a weird Windows/Chrome/ANGLE thing that's causing it to work at all, but the screenshots alone help specify the desired effect.
I've done some experimenting, and by changing the alpha values back to 1.0 and setting the canvas CSS style's mix-blend-mode: screen;, I can produce the same result, I think, in my browsers:

By using a bright image as background, and a dark-code-over-light-background version of the effect with the mix-blend-mode set to multiply, we can produce a related interesting effect:

I propose we make an examples folder that demonstrates these in independent HTML files. In fact, an examples folder would generally simplify the project by showing visitors how they can leverage it without adding features.
In the meantime, it's worth it for us to just try to drive opacity from glyph intensity, to see what happens. I'll give it a shot in the next couple days, using this PR as a jumping-off point; it probably boils down to expanding color support to include alpha, so paletteRGB and paletteHSL would additionally get paletteRGBA and paletteHSLA, etc etc. A little messy, but still backwards-compatible.

@FieryRMS do you have a url parameter to set the black background to transparent (alpha 0)? I'm trying to use it as a wallpaper so the idea is to have the rain code on top of the desktop

I really dropped the ball on this issue. I'm sorry about that, folks, when I committed to this one I figured I'd have the bandwidth to tackle it in weeks, certainly not years.
For what it's worth, I intend to get this stuff done by the end of this month (February 2024).

If there's something I can help with even testing let me know


add timeout to http client

this adds a timeout to the http client.
for some reason clients using this lib sometimes stop sending metrics.
we assume this is due to the missing timeout and a endless hanging http-request.

@ksophocleous please take a look

LGTM2


fix: business attribute empty bubble selection issue

Bug Link - https://github.com/datahub-project/datahub/issues/11719
Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

/build


Refactor pkg/run

Update doc comments to match Go's convention
https://golang.org/doc/effective_go.html
Reorganize imports to match convention
Call errors 'err', no need for prefixes

I'll be touching this file for fixing concurrency issues, didn't want to get stylistic changes mixed up with that.
@soltysh @gabemontero PTAL

lgtm [merge]


How to avoid data leakage?

In the "Data sets and Preprocessing" section of your paper, you mention that " we removed all proteins from the training set that had either sequence identity greater than 50% or ligand similarity greater than 0.9 and sequence identity greater than 30%".

How do you define sequence identity and ligand similarity?
Could you provide the scripts to calculate sequence identity and ligand similarity?
You mention twice sequence identities which are greater than 50% and 30%. Do you mean the protein sequence identity greater than 50% and ligand sequence identity greater than 30%?

Hey, you can check out the code for creating sequence based splits here: https://github.com/gnina/scripts#generating-clustered-cross-validation-splits-of-data
for ligand similarity we use tanimoto, not sequence. we consider protein similarity of 30% when ligand tanimoto similarity is greater than 0.9


Latest 0 will dismiss if use number as item value

Refer to my pic, if you put an item value like "balala.10", the latest 0 will gone and only "balala.1" left

http://nodeca.github.io/js-yaml/#yaml=dmVyc2lvbjogMS4xMAp2OiAnMS4xMCcKYmFsYTogYmFsYWxhLjEw
Everything works as expected.