"Terminal: clear" does not work with vscode-R

VSCode Version: March 2020 (version 1.44)
VSCode-R Version: 1.3.0
OS Version: Windows 10 1909 (italian)
Create an R file and run R in vscode
Run the vscode command "Terminal: clear" and observe that the terminal clears
Run the source or a line
the R code is executed but the cleared code reappears

I cannot reproduce what you observe. Would you like to elaborate or provide some screenshots?

run R in the terminal

write some code in the terminal, for instance print a dataframe

clear the terminal (ctrl+shift+p and write the command terminal: clear)

now run the code from the script (in this example I run the source with ctrl+shift+s but there is the same problem if you run only one line or the selection)

the cleaned code in the terminal reappears

vscode-R does nothing about terminal context storage. I guess it is an issue of VSCode terminal under Windows. @andycraig any idea on this?

I'm sorry,
I confirm that it is a vscode problem: after your reply, I tested with python and there is the same problem and I found some bug-report not solved and closed about it, for instance:
https://github.com/microsoft/vscode/issues/81299
I also observed that the R function shell("cls") solves the problem in windows (and maybe some other arguments are necessary for other OS).
Therefore, before closing this issue I would like to ask you if you can integrate a shortcut to run it.
Best
Alberto
PS: previously I noticed another issue in Windows with the Italian keyboard (https://github.com/Ikuyadeu/vscode-R/issues/145) that it was due to Rterm.exe, therefore, I reported it to the R developers (https://bugs.r-project.org/bugzilla/show_bug.cgi?id=17679) now solved in R version 4.0.0. I really desire an RStudio alternative!

You may take a look at https://github.com/Ikuyadeu/vscode-R/wiki/Keyboard-shortcuts#creating-keybindings-for-r-commands and create your own command shortcut keys by yourself.

thank you

PS: previously I noticed another issue in Windows with the Italian keyboard (#145) that it was due to Rterm.exe, therefore, I reported it to the R developers (https://bugs.r-project.org/bugzilla/show_bug.cgi?id=17679) now solved in R version 4.0.0.

@arcalb Thank you for this update! Good on you for reporting it to the R team and I'm pleased to hear it was resolved. I'll copy this over to the original issue too.


proposal: enable staticcheck

Background
I noticed that our linters do not catch unused variables. Upon running staticcheck with:
staticcheck $(go list ./...)

I discovered around 30 lint issues related to unused code. We should consider enabling staticcheck as this is a useful static analysis tool.
Suggested Design
We can enable it via golanglint-ci without much effort:
https://github.com/osmosis-labs/osmosis/blob/a785de13eebcfd91b6807458fbcf8ffaff105bb5/.golangci.yml#L71
Acceptance Criteria

staticcheck is enabled
all dead code / unused variables are removed

IIRC, staticcheck is super slow

You're right. It's slow. Took 5 seconds on the first pass. Reused cache a second time, taking approximately 1 second.
To mitigate, what do you think about the following:

adding a makefile step that is separate from our main golangci-lint linter i.e make staticcheck

This should only be used if someone sees CI failing and wants to reproduce locally
Our regular linting is done separately by golangci-lint where it has staticcheck disabled

separate CI job for staticcheck that runs in parallel with other jobs

Our bottlenecks are tests, both e2e and unit so 5 seconds should not be a problem

Disabling noise like deprecation linter and anything else we might see later

I just shot myself in the foot in https://github.com/osmosis-labs/osmosis/pull/1857 by leaving a lot of unused code. Since we tend to be working on many PRs concurrently while waiting on feedback, it's easy to miss things like this when context switching.
staticcheck in CI should be able to automate away this cognitive overhead for both the PR author and the reviewer.

Why not just add the deadcode linter?

I've been framing this in terms of the dead code detection benefit so far because of recency bias.
However, staticcheck is also useful for the variety of other checks it supports, helping spot erroneous errors and maintain code standards. It would also help reduce manual linting in PRs.
With only a quick skim, these are the linters that I've seen to be manually pointed out in our reviews that can be covered by staticcheck instead:

Simplify error construction with fmt.Errorf - https://staticcheck.io/docs/checks/#S1028
Merge variable declaration and assignment - https://staticcheck.io/docs/checks/#S1021
Convert if/else-if chain to tagged switch - https://staticcheck.io/docs/checks/#QF1003
The documentation of an exported function should start with the function’s name - https://staticcheck.io/docs/checks/#ST1020
Simplify returning boolean expression - https://staticcheck.io/docs/checks/#S1008

Since our goal is to minimize manual linting in the code reviews and offset this work to linter, staticcheck can help, reducing the workload on the reviewer.
It would also help standardize the coding standards/styles across the repository. Currently, the styles are inconsistent, reducing the overall readability. We can always remove linters that we don't like as we go along.
From my experience, staticcheck has proved to be a useful tool for catching erroneous errors. It has also been helpful in pointing out the details and optimizations of Go, helping me learn.

Just checked:

On my laptop first run takes 16 seconds
Second run immediately after took 1.5 ish seconds

It had a 5x speedup in 2019: https://staticcheck.io/changes/2019.2/ , and another big one in 2020: https://staticcheck.io/changes/2020.2/ , so thats why the recollection of minutes is wrong.
Of the lints you were listing, I'm not totally sold on a lot of them being important or worth the slowdown.
I feel mediumly strongly that there should be:

Only one linting process for main
Should be blazingly quick (It should be doable on save, and I don't think about it)

Maybe its the case that static check on a small number of items is fast! Or that we can have offload some of these goals to other linters
I'm down for a second pre-release or pre-tag linting process thats slower.
cc @alexanderbez for further thoughts

Looking into this more, the golangci-lint gosimple linter is a subset of the staticcheck linters, namely these: https://github.com/dominikh/go-tools/blob/master/simple/doc.go (Every lint that is S####)
Which of the ones you listed is most of them, and has ~no execution time tradeoff. If we want stylecheck, thats also separated out into its own linter with golangci-lint. Similar for QF as "QuickFix"
Perhaps we should go with the approach of enabling the components of staticcheck we want via golangci-lint?

Good catch, seems that there are 4 components:

staticcheck: https://github.com/dominikh/go-tools/blob/331bcca40621580531c9b8a9cb7d5c2c06c709d2/staticcheck/analysis.go#L23
stylecheck: https://github.com/dominikh/go-tools/blob/331bcca40621580531c9b8a9cb7d5c2c06c709d2/stylecheck/analysis.go#L14
simple: https://github.com/dominikh/go-tools/blob/331bcca40621580531c9b8a9cb7d5c2c06c709d2/simple/analysis.go#L11
unused: https://github.com/dominikh/go-tools/blob/331bcca40621580531c9b8a9cb7d5c2c06c709d2/unused/unused.go#L418

From what I understand, there is a staticcheck binary that has these all and a staticcheck set of rules. Seems that golangci-lint is referring to the set of rules in its configuration.
I will try to start enabling these ones by one in upcoming PRs so we can see what makes sense

The candidates to be removed if golangci-lint run time becomes an issue, in my opinion, are:

gosimple: https://github.com/osmosis-labs/osmosis/pull/1957#issuecomment-1174017505
stylecheck: https://github.com/osmosis-labs/osmosis/pull/1960#issuecomment-1174058394

I think we added all sub-components! If make lint times are getting annoying, we'll come back and start turning some off


Arbitrary HTML asset aggregation

We already have CSS/JS asset aggregation. I’d like to see this with arbitrary HTML too. Think of a single WebC component file for a web font that includes both the @font-face CSS and the preload HTML together! Or a WebC icon that only includes a single <g> that aggregates up to a reusable de-duplicated SVG icon set.

<style webc:bucket="priority">
@font-face {
  src: url("font.woff2") format("woff2");
}
</style>

<template webc:bucket="header">
  <link rel="preload" href="font.woff2" as="font" type="font/woff2" crossorigin>
</template>

<template webc:bucket="svg-icon">
  <g id="icon-arrow”>
    <path d="…"></path>
  </g>
</template>

The bundle plugin has this functionality: https://github.com/11ty/eleventy-plugin-bundle (it needs to be wired up to WebC though)
see also https://github.com/11ty/eleventy-plugin-webc/issues/48


Hacktoberfest

Hi @nikhilmufc7 , I've done some cleanup on the index file.

Indentation fixed
Lines sorted

hi please can you resolve the merge conflicts , i'll merge straight after, thanks! @wdhif

@nikhilmufc7 Done :) can you tag the PR Hacktoberfest ?

Done, thanks a lot!


http: prefetch for upstreams

Commit Message: Adding predictive prefetch (useful mainly for HTTP/1.1 and TCP proxying) and uncommenting prefetch config.
Additional Description:
Risk Level: low (mostly config guarded)
Testing: unit, integration tests
Docs Changes: APIs unhidden
Release Notes: inline
Fixes #2755

Tagging @antoniovicente for API discussion and code review (which I think is mostly ready to look at) but I don't want this PR landing until we have a solid API plan for mobile and I need some help from the mobile folks on that (cc @mattklein123 @junr03 @goaway)
For server-side prefetch, I think we generally want to have load-adjusted prefetch which is what is implemented.  As the rate of queries go up, more connections are prefetched.
For mobile, AFIK for HTTP/1.1 we want to prefetch a fixed (maybe configurable, but fixed) number of connections per logical endpoint. (last I was paying attention was years ago, when I think it was usually either 6 or 8). Basically if you have one request for www.google.com you establish 6 connections on the assumption there will be a bunch of follow-up requests, and you want to head off latency issues.  So I think for one of these fields we're going to want to have a one-of between ratio-based and fixed-config.
What I'm not sure of, is what that looks like for mobile today, is which one.  I assume we're going to do DNS resolution, get back a few results, but only talk to one IPv4 or IPv6 address (not load balance across DNS results). If so I think we'd want to make the per-host prefetch either ratio-based or fixed, rather than the per-cluster prefetch?

Or maybe we want this server-side as well, for the moral equivalent of
min_connections_picked and it shouldn't be a one-of?  Thoughts?
On Mon, Nov 23, 2020 at 8:59 AM repokitteh[bot]<EMAIL_ADDRESS>wrote:

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to
api/envoy/.
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.
🐱
Caused by: #14143 https://github.com/envoyproxy/envoy/pull/14143 was
opened by alyssawilk.
see: more https://github.com/envoyproxy/envoy/pull/14143, trace
https://prod.repokitteh.app/traces/ui/envoyproxy/envoy/07969190-2d94-11eb-902b-0c021e520f07
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/envoyproxy/envoy/pull/14143#issuecomment-732178722,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AELALPO2K7K7I7PA77GG6O3SRJTDRANCNFSM4T7QWNWQ
.

Or maybe we want this server-side as well, for the moral equivalent of
min_connections_picked and it shouldn't be a one-of?  Thoughts?

Having not thought about this a ton my initial feeling would be to not special case mobile at all and just have the right knobs that allow the user to select between load based and fixed as you mention? I can take a look at the API also if you want.

yeah, I don't think config would be server or client specific, just that one of these (either per-host or per-upstream) needs to be a oneof to handle the fixed prefetching case.
I could just solve the problem by making them both one-of and we can add the relevant one for mobile and leave the other as to-be-implemented-iff-needed?

I could just solve the problem by making them both one-of and we can add the relevant one for mobile and leave the other as to-be-implemented-iff-needed?

I think that sounds reasonable at a high level but I can take a look at the proposed API once @antoniovicente does a pass.

Tagging @antoniovicente for API discussion and code review (which I think is mostly ready to look at) but I don't want this PR landing until we have a solid API plan for mobile and I need some help from the mobile folks on that (cc @mattklein123 @junr03 @goaway)
For server-side prefetch, I think we generally want to have load-adjusted prefetch which is what is implemented. As the rate of queries go up, more connections are prefetched.
For mobile, AFIK for HTTP/1.1 we want to prefetch a fixed (maybe configurable, but fixed) number of connections per logical endpoint. (last I was paying attention was years ago, when I think it was usually either 6 or 8). Basically if you have one request for www.google.com you establish 6 connections on the assumption there will be a bunch of follow-up requests, and you want to head off latency issues. So I think for one of these fields we're going to want to have a one-of between ratio-based and fixed-config.
What I'm not sure of, is what that looks like for mobile today, is which one. I assume we're going to do DNS resolution, get back a few results, but only talk to one IPv4 or IPv6 address (not load balance across DNS results). If so I think we'd want to make the per-host prefetch either ratio-based or fixed, rather than the per-cluster prefetch?

Are you talking about a prefetch limit or limit on the number of active connections to a domain?  Seems like the Chrome limits are something like 6 connections per host name, and 10 connections total per page load.  I don't remember what chrome and others browsers did as regarding prefetching.  That said, should we expect HTTP/1.1 from mobile devices?  Ideally the client would use HTTP2 or QUIC for which a single connection ought to be sufficient due to multiplexing.  Possible exception being websocket connections.

This is a nit, but how married are we to the name "prefetch"? I feel it's somewhat overloaded with h2's (etc.) notion of push and could be confusing. What about something like "prewarm" or "proactive_connect/connections"

hm, I think of prewarm as a different action, where you send data down a connection early to get the cwnd set up correctly.  If anyone else thinks prefetch could get conflated with push I'm up for trying to come up with a better name.

@mattklein123  or @snowp up for second pass?

Sure I can take a look.

Not to delve too far into bikeshedding territory, but "Preconnect"?
I think it's the "fetch" that really bugs me, since no data is actually being transmitted and naively, it would strongly imply to me that it was.

Preconnect SGTM.  Will swap it out Monday :-)

Rename is done and I've otherwise just been keeping this up to date. PTAL!

@alyssawilk thanks for humoring me with the rename. :)

Np - Turns out that's what it's called in Chrome, so it's one more step in
our mobile stack consistency :-)
On Wed, Dec 16, 2020 at 2:41 PM Mike Schore<EMAIL_ADDRESS>wrote:

@alyssawilk https://github.com/alyssawilk thanks for humoring me with
the rename. :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/envoyproxy/envoy/pull/14143#issuecomment-746899234,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AELALPMFVEKMGUVLYGGF6GDSVEEPZANCNFSM4T7QWNWQ
.

ok, utility function added.  This (+comments) make more sense now?

ok, utility function added.  This (+comments) make more sense now?


[ImageResizer] Fix wrong registry key in installer.

Summary of the Pull Request
BMP context handler of ImageResizer is registered in the wrong place, this PR fixes that.

PR Checklist

[ ] Closes: #xxx
[ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

/azp run


Problems using the library

Hi! I've installing the library by using pip, but I'm getting an error when trying to use the example in the readme, I'm trying to run:
from linguaf import descriptive_statistics as ds

documents = [
    "Pain and suffering are always inevitable for a large intelligence and a deep heart. The really great men must, I think, have great sadness on earth.",
    "To go wrong in one's own way is better than to go right in someone else's.",
    "The darker the night, the brighter the stars, The deeper the grief, the closer is God!"
]

print(ds.words_per_sentence(documents))

and I get:
Traceback (most recent call last):
  File "x.py", line 1, in <module>
    from linguaf import descriptive_statistics as ds
  File "C:\Users\javi\anaconda3\lib\site-packages\linguaf\descriptive_statistics.py", line 26, in <module>
    STOPWORDS[language] = __load_json(
  File "C:\Users\javi\anaconda3\lib\site-packages\linguaf\__init__.py", line 10, in __load_json
    data = json.load(f)
  File "C:\Users\javi\anaconda3\lib\json\__init__.py", line 293, in load
    return loads(fp.read(),
  File "C:\Users\javi\anaconda3\lib\encodings\cp1252.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x8f in position 98: character maps to <undefined>

I've tried to install the package from github too and got the same result, can you give me a hand?

I've fixed it by specifying encoding as utf-8 in the function load_json in the init.py file of the library.
def __load_json(filepath):
    data = None
    with open(filepath, encoding="utf8") as f:
        data = json.load(f)
    return data


Do not use sh in istioctl.

Currently istioctl uses something like
kubectl exec <pod> -- sh -c "GODEBUG= pilot-agent request GET <path> ..."

to implement some functionality like istioctl proxy-config and to mute debug output from the go runtime when the environment variable GODEBUG is set.  For distroless images, this doesn't work, because there is no sh.
Therefore, we ignore the output on stderr if the kubectl exec is successful. Otherwise the output is appended to the error.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jkbschmid
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: fisherxu
If they are not already assigned, you can assign the PR to them by writing /assign @fisherxu in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @jkbschmid. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@jkbschmid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
913b4fc9ba3e673948c3eb311cc6e0d6976f60e9
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I signed it!

@jkbschmid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
913b4fc9ba3e673948c3eb311cc6e0d6976f60e9
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jkbschmid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
913b4fc9ba3e673948c3eb311cc6e0d6976f60e9
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
913b4fc9ba3e673948c3eb311cc6e0d6976f60e9
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I signed it!

/lgtm
@esnible do you know if there are any cases where we print useful stderr (and don't fail)?  I suspect not

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn, jkbschmid
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: fisherxu
If they are not already assigned, you can assign the PR to them by writing /assign @fisherxu in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn I couldn't find anywhere in pilot/cmd/... where we write to stderr.  If anything goes to stderr, it is an error message from Cobra which will return a non-zero error status.

@howardjohn do we need anything else to get the CLA approval?

Needed manual approval since the commit was from multiple authors

Hi @ozevren @liamawhite @nmittler @esnible @fisherxu ,
could you please allow the merge?

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, jkbschmid, ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS [ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jkbschmid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
913b4fc9ba3e673948c3eb311cc6e0d6976f60e9
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


<EMAIL_ADDRESS>cannot be found on CDN (unpkg.com)

Environment Information

leafmap version: 0.3.3
Python version: 3.8
Operating System: Linux

Description
Leafmap 0.3.3 uses<EMAIL_ADDRESS>However, the new ipyevent cannot be found on CDN:
Error message from Chrome console:

Response from CDN:

Thanks for reporting. Would downgrading ipyevents to v2.0.0 resolve the issue? If yes, then this is bug that needs to be reported on the ipyevents repo. We can temporarily pin ipyevents v2.0.0 in the requirements.txt

As far as I can see, v1.9.0's cdn works<EMAIL_ADDRESS>However, v2.0.0 does not<EMAIL_ADDRESS>Let me report the issue to ipyevents.

ipyevents v2.0.0 and v2.0.1 were just released a few days ago. From the release history, I can't find v1.9.0. Only see v0.9.0
https://github.com/mwcraig/ipyevents/releases
https://pypi.org/project/ipyevents/#history

v0.9.0 should work. This version points to<EMAIL_ADDRESS>Their version naming is confusing though...

Anyway, an issue is opened on that project: https://github.com/mwcraig/ipyevents/issues/70

I have added ipyevents v0.9.0 to requirements.txt. Will make a new release later this week. We can remove the version restriction once the issue is fixed by ipyevents.
https://github.com/giswqs/leafmap/blob/master/requirements.txt#L6

Leafmap v0.3.4 has been released. The pip version uses ipyevents <= 0.9.0. Note that the conda-forge version does not specify ipyevents version.

Thanks for the change. The author of ipyevents confirmed to support npm for newer versions.


Filter by video length

Just as you can filter videos by video resolution, it would be nice to be able to filter by video length as well.
Both an upper and lower bound would be good! 👍

I'll work on getting this in 👍

Have you started on this? 😄
If not - I wouldn't mind looking at this! 👍

Haven't started yet -- feel free to give it a go.
I may be a bit finicky about the UI - how were you thinking of letting users choose the cutoffs?
ps - there seem to be two features, both we'd like to have eventually:

filter by length using minimum and maximum time cutoffs
sort by length - ascending / descending (separate issue from this) 👍

There's lots of sorting that would be nice! 👍 We should make the issues for them! (Maybe a parent issue, and one for each type)
And I was planning on copying the resolution filter, with 0->max_video_length, and some number of divisions in between... Haven't thought too much about it - have you any ideas? 💡

We can easily detect the shortest and longest video within the hub - set those as cutoffs, and then have the two sliders as I have with the resolution filter.
What made me pause is that I custom coded the resolution filter sliders but not in a flexible-enough way that I could reuse the component. I've not looked into it in more than half a year -- perhaps it would be easy-enough to modify. Do take a look if it can be!
For the UI, I suspect a nice way to do it would be something like this:
above:          15min           45 min
bar:         ======0####0=============
below:     3min                                    1hr 24min

So that the min and max are always shown (below) and the cutoff is auto-updated as you slide the slider just above the div that you drag (minimum aligned left, maximum aligned right - so they never overlap even if close together)
Comments? 😃


Adding e2e-harness-generate update

What type of PR is this?
(maintenance)
What this PR does / why we need it?
This PR is about updating the e2e requirements as well regarding Go 1.22 such that the image build passes. Right now, it's failing as per https://ci.int.devshift.net/job/openshift-ocm-agent-operator-gh-build-master/222/console and this PR is intended to fix it.
Which Jira/Github issue(s) this PR fixes?
Fixes # OSD-25349

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.22%. Comparing base (742e13a) to head (5cba20a).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   64.22%   64.22%
=======================================
  Files          22       22
  Lines        1504     1504
=======================================
  Hits          966      966
  Misses        459      459
  Partials       79       79

/lgtm


Add code or comment for downloading .shp file

I couldn't run the app because the ecoregions shapefile isn't on GitHub.  Either add code or a comment about where to download it and where to put it for better reproducibility.  I think this is it: https://gaftp.epa.gov/EPADataCommons/ORD/Ecoregions/cec_na/na_cec_eco_l1.zip

Hi Eric,
Thank you for bringing this to my attention! I actually have been working
with some IT people to make improvements on the Shiny app which will
hopefully be up and running soon but I will make sure all the code is
updated on github to include the ecoregions. Thanks again for letting me
know!
On Fri, May 19, 2023 at 1:09 PM Eric R. Scott @.***>
wrote:

I couldn't run the app because the ecoregions shapefile isn't on GitHub.
Either add code or a comment about where to download it and where to put it
for better reproducibility. I think this is it:
https://gaftp.epa.gov/EPADataCommons/ORD/Ecoregions/cec_na/na_cec_eco_l1.zip
—
Reply to this email directly, view it on GitHub
https://github.com/erinetracy/AFS_database_code/issues/10, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AS3S4MJUK3UZYG42DW3QVVLXG7HRJANCNFSM6AAAAAAYIGEZ7M
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Erin Tracy

I cleaned up the code for downloading the ecoregions data in this script in the repo, hopefully that is sufficient!

That script works like a charm, but I still can't run the app because Lat_long_AFSshiny_012023.csv is missing I think? (or not where the code expects it to be)

Just now coming back to this. You are right that the app cannot be run from everything in the GitHub repo. That csv has location data for bodies of water, which we don't want to make public. I will add a note about that in the README!

Depending on priorities, it might be cool to include a dummy dataset in its place.  That would be useful if a goal is for other researchers to be able to replicate this shiny app.  If that's not a top priority, then I think a note in the README is fine.


Please support group variables on GitLab

Hi.  Using cosign generate-key-pair gitlab://foo/bar works fine if the destination is a project, but it seems useful to also generate keys and set the variables for a group, so the variables are reachable for all sub-groups.
Compare this successful run:
jas@kaka:~$ cosign generate-key-pair gitlab://debdistutils/canary/trisquel
Enter password for private key:
jas@kaka:~$

With the following failing run:
jas@kaka:~$ cosign generate-key-pair gitlab://debdistutils/canary
Enter password for private key:
Enter password for private key again:
WARNING: If you are using a self-hosted gitlab please set the "GITLAB_HOST" your server name.
Error: could not create "COSIGN_PASSWORD" variable: POST https://gitlab.com/api/v4/projects/debdistutils/canary/variables: 404 {message: 404 Project Not Found}
main.go:74: error during command execution: could not create "COSIGN_PASSWORD" variable: POST https://gitlab.com/api/v4/projects/debdistutils/canary/variables: 404 {message: 404 Project Not Found}
jas@kaka:~$

I would want the second command to populate variables for that sub-group.
Thank you!

@znewman01 is this something I could work on?
Additionally, is this only for gitlab or should this apply to github key pairs as well?

That would be great @rnjudge ! Thanks 🙂

Additionally, is this only for gitlab or should this apply to github key pairs as well?

Good call. I think the analog in GitHub would be organization secrets. That seems useful to me!

+1 on the organization secrets for github, but i think this will be another PR

Hi @rnjudge! May I give this a try if you are not working on this anymore?

Hi :smile: It's been some time since the last comment on this issue, I'll work on this

@robertohueso Thanks for doing this. This is follow-up and FYI.
As of this moment I'm testing out cosign within a gitlab-ci pipeline.
I initially created project level COSIGN variables within GitLab on a self-hosted instance. Worked out great.
As more projects came along for signing container images, I copied those same variables as a test use case to the main group and deleted the project level variables. Within GitLab those main group cosign variables are now inherited to all projects and/or subgroups.
But using 'cosign sign -y --key gitlab://${PROJECTID} "$IMAGE_W_DIGEST"' within the pipeline of project within a subgroup - inherited group variables are visible - cosign returns the following error:
# 324 is the project id. Test done with group id, also same error.
Error: signing [reg.<own-domain>.com/library/dnsmasq@sha256:34b9a5c7321cfcd1d1e1111049ee15916b7bb2d1de7d840aeebc060bcf1796a9]: getting signer: reading key: could not retrieve "COSIGN_PUBLIC_KEY" variable: GET https://git.<own-domain>.com/api/v4/projects/324/variables/COSIGN_PRIVATE_KEY: 404 {message: 404 Variable Not Found}

 # part of pipeline job
   before_script:
    # https://docs.sigstore.dev/cosign/system_config/installation/#alpine-linux
    - apk add --no-cache --update cosign grep jq # cosign slightly outdated but cleaner code
  script:
    - export COSIGN_PASSWORD=${COSIGN_PASSWORD}
    - export GITLAB_TOKEN=${COSIGN_PAT}
    - export GITLAB_HOST=${CI_API_V4_URL}
    #
    # https://github.com/sigstore/cosign/issues/2914 "Please support group variables on GitLab"
    #
    - |
      cosign sign -y --key gitlab://${PROJECTID} "$IMAGE_W_DIGEST" \
        --annotations "com.gitlab.ci.project.name=$CI_PROJECT_NAME" \
        --annotations "tag=$IMAGE_TAG"


Feature/update image upload 40768943

update image uploading modal (Figma 7.3 - 7.5)
https://uistorybook.pastel.network/?path=/story/features-add-nft--add-nft
add commit id to smartcrop.js dep
fix storybook build error (https://github.com/babel/babel/issues/11622)
add Tooltip2 common component because Tooltip already exists but not customizable enough
change optimization slider to use % quality instead of MB because letting user choose size doesn't seem to be implementable

I needed to merge PR of image optimization to avoid further conflicts
Removed extra close button on cropping and in full screen
Changed magnification zoom level significantly because with small zoom level it's impossible to see the difference, so now has around 25 times zoom depending on image size
Before/After now has updated design with white background
Removed custom cursor icon from previous design, now it is a standard cursor.
Please ignore other screens, this PR is for "preview" modal with optimization slider.


fix possible deadlocks between catalog update and FTS

This problem partially fixed in #8012 (https://github.com/greenplum-db/gpdb/pull/8012)
However, these changes do not take into account the lock mode of nested functions
for gp_add_segment_mirror (add_segment_config, add_segment_config_entry,
get_availableDbId). This functions still require AccessExclusiveLock mode.
Catalog changes are proccess in single transaction so this mode will be held until
transaction commit. So we may get deadlock if we will be restore multiple segments
for cluster with large persistent tables, which will require updating the catalog more than 30 * 2
(DISPATCH_WAIT_TIMEOUT_MSEC) seconds.
In general, any update catalog operations requiring dispatch may cause deadlock with FTS.
So fixed gp_add_master_standby too.
gp_add_segment does not dispatch, but is performed in one transaction with the update
of the mode and status of the segment, which require dispatching
6X and master not affected by this problem because not use dispatch for catalog changes (https://github.com/greenplum-db/gpdb/issues/8032#issuecomment-506644559).
PS I lock gp_persistent_relation_node in utlility mode on segment for reproduce problem.

@darthunix , thank you. I changed that.

Internal review. No need more.


Cannot find module 'node:module'

Environment

Operating System: Linux
Node Version:     v14.16.1
Nuxt Version:     3-3.0.0-27242696.dbbce5f
Package Manager:  npm
Bundler:          Webpack
User Config:      -
Runtime Modules:  -
Build Modules:    -

Describe the bug

I have created the new nuxt3 project through CLI with npx nuxi init nuxt3-app
-Tried to start the project after installation of dependencies with npm install
Run npm run dev command and got this error:

` ERROR  Cannot find module 'node:module'                                                                                18:13:57
Require stack:

/codebase/test-nuxt3/node_modules/jiti/dist/jiti.js

/codebase/test-nuxt3/node_modules/jiti/lib/index.js
Require stack:

node_modules/jiti/dist/jiti.js
node_modules/jiti/lib/index.js
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
at Function.Module._load (internal/modules/cjs/loader.js:725:27)
at Module.require (internal/modules/cjs/loader.js:952:19)
at require (internal/modules/cjs/helpers.js:88:18)
at node_modules/jiti/dist/jiti.js:1:51704
at node_modules/jiti/dist/jiti.js:1:55809
at Object. (node_modules/jiti/dist/jiti.js:1:55838)
at Module._compile (internal/modules/cjs/loader.js:1063:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
at Module.load (internal/modules/cjs/loader.js:928:32)
`

Reproduction

npx nuxi init nuxt3-app
npm install
npm run dev

Additional context
No response
Logs
No response

I just manually installed the package npm i jiti. Worked for me.


278 add tutorial for use with openmp

Closes #278
Docs can be viewed here: https://ncar.github.io/micm/branch/278-add-tutorial-for-use-with-openmp/user_guide/openmp.html

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (1a1533b) 97.34% compared to head (4b7f93a) 97.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #280   +/-   ##
=======================================
  Coverage   97.34%   97.34%
=======================================
  Files          32       32
  Lines        2639     2639
=======================================
  Hits         2569     2569
  Misses         70       70

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


clashleaders.clash.api.TooManyRequests in GET /clan/9URJYCP2/short.json

Error in ClashLeaders
clashleaders.clash.api.TooManyRequests in GET /clan/9URJYCP2/short.json
Too many requests when fetching clan [#9URJYCP2].
View on Bugsnag
Stacktrace
clashleaders/clash/api.py:67 - find_clan_by_tag
clashleaders/model/clan.py:61 - fetch_and_save
clashleaders/views/clan.py:105 - clan_meta

View full stacktrace
Created automatically via Bugsnag

An error linked to this issue has been marked as fixed in Bugsnag
clashleaders.clash.api.TooManyRequests in GET /clan/9URJYCP2/short.json


javascript error on new VIE() in old firefox

when instantiating VIE 2.0 with

in firefox 3.6.22 (linux) i get the following error message for line 168

the code in that area is
165 if (!id) return undefined;
166 if (typeof id === 'string') {
167 var lid = this.vie.namespaces.isUri(id) ? id : this.vie.namespaces.uri(id);
168 return this._types[lid];

/cc @rryter

We've done some linting on the code. Can you verify the issue is still here?

it looks like this was triggered by some other error. in the cmf-sandbox where i observed the problem, it is now gone. sorry for the noise.


Fix typo in coding-style-guide.md

fixed typo in coding-style-guide.md, where string slice is declared using []string{} rather than []string

@fbarotov do you mind fixing DCO? (: You need to sign off you commit: https://github.com/thanos-io/thanos/pull/2939/checks?check_run_id=909457921

@fbarotov do you mind fixing DCO? (: You need to sign off you commit: https://github.com/thanos-io/thanos/pull/2939/checks?check_run_id=909457921

thanks a lot :) done.


fix: conform search provider to warp2 schema

Ticket
LS-1213
Changes
conform search provider + testing to warp2 schema
Testing

git checkout LS-1213--warp2-search-provider
cd packages/vue
npm run test -- searchProvider.spec.js

This looks good! How do we feel about merging this into main vs another warp2 dedicated branch. I could see some value in separation here

Good point let's do that instead!


TransportException: Unexpected response; status: 500 from dependency-check-maven 8.0.0

Describe the bug
I have 3 separate maven projects that should have same settings and plugins in the pom.xml file. All the projects build and deploy fine. When I try the dependency-check:aggregate target, 2 of the projects work as expected. The third projects fails in the dependency-check processing.
Version of dependency-check used
I am using the 8.0.0 version of the maven plugin.
Log file
There are 8 stack traces similar to this:
[DEBUG] POST https://ossindex.sonatype.org/api/v3/component-report; payload: {"coordinates":["pkg:maven/org.hibernate.validator/hibernate-validator-annotation-processor@6.2.5.Final","pkg:maven/org.apache.httpcomponents/httpclient@4.5","pkg:maven/org.opensaml/opensaml-profile-api@3.4.6","pkg:maven/org.jboss.javaee/jboss-transaction-api@1.0.1.GA","pkg:maven/org.springframework.ldap/spring-ldap-core@2.4.1","pkg:maven/com.squareup.okhttp/okhttp@2.7.5","pkg:maven/pentaho-kettle/kettle-core@<IP_ADDRESS>-290","pkg:maven/org.pentaho/metastore@<IP_ADDRESS>-290","pkg:maven/org.glassfish.jaxb/jaxb-core@3.0.2","pkg:maven/com.sapiens.coresuite.zk/midnightblue-theme-zk9@8.2.6","pkg:maven/com.google.protobuf/protobuf-java@3.19.4","pkg:maven/com.fasterxml.jackson.module/jackson-module-jaxb-annotations@2.13.4","pkg:maven/org.apache.hadoop/hadoop-hdfs-client@3.3.1","pkg:maven/jgroups/jgroups@2.6.13.GA","pkg:maven/com.lowagie/itext@2.1.7.js10","pkg:maven/org.springframework.boot/spring-boot-devtools@2.7.5","pkg:maven/org.jboss.cache/jbosscache-core@%24%7Bjbosscache-core-version%7D","pkg:maven/org.opensaml/opensaml-saml-impl@3.4.6","pkg:maven/org.opensaml/opensaml-security-impl@3.4.6","pkg:maven/com.sapiens.coresuite.zk/mysteriousgreen-theme-zk9@8.2.6","pkg:maven/org.apache.xmlbeans/xmlbeans@3.1.0","pkg:maven/org.opensaml/opensaml-xmlsec-impl@3.4.6","pkg:maven/io.dropwizard.metrics/metrics-core@4.2.12","pkg:maven/org.apache.httpcomponents/httpmime@4.5.13","pkg:maven/com.googlecode.jmockit/jmockit@1.3","pkg:maven/org.opensaml/opensaml-xacml-api@3.4.6","pkg:maven/org.jboss/jboss-common-core@2.2.14.GA","pkg:maven/org.springframework.security/spring-security-ldap@5.7.4","pkg:maven/junit/junit@4.12","pkg:maven/org.opensaml/opensaml-core@3.4.6","pkg:maven/com.squareup.okio/okio@1.6.0","pkg:maven/org.springframework/spring-oxm@5.3.23","pkg:maven/org.opensaml/opensaml-xacml-saml-impl@3.4.6","pkg:maven/org.opensaml/opensaml-xacml-impl@3.4.6","pkg:maven/com.fasterxml.woodstox/woodstox-core@5.2.1","pkg:maven/org.opensaml/opensaml-security-api@3.4.6","pkg:maven/org.opensaml/opensaml-saml-api@3.4.6","pkg:maven/org.jboss.logging/jboss-logging-spi@2.0.5.GA","pkg:maven/org.jboss.cache/jbosscache-core@3.2.7.GA","pkg:maven/org.apache.httpcomponents/httpmime@4.5.3","pkg:maven/org.mozilla/javascript@1.7.5","pkg:maven/com.sun.istack/istack-commons-runtime@4.0.1","pkg:maven/net.shibboleth.utilities/java-support@7.5.2","pkg:maven/javax.ws.rs/javax.ws.rs-api@2.1.1","pkg:maven/org.eclipse.swt/org.eclipse.swt@4.3","pkg:maven/org.pentaho/kettle-ui-swt@<IP_ADDRESS>-290","pkg:maven/pentaho-kettle/kettle-engine@<IP_ADDRESS>-290","pkg:maven/org.apache.santuario/xmlsec@2.2.2","pkg:maven/com.fasterxml.jackson.dataformat/jackson-dataformat-xml@2.12.4","pkg:maven/com.sapiens.coresuite.zk/sapiens-theme-zk9@8.2.6","pkg:maven/org.eclipse.jface/org.eclipse.jface@3.22.0","pkg:maven/joda-time/joda-time@2.10.10","pkg:maven/org.jasypt/jasypt@1.9.3","pkg:maven/pentaho-kettle/kettle-dbdialog@<IP_ADDRESS>-290","pkg:maven/org.codehaus.woodstox/stax2-api@4.2","pkg:maven/org.opensaml/opensaml-xacml-saml-api@3.4.6","pkg:maven/org.hdpagination/hdpagination@1.1","pkg:maven/pentaho/metastore@<IP_ADDRESS>-290","pkg:maven/com.fasterxml.woodstox/woodstox-core@6.2.4","pkg:maven/org.opensaml/opensaml-xmlsec-api@3.4.6","pkg:maven/pentaho-kettle/kettle-ui-swt@<IP_ADDRESS>-290","pkg:maven/javax.validation/validation-api@2.0.1.Final","pkg:maven/org.apache.wss4j/wss4j-ws-security-common@2.3.2","pkg:maven/com.google.guava/guava@30.1-jre","pkg:maven/com.squareup.okio/okio@2.8.0","pkg:maven/com.sapiens.coresuite.zk/webtier-framework@8.2.6","pkg:maven/com.squareup.okhttp3/okhttp@4.9.3","pkg:maven/org.opensaml/opensaml-soap-api<EMAIL_ADDRESS>(application/vnd.ossindex.component-report-request.v1+json); accept: application/vnd.ossindex.component-report.v1+json
[DEBUG] Connecting to: https://ossindex.sonatype.org/api/v3/component-report
[DEBUG] Error requesting component reports, disabling the analyzer
org.sonatype.ossindex.service.client.transport.Transport$TransportException: Unexpected response; status: 500
at org.sonatype.ossindex.service.client.transport.HttpUrlConnectionTransport.post (HttpUrlConnectionTransport.java:106)
at org.sonatype.ossindex.service.client.internal.OssindexClientImpl.doRequestComponentReports (OssindexClientImpl.java:204)
at org.sonatype.ossindex.service.client.internal.OssindexClientImpl.requestComponentReports (OssindexClientImpl.java:170)
at org.owasp.dependencycheck.analyzer.OssIndexAnalyzer.requestReports (OssIndexAnalyzer.java:219)
at org.owasp.dependencycheck.analyzer.OssIndexAnalyzer.analyzeDependency (OssIndexAnalyzer.java:134)
at org.owasp.dependencycheck.analyzer.AbstractAnalyzer.analyze (AbstractAnalyzer.java:131)
at org.owasp.dependencycheck.AnalysisTask.call (AnalysisTask.java:88)
at org.owasp.dependencycheck.AnalysisTask.call (AnalysisTask.java:37)
at java.util.concurrent.FutureTask.run (FutureTask.java:264)
at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1136)
at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:635)
at java.lang.Thread.run (Thread.java:833)
[WARNING] An error occurred while analyzing 'C:\Users\Michael.Rother.m2\repository\org\glassfish\jaxb\jaxb-runtime\2.3.7\jaxb-runtime-2.3.7.jar' (Sonatype OSS Index Analyzer).
[DEBUG]
org.owasp.dependencycheck.analyzer.exception.AnalysisException: Failed to request component-reports
at org.owasp.dependencycheck.analyzer.OssIndexAnalyzer.analyzeDependency (OssIndexAnalyzer.java:155)
at org.owasp.dependencycheck.analyzer.AbstractAnalyzer.analyze (AbstractAnalyzer.java:131)
at org.owasp.dependencycheck.AnalysisTask.call (AnalysisTask.java:88)
at org.owasp.dependencycheck.AnalysisTask.call (AnalysisTask.java:37)
at java.util.concurrent.FutureTask.run (FutureTask.java:264)
at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1136)
at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:635)
at java.lang.Thread.run (Thread.java:833)
Caused by: org.sonatype.ossindex.service.client.transport.Transport$TransportException: Unexpected response; status: 500
at org.sonatype.ossindex.service.client.transport.HttpUrlConnectionTransport.post (HttpUrlConnectionTransport.java:106)
at org.sonatype.ossindex.service.client.internal.OssindexClientImpl.doRequestComponentReports (OssindexClientImpl.java:204)
at org.sonatype.ossindex.service.client.internal.OssindexClientImpl.requestComponentReports (OssindexClientImpl.java:170)
at org.owasp.dependencycheck.analyzer.OssIndexAnalyzer.requestReports (OssIndexAnalyzer.java:219)
at org.owasp.dependencycheck.analyzer.OssIndexAnalyzer.analyzeDependency (OssIndexAnalyzer.java:134)
at org.owasp.dependencycheck.analyzer.AbstractAnalyzer.analyze (AbstractAnalyzer.java:131)
at org.owasp.dependencycheck.AnalysisTask.call (AnalysisTask.java:88)
at org.owasp.dependencycheck.AnalysisTask.call (AnalysisTask.java:37)
at java.util.concurrent.FutureTask.run (FutureTask.java:264)
at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1136)
at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:635)
at java.lang.Thread.run (Thread.java:833)
Expected behavior
To process the project and generate the report.
Additional context

Try to reduce your scan to the failing artifact and report an issue at Sonatype OSSIndex. your issue is similar to #5154 and #5216

Prime suspect to look at would be<EMAIL_ADDRESS>as #5154 is about a slightly later version of the same JGroups library, so they likely run into the same internal issue of OSSIndex

Best approach for nailing down which dependency is hurting you would be bi-secting from the logged payload using tools like Postman to directly call the OSSIndex API (HTTP POST to https://ossindex.sonatype.org/api/v3/component-report)
with first/second half of the packageURLs from the logged payload as the data.
Either first or second half of the logged payload will run into HTTP 500 (worst case: both would.... and you would have more than one dependency for which OSSIndex triggers some internal error trying to construct the report on known vulnerabilities on their side)
The failing half you continue to split into two halfs and test them until you find the culprit library and then reach out to Sonatype to inform them that the given artifact coordinates trigger an internal server error.

For the failing package you'll be able to trigger the same error on their search web interface (https://ossindex.sonatype.org/search) pasting the packageURL in the search-field and keeping the dropdown to the default 'all ecosystems'
If you don't have access to tools to fire API requests directly you could use that same form to try the package-urls from the payload one by one (would likely take you more time to find the problematic library compared to the bi-secting)

Note that as a workaround until Sonatype OSSIndex has fixed the issue you can configure your maven builds to only warn you about the error with the new ossIndexWarnOnlyOnRemoteErrors configuration option introduced in v8.0.0 (#5300 , with a chance on false negatives for vulnerabilities that are only registered within OSSIndex)

Thanks for the help.


LEDBoard should have an active_high option

So that it can be used with both common-cathode and common-anode configurations of groups of LEDs.

In fact I guess this should be added in LEDCollection.

Hmm, the way you've done it there is to assign the identical initial_value to every LED in the LEDBoard. The way I was imagining it working, was to have the (optional) iniital_value be a tuple, with an exception thrown if it's a different size to the pins tuple, and then using the initial_value tuple-values to initialise the individual LEDClass initial-values (maybe by using something like enumerate or zip).

You could do, but that's a complex init for an odd case, I'd say. Probably easier just to set them up after init. What do you think, @waveform80?

https://github.com/RPi-Distro/python-gpiozero/pull/176#issuecomment-181906439


Updating from pre release to release via updater not possible

If you have a pre release installed (e.g. latest 2.2.2 pre-release) and the release version is published (e.g. 2.2.2 release), the in-app-updater can't update to that because the installed version (pre-release) has the same version number as the new version.
This is not a big problem because you can just download and run the installer which doesn't even take a minute, but it's still an issue.

It's not a problem at all. Because you cannot create 2 releases with
same version number.
Pre-release is just flag on release, it doesn't play any role in
versioning and you cannot even make 2 same tags in git.

The problem is when you change it to release from pre-release and people
have already installed it
On Oct 14, 2015 9:10 PM, "l0g0sys"<EMAIL_ADDRESS>wrote:

It's not a problem at all. Because you cannot create 2 releases with
same version number.
Pre-release is just flag on release, it doesn't play any role in
versioning and you cannot even make 2 same tags in git.
—
Reply to this email directly or view it on GitHub
https://github.com/EmmittJ/PoESkillTree/issues/212#issuecomment-148276032
.

If they have it already installed than there is no problem. There is no
point doing update when nothing changes just flag was changed.

Except new features can be added to a pre-release basically a current
working build of the source
On Oct 14, 2015 9:15 PM, "l0g0sys"<EMAIL_ADDRESS>wrote:

If they have it already installed than there is no problem. There is no
point doing update when nothing changes just flag was changed.
—
Reply to this email directly or view it on GitHub
https://github.com/EmmittJ/PoESkillTree/issues/212#issuecomment-148276458
.

See? If you add new features, you cannot make it same version. You have
to increase version number.

There is even check in release script, which won't allow you to make 2
releases with same version number/git tag.

This is my bad. I should have incremented the version number instead of keeping it the same pre-release

Yeah, you should be always able to track any release (regardless it
being pre or regular) using git tag as unique identifier. Pre-release is
just flag in githug release entity. I'm affraid that i cannot make it
part of version comparison on any level (assembly version, app version).


Out of memory

Hi,
I have compiled dlib on a AWS GPU instance (4G).
When running dnn_mmod_ex faces i get the following error:
num training images: 4
num testing images:  5
detection window width,height:      40,40
overlap NMS IOU thresh:             0.0781701
overlap NMS percent covered thresh: 0.257122
step#: 0     learning rate: 0.1   average loss: 0           steps without apparent progress: 0
Error while calling cudaMalloc(&data, new_size*sizeof(float)) in file /home/ubuntu/dlib/dlib/dnn/gpu_data.cpp:191. code: 2, reason: out of memory

Any idea what i'm doing wrong ?

dnn_mmod_ex requires 5.3 GB GPU RAM. You can try to simplify NN structure or use smaller batch size
https://github.com/davisking/dlib/blob/master/examples/dnn_mmod_ex.cpp#L161
change 150 into some smaller value

that worked, thks.
Do you know how much accuracy i should get using dnn instead of the hog detector, and how much more data I need to train the network with (hog is pretty accurate with very little data) i.e hundred of pictures, thousands, ten thousands ?

I didn't tested it much and I dont have right numbers. You can get some info here
Because it is DNN-based - the more images you will give to it, the better will be results. If the results will be bad - change NN structure. Even multiclass detector is now possible. But the price is performance

thanks @e-fominov i can't wait to try it !!!!

I haven't made the loss_mmod multi-class yet.  It's a minor change though
and will be in dlib in the near future though :)
I'm still refining that mmod dnn example. One change that's almost
certainly better is to change the random cropper to crop out more
background data per mini-batch.  You can do that by adding
cropper.set_background_crops_fraction(0.5); to the code.  There are a few
other more minor things that I'll add in the next few days once I've tested
them more.

i trained a custom detector, everything went fine (4000 steps, 098 0.70 0.70) untill the code in dnn_mmod_ex start the detection on the test images.
i get:
num training images: 14
num testing images: 2
Error while calling cudaMalloc(&data, new_size*sizeof(float)) in file /home/ubuntu/dlib/dlib/dnn/gpu_data.cpp:191. code: 2, reason: out of memory

You ran out of memory.  Not sure what to do about it.  If you ran out at
the final for loop then you must not have very much RAM in your graphics
card.

i have 8G.... also the following script that just read the net from disk and detect fails with the same out of memory error:
#include <iostream>
#include <dlib/dnn.h>
#include <dlib/data_io.h>
#include <dlib/gui_widgets.h>

using namespace std;
using namespace dlib;

template <long num_filters, typename SUBNET> using con5d = con<num_filters,5,5,2,2,SUBNET>;
// A 3x3 conv layer that doesn't do any downsampling
template <long num_filters, typename SUBNET> using con3  = con<num_filters,3,3,1,1,SUBNET>;

// Now we can define the 8x downsampling block in terms of conv5d blocks.  We
// also use relu and batch normalization in the standard way.
template <unsigned long N, typename SUBNET> using downsampler  = relu<bn_con<con5d<N, relu<bn_con<con5d<N, relu<bn_con<con5d<N,SUBNET>>>>>>>>>;

// The rest of the network will be 3x3 conv layers with batch normalization and
// relu.  So we define the 3x3 block we will use here.
template <unsigned long N, typename SUBNET> using rcon3  = relu<bn_con<con3<N,SUBNET>>>;

using net_type  = loss_mmod<con<1,6,6,1,1,rcon3<32,rcon3<32,rcon3<32,downsampler<32,input_rgb_image_pyramid<pyramid_down<6>>>>>>>>;

// ----------------------------------------------------------------------------------------

int main(int argc, char** argv) try
{

    if (argc != 2)
    {
        cout << "Give the path to the examples/faces directory as the argument to this" << endl;
        cout << "program.  For example, if you are in the examples folder then execute " << endl;
        cout << "this program by running: " << endl;
        cout << "   ./dnn_mmod_ex faces" << endl;
        cout << endl;
        return 0;
    }
    const std::string faces_directory = argv[1];
    std::vector<matrix<rgb_pixel>> images_train, images_test;
    std::vector<std::vector<mmod_rect>> face_boxes_train, face_boxes_test;

    load_image_dataset(images_test, face_boxes_test, faces_directory+"/testing.xml");

    cout << "num testing images:  " << images_test.size() << endl;

    net_type net;

    deserialize("mmod_network.dat") >> net;
    // Now lets run the detector on the testing images and look at the outputs.
    image_window win;
    for (auto&& img : images_test)
    {
        pyramid_up(img);
        auto dets = net(img);
        win.clear_overlay();
        win.set_image(img);
        for (auto&& d : dets)
            win.add_overlay(d);
        cin.get();
    }
    return 0;

}
catch(std::exception& e)
{
    cout << e.what() << endl;
}

Beats me.  8GB is plenty to run that code.  Maybe something else is using
your GPU.

it s a fresh GPU instance on aws...

Did you look at nvidia-smi to see what is happening on the card?

+------------------------------------------------------+
| NVIDIA-SMI 352.63     Driver Version: 352.63         |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|===============================+======================+======================|
|   0  GRID K520           Off  | 0000:00:03.0     Off |                  N/A |
| N/A   35C    P0    36W / 125W |     11MiB /  4095MiB |      0%      Default |
+-------------------------------+----------------------+----------------------+

+-----------------------------------------------------------------------------+
| Processes:                                                       GPU Memory |
|  GPU       PID  Type  Process name                               Usage      |
|=============================================================================|
|  No running processes found                                                 |
+-----------------------------------------------------------------------------+

and when i run the detection i see this just before it crashes:
+------------------------------------------------------+
| NVIDIA-SMI 352.63     Driver Version: 352.63         |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|===============================+======================+======================|
|   0  GRID K520           Off  | 0000:00:03.0     Off |                  N/A |
| N/A   40C    P0   100W / 125W |   4017MiB /  4095MiB |     99%      Default |
+-------------------------------+----------------------+----------------------+

can it come from my test images that are 1400x1920 pixels ?

Yes. Obviously. I thought you were running the example in dlib as is.

is there a way to run detection on a large image ? or just run the detection on the CPU ?

Either cut the image into pieces or compile the code without CUDA enabled.


FIX: Don't reuse assign note when reassigning

https://user-images.githubusercontent.com/1555215/174345166-b92c3f4a-13c7-4fd0-a3b7-7f0b05af2cef.mov

Stupid question: does the unit test test that the note isn't used when reassigning?

OMG!!
You totally caught the other part that the note was still there!
https://github.com/discourse/discourse-assign/blob/169f13e2396db5306558d5a405e38529ab257a94/assets/javascripts/discourse/services/task-actions.js#L53


chat: endless on peek when looking @ a threaded response

When attempting to view a threaded response in UC, I am getting an endless stream of watch and peak alternation between groups and chat. Unclear if this is intended behavior.

@rabsef-bicrym Thank you, we're confirming our fix for this. We're thinking it'll be an inline thread you run as a two-liner in dojo, but this should quiet things down.

It is not related to typing [%this ~] in the chatinput

No yah - sorry - just noticed it while doing the other action as well.

@jamesacklin this is something different, I'm working on fixing part of this


RealmSwift: Crash when calling className()

Hello,
I am finally pushing my realm-power app to the AppStore. My only complaint is slow open speed, it's  already documented in another issue, but the rest of the features rock. #2510
So, about the issue. I've pushed the app to testers, and noticed a really weird crash when trying to call className(). It only happens in some cases, but not all cases .. I haven't thoroughly debugged it, because I've noticed that RealmSwift now uses className as a property. Switching to a property fixed the issue.
The only issue now is, why am I even able to perform realmObject.className()? Do you provide the function call for backward compatibility? Do you have insights about this issue, or if I can provide more info about it?
Finally, the backtrace is suggesting that I am trying to perform a call on a String?:
* thread #1: tid = 0x4a653, 0x00000001007eaea0 MyFramework`static ext.MyFramework.MyFramework.SettingsTable<A where A: RealmSwift.Object, A: MyFramework.SettingsTable>.NotificationKey.getter : Swift.String(self=0x000025a144e7fda5) + 124 at SettingsTable.swift:23, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x25a144e7fda5)
  * frame #0: 0x00000001007eaea0 MyFramework`static ext.MyFramework.MyFramework.SettingsTable<A where A: RealmSwift.Object, A: MyFramework.SettingsTable>.NotificationKey.getter : Swift.String(self=0x000025a144e7fda5) + 124 at SettingsTable.swift:23

Relevant code:
public extension SettingsTable where Self: Object {

    static var NotificationKey: String {
        return "\(className()).On.Update"
    }

    ...
}

Thanks,

:flushed: can't believe I fell into this .. it's just printing the selector... Let me dig deeper.

Sorry about the previous confusion. Static className() function and className member  variable. Got it. So, that means the issue is still unresolved. className() call crashes in some cases, and I've narrowed it down.

Doesn't crash on simulator and iPhone 5.
Crashes on two iPhone 6s devices I've tried.
Everyone loves a sample project. Here you go.

Help?
(Couldn't understand the performance magic that was happening in the +[RLMObjectBase className] method :grin: )

Hey, sorry about the troubles on this one. I'm not immediately sure why this is happening, we do run device tests on a 64bit iOS 8 device on a continuous basis and it's never caught this. I'll dig into it.

Thanks @jpsim! Honestly, I am more concerned about other Realm users running into this than my specific use case. I've already worked around it.

I was testing that out and investigating to see what is happening here.
The problem seemed to became finally more obvious when I was reverse-engineering the generated framework binary with Hopper. It turns out that the static var defined in a protocol extension is implemented statically and isn't made available to the Objective-C runtime. This can confirmed by trying to execute Subclass.performSelector("NotificationKey"), which also fails on the simulator. But this doesn't seem to stop Swift from making it possible to use it even with NSObject descendants. This was for me surprising because I found out as well that static computed properties are available to the Objective-C runtime as well (by an alias calling the static variant) when they are directly defined in the class.
At least for me, it isn't crashing exactly on calling className(), but rather on trying to access self in the computed property NotificationKey. Same happens when trying to access the dynamicType in proxy in any other way. From my understanding, this seems to be rather a problem with the Swift compiler or runtime.
So what you definitively could do for now is to change your implementation to something like seen below:
public extension SettingsTable where Self: Object {
    …
    public var proxy: String {
        return "\(self.objectSchema.className).On.Update"
    }
}

Thanks for bringing this to our attention.
This definitively needs further investigation / follow-up.

I've looked further into this and determined that it's actually a Swift bug, so I filed a radar (rdar://24173309) as well as a ticket on Swift's bug tracker (SR-537).
Here's a minimal repro case without referencing Realm at all:
import Foundation
// doesn't crash when subclassing a non-Objective-C class, or not subclassing
class Class1: NSObject, Protocol1 {}

protocol Protocol1 {}
// doesn't crash without the type constraint, or with a different constraint ('Self: Hashable')
extension Protocol1 where Self: Class1 {
    func printType() {
        print(self.dynamicType)
        // also crashes:
        // _ = String(self.dynamicType)
        // self.dynamicType.description()
    }
}

Class1().printType() // EXC_BAD_ACCESS

So I'm closing this ticket because the issue is unrelated to Realm.


Move Notice string from PDF2 to base plug-in

Description
Move Notice string from PDF2 to base strings file.
Motivation and Context
Fixes #3888
How Has This Been Tested?
Existing tests.
Type of Changes

New feature (non-breaking change which adds functionality)

Documentation and Compatibility
None needed

Will rebase on hotfix/3.7.1

The ANSI Z535.4 localizations from #3889 should be a separate feature PR. This refactor PR just moves variables to the correct files.


[request]  add ->comment($comment) to the Schema builder

I would like to be able to store comments in my database columns and tables as i create them, would it be possible to add this into the Schema builder eg:
public function up() {
   Schema::create('table', function($t){
      $t->increments('id')->comment('The auto generated primary key'),
      $t->string('name')->unique()->comment('The unique name of your thing'),
   })->comment('The table for f00');
}

+1 please, let's revive this, it'd be super useful, even as a breadcrumb for other devs in the code

Commenting here isn't going to make it happen. Actually sending a pull request would. Sorry to be so blunt. Rob and Jonathan have a point.


fixed kernel version

the kernel you now get is much newer

Fixed as part of https://github.com/boot2docker/boot2docker/pull/1332. :+1:


Native 'setMashapeKey' method for X-Mashape-Key header

wait for da test

Should
Unirest\Request::defaultHeaders(array(
    "Header1" => "Value1",
    "Header2" => "Value2"
));

not override the X-Mashape-Key?

@thibaultCha nah, we have clearDefaultHeaders for that.


concepts-docenhancement-1620309

Added section - Generate deep links to file in the channel.

Docs Build status updates of commit 63cbc9b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/build-and-test/deep-links.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 6f3eab8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/build-and-test/deep-links.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit bfff6a2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/build-and-test/deep-links.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 2e4878f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/build-and-test/deep-links.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit c753b0c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/build-and-test/deep-links.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 0ae9d98:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/build-and-test/deep-links.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit b3bb0b4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/build-and-test/deep-links.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 1884bc7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/build-and-test/deep-links.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


The Error's backtrace ought to be an Option

Allowing to check:
if err.backtrace().is_some() {
    ...
}

To decide about printing the backtrace or not, is more idiomatic no? for now, I need to check if RUST_BACKTRACE is set.

What's wrong with printing it unconditionally? It's not an option because in Fail, the optionality is connected to whether this error type has a backtrace, not whether or not RUST_BACKTRACE is set. I just figured you'd always print it and it'd print nothing if backtraces are turned off.

In my case, I print errors — and backtraces — with log macros, which add timestamps and such to the print. If backtraces are disabled I get a line like ERROR 2018-02-12T22:07:45Z: main_app  with no backtrace info attached to it.

That's annoying.
Currently there's a private is_none method on Backtrace. Maybe we could expose that (probably under a different name).

I'd use is_empty so it is idiomatic.


Get the account address from stored credentials instead of the route params

Description
Get the account address from the stored credentials instead of the route params
Related Issues

https://github.com/threefoldtech/tfgrid-sdk-ts/issues/562
https://github.com/threefoldtech/tfgrid-sdk-ts/issues/459

Screenshots/Video

Screencast from 14-06-23 12:05:39.webm

Checklist

[ ] Tests included
[ ] Build pass
[ ] Documentation
[ ] Code format and docstrings
[ ] Screenshots/Video attached (needed for UI changes)

dashboard build workflow is failing

dashboard build workflow is failing

Interestingly, it passed on my local system! :)


activesitesonly parameter does not work

Hi,
Whether I use this parameter in the playground or via CURL or via this package, I still get results with an empty "sitedetails" array. What gives?

Hi there,
The sitedetails array may be empty either because:

You haven't used the "activeproductsonly" query, as a result of which the product in question has no active sites to show.
You're on the free/starter plan, as a result of which your access to data is limited.


Support other url schemes for md links

I tried this plugin on my mdlinks to zotero:// and it just ignore them . But it works on web links. Can you please add other URL schemes like Zotero to be opened too?

Thank you for your FR, @Archie-2021 :)
I'll implement it 👍

@Archie-2021
Released in v0.3.0 🚀

Thank you very much.


Don't run tests when pushing to release

UI Version: 0.9.3
Description:

Pushing to release runs a job on CircleCI that creates a pull request release candidate.  The tests are run twice (once on release and a second time on the pull request).  Let's skip the tests on release.

i think we're abusing the discuss label - which in my mind is a label for things we are going to discuss in our zoom calls.


[REQUEST] MiCS vs Zero++ hpZ for Hybrid FSDP

Is your feature request related to a problem? Please describe.
I'm interested in hybrid FSDP where the model is replicated across nodes and sharded within node.
My understanding is that this can be achieved through MiCS and / or ZeRO++ hpZ.
Describe the solution you'd like
Better documentation, examples, or tutorials on how these solutions differ and how to best compose these features with Zero3 for a given network topology.

@jeromeku, you can start here: https://www.deepspeed.ai/tutorials/zeropp/

@tjruwase
Is it possible partition parameters using the secondary partition for both forward and backwards?  That is, only shard intra-node for both forwards and backwards instead of only for backwards?
Can this be accomplished given hpZ, and if so, what would be the appropriate config?
Thanks!

Can this be accomplished given hpZ, and if so, what would be the appropriate config?

No, this is not possible in hpZ.

@tjruwase
Are there any benchmarks comparing ZeRO++ hpZ with MiCS?  Are there specific use cases for one over the other given the different partitioning schemes employed by hpZ vs MiCS?

@jeromeku, please see the attached performance comparison of hpZ versus MiCS. Generally, hpZ is more memory efficient because, unlike MiCS, it does not replicate the entire model state. However, MiCS might be competitive in scenarios where memory is not a bottleneck.


Portal names sorting

Could you please implement configurable portal names sorting in the drop-down list?
I could think of three useful variants: Alphabetic, Distance, Last Visited. I, personally, need only alphabetic one - to check portals one by one trying to find my missing boat :)

1.0.4 now has alphabetic sorting. Between the three I think that's the most useful because the order should stay consistent as you play.
I could add configurable sorting, but... I dunno. I don't feel like that's super useful. I just added another button in 1.0.4 and now the configuration UI is starting to look a little busy. I think I'll leave it alone for now, but if more people ask about this I'll take a stab at it.


Not connecting phantom wallet on mobile devices

Describe the bug
When I hit the connect button on an ios device it should open the native phantom wallet app with deep link and connect.
https://docs.phantom.app/integrating/deeplinks/provider-methods/connect

Duplicate of https://github.com/solana-labs/wallet-adapter/issues/385. Phantom deep links are not currently supported.

Talk to Solana Support on the Live support page so that your issue can be looked into.

^ Pay no attention to the scammer.

Duplicate of #385. Phantom deep links are not currently supported.

It appears that it should be though according to this. I can't figure out how to though.

@mcpat1993 Phantom's deep link functionality is only supported by Phantom. But not by this project, which serves to standardize behaviors across wallets. This will get standardized and implemented! But this issue is a duplicate of #385, so please subscribe to that to track this.


mwc-tab applies wrong styles to slotted elements

Hi,
when mwc-tab is used like this:
<mwc-tab-bar>
  <mwc-tab label="one"></mwc-tab>
  <mwc-tab label="two"></mwc-tab>
  <mwc-tab label="three"></mwc-tab>
</mwc-tab-bar>

Everything is working as intended, I can apply color via css var --mdc-theme-primary: red;, and it  gets propagated correctly.
However if I use tabs like this:
<mwc-tab-bar>
  <mwc-tab>One</mwc-tab>
  <mwc-tab>Two</mwc-tab>
  <mwc-tab>Three</mwc-tab>
</mwc-tab-bar>

The text will not become red.

Unfortunately using the slot in this use case is not what the slot was intended for.
The slot was intended for being used as a method to insert an image icon via an <img> or <svg> etc. (as a matter of fact, this use case does not work, so we will have to make a fix for this).

related #628


Cannot set mipmaps/filter defaults on texture imports from gltf files

Godot version
3.3 stable
System information
Windows 7 64-bit
Issue description
I've set the texture imports in both Project Settings and the node import tab, but textures still come in with filter and mipmaps on:

A gltf file exported from blender always imports like this:

This happens with both built-in materials and unpacked files:

Steps to reproduce
Export a gltf in blender, watch as Godot does not import with the texture defaults it's been given.
Minimal reproduction project
No response

Duplicate of https://github.com/godotengine/godot/issues/45206.

Duplicate of #45206.

The other issue doesn't mention mipmaps?

The other issue doesn't mention mipmaps?

It's still the same underlying cause :slightly_smiling_face:

The other issue doesn't mention mipmaps?

It's still the same underlying cause 🙂 I edited the other issue's title accordingly.

Just for reference of anyone coming across this, is the present solution to use a) built-in materials or separate files and b) to manually change the mipmap and filter settings on each material?

Just for reference of anyone coming across this, is the present solution to use a) built-in materials or separate files and b) to manually change the mipmap and filter settings on each material?

You can use non-embedded textures and change the flags on the textures in the Import dock.

Just for reference of anyone coming across this, is the present solution to use a) built-in materials or separate files and b) to manually change the mipmap and filter settings on each material?

You can use non-embedded textures and change the flags on the textures in the Import dock. If you still want to use embedded textures, you'll have to use a script on the MeshInstance to toggle filter/mipmaps on its textures at run-time.

Does non-embedable mean this?

And change flags manually on each one like this?

Does non-embedable mean this?

Yes, but make sure the individual texture files are separate as well (i.e. not embedded within the .material) file. Also, consider using the Files (.tres) option to use a more VCS-friendly text format instead of a binary format.

And change flags manually on each one like this?

Yes, but you need to do it from a script or your changes will be lost upon running the project or reimporting the glTF (depending on whether you've set materials to be kept on reimport).

Does non-embedable mean this?

Yes, but make sure the individual texture files are separate as well (i.e. not embedded within the .material) file. Also, consider using the Files (.tres) option to use a more VCS-friendly text format instead of a binary format.

And change flags manually on each one like this?

Yes, but you need to do it from a script or your changes will be lost upon running the project or reimporting the glTF (depending on whether you've set materials to be kept on reimport).

In my experience:

glTF cannot be made into insrtanced scene easily, so useless if I want to add a script or collider.
glb + seperate materials take up glb size * 2 due to the materials having the images embedded in them
glb + tres takes up 10x space as tres is awful for storing texture images
all the above are useless at following the project import settings (filter, mipmaps) and just totally ignore that part, leaving you to manually fix each and every texture import setting
gltf + serperate material or tres takes up about 1/4 as much space (tres slightly less) as glb built-in and respects import settings but no isntanced scenes (and the folder looks terrible with 20 files instead of 1)

So far, I've found no good solution for importing an object, having it respect my texture import settings and being able to turn it into an instanced scene to add scripts or colliders or whatever to.


New version: vim.vim version 9.1.0821

Pull request has been created with WinGet Releaser :rocket:
Microsoft Reviewers: Open in CodeFlow

@wingetbot run


how to load all NRRD images

If we have a lot of NRRD images on the local device, how can we load them?

use nrrdloader with nrrd_tools


Fix: MacOS 14.x launch bug without OpenGL installed

Fix #422

A darwin-specific fix lands to the main branch soon (tm)


Version Packages

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
<EMAIL_ADDRESS>Patch Changes

#606 ef18e36 Thanks @threepointone! - deploy to own cloudflare account
You can now deploy to your own CF account! To do so, you must set the following environment variables: CLOUDFLARE_ACCOUNT_ID and CLOUDFLARE_API_TOKEN, and add domain: your.domain.com to your partykit.json file.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[MONITOR-SPEC-PR]Artifact folder not found

Description:
Artifact folder not found for artifacts/packages/Release/Azure.Messaging.EventGridV2.
Additional context:
link1:
https://github.com/Azure/azure-rest-api-specs/pull/31801/checks?check_run_id=34157979501
link2:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4397070&view=logs&j=03afb3bb-7296-55ad-aa07-ceee610c73b2&t=0f320c29-1c90-5304-d2d3-c58a6bb76437&l=1224

@chunyu3 Could you take a look:

it has error https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4397070&view=logs&j=03afb3bb-7296-55ad-aa07-ceee610c73b2&t=0f320c29-1c90-5304-d2d3-c58a6bb76437&l=222, but treated as warning.
although it's failed, the generateOutput.json report succeeded https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4397070&view=logs&j=03afb3bb-7296-55ad-aa07-ceee610c73b2&t=0f320c29-1c90-5304-d2d3-c58a6bb76437&l=1296

@jianingwang123 please follow up


Add comments field on personal site when entering hours.

Allows the user to add comments when entering hours on the personal site. The comments field is available through the VolunteersReportHoursFS fieldset on the volunteers hours object.

David, let me know if there is anything else you would like me to do in order to get this request merged. Thanks. Vladimir


Support web UI

The pbgopy server is just an HTTP server, hence the client does not have to be a pbgopy command.
It would be nice to provide a simple web UI so that data can be shared even in environments where it is tough to install the pbgopy command, such as mobile devices. A page as simple as piping-server is ideal:

This interests me. Please correct me if I'm wrong but when you say

a page as simple as piping-server

you are referring to this UI yeah?

Eventually we want to offer something that rich, but we want something as simple as this for the first one.
See more: https://dev.to/nwtgck/data-streaming-with-every-device-over-httphttps-mo4
All we need to do is to send a request to the root path / and fix it to return a static page.

Currently, we use the root path for handling the clipboard, so we first have to change it to /clipboard.
https://github.com/nakabonne/pbgopy/blob/b77c9c20c1657bde380269698a72733d24cdf768/commands/serve.go#L74

I'll make a PR changing the clipboard endpoint first

Yes, please.

On the second thought, changing the clipboard endpoint is a significant breaking change, so it would be nice to include the change in the patch supporting Web UI.


Tokens not applying

Describe the bug
When styles are created from the plugin. The sets that were created and deleted, do not apply on the canvas.
To Reproduce
Steps to reproduce the behavior:

Create a theme, don't set any set as source
Create styles from the plugin
Delete a set of styles (example core)
Apply any token from that set (core)
The appearance on the canvas does not change
On inspect, the tokens are applied but changes cannot be seen on the Figma canvas

Expected behavior
Applying tokens should always reflect on the Figma canvas
Screenshots or Screencasts
Uploading Screen Recording 2022-09-30 at 7.38.11 PM.mov…

@esthercheran there is no video attached


new torch compatibility

people are being prompted on automatic1111 to update torch, it's causing conflicts with this app, breaking the program. have to reinstall venv without the extension present to fix it currently

I guess the problem here is that the installation script hasn't any mechanism to check if torch is arleady installed, and also tries to install an older version.
I tried the plugin using the newer version (even if i'm using an AMD gpu) and there shouldn't be any technical reason to keep torch version outdated.
I've created a pull request wich should solve the problem
https://github.com/enlyth/sd-webui-riffusion/pull/18

Thanks @DGdev91 I've been really busy with IRL stuff lately, merged


Finished tests in 0.002080s, 2404.3779 tests/s, 2404.3779 assertions/s.

5 tests, 5 assertions, 0 failures, 0 errors, 0 skips
/home/klee/.rvm/rubies/ruby-2.3.1/bin/ruby -S bundle exec cucumber --format progress
.....F-----.....F--------.....F-----....F-----

(::) failed steps (::)

expected "bundle exec rails g model User name:string" to be successfully executed (RSpec::Expectations::ExpectationNotMetError)
features/configuration.feature:11:in `And I successfully run `bundle exec rails g model User name:string`'

expected "bundle exec rails g model User name:string" to be successfully executed (RSpec::Expectations::ExpectationNotMetError)
features/configuration.feature:11:in `And I successfully run `bundle exec rails g model User name:string`'

expected "bundle exec rails g model User name:string" to be successfully executed (RSpec::Expectations::ExpectationNotMetError)
features/configuration.feature:11:in `And I successfully run `bundle exec rails g model User name:string`'

expected "bundle install" to be successfully executed (RSpec::Expectations::ExpectationNotMetError)
features/sets_validations.feature:7:in `And I successfully run `bundle install`'

Failing Scenarios:
cucumber features/configuration.feature:14 # Scenario: Setting enabled option to false disable Valle
cucumber features/configuration.feature:39 # Scenario: Using the exclude_models option should skip the models specified in the list
cucumber features/configuration.feature:80 # Scenario: Using exclude_attributes option should allow us to skip some attributes
cucumber features/sets_validations.feature:12 # Scenario: Using Valle automatically sets validations

4 scenarios (4 failed)
46 steps (4 failed, 23 skipped, 19 passed)
0m10.387s

This is what causes the failures on Travis:
https://travis-ci.org/akalyaev/valle/jobs/119921272

Yeah, there is an output, but it's impossible to understand why these tests are failing :(

This is the last green build:
https://travis-ci.org/akalyaev/valle/builds/60129428
And this is the first build that is red after that:
https://travis-ci.org/akalyaev/valle/jobs/116638496
So it looks like PR #24 might be the culprit.

@oliverklee thanks for reporting this 👍


Save the game

[ ] Save

[ ] Game version
[ ] Game stats

[ ] Play time
[ ] Steps

[ ] Replace current level in save-state

[ ] Containers

[ ] Phase
[ ] Items (only need to save what is not theirs)

[ ] Door phases
[ ] ToggleGroups (this could interfere with doors...)
[ ] Sequencers
[ ] Enemies
[ ] NPCs

[ ] Keep other levels
[ ] Overwrite Player

[ ] Stats
[ ] Inventory Items

[ ] Merge Lost items

inventories don't need to understand how to save but implement own save data load from save functions.
create interface for classes that react to save is load
make abstract class invoke them instead of inheriting stuff

ToggleGroup and Sequencers should probably be per dungeon and not assume to be singletons

lets try and close this issue by going through existing points. if the features are implemented, and not save implemented. then add save. lets not keep open for things that don't exist yet.

Closing this and letting each new implementation add save state


404 NOT FOUND - with docker image

After pull a new image of tomcat, the server does not start.
I solved the problem by renaming webapps.dist to webapps.

https://github.com/docker-library/tomcat/issues/183

see also #181 / #124 for additional detail.

So, the doc on docker hub should be updated, because after run the container you can't visit de homepage.
When i read this:

How to use this image.

Run the default Tomcat server (CMD ["catalina.sh", "run"]):

$ docker run -it --rm tomcat:8.0

You can test it by visiting

http://container-ip:8080

My test is unsuccessful.

$ docker run -d --rm --name tomcat tomcat:8.0
c9731f7c300653ebcb8edc7d238d0a51a4c20a5ae5cd88a6fcdf4d53ae2ce149

$ docker inspect tomcat | grep -i address
            "LinkLocalIPv6Address": "",
            "SecondaryIPAddresses": null,
            "SecondaryIPv6Addresses": null,
            "GlobalIPv6Address": "",
            "IPAddress": "<IP_ADDRESS>",
            "MacAddress": "02:42:ac:11:00:03",
                    "IPAddress": "<IP_ADDRESS>",
                    "GlobalIPv6Address": "",
                    "MacAddress": "02:42:ac:11:00:03",

$ curl <IP_ADDRESS>:8080 2>/dev/null | head
<!DOCTYPE html>
<html lang="en">
    <head>
        <meta charset="UTF-8" />
        <title>Apache Tomcat/8.0.53</title>
        <link href="favicon.ico" rel="icon" type="image/x-icon" />
        <link href="favicon.ico" rel="shortcut icon" type="image/x-icon" />

Following the documentation above works for me as well. The 404 response is due to the default webapps being removed in #181. The only amendment I'd suggest for the docs is that we drive users to Tomcat 9.0 instead of an EOL version (8.0) :)

Agreed, very good point -- I do think there's value in pointing out that we're no longer including the default webapps though, so I've updated both over in https://github.com/docker-library/docs/pull/1637. :+1:

Awesome, thanks @tianon :D I was going to submit that yesterday, but got tied up.

After pull a new image of tomcat, the server does not start.
I solved the problem by renaming webapps.dist to webapps.

it worked for me thank you...!! but can you explain how this rename fixed the issue

After pull a new image of tomcat, the server does not start.
I solved the problem by renaming webapps.dist to webapps.

it worked for me thank you...!! but can you explain how this rename fixed the issue

Because the new image put the tomcat server in webapps.dist directory but try to start with webapps directory.
I realised the problem is not in all docker image, also the target tomcat:8.5-jdk8 i tried.
I finally create a new docker image for me, with symbolic link, like:
`
FROM tomcat:8.5-jdk8
RUN ln -s /usr/local/tomcat/webapps.dist/manager webapps/manager
RUN ln -s /usr/local/tomcat/webapps.dist/host-manager webapps/host-manager
RUN ln -s /usr/local/tomcat/webapps.dist/ROOT webapps/ROOT
CMD ["catalina.sh", "run"]
`

docker pull tomcat:latest
docker run -d  --name mytomcat -p 8080:8080 tomcat:latest
docker exec -it  mytomcat /bin/bash
mv webapps webapps2
mv webapps.dist/ webapps
exit
http://host:8080
Test successful !

150411100 Thanks man ...its working fine now ...good recommendation...!!!

After pull a new image of tomcat, the server does not start.
I solved the problem by renaming webapps.dist to webapps.

Hi how can I rename it?

See https://github.com/docker-library/tomcat/pull/181#issuecomment-569817484 for one concrete example of how to accomplish that.
For further assistance, these sorts of questions/requests would be more appropriately posted to the Docker Community Forums, the Docker Community Slack, or Stack Overflow.


Add a timestamp to publication acks

Publication ACKs currently return the stream offset the message was committed to, but not its timestamp. This PR adds this.

PR created upstream, closing this one.


Revert "Moth Maggots"

Reverts Goob-Station/Goob-Station#852
ROACHES ARE BETTER

Summary by CodeRabbit
Release Notes

New Features

Introduced new entities, including diona nymph and various Cube types, enhancing gameplay diversity.
Added new microwave meal recipes, expanding culinary options.

Changes

Renamed roles and items from "SyndiMaggot" to "SyndiRoach" and updated associated descriptions.
Updated the moth maggot entity to mothroach with a refined description.

Documentation

Updated copyright information for texture resources to reflect new attributions.

PR denied, feel free to contribute NEVER

Uploading old man screaming into camera.mp4…

reconsidering thee options with @Piras314 rn...

durk must not selfmerge

Why can't we have both roaches and maggots?

mothmaggots are the better mothroach, you guys are just blind, YOU HATE CHANGE!! Y'ALL JUST BEING HATERS!!! MOTHROACHES ARE WORSE THEN MOTHMAGGOTS!! MOTHMAGGOTS LOW DIFF MOTHROACHESS!!!

Durk managed to close his own PR revert twice now, bluh

1984

1984

1984
(mothmaggots suck)

*chitters x603

1984

Can we lynch durk