split2flac: removed

Motivation for this change
This PR is a direct response to the opened issue https://github.com/NixOS/nixpkgs/issues/154555
I removed split2flac as it is a legacy project with the source archived on github. Furthermore it fails to build due to an indirect python2.7 dependency.
Closes #154555
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@bobby285271 thanks for the heads up. I rebased the branch.

needs another rebase

Would be nice to get this in

Would be nice to get this in

you can use the gh command to checkout a pr and then push changes to it
gh pr checkout 154917
and then just do normal git things

Sorry to hijack this, but can one then push stuff to the PR's branch, so in this case to dasj19:remove-split2flac? Or how would I change the PR otherwise?

That is only possible if you have write perms in nixpkgs
If you dont then you may create a new pr

Hi guys, sorry for my absence. I just did a rebase. Please merge this PR.


Commit d15adfc917b3d417980c6259c0c8f072f1f82082 increases system load from ~9 to ~16

As per https://github.com/prometheus/prometheus/issues/1472
d15adfc917b3d417980c6259c0c8f072f1f82082 is the next one
git bisect start
# good: [5b30bdb610a8fe7019edbf23bfc10412309ca5b8] Change TargetProvider interface.
git bisect good 5b30bdb610a8fe7019edbf23bfc10412309ca5b8
# bad: [fbe251c2df399b89bf87a11352ab26aff676d8d0] Fix scrape interval length calculation
git bisect bad fbe251c2df399b89bf87a11352ab26aff676d8d0
# skip: [05de8b7f8d43bc37b7198cad16e9b4760ba255ff] Extract target scraping into scrape loop.
git bisect skip 05de8b7f8d43bc37b7198cad16e9b4760ba255ff
# bad: [da99366f85bb9acc758ecc4ff0eeec43ac0310c7] Consolidate Target.Update into constructor.
git bisect bad da99366f85bb9acc758ecc4ff0eeec43ac0310c7
# bad: [d15adfc917b3d417980c6259c0c8f072f1f82082] Preserve target state across reloads.
git bisect bad d15adfc917b3d417980c6259c0c8f072f1f82082
# first bad commit: [d15adfc917b3d417980c6259c0c8f072f1f82082] Preserve target state across reloads.

Could you elaborate?
Next on for what? If the issue started in the commit you bisected in #1472, it will likely be there for all subsequent ones.

The last one went from load ~3 to ~9. This one went from ~9 to ~16.

I understand. Generally it's super helpful to get the profiling SVG that nicely shows where time is spent.
Basically, run this:
go tool pprof --svg http://<prometheus>/debug/pprof/profile > prof.svg

Good to know. Do you need that for those two issues?

Got one for the first one, which is hopefully fixed via #1474.
Would be great for this one.

Minor nitpick: GitHub does not allow SVG, only PNG, GIF, and JPG.
As they all look different, I made ten and had a sleep 10 in between.

System load with different builds: https://snapshot.raintank.io/dashboard/snapshot/fN9YwxGe8X9lxmQOwiK42pi6D6XQIo7L

Longer term data, with added ingestion rates: https://snapshot.raintank.io/dashboard/snapshot/3szO1U2vYxxDrYlwq26V1Dq844xw4J6L

Is this resolved?


 An empty array was returned because the Python Path config setting hasn't been set yet (didn't run into this issue locally since I had Python Path set).

Pull Request Test Coverage Report for Build 622112802

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 43.15%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/notebook/src/jupyter/jupyterServerInstallation.ts
0
1
0.0%

Totals

Change from base Build 621897641:
0.0%

Covered Lines:
25120

Relevant Lines:
53246

💛  - Coveralls


#101: Duplicate keys in bc file incorrectly leads to semicolon separated keys

Interesting, there seem to be unicode issue on Windows


build images weekly, without cache

this gives me the idea to also start making progress into buildx, it'd be cool if build-docker-images had a flag for outputting a bake file

depends on #791

this could also maybe implement parts of #610, checking that mounts works correctly


Support Laravel 9 too

hello! anything else I could do to get this merged faster? :)

Sadly, Arcanist was the only package which blocked me from updating to Laravel 9, so I will use my fork with the adjusted composer.json instead now.
It's sad to see @ksassnowski seems to not care about this package anymore.

Thanks @ziming ! Sorry for the delay.
@marcreichel save the guilt trip bullshit, please. This ain't my job and real life happens sometimes.

@ksassnowski Wasn't meant offending. Sorry if you thought it was. ❤


Rustup

@bors r+

:pushpin: Commit 5c6b4f3c684341cf4ac41a5cd2b796fe97d39306 has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit 5c6b4f3c684341cf4ac41a5cd2b796fe97d39306 with merge 693fcf679ca5dc8fa3149d058f077bc21d50b548...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 693fcf679ca5dc8fa3149d058f077bc21d50b548 to master...


Allow nextSnapshot from a non-snapshot version

Hi,
There's a bug in
mvn versions:set -DnextSnapshot

that prevents it from automatically generating the next snapshot if the current version isn't already a SNAPSHOT. This makes it relatively difficult to move to the next snapshot after we've deployed a release.
Before

After

+1 for getting this merged, as we'd also love this feature.

We would also like this feature. Just ran into this issue, came to see if it could be fixed, and there is already a pull request. Please merge!

Alternatively maybe @olamy or @hboutemy could take a look at this PR and subsequently PR #255 ?

@rfscholte could you take a look at this PR?

sounds a good feature. But I'd like to see an it test for this before merging.
Thanks

@olamy I created some tests in a separate PR #225. Should I combine this PR and the 1 with the tests in a single PR or would you rather merge them 1 after another?

@olamy I created a new PR #284 containing both this fix and the IT tests from PR #225

#284 merged.  I believe this one can be closed.


split up main.py according to classic RL parts

player.py or agent.py is fine, maybe agent.py since an agent can be a player or a bot and then you just implement different ways of controlling agents (random, human, GPT-3)
environment.py - this is your Game class

Nice, done here: https://github.com/aogara-ds/hoodwinked/commit/36a3b1f026e4fabc24438786f1aefa058ed373d3


Motor spinning on USB power reset

Despite the fixes in #7123, we still get motors spinning on unplugging the USB cable.
Steps to reproduce:

Plug in battery, USB cable
Start QGroundControl
Unplug USB cable

It only happens if QGroundControl has been talking to the PX4, as this triggers USB telemetry boolean that actually makes the PX4 reset after USB has been unplugged.
I have looked at the PWM signal with an oscilloscope and have pictures of it, but they aren't very telling.
Workaround:
In src/modules/commander/commander.cpp, find the usleep() just before the reboot and put board_on_reset(0); before the sleep. This sets all PWMs to zero.
A better long term fix would be to add a sleep to the board_on_reset.

We have the PixRacer hardware version 4, by the way.

@lericson - Thank you for reporting this. Please test https://github.com/PX4/Firmware/pull/7459
For a faster test cycle time: A reboot command on the debug port will also trigger the spin.
It is tricky to catch. The asynchronous reset has to occur when the PWM pins are high. So more testing is better, testing with a logic analyzer with analog, is the best way to see the fix is solid.
On the HW I tested the discharge rate was fast enough. I had assumed that is not the same on all HW and had the hook in place just incase. The PR use it.

It happens very consistently for us. Will try the PR on Monday, thanks! I had tried usleep at the same location but it didn't work -- might've been to short an interval too.

@lericson
Thank you! Please let me know how the testing goes. I may also need more details the proposed fix you have and the HW attached.

Just happened to me as well with a PixRacer on master ca480ff.

@ndepal Would you please test https://github.com/PX4/Firmware/pull/7459 and see if it stops the issue.

Just tested #7459, it does not fix the issue.

@ndepal would you be able to do a few more tests?

Comment out the usleep found here

Does the motors still spin?

Add the sleep back in as usleep(10000)

Does the motors still spin?
These are just tests to try to understand where the PWM is getting stretched.

Tested as requested.

motors still spin
motors still spin

@ndepal Thank you for testing.
Would you mind one more test?
Do as @lericson suggested place the  board_on_reset(0); call prior to this line
I will need to duplicate your setup. Please list what you have connected to the PixRacer and on what connector. Part number or links would be appreciated.

board_on_reset(0); fixes the problem for me, but only with a long enough sleep afterwards. I did not get spinning motors with usleep(300000); or above, but I did with usleep(200000); and below.
My setup:
Pixracer from auav.co
ESCs: Favourite Little Bee 30A
Motors: Emax cooling MT2206 II 1900KV
nothing else attached for these tests.

@ndepal Thank you that is super helpful. I think I understand what is happening. See https://github.com/PX4/Firmware/pull/7459/commits/0484ee32239a9534db455b0cf3788440dfa3b92a for the details. I have updated https://github.com/PX4/Firmware/pull/7459. would you please fetch it again and test it with no other modification.

Pulled and re-tested #7459, the issue is fixed for me.

@ndepal - thank you!
@lericson  I have updated #7459. would you please fetch it again and test it with no other modification.

Should be fixed.

Can confirm it no longer happens.  It even took off from the desk where it was seated, and not on USB reset either -- a simple reboot.


Add blocks icons

blocks-apart doubles as [VS Code] extensions from codicons.

What about adding a border radius?
Not 100% happy, what do you think about something like this?

What about adding a border radius?

Sure. See pushed (and optimised) changes…

Really nice icons @danielbayley
I agree with @jguddas.
Thanks for making the changes @danielbayley, those look more Lucide-like now.

Should the blocks icon not have the same rect as all the other layout icons?

It could be, but then the blocks are different sizes within this pair of icons, since blocks-apart can’t be made any bigger…

Hmm, this one is hard. On the one hand, we want this icon with both versions matching and on the other hand, we want consistency.
I tried to give it a shot, I used the blocks from layout-grid and it kinda works. But the combined blocks variant is a lot smaller. Let me know what you think

Hmm, this one is hard. On the one hand, we want this icon with both versions matching and on the other hand, we want consistency.

Yeah, seems like it should be simple, but then along come the tradeoffs… Like with so many things! 🙉

I tried to give it a shot, I used the blocks from layout-grid and it kinda works. But the combined blocks variant is a lot smaller. Let me know what you think …

The rounding of blocks-grid is different to blocks. But anyway I think having blocks-grid and grid-2 seems a bit redundant. So I’m leaning towards just keeping blocks and grid-2…
@ericfennis What about renaming https://lucide.dev/icons/grid to grid-3x3 and this one grid-2x2?

@danielbayley Can you rebase this PR?

@danielbayley Can you rebase this PR?

@karsa-mistmere Ready…


Got KeyError: 'RANK' when train on single GPU

Hi!
I do as the the  reply said to train the DAT-light model on single 3090 GPU，but got  KeyError: 'RANK' as follows.  How can I fix this?
root@autodl-container-2bae408949-4f297d06:~/DAT# python basicsr/train.py -opt options/Train/train_DAT_light_x2.yml --launcher pytorch
Traceback (most recent call last):
  File "basicsr/train.py", line 215, in <module>
    train_pipeline(root_path)
  File "basicsr/train.py", line 93, in train_pipeline
    opt, args = parse_options(root_path, is_train=True)
  File "/root/DAT/basicsr/utils/options.py", line 106, in parse_options
    init_dist(args.launcher)
  File "/root/DAT/basicsr/utils/dist_util.py", line 14, in init_dist
    _init_dist_pytorch(backend, **kwargs)
  File "/root/DAT/basicsr/utils/dist_util.py", line 22, in _init_dist_pytorch
    rank = int(os.environ['RANK'])
  File "/root/miniconda3/lib/python3.8/os.py", line 675, in __getitem__
    raise KeyError(key) from None
KeyError: 'RANK'

Hello, I also encountered this problem, I would like to ask if you have solved this problem

Set num_gpu in yml as 1.
And use the following script:
python basicsr/train.py -opt options/Train/train_DAT_light_x2.yml

Thanks for the author's immediate reply, but now I have a new question,

I am using a single 2080Ti run and have set both batch_size and num_worker to 1.

It may be that the cuda and pytorch versions do not match.
Re-build a new python environment use the following scripts:
conda create -n DAT python=3.8
conda activate DAT
pip install torch==1.8.0+cu111 torchvision==0.9.0+cu111 torchaudio===0.8.0 -f https://download.pytorch.org/whl/torch_stable.html
pip install -r requirements.txt (delete torch==1.8.0 and torchvision in requirements.txt)
python setup.py develop

Hello, I also encountered this problem, I would like to ask if you have solved this problem

I just add this lines in basicsr.utilsdist_util._init_dist_pytorch，and use command the author mentioned before then it works.
os.environ['RANK'] = '0'
os.environ['WORLD_SIZE'] = '1'
os.environ['MASTER_ADDR'] = '<IP_ADDRESS>'
os.environ['MASTER_PORT'] = '1234'

It may be that the cuda and pytorch versions do not match. Re-build a new python environment use the following scripts:
conda create -n DAT python=3.8
conda activate DAT
pip install torch==1.8.0+cu111 torchvision==0.9.0+cu111 torchaudio===0.8.0 -f https://download.pytorch.org/whl/torch_stable.html
pip install -r requirements.txt (delete torch==1.8.0 and torchvision in requirements.txt)
python setup.py develop

thx very much^_^


4.1.0 Unhandled Exception: System.NullReferenceException: Object reference not set to an instance of an object.

DryIoc 4.1.0 is throwing exception for load test.
See updated pull request to reproduce the problem:
https://github.com/dadhi/DryIoc/pull/165
Unhandled Exception: System.NullReferenceException: Object reference not set to an instance of an object.

Do you have maybe a line numbers for the exception stack?

@dadhi
Sure. I updated the issue. You can also reproduce the issue with changes done to LoadTest:
https://github.com/dadhi/DryIoc/pull/165

@dadhi
When debuggin the edited load test I am also seeing following alert to popup.

When debugging the edited load test I am also seeing following alert to popup.

Thanks, this is valuable - some of my assumtions were surely wrong. Will check.

Awesome, I'm waiting for next release! :)

@Havunen  Did you see the results I've added in comment in LoadTest Program.cs?
Interesting, is it OK to have 15 and 16 min of test time? I have also saw 155 threads in output. Sorry I did not have much time to fully grasp what the test is doing, just concentrated on the fixes.

Yes I noticed it. The test takes for a while because it creates lots of parallel load to verify there is no dead-lock / locking issues. I will run the tests now and compare it to previous DryIoc version to see if there is performance change.

@dadhi Did you notice that when running LoadTest using "WithoutFastExpressionCompiler" -option its now crashing to new exception:
Unhandled Exception:
Unhandled Exception:

Unhandled Exception:Unhandled Exception: Unhandled Exception:
Unhandled Exception: Unhandled Exception: Unhandled Exception: Unhandled Exception: Unhandled Exception:Unhandled Exception:
 Unhandled Exception: Unhandled Exception:   Unhandled Exception:
Unhandled Exception:

Unhandled Exception: Unhandled Exception: Unhandled Exception: System.IndexOutOfRangeException: Index was outside the bounds of the array.
   at DryIoc.Container.Registry.TryCacheKeyedFactory(Type type, Object key, Object factory)
   at DryIoc.Container.ResolveAndCacheKeyed(Type serviceType, Object serviceKey, IfUnresolved ifUnresolved, Object scopeName, Type requiredServiceType, Request preResolveParent, Object[] args)    at DryIoc.Container.ResolveAndCache(Type serviceType, IfUnresolved ifUnresolved)
   at DryIoc.Container.DryIoc.IResolver.Resolve(Type serviceType, IfUnresolved ifUnresolved)
   at LoadTest.Program.<>c__DisplayClass3_0.<IterateInOrder>b__0()
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ThreadHelper.ThreadStart()
System.IndexOutOfRangeException: Index was outside the bounds of the array.
   at DryIoc.Container.Registry.TryCacheKeyedFactory(Type type, Object key, Object factory)
   at DryIoc.Container.ResolveAndCacheKeyed(Type serviceType, Object serviceKey, IfUnresolved ifUnresolved, Object scopeName, Type requiredServiceType, Request preResolveParent, Object[] args)    at DryIoc.Container.ResolveAndCache(Type serviceType, IfUnresolved ifUnresolved)
   at DryIoc.Container.DryIoc.IResolver.Resolve(Type serviceType, IfUnresolved ifUnresolved)
   at LoadTest.Program.<>c__DisplayClass3_0.<IterateInOrder>b__0()
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ThreadHelper.ThreadStart()

I did not test it without FEC, but now will do. thanks again. I have a clue regarding this exception.

@Havunen ,
I have fixed the keyed resolution cache which was not working at all  - that means controllers were not cached and not compiled either.
After the fix it is became clear that compilation slows down the whole thing 100x times - so to emulate the previous results I need to add WithUseInterpreation() rule.
The problem with compilation is not only compilation time but multiple threads attempting to compile the same expression wasting the resources and moreover competing over resources slowing everythijg even further (cpu was 100% loaded).

@dadhi
I think its real-world problem in web applications, multiple threads can start resolving same controller same time? It would be good to get it fixed.
In the load test I tried to compile and cache everything before the actual parallel work starts.
See these code lines:
https://github.com/dadhi/DryIoc/blob/master/playground/LoadTest/Program.cs#L108-L110
I thought DryIoc works so that first time it resolves controller it interprets the result and then next time it caches it.  Doesn't it work like that anymore?

The lines you've mentioned should work as expected , I will add stopwatch to track how much time it takes.
I've added the issue #208 to address compilation.

I have documented the exact pipeline here https://github.com/dadhi/DryIoc/issues/199#issuecomment-573291497

I think, here is the way to go for now https://github.com/dadhi/DryIoc/issues/208#issuecomment-573294503

Feeling dumb, I've fixed another issue with the keyed service and it started to work.

I think ideally it would be nice to run LoadTest using all possible Configurations, but then it would take even longer to finish...

I have run it locally with and without FEC and the times are both faster (~ 7 and 10 minutes). I have added the results to the source and will push it later.
It would be also interesting to check WithUseInterpretation.. will see.


Update roleTemplates to not use locked if set as default

Problem:
A roleTemplate set to both locked and default is being applied when a
new cluster or project is created
Solution:
Verify a roleTemplate is not locked before using it as a default
Issue: https://github.com/rancher/rancher/issues/14788

@dramich can you add a test case for this?

LGTM


refactor(es/minifier): Split into multiple crates

Description:
Related issue (if exists):

Closes #4472

I tried moving tests and it was enough.


FileDialog with File System chosen for Access has a far too large minimum width.

Godot version
v4.1.stable.official [970459615]
System information
Godot v4.1.stable - Manjaro Linux #1 SMP PREEMPT_DYNAMIC Sun Jun  4 18:26:12 UTC 2023 - Vulkan (Compatibility) - AMD Radeon RX 570 Series (polaris10, LLVM 15.0.7, DRM 3.52, 6.3.5-2-MANJARO) () - AMD Ryzen 5 5600G with Radeon Graphics (12 Threads)
Issue description
When adding a FileDialog node to a scene and changing the Access type to File System the minimum width jumps up substantially. For Resources or User Data it is either 275 or 392 depending on the File Mode chosen, but as soon as it is changed to File System it jumps up to either 1341 or 1458. Which for any resolution around 720p or under will make it potentially wider than the screen.
Steps to reproduce
Step 1: Add FileDialog node to scene.
Step 2: Change Access type in inspector to File System
Step 3: Observe how wide the FileDialog becomes and how any attempts to lower the x size are futile.
Minimal reproduction project
N/A

Can't reproduce this on mac nor on fedora 38 under wayland. This needs more info.
What display server are you using?

I'm just using x11 (or whatever version of that Manjaro uses out of the box, as I haven't messed with that at all). If it makes any difference I am using KDE for my desktop.
I'd imagine it is probably an issue with one of the input fields that get added for the File System option that is likely increasing the minimum width due to their own large minimum width. Also be sure to note this is mainly an issue at smaller resolutions, where it ends up going off the screen area. It might not seem like an issue at 1080p or higher, but really wide dialogs that can't be shrunk down are a much bigger problem on lower res screens/windows.
I was going to try the native dialogs plugin as an alternative, but it seems that hasn't been updated for 4.1 yet. I might try to see if I can just cobble something together from control nodes to make it fit more seamlessly with the rest of my project's GUI. It doesn't seem like the FileDialog has much in the way of themeing options and the layout is really wonky and unintuitive anyhow.

So, I tried to repro with xorg as well, under fedora, but couldn't...
Also changed the resolution to 720p... this needs more testing and more data...
The text box changes yes, but it respects the size of the dialog box.
Screencast from 2023-07-22 19-16-40.webm
I would suggest providing more info on that.

Ok, so I just created a fresh file to see if I was missing anything. One thing that might make a difference is that I am using the Compatibility backend, as I was planning to see if I could get a web version of my current project working on itch io later on once I get everything worked out. Though after switching it to Forward+ the problem persisted.
I'd share a screenshot or a project file, but for whatever reason github wont let me attach anything. When I drag the jpg screenshot on it complains about it being an empty file and when I try to drag my zipped up test case project it complains that it can't process the file...

test.zip
Switched browsers and now I can attach files.


Replacing Image Deletes Updated Image

There is an error in the logic around replacing images.  I believe it exists for all images types (organization, campaign & event).  The following steps will reproduce the error (note this must be done on a copy that is using the Azure based IImageService such as http://allready-d.azurewebsites.net/):

Upload an image
Verify the image is visible
Edit the org/campaign/event again and upload the same image again.
After saving the image is now broken and throws an exception if you try and update again.

This will occur with any two images that use the same filename.  The problem stems from the way we are currently naming our blobs and the fact that we always upload and then delete the old one.  If they are using the same filename, we upload the replacement and then immediately delete it.

How to do you upload an image? I have tried as an organization admin. Can you show screenshots?

@wmay1991 when logged in as an organization admin it looks like you can only update the event images:

As a site admin you will see a similar upload option when editing organizations and campaigns.

@wmay1991 Did you look into this further?

Looking into this

@wmay1991
I've been looking at EventAdminController.cs as part of another issue and found the possible cause.   It appears that the wrong parameter is being passed to the UploadEventImageAsync method in public async Task<IActionResult> Edit(EventEditViewModel eventEditViewModel, IFormFile fileUpload).  campaign.Id is being passed.  It should be eventEditViewModel.Id.  This erroneous parameter could result in clashes if the same image file is being used for multiple events.
I corrected a similar issue (PR #1931) a coupe of weeks ago in the same controller.
I hope this helps.

@dchristensen
From above

This erroneous parameter could result in clashes if the same image file is being used for multiple events.

Does this sound like what you may have done?

@c0g1t8
While that may be an issue, I don't think it is the specific issue I am reporting.  I found this error while working on PR #1955, which originally suffered from the same problem.  The core issue is that when updating an image, if the new image's filename matches the original image's filename, the image just gets replaced in Blob Storage, however the code in the handler first uses the IImageService to save the image, then calls DeleteImage passing in the old image path.  Since the original and new images have the same path, the new image gets deleted and we're left with a record that points to an image that no longer exists.
In my eyes there are two ways of fixing this.

In the ImageService class make sure that every image has a unique path. (This is the approach I used for the FileImageService, but I don't know how important semantic/pretty paths are)
Fix the handlers that call into 'IImageService` to check the old path before trying to delete it to make sure its not the same path that was just returned when saving the new image.

As an aside, it might be nice to have some error handling around the Azure calls, since I've borked one of the campaigns now so that whenever you try to upload an image it throws an exception: http://allready-d.azurewebsites.net/Admin/Event/Edit/2

@dchristensen
First, nice work on the FileImageService.  That simplified local testing a lot. 😄
I think you've hit it on the head.  DeleteImageAsync should be called before UploadEventImageAsync.  Something like this should work:
                    if (fileUpload.IsAcceptableImageContentType())
                    {
                        var existingImageUrl = eventEditViewModel.ImageUrl;
                        if (!string.IsNullOrEmpty(newImageUrl))
                        {
                            eventEditViewModel.ImageUrl = newImageUrl;
                            if (existingImageUrl != null)
                            {
                                await _imageService.DeleteImageAsync(existingImageUrl);
                            }
                        }
                        var newImageUrl = await _imageService.UploadEventImageAsync(campaign.OrganizationId, eventEditViewModel.Id, fileUpload);
                    }

This would be the easiest fix and would handle the case where the actual image has changed but the filename has not.
I looked at the CampaignController implementation.  A similar fix should also work.  OrganizationController is implemented differently so I don't think this problem applies.
@wmay1991 Didn't mean to hijack the issue.  Curiosity got the better of me.

@c0g1t8 I think deleting after saving is the correct behavior, we wouldn't want to have something go wrong on the save and end up with no image at all.  I think comparing existingImageUrl and newImageUrl before actually calling DeleteImageAsync would resolve the issue.

@dchristensen You have a good point.  But you would only be comparing the URLs not the actual image files.  In the case the user wished to replace the image file with a different image file with the same name, they would need to first delete before uploading.
It sounds like we would need a swap/replace a method on the IImageService to maintain consistency.
In the short term, I would go with the simple fix.

It would resolve the problem immediately.
My previous experience with Azure blob storage has shown that it is remarkably reliable and resilient.  Though the issue you've pointed out is valid, the odds of it occurring and impact is low.

This is above my pay-grade 😄.  So I think we need the higher powers make the long term decisions.

@c0g1t8 I think comparing image URLs would be ok, since that is the identifier that is both returned from the Upload method and used to perform the Delete.

@dchristensen  I think I understand what you mean now.
if (fileUpload.IsAcceptableImageContentType())
{
    var existingImageUrl = eventEditViewModel.ImageUrl;
    var newImageUrl = await _imageService.UploadEventImageAsync(campaign.OrganizationId, campaign.Id, fileUpload);
    if (!string.IsNullOrEmpty(newImageUrl))
    {
        eventEditViewModel.ImageUrl = newImageUrl;
        if (existingImageUrl != null && existingImageUrl != newImageUrl)
        {
            await _imageService.DeleteImageAsync(existingImageUrl);
        }
    }
}

I like it 😄.  It preserves the old image in case the upload fails since that would be caught as an exception.  And it allows the user to replace the old image with a new one even if the filename is the same.

The fix sounds good to me. Sorry I have been unavailable the past couple days.

@wmay1991 If you don't mind, I'll push a PR on this.

Sure


VSCode cannot start app in the builtin terminal but works in Windows Terminal

Type: Bug

Behaviour
Expected vs. Actual
Expected behavior uvicorn main:app --reload would start my FastAPI app locally, it works fine in windows builtin terminal but failed connecting to Redis in VSCode's terminal
Now observing error failing to connect to Redis
Process SpawnProcess-1:
Traceback (most recent call last):
  File "C:\Program Files\Python310\lib\multiprocessing\process.py", line 314, in _bootstrap
    self.run()
  File "C:\Program Files\Python310\lib\multiprocessing\process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "D:\SynologyDrive\Programming\Github\master-interview\master-interview-backend\env\lib\site-packages\uvicorn\_subprocess.py", line 76, in subprocess_started
    target(sockets=sockets)
  File "D:\SynologyDrive\Programming\Github\master-interview\master-interview-backend\env\lib\site-packages\uvicorn\server.py", line 59, in run
    return asyncio.run(self.serve(sockets=sockets))
  File "C:\Program Files\Python310\lib\asyncio\runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "C:\Program Files\Python310\lib\asyncio\base_events.py", line 649, in run_until_complete
    return future.result()
  File "D:\SynologyDrive\Programming\Github\master-interview\master-interview-backend\env\lib\site-packages\uvicorn\server.py", line 66, in serve
    config.load()
  File "D:\SynologyDrive\Programming\Github\master-interview\master-interview-backend\env\lib\site-packages\uvicorn\config.py", line 471, in load
    self.loaded_app = import_from_string(self.app)
  File "D:\SynologyDrive\Programming\Github\master-interview\master-interview-backend\env\lib\site-packages\uvicorn\importer.py", line 21, in import_from_string
    module = importlib.import_module(module_str)
  File "C:\Program Files\Python310\lib\importlib\__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "D:\SynologyDrive\Programming\Github\master-interview\master-interview-backend\main.py", line 27, in <module>
    import chat.chat as chat
  File "D:\SynologyDrive\Programming\Github\master-interview\master-interview-backend\chat\chat.py", line 12, in <module>
    import feedback.feedback as feedback
  File "D:\SynologyDrive\Programming\Github\master-interview\master-interview-backend\feedback\feedback.py", line 14, in <module>
    from cache.conversationCache import redisClient
  File "D:\SynologyDrive\Programming\Github\master-interview\master-interview-backend\cache\conversationCache.py", line 16, in <module>
    result = redisClient.ping()
  File "D:\SynologyDrive\Programming\Github\master-interview\master-interview-backend\env\lib\site-packages\redis\commands\core.py", line 1194, in ping
    return self.execute_command("PING", **kwargs)
  File "D:\SynologyDrive\Programming\Github\master-interview\master-interview-backend\env\lib\site-packages\redis\client.py", line 1255, in execute_command
    conn = self.connection or pool.get_connection(command_name, **options)
  File "D:\SynologyDrive\Programming\Github\master-interview\master-interview-backend\env\lib\site-packages\redis\connection.py", line 1442, in get_connection
    connection.connect()
  File "D:\SynologyDrive\Programming\Github\master-interview\master-interview-backend\env\lib\site-packages\redis\connection.py", line 710, in connect
    self.on_connect()
  File "D:\SynologyDrive\Programming\Github\master-interview\master-interview-backend\env\lib\site-packages\redis\connection.py", line 754, in on_connect
    auth_response = self.read_response()
  File "D:\SynologyDrive\Programming\Github\master-interview\master-interview-backend\env\lib\site-packages\redis\connection.py", line 865, in read_response
    response = self._parser.read_response(disable_decoding=disable_decoding)
  File "D:\SynologyDrive\Programming\Github\master-interview\master-interview-backend\env\lib\site-packages\redis\connection.py", line 346, in read_response
    result = self._read_response(disable_decoding=disable_decoding)
  File "D:\SynologyDrive\Programming\Github\master-interview\master-interview-backend\env\lib\site-packages\redis\connection.py", line 369, in _read_response
    raise error
redis.exceptions.AuthenticationError: invalid username-password pair

Steps to reproduce:

Have a python  FastAPI app, with a virtual env, then make some connection to MongoDb or Redis
2. Activate the virtual env
3. try to start the app with uvicorn main:app --reload and it will fail due to incorrect pwd or user name error although trying in windows terminal works

Diagnostic data

Python version (& distribution if applicable, e.g. Anaconda): 3.10.10
Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Venv
Value of the python.languageServer setting: Default

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

XXX

User Settings

languageServer: "Pylance"

VS Code version: Code 1.85.2 (8b3775030ed1a69b13e4f4c628c612102e30a681, 2024-01-18T06:40:10.514Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz (8 x 3600)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.92GB (15.18GB free)

Process Argv
--crash-reporter-id 89e2fc8a-566b-4794-a71c-2132e1c2d0fc

Screen Reader
no

VM
0%

Extensions (52)

Extension
Author (truncated)
Version

project-manager
ale
12.7.0

vscode-color
ans
0.4.5

gitignore
cod
0.9.0

doxdocgen
csc
1.4.0

vscode-eslint
dba
2.4.4

git-extension-pack
don
0.1.3

githistory
don
0.6.20

es7-react-js-snippets
dsz
4.4.3

gitlens
eam
14.7.0

vsc-material-theme
Equ
33.1.2

vsc-material-theme-icons
equ
1.2.2

prettier-vscode
esb
10.1.0

figma-vscode-extension
fig
0.3.3

copilot
Git
1.156.0

copilot-chat
Git
0.11.1

better-cpp-syntax
jef
1.17.2

git-graph
mhu
1.30.0

prettify-json
moh
0.0.3

vscode-azureappservice
ms-
0.25.1

vscode-azurefunctions
ms-
1.13.2

vscode-azureresourcegroups
ms-
0.8.3

vscode-cosmosdb
ms-
0.20.1

black-formatter
ms-
2024.0.0

debugpy
ms-
2024.0.0

isort
ms-
2023.10.1

pylint
ms-
2023.10.1

python
ms-
2024.0.0

vscode-pylance
ms-
2023.12.1

jupyter
ms-
2023.11.1100101639

jupyter-keymap
ms-
1.1.2

jupyter-renderers
ms-
1.0.17

vscode-jupyter-cell-tags
ms-
0.1.8

vscode-jupyter-slideshow
ms-
0.1.5

remote-ssh-edit
ms-
0.86.0

azure-account
ms-
0.11.6

cmake-tools
ms-
1.16.32

cpptools
ms-
1.18.5

cpptools-extension-pack
ms-
1.3.0

powershell
ms-
2024.0.0

remote-explorer
ms-
0.4.1

vsliveshare
ms-
1.0.5905

color-highlight
nau
2.5.0

material-icon-theme
PKi
4.33.0

java
red
1.27.0

vs-code-prettier-eslint
rve
5.1.0

cmake
twx
0.0.17

vscodeintellicode
Vis
1.2.30

vscode-java-debug
vsc
0.56.0

vscode-java-dependency
vsc
0.23.4

vscode-java-pack
vsc
0.25.15

vscode-todo-highlight
way
1.0.5

vscode-open-in-github
ziy
1.3.6

(2 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscorecescf:30445987
vscod805:30301674
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:30899288
c4g48928:30535728
azure-dev_surveyone:30548225
vscrp:30673768
a9j8j154:30646983
962ge761:30951796
pythongtdpath:30769146
welcomedialogc:30910334
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
pythontbext0:30879054
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
dsvsc019b:30953937
3ef8e399:30949928
bg6jg535:30956215

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.86.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

This type of issue is typically related to environment differences between VS Code's terminal and the external terminal. You can try diffing the two environments by printing them (eg. env, Get-ChildItem env:) and investigating any differences.
Closing this off as it doesn't look actionable on our end, you can read more about our issue process here. Thanks for understanding.
/label *question

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.
Happy Coding!


Synchronisation problem when resolving the channel

Hi, We are getting an strange error when we try to get a channel
Could not register object [org.springframework.integration.channel.DirectChannel@2898b3cc] under bean name 'topic_name': there is already object [topic_name]
I am using BinderAwareChannelResolver::resolveDestination(topicName)
Do you think we need to use a synchronized context there? Normally happens when we use concurrent threads at the beginning

@FcoJavierSainz Could be a concurrency issue - what version of the framework are you using?

Here is the SCS version
dependencyManagement {
     imports {
          mavenBom 'org.springframework.cloud:spring-cloud-stream-dependencies:Brooklyn.SR3'
     }
}

And here the dependencies, we override spring-integration-kafka
	compile 'org.springframework.integration:spring-integration-kafka:2.1.0.RELEASE'
	compile 'org.springframework.cloud:spring-cloud-stream'
	compile 'org.springframework.cloud:spring-cloud-starter-stream-kafka'
	compile('org.apache.kafka:kafka-clients:<IP_ADDRESS>') {
		exclude module: 'slf4j-log4j12'
	}```

@mbogoevici see my comment in Gitter - we need to recheck the bean can't be resolved inside the synchronized block.

I am on it.

Thanks @garyrussell :)


railway up --ci doesn't wait for build to finish in GitLab CI/CD

The goal of railway up --ci from #477 is to allow you to wait for the build to succeed or fail in a CI environment such as GitLab CI/CD.
The command behaves as expected when running locally on my MacBook.
I see build logs streaming in and it ends with a Deploy complete message when the service is actually live on Railway.

When I use the same flag in GitLab CI/CD however, the pipeline exits after upload is complete and a link to the build logs is shown. It effectively behaves the same as it used to with the --detach flag.

I verified that both my MacBook and the GitLab runner are using the latest Railway CLI version 3.9.3 by running railway --version (see output from GitLab CI in pic above).
The gitlab-ci.yml pipeline is based on the official guide Using GitLab CI/CD with Railway, only difference is I changed -d to --ci

This issue can be closed now as the problem has been fixed in #537


Cpp translation - initial generation of header files

There are a couple of distinct changes in this branch, the most major of which is the addition of a cpp (headers only so far) translator that exports .h files to a cpp subdirectory of the build folder.
In addition,

pylint warnings have started to be fixed in various python files, including files in the doc directory.
Some instances of os.path have been replaced with pathlib Path.

I wanted to get this much work merged before fleshing out the following items:

Using the new SchemaFile if possible for the cpp translation
Add cpp implementation file generation
More pylint fixes and the addition of a CI check for them
Complete pathlib transition.

The latest checkin contains CPP code generation.


Include the readme on PyPI

Would be nice to have the readme contents here: https://pypi.org/project/pyganja/
There are some simple instructions about how to do that here: https://packaging.python.org/guides/making-a-pypi-friendly-readme/

Fixed in https://github.com/pygae/pyganja/commit/4279fa1b9fde37193b10b8be3a6368a6307ac485


scan the base build image for vulnerabilities before compiling binaries and copying to Scratch image

Is your feature request related to a problem? Please describe.
The k3s image build process results in a FROM scratch image.  As such, scanners like trivy/clair/etc do not run against the image.
Describe the solution you'd like
Scanning the base build image as part of the image build process before the binaries are compiled and copied over to the final Scratch image would allow for proactive identification and remediation of any known vulnerabilities in the libraries included in the compiled binary.

I believe this is closed by #2253


Implement support for LlamaIndex

CassIO currently supports Langchain. We should add support for LlamaIndex next.
Integration options:
Vector Store - https://gpt-index.readthedocs.io/en/latest/how_to/integrations/vector_stores.html
Index Stores - https://gpt-index.readthedocs.io/en/latest/how_to/storage/index_stores.html

I suggest this should be broken down into more manageable better-defined units, such as "Llamaindex: Cassandra backend for VectorStoreIndex interface", plus others.

Agreed - I've added a new label called "Epic" to help differentiated very large items VS things that are actionable.

This task has been broken up but wanted to add context in the parent task
*LllamaIndex - Complete

Details

CassIO currently supports Langchain. We should add support for LlamaIndex next.
Integration options:

Vector Store
Index Stores
Document Store (KV Store)

suggest this should be broken down into more manageable better-defined units, such as "Llamaindex: Cassandra backend for VectorStoreIndex interface", plus others.

Outcome

#79
#38
#78
Create examples to use LllamaIndex - Index Data, use Chainlit UI to ask questions

References

https://gpt-index.readthedocs.io/en/stable/core_modules/data_modules/storage/docstores.html
https://gpt-index.readthedocs.io/en/latest/how_to/storage/index_stores.html
https://gpt-index.readthedocs.io/en/latest/how_to/integrations/vector_stores.html


[Story] Identify what an R app and R library are

What projects is this story for?
No response
As a user, I want
NA
Description
This monorepo has two types of projects:

app (apps/)
library (libs/)

Each project (app or lib) defines a set of tasks that it implements in its project.json. Examples are build, test, lint or any other task required by the project.
The goal of this ticket is to identify what technologies are required to develop R apps and libraries in this monorepo. For example, the dependencies of a Python project are managed with Poetry. The version of Python needed by a given project is managed with Pyenv. The only type of Python app currently in the monorepo is a REST API. Another type of Python app that could be added in the future is CLI. This monorepo has both REST API and CLI examples for TypeScript.

A Python app example is apps/schematic/api
A Python library example is libs/schematic/api-client-python

@andrewelamb @afwillia @jaeddy What do you think an R app and library should be in the monorepo? There are possibly multiple answers for what an app is (e.g. REST API and CLI). What tools should be used to manage the dependencies of an R project? Using Pyenv as a reference for managing different version of Python, is there a similar tool to manage multiple versions of R?
Acceptance criteria

@andrewelamb, @afwillia and @jaeddy signed off on the framework and tools the monorepo should support to develop R apps and libraries

Tasks
No response
Anything else?
No response
Have you linked this story to a GitHub Project?

[X] I have linked this story to a GitHub Project and set its metadata.

@tschaffter I can add some more to this later, but renv does a lot of the same things poetry does, and could be considered equivalent.

(copied from Slack)

i haven’t done serious R development in a while, so i can’t guarantee that these resources are the latest and greatest… but might be a good starting point. the #r channel would also be a good place to ask and/or cross-check the resources below

R package development

the R Packages book describes best practices, and includes info about some core packages (e.g., devtools, testthat, etc.)
i’m not sure how much there is in terms of “frameworks” for building R libraries; there are a view different paradigms for object oriented programming, which are described in the Advanced R book
one could potentially view Bioconductor as a pseudo-framework (i.e., specific and opinionated ways to build packages), but that will probably be less relevant to most of our R tools

Shiny app development

similarly, there are a couple books describing best practices for app development: (1) Engineering Production-Grade Shiny Apps - published “independently” a few years ago; and (2) Mastering Shiny - written and published by Hadley Wickham / Posit, so maybe more authoritative, but not sure if it includes as much about production deployment
the first book references golem (see golemverse), which is a framework for building Shiny apps, and is somewhat unique in that it treats Shiny apps as R packages
another more recent framework is Rhino, developed by  Appsilon — i think it doesn’t require your app to be an R package, but might be more compatible with other web dev frameworks (see screenshot below)
Appsilon also has a lot of other great resources for building “enterprise grade” Shiny apps, including a nice blog

multiple versions of R

i’m not sure if this is something supported by renv (see package site), but might be worth checking
here’s a blog post from someone describing their approach for installing/managing multiple R versions on Mac OSX — it might be more straightforward in Linux environments

The articles describe how to manage multiple R versions on the same host:

Installing multiple parallel versions of R on Mac and getting back up and running quickly by simplifying package installation
Managing Multiple R Installations on Linux

Initially a single version of R should suffice. I will try these instructions from Posix to install R with a pinned version.


Bug - Passing more than one command as entrypoint override

Due a pointer wrong reference, when I try to pass more than one command, this happens:

PR> https://github.com/josmo/drone-ecs/pull/50

Yes, up and running!

Glad to hear! Thanks @dminella I've tagged 1.1.0 and it should be published now.


AGI BANK (AGIB)

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[ ] Filename in the lowercase format
[ ] Image format: png
[ ] Image size: 256 by 256 px

No need to add multiple images in different folders, please get familiar with requirements for next PR https://developer.trustwallet.com/add_new_token_image. For now added here  https://github.com/TrustWallet/tokens/commit/49cbb15411a850b0c98e5fe71e92928a40a37a81


Collapse HorizontalAlignment and VerticalAlignment modifiers into one

In Compose UI, the Row/Column scope offers a unified align modifier. In CSS, this is the same as align-self.
If someone changes from a Row to a Column, I wouldn't also expect that the children modifier names to be changed (previously it would've been from verticalAlignment to horizontalAlignment.

@veyndan I'd argue that we shouldn't make this change as it changes the public API names to be less clear:
Column {
    Image(url, modifier = Modifier.alignment(CrossAxisAlignment.Center)
}

Is less clear because it doesn't specify if we're aligning on the horizontal or vertical axis:
Column {
    Image(url, modifier = Modifier.horizontalAlignment(CrossAxisAlignment.Center)
}

@colinrtwhite Responded at https://github.com/cashapp/redwood/pull/1292#issuecomment-1612126907. Happy to have a video chat about this too!


How to update existing birds with latest from Cookiecutter template?

Description
We consistently improve the template while we are using the WPS birds. What could be ways to update existing birds with the improvements?
Environment

Cookiecutter version used, if any:
Python version, if any:
Operating System:

Steps to Reproduce
Additional Information

Collecting ideas ...
It could be helpful to keep the cookiecutter settings to re-run the cookiecutter. The generated bird can be compared with the existing bird using (git) diff.

See also for improving test-suite:
https://github.com/bird-house/bird-house.github.io/issues/28

I was thinking more of a git command. Something like : go back to the original cookie-cutter commit, create the new version then apply all the other changes.

I think that the procedure would then look like this:
git co -b orig_cookiecutter_update <SHA of the first commit>
git clean -fxd
# Run cookie-cutter with extra context arguments reflecting how it was called the first time.
git add *
git add */.*
git ci -m 'update cookiecutter template'
git co -b cookiecutter_update master
git merge orig_cookiecutter_update

@cehbrecht One issue is that the date is going to be updated, because the jinja template uses the current date. This will screw the CHANGES.rst file
-0.1.0 (2018-04-16)
+0.1.0 (2020-01-10)

Cookiecutter should probably then take the date as an argument, so we can pass the original date of creation.

We could tune the template more to avoid potential conflicts when updating with the script in PR #79.


.github/workflows/benchmarks: support push to Github Pages

this commit adds auto-push: true to the benchmark-action/github-action-benchmark
which allows it commit changes and push to gh-pages branch and display charts
dashboard on GitHub Pages.
close #620

Update
Check out https://containerd.github.io/runwasi/dev/bench/


K8SPXC-360: keep HAProxy version during status update

HAProxy version received from version service and set only once, we should intentionally save it during status updates later

Test name
Status

storage
passed

recreate
passed

scaling
passed

big-data
failed

init-deploy
passed

self-healing
passed

scaling-proxysql
passed

limits
passed

upgrade
passed

restore-to-encrypted-cluster
failed

self-healing-advanced
failed

demand-backup
passed

upgrade-consistency
passed

monitoring
passed

security-context
passed

operator-self-healing
passed

monitoring-2-0
passed

scheduled-backup
failed

affinity
passed

one-pod
passed

demand-backup-encrypted-with-tls
failed

auto-tuning
passed

proxysql-sidecar-res-limits
passed


vscode-server failed to install on remote windows machine using remote-ssh

Type: Bug
two windows machines, successfull connect using remote-ssh, but installing vscode-server fails with the following error (after downloading finishes at 100%):
[12:49:59.549] [server] Error installing server: error reading entry file: invalid gzip header
loops again through download and this error.
VS Code version: Code - Insiders 1.91.0-insider (aea213b7fcc7de5c24ad797ac1af209b159d451f, 2024-06-28T05:56:20.804Z)
OS version: Windows_NT x64 10.0.22631
Modes:
Connection to 'SSH: <IP_ADDRESS>' could not be established  Connecting was canceled

System Info

Item
Value

CPUs
AMD Ryzen 7 7800X3D 8-Core Processor            (16 x 4200)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.10GB (18.69GB free)

Process Argv

Screen Reader
no

VM
36%

Connection to 'SSH: <IP_ADDRESS>' could not be established  Connecting was canceled
Extensions: none
A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805cf:30301675
vsaa593cf:30376535
py29gd2263:31024238
vscaac:30438845
c4g48928:30535728
2i9eh265:30646982
962ge761:30841072
pythongtdpath:30726887
welcomedialog:30812478
pythonnoceb:30776497
asynctok:30898717
dsvsc013:30777762
dsvsc014:30777825
dsvsc015:30821418
pythonregdiag2:30926734
pythonmypyd1:30859725
h48ei257:31000450
pythontbext0:30879054
accentitlementst:30870582
dsvsc016:30879898
dsvsc017:30880771
dsvsc018:30880772
cppperfnew:30980852
pythonait:30973460
jchc7451:31067543
chatpanelt:31014475
724cj586:31013169
a69g1124:31018687
dvdeprecation:31040973
dwnewjupytercf:31046870
nb_pkg_only:31057982
nativerepl2:31071685
refactort:31084545
pythonrstrctxt:31083681
0c838689:31088353

issue exist with stable vscode version as well.

I have the same issue on 1.91.0 (user setup) and also v1.90;
ps:but if login with other users ,  some will login success but some still fail .
版本: 1.91.0 (user setup)
提交: ea1445cc7016315d0f5728f8e8b12a45dc0a7286
日期: 2024-07-01T18:52:22.949Z
Electron: 29.4.0
ElectronBuildId: 9728852
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Windows_NT x64 10.0.22631

Just want to share setting remote.SSH.useExecServer to false solves my issue for now.

remote.SSH.useExecServer

confirmed.

Please share the Remote - SSH log from the Output panel

Please share the Remote - SSH log from the Output panel

Version: 1.92.0 (Universal)
Commit: b1c0a14de1414fcdaa400695b4db1c0799bc3124
Date: 2024-07-31T23:26:45.634Z (1 day ago)
Electron: 30.1.2
ElectronBuildId: 9870757
Chromium: 124.0.6367.243
Node.js: 20.14.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 23.5.0
Local: MacBookAir M2
Remote: Windows 11 Pro (Intel)
For my case, this only affect remote Windows connection. Remote Linux not affected.
When this happen, the output panel is empty. There are multiple download server notification. One of them show error:
Failed to connect to the remote extension host server (Error: WrappedError(WrappedError { message: "error reading entry file", original: "invalid gzip header" }))

lioujheyu instruction above does allow me to connect to the Windows machine.

@J-Siu Please share the Remote - SSH log from the Output panel

This is my log showing the same error connecting to a Windows Machine.
[08:27:28.590] Log Level: 2
[08:27:28.604] SSH Resolver called for "ssh-remote+jheyulio-desk1", attempt 1
[08:27:28.604] "remote.SSH.useLocalServer": false
[08:27:28.604] "remote.SSH.useExecServer": true
[08:27:28.604] "remote.SSH.showLoginTerminal": false
[08:27:28.604] "remote.SSH.remotePlatform": {"jheyulio-desk1":"windows","remote_wsl":"linux"}
[08:27:28.604] "remote.SSH.path": undefined
[08:27:28.604] "remote.SSH.configFile": undefined
[08:27:28.604] "remote.SSH.useFlock": true
[08:27:28.604] "remote.SSH.lockfilesInTmp": false
[08:27:28.605] "remote.SSH.localServerDownload": auto
[08:27:28.605] "remote.SSH.remoteServerListenOnSocket": false
[08:27:28.605] "remote.SSH.showLoginTerminal": false
[08:27:28.605] "remote.SSH.defaultExtensions": []
[08:27:28.605] "remote.SSH.loglevel": 2
[08:27:28.605] "remote.SSH.enableDynamicForwarding": true
[08:27:28.605] "remote.SSH.enableRemoteCommand": false
[08:27:28.605] "remote.SSH.serverPickPortsFromRange": {}
[08:27:28.605] "remote.SSH.serverInstallPath": {}
[08:27:28.605] "remote.SSH.permitPtyAllocation": false
[08:27:28.605] "remote.SSH.preferredLocalPortRange: undefined
[08:27:28.605] "remote.SSH.useCurlAndWgetConfigurationFiles: false
[08:27:28.608] VS Code version: 1.91.1
[08:27:28.608] Remote-SSH version<EMAIL_ADDRESS>[08:27:28.609] win32 x64
[08:27:28.614] SSH Resolver called for host: jheyulio-desk1
[08:27:28.614] Setting up SSH remote "jheyulio-desk1"
[08:27:28.617] Using commit id "f1e16e1e6214d7c44d078b1f0607b2388f29d729" and quality "stable" for server
[08:27:28.618] Install and start server if needed
[08:27:28.623] Checking ssh with "C:\windows\system32\ssh.exe -V"
[08:27:28.625] Got error from ssh: spawn C:\windows\system32\ssh.exe ENOENT
[08:27:28.625] Checking ssh with "C:\windows\ssh.exe -V"
[08:27:28.627] Got error from ssh: spawn C:\windows\ssh.exe ENOENT
[08:27:28.627] Checking ssh with "C:\windows\System32\Wbem\ssh.exe -V"
[08:27:28.629] Got error from ssh: spawn C:\windows\System32\Wbem\ssh.exe ENOENT
[08:27:28.629] Checking ssh with "C:\windows\System32\WindowsPowerShell\v1.0\ssh.exe -V"
[08:27:28.630] Got error from ssh: spawn C:\windows\System32\WindowsPowerShell\v1.0\ssh.exe ENOENT
[08:27:28.630] Checking ssh with "C:\windows\System32\OpenSSH\ssh.exe -V"
[08:27:28.695] > OpenSSH_for_Windows_8.6p1,
[08:27:28.696] > LibreSSL 3.4.3

[08:27:28.701] Remote command length: 4962/8192 characters
[08:27:28.701] Running script with connection command: "C:\windows\System32\OpenSSH\ssh.exe" -T -D 63086 "jheyulio-desk1" powershell
[08:27:28.704] Terminal shell path: C:\windows\System32\cmd.exe
[08:27:29.787] > Windows PowerShell
> Copyright (C) Microsoft Corporation. All rights reserved.Install the latest PowerShell for new features and improvements! https://aka.ms/PSWindowsPS C:\Users\jheyulio>
> PS C:\Users\jheyulio> $uuid="702d5e0938c9"
> PS C:\Users\jheyulio> "${uuid}: running"
> 702d5e0938c9: running
> PS C:\Users\jheyulio> "702d5e0938c9: pauseLog"
> 702d5e0938c9: pauseLog
[08:27:29.787] Got some output, clearing connection timeout
[08:27:30.148] >
[08:27:30.420] > Looking for existing CLI in C:\Users\jheyulio\.vscode-server
> Found installed CLI
> Starting cli: & 'C:\Users\jheyulio\.vscode-server\code-f1e16e1e6214d7c44d078b1f0
[08:27:30.439] >
> 0607b2388f29d729.exe' command-shell --cli-data-dir 'C:\Users\jheyulio\.vscode-ser
> rver\cli' --parent-process-id 11480 --on-host <IP_ADDRESS> --on-port --require-token
> n 4e955286-28dc-4496-9625-eee814cbec32 *> 'C:\Users\jheyulio\AppData\Local\Temp\t
> tmpD099.tmp'
[08:27:30.462] >
[08:27:30.890] > 702d5e0938c9: start
> SSH_AUTH_SOCK====
> listeningOn==51897==
> osReleaseId==windows==
> osVersion==10.0.22631==
> arch==x64==
> platform==windows==
> unpackResult====
> didLocalDownload==False==
> downloadTime====
> installTime====
> extInstallTime====
> serverStartTime==54==
> execServerToken==1a111111-11aa-1111-1111-aaa111aaaa11==
> 702d5e0938c9: end
> 17964, watching 11480
[08:27:30.891] Received install output:
SSH_AUTH_SOCK====
listeningOn==51897==
osReleaseId==windows==
osVersion==10.0.22631==
arch==x64==
platform==windows==
unpackResult====
didLocalDownload==False==
downloadTime====
installTime====
extInstallTime====
serverStartTime==54==
execServerToken==1a111111-11aa-1111-1111-aaa111aaaa11==

[08:27:30.891] Remote server is listening on port 51897
[08:27:30.891] Parsed server configuration: {"serverConfiguration":{"remoteListeningOn":{"port":51897},"osReleaseId":"windows","arch":"x64","sshAuthSock":"","platform":"windows","execServerToken":"1a111111-11aa-1111-1111-aaa111aaaa11"},"serverStartTime":54,"installUnpackCode":""}
[08:27:30.898] Starting forwarding server. local port 63099 -> socksPort 63086 -> remotePort 51897
[08:27:30.900] Forwarding server listening on port 63099
[08:27:30.900] Waiting for ssh tunnel to be ready
[08:27:30.901] [Forwarding server port 63099] Got connection 0
[08:27:30.903] Tunneled port 51897 to local port 63099
[08:27:30.903] Resolved "ssh-remote+jheyulio-desk1" to "port 63099"
[08:27:30.913] Initizing new exec server for ssh-remote+jheyulio-desk1
[08:27:30.913] Resolving exec server at port 63099
[08:27:30.941] [Forwarding server port 63099] Got connection 1
[08:27:31.008] Exec server for ssh-remote+jheyulio-desk1 created and cached
[08:27:31.014] ------

[08:27:31.058] [server] Checking C:\Users\jheyulio\.vscode-server\cli\servers\Stable-f1e16e1e6214d7c44d078b1f0607b2388f29d729\log.txt and C:\Users\jheyulio\.vscode-server\cli\servers\Stable-f1e16e1e6214d7c44d078b1f0607b2388f29d729\pid.txt for a running server...
[08:27:31.152] [server] Installing and setting up Visual Studio Code Server...
[08:28:13.593] [server] Downloading Visual Studio Code server -> C:\Users\jheyulio\AppData\Local\Temp\.tmpGnpmiW\stable
[08:28:13.598] [server] server download progress: 0/48343944 (0%)
[08:28:13.841] [server] server download progress: 2105344/48343944 (4%)
[08:28:14.027] [server] server download progress: 4210687/48343944 (9%)
[08:28:14.197] [server] server download progress: 6316031/48343944 (13%)
[08:28:14.423] [server] server download progress: 8421374/48343944 (17%)
[08:28:14.650] [server] server download progress: 10526718/48343944 (22%)
[08:28:14.929] [server] server download progress: 12632061/48343944 (26%)
[08:28:15.335] [server] server download progress: 14737405/48343944 (30%)
[08:28:15.579] [server] server download progress: 16842748/48343944 (35%)
[08:28:15.835] [server] server download progress: 18948092/48343944 (39%)
[08:28:16.083] [server] server download progress: 21053435/48343944 (44%)
[08:28:16.326] [server] server download progress: 23158779/48343944 (48%)
[08:28:16.567] [server] server download progress: 25264122/48343944 (52%)
[08:28:16.782] [server] server download progress: 27369466/48343944 (57%)
[08:28:17.035] [server] server download progress: 29474809/48343944 (61%)
[08:28:17.260] [server] server download progress: 31580153/48343944 (65%)
[08:28:17.471] [server] server download progress: 33685496/48343944 (70%)
[08:28:17.711] [server] server download progress: 35790840/48343944 (74%)
[08:28:17.957] [server] server download progress: 37896183/48343944 (78%)
[08:28:18.197] [server] server download progress: 40001527/48343944 (83%)
[08:28:18.453] [server] server download progress: 42106870/48343944 (87%)
[08:28:18.680] [server] server download progress: 44212214/48343944 (91%)
[08:28:18.932] [server] server download progress: 46317557/48343944 (96%)
[08:28:19.678] [server] server download progress: 48343944/48343944 (100%)
[08:28:19.687] [server] Error installing server: error reading entry file: invalid gzip header
[08:28:19.689] [server] Checking C:\Users\jheyulio\.vscode-server\cli\servers\Stable-f1e16e1e6214d7c44d078b1f0607b2388f29d729\log.txt and C:\Users\jheyulio\.vscode-server\cli\servers\Stable-f1e16e1e6214d7c44d078b1f0607b2388f29d729\pid.txt for a running server...
[08:28:19.832] [server] Installing and setting up Visual Studio Code Server...
[08:29:02.139] [server] Downloading Visual Studio Code server -> C:\Users\jheyulio\AppData\Local\Temp\.tmp9ZPP86\stable
[08:29:02.141] [server] server download progress: 0/48343944 (0%)
[08:29:02.367] [server] server download progress: 2105339/48343944 (4%)
[08:29:02.612] [server] server download progress: 4210682/48343944 (9%)
[08:29:02.840] [server] server download progress: 6316026/48343944 (13%)
[08:29:03.074] [server] server download progress: 8421369/48343944 (17%)
[08:29:03.309] [server] server download progress: 10526713/48343944 (22%)
[08:29:03.532] [server] server download progress: 12632056/48343944 (26%)
[08:29:03.845] [server] server download progress: 14737400/48343944 (30%)
[08:29:04.123] [server] server download progress: 16842743/48343944 (35%)
[08:29:04.358] [server] server download progress: 18948087/48343944 (39%)
[08:29:04.586] [server] server download progress: 21053430/48343944 (44%)
[08:29:04.829] [server] server download progress: 23158774/48343944 (48%)
[08:29:05.064] [server] server download progress: 25264117/48343944 (52%)
[08:29:05.324] [server] server download progress: 27369461/48343944 (57%)
[08:29:05.582] [server] server download progress: 29474804/48343944 (61%)
[08:29:05.866] [server] server download progress: 31580148/48343944 (65%)
[08:29:06.137] [server] server download progress: 33685491/48343944 (70%)
[08:29:06.393] [server] server download progress: 35790835/48343944 (74%)
[08:29:06.661] [server] server download progress: 37896178/48343944 (78%)
[08:29:06.974] [server] server download progress: 40001522/48343944 (83%)
[08:29:07.280] [server] server download progress: 42106865/48343944 (87%)
[08:29:07.581] [server] server download progress: 44212209/48343944 (91%)
[08:29:07.861] [server] server download progress: 46317552/48343944 (96%)
[08:29:08.629] [server] server download progress: 48343944/48343944 (100%)
[08:29:08.634] [server] Error installing server: error reading entry file: invalid gzip header
[08:29:08.635] [server] Checking C:\Users\jheyulio\.vscode-server\cli\servers\Stable-f1e16e1e6214d7c44d078b1f0607b2388f29d729\log.txt and C:\Users\jheyulio\.vscode-server\cli\servers\Stable-f1e16e1e6214d7c44d078b1f0607b2388f29d729\pid.txt for a running server...
[08:29:08.671] ------

[08:29:08.671] SSH Resolver called for "ssh-remote+jheyulio-desk1", attempt 2, (Reconnection)
[08:29:08.674] SSH Resolver called for host: jheyulio-desk1
[08:29:08.675] Setting up SSH remote "jheyulio-desk1"
[08:29:08.679] Using commit id "f1e16e1e6214d7c44d078b1f0607b2388f29d729" and quality "stable" for server
[08:29:08.684] Install and start server if needed
[08:29:08.691] Remote command length: 4962/8192 characters
[08:29:08.691] Running script with connection command: "C:\windows\System32\OpenSSH\ssh.exe" -T -D 63215 "jheyulio-desk1" powershell
[08:29:08.696] Terminal shell path: C:\windows\System32\cmd.exe
[08:29:08.777] [server] Installing and setting up Visual Studio Code Server...
[08:29:10.130] > Windows PowerShell
> Copyright (C) Microsoft Corporation.   My local machine is a MacBook m1 and the remote machine is a m3. Similar log with the above. I'm using the stable version of vscode.

Looks like this was caused by some CDN change that no longer returns the filename correctly in the response, so we treat it as a tarball instead of a .zip

I get this issue too. My local machine is a MacBook m1 and the remote machine is a m3. Similar log with the above. I'm using the stable version of vscode 1.92.0.

Your issue would not be related to this one

Oh, I forgot that macOS bits are also distributed in a zip rather than .tar.gz like they are on Linux, so yes your issue may be the same, sorry for the confusion

Verified with Rob


Fix package name escaping in UserService

Description
This pull request addresses the issue described in #3262 by adding support for the PackageName escaping in the go-github library.
Changes Made
Updated the UserService.GetPackage method to escape package names consistently using url.PathEscape, aligning it with the OrganizationsService.GetPackage.
This change ensures consistent handling of package names across the API, improving overall reliability and usability.

okay

Hi @gmlewis ! Today I advanced the tests, maybe I won't be able to finish them today since I have some errors. I'll fix them tomorrow, is that okay with you?

I'll fix them tomorrow, is that okay with you?

Of course. No rush, no pressure. We appreciate your contributions whenever you are able.

I just realized that in the users test url here has the same URL as here
In addition to that, the two urls are from orgs, in users it should be https://api.github.com/users/github/packages/container/hello%2Fhello_docker and not like that https://api.github.com/orgs/github/packages/container/hello%2Fhello_docker If I am wrong please correct me.

If I am wrong please correct me.

If I'm not mistaken, these are simply values (test data) and therefore it doesn't matter what they are. If you find them confusing or unexpected, feel free to update them.
I'm looking at this from my cell phone, so I might not be understanding correctly what you are attempting to point out. If this is the case, I will take a more careful look tomorrow from my desktop machine.

If I am wrong please correct me.

If I'm not mistaken, these are simply values (test data) and therefore it doesn't matter what they are. If you find them confusing or unexpected, feel free to update them.
I'm looking at this from my cell phone, so I might not be understanding correctly what you are attempting to point out. If this is the case, I will take a more careful look tomorrow from my desktop machine.

okay it seems perfect to me.

Hi, sorry I'm late, but I've been busy with school and personal projects and I'm almost done with the tests. @gmlewis

good job, @DiegoDev2

good job, @DiegoDev2

Hi, thank you very much although I haven't been able to finish it yet, I haven't had time to finish it unfortunately

good job, @DiegoDev2

Hi, thank you very much although I haven't been able to finish it yet, I haven't had time to finish it unfortunately

please, let me know if you need any help to finish the contribution :]

Hi, I am really very sorry for you. Also, after reviewing a little, I realized that the change that was being made is not necessary, should we close this? @gmlewis

the issue too? @gmlewis

the issue too? @gmlewis

Sure.  I'll close it too.

the issue too? @gmlewis

After re-reading the original issue, I'm now confused as to why you suggest that it should be closed.
Doesn't the original issue still exist?
If not, could you please comment on #3262 why you think it is not an issue, @DiegoDev2 ?


Bug: MentionsPlugin click interactions fail to insert correct mention

Live on the playground, if you trigger the mentions typeahead and then select an option with your mouse, you'll find that the first option is selected instead of your choice. You'll also notice two hover/focus highlights happening, even though you've used your mouse to hover on a specific option.

^^ I clicked Admiral Dodd Rancit here

^^ And Aayla Secura was inserted
Lexical version: 0.2.9
Steps To Reproduce

Type @a in the playground
Use your mouse to hover on any option except the first
Click on that option
See first option inserted instead of your choice

Link to code example:
The problem is here
https://github.com/facebook/lexical/blob/main/packages/lexical-playground/src/plugins/MentionsPlugin.tsx#L786
There is both an isSelected and isHovered state. isSelected determines which item gets inserted, but it isn't set onMouseEnter. I think this differentiation is unnecessary, and there could just be one focused state. This gets rid of multiple highlights and this bug.
I have a branch locally with this fixed but don't have push writes to get a PR up for review. Happy to push up if helpful!

I have a branch locally with this fixed but don't have push writes to get a PR up for review. Happy to push up if helpful!

Thanks for reporting! Would love to have a look a the PR. The contribution workflow is typically to create a fork of lexical, then create a pull request from that fork into the main repo. If you're up for doing that, I'd be happy to take a look at the PR.
https://www.atlassian.com/git/tutorials/comparing-workflows/forking-workflow

Thanks for reporting! Would love to have a look a the PR.

@acywatson Sounds good! PR ready for you here: https://github.com/facebook/lexical/pull/2224

@dylanhusted Awesome. Thanks so much for doing this.
Closing as fixed by #2224


Lido app/marcus/lido 3287

This change breaks COUNT and COUNTIFS (due to the changed input) I will fix them shortly @tyleradams @jmorganmartin

Fix them in this PR

@tyleradams @jmorganmartin Changes are implemented :)


"cssrewrite" filter not found in Symfony 3

We use a Twig template that contains the following code:
    {% stylesheets
        'bundles/aimeosshop/themes/elegance/common.css'
        'bundles/aimeosshop/themes/elegance/aimeos.css'
        filter='cssrewrite'
    %}
        <link rel="stylesheet" href="{{ asset_url }}" />
    {% endstylesheets %}

For Symfony 3 this fails with an exception "There is no "cssrewrite" filter." while it works for Symfony 2. The assetic bundle is registered in ./app/AppKernel.php with new Symfony\Bundle\AsseticBundle\AsseticBundle().
What causes this problem?

Works as per latest sass bundle, please update or close )

On my case, I had a similar issue and the problem was the missing configuration in app/config/config.yml
assetic:
    debug:          "%kernel.debug%"
    use_controller: false
    bundles:        [ ]
    #java: /usr/bin/java
    filters:
        cssrewrite: ~
        #closure:
        #    jar: "%kernel.root_dir%/Resources/java/compiler.jar"
        #yui_css:
        #    jar: "%kernel.root_dir%/Resources/java/yuicompressor-2.4.7.jar"

Once cssrewrite is added to the list of filters, the problem is solved for me.


Improve repo

This adds more to the readme, and makes the process more clear.

Best to squash and merge instead of just merging the PR, I can do that once it's approved


New recipe and visitor to change the access level of a java method

Fixes #622

Thank you so much for all the hard work on this @murdos! I made some further edits to support more use cases, so there is only one test still disabled now on main. And we can continue working from main. This PR is merged with a series of commits on main ending with 8cb4b32af43ad7c17ef0cf40f846450173f6d3ad.
Please check it over and see if I've correctly incorporated everything you added in the past couple days.

Please check it over and see if I've correctly incorporated everything you added in the past couple days.

Thanks for polishing and having merged my work!
It seems that there are some divergences, mainly on tests, but nothing important. Your final version looks fine.


Mini project tip: get Lazy right

Summary
I spend 2 days trying to figure what is wrong only to realize my Lazy was wrong :(
Description

I am not sure who needs this, but if you are stuck on the mini-project still, you can try to take a look at the Lazy class and make sure that your map and filter class is done properly. I kept thinking that there was a problem with my InfiniteListImpl, but it was a carry forward mistake from Lazy!
Make sure that all steps in filter and map in Lazy are chained properly (and cached properly)!

Same for me as well. Just want to add on to check the get() method as well, make sure that it's getting the cached value when needed properly.

for those who dk whats going on here. You can try this test case
var a = Lazy.<Integer>of(() -> {System.out.println("a");return 1;})
var b = a.map(x -> {System.out.println("b");return x+1;})
var c = b.map(x -> {System.out.println("c");return x+1;})
a.get()
b.get()
c.get()

You should only get a,b,c each printed once.

i think you need to change to supplier but i am also not sure as i have not finished yet, i guessed it was on level 5

@callmeqimin Don't worry I managed to finish it!
@Eclipse-Dominator YES, that test case would have tested for the problem I had D: thanks for providing it ^^


Show extra "Sign In" button on Desktop

Issue

Closes #3989: [desktop] Better indication of being signed in / out on account header
Also, I often got confused in development on whether I'm using local or shared.  Having something to indicate the logged-off status would be helpful.

Notes

Retained the ["Sign In" for Desktop, "Log In" for Web] labeling.

I think #3989 is still a valid issue, but I don't think we should be make the sign in button more prominent in the desktop app. Generally we should be making the links/buttons to centralized features less noticeable on desktop.
I'm not sure what the solution to #3989 should be


[Bug]:  [File: azure_provider.py:333]   [Module: azure_provider]         CRITICAL: It was not possible to retrieve any subscriptions, please check your permission assignments

Steps to Reproduce

Expected behavior
I expected the script or command to successfully retrieve the Azure subscriptions after configuring the permissions.
Actual Result with Screenshots or Logs

How did you install Prowler?
From pip package (pip install prowler)
Environment Resource
Pycharm (Terminal)
OS used
MacOs
Prowler version
4.2.1
Pip version
21.3.1
Context
I have followed the prowler documentation and have given both Microsoft Entra ID permissions and Subscription scope permissions. Upon running "prowler azure --sp-env-auth" I am encountering the above error.

Hi @parinitachandan, I will work on your issue.
When I test this case on similar environment than yours the error did not appear, seeing the error I could say that possibly is an Entra permission problem listing subscriptions or there is no subscription to audit in your Azure account. Only with the Directory.Read.All and Policy.Read.All application permissions should it be necessary to list the subscriptions.
To give me more information you could send me a photo with the service principal permissions (like next example) and a run of Prowler with the --log-level ERROR flag.

I await your reply, thank you for using Prowler 🚀

Hi @parinitachandan, are you still having problems with Azure scan? Let me know if the problems persist or if everything has been solved and we can close this issue. I'll keep an eye out for new messages 👍

Hi @parinitachandan I'll close this issue since we didn't receive any feedback. Please feel free to reopen it if you notice the same behaviour again. You can also let us know if everything is solved now.
Thanks for using Prowler 🚀


PartialFunction.orElse

Given a PartialFunction I'd like to be able to supply another PartialFunction to be used when the first is not defined as in scala's PartialFunction (see example in at the top of the class docs)

This issue can be solved after #2023 has been solved, because of ambiguities.
For example Map extends PartialFunction. Because Map currently extends Value, it also has get(), getOrElse() and orElse(), ... This currently leads to ambiguities.

Closed because of #2176.
PartialFunction will be moved to io.vavr.match and only used for that purpose.


Update BlockStatementTemplateGenerator to handle lambda bodies which are instances of J.Block  (fixes #2181)

Update BlockStatementTemplateGenerator to handle lambda bodies which are instances of J.Block (fixes #2181)

Hm looks like a couple tests failed. Peculiarly only on Java 8.
https://ge.openrewrite.org/s/hkad4abtbadtm/tests/overview?outcome=failed

Java 8 is much more sensitive than its successor versions... I've not infrequently been surprised that it fails to handle something later versions can accommodate


Updated german translation

How do you change the default language? I just saw that in my app some is German and some is English - however I would like to have full English. Couldn't find that in the settings...

@Fuzzyma #82

Thanks!


QUIC: Add HTTP/3 demo using nghttp3

Fixes https://github.com/openssl/project/issues/41

Wow @hlandau, great work!

Added some more comments.

All the usual project copyright headers need to go around these files too ... you can be sure this code will end up copied into various applications in the short term so are those prefixes reasonable? H3_ seems unwise - perhaps OSSL_DEMO_H3? We don't want to unnecessarily make the forward path harder here.
A direct link to https://github.com/ngtcp2/nghttp3 should be included.

@t-j-h Updated

Updated. The lsquic issue is fixed, turns out we weren't sending SNI. Their error returned ("internal error") is suboptimal but so be it.

This pull request is ready to merge


After update Local notifications.schedule not a function

Here's my stack trace
com.tns.NativeScriptException:
Calling js method call failed
TypeError: LocalNotifications.schedule is not a function
File: "file:///data/data/com.malachat.aio/files/app/connection.js, line: 84, column: 22
StackTrace:
   Frame: function:'', file:'file:///data/data/com.malachat.aio/files/app/connection.js', line: 84, column: 23
   Frame: function:'listener', file:'file:///data/data/com.malachat.aio/files/app/tns_modules/nativescript-socket.io/socketio.js', line: 84, column: 22

   at com.tns.Runtime.callJSMethodNative(Native Method)
   at com.tns.Runtime.access$2300(Runtime.java:34)
   at com.tns.Runtime$3.run(Runtime.java:1136)
   at android.os.Handler.handleCallback(Handler.java:751)
   at android.os.Handler.dispatchMessage(Handler.java:95)
   at android.os.Looper.loop(Looper.java:154)
   at android.app.ActivityThread.main(ActivityThread.java:6236)
   at java.lang.reflect.Method.invoke(Native Method)
   at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:891)
   at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:781)

Before everything worked without a problem now on ver:3.1.0 below my code
LocalNotifications.schedule([{
       id: id+1,
        title: 'MalaChat',
        body: msg,
        ticker: 'New Message ',
        color:  '',
        badge: 1,
        groupedMessages:[msg], //android only
        groupSummary:"Summary of the grouped messages above", //android only
        ongoing: false, // makes the notification ongoing (Android only)
        icon: 'res://heart',
        image: "https://cdn-images-1.medium.com/max/1200/1*c3cQvYJrVezv_Az0CoDcbA.jpeg",
        thumbnail: true,
       // interval: 'minute',
        channel: 'My Channel', // default: 'Channel'
        sound: "customsound-ios.wav", // falls back to the default sound on Android
        at: new Date(new Date().getTime()) // 10 miliseconds from now
     }]).then(
         function() {
           console.log("Notification scheduled on main Thread!");
         },
         function(error) {
           console.log("scheduling error: " + error);
         }
     )
});

What did you update? The plugin or NativeScript? In either case, have you tried removing the platforms folder?
Please share a repo for further assistance.

Hi Eddy I'll try that, I updated the plugin first,then {N} last week to v5
, during upgrade to v5 it removed the projects platform but still no luck
I'll try manually removing and re-adding
On Tue., 25 Dec. 2018, 15:35 Eddy Verbruggen<EMAIL_ADDRESS>wrote:

What did you update? The plugin or NativeScript? In either case, have you
tried removing the platforms folder?
Please share a repo for further assistance.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/EddyVerbruggen/nativescript-local-notifications/issues/129#issuecomment-449851004,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATfQSQ144ELUk4sWdmLR598i9-NxxDhJks5u8impgaJpZM4ZhE-P
.


Unclear how script discovers quic versions

Since my server for example uses quic, too, its used versions are not recognized by this tool.
Already tried to adjust the alternative services header to be like the one from google, still doesn't work.
This tool sends a dummy packet so the quic server should respond with its offered negotiationable versions, is r.g. the caddy web server able to respond to such a request ?
Thanks!

Don't know how I missed this issue, sorry!
Indeed, Google has changed something with their latest QUIC version and the tool won't work anymore :/
Yes it would simply send a dummy packet with some invalid version and expect version negotiation packet which would contain all versions supported by the server side.
Another person has contacted me about these changes and maybe we'll come up with the solution shortly. Stay tuned :)

See https://quicwg.org/base-drafts/draft-ietf-quic-transport.html#rfc.appendix.B.4
'''Initial packets from clients need to be padded to 1200 unless a Handshake packet is sent as well (#2522, #2523)


Question: example on skip-days-from for off hours

I am not fully understanding how to specify skip-days-from, for public holidays.
Which format of the CSV or JSON file on S3 should I have? I have read the the docs for value_from but I am still confused.
My example list:
2017-12-27,2018-01-01,2018-03-30,2018-04-01,2018-04-25,2018-05-01,2018-05-31,2018-06-10,2018-08-15,2018-10-05,2018-11-01,2018-12-01,2018-12-08,2018-12-25,2019-01-01,2019-04-19,2019-04-21,2019-04-25,2019-05-01,2019-06-20,2019-06-10,2019-08-15,2019-10-05,2019-11-01,2019-12-01,2019-12-08,2019-12-25
Is it possible to give me an example on each type (JSON, CSV, csv2dict) so I can implement this feature? I am looking into reading these values from HR db, and generating that file.
Thanks

hopefully this helps re format, nutshell its configurable per format, via the expression usage. http://www.capitalone.io/cloud-custodian/docs/generated/c7n.html?highlight=values_from#c7n.resolver.ValuesFrom


Concurrent Downloading when upgrading

Provide a detailed description of the proposed feature
When you do brew upgrade instead of it downloading each thing individually, it downloads them all concurrently to try and speed up the upgrading process.
What is the motivation for the feature?
It takes quite a long time to upgrade when you're waiting for 22 downloads to happen.
How will the feature be relevant to at least 90% of Homebrew users?
They won't need to wait as long for their software to be upgraded.
What alternatives to the feature have been considered?
none

Asked and rejected before: https://github.com/Homebrew/brew/issues/13064

This would multiply Homebrew's bandwidth usage by the average number of concurrent downloads allowed, which wouldn't be great for GitHub's servers, so this isn't something we're interested in implementing for everyone in brew. Sorry!

Sad but understandable

Note that brew supports writing your own external commands, so you could probably write a brew parallel-fetch command if you really wanted to.
It's just not something we want to make readily available to all our users to avoid slamming GitHub's servers.


feat(validation): adding credible set variant validation

Business logic + testing for flagging study loci if any tagging variant is not in the variant index. This logic assumes the lead variant is always in the locus object.

I think it is safe to assume that locus will not be empty at any time

@project-defiant , even if the locus is empty, we are exploding it, so those study loci will be dropped from joining with the variant index.... Could have added a test for that.


⚡ Feature Request for auto-import libraries from outside current working folder (e.g. from python poetry environment)

When developing with python, I am using several different repositories inside my workspace, which are all part of a bigger project. I am using poetry to manage the dependencies between repositories.
When I try to use the auto-import feature (Ctrl+.) VSCode is unable to find imports from outside the current repository.
I would like to request support for imports which are part of the current working environment even if they are located outside the current working repository, something like pycharm does.

this looks like a dup of https://github.com/microsoft/pylance-release/discussions/2614
it sounds like you are working with multiple repos that has dependency each other. people usually use multi workspace set up for it and each repo become a root of the workspaces.
if it is the same case, please upvote the discussion. if not, please, reopen this issue.


update editorconfig, enforce via CI

This PR enables more options in the editorconfig file:

end of line = LF (unix)
insert final newline = true
trim trailing whitespace = true
charset = utf-8

I have not reformatted any existing files. The changes will be slowly applied by people editing the files with editors that support editorconfig.
Also there is no check (via editorconfig-checker) in the CI right now.

The CI failure is intermittent and not related to the PR.

Should probably add a check in CI.

Should probably add a check in CI.

I didn't want to add a check in the CI, because then I would need to fix all the files now creating a large changeset containing only whitespace changes touching lot of files.
If this is preferred, let me know and I'll update the PR, I just thought this approach was better:

The changes will be slowly applied by people editing the files with editors that support editorconfig.

I think it's better if we just apply all the fixes now, and add the check in CI, so that this stuff is enforced. Basically only gonna merge style enforcement prs.

I don't want to enforce 'insert final newline'

I pushed the requested changes into the repo.
The CI didn't run, because I assume it doesn't run when a contributor touches the github workflow file, so I couldn't have this tested in the github CI.

I don't want to enforce 'insert final newline'

Globally or for some specific files?

Updated the PR to not enforce newlines at end of files

Changes made in tinygrad/:
------------------------------------------------------------
files                             insertions       deletions
------------------------------------------------------------
tinygrad/runtime/ops_metal.py              1               1
------------------------------------------------------------
lines added in the tinygrad folder: 0


new colors

Summary by Sourcery
Introduce new color codes for 'black' and 'cyan' to enhance the color options available in the application.
New Features:

Add new color codes for 'black' and 'cyan' to the color dictionary in src/art.py.

Introduce new color codes for 'black' and 'cyan' to enhance the color options available in the application.
New Features:
Add new color codes for 'black' and 'cyan' to the color dictionary in src/art.py.

Hey @mrmcgrain, looks great! Can you add these new colors to help.txt? I'll merge your PR after that is done :+1:

Just updated the help.txt, Thank you for my first contribution experience..
While I did not do much, the process was very informative.
On Fri, Aug 2, 2024 at 9:03 AM Ryan Frederich @.***>
wrote:

Hey @mrmcgrain https://github.com/mrmcgrain, looks great! Can you add
these new colors to help.txt
https://github.com/ryansurf/cli-surf/blob/main/help.txt? I'll merge
your PR after that is done 👍
—
Reply to this email directly, view it on GitHub
https://github.com/ryansurf/cli-surf/pull/78#issuecomment-2265710610,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BESPBXGDWT4FQYSD7LVOLSLZPOUV3AVCNFSM6AAAAABL3QPQNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRVG4YTANRRGA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@mrmcgrain thank you for your contribution. So, another opportunity to learn just came up 😄
The linter failed! It looks like there's some trailing whitespace in the updated code. You can run make lint and make format to fix these (the formatter will automatically fix it for you).
Let me know if that works

appears I do not have make on my windows machine...lol, looking into that
now
On Fri, Aug 2, 2024 at 9:43 AM Ryan Frederich @.***>
wrote:

@mrmcgrain https://github.com/mrmcgrain thank you for your
contribution. So, another opportunity to learn just came up 😄
The linter failed
https://github.com/ryansurf/cli-surf/actions/runs/10218906115/job/28276136133?pr=78!
It looks like there's some trailing whitespace in the updated code. You can
run make lint and make format to fix these (the formatter will
automatically fix it for you).
Let me know if that works
—
Reply to this email directly, view it on GitHub
https://github.com/ryansurf/cli-surf/pull/78#issuecomment-2265774348,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BESPBXBRJ7WZRPGZY3A5SSLZPOZKJAVCNFSM6AAAAABL3QPQNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRVG43TIMZUHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@mrmcgrain whoops, well you shouldn't need it. Checkout the  makefile and run the commands under lint & format


Update guava to 32.1.2-jre

About this PR
📦 Updates com.google.guava:guava from 31.1-jre to 32.1.2-jre
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.google.guava", artifactId = "guava" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.google.guava", artifactId = "guava" }
}]

labels: library-update, commit-count:1

Superseded by #195.


Cxeb68d52e-5509: Vulnerable issue in commons-codec

Is there an existing issue for this?

[X] I have searched the existing issues

Are you using the latest version of MockBukkit?

[X] I am using the latest version of MockBukkit.

Minecraft Version
1.19
Describe the bug
Info: I'm using MC 1.20, but this is not available in the list! (Maybe 1.2 is a typo?)
The version 1.7.3 of dependency org.apache.maven.resolver:maven-resolver-transport-http has an security issue, because it uses an old version of commons-codec. In version 1.9.15 the issue is fixed.
Please check https://devhub.checkmarx.com/cve-details/Cxeb68d52e-5509/
Reproducible Test
No test, issue in dependency. See description for more information.
Anything else?
No response

This is an upstream issue. We can't bump it without possibly breaking compatibility. Please raise this issue with the Spigot or Paper team instead.


[Feature Request] Remove marks when all lines are visible

Is your feature request related to a problem? Please describe.
I know there is "hide_if_all_visible" option but it doesn't remove the marks. I have Gitsigns on the left and scrollbar on the right does the same thing. It just feels redundant to me.
Describe the solution you'd like
I want a "hide_if_all_visible" option for all marks.
Describe alternatives you've considered
Maybe an individual "hide_if_all_visible" option for each mark that overrides the all marks option.
Additional context
It is weird to have no scrollbar but the marks are still there. (At least to me)

btw ScrollbarHide hides both the scrollbar and marks so in theory, I could write an auto command but I'm too lazy. Thanks again

I just realised #10 is very similar to this thread

thanks! that is quick


rf-send used but not defined

rf-send is used in the forth code in several places but it is not defined. I hit the one in flib/any/varint.fs. A quick fix might be to change it to rf69-send, but that ties it to the rfm69 radio, which isn't great either.
1608-forth> egrep -r rf-send
prc/d:: t69try ( n - ) 16 rf69-power  0 <# #s #> 0 rf-send ;
oxs/l:  v> 0 rf-send ;
oxs/d-other:: t69try ( n - ) 16 rf69-power  0 <# #s #> 0 rf-send ;
flib/any/varint.fs:  v> 0 rf-send ;
rnw/d:: t69try ( n - ) 16 rf69-power  0 <# #s #> 0 rf-send ;

Would it make sense to change rf69- back to rf- wholesale? That would allow whichever radio code is included to work, as opposed to having different names for the same words in the various radios. It's not like we expect to have multiple radios of different types on the same node, right? (And if we did something else would probably be needed anyway.)

Yeah, bit awkward - did I miss a few renames? I guess so.
There might well be a need for two radios when setting up some sort of relay, but there's no problem defining one, using it, and then defining the other (and ignoring the "redefined" warning). I agree that a full rename to drop the 69 is probably nicer in 99% of the use cases.
Ok, I'll do it (also need to adjust the weblog post - no big deal).

Should be fixed in all flib/ files now.