Changing OperatorChebyshevSmoother to pass-by-reference [op-by-ref-dev]

The reason for this change in two-fold. First, all other classes declared in solvers.hpp use pass-by-reference for their operators so OperatorChebyshevSmoother may cause confusion. Second, this class will abort if the operator is NULL so pass-by-reference will ensure that a valid operator object has been passed.
Note: this PR includes deprecation warnings on the original constructors, however, these don't seem to work. I'm not sure why...

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#2370
@mlstowell
@tzanio
@pazner + @barker29
06/30/21
⌛due 07/14/21
⌛due 07/21/21

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch.

Looks great, except I find this a bit concerning:

Note: this PR includes deprecation warnings on the original constructors, however, these don't seem to work. I'm not sure why...

Yes, I do as well. These constructors are used in ex26, ex26p,  and a dedicated unit test (also in the ceed subdir). In each case, except ceed, an OperatorHandle object is used. I was initially concerned that this class might have a copy constructor which was avoiding the use of the deprecated OperatorChebyshevSmoother constructor. I was able to confirm that this was not the case and the deprecated constructor was indeed being called even though no warning was being displayed.
It may just be an issue with my compiler (clang 11.0.0 on Mac OS 10.14.6). I should try the same tests on an LC linux machine and see what happens.

Looks great, except I find this a bit concerning:

Note: this PR includes deprecation warnings on the original constructors, however, these don't seem to work. I'm not sure why...

Yes, I do as well. These constructors are used in ex26, ex26p, and a dedicated unit test (also in the ceed subdir). In each case, except ceed, an OperatorHandle object is used. I was initially concerned that this class might have a copy constructor which was avoiding the use of the deprecated OperatorChebyshevSmoother constructor. I was able to confirm that this was not the case and the deprecated constructor was indeed being called even though no warning was being displayed.
It may just be an issue with my compiler (clang 11.0.0 on Mac OS 10.14.6). I should try the same tests on an LC linux machine and see what happens.

The new deprecation warning does work on borax using gcc. Perhaps its an Apple specific issue...

The new deprecation warning does work on borax using gcc. Perhaps its an Apple specific issue...

Good to know.
I would suggest changing the pointer versions of the constructors to simply call the reference versions to avoid code duplication.

This looks fine to me.

thanks Andrew!

thanks @dridzal !

The new deprecation warning does work on borax using gcc. Perhaps its an Apple specific issue...

Good to know.
I would suggest changing the pointer versions of the constructors to simply call the reference versions to avoid code duplication.

To be honest I'm not sure how to do that with constructors. We could move the member data initializations into an Init member function and the power method initialization into another member function and call each of these as appropriate. Frankly this seems like a bit much if we're just going to remove the deprecated constructors in a forthcoming version.

To be honest I'm not sure how to do that with constructors. We could move the member data initializations into an Init member function and the power method initialization into another member function and call each of these as appropriate. Frankly this seems like a bit much if we're just going to remove the deprecated constructors in a forthcoming version.

I just pushed a change that calls the reference constructors from the pointer constructors. Let me know if it looks good to you.

To be honest I'm not sure how to do that with constructors. We could move the member data initializations into an Init member function and the power method initialization into another member function and call each of these as appropriate. Frankly this seems like a bit much if we're just going to remove the deprecated constructors in a forthcoming version.

I just pushed a change that calls the reference constructors from the pointer constructors. Let me know if it looks good to you.

Thanks, @pazner! For some reason I never realized that would work. I do like this change. Thanks again.

Merged in next for testing...


Select Prototyping Interfaces

Select a way to interconnect sensors and micro-controllers for the development cycle.

Mikroe bus/click interface decided on for prototyping.


autodoc-ker: Repo for us to share OSS Autodoc indexes.

I threw something together to help share indexes with the team (for OSS repos that we don't maintain). I was wondering if you'd be interested in letting me park this in your org?
https://github.com/dahifi/autodoc-ker

Hey this is a great idea! We'd love to host this. I think it should be fairly straightforward for you to transfer ownership.
Super cool that you did the twitter ml algo, I literally just indexed it myself 5 minutes ago :)
Let me know if you need any help!

Invite sent for collaboration.


Add support for ListOfObjects and MapOfObjects outputs from terraform.

I needed support for a more complex output structure than only Lists or only Maps. So I added an output function for lists of maps. I believe this could close https://github.com/gruntwork-io/terratest/issues/300 but am not sure what the requirements were for that issue.
I read the instructions at https://terratest.gruntwork.io/docs/community/contributing/ but couldn't find information on running the tests so here are the outputs from the test cases I created:
https://gist.github.com/deberon/4e32f0bea2a26c5be66d4fc47a479bad

I modeled this function after OutputMap and OutputList which both return strings. Taking some time to think about things, I could write 2 new functions along the lines of OutputListOfObjects and OutputMapOfObjects.
OutputMapOfObjects would be mostly similar to OutputMap but with interface objects instead.
OutputListOfObjects would be my new OutputListOfMaps function but with the type changes you suggested.
Does this sound good? I apologize if my naming isn't appropriate, but I'm not really sure if we should refer to them as the golang types or the terraform types.

That sounds good, thanks!

@brikis98 I made those proposed changes. The implementation I went with even supports recursive objects, which I also built rudimentary tests for.

@brikis98 I pushed a new commit with support for floats and bools as well. Thanks!

@brikis98 sorry for the lengthy PR, but I have submitted the changes you suggested.

@brikis98 I added commits addressing your most recent comments. Thanks!

@brikis98 would it be better to work with the output as JSON values? that is actually what the output is afterall.

would it be better to work with the output as JSON values? that is actually what the output is afterall.

What do you mean?

@brikis98 I am new to Go, so pardon my ignorance, but it seems like it would be better for terratest to just unmarshall the terraform output into a struct which can then be asserted upon

Ah, so  you mean an API like:
func OutputStruct(t *testing.T, options *Options, key string, out interface{})

Where out would be a pointer. So the usage of it would be something like:
type Example struct {
  foo string
  bar int
}

var example Example
terraform.OutputStruct(t *testing.T, options, "example", &example)

If so, I think that makes sense for more complicated use cases, and would certainly welcome a separate PR to add that! That said, supporting maps and lists better out of the box, as in this PR, is useful too.

yes, exactly like that @brikis98 -- I can open up a separate feature request issue for that.

Thanks!
@deberon What's the latest with this PR? Are you waiting on a review from me?

@brikis98 I am not actually sure. I think I need that approval.

@deberon OK, took one more pass. There's just one issue left, and I can kick off tests. Thanks!

@brikis98 I made your requested changes

OK, all tests passed, except one, which has a known issue that causes an intermittent failure. I'm going to merge this now, thanks!

https://github.com/gruntwork-io/terratest/releases/tag/v0.28.2


Add support for routing by handle

In order to support retrieving DSpace objects by handles, we'll add support for any kind of external identifier in one go:

Create an IdentifierType enum containing the supported identifiers

This is likely temporary, as eventually this list will come from rest as well, but if we need to replace it later, it's good to use an enum now, instead of strings everywhere.
only add UUID =  'uuid' and HANDLE = 'handle' for now

Create an index that maps identifiers to self links

Remove the IndexName enum. Since the available indices will depend on the available identifier we can no longer enumerate them. Instead

replace REQUEST by a constant
replace OBJECT by a getIdentifierIndexName(idType: IdentifierType): string method, that returns object/id-to-self-link/${idType}
remember to update all the places that use the old IndexName values

Modify the IndexEffects, to update all ID indices instead of only the UUID index, every time an object is added to the cache

Rename it to IdentifierIndexEffects

In ObjectCacheService replace hasByUUID and getByUUID by hasByID and getByID methods that take the IdentifierType as an optional parameter, if it isn't specified, use UUID
In DataService, do the same for findById()

If the identifier is UUID, keep using the current endpoints
Otherwise, use the new Rest Endpoint.
Take in to account that creating the REST endpoint is a Sprint task as well, so if it doesn't exist yet, you won't be able to test this actual call.
But due to the cache, this findBy method will still return objects that have been retrieved in another way and indexed in the id index.

Create a DSODataService that does nothing but extend Dataservice<NormalizedDspaceObject, DSpaceObject>
modify RequestService.isCachedOrPending() to check by other identifiers as well to determine if something is cached.

currently it only checks the objectCache by selfLink, but if the request has a property associated with another configured identifier (e.g. request[IdentifierType.HANDLE]) it should also check hasByID for that IdentifierType.

configure identifier based routes, that redirect to the DSOType based route

routes should be /id/${idType}/${id}

these are under /id to prevent accidental clashes with other routes added by dspace or modules built on top of dspace later

Also add /handle/${handle} for backwards compatibility. It should do the same thing as /id/handle/${handle}
Use DSODataService.findById() to retrieve the object from the api and then redirect to ${object.type}/${object.id}
Because it is already cached it should not be fetched again when that route is loaded.

Makes sense. I updated the description

Here's a PR that supports routing by handle and uuid by implementing the changes outlined in this issue.  https://github.com/DSpace/dspace-angular/pull/490

@artlowel & @mspalti : Should this ticket now be closed since #490 was merged?

Yes it should


File listing order in source control

VSCode Version: Version 1.22.2 (1.22.2)
OS Version: mac 10.13.4

There is a difference in the way the files are sorted in the explorer vs source control.
While explorer is respecting the ordering by string, (1... 10) source control is mixed up ( 1,11,13,2,)

/duplicate #14582


Expose a public unsafe API to spawn threads with unrestricted lifetime bounds

Currently, the only way to spawn a thread is with 'static lifetime bounds on the closure and its return type. This makes sense for regular threads with an indeterminate lifetime. However, the std::thread module could also expose an explicitly unsafe way for spawning threads, with function signatures like the following:
//in std::thread

impl Builder {
    pub unsafe fn spawn_unchecked<F, T>(self, f: F) -> io::Result<JoinHandle<T>>
    where
        F: FnOnce() -> T,
        F: Send + 'a,
        T: Send + 'a {...}
}

and (for the free-standing version)
//in std::thread

pub unsafe fn spawn_unchecked<F, T>(self, f: F) -> io::Result<JoinHandle<T>>
where
       F: FnOnce() -> T,
       F: Send + 'a,
       T: Send + 'a {...}

Since the implementation of of Builder::spawn relies on unsafe code itself and the std::sys::thread types/functions don't require 'static lifetime bounds (haven't checked for all), this should be comparatively easy to implement by refactoring the spawn implementation into spawn_unchecked and calling that function with 'static lifetime bounds for the safe API.
The benefits would mainly be:

users could use the unsafe API to spawn "scoped" threads without resorting to external crates if they so desire (adding the responsibility to ensure manual joining of course)
safe and general implementations for actual scope threads could be simplified and made (slightly) more efficient

Currently, scoped thread implementations have to use a lot of tricks with their return types and lifetime transmuting to get to work. Results have to be separately allocated and internally set instead of using the std::thread::JoinHandle type, which would be much more fitting if not for the lifetime bounds on the spawn functions.
To summarize, scoped threads could be implemented more safely and with fewer allocations.

I'm not sure I understand the motivation for this: why wouldn't callers just unsafely cast F to a type with a static bound and then call the existing spawn function?

I think something like crossbeam's scoped threads is a better solution.

Closing in favor of https://github.com/rust-lang/rust/pull/55043.


Issue 136

Sample for issue 136: https://github.com/Readify/Neo4jClient/issues/136
Please run console app and see output result. ReadJson method from custom converter not used.

Hullo!
Thank you for this, I'm not going to pull it into the codebase, as I've fixed it in a different branch, you should be able to get version <IP_ADDRESS> to have this fixed for you!


Use blueprintjs Radio in RadioGroup

closes : https://github.com/zakodium-oss/react-science/issues/662

Codecov Report
Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (48ae20c) 22.86% compared to head (4cf974f) 22.24%.
Report is 4 commits behind head on main.

Files
Patch %
Lines

stories/components/radio.stories.tsx
0.00%
28 Missing and 1 partial :warning:

stories/components/form.stories.tsx
0.00%
13 Missing :warning:

src/components/forms/radio-group/RadioGroup.tsx
0.00%
3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #664      +/-   ##
==========================================
- Coverage   22.86%   22.24%   -0.63%
==========================================
  Files         221      220       -1
  Lines       13080    13081       +1
  Branches      235      236       +1
==========================================
- Hits         2991     2910      -81
- Misses      10000    10081      +81
- Partials       89       90       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


docs(newsletter): clean up formatting and verbiage of existing documentation

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/develop/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: N/A
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

@griest024 there seemed to be some duplicating information so I tried my best to clean it up and remove what I thought was redundant information. Can you review and make sure I didn't remove important information?


Adding Kubernetes artifacts

Heyho together!
I am currently finalizing my master thesis about Kubernetes Forensics where one objection is the identification and description of forensic artifacts related to Kubernetes.
To identify them, I have used a method of automated differential analysis between two states, mainly working with Pod resources. That allows to trace changes on a nodes file system level so that characteristic file changes can be identified and analyzed.
To bring my results into a usable and understandable format I have chosen to follow your formatting guidelines so that the results can get contributed to the repo.
I hope that I understood the guidelines correctly and did not mess up completely ... :D
To mark the purpose/ type of a placeholder in paths i have decided to use the following style:
attributes: {paths: ['/var/log/pods/<namespace>_<pod_name>_<pod_id>/<container_name>/<num>.log']}
If %% signs should be used instead I can just exchange the characters.
Looking forward for your feedback! :)
Kind regards,
Christoph

I'll have a run when time permits, CI tests are currently failing on artifacts.errors.FormatError: Artifact definition: KubernetesLogs found undefined labels: Log.

Changed the docstrings to match the style guide:
'/var/log/pods/<namespace>_<pod_name>_<pod_id>/<container_name>/<num>.log'

Is not going to work, you'll need to make this a glob or add supported place holders

Ahoi again!
Sorry for my confusion here.
I've exchanged the paths now with values that match the glob pattern and added an additionaly explanation to the respective docs to explain how the path is structured.
I've also ran the run_tests.py locally and it says OK. :)
Regards,
Christoph

@pr3l14t0r thx for the proposed changes, I'll have a more detailed look later (when time is more favorable)


Can you to show example with sso?

How to use your nuget with sso?

Normally, there is an example within this repository.


Agent client implementation

The travis build fails with an  internal compiler error when compiling with go-docker and using go:tip (last golang/go commit on master). We should find a solution to correct this before merging.

This change is

Reviewed 10 of 12 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 5 unresolved discussions, some commit checks failed.

agent/agenttestcases/findsegments.go, line 34 at r2 (raw file):

func (f Factory) TestFindSegmentsTags(t *testing.T) {
	process, tag := "test", "tag"
	f.Client.CreateMap(process, nil, tag)

Add a segment without tag to check that it is not found.
This test does not reveal if find works wel

agent/agenttestcases/findsegments.go, line 34 at r2 (raw file):

func (f Factory) TestFindSegmentsTags(t *testing.T) {
	process, tag := "test", "tag"
	f.Client.CreateMap(process, nil, tag)

Why tag is not a slice?

agent/agenttestcases/findsegments.go, line 56 at r2 (raw file):

func (f Factory) TestFindSegmentsLinkHashes(t *testing.T) {
	process := "test"
	parent, _ := f.Client.CreateMap(process, nil, "test")

Same as below

agent/client/client.go, line 89 at r2 (raw file):

impelmenting
nit: typo

agent/client/client.go, line 232 at r2 (raw file):

	decoder := json.NewDecoder(resp.Body)
	seg := cs.Segment{}
	if err := decoder.Decode(&seg); err != nil {

indigo-js preloads refs segments

Comments from Reviewable

Review status: all files reviewed at latest revision, 5 unresolved discussions, some commit checks failed.

agent/agenttestcases/findsegments.go, line 34 at r2 (raw file):
Previously, alexppxela (Alexandre Thibault) wrote…
Why tag is not a slice?

Because CreateMapand CreateLink take varargs and not a list (it's the same in agent-client-js)

agent/agenttestcases/findsegments.go, line 34 at r2 (raw file):
Previously, alexppxela (Alexandre Thibault) wrote…
Add a segment without tag to check that it is not found.
This test does not reveal if find works wel

Done.

agent/agenttestcases/findsegments.go, line 56 at r2 (raw file):
Previously, alexppxela (Alexandre Thibault) wrote…
Same as below

Same as above

agent/client/client.go, line 89 at r2 (raw file):
Previously, alexppxela (Alexandre Thibault) wrote…

impelmenting
nit: typo

Done.

agent/client/client.go, line 232 at r2 (raw file):
Previously, alexppxela (Alexandre Thibault) wrote…
indigo-js preloads refs segments

this is done on the agent side

Comments from Reviewable

Impressive job! Thanks!

Review status: 9 of 13 files reviewed at latest revision, 17 unresolved discussions, some commit checks failed.

agent/agenttestcases/createlink.go, line 32 at r4 (raw file):

	ref := client.SegmentRef{Process: "other", LinkHash: testutil.RandomHash()}
	refs := make([]client.SegmentRef, 0)
	refs = append(refs, ref)

you could write refs := [1]SegmentRef{{Process: "other", LinkHash: testutil.RandomHash()}} I think

agent/agenttestcases/createlink.go, line 50 at r4 (raw file):

	ref := client.SegmentRef{Process: "wrong"}
	refs := make([]client.SegmentRef, 0)
	refs = append(refs, ref)

idem

agent/agenttestcases/createlink.go, line 80 at r4 (raw file):

func (f Factory) TestCreateLinkHandlesWrongAction(t *testing.T) {
	process, action := "test", "wrong"
	parent, err := f.Client.CreateMap(process, nil, "test")

If we don't plan on check this err it should not be declared

agent/agenttestcases/createmap.go, line 26 at r4 (raw file):

	ref := client.SegmentRef{Process: "other", LinkHash: testutil.RandomHash()}
	refs := make([]client.SegmentRef, 0)
	refs = append(refs, ref)

see above

agent/agenttestcases/createmap.go, line 43 at r4 (raw file):

	ref := client.SegmentRef{Process: "wrong"}
	refs := make([]client.SegmentRef, 0)
	refs = append(refs, ref)

idem

agent/agenttestcases/findsegments.go, line 99 at r4 (raw file):

	created := 10
	expected := 0
	for i := 0; i != created; i++ {

nit: we usually write loops with < instead of != in the codebase...

agent/agenttestcases/findsegments.go, line 123 at r4 (raw file):

	for i := 0; i != created; i++ {
		f.Client.CreateMap(process, nil, "test")
	}

I think the creation could be factorized with the previous test and we could use test fixtures.

agent/client/client.go, line 76 at r4 (raw file):

// CreateLink sends a CreateLink request to the agent and returns
// the newly created segment

nit: these comments need to end with . (looks better in godoc)

agent/client/client.go, line 77 at r4 (raw file):

// CreateLink sends a CreateLink request to the agent and returns
// the newly created segment
func (a *agentClient) CreateLink(process string, linkHash *types.Bytes32, action string, refs []SegmentRef, args ...string) (*cs.Segment, error) {

I thought we had decided to keep calling it CreateSegment?

agent/client/client.go, line 89 at r4 (raw file):

	decoder := json.NewDecoder(resp.Body)
	seg := cs.Segment{}
	// TODO: could be improved by implementing UnnmarshalJSON on cs.Segment

nit: I think it'd be better to create an Issue and remove this TODO

agent/client/client.go, line 201 at r4 (raw file):

	process := processes.FindProcess(name)
	if process == nil {
		return nil, errors.New("Not Found")

I guess this kind of strings could be constants... What do you think?

agent/client/client.go, line 269 at r4 (raw file):

			return nil, err
		}
		endpoint += "?" + queryParams.Encode()

I find it a bit odd that you have to write it like that.
I feel like you should do:
url.RawQuery = queryParams.Encode()
What do you think?

Comments from Reviewable

Review status: 9 of 13 files reviewed at latest revision, 17 unresolved discussions, some commit checks failed.

agent/agenttestcases/createlink.go, line 32 at r4 (raw file):
Previously, such (Adrien Montfort) wrote…
you could write refs := [1]SegmentRef{{Process: "other", LinkHash: testutil.RandomHash()}} I think

It works with [] instead of [1] ! thanks.
Done.

agent/agenttestcases/createlink.go, line 50 at r4 (raw file):
Previously, such (Adrien Montfort) wrote…
idem

Done.

agent/agenttestcases/createlink.go, line 80 at r4 (raw file):
Previously, such (Adrien Montfort) wrote…
If we don't plan on check this err it should not be declared

Done.

agent/agenttestcases/createmap.go, line 26 at r4 (raw file):
Previously, such (Adrien Montfort) wrote…
see above

Done.

agent/agenttestcases/createmap.go, line 43 at r4 (raw file):
Previously, such (Adrien Montfort) wrote…
idem

Done.

agent/agenttestcases/findsegments.go, line 99 at r4 (raw file):
Previously, such (Adrien Montfort) wrote…
nit: we usually write loops with < instead of != in the codebase...

Done.

agent/agenttestcases/findsegments.go, line 123 at r4 (raw file):
Previously, such (Adrien Montfort) wrote…
I think the creation could be factorized with the previous test and we could use test fixtures.

Done.

agent/client/client.go, line 76 at r4 (raw file):
Previously, such (Adrien Montfort) wrote…
nit: these comments need to end with . (looks better in godoc)

Done.

agent/client/client.go, line 77 at r4 (raw file):
Previously, such (Adrien Montfort) wrote…
I thought we had decided to keep calling it CreateSegment?

The discussion we had was about the agent's API (replace /segments by /links) but you're right, it should be consistent with the API.
Done.

agent/client/client.go, line 89 at r4 (raw file):
Previously, such (Adrien Montfort) wrote…
nit: I think it'd be better to create an Issue and remove this TODO

Agreed !
Done.

agent/client/client.go, line 201 at r4 (raw file):
Previously, such (Adrien Montfort) wrote…
I guess this kind of strings could be constants... What do you think?

Agreed, error messages are a mess right now... it's coming in the next commit

agent/client/client.go, line 269 at r4 (raw file):
Previously, such (Adrien Montfort) wrote…
I find it a bit odd that you have to write it like that.
I feel like you should do:
url.RawQuery = queryParams.Encode()
What do you think?

I wasn't aware of the usage of RawQuery, but it's way better indeed.
Done.

Comments from Reviewable

Reviewed 1 of 13 files at r1, 13 of 13 files at r5.
Review status: all files reviewed at latest revision, 5 unresolved discussions, some commit checks failed.

Comments from Reviewable

Review status: 11 of 14 files reviewed at latest revision, 6 unresolved discussions.

agent/client/client.go, line 201 at r4 (raw file):
Previously, simonvadee wrote…
Agreed, error messages are a mess right now... it's coming in the next commit

Done.

Comments from Reviewable

Reviewed 3 of 3 files at r6.
Review status: all files reviewed at latest revision, 5 unresolved discussions, some commit checks failed.

Comments from Reviewable

Reviewed 2 of 2 files at r7.
Review status: all files reviewed at latest revision, 5 unresolved discussions, some commit checks failed.

Comments from Reviewable


Fixed incorrect documentation demonstrating Modal sizes

The property affecting the size (or, rather, the width) of Modal is width, not size.

Thanks @briankc! Sometimes these things sneak through


Enable end2end tests on forked PRs

This PR enables end-to-end tests to run on forked PRs with the following triggers:

issue_comment: When a maintainer comments !test on a PR, it will trigger the end-to-end tests with full access to repo secrets. This enables the maintainer to carefully review PR comments before approving tests, without having to locally checkout and merge separately. This step is meant to give an early signal rather than be a required status check, so trivial or unrelated PRs can skip it.
merge_group: This triggers the end-to-end tests whenever a PR is added to the merge queue, which this repo doesn't currently have but is used to great effect in https://github.com/lurk-lab/lurk-rs. Requiring the tests to pass when attempting to merge ensures correctness if the above PR comment action isn't run.

Successful runs:

issue_comment: https://github.com/lurk-lab/ci-lab/pull/16 and https://github.com/lurk-lab/ci-lab/actions/runs/6701350814/job/18208641508
merge_group: https://github.com/lurk-lab/lurk-rs/actions/runs/6698173184

TODO:

[ ] Factor out end-to-end test into separate action to remove code duplication

@storojs72 The issue_comment trigger runs from the base branch, so unfortunately it's not possible to test until the action is merged to main and a new PR is opened. Please review the linked successful run carefully so we have confidence that this approach will work


Doc issue - need to revise URL for mod_schema.xsd in readthedocs "FOMOD Bible"

readthedocs "FOMOD Bible" section "revised FOMOD schema" href is invalid
Context
Can't find Issues for read the docs, please move this issue if appropriate
Process

Click on link "revised FOMOD schema" in FOMOD Bible section of Advanced

Expected result
mod_schema.xsd to open
Current result
404 from git.
Possible Fix
recent file reorg moved mod_schema.xsd from fomod-designer/fomod/designer/blob/develop/resources/ to  fomod-validator/fomod/validator/resources/mod_schema.xsd , need to update url in href.
name of issue screenshot
[if relevant, include a screenshot]

woops, will fix!


only allow for valid urls in slack button

⚠⚠⚠ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:

[X] I have read and understand the pull request rules.

Description
Fixes #5309
Type of change
Please delete any options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

Checklist

[X] My code follows the style guidelines of this project
[X] I ran ESLint and other linters for modified files
[X] I have performed a self-review of my own code and tested it
[ ] I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
[X] My changes generates no new warnings
[ ] My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

Thanks, looks reasonable 👍


webapp remote-connection create and webapp create-remote-connection do not allow visual studio remote debugging connection

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Describe the bug
I am trying to connect to a webapp with the Visual Studio Remote debugger over ssh. The connection created with
webapp remote-connection create and webapp create-remote-connection does not seem to support this connection.

To Reproduce

Open a connection with
az webapp create-remote-connection --resource-group myrg --name myapp --port 22
or
az webapp remote-connection create --resource-group myrg --name myapp --port 22
Open the Visual Studio Debugger Attach to process dialog.
Select SSH and enter connection details
Connection fails with "Could not connect to the remote system, connection timeout"

Expected behavior
The debugger should connect and be able to read the / connect to process on the remote machine.
Environment summary
az --version
azure-cli                         2.22.0 *

core                              2.22.0 *
telemetry                          1.0.6

Extensions:
application-insights              0.1.13
webapp                             0.3.1

Python location 'C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\python.exe'
Extensions directory 'C:\Users\Greg\.azure\cliextensions'

Python (Windows) 3.6.8 (tags/v3.6.8:3c6b436a57, Dec 23 2018, 23:31:17) [MSC v.1916 32 bit (Intel)]

Legal docs and information: aka.ms/AzureCliLegal

Visual Studio 16.9.4
Additional context

route to appropriate team

@btardif - can you please confirm whether this should be fixed by the redesign.


Need option to disable rate control

CBR gives about 10% performance lose on RX580 in hevc mode. Need option to remove rc_mode from ffmpeg options

Already done.


fix(CX-2751): dismiss career highlights modal after adding a new artwork

Description

This PR resolves CX-2751

Dismiss career highlights modal after adding a new artwork

QA Testing
https://user-images.githubusercontent.com/11945712/184327290-71a987be-27db-4397-b464-d56f7ef642a5.mov

Acceptance Criteria

Setup Instructions

PR Checklist

[x] I tested my changes on iOS / Android.
[x] I added screenshots or videos to illustrate my changes.
[ ] I added Tests and Stories for my changes.
[ ] I added an [app state migration].
[ ] I hid my changes behind a [feature flag].
[ ] I have prefixed changes that need to be tested during a release QA with [NEEDS EXTERNAL QA] on the changelog.

#nochangelog

#squashongreen


Add another item to the Restrictions list

Query Store also cannot be enabled on tempdb.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 37fab3b5-a2f3-5612-06e2-01e0406a615d
Version Independent ID: 2daa00e0-8234-bf26-13c0-8d5200a1f4a5
Content: tempdb database - SQL Server
Content Source: docs/relational-databases/databases/tempdb-database.md
Product: sql
Technology: ****
GitHub Login: @WilliamDAssafMSFT
Microsoft Alias: wiassaf

@zikato -- Tom, thank you for your feedback.
@WilliamDAssafMSFT -- William, please look into this issue.

Thanks @zikato for the feedback and taking the time to open this issue. This is true, we have this fact documented properly in the Query Store overview article


Fix angle keypoints changes in VerticalFlip, HorizontalFlip, Flip, issue #394

Changed angle flipping logic. Without normalization
Issue: https://github.com/albu/albumentations/issues/394

I think we can add this PR after #426

@Arquestro can you please update your PR with respect to latest updates from master? Thanks!

@BloodAxe Done.


PMM-13533: Prepare for PMM v3 release

We are introducing a new way to upgrade PMM versions in PMM v3. This new update uses version service to list available PMM versions and the associated release notes.
Most of the changes in this PR are already on check-dev (main), and we have been testing there. However, as we prepare for the beta release of PMM 3, we need to get this to production as well.
This cherry-picks all the commits needed to get this new update mechanism to work (including #261 and #262 )

Test name
Status

api-tests
passed

Test name
Status

api-tests
passed


[ADDON]: Add Support for Kyverno

Add Support to leverage Kyverno - https://kyverno.io/     Kyverno provides a policy engine for managing policies in Kubernetes.

/assign

@vyankyGH Did you get a chance to work on this and submit a PR


Javascript check for input type

In datepicker example you are using " var type = $('').attr('type');".
Chrome v.16 always returns "date" (as well as firefox). I'm using a "modernizr" library to check for support and it works fine.. maybe you could mention that in docs ?
There's still a mess with html5 browser support.
Thanks

Wow, long wait but we finally made it. Thanks for reporting! :)


⚠ Spryr has degraded performance

In e9057f8, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 5685 ms

Resolved: Spryr performance has improved in ad6d280 after 7 minutes.


CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

JIRA Ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-10109
Description
This feature allow admins to dedicate a range of public IP addresses to the SSVM and CPVM, such that they can be subject to specific external firewall rules. The option to dedicate a public IP range to the System VMs (SSVM & CPVM) is added to the createVlanIpRange API method and the UI.
Solution
Global setting 'system.vm.public.ip.reservation.mode.strictness' is added to determine if the use of the system VM reservation is strict (when true) or preferred (false), false by default.
When a range has been dedicated to System VMs, CloudStack should apply IPs from that range to
the public interfaces of the CPVM and the SSVM depending on global setting's value:

If the global setting is set to false: then CloudStack will use any unused and unreserved public IP
addresses for system VMs only when the pool of reserved IPs has been exhausted
If the global setting is set to true: then CloudStack will fail to deploy the system VM when the pool
of reserved IPs has been exhausted, citing the lack of available IPs.

UI Changes
Under Infrastructure -> Zone -> Physical Network -> Public -> IP Ranges, button 'Account' label is refactored to 'Set reservation':

When that button is clicked, dialog displayed is also refactored, including a new checkbox 'System VMs' which indicates if range should be dedicated for CPVM and SSVM, and a note indicating its usage:

When clicking on button for any created range, UI dialog displayed indicates whether IP range is dedicated for system vms or not:

@blueorangutan package

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1158

@blueorangutan test

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@borisstoyanov @rhtyd @DaanHoogland
Guys, one issue while porting this feature to 4.11 which was not present on 4.6. In this commit: https://github.com/apache/cloudstack/commit/37301ed4540450c29be4f975d58b38dbeec6c296#diff-6adc687ad4a13d4b956fdc638299401b domain_vlan_map is introduced. When adding a new range on domain, a new entry on domain_vlan_map is created. As IpAddressManagerImpl#fetchNewPublicIp lists non dedicated zone wide vlans, but always returns range corresponding to vlan id = 1 (as there's no entry for it on domain_vlan_map) - check ZoneWideNonDedicatedVlanSearch search builder on VlanDaoImpl.
What do you think will be the best solution for this case?

looks like the deployment failed waiting for default template to install, I'll restart
@blueorangutan test

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan test

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-1589)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35319 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2295-t1589-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_iso.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 58 look OK, 4 have error(s)

Test
Result
Time (s)
Test File

test_01_vpc_remote_access_vpn
Failure
60.89
test_vpc_vpn.py

test_08_reboot_cpvm
Failure
0.03
test_ssvm.py

test_06_stop_cpvm
Failure
0.05
test_ssvm.py

test_04_cpvm_internals
Failure
0.04
test_ssvm.py

test_02_list_cpvm_vm
Failure
0.03
test_ssvm.py

test_04_rvpc_privategw_static_routes
Failure
471.52
test_privategw_acl.py

test_04_extract_Iso
Failure
5.10
test_iso.py

test_10_destroy_cpvm
Error
5.15
test_ssvm.py

test_change_service_offering_for_vm_with_snapshots
Skipped
0.00
test_vm_snapshots.py

test_09_copy_delete_template
Skipped
0.01
test_templates.py

test_06_copy_template
Skipped
0.00
test_templates.py

test_static_role_account_acls
Skipped
0.02
test_staticroles.py

test_11_ss_nfs_version_on_ssvm
Skipped
0.02
test_ssvm.py

test_01_scale_vm
Skipped
0.00
test_scale_vm.py

test_01_primary_storage_iscsi
Skipped
0.08
test_primary_storage.py

test_vm_nic_adapter_vmxnet3
Skipped
0.00
test_nic_adapter_type.py

test_nested_virtualization_vmware
Skipped
0.00
test_nested_virtualization.py

test_06_copy_iso
Skipped
0.00
test_iso.py

test_list_ha_for_host_valid
Skipped
0.01
test_hostha_simulator.py

test_list_ha_for_host_invalid
Skipped
0.01
test_hostha_simulator.py

test_list_ha_for_host
Skipped
0.02
test_hostha_simulator.py

test_hostha_enable_feature_without_setting_provider
Skipped
0.01
test_hostha_simulator.py

test_hostha_enable_feature_valid
Skipped
0.02
test_hostha_simulator.py

test_hostha_disable_feature_valid
Skipped
0.02
test_hostha_simulator.py

test_hostha_configure_invalid_provider
Skipped
0.02
test_hostha_simulator.py

test_hostha_configure_default_driver
Skipped
0.01
test_hostha_simulator.py

test_ha_verify_fsm_recovering
Skipped
0.01
test_hostha_simulator.py

test_ha_verify_fsm_fenced
Skipped
0.02
test_hostha_simulator.py

test_ha_verify_fsm_degraded
Skipped
0.02
test_hostha_simulator.py

test_ha_verify_fsm_available
Skipped
0.03
test_hostha_simulator.py

test_ha_multiple_mgmt_server_ownership
Skipped
0.02
test_hostha_simulator.py

test_ha_list_providers
Skipped
0.02
test_hostha_simulator.py

test_ha_enable_feature_invalid
Skipped
0.02
test_hostha_simulator.py

test_ha_disable_feature_invalid
Skipped
0.02
test_hostha_simulator.py

test_ha_configure_enabledisable_across_clusterzones
Skipped
0.02
test_hostha_simulator.py

test_configure_ha_provider_valid
Skipped
0.01
test_hostha_simulator.py

test_configure_ha_provider_invalid
Skipped
0.02
test_hostha_simulator.py

test_deploy_vgpu_enabled_vm
Skipped
0.03
test_deploy_vgpu_enabled_vm.py

test_3d_gpu_support
Skipped
0.04
test_deploy_vgpu_enabled_vm.py

@borisstoyanov done.
The only main concern for this community PR is fix for domain_vlan_map. @ustcweizhou could you please give your thoughts/suggestions about that fix (mentioning you as found a commit from you where domain vlan map is introduced and don't want to break your code :) ) ?

@nvazquez, Thanks for the feature. Can you please put some snaps of the UI change, Particularly the set reservation form.

@nitin-maharana thanks for your review! I'll try addressing your comments asap, thanks!

@nitin-maharana thanks for your review and comments! UI screenshots are added on PR description and refactor is made based on your comments.

@nvazquez is this ready or still in progress? can you fix conflicts? /cc @borisstoyanov

@rhtyd this is ready, I have fixed conflicts and pushed, tested again in local environment:
Test public IP range dedication ... === TestName: test_dedicatePublicIpRange | Status : SUCCESS ===
ok
Test public IP range dedication for SSVM and CPVM ... === TestName: test_dedicate_public_ip_range_for_system_vms | Status : SUCCESS ===
ok
Test CPVM Public IP ... === TestName: test_dedicate_public_ip_range_for_system_vms_cpvm | Status : SUCCESS ===
ok
Test SSVM Public IP ... === TestName: test_dedicate_public_ip_range_for_system_vms_ssvm | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 4 tests in 393.674s

OK

@nitin-maharana can you please review again so we can get your blessing on this PR?
@blueorangutan package

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1468

@blueorangutan test

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@nvazquez can you fix conflicts and re-kick test (the test failed to start at backend due to trillian deployment failure)

@rhtyd sure, thanks

@blueorangutan package

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1481

@blueorangutan test

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-1911)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38238 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2295-t1911-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_usage.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 61 look OK, 5 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_list_sec_storage_vm
Failure
0.23
test_ssvm.py

test_02_list_cpvm_vm
Failure
0.24
test_ssvm.py

test_05_stop_ssvm
Failure
69.49
test_ssvm.py

test_06_stop_cpvm
Failure
57.20
test_ssvm.py

test_04_extract_template
Failure
132.38
test_templates.py

ContextSuite context=TestISOUsage>:setup
Error
0.00
test_usage.py

test_06_download_detached_volume
Failure
147.56
test_volumes.py

test_07_resize_fail
Failure
15.47
test_volumes.py

test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL
Failure
369.23
test_vpc_redundant.py

test_05_rvpc_multi_tiers
Failure
369.04
test_vpc_redundant.py

test_05_rvpc_multi_tiers
Error
420.19
test_vpc_redundant.py

Several issues seen and also failure in Travis, can you check @nvazquez maybe re-run tests when you've time post-holidays. Thanks.


New FSharp.Formatting uses latest FCS

so they version conflict should be solved.

Please remove https://github.com/fsprojects/VisualFSharpPowerTools/blob/master/lib/FSharp.Compiler.Service.dll
and fix #I here https://github.com/fsprojects/VisualFSharpPowerTools/blob/master/docs/tools/generate.fsx#L28

done

Great, thanks!


How to use in applications

Hi ,
I was exploring superset and it's great. I have created some dashboards, but Now I want to use them in a web application .How Can I load these dashboards in application interface.
Thanks

if you add a url parameter &standalone=true the menu bar won't show up at the top, so you can then <iframe> that.
There's been talks of shipping superset charts and dashboards as React components, it should happen in the first half of 2018.

Thanks :)


Add canGenerate method on Consumer/Provider ResourceDefinitionGenerator

Feature Request
Currently it's up to the implementation of the ResourceDefinitionGenerator decide if the ResourceDefinition needs to be generated.
This could be handled in a different way, like it has been done on the Provider interface: adding a method that states if a certain request needs to have a resource generated or not. This will make the API and the implementation breezier.
Which Areas Would Be Affected?
transfer
Why Is the Feature Desired?
refactoring
Solution Proposal
Add a method with this interface to the generator
boolean canGenerate(DataRequest dataRequest, Policy policy);

Then on the ResourceManifestGenerator it will be used to filter out the generators:
var definitions = consumerGenerators.stream()
                .filter(generator -> generator.canGenerate(dataRequest, policy))
                .map(generator -> generator.generate(dataRequest, policy))
                .collect(Collectors.toList());

Type of Issue
refactoring

+1 we should be careful to note that an explicit design is to allow multiple resource generates to be engaged as opposed to just one (as is the case with other canXXX() methods).


MINOR: Add exception.toString for error log formatting

Update to use exception.toString() as a parameter for log.error
Testing strategy - ran current tests.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@guozhangwang @mjsax @vvcephei


no dependencies with published package

It looks like you made all of the dependencies devDependencies so none are installed when using the @ui-js/grok package.

Ooops... I think I fixed it now.


Implemented multiple definitions for businessHours

and also deleted from control version the folder dist (it was already ignored on .gitignore)
This fixes issue #2421

Very nice feature!!!

There's a problem with this pull request: I mess up the languages!!! I'm closing this.


problem with docker run

Hi folks,
docker run -p 8080:8080 jboss/hawkular-apm-server
the full log

Can't see the error anymore.
Thanks.


Update the README

What does this PR do?
As per title.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


disable dev mode for lspsaga.nvim

Fixes #48

Hello, I've got this problem with missing lspsaga in my $HOME/projects/lspsaga.nvim. Found out it was related to lspsaga.nvim's dev mode enabled. I disabled it, so no one else will have to figure this out yet again, hope you don't mind.
Cheers

thanks


is the master repo  support registry v2 for now?

why get 404 error when i add local registry2 use "--insecure-registry" ?

hi @ehazlett , i saw that you open you own repo to support v2 version, but i can not find how to use? the readme.md in you branch is the same with the master repo.
what can i do?  thank you for your time~

Hi @ehazlett , @tombee ,@kazaff ! We actually have a working registry v2 for shipyard implemented here https://github.com/eedevops/shipyard, under the registry-v2 branch. I can integrate it with your current master and test it. Would you accept a PR, if we submit it? TY!

Please submit a PR and we will review it. Thanks!

Hi @ehazlett , @tombee . Just submitted a PR. Thanks!

The pr is here, if you want to check it out: https://github.com/shipyard/shipyard/pull/852


change quote to avoid escapes

Description
Change quotes to avoid escaping inner quotes.
BAD:
var s = 'It\'s not fun';

GOOD:
var s = "It's not fun";

Related Issues
None
Tests
None
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.

Merge conflict.  Would you mind rebasing?

It looks like this one has another merge conflict.


Small fix to address issue preventing models to be saved using postgres,

Small fix to address issue preventing models to be saved using postgres, mysql or sqlite adapters

@dkubb can you follow up?

@jwkoelewijn I don't recall any test failures in the dm-core specs after my change was applied? Did you see something in your app? If so, are you able to add a failing spec to this?
If I recall the ||= was important because in some instances @properties has already been set, and we don't want to reset it if it has. However, I'd love to see a failing spec and maybe I can play around with the code and figure out an approach that works for both cases.

@dkubb You're right, all specs in dm-core passed, however, the change introduced spec failures in dm-postgres, dm-sqlite and dm-mysql adapters. This small change should fix this. Because there were already failing specs, I didn't deem it necessary to create new specs. The original case for which the changes were made still have specs for testing that case, this small fix is only to fix the failing specs in postgres, sqlite and mysql.


“Step 1 of ” text appears instead of “Step 1 of 3” for Create account screens when user navigates through steps screens of create account flow

Frequency: 100%
Repro on build version: Android Internal Build V1.24.1, Android Play store Build V1.23.3, Test flight build V1.24.1, V1.24.0, 1.23.3
Repro on devices: iPhone 13 mini (15.1.1), iPhone 12 (14.7.1), Samsung Galaxy A8+(8.0), Google Pixel 2XL (11.0)
Pre-condition:

User must have installed the application.
User must be on “Step into the future of crypto with valora” screen

Repro Steps:

Tap on “Create new account”, tap on “Accept” button & observe.
Tap on “Next” button after entering valid name & observe.
Enter valid PIN twice & observe.

Current Behavior:  “Step 1 of ” text appears instead of “Step 1 of 3” for Create account screens when user navigates through  steps screens of create account flow
Expected Behavior: “Step 1 of 3” text must appear for Create account screens when user navigates through  steps screens of create account flow
Investigation: This issue is reproducible for restore account steps screens also
Impact: Bad user impact.
Attachment:
Create Account steps issue.mp4
Restore Account Steps issue.mp4

@gnardini I also cannot reproduce the issue. @ValoraQA can we get a retest on todays nightly build?

Hey @MuckT, We have verified above issue using Latest Android Nightly Build V1.24.0, Test flight Nightly Build V1.24.0<PHONE_NUMBER>) & observed that issue is not Reproducible.
Note:  We have re-verified this issue using Latest Android Internal Build V1.24.1, Test flight Build V1.24.1 & observed that the issue is still reproducible for both platforms
Devices: Google Pixel XL (10.0), iPhone 13 mini (15.1.1)
Attachments:
Nightly Create account.jpg
Nightly Restore Account.jpg
CC: @gnardini
Thanks..!!

Hey @MuckT, We have verified above issue using Latest Android Internal Release Build V1.25.1, Test flight Release Build V1.25.1 & observed that the issue is fixed. "Step 1 of 3" text appears for create account screens when user navigates through steps screens of create account flow.
Hence we are closing this issue.
Devices: iPhone 13 mini (15.1.1), Google pixel 2XL(11.0), iPhone 12 (14.7.1), Google Pixel XL (10.0), iPhone 7 (13.3)
Attachments:
Create Account Flow.jpg
Restore Account Flow.jpg
Thanks..!!


Basic import not working

Vapi Python SDK version: 0.1.0
Python version: 3.11.5
Operating System:

Description
For some reason the basic pip installation isn't working.
Looks like Vapi isn't detected in the vapi_python package.
What I Did
from vapi_python import Vapi
results in:
ImportError: cannot import name 'Vapi' from 'vapi_python' (c:\Python311\Lib\site-packages\vapi_python_init_.py)

https://github.com/VapiAI/python/issues/5#issuecomment-2109914373
Currently windows not supported. Daily is working on it.

After some exploration it looks like the issue has to do with daily-python not being in the PyPI library.  Therefore since this is a required library the whole download seems to fail.


minor cleanup

removed a file from the front page of flow that I don't think is used by anyone

LGTM - don't remember this being used at all


fix #63 all php indentation

@mixcas check my refactor of the switch thing and merge if you are happy


Update Composer dependencies (2024-02-14-00-10)

Visual regression test passed!
View the visual regression test report


Links are broken in walkthrough github page

In this page (https://dahak-metagenomics.github.io/dahak-taco/walkthrus/readfilt.html)
hyperlinks pointing to
https://dahak-metagenomics.github.io/INSTALLING.md
and
https://dahak-metagenomics.github.io/dahak-taco/walkthrus/setup.md
are broken and lead to 404

NLA


Remove outdated note about cross-region restore support for MI

This sentence is more nuanced and explained in the relevant geo-restore section.

@SvenAelterman : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

Hi @SvenAelterman , thanks for your submission! My apologies, but I believe this change is not accurate as cross-region and cross-subscription point in time restore is not currently supported. Would you mind clarifying what prompted this submission? Please feel free to contact me directly at<EMAIL_ADDRESS>I'll go ahead and close out this PR for the time being but please feel free to comment should you need anything further.
Thanks!
Masha from the SQL Docs team
#please-close


Added service to control force mode from ROS2

Added service to set force mode
Needs https://github.com/ros-industrial/ur_msgs/pull/21 and https://github.com/UniversalRobots/Universal_Robots_ROS2_Description/pull/75
ToDo list

[x] Make force_mode work
[x] Implement an own controller for force_mode
[ ] Document force_mode_controller
[ ] Make controller thread_safe using realtime_buffer
[ ] Test and probably improve force_mode_controller in conjunction with moving the robot
[ ] Add test(s) for force_mode_controller

Since I did some amount of work on this, I think this should be reviewed by @RobertWilbrandt.
In a nutshell I think it is very discussable whether we add this functionality to the IO controller or whether we should shift it to another controller. As we put a lot of stuff into the IO controller, I don't see why this should not go into this, as well, but I definitively don;t like getting this thing bigger and bigger.
Also, tests would be good, but that would also go for the other components inside that controller.

Thinking about this: I really think, this should go into its own controller. Then activating / deactivating the controller would be activating / deactivating force_mode providing a service for parametrizing the force_mode.
Also, setting force_mode's damping and gain should be handled from this.

Closing this in favor of #1049


Light mode support?

I really enjoy using the component-party.dev website, but I personally prefer a light interface. Could you consider adding a light mode option in addition to the current dark mode? It would be great to have both options available for different user preferences.

It's a lot of work and making maintenability more complex so not planned atm.


Highlight track in nav context from link & fix link resolution loop

This was listed as a to-do item and often bothered me when I wanted to quickly open a Spotify link that someone had sent me. This is probably a more critical feature than I realized it to be.
This PR also fixes the issue where in navigating to a URL determined context, pressing back to navigate backwards would end up leading to resolving the URL once more, putting you in a loop you couldn't get out of.

Wow, you're on a roll. Great job!


Google Cloud error

How to configure gcloud for this project.
I am getting folwoing error
GoogleProvider: Error: Could not load the default credentials. Browse to https://cloud.google.com/docs/authentication/getting-started for more information. - ending stream
/usr/src/aeap-speech-to-text/node_modules/google-gax/node_modules/google-auth-library/build/src/auth/googleauth.js:292
throw new Error(exports.GoogleAuthExceptionMessages.NO_ADC_FOUND);
^
Error: Could not load the default credentials. Browse to https://cloud.google.com/docs/authentication/getting-started for more information.
at GoogleAuth.getApplicationDefaultAsync (/usr/src/aeap-speech-to-text/node_modules/google-gax/node_modules/google-auth-library/build/src/auth/googleauth.js:292:15)

how to configure environment variable

sorted with export


Implement solid service support

FWIW...
Solid is w3c standard for enabling interoperable read-write web, that enables storage decoupled, decentralized web applications.
It's interaction model has two kinds of resources:

Containers: analogous to directory. Has containment rdf gaph as their representations.
Non containers: Any other rdf or non rdf resources.

It also supports notion of auxiliary resources.
Standardizes following operations:

HEAD, GET, PATCH, PUT, DELETE on any resource.
POST on container resource to create children.

It's PUT allows creating non existing parent containers automatically.
It standardizes uri slash semantics too.
Along with above, it standardizes decentralized oidc identity provider, authentication via web-id (one to one), or through oidc flows. And has access control mechanism.
Solid protocol will be w3c recommendation soon (Currently ED, with v0.9). Has few companies (like inrupt, headed by w3c chief himself) already providing enterprize implementations. And exists popular oss implementations. Has growing number of apps. Adopted by few govts for providing decentralized services for their citizens.
Originally posted by @damooo in https://github.com/datafuselabs/opendal/issues/403#issuecomment-1169024103

@Xuanwo How do we review this issue today?

@Xuanwo How do we review this issue today?

A potential service for the community to consider. Let me add some tag for it.

Just to clarify: Solid is not (yet) a W3C standard, nor an official draft on the recommendations track. The official list is here: https://www.w3.org/TR/
There is a community group  iterating internally on a draft, but the W3C tries to be clear that these are not to be considered endorsed by the W3C. More info about this


Fix SeaExplorer L0 timeseries name to avoid broken website links

Removed _L0 from the end of the SeaExplorer L0 timeseries name for the netcdf files. This change makes the filename consistent with the L0 timeseries filename for the Slocums, and avoids creating broken website links, since the html template is looking for a filename without L0 appended to the end.

@hvdosser you will probably want to rebase on upstream/main to get CI to work here.


Enzyme compatibility in Webpack config

RE: https://github.com/facebookincubator/create-react-app/issues/80#issuecomment-235015337
This is what's required for Enzyme compatibility:
https://github.com/airbnb/enzyme/blob/master/docs/guides/webpack.md#react-15-compatability
externals: {
  'react/addons': true,
  'react/lib/ExecutionEnvironment': true,
  'react/lib/ReactContext': true
}

This project doesn't have a test-specific Webpack config, so where should this go?

OK, happy to take a PR adding this.

I’ve looked at it again and I don’t quite see the point. Presumably you’d run Enzyme outside of both npm start and npm run build anyway, wouldn’t you? An in this case you’d likely want a custom config anyway that’s tailored to tests.
What is the reasoning behind including these externals either in current dev or prod config?
cc @ariporad

What is the reasoning behind including these externals either in current dev or prod config?

Nothing, those should go in the testing specific webpack config as reflected in @insin's question at the end of the issue. :+1:

Okay, I’ll close then until we decide something on testing.


Upload stream not work with some file

I try to upload some audio record file in my serverpod server (0.9.21) but it's not work for file with size >=5 MB.
My RecordEndpoint  :
import 'package:serverpod/serverpod.dart';

class RecordEndpoint extends Endpoint {
  Future<String?> getUploadDescription(Session session, String path) async {
    return session.storage.createDirectFileUploadDescription(storageId: 'private', path: path);
  }

  Future<bool> verifyUpload(Session session, String path) async {
    return session.storage.verifyDirectFileUpload(storageId: 'private', path: path);
  }
}

Flutter (with upload)
  final String? uploadEnregistrement=await client.record.getUploadDescription(file!.split('/').last);
  if (uploadEnregistrement!=null) {
    final audioFile=File(file.replaceAll('file://', ''));
    var uploader = FileUploader(uploadEnregistrement);
    await uploader.upload(audioFile.openRead(),audioFile.lengthSync());
    final bool uploadOK=await client.record.verifyUpload(file.split('/').last);
    print(uploadOK);
  }

uploadEnregistrement is ok => {"url":"http://<IP_ADDRESS>:8080/serverpod_cloud_storage?method=upload&storage=private&path=audio6028604305658716676.m4a&key=e4Yiw7RWP8PVuivq","type":"binary"}
But verifyUpload return false and in table cloud_storage & cloud_storage_direct_upload there is no row about this file (or uploadDescription).
For small file (like < 5 MB) it's work fine but with file with a size > 5Mb it's not working. The file in my mobile is ok because i can listen to it.
i have no error on my backend :

Config :

ok thank's i will try with S3 👍 . I thought it's come for my upload code (with stream).

during the time my domain was available in aws/cloudfront  &ssl,
i read serverpod code and  in serverpod_shared/lib/src/config.dart file i found this row :

The limit of 5 Mo approximately is not linked to MaxRequestSize ?

Please document this behaviour. I could not upload PDFs.
I added the line to  pod.config.maxRequestSize = 15216050; in run method of the server and fixed the issue

Max request size is now listed in the configurations options but we should include documentation about this in the "Uploading files" page.


Custom filter function.

Would be great to have an option to provide custom filter function.

It seems it is easy change, just need to add something similar to externalSetFilter. And it seems it makes sense to have something similar to externalChangeSort for the local data as well.
Here is my use case:
I have non-flat object as column element, something like:
{
  @value: 'some value',
  @type: 'some type'
}

And then I use custom column component to render this value. As a result default sorting and filtering functions do not work.

Thanks for the suggestion! :+1:  We are planning on adding something like this in the near future where filter/sort/etc can be passed to the component.

Meanwhile there is quick workaround - filter and sort use toString function to get value from data object. So proper toString function solves this issue for me.

Would nice for date sorting. #142

@aindlq where did you add this quick work around?

@pherris
[{a: "some text", b: 2, toString: function(){return this.b;}}]

I use custom component for column to output x.a, and x.b is used for filtering and sorting. If your data object is instance of some class, you can use prototype to define toString there.

@aindlq
this is really interesting could you provide more code ? thanks a lot

Shoot, I don't think this will work for me. I've also got a custom component but it's doing a lookup for the display value.
var QueueCell = React.createClass({
  render() {
    var queue = QueueStore.getQueues().get(this.props.rowData.queue) || {};
    return (
      <span>{queue.description || this.props.rowDate.queue}</span>
    );
  }
});

Maybe if the custom component could implement a toString method and the library would use that...

@aindlq
Would also like a working example. Trying to do something similar as well.

Here is small example with simple js object, x.show is used for display value and x.id for filtering: http://jsbin.com/foxuviheju/1/edit?html,output
In my use case data object is not just, so I have toString defined on prototype.

thank you

Thanks @aindlq!
I'm closing this for now in favor of https://github.com/GriddleGriddle/griddle-core/issues/29 -- we will treat these issues as kind-of acceptance criteria of the new stuff when that's ready.
This issue existed before that project even existed but we are trying to clear out anything that we're working on with the new components :+1: Please feel free to let us know of any questions


P-3 nav and PSD support

Add P-3 Met-Nav, UIOOPS PSD, and TAMMS

[x] Read P-3 meteorology and navigation info from IWG files
[x] Trim and resample Met-Nav data with user-specified start/end times and frequency
[x] Generate composite (e.g., 2D-S + HVPS) PSDs from UIOOPS output
[x] Derive bulk microphysical properties
[x] Read TAMMS data in the NASA AMES format

P-3 met-nav, TAMMS, UIOOPS PSD classes implemented and tested. Changes pushed up to the main branch. See src/impacts_tools/tests for example notebook with execution.


Performance issues when requesting a vast amount of occurrences

via the "table" API. This was never noticed because of our pagination, but it's been used by @sronveaux that consumes our API for other purposes.

I removed tons of duplicated queries already.
In case the user is authenticated, it is not enough because https://github.com/riparias/early-warning-webapp/blob/58ca7750bb6a796bf6a4a224ef49857f952f2edd/dashboard/models.py#L224-L228 is not using the result of prefect_related().
To be improved, but not problematic anymore since @sronveaux access the data as non-authenticated user.

I tried to fix the remaining (authenticated) use-case, but since it's not that easy and there's no concrete use case for it now, I'm gonna close this issue (YAGNI).


Allow navbar links padding to be configurable.

Fixes #21956

This isn't the right approach; you're zeroing out the vertical padding while setting horizontal padding here. Generally we do -x and -y variables and apply those as needed.


dropdown menu doesn't open on click on mobile

dropdown menu doesn't open on click on mobile

Bug fixed


Revert changes related to #7623

cc @luacmartins @thienlnam
Details

Original PR here broke the error boundary and storybook https://github.com/Expensify/App/pull/8196/files
Fix PR applied an unnecessary solution (IMO) and did not actually fix the error boundary https://github.com/Expensify/App/pull/8365/files

I'm CP'ing this to staging so we can fix the broken error boundary ASAP.
I don't know what we want to do about the original issue but having the error boundary work is 1000x more valuable than the issue and this has wasted valuable time.
Fixed Issues
Related to #7623
Tests
Apply this diff:
diff --git a/src/libs/Navigation/AppNavigator/AuthScreens.js b/src/libs/Navigation/AppNavigator/AuthScreens.js
index 944dcfa52..acb1752c9 100644
--- a/src/libs/Navigation/AppNavigator/AuthScreens.js
+++ b/src/libs/Navigation/AppNavigator/AuthScreens.js
@@ -127,6 +127,8 @@ class AuthScreens extends React.Component {
         BankAccounts.fetchFreePlanVerifiedBankAccount();
         BankAccounts.fetchUserWallet();

+        throw new Error('derp');
+
         // Load policies, maybe creating a new policy first.
         Linking.getInitialURL()
             .then((url) => {

Run app see that error boundary is triggered:

🚀 Cherry-picked to staging by @luacmartins in version: 1.1.49-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by @roryabraham in version: 1.1.49-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[Question] How to view the generated .trace files for a trace?

Dear Authors:
Thanks for the great work!
Just want to check how can I view the generated trace given these files?
Thanks!

You can use https://trace.playwright.dev/.On 26 Jun 2024, at 4:30 AM, ReeceResearch @.***> wrote:
2024-06-<IP_ADDRESS>.png (view on web)
Dear Authors:
Thanks for the great work!
Just want to check how can I view the generated trace given these files?
Thanks!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>


Cant import a Bruno collection I previously exported

Import collection failed message is displayed.
No further details provided

Same issue!

Same here, issues with 1.13.0 and 1.13.1. Haven't tried downgrading.

Probably duplicate of https://github.com/usebruno/bruno/issues/1868

Hello
I have same error after updating Bruno on 1.12.3 Mac x64 version.
To replicate this issue you need to export a Bruno collection and Import same Bruno collection.

This is very critical, cause no turnover(or tell us how to by pass)... I'm blocked on my usage of BRUNO :(

@armdab As a workaround, I simply remove the first item (the one with type=json) in the exported json file.

@AnthonySou , can you pleas be more specific?

@ruvlesh Steps :

Export bruno collection
Edit the exported json file, find the first "items" array and remove the first json object of this array (this object have a property "type"="json")
Save the file
Import the bruno collection and that was ok for me
Hope this will be helpful.


document hardlink_lock config option

Description or link to context please 🙂

@jorgeorpinel https://github.com/iterative/dvc.org/pull/867 here is the patch.

Ah yes, sorry, I keep not noticing those automatic links. My brain is trained to ignore them :b

@jorgeorpinel THere is also "May be fixed by #867" in the header.


Compose Restoration Test sometimes fails

Describe the bug
The Compose Restoration Test sometimes failes.
Additional context
Emulator-Logcat-Logs-21.zip
Emulator-Test-Results-21.zip

The test itself is not completely wrong, it just doesn't wait enough.
The implementation is incorrect, and the test points that out sometimes:

When the Restoration happens, the whole composable is recreated
=> This means the LaunchedEffect as well, which navigates away from the Splash screen
=> This means after 500 millis we navigate again to Splash screen, even if we are already there
=> The restoration state is lost, since we popup and only show the new screen which has no saved state.

To resolve:
=> Add advanceTimeBy after restoration, to ensure all time based operations run as well
=> Then modify the implementation so the State Restoration becomes correct


Modelling - manually added app server does not show

where  should the IP appear if if does not match any network area?

@abarz722 I guess we have a blind spot here which needs to be decided by the customer

implemented


Add Issue and PR templates

Hey @sidjain26! I'm wondering - should we be also asking what versions of jshint-loader & jshint are being used?

@kostasmanionis added respective fields.


Choice of Logging Backend

Is your feature request related to a problem? Please describe.
Currently only logging to TensorBoard is supported, but there are many other great logging tools out there (Visdom, W&B, MLflow).
Describe the solution you'd like
There should be a way for the researcher to choose a logging backend and/or a way to implement/override a custom logger given the interface Lightning requires.
Describe alternatives you've considered
Force everyone to use TensorBoard :(
Additional context
Since the Experiment is a subclass of SummaryWriter, it cannot be changed easily. It would require a lot of refactoring.

duplicate #47

Stupid of me, how did I not see the other issue... Thanks for taking a look at this.

all good!!

@awaelchli want to try implementing this support? (using the other issue)

@williamFalcon I would like to try it this weekend. I only discovered lightning recently and I am not yet familiar with the details of this library.


Draft: Add hierarchical creation

Added a testcase for creation of the PhysicalArchitecture layer. During the creation the whole structure information is passed as a dictionary and should be created in one go.
@vik378 mentioned the idea that at first the dict is checked against a minimum viable scheme/skeleton of the ModelElement on which the initial create call is requested.
In a later stage there might be generic name (or requried attribute) generation added.

@amolenaar marked this pull request as ready for review 4 hours ago

Why that? As far as I can see, this is not ready (the head commit 54ef7d7 is marked "[WIP]", and almost all the CI is red). Did you mean to push some new commits?

@Wuestengecko Not sure what happened. I did not intent to change it's status.

@amolenaar no big issue. I'll just change it back then.

Not aligned with the vision anymore.


ng update @angular/material v7 cannot find module

Bug, feature request, or proposal:
When I try to update from v6.4.7 to 7.0.0-rc.0 of material using ng-update, I get an error on the terminal.
What is the expected behavior?
Successful update to v7 without warnings or errors.
What is the current behavior?
Cannot find module '/usr/local/google/home/stephenfluin/workspace/devfest/node_modules/@angular/material/schematics/ng-update/index'
What are the steps to reproduce?
// First get a v6 app
ng new my-app
ng add @angular/material
ng generate @angular/material:material-dashboard --name=dash
// Then try updating to v7
$ ng update @angular/material --next
    Updating package.json with dependency @angular/cdk @ "7.0.0-rc.0" (was "6.4.7")...
    Updating package.json with dependency @angular/material @ "7.0.0-rc.0" (was "6.4.7")...
UPDATE package.json (1456 bytes)
warning " ><EMAIL_ADDRESS>has incorrect peer dependency "<EMAIL_ADDRESS><7.0.0 || >6.0.0-beta <7.0.0".
warning " ><EMAIL_ADDRESS>has incorrect peer dependency "<EMAIL_ADDRESS><7.0.0 || >6.0.0-beta <7.0.0".
Cannot find module '/usr/local/google/home/stephenfluin/workspace/test/update-etst/node_modules/@angular/material/schematics/ng-update/index'

Good catch. I've also ran into this an hours ago. See https://github.com/angular/material2/pull/13406

Fixed with https://github.com/angular/material2/commit/3f8ee748ddfbed08203e623963d9a544766a19d8

Just wondering if it is related https://github.com/angular/material2/issues/13438 ?


Update item-sliding.ts

Short description of what this resolves:
Changes proposed in this pull request:

Ionic Version: 1.x / 2.x
Fixes: #

Thank you!


Admin REST endpoint to add to witnesses collection

An admin REST endpoint is required to post a request for a service to invite another service to be a witness. This endpoint should have access control.

A generic /outbox endpoint exists that allows any activity to be posted. So this issue is no longer relevant.


Set copyLibsDirectory when deploying loose app with container support

Loose application with container support currently parameterizes the project root, but .m2 dependencies are outside of the project dir and still use absolute paths.  To solve this, set the copyLibsDirectory when calling the deploy task with container option, so that the dependencies will be copied to somewhere under the project root.
See https://github.com/OpenLiberty/ci.maven/blob/master/docs/deploy.md#deploy  with copyLibsDirectory parameter

Investigate whether there is a similar thing in the gradle build.

It still needs to be added to gradle. Here is the issue open for it: https://github.com/OpenLiberty/ci.gradle/issues/468


cadaver: Fix building with current openssl

...by using the already-packaged (newer) version of neon as it is also done for
openSUSE[1].
[1] https://build.opensuse.org/package/show/openSUSE:Factory/cadaver

Motivation for this change
This package was broken before, because it used an old version of openssl which has known vulnerabilities.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@wavewave

Result of nixpkgs-review pr 115329 at fefb459e run on aarch64-linux 1

1 package built:

cadaver

4 suggestions:

warning: build-tools-in-build-inputs
pkg-config is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/tools/networking/cadaver/default.nix:22:3:
   |
22 |   buildInputs = [ neon pkg-config readline zlib];
   |   ^

warning: missing-patch-comment
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/tools/networking/cadaver/default.nix:12:5:
   |
12 |     (fetchpatch {
   |     ^

warning: missing-patch-comment
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/tools/networking/cadaver/default.nix:17:5:
   |
17 |     ./configure.patch
   |     ^

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/tools/networking/cadaver/default.nix:28:5:
   |
28 |     license     = licenses.gpl2;
   |     ^


P4RT 2.1 - Script updated to add interface type to DUT

Updated go script for P4rt 2.1
Added a function configureInterfaceType() which updates the interface type with the port ID on the DUT.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 57.219%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1181

Relevant Lines:
2064

💛  - Coveralls

/gcbrun


is there a way to add new entry while ring is waiting for cqe

I am trying to use io_uring and I run 2 threads:

one is waiting for the ring, if it returns, handle the.
the second one creates an entry and uses prep_readv to set it and push it into sq.

I found if the first thread is waiting, the second thread push entry won't let the first thread return.

I try submit again after push entry to sq, and the wait_for_cqe can return now.
Will there be any problems when I do this?

No, that is fine.


Change default client name GraphClient => ApiClient

Adresses #189

@wcontayon thanks a lot for your contribution!

You're welcome @baywet. Please feel free to assigne me some interesting issues. It's a pleasure to contribute on Microsoft Open Source project. 🙂 🙂 🙂

@wcontayon can you sign the CLA please before we can merge this PR? (see the previous message from the bot)

@wcontayon thanks! your pull request has now been merged. Congrats!
We're more than happy to have you contributing, just so I can gage what kind of work items I can assign you, how much time are you looking at spending on the project? Do you know any language we could add, like PHP or Go?

@baywet I've some knowledge (not an expert) on PHP, but not in Go.
I mainly work with .NET. Feel free to assign me .NET issues (help, bug, enhancement) 🙂

great! have a look at #135 and #211 and tell me if you feel like taking any of those.


style(black): format acquisition

Run the acquisition Python files through the code formatter black.
Summary:

Everything but covidcast (do that one after #1103).
Also makes SonarCode happy.

Prerequisites:

[x] Unless it is a documentation hotfix it should be merged against the dev branch
[x] Branch is up-to-date with the branch to be merged with, i.e. dev
[x] Build is successful
[x] Code is cleaned up and formatted

May not be important given our general preference for the 100-length line version, but this is missing the pyproject.toml file.

Closing in favor of #1189


New version: BrkgaMpIpr v1.0.2

Registering package: BrkgaMpIpr
Repository: https://github.com/ceandrade/BrkgaMpIpr.jl
Created by: @ceandrade
Version: v1.0.2
Commit: 8fb917216a5a09167eae7a9fe4fefaf0537f765d
Reviewed by: @ceandrade
Reference: https://github.com/ceandrade/BrkgaMpIpr.jl/issues/7#issuecomment-601339379

Cancel merge


new SHR-based patient model / Patient object / condition summary metadata

initial commit of new patient model using SHR JSON instance with abstraction on top for accessing - Patient. Updated summary and timeline to use it and updated summary to use metadata defined in json per condition

Adding back in the paper background to the editor panel makes the editor panel look consistent with the other 2 panels (and preserve the look and feel of full app).
Insertion of data summary items into the editor works. I noticed, however, that there is an error when the user inserts the shortcut then inserts items from the summary panel. Inserted items from the summary panel turn into structured fields.

Should we make a jira issue for this?

I actually saw that too, but thought it would get solved once we can hook up the disable insertion when in a structured field. Dylan's changes making sure slate selection sync's with html focus will also help. I didn't create a jira. If after we implement that functionality fully, it still has issues, then we should enter them. I'll create a jira to implement the disabling of insertion buttons but I think it has to wait for your and Dylan's stuff to get merged with me stuff.

I agree that it should probably wait until everything is merged together before we start knocking out those small, related tasks; they might be solved in the process of or as a product of fixing something in the existing tasks.

Ok based on your comments (Greg and Dylan) then this branch looks good to me

Moved the hard coded metadata describing how to summarize a condition into a separate class (still hard coded for now though).
Also add focus to the transform chain after insertText for inserting summary items into editor. this resolves jira 213 so I pulled that into sprint

Nice touch regarding the focus function.

thanks! it's nice when things are that easy!


added reportPath as parameter to reportTaskStart

added reportPath as parameter to the reportTaskStart() to have the path to the reporter output file (if set) in the (custom) reporter. This can be used to write other files in this location as well.

I really don't get why the functional tests fail. I didn't touch any of the code for that test.
Can anyone explain?
1) [Regression](GH-3021) - Should not wait for selector timeout if element has border-radius
       Should not wait for selector timeout:
     Error: We should not wait for selector timeout in this test
      at Context.<anonymous> (test/functional/fixtures/regression/gh-3021/test.js:7:76)

I couldn't reproduce locally neither, but got other test failed though

Thank you for your contribution! I think the mentioned test is just flaky, so we can just restart the build to get it working.
However, I feel that it will be better to just make public the ReporterPluginHost#stream property, which is already defined but is hidden with a module-scoped Symbol('stream'): . So you will be able to write something like:
reportTaskStart (...args) {
    // do stuff
    const  path = this.stream.path;
}

in your reporter plugin.
I will discuss it with @kirovboris, @miherlosev and other TestCafe team members in private and report our decision here.

I apologize for a delayed response. We have decided to provide access to the stream property for reporter plugins: https://github.com/DevExpress/testcafe/issues/3610. Since this PR is stale, I think it's better to start a new PR now.


Simplified defineProperty(data,'raw') statement

it already has the value 'raw', it's just unprotected and enumerable...

Thanks


The movement is strange when there is shadow in text style.

Text does not flow naturally when I run this code
Marquee(
            text: "Hello",
            style: TextStyle(
                color: Colors.green[100],
                fontSize: 100,
                shadows: [
                  Shadow(color: Colors.green[300], blurRadius: 20 / 2),
                  Shadow(color: Colors.green[400], blurRadius: 20),
                  Shadow(color: Colors.green[500], blurRadius: 20 * 3.0)
                ]
            ),
            scrollAxis: Axis.horizontal,
            crossAxisAlignment: CrossAxisAlignment.center,
            blankSpace: 20,
            velocity: 300,
            pauseAfterRound: Duration(seconds: 0),
            startPadding: 10.0,
          );
        }

It's strange only on the simulator.
It's okay on the device...!!

That is pretty weird. I suppose, rendering text shadows is pretty resource intensive. Although the widget should actually only render the texts as they newly come into view and use cached versions the rest of the time.
Since this only affects the simulator, I don't think I'll take any further action. Is this still a priority problem for you?

That is pretty weird. I suppose, rendering text shadows is pretty resource intensive. Although the widget should actually only render the texts as they newly come into view and use cached versions the rest of the time.
Since this only affects the simulator, I don't think I'll take any further action. Is this still a priority problem for you?


Fixed #26831 -- Documented session data must be JSON encodable for JSONSerializer.

https://code.djangoproject.com/ticket/26831

merged in 1f82b857ceb75f2d7a68e79c6a00c30bfe7f1318, thanks!


Multi-method properties

In the course of a given QM computation multiple properties (particularly one-electron) could be constructed so that a single field may become ambiguous. A good example is a CCSD density computation which may form SCF, MP2, and CCSD densities. For a quantity like dipole_moments a program may build a set of moments for each density.
A possibility is to have keys for each scf_dipole_moments, mp2_dipole_moments, and ccsd_dipole_moments. Another possibility is to build a dipole moment definition object:
property: {
  type: "dipole moment"
  method: "SCF"
  value: ...
}

which holds the properties for each method. (Let me know if I misunderstood this @langner.)
Brought up by @langner in #37.

I actually did not have a specific solution in mind, just think it'd be worthwhile to consider generalizing here. Adding keys is probably not scalable. Would there also be ccd_dipole_moments and cis_dipole_moments? And how about quadrupole moments?

I think this is a good @loriab question who has thought about this quite a bit more than I have. Generally my thought was to explicitly tag the "99% case" and have these keys extensible like ci5_dipole_moments which can be integrated into the schema via regex patterns.

I will push for the objects instead of building a slew of keys...which a developer will have to look through, and which would have to be extended every time someone thinks of a new method.
Now, the method alone does not provide enough information. In reality, the method should point to the full information, basis set, SCF and settings, etc.

The output of that these properties are attached to the method, basis, settings etc. It seems overkill to to point to these again in a property structure, no?
I dont quite understand, defining keys seems to be a large part of this so that users do not have to go fishing through each programs output keys to figure out what they have. Again, we do not need to define keys for everything; however, I am reasonably certain that the majority of cases comprise of a relatively small subset of possible keys.
Dipole moments is a bit of an odd case as we have somewhat duplicate keys for multiple methods. However, the energy components of SCF/MP/CI/CC/SAPT/etc is all quite unique.

If properties are already attached to method, etc. then having specific keys for specific methods seems to be mute. Reality is that many properties can be build from a (first-order) density matrix and integrals, and this density matrix can come from many methods. So, it's not just dipole moments. Actually this can hold for every property that can computed with response, there are now ccsd response methods out there.

It's useful to have dedicated keys for the majority use cases, so maybe we should do both things. Several related issues come to mind:

Where do we draw the line, to strike a good balance between convenience and unnecessary proliferation of rare properties?
How do we deal with a situation where someone specifies the same property with a dedicated key and a some kind of full-blown object?
There may be things about properties that one may wish to annotate, for example the center of mass for dipole moments if it's not aligned with whatever is specified for the molecule. How do you conveyed without additional structure to the property?

Does it particularly matter if someone documents a property that isn't widely know about/used? Codes that do not use construct the property can simply ignore it and if they implement the method they have known keys to use.
From a json-schema standpoint the spec support multiple objects as values. Digesting this does become more complex... anytime we add more information the complexity of parsing the returned JSON is going to go up.
No idea, this kind of lumps into other questions of what happens if someone asks for PCM or computes properties via response density.

I feel like we need some sort of test suite of example calculations, which we would officially support, and the corresponding JSON schema files they would be represented by for guidance. This would capture the common cases and the special ones that have been raised. Maybe that would make the discussion more concrete? We've done this for cclib from the start and it's helped tremendously focus discussions about scope and supported methods.


Update Dev with the new demos in Master

PR to update the dev with a new PR from master and update the git history there.

Closing this PR due to some "silent changes"


[Bug]: Customer.IO overwrites project file changes from other plugins

Hi,
We're attempting to utilise expo-notifications alongside customerio/customerio-expo-plugin for richpush notifications on iOS.
Whilst investigating writing our own Expo plugin to handle registering the entitlement file in the project file (a task on the Customer.IO roadmap with no timeline), we discovered this is impossible due to the manner in which Customer.IO is writing project files changes. We also discovered that it shouldn't be necessary as expo-notifications is already configuring it, but Customer.IO is then overwriting those changes.
I believe this would also impact any other plugin that modifies the iOS project files that exists in a project utilising customerio/customerio-expo-plugin, potentially overwriting any changes they make, which adds a lot of risk to utilising customerio/customerio-expo-plugin.
We believe the problems to be as follows:
Firstly, the plugin does not await asynchronous actions within it, and thus rather than running in sequence with other plugins that are modifying the project file, it will instead overlap them. This will result in race conditions where the behaviour of plugins will vary based on the timing of when the project file is read by a given plugin.
See here for an example that should be promisified. I've included what this would look like below:
await new Promise((resolve, reject) => {
  xcodeProject.parse(async function (err: Error) {
    if (err) {
      reject(`Error parsing iOS project: ${JSON.stringify(err)}`);
    }

    if (options.pushNotification) {
      await addPushNotificationFile(options, xcodeProject);
    }

    if (options.pushNotification?.useRichPush) {
      await addRichPushXcodeProj(options, xcodeProject);
    }

    FileManagement.writeFile(projPath, xcodeProject.writeSync());
    resolve();
  });
});

This change alone will not resolve things however, and will actually result in Customer.IO not working, as the changes that Customer.IO has then written to the project file will then be overwritten by Expo. See here for information on how Expo suggests to modify files via returning modResults rather than writing to files.
I believe Customer.IO's Expo plugin code needs modifying to utilise withXcodeProject and other similar variants rather than directly modifying files in order for it to work correctly, alongside ensuring it only returns once all asynchronous actions have completed.

An alternative to the promisify could be xcodeProject.parseSync().

I've raised a pull request with the changes I believe are needed to resolve this.

I apologize for the inconvenience you are experiencing while using our plugin. Firstly, I would like to express my appreciation for providing such a detailed description of the issue. Your insights have greatly helped us in better understanding the issue at hand. We have encountered several compatibility issues recently, particularly with regards to our plugin and expo-notifications.
Please be assured that our team is actively working on addressing these issues and making the necessary adjustments to ensure compatibility between our plugin and expo-notifications. We are dedicated to providing a seamless experience for our users and appreciate your patience as we work towards a resolution.
Thanks for opening the PR. Your efforts to make our plugin are well appreciated. Our team will look into it.

For now we've forked the repository and pushed our own version to our internal NPM to unblock ourselves. Hopefully we'll switch back once this is resolved 👍


Supporting TypeScript

Is your feature request related to a problem? Please describe.
TypeScript does not appear as an option in the language selection when running amplify pull.
Therefore, the only option is to output in JavaScript, but this may cause coding errors when using it.
Describe the solution you'd like
Supporting TypeScript at UI code generation
Describe alternatives you've considered
nothing
Additional context
none

Codegen does support typescript. It can be selected by adding codegen to the project, or by updating via amplify update codegen. If you're describing the generated ui (react) components, then a decision was made to default to JS + typings files, which provides a similar DX to TS while operating in-editor and with tsc/etc.

Closing this issue.

Thank you very much for supporting TypeScript.
Awesome!!!


Improve links in header

Questions
Answers

Description?
Preparation for improving links in the header. Due to no dropdown available in the clean templates, implementation will be done in classic theme.

Type?
improvement / new feature

BC breaks?
no

Deprecations?
yes

Fixed ticket?
Fixes PrestaShop/Prestashop#25024

How to test?
Install module and see nothing is broken.

No need to change anything with this PR. Closing.