aur-fetch: add --sync

Make aur-fetch non-destructive by default, to either update AUR_SEEN (if --confirm-seen is specified) or run git-fetch -v.
If --sync=reset or --sync=rebase are specified, git reset --hard HEAD@{upstream}, and git reset --HARD; git merge are run, respectively.
sync=auto decides the action based on the aurutils.rebase configuration setting, defaulting to --reset, and this option is used by aur-sync.

As usual, documentation updates are missing.

@rafasc I wonder instead of using $git_empty_tree whether to continue to the next package if AUR_SEEN is not found. That way, aur fetch -L only work for cases it is defined to work on (AUR_SEEN available), rather than make an assumption that the user made no inspection through other means.

In particular: f53f3936452ac21098e2366c8bfcbfedc8eeaff1QD

Seems reasonable as standalone, but considering the use in aur-sync it creates a new corner case:
The warnings would be quickly hidden by the viewer in use, and these not reviewed packages would be marked in the results file as fetch:// with no diff, which matches the no   changes case.
Maybe marking these as 'error:' in the results file would be enough?

I've considered to make aur-fetch exit > 0 if for some package AUR_SEEN was not available. error: in the results file would need to be extended to other cases (rebase failing, clone failing, ...) as well.
I guess the main intent was to not suddenly have large changesets in the viewer, assuming in good faith that anything lacking AUR_SEEN was already properly inspected. But I can see the problematic. I've left things as is (only adding an exit 1 if git-fetch fails.)

Maybe the following is an alternative, preserving the 2.3 behavior if AUR_SEEN is not set:
diff --git a/lib/aur-fetch b/lib/aur-fetch
index ab745f3..3de96cd 100755
--- a/lib/aur-fetch
+++ b/lib/aur-fetch
@@ -134,14 +134,14 @@ fi | while read -r pkg; do
             exit 1
         }

-        if ! seen=$(git rev-parse --quiet --verify AUR_SEEN); then
-            warning '%s: AUR_SEEN object not found for %s, assuming empty tree' "$pkg" "$argv0"
-            seen=$(git hash-object -t tree /dev/null)
+        if seen=$(git rev-parse --quiet --verify AUR_SEEN); then
+            range=${seen:+$seen..}HEAD
+        else
+            warning '%s: %s: AUR_SEEN object not found, assuming ORIG_HEAD' "$pkg" "$argv0"
+            range=ORIG_HEAD..HEAD
         fi

         if [[ $seen != "$(git rev-parse HEAD)" ]]; then
-            range=${seen:+$seen..}HEAD
-
             # Contents have changed since last inspection; print differences.
             if (( verbose )); then
                 git --no-pager log "${diff_args[@]}" "$range"

Perhaps that and mark them as clone or something else in results, and/or make the output go into a pkgname.unseen file?
I am mostly concerned about how easy such cases could go unnoticed, essentially negating the entire point of having and trusting  AUR_SEEN.
There were some issues in the past concerning ORIG_HEAD and rebase, because commands that run inside a rebase can modify ORIG_HEAD . I didn't check, but I believe currently the rebase process sets the ORIG_HEAD when the rebase finishes to the value you would expect.
But I would really prefer people avoid this problem by explicitly running --confirm-seen.

Alright then, let's keep to this approach then :+1:


Sites.Selected permission should be available in SharePoint REST/CSOM APIs.

Sites.Selected should now be available in production for SharePoint permissions in addition to Microsoft Graph.
Would you please change the description of the document as follows?
Before the change:
The Sites.Selected application permission is available only in the Microsoft Graph API.
After the change:
The Sites.Selected application permission is available in the Microsoft Graph API and SharePoint REST / CSOM APIs.

The "API permissions" setting in Azure AD admin center shows the "Sites.Selected" application permissions for the SharePoint resource (https://microsoft.sharepoint-df.com/Sites.Selected), and I verified that the "Sites.Selected" permission works with the SharePoint REST API v1.0.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9edcc46d-c145-fad7-a54c-52c21f05ab7c
Version Independent ID: 8b6bcf33-b048-2d3c-33b5-5a3dd5d25a75
Content: Microsoft Graph permissions reference  - Microsoft Graph
Content Source: concepts/permissions-reference.md
Product: non-product-specific
Technology: microsoft-graph
GitHub Login: @Jackson-Woods
Microsoft Alias: MSGraphDocsVteam

As part of a repository clean up effort we are closing older issues. If this issue remains, please: open a new issue, reference this issue, and provide any additional details that may help in resolution. Thank you for your understanding as we work to improve our responsiveness.


DRAFT: YOMA-446 - feat(CompletedCourses): adding a shared section of utils for qualifications

Scope YOMA-446

Work Done
adding a shared component to facilitate a dry version of the education and completed courses components. Should be mostly scaffolded.
Steps to Test
nothing is currently implemented.

Closing as implemented in other branches/ PRs


Cleanup build

Remove the release workflow since the release binaries aren't used by anyone currently.
Speed up checkout
Use go 1.18 and simplify the build so that we just use the version of Go specified in our go.mod

Codecov Report

Merging #4 (1939000) into main (05d88d4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   61.74%   61.74%
=======================================
  Files          19       19
  Lines         732      732
=======================================
  Hits          452      452
  Misses        256      256
  Partials       24       24

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[Backtracing] Fix out-of-process async backtraces.

These weren't working correctly because I made the unwinder call _swift_task_getCurrent(), but of course when out-of-process, it calls that in swift-backtrace, which is wrong.  Remove that for now.
While I'm here, I also tweaked the formatting slightly, and I noticed that we were saying that all thunks were also system functions, which seemed unnecessary and odd.
Plus there were a couple of extra system functions I added to make the async crash backtraces nicer in friendly mode.
rdar://106363539

How odd. The macOS build failed to demangle some of the symbols. (There's some other problem that someone has introduced in the meantime that's broken PR testing also.)

@swift-ci Please smoke test

Ah, I wonder if the issue is that the macOS CI is running an older macOS that can't demangle async function names. That would make sense as it's clearly demangled the top frame correctly.

@swift-ci Please smoke test


Get rid of Node and NodePointer types

Also renamed other types:
NodeInfo -> Node
NodeTransform -> Transform

Yay, CI passed, ready to review

What does @kvark think of these changes?

Will have a look in a few hours

On Oct 25, 2017, at 06:51, David Harvey-Macaulay<EMAIL_ADDRESS>wrote:
What does @kvark think of these changes?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Add support for multiline urls (with "%0D%0A" in them)

This is a:

[x] Feature Request

My version of UI-Router is: 0.4.2
Feature Request
Problem description
This feature request is based on a real problem in a web app. I have already made it work in a fork and can make a PR which closes this issue.
We have "Login with Active Directory" functionality, login is done on a Microsoft website, and in case of an error, it redirects to the url like https://www.myapp.com/#/error=access_denied&error_description=AADSTS65005:+The+app+needs+access+to+a+service+(%22https://myapp.com/fdd80187-f97c-496d-9266-606316779c58%22)+that+your+organization+%22mstnd206987.onmicrosoft.com%22+has+not+subscribed+to+or+enabled.+Contact+your+IT+Admin+to+review+the+configuration+of+your+service+subscriptions.%0D%0ACorrelation+ID:+6c8ff940-b412-4519-a034-def6d0ba5adb%0D%0ATimestamp:+2017-05-05+11:49:04Z&state=f9c70076-af69-4f7f-8f87-7fc9f0d57922
We have a route/state for it in config, and it worked with ngRoute (it matched this url to template and controller, and the page was shown). But after we switched to ui-router, controller was not called, template's html was not requested from the server and no page was shown, page was completely blank.
Reason
The part of the url which causes problem is this one %0D%0ACorrelation+ID:..., or more specifically symbols %0D%0A. If I remove them from the url - everything works fine. These symbols are encoded "CRLF", so basically a new line.
I went to the source code and debugged why such urls are not matched to anything (tested with catch all route /error=*adError). The reason is that multiline urls are not matched (skipped) without multiline 'm' flag (because ui-router adds $ at the end of the regexp). If multiline flag is set - it works. But ui-router does not allow to set it via config.
Code lines for reference are:
function UrlMatcher(...) {
...
this.regexp = new RegExp(compiled, config.caseInsensitive ? 'i' : undefined);

Possible solution
Now, there are several ways to add multiline urls support:
a) allow to set it globally, as a "caseInsensitive" option you already have. I am not sure if it can break any other use cases - this is a question to you.
b) set it per state. This is how I did it for my project
.state({
 name: ,
 url: ,
 multilineUrl: true
});

Maybe we should allow both options.
So, the questions are:

Should I send a PR for this?

which option a) or b) should be done?

Thanks for the well described issue report.
Can you think of any way that enabling multiline matching would break matching in other apps?

@christopherthielen Well, it should not affect one line urls - their functioning should stay the same (as long as global flag is not used, but it seems not to be used anywhere in the component).
The only difference I can think of is multiline url where only the first line should be matched, but cannot think of a real world example where this could be needed.
Actually, the problem seems to be not in the multiline flag missing, but in the "catch all" syntax.
Its regexp is .*, which does not match \n and \r. They should be included, so it can be [\s\S]* instead (to match any character), or (.|\n|\r)* at least
Should I send the PR?

@christopherthielen Should I send the PR? Works well in our app

Yes, please send a PR. The PR does not need a toggle. Let's process multi line by default and if people complain, we can add a toggle later.


Application crash when using Ammo

An application crashes, when using Ammo. This is due to setting a JS Function in Wasm, which expects a WebAssembly.Function:
https://github.com/playcanvas/engine/blob/eba06683346ede7a2932c5e58fbff85a0308f33a/src/framework/components/rigid-body/system.js#L386-L388
To repro:

open engine examples, Vehicle
place a breakpoint at above line in the rigidbody system
refresh and once stopped at breakpoint, enable pause on caught exceptions
resume execution

Another repro option:

open engine example, Vehicle
click the code refresh button

Unfortunately, WebAssembly.Function is in stage 3 proposal today, and cannot be used now without browsers using special flags. There is a workaround of compiling a small module that transforms a function into WebAssembly.Function, but not sure we should go that way. This should be addressed, once the proposal lands to WebAssembly:
https://github.com/WebAssembly/js-types/blob/main/proposals/js-types/Overview.md#addition-of-webassemblyfunction

Actually the second crash might be related to instance reload, not sure. Didn't investigate deeply. I will create another issue.


np.array(x), where x is a tuple or list of tensor(s), is unusable (eager execution)

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Ubuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
No
TensorFlow installed from (source or binary):
Source
TensorFlow version (use command below):
b'v1.12.0-5845-g764109a352' 1.12.0
Python version:
3.6.7
Bazel version (if compiling from source):
Invocation ID: 42251854-036f-415c-8a52-76aac8520ea0
Build label: 0.21.0
Build time: Wed Dec 19 12:58:44 2018<PHONE_NUMBER>)
GCC/Compiler version (if compiling from source):
gcc (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0
CUDA/cuDNN version:
Cuda compilation tools, release 10.0, V10.0.130
GPU model and memory:
GTX 1060 Max Q, 6gb VRAM

Describe the current behavior
If x is a list of any size, or a tuple of size >= 2, which contains tensors, np.array(x) is unusable as it runs exponentially longer than the tensor.numpy() function.
Describe the expected behavior
np.array(x) should run in a reasonable amount of time. Doing a simple list comprehension with tensor.numpy() shouldn't be faster.
Code to reproduce the issue
This shows the exponential time difference when x is a list containing a single tensor.
import numpy as np
import tensorflow as tf
import time

tf.enable_eager_execution()

x = [tf.zeros((32, 32, 12))]

start = time.time()
print("temp")
temp = np.array(x[0:1])
end = time.time()
print(end - start)

start = time.time()
print("temp1")
temp1 = np.array([x[0]])
end = time.time()
print(end - start)

start = time.time()
print("temp2")
temp2 = np.array([x[0].numpy()])
end = time.time()
print(end - start)

start = time.time()
print("temp3")
list = []
[list.append(t.numpy()) for t in x]
temp3 = np.array(list)
end = time.time()
print(end - start)

Other info / logs
Output:
temp
1.7468986511230469
temp1
1.7278409004211426
temp2
0.00018978118896484375
temp3
0.00024890899658203125
However, strangely enough, the problem only occurs with tuples when the length of the tuple is 2 or more. Changing x to the line below and running the same code generates similar results.
x = (tf.zeros((32, 32, 12)), tf.zeros((32, 32, 12)))
Why is it faster for me to use a list comprehension with t.numpy(), appending it to a list, and then run np.array(list), than it is to run np.array(x)?

FYI my numpy version is 1.16.0

@akshaym this is weird, do you have time to take a look?

Thanks for the report!
Based on reading some code, numpy special cases objects that are already np.arrays when converting sequences to python (code reference: https://github.com/numpy/numpy/blob/dea85807c258ded3f75528cce2a444468de93bc1/numpy/core/src/multiarray/ctors.c#L453) and there doesn't seem much we can do on the TF side to get around this.
Numpy does provide an API to allow this to be slightly faster (the tensor is iterated twice, one of which is to discover the shape - and that can be easily fixed by EagerTensor implementing numpy's array interface).
This is still not really ideal though, since when iterating through a tensor item by item, we create a bunch of temporary tensors. Your best bet is to continue to convert the individual tensors to numpy in the list, or to use something like tf.stack(x).numpy() instead.

Thanks for looking into this! I guess I will avoid this function in the future for this use case.


Make HttpClient properly overridable

Description
Currently it's not possible to properly override the protected HttpClient property of BotFrameworkAdapter in a subclass, since BotFrameworkAdapter is referencing it's private _httpClient member (which the property intends to be a wrapper of) in numerous places.
Specific Changes
Turn HttpClient into an auto property, making it properly overridable.

Closing this, since I just realized that in order to achieve what I want (proper HttpClient usage, provided by IHttpClientFactory), this is not enough, but the whole BotFrameworkAdapter class needs to be rearchitected, so it can be registered with transient lifetime, not just as a singleton...


TextEdit respects content margin from StyleBox

TextEdit adjusts x & y offset according to the corresponding StyleBox when in normal or read-only mode.
The x offset from normal style is already applied in any case so it has to be substracted when calculating the x offset in this part of code.
Now TextEdit acts the exact same way as LineEdit when it comes to content margins.
Fixes #32867

@RandomShaper Could you please check again? I've just added a change to draw only visible lines, in order to respect the bottom margin as well. before it was drawing the text for wrapped lines as well even if not visible.

@pouleyKetchoupp TextEdit needs to use draw_amount as when smooth_scroll is enabled, we could be half way down a line, in this case we need to draw the top half of the next line.
Secondly, adding the wrapped rows for the first line prevents the below from happening:

@Paulb23 Ok, makes sense! I'll find a better way to clip the bottom part when there's a bottom content margin then.

I've reverted my previous change and instead, wrapped lines that are entirely outside the content margin of the stylebox are not drawn, so it still displays partial lines in the cases it did before.
I've also removed the case that adapts x/y offsets to the focused stylebox when focused, because I noticed some discrepancies with mouse clicks when margins are different from the normal style, and changing the whole class to take the focus stylebox into account is a bit too involved for this PR. So for now, it still relies on normal stylebox when focused and ignores specific content margins from the focus stylebox.

In addition to the change I've made from your comment for bottom margin clipping, I've made changes to handle top margin clipping properly.
It's useful when scrolling in the TextEdit in case there's top content margin, and in this case I can't just skip the line ( it would set the wrong color on following lines in some cases), so I'm setting a clipped variable which is used to avoid drawing the characters, caret and other features.
One last thing is I've removed a line at the very end of the line loop: ofs_y += ldata->get_line_descent(line_wrap_index);
It does nothing currently as ofs_y is set on each iteration, but I'd like to make sure it's not supposed to be used for something and would need to be fixed instead.

Thanks!

It's not trivial to cherry-pick, so a dedicated PR would be welcome for 3.2.

@akien-mga Dedicated 3.2 PR here: #46060

As of 3.4.1 Stable, Content Margins of StyleBoxes have been unpredictable in each Node.
Here are two images.  Both are a TextEdit node with a StyleBoxFlat.  The first image is NO Content Margin. The second image is a Top Content Margin of 20.  These are both in the Editor.

The Editor shows a correct applying of Top Content Margin (however, notice that the scrollbar of the second image has shortened both on top AND bottom).
Now, when the app is run, here is how it looks:

I love that the top margin is actually working now.  It used to not work.  However, notice that even though I only set the Top Content Margin, it has been applied to both Top AND Bottom, shrinking it on both ends.  This isn't how it should be.  This should only happen if the Top AND Bottom Content Margin are both set to 20.
Currently, setting the Bottom Content Margin is only changing the scrollbar height, but not the actual content.

@ondesic Open a new issue if it wasn't already reported.

I felt that the title fell under the problem I was noticing with TextEdits, content Margins and Styleboxes.  I am happy to start a new issue, however, 50% of the time when I do, it is closed as a duplicate.  Just trying to avoid that.  I'll create a new issue.


Separate Rooms

How would you do separate chat rooms? I can't find this in the btford-angular-socket documentation.

http://stackoverflow.com/questions/24789769/setting-up-a-socket-io-room-for-a-specific-group-based-on-url-node-js-express


Added support for H2_PRIOR_KNOWLEDGE (HTTP2 without TLS)

To be able to test a smithy client using a local server, it makes a lot of sense to support an option without TLS.
Issue #

Description of changes
The change is required to be able to test a locally generated smithy client with a locally generated smithy server.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thanks for the PR!


add a  Feature : clone and duplicate model from scratch when creating new model from Modelfile to laod to gpu memory

when we create a new_model from BaseModel
ollama does not load model to memory again
he used loaded BaseModel as new model and NewModel does not load as seprate model
we want use two model as sepearate two load both in gpu memory we enough memory

https://github.com/ollama/ollama/issues/7206#issuecomment-2413928300

dupe #7206


Download Behavior

Hi, nice add-on!
I observed some stranger behavior on "download as PNG" feature:
http://vaadin-demos.qqjtxeeuih.eu-central-1.elasticbeanstalk.com:5600/#!pie-chart-download
On Chrome I don't need to make nothing (press the download button), only use second mouse button and use "Save image" option.
On Safari (MacOS 10.12.1) I couldn't download, and demo notifications never disappears.
What is the correct behavior for this example?

Hi,
the download feature is currently under active development in #21 and will be included in release 0.4.0.
The "Save image" option is browser specific and works in Chrome and in Firefox for every html canvas element. I tried the same with Safari and IE 11 but could not see such option. (Tested at http://www.chartjs.org/)
#21 targets a browser independent solution, which I will describe there.
Hope this helps.
BR, Michael

Nice! tks for response


Storyboard ViewControllers?

Instead of the XiB files in your Example app, I tried to create the view controllers in Main.storyboard and connected them to the .h and .m files but, for some reason, when I click the tab bar buttons I can't get to those view controllers. Help please?

Hi @MhTheDev,
Would you have an example of how you're instantiating and setting the controllers from your storyboard?
Thanks!

Hey @ezescaruli thank for your reply! Here's the example: https://github.com/MhTheDev/ESTabBarControllerTest
Xcode is telling me that the screens are unreachable (ViewControllers in Main.storyboard) but I don't know what to do! If you run the app, the labels won't show. Help?

Hi @MhTheDev,
The issue is that the view controllers are being instantiated this way:
[[SearchViewController alloc] init];

But that doesn't use the storyboard to create them. In your case, you should first give your view controllers a Storyboard ID using the Identity Inspector:

And them instantiate the view controller using that ID. For example:
SearchViewController *searchViewController = [[self storyboard] instantiateViewControllerWithIdentifier:@"Search"];
[tabBarController setViewController:searchViewController atIndex:0];

Try that and see how it goes.
Cheers,
Ezequiel

Hey @ezescaruli ! Thank you for your help! It works just perfect! Just for the note, your TabBarController is awesome.

But how about to add this in your README ? Or maybe everyone but me knows this?

@MhTheDev I think it's a pretty standard way of instantiating a view controller, so let's not add it for now ;)

@ezescaruli So yeah, just exactly what I thought of. Everybody knows it but me. Anyway thanks again.

@MhTheDev That's not a problem, man! We are all learning here ;)

@ezescaruli That's true, we're all learning! :)


file.filename is required even when providing url

Hi,
iv'e been trying to send an email with an inline image,
as the documentation states i should do
email.addFile({
                url: image,
                cid: 'customer-image-url'
            });

however this didnt work and the image was not attached,
when debugging sendgrid.js iv'e noticed that form.files was form.files[undefined] (sendgrid.js line:97)

Hello @id0Sch,
This functionality has changed in the new version of this library, which is set to get out of beta in a few weeks. Here is an example using the new library: https://github.com/sendgrid/sendgrid-nodejs/blob/v3beta/examples/helpers/mail/example.js#L67
With Best Regards,
Elmer


Ambiguity in Hexagonal wrap 10x10 756

In the 10x10 hexagonal wrap puzzle 756 there is an ambiguous section.
Here is the nearly finished puzzle with the ambiguous area unfinished: nearly done 756.

Oops, looks like you're right. Thanks for reporting!
I'll check how the generator sneaked this in :/.

Seems like there's a bug in my solver that causes it to miss this kind of ambiguities. Here's an example of a 3x3 non-wrap puzzle with the same pattern. The solver reports a single solution in this case too but it's clear that the right side could go two ways =(.

I'll need to dig in to see why this happens.

I have found the bug. It looks like 528 puzzles out of 12000 total were affected. Most of the affected puzzles have two solutions with an occasional 3 or 4. Here's an example of a fun spot that produces three different solutions:

I'm going to replace some tiles in the affected puzzles to enforce a unique solution.
Thanks so much for bringing this to my attention! I played a whole lot of the puzzles and never noticed =).

Ok, on a more accurate count this concerned about ~260 wrap puzzles. All the non-wrap ones were fine.
I have replaced some tiles in the affected puzzles to remove the ambiguity. Number 756 now looks like
this (with the same four tiles left unlocked).
Hopefully there are no more puzzles with multiple solutions but if you notice any please open a new issue.


Get Meeting Timer

Hello sir, please i would love to get the timer of the meeting so as to be able to track the number time user spend on meeting?

Hey @zionnite,
I am sorry, but I will not implement this on my own atm. Feel free to create a PR, though.

I didn't get any events to get time for a meeting when it ends in  jitsi_meet SDK itself. Hope this answer may help others. If anyone knows the information feel free to give suggestions.
Handle your own timing when the meeting joins and ended in listeners.
Thanks.


Fixed bug with dividers in ListView

https://github.com/ksoichiro/Android-ObservableScrollView/issues/219

Thank you for PR! I confirmed the issue and this fix looks good to me.


Develop cleaned up names for fields in the Expenditure model and map them to the loader

Working on this today

Looks like the expenditure model loads correctly now. The next step is including expenditure data from forms 496 and 498

Landed!


fix: LOPS-280: UI changes for Data Explorer are also affecting Data Manager

PR fulfills these requirements

[x] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
[ ] Tests for the changes have been added/updated (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[ ] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
[x] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)
(check all that apply)

[ ] Product design
[x] Frontend

Describe the reason for change
while new UX FF was off - the action button callbacks were not being used correctly
What does this fix?
(if this is a bug fix)
What is the new behavior?
(if this is a breaking or feature change)
What is the current behavior?
(if this is a breaking or feature change)
What libraries were added/updated?
(list all with version changes)
Does this change affect performance?
(if so describe the impacts positive or negative)
Does this change affect security?
(if so describe the impacts positive or negative)
What alternative approaches were there?
(briefly list any if applicable)
What feature flags were used to cover this change?
(briefly list any if applicable)
Does this PR introduce a breaking change?
(check only one)

[ ] Yes, and covered entirely by feature flag(s)
[ ] Yes, and covered partially by feature flag(s)
[ ] No
[ ] Not sure (briefly explain the situation below)

What level of testing was included in the change?
(check all that apply)

[ ] e2e
[ ] integration
[ ] unit

Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

/git merge master


feature: get random quote from author slug

One file changed:
M: /src/controllers/quotes/randomQuote.js
Allows you to make a query from a random quote using the author slug as opposed to the author's ID or full name.

First, thanks for submitting a PR!

So just clarify, the goal is to be able to filter random quotes by author, using the author slug field (as oppose to the author name or _id).
Example
Get a random quote by A. A. Milne
GET /random?authorSlug=a-a-milne

I think this is a great idea! Ultimately I am planning to add an authorSlug field to quotes which will be included in the API response. This will make it easier to get details about an author from a quote or vice versa.
Once we add the authorSlug field,  it will be possible to filter by slug without first querying the author. But I'm fine with merging this now and then making that change later.
Have you already tested this locally to make sure it works?

Yeah, that is the idea!
It works locally as shown in the below screenshot

Changes have been deployed 🚀 Thanks for the contribution. I will update the docs later.


Creating a deep vs shallow copy of an object in Java

This PR contains the supporting repositories for the following eval article.
https://drafts.baeldung.com/?p=202858&preview=true
And there are two projects available;

object_copy - This has a spring-boot application which is specifically used for examples in the article.
deep_vs_shallow_copy - This is a standard Java project will Unit tests, which is easy to understand.

retest this please


feat: Allow hiding warnings

Fixes
Checklist

[x] I acknowledge that all my contributions will be made under the project's license
[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the [Contribution Guide] and my PR follows them.
[x] I updated my branch with the development branch.
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation about the functionality in the appropriate .md file
[x] I have added in line documentation to the code I modified

Description

Allows hiding warnings by using a "hideWarnings" parameter in the Mail class.

Hello @albertor24,Thanks again for the PR! We want to show our appreciation by sending                                              you some swag. Could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX

Hello, any idea when this will land on a release? We have our logs full of these warnings...

@thinkingserious Any estimation for when this will get released ? This a pretty annoying thing, it breaks our log processor as it's not using our logger but a "dirty" console.warn...

Hello @thinkingserious
Any idea when this will land? We have been waiting for months now having to manually set the sendgrid-helpers version to 6.3.0 in yarn.lock to avoid dirty logs!
Is there anything that still needs to be done before this can be released?

Is this merged yet? It fills my logs with error and triggers my monitoring alerts :(

Bah, I just spent a while trying to figure out why the hideWarnings options was not available in the latest version from npm. Bump for a soon release please! Thanks!

hey @childish-sambino @thinkingserious is this fixed ?

@Wtrapp Yes.

What version? @childish-sambino I'm using "@sendgrid/mail": "^7.0.0" with nodeJS and still getting the errors/warnings.
Content with characters ', " or & may need to be escaped with three brackets {{{ content }}} See https://sendgrid.com/docs/for-developers/sending-email/using-handlebars/ for more information.
Thanks for the quick response.

Should've been in 6.5.0. Are you passing the hideWarnings property? https://github.com/sendgrid/sendgrid-nodejs/blob/master/docs/use-cases/hide-warnings.md

Of course I was not passing that property otherwise it would have been working perfectly.
Easy fix. Working great now. THANK YOU!!!


Umbrella Features ☂

Details
Opening this issue so we can coordinate development in this library in order to build all the missing features for full SCA using Stripe. The goal is to add all the missing pieces to the library for the 1st of September.
@viktorasl let me know what you think of the following API:
// Setup Intent
setupPayment(clientSecret, cardDetails)
// Using card details on the fly
confirmPaymentWithCard(clientSecret, cardDetails)
// Using existing card
confirmPaymentWithId(clientSecret, paymentMethodId)

Tasks

[ ] Setup Intents on iOS
Setup intents is almost the same setup on iOS as the payment intents, we need to pass card details through to the native side, support billing details, and return a card object on successful creation.
[ ] Payment Intents Support ID on iOS
Currently the payment intents only supports taking an object of card details. We can modify this function to make cardParams optional and add a parameter called paymentMethodId, depending on which parameter is present, we can create the STPPaymentIntentParams. This will allow us to confirmPayment with card details or an existing card.

The same above is true for Android:

[ ] Setup Intents on Android

[ ] Payment Intents Support ID on Android
Change this function here to support optionally either cardParams or paymentMethodId.

[ ] TypeScript API

If I have missed any important features, please let me know in the comments.

Hey guys, Amogh here. Worked with @lukebrandonfarrell on the native Android aspect of our version of this library, would be cool if we could continue developing it and be able to launch it as a production-level alternative to tipsi-stripe 😄

Looks great! Generally I'm iOS developer so if you have less resources regarding iOS development I can help.
As production ready as tipsi is will be hard to implement as there are quite a lot of edge cases and extra functionalities build around Stripe (i.e fraudulent activity middleware) 😄
But I believe this library can find it's niche in the market 👍

@viktorasl Sounds good. We have the iOS implementation already done in Swift, so just need to make the conversion. I'll attach you in to review the PR for iOS side.
As for a note to myself, we need to support Diners Club cards which our native implementation has trouble with at the moment.

Finished the implementation over at: https://github.com/aspect-apps/react-native-stripe-payments (@viktorasl) will make a PR in next week.


Display File System Stats

Display the following:
-total filesystem size in bytes
-size available for files (used)
-size available for files (unused)
-amount of space currently used
-number of possible files and directories (# of inodes)
-number of existing files
-number of existing directories
-number of block groups, w/ info for each block group
-block size in bytes
-state of the filesystem

Is size available for files (used), same as: amount of space currently used?
Don't think so, but we'll roll with it.

State of the filesystem? Sure.

DONE


libdsp: Add average filter

Summary
Add average filter
Impact
None
Testing
N/A

Thank @xiaoxiang781216, @pkarashchenko and @raiden00pl
In fact just after submitting it I released some of those issues: it cannot be used by more than 1 user/program; it didn't have a way to restart the average; it was not re-entrant and probably wasn't thread-safe as well.

I think "prev_avg = avg" is making no sense, because it will be lost as the function leaves.
Does it make sense to pass float "*prev_avg, float *k" ? This way the use don't need to remember to update prev_avg and k. Just need to create the original variables with prev_avg = 0 and k = 1.

It's better to pack the filter's internal data into a structure:
struct filter_avg_data_s
{
   float prev_avg;
   float k;
};

then it's easier to organize several filters working in the same place in the code:
struct filter_avg_data_s filter1;
struct filter_avg_data_s filter2;

// initialization
filter_avg_data_init(&filter1, k=1.0f);
filter_avg_data_init(&filter2, k=1.0f);

// feed with data
filter_avg(&filter1, val=1.0f)
filter_avg(&filter2, val=1.0f)


markdown documentation quick reference in editor?

a link to markdown documentation or quickreferencepage in the editor with common markdown markup would be handy for non-fluent-markdown-writers.

Hi,
i have a video that will not play in the extension. After some searching i found that Windows Film (W10) says it needs a codec MPEG-H Part2/HEVC (H.265) (hevc) which should not be installed in Windows.
My question, Does the extension use Windows-codecs or its own codecs.
The video was made with a rather new dashcam.
Regards,
Jan

Hi,
TagSpaces use the codecs integrated in the underlying Electron/Chromium infrastructure. So if you can play a given files format in a recent Chrome browser, it should also by playable in TagSpaces.
Greeting


Module "load" does not load

I cannot understand why the load average module does not show up in my motd while I can see the other modules. I am using the latest raspberry pi os on (of course) a raspberry pi 4B. Is there a way to debug what could be the issue?

Try running the operative portions of the load module line by line, see if everything executed as expected

I noticed that I get this error by giving this command:
forfet@server:~ $ warning_threshold=$(bc -l <<< "$nproc * 0.9")
-bash: bc: command not found
forfet@server:~ $

Could that be the reason?

Install 'bc' with whichever package manager your distribution provides.

@garret Yup, that's exactly the reason. Install bc like @VeKett says and it will work.
I was going to put modules dependencies and a warning that modules will fail silently in the readme but I forgot. Definitely will do it.


Metrics api: get metrics from/until timestamp

Hello,
I am trying to get all metrics from a timestamp, and all metrics until a timestamp, as described in the Metrics API documentation. I expect that only metrics created after/until the given timestamp will be returned. However, the from and until parameters seem to have no effect at the list of returned metrics.
How to use from and until parameters with /metrics/find endpoint?

Unfortunately,  it's not possible in the current codebase. TBH I don't know why from and until parameters present in find call. Theoretically, they can be used in some external finder, but now nor Whisper nor Ceres storage not testing file creation date and not comparing from with it. Also, it will be quite hard to calculate until date for a particular metric - you need to check all archives and find "data edge" - it's can be quite complicated and resource intensive.
So, for now, I would say - it's only present for external storages, in current code it has no meaning.

Thank you for quick reply, @deniszh. Do you have an idea on how to get a list of metrics created in the last X minutes?

You can find that info in carbon.log (looks like ' [creates] creating database file /opt/graphite/storage/whisper/blah.wsp (archive=[(60, 525600), (600, 518400)] xff=None agg=None)') and you can use something like https://github.com/eBayClassifiedsGroup/graphite-news to expose this info.

@deniszh thank you!


Add possibility to remove user from group

As requested by Sylvia.
The possibility to remove toxic people from their group is very important to the EfA people. An idea against abuse is to require multiple users to agree on kicking another one. Another way would be classic admin roles.

 Das würde dann bei uns 2 Vorstandsmitglieder machen…)

Sylvia put emphasis on this again and stated, that it is of vital importance to protect a group from users going rogue. (I have to add that my personal experience with foodsharing Bielefeld also provided a case, in which a user suddenly became toxic and needed to be removed.)
Since not everyone should be able to randomly kick users, this issue touches #550 and #356.
How can we make sure to have groups of equals, while still making sure that destructive individuals cannot bring a whole group to ruin?

We need the possibility to delete a toxic member, to make sure, that he doesn't demage all notes while going mad.
Suggestion: a toxic member can be deleted, if 2 members in charge delete him from the group.

a toxic member can be deleted, if 2 members in charge delete him from the group

Sounds reasonable, though to have "members in charge" it needs a concept of admin roles first (#356), with decisions like "who can add an admin" and "who can remove a (toxic) admin" not made yet.
If there's only one admin, the limitation of "2 admins need to accept removal" does not apply. If there's ten admins, it could make sense to require 3 or more approvals. Also, should we take "veto" among admins into account? To avoid adverse effects of "veto", a simple systemic-consensus-based system (like https://ukuvota.world) might be good.
That's a lot to implement and will surely take a while, so we should go for a less complex solution first (one that doesn't solve the concerns in my previous paragraph) that can be improved later on. Maybe it could be good to outline some steps...

@djahnie received a request from Foodsharing Poland to remove a member. We didn't act on it, but @nicksellen had the idea to found a karrot.world admin group and define a formal process how users could be removed from groups. This could be a good solution for general admin topics and it might be a relief for affected groups before karrot receives a built-in removal feature.

This is being discussed in #853 so closing this as duplicate.


add await-interactions rule

Issue: #
What Changed
one more for addon-interactions

Checklist
Check the ones applicable to your change:

[ ] Tests are updated
[ ] Documentation is updated

Change Type
Indicate the type of change your pull request is:

[ ] documentation
[ ] patch
[ ] minor
[ ] major

Self merging @shilman


feat: write data to the tree

I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR implements the following features

writes rows to a merge tree
freezes a merge tree
forks a merge tree

Checklist

[ ]  I have written the necessary rustdoc comments.
[ ]  I have added the necessary unit tests and integration tests.
[x]  This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

I decide to change the implementation of the index part.


Add missing properties to packets

Adds epoch to PositionList
Adds outlineColor and outline to Polygon

I didn't add a test for these new properties, yet the Codecov report is says that the added lines are being hit.
It's because all classes initialise all properties (usually to None). For example, from test_polygon_with_hole() the created polygon is:
p = Polygon(
    positions=PositionList(cartographicDegrees=[30.0, 40.0, 1.0]),
    holes=PositionListOfLists(
        cartographicDegrees=[[20.0, 20.0, 0.0], [10.0, 10.0, 0.0]]
    ),
)

Which creates an object with the following properties:
p = Polygon(
    positions=PositionList(
        interpolationAlgorithm=None,
        interpolationDegree=None,
        delete=None,
        referenceFrame=None,
        cartesian=None,
        cartographicRadians=None,
        cartographicDegrees=[30.0, 40.0, 1.0],
        references=None,
        interval=None,
        epoch=None,
    ),
    show=None,
    arcType=None,
    granularity=None,
    material=None,
    shadows=None,
    distanceDisplayCondition=None,
    classificationType=None,
    zIndex=None,
    holes=PositionListOfLists(
        delete=None,
        referenceFrame=None,
        cartesian=None,
        cartographicRadians=None,
        cartographicDegrees=[[20.0, 20.0, 0.0], [10.0, 10.0, 0.0]],
        references=None,
    ),
    outlineColor=None,
    outline=None,
)

All the properties with None values are removed when calling __str__.
It's somewhat deceiving to say that these lines are actually covered despite having no actual checks for them.

Makes sense, thanks for the investigation!


Compatibility with RuboCop v1.0

RuboCop v1.0 is imminent, and looking at this gem there's going to be a few things that might break.
Already the latest release included a change of API for Team that broke things (sorry).
I would like to help with the transition for v1. I imagine that compatibility with older versions of RuboCop is important?

That would be awesome \o/
I might also be able to help since I think I'm the one that tinkered with the RuboCop API the most recently when adding the autocorrect suggestions.
I am not part of the maintainers so I don't know how compatibility with older RuboCop versions is important. Personnally I'd be okay with having the next version of pronto-rubocop only compatible with RuboCop > 1.0.


[5.5] standard deviation added with tests

Ref: https://github.com/laravel/internals/issues/866
Name looks ugly but the same terminology (stddev)  is used in databases. I have also provided an alias for those who consider it ugly (same case as avg())
Have also left out the closure option as suggested in proposal.
Cheers

Note that tests are calling the stdDev method while the method itself and the alias named it stddev. Personally I prefer the former. :tongue:

I'm fine with people just macro'ing this in as needed for now.


Bug in the interaction between the environment and the action?

I tried the minimal_example.py with some other actions, but the interaction seems strange. For example, for the task 156.json, the first action I choose is [xxx] link 'Starred 7' by click [xxx], this first step is ok in the chrome ui; the second action I choose is [yyyy] link 'Explore' by click [yyyy], but this step doesn't seem to worked in the ui; after that, I action again by click [yyyy] and this time it work well and bring me to the 'Explore' page.
I noticed that when the actree_obs head with Tab {idx}, there maybe some problem with the next action. But different action seems have different behavior, some work and others not.
This interaction confuse me a lot.

It seems that in some case the obs["text"] show the whole page (including scroll up and down), instead of the current page.
For example, click link 'The A11Y Project / a11yproject.coma11yproject.contributor.me' in 156.json.

The first problem magically disappeared when I got home, everything was fine even at sleep=1.5. I will check it tomorrow in my office. (⊙ｏ⊙)

The first problem seems to be related to the network environment.

Using my own wifi, problem exist;
Using my own wifi+vpn, work well;
Using my office wifi or (+vpn), problem exist;
Notice that my office wifi seems have it own vpn.

Thanks for the analysis!


PR: Update "aces-dev" to 1.3.

This PR update aces-dev to 1.3. It is only the 1.3_rc2 tag and we should probably wait for the final release before merging but this is to get the ball rolling.
Note that the ACES --> CSC changes are for the pure analytical config that leverages the graph, it is only used to check the state of aces-dev and generate the data for the spreadsheet.
I have updated the spreadsheet accordingly: https://docs.google.com/spreadsheets/d/1SXPt-USy3HlV2G2qAvh9zit6ZCINDOlfKT07yXJdWLg/edit?usp=sharing
New stuff is mostly:

Updates related to the Venice CSC
GamutCompress LMT

Reference Config: https://gist.github.com/KelSolaar/1e2b054080e074e7f3529439470ee643/f114dbf4bbd54726992bca9398341e08240e5b45

Ready to roll!


[Bug] Automatic padding/alignment doesn't work.

Basically what the title says. Automatic padding with a shape doesn't work, automatic alignment and spacing either. Only thing that works is with a shape and text layer (a button, for instance). I've attached a sketch file and a video.
Thanks!
paddy-bugs.zip

I've noticed this as well. It was working for me in the past few day, but seems to have stopped working. Even when going by what the docs are showing.

Yup, the automatic alignment is broken for me too.

Yep, same here. Happened after the last update.

The same here!

Thanks all for letting me know!
I suspect this may be due to something I implemented to stop Paddy from trying to update every time – however, it appears to be too aggressive.
I think I may have a fix in the upcoming release... hang tight!

Can you all check this sneak peak of the next release, and let me know if it works for you now: https://github.com/DWilliames/paddy-sketch-plugin/archive/v1.0.4.zip
It seems to be working for me :P

I just pushed a release (v1.0.4) that should now fix this. 👍
I will close this issue for now, assuming that the fix is stable — if you find that it hasn't been fixed, then please re-open this issue.
Cheers!


HHH-16472 Treated left join with restriction on entity results in incorrect query

https://hibernate.atlassian.net/browse/HHH-16472

Depends on https://github.com/hibernate/hibernate-orm/pull/6484

Depends on #6484

Since that change is now merged I've rebased this PR and adapted the solution to work with the new treat handling.


Aggregate lists of trainable variables from different Keras models in Tensorflow v2

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Colab
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):
TensorFlow version (use command below): 2.1.0-rc1
Python version: 3.6
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

I have two neural networks (e.g., f and g) implemented using tensorflow.keras.Model. I simply want to compute the gradient of f(g(x)). However, I was not able to aggregate the lists of trainable variables of both models.
According to Tensorflow V2 documentations: If you need to aggregate lists of variables (like tf.Graph.get_collection(tf.GraphKeys.VARIABLES)), use the .variables and .trainable_variables attributes of the Layer and Model objects.
I tried to do so but I am getting this weird error:
/content/drive/My Drive/Colab/IIC/IIC.py in train_step(self, x, gx, head)
    197
    198                 gradients = tape.gradient(loss, trainable_variables)
--> 199                 self.optimizer.apply_gradients(zip(gradients, trainable_variables))
    200                 self.train_loss(loss)
    201

/tensorflow-2.1.0/python3.6/tensorflow_core/python/keras/optimizer_v2/optimizer_v2.py in apply_gradients(self, grads_and_vars, name)
    432         _ = self.iterations
    433         self._create_hypers()
--> 434         self._create_slots(var_list)
    435
    436       if not grads_and_vars:

/tensorflow-2.1.0/python3.6/tensorflow_core/python/keras/optimizer_v2/adam.py in _create_slots(self, var_list)
    147     # Separate for-loops to respect the ordering of slot variables from v1.
    148     for var in var_list:
--> 149       self.add_slot(var, 'm')
    150     for var in var_list:
    151       self.add_slot(var, 'v')

/tensorflow-2.1.0/python3.6/tensorflow_core/python/keras/optimizer_v2/optimizer_v2.py in add_slot(self, var, slot_name, initializer)
    572     if slot_name not in self._slot_names:
    573       self._slot_names.append(slot_name)
--> 574     var_key = _var_key(var)
    575     slot_dict = self._slots.setdefault(var_key, {})
    576     weight = slot_dict.get(slot_name, None)

/tensorflow-2.1.0/python3.6/tensorflow_core/python/keras/optimizer_v2/optimizer_v2.py in _var_key(var)
   1063   if hasattr(var, "_distributed_container"):
   1064     var = var._distributed_container()
-> 1065   if var._in_graph_mode:
   1066     return var._shared_name
   1067   return var._unique_id

AttributeError: 'list' object has no attribute '_in_graph_mode'

The trainable_variables is just a list of trainable variables from both models f and g.
trainable_variables = [f.trainable_variables, g.trainable_variables]

@nairouz
Request you to provide colab link or simple standalone code to reproduce the issue in our environment. It helps us in localizing the issue faster. Thanks!

@ravikyram
Here is a toy example:
from __future__ import absolute_import, division, print_function, unicode_literals

import tensorflow as tf

from tensorflow.keras.layers import Dense, Flatten, Conv2D
from tensorflow.keras import Model

mnist = tf.keras.datasets.mnist

(x_train, y_train), (x_test, y_test) = mnist.load_data()
x_train, x_test = x_train / 255.0, x_test / 255.0

# Add a channels dimension
x_train = x_train[..., tf.newaxis]
x_test = x_test[..., tf.newaxis]

train_ds = tf.data.Dataset.from_tensor_slices(
    (x_train, y_train)).shuffle(10000).batch(32)

test_ds = tf.data.Dataset.from_tensor_slices((x_test, y_test)).batch(32)

class StupidModel1(Model):
  def __init__(self):
    super(StupidModel1, self).__init__()
    self.conv1 = Conv2D(32, 3, activation='relu')
    self.flatten = Flatten()

  def call(self, x):
    x = self.conv1(x)
    x = self.flatten(x)
    return x

class StupidModel2(Model):
  def __init__(self):
    super(StupidModel2, self).__init__()
    self.d1 = Dense(128, activation='relu')
    self.d2 = Dense(10, activation='softmax')

  def call(self, x):
    x = self.d1(x)
    return self.d2(x)

# Create an instance of the model
stupid_model_1 = StupidModel1()
stupid_model_2 = StupidModel2()

loss_object = tf.keras.losses.SparseCategoricalCrossentropy()

optimizer = tf.keras.optimizers.Adam()

train_loss = tf.keras.metrics.Mean(name='train_loss')
train_accuracy = tf.keras.metrics.SparseCategoricalAccuracy(name='train_accuracy')

test_loss = tf.keras.metrics.Mean(name='test_loss')
test_accuracy = tf.keras.metrics.SparseCategoricalAccuracy(name='test_accuracy')

@tf.function
def train_step(images, labels):
  with tf.GradientTape() as tape:
    predictions = stupid_model_2(stupid_model_1(images))
    loss = loss_object(labels, predictions)
  trainable_variables_list = [stupid_model_1.trainable_variables, stupid_model_1.trainable_variables]
  gradients = tape.gradient(loss, [stupid_model_1.trainable_variables, stupid_model_1.trainable_variables])
  optimizer.apply_gradients(zip(gradients, trainable_variables_list))

  train_loss(loss)
  train_accuracy(labels, predictions)

@tf.function
def test_step(images, labels):
  predictions = model(images)
  t_loss = loss_object(labels, predictions)

  test_loss(t_loss)
  test_accuracy(labels, predictions)

EPOCHS = 5

for epoch in range(EPOCHS):
  # Reset the metrics at the start of the next epoch
  train_loss.reset_states()
  train_accuracy.reset_states()
  test_loss.reset_states()
  test_accuracy.reset_states()

  for images, labels in train_ds:
    train_step(images, labels)

  for test_images, test_labels in test_ds:
    test_step(test_images, test_labels)

  template = 'Epoch {}, Loss: {}, Accuracy: {}, Test Loss: {}, Test Accuracy: {}'
  print(template.format(epoch+1,
                        train_loss.result(),
                        train_accuracy.result()*100,
                        test_loss.result(),
                        test_accuracy.result()*100))

It is not a bug!!
I am sorry.

It is not a bug!!
I am sorry.

If it is not a bug, then what is the preferred way to solve this? I have  a similar case.
Calling apply_gradients() twice, once for every model with its own trainable variables, does not give an error but might be wrong since the optimizer keeps internal state. Another solution would be to create two optimizers, one for every model, and then call apply_gradients separately for every model.
Again, what is the preferred solution here if it is not a bug?

If it is not a bug, then what is the preferred way to solve this? I have a similar case.
Calling apply_gradients() twice, once for every model with its own trainable variables, does not give an error but might be wrong since the optimizer keeps internal state. Another solution would be to create two optimizers, one for every model, and then call apply_gradients separately for every model.
Again, what is the preferred solution here if it is not a bug?

The list of trainable_weights might be [list of variable], instead of [[list of variable], [list of variable]].


ARM should reject unknown properties and values

Per
https://armwiki.azurewebsites.net/api_contracts/guidelines/openapi.html#oapi018-reject-unknown-properties-and-property-values
Should the generated marshallers reject unknown properties/values?

I could imagine this being quite undesirable in our SDKs as used by customers (receiving data from us), but useful when we use the same SDKs server side (receiving data from customers).  It'd need to be an option.

We discussed that some time ago @jhendrixMSFT.
This request was in particular because we want to reuse the SDK types on server side. it handles a lot of the quircks of the Azure specific formats in the SDK, so it's nice to take advantage of it.
it also ensure that our swagger spec generates what our service needs, and that the types are exactly the same as what the SDK creates. It allows to stop worrying about some small incompatibilities that have been experienced when hand-rolling the server types.
We generate our types by calling autorest (not by importing the SDK). so server side types options would make sense.
From my earlier analysis, it would be very simple, as the current unmarshaller goes via a map.
if there is anything left in the RawMessage at the end, it means it didn't match a property on the target type, and we can error.
if you have an idea on how to build that as a plugin, that's ok. but I think considering how simple this addition would be inside the Unmarshal implementation, it makes more sense to have it built-in as an option.

I'd also note that we're happy to give it a go with some help if you think this makes sense.

Had a closer look, I think it's even simpler than this, we might just need to add a default case in the switch statement
// UnmarshalJSON implements the json.Unmarshaller interface for type ErrorResponse.
func (e *ErrorResponse) UnmarshalJSON(data []byte) error {
	var rawMsg map[string]json.RawMessage
	if err := json.Unmarshal(data, &rawMsg); err != nil {
		return fmt.Errorf("unmarshalling type %T: %v", e, err)
	}
	for key, val := range rawMsg {
		var err error
		switch key {
		case "error":
			err = unpopulate(val, "Error", &e.Error)
			delete(rawMsg, key)
		default: // Unexpected key
			err = fmt.Errorf("unknown key for type %T: %q", e, key)
		}
		if err != nil {
			return fmt.Errorf("unmarshalling type %T: %v", e, err)
		}
	}
	return nil
}

ah, the default case would clash with the handling of special AdditionalProperties
 if (addlProps) {
    unmarshalBody += '\t\tdefault:\n';
    unmarshalBody += emitAddlProps('\t', addlProps);
  }


Rendering Quality is not good

Hello @vye16 , thanks for your amazing work. I tried to run code following the steps (both for preprocessing and training) on a cat video from Banmo. I tried to obtain the rendering video using ''lemniscate'' trajectory but the quality is not good. Here is the video. I am not sure what is going wrong?
https://github.com/user-attachments/assets/06d852a6-2efe-4666-b248-d4f2b0bac6ed

Hi, this can happen if the rendering trajectory is too far away from the training views, and depending on how the training cameras and depth maps look. A better way to debug is to run the rendering script
python run_rendering.py --work-dir [WORK_DIR]
to interactively view the trained model.

@DevikalyanDas Did you get the video using run_video.py? I am trying to try  som on nvidia-long dataset. I have already done the preprocess and train, got the custom dataset and ckpt. I am trying to get the rendering videos. Could you please tell me how did you made it?
Thank you!

@CTouch Yes I got the video using run_video.py. As far as I remember, the script was already working except for some changes in the dataloader for running the custom videos and you also have to provide the type of trajectory that you want to perform during rendering as commandline arguments. I think if the script is working for training the custom videos then it will work for rendering also.

@CTouch Yes I got the video using run_video.py. As far as I remember, the script was already working except for some changes in the dataloader for running the custom videos and you also have to provide the type of trajectory that you want to perform during rendering as commandline arguments. I think if the script is working for training the custom videos then it will work for rendering also.

Got it! Thank you!


(PUP-6463) Improved error message when accessing unassigned parameter

A parameter default expression that made an attempt to access a
parameter to the left in the parameter list when that parameter in turn
was unassigned, resulted in an error message "$y tries to illegally
access not yet evaluated $x". That message should only be used when
accessing parameters to the right. An access to an unassigned parameter
to the left should result in the same message as when a required
parameter is unassigned. This commit fixes that.

This is supposed to go to stable branch - otherwise fine to merge.

CLA signed by all contributors.

Superseded by PR-5078.


[OPIK-63] [New feature] Add segment to Opik Cloud

Details
Issues
Resolves #
Testing
Documentation

Small comment for your consideration (but not to block the PR), technical users like ours generally use adblocks with the rate of 30-50%, and adblocks block the segment domain.
We could get much better success if identify and trackEvent methods send the data to our own backend, and the backend sends it to Segment.
A second aspect would be the name of the backend route – if you avoid something like /analytics or /track but rather call it something inconspicuous, you can avoid even more rules in adblocks.

Small comment for your consideration (but not to block the PR), technical users like ours generally use adblocks with the rate of 30-50%, and adblocks block the segment domain.
We could get much better success if identify and trackEvent methods send the data to our own backend, and the backend sends it to Segment.
A second aspect would be the name of the backend route – if you avoid something like /analytics or /track but rather call it something inconspicuous, you can avoid even more rules in adblocks.

Thanks for your input here. We have the same functionality right now for the main app. So we can change it together in the future


App Crash on Pull Service (same reason as LoggingService crash)

Crash is observed on pull service.

Did the commit you make resolve the issue?
I pulled it in, because it doesn't break things, but I noticed you added the boolean state update in
onHandleIntent and onDestroy
onHandleIntent does not get called (at least on my phone)
onDestroy in general is not guaranteed to be called
https://stackoverflow.com/questions/4449955/activity-ondestroy-never-called
So we shouldn't be updating states in there.
Anyway that boolean state is updated outside the service too.

@justinklchan : I think i didn't the way service is being, let me investigate. But this is how we should manage intentservices. What that stackoverflow refers to is activity onDestroy, which is not expected to be called always. here we are referring to intent services https://developer.android.com/reference/android/app/IntentService#onDestroy()

@justinklchan : Constants is not the right way to manage a service state.  I see it is being called for me.

@

Ok I fixed the issue of onHandleIntent not always being called in a commit.


how to use plugin block bootstap

how to use bootstrap plugin block?

Hi @baihaqyaviq! For now there is no option for adding plugin.

please add this option

Hopefully will work on it in next one or two weeks.

i have idea for change layout with grapesjs
Suppose we have a special order in a blade and we want to change it with grapesjs page builder

i have idea for change layout with grapesjs Suppose we have a special order in a blade and we want to change it with grapesjs page builder

Blade content already is changeable with page build via templates.

Hi @baihaqyaviq, The bootstarp4 plugin option was added in the latest release. please see v3.1.0


⚠ Samsung has degraded performance

In a16da00, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2095 ms

Resolved: Samsung performance has improved in c06c0a8.


Add concepts to restrict Ultra-only primitives (for example aes) to Ultra

We need to add mechanisms to disable compilation for methods in stdlib that should only be used with ultra (for example aes's encrypt_buffer_cbc)

We could use a requires clause like we do here
https://github.com/AztecProtocol/barretenberg/blob/57af751646dc3c038fea24ada4e160f6d422845f/cpp/src/barretenberg/srs/io.hpp#L326
with the concept HasPlookup that already exists.


[$250] Composer - Composer is not in focused when switching chat

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.81-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: exploratory
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:  Applause internal team
Slack conversation:
Action Performed:

Go to staging.new.expensify.com/
Switch between chats

Expected Result:
The composer will be in focused when switching chat
Actual Result:
The composer is not in focused when switching chat
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/43996225/5d6c5978-bcb5-49ab-af95-3af483a90301

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ec9e11187ff9476c
Upwork Job ID:<PHONE_NUMBER>783128752
Last Price Increase: 2024-06-10

Issue OwnerCurrent Issue Owner: @parasharrajat

I reproduced on staging v1.4.81-4

Commit no #9f7ea101a3 has introduced this bug when useOnyx is used instead of  withOnyx

Commit no #9f7ea101a3 has introduced this bug when useOnyx is used instead of withOnyx

This seems to be just a commit to merge main. I reverted the associated PR and it did not fix the issue.
I looked into several PR's and couldn't find the culprit. I also looked through the Composer component tree and didn't spot anything obvious. Logging off now but I'll continue looking into it tomorrow if needed.

Fixed on staging. Closing

Fixed by https://github.com/Expensify/App/pull/43431
Discussed here: https://expensify.slack.com/archives/C01GTK53T8Q/p1718054675083139?thread_ts=1718054237.611609&cid=C01GTK53T8Q


Remove noImplicitAny and add types to params

This isn't ready yet, but wanted to show what is done so far.  I turned on noImplicitAny in tsconfig.json and went through all of the files that needed types in parameters.  There were a couple I put any because I couldn't tell what they were exactly (such as https://github.com/szeck87/probot/blob/enable-noimplicitany/src/github/pagination.ts#L11).  Three files still need work.  I could use some guidance on:

src/github/pagination.ts:  responsePromise.  It doesn't like a type of AnyResponse or Promise<AnyResponse in the callbacks, so not sure what to use there.
src/middleware/log-request-errors.ts:  req, res, and next
src/middleware/logging.ts:  req, res, and next, as well as the logger bind.

Thanks @ocombe!  @tcbyrd @bkeepers can you take a look over this?  Especially the files under middleware, since I created interfaces as it was custom code borrowed from https://github.com/vvo/bunyan-request, and the promise-events type under @types/promise-events/index.d.ts.
I'm still having issues with responsePromise in github/pagination.ts.  It looks like it should be Promise<AnyResponse> but the thenproperty is missing inAnyResponse` for the callback.

@bkeepers I rebased from master to resolve the conflicts.  I'm not sure why application.ts is showing as a changed file here, but it's the same as master.

Thanks @szeck87!


MONDO:####-obsoleted used for source

(there is probably another issue with this, but I couldn't find it)
What are "MONDO:####-obsoleted" used for source?
What do they represent?
Eg: MONDO:0013626 - 'psoriasis 14, pustular'

is_a ‘epidermal disease’ [source: MONDO:0019274-obsoleted]
is_a ‘skin disorder’ [source: MONDO:0019275-obsoleted]

It looks like they are often the source of bad classification for example:

Do we need these sources? Can we remove them?
Can/should we remove the whole axiom if the only source is a MONDO:###-obsoleted?

@cmungall
(CC @nicolevasilevsky )

from the call on March 2nd, 2023 :
these MONDO:###-obsoleted are keeping track of Mondo terms that were obsoleted.
We should query to see how many of these sources we have and assess whether it would make sense to remove these sources.
We could also remove the axiom with only MONDO:###-obsoleted as source and check whether we end up with orphan terms. (this would help with the error in classification as shown in the comment above)

you will specifically see these where the obsolete was an intermediate and
the axioms were rewired
On Thu, Mar 2, 2023 at 6:49 PM sabrinatoro @.***> wrote:

from the call on March 2nd, 2023 :
these MONDO:###-obsoleted are keeping track of Mondo terms that were
obsoleted.
We should query to see how many of these sources we have and assess
whether it would make sense to remove these sources.
We could also remove the axiom with only MONDO:###-obsoleted as source and
check whether we end up with orphan terms. (this would help with the error
in classification as shown in the comment above)
—
Reply to this email directly, view it on GitHub
https://github.com/monarch-initiative/mondo/issues/6004#issuecomment-1452879062,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAMMONLGWVAQBIVIFDL5O3W2FL2TANCNFSM6AAAAAAVNZZOX4
.
You are receiving this because you were mentioned.Message ID:
@.***>

we don't need to keep these IDs but we should review these superclasses first.

discussed on the curation call on 2024-04-04:
Decision

We will remove all of the superclass assertions that have MONDO:XXXXXXX-obsoleted

in cases where there is only on superclass assertion that has the source MONDO:XXXXXXX-obsoleted, we will review these and manually add a new superclass

We will remove all of the relationship: excluded_subClassOf annotations that have MONDO:XXXXXXX-obsoleted

To do's

[ ] @twhetzel please write a script and generate a report that shows:

all of the classes that have a superclass where the source is only MONDO:XXXXXXX-obsoleted (eg is_a: MONDO:0005093 {source="MONDO:0018798-obsoleted"} ! skin disorder (on MONDO:0007118).

[ ] Nicole will review these and confirm it is okay to delete these.
[ ] Next, @twhetzel write a script to delete all of these superclass assertions

of these classes above, we need a list of the classes where these superclasses are the only superclass for that term.

[ ] In these cases, Nicole will manually review these and add new parents

See example below:
[Term]
id: MONDO:0007852
name: palmoplantar keratoderma-deafness syndrome
def: "Palmoplantar keratoderma-deafness syndrome is a keratinization disorder characterized by focal or diffuse palmoplantar keratoderma. A patchy distribution is observed with accentuation on the thenars, hypothenars and the arches of the feet. The disease becomes apparent in infancy and is associated with sensorineural hearing loss that shows a variable age of onset. Due to genetic and clinical similarities, it has been proposed that palmoplantar keratoderma-deafness syndrome, knuckle pads-leukonychia-sensorineural deafness-palmoplantar hyperkeratosis syndrome and keratoderma hereditarium mutilans may represent variants of one broad disorder of syndromic deafness with heterogeneous phenotype. The disease is transmitted in an autosomal dominant manner with incomplete penetrance." [Orphanet:2202]
subset: gard_rare {source="GARD:3094"}
subset: nord_rare {source="MONDO:NORD"}
subset: ordo_disease {source="Orphanet:2202"}
subset: orphanet_rare {source="Orphanet:2202"}
subset: rare
synonym: "diffuse palmoplantar keratoderma with deafness (subtype)" RELATED [GARD:0003094]
synonym: "focal palmoplantar keratoderma with sensorineural deafness (subtype)" RELATED [GARD:0003094]
synonym: "hereditary palmoplantar keratoderma with deafness (subtype)" RELATED [GARD:0003094]
synonym: "keratoderma palmoplantar deafness" RELATED [GARD:0003094]
synonym: "keratoderma palmoplantar, with deafness" RELATED [GARD:0003094]
synonym: "keratoderma, palmoplantar, with deafness" RELATED [OMIM:148350]
synonym: "palmoplantar hyperkeratosis-deafness syndrome" EXACT [Orphanet:2202]
synonym: "palmoplantar hyperkeratosis-hearing loss syndrome" EXACT [Orphanet:2202]
synonym: "palmoplantar keratoderma and sensorineural deafness" RELATED [GARD:0003094]
synonym: "palmoplantar keratoderma-hearing loss syndrome" EXACT [Orphanet:2202]
synonym: "PPK-deafness syndrome" EXACT [Orphanet:2202]
xref: DOID:0111505 {source="MONDO:equivalentTo"}
xref: GARD:3094 {source="Orphanet:2202"}
xref: ICD10CM:Q82.8 {source="Orphanet:2202/attributed", source="Orphanet:2202/ntbt", source="Orphanet:2202"}
xref: MESH:C536152 {source="Orphanet:2202", source="MONDO:equivalentTo", source="Orphanet:2202/e"}
xref: OMIM:148350 {source="Orphanet:2202", source="MONDO:equivalentTo", source="Orphanet:2202/e"}
xref: Orphanet:2202 {source="OMIM:148350", source="MONDO:equivalentTo"}
xref: UMLS:C1835672 {source="OMIM:148350", source="Orphanet:2202", source="MONDO:equivalentTo", source="MONDO:ncbi_mim2gene_medline", source="Orphanet:2202/e"}
is_a: MONDO:0017666 {source="MONDO:0020094-obsoleted"} ! diffuse palmoplantar keratoderma
relationship: has_material_basis_in_germline_mutation_in http://identifiers.org/hgnc/4284 {source="MONDO:mim2gene_medgen"} ! GJB2
property_value: confidence "3.7222222222222223" xsd:double

there are some cases where there is additional support for the superclass assertion from other sources, such as is_a: MONDO:0031166 {source="MONDO:0020243-obsoleted", source="OMIM:136550", source="https://github.com/monarch-initiative/mondo/pull/2571/"} ! macular dystrophy, retinal (on MONDO:0007630)

[ ] In these cases, we just want to delete the MONDO:XXXXXXX-obsoleted, but leave the other source(s) and the superclass assertion.

in this particular case, the GitHub URL needs to moved to the 'term tracker item' annotation (see below)

The MONDO:XXXXXXX-obsolete  is in a lot of excluded_subclassOf annotations too. Could we please have a list of these in the report

[ ] Nicole will review
[ ] next, @twhetzel should remove exlcuded_subclassOf annotations with only MONDO:XXXXXXX-obsolete

example: relationship: excluded_subClassOf MONDO:0100036 {source="MONDO:0017655-obsoleted", source="https://orcid.org/0000-0001-5208-3432"} ! variable age onset epilepsy (on MONDO:0008045).

There are some cases where the GitHub link is included in the source annotation (eg is_a: MONDO:0018075 {source="MONDO:0017085-obsoleted", source="https://github.com/monarch-initiative/mondo/pull/2571/"} ! neural tube defect (on MONDO:0007316).

[ ] We'd like to clean these up and move the GitHub URL to be a term tracker item annotation (egproperty_value: IAO:0000233 "https://github.com/monarch-initiative/mondo/issues/2571" xsd:anyURI)

based on the last comment, I am assigning to @twhetzel .


MaxUserNameListLength is not considered in UniqueIDJDBCUserStoreManager

Describe the issue:
In getUserListFromProperties() [1] of JDBCUserStoreManager it checks MaxUserNameListLength and limit the result list. But in doGetUserListFromPropertiesWithID() [2], it does not have such a limit and returns all the users on the userstore adding a high load to the WSO2IS as well as the DB.
How to reproduce:

Configure UniqueIDJDBCUserStoreManager
Create a large number of users  (eg: 10,000)
Invoke GET /scim2/Users without a filter
It will take a lot of time to return all the users or thread deaths will occur

Expected behavior:
It should not list more than 100 users
Environment information

Product Version: IS 5.11.0

[1] https://github.com/wso2/carbon-kernel/blob/da05c14dda09db58954411f4c0b3fafc6ba34794/core/org.wso2.carbon.user.core/src/main/java/org/wso2/carbon/user/core/jdbc/JDBCUserStoreManager.java#L2992-L3080
[2] https://github.com/wso2/carbon-kernel/blob/da05c14dda09db58954411f4c0b3fafc6ba34794/core/org.wso2.carbon.user.core/src/main/java/org/wso2/carbon/user/core/jdbc/UniqueIDJDBCUserStoreManager.java#L2314-L2380

We have used UserCoreConstants.MAX_SEARCH_TIME as the default value for PROPERTY_MAX_USER_LIST in the above PR(s). Which needs to be updated with the correct constant.

Reducing the severity level since the actual fix has been done

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Is there a Rust of this interface document?

https://robocode-dev.github.io/tank-royale/api/apis.html

There is no Rust implementation yet. But it is possible to communicate via the protocol over a WebSocket.
Schemas in JsonScema/YAML have been provided for the JSON messages that sent between the server, bots, and observer/controllers. And there are also sequence diagrams over, how the communication works:
https://github.com/robocode-dev/tank-royale/blob/main/schema/schemas/game/README.md


Allow using a custom base image for docker builds

Reason: Custom resolvers that are usually added in our CI pipeline before sbt starts, as well as adding certificates. This change allows me to build a base image with all that myself and use it to build the scala-steward docker image that'll work in my gitlab org.
Let me know if the name needs changing or there's anything else wrong with this ;)

I find the name a tad too generic. Maybe DOCKER_BASE_IMAGE would be more descriptive? Apart from that this LGTM.

Sure, that makes lotsa sense


Make starknet react implementation

After https://github.com/0xs34n/starknet.js/issues/382 make the starknet react one

close https://github.com/apibara/starknet-react/pull/204

Merge by Iris and fransesco !


Can't collapse all tree elements at init.

Hi @mindceb, without more information or a link to example code reproducing the issue I am unable to help. Going to close for now, but feel free to re-open with more information.


Unsupported config option for services service: 'filebeat'

hello when I try to start the docker example stack, I get following error:
localhost full_stack_example # docker-compose -f docker-compose-linux.yml up
Unsupported config option for services service: 'filebeat'

Im running:

Docker version 18.03.1-ce, build 9ee9f40
docker-compose version: 1.3.3
4.14.63-coreos

Any ideas what might cause this error?

I used the built-in config validator tool in docker-compose
docker-compose -f docker-compose-linux.yml config
It returned no errors.
I then used docker-compose -f docker-compose-linux.yml up -d and it worked. I am viewing it now.
Please check to make sure you are running the newest version.

Sorry for not responding :( my bad. I don't remember what this issue was about, so I am closing this issue. Sorry for the inconvenience.


Untracked .swiftpm

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@cefa6db). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage        ?   96.42%
=======================================
  Files           ?        1
  Lines           ?       28
  Branches        ?        0
=======================================
  Hits            ?       27
  Misses          ?        1
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Bug]: nodes failed to join in getting started

Welcome to Amazon EKS Blueprints!

[X] Yes, I've searched similar issues on GitHub and didn't find any.

Using macOS
Terraform
❯ terraform version
Terraform v1.2.1
on darwin_amd

AWS CLI
❯ aws --version
aws-cli/2.7.4 Python/3.9.11 Darwin/21.4.0 exe/x86_64 prompt/off

What did you do and What did you see instead?
Following getting started with no changes from here https://aws-ia.github.io/terraform-aws-eks-blueprints/getting-started/
Ran the following
git clone https://github.com/aws-ia/terraform-aws-eks-blueprints.git
cd examples/eks-cluster-with-new-vpc/
terraform init
terraform plan

Ran the following but no resources were created, I opened a different issue https://github.com/aws-ia/terraform-aws-eks-blueprints/issues/601
terraform apply -target="module.aws_vpc"

output
Apply complete! Resources: 0 added, 0 changed, 0 destroyed.

Ran the command to create eks cluster
terraform apply -target="module.eks_blueprints"

The error output after 23 minutes
module.eks_blueprints.module.aws_eks_managed_node_groups["mg_5"].aws_eks_node_group.managed_ng: Still creating... [23m20s elapsed]
╷
│ Warning: Applied changes may be incomplete
│
│ The plan was created with the -target option in effect, so some changes requested in the configuration may have been ignored and the
│ output values may not be fully updated. Run the following command to verify that no other changes are pending:
│     terraform plan
│
│ Note that the -target option is not suitable for routine use, and is provided only for exceptional situations such as recovering from
│ errors or mistakes, or when Terraform specifically suggests to use it as part of an error message.
╵
╷
│ Error: error waiting for EKS Node Group (eks-cluster-with-new-vpc:managed-ondemand-20220606201637553100000009) to create: unexpected state 'CREATE_FAILED', wanted target 'ACTIVE'. last error: 1 error occurred:
│       * i-08f17e34294ce4c97, i-0c796db5af561f64f, i-0f4928f92900e58cc: NodeCreationFailure: Instances failed to join the kubernetes cluster
│
│
│
│   with module.eks_blueprints.module.aws_eks_managed_node_groups["mg_5"].aws_eks_node_group.managed_ng,
│   on ../../modules/aws-eks-managed-node-groups/main.tf line 1, in resource "aws_eks_node_group" "managed_ng":
│    1: resource "aws_eks_node_group" "managed_ng" {

On the console, the vpc is created, with 3 subnets, and 3 nodes are created
The node group is created but is in a failed state with a message Instances failed to join the kubernetes cluster
Additional Information
No response

Thanks @csantanapr - we've recently updated our guidance around deploy and destroy but the published docs aren't up to date. We'll trigger a release shortly to get these changes published. Apologies and thank you for your patience!

Hi @bryantbiggs
I just try plan and apply as is at created all 76 resources including the eks addons
terraform plan
terraform apply

eks with addons
Apply complete! Resources: 76 added, 0 changed, 0 destroyed.

Outputs:

configure_kubectl = "aws eks --region us-west-2 update-kubeconfig --name eks-cluster-with-new-vpc"

I still would like to know the root cause of why terraform apply -target="module.aws_vpc" thinks there are zero resources to create.

the module name is "vpc" so your apply would need to be terraform apply -target=module.vpc - there was a re-name not so long ago to standardize some of the naming conventions. I just pushed the release so the docs site should get updated for this

Ha!, @bryantbiggs just saw the change in https://github.com/aws-ia/terraform-aws-eks-blueprints/pull/603
Yeah you can even use modules.foo and you don't get Error: Invalid target
❯ terraform plan -target="module.foo"

No changes. Your infrastructure matches the configuration.

I see the valid modules.vpc now using terraform state list
❯ terraform state list | grep vpc
module.vpc.aws_default_network_acl.this[0]
module.vpc.aws_default_route_table.default[0]
module.vpc.aws_default_security_group.this[0]
module.vpc.aws_eip.nat[0]
module.vpc.aws_internet_gateway.this[0]
module.vpc.aws_nat_gateway.this[0]
module.vpc.aws_route.private_nat_gateway[0]
module.vpc.aws_route.public_internet_gateway[0]
module.vpc.aws_route_table.private[0]
module.vpc.aws_route_table.public[0]
module.vpc.aws_route_table_association.private[0]
module.vpc.aws_route_table_association.private[1]
module.vpc.aws_route_table_association.private[2]
module.vpc.aws_route_table_association.public[0]
module.vpc.aws_route_table_association.public[1]
module.vpc.aws_route_table_association.public[2]
module.vpc.aws_subnet.private[0]
module.vpc.aws_subnet.private[1]
module.vpc.aws_subnet.private[2]
module.vpc.aws_subnet.public[0]
module.vpc.aws_subnet.public[1]
module.vpc.aws_subnet.public[2]
module.vpc.aws_vpc.this[0]
module.eks_blueprints_kubernetes_addons.module.aws_vpc_cni[0].aws_eks_addon.vpc_cni
module.eks_blueprints_kubernetes_addons.module.aws_vpc_cni[0].module.irsa_addon[0].aws_iam_role.irsa[0]
module.eks_blueprints_kubernetes_addons.module.aws_vpc_cni[0].module.irsa_addon[0].aws_iam_role_policy_attachment.irsa[0]

Closing is working for me now


Logic App Integration Account Session APIs and tests.

Description

https://github.com/Azure/azure-rest-api-specs/pull/948

This checklist is used to make sure that common guidelines for a pull request are followed.

[X] I have read the contribution guidelines.
[X] The pull request does not introduce breaking changes.

General Guidelines

[X] Title of the pull request is clear and informative.
[X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Note: Merge commits DO APPEAR in the history of the PR. The "cleaning up" page has steps to AVOID merge by using rebase instead. It lacks steps to rebase once you have merged already and probably for the good reason that there are no such steps.
Testing Guidelines

[X] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[X] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[X] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as a link to the swagger spec, used to generate the code.

NOTE: previous author(s) forgot to do that on past RPs so there is a large number of changes in this PR due to respecting this checklist item.

[X] The project.json and AssemblyInfo.cs files have been updated with the new version of the SDK.

Can one of the admins verify this patch?

Hi @daviburg, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (daviburg@ntdev.microsoft.com). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

Why am I on this PR? I don't see anything SQL related :)

@jaredmoo picked you up as most recent reviewer for SDK PR. Turns out I did not luck out finding someone covering general topics. Doesn't hurt to try, does it? wink

@azuresdkci add to whitelist

@azuresdkci add to whitelist


[Enhancement] Use a service to load iptables instead of rc.local

Using a service configured the following way might improve the reliability of the iptables loading.
[Unit]
Description = Apply iptables rules
After=network-online.target

[Service]
Type=oneshot
ExecStart=/bin/sh -c 'iptables-restore < /etc/iptables.ipv4.nat'

[Install]
WantedBy=multi-user.target

I think the iptables-persistent package from Ubuntu does exactly this. I might give it a try.

I've had issues with the iptables-persistent package, hence the service solution but YMMV.
In short, the iptables-persistent loads the rules but instead of the expected behaviour of replacing the previous rules, it appended the saved rules.

I looked at the code of iptables-persistent and it seems to be doing exactly what you proposed. It has an additional config option for loading new rules without flushing the current ones but it is disabled by default.
It is included in the newest release.


[tools revamp] update selection flow

remove selector box when user has clicked continue/made a selection

thanks for the review!


How to update the MongoDB to 3.x

Hi there,
This repo is really useful and our team is using this repo for the MongoDB and RabbitMQ service.
I saw the MongoDB in this repo is in version of 2.x.
Could you please help tell me how to update the MongoDB to 3.x version?
Thank you

Anyone help with this?

hello there,
please give us some pointers for newbies to cf
thanks!!


The escape key to exit an editable field but ended up cancelling an upload

Storage Explorer Version: 1.7.0
Platform/OS: All
Architecture: All
Regression From: No
Bug description
When performing an upload, if you have the "file picker" window open, if you then press escape both the "file picker" window and the upload dialog are closed. We should only close the file picker.

I've investigated and this only repros on Windows. The cause of the bug also appears to be internal to Electron, I've opened an issue here: https://github.com/electron/electron/issues/19087

Annnnd they closed that bug. Opened one against Chromium: https://bugs.chromium.org/p/chromium/issues/detail?id=980751

Kicking this issue down to road. Will check on it later to see progress...

Still an active bug. Kicking down the down the road again.

Still an active bug. Kicking down the down the road again. 😔


How to run the sample on Android TV Emulator?

Can anyone help me to run the sample app on Android TV API 28 Emulator?
As per the Readme, I am not able to get the Live Channels app to appear though I see it installed as one of the system app.

I had to install 27, after installing sample app, just restart emulator. 28 is not working for me


Meteor Error -> MongoDB cannot open or obtain a lock on a file

Hi,
I am trying to setup Telescope but I keep getting this error.
=> Started proxy.
Unexpected mongo exit code 45. Restarting.
Unexpected mongo exit code 45. Restarting.
Unexpected mongo exit code 45. Restarting.
Can't start Mongo server.
MongoDB cannot open or obtain a lock on a file

I have tried meteor reset i have tried sudo meteor .. i have tried to delete .meteor/local/db/mongod.lock nothing worked.

I think you have to fix the permissions on your project and also on ~/.npm directory.


Push more computations into node functions to improve performance

Current Performance
On the Apple M2 chip with the Rats example, a manually unrolled log density function has a median benchmark time of 1.113 μs, while the current master branch at 50.916 μs. In principle, we should be able to push the performance to within 10 times of the unrolled version.
Performance Analysis

Profiling reveals type instabilities in:

Bijector transformations
BangBang's setindex! operations
logpdf computation due to runtime distribution determination

The root cause appears to be storing node functions in Vector{Any}, which disallows type inference.
Proposed Solution
Put bijector, setindex!, and logpdf computations directly into node functions where distribution types are known at compile time.
In master branch: (consider alpha[1], which is a stochastic variable
function (evaluation_env, loop_vars)
      (; var"alpha.c", var"alpha.tau") = evaluation_env
      (;) = loop_vars
      return dnorm(var"alpha.c", var"alpha.tau")
 end

In this PR:
function (__evaluation_env__::NamedTuple{__vars__}, __loop_vars__::NamedTuple{__loop_vars_names__}, __vn__::AbstractPPL.VarName, __is_transformed__::Bool, __is_observed__::Bool, __params__::AbstractVector{<:Real}) where {__vars__, __loop_vars_names__}
      (; var"alpha.c", var"alpha.tau") = __evaluation_env__
      (;) = __loop_vars__
      __dist__ = dnorm(var"alpha.c", var"alpha.tau")
      if !__is_observed__
          if __is_transformed__
              __b__ = Bijectors.bijector(__dist__)
              __b_inv__ = Bijectors.inverse(__b__)
              __reconstructed_value__ = JuliaBUGS.reconstruct(__b_inv__, __dist__, __params__)
              (__value__, __logjac__) = Bijectors.with_logabsdet_jacobian(__b_inv__, __reconstructed_value__)
          else
              (__value__, __logjac__) = (JuliaBUGS.reconstruct(__dist__, __params__), 0.0)
          end
          __evaluation_env__ = BangBang.setindex!!(__evaluation_env__, __value__, __vn__)
          __logp__ = Distributions.logpdf(__dist__, __value__) + __logjac__
      else
          __logp__ = Distributions.logpdf(__dist__, AbstractPPL.get(__evaluation_env__, __vn__))
      end
      return (__logp__::Float64, __evaluation_env__::NamedTuple{__vars__})
  end

On a high level, previously, node functions are pure functions, now node function models effects to the environment.
The tradeoffs are: (1) Increased complexity in node functions, (2)the log density evaluation is less readable.
Challenges
Type instability is still a problem: in the scope of evaluate!!, node function types are still not known by the compiler, because the node functions are still stored in a Vector{Any}. To push this forward, maybe we would need to use FunctionWrappers for type stability.

The current approach to computing log density in JuliaBUGS faces fundamental limitations that make further performance optimization really difficult.
Consider a simplified version of our evaluation logic:
function compute_logp(model, values, params)
   # values is a NamedTuple storing all variable values (`evaluation_env` in `BUGSModel`)
   # vns is a Vector{VarName} in topological order
   logp = 0.0

   for (vn, node_fn) in zip(model.vns, model.node_functions)
       # the compiler only knows `vn` is a `VarName` but doesn't know the `sym`
       if is_deterministic(vn)
           # `node_fn` here calls `BangBang.setindex!!` on values and return, so the type of `values` can't be known at compile time
           values = node_fn(values)
       else
           values, logjac = node_fn(values, params) # similar issue here
           logp += logpdf(dist, param_values) + logjac
       end
   end
   return logp
end

There are several fundamental type stability issues that prevent further optimization. First, the vns vector cannot be type-stable except in trivial single-variable cases, since each VarName{sym} has a different concrete type (e.g., VarName{:x} vs VarName{:y}).
The second major issue arises from updates to values. Each node_fn call potentially modifies the type of values. We don't want to make the type too restrictive because: (1) BUGS' implicit casting between Int and Float and (2) ReverseDiff's DualNumber types during gradient computation. So although we know the variables names will not change, their values might.
To push for more performance, we would have to opt in for either FunctionWrapper or MistyClosure, but this means we will be limited in terms of the AD backend we could support (pretty much only Enzyme and Mooncake, where the latter needs to be modified). This, in my opinion, would be a bad solution, because it will be hard to understand and maintain.
So, the natural next step would be start generating Julia code directly.


bug with changyan comment block

when in mobile mode, part of Changyan comment block overlap with navbar , which hide the "cancel" button of Changyan. Is there a way to fix this?

I don't use Changyan.
Could you give me your site address? Let me see the problem.

This bug requires more information.
Temporarily closed.


Add Basic Windows & Linux Support

What kind of change does this PR introduce?
This adds the ability to use this SDK on Windows and Linux environments.
What is the current behavior?
Currently, the SDK doesn't compile on Linux or Windows.
What is the new behavior?
This PR adds support to compile, test, and run the SDK on Windows and Linux.
Additional context
As with all things, Swift on non-Darwin platforms comes with some caveats:

The keychain doesn't exist on non-Darwin platforms. I've made a stub to get the SDK working, and left comments on what will probably need to happen in a different PR (tl;dr it will probably be easier to add the Windows support here compared to Linux since there are stable APIs on Windows to use)
All of the test files had to be broken out on different platforms for two reasons:

Windows uses crlf line endings instead of Darwin and Linux which use lf line endings, this is quite annoying, but that's life
Foundation on non-Darwin behaves differently and does some auto-canonicalization of http headers (i.e. apikey becomes Apikey), except anything starting with an X- which creates ordering issues when using the textual format.

I was unable to get the examples to run on my mac since it looks like they required a different team to get setup, so I'm hoping that running them on this repo's CI will work, but I'm seeing some success on my fork https://github.com/brianmichel/supabase-swift/actions/runs/7160617987/job/19495202392?pr=1
Looking forward to the discussion :D

Hey @grdsdev sorry for the delay, I'm going to pick this back up today and see if I can address some of the changes you've requested.

Hey @grdsdev I'm seeing errors regarding swift evolution support, which trace back to snapshot testing and I see an open issue on their repo https://github.com/pointfreeco/swift-snapshot-testing/issues/536 has this CI job worked before?

Hey @grdsdev I'm pretty close to responding to all of your feedback, let me know what you think of the approach I've uploaded, looks like all of CI that was passing is passing again https://github.com/brianmichel/supabase-swift/actions/runs/7240544944/job/19723650563?pr=1. I'll open up convos with the Pointfree folks in a little bit.
I might have to rebase this another day as I imagine it's going to be quite messy.

Hey @grdsdev I believe I've fixed all of the issues and my latest CI run was all green https://github.com/brianmichel/supabase-swift/pull/1/commits/2d8c882e1f4193490c39a7c62bf988b10e9447b7 there are likely some lingering questions that should be addressed, but I'd say this is 100% ready for a re-review and potentially ready for merging.


Jkirkwood/model loading poc2

Allow appending to model config for load_predict endpoint.
Fail quickly for model not found

Cleanup card: https://zendesk.atlassian.net/browse/BEAGLE-781

Support unloading multiple models card: https://zendesk.atlassian.net/browse/BEAGLE-782