Computing 2nd-order tf.gradients of tensors throws Exception when used with batch_norm

Describe the problem clearly
If the updates_collections of a batch_norm layer is set other than tf.GraphKeys.UPDATE_OPS, it is no longer possible to compute 2nd-order tf.gradients with respect to the weights of a fully_connected layer.
p.s. It is okay when updates_collections is set as tf.GraphKeys.UPDATE_OPS. I think updates_collections should not affect the ability to compute gradients?
Environments

Ubuntu 16.04 64bit
Python 3.6.0 |Anaconda 4.3.1 (64-bit)| (default, Dec 23 2016, 12:22:00)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-1)] on linux
tensorflow-gpu 1.0.1 installed from pip
libcublas.so.8.0, libcudnn.so.5, libcufft.so.8.0,  libcuda.so.1, libcurand.so.8.0

Source Code
import tensorflow as tf

with tf.Session() as sess:
    X = tf.placeholder(tf.float32, [None, 2])
    is_training = tf.placeholder(tf.bool, [], name='is_training')

    outputs = tf.contrib.layers.fully_connected(inputs=X, num_outputs=1)
    outputs = tf.contrib.layers.batch_norm(
        inputs=outputs,
        is_training=is_training,
        updates_collections='bad_collections')
    # get gradients of X with respect to outputs values
    grads = tf.gradients(outputs, [
        X,
    ])[0]
    bad_vars = tf.get_collection(tf.GraphKeys.TRAINABLE_VARIABLES)
    # get gradients of weights with respect to gradients of X
    bad_grads = tf.gradients(grads, bad_vars) # this line

Logs
Traceback (most recent call last):
  File "test.py", line 18, in <module>
    bad_grads = tf.gradients(grads, bad_vars)
  File "$HOME/anaconda2/envs/tf/lib/python3.6/site-packages/tensorflow/python/ops/gradients_impl.py", line 474, in gradients
    out_grads[i] = control_flow_ops.ZerosLikeOutsideLoop(op, i)
  File "$HOME/anaconda2/envs/tf/lib/python3.6/site-packages/tensorflow/python/ops/control_flow_ops.py", line 1303, in ZerosLikeOutsideLoop
    pred = op_ctxt.pred
AttributeError: 'NoneType' object has no attribute 'pred'

Hi @shaform, this seems a more suitable question for StackOverflow

Hi @Carmezim, thanks for the reply. I thought this was a bug since I
believed that changing updates_collections shouldn't affect the ability to
compute gradients. Your comment seems to suggest that the exception is
totally expected and therefore shouldn't be fixed. (i.e. It is not a bug.)
Could you share the rational behind this, please? Thanks.
On Thu, Apr 13, 2017, 11:09 AM Adriano Carmezim<EMAIL_ADDRESS>wrote:

Hi @shaform https://github.com/shaform, this seems a more suitable
question for StackOverflow
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/9034#issuecomment-293766070,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWaRLYuEWp8Wgp5zFXdDzqYn0IXT_ayks5rvZHNgaJpZM4M2S1S
.

I've updated the description and title to make to more clear.

Looks like it's because when custom updates_collections is set, legacy BN implementation would be used https://github.com/tensorflow/tensorflow/blob/r1.0/tensorflow/contrib/layers/python/layers/layers.py#L536. It's likely that this implementation would cause problems when one attempts 2-nd order tf.gradients.

@fchollet any comment on this? (contrib.layers)

Can you log the specific op for which you cannot obtain second-order gradients?

@fchollet
When the exception is thrown, the op on out_grads[i] = control_flow_ops.ZerosLikeOutsideLoop(op, i) is the following:
<tf.Operation 'gradients_6/BatchNorm_3/cond_1/Merge_grad/cond_grad' type=Switch>

I think updates_collections should not affect the ability to compute gradients?

When you are using a custom updates_collections you are routed to a different implementation of batch norm (the one in tf.layers does not support custom update collections), so this is not about updates_collections affecting gradient computation.
As far as I can tell you are calling an op (as part of the legacy batch norm layer implementation) that does not implement second-order gradients. Can anyone confirm?

@yuanbyu is that something you've seen before?

Automatically closing due to lack of recent activity. Since this issue is old at this point, please reopen the issue if it still occurs when tried with the latest version of Tensorflow. Thank you.


migration_file in subject

It would be nice to have a migration_file method in a subject to test the content of the migration file, something like
describe ActiveRecord::Generators::MigrationGenerator do
  destination File.expand_path("../../tmp", __FILE__)

  before do
    prepare_destination
    run_generator %w(create_posts)
  end
  subject { migration_file('db/migrate/create_posts.rb') }
  it { should exist }
  it { should contain 'class CreatePosts < ActiveRecord::Migration' }
end

cheers.

Coming soon in v0.1.4

Released v0.2.0 with this fix


Disabling a rule by using "append" does not work as expected

Describe the bug
Disabling a rule should be possible by just appending enabled: false as per the official documentation.
Unfortunately, it does not work.
How to reproduce it
Add a file under /etc/falco/rules.d/custom-rules.yaml with the following content:
- rule: Unexpected UDP Traffic
  append: true
  enabled: false

Finally, run falco, and you get:
Tue Jan 26 15:24:39 2021: Falco version 0.27.0 (driver version 5c0b863ddade7a45568c0ac97d037422c9efb750)
Tue Jan 26 15:24:39 2021: Falco initialized with configuration file /home/leogr/code/github.com/falcosecurity/falco/falco.yaml
Tue Jan 26 15:24:39 2021: Loading rules from file /etc/falco/falco_rules.yaml:
Tue Jan 26 15:24:39 2021: Loading rules from file /etc/falco/falco_rules.local.yaml:
Tue Jan 26 15:24:39 2021: Loading rules from file /etc/falco/k8s_audit_rules.yaml:
Tue Jan 26 15:24:39 2021: Loading rules from file /etc/falco/rules.d/custom-rules.yaml:
Tue Jan 26 15:24:39 2021: Runtime error: Rule must have property condition
---
- rule: Unexpected UDP Traffic
  append: true
  enabled: false
---. Exiting.

N.B: rule files were loaded in the correct order (that's important to ensure that append works).
Expected behaviour
No error and the rule being disabled as suggested by the official documentation here.
Environment

Falco version: 0.27.0 (previous versions seem to be affected too)

System info:

Cloud provider or hardware configuration:
OS:

Kernel:

Installation method:

Additional context
Disabling a rule seemed to work, as discussed in the past (see https://github.com/falcosecurity/falco/issues/1469 ).
However, as noticed by a user in the slack channel (original discussion here) it doesn't work.
Considerations
Firstly, the rule parser implements a too strict condition on the existence of the condition property that actually disallows this possibility. Secondly, after a quick look, it seems to me that implementation of the enabled flag would not work in appending mode even after removing the check on the condition property. Further investigation is needed.
Workaround
It is still possible to disable a rule using the never_true macro, for example:
- rule: Unexpected UDP Traffic
  condition: and (never_true)
  append: true

/milestone 0.28.1

/milestone 0.30.0

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

cc @jasondellaluce

/remove-lifecycle rotten

After further investigating this issue, It turns out that the enabled field was not overridden on appended rules at all. As such, the value was not updated even if the condition field requirement is weakened. I just opened #1775 to fix this problem.


Special characters in URL string return 404 Error

My dataset contains scandinavian characters such as "æøå". When browsing to a ressource containing one of these letters, Pubby return 404 Not Found error. I am browsing to --> http://localhost:8080/ontology/page/harAfhængighed but it returns --> http://localhost:8080/ontology/harAfhængighed with error "The requested resource does not exist at this server, or no information about it is available."
Is there any work around?

This is already fixed in the codebase (via the introduction of conf:supportsIRIs), but the fix is not yet available in a release. If you have Java development tooling (JDK and Maven), you can build from source.


Feature: single reference magnitude for MFD uncertainty generation

We want to use a single, constant reference magnitude when generating MFD uncertainty rather than the minimize_below_mag of each region
minimize_below_mag should still used when setting stdDev. Keep this code as is:
double stdDev =                     (mag < minimize_below_mag) ? 1.0 : firstWeightPower / Math.pow(rate,power-1);
but use 7.0 instead of minimize_below_mag in:
double firstWeightPower = Math.pow(mfd.getClosestYtoX(minimize_below_mag), power-1);

@chrisdicaprio as discussed, I will add a precondition to assert that minimize_below_mag is <= than 7.0


+3 icons

Description
Addition of: Disabler, Simple Reboot, Animated Stickers Maker
Icons addition information
Added
Disabler (com.servoz.appsdisabler)
Simple Reboot (simple.reboot.com)
Animated Stickers Maker (com.leapzip.animatedstickers.maker.android)

The icon outlines have nearly no free space between them, gotta fix tomorrow though.

I have taken into account the Lawnicons guidelines for you. In case of creating new icons for Lawnicons, I suggest you compare and analyze the latest changes.
Also, try not to drag the history of all PRs through each PR.


Is there any way to delay the DSC execution util the Window operation system restart completely?

Hello, Team,
We faced one issue in the DSC pull mode as below:
In the DSC pull mode, when the computer restarted,  the DSC will automatically execute the DSC resource even if the corresponding window operation system is not fully ready, for example, Applying Group policy Drive Maps policy.
Is there any way to delay the DSC execution until the Window operation system restart completely?  Thanks in advance

@chancein007 did you get you question answered?

Closing this question as answered. Please reopen or comment if this was closed in error.


Open multiple URL at once

Is it possible to open multiple URLs at once with this plugin?

Via command line, like so:
Multi URL test = run-hidden powershell -command start-process https://www.youtube.com/@tagesschau/videos; start-process https://app.raindrop.io
https://github.com/stax76/run-hidden


build: fix broken lerna scope

Description
While trying to run a release on a single package change, the command failed.

npx lerna changed shows that a package is ready for publication, but it looks like the filtering may have been too aggressive while building the scope.
How and where has this been tested?

How this was tested:
Browser(s) and OS(s) this was tested with:

Screenshots

To-do list

[ ] If my change impacts other components, I have tested to make sure they don't break.
[ ] If my change impacts documentation, I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have tested these changes in Windows High Contrast mode.

[ ] This pull request is ready to merge.

Note to future self - found the inspiration for this little hack here: https://github.com/lerna/lerna/blob/d242b067a741453ed5b65354f914b52f4362df43/scripts/build.sh


fix(chat): Update the phrase "Not allowed model selected. Please, change the model to proceed" (Issue #2363)

Description:
Update the phrase "Not allowed model selected. Please, change the model to proceed"
Issues:

Issue #2363

Checklist:

[x] the pull request name complies with Conventional Commits
[x] the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
[x] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[x] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

/deploy-review

/deploy-review


Add Configurable Common Labels and Add a PDB

These changes to the Helm chart are really to introduce two changes:

Add a configurable commonLabels value, which adds the user-supplied extra labels to all Trust Manager resources including the trust-manager pods.
Add a configurable PodDisruptionBudget.

Most of the code is just copy-and-paste from Cert-Manager's Helm chart.

I will have to add the DCO sign off to the previous commits this evening.

@jakexks are you able to review if this PR is okay to test?

Thanks @justdan96, I rebased your PR and updated the PDB to match the logic and comments in cert-manager.
/approve
/lgtm

/retest

/approve
/lgtm


feat: BETA loadbalancer service support

Part of https://github.com/equinix/metal-cli/issues/411
(Used CPEM's LBaaS Go project as the base. Lots of cleanup ahead. )
This PR introduces the minimal subcommand support to start working with LoadBalancers. This PR does not include ports and pools, which can be added later.
TODO:

[x] Get LB
[x] List LB
[x] Detele LB
[x] Create Project LB
[x] Send debug transport to token exchange when debugging?
[x] Ensure command docs are correct
[ ] Ensure requirement checks (required fields) are correct
[x] Ensure example commands are correct
[x] Ensure command is named "loadbalancer-beta"
[x] generate docs

One thing to consider here: if LBaaS has its own generated client that sits next to the metal client in equinix-sdk-go, with its own spec and its own API endpoint, that may indicate that LBaaS CLI commands should go alongside Metal CLI commands in a broader-scoped Equinix CLI (eqx? eqix?  the-equinix-cli?) rather than directly in here.

Merged in latest updates and tested create/get/delete commands to verify they work.


GH-36730: [Python] Add support for Cython 3.0.0

Rationale for this change
Cython 3.0.0 is the latest release. PyArrow should work with Cython 3.0.0.
What changes are included in this PR?

Don't use vector[XXX]&&
Add a declaration for postincrement

See also: https://cython.readthedocs.io/en/latest/src/userguide/migrating_to_cy30.html#c-postincrement-postdecrement-operator

Ignore C4551 warning (function call missing argument list) with MSVC

See also: https://github.com/cython/cython/issues/4445

Add missing const to CLocation's static methods.
Don't use StopIteration to stop generator

See also: https://cython.readthedocs.io/en/latest/src/userguide/migrating_to_cy30.html#python-3-syntax-semantics

Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.

Closes: #36730

This may fix the compilation error but there are other issues during tests (see macOS CI?).

I've fixed CI failures.

@kou there were also some runtime errors in the minimal build that are caused by cython 3. Based on your diff, I don't think that will already be fixed here, but let me run them to be sure.

@github-actions crossbow submit example-python-minimal-build-fedora-conda

@github-actions crossbow -g python

Can this PR also undo the pinning on various Python builds?

@github-actions crossbow submit example-python-minimal-build-fedora-conda

I've fixed the generator related problem.
I'll rebase on main and unpin Cython version.

Hmm. Can we detect Cython version in .{pyx,pxi}?

 We use the same pattern in many other places. Can you try this patch:
--- a/python/pyarrow/_dataset_parquet.pyx
+++ b/python/pyarrow/_dataset_parquet.pyx
@@ -741,7 +741,7 @@ cdef class ParquetFragmentScanOptions(FragmentScanOptions):
             thrift_string_size_limit=self.thrift_string_size_limit,
             thrift_container_size_limit=self.thrift_container_size_limit,
         )
-        return type(self)._reconstruct, (kwargs,)
+        return ParquetFragmentScanOptions._reconstruct, (kwargs,)

(in theory it shouldn't matter for python, but maybe cython 3 has a bug that treats this different)

Thanks! I've pushed your patch.

If there are problems with compatibility between 0.29 and 3.0 (aside from the few intentional breaking changes), the Cython devs are usually quick to respond if you open an issue

The failing pickle test is only when using the cloudpickle module instead of the python pickle module. Perhaps they don't support cython3.0.0 yet? This is the only test in the entire codebase that tests cloudpickle.. not sure how important it is as a dependency to pyarrow.
@pytest.mark.pandas
@parametrize_legacy_dataset
def test_cloudpickle_dataset(tempdir, datadir, use_legacy_dataset):
    cp = pytest.importorskip('cloudpickle')
    dataset = _make_dataset_for_pickling(tempdir, use_legacy_dataset)
    _assert_dataset_is_picklable(
        dataset, pickler=cp, use_legacy_dataset=use_legacy_dataset)

Well, first, this PR should be rebased, because there are conflicts.

I did rebase/squash here to test things out here: https://github.com/apache/arrow/pull/37097
I wanted to experiment without polluting this PR. I can merge any fixes I find back into this PR.

Can we use #37097 instead of this?

Can we use #37097 instead of this?

Sure!

I close this in favor of #37097.


fix: Broken replacement when export and file contain the same string

fixes #151 by replacing the last occurrence of the matched filename instead of the first one.
Also I added a test for the bug, but was not sure where to place the fixture as it has a different typescript config to the other tests.

Thanks for contributing this fix! Much appreciated 😊
@all-contributors please add @Zebreus for bug fix and test


Instructions for Windows users

Just tried this out on Windows, using Python 3.5.2 x64. Here's what I ran into...

Install Python 3.5 for "all users"; I used the default C:\Program Files\Python 3.5 location.
Run easy_install musicrepair in an admin command prompt. Pip didn't work.
"c:\Program Files\Python35\Scripts\musicrepair.exe" worked for me, once it installed correctly.

Forgive me but I couldn't understand the issue. Do you mean that for windows users easy_install works but pip doesn't?

@lakshaykalbhor Pip might work, but my first go of it had it stop after some errors on dependencies. Then again, I hadn't tried admin rights on that run. The easy_install run was more complete the first try, before elevating. I've ran into this on other projects: think it has to do with the ability of dependencies to compile stuff with C++ or something.

I shall add a side note in the readme for windows users that if pip doesn't work, they should try easy_install (With admin rights). Thanks for pointing this out

@lakshaykalbhor No problem. 👍 https://packaging.python.org/pip_easy_install/ Seems to indicate whats going on btw.

To recursively descend a directory tree this seems to be working:
for /r /d %1 in (*) do musicrepair -d "%1"

Its because of the python bug https://github.com/pypa/setuptools/issues/398

Hey @uniquetwiki I am sorry to disturb you and ask you will you be able to give me that windows package plz I really want to try this

@unquietwiki have you checked Pyintsalller It allows us to create stand alone distribution of the app

@Droyk there's nothing for me to give you, unless you're asking for something to package it up as @gautamkrishnar is suggesting. I just use it on my machine via the easy_install method.

When I tried running musicrepair after using the pip install I was getting error message:

failed to create process.

It turned out that pip was omitting the quotes around the path to python.
To fix I edited the musicrepair-script.py file to add the quotes:
from:
#!C:\Program Files (x86)\Python_343\python.exe
to:
#!"C:\Program Files (x86)\Python_343\python.exe"


Any way to use the floating button via layout XML instead of via code?

I don't really want it to always be there.
For example, if there is a navigation drawer, it shouldn't be visible, and others might be shown (when choosing other fragments to show).
I think it's better to let us choose exactly where to put it on the layout file.
Currently, the only way to avoid this, is to create the view when needed, and call "detach" on it when not needed.

Good point,i don't want to write so many java code too...and you miss the onClickListener and onItemClickListener ...


COG is causing a NPE with lost citie's debug command

After installing COG, whenever I tries to use /lc_debug command from the lost cities mod it gives a NPE in the console, could you take a look at this issue? Since commands in this mod are very helpful in debugging generations.
Full log with the error in the end: https://gist.github.com/wormzjl/1f273d3ecb0062e5512ec4c3a91e102c
Source of the lost cities mod: https://github.com/McJtyMods/LostCities

Have you raised this with the Lost Cities developers? The crash is obviously in their code, so even if the bug is in COG, they might help with the diagnosis. I glanced at the indicated code, but the cause wasn't obvious.


Allow zero-output coinbase transactions in auxpow

Even though a transaction without outputs is not valid, it can be deserialised fine by Namecoin Core and thus is accepted as parent coinbase in an auxpow.  Electrum-NMC's deserialiser already fails on that, and thus Electrum-NMC did so far not accept those auxpow's (leading to a consensus failure with Namecoin Core).
With this patch, we allow auxpow's whose parent coinbase transaction has no outputs, so that Electrum-NMC follows the behaviour of Namecoin Core.
Note that auxpow's like that are very unlikely to occur on mainnet, as a miner would essentially have to build a Namecoin-only block for it, giving up the merge-mining bitcoin reward (and thus it is very costly to do so).  But it is nevertheless a possibility.  On testnet, there are actual blocks that failed to sync with Electrum-NMC before this patch (e.g. the one from the new unit test).

Concept ACK.
Shouldn't this be submitted to the auxpow branch rather than master?
Does this issue affect the master-3.3.10 branch too?  If so, is it easy to backport?  (Transaction parsing has been completely rewritten since then.)
Nit: Git commit message says "deserialising (and verifying) and auxpow"; I assume "and" is a typo and should be "an".

Thanks for the review!  I agree this should be for auxpow, and have changed it accordingly.  I've also fixed the commit-message typo.
I think this does not affect the pre-rewrite code, as it used to work with Xaya before that.  It seems very likely that the reason why it broke was the rewrite.

Looks good to me except for the grammar typo I noted.  Once that's fixed, I think this can be merged.

Thanks for the review, I've pushed a fix.


Linux: If specified password is incorrect, user is prompted

Currently testing on Lubuntu 17. Seems to work well!
One thing I have noticed is that if the specified password is incorrect, then the desktop session displays a (standard) prompt to the user for the wifi password. I would hope that I could have full control of the UI (or lack thereof). Any way around this?

Sorry for the delay.
I didn't how about it. I tried on Fedora too and the same thing happened. Quite weird because I didn't activate the option ask:
-a | --ask
           When using this option nmcli will stop and ask for any missing required arguments, so do not use this option for non-interactive purposes like scripts. This option controls, for
           example, whether you will be prompted for a password if it is required for connecting to a network.

Sorry but I don't know yet how to correct it.


Replace IT Services menu with About and Contact , remove loading

Fixed #437 on iOS
Fixed #451

Updated Android build on this branch as well

Waiting to review this until the updates from #453 are in.

This PR is now a mix of Android and iOS changes, some of which have already been merged in another PR, and others of which have been invalidated by having gotten final requirements for the "i" menu (issues #459  and #453). Does it make sense to close this and start over on these menu tweaks?


TRSS grid cell display graphic missing

In this test grid: https://trss.adoptopenjdk.net/resultSummary?parentId=5ede3c7c7d66ef2bd6e8378b sanity.perf tests were executed against x86-64_mac but the grid position for that test is blank.
If you hover your mouse over the grid cell then the popup appears showing that the tests were executed and there were 2 failures.
Maybe it's due to the test's "PARTIAL_SUCCESS" status?

I do not see PARTIAL-SUCCESS is used anywhere.
@OscarQQ could you update buildResult = "UNSTABLE"? Also, add a note in the tooltip for Perf, Build Result is from TestBenchmarkParser.js (not CI build). Thanks


Improve performance of article-structure plugin.

This improves the performance of the plugin, as this PR ensures that the move/insertion possibility is not checked every state change.
To be tested in combination with https://github.com/lblod/ember-rdfa-editor/pull/564.

@abeforgit @lagartoverde I'm gonna put this on hold now, I'm not fully happy with the interface yet.

this keeps running our ci for no reason so gonna close it (but ill leave the branch up)


Resources

Hi and thanks for this project!
Is there any way to define resource requirements per model? I can't seem to find it?
It looks like at the moment the deployments are created without any resource requirements / limits.
I'd like to define in the Model CRD that I want e.g. 4 CPUs and 8Gi memory.
Thanks.

Currently I haven't implemented the resource limit for Model deployments, I will add the support for it ASAP today.
You can try to use
kubectl set resources deployment -l model.ollama.ayaka.io=<model name> --limits cpu=4

and
kubectl set resources deployment -l model.ollama.ayaka.io=<model name> --limits memory=8Gi

to manually patch it.

-l means select by label
--limits means add annotation for resources.limits

Sorry for any of the inconvenient.

Implemented and released, please upgrade to v0.7.0 to test it out.

I've defined resources as documented in https://ollama-operator.ayaka.io/pages/en/references/crd/model.html#full-crd-reference but the model deployment isn't getting them...


Fixing remaining term query in keyword fields

Description
Overrides termQuery in keyword fields to be searchable with only doc_values enabled.
Related Issues
Resolves #11538

Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
[ ] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
[ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Did a benchmark on the term query on a keyword field and did not see any improvements in performance. This might be a redundant change.


Modify UpdateEncryptColumnTokenGenerator

Ref #2732

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Pull Request Test Coverage Report for Build 8936

40 of 51 (78.43%)  changed or added relevant lines in 1 file are covered.
11 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.2%) to 62.633%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/token/generator/UpdateEncryptColumnTokenGenerator.java
40
51
78.43%

Files with Coverage Reduction
New Missed Lines
%

sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/token/generator/UpdateEncryptColumnTokenGenerator.java
2
81.43%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/core/filler/SQLStatementFillerEngine.java
2
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/sql/statement/generic/AbstractSQLStatement.java
7
14.29%

Totals

Change from base Build 8935:
0.2%

Covered Lines:
8644

Relevant Lines:
13801

💛  - Coveralls


Add SassMagic

Add SassMagic for Libraries and Mixins

@airen Thank you for the PR!
Please put SassMagic at the bottom of the Libraries and Mixins section instead as mentioned in Contributing.md.
Also, we don't need to mention that SassMagic is SassMagic. You can see the other descriptions as an example to shorten it. 😄


fix: LSDV-4881: Fix missed points in optimized timeseries

PR fulfills these requirements

[x] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
[x] Tests for the changes have been added/updated (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[x] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
[x] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)
(check all that apply)

[ ] Product design
[x] Frontend

Describe the reason for change
When the user zooms in with big time series (e.g. 250k points), some of the points are not selectable
What does this fix?
It makes available for the cursor all timestamps/points that was filtered by optimized data mode.
What is the new behavior?
N/A
What is the current behavior?
N/A
What libraries were added/updated?
N/A
Does this change affect performance?
It may be. But it was not detected by me.
Does this change affect security?
Nope
What alternative approaches were there?
N/A
What feature flags were used to cover this change?
fflag_fix_front_lsdv_4881_timeseries_points_missing_140423_short
Does this PR introduce a breaking change?
(check only one)

[ ] Yes, and covered entirely by feature flag(s)
[ ] Yes, and covered partially by feature flag(s)
[x] No
[ ] Not sure (briefly explain the situation below)

What level of testing was included in the change?
(check all that apply)

[ ] e2e
[x] integration
[ ] unit

Which logical domain(s) does this change affect?
TimeSeries

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.01 :tada:

Comparison is base (745cddc) 63.99% compared to head (c349077) 64.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1317      +/-   ##
==========================================
+ Coverage   63.99%   64.01%   +0.01%
==========================================
  Files         434      434
  Lines       26929    26936       +7
  Branches     6961     6964       +3
==========================================
+ Hits        17234    17242       +8
+ Misses       9695     9694       -1

Impacted Files
Coverage Δ

src/tags/object/TimeSeries/Channel.js
80.25% <100.00%> (+0.30%)
:arrow_up:

src/utils/feature-flags.ts
100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[Python schema] Support python avro schema set default value.

Motivation
now python avro schema don't support set default value, it led to the python schema can't update.
implement

add required field to control the type of schema can set null.
add required_default filed to control to control the schema has default attribute wether or not.
add default field to control the default value of schema.

Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

@BewareMyPower  could you please review this pr? thanks :)

It looks like there're still some problems with the implementation.
File "/tmp/schema_test.py", line 810, in test_avro_required_default
    "default": None
AssertionError: {'fields': [{'default': None, 'type': ['null', 'int'], 'name': 'a'}, {'default': [truncated]... != {'fields': [{'default': None, 'type': ['null', 'int'], 'name': 'a'}, {'default': [truncated]...

mark as release/2.7.2 since this is a bug when the users using the schema in the Python client.


[Feature] azure.yml image to support environment variable substitution

[x] Make sure you've installed the latest version using instructions in the wiki

Output from azd version
N/A
Describe the bug
Not a bug, a missing feature!
Consider the following: azure.yml:
# yaml-language-server: $schema=https://raw.githubusercontent.com/Azure/azure-dev/main/schemas/v1.0/azure.yaml.json

name: my-container-app
metadata:
  template<EMAIL_ADDRESS>services:
  web:
    image: myregistry.azurecr.io/my-project/my-container-app:${WEB_VERSION_TAG}
    host: containerapp

The image property under services does not support environment substitution according to: https://raw.githubusercontent.com/Azure/azure-dev/main/schemas/v1.0/azure.yaml.json
However, the same image property under docker does support environment substitution according to: https://raw.githubusercontent.com/Azure/azure-dev/main/schemas/v1.0/azure.yaml.json
To Reproduce
N/A
Expected behavior
Wouldn't it be amazing if services.image did support environment substitution in the same way as docker.image?
Environment
N/A
Additional context
This came out the work done in this post: https://johnnyreilly.com/using-azd-for-faster-incremental-azure-container-app-deployments-in-azure-devops

@wbreza can we fix this?


Have to fly in creative mode, then switch to spectator mode to be able to sprint in spectator mode

here is a recording showing it
https://youtu.be/3UQDOIGGUXE

Should be fixed in b2f8662cc97dfe01f5ab07c00bb10d0eb37313ca, could you please let me know if that resolves your issue?

it seems to be fixed. Thanks


RFM - Windows Firewall Control

I DON'T Want To Become The Maintainer

[x] I have followed the Package Triage Process and I do NOT want to become maintainer of the package;
[x] There is no existing open maintainer request for this package;

Checklist

[x] Issue title starts with 'RFM - '

Existing Package Details
Package URL: https://chocolatey.org/packages/windowsfirewallcontrol
Package source URL: https://www.binisoft.org/wfc
Date the maintainer was contacted (in YYYY-MM-DD): 2020-06-28
How the maintainer was contacted: https://chocolatey.org/packages/windowsfirewallcontrol/ContactOwners
The new version is <IP_ADDRESS> out on 2020 JUNE 27, and the chocolatey one is <IP_ADDRESS> (2019 APRIL 17), many version are out since last update.

If no one takes up maintaining this package i might look into doing so, but i can only start work on it in 7-10 days time.
Just a note that they keep the exe file name the same every update so if someone tries to install an old version on the community repo then those installs will fail the hash check.

I've requested maintinership monday, but still don't have any answer.
I'll ask the site admins for it
Th package is already ready

Request sent to site admins
Le dim. 12 juil. 2020 à 03:33, Stewart Cossey<EMAIL_ADDRESS>a
écrit :

If no one takes up maintaining this package i might look into doing so,
but i can only start work on it in 7-10 days time.
Just a note that they keep the exe file name the same every update so if
someone tries to install an old version on the community repo then those
installs will fail the hash check.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/chocolatey-community/chocolatey-package-requests/issues/856#issuecomment-657159984,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABOQG62FXPVSPTPVGOXLWHLR3EHILANCNFSM4OR3VUZQ
.

Package ready, just waiting for have the maintainer role andi'll push it asap

@tunisiano187 thanks a lot :), i really like this software (since the way to monitor windows firewall is so... unfriendly for normal user)

You're welcome

@tunisiano187 new version failed the test (i will mark this closed thanks for all)

@aelisya the request is not considered to be completed until the package has been approved by a moderator, thus I am re-opening this request again.

@AdmiringWorm we have received the update, can i close it now ?

@aelisya yup, now that the package version have been approved, this request is considered completed and can be closed.

@tunisiano187 i just want to say on the website it say 6.3.0 and on the software installed <IP_ADDRESS>, so it lead to perimed logo to show everytime (or it's juste me ?)

Perimed logo ?, i'm using their installer so ...
Le jeu. 23 juil. 2020 à 00:08, Michael<EMAIL_ADDRESS>a écrit :

@tunisiano187 https://github.com/tunisiano187 i just want to say on the
website it say 6.3.0 and on the software installed <IP_ADDRESS>, so it lead to
perimed logo to show everytime (or it's juste me ?)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/chocolatey-community/chocolatey-package-requests/issues/856#issuecomment-662722066,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABOQG6ZICCLM4YWQ3YJ3KM3R45PMPANCNFSM4OR3VUZQ
.

@tunisiano187 no sorry it was a bug on my side (it's why i have rapidly removed my comment)


<EMAIL_ADDRESS>decompress error

Got this error when I attempted to run scoop install Twilio. I tried to install via PowerShell as well
C:\Users\Drew\Desktop
λ scoop install twilio
Installing '7zip' (22.01) [64bit] from main bucket
7z2201-x64.msi (1.8 MB) [===========================================================================================================================================================================================================] 100%
Checking hash of 7z2201-x64.msi ... ok.
Extracting 7z2201-x64.msi ... done.
Linking ~\scoop\apps\7zip\current => ~\scoop\apps\7zip\22.01
Creating shim for '7z'.
Creating shim for '7zFM'.
Creating shim for '7zG'.
Creating shortcut for 7-Zip (7zFM.exe)
Persisting Codecs
Persisting Formats
Running post_install script...
'7zip' (22.01) was installed successfully!
Notes
Add 7-Zip as a context menu option by running: "C:\Users\Drew\scoop\apps\7zip\current\install-context.reg"
Installing 'twilio' (5.3.3) [64bit] from twilio-scoop bucket
twilio-win32-x64.tar.xz (32.8 MB) [=================================================================================================================================================================================================] 100%
Checking hash of twilio-win32-x64.tar.xz ... ok.
Extracting twilio-win32-x64.tar.xz ... ERROR Exit code was 2!
Failed to extract files from C:\Users\Drew\scoop\apps\twilio\5.3.3\twilio-win32-x64.tar.
Log file:
~\scoop\apps\twilio\5.3.3\7zip.log
Please try again or create a new issue by using the following link and paste your console output:
https://github.com/twilio/scoop-twilio-cli/issues/new?title=twilio%405.3.3%3A+decompress+error

Hi @drewAdorno  thanks for reaching out. This looks like a duplicate issue. Can you please try running this command in Powershell as an admin. Its mentioned in the doc here

Hi Kridai, I got this resolved shortly after I posted the bug. It was a permissions issue Thank you


Lints: consider adding new 2.19 lints

collection_methods_unrelated_type
combinators_ordering
dangling_library_doc_comments
implicit_call_tearoffs
library_annotations
unnecessary_library_directive
unreachable_from_main
use_string_in_part_of_directives

I wish the combinators_ordering one was case-insensitive, though!

I wish the combinators_ordering one was case-insensitive, though!

cc @pq re: combinators_ordering; happy to file a feature request if that change sounds reasonable.

I think we already argued about this. I'm not sure....
I mean, had a thoughtful discussion 😁
On Sun, Feb 12, 2023, 10:03 Devon Carew @.***> wrote:

I wish the combinators_ordering one was case-insensitive, though!
cc @pq https://github.com/pq re: combinators_ordering; happy to file a
feature request if that change sounds reasonable.
—
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/ecosystem/issues/47#issuecomment-1427095037,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAEFCUGDVXX3TKQUXSTZF3WXEQYLANCNFSM6AAAAAAULWY44U
.
You are receiving this because you authored the thread.Message ID:
@.***>

I think we already argued about this. I'm not sure....

😃
https://github.com/dart-lang/linter/issues/3866


$backup->getCreatedAt() is not robust

I'm wondering if it is possible to improve $backup->getCreatedAt() in some way. Currently the result completely relies on the time reported by the OS. This may not work, for example, after I replaced the server and restored the backups from another place. The first call of zenstruck:backup then will keep only a single archive out of all that have been copied. This is because their creation date will actually be the same.
Maybe using the filename itself will help here, but I can't come up with some general solution in my head.

For the $backup->getCreatedAt(), what about a FilenameTimestampDestination wrapper that builds the Backup's using the filename for the createdAt? A constructor option could be a regex to be used to extract the timestamp from the filename? -- @kbond

Yeah, I guess that's the direction in which the solution is. Maybe it is even possible to use the backup namer as a source for a regexp. Prefix and timestamp format are there already. -- @kachkaev

Do you see an issue with: https://github.com/kbond/php-backup/blob/rotating-backups/src/Destination/RotatedDestination.php#L29 ? I don't think that it would be as the new backup would presumably be using the correct time...

What if that destination gets the namer as an additional parameter in the constructor? Backup::fromFile($filename) becomes Backup::fromFile($filename, $namer) too.
Then if the namer is of type timestamp and it is possible to extract createdAt from the $filename, actual file creation time does not matter. Otherwise, OS timestamp is used as a fallback.

Yeah, I like the Namer idea. I would prefer injecting the TimestampNamer directly though. The class wouldn't be usable without it.


[BUG] Opening the menu in navbar moves everything to left

Is there an existing issue for this?

[X] I have searched the existing issues

Current behavior
When I open the menu in the navbar, the content of the website is pushed to the left.
Expected behavior
When opening the menu, it should just show the menu on the website and not move anything.
Steps to reproduce

Open the menu on any page within the website (Features page is probably the best place to do this)

Environment (remove values that do not apply)
- Browser: Google Chrome

Anything else?
Before opening the menu:

After opening the menu:

Code of Conduct

[X] I agree to follow this project's Code of Conduct

The same seems to be happening when you open the drawer in navbar, too.

Fixed in 05cae0a0323e67947ea4cbd22a291dc3fb38ffa5.


login with username and password prompt

Motivation: it's more secure to interactively enter passwords and usernames to prevent accidental leaking of credentials in history.

[ ] username and password can be entered interactively, when not provided via parameter

Hey @nitram509 I would like to contribute to this issue.

Hi @RahulSankhla312, you are very welcome.
Just as a friendly reminder: there's the https://hacktoberfest.com/ starting and in case you're participating,
feel free to craft your PR in October.
Best regards
Martin

Sir @nitram509  , can you please explain this username and password prompt issue ?

Yes, of course.
The current implementation of ntgrrc does a login but only allows command line parameters,
like for example ntgrrc login --address=STRING --password=STRING
Entering password on the command line is considered bad, because it typically leaves the password/secret in the shell's history.
That's why this issue is about to extend ntgrrc with logic, that when no parameter "--password" is provided, then the tool should prompt the user, to enter a password.
That's it.
Does this make sense?


Removes reference to removed job

:tada: This PR is included in version 2.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Support more postgres errors

To help track what postgres errors would be good to add default exception handlers for I've created this ticket.
All postgres errors are here: https://www.postgresql.org/docs/current/errcodes-appendix.html

[ ] 42703 | undefined_column - likely to encounter this when your model field name does not match the table column

... more soon ...

likely to encounter this when your model field name does not match the table column

You mean the field namespace doesn't match the model key?

I mean when the model key e.g. "email" doesn't have a corresponding column "email" in the table.
In this case I added a field to my model but forgot to add it to the table in my migration.


Vulnerability fix for AzurePowerShellV4

Task name: AzurePowerShellV4
Description: Latest vulnerability fix for AzurePowerShellV4
Documentation changes required: (Y/N)
Added unit tests: (Y/N)
Attached related issue: (Y/N) https://dev.azure.com/mseng/PipelineTools/_componentGovernance/184/alert/79428?typeId=12858
Checklist:

[x] Task version was bumped - please check instruction how to do it
[x] Checked that applied changes work as expected
[x] node make.js build --task AzurePowerShellV4
[x] node make.js test --task AzurePowerShellV4

/azp run


Add CPAN releases

Once our install issue is fixed, let's add a CPAN release and update our reference in the ecosystem to avoid accidentally breaking downstream users when master is updated.

You probably mean p6doc here. I don't know if there's a CPAN release for the time being, I am not sure we want to do that. If you mean ecosystem release, it's probably OK.

I would recommend we do it for all the doc repos, but definitely this one, once we have resolved the install issue.

I would say this is solved?
----------------------------------------------------------------------------------------------------------------------
ID|From                             |Package                                    |Description
----------------------------------------------------------------------------------------------------------------------
0 |Zef::Repository::Ecosystems<cpan>|rakudoc:ver<0.2.1>:auth<github:Raku>:api<1>|A tool for reading Raku documentation
1 |Zef::Repository::Ecosystems<cpan>|rakudoc:ver<0.2.2>:auth<github:Raku>:api<1>|A tool for reading Raku documentation
2 |Zef::Repository::Ecosystems<cpan>|rakudoc:ver<0.2.3>:auth<github:Raku>:api<1>|A tool for reading Raku documentation
3 |Zef::Repository::Ecosystems<cpan>|rakudoc:ver<0.2.4>:auth<github:Raku>:api<1>|A tool for reading Raku documentation


#162 bugfix - Large nagtive number rounding

Fixed bug #162, and added tests to check that large negative
numbers do not round.  Also commented out broken test related to
test #162.

🎉 yay! thanks for fixing this
just two small comments then let's merge this!! :D

Thanks for the comments,  I have made the changes.  Assuming this passes, should I pick some open issue and give it a go?

yup! feel free to work on something else open. I'm hoping to move the focus to porting over to math-rules and math-parser soon, so feel free to check those out at https://github.com/semantic-math
If you wanna do some more stuff in the meantime:

#198 would be goo to look into
#146 would be really helpful and will continue to stay in the codebase despite changing to a new parse tree (not sure what else will stay vs change)
#109 is a neat teaching related one to look into (we don't only want to get the right answer, we want to get there in a way that makes sense!)

feel free to check out some other open issues, those were just some that stood out to me
thanks for spending your time on this project! I really appreciate it. If you have any questions or need help with anything, just let me know :)


Encountering difficulties installing valis-wsi due to compatibility issues with Python 3.12.

Issue Summary:
Environment:
Python version: 3.12.1
Operating System: Linux
Package Manager (if applicable): Conda
Steps to Reproduce( according to the documentation):
python3 -m venv venv_valis
source ./venv_valis/bin/activate
python3 -m pip install --upgrade pip
python3 pip install valis-wsi
Error Messages:
Encountered a RuntimeError during the installation process, indicating that the package does not support Python version 3.12.1.
Additional Information:
Attempted to upgrade the numba package directly, but faced the same compatibility issue.

Hi @jeginderof,
I just pushed the updated version of valis (1.0.3), which should be compatible with Python 3.12. Please try it out and let me know how it goes.
Best,
-Chandler


Update index.adoc to fix typo

Checklist

[x] documentation is changed or added (if applicable)
[x] contribution guidelines followed here

@Fishbowler Are you able to sign the Eclipse CLA?

I cannot work out how to get my completed ECA to be picked up.
This one character change is my own work, performed in my own time, I'm in no way legally constrained, embargoed or otherwise limited from contributing, and I offer this one character freely for an authorised maintainer to either merge or cherry pick as they see fit.

Fixed :)


Docker User

I see in this Readme an alert to use chown in Linux, but we can get away with it if the Docker image uses the same user UID:GID of the Linux OS.
To achieve this we create an user elixir in the docker image with uid:gid equal to 1000:1000, that usually is the same used in our PCs or Laptops if we are logged with the first user created in the Linux OS for us.
FROM elixir

ARG CONTAINER_USER='elixir'

RUN  useradd -m -u 1000  "${CONTAINER_USER}"

# this will make the container to run under user elixir with uid:gid 1000:1000
USER "${CONTAINER_USER}"

My Dockerfile using the above approach can be seens here.
Another approach is to start the container like sudo docker run -v $PWD:/dir image-name  -u $UID:$GID  command-name. Same can be done from a docker compose file.
Any of the above approaches will eliminate permissions conflicts between the container and our machine when mapping volumes.

PS: I have not used this package yet, just trying to help with the Docker tip.

Awesome, thanks for the pointers, I will try both these approaches. I think wrapping it up in the dockerfile would be best. Will any of these changes cause problems for mac users? mac users didn't originally have the ownership problems

Not a Mac user, but under the hood  they are running Docker in a Linux Virtual Environment,  therefore that emulation may take care of the permissions issues...

I have not managed to make this work. I believe that the mix.archive is getting installed to the wrong user and when I change the user as described above before building the archive I get permission errors

Any operations made before change the user will be done as the root user.

This is the Dockerfile
If I change the user after line 11, then, when running the container later then the mix task embark cannot be found.
~/Projects/Tokumei (master *% u=)$ docker run -v $PWD:/tmp tokumei/embark my_app2
** (Mix) The task "embark" could not be found

If I change the user before line 9, then there is an error copying things into the container.
Step 8/10 : RUN mix compile && mix archive.build && mix archive.install --force
 ---> Running in 348f5a91191c
** (File.Error) could not make directory (with -p) "/installer/_build/dev/lib/embark": no such file or directory
    (elixir) lib/file.ex:236: File.mkdir_p!/1


[FIX] Add retry if first dashboard retrieval fails

Occasionally when retrieving the dashboard information, an error would occur with the message:
 "msg="status: 404, body: {\"message\":\"Dashboard not found\"}"
After some investigation it was concluded that the error occurred when the request to Grafana API coincided with the restart of Grafana pods.
This PR adds a one-time retry if the GET request fails.

Hey, @lmarques03 thanks for the contribution!
Can you elaborate a little bit more about this issue, looking at the description that you provided, seems to me that the dashboard doesn't exist, could it be an issue with the dashboard sync instead of the Grafana API?

Hello, @nicolastakashi.
It certainly could be, however from our side, every time the error was triggered it coincided with the restart of Grafana pods. As such, the error is only triggered very occasionally, which indicates that most of the times the dashboard sync is done correctly. Also, the error does not persist, and on the next API call everything works fine, and the dashboard is found.
Apart from all of this, I was not able to replicate the error in my local environment, even when importing the same dashboards as in prd.

Hey, @lmarques03 thanks for the clarification.
Well since it's a transient issue in my view we can just check the error code and don't treat 404 as an error, this is a recurrent task, the next time the dashboards will be available and everything is ok.
WDT?

@nicolastakashi That sounds like a good idea. Would you prefer to mantain the retry (and do it only when the error is 404), or simply ignore the error altogether, and wait for the next iteration?

Hello @nicolastakashi. I changed the code to handle 404 as a warning. It should be fine now. Please review and let me know what you think.

Yeah that was dumb. I fixed it now.
If the dashboard retrieval results in an error, then it always continues to the next iteration. But it does not consider the 404 response as an error.


[Feature] Allow setting the RayClusterName in the job specification to have determinitic service head

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
Currently in order to expose the service to the end user, we need to look for the service name which contains a random number.
For instance of the user has already a unique RayJob: job-22f1d24aff9a4c7fbe5ab9707decbcb0 the cluster name would something like this job-22f1d24aff9a4c7fbe5ab9707decbcb0-raycluster-7ct2d and subsequently the service head would be 22ff9a4c7fbe5ab9707decbcb0-raycluster-7ct2d-head-svc.
It would be nice to allow the user to set the value and only generate them if not specified.
Use case
I understand the logic to prevent crashing the creation of the cluster, unfortunately this make using the operator very hard.
I think the specification should allow setting the RayClusterName similar to the JobId to allow building on top of this operator.
Note: I already tried to set the name of the service and head via metadata.name unfortunately some env vars are auto generated and the ray params and using the env var to resolve the service name.
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

cc @architkulkarni

@architkulkarni Happy to make a PR.
I will start with changes that I can test on a local cluster and then we can discuss in case I miss anything after opening a PR draft.

@mmourafiq that sounds great, thanks for the contribution!


Lazily parse package.json files

This has caused issues with node module dependencies that include intentionally invalid package.json files in their distributions (as part of tests).
For now, there is a workaround: add an entry to the [ignore] section of the .flowconfig.
I think we should only parse the package.json file once the relevant module has been required. Ideally, we would only parse once if the module were required multiple times.

I think the challenge here is that if we defer them, I don't think we'll be in an environment where we can raise the parse error.
also, we check every @flow file under root (+includes-excludes) whether or not it's required anywhere, so I expect we'd end up parsing the package.json anyway when we check the files in that package (except for true edge cases like a directory with only an invalid package.json for a test, but if that test had a .js file in it then it'd still fail).

We raise if the package.json file can't be found. Couldn't the same code path could raise the parse error too?
You make a good point, though, that even if we do it lazily, we could end up parsing them anyway through requires in .js files.
Do you have any alternate ideas that solve the whole problem? [ignore] does work, but if we could eliminate the startup cost somehow, without requiring configuration, that would be ideal.
Also, the [ignore] solution means each project needs to solve the same problem over and over. It's not ideal, but what if we added a custom key to package.json files themselves, allowing node modules to specify ignored patterns. Not idea, because projects would need to add code just for us, but it does help address the issue that everyone needs to configure each project.

re: custom keys in package.json, i think we should support nested .flowconfigs for things like this... but I don't know that I've thought enough about the implications of that.


Method overriding when extends

class MyEventSource extends EventSource {
  close() {
    console.log('My close function call')
  }
}

const es = new MyEventSource(...)
es.close()

In the Browser (Chrome or Firefox) the output is:
My close function call

But in the NodeJS the output is:
undefined

Because my close function does not override the EventSource.close function.

Fixed in v1.0.2


*: remove static deployment manifests

As in title.
Reasoning behind this change is that in those manifests we are setting database password to a well-known string and distributing it in multiple places. After deploying, this is hard to change and quite problematic. Instead we should be pointing folks to use CLI or helm charts.
@cevian @VineethReddy02 I don't intend to merge it now as this is something we should talk about.

Related to #237

Moving from draft to review as we agreed on this in tobs future meeting.


[Converter support] Support creating ONNX dialect in other IRs

onnx script is going to be great for the conversion process in pytorch. The torch exporter uses the onnx dialect in TorchScript, before going through a few additional passes and eventually generating an onnx proto. (So we cannot create onnx protos directly)
It would be very helpful to be able to delegate the graph building process to another object / entity. For example, we can create a wrapper around torch's graph.op method so that each graph building call is delegated to graph.op, allowing it to build a torch script graph.
One way of doing this can be exposing the graph building APIs so we don't need to rely on @script and the source code for constructing the graph.
cc @BowenBao

Possible via evaluators

Replaced by #273


HTTP::InvalidHeaderNameError: Invalid HTTP header field name: "Accept:/\r"

View details in Rollbar: https://rollbar.com/hackerbase/API-Fuzzer/items/89/

HTTP::InvalidHeaderNameError: Invalid HTTP header field name: "Accept:*/*\r"
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/http-2.0.3/lib/http/headers.rb", line 201, in normalize_header
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/http-2.0.3/lib/http/headers.rb", line 51, in add
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/http-2.0.3/lib/http/headers.rb", line 180, in block in coerce
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/http-2.0.3/lib/http/headers.rb", line 180, in each
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/http-2.0.3/lib/http/headers.rb", line 180, in coerce
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/http-2.0.3/lib/http/headers.rb", line 152, in merge!
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/http-2.0.3/lib/http/headers.rb", line 160, in block in merge
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/http-2.0.3/lib/http/headers.rb", line 160, in tap
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/http-2.0.3/lib/http/headers.rb", line 160, in merge
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/http-2.0.3/lib/http/options.rb", line 62, in block in <class:Options>
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/http-2.0.3/lib/http/options.rb", line 35, in instance_exec
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/http-2.0.3/lib/http/options.rb", line 35, in block (2 levels) in def_option
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/http-2.0.3/lib/http/options.rb", line 126, in dup
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/http-2.0.3/lib/http/options.rb", line 35, in block in def_option
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/http-2.0.3/lib/http/chainable.rb", line 176, in headers
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/bundler/gems/API-fuzzer-575658e767ee/lib/API_Fuzzer/request.rb", line 32, in set_cookies_headers
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/bundler/gems/API-fuzzer-575658e767ee/lib/API_Fuzzer/request.rb", line 14, in send_api_request
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/bundler/gems/API-fuzzer-575658e767ee/lib/API_Fuzzer/xss_check.rb", line 44, in block in fuzz_each_parameter
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/bundler/gems/API-fuzzer-575658e767ee/lib/API_Fuzzer/xss_check.rb", line 43, in each
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/bundler/gems/API-fuzzer-575658e767ee/lib/API_Fuzzer/xss_check.rb", line 43, in fuzz_each_parameter
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/bundler/gems/API-fuzzer-575658e767ee/lib/API_Fuzzer/xss_check.rb", line 36, in block in fuzz_each_payload
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/bundler/gems/API-fuzzer-575658e767ee/lib/API_Fuzzer/xss_check.rb", line 35, in each
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/bundler/gems/API-fuzzer-575658e767ee/lib/API_Fuzzer/xss_check.rb", line 35, in fuzz_each_payload
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/bundler/gems/API-fuzzer-575658e767ee/lib/API_Fuzzer/xss_check.rb", line 27, in block in scan
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/bundler/gems/API-fuzzer-575658e767ee/lib/API_Fuzzer/xss_check.rb", line 26, in each
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/bundler/gems/API-fuzzer-575658e767ee/lib/API_Fuzzer/xss_check.rb", line 26, in scan
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/bundler/gems/API-fuzzer-575658e767ee/lib/API_Fuzzer.rb", line 21, in scan
  File "/Users/Lalith/src/Fuzzapi/app/workers/scan_vulnerability_worker.rb", line 9, in perform
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb", line 152, in execute_job
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb", line 134, in block (2 levels) in process
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/sidekiq-4.1.4/lib/sidekiq/middleware/chain.rb", line 128, in block in invoke
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/newrelic_rpm-<IP_ADDRESS>7/lib/new_relic/agent/instrumentation/sidekiq.rb", line 33, in block in call
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/newrelic_rpm-<IP_ADDRESS>7/lib/new_relic/agent/instrumentation/controller_instrumentation.rb", line 362, in perform_action_with_newrelic_trace
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/newrelic_rpm-<IP_ADDRESS>7/lib/new_relic/agent/instrumentation/sidekiq.rb", line 29, in call
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/sidekiq-4.1.4/lib/sidekiq/middleware/chain.rb", line 130, in block in invoke
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/sidekiq-4.1.4/lib/sidekiq/middleware/server/active_record.rb", line 6, in call
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/sidekiq-4.1.4/lib/sidekiq/middleware/chain.rb", line 130, in block in invoke
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/sidekiq-4.1.4/lib/sidekiq/middleware/server/retry_jobs.rb", line 74, in call
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/sidekiq-4.1.4/lib/sidekiq/middleware/chain.rb", line 130, in block in invoke
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/sidekiq-4.1.4/lib/sidekiq/middleware/server/logging.rb", line 11, in block in call
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/sidekiq-4.1.4/lib/sidekiq/logging.rb", line 32, in with_context
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/sidekiq-4.1.4/lib/sidekiq/middleware/server/logging.rb", line 7, in call
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/sidekiq-4.1.4/lib/sidekiq/middleware/chain.rb", line 130, in block in invoke
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/sidekiq-4.1.4/lib/sidekiq/middleware/chain.rb", line 133, in call
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/sidekiq-4.1.4/lib/sidekiq/middleware/chain.rb", line 133, in invoke
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb", line 129, in block in process
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb", line 168, in stats
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb", line 128, in process
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb", line 80, in process_one
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb", line 68, in run
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/sidekiq-4.1.4/lib/sidekiq/util.rb", line 17, in watchdog
  File "/Users/Lalith/.rvm/gems/ruby-2.2.2/gems/sidekiq-4.1.4/lib/sidekiq/util.rb", line 25, in block in safe_thread

Fixed in latest version


The data or model about Concatenate text segments

Thanks for sharing great work!
Could you share the data or model about Concatenate text segments? Or tell me how to deal with the data of "Concatenate text segments"

Sorry about the late response. Thanks for your attention in CED~
Thanks for your mention. I'll publish the data and scripts within this week. Please leave this issue open until the code is open-sourced.

Hi there. Sorry for the long waiting. The text concatenation dataset pre-processing is acturally a little complex.
When talking about text concatenation, there are two methods for different usage:

Spliting the raw wiki data into chunks for each node: Since the processed datasets have been provided, you may want to know how did we split sentences and titles into chunks. Here's the script: https://github.com/Spico197/CatalogExtraction/blob/main/doctree/utils/make_further_split.py . Please install jieba before running, and beaware that the provided datasets have already been chunked.
For training the pipeline baseline system: I had uploaded the data and script before at: https://github.com/Spico197/CatalogExtraction/releases/tag/data-v1-patch


Prevent storing negative tagged memory allocations

I think it's redundant to: https://github.com/prestosql/presto/pull/602/commits/f929280a2d56fe4ef822d638c9ccdbf690c5e9d2

@sopel39 I assumed that negative values were illegal. Please do put up a PR for your fix.

@electrum fix landed as part of https://github.com/prestosql/presto/pull/602


Unit testing with ComponentsHelper

Hi,
I have an issue with my unit test using ComponentsHelper.
Before I used to inject a ComponentFactoryResolver and an Injector every time I wanted to create a component and my tests were fine.
I was doing this in my app :
const injector = this.buildStructureComponentInjector();
const factory = this.componentFactoryResolver.resolveComponentFactory(StructureComponent);
// Create component
const componentRef = this.structuresLocation.createComponent(factory, null, injector);

And now I do this :
const structureRef = this.componentsHelper.appendNextToLocation(StructureComponent, this.structuresLocation, this.getStructureProviders());
In my tests, I have that error :

Error: No component factory found for StructureComponent

I already have StructureComponent in my entryComponents array of app module and the app is working fine.
So, how do you deal with ComponentsHelper test ?

I removed it completely, please try v1.1.16-7
Docs preview here http://valorkin.github.io/ng2-bootstrap/#/


(cosmos) @Query not working with list

        <dependency>
            <groupId>com.azure</groupId>
            <artifactId>azure-spring-data-cosmos</artifactId>
            <version>3.5.0</version>
        </dependency>

Below is the Query I use, but it returns empty results,
  @Query(value = "SELECT * FROM r "
               + "WHERE ( r.environmentCode = @environmentCode) "
               + "AND (@hopDistinctName = null or r.hopDistinctName IN (@hopDistinctName)) "
              )
     Page<ExceptionTransaction> findAllExceptionTransaction(
               @Param("environmentCode") Integer environmentCode,
               @Param("hopDistinctName") List<String> hopDistinctNames,
               Pageable pageable);

I am using @hopDistinctName = null or r.hopDistinctName IN (@hopDistinctName to ignore null value.
And with this SQL statement, I am able to get the results:
SELECT * FROM c WHERE c.environmentCode = 100
AND c.hopDistinctName IN  ("Response Transformation")

Anything wrong with my @Query?
Is there any way I can log the actual SQL statement?
This is the logging from SqlQuerySpecLogger:
2021-03-23 22:28:56,940 DEBUG [http-nio-8080-exec-8] com.azure.cosmos.implementation.SqlQuerySpecLogger  logQuery - select * from (SELECT * FROM r WHERE ( r.environmentCode = @environmentCode) AND (r.countryCode = @countryCode) AND (r.instanceTypeCode = @instanceTypeCode) AND (r.scenarioName = @scenarioName) AND (@hopUuid = null or r.hopUuid = @hopUuid) AND (@hopType = null or r.hopType = @hopType) AND (@originalMessageId = null or r.originalMessageId = @originalMessageId) AND (@testFlag = null or r.testFlag = @testFlag) AND (@replayBatchId = null or r.replayBatchId = @replayBatchId) AND (@hopDistinctName = null or r.hopDistinctName IN (@hopDistinctName)) AND (r.messageTimestamp BETWEEN @rangeStart AND @rangeEnd) ) r ORDER BY r.messageTimestamp ASC > param: @environmentCode = 100 > param: @countryCode = US > param: @instanceTypeCode = 1 > param: @scenarioName = ESB1424_SAPS4_CILL > param: @hopUuid = null > param: @hopType = null > param: @originalMessageId = null > param: @testFlag = false > param: @rangeStart = 2021-02-10T22:03:48.802Z > param: @rangeEnd = 2021-02-10T23:59:59.999Z > param: @replayBatchId = null > param: @replayStatus = null > param: @errorCode = null > param: @hopDistinctName = ["Response Transformation"]

@kushagraThapar would you please answer this?

@mbhaskar  - can you please help the customer here with query annotations ?

ya, @mbhaskar  please help

@mbhaskar will you have time to take a look at this issue?

@loudywen do you get results when you remove this @hopDistinctName = null or  from the annotated query?

@mbhaskar  I do get results after removed @hopDistinctName = null
But with this SQL statement I am able to get results:
SELECT * FROM c WHERE c.environmentCode = 100
AND c.hopDistinctName IN  ("Response Transformation")

@mbhaskar  have you been facing the same issue?

@chenrujun  @saragluna @mbhaskar  hi is any progress for this one?

I think because it is not building the content of the IN properly.
Since if I use this       @Query(value = "SELECT * FROM c WHERE c.environmentCode = 100 and c.hopDistinctName IN (\"test\")")      List<AuditTransaction> findAllAuditCustom4(); without the parameter place holder in the query, I am able to get the data

Also if i change the
  @Query(value = "SELECT * FROM r "
               + "WHERE ( r.environmentCode = @environmentCode) "
               + "AND (@hopDistinctName = null or r.hopDistinctName IN (@hopDistinctName)) "
              )
     Page<ExceptionTransaction> findAllExceptionTransaction(
               @Param("environmentCode") Integer environmentCode,
               @Param("hopDistinctName") List<String> hopDistinctNames,
               Pageable pageable);

the List<String> to String then it will work

FYI @backwind1233.

Since the @Query for IN is not working, can someone tell me how can I build the Criteria for the below SQL statement:
select *
from auditTransaction
where EXISTS(
        SELECT *
        FROM n IN auditTransaction.businessIdentifiers
        WHERE n.data IN ("hi")
    )

@ZhuXiaoBing-cn would you please take a look at it?

Hi, @loudywen, I found that the client doesn't support making list SqlParameter that could be used for in clauses: Azure/azure-cosmosdb-java#60.
Here are some practices for reference:

You can try something like this:

String query = "SELECT * from c where c.prop IN (@param1, @param2)";
SqlParameterCollection params = new SqlParameterCollection(new SqlParameter("@param1", 98), new SqlParameter("@param2", 99));
SqlQuerySpec sqs = new SqlQuerySpec(query, params);

https://github.com/ankagrawal/ambry/blob/f72d240e13f1911e3abfdebec5df7e405b878b67/ambry-cloud/src/main/java/com.github.ambry.cloud/azure/AzureCloudDestination.java#L320-L321

list.stream().map(s -> '"' + s + '"').collect(Collectors.joining(","));

@All is this closed ? What is solution to pass the list as parameter?
private SqlQuerySpec getQuery(List<Integer> namesList) {
	ArrayList<SqlParameter> paramList = new ArrayList<SqlParameter>();
    paramList.add(new SqlParameter("@names", namesList));
    SqlQuerySpec querySpec = new SqlQuerySpec(
            "SELECT * FROM Test t WHERE t.name in(@names)",
            paramList);
    return querySpec;
}

@viswa-optimusprime For List parameters, the current practice is to convert List to String.
list.stream().map(s -> '"' + s + '"').collect(Collectors.joining(","));

@mbhaskar , @backwind1233 : I'm sorry if this is unrelated question on this issue.
I wanted to know the maximum number of parameters we can pass to the IN clause in cosmos.
Could you please help with a number so that I can handle the bottlenecks in my project.
Thanks!

@xinlian12 could you help review this issue?

@rajesh-melige  - I don't think there is any limit to no. of parameters in IN clause  - https://docs.microsoft.com/en-us/azure/cosmos-db/sql/sql-query-keywords#in
But I guess, the more params you pass, the slower will be the query, because then it would need to filter more.

private SqlQuerySpec getQuery(List namesList) {
ArrayList paramList = new ArrayList();
paramList.add(new SqlParameter("@names", namesList.stream().collect(Collectors.joining("','", "'", "'"))));
SqlQuerySpec querySpec = new SqlQuerySpec(
"SELECT * FROM Test t WHERE t.name in(@names)",
paramList);
return querySpec;
}


[Alarms & Timers] Fix "Enable All"

I found a bug with a disabled timer + enable all action: the enable all does not update the timer field. This PR fixes the bug :-)

Thanks!


missing autoload.php

There is line #34 in file /examples/example-captcha.php:
require_once __ DIR __ . '/../vendor/autoload.php';
But there is no such file in the library.

right, the vendor dir is automatically created by composer. If you not use composer you have to use an autoloader class like this https://gist.github.com/jwage/221634 or in a fast way for a simple test, just include all files.

I've made the comment in the example a bit clearer:
ac5696b7455de4e2f5ef8c9788e475514c3819f8


Jest Snapshot Testing Issues

Any advice on getting this this to work with Jest Snapshots? My teammate added this to a functional component I wrote:
const methods =  {
  componentDidMount(props) {
    console.log('props',props)
    props.setNavFlagToDashboard()
  }
}

export default lifecycle(methods)(FunctionalComponent)

Which leads to this output when running the test:
TypeError: props.setNavFlagToDashboard is not a function
Any advice on how best to approach this?

It's hard to sufficiently answer that question without seeing the test itself. Can you provide the test code as well?

Well based on this it simply looks like you're not passing the function prop in question to the component. Have you tried just passing in a noop function?
shallow(<BlogList setNavFlagToDashboard={() => {}} />)

Yes, no luck though. I'll dig into it more when this project is over - thanks for taking a look!

So I just released 3.0.0, but that was just a refresh of the codebase for modern approach ... I didn't actually change anything functionally, so updating should have no impact on your codebase (except tree-shaking is now active, since you use webpack :smiley_cat: ).
I also added a test to try to reproduce, and couldn't, so hopefully this example provides some guidance:
test('if snapshots work as expected', (t) => {
  const onMount = ({doThing}) => doThing();
  const spy = sinon.spy();

  const DummyComponent = componentDidMount(onMount)(FunctionalComponent);

  const wrapper = shallow(<DummyComponent doThing={spy} />);

  t.true(spy.calledOnce);

  t.snapshot(toJson(wrapper));
});

This is with AVA, not Jest, but that should not make a difference ... likely it was in the way you were applying things.


Unwanted sticky column at the end of the table

An extra, empty, stickied-to-the-left column gets drawn on the table. If the content is larger than the allocated place and it becomes scrollable, the said column will overlap the content.
See my modified example: the said column is with yellow background.
https://stackblitz.com/edit/icell-datatable-demo-angular11-sgswyx?file=src/app/app.component.ts

Is there a purpose behind that and I using the table wrong, or is it a bug?

it's not a 🐛, it was simply the fast solution, to introduce the columns selector, to be visible all the time, I looked into some solution, but no luck yet, feel free to investigate 👀

I'll look into it next week - in the meanwhile, a quick fix I used in our implementation is to hide the last  in each line with CSS.


Minor Admin UI changes, typos/ naming updates/ positioning

In the left hand menu under Search change Maker to Makers
In the right hand listing when you go to Admin/ Search/ Makers and you see the list, the title at the top says Maker Groups, it should just say Makers
When you click on the maker to view the details before editing (Admin/ Search Makers/ Maker detail) you don't see every field for that maker - it might be  better to just jump straight into the edit details screen rather than view a subset of the detail and then having to click on update details to then edit them?

as you wish, I'll improve that screen anyways


Remove superset-connector.d.ts

This file is not necessary.  Superset Connector has its own type definitions now https://github.com/onaio/js-tools/tree/master/packages/SupersetConnector/dist/types

This file was already removed, so going to close this issue.


MUMUP 2510, 2511, 2512 UW-Colleges, UW-Eau Claire, UW-Extension

Coverage remained the same at 34.738% when pulling f141c35158d38a9f3adfb9083106d3aa2a418d84 on jiayinjx:add-theme into fb3ff2e9fd85f59af77497b080a04b14b7748589 on UW-Madison-DoIT:master.

:+1: please be sure to move these stories into the sprint and then "move to TEST" them.


modules: Update to rebased hal_silabs

Update to latest upstream main tree and a rebased hal_silabs tree.

@jerome-pouiller @asmellby our hal_silabs fork (silabs branch) has now been rebased to latest upstream. There's sliabs-old that points at the ref before the rebase. I've added the "DNM" label, since I still want to wait for some upstream PRs from Aksel to get merged before we update our main tree pointer. In practice I'll likely go for the 4.0.0-rc1 tag once that has been created.

Now updated to 4.0.0-rc1


Refs #21286 -- Enabled ImageField data in serializer data tests.

This patch tests ImageField in the serializer data tests in the same way that FileField is tested. This includes one commented-out test.
The commented-out test is a good addition because it implies that because ImageField is a subclass of FileField, the tests are commented-out for the same reason. They can both be enabled when ticket 10244 is resolved.
Trac ticket number
ticket-21286
Branch description
This patch tests ImageField in the serializer data tests in the same way that FileField is tested. This includes one commented-out test.
The commented-out test is a good addition because it implies that because ImageField is a subclass of FileField, the tests are commented-out for the same reason. They can both be enabled when ticket 10244 is resolved.
Checklist

[x] This PR targets the main branch.
[x] The commit message is written in past tense, mentions the ticket number, and ends with a period.
[x] I have checked the "Has patch" ticket flag in the Trac system.
[x] I have added or updated relevant tests.
[x] I have added or updated relevant docs, including release notes if applicable.
[x] I have attached screenshots in both light and dark modes for any UI changes.

@sarahboyce What is your preference? I hope to start working on ticket-10244 soon.

@sarahboyce What is your preference? I hope to start working on ticket-10244 soon.

If you're working on ticket-10244 let's leave it like this for now :+1:


Cosmetic changes to graceful shutdown code

Use constant instead of magic number
Let the operator know mldb that the container is being shut down

+1


Add an editing the page

Type of feature
🍕 Feature
Current behavior
I noticed that the repository is missing edit this page buttons.
Suggested solution
I think we should add one. To stay consistent with the other repos.

Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[X] I agree to follow this project's Contribution Docs

@open-sauced/triage, what do you think?


Fixed #2614. Content length of the body of the Post request is calcul…

…ated properly when using OAuth 1.0 and 'form' object and transport_method=body
PR Checklist:

[x] I have run npm test locally and all tests are passing.
[x] I have added/updated tests for any new behavior.

PR Description
Fixes https://github.com/request/request/issues/2614 and possibly https://github.com/request/request/issues/2599

Content-length of the body is calculated after OAuth because OAuth can update body if transport_method=body.

So who can merge this, @Huachao ?

@dvishniakov sorry, I am not a collaborator of this project, and just have interest in reviewing your code. I think @FredKSchott have this permission.

@FredKSchott can you advice how to proceed?

@mikeal any ideas how is it possible to make some progress here? Thanks

@simov hi, any ideas how is it possible to make some progress here? Thanks


reported sunrgbd result

Hi,
Thanks for your work. I want to evaluate the network on the sunrgbd dataset. I was wondering how do you evaluate the model on the SUN RGBD dataset. It seems that f pointnet does not provide 2d detection results for sun rgbd dataset. Did you train your own rgb detector on the sunrgbd dataset, or use the gt boxes?
Best

We train faster-rcnn with the backbone network fo ResNet50 to provide the 2D detection results of SUNRGBD. We get a similar 2D detection result as f-poinnets.  The reported results are based on this 2D detector.
If we use the ground truth 2D boxes, we can get a very high 3D detection mAP.

Hi zhixin,
thank you for your reply. Would you mind share your mAP on SUN RGB-D under IoU 0.5? I would like to make a comparison while cannot find that in your paper

I have replyed your email.

hi, i want to know how to visualize the output of SUNRGBD ? please help me @zhixinwang @timetomakesense


Rename onTraversalDone() to onTraversalSuccess() and clarify the docs

Currently, the engine-level shutdown routine onShutdown() is always invoked, even when an exception occurs during traversal, but the tool-level shutdown routine onTraversalDone() is not wrapped within a finally block and so not invoked when an exception occurs. Do we want it to always be invoked? Some tools might be designed on the assumption that onTraversalDone() will only be reached if the traversal completed start to finish without error (and so it's appropriate to generate certain final output, etc.), while other tools might prefer it to always be invoked so that resources can be closed. Thoughts?

agreed. onTraversalDone should be renamed to onTraversalSuccess and doc clarified to reflect the semantics.

Depends on https://github.com/broadinstitute/hellbender/issues/121

alpha candidate?


 I forked quite some time ago, and made a bunch of minor changes primarily around the generator to make it work with all the different fields I could find/think of, and added zap logging. Besides that just some minor comments and things I think, only thing that isn't tested fairly well, is I just added a timeout in frame/layer.go to fix a lock up issue I was getting. I don't like just blindly adding the time out there, but it worked for me so eh. :man_shrugging: Just thought I would share in case you  guys are interested in any of the changes. If so we can try to cherry pick w/e important  things we want. Also added custom method for subscribing to events and such. Quite a few things not too sure what.

@gregadams4 Where did you branch from? Was it master? If so, the https://github.com/gozwave/gozw/tree/refactor-gen branch I updated the generator to use a newer version of the xml found here. Could you compare what you did with what I did and see if we can combine the best parts of both? It's hard for me to compare with the generated code updated.


Update SustainabilityUseCasesAndLandscape2023.md

I have added my name in SustainabilityUseCasesAndLandscape2023 article.

This is a list of people who have added content.  Do you have content to add to this article?  Or have you already, and had we missed that?

I thought I was adding people to be active in the tag-env-sustainability document.
sorry. ^^;;

That's a great idea!  We clearly need a list of active members!  I'll look at how tag-security does that.


invoke() cannot be resolved in some cases

The output of the invoked commands may be concatenated to the output of the EOI writing command. In some situations, the chunk passed in the _write() function contains not only the EOI string but also the output of the previously executed command. This issue will make the invoke function is stuck and never be resolved. Instead of comparing the chunk with the EOI string, I suggest checking if the chunk containing the EOI string.

Guys. i was having the exact same problem randomy. I think this fix may be helping. Do you lnow when it will be integrated in Master Branch?

Guys. i was having the exact same problem randomy. I think this fix may be helping. Do you lnow when it will be integrated in Master Branch?


Dependency management

We could of course use plain git submodules, but what if we only need only one file or folder from an external git repo, http url or even helm chart/templates ?
I would like to introduce the concept of modular dependencies in kapitan, and it would look something like this:
parameters:
  kapitan:
    compile:
    ...

    dependencies:
    - type: git
      output_path: ../../lib
      source: git@github.com:grafana/grafonnet-lib.git
      subdir: grafonnet
      version: 0.1
    - type: http
      output_path: ../../lib
      source: https://raw.githubusercontent.com/bitnami-labs/kube-libsonnet/master/kube.libsonnet
      version: 0.1

In this scenario, kapitan compile will pull github.com/grafana/grafonnet-lib/grafonnet/* and github.com/bitnami-labs/kube-libsonnet/master/kube.libsonnet into lib at the root. Dependencies will be cached and only re-pulled when the version changes, keeps things simple and we don't need to implement an extra kapitan subcommand.
Users have full control of what the source can be (jsonnet, libsonnet, jinja2 templates, k8s manifests etc.) and where it's placed inside the project (output_path), can be per target, class or global.
In terms of modularity, each type can be defined as a separate python module with the same name, as in kapitan/kapitan/dependencies/git.py will control the functionality of type: git; in the example above, subdir is a git module specific variable, we can also add branch, release etc.
@ademariag @gburiola @ramaro What do you think?

FYI there's an effort to create a standard dependency management for jsonnet, called jsonnet-bundler. I think the authors have thought it out pretty well. I see you want to do deal with much more than just jsonnet, so I'm not sure how relevant it is.
repo: https://github.com/jsonnet-bundler/jsonnet-bundler
doc: https://docs.google.com/document/d/1czRScSvvOiAJaIjwf3CogOULgQxhY9MkiBKOQI1yR14/edit?usp=sharing

Yes we've seen that, we can easily create a dependency module specifically for jsonnet (type: jsonnet) that uses the standard. The idea is still very fresh, once it's a bit more mature we will take a look :)

@sbarzowski Forgot to mention, we merged #133 a while ago, which allows the usage of jsonnet-bundler to pull external dependencies and reference them inside kapitan.

My 2C on the subject: I don't think kapitan be responsible for managing these kinds of dependencies as it will needlessly grow in complexity since it will be managing dependencies of other tools, like jsonnet or Python, and we know the latter is already a mess with a plethora of tools and different dependency management tools.
A more generic and simpler approach IMO would be having pre-conditions for compilation. This way the user is responsible for its build environment, but kapitan is able to check if the needed tools are found.
tldr: if kapitan is already free from managing Python dependencies, why should it manage jsonnet ones (or any other, for that matter)?

I believe (correct me if I'm wrong, anyone) this issue isn't about build/runtime type dependencies like you're describing, but having kapitan configuration that's dependent on other repositories or sources of kapitan (or relevant jsonnet/jinja snippets, etc) config, i.e., having a some-app config repo that references an external standard-myorg-app-base as a parent, and/or pulls in a common envoy-sidecar one as a mixin.

@adrianchifor.  As mentioned by caioaao we don't want a complex dependencies manager. Only a checker which find whether we are using specific version  or not. If not, tell user to use that version.
    dependencies:
    - type: jsonnet
      module: kube
      version: 0.12

Also,  just to clarify, if a user has installed kapitan with jsonnet version 0.11 and is using python 2.7. So, if user try run kapitan on main.jsonnet with version specific as 0.12, kapitan should raise warning. Right?

@harsh-98 Jsonnet versions are already managed in requirements.txt and you can pin kapitan to a version by specifying version: <kapitan version> in .kapitan. We need a way to pull external dependencies like jsonnet/kadet libs and helm charts from git repos or http endpoints, bring them in and manage the versioning of them to know when to check/re-pull them.

And that's exactly what I'm arguing against. Kapitan should manage kapitan dependencies, not jsonnet/Kadet/helm/whatever is next. Each of those are external tools and, as such, should have external dependency managers. Kapitan will become impossible to maintain otherwise

@caioaao we're not talking about supporting dependency management for external tools.
This is for kapitan depedencies. For example, this would simplify importing a project from another repository into your current template repository as @nikkomega mentioned above.

We had https://github.com/deepmind/kapitan/issues/197 for allow custom scripts during compilation but now that https://github.com/deepmind/kapitan/pull/267 is merged, people can write and import custom jinja filters. Also, running scripts on compile would not be able to keep track of dependencies, like when to re-pull. Yes https://github.com/deepmind/kapitan/issues/143 is a subtask of this.

@adrianchifor @uberspot
Just looking at #290, do you think it makes sense to support copy of local files via this feature?

@uberspot yeah, just as another input type file (or some other appropriate name) on top of http[s] and git.

File:// is defined in rfcs https://en.m.wikipedia.org/wiki/File_URI_scheme so it's a good contender for that. sounds good to me otherwise. :)

Is there any reason, why this issue is still open after #304 is merged?

@prakashrj the only reason is that we forgot to close! Thanks :)


Unable to control the logger from v.2.0.0 or newer

In my application I am using the Python logging library and it was not having problems with api4jenkins till the version v1.15.0. As soon as I have started using a newer version, I get such messages in my logs for all operations:
2023-12-12 16:09:36 INFO     HTTP Request: GET https://jenkins.mycompany.com/crumbIssuer/api/json "HTTP/1.1 200 OK"
2023-12-12 16:09:36 INFO     HTTP Request: HEAD https://jenkins.mycompany.com/ "HTTP/1.1 200 OK"
2023-12-12 16:09:36 INFO     HTTP Request: GET https://jenkins.mycompany.com/user/myuser/api/json?depth=0 "HTTP/1.1 200 OK"
2023-12-12 16:09:36 INFO     HTTP Request: GET https://jenkins.mycompany.com/user/myuser/api/json?depth=0&tree=id "HTTP/1.1 200 OK"
2023-12-12 16:09:36 INFO     HTTP Request: GET https://jenkins.mycompany.com/user/myuser/api/json?depth=0&tree=absoluteUrl "HTTP/1.1 200 OK"
2023-12-12 16:09:36 INFO     HTTP Request: GET https://jenkins.mycompany.com/user/myuser/api/json?depth=0&tree=fullName "HTTP/1.1 200 OK"

It looks like sometimes these logs even lead to a The read operation timed out error which interrupts my application. I have tried to control the logger as follows:
import logging
...
jenkins_logger = logging.getLogger('api4jenkins')
jenkins_logger.setLevel(logging.CRITICAL)

but whatever log level I set, I still get the same high amount of log messages. The last 2 rows above were not necessary in the v1.15.0 version.
I am using Python 3.10.13 and I have encountered this issue with api4jenkins v2.0.0, v2.0.1 and v2.0.2. These versions have 3 loggers: api4jenkins.item, api4jenkins and api4jenkins.http. Instead the v1.15.0 version has 2 loggers: api4jenkins.requester and api4jenkins.

@vittoriocanilli  logger in item.py is unnecessary, i will remove the line.  but how to reproduce the issue, are you able to share more detail ?

@joelee2012 I have found out how to mute the logs, as I have seen in the change logs that requester has been replaced by httpx:
import logging
...
jenkins_logger = logging.getLogger('httpx')
jenkins_logger.setLevel(logging.CRITICAL) # even logging.ERROR will be fine

But it looks like it wasn't the excessive logs leading to the application error, as I assumed previously. I actually get a httpx.ReadTimeout exception with The read operation timed out as message when I try to update a job (a GitHub organization in my case) with the following command:
from api4jenkins import Jenkins
j = Jenkins('http://<IP_ADDRESS>:8080/', auth=('username', 'password or token'))
j.get_job('my_github_org').configure("<?xml version='1.1' encoding='UTF-8'?><my_github_org_xml/>")

It succeed sometimes, but it fails 80% of the times, while it always worked with the v1.15.0 version. Is there a way to set a higher timeout? I did not change anything on my Jenkins instance.

@joelee2012 eventually I have found this paragraph in the documentation, which leads to more information on using HTTPX , so I could find out how to set its timeout.
Just to recap, here is how I solved the issues:
import logging
from api4jenkins import Jenkins
...
httpx_logger = logging.getLogger('httpx') # <- setting HTTPX log level
httpx_logger.setLevel(logging.CRITICAL) # <- setting HTTPX log level
...
j = Jenkins('http://<IP_ADDRESS>:8080/', auth=('username', 'password or token'), timeout=10) # <- setting HTTPX timeout
j.get_job('my_github_org').configure("<?xml version='1.1' encoding='UTF-8'?><my_github_org_xml/>")


Adding textDocument\foldingRange support for the language server

Is your feature request related to a problem? Please describe.
Being able to collapse long docstrings/adjacent single line comments/adjacent open statements into single lines can greatly improve readability (prime example: Quantum Katas, Basic Gates task).
Describe the solution you'd like
Support for the textDocument\foldingRange language server protocol message.
Describe alternatives you've considered
N/A
Additional context
Currently working on this for the OneWeek hackathon!

On hold until the Visual Studio SDK is updated to >= 16.1.3121, which depends on this issue being fixed.

@tmcrain Is there a branch with the WIP? Also, let me know if you feel like picking up something else. :)

Looks like the blocking issue above has been fixed. :)