Alternative pattern to setState callback?

I'm in the midst of complex animations and transitions. React's setState supplies the callback that guarantees the DOM to be updated. Since mobx doesn't have a post re-render callback, what is a common pattern to use?
The only three viable solutions I came up with are:

setTimeout, I'm not confident in the reliability of this in most use cases
componentDidUpdate conditional triggers based on instance variables, but this gets messy and breaks the flow of animation instructions
Basic "nextRenderQueue" instance variable that's an array of functions (self-rolled quasi-callback) that's executed/emptied in componentDidUpdate. This works in my situation but seems sort of hacky.

I looked through SO, mobx repo, and mobx-react repo, but I can't seem to find an agreed upon solution.

For animations I would go for using mobxUtils.now('frame') (an observable
that produces the current time on every available requirestAnimationFrame)
in your rendering and interpolate. But with componentDidUpdate it should be
possible to achieve it as well indeed.
Op za 2 dec. 2017 om 03:38 schreef Justin Abene<EMAIL_ADDRESS>
I'm in the midst of complex animations and transitions. React's setState
supplies the callback that guarantees the DOM to be updated. Since mobx
doesn't have a post re-render callback, what is a common pattern to use?
The only three viable solutions I came up with are:

setTimeout, I'm not confident in the reliability of this in most use
cases
componentDidUpdate conditional triggers based on instance variables,
but this gets messy and breaks the flow of animation instructions
Basic "nextRenderQueue" instance variable that's an array of
functions (self-rolled quasi-callback) that's executed/emptied in
componentDidUpdate. This works in my situation but seems sort of hacky.

I looked through SO, mobx repo, and mobx-react repo, but I can't seem to
find an agreed upon solution.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mobxjs/mobx-react/issues/369, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABvGhHS1o9RvalIJNcYmy4V87nkHlivvks5s8Lg7gaJpZM4QzI0l
.

@mweststrate With my current scenario I'm mainly dealing with GSAP, so I don't need to tap intorequestAnimationFrame yet. Mostly it's onComplete GSAP handlers in sequences. There's a lot of situations where DOM elements are added/removed mid-animation chain via isVisible... observables. Moving things into componentDidUpdate breaks that logic chain, but also adds other logic to figure out where/when to resume or what not to animate since componentDidUpdate will fire for numerous reasons unrelated to animation.

The problem is not entirely clear without example of what you are trying to achieve, but it is not possible in the Mobx model to attach callback about when something has rendered beyond componentDidUpdate. Mobx-react relies on the internal mechanism in React to batch and schedule renders, and doesn't keep track of whether and when something is rendered but relies on the eventual consistency of the rendering instead.


test(e2e): use wrangler for ci e2e tests

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:white_check_mark: All tests successful. No failed tests found.


Treating XHTML as HTML breaks cross-platform CFI consistency

Due to what I believe to be a behavior of libxml2, XHTML content from within an EPUB has the following meta tag added if no http-equiv="Content-Type" meta tag exists:
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />

This causes browsers to interpret XHTML documents as HTML which in turn triggers browser fallback behavior that results in radically different DOMs across browsers. As such, the logic for calculating CFIs produces CFIs that are not portable across platforms.
Thank you to @JCCR for helping me debug this issue.
This issue is a bug.
Expected Behaviour
Readium produces CFIs that are portable across Android and iOS.
Observed behaviour
Readium does not.
Test file(s)
Here is a single XHTML file from an EPUB (source.xhtml) along with the DOMs produced for Android and iOS:
https://gist.github.com/winniequinn/b0865f110ffc821e2e583bfa51c30f17
Product
Native application (Readium SDK C++)

If I remember correctly , the application/xhtml+xml HTTP content-type is correctly included in the response created by the Android and iOS apps' respective HTTP servers. Let me find the source code references...

Android:
https://github.com/readium/SDKLauncher-Android/blob/master/SDKLauncher-Android/app/src/main/java/org/readium/sdk/android/launcher/util/EpubServer.java#L85-L86
https://github.com/readium/SDKLauncher-Android/blob/0bd7eb1ac88616a1eba3dfe27dd5d93c17d8ef44/SDKLauncher-Android/app/src/main/java/org/readium/sdk/android/launcher/util/EpubServer.java#L85-L86
tmpMap.put("html", "application/xhtml+xml"); // FORCE
tmpMap.put("xhtml", "application/xhtml+xml"); // FORCE

https://github.com/readium/SDKLauncher-Android/blob/master/SDKLauncher-Android/app/src/main/java/org/readium/sdk/android/launcher/util/EpubServer.java#L209-L229
https://github.com/readium/SDKLauncher-Android/blob/0bd7eb1ac88616a1eba3dfe27dd5d93c17d8ef44/SDKLauncher-Android/app/src/main/java/org/readium/sdk/android/launcher/util/EpubServer.java#L209-L229
		String mime = null;
		int dot = uri.lastIndexOf('.');
		if (dot >= 0) {
			mime = MIME_TYPES.get(uri.substring(dot + 1).toLowerCase());
		}
		if (mime == null) {
			mime = "application/octet-stream";
		}

		ManifestItem item = pckg.getManifestItem(uri);
		String contentType = item != null ? item.getMediaType() : null;
		if (!mime.equals("application/xhtml+xml")
				&& !mime.equals("application/xml") // FORCE
				&& contentType != null && contentType.length() > 0) {
			mime = contentType;
		}

		PackageResource packageResource = pckg.getResourceAtRelativePath(uri);

		boolean isHTML = mime.equals("text/html")
|| mime.equals("application/xhtml+xml");

iOS:
https://github.com/readium/readium-sdk/blob/master/Platform/Apple/RDServices/Main/RDPackageResourceResponse.m#L57-L66
https://github.com/readium/readium-sdk/blob/3ba644f7dee27d29a5c45c4dee6cfabcca4df52d/Platform/Apple/RDServices/Main/RDPackageResourceResponse.m#L57-L66
- (NSDictionary *)httpHeaders {
	if(m_resource.relativePath) {
		NSString* ext = [[m_resource.relativePath pathExtension] lowercaseString];
		if([ext isEqualToString:@"xhtml"] || [ext isEqualToString:@"html"]) {
			return [NSDictionary dictionaryWithObject:@"application/xhtml+xml" forKey:@"Content-Type"]; // FORCE
		}
		else if([ext isEqualToString:@"xml"]) {
			return [NSDictionary dictionaryWithObject:@"application/xml" forKey:@"Content-Type"]; // FORCE
		}
}

https://github.com/readium/readium-sdk/blob/master/Platform/Apple/RDServices/Main/RDPackageResourceConnection.m#L275-L302
https://github.com/readium/readium-sdk/blob/3ba644f7dee27d29a5c45c4dee6cfabcca4df52d/Platform/Apple/RDServices/Main/RDPackageResourceConnection.m#L275-L302
		NSString* ext = [[path pathExtension] lowercaseString];
		bool isHTML = [ext isEqualToString:@"xhtml"] || [ext isEqualToString:@"html"] || [resource.mimeType isEqualToString:@"application/xhtml+xml"] || [resource.mimeType isEqualToString:@"text/html"];

		if (isHTML) {
			NSString * FALLBACK_HTML = @"<?xml version=\"1.0\" encoding=\"UTF-8\"?><title>HTML READ ERROR</title>ERROR READING HTML BYTES!";

			NSData *data = [resource readDataFull];
			if (data == nil || data.length == 0)
			{
				data = [FALLBACK_HTML dataUsingEncoding:NSUTF8StringEncoding];
			}

			NSXMLParser *xmlparser = [[NSXMLParser alloc] initWithData:data];
			[xmlparser setShouldResolveExternalEntities:NO];
			BOOL isXhtmlWellFormed = [xmlparser parse];

			if (isXhtmlWellFormed == NO)
			{
				NSLog(@"XHTML PARSE ERROR: %@", xmlparser.parserError);

				// Can be used to check / debug encoding issues
				NSString * dataStr = [[NSString alloc] initWithData:data encoding:NSUTF8StringEncoding];
				//NSLog(@"XHTML SOURCE: %@", dataStr);

				// FORCE HTML WebView parser
				//@"application/xhtml+xml"
				resource.mimeType = @"text/html";
}

As you can see, in iOS there is a fallback to HTML for malformed XHTML documents ... yes, there exists EPUBs authored with not-well-formed XML-HTML :(
But otherwise, the application/xhtml+xml content type should be correctly passed into HTTP responses via the appropriate headers ... well, at least in the ReadiumSDK "launcher apps".
I am not sure about libxml's responsibility here, are you sure it isn't an implementation trick specific to UIWebview / WKWebView? (on iOS)

The mimetype served through HTTP is fine. The problematic bit is the html
http equiv meta tag that has the incorrect mimetype. It appears that for
this case it is always having the value of text/html.
The XML lib used by the ReadiumSDK logic seems to be responsible.
On Thu, Jun 21, 2018, 8:12 AM Daniel Weck<EMAIL_ADDRESS>wrote:

As you can see, in iOS there is a fallback to HTML for malformed XHTML
documents ... yes, there exists EPUBs authored with not-well-formed
XML-HTML :(
But otherwise, the application/xhtml+xml content type should be correctly
passed into HTTP responses via the appropriate headers ... well, at least
in the ReadiumSDK "launcher apps".
I am not sure about libxml's responsibility here, are you sure it isn't an
implementation trick specific to UIWebview / WKWebView? (on iOS)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/readium/readium-sdk/issues/315#issuecomment-399138928,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE5RbFqVt2u7V18wl9s9zfA-rtxIMtWkks5t-7fXgaJpZM4UwC6B
.

Could you please share the EPUB you are using to reproduce the issue? I would like to run a quick test with SDKLauncher-OSX.

There is no DOM parsing (libxml or not) involved when the iOS / Android / OSX platform-native code  (not C++, but Java or ObjectiveC) pre-processed the HTML documents in order to inject the navigator.epubReadingSystem stuff ... so I do no understand why / how the <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> markup would be added.
IMO, the next best course of action is to reproduce (if possible) the bug with the SDKLauncher-iOS/Android/OSX apps, because it may be that your app is built with a different logic.

@winniequinn
Let's try to reproduce this using the vanilla launchers.
Could you share the EPUB that was used in your testing?

@danielweck
I couldn't reproduce this using various books including a similar Alice book like winnie's sample. I am using the Android launcher.

This repository seems dormant, so I hope no one minds me doing a little housecleaning and closing out this stale issue I reported. @danielweck, feel free to reopen if you think it's worth keeping this active!


Yamllint: Fix all yamllint errors

Partly osism/issues#396
Signed-off-by: Ramona Beermann<EMAIL_ADDRESS>

Fix for broken pipline. This is needed to merge this PR https://github.com/osism/mappings/pull/81


Git Server

We don't have a git server. See contribution page.

We have the git server now. Disabled for now as it meant to decouple from the code host platform, in due time.


Amp 59250 ampli v2 node documentation

Description

ampli v2 node documentation
Includes migration steps from Ampli Node v1
TODO: Need to merge in Doc header updates from here

Jira
AMP-59250
Change type

[x] New documentation.

PR checklist:

[x] My documentation follows the style guidelines of this project.
[x] I previewed my documentation on a local server using mkdocs serve.
[x] Running mkdocs serve didn't generate any failures.
[x] I have performed a self-review of my own documentation.

@amplitude-dev-docs
@caseyamp

@caseyamp I fixed all the errors in markdownlint but now have error for deadlinks in markdown-link-check. Can you help?

@caseyamp I fixed all the errors in markdownlint but now have error for deadlinks in markdown-link-check. Can you help?

Go ahead and merge @justin-fiedler , I'll fix these. I'm still working out all the little issues with the link checker.


One single repository for containers

If we agree to follow https://github.com/BioDocker/specifications/issues/6 we could think about having one repository for all Dockerfiles.
From our experience this has many advantages for a developer, like bulk-updates, unified maintenance (travis, contribution.md, issues) and a grep-able big repository.

@bgruening  This is a great idea, I thought about that in the pass but not sure way, i decided to create a single repository for each container. I think it was because the automated build, but now I know how to configure that to work on separated dockerfiles in different folders. What do you think about that @ypriverol ? I'm in favor of changing to a single repo.

@bgruening can we setup the galaxy repo? If yes please close the issue. Any other option from other @BioDocker/contributors

@bgruening you mean creating a repo for galaxy on Biodocker? OK for me. I'm planning to create a single repo called Proteomics or Proteomics-tools, and then move all the other folders inside. Having that set up I can re initiate the automatic build at DockerHub

@Leprevost why not creating a bioboxes repository and move everything into this? (With everything I mean no binaries, we should keep them out of the git history, if possible.)
@ypriverol I'm not sure Galaxy fits here. It's more or less a complete Galaxy Server with FTP and Scheduler, all in one, not a single application.
I see this more as that Galaxy is using the BioDocker containers to resolve the dependencies. Does this makes sense?

my agree with you. Biodocker is about the containerand not the way of connecting them. the galaxy idea is about have a place for the sources

OK, I will create the Proteomics repository then, and start moving the deploy instructions

@bgruening I also see Galaxy will use BioDocker containers to resolve the dependencies. But for the single repository for (source of the softwares we will use) I would like to have a place in Galaxy Servers if is possible. All the tagging, download, search, etc can be done using the Docker Hub. In any case we can also continue with github

hey @BioDocker/contributors I'm moving all folders into a single repository and re configuring all the automatic build directives on DockerHub. The containers will be unavailable for a few hours, hope to finish all tonight.

done, the containers are all building, some of them are done, others will take some time to be available. We now have a central repository called Proteomics. Inside we have a folder for each software and inside folder for each version containing a Dockerfile. We still have the binaries, I'm planning to moving them with time or all at the same time if we get some place to store them.

@Leprevost @bgruening I'm not sure this approach is the best option. I will explain my idea:

About the sources and binaries, we should try to put the them if they are not in Github in a central
repository, I was talking with @bgruening about the possibility of Galaxy, but we should need more
people for that. It will allow us to control the sources and binaries if the original repo of the software
disappear (like source-forge).

**One place for the containers ** This approach (as implemented now) is no suitable if the user is
interested in one particular container. Having one repository for all the containers will make difficult
to find and see individual containers and use them. This implementation also do not represent our
main goal, providing the containers and the leave to the platforms (Galaxy, TPP, OpenMS) the way
to connecting them. Categories like Proteomics, Genomics... organisation will make us to fall in a
difficult scenario: when a user is interested in one particular program that is more generic such as
EMBOSS, it will need to look inside all the Categories. This classification should be done using
tagging system.

My Idea: Keep the dockers containers or as repositories and we will continue removing them to the
original github repos where the developers can maintain them or have a BioDocker Repo where we
put all the containers, not only from proteomics.

I'm also -1 one this change but for different reasons :)

About the sources and binaries, we should try to put the them if they are not in Github in a central
repository, I was talking with @bgruening about the possibility of Galaxy, but we should need more
people for that. It will allow us to control the sources and binaries if the original repo of the software
disappear (like source-forge).

+1 for this. Binaries should not be part of the repository. Text only. And we should make this mandatory from the beginning. Removing them later from the git history is cumbersome.

*One place for the containers * This approach (as implemented now) is no suitable if the user is
interested in one particular container. Having one repository for all the containers will make difficult
to find and see individual containers and use them. This implementation also do not represent our
main goal, providing the containers and the leave to the platforms (Galaxy, TPP, OpenMS) the way
to connecting them.

I don't fully understand this point. You can perfectly build a Docker container only for PeptideShaker automatically via DockerHub, even if you have multiple Dockerfiles in one repository. Was this your concern?

Categories like Proteomics, Genomics... organisation will make us to fall in a
difficult scenario: when a user is interested in one particular program that is more generic such as
EMBOSS, it will need to look inside all the Categories. This classification should be done using
tagging system.

I totally agree with this, but I vote for one repository BioDocker and putting everything under this repository for the reasons outlined above and because we should bring communities together. Proteomics, Transcriptomics, Imaging ... we need to get away with the distinctions. It's all about data and integration.

My Idea: Keep the dockers containers or as repositories and we will continue removing them to the
original github repos where the developers can maintain them or have a BioDocker Repo where we
put all the containers, not only from proteomics.

Can you elaborate on this more? Is this not exactly the one-repo multiple Dockerfiles idea?

OK, you have good points, I agree with some of them. I personally think that having a central repository is better to maintain. A problem I noticed in the past with having several docker repositories is that it makes harder to find stuff in the GitHub page. If we grow too much it will get to a point that we will need some sort of list to keep track of it and to show people what we have, and I think that's not practical. With a central repository, everything is listed as folders inside the central repo, you just need to open it to see all the programs there.
We have to keep in mind that the repositories are not for the "users", they are for the developers. My second point is that the repositories are not going to be updated that much, because they are going to hold just dockerfiles, right? So I don't think we will have too much movement on the group, maybe when a new software is releases or a new version is launched.
I agree about changing the name from Proteomics to Biodocker. I will do that today.

+1 Ok lets changed to biodocker or something similar. Please @Leprevost can you make clear this discussions in the specification and update this specification, you can close the issue. Perhaps is better to use biodockers

biodocker is fine

done

One idea. subfolders could be created for "genomics", "transcriptomics", "proteomics", "others" and symbolic links created inside each of them linking to the folder in the global list. this way everybody wins except when symlinks break.


Update laverna to 0.7.5

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Thanks for the PR!

My pleasure sir ;-)
On Sun, 1 Oct 2017, 10:39 commitay<EMAIL_ADDRESS>wrote:

Thanks for the PR!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/caskroom/homebrew-cask/pull/39159#issuecomment-333362071,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATuw-DqPxwcmgovyrA5ToS6lmKj_KRjks5sn0-8gaJpZM4Pp0m1
.


IE 11 and Vue Cli 3

Hello!
I use Vue Cli 3 with TypeScript
For this i create file:
import Vue from 'vue';
import Vuex from 'vuex';
import createPersistedState from 'vuex-persistedstate';
Vue.use(Vuex);
export default new Vuex.Store({
plugins: [createPersistedState({
storage: window.sessionStorage,
})],
modules: {
...
},
mutations: {
},
actions: {},

});
In IE 11 i see error invalid storage instance given

Please check the issue template:
If you try to report a bug but do not not provide a reproducible codesandbox or fiddle,
the issue will be closed without further notice.


Reference TestCentric.Engine.Api 2.0.0-beta4

:tada: This issue has been resolved in version 2.0.0-beta4 :tada:
The release is available on:

GitHub Release
NuGet Package


Add unordered_dense and deprecate robin-hood-hasing

i don't understand why this doesn't work :/

i don't understand why this doesn't work :/

it's cmake and meson scripts have not install header configuration.
In addition, using meson introduces additional python/openssl/ninja dependencies and builds a lot of tests, which is just a headeronly library. It is faster to use cmake to install it here.


LakeTablet cannot be cast to LocalTablet

Steps to reproduce the behavior (Required)

CREATE TABLE `table` (
  `c1` date NOT NULL COMMENT "",
  `c2` varchar(2048) NOT NULL COMMENT "",
  `c3` int(11) NULL COMMENT "",
  `c4` int(11) NULL COMMENT "",
  `c5` int(11) NULL COMMENT ""
) ENGINE=OLAP
DUPLICATE KEY(`c1`, `c2`)
COMMENT "OLAP"
PARTITION BY date_trunc('day', c1)
DISTRIBUTED BY HASH(`c2`)
PROPERTIES (
"replication_num" = "1",
"datacache.enable" = "true",
"storage_volume" = "builtin_storage_volume",
"enable_async_write_back" = "false",
"enable_persistent_index" = "false",
"compression" = "LZ4"
);

Insert some data

ALTER TABLE table COMPACT;

Expected behavior (Required)
Perform compaction
Real behavior (Required)
SQL Error [1064] [42000]: Unexpected exception: class com.starrocks.lake.LakeTablet cannot be cast to class com.starrocks.catalog.LocalTablet (com.starrocks.lake.LakeTablet and com.starrocks.catalog.LocalTablet are in unnamed module of loader 'app')
StarRocks version (Required)
3.1.6-fcc0c6b

already fixed, pr : https://github.com/StarRocks/starrocks/pull/36979

https://github.com/StarRocks/starrocks/pull/36979


Change sidebar-content to flex and move pagination

@jnsdrtlf Are you still working on this branch (hotfix/pagination) or can we delete it as it is unused?


Login page: Eye icon not working

The toggle button(eye icon) in the password field in login page is not working...(toggle functionality not working)...
Eventhough it is working in signup page, not working in login page...I would like to fix this.

Kindly assign me this issue with gssoc and hacktoberfest labels.

@swathivemula7 can you fix this now.

@swathivemula7 can you fix this now.

Sure, i can fix this before tonight

@swathivemula7 make sure to complete this fast.

/assign

i am interested in fixing this issue, can I be assigned this?

@swathivemula7 I think this issue was resolved, Because, i have assigned a login page updation before I have assigned you, i think he had also updated this one also.
Will it be okay for you, if i close this issue, so that you can look for other issues.
But please don't be discouraged.

@vivekvardhan2810 I was also about to raise a PR. But it's okay I will find an another issue.

@swathivemula7 can i close this issue. so that you can for other issues also.


add into function for PrefixIterator

Small refactor, add into function which conveerts PrefixIterator<T, O1> into another PrefixIterator<T, O2>

@kianenigma , Unfortunately it is not possible to implement From or Into, we have the similar situation as described here https://users.rust-lang.org/t/conflicting-implementations-for-trait-core-convert-from/3149.
So ok, will rename it to into_other.


Refactor output

Allow custom output through configuration
more info on -v, -vv and -vvv for text
check on is decorated everywhere

A lot of the classes here are missing class level phpdoc.

@GrahamCampbell thanks for reviewing this, I've made some changes based on your comments :)

The author tag is required in this project though.

but why? we have the git history for this, I don't see the added value for this.

related:
https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/839
https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/826
https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/454
https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/967
https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/1239
opens up a solution for:
https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/299
https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/1176

I'm not sure that handling all output via events is the best option here. Events are great when we have difficult deps to handle, like passing some info from A to D through B and C. Here, we have FixCommand that want to print sth and it already has access to *Output instance. Using events to connect them looks a bit overgrowth here.
Secondly, when we decided to use Events to handle progress we did it to have simpler flow and data flow - but we noticed a decrease of performance. Did you check if that changes affects performance?
Third thing is FixerOutputInterface. When I want to implement it I have no clue what events I should or even may listen to inside getSubscribedEvents method.
Finally, having FixerFinishedEvent that takes so many data on input (array $changed, Stopwatch $stopwatch, ErrorsManager $errors, $dryRun, $diff) simply blows my mind.

Separation of output format into separate classes is great. Just not sure if this is the greatest way to do it.

Any other opinions would be appreciated

anyone ?

@keradus thank you for your feedback and concerns. I was planning to come up with a well thought out response but didn't find the time, nor did I find the time to do some more profiling. I will come back on your points.
For now I hope to get some more feedback from others to see if this idea or something like https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/1163 is more suitable, or maybe just leave the output code as is.

I'm closing this one for not mixing code review and design discussion. I'd think it might be better to come to a conclusion about what to build first and then continue on working on it (that is, if the output should be refactored at all ;) )


Update README.md

Description
Added notes to update readme

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

Lets merge once AEM Archetype is released.


Vuex Persistence.

Vuex Persistence

Behavior
Hello everyone!
So... this template has a data loss  when page reaload. I think it's because we dont have vuex-persistence plugin in the application. Is there other vuex persistence to avoid data loss when reload the page ? How are you guys handle this ?

The issue
When page reload we lose our vuex data.

What you guys thinik about this ?
Maybe we could have a boolean parameter on our vuex modules to handle this situation. This parameter would be responsible for indicate that we want that module persisted or  not.

Motivation
Persist user data on vue store to avoid re-login when users reload the page

Has it been solved? I've come across this problem now
有解决吗 我现在也碰到这个问题了

Has it been solved? I've come across this problem now
有解决吗 我现在也碰到这个问题了

Since they didn't answer this issue, I don't think they had solved.


fix(wizard): set pf-c-wizard__main to grow and fill available height

fixes https://github.com/patternfly/patternfly-next/issues/1766

Deploy preview for pf-next ready!
Built with commit c14dcdfa9ca64db991257923351800adfb835ad1
https://deploy-preview-1781--pf-next.netlify.com

:tada: This PR is included in version 2.6.10 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Suggestion] Be able to replay a method from the bookmarks

Being able to replay a method that is added to the bookmark is a cool addition to the extension is can be extremely helpful while debugging.

Interesting, I will certainly study this further. Thank you.

@renanccastro I added the feature to the development branch, you are welcome to build and test locally if you want. I will release as soon as I have all the features/issues resolved.

Meteor DevTools Evolved v1.1 released including the replay feature. :tada:


annotations: flag for symbol markings/ not annotatable

in the first instance, maybe a checkbox "symbol/glyph (not on keyboard)" that hides the textbox entry field.
one day in the future, maybe we will have a taxonomy of glyphs to chose from.


Avoid tar directory traversal on sdist extract to fix CVE-2007-4559

This fixes the tar directory traversal issue with Python's stdlib tarfile module's extractall function, replacing #89 and adapted from what we did in spyder-ide/spyder-kernels#428 , but greatly simplifying the implementation using pathlib (and making a few other tweaks to confirm with pyroma's style and practices).
Closes #89

Great!


Sandstorm.io authentication is not working

How to reproduce:

create new sandstorm.io demo.
Install Libre board.
Create new Board and create a share Link with the blue "Share" button.
Open Share Link in new Incognito window.
Register new Libre board account ("Sign up for free"). Error: "0 must be an object [400]".
Try to login with new account. User cannot access boards: "No boards.". If you go back to the shared link the user is not logged in.

Also see: http://logbot.g0v.tw/channel/sandstorm/2015-05-21#0

More details: It appears LibreBoard displays its own sign-in dialog when a user other than the grain owner views the grain. Instead, it should trust Sandstorm's access control, and it should assume that anyone who arrives at the page is supposed to have access to the board (otherwise Sandstorm would have blocked them). It would actually be best to remove the accounts-password package entirely from the Sandstorm build.

Also, all authentication- and authorization-related knobs should be hidden or removed from the Sandstorm build. For example, setting a board public vs. private, all of the "sign up for free" banners, etc.

The above commit fixes the issue but v0.9 still needs some work before I can release a updated spk :)

Waiting for this to be fixed so we can start playing around with it.

Can you make a beta spk?


SX1262 output power too low

I measured the output power from my TTGO_T_Beam_V1_2_SX1262. The power level seems limited at only 10 dBm, not 22 dBm according to the datasheet.
After looking around in the code, i found that the current limit for the PA is not increased from its default value.
When setting it to its max. value using radio.setCurrentLimit(140);, the measured power increases from 10 to 17 dBm. (still not 22 dBm, but maybe my board is not that good)

Yes, this (too) is indeed missing from the code.
Try to raise the current limit higher (maximum value 240mA).
Do not raise the output power higher than 20dBm because +2 is added within the code. If you set a value higher than 20 in the configuration you will limit the radiolib back to 10dBm.
HA5SZI

From my experience, NONE of the Lilygo modules do reach the advertised output power !
+17dBm is the max I got from a SX1278 and +20dBm from a SX1272
I've written a small test software for the Lilygo modules :
https://www.egloff.eu/


Add "nightly" Schedule Specification

Summary
As a user of k8up
I want to be able to allow the controller to schedule backups automatically between 0000 and 0300
So that nightly backups can be automated more efficiently
Context
As a result of the new schedule options, the controller can now automate the timeframe for certain tasks via new schedule specifications like @monthly, @midnight, and @daily. These options are a great addition, but do not allow for the functionality required to run nightly backups at scale, as the @daily option and the @midnight option both run at 0000 and the @daily-random option can schedule a backup at any time of the day with no way to specify a certain time range.
Implementing a new @nightly option which would function much like the @daily-random function, but with start and end times between 0000 and 0300 would allow for users to let the controller handle exact backup scheduling timeframes whilst still ensuring these backups happen during off-peak time frames.
Out of Scope

Further links
Schedule documentation: https://github.com/vshn/k8up/blob/master/docs/modules/ROOT/pages/references/schedule-specification.adoc
Acceptance criteria

Given a schedule with a specification of @nightly
When the controller sees such a value
Then the controller should automatically pick a time to schedule the suggested operation that is between 0000 ( 0 0 * * * ) and 0300 ( 0 3 * * * ) .
Implementation Ideas
Initially, it seems like this would be easy enough to implement as a clone of @daily-random, with time gates from 0000 to 0300 instead of 0000 to 2359.
As a possible future addition, it could be good to ensure that each automatically scheduled operation does not conflict with other scheduled events of the same type from operations which use this same backup bucket.

Maybe we could implement something like @range-random where a user could specify a range within the backups should be randomized. That way users have a powerful way to customize the random schedules generated by k8up.

Maybe we could implement something like @range-random where a user could specify a range within the backups should be randomized. That way users have a powerful way to customize the random schedules generated by k8up.

Your solution sounds good to me! It's easy enough to just add some extra variables when specifying a schedule. :)
I do wonder if such a time frame option would be easily compatible with eventual environment task de-duplication as well as collision avoidance between tasks using the same bucket?

Your solution sounds good to me! It's easy enough to just add some extra variables when specifying a schedule. :)
I do wonder if such a time frame option would be easily compatible with eventual environment task de-duplication as well as collision avoidance between tasks using the same bucket?

Your solution sounds good to me! It's easy enough to just add some extra variables when specifying a schedule. :)
I do wonder if such a time frame option would be easily compatible with eventual environment task de-duplication as well as collision avoidance between tasks using the same bucket?

Your solution sounds good to me! It's easy enough to just add some extra variables when specifying a schedule. :)
I do wonder if such a time frame option would be easily compatible with eventual environment task de-duplication as well as collision avoidance between tasks using the same bucket?

@cdchris12 I'm rewriting your request a bit, to incorporate the information from the comments.


external/elasticsearch tests fail to build for jdk11

Seems for both j9 and hs there is an issue with the setup/build of the elasticsearch test material.
For j9 (from https://ci.adoptopenjdk.net/view/Test_external_weekly/job/openjdk11_j9_external_extended_elasticsearch_x86-64_linux/76/console):
08:03:58  * What went wrong:
08:03:58  Execution failed for task ':plugins:ingest-attachment:unitTest'.
08:03:58  > There were test failures: 4 suites, 24 tests, 1 suite-level error, 1 error [seed: C59A1DB000FC034E]
08:03:58
For hs (from https://ci.adoptopenjdk.net/view/Test_external_weekly/job/openjdk11_hs_external_extended_elasticsearch_x86-64_linux/71/console):
05:46:41  * What went wrong:
05:46:41  Execution failed for task ':x-pack:qa:tribe-tests-with-license:unitTest'.
05:46:41  > There were test failures: 3 suites, 6 tests, 2 suite-level errors, 1 error, 4 ignored [seed: E173281EBB689715]
Something appears to have changed between July & Oct, we should check if we are setting up and using the right material.

Close this as we will remove this test from the suite (since this is no longer an opensource project).


Merge PDF4me SwissQR to master repo

Please check the following conditions for your PR.

[x] apiDefinition.swagger.json is validated using paconn validate command.
[x] apiProperties.json has a valid brand color. Invalid brand colors are #007ee5 and #ffffff.

By mistake


feat(shared): spell and grammar linting

As a developer, I want to enforce the usage of proper commit messages in all Pull Requests (PRs) to maintain code quality and consistency.
Issue:
currently, we lack a tool or feature to make sure that the PRs we receive for our project follow the correct PR format.

Solution:
To address this issue, we can implement GitHub Spellcheck, a tool that automatically checks the spelling and grammar in commit messages whenever a PR is created. By integrating this tool into our repository, we can ensure that all future PRs have correctly spelled and well-written commit messages.

Additional context:
GitHub Spellcheck will improve the quality of Hyperledger Bevel Pull Requests.

i am working on this.


Add support for more than 50(?) episodes

Feeds only return 50 episodes in my experience.
Since there are podcasts with thousands of episodes it would be great to have more, or maybe self host and change that number manually.

I agree I also seem to be having this issue as well.

I agree I also seem to be having this issue as well.

Fully support this. Maybe an option in the site on how many episodes we can select.

Fully support this. Maybe an option in the site on how many episodes we can select.

I have no plans to add this. 50 is the max number of episodes returned by Spotify's API in a single call. I don't want to burden their API by making excessive requests, nor do I want to get rate limited. Until they raise that limit, I can't risk the cost of multiple API calls.

I have no plans to add this. 50 is the max number of episodes returned by Spotify's API in a single call. I don't want to burden their API by making excessive requests, nor do I want to get rate limited. Until they raise that limit, I can't risk the cost of multiple API calls.

I don't think there is any issue with requesting any number of episodes. I use Spotify's API to filter my music, and I make thousands of calls no problem. I don't know if you're familiar with Python syntax, but here's more or less how I went about it (except I did it with music, not podcasts, which are unavailable in my country). As you can see, the get_show_episodes function is wrapped inside a decorator which makes sure that all the items are accumulated by making it recur until there are no new items to speak of. If some API-related errors do arise, they can be bypassed by refreshing the token.

I don't think there is any issue with requesting any number of episodes. I use Spotify's API to filter my music, and I make thousands of calls no problem. I don't know if you're familiar with Python syntax, but here's more or less how I went about it (except I did it with music, not podcasts, which are unavailable in my country). As you can see, the get_show_episodes function is wrapped inside a decorator which makes sure that all the items are accumulated by making it recur until there are no new items to speak of. If some API-related errors do arise, they can be bypassed by refreshing the token.


Unicode emojis are being escaped

mdx-bundler version: 10.0.2
node version: v18.17.0
npm version: 9.6.7
yarn version: 4.0.2

Relevant code or config
intro.md
---
title: intro
---

Smiley Face 😀

mdxcollection.ts
async function prepareFile (
  options: Partial<Parameters<typeof bundleMDX>[0]>,
  filePath: string
) {
    const fileContents = await fs.readFile(filePath, 'utf-8');
    log('fileContents: ', fileContents)

    const source = String(fileContents);
    log('source: ', source)

    const options = Object.assign(
      {},
      Object.create(options),
      {
        source,
      }
    );

    const contents = await bundleMDX(options);
    log('contents.code: ', contents.code)

    return content
}

What you did:
mdxcollection('intro.md')

What happened:
mdxcollection('intro.md')

// fileContents: '---\ntitle: intro\n---\n\nSmiley Face 😀\n'

// source: '---\ntitle: intro\n---\n\nSmiley Face 😀\n'

// contents.code: "var Component=(()=>{var p=Object.create;var r=Object.defineProperty;var f=Object.getOwnPropertyDescriptor;var l=Object.getOwnPropertyNames;var _=Object.getPrototypeOf,d=Object.prototype.hasOwnProperty;var j=(t,n)=>()=>(n||t((n={exports:{}}).exports,n),n.exports),M=(t,n)=>{for(var e in n)r(t,e,{get:n[e],enumerable:!0})},m=(t,n,e,i)=>{if(n&&typeof n==\"object\"||typeof n==\"function\")for(let o of l(n))!d.call(t,o)&&o!==e&&r(t,o,{get:()=>n[o],enumerable:!(i=f(n,o))||i.enumerable});return t};var h=(t,n,e)=>(e=t!=null?p(_(t)):{},m(n||!t||!t.__esModule?r(e,\"default\",{value:t,enumerable:!0}):e,t)),y=t=>m(r({},\"__esModule\",{value:!0}),t);var a=j((w,s)=>{s.exports=_jsx_runtime});var D={};M(D,{default:()=>x,frontmatter:()=>C});var c=h(a()),C={title:\"intro\"};function u(t){let n={p:\"p\",...t.components};return(0,c.jsx)(n.p,{children:\"Smiley Face \\u{1F600}\"})}function x(t={}){let{wrapper:n}=t.components||{};return n?(0,c.jsx)(n,{...t,children:(0,c.jsx)(u,{...t})}):u(t)}return y(D);})();\n;return Component;"

[!NOTE]
children:\"Smiley Face \\u{1F600}\"

So this doesn't end up rendering the emoji correctly anymore.
Reproduction repository:
I tried reproducing it here, but inexplicably it wont (perhaps because it's an in memory filesystem on stackblitz?).
https://stackblitz.com/edit/remix-run-remix-cqytcp?file=app%2Froutes%2F_index.tsx
Problem description:
unicode emoji is escaped.
Suggested solution:
🤷🏻

solution: don't forget <meta charSet="utf-8" /> in your head.

By default esbuild's output is ASCII-only. Any non-ASCII characters are escaped using backslash escape sequences. One reason is because non-ASCII characters are misinterpreted by the browser by default, which causes confusion. You have to explicitly add  to your HTML or serve it with the correct Content-Type header for the browser to not mangle your code.

https://esbuild.github.io/api/#charset
so in my case: Remix, which means:
root.tsx
export function Layout({ children }: { children: React.ReactNode }) {
  return (
    <html lang="en">
      <head>
        <meta charSet="utf-8" />
        <meta name="viewport" content="width=device-width, initial-scale=1" />
        <Meta />
        <Links />
      </head>
      <body>
        {children}
        <ScrollRestoration />
        <Scripts />
      </body>
    </html>
  );
}

Remove <meta charSet="utf-8" /> and the problem appears.
Obviously it's not a problem with bundler-mdx, but is it a common enough thing to overlook? is documentation enough, or am i just too much of a noob?


Eliminate and lint-ban spurious whitespace in translated strings, especially HTML templates

In scanning through some of our untranslated strings in the languages we have a lot of translations for, one pattern is that in many cases we had a previous translation for the very same string -- except with different whitespace in it, like line breaks and subsequent indentation.
Happily, most (all?) of these are cases where the specific whitespace doesn't matter at all in the end, because it's just HTML or HTML template fragments. For example, commit https://github.com/zulip/zulip/commit/3d2fc9171 reindented some of our HTML templates to a uniform style. Those reindentations are the reason why some of the descriptions on /features, like the paragraph that reads "Search is both snappy and smart, [...]", are no longer translated in 1.6 for Czech, Japanese, Russian, or Serbian, even though we had the same text translated before.
The extra whitespace also complicates the work of making a translation -- it's all there in the input the translator is expected to work with in the translation tool, and newlines especially are quite fiddly in the Transifex UI.
It'd be better to simply not line-wrap within a string that's going to be translated. We already do this in many places; we should do it systematically and write a linter for it.
Some care required if we go through and eliminate the extra whitespace in existing strings -- that'd itself be one last instance of this issue, so if we do that we should take some time to go through existing well-translated languages and adapt the existing translations to the whitespace-fixed strings.

@YagoGG did some work on this, which actually fixed most of the original issues of this form.

@synicalsyntax I noticed this didn't mention @zulip/server-i18n ; any idea why?

@timabbott when was @zulip/server-i18n added? It doesn't seem to be in the zulipbot config file.

That would explain it.  I'm not sure when we made it, but might as well add it to the config now?

Done @timabbott 895b8314c8d460aa074962e987121b1091acb695

This was already fixed in https://github.com/zulip/zulip/pull/13397.


-Z minimal-versions compilation fails on 0.7.6, libc 0.2.69

Hi there,
After doing some unrelated to mio dependency upgrades on a crate, I added a CI check for doing a cargo +nightly update -Z minimal-versions. This passes on githubs ubuntu-latest but not on macos-latest: build error:
Error:     --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/mio-0.7.6/src/sys/unix/tcp.rs:334:15
     |
334  |         libc::TCP_KEEPINTVL,
     |               ^^^^^^^^^^^^^ help: a constant with a similar name exists: `TCP_KEEPALIVE`
     |
    ::: /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/libc-0.2.69/src/unix/bsd/apple/mod.rs:2259:1
     |
2259 | pub const TCP_KEEPALIVE: ::c_int = 0x10;
     | ---------------------------------------- similarly named constant `TCP_KEEPALIVE` defined here

(With more of these cut, but this shows the used versions.)
I don't have a mac myself, but it sounds like the 0.2.69 is too low. I think the TCP_KEEPINTVL was added in https://github.com/rust-lang/libc/commit/967dffee510042e3dcab179d5ce6d91bd36d1d55 which seems to appear first in v0.2.71.

Thanks to @niklaslong it'd seem that the build fails with libc 0.2.69, but after cargo update -p libc --precise 0.2.71 it works.

Thanks to @niklaslong it'd seem that the build fails with libc 0.2.69, but after cargo update -p libc --precise 0.2.71 it works.

This should be fixed in 0.7.7 and master as those require libc 0.2.82.

This should be fixed in 0.7.7 and master as those require libc 0.2.82.

Ah great, didn't check. Is the plan to yank 0.7.6 as well? I understand that to be the only way tokio = "1" dependency to pass minimal-versions build on macos, unless this could be specified as target specific requirement.. Lets see...

Ah great, didn't check. Is the plan to yank 0.7.6 as well? I understand that to be the only way tokio = "1" dependency to pass minimal-versions build on macos, unless this could be specified as target specific requirement.. Lets see...

Tokio could increment the min version of mio to fix that.

Tokio could increment the min version of mio to fix that.

Trying to work around locally with target specific dependency https://github.com/NLnetLabs/domain/pull/86/commits/db0df6b7a12561b5e6db03f0e033ccf67d2a3f1f

Trying to work around locally with target specific dependency https://github.com/NLnetLabs/domain/pull/86/commits/db0df6b7a12561b5e6db03f0e033ccf67d2a3f1f

The above target specific optional dependency trick works probably for now.

The above target specific optional dependency trick works probably for now.


prisma format fails with message that tells me to fix the error I should run prisma format

Bug description
generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "postgresql"
  url      = env("DATABASE_URL")
}

model sync_meta {
  id            Int                      @id
  started_at    DateTime?                @db.Timestamptz(6)
  completed_at  DateTime?                @db.Timestamptz(6)
  duration_last Unsupported("interval")?

  @@map("_sync_meta")
}

model song {
  id           String    @id
  created_time DateTime? @db.Timestamptz(6)
  artist       String?
  title        String?
  Artist       artist?   @relation(fields: [artist], references: [id])

  @@index([artist], name: "artist_csbqvaulkkx3n7a_idx")
}

model artist {
  id           String    @id
  created_time DateTime? @db.Timestamptz(6)
  name         String?
  song         String?

  @@index([song], name: "song_pl7n5ch9hvpmdxp_idx")
}

Run npx prisma format:
Environment variables loaded from .env
Prisma schema loaded from prisma\schema.prisma
Error: Schema parsing
error: Error validating field `Artist` in model `song`: The relation field `Artist` on Model `song` is missing an opposite relation field on the model `artist`. Either run `prisma format` or add it manually.
  -->  schema.prisma:24
   |
23 |   title        String?
24 |   Artist       artist?   @relation(fields: [artist], references: [id])
25 |
   |

Validation Error Count: 1

(VSCode extension just silently fails)

Another example schema here: https://github.com/prisma/prisma/issues/6854

Hey there, is there a workaround for this?

This has been changed in the meantime. With 5.14.0 and the schema above:
prisma validate
PS C:\Users\Jan\Documents\throwaway\1483> npx prisma validate
Environment variables loaded from .env
Prisma schema loaded from prisma\schema.prisma

Error: Prisma schema validation - (validate wasm)
Error code: P1012
error: Error validating field `Artist` in model `song`: The relation field `Artist` on model `song` is missing an opposite relation field on the model `artist`. Either run `prisma format` or add it manually.
  -->  prisma\schema.prisma:24
   |
23 |   title        String?
24 |   Artist       artist?   @relation(fields: [artist], references: [id])
25 |
   |

Validation Error Count: 1
[Context: validate]

Prisma CLI Version : 5.14.0

prisma format
PS C:\Users\Jan\Documents\throwaway\1483> npx prisma format
Prisma schema loaded from prisma\schema.prisma

Error: Prisma schema validation - (validate wasm)
Error code: P1012
error: Field "song" is already defined on model "artist".
  -->  prisma\schema.prisma:34
   |
33 |   song         String?
34 |   song         song[]
   |

Validation Error Count: 1
[Context: validate]

Prisma CLI Version : 5.14.0

Using Format Document in VSCode shows what it tries to do:
model artist {
  id           String    @id
  created_time DateTime? @db.Timestamptz(6)
  name         String?
  song         String?
  song         song[]

  @@index([song], name: "song_pl7n5ch9hvpmdxp_idx")
}

A back relation field songis added to artist, which makes that model invalid because of the duplication.
As soon as you rename that field to song2 for example the model becomes valid.
What should prisma format do here?


Is repository active or maintained?

Hello
There are dead PR's and ~100 issues. Is repository active? There are definitely some upgrades to be done for the ease of use for xcodes tool but looks like maintainers are silent.

Hi @mojidabckuu - rest assured this repo is still active and maintained, even though it may look at times not. Thanks


Improve installation

Improve installation method. Options include PyPi, Conda and conda/mamba environment file.

Installation improved by adding conda environment file with only required packages required. Further improvements are still to be made to make the package pip and conda installable directly without cloning the repo.

After discussions with @btalb this probably isn't suitable for deployment via PyPi due to its dependency on ROS. Specifically rosmsgs which breaks it being python only. Alternatively this could become a debian on our ppa or could become a package on conda-forge with the robostack dependency.


New (simpler but more robust) implementation of canonicity check

This is an attempt to resolve the issue with the canonicity check that I encountered in https://github.com/agda/agda2hs/pull/350 by implementing it in a completely different way. Instead of re-inferring the instance and checking it for equality with the given one, we instead traverse the term and check that its head symbol is an instance (either a global instance Def or a local instance Var), and that all its recursive instance arguments are canonical too.
Due to the upstream issue https://github.com/agda/agda/issues/7449, this has the annoying effect that instances need to be given in a form that does not reduce unless projected, or if they reduce then the reduct should be a valid instance itself. This should not be a problem for user-written instances, but for the instances in the Prelude it means we cannot make use of most of the tricks that were there to avoid boilerplate. Instead, I just bit the bullet and made the code in it quite a bit more verbose in order to make it pass the new canonicity check.
Happy to get feedback on the general idea as well as the implementation details.

With regards to instances being inlined, can this be prevented by annotating with {-# NO_INLINE #-}?

That doesn't help as the terms are actually reduced to whnf, on which NO_INLINE has no effect.

since mkApplicative was marked as private, we could assume that all uses of mkApplicative in instance arguments must arise from instance search, so we could hardcode these helpers from the prelude to be fine (TM)

Yeah in hindsight perhaps this would've been easier. But now the work is done anyway.

It would be if we wanted to use the same kind of tricks for a custom class, right?

These tricks would not be accepted for instances that are actually compiled to Haskell. However, it could be a problem if a user wants to mirror instances that already exist in Haskell on the Agda side.

Since there are no objections I will merge this now, so we can continue to update the Agda base version to 2.7.0.


PyCharm EAP Support

Describe the bug
With each release of and EAP on PyCharm Professional the plugin fails to load or is incompatible with the latest EAP
To Reproduce
Steps to reproduce the behavior:

Go to 'Settings/Plugins'
Click on 'Ruff'
See error " Incompatible: requires IDE build 241.* or earlier"

Expected behavior
Continued use with latest EAP unless some reason exists that would break the compatibility.
Environments (please complete the following information):

IDE: [PyCharm Professional; 2024.2 EAP]
OS: [Windows 11]
Ruff Version [0.0.33]
Plugin version [0.0.33 ]

@koxudaxi I know you are busy with porting to the new LSP integration. Anyway, would you be so kind to just rebuild the current version with updated until-build so we can use the current version of the plugin in PyCharm EAP. Thank you very much.

Sorry for the slow response.
I have tried, but I can't build it properly just by increasing the version. Some APIs cannot be referenced, so something needs to be fixed.
https://github.com/koxudaxi/ruff-pycharm-plugin/actions/runs/9585184135/job/26430490957?pr=461

We have to upgrade the intellijPlatform plugin  to v2
But, the latest bata don't support EAP :(
https://github.com/JetBrains/intellij-platform-gradle-plugin/issues/1629

Thanks a million, looks like it is resolved now


Vulkan: Fix vkCmdDrawIndexed crash on Adreno 5XX devices

Fixes #79760
Fixes #82602
Fixes #85097
Fixes #86037
Fixes #94741 (Editor)

previous solution
Workaround for the Adreno 5XX family of devices.
An issue occurs when the vkCmdDrawIndexed function is called multiple times between vkCmdBeginRenderPass
and vkCmdEndRenderPass, using a shader that includes a uniform variable (#define MATERIAL_UNIFORMS_USED enabled). The crash is caused if the subsequent render operations (Nodes) within the same render pass do not use material shaders with a uniform variable.
In other words, if a shader with uniform variables is used within a render pass, all following render operations up to the end of the render pass must also use shaders with uniform variables. Otherwise, this can lead to a crash. This workaround ensures that this does not happen by making sure that shaders with uniform variables are consistently used between vkCmdBeginRenderPass and vkCmdEndRenderPass.

Test project: ShaderTest.zip
Tests on Firebase Test Lab

Mi A2 Lite   - Adreno (TM) 506 (reproduced)
vivo 1906   - Adreno (TM) 505 (reproduced)
F-01L (Fujitsu)  - Adreno (TM) 506 (not affected)

crash if:r_device.workarounds.force_material_uniform_set = false;
F libc    : Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0 in tid 19822 (VkThread), pid 19502 (lex.shader_test)
F DEBUG   : backtrace:
F DEBUG   :       #00 pc<PHONE_NUMBER>0f5004  /vendor/lib64/hw/vulkan.msm8953.so (BuildId: 4059f276877a7a61cc16b085624608be)
F DEBUG   :       #01 pc<PHONE_NUMBER>0a0468  /vendor/lib64/hw/vulkan.msm8953.so (qglinternal::vkCmdDrawIndexed(VkCommandBuffer_T*, unsigned int, unsigned int, unsigned int, int, unsigned int)+232) (BuildId: 4059f276877a7a61cc16b085624608be)

no crash if: r_device.workarounds.force_material_uniform_set = true;
https://github.com/godotengine/godot/assets/41921395/5ecc9e47-80e1-448a-80c2-ac03419da460

There are more vkCmdDrawIndexed crashes, RENDER_GRAPH_REORDER = 0 fixes the issues.
https://github.com/godotengine/godot/issues/94741#issuecomment-2254285575
I do not own an Adreno 5xx. I can only check on Firebase Test Lab if the devices crash and analyze the logs, which takes a lot of time. Adreno 5xx (Android 7 to 10) devices are no longer very widespread, or there are not so many devices in active use. I think we should just disable RENDER_GRAPH_REORDER for all Adreno 5xx devices for now.
In the next few days I will first check what effects RENDER_GRAPH_REORDER = 0 has on performance.

In the next few days I will first check what effects RENDER_GRAPH_REORDER = 0 has on performance.

In theory it should have a big impact on performance. However since Adreno 5XX isn't a very common device anymore, it is probably better to force disable RENDER_GRAPH_REORDER so that the workaround only has a small impact on the complexity of the code.
That being said, some of the original reports were from before the acyclic graph was added, which means that setting RENDER_GRAPH_REORDER=0 may not be enough (for example: https://github.com/godotengine/godot/issues/79760)
CC @DarioSamo You may find this interesting. We discussed this workaround last month, now we have a bit more information

In theory it should have a big impact on performance. However since Adreno 5XX isn't a very common device anymore, it is probably better to force disable RENDER_GRAPH_REORDER so that the workaround only has a small impact on the complexity of the code.

The good news is the macro doesn't really control much actual compilation and it just controls a boolean that gets passed here. Making a driver workaround might be as simple as just adding a && to that first argument (e.g. a workaround boolean called avoid_graph_reorder).
https://github.com/godotengine/godot/blob/0e9caa2d9cb20737f8dcf08b75fcf2a78d980569/servers/rendering/rendering_device.cpp#L5232
I'd keep this as an option if you consider there's absolutely no other solution and there's not enough time to figure out every annoying driver bug in time for 4.3. However, it is very likely the issue will pop up in the future in the mobile renderer just because someone adds an operation that causes it and we'll pretty much be back at the same point. Perhaps by that point, with some luck, we won't care that these devices are broken and don't need to investigate it further.

TODO:
MRP for workarounds.avoid_compute_after_draw on Adreno 5xx: https://github.com/godotengine/godot/issues/90459
Perhaps also affected, the 5xx Adreno are not particularly performant, I only tested with 2D nodes a few months ago.

no crash on Fujitsu F-01L - Adreno (TM) 506, Vulkan 1.0.61, driverVersion = 54185879

Is there a function to format the driverVersion as a string? xxx.xxx.x
I want to output in logcat first, on 1 device out of 6 the 2D UniformShader does not crash.

just adding a && to that first argument (e.g. a workaround boolean called avoid_graph_reorder).

That sounds better, maybe I'll change it later. (Wow ... this sentence rhymes in English) 🎤 drop
I decided on a new private variable that is initialized in the constructor, but I can also change that later.
I wasn't sure whether it would have a negative impact on performance.
Every frame: RENDER_GRAPH_REORDER && get_device_workarounds().disable_render_graph_reorder

Is there a function to format the driverVersion as a string? xxx.xxx.x

Yep, they're defined in vulkan_core.h
#define VK_API_VERSION_VARIANT(version) ((uint32_t)(version) >> 29U)
#define VK_API_VERSION_MAJOR(version) (((uint32_t)(version) >> 22U) & 0x7FU)
#define VK_API_VERSION_MINOR(version) (((uint32_t)(version) >> 12U) & 0x3FFU)
#define VK_API_VERSION_PATCH(version) ((uint32_t)(version) & 0xFFFU)

You have to assemble the string yourself using itos()
itos(VK_API_VERSION_VARIANT(driverVersion)) + "." + itos(VK_API_VERSION_MAJOR(driverVersion)) + "." + itos(VK_API_VERSION_MINOR(driverVersion)) + "." + itos(VK_API_VERSION_PATCH(driverVersion))

In theory it should have a big impact on performance.

2D Benchmark: godot4-bunnymark-gdscript.zip
On old Android devices, the benchmark would have to be adjusted (30 or 45 fps)
# bunnymark
var bunnymark_target = 60.0

On MacM1 Dev. build, up to 3% more Node2D objects, without reorder (RENDER_GRAPH_REORDER = 0)

device
reorder  = true
reorder =  false

MacOS M1  Dev. - 60 fps
3360
3440

TODO Android
-
-

TODO: Adreno 5xx on Firebase Test lab

device
driverVersion

Mi A2 Lite , API 29, Adreno (TM) 506

Galaxy Tab S3, API 28, Adreno (TM) 530

AQUOS sense2 SH-01L, API 28, Adreno (TM) 506

vivo 1906, API 28, Adreno (TM) 505

F-01L Fujitsu, API 27, Adreno (TM) 506. (2D not affected)

ShaderTest.zip -> #79760, #82602, #85097, #86037
RENDER_GRAPH_REORDER = 0 does not prevent the uniform crash.
On Firebase Test Lab, unfortunately 3 Adreno 5xx devices have been removed in the last 2 months. There are only 4 devices left and my ShaderTest still crashes there, except on F-01L - Fujitsu. And soon at least 1 more device will be removed.

BACKUP, previous solution:
https://github.com/Alex2782/godot/tree/fix_uniform_crash_adreno_5xx_back
I could create a new PR if the following changes have any chance of being included (red, removed lines): compare
Otherwise I will give up trying to fix the 'uniform' crashes because I lack productive testing facilities.


Update tutorial-risk-based-sspr-mfa.md

"Impossible travel to atypical locations"
what does it mean?  how does it differ from
"sign ins from  unfamiliar places"?

@bergano65 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks for teaching out, @bergano65. For questions, please use GitHub issues on a doc rather than a PR.
To answer the question though - sign-in from unfamiliar places would be a new location that you haven't signed in from before or wouldn't typically sign in from. That's the only sign-in event that is being detected and triggering a warning.
Impossible travel would be multiple sign-in events from widely different geographic places in a very short space of time where you couldn't have completed the physical travel required. They're similar in that one of the impossible travel sign-in events could be from an unfamiliar place, but it's the detection of multiple sign-in events in a short space of time (often seconds or minutes apart) that triggers the impossible travel alert.
#please-close


No .gitignore in the root of the project.

Describe the bug
The project has no .gitignore file and even if it did it would be overwritten by the project scaffolding.
Add a .gitignore to the repo and merge the project scaffolding .gitignore into it durint the Gitpod init phase.
Screenshots

Steps to reproduce

Expected behavior

Additional information

Merged to main

Merged to main


Ensure that ebuilds use our sources in case of archived repositories

Current situation
There are some ebuilds, like nova-agent-container or nova-agent-watcher, that are pulling sources from coreos github org. I think those should be forked over to kinvolk org.
Impact
If the organization ever goes away, the build will be broken and the sources may be hard to recover back. Also, if there's ever a need to fixing a bug, the fork will necessary anyway, since the projects are archived, thus read-only.
Ideal future situation
All ebuilds refer to either maintained projects or to kinvolk fork.

Hello!
I would like to work on this issue.
As the flatcar init ebuild is pointing to the kinvolk fork. Do I need to change the ebuild of nova-agent-container and nova-agent-watcher so that they point to kinvolk own fork. But as there is now such fork of the two packages in the kinvolk. In that case I need some direction what should be my approach.

Solving this might not be straightforward and might need admin access, as we need to create a copy of all the required repos into the flatcar-linux org and then updating the references in the ebuild files.
to start off it would be good to create a list of repos that are still referring to github.com/coreos/

I searched in the coreos-overlay and got some packages that still referring to github.com/coreos/
List -

Sysroot
eselect-go
nova-agent-container
nova-agent-watcher
fero-client
kola-data
go-tspi

Although I am not sure about coreos-au-key


Emit FIRRTL bulkconnects whenever possible

This PR aims to emit a FIRRTL bulkconnect when connecting Aggregates either mono- or bi-directionally. This does not cover all possible cases (e.g. ExpandConnects + Dedup), but instead serves as a baseline for most cases when a bulk connect would work.
Contributor Checklist

[ ] Did you add Scaladoc to every public function/method?
[x] Did you add at least one test demonstrating the PR?
[x] Did you delete any extraneous printlns/debugging code?
[x Did you specify the type of improvement?
[] Did you add appropriate documentation in docs/src?
[ ] Did you state the API impact?
[ ] Did you specify the code generation impact?
[ ] Did you request a desired merge strategy?
[ ] Did you add text to be included in the Release Notes for this change?

Type of Improvement

bug fix
performance improvement

API Impact

No impact
Backend Code Generation Impact
No impact
Desired Merge Strategy
Squash and merge
Release Notes
Emit FIRRTL bulk connects whenever possible when using a MonoConnect or BiConnect
Reviewer Checklist (only modified by reviewer)

[ ] Did you add the appropriate labels?
[ ] Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
[ ] Did you review?
[ ] Did you check whether all relevant Contributor checkboxes have been checked?
[ ] Did you mark as Please Merge?

I meant to mark this for backporting but forgot.

@Mergifyio backport 3.5.x


⚠ Fetchers has degraded performance

In f3b1629, Fetchers ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 523 ms

Resolved: Fetchers performance has improved in 4196061.


Paper ?

This looks like a good work, do you have a link to the paper? Which conference or journal does it appear in?

Thank you for your interest. The manuscript is available on the arXiv preprint now at the link below:
https://arxiv.org/pdf/2406.01629v1


Pyodbc installation on Linux

To be able to use SQL Server Database as Data Node, users should install OBDC.
We should provide documentation.
CFM Dockerfile as example:
FROM python:3.10
EXPOSE 5025/tcp
WORKDIR /cfmv2
RUN apt update -y  &&  apt upgrade -y && apt-get update
RUN apt-get install -y --no-install-recommends
unixodbc-dev
unixodbc
libpq-dev
Add SQL Server ODBC Driver 18 for Ubuntu 18.04
RUN curl https://packages.microsoft.com/keys/microsoft.asc | apt-key add -
RUN curl https://packages.microsoft.com/config/ubuntu/18.04/prod.list > /etc/apt/sources.list.d/mssql-release.list
RUN apt-get update
RUN ACCEPT_EULA=Y apt-get install -y --allow-unauthenticated msodbcsql18
RUN ACCEPT_EULA=Y apt-get install -y --allow-unauthenticated mssql-tools
RUN echo 'export PATH="$PATH:/opt/mssql-tools/bin"' >> ~/.bash_profile
RUN echo 'export PATH="$PATH:/opt/mssql-tools/bin"' >> ~/.bashrc
RUN apt-get update -y &&
apt-get install -y python3.pip python3-dev
COPY ./requirements.txt ./requirements.txt
RUN pip install --upgrade pip
RUN pip install -r requirements.txt
COPY . .
#ENTRYPOINT /bin/bash
CMD ["python3", "main.py"]

I think maybe we should change from ubuntu 18.04 to 22.04 which is the new LTS version


Add more random bytes to the value

Add at least 8 random bytes with the encoded value.

Done. We now have 16 byte nonce as iv.


Support boolean values in required validator

This adds support for required boolean values, e.g. checkboxes.

Codecov Report

Merging #126 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #126   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          19     19
  Lines         309    309
=====================================
  Hits          309    309

Impacted Files
Coverage Δ

src/validators/common.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d767d8b...383f1e1. Read the comment docs.

I see it's necessary to mix well with checkboxes and I clearly missed that. Thanks for the PR!

I'm not sure how common this is, but for Yes or No radio buttons I usually set the values of the elements to true and false and this commit caused a bit of an issue for me.
It might just be me, but it seems that requiring true for a checkbox is a slightly different concept than requiring a value for a field. The former has a default value, false, and is requiring a specific value, true, the latter is requiring a value exists.
I can create a custom validator for my use case, but just thought I'd bring it up to see what you all think.

Just found this PR after creating issue #156. I don't agree with this change for the same reason as @jsfeldman, this breaks using radio buttons with the required validator. Perhaps we can find a solution that supports both radio and checkbox inputs.

@petridw I'd be glad to review a proposition, but I have little time to dedicate for finding it from scratch on my own. But I agree the issue is present and it has to be resolved.

@Frizi I'll take a look at the validator when I have some time and see if a simple approach presents itself.


[Bug]: RichTextEditor "Paragraph popup" and DatePicker "Calendar" floats with page scroll

Is there an existing issue for this?

[X] I have searched the existing issues

Description
As a user, when I click on the Paragraph buttonon the RichTextEditor widget to select the text variant and scroll down the page, the Popover is randomly floating around the page. Similarly, the Datepicker widget's dialog is sticking to the bottom of the page, which is visually unappealing.
Steps To Reproduce
Attaching a video for both widgets
Public Sample App
No response
Environment
Production
Severity
Medium (Frustrating UX)
Issue video log
https://www.loom.com/share/9674cffe52fc407cafca7142f4d89aaa?sid=75bba893-98cf-466d-af5c-29aeaf820fe9
Version
Release v.1.26

Hey @Harshithazemoso, Can you please checkout issues where we are inviting contributions?

https://zemoso.atlassian.net/browse/TNOSB-426-ticket created on Jira

Hi @rahulbarwal @Harshithazemoso
In addition to these bugs, I've also identified other issues with the dropdowns that reveal or hide additional toolbar items on the RichTextEditor widget—such as text variant, text color, background color, line height, bullet list, and numbered list. When scrolling down the page, the Popover unpredictably floats around, resulting in a visually unappealing experience.
I am attaching the issue loom video for your reference : Loom Video
Can i pick this issue ? @Nikhil-Nandagopal


Fix evil-window "c" binding

Instead of relying on the optional ":ui workspaces" feature, the
built-in evil-window-delete is used and
+workspace/close-window-or-workspace is only used if ":ui workspaces" is
enabled.
Fixes https://github.com/hlissner/doom-emacs/issues/1640.

Someone on discord said that I should probably use straight as a base instead -> switching back.

Excellent. Thanks for your help!


video qa

Hi, your code is excellent! I would like to ask when you can share the code about video qa evaluation?

Hi,
Thank you for your interest! Since most video QA models are not supported by Hugging Face and require adding new repositories as submodules, we do not include them to keep the main branch codebase clean.
We have added a video model branch with a new README. Check out the [video model branch(https://github.com/JieyuZ2/TaskMeAnything/tree/video_model_branch) to use our video QA models.


Problems running Unima

I'm trying to run Unima (downloaded binary from GitHub) from PowerShell, but I'm struggling to get it to work.
The output:
2019-05-17 11:05:09,096: Unima.Application.Commands.Project.OpenProject.OpenProjectCommandHandler: Opening project at C:\Users\jonas\Downloads\mutation\config.json
2019-05-17 11:05:09,127: Unima.Application.Commands.Project.OpenProject.OpenProjectCommandHandler: Loading configuration: {
    "SolutionPath":  "C:\\git\\fluentassertions\\FluentAssertions.sln",
    "TestProjects":  [
                         "C:\\git\\fluentassertions\\Tests\\NetCore20.Specs\\NetCore20.Specs.csproj"
                     ],
    "BuildConfiguration":  "Debug",
    "TestRunner":  "dotnet",
    "NumberOfTestRunInstances":  5,
}
2019-05-17 11:05:09,595: Unima.Application.Commands.Project.OpenProject.OpenProjectCommandHandler: Failed to open project
System.Reflection.ReflectionTypeLoadException: Unable to load one or more of the requested types. Retrieve the LoaderExceptions property for more information.
   at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module)
   at System.Reflection.RuntimeAssembly.get_DefinedTypes()
   at System.Composition.Hosting.ContainerConfiguration.<>c.<WithAssemblies>b__16_0(Assembly a)
   at System.Linq.Enumerable.<SelectManyIterator>d__17`2.MoveNext()
   at System.Composition.TypedParts.TypedPartExportDescriptorProvider..ctor(IEnumerable`1 types, AttributedModelProvider attributeContext)
   at System.Composition.Hosting.ContainerConfiguration.CreateContainer()
   at Microsoft.CodeAnalysis.Host.Mef.MefHostServices.Create(IEnumerable`1 assemblies)
   at Microsoft.CodeAnalysis.Host.Mef.MSBuildMefHostServices.get_DefaultServices()
   at Unima.Application.Commands.Project.OpenProject.OpenProjectCommandHandler.<Handle>d__2.MoveNext()

The project I'm trying to test:
https://github.com/fluentassertions/fluentassertions/
Any hints?

I downloaded your project and tried to open it myself and managed to get passed the point you failed at. But it still fail later on when compiling because of different System.RunTime versions:
"Assembly 'FluentAssertions' with identity 'FluentAssertions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=33f2691a05b67b6a' uses 'System.Runtime, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' which has a higher version than referenced assembly 'System.Runtime' with identity 'System.Runtime, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'"
So I will try to take a look at it this weekend and see why Roslyn won't handle it.

Thanks for taking the time.
I haven't been able to compile the project in Visual Studio 2019 myself so far, but If you have any builds that I can run to help, feel free to reach out.

A bit of an update:
It seems like roslyn fail to build all your Core 1.1 projects because your main project only target Core 2.0. I found a couple of issues on this on the roslyn repo but sadly it doesn't seem to have that high priority👎
I will maybe try to look for some other solution or see if I do something wrong but I don't think there are a quick fix for now.

This is a problem with multiple target frameworks. It should work with the latest version (easiest are to try it with the visual studio extension).,


Docker 1.11-rc2 performance regression

As requested by @thaJeztah I am reporting a suspected regression in Docker performance when testing 1.11-rc2 as compared to 1.10. Here's a screenshot (the line is when we made the upgrade to rc2):

That was a trailing 3-day graph. Here's a 7-day if you want one too:

The peak on the right is pretty noticeable. Our app doesn't do anything too specific - runs a ton of containers, attaches some as TTYs, deletes, etc.
Output of docker version:
Client:
 Version:      1.11.0-rc2
 API version:  1.23
 Go version:   go1.5.3
 Git commit:   eabf97a
 Built:        Fri Apr  1 22:26:46 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.11.0-rc2
 API version:  1.23
 Go version:   go1.5.3
 Git commit:   eabf97a
 Built:        Fri Apr  1 22:26:46 2016
 OS/Arch:      linux/amd64

Output of docker info:
ontainers: 14
 Running: 14
 Paused: 0
 Stopped: 0
Images: 22
Server Version: 1.11.0-rc2
Storage Driver: overlay
 Backing Filesystem: extfs
Logging Driver: none
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: null host bridge
Kernel Version: 3.19.0-56-generic
Operating System: Ubuntu 14.04.4 LTS
OSType: linux
Architecture: x86_64
CPUs: 8
Total Memory: 29.45 GiB
Name: execute-1459580406
ID: ZYHJ:PS3I:SNMO:APRR:ZYXH:GXUR:5CKY:2NTE:J72N:2ICX:FZ6U:W5OC
Docker Root Dir: /var/lib/docker
Debug mode (client): false
Debug mode (server): false
Registry: https://index.docker.io/v1/
WARNING: No swap limit support

Additional environment details (AWS, VirtualBox, physical, etc.):
Running GCE 8-core machines with a local SSD scratch disk for /var/lib/docker

Thanks for testing and reporting on this!

This appears to be improved on rc3, so I'm comfortable closing for now.


🗑 Deprecation of toNegativeInt extension function with warning level

📝 Description
We would like to deprecate the Number.toNegativeInt() extension function with a warning level for using the NegativeInt.Companion.create(Number) function instead, introduced by #350.
🔗 Dependencies
This issue is blocked by the following ones:

[ ] #467

✅ Checklist

[ ] Deprecate the declaration with a warning level, refactor its usages and update the unreleased changelog.
[ ] Close this issue as completed and update tracking ones if present.

Another issue for this task will be created when ready.


[OSPP][Feature]Support Doris-Airbyte-Connector

Background:
Airbyte is a very popular product in the current data integration field. Its open source setting maintains a large number of connectors at the data source and destination ends to facilitate users to synchronize or transfer databases between different data sources. We need to contribute Doris connector to airbyte.
Requirements:

Investigate the development process of the airbag connector, including the design and implementation of the connector, and how to contribute to and maintain the connector.

Implement Doris' source and destination connectors.

Project output requirements:

Implement Doris' source and destination connectors.

Contribute the connector to the airbyte community.

Hi，any progress？


Add nested outline to refactored code

Also replace OBJECTs in tests with VARIABLEs.

Moved to here as https://github.com/posit-dev/ark/pull/606 was accidentally closed.

Hi @kv9898. Could you take a look at the changes I've made? I kept your general outline of the algorithm but I've simplified the way we manage the section stack. I've also added a test using insta snapshots. It was getting tedious to define the expected outputs 😄

Hi @kv9898. Could you take a look at the changes I've made? I kept your general outline of the algorithm but I've simplified the way we manage the section stack. I've also added a test using insta snapshots. It was getting tedious to define the expected outputs 😄

The changes look great! I was surprised by the snapshot test - must have been a big effort!
I noted that two of the tests failed, but it seemed that they were unrelated to our changes, right? I also noted that when using the nightly Rust (I tried with 1.84 on Windows), the ark kernel keeps crashing after 1 second or so. I (not the programme) panicked about some potential fatal errors I wrote. Things are good with 1.80.

I was surprised by the snapshot test - must have been a big effort!

Luckily very easy, I switched to using https://docs.rs/insta/latest/insta/ to generate the snapshot from the Debug format impls for our data structures. From now on we probably should default to using this sort of tests.

I noted that two of the tests failed, but it seemed that they were unrelated to our changes, right?

These failures are from https://github.com/posit-dev/ark/issues/609

It seems that once we initiate the Folding Range Capability, other folding rules are overridden (i.e. we need to cover all existing folding rules to prevent a regression). I'm thinking of using the same node-walking strategy to create foldable comment sections, but I'm not sure whether I can reuse any symbols infrastructure as folding range is a separate API. Also, is the node-walking strategy good for other foldings (e.g. regions, brackets)?

I think node walking would be a good strategy for folding ranges too. The ranges will be nested and this nesting is consistent with the nesting of the syntax tree.
I guess there are two options:

Either start from scratch with a new traversal of the tree. That's a bit wasteful in terms of performance but would lead to simpler code, and perhaps a bit of duplication.

Or collect folding range from the same place we colect symbols.

Note that we'll change the representation of the syntax tree in the coming weeks to https://github.com/rust-analyzer/rowan. Don't worry about implementing new code with Tree-sitter, just be aware that at some point this code will have to be rewritten. The TS and rowan representations will coexist for some time so there won't be any rush to switch.
But I think this tells me that we can keep things simple for the folding range algorithm, i.e. have a separate traversal. Make a good set of tests for it. And then when we rewrite these to use the new representation we can think about merging them. But if you see a simple way to colect folding ranges in the symbol traversal, feel free to go for it!
In either case it's probably best to start small. Since implementing folding ranges disables the existing rules we have, maybe this could be implemented under a feature flag that's disabled by default. This would allow you to implement incrementally with simple PRs.

Thanks for your work on this!


Manual installation powershell command not working for linux

Hi,
I have tried to install the OMS agent on Linux VM and the powershell command not working I got Error Message: "Set-AzVMExtension : Unterminated string. Expected delimiter: ". Path 'workspaceKey', line 3, position 2.
At line:9 char:2

Set-AzVMExtension -ResourceGroupName $vm1.ResourceGroupName -VMName  ...

 + CategoryInfo          : CloseError: (:) [Set-AzVMExtension], JsonReaderException
 + FullyQualifiedErrorId : Microsoft.Azure.Commands.Compute.SetAzureVMExtensionCommand"

I have fixed the issue based on the the Set-AzVMExtension documentation.
Changing the variable and the command to that.
$PublicConf = @{"workspaceId"="WorkspaceID value"}
$PrivateConf = @{"workspaceKey"="<Primary key value>”}
Set-AzVMExtension -ResourceGroupName $vm1.ResourceGroupName -VMName $vm1.Name -Name "OmsAgentForLinux" -Publisher "Microsoft.EnterpriseCloud.Monitoring" -ExtensionType "OmsAgentForLinux" -TypeHandlerVersion '1.0' -Location $vm1.Location -Settings $PublicConf -ProtectedSettings $PrivateConf -ForceRerun True

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8267e218-3748-2820-3eee-80479705eec2
Version Independent ID: 8c6d5fce-6383-a0f8-7df3-f5e0a77bbad6
Content: Data Collection in Azure Security Center
Content Source: articles/security-center/security-center-enable-data-collection.md
Service: security-center
GitHub Login: @monhaber
Microsoft Alias: v-mohabe

@clerens Thanks for your feedback! We will investigate and update as appropriate.

Hey @clerens thanks for letting us know about this! So the command is correct, but the initialization of the variables public conf and private conf are wrong.
And per the docs : https://docs.microsoft.com/en-us/powershell/module/az.compute/set-azvmextension?view=azps-2.6.0
It should be a hashmap with an equal sign.
$PublicConf = '{
     "workspaceId": "WorkspaceID value"
 }'

 $PrivateConf = '{
     "workspaceKey": "<Primary key value>”
 }'

And per the docs, you changed it to have equal signs.
$PublicConf = @{"workspaceId"="WorkspaceID value"}
$PrivateConf = @{"workspaceKey"="<Primary key value>”}

But this command should stay the same:
Set-AzVMExtension -ResourceGroupName $vm1.ResourceGroupName -VMName $vm1.Name -Name "OmsAgentForLinux" -Publisher "Microsoft.EnterpriseCloud.Monitoring" -ExtensionType "OmsAgentForLinux" -TypeHandlerVersion '1.0' -Location $vm.Location -Settingstring $PublicConf -ProtectedSettingString $PrivateConf -ForceRerun True`

@clerens Please let us know if there are anymore questions within the scope of this git issue. If not, I will be closing out this git issue by end of day monday as we are currently making the change in the docs.
Please reopen this git issue if you have anymore concerns. Thanks

@clerens Please let us know if there are anymore questions within the scope of this git issue. If not, I will be closing out this git issue by end of day today. Please reopen this git issue if you have anymore concerns. Thanks


Page refreshing after clicking JSON output while testing Inference API of any model

I am testing one of the model in HF. While testing Inference API after clicking the Compute it gives the result. But after that when I click the JSON output the page automatically reloads. Take a look
https://github.com/huggingface/huggingface_hub/assets/101238933/528dff55-7751-4f04-bc8e-63ef9d88ce41
To reproduce : Click JSON output in any model Inference API

cc @mishig25 for viz

Thanks for reporting @surjendu104! I have also been able to reproduce on https://huggingface.co/dslim/bert-base-NER. I'm moving this issue to huggingface.js repo that is more suitable for widget issues.


Add conda distribution

Conda-forge package in progress here: https://github.com/conda-forge/staged-recipes/pull/23906

Feedstock repo here: https://github.com/conda-forge/tstrait-feedstock
Package here: https://anaconda.org/conda-forge/tstrait
:tada:


Herd immunity

I would love to have some kind of explanation for the herd immunity date in the bot, like the assumed vaccination rate etc.
Thanks for the bot, I love it!

As this is the most interesting part of the bot, I will add a section on this on the README soon. I will notify you then :)

Adressed in dd0c7c4d1cc9884c8039b8cbe209a11f77ff1455. @larsfu
If you have additional questions, just open another issue :)


[ENH] Add query tool to docker compose

Closes #145

Changes proposed in this pull request:

update docker-compose.yml to also launch query tool
new ENV variables in .template.env:

NB_QUERY_TAG for the docker image tag of query tool
NB_QUERY_PORT_HOST for host port of query tool

Checklist

[ ] PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
[ ] PR links to GitHub issue with mention Closes #XXXX
[ ] Tests pass
[ ] Checks pass

For new features:

[ ] Tests have been added

For bug fixes:

[ ] There is at least one test that would fail under the original bug conditions.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
368

Relevant Lines:
368

💛  - Coveralls


increments scheduler version to 1.0.16

updates scheduler to use cassandra version 3.0.8
updates cassandra build script to metrics version 3.0.3

retest this please

retest this please


feat: auto read the data folder, no need for fix name, add file argv directly also

Check the commit to see the modification.

It's more convenient for people to directly copy their point cloud file in the data folder and run it. No need to rename all of them.
for a single file demo, add the argv also for convenience.

Test command:
mkdir build && cd build
cmake .. && make -j$(nproc)

# example here
./examples/cpp/demo_visualize /home/kin/data/1670247988.bin

Thank you for sharing more convenient codes. Your pull request has been merged just before. :+1:


Update set-body-policy.md

Added clarification that liquid templates don't work inside return-response.

@dlepow
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

@dlepow - this section now has 3 consecutive important alerts. Can you revise this in a follow-up PR to adhere to MS style? (very limited alerts and no more than one in a row). thanks


any plans to support linux-musl

I understand that it is mentioned that "We do not support linux-musl currently."
are there any plans to do so?

Hi happy to get support on this through PR, see #44 closing in favour of that.


Admin :( Button Problems

In admin, if you click one of the :( icons, not a smile or an idea, then a feedback tab pulls up requesting you to submit a feedback as that person. That is a problem.
Even if the screen doesn't actually submit, it is still a very bad problem.
CLICK THE SAD ICON NOT THE TEXT, BUT THE ICON Clicking the text won't do anything
Also, maybe for a separate issue, but what is "Select a feedback on the left" for if it doesn't do anything?

Nevermind @thatoddmailbox told me it was the hexy way to screenshot a page and not a weird feedback box LOL


Example PowerShell cmdlet appears to have been nerfed

Under "Accessing Metrics" | "Reading metric values" the PowerShell example has been mangled and appears like this:
-=-=-=-
$resourceId = ""
$resourceId -MetricName "UsedCapacity" -TimeGrain 01:00:00
-=-=-=-
There is no mention of the Get-AzMetric cmdlet at all?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1dd1c1ed-ebf6-4606-b7cd-cc005fee74b2
Version Independent ID: d32aec41-af2c-82ac-e1ac-d5b7105e48cc
Content: Monitoring Azure Blob Storage
Content Source: articles/storage/blobs/monitor-blob-storage.md
Service: storage
GitHub Login: @normesta
Microsoft Alias: normesta

@W1ll1amz You are correct . We will review this and update the thread.

@W1ll1amz We have initiated the change request and updated the documentation and fixed the command with the following . This should be updated in the live documentation in the next 48 hours.
   $resourceId = "<resource-ID>"
   Get-AzMetric -ResourceId $resourceId -MetricName "UsedCapacity" -TimeGrain 01:00:00

Thank you .


Fix: TestCLISign

Summary of Bug

Version

Steps to Reproduce

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

thanks @sahith-narahari


Update image header for README

Don't know why it was pointing to a web header. It looks prettier now! 😄

Thanks!


UnboundLocalError while trying the example from documentation

Thank you for the package.
I am quite new to GEOparse and have been trying to figure out the basics of the package. I tried to implement the initial example  provided on the documentation and get an Unbound Local Error. The screenshot of the same is as follows:

Python Version: 3.8.5
GEOparse Version: 2.0.2
Any leads about how to overcome this problem would be really helpful. Thanks!

Hi @sowmyamanojna, most probably the NCBI server changed something. Let me check it.
Rafal

This works for me. Did you try simply:
curl ftp://ftp.ncbi.nlm.nih.gov/geo/series/GSE1nnn/GSE1563/soft/GSE1563_family.soft.gz
If you can't see that file from your machine using curl, you have some kind of network error unrelated to GEOparse.


RESEND mail sending error

Failed to compile
Next.js is up to date
<EMAIL_ADDRESS>Attempted import error: 'renderToReadableStream' is not exported from 'react-dom/server' (imported as 'renderToReadableStream').
Import trace for requested module:
<EMAIL_ADDRESS>./node_modules/resend/build/src/resend.js
./node_modules/resend/build/src/index.js
./src/app/api/send/route.js
This error occurred during the build process and can only be dismissed by fixing the error.

Failed to compile
<EMAIL_ADDRESS>Attempted import error: 'renderToReadableStream' is not exported from 'react-dom/server' (imported as 'renderToReadableStream').
This error occurred during the build process and can only be dismissed by fixing the error.


Add option to sign transaction hash with Ledger device

Preview is available here:http://laboratory-pr838.previews.kube001.services.stellar-ops.com/

works for me. Thanks!


ccccccughrujlfheulgehtreghlncrechdhivhfergkk

My Environment

ArangoDB Version:
Deployment Mode:
Deployment Strategy:
Configuration:
Infrastructure:
Operating System:
Total RAM in your machine:
Disks in use:
Used Package:

Component, Query & Data
Affected feature:

AQL query (if applicable):

AQL explain and/or profile (if applicable):

Dataset:

Size of your Dataset on disk:

Replication Factor & Number of Shards (Cluster only):

Steps to reproduce

Problem:
Expected result:

This is obviously meaningless, so closing it.


Automatic Issues For Nightly KIC Test Failures

Problem Statement
In the past there have been some nightly test failures that have taken longer for us to resolve than we would have liked. The purpose of this task is to add automatic issue creation whenever this occurs to help increase the noise made from a failure.
Disambiguation: this is about KIC tests that we run nightly; not tests that we run against Kong Gateway nightly builds.
Acceptance Criteria

[ ] issues are now created at severity/high for any nightly test run failure

This looks relatively easy to do with e.g. https://github.com/marketplace/actions/create-github-issue
steps:
  - uses: actions/checkout@v3
  - name: Something that might fail
    run: exit 1
  - name: Create Issue on Failed workflow
    if: ${{ failure() }}
    uses: dacbd/create-issue-action@main
    with:
      token: ${{ github.token }}
      title: Action workflow failed.
      body: |
        ### Context
        [Failed Run](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }})
        [Codebase](https://github.com/${{ github.repository }}/tree/${{ github.sha }})
        Workflow name - `${{ github.workflow }}`
        Job -           `${{ github.job }}`
        status -        `${{ job.status }}`
      assignees: SomeUsername,AnotherUsername

Sounds good.

Blocked until we get rid of frequent causes for test flakiness (and get test flakiness under a "reasonable" threshold).

Concern by @rainest: this might end up with numerous reports for the test failing time after time.
Proposed solution: dedup by test case name. The automation would reopen the issue when an issue for this test case name fails (and comment with the run ID).

Another alternative proposed by @rainest and @pmalek: use external tooling to visualize trends in failures for specific test cases.


Custom html tags are red in php language

This was rectified for the html language in #56467 but I'd like to see this done for php as well. I work with Laravel so all of my views are in php files.

Guessing that we just need to get the php html grammar to reference text.html.derivative
https://github.com/microsoft/vscode/commit/cfc2a2212de9ea10943af58ebd1817a5ad196463


odb: Adding new USE categories to follow LEF spec

These categories (SCAN, TIEOFF, RESET) show up in some Google LEF files

ready for review?

Yes.

This looks to be a write_abstract_lef issue instead.


Improved: code to use defined method instead of writing same code again(#456)

Related Issues
Using the same logic again to check for default_billing
closes #456
Short Description of the PR

Used the predefined method instead of writing the conditions again
Screenshots of Visual Changes before/after (if There Are Any)

Pull Request Checklist

[x] I have updated the Changelog (V1) and mentioned all breaking changes in the public API.
[ ] I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.
[x] I have tested my Pull Request on production build and (to my knowledge) it works without any issues

[ ] I have followed naming conventions

Upgrade Notes and Changelog

[x] No upgrade steps required (100% backward compatibility and no breaking changes)
[x] I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

Contribution and Currently Important Rules Acceptance

[x] I read and followed contribution rules

@Fifciu Please review

Good idea, thanks. Please solve the conflict in the changelog

Resolved conflicts

I see unit tests are not passing. Could you please fix them @ymaheshwari1 ?

Sure

I see unit tests are not passing. Could you please fix them @ymaheshwari1 ?

Hi @Fifciu Fixed the failing unit tests, please review

Great job @ymaheshwari1 , thank you a lot!


[Tests-Only] [Do Not Merge] Trigger CI

There were a lot of acceptance test refactorings merge to OC10 core master just now.
Make sure that they pass.

Passes


mdl-selectfield.min.js:1 Uncaught ReferenceError: componentHandler is not defined

Maybe the problem is this