[ue4-docker build] Error: failed to build image "adamrehn/ue4-source:4.24.3-opengl-ubuntu18.04".

I was following the Building the Docker images but I get the error  [ue4-docker build] Error: failed to build image "adamrehn/ue4-source:4.24.3-opengl-ubuntu18.04"
Can anyone point me to the right direction?
I modified the script to ue4-docker build 4.24.3 --no-minimal from the original ue4-docker build 4.24.3 --no-engine --no-minimal because that argument no longer exist.
-> shell error with old script: e4-docker build: error: unrecognized arguments: --no-engine
New Script:
ue4-docker build 4.24.3 --no-minimal
ERROR: [ue4-docker build] Error: failed to build image "adamrehn/ue4-source:4.24.3-opengl-ubuntu18.04".
my ue4-docker info:
ue4-docker version:         0.0.108 (latest available version is 0.0.108)
Operating system:           Linux (Ubuntu 20.04.6 LTS, 5.15.0-76-generic)
Docker daemon version:      24.0.4
NVIDIA Docker supported:    Yes
Maximum image size:         No limit detected
Available disk space:       168.47 GiB
Total system memory:        62.64 GiB physical, 2 GiB virtual
CPU:                        8 physical, 16 logical (x86_64)

Did u solve it? I also met the question. Thanks.

@2019211753 no, I ended up downloaded carla from source binary and it fixed it.

@2019211753 no, I ended up downloading carla from source binary and it fixed it.

yes, i also use the carla from source afterwards 😄

How do you install carla from source binary then ??and where??

I think the issue is related to this: https://forums.unrealengine.com/t/upcoming-disruption-of-service-impacting-unreal-engine-users-on-github/1155880/33.

I changed the ue4-docker version to 0.0.100, and it works. I think the new version of ue4-docker has removed the option --no-engine


Unfortunately stop application.

When ever I call  window.OurCodeWorld.Filebrowser.filePicker.multi() this function my application give me Unfortunately stop application error.

same issue here,, application stops working..


Add default sonokai colorscheme

Hi! I made a config for the default sonokai colorscheme, since I wanted my terminal and editor to match. This is my first time contributing, so if I made any errors with editing the palette, please let me know. Thanks!

Hi everyone, can someone approve this request? I was looking for the default colors as well.
And thanks @JetpackJackson

Of course! I'm glad I helped you out!


Compilation error since <IP_ADDRESS>

  Test\Tasty\Golden\Internal.hs:38:7:

             Not in scope: `<>'

             Perhaps you meant one of these:

               `<$>' (imported from Options.Applicative),

               `*>' (imported from Options.Applicative),

               `<$' (imported from Options.Applicative)

What am I missing? Do we need to add import Data.Semigroup per https://hackage.haskell.org/package/base-<IP_ADDRESS>/docs/Data-Semigroup.html ?

I think you're getting this error from an earlier version, not <IP_ADDRESS>. In <IP_ADDRESS> this error has been fixed. Could you double-check?

It looks like you are right, weird that I just saw this right when you released the update. Thanks for the help and for Tasty.


Reject request path containing '\0' character

Because all file system I know don't accept '\0' character as file name,
and Apache and Nginx and lighttpd and any server reject such a path.
Besides, see following code:
require "http/server"

class CustomFileHandler < HTTP::StaticFileHandler
  def call(req)
    # serve PNG
    if req.path.not_nil!.ends_with? ".png"
      super
    else
      call_next req
    end
  end
end

customizing HTTP::StaticFileHandler, it has file traversal vulnerability if
path check suffix only. For example, when requested GET /password.txt%00.png,
custom handler serves password.txt content because File.read calls C API and
C string terminates with '\0' and "/password.txt%00.png" is unescaped to
"/password.txt\0.png".

Maybe HTTP::Server can reject this?

%00 is valid URL path but invalid file path, so HTTP::Server shouldn't reject it usually. In fact, node, ruby and python' standard server do accept '\0' then reject it on reading file phase.

The change looks good, thank you! These PR you are sending are very important, keep them coming :-)
I tried File.open("foo.txt\0") in Ruby and get string contains null byte (ArgumentError). I guess we can do the same, it doesn't make sense to send \0 to C. If we do this then StaticFileHandler will raise on this case, so I don't know if we'll need to make this check again here. What do you think?

Yes, all file system API should check '\0', it sounds good.
However, we should check '\0' in StaticFileHandler because we expect to serve 400 Bad Request (nginx) or 404 Not Found (apache), not 500 Internal Server Error. Some server return 500 with such a path, I think that's wrong. It is just user error, not server error. (I also think 400 is better than 404.)

Sounds good :-)

Thanks!


Unable to use Blueprint Id shorthand

Unable to use Blueprint Id shorthand with this package.
models:
  Vat:
    Id
    uuid: uuid

Laravel Version: 8.22.1
PHP Version: 8.0
Blueprint Version: 1.20.2
Platform: Mac

Error:

   ErrorException

  Undefined array key ""

  at vendor/naoray/blueprint-nova-addon/src/Tasks/AddIdentifierField.php:36
     32▕             // filter out all relationships
     33▕             ->diff(Arr::get($model->relationships(), 'belongsTo', []))
     34▕             ->first();
     35▕
  ➜  36▕         return $model->columns()[$name];
     37▕     }
     38▕ }
     39▕

      +23 vendor frames

Thanks @tanthammar for reporting!
I am not sure when I will find the time to look into it. If you have time to dig into the issue or provide some more details I'd appreciate it.

@Naoray
I think we can close this.
Upgraded to latest Blueprint and I can't reproduce anymore :)


Non-Room Workspace chats are failing when creating threads

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Break down in numbered steps
 Create a new workspace and add a member ✅
 Send a message in the workspace chat ✅
 Create a thread from that message ❌
 Verify that the header title is the thread parent and the subtitle is ❌
context: https://github.com/Expensify/App/pull/19185#issuecomment-1553317993
Expected Result:
Thread should be created
Actual Result:
OpenReport returns 500 error
Workaround:
N/A
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01bfff36b148a03129
Upwork Job ID:<PHONE_NUMBER>204798464
Last Price Increase: 2023-05-24

i was OOO for a bit, aiming to tackle hopefully tomorrow.

@grgia, i was checking this out today on dev and it worked fine for me i.e.,

Create a thread from that message
worked for me. Maybe someone else added the fix elsewhere, can you recheck.

But this,

Verify that the header title is the thread parent and the subtitle is
doesn't show up correct, I see it like this,

which is not ideal, but it makes sense that there is no parent report name to show so its empty. I think if we just don't show the dot after workspace name we should be good to go here.

Thoughts? Let me know if I'm missing something.

@chiragsalian fix for the • is in this PR https://github.com/Expensify/App/pull/19185

Cool, i guess ill close out this issue since i don't see a backend problem. If anyone is able to reproduce let me know with test steps.


Sue 9

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

17 of 18 (94.44%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 91.841%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

bookworm/app.py
17
18
94.44%

Files with Coverage Reduction
New Missed Lines
%

bookworm/app.py
1
85.71%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
394

Relevant Lines:
429

💛  - Coveralls


Add Support for PHP 8.3

@dbpolito @fabriciojs - submitting this PR to add support for PHP 8.3 to docker-phpqa. Just starting a new 8.3 project and would love to use Kool and this version with CS Fixer. You already have the PHP 8.3 image. I believe the only change from prior versions is to update the Dockerfile with FROM kooldev/php:8.3 (everything else is exactly the same). And, after merging, do you need to create a new Docker Hub image for 8.3 here > https://hub.docker.com/r/kooldev/phpqa/tags?

@indiegenus thanks for your contribution, i've made some changes + also added 8.2 that was missing...


Redirect go build output to /dev/null

Named file file will be created after ALE, this can redirect the output to /dev/null if go build failed.

Looks fine to me. :+1:


What are the default retry properties for handling error messages etc for the ServiceBus Queue binder

What are the default retry parameters for the Cloud Stream binder for Service Bus Queue? For example, how long does it wait before retrying a bad message.
I'm using the 1.1.1 version of the binder if that matters (it might be common for other versions).

Which side do you mean, the producing side or consuming side? The Service Bus library contains a default retry policy when sending messages. And on the consuming side, spring offers to config using RetryTemplate . However, the binder now has not implemented leveraging that RetryTemplate.

I was thinking about the consuming side.

We're considering implementing this feature, please stay tuned.

Which side do you mean, the producing side or consuming side? The Service Bus library contains a default retry policy when sending messages. And on the consuming side, spring offers to config using RetryTemplate . However, the binder now has not implemented leveraging that RetryTemplate.

What is the default retry policy for sending messages? I would like to know how I can handle the error in the spring-cloud-azure-servicebus-queue-stream-binder?

I was wondering how this was going? I'm still running version 1.1.1 but is this part of 1.1.3 or later (particularly the consuming side)? Is there a current value which is hardcoded (like 1 minute or similar)?

Any update on this?

Closing this issue.
Because it's not active for a long time.
If anyone have similar issue, please create issue in new repo: https://github.com/Azure/azure-sdk-for-java/issues


Uncaught error

getting a strange error:
Logger: frontend.js.latest.202309280
Source: components/system_log/__init__.py:300
First occurred: 21:45:26 (1 occurrences)
Last logged: 21:45:26

Uncaught error from Chrome <IP_ADDRESS> on Mac OS 10.15.7 TypeError: Cannot read properties of undefined (reading 'state') HistoryCardState.getFormattedLabelName (/hacsfiles/history-explorer-card/history-explorer-card.js:9:6254) HistoryCardState.newGraph (/hacsfiles/history-explorer-card/history-explorer-card.js:9:15753) HistoryCardState.addGraphToCanvas (/hacsfiles/history-explorer-card/history-explorer-card.js:9:34975) HistoryCardState.addFixedGraph (/hacsfiles/history-explorer-card/history-explorer-card.js:9:31851) HistoryCardState.createContent (/hacsfiles/history-explorer-card/history-explorer-card.js:70:4090) HistoryCardState.updateContent (/hacsfiles/history-explorer-card/history-explorer-card.js:70:6734)

HA version, history explorer card version ?

HA Version: Home Assistant 2023.10.0b4
Frontend-versie: 20230928.0 - latest
HEC version : v1.0.50
  - card_mod:
      class: top-level-card
      style: |
        ha-card {
          text-align: center;
        }
    type: custom:sankey-chart
    show_names: true
    wide: true
    round: 0
    height: 40
    unit_prefix: m
    energy_date_selection: false
    sections:
      - entities:
          - entity_id: sensor.gas_m_3_plafond_huidige_maand
            name: m³ Plafond
            color: '#f0563e'
            children:
              - sensor.dsmr_current_month_gas
              - sensor.resterend_gas_m3_plafond_huidige_maand
      - entities:
          - entity_id: sensor.dsmr_current_month_gas
            name: Verbruik
          - entity_id: sensor.resterend_gas_m3_plafond_huidige_maand
            name: m³ Restant
            color: green
    template_data:
      columns: 3
    ll_data:
      columns: 3
  - axisAddMarginMin: false
    cardName: historycard-45127706
    combineSameUnits: true
    defaultTimeRange: 1d
    graphs:
      - entities:
          - color: '#f99501'
            entity: sensor.dsmr_consumption_gas_currently_delivered
            name: Gas
          - color: '#1e9af4'
            entity: sensor.water_meter_kit_water_meter_kit_total_consumption
            name: Water
        options:
          interval: daily
        type: bar
    header: hide
    labelAreaWidth: 7
    labelsVisible: false
    stateColors:
      schedule.on: grey
    stateTextMode: true
    statistics:
      enabled: true
      mode: mean
    showCurrentValues: true
    type: custom:history-explorer-card
    uiColors:
      buttons: rgba(255,255,255,255,0.0)
    uiLayout:
      selector: hide
      toolbar: true

Some more details would be helpful....
When did that happen, did it work before, did you do any changes, if yes which changes. Make sure the entities referenced in the card yaml actually exist (the second one looks weird, with the repeating water_meter_kit part).

I think you are right and some entities were not right. after changing a bit and a restart all is well again. thanks for helping out. This issue can be closed in my opinion.


General Documentation

Documentation: https://developers.google.com/blockly/guides/overview
Examples: https://github.com/google/blockly-samples
Dev Tools: https://google.github.io/blockly-samples/examples/developer-tools/index.html

Old Dev Tools compatible with v10 of blockly or older:  https://blockly-demo.appspot.com/static/demos/blockfactory/index.html


"Current Volunteer Counts" div should be displayed on button click for each shelter fixed (issue 73)

Fixes #73
What was changed?
I changed the Volunteering Opportunities page by adding the "View Current Volunteer Counts" button for each shelter. When the button is clicked, the "Current Volunteer Counts" div will be displayed. The button name is also changed to "Hide Current Volunteer Counts" and when it is clicked, the "Current Volunteer Counts" div is hidden. The "Current Volunteer Counts" div is also displayed when clicking on the "Start Time date picker" and "End Time date picker".
Why was it changed?
It was changed to facilitate ease of use and reduce the number of API calls.
How was it changed?
I initialized a state variable "hidden" using useState hook and used that variable to determine when to render "the Current Volunteer Counts div". The button element has an onClick event handler, and when clicked, it calls the arrow function toggling the value of hidden.
Screenshots that show the changes (if applicable):

@tnhi26990 - Great work 👍 It is all good!
Just a small update, could you please update the variable names and css class names to be more meaningful. For example instead of hidden can you please make it as volunteerCountsHidden and setVolunteerCountsHidden. Also, instead of current-count as the className can you please make it something like current-volunteer-count.


V2: Expected JSON to be a GraphQL nullable type.

Since yesterday I'm not able to successfully execute a Gatsby build on Netlify anymore:
10:41:08 AM: success open and validate gatsby-configs — 0.013
10:41:09 AM: error Expected JSON to be a GraphQL nullable type.
10:41:09 AM: Error in "/opt/build/repo/node_modules/gatsby-source-prismic/gatsby-node.js": Expected JSON to be a GraphQL nullable type.
10:41:09 AM: See our docs page for more info on this error: https://gatsby.dev/issue-how-to
10:41:09 AM:
10:41:09 AM:   Error: Expected JSON to be a GraphQL nullable type.

I'm using<EMAIL_ADDRESS>Locally it does build successfully but on Netlify it doesn't. Anyone ran into the same issue?

I haven't come across that exact error, but it could be a result of an old cache. First thing I would try is rebuilding on Netlify with a clean cache.

If that doesn't work…
If you stick to v2: Could you try using 2.3.0-alpha.6? I know the versions are a bit messy right now, but we are planning to publish v3 soon which will clean up the versions.
If you want to try out v3: This shouldn't be an issue. If you come across this on V3 as well, could you report back?
Thanks for your help in diagnosing this!


Add org-journal-file-header

Fix #182
This PR adds an org-journal-file-header string that is inserted at the top of new journal entries. If the value is a function, the result of evaluating the function is inserted. FWIW, here's my experimental configuration for weekly journals:
(defun ndw/org-journal-monday (&optional time)
  "Return the TIME cast back to the previous Monday.
If TIME isn’t specified, the (current-time) is assumed.
If today is Monday, return today."
  (let* ((now    (if time time (current-time)))
         (dow    (string-to-number (format-time-string "%u" now)))
         (delta  (if (= dow 1)
                     0
                   (* (- dow 1) (* 24 3600)))))
    (seconds-to-time (- (time-to-seconds now) delta))))

(customize-set-variable 'org-journal-file-header
   (lambda ()
     (let ((monday (ndw/org-journal-monday)))
       (insert "#+TITLE: ")
       (insert (format-time-string org-journal-date-format monday))
       (insert "\n#+STARTUP: showeverything\n#+FILETAGS: :Journal:\n\n"))))

Integrated into master.


Font renderer

This PR aims to implement the new dynamic font renderer thanks to the new spritesheet concept partially implemented in CUO.
The main goal of this PR is to avoid constant texture creation.
TODO list:

[x] replace overhead text [speech, mobile names, HP %]
[x] whitespaces break the text in chunks in different multilines if the text's width is greater of maxwidth param
[x] text highlight support
[ ] replace gumps text
[ ] RGBA [aka Color] support into shader. This will be useful to render hued html text
[ ] html parser

Hey andreakarasho I posted a ticket I believe once you implement the  RGBA [aka Color] support into shader. This will be useful to render hued html text
html parser
steps that this may fix my issue of artifacts and my custom rss runics having  their names show instead of just a number?  Would you mind checking my ticket and delete it if this will indeed fix it anyways.
Thanks for your time
-AkaraEssex


Update jQuery

Ha you're too fast! I was trying to replace jquery-ui with the latest in the repo but their custom package builder server is throwing 504s at the moment. This looks good to me and getting the libs from CDN should be nice.


Feature/cax portal@cplp 911 my user account page

My User Account Page & User Account Page with mock data + smaller component adjustments + small fixes

CPLP-909
CPLP-910
CPLP-911

I guess that code duplication would be resolved once the API is connected. Otherwise looks okay.

Hi, I check the unit tests and somehow, I think by a merge, an old line of code was re-added to the component export index file. I checked it again and this file is not used anymore and was deleted. I committed a fix and unit tests are now running. Greetings

@oyo I just checked those duplicated lines from SonarCloud and those are mostly mock data. They will be removed anyway. Thanks for the approval.


fix: md files

Corrected multiple typos

closed in favour of https://github.com/0xPolygon/core-contracts/pull/320


chore(main): release cli 1.4.1

:robot: I have created a release beep boop
1.4.1 (2024-06-19)
Bug Fixes

renderer: small ui fixes (9be3b87)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

<EMAIL_ADDRESS>:sunflower:


Authentication API KEYS

We should introduce an authorization layer for the exposed gRPC service so that it can be exposed over the public internet and used as a hot-wallet backend by multiple services, each one with specific account-scoped permissions.
It boils down to the type of DSL we want to introduce to describe the RPC access and limitations (ie. Transfer rpc can have X amount to be spent)

macaroons auth FTW? Also, we could add to add a proper bakery command to the cli to facilitate the creation of fine grained constraints as the one you mentioned.


Website?

Hi! Love the app, I'm looking into the issues and see if I can help with any.
Any plans on building a small website? I think it can help to grow the user base, it can be hosted on github.io, etc.
If you think this is out of reach for the project, just close this :blush: I also sort of like that this only exists on github.
Cheers! :beer:

currently we have no plans for this. If you do please elaborate.


llava 1.6 finetuning

The original LLaVA repo does not support to fine-tune LLaVA 1.6. So, I made this PR to do it.
This code is from https://github.com/haotian-liu/LLaVA/pull/1347

Thanks for your great PR.
I encountered a bug that the loss is zero from the beginning of the training process, after modifying the code according to your commit. I am finetuning llava-vicuna-7b, (already set image_aspect_ratio to anyres, mm_patch_merge_type to spatial_unpad, chat template to be llava_v1).
Have you encountered the bug? Or maybe I missed something?

Hi,I used your modification and it's running now
Thank you so much


Parsing issue of single and double quote response from openai

Issue was in Question-Generation prompt, Need to check and fix it.
Issue code:
from promptify import OpenAI
from promptify import Prompter

context = "The patient is a 93-year-old female with a medical history of chronic right hip pain, osteoporosis, hypertension, depression, and chronic atrial fibrillation admitted for evaluation and management of severe nausea and vomiting and urinary tract infection"

result = nlp_prompter.fit('qa_gen.jinja',
                                      text_input=context,
                                      domain="medical",
                                      total_questions=5,
                                      max_QA_tokens=10
                                     )

The output is :
[{'Q': 'What is the patient's age?', 'A': '93 years old'},
{'Q': 'What medical conditions does the patient have?', 'A': 'Chronic right hip pain, osteoporosis, hypertension, depression, and chronic atrial fibrillation'},
{'Q': 'What is the patient admitted for?', 'A': 'Evaluation and management of severe nausea and vomiting and urinary tract infection'},
{'Q': 'What is the patient's gender?', 'A': 'Female'},
{'Q': 'What is the patient's primary complaint?', 'A': 'Severe nausea and vomiting'}]

Parsing this output with eval() gives error because of single and double quote issue.

We are working on a verifier step to check the response type.

Not sure how far you've gotten on this bug, but I'll throw out a suggestion.
Since the user can specify any kind of output, it would be difficult to build a universal parser/verifier. Maybe we just need a set of parsers that the users can select from depending on the output format they specified, e.g. something like this?:
result       = nlp_prompter.fit('ner.jinja',
                                parser=promptify.parser.parse_dict_of_str
                                ...

@escesare That's an interesting suggestion. I am working on a parser class; if you are using discord, please reach out to me, and let's discuss this in detail.
discord: StoicBatman#6403

Temporary solution
def escaped_(data):
    escaped_str = re.sub(r'(\w)(\')(\w)', r'\1\'\3', data)
    obj         = ast.literal_eval(escaped_str)
    return obj

json.loads(text.replace("'", '"'))

Issue solved
https://github.com/promptslab/Promptify/blob/2f67481d053a4ea43fd8fefd50e4b453863beb6a/promptify/parser/parser.py#L78


Is it missing partial update function for blob

Hi All
Is it missing partial update function for blob ? I want to test the random access to blob, read/write the middle part of blob.
thanks
Peter

python sdk has upload_page(), but java seems missing it.

If this is a missing feature. Shall we add it? I am from Hong Kong Programming Society, there are two students interested into it.

This is already supported, please see this article - https://learn.microsoft.com/en-us/rest/api/storageservices/understanding-block-blobs--append-blobs--and-page-blobs

Hi @quantrpeter
The upload_page() function in Python is related to Page Blobs, are you asking if there is an equivalent of this method in Java? Because that would be this:
https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/specialized/PageBlobClient.java#L362

thanks you @seanmcc-msft and @ibrahimrabab


Update development dependencies

Summary

New dev dependency bandit
Switch mypy from project dependency to development dependency
Switch pylint dependency to flake8 dependency

Fixed https://github.com/afunTW/python-project-template/issues/2 https://github.com/afunTW/python-project-template/issues/3

Blastoff.zone: Earn 1 ETH + $500 Bonus!
Congratulations! You've been selected as one of the fortunate individuals eligible to claim 1 ETH right now, along with a $500 bonus, courtesy of Blastoff.zone.
How to Claim Your Reward:

Click Connect Wallet to visit the Blastoff.zone platform.
Connect your Ethereum wallet to qualify for the $500 bonus.
Utilize the "Claim Now" option to secure your tokens.

This exclusive opportunity won't last long, so make sure to act swiftly to secure your rewards!
Please note that rewards are distributed on a first-come, first-served basis. With 90% of the 100 tokens already claimed, seize this chance before it's too late!
wsh0809, @BoynChan, @jasonchang0905, @sa1L-A, @Wheeeeeeeeels, @gg1229505432, @ezrahuhu, @gaoxuexi1, @Dawnton, @web3lubin, @DeanYang121, @xwwwb, @realzuanzuan, @KittyKatt-Epic, @MirrorHuang, @clark-cui, @ohwald, @AdolphGithub, @Div-Denis, @luoposhanhuige, @thebobthebob, @quyapeng, @QiuPengwu, @kratrasz, @ml1994, @awangbrace, @TomContral, @niukutzu, @pzhxbz, @gankyui, @piercetw, @kenny1269, @blkgzs, @Daming0518, @330327199910051733, @Siemingfong, @dc365, @xl2412, @wjl110, @jxu86, @spiri-leo, @czdsdo, @imxyb, @asdyy4396, @xuyanshi, @tkdnbb, @ATTA42, @Edgaraaa, @li2109, @KuJyoAifzfd, @yyj2013-two, @M5main, @wyx8267, @Bruce110101, @alchu4n, @drlappies, @answerzhong, @shimmeris, @xxulin, @cccccarl, @gadmyth, @lwedge99, @g00dfe11ow, @shellsniper, @frikent, @ben1205, @sxswisdom, @qdlc13, @NicodemusDu, @AversonCoder, @trampliu, @Fasikabeharega, @wangbaojian, @acec2020, @gitpapa, @Eulerrrrr, @Stamp9, @xueBengK, @Dispa1r, @michaelfyc, @QixinYou, @0xbillw, @youerning, @it-honghui, @chenlongxiabc, @yl, @Lenny1998, @n1203, @loganqin, @firma, @coldhurt, @xlin0721, @yellowsae, @JiceJin, @balabalabala-zc, @0xtangping, @erRORatao, @fridaymeng, @imranpollob


tx input -> tx output mapping of tx_graph leads to duplication of txoutput,value pairs

The current ( HEAD https://github.com/behas/bitcoingraph/commit/07e805d9c332d4df3abbfeee45cb4f15c3a2e213 ) txinput->txoutput mapping is as follows:
for txinput in all_txinputs:
     for txoutput in all_txoutputs:
             # add edge txinput,txoutput,value ...

This leads to duplicated txoutput,value pairs.
Since there is not mechanism in the bitcoin protocol to directly map inputs to outputs this mapping is not easily generated without re factoring data structures.

Splitting up tx_graph output in multiple files would be a solution:
tx.csv: tx_id, timestamp, height
tx_inputs: tx_id, src_addr, value, prev_tx_id
tx_outputs: tx_id, tgt_addr, value

solved by new tx output file structure


sepc: a case clause of swtich does not flow to the next clause

https://golang.org/test/switch.go
The official test works great.
However "switch case" shows strange result in the test below:
https://play.golang.org/p/mkDtpfYqhr

case statements in Go have an implicit break, they don't fall through automatically. Use the fallthrough keyword for that, or specify all valid values in a single case, separated by commas.

See http://golang.org/ref/spec#Switch_statements

Thanks a lot.


Expose host on Network

Hi,
May I ask if there is a way to pass --host IP when using the command npm run tauri dev? I have tried just appending the IP address to the end but received this instead:
error: unexpected argument '<IP_ADDRESS>' found

Usage: cargo.exe build [OPTIONS]

Thanks!

I don't think there is use of npm run command in this project? @rui-chen-1


zero-copy send doesn't have better performance

My test was running on two physical machines (20Gbps bonding NICs), kernel version 6.2.0-1.el7.elrepo.x86_64.
First I setup a tcp server on one machine, and then run these two commands on the other, to compare send_zc and send performance.
./example/send-zerocopy -n8 -s32768 -4 -t20 -D<IP_ADDRESS> -p9527 -z1 tcp
tx=1294016 (MB=40438), tx/s=64700 (MB/s=2021)
./example/send-zerocopy -n8 -s32768 -4 -t20 -D<IP_ADDRESS> -p9527 -z0 tcp
tx=1528384 (MB=46343), tx/s=76419 (MB/s=2317)
The send_zc is even worse ...

First we'd need to check if it really was zc using IORING_SEND_ZC_REPORT_USAGE.
Please also post perf profiles, that would be helpful.
perf record -g
perf report > output_file.txt

@isilence
After adding IORING_SEND_ZC_REPORT_USAGE , cqe->res is still 0, rather than IORING_NOTIF_USAGE_ZC_COPIED. So it looks like it was not copied.
perf.log

I did, and I can recall the results didn't vary too much.
Instead of the bandwidth, what I actually concerned is the CPU usage. The zerocopy version didn't drop CPU usage but increased. I used to run the epoll zerocopy in the same test machine (available since kernel 4.18), and it could reduce 50% CPU.

Could you share your test results?

That's what I wanted to ask, what is the CPU usage? I see lots of waiting in the logs, that hints that you might be under utilised, and comparing bandwidth in this case wouldn't make any sense. Try to pin it to a CPU, e.g. taskset -c 0 <rest of the command> and try the test again looking for CPU util.
With that being said, it's still interesting why it's lower. It may be latency, and e.g. additional scheduling effects from zc notifications. Let me cook up a patch for the example to try. Also, I'd rather omit -n8 and send more, it doesn't make much sense for TCP.

Another observation is that according to logs is that often it goes via the slow path (internal worker thread pool, aka io-wq), which is most probably due to sending too much and so clogging tx queues. Need to see if I can do sth about the test, but in the meanwhile, if I'm correct, if you do "-n1", it should mostly disappear.

Another observation is that according to logs is that often it goes via the slow path (internal worker thread pool, aka io-wq)

Just for my education, where do you see it?

Another observation is that according to logs is that often it goes via the slow path (internal worker thread pool, aka io-wq)

Just for my education, where do you see it?

In the @beef9999 's logs, look for io_wq, e.g. io_wq_submit_work

https://github.com/isilence/liburing/tree/sendzc-defer-taskrun
@beef9999, try this branch. It adds a new argument, pass "-d" to your test. It's not too likely to fix your problem, but I'd ask to run it and post profiles for copy and zerocopy runs and CPU utilisation.

case 1:
./examples/send-zerocopy -n1 -s32768 -4 -t20 -D<IP_ADDRESS> -p9527 -z0 -d tcp
tx=1616716 (MB=50363), tx/s=80835 (MB/s=2518)
CPU usage: 56%
copy.txt
case 2:
./examples/send-zerocopy -n1 -s32768 -4 -t20 -D<IP_ADDRESS> -p9527 -z1 -d tcp
tx=1494701 (MB=46709), tx/s=74735 (MB/s=2335)
CPU usage: 48%
zc.txt

I tried to reproduce and was getting mixed results resembling yours until I defaulted network configs and got 1630 vs 1720 MB/s in favour of zerocopy. Was are you using on the receiving side? It was msg_zerocopy for me and I had to not forget to kill SO_RCVBUF / SO_RCVLOWAT configuration out of it as it completely ruins results for me.

On the recv side, I was using a standard tcp socket on epoll. Didn't set any option except TCP_NODELAY.

On the recv side, I was using a standard tcp socket on epoll. Didn't set any option except TCP_NODELAY.

It seems it's configuration specific. I can try to repro it if you share how do you run the rx side with code if it's self-written.

1720 was zerocopy?

Right

Besides I can recall the current Linux kernel didn't support zerocopy receive until you have a NIC supports header-data splitting?

It just the name of the benchmark. Inside it's a normal recv throwing data away with MSG_TRUNC.

@isilence I found it was TCP_NODELAY that caused the performance drop.
Below is my test code. If I comment out the TCP_NODELAY line, I'll get the appropriate results like yours. The copy version is slightly higher, though.
#include <sys/socket.h>
#include <netinet/in.h>
#include <netinet/tcp.h>
#include <string.h>
#include <stdlib.h>
#include <unistd.h>
#include <pthread.h>

void* handler(void* args) {
    int connfd = (int) (unsigned long) args;
    char buff[512];
    while (1) {
        read(connfd, buff, sizeof(buff));
    }
    return NULL;
}

int main() {
    int fd = socket(AF_INET, SOCK_STREAM, 0);
    if (fd < 0)
        abort();

    struct sockaddr_in server_addr, client_addr;
    memset(&server_addr, 0, sizeof(server_addr));
    server_addr.sin_family = AF_INET;
    server_addr.sin_addr.s_addr = htonl(INADDR_ANY);
    server_addr.sin_port = htons(9527);

    if (bind(fd, (struct sockaddr*) &server_addr, sizeof(server_addr)) != 0)
        abort();

    if ((listen(fd, 1024)) != 0)
        abort();

    socklen_t len = sizeof(client_addr);
    while (1) {
        int connfd = accept(fd, (struct sockaddr*) &client_addr, &len);
        if (connfd < 0)
            abort();

        int val = 1;
        if (setsockopt(connfd, IPPROTO_TCP, TCP_NODELAY, &val, sizeof(val)) != 0)
            abort();

        pthread_t thread_id;
        pthread_create(&thread_id, NULL, handler, (void*) (unsigned long) connfd);
    }
}

gcc -g  -O3 -Wall -o tcp-server tcp-server.c -lpthread

./examples/send-zerocopy -n1 -s32768 -4 -t10 -D<IP_ADDRESS> -p9527 -z1 -d tcp
./examples/send-zerocopy -n1 -s32768 -4 -t10 -D<IP_ADDRESS> -p9527 -z0 -d tcp

Do you have any suggestion on TCP_NODELAY, because almost all of our network programs have enable this feature. We used to think it's benifitial.

My code:
io_uring poll + non_blocking fd + sendmsg(fd, &msg, MSG_ZEROCOPY)
20Gbps,  30% CPU
The liburing zc example:
13Gbps, 54% CPU

@beef9999, something doesn't stick with the results. You said you've been getting 16-18 Gbps before with io_uring before, what has changed? Let me also ask what is the bandwidth of your setup 2x20 Gbps?
There is one problem with the io_uring benchmark itself, namely the lack of any pacing / throttling, it just keeps pushing into it until stuck, which might be pushing requests to slow worker threads too often. There is no such thing when you poll for space in queues first as with epoll. Anyway, it still seems off, can you attach your poll version?

There might be two major differences between your env and mine. 1. I'm using kernel 6.2 by CentOS el7, and I assume yours is the community version? 2. My NICs have bonding.

I was testing upstream, 6.3-rc*

@beef9999, what happened with your post about TCP_NODELAY and getting zc more or less on par with the copy version?

@isilence

I think the bonding NICs is useful when handling multiple connections, for this test there is only one. So the max bandwidth is 20G.
I noticed that the latest example in master has been changed by adding IORING_SETUP_DEFER_TASKRUN | IORING_SETUP_SINGLE_ISSUER | IORING_SETUP_COOP_TASKRUN. I re-run the new zc example, now it could reach the 20G limit. And CPU util is less than normal tcp, looks good.
TCP_NODELAY did have negative impact, but very small. Let's forget it.

Looking at some stats, io_uring spends too much time scheduling because of some internal details, that's a CPU waster. It should be better when there is more load, but it's still a good spot to try and tune. Luckily, there was a few ideas floating around.
A curious experiment: if we add some sleeping before waiting for CQEs (in cases when we do sleep / wait, e.g. the CQ is empty and we have to enter the kernel), the sys% CPU usage reduces from 22% to ~10%. The waiting time is hand picked for the setup to not hurt perf, it's kind of the ideal scenario that we can expect.

@isilence One interesting thing I discovered during real work load tests is, if you just do send in the client and receive in the server, the zero copy send is not likely to surpass the libc send.
That’s because in a real scenario your send_zc should always proceed after the previous notify cqe has arrived.
The cqe notification is based on TCP ACK. Imagine you network round trip latency is 10 microseconds, so every send_zc has to wait for this period of time to start the next. But for the libc send, it just need to write to a buffer, and would immediately return to user space. So I can only observe by iftop that zc only has 4Gb bandwidth, while the libc send can reach 20Gb.
However, a more common case in networking scenario is send and receive, where you can easily observe the performance difference. Because the libc send now has a minimum 10 microseconds. The zero copy optimization starts to be effective.
In a word, zero copy is only supposed to set in a send-receive round trip.

One more question, will short write occur in io_uring send_zc ?  (requested to send n, but eventually sent less than n)

@isilence One interesting thing I discovered during real work load tests is, if you just do send in the client and receive in the server, the zero copy send is not likely to surpass the libc send.

If your CPU is under-utilised then that's so. However, if it's already 100% CPU, those extra cycles will go to throughput.

That’s because in a real scenario your send_zc should always proceed after the previous notify cqe has arrived.
The cqe notification is based on TCP ACK. Imagine you network round trip latency is 10 microseconds, so every send_zc has to wait for this period of time to start the next. But for the libc send, it just need to write to a buffer, and would immediately return to user space. So I can only observe by iftop that zc only has 4Gb bandwidth, while the libc send can reach 20Gb.
However, a more common case in networking scenario is send and receive in the client, where you can easily observe the performance difference. Because the libc version now has a minimum 10 microseconds. The zero copy optimization starts to be effective.
In a word, zero copy is only supposed to set in a send-receive round trip.

Well, no. If you're streaming data, you don't have to wait for the prev notification but can push more data using another buffer. And if you're concerned about memory consumption, in a copy mode the kernel will allocate that memory internally and keep it until it gets an ACK, which is less transparent.

One more question, will short write occur in io_uring send_zc ? (requested to send n, but eventually sent less than n)

For TCP, io_uring will try to hide a short send, i.e. retry internally, but it can fail. IOW, in theory can happen but should be rare


@template doesn't work with JSDoc 3.6

Input:
/**
 * @name foo
 * @constructor
 * @template T
 */

Result:
/**
 * @name foo
 * @constructor
 * @template T
 */
declare class foo {
}

Expected:
/**
 * @name foo
 * @constructor
 * @template T
 */
declare class foo<T> {
}

I don't know if other tags stopped working...

I haven't actually tried jsdoc 3.6 yet, but looks like they added support for closure compiler tags which means they won't show up in the "unknown tags" section anymore.

@englercj how much work is required to support jsdoc 3.6.x?

No idea, haven't looked. Feel free to give it a shot and submit a PR.


CLI Button comes back

Per community request, the CLI Button comes back.
Special thanks to @forseti.
Closes: https://github.com/stateful/vscode-runme/issues/1692

@sourishkrout I think this one can be a good option:

@forseti, Let me know what do you think.

Let's use play-circle please:


ThreadedEngine is buggy on GPU

reproducible by run example/mnist/mlp_gpu.py
but cpu works fine

fixed


 Just send data payload (not notification) with image field.
I noticed that when the data dictionnary contains a title field, this field is remove. Therefore  I renamed it data_title
On my phone, the app was crashing, I had to comment this line to make it work:
//notificationBuilder.setColor(getResources().getColor(accentID, null));

@alexislg2 why is title changed to data_title?

@robertarnesson Because as I said remoteMessage.getData().get("title") is always None

This PR is not compatible with iOS because of https://github.com/arnesson/cordova-plugin-firebase/issues/308
This is quite annoying...

@alexislg2 Looks great. Would it be hard to add the support for the notification image (not bigPicture just to replace the square image)
Also, I managed to make it work by sending my push notifications separately to my users. All my topics have an ios and android version. When I need to send the notification I send them to Android user with "data" only and to iOS users with "notification" only

closing for cleanup, please resubmit PR if changes are still desired


Usage in docker messes with host network

Since I didn't want to mess with my host system (and also had no empty raspi, I could use), I made a docker-container.
This works fine (I may PR it here, if someone is interested), but I had to set privileged and network_mode:host to get this working.
It seems to change routes on the host, since privileged and network_mode:host gives a lot of control to the container. After stopping the container I have some network-related issues (connection problems to other docker-containers on the same computer).
Only restart of host helps.
@kueblc - I've seen you're commenting about your branch create-ap to use in ubuntu/docker. What's the difference to this master? I've only seen it has 42 additional commits, but not quite sure what's the purpose of this branch, since this master also works for me on a ubuntu docker/ubuntu host combination besides this side effects.

create_ap is a third party script maintained by @oblique that makes it dead simple to launch an AP. In the create-ap branch I replaced the setup_ap script with a call to create_ap.
Older versions of tuya-convert were a little destructive when setting up an AP, and as I was having trouble getting it to work on my Ubuntu desktop I considered that outsourcing this task would make things easier.
Since #225 I've been able to correct most if not all of the issues, so I've ceased maintaining the create-ap branch. I would recommend trying the development branch if you haven't already.

Ok, I'll try the development branch this week, maybe I'll find the problem or perhaps it get's solved by this branch. I'll report then and close this issue.
Thanks for clarification.

Closing for now @Cyber1000 but feel free to reopen if you need to follow up

I've tried the newest branch and it seems to work, no destructive settings anymore! Just wanted to mention this, sorry for the late reply.

Great, thanks for following up!

Hello @Cyber1000,
do you mind sharing your approach using docker? I prefer the idea of docker over using a RPi every time I get some new devices :)
Thanks!

@moritzj29 No problem, it's a setup separated into Dockerfile (for building a docker-image locally) and docker-compose.yml (for running the container). You have to use it on linux-host (I used ubuntu, but shouldn't matter really if you take a well known linux distro).
Hope the readmes are clear (I've just written them, these repos were for personal use until now). Feel free to ask, if not.
Building docker-image: https://github.com/Cyber1000/Docker-Images-Tuya
Using the container with docker-compose: https://github.com/Cyber1000/Docker-Services-Tuya
Perhaps I'll make a PR somewhere in the future to include the Dockerfile in this project, but there are some minor (mostly cosmetic) points I would change.

@Cyber1000 thanks for your work. I little edited your work for rpi4
https://github.com/Daviteusz/Docker-Images-Tuya
And working very good.

@Daviteusz  You're welcome :-)
Some points:

You have forked from the master of my repo, which is not up-to-date (and will be uptodate only now and then) and was a first approach, you may fork from the development branch (and somewhere in the future from the master branch) of this repo: https://github.com/ct-Open-Source/tuya-convert/tree/development
If you do a RUN apt-get update and separately do a RUN apt-get install ... the RUN apt-get update will only be run once on your computer (as a cached layer by docker) and so you won't get fresh installs on subsequent docker-builds. See more at https://runnable.com/blog/9-common-dockerfile-mistakes (point 1)
why I choose phusion/baseimage (actually a adjusted ubuntu 16.04): ubuntu isn't made for living inside docker and some things like init-process don't work fully reliable, see https://hub.docker.com/r/phusion/baseimage. But this is more a problem of docker-containers which are started and run for days and weeks and not a problem with this short-executing-scripts, so you should be fine.

I assume the phusion/baseimage:0.11 part was the tricky part why it didn't work for rpi4?


Content Suggestion: BitcoinersBest

Link to Content: https://bitcoiners.best/
Briefly Describe Content: Bitcoin Content Ranking
Suggested Section: Spend Bitcoin

Currently Down - Will check again

Site still down. Twitter inactive since March.
Closing.


Wrapper for Crawly.Spider behaviour

Extend Crawly.Spider with spider_closed callback
Use macro to simplify the Crawly.Spider definitions

I agree with the use Crawly.Spider macro, I think it would simplify boilerplate a lot.
I don't agree with the use of the spider_closed/1 callback. This implies that there will be a callback for every spider-related event. I feel that this will give rise to a lot of boilerplate, and a lot of copy-pasting of code. There is also no access to the engine/spider state.
As I mentioned in the issue, I lean towards simply passing a function for the engine to call  through the settings. It is very extensible and already allows for spider-level overrides.
Some benefits from this approach:

The callback is fired asynchronously, which would be beneficial for other types of events
can define a default callback, override on a per-spider basis as necessary
can separate this callback from spider code (so cleaner spider code)
less maintenance (less callbacks on the spider)
easier to understand (less callbacks that may behave differently, this one is standardized to receive engine state and spider state)
more extensible (the task firing can be abstracted to a util function, and adding support for other events would just be a few lines of code)

For example:
# in config.exs
config :crawly,
  on_spider_close: &MyApp.send_email_notification/2

# in MyApp.MySpider
def override_settings() do
    [on_spider_close: &MyApp.handle_update_spider_dashboard/2 ]
end

# in Engine.close_spider
def stop_spider(spider_name, reason \\ :ignore) do
  callback = Crawly.Utils.get_settings(spider_name, :on_spider_close)

  # start the callback that we don't care about
   if callback do
     Supervisor.start_link([
        {Task, fn -> callback.(engine_state, spider_state) end}
      ], strategy: :one_for_one)

   end

  # close the spider
  GenServer.call(__MODULE__, {:stop_spider, spider_name})
end

don't agree with the use of the spider_closed/1 callback. This implies that there will be a callback for every spider-related event. I feel that this will give rise to a lot of boilerplate, and a lot of copy-pasting of code. There is also no access to the engine/spider state.
As I mentioned in the issue, I lean towards simply passing a function for the engine to call through the settings. It is very extensible and already allows for spider-level overrides.

I understand your concern (I was playing with both ways of declaring things before submitting the PR), and at this point, my arguments are the following.
Custom settings way of defining callbacks have the following drawbacks

custom_settings - is a KW list which allows overriding settings. Semantically spider callbacks are not settings. Even more, there is no global representation of the callbacks.
if we define for example spider_closed callback via settings, it would mean that our settings are more complex, now it's not only simple overrides of globally defined settings but also something on the top of it.
behavior itself will not be that clear: As well as callbacks are not defined by behavior, we would literally have to depend on conventions, which could be quite error-prone, when people will do typos and will not understand why something is not being called, and there will not be hints from the compiler.
finally, the Crawly internal code could be more simple. We would not have to do function_exported?/3 all the time. We can safely call something, expecting it to be defined default with the help of using macro.

As far as I see the only benefit of custom_settings based approach is the fact that all spiders written for older versions of Crawly can be easily migrated without a switch to using macro.

Some benefits from this approach:

The callback is fired asynchronously, which would be beneficial for other types of events
can define a default callback, override on a per-spider basis as necessary

I think this can be easily achieved with the callback-based approach. We can force the macro to generate a function that will read the config by default.

can separate this callback from spider code (so cleaner spider code)

Same as above, at this point more strict interface seems to be quite beneficial

less maintenance (less callbacks on the spider)

Callbacks are not executed in the context of the spider. So technically it's just a place where the code is stored.

more extensible (the task firing can be abstracted to a util function, and adding support for other events would just be a few lines of code)

We still can do it. E.g. the global setting might call a util function similarly to what you're suggesting.
Stating all the arguments above I would still prefer to go with the callback-based approach

I think this can be easily achieved with the callback-based approach. We can force the macro to generate a function that will read the config by default

But wouldn't this be going back one full circle to defining the callback through settings?
I agree that the callback isn't settings. But neither is it spider code. It shouldn't be living in the spider as well. These type of event-triggered callbacks are side-effects and are not related to data-parsing, which is the context of a spider module.
From a user story perspective:

As a dev, I want to do something when this spider ends -- spider specific
As a dev, I want to do something when any of my spider ends -- not spider specific
As a dev, I want to do something when all my spiders end. -- not spider specific

The settings-approach allows for addressing of scenarios 1,2,3. While the macro callback approach only addresses scenario 1.
Relying on the macro to define the callbacks in advance also makes it a breaking change, and requires internal code to check if the callback is defined anyway.
Why have 2 different approaches to configuring a Spider when there already is a unified approach to configure it? In the end, if there's going to be a default setting on the config, it can be customized with override_settings and makes the callback moot.

I feel that the KW approach forces the dev to define the callback outside of the spider scope, which would be more appropriate for scenarios 2 and 3.

I also think the typo and compiler concerns can be rectified through debug logging.
I think the crux of the issue here is:

where should the callback code be defined, in spider or elsewhere

if in spider, then macro callback is an ok approach
if not in spider, then define elsewhere and point to it in settings.

How is this type of configuration (event callbacks) going to be extended in the future.

macro approach means 1 callback per event
KW setting approach means one new setting per event

How to specify a default (i.e. global) callback?

But wouldn't this be going back one full circle to defining the callback through settings?
Maybe not, if the settings are clearly defined and the callbacks code is autogenerated with a macro

I agree that the callback isn't settings. But neither is it spider code. It shouldn't be living in the
spider as well. These type of event-triggered callbacks are side-effects and are not related to data- parsing, which is the context of a spider module.

Mmm.. Yes, you're right. Maybe they should not be a part of the spider at all. Let me ask for an advise from Scrapy core team members.

Relying on the macro to define the callbacks in advance also makes it a breaking change,
Yes, it's a breaking change.

and requires internal code to check if the callback is defined anyway.
well, this is going to be handled by the compiler, who will return a warning stating that you have not defined required callbacks.

Why have 2 different approaches to configuring a Spider when there already is a unified approach to configure it? In the end, if there's going to be a default setting on the config, it can be customized with override_settings and makes the callback moot.

Well, but from the other side, I see some similarity between parse_item/1 and spider_closed/1 or item_scraped/2 [item scraped would be even more specific to a given spider, e.g. it would allow to make some very specific post-processings]

@Ziinc Actually after some conversations, I have decided to switch to the idea of the settings_based approach.
Please have another glance on the PR.


Implement extension function CartesianProduct

From set theory: the Cartesian product of two sets A and B, denoted A × B, is the set of all ordered pairs (a, b) where a is in A and b is in B.

Do we need an implementation for more than 2 dimensions?


Vertical-navbar-modified

fixed #886
I modified the Vertical navbar links as you told
as reference :https://girlscriptboilerplate.smaranjitghose.com/
and fixed the merge conflicts
and added level3 & partially approved
Can you review it please sir? @sameersrivastava13

Your changes:

Reference:

Can you tell me please How Can I fix the merge conflict @smaranjitghose

Your changes:

Reference:

sorry It happened some error

I already do this but I can't solve the fixed merge conflict @smaranjitghose

I already do this but I can't solve the fixed merge conflict @smaranjitghose

The texts should be centre aligned w.r.t the screen (top and bottom). There is too much space at the top
Increase the size of the text

Can you tell me please How Can I fix the merge conflict @smaranjitghose

Pull the changes from the upstream repo(this one)
Integrate them into your feature branch
Add/modify your changes accordingly
Make a Squash Commit
Update the PR

DO NOT MERGE this PR yet
see my review at PR #900.
same applied to this one


add op to tf_op_files.txt

add op to tensorflow/contrib/makefile/tf_op_files.txt to fix problem of op not registered
download farmhash and highwayhash to fix *.h and *.cc not found problem

Nagging Assignee @akshaym: It has been 15 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @akshaym: It has been 30 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @akshaym: It has been 45 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @akshaym: It has been 60 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @akshaym: It has been 75 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @akshaym: It has been 90 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Sorry for the slow review response! We're beginning to deprecate the makefile build of TensorFlow in favor of TF Lite, but this looks like a reasonable change to include even so, thanks.

@petewarden Have fixed conflict. Please approve it again.


Blog about this?

I probably have enough material, could be good for visibility?

+1, it would be a good idea to talk about existing streams and how new bob streams works.


Docs: Added cli for Windows PowerShell

Thanks for adding Windows support! 🎉🍻
In Windows Powershell (the default terminal for VSCode), the @ character is reserved, and the current command will only run npm init.

wouldn't yarn create "@observablehq" work everywhere? (I'd prefer a single generic line than listing cases.)

@Fil fixed.


Support for enum types

Current options binding does not support enums.
(note: for the unit tests, I picked a random enum from the System namespace.  I'm not actually suggesting that people might want to use UriKind in their configuration files.  Although, I guess you never know!)

Hi @dtkujawski, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft Open Technologies, Inc. and real humans are currently evaluating your PR.
TTYL, MSOTBOT;

@dtkujawski can you rebase and test on the latest code? We recently changed this file and I want to ensure your changes still work.

Eilon - had to make a minor modification for it to work with latest.  Should be good to go now.

Can I ask a noob-question?  Is there a resource you could point me to which explains a good way to link my custom project/solution to use versions of these assemblies that I build locally?  Currently I am just using the unit tests to verify the code, but I'd like to make use of these changes in my custom solution until they get merged into the next CTP.

PS: Looks like the CI failed, but it appears due to a configuration issue with CI possibly (permission failure)

The Travis CI failed due to the shell script not having execute permissions. @davidfowl fixing.

The change looks good - nice test too. @HaoK do you want to take a quick look?
BTW I don't like that exceptions are ignored here, so I filed #55 .

Nice! :shipit:

@dtkujawski did you change the persmissions on the build.sh file? Looks like you did.

@davidfowl  ahh weird - didn't realize that happened.  I've pushed a commit that has the execute permission re-instated.  Just waiting for the Appveyor process to grab it.

@dtkujawski merged, thanks!


Time zones / Time references

I think we should make sure, that time zones, other time references are used correctly.
We can have time stamps given as UTC, really related to a time zone, local time (without DST), mean solar time, true solar time, ...? This is an everyday problem from my experience, so we should be able to handle all of these formats at least in the future.
For now it could be ok to define, that all times should be given as UTC and leave all time conversion issue to the user.
As pandas has support for Julian dates since 0.14 (this is the pull request). I was thinking about creating a pull request to implement to_solar_time in pandas. However this is not easy to implement and I am not sure, if they accept it. But this way all time conversion would be in pandas an we could implement thinks based on pandas.

I'm all for being helpful with timezones. This was my motivation for adding a tz attribute to the Location class. The solarposition module (with some functions in tools) has an attempt at using tz knowledge from either the DatetimeIndex or the Location object. Do these fit into your scope or do you want to do something different? I did think that it would be nice if the Location constructor could use a web service to determine a IANA timezone from a lat/lon. (Or maybe even a lat/lon/tz from a city/state/country search, but that's another topic.)
Guaranteeing that time zones are handled correctly is hard unless you're very restrictive about it. My inclination is to leave the vast majority of the work to pandas. All localized times in pandas are stored as utc internally, so we can and should take advantage of that (as the description above does).
We could require that all times be localized, or we could throw warnings whenever we detect that people are using non-localized times.
Concerning solar time... I just rely on the zenith and azimuth calculations for a given lat/lon. Is there an application for solar time other than for the actual calculation of those quantities of interest? I don't know how pandas would reasonably incorporate something that requires a specific lat/lon. Maybe we're talking about two different quantities? I think of solar time as the local time shifted to make the minimum zenith occur at 12:00 noon.

I mean true or apparent solar time, so I think we talk about the same quantities. It is often useful to plot some quantities against this time e.g. to detect the azimuth angle of a system or to detect misalignments between irradiance sensor and modules, ...
So I think it would be useful.
I would also like to rely on pandas for time conversion, as it is the best python implementation I am aware of. However I may be difficult to detect the exact format that a user is assigning to a function.
So perhaps we should extend the tz (or whatever it's name should be) to ecept not only real time zone names, but also something like utc+8 for a time format without daylight saving time, tst for true solar time, mst for mean solar time ...
As a default I think utc would be better than a localized time.

Agreed on using pandas and default UTC, and I think one critical component
of having a successful time implementation for others will be a tutorial
covering various conversions and manipulations.
I am still trying to wrap my head around how true solar time and mean solar
time interact with data collected from a system, but I will get there.
On Sun, Apr 5, 2015 at 11:51 PM, bmu<EMAIL_ADDRESS>wrote:

I mean true or apparent solar time
http://en.wikipedia.org/wiki/Solar_time, so I think we talk about the
same quantities. It is often useful to plot some quantities against this
time e.g. to detect the azimuth angle of a system or to detect
misalignments between irradiance sensor and modules, ...
So I think it would be useful.
I would also like to rely on pandas for time conversion, as it is the best
python implementation I am aware of. However I may be difficult to detect
the exact format that a user is assigning to a function.
So perhaps we should extend the tz (or whatever it's name should be) to
ecept not only real time zone names, but also something like utc+8 for a
time format without daylight saving time, tst for true solar time, mst
for mean solar time ...
As a default I think utc would be better than a localized time.
—
Reply to this email directly or view it on GitHub
https://github.com/pvlib/pvlib-python/issues/47#issuecomment-89947982.

That sounds like a good use case. solarposition.ephemeris does return solar time, although I did not test this output in my recent PR. Pyephem has a sidereal_time method, so we can add solar time to solarposition.pyephem also. Hopefully we can extract this from the other SPA functions as well.

However I may be difficult to detect the exact format that a user is assigning to a function.

I'm not sure what you mean by this. My thought is that you can always do one of these:

Use the timezone specified on a DatetimeIndex or a Location. (Possibly raise an error if they do not agree.)
Assume UTC. (Possibly raise a warning that we're assuming UTC.)

I don't think there can be any ambiguity because the DatetimeIndex and Location constructors raise errors if the user inputs an timezone that pytz doesn't know about. pytz.FixedOffset timezones can do something like your utc+8 suggestion:
pd.DatetimeIndex(['2015-1-1T00']).tz_localize(pytz.FixedOffset(120))

<class 'pandas.tseries.index.DatetimeIndex'>
[2015-01-01 00:00:00+02:00]
Length: 1, Freq: None, Timezone: pytz.FixedOffset(120)

We could consider making a rule that all timezones must always be specified (even if it's UTC).

tst for true solar time, mst for mean solar time

Interesting idea; a correct and consistent implementation sounds hard. (mst is Mountain Standard Time in the US.)
In any case, I will improve the Location docstring and make a tutorial. We could also make a page on the rtd docs just for timezones. I will also change the Location default tz to be UTC.

I think, we misunderstand each other a little bit until now; my English may be the reason ;-)
My use cases include up to now:

irradiance data provided by a national weather service using true solar time as timestamp
data from our own monitoring system using local time (without daylight saving)
data from utilities most often localized (including daylight saving)
data from meteonorm, local time (I think)
data from GeoModel, UTC
"SatelLight" data, local time

So I need

to convert any of these to any defined standard, using tools provided by pvlib  or
a keyword that lets our functions know, what kind of time stamp is used and the conversion to this standard is performed within the function (should be utc in any case I think)

Hope this is understandable ;-)
@jforbess
Data collected from a system is usually stored with a local time stamp, from my experience.
However, sometimes I do not now the azimuth of the system or argue that something is wrong with the alignment of the irradiance sensor.
If you plot your measurements, lets say power and irradiance against local time you won't see a clear peak at noon (if the system is oriented towards equator), but have a scatter due to the equation of time (about +- 15 minutes). If you plot it against true solar time you have a clear peak for both quantities at noon. If not, there is something from either with the alignment of the irradiance sensor or the azimuth of the system is not oriented towards equator.
This is only one use case, there are other examples were true solar time is useful.

Yes, those cases are generally what I would assume, though in my experience
irradiance data from a national weather service is also in local time, not
true solar time. I am not sure I ever see anything in true solar time
except outputs from very specialized models, like the example you cited,
and in that example, I might compare daily peaks to daily model peaks in
local time, which would look for alignment at 12:35 or whenever the peak is
expected in local time.
From my past experience, using UTC internally usually ends up resulting in
the fewest conversions, since there will always be some. :)
On Mon, Apr 6, 2015 at 10:45 AM, bmu<EMAIL_ADDRESS>wrote:

I think, we misunderstand each other a little bit until now; my English
may be the reason ;-)
My use cases include up to now:

irradiance data provided by a national weather service using true
solar time as timestamp
data from our own monitoring system using local time (without
daylight saving)
data from utilities most often localized (including daylight saving)
data from meteonorm, local time (I think)
data from GeoModel, UTC
"SatelLight" data, local time

So I need

to convert any of these to any defined standard, using tools
provided by pvlib or
a keyword that lets our functions know, what kind of time stamp is
used and the conversion to this standard is performed within the function
(should be utc in any case I think)

Hope this is understandable ;-)
@jforbess https://github.com/jforbess
Data collected from a system is usually stored with a local time stamp,
from my experience.
However, sometimes I do not now the azimuth of the system or argue that
something is wrong with the alignment of the irradiance sensor.
If you plot your measurements, lets say power and irradiance against local
time you won't see a clear peak at noon (if the system is oriented towards
equator), but have a scatter due to the equation of time (about +- 15
minutes). If you plot it against true solar time you have a clear peak for
both quantities at noon. If not, there is something from either with the
alignment of the irradiance sensor or the azimuth of the system is not
oriented towards equator.
This is only one use case, there are other examples were true solar time
is useful.
—
Reply to this email directly or view it on GitHub
https://github.com/pvlib/pvlib-python/issues/47#issuecomment-90169522.

These use cases are helpful and cover a pretty broad range. I think that properly used IANA timezones (the pytz/pandas convention) can cover all except for solar time. For example, here in the US we have US/Mountain (DST aware) and MST (no-DST):
pd.DatetimeIndex(['2015-4-1T00']).tz_localize('US/Mountain')

<class 'pandas.tseries.index.DatetimeIndex'>
[2015-04-01 00:00:00-06:00]
Length: 1, Freq: None, Timezone: US/Mountain

pd.DatetimeIndex(['2015-4-1T00']).tz_localize('MST')

<class 'pandas.tseries.index.DatetimeIndex'>
[2015-04-01 00:00:00-07:00]
Length: 1, Freq: None, Timezone: MST

Note the difference in the UTC offset between the two.
So long as I specify times consistent with the timezone, pandas will use the same integer to represent them:
# US/Mountain
pd.DatetimeIndex(['2015-4-1T01']).tz_localize('US/Mountain').astype(int)

array([1427871600000000000])

# MST
pd.DatetimeIndex(['2015-4-1T00']).tz_localize('MST').astype(int)

array([1427871600000000000])

# UTC
pd.DatetimeIndex(['2015-4-1T07']).tz_localize('UTC').astype(int)

array([1427871600000000000])

# No specification
pd.DatetimeIndex(['2015-4-1T07']).astype(int)

array([1427871600000000000])

So I think we already have all of the tools we need, and the Location objects and the solarposition module already make use of these tools.
On solar time... maybe I see part of the remaining problem now. We've been talking about a way to go from a UTC-based timestamp to solar time (e.g. solarposition.ephemeris), but you want to be able to do the reverse. That seems harder. Could be doable with interpolation. Maybe @alorenzo175 knows how to do it exactly.

Ok, I was aware of the pandas time conversion / localization, but not the non-DST ones. I agree, that in this case most of the tools are available. For the conversion from true solar time to UTC one needs the time difference of mean solar time to utc (depending on longitude) and the equation of time, should also be included in the solar position algorithms.
What about the handling of tz-naive timestamps? Do I have to localize before up to now?

@jforbess: just ask the German weather service ;-)
the other comment: you won't have a peak at 12:35 if you plot one year data against local time. the peak shifts from 12:20 to 12:50 due to equation of time. and i you want to detect small sensor missalignments

There are other use cases (see e.g. [this paper][http://www.researchgate.net/publication/259400149_Long_term_satellite_hourly_daily_and_monthly_global_beam_and_diffuse_irradiance_validation._Interannual_variability_analysis), section 5.1.).
However, I'm not sure if it should be the first priority, as you seem to see no need for true solar time, and maybe most of the users also do not need it.

The pandas integer representation of a tz-naive timestamp is the same as that for a UTC timestamp (see above). Is that what you meant?
You've convinced me that including solar time in the solarposition outputs is high priority, but the converter from solar time to UTC would be lower on my priority list.

Yes, I'm not saying that true solar time isn't a key concept, I am just
saying that it's a lower priority to be able to convert between it and UTC.
Though I suspect that the large German operations performance community
would disagree, given @bmu's insight regarding their dataset.
On Mon, Apr 6, 2015 at 12:03 PM, Will Holmgren<EMAIL_ADDRESS>wrote:

The pandas integer representation of a tz-naive timestamp is the same as
that for a UTC timestamp (see above). Is that what you meant?
You've convinced me that including solar time in the solarposition
outputs is high priority, but the converter from solar time to UTC would be
lower on my priority list.
—
Reply to this email directly or view it on GitHub
https://github.com/pvlib/pvlib-python/issues/47#issuecomment-90199601.

Ok, I'm fine with a lower priority for the reverse calculation (not sure about "the large German operations performance community", though)

@wholmgren: I had a look on the code (especially tools.localize_to_utc) and now it is clearer what happens until. Should have done this before, sorry.
But I think something in the documentation on this topic would be useful, as not all users will be aware of the time zone handling.

Just a reminder to myself and others as to the huge install base outside my
experience, and you know, the largest installed base in the world.
On Mon, Apr 6, 2015 at 12:18 PM, bmu<EMAIL_ADDRESS>wrote:

Ok, I'm fine with a lower priority for the reverse calculation (not sure
about "the large German operations performance community", though)
—
Reply to this email directly or view it on GitHub
https://github.com/pvlib/pvlib-python/issues/47#issuecomment-90204213.

After some sleep, I see my initial confusion: From my point of view, the time zone is related to the data, not to the location. Maybe it is good to have information on the (legal) time zone of a location, but this is not necessarily an indicator for the time stamp used in e.g. measurement files (and I don't know, if this is clear for a user in general).
That's why I was asking for a time zone keyword e.g. for the solar position functions. Maybe this keyword could default to None or infer or ... (in this case it must be a tz-aware time index). If the time index is tz-naive, the user can provide the time reference.
Maybe we could also use the time zone of the location class, but than it should be clearer that this should be the time zone, that is used for the time stamps.

My thought is to go in the other direction. Make the solar position methods only accept tz localized times, raise an error with naive times, and ignore the location object's tz attribute. This makes it so that there is only one way to do it and the user must be very explicit about it. If you have data, then it was recorded with a specific time convention (UTC, Europe/Berlin, US/Arizona) and I think the very first thing you should do when you import that data is to use tz_localize. As soon as you tz_localize, pandas starts treating it as UTC under the hood, you can convert it to whatever viewing representation you want, and there can be no mistakes.

I think this could be right, but I didn't used to do it this way. Time zone conversion was complicated before pandas, should be possible today for a user.

I just discovered that pandas doesn't seem to behave well in one situation: I have data from PVsyst (no DST) that I am trying to load into pvlib to compare to a pvlib model. I am trying to align the timestamps, but pandas doesn't seem capable of localizing timestamps without applying DST. (I'd like to just specify UTC-5, instead of 'US/Eastern'.) I asked a question about this on [stackexchange] (https://stackoverflow.com/questions/30179491/does-pandas-tz-localize-allow-me-to-specify-a-timezone-without-dst) because it seems to be more of a pandas issue than pvlib issue, but perhaps people here have solved this problem already? If not, it's something that we can't rely on pandas for, though perhaps support is coming in 0.17.

I think you want to localize with 'EST' or pytz.FixedOffset(-5*60).
I suppose I should finish writing the pvlib timezone tutorial.

I checked 'EST', and it still applied the UTC-4 to the periods between March and November, but the pytz.FixedOffset worked great. I had something in mind like that, but couldn't quite figure out how pytz and tz_localize interacted. Thanks!

@bmu @jforbess I reread this thread and I'm not sure what, if anything, is needed to close this issue. Can we resolve it with better documentation or do we need to change the code?

I think there were two potential actions:

Require timestamped data to be localized. I don't know that we agreed
whether this was a good requirement or not. I view it as moderately
positive, because it will force all handling of timezones to be clearer.
But a potential drawback is when I somehow find myself using a Central
timezone for data in an Eastern location because of how the data was
captured originally. (Probably because it wasn't clear whether the data was
captured as interval beginning or interval ending, to use PVsyst's
nomenclature.)

Provide a mapping to true solar time. I believe this is a desirable
feature, but not likely to be part of the 0.2 release.

Finally, I do think that better documentation can cover item 1 if others
don't prefer requiring localization.
On Sun, Jun 21, 2015 at 12:36 PM, Will Holmgren<EMAIL_ADDRESS>wrote:

@bmu https://github.com/bmu @jforbess https://github.com/jforbess I
reread this thread and I'm not sure what, if anything, is needed to close
this issue. Can we resolve it with better documentation or do we need to
change the code?
—
Reply to this email directly or view it on GitHub
https://github.com/pvlib/pvlib-python/issues/47#issuecomment-113933939.

I agree with @jforbess in both points. But I think we can shift both of them to a later release.

Ok, thanks for the clarification. I am going to mark this issue as 0.3 and think about it again after this release is out.

6 months later... the solarposition.py module in PR #93 now requires that timestamped data be localized or it will be assumed to be UTC time. See the diff.

I think that the new code and the new documentation can close this issue. Here's the new proposed documentation:
http://wholmgren-pvlib-python-new.readthedocs.org/en/contributing/timetimezones.html
Please provide comments in #135, if you have them.
Assuming no objections, I will close this when #135 is merged. A new issue could be created for adding true solar time to more functions, if desired.

Just an idea:
We could open a milestone for the Santa Clara pvlib sprint in May and move such issues to this milestone. I will be there, too.
Am 15. März 2016 20:55:40 MEZ, schrieb Will Holmgren<EMAIL_ADDRESS>
I think that the new code and the new documentation can close this
issue. Here's the new proposed documentation:
http://wholmgren-pvlib-python-new.readthedocs.org/en/contributing/timetimezones.html
Please provide comments in #135, if you have them.
Assuming no objections, I will close this when #135 is merged. A new
issue could be created for adding true solar time to more functions, if
desired.

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/pvlib/pvlib-python/issues/47#issuecomment-196996019

--
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

We could open a milestone for the Santa Clara pvlib sprint in May and move such issues to this >milestone. I will be there, too.

Regarding Santa Clara pvlib sprint:
I received an invitation. Thanks for that!
But will not be able to attend.
If there is a possibility to participate on discussions and sprints remotely I would be happy to do so.

@bmu a Santa Clara milestone is good idea and it's great to hear that you'll be able to attend. Did you rsvp to Josh Stein? I did not see your name on a recent list of attendees.
@dacoex and others: We don't yet know exactly what the agenda will be, but I expect that there will be a way to contribute remotely. We'll still be using GitHub, of course.
I'll make a milestone and a new issue for further discussion.


Add FullScreen component

It can be powered by useFullScreen from @vexip-ui/mixins (common/mixins/src/full-screen.ts)


⚠ Bofrost.fr has degraded performance

In 018dc59, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 2067 ms

Resolved: Bofrost.fr performance has improved in bec5e67.


[CSL-198] Improve error handling in onNewSlot worker

@gromak
Currently we catch SomeException from action passed as argument and don't catch any other exceptions. Probably it's not the best solution.

@alex.well-typed
The description has become stale but I think this ticket remains very important.
onNewSlot will catch all exceptions from the action passed in, and will never rethrow them. That strikes me as a bad idea. If such a worker crashes, the program should crash, because presumably that worker is doing something that needs to be done. If an exception isn't such a big deal, then the worker definition itself could catch it and squelch it.


Local variables in config file.

We allow
%save my_config.yml -f
hosts:
  host_31:
    R_version: 3.1
    task_template: |
      module load R/{R_version}
      {command}
  host_33:
    based_on: hosts.host_31
    R_version: 3.3

because R_version will be expanded for task_template.
We however does not allow
sos run -q host_31 R_version=3.3

because the templates are pre-expanded so task_template is
module load R/3.1
 {command}

not
module load R/{R_version}
{command}

when the template is used.
It might be easier to allow the later usage and make R_version=3.1 a default value for R_version.
The technical difficulty is that if we do not pre-expand R_version, we will need to keep it when we expand task_template, but currently we do not  have access to this dictionary when we expand task_template.

I am uncomfortable for the existing behavior also because if users define walltime in a local configuration file, then all task_template etc would be affected, actually pre-expanded and invalidate task: walltime=.

The proposed behavior is reasonable and is what we would expect now that we have #1324. It does sound like expanding the template needs to be postponed.

This is implemented, but only for task_template and workflow_template because it is too much trouble to enforce this for all values in config. However, currently only task_template and workflow_template accept any user configuration so this should be good enough and the "inconsistency" in implementation should not matter.

Documented at https://vatlab.github.io/sos-docs/doc/user_guide/config_files.html#String-interpolation


README Missing Instructions

Trying use this package, I was having a number of issues with getting the backgrounded start to work. Looks like there were some useful comments recently removed from the README. Any reason for that? On iOS adding this back in fixed it:
#import "RNQuickActionManager.h"

...

- (void)application:(UIApplication *)application performActionForShortcutItem:(UIApplicationShortcutItem *)shortcutItem completionHandler:(void (^)(BOOL succeeded)) completionHandler {
  [RNQuickActionManager onQuickActionPress:shortcutItem completionHandler:completionHandler];
}

Awesome, thank you! Really appreciate the library as well! 👏


Add linting support for '.tar.gz' tarballs for helm charts

What this PR does / why we need it:
This PR adds support to lint packaged helm charts with extension .tar.gz.
Special notes for your reviewer:
'closes #6535'
If applicable:

[ ] this PR contains documentation
[x] this PR contains unit tests
[x] this PR has been tested for backwards compatibility

Thanks @KamalashreeNagaraj. At this time we are only working on bugfixes and regressions from Helm 2 for the Helm 3.0.0 release, so I've marked this as a candidate for the 3.1.0 release.

Sure. What implication will this have on the timelines? By when can I expect this PR to be under review?

We just discussed in the public dev call that we are shooting for a 3.0.0 release on October 31st. We probably will be heads down until then

Apologies for the automatic closure. We just switched the dev-v3 branch to master, and the old master branch is now dev-v2. Feel free to re-open a new PR with this change. Thanks again and sorry for the hassle!

So I should raise the new PR to the master branch?

@KamalashreeNagaraj Yes

Sure. Will do it 👍 The same issue id #6535 applies right?


Revert "update syncset to use secretRefence"

This reverts commit 919be0510ac1b1d5e46b9a23ae8b0104d714121d.
I got error when testing:

secrets "haowang-test-primary-cert-bundle-secret" is forbidden: cannot set blockOwnerDeletion in this case because cannot find RESTMapping for APIVersion certman.managed.openshift.io/v1alpha1 Kind CertificateRequest: no matches for kind "CertificateRequest" in version "certman.managed.openshift.io/v1alpha1"" syncsetinstance=uhc-staging-18bj1mflc7uemp0lvler2ggv5ln9bu9t/haowang-test-haowang-test-clusteringress-syncset

this seems because the target cluster didn't have teh CertificateRequest installed

/test unit

I think your owner ref workaround looks good, will close this one for now.


fix: get soil data

CI still failing after the bugfix on weather data provider.
Now if is on get soil data

@chrichri17 FYI
now it is fixed https://github.com/akouete-kpakpo/nevergrad/runs/7732128399?check_suite_focus=true


Size troubles

I'm trying to run this on a project with the following prompt:
Upgrade the Rails version to <IP_ADDRESS> following known migration guides to upgrade a Rails project from Rails 6 to Rails 7. Ensure that `bundle exec rspec` still passes

I've tried to trim down my files in src_include as much as possible to fit within the default limits but when I try a prompt I see:
reqJson {
  model: 'gpt-4',
  temperature: 0,
  total_tokens: 4050,
  max_tokens: 29905,
  top_p: 1,
  frequency_penalty: 0,
  presence_penalty: 0,
  rawApi: false,
  messages: [
    {
      role: 'system',
      content: "You are an assistant, who can only reply in JSON object, reply with a yes (in a param named 'reply') if you understand"
    },
    { role: 'assistant', content: '{"reply":"yes"}' },
    {
      role: 'user',
      content: '[object Object]\n' +
        '[object Object]\n' +
        '[object Object]\n' +
        '[object Object]\n' +
        '[object Object]'
    }
  ]
}
getCompletion API error {
  message: "This model's maximum context length is 8192 tokens. However, you requested 29973 tokens (68 in the messages, 29905 in the completion). Please reduce the length of the messages or completion.",
  type: 'invalid_request_error',
  param: 'messages',
  code: 'context_length_exceeded'
}

I'm not sure how to debug further here.

Also, aside from the actual error, I feel like there's a good opportunity for the AI here. If ai-smol-dev fed my prompt to the AI and tried to figure out what to do next, it would probably realize it didn't need all my files yet until much later.
If I were to give this task to a junior developer, the ONLY file they would initially need is the Gemfile. They'd go in, change the version number of rails, and then run bundle update rails. The output, assuming there were problems, would provide them with clues on what to do next without ever needing to open another file. It's very likely they'd be able to resolve any conflicts here without opening or reading any other files. Once that step was complete, they'd run bundle exec rspec to run the tests. They'd read the bottom of the error output to determine what to do next. At that point they'd see stack traces referencing file numbers they may want to read. A reasonable strategy would then be to run the first failing spec by itself, take the entire output, and feed the output and the content of the files from the stack trace to the model. Until then, it wouldn't have needed the content of any other files but Gemfile.

Thats wierd that you are seeing [Object Object], sounds like there is a bug somewhere
If you are having large projects, strongly suggest applying for anthropic claude 100k access. As that generally resolve most size sises

@glennfu I ran into something similar but I tried increasing the file size in the config and that worked for me
  "limits": {
    "FILE_LIST":10000
  },

@shannonlal I had actually done the same but in an effort to narrow down the true problem I excluded more files so that I wouldn't go over the default file list limit.

Thats wierd that you are seeing [Object Object], sounds like there is a bug somewhere
If you are having large projects, strongly suggest applying for anthropic claude 100k access. As that generally resolve most size sises

Oh also I applied for Claude what feels like a long time ago, but still haven't gotten access.

@PicoCreator As another followup I made a new blank project (literally 0 files), typed up a README.md, switched to node 19, then fired it up and got this:
reqJson {"model":"gpt-4","temperature":0,"total_tokens":4050,"max_tokens":29905,"top_p":1,"frequency_penalty":0,"presence_penalty":0,"rawApi":false,"messages":[{"role":"system","content":"You are an assistant, who can only reply in JSON object, reply with a yes (in a param named 'reply') if you understand"},{"role":"assistant","content":"{\"reply\":\"yes\"}"},{"role":"user","content":"[object Object]\n[object Object]\n[object Object]\n[object Object]\n[object Object]"}]}
getCompletion API error {
  message: "This model's maximum context length is 8192 tokens. However, you requested 29973 tokens (68 in the messages, 29905 in the completion). Please reduce the length of the messages or completion.",
  type: 'invalid_request_error',
  param: 'messages',
  code: 'context_length_exceeded'
}

I'm starting to think this isn't so much a size problem as a bug. I tried npm install smol-dev-js and I also build from source and linked it with npm install && npm link to test that way, both attempts gave the same error. node -v shows v19.8.1. Let me know if there's anything else I can do try and debug this further.


fix count down not showing on MyPicks

stat_time wasn't in the model.  Added it, count down is working now.


Can't update the startValues dynamically

I have a scenario where I want the user to be able to control the startValues and I'm having trouble with it. I'm using the state to set the startValues but the values are not updated when the state is updated.
const [timerMinutes, setTimerMinutes] = React.useState('0');
const [timerSeconds, setTimerSeconds] = React.useState('20');

const [timer, isTimerAchieved] = useTimer({
    countdown: true,
    precision: 'secondTenths',
    startValues: { minutes: timerMinutes, seconds: timerSeconds }
});

//I was hoping that calling this function would update the startValues to 1:30 for the instance.
function udpateTimer() {
    setTimerMinutes(1)
    setTimerSeconds(30)
}

Am I doing something wrong? What is the best way to achieve that?
Here's an example: https://codesandbox.io/s/broken-violet-hw5mw?file=/src/App.js

Hi!
Sorry for the late response, I totally missed this issue :(. I am going to answer you anyway, maybe it can help you or other users. useTimer creates a single timer, once it is created you can't create it again with other values. If you need to change the configuration, you need to call timer.start({ /* new config here*/}). I updated your example with a fix: https://codesandbox.io/s/vigorous-poitras-2s7jr?file=/src/App.js
Notice that the timer needs to be stopped to be started again with the new values.
Best regards!


Where to download the out-of-domain images?

Thanks for your great work! Could you please share the original out-of-domain images you collected?

Hey @huiqu18,
The images I have used are scattered across the internet, Most of them are the top results when you search for the character.
Here are few example links:
Joker,  Tyrion Lannister and Lebron James

Thank you for your response.


v4 - route to the correct form on state selection

Add a new page before the account request form that asks users what state their organization is in. If they're in an unsupported state, route them to the waitlist form. If they're in a supported state, route them to the account request form.
No designs for this yet, but this ticket will be updated when they're available.

@vz3 and @emmastephenson to pair on options


Printing in higher DPI does not work for WMTS layers

The TileMatrix of a WMTS layer is selected depending on the scale. Because in this case the scale is the same when printing with DPI 100 or DPI 300, the same TileMatrix is always used. So, WMTS layers can not be printed in a higher resolution.

You want to add a scaleRatio configuration parameter or something?

I tend to say to no additional scaleRatio parameters should be required. It should work the same way as for example with XYZ tiles (and also in v2?).


Undefined name 'Provider' inside generated files

Describe the bug
I use the Riverpod Generator and when it is generating the files some dependencies are not generated correctly. Running the app or tests I get the the error:
Error: Undefined name 'selectedPlaceProvider'. selected.viewmodel.g.dart:1050     selectedPlaceProvider,
Looking in the file I see transitiveDependencies where some of them don't have a type:

I use Riverpod Lint and I have no linting errors. The only way to fix it is to define the transitive Providers as a direct dependency.
To Reproduce
Not sure how to reproduce it. Regenerating the files still create this error.
Expected behavior
The generated files should not contain errors.

I think the problem is that the dependencies originate from a different file which also originate from another. So the original file does not have the import and also does not know that it needs it.

Sounds like you're missing an import. You need to import the provider

That is correct. But I would expect that the linter would warn me when an import is missing. It can be very tedious to add them all manually when have over 50 providers in scattered over different files. The only way to find out there is a problem is by running or testing my app. Do you think there is another way?

I agree. I'll make a separate issue specific to the linter

It is weird that you had this issue though. How did you end-up with this exactly? Because the @riverpod fn and the generated provider should be part of the same library.
So if you import one (for specifying dependencies) then the other should be available


Datagrid resizable columns should be configurable

Select one ...  (check one with "x")
[ ] bug
[x] feature request
[ ] enhancement

Expected behavior

Datagrid columns are always resizable in Clarity. It is sometimes desirable to prevent some or all columns from being resized. There should be a column level option and ideally a datagrid wide option to control if columns are resizable or not.
Actual behavior

It is not possible to configure if columns are resizable or not.

I will vote for this feature too. In some cases we don't like columns to be resized by user.

@usmanajmal you could disable resizing by applying this simple CSS rule:
.datagrid-column-separator {
  pointer-events: none;
}

@usmanajmal you could disable resizing by applying this simple CSS rule:
.datagrid-column-separator {
  pointer-events: none;
}

One possible setback with this work around is that all pointer-events including filtering will be disabled.

@xzs  the workaround I suggested is still valid. It won't affect filtering or any other areas as we are specifically targeting .datagrid-column-separator: https://stackblitz.com/edit/clarity-light-disable-column-resizing

Given the simplicity of the workaround, I'm closing this because it is not going to be bumped up as a priority for the team. It is a good candidate for an external contribution, however. And if that is something someone would want to take on, I'm happy to revisit.


Application Insights

Codecov Report

Merging #26 into master will increase coverage by 6.90%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   41.11%   48.01%   +6.90%
==========================================
  Files          22       25       +3
  Lines         197      227      +30
  Branches       20       23       +3
==========================================
+ Hits           81      109      +28
- Misses        105      107       +2
  Partials       11       11

Impacted Files
Coverage Δ

src/App.js
100.00% <ø> (ø)

src/services/telemetry.service.js
85.71% <85.71%> (ø)

src/constants/config.js
100.00% <100.00%> (ø)

src/utils/TelemetryProvider.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 429318c...9231cb9. Read the comment docs.


⚠ GitLab Server has degraded performance

In f7be8c6, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 6924 ms

Resolved: GitLab Server performance has improved in 50fedd4.


[top/dv] add test chip_sw_uart_tx_rx_alt_clk_freq

Extend from chip_sw_uart_rand_baudrate with following added settings.

Configure LC to RMA state, so that it allows clkmgr to use external clock.
Configure clkmgr to select external clock.
Randomize LOW_SPEED_SEL, so that uart core clock frequency can be either
ext_clk_freq / 4 or ext_clk_freq / 2.

Signed-off-by: Weicai Yang<EMAIL_ADDRESS>

I'm looking into the CI failure in bazel that's happening here.

I'm looking into the CI failure in bazel that's happening here.

Thanks @drewmacrae


Runtime null checks inserted in pure Ceylon code

After @gavinking 's changes this weekend, this code now has runtime null checks inserted for m3 and m4 implementations:
@noanno
interface Bug1208I<T> {
    shared formal Integer m1();
    shared formal T m2();
    shared formal Integer m3();
    shared formal T m4();
}

@noanno
class Bug1208() satisfies Bug1208I<Integer> {
    m1 = function() => 2;
    m2 = function() => 2;
    m3 = function() => m2();
    m4 = function() => m2();
}

Due to a4b03efcc8bb6dd30683faca0d81d08cf32d9276

I can't really fix this without a test, but I suspect you should check the Reference rather than the Declaration's return type.

Should be fixed.

Confirmed! Thanks.


🐡 FIX - linting and image pull policy 🐡

What is this PR About?
Small fixe to the Jenkins chart
How do we test this?
Provide commands/steps to test this PR.
cc: @redhat-cop/day-in-the-life

/lgtm
/approve