Rust code is really unreadable for beginners who want to add new functionality.

Is your feature request related to a problem? Please describe.
I was trying to add a new feature into rust but then the code seems very poor in commenting what it does except few lines.
Describe the solution you'd like
Proper documenting and Commenting required to promote more growth in the Script.
Additional context

@lj3954 @adamperkowski I think you two could best implement detailed comments in the rust codebase.

There's 1843 total lines written in Rust in Linutil as of 006326afa9a6f98f00d1672280e38ceecb139847. 1605 in tui and 238 in core. A lot to comment.

/unlabel 'enhancement'
/label 'rust'

There's 1843 total lines written in Rust in Linutil as of 006326afa9a6f98f00d1672280e38ceecb139847. 1605 in tui and 238 in core. A lot to comment.

Not to mention that those lines are extremely volatile. It's understandable that someone would want an easy experience with contributing, but there are times when the only way to really understand the code is to actually read the code.
Comments get old, people get lazy, and all of a sudden the once helpful comments are just bloat.
Just as a comment from my own experience, this codebase is actually pretty good. There's a lot of meaningful semantic variable naming, there's not a whole lot of macros, and the code itself follows a pretty linear path. I've actually had a very pleasant experience contributing to this project for these reasons.

Also, that's not too say that the internal interfaces shouldn't be documented, but I'm not sure that's what your point is, @guruswarupa

This is actually one of the few open source codebases where I don't get lost.
You can easily follow the flow and get to wherever you want to.
I do understand about newcomers tho, and maybe the more stable parts of the tool could be better documented. I can work on that if we agree that it should be worked on.

/close not planned
Adding comments will clutter the codebase and updating those comments will be a hassle, especially with the rate Linutil has been going, things change, things change fast and we can't constantly be managing and updating comments in the src.


PIXI.TextMetrics undefined

I tried using PIXI.TextMetrics.measureText, but no luck.
Is there a simple way to make this work?

The simplest solution might be to assign TextMetrics via an IIFE.  I'll explore that in the morning if no other options are mentioned.


Support building from source outside of a git repository

Related to aspect-build/silo#329.
Why?
Homebrew build from source (brew reinstall --build-from-source --verbose --debug aspect-cli)
Consierations
The buildinfo/bazel_stamp_info.sh should check if there is a git repository.

If so, do what it does today
If no, check for ASPECT_VERSION env variable. (Homebrew formula will set this value prior to the build.)

This sounds wrong to me, the user will not have access to our source code. If we are on our own tap then we can install a downloaded binary right?

This is my understanding.

The Aspect CLI is open-source.
The Homebrew formula pattern is to provide the install stanza that builds from source.

If we were going to push to be in Homebrew core, they would want this pattern so that they can build the bottles.
Since we will host our tap, we will build our bottles.

This issue merely allows us/someone to build the code specifying the semver instead of using the git tricks to figure it out.

Bazelisk does by passing some flags to go build.
I think Bazel is doing it by setting an environment variable.

I think when/if we want a homebrew formula (call it aspect-oss for clarity) that does want to build the tool from sources in this repo, it should be just like the bazelisk homebrew formula, which is to say, it would use the go tool to build the program and not bother with Bazel at all. So then this could be closed as WAI?


Export Page - When export contact of some company its column is mismatched with values

Describe the bug

When we export 'Test Contact 1' it export a csv with mismathced column and value

Export name: Test Contact 1
Apply to : Contact
Query : Company Avinash Associates
csv file


Show "owner" in Find-PSResource

Summary of the new feature / enhancement
As a user, I want to know who uploaded a package to the gallery, because that can't be spoofed.
On the gallery, when I search, I see the module name, latest version, download count, and owner (aka the uploader, labelled "By") and can browse all the other modules by the same author.
Find-PSResource offers no parity at all. It doesn't search descriptions (only names), and only shows the Name, Version, and Description. In fact, the download counts and owner are missing from the object -- information we know is available in the nuget search response.  Since the author and company name are "just metadata" that isn't checked or validated at all, making the owner (and download count) available on the return seems critical.
Example (results in gallery):

Hey @Jaykul, thanks for opening up this issue. Perhaps a suggestion would be to add a new parameter to the Find-PSResource cmdlet to get available commands from a specific author: -Author.

I'm less interested in filtering than I am in knowing who uploaded the module (versus what's in the metadata).


[Bug report] Page goes blank when there is no shooter ratio

Thanks for the report. Fixed in https://github.com/tervay/recalc/commit/727e31483cf601566db1c6b75e1f6672a25d9317


FIX: crash when selected corrupted image on Android

@johnmlee101
Details
App got crashed when user selected the corrupted image file from Image Library.
I added check condition for input attachment image's width and height. The corrupted images always return -1 for both width and height.
Fixed Issues
https://github.com/Expensify/Expensify.cash/issues/2570
Tests
QA Steps

Open app and login
Enter any chat
Tap on + sign > Add Attachment > Choose From Gallery
Choose a corrupted picture

Tested On

[ ] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[X] Android

Screenshots
Web
Mobile Web
Desktop
iOS
Android

Also there are conflicts that need resolving first.

Updated

Updated

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


feat: Version Compatibility Based on Gem Specs

This changes provides instrumentation authors the ability to use gem specifications for version compatibility checks instead of having to write a custom compatibility block.
In order to take advantage of this feature instrumentation authors must:

Declare the library and version constraints as a development dependency
Use instrumentation naming conventions e.g. opentelemetry-instrumentation-ruby_kafka

Related https://github.com/open-telemetry/opentelemetry-ruby/issues/988
Some Concerns:

There are certainly many more test scenarios to take into consideration. E.g. When multiple versions of the gem are installed and not yet activated.
Naming is strict and requires that the instrumentation name suffix matches the target library. We currently have some cases where the instrumentation names do not match e.g. ruby-kafka and activesupport

Ping @open-telemetry/ruby-maintainers @open-telemetry/ruby-approvers 🙏

@arielvalentin My two cents is i think this looks great and is an improvement on the current system. It feels _ a little_ hacky to me to rely on development dependancies in a gemspec, for something like an instrumentation that doesn't necessarily need to be packaged as a gem to begin with, but since this doesn't override the compatible block, but only acts as a useful fallback/default, I don't see the harm. that being said I'd like some other folks to chime in here, I brought this up in the SIG, would be keen to hear other POVs here.

@arielvalentin My two cents is i think this looks great and is an improvement on the current system. It feels _ a little_ hacky to me to rely on development dependancies in a gemspec, for something like an instrumentation that doesn't necessarily need to be packaged as a gem to begin with, but since this doesn't override the compatible block, but only acts as a useful fallback/default, I don't see the harm. that being said I'd like some other folks to chime in here, I brought this up in the SIG, would be keen to hear other POVs here.

@ericmustin I would think folks that are writing their own auto-instrumentation that are not packaged as a gem are likely either implemented first party or patched in their applications. It's likely they are aware what the compatibility requirements are in their own projects or may not be using instrumentation at all.
Could you elaborate a bit on what you think makes it a little hacky?

Could you elaborate a bit on what you think makes it a little hacky?

I don't think that checking development dependancies in a gemspec from production code is a common convention. Maybe hacky isn't the right term.  That being said I think it's fine imo, just, unusual. Again i'd like some other input here from @open-telemetry/ruby-maintainers @open-telemetry/ruby-approvers

@robertlaurin do you have any time this week to take a look?

Closing per my offline conversation with @robertlaurin https://github.com/open-telemetry/opentelemetry-ruby/issues/988#issuecomment-1018676853


New scvi-tools breaking changes

Hi contrastiveVI team!
I just wanted to let you know that we are soon going to release a version of scvi-tools that breaks your code. The fortunate thing is that it doesn't look hard to fix. You can read more here:
https://docs.scvi-tools.org/en/0.15.0-beta.0/release_notes/v0.15.0.html
Please feel free to reach out with any questions on our discourse. As a first step you may consider upper bounding the version to <0.15.0, and then making the changes.

Hi @adamgayoso ,
Thanks for the heads up! We'll take a look and let you know if we run into any issues.

Addressed in https://github.com/suinleelab/contrastiveVI/pull/6.


Fix #55: Hide Bottom Navigation on Contact List Fragment

Fixed #55
Debug the transition between fragments navigation using bottom navigation
Below is the Screen Recoding of Changes:-
https://user-images.githubusercontent.com/76530270/163543050-d252b04e-6758-444c-b2b7-5464f69adedd.mp4

@yellowHatpro can you please review this PR for issue #55

Yeah now it looks better

Thanks you
Can you please assign this PR to me
Add Lables Level and GSsoc
As per gsssoc 2022

@yellowHatpro please add lables on this PR please


[run-bundle] Test example scenarios for run bundle

Description of the change:
This PR adds additional olm integration tests to test the run bundle
command for various example UX scenarios.
Motivation for the change:
Follow up of #3831
c/c: @jmrodri
Checklist
If the pull request includes user-facing changes, extra documentation is required:

[ ] Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
[ ] Add or update relevant sections of the docs website in website/content/en/docs

Closing this PR as this would be tested in unit tests.


bug: EthereumProvider.init is not a function

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
0.12.18
Current Behavior
React test throwing below error. when updating walletConnect to v2
TypeError: EthereumProvider.init is not a function
 ❯ WalletConnectConnector.initProvider_fn node_modules/@wagmi/connectors/dist/walletConnect.js:222:58

testing lib : vitest
I used rainbowkit for connect : "@rainbow-me/rainbowkit": "0.12.15",
Expected Behavior
No response
Steps To Reproduce
No response
Link to Minimal Reproducible Example (StackBlitz, CodeSandbox, GitHub repo etc.)
No response
Anything else?
No response

Ran into the same issue when using vitest to test React components. There was a similar report on @wagmi/connectors https://github.com/wagmi-dev/references/issues/370.


Binding multiple provider with same CRD into one consumer cluster

Problem Statement:
Currently kube-bind assumes that there will be only one provider cluster for a given CRD. But it is common to have multiple provider cluster for a CRD. This proposal discusses some changes in CRDs to enable this use-case.
Proposed Solution:
There are 3 parts to the proposed solution.

In the BindingResponse, the provider will returns a cluster UID which is stable and unique across all the clusters from that provider. My proposal is to use kubectl get ns kube-system -o=jsonpath='{.metadata.uid}' as the cluster UID.

In the APIServiceBinding CRD spec is modified to list an array of all clusters that offer this CRD. This will given konnector enough information to sync CROs.

When consumer creates a CRO, then apply a provider.kube-bind.io/cluster-id: {uid} as annotation if a CRD is provided by multiple cluster. If only one cluster offers that CRD, it can be used without the annotation.

What this does not solve:
If multiple provider clusters have the same CRD with different schema, this does not solve that. I don't think there is any easy solution for that. I think it is reasonable to assume that consumer/provider will communicate out of band to resolve this issue.

I have proposal is Google Doc format here:
https://docs.google.com/document/d/1xpsPwbQhQTa64rK0CKqS0ez_lsT6eVTU3pel0x2eTxM/edit


Breadcrumb

breadcrumb Is added with the FoundationPress style and the option GetText for the translations.

How can I delete the commits, now? or is better do a new pull request?
Thanks!!

Good work with that. But some people may not want the breadcrumb in the header, some would prefer the footer,
Do you think it would be worth me doing some code that would give the user the option, this could be including in the WP Customizer interface as a tick box?

@themestechnology If you only want the breadcrumb in the footer, you only have copy the call function where you want.
<?php the_breadcrumb(); ?>

What @themestechnology was trying to suggest was plugin functionality to allow users to determine the location of the breadcrumbs through the WP admin panel, without tinkering with PHP files.
Dude, anything you can do to make this platform more awesome than it already is, would be greatly appreciated.
I think this platform has awesome potential to become one of the best out there, and the more contributors, the better.
I was considering an SQL-driven solution to the breadcrumbs, because I think breadcrumbs are important. Unfortunately, I don't have time to dedicate to the things I want to do because I have just started a very time-taxing job.

Oh, thanks for the work, @mvillagordo ;)

Forgive me for the pull request.


DNA mass and SAR11

From the at sea team:

Michelle is sampling:

viral and cellular DNA (total nanograms is final reported data, count/ml is initial?)
presence/absence for SAR11 and associated virus

I've confirmed that the dna is just a mass/volume and the SAR11 is a Boolean presence/absence.
I want to try to find some other data sets with things data this (specifically how is bool handled in CF).

After discussing with the person on board P02, we are going to create a placeholder parameter of VIRAL_ABUNDANCE (no units) for this level 3 program. The genes being looked haven't been finalized yet.


Bash: build failed for 5.1.p4-1

I have updated my system and I get the following from bash:
.
.
gcc  -DPROGRAM='"bash"' -DCONF_HOSTTYPE='"x86_64"' -DCONF_OSTYPE='"linux-musl"' -DCONF_MACHTYPE='"x86_64-pc-linux-musl"' -DCONF_VENDOR='"pc"' -DLOCALEDIR='"/usr/share/locale"' -DPACKAGE='"bash"' -DSHELL -DHAVE_CONFIG_H   -I.  -I. -I./include -I./lib    -O3 -pipe -march=native -static  -c arrayfunc.c
rm -f assoc.o
gcc  -DPROGRAM='"bash"' -DCONF_HOSTTYPE='"x86_64"' -DCONF_OSTYPE='"linux-musl"' -DCONF_MACHTYPE='"x86_64-pc-linux-musl"' -DCONF_VENDOR='"pc"' -DLOCALEDIR='"/usr/share/locale"' -DPACKAGE='"bash"' -DSHELL -DHAVE_CONFIG_H   -I.  -I. -I./include -I./lib    -O3 -pipe -march=native -static  -c assoc.c
rm -f braces.o
gcc  -DPROGRAM='"bash"' -DCONF_HOSTTYPE='"x86_64"' -DCONF_OSTYPE='"linux-musl"' -DCONF_MACHTYPE='"x86_64-pc-linux-musl"' -DCONF_VENDOR='"pc"' -DLOCALEDIR='"/usr/share/locale"' -DPACKAGE='"bash"' -DSHELL -DHAVE_CONFIG_H   -I.  -I. -I./include -I./lib    -O3 -pipe -march=native -static  -c braces.c
rm -f bracecomp.o
gcc  -DPROGRAM='"bash"' -DCONF_HOSTTYPE='"x86_64"' -DCONF_OSTYPE='"linux-musl"' -DCONF_MACHTYPE='"x86_64-pc-linux-musl"' -DCONF_VENDOR='"pc"' -DLOCALEDIR='"/usr/share/locale"' -DPACKAGE='"bash"' -DSHELL -DHAVE_CONFIG_H   -I.  -I. -I./include -I./lib    -O3 -pipe -march=native -static  -c bracecomp.c
rm -f bashhist.o
gcc  -DPROGRAM='"bash"' -DCONF_HOSTTYPE='"x86_64"' -DCONF_OSTYPE='"linux-musl"' -DCONF_MACHTYPE='"x86_64-pc-linux-musl"' -DCONF_VENDOR='"pc"' -DLOCALEDIR='"/usr/share/locale"' -DPACKAGE='"bash"' -DSHELL -DHAVE_CONFIG_H   -I.  -I. -I./include -I./lib    -O3 -pipe -march=native -static  -c bashhist.c
rm -f bashline.o
gcc  -DPROGRAM='"bash"' -DCONF_HOSTTYPE='"x86_64"' -DCONF_OSTYPE='"linux-musl"' -DCONF_MACHTYPE='"x86_64-pc-linux-musl"' -DCONF_VENDOR='"pc"' -DLOCALEDIR='"/usr/share/locale"' -DPACKAGE='"bash"' -DSHELL -DHAVE_CONFIG_H   -I.  -I. -I./include -I./lib    -O3 -pipe -march=native -static  -c bashline.c
rm -f list.o
gcc  -DPROGRAM='"bash"' -DCONF_HOSTTYPE='"x86_64"' -DCONF_OSTYPE='"linux-musl"' -DCONF_MACHTYPE='"x86_64-pc-linux-musl"' -DCONF_VENDOR='"pc"' -DLOCALEDIR='"/usr/share/locale"' -DPACKAGE='"bash"' -DSHELL -DHAVE_CONFIG_H   -I.  -I. -I./include -I./lib    -O3 -pipe -march=native -static  -c list.c
bashline.c:65:10: fatal error: builtins/builtext.h: No such file or directory
   65 | #include "builtins/builtext.h"  /* for read_builtin */
      |          ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:101: bashline.o] Error 1
make: *** Waiting for unfinished jobs....
gcc -rdynamic -O3 -pipe -march=native -static  -rdynamic -O3 -pipe -march=native -static  -o mkbuiltins mkbuiltins.o -ldl
./mkbuiltins -externfile builtext.h -structfile builtins.c \
    -noproduction -D .   ./alias.def ./bind.def ./break.def ./builtin.def ./caller.def ./cd.def ./colon.def ./command.def ./declare.def ./echo.def ./enable.def ./eval.def ./getopts.def ./exec.def ./exit.def ./fc.def ./fg_bg.def ./hash.def ./help.def ./history.def ./jobs.def ./kill.def ./let.def ./read.def ./return.def ./set.def ./setattr.def ./shift.def ./source.def ./suspend.def ./test.def ./times.def ./trap.def ./type.def ./ulimit.def ./umask.def ./wait.def ./reserved.def ./pushd.def ./shopt.def ./printf.def ./complete.def ./mapfile.def
make[1]: Leaving directory '/home/macquat/.cache/kiss/proc/28048/build/bash/builtins'
-> bash Build failed

Does somebody else have this error ?

Strange, builds just fine for me. Are you using the packaged build file or have you modified it?

Strange, builds just fine for me. Are you using the packaged build file or have you modified it?

I didn't modified it. I used the packaged build. I tried to build the version in community and I can build it. The build in repo-community fails.

I didn't modified it. I used the packaged build. I tried to build the version in community and I can build it. The build in repo-community fails.

I have to have a look at this:
https://lists.gnu.org/archive/html/bug-bash/2020-12/msg00000.html
It seems promising.

I have to have a look at this:
https://lists.gnu.org/archive/html/bug-bash/2020-12/msg00000.html
It seems promising.

@noocsharp As I can see you have updated bash. It's interesting: I have a local repo on my system. If I kiss-fork bash in my local repo, then I can compile bash without problem. As soon as I try to build it from communty, the build fails. It's discussed here:
https://lists.gnu.org/archive/html/bug-bash/2020-12/msg00051.html
Could you try to add the patch given here:
https://gitweb.gentoo.org/repo/gentoo.git/tree/app-shells/bash/files/bash-5.1-parallel_make.patch?id=4c2ebbf4b8bc660beb98cc2d845c73375d6e4f50
I could then test if it works.

@noocsharp As I can see you have updated bash. It's interesting: I have a local repo on my system. If I kiss-fork bash in my local repo, then I can compile bash without problem. As soon as I try to build it from communty, the build fails. It's discussed here:
https://lists.gnu.org/archive/html/bug-bash/2020-12/msg00051.html
Could you try to add the patch given here:
https://gitweb.gentoo.org/repo/gentoo.git/tree/app-shells/bash/files/bash-5.1-parallel_make.patch?id=4c2ebbf4b8bc660beb98cc2d845c73375d6e4f50
I could then test if it works.

I sent in a pull request adding this patch.

I sent in a pull request adding this patch.

I have updated my system without problem, thank you! :+1:!

I have updated my system without problem, thank you! :+1:!


How to define return type of v3::MqttServer::new

I'm working on a project that is trying to use ntex-mqtt and so far it seems to work out pretty well. So first of all thanks for this amazing framework!!
Now my issue is with defining the function signature of a function that returns the result of v3::MqttServer::new. The function looks like this:
fn new_server_v3(
    <snip>
) -> v3::MqttServer<ClientSession, ?, ?, ?> {
    v3::MqttServer::new(|handshake: v3::Handshake| async {
       // do some prep stuff

        let session = ClientSession {
            <snip>
        };

        Ok::<_, ServerError>(handshake.ack(session, false))
    })
    .control(control_service_factory_v3())
    .publish(fn_factory_with_config(
        |session: v3::Session<ClientSession>| {
            Ready::Ok::<_, ServerError>(fn_service(move |req| publish_v3(session.clone(), req)))
        },
    ))
}

For readability and because this function takes some variables that we need later again to create the v5 server, we really prefer to create this function instead of defining it inline. Amongst other things it requires us to type a lot of let var = var.clone()'s in between and inside every closure.
Using a function like this makes the code so much cleaner and the readability so much better/easier, but I fail to find how to define the return type correctly. If I assign the result of v3::MqttServer::new to a variable and inspect that it shows something like:
ntex_mqtt::v3::MqttServer<_, FnServiceFactory<[closure@connect/ingester/src/ingester.rs:142:33: 142:59], impl std::future::Future<Output = Result<ntex_mqtt::v3::HandshakeAck<ClientSession>, ServerError>>, ntex_mqtt::v3::Handshake, ntex_mqtt::v3::HandshakeAck<ClientSession>, ServerError, ()>, impl ServiceFactory<ntex_mqtt::v3::ControlMessage<ServerError>, Session<ntex_mqtt::v3::MqttSink, ClientSession>, Response = ntex_mqtt::v3::ControlResult, Error = ServerError, InitError = ServerError>, FnServiceConfig<[closure@connect/ingester/src/ingester.rs:158:9: 158:46], ntex::util::Ready<FnServiceFactory<[closure@connect/ingester/src/ingester.rs:159:52: 159:62], impl std::future::Future<Output = Result<(), ServerError>>, ntex_mqtt::v3::Publish, (), ServerError, ()>, ServerError>, Session<ntex_mqtt::v3::MqttSink, ClientSession>, FnServiceFactory<[closure@connect/ingester/src/ingester.rs:159:52: 159:62], impl std::future::Future<Output = Result<(), ServerError>>, ntex_mqtt::v3::Publish, (), ServerError, ()>, ntex_mqtt::v3::Publish, ServerError>>

Which is just a little too much for me 😅 So can you maybe tell me how to define the type of how I should be able to find that out by myself?
Thanks!!

do you need something like this?

That's pretty close, but still slightly different... In our case we in the end have something like this:
let server_v3 = server_v3(...);
let server_v6 = server_v5(...);

MqttServer::new().v3(server_v3).v5(server_v5)

So it's about the type the is expected by MqttServer::new().v3(...) and MqttServer::new().v5(...). If I change my result type to the impl from the example (just for testing) it gives me this error:
expected struct `ntex_mqtt::v3::MqttServer<_, _, _, _>`
found opaque type `impl ServiceFactory<ntex::io::Io<[type error]>, [type error], Response = (), Error = [type error], InitError = ()>`

it is not possible to write type with closures (at least i dont know)
other option would be to use service::boxed::BoxServiceFabric<>

Well, I guess you are right about that (not possible to write a type with closures). At least I'm not able to find a way either 😊
So any pointers (no pun intended 😉 ) to the other option? I searched the ntex org for BoxServiceFabric but got zero hits. Did find BoxServiceFactory and some in boxed.rs, but not much examples on how I would approach that..

BoxServiceFactory, just define all params same as in ServiceFactory trait. you can create it with factory helper

I'll have a closer look. Thanks for help so far!


Schedule node-exporter to controlplane and etcd roles

Problem:
node-exporter component isn't scheduling to controlplane and etcd role
nodes
Solution:
Modify taints
Issue:
https://github.com/rancher/rancher/issues/17030

@loganhz

Close this PR, patch by another PR.


IllegalArgumentException when validating email address ending with "High Octet Preset" control character

Using JMail 1.3.2 to validate an email address ending with a "High Octet Preset" control character, e.g. JMail.isValid("a@b.com\u0081"); fails with:
java.lang.IllegalArgumentException: java.text.ParseException: A prohibited code point was found in the inputcom
	at java.base/java.net.IDN.toASCIIInternal(IDN.java:275)
	at java.base/java.net.IDN.toASCII(IDN.java:123)
	at com.sanctionco.jmail.JMail.isValidIdn(JMail.java:512)
	at com.sanctionco.jmail.JMail.lambda$tryParse$0(JMail.java:119)
	at java.base/java.util.Optional.filter(Optional.java:218)
	at com.sanctionco.jmail.JMail.tryParse(JMail.java:119)
	at com.sanctionco.jmail.JMail.isValid(JMail.java:67)
Caused by: java.text.ParseException: A prohibited code point was found in the inputcom
	at java.base/jdk.internal.icu.text.StringPrep.prepare(StringPrep.java:448)
	at java.base/java.net.IDN.toASCIIInternal(IDN.java:273)
	... 74 more

I guess that is not the expected behavior, or am I wrong?
By the way: Thank you very much for developing JMail! It is the best Java E-Mail validation library.

Thank you for the report @PascalSchumacher. You're right that this is not the expected behavior, I will take a look at this issue.

@PascalSchumacher please let me know if the fix in fbeecce looks good to you and I will publish a new version v1.3.3.

@RohanNagar Thanks for the quick fix. I always a bit nervous when I see a catch block catching Exception because it also catches Throwables like OutOfMemoryError. According to the Java Doc this method only throws IllegalArgumentExceptions so I believe catching that would be better. What do you think?

@PascalSchumacher Good point. OutOfMemoryError actually would not be caught since it extends Error. If we did something like catch (Throwable t), then it would be caught.
However since this method only throws IllegalArgumentException it makes sense to only catch that. I've updated and released version 1.3.3, which should be available on maven central in about 10 minutes!

@PascalSchumacher Good point. OutOfMemoryError actually would not be caught since it extends Error. If we did something like catch (Throwable t), then it would be caught.

Yes, I was wrong. I do not know what I was thinking. Sorry!
Thank you very much for the new release! 👍  😃


[Zip] Reimplement to remove Sendable constraint and reduce Task creation

Hi,
This issue is just to keep track that I'm in the process of refactoring the zip operator to follow the work bootstrapped by @FranzBusch.
The goals are:

to remove the Sendable constraint on the base iterators
to optimise the number of created tasks

I will implement zip state machines which roles will be to compute the next state (and the output) given a current state and an event (as in a Mealy state machine), and use those state machines in the zip async sequences.
I'll keep you posted.

As the PR has been merged we can close this issue.
Thanks @phausler and @FranzBusch


Docs: A row in the Discriminating Unions example is barely visible

Page URL: https://www.typescriptlang.org/docs/handbook/unions-and-intersections.html#discriminating-unions
Issue: I can barely see the text in the first row of the table, where the shared "state" property of the union type is shown
Recommended Fix: Please apply the font color which is more contrast to the background of the row, for example, black.
Browser: Google Chrome Version 80.0.3987.163 (Official Build) (64-bit)
OS: MacOS Catalina Version 10.15.4

ah, dark mode - my constant enemy


Why is ReLU used?

Is there a particular reason why the OPT-family models don't use GeLU like GPT does (at least, to my knowledge)?

See the Run 11 section of the logbook for rationale of why we made that decision.

I see. So the main reason was to address training instabilities, right?


fix: e2e failure due to count returned by APISIX

Signed-off-by: Ling Samuel<EMAIL_ADDRESS>
[x] Bugfix

Bugfix

Description

If the count field is string, its value is greater than actual value by 1.

How to fix?

Decrease count if its type is string.

Codecov Report

Merging #640 (1c53349) into master (91d985e) will increase coverage by 0.33%.
The diff coverage is n/a.

:exclamation: Current head 1c53349 differs from pull request most recent head ba56dc4. Consider uploading reports for the commit ba56dc4 to get more accurate results

@@            Coverage Diff             @@
##           master     #640      +/-   ##
==========================================
+ Coverage   34.46%   34.79%   +0.33%
==========================================
  Files          57       57
  Lines        5722     5722
==========================================
+ Hits         1972     1991      +19
+ Misses       3504     3492      -12
+ Partials      246      239       -7

Impacted Files
Coverage Δ

pkg/apisix/route.go
37.76% <0.00%> (+2.09%)
:arrow_up:

pkg/apisix/cluster.go
30.47% <0.00%> (+3.27%)
:arrow_up:

pkg/apisix/plugin.go
100.00% <0.00%> (+20.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8854c3...ba56dc4. Read the comment docs.


ARTEMIS-4145 MQTT shared sub queue may be inadvertently removed

o.a.a.a.c.p.m.MQTTSubscriptionManager#removeSubscription() had a chunk of code from 971f673c602f859f342e22afe988c71687f754b6 removed. I couldn't determine why that bit of code was actually added in the first place, but the tests from that commit all still pass even with it removed now (as well as all the other MQTT tests) so I think it's safe.

The last point of the original changes description seems to be about why that code was added:

For the MQTT protocol, there is one and only one consumer connection per queue, which is a good choice for closing the old MQTT consumer before the new MQTT consumer connects.
The original code could not effectively clean up the 'old consumer' in the queue when the 'new MQTT connection' was connected to the Artemis broker. Modify ‘MQTTSubscriptionManager.removeSubscription’ to get the queue consumer collection from the ‘QueueImpl’ instance and close them.

@gemmellr, thanks for the clarification. I'll update the commit message based on this.


Small changes to propositional logic part and natural deduction chapter

Several small typos and some corrections added. Also added a sentence explaining !A \Proves !B.

Right, didn't no you could negate tags. Thanks.

Thanks!


Hierarchical network

Dilated convolution improves convergence (per step) a bit:

Although it's also massively slower, so we might want to re-evaluate its context size:

For the same wall-time, dilated convolution underperforms the dense one:

Currently, the performance improvements are marginal:

One way this could be happening is that the model doesn't use the context of the depthwise block. To validate this is happening, I'll start another run without bottleneck block and QRNN.

#48 somewhat addresses the convolution issue using an explicit locality bias for convolutions. Note that it doesn't reduce the computation time. However, neither do dilated convolutions, so it seems fair.


Accuracy too low, any sugguestions?

Step by step guided by the README, i created an env almost the same as the proj.
the env is listed below:
conda 4.5.11
pytorch 1.12
cuda 11.7
After changing the path of datasets in the 'train.sh'
Using the CVPR2016 and NIPS2014, i got the highest accuracy 79.43 after 9 Epochs iterations. Seems far away from the paper result.
Anyone has any ideas or suggestion? 3x a lot !

The python version is 3.10 preinstalled in the Ubuntu 22.04LTS. There are a few syntax difference with the project's code, and i have already changed to eleminate all warnings.


Looking for CPU memory usage REST API in azure

Hi There,
I was trying to find the REST API for the cpu memory usage in azure for the list of subscriptions . In list of subscriptions looking for each resource group- > each VM usage details . Also would like to know the allocation and the usage memory in GB.
Can someone help me with this issue?
Thanks,
Venkata

hi @Madhut is this a Dup of #5703, I will close for now and You can vote on the other one and add your comments there, if not please reopen this one
THANKS for reaching OUT :)


Add missing propTypes for shadow, buttonStyle, textStyle, & colorStyle

Continuing off of https://github.com/styled-system/styled-system/pull/554 adding the same to @styled-system/prop-types

Awesome, thanks!


Update eks-a e2e test AMI to the latest

Issue #, if available:
Updating e2e ami with the latest security patches
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm
/approve


Grid actions should still be center-aligned

On .grid-actions, align-self: center should work.
(09 May 2022)

Fixed in e5334b6907cc59d88df948020addbc9fc3bf0c82!


Streaming events

is there any way to stop capturing when no more data comes from udp stream?

I guess you could call command.kill() in your stream end handler. But since it's an UDP stream, is there really an end ?


RE7 crashing upon installer upscaler plugin.

game crashes whenever i insert dlss to use as plugin. any fix or what i should do?

same issue


Remove thiserror crate

Manually implement std::error::Error and std::fmt::Display for the Error enum, rather than using the derived implementation from thiserror.
This should provide a compile time benefit, especially on slow machines.

Sorry, so late to response on this. How much time does thiserror's compilation cost in your case?

Sorry, so late to response on this. How much time does thiserror's compilation cost in your case?

No worries! I've run some builds to give you some data!
With thiserror:
cargo clean; cargo build
4.98s
4.85s
4.94s
4.95s
4.98s
=> Average: 4.94s
cargo clean; cargo build --release
10.70s
9.51s
9.80s
9.63s
9.80s
=> Average: 9.89s
Without thiserror
cargo clean; cargo build
1.49s
1.45s
1.49s
1.48s
1.49s
=> Average: 1.48s
cargo clean; cargo build --release
1.48s
1.41s
1.43s
1.42s
1.41s
=> Average: 1.43s
I had been getting results of about 6s, 12s, 1.5s and 2s before, but I couldn't reproduce those numbers - I assume that there were more background processes running at the time, but even with these latest numbers you can see a pretty decent increase.

You know, maintaining the manually implemented code is somewhat annoying. So we use the thiserror to avoid that.

Sure, completely agree with the principle. After all, this is why I'm using this crate to check if a program is installed, rather than doing my own thing and likely messing up all the edge cases. And if you'd used thiserror in a lot of places with multiple errors, and/or used some more of thiserror's various attributes, I may not have bothered with this pr. Likewise if this crate was under heavy development. But it seems pretty stable, and the "manually implemented code" in this case boils down to essentially a single trivial match statement, which I wouldn't have thought would cause much of a burden!

unless you do something very bare bone chances are good that you have thiserror in your dependency graph anyway. I don't mind which using it. I use it myself in asyncgit


pushRawTX

Is there any function or endpoint to submit Txs that I finalize later with sats-connect?
Right now I am signing without broadcasting, finalizing, and then using external api for broadcast

This doesn't exist at the moment, no. We can add it as a feature request 👍


Show only title and quantity in ERC 875 token card if there's no asset definition

For #664

@hboon Excellent! Just missing it on import screen

It shows the 1st screenshot for a while and then the 2nd after it gets the contract name — from the local datastore if available, otherwise after making an RPC call). The latter might take a while. Is that what you noticed? We can show the "token name" (from the XML) as a placeholder while/if it needs to make the RPC call.

@James-Sangalli Ready for review again


Disabled the json_run_localhost:*_low_thread_count family of tests

The relevant issue, #13122 should still be treated as high priority, aiming at getting this re-enabled.

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences


Error when trying to download with links in a file

Hi, after the update 2.1.0 when i try to download videos from a file (".txt"). It gives me this error:
[ERROR] TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
at validateString (internal/validators.js:120:11)
at Object.join (path.js:375:7)
at D:\destreamer-master\build\src\VideoUtils.js:78:64
at Array.forEach ()
at Object.createUniquePath (D:\destreamer-master\build\src\VideoUtils.js:75:12)
at downloadVideo (D:\destreamer-master\build\src\destreamer.js:101:33)
at processTicksAndRejections (internal/process/task_queues.js:97:5)
how can i fix this?

I got the same issue. Besides, when chromium get opened, it gets crashed in the next 10-15 seconds and it returns the following error.
[ERROR] TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined at validateString (internal/validators.js:120:11) at Object.join (path.js:375:7) at D:\destreamer-master\build\src\VideoUtils.js:78:64 at Array.forEach () at Object.createUniquePath (D:\destreamer-master\build\src\VideoUtils.js:75:12) at downloadVideo (D:\destreamer-master\build\src\destreamer.js:101:33) at processTicksAndRejections (internal/process/task_queues.js:97:5)

could you try to run with the --verbose/-v flag and paste here your output please? censor as you like usernames or real folder names with fake ones if you like :)

[VERBOSE] Session and API info
API Gateway URL: https://euwe-1.api.microsoftstream.com/api/
API Gateway version: 1.4-private
Parsing input file
[VERBOSE] List of GUIDs and corresponding output directory
https://web.microsoftstream.com/video/X => undefined
The error is the same as above

would you mind sharing the command you are launching and the input file? I can't figure out why it's resulting in an undefined directory

D:\destreamer-master>
algebra.txt
destreamer.cmd -k -v -f algebra.txt
Using ffmpeg version git-2020-07-16-d11cc74 Copyright (c) 2000-2020 the FFmpeg developers
Access token still good for 52 minutes.
[VERBOSE] Session and API info
API Gateway URL: https://euwe-1.api.microsoftstream.com/api/
API Gateway version: 1.4-private
Parsing input file
[VERBOSE] List of GUIDs and corresponding output directory
https://web.microsoftstream.com/video/61659c80-3ec5-4663-8f44-e810187b288d => undefined

Thank you very much, found the bug thanks to you file @RiccardoJR! will push a fix as soon as I can


Why is the release of this application taking sooo long??

Because we are not working on it full time lol!!


Upgrade to 3.1.2 causes fails to look up resources in some cases.

We are using WPFLocalizationExtension with DevExpress MVVM UI.
Xaml causing problems looks like this. Resource is present, access modifier is public.
<dxmvvm:SaveFileDialogService
      AddExtension="True"
      AutoUpgradeEnabled="True"
      DefaultExt=".cst"
      Filter="{lex:Loc LblCstFileFilter}"
      OverwritePrompt="True" />

This resource is not found, though. Same resource key used with menu items, for example, works and displays corresponding string.
Version 3.1.1 does not have this issue.

At runtime.
I don't remember having this issue with 3.0.0, but I'll re-check.
Will binding redirection suffice ?

Do not know, I does not have experience with binding redirection.


Fix: grant permissions when creating Redshift db

Took this directly from #194, so hopefully I got the syntax right! ❤

You shouldn't need to grant usage on the schema more than once unless you're recreating it all the time, but it shouldn't hurt.  Looks good to me.

Thanks for adding this! We only run this command when creating a brand new schema or when the altering it, so looks good.


Add "Finish all chapters" feature

Now we need to finish chapters handle for each chapter.
And we need to add button in ChaptersList for finish all started chapters in book

need to add definition and UI prototype.
Do we need cancel finish all chapters?


feature request: QuoteOrder

I'm adding an order form to Terminal and would like to display some of the same information in the UI that is presented when submitting an order from the CLI:
-- Order Details --
Bid Amount: 0.02 BTC
Bid Duration: 2016
Total Premium (paid to maker): 0.00019998 BTC
Rate Fixed: 4960
Rate Per Block: 0.000004960 (0.0004960%)
Execution Fee:  0.00002001 BTC
Max batch fee rate: 300 sat/kw
Max chain fee: 0.000039 BTC
Confirm order (yes/no):

Most of this information, I am able to calculate in the web app with relatively little code. For example, I've already implemented the code to convert from interest rate to the rate per block. The challenge I am currently facing is calculating the "Max chain fee" given the --max_batch_fee_rate. I have traced how this is done in the pool CLI. It calls EstimateTraderFee which uses constants from poolscript, lnd, and btcd to determine the bytes of this order's transaction in the batch.
I started down the path of copying all of these constants into my JS code, then realized how much needed to be duplicated. My concern is not just how much effort this would be for me, but I am also considering the usability of the GRPC API for future devs. I would image that they will also run into this same issue and need to duplicate this code in their apps. This feels a bit wasteful for consumers of the API.
With all of that said, I'd like to request the ability to fetch the same order details above as a quote without actually submitting the order. I'm imagining there would be a QuoteOrder endpoint which takes the exact same args as SubmitOrder, but the response would be something like this:
{
  "premium": "19998",
  "rate_fixed": 4960,
  "rate_per_block_pct": "0.0004960",
  "execution_fee": "2001",
  "max_batch_fee_rate": 300,
  "max_chain_fee": "3900"
}

This still wanted/needed?

Yes, this is still needed for the UI to be able to display accurate fees before placing an order.


Where is this heading?

Good stuff :)
Been disappointed with Phoenix content being a Rails "look a like" and not getting with the times... We need a much lighter framework designed for micro services.
What are your general ideas? I thought it also might be useful to go with absinthe graphql instead of sticking with old school REST.

Heh
I've given Potion a lot of sporadic thought over the years. Unfortunately, I've not been able to coalesce my scattered thoughts into a coherent roadmap. I've also not had the (justifiable) time to make Potion.
Absinthe is really intriguing. It's something I'm interested in trying at work, as we're essentially futzing with large graphs. There's definitely bits I want to steal for Potion.
I also like some of the ideas in Trailblazer.
I've mostly been playing with the representation layer as of late. I really like the idea of building a pipeline of operations that work ontop of a intermediate form, that can be lowered into whatever representation you want. Blazon is headed in the right direction, but needs massive rework. There's definitely a not-so-sutbtle hint of LISP in that. I'm going to tackle this soon.


[vim] Fix crash on exiting insert mode.

Happened if you entered visual block mode in one editor and then tried to exit insert mode in another, since lastChange comes from vimGlobalState.

looks good to me


Support for mman.h

Adding one new header file:
spawn.h
Adding new functions:
posix_spawn
posix_spawnp
posix_spawn_file_actions_addclose
posix_spawn_file_actions_adddup2
posix_spawn_file_actions_addopen
posix_spawn_file_actions_destroy
posix_spawn_file_actions_init
posix_spawnattr_destroy
posix_spawnattr_getflags
posix_spawnattr_getpgroup
posix_spawnattr_getschedparam
posix_spawnattr_getschedpolicy
posix_spawnattr_getsigdefault
posix_spawnattr_getsigmask
posix_spawnattr_init
posix_spawnattr_setflags
posix_spawnattr_setpgroup
posix_spawnattr_setschedparam
posix_spawnattr_setschedpolicy
posix_spawnattr_setsigdefault
posix_spawnattr_setsigmask

I checked all the changes, and the functions work correctly as intended.


Fix decoding of MISO in single-bit mode

Closes #10

@zx96 thanks, for finding that out.
You may direct me to what flash was used so maybe this opcode can be decoded.


PLAT-29869: Create webOS Design Considerations for Enact

Issue Resolved / Feature Added
Added webOS Design Considerations doc
Links
PLAT-29869
Enyo-DCO-1.1-Signed-off-by: Dave Freeman<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Dave Freeman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Dave Freeman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Increased timeout to 16MB spiffs flash problem

When flashing an ESP32 with 16MB flash chip, during flash of spiffs partition (~13MB) there is a long delay when the first block is written. This causes a time-out and results in the flash failing. Increasing the DEFAULT_TIMEOUT value from 3000 to 40000 fixes this problem. I found that the actual delay is around 25 seconds so a timeout of 40 seconds seems reasonable and probably doesn't make the user experience too much worse in cases where communication really does break down.

Why not making this timeout depending on the binary size?

Released in ESP Web Flasher 5.1.4


Version command to output OpenShift version

/kind feature

Which functionality do you think we should add?
odo version to output openshift version
Why is this needed?
To determine/verify what openshift I am working with

This is a little bit problematic.
I don't know about a way to get the OpenShift version on OpenShift 4.x without kube:admin privileges. :-(


Gradle can finish  successfully even if test runs short circuit due to System.exit call

For context, I'm using Gradle 5.2.1 and Junit 4 though I'm fairly certain this issue exists with any combination of Gradle and Junit versions.
If the code under test being executed calls System.exit(0) at any point, the JVM used to run the tests cleanly exits. This means that depending on when the call happened, many tests may never be executed but you could still receive a successful build.
On the contrary, if System.exit(1) is called for example, Gradle fails the build and issues a warning that looks like this:
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':test'.
> Process 'Gradle Test Executor 1' finished with non-zero exit value 1
  This problem might be caused by incorrect test process configuration.
  Please refer to the test execution section in the User Manual at https://docs.gradle.org/5.2.1/userguide/java_testing.html#sec:test_execution

Expected Behavior
Even in the case of System.exit(0), Gradle fails the build seeing as all tests haven't executed. Ideally there is some mechanism to continue running tests or expecting the System.exit call (using something like https://github.com/stefanbirkner/system-rules) but that's not really Gradle's concern, as long as Gradle can help determine when these cases happen and avoid giving a successful build when the test task has only partially run.
Current Behavior
Tests will stop running after the first test which calls System.exit(0). If maxParallelForks is set to it's default of 1 this will mean that no other tests are run for this project.
Context
We have a very large, multi-project build and we've seen test failures which appeared to be flaky, but truly weren't. As it turned out these legitimate, consistently failing tests often never ran because at some point before them a test called System.exit(0) and Gradle reported the build as successful as all tests that had run up to that point succeeded. This is particularly troubling because, unless you know how many tests there are and specifically verify afterwards to make sure that number executed a build may seems "successful" to an engineer leading them to deploy their code but is in reality failing tests.
Steps to Reproduce (for bugs)
Simple repro can be found at https://github.com/seanabraham/system-exit-gradle-repro

Looks like there is a similar report at https://github.com/gradle/gradle/issues/3610


Network Data Collection

In the past, we have collected live data from validators and node operators to help us diagnose issues with a given network. We should extend this practice to not only collect data from our live networks, but also persist that data in some form, and ideally make it queryable. After consulting with @cmwaters and @staheri14, it seems clear that the best place to start is with existing tendermint metrics, and looking into either some sort of adapter to the existing prometheus endpoint, or a mechanism to scrape the prometheus server itself.
We might also want to think about mechanisms to collect even finer grained tracing level data in environments such as testground where we can have an omniscient view of the network. In a perfect world, we would also be able to use the same metrics level and trace level collection mechanisms in a live network and in testground.

[x] https://github.com/celestiaorg/celestia-core/issues/968

closing as essentially completed with https://github.com/celestiaorg/celestia-core/issues/968


🌐Make newsletter boilerplate text translatable.

no issue
This PR adds the ability to translate the strings that appear in the newsletter as boilerplate text, using i18next.
Variables are in single mustaches ( {date} ) in the translation strings (rather than {{date}}), because these strings occur both the email template.hbs and also .js files.  That necessitated a separate namespace.
Example usage - handlebars

{{t 'Keep reading'}}

{{{t 'By {authors}' authors=post.authors }}}

(triple { required because of possible & )
Example usage - javascript
                getValue: (member) => {
                    if (member.status === 'comped') {
                        return t('complimentary');
                    }
                    if (this.isMemberTrialing(member)) {
                        return t('trialing');
                    }
                    // other possible statuses: t('free'), t('paid') //
                    return t(member.status);
                }

TODO:  Images of text on buttons on desktop are not translatable.  (Mobile are fine.)

Definitely take what I said with a grain of salt! Someone should confirm my observations 🙈

@sanne-san , if you have time to look at this, I'd appreciate it! :)


Feature Request: MLOps Solution in Infra Catalog

(see lessons and reusable IP from Tony B. personalization project)

Auto-closed due to completion of #62. Awesome work, @jacksandom ! 🎉🎉🎉


Trying to make custom keybind behave like arrow keys

I set up some vim-like keybindings so I can move between files and folders. I did it like this:
[
        {
        "key": "k",
        "command": ["script-binding", "file_browser/dynamic/scroll_up"]
    },
    {
        "key": "j",
        "command": ["script-binding", "file_browser/dynamic/scroll_down"]
    },
    {
        "key": "h",
        "command": ["script-binding", "file_browser/dynamic/up_dir"]
    },
    {
        "key": "l",
        "command": ["script-binding", "file_browser/dynamic/down_dir"]
    }
]

But when I keep the key pressed it doesn't scroll like it does with arrow keys. I have to release the key and press it again to move down or up a list. Is it possible to make it behave like the default keys?

It is possible, you need to use the flags field.
It would look something like:
"flags": { "repeatable": true}

It is possible, you need to use the flags field.
It would look something like:
"flags": { "repeatable": true}

Worked perfectly. Thank you very much!


Integration with Microsoft Teams

Hello. I reviewed the project but did not see integration with Microsoft Teams. The Minimeet extension is only for Google Meet. How can this be achieved with Microsoft Teams?
Thank you very much for your time.

At the moment, only Google Meets is supported. This project mainly focuses on a browser-based video chatting, and Google Meets is a native browser-first experience. As such, all the Chrome Extension logic around authentication, finding and joining meetings is focused around Google authentication and Google Meet meetings.
It's theoretically possible to support Microsoft Teams meetings, but most likely that would have to be in the browser-version of Teams. I'm not sure how optimized Teams is for running in the browser (it may be too slow to run on a Raspberry Pi), or which features are available in the browser (e.g. finding and joining the next meeting). Either way, it would be a ton of work and require rewriting most of the minimeet extension and the other logic here.
So for now, you can just assume this is not supported. I also don't have any upcoming plans to add support for this myself. Your options are to either invest in a new project that supports Teams, or consider using Google Meets for your needs.


i can't find intercept_Core in wiki "Window Envionment Setup"

when i build the project Hello_Intercept and make .pbo file by following wiki "Windows Environment Setup" the aram3 launcher syas "Can't find addon Intercept_Core. " But i can't find any sign of Intercept_Core addition in wiki . Is there any help that i solve this problem?

sorry about my writing. i was in upset that spending this all day.

Also it is on the wiki.
Download and Install the Latest Release of Intercept -> Installation ->

The host mod: This allows our code to be injected into the Arma 3. This should be installed as an Arma 3 mod

oh... I missed that. tank you


Reusable Trufflehog Workflow

Type of Change

[ ] Bugfix
[x] Enhancement / new feature
[ ] Refactoring
[ ] Documentation

Description

[x] This workflow aims to automate repository secret scanning via Trufflehog. Here you can find an example, where the reusable secret scan is being used.

Checklist

[x] Add relevant labels (for example type of change or patch/minor/major)
[x] Make sure not to introduce some mistakes
[x] Update documentation
[x] Review the Contributing Guideline and sign CLA
[ ] Reference relevant issue(s) and close them after merging

"I have read the CLA Document and I hereby sign the CLA"

This workflow aims to automate repository secret scanning via Trufflehog. Here you can find an example, where the reusable secret scan is being used.

How is this different from GitHub Secret Scanning?

Trufflehog has so-called verifiers, that check if credentials are actually able to do a log in
It's open source
It'f free of charge in this setting


Review 4: SLURM parameters

SLURM parameters

You should scale the memory based on the number of files (not fixed 1G). Indeed the number of files a job process is not the same (memory consumption different for n_files<1000; <10000; <inf).
Same comment for the time

The reason I fixed the memory at 1G (if it isn't specified) is from doing tests of the memory usage with different number of subjects from ADHD200 and ABIDE, the memory usage was stable around 500MB regardless of the number of subjects as the script basically processes a subject writes the output to file and then frees up the memory. It could definitely use more extensive tests with large datasets though to see how it behaves then and set the memory accordingly.
The time does scale with n subjects, right now it's about 10s per subject (depending a bit on which batch).


Remove MariaDB CRD

openstack-k8s-operators now uses Galera exclusively for MySQL/MariaDB access, so the MariaDB CRD can be fully removed.

OK it looks like there are references to this from both install_yamls as well as openstack-operator, so I can't quite trace out how the build is failing but we would assume the openstack-operator build is somehow failing because things it expects to see have been removed from here.

/retest

this should be all set now

I'm wondering if this test helper needs to be change as well: https://github.com/openstack-k8s-operators/mariadb-operator/blob/4cd7b3f5eedec8fef56396cfb88f3cbd795dbb08/api/test/helpers/crd.go#L103C11-L152 as it refers to the code that looks for MariaDB CR by name
https://github.com/openstack-k8s-operators/mariadb-operator/blob/4cd7b3f5eedec8fef56396cfb88f3cbd795dbb08/api/v1beta1/mariadbdatabase_funcs.go#L79-L87

cc @dciabrin does this comment also apply to the Galera CR ?

I'm wondering if this test helper needs to be change as well: https://github.com/openstack-k8s-operators/mariadb-operator/blob/4cd7b3f5eedec8fef56396cfb88f3cbd795dbb08/api/test/helpers/crd.go#L103C11-L152 as it refers to the code that looks for MariaDB CR by name
https://github.com/openstack-k8s-operators/mariadb-operator/blob/4cd7b3f5eedec8fef56396cfb88f3cbd795dbb08/api/v1beta1/mariadbdatabase_funcs.go#L79-L87

cc @dciabrin does this comment also apply to the Galera CR ?

I think you are correct. The test helper will need to be updated. But the breakage wouldn't occur until renovate bumps up the mariadb-operator/api dependency right? So we could land this and gradually update the operators to use an equivalent Galera test helper gradually

I'm wondering if this test helper needs to be change as well: https://github.com/openstack-k8s-operators/mariadb-operator/blob/4cd7b3f5eedec8fef56396cfb88f3cbd795dbb08/api/test/helpers/crd.go#L103C11-L152 as it refers to the code that looks for MariaDB CR by name
https://github.com/openstack-k8s-operators/mariadb-operator/blob/4cd7b3f5eedec8fef56396cfb88f3cbd795dbb08/api/v1beta1/mariadbdatabase_funcs.go#L79-L87

cc @dciabrin does this comment also apply to the Galera CR ?

I think you are correct. The test helper will need to be updated. But the breakage wouldn't occur until renovate bumps up the mariadb-operator/api dependency right? So we could land this and gradually update the operators to use an equivalent Galera test helper gradually

still trying to understand the complete flow of this helper, I'm not yet seeing the "breakage" here since this helper seems to be in a closed loop against the local mariadb API in any case (comments are out of date since https://github.com/openstack-k8s-operators/lib-common/pull/352 occurred) but this seems to raise a bigger issue which is that the mariadbv1.Database API is what all the services are using to create databases, and that's not yet integrated with the new MariaDBAccount thing I just merged, seems like it should be.

I'm wondering if this test helper needs to be change as well: https://github.com/openstack-k8s-operators/mariadb-operator/blob/4cd7b3f5eedec8fef56396cfb88f3cbd795dbb08/api/test/helpers/crd.go#L103C11-L152 as it refers to the code that looks for MariaDB CR by name

cc @dciabrin does this comment also apply to the Galera CR ?

Labeling shouldn't change, the Galera CR and the MariaDB CR both use the same labels so clients looking for the database service don't need to treat MariaDB and Galera separately. Back when this was introduced, the only component that would distinguish those two CR was the MariaDBDatabase controller.
So I would say this labeling should all be internal, and no change is needed. If we want to revisit later and replace references to mariadb by galera, this can be done in another PR.

I've deployed openstack locally using this version of the operator, there's no MariaDB crd in the cluster at all and everything is running fine
$ oc get crds | grep mariadb
galeras.mariadb.openstack.org                                     2024-01-11T16:21:22Z
mariadbaccounts.mariadb.openstack.org                             2024-01-11T16:21:22Z
mariadbdatabases.mariadb.openstack.org                            2024-01-11T16:21:22Z

[classic@hab-11 install_yamls]$ oc get pods
NAME                           READY   STATUS    RESTARTS      AGE
ceilometer-0                   3/3     Running   0             24m
cinder-api-0                   2/2     Running   0             20m
cinder-scheduler-0             2/2     Running   0             20m
dnsmasq-dns-69cb44859d-gcjgb   1/1     Running   0             16m
glance-default-single-0        3/3     Running   0             24m
keystone-6d94d9cd4-794x5       1/1     Running   0             23m
memcached-0                    1/1     Running   0             30m
neutron-84f6b4848c-gcjwz       2/2     Running   0             17m
nova-api-0                     2/2     Running   0             15m
nova-cell0-conductor-0         1/1     Running   0             17m
nova-cell1-conductor-0         1/1     Running   0             15m
nova-cell1-novncproxy-0        1/1     Running   0             17m
nova-metadata-0                2/2     Running   0             15m
nova-scheduler-0               1/1     Running   0             15m
openstack-cell1-galera-0       1/1     Running   0             30m
openstack-galera-0             1/1     Running   0             30m
openstackclient                1/1     Running   0             21m
ovn-controller-5gzth           3/3     Running   0             30m
ovn-northd-79cf7987f5-54jjw    1/1     Running   0             27m
ovsdbserver-nb-0               1/1     Running   0             30m
ovsdbserver-sb-0               1/1     Running   0             30m
placement-7444b6685d-nhf8k     2/2     Running   0             21m
rabbitmq-cell1-server-0        1/1     Running   0             30m
rabbitmq-server-0              1/1     Running   1 (27m ago)   30m
swift-proxy-549bcf8f4d-t9jmh   3/3     Running   0             24m
swift-storage-0                16/16   Running   0             30m

/lgtm

waiting on @dciabrin  to /approve

/approve


Add missing task and DAG args from the newer Airflow versions

Airflow has added new DAG and task args which are currently not supported by airflow-declarative.
Relevant Airflow docs:

https://airflow.apache.org/docs/stable/_api/airflow/models/index.html#airflow.models.DAG
https://airflow.apache.org/docs/stable/_api/airflow/models/index.html#airflow.models.BaseOperator

I checked only the tags field (I don't need the other ones) -- it works fine.

LGFM. Could you please fix CI issues before merge?

Tests were failing due to some changes in Airflow master. I have just pushed the fixes, tests should pass now.

:beer:


added support for fine grained tokens

Hey 👋
Have been trying out the beta fine grained tokens.
This adds support for fine grained tokens by:

adding an optional IS_FINE_GRAINED boolean flag so it can change the clone url to be<EMAIL_ADDRESS>
May be better way to do this so happy to see suggestions. Let me know I missed anything. Should be a non breaking change!

I just tried this out and it works well.


This mod makes lan not games not work

trying to join a lan world with this mod gives "io.netty.handler.codec.DecoderException: java.lang.IllegalArgumentException: Unknown recipe serializer minecraft:nether_wart_block" and makes joining lan worlds impossible
Minecraft 1.20.4
Fabric loader 0.15.1
Fabric api 0.91.2+1.20.4
Redstone pen 1.8.25

Hi, ty for the hint let me take a look what's going on there. Recipe serializer nether_wart_block sounds very strange ;)

Oky, was reproducible and could be fixed. The file is in approval on Curse, the file on Modrinth is already up: https://modrinth.com/mod/redstonepen/version/1.8.26. Cheer's;


Fix for #154 test config

Based on #174 (please merge before this one)
Fixes #154 and other minor issues
Gollum -tc not working was caused by a bug in the check for a missing config file.
Some minor cleanup and a regression fix for gollum -v is contained, too.

Coverage decreased (-0.008%) to 65.447% when pulling 0bd6c93de0618df503fc3bb376f428ab256774af on fix/154_TestConfig into 0f71ba3de1ad9d1e5ad50864722e57f7f74cf0c5 on master.

Coverage decreased (-0.008%) to 65.447% when pulling f7139f1d97d1ad71da76f10685b9d114e0adf91a on fix/154_TestConfig into 0f71ba3de1ad9d1e5ad50864722e57f7f74cf0c5 on master.

Coverage remained the same at 65.447% when pulling 6a99f0cb0a13385505137682301c8657eac03fb7 on fix/154_TestConfig into 9186cab925912c972c7d702ee9268764555b8723 on master.


Is there a way to run a custom query within the model?

Am I missing something or is there a way to run a custom query in the model itself? In the same way as would be done in CakePHP?
ie:
$someModelData = $this->query("SELECT * FROM wp_users");
Or run the $this->SomeOtherModel->find() within the model?
Or is it expected to fall back to the Wordpress way using $wpdb?
Cheers

I have been using global $wpdb but would welcome a pull request for $this->prepare() and $this->query() that passes through to $wpdb (maybe with substitution of {prefix} on table names).
In the case of $model->SomeOtherModel->find() I have instead been creating classes that do not inherit MvcModel to use the data mapper pattern (instead of the active record approach in current models), and this works quite well.


Hangs on additional asset processing

Works fine without babili-webpack-plugin
Repro:
git clone https://github.com/damianobarbati/mdi/tree/v1.0.14
yarn install
yarn build:prod

Can anybody help here?
I did set up a very simple repro: all is needed to investigate is a clone, install and yarn build:prod
https://github.com/damianobarbati/mdi/tree/v1.0.20
😞

I have the same problem :(

can you help us @d3viant0ne?

@damianobarbati what is exactly hangs in additional asset?

I mean the webpack step  additional asset processing
Here the full output for reference.
Thanks for helping @evilebottnawi :)
imac:mdi damz$ yarn build:prod
yarn build:prod v0.24.6
$ NODE_ENV=production webpack --config ./config/webpack.config.js --progress
clean-webpack-plugin: /Users/damz/Desktop/mdi/build has been removed.
clean-webpack-plugin: /Users/damz/Desktop/mdi/dist has been removed.
 10% building modules 0/1 modules 1 active ...!/Users/damz/Desktop/mdi/src/index.jskeyword select requires $data option
babel-preset-env: `DEBUG` option

Using targets:
{
  "chrome": "59"
}

Modules transform: false

Using plugins:

Using polyfills:
  web.timers {"chrome":"59"}
  web.immediate {"chrome":"59"}
  web.dom.iterable {"chrome":"59"}
[BABEL] Note: The code generator has deoptimised the styling of "/Users/damz/Desktop/mdi/src/index.js" as it exceeds the max of "500KB".
 91% additional asset processing

@damianobarbati very strange, wip

@damianobarbati Which command to run to reproduce problem?

git clone https://github.com/damianobarbati/mdi
cd mdi
yarn install
yarn build #here I'm downloading some stuff to build the src/index.js and svg files
yarn build:prod #here webpack is fired

@damianobarbati in next please describe this steps in readme, thanks

Got it, sorry for the current broken readme: fixing in next push

@damianobarbati using your steps, my output:
yarn build:prod v0.23.2
$ NODE_ENV=production webpack --config ./config/webpack.config.js --progress
clean-webpack-plugin: /home/evilebottnawi/IdeaProjects/mdi/build has been removed.
clean-webpack-plugin: /home/evilebottnawi/IdeaProjects/mdi/dist has been removed.
 10% building modules 0/1 modules 1 active ...ottnawi/IdeaProjects/mdi/src/index.jskeyword select requires $data option
babel-preset-env: `DEBUG` option

Using targets:
{
  "chrome": "59"
}

Modules transform: false

Using plugins:

Using polyfills:
  web.timers {"chrome":"59"}
  web.immediate {"chrome":"59"}
  web.dom.iterable {"chrome":"59"}                                           Hash: 38ead94a9b51b36ad883
Version: webpack 3.4.1
Time: 897ms
               Asset       Size  Chunks             Chunk Names
   dist/index.min.js  735 bytes       0  [emitted]  main
dist/index.min.js.gz  378 bytes          [emitted]
   [0] ./src/index.js 0 bytes {0} [built]
Done in 1.91s.

@damianobarbati Can your provide your nodejs version?

Sure thing.
imac:mdi damz$ node -v
v8.2.1
imac:mdi damz$ cat package.json
{
    "name": "@damianobarbati/mdi",
    "version": "1.0.20",
    "license": "MIT",
    "author": "Damiano Barbati<EMAIL_ADDRESS>(http://github.com/damianobarbati)",
    "main": "src/index.js",
    "module": "src/index.js",
    "jsnext:main": "src/index.js",
    "scripts": {
        "jslint": "eslint **/*.js --ignore-path .gitignore --ignore-pattern **/*.min.js .",
        "build:dev": "NODE_ENV=development webpack --config ./config/webpack.config.js --progress --watch",
        "build:stg": "NODE_ENV=staging webpack --config ./config/webpack.config.js --progress",
        "build:prod": "NODE_ENV=production webpack --config ./config/webpack.config.js --progress",
        "build": "sh build.sh",
        "build2": "sh build2.sh"
    },
    "browserlist": [
        "chrome 59"
    ],
    "eslintConfig": {
        "parser": "babel-eslint",
        "parserOptions": {
            "ecmaVersion": 2017,
            "sourceType": "module",
            "impliedStrict": true,
            "ecmaFeatures": {
                "jsx": true,
                "impliedStrict": true,
                "globalReturn": false,
                "experimentalObjectRestSpread": true
            }
        },
        "env": {
            "browser": true,
            "node": true,
            "jest": true,
            "es6": true
        },
        "plugins": [
            "import",
            "react",
            "jest"
        ],
        "extends": [
            "eslint:recommended",
            "plugin:react/recommended",
            "plugin:jest/recommended"
        ],
        "rules": {
            "no-console": "off",
            "no-unused-vars": "off",
            "no-unsafe-finally": "off",
            "no-unreachable": "off",
            "react/no-unescaped-entities": "off",
            "react/no-children-prop": "off"
        }
    },
    "babel": {
        "presets": [
            [
                "env",
                {
                    "targets": {
                        "browsers": [
                            "chrome 59"
                        ]
                    },
                    "modules": false,
                    "useBuiltIns": true,
                    "debug": true
                }
            ],
            "stage-0",
            "react"
        ],
        "plugins": [
            "transform-decorators-legacy",
            "transform-class-properties",
            [
                "react-css-modules",
                {
                    "filetypes": {
                        ".scss": {
                            "syntax": "postcss-scss"
                        }
                    }
                }
            ]
        ]
    },
    "peerDependencies": {
        "material-ui": "1.0.0-beta.2",
        "react": "^15.6.1"
    },
    "dependencies": {
        "babel-eslint": "^7.2.3",
        "babel-loader": "^7.0.0",
        "babel-plugin-react-css-modules": "^3.0.0",
        "babel-plugin-transform-class-properties": "^6.24.1",
        "babel-plugin-transform-decorators-legacy": "^1.3.4",
        "babel-preset-env": "^1.5.1",
        "babel-preset-latest": "^6.24.1",
        "babel-preset-react": "^6.24.1",
        "babel-preset-stage-0": "^6.24.1",
        "babili-webpack-plugin": "^0.1.1",
        "case-sensitive-paths-webpack-plugin": "^2.1.1",
        "clean-webpack-plugin": "^0.1.16",
        "compression-webpack-plugin": "^1.0.0",
        "eslint": "^4.1.1",
        "eslint-loader": "^1.7.1",
        "eslint-plugin-import": "^2.3.0",
        "eslint-plugin-jest": "^20.0.3",
        "eslint-plugin-react": "^7.0.1",
        "file-loader": "^0.11.1",
        "glob": "^7.1.2",
        "lodash": "^4.17.4",
        "prop-types": "^15.5.10",
        "string-replace-loader": "^1.3.0",
        "webpack": "^3.0.0"
    }
}

But @evilebottnawi I'm checking the commands because this is impossible: 3mb of svg files emitted in ~800bytes?
Did you run yarn build before yarn build:prod? :|

My current output with the steps => 🤔

imac:Desktop damz$ git clone https://github.com/damianobarbati/mdi
Cloning into 'mdi'...
remote: Counting objects: 11549, done.
remote: Total 11549 (delta 0), reused 0 (delta 0), pack-reused 11549
Receiving objects: 100% (11549/11549), 6.67 MiB | 2.71 MiB/s, done.
Resolving deltas: 100% (8608/8608), done.
imac:Desktop damz$ cd mdi/
imac:mdi damz$ yarn install
yarn install v0.24.6
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
✨  Done in 4.64s.
imac:mdi damz$ yarn build
yarn build v0.24.6
$ sh build.sh
Cloning into 'material-design-icons'...
remote: Counting objects: 42051, done.
remote: Compressing objects: 100% (32101/32101), done.
remote: Total 42051 (delta 10321), reused 40199 (delta 9947), pack-reused 0
Receiving objects: 100% (42051/42051), 15.54 MiB | 3.46 MiB/s, done.
Resolving deltas: 100% (10321/10321), done.
Checking out files: 100% (90943/90943), done.
Cloning into 'MaterialDesign'...
remote: Counting objects: 4183, done.
remote: Compressing objects: 100% (3202/3202), done.
remote: Total 4183 (delta 1078), reused 4007 (delta 979), pack-reused 0
Receiving objects: 100% (4183/4183), 4.52 MiB | 2.62 MiB/s, done.
Resolving deltas: 100% (1078/1078), done.
mkdir: icons: File exists
yarn install v0.24.6
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
✨  Done in 2.41s.
./material-design-icons/action/svg/production/ic_3d_rotation_24px.svg Action3DRotation
./material-design-icons/action/svg/production/ic_accessibility_24px.svg ActionAccessibility
etc etc etc
✨  Done in 35.50s.
imac:mdi damz$ yarn build:prod
yarn build:prod v0.24.6
$ NODE_ENV=production webpack --config ./config/webpack.config.js --progress
clean-webpack-plugin: /Users/damz/Desktop/mdi/build has been removed.
clean-webpack-plugin: /Users/damz/Desktop/mdi/dist has been removed.
 10% building modules 0/1 modules 1 active ...!/Users/damz/Desktop/mdi/src/index.jskeyword select requires $data option
babel-preset-env: `DEBUG` option

Using targets:
{
  "chrome": "59"
}

Modules transform: false

Using plugins:

Using polyfills:
  web.timers {"chrome":"59"}
  web.immediate {"chrome":"59"}
  web.dom.iterable {"chrome":"59"}
 70% building modules 3026/3026 modules 0 active

@damianobarbati yarn build
yarn build v0.23.2
$ sh build.sh
Cloning into 'material-design-icons'...
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
Cloning into 'MaterialDesign'...
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
mkdir: cannot create directory ‘icons’: File exists
yarn install v0.23.2
[1/4] Resolving packages...
warning Integrity check: Lock files don't match
[2/4] Fetching packages...
warning<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
[4/4] Building fresh packages...
Done in 2.85s.
failed []
Done in 6.20s.

I don't know what's going on with github today, anyway it's not allowing you to download the public repo with icons =>
Permission denied (publickey).
fatal: Could not read from remote repository.

And it's not letting me push new commits throwing errors about authentication.
You should have the /icons folder in place anyway and yarn build:prod should build the dist file: but it's huge, definitely can't be 800bytes!

@damianobarbati can your change src/index.js to one line export Action3DRotation from '../icons/Action3DRotation'; and try to build?

@damianobarbati Reproduced, looking for a problem

Great! I did some test, with a bunch of lines it is indeed working: once they're more then ~100 (?) it starts hanging :)

@damianobarbati seems nothing is hands, using 1000 modules i have 195.32s. with disabled source maps

@evilebottnawi I have the sourcemaps disabled as well but it never ends the compilation.
Right now it has been stuck at 91% for about 22minutes (since I tried the 1000 and then the full 3000 list).
I'm afraid it's not linear the time required (1k ~ 1min => 3k ~ 3min) but it simply hangs.
And I'm on a 2017 iMac with maxed out "3,6 GHz Intel Core i7-7700" cpu :(

Did you try to compile the full list?
And thanks again for your efforts 🤗

@damianobarbati i have very power machine in my office Intel Xeon E5-2699 v4 @ 2.20GHz 2k icons compiling ~25 min :smile: Seems 3k have ~60-120 min, yep not linear, I think your should search other solution for your purpose, this is not acceptable :disappointed:

oh no... 😔

@damianobarbati in other hand your can search way to fix performance in babel plugins, but it is hard way :smile:

@damianobarbati right now my machine is done build:
    + 3000 hidden modules
Done in 1181.66s.

real    19m42,102s
user    19m40,280s
sys     0m2,004s

@damianobarbati seems babel plugins for minify have bad performance, your can try uglify-es plugin, maybe it is be more faster. I can not do anything else here, I'm sorry.

@evilebottnawi thanks so much for investigating this: at least I know it's just about horse power right now.
I'll try to leave it the whole night compiling, I always killed it in 30-45mins supposing it was stuck.
"sadly" closing this T_T

I still think there is a bug somewhere. In my project webpack hangs too, but if I kill the process and check the dist folder, all files seem to be minified

@wasd171 please provide minimum reproducible test repo? But seems problems not in babili-webpack-plugin, most likely somewhere in babel plugins.

I don't have any other babel plugins. The repo: https://github.com/wasd171/prettier-chrome
Uncomment line https://github.com/wasd171/prettier-chrome/blob/master/webpack.config.js#L29 in webpack.config.js and run npm install && npm run build:prod

@wasd171 i will try this in near future, thanks!

@evilebottnawi I managed to compile (~37mins -_-")!
But now how do I exclude that module (already published compiled) from being processed again from Babili plugin in the project including it? :|

@damianobarbati https://github.com/webpack-contrib/babili-webpack-plugin/issues/50?

Below settings helped me to reduce the heap memory since it will not include the sourceMap file.
devtool: false, // Webpack.

new webpack.optimize.UglifyJsPlugin({
   sourceMap: shouldUseSourceMap
}),

or below code will help for latest webpack uglify plugin.
> npm install uglifyjs-webpack-plugin --save-dev

// conf.js
const UglifyJsPlugin = require('uglifyjs-webpack-plugin');
module.exports = {
  optimization: {
    minimizer: [
      new UglifyJsPlugin({
        sourceMap: true,
      }),
    ],
  },
};

If this still not help to fix the problem. below command helps to increase heap memory and answer link to know more about heap memory is below as well.
node --max-old-space-size=16000 scripts/build.js

https://stackoverflow.com/a/57480923/1533666


Why does the policy loss not decrease but increase?

I executed the run_continuous.py file for the continuous agent and found that the policy loss increased approximately linearly with training episodes until it stabilized. Why is the policy loss not reduced?
And I tried to tune some hyperparameters, such as n_rollouts and hidden_dimensions, but it did not work to reduce the policy loss.  The episode reward also didn't improve further over the course of the training.  So is that a normal phenomenon for this repo?

What episode reward does your agent finally reach?
What version of gym are you using (are you using the package versions from this repo's conda env)?
Are you using a normally distributed policy or the Beta distribution policy?

Honestly it's been so long since I worked with this code that I can't say too much.
Here's a link to some loss plots from a report I made back then. Maybe you can compare to those and diagnose a bit what doesn't work for you:
https://wandb.ai/timo_kk/a0c/reports/A0C-loss-vs-A0C-Q-loss--VmlldzoyNTA3ODQ?accessToken=wzwqwdv9sku8l90i3gyufgrwb7go5uzxt3pbxommmovakhs9w52tpdexnm3r87ow
Here's a set of parameters from a run that worked:
Agent epsilon greedy:
  desc: null
  value: 0
Batch size:
  desc: null
  value: 32
Clamp log param:
  desc: null
  value: true
Clamp loss:
  desc: null
  value: Loss scaling
Date:
  desc: null
  value: '2020-12-22 08:16:39'
Discount factor:
  desc: null
  value: 1
Distribution:
  desc: null
  value: Squashed Normal
Environment:
  desc: null
  value: Pendulum-v0
Environment seed:
  desc: null
  value: 34
Episode length:
  desc: null
  value: 200
Final selection policy:
  desc: null
  value: max_visit
LayerNorm:
  desc: null
  value: false
Learning rate:
  desc: null
  value: 0.001
Log counts scaling factor [tau]:
  desc: null
  value: 0.1
Log prob scale:
  desc: null
  value: Corrected entropy
Loss lr:
  desc: null
  value: 0.001
Loss reduction:
  desc: null
  value: mean
Loss type:
  desc: null
  value: A0C loss tuned
MCTS epsilon greedy:
  desc: null
  value: 0
MCTS rollouts:
  desc: null
  value: 25
Network hidden layers:
  desc: null
  value:
  - 128
  - 128
  - 128
Network hidden units:
  desc: null
  value: 3
Network nonlinearity:
  desc: null
  value: elu
Num mixture components:
  desc: null
  value: 2
Optimizer:
  desc: null
  value: Adam
Policy coefficient:
  desc: null
  value: 0.1
Progressive widening exponent [kappa]:
  desc: null
  value: 0.5
Progressive widening factor [c_pw]:
  desc: null
  value: 1
Replay buffer size:
  desc: null
  value: 3000
Target entropy:
  desc: null
  value: -1
Training episodes:
  desc: null
  value: 45
Training epochs:
  desc: null
  value: 1
UCT constant:
  desc: null
  value: 0.05
V target policy:
  desc: null
  value: off_policy
Value coefficient:
  desc: null
  value: 1
Weight decay:
  desc: null
  value: 0.0001
_wandb:
  desc: null
  value:
    cli_version: 0.10.12
    framework: torch
    is_jupyter_run: false
    is_kaggle_kernel: false
    python_version: 3.8.5

@cz11233, just one thing to mention --- In the context of reinforcement learning, policy loss is not a good measurement.  Because every time a policy is improved, a better TARGET policy is produced, too. That means there is always a gap between the policy(model) to be trained and the target policy.
But if the episode return is not improving after long training, this could be the case.
As for me,  I've been in a kind of situation that... an RL algorithm never gets improved after I checked every detail of the algorithm. But finally, it gets improved by making a full-connected layer output from 64 to 256.

@timoklein  Well, I know what the problem is, I shouldn't have used beta distribution. So do you know why it doesn't work?
Besides, in your paper "Combining Reinforcement Learning and Search for Cooperative Trajectory Planning", I noticed that the loss plots are given in Figure 30, where the policy loss decreases consistently, neither rising nor flattening. Is this due to the network of the paper being different from this repo? Or is it something else, e.g. multi_agent?

@dbsxdbsx  Thanks for your answer, it solves my puzzle about the policy loss

I shouldn't have used beta distribution. So do you know why it doesn't work?

It might just be that I implemented it wrong. I wrote some tests for my thesis, the outputs etc. were in line but it never learned anything. Since the other policies worked, I pursued them further.

Is this due to the network of the paper being different from this repo?

I would think so. The architecture is totally different (way larger model). If I remember correctly, the policy loss would also plateau if you ran it further due to the reason outlined by @dbsxdbsx .


No fulltext search for the writing style guide?

I'd like to search the style guide for certain terms. I don't recognize a full-text search option. The search button on top searches all of Microsoft.
For me the full-text search is the by far the most important feature. Do I miss something?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 590ef2fd-0b1a-a2e0-d6a5-109f997f1db7
Version Independent ID: 913df696-e028-f6b4-2a41-f203798badb0
Content: Microsoft Writing Style Guide Released
Content Source: teamblog/style-guide.md
Product: team-blog
GitHub Login: @dend
Microsoft Alias: danielfe

Hello! The writing style guide now has a search scope, that should limit the search exclusively to the guide:


Vaadin 24 support

Are there any plans to support Vaadin 24?

Hi, thanks for the interest in the project!
Support for Vaadin 24 is on the to-do list, but development has not yet started.
It will require a huge refactoring, so I currently do not have an indication of when it could be ready.

The development branch is now updated to Vaadin 24.3.
A first alpha version (24.3.0-alpha1) is available on maven central.
@arouel I'll close the issue. If you have any questions, please comment here or create a new ticket.


Add an deactivate option to the notification system

There isn't an option to deactivate the notification once one has finished the downtime. Therefore the notification needs to be delete it instead.
One way to fix the issue would be to set an hour for the notification to expire, but it can be a problem with the time stamp in the server. Might be simpler to just had an active/inactive flag that can be changes as needed.

Waiting til Wednesday to merge to run Mart through process

Brian will take a look and review this.

All works fine. Closing out


Actor.reboot() doesn't work

Actor.reboot() fails because it doesn't pass in the old Actor's input to the new one. Thus, if the actor requires any input, it fails and puts the original actor in a weird state.
The workaround is to do this:
a = Actor._get_default_instance()
await Actor.metamorph(a._config.actor_id, actor_input)
But this isn't ideal, so please either pass the old input to the new actor or have a parameter in reboot() in which we can pass the input.

Hello @ramicaza,
I would like to thank you for reporting this bug.
We'll look into the problem as soon as possible.
Cheers,
Jiri

@jirimoravcik is this something @vdusek can help with?

@jirimoravcik is this something @vdusek can help with?

Hey, currently, I'm adding a new API endpoint for the reboot. When this is done, we'll need to add a call to that endpoint to both our clients and then propagate them to SDKs. I think that would be a great task for @vdusek
I'll ping you when I finish the platform side and we'll discuss how to proceed from there!

Closing the issue since the Actor.reboot method was fixed in the https://github.com/apify/apify-sdk-python/issues/101 and a new version of the SDK was release - https://pypi.org/project/apify/1.1.3/.


Missing function call for docs for deprecated routes

This is minor issue in example documentation for deprecated routes.
Ref: Deprecating routes
@app.route("/")
@deprecate # missing call
async def index():
    ...

Fixed, it should be called without the parenthesis.


Does seaweedfs version 2.0 and after support ipv6?

Does seaweedfs version 2.0 and after support ipv6?

no


Crashing when i try to recreate android sample project

i ran into difficulties while running samples (get some errors when start scripts and some files desn't generated) and made a decision to make a new project by implementing lib and using samples code. But i alsways get a crash on v-1.5.1:

Build fingerprint: 'Xiaomi/cancro_wc_lte/cancro:6.0.1/MMB29M/V<IP_ADDRESS>.MXDMIFA:user/release-keys'
Revision: '0'
ABI: 'arm'
pid: 6194, tid: 6194, name: example.qweqwe2  >>> com.example.qweqwe2 <<<
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x88
r0 00000000  r1 00000000  r2 00000000  r3 9ea268f0
r4 9ec6e070  r5 00000014  r6 9ec6e070  r7 bec70c68
r8 9ec5e0d8  r9 9ec5e0a0  sl 9ec5e0fc  fp 00000000
ip 00000018  sp bec70bec  lr b33949ef  pc b339cbb6  cpsr 60000830
backtrace:
#00 pc 00024bb6  /data/app/com.example.qweqwe2-1/lib/arm/libgltfio-jni.so
Early i try v-1.4.5 and get that on the same code:
java.lang.UnsatisfiedLinkError: dlopen failed: cannot locate symbol "__aeabi_memmove4" referenced by "/data/app/com.example.qweqwe2-2/lib/arm/libfilament-utils-jni.so"
Сan anyone explain what I'm doing wrong

Sorry for the trouble, we're looking into it.  This is a dup of #2319.

Closing as duplicate.

@arctic4x What version of Android are you seeing the crash on btw?

Actually @prideout this looks like a different problem. __aeabi_memmove4 is missing because the ABI for it changed in API 21.
@arctic4x Did you build the libraries yourself or are you using the ones we provide already compiled?

See https://github.com/android/ndk/issues/126 for more info.

Actually @prideout this looks like a different problem. __aeabi_memmove4 is missing because the ABI for it changed in API 21.
@arctic4x Did you build the libraries yourself or are you using the ones we provide already compiled?

I implement libs in gradle dependencies, Should i build filament anyway?

@arctic4x What version of Android are you seeing the crash on btw?

version - 24
device - xiomi mi4w

Thanks, we'll look into this.

Could you please show me your Gradle file? I've been looking at this error with the NDK folks and the only thing we can think of is an issue with the device. The symbol has always been present.

We double checked and at this point it does look like an issue with your device. Would you be able to run readelf on your device's libc? We'd like to check if the symbol is missing.

From what @arctic4x said in the #2337 description, it sounds like we can close this particular issue?

Seems like it.


HolderNames

It looks that holdernames ( tested with a visa credit card ) and PC/SC always are returned as null  ( cc number & expiration data ok )  . I know the holdernames cant be read via nfc, but commonly with pc/sc  the holdername is got reading the application ( tested for example with very old libraries https://github.com/sasc999/javaemvreader )

The EMVParsers calls to

byte[] info = template.get().getProvider()
  						            .transceive(new CommandApdu(CommandEnum.READ_RECORD, index, afl.getSfi() << 3 | 4, 0).toBytes());

After  Calls to  byte[] cardHolderByte = TlvUtil.getValue(pData, EmvTags.CARDHOLDER_NAME), but always returns null.

Any idea or way to get the holder name ? Thank u in advance!

It looks that holdernames ( tested with a visa credit card ) and PC/SC always are returned as null ( cc number & expiration data ok ) . I know the holdernames cant be read via nfc, but commonly with pc/sc the holdername is got reading the application ( tested for example with very old libraries https://github.com/sasc999/javaemvreader )

The EMVParsers calls to

byte[] info = template.get().getProvider()
  						            .transceive(new CommandApdu(CommandEnum.READ_RECORD, index, afl.getSfi() << 3 | 4, 0).toBytes());

After  Calls to  byte[] cardHolderByte = TlvUtil.getValue(pData, EmvTags.CARDHOLDER_NAME), but always returns null.

Any idea or way to get the holder name ? Thank u in advance!

Hello, I wonder if your problem has been solved? I also have this problem. I look forward to your reply


Should strategy names be shortened?

The naming pattern for the original few strategies was RemovePodsViolating... and this pattern has since drifted in some strategies (RemoveDuplicates, PodLifeTime, LowNodeUtilization) which raises the question, is the "RemovePods" prefix necessary?
It seems implied that each strategy will be removing pods that violate some constraint, so for ease of readability and config it might be worth it to remove the prefix from the existing strategies (possibly still supporting the old names for compatibility).
It may not be a big enough issue to change old strategy names, but we should consider setting a precedent of whether or not this is necessary for future strategies. Open to any feedback on this!
/kind cleanup

/remove-lifecycle stale

This can be targetted for the v2alpha version bump.
RemoveDuplicates ==> Duplicates
LowNodeUtilization
HighNodeUtilization
RemovePodsViolatingInterPodAntiAffinity ==> PodsViolatingInterPodAntiAffinity
RemovePodsViolatingNodeAffinity ==> PodsViolatingNodeAffinity
RemovePodsViolatingNodeTaints ==> PodsViolatingNodeTaints
RemovePodsViolatingTopologySpreadConstraint ==>PodsViolatingTopologySpreadConstraint
RemovePodsHavingTooManyRestarts ==> PodsHavingTooManyRestarts
PodLifeTime
Agree that the prefix Remove is inherently implied that the strategy is going to remove pods

@hanumanthan I would go a step further and drop all the redundant prefixes, not just Remove, so eg
RemovePodsViolatingInterPodAntiAffinity => InterPodAntiAffinity
RemovePodsViolatingNodeAffinity => NodeAffinity
... etc
the question is if we actually want to do this. I don't think it needs to be strictly tied to an API version, as we could easily just code a translation layer in the config parsing logic. But it will eventually be breaking when we remove that layer

From RemovePodsViolatingNodeTaints:
Summarizing:

descheduler never removes a pod, it only evicts one => Remove keyword can be drop
descheduler always evicts pods only => Pods keyword is redundant
taints are always present on nodes only => should we drop Node keyword?

Turning the name into ViolatingTaints. Checking naming under https://github.com/kubernetes/kubernetes/tree/master/pkg/scheduler/framework/plugins and https://github.com/kubernetes-sigs/scheduler-plugins/tree/master/pkg many plugins mentions a feature. E.g.
nodeaffinity, podtopologyspread, coscheduling, crossnodepreemption, podstate. Given we are checking against certain features, we might follow the same pattern. E.g. Taints, NodeAffinity, TopologySpreadConstraint (given all  plugin are evicting pods "violating" some constraint we can leave out Violating keyword as well). Turning all plugin names into:

duplicates
failedpods
nodeaffinity (https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#affinity-and-anti-affinity)
taints (https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/)
interpodantiaffinity (https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#inter-pod-affinity-and-anti-affinity)
podlifetime
toomanyrestarts
topologyspreadconstraint (https://kubernetes.io/docs/concepts/scheduling-eviction/topology-spread-constraints/)
nodeutilization

Plugins such as nodeaffinity, taints, interpodantiaffinity and topologyspreadconstraint operator with known features. In the remaining cases it's up to us to choose the naming.


issue #5: Move files in a specific directory

Hey @ADITYADAS1999,
I hope this message finds you well. I have made the necessary changes by creating a new directory at the root and moving the specified files into it.
I'm eager to hear back from you and welcome any feedback you may have.
Thank you!

Hey @ADITYADAS1999,
I hope this message finds you well. I have made the necessary changes by creating a new directory at the root and moving the specified files into it.
I'm eager to hear back from you and welcome any feedback you may have.
Thank you!

Thanks for the PR @Subham5401
It's all looking good


Removed write_plots and write_netcdf in some python diagnostics

This PR deprecates the options write_plots and write_netcdf for some python diagnostics (the ones I coded) and for some tests. I successfully tested all affected recipes after the change.

Addresses #2005

Before you get started

[x] ☝ Create an issue to discuss what you are going to do

Checklist
It is the responsibility of the author to make sure the PR is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[x] 🛠 PR has a descriptive title for the changelog
[x] 🛠 Code follows the style guide
[x] 🛠 Documentation is available
[x] 🛠 YAML files pass pre-commit or yamllint checks
[x] 🛠 Circle/CI tests pass
[x] 🛠 Codacy code quality checks pass
[x] 🛠 Documentation builds successfully on readthedocs

To help with the number pull requests:

🙏 We kindly ask you to review two other open pull requests in this repository

Would it make sense to replace the word 'Deprecated' in the title with the word 'Remove'?
It would be good if you could mention in the pull request description which recipes are affected by these changes, that will make it easier to find where things went wrong if something turns out to be broken later.

Code changes look good to me, but I do not have time to test these recipes. Do you think we could run some of them with the @esmvalbot? If not, do you think it would be OK to merge this as is, since we plan to test recipes for the release anyway?

I tested all recipes, but I will run some (which do not require lots of memory) with the bot. So merging should be safe.

Would it make sense to replace the word 'Deprecated' in the title with the word 'Remove'?

Done

It would be good if you could mention in the pull request description which recipes are affected by these changes, that will make it easier to find where things went wrong if something turns out to be broken later.

This is the list:

recipe_ecs.yml
recipe_tcr.yml
recipe_cox18nature.yml
recipe_flato13ipcc.yml
recipe_schlund20jgr_*.yml

@bouweandela did you see this comment?

@esmvalbot Please run recipe_cox18nature.yml

@esmvalbot Please run recipe_tcr.yml

@esmvalbot Please run recipe_ecs.yml

The bot failed due to missing data, but the recipe ran fine on my machine