Add path check

Coverage increased (+0.01%) to 47.427% when pulling 1e6e7c9ab415e8a7ab2cb06cf3024be0dda3c60f on SirmaITT:bugfix/fix_bounds into cdba870cfbf1ea8afeeadd22af7b46dc609f99b1 on IIIF:release2.1.


runtime: []byte(str) occasionally causes a panic

Go version
go1.9.2
Output of go env in your module/workspace:
Running in production environment, on Linux system, in binary mode.

What did you do?
In the program, using the mgo package to convert a struct to BSON format data is causing a panic.
This issue has occurred for the first time since the program started running in the production environment in 2018.
After analyzing the complete panic log, we found that the panic occurred at Line 480.
github.com/project/vendor/github.com/project/mgo/bson.(*encoder).addCStr(0xc43098b0e8, 0x0, 0x3)
        /opt/gohome/src/github.com/project/vendor/github.com/project/mgo/bson/encode.go:480 +0x43

The log clearly indicates that(e *encoder)is not a nil pointer, so the issue is likely caused by []byte(v)....
Line:479:func (e *encoder) addCStr(v string) {
Line:480:   e.addBytes([]byte(v)...) // PANIC
Line:481:   e.addBytes(0)
Line:482:}
---------------------------------------------
Line:512:func (e *encoder) addBytes(v ...byte) {
Line:513:   e.out = append(e.out, v...)
Line:514:}

We were shocked by the analysis conclusion, so we tried to simulate it locally 100 million times and did not encounter any panic.
func RunStr() {
   var str string
   fmt.Sprintf("%s", ToBytes([]byte(str)...))
   empty := ""
   fmt.Sprintf("%s", ToBytes([]byte(empty)...))
}

We realized that this may be a system-level or memory-level issue, so we would like to seek official help.
 Convert string v to a byte array and unpack the array into a list of bytes.
It is very confusing for us that this operation resulted in a panic, as we could not find any relevant information in the repository's issue tracker, release notes, or fix records.

 :)
Does this reproduce on the latest release of Go (1.23.4)?

github.com/project/vendor/github.com/project/mgo/bson.(*encoder).addCStr(0xc43098b0e8, 0x0, 0x3)

You've got a bad string input to addCStr. That string has length 3, but a nil backing store pointer.
That's not possible in vanilla Go. You might have a data race (did you run with -race?), or incorrect use of unsafe or cgo.

Related Issues

encoding/json: encode panic #55829 (closed)
panic: encoding unexpected fault #18062 (closed)
text/template: panics encountered during function calls are hard to treat and debug #28242 (closed)
encoding/json: occasional panic while encoding json #25608 (closed)
fmt: Panic within fmt.Sprintf() #64505 (closed)
cmd/compile: SIGSEGV on bytes.Join([][]byte{....}) #19056 (closed)
encoding/json: json.Unmarshal: invalid memory address or nil pointer dereference #60549 (closed)
encoding/gob: memory corruption decoding interface #3175 (closed)
encoding/json: length greater than capacity in backtrace in unquoteBytes crash #34292 (closed)
possible GC-related panic #5554 (closed)

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

github.com/project/vendor/github.com/project/mgo/bson.(*encoder).addCStr(0xc43098b0e8, 0x0, 0x3)

You've got a bad string input to addCStr. That string has length 3, but a nil backing store pointer. That's not possible in vanilla Go. You might have a data race (did you run with -race?), or incorrect use of unsafe or cgo.

This is an error log generated in the production environment after running the binary compiled through 1.9.2.
We have analyzed the complete call stack, which involves a process similar to json.Marshal, recursively handling the incoming objects, using type reflection to obtain the data type and value, and then writing them into a byte stream.
I suspect that the issue may not be related to running with the -race flag or improper use of unsafe or cgo.
In the input parameter of the addCStr function, the string should default to having a value (or be empty) to align with the language's characteristics. This is also why we were surprised by this error.

 :)
Does this reproduce on the latest release of Go (1.23.4)?

Thank you for your attention.
The issue was attempted to be reproduced one billion times on version 1.9.2 without success, as described in the previous text.
The problem currently exists as a production failure, and our focus at this stage will be on determining the actual cause of the issue.
However, I also agree that it is worth considering whether the issue may exist in other versions or the latest version.

I'm going to close this issue, as I don't think there's anything we can do. We'd need to know where that bad string came from.


🏗 Build spider: Sedgwick Juvenile Corrections Board

What's this PR do?
Adds a spider to scrape meetings from the website of Sedgwick county Juvenile Corrections Advisory Board, Wichita KS. The new spider is called wicks_sedgwick_jcab.
Why are we doing this?
Built the spider as per request.
Steps to manually test

Ensure the project is installed:

pipenv sync --dev

Activate the virtual env and enter the pipenv shell:

pipenv shell

Run the spider:

scrapy crawl wicks_sedgwick_jcab -O test_output.csv

Monitor the output and ensure no errors are raised.

Inspect test_output.csv to ensure the data looks valid.

Are there any smells or added technical debt to note?
Nothing major to note.

I don't think I have merging rights yet, so please feel free to merge this PR whenever possible.

I don't think I have merging rights yet, so please feel free to merge this PR whenever possible.

Ah! My bad, @msrezaie. I've just created a new org team called "Code the Dream" and sent you and @cruznunez invites. The team should have "maintainer" status for this repo and the other newly-created city-scraper repos. If you could accept that invite and then try merging again I'd be appreciative. My apologies for overlooking the permissions issue.


677 add namespaces for staff and adopter fosterer

🔗 Issue

#677
✍ Description

Updates routes to use staff and adopter_fosterer namespaces. Add directories for each namespace to controllers, views, and controller tests, and updates path/url helpers throughout. Also updates locale/en.yml to incorporate namespaces.
I didn't split the integration tests into staff, adopter_fosterer directories. Wasn't sure how these are best organized. Let me know. I'm happy to make changes.
📷 Screenshots/Demos

Thanks @MooseCowBear! I think we can leave the integration tests as is for now. I will check this branch out this weekend and have a good look.

@kasugaijin Yes, I think the namespaces were a good idea.


[Request] Mute sounds when in a vacuum

When a player is on a planet with the Atmosphere Type "Vacuum". All sounds except for GUI ones are muted. IRL, sound waves cannot travel without air. Of course, this stops happening when a player enters a sealed environment.

I think that if this is implemented, there should be a option to disable the feature and maybe a helmet module to keep the ability to hear (even if thats unrealistic)


'create-react-native-app' is not recognized as an internal or external command

Hello. I've followed the installation and installed CRNA with the following command: yarn global add create-react-native-app.
But the powershell terminal spits out this: create-react-native-app : The term 'create-react-native-app' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
Any suggestions on how to deal with this is appreciated.
Thanks!

Fixed it with this yarn issue: Link


DSEGOG-320 Update for Apache extension

This is a simple PR to support the changes made in https://github.com/ral-facilities/operationsgateway-ansible/pull/17. The og-api variable for the dev server has been edited to add /api onto the end of it. Also a couple of sentences in dev_server.md to explain this change.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.99%. Comparing base (6ba3184) to head (44d9ed0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   94.99%   94.99%
=======================================
  Files          50       50
  Lines        2837     2837
  Branches      297      297
=======================================
  Hits         2695     2695
  Misses        105      105
  Partials       37       37

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


test: Do not merge : Coderabbit file changes

Description
This is for remove duplicate helper from new files.
Fixes #34937
Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!CAUTION]
If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[x] No

Summary by CodeRabbit

New Features

Introduced a new test suite for the Admin Settings page to validate page title behavior upon instance name changes.
Enhanced code review guidelines to specify preferred API function usage for improved consistency.

Bug Fixes

Improved reliability of the application by ensuring accurate page title updates based on feature flag status.

@coderabbitai full review

@coderabbitai full review


Allow activeSlideKey to slide to first child

When using the activeSlideKey to try to slide to the first child it fails as index would be 0 which is falsey.

This PR looks good and necessary @kidjp85


DELTASPIKE-1091 add default values to Weld profiles.

To sum this up:

Removes the need to use system property to trigger Weld profiles
Removes the common profile for all Weld profiles, deps/setups were copied over to relevant profiles (turns out to be the smoothest solution)
Introduces default values for Weld profiles
So a simple mvn clean verify -PWeld${X} (where X = 1 || 2 || 3) will work
You can still specify Weld version with -Dweld.version=...; obviously the major release version has to match the chosen profile


Installing big sur stuck at 13 minutes remaining

20QE-S01L00
i7 8565U
Using efi in this repo with platformInfo added, BIOS configuration referred to tylernguyen/x1c6-hackintosh, however, I got stuck when installing big sur with 13 minutes remaining.
Does this might be caused by my wrong configuration or incompatible os version? Thanks a lot.

So, my friend did the update, but his wifi wasn’t working afterwards. This was on a 20QD like the repository requests we use.
I’d like more input on this from more seasoned hackintosh folks.


Fix template loading

Fix template loading when html element attribute is object and string value contain antislash
Short description of what this resolves:
Changes proposed in this pull request:

Fixes: #

@supa-creation,
Can you explain what this is fixing a little more clearly? Any chance you could create a some unit tests around this so I can better see what's going?
Thanks,
Dan

     <directive [attribute]="{       'key1': 'It\'s a string',     }"></directive>
Here is an example that generates an error that is fixed with this fix

@supa-creation,
Sweet! Thanks for the PR.
Thanks,
Dan

Thank you for accepting ;)
I will be able to update my project.


Made module exclusively Python3

Hi,
First of all, thank you for this module.  It has saved us a good chunk of development time.  I've updated this module so  that it is Python 3 only.  I've also added another test and updated it for Flask > 1.0.  Hooks can now return their http status, which the runner is free to ignore, or return to the end-user.  Please let me know if you'd like me to change this PR in any way.
Thank you.

This branch should now cleanly merge onto master.  It removes Python 2 runtimes from tox, and Travis.


Database: Create Families table and its routers, controllers, migrations, seeds

Description
This PR creates new families table and its routers, controllers, migrations, seeds.
Please provide a short summary explaining what this PR is about.
Fixes #202
How to test?
nom run db:clean
npm run db:setup
Please provide a short summary how your changes can be tested?
Checklist

[X] I have performed a self-review of my own code
[X] I have followed the name conventions for CSS Classnames and filenames, Components names and filenames, Style filenames, if you are in doubt check the the project README.MD and here https://github.com/HackYourFuture-CPH/curriculum/blob/master/review/review-checklist.md
[X] I have commented my code, particularly in hard-to-understand areas, if you code was simple enough mark the box anyway
[X] I have made corresponding changes to the documentation, if you code was simple enough mark the box anyway
[X] This PR is ready to be merged and not breaking any other functionality

I guess we need to fix this first:

You can solve the DB conflicts just by changing the seed file names. You need to move the seedfile of the families before products.

You'll need to change the order of seed files, so families comes before products.

Thank you .. It worked ..

@Darya-s You need to update the database and solve conflicts.


Fix crash when enabling minification

Issue

close #257

Overview (Required)

Changed org.jetbrains.androidx.navigation:navigation-compose to version 2.8.0-alpha08 to avoid crashes on screen transitions in release (and debug) builds as a workaround.

Links

https://github.com/JetBrains/compose-multiplatform/issues/4711

Screenshot (Optional if screenshot test is present or unrelated to UI)
Unrelated to UI
Movie (Optional)

Before
After

Thank you for your investigation and contribution!


Importing @opentelemetry/core fails with no other dependencies

Please answer these questions before submitting a bug report.
What version of OpenTelemetry are you using?
0.1.1
What version of Node are you using?
10.15.0
What did you do?
If possible, provide a recipe for reproducing the error.

create a new node.js project
install @opentelemetry/core
import @opentelemetry/core

What did you expect to see?
Useable OpenTelemetry core api
What did you see instead?
Module fails to import and crashes the program.

@dyladan Can we close this one via https://github.com/open-telemetry/opentelemetry-js/pull/472?

yes

@mayurkale22 I was just thinking about this. The program crashed. Failing to load a plugin should not cause a crash right? The actual crash was not during plugin load but was in the line that logs the traceId. Something along the lines of cannot access traceId of undefined. Should I open another issue for that?

Sure, please provide a recipe for reproducing the error.

I was creating the bug and realized I was mixing up 2 different bugs. Current state is fine :)


Docker container settings dialog needs better error handling

The docker container settings in the app edit/creation modal dialog has only rudimentary error handling. We should do it like at the other app modal fields.
AC.

Container fields needs a client side validation
The API error response must be parsed and displayed at the related field.

Will be fixed by #2105


Added Ability to be extension agnostic

This resolves the #24 issue.

Another great PR - thanks for all your help :smile:. Merged.

Thanks! I got more coming too!


Fix deprecation warning in build.gradle.

Two dependency entries were using a deprecated configuration: changed them to be non-deprecated, and consistent with the rest of the file.

Folded into #636

Folded into #636


fix license id

closes #265

Codecov Report
Patch and project coverage have no change.

Comparison is base (e83220f) 77.74% compared to head (054e1b6) 77.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #266   +/-   ##
=======================================
  Coverage   77.74%   77.74%
=======================================
  Files         107      107
  Lines        8557     8557
=======================================
  Hits         6653     6653
  Misses       1904     1904

Impacted Files
Coverage Δ

src/core.F90
75.00% <ø> (ø)

src/cross_section.F90
86.43% <ø> (ø)

src/cross_section_factory.F90
41.83% <ø> (ø)

src/cross_section_warehouse.F90
83.95% <ø> (ø)

src/cross_sections/acetone-ch3co_ch3.F90
90.24% <ø> (ø)

src/cross_sections/ccl4.F90
86.36% <ø> (ø)

src/cross_sections/cfc-11.F90
86.48% <ø> (ø)

src/cross_sections/ch2o.F90
86.11% <ø> (ø)

src/cross_sections/ch3ono2-ch3o_no2.F90
86.11% <ø> (ø)

src/cross_sections/chbr3.F90
85.36% <ø> (ø)

... and 97 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Fix missing LICENSE in sdist

The latest release on PyPI is missing the LICENSE file. Unless I'm mistaken, this is because Flit expects the filename to be specified as the file argument under license. (The text argument is meant for the full license text, not the license identifier.)
I'm repackaging this for conda-forge, and this issue was caught by the infrastructure we have to make sure that all  the licenses are in order.

@maresb, thanks for bringing this up. The missing of the LICENSE file (and other files) were not intended (incomplete sanity checks by myself when we moved from setuptools to flit). I plan to investigate more to improve my understanding of all this (although, I won't be able to look/address this all till this evening).
I'm not sure off hand if the changes proposed are the changes we want to make here. The existing license value was initially defined when using setuptools (based off their example). Flit's documentation indicates a different meaning for this value -- which seems odd to me. I assumed such a meta-license field is best served as a SPDX license identifier, in the way that Poetry promotes. Although looking at PEP 621, it clearly indicates (as this PR suggests) the text of the license is desired (either explicitly or by using the file hint, which this PR uses).
The use of flit was mainly driven by Sphinx's use of this builder. Looking at their project definition, they also use a SPDX identifier (some other projects look to be doing it the same; but... are they all wrong? or is using a SPDX ID for text more commonplace). My original thinking was to leave it as it and properly define an include list to include not only the license document, but other files that were missed in this last source distribution.
Welcome for any comments on this. In any case, the goal will be to ship out a v2.1.1 release by the end of this day.

Hmm, I'm honestly not that experienced with Flit. And I also find the whole specification and usages of these license arguments confusing. Looking over the relevant PEP it looked like this was the appropriate fix, but I have not actually tested building it to ensure that it results in the license being included. But thanks a lot for looking into this. I'd definitely like to know what you find out.
On the conda-forge side we have an option to include the license file in the recipe, so I was nevertheless able to create a confluence builder v2.1.0 release containing the license downloaded from the repo. But I'll remove this once we get this figured out so that the provided license file takes priority and remains up-to-date.

Was able to finally research this a bit more. Stumbled upon PEP 639 and its Discourse thread for what is expected soon. It appears whenever this PEP is approved, the use of license as a table will be deprecated. I believe we will be able to just define the following in the final version (assuming flit, or whatever builder we use, supports it):
license = 'BSD-2-Clause'

That being said, this information does not help us right now. Flit requires a table format and the existing string value could be considered incorrect. Since I'm not particularly interested in correcting the use of a key which is soon to be deprecated, I plan to submit a merge request with the license key removed (classifiers can still be used to reflect license information).
This does not resolve the main issue brought up with this merge request that the source distribution is missing the expected LICENSE document. Instead, pyproject.toml will most likely be updated with the following:
[tool.flit.sdist]
include = [
    'AUTHORS',
    'LICENSE',
    'MANIFEST.in',
]

This will include the LICENSE document, as well as other documents that should be included in the source distribution.

@maresb, thanks again for reporting this. Since alternative changes to pyproject.toml were needed, another merge request was created to address this; will close this merge request.

Cool, thanks so much for the fix, and the detailed findings!


wielded instruments can be played in inactive hand

1, wield guitar
2. change hand
3. open instrument ui with right click on guitar
4. press q
ui is still open

got fixed at some point


functionpushdown move function pushdown as default false since its performance is not good

Proposed changes

set enable function pushdown default to false.
enable it in fuzzy mode to test this feature.

We should remove function pushdown in the future since we already have common expr pushdown.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.42 seconds
stream load tsv:          454 seconds loaded<PHONE_NUMBER>9 Bytes, about 157 MB/s
stream load json:         19 seconds loaded<PHONE_NUMBER> Bytes, about 118 MB/s
stream load orc:          57 seconds loaded<PHONE_NUMBER> Bytes, about 18 MB/s
stream load parquet:          28 seconds loaded 861443392 Bytes, about 29 MB/s
insert into select:          69.1 seconds inserted 10000000 Rows, about 144K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230624130239_clickbench_pr_166808.html


Zeph180-djo1975-JS-CAPSTONE-PP

https://github.com/djo1975/JS-CAPSTONE-PP/projects,
This a group of two students: Studenta A-djo1975, Student B-Zeph180

Hi Team,
Good job so far, indeed you have spent time on this project!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

Kanban Board ✔

Required Changes ♻
Check the comments under the review.

[ ] I would implore you to assign all projects to every member so that every member would know the task they are to do.
[ ] Since you are 2 in this group, it is expected your tasks total 15 but I can see 14, kindly add the last one.

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Please, I am not sure what I have to do with this : I would implore you to assign all projects to every member so that every member would know the task they are to do.

Please, I am not sure what I have to do with this: I would implore you to assign all projects to every member so that every member would know the task they are to do.

@djo1975 The reviewer meant that you should ensure all members have assigned tasks for clarity on who is supposed to tackle which task, I can see you aready implemented it

Hi @djo1975 and @Zeph180 ,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉 🎉 🎉
Highlights
✔  Good design
✔  Good Description
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


App crashes when in viewer

Describe the bug
When moving from image to image in the viewer it crashes (see photos)
To Reproduce
Steps to reproduce the behavior:

Click on any image and either swipe or tap to move to new image
After 3 or 4 images either there is an image saying 'oops' or the app crashes

Thumbnails appear correctly. It's only when opening some images they show 'oops' and then crashes though not always
I've cleared cache and data and tried to use the app with stock settings but to no avail
Expected behavior
You would hope it woudl move from image to image without issue
Screenshots

System information and logs:
aves-logs-20230506_111329.txt
Package: deckers.thibault.aves
Installer: com.looker.droidify
Aves version: 1.8.6-izzy, build 9701
Flutter: stable 3.7.12
Android version: 13, API 33
Android build: TP1A.220624.014.F936BXXU2CWCC
Device: samsung SM-F936B
Geocoder: ready
Mobile services: ready
System locales: en_GB
Storage volumes: /storage/emulated/0/
Storage grants:
Error reporting: false
Additional context
Add any other context about the problem here.

Thanks for the report. I see some fatal errors in the logs, but they seem to come out of nowhere.
If you open the app and just wait, would it crash by itself? I'm asking because maybe the background cataloging is using/corrupting memory.
Does it happen with particular files you can identify and share with me?
Does it happen if you only browse through images (and not videos)?
Does it happen if you only browse through basic images taken with your camera (nothing fancy, downloaded or transferred from outside)?
I've noticed you use a Samsung Flip. Do you open/close it while the app is running?

If I open the app and leave it alone it's fine no crashes
How long should cataloguing take? There are about 10k mainly images.
A couple of files it seems to happen to more frequently but not always. See attached.both were taken with the camera. Interestingly if I scroll through images downloaded from the web which I've saved it doesn't crash.
It appears to be images I've taken which are triggering the crash. I've filtered by video including ones I've recorded and can scroll through with no issue.
Unfortunately it crashes on my galaxy fold 4 on both the main and cover screens.
I've attached a video of how when opening an image which shows 'oops' it does momentarily show thr image. It's of one of the two images I've attached
https://user-images.githubusercontent.com/81394097/236640824-58098521-731b-4369-b726-f3fd23c8cd72.mp4

If I open the app and leave it alone it's fine no crashes
How long should cataloguing take? There are about 10k mainly images.

It's variable, but if you started the app for the first time, the 10k images would be catalogued in the background in a few minutes. After that, when there are just a few new images to catalog, it's done within the app when you open it and it usually takes a few seconds. Some people have in their collection some files that make the cataloguing crash (usually because of a memory error), and that will crash the app is cataloguing is done within the app. Anyway, it doesn't seem to be your case.

A couple of files it seems to happen to more frequently but not always. See attached.both were taken with the camera. Interestingly if I scroll through images downloaded from the web which I've saved it doesn't crash.
It appears to be images I've taken which are triggering the crash. I've filtered by video including ones I've recorded and can scroll through with no issue.
Unfortunately it crashes on my galaxy fold 4 on both the main and cover screens.

Thanks for all the details. At this point I have no idea what the issue could be, but it's useful to know what works.

I've attached a video of how when opening an image which shows 'oops' it does momentarily show thr image. It's of one of the two images I've attached

If you see the image for a split second like this, it's because the thumbnail is in the cache, but the full image can't be loaded. Sometimes, a file that no longer exists but wasn't properly removed from the system Media Store will behave like that in Aves, because it still has its thumbnail from a previous time.

Do you use a custom rom?
I see you use the Izzy version. You could try and install Aves Libre (from F-Droid) or Aves from the Play Store. Aves Libre would install side by side with your current version but Aves from the Play Store would replace the one you currently have.

I'm not using a custom rom. Samsung one Ui 5.1 based on android 13.
I downloaded it from Droidify which is a material design version of Fdroid, infact I think I downloaded it from fdroid.
So I've just uninstalled and installed the play store version....and it seems fine. I've swiped through 2 dozen photos quickly and no crash and it woudl be caching images in background still. I'll keep you posted if something goes wrong
Out of interest Is the libre version newer?

On F-Droid (or any client like Droidify) you can find both "Aves" (from IzzyOnDroid's repo) and "Aves Libre" (from the basic F-Droid repo). From your system environment, I know you were using the izzy version.
I'm glad to know the play version works better for you, but the different versions should not differ when it comes to browsing and decoding images, so there's still a mystery.
You can see the differences between versions here. All versions are released more or less at the same time, but F-Droid takes a few days to update the libre version in their repo.

So I've just uninstalled and installed the play store version....and it seems fine. I've swiped through 2 dozen photos quickly and no crash and it woudl be caching images in background still. I'll keep you posted if something goes wrong

Still fine? If you want to go the extra mile, you could try the libre version and see whether it crashes.

So I've just uninstalled and installed the play store version....and it seems fine. I've swiped through 2 dozen photos quickly and no crash and it woudl be caching images in background still. I'll keep you posted if something goes wrong

Still fine? If you want to go the extra mile, you could try the libre version and see whether it crashes.

Yep all good thanks.


Connect a specific version of node to farcaster.dev for tests

Website farcaster.dev can take a list of public offers, a special version of the node should be able to push offers there (the "maker" version) and the standard version should have a command to list them in cli.

[ ] List available offers in cli
[ ] Push new list of available offers in farcaster.dev from special node version

As @zkao mentioned, if we are able to list offers from the cli there is no need to have a special node version, we can just script to list and update every x time.
I though about what the cli could look like and came up with this idea:
swap-cli ls <TYPE>

where TYPE is by defaults swaps with ls swaps being the current ls behavior and ls offers being the list of offers like:
---
- "Offer:Cke4ftrP5A71LQM2fvVdFMNR4gumFhEqm11111uMFq7cEPSbSQpvEiF11111TB9zym113GTvtvqfD1111114A4TULEXhypzp8nJ4WAGAZUdDkYai3i9KTgUHkGLs5zX3N1tA11111111111111111111111111111111111111111AfZ113XRBuJApN3x"

ls stands for list swaps
why reuse?
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Saturday, December 4th, 2021 at 9:55 AM, h4sh3d @.***> wrote:

As @.***(https://github.com/zkao) mentioned, if we are able to list offers from the cli there is no need to have a special node version, we can just script to list and update every x time.
I though about what the cli could look like and came up with this idea:
swap-cli ls
where TYPE is by defaults swaps with ls swaps being the current ls behavior and ls offers being the list of offers like:

"Offer:Cke4ftrP5A71LQM2fvVdFMNR4gumFhEqm11111uMFq7cEPSbSQpvEiF11111TB9zym113GTvtvqfD1111114A4TULEXhypzp8nJ4WAGAZUdDkYai3i9KTgUHkGLs5zX3N1tA11111111111111111111111111111111111111111AfZ113XRBuJApN3x"

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

I though ls was for list

maybe we should call it ListSwaps, and the abbreviation is ls, and the other ListOffers ?

created https://github.com/farcaster-project/offer-refiller to address this. It's pushing public offers to the web frontend whenever the list of swaps offered is updated.


Build instructions

Hi,
thanks for the exploit. May it be possible to add build instructions?
Thanks!

Simply dropping them in a project and compiling with x64|Release works for me on MSVC.
Let me know if you run into any issues, I can also add a solution file if needed.

I'm using Visual Studio Community 2017.
File > New Project > Visual C++ > Empty Project
I added your header files in the solution explorer to "Header Files" and Main.cpp and Native.asm to "Source Files". Building the project for x64|Release gives me 22 unresolved external symbols (the asm functions, e.g. __readss).

Thanks for your help!

Right click on your project, go to Build Dependencies and click on Build Customizations.... Choose masm from the menu and click OK. Then right click on Native.asm, go to Properties and set the item type to Microsoft Macro Assembler. This should solve your problem.

On another note, to make sure you don't bugcheck:

Disable Properties>C/C++>Code Generation>Security Check (/GS-)
Disable Properties>C/C++>Code Generation>Control Flow Guard
Make sure you compile with Release
Do not launch with the debugger

Works fine, thanks for your help and the tips to improve reliability!

Hi can1357,
I failed to compile with VS2017,
what version of MSVC r u using?

VS2017

it's work, thx.
I run the output exe file and get some error:
`C:\Users\x\source\repos\CVE-2018-8897\x64\Release>CVE-2018-8897.exe
[[[[[[        Assert Failed: !KvaInfo.KvaShadowFlags.KvaShadowEnabled        ]]]]]]
`

@Malayke read the error?


Sort Domains

Should be alphabetical for users to more easily find what they are looking for.

Maybe this should be the default, but we're going to be adding a sorting option to every list so this request is not strictly relevant.

Task completed


[stable/goldpinger] add extraEnv

Signed-off-by: Taehyun Kim<EMAIL_ADDRESS>
Is this a new chart
No

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
Goldpinger can take additional environment variables like HOSTS_TO_RESOLVE.
This PR enables that.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @okgolove

/ok-to-test

/lgtm


WIP: Library v2

Description
After being dead for a while, time to revamp this lib.
Changes

modernize the entire workflow;
Switch to Node 18 requirement;
add new flag --optionalDeps (thanks @jase88 [https://github.com/raulfdm/pin-dependencies-checker/pull/7]);
ESM only;
considers single or monorepo;
[ ] update README

Hi, wow thanks for refactoring - looking good.
Sorry for jumping in, but one suggestion since you also enforce > node 18
import { parseArgs } from 'node:util';

const {
  values: { peerDeps, deps, devDeps, optionalDeps },
} = parseArgs({
  options: {
    peerDeps: {
      type: 'boolean',
      default: false
    },
    deps: {
      type: 'boolean',
      default: true
    },
    devDeps: {
      type: 'boolean',
      default: true
    },
    optionalDeps: {
      type: 'boolean',
      default: true
    }
  },
});

Could save you yargs as dependency and could make zod unnecessary (at least with the current simple boolean flags)

Uhh... nice @jase88 ... I didn't know about that.
I saw it's still experimental but I think it's safe to use:

Going to do some tests with it.
Thanks for sharing it


update google-java-format version

This version also removes unused imports.
Please let me know when's a good time to merge this.

Codecov Report

Merging #289 into master will decrease coverage by 0.11%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master     #289      +/-   ##
============================================
- Coverage     73.78%   73.67%   -0.12%
+ Complexity      361      360       -1
============================================
  Files            66       66
  Lines          1812     1812
  Branches        148      148
============================================
- Hits           1337     1335       -2
- Misses          405      406       +1
- Partials         70       71       +1

Impacted Files
Coverage Δ
Complexity Δ

.../com/google/api/gax/grpc/FixedChannelProvider.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...c/main/java/com/google/api/stats/Distribution.java
77.58% <ø> (ø)
16 <0> (ø)
:arrow_down:

...ain/java/com/google/api/gax/grpc/ApiException.java
100% <ø> (ø)
4 <0> (ø)
:arrow_down:

.../com/google/api/gax/batching/ThresholdBatcher.java
100% <ø> (ø)
17 <0> (ø)
:arrow_down:

...in/java/com/google/api/gax/grpc/UnaryCallable.java
92% <ø> (ø)
17 <0> (ø)
:arrow_down:

...le/api/gax/batching/AccumulatingBatchReceiver.java
100% <ø> (ø)
4 <0> (ø)
:arrow_down:

...va/com/google/api/gax/grpc/ChannelAndExecutor.java
75% <ø> (ø)
3 <0> (ø)
:arrow_down:

...n/java/com/google/api/gax/core/FlowController.java
78.12% <ø> (ø)
17 <0> (ø)
:arrow_down:

.../com/google/api/gax/batching/NumericThreshold.java
100% <ø> (ø)
5 <0> (ø)
:arrow_down:

.../com/google/api/gax/testing/MockServiceHelper.java
95% <ø> (ø)
13 <0> (ø)
:arrow_down:

... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6f1039...e9413fc. Read the comment docs.

Wait until after https://github.com/googleapis/gax-java/pull/288

@garrettjonesgoogle PTAL

LGTM


Check whether cursor is on and not between intra doc links in goto_definition

bors r+

btw, syntax-hightlighting the links would be :zap:
Might be a good opportunity to refactor the docs pipeline as well

changelog fix


Initial transform of EIA930 tables

Create a basic set of core_eia930 assets sufficient for the GridLab MVP.
- [x] Switch to using April `eia930` DOI in datastore.
- [x] Add `core_eia930__hourly_balancing_authority_demand` asset
- [x] Add `core_eia930__hourly_balancing_authority_net_generation` asset
- [x] Add `core_eia930__hourly_balancing_authority_interchange` asset
- [x] Add `core_eia930__hourly_subregion_demand` asset
- [x] Add `core_eia930__assn_balancing_authority_subregion`
- [x] Add `core_eia930__assn_balancing_authority_region` asset
- [x] Standardize column names in interchange table column maps
- [x] Define schemas for each of these tables
- [x] Write EIA-930 tables to SQLite (~18min; adds 50% / 8GB to pudl.sqlite)
- [x] If SQLite output too slow/big, try Parquet only (90sec; 260MB)
- [x] DATA: Evaluate consistency of BA codes found in EIA860, EIA923, & EIA930
- [x] DOC: Are `generation`/`demand`/`interchange` really ~MW~? Or MWh?
- [x] DOC: Clarify whether these hourly timestamps are Hour Ending or Hour Starting
- [x] DOC: Clarify meanings of `reported`, `adjusted`, `imputed` and `forecast` demand/interchange/generation
- [x] DOC: Verify that `demand_reported_mw` for BA and subregions actually mean the same thing
- [x] DOC: Flesh out real table descriptions
- [x] ENG: Address access/database consequences of only writing hourly EIA-930 data to Parquet
- [x] ENG: copy the EIA-930 parquet outputs out of `parquet` folder for distribution in nightly builds
- [ ] Figure out if day ahead demand forecast timestamps are when the forecast was made, or the forecast time

# Out of Scope
- [x] DATA: Remove local timestamps and record the timezone associated with each BA's reporting
- [x] ENG: Define allowed `region_code_eia` values in the BA coding table
- [ ] DATA: [Evaluate discrepancy between reported total & per-fuel generation](https://github.com/catalyst-cooperative/pudl/pull/3584#issuecomment-2067908462) (it is not small!)
- [ ] DATA: [Evaluate consistency of aggregated subregion demand and BA demand](https://github.com/catalyst-cooperative/pudl/pull/3584#issuecomment-2067908462)
- [ ] ENG/DATA: Define additional asset checks to validate the new tables
- [ ] ENG: Harvest BA codes from EIA-860, EIA-861, EIA-923, and EIA-930
- [ ] DATA: Create a coding table for cleaning and documenting BA subregion codes

Hey @grgmiller & @jdechalendar do either of you happen to know whether the EIA-930 timestamps associated with the day-ahead demand forecasts are the time at which the forecast is being made?  Or the time associated with the demand that's being predicted?  Is there a general convention on this with respect to day-ahead-forecasts? Like is the prediction always being made at time X for the time X+24h?

  Or the time associated with the demand that's being predicted?  Is there a general convention on this with respect to day-ahead-forecasts? Like is the prediction always being made at time X for the time X+24h?

I've never used these forecasts so I'm useless here - sorry!

 Or the time associated with the demand that's being predicted? Is there a general convention on this with respect to day-ahead-forecasts? Like is the prediction always being made at time X for the time X+24h?

My understanding is that the timestamp refers to the forecasted interval. If you look at one of the regional excel files, this can be confirmed because there is demand forecast data for timestamps that have not yet occurred.


Introduce a glorious new cli arg splitter

Allow &str and &[&str] as input for command
Fixes #25
Currently based on #24. Rebase on master before merging

PS: I would concentrate on supporting "..." first and revisit '...' later, if at all. I thing it would be ok to reject the latter in a controlled way.

Let's put this on hold for now.


Use 1.21.0 instead of 1.21 as module version

How to categorize this PR?

/kind bug
What this PR does / why we need it:
Currently dependabot fails with:
go: downloading go1.21 (linux/amd64)
go: download go1.21 for linux/amd64: toolchain not available

See https://github.com/dependabot/dependabot-core/issues/7895 and https://github.com/golang/go/issues/62278.
It seems that with go1.21 it is no longer possible to have X.Y as module version - see https://github.com/golang/go/issues/62278#issuecomment-1698829945.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A
Release note:

NONE

It seems that goimports-reviser does not support the new format X.Y.Z. I created https://github.com/incu6us/goimports-reviser/issues/129.
/hold

/unhold
<EMAIL_ADDRESS>contains a fix for the issue described in https://github.com/gardener/gardener-extension-registry-cache/pull/39#issuecomment-1702834544.  d7cb55e does a temporary patch to update the goimports-reviser to v3.4.5.

/approve


No way to specify linker arguments via rustflags for dependency build scripts with --target

Problem
Background, but note that I already know how to work around this for me but am posting for want of a more general solution: I'm using rust on an unsupported macOS target (toolchain installed with macports) for $reasons. Due to missing system symbols like _getentropy() and _clock_gettime, the rust toolchain is built additionally linked against /opt/local/lib/libMacportsLegacySystem.B.dylib which provides these symbols that the standard library now uses since support for older macOS releases was removed.
Compiling a project with transitive dependencies that use std functionality that pulls in a reference to these symbols requires that the cargo be executed as env RUSTFLAGS='-Clink-args=-Wl,/opt/local/lib/libMacportsLegacySystem.B.dylib' cargo build and works great. No problems.
However, due to the logic that cargo uses internally to determine when and where rustflags are forwarded to rustc, this does not work if cargo is executed with an explicit --target, even when the target matches the host (e.g. x86_64-apple-darwin in this case).
I have tried the following methods:

env RUSTFLAGS='...' cargo build --target x86_64-apple-darwin
env CARGO_BUILD_RUSTFLAGS='...' cargo build --target x86_64-apple-darwin
env CARGO_TARGET_X86_64_APPLE_DARWIN_RUSTFLAGS='...' cargo build --target x86_64-apple-darwin
Specifying target.x86_64-apple-darwin.rustflags in a newly created .config/cargo.toml (to emphasize that there was no previous such file masking the above)

In all these cases, the provided rust flags are not passed when the linker is invoked in dependency builds (e.g. pcre2-sys fails to compile with errors about a missing _getentropy() symbol).
Debugging with env CARGO_LOG=trace reveals that the flags are picked up, and they're even used for some of the rustc invocations, but critically, they're ignored when it comes to build scripts (which is predominantly where external linker invocations will come in).
I can understand why "normal" RUSTFLAGS are not forwarded to all rustc invocations when --target is used, but I would proffer that the specific combination of CARGO_TARGET_<TRIPLE>_RUSTFLAGS with a matching --target <triple> should be forwarded the same way that RUSTFLAGS is when no --target is passed. (Note here that the project builds successfully when using RUSTFLAGS and no --target, with the correct -Clink-args being forwarded throughout.)
Note also that I am requesting that a solution be possible via the usage of environment variables only, without needing to specify any values in .cargo/config.toml so that this can be used in external build systems. (Indeed, the problem here is that I am calling cargo from a build system that determines the target and always passes --target <triple> to cargo.)
(For the record, I am not reporting this as a "I can't build on this unsupported platform" bug but rather as a "there doesn't seem to be any way to influence the linker behavior of all transitive dependencies in one go with an environment variable" issue only when building for a specific --target triple.)
cc #9743, which identified the issue but ended up being treated as a symptom of the OP's problem rather than the problem itself, and was closed accordingly.
Steps
No response
Possible Solution(s)

Always pass CARGO_TARGET_<TRIPLE>_RUSTFLAGS to build scripts when an explicitly provided, matching cargo build --target triple is used
Extract at least linker-specific flags like -Clink-args and other -Clink... flags and pass those to build scripts where currently no rustflags are forwarded

Notes
No response
Version
cargo 1.78.0
release: 1.78.0
host: x86_64-apple-darwin
libgit2: 1.7.2 (sys:0.18.2 system)
libcurl: 8.7.1 (sys:0.4.72+curl-8.6.0 system ssl:OpenSSL/3.1.5)
os: Mac OS 10.10.5 [64-bit]

Should this be considered a duplicate of https://github.com/rust-lang/cargo/issues/4423?

When not using --target, this has a consequence that Cargo will share your dependencies with build scripts and proc macros. RUSTFLAGS will be shared with every rustc invocation. With the --target flag, build scripts and proc macros are built separately (for the host architecture), and do not share RUSTFLAGS.

I found the section in Cargo book

Should this be considered a duplicate of https://github.com/rust-lang/cargo/issues/4423?

Very likely

@epage #4423 is a broad issue that is much more difficult to solve without introducing some major changes; would you consider entertaining a PR that forwarded rustflags to build scripts specifically and only for the case where host triple == explicit target triple? That would make cargo build equal to cargo build --target <host triple>, which, I think, is fairly uncontroversial?

If I've understood that link correctly, what I want is actually the opposite of that, as target-applies-to-host already defaults to true and is the reason why RUSTFLAGS is being applied to everything (which I want) except the build scripts (which I wish it actually extended to). What I am asking for is a true "target-applies-to-host" that applies to everything, everywhere (whereas the current target-applies-to-host option is intended to expose the target-applies-to-host=false toggle, which is expressly the opposite of what I am seeking).
It does seem that -Zhost-config would work here, but that requires nightly :(
For context, I am on a no-longer-supported OS X version for $reasons, and since std now assumes that methods like getentropy() are always present on the host system (not true for older macOS/OS X releases), apps using that functionality end up with missing symbol linker errors. The workaround here is to link against the MacPorts "LegacySupport" library that provides shims for these, and to work around an assertion failure (internal bug) in the latest available ld for OS X, I need to compile anything that runs on the host machine with -Clink-arg=-fuse-ld=lld -Clink-arg=-Wl,/opt/local/lib/libMacportsLegacySystem.B.dylib.
For normal builds, merely setting RUSTFLAGS to the needed does the job, but the problem is when compiling with --target $host_target_triple that there is no combination of .cargo/config.toml or environment variable values that will pass these required linker flags to cc when invoking build scripts in transitive dependencies (without patching their build.rs to force these to be emitted). It seems from the link you shared that -Zhost-config or [host] in .cargo/config.toml would theoretically do what I need, but as I can't arbitrarily install a nightly toolchain to use these flags.
For further context, the issue is with "packaged" rust projects that cannot be installed normally via cargo install and have an external build system that further provides specific functionality required to create installable artifacts. In this specific case, I'm a fish-shell core dev and we've ported our codebase from C++ to rust but we still need to use CMake to perform the install step because we need to install support libraries to $PREFIX/share/fish/, and we would certainly prefer to not have to embed megabytes of support files in the binary just so that we can deploy them on first run as being cargo install deployable (without an external build system) would require. The further issue is that CMake invokes cargo with an explicit --target in all cases, even when target matches the host (mainly so that the deployment code is the same regardless of cross-compilation or not), so the RUSTFLAGS that we set in the CMake environment and pass to Cargo are not being used for the build scripts.
But the problem is obviously more general than that; the root problem is a general conflation of host and target systems for RUSTFLAGS and the "workaround" here was to completely ignore RUSTFLAGS for build scripts when --target was specified, but this (to my eyes) was not a fully studied option and has ramifications like the ones above that can actually leave one completely unable to target the host system.
So again, my suggestion would be that today a PR to patch cargo to either forward RUSTFLAGS to build scripts as well specifically when host matches target, or (less discoverable but I can't see any problem with this suggestion) at the very least, CARGO_TARGET_<TRIPLE>_RUSTFLAGS when specifically building for the same target triple (and possibly when target matches host if you want to be truly paranoid), to build scripts (along with everything else). The current status quo of "RUSTFLAGS applies everywhere, even to build scripts, but if --target is set and even if target matches host, it doesn't get passed to build scripts and there's absolutely nothing you can say or do about it" is, to my eyes, hard to defend as it is clearly a hack and leaves some cases completely unaddressed (and worse, unaddressable).

So again, my suggestion would be that today a PR to patch cargo to either forward RUSTFLAGS to build scripts as well specifically when host matches target, or (less discoverable but I can't see any problem with this suggestion) at the very least, CARGO_TARGET_<TRIPLE>_RUSTFLAGS when specifically building for the same target triple (and possibly when target matches host if you want to be truly paranoid), to build scripts (along with everything else).

This might break existing builds, for example, when using address sanitizer.

for example, when using address sanitizer.

Interesting case, I confess I didn't consider it... but I'm not sure it's so cut and dry. I set up the ASAN CI profile for fish, and so speaking from experience, I can imagine scenarios where passing RUSTFLAGS to build scripts could both break or actually be required for the correct application of ASAN. It's easy to see why you wouldn't want your build script to be run under ASAN (it'll mess with its output and you might have memory leaks that trigger an ASAN abort causing your builds to fail, among others) but there are also inverse cases (though I think they would tend to be non-idiomatic). CFLAGS is passed to build.rs and that's how you can usually get -fsanitizer=asan to be applied to C/C++ dependencies built by build.rs, but if you are building rust dependencies "out-of-band" (e.g. perhaps they don't use cargo or perhaps they're transitive dependencies of a C/C++ library you are building in build.rs), then you'll actually end up with a mix of ASAN-enabled and non-ASAN-enabled object files! (It's also "weird" that CFLAGS is forwarded to build.rs but RUSTFLAGS isn't, strictly from a philosophical purity POV.)

Is RUSTFLAGS currently not forwarded both when building build.rs and when executing it?

Is RUSTFLAGS currently not forwarded both when building build.rs and when executing it?

It depends on how you configure it.
Cargo does respect RUSTFLAGS from the environment when building a package. Mind the precedence in the doc and aforementioned --target behavior.
When running a build script, Cargo sets CARGO_ENCODED_RUSTFLAGS and removes RUSTFLAGS.

CARGO_ENCODED_RUSTFLAGS — extra flags that Cargo invokes rustc with, separated by a 0x1f character (ASCII Unit Separator). See build.rustflags. Note that since Rust 1.55, RUSTFLAGS is removed from the environment; scripts should use CARGO_ENCODED_RUSTFLAGS instead.

@weihanglo sorry, I meant specifically in the explicit --target case, not in general.

CARGO_ENCODED_RUSTFLAGS is rustflags for the package a build script belongs to, not for building build script itself. So, it is always available for a running build script. For example, the build script execution would get a CARGO_ENCODED_RUSTFLAGS="--verbose" when running the command below:
cargo build --target wasm32-unknown-unknown --config 'target.wasm32-unknown-unknown.rustflags="--verbose"

While compiling the build script itself wouldn't.


Add use of prototype._clone() if found to clone an object. + test

This commit adds a feature by which if an object has a prototype method _clone(), this method is used to clone that object and all descendants.
Rational:
Currently cloning of an object is done with Object.create().
This does not work for certain objects (specifically node-opencv mat and opencv4nodejs cv.Mat objects).
For any object which does not clone correctly, a user can add a _clone() function and node-clone will then clone to the user's required specification.
Other examples where this is useful:
The _clone() function can do anything the user wants with an object.  For example, it could mearly return the original object, or return the original object with a reference count incremented.  Or as in the test, the clone could be marked as a clone...
questions:  is _clone() as the function name sufficiently 'conflict free'?

update: modified to allow an object to have a plain function _clone() attached - in this way behaviour for an individual object can be modified as well.  Obviously, if a prototype._clone() method is not added, the resulting object may no longer be cloneable.

I dislike the idea of having cloned objects define a prototype function. It seems to me that this should be part of it's own library, that you could use if clone doesn't work with an object.

the problem is that the clone library is used by another project (Node-Red), which uses it to clone generic messages; so we would prefer not to change the library for another.  We want to send objects down these messages, and have no control over the cloning process (i.e. we can;t choose to clone in a different way).  We have spent days over a period of months looking at mechanisms to make clone work for us, but all attempts have failed.
So what we are proposing is that we add a 'getout' clause, allowing the objects themselves to determine the cloning mechanism should the object/user so desire.  If we can get this into your library, getting the NR team to update will not be an issue (but getting a PR in for NR to change the library for another would take another 6 months :) ).
Added to readme as requested.

clone is used by almost 2000 other projects. I can't make sure that this change won't be breaking other people's code.
Native objects always have been problematic. Why don't you just wrap your call to clone and invoke the _clone() method instead, if it is available? This way, you don't have to fork clone or use another library. What do you think?

Hi Paul,
the root object being cloned is a message structure, which users would expect to be able to place a native object at any level in the structure, and the project (Node-Red) is also risk-averse.  The mod is low risk, except for the name of the function (_clone()), so could we compromise on a more complex name; less risk of conflict?  eg ___cloneObject() (3 underscores)?
I see this as a big advance in clone technology; enabling customization without modification.  e.g. recent additions to the your project involve clone of specific object types; nativeMap, nativeSet, nativePromise; each of these get special treatment.  The mod allows any user to enable clone of their object type, without a mod to clone itself, and even to do more; e.g. to make an object not clone, but instead reference ( myobject._clone= function() {return this); ), if so desired (i.e. it enables Control, at an object level).
And you would no longer need to worry about native objects (or request for support for objects you don't want to); the objects would have a way to look after themselves - giving you the 'getout' clause :).
thoughts?
s

Hi Paul,
I am contributing together with Simon on Node-Red, so thank you very much for having this discussion with us!!!!
Some context
In Node-Red messages are send between blocks, that are wired together:

In the first block we create an OpenCv image (i.e. Javascript wrapper around native memory), which is send to the next blocks in the payload field of a message object.  The original message object is send to the first wire (1), but a clone of the message is send to the next wire (2).  To clone the message, Node-Red calls your module and we have NO way to work around it ;-(
Requirement
The only way to create a valid clone of the Javascript wrapper, is by using the API of the OpenCv wrapper:
someWrapper.copy()
So we try to find some way to customize the cloning process, by calling this code snippet ...
Failed experiments
We are aware that your project is very popular, so we tried to find a way to call that code snippet (without pull-request) but all our experiments have failed:

Constructor: the Object.create doesn't call the constructor
Proxy object: the Proxy getter is called by your module, but the clone is a normal object (instead of a Proxy object).  Your module calls the getter only to get the data.
Getters and setters: Same result as with a Proxy.  When we specify getters and setters in the message object, the cloned object doesn't contain the getters and setters anymore.
Cloneable: Unfortunately Javascript doesn't seem to have a Cloneable interface (like Java, C# ...).  So therefore Simon created this pull request to have at least something alike ...

But perhaps you have better ideas to allow us to customize the cloning.  I.e. some way that doesn't break other projects, and could be helpfull for other users also.
Thanks in advance,
Bart

Thank you, Simon and Bart, for providing some context.
Can you detect whether you are cloning such a wrapper object around an OpenCV image/object or is it deeply nested in an object structure that you clone all at once?
Can you give me a link to the code we're talking about? Probably I can think of a solution when I have a specific example.

Dear Paul,
I have prepared a Simple repo (based on an example from the guy who make opencv4nodejs) here:
https://github.com/btsimonh/node-addon-tutorial
Pull it down,
cd to the VectorExample folder,
do 'npm install'
look at index.js
run with 'npm start' or 'node index.js'
This reproduces our issue in the simplest form.  The native Vector object seems to clone, but as soon as you try to use 'add', you either get 'TypeError: Illegal invocation' (if you try to run the add function from the clone), or 'Vector::Add - expected argument to be instance of Vector' (if you try to pass a clone into .add on a real Vector).
Note: I have only built on Windows.
Additional info on the Actual objects we are trying to clone:
So the object in question is Mat from opencv4nodejs
https://github.com/justadudewhohacks/opencv4nodejs/blob/master/cc/core/Mat.h
installing opencv4nodejs takes 4Gbytes and 2 hours, so we won't ask you to do that to try :).
We are then using that in Node-Red, and the Mat object could be at any depth in the message structure.  The specific use of Clone in Node-Red is in function cloneMessage(msg) in
https://github.com/node-red/node-red/blob/716bca211b7105d2b3e13a1c3802b7f5e572620b/red/runtime/util.js
Note that Node-Red already has one issue where 'req' and 'res' in the root of the message need to be referenced, not copied (these are http request and results).  Our data would normally be called 'payload' and be in the root of message, but could be msg.payload.img, etc. and there could be multiple in one message.
At the end of the index.js in the Simple Repo above, I've made an example Node-Red message as illustration.
thanks for your consideration,
Simon

Added to the end of the Simple Repo a http response clone test - the thing that Node-Red manually avoids.

Hi Paul,
what are your thoughts?
Simon

Sorry, was a bit overwhelmed by that header file and regretted that I asked in the first place.
So, if I try to run npm install in VectorExample, I just get:
$ npm install

><EMAIL_ADDRESS>install C:\Users\Paul\workspace\playground\node-addon-tutorial\VectorExample
> node-gyp rebuild

C:\Users\Paul\workspace\playground\node-addon-tutorial\VectorExample>if not defined npm_config_node_gyp (node "C:\Users\Paul\AppData\Roaming\npm\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "" rebuild )
Traceback (most recent call last):
  File "C:\Users\Paul\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\gyp\gyp_main.py", line 13, in <module>
    import gyp
ImportError: No module named gyp
gyp ERR! configure error
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (C:\Users\Paul\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\lib\configure.js:305:16)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Windows_NT 6.1.7601
gyp ERR! command "C:\\Program Files\\NodeJS\\node.exe" "C:\\Users\\Paul\\AppData\\Roaming\\npm\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd C:\Users\Paul\workspace\playground\node-addon-tutorial\VectorExample
gyp ERR! node -v v4.4.5
gyp ERR! node-gyp -v v3.3.1
gyp ERR! not ok

npm WARN<EMAIL_ADDRESS>No description
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\\Program Files\\NodeJS\\node.exe" "C:\\Users\\Paul\\AppData\\Roaming\\npm\\node_modules\\npm\\bin\\npm-cli.js" "install" "."
npm ERR! node v4.4.5
npm ERR! npm  v3.9.3
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the node-addon-tutorial-vector-example package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs node-addon-tutorial-vector-example
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls node-addon-tutorial-vector-example
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\Paul\workspace\playground\node-addon-tutorial\VectorExample\npm-debug.log

hi paul,
hmm...  some time since I did this.
I'll take a look, but not a specialist in build errors....
you have windows build env?
s

Hi Paul,
seems I've been a little lax on this one.  What exact environment are you running; maybe I can send you a binary image so you don't need to build?
I still believe this idea may help in a number of your outstanding issues; e.g. it would enable user workarounds for many of the issues in your issue list, giving them the choice of customising the clone method for chosen objects, even if they have no control over the code where clone is called...
https://github.com/pvorb/clone/issues/92
https://github.com/pvorb/clone/issues/82
https://github.com/pvorb/clone/issues/80
could all be worked around by the user...
best regards,
Simon

replacing with a simpler modification.  Watch this space :).


Some themes don't correctly color the WSL Remote icon

Describe the bug
When the WSL Remote extension is installed, it adds an icon (by default is green) that can be used as a shortcut to the WSL features. On some of the themes provided, the icon is indistinguishable from the background color.
To Reproduce

Install Remote - WSL (ms-vscode-remote.remote-wsl)

Expected Behavior
The icon has a contrast color so is easier to see with the themes.
Environment
Version: 1.57.0-insider (user setup)
Commit: 217f1a2f60a197807de78af362ecb832100fda96
Date: 2021-06-02T06:36:06.263Z
Electron: 12.0.9
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19042
Doki Theme: 12.2.1
Screenshots
No Theme:

Miku Theme:

So far I can confirm it with all themes, but is worst with dark ones as it completely blends with the colored background most of the time.
For example. Megumin Dark and Asuna Dark:

Thank you for bringing this to my attention and providing all the necessary details! I'll have a fix out for it shorty.

Aight, the release has been published, so you should be able to take the update.
Thanks for reporting this!


Show report even if it has no attachments

Question to @idasbiste ; should this fix go upstream as well or is it specific to stuff we're doing?


updates to outliers

related to https://github.com/USGS-R/mda.lakes/issues/87 @lawinslow
Let me know if you want outlier removal to happen in prep for data-raw, or within lakeattributes

@jread-usgs why is wqp_secchi.tsv empty?

I should have looked at this PR more carefully


JsonLogic

http://jsonlogic.com/
May be worth doing.

A Json.Net implementation has been found: https://github.com/yavuztor/JsonLogic.Net.  It hides the model, which is my main argument agains Json.Net, so at least it's consistent.


UserWarning: Setuptools is replacing distutils

Environment Versions

OS Type: macos
Python version: python 3.9.16
pip version: 22.3.1
pip-tools version: 6.13.0

Steps to replicate
Run any pip-compile command.
Expected result
No warning
Actual result
❯ pip-compile --version
/Users/tekumara/code/fakesnow/.venv/lib/python3.9/site-packages/_distutils_hack/__init__.py:33: UserWarning: Setuptools is replacing distutils.
  warnings.warn("Setuptools is replacing distutils.")
pip-compile, version 6.13.0

pip-tools can't do anything about that, report to the said project instead..

For anyone else encountering this, you should not see it in a clean venv with only pip-tools installed. It's caused by one of your other packages still using Distutils in some way.
I spent a little while trying to "bisect" my dependency list to figure out where it came from, but I didn't find the culprit. It seems to happen in almost every nontrivial Python project where I've used pip-tools, so it's likely to be some common lower-level package that a lot of other things depend on.
In any case, you can silence it by setting the env var PYTHONWARNINGS='ignore:Setuptools is replacing distutils:UserWarning:_distutils_hack'.
Unfortunately setting PYTHONWARNINGS='error' didn't seem to help isolate the source:
PYTHONWARNINGS='error' ./venv/bin/pip-compile --version

Traceback (most recent call last):
  File "/Users/.../.venv/bin/pip-compile", line 5, in <module>
    from piptools.scripts.compile import cli
  File "/Users/.../.venv/lib/python3.10/site-packages/piptools/scripts/compile.py", line 15, in <module>
    from pip._internal.commands import create_command
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1002, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 945, in _find_spec
  File "/Users/.../.venv/lib/python3.10/site-packages/_distutils_hack/__init__.py", line 97, in find_spec
    return method()
  File "/Users/.../.venv/lib/python3.10/site-packages/_distutils_hack/__init__.py", line 147, in spec_for_pip
    clear_distutils()
  File "/Users/.../.venv/lib/python3.10/site-packages/_distutils_hack/__init__.py", line 33, in clear_distutils
    warnings.warn("Setuptools is replacing distutils.")
UserWarning: Setuptools is replacing distutils.


Add Validate in addition to ValidateUpdate to validation for most resources.

@thockin @smarterclayton
Closes https://github.com/GoogleCloudPlatform/kubernetes/issues/6219

LGTM

LGTM


CDK table data stack fails to deploy if no ingest source buckets are set

Description
The nightly system tests failed on IngestNoSourceBucketIT. The instance failed to deploy with an error from the CDK. The resource that failed to deploy was TableData/TableDataBucket/Policy. Here's the error:
Unable to retrieve Arn attribute for AWS::S3::Bucket, with error message Bucket not found
Steps to reproduce

Run system test IngestNoSourceBucketIT
See failure

Expected behaviour
The instance should deploy successfully and the test should pass.
Background
This is similar to an old bug:

https://github.com/gchq/sleeper/issues/1577

I can't reproduce this now. Maybe something else we changed fixed it.


Breakpoints with slidesPerView: auto do not work correctly

Check that this is really a bug

[X] I confirm

Reproduction link
https://codesandbox.io/s/swiper-breakpoints-perview-d7xlkm
Bug description
I use a wrapper for React on web components.
When setting slidesPerView: "auto" in root settings and slidesPerView: 1 (or any other number) in breakpoints, the slider does not behave as expected. In breakpoints everything works fine, but where it should be "auto" - one slide is displayed at a time. Without breakpoints settings, specifying slidesPerView: "auto" works correctly.
Expected Behavior
No response
Actual Behavior
No response
Swiper version
10.1.0
Platform/Target and Browser Versions
Windows, Google Chrome 115.0.5790.111
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

but where it should be "auto" - one slide is displayed at a time

When you use auto you need to specify slide width in CSS, it is 100% by default

When you use auto you need to specify slide width in CSS, it is 100% by default

It didn't work

@nolimits4web Were you able to do this with the example I provided above?

@nolimits4web Were you able to do this with the example I provided above?

The example you have provided doesn't have slide widths specified in CSS for auto mode

@nolimits4web I have defined widths for the swiper-slide component and for the slide (picture) itself, but it doesn't give any result. Have you tried fixing the code in the example I attached so that it works as it should?

there is no point to define width using style attributes here, it will be overwritter, as in my first comment, it must be done in CSS

@nolimits4web Ok, I overridden the width in the css file. But other problems appeared:

spaceBetween for a screen larger than 375px should be 32px, but it displays 16px
When scrolling the slider to the right until the end, a large white space appears
When you swipe the slider to the left, the slides in it start to shift and it "jerks".

None of these problems occur if you don't change the parameters in breakpoints.

spaceBetween for a screen larger than 375px should be 32px, but it displays 16px

I see everything is correct
2 and 3 - see the docs for loop mode requirements https://swiperjs.com/swiper-api#param-loop

@nolimits4web In the Google Chrome browser 115.0.5790.171 on Windows, I have the wrong slide spacing displayed in the settings for breakpoints

There are slider settings that work correctly:
const sliderParams = {
slidesPerView: "auto",
spaceBetween: 32
grabCursor: true,
loop: true,
};
But I need these settings to apply only for desktop and different settings for mobile devices, so I use the breakpoints parameter to change the settings:
const sliderParams = {
slidesPerView: 1,
grabCursor: true,
spaceBetween: 16,
loop: true,
breakpoints: {
375: {
slidesPerView: "auto",
spaceBetween: 32
}
}
};
And already such settings give the problems I described above. I don't quite understand what documentation has to do with it, if everything works correctly without breakpoints.

@nolimits4web Should I create a separate issue for this or does it not count as an issue?

@nolimits4web Or maybe we should reopen this issue?

@nolimits4web Is there any chance to continue the discussion?

@nolimits4web I really need help with this. Can you give me a hint how to fix it if what I described is not a bug?

Please create a new issue with full correct CodeSandbox example


ru_reviews dataset adding

RuReviews: An Automatically Annotated Sentiment Analysis Dataset for Product Reviews in Russian

Hii please follow me

Hi @lhoestq
I have added the readme as well
Please do have a look at it when suitable

Chatted with @darshan-gandhi on Slack about parsing examples into a separate text and sentiment field

Thanks for your contribution, @darshan-gandhi. Are you still interested in adding this dataset?
We are removing the dataset scripts from this GitHub repo and moving them to the Hugging Face Hub: https://huggingface.co/datasets
We would suggest you create this dataset there. Please, feel free to tell us if you need some help.


spec: clarify meaning of alias decls in sequence of "enum" const declaration

package main

import "math"
import "fmt"

const (
	a = iota
	b
	c => math.Pi
	d
)

func main() {
	fmt.Println(a, b, c, d)
}

prints
0 1 3.141592653589793 2

It probably shouldn't be allowed in the first place. Certainly the output is wrong (iota should be incremented with each semicolon).

Certainly the output is wrong (iota should be incremented with each semicolon).

Currently the spec says iota's value increments after each ConstSpec, and AliasSpec is disjoint from ConstSpec.  So I think replacing "d" with "d = iota" would logically assign 2 to d, under the current wording.
That said, if we did want to change it to increment at semicolons, I'm not opposed to that.  I just expect in practice it won't really matter.  If we choose to increment only after ConstSpecs, users can still include blank ConstSpecs next to AliasSpecs to increment iota; conversely, they can move AliasSpecs out-of-line to prevent them from incrementing iota.

I agree with Matthew that the current interpretation is clear, and that it matters little in practice.  I also think the current interpretation is defensible: iota shouldn't increment after an alias declaration that can't possibly use it.

@mdempsky, @alandonovan Good point - with the current spec, incrementing iota with each ConstSpec is the same as incrementing with each semicolon...
There's a simpler solution: Do not alias const aliases in the first place. Just something to keep in mind.

If you replace => with = it prints
0 1 3.141592653589793 3.141592653589793 ( https://play.golang.org/p/4xOWo5vx8P )
Since => and = are essentially the same for consts, I'd expect them to behave identically.

Locking because aliases are no longer proposed.


[modify] contact : show contact addon condition

Coverage: 83.009%. Remained the same when pulling 6b0127ce97cc81a8b1ccc5f82cf9245c7b8f98e7 on fix-contact-addon into 3b4221d7c94f482fdb60ac92666f9d4d3ae8d37d on master.


Custom response messages with type set to ACK send CON

Hi!
I am trying to implement a CoAP server with custom responses and I've noticed that when I send a confirmable GET request to the server it responds with another confirmable request instead of an ACK
I am taking the simple/server and simple/client example code here with minor adjustments:

The type acknowledgement is set in the custom response in the handleB callback.

Changed the port to 5683 to show as CoAP message on Wireshark:

The issue is that while the SetResponse method on endpoint "/a" correctly sends with type ACK.

The custom response though set to ACK on endpoint "/b" does not send an ACK

Through debugging the server I found the problem comes from here in blockwise.go:

Where it's not possible to set a type other than CON or NON-CON.
Is there a reason why this does not allow for ACK types in this if statement? As in the blockwise examples in RFC7959-3.1 the responses use an ACK

Ok never-mind, I have found that using w.SetMessage to replace the response message instead of w.Conn().WriteMessage to create a new one, sets the response type to acknowledgement


Docker Image Created

https://hub.docker.com/r/retro64xyz/docker-keybase/
https://github.com/Retro64XYZ/docker-keybase
You can now install keybase from Docker using the command -
docker pull retro64xyz/docker-keybase
Would it be possible to get this added to the keybase.io site as an installation option in the documentation?

I think this should be an official image

I haven't tried to make it official or asked because I am having trouble
getting it to work under Mac. Works fine under Linux, but I can't get it to
run on any Mac computers.
On Thu, Mar 1, 2018 at 1:48 AM, Michał Czeraszkiewicz <
<EMAIL_ADDRESS>wrote:

I think this should be an official image
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/issues/7081#issuecomment-369518676,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZjtyZjK7-VtOouJ29XohRYNPUU3rLukks5tZ7XTgaJpZM4Nh3kG
.

How does this work with KBFS; is the build file exporting this for desktop use and I missed it?

@Retro64XYZ For me this breaks on the dpkg command. Using ; exit 0 the (expected) dpkg errors are ignored. Also I need to run the USER command before run_keybase. Perhaps you can give these changes a spin on a Mac.
RUN dpkg -i keybase_amd64.deb; exit 0
RUN apt-get install -fy
USER keybaseme
RUN run_keybase

I am making some changes now and this should work better soon.

On Mar 30, 2018, at 8:07 AM, Zeger Hoogeboom<EMAIL_ADDRESS>wrote:
@Retro64XYZ For me this breaks on the dpkg command. Using ; exit 0 the (expected) dpkg errors are ignored. Also I need to run the USER command before run_keybase. Perhaps you can give these changes a spin on a Mac.
RUN dpkg -i keybase_amd64.deb; exit 0
RUN apt-get install -fy
USER keybaseme
RUN run_keybase
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


ol.TileCache.prototype.pruneTileRange function can be optimized

After removing item from cache "i" counter variable can be decreased by 1. Currently system doing unnecessary iteration for every removed item.
Proposed code:
ol.TileCache.prototype.pruneTileRange = function(tileRange) {    var i = this.getCount(),        key;    while (i-- > 0) {      key = this.peekLastKey();      if (tileRange.contains(ol.tilecoord.createFromString(key))) {        this.pop().dispose();        i--;      } else {        this.get(key);      }    } };

Would you be able/willing to create a pull request with your proposed code?


Add permissions card to overview

This PR adds the permissions card to the virtualization overview.
Screenshots:

/test kubevirt-e2e-aws

/retest
/lgtm

/lgtm

@pcbailey can you investigate the e2e failings?

/hold
holding to stop the retests, @pcbailey @glekner  please unhold once the tests issue is fixed

/retest

/hold cancel

/lgtm


update packages

:x: Build TheIdServer 8.1.0-fix-dependencies.1+14.build.3831 failed (commit https://github.com/Aguafrommars/TheIdServer/commit/3495f44d82 by @invalid-email-address)

:white_check_mark: Build TheIdServer 8.1.0-fix-dependencies.1+14.build.3832 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/3495f44d82 by @invalid-email-address)


I have a question about SAMPLE generic-hyperlink-values

Sample
https://github.com/pnp/List-Formatting/tree/master/column-samples/generic-hyperlink-values
Question
The code shown in the example above:
{
  "$schema": "https://developer.microsoft.com/json-schemas/sp/v2/column-formatting.schema.json",
  "elmType": "a",
  "txtContent": "@currentField",
  "attributes": {
    "target": "_blank",
    "href": "='http://finance.yahoo.com/quote/' + @currentField"
  }
}

works well as long as the dynamic URL:

isn't a link to a SharePoint resource
which includes characters such as an ampersand &

For example, I am trying to generate a dynamic URL based on the value in another column.
The dynamic URL is a link to a filtered view of a document library, eg:
"attributes": {
  "target": "_blank",
  "href": "='https://tenant-name.sharepoint.com/sites/site-name/cd/Forms/My%20View%20Name.aspx?env=WebViewList&FilterField1=My_x0020_Reference&FilterValue1=' + [$Title]"
}

If the value in the other column includes an ampersand &, the URL breaks when clicking on the dynamic URL.
Is there anyway to URL encode the column value when adding it to the dynamic URL?

Hi @oshihirii !
How about replacing & with %26 using the replaceAll operator?
I tried the following method of using the replaceAll operator and was able to filter successfully even if the value contained &.
{
  "$schema": "https://developer.microsoft.com/json-schemas/sp/v2/column-formatting.schema.json",
  "elmType": "div",
  "children": [
    {
      "elmType": "a",
      "txtContent": "@currentField",
      "attributes": {
        "href": "= 'https://fiskawahara.sharepoint.com/sites/UIlcidTest-Enlgish/Filter/Forms/AllItems.aspx?FilterField1=Choice&FilterType1=Choice&FilterValue1=' + replaceAll(@currentField,'&','%26')",
        "target": "_blank"
      }
    }
  ]
}

Hi @oshihirii !
How about replacing & with %26 using the replaceAll operator?
I tried the following method of using the replaceAll operator and was able to filter successfully even if the value contained &.
{
  "$schema": "https://developer.microsoft.com/json-schemas/sp/v2/column-formatting.schema.json",
  "elmType": "div",
  "children": [
    {
      "elmType": "a",
      "txtContent": "@currentField",
      "attributes": {
        "href": "= 'https://<<tenantName>>.sharepoint.com/sites/<<siteName>>/<<documentLibraryName>>/Forms/<<View>>.aspx?FilterField1=Choice&FilterType1=Choice&FilterValue1=' + replaceAll(@currentField,'&','%26')",
        "target": "_blank"
      }
    }
  ]
}

The method without replaceAll did not filter properly for me as well.

Hi @tecchan1107 ,
Thankyou, it is a good idea and your approach is what I am implementing now.
For it to be a truly thorough solution, I am wondering if somebody smarter than me could figure out a replaceAll() that replaces all characters that SharePoint requires to be replaced in the URL.
That way we could be confident that any value we are grabbing from another column to create a filtered list URL (using JSON formatting) will be encoded as required.
I guess it would basically imitate an encodeURI() function.
The first step would be defining all the illegal characters in a SharePoint list URL.
I have searched and the only illegal characters I come across are those relating to file names, eg:
" * : < > ? / \ |

But I am not sure if they are the same characters that are not allowed in a SharePoint list URL.
Related Reading:
Restrictions and limitations in OneDrive and SharePoint > Invalid characters
Query String URL Tricks for SharePoint and Microsoft 365


Is there a short guide for embedding it into another program?

From looking at lily.c it seems that having a lily_parse_state, a lily_lex_mode and passing the code to lily_parse_string is all it takes. Do you have a simple example available, as well as one in which it is used as a dynamic library? C is not one of my strengths.
Is to_process the actual string passed to lily, ie the contents of the string or the file?

At the moment, no. Some of those functions will be changing when the api is done, and also I'll put some documentation up too.
If you're parsing a file, to_process is the filename. If you're parsing a string, to_process is the whole string to be processed.

I've updated the website, and included are a few examples of how to embed/extend the language, along with api documentation: lily-lang.org/embed_and_extend.html


FIX for #4710: Use INTERNAL dialogs instead of old alert() popups on server connection errors during ping.

Fix to address #4710. Also adding login prompt, in case server connectivity issues last long enough to timeout session due to failed pings.
Goals:

Use internal dialog instead of alert(), mainly to prevent window from stealing focus and for a less interrupted experience.
Provide the opportunity for the user to log back in via more fail-safe method on server access errors, i.e. new window instead in case server is down and <iframe> is not able to load inline within page.
Close the internal message dialog if everything is back to normal (at least in terms of server response).
In case user ends up locked out of server long enough (due to downtime) and then their session times out, provide opportunity once server is back online to log back into session.

What I had to change

Ping code, added more in-depth and specific checking on server response with more intelligent handling. Preventing display of multiple message over and over by checking for existing messages first.
Minor tweak to ssui.ssdialog in ssui.core.js to not require an <iframe> by simply checking to see if a URL was passed. That way you can still toggle/style modal dialogs without having to load a URL. This is important here, given the server could be down!
Performing an actual security check on ping (in the Security controller, no less) to facilitate more specific response checking client-side, which I think makes sense here.

What is still needed

Fix the entwine namespacing issues (see below).
Abstract that simple message code that I wrote to something reusable, maybe. I can see this being useful elsewhere; after modifying ssui.ssdialog in ssui.core.js, you no longer MUST have an <iframe> in order to display a nicely formatted SilverStripe dialog that just contains arbitrary HTML. I don't believe that you should have to create a tag; I think you should be able to call some sort of function (namespaced itself) and just give it the HTML or message you want to render. e.g. $.ss.simpleModal("My message here.").

IMPORTANT (unrelated to original PR): Originally I was able to work with calling the following in older 3.1 code, but ended up having to perform a hack/workaround to deal with a potential bug (or change?) in entwine namespacing. That is, calling this would work from within the ss.ping entwine namespace:
$('.cms-container').entwine('ss').showLoginDialog();

Now, I have to resort to something more like this in order to steal from the working scope of ss on its own, since this no longer works inside of the ss.ping scope:
var containerScope;
$.entwine('ss', function($){
    containerScope = $('.cms-container');
    window.containerScope = containerScope;
});

$.entwine('ss.ping', function($){
    $('.cms-container').entwine({
        _setupPinging: function () {
            containerScope.showLoginDialog();
        }
    });
});

We'll want to make sure we test this with a server down, pop-ups enabled, pop-ups disabled, etc, to confirm that it's solid, but the approach looks good.
Is there any way that we can test this with Behat? E.g. could we load the CMS, visit Security/logout in another window, pause, and then confirm the presence of the log-in-again screen? @chillu do you have any idea of the feasibility of that?

Oops, left the window debug variable in there, I'll have to take that out.

Will this get any love?

Rebase, please.

rebase please

Ok @dhensby, rebased and squeaky clean. Let me know what you think @tractorcow about this:
https://github.com/silverstripe/silverstripe-framework/pull/4722#discussion_r57829168
Discussion still continues however on #4710, so I don't really feel like this is ready for merge per se. Or if it's even usable (would need more time to look into it later when I can focus more on this).

@tractorcow :)

bump

As @patricknelson has made somewhat clear before, he won't have time to work on these PRs if changes are needed - can any core members take it on to get it over the line?

Unfortunately we're only doing security updates to SilverStripe 3 from now on, so I'll have to close this one.
If you feel this is still a worthwhile feature, please refactor it so it works with SilverStripe 4.

We now have a dedicated modal for this. So there's no point rebasing this on SilverStripe 4.


Error on generation

I'm executing this code:
Set sc = ##class(dc.openapi.client.Spec).generateApp("petshop", "https://petstore.swagger.io:443/v2/swagger.json")

and getting this error:
ERROR #5002: Error: <CLASS DOES NOT EXIST>zmodels+2^dc.openapi.client.Generator.1 *Grongier.OpenApi.Definition

Looks like Grongier.OpenApi.Definition class is not in repo: https://github.com/lscalese/OpenAPI-Client-Gen/blob/master/src/dc/openapi/client/Generator.cls#L173

Hi @eduard93,
Can you rebuild the image and retry :
docker-compose build --no-cache
iris.script has changed to install objectscript-openapi-definition
Thank you.

I'm not using docker - just installing on host.
After running:
 zpm "install sslclient"
 zpm "install objectscript-openapi-definition"
 zpm "install swagger-ui"

It works now.
Also got web app compilation error: Web application creation status Error #879: Role %DB_IRISAPP does not exist
I think it's caused by: https://github.com/lscalese/OpenAPI-Client-Gen/blob/76fcb96b2fc2ed239dc0efab37efa51ab489f18c/src/dc/openapi/client/Generator.cls#L252

Hoooo Yes, sorry for that...
I solve this.

May I consider this issue as fixed and close?

Sure!

Thank you!


added feature #460 option to create a new visit on the creation of a …

Fixes #460
Changes proposed in this pull request:

added a checkbox with property "createOutpatientVisit" to the add patient form
the checkbox is uncheck by default
added property "createOutpatientVisit" in the patient model
added a check to see if checkbox is checked then add new visit and redirect to new visit page

Note: pull requests without proper descriptions may simply be closed without further discussion. We appreciate your contributions, but need to know what you are offering in clearly described format. Thanks! (you can delete this text)
cc @HospitalRun/core-maintainers
…new Patient

@omoabobade Thank you for your PR!  I have made some comments above about the change you made.  Please take a look at them.  Also, I see that the tests are not passing and it appears the reason is because when you create a new patient it doesn't have any visits set which causes the errors.  If you change your code to only work on new records, we can fix this error.  I'll add more comments to your code to show you what needs to be done.

Also @omoabobade once you have made the suggested changes, you should run ember test in your development environment to verify all the tests are passing.  Alternatively you can run ember serve and then go to http://localhost:4200/tests to run the tests in your browser.

@jkleinsc does this just need to re-run the tests or this there a gap in the functionality that @omoabobade submitted?

@tangollama there are errors in the submitted PR that need to be corrected.  I highlighted above what those errors are and how to correct them,

Closing this PR in favor of merging in outpatient branch.