Sparrow No Longer Connects to Bitcoin Core

I am running bitcoin core 24.0.1 and am using Sparrow 1.7.6.  Sparrow is able to connect to bitcoin core very sporadically.  I am able to send rpc commands to my node using:
./bitcoin-cli -rpcconnect=<IP_ADDRESS> -rpcport=8332 -rpcuser=user -stdinrpcpass -getinfoRPC password>
Chain: main
Blocks: 787408
Headers: 787408
Verification progress: 99.9999%
Difficulty:<PHONE_NUMBER>3118.43
Network: in 0, out 10, total 10
Version: 240001
Time offset (s): 0
Proxies: n/a
Min tx relay fee rate (BTC/kvB): 0.00001000
Wallet: cormorant
Keypool size: 1001
Transaction fee rate (-paytxfee) (BTC/kvB): 0.00000000
Balance: (It gives me my balance)
Warnings:
./bitcoin-cli -rpcconnect=<IP_ADDRESS> -rpcport=8332 -rpcuser=user -stdinrpcpass getwalletinfo
RPC password>
{
"walletname": "cormorant",
"walletversion": 169900,
"format": "sqlite",
"balance": (Shows my balance),
"unconfirmed_balance": 0.00000000,
"immature_balance": 0.00000000,
"txcount": 3,
"keypoolsize": 1001,
"keypoolsize_hd_internal": 0,
"paytxfee": 0.00000000,
"private_keys_enabled": false,
"avoid_reuse": true,
"scanning": false,
"descriptors": true,
"external_signer": false
}
For some reason it is timing out.  The following is the log info:
2023-04-28 16:45:26,117 WARN [Thread-17] c.s.s.n.TcpTransport [null:-1] No response from server, setting read timeout to 34 secs
2023-04-28 16:46:00,168 WARN [Thread-14] c.s.s.n.TcpTransport [null:-1] No response from server, setting read timeout to 34 secs
2023-04-28 16:46:34,220 WARN [Thread-17] c.s.s.n.TcpTransport [null:-1] No response from server, setting read timeout to 34 secs
2023-04-28 16:47:08,271 WARN [Thread-14] c.s.s.n.TcpTransport [null:-1] No response from server, setting read timeout to 34 secs
2023-04-28 16:47:42,322 WARN [Thread-17] c.s.s.n.TcpTransport [null:-1] No response from server, setting read timeout to 34 secs
I have seen another similar thread:
https://github.com/sparrowwallet/sparrow/issues/770
I moved the old sparrow folder, rebooted the node and it works...once.  Then if I disconnect and try to reconnect I get the above timing out messages.

Unless you have useLegacyCoreWallet set to true in your Sparrow config file, you can ignore the earlier issue - it doesn't apply.
Is Bitcoin Core running on another PC? You can turn on DEBUG logging (see FAQ) to see which RPC commands are timing out (filter on BitcoindTransport).

Thank you for the reply.
useLegacyCoreWallet is set to false in my Sparrow config file.
Bitcoin Core is running on a Raspberry Pi 3B+ on my network.  I am able to RPC to it as shown above.
from debug.log in core nothing appears to be timing out as no errors are reported after Sparrow times out.

Core's debug.log is not particularly helpful for debugging RPC errors.
I again suggest using Sparrow's DEBUG logging, as described in my previous comment.

Did I not post the log info above?  If I posted the wrong log, which one was I supposed to post?

Sparrow's log (sparrow.log) can be found in Sparrow's home folder - see the FAQ for details.

Okay, thank you.
Here is what I found in sparrow.log for that day.
2023-05-02 18:50:13,732 ERROR [JavaFX Application Thread] c.s.s.p.ServerPreferencesController [null:-1] Connection error
java.lang.IllegalStateException: I/O error during request processing
at simple.json.rpc.client@1.3/com.github.arteam.simplejsonrpc.client.builder.ObjectApiBuilder.execute(Unknown Source)
at simple.json.rpc.client@1.3/com.github.arteam.simplejsonrpc.client.builder.ObjectApiBuilder.invoke(Unknown Source)
at jdk.proxy2/jdk.proxy2.$Proxy15.getNetworkInfo(Unknown Source)
at com.sparrowwallet.sparrow@1.7.6/com.sparrowwallet.sparrow.net.cormorant.bitcoind.BitcoindClient.initialize(Unknown Source)
at com.sparrowwallet.sparrow@1.7.6/com.sparrowwallet.sparrow.net.cormorant.Cormorant.start(Unknown Source)
at com.sparrowwallet.sparrow@1.7.6/com.sparrowwallet.sparrow.net.ElectrumServer$ConnectionService$1.call(Unknown Source)
at com.sparrowwallet.sparrow@1.7.6/com.sparrowwallet.sparrow.net.ElectrumServer$ConnectionService$1.call(Unknown Source)
at javafx.graphics@18/javafx.concurrent.Task$TaskCallable.call(Unknown Source)
at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
at javafx.graphics@18/javafx.concurrent.Service.lambda$executeTask$6(Unknown Source)
at java.base/java.security.AccessController.doPrivileged(Unknown Source)
at javafx.graphics@18/javafx.concurrent.Service.lambda$executeTask$7(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.base/java.lang.Thread.run(Unknown Source)
Caused by: java.net.ConnectException: Connection refused
at java.base/sun.nio.ch.Net.connect0(Native Method)
at java.base/sun.nio.ch.Net.connect(Unknown Source)
at java.base/sun.nio.ch.Net.connect(Unknown Source)
at java.base/sun.nio.ch.NioSocketImpl.connect(Unknown Source)
at java.base/java.net.Socket.connect(Unknown Source)
at java.base/java.net.Socket.connect(Unknown Source)
at java.base/sun.net.NetworkClient.doConnect(Unknown Source)
at java.base/sun.net.www.http.HttpClient.openServer(Unknown Source)
at java.base/sun.net.www.http.HttpClient.openServer(Unknown Source)
at java.base/sun.net.www.http.HttpClient.(Unknown Source)
at java.base/sun.net.www.http.HttpClient.New(Unknown Source)
at java.base/sun.net.www.http.HttpClient.New(Unknown Source)
at java.base/sun.net.www.protocol.http.HttpURLConnection.getNewHttpClient(Unknown Source)
at java.base/sun.net.www.protocol.http.HttpURLConnection.plainConnect0(Unknown Source)
at java.base/sun.net.www.protocol.http.HttpURLConnection.plainConnect(Unknown Source)
at java.base/sun.net.www.protocol.http.HttpURLConnection.connect(Unknown Source)
at java.base/sun.net.www.protocol.http.HttpURLConnection.getOutputStream0(Unknown Source)
at java.base/sun.net.www.protocol.http.HttpURLConnection.getOutputStream(Unknown Source)
at com.sparrowwallet.sparrow@1.7.6/com.sparrowwallet.sparrow.net.cormorant.bitcoind.BitcoindTransport.pass(Unknown Source)
... 15 common frames omitted

Ok, here's the critical line:
Caused by: java.net.ConnectException: Connection refused

For some reason, the client connection to the Bitcoin Core RPC is being refused. Given your previous comments it sounds like some kind of a network issue, but it's difficult to say more. I can say that the call that is failing is the first call Sparrow makes to Bitcoin Core during initialization. Have you setup Bitcoin Core with the correct rpcallowip config?

No response, closing this off.

Sorry for the slow reply.  I was away for the holiday.  Bitcoin cores seems
to be configured correctly as evidenced by the ability to run rpc calls
from terminal from the same computer that I am running Sparrow on.
On Mon, Jun 5, 2023 at 6:51 AM craigraw @.***> wrote:

No response, closing this off.
—
Reply to this email directly, view it on GitHub
https://github.com/sparrowwallet/sparrow/issues/952#issuecomment-1576642317,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALHHLQRRNL3NATTDOQ7SIU3XJXB3HANCNFSM6AAAAAAXPY7NVE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Have you setup Bitcoin Core with the correct rpcallowip config?

I suspect the cause of the problem here is Sparrow requesting a mempool dump from a low powered server. I'm not sure, but it may be that the RPC interface is simply too bogged down servicing this call to respond to any others. I'll have a think on how this situation can be improved.

I was wondering if that had something to do with it.  Core is running on a
Raspberry Pi 3B+.
On Fri, Jun 16, 2023 at 7:12 AM craigraw @.***> wrote:

I suspect the cause of the problem here is Sparrow requesting a mempool
dump from a low powered server. I'm not sure, but it may be that the RPC
interface is simply too bogged down servicing this call to respond to any
others. I'll have a think on how this situation can be improved.
—
Reply to this email directly, view it on GitHub
https://github.com/sparrowwallet/sparrow/issues/952#issuecomment-1594580908,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALHHLQV4WNCZCTOEQEJSZPLXLRERVANCNFSM6AAAAAAXPY7NVE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Fixed - see https://github.com/sparrowwallet/sparrow/issues/991#issuecomment-1598891571

Awesome! Thank you!  Looking forward to that making its way into an
upcoming release.
On Tue, Jun 20, 2023 at 9:22 AM craigraw @.***> wrote:

Fixed - see #991 (comment)
https://github.com/sparrowwallet/sparrow/issues/991#issuecomment-1598891571
—
Reply to this email directly, view it on GitHub
https://github.com/sparrowwallet/sparrow/issues/952#issuecomment-1598892256,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALHHLQT5RRGRVTNW2W55VZ3XMGWYTANCNFSM6AAAAAAXPY7NVE
.
You are receiving this because you authored the thread.Message ID:
@.***>


Translate tasks/setup-konnectivity/setup-konnectivity.md in Korean

This is a Feature Request

What would you like to be added

Translate tasks/setup-konnectivity/setup-konnectivity.md in Korean
Why is this needed
No translate tasks/setup-konnectivity/setup-konnectivity.md in Korean
Comments

Page to Update: https://kubernetes.io/docs/tasks/setup-konnectivity/setup-konnectivity/

/language ko
/assign


Feature: multiple networks

As we have proper staging environments now, we need to test changes on different networks.
We don't have no automation on domain creation so far, so let's have this 'forced' network option at least.

@luixo it works oddly in my testing. Server-side is working fine, but client-side navigation is mostly broken, e.g. if you go to https://frontend-pr-941-5pl1.onrender.com/blocks?network=testnet, and try to open any block, you will get "not found", and you need to refresh the page (go through server-side rendering) to get the page loaded correctly. Nevertheless, it is enough for the most use-cases these days.


New version: Binutils_jll v2.39.0+0

Autogenerated JLL package registration

Registering JLL package Binutils_jll.jl
Repository: https://github.com/JuliaBinaryWrappers/Binutils_jll.jl
Version: v2.39.0+0
Commit: 1cdc4afe4d8d605ef44b01f416bd5eb1f12d6792
Revision on Yggdrasil: https://github.com/JuliaPackaging/Yggdrasil/commit/e668f219e0139ef98e4c5ddef74530c8571cb7bf
Created by: @mofeing

@giordano Is there sth wrong with my recipe?

Apparently yes: c++filt isn't an acceptable name.  I should have noticed that you used Symbol("c++filt"), that should have been a red flag.  Can use something like "cxxfilt" instead.  But I also thought we had a check that the names have to be valid identifiers.
[noblock]


theme_mod not working on some scenario.

Issue description:
theme_mod is not working when placed in add_config see the code below
Version used:
Version : 2.3.6
Using theme_mods or options?
Both
Code to reproduce the issue (config + field(s))

// Start Not working

All code save under 'mrc' key, on theme_mod nothing is saved

Kirki::add_config( 'wpcb_my_config', array(
        'capability'    => 'edit_theme_options',
        'option_type'   => 'option',
        'option_name'   => 'mrc',
    ) );

Kirki::add_field( 'wpcb_my_config', array(
        'type'          => 'text',
        'settings'      => 'banner_heading',
        'label'         => __( 'Banner Heading', 'HN' ),
        'section'       => 'banner_section',
    ) );

Kirki::add_field( 'wpcb_my_config', array(
        'type'          => 'text',
        'settings'      => 'banner_heading2',
        'label'         => __( 'Banner Heading', 'HN' ),
        'section'       => 'banner_section',
        'option_type' => 'theme_mod',
    ) );
// End Not working

// Start working

Kirki::add_config( 'wpcb_my_config', array(
        'capability'    => 'edit_theme_options',
        'option_type'   => 'option',
    ) );

Kirki::add_field( 'wpcb_my_config', array(
        'type'          => 'text',
        'settings'      => 'banner_heading',
        'label'         => __( 'Banner Heading', 'HN' ),
        'section'       => 'banner_section',
        'option_type'   => 'option',
        'option_name' => 'mrc'
    ) );

Kirki::add_field( 'wpcb_my_config', array(
        'type'          => 'text',
        'settings'      => 'banner_heading2',
        'label'         => __( 'Banner Heading', 'HN' ),
        'section'       => 'banner_section',
        'option_type' => 'theme_mod',
    ) );

// End working

Quick reply will be very helpful. Thanks

Do you change the values of those controls?
Only changed controls get saved.

Yes i did changed the values. Is this a bug ??

Wait a minute 'cause I think I may have misunderstood initially what you're saying.
So... If your config uses options and you have option_name defined, then you can't override the data-type in a specific control and make it use theme_mods, but if the option_name is not defined in the global config then you can override the data-type on specific fields and make them use theme_mods?

So... If your config uses options and you have option_name defined, then you can't override the data-type in a specific control and make it use theme_mods, but if the option_name is not defined in the global config then you can override the data-type on specific fields and make them use theme_mods? In other words the data is saved, but the per-field override to theme_mods doesn't work when the global config has option_name defined?

=> Yes, Exactly

Pleasy try using the version from the development branch on this repository.
I believe this one was just fixed.
Please confirm so that I may include this fix in the next version of the plugin... 👍

It worked :+1:


Fix for zenodo token tests

@Maurier This PR should fix the build errors we have been seeing with all our PRs for a long time. It would be good to merge this one first so that the remaining PRs can pass the build stage.


Ansible request for directory creation on Windows

Please put the name of the software product (and affected platforms if relevant) in the title of this issue
Delete as appropriate from this list:

Bug in ansible playbook

Details:
Windows playbooks utilise but do not create c:\temp which is required for some playbook roles and it is not on all machines by default. Similarly c:\openjdk which is required when creating the symbolic links with mklink will fail with The system cannot find the path specified

@sxa believe these directories are created at the very beginning of the Common role in the windows playbook. Can you see if you can reproduce this, as I am unable.

Removing from the September plan until I can attempt to reproduce on a clean Azure deployment (Unsure which type of machine I hit this on)

Hit this again today when using a new Windows system created at Azure:
AWX link: https://awx2.adoptopenjdk.net/#/jobs/playbook/553
Created the directory manually to work around it.

I notice in the awx jobit has the skipped tag "basic_config" , the task that creates the c:\temp dir has this tag..
- name: Create C:\temp directory
 win_file:
   path: C:\temp
   state: directory
 tags: basic_config

I notice in the awx jobit has the skipped tag "basic_config" , the task that creates the c:\temp dir has this tag.. - name: Create C:\temp directory  win_file:    path: C:\temp    state: directory  tags: basic_config

Well spotted - I don't recall why that is there. We should probably check whether the use of that role is a sensible approach for creating those directories ...


Remove node_modules from Makefile

Just an idea to make your Makefile lighter to follow.
If you use npx, then you can execute files in node_modules/bin directly.
e.g.
$ npm i eslint

$ npx eslint --fix

So Makefile can be like this, without setting up the bin path.
lint:
  npx eslint --fix

Oh and if eslint is not installed in the project, then it will be referenced globally, or it will be downloaded and run globally.

Another option is to use scripts in package.json which is empty.
{
  "scripts": {
    "lint": "eslint --fix"
  }
}

Then you can run
$ npm run lint

Without caring about bin path or npx.

Thanks for your reminder of the best practice, I know all of these, just didn't pay attention, I will take a try of npx next time


Hyperparameter optimization example notebook

New notebook, optimizes the initial point for the hyperparameter optimization of a spectral mixture kernel

Codecov Report

Merging #35 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #35   +/-   ##
=======================================
  Coverage   99.69%   99.69%
=======================================
  Files           8        8
  Lines         660      660
=======================================
  Hits          658      658
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bba551...807e0e4. Read the comment docs.

Updated the notebook a bit. As a final change I added some sections to it as I feel it reads nicer. If you decide to keep them, it is best to update the other notebooks with sections too to keep everything uniform.


[CDC] Fixed command expression errors reported in WARN #124001

This PR fixes command expression errors as below
WARN [#124001] : DEBUG CLI: Could not parse given expression into a valid database query. Perhaps some column headers are wrong. Skipping...
Signed-off-by: Joshua Park<EMAIL_ADDRESS>

While waiting for merge, I added another commit that had waivers for DATA REVIEW items.


Use HTTPS for CDN hrefs

can we just remove all protocols > // ?

I've been using https:// now, rather than //, per https://twitter.com/paul_irish/status/588502455530311680.

Maybe there's a performance implication with using HTTPS when the site is requested over HTTP. Whatever we choose, it should ideally be consistent.

Let's go with Paul Irish; apparently calling // will call the resource with the same protocol of the calling page.
http://blog.wikimedia.org/2011/07/19/protocol-relative-urls-enabled-on-test-wikipedia-org/


is anyway use validation api with annotated service method

i found in com.linecorp.armeria.internal.server.annotation.AnnotatedService#invoke body, use resolvers get argumetns , and then invoke method.
if i want use validation-api  annotation such as javax.validation.constraints.NotNull in method parameter and check before invoke . is anyway to support this pattern.
additional , use spring aop can support it , but is possible support by armeria?

Hello! @guxingke
In an annotated service, the parameters are not nullable by default unless they are annotated @Nullable or Optional.
Do you want to use javax.validation.constraints.NotNull specifically, or want to use other annotations in the validation library such as @Max, @Min or etc?

hello @minwoox
yes, in my case , when consumer json object with RequestObject anotated parameter,  i want to use javax.validation.Valid for this parameter,  the obj fields has some annotations from the validation library.

I see. It's probably a good idea to support those annotations in the javax.validation.constraints package. Are you interested in sending PR for this? or do you want to wait for the feature? Meanwhile, you might use RequestConverterFunction to validate before we implement this feature.

I checked the method signature of RequestConverterFunction , and i found it can not get the service-method parameter annotations , it means use custom RequestConverterFunction cannot do on-demand validation by annotation.

cannot do on-demand validation by annotation

Exactly. We need to do the validation manually at the moment. 😄

Other constraints like @NotBlank are also useful if you can support them!

will be nice if we integrate with libraries such as Hibernate Validator.


Added a link to the example command.

Added a link to the example to help navigate through the document.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Thank you @mikecasas for the content contribution!


How to set up Dapr on an EKS cluster guide

Adding an AWS EKS guide for Dapr install to complement the others https://docs.dapr.io/operations/hosting/kubernetes/cluster/

We're just starting our journey and exploring Dapr on EKS as part of an internal POC so I'll take a stab at getting this documented.

We just started an internal POC for Dapr on EKS and I'll take a stab at getting a guide together in the next couple of weeks here as we go through this journey.
(deleted the previous message - was logged in as the wrong account)

We just started an internal POC for Dapr on EKS and I'll take a stab at getting a guide together in the next couple of weeks here as we go through this journey.
(deleted the previous message - was logged in as the wrong account)

Thanks! That would be great.

Hi @hhunter-ms - Thanks for the nudge :)  This did drop off my radar.  I'll add it to my queue for next week. I do still have access to our EKS cluster (or the ability to spin up a new temporary one to document) so this should be pretty easy.  I'll let you know if I need any assistance on the documentation.  Thanks!

@hhunter-ms going to have this as a good first issue for Grace Hopper

Hi @hhunter-ms.
I'm trying to install DAPR on my EKS cluster. My cluster has Security Group for Pods enabled and we use IAM roles for service accounts to provide temporary AWS credentials to our pods.
I have difficulties to understand the necessary AWS perms each component require, and the protos and ports to open between my application pod where the dapr sidecard is injected, the DAPR control plane (dapr-system) and the EKS cluster control plane.
I saw this issue was marked as completed but I can't find the EKS cluster guide on DAPR doc: https://docs.dapr.io/operations/hosting/kubernetes/cluster/
Could you please please share the EKS guide link?
Thanks in advance
Regards
Mickael

derstand the necessary AWS perms each component req

Hello @mickael-ange , were you able to solve your issue? I'm trying to deploy dapr to AWS EKS too and sidecar injection doesn't seem to be working for me.

Hi @paulafahmy
Yes, I come up with the following simple security groups configuration.
I created 2 Security groups:

The DaprSystems SG which should be attached to pods in the dapr-system namespace. To attach the SG to all DAPR systems, I created the dapr-systems SecurityGroupPolicy with the following (Ansible) config.

    - name: Configure k8s SecurityGroupPolicy for DAPR Systems
      kubernetes.core.k8s:
        definition:
          apiVersion: vpcresources.k8s.aws/v1beta1
          kind: SecurityGroupPolicy
          metadata:
            name: dapr-systems
            namespace: dapr-system
          spec:
            podSelector:
              matchLabels:
                app.kubernetes.io/name: dapr
            securityGroups:
              groupIds:
                 - sg-xxxxxx # The `DaprSystems` SG ID
                 - sg-yyyyyy # EksPod SG which is attached to all my pods which allows communication from my EKS Nodes

The DaprSidecar SG which should be attached to the pod containing your application where the DAPR sidecar will be injected. To attach the SG to the application pod, I created the my-app SecurityGroupPolicy with the following (Ansible) config.

    - name: Configure k8s SecurityGroupPolicy
      kubernetes.core.k8s:
        definition:
          apiVersion: vpcresources.k8s.aws/v1beta1
          kind: SecurityGroupPolicy
          metadata:
            name: my-app
            namespace: my-app-ns
          spec:
            podSelector:
              matchLabels:
                app.kubernetes.io/name: my-app
            securityGroups:
              groupIds:
                  - sg-xxxxx # My app SG ID
                  - sg-yyyyy # DaprSidecar SG ID
                  - sg-zzzzz # EksPod SG which is attached to all my pods which allows communication from my EKS Nodes

The ingress rules for each security group are as follows:

DaprSystems (The EksCluster SG is the one that is attached to my EKS cluster)

DaprSidecar: No rules
EksPod: allow all TCP ports from EKS Nodes SG to EKS Pods. Mainly for probes.

I hope it can help you.
Cheers

Adding an inbound rule in worker security group to enable traffic at port 4000 from Control plane worked for me. Sidecar containers are getting injected successfully after that.

I have a PR opened for this issue: https://github.com/dapr/docs/pull/4279

this was resolved - closing - thank you @rochabr


[WIP] Add NVTabular+Dask example notebook

closes #175

Looks like there are isort failures for files not touched by this PR - cc @jperez999

@benfred - I'm sure there is more to do here, but I welcome your feedback if you get any free time.


Add Git and GitHub for Beginners - Crash Course

What does this PR do?
Add resource(s)
For resources
Description
It is a short course on youtube by freecodecamp
Why is this valuable (or not)?
It is valuable because, it is taught in short period of time.
How do we know it's really free?
It is on YouTube
For book lists, is it a book? For course lists, is it a course? etc.
It is a Course
Checklist:

[x] Read our contributing guidelines
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction)

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

For youtube, we prefer "playlist" links and the name of the producer/creator.


Submission/data repos

I'd initially been thinking that we should have separate repositories for submissions and official data. Lately I've been leaning toward a single-repo model. Now that we have adopted the Dataset framework there seems little need to have a completely separate repo to e.g. reorganize the data. If we want to make changes like adding RDKIT_BINARY values to the official data, we could just create a PR on the single repo. I also like the idea of preserving the commit history from the submissions.
Thoughts? Any reason we'd want a separate repo with its own history?

I agree that two separate repos might be unnecessary. I like having the commit history from submissions more easily accessible via the official repo (rather than having to refer back to the submission repo).
I think I would like to have the RDKIT_BINARY values be part of the official repo, but I'm not sure how to balance that with the lack of readability in the pbtxt format

Decision: one repo; RDKIT_BINARY won't be added intentionally for now for versioning reasons.


pKa type I analysis with closest and hungarian matching

This PR adds type I microscopic pKa analysis performed based on predicted pKa values, ignoring predicted microstate ID pairs.
We assume that experimentally determined pKas of molecules with only 1 pKa or well separated multiple pKas (more than 3 pKa units apart) can be treated as microscopic pKas. Type I predictions of molecules SM14 and SM18 were not included in this analysis since their experimental pKa values don't satisfy these criteria.

The new analysis is located in this directory: https://github.com/MobleyLab/SAMPL6/tree/pKa_typeI_analysis/physical_properties/pKa/analysis/analysis_of_typeI_predictions
@bannanc Could you please have a look?

@davidlmobley @jchodera @MehtapIsik
I probably won't have time until Sunday or Monday to review.

In that case, wouldn't it be useful to just merge? I am thinking it is important that participants can see and comment on this analysis approach sooner than later.

Previously I analyzed macroscopic pKas predictions (type III) using pKa value similarity-based matching to experiments.
Now I adopted this approach to microscopic pKa predictions. The working assumption is that experimental pKas are a good approximation of microscopic pKas, if experimental values are well separated.
This is one approach to assess microscopic pKa predictions in the lack of experimental microscopic pKa data.  I would like to share this set of results with participants with an email announcement.
I will continue to work on another approach to analyze microscopic pKas by calculating modeled macroscopic pKas.

@davidlmobley Do you have any remaining concerns about this analysis or would it be OK to proceed with merging?


New Embed: some users found test code tab confusing

In the recent UX study, some participants found the test code tab confusing or didn’t see the value of explicitly showing it.
We would like to evaluate a proposal in the UX fork: hiding the test code tab

Hide the tab from the start
Add a more menu with an option to show test code

cc: @johnpryan

From Round 2 UX study, participants could pass the exercises without referring to the test code. So this is ready to be implemented.
--
However, two minor UI bugs found in the prototypes https://github.com/dart-lang/dart-pad/commit/296c7865e71bb14126c2768b24f8b91ee75a3338

Demo mode (no exercises) should not have this toggle option.

If users hide the test code via toggle button/checkbox while they are focus on the test code tab, they should be refocus on the "Your code" tab

This is current status in the ux branch:
Action: clicked on menu, marked the checkbox as checked, clicked the on the test code tab.

Action: stayed on the same test code tab, unchecked it, no tab is focused and displayed.

cc: @johnpryan


Testing steps | Logs query

Hello,
Would like to confirm information about "DHOSReliability" for "computer name" field.
Current setup build as:

Created log analytics workspace with pricing tier per GB 2018
Added Device Health to tenant
Deployed id and logs settings via Intune and devices do onboard fine

But when query logs for devices or apps info or "DHOSReliability", the Computer name shown as "unknown".
Any ideas why?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: af1d6af3-9530-fd12-cd25-52c904c5ac58
Version Independent ID: 8d5d6869-1ea9-05e3-76e9-4970fe1e7871
Content: Using Device Health
Content Source: windows/deployment/update/device-health-using.md
Product: w10
Technology: windows
GitHub Login: @jaimeo
Microsoft Alias: jaimeo

@officedocsbot assign @mypil

@lightupdifire -  Thank you for submitting feedback.
I will get this issue over to the Win10 ITPro writing team for investigation.
Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

@MatthewMWR , @Deepamdubey , is this something you can address? Let me know if there is a doc edit need here.

To enhance consumer privacy, recent versions of Windows 10 no longer include the device name in Windows Diagnostic Data by default. By extension, the device names are not available in Windows Analytics solution by default.
To enable the devices to send their device name, you need to configure allowdevicenameintelemetry via the UR deployment script or Group Policy, etc. For reference:
https://gpsearch.azurewebsites.net/#13763

@MatthewMWR
As far understood, Device Health presented as "new solution", that can exist without UR deployment..
And we try to avoid any script deployment.
Thanks for guide for "allowdevicenameintelemetry", I see CSP policy exist, can play with that.
Regards "Device Health" article, maybe it is good to explain that if you deploy "Device Health" as standalone, without UR deployment, then there is limitation, or create an FAQ article for "Device Health" and explain what limitation could be?

@MatthewMWR - We would like to follow up. Do you have any information on the additional question from @lightupdifire?
Thanks.

I'm not 100% sure I understand the question. Is it essentially "would a Device Health customer lose out on any Device Health features if they don't also use UR and/or UR deployment script?". I'll try to answer that question for now.
There are no hard dependencies between the solutions (there are shared dependencies like deploying CommercialID, but no dependencies between the actual solutions in Log Analytics). If a customer is not using UR then DH deployment is typically best done via simple configuration like deploying the policies via MDM or GP (no need for deployment script).
I can imagine some specific cases where deploying DH together with either UR or UR deployment script could add value, for example:
You could have a connectivity issue between your PCs and the Microsoft endpoints used by UR and DH, and the UR deployment script would help to find these sooner.
You could have a custom Log Analytics query which cross-references UR and DH data.

@MatthewMWR ,
Thanks for you answer, this confirm that DH can exist as standalone solution,
Then please add to this article (or create FAQ) about limitations or like "fine-tuning required", like computer name will be not shown in logs and required to add CSP policy via Intune.
I could fix computer name using Intune CSP policy:
OMA-URI: ./Vendor/MSFT/Policy/Config/System/AllowDeviceNameInDiagnosticData
Data type: Integer
Value: 1

@lightupdifire - From our understanding, the issue has been resolved. If you feel it hasn't been resolved, please re-open this issue.
Thank you for your contribution to make the docs better! Much appreciated!


[Feature Request] Hide Retweets and Replies in Groups and/or Globally.

Original posts tend to get lost if a user RTs or replies a lot. Therefore an option to hide them will be useful.

I second this, especially the replies.
It makes group viewing exponentially longer to go through based on how active a tweeter user is with replies.

Interesting idea, and one that could improve usability a lot. It could also make sense to display an icon or caption above a tweet to say it's a reply, and to also make the "replies" icon at the bottom tappable for tweets with replies, just so the context isn't removed.

Not seeing any replies or retweets in my feed after updating the app to 2.3.2 so I guess you can close this issue now.
Thanks for the great work! 👍

I agree the answers are sometimes annoying in the timeline. But, on the other hand I personally have several groups where I would like to be able to see the retweets as well.
When you subscribe to someone it's not necessarily to see their replies but I think you can accept that it's also to see what they retweet...
So I don't know if this is possible but rather than taking away this possibility from the users why not let them choose ?
If this is possible It's probably more work for @jonjomckay (sorry) but I would find it more relevant...

@alphanerdgen I don't think that was something I did - it's probably the Search API just not returning those tweets now. The PR for this issue (#71) will address the comments here by providing an option on subscription groups to enable or disable replies and retweets, but it'll only work on the tweets that actually get returned in the current method I'm using to list the tweets, which doesn't show everything.
I plan to tackle that in another issue, as it probably requires a complete overhaul of how subscription group feeds are constructed.


How to deal with printing content inside ember-light table

Hello,
In my project, I am trying to prepare an ember-light table for printing with a print.css stylesheet. I have multiple expanded rows, which in a printed format would take multiple pages. My issue is that, I cannot find a way to make ember-light table be visible in its full height, in other words to be able to print the entire content of the table. Because right now, only the part, to which I've scrolled to is visible, making it inconvenient for printing. Thank you in advance!

We already have an issue for that:  https://github.com/offirgolan/ember-light-table/issues/471  :wink:
Concerning printing a scrollable table (with fixed header / footer), you'd need to overwrite the styles that set stuff like overflow: scroll and position: absolute.

@buschtoens Oh yes, I was just looking at this one, sorry about that. I followed what @Techn1x did and it worked pretty well, however it forced me to remove the height declaration, which killed the purpose a little bit of having the table be set in one place, without having to go down the page.

Sounds like a CSS problem. I suggest manually "undoing" all styles set by fixed=true and incorporating what #471 does. Since this a duplicate of that issue, I'd rather not scatter the discussion about multiple issues and continue there.


[BTC Bridge] Rust client & react web-based dashboard for vaults

Description
Harmony is in the process of building a trustless bridge to Bitcoin using Interlay's XCLAIM protocol. There are several components of the bridge. Vaults are the heart of the OneBTC bridge. They are responsible for maintaining the physical 1:1 peg between BTC and OneBTC. Vaults receive BTC for safekeeping from users and ensure BTC remains locked while OneBTC exists.
This bounty needs to port Interlay's PolkaBTC vault rust client to Harmony, which is currently implemented for Polkadot. The bounty also needs to develop a minimal react web-based dashboard for vaults showing issue, redeem and replace requests, collateral status, BTC holdings and earned fees.
Resources

PolkaBTC Vault rust client code: https://github.com/interlay/polkabtc-clients/tree/master/vault
Vault documentation is available in https://docs.polkabtc.io/#/vault/overview
Vault detailed spec is available in https://interlay.gitlab.io/polkabtc-spec/spec/vaultregistry.html

Requirements

Rust programming
React web development

Acceptance Criteria

[ ] Fully port PolkaBTC's vault rust client to Harmony including tests and examples
[ ] A react web-based dashboard for vaults
[ ] Both submited as PR to https://github.com/harmony-one/onebtc

Reference

Harmony's Trustless ONE<>BTC Bridge

Reward
$15,000 equivalent in ONE tokens

@gupadhyaya Is this bounty listed on gitcoin? Is it open?

@dB2510 https://gitcoin.co/issue/harmony-one/bounties/43/100025919

Given that many of the ONE<>BTC bridge and relay contracts are incomplete relative to the ONE<>BTC spec, is it sufficient to have placeholders in the ported code sections for which there is not yet an equivalent contract function that can be executed? Otherwise, it's very difficult to port the Vault client without a full understanding of the logic behind both the spec and the contracts as they are implemented.

@gupadhyaya ^

Given that many of the ONE<>BTC bridge and relay contracts are incomplete relative to the ONE<>BTC spec, is it sufficient to have placeholders in the ported code sections for which there is not yet an equivalent contract function that can be executed? Otherwise, it's very difficult to port the Vault client without a full understanding of the logic behind both the spec and the contracts as they are implemented.

we have extended the deadline till aug 9th and by then, we will try to get all the contract interfaces figured out at least. feel free to keep making progress and keep us posted. thanks.

A bit late. But is it still open @gupadhyaya ? On the bounties is has the status open.

@srstomp It is open but we were planning to close it by end of this week. Are you actively working on it? Do you have an ETA?

@srstomp It is open but we were planning to close it by end of this week. Are you actively working on it? Do you have an ETA?

does this issue still need to be done?


What identifiers do apps use in lieu of AAID?

We discussed in #56 that apps may use their own identifiers. This raises the question whether and how apps use alternative identifiers for user tracking, e.g. a Facebook ID.

I will look into other settings that could be helpful to disable/point out (e.g. Location History)

Maybe, we'll eventually be able to automate the Android privacy settings,
e.g. with the Accessibility API.
Am Dienstag, 25. April 2023 schrieb Wesley Tan @.***>:

I will look into other settings that could be helpful to disable/point out
(e.g. Location History)
—
Reply to this email directly, view it on GitHub
https://github.com/privacy-tech-lab/gpc-android/issues/58#issuecomment-1521827006,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABHPPJRSQRJGF5PFDD66YKDXC7JFRANCNFSM6AAAAAAXLA4VK4
.
You are receiving this because you authored the thread.Message ID:
@.***>

There's also the collection of diagnostics data in the Google settings.
Am Dienstag, 25. April 2023 schrieb Konrad @.***>:

Maybe, we'll eventually be able to automate the Android privacy settings,
e.g. with the Accessibility API.
Am Dienstag, 25. April 2023 schrieb Wesley Tan @.***>:

I will look into other settings that could be helpful to disable/point
out (e.g. Location History)
—
Reply to this email directly, view it on GitHub
https://github.com/privacy-tech-lab/gpc-android/issues/58#issuecomment-1521827006,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABHPPJRSQRJGF5PFDD66YKDXC7JFRANCNFSM6AAAAAAXLA4VK4
.
You are receiving this because you authored the thread.Message ID:
@.***>

In response to the phase out of the AAID, apps must surely come up with alternative. Facebook's Advanced Matching and Google's Enhanced Conversions fall into this category. What other approaches do apps use?  I imagine, for example, that some apps may use the same intent-based approach that I used in my early GPC for Android prototype, but for tracking.

Some other indicators are:
First-party data: Apps can rely more on first-party data, which is collected directly from users within the app ecosystem, such as user preferences, app usage patterns, and in-app interactions. This data can be used for personalization and targeting while complying with privacy regulations.

This is somewhat like the Facebook ID mechanism. Honestly not sure what we can do about this since these are permissions that users of the respective apps have to agree too.
Device graph: This approach involves linking multiple devices used by the same user to create a "device graph." This can be done using various data points, such as IP addresses or login credentials. By understanding the relationship between devices, apps can track user behavior across devices without relying on AAID.
For instance, Developer Chainfire released an app named Pry-Fi for Android. It gives your phone a pseudo-IMEI that changes regularly. (For situations in which a store tracks you by MAC address). And that’s about the only legitimate use an app would have to access the MAC address. (But not the IMEI - the phone doesn’t do anything with it - it’s the phone’s serial number and, in conjunction with the SIM card’s number, your phone gets authenticated to the cellphone network.)
https://developer.android.com/about/versions/10/privacy/changes. Some relevant functions include
getImei()
getDeviceId()
getMeid()
getSimSerialNumber()
getSubscriberId()

Here is a look at Instagram's ad-tracking mechanism:
https://github.com/privacy-tech-lab/gpc-android/assets/121606501/ad11f131-6c78-4fcc-a9f0-f13b06e835a3

Closing for now. Nothing more to say for now ...


Plugin Missing or incompatible

Hello,
I want to test Seurat.
I am using Unreal Engine 4.16.3. The plugin was develop against a 4.16 version.
I did the following steps:

Downloading plugin
Copying the "Plugins"-folder of the plugin in project-folder.
Starting Unreal Engine and create an empty (blank) Blueprint-Project
Enable Seurat plugin under Edit -> plugins -> Other -> Seurat,
Restart the project.

Then I get following error:

"Missing or incompatible modules in Seurat plugin - would you like to disable it? You will no longer be able to open any assets created using it."

When clicking yes, following error occurs:

"Plugin "Seurat" failed to load because module "Seurat" could not be found. Please ensure the plugin is properly installed, otherwise consider disabling the plugin for this project."

I also get the error when copying the plugin into Unreal Engine\Engine-Folder instead of project folder.
What can I do? How can I use the plugin?
Best regards
Update: ----------------------------
I already tried following tutorial to get everything working:
https://medium.com/@slonorib/how-to-use-seurat-with-unreal-engine-4-2a52fb9e52cf
I also added the following line to the "Seurat.Build.cs":
PCHUsage = PCHUsageMode.UseExplicitOrSharedPCHs;
But I still get the error that plugin is not compatible :(
Update 2; -------------------------------------
I also tested a blank Blueprint and a blank C++ Project. For the C++ Project, Windows SDK 8.1 must be installed. But it still does not work. When enabling the plugin, following error is shown:

The following modules are missing or built with a different engine version:
UE4Editor-Seurat.dll
Would you like to rebuild them now?

If I click yes, following is shown:

Project could not be compiled. Try rebuiding from source manually.

I really want to test that aweasome plugin in Unreal Engine :(

I already tried following tutorial to get everything working:
https://medium.com/@slonorib/how-to-use-seurat-with-unreal-engine-4-2a52fb9e52cf
I also added the following line to the "Seurat.Build.cs":
PCHUsage = PCHUsageMode.UseExplicitOrSharedPCHs;
But I still get the error that plugin is not compatible :(

This article will help you recompile the plugin.
https://github.com/ufna/VaRest/wiki/Plugin-Installation---compile-from-source
Follow the instruction but obviously use the Seurat plugin instead.
I was able to recompile the plugin for Unreal 4.18.3.
The Unreal plugin won't work with 4.21 or above as Unreal deprecated FHighResScreenshotConfig.SaveImage() function - which the plugin relies upon.  https://docs.unrealengine.com/en-US/API/Runtime/Engine/FHighResScreenshotConfig/index.html

Thanks for yout answer.
Unfortunately, I get the same error with 4.18.3. As soon as I enable the plugin in edit -> plugins, Unreal Engine wants to restart.
After restart, I get the errors as descriped above:
The following modules are missing or built with a different engine version:

UE4Editor-Seurat.dll

Would you like to rebuild them now?

and then, I get
Project could not be compiled. Try rebuiding from source manually.

It does work :)

Disable the plugin from your project and close Unreal.
Copy the Seurat plugin to the Engine plugin folder (if you haven't already).
Create a blank C++ project in Unreal as per the instructions here - https://github.com/ufna/VaRest/wiki/Plugin-Installation---compile-from-source
Do not enable the plugin. Close Unreal.
Simply copy the plugin to the projects plugin folder.
Add PCHUsage = ModuleRules.PCHUsageMode.UseExplicitOrSharedPCHs; to the Seurat.Build.cs file in the project plugin Seurat source folder
Load Unreal and the blank project, you should be prompted to recompile the plugin.

If that doesn't work, post your logs (ProjectFolder/Saved/Logs).

Hey, are Step 2 and step 5 not the same?
In Step 2, I am copying the plugin in my Unreal Engine folder, and in step 5, i am copying it in my project folder. Where is the difference?

When doing so, there is so prompt to recompile the plugin.
This is my setup:
Seurat Plugin is in:
C:\Program Files\Epic Games\UE_4.18\Engine\Plugins\Seurat
and in
C:\Projects\Unreal Engine\SeuratTest\Plugins\Seurat
(SeuratTest is the project folder)
Are my folders correct?
e.g. I have following paths to the Seurat.Build.cs
C:\Program Files\Epic Games\UE_4.18\Engine\Plugins\Seurat\Source\Seurat\Seurat.Build.cs
and
C:\Projects\Unreal Engine\SeuratTest\Plugins\Seurat\Source\Seurat\Seurat.Build.cs
I only adjusted the Seurat.Build in my Project folder (adding PCHUsage = ModuleRules.PCHUsageMode.UseExplicitOrSharedPCHs;)

Your folders are correct and yes the folder structure is correct.
You could try removing Seurat from C:\Program Files\Epic Games\UE_4.18\Engine\Plugins and try again.
Nothing in your log indicates why or if the compile failed.
Here's the compiled Seurat plugin I created for 4.18.3. Hopefully it will work for you. Copy it to your engine folder. http://www.mediafire.com/file/ecknwh0z8l6ke1f/Seurat.zip/file

@DaRockJaeger Did that work for you?

Hello vmattc,
Thank you for uploading the compiled Plugin. I am capturing my Unreal Scene at the moment :D
But it is strange that I was not able to compile the plugin by my own.

I managed to update the plugin code to work with Unreal 4.22 too.
However, I'm experiencing the same "cracks" and texture artefacts that everyone is (in capturing and importing in both Unity and Unreal). Looks fine in Butterfly, but seems that there's some fundamental issue with Seurat when using it with Unreal and Unity.
@davejrichardson & @manfred-ernst any news on Seurat development or possible help solving the crack issues?

We've managed to get the capture and rendering working in UE4 without cracks - the main issue for us has been the documentation doesn't match the requirements for UE4.
For us at least the issues were that the -skybox_radius needs to be set to 20000 for seurat to correctly build the mesh from a UE4 capture (or it effectively builds a high-res broken cube mesh with projected textures), and that the UE4 plugin docs state to make a translucent material whereas the default settings are for pre-multiplied alpha, which causes texture artifacts, as would be expected.
So either setting -premultiply_alpha=false in the seurat command line params or setting the UE4 material blend mode to be AlphaComposite (pre-multiplied) gave us a reasonable UE4 pipeline without any major cracking issues. It still doesn't look that great though it must be said.
Unity is a whole different kettle of fish however and both the capture and mesh display are basically broken for us at the moment.

@publicdomaincorp Thanks for the reply, yep I just figured out the premultiply_alpha setting too. I have it working in Unity fine now as well as UE4 v 4.22. No cracks now which is great.

I managed to update the plugin code to work with Unreal 4.22 too.

He vmattc, can you please please upload the plugin for 4.22? It would be great if am able to use the newest unreal engine with Seurat :D

@publicdomaincorp Thanks for the reply, yep I just figured out the premultiply_alpha setting too. I have it working in Unity fine now as well as UE4 v 4.22. No cracks now which is great.

I can't get this plugin detected in Unreal 4.22 - if you could please ZIP up your version of the plugin, it would be REALLY appreciated! Thanks!

Any news about UE 4.22 and Seurat?

I'll be sharing something in the next week or so.

I'll be sharing something in the next week or so.

Was about to tackle porting it to 4.22. But read this thread here. Would love if you could share your work!

As promised, details on updating and using Seurat.
https://octo.vmware.com/immersive-training-environments-virtual-reality-using-google-seurat-part-1/
https://octo.vmware.com/immersive-training-environments-virtual-reality-using-google-seurat-part-2/
Please let me know of any feedback

Ok, sorry for the delay... here are the details!
https://octo.vmware.com/immersive-training-environments-virtual-reality-using-google-seurat-part-1/
https://octo.vmware.com/immersive-training-environments-virtual-reality-using-google-seurat-part-2/

Ok, sorry for the delay... here are the details!
https://octo.vmware.com/immersive-training-environments-virtual-reality-using-google-seurat-part-1/
https://octo.vmware.com/immersive-training-environments-virtual-reality-using-google-seurat-part-2/

Amazing stuff!


fix promise model update make optional

fixes #138

@lilsweetcaligula I did this as a pre-requisite before merging your PR (after validating it works) but somehow I am not encountering the same 500 error when I run this code on local dev anymore

@lilsweetcaligula


Ability to View Running Games

We need to add a screen that shows all of the models at the same time in a grid playing in simulating the game as they play through every level

sign me in!
so a page where you can see in realtime models playing, even if you started on another tab? can you point on what would be the correct way to implement this with convex?


typescript client frontend generation

It would be nice if the generated clients (when typescript is enabled) have typed responses.  Currently, IDE's (such as VSCode) just recognize the response objects as any and any[].
If you take a generated client and package it with npm/tsc to compile it down, the response types are dropped since they are not referenced in the api.ts file.
I believe all that needs to be added to the various functions is : Promise<Types.GetFooResponses> like below.
export const getTypes: Api['getTypes'] = async (request: Types.GetTypesRequest) => {
  return await _getTypes(baseUrl, request)
}

to
export const getTypes: Api['getTypes'] = async (request: Types.GetTypesRequest): Promise<Types.GetTypesResponses> => {
  return await _getTypes(baseUrl, request)
}

Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests.


Unable to recover an existing Keeper app.

https://github.com/bithyve/bitcoin-keeper/assets/62699947/9533ecf6-6523-478d-b1d3-49d17490c4a5

All the entered seed words were correct still it was showing "Invalid seeds Entry" modal and if we click on "X" button it is giving a toast message "Failed to get app image".

Verified this issue on keeper app v 1.1.12(299)


ci: fix python release

The filename is wrong here:
  pull_request:
    paths:
      # When we change pyproject.toml, we want to ensure that the maturin builds still work
      - py-rattler/pyproject.toml
      # And when we change this workflow itself...
      - .github/workflows/python-release.yaml

If you fix that, hopefully the test will run


Session

Laravel Version: 5.4

Description: Hello I have a problem, adldap is working perfectly. I can login with my credentials but my session is not expiring until I logout. Is there anything I need to change or do and I also tried changing lifetime and expire_on_close in config/session.php but nothing worked out.

Hi @anukwgl, sessions are all managed via Laravel and not Adldap2.
You will need to troubleshoot this in your application unfortunately, as this is a Laravel issue.


Calling a class method on NOTIFICATION_PREDELETE will crash the editor

Godot version
v4.2.dev.custom_build [eca6f0eb5]
System information
Windows 10, Forward+, NVIDIA GeForce GTX 1050 Ti (<IP_ADDRESS>79)
Issue description
Calling a class method from _notification on NOTIFICATION_PREDELETE will crash the Godot editor.
It seems self is <Object#null> at that time.
Right before the Godot editor closes, it will say something about "attempting to call _on_predelete on a null instance" or something similar.
This makes sense, since self is null.
However, it seems like a bug that the object is a null instance on predelete, when you would want to clean up resources that the object was responsible for.
Steps to reproduce
Create a node that creates an object that will be deleted at the end of the function:
extends Node

func _ready():
    var test_ref_counted = TestRefCounted.new()

Create a RefCounted object which runs some code on predelete:

The following will correctly print "predelete"

class_name TestRefCounted
extends RefCounted

func _notification(what):
    if what == NOTIFICATION_PREDELETE:
        print("predelete")

The following will print <Object#null>

class_name TestRefCounted
extends RefCounted

func _notification(what):
    if what == NOTIFICATION_PREDELETE:
        print(self)

The following will crash the Godot editor, because you attempt to call a function on a null object.

class_name TestRefCounted
extends RefCounted

func _on_predelete():
    pass

func _notification(what):
    if what == NOTIFICATION_PREDELETE:
        _on_predelete()

Minimal reproduction project
This MRP has the code in point 3 in "Steps to reproduce", and will crash the Godot editor if ran.
MRP-predelete.zip

Related to #6784.

Interestingly, it seems like you can still access script member variables during NOTIFICATION_PREDELETE (someone could test this with ASAN enabled just in case):
class_name TestRefCounted
extends RefCounted

var member_variable = "you can print this one"

func _on_predelete():
	pass

func _notification(what):
	if what == NOTIFICATION_PREDELETE:
		print(member_variable) #Ok
		member_variable = "something else" #Ok
		print(member_variable) #Ok
		_on_predelete() # Error here

I ran into this issue today on 4.3dev4 as I was converting some custom Object classes that I had manually freed using free() to RefCounted to get automatic reference counting and freeing, and I wanted to see that the automatic freeing was happening as expected.
The interesting thing is that when the objects were just Object subclasses and I called free() they would receive the NOTIFICATION_PREDELETE notification as expected before being freed so I could do some additional cleanup. And I would expect RefCounted to just maintain a count of references and then call free() when this reaches zero, but perhaps it doesn't? When they are RefCounted subclasses they still get the NOTIFICATION_PREDELETE notification, but it seems that the objects have already been freed and are null when this happens.

Yep, having the same issue here. Hope this gets fixed soon!

ASAN is not happy!
Promise defer _emit <RefCounted#-9223371919783360678> true
Promise defer predelete <Object#null> false
=================================================================
==1431660==ERROR: AddressSanitizer: heap-use-after-free on address 0x614002e49ca0 at pc 0x55556a4295df bp 0x7fffffffc460 sp 0x7fffffffc450
WRITE of size 4 at 0x614002e49ca0 thread T0
    #0 0x55556a4295de in std::__atomic_base<unsigned int>::fetch_sub(unsigned int, std::memory_order) /usr/include/c++/11/bits/atomic_base.h:628
    #1 0x55556a4295de in SafeNumeric<unsigned int>::decrement() core/templates/safe_refcount.h:87
    #2 0x55556a4295de in SafeRefCount::unref() core/templates/safe_refcount.h:207
    #3 0x55556a4295de in _ObjectDebugLock::~_ObjectDebugLock() core/object/object.cpp:55
    #4 0x55556a3fef4d in Object::callp(StringName const&, Variant const**, int, Callable::CallError&) core/object/object.cpp:814
    #5 0x55556945a337 in Callable::callp(Variant const**, int, Variant&, Callable::CallError&) const core/variant/callable.cpp:69
    #6 0x55556a3e0bc6 in CallQueue::_call_function(Callable const&, Variant const*, int, bool) core/object/message_queue.cpp:220
    #7 0x55556a3e1bb7 in CallQueue::flush() core/object/message_queue.cpp:270
    #8 0x55555f9730a7 in SceneTree::physics_process(double) scene/main/scene_tree.cpp:492
    #9 0x55555707dd2e in Main::iteration() main/main.cpp:4063
    #10 0x555556ea96a9 in OS_LinuxBSD::run() platform/linuxbsd/os_linuxbsd.cpp:962
    #11 0x555556e8f776 in main platform/linuxbsd/godot_linuxbsd.cpp:85
    #12 0x7ffff7029d8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
    #13 0x7ffff7029e3f in __libc_start_main_impl ../csu/libc-start.c:392
    #14 0x555556e8f364 in _start (/home/jpate/build/src/godot/bin/godot.linuxbsd.editor.x86_64.san+0x193b364)

0x614002e49ca0 is located 96 bytes inside of 392-byte region [0x614002e49c40,0x614002e49dc8)
freed by thread T0 here:
    #0 0x7ffff74b4537 in __interceptor_free ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:127
    #1 0x555568a49e7c in Memory::free_static(void*, bool) core/os/memory.cpp:168
    #2 0x5555571bb4ee in void memdelete<RefCounted>(RefCounted*) core/os/memory.h:119
    #3 0x555569483445 in Variant::_clear_internal() core/variant/variant.cpp:1389
    #4 0x555558027ecc in Variant::clear() core/variant/variant.h:309
    #5 0x555558027ecc in Variant::~Variant() core/variant/variant.h:803
    #6 0x555558027ecc in GDScriptFunction::call(GDScriptInstance*, Variant const**, int, Callable::CallError&, GDScriptFunction::CallState*) modules/gdscript/gdscript_vm.cpp:3693
    #7 0x555557af8015 in GDScriptInstance::callp(StringName const&, Variant const**, int, Callable::CallError&) modules/gdscript/gdscript.cpp:2028
    #8 0x55556a3fe9a1 in Object::callp(StringName const&, Variant const**, int, Callable::CallError&) core/object/object.cpp:786
    #9 0x55556945a337 in Callable::callp(Variant const**, int, Variant&, Callable::CallError&) const core/variant/callable.cpp:69
    #10 0x55556a3e0bc6 in CallQueue::_call_function(Callable const&, Variant const*, int, bool) core/object/message_queue.cpp:220
    #11 0x55556a3e1bb7 in CallQueue::flush() core/object/message_queue.cpp:270
    #12 0x55555f9730a7 in SceneTree::physics_process(double) scene/main/scene_tree.cpp:492
    #13 0x55555707dd2e in Main::iteration() main/main.cpp:4063
    #14 0x555556ea96a9 in OS_LinuxBSD::run() platform/linuxbsd/os_linuxbsd.cpp:962
    #15 0x555556e8f776 in main platform/linuxbsd/godot_linuxbsd.cpp:85
    #16 0x7ffff7029d8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58

Interestingly, it seems like you can still access script member variables during NOTIFICATION_PREDELETE even if self is null, maybe they are still available in some local script scope etc.? Someone could test this with ASAN enabled just in case:

The script data may be hanging around but the pointer to that data has been deleted..
Likely it just happens to still be available because it never gets zeroed out when the object pointer is freed, but other pointers stil refer to that address. This only works if it's not reallocated during the window when it's freed and you are accessing it.
with ASAN enabled it immediately crashes :D

I got a similar issue in v4.3 .NET, specifically like this bug #82841.
NOTIFICATION_PREDELETE is never caught by MObject inheriting RefCounted when the node GameData is freed by using QueueFree().
public abstract partial class MObject : RefCounted
{
	protected MObject()
	{
		...
	}

	public override void _Notification(int what) // Never called
	{
		if(what == NotificationPredelete)
		{
			Predelete();
		}
	}
	public abstract void Predelete();
}

public partial class MPlayer: MObject
{
        public MPlayer() : base()
	{
		...
	}
	public override void Predelete()
	{
                ...
	}
}

public partial class GameData : Node
{
	public MPlayer Player = new();

}

@CorailleHorn This is intentional. When this notification is sent, the C# script has already been disposed, so we can't invoke its methods. Instead, consider using IDisposable for releasing resources when the object is being freed.
https://github.com/godotengine/godot/blob/893bbdfde8ad1f94fb4e6db246ff7075569396ea/modules/mono/csharp_script.cpp#L1903-L1911

@raulsntos thanks for your answer. I tried what you said : replacing the overriden _Notification method by an overriden Dispose method.
But unfortunately, this doesn't seem to work as I'm expecting. When using RefCounted, the dispose method only appears to be called immediately when closing the application. When the node GameData is manually freed, no dispose method is called directly. Though, I found that after waiting for some minute, a couple of MObject dispose method could be automatically called. Seems like a godot GC behaviour ?
protected override void Dispose(bool disposing)
{
	Predelete();
	base.Dispose(disposing);
}

I also tried to trigger the dispose method by removing a MObject from a collection (from there, there are no more references to it in my scripts), but it also does not work.  What I understood is that a RefCounted object is supposed to be automatically freed when there are no more references to it (like any c# object as far as I know).
The thing I'm trying to do is to implement signals in my MObject architecture using a godot native class lighter than Node. Following the docs, I want to free the custom signals connections in the proper "pre-deletion" method but the RefCounted behaviour seems not to work with this pattern.


[SPARK-26975][SQL] Support nested-column pruning over limit/sample/repartition

What changes were proposed in this pull request?
As SPARK-26958 benchmark shows, nested-column pruning has limitations. This PR aims to remove the limitations on limit/repartition/sample. Here, repartition means Repartition, not RepartitionByExpression.

How was this patch tested?
Pass the Jenkins with a newly added test suite.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8473/
Test PASSed.

Test build #103007 has started for PR 23964 at commit 8d3a2f7.

Test build #103007 has finished for PR 23964 at commit 8d3a2f7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103007/
Test PASSed.

Hi, @cloud-fan , @gatorsmile , @dbtsai , @viirya , @maropu , @kiszk .
Could you review this please?

I'll resolve the conflict very soon. It's because I merged @viirya 's #23955 a few minutes ago.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8528/
Test PASSed.

Test build #103066 has started for PR 23964 at commit 78bd63d.

Test build #103066 has finished for PR 23964 at commit 78bd63d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103066/
Test PASSed.

Hi, @cloud-fan and @gatorsmile .
Could you give some directional advice on this?

Thank you so much for review, @maropu . All comments are valid. I'll address your comments today.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8627/
Test PASSed.

Test build #103181 has started for PR 23964 at commit ec2c5ee.

Test build #103181 has finished for PR 23964 at commit ec2c5ee.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103181/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8637/
Test PASSed.

Test build #103192 has started for PR 23964 at commit ec2c5ee.

Test build #103192 has finished for PR 23964 at commit ec2c5ee.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103192/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8645/
Test PASSed.

Test build #103200 has started for PR 23964 at commit ec2c5ee.

Test build #103200 has finished for PR 23964 at commit ec2c5ee.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103200/
Test PASSed.

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8742/
Test PASSed.

Test build #103299 has started for PR 23964 at commit ec2c5ee.

This is waiting for #24049 . After #24049 is merged, this PR will be simplified again.

Test build #103299 has finished for PR 23964 at commit ec2c5ee.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103299/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8815/
Test PASSed.

Test build #103392 has started for PR 23964 at commit 045ed06.

Hi, @maropu , @viirya , @dbtsai . Could you review this PR please?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8876/
Test PASSed.

Test build #103460 has started for PR 23964 at commit 6b6719b.

Test build #103460 has finished for PR 23964 at commit 6b6719b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103460/
Test FAILed.

Thank you so much for review, @viirya .

Retest this please.

Test build #103511 has started for PR 23964 at commit 033d172.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8925/
Test PASSed.

Test build #103511 has finished for PR 23964 at commit 033d172.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103511/
Test PASSed.

Do you have any other concerns, @maropu and @viirya ?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8952/
Test PASSed.

Test build #103541 has started for PR 23964 at commit b035234.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8958/
Test PASSed.

Test build #103547 has started for PR 23964 at commit b743a52.

Hi, @cloud-fan , @gatorsmile , @rxin , @dbtsai , @maropu .
This PR will improve Parquet/Orc/OrcV2 as you see in the benchmark result.
I believe we had decent time on this PR to fix a potential corner cases and to polish.
If there is no other clear objections, I'd like to move forward and to start to work on this foundation. Could you review this please?

Test build #103541 has finished for PR 23964 at commit b035234.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103541/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8966/
Test PASSed.

Test build #103555 has started for PR 23964 at commit 0f29eb8.

Test build #103547 has finished for PR 23964 at commit b743a52.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103547/
Test PASSed.

Test build #103555 has finished for PR 23964 at commit 0f29eb8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103555/
Test PASSed.

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8994/
Test PASSed.

Test build #103586 has started for PR 23964 at commit 0f29eb8.

Test build #103586 has finished for PR 23964 at commit 0f29eb8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103586/
Test PASSed.

The current one looks good to me except for my minor comments. I leave it to the other reviewers. @cloud-fan @viirya

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9007/
Test PASSed.

Test build #103602 has started for PR 23964 at commit ec8c97b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9008/
Test PASSed.

Test build #103603 has started for PR 23964 at commit 3711312.

The PR is updated as @maropu 's suggestion.
@cloud-fan , @dbtsai , @viirya . How do you think about the current status?

Test build #103603 has finished for PR 23964 at commit 3711312.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #103602 has finished for PR 23964 at commit ec8c97b.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103603/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103602/
Test FAILed.

retest this please

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9023/
Test PASSed.

Test build #103622 has started for PR 23964 at commit 3711312.

Test build #103622 has finished for PR 23964 at commit 3711312.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103622/
Test PASSed.

Hi, @viirya , @maropu , @dbtsai , @cloud-fan .
For the question about the other data sources, I made the following PR for that. I think the reduced schema has no harm on all file-based data sources in this cases. Please review the following PR.

SPARK-27197 Add ReadNestedSchemaTest for file-based data sources

And, if there is another concerns or example, please let me know. We can narrow down more specifically for our purpose. Thank you in advance.

After https://github.com/apache/spark/pull/23964#issuecomment-473742988 , all comments are addressed.

The current one looks good to me except for my minor comments.

Since there is no further comments and this has been looking good for two days, I'll merged this.
Thank you all for helping this PR, @maropu , @viirya , @dbtsai , @dilipbiswal , @cloud-fan , @gatorsmile .
Merged to master.


fix(calendar): fix selection dynamic values

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.601%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
8145

Relevant Lines:
9251

💛  - Coveralls


Synchronization job workflow fails when matching existing service cloud records on email without a customer List

Describe the bug
When running the synchronization job with existing records in service account that match up to existing records in commerce cloud the work flow fails with the following error.
Error element ia_validateIntegrationConfiguration (FlowActionCall).
An Apex error occurred: System.NullPointerException: Attempt to de-reference a null object

Flow Details
Flow API Name: B2CCommerce_PlatformEvent_ProcessContactUpdate
Type: Autolaunched Flow
Version: 1
Status: Active

Flow Interview Details
Interview Label: B2C Commerce: Platform Event: Process Contact: 3/4/2022, 11:29 AM
Start time: 3/4/2022, 11:29 AM
Duration: 0 seconds

How the Interview Started
API Version for Running the Flow: 52
Some of this flow's variables were set when the interview started.
$Record = B2C_Commerce_ProcessCustomerDetails__e (No ID)

DECISION: Is ProcessMode Valid
Skipped this outcome because its conditions weren't met: decOutcome_ProcessModeIsInValid
Outcome conditions:
1. {!$Record.Process_Mode__c} (retrieve) Does not equal retrieve
2. {!$Record.Process_Mode__c} (retrieve) Does not equal publish
Logic: All conditions must be true (AND)

Default outcome executed.

GET RECORDS: Get the Contact Record
Find all Contact records where:
Id Equals {!$Record.CRM_Contact_ID__c}<PHONE_NUMBER>NPTq3AAH)
Store the values of these currently referenced fields in recGet_Contact: AccountId, Id
Because recGet_Contact is passed to an action, subflow, or Lightning component, store the values of all Contact fields that the running user has access to.
Result
Successfully found records.

DECISION: Was the Contact Found?
Outcome executed: decOut_ContactWasVerfiied
Outcome conditions:
{!$Record.CRM_Contact_ID__c}<PHONE_NUMBER>NPTq3AAH) Equals {!recGet_Contact.Id}<PHONE_NUMBER>NPTq3AAH)

DECISION: Does the Contact Have a Parent Account?
Skipped this outcome because its conditions weren't met: decOut_ContactDoesNotHaveParentAccount
Outcome conditions:
{!recGet_Contact.Account.Id}<PHONE_NUMBER>PlvbpAAB) Equals true

Default outcome executed.

GET RECORDS: Get the B2C CustomerList
Find all B2C_CustomerList__c records where:
Id Equals {!$Record.CRM_CustomerList_ID__c} (null)
Store the values of these currently referenced fields in recGet_B2CCustomerList: B2C_Client_ID_Value__c, Audit_OCAPI_API_Response__c, Base_API_Url__c, JWT_Certificate_Name__c, Id, B2C_Instance__c, B2C_Client_ID__c
Because recGet_B2CCustomerList is passed to an action, subflow, or Lightning component, store the values of all B2C_CustomerList__c fields that the running user has access to.
Result
Failed to find records.

GET RECORDS: Get the Related B2C Instance
Find all B2C_Instance__c records where:
Id Equals {!recGet_B2CCustomerList.B2C_Instance__c} (null)
Store the values of these currently referenced fields in recGet_B2CInstance: Id
Because recGet_B2CInstance is passed to an action, subflow, or Lightning component, store the values of all B2C_Instance__c fields that the running user has access to.
Result
Failed to find records.

B2CIAVALIDATECONTACT (APEX): Validate Integration Configuration
Inputs:
b2cInstance = {!recGet_B2CInstance} (null)
contact = {!recGet_Contact} (Contact<PHONE_NUMBER>NPTq3AAH))
customerList = {!recGet_B2CCustomerList} (null)
processMode = {!$Record.Process_Mode__c} (retrieve)

Error Occurred: An Apex error occurred: System.NullPointerException: Attempt to de-reference a null object

To Reproduce
Steps to reproduce the behavior:

Load accounts into Service Cloud
Create customers in Commerce cloud with the same email address
Run synchronization job provided by b2-crm-sync
Observe workflow error

Expected behavior
Account should be matched and updated with the current customer list, customer no and customer id in order for account to be properly synchronized. This job is needed when establishing connector with existing commerce cloud and service cloud instances

I'm able to replicate this without the job directly in the flow in service cloud

Create a new account (we're using person accounts) with a first name, last name, and email.
Execute the Debug Run: B2C Commerce: Process: Create Or Update Contact in QA mode
QA Mode should have the following values filled in

Customer list should be valid. First name, last name, email should match newly recreated record. Customer No and Customer ID need to be filled in to similar values that would be sent by the process contact job in SFCC

Hello @nek4life,
Thank you for posting this issue.
That's actually the expected behavior, as the person account you are creating initially has no customer list value, so crm-sync is not able to find a match as this value is a hardly-required value here.
Can you please try to put a value in the customer list field when inserting person accounts in Core, and then either run the flow or the job?
Thanks

Hello @nek4life ,
Thank you for this well-detailed context, it totally makes sense to me now. Apologize if I did not get it the first time.
I'll look into this and improve this piece of the crm-sync core matching logic to ensure this use case is covered.
Will let you know.

Thanks @jbachelet! Slightly related, it does seem a bit odd that a customer list ID is expected even with guest checkout as that customer may or may not actually be a registered customer and not be assigned to an actual customer list.
Since there isn't any support for syncing ad-hoc forms at this time we looked at how guest checkouts worked since they are a similar use case and were able to reuse the flow, however we still need to send a customer list in for this as well. Ideally the request wouldn't require a customer list because that customer for either ad-hoc form like an email signup or guest checkout really shouldn't be assigned to a customer list.
Perhaps this is a larger architectural issue related to how the api connection details are stored within the framework. For this issue I don't expect this to be resolved, but wanted to mention as others may be facing the same issue or questions about their implementation.

@jbachelet : We are also facing a similar issue. In our case, the client has SF OMS enabled and OMS creates a person account when a new order is created in the system and no existing person account exists yet in SF.
Now, if the same customer tries to create an account in SFCC at a later stage, we get the same error as in the issue description.


Implement recurring lessons

Fixes #10.
Recurring lessons will display the date of the lesson in the current week.
Minor changes to the JsonAdaptedLesson class to include isRecurring boolean.

Commit #7a7f794 fixes #85.

Codecov Report

Merging #82 (aa3d696) into master (bae96c7) will decrease coverage by 1.78%.
The diff coverage is 6.81%.

@@             Coverage Diff              @@
##             master      #82      +/-   ##
============================================
- Coverage     55.70%   53.91%   -1.79%
- Complexity      508      510       +2
============================================
  Files           107      108       +1
  Lines          2129     2207      +78
  Branches        221      235      +14
============================================
+ Hits           1186     1190       +4
- Misses          868      940      +72
- Partials         75       77       +2

Impacted Files
Coverage Δ

...seedu/address/logic/commands/AddLessonCommand.java
41.66% <ø> (ø)

...va/seedu/address/logic/commands/AssignCommand.java
0.00% <0.00%> (ø)

...u/address/logic/parser/AddLessonCommandParser.java
51.61% <0.00%> (+1.61%)
:arrow_up:

...eedu/address/logic/parser/AssignCommandParser.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/AddressBook.java
78.57% <0.00%> (-6.05%)
:arrow_down:

.../java/seedu/address/model/lesson/DateTimeSlot.java
55.84% <0.00%> (-2.27%)
:arrow_down:

...c/main/java/seedu/address/model/lesson/Lesson.java
47.82% <0.00%> (-11.64%)
:arrow_down:

...va/seedu/address/model/lesson/RecurringLesson.java
0.00% <0.00%> (ø)

...main/java/seedu/address/model/student/Student.java
89.65% <0.00%> (-3.21%)
:arrow_down:

...seedu/address/model/student/UniqueStudentList.java
76.00% <0.00%> (-10.37%)
:arrow_down:

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b22c68...aa3d696. Read the comment docs.


Not compatble with zabbix 5.2 user object dont have type

in zabbix 5.2 the user obj have changed and type have been removed.

    if self.conn.api_version() >= "5.2":
        user_defaults['roleid'] = 1
    else:
        user_defaults['type'] = 1

this seems not to be working as it should

Found that i missed comment out a line in config.

Thanks for the issue, i improved the documentation.
https://github.com/zabbix-tooling/zabbix-ldap-sync/commit/8de50bd23de7e63821c0484c86abe669e522e442


Support of the training-independent inference script with pre-trained model

Hello
How are you?
Thanks for contributing this project.
I think that the inference with pre-trained model is dependent on training dataset.
Could u provide an independent script for test inference?
Thanks.

Hi @rose-jinyang! Thank you for your interest in our work!
Please see the configurations here to switch to either evaluation (compute mIoU against your ground truth) or test (no ground truth available, just output the prediction files).


Istio with Ambient Mode not work / how to install CNI

Hi, trying to install Istio in Ambient Mode but istio-cni-node won't start as it can't find CNI, what are my installation options?
https://istio.io/latest/docs/ambient/getting-started/
brew install istioctl
istioctl install --set profile=ambient --skip-confirmation

Added to the docs.


Convert to .NET Core / Dotnet Tool / GitHub Actions

Closes #17
Closes #18

@madkat FYI I think I've got it mostly done here.
This tool relies quite a bit on the NewLine character to output the graph, I think for now I am just going to allow it to default to whatever the system's NewLine is, mostly because these are plain-text files which means Git will mangle/"normalize" them when they're committed. Also its super hard to change StringBuilder.AppendLine's newline character so there is that...
Means a bunch of unit tests changed, as you can see I've got GitHub Actions running on this which shows this working on Windows/Ubuntu/macOS


TAJO-1360: VALUES_ field in OPTIONS table of catalog store should be longer.

I suggest OPTIONS size as 4000, because max size of  oracle varchar2 is just 4000
I researched docs for these patch.
maria: https://mariadb.com/kb/en/mariadb/varchar/
mysql: http://dev.mysql.com/doc/refman/5.7/en/char.html
postgres: http://www.postgresql.org/docs/8.3/static/datatype-character.html
derby: https://db.apache.org/derby/docs/10.7/ref/rrefsqlj41207.html
oracle: https://docs.oracle.com/cd/B28359_01/server.111/b28320/limits001.htm#i287903
(here varchar2 limit is just 4000)

+1
Even though I suggested 8000 chars, 4000 chars also look enough. When we face the same problem due to limited length, we need to investigate new solution.
If there are no objection until tomorrow, I'll commit it.

+1

Since I did move sql statements to xml files for Oracle and PostgreSQL DBMS, but these deprecated sql files for Oracle and PostgreSQL are still remained. Sorry for that. Can you apply these changes to /tajo-catalog/tajo-catalog-server/src/main/resources/schemas/oracle/oracle.xml and /tajo-catalog/tajo-catalog-server/src/main/resources/schemas/postgresql/postgresql.xml? I will create another issue to delete these deprecated sql files. Without this issue, I don't have any concerns on this patch.

Thank you @ykrips for your comment. I missed them.

Hi @charsyam,
Any progress? If you are busy now, I can finish this issue.

@hyunsik I will patch it soon ASAP.
actually, I forgot it, Thank you for reminding. :)

There is something wrong. so I will send it again.

@hyunsik @dongjoon-hyun @ykrips
Please see https://github.com/apache/tajo/pull/436
I'm sorry to make you confused


fix: safari scrolling on window now works properly

Also reduces bundlesize

:tada: This PR is included in version 1.1.10 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Compile error with browserify

Hi,
Not sure if this is an issue just effecting me or a more general issue.
I am getting a browserfiy issue after adding this to my project:

Hey @jbardnz!
Someone on reddit already noticed the problem and it is fixed in the latest commit.
I will bump the version in a moment. :)

Thanks so much for the super quick reply :)

No problem.
Fixed in v0.1.6

Hmm, I now seem to get a different compile error:

Ouch. This might be something sass related. I’m about to get rid of it in the multiselect.vue file. This might solve the problem. On it right now!
Thanks for reporting!
Can you also provide some of the configuration you’re using? Any preprocessors?

I'm using Laravel Elixir to compile my JS assets.
I am also running Sass for all my styling and in my own Vue components so it should have all the dependencies it needs to compile. Apart from that it is just a standard gulp setup.

@jbardnz
Got rid of sass anyway (thus probably removing the line that throw the error). Give it a try now. :)

Thanks man!
That has cleared the Sass issue - but it has caused a different issue:

Damn! Could you try reinstalling/updating babel-preset-stage-2? And/or removing node_modules and running npm install again?
pointerMixin.js doesn’t really use any Babel requiring functionality.
This might be a problem with laravel-elixir.
https://github.com/laravel/elixir/issues/354
I will investigate it later, but probably not today.

Hmm potentially it is just a Laravel Elixir issue then. I will investigate the solutions suggested on that thread tomorrow and post back.

Thanks!

I had the same trouble, and (mind you I'm in no way knowledgable in all of this, so I don't know what can be done to fix it really), but following the thread in the above mentioned elixir issue, I removed the .babelrc file at the root of vue-multiselect folder in node_modules and it works perfectly fine now!

That’s interesting! Thanks @jpmurray. I will check it myself and add it to .npmignore if it doesn’t break anything for webpack based imports.

@jpmurray @jbardnz .babelrc file removed. This should fix the problem. If not, please reopen and let me know! :) Have a nice weekend!

@shentao I have just tested and can confirm that fixes the issue for me! Thanks so much for fixing this.

Awww yeah! 👯 Glad to hear that!


In-memory Engine: implement range load

What is changed and how it works?

Issue Number: Ref #16141

What's Changed:
implement range load

This PR implements range load.
A range will experience three phases before providing read services:

pending range
pending range with snapshot
range with snapshot loaded

When deciding to load a range, say r1, r1 becomes pending range.
In apply thread at some time, r1, coupled with the rocksdb snapshot, becomes pending range with snapshot, and a load task will be scheduled to a specific worker which will load data from the snapshot into the in-memory engine.  At the same time, any write for this range will be cached.
When the snapshot load finished, r1 becomes range with snapshot loaded and at some time in the apply thread, it will consume the cached writes. Then, r1 becomes a normal range in the in-memory engine and load completes.
Related changes

[ ] PR to update pingcap/docs/pingcap/docs-cn:
[ ] Need to cherry-pick to the release branch

Check List
Tests

[x] Unit test
[x] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Release note

None

/merge


License Question

Thanks for sharing this code and blog post. Just curious any plans on putting a license on this code?

Happy you found this useful, @jwyglendowski-precisionlender 🙌
I've just addressed this here and you should be able to use this code under the MIT license: https://github.com/brunojppb/node-distributed-lock/commit/2bc997e1c3356f5c6a6c943a3d2c5bb984484490


Windows

Is there even a chance for it to work on Windows?
Currently, tesserocr wheels doesn't compile on Windows and installed binary is not found.
Also, OPENAI_API_KEY cannot be found no matter what I do. I guess I need to try to restart the system as a last resort.  Yes, restarting actually helped somehow.
> memento-bg
pygame 2.5.0 (SDL 2.28.0, Python 3.10.12)
Hello from the pygame community. https://www.pygame.org/contribute.html
Traceback (most recent call last):
  File "C:\Users\dzidm\miniconda3\Scripts\memento-bg-script.py", line 33, in <module>
    sys.exit(load_entry_point('memento', 'console_scripts', 'memento-bg')())
  File "c:\users\dzidm\downloads\memento\memento\__init__.py", line 6, in bg
    backgound = Background()
  File "c:\users\dzidm\downloads\memento\memento\background.py", line 75, in __init__
    self.workers[i].start()
  File "C:\Users\dzidm\miniconda3\lib\multiprocessing\process.py", line 121, in start
    self._popen = self._Popen(self)
  File "C:\Users\dzidm\miniconda3\lib\multiprocessing\context.py", line 224, in _Popen
    return _default_context.get_context().Process._Popen(process_obj)
  File "C:\Users\dzidm\miniconda3\lib\multiprocessing\context.py", line 336, in _Popen
    return Popen(process_obj)
  File "C:\Users\dzidm\miniconda3\lib\multiprocessing\popen_spawn_win32.py", line 93, in __init__
    reduction.dump(process_obj, to_child)
  File "C:\Users\dzidm\miniconda3\lib\multiprocessing\reduction.py", line 60, in dump
    ForkingPickler(file, protocol).dump(obj)
TypeError: cannot pickle 'sqlite3.Connection' object
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "C:\Users\dzidm\miniconda3\lib\multiprocessing\spawn.py", line 116, in spawn_main
    exitcode = _main(fd, parent_sentinel)
  File "C:\Users\dzidm\miniconda3\lib\multiprocessing\spawn.py", line 126, in _main
    self = reduction.pickle.load(from_parent)
EOFError: Ran out of input

For now I am give up on this...

Hi,
This looks a lot like #46 but it was on MacOS.
I will investigate when I have time, It is easier for me to test things on Windows than MacOS, maybe I will find a solution for both :)
Thanks !

Hi
Which version of Python are you using

Python 3.10.12

any update regarding windows support? have the same problem with missing python lib when using the exe files.
I also tried using WSL2 for it however "display" doesnt get detected when I Try with an x server it says xrandr not deteted.
would L O V E to see this tool on windows, rewind for windows seems to take like months to complete and isnt osource

Hi, I will try to put some work on it in the following days. I don't have a lot of free time these days but it should get better soon :)

Indeed, the main issue seems to be that tesserocr wheel does not work on windows anymore from pip. I stumbled upon this thread https://github.com/sirfz/tesserocr/issues/287 . It seems to be possible to install it from conda-forge . I will try this.
As a last resort, it may be necessary to build tesserocr manually (https://github.com/sirfz/tesserocr/blob/master/Windows.build.md) which seems to be painful.
I'll keep you updated

https://pypi.org/project/tesserocr/
The instructions under the Windows/pip section seems to have worked on my system

Now I have issues with chroma. Will continue to investigate later

just curious about any update? :)

just curious about any update? :)

same here :)

Hi all, sorry I don't have much free time to work on Memento these days ... I will update you here when I can give it some time !

Any news of making it work on Windows 11? Appreciate

Also not working in WSL. THis project seems to get abandoned. Sad, it looked promising.

Hi @venturaEffect, I would not say the project is abandoned, I just don't have a lot of free time to work on side projects these days :) I have a few ideas to improve it, and I definitely should spend some time making it work on windows and macos.
I will try to spend a few days on it soon, thank you for your interest anyway !


[rbmaradio] 256k not available

Redbull radio recently retired 256k CBR MP3 as streaming format in favour of 192k CBR. 96k CBR seems to be retiered without replacement.

not fixed. Still chooses 256k as format in 2018.05.30
youtube-dl https://www.redbullradio.com/shows/on-the-floor/episodes/shakey-ohm -g -v [debug] System config: [] [debug] User config: [] [debug] Custom config: [] [debug] Command-line args: ['https://www.redbullradio.com/shows/on-the-floor/episodes/shakey-ohm', '-g', '-v'] [debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252 [debug] youtube-dl version 2018.05.30 [debug] Python version 3.4.4 (CPython) - Windows-10-10.0.17677 [debug] exe versions: ffmpeg 4.0, ffprobe 4.0, rtmpdump 2.3 [debug] Proxy map: {} [debug] Default format spec: bestvideo+bestaudio/best https://audio.rbmaradio.com/OF_21379_Shakey_at_OHM_OT_53M.mp3?cbr=256


Clarify "executable" property in gradle.properties

Let's improve the importance of theexecutable=false or executable=true setting in gradle.properties, so people can see it directly in README.md

Thanks for your review, @mmoayyed .
Let me rephrase things and try again whenever I have some time to waste on this.