19629 Update legal type when adopting a business' name

Issue #: bcgov/entity#19629
Description of changes:

app version = 5.8.6
if adopting a business' name, also adopt its legal type

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

/gcbrun

Temporary Url for review: https://business-create-dev--pr-645-we2he6fl.web.app

/gcbrun

Temporary Url for review: https://business-create-dev--pr-645-we2he6fl.web.app

/gcbrun

Temporary Url for review: https://business-create-dev--pr-645-we2he6fl.web.app


Spatial features in prediction model.

The canonical dataset does not incorporate spatial information, which is an important source of information for predictions.  Other research with a similar target have used methods like [spatial autoregression] (SAR) (http://www.montana.edu/ce/instructors_professors/faculty/TRB13PedCrashesCAR.pdf) and panel-based methods.
We'd like to incorporate spatial information either as features or as part of the model structure.

To some extent this has been attempted with the Bayesian and improved Benchmark model.  There's definitely more work to be done, but definitely check those out first if you're thinking of working on this.

Reopening this: We don't currently have spatial features included in the model.  I'd like to reintroduce the adjacency matrix to the model and do some testing for the impact there.
Tasks:

Reintroduce segment adjacency matrix (see notebooks) and test performance
If full matrix doesn't seem to help much, maybe it makes sense to just include, features of adjoining segment.  (e.g. speed limit of adjoining segment)
With these new features, test how changing aspects of one or another joining feature changes risk scores on a target segment

Will be incorporating into issue around segment embeddings.


User logged out on click of signup /Login

Hi Roja,
I'm trying re-produce the issue, but not able to do it.
Can you please provide steps to re-produce it?
Thanks,
Sai Rohith Achanta.

Login to the website and then click on Signup or login. The user gets to signup and log-in again.

Thanks for providing the steps to re-produce. After going through your steps, it seems that you are using the older version of the application. The newer version does not have login and signup once the user login's to the application.
Can you please pull the latest from "Project-1" branch and check if the issue still persists?


default state on reboot or power loss state control?

Not sure this is the right place to ask. I have a bulb I am looking at that is on becomes unavailable and when I see it returning its off when its supposed to be on for night illumination. I am just trying to make sense of the behavior...it doesn't look like wifi should be a problem. A quick google search didnt turn anything up on libretiny and default power on states.

This is an ESPHome feature, refer to the ESPHome docs for help.


Husky hook

Traits

Command line program.
Implements husky hook interface.
Fails commit on validation failure.
Outputs all failed validations.

Husky hook implemented.


The token name is not sent to the Bot

The name of the token selected by the master is only sent to the bot if the token configuration is "Hovered by Anyone" or "Always for Everyone", otherwise the name is unknown and comes with a code. If this is standard behavior, an option to always send names would be interesting.

Foundry Virtual Tabletop: Version 11 Stable, 11.315
Game System: dnd5e, 2.4.1

Yes, this is intended behavior. The thought of adding a toggle for it did cross my mind. I can add it on the next release.

Toggle added in 1.8.4.


Analysis issues - "what should be done" sample codes.

Hi.
I appreciate the online documentation fetched from Visual Studio for my C++ developments.
For example, when clicking on an error given by the compiler or the static analysis (Clang), we get a page like this one:
C26485 NO_ARRAY_TO_POINTER_DECAY
A sample code is given for "what we shouldn't do". But I regret one thing: There is no sample code for "what should be done", how to correct the issue. I previously worked with tools whose documentation was done this way.
I imagine it's a large piece of work but it would give a great added value to your products.
Kind regards.
Sylvestre.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a414c668-e7c2-0e5d-f58f-9ab68abf76e9
Version Independent ID: 25fa5dbb-7c65-57f3-eaa4-a422c79cb4f1
Content: C26485
Content Source: docs/code-quality/c26485.md
Product: visual-cpp
Technology: cpp-tools
GitHub Login: @corob-msft
Microsoft Alias: corob

@Slyware
I understand and support your notion that warning docs should incorporate instructions on how to fix the issue. We try to do that now. Sometimes it's easy to say what to do to fix an issue. In other cases, it's tantamount to saying "you need to rearchitect your code away from this problem-prone paradigm." There may not be one simple transformative answer, so you get handwaving instead. That's the case in this article. Any number of solutions could work better, but we don't show use of one over another because we don't know which one will work best, or even well, in your situation. In some other old articles, we just plain didn't include a "how to fix it" example. We'll try to address those when we come across them, or when someone complains. Thanks for the validation.


Parent checking

I want to add some custom properties to a body I created with Bodies.rectangle. However when I add it to the world, I get the warning of: Composite.add: skipped adding a compound body part (you must add its parent instead) from here
Would it be better to compare the parent by some other means, maybe the id rather than the reference?
This is my code:
class Rectangle {
  constructor() {
    this.debugger = new Debugger();

    const matterBody = Bodies.rectangle(...arguments);
    Object.assign(this, matterBody);
  }

  update() {
    this.debugger.update(this.vertices);
  }
}

but what exactly is the problem here? and why you get composite parent error?
Also did you try this?

You can fix this by setting this.parent = this after you use Object.assign. Though, that said I would not recommend extending bodies in this way. As @Qriva mentioned the recommended way is to use the plugin approach.
So rather than wrapping the body object with another, all you should do is:
matterBody.plugin.debugger = new Debugger()
For reference, the body.plugin object is specifically for adding custom properties!


Update version to 1.2.0

Description
minor version bump with guest sessions api, and new UDF features.

Automation worked on the minor bump version, we don't need this backup PR.


Startup script error...

i followed the exact commands, but i get this error
systemctl status broadlink-mqtt.service

broadlink-mqtt.service - Broadlink MQTT Service
Loaded: loaded (/lib/systemd/system/broadlink-mqtt.service; disabled; vendor preset: enabled)
Active: failed (Result: exit-code) since Wed 2022-11-16 16:14:14 EET; 2s ago
Process: 159885 ExecStart=/usr/bin/python3 /root/broadlink-mqtt/mqtt.py (code=exited, status=208/STDIN)
Main PID: 159885 (code=exited, status=208/STDIN)
CPU: 1ms

Nov 16 16:14:14 AD110-NOC systemd[1]: Started Broadlink MQTT Service.
Nov 16 16:14:14 AD110-NOC systemd[159885]: broadlink-mqtt.service: Failed to set up standard input: Operation not permitted
Nov 16 16:14:14 AD110-NOC systemd[159885]: broadlink-mqtt.service: Failed at step STDIN spawning /usr/bin/python3: Operation not permitted
Nov 16 16:14:14 AD110-NOC systemd[1]: broadlink-mqtt.service: Main process exited, code=exited, status=208/STDIN
Nov 16 16:14:14 AD110-NOC systemd[1]: broadlink-mqtt.service: Failed with result 'exit-code'.
Nov 16 16:14:14 AD110-NOC systemd[1]: broadlink-mqtt.service: Consumed 1ms CPU time.

do you have python3 installed?

i finally did it the old fashioned way, in crontab...
@reboot /usr/bin/python3 /root/broadlink-mqtt/mqtt.py


added task queue base

Added base logic for the task queue.
Can we somehow use the SensorData scheme from the .proto file in the CloudService? Right now I just assume the scheme is always correct and access the fields without any null checks or similair.

@LeanderAK

Can we somehow use the SensorData scheme from the .proto file in the CloudService? Right now I just assume the scheme is always correct and access the fields without any null checks or similar.

Yes, since we generate mypy .pyi files (python stubs), you can use type annotations as usual in your endpoint, e.g. fog_pb2.ProcessDataRequest.  You can also instantiate these classes as usual when building a request (e.g. the feedback for the edge server).
Null checks are a bit strange since they've removed the required field, and all fields are optional by default. However, optional means the actual request structure is there, e.g. you can always access request.data.value, but it will be filled in with default values. So to check if the entire request is empty, you can check whether request.ListFields()  is None.
I pushed an example commit with the type annotation and empty request check: https://github.com/LeanderAK/SS24_FOGC_Project/pull/7/commits/473d0f162adcfcf376dc6fc2e4f8e0e807385a5f. Of course feel free to remove this when done with the PR.

Thanks for the detailed explanation. Ive added the connection to the edge Server.


Translation key not found - Mapbox integration

Something really ugly happens in the browser console when moving the mouse over the mapbox maps.  An error message is repeated over and over again, presumable on some hover/mousein/mouseout event... Error: No translation key found.

Is this still an issue?

No actually I fixed this issue as part of the afro report prep.


[AKS] az aks create/az aks nodepool add: No longer supports creating nodepools with ossku CBLMariner

Related command

az aks create
az aks nodepool add

Description

[AKS] az aks create/az aks nodepool add: No longer supports creating nodepools with ossku CBLMariner
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

AKS


Duplicate data ingestion in Kinesis indexing service

Affected Version
0.14.0-rc1
Description
I created two dataSources for the same Kinesis stream, but it returned different results for the same query. Duplicate raw events was found in one dataSource (it was about 110 events). I'm suspecting this line. Maybe isExclusive should be set to true. But, I'm not sure why it happened for only one dataSource.

It's possible the other datasource had duplicates at a different point. I think we were just looking at one second's worth of data when debugging this.

Hmm, yeah maybe. Looks that sometimes flow0 produces more rows than flow0-b too.


cut release

Codecov Report

Merging #238 (ce93f96) into main (3bae47e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #238   +/-   ##
=======================================
  Coverage   82.82%   82.82%
=======================================
  Files          29       29
  Lines        3674     3674
=======================================
  Hits         3043     3043
  Misses        631      631

Impacted Files
Coverage Δ

preliz/__init__.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Multiple statuses with the same context value

I have a scenario where the API returns multiple statuses with the same context value, one has state: pending and another have state: success. In this instance, I never receive a success state and always getting pending from outputs.failedCheckStates

Sorry for the delay in responding to your issue. I am unable to work on this at the moment, have you had any luck in figuring out the issue? I would welcome any collaboration to address the underlying issue you are experiencing.


Will there be a Forge and the Easier Version for Transit Railway 1.16/1.17/1.18?

Hello developers,
I want to suggest adding the forge version of Transit Railway. I usually play on Forge, not Fabric. Also, I would like you to add an easier version of Transit Railway, Transit Railway Lite. It is easier than the standard version, but the easier version also needs the Fabric and Forge versions. Transit Railway Lite also is for versions 1.16, 1.17, and 1.18.
Would you please make those versions.? I am not trying to be mean; I want to add it as a feature.

People want the forge version, and the Transit Railway  #took 4 years to make. Please make the Lite and Forge versions!

Why don't you make it. And what the heck is a Lite version? Minecraft Transit Railway is already very easy.

Why don't you make it? And what the heck is a Lite version? Minecraft Transit Railway is already very easy and probably one of the easiest train mods available for Minecraft. Stop making generalised statements like "People want the forge version". Who are these people? The developer chose Fabric. Development currently has taken and still takes a considerable amount of time to develop in his spare time. He clearly states on the curseforge page that he will not be making a Forge version. The sourcecode is freely available for anyone else to do it themselves.

Maybe it's a great idea to make a Lite Version! The Lite version includes easier ways to use MTR mod, simple mechanics, very easy train modification.


This page doesn't explain how to pass username and password for postgress despite the fields existing

The fields are some sort of parameter which isn't documented how to specify a parameter with value and there doesn't seem to be any examples of this.
Further, because you can't set this, pgadmin has a magical password that it prompts for but you don't know what it is, so you're stuck with a useless pgadmin as currently documented.

Hi @JHTaxa - what page are you referring to here?

https://learn.microsoft.com/en-us/dotnet/aspire/database/postgresql-component?tabs=dotnet-cli
(sorry thought it automatically did it when providing feedback from the page)
Basically if you use data persistence, then you must set username and password because the random password that is the default won't work.
There's @davidfowl notes on this in several other places.
His solution is to set it in app secrets, but I'd rather configure it directly and explicitly and even if this isn't possible, his comments should be transfered into direct instructions with notes about data persistence on this page.


Is it possible to remove/hide the black line divider/separator after each field?

I would like to control padding and display my own separators in the Column under FormBuilder.

FormBuilder's main purpose is to just provide form  stuff. The rest of how you express your UI wouldn't be restricted by the library, so feel  free to compose your UI the way you want.
The way we have set up the example project with a Column and no padding isn't the only  way.

OK, but I don't see how

I just figured out that this black line came from the InputDecorator, so I can remove it or customize it with the decoration field.

@Alkabann You know you could just disable input border application-wide from your theme, right?


Output path is shared between modules on multimodule project with .sbt file for a module

Hi, I have a multimodule project, one of the modules is a play module. I know the correct way to have multi-module projects is to have only 1 .sbt file for the root module but the play project is not happy with that and requires it's own .sbt file.
So currently my project has:
root-
| build.sbt (A)
| --- core (module)
| --- helloworld (play module)
(A) looks like:
import play.Project._
name := "project"
version := "1.0"
// ----------------------------------------------------------------------
// child projects
// ----------------------------------------------------------------------
lazy val core = project.settings(
libraryDependencies ++= {
...
}
)
lazy val helloworld = project.settings(
libraryDependencies ++= Seq(
...
)
).dependsOn(core)
But also helloworld has an sbt file which is copied below:
name := "helloworld"
version := "1.0"
play.Project.playScalaSettings
But I end up getting the following error when I "gen-idea" and do a clean build from within intellij:
scala: Output path /home/ariskk/idea-workspace/project/project/target/idea-test-classes is shared between: Module 'helloworld-build' tests, Module 'project-build' tests
Output path /home/ariskk/idea-workspace/project/project/target/idea-classes is shared between: Module 'helloworld-build' production, Module 'project-build' production
Please configure separate output paths to proceed with the compilation.
TIP: you can use Project Artifacts to combine compiled classes if needed.
Is there a work around for this? Please note that without the helloworld/build.sbt, the play module is not working.
Also all modules build/run ok within sbt.
Thanks

Don't know if relevant but the problem reproduces when one changes modules definition.
i.e. you change module id, then IntelliJ says that output path of new-named module is shared between old-named module.
Easy fix is to delete all target and .idea directories but it is more like forcing tool rebuild its project knowledge.


Doubly Ended Queue (Dequeue) Implementation

imsushant12 commented 14 minutes ago
Hello, @rudrakshi99 @nakul-19 @plazzy99 , I am a GSSOC'21 participant.
I wish to contribute "Implementation of Doubly Ended Queue" using Array with proper comments and clear explanation-
Please assign me this issue ,my code will be in C++ with proper comments and test cases.

@rudrakshi99 @plazzy99
I'm a GSSOC'21 paticipant/CA.
I've already started PRs pertaining to few other issues...
I wish to contribute to this issue (in CPP) with ample comments, clean indentation, & standard outputs to test cases.

I am a GSSOC '21 participant.
I wish to contribute a JAVA code for this issue:
My code will have comment lines to make it explanatory and understandable to everyone.
I will be very happy if I am assigned this issue and allowed to work on this

Hello
I am a GSSOC'21 participant
I would like to contribute in this issue
I can implement this in java with proper comment for better understanding.
I will also add 2-3 testcases for better understanding


AttributeError: module 'six' has no attribute 'text_type'

Hello, I am getting the above error, can someone please direct me on how to solve it!

Oh okay: I was doing it manually, placing the module directly into python3.7 folder, and, I put it inside a folder instead of placing the .py directly.
Solved!


27 aply corrections on version 200

Complete refactoring of the 2.0.0 version

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

412 of 426 (96.71%)  changed or added relevant lines in 17 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-2.04%) to 97.959%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

repository/IngSoft2-Model/Distribution.class.st
21
25
84.0%

repository/IngSoft2-Model/HyperJumpEffect.class.st
53
57
92.98%

repository/IngSoft2-Model/ManifestIngSoft2Model.class.st
0
6
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-2.04%

Covered Lines:
672

Relevant Lines:
686

💛  - Coveralls


Add eBPF connection tracking, without dependencies on kernel headers

Based on work from Lorenzo, updated by Iago, Alban, and Alessandro
This PR adds connection tracking using eBPF. This feature is not enabled by default.
For now, you can enable it by launching scope with the following command:
sudo ./scope launch --probe.ebpf.connections=true

Scope Probe also falls back on the old /proc parsing if eBPF is not working
(e.g. too old kernel, or pre-compiled eBPF program missing for the current kernel).
This patch allows scope to get notified of every connection event, without relying
on the parsing of /proc/$pid/net/tcp{,6} and /proc/$pid/fd/*, and therefore
improve performance.
We vendor https://github.com/kinvolk/gobpf-elf-loader in Scope to load and
receive information from the ebpf programs. The Scope build fetches the pre-compiled
ebpf programs from https://hub.docker.com/r/kinvolk/tcptracer-bpf/
(see https://github.com/kinvolk/tcptracer-bpf)
At the moment, the eBPF programs are pre-compiled for:

Arch 4.8.11-1
fedora-24
debian-testing
coreos

The ebpf programs use kprobes on the following kernel functions:

tcp_v4_connect
tcp_v6_connect
inet_csk_accept
tcp_close

It generates "connect", "accept" and "close" events containing the
connection tuple but also pid and netns.
Note: the IPv6 events are not plugged in Scope.
probe/endpoint/ebpf.go maintains the list of connections. Similarly to
conntrack, it also keeps the dead connections for one iteration in order
to report short-lived connections.
The code for parsing /proc/$pid/net/tcp{,6} and /proc/$pid/fd/* is still
there and still used at start-up because eBPF only brings us the events
and not the initial state. However, the /proc parsing for the initial
state is now done in foreground instead of background, via newForegroundReader().
NAT resolution on connections from eBPF works in the same way as it did on connections
from /proc: by using conntrack. One of the two conntrack instances was removed since
eBPF detects short-lived connections.
The Scope Docker image size comparison:

weaveworks/scope in current master:  22 MB (compressed),  68 MB
(uncompressed)
weaveworks/scope with this patchset: 24 MB (compressed), 70 MB
(uncompressed)

Fixes #1168 (walking /proc to obtain connections is very expensive)
Fixes #1260 (Short-lived connections not tracked for containers in
shared networking namespaces)
Fixes #1962 (Port ebpf tracker to Go)
Fixes #1961 (Remove runtime kernel header dependency from ebpf tracker)
Supersedes #2024

Scope fetches the pre-compiled ebpf program from https://hub.docker.com/r/kinvolk/tcptracer-bpf/
(see https://github.com/kinvolk/tcptracer-bpf)

Perhaps include all the binaries in the scope container image? Yes, it adds bloat, but dynamically downloading binaries (on every launch?) is gross.

Perhaps include all the binaries in the scope container image? Yes, it adds bloat, but dynamically downloading binaries (on every launch?) is gross.

@rade It is already in the Scope Docker image. It is done at build-time (implemented in Scope's Makefile).
At the moment, the size of the compiled ebpf programs is very small, I think <50KB uncompressed.
https://hub.docker.com/r/kinvolk/tcptracer-bpf/tags/

Ah, so when you wrote "Scope fetches" you didn't actually mean "Scope" but "The scope build". Also you wrote "Scope fetches the pre-compiled ebpf program" (note the singular). Taking into account your comments, I believe that sentence should have read "The scope build fetches the pre-compiled ebpf programs." Correct?

@rade correct. Sorry for the impreceise wording. I or @iaguis will edit the PR text.

I closed the two previous iterations of this work, in favor of this PR. For the record, this was:

iteration 1: #1967 (ebpf using bcc/python)
iteration 2: #2024 (ebpf using bcc/gobpf)

Two graphs comparing the performance between master and this branch (by running our test dialer, #2082):
With up to 4K connections (40 dialer container with 100 connections each):

With a pool of 100 containers, each holding a random number of connections between 1 and 20:

Superseded by https://github.com/weaveworks/scope/pull/2135


Send_message blocks forever waiting for response

While sending a message to the WebSocket if OBS or the WebSocket suddenly crashes it will wait forever for a response.

https://github.com/dnaka91/obws/blob/b25ea51a15d826a1a50f004e09c071c57c9fd9be/src/client/mod.rs#L293-L295

Thank you for reporting this. Sorry, you find so many rough edges in regards to crashing OBS. For me it almost never crashes so I simply don't get into this situations.
I see we problem here. We put the oneshot Sender in a map but never clear the map when we get out of the event loop. Therefore, the sender isn't dropped and we wait forever.
I'll prepare a fix tomorrow.
After that I'll look into building a dummy websocket server to emulate obs-websocket. That should allow to write unit tests for the core handling logic of the client against these cases.

As you probably already saw, I pushed a change yesterday that should fix this.
I'll make a new release today.

Yes, thank you for that :smile:


Azure Notification Hubs getting multiple registrations

Please check all of the platforms you are having the issue on (if platform is not listed, it is not supported)

[x] iOS
[x] Android
[ ] UWP
[ ] watchOS
[ ] tvOS
[ ] Tizen
[ ] .NET Standard

Feature Library

[ ] Core
[ ] BluetoothLE
[ ] Beacons
[ ] Locations
[ ] HTTP Transfers
[ ] Notifications
[ ] Sensors
[x] Push

Version of Library
Shiny.Push.AzureNotificationHubs <IP_ADDRESS>3-beta
Version of OS(s) listed above with issue
iOS 13.4.1
Android 9
Steps to Reproduce

Install Shiny.Push.AzureNotificationHubs
Initialize it in the Startup
Go to the Device Registrations after a few times running it.

Expected Behavior
Each test device should show up once
Actual Behavior
The Devices are registered repeatedly.

Are you calling RequestAccess each time as well?  I assume so, just want to be sure.

So the code I have is as follows:
public class MyStartup : PrismStartup
{
    protected override void ConfigureServices(IServiceCollection services)
    {
        services.UsePushAzureNotificationHubs<PushDelegate>(
            Secrets.NotificationHubsConnectionString,
            Secrets.NotificationHubName
        );
    }
}

Then in the service that I need to access the Registration Token I have:
var access = await _pushManager.RequestAccess();
var token = _pushManager.CurrentRegistrationToken;

This should be resolved in the latest beta.


Merge 2.60.0 to master aug3

See detailed description in the commit message.

all of my commits are cherry picked from master

@doktoric there are quite a few commits from 2.60


Improve drawing of PBs map

Fix #146
@HubLot could you test please?

Looks good to me! The use of different axes is clever.
I tried on several size of proteins (up to 360 residus) and the results looks always readable. Good job!
Can you check the checkbox 'allow edits from maintainers' @pierrepo? I would like to test this feature and fix some PEP8 issues :)

Thanks!
I don't have this option. Maybe because it's not a fork?
https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/

Oh indeed.  Dunno if it's the right thing to do

Yes go ahead.
Le 17 janvier 2017 15:50:13 GMT+01:00, Hub<EMAIL_ADDRESS>a écrit :

Oh indeed.  Dunno if
it's the right thing to do
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/pierrepo/PBxplore/pull/147#issuecomment-273188961

--
Envoyé de mon appareil Android avec K-9 Mail. Veuillez excuser ma brièveté.


ci: remove duplicate guardrails [skip deploy]

Why
We recently rolled out this new Guardrails workflow to every repository, but
I've discovered we don't actually need it! 🙈
I learned that GitHub rulesets can require a specific, shared workflow to pass
for every repository instead! So, I have created an org ruleset that requires
the
guardrails workflow
in github-workflows to pass before merging to the default branch. This applies
to all repositories, but it is currently not a blocker for merging.
The problem we have now is that there are two guardrails checks running on
every PR (the one from the ruleset and the one from the workflow in each
repo).

Maintaining a single ruleset is easier than maintaining workflow files in our
~400 active repositories. So let's keep it simple!
https://wealthsimple.atlassian.net/browse/BEPLAT-1468
What Changed

Delete the guardrails.yml GitHub workflow file

[!WARNING] This PR was opened automatically Please review it carefully for
changes! Reach out to
#backend-platform-on-call
on Slack if you have any questions

I actually want to keep this for public repos, since we've excluded them from the "Enforce Guardrails" ruleset.


Issue : Systemd configuration does not reflect Splunk Configuration

Configuration of the systemd Splunkd.service is using the following values :
    - { option: "ExecStart", value: "{{ splunk_home }}/bin/splunk start --accept-license --answer-yes --no-prompt" }
    - { option: "ExecStop", value: "{{ splunk_home }}/bin/splunk start stop" }
    - { option: "ExecReload", value: "{{ splunk_home }}/bin/splunk restart" }
    - { option: "Restart", value: "on-failure" }
    - { option: "RestartSec", value: "30s" }
    - { option: "TimeoutStopSec", value: "10min" }
    - { option: "Type", value: "forking" }
    - { option: "RemainAfterExit", value: "False" }
    - { option: "User", value: "{{ splunk_nix_user }}" }
    - { option: "Group", value: "{{ splunk_nix_group }}" }
    - { option: "PIDFile", value: "{{ splunk_home }}/var/run/splunk/splunkd.pid" }
    - { option: "LimitNOFILE", value: "1024000" }
    - { option: "LimitNPROC", value: "512000" }
    - { option: "LimitFSIZE", value: "infinity" }
    - { option: "LimitDATA", value: "infinity" }
    - { option: "LimitCORE", value: "infinity" }
    - { option: "TasksMax", value: "infinity" }

when the splunk documentation is asking for :
#This unit file replaces the traditional start-up script for systemd
#configurations, and is used when enabling boot-start for Splunk on
#systemd-based Linux distributions.

[Unit]
Description=Systemd service file for Splunk, generated by 'splunk enable boot-start'
After=network.target

[Service]
Type=simple
Restart=always
ExecStart=/opt/splunk/bin/splunk _internal_launch_under_systemd
KillMode=mixed
KillSignal=SIGINT
TimeoutStopSec=360
LimitNOFILE=65536
SuccessExitStatus=51 52
RestartPreventExitStatus=51
RestartForceExitStatus=52
User=splunker
Group=splunker
Delegate=true
CPUShares=1024
MemoryLimit=<value>
PermissionsStartOnly=true
ExecStartPost=/bin/bash -c "chown -R splunker:splunker /sys/fs/cgroup/cpu/system.slice/%n"
ExecStartPost=/bin/bash -c "chown -R splunker:splunker /sys/fs/cgroup/memory/system.slice/%n"

[Install]
WantedBy=multi-user.target

The current configuration does not allow for the Workload management to be enabled via an ansible installation (at least the ExecStart and the Restart need to be changed.
I'm not a Unix expert so I don't really know the impact of this.

Good catch. I came across this in the docs as well, but only after the refactor to rely on service restarts for everything was done. I have not tested with workload management to confirm that the current configuration does not work with it, but I agree that we generally be aligned with the best practices from the docs.
This is going to require some additional refactoring, as  ExecStart=/opt/splunk/bin/splunk _internal_launch_under_systemd does not accept additional arguments, namely --accept-license which means we'll need to make a new task that does splunk ftr --accept-licence --no-prompt --answer-yes  and include it at the appropriate points (ie after install/upgrade but before starting splunk) during the installation and upgrade tasks.


botocore,boto3,awscli: 1.13.2->1.13.37,1.10.1->1.10.37,1.16.266->1.16…

….301
Motivation for this change
Keep the tool up to date.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @FRidh

Thanks for finding this, @jonringer! I'll check it.

thank you for submitting the PR, however, most of these packages have been updated on master.


API-5674 Upgrading sentry node dependency

Related story: https://vajira.max.gov/browse/API-5674
Upgrading @sentry/node dependency from version 5.30.0 to 6.2.3
Confirmed update with npm outdated and verified unit and regression tests pass.

Major release notes:

https://github.com/getsentry/sentry-javascript/releases/tag/6.0.0

This major version release doesn't contain any breaking API/code changes.


Allowing extra fields

Is it possible to ignore extra fields? With ppx_yojson_conv you just need to add a [@@yojson.allow_extra_fields].

It is - [@@deriving yojson { strict = false }] will ignore extra fields. https://github.com/ocaml-ppx/ppx_deriving_yojson#semantics covers more at the end of the section.


New function custom_src() to better proxify URLs

Proxify images like this: <img data-thumb="//i.ytimg.com/i/lgRkhTL3_hImCAmdLfDE4g/1.jpg"
And multiple URLs inside srcset="http://site.com/a.jpg 1x, http://site.com/b.jpg 2x"
Added private function custom_src($matches) and more "string replace" rules.
More info on the last commit.

Will make a new PR soon with a better function, closing this PR now.


Add timeout to requests calls

Many developers will be surprised to learn that requests library calls do not include timeouts by default. This means that an attempted request could hang indefinitely if no connection is established or if no data is received from the server.
The requests documentation suggests that most calls should explicitly include a timeout parameter. This codemod adds a default timeout value in order to set an upper bound on connection times and ensure that requests connect or fail in a timely manner. This value also ensures the connection will timeout if the server does not respond with data within a reasonable amount of time.
While timeout values will be application dependent, we believe that this codemod adds a reasonable default that serves as an appropriate ceiling for most situations.
Our changes look like the following:
 import requests

- requests.get("http://example.com")
+ requests.get("http://example.com", timeout=60)

More reading

https://docs.python-requests.org/en/master/user/quickstart/#timeouts

I have additional improvements ready for this repo! If you want to see them, install our plugin (Github Marketplace download) & leave the comment:
@pixeebot next

... and I will open a new PR right away!
🧚🤖  Powered by Pixeebot
Feedback | Community | Docs | Codemod ID: pixee:python/add-requests-timeouts

Please don't ever submit automatic code changes like these. At least not the unsubstantial kind yet -- they don't demonstrate anything.


Filter button is missing

The per-channel filter button is now missing.  This problem looks like a CSS or icon issue, because the mouse cursor changes to a pointer when hovering and the button is still clickable (operable).
Chrome 42.0.2311.152 m

Confirmed.
Seems slack changed there iconset. I'm on it, expect a fix within 24 hours.

Should be fixed in 7f62431f0d3e460b23e34b87a9bcb27fca0edaba.

I just got the update.  Its working great!  Thanks.


[Bug]: Multiple scrolls exist on the Manage Environments page

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When I add some property like host port combination or a database name property, multiple scroll bars appear on the manage env page.
Steps To Reproduce

Create any ds and save it.
Go to Manage Environments page
Add some property like host port combination or a database name property
Note, multiple scroll bars appear on this page.

Public Sample App
No response
Issue video log
No response
Version
EC2 Instance

Resolved


add support for string custom_id in component callback

About this Pull Request
This pull request adds support for string custom_id in component callbacks
Does not add anything new, just modifies a couple of lines to allow strings to work
Tested and it works
Checklist

[x] I've run the pre_push.py script to format and lint the change(s) made.
[x] I've checked to make sure this pull request runs on Python 3.6.X.
[ ] This fixes/solves something from the project's Issues.

Issue (if referenceable):

[ ] This adds something new.

[ ] This is not a code change.
[ ] (If required) Relevant documentation has been updated/added.
[ ] There is/are (a) breaking change(s).

Please retarget this to the unstable branch. Making pull requests directly to stable currently goes against our workflow for unstable/stable design.

noooo i messed it up

I'll make a new PR with the code in the unstable branch instead


Support different Message of the Day format

Similar to what #2 fixed, displays Message of the Day when it's built dynamically.
I tested with my server that runs Ubuntu 14.04.

The following comment 1 suggests that you would need sudo to run this:
you can force with sudo run-parts /etc/update-motd.d/

That's where I got my code from and I tested without sudo and it works. I'm not sure why the guy's comment includes sudo. It wouldn't make sense to me for sudo to be required because not everyone who SSH's in going to have sudo access, so the system must be able to run the scripts in the /etc/update-motd.d/ directory without sudo.

Anything I can do to help get this merged in?

So I had a bad feeling about this due to the highly upvoted comment using sudo. Indeed, when I tried it on my own Ubuntu 14.04 system, I got the following error:
/usr/lib/update-notifier/update-motd-fsck-at-reboot: 33: /usr/lib/update-notifier/update-motd-fsck-at-reboot: cannot create /var/lib/update-notifier/fsck-at-reboot: Permission den
ied
That being said, it seems that this command does no damage when it fails, so I'm going to simply pip stderr to /dev/null from the command output, and hopefully we don't get any complaints. It's quite nice to be that much closer to ssh though, so thank you for the contribution!

That's interesting that it requires sudo. I wonder how SSH does it? Because someone logging in is not necessarily going to have any kind of super user access, and will not have used their super user access even if they have it.
Eh, problem for another time. I guess I'm just glad that whatever's letting it work on my servers is there.


Revert "[CS] Don't crash when default argument is magic literal and types don't match"

Reverts apple/swift#26074, as it causes a regression with generic type resolution.
See SR-10492

Ah, I can't actually push to this branch. I wanted to move the test into compiler_crashers_2 in the meantime, so when it gets fixed, we can move it into compiler_crashers_2_fixed. I'll create another PR after this is merged.

Sure!

@swift-ci please smoke test and merge


Support vLLM OpenAI-compatible servers

Allow the user to configure api_base. Also replace the deprecated engine field with model in most cases, except we preserve the existing behavior for some models to avoid breaking the cache.
This allows using HELM with vLLM OpenAI compatible servers.
Example:
Start the server with
python -m vllm.entrypoints.openai.api_server --model facebook/opt-125m

Run helm-run with prod_env/model_deployments.yaml:
model_deployments:
  - name: facebook/opt-125m
    tokenizer_name: facebook/opt-125m
    sequence_length: 2048
    window_service_spec:
      class_name: "helm.benchmark.window_services.huggingface_window_service.HuggingFaceWindowService"
      args: {}
    client_spec:
      class_name: "helm.proxy.clients.openai_client.OpenAIClient"
      args: {
        api_base: "http://localhost:8000/v1"
      }

There's some trickiness regarding API format - we're using legacy parameters such as engine that are deprecated. Will redo this PR later, possibly after upgrading the OpenAI SDK.


Multi-mission radioisotope thermoelectric generator knowledge

https://github.com/instructlab/taxonomy/issues/839

Closing due to combined PR here:  #1142


Regression in 0.7.1 for actix web & tail matches

Looks like there has been a change to the way url path parameters are generated between 0.7.0 & 0.7.1.  When using a tail match, which is normally defined by with a {param:.*} in the url, this now has broken output.
Here's an example config:
cfg.service(web::resource("/example/{filename:.*}").route(web::get().to(get_example)))

This matches anything that has the /example/ prefix, including any extra slashes etc..
Here's a diff of a service:
     "/example/{filename:.*}": {
       "get": {
         "operationId": "get_example",
         "parameters": [
           {
             "in": "path",
-            "name": "filename:.*",
+            "name": "filename",
             "required": true,
             "schema": {
               "type": "string"
             },
             "style": "simple"
           },

I would expect in this case the name still is filename:.*

Looks like this was done by #430

@cetra3 it this is what's happening then I think current behaviour is wrong because it leads to invalid openapi (easy to check on openapi website editor)
@snaggen any thoughts here?

Yeah the problem is that the filename on the path differers, so this yields invalid spec :(
Since there is nothing on the spec about regex being valid or other I think we should keep it as it was before.
I also use regex in the openapi at work, and I've yet to see an issue with the openapi tools.
We can add a option to keep or remove regex? But when the option is set to remove, remove it from the path as well.
What do you think?

I would have thought, stripping the regex out of the path and adding it as a pattern in the schema would be most correct.
Keeping the regex on the name causes it to be visible to users in documentation as part of the name. This is not a huge problem, just a bit ugly.

In the example diff in OP , there are a schema section. A schema section can contain a pattern, which should be a regex. So, by moving the regex from the path and name, to the schema (in the pattern property) we should get the same semantics as the actix path syntax.

You mean like:
type: string
pattern: ".*"

Interestingly on the spec Format it says the following:
"The schema exposes two types of fields: Fixed fields, which have a declared name, and Patterned fields, which declare a regex pattern for the field name.
So it seems a field name can be a regex?

Well, under the Path section for Patterned Fields, it doesn't mention anything about regex at all.... it seems to just mean the /some/{path} syntax. And also, the Patterned Fields refer to matching the path to use, not to restrict it like actix does, so it is a very different semantics.
     "/example/{filename}": {
       "get": {
         "operationId": "get_example",
         "parameters": [
           {
             "in": "path",
            "name": "filename",
             "required": true,
             "schema": {
               "type": "string",
               "pattern": ".*"
             },
             "style": "simple"
           },

is how I think the actix route
cfg.service(web::resource("/example/{filename:.*}").route(web::get().to(get_example)))

should be interpreted since in actix this means the path /example/{filename} that matches ".**

Yeah I'd be happy with that. @cetra3 looks good to you too?
How would we do reversal to generate server side code from that yaml? Only if the pattern is explicitly ".*" do we pass that to the actix server?

How would we do reversal to generate server side code from that yaml? Only if the pattern is explicitly ".*" do we pass that to the actix server?
Well, since the pattern is regex shouldn't it just be reversed, so that the path would be /example/{name:pattern} in any case where the schema have a pattern?

Oh ok I thought actix didn't quite support regex, it's been a while since I looked at it.

So to expand upon the issue a little more, we're using the openapi-generator-cli which does a pretty trivial "search & replace" against the path to build up the correct uri.  With 0.7.1 this doesn't work, as filename:.* != filename.
To clarify: in actix-web this syntax is not strictly regex, it's a special way of dictating a path route includes a tail match. That is: the param can include forward slashes.
I.e, /example/{filename:.*} matches on:
/example/file.txt
/example/path/to/file.txt
/example/another/file.txt

Whereas /example/{filename} only matches things like:
/example/file.txt
/example/another_file.txt

So I think this statement might not be entirely correct:

should be interpreted since in actix this means the path /example/{filename} where the filename matches ".**

However: I agree that the example given example looks like it would solve the issue.

I took a stab at fixing the regression, but got stuck. Basically, one way to do it would be to strip the pattern as early as possible. So, that nothing that goes in to path_map contains a pattern. However, then we loose the information about the pattern. So, I guess the pattern should be removed as late as possible, but I'm not sure how to do that in a good way.

I have now pushed a fix for this regression. The pattern in the template is removed when the paths is serialized. And the pattern is also set as a pattern in the parameter information.
I realize that the patterns might not be fully compatible, but it will probably only be a problem in the more advanced cases. So, perhaps just wait and address that when it becomes a problem.

Hey looks like this one is still an issue in 0.8.1 should I raise another issue or can we reopen this one.

Oh then let's reopen it :(


Dispatch within FileReader's reader.onload()

It seems that mockedStore.getActions() does not see dispatches within FileReader's reader.onload()
mockedStore.getActions() returns [ { type: 'Works' } ]
Can I get some help retrieving dispatches when using FileReader?
export const importRule = file => dispatch => {
    const reader = new FileReader();
    dispatch({
        type: 'Works'
    });
    reader.onload = (e) => {
        dispatch({
            type: 'Does not work'
        });
    };
    reader.readAsText(file)
};

Hi, it depends on where you call mockedStore.getActions(). If it's called in onload, it will have both 2 actions; if it's outside, will only have one { type: 'Works' } because onload is async

You can wrap onload into the promise, that will allow you to call getActions after onload gets finished


Add multiple currencies and pending transactions

Description
Adds the following features:

Abstract API base class which is extended by the APIs: pending (get pending transactions), tokenMetadata (get decimals/name for a token), txHash (get amounts and timestamps for a transaction) and transactions (get completed transactions). There are a number of APIs because many data sources have to be combined to get the full picture.
Multiple currency support. Currencies can be added through repeat store.dispatch(addToken(address)) calls.
Pending transaction support. Polls an external API and uses Etherscan to convert the resulting hashes to contract data.
Changes NumberInput to take a number as a value.
Caches identity resolver responses to prevent requesting identities many times
Updates DailyTotal to calculate total from each token taking decimals into account
Adds trust and token metadata to the transactionslist container
Moves isFSA out of actions and into the reducer builder to decrease code noise
Splits updateSettings action into multiple actions, one for each relevant item of data stored

Issues fixed
Fixes #76.
Checklist

[ ] npm test returns no warnings or errors.

Unit tests to be updated

I'm happy with the changes. - But the tests are failing. 😭
Can you take a look when you can. - Would be awesome to get this in before Friday. - Let me know if anyone else can take a look in the interim.

I can have a look at the tests

Updated test scripts for the transaction reducer are IN 🙌

Rebased onto master


Cannot create traefik, tunnel, or mailhog containers

While trying to create a new Warden project using the walkthrough at https://docs.warden.dev/environments/magento2.html , the traefik, tunnel, and mailhog containers are not created when running warden env up
This also seems to be an issue when trying to spin up existing Warden projects that I have created in the past. It is not limited to new projects.

After doing a brew uninstall warden and then reinstalling with brew install wardenenv/warden/warden this issue is no longer present.
My local install of warden had been the davidalger/warden/warden version. Migrating/updating to the wardenenv/warden/warden version solved it for me.


Daily energy entities disappear from powercalc UI after reboot

System Health details
Couldn't find it
Checklist

[X] I have read the FAQ to see if there is a known solution to my problem.
[X] I have enabled debug logging for my installation.
[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of currently previous issues..

Describe the issue
I have created like 5 entries in powercalc gui and there were working with no issue, restart home assistant made them disappeared from powercalc but they are available on entities with red exponential mark saying unavailable "This entity is no longer being provided by the powercalc integration. If the entity is no longer in use, delete it in settings"
Reproduction steps

Create daily energy like fridge
Value like 1
tiggle utilities meter
4.submit
Restart home assistant
Entry disappeared
...

Debug logs
2024-05-30 14:14:58.142 DEBUG (MainThread) [custom_components.powercalc.sensors.daily_energy] Creating daily_fixed_energy energy sensor (name=Test_debug energy, entity_id=sensor.test_debug_energy, unique_id=Test_debug)
2024-05-30 14:14:58.142 DEBUG (MainThread) [custom_components.powercalc.sensors.daily_energy] Creating daily_fixed_energy power sensor (base_name=Test_debug unique_id=Test_debug)
2024-05-30 14:14:58.142 DEBUG (MainThread) [custom_components.powercalc.sensors.power] Creating power sensor (entity_id=sensor.dummy entity_category=None, sensor_name=Test_debug power strategy=fixed manufacturer= model= unique_id=Test_debug_power)
2024-05-30 14:14:58.143 DEBUG (MainThread) [custom_components.powercalc.sensors.utility_meter] Creating utility_meter sensor: Test_debug energy daily (entity_id=sensor.test_debug_energy_daily)
2024-05-30 14:14:58.143 DEBUG (MainThread) [custom_components.powercalc.sensors.utility_meter] Creating utility_meter sensor: Test_debug energy weekly (entity_id=sensor.test_debug_energy_weekly)
2024-05-30 14:14:58.143 DEBUG (MainThread) [custom_components.powercalc.sensors.utility_meter] Creating utility_meter sensor: Test_debug energy monthly (entity_id=sensor.test_debug_energy_monthly)
2024-05-30 14:14:58.143 DEBUG (MainThread) [custom_components.powercalc.sensors.daily_energy] sensor.test_debug_energy: Restoring state: 0
2024-05-30 14:14:58.144 DEBUG (MainThread) [custom_components.powercalc.sensors.power] sensor.dummy: State changed to "on". Power:25.00
2024-05-30 14:14:59.147 ERROR

Diagnostics dump or YAML config
No response

No errors in the logs?
You should see Creating daily_fixed_energy energy sensor one time for each your config entry, which indicates the entities are being created by powercalc.
In your debugs logs I only see one for "Test_debug", so that's probably a test you did?

Yes I did the test to collect the debug info and only that what I've got. Any daily energy sensors created by powercalc via the UI will disappear after restart the home assistant. So I went a head and created them in the configuration yaml file and they are working with no issue. The only two sensors that never disappeared from powercalc are the Google home that automatically discovered and another one I created for my Tuya smart plug. Maybe because they associate with actual devices and the daily energy all just virtual?

i have this issue too. real devices stay, but any virtual device disappears. I note the entities are still there, but inactive, but the base device is gone

@mikealanni Issue confirmed with Daily energy. I was able to reproduce and have a fix with #2271
Actually this bug was introduced in very recent version v1.12.3 from 2 weeks ago.
@tubbers For you also this config entry is not visible anymore at "Integration entries"?

Did you create this recently?
I not available anymore please create again, and after that check the logs for errors. Also click three dots and download diagnostics than. Would help me debug the issue.
When the config entry is still visible, also download diagnostics and share.

I have the same issue. Real device stays like Alexa and virtual device disappear.

@laplac Could you have a look into the questions I asked to @tubbers ?
And since when do you experience this issue?

@bramstroker I was on version 1.12.3. I just updated to version 1.12.5 now and will test.
Q. this config entry is not visible anymore at "Integration entries"?
A. The config disappear completely from the integration entries after restart. the entities like energy and utility entities stays but with status "Not provided"
Q. Did you create this recently?
A. Yes on version 1.12.3 .

@bramstroker I was on version 1.12.3. I just updated to version 1.12.5 now and will test.
Q. this config entry is not visible anymore at "Integration entries"? A. The config disappear completely from the integration entries after restart. the entities like energy and utility entities stays but with status "Not provided"
Q. Did you create this recently? A. Yes on version 1.12.3 .

Ah ok thanks. That was exactly what I was able to reproduce and fixed. But not released yet.
This bug was specifically with "Daily fixed energy", not "Virtual power (manually)".
There was a JSON encoding issue while saving the config entry, so the entry would never been actually saved, and thus not surviving restarts.
Will release new version shortly with the fix.
But I  was uncertain because of your comment "virtual device disappear" that the issue was broader than only the daily fixed sensors.

Just released v1.12.6 with the fix.
@tubbers when your issue is not with "Daily energy" sensors please create a separate issue, and provide more information.

I don't have the 3 dots to download, as the devices are missing.  So there is no configure option or 3 dots.  Only physical devices exist.  I upgraded to this new fixed version and recreated the devices. I created both daily energy and virtual devices and both were lost on reboot


merge settings into group box on multirecord

The rendered rate should probably be in the settings box...I now there is a risk of confusion.
You should also add a tool tip explaining that parameter

Dpme


Plot.raster mixBlendMode firefox

Hey folks - I was checking out Jo Wood's amazing {Topographic Mapping](https://observablehq.com/@jwolondon/topographic-mapping) notebook. On Chrome, the mixBlendMode looks great

On Firefox, however, it does not.

FF 116.0.2 (64-bit)
macOS Monterey v12.5

Looks like the mixBlendMode is set on the <image>. If I instead add it to the containing <g> if works in Firefox (as well as Chrome).

We don’t typically include workarounds for browser bugs in Plot. Moving the mixBlendMode up to the pattern G changes the semantics if there are multiple images. Though, maybe in this case we can make an exception? In any case probably best to file a bug with Firefox first.

I can't reproduce (it works in Firefox for me).
tested on MacOS Ventura 13.4.1 (22F82) with FF 115.0.3 (64 bits) and FF 116.0.2 (64 bits) and 116.0.3 (64 bits) [For some reason Firefox upgraded twice while I was checking!]

Same experience for me as Fil. Works fine logged out in FF 107 and also when I updated to FF 116.0.3 (OS Venture 13.4.1).

Closing as this is either a browser bug, or not reproducible, and hence we do not plan on taking any action. But please feel free to continue discussing.

I can't reproduce (it works in Firefox for me).
tested on MacOS Ventura 13.4.1 (22F82) with FF 115.0.3 (64 bits) and FF 116.0.2 (64 bits) and 116.0.3 (64 bits) [For some reason Firefox upgraded twice while I was checking!]

Weird. I just updated to Ventura 13.5.1, and the issue persists! I guess an odd FF+OSX edge case issue. I'll try to open a ticket with Mozilla. Thanks!

Just for info and completeness - this issue only occurs in firefox, with my external monitor (!)

Chrome + monitor = no issue
Chrome + laptop = no issue
Firefox + monitor = issue
Chrome + laptop = no issue

Thanks for having looked into it nevertheless!


Getting error during Android & iOS build since App Center Distribute updated to version 3.154.1

What App Center service does this affect?
App Center Distribute v3.154.1
Describe the bug
on Android (we seem to have found out the issue in iOS as it shows the erorr message clearly):
==============================================================================
Task         : App Center distribute
Description  : Distribute app builds to testers and users via Visual Studio App Center
Version      : 3.154.1
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/app-center-distribute
==============================================================================
##[warning]Cannot find any file based on /Users/vsts/agent/2.153.2/work/1/a/mapping/**/mapping.txt.
##[error]"{\"message\":\"Forbidden\",\"statusCode\":403,\"code\":\"Forbidden\"}"
http response code: 403

To Reproduce
Expected behavior
I noticed the past builds that were successful, App Center distribute was at version 3.150.1 .
Once the version bumped to 3.154.1, thats where the builds began to fail.
After looking into the chain of failed builds i noticed they all share the similar version 3.154.1
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser: Chrome v75
Version [e.g. 22]

Additional context
the project is built on react native after ejecting from expo.
appcenter npm version is 1.8.1

Hi, i resolved the issue. I built a post-build script based on the comment https://github.com/microsoft/appcenter/issues/75#issuecomment-493184790 . From there, the error still shows, but now it also shows what is wrong. turns out my dev team did not set a destination for the new config.

@qwerqy Are you distributing to distribution groups or store? Likely there is some improvements we can make in the task, at least for better error message.

We've started getting these errors within the last 2 days on all iOS builds. The first failure on a branch will involve a 404 and all subsequent errors are 403s. Both are pasted below.
##[section]Starting: Create distribution
==============================================================================
Task         : App Center distribute
Description  : Distribute app builds to testers and ***s via Visual Studio App Center
Version      : 3.154.1
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/app-center-distribute
==============================================================================
##[error]"{\"message\":\"Not found. Context ID: d4b8ab79-f48c-42e4-9047-50a07276c3fe\",\"statusCode\":404,\"code\":\"Not Found\"}"
http response code: 404
##[section]Finishing: Create distribution

##[section]Starting: Create distribution
==============================================================================
Task         : App Center distribute
Description  : Distribute app builds to testers and ***s via Visual Studio App Center
Version      : 3.154.1
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/app-center-distribute
==============================================================================
##[error]"{\"message\":\"Forbidden\",\"statusCode\":403,\"code\":\"Forbidden\"}"
http response code: 403
##[section]Finishing: Create distribution

This is happening on 3 different branches and all Android builds still work. The iOS builds do not share code in a way that would have caused all of these to start failing at the same time. It also did not correspond with a bump in App Center Distribute, as this issue suggests, because we've had plenty of successful builds on 3.154.1. I've contacted App Center support, but was only pointed to this issue.
Any chance anyone would have insight into this? Thanks in advance!

@guschilds Most likely the user who originally setups the build lost access to the app. Do you mind reach back to customer support and ask to have the ticket transfer to me? I can help work with support to take a deeper look

@qwerqy Are you distributing to distribution groups or store? Likely there is some improvements we can make in the task, at least for better error message.

apologies for the late reply. we distribute to store.

@qwerqy hmm... that's odd. I double-checked configuring a build with distribution or use the Azure DevOps task directly in an Azure DevOps account. Both require selecting a destination.

@qwerqy hmm... that's odd. I double-checked configuring a build with distribution or use the Azure DevOps task directly in an Azure DevOps account. Both require selecting a destination.

Are you saying an error will show saying that the user has selected the option to use Store but did not specify destination right after clicking Save/Save & Build? i do not recall facing that warning.

@qwerqy You shouldn't be able to save the build configuration without specifying a destination. Could you try to reproduce that (save without having a destination)?

I am currently facing the issue on
Task         : App Center distribute
Description  : Distribute app builds to testers and ***s via Visual Studio App Center
Version      : 3.160.0
Author       : Microsoft Corporation
this is the error it is showing for the latest merged pull requests.
##[error]"{"message":"Not found. Correlation ID: ea022ec3-aaa-bbb...","statusCode":404,"code":"Not Found"}"
can anyone help on this?

Same error here :(
com.betomorrow.gradle.appcenter.infra.AppCenterUploaderException: Can't prepare release upload, code=401, reason={"message":"Not found. Correlation ID  (TOKEN),"statusCode":401,"code":"Unauthorized"}

@wellavelino  i'm having same issue,Do you have any solution ??

same error here:
##[error]"{\"message\":\"Not found. Correlation ID: 5e2cf393-650e-4ea5-b713-6e3759573be9\",\"statusCode\":404,\"code\":\"Not Found\"}"

Most likely the user who originally setup the build configuration lost access to the app. Re-save the configuration may fix it. If not, please reach out to support who will need your app information to investigate.

@DennisPan thanks, solved ✅

@DennisPan Can you elaborate a little about what do you mean by re-saving build configuration?

@AadilMehrajBhat Open the build configuration then click "Save" or "Save & Build"

I had two app in my account that I transferred to organisation account, then I delete the former two apps in my account bt  now my apps in orgz. are listed bt all the other build, distribute page shows error
code: "Not Found" message: "Not found. Correlation ID: d34f056e-a6e1-42f3-adc5-d18c8f0a02a9" statusCode: 404

Check that the "APP ID" is correct

if your problem to upload .apk to app center with jenkins 403: {"message"=>"Forbidden", "statusCode"=>403, "code"=>"Forbidden"}
Solution:
You Must Change App Name on your Jenkins Configuration sama with your App Center Project
References : https://www.logcg.com/en/archives/3290.html

I was getting the same error today trying to upload an .ipa built in Azure DevOps to App Center:
##[error]"{"message":"Not found. Correlation ID: 7fc91062-2788-4118-b062-72bf8d76675b","statusCode":404,"code":"Not Found"}"
Previously this same upload had been working without issues for months.
I noticed in App Center > Settings > App API Tokens that there were no API tokens. I followed the steps here to add an API token: https://docs.microsoft.com/en-us/appcenter/api-docs/. I then created a new Service Connection in Azure DevOps with this API token, and changed my build to use the new service connection. That fixed the issue for me.

Getting the same issue, already tried a API token and User Token with no difference. Still getting this error:
##[error]"{"message":"Resource not found: /v0.1/apps/https://appcenter.ms/users/{user name}/apps/{app name}/release_***s. Correlation ID: de46694e-bf0f-4b30-8fd9-460d109c092e","statusCode":404,"code":"Not Found"}"
Does anybody have a solution. Already tried re-saving the configuration as well

I was getting the same error and turns out that my 'App Slug' was incorrect, I was only supplying the {app_identifier}
It has to be in the format of either:
{username}/{app_identifier}
Or if you using an Azure organisation
{orgname}/{app_identifier}
Hope this helps...

Most likely the user who originally setup the build configuration lost access to the app. Re-save the configuration may fix it. If not, please reach out to support who will need your app information to investigate.

For me, this comment has shed some light on my case, turns out the APP_API_TOKEN is suddenly invalid and i lost access to the app.
To solve it, i have to create a new App API token and use it when making api call.

Most likely the user who originally setup the build configuration lost access to the app. Re-save the configuration may fix it. If not, please reach out to support who will need your app information to investigate.

This has fixed for me as well. After stumbling for so many hours, it's finally fixed for me.


What are the units for SpringBoot metrics LibratoReporter sends to Librato?

I am using the Librato Reporte to send autoconfigured SpringBoot metrics to Librato. The generated metrics are:
ComplexGauge: name=foo
Gauge: name=foo.median
Gauge: name=foo.75th
Gauge: name=foo.95th
Gauge: name=foo.98th
Gauge: name=foo.99th
Gauge: name=foo.999th
DeltaGauge: name=foo.count
Gauge: name=foo.meanRate
Gauge: name=foo.1MinuteRate
Gauge: name=foo.5MinuteRate
Gauge: name=foo.15MinuteRate
But I cannot find anywhere what the units are for each metric. Do you guys mind replying with the units for each one? thanks a lot.

Hi @diego-carvallo-tx ,
Are you referring to the Timer type? By default they are reported as Milliseconds, you can change the default if you need to.
The foo.count metric includes a number of times the Timer code has been updated, usually corresponding to the request rate. The *Rate metrics all correspond to pre-calculated request-rate metrics at different intervals. The remaining metrics are all given percentiles of the timer samples, as measured in Milliseconds.

Could you help me complete/correct this table so I can correctly interpret the charts I see in Librato when using the LibratoReporter?

Metric
Units
Interpretation

foo
???
???

foo.count
requests
overal number of   requests since server start???

foo.median
requests/minute???
median fo requests   per minute???

foo.1MinuteRate
requests/minute
moving average   number of requests per second within the last minute

foo.5MinuteRate
requests/5minutes
moving average   number of requests per second within the last 5 minutes

foo.15MinuteRate
requests/15minutes
moving average   number of requests per second within the last 15 minutes

foo.meanRate
requests/minute???
average number or   requests per minute??? per second???

foo.75th
???
75th percentile:   75% of the time the requests are below what units???

foo.95th

"

foo.98th

"

foo.99th

"

foo.999th

"

Based on info found at https://reflectoring.io/transparency-with-spring-boot/

@diego-carvallo-tx sure, let me give it a shot:

Metric
Units
Interpretation

foo
milliseconds
avg, sum, min and max of all times in milliseconds (see Summary Fields)

foo.{75th, 95th, 99th, ...}
milliseconds
Nth percentile of time the requests are below given milliseconds

--
--
--

If you are using Spring Boot, you may also be interested in our recent addition of AppOptics support to micrometer.io: https://github.com/micrometer-metrics/micrometer/pull/705. AppOptics is the new replacement for Librato that includes APM and distributed tracing. It is built on the Librato framework and supports all the common Librato features.

Thanks, still didn't find what I need. Let me put it in a different way:
If I need a chart of the average time (in seconds) spent per request, which one should I use?
Thanks a lot for your help.

If I need a chart of the average time (in seconds) spent per request, which one should I use?

If you want average time "in seconds", you'll need to plot just the metric foo and add a display transform of x/1000 to convert milliseconds -> seconds.

Thanks for your submission. AppOptics is the next generation of Librato and is built on the same backend, but with additional support for APM and distributed tracing. We are moving future development of this client to https://github.com/appoptics/metrics-appoptics.


Cheat sheet: Put most important at the top.

Until #27600, it's critical this doc provide the most important info up front.
Read the environment 1st
Read the environment - Duplicate
Please put order sections should be listed.
My order

Working with ports, not at the top,  should be near the bottom.
Multiple ports after working with ports
All the stuff with port in the H2 should go to the bottom
Listen on all interfaces - near the end
Listen on all interfaces using ASPNETCORE_URLS - ditto
Certs stuff - low priority
Config, logging, DI at the top
Add Middleware top 1/3rd
Custom dependency injection (DI) container - right after first DI
Request handling #1, should be at top
Routing: Much higher than now
Parameter Binding - near the top (and all the associated H3's that follow)
Responses move up
Filters and auth, move up

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b09824ab-b051-75a1-13b7-b0e281cc46e0
Version Independent ID: b09824ab-b051-75a1-13b7-b0e281cc46e0
Content: Minimal APIs quick reference
Content Source: aspnetcore/fundamentals/minimal-apis.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@rafikiassumani-msft  can you suggest optimal order?

@Rick-Anderson I will add some comments by tomorrow.

Copying from https://github.com/dotnet/AspNetCore.Docs/pull/27709#issuecomment-1324258227

@Rick-Anderson  and @tdykstra Can we use the following order? These are only big titles.

WebApplication -> rename to Host
Handling request
Routing (Everything)
Parameter Binding (Everything)
Handling Results (Everything including TypedResults)
Configurations
Environment
Ports
Services and DI
Customizations (Other stuffs)

@rafikiassumani-msft @BrennanConroy Putting Configuration, Environment, etc. toward the end involves taking sections out of WebApplication and WebApplicationBuilder. The resulting H2/H3 structure is below, showing what remains in WebApp/WebAppBuilder renamed Host.
The outline shows Customizations as an everything else category. The H3s in Host could go under Customizations and vice versa. The heading "Customizations" isn't a perfect fit for everything in it.
Please let me know if you'd like to make any changes to this plan.
## Host
### Template code (first part of current WebApplication section, currently doesn't have a heading)
### Customize the IHostBuilder
### Customize the IWebHostBuilder

## Handle requests - Routing
### Route Handlers
### Named endpoints and link generation
### Route Parameters
### Wildcard and catch all routes
### Route constraints

## Handle requests - Parameter binding
### Explicit Parameter Binding
### Parameter binding with DI
### Optional parameters
### Special types
### Custom Binding
### BindAsync
### Binding failures
### Binding Precedence
### Customize JSON binding
### Read the request body

## Handle Results
### Example return values
### Built-in results
### Customizing results

## Configuration
### Read Configuration (from WebApplication and WebApplicationBuilder)
### Add configuration providers (from WebApplicationBuilder)

## Environment
### Read the environment (from WebApplication and WebApplicationBuilder)

## Working with Ports
### Multiple ports
### Set the port from the command line
### Read the port from environment
### Set the ports via the ASPNETCORE_URLS environment variable

## Services and DI
### Add services (from WebApplicationBuilder)
### Access the Dependency Injection (DI) container (from WebApplication)
### Custom dependency injection (DI) container (from WebApplicationBuilder)
### Logging (from WebApplication)
### Add logging providers (from WebApplicationBuilder)

## ASP.NET Core Middleware
### Add Middleware (from WebApplicationBuilder)
### Developer exception page (from WebApplicationBuilder)

## Authorization
### Allow unauthenticated users to access an endpoint

## CORS

## Customizations
### Listen on all interfaces (from WebApplication)
### Working with certificates (from WebApplication)
### Change the content root, application name, and environment (from WebApplicationBuilder)
### Change the web root (from WebApplicationBuilder)

## See also
Links to Filters and OpenAPI docs -- we could make these H2s with link only instead so they would show up in the automatic in-page TOC.


Enable GitHub's merge queue

### Tasks
- [x] Enable Merge Queue from the branch protection.
- [x] https://github.com/option-t/option-t/pull/1908
- [x] https://github.com/option-t/option-t/pull/1913
- [x] Set "Require branches to be up to date before merging"
- [x] https://github.com/option-t/option-t/pull/1914
- [x] https://github.com/option-t/option-t/pull/1915

We also set "Require branches to be up to date before merging" in branch protection to make the merge queue works well

I disable merge queue. I seem it was not suite solution for our scalability. For the future, we should try it again.

I enabled this again.


CI is currently failing

Two things to look at:

none build which mainly do code formatting checks (see https://github.com/dask/dask-jobqueue/pull/610#issuecomment-1665311514).
Docker image builds, might be due to Python version problem. (https://github.com/dask/dask-jobqueue/pull/606#issuecomment-1579045899)

One thing I noticed is that this looks really outdated
https://github.com/dask/dask-jobqueue/blob/4bbd0a08342926ee8728ccd9a4559be3aa3ec628/.pre-commit-config.yaml#L7
flake8 moved to github years ago, see https://flake8.pycqa.org/en/latest/release-notes/4.0.0.html "Migrate from GitLab to GitHub"

Are you looking for help with this?

Definitely!

Created PR 636  to resolve CI failures.
Unfortunately CI fails in the PR since the updated images aren't pushed from the build step if its a PR - so CI action is still using the old docker images.
LMK if there's another direction I should take this to deal with the docker image catch-22
Specific to SGE tests - adding the --full-trace flag got rid of the seg fault, but I don't have a good root cause analysis.
This PR also doesn't address CI for documentation.

CI is in a much better place. #653 is still outstanding but I think we can close this issue in favour of that one.


Exported certificate folding cross vertically displaced

Avoid duplicates

[X] Bug is not mentioned in the FAQ
[X] Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[ ] Bug is not already reported in another issue
Refer also to https://github.com/corona-warn-app/cwa-app-android/issues/5350, which is marked with label https://github.com/corona-warn-app/cwa-app-android/labels/Fix 2.25.

Technical details

Device name: Pixel 3a emulator
Android version: 12
App version: pre-release 2.25.x - 2.25.0-RC2 in addition to previously reported 2.24.2.
Regression from CWA 2.23.2.

Describe the bug
The folding guide cross on an exported EU certificate is not vertically in the center of the paper, although horizontally it is centered. The cross is vertically displaced about 4.5 mm.
Distances in mm from edge to center cross

App Version
left
right
top
bottom
comment

2.23.2
104.55
104.55
147.76
148.99
correctly centered

2.25.0-RC2
104.76
104.78
144.15
152.90
vertically displaced

Expected
105
105
148.5
148.5
dimensions for center of DIN A4

Steps to reproduce the issue
On Desktop

Use Android Studio Device File Explorer to transfer German EU vaccination certificate PDF to the emulator

In CWA App

Tap Scan
Tap Open File
Navigate to vaccination certificate in File app and tap on file, tap "Continue"
Tap three-dot symbol
Select Display Print Version, tap "Next"
Tap Share symbol
Tap Drive symbol
Tap Save

On Desktop

Open Drive https://drive.google.com/drive/my-drive
Download
Open saved PDF with Adobe Acrobat DC
Zoom to page level
Click Tools > Measure > Measuring Tool
Use mouse to measure from edges to center cross

Expected behavior
The folding cross should be in the center of the document. DIN A4 has the standard dimensions 210 x 297 mm, so the cross should be at 105 and 148.5 mm from the respective paper edge.

Internal Tracking ID: EXPOSUREAPP-13667

@MikeMcC399 Thanks for reporting. Internal Tracking ID: EXPOSUREAPP-13667. Best wishes, DS

Corona-Warn-App Open Source Team

See PR https://github.com/corona-warn-app/cwa-app-android/pull/5427

PR #5427 is included in v2.26.0-rc.1 so if anybody is handling the labels here, then https://github.com/corona-warn-app/cwa-app-android/labels/Fix 2.26 could be applied to this issue.


Removed unnecessary lifetimes

Hi! I made a commit removing some lifetimes that are not needed.

Thanks for the contribution


License

Hello,
A license for this project would be appreciated. I would suggest the MIT License.
Thanks.

Done in the new release.


Make textFont for TagView as @IBInspectable

Please, make textFont variable @IBInspectable to be able to change font from Storyboard, not only from code

Hi Roman, this is unfortunately a limitation of @IBInspectable. Please file a radar at https://bugreport.apple.com.


DataTestMethodAttribute doesn't have a constructor to set display name

Summary
The TestMethodAttribute has a constructor that allows you to set the DisplayName property.  DataTestMethodAttribute inherits from this class, but doesn't have the constructor to provide a display name, so it's impossible to provide an alternative display name for
Background and Motivation
Providing a display name for unit tests is a nice way to have a more descriptive display for your tests. However it is now not possible to do this for DataTestMethod unit tests because the required constructor is not present.
DataRowAttribute does have the ability to set the DisplayName which is nice, but it would be great to also be able to set it for the test itself.
Proposed Feature
I guess it's just a matter of adding
    public DataTestMethodAttribute(string? displayName)         : base(displayName)     {     }
(I'm still trying to build the repository without success so I cannot verify this myself yet)

Hi @HannoZ,
Thank you for the report. This indeeds looks like the feature missed some cases, we will work on it (except if you are willing to take care of it).
What's the issue you are facing with building the repository?

I would be glad to fix it myself, if I can manage to build the solution. There's a lot of advanced stuff in there so it's not very easy to troubleshoot. First I was having some issues with the .NET 9 alpha SDK, it seemed to be installed by running Build.cmd but it wasn't. So (after some searching) I found the installer on https://github.com/dotnet/installer. That helped to solve a lot of build errors, but there is one left in project FxExtensibility: "The analyzer assembly 'C:\Program Files\dotnet\sdk\9.0.100-alpha.1.24067.14\Sdks\Microsoft.NET.Sdk\codestyle\cs\Microsoft.CodeAnalysis.CSharp.CodeStyle.dll' references version '<IP_ADDRESS>' of the compiler, which is newer than the currently running version '<IP_ADDRESS>'."
And there is also an issue with uap10.0.16299  which causes a compile error in UWP_UITestMethodAttribute.cs

Thanks! I'll try to improve the build doc page.

hat helped to solve a lot of build errors, but there is one left in project FxExtensibility: "The analyzer assembly 'C:\Program Files\dotnet\sdk\9.0.100-alpha.1.24067.14\Sdks\Microsoft.NET.Sdk\codestyle\cs\Microsoft.CodeAnalysis.CSharp.CodeStyle.dll' references version '<IP_ADDRESS>' of the compiler, which is newer than the currently running version '<IP_ADDRESS>'."

Interesting, I don't have this even on clean build (git clean -dfx)

And there is also an issue with uap10.0.16299 which causes a compile error in UWP_UITestMethodAttribute.cs

Have you run this script https://github.com/microsoft/testfx/blob/main/eng/Install-WindowsSDK.ps1?

After running this script, all errors are gone!
Which means I can work on a fix myself now 👍🏻

Moved to 3.2.0

Hi @Evangelink Today I tested the new 3.2.0 package. The new constructor with displayname overload is there now, but unfortunately the display name seems to be ignored when the test is actually displayed..
Do I create a new issue for this or do you reopen this one?
public class MyTestClass
{
    [DataTestMethod("This is a data test method")]
    [DataRow("This_is_a_datarow1", DisplayName = "Row 1")]
    [DataRow("This_is_a_datarow2", DisplayName = "Row 2")]
    public void MyDataTestMethod(string input)
    {
        // test code
    }

    [TestMethod("This is a regular test method")]
    public void MyTestMethod()
    {
        // test code
    }
}

Damn, sorry I should have looked at adding some integration test. I will create a different issue. Thanks for the report!


DPU Integration With Vivado: [DNNDK_XRT] Cannot find device, index: 0

I followed chapter 5 in the DPU user guide (https://www.xilinx.com/support/documentation/ip_documentation/dpu/v3_3/pg338-dpu.pdf) to integrate the DPU into my block design.
I added the dpu node to the device tree and created the software components with PetaLinux.
However upon using dexplorer I get the error "[DNNDK_XRT] Cannot find device, index: 0"
When trying to run my VART application the dpu controller throws the same error.
xbutil scan:

cat /proc/interrupts:

Any ideas?

@Hamptonjc   hi,  which flow(vitis flow or vivado flow) did you use? and could you please share steps for details?

Hi @Hamptonjc
Since we haven't received your reply for a long time, we assume you have solved this issue and I'm going to close it. If you still have any questions, please feel free to reopen it. Thank you very much.

hi, i think i have met the same problem, could u please share your solutions?

hi @Urbont, could you please try to add dpu into your block design with v2022.2 tool? the version of dpu match v2022.2 is v4.1. And share your steps to reporpduce issue if issue still exists


Dynamo: removed double encoding when encoding lists.

The build failed... I can't run the unit tests locally either but I'm pretty sure is nothing with my commit.

The tests for the Encoder are found here: https://github.com/CargoSense/ex_aws/blob/master/test/lib/ex_aws/dynamo/encoder_test.exs. Can you please run them locally via.
mix test test/lib/ex_aws/dynamo/encoder_test.exs

Can you elaborate a bit on your changes?

Also, the reason the tests are failing is because your branch is 10 commits behind master. Please rebase off master.

Would prefer if you would rebase instead of merge, thanks.

Sure, it makes sense. I'll cancel this PR and make another one.

Thanks, not trying to be a pain but it can help the commit history readability a lot particularly when it's a small PR.


Golang Language Server Error

I cannot save file. VSCode keep showing "Getting code actions from Go"

/extGo

It looks like this is caused by the Go extension. Please file the issue to the Go extension repository. Make sure to check their issue reporting template and provide them relevant information such as the extension version you're using. See also our issue reporting guidelines for more information.
Happy Coding!


make check error

Background
when i "make check" i have the folowing error :
"...
--- PASS: TestDecodeEncode (0.03s)
PASS
ok  	github.com/lightningnetwork/lnd/zpay32	(cached)
Makefile:150 : la recette pour la cible « unit » a échouée
make: *** [unit] Erreur 123"
Your environment

version of lnd : last
which operating system (uname -a on *Nix) :Linux debian 4.9.0-4-amd64 #1 SMP Debian 4.9.65-3+deb9u1 (2017-12-23) x86_64 GNU/Linux
version of btcd, bitcoind, or other backend : not installed
any other relevant environment details

Steps to reproduce
Tell us how to reproduce this issue. Please provide stacktraces and links to code in question.
Expected behaviour
Success
Actual behaviour
Error

Looks like one of the unit tests failed, they are run conncurrently so the failure might not have been in the last package to print. Can you find which test is failing?

complete log :
root@debian:~# cd $GOPATH/src/github.com/lightningnetwork/lnd
root@debian:/usr/local/src/goprojects/src/github.com/lightningnetwork/lnd# make check
Compiling btcd dependencies.
cd /usr/local/src/goprojects/src/github.com/roasbeef/btcd && git checkout 3b7cd0380ae14f7ae01703f04b5120bf688f5dcd && glide install
HEAD est maintenant sur 3b7cd038... Merge pull request #20 from halseth/mempool-spends
[INFO]	Downloading dependencies. Please wait...
[INFO]	--> Found desired version locally github.com/aead/siphash e404fcfc888570cadd1610538e2dbc89f66af814!
[INFO]	--> Found desired version locally github.com/btcsuite/btclog 84c8d2346e9fc8c7b947e243b9c24e6df9fd206a!
[INFO]	--> Found desired version locally github.com/btcsuite/go-flags 6c288d648c1cc1befcb90cb5511dcacf64ae8e61!
[INFO]	--> Found desired version locally github.com/btcsuite/go-socks 4720035b7bfd2a9bb130b1c184f8bbe41b6f0d0f!
[INFO]	--> Found desired version locally github.com/btcsuite/golangcrypto 53f62d9b43e87a6c56975cf862af7edf33a8d0df!
[INFO]	--> Found desired version locally github.com/btcsuite/goleveldb 7834afc9e8cd15233b6c3d97e12674a31ca24602!
[INFO]	--> Found desired version locally github.com/btcsuite/snappy-go 0bdef8d067237991ddaa1bb6072a740bc40601ba!
[INFO]	--> Found desired version locally github.com/btcsuite/websocket 31079b6807923eb23992c421b114992b95131b55!
[INFO]	--> Found desired version locally github.com/btcsuite/winsvc f8fb11f83f7e860e3769a08e6811d1b399a43722!
[INFO]	--> Found desired version locally github.com/davecgh/go-spew ecdeabc65495df2dec95d7c4a4c3e021903035e5!
[INFO]	--> Found desired version locally github.com/jessevdk/go-flags 1679536dcc895411a9f5848d9a0250be7856448c!
[INFO]	--> Found desired version locally github.com/jrick/logrotate a93b200c26cbae3bb09dd0dc2c7c7fe1468a034a!
[INFO]	--> Found desired version locally github.com/kkdai/bstream f391b8402d23024e7c0f624b31267a89998fca95!
[INFO]	--> Found desired version locally github.com/roasbeef/btcutil dfb640c57141f1c2113b92b4b16d2a89c30dd258!
[INFO]	--> Found desired version locally golang.org/x/crypto 9419663f5a44be8b34ca85f08abc5fe1be11f8a3!
[INFO]	Setting references.
[INFO]	--> Setting version for github.com/aead/siphash to e404fcfc888570cadd1610538e2dbc89f66af814.
[INFO]	--> Setting version for github.com/btcsuite/btclog to 84c8d2346e9fc8c7b947e243b9c24e6df9fd206a.
[INFO]	--> Setting version for github.com/btcsuite/go-socks to 4720035b7bfd2a9bb130b1c184f8bbe41b6f0d0f.
[INFO]	--> Setting version for github.com/btcsuite/golangcrypto to 53f62d9b43e87a6c56975cf862af7edf33a8d0df.
[INFO]	--> Setting version for github.com/btcsuite/goleveldb to 7834afc9e8cd15233b6c3d97e12674a31ca24602.
[INFO]	--> Setting version for github.com/davecgh/go-spew to ecdeabc65495df2dec95d7c4a4c3e021903035e5.
[INFO]	--> Setting version for github.com/kkdai/bstream to f391b8402d23024e7c0f624b31267a89998fca95.
[INFO]	--> Setting version for github.com/btcsuite/snappy-go to 0bdef8d067237991ddaa1bb6072a740bc40601ba.
[INFO]	--> Setting version for github.com/jrick/logrotate to a93b200c26cbae3bb09dd0dc2c7c7fe1468a034a.
[INFO]	--> Setting version for github.com/btcsuite/go-flags to 6c288d648c1cc1befcb90cb5511dcacf64ae8e61.
[INFO]	--> Setting version for github.com/btcsuite/websocket to 31079b6807923eb23992c421b114992b95131b55.
[INFO]	--> Setting version for github.com/jessevdk/go-flags to 1679536dcc895411a9f5848d9a0250be7856448c.
[INFO]	--> Setting version for github.com/btcsuite/winsvc to f8fb11f83f7e860e3769a08e6811d1b399a43722.
[INFO]	--> Setting version for github.com/roasbeef/btcutil to dfb640c57141f1c2113b92b4b16d2a89c30dd258.
[INFO]	--> Setting version for golang.org/x/crypto to 9419663f5a44be8b34ca85f08abc5fe1be11f8a3.
[INFO]	Exporting resolved dependencies...

Yes, btcd (roasbeef's fork) and bitcoind (with ZMQ support) must be installed for all tests to pass.

These issues are caused because bitcoind w/ ZMQ is not installed, the proper version of btcd is installed automatically when compiling the unit or integration tests

I'm seeing the same issue. I am attaching both my output and error files. It seems like bitcoind hasn't been installed. How do I install that? On an unrelated note, it seems like the btcctl command is also not recognized.
output.txt
err.txt

These issues are caused because bitcoind w/ ZMQ is not installed, the proper version of btcd is installed automatically when compiling the unit or integration tests

I don't know if there are notifications for this issue. but I reinstalled bitcoind with ZMQ support and I'm still getting this same error too. I have been on it for the past two days, if anyone can help me out, would really appreciate it. I also check my log to see if ZMQ is enabled, it's enabled. but I still get this error.

@Geoelycom this issue is very old. Could you open a new one where you post details about your setup and relevant logs?

@Geoelycom this issue is very old. Could you open a new one where you post details about your setup and relevant logs?

Okay I'm glad you check this out. I have actually left it and move on with CLN as i was getting frustrated. I will spin it up and create a new issues with relevant informations. Thank you.


Unable to choose alternate relic, I have leveled up 3 times,  but still haven't unlocked the config

To find the config menu, click "Mods" on the main menu, then "The Construct" in the box to the left, then "Config" just below that box.
Have you reached the config menu, and it still displays "Reach EXP Level 1 as the Construct to unlock"?

I reinstalled and it fixed itself.


Speed tester

What does the program do ?
Running "finalShell.sh" runs all programs to read through a 370,000+ word file that you can find here. Each language searches for "zulu" in the text file (chose zulu because it's so far down the file), and writes the time it took to complete the process to a file in the "logs" folder. If you can find a way to make this more efficient, please do!
In general, in order from fastest to slowest, my tests ran an average of:
0.12528969923000005 seconds for Python
0.03976097 seconds for C
0.038764757 seconds for C++
0.3368500018119812 seconds for Java
In what programming language it is written?
Python, C, C++, Java, and shell scripts

Thank you for participating  in hacktoberfest ❣ if you liked working on this repo you can share it with friends and star this project for helping others


Ensure /node_modules is present prior to starting Evidence dev server

[x] Add this check to startServer(url) in src/commands/server.ts
[x] And display Install Dependencies prompt if no nodejs modules are installed
[x] Include this in v1.1.0 enhancements release (#65)

@archiewood to test:

Create an empty project folder and open it in vscode
Use new New Evidence Project command from the Command Palette... to start new Evidence project
Confirm display project folder, which is the same at your open workspace folder in this case
Open Evidence markdown document
Click Preview to view that document page rendered by the Evidence dev server
You should get a prompt to Install Dependencies first
Click Yes to Install Dependencies
Click Preview of the open Evidence markdown document again
You should see Evidence dev server starting
Switch to Output to view Evidence Outoup and logged commands and page pings
You should see server generating content for the requested page being pinged
Eventually the page should load or just click reload after you see all the query/data parts finished in the terminal output by the Evidence dev server run.

I believe this is one of the scenarios you tested last week and ended up with npm install and start server running in sequence without prompts. This should be resolved now.
If you do more testing today, please provide test steps/action as I did in this example.
All of the described workflow from above is captured in this demo gif:


Sycn to upsteam

Ⅰ. Describe what this PR did
sync functions to upsteam
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

ping @rudyfly
--- FAIL: TestGetAllPlugins (15.02s)
    manager_test.go:256: PluginServer expect Content-Type is application/vnd.docker.plugins.v1.1+json,but got
    manager_test.go:256: PluginServer expect Content-Type is application/vnd.docker.plugins.v1.1+json,but got
    manager_test.go:256: PluginServer expect Content-Type is application/vnd.docker.plugins.v1.1+json,but got
    manager_test.go:256: PluginServer expect Content-Type is application/vnd.docker.plugins.v1.1+json,but got
    manager_test.go:256: PluginServer expect Content-Type is application/vnd.docker.plugins.v1.1+json,but got
    manager_test.go:277: expect to get only one plugin, but got 0 plugins


feat: integrate REVM instead of SputnikEVM

What ❔
This PR adds integration with REVM
To run the semantic tests:
cargo run --verbose --release --bin compiler-tester -- --path solidity/test/libsolidity/semanticTests --mode 'Y+ 0.8.26' --target EVM --use-upstream-solc
These are the differences on Semantics Tests with the EVM Interpreter
Test solidity/test/libsolidity/semanticTests/externalContracts/FixedFeeRegistrar.sol[addr:24] was failing and is now passing ✅
Test solidity/test/libsolidity/semanticTests/array/array_storage_index_access.sol[test_indices:7] was failing and is now passing ✅
Test solidity/test/libsolidity/semanticTests/externalContracts/FixedFeeRegistrar.sol[owner:22] was failing and is now passing ✅
Test solidity/test/libsolidity/semanticTests/functionCall/precompile_extcodesize_check.sol[testLowLevel:2] was failing and is now passing ✅
Test solidity/test/libsolidity/semanticTests/externalContracts/FixedFeeRegistrar.sol[disown:20] was failing and is now passing ✅
Test solidity/test/libsolidity/semanticTests/externalContracts/FixedFeeRegistrar.sol[subRegistrar:25] was failing and is now passing ✅
Test solidity/test/libsolidity/semanticTests/externalContracts/FixedFeeRegistrar.sol[content:23] was failing and is now passing ✅
Test solidity/test/libsolidity/semanticTests/tryCatch/create.sol[g:2] was passing and is now failing ❌
Test solidity/test/libsolidity/semanticTests/externalContracts/FixedFeeRegistrar.sol[#balance_check:21] was passing and is now failing ❌

Here is an explanation of the differences

Test solidity/test/libsolidity/semanticTests/externalContracts/FixedFeeRegistrar.sol[owner:22] was failing and is now passing ✅
Test solidity/test/libsolidity/semanticTests/externalContracts/FixedFeeRegistrar.sol[content:23] was failing and is now passing ✅
Test solidity/test/libsolidity/semanticTests/externalContracts/FixedFeeRegistrar.sol[subRegistrar:25] was failing and is now passing ✅
Test solidity/test/libsolidity/semanticTests/externalContracts/FixedFeeRegistrar.sol[addr:24] was failing and is now passing ✅
Test solidity/test/libsolidity/semanticTests/externalContracts/FixedFeeRegistrar.sol[disown:20] was failing and is now passing ✅
Test solidity/test/libsolidity/semanticTests/externalContracts/FixedFeeRegistrar.sol[#balance_check:21] was passing and is now failing ❌

Since the address 0x124 is not a system contract on revm, the send can be done correctly, however, this made us realize that the test is wrong, since the balance_check:21 should actually be 69 eth, which is the correct value revm outputs, it does not fail on evm interpreter since the disown does not work.

Test solidity/test/libsolidity/semanticTests/functionCall/precompile_extcodesize_check.sol[testLowLevel:2] was failing and is now passing ✅

Revm has the identity precompile, while evm interpreter does not.

Test solidity/test/libsolidity/semanticTests/array/array_storage_index_access.sol[test_indices:7] was failing and is now passing ✅

On EVM Interpreter we don't have enough gas (0xffffff), we do however on revm (20000000)

Test
solidity/test/libsolidity/semanticTests/tryCatch/create.sol[g:2] was passing and is now failing ❌

In this test, first it tries to deploy a contract which constructor reverts, it catches that error and then it passes.
Then it deploys another contract, this one does not revert, however the address expected is not the same.
This is because on EVM when a deploy fails, the nonce is still incremented, and this test expects it is not.
For the remaining tests this are the numbers:
REVM:
16673 Success
400 Failed
2 Invalid
EVM Interpreter:
16802 Success
269 Failed
4 Invalid

Why ❔

Checklist

[x] PR title corresponds to the body of PR.
[x] Tests for the changes have been added / updated.
[ ] Documentation comments have been added / updated.
[ ] Code has been formatted via cargo fmt and checked with cargo clippy.

Please also run cargo fmt pre-commit.


[1.12.2] [beta17] Magic & Essentia Mirror are missing inventory icons

Hi,
the Magic & the Essentia Mirror are missing their inventory icons in beta 17.

Thanks for looking into it.
Best regards
wamc

It works perfectly fine for me. What other mods are you using?

Only Thaumcraft, Baubles and Forge.
Seems to be an issue with forge, it works fine until forge-<IP_ADDRESS>15, forge-<IP_ADDRESS>16+ got this issue....

It seems a fix is pretty straight forward. That PR made blockstate #inventory variant to take precedency instead of item model json. As suggested in that PR removing the duplicate definition of a model will resolve the issue. In this case removing the #inventory variant from blockstate json make everything fine.
I've tested my solution both on 2747 (a version I prefer) and 2705 (a recommended version). They are both working fine.

Still an issue in B23 https://imgur.com/a/1Szizp9

I don't know if this is the same thing, but I also see no icons on the corresponding research branches in the thaumonomicon?

The same. Research entry uses that model too.