pkg/trace/api: add generic EVP Proxy API

What does this PR do?
Adds a generic forwarding proxy API that can forward payloads to any intake endpoint given its path and subdomain (the domain is always set to the configured Datadog site(s)).
The proxy discards all input headers (except for User-Agent and Content-Type) and adds its own with the API key for the given site, the hostname configured in the Agent and the container tags if the request comes from a container.
The proxy doesn't deserialize the payloads.
The code is mostly based on the profiling proxy API and the appsec proxy API.
Motivation
The Tracing Libraries add support for new products (profiling, appsec, ci visibility...) and need the Trace Agent to send their payloads to different endpoints. The goal of this PR is to add a generic API that can be reused for different types of payloads and endpoints instead of adding new specific forwarding APIs. The first user will be CI Visibility.
While the Tracing Libraries can send some of these payloads directly to the backend endpoints, sending them through the Agent has some advantages: you don't need to configure your Tracing Libraries with your API key or proxy settings, the hostname will match with everything else sent from the same Agent, container tags can be set...
Additional Notes

Naming is hard. I'm calling this EVPProxy. The api URL is /evp_proxy and the config settings are under evp_proxy_conf. I'm not sure this is the best name, but it achieves two goals: it is generic and it doesn't expose the name of internal backend components.

Inconsistencies in header names (Datadog-Container-ID vs X-Datadog-Hostname vs DD-API-KEY) are to keep them consistent with other Trace Agent and backend APIs.

Someone with access to this API (eg: a local user on a machine running the Agent) can make the Agent send a payload with the Agent API key to any endpoint under *.evp.datadoghq.com. I assume this can't be used to leak the key.

The new configuration options are not documented. This was already the case for the profiling API settings and we can reconsider it if we see valid use cases for tweaking these settings.

Describe how to test/QA your changes
In addition to the tests added, I tested this manually by hacking the JS Tracing Library so it sends CI Visibility payloads to the Agent instead of directly to the backend API.
Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the config template has been updated.

We don't want to add the new settings to the config template.


QC- Update/Consolidate QC items 7-11

Update QC rule 7 to the following:
If BioFin_BaseUrineCol_v1r0 = yes, collection setting is Clincial and BioClin_DBUrineRRLDtBL_v1r0 occurred more than 7 days ago, BioClin_SiteUrineColl_v1r0 must be yes
Remove current QC rules 8-11 and consolidate into this one rule:
If BioFin_BaseBloodCol_v1r0 = yes, collection setting is Clincial and BioClin_DBBloodRRLDtBL_v1r0 occurred more than 7 days ago, BioClin_SiteBloodColl_v1r0 must be yes

Updated

https://nih.app.box.com/file/1587551786119

If approved by Wednesday 12/4, this can be updated in the automation for Monday's report


Add MariadbOperator Resource

Short description:
Add the MariadbOperator resource
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

Summary by CodeRabbit

New Features

Introduced a new MariadbOperator class for enhanced interaction with MariaDB resources in a Kubernetes environment.
Added a new constant for the Helm MariaDB API group, improving reference capabilities within the application.

Refactor

Updated the structure for better alignment with Helm-managed MariaDB resources.

Report bugs in Issues
The following are automatically added:

Add reviewers from OWNER file (in the root of the repository) under reviewers section.
Set PR size label.
New issue is created for the PR. (Closed when PR is merged/closed)
Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
verified label removed on each new commit push.
To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.

Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
Cherry-pick will be started when PR is merged

To build and push container image command /build-and-push-container in the PR (tag will be the PR number).

You can add extra args to the Podman build command

Example: /build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=<commit_hash>

To add a label by comment use /<label name>, to remove, use /<label name> cancel
To assign reviewers based on OWNERS file use /assign-reviewers
To check if PR can be merged use /check-can-merge

Supported /retest check runs

/retest tox: Retest tox
/retest python-module-install: Retest python-module-install

Supported labels

hold
verified
wip
lgtm

/verify

/verified

/verified

/verified

/verified

/lgtm

/verified


¿Will put translations into spanish?

Are there planning to put documentation to Spanish?
Estimated time? Other languages?

There's no plan for that right now. The parent docs site does support localization, but the docs are maintained by the engineers themselves and nobody speaks Spanish.

Thank you very much for the reply.


Changed CI to create release note for patches

This is a result of feedback that the current release notes made it too difficult to see what changes happened on patch releases. From my experience as well it became difficult to chase down which release a commit landed on.
The risk is that this creates additional noise, both for the release page and for user notifications. I am open to feedback if this causes a problem.
Other tweaks on the CI side, these came from iteration with the same scheme for coru and equeue:

Changed version branch updates to be atomic (vN and vN-prefix). This makes it a bit easier to fix if one of the pushes fails due to a rogue branch with the same name.

Added GEKY_BOT_DRAFT as a CI macro that can optionally switch between only creating drafts or immediately posting a release. The default is what I will be trying with littlefs which is to draft minor/major releases, but automatically create patch release.
The real benefit of automatic releases is to use on tiny repos that don't really have an active maintainer. Though this is definitely no longer the case with littlefs, and I'm happy it has gained this much attention.

cc @FreddieChopin

This can be seen in action here: https://github.com/geky/littlefs-test-repo/releases


Corrected footer visibility

PR Description 📜
Fixed the disappearance of the footer copyright section.
Fixes #658

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for review.

## Add your screenshots(Optional) 📸
https://github.com/user-attachments/assets/d4921f20-92cc-47e2-b803-8b72ca44dbd1

Thank you soo much for contributing to our repository 💗

@ayush-t02 please check this out.


Empty content array instead of empty text

I filed this a few months ago (#399) and it turns out it's not a Bedrock issue, and not limited to max_tokens 1.
When Claude doesn't return anything, the content array is empty. This breaks the assumption that the content array will contain an object with a text field. The correct output should be
[ { type: 'text', text: '' } ]

Repro:
import axios from 'axios';
import 'dotenv/config';

interface Message {
  role: string;
  content: string;
}

async function apiCallMessages(messages: Message[], model: string) {
  const sampleRequest = {
    messages,
    max_tokens: 4096,  // required, maximum
    model,
  };

  let parsed, response;

  response = await axios.post('https://api.anthropic.com/v1/messages', sampleRequest, {
    headers: {
      'x-api-key': process.env.ANTHROPIC_API_KEY as string,
      'anthropic-version': '2023-06-01',  // required by the Messages API, optional for Text Completions
      'anthropic-beta': 'messages-2023-12-15',  // required to use the Messages API while in beta
      'anthropic-sdk': `anthropic-sheets/0.8.1`,
    },
  }) as Record<string, string>;
  return response.data;
}

const prompt = 'Who is the best basketball player of all time? Please choose one specific player and be brief.';
let response = await apiCallMessages([
  { role: 'user', content: prompt },
  { role: 'assistant', content: 'Stephen' },
], 'claude-3-haiku-20240307');
console.log(response['content']);  // 'Curry...'

response = await apiCallMessages([
  { role: 'user', content: prompt },
  { role: 'assistant', content: 'Stephen Curry.' },
], 'claude-3-haiku-20240307');
console.log(response['content']);  // <-- [], which is an error

Where is it documented that content should always be a non-empty array? This may be a bug in the documentation, or a misunderstanding of the API's contract.
Either way, this does not sound like a bug in the SDK, so I'm going to go ahead and close this issue.

When Claude doesn't return anything, the content array is empty. This breaks the assumption that the content array will contain an object with a text field. The correct output should be
[ { type: 'text', text: '' } ]

@rattrayalex is correct, that is not a valid assumption and this is the expected behavior for empty responses and matches the behavior on input where "content": [{"type": "text", "text": ""}] will give you an error.
Unrelated note:

'anthropic-beta': 'messages-2023-12-15',  // required to use the Messages API while in beta

Messages API is now GA and you no longer need this header.

Thanks for the clarifications!


Rename InputFilterPluginManager as PluginManager

It's redundant to repeat component name in class name.
This large class name produces inconsistent method names in consumer classes (see Factory::setInputFilterManager)

:+1:

Regardless of whether or not this is targeted at 3.0, is still a BC break, and should be labeled as such, as the change has ramifications:

users interacting with it directly have to make changes to their code
references to the class in service manager configurations will need to be updated

One reason to potentially keep the name is that this is one plugin manager that often is referenced with others in the same connect: validator, filter, and form plugin managers. Keeping the name prevents the necessity of aliasing when these are referenced together.

I did remove the BC break label because this can be done in bc way and do the removal of the old class on v3

This is a naming convention so I agree with that.


Switching to use a datetime index to make passing around data more lightweight

Wanted to get this in to make some of the testing easier/make it easier to pass around individual series rather than dataframes

Oh boy, there are a lot of corners in this code base. I hadn't looked at series_utils or top_level_metrics before.

Yup! If you have any suggestions, very open to making them better at some point.  hopefully adding date as an index will help in the future with them


Implement an EGL driver

This PR isn't meant to be merged as-is, as no current code references it.
This is needed by Wayland and could potentially be used by other platforms too, such as Android.
This driver has been written in a platform-agnostic way, requiring the implementing platform to create a platform-specific manager inheriting from the EGLManager class, implementing the _get_platform_extension_* methods.
It also includes its GLAD loader, currently only checking the Wayland platform extension.

Is it will be merged when #57025 will be ready?

Since https://github.com/godotengine/godot/pull/72831 got merged, maybe we can rebase and see if there's any diff.


Fix bug disallowing saving in setting seditor and keybindings editor

(When dirty new file is open)
Closes #56030.

@isidorn it seems like you've owned this at some point. What do you think of these changes? It doesn't break #41841.

@JacksonKearl thanks for your PR, sorry for the slow reply I was on vacation.
I think the null check makes sense, however what I am not convinced is
if (resources.length === 0) { return undefined; }
Why do you need to return here - previously we were saving all in this case and I would prefer not to change this since the save command can be triggered from like 10 different locations and I would hate to have to double check nothing gets broken. In case you are interested here are some: main menu, keybinding, context menu in open editor, actions in open editor, command palette...

I actually am unable to repro this anymore on Insiders. A fix must have come in from somewhere else.


[GHSA-fpfv-jqm9-f5jm] Incomplete string comparison in the numpy.core component...

Updates

Affected products
CVSS
CWEs
Severity
Summary

Members of the NumPy organization are disputing the CVEs validity here. NVD changed the severity score and added this note “NOTE: the vendor states that this reported code behavior is “completely harmless.“ We agree with the maintainers justification here and are therefore not including this in the database in it's current state.


#83: Added Check for empty link

As you can see in the changes the fix required me to check explicitly for "http://" in the sourceUrl. I could not find a place where the "http://" gets prepended so i assume the problem lies in the API.
So it depends on if you want to change the API or the frontend in that case.

Thanks @Agreon, you'll probably right. I'll take a look on the API end. In the meantime, I would go with your change if @hell03610 agrees.

Yeah, it is the api adding that definitely. We'll fix the api, code here looks good!

...however, it'd be nice to make the site resilient so when we fix the api and it returns a null value, it doesnt show the sourceUrl.  @Agreon  could you change it to check if it has value and it is different that "http://"? Danke!

I would suggest the following:
We close this issue/PR in favor of the API-Change. My "fix" would just clutter the frontend and after the API-Change happened it would be unnecessary to check for "http://".

I opened https://github.com/VLCTechHub/VLCTechHub-api/pull/39 ;)

@hell03610 The change in the API is already shipped, so I think we can just close this, as @Agreon suggested.


TS adds new timepoint beyond the dataset timepoints span

while annotating a dataset, move to the last timepoint,
move mouse over some spot in BDV,
press A (add linked spot) and it gets a bit crazy... would expect nothing to happen actually

TS seems to add another time point (a new line appears in TS) but does allow to see it (to scroll over it). BDV shows ellipses from the last time point and also from the new just-beyond time point. At least, this is what it looks like from outside.
How can I help?

It's a plain bug. Linking from one spot to another spot in the next frame is forbidden and what you describe should amount to nothing happening.


Coloured Name

How Do I Add Colored Names?
Example Anyone Who Uses My Name "Mage"
Their Name Would Appear In Black

Btw I dont Mind If Its  the cell that would be black

is everyone dead?
Hey Lemons

Client sided, you can however ask through the discord server.

You can use the colour sent for the cells colour as the nickname colour.
You can use the handy script Tombez wrote for Minecraft based colour codes in text. (e.g names, leaderboards using § colourcodes)

Thanks


Preparation Screen

Next step is to recreate the preparation screen before you head into battle.

Also completed.


Enhancement request: A --version switch would be useful

This enhancement request is valid as of commit 018ca2d1a499f4a5074629eaaa95f0c7f2134f1c
Please provide a -V/--version switch that prints the executable's name and version (and possibly version date) to standard output and exits successfully.
E.g.:
» ssort --version
ssort v0.12.3 (2024-01-21)
#              ^^^^^^^^^^
#               ISO 8601

Such a switch is useful for:

users or admins who want to know if an upgrade is needed, or when
referring to a given version when submitting a bug report (the submitter may not be the one who installed the binary, and may nbot be able to refer to a commit).

PS: I suggest using a capital -V for the short option. That way the lowercase -v is still available for a potentially future option that will be used more frequently (e.g., --verbose) than the version switch.
Cheers.

I can't think of any reason why not.  Fixed in https://github.com/bwhmather/ssort/pull/111.
Cheers.

(published in 0.12.3)


Fix problems with Transient State in Desktop

Overview
Currently a transient state is used in order to fetch data from API project. This however causes too much trouble - e.g. saving currently does not work, because the Aggregate roots apply changes to their OWN IState instance, thus those changes are not reflected ANYHWERE else.
Potential Solutions

Aggregates perform their own persistance somehow?
State is changed back to Singleton and a background job passively works to update it with API data. Probably the better option

Fixed


Add "node.esm" build target

Closes #38

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi, @pimterry 👋 Can you please help me with the module tests for this change? I'm not entire familiar with what you are using for that. Thanks!


Tests CI via GH actions

TLDR
Added testing via GH actions for when we have a new PR or push.

@kr1sp1n I could use your help to remove the non-functioning PR Checks


feat(curriculum): add travel agency page lab

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

Tests should work now @zairahira

Title and merge conflicts are fixed. @moT01 If you think there's not enough flexibility I can change a couple of user stories.


Changed auto-generated icon typings so both tsc and tslint are happy

So in my typescript project if you import an svg icon as follows:

import Brightness1Rounded from "@material-ui/icons/Brightness1Rounded"

you get the following error when you run tslint
ERROR: <file_path>[15, 8]: Expected import 'Brightness1Rounded' to match the default export 'SvgIcon'.
The current work aro9unds for this that are both tsc and tslint friendly are

import SvgIcon from "@material-ui/icons/Brightness1Rounded", which you can't do if you want to use mutliple icons in a file.

import {Brightness1Rounded} from "@material-ui/icons", which increases the js bundle size by about 3mb.

So I have fixed the create typings script so you can just import an icon like I have with line (0), while keeping the ts compiler (backwards compatibly happy as well) and lint happy.

Please add typescript version, tsconfig and whether this error occured via tslint our tsc.

tsc is 3.1.3
tslint is 5.11.0
So the error is a tslint error, it is not a tsc error. When you run tslint the linting fails due to the default export being named SvgIcon in all icon .d.ts files. The specific rule that is causing this error is the 'match-default-export-name', which I have set to 'true'. I don't wish to turn off this rule, however I have found a work around that doesn't have any drawbacks. If you import an icon in ts like so:
import { default as Brightness1Rounded } from "@material-ui/icons/Brightness1Rounded"
The tslint rule now holds and multiple icons can be imported in a single file without increasing the bundle size.
Thanks for responding to my pull request and apologies for not creating an issue first, however if this is not sufficient information to get this PR approved, fill free to decline because I have found a suitable work around.

That's a general issues with tslint rules. They don't provide a rationale. This one is especially confusing since this is something I would explicitly write and would be pretty annoying for refactoring e.g. suppose you only care about the interface in your code but later want to change where/how this is implemented:
- import FancyComponent from './FancyComponent';
+ import FancyComponent from './LazyFancyComponent';

I don't want to include all the renamed occurrences to add noise to the diff since the interface is still the same and I don't care how/where this is implemented (or even worse webpack/ts might alias that path to somewhere else). Only the interface matters and not the implementation.
Especially for icons in my projects I always suffix the import with icon since this is IMO way more readable:
- import Add from "@material-ui/icons/Add";
+ import AddIcon from "@material-ui/icons/Add";

import MarkProcessedIcon from "@material-ui/icons/Delete";
import BookingRequestsIcon from "@material-ui/icons/Drafts";

So I'm not fully convinced and the more code we emit as a string the more likely it is to break and publish size is already an issue for things like codesandbox.

https://packagephobia.now.sh/result?p=<EMAIL_ADDRESS>If there is a simple workaround, I would rather not change the TypeScript definition.

@eps1lon How do we move forward?

It's a tslint rule that can always be disabled and has a documented workaround in this thread. There were no arguments in favor of that rule supplied and we don't follow that rule in our docs either because we import icons like so:  import ${name}Icon from "@material-ui/icons/${name}";
Therefore I'm closing.


(WIP) PuppetDB alpine image from source

@puppetlabs/puppetdb thoughts on this approach? Our goal is to reduce the image size.
Building from source rather than packages also means developers (external; community) can build an image with their local changes, which has its own uses.
This builds an image of size 212MB, and the current puppetdb image is 412MB. Would be nice to get it down further. The Ruby+Puppet bits are what we'd like to cut out.

Test PASSed

CLA signed by all contributors.

Replaced by https://github.com/puppetlabs/puppetdb/pull/2738


Updated twitter tag

Following this guide seeing if it does anything https://www.kozhuhds.com/blog/generating-static-open-graph-og-images-in-astro-using-vercel-og

@hqasmei is this the thing that fixed it? Or is this no longer necessary?

@danstepanov yep it’s fixed. I’ll close this.


The encoding of the default admin interface method has changed.

By default, the return values of the interface methods are serialized as JSON text and sent back to the REST client.
Affected by the application of the serialization policy.
@serializationPolicy!(Base64ArrayPolicy)
Affected Methods
These methods should be serialized as JSON text.
public string loginQR (@viaHeader("Content-Type") out string contentType,
                           @viaHeader("Vary") out string vary);

public string encryptionKeyQR (string app, ulong height,
                                   @viaHeader("Content-Type") out string contentType,
                                   @viaHeader("Vary") out string vary);

I think your issue is that there are escaped " (/") in the output you receive, but that has nothing to do with Base64 serialization.
Please let me know

what the output you receive
what the output you want to receive

from those function

@TrustHenry after https://github.com/bosagora/agora/pull/2300 is merged, you will need to send your requests from the client with
Accept: image/svg+xml

set

Fixed by #2300


HaaS tests failing

I ran all tests on a fresh copy of the repo, and I got errors shown below:
py.test tests/

========================================== ERRORS==============================
____________ ERROR collecting tests/integration/keystone.py ________________________
tests/integration/keystone.py:17: in
from keystoneauth1.identity import v3
E   ImportError: No module named keystoneauth1.identity
__________________________ ERROR collecting tests/unit/cli.py __________________________
import file mismatch:
imported module 'cli' has this file attribute:
/home/naved/hil/tests/integration/cli.py
which is not the same as the test file we want to collect:
/home/naved/hil/tests/unit/cli.py
HINT: remove pycache / .pyc files and/or use a unique basename for your test file modules
_____________ ERROR at setup of TestNativeNetwork.test_isolated_networks ________________
def site_layout():
"""Load the file site-layout.json, and populate the database accordingly.
    This is meant to be used as a pytest fixture, but isn't declared
    here as such; individual modules should declare it as a fixture.

    Full documentation for the site-layout.json file format is located in
    ``docs/testing.md``.
    """

  layout_json_data = open('site-layout.json')

E       IOError: [Errno 2] No such file or directory: 'site-layout.json'
haas/test_common.py:252: IOError
____ ERROR at setup of TestNetworkVlan.test_isolated_networks ________________________
def site_layout():
"""Load the file site-layout.json, and populate the database accordingly.
    This is meant to be used as a pytest fixture, but isn't declared
    here as such; individual modules should declare it as a fixture.

    Full documentation for the site-layout.json file format is located in
    ``docs/testing.md``.
    """

  layout_json_data = open('site-layout.json')

E       IOError: [Errno 2] No such file or directory: 'site-layout.json'
haas/test_common.py:252: IOError
======================== FAILURES ===================================
________________________________________________________ TestHeadNode.test_headnode_deletion_while_running ________________________________________________________
self = <headnodes.TestHeadNode instance at 0x7fa15062b0e0>
def test_headnode_deletion_while_running(self):
    api.project_create('anvil-nextgen')

  api.headnode_create('hn-0', 'anvil-nextgen', 'base-headnode-2')

tests/deployment/headnodes.py:71:
========= 1 failed, 372 passed, 1 skipped, 1 xfailed, 4 error in 169.01 seconds ============
I ran the tests on a VM running CentOS and directly on my pc running ubuntu, and I got the same results.

It is not a issue and we are expecting py.test tests/ failling.
The reason is,  deployment / integration requires correct environment setup to test. Like what is described in doc/testing, you should only run py.test tests/unit and py.test stress.py

@shwsun is correct. I'm going to close this.


ValueError when Loading Qwen2-VL Model with Liger Kernel

🐛 Describe the bug
I'm encountering a ValueError when trying to load the Qwen2-VL model using the AutoLigerKernelForCausalLM class from the Liger Kernel. The error message indicates an unrecognized configuration class for this model.
Reproduce
Clone the repository:
bash
git clone https://github.com/linkedin/Liger-Kernel.git
cd Liger-Kernel
pip install -e .
Install necessary packages:
python
from huggingface_hub import login
hf_token = input("Enter your Hugging Face token: ")
login(token=hf_token)
pip install torch
pip install triton  # >= 2.3.0
pip install liger-kernel
pip install liger-kernel-nightly
pip install git+https://github.com/huggingface/transformers@21fac7abba2a37fae86106f87fcf9974fd1e3830
Attempt to load the model:
python
from transformers import Qwen2VLConfig, Qwen2VLForConditionalGeneration
from liger_kernel.transformers import AutoLigerKernelForCausalLM
config = Qwen2VLConfig.from_pretrained("Qwen/Qwen2-VL-2B-Instruct")
model = AutoLigerKernelForCausalLM.from_pretrained("Qwen/Qwen2-VL-2B-Instruct", config=config)
Error Message
angelscript
ValueError: Unrecognized configuration class <class 'transformers.models.qwen2_vl.configuration_qwen2_vl.Qwen2VLConfig'> for this kind of AutoModel: AutoLigerKernelForCausalLM.
Model type should be one of [list of model types].
It seems that the AutoLigerKernelForCausalLM class does not recognize the Qwen2VLConfig. Is there a workaround or an update planned to support this model? Any guidance would be greatly appreciated!
Versions
Environment Report:
Operating System: Linux-6.1.85+-x86_64-with-glibc2.35
Python version: 3.10.12
PyTorch version: 2.4.0+cu121
CUDA version: 12.1
Triton version: 3.0.0
Transformers version: 4.45.0.dev0

Qwen2-VL isnt based off of AutoModelForCausalLM, so it cant be loaded with AutoLigerKernelForCausalLM. Instead its a "ForConditionalGeneration" model, which I don't believe has an AutoModel parent class.
See instructions for loading Qwen2-VL here: https://huggingface.co/Qwen/Qwen2-VL-2B-Instruct
As a workaround, I'd recommend using the monkeypatch function apply_liger_kernel_to_qwen2_vl after from transformers import Qwen2VLForConditionalGeneration


fix counter typo

Issue #, if available:
close #56
close #57
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

what wrong at build workflow ?1


278 more seamlessly running jupyter and app

This PR allows robot to be serializable and adds a robot level method to send the serialized state of the robot to the opentrons app.

Refactor of instrument motors. Previously instrument motors were attached to a robot obj, a robot obj that may no longer exist at runtime when the robot is serialized and sent to another process. By making the getting of the robot and motor happen at runtime, we are able to execute robot commands from a serialized robot after a robot is deserialized.
Changed vector_value to be declared by a class that is the output of the original named tuple used to create such a class at run time
Used python package dill for serialization after hitting limitations with serializing lambda's/closures using python's built-in pickle.
Updated reset_for_tests to wipe out robot singleton and recreate rather than reset certain attributes in the global robot obj. Previously there was leakage in robot state across the tests due to improper setup/teardown

Coverage decreased (-0.2%) to 94.815% when pulling 0606626fb23d0d4482208694ddac4fd1f3334d39 on 278-more-seamlessly-running-jupyter-and-app into a9068b12ed466e1c6e31adad2488bde481bcc5a9 on master.

Coverage decreased (-0.2%) to 94.815% when pulling 1afa57583f3af9ca712f70fb86bced1f8b9f6bb0 on 278-more-seamlessly-running-jupyter-and-app into da793569c3a56c561df4aa544afc7bec87f0f18b on master.

Coverage decreased (-0.3%) to 94.769% when pulling 7b85a6f7ed326b6e9d31d5eea6de138e8c7296d8 on 278-more-seamlessly-running-jupyter-and-app into da793569c3a56c561df4aa544afc7bec87f0f18b on master.

Coverage decreased (-0.3%) to 94.769% when pulling daea1e079f5d59c62788163f89ce8bc4c16e836d on 278-more-seamlessly-running-jupyter-and-app into da793569c3a56c561df4aa544afc7bec87f0f18b on master.


mount point recover automatically

Ⅰ. Describe what this PR does
when fuse pod quits unexpectedly, mount point can recover automatically
Ⅱ. Does this pull request fix one issue?

support https://github.com/fluid-cloudnative/fluid/issues/1279
Design doc: https://docs.google.com/document/d/1Eg0Ir64YTY2mC-KgYHDFhh4DE-GiOAlTVckqrKluguU/edit#heading=h.11qutw29y0l3
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

@yangyuliufeng Thanks! I'm working on this.

@TrafalgarZZZ thank you for suggestions! I'll work on this.
Maybe you should set namespace label fluid.io/enable-injection: "true". It's set by MutatingWebhookConfiguration

Maybe you should set namespace label fluid.io/enable-injection: "true". It's set by MutatingWebhookConfiguration

@zwwhdls Thanks. Now it works.


CarSim problem：no collision

I built 0.9.11 on win10 and generated the .sim file according to the requirements of the official documentation. Then I run manual_control_carsim.py and pressed ctrl+k to enable carsim. But I found that the collision disappeared after turning on carsim, the vehicle could drive into the walls and the house, and even out the map. The accelerator and brake of the vehicle can be controlled normally, but the steering angle is very small compared to the original, and there is basically no way to steer normally.

I want to know where this problem is my setting wrong? I generated the sim file according to the picture below

Our team is thinking about investing in CarSim to use it in Carla. Is this still a problem in the newest release, @JarvanI ?


Report when backoff limit is exceeded

needs https://github.com/openstack-k8s-operators/lib-common/pull/508

/test functional

/test functional

/test functional

Is the Failed going to be used in any other way besides providing information if one calls up the resource from client? Any plans for it to be involved in operator behavior for example?

yes, it will be used here: https://github.com/openstack-k8s-operators/dataplane-operator/pull/879/files for tracking the attempts on the dataplane-operator side

recheck

recheck


Props passed through route remain static

Any props passed through scene remain static even if the parent state changes. Imagine a scenario wherein I would like to pass  internetConnectivity state from my parent to all the scenes. Whenever the connectivity changes, the state updates and props passed to scenes should be updated as well. Currently this is not working as expected. Copy of issue #167

+1 . my problem too . is there any workaround?

@hamidjafari, I did not wait for the solution. If you still have this issue, you can define functions in top level <Router> and those functions can get you whatever you need whenever you want. Do not forget to use bind

@mkjangid , can you place one example code here ?

@mkjangid , can you place one example code here ?

I'm having the same issue. @mkjangid a code example would be very helpful!

Attaching a sample code to get the idea
export default class MyApp extends Component{
    constructor(props) {
        super(props);
            loading:true,
            isConnected:false,
        };
    }

getMainState(){
        return this.state;
    }

<Router getMainState={this.getMainState.bind(this)}>
      <Scene></Scene>
</Router>
}

Within every scene, the functions defined at root are accessible as
var parentState = this.props.getMainState();


Honor the column max length property while populating min/max values for column metadata

Currently addColumnMinMaxValueInfo in SegmentColumnIndexCreator does not honor the column field maxLength for adding min/max values in metadata. If minString for a column is longer than default max limit 512 then minValue is set to null. This causes the segment to be preProcessed every time segment is reloaded.
Here is the summary of changes:

write - Use column maxLength property to add min/max in addColumnMinMaxValueInfo.
load -  check min / max separately and set them separately into the builder and populate accordingly in ColumneMetadataImpl.
Test -  Added a unit test to reproduce the issue and verify the fix.

Good catch! As discussed offline, changing load time only to treat min/max separately should be good enough. We don't want to use max length in field spec because user might set a huge value in order to ingest data blob, which can make metadata unreadable

Thanks for the feedback @Jackie-Jiang  I have incorporated the review comment and updated the PR.

Codecov Report
Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (59551e4) to head (0efbecc).
Report is 946 commits behind head on master.

Files
Patch %
Lines

...segment/spi/index/metadata/ColumnMetadataImpl.java
0.00%
13 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (59551e4) and HEAD (0efbecc). Click for more details.
HEAD has 53 uploads less than BASE

Flag
BASE (59551e4)
HEAD (0efbecc)

integration
7
1

integration2
3
1

temurin
12
1

java-21
7
1

skip-bytebuffers-true
3
0

skip-bytebuffers-false
7
1

unittests
5
0

unittests1
2
0

java-11
5
0

unittests2
3
0

integration1
2
0

custom-integration1
2
0

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #13897       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436     2505       +69
  Lines        133233   138763     +5530
  Branches      20636    21562      +926
=============================================
- Hits          82274        0    -82274
- Misses        44911   138763    +93852
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <0.00%> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <0.00%> (ø)

java-11
?

java-21
0.00% <0.00%> (-61.63%)
:arrow_down:

skip-bytebuffers-false
0.00% <0.00%> (-61.75%)
:arrow_down:

skip-bytebuffers-true
?

temurin
0.00% <0.00%> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix(cli.py): correct improper html generating method

Fixes #11
Test result:

thanks for the pull request. this was great!


Meet trouble in "Print It" Japanese characters on [Graz] Prebuilt packages for Mac.

Meet trouble in "Print It" Japanese characters in Workspace.
But, it is OK in Pharo's Plaground.

now fixed. :-) https://github.com/tomooda/ViennaTalk/releases/download/graz1/ViennaTalk-mac-x64.dmg
thank you for the report!


Release v0.8.3

Fixes a few oas-kit related bugs: #165 #170 and tags up v0.8.3.

Coverage remained the same at 87.863% when pulling ed88f7a82b8727764fbad0f09ff0a750755b19bd on update-oas-validator into b9cb38022b0f2c9888905916264c2292cec31279 on master.

Coverage remained the same at 87.863% when pulling 2b14d36d96d40c6f7ea0b561914d4010a7e22ef0 on update-oas-validator into b9cb38022b0f2c9888905916264c2292cec31279 on master.

Coverage remained the same at 87.863% when pulling ed88f7a82b8727764fbad0f09ff0a750755b19bd on update-oas-validator into b9cb38022b0f2c9888905916264c2292cec31279 on master.

Coverage remained the same at 87.863% when pulling 2b14d36d96d40c6f7ea0b561914d4010a7e22ef0 on update-oas-validator into b9cb38022b0f2c9888905916264c2292cec31279 on master.

Coverage remained the same at 87.863% when pulling 2b14d36d96d40c6f7ea0b561914d4010a7e22ef0 on update-oas-validator into b9cb38022b0f2c9888905916264c2292cec31279 on master.

Coverage remained the same at 87.863% when pulling 2b14d36d96d40c6f7ea0b561914d4010a7e22ef0 on update-oas-validator into b9cb38022b0f2c9888905916264c2292cec31279 on master.

Coverage remained the same at 87.863% when pulling ed88f7a82b8727764fbad0f09ff0a750755b19bd on update-oas-validator into b9cb38022b0f2c9888905916264c2292cec31279 on master.

Coverage remained the same at 87.863% when pulling ed88f7a82b8727764fbad0f09ff0a750755b19bd on update-oas-validator into b9cb38022b0f2c9888905916264c2292cec31279 on master.


Configure Azure Piplelines

This pipeline configuration builds the application and produces a build for the Release configureation

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: bdevope sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Display-only live column arrangement?

It would be nice to have a view mode that is like the results of :ArrangeColumns, but doesn't actually modify the file. That is, column widths are calculated, and then the separator is displayed as <sep><x spaces> where x is column width - column contents width. Ideally, column widths would be corrected whenever a cell was edited (not while in insert mode, but after).
I'm not sure how feasible this would be, given Vim's structure, nor how computationally intensive this would be, but it would be really nice for smallish CSVs anyway.

I think, this is like the collapse feature from issue #41 . This might be possible, with the conceal feature, but probably makes Vim a lot slower.

closing see #41

Yeah, fair enough, I didn't realise that that was discussing a view-only arrangement. The ability to have that work on non-arranged columns would be an extra.


RFC: Add command line option to lxd to disable vm support

Required information

Distribution: all
Distribution version: all
LXD version: >=5.5

Issue description
There are different use cases, for example using LXD in LXD in a restricted container, etc. where LXD could be used for containers and it isn't possible using the VM driver because the /dev/vsock kernel driver is not available.
With the upgrade to LXD 5.5 seems mandatory the activation of the listening socker for /dev/vsock also when is not used.
Speaking on this in the IRC channel the suggestion is avoid the loading of kvm kernel driver but it seems not too correct. From a user aspect I think that could be ok to have kvm kernel driver for other needs, like to have the qemu binary but simply don't use VM support on LXD.
Could be a good idea to have a --disable-qemu-driver option to lxd binary?
I dunno if there is another way to disable qemu driver.
Thanks in advance

If /dev/vsock isn't available in the container, what is happening that is causing a problem?
Having /dev/vsock available shouldn't be a requirement for LXD to start up. Is that the issue?

hi @tomponline if the /dev/vsock LXD doesn't start.
DEBUG  [2022-09-08T17:16:50Z] Initializing database gateway
INFO   [2022-09-08T17:16:50Z] Starting database node                        id=1 local=1 role=voter
INFO   [2022-09-08T17:16:52Z] Loading daemon configuration
INFO   [2022-09-08T17:16:52Z] Closing socket                                socket=/var/lib/lxd/unix.socket type="REST API Unix socket"
INFO   [2022-09-08T17:16:52Z] Closing socket                                socket=/var/lib/lxd/devlxd/sock type="devlxd socket"
ERROR  [2022-09-08T17:16:52Z] Failed to start the daemon                    err="listen vsock: open /dev/vsock: no such file or directory"
INFO   [2022-09-08T17:16:52Z] Starting shutdown sequence                    signal=interrupt
DEBUG  [2022-09-08T17:16:52Z] Cancel ongoing or future gRPC connection attempts
INFO   [2022-09-08T17:16:52Z] Stop database gateway
INFO   [2022-09-08T17:16:52Z] Not unmounting temporary filesystems (instances are still running)
INFO   [2022-09-08T17:16:52Z] Daemon stopped

So, if this something wrong could be an issue too but in my case the RFC is for ask an option that permit to disable the instance type VM instead of just trying to detect it from existing rootfs.
I had few time to read the code about DriverStatuses() that report the list of the driver supported and it isn't so clear to me how it works that LXD detect system in this case.

Inside the container is /dev/kvm available?

Yes.
# ls /dev
console  core  fd  full  fuse  kvm  lxd  mapper  mqueue  net  null  ptmx  pts  random  shm  stderr  stdin  stdout  tty  urandom  vhost-net  vhost-scsi  vhost-vsock  zero

OK do you know why its being passed through into the container? I suspect the issue will go away if you don't indicate to the container the kvm is available by passing /dev/kvm into it.

From a user aspect I think that could be ok to have kvm kernel driver for other needs, like to have the qemu binary but simply don't use VM support on LXD.

I see that you're intending to use qemu (which is why /dev/kvm is required) but not LXD VMs, so not providing /dev/vsock.
Can you confirm though that LXD will start if no /dev/kvm available, just for completeness.

Tested with a cloned container. Yeah, I confirm that disable KVM permits LXD bootstrap:
WARNING[2022-09-09T14:36:29Z] Instance type not operational                 driver=qemu err="KVM support is missing (no /dev/kvm)" type=virtual-machine

That'd be a bug, LXD should be able to start just fine in such scenarios and simply not support running VMs.
Looks like we need to fix the vsock listener.

@stgraber yeah we should be able to fix this by adding detection of /dev/vsock to the VM supported logic, which would then prevent this listener from being tried.

IMHO, i think that could be good also to have a way to disable vm support when both vsock and kvm devices are available.

If you need to disable VMs, the best is to set a VM limit of 0 on your project.

Yes, correct. But this doesn't avoid to open a listening socket with vsock kernel.
I have really few experience with vsock kernel driver. Sharing the same /dev/vsock between multiple containers could be a security hole if multiple users starts LXD in container and using the same /dev/vsock?
thanks in advance for any suggestions.

If fix the bug so that if /dev/vsock isn't provided to the container it will be considered as not supporting VMs (even if /dev/kvm is passed in), then LXD will start as normal but will not allow VMs to be used.

Personally, i think that to have an option to force shutdown is also good (because you have the same problem is there are in the container both /dev/kvm and /dev/vsock devices but you don't want VM supporto) but i leave to you how proceed ;)
Thanks for the very fast feedback and support.

I have the same issue :
https://github.com/lxc/lxd/issues/11597#issuecomment-1518589443


Tidy UI - Game Settings collapsible menu buttons are not styled

Tidy UI - Game Settings adds buttons to the Module Settings menu which allow for the individual settings for specific modules to be expanded and collapsed. These elements are not styled, even when "Enable Tidy UI - Game Settings" is enabled. As the icons default to black this can make them hard to see against darker backgrounds (such as the preset "Cobalt Theme")

Good Catch!

I am closing this, as I am not sure if this is still an issue on v10. If it is, please let me know and I'll re-open this issue


I think upload is broken?

My net specs I pay for
1gbps down/750mbps up
I see usually in the neighbourhood of around 650-750 down and about 500-600 up typically throughout the day,
I deployed this to a gke cluster and ran a test from the gke cluster to home, this is the results.

The download speed is typical of what I would see from lets say speettest.net, the upload though is definitely broken.
The docker image I used was openspeedtest/latest:latest (pushed 15 days ago from typing this)
DIGEST:sha256:2b058dda797e8bac0861a92cf5e6a34afbdf748b07f3b16fc65347916b62e504
Results from speed test immediately after running the openspeedtest one with negligible network traffic differences from my device

it's almost like the decimal place is off by 2 digits like I would expect to see around 579.64 would be normal for me

Behind reverse proxy? https://github.com/openspeedtest/Speed-Test#docker-install-instructions

Wow I have to apologize, I completely glazed over that 🤣, I set it to 10G I suppose it makes sense... the new results

Which is actually accurate due to the fact that gke depending on the machine type limits bandwidth currently capped at 300 so this is accurate now, Thank you for the assistance apologize again for glazing over that part......

For the k8s people
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  annotations:
    cert-manager.io/cluster-issuer: ISSUER-NAME
    kubernetes.io/ingress.class: nginx
    nginx.ingress.kubernetes.io/proxy-body-size: 10240m
    nginx.ingress.kubernetes.io/ssl-redirect: "true"
  name: INGRESS-RESOURCE-NAME
  namespace: NAMESPACE-NAME
spec:
  rules:
  - host: DNS-ADDRESS
    http:
      paths:
      - backend:
          service:
            name: SERVICE-NAME
            port:
              name: SERVICE-PORT-NAME
        path: /
  tls:
  - hosts:
    - DNS-ADDRESS
    secretName: TLS-SECRET-NAME


disable tech and manually enable time updates for text tracks

fixes #60

Coverage increased (+0.3%) to 82.432% when pulling 2e356f62cbb84959cb1c8c567d391cf13b6dd2e3 on tech-60 into 7d1ec932fbbdc1caf8f8fbfc4d0be6c3bf43f05d on master.


Stuck at Downloading Full ROM firmware HP Chromebook 14 SMB

When the script starts downloading Full rom firmware, it gets stuck.
Both when use Ctrl-Alt-T shell or Ctrl-Alt- right  chronos
(coreboot_edk2-falco-mrchromebox_20240416.rom)
Waited for about 5 minutes. Tried twice.
HP chromebook 14 SMB
Will appreciate any help. Thank you.

Nevermind. Ignore my enquiry, it works. It takes about half an hour. Might be helpfull if there is update on % work progress of the script when it is downloading / installing, etc.


chore: update to iOS AppNexusSDK version 9.0.0

This has already bee tried in version 0.2.9 - however this resulted in failed validation on package submission

Unexpected CFBundleExecutable Key. The bundle at 'Payload\/Runner.app\/ANSDKResources.bundle' does not contain a bundle executable. If this bundle intentionally does not contain an executable, consider removing the CFBundleExecutable key from its Info.plist and using a CFBundlePackageType of BNDL. If this bundle is part of a third-party framework, consider contacting the developer of the framework for an update to address this issue. (ID: 4d103e4e-eb6d-47e8-838c-a2933796e320)

An upstream ticket has been created, waiting for their feedback/fix here: https://help.xandr.com/s/case/5006S00002VMmAnQAL/ios-sdk-validation-error-when-using-version-900

@ashcherbonos FYI, I created this ticket to track the efforts to update the iOS sdk to version 9.0.0 (released to https://github.com/thekorn/xandr/pull/144)

this has been fixed with latest release of this package 0.2.13


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_38b8b582-44c7-4a91-9120-cd528aa942e1/pull/1 is merged into live branch.
Auto archive content to https://github.com/OPS-E2E-PPE/docs-archive-test-target_38b8b582-44c7-4a91-9120-cd528aa942e1.git

Docs Build status updates of commit ff5db83:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Archive_master_2019-09-29-06-00-17 has been deleted or has been force pushed: fatal: Couldn't find remote ref Archive_master_2019-09-29-06-00-17

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


exception during scrapy callback marked as queued

Hi,
If there is any exception with response parsing in scrapy, the request remain marked as QUEUED and  no error is logged on the frontier.

Good finding, actually. This could happen because of redirects. When redirect happens, Frontera will get a response object with last (already redirected) URL and will not match it with record in database. Therefore, it will create a new record and mark it as CRAWLED, and old one remain QUEUED.
There is canonical solvers mechanism which should be returning canonical URL,
https://github.com/scrapinghub/frontera/blob/master/frontera/contrib/canonicalsolvers/basic.py
depending on that we could mark old record as CRAWLED also. But that needs to be coded, PR is welcome as usual.

This is happening for every case and not just for redirects. To test I wrote a simple spider with sqlalchemy backend:
# -*- coding: utf-8 -*-
import scrapy

class ExampleSpider(scrapy.Spider):
    name = "example"
    allowed_domains = ["example.com"]
    start_urls = (
        'http://www.example.com/',
    )
    frontera_settings = {
        'frontier' : 'error_test'
    }

    def parse(self, response):
        raise Exception("Test Exception")
        pass

But the error is not getting set in database.

This is again a good finding, @RajatGoyal! We could solve that by handling exceptions in spider middleware, and propagating them to backend. If you could make a PR, that would be awesome!

any idea on how to propagate it to the backend?

We need to adapt interfaces in FronteraManagerWrapper, FronteraManager and Backend. I think we need to propagate type (error happened during response processing), response itself, along with error structure.

I have fixed this, but I don't have writes to push a branch now, it gives 403 response.

Can you fork Frontera to your private account, and use your local branch?

@sibiryakov Take a look at the above branch.

This could work, but would be nice to pass:

Error type: where it came from, e.g. downloader or spider?
in case of spider, response object.


chore: Delete AdaptiveControl

Summary by Sourcery
Remove the 'AdaptiveControl' class and refactor the codebase to use the 'Control' class instead, while adding 'rtl' and 'adaptive' parameters to enhance control configurations.
Enhancements:

Add 'rtl' and 'adaptive' parameters to various control classes to enhance their configuration options.

Chores:

Remove the 'AdaptiveControl' class and its usage across multiple files, replacing it with the 'Control' class where necessary.

I see there are other changes non-related to AdaptiveControl: https://github.com/flet-dev/flet/pull/4096/files#diff-90d1bdacd55399dd7e1b5e3b6958f1ae1e3923f8757d5a7a4ff8a640846f1e59
I think, going forward, we should have PR doing only one thing.
I'm closing this PR as discussed on Discord.


Rle mask export

Create Brush tool by extending this branch and making changes.

Above mentioned branch has been taken for local development. latest "develop" branch is merged to keep everything up to date. Brush tool was already added in the UI but the export to COCO was incorrect. Changes have been made to export it in RLE Mask format.
There's an issue while uploading COCO. The mask does not show up. Same thing is happening in case of importing ellipse via COCO Json. This issue needs resolution
Motivation and context

Linked issues:
https://github.com/openvinotoolkit/cvat/issues/4727
https://github.com/openvinotoolkit/cvat/issues/4723
https://github.com/openvinotoolkit/cvat/issues/1849
https://github.com/openvinotoolkit/cvat/issues/2384
How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[ ] I have added a description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[x] I have linked related issues (read github docs)
[x] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[ ] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below)

# Copyright (C) 2022 Intel Corporation
#
# SPDX-License-Identifier: MIT

@kkm-atom , we will continue the implementation in the repository for now: https://github.com/cvat-ai/cvat/pull/2.

Hi, @kkm-atom
Now, I will be able to finish the patch gradually in this repository and maybe to use some of your code if you do not mind.
Looking into a number of conflicts with develop branch and probably with current masks patch (which was adjusted and also has lots of conflicts with develop) it would be easier to close this pull request. Anyway, thank you for the contributing.


O4 gRPC Module For Communication Layer

As an initial step towards this Objective, I propose migrating the current MPI version of CommUtils to gRPC. It can be done in following steps:

Define the gRPC service and messages in a .proto file.
Generate the gRPC code from the .proto file.
Implement the gRPC server with the necessary services.
Implement the gRPC client to replace the MPI communication calls.

if nothing else is priority now, I can get started with this

Thanks for bringing it up! Xavier and Gautam are working towards this.

Hi @gautamjajoo , I want to check if I can help you with anything in the development of the gRPC Module

The issue is fixed now with a new communication manager API


quic fuzzer hang

The fuzzer from #22368 combined with #22410 and #22411, hangs with
hang2.gz

If you fix this, can I suggest that you run the fuzzer for a minute or so. I've found both those hangs in a few seconds. Use libfuzzer, and add -timeout=5 to the command line, so it gives you a nice file instead of just hanging for a very long time.

This hang is caused because we receive a very large token in a retry packet. Later we try to create a PING frame but, because the token is so large, we fail to insert the PING or anything else into the datagram. Since we have failed to generate a PING, but the ping deadline has expired we immediately try to create another PING - and so on in an infinite loop.

If you fix this, can I suggest that you run the fuzzer for a minute or so. I've found both those hangs in a few seconds. Use libfuzzer, and add -timeout=5 to the command line, so it gives you a nice file instead of just hanging for a very long time.

I did that and immediately ran into #22427

The original hang was fixed.


(feat: TX-332): AlicanAkyuz/Wire transfer payment method

The type of this PR is: Feature
This PR solves TX-332
Description
This PR adds wire transfer as an option to the payment step of the checkout flow.
Implementation Details

moved flag-checks to PaymentContent component to be able to make it easier to control which method to render.
added getAvailablePaymentMethods function that adds ACH and WIRE methods to Credit card when they are available. In case both flags are false, current Credit card input is rendered without Collapse
placed onWireTransferContinue in Payment/index.tsx to be consistent with Credit card and debit calls. This function will update backend with payment_method: 'wire_transfer' when ready.

Videos
Both flags as disabled:
https://user-images.githubusercontent.com/42584148/169832879-f9e54ca7-9f8c-40d2-b4a1-d30008209688.mov
ACH enabled, wire transfer disabled:
https://user-images.githubusercontent.com/42584148/169833381-3479cb48-4df9-49fb-89cf-80b99aa2da8b.mov
ACH and wire transfer enabled:
https://user-images.githubusercontent.com/42584148/169833047-65d6a0e0-a354-4296-a552-b6913355b5f6.mov

This PR looks great @AlicanAkyuz. One suggestion would be, once the feature flag stuff is removed lets just be sure to look carefully at the tests and cover any behavior that might have been missed with more tests (since we're dealing with money and every aspect of $ code should be covered as best as one can. If this is already the case, then feel free to ignore this message!)

@damassi thank you for flagging the tests, I definitely agree that we need to improve the tests here. The test for the flag was already there, I just changed the explanation in order to be able to differentiate ACH and wire transfer flag tests. but you are right, they actually don't test anything. I'll pay attention to these tests before the features are on prod 👍


Note that Folder Collections require 'title' field

- Summary

Updated docs so people know that the title field is required for Folder collections
- Test plan

Not sure why the last line was added and removed...
- Description for the changelog

Updated docs to note the requirement of a title field for creating new Folder Collection entries
- A picture of a cute animal (not mandatory but encouraged)

took me about 2 hours to figure that one out :)


Add Merge Function in Convex Hull

This PR adds the merge function in the ConvexHull structure. This function will be used by PWLH #45 . Necessary tests are also added. A few other changes were made in src/utilities/convex_hull.zig for consistency and to improve documentation.

Interesting, following your comments I found a bug in the len() function. Now it is fixed.


Support creating commits via SSH

This would enable the option to use deploy keys.

Interesting, could you create a PR for this?

I would love to. JS is not my dominant language, so I am not sure when I will be able to get to it.

To make this happen, the github-token needs to be optional and the repo to be written to needs to be checked out w/ the correct ssh-key, i.e. a deploy key w/ write access.


YouTube player in the sidebar doesn't seem to work

Example:
https://phuks.co/s/Apple/hot
An error occurred. Please try again later. (Playback ID: my1Hj8EOG2aF6mp_) Learn More

The youtube player has been unmaintained for a long time, and it had hardcoded phuks urls too. I've removed it in commit 95e76d5 until we can find a better solution


Make gulp private tasks private

Running gulp --tasks shows tasks that wouldn't necessarily be meant to be run on their own, such as gulp browserSync. In gulp 4 these supposably can be hidden, see https://github.com/gulpjs/gulp/issues/490

Gulp 4 tasks output is better and this probably isn't necessary anymore.


Parser gives up instead of getting out of nested rule to try alternatives

Here's a repo with this exact reproducible case: https://github.com/deltaidea/chevro-section-conditions
Syntax
A script consists of sections, which consist of commands. Sections cannot be nested.
There're also if statements, both top-level (with sections inside) and section-level (with commands inside). See a sample script below.
Here's pseudo-code of how I see the syntax:
Script = TopLevelStatement+
TopLevelStatement = TopLevelIf | Section
TopLevelIf = 'if FOO' TopLevelStatement+ 'endif'

Section = '
' SectionStatement+
SectionStatement = SectionIf | 'COMMAND'
SectionIf = 'if FOO' SectionStatement+ 'endif'

Example

  COMMAND

  if FOO
    COMMAND
  endif

if FOO

    COMMAND

    COMMAND
endif

In the example above the Parser tries the following path (whitespace is ignored):

  COMMAND

  if FOO
    COMMAND
  endif

  if FOO
    // Expecting 'COMMAND' here, Parser thinks we're still inside the section started on line 1.

How do I force the parser to rewind, pop the rule stack and try parsing the 'if' as a TopLevelStatement?
I can adjust the syntax definition in any way, so if there's a better way to parse the same language, please tell me!

The only solution I've come up with so far is:

Treat both
 and COMMAND as a flat list of statements.
Post-process CST into AST where they are nested, validate that they do not cross/intersect, e.g. no if starts in one section and contains another.

Is this a sane way to deal with this? Is there a more simple fix that I don't see?

Ah, I just found out it's possible to define custom predicates for .OR alternatives!
I could probably add a predicate for sectionIf rule that looks ahead and returns false if it sees
 token before the matching endif.
I'll close this issue once I implement that and confirm that it really works. Sorry for the noise. 😉

These are actually really good questions.
Firstly a context free parser cannot take into account the rule hierarchy of nested repetitions.
as in the example you showed, simply because it will no longer be context free as we will need
to take into account the parent rule in the hierarchy which may change between different invocations.
Secondly it looks like you will have to scan more than LL(*) tokens ahead to decide between
the alternatives even if they were both in the same alternation.
because you can always add more "COMMANDS" tokens until you find the deciding ".
This means that for any lookahead K, there is an input where K+1 tokens will be need to disambiguate the choices.
You may be able solve this by using backtracking.
https://github.com/SAP/chevrotain/blob/6a8febdcc78351b2b8610debc23f6d1b9bb1ce4d/test/full_flow/backtracking/backtracking_parser.ts#L62
But I strongly suggest you try to avoid backtracking as it is both slow, error prone (reseting state)
and mutually exclusive with automatic error recovery.
Suggested Approach.
Explicitly close the ""
Just like you have IF and ENDIF, you can also have "<END_SECTION>".

Thanks for your insight and time!
As you might suspect, adding GATE: () => false to sectionIf alternative in sectionStatement doesn't work.

Explicitly close the "Section"

I wish I could change how the language looks. 🙁
It's a scripting language for an existing third-party application, simplified to the relevant subset.
I'm writing my own AST parser, so at least I completely control the parser implementation.

you can always add more "COMMANDS" tokens until you find the deciding "section"

Note that if can include either only sections (when used at the top level) or only commands (when used in a section).
But yes, still, there could an be infinite number of nested ifs, and you'd need to traverse them all before you find the first
 or COMMAND.
I quite like the potential of automatic error recovery, so I'll try parsing commands and sections into a flat CST and validating where they appear manually when building AST.
Once again, thanks for your help!

Once again, thanks for your help!

You are welcome.
Creating a flat structure and analyzing it later is a valid approach when the grammar
cannot be described cleanly in the parser.
For example this is done in the swift programing language.

NOTE
At parse time, an expression made up of binary operators is represented as a flat list. This list is transformed into a tree by applying operator precedence. For example, the expression 2 + 3 * 5 is initially understood as a flat list of five items, 2, +, 3, *, and 5. This process transforms it into the tree (2 + (3 * 5)).

Because embedding the operator precedence in a top down parser results in
crazy deep parse trees and complicated grammar.
Btw I've looked at some of the samples for your language:
https://github.com/deltaidea/mangudai/blob/master/test/samples/sections.generated.rms
Is the indentation meaningful ? If so you can use indent and outdent tokens to indicate exiting a
section "block". Just like in python.
https://github.com/SAP/chevrotain/tree/master/examples/lexer/python_indentation

Glad to know I'm not the only one. 😄
Flat list it is then.
Nah, the indentation doesn't mean anything to the game that is the canonical interpreter. Newlines are the only part that has meaning, and only as a separator. Like newline after return in JS - it only matters whether at least one is there.


[bzip2] Add SHA512 hash check

Describe the pull request

Add SHA512 hash check to portfile.cmake
Delete old style CONTROL file
Add new style vcpkg.json file

What does your PR fix? Fixes #13224 ([bzip2] Update to 1.0.8. #13178 - missing SHA512 hash check)

Which triplets are supported/not supported? Changes made should not change triplets supported/not supported

Have you updated the CI baseline? Changes made should not effect CI baseline

Does your PR follow the maintainer guide? Yes it should

Thanks for your contribution!

You are welcome @BillyONeal, keep up the hard work 🥇


my_dealloc call when keyboard hide in UIWebView

This problem cause disable pan gesture stop working after keyboard in UIWebView show up. my_dealloc  is called after keyboard hide.
This UIViewController contain UIView > UIWebView and I push to this UIViewController from UIViewController which connect to RightMenuViewController by AMSlideMenuContentSegue

fixed


How exactly does predict_f function work? I am trying to train a gpflow model with matern52 kernel, on a training set of X_train size (10x2) and y_train as (10x1), however using predict_f on testing data of (3600x2) is actually giving an output of (3600x11), how exactly is it giving this dimension can someone explain?

GitHub issues are most helpful for reporting issues that might require changes to the GPflow code base itself. If your question is about how to use GPflow, please consider asking it on StackOverflow and using the gpflow tag (https://stackoverflow.com/questions/tagged/gpflow) for your question. This makes it easier for other users of GPflow to help you with your problem, and also makes your question and any answers more easily discoverable for others who might have the same question again in the future! If your question is about an omission or lack of clarity in the GPflow documentation, please use the documentation issue template.

That does sound wrong. Would it be possible for you to post a running code example, so I can debug it?

GPflow_model.pdf
Yeah sure sir, I'm attaching a PDF version of my notebook with its outputs for your reference. Kindly go through it and let me know how exactly is the model predict_f working and if there's a way for me to implement the code in a better way.
(I'm still really new to using gpflow, and though I was able to understand this code with scikit learn, it's causing problems here.)

It appears your Y_train has shape [11], and not [11, 1]. Gpflow then broadcasts your Y_train to shape [11, 11] to be compatible with your X_train, and that is where you get your 11-dimensional output from.
Good news is that I'm currently working on implementing much stricter shapes-checks throughout GPflow, and in future versions these kind of mistakes should become a lot more obvious.

Thank you Sir for pointing that out! I completely missed the fact regarding the shape of Y_train and broadcasting. The code is running fine now. If anything else comes up I'll mention it here or in a different issue, but for now thanks a lot for resolving this really quickly.

No problem.


Inconsistent positioning of drop-down menu on title pages

Steps to reproduce

Open any title
Click on the drop-down menu icon (opens right-aligned)

However, there is a second unintended behaviours:

Open any title.
Click the search icon.
With the search bar still active, click on the drop-down menu icon (opens left-aligned)

Expected behavior
In both cases, the menu opens right-aligned
Actual behavior
There are different 2 behaviours
Crash logs
No response
Neko version
2.14.1
Android version
Android 12
Device
Xiaomi Poco X4 Pro
Other details

Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to the newest version Latest.
[X] I have filled out all of the requested information in this form.

2.15.0 still has it

Yea I haven't looked into this much, I think its an issue with the library or how I am using the library

Ye, it's a funny weird behavior. Idk how much Neko's ui code has diverged from TachiJ2K's, but I know it doesn't have this bug, so if they are still close you could maybe look at the diff


Revamp ABout us Page and Home page issue #291

@nilisha-jais Please check this PR. I have resolved all the merge conflicts.

Looks fine now. Thank you!


Authorization:  I can NOT see items deposited by other users.

@amyehodge do you think this is complete?  Have you been able to test this?

@amyehodge do you think this is complete?  Have you been able to test this?

Yes, this one looks complete. Closing ticket.

Yes, this one looks complete. Closing ticket.


Add required_approving_review_count #89 (required go-github update)

Update go-github to latest (0.18.2) for google/go-github#880
Add new required_approving_review_count property
Correct concomitant breaking changes

Fixes #89

@radeksimko Hey! no rush or anything but I opened this PR. Don't let the XXL scare you from reviewing it, it is very small except it contains an update to the Github SDK. ACC tests passed locally and we implemented this change in our stack and it works great! Thanks for any input!!

Any news @majormoses ?

Any news @majormoses ?

I am not a maintainer for this project and my golang foo is pretty weak I just reviewed it saying I didnt see anything that looked incredibly stupid.

Any updates on getting this reviewed?

@bflad I noticed you merged the last PR, this has been open for a while, any hope of getting this reviewed? I have been using it and it is quite nice.

Looking forward to seeing this approved.

Looking forward to seeing this approved also, this is one of the several issues we need to solve before migrating to terraform GitHub management.

Any updates on getting this reviewed?

Looking forward to this!

2.0.0 has been released, including support for this attribute.


task(components/button-group): button-group update to ease use in audio/video controls

Description
Updates were made to the ButtonGroup component to make it easier to use it with the audio/video controls design.

Added a "compressed" property to compress horizontal space and remove inner borders around ChildNodes
Added new Compressed and Audio Video Controls stories.
Updated snaps of components that used ButtonGroup since it added data-compressed={false} to all of them.

Links
https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-303422

I'm going to go ahead and merge this so other audio/video work can get started. I think a new ComboButton? component that pre-composes a PillButton and CircleButton (with down arrow) would be a nice addition and then we could strip out the somewhat odd "compressed" numbers and use it for audio/video controls and other places that need the button + dropdown.


Alexa session timeout time

I have some questions about session timeout
When i set the service endpoint in the lambda , 8's could happen session timeout
but i set  service endpoint in the https (flask-ask) , 2~4's could happen session timeout
Is it possible to extend the flask-ask's time (not set reprompt)?

I think this is a dupe of
https://github.com/johnwheeler/flask-ask/issues/44
I don't think it is possible to set the timeout from the server. If lambda is allowing a longer timeout than an HTTP endpoint, that would be an issue with the Alexa Service and outside Flask-Ask

Ok....
Thank you for your answer & python code


[DDW-309] Limit maximum number of wallets to 20

This PR limits the maximum number of wallets to 20.

Review Checklist:
Basics

[ ] PR is updated to the most recent version of target branch (and there are no conflicts)
[ ] PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
[ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub
[ ] Automated tests: All acceptance tests are passing (npm run test)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (npm run dev)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (npm run package / CI builds)
[ ] There are no flow errors or warnings (npm run flow:test)
[ ] There are no lint errors or warnings (npm run lint)
[ ] Text changes are proofread and approved (Jane Wild)
[ ] There are no missing translations (running npm run manage:translations produces no changes)
[ ] UI changes look good in all themes (Alexander Rukin)
[ ] Storybook works and no stories are broken (npm run storybook)
[ ] In case of npm dependency changes both package-lock.json and yarn.lock files are updated

Code Quality

[ ] Important parts of the code are properly documented and commented
[ ] Code is properly typed with flow
[ ] React components are split-up enough to avoid unnecessary re-rendering
[ ] Any code that only works in Electron is neatly separated from components

Testing

[ ] New feature / change is covered by acceptance tests
[ ] All existing acceptance tests are still up-to-date
[ ] New feature / change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review:

[ ] Merge PR
[ ] Delete source branch
[ ] Move ticket to done on the Youtrack board

Hello! Can, please, someone explain shortly, if possible, why limit had to be changed from 50 to 20? Would much appreciate. Thank you!

Hello @vantuz-subhuman! This decision was a result of the benchmarking we did. Limiting the number of wallets to 20 ensures Daedalus performs optimally for most of the users.
Cheers!


enhancement: better pool usage

enhancement: better pool usage.
Objects should be returned to pool after using to get a better memory handle.

Sry. I found out it was *bitmap. Can not return to the pool or it might get changed caused it's a reference.
Maybe we should use bitmap instead of *bitmap? Otherwise, we may change the bitmap set it to zero after NewBitmap64


adding main page link to the footer logo

What feature?
I have an idea
Add screenshots
Add screenshots
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@anuza08 you can Add About page to the LOGO


Fix bug in MercurySender

There was a bug in MercurySender. This bug did not have any consequences, since the requests were executed nevertheless, and just the channel for the response was dropped too early (but no one was interested in these responses).

I don't yet know much about this, but it seems like you ensure the sender is in the flushed state only when there are no pending messages. Can there be a race condition where is_flushed() returns true and then in the meantime a message is pushed onto the pending queue?

Modifying the pending queue requires mutable (= exclusive) access to this struct. It isn't possible that one thread pushes something while another thread has a reference to it.

Alright then, looks good to me.


feat: Integrate Footer into global layout for consistent design

📝 Pull Request Title
feat: Integrate Footer into global layout for consistent design
🛠 Issue

Closes #53

📖 Description

Integrated the Footer component into the global layout, ensuring that it appears consistently across all pages, including the Marketplace.
Removed redundant Footer import from the landing page to streamline code and prevent duplication.
Validated that the Footer is displaying as expected on all pages, ensuring consistency in the user interface and functionality.
Resolved visibility inconsistencies with the Footer, improving the overall user experience.

✅ Changes made

Added Footer component to global layout.
Removed Footer import from landing page.
Ensured the Footer displays correctly across all pages.
Fixed Footer visibility inconsistencies.

🖼 Media (screenshots/videos)

None

📜 Additional Notes

I added some padding to the component on mobile view to maintain consistency

If there is any other changes kindly specify.

@davedumto please resolve the conflicts! after that, we are good to merge

@davedumto please resolve the conflicts! after that, we are good to merge

While looking at the logic, I realized the dark mode logic was removed from the Page.tsx. should I merge it like that?

@davedumto please resolve the conflicts! after that, we are good to merge

While looking at the logic, I realized the dark mode logic was removed from the Page.tsx. should I resolve it like that?

Leave it as it is, the dark mode logic is now in header.tsx.

I've seen the conflicts; you can delete those lines.

 @davedumto I've seen the conflicts; you can delete those lines.

Okay I am doing that now

I have resolved the conflicts.


Announce SciPy 1.5.0

Announce SciPy 1.5.0

self-merging small doc change--I think people are busy and this is pretty minor


Created Register page both backend and frontend

User is able to register and data is being saved to data base.

i will review it soon


Issue #1445 - Cleanup on MvcOptions.ApplicationModelConventions.

#1445

/cc: @rynowak @yishaigalatzer

:watch:

Updated.. Please have a look.

:shipit: from me. I also have a suggestion about how to keep the implementation classes private which is worth considering

Modified that and checked in - https://github.com/aspnet/Mvc/commit/d2c3985cd60d01e355c89ed7eb9d2f6922da762a


Error using vid_demo.py

First of all, thanks for your work, it's really useful.
I'm facing an error using the vid_demo.py for video inference using YOLOV\exps\yolov\yolov_s.py and YOLOV\weights\yolov_s.pth. The error I'm getting is ZeroDivisionError: float division by zero when trying to test the inference on a custom video. I provide a screenshot of the error below:

I just followed the instalation steps as referred on the README.md file, using a conda environment. I'm running it on Windows 11.

Please check the --path parameter, it seems opencv doesn't get the video

Thanks for answering so quickly.
It seems that is something going on with the video. Before running vid_demo.py, my target video looks normal:

However, after running the script the video seems corrupt somehow:

After this, the video is no longer readable

The error occured because the video file was corrupted.

发生此错误是因为视频文件已损坏。

嘿，朋友你好，我也出现了类似问题，进行vid_demo测试的时候，传入视频运行vid_demo失败后发现已损坏，请问你是如何解决的呢？谢谢


Update templates

Launcher now ships template versions 2.4.0. The helm charts are now updated accordingly

Thank you @colearendt ! I started to do this like 3 separate times but got lost in the sauce on the template merge each time. If you have a minute, could you write up a summary of the commands you use somewhere to handle the diff?

@jforest do you want to get this landed soon while it is relatively fresh? Was it something you covered with Cole?

@jforest do you want to get this landed soon while it is relatively fresh? Was it something you covered with Cole?

It was something we covered, and added his latest commits while doing so.  It appears there are new conflicts we need to fix first, I'll look at that now

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: colearendt:x: jforestYou have signed the CLA already but the status is still pending? Let us recheck it.


off the side of the screen

Hello,
Is there a way to scroll sideways on the gui, or shrink the view?  After going down a few levels of decisions, they are generated off screen.
Thanks.

I've had the same problem, but you can try making your browser window double its normal width before you run the tool (by moving it mostly off the side of the screen and then dragging the edge to make it wider). If you do that before opening the tool then the whole tree should be displayed when it opens. Then you can shrink the browser window back to normal and everything seems okay. I also have the view zoomed out a little. Works on chrome on a mac anyway.


slirp4netns, test: increase max timeout limit for slirp4netns to start start

Slirp4netns starts in uncertain way in different environment, increasing
timeout to ensure that we reduce flakes as much as possible. Since its
hard to reproduce this flake in different environment.
Last flake seen: https://github.com/containers/aardvark-dns/pull/111

@Luap99 I am unable to reproduce this flake in different envs, slirp startup happens in really uncertain way in different envs. Saw a recent flake here: https://github.com/containers/aardvark-dns/pull/111

I am confident that this will not fix the flake, the timeout is already high enough. There is something else going on here.

@Luap99 Its weird when i try this on local slirp starts without any issues on CI it flakes.

I'm closing this PR will re-open if I fine any better fix, increasing timeout indeed does not fix the flake.

Because CI is super slow compared to anything you run local.
I think I found the problem, I can will open a PR later.

https://github.com/containers/aardvark-dns/pull/113


Modal is visible even when visible is set to false?

Please provide all the information requested. Issues that do not follow this format are likely to stall.
Description
https://snack.expo.io/@adititipnis/surprised-ice-cream
The modal is visible even when visible property is set to false
React Native version:
0.61.4
Steps To Reproduce
https://snack.expo.io/@adititipnis/surprised-ice-cream
Run the app
Expected Results
The modal should not be shown when the value for modalVisible is false
Snack, code example, screenshot, or link to a repository:
https://snack.expo.io/@adititipnis/surprised-ice-cream

I think its happening on run on web browser and not on ios/android emulator

I think its happening on run on web browser and not on ios/android emulator

Yes. This is not happening on my android.


Jobs are not retried considering --tries set on worker when fail with ModelNotFoundException

Laravel Version: 9.37.0
PHP Version: PHP 8.1.11 (cli) (built: Sep 29 2022 22:28:49) (NTS)
Database Driver & Version: myql 8

Description:
When a job fails with ModelNotFoundException, the job is not retried automatically considering --tries option set on worker and is added immediately to failed_jobs table.
You might argue that if a model does no longer exists, there is no point in retrying the job because it will fail for the same reason and I agree with that. But the reasons why a model can not be restored are multiple not only because is deleted.
But there are cases when retrying the job will make the job succeed. ie: a worker on a different server that the one from where it was dispatched, and which is listening to a mysql replica and the new record is not yet propagated.
Steps To Reproduce:

$model = Model::create([]);
$model->delete();
dispatch( new SampleJob($model));
php artisan queue:work --tries=3

I expect that SampleJob to be executed 3 times. Currently is executed only once.

This would seem the expected behavior to me. There's no point in retrying a job if the model cannot be found. You example does not make sense to me.


Create prettier.yml

executes prettier ig
Please describe changes
Adds a manual dispatchable workflow for prettier that pushes any prettier changes. whether this is remotely useful is up for debate
Description

[x] I've added new features. (methods or parameters)
[ ] I've added jsdoc and typings.
[ ] I've fixed bug. (optional you can mention a issue if there is one)
[ ] I've corrected the spelling in README, documentation, etc.
[ ] I've tested my code. (npm run test)
[ ] I've check for issues. (npm run eslint)
[ ] I've fixed my formatting. (npm run prettier)

Whats the point? Would it make more sense to run if prettier check fails and not just every time someone commits?

it runs on manual request


Fix for missing "kerning" sections

For users of AngelCodes' BMFont program this small fix makes it possible to use fonts where there is no kerning section. See the documentation:

This block is only in the file if there are any kerning pairs with amount differing from 0.

Thank you.


Rabo MT940 extended error.

Parsing Rabo MT940 Structured is giving an exeption:
in handle_transaction_data
    ''', data, re.VERBOSE).groupdict()
AttributeError: 'NoneType' object has no attribute 'groupdict'

https://github.com/WoLpH/mt940/blob/master/mt940/parser.py#L100
See this gist for the file : https://gist.github.com/spoetnik/046c2e9dd4242d2603ad

Just a little update here, I'm working on handling this but I'm having a bit of trouble deciphering the rabobank format. Perhaps the jejik-mt940 library will help a bit though...
Thanks for the file, helps a lot with testing :)

Cool thanks. I wish I was so Python-savvy I could help.
Here are the Rabobank specs: https://www.rabobank.nl/images/formaatbeschrijving_swift_bt940s_1_0_nl_rib_29539296.pdf
Have you seen this Ruby parser? https://github.com/railslove/cmxl
Looks like custom MT940 definitions could be handled by overriding a class...
Thanks for looking into this!

This standard is beyond crappy... that is, there are many standards and apparently most of the banks are not complying with the standards.... A lot more painful than I'd hoped but I've made it a bit more versatile.
Now it supports any sta file I could find (thanks to your links I now have 32 files which are supported) but it won't have all details for every file. Let me know if you need more help :)

Thanks! I will test it! So far it's looking good. Update is on pypi already. Sweeeet!!


$tsc problemmatcher fails with long output lines in terminal window

VSCode Version: Code 1.16.1 (27492b6bf3acb0775d82d2f87b25a93490673c6d, 2017-09-14T16:38:23.027Z)
OS Version: Windows_NT x64 6.1.7601
Extensions:

Extension
Author (truncated)
Version

vscode-file-peek
abi
1.0.1

jenkins-status
ale
0.4.0

githistory
don
0.2.3

vscode-generate-getter-setter
DSK
0.4.2

gitlens
eam
5.4.0

tslint
eg2
1.0.9

vscode-npm-script
eg2
0.2.1

vscode-great-icons
emm
2.1.16

status-bar-tasks
Gua
0.2.1

vscode-firefox-debug
hbe
0.16.0

debugger-for-phantomjs
ira
0.1.1

docthis
joe
0.4.8

typelens
kis
1.5.0

debugger-for-chrome
msj
3.3.1

vscode-docker
Pet
0.0.18

java
red
0.10.0

html-less-class-completion
wan
0.0.6

Steps to Reproduce:

Create a dummy task in gruntFile.js to print a long string in the format for some valid typescript error
Configure this dummy grunt task as your build task with problem-matcher $tsc
'Build' your project (thus causing the dummy grunt task to run and use integrated terminal window)
Notice that for long line outputs, integrated terminal splits it into multiple lines (even when actual output is single line)
The $tsc problem matcher treats each line as independent and hence fails to properly report the error in problems tab

Reproduces without extensions: Yes/No Yes

Dups 32042