App config remove revisions

Removes use of revisions endpoint

LGTM. @mrm9084, can you explain more on why to remove the use of revision endpoint?

@saragluna  There are multiple known issues that are caused by this. 1) Revision history only lasts 30 days, 2) Revisions can't tell if a key has been deleted. 3) We only need the latest etag, with the new requirement of a watch key we can just request the key.
This change also brings the Spring implementation closer to the other ones we have.


trufflehog: 3.81.10 -> 3.82.1

Diff: https://github.com/trufflesecurity/trufflehog/compare/refs/tags/v3.81.10...v3.82.1
Changelog: https://github.com/trufflesecurity/trufflehog/releases/tag/v3.82.1
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 341331 run on x86_64-linux 1

1 package built:

trufflehog


examples: fails to build with ffmpeg >= 4.4 due to -Werror

Regressed by https://github.com/ffmpeg/ffmpeg/commit/f7db77bd8785d1715d3e7ed7e69bd1cc991f2d07
examples/dmabuf-capture.c:494:4: error: 'av_init_packet' is deprecated [-Werror,-Wdeprecated-declarations]
                        av_init_packet(&pkt);
                        ^
/usr/include/libavcodec/packet.h:487:1: note: 'av_init_packet' has been explicitly marked deprecated here
attribute_deprecated
^
/usr/include/libavutil/attributes.h:100:49: note: expanded from macro 'attribute_deprecated'
#    define attribute_deprecated __attribute__((deprecated))
                                                ^

https://github.com/swaywm/wlroots/pull/2799


Add dependency to hamcrest-jackson

This PR addresses issue #16 .

Hi @jarst
Thanks for contributing to HttpClientMock.
I've looked at your PR. I agree that adding dependency is not a big improvement.
TBH I rather thought about adding a method like:
withBodyHavingJsonField('foo.bar', equal('some test'))
Before you start implementation please reach me and consult the proposition.


Restore appwrite.json path

I got an error. I realised the error was related to the schematic file path. That's how I fixed it.
Os : Windows
Command : npm run appwrite:restore
Related File : restore.msj
Line : 12
const schema = require(path.join(process.cwd(), "./appwrite.json"));

to
const schema = require(path.join(process.cwd(), "./schema/appwrite.json"));

Why don't you simple copy appwrite.json to the root?

Yes I can do that, but the fetch command places it in this folder
appwrite_fetch.bat
@echo off
if exist .\schema rmdir .\schema /s /q
mkdir .\schema
cd .\schema


support for jupyter notebook widgets

Actually ignore this, for some reason the ipywidgets version doesn't work with p_tqdm. It just sits there at 0%.

I like the change, thank you for suggesting it! (And sorry for not taking a look earlier!)


Implement Functional\key

Problem
Given an array of items, return a map from keys to values, where the key is specified by a callback, and the value is the item from the array.
Dev notes
Ideally we can use a composition of group and map, however error messages from InvalidArgumentException::assertValidArrayKey will leak out internal implementation details
and will not provide an accurate message.

I didn't realize I was ignoring this PR, sorry about that. Wouldn’t map(group(…, …), 'array_pop') already accomplish what you need?

No problem, thank you for looking into it!
Yes, that expression would achieve the same goal, but it think it is a bit more verbose than it needs to be, and does not communicate intent as clearly as having a named function.

Closing


[ci][web] Remove CHANNEL override in drive_examples_command.

Integration Tests with the canvaskit renderer (introduced here) are flaky in Flutter stable (3.22). This is corrected in the next beta release, but in the meantime, examples in stable are being driven with the html renderer to remove the flakiness.
Once 3.22 gets updated to the next version, clean-up the changes introduced to make stable test with html, and master with canvaskit.
Related issues/prs:

https://github.com/flutter/flutter/issues/145149

https://github.com/flutter/packages/pull/7087

breaking because of the html renderer

We still have some tests running on the HTML renderer.


[docs] Improve entry points for issue repros

Ready for review though not mergable. I want to fix/improve the TypeScript playground experience first (since it doesn't support @material-ui/core/Typography yet).
Opening to get feedback about the wording.
Recommended codesandbox for repros is now a dedicated codesandbox template that is owned by the team (need your names for invite).

What're tradeoff (pros/cons) of the template vs polling the CRA example?

Different goals: One showcases example usage, the other is a base for an issue. In one you have a sandbox where you can delete things. You shouldn't delete anything from the template.

It seems that we can use our GitHub slug for invites, does it work with "oliviertassinari"?

Invite sent.

should we expose the ThemeProvider

Not every issue uses the provider. In most issues it would be just noise.


Can't delete user

Why can't I delete users from wagtailadmin area, also if user logged in has delete permission on User model?

Good point. I think this will need some design/UX work, as we need to determine what should happen to existing content owned by the user when after the user is deleted.
WordPress gives you a radio box on the confirmation screen asking if you want to transfer all content to a different user or to erase associated content entirely.

On all models that have a concept of ownership (Page, Image, Document...), we have 'owner' set up as a nullable field (because otherwise you'd have to invent a fake user account when doing automated data imports). Assuming we've got those fields set up properly with on_delete=SET_NULL, then, there should be no problem with keeping the user's content around. (I can't think of any case where you'd actually want the content to be deleted when removing a user.)
I think a standard delete confirmation screen will do the job here. Not sure why we don't have one - just an oversight, I guess.

@gasman No chances to see this feature in Wagtail 1.5?

@Luperi There's plenty of chance to see it in 1.5, assuming someone implements it :-) I can't promise to work on it myself, as there are lots of other high priority items to get through, but that shouldn't stop someone else from working on it.

Oops! Hold on on this one please. I totally missed the existing PR and fixed the issue in quite a different way.
From what I get the existing PR "only" adds the delete button on the edit page. I added it in the listing too.
I will compare my code and the existing PR tomorrow (NZ time) and try to keep the best from it (especially the tests).
Sorry about this :s

Completed in #2523.


[Event Request] codeunit 90 "Purch.-Post"

Please add OnPostPurchLineOnBeforeRoundAmount event in function PostPurchLine
local procedure PostPurchLine(var PurchHeader: Record "Purchase Header"; var PurchLine: Record "Purchase Line"; var TempVATAmountLine: Record "VAT Amount Line" temporary; var TempVATAmountLineRemainder: Record "VAT Amount Line" temporary; var TempDropShptPostBuffer: Record "Drop Shpt. Post. Buffer" temporary; var EverythingInvoiced: Boolean; var ICGenJnlLineNo: Integer)
    var
        PurchRcptLine: Record "Purch. Rcpt. Line";
        PurchInvLine: Record "Purch. Inv. Line";
        SearchPurchInvLine: Record "Purch. Inv. Line";
        PurchCrMemoLine: Record "Purch. Cr. Memo Line";
        SearchPurchCrMemoLine: Record "Purch. Cr. Memo Line";
        CostBaseAmount: Decimal;
        IsHandled: Boolean;
    begin
        IsHandled := false;
        OnBeforePostPurchLine(PurchHeader, PurchLine, IsHandled);
        if IsHandled then
            exit;

        with PurchLine do begin
            if Type = Type::Item then
                CostBaseAmount := "Line Amount";
            UpdateQtyPerUnitOfMeasure(PurchLine);

            TestPurchLine(PurchHeader, PurchLine);
            UpdatePurchLineBeforePost(PurchHeader, PurchLine);

            if "Qty. to Invoice" + "Quantity Invoiced" <> Quantity then
                EverythingInvoiced := false;

            OnPostPurchLineOnAfterSetEverythingInvoiced(PurchLine, EverythingInvoiced, PurchHeader);

            if Quantity <> 0 then begin
                TestField("No.");
                TestField(Type);
                if not ApplicationAreaMgmt.IsSalesTaxEnabled then begin
                    TestField("Gen. Bus. Posting Group");
                    TestField("Gen. Prod. Posting Group");
                end;
                DivideAmount(PurchHeader, PurchLine, 1, "Qty. to Invoice", TempVATAmountLine, TempVATAmountLineRemainder);
            end else
                TestField(Amount, 0);

            CheckItemReservDisruption(PurchLine);
//NEW EVENT
            OnPostPurchLineOnBeforeRoundAmount(PurchHeader, PurchLine, PurchInvHeader, PurchCrMemoHeader, SrcCode);
//NEW EVENT
            RoundAmount(PurchHeader, PurchLine, "Qty. to Invoice");
...

[IntegrationEvent(false, false)]
    local procedure OnPostPurchLineOnBeforeRoundAmount(var PurchaseHeader: Record "Purchase Header"; var PurchLine: Record "Purchase Line"; var PurchInvHeader: Record "Purch. Inv. Header"; var PurchCrMemoHeader: Record "Purch. Cr. Memo Hdr."; SrcCode: Code[10]);
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Invalid example code in the README

At the top of the README there's this example code:
dragMock.drag(dragSource).drop(dropTarget);

This does not work because there's no drag function on the dragMock object.

Ohh, of course. Fixed the demo code.
Thanks for the hint!


testing: improvements for Bakup related tests

enable backup related test for the coverage build
use shorter timeout for admin clients for backup tests
correctly cleanup stale instances by deleting backups first

Fixes #1432 #1429
We may still want to disable backup related tests for the coverage build. If so, we can run the backup related tests in nightly build.

This change is

Once all the test pass, maybe I'll trigger 5 coverage builds almost simultaneously.

The coverage build took 35:43, better than before :)
@coryan Thanks for the review, I'll split the PR, but before doing so, let me run 5 simultaneous coverage builds as an endurance test.

I started 5 coverage-presubmit builds

All the 5 coverage-presubmit builds passed with the latency of 33:21, 35:14, 35:49, 34:52, and 36:11.
Much better :)

FYI, it successfully deleted an instance temporary-instance-2020-03-18-hogehoge with a backup in my project :)

Pro tip: to fix more than one bug you cannot just say Fixes #NNN #MMM you need to say Fixes #NNN and fixes #MMM.


E-Mail Sending Issue

Similar to issue descrbied in https://github.com/YouTransfer/YouTransfer/issues/196
So I setup a YouTransfer instance on our network and uploading as well as downloading works perfectly fine. The problem is when I use the mail sending UI to send the link to recipients. The error I get is;
"An error occurred while sending your message
self signed certificate"
All my configurations are fine, especially my mail configs. I am using the SMTP option and chose "OTHER" so I can input my details correctly. We are not using SSL. There's nothing in the logs (via docker logs) when this happens. I can verify that my credentails are correct as well as my host setting.
Can anyone point me in the right direction or could the devs fix this bug?
BTW - Really awesome FOSS system! I need to get mails working before I roll it out, nothing else can even come close to YouTransfer

Same issue here. Tried everything but cant get smtp mail to work o my own mailservers. Keep getting this self signed certificate message.
Down/upload is fine to https adress via haproxy. Please advice

Gents,
same issue here as well, I have an external SMTP provider working with SSL. Cant get it work:
An error occurred while sending your message
140720076990272:error:140770FC:SSL routines:SSL23_GET_SERVER_HELLO:unknown protocol:../deps/openssl/openssl/ssl/s23_clnt.c:782:

I had exactly the same issue while trying to get it to work with our own infrastructure. Email is sent via a relay which then hands it off. Exim uses a self signed cert and doesn't require authentication.
This was fixed by adding the below at youtransfer.js
        tls: {
                rejectUnauthorized: false
        }

The next issue I faced was that it was trying to authenticate with a username and password, even though none was set. I'm no javascript programmer but managed to fix it by removing the auth block in youtransfer.js I'm sure there's probably a more elegant way of doing this but it's beyond my knowledge.
The changes were made to 1.0.6 which is the latest docker image available and the only one that would work for me.


Using gpio>31 for PWM

We are using RPi CM3 and so, there is possible to use almost all 53 GPIOs.
I would like to use PWM on gpio>31 but it is not supported by gpiod.
There is PI_MAX_USER_GPIO define limiting the number to 32. There are also many XyzBits variables using datatype uint32_t.
If we for example rise the limit, change the data type to uint64_t and fix all constructions like 1<<gpio. Can it work, or are there other limitations/obstacles to solve?
E.g. it will have performace impact, change the protocol format, ...?

It's not a trivial change because the DMA  chain must be extended to allow writes to both GPIO registers.  This was implemented in the very first versions of pigpio but has long been removed as pointless on all but the compute module.
It's not something I will add back in.
If you would like to see the early code let me know and I'll see what I can find.

I'm not sure I have ever suggested that pigpio supports the compute module completely.  The most I remember saying is that pigpio works on all Pi models.
Look at http://abyz.me.uk/rpi/pigpio/index.html and notice the repeated mention of GPIO 0-31.

Well, that link says, amongst other things:
The pigpio library
Features
...

reading/writing all of the GPIO in a bank (0-31, 32-53) as a single operation

...
GPIO
ALL GPIO are identified by their Broadcom number.  See elinux.org
There are 54 GPIO in total, arranged in two banks.
Bank 1 contains GPIO 0-31.  Bank 2 contains GPIO 32-53.
There are several types of board, each with different expansion headers, giving physical access to different GPIO.

Type 1 - Model B (original model)
Type 2 - Model A, B (revision 2)
Type 3 - Model A+, B+, Pi Zero, Pi2B, Pi3B
Compute Module - Compute Module

...
Compute Module
All 54 GPIO may be physically accessed.  Some are reserved for system use - refer to the Compute Module documentation.
For all types of Pi it is safe to read the GPIO. If you try to write a system GPIO or change its mode you can crash the Pi or corrupt the data on the SD card.
I suggest it could be emphasised that pigpio only supports the first GPIO bank which is sufficent for all RPi models except the CM series (a mention for the Compute Module 3 and 3 Lite ought to go into that list though I do not know what hardware numbers they have)
OTOH I appreciate the effort you have put into this project and this is only about part of the library so I am not going to worry about this as it doesn't affect me currently 1 - it is just that handling the corner cases are what marks out an excellent product. 😀
<footnote> 1 - I'm still keeping my eyes open for a cheap CM/CM3 dev kit on a well known on-line auction site as that is the expensive part for the home hobbyist to get their hands on - so if I ever have success I'll be sure to give an update on the hardware numbers...</footnote>

I'm re-opening this issue to remind me to update the documentation.
APIs affecting GPIO 32-53:

gpioRead()
gpioWrite()
gpioRead_Bits_32-53()
gpioWrite_Bits_32_53_Clear()
gpioWrite_Bits_32_53_Set()
setMode()
getMode()
setPullupDown()
setISRfunc()

I'm re-opening this issue to remind me to update the documentation.
APIs affecting GPIO 32-53:

gpioRead()
gpioWrite()
gpioRead_Bits_32-53()
gpioWrite_Bits_32_53_Clear()
gpioWrite_Bits_32_53_Set()
setMode()
getMode()
setPullupDown()
setISRfunc()


feat: throw error if node version out-dated

This might be useful to avoid many silently failing tests if Node version is less than 20. Wdyt?

Not a big fan of preinstall script for this usage, it could create new issue for some projects. I think it's ok to just use "engines". Developer can use tools to verify engines for their package if they want to.

ok, should i remove this hook from fhevm and hardhat-template as well then?

Yes, especially for fhevm because fhevm is a Solidity library and we don't care if people are using node 18 in this case. AFAIK, preinstall is used in both situations: when you do npm install locally in the repository and when you do npm install fhevm.


Adds federated data sources

Add federated data sources. Includes test cases and docs.

No changelog. Adding


Feature Request: Sort tracks on Date Modified

We can sort the tracks according to the title, artist name, album name and duration. Can you add a column for Date Modified too so that recently added tracks appear at the top?

This will take time because I currently don't store file metadata (date modified, date created, etc) that's not specified in the id3 tags. Adding support for this will require changes to the data structures and other helper functions for sorting date, etc.
I have a plan to revamp the column layout system to allow the user to specify the columns they want. I will definitely add date modified column along with that change set. Most possibly in the release after 2.0.

I have pushed out the release with support for the date columns. They are not visible by default, you have to select them in the settings dialog. You'll also need to refresh the library so that the date attributes are read and stored in the db.


export frame from world editor camera to image

640px on the longer side
takes a snapshot of whatever the world editor camera is seeing at the moment.

@gmarinov is this done?

We do this when publishing. Closing


pthread create failed in code compiling DDS and CUDA

Hello
I wrote a code using DDS and CUDA. In this code, I use VortexOpenSplice (6.9.2p1 HDE) and library cudaarithm ( from CUDA 11.8 and openCV 4.6.0; openCV is compiled with cuda 11.8). My platform is Ubuntu 22.04.3 LTS code name jammy; arch 64.
Compilation is ok. But execution of the code terminates at the first instance of any dds object. Here an example in ospl error log :
========================================================================================
Context     : dds:domain::DomainParticipant::DomainParticipant
Date        : 2023-11-22T14:56:21+0100
Node        : safran-Nuvo-8108GC-Series
Process     : CUDA_DDS_exec <1109311>
Thread      : main thread 1533ec82a000
Internals   : DomainParticipantDelegate.cpp/90/6.9.2p1/283dd7d/1ad4fef/-1
----------------------------------------------------------------------------------------
Report      : Error: Failed to create DomainParticipant
Internals   : org::opensplice::domain::DomainParticipantDelegate::DomainParticipantDelegate/DomainParticipantDelegate.cpp/90/1/1700661381.537102916
----------------------------------------------------------------------------------------
Report      : Unable to connect to domain id = 0.
              The most common causes of this error are an incorrect configuration file or
              that OpenSpliceDDS is not running (when using shared memory mode).
Internals   : u_participantNew/u_participant.c/234/773/1700661381.537121441
----------------------------------------------------------------------------------------
Report      : Failed to start Spliced for domain 'ospl_sp_ddsi' within 0 seconds, result = U_RESULT_INTERNAL_ERROR

Internals   : user::u_domain::startSpliceThread/u_domain.c/1251/773/1700661381.537133310
----------------------------------------------------------------------------------------
Report      : Error starting thread for 'spliced'

Internals   : user::u_domain::startSplicedInProcess/u_domain.c/736/773/1700661381.537145367
----------------------------------------------------------------------------------------
Report      : pthread_create failed with error 22 (spliced)
Internals   : os_threadCreate/os_thread.c/543/2/1700661381.537156696

The code works if the cv::cuda method is commented (no need to modify the associated cmake). Domain is well created.
The code is very simple :
#include <dds/dds.hpp>
#include <opencv2/cudaarithm.hpp>

static void wrap_substract(cv::InputArray i_src1, cv::InputArray i_src2, cv::OutputArray o_dst, cv::InputArray i_mask, int i_dtype){
     cv::cuda::subtract(i_src1,i_src2,o_dst,i_mask,i_dtype);
}

int main(int argc, char **argv){
    uint32_t nbDomainParticipant = 0;
    dds::domain::DomainParticipant dParticpant_(nbDomainParticipant);
    return 0;
}

Of course, domaine participant value is correct in regards of the ospl config xml. Commenting  "wrap_substract" is enough to make working the code.
I attached compressed files with the code and the associated cmake:
CUDA_DDS.zip
Unfortunately, it is really complicated to compile this code because that needs a complete CUDA and Open CV setting on the platform. That can take hours or days to install these packages and then to reproduce that issue. But my point is to know if anybody have pieces of idea about the origin of that failure.
I have already tested the following ideas :

if the wrapper of the cv::cuda method is declared inline, the execution is correct.
if the openCV is compilated in a static library, this code works.
But these solutions do not work in a more complicated code (that i can't show). I have to find a sustainable solution for my big project.
The issue looks to be linked to the heap memory, like there is a memory corruption caused by a global variable in cuda library. But I don't know how to reveal that kind of interference, nor if my idea is correct.

Thanks.

hi @cvdcvd , this project is not actively maintained anymore please take a look at it successor  CycloneDDS


plex-desktop: init at 1.96.0

Description of changes
plex-desktop: init at 1.95.3
Based on the spotify derivation which pulls from the snap store. Also borrowed the excellent update script from there as well.
Fixes https://github.com/NixOS/nixpkgs/issues/252131

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Updated TODO for 2024-07-11:

[ ] Downloads
[ ] Investigate Plex & Plex,sh processes hang around after closing the app. Other apps do this so this though, so maybe this isn't specific to Plex.

Original Post
Tested this on 3 different NixOS systems and everything generally works.

Gnome (w/ integrated Intel GPU) - everything works & always launches successfully.
Hyprland (w/ integrated intel GPU) - sometimes fails to launch for an unknown reason. Messing with QT_QPA_PLATFORM=xcb generally works.
Hyprland (w/ Nvidia) - needs nvidia-offload environment variables set (see below). Works flawlessly.

export __NV_PRIME_RENDER_OFFLOAD=1
export __NV_PRIME_RENDER_OFFLOAD_PROVIDER=NVIDIA-G0
export __GLX_VENDOR_LIBRARY_NAME=nvidia
export __VK_LAYER_NV_optimus=NVIDIA_only

The steam derivation provide an extraEnv option which seems like a reasonable solution. In my own configuration, I just override those as needed for this one particular machine. This is probably what I'll do unless someone someone has a better suggestion.
# Override the package passed to programs.steam.package based on the isNvidia flag in my config.
pkgs.steam-small.override
{
  extraEnv =
    if isNvidia
    then {
       __NV_PRIME_RENDER_OFFLOAD = 1;
       __NV_PRIME_RENDER_OFFLOAD_PROVIDER = "NVIDIA-G0";
       __GLX_VENDOR_LIBRARY_NAME = "nvidia";
       __VK_LAYER_NV_optimus = "NVIDIA_only";
    }
    else {};
};

I'd appreciate any feedback on this that would make this launch more reliably.

Add a :+1: reaction to pull requests you find important.

Environment variable overrides now work as follows:
plex-desktop.override{
  extraEnv = {
    __NV_PRIME_RENDER_OFFLOAD = 1;
    __NV_PRIME_RENDER_OFFLOAD_PROVIDER = "NVIDIA-G0";
    __GLX_VENDOR_LIBRARY_NAME = "nvidia"
    __VK_LAYER_NV_optimus = "NVIDIA_only";
  };
 }

I'm a maintainer of plexamp let me know when you need approval

@Redhawk18 Thanks! A couple parts that seem to be broken:

Downloads
Rentals
DRM content

There's a sqlite error on launch which could be related. It's correctly writing to ~/.cache and ~/.local/share/plex and the only database I can see (com.plexapp.plugins.library.db) is writable so I haven't figured out what exactly it needs.
Login, personal server content, live tv, and some of their ad-supported content all works. It's good enough that I'd be fine with merging this as-is and working out the other issues down the road. Let me know what you think.

I'm unsure how to fix these errors, there's not much I can personally do.

No worries. Not expecting you to put any time in just noting what doesn't work. If this is good enough for whoever has merge rights, I'd say let's get it in and I'll keep trying to figure out where the problem lies and issue another PR then.

No worries. Not expecting you to put any time in just noting what doesn't work. If this is good enough for whoever has merge rights, I'd say let's get it in and I'll keep trying to figure out where the problem lies and issue another PR then.

I believe you'll have to post in discord because only nixos team members have perms to merge new packages. Also once it's merge we should remove the much older and outdated version of plex desktop.

While testing 4k/HD content, I found Plex wasn't using my integrated intel GPU. Thanks to NixGL, I was able to narrow down the problem to the version of libglvdn. It needs this library to work properly, but the newest version in unstable isn't compatible with the libraries that ship in the snap distribution. Pinning this to a previous version seems to have done the trick. This also solved the stability issues I was experiencing on system no. 3 so hopefully everything is a little more stable.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4222

@SuperSandro2000 Thank you for taking the time to review this! I appreciate the work you and everyone on the team does to keep nix going.
I've gone through and accepted most of your suggested changes and made some additions based on your comments. Let me know if I can do anything else.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/missing-libwebp-so-5/49488/2

I don't know if this is the correct place to ask this (and please show me where I should go if it is not), but it does not appear that the sign in works? Is this a known issue, or just something on my machine? Is there a configuration option that needs to be added for sign in button to correctly open my web browser perhaps?

I meant to make a note of this in the PR. I think this is an issue for other applications as well and depends on the window manager you use.
I needed this in my configuration.nix for Hyprland at least, not sure if my machine w/ Gnome needed any tweaking at all.
# Plex needs this to login/click on links.
xdg.portal = {
   enable = true;
   extraPortals = [ pkgs.xdg-desktop-portal-gtk ];
   xdgOpenUsePortal = true;
 };

I've been testing the package for nearly a week and have encountered two minor issues. First, CJK characters are not rendering at all. Second, I'm wondering if native Wayland support is possible. I haven't tested the upstream Snap or Flatpak packages to see if they currently support Wayland at all.

I'm unsure about solving the 1st issue. I can take a look, but if you have any suggestions please let me know.
For issue 2, there's a line in the Plex.sh startup script that comes with the snap:
# Disable wayland unless the user has set the value before
export DISABLE_WAYLAND=${DISABLE_WAYLAND:-1}

So, they disable by default which suggests to me that they don't support Wayland natively? I'm unsure how to confirm this definitively though.


Unregister bulyilmaz-example

Please unregister "bulyilmaz-example". I am using a Bitbucket repo and I can't unregister.
Thanks!

it's probably not needed anymore, but I've done it, sorry for the delay


BRAVO-1388 Deprecate total from responses, it doesn't contain any useful information

Increase revision in POM
Incremented


⚠ Bofrost.es has degraded performance

In cc85dc2, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1509 ms

Resolved: Bofrost.es performance has improved in 5f76b71 after 7 minutes.


fix(runtime-core): correct anonymous function name

Sorry for missing this PR - a fix was landed in b2be75bad4ba70da1da6930eb914e51ce2c630b2
Thanks for your contribution regardless.


[FEATURE]Catalog Schema API

Is your feature request related to a problem?
In order to view the catalog's schema components and to enable users to actually load schemas into the core (as index and component templates) an API is required
What solution would you like?
An schema (REST- based ) API to have CRUD operations on the schema entities

get all schemas
get schema by id
create schema

This api is only responsible of reflecting the status of the catalog  repository - meaning if a schema exists in the catalog it doesn’t necessarily states that this schema has all of its components loaded and materialized ( schema physical parts include index_template & component_templste)
For actuality manifestations of the schema into physical elements another API will be presented
The Create schema will be responsible for the
What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.
Do you have any additional context?

I wanted to start some discussion regarding how to create the reflection of a schema in our physical models (index_template ,component_template)

See additional details

here
here


[Feature]: AniList Userlist builder options

Is your feature request related to a problem? Please elaborate.
Similar to how the MAL Builder has an option for user lists, it would be nice to have the same for AniList.
Describe the solution you'd like
Basically the same usage as the mal_userlist but for AniList Instead.
Additional Information
No response

Are the lists public?

I believe so, If I switch to an Incognito browser I can still access my lists

Could you share one here for me to look at

https://anilist.co/user/Frazzer/animelist                  - Has All Animes
https://anilist.co/user/Frazzer/animelist/Watching - Has Just Watching
https://anilist.co/user/Frazzer/animelist/Planning  - Has Planning to Watch
and so on for other user lists.

Also looking at the API docs, It looks like you can get the user's lists through a MediaList query using a userName or userId_in with status_in to mark the list type


update weldx k3d code

update to weldx 0.5.1 implementation

I will add a simplified test case later


[BugFix] Fix datetime to timestamp conversion

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #21216
Problem Summary(Required) ：

Use ZoneOffset.UTC for timestamp conversion.
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

you could test equal expr. this may be not work.


postMessage is missing in typings

postMessage does not exist on WebView instance in<EMAIL_ADDRESS>while it works on<EMAIL_ADDRESS>

Feel free to submit PR for types


cache filter: mock cache in CacheFilterTest

Commit Message: Refactor CacheFilterTest to use a mock cache.
Additional Description: Add a mock cache and associated objects, and restructure the CacheFilter unit test to use them instead of SimpleHttpCache. This focuses the test on specifically exercising the CacheFilter's interface, and lets tests skip the extra requests they were sending to set up the cache for a lookup or verify the results of an insert. It'll also let future tests exercise more fine-grained control over the cache's behavior, e.g. to test flow control.
Risk Level: Low
Testing: bazel test //test/extensions/filters/http/cache/...
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

cc  @toddmgreer @jmarantz @penguingao @mpwarres @capoferro as codeowners

Definitely breakage in this patch, not main;

test/extensions/filters/http/cache/cache_filter_test.cc: In member function ‘std::unique_ptr<Envoy::Extensions::HttpFilters::Cache::MockInsertContext, std::default_delete<Envoy::Extensions::HttpFilters::Cache::MockInsertContext> > Envoy::Extensions::HttpFilters::Cache::{anonymous}::CacheFilterTest::headerOnlyInsertContext() const’:
test/extensions/filters/http/cache/cache_filter_test.cc:188:21: error: redundant move in return statement [-Werror=redundant-move]
  188 |     return std::move(insert_context);
      |            ~~~~~~~~~^~~~~~~~~~~~~~~~
test/extensions/filters/http/cache/cache_filter_test.cc:188:21: note: remove ‘std::move’ call
test/extensions/filters/http/cache/cache_filter_test.cc: In member function ‘std::unique_ptr<Envoy::Extensions::HttpFilters::Cache::MockInsertContext, std::default_delete<Envoy::Extensions::HttpFilters::Cache::MockInsertContext> > Envoy::Extensions::HttpFilters::Cache::{anonymous}::CacheFilterTest::bodyInsertContext(const std::vector<absl::string_view>&) const’:
test/extensions/filters/http/cache/cache_filter_test.cc:214:21: error: redundant move in return statement [-Werror=redundant-move]
  214 |     return std::move(insert_context);
      |            ~~~~~~~~~^~~~~~~~~~~~~~~~
test/extensions/filters/http/cache/cache_filter_test.cc:214:21: note: remove ‘std::move’ call
test/extensions/filters/http/cache/cache_filter_test.cc: In member function ‘std::unique_ptr<Envoy::Extensions::HttpFilters::Cache::MockInsertContext, std::default_delete<Envoy::Extensions::HttpFilters::Cache::MockInsertContext> > Envoy::Extensions::HttpFilters::Cache::{anonymous}::CacheFilterTest::headerOnlyInsertContext() const’:
test/extensions/filters/http/cache/cache_filter_test.cc:188:21: error: redundant move in return statement [-Werror=redundant-move]
  188 |     return std::move(insert_context);
      |            ~~~~~~~~~^~~~~~~~~~~~~~~~
test/extensions/filters/http/cache/cache_filter_test.cc:188:21: note: remove ‘std::move’ call
test/extensions/filters/http/cache/cache_filter_test.cc: In member function ‘std::unique_ptr<Envoy::Extensions::HttpFilters::Cache::MockInsertContext, std::default_delete<Envoy::Extensions::HttpFilters::Cache::MockInsertContext> > Envoy::Extensions::HttpFilters::Cache::{anonymous}::CacheFilterTest::bodyInsertContext(const std::vector<absl::string_view>&) const’:
test/extensions/filters/http/cache/cache_filter_test.cc:214:21: error: redundant move in return statement [-Werror=redundant-move]
  214 |     return std::move(insert_context);
      |            ~~~~~~~~~^~~~~~~~~~~~~~~~
test/extensions/filters/http/cache/cache_filter_test.cc:214:21: note: remove ‘std::move’ call

/wait

Can we have @toddmgreer or @capoferro take a look first and then I'l do a final pass?

/wait

/wait


⚠ Bofrost.de has degraded performance

In 0c11a71, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1251 ms

Resolved: Bofrost.de performance has improved in e48bcdf after 13 minutes.


[W-10463851] Make Donation History component compatible with DE.

Critical Changes
Make Donation History components work in the context of a Community taking into account the currently connected user.
( these changes depend on the permissions discussed in the ticket W-10281560 )
Changes

Check the existence of the contact id when initializing the component.
Add method to return the contact id related to the current user.
enable component targets in the meta to be able to use them in a DE.

This PR also includes the required Permission Set described in W-10281560


Finish implementation of optional attributes

Description
See the linked pull request and issue for context.
Continuation of #1433
Closes #903
Details

When no optional attributes are involved, more optimised code is generated.
Uses Attributes::IndexMap instead of Attributes::Vec when optional attributes are present.

Checklist:

[x] I have run ./ci/run_stable_checks.sh
[x] I have reviewed my own code
[x] I have added tests

Huh, what's going on with the checks...

Maybe with hit peak concurrency?
(Github Actions limits the number of concurrently running actions)

On 31 Aug 2020, at 15:50, Simon<EMAIL_ADDRESS>wrote:
Huh, what's going on with the checks...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/yewstack/yew/pull/1537#issuecomment-683827743, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKFSTPLP2AVF77LYQD2LZUTSDO2BZANCNFSM4QQS4AFA.

@jstarry, do you have some time to review this? I had to make quite a few changes to the original PR.

Sure, I'll take a look tomorrow!

Just one question, why default to using IndexMap when using optional attributes?

@jstarry
If an optional attribute switches from None to Some or vice versa the length of the attributes changes. When diffing attribute vectors that don't share the same length it calls diff_incompatible to compare them which converts both vectors into HashMaps first. This isn't needed when using  IndexMap.
I haven't benchmarked this so I can't say for sure that this is more performant but I'm fairly certain that it is.

If an optional attribute switches from None to Some or vice versa the length of the attributes changes. When diffing attribute vectors that don't share the same length, diff_incompatible is called which converts both vectors into HashMaps first. This isn't needed when using IndexMap.

Good point. What if we option wrapped all of the attribute values to maintain order?
Vec<(&'static str, Option<Cow<'static, str>>)>

That would work, yeah. Should even make it possible to clean up the code significantly.
The only downside I can think of is that this would slightly slow down the non-optional attribute path because of the runtime overhead of Option.

@jstarry Well that was A LOT more painful than I thought but it's done and includes some much needed clean up too.

Since I changed the attribute diffing and the benchmarks, here's what it looks like now:
changed last:
 vec-vec:          0s (R²=0.993, 1233946 iterations in 122 samples)
 map-map:          0s (R²=0.999, 1357342 iterations in 123 samples)
 vec-map:         3ns (R²=0.780, 357422 iterations in 109 samples)
 map-vec:         2ns (R²=0.889, 295388 iterations in 107 samples)
changed middle:
 vec-vec:         1ns (R²=0.898, 1019788 iterations in 120 samples)
 map-map:          0s (R²=0.997, 1357342 iterations in 123 samples)
 vec-map:         2ns (R²=0.984, 575638 iterations in 114 samples)
 map-vec:         2ns (R²=0.999, 432483 iterations in 111 samples)
changed first:
 vec-vec:         1ns (R²=0.999, 1019788 iterations in 120 samples)
 map-map:         1ns (R²=0.998, 1019788 iterations in 120 samples)
 vec-map:         3ns (R²=0.912, 393165 iterations in 110 samples)
 map-vec:         5ns (R²=0.990, 183408 iterations in 102 samples)
reordered:
 vec-vec:         6ns (R²=0.967, 137793 iterations in 99 samples)
 map-map:          0s (R²=0.965, 4259946 iterations in 135 samples)
 vec-map:         2ns (R²=0.969, 432483 iterations in 111 samples)
 map-vec:         3ns (R²=0.971, 324928 iterations in 108 samples)
added to start:
 vec-vec:        10ns (R²=0.981, 94110 iterations in 95 samples)
 map-map:          0s (R²=0.976, 2909596 iterations in 131 samples)
 vec-map:         3ns (R²=0.987, 295388 iterations in 107 samples)
 map-vec:         2ns (R²=0.986, 432483 iterations in 111 samples)
removed from start:
 vec-vec:        10ns (R²=0.977, 113876 iterations in 97 samples)
 map-map:          0s (R²=0.991, 2909596 iterations in 131 samples)
 vec-map:         2ns (R²=0.984, 432483 iterations in 111 samples)
 map-vec:         3ns (R²=0.991, 295388 iterations in 107 samples)
added to end:
 vec-vec:         1ns (R²=0.980, 696525 iterations in 116 samples)
 map-map:         1ns (R²=0.997, 927079 iterations in 119 samples)
 vec-map:         6ns (R²=0.926, 201750 iterations in 103 samples)
 map-vec:         7ns (R²=0.991, 137793 iterations in 99 samples)
removed from end:
 vec-vec:         2ns (R²=0.993, 432483 iterations in 111 samples)
 map-map:         2ns (R²=0.996, 432483 iterations in 111 samples)
 vec-map:         4ns (R²=0.929, 201750 iterations in 103 samples)
 map-vec:         3ns (R²=0.972, 244120 iterations in 105 samples)
equal:
 vec-vec:          0s (R²=0.991, 2645086 iterations in 130 samples)
 map-map:          0s (R²=0.977, 2909596 iterations in 131 samples)
 vec-map:         1ns (R²=0.997, 575638 iterations in 114 samples)
 map-vec:         1ns (R²=0.962, 575638 iterations in 114 samples)

In hindsight it probably would've been better to do the switch to Optional<Cow<'static, str>> in a separate PR but I'm pretty happy with how this turned out otherwise.
Would you like to take another look, @jstarry?

Overall the code is looking really great. I haven't reviewed the Yew code base much, but I was happy to see trybuild being used, it's a lifesaver for sure.
I have a repo using the code over in #1433 (@alexschrod's original PR code). I'll cut the repo over to this branch and will report back if I see any issues.

I was a bit bothered by the outliers in the vec-vec case so I decided to optimize it a bit.
These slow cases happen when the two attribute vectors don't have the keys in the same order. This is true for the "reordered", "added to start", and "removed from start" benchmarks.
Here are the results:
changed last:
 vec-vec:         1ns (R²=0.977, 1357342 iterations in 123 samples)
 map-map:         1ns (R²=0.993, 1642386 iterations in 125 samples)
 vec-map:         4ns (R²=0.876, 523306 iterations in 113 samples)
 map-vec:         2ns (R²=0.999, 842798 iterations in 118 samples)
changed middle:
 vec-vec:         1ns (R²=1.000, 1987290 iterations in 127 samples)
 map-map:         1ns (R²=1.000, 2186020 iterations in 128 samples)
 vec-map:         2ns (R²=1.000, 927079 iterations in 119 samples)
 map-vec:         2ns (R²=1.000, 927079 iterations in 119 samples)
changed first:
 vec-vec:          0s (R²=1.000, 2404623 iterations in 129 samples)
 map-map:          0s (R²=1.000, 2404623 iterations in 129 samples)
 vec-map:         2ns (R²=1.000, 1019788 iterations in 120 samples)
 map-vec:         2ns (R²=1.000, 1019788 iterations in 120 samples)
reordered:
 vec-vec:         2ns (R²=1.000, 927079 iterations in 119 samples)
 map-map:          0s (R²=0.999, 13369557 iterations in 147 samples)
 vec-map:         1ns (R²=0.998, 1493077 iterations in 124 samples)
 map-vec:         1ns (R²=1.000, 1493077 iterations in 124 samples)
added to start:
 vec-vec:         3ns (R²=1.000, 575638 iterations in 114 samples)
 map-map:          0s (R²=1.000, 12154142 iterations in 146 samples)
 vec-map:         1ns (R²=1.000, 1357342 iterations in 123 samples)
 map-vec:         1ns (R²=1.000, 1357342 iterations in 123 samples)
removed from start:
 vec-vec:         3ns (R²=0.999, 696525 iterations in 116 samples)
 map-map:          0s (R²=1.000, 13369557 iterations in 147 samples)
 vec-map:         1ns (R²=0.980, 1493077 iterations in 124 samples)
 map-vec:         2ns (R²=0.971, 927079 iterations in 119 samples)
added to end:
 vec-vec:         1ns (R²=0.997, 1987290 iterations in 127 samples)
 map-map:         1ns (R²=0.997, 1806626 iterations in 126 samples)
 vec-map:         2ns (R²=0.998, 842798 iterations in 118 samples)
 map-vec:         2ns (R²=0.999, 927079 iterations in 119 samples)
removed from end:
 vec-vec:          0s (R²=1.000, 2909596 iterations in 131 samples)
 map-map:          0s (R²=1.000, 2909596 iterations in 131 samples)
 vec-map:         2ns (R²=0.998, 1019788 iterations in 120 samples)
 map-vec:         2ns (R²=0.997, 927079 iterations in 119 samples)
equal:
 vec-vec:          0s (R²=0.999, 5154537 iterations in 137 samples)
 map-map:          0s (R²=0.943, 5669992 iterations in 138 samples)
 vec-map:         1ns (R²=0.999, 1233946 iterations in 122 samples)
 map-vec:         1ns (R²=1.000, 1233946 iterations in 122 samples)

I think this should be good to go now.


Discord.desktop from backup

currently in system-config-backup I have an discord.desktop file, need to add copying of this into the move-configs.sh

I'll migrate to vencord


Update Timless Jewel Emulation & Node Indices

Places my datafile generator on top of the most recent version of https://github.com/majorregal/TimelessEmulator instead of an outdated decompiled version.
Updates the ordering of nodes and notables to be notables (sorted by graph id) then small nodes (sorted by graph id) so that all datafiles can use the same indices.
Optimizes datafile generation a bit (about a 6-fold speedup).
Replaces Data folder with most recently generated data.

I'll propose changes to the readme separately once we have the rest locked down


Qt Creator 4.1.0 Support

4.0 version does not work with Qt Creator 4.1.0.  Qt Creator reports that there were errors, and the plugin will be disabled.

It happens every major/minor update. I'll rebuild plugin soon.

Uploaded.

Many thanks!


HDFS Disaster Recovery

[x] DR Actions
[x] DR scheduler.
[x] Async backup
[x] Integrate with rule.
[x] Diff merge and sync.
[x] Sync backup
[x] Load balance between different sites.

Already done. Issue closed.


Introduce check on chainId during store.addSignedState.

Currently, the first we learn of an incorrect chain id at challenge or conclude time. That’s far too late, as by that point we may have unwittingly locked up funds against the channel on “the wrong chain”, causing the twin problems of

a running but unfunded channel (I might provide goods or services for “payments” that aren’t actually payments)
funds deposited against a channel that hasn’t even been opened (no states and therefore no way to unlock the funds)

This approach is good because it performs the required check very early on. The check is against the wallet's passed-in configuration object. The single chain specified there might be a ganache server during testing, or ethereum mainnet in production. No check is necessary during channel creation, as the chainid is correct by construction in that case.
Downsides of this PR: a new error is thrown without any error-handling logic in place for it. I think this is OK for now.
Alternatives considered:
a) making the check mandatory further down the stack in nitro protocol or wallet core. I actually started off with this but decided that it was unnecessarily restrictive. The docs currently suggest that this is really a responsibility deferred to the wallet.
b) doing the check inside validTransition or elsewhere. I think this wouldn’t make the most sense: the on chain code already enforces that all states in a transition have the same FixedPart (and therefore the same chainId). So there’s no need to check it for every transition.
c) ignoring the states (and maybe log a warning) with a wrong chainid instead of throwing an error. I discarded this idea because it seems like quite a catastrophic error in our current "single chain" world / assumption.
Quirks
We use a number for the chain id in the wallet, but a string in the store. We sometimes use chainId and other times use chainNetworkId.
The other place we should check the chain id is in the chain service. I think it wouldn't be too hard to get into a nasty state where the chain service is pointing at a different chain to the rest of the wallet. Ideally it gets the chain id from the wallet config, and that is considered the source of truth for the chain id.

Checklist:
Code quality

[x] I have written clear commit messages
[x] I have performed a self-review of my own code
[x] This change does not have an unduly wide scope
[x] I have separated logic changes from refactor changes (formatting, renames, etc.)
[x] I have commented my code wherever necessary (can be 0)
[x] I have added tests that prove my fix is effective or that my feature works, if necessary // new case for pushMessage

Project management

[x] I have applied the appropriate labels
[x] I have linked to all relevant issues (can be 0)
[x] I have added all dependent tickets (can be 0)
[x] I have assigned myself to this PR
[x] I have chosen the appropriate pipeline on zenhub for the linked issue

Just to clarify: are you suggesting we read the environment variable from within the wallet code? I am very reluctant to do that since we have this information in the wallet configuration, and that's the right place to declare the configuration for library code (IMO).
I'd be happier to consider changing the test code (only) to read from the environment variables: is that what you have in mind? It could be an easy fix to simply have the default test config point to the environment variable.

Just to clarify: are you suggesting we read the environment variable from within the wallet code? I am very reluctant to do that since we have this information in the wallet configuration, and that's the right place to declare the configuration for library code (IMO).
I'd be happier to consider changing the test code (only) to read from the environment variables: is that what you have in mind? It could be an easy fix to simply have the default test config point to the environment variable.

I think doing it in the defaultTestConfig makes sense. I agree that we don't want this in the actual wallet code, we shouldn't use that for configuration. But in this case, I think we're just using process.env.CHAIN_NETWORK_IDto communicate the chain id betweenchain-setup.ts` and the chain tests.

069d67e

Thanks for the review @lalexgap. I went a bit further here #3328, you might be interested to take a look.


CI for Node

Failed test:
App
✕ Contains the compiled JavaScript
Game
Game
✕ Initializes with two players
✕ Starts the game with a random player
nextPlayer
✕ Sets the current player to be whoever it is not


Model loading, ignore declaration files

When passing a directory to the modelPaths option in the constructor, it would be nice if sequelize-typescript only looked for .js files.
I see two instances where people could run into this:

mocha-typescript requires my main application to be compiled with the "declarations": true option so that it can consume the application's types to (if the test suite and app are two different typescript apps). Unfortunately, this means in my output directory not only will typescript emit js files but also .d.ts. Anyone else using declarations will run into this.

Any source maps map file alongside the models will also junk up the output directory.

This can be easily worked around with a little but of code with fs and some filtering, but maybe this extra nicety could be baked into sequelize-typescript? I'm going to be writing up a PR, since I'll be using the same logic in my own code if this doesn't make it into the repo. Feel free to either close this issue if you don't want it baked in, or assign it to me if you do.
Thanks for reading! <3<3

Hey @snewell92, on which version did you noticed this? I've released a new version(0.3.3) several hours ago, in which I changed this behavior. With 0.3.2 it used .js files only, but now also considers .ts files too. This is because of what is described here: #22
Unfortunately I didn't think about d.ts files. So, yes, this need to be fixed, but loading .ts files need to be further supported.
Probably it would make sense to add an exclude option or support globs instead of a directory in modelPaths. What do you think?

Ah yes I saw that patch earlier and should've connected the dots.
I also upgraded to 0.3.3 earlier today.
Let's discuss this, because ideally we would allow end users total freedom in their project structure. Source maps, definition files, a .js output or .ts to be dynamically transpiled by ts-node - possibly even an index file that is a single source of exporting models.
I like your file glob idea, but I also like the excludes option.
The file glob elegantly takes care of .ts/.js/.map/.d.ts file inclusion, and solves it for future file types that might encroach our TS Sequelize projects. We could even keep current behavior first checking if the string is a directory, I recently wrote some code that figures that out:         fs.lstatSync(path.join(dirPath, file)).isDirectory().
The modelExcludes option seems easy, but I'm not really sure.
I'm a bit confused as to how the directory gets resolved into the files/models. I was looking in the Sequelize.ts code in the v3 and v4 folders, and both declare an addModels function but I can't find that function in the upstream plain sequelize library. Or is this code in the BaseSequelize.ts file around line 67ish? So this code would have to change?
BaseSequelize.ts
addModels(arg: Array<typeof Model|string>): void {

 const models = getModels(arg);

 this.defineModels(models);
 models.forEach(model => model.isInitialized = true);
 this.associateModels(models);
 resolveScopes(models);
 models.forEach(model => this._[model.name] = model);
}

I'd be willing to take a crack at either or both of these methods (supporting file glob / support excludes option) 😸 I actually initially had an index.ts file with my models, and I had to move all my model to their own folder. With the excludes option I wouldn't have to.

OK, let's support both options then :)
The v3/v4 folder structure together with BaseSequelize seems to be a little bit confusing, I know. But it is necessary to support version 3 and version 4 at the same time. Sequelize 4.0.0 provides es6 classes, Sequelize >= 3 the constructor-pattern. Since es6 classes cannot be extended with  constructor-pattern "classes", the models in v4 are transpiled with target "es6" and everything else with "es5". That's why BaseSequelize is not extended by v3/Sequelize.ts and v4/Sequelize.ts directly.
The models get resolved in services/models.ts -> getModels.
We should use glob or minimatch for our glob implementation.
Should the modelPaths option be changed to support globs or should we add new options lik include/exclude? If so, will modelPaths and include/exclude work together or only the one or the other?
I think modelPaths should expect a path as the name of the option says. So from my opinion, we should use an additional option like include. Furthermore I see no problems if modelPath and exclude will used together and include and exclude.

tldr; I like this. I would like the includes option to be an array of globs/directories/paths that gets concatenated with the modelPaths array. Excludes option can be an array of strings that are patterns/file names. The readme/documentation can go unchanged until includes/excludes gets implemented. modelPaths, as far the end user is concerned, can be for directories, includes for glob patterns. The code won't care since it handles both the same. First, I'll add the .d.ts exclusion by default with a PR to close this issue.
v3/v4 does makes sense for supporting both versions, I just didn't know the structure of the project very well, still digging into it, thanks for explaining where getModels is and how this project supports the two version (Which is very nice by the way! Great job on that :+1: ).
As far as how globbing and include/exclude would work together, I think we should keep the same behaviour and implementation - we can add file globbing as an opt in choice. It would be easy to detect if modelPaths is a directory or not, and if so just do what we do now. Otherwise try it as a glob. If that fails throw an error because those are the only two options we support.
As far as how include/exclude + modelPaths will work all together, I like your thoughts about taking care with how these options would interact.
....
After thinking about it a little more, what if the modelPaths is a directory that specifies a main model folder, looks at excludes option to exclude an index file, and also there is one rogue model in another directory, for whatever reason. Or perhaps there are two folders, one for entities, another for associations or 'higher-order' models. So it doesn't make sense to use includes to include a file that is in the directory, as we would have already pulled it in, but if it specifies one rogue file somewhere that makes sense. The second folder we already can pull in because we expect an array of directories.
Thus, I think includes/excludes would work the same way with both options, modelPaths as directory or glob. And we can do the discrimination within the reduce loop so we can mix directories with glob patterns.
Your point about the name of the option (modelPaths should be a path, since that's the name of the option) is a good one though. With my conclusions modelPaths is either a path, or a glob - which is not only a path. What we can do is add the includes option as an array of string that are either paths/globs, and just join the two arrays together and iterate through them. The includes option is a little broader in that I could see people passing specific file names, but I know how to discriminate between directory/file. It would be easier to implement this way, and I see no real reason to enforce that modelPaths are only paths. The readme/documentation can stay the same about modelPaths (accepts a path) and then add a section about the includes and excludes portion.
Example configs
{
 modelPaths: [ path.join(__dirname, 'models') ],
 includes: [ './src/models/associations/*.js' ],
 excludes: [ 'index.js' ]
}

{
 includes: [ './src/models/**/*.js ], // grab all js files
 excludes: [ 'index.js' ] // remove index.js files (app and tests use this to import models)
}

To recap (to demonstrate that I understand, so I don't go off coding the wrong thing):

First
Exclude .d.ts file by default in getModels with the current implementation (probably its own PR, at the very least definitely its own commit) - quick fix for right now.
Second

Add the includes option, just concatenate this array to modelPaths in BaseSequelize.init. Need some code to check that both exist (default to empty arrays).
Implement discerning whether modelPaths is a directory. If so, do what we do now.
If not a directory, assume a glob, use glob.
After grabbing initial slew of files, apply the excludes/include option to filter or add in other files. Then we can require them result in.

How about I get a PR to close this issues about .d.ts file right now, since now I see how those files are filtered, and then I open a separate linked issue about adding includes/excludes, and I'll open a separate PR where I start working on the aforementioned second task.
Let me know if you disagree with the concatenation of modelPaths and includes array. I think this is a good compromise, docs can keep the semantics of modelPaths while the code becomes easier to wrangle.

Hey @snewell92, thanks for your input.
Regarding include/exclude options: I'm a little bit confused now :O You wrote

Your point about the name of the option (modelPaths should be a path, since that's the name of the option) is a good one though. With my conclusions modelPaths is either a path, or a glob - which is not only a path.

But later on

Implement discerning whether modelPaths is a directory. If so, do what we do now.
If not a directory, assume a glob, use glob.

So you meant to support globs in modelPaths, right? Hm, I'm not sure about it. Why should one use modelPaths and include together? Either could work on its own or did I overseen something?
Regarding your example includes: [ './src/models/associations/*.js' ],: Setting a glob in include without a leading __dirname is probably not enough. So either the glob need to be joined with __dirname or another option, in which a "root" is defined, is necessary. But this would always look like:
{root: __dirname}

Do you know what I mean? But probably there is a lack of understanding on my side.

Yeah I changed my mind a little bit and was thinking/typing. This is what I've come to:
I still think we should keep the current behavior so people's code doesn't break, so modelsPaths should still be able to be a directory. Now,should it only be a directory? Or can it be a glob too?
If we allow modelPaths to be an arbitrary mix of directories/globs, implementing includes will be simpler, since we can concat both arrays, and in the reduce loop in getModels we have extra code before the directory read (fs.readDirSync I think) where we look at the string we have and test if it is a directory, file, or glob.
If you think it is simpler, we could make the getModels option only a directory, and the includes only files / glob.

I'm thinking about what you said...

Either could work on its own or did I overseen something?

maybe you're right. Unless we want to be strict, we could simply not use the includes option, and just use modelPaths.

@leogoesger Since globs are supported now, you could do it like so: /**/!(index).ts


REST API Documentation or Swagger ?

Hi ,
There is any documentation for API ? I am .NET programmer and I would like communicate with REST API from .NET Core app. But I cannot find any documentation.

At the moment I recommend to use SOAP API, more completed.
Here you can find some documentation, https://kb.cloud.it/api.aspx, even if I am sorry to say is not up to date. I recommend to use version 2.9, in the documentation the wsdl url is related to release 2.8. The described methods exist also in the 2.9 release.

Hello,
I am a professional technical writer and would like to document your REST API. Please let me know if you would like me to assist.
-Ryan

Hi, I'm also a technical writer and would really like to contribute if you still need it?

At the moment I recommend to use SOAP API, more completed.
Here you can find some documentation, https://kb.cloud.it/api.aspx, even if I am sorry to say is not up to date.

not up to date to the point of being nearly useless.

I recommend to use version 2.9, in the documentation the wsdl url is related to release 2.8. The described methods exist also in the 2.9 release.

one can also find my Java or Python code useful.

Hi there, I'm new to GitHub. While I've done aspects of technical writing in previous job roles, I'm now looking to get into technical writing professionally, which is why I'm trying to find open source RESTful API projects to help contribute documentation towards. I was wondering if you might have any issues that you may still need some help with?


Problems with aqt on Windows

First thanks so much for your work! It might save my C++ course this semester for which I have to install Qt Creator in our computer lab.
I ran, however, into some issues on Win 10:

pip install aqtinstall installed version 1.1.4 on Windows (Linux worked fine and installed v 2.0.0). Is there a way to install v 2.0.0 with pip on Windows?
I tried to use the aqt.exe from the repo's release page, but Windows complaint about malicious behaviour and also on virustotal.com finds four security vendors who flag the file as malicious: https://www.virustotal.com/gui/file/b91c8c3aeac8fb22d5127012dee8793d5e40c15da77880448f309ab33d2f09ca/detection
Any idea why this might be?

Best,
Sebastian

I am a little out of my depth here, so perhaps someone can correct me if I'm wrong:

aqtinstall uses py7zr to extract .7z archive files. There is a command line option to use an alternate extractor utility, like 7zip, but there is no option to install aqtinstall without also installing py7zr.
py7zr has a dependency called bcj-cffi, which includes helper utilities written in C. Note the "cffi", or "C Foreign Function Interface" in the name. In order to install this dependency, it needs to compile those utilities with a C compiler. I am not sure why pip is looking for MSVC 14 in your case. I suspect that if pip was able to find a working compiler, it would not have this problem.
It looks like pip is attempting to install older versions of aqt, in an attempt to find one that has a set of dependencies that it can satisfy. I speculate version 1.1.4 requires an older version of py7zr that doesn't use the C foreign function interface, and that's why it chose that particular version.

I can think of a couple of potential ways to fix this:

Just install Visual Studio. If you're developing native software on Windows, it's very likely that you'll need to install this at some point anyway. I expect that you can just install the most recent version. You might need to run pip install aqtinstall from the Visual Studio command line prompt; it will show up in the Start Menu folder for Visual Studio. Fair warning: this will consume a lot of hard disk space, in addition to the Qt installation.
Try using pip install aqtinstall from within MSys2. MSys is a popular command line environment for Windows that works a lot like Linux. It uses pacman for package management, and it makes it really easy to install modern versions of GCC and mingw. I expect that pip would be able to find a C compiler very easily in this environment. Fair warning: this will also consume a lot of hard disk space.
Use aqt.exe instead. aqt.exe is specifically intended for use in situations like yours, where dependency management is really difficult. Both of the previous options will consume a lot of hard disk space; this one should not.

py7zr has a dependency called bcj-cffi, which includes helper utilities written in C. Note the "cffi", or "C Foreign Function Interface" in the name. In order to install this dependency, it needs to compile those utilities with a C compiler. I am not sure why pip is looking for MSVC 14 in your case. I suspect that if pip was able to find a working compiler, it would not have this problem.

Now just started a new project PyBCJ that provide a native CPython extension, as same manner as PyPPMd and PyZSTD does, that are helper libraries py7zr depends.
PyPPMd provide native extension library DLL binary for Windows, and also for Linux, macOS, M1 mac and ARM linux.
It will solve your problem, requirements for MSVC,  in future.

@pzhlkj6612
It's a fairly fresh install on a Windows 10 VM, I use Python 3.10.0 (tags/v3.10.0:b494f59, Oct  4 2021, 19:00:18) [MSC v.1929 64 bit (AMD64)] and pip 21.2.4 from C:\Users\bacchus\AppData\Local\Programs\Python\Python310\lib\site-packages\pip (python 3.10)
@ddalcino
Thanks for that great summary of all options, that helps a lot. I think I'll give aqt.exe another try.
Thank you all for your help! I guess this issue is solved for me and I'll close this :-)

Dependencies of aqtinstall may not provide binary extensions for 3.10, at least projects I maintained. Could you downgrade python to 3.9.x, then behavior may be changed.

Oh, haha. I tested with Python 3.9.7 and pip 21.2.3 (installed by the installer downloaded from python.org) and everything works fine. aqtinstall 2.0.0 has been installed.

Oh, haha. I tested with Python 3.9.7 and pip 21.2.3 (installed by the installer downloaded from python.org) and everything works fine. aqtinstall 2.0.0 has been installed.

Yes, same here! With 3.9.7 everything installs fine!


feature(ClerkAuthSSR): Enable and provide example of using SSR with Clerk

By passing pageProps through to ClerkProvider, all the functions in app/utils/clerk will have an initial context set and will resolve immediately during server side render.
I've also provided an example in nextjs/pages/home of a getServerSideProps that includes the necessary context in pageProps. The result is that the Sign Out button doesn't pop in when loading the Home page.
I've implemented this in my own project and figured some others wouldn't mind the help getting it set up.
LMK if there is a better or standard way to do this ofc.

Oh whoa, this is really cool!


Error in delete functions with data in table generalization

Hi guys!
I think I have found a bug in the delete functions. I am using 3DCityDB v. 4.3
In short: if the FK are written in the GENERALISATION table, the delete scripts forget to delete them, therefore the process fails.
I add a small dataset to reproduce the error.
Load it (EPSG: 28992) and run either of :
SELECT citydb.del_cityobject(id) FROM citydb.cityobject WHERE gmlid = 'NL.IMBAG.Pand.1742100000007906';
SELECT citydb.del_building(id) FROM citydb.cityobject WHERE gmlid = 'NL.IMBAG.Pand.1742100000007906';
Attached a small test file.
3dbag_v210908_fd2cee53_482.zip

Thanks @gioagu good catch. We've fixed this issue here ff266bc87e5056a03ad407db69c191326890b413 for the upcoming release 4.4.


please add support spatie version 4

please add support spatie version 4
i cannot get it work now

There is spatie/permission V5 already

Hi @reanyouda , @PaolaRuby
sorry for really late response! I refactored the package here and I have plan to add great features as well.
weprodev/larapanel-framework
Best,
Michael


highlight broken when using a baseurl

Hi, I'm an octopress noob so I apologies if I'm missing something but I'm trying to get the solarized highlight working with a baseurl without success. The demo works fine but once I try to set a baseurl the highlight doesn't work anymore because of the broken css url.
Although I defined a baseurl the css is still included without that base url.
<link href='/stylesheets/all-7c164891a277a5dda97ada0a56742417.css' media='all' rel='stylesheet' type='text/css'>

My steps:

Clone the solarized repo

# git clone https://github.com/octopress/solarized.git

Go to the demo folder and edit _config.yml to add a baseurl

baseurl: '/test'

Start jekyll (jekyll serve) and open http://localhost:4000/test/

Good catch! Thanks I'll look into it.

You should be able to bundle update and your urls will be expanded with the baseurl. Let me know if there's any trouble.

It's fixed. Thanks you for your quick response!

Woo hoo! Thanks for helping me find the bug!


use substring() instead of deprecated substr()

substr() is deprecated, so for better cross platform compatibility, we'll convert these to substring().

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substring#the_difference_between_substring_and_substr

Much apreesh!


date time to US Eastern Time

Question
Hi, I get my data from eodhd API service and the time received is in UTC time as most of the API data service. when I convert the date time to  US Eastern Time to match the stock market time in the chart it doesn't work. I tried everything changing datetime column, created separate date column with EST , I even changed epoch to be in EST time nothing work, the chart insist to show it in UTC time. I am not sure what I am missing here.  Thanks
Code example
No response

Hey @ahmedacoding,
Could you provide a csv copy of the data you are using before and after conversion.
Louis

Sure, attached a csv's files, "1hour_intraday_raw.csv" sample of the raw data coming from the API.
"1hour_intraday_dataframe.csv"  Sample after converting it to data frame using Panda.
"1hour_intraday_dataframe_EST.csv" and here is a file after changing the time zone to Eastern time EST .
in the picture attached you can see APPL chart start on 13:30 even though "1hour_intraday_dataframe_EST.csv" file have it start on 9:30 am
Also, in a side note in a different issue "Tick" data attached is "websocket_realtime.csv" output file for WebSocket Realtime data which if I try to apply the "Tick" data example on it after converting it to data frame it doesn't chart at all.   Thanks for taking the time to reply and checking them.
1hour_intraday_dataframe.csv
1hour_intraday_dataframe_EST.csv
1hour_intraday_raw.csv
websocket_realtime.csv
Thanks

forgot to attach the pictures ...

I found the issue and fixed it in the csv file.  the 'date' column had extra digits after the seconds I guess it's for time off set after EST conversion. I removed them and the chart worked.
However the issue with plotting "Tick" data (file attached) from WebSocket Realtime is the one I couldn't fix so far.
websocket_realtime.csv
Thanks

I found the issue and fixed it in the csv file. the 'date' column had extra digits after the seconds I guess it's for time off set after EST conversion. I removed them and the chart worked.
However the issue with plotting "Tick" data (file attached) from WebSocket Realtime is the one I couldn't fix so far.
websocket_realtime.csv
Thanks

Typically this issue occurs when the tick data has timestamps that are chronologically before the last data point.
Louis


ARROW-8021: [Python] Install test requirements including pandas in Appveyor

Many unit tests are currently being skipped in Appveyor (presumably these changes will carry over when we migrate these builds to GitHub Actions).

I think you have to install those packages from conda if you don't want to get ABI mismatches.

Roger, I'll switch to conda for these

+1. Appveyor build: https://ci.appveyor.com/project/wesm/arrow/builds/31358181


Restructure logging

Changes include restructuring of logging to make
the logger object accessible so we can validate
log messages in the tests.
Also hide the stacktrace being shown to the
user on the terminal when an error occurs but
stacktrace is available in the log file.

Couple of minor tweaks spotted with suggested fixes.
Also one suggested change with regard to simplifying a complex except statement.

Updated with all the suggested changes in the latest commit.


Runelite on Mac Whitebox that closes when trying to open

Just closed my previous Runelite client and tried opening it to be welcomed by a white loader bar that shuts out immediately, currently on Mac High Sierra, I've tried redownloading and using the all platform client if anyone can help please it would be appreciated.

Pictures would be helpful

Capture your application.log and launcher.log and upload to gist.github.com or pastebin.
RuneLiteBOT - Today at 5:30 PM
To find logs, either open screenshot directory (by right-clicking "Camera" button) and navigate 1 directory up and then open logs folder, or navigate to %userprofile%\.runelite\logs on Windows or $HOME/.runelite/logs on Linux and macOS.```

Alternatively, try clear your runelite folder -

1) Launch a terminal
2) `rm -rf ~/.runelite`

This issue was discussed on discord, and was determined to be 403's when connecting to maven due to cloudflare blocked IP - and can be closed.


Add HashiCorp Helm Repository

The Artifact Hub is another place you can list your repos. To do that, you login (or create an account), create an organization, and list your repository. You can link it to a user or organization.

Thanks!


Support CORS [JIRA: RCS-177]

Add support for CORS
S3 CORS docs.
W3C CORS doc

i just encountered the same problem ,how to solve it?

CORS is on the roadmap of Riak CS but not implemented yet and not determined when.

whether could i use the aws s3 interface  named 'putBucketCors ' to add a cors configuration to support
it ?

Riak CS does NOT implement the S3 API. I'm afraid you could not.

http://docs.basho.com/riakcs/latest/references/apis/storage/s3/
this chapter describes that riak cs support some of s3 api,
including PUT Object interface ,
but when i use it ,it just encountered the cors problme

hello shino ,do you know some other ways to solve this problem?
i have used the putobject interface  riakcs supported,
and the the putbucket interface riakcs not supported.
which do not work any more .

I still don't understand exact problem. Lacking in CORS support may not interfere correct PUT Object call, but we need more information about WHAT and HOW you are failing in detail, to know whether we can solve your problem or not.

Hi, Mr kuenishi
I and xiaoliuliu2050 work in a same development group, currently we encounter a problem about how to put and get files in browser environment to the riak-cs system, our riak cs is version 1.5.4.
The following is our questions:

If lacking in CORS support in current riak-cs, can we make operation put and get files in browser environment to the riak-cs system (we adopt Amazon S3 javascript REST API in aws-sdk-2.1.4.min.js)
Based on question 1, if we can, then how to or what API we can use?

Thank you in advance.

If you've done some experiment, maybe a set of HTTP request and response that your browser JavaScript are making might help diagnose the problem. If that browser doesn't work, I'll recommend making APIs in your HTTP server that handles puts and gets from browser and forwards those request to Riak CS. I'd recommend (riak-users mailing list)[http://lists.basho.com/mailman/listinfo/riak-users_lists.basho.com] for a discussion like this.

+1 for CORS support. A modern day "cloud storage" solution should support modern day "cloud applications".  For our traditional iOS apps, the regular interfaces work great and thank you for that. However, as we venture into Single Page Apps for mobile and browser, the need for CORS support is critical for our business (which relies heavily on Riak and Riak-CS).
A barebones implementation should not be that difficult. I have added CORS "support", albeit rudimentary, myself to webmachine based app for one  of our services within a few minutes. Need to support CORS pre-flight (HTTP OPTIONS method) without authentication which return, at the bare minimum, these three headers

"Access-Control-Allow-Headers"
"Access-Control-Allow-Methods"
"Access-Control-Allow-Origin"

One could specify each option through riak-cs.config or do what Amazon S3 does and allow the admins to provide a blurb.  Another critical header for the subsequent  request following the pre-flight, whether it be GET or PUT, is to return the "Access-Control-Allow-Origin" header.

Shawn, thank you for reminding us - I wasn't aware that CORS was critical for SPA. The implementation shouldn't be hard, just adding and API handler, a field in bucket metadata, adding  a handler in Stanchion.
For sure CORS is in our backlog of adding more S3 API support, but for now Bucket Lifecycle and Bucket Versioning are in higher priority for API coverage. And to tell the truth, items like operation improvement, metrics, garbage collection, replication are in higher priority than them. I hope you could be patient, or could contact Basho business side... sorry.

SPAs involved with angular.js typically will force the CORS path when content type is something other than text plain. And with the latest frameworks, CORS always tends to pre-flight with no option of disabling it. To be honest, I don't get their story either but if you search online, folks are setting up proxy services that understand CORS on the receiving side and then communicate with services that do not support CORS. As one can imagine, not the most efficient nor cost beneficial approach when dealing with potentially large media files.
I have pinged @mjbrender and working with him to see what can be done. Hoping to get a dialogue going with some folks at Basho to see what the right way to do this would be  (thx for your info above btw) and perhaps pushing a patch here in the near future with a good likelihood of getting merged.

Put together a very high level design doc to make sure the path I am taking makes sense for Basho. Feedback, comments welcome. I will wait to hear from you before jumping in the code. Cheers.
URL: http://shawndebnath.com/docs/riak_cs_cors.txt

/unsubscribed/

Thanks, @sdebnath . I'll take a look.

Wishing for CORS… milestone 2.3.0 :cold_sweat:

@sdebnath  I've read through the design doc. Thank you for your contribution! Overall it looks good, capturing webmachine correctly.  Let me have some questions / comments.

DELETE /?cors resource is also needed.
For bucket policies, resource permissions like s3:PutCORSConfiguration should be added to header to handle with bucket policies.
Original S3 seems to evaluate CORS accessiblity before object existence and regardless of any subresources. Regarding this, for perfect compatibility, I think we have to touch WM resources related buckets and objects. If so, it would be better to add options/2 handler in riak_cs_wm_common, but it's not aware and other APIs will be affected.
I'm not sure I get the point of open questions No.2; if AllowedOrigin is set as wildcard, then the response from Original S3 looks including the wildcard Access-Control-Allow-Origin: *. I haven't read through the w3c spec, but is this illegal behaviour?

We know that S3 has several weird behaviors, and we have been not spending much time on imitating such behaviors and just be choosing simpler implementation for minor use cases. Our My design decision usually depends on whether a lot of clients and libraries are depending on such behaviour. Others may have different view, though.
I also would like to mention CORS rules data should be updated via Stanchion and it would require a log of hastle, but it's possible by repeating my effort in bucket policies.

Thanks for the feedback @kuenishi. Going to try to inline comments here:

DELETE /?cors: makes sense, added to doc
s3:PutCORSConfiguration header: okay, makes sense. If I have questions, I will ping you.
options/2 in riak_cs_wm_common: yep, that was the approach I was planning on taking. riak_cs_wm_common has the shared entry points, which then calls to appropriate resources. I was planning on filtering processing of options and restrict it to bucket/object resources. And yes you are correct, regardless of sub-resource, the options will be evaluated on the bucket and then proceed to regular acl and other checks where sub-resource existence is checked today.
Re Allow-Origin header: Per specs, the server can return  "Origin request header, "", or "null"). What I proposed is not illegal behavior as we would be passing the back origin request header sent by client instead of the riak setting of ''.  I believe we should be good.
Regarding keeping it simple and not matching S3: agreed. This feature is simple enough that we can follow the actual guidelines set forth in the CORS spec. It might break S3 compatibility but actually meets the major browser requirements out there today.
Regarding updates via stanchion, yep that's the plan as documented in the design doc.

Tidying up some loose ends at work, will jump on this soon.
Thanks!

Cool. One thing I forgot to note: s3:PutCORSConfiguration is required until release, but not mandatory for first work. You can focus on CORS without it.

How can I see what the current status of this is? I'd really like to be able to use riak-cs, but the lack of CORS is a blocker for us.

I am currently working on this on my spare time, this effort is not part of Basho. Unfortunately, there were some higher priority work that took precedence at my startup and this was put on hold, though we are planning on restarting the work soon.
The work to receive and store the CORS settings is complete. Need to ensure it is working correctly, then on to implementing support for checks against the rules.
Having said that, we are currently quite satisfied by putting a media proxy in front of RiakCS/S2 for web requests to CS. Works quite well for majority of the scenarios.

:+1:

:+1:

:+1:


Enable keyboard interruption

If user needs to exit after long processing time. Currently, it is not handled properly, and terminal should be terminated:
julien-macbook:~/data/juntendo/mice_mri/template $ sct_maths -i tmp.template_mask-csf.nii.gz -dilate 15 -o tmp.template_mask-csf_dilate15.nii.gz

--
Spinal Cord Toolbox (master/2b78f815bf1c7c66be65b2c7368d385fe50751f0)
Running /Users/julien/code/sct/scripts/sct_maths.py -i tmp.template_mask-csf.nii.gz -dilate 15 -o tmp.template_mask-csf_dilate15.nii.gz
^C^C^C^C^C^C

^C^C^C^C^C^C^C^C^C

^C

I have tried 2 approach to try to solve this, but without results
1- Using a signal
def signal_handler(signal, frame):
  print('Exit')
  sys.exit()

Then I put these before call the main function
import signal
    # to capture the Ctrl+C signal
    signal.signal(signal.SIGINT, signal_handler)

2- Use try , except
try:
       main()
   except KeyboardInterrupt:
       print('Exit')
       sys.exit()

In both cases Ctrl + C only take effect once the dilation operation is finished.
I followed the source code of the morphological operation from scikit-image to scipy.
The function skimage.morphology.dilation calls a function in scipy written in C++ that performs the dilation(here)
when calling the aforementioned function python gives control of execution to the C ++ application, for this reason Ctrl + Z does not work
@peristeri @zougloub could you give me some idea

@fperdigon if there is no "easy" solution i would just close this issue since this is an isolated case.

The fix for that isn't worth it, you'll need to wrap the extension code to execute in another process or thread depending if the extension is holding the GIL or not. I would close this as @jcohenadad said.


Saying "type" instead of "type alias" could use a better clue

This morning, I declared a useless type when I meant type alias.  Details, including code and the compiler output, in this gist.
Does it even make sense to say
type Action = SomeOtherComponent.Action
? I don't think so. I wish it would say, "Yo, that doesn't make sense. Did you mean 'type alias' ? " instead of "conflicting types ..." later on.
Consulted with Richard, he said this surprises him, so I don't feel bad for being hugely frustrated and stymied by it.

This is really surprising to me as well. I'm sort of surprised this even passes the parser. Thanks for reporting this!

In explaining Elm to others (and to myself for that matter) having both types and type aliases in the language is confusing. I can imagine being loathe to change the syntax at this point, but it would be easier to explain to people if one instead used type Foo = for what are now type aliases and something like type Foo = union A | B | C for what are currently types. There may well be other downsides besides the costs of a syntax change but I would take this error message report as actually a report about an error that it's too easy to make when using the language.

Okay, this does not pass the new parser. Instead you get this error message:

It now says you are in a union type, but I guess more could be done to distinguish further. It may make sense to add links that explain the syntax, but that can be done separately.


adding-normalize.css issue #889

this PR resolves issue https://github.com/finos/a11y-theme-builder/issues/868
Adding normalize.css
inorder to have consistency across browsers

No I wanted to check preview in safari rest I will have to go through again

I'm not able to detect any MAJOR changes as applied. Can you confirm it once again?

Yes, It's difficult to debug without having safari I am going through the material code itself if I can find something. Thanks for helping, meanwhile if you can  check it locally btw if there are any changes u can see in primary color drop-down?


Change style of generated code to conform to TiGL coding style

I just changed some minor things in the code gen, which include:

Style of the initializer list
Avoid indentation of outer TiGL namespace
Avoid indentation of #ifdef etc...

This style is described in the TiGL wiki and can also be forced with clang-format or astyle:
https://github.com/DLR-SC/tigl/wiki/TiGL-Programmers-Guide#tigl-mandatory-c-style-guidelines

seeing your changes I'm thinking I should rename IndentingStreamWrapper::raw() to something like IndentingStreamWrapper::unindented(). Maybe I'll do a refactoring later.