Add Spectrum as an Adobe Pass provider

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[x] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Some services no longer allow for the older services (ex. Charter_Direct) to be used and just return a generic 401 response.
Going through their login flow manually, the new provider name appears to be Spectrum. This provider seems to work even place of services that still allow for Charter_Direct to be used.

I patched 2020.12.14 with this, but it does not work:
[debug] System config: []
[debug] User config: ['--write-thumbnail', '--add-metadata', '--cookies', '~/.youtube-dl.cookies', '--download-archive', '~/.youtube-dl.archive', '--ap-mso', 'Spectrum', '--ap-username', 'PRIVATE', '--ap-password', 'PRIVATE', '--verbose', '--write-info-json']
[debug] Custom config: []
[debug] Command-line args: ['https://play.mylifetime.com/movies/dear-christmas/full-movie']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2020.12.14
[debug] Python version 3.9.1 (CPython) - macOS-10.15.7-x86_64-i386-64bit
[debug] exe versions: ffmpeg git-2020-11-22-9208b72, ffprobe git-2020-11-22-9208b72, rtmpdump 2.4
[debug] Proxy map: {}
[aenetworks] movies/dear-christmas/full-movie: Downloading JSON metadata
[aenetworks]<PHONE_NUMBER>968: Downloading JSON metadata
[aenetworks]<PHONE_NUMBER>968: Downloading Provider Redirect Page
[aenetworks]<PHONE_NUMBER>968: Downloading Provider Login Page
ERROR: Unable to extract post url; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/youtube_dl/YoutubeDL.py", line 803, in wrapper
    return func(self, *args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/youtube_dl/YoutubeDL.py", line 824, in __extract_info
    ie_result = ie.extract(url)
  File "/usr/local/lib/python3.9/site-packages/youtube_dl/extractor/common.py", line 532, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/lib/python3.9/site-packages/youtube_dl/extractor/aenetworks.py", line 158, in _real_extract
    auth = self._extract_mvpd_auth(
  File "/usr/local/lib/python3.9/site-packages/youtube_dl/extractor/adobepass.py", line 1509, in _extract_mvpd_auth
    provider_refresh_redirect_url = extract_redirect_url(
  File "/usr/local/lib/python3.9/site-packages/youtube_dl/extractor/adobepass.py", line 1370, in post_form
    post_url = self._html_search_regex(r'<form[^>]+action=(["\'])(?P<url>.+?)\1', form_page, 'post url', group='url')
  File "/usr/local/lib/python3.9/site-packages/youtube_dl/extractor/common.py", line 1019, in _html_search_regex
    res = self._search_regex(pattern, string, name, default, fatal, flags, group)
  File "/usr/local/lib/python3.9/site-packages/youtube_dl/extractor/common.py", line 1010, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
youtube_dl.utils.RegexNotFoundError: Unable to extract post url; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

I threw in a breakpoint to investigate.  provider_login_page_res at adobepass.py:1514 is basically just javascript, no form in the HTML:
'<!DOCTYPE html>\n    <meta charset="UTF-8">\n    <meta name="viewport" content="width=device-width, initial-scale=1.0">\n    <meta http-equiv="X-UA-Compatible" content="ie=edge">\n    <title>TV Everywhere</title>\n    <meta http-equiv="Cache-Control" content="max-age=0, no-cache, no-store, must-revalidate">\n    <meta http-equiv="Pragma" content="no-cache">\n    <meta http-equiv="Expires" content="0">\n    \n\n    \n\n      \n    \n\n

\n\n\n'

I redacted RelayState and SAMLRequest assuming they contained authentication tokens or something.
I can't tell what, if anything, in this pile of JS contains the URL adobepass is looking for.

Hmm yeah looks like Spectrum updated their login page recently. I'll dig into it.

Reworked the change to get things working again. Unfortunately the new login form is a bit special as it's all dynamically loaded via JS so we need to manually recreate the flow in code.

Awesome, nbc and aenetworks are both working for me now.  This fixes both #22714 and #27328

@dstftw Do you need me to send a provider account?

@dstftw Do you need me to send a provider account?

Yes.

Yes.

Unfortunately my Spectrum account is in a weird state and is not allowing me to change my password. Can someone else (@gxam maybe?) share a login with @dstftw?

Unfortunately my Spectrum account is in a weird state and is not allowing me to change my password. Can someone else (@gxam maybe?) share a login with @dstftw?

If a dev needs a spectrum account login, please let me know and I'll provide one post-haste!

Bumping this.. If a developer could finish this update for the SPECTRUM MSO I'd be super grateful!
I have credentials that I will send immediately to whomever is a developer willing to take this on.

@dstftw @kevinoconnor7 any willingness to work on this?  I can provide MSO login

@ohmybahgosh All the work is done. From my perspective this PR is ready to merge. @dstftw just needs a Spectrum login to test it with. You can probably send it to them via the email on their github profile.
Unfortunately my Spectrum account is still in a bad state and I cannot easily change the password on it.

./youtube-dl/youtube-dl https://www.nbc.com/making-it/video/random-crafts-of-kindness/4386591 --verbose
[debug] System config: []
[debug] User config: [u'--ap-mso', u'Spectrum', u'--ap-username', u'PRIVATE', u'--ap-password', u'PRIVATE', u'--convert-subtitles=srt', u'--add-metadata', u'--write-all-thumbnails', u'--embed-thumbnail', u'--embed-subs']
[debug] Custom config: []
[debug] Command-line args: [u'https://www.nbc.com/making-it/video/random-crafts-of-kindness/4386591', u'--verbose']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2021.03.14
[debug] Python version 2.7.18 (CPython) - Linux-5.10.0-kali9-amd64-x86_64-with-debian-kali-rolling
[debug] exe versions: ffmpeg 4.3.2-0, ffprobe 4.3.2-0, phantomjs 1.9.7, rtmpdump 2.4
[debug] Proxy map: {}
[NBC] 4386591: Downloading JSON metadata
[NBC] 4386591: Downloading Provider Redirect Page
[NBC] 4386591: Downloading Provider Login Page
[NBC] 4386591: Downloading SAML Response
ERROR: Unable to download JSON metadata: HTTP Error 404:  (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "./youtube-dl/youtube-dl/youtube_dl/extractor/common.py", line 634, in _request_webpage
    return self._downloader.urlopen(url_or_request)
  File "./youtube-dl/youtube-dl/youtube_dl/YoutubeDL.py", line 2279, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/usr/lib/python2.7/urllib2.py", line 435, in open
    response = meth(req, response)
  File "/usr/lib/python2.7/urllib2.py", line 548, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python2.7/urllib2.py", line 473, in error
    return self._call_chain(*args)
  File "/usr/lib/python2.7/urllib2.py", line 407, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 556, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)

oops! There was a case-sensitivity issue in the entitlement URL that I fixed on my local branch but never pushed. Should be fixed now!

That fixed it!!

Are the devs reviewing this PR?  Spectrum is one of the most popular TV providers in the U.S., this is a great addition! I have tested by using yt-dlp and it has worked so far, fixing unable to extract post url on NBC.

Are the devs reviewing this PR? Spectrum is one of the most popular TV providers in the U.S., this is a great addition! I have tested by using yt-dlp and it has worked so far, fixing unable to extract post url on NBC.

I hope they are...
I issued a PR for this fix over on YT-DLP and it was tested/merged already.  Has been working great!


Improve formatting of | after def and new line after |

This PR is to improve the formatting | after method definition, and new line after line only with |.
The position of | inserted after method definition.
class Foo
  class Bar
    def foo: () -> Test# ⤵ Newline here
         |             # This is the current vertical bar position.
           |           # This is the expected vertical bar position.
  end
end

The text indent after | line.
class Foo
  class Bar
    def foo: () -> Test
           |# ⤵ Newline here
  ⬅ Here is the cursor goes currently.
    ⬅ Here is the expected cursor position.
  end
end

It breaks when we have multiple | lines.
def foo: () -> String
       | (Integer) -> void
       | # new line here
              ⬅# Cursor goes (around) here...

I will try to fix this soon.

Trying to change everything...

Stop inserting | after def
Indent for : and = with def and type
Indent with class, module, and interface
Outdent with end


Fix cross-deleted-pr-branches on delete repositories

Test URLs
https://github.com/jquery/jquery/pull/769
https://github.com/yakov116/TestR/pull/7
Screenshot

FYI: GitHub used to display 'unknown repository' they no longer do that

More test URLs from  https://github.com/sindresorhus/refined-github/issues/1985

deleted branch: https://github.com/sindresorhus/refined-github/pull/576
deleted branch (from fork): https://github.com/sindresorhus/refined-github/pull/872
restored branch (on fork): https://github.com/sindresorhus/refined-github/pull/909

This feature really looks good after https://github.com/sindresorhus/refined-github/pull/4152
@fregante 🚀 ?


LICENSE file needed

Please add a LICENSE file. Thanks!

Added CC-BY 4.0 LICENSE file with commit 068ea6d


postgres-flex documentation lacks information about supported roles

The documentation currently does not indicate which roles are supported:
roles (Set of String)
Please document which are supported. Please also ensure that the role create_db will be supported.
So as a User I am able to create custom schemas.

Hi @roberth1988,
Thank for the request, we have created a story and will work on it soon.

Hi @roberth1988,
We have added documentation for the field and released this as part of v0.24.0.


Remove support for openshift labels

This was replaced by tekton results
CLOUDBLD-9046
Signed-off-by: mkosiarc<EMAIL_ADDRESS>Maintainers will complete the following section

[x] Commit messages are descriptive enough
[x] Code coverage from testing does not decrease and new code is covered
n/a JSON/YAML configuration changes are updated in the relevant schema
n/a Changes to metadata also update the documentation for the metadata
n/a Pull request has a link to an osbs-docs PR for user documentation updates

Coverage decreased but only due to removed code (no new missed lines)


P4 commands in output even when git selected as SCM provider.

Since the last version even when I have git selected as my SCM provider I am getting p4 output in my console.
It is pretty noisy. See the attached screenshot. I have had to disable the p4 plugin in the workspaces that use git.

We are aware of the issue. A fix is already in. A new version of the extension should be publish soon.

Great thanks!

Less intrusive errors in version 2.0.1, please update.

@stef-levesque unfortunatly this doesn't seem fixed.
Just updated, reset vscode and upon opening.
p4 print -q "/Users/wyles/src/llvm-opt-view/src/OptStreamTransformer.js"
p4 login -s
ERROR:
Error: Command failed: p4 print -q "/Users/wyles/src/llvm-opt-view/src/OptStreamTransformer.js"
Path '/Users/wyles/src/llvm-opt-view/src/OptStreamTransformer.js' is not under client's root '/Users/wyles/perforce'.


Create an AngularJS Client

Create a client in Angular JS (Angular 1), for example, and use!

Can be converted from:
https://github.com/torch2424/aaronTheDevBlog-SayonaraJS


Metric contexts: adapt the database schema

At the very least, a new column with JSON type needs to be added to the metrics and latest_metrics tables. Ideally we would normalize the metrics IDs by having a new metrics table that maps a key and context to an id, and then reference those IDs in metric_values and latest_metric_values (new table names) instead of the key.

I'm not sure I understand the normalized approach here. Is this because every metric for a run will have identical context, so we want to reduce storage?

Not just storage but also lookup times. Imagine you have 1000 runs that log 100 metrics of 10000 steps each. The metric contexts will be duplicated 10,000,000 times and any lookup will need to examine all of these. We inherited our schema from the MLFlow one, and it really doesn't scale further without more normalisation.
I would like us to not build more tech debt with this new feature. The rest of the normalisation (params and tags) can happen later.


Toggle Whitespace Visibility (editor.renderWhitespace command)

I like to be able to quickly toggle whitespace visibility (editing a JSON file is not ideal), but it doesn't seem like there is a command associated with the editor.renderWhitespace setting, so I'm not able to create a keyboard shortcut.
See also: https://visualstudio.uservoice.com/forums/293070-visual-studio-code/suggestions/7894491-toggle-whitespace-visibility

This is now available.


Adding Wazuh to community project list

Hi team, sending the required data to add Wazuh to the community project list.
Description
Include Wazuh data and logo to the community project list.
Issues Resolved
No issue required.
By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

This LGTM

@snaow would you be okay with using the same square logo used in the partner page for this PR too?

Yes! No problem with that.
PR updated.
Thanks again @elfisher

Thanks @snaow!


Hyperlink DOIs against preferred resolver

Hello :-)
The DOI foundation recommends this new, secure resolver. Accordingly, this PR updates all DOI links.
Cheers!

@katrinleinweber thanks!

You're welcome, and thanks for merging :-)


Provide JSON output for list commands

Having JSON output makes it much easier to parse/script things; the current output that's especially hard to parse is the output of the fn list calls command.

Looking at this, it might be useful if this is enabled on other resources as well (apps, routes, ...)

some of these already provide JSON objects, take a look at fn inspect

True, but I was thinking more in this way:
$ fn list apps --output json
[
    {
        "name": "app1"
    },
    {
        "name": "app2"
    }
]

Or listing the calls:
$ fn list calls app1 --json
[
    {
        "id": "01CMBC2R72R2M0250ZJ0000003",
        "appId": "01CM8P0Y60R2M023RZJ0000001",
        "route": "/testapp",
        "createdAt": "2018-08-07T16:38:16.674-07:00",
        "startedAt": "2018-08-07T16:38:16.674-07:00",
        "completedAt": "2018-08-07T16:38:16.686-07:00",
        "status": "success"
    },
    {
        "id": "01CMBC2R72R2M0250ZJ0000003",
        "appId": "01CM8P0Y60R2M023RZJ0000001",
        "route": "/testapp",
        "createdAt": "2018-08-07T16:38:16.674-07:00",
        "startedAt": "2018-08-07T16:38:16.674-07:00",
        "completedAt": "2018-08-07T16:38:16.686-07:00",
        "status": "success"
    }
]

This could make any automation scenarios much easier - for example you could pipe the output of an Fn command to a different binary (jq to parse, or something else). The way we output stuff today (calls in particular) is not parsable at all.

+1 I thought I'd filed this enhancement request!  We definitely need optional JSON output for scripting support.

This was merged yesterday - #382

Thanks @peterj !


XML syntax error on line 16: invalid character entity & (no semicolon)

v1.40 gives me this error when opening Tailscale.
QTS 5.1 on a TS-264

How did you fix this? @RJDavison
I am getting XML syntax error on line 22: element <link> closed by </head> on a blank white page at URI /cgi-bin/qpkg/Tailscale/index.cgi when accessing Tailscale 1.40 on a TS-230

Are you logging into the nas through something like cloudflared tunnels? I
was and found that if I ran tailscale from the same network as the NAS then
it all worked.
On Tue, 16 May 2023, 22:52 Matthew Albert, @.***> wrote:

How did you fix this? @RJDavison https://github.com/RJDavison
I am getting XML syntax error on line 22: element  closed by
on a blank white page at URI /cgi-bin/qpkg/Tailscale/index.cgi when
accessing Tailscale 1.40 on a TS-230
—
Reply to this email directly, view it on GitHub
https://github.com/tailscale/tailscale-qpkg/issues/97#issuecomment-1550273147,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMVNQ23WN5MDWTW35FIJLDXGPLHXANCNFSM6AAAAAAYBDVD7A
.
You are receiving this because you were mentioned.Message ID:
@.***>


Wrong includes directory in php_fpm.conf after vagrant install

I have installed php-fpm via chef in vagrant using just "add_recipe 'php-fpm'". The basic install seems to work but the system fails when starting up the service. The error given is:
Starting php-fpm: [06-Dec-2013 07:40:51] ERROR: Unable to globalize '/etc/php-fpm.d/pools/*.conf' (ret=2) from /etc/php-fpm.conf at line 11.
[06-Dec-2013 07:40:51] ERROR: failed to load configuration file '/etc/php-fpm.conf'
[06-Dec-2013 07:40:51] ERROR: FPM initialization failed

I saw that the path of the include directive in php-fpm.conf is wrong, it is currently pointing to /etc/php-fpm.d/pools/*.conf but there is no pools directory inside /etc/php-fpm.d/. Changing the include path in the conf file to remote "/pools" allows the service to be started.

mabye selinux, execute "setenforce 0" and try again

Not sure if this is relevant for you guys, but I've run into this error a lot and there's no good info anywhere else, so here's a better tip than "setenforce 0" if you're on Ubuntu:
sudo aa-complain /usr/local/bin/php-fpm
/usr/local/bin/php-fpm


Web - Chat - Context menu does not open on right click if another one already open

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Expected Result:
Right clicking on a chat message should open the context menu (i.e. right click menu). Right clicking on a second chat message (without closing the context menu on the first chat) should open the custom context menu.
Actual Result:
Right clicking on a chat message opens the context menu (intended result). Right clicking on a second chat message (without closing the context menu on the first chat) does not open any contact menu. Instead, browser default context menu shows (web), or nothing happens (desktop app).
Action Performed:
On web browser:

Open expensify.cash in a web browser and log in
Click on a chat in the left hand menu to show the messages
Right click on a message, the context menu appears (intended result)
Right click on a different message: browser default context menu is shown

On web app

Open the expensify.cash desktop app and  log in
Click on a chat in the left hand menu to show the messages
Right click on a message, the context menu appears (intended result)
Right click on a different message: nothing happens, context menu remains open on the first message you clicked in Step

Workaround:
N/A
Platform:
Where is this issue occurring?
Web ✔
iOS
Android
Desktop App ✔
Mobile Web
Version Number: 1.0.50-0
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/118547738-7fc29c00-b727-11eb-9482-a3a63947df69.mp4
View all open jobs on Upwork

Triggered auto assignment to @sakluger (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Updated description for clarify - sending through to Engineering triage.

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

This is a good external issue.

Triggered auto assignment to @stephanieelliott (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Job on Upwork: https://www.upwork.com/jobs/~01fd7ca34f15a030af

Triggered auto assignment to @beamanator (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Ready for proposals :)

Not sure if this is a bug or just a mismatch in expectations of functionality.
On mobile, long press on any PressableWithSecondaryInteraction component (that your ReportActionItems are wrapped in for that interaction) will open up the context menu and the PopoverWithMeasuredContent (which traced all the way down seems to be a react-native-modal)   React Native modals take priority over everything else from a z-index / context stacking point of view so trying to right click anywhere while the context menu (and popover modal) is open will either do nothing on desktop or just open the default browser context menu on chrome.   You could say you have the same "bug" on mobile as well because performing a long press on anything once the popover modal with the context menu options is open doesn't work either (even though you can see the message that you're trying to long press underneath the slightly transparent modal overlay / backdrop).   Just maybe less of a deal because the user can infer that they have to close out of the current modal + menu context first before trying to long press another chat message, because they can see the backdrop the modal creates (that is hidden for the popover modal in desktop / web resolutions).
Menus as static popovers are nice if you are expecting to have more interactive elements inside.  What's maybe confusing here is that you are using this pattern on desktop/web but for right-click context menus, which are usually implemented differently, where the desired behavior is when right-clicking outside of the context menu area, the previous context menu should close (on keydown of right click somewhere else) and a new context menu should open (on keyup of right click) based on where the mouse is.   This is a little tricky to implement here.  Thinking out loud -  an easy hack could be to close the context menu + popover on mouse away from the context menu area.    I honestly can't think of a good way to implement the desired behavior on right click keydown outside of a hack like that especially with how the PressableWithSecondaryInteraction component and the react native modal works.   Alternatively, you could just be branch off the functionality here for desktop/web and implement the context menu without using the popover for desktop/web.    Would have to dig a little deeper.

Issue reproducible today during KI retests

Hmm good point @0x5e5e - the modal only looks like it's tiny, but its surrounding div is full screen (on web / desktop).
@Expensify/design got another question for y'all :D Currently on web / desktop, it looks like users should be able to right-click once (to see the copy / edit / mark unread menu), then right-click again somewhere else (before closing the menu) in order to immediately close the currently open menu & open a new one wherever you just clicked.
This functionality isn't possible at the moment (since the menu is technically full-screen, even though it looks tiny). I think our options are:

Slightly dim the screen when the right-click menu is open

This mimics how the menu + page works on mobile
With this change, users will more easily understand the menu is full-screen, they have to close the currently open menu before opening a new right-click menu

Do nothing, close this issue

Maybe it's ok like it is, since users can already see that if they open a right-click menu, they can't click on a LHN chat to go to it immediately, their first click closes the menu, so a second click is required to go to a new chat

Try one of the options @0x5e5e mentioned above to enable this functionality (automatically closing & reopening right-click menu if user right-clicks outside of a currently opened menu)

One option here is a workaround: if a user opens a right-click menu, then moves their mouse away from the menu, the menu closes automatically
Other... No easy solution available yet

@Beamanator I think we can reduce the full screen context menu equal to its width. I will have a look over it and see whether it can be done?

@Beamanator Thanks for the context and background there. Another avenue that we might try taking is to see if we can remove the full-screen back-drop entirely. Then when the right-click menu opens, add a click listener to the entire document and anytime something is clicked on that IS NOT the current right-click menu, the menu will be closed. This will allow whatever was clicked on to continue working from the original click too.

I'm not sure if people were waiting on me to respond 😅 but I think these are all great options, I think it makes sense to move forward with proposals for fixing this issue (which is really kinda implementing a new feature). Either by shrinking the size of the context menu background, or trying to eliminate it and just keep the popup.

Issue reproducible today during KI retests

Issue reproducible today during KI retests

Since this is more like a new feature (and not a bug as originally thought), I think we should we update the issue body to be more our desired outcome.  Sounds like the options are:

reduce the full screen context menu equal to its width, or
remove the full-screen back-drop entirely. Then when the right-click menu opens, add a click listener to the entire document and anytime something is clicked on that IS NOT the current right-click menu, the menu will be closed.

What is our preference between these options? Tagging in @Expensify/design for visibility

I do believe in either scenario, if a user right clicks outside of the currently open menu we'd want the currently open menu to be closed. So I think the only difference between the two options would be:

reduce the full screen context menu background to the size of the menu
eliminate the full screen context menu background

Personally I think it would be better to go with option 2 if possible - the less elements on the screen the better :D

So I looked at it. react-native-modal does provide us an option to render the menu inline but It has one issue, the Menu is overridden by other views. Apart from it, if we lose the backdrop, still the modal is rendered over a fixed fullscreen view which is the issue we are discussing at the moment.
I have another idea here. Lets see if that works.

I've updated the issue body and title to more accurately describe what we are after cc: @Beamanator. I've also 2x the rate on Upwork and posted to #expensify-open-source 👍
@parasharrajat if you have a proposal for fixing this, can you please leave it here in a comment?

So I finally got the chance to look over this issue. As I said earlier, this is possible to remove the full-screen modal . So after a lot of tweaks I have come up with something, hope you will like it @Beamanator. It little complex to explain everything but I will try my best.
Proposal

react-native-modal has two props which will help us eventually. coverScreen & hasBackdrop . We will be setting them off to make this work.
For consistency, we will create a new Modal type CONTEXT_MENU. This will set the above-mentioned props to false and inherit all the styling logic of Popover in getModalStyles.
Now we create one wrapper Component ContextMenuPopover  which creates a portal for the Popover on web 7 desktop.
Like

const ContextMenuPopover = props => createPortal(
    <Popover
        type={CONST.MODAL.MODAL_TYPE.CONTEXT_MENU}
        closeOnOutsideClick
        // eslint-disable-next-line react/jsx-props-no-spreading
        {...props}
    />,
    document.body,
);

type={CONST.MODAL.MODAL_TYPE.CONTEXT_MENU} will only overwrite the type of modal when we are bigger screens.
for this, we modify the underlying Popover 's type prop as
        type={props.isSmallScreenWidth ? CONST.MODAL.MODAL_TYPE.BOTTOM_DOCKED : props.type}

and pass the Default value for type as type: CONST.MODAL.MODAL_TYPE.POPOVER
for native it will just wrap Popover and nothing else.

As you can see it takes one prop closeOnOutsideClick. We define this prop on BaseModal.
closeOnOutsideClick will listen for mousedown on the web & desktop and then close the modal if the user clicks outside the modal area.

    componentDidMount() {
        document.addEventListener('mousedown', this.closeOnOutsideClick);
    }

    componentWillUnmount() {
...
    }

    closeOnOutsideClick(event) {
        if (this.baseModalRef && !this.baseModalRef.contains(event.target) && this.props.closeOnOutsideClick) {
            this.props.onClose();
        }
    }

We replace the Popover used inside the PopoverWithMeasuredContent which is used as a context menu for the Report Message with ContextMenuPopover.

Video coming shortly...

@Beamanator What do you think?

I have tested out my proposal and it seems to be working as expected. @Beamanator Please let me know whether the proposal looks good or not? PR is one click away.
Thanks.

@parasharrajat that looks great! I'm excited to see the code in action too :D Please apply on upwork & submit the PR when you have a chance!

Issue reproducible today during KI retests

@stephanieelliott please pay and close out this contract ASAP

All paid up!


Refactorizationalism

@mrjones-plip Comments left inline to let you know what I was thinking. I haven't run this script at all, so it may not even be valid, but you'll get an idea anyway...
The main thing you should see is much less nesting, and a couple of extra functions, so each is just doing one piece and then handing the result off to the next.
Neither of our versions handle big dbs very well and we'd need to add some sort of pagination step to do a small batch of users at a time.


Sir, can you write one for me 🙃; like this for  my app but without termux-usb

          Sir, can you write one for me 🙃; [like this](https://github.com/nohajc/vendor-adb-patched/blob/840f0b1e77f3aa5619cb3246cb269ebd3b21fe57/libtermuxadb/src/lib.rs) for  [my app](https://play.google.com/store/apps/details?id=com.rv882.adbify) but without ```termux-usb```

Originally posted by @RohitVerma882 in https://github.com/nohajc/termux-adb/issues/1#issuecomment-1608764282

Hi. Sorry, I'm not planning to extend my tool beyond the termux ecosystem nor contribute to any other projects implementing similar functionality right now.
That being said, if you find out what termux-usb does internally (it just calls some Android SDK functions), it should be perfectly possible to use it in your app. Obviously you don't need the shell script wrapper.


Add documentation about updating .ci.yaml and flutter-gold.

Closes https://github.com/flutter/flutter/issues/143863.
/cc @christopherfujino

I am going to merge for now, but I am very open to making additional changes.

We don't review PRs after landing. This didn't seem time sensitive to me, but I guess it couldn't wait. 🤷


Shell: auto-complete

It would be amazing for dagger shell to support auto-complete based on available builtins and API schema... Complete game changer for discovery.

Maybe this is one that can be parallelized @helderco ?

Yeah, I agree. I was going to take this on next, but if anyone has the bandwidth we can try to parallelize.


Bug/master/11860 lang environment var

Change the behavior of "exec" resources so that they no longer override the LANG (and other locale-related) environment variable during execution.  Also add a (pending) acceptance test to verify this functionality.

New commit should address all of the issues that were raised.


CPU Port

How can I port these models to a CPU only code ? I have 128 GB Mac M1 Ultra Studio system which has 21 Tflops throughput, which render the use of block fftconv moot.
Is it possible to create a CPU only model ? How should one start working on it ?

This is on our roadmap - there's some dependencies that we need to work through for the SSM support (just kernel generation, not even the block FFTConv yet).
Thank you for posting the issue! It's helpful to get a sense of the platforms that people want to run on.

Thanks Dan. After the changes in your roadmap, can we benchmark the huggingface weights on CPU then ?

We’ll be sure that it works!
On Wed, Jan 25, 2023 at 1:34 AM Omkar Patil @.***>
wrote:

Thanks Dan. After the changes in your roadmap, can we benchmark the
huggingface weights on CPU then ?
—
Reply to this email directly, view it on GitHub
https://github.com/HazyResearch/H3/issues/7#issuecomment-1403327736, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABDDIIUN6LKV3QS2SQPW5UTWUDXRNANCNFSM6AAAAAAUGBRICE
.
You are receiving this because you commented.Message ID:
@.***>

Hey Dan, do you have any timelines in mind for this ?


Fix osl_range_check not found error with USE_LLVM_BITCODE=OFF.

This broke in master in a9c21bdf, there's a runtime error for many OSL shaders when building with USE_LLVM_BITCODE=OFF.

LGTM

This is only an issue in master and does not need any backport, right?

Yes, it's only an issue in master.


[CAMEL-15341] Create camel-azure-storage-datalake to serve Azure DataLakes Gen2

New component that handles operations for azure datalake storage using  the Azure SDK for java.
At present, It supports operations related to files and filesystems in datalake.

Is there any update on this? As we are closing down for 3.7 release so this needs to be done soon, otherwise it will miss the release

I think this is for 3.8 .. we are cutting the release already

Is there any update on this? As we are closing down for 3.7 release so this needs to be done soon, otherwise it will miss the release

I'll need some time for adding proper unit and integration tests.

Can you please rebase and solve conflicts? Thanks

Can you please rebase and solve conflicts? Thanks

Sure.

I would like to have feedback from @omarsmak too. By the way the branch is a bit a mess and it cannot be rebased. Can you please amend the situation?

hey @aryankoul, any progress on this PR?

hey @aryankoul, any progress on this PR?

hey @aryankoul, any progress on this PR?

Hi @omarsmak , i have pushed new changes. please review the same.

hey @aryankoul, any progress on this PR?

Hi @omarsmak , i have pushed new changes. please review the same.

LGTM! Thank you @aryankoul !
Once this is merged, the next step to create the Spring boot starter in camel-spring-boot and if you have time, would be great if you can add an example demonstrate the component in the camel-examples repo, you can re-use this example for datalake component.
Let's see if others have any other comments cc @davsclaus @oscerd
P/S: there are some conflicts, can you please resolve them? thanks

Thanks @omarsmak!
Sure, i'll look into the camel-examples repo.

LGTM! Thank you @aryankoul !
Once this is merged, the next step to create the Spring boot starter in camel-spring-boot and if you have time, would be great if you can add an example demonstrate the component in the camel-examples repo, you can re-use this example for datalake component.
Let's see if others have any other comments cc @davsclaus @oscerd
P/S: there are some conflicts, can you please resolve them? thanks

Thanks @omarsmak!
Sure, i'll look into the camel-examples repo.

@aryankoul can you rebase please?

@aryankoul can you rebase please?

Can we merge this PR?

Can we merge this PR?

It cannot be rebased. But I'll try to merge it today or tomorrow

It cannot be rebased. But I'll try to merge it today or tomorrow

It cannot be rebased. But I'll try to merge it today or tomorrow

Thanks a lot!

It cannot be rebased. But I'll try to merge it today or tomorrow

Thanks a lot!

Merged but tests are failing
[ERROR] Errors:
[ERROR] org.apache.camel.component.azure.storage.datalake.integration.DataLakeConsumerTest.null
[ERROR]   Run 1: DataLakeConsumerTest>BaseIT.initProperties:80 » NullPointer 'accountName' cann...
[ERROR]   Run 2: DataLakeConsumerTest>BaseIT.initProperties:80 » NullPointer 'accountName' cann...
[ERROR]   Run 3: DataLakeConsumerTest>BaseIT.initProperties:80 » NullPointer 'accountName' cann...
[INFO]
[ERROR] org.apache.camel.component.azure.storage.datalake.integration.DataLakeFileOperationTest.null
[ERROR]   Run 1: DataLakeFileOperationTest>BaseIT.initProperties:80 » NullPointer 'accountName'...
[ERROR]   Run 2: DataLakeFileOperationTest>BaseIT.initProperties:80 » NullPointer 'accountName'...
[ERROR]   Run 3: DataLakeFileOperationTest>BaseIT.initProperties:80 » NullPointer 'accountName'...
[INFO]
[ERROR] org.apache.camel.component.azure.storage.datalake.integration.DataLakeFileSystemOperationTest.null
[ERROR]   Run 1: DataLakeFileSystemOperationTest>BaseIT.initProperties:80 » NullPointer 'accoun...
[ERROR]   Run 2: DataLakeFileSystemOperationTest>BaseIT.initProperties:80 » NullPointer 'accoun...
[ERROR]   Run 3: DataLakeFileSystemOperationTest>BaseIT.initProperties:80 » NullPointer 'accoun...

Merged but tests are failing
[ERROR] Errors:
[ERROR] org.apache.camel.component.azure.storage.datalake.integration.DataLakeConsumerTest.null
[ERROR]   Run 1: DataLakeConsumerTest>BaseIT.initProperties:80 » NullPointer 'accountName' cann...
[ERROR]   Run 2: DataLakeConsumerTest>BaseIT.initProperties:80 » NullPointer 'accountName' cann...
[ERROR]   Run 3: DataLakeConsumerTest>BaseIT.initProperties:80 » NullPointer 'accountName' cann...
[INFO]
[ERROR] org.apache.camel.component.azure.storage.datalake.integration.DataLakeFileOperationTest.null
[ERROR]   Run 1: DataLakeFileOperationTest>BaseIT.initProperties:80 » NullPointer 'accountName'...
[ERROR]   Run 2: DataLakeFileOperationTest>BaseIT.initProperties:80 » NullPointer 'accountName'...
[ERROR]   Run 3: DataLakeFileOperationTest>BaseIT.initProperties:80 » NullPointer 'accountName'...
[INFO]
[ERROR] org.apache.camel.component.azure.storage.datalake.integration.DataLakeFileSystemOperationTest.null
[ERROR]   Run 1: DataLakeFileSystemOperationTest>BaseIT.initProperties:80 » NullPointer 'accoun...
[ERROR]   Run 2: DataLakeFileSystemOperationTest>BaseIT.initProperties:80 » NullPointer 'accoun...
[ERROR]   Run 3: DataLakeFileSystemOperationTest>BaseIT.initProperties:80 » NullPointer 'accoun...

For the moment it is in a local branch on my machine, correctly rebased. Please fix the tests.

For the moment it is in a local branch on my machine, correctly rebased. Please fix the tests.

For the moment it is in a local branch on my machine, correctly rebased. Please fix the tests.

@oscerd i have fixed the tests, please check now.

For the moment it is in a local branch on my machine, correctly rebased. Please fix the tests.

@oscerd i have fixed the tests, please check now.

If you run the mvn install on this component the tests will run anyway and fail. No matter the profile.

If you run the mvn install on this component the tests will run anyway and fail. No matter the profile.

If you have docker service running, they will run with a pure mvn install.

If you have docker service running, they will run with a pure mvn install.

Lets try to find a solution, because we would like to release 3.8 soon.

Lets try to find a solution, because we would like to release 3.8 soon.

If you run the mvn install on this component the tests will run anyway and fail. No matter the profile.

AFAIK , only those files are included automatically for test which have "Test" as prefix or suffix. Thats why i changed the names of the test files that were failing due to lack of access key,  to have prefix "IT" instead of "Test", so that they do not run automatically in mvn commands. I have added a profile to run them explicitly.

If you run the mvn install on this component the tests will run anyway and fail. No matter the profile.

AFAIK , only those files are included automatically for test which have "Test" as prefix or suffix. Thats why i changed the names of the test files that were failing due to lack of access key,  to have prefix "IT" instead of "Test", so that they do not run automatically in mvn commands. I have added a profile to run them explicitly.

Rebase and run a full build mvn install -DskipTests.. they will run if you have docker service running. You have to deactivate the profile by default, ignore the test, remove the tests or find a different approach.

Rebase and run a full build mvn install -DskipTests.. they will run if you have docker service running. You have to deactivate the profile by default, ignore the test, remove the tests or find a different approach.

I mean run the full build and then run mvn install only on the component. They will run

I mean run the full build and then run mvn install only on the component. They will run

Merged with some modification. Thanks

Merged with some modification. Thanks


auth_on_register plugin, based on client cert field value (not CN)

Hi group,
I'm seeking an advice if I can easily write a plugin for VerneMQ which carve out specific fields from Client Certificate and use that for authentication.
I never worked with erlang, but read the documentation.
I do believe I need the hook on auth_on_register.
I think I also found what parameters can be used in that function (here: https://github.com/vernemq/vernemq_dev/blob/master/src/auth_on_register_hook.erl)
and found references on other sites to use as
auth_on_register(_Peer, {_MountPoint, ClientId}, UserName, Password, _CleanSession) ->
Is there any "easy" option to refer to/process the client certificate send by the client in the auth_on_register hook?
Thanks

Hi @sooslaca I think that's currently not possible. The auth_on_register hook is called downstream of the SSL connection setup (where the verify_peer step happens).
What is the exact use case here?

Hi @ioolkos , thanks for your response.
My use case would be to carve out 'Organization' from the Client Certificate and use that as identity and also post a message on a special topic when client authenticates (with Client Cert only, no username or password)
So as you said it's not currently possible but I can 'patch' https://github.com/vernemq/vernemq/blob/master/apps/vmq_server/src/vmq_ssl.erl , correct?
But then I need to recompile every time when new release is available, and that is something I wanted to avoid with the possibility of using plugins under VerneMQ.
Or would it be possible to add an other hook before auth_on_register like verify_cert ?
Thanks for your help.

First, let's make sure that using the Common Name as username is not what you are looking for (that's a question)
https://github.com/vernemq/vernemq/blob/1070185141827fb1325d57c25c87dab345b3ad7e/apps/vmq_server/priv/vmq_server.schema#L1365
Supposing it's not, the place to look into the client cert is the verify_fun of the Erlang SSL implementation. The verify_fun is a form of hook that can be a given function, or you can implement your own. So you have to hook into the SSL/TLS layer, not into the VerneMQ MQTT layer.
Setting the verify function is not exposed in the vernemq.conf file. We would need to set that in the advanced.config file, under ssl_options for the vmq_server app. (can help you if needed).
Maybe here's some inspiration: https://github.com/deadtrickster/ssl_verify_fun.erl
We'd also have to look into how to load your code into Verne. (most likely as a module plugin).
Also, please note that I'm not so sure what kind of acrobatics is sane or unsane to do in the verify_fun ... :-) My guess is anything goes, but maybe there's timeouts to consider etc.

thanks @ioolkos for the hints on how to possibly move forward. I'll dig the hints and try to implement my needs (yes, it's NOT CN). Let me close this issue as this really a non-issue thread.

Hi @ioolkos , I dig into your idea a bit. ssl_verify_fun I believe is responsible for validating the actual client certificate, which is fine and is required all the cases to be secured. (not expired, etc...)
What I found vernemq extract the CN to be the preauth here:
https://github.com/vernemq/vernemq/blob/1070185141827fb1325d57c25c87dab345b3ad7e/apps/vmq_server/src/vmq_ranch.erl#L121
and here if it's proxied:
https://github.com/vernemq/vernemq/blob/1070185141827fb1325d57c25c87dab345b3ad7e/apps/vmq_server/src/vmq_ranch.erl#L98
Then preauth is used as username here:
https://github.com/vernemq/vernemq/blob/379c7d15871ede362ae19dd4a35621ba5928b024/apps/vmq_server/src/vmq_mqtt_fsm.erl#L50
What my given requirement is to use another attribute (Organization) in the certificate as username.
Do you think it's possible to achieve this functionality as a 'plugin' or I need to patch the source code and recompile it every time on upgrade?
Thanks for your help in advance

No bandwidth to explore this 100% but you can try to look into something like this: https://github.com/vernemq/vernemq/blob/4ce9ac13eb6351402a1a9d7cf07fe56e69086f4a/apps/vmq_server/test/vmq_ssl_SUITE.erl
That is register a module as an auth_on_register hook. Do your logic in your module. Enable the module plugin via normal vmq-admin plugin enable command. This way you'd only have to compile and load your own plugin and could use official build.
Just a quick note, no guarantees.

Hi @ioolkos , yeah that would be my ideal place, problem is I’m not getting the client cert as a parameter in ‘auth_on_register’
Would it be possible to have the client cert sent to ‘auth_on_register’ if it exists so any further logic can be easily implemented?
Thank you

Watching this discussion, I'm really interested in this. I'd like to be able to access the client certificate that was used to authenticate so that I could pull various properties from it to define client ID and username. Being able to access the client cert in the auth_on_register hook would be extremely useful.

Hello, i am also very interested in solving this problem, if a plugin could access the x509 cert from the mutual auth it would be very convenient and would allow to simplify my design a lot. Is this being considered as a feature in future updates?

@sooslaca, @mtannertdev, @riraccuia Thanks for your comments!
and great to see a  need. To help make this a feature for the roadmap, let's first define what the "feature" is. Is it the same for all your use cases?

My use case would be to get the client certificate that is used to handshake TLS as a variable in the auth_on_register hook. I'm pretty sure I can pull the attributes from it using erlang based on what I can see in other examples (https://github.com/deadtrickster/ssl_verify_fun.erl/blob/master/src/ssl_verify_fun_cert_helpers.erl).

Hi @ioolkos , thanks for coming back on this. I’m glad to see that others are entertained by the idea as well.
My use case would be similar like @mtannertdev  wrote, during auth I would like to use certain fields from TLS cert.
To encorporate that best would be to have the full TLS client auth cert into the auth_on_register hook so a plugin can consume the information.
Thanks for the help

I guess auth_on_register variable would do the job, i agree with keeping the whole x509 cert from the handshake

I'm soo glad I found this issue. Exactly! Pulling additional attributes from connecting certs (even the entire cert retained) would save me so much pain. Not a big erlang coder myself but would love to see this feature. I think @sooslaca is right, passing the entire cert to the auth_on_register hook would allow a plugin to pick whatever it needs.

Thanks, great to see more interest.
Action points:

[ ] check technical feasability
[ ] check backward compatibility, in the auth_on_register hook. (Lots of existing auth plugins out there).
[ ] find sponsor to do this as a sponsored feature development, after 1 and 2 check out ;)

@ioolkos
I am looking for the CN to identify the specific tenant to which the device belongs to.  I see that there is already an option to use CN as the username, but in this case i want to retain the username but also access the CN in the webhook.
Having the entire ca certificate that was used to allow the connection as part of auth_on_register/webhook will make it more flexible for various usecases.
Another related query:
We face scenario where a tenant is added dynamically to the system, Is there a provision where to dynamically update the CA cert at runtime?


[0.11] CQ - possible iterator issue

Hello,
I have a cluster I've been testing nightly builds on, the most recent of which seems to have a potential issue (I could be doing something wrong) with CQ and/or the recent iterator changes.
Version: influxdb-0.11.0~n1457078433-0
OS: CentOS 7
Cluster Size: 3
I have a custom agent where I recently changed the way I send batch points to InfluxDB, from a single field key (named value) to multiple field keys.
I have two databases, one that is used to store the raw inbound points, and the second for the downsampled data.
In the first database (inbound raw), the series listed from show series are as expected, where I have the following tags/fields for all series that are listed:
tags:

exchange
host
location
status
svr

fields:

requests
conn_50th
conn_95th
conn_99th
response_50th
response_95th
response_99th

What I see in the downsampled database, however, is that some series have the expected information, and others that have some of the tag keys as values for other tags.
eg. Expected:
incoming,exchange=xx,host=yy,location=ams,status=SERVER_ABORT_HEADER,svr=zz
eg. Unexpected:
incoming,exchange=host,location=status,svr=xx
NOTE: I scrubbed the exchange value to xx for both
The number of "Unexpected" series matches the number of unique exchange values.
The CQ is:
CREATE CONTINUOUS QUERY cq_haproxy_incoming_ps_1m ON haproxy_incoming BEGIN SELECT max(requests) AS requests, max(conn_50th) AS conn_50th, max(conn_95th) AS conn_95th, max(conn_99th) AS conn_99th, max(response_50th) AS response_50th, max(response_95th) AS response_95th, max(response_99th) AS response_99th INTO haproxy_incoming_per_second.rp_haproxy_incoming_per_second_1m.incoming FROM haproxy_incoming.rp_haproxy_incoming.incoming GROUP BY time(1m), * END
I haven't started reading through the code yet and will start that now, but I wanted to bring this up as an issue as it will take me some time to "get up to speed".
Please let me know if I have missed any information and I'd be happy to provide it.

Closing as behaviour is not present after single host changes


Issues related to missing layer (likely caused by https://github.com/containerd/containerd/issues/8973 )

Description
This here is to collect issues that may be caused by https://github.com/containerd/containerd/issues/8973

#3420
#827
#2588
#3415
#2506
#2327
#2357

How to solve it is unclear at this point.
Steps to reproduce the issue
na
Describe the results you received and expected
na
What version of nerdctl are you using?
main
Are you using a variant of nerdctl? (e.g., Rancher Desktop)
None
Host information
No response

Tagging @lingdie who likely has a good understanding of whats going on.

@AkihiroSuda while this is still murky, I feel this is bad enough given the number of issues.
Do you think this could be added to the v2 milestone?

@AkihiroSuda https://github.com/containerd/containerd/issues/8973 is stale, despite pings.
What is your opinion?

do you think this should be a blocker for containerd v2 release? Or otherwise any chance to get eyeballs on it?
or should we try harder to work around it here (not sure this is even feasible honestly)?

The suggestion over there ("Changing the default pull behavior should be up to the client") is a bit asinine TBH, as it would have wide ranging impact on performance...

@lingdie your patch was definitely going in the right direction, but I guess if the layers are missing, it will not be enough?
What if we check if there are missing layers, then force a fetch?
Something in the line of:
_, _, _, missing, err := images.Check(ctx, client.ContentStore(), im.Target, platform)
if len(missing) > 0 {
    img, err = client.Fetch(ctx, ref, opts...)
}

// unpack the image to snapshotter
cimg := containerd.NewImage(client, img)
if err := cimg.Unpack(ctx, snName); err != nil {
    return emptyDigest, err
}

Here is a repro involving tagging:
nerdctl rm -f $(nerdctl ps -aq) 2>&1 >/dev/null
nerdctl rmi -f $(nerdctl images -q) 2>&1 >/dev/null
nerdctl image pull busybox 2>&1 >/dev/null
nerdctl run -d busybox 2>&1 >/dev/null
nerdctl image rm -f busybox 2>&1 >/dev/null
nerdctl pull busybox
nerdctl tag busybox myregistry:5000/test
nerdctl push myregistry:5000/test

This will fail when we try to convert to a temp single platform image (because we tagged an image with missing layers).

a blocker for containerd v2 release

I'd prefer to limit the blockers to:

regressions in v2
new features in v2, merged with a wrong design

a blocker for containerd v2 release

I'd prefer to limit the blockers to:

regressions in v2
new features in v2, merged with a wrong design

Fair enough.
I might have a workable fix in the linked PR.


Add Parc

Good evening, here is the list of some api that would be nice to add!
As well as the opportunity to retrieve the shows of each park and the listed!
hersheypark
Website : http://www.hersheypark.com/
Wait time : https://hpapp.hersheypa.com/v1/rides/wait
details : https://hpapp.hersheypa.com/v1/rides
Universal Singapore
Shows : http://cma.rwsentosa.com/Service.svc/GetUSSContent?languageID=1&filter=Show,Ride,MeetAndGreet,&Latitude=1.254251&Longitude=103.823797
Universal Japan
Wait time : http://ar02.biglobe.ne.jp/app/waittime/waittime.json
Shows : http://ar02.biglobe.ne.jp/app/waittime/schedule.json
Universal Hollywood
Wait time : http://m.universalstudioshollywood.com/waittimes
SeaworldSanDiego & SeaworldSanAntonio & SeaworldOrlando & BuschGardensWilliamsburg &  	BuschGardensTampa
Show : https://seas.te2.biz/v1/rest/venue/{0}/shows/{1}
Disneyland Paris & walt disney studios 1 Disney Village Paris
Shows horaires : https://wdpromedia.disney.go.com/media/wdpro-dlp-assets/prod/global/schedules/entertainments/
Shows details : https://wdpromedia.disney.go.com/media/wdpro-dlp-assets/prod/fr-fr/entertainments/

Hi!
It would be great if you could help out the project and try adding some of these parks yourself! I'd be happy to review pull requests!

Universal Hollywood is now supported. I may look into hersheypark soon.
Seaworld and Disney Paris parks are already supported and show times are currently out-of-scope for the library.
I'm afraid I'm going to close this ticket for now, but please feel free to contribute with a pull request  with any parks you implement!


Create key from string

Is there a way to create a key from a random string for signing and verifying jwts using oslo?
If not, how to do it?
My goal is to be able to specify a secret as an env variable that is used for handling jwts.

It was too early in the morning...

@david-plugge did you solve this? how did you that?

Simply use TextEncoder
const JWT_KEY = new TextEncoder().encode(env.MAGIC_LINK_TOKEN_SECRET);

await createJWT(
	algorithm,
	JWT_KEY,
	{},
	{
		subject: email,
		expiresIn: new TimeSpan(10, 'm')
	}
);

Yes silly me, thanks :)


Update WinUI example to use NT handles

Overhauls the WinUI example to use NT handles to fix support issues from using KMT handles. The following has been done:

Updated WinUI example to use NT handles for the shared texture
Updated WinUI example to use keyed mutex for the shared texture
Added dedicated allocation for image memory when DedicatedOnlyBit set for the target handle type
Added a check for the physical device's LUID to match across interop, but only if the shared handle type needs to use the same device as documented in the VkExternalMemoryHandleTypeFlagBits docs

For #2

Thanks for merging this @malstraem. Something I forgot to mention is that, if this gets merged alongside #3, you'd want to update CheckExternalImageHandleType to check against targetHandleType instead of the hardcoded D3D11TextureKmtBit type. My bad, I could throw up another PR to fix it, if you'd like?

@jack-day, oh, i see. No problem, try it 😄

Great! I've opened up #5 for it 😃


Error with basic-tf-example

Environment
macos 10.15.6
docker 19.03.13
porter v0.29.1 (2e0f3648)
terraform mixin v0.6.0

Scenario
$ cd examples/basic-tf-example
$ porter build
Copying porter runtime ===>
Copying mixins ===>
Copying mixin terraform ===>

Generating Dockerfile =======>

Writing Dockerfile =======>

Starting Invocation Image Build =======>
$ porter install
porter install
installing basic-tf-example...
executing install action from basic-tf-example (installation: basic-tf-example)
Install Terraform assets
Initializing Terraform...
/usr/bin/terraform terraform init

Initializing the backend...

Initializing provider plugins...

The following providers do not have any version constraints in configuration,
so the latest version was installed.

To prevent automatic upgrades to new major versions that may contain breaking
changes, it is recommended to add version = "..." constraints to the
corresponding provider blocks in configuration, with the constraint strings
suggested below.

* provider.local: version = "~> 1.4"

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.
stat rocks!: no such file or directory
Error: error running command terraform apply -auto-approve -input=false -var myvar=porter rocks!: exit status 1
err: error running command terraform apply -auto-approve -input=false -var myvar=porter rocks!: exit status 1
Error: mixin execution failed: exit status 1
Error: 2 errors occurred:
	* container exit code: 1, message: <nil>. fetching outputs failed: error copying outputs from container: Error: No such container:path: eefa835f1f0b5e32b94330c7e5bb0817093710c6c172c7a89fe1348bfe1bfdca:/cnab/app/outputs
	* required output myvar is missing and has no default

Results
Terraform variables with spaces are not surrounded by quotes.
terraform apply -auto-approve -input=false -var myvar=porter rocks!

Investigation
In following source code, quotes should be added:
https://github.com/getporter/terraform-mixin/blob/5f85f7071b6d81662476746cc4d116e72710d7ac/pkg/terraform/install.go#L32

Error fixed with v0.6.0-21-g174d233 canary version in commit 12b0f573dd52ff0caf0db1131b64eb864c020883.

@sestegra Thank you for giving us a heads up! 🙇♀  The problem was that we fixed the mixin but forgot to release an updated version. 🤦♀ v0.6.1 now has the fix in it


Init bug fixes

Previously it was not letting me titan init my-project without 1. an aion node running 2. $PWD/titanrc.js already existing.
Ideas in this PR:

allow init without node up
cross platform path fixes
mkdirp simplification
download pack simplification

Using path strings like ${process.cwd()}/name.ext is not cross-platform. Must use path.join

This looks great @tcrowe thanks. I had this in the list of known bugs to fix. I'm also moving things to TypeScript now so I would try to implement these changes there too.

That sounds great. I'll keep an eye out for the new TS version.


Sentinel Content Management > Repositories (preview): deployment failing

Describe the bug
My understanding of "repositories (preview)" is to be leveraged as continuous integration/deployment pipeline. If not correct, please say.
I mirrored this repository in Azure DevOps, added a branch for my environment, and configured it in Sentinel repositories.
The resulting pipeline fails first because of local href error (#3490) and after on powershell script execution below which is not expected.
Side note, deployment is only asking target sentinel where I would expect other input, typically target resource group for playbooks/logicapp.
To Reproduce
Steps to reproduce the behavior:

Clone repository in Azure Devops
Add it to Sentinel repositories
Check Pipeline results in Azure Devops

Expected behavior
If CI/CD, this should result in corresponding content to be deployed to matching Sentinel and be operational without errors.
Screenshots
Starting: AzurePowerShell
==============================================================================
Task         : Azure PowerShell
Description  : Run a PowerShell script within an Azure environment
Version      : 5.185.0
Author       : Microsoft Corporation
Help         : https://aka.ms/azurepowershelltroubleshooting
==============================================================================
Generating script.
========================== Starting Command Output ===========================
"C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe" -NoLogo -NoProfile -NonInteractive -ExecutionPolicy Unrestricted -Command ". 'D:\a\_temp\[GUID].ps1'"
Import-Module -Name C:\Modules\az_6.5.0\Az.Accounts\2.6.1\Az.Accounts.psd1 -Global
WARNING: Both Az and AzureRM modules were detected on this machine. Az and AzureRM modules cannot be imported in the
same session or used in the same script or runbook. If you are running PowerShell in an environment you control you can
 use the 'Uninstall-AzureRm' cmdlet to remove all AzureRm modules from your machine. If you are running in Azure
Automation, take care that none of your runbooks import both Az and AzureRM modules. More information can be found
here: https://aka.ms/azps-migration-guide
Clear-AzContext -Scope CurrentUser -Force -ErrorAction SilentlyContinue
Clear-AzContext -Scope Process
Connect-AzAccount -ServicePrincipal -Tenant *** -Credential System.Management.Automation.PSCredential -Environment AzureCloud @processScope
 Set-AzContext -SubscriptionId [GUID] -TenantId ***
Starting Deployment for Files in path: D:\a\1\s
##[error]You cannot call a method on a null-valued expression.
##[error]PowerShell exited with code '1'.
Finishing: AzurePowerShell

Desktop (please complete the following information):
N/A
Smartphone (please complete the following information):
N/A

I'm seeing the same thing. From GitHub actions log:
Initializing Az Module
"C:\Program Files\PowerShell\7\pwsh.exe" -NoLogo -NoProfile -NonInteractive -Command "try ***
            $ErrorActionPreference = \"Stop\"
            $WarningPreference = \"SilentlyContinue\"
            $output = @***
            $data = Get-Module -Name Az -ListAvailable | Sort-Object Version -Descending | Select-Object -First 1
            $output['AzVersion'] = $data.Version.ToString()
            $output['Success'] = \"true\"
        ***
        catch ***
            $output['Error'] = $_.exception.Message
        ***
        return ConvertTo-Json $output"
"C:\Program Files\PowerShell\7\pwsh.exe" -NoLogo -NoProfile -NonInteractive -Command Test-Path (Join-Path C:\Modules az_*)
True
***
  "AzVersion": "6.5.0",
  "Success": "true"
***
Initializing Az Module Complete
Running Az PowerShell Script
"C:\Program Files\PowerShell\7\pwsh.exe" -NoLogo -NoProfile -NonInteractive -Command D:\a\_temp\[GUID].ps1
Starting Deployment for Files in path: D:\a\sentinel-playbooks\sentinel-playbooks
ForEach-Object: D:\a\_temp\[GUID].ps1:107
Line |
 107 |      $template.resources | ForEach-Object ***
     |                            ~~~~~~~~~~~~~~~~
     | You cannot call a method on a null-valued expression.

Error: Error: The process 'C:\Program Files\PowerShell\7\pwsh.exe' failed with exit code 1

@preetikr - please have a look

From recent testing, this seems to be partially working.
After merging with current upstream/master, deleting sentinel repository creation, adding again, it attempts to deploy targeted scope (playbooks for now) and does some partially.
Still need to find

how to give general or individual playbooks input parameters. Else most playbooks end with broken API connection
why some playbooks deployed without managed identity even when their json has it
exact permissions required (least privileged ideally) and where

Is this working now, last time i checked it just failed.

@juju4 are you still facing same issue ?

That's mostly addressed with sentinel-deployment.config
Updated relevant docs
https://learn.microsoft.com/en-us/azure/sentinel/ci-cd?tabs=github
https://learn.microsoft.com/en-us/azure/sentinel/ci-cd-custom-deploy?tabs=github


qutebrowser: 1.6.3 -> 1.7.0

Motivation for this change
Upgrade qutebrowser to latest version.
Things done
Upgraded sip and pyqt5 dependencies as well.
Could not test execution of qutebrowser as it fails with No module named 'PyQt5.QtQml' error on my side; it used to fail with the same error before the upgrade to 1.7.0 so this is not related to this pull-request. This pull-request was actually an attempt at fixing this error, but even though it doesn't, the upgrade is still desirable.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

duplicate of https://github.com/NixOS/nixpkgs/pull/65150


OSS License

Thank you for open sourcing the data of the awesome keyboard. Could you add OSS license to the repo just in case?

 However times have changed and perhaps it is time to slap a lisence on this. Do you have any suggestions?

Thank you for the quick response! Say MIT, GPL, CC BY-SA sounds awesome!

MIT seemed to cover most of the things I wanted. I updated the repo with the license file.

Awesome! I appreciate it!


Adding troubleshooting documentatio for K8S Elastic scaling

Thanks to @micafer debugging, some tips exchanged by email.

@sebastian-luna-valero I've added you as a maintainer of this repo so you can merge PR if needed.


Increment resolvewithplus improve support more export patterns

closes https://github.com/iambumblehead/esmock/issues/293

will publish this as 2.6.4 in a moment


Add Korean and test in progress

Fixes Or Enhances
Make sure that you've checked the boxes below before you submit PR:

[ ] Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

coverage: 74.076% (-0.2%) from 74.318%
when pulling c08ffa54701269b97eb19f3e0056030139a82b03 on jkh0kr:master
into 6c3307e6c64040ebc0efffe9366927c68146ffba on go-playground:master.

So what should I do?

The file was created based on Japanese and then updated to English.


PyPi PIP Update Version

Feature Request
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
No
Describe the solution you'd like
A clear and concise description of what you want to happen.
Please also update on PIP https://pypi.org/project/open-webui/
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
N/A
Additional context
Add any other context or screenshots about the feature request here.
N/A

+1

Please check for duplicate issues: #7677


Add Sigma Support for S1 PQ and Cortex

Changes

Add Sigma support for S1 PQ and Cortex products
Update unit tests as necessary

Looks good! Tested with the following rule.
status: test
description: Detects PowerShell Use
author: 'Test'
date: 2023/07/28
logsource:
    category: file_event
    product: windows
detection:
    selection:
        Image|contains:
            - 'powershell.exe'
    condition: selection


Got 'ERROR_QUEUE_FULL'  ---named queue is full

Hi there, when I parallel access arangodb with multi-threading model, I often get the error message: "named queue is full" in python driver, which means an ERROR_QUEUE_FULL error. I'm looking forward to the startup-parameters to increase the queue length.

Hi @daoxian,
did you already try to modify the following arangod options?
  --server.maximal-queue-size <uint64>        size of the priority 2 fifo (default: 4096)
  --server.scheduler-queue-size <uint64>      number of simultaneously queued requests inside the scheduler (default: 128)

Yes, the maximum queue size is modified to 0

I enlarged both the prio-1 & 2  queue size, and this problem vanished.


Adding generic phones resource

This is generic at the moment. I can change it to be specific to WebRTC if that seems better @carnellj

Should also add the telephony resource into the list in resource_genesyscloud_tf_exporter_test.go file


Fix mobile view

This PR provides the solution for code that is causing issues with the user interface.
fixes #63
Along with that, I have made leaderboard view better for mobile users so that they don't have to scroll to see the score.

Thank you!


Don't run docker container as root

The internal user running inside the Docker container is root.
This can be dangerous in some circumstances.

Fixed in PR #177


Allow non-K8S addon hooks

To me it looks like currently there are "pre deletion" hooks, which make use of the finalizer of a managed addon resource.
However, they only allow one to spawn a pod or a job. Assuming one wants to simply reach to an external API, that would mean spawning a job, with a simple HTTP call.
It would be great if the Agent interface would allow for a PreDelete function, which would handle the same, and report back with: ok, need-more-time, failed. Which is basically the same as a job would, just without spawning additional pods.

/assign @zhiweiyin318
this was used to integrate with helm. but i think it makes sense to extend. @zhiweiyin318 thought?


go to definition

Closed by https://github.com/elixir-tools/next-ls/releases/tag/v0.5.0
Followup tasks created #85 #86 #87 #88 #89 #90 #91


[SPARK-46179][SQL] Add CrossDbmsQueryTestSuites, which allows generating golden files with other DBMS, starting off with Postgres

What changes were proposed in this pull request?

Create CrossDbmsQueryTestSuite, which extends SQLQueryTestSuite. CrossDbmsQueryTestSuite is an abstract class that allows generating golden files with other DBMS. The idea here is to generate golden files by running other DBMS, and then when running the test with Spark, it can just compare against the golden file. Running the test itself does not require a live instance of the other DBMS.
PostgreSQLQueryTestSuite is an implementation of CrossDbmsQueryTestSuite. For starters, sql files in the subquery sql-tests are automatically opted into this test. Instructions are added to the header comment for the developer to generate golden files with Postgres. In this PR, all files except for exists-having.sql are ignored, otherwise this PR would have 10K+ line changes (I would like to do that in the next PR, if possible). I had to change the syntax for view creation in exists-having.sql slightly, and this is reflected in the analyzer-results file, but crucially, the query output (in the results file) are not changed.
Note that this will not be applicable to many of the current sql tests we have due to:

Incompatible SQL syntax between spark sql and postgres.
Incompatible data types.
Difference in numerical precision with doubles.
Missing functions in either system.
Test files with specific configs, such as ANSI, count bug etc.

Why are the changes needed?

For correctness checking of our SQLQueryTestSuites, we want to run SQLQueryTestSuites with Postgres as a reference DBMS to generate golden files. This can be easily extensible to other DBMS.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

This is a test-related PR, does not affect system behaviors.
Was this patch authored or co-authored using generative AI tooling?

No.

@jchen5 @agubichev @dtenedor Pinging for re-reviews :-) There's are quite a lot of changes since last time (read PR description).

I changed CrossDbmsQueryTestSuite to be an abstract class, and then PostgreSQLQueryTestSuite to extend that.
For PostgreSQLQueryTestSuite, the default input directory is sql-tests/subquery, to reduce the scope. In this PR, all files except for exists-having.sql are ignored, otherwise this PR would have 10K+ line changes, because I have to change the view creation syntax in these files a bit to be compatible with Postgres.
I added a docker file and bash script for easy installation and start of a Postgres container.

one high-level question: how would the test system look like after we support more than one DBMS? Which DBMS we should pick to generate golden files? Or for each golden file, we only run it with one reference DBMS?

one high-level question: how would the test system look like after we support more than one DBMS? Which DBMS we should pick to generate golden files? Or for each golden file, we only run it with one reference DBMS?

@cloud-fan I'm thinking that each input SQL file will be subject to all DBMS, unless otherwise specified. This means that each input SQL file can produce more than one golden file (1 for Spark, then 1 for each DBMS).

1 for Spark, then 1 for each DBMS

Our goal is to guarantee Spark produces the same result as the reference DBMS, why do we want to have one golden file for each DBMS? What if they are different? Which one should Spark follow?

Our goal is to guarantee Spark produces the same result as the reference DBMS, why do we want to have one golden file for each DBMS? What if they are different? Which one should Spark follow?

That makes sense. I think all DBMS can share the same golden file, if we make the queries simple enough that they are compatible with all DBMS. I wish there was a way to only have one set of golden files, but the current golden files have the Spark schema and hence aren't able to be generated with the DBMS. I don't want to make too many changes to the golden file.

That makes sense. I think all DBMS can share the same golden file, if we make the queries simple enough that they are compatible with all DBMS.

Makes sense to me. Then shall we always let Spark generate golden files? What we need to do is to let other DBMS run the query and compare results with golden files (exclude the schema part). I think keeping a single golden file is important to verify the results, otherwise we need human to make sure two golden files are equal.

Then shall we always let Spark generate golden files? What we need to do is to let other DBMS run the query and compare results with golden files (exclude the schema part).

The reason why we wanted to use DBMS to generate golden files is because we didn't want the CI/CD/developer to have to install some version of postgres/other DBMS just to run tests.

because we didn't want the CI/CD/developer to have to install some version of postgres/other DBMS just to run tests.

Isn't it better to trust CI/CD to install the proper version of DBMS and run the tests, instead of humans? AFAIK we are already doing it to run tests for JDBC data sources. We already have postgres tests in https://github.com/apache/spark/blob/master/connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala

We are already doing it to run tests for JDBC data sources

@cloud-fan I didn't know about those tests! I made the changes to add this as an integration test instead, as you suggested. The two tests are a bit disconnected:

It's maybe a bit weird that a test in spark/connector uses files in spark/core, but this can be improved in the future.
There's some code duplication to read golden files, but I think not too much that it is bad code.

It's maybe a bit weird that a test in spark/connector uses/affects test files in spark/core.

I think it's OK. We have JDBC tests in spark/connector that depend on tests in sql/core

There's some code duplication to read golden files, but I think not too much.

Is there a way to refactor it?

Is there a way to refactor it?

I tried to move as much code as possible to the trait SQLQueryHelper. It's 20+ lines, I don't think it's an issue.

@cloud-fan Can we merge?

thanks, merging to master!


DefaultChannelHandlerInvoker should work with non AbstractChannelHand…

…lerContext sub-classes.
Motivation:
DefaultChannelHandlerInvoker currently blindly cast to AbstractChannelHandlerContext without checking if the ChannelHandlerContext is really a sub-type of it. It should check it first and if not just use slow-path implementation.
Modifications:
Do instanceof check first and if it fails just create a new Runnable instance of used the cached.
Result:
DefaultChannelHandlerInvoker works with any ChannelHandlerContext implementations.

@Scottmitch @trustin @nmittler PTAL.

lgtm

LGTM

Cherry-picked into 4.0 as ea94336689047fcd505a4e4040d55b3f46728054


Improve accessibility

https://wave.webaim.org/report#/research-software.uit.no

I have adjusted colors and contrast and added alt text.


Add pagination

This pr introduces a new reusable hook called usePagination for handling pagination

Thank you for contribution. Really great job 👏👏👏


Redirect to dashboard from landing

📝 Changed routes:

/

(view full size)

Commit fb696ce5424ce11d9f89f483771e50efc07024b1 (https://thirdweb-jzc0dbai0-thirdweb.vercel.app).


Why Explain Without Explaining?

In section 2.3 You give very vague instructions on adding URL Types. If you are not going to fully explain it why bother writing the article? I have no idea what you are talking about!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 83d269a0-0b09-c2f6-d37a-319831bcf782
Version Independent ID: f2c17a3a-87bb-0c75-9efb-de6ffb6f7738
Content: App Center Distribute for Xamarin - Visual Studio App Center
Content Source: docs/sdk/distribute/xamarin.md
Service: vs-appcenter
GitHub Login: @elamalani
Microsoft Alias: emalani

The reason for step 2.3 is partly explained further down in section "How do in-app updates work?".
Might be good to explain that iOS requires that you registers a unique schema/protocol to enable information to be transferred from a browser to a specific app via navigation to an url?

Hey @ahdbilal could you add some clarity to the relevant section? Thanks.

Hi! Thanks for mention it! We updated docs about it.
I’m closing this issue, but feel free to reopen this issue if it isn’t resolved or you have additional questions.

Hi! Thanks for mention it! We updated docs about it.
I’m closing this issue, but feel free to reopen this issue if it isn’t resolved or you have additional questions.


Verify duplicate mod version on mod bundling

On bundling it should be verified if mod/package version is already bundled. If yes throw error.
More or less related to #63.

Thanks!
This particular part of the app needs some serious TLC, this is a great addition until I can re-word the whole thing.


Update doc about routing for openapi operations

The document about routing says "you can include x-swagger-router-controller in your operation definition, making operationId relative"
while, in fact, to add OpenAPI operations, it is x-openapi-router-controller that should be added to operation definition.

This took me long to figure this issue out ... @xiaoyu-wu you are right!

Fixed in #1353


Add BTB selectors

Added UCB1 selector in order to select in a better way the templates.

Codecov Report

Merging #33 into master will increase coverage by 0.03%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   39.43%   39.46%   +0.03%
==========================================
  Files           8        8
  Lines        1268     1272       +4
==========================================
+ Hits          500      502       +2
- Misses        768      770       +2

Impacted Files
Coverage Δ

ta2/search.py
40.12% <18.18%> (+0.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 510abf4...bef1082. Read the comment docs.


DNA_construct

generic DNA construct simulation which predicts RNA and protein production based on a sequence of DNA parts.
Check out DNA construct examples .ipynb!

Hi Andrey,
I think these three commits could be merged together:

To do so:

checkout your branch
run

git rebase -i HEAD^^^

Then you see the screenshot above (depending on your default editor in terminal)
To merge the commits, you can use squash or fixup

hopefully, it can merge without merge conflict, if not you need to handle the conflicts. For each conflict, after resolving it, you need to run
git add file_name
# and
git rebase --continue

If you get lost
git rebase --abort

to start over.
Because these steps rewrites history, you need to force push your changes to GitHub:
git push -f

One more thing, there's one error, which is not present in the dev branch, but most probably this PR introduces:

This is generated in ' examples/Plotting Examples.ipynb::Cell 2'
You can reproduce this after running
python setup.py test

on your branch

Hi Andrey,
please rebase your branch to dev, so you get the latest updates:
git fetch upstream/dev
git checkout DNA_construct_final
git rebase upstream/dev

Once you have that you need to force push:
git push -f

After these steps, Travis should be able to run properly.

ok i am doing this rebase thing and it has too many conflicts. i don't understand why squashing those commits would create conflicts. are you sure this is worth it?

ok i am doing this rebase thing and it has too many conflicts. i don't understand why squashing those commits would create conflicts. are you sure this is worth it?

Probably doesn't worth it, we can do a squash and merge at the end:

Some thoughts on how to deal with binding location on DNA constructs.
Issue description: DNA constructs (and other future objects) will require that a species bind to a specific location on the piece of DNA. This means that BoundDNA = ComplexSpecies([DNA, Binder]) will not work because the Binder could bind to multiple locations on the DNA. This issue has currently been solved with the make_complex function which does some fancy logic to bind things to the appropriate place on OrderedComplexSpecies. However, this solution is not necessarily generalizable to the case where there are many possible binding locations and different mechanisms require different locations along the same species.
Suggested Solution: Introduce a new Species class SubSpecies(Species). SubSpecies can ONLY exist inside a ScaffoldSpecies (there is probably a better name) which is effectively an OrderedComplexSpecies made up of SubSpecies. Importantly, SubSpecies know about their containing ScaffoldSpecies and use it's name. However, when a SubSpecies is passed into ComplexSpecies or OrderedComplexSpecies, the resulting Species object is automatically placed inside of the ScaffoldSpecies which contains the Subspecies.
I will illustrate this with an example of two binding sites B1 and B2 in a polymer P which can be bound to A1 and A2, respectively. Note that this is a combinatorial system with 4 possible states.
B1 = SubSpecies("B1")' B2 = SubSpecies("B2") P = ScaffoldSpecies ([B1, B2])==> B1 and B2 can now only be used in a reaction or ComplexSpecies after they are placed inside a Parent Species. If B1 or B2 were used before this line of code, an error would occur.C1 = ComplexSpecies([A1, B1])==>Returns ScaffoldSpecies([ComplexSpecies([A1, B1]), B2])Notice that A1 binds to B1 inside of the ScaffoldSpecies that contains B1 and B2.C2 = ComplexSpecies([A2, B2])==>Returns ScaffoldSpecies ([B1, ComplexSpecies([A2, B2])]) C3 = ComplexSpecies([A1, C1.species[B1])==>Returns ScaffoldSpecies([ComplexSpecies([A1, B1]), B2]), ComplexSpecies([A2, B2])])Notice that ScaffoldSpecies can access their SubSpecies easily. The proposed indexing probably needs to be smarter for cases where there are multiple copies of the same SubSpecies in a ScaffoldSpecies - but that is doable, maybe by integer indexing.C4 = ComplexSpecies([A2, C2.species[B2])==>Returns ScaffoldSpecies([ComplexSpecies([A1, B1]), B2]), ComplexSpecies([A2, B2])])which is equal toC3`.
Finally, if a subspecies is used in a reaction, it will be equivalent to using its containing ScaffoldSpecies.
For this to work, every ScaffoldSpecies will need a unique copy of each SubSpecies.

Are the thoughts above intended to be part of this PR, or is that something that you are starting a discussion on (in which case you might want to start an issue?).
Note that there are other similar constructions that might occur in other places.  For example, if we create a protein fusion A-B then might have a. molecule that binds to just one of the proteins in the construct, to yield something like C:A-B or on the other protein to yield A-B:D.  Or a single protein might bind to both, so perhaps we write (C:A)-B, A-(B:D), and (A-B):E?
Similar things can happen with RNAs, genelets, kinases (eg, if there are multiple phosphorylation sites), methyltransferases, etc.

@murrayrm this pull request is a work in progress and active discussion. I think one advantage to having discussions around pull requests is that there is now commentary around the code changes in the request. With issues the code and discussion are frequently detached.

I don't really understand how ComplexSpecies would yield different things. I think that a function like make_complex() makes the most sense to me and overloading the ComplexSpecies constructor is too confusing.
I like the idea of passing a sub-member of a ScaffoldSpecies. Its basically another version of the binding site variable. The problem of duplicate SubSpecies is still present. The solution is the binding site variable.
The core problem of all of this is that if you have two ScaffoldSpecies that bind each other, we don't know how to handle that.

@dr3y responding to your comments below.

I don't really understand how ComplexSpecies would yield different things. I think that a function like make_complex() makes the most sense to me and overloading the ComplexSpecies constructor is too confusing.

My hope here is that we can bury all the confusing aspects into the constructor and then use ScaffoldSpecies and SubSpecies the way we would use any other Species, but with the added bonus that they work differently when forming bound complexes and inside reactions. The issue I think people will be confused about in the future is when to use the binding site keyword, and when not to - the nice thing about the SubSpecies approach is that we basically make an object which takes care of that for us. I do agree however that writing this code will be complicated and overloading a constructor adds complexity to the code base, however I think it will make everything more consistent and object oriented.

I like the idea of passing a sub-member of a ScaffoldSpecies. Its basically another version of the binding site variable. The problem of duplicate SubSpecies is still present. The solution is the binding site variable.

Instead of referencing a ScaffoldSpecies[SubSpecies] to get that SubSpecies, what if you could also reference ScaffoldSpecies[integer] to get that SubSpecies? This looks a lot like the binding site, variable in the end, but is just encapsulated into the species more directly.

The core problem of all of this is that if you have two ScaffoldSpecies that bind each other, we don't know how to handle that.

This is a very good thought experiment I hadn't considered! We are definitely missing some pieces, but here are my first thoughts:
A1, A2, B1, B2= SubSpecies("A1"), SubSpecies("A2"), SubSpecies("B1"), SubSpecies("B2")

PA = ScaffoldSpecies ([A1, A2])
PB = ScaffoldSpecies ([B1, B2])

To make PA bind to PB with site A1 attaching to B1 we should be able to say very simply:
C = ChemicalComplex([A1, B1])
However, I think @dr3y you correctly point out that it isn't obvious what this will return. Additionally, I worry that C2 = ChemicalComplex([B1, A1]) will not end up being the same as C, which isn't the behavior we want.
What this suggests to me is that we need a better internal Species representation than strings. I believe this problem has been dealt with by the DNA-strand-displacement using graph-isomorphisms. The increased level of complexity coming out of having binding sites like this also makes me even more convinced that we will need more than just a function create_complex in order to deal with the potential complexity arising when two things with diverse binding sites bind together. ScaffoldSpecies and SubSpecies might be a way to do this - although this example points out that a linear sequence representation is insufficient for two ScaffoldSpecies binding together. @zoltuz @ayush9pandey @murrayrm I would appreciate any feedback you have here - it seems like this issue is quickly becoming more complicated than I originally envisioned, but these are very plausible modelling scenarios biocrnpyler should be able to deal with.

Instead of referencing a ScaffoldSpecies[SubSpecies] to get that SubSpecies, what if you could also reference ScaffoldSpecies[integer] to get that SubSpecies? This looks a lot like the binding site, variable in the end, but is just encapsulated into the species more directly.

So then each SubSpecies know what position it has in the ScaffoldSpecies? This is basically how DNA_construct and DNA_part works and that is why it allows having the same part in multiple locations.

So then each SubSpecies know what position it has in the ScaffoldSpecies? This is basically how DNA_construct and DNA_part works and that is why it allows having the same part in multiple locations.

That sounds right - it makes sense for SubSpecies to functionally mimic DNA_part because a SubSpecies represents a DNA_part.

@dr3y some comments/notes on DNA_construct from the meeting:

DNAconstruct from a list of parts with no directions defaults to forward
reactions that understand OrderedPolymerSpecies & test cases
add get_part(part = part) which returns a part with the same name and type if one is inside. Please model this off of Mixture.get_component()
is it possible to save self.rnas, self.proteins so explore_txtl doesn't have to be called in update_reactions? These would have to be reset to None if anything is updated in the DNAconstruct. Same for out_components [this is especially important because this is an exponentially large operation, in general].


added correct jetty dependencies

Merged build triggered.

Merged build started.

Merged build finished. Test PASSed.

Merged. Thanks @erictu!


ERR_SSL_PROTOCOL_ERROR on Running tutorial

Problem encountered on https://dotnet.microsoft.com/en-us/learn/aspnet/blazor-tutorial/run
Operating System: windows 10
First with  the "dotnet watch" comand I just get the explanation of the comand, nothing is starting.
When I try "dotnet watch run" something happens, but with an ERR_SSL_PROTOCOL_ERROR (Connection to this side is not safe, localhost sends a invalid answer) in my Browserwindow.
This happens in G-Chrome and in MS-Edge.
Here the enviroment:
C:\Users\Iso1\BlazorApp>dotnet --info
.NET SDK (gemäß "global.json"):
Version:   5.0.400
Commit:    d61950f9bf
Laufzeitumgebung:
OS Name:     Windows
OS Version:  10.0.19043
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\5.0.400\
Host (useful for support):
Version: 5.0.9
Commit:  208e377a53
.NET SDKs installed:
5.0.400 [C:\Program Files\dotnet\sdk]
.NET runtimes installed:
Microsoft.AspNetCore.All 2.1.29 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.29 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.1.18 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 5.0.9 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.29 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.1.18 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 5.0.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 3.1.18 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 5.0.9 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

I'm getting the same error, not really sure what's going on.

I deleted the BlazorApp folder and recreated it, without the "--no-https" in the command line, and it worked.
Try it out and see if it works for you too.

It sounds like the browser was not able to make a successful SSL connection to the app. In the tutorial we recommend creating the Blazor app without HTTPS enabled to avoid certificate trust issues. If you prefer to run with HTTPS enabled, you'll need to first setup the ASP.NET Core development certificate by running dotnet dev-certs https --trust.


Aesthetic Dialogs project is not visible

I submitted the project AestheticDialogs but it is not visible on the site.

Yes, @techtrailhead updated the script yesterday. Thank you.


Document how to handle wrong/bad images on old versions of docker

The import/export thing

See: https://shuffler.io/docs/troubleshooting#how-to-handle-wrong-or-bad-images-on-old-versions-of-docker


dict for Variables produces unexpected output

Description
>>> bqm = dimod.BQM({(0, 0): 1, (0, 1): 2, (0, 3): 3}, {}, 0, "SPIN")
>>> set(bqm.variables)
{(0, 0), (0, 1), (0, 3)}
>>> list(bqm.variables)
[(0, 0), (0, 1), (0, 3)]
>>> dict(bqm.variables)
{0: 3}

**Steps To Reproduce**
See above

**Expected Behavior**
Dict of variable labels

**Environment**
 Leap IDE

**Additional Context**
dimod version: 0.10.17

This isn't a dimod thing, it's a Python one.
In [1]: variables = [(0, 1), (0, 2), (0, 3)]

In [2]: set(variables)
Out[2]: {(0, 1), (0, 2), (0, 3)}

In [3]: dict(variables)
Out[3]: {0: 3}

It's because you can construct dicts with
dict((key, value) for key, value in ...)

Also, it's not clear to me what you expect the values of the dict you create with dict(bqm.variables) to be. Variables is an iterable of labels, like a list.