Chat message images are not rendered

What version of Integration has the issue?
v2.13.11
System Health details

Version
core-2024.9.1

Installation type
Home Assistant OS

Development
false

Supervisor
true

Docker
true

User
root

Virtual environment
false

Python version
3.12.4

Operating system family
Linux

Operating system version
6.6.46-haos

CPU architecture
x86_64

Timezone
Europe/Berlin

Configuration directory
/config

Checklist

[X] I have enabled debug logging for my installation.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).

Describe the issue
I am using the markdown card read messages and I can see the text of the messages, but when the message contains any media, it is not shown:
Just this is shown:

If I open the developer tools, I see that the image is attached

But it is not found

Reproduction steps

Include the chat card into your dashboard https://raw.githubusercontent.com/Ludy87/xplora_watch/main/samples/markdown-card-read-messages.md
Send a message with an image
Reload the page

Debug logs
2024-09-08 17:22:28.710 DEBUG (MainThread) [custom_components.xplora_watch] Set up the Xplora® Watch Version 2 component
2024-09-08 17:22:28.711 DEBUG (MainThread) [custom_components.xplora_watch] Configure based on config entry 01J53BSA5NZ3M3N6JG93X41T54
2024-09-08 17:22:28.941 DEBUG (MainThread) [custom_components.xplora_watch] pyxplora_api lib version: 2.12.9-1298
2024-09-08 17:22:30.457 DEBUG (MainThread) [custom_components.xplora_watch.coordinator] Fetch data from Xplora: 6350930
2024-09-08 17:22:33.318 DEBUG (MainThread) [custom_components.xplora_watch.coordinator] load address from openstreetmap.org
2024-09-08 17:22:33.320 DEBUG (MainThread) [custom_components.xplora_watch.coordinator] Manually updated xplora_watch- data
2024-09-08 17:22:33.320 DEBUG (MainThread) [custom_components.xplora_watch.coordinator] Finished fetching xplora_watch- data in 4.379 seconds (success: True)
2024-09-08 17:22:34.683 DEBUG (MainThread) [custom_components.xplora_watch.helper] set services.yaml path: /config/custom_components/xplora_watch/services.yaml
2024-09-08 17:22:34.683 DEBUG (MainThread) [custom_components.xplora_watch.helper] services_en.json path: /config/custom_components/xplora_watch/jsons/service_en.json
2024-09-08 17:22:34.703 WARNING (MainThread) [homeassistant.helpers.frame] Detected that custom integration 'xplora_watch' calls async_forward_entry_setup for integration, xplora_watch with title: Xplora® and entry_id: 01J53BSA5NZ3M3N6JG93X41T54, which is deprecated and will stop working in Home Assistant 2025.6, await async_forward_entry_setups instead at custom_components/xplora_watch/__init__.py, line 67: hass.async_create_task(hass.config_entries.async_forward_entry_setup(entry, platform)), please create a bug report at https://github.com/Ludy87/xplora_watch/issues
2024-09-08 17:22:34.721 DEBUG (MainThread) [custom_components.xplora_watch.binary_sensor] Updating binary_sensor: Dana Watch Charging (Saninn Giancarlo Salas Diaz) | Typ: charging | Watch_ID ...6350930
2024-09-08 17:22:34.732 WARNING (MainThread) [homeassistant.helpers.frame] Detected code that calls async_forward_entry_setup for integration xplora_watch with title: Xplora® and entry_id: 01J53BSA5NZ3M3N6JG93X41T54, during setup without awaiting async_forward_entry_setup, which can cause the setup lock to be released before the setup is done. This will stop working in Home Assistant 2025.1. Please report this issue.
Stack (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/usr/src/homeassistant/homeassistant/__main__.py", line 223, in <module>
    sys.exit(main())
  File "/usr/src/homeassistant/homeassistant/__main__.py", line 209, in main
    exit_code = runner.run(runtime_conf)
  File "/usr/src/homeassistant/homeassistant/runner.py", line 189, in run
    return loop.run_until_complete(setup_and_run_hass(runtime_config))
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 674, in run_until_complete
    self.run_forever()
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 641, in run_forever
    self._run_once()
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 1990, in _run_once
    handle._run()
  File "/usr/local/lib/python3.12/asyncio/events.py", line 88, in _run
    self._context.run(self._callback, *self._args)
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 2184, in async_forward_entry_setup
    _report_non_awaited_platform_forwards(entry, "async_forward_entry_setup")
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 1201, in _report_non_awaited_platform_forwards
    report(
  File "/usr/src/homeassistant/homeassistant/helpers/frame.py", line 151, in report
    _LOGGER.warning(msg, stack_info=True)
2024-09-08 17:22:34.733 WARNING (MainThread) [homeassistant.helpers.frame] Detected code that calls async_forward_entry_setup for integration xplora_watch with title: Xplora® and entry_id: 01J53BSA5NZ3M3N6JG93X41T54, during setup without awaiting async_forward_entry_setup, which can cause the setup lock to be released before the setup is done. This will stop working in Home Assistant 2025.1. Please report this issue.
Stack (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/usr/src/homeassistant/homeassistant/__main__.py", line 223, in <module>
    sys.exit(main())
  File "/usr/src/homeassistant/homeassistant/__main__.py", line 209, in main
    exit_code = runner.run(runtime_conf)
  File "/usr/src/homeassistant/homeassistant/runner.py", line 189, in run
    return loop.run_until_complete(setup_and_run_hass(runtime_config))
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 674, in run_until_complete
    self.run_forever()
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 641, in run_forever
    self._run_once()
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 1990, in _run_once
    handle._run()
  File "/usr/local/lib/python3.12/asyncio/events.py", line 88, in _run
    self._context.run(self._callback, *self._args)
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 2184, in async_forward_entry_setup
    _report_non_awaited_platform_forwards(entry, "async_forward_entry_setup")
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 1201, in _report_non_awaited_platform_forwards
    report(
  File "/usr/src/homeassistant/homeassistant/helpers/frame.py", line 151, in report
    _LOGGER.warning(msg, stack_info=True)
2024-09-08 17:22:34.734 DEBUG (MainThread) [custom_components.xplora_watch.sensor] Updating sensor: Dana Watch Battery (Saninn Giancarlo Salas Diaz) | Typ: battery | Watch_ID ...6350930
2024-09-08 17:22:34.734 DEBUG (MainThread) [custom_components.xplora_watch.sensor] Updating sensor: Dana Watch Message (Saninn Giancarlo Salas Diaz) | Typ: message | Watch_ID ...6350930
2024-09-08 17:22:34.735 WARNING (MainThread) [homeassistant.helpers.frame] Detected code that calls async_forward_entry_setup for integration xplora_watch with title: Xplora® and entry_id: 01J53BSA5NZ3M3N6JG93X41T54, during setup without awaiting async_forward_entry_setup, which can cause the setup lock to be released before the setup is done. This will stop working in Home Assistant 2025.1. Please report this issue.
Stack (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/usr/src/homeassistant/homeassistant/__main__.py", line 223, in <module>
    sys.exit(main())
  File "/usr/src/homeassistant/homeassistant/__main__.py", line 209, in main
    exit_code = runner.run(runtime_conf)
  File "/usr/src/homeassistant/homeassistant/runner.py", line 189, in run
    return loop.run_until_complete(setup_and_run_hass(runtime_config))
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 674, in run_until_complete
    self.run_forever()
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 641, in run_forever
    self._run_once()
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 1990, in _run_once
    handle._run()
  File "/usr/local/lib/python3.12/asyncio/events.py", line 88, in _run
    self._context.run(self._callback, *self._args)
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 2184, in async_forward_entry_setup
    _report_non_awaited_platform_forwards(entry, "async_forward_entry_setup")
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 1201, in _report_non_awaited_platform_forwards
    report(
  File "/usr/src/homeassistant/homeassistant/helpers/frame.py", line 151, in report
    _LOGGER.warning(msg, stack_info=True)
2024-09-08 17:22:34.736 WARNING (MainThread) [homeassistant.helpers.frame] Detected code that calls async_forward_entry_setup for integration xplora_watch with title: Xplora® and entry_id: 01J53BSA5NZ3M3N6JG93X41T54, during setup without awaiting async_forward_entry_setup, which can cause the setup lock to be released before the setup is done. This will stop working in Home Assistant 2025.1. Please report this issue.
Stack (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/usr/src/homeassistant/homeassistant/__main__.py", line 223, in <module>
    sys.exit(main())
  File "/usr/src/homeassistant/homeassistant/__main__.py", line 209, in main
    exit_code = runner.run(runtime_conf)
  File "/usr/src/homeassistant/homeassistant/runner.py", line 189, in run
    return loop.run_until_complete(setup_and_run_hass(runtime_config))
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 674, in run_until_complete
    self.run_forever()
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 641, in run_forever
    self._run_once()
  File "/usr/local/lib/python3.12/asyncio/base_events.py", line 1990, in _run_once
    handle._run()
  File "/usr/local/lib/python3.12/asyncio/events.py", line 88, in _run
    self._context.run(self._callback, *self._args)
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 2184, in async_forward_entry_setup
    _report_non_awaited_platform_forwards(entry, "async_forward_entry_setup")
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 1201, in _report_non_awaited_platform_forwards
    report(
  File "/usr/src/homeassistant/homeassistant/helpers/frame.py", line 151, in report
    _LOGGER.warning(msg, stack_info=True)
2024-09-08 17:22:34.736 DEBUG (MainThread) [custom_components.xplora_watch.notify] init Notify Service
2024-09-08 17:27:35.587 DEBUG (MainThread) [custom_components.xplora_watch.coordinator] Fetch data from Xplora: 6350930
2024-09-08 17:27:38.299 DEBUG (MainThread) [custom_components.xplora_watch.coordinator] load address from openstreetmap.org
2024-09-08 17:27:38.301 DEBUG (MainThread) [custom_components.xplora_watch.coordinator] Manually updated xplora_watch- data
2024-09-08 17:27:38.302 DEBUG (MainThread) [custom_components.xplora_watch.coordinator] Finished fetching xplora_watch- data in 4.259 seconds (success: True)
2024-09-08 17:32:39.585 DEBUG (MainThread) [custom_components.xplora_watch.coordinator] Fetch data from Xplora: 6350930
2024-09-08 17:32:42.246 DEBUG (MainThread) [custom_components.xplora_watch.coordinator] load address from openstreetmap.org
2024-09-08 17:32:42.247 DEBUG (MainThread) [custom_components.xplora_watch.coordinator] Manually updated xplora_watch- data
2024-09-08 17:32:42.247 DEBUG (MainThread) [custom_components.xplora_watch.coordinator] Finished fetching xplora_watch- data in 4.204 seconds (success: True)

Hi @distante
Please set in your configuration.yaml and try again

homeassistant:
  allowlist_external_dirs:
    - "/config"

Can you check whether the image is in another folder? Normally it would be in www/image
Otherwise you can create the www folder in the root directory of the config and test it?

I have the www/image folder but there there is nothing


fix: Trigger component content will not pop up

Types of changes

[ ] New feature
[x] Bug fix
[ ] Enhancement
[ ] Documentation change
[ ] Coding style change
[ ] Component style change
[ ] Refactoring
[ ] Test cases
[ ] Continuous integration
[ ] Typescript definition change
[ ] Breaking change
[ ] Others

Background and context

Solution
In some cases, Portal getContainer may be called before the componentDidMount of the index file
https://github.com/arco-design/arco-design/blob/8593792df73de56e18990eba01d8e3265f4be8a0/components/Trigger/portal.tsx#L20
At this time, since this.isDidMount is false, it will cause the container not to be added to the rootElement
https://github.com/arco-design/arco-design/blob/8593792df73de56e18990eba01d8e3265f4be8a0/components/Trigger/index.tsx#L859-L893
And because getContainer returns an element that has not been added to the rootElement, it will cause getContainer not to be called again.
https://github.com/arco-design/arco-design/blob/8593792df73de56e18990eba01d8e3265f4be8a0/components/Trigger/portal.tsx#L15-L21
This will lead to the content not being able to pop up, so it is necessary to add an isDidMount check in getContainer.

How is the change tested?

Changelog

Component
Changelog(CN)
Changelog(EN)
Related issues

Trigger
修复某些情况下 Trigger 组件 popupVisible 属性默认为 True 时内容没有弹出的问题
Fix the issue that the content is not popped up when the Trigger component popupVisible property is defaulted to True in some cases.
https://github.com/arco-design/arco-design/issues/2811

Checklist:

[ ] Test suite passes (npm run test)
[ ] Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
[ ] Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others should be submitted to main branch)

Other information

It looks like there are some problems with the test I'll fix the test later

It looks like there are some problems with the test I'll fix the test later

done


Java <-> Squeak byte array conversion issues

I'm struggling with passing byte arrays between Java and Squeak. The issue is that 0xFF is represented as 255 in Squeak and -1 in Java as Java only has signed bytes and bytes in Squeak are unsigned.
The following works:
(Java type: 'java.net.InetAddress')
	getByAddress: #[127 0 0 1]

but this fails
(Java type: 'java.net.InetAddress')
	getByAddress: #[192 168 0 1]

Another interop bug, thanks for reporting! A fix is on the way:

A fix is on dev and will ship with the next release.


Add automatic CPU feature detection

I love this project!  I joined the std::simd team originally after getting frustrated writing my fourier crate.
Full disclosure--the multiversion crate is mine, but I think it works perfectly here, especially considering the desire to forbid unsafe code.
I removed all references to -Ctarget-cpu=native and the like--I believe with this change, it should make no difference, at least on x86(-64) and aarch64.  Plus, in my opinion, it's only useful for research and not commercial/enterprise software, since it's not really possible to redistribute -Ctarget-cpu=native code.  I think this benchmark is more faithful to real use.
This PR is going to need a follow-up commit updating the benchmark results.

Hi @calebzulawski,
Thank you for the kind words and your contribution! I'm going to try to figure out why the coverage check is failing, and then I'll re-run the benchmarks on the same machine.
Best,
Saveliy

Do I understand correctly that ARM does not need multiversioning because Aarch64 always has NEON, and portable SIMD does not map well to SVE?

Correct--standard aarch64 has neon, so no need to detect it.  You can have nonstandard aarch64 without it, but then there is no need to detect it.  SVE actually can map to portable SIMD, but it will need more support from the compiler.  E.g. you can have separate SVE-128 and SVE-256 target features that each refer to a specific SVE register size, detected at runtime. I digress...

I rebased--not sure if that's expected to fix the code coverage issue.

@calebzulawski
Here are the benchmark results. Since your PR was already merged, I ran this from the main branch.

Thank you! I think that looks comparable to the old benchmark results, what do you think?

@calebzulawski
This looks great! Thank you for your contribution. This was the last thing I wanted merged prior to releasing the next version.

@calebzulawski
Just wanted to add that I re-ran the benchmarks for pyphastft (the python bindings via PyO3) as well. All of the new plots are in the readme. Thank you!
Best,
Saveliy

Awesome! Excited to see a new release!


object location services: caching policies - expiration, size limits, replacement

Original issue: https://charm.cs.illinois.edu/redmine/issues/113

Right now, location cache entries are never removed, even if they become unused and stale. For performance and memory consumption, stale entries should be discarded over time. We don't need a fixed size limit, since it's a software cache, and it may be the best use of that memory, but it shouldn't be allowed to grow without bound.

Original date: 2013-03-15 22:04:39

Expiration could be based on time in cache without being accessed, age (in terms of migration 'generations'), or how many other entries have been accessed. There's an issue of working set size estimation, and optimal cache size estimation. I would posit that except at the limit of memory consumption, the addition of one entry should never evict another, because of the potential for performance cliff effects.

Original author: Nikhil Jain
Original date: 2014-01-06 04:47:07

With Ram not available, this task needs to be reassigned.


per_kb_fee -> per_byte_fee

Ok did the easy thing and converted per_kb_fee to per_byte_fee
One thing: upon deeper inspection, it looks like the server shouldn't be masking the fee. Maybe you see something I don't.. but if the client "re-masks" after factoring in weight (as MyMonero does here, here's the caller), the fee calculation is different than it would otherwise be. Since wallet2 seems to only mask once after weight is factored in, and I figure the intention is to match wallet2, then makes sense to let the client do the masking so as to not lead to fingerprinting?
Running the numbers:
uint64_t calculate_fee_from_weight(uint64_t base_fee, uint64_t weight, uint64_t fee_multiplier, uint64_t fee_quantization_mask)
{
  // monero-lws expected calculated fee
  const std::uint64_t per_byte_fee_masked =
    ((base_fee + (fee_quantization_mask - 1)) / fee_quantization_mask) * fee_quantization_mask;
  uint64_t monero_lws_calculated_fee =  weight * per_byte_fee_masked * fee_multiplier;
  monero_lws_calculated_fee = (monero_lws_calculated_fee + fee_quantization_mask - 1) / fee_quantization_mask * fee_quantization_mask;

  // wallet2 calculated fee
  uint64_t fee = weight * base_fee * fee_multiplier;
  fee = (fee + fee_quantization_mask - 1) / fee_quantization_mask * fee_quantization_mask;

  printf("monero-lws fee: %lu \nwallet2 fee: %lu", monero_lws_calculated_fee, fee);
  return fee;
}

Outputs:
monero-lws fee: 344640000
wallet2 fee:   336650000

Confirmed that the server shouldn't be masking to maintain parity with wallet2. I confirmed by getting a client-side + server-side implementation to match wallet2 using MyMonero's code. Will be submitting a separate PR to MyMonero's code after a bit more testing

So the API schema needs to be updated, correct? I just went through some mymonero code and it looks like per_byte_fee is now preferred.

latest commit look good? think that's what you meant, would make sense to me

Also will squash before merge. Pretty unnecessary set of commits to keep around


END within method should warn (when using serialization API)

If I run this snippet through parse I see the warning:
def foo; END {}; end

Warnings:
[#<Prism::ParseWarning @message="END in method; use at_exit" @location=#<Prism::Location @start_offset=9 @length=3 start_line=1>>]

AST:
@ ProgramNode (location: (1,0)-(1,20))
├── locals: []
└── statements:
    @ StatementsNode (location: (1,0)-(1,20))
    └── body: (length: 1)
        └── @ DefNode (location: (1,0)-(1,20))
            ├── name: :foo
            ├── name_loc: (1,4)-(1,7) = "foo"
            ├── receiver: ∅
            ├── parameters: ∅
            ├── body:
            │   @ StatementsNode (location: (1,9)-(1,15))
            │   └── body: (length: 1)
            │       └── @ PostExecutionNode (location: (1,9)-(1,15))
            │           ├── statements: ∅
            │           ├── keyword_loc: (1,9)-(1,12) = "END"
            │           ├── opening_loc: (1,13)-(1,14) = "{"
            │           └── closing_loc: (1,14)-(1,15) = "}"
            ├── locals: []
            ├── locals_body_index: 0
            ├── def_keyword_loc: (1,0)-(1,3) = "def"
            ├── operator_loc: ∅
            ├── lparen_loc: ∅
            ├── rparen_loc: ∅
            ├── equal_loc: ∅
            └── end_keyword_loc: (1,17)-(1,20) = "end"

Loader is seeing 0 warnings so this is not making it into the serialized blob.

"def foo; END {}; end".then { |source| Prism.load(source, Prism.dump(source)) }

With this code I'm seeing the warning. Any chance you're setting verbose to nil?

Perhaps the issue is not all warnings only emit is verbose is true.  This I think is one of those?

Oh no really? I thought everything checked verbose. I'll see what I can find out.

I just checked with -vw and I also do not see this so I think I probably am not passing verbose in either.

I'm not sure what's going on here exactly. If you set VERBOSE=nil this warning does not appear, if you set VERBOSE=false it does appear. For all of the other warnings I checked, VERBOSE=false also makes them appear.

I think this is indicative that we need to create a centralized Java class to serialize the options going into the JNI/JNR call.

ruby -e 'p $VERBOSE; def foo; END {}; end'
-e:1: warning: END in method; use at_exit
false

This is 3.2.2 with no options.

Right, that makes sense. There's a difference between VERBOSE=nil and VERBOSE=false unfortunately.

I think in our case, you should pass indicate that it's verbose if $VERBOSE != nil

The Java I use is:
metadata.append(runtime.getInstanceConfig().getVerbosity() == RubyInstanceConfig.Verbosity.NIL ? 0 : 1);

So I already do that and confirm it is 1 so unless it is in wrong place I don't know.

oh I think I reversed this value!  supress warnings.

LOL.  I was marking as warnings and not supress warnings.  I think this is my brain just assuming all values are positive assertions and not negative.  It is something I religiously do so I probably just spaced this out.  Sorry for the confusion.

Actually that part of the API will likely need to change or have an extra flag, because there are 3 states for $VERBOSE and some parser warnings warn at false while some only warn at true (and of course none warn at nil):
ruby 3.2.2 (2023-03-30 revision e51014f9c0) [x86_64-linux]
$ ruby -e 'def foo; END {}; end'
-e:1: warning: END in method; use at_exit
$ ruby -e '(1; 2)'
$ ruby -w -e '(1; 2)'
-e:1: warning: unused literal ignored
-e:1: warning: possibly useless use of a literal in void context

I was thinking about this with @andrykonchin the other day, but didn't find an example, but now there is one.
I'll file a separate issue to avoid mixing things.


Set bound intensity pulse

Same as duration pulse, make a intensity pulse bound to prevent negative values

Done.


Fix asserts and crashes caused by skipping function bodies or allowing errors

I ran the stress tester locally with the new TestModule request and found a few new asserts and crashes. I'll run it again with these changes to see if it finds any more. Might actually be able to enable by default - with skipping all function bodies and WMO enabled it took ~30 minutes locally, which includes actually building the projects.

@swift-ci please test

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 5a5ba65bb0392f567e91ab4d45594706d312226e

@swift-ci please test Linux platform

Build failed
Swift Test OS X Platform
Git Sha - 5a5ba65bb0392f567e91ab4d45594706d312226e

@swift-ci please test macOS platform

Good point @xymus, thanks. I've changed the serialization to just skip destructors if they're invalid and we're allowing errors. I also added a further comment to the attribute commits - invalid attributes are already skipped, so:

the verification is a little superfluous (typechecking already has that check)
CustomAttr is a little special in that it isn't set to invalid and is thus serialized (hence the skip during deserialization)

@swift-ci please test


chore(ci): refactor python tests to allow custom docker-compose.yml

Reorganise related test_*.py files in their own separate directory.
This also allows the addition of their own (custom)
docker-compose.yml file.
Note that, consequently, the way the tests are invoked has now changed slightly,
See test/python/README.md and scripts/pytest-tests.sh for details

bors try

Some general questions:
1. Are these tests in separate directories run in parallel?

There is no intention at this time to run the pytests in parallel.
The reason they are in separate directories is so that each directory may contain a docker-compose.yml file.
Thus all tests that require the same docker-compose.yml file can reside in the same directory.
Although there is no requirement that they must do so as the directory structure can be used to group logically related tests.
The only rule that needs to be observed is that tests with different container configurations must reside in reside directories

2. The replica_uuid feature mentions about v1 api [here](https://github.com/openebs/mayastor/blob/51367353c05ec4743c01a0d520a920a6c5c68cac/test/python/tests/replica_uuid/features/replica-guid.feature#L17), Shouldn't it be renamed v2?

Possibly. That question should perhaps be directed to the test's author @mtzaurus. However, I would prefer that is addressed in a separate Jira/PR

bors merge

bors merge

bors merge


Alternate mirrors config attribute being ignored

The bug
We have been running into #260 on a regular basis. In an attempt to fix it I configured our CI action with the official hex.pm mirror listed on their site as a backup in case it happens again.
The issue is that it appears that the hexpm-mirrors attribute is being ignored and the alternate mirror is not being attempted. I could be misinterpreting the output though. There is no output indicating that it failed to fetch from the alternate mirror, nor does it show up in the config output when it runs.
Software versions

setup-beam: v1
elixir: 1.16.1
opt: 26.0.2

STR

Configure our action with the default mirror and an alternate. (Maybe use invalid URLs to replicate?)
Run until the action fails to fetch the data.
Notice there's no output in the error indicating that it tried and failed via both mirrors.

Expected behaviour
Based on a quick glance of the code I expect there to be output when it failed attempting to download from each configured mirror.
Example Action Config
- name: Set up Elixir and Erlang
  uses: erlef/setup-beam@v1
  with:
    elixir-version: "1.16.1"
    otp-version: "26.0.2"
    hexpm-mirrors: |
      https://builds.hex.pm
      https://repo.hex.pm

Action Output
Run erlef/setup-beam@v1
  with:
    elixir-version: 1.16.1
    otp-version: 26.0.2
    github-token: ***
    install-hex: true
    install-rebar: true
    version-type: loose
    disable_problem_matchers: false
    hexpm-mirrors: https://builds.hex.pm

  env:
    GITHUB_TOKEN: ***
    ELIXIR_VERSION: 1.16.1
    OTP_VERSION: 26.0.2
Action fetch /builds/otp/ubuntu-22.04/builds.txt failed for mirror https://builds.hex.pm, with Error: Request timeout: /builds/otp/ubuntu-22.04/builds.txt
##[debug]Stacktrace: Error: Request timeout: /builds/otp/ubuntu-22.04/builds.txt
##[debug]    at ClientRequest.<anonymous> (/home/runner/work/_actions/erlef/setup-beam/v1/dist/index.js:2225:26)
##[debug]    at Object.onceWrapper (node:events:628:28)
##[debug]    at ClientRequest.emit (node:events:514:28)
##[debug]    at TLSSocket.emitRequestTimeout (node:_http_client:840:9)
##[debug]    at Object.onceWrapper (node:events:628:28)
##[debug]    at TLSSocket.emit (node:events:526:[35](https://github.com/Veeps-Official/veeps_umbrella/actions/runs/8443612025/job/23127625152#step:3:35))
##[debug]    at Socket._onTimeout (node:net:589:8)
##[debug]    at listOnTimeout (node:internal/timers:573:17)
##[debug]    at process.processTimers (node:internal/timers:514:7)
Error: Could not fetch /builds/otp/ubuntu-22.04/builds.txt from any hex.pm mirror

This was my mistake. After debugging all day I discovered that I'd missed adding hexpm-mirrors to the use of this action in one of the other steps. Sorry about that!


[Bugfix][Kernel] Add IQ1_M quantization implementation to GGUF kernel

FILL IN THE PR DESCRIPTION HERE
FIX #8321  (link existing issues this PR will resolve)

This PR adds IQ1_M quantization implementation to GGUF kernel, which is not included in previous kernel.
This PR also adds kernel test to cover most of quantization type.

TODO

[x] Add IQ1_M dequantize implementation.
[x] Add IQ1_M MMVQ implementation and enable MMVQ during forwarding.
[x] Refactor test to cover most of quantization Add kernel test.

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

cc @mgoin


RFC for granting priviledges in snowflake

I am trying to figure out the resource schemas for granting privileges in snowflake.
Below is a doc where I have some examples of how it could work. Please give feedback.

A few thoughts:

Thanks for starting this!
s/priviledges/privileges/g
Just wanted to check my understanding, this is just how we assign privileges to roles? Users -> roles is another exercise?
I think generally on the questions about how many permissions to enable to be nested in a single grant we should drive towards simplicity which to me would say let's make it easy to grant a ton of access in a single resource. I think that generally means we end up with one resource per role which is cognitively nice.


Added support for argparse groups

Now sphinx-argparse understands the action groups encoded in argparse and properly formats the documentation. For an example, simply rebuild the html documentation. I updated the tests and the sample.py.
In the original code, to get the optional arguments a call to parser._get_optional_actions() was done. In the new version optional arguments are found from by iterating over parser._action_groups. I searched argparse itself prepares the documentation and the way they do it is by iterating over _action_groups.

@fidelram Can you check the "Allow edits from maintainers" box? I can resolve the merge conflicts then.

@fidelram: I think I've implemented this now in the feature/groups branch. Can you check if this implements what you want properly.

@dpryan79 done ""Allow edits from maintainers"

I've merged the reimplementation.


Update create_pcm_archive.sh

select parts button in JLCPCB tools does not work.
  File "C:\Users\Takahiro\Documents\KiCad\6.0\3rdparty\plugins\com_github_bouni_kicad-jlcpcb-tools\plugin.py", line 22, in Run
    dialog = JLCPCBTools(None)
  File "C:\Users\Takahiro\Documents\KiCad\6.0\3rdparty\plugins\com_github_bouni_kicad-jlcpcb-tools\mainwindow.py", line 519, in __init__
    self.logger.info(f"kicad-jlcpcb-tools version {getVersion()}")
Message: 'kicad-jlcpcb-tools version 2022.04.01\n'

To solve this problem, update create_pcm_archives.sh to include settings.json to release

Good catch, thanks for your PR!


Security Issue with SharePoint Connection

Description
Please correct me if I am wrong, but as far as I understand the app user has to have read and write access on the "Teams Requests"-List, because within PowerApps the SharePoint Connector always works in the context of the current user. And we use that very same connector to

Read from the List when we open "My Requests"
write to the List when we go past the 2nd Step (as soon as we enter the team-name)

That means that by design every user in my organization, who wants to use the app, must be granted read and write permissions on that list.
But what stops a user from simply opening the SharePoint List in the browser and creating a new entry with an "Approved" status, hereby triggering the logic app, that will actually create a new team without any approvement?
Steps to reproduce

Open SharePoint
Login as normal user
Edit the list (create new entry or self-approve another Pending entry by editing the status)

Expected results
List cant be edited
Actual Results
Logic App is triggered - team is created
Solution component
Power App
Operating system (environment)
Windows
Additional Info
No response

Can an update be provided for this issue please? Still waiting triage since 08 2022!


fix: remove log on api wrapper

Describe your changes
Trying out minor change to help performance and to use it to deploy a change
Type of change 🧩

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Other (please explain in the description section above)

Checklist before requesting a review

[ ] I have performed a self-review of my own code
[ ] I have double checked this work does not include any hardcoded secrets or passwords
[ ] I have made corresponding changes to the documentation
[ ] I have provided details on how I have tested my code
[ ] I have referenced the ticket number above
[ ] I have provided a description of the ticket
[ ] I have included unit tests to cover any testable code changes

:tada: This PR is included in version 2.38.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.33.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix ambiguous async read on default token

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.21%. Comparing base (64e1720) to head (3a38b24).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #240   +/-   ##
=======================================
  Coverage   89.20%   89.21%
=======================================
  Files         121      121
  Lines        7988     7994    +6
=======================================
+ Hits         7126     7132    +6
  Misses        862      862

Files
Coverage Δ

...sync_mqtt/predefined_layer/impl/mqtt_handshake.hpp
95.00% <100.00%> (+0.26%)
:arrow_up:

...nclude/async_mqtt/util/impl/stream_read_packet.hpp
92.62% <100.00%> (+0.25%)
:arrow_up:


Fake news Detection model

Is your feature request related to a problem? Please describe.
I want to add this new project to the repository
Describe the solution you'd like
A supervised learning bases fake news detection model
Describe alternatives you've considered
No response
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi, we have many similar issues. Hence, we cannot assign you this issue.


Is it possible to print %VAR_COUNT%, also noted the duplication of a last entry in .csv

I had a need to produce some numbered tickets, many on the same page, and used SG for the purpose. It worked well enough, taking a sequence from a data file (1..N), although the very last number repeated a few times, filling the remaining tickets on the page. No big deal, but it would be nice if the program stop when reaching the last entry in the data file.
I also noticed, that there is a variable %VAR_COUNT%, which could be used for the file naming. That would be also useable for numbering, but when I tried it in the source file, it printed nothing. Would be nice to have access to it, too.
Enclosed are .sla test file, and simple data file.
Last but not least, thanks a lot for the wonderful and valuable script. I used it earlier for making diplomas for the musical school and musical festivals.
testseqnumbering__single.pdf
testseqnumbering.csv
testseqnumbering.sla.zip

done. please check. thanks for your feedback.


Pull request for hunspell

For travis-ci/travis-ci#42.
Ran tests and found no setuid bits.
See https://travis-ci.org/travis-ci/apt-whitelist-checker/builds/71947926

Needs to be deleted in order to refine the process (and create a new PR)


Can't access pagination info in the header

Hi, I'm trying to access Link field in the header to build my pagination. I use axios.
I only get:
x-total-count: "500",
pragma: "no-cache",
content-type: "application/json;
charset=utf-8",
cache-control: "no-cache",
expires: "-1"

what I see in my chrome dev tool
Access-Control-Allow-Credentials:true
Access-Control-Allow-Origin:http://<IP_ADDRESS>:3000
Access-Control-Expose-Headers:X-Total-Count, Links
Cache-Control:no-cache
Connection:keep-alive
Content-Encoding:gzip
Content-Type:application/json; charset=utf-8
Date:Wed, 02 Nov 2016 15:10:57 GMT
ETag:W/"2606-KzmHaw5B5nHWkO2sfZlE0w"
Expires:-1
Link:<http://localhost:3001/articles?_sort=lastHourViews&_order=ASC&_page=1>; rel="first", <http://localhost:3001/articles?_sort=lastHourViews&_order=ASC&_page=2>; rel="next", <http://localhost:3001/articles?_sort=lastHourViews&_order=ASC&_page=50>; rel="last"
Pragma:no-cache
Transfer-Encoding:chunked
Vary:Origin, Accept-Encoding
X-Content-Type-Options:nosniff
X-Powered-By:Express
X-Total-Count:500

I think Links is being exposed rather than Link.

@vpanjganj yes good catch 👍 do you want to make a PR?
https://github.com/typicode/json-server/blob/master/src/server/router/plural.js#L156

@typicode sure.

@typicode, I made a PR: https://github.com/typicode/json-server/pull/394


Tidy up the documentation.

A few things have come up recently that would be good to write down quick intros for in the documentation, at least before a big public release:

[ ] explain how to retrieve the injected transit and systematics parameters, to provide a nice test case for anyone's multiwavelength fits
[ ] add a page for general helper functions, for example things like bintogrid and bintoR, or the one2another colormap. It shouldn't be front and center, but I've suggested those functions to folks frequently enough that they should probably have their own page
[ ] add a page for interacting with models, including getting the residuals, various plots and metrics, and more

[ ] We should the shortest possible example for someone to create rainbow from scratch, perhaps as a section on the existing "create from arrays" page.

[ ] Make sure the .help tables are up-to-date with all recent changes.

[ ] Add a tiny bit of description for some of the standard output formats (.rainbow.npy, .rainbow.fits, xarray_[...]) to make it easier for folks to read them without chromatic.

The general helper functions are now described under "Related Tools" at https://zkbt.github.io/chromatic/.

I'm closing this Issue for now. The job of getting the documentation right is going to be infinite, but let's call this list of actions done, and move on to more!


Add MangaOnline

Closes  #405
Checklist:

[x] Updated extVersionCode value in build.gradle for individual extensions
[ ] Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
[x] Referenced all related issues in the PR body (e.g. "Closes #xyz")
[x] Added the isNsfw = true flag in build.gradle when appropriate
[ ] Have not changed source names
[ ] Have explicitly kept the id if a source's name or language were changed
[x] Have tested the modifications by compiling and running the extension through Android Studio
[x] Have removed web_hi_res_512.png when adding a new extension

merged in #1610
you may add the deeplink in a follow up pr.


[NETBEANS-54] Module Review jellytools.platform

Thanks for the review — and will follow your insights here ASAP.

OK, removed the license as suggested by @junichi11.

Thank you for fixing it!
We can exclude version_info from rat as well as *.mf.
https://github.com/apache/incubator-netbeans/blob/19ec0a5a4d7183ff3c201c804c63f1fbef938392/nbbuild/build.xml#L1979

Thanks a lot for the support, and merging.


Do not override static_assert for C++

Fixes https://github.com/XboxDev/nxdk/issues/598

Change looks good, I've allowed myself to modify the commit title to match our convention. Thanks!


Abbreviations can't be used until async paint is done

It seems like if I try to use an abbreviation too soon after a prompt is initially painted, abbreviations aren't available. If I wait a few moments, presumably after the async bit is resolved, abbreviations work as expected again. Does this sound plausible?
https://user-images.githubusercontent.com/967145/148860567-60439bf5-142a-4350-8d50-7fa3204b20b5.mp4

Nevermind…I was doing something weird in my init.fish.


OSX filesystem support

Hi!  I've added some code to handle OSX specific file copying.  The Dart libs don't handle copying symlinks well and the archive lib has a similar problem.  For OSX, I think it may just be better to use the native CLI tools "cp" and "unzip" to get around this for now.
I also bumped up the hard coded electron version.
Cheers!

Thanks a bunch! I don't own a mac so I was hoping someone would come in and take care of the OSX stuff.

Happy to help.  Thanks for making this lib!


Logs is not showing values

I noticed that the logs do not display the values (numbers) that the player entered. For example, what speed he gave himself, etc. Thanks for fixing it!

Download
https://www.dropbox.com/scl/fi/ku9a1wblqyb84rb8ekase/fix.zip?rlkey=8763vim31xfgywjgy217yb8lh&st=gbp0kafn&dl=1
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file password: changeme In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."


Podman hangs on: podman run -it --rm ...

/kind bug
Description
podman run --interactive --tty --rm yelgeb/inselelo:0.0.27 bash delivers the shell prompt then hangs.
Steps to reproduce the issue:

Execute
strace -ostrace.log podman run --interactive --tty --rm yelgeb/inselelo:0.0.27 bash

Describe the results you received:
The strace.log is attached: strace.zip
$ strace -ostrace.log podman run --interactive --tty --rm yelgeb/inselelo:0.0.27 bash
root@6adf51051ce9:/#

The user input ls is not accepted.  No error is thrown.
Describe the results you expected:
Directory listing.
Additional information you deem important (e.g. issue happens only occasionally):
Happens always.
Output of podman version:
$ podman version
Version:            1.9.3
RemoteAPI Version:  1
Go Version:         go1.10.1
OS/Arch:            linux/amd64

Output of podman info --debug:
debug:
  compiler: gc
  gitCommit: ""
  goVersion: go1.10.1
  podmanVersion: 1.9.3
host:
  arch: amd64
  buildahVersion: 1.14.9
  cgroupVersion: v1
  conmon:
    package: 'conmon: /usr/libexec/podman/conmon'
    path: /usr/libexec/podman/conmon
    version: 'conmon version 2.0.16, commit: '
  cpus: 2
  distribution:
    distribution: ubuntu
    version: "18.04"
  eventLogger: file
  hostname: desktop.local.lan
  idMappings:
    gidmap:
    - container_id: 0
      host_id: 1000
      size: 1
    - container_id: 1
      host_id: 100000
      size: 65536
    uidmap:
    - container_id: 0
      host_id: 1000
      size: 1
    - container_id: 1
      host_id: 100000
      size: 65536
  kernel: 5.3.0-40-generic
  memFree: 932093952
  memTotal:<PHONE_NUMBER>6
  ociRuntime:
    name: runc
    package: 'containerd.io: /usr/bin/runc'
    path: /usr/bin/runc
    version: |-
      runc version 1.0.0-rc10
      commit: dc9208a3303feef5b3839f4323d9beb36df0a9dd
      spec: 1.0.1-dev
  os: linux
  rootless: true
  slirp4netns:
    executable: /usr/bin/slirp4netns
    package: 'slirp4netns: /usr/bin/slirp4netns'
    version: |-
      slirp4netns version 0.4.3
      commit: unknown
  swapFree:<PHONE_NUMBER>
  swapTotal:<PHONE_NUMBER>
  uptime: 275h 50m 28.85s (Approximately 11.46 days)
registries:
  search:
  - docker.io
  - quay.io
store:
  configFile: /home/hedge/.config/containers/storage.conf
  containerStore:
    number: 2
    paused: 0
    running: 1
    stopped: 1
  graphDriverName: vfs
  graphOptions: {}
  graphRoot: /home/hedge/.local/share/containers/storage
  graphStatus: {}
  imageStore:
    number: 2
  runRoot: /run/user/1000/containers
  volumePath: /home/hedge/.local/share/containers/storage/volumes

Package info (e.g. output of rpm -q podman or apt list podman):
$ apt list podman
Listing... Done
podman/unknown,now 1.9.3~1 amd64 [installe
d]

Additional environment details (AWS, VirtualBox, physical, etc.):
Physical.

Can you upload your image to DockerHub? I have no problem testing with other images
# podman   run -ti --rm  docker.io/library/nginx:alpine sh
Trying to pull docker.io/library/nginx:alpine...
Getting image source signatures
Copying blob cbdbe7a5bc2a skipped: already exists
Copying blob 10c113fb0c77 done
Copying blob 262f9908119d done
Copying blob c4a057508f96 done
Copying blob 9ba64393807b done
Copying config 7d0cdcc60a done
Writing manifest to image destination
Storing signatures
/ # ls
bin                   docker-entrypoint.d   etc                   lib                   mnt                   proc                  run                   srv                   tmp                   var
dev                   docker-entrypoint.sh  home                  media                 opt                   root                  sbin                  sys                   usr

You're not redirecting anything in the container, right? E.g. podman run -t -i fedora bash < echo ls

@mheon correct, no redirection. I've moved on and redesigned our workflow.  Will reopen with a reproducible example.


Bugfix/2452 Links in footer to static pages bug

Related issues
closes https://github.com/DivanteLtd/vue-storefront/issues/2452
Short description and why it's useful
I solved an issue by adding a watcher to a $route.name param and added a 2nd example of  static page to not confuse users with only one static page ;)
Upgrade Notes and Changelog

[x] No upgrade steps required (100% backward compatibility)
[x] I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and currently important rules acceptance

[ ] I read and followed contribution rules
[ ] I read the TypeScript Action Plan and adjusted my PR according to it
[ ] I read about Vue Storefront Modules and I am aware that every new feature should be a module

It's in changelog, no upg notes required here

Also this needs to wait for a store depreciation to be merged in, i accidentally started from a . wrong branch

Even after merge it still show already merged commits.
Here js the file i changed https://github.com/DivanteLtd/vue-storefront/pull/2464/files#diff-53623d3d96444676ad00f4011dfaafe2


Refactor/fix Docker

Refactors/fixes the Docker version of the Python Matter server.

Bumps base image to use official Python-provided Docker images

Based on Debian Bulleyes
Using Python 3.10

Rename legacy docker-compose.yml to current default compose.yml
Update readme to remove legacy commands; removed unneeded container reference in commands.
Some small styling & typo squatting.

Tested and worked against the integration currently in the Home Assistant dev branch.
../Frenck
fixes #214

No problem

can you enable github actions so docker images are build? it's free and we can stay updated instead of rebuilding the image each version.

can you enable github actions so docker images are build?

At this point, this is development/test method.

@rursache Yeah, me helping out here for a bit and responding promptly to your question above (which was more an unrelated feature request to this PR), deserves a thumbs down 👎 on my response? Thanks, @rursache appreciated 👍

Having docker images build is so basic and easy to setup once and forget while ALL users will benefit is so obvious that I had no intention to go intro arguing with you. Getting upset over emojis is also really childish.
I made this if it's considered help.

Having docker images build is so basic and easy to setup once and forget while ALL users will benefit.

Sure, but also need to be maintained. The project explicitly did choose not to do that at this point. Which I respect (and not my call). I did reach out to check if it was wished for.
Adding it would be trivial right now. However, considering your thumbs-down response isn't really motivating, I don't see why I would spend time on it. It is the signal you are sending with it, that is not right.

Getting upset over emojis is also really childish.

Right, thanks again. I will consider that an insult 👍
../Frenck


Retry

As described in #329 .
Any suggestion how to write a test for this?

Hi Christian. Sorry about the delay.
I'm not sure this can be tested automatically without mocking the http agent. It's probably sufficient for now if the tests still pass, which they do.
Can you rebase this on the latest master so we can merge it?

No, I can't rebase this. There have been too many changes in connection.js since I worked on this.


[WIP] Text behavior enhancement

Enhance text behavior to support multi line capture
To support multi line capture, this draft is acting on widget text_behavior.

rebased on new structure (#448)
it substitutes an older attempt (#380)

Status

With the given RFC, you can separate lines in a TextBox widget. Typing "Ctrl+Enter" while you edit the content of the given TextBox will insert a '\n'.

The renderer (TinySkia) will recognize the insertet '\n' and split the line as expected. Never the less, cursor handling is broken. And i haven't made any attempts to get the constraints of the TextBox right.

There is a first example: text_behavior

Further work needed
Adaption needs to aggree on a concept that will solve the following topics

auto resize the widget size of the TextBox (up to the defined max_height)
auto resize the widget size of the TextBox (up to the defined max_width)
enable a ScrollIndicator (horizontal and vertical).
If line number gets bigger than the visible number of lines inside the TextBox, or number of characters will get bigger than the visible box size, a scroll bar should help to move the addressed text area.

Contribution checklist:

[X] Add documentation to all public structs, traits and functions.
[X] Run cargo fmt to make the formatting consistent across the codebase
[X] Run cargo clippy to check with the linter# Context:
[X] Describe the major change(s) in the CHANGELOG.MD

Redox moved to GitLab years ago, thus if you still want to merge it, move this pull request to there.
If you still want to contribute to Redox, talk with us in the Matrix chat.


Docs: WritableStream -> WriteStream

I am not pretty sure about this one though.
Because it writes WriteStream in another place
Actually, in fs it is called fs.WriteStream but the underlying class/interface is stream.Writable. I am not sure what it is referring to...

Coverage remained the same at 100.0% when pulling da96c27da3c2dc94bfbef03ccbcea06c141acaee on kevinresol:patch-3 into b94126be1c9aef1b561ff50b968c12563e5ae70e on GoogleCloudPlatform:master.

I think we should favor WritableStream, which is just to say we are returning a stream that is writable. Do you mind basically reversing this PR and changing it in the other file that you found WriteStream?

No problem. Do you want to change ReadStream to ReadableStream as well then?

I went ahead changing readstream to readable stream. Also added the missing return type for File.create(read/write)stream

Coverage remained the same at 100.0% when pulling 3fe8bac6245b972e3accd64778a45205bcae6210 on kevinresol:patch-3 into b94126be1c9aef1b561ff50b968c12563e5ae70e on GoogleCloudPlatform:master.

Perfect! Thanks again :)


[Misc] Temporarily resolve the error of BitAndBytes

FIX https://github.com/vllm-project/vllm/issues/7294
ping @mgoin

/ready


fix: remove scroll bar

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[x] Bugfix
[ ] Feature
[ ] Refactoring

What's new?

[x] PR closes #2685
[ ] <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[x] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[x] I've tested PR on mobile and everything seems works
[x] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

pay 100 usd
amazing!

😍 Perfect, I’ve sent the payout
💵 $100 @ 167.37 USD/KSM ~ 0.597 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x25b5e721c7001c5e13888db047c0aea1aeeb5d9b470fe28b5c0300b192ed811b
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


Fixed issue #303

Description
Fixed issue #303
Type of change

Bug fix (non-breaking change which fixes an issue)

Testing steps
Done on CI
Checklist

[ ] make before_commit passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report
Base: 5.77% // Head: 5.77% // No change to project coverage :thumbsup:

Coverage data is based on head (d541080) compared to base (fe9eb96).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #317   +/-   ##
======================================
  Coverage    5.77%   5.77%
======================================
  Files          15      15
  Lines         848     848
======================================
  Hits           49      49
  Misses        799     799

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Mk2Expansion.netkan

Updates dependencies for M2X 1.6.10

You aren't editing the existing .netkan file. Here is the correct path on your fork: https://github.com/SuicidalInsanity/NetKAN/blob/patch-1/NetKAN/Mk2Expansion.netkan


Git Ignore .idea settings files

adding .idea folder into .gitignore

fix: #49

Done

@MortarDefender please ask CR from your team members


rbd: return error if last sync time not present

As per the csiaddon spec, last sync time is a required parameter in the GetVolumeReplicationInfo if we are failed to parse the description, we return an error message instead of nil which is an empty response.
Signed-off-by: Madhu Rajanna<EMAIL_ADDRESS>Note:- skipping E2E as we dont have CI for DR
Note:- Replacement for https://github.com/ceph/ceph-csi/pull/3478 after discussion in csiaddons spec.

@ShyamsundarR PTAL at last commit. This check was missing, and cephcsi was returning an empty response.

@ShyamsundarR PTAL at last commit. This check was missing, and cephcsi was returning an empty response.

Thanks, I am only looking at overall structural correctness (hence not hitting the approved button). @yati1998 assuming you are taking a closer look?

@mergifyio rebase


docs: fix typo on decorator property docs

There seems to be some typos on docs to fix 👻.
Please check if I got them right.

Codecov Report
Base: 99.80% // Head: 99.80% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (a127786) compared to base (44145bf).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3919   +/-   ##
=======================================
  Coverage   99.80%   99.80%
=======================================
  Files         214      214
  Lines       13644    13651    +7
  Branches     3187     3189    +2
=======================================
+ Hits        13618    13625    +7
  Misses         24       24
  Partials        2        2

Impacted Files
Coverage Δ

packages/mongodb/src/MongoDriver.ts
100.00% <0.00%> (ø)

packages/knex/src/query/QueryBuilder.ts
100.00% <0.00%> (ø)

packages/core/src/entity/EntityHelper.ts
100.00% <0.00%> (ø)

packages/core/src/utils/EntityComparator.ts
100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


CIP-1775? | Delegated Spending Authorizations

Allow users to delegate authorized spending of outputs in their wallets to smart contracts or other users, without sending said outputs out of their wallets.
This brings benefits to Cardano users when interacting with existing dapps and opens up new use cases, like noncustodial asset management, concurrent use of dapps and seamless integration with sidechains.

I get the motivation, but I don't think this is a good idea.
There are two unrelated issues here:

Protocols some times don't respect staking. Those protocols are buggy. Don't use them.
Wallets don't show where your funds are in custom protocols. This is harder, but essentially entirely a wallet issue. Wallets need to be fixed.

You could imagine there being some wallet-protocol interoperation ABI specification language, such that the wallet can provide limited information about where your funds are.

@L-as:

I get the motivation, but I don't think this is a good idea. There are two unrelated issues here:

Protocols some times don't respect staking. Those protocols are buggy. Don't use them.

Can you name a few that do? I used a few DEXes (MuesliSwap, SundaeSwap, Minswap, WingRiders), and none of them offered me my staking rewards back for the time my ADA was in their custody.

Wallets don't show where your funds are in custom protocols. This is harder, but essentially entirely a wallet issue. Wallets need to be fixed.

Is there a uniform way to reflect ownership of assets in Cardano? (For the assets sent to dApps, I mean.) Genuinely curious. But even if it exists, it cannot be enforced.

You could imagine there being some wallet-protocol interoperation ABI specification language, such that the wallet can provide limited information about where your funds are.

Would make a nice CIP idea 😉

@L-as

Can you name a few that do? I used a few DEXes (MuesliSwap, SundaeSwap, Minswap, WingRiders), and none of them offered me my staking rewards back for the time my ADA was in their custody.

Indigo protocol uses franken-addresses to let you keep your staking rewards on your Ada locked in its CDPs.  Also I believe that AXO's "programmable swaps" intends to do the same - though it is not released yet.

Indigo protocol uses franken-addresses to let you keep your staking rewards on your Ada locked in its CDPs.

Curious about franken-addresses. Can you provide any links?

Also I believe that AXO's "programmable swaps" intends to do the same - though it is not released yet.

Axo's Jarek talking about this was actually an inspiration to write this CIP. And wouldn't it be nice to be able to use any DApp this way?

Franken addresses video by @AndrewWestberg https://youtu.be/KULzovfWn-M

Ledger specifications for Cardano addresses on page 114 of https://hydra.iohk.io/build/7918420/download/1/ledger-spec.pdf

Is there a uniform way to reflect ownership of assets in Cardano? (For the assets sent to dApps, I mean.) Genuinely curious. But even if it exists, it cannot be enforced.

Shitty protocols will always exist.

You could imagine there being some wallet-protocol interoperation ABI specification language, such that the wallet can provide limited information about where your funds are.

Would make a nice CIP idea 😉

Yes, definitely. I might make one in the future after my work on our Plutus Specification Language.

@KtorZ Thank you for taking a look!

While I like the motivation behind the proposal, I don't think that the proposed designed would work for it allows multiple actors to get a hold of some funds without actually ensuring that funds will be available when they need to spend them.

We can address that.
It is specifically called out that only wallet addresses will support delegated spending authorizations. So, assets sent to a script are still only controlled by the script.

Consider even only the case where there's a single delegated authorization. There's nothing preventing a user from withdrawing their funds into a different UTxO, leaving any contract relying on the original funds screwed. While I can think of use cases where this makes sense, I can also think of problematic ones (e.g. An auction). Moving (and thus, locking) funds into contract is a fundamental part that makes many DApps work.

I can see your concern for existing Plutus scripts expecting to have exclusive control of an output, while the output might be in a wallet and could be spent without script's "consent".
Maybe we could require that only Plutus v3 (or higher) scripts can participate in DSAs, and make DSAs available via script context. Scripts relying on asset locking would easily confirm exclusive control of them.
As an added benefit, we can also allow DSAs to work the same way for outputs located at Plutus v3 script addresses. This would open up even more use cases: imagine being able to add functionality while keeping existing scripts.

Having said that, I think it would be possible to achieve a similar set of goals from the one highlighted in this document by working on a common conventionnal definition of a 'managed account' via contract. Said differently, instead of modifying the core structure of an output, we could imagine designing a script whose sole purpose is to be a façade for other DApps. DApps would have to explicitly embrace working with these special script-locked inputs as part of their contracts, but it would give nice extra benefits to users (and consequently, alleviate DApps from having to consider things like cancelation or reimbursement). This is very vague but, feels like a track worth exploring 🤔

Not a bad idea. Yet, more complicated:

for the end user - yet another script to trust,
for the DApps - changes to script context, perhaps even not as simple as adding a field with a map of authorized spenders.

@L-as @KtorZ @TerminadaPool @AndrewWestberg
Thank you all for the feedback! The text should be ready for another look.

Having said that, I think it would be possible to achieve a similar set of goals from the one highlighted in this document by working on a common conventionnal definition of a 'managed account' via contract. Said differently, instead of modifying the core structure of an output, we could imagine designing a script whose sole purpose is to be a façade for other DApps. DApps would have to explicitly embrace working with these special script-locked inputs as part of their contracts, but it would give nice extra benefits to users (and consequently, alleviate DApps from having to consider things like cancelation or reimbursement). This is very vague but, feels like a track worth exploring 🤔

@KtorZ, did you have a chance to take a look at #309 yet (posted by @SebastienGllmt)? It does look pretty much just like what you were suggesting. Interpretation of the referred scripts needs clarification (which I'm suggesting to add here), but otherwise looks promising.

@imikushin @AndrewWestberg In my experience, the loss of custody is more of a consequence of the way Dapps are designed rather than the "law". As a counter example, I created a DEX proof-of-concept where users DO NOT give up custody of their assets nor do they pool assets together into a liquidity pool. They also maintain full delegation control of their assets at all times. I open-sourced it and it can be found here.
Everything is explained in the README but the main idea is to give all users their own personal smart contract instance which they uniquely control. This alone is a major paradigm shift in the way Dapps are designed. Then finding all of the other users is done using Beacon Tokens. There is still room for improvement but given your perspectives, I am curious of your thoughts.

I just added the desired behavior of this CIP as one of the motivation in CIP-38  https://github.com/cardano-foundation/CIPs/pull/309

@imikushin this was never disqualified in the review process but was never pushed forward either (in a long time now).  The idea seems no less relevant today than it did 1½ years ago but we have to close this PR if nothing further is going to happen with the proposal... I'm marking it Abandoned based on this assumption in the meantime.
Please let us know if you'd like to press this forward; if so I'll put on the next CIP meeting agenda to reconfirm the need, confirm that any remaining issues are addressed, and assign a properly sequential CIP number.  Failing that (or any reviewer wanting to take up this proposal in your stead) this would be closed some time later when tagged Abandoned proposals are cleaned up.
cc (reviewers so far): @L-as @KtorZ @TerminadaPool @AndrewWestberg @SebastienGllmt @fallen-icarus

@rphair glad to hear this still seems relevant to people. I'd love to resume working on this if there's interest.  So, if there's anyone still interested in this, please react to this comment.

Thank you @imikushin - without confirmation of such interest we will have to close this for now.  If similar issues come up in the future I'll try to make a note here so you might better gauge the community need to reopen this proposal submission.


[DatePick] support bordered-less style and disable one of range picker

nzBorderless has bee added in https://github.com/NG-ZORRO/ng-zorro-antd/pull/5975.


Rename exposed types

Changed

Renamed exposed API types.
Renamed TaskScope to BindingScope

Codecov Report

Merging #61 (bdd3595) into master (3e8a26c) will decrease coverage by 0.65%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   98.10%   97.44%   -0.66%
==========================================
  Files          62       51      -11
  Lines        1054      783     -271
  Branches      126      105      -21
==========================================
- Hits         1034      763     -271
  Misses         18       18
  Partials        2        2

Flag
Coverage Δ

cuaktask
93.18% <ø> (ø)

iocuak
97.48% <100.00%> (ø)

porygon
100.00% <100.00%> (ø)

porygon-typeorm
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...kages/iocuak/src/metadata/decorators/injectable.ts
100.00% <100.00%> (ø)

.../iocuak/src/metadata/models/api/BindingScopeApi.ts
100.00% <100.00%> (ø)

...ata/models/api/bindingScopeApiToBindingScopeMap.ts
100.00% <100.00%> (ø)

...ata/models/api/bindingScopeToBindingScopeApiMap.ts
100.00% <100.00%> (ø)

.../iocuak/src/metadata/models/domain/BindingScope.ts
100.00% <100.00%> (ø)

...c/metadata/utils/api/convertBindingToBindingApi.ts
100.00% <100.00%> (ø)

...uak/src/task/models/cuaktask/CreateInstanceTask.ts
100.00% <100.00%> (ø)

...crud/modules/iocuak/DomainCreateContainerModule.ts
100.00% <100.00%> (ø)

...c/crud/modules/iocuak/DomainCrudContainerModule.ts
100.00% <100.00%> (ø)

...crud/modules/iocuak/DomainDeleteContainerModule.ts
100.00% <100.00%> (ø)

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8c3289...bdd3595. Read the comment docs.


feat: adding jest and unit tests

feat: created few tests for transaction.event.mapper and transaction.event.service illustrating how things can be mocked
feat: adding jest.config to support Typescript in tests
chore: adding npm run test script in package.json and a run configuration to run tests

Outdated.


Add typescript definition

(follow up to #16 from @threedayAAAAA)
Fixes https://github.com/dcousens/is-sorted/issues/15
This pull request only adds the minimal Typescript definition required, which is exponentially easier to maintain for such a small package.

@threedayAAAAA I'd appreciate your review and testing :+1:

@threedayAAAAA if you want to review this pull request, that would be appreciated


Have the ability to modify the default variable from @xenova/transformers ?

Sometimes I need to change the HF_ENDPOINT in @xenova/transformers. But I can't find a way to do so when I use in llamaindex.
I find @xenova/transformers have a api env Could modify the remoteHost, Would you please also expose this API and let me modify it ?
Thanks.

@abcfy2 why does import { env } from '@xenova/transformers'; not work?

@abcfy2 why does import { env } from '@xenova/transformers'; not work?

This will not working as expect:
import { env } from "@xenova/transformers";
import { HuggingFaceEmbedding, Settings } from "llamaindex";

env.remoteHost = "https://hf-mirror.com/";
Settings.embedModel = new HuggingFaceEmbedding();

I guess the reason is import is asynchronous. So before env.remoteHost = "https://hf-mirror.com/";, @xenova/transformers may initialized by llamaindex. So modify env is no longer working.

does it work to import it later lazily?
export async function lazyLoadTransformers() {
    transformer = await import("@xenova/transformers");
    transformer.env.remoteHost = "https://hf-mirror.com/"
}

Yes. It's working. I modified this file: https://github.com/run-llama/LlamaIndexTS/blob/main/packages/llamaindex/src/internal/deps/transformers.ts#L5
And build locally then installed to my project. It's working.

Yes. It's working. I modified this file:
main/packages/llamaindex/src/internal/deps/transformers.ts#L5
And build locally then installed to my project. It's working.
So I think we can export env api from transformers.ts, and let other codes could modify it. Or allow environment variables to modify env.

It's a tricky thing that @xenova/transformers doesn't have bad support on non-nodejs runtime so I had to make it async. Yeah I think we could move to env package and make empty export for non-nodejs environment

Now you can do by this way
Settings.callbackManager.on("load-transformers", event => {
  const { transformers } = event.detail
  transformers.env.xxx = false
});

Now you can do by this way
Settings.callbackManager.on("load-transformers", event => {
  const { transformers } = event.detail
  transformers.env.xxx = false
});

Great. Thank you.


test_selfmonitoring_dashboard::test_remove occasionally fails

Bug Description
After removing prom,
await ops_test.model.applications[prometheus_app_name].remove()

The test makes an assertion
relation_removed_dashboards = await get_grafana_dashboards(ops_test, grafana_app_name, 0)
assert relation_removed_dashboards == []

That fails. Occasionally.
https://github.com/canonical/grafana-k8s-operator/actions/runs/3177380221/jobs/5177760631#step:5:801
To Reproduce
Run itests.
Environment
GitHub runner
Relevant log output
Traceback (most recent call last):
  File "/home/runner/work/grafana-k8s-operator/grafana-k8s-operator/tests/integration/test_selfmonitoring_dashboard.py", line 88, in test_remove
    assert relation_removed_dashboards == []
AssertionError: assert [{'id': 1, 'i...eta': 0, ...}] == []
  Left contains one more item: {'id': 1, 'isStarred': False, 'slug': '', 'sortMeta': 0, ...}
  Full diff:
    [
  -  ,
  +  {'id': 1,
  +   'isStarred': False,
  +   'slug': '',...

Additional context
No response

Seems like it fails more frequently now
https://github.com/canonical/grafana-k8s-operator/actions/runs/3184129557/jobs/5199389512#step:5:809

This was actually flaky before, and to make it less flaky, removing the "self-monitoring" relation actually completely restarts Grafana after deleting the provisioning file. I'll try with microk8s 1.25 locally to see if I can make this happen more often locally.
It's completely crazy that the ModelConfigChange workaround here increased reliability, because Grafana doesn't use update-status... at all. So that change is affecting Juju behavior only, yet increases reliability of tests in a charm which literally do not respond to that event.

Still flaky:

test_selfmonitoring_dashboard: still fails.
test_grafana_dashboard_relation_data_with_grafana_tester: Test times out after 6h.

Still fails.

Unfortunately, still irrelevant. There's just nothing actionable other than deleting the test or waiting until we move to self-hosted infrastructure. It only fails in GH runners, and only sometimes, and seems to be related to speed or resource starvation.


Added random password generator using python

Hello! Pls check the pr @techyminati

kindly check my pr @techyminati

sure, please do star this repo and follow me if you can :P

sure, please do star this repo and follow me if you can :P

@techyminati is this not duplicate?

I try my best to filter out duplicates and spam most of time :), there is possibility i might have skipped few of them, I'm not a robot :).

I try my best to filter out duplicates and spam most of time :), there is possibility i might have skipped few of them, I'm not a robot :).

@techyminati or are you a robot? Hmmmm sus😁


Move float and int instances into separate modules

Alas, this fails to run because there is some cyclic dependency. Not sure where though. 🤔

I'd recommend trying to improve the cyclic dependency error https://github.com/gluon-lang/gluon/blob/dac02eca4477cd786b6d467ca685fa0098168095/src/import.rs#L236. All the previously imported modules are already in the vec so it should be straightforward to generate a nicer error from it.

Ah, I misremembered thought all std modules were excluded from the implicit prelude but it was only std.types https://github.com/gluon-lang/gluon/blob/dac02eca4477cd786b6d467ca685fa0098168095/src/import.rs#L245


Pxiv - Book content grammatical error

In the last paragraph, the sentence:
"...Lo-Dash as to the files..."
I think should be without the word "as":
"...Lo-Dash to the files..."

Fixed, thanks!


MathCAT crashes on some MathML expressions.

To reproduce:
Using the NVDA MathCAT add-on, attempt to read a MathML expression that causes a crash.
NVDA emits an error tone, and leaves a Python traceback in the log.
Perhaps there's a separate issue for the add-on: would it be possible to log the error without causing a Python traceback (e.g., catch the error, log it and continue)? A major drawback of the current implementation is that the user can't even navigate past the problematic MathML expression to continue reading the document (e.g., with the Down-Arrow key).
The first example is taken from the Wikipedia article on the Fundamental Theorem of Calculus:
https://en.wikipedia.org/wiki/Fundamental_theorem_of_calculus
The second example appears in the Wikipedia entry on elementary algebra:
https://en.wikipedia.org/wiki/Elementary_algebra
Zip file containing instances of the MathML that crash and also the corresponding log files:
mathcat-crashes.zip

The code does catch the error, but needs to return something of the proper format that the call is expecting.


Shortcuts for editing pages

Describe the feature you'd like
I have switched from confluence to BookStack. While most of the features I use are present, there are some things which are worse to use.
Especially on editing I am a big fan of using shortcuts to avoid switching from keyboard to mouse and vice versa.
It would be great if some shortcuts would be present so I want to suggest to add support for them.
The following shortcuts are in massive use on confluence by me and I am missing them in this greate BookStack:

'e' on page view to start editing
ALT+down in a table to add a row below
ALT+up in a table to add a row above
{code} to insert a code block
{tipp} to add a green backgrounded panel

Additionally some colored "emoticons" would be great to provide e.g. some check lists etc. e.g.

(/) for a green check mark
(x) for a red X-cross
(*g) for a green star
(?) for a blue question mark
(!) for yellow exclamation mark

Describe the benefits this would bring to existing BookStack users
Using the shortcuts editing is much easier an faster than permanently switching from keyboard to mouse (esp. in tables).
A switch from confluence is made more smooth
Can the goal of this request already be achieved via other means?
I am currently not aware of some usable possibilities
Have you searched for an existing open/closed issue?

[X] I have searched for existing issues and none cover my fundemental request

How long have you been using BookStack?
6 months to 1 year
Additional context
No response

I have a very similar situation, and I moved from my personal dokuwiki over to bookstack. Over all I actually like it quite a bit better, but one of the biggest ones that gets me every time is that I still automatically hit 'e' every time I'm trying to edit a page. While it's not a huge shift to using the mouse, it's enough to throw me off each time. I use 'e' for both Confluence (enterprise stuff), and my personal dokuwiki. It would be really nice if 'e' at the very least was added, though I like some of the others mentioned above.

@crueber If you go to "My Account > UI Shortcut Preferences" you can enable UI shortcuts to be able to press "e" to edit when viewing a page (or book, chapter etc...).


Revisit reporting quantity for Phoenix Next campaigns w/ disabled quantity field

Phoenix Next campaigns can have quantity field turned off.
Under the hood Phoenix Next would just set quantity on reportbacks for such campaigns to 1. This may be a problem as we anticipate second report back quantity to include quantity from the first one (per discussion with @sbsmith86).
Example:

Member collected 5 pares of jeans
Reported back a photo and  quantity 5
Collected 5 more
Reported back photo and quantity 10

In the case where quantity field turned off, quantity will always be reported as one. Even on the second reportback.
Example:

Member posted a shower songs screenshot
Signup post quantity automatically set to 1
Member posted another one shower songs screenshot
Signup total quantity is still 1

Expected:

Signup post total quantity is 2

To discuss with: @justkika, @ashleybaldwin, @sbsmith86.

I think one thing to get clarity on is if, in the scenario where quantity is turned off, is it in fact expected that the total quantity should be 2 if they post twice.
It could be that if quantity collection is turned off, we don't really care about the quantity. We only want to know if the user did the action or not, so in those cases, we don't really care about the number in the quantity field. We could use the consistent 1 value to signify that the action was done or we could just see how many approved posts they have under the signup.

Thanks, Shae, good point. @justkika we need to go over few use cases and determine whether we need to accumulate quantity across reportback to campaign with quantity field turned on. See examples above.


[CDS-83649] Docs improvement for CDS-83415 (Selector logic for helm d…

…eployment)
Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the CODEOWNERS.
What Type of PR is This?

[x] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

CDS-83649

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[x] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://656454c6a9fd6e1729e564b8--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65645558e2e6881c7c89be72--harness-developer.netlify.app


How do I delete my previus message in the dialog

how to delete my previous message in the dialog?

I imagine that you are referring to how to delete the message of the command /example
If so:
bot.onText(/^/example/, function(msg){
`var messageId = msg.message_id;
bot.deleteMessage(msg.chat.id, messageId)
bot.sendMessage(msg.chat.id, "This is an example"`

Add if it works to close the thread. Thank you


Log query successful but no file created

When running the following in ssms the query completes successfully but no file is created? The host is Ubuntu, details below. Any help appreciated...Chris
EXECUTE dbo.DatabaseBackup
@Databases = '%tm%',
@Directory = '/data/mssql/backup/local/Log/Wednesday',
@BackupType = 'LOG',
@Verify = 'Y',
@CheckSum = 'Y'
SQL Server version and edition
Microsoft SQL Server 2017 (RTM-CU15) (KB4498951) - 14.0.3162.1 (X64)   May 15 2019 19:14:30   Copyright (C) 2017 Microsoft Corporation  Standard Edition (64-bit) on Linux (Ubuntu 18.04.2 LTS)
What output are you getting?
Date and time: 2019-09-11 09:52:52
Server: db-1
Version: 14.0.3162.1
Edition: Standard Edition (64-bit)
Platform: Linux
Procedure: [master].[dbo].[DatabaseBackup]
Parameters: @Databases = '%tm%', @Directory = '/data/mssql/backup/local/Log/Wednesday', @BackupType = 'LOG', @Verify = 'Y', @CleanupTime = NULL, @CleanupMode = 'AFTER_BACKUP', @Compress = NULL, @CopyOnly = 'N', @ChangeBackupType = 'N', @BackupSoftware = NULL, @CheckSum = 'Y', @BlockSize = NULL, @BufferCount = NULL, @MaxTransferSize = NULL, @NumberOfFiles = NULL, @CompressionLevel = NULL, @Description = NULL, @Threads = NULL, @Throttle = NULL, @Encrypt = 'N', @EncryptionAlgorithm = NULL, @ServerCertificate = NULL, @ServerAsymmetricKey = NULL, @EncryptionKey = NULL, @ReadWriteFileGroups = 'N', @OverrideBackupPreference = 'N', @NoRecovery = 'N', @URL = NULL, @Credential = NULL, @MirrorDirectory = NULL, @MirrorCleanupTime = NULL, @MirrorCleanupMode = 'AFTER_BACKUP', @MirrorURL = NULL, @AvailabilityGroups = NULL, @Updateability = 'ALL', @AdaptiveCompression = NULL, @ModificationLevel = NULL, @LogSizeSinceLastLogBackup = NULL, @TimeSinceLastLogBackup = NULL, @DataDomainBoostHost = NULL, @DataDomainBoostUser = NULL, @DataDomainBoostDevicePath = NULL, @DataDomainBoostLockboxPath = NULL, @DirectoryStructure = '{ServerName}${InstanceName}{DirectorySeparator}{DatabaseName}{DirectorySeparator}{BackupType}{Partial}{CopyOnly}', @AvailabilityGroupDirectoryStructure = '{ClusterName}${AvailabilityGroupName}{DirectorySeparator}{DatabaseName}{DirectorySeparator}{BackupType}{Partial}{CopyOnly}', @FileName = '{ServerName}${InstanceName}{DatabaseName}{BackupType}{Partial}{CopyOnly}{Year}{Month}{Day}{Hour}{Minute}{Second}{FileNumber}.{FileExtension}', @AvailabilityGroupFileName = '{ClusterName}${AvailabilityGroupName}{DatabaseName}{BackupType}{Partial}{CopyOnly}{Year}{Month}{Day}{Hour}{Minute}{Second}{FileNumber}.{FileExtension}', @FileExtensionFull = NULL, @FileExtensionDiff = NULL, @FileExtensionLog = NULL, @Init = 'N', @DatabaseOrder = NULL, @DatabasesInParallel = 'N', @LogToTable = 'N', @Execute = 'Y'
Version: 2019-06-14 00:05:34
Source: https://ola.hallengren.com
Date and time: 2019-09-11 09:52:52
Database: [tmDatabase-45]
State: ONLINE
Standby: No
Updateability: READ_WRITE
User access: MULTI_USER
Is accessible: Yes
Recovery model: FULL
Encrypted: No
Differential base LSN:<PHONE_NUMBER>08000037
Last log backup LSN: N/A
Last log backup: N/A
Log size since last log backup (MB): N/A
Date and time: 2019-09-11 09:52:52

It was a user bug :-) A full database hadn't been taken after changing the recovery model from Simple to Full


Add a SBOM template in CycloneDX format

Hi,
My name is Richard Hughes and I'm a developer at Red Hat. I'm the maintainer of fwupd and LVFS, and am trying to improve software supply chain security by encouraging OEMs, ODMs and IBVs to ship Software Bill of Materials with each firmware binary blob (SBOMs).
I'm working alongside lots of other companies proactively trying to do the right thing. The reason I've opened this pull request is because your project is either used in the build process of a firmware we care about (e.g. EDK II, or coreboot) or is built into the firmware binary itself. Although my personal focus is on firmware, the SBOM file is in CycloneDX format (one of the most popular industry standards) which makes it also useful when building containers or OS images too.
I would like to contribute this template SBOM file into your project that gets included into source control with substituted values that get populated automatically. I'm not super familiar with Wuffs, and so I've done my best populating the project values -- but please point out any that are incorrect and I'll fix them up. I've also put the sbom.cdx.json file in what I feel is the right place, but please say if you want me to put it somewhere different or name it a different thing; the directory and sbom prefix are unimportant.
I couldn’t find any existing CVEs that reference your project (a good thing!), so I’ve created a CPE reference that seems plausible. Please let me know if you know of a better CPE to use.
The various firmware build tools will take these incomplete SBOM files and then build them into a complete composite SBOM to represent the firmware. Having an upstream reference to what the PURL and CPE values should be means we have something we can trust; I could quite easily spin up a web-service that we say "what CPE do we use for X" -> cpe:2.3:a:Y:Z:::::::: but we don't actually know if that's still true, up to date, or what the maintainer actually wants them to be. Putting the template upstream means we can trust the values we find in the checked out code during the build process.
Also, if you’re not happy with Google being labelled a supplier (which seems more appropriate from a SBOM point of view, but makes some open source maintainers uncomfortable) we can remove that bit.
I've written a bit more about this proposal here https://blogs.gnome.org/hughsie/2024/11/14/firmware-sboms-for-open-source-projects/ and there's also lot more information about firmware SBOMs here: https://lvfs.readthedocs.io/en/latest/sbom.html – many thanks for your time.

I'm largely OK with this but I'm not very familiar with this area. I asked my Google colleague B.L., who has more SBOM experience. I'll quote extracts of what he told me below but the general vibe was also a little confusion, in that he thought SBOMs were more for releases instead of libraries (and even more so for open source libraries). Anyway...

You said:

I couldn’t find any existing CVEs that reference your project (a good thing!), so I’ve created a CPE reference that seems plausible. Please let me know if you know of a better CPE to use...
Having an upstream reference to what the PURL and CPE values should be means we have something we can trust;

I don't know how PURLs and CPEs are used but I'll note that your JSON file mentions "cpe" but not "purl". Also, B.L. said:

I think in this case, a PURL would also be helpful - and perhaps more fitting for open source libraries, if any of the purl types make sense.
CPEs generally I've seen more for product use, and not sure if its as useful in this case. My opinion would be to use PURLs here instead of a CPE.

You said:

Also, if you’re not happy with Google being labelled a supplier (which seems more appropriate from a SBOM point of view, but makes some open source maintainers uncomfortable) we can remove that bit.

B.L. said:

If Google is the one producing the release and distributing it, then Google is the supplier of the software... If the SBOM is for the distributed binary... then "Google LLC." as supplier sounds good. If its for the library, I think I'd defer to [another set of colleagues for advice].

I'll ask that other set of colleagues for their advice. Let me get back to you.

Coming back to me (instead of my colleague B.L.)...
Wuffs has no dependencies. Should we represent that explicitly in the JSON template somehow?

There is also the https://github.com/google/wuffs-mirror-release-c repo, which basically mirrors the release/c directory of this repo. For example, coreboot's copy of wuffs comes from the mirror repo.
Should I also update the mirror repo to also pick up doc/sbom.cdx.json?

A final unrelated tangent.

I've written a bit more about this proposal here https://blogs.gnome.org/hughsie/2024/11/14/firmware-sboms-for-open-source-projects/

Ah, b.g.o. I also used to write at https://blogs.gnome.org/nigeltao/ but that was a looooong time ago.

I'll note that your JSON file mentions "cpe" but not "purl"

Ah, your JSON file says:

"bom-ref": "pkg:github/google/wuffs@@VCS_TAG@"

Is that a github PURL key-value pair, even though that line doesn't literally contain the string "purl"?

I don't know how PURLs and CPEs are used but I'll note that your JSON file mentions "cpe" but not "purl".

Right, as you noticed the PURL is what I chose as the bomRef. If you'd rather make it explicit (i.e. move it to the purl attribute) that's completely fine -- the tools will just "move" it to the bomRef at build time.

Wuffs has no dependencies. Should we represent that explicitly in the JSON template somehow?

 I don't think you can specify "none" in CycloneDX now.

Should I also update the mirror repo to also pick up doc/sbom.cdx.json?

I didn't know about this, but I think so. Lets get this one good enough to merge and then I can do another PR if you'd like.

but that was a looooong time ago

Well, it's great to meet another old GNOMEie. :)


Add v1.5.2-incubating changelog

Why are the changes needed?

Add v1.5.2-incubating changelog for release
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

cc @yaooqinn @pan3793

wait for a blocker issue https://github.com/apache/incubator-kyuubi/pull/2848

since it's not a blocker, merging to master

yea, but it still has a chance to get in 1.5.2 during RC


Model Testing Framework and Metrics

Come up with testinng framework for the open-source models
should include metrics for both classification and segmentation

Testing Framework Doc
https://docs.google.com/document/d/1r9W2Q-IInp1dy0TzA8fAT_d9ZhbaKIheAPezXDDhGOM/edit?tab=t.0


How to request permission again if User Put check mark on deny and never ask again ??

How to request permission again if User Put check mark on deny and never ask again ??
P.s : Thank you for this Awsome Plugin :D

You can simply store the denied permission in PlayerPrefs as part of the onDenyAndNeverAskAgain callback


Update azurepolicy.json

Fixing policy roleDefinitionID requirements from Contributor to Tag Contributor. There is no reason for policy to have more rights then needed for underlying resource.
https://docs.microsoft.com/en-us/azure/azure-resource-manager/management/tag-resources?tabs=json#required-access

looks good to me


fix typo in amx enabling os call

fix the typo in https://github.com/libxsmm/libxsmm/issues/601

thanks for your contribution


[Feature Suggestion] Pipeline markers in micromapping mode

It would be nice to support pipeline markers in micromapping mode: https://wiki.openstreetmap.org/wiki/Key:marker
Currently they aren't even displayed.
IMO they would be useful because the energy infrastructure (in particular gas and oil) is currently very incomplete in OSM.
Edit: There's also the deprecated pipeline=marker, which is however still in widespread use.

Done in 0.9.


_cjose_jws_verify_sig_rs256 always returns true

what's up with this line:
https://github.com/cisco/cjose/blob/master/src/jws.c#L827
static bool _cjose_jws_verify_sig_rs256(
            cjose_jws_t *jws,
            const cjose_jwk_t *jwk,
            cjose_err *err)
{
    return true;
...

That's clearly a bug.  Possibly from a bad merge, although I can't recall any of those.

The code that is triggered now doesn't work conform spec, see #12

Re-opening until #12 merges.

Closed with merge of #12.


Add the ability to forwardport a change

Occasionally I do work on a non-master branch and want to forwardport a PR to the master branch, however, even if I manually specify the SHA and branch:
~/es/elasticsearch (git) 0f312c8b  7.x [origin/7.x] (2 stashed)
» backport --sha 0f312c8b381fe19b69964f1ef677c9c46ed844b7 --branch master
✖ Loading commit "0f312c8b"
No commit found on master with sha "0f312c8b381fe19b69964f1ef677c9c46ed844b7"

It appears to look for the sha on the master branch instead of 7.x.
It'd be great to be able to forwardport though!

Hey!
This is already possible - but not very well documented, and it should probably work as you suggest.
By using the [sourceBranch](https://github.com/sqren/backport/blob/master/docs/configuration.md#sourcebranch) argument, you can specify to pick commits from a non-master branch:
The following will list commits on 7.x and backport the selected commit to master:
backport --sourceBranch 7.x --branch master

The following currently doesn't work, but I'll look into fixing it:
backport --sourceBranch 7.x --branch master --sha 0f312c8b381fe19b69964f1ef677c9c46ed844b7


Fixed html issue.

@rezwan2525
Can you please review.

@trishitchar Amazing. Thanks for contributing 🤩


fix2473: use plural form only when required

Hopefully these changes should be adequate in order to fix the issue described in #2473.

Thanks @a-roussos :+1:

You are welcome! I'm very happy to see this change accepted and it was a pleasure to collaborate with you.