LAB_02_Implementing_integration_between_AD DS_and_Azure_AD.md

Source:
To address concerns regarding management and monitoring overhead resulting from using Microsoft Azure ActiveDirectory (Azure AD) to authenticate and authorize access to Azure resources,
Current Translation:
Microsoft Azure Active Directory (Azure AD) を使用して Azure リソースへのアクセスを認証および承認したことで生じる管理と監視のオーバーヘッドについての懸念に対応するために、
Suggested Translation:
Microsoft Azure Active Directory (Azure AD) を使用して Azure リソースへのアクセスを認証および承認する作業で生じる管理と監視のオーバーヘッドの懸念事項に対処するために、

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Fixed

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team


[guest-log] Avoid reporting error if the socket file got closed

What this PR does / why we need it:
When a shutdown of the guest OS got
triggered from the guest,
the socket file for the serial console
device could get removed even before virt-launcher-monitor detects that the VM is down and made virt-tail aware.
Due to that, virt-tail should not exit with an error when the socket file for the serial console gets removed.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes https://issues.redhat.com/browse/CNV-36451
Special notes for your reviewer:
None
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[X] PR: The PR description is expressive enough and will help future contributors
[X] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[X] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note:

None

/retest

/retest

/retest

/retest

/lgtm

/retest

/retest

/lgtm

/test

/retest

/retest

/approve

/cherrypick release-1.0

/cherrypick release-1.1

I meant to cherrypick this to release-1.1, I'll close the backport to 1.0 once it's created.

/retest

@victortoso since you already took a look at this, can you re-lgtm if everything's fine?

/lgtm

/retest-required

/retest

/retest

/test pull-kubevirt-e2e-k8s-1.27-ipv6-sig-network


Make kafka version configurable

[x] Make kafka version configurable
[x] Make kafka version using latest version: 2.7.0

kafka latest version: 2.7.0 fixed a bug: https://issues.apache.org/jira/browse/KAFKA-8334
It happened in our env, after deploy latest kafka version in PM, the problem gone.
Description

Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[ ] Controller
[x] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[x] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

Just for those who visit this PR, that issue makes committing offests take more than 5 seconds, accordingly it would dramatically increase the wait time of certain activations.

Just for those who visit this PR, that issue makes committing offests take more than 5 seconds, accordingly it would dramatically increase the wait time of certain activations.

Codecov Report

Merging #5046 (862df50) into master (b0baa7b) will increase coverage by 35.26%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #5046       +/-   ##
===========================================
+ Coverage   35.98%   71.24%   +35.26%
===========================================
  Files         202      199        -3
  Lines        9820     9735       -85
  Branches      416      435       +19
===========================================
+ Hits         3534     6936     +3402
+ Misses       6286     2799     -3487

Impacted Files
Coverage Δ

...che/openwhisk/core/invoker/LogStoreCollector.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...a/org/apache/openwhisk/http/BasicHttpService.scala
3.33% <0.00%> (-86.67%)
:arrow_down:

...la/org/apache/openwhisk/http/BasicRasService.scala
16.66% <0.00%> (-83.34%)
:arrow_down:

...pache/openwhisk/core/invoker/InvokerReactive.scala
0.00% <0.00%> (-80.00%)
:arrow_down:

...la/org/apache/openwhisk/core/invoker/Invoker.scala
1.58% <0.00%> (-68.26%)
:arrow_down:

...apache/openwhisk/core/ack/MessagingActiveAck.scala
0.00% <0.00%> (-54.55%)
:arrow_down:

...whisk/connector/kafka/KafkaMessagingProvider.scala
29.26% <0.00%> (-41.47%)
:arrow_down:

...tainerpool/docker/DockerClientWithFileAccess.scala
56.00% <0.00%> (-36.00%)
:arrow_down:

.../containerpool/docker/DockerContainerFactory.scala
36.36% <0.00%> (-33.34%)
:arrow_down:

...whisk/connector/kafka/KafkaProducerConnector.scala
27.50% <0.00%> (-32.50%)
:arrow_down:

... and 145 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0baa7b...862df50. Read the comment docs.

Codecov Report

Merging #5046 (862df50) into master (b0baa7b) will increase coverage by 35.26%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #5046       +/-   ##
===========================================
+ Coverage   35.98%   71.24%   +35.26%
===========================================
  Files         202      199        -3
  Lines        9820     9735       -85
  Branches      416      435       +19
===========================================
+ Hits         3534     6936     +3402
+ Misses       6286     2799     -3487

Impacted Files
Coverage Δ

...che/openwhisk/core/invoker/LogStoreCollector.scala
0.00% <0.00%> (-100.00%)
:arrow_down:

...a/org/apache/openwhisk/http/BasicHttpService.scala
3.33% <0.00%> (-86.67%)
:arrow_down:

...la/org/apache/openwhisk/http/BasicRasService.scala
16.66% <0.00%> (-83.34%)
:arrow_down:

...pache/openwhisk/core/invoker/InvokerReactive.scala
0.00% <0.00%> (-80.00%)
:arrow_down:

...la/org/apache/openwhisk/core/invoker/Invoker.scala
1.58% <0.00%> (-68.26%)
:arrow_down:

...apache/openwhisk/core/ack/MessagingActiveAck.scala
0.00% <0.00%> (-54.55%)
:arrow_down:

...whisk/connector/kafka/KafkaMessagingProvider.scala
29.26% <0.00%> (-41.47%)
:arrow_down:

...tainerpool/docker/DockerClientWithFileAccess.scala
56.00% <0.00%> (-36.00%)
:arrow_down:

.../containerpool/docker/DockerContainerFactory.scala
36.36% <0.00%> (-33.34%)
:arrow_down:

...whisk/connector/kafka/KafkaProducerConnector.scala
27.50% <0.00%> (-32.50%)
:arrow_down:

... and 145 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0baa7b...862df50. Read the comment docs.

Have any comment?
I benchmarked against the wurstmeister/kafka:2.13-2.7.0 , worked well. result as below
Env
Env:  3 PM nodes（128G memory; 40 core cpu;）
kafka version: wurstmeister/kafka:2.13-2.7.0
Benchmark test
I run producer and consumer side's script at the same time in kafka0 container.

Producer side

# send 50,000,000 records
/opt/kafka_2.13-2.7.0/bin/kafka-producer-perf-test.sh --topic scheduler0 --num-records 50000000  --record-size 100  --throughput -1 --producer-props acks=0 bootstrap.servers=<IP_ADDRESS>:9093,<IP_ADDRESS>:9094,<IP_ADDRESS>:9095
4077415 records sent, 815483.0 records/sec (77.77 MB/sec), 0.5 ms avg latency, 407.0 ms max latency.
4763549 records sent, 952709.8 records/sec (90.86 MB/sec), 0.3 ms avg latency, 15.0 ms max latency.
4392536 records sent, 878507.2 records/sec (83.78 MB/sec), 0.3 ms avg latency, 17.0 ms max latency.
4739980 records sent, 947996.0 records/sec (90.41 MB/sec), 0.3 ms avg latency, 14.0 ms max latency.
4678736 records sent, 935747.2 records/sec (89.24 MB/sec), 0.3 ms avg latency, 10.0 ms max latency.
4289005 records sent, 857801.0 records/sec (81.81 MB/sec), 0.4 ms avg latency, 6.0 ms max latency.
4657720 records sent, 931544.0 records/sec (88.84 MB/sec), 0.3 ms avg latency, 13.0 ms max latency.
4393393 records sent, 878678.6 records/sec (83.80 MB/sec), 0.3 ms avg latency, 11.0 ms max latency.
4286190 records sent, 857238.0 records/sec (81.75 MB/sec), 0.3 ms avg latency, 5.0 ms max latency.
4440910 records sent, 888182.0 records/sec (84.70 MB/sec), 0.3 ms avg latency, 11.0 ms max latency.
4519094 records sent, 903818.8 records/sec (86.19 MB/sec), 0.3 ms avg latency, 13.0 ms max latency.
50000000 records sent,<PHONE_NUMBER>84 records/sec (85.57 MB/sec), 0.32 ms avg latency, 407.00 ms max latency, 0 ms 50th, 1 ms 95th, 2 ms 99th, 10 ms 99.9th.

I configured  --throughput -1 to disable throttling, we can see, the tps is about 897,311

Consumer side

# Fetch 5,000,000  record (running for about 3 seconds)
/opt/kafka_2.13-2.7.0/bin/kafka-consumer-perf-test.sh  --topic scheduler0 --messages 5000000 --bootstrap-server=xxx.xxx.xxx.xxx:9093,xxx.xxx.xxx.xxx:9094,xxx.xxx.xxx.xxx:9095
start.time, end.time, data.consumed.in.MB, MB.sec, data.consumed.in.nMsg, nMsg.sec, rebalance.time.ms, fetch.time.ms, fetch.MB.sec, fetch.nMsg.sec
2021-01-28 11:46:58:466, 2021-01-28 11:47:01:299, 476.8650, 168.3251, 5000292, 1765016.5902,<PHONE_NUMBER>934, -1611802016101, -0.0000, -0.0031

# Fetch 10,000,000   records  (running for about 5 seconds)
/opt/kafka_2.13-2.7.0/bin/kafka-consumer-perf-test.sh  --topic scheduler0 --messages 10000000 --bootstrap-server=xxx.xxx.xxx.xxx:9093,xxx.xxx.xxx.xxx:9094,xxx.xxx.xxx.xxx:9095
start.time, end.time, data.consumed.in.MB, MB.sec, data.consumed.in.nMsg, nMsg.sec, rebalance.time.ms, fetch.time.ms, fetch.MB.sec, fetch.nMsg.sec
2021-01-28 11:45:58:096, 2021-01-28 11:46:03:224, 953.6926, 185.9775, 10000192, 1950115.4446,<PHONE_NUMBER>563, -1611801953435, -0.0000, -0.0062

# Fetch 1,000,000,000 records (running for about 20 minutes)
/opt/kafka_2.13-2.7.0/bin/kafka-consumer-perf-test.sh  --topic scheduler0 --messages<PHONE_NUMBER> --bootstrap-server=xxx.xxx.xxx.xxx:9093,xxx.xxx.xxx.xxx:9094,xxx.xxx.xxx.xxx:9095
start.time, end.time, data.consumed.in.MB, MB.sec, data.consumed.in.nMsg, nMsg.sec, rebalance.time.ms, fetch.time.ms, fetch.MB.sec, fetch.nMsg.sec
2021-01-28 11:55:33:186, 2021-01-28 12:16:03:855, 95367.4615, 77.4924,<PHONE_NUMBER>,<PHONE_NUMBER>,<PHONE_NUMBER>652, -1611801302983, -0.0001, -0.6204

We can saw the the tps is very high as well, when fetch 5,000,000, the tps is 1,765,016, when fetch 10,000,000 the tps is 1,950,115, when fetch 1,000,000,000, the tps is 81,2566
I also tested below scenes
when running kafka-producer-perf-test.sh, i adjusted the --num-records to huge value to make the producer script running for long time, when running kafka-consumer-perf-test.sh, i ajusted the --messages to huge value as well to make the consumer script running for long time
During benchmarking, i observed the cpu/memory doesn't consume too much for all kafka nodes.

FYI, on our production env, the consumer.commit offset timeout(>=5.seconds) issue didn't reappeared after we used the latest kafka version.

Have any comment?
I benchmarked against the wurstmeister/kafka:2.13-2.7.0 , worked well. result as below
Env
Env:  3 PM nodes（128G memory; 40 core cpu;）
kafka version: wurstmeister/kafka:2.13-2.7.0
Benchmark test
I run producer and consumer side's script at the same time in kafka0 container.

Producer side

# send 50,000,000 records
/opt/kafka_2.13-2.7.0/bin/kafka-producer-perf-test.sh --topic scheduler0 --num-records 50000000  --record-size 100  --throughput -1 --producer-props acks=0 bootstrap.servers=<IP_ADDRESS>:9093,<IP_ADDRESS>:9094,<IP_ADDRESS>:9095
4077415 records sent, 815483.0 records/sec (77.77 MB/sec), 0.5 ms avg latency, 407.0 ms max latency.
4763549 records sent, 952709.8 records/sec (90.86 MB/sec), 0.3 ms avg latency, 15.0 ms max latency.
4392536 records sent, 878507.2 records/sec (83.78 MB/sec), 0.3 ms avg latency, 17.0 ms max latency.
4739980 records sent, 947996.0 records/sec (90.41 MB/sec), 0.3 ms avg latency, 14.0 ms max latency.
4678736 records sent, 935747.2 records/sec (89.24 MB/sec), 0.3 ms avg latency, 10.0 ms max latency.
4289005 records sent, 857801.0 records/sec (81.81 MB/sec), 0.4 ms avg latency, 6.0 ms max latency.
4657720 records sent, 931544.0 records/sec (88.84 MB/sec), 0.3 ms avg latency, 13.0 ms max latency.
4393393 records sent, 878678.6 records/sec (83.80 MB/sec), 0.3 ms avg latency, 11.0 ms max latency.
4286190 records sent, 857238.0 records/sec (81.75 MB/sec), 0.3 ms avg latency, 5.0 ms max latency.
4440910 records sent, 888182.0 records/sec (84.70 MB/sec), 0.3 ms avg latency, 11.0 ms max latency.
4519094 records sent, 903818.8 records/sec (86.19 MB/sec), 0.3 ms avg latency, 13.0 ms max latency.
50000000 records sent,<PHONE_NUMBER>84 records/sec (85.57 MB/sec), 0.32 ms avg latency, 407.00 ms max latency, 0 ms 50th, 1 ms 95th, 2 ms 99th, 10 ms 99.9th.

I configured  --throughput -1 to disable throttling, we can see, the tps is about 897,311

Consumer side

# Fetch 5,000,000  record (running for about 3 seconds)
/opt/kafka_2.13-2.7.0/bin/kafka-consumer-perf-test.sh  --topic scheduler0 --messages 5000000 --bootstrap-server=xxx.xxx.xxx.xxx:9093,xxx.xxx.xxx.xxx:9094,xxx.xxx.xxx.xxx:9095
start.time, end.time, data.consumed.in.MB, MB.sec, data.consumed.in.nMsg, nMsg.sec, rebalance.time.ms, fetch.time.ms, fetch.MB.sec, fetch.nMsg.sec
2021-01-28 11:46:58:466, 2021-01-28 11:47:01:299, 476.8650, 168.3251, 5000292, 1765016.5902,<PHONE_NUMBER>934, -1611802016101, -0.0000, -0.0031

# Fetch 10,000,000   records  (running for about 5 seconds)
/opt/kafka_2.13-2.7.0/bin/kafka-consumer-perf-test.sh  --topic scheduler0 --messages 10000000 --bootstrap-server=xxx.xxx.xxx.xxx:9093,xxx.xxx.xxx.xxx:9094,xxx.xxx.xxx.xxx:9095
start.time, end.time, data.consumed.in.MB, MB.sec, data.consumed.in.nMsg, nMsg.sec, rebalance.time.ms, fetch.time.ms, fetch.MB.sec, fetch.nMsg.sec
2021-01-28 11:45:58:096, 2021-01-28 11:46:03:224, 953.6926, 185.9775, 10000192, 1950115.4446,<PHONE_NUMBER>563, -1611801953435, -0.0000, -0.0062

# Fetch 1,000,000,000 records (running for about 20 minutes)
/opt/kafka_2.13-2.7.0/bin/kafka-consumer-perf-test.sh  --topic scheduler0 --messages<PHONE_NUMBER> --bootstrap-server=xxx.xxx.xxx.xxx:9093,xxx.xxx.xxx.xxx:9094,xxx.xxx.xxx.xxx:9095
start.time, end.time, data.consumed.in.MB, MB.sec, data.consumed.in.nMsg, nMsg.sec, rebalance.time.ms, fetch.time.ms, fetch.MB.sec, fetch.nMsg.sec
2021-01-28 11:55:33:186, 2021-01-28 12:16:03:855, 95367.4615, 77.4924,<PHONE_NUMBER>,<PHONE_NUMBER>,<PHONE_NUMBER>652, -1611801302983, -0.0001, -0.6204

We can saw the the tps is very high as well, when fetch 5,000,000, the tps is 1,765,016, when fetch 10,000,000 the tps is 1,950,115, when fetch 1,000,000,000, the tps is 81,2566
I also tested below scenes
when running kafka-producer-perf-test.sh, i adjusted the --num-records to huge value to make the producer script running for long time, when running kafka-consumer-perf-test.sh, i ajusted the --messages to huge value as well to make the consumer script running for long time
During benchmarking, i observed the cpu/memory doesn't consume too much for all kafka nodes.

FYI, on our production env, the consumer.commit offset timeout(>=5.seconds) issue didn't reappeared after we used the latest kafka version.

What I mentioned was the benchmarking of OpenWhisk with this version of Kafka.
But I think it looks good to me as is.

What I mentioned was the benchmarking of OpenWhisk with this version of Kafka.
But I think it looks good to me as is.

Thanks @ningyougang and @style95!

Thanks @ningyougang and @style95!

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.79%. Comparing base (6686820) to head (5cde872).
Report is 236 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5046       +/-   ##
===========================================
- Coverage   82.52%   71.79%   -10.73%
===========================================
  Files         206      219       +13
  Lines       10006    11256     +1250
  Branches      445      503       +58
===========================================
- Hits         8257     8081      -176
- Misses       1749     3175     +1426

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Create email.txt

Add Blue Ridge Community College, Thanks.

@silencezwm This domain is blacklisted because the college allows to register an email address there even if you are not a student of the college. If you are the student of this college, please apply with official document ("OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students).


MocketSocket doesn't support SSL connections

It looks like MocketSocket can't be wrapped completely by SSLSocket
>>> import requests
>>> from mocket.mocket import Mocket
>>> Mocket.enable()
>>> requests.get('https://httpbin.org')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/bjmc/Sandbox/vcrpy/.env/local/lib/python2.7/site-packages/requests/api.py", line 55, in get
    return request('get', url, **kwargs)
  File "/home/bjmc/Sandbox/vcrpy/.env/local/lib/python2.7/site-packages/requests/api.py", line 44, in request
    return session.request(method=method, url=url, **kwargs)
  File "/home/bjmc/Sandbox/vcrpy/.env/local/lib/python2.7/site-packages/requests/sessions.py", line 335, in request
    resp = self.send(prep, **send_kwargs)
  File "/home/bjmc/Sandbox/vcrpy/.env/local/lib/python2.7/site-packages/requests/sessions.py", line 438, in send
    r = adapter.send(request, **kwargs)
  File "/home/bjmc/Sandbox/vcrpy/.env/local/lib/python2.7/site-packages/requests/adapters.py", line 291, in send
    timeout=timeout
  File "/home/bjmc/Sandbox/vcrpy/.env/local/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 428, in urlopen
    body=body, headers=headers)
  File "/home/bjmc/Sandbox/vcrpy/.env/local/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 280, in _make_request
    conn.request(method, url, **httplib_request_kw)
  File "/usr/lib/python2.7/httplib.py", line 973, in request
    self._send_request(method, url, body, headers)
  File "/usr/lib/python2.7/httplib.py", line 1007, in _send_request
    self.endheaders(body)
  File "/usr/lib/python2.7/httplib.py", line 969, in endheaders
    self._send_output(message_body)
  File "/usr/lib/python2.7/httplib.py", line 829, in _send_output
    self.send(msg)
  File "/usr/lib/python2.7/httplib.py", line 791, in send
    self.connect()
  File "/home/bjmc/Sandbox/vcrpy/.env/local/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 107, in connect
    ssl_version=resolved_ssl_version)
  File "/home/bjmc/Sandbox/vcrpy/.env/local/lib/python2.7/site-packages/requests/packages/urllib3/util.py", line 378, in ssl_wrap_socket
    ssl_version=ssl_version)
  File "/usr/lib/python2.7/ssl.py", line 440, in wrap_socket
    ciphers=ciphers)
  File "/usr/lib/python2.7/ssl.py", line 168, in __init__
    socket.__init__(self, _sock=sock._sock)
  File "/usr/lib/python2.7/socket.py", line 190, in __init__
    setattr(self, method, getattr(_sock, method))
AttributeError: 'MocketSocket' object has no attribute 'recv'

Thanks! :champagne:

@bjmc are you still using mocket?

Unfortunately, no. Without this feature, it wasn't helpful for me. I might have another look at it, now, but the project for which I was originally considering mocket has ended.

I know it took forever, and I am really sorry.
Said this, the only big thing missing is now the documentation, but I would like to invest time on showing how to mock something non-HTTP. On the other side, the last releases are supporting sockets on gevent, asyncio/aiohttp and pypy.


[ Conv2d ] save & read unittest

Add save & read unit test
Self evaluation:

Build test:	 [X]Passed [ ]Failed [ ]Skipped
Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: jijoong.moon<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.4.20191203. Thank you for submitting PR #143. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.


Segfault when connecting to Windows Server

Describe the bug
Remmina 1.4.11 compiled against freerdp 2.3.1 (maybe even 2.3.0) crashes every second time when connecting to a Windows Server.
To Reproduce
Steps to reproduce the behavior:

Start remmina 1.4.11
Connect to Windows Server via RDP
Log out
Connect to Windows Server via RDP again

Expected behavior
Login should just work
Application details

FreeRDP version 2.3.1
Command line used: remmina
OS version connecting to (server side): Microsoft Windows Server [Version 10.0.17763.1697]

Environment (please complete the following information):

OS: Linux
Version/Distribution: Ubuntu 20.04
Architecture: [amd64, arm]: amd64

Additional context
During tests I got two different stack traces (the first one more often):

Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `remmina'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x00007faa5931db85 in WLog_GetLogLevel (log=0xf0) at ./winpr/libwinpr/utils/wlog/wlog.c:415
415	./winpr/libwinpr/utils/wlog/wlog.c: No such file or directory.
[Current thread is 1 (Thread 0x7faa4aacd700 (LWP 20924))]
(gdb) #0  0x00007faa5931db85 in WLog_GetLogLevel (log=0xf0) at ./winpr/libwinpr/utils/wlog/wlog.c:415
#1  0x00007faa5931dbf9 in WLog_IsLevelActive (_log=, _log_level=_log_level@entry=4) at ./winpr/libwinpr/utils/wlog/wlog.c:433
#2  0x00007faa59532481 in transport_connect_nla (transport=0x7faa280b0c50) at ./libfreerdp/core/transport.c:345
#3  0x00007faa594f62ce in nego_security_connect (nego=nego@entry=0x7faa28067150) at ./libfreerdp/core/nego.c:248
#4  0x00007faa594f770d in nego_connect (nego=0x7faa28067150) at ./libfreerdp/core/nego.c:220
#5  0x00007faa5951fb37 in rdp_client_connect (rdp=rdp@entry=0x555a86831600) at ./libfreerdp/core/connection.c:333
#6  0x00007faa5952025a in rdp_client_reconnect (rdp=0x555a86831600) at ./libfreerdp/core/connection.c:605
#7  0x00007faa59511453 in freerdp_reconnect (instance=instance@entry=0x555a86ba4440) at ./libfreerdp/core/freerdp.c:545
#8  0x00007faa595127f8 in freerdp_connect (instance=0x555a86ba4440) at ./libfreerdp/core/freerdp.c:228
#9  0x00007faa597dbdf3 in remmina_rdp_main (gp=0x555a8700ac50) at ./plugins/rdp/rdp_plugin.c:1828
#10 remmina_rdp_main_thread (data=0x555a8700ac50) at ./plugins/rdp/rdp_plugin.c:2032
#11 0x00007faa5e928609 in start_thread (arg=) at pthread_create.c:477
#12 0x00007faa5e20a293 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

or

Core was generated by `remmina'.
Program terminated with signal SIGABRT, Aborted.
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
50	../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
[Current thread is 1 (Thread 0x7f306bfff700 (LWP 20402))]
(gdb) #0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1  0x00007f309e17c859 in __GI_abort () at abort.c:79
#2  0x00007f309e1e73ee in __libc_message (action=action@entry=do_abort, fmt=fmt@entry=0x7f309e311285 "%s\n") at ../sysdeps/posix/libc_fatal.c:155
#3  0x00007f309e1ef47c in malloc_printerr (str=str@entry=0x7f309e313670 "double free or corruption (out)") at malloc.c:5347
#4  0x00007f309e1f1120 in _int_free (av=0x7f309e342b80 <main_arena>, p=0x7f30841b72d0, have_lock=) at malloc.c:4314
#5  0x00007f30993a3eb0 in sspi_SecBufferFree (SecBuffer=SecBuffer@entry=0x7f308425cdd0) at ./winpr/libwinpr/sspi/sspi_winpr.c:278
#6  0x00007f309955ff68 in nla_buffer_free (nla=nla@entry=0x7f308425ccf0) at ./libfreerdp/core/nla.c:2261
#7  0x00007f3099564c25 in nla_free (nla=0x7f308425ccf0) at ./libfreerdp/core/nla.c:2462
#8  0x00007f30995a1409 in transport_connect_nla (transport=0x7f308425ca50) at ./libfreerdp/core/transport.c:328
#9  0x00007f30995652ce in nego_security_connect (nego=nego@entry=0x7f3084006e10) at ./libfreerdp/core/nego.c:248
#10 0x00007f309956670d in nego_connect (nego=0x7f3084006e10) at ./libfreerdp/core/nego.c:220
#11 0x00007f309958eb37 in rdp_client_connect (rdp=rdp@entry=0x5623cb59aa10) at ./libfreerdp/core/connection.c:333
#12 0x00007f309958f25a in rdp_client_reconnect (rdp=0x5623cb59aa10) at ./libfreerdp/core/connection.c:605
#13 0x00007f3099580453 in freerdp_reconnect (instance=instance@entry=0x5623cb240110) at ./libfreerdp/core/freerdp.c:545
#14 0x00007f30995817f8 in freerdp_connect (instance=0x5623cb240110) at ./libfreerdp/core/freerdp.c:228
#15 0x00007f309984adf3 in remmina_rdp_main (gp=0x5623cb1b4ed0) at ./plugins/rdp/rdp_plugin.c:1828
#16 remmina_rdp_main_thread (data=0x5623cb1b4ed0) at ./plugins/rdp/rdp_plugin.c:2032
#17 0x00007f309e997609 in start_thread (arg=) at pthread_create.c:477
#18 0x00007f309e279293 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

@linuxrrze ok, there seems to be something broken with the build.
Can you compile -DWITH_SANITIZE_ADDRESS=ON and check where it starts complaining?

Or is this meant to have effects during runtime only?

@linuxrrze it will link in address sanitizer and crash early if something is not right (wrong address/buffer overflow/...)
the trace you posted seems like there is something fishy as the functions can not fail where they fail except if the pointer/argument is wrong

Hmm, ok - remmina now quits (very) early:

RUNNING: remmina
Load modules from /usr/lib/x86_64-linux-gnu/remmina/plugins
Remmina plugin glibsecret (type=Secret) has been registered, but is not yet initialized/activated. The initialization order is 2000.
==37561==ASan runtime does not come first in initial library list; you should either link runtime to your application or manually preload it with LD_PRELOAD.

However I guess that's not the output you need ... looking around some more I found some env settings (ASAN_OPTIONS) and this gives a stack trace at least:

RUNNING: ASAN_OPTIONS=verify_asan_link_order=0  /usr/bin/remmina
Load modules from /usr/lib/x86_64-linux-gnu/remmina/plugins
Remmina plugin glibsecret (type=Secret) has been registered, but is not yet initialized/activated. The initialization order is 2000.
==38082==AddressSanitizer CHECK failed: ../../../../src/libsanitizer/sanitizer_common/sanitizer_linux_libcdep.cc:212 "((get_tls)) != ((0))" (0x0, 0x0)
#0 0x7f6fd81c1c7e  (/lib/x86_64-linux-gnu/libasan.so.5+0x117c7e)
#1 0x7f6fd81e02ae  (/lib/x86_64-linux-gnu/libasan.so.5+0x1362ae)
#2 0x7f6fd81d3c5c  (/lib/x86_64-linux-gnu/libasan.so.5+0x129c5c)
#3 0x7f6fd81c4919  (/lib/x86_64-linux-gnu/libasan.so.5+0x11a919)
#4 0x7f6fe03bfb89  (/lib64/ld-linux-x86-64.so.2+0x11b89)
#5 0x7f6fe03bfc90  (/lib64/ld-linux-x86-64.so.2+0x11c90)
#6 0x7f6fdeeef914 in _dl_catch_exception (/lib/x86_64-linux-gnu/libc.so.6+0x163914)
#7 0x7f6fe03c40be  (/lib64/ld-linux-x86-64.so.2+0x160be)
#8 0x7f6fdeeef8b7 in _dl_catch_exception (/lib/x86_64-linux-gnu/libc.so.6+0x1638b7)
#9 0x7f6fe03c35f9  (/lib64/ld-linux-x86-64.so.2+0x155f9)
#10 0x7f6fde24134b  (/lib/x86_64-linux-gnu/libdl.so.2+0x134b)
#11 0x7f6fdeeef8b7 in _dl_catch_exception (/lib/x86_64-linux-gnu/libc.so.6+0x1638b7)
#12 0x7f6fdeeef982 in _dl_catch_error (/lib/x86_64-linux-gnu/libc.so.6+0x163982)
#13 0x7f6fde241b58  (/lib/x86_64-linux-gnu/libdl.so.2+0x1b58)
#14 0x7f6fde2413d9 in dlopen (/lib/x86_64-linux-gnu/libdl.so.2+0x13d9)
#15 0x7f6fdf5e7c16 in g_module_open (/lib/x86_64-linux-gnu/libgmodule-2.0.so.0+0x1c16)
#16 0x559aa53f825f in remmina_plugin_native_load (/usr/bin/remmina+0x3c25f)
#17 0x559aa53f785f in remmina_plugin_manager_init (/usr/bin/remmina+0x3b85f)
#18 0x559aa53e2286 in main (/usr/bin/remmina+0x26286)
#19 0x7f6fdedb30b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
#20 0x559aa53e245d in _start (/usr/bin/remmina+0x2645d)

@linuxrrze you need to define LD_PRELOAD=/usr/lib/gcc/x86_64-linux-gnu/9/libasan.so to load the asan library as the first one. (check the path, it might be different for your machine)

Ok ... I tried that:
Remmina just hangs upon startup dropping 3 lines but never opens a window.
With LD_PRELOAD:

RUNNING: LD_PRELOAD=/usr/lib/gcc/x86_64-linux-gnu/9/libasan.so remmina
Load modules from /usr/lib/x86_64-linux-gnu/remmina/plugins
Remmina plugin glibsecret (type=Secret) has been registered, but is not yet initialized/activated. The initialization order is 2000.
The glibsecret secret plugin  has been initialized and it will be your default secret plugin

Waiting forever (or at least very long)
Without LD_PRELOAD:

RUNNING: remmina
Load modules from /usr/lib/x86_64-linux-gnu/remmina/plugins
Remmina plugin glibsecret (type=Secret) has been registered, but is not yet initialized/activated. The initialization order is 2000.
The glibsecret secret plugin  has been initialized and it will be your default secret plugin
StatusNotifier/Appindicator support: your desktop does support it and libappindicator is compiled in Remmina. Good.
Running under GNOME Shell version 3.36.4

up and running ...
Build service is just building packages for remmina 1.4.12 ... so we'll see how that goes.

Same thing with remmina 1.4.12:
When started with LD_PRELOAD=...libasan.so remmina just hangs.
When started without LD_PRELOAD it just quits with "ASan runtime ..." message.
If I remove remmina-plugin-rdp.so remmina can be started (with other plugins like VNC, SPICE, SSH).

Update:
I analyzed the difference between my debian/rules file and compared it to the plain Ubuntu one:
Looks like at some point "-D_REENTRANT" was added to packaging rules:
# s. https://github.com/FreeRDP/FreeRDP/issues/5504
CFLAGS+=$(CPPFLAGS) -D_REENTRANT

Removing that line seems to fix the issue.
Looks like this was the "fishy" part of my build.
I'll do some more testing and if the error does not re-appear I'll close this issue.

@linuxrrze ok, just defining that might break a lot of stuff ^^


CIS Benchmark Controls missing - AWS

Hi Toniblyx,
Can see the attached screenshot from CIS benchmark in which highlighted controls are missing while doing our audit in AWS Environment. Please let me know the possible way for getting it?

Thanks for your updates on this controls . I will passed the same information to our teammates.


Support tar-split style storage

Right now when we fetch container images we parse them and:

Drop on the floor things like files in /var
Rename /etc
Pass the tar stream to ostree commit, which will also discard e.g. mtimes

And other bits.
This breaks the ability to re-synthesize the tar stream; basically what I think there are some use cases for is ostree container push.  This also relates to https://github.com/ostreedev/ostree-rs-ext/issues/273
I think the solution to this is to take a similar approach as https://github.com/vbatts/tar-split
Although, I think what I'd propose is an algorithm like this:
let mut tar_meta_entries = Vec::new();
for entry in tar {
    let (metadata, raw_metadata_bytes) = entry.metadata();
    let checksum = write_ostree_object(entry);
    tar_meta_entries.push((raw_metadata_bytes, checksum));
}

Then we serialize tar_meta_entries...somewhere.  In the commit metadata is an obvious place, but would need some size analysis.  We could store it in another ref as data, but just mildly ugly to have two refs per layer.
To reliably reconstitute the bit for bit uncompressed tar stream, we just need to load tar_meta_entries, write the metadata bytes, then load the corresponding ostree object and append its raw data.

A key feature this would enable is ostree container push from the running OS.  (Obviously, it also kind of scope creeps this whole thing into an ostree-based container storage backend)

Was briefly looking at this today, and it looks like the current tar API may already provide exactly what we need in e.g. https://docs.rs/tar/latest/tar/struct.Entry.html#method.raw_header_position


Rework HDF file handling

This stops it appending irrelevant data to a previous file, but will this now just open (overwrite) the same file when new data comes in?

No, when new data comes it should check if a file already exists, and if so append a suffix to the file name before opening to make sure no data is overwritten
https://github.com/dls-controls/pmacFilterControl/blob/1077ea43319ed9c5530a1c23cf6bfec53d1b980f/src/pmacfiltercontrol/pmacFilterControlWrapper.py#L696-L709

NOTE: Currently the time is appended as a placeholder, but this will likely be changed to an integer in the near future

but this will likely be changed to an integer in the near future
I think this should be done in this PR. It won't work with Malcolm without it (currently it assumes the file is just called attenuation.h5 but this could be cnahge to have a _1 suffix as appropriate, as long as it is consistent when it is the first time it writes to a given directory.

Is the log message to say when the file is closed supposed to be included here?

Is the log message to say when the file is closed supposed to be included here?

Now it is, along with the other minor changes you made in the 'work' checkout

Looks OK now.
Is it still possible for it to immediately re-open the same file by passing a manual command after doing a scan?

Is it still possible for it to immediately re-open the same file by passing a manual command after doing a scan?

It is not https://github.com/dls-controls/pmacFilterControl/pull/43/files#diff-2e041aa7ee041c8fa085ffd879caff59c52341c546c93caee6bf36d68769d638R60-R61


Card Component Created

Pull Request Type
What kind of change does this PR introduce?
A Card component for generating random images has been created
What is the current behavior?
No card component existed
Issue Number: #1454
What is the new behavior?
A card component that shows random images is created

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out my other projects. Just click here to find more. These projects contain real issues that you can help resolve. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


Add supported Laravel 11+

Add support for Laravel 11+.

composer.json

Update the require section to include "illuminate/contracts": "^10.0|^11.0".

.github/workflows/run-tests.yml

Add Laravel 11 to the matrix configuration for testing.
Include specific matrix configuration for Laravel 11 with testbench: 8.* and carbon: ^2.63.

For more details, open the Copilot Workspace session.

Update GitHub Actions workflow to include Laravel 11 and PHP 8.3 in the matrix configuration

Matrix Configuration

Add PHP 8.3 to the matrix configuration for testing
Update Laravel 11 configuration to use Testbench 9

Update GitHub Actions workflow for testing

Remove specific testbench and carbon versions from matrix configuration


why my app have granted access with pin code?

i use this library to login via web browser but it show graned access with pin code?

Sorry, I do not understand what your issue is. Can you please rephrase your issue and explain more detailed what your problem is?


Update readme

update "master" to main
update conversion to the remote naming scheme Josh and I currently use
update note about node 14 once my PR is merged that fixes the dependency issue

now that #1299 is merged


Doxygen based documentation

TODO:

Add doxygen markup to existing code comments.
Build doxygen for the project automatically to gh-pages.
Move current wiki content to doxygen documentation pages.
Add new content documenting OTA updates, clearer quickstart steps.

Small note that some of the documentation mentioned above (like OTA update details) has been added, but is currently in the github wiki:
https://github.com/SuperHouse/esp-open-rtos/wiki
Would still like eventually migrate it all to doxygen.


Dark Theme

Currently when in the Dark Theme in Visual Studio 2015 the text is all highlighted in a weird background color and the text is white making it almost impossible to read.

T4Toolbox currently defines colors only for the light theme of Visual Studio. If you are using the dark theme, you can modify the T4 Toolbox colors using the Tools -> Options dialog, Environment -> Fonts and Colors page. The T4 Toolbox color names start with Text Template, for example, Text Template Code Block.
Based on a quick research, it appears that the "right" way to support themes is to define theme-specific colors in a .pkgdef file installed with the extension. The PowerShell Tools may be a good example to follow because it is now shipping with Visual Studio 2015 and was most likely reviewed for accessibility compliance by the Visual Studio team.
In particular, the PowerShell Tools extension defines classification format definitions very similarly to how we do it in T4Toolbox: ClassificationType.cs. And here is the color definition file: PowerShellToolsColors.pkgdef. Notice the two GUIDs, which I believe represent the dark and one other theme.
Unfortunately, the .pkgdef contains binary data, which I don't know how to read or write. We may be able to use the Visual Studio 2013 Color Theme Editor to create it. Using this extension, I was able to modify the T4 Toolbox colors and export the modified theme to a .pkgdef file. However, unlike the poshtools' .pkgdef file, the file I created didn't have a separate, extension-specific key defined. The colors must have been embedded in some other section because I didn't see T4Toolbox in the file, nor did I find the names of the T4 Toolbox colors, however, the customized colors were properly restored when I reset my theme and imported the previously saved one.

Thanks for the tip! I’d suggest that you need to automatically recongnize the theme and just work, and you should be using the standard coding text background and foregrounds not custom ones.
From: Oleg Sych<EMAIL_ADDRESS>Sent: Tuesday, July 14, 2015 2:10 AM
To: olegsych/T4Toolbox<EMAIL_ADDRESS>Cc: JohnGalt1717<EMAIL_ADDRESS>Subject: Re: [T4Toolbox] Dark Theme (#14)
T4Toolbox currently defines colors only for the light theme of Visual Studio. If you are using the dark theme, you can modify the T4 Toolbox colors using the Tools -> Options dialog, Environment -> Fonts and Colors page. The T4 Toolbox color names start with Text Template, for example, Text Template Code Block.
Based on a quick research, it appears that the "right" way to support themes is to define theme-specific colors in a .pkgdef file installed with the extension. The PowerShell Tools https://github.com/adamdriscoll/poshtools  may be a good example to follow because it is now shipping with Visual Studio 2015 and was most likely reviewed for accessibility compliance by the Visual Studio team.
In particular, the PowerShell Tools extension defines classification format definitions very similarly to how we do it in T4Toolbox: ClassificationType.cs https://github.com/adamdriscoll/poshtools/blob/2cacf706c883eab4cfc4a31c9634445152438502/PowerShellTools/Classification/ClassificationType.cs . And here is the color definition file: PowerShellToolsColors.pkgdef https://github.com/adamdriscoll/poshtools/blob/dev/PowerShellTools/PowerShellToolsColors.pkgdef . Notice the two GUIDs, which I believe represent the dark and one other theme.
Unfortunately, the .pkgdef contains binary data, which I don't know how to read or write. We may be able to use the Visual Studio 2013 Color Theme Editor https://visualstudiogallery.msdn.microsoft.com/9e08e5d3-6eb4-4e73-a045-6ea2a5cbdabe  to create it. Using this extension, I was able to modify the T4 Toolbox colors and export the modified theme to a .pkgdef file. However, unlike the poshtools' .pkgdef file, the file I created didn't have a separate, extension-specific key defined. The colors must have been embedded in some other section because I didn't see T4Toolbox in the file, nor did I find the names of the T4 Toolbox colors, however, the customized colors were properly restored when I reset my theme and imported the previously saved one.
—
Reply to this email directly or view it on GitHub https://github.com/olegsych/T4Toolbox/issues/14#issuecomment-121140554 .  https://github.com/notifications/beacon/AByBc88BEnsRr5Rl2QtI3NSLBATYhIV9ks5odJ9DgaJpZM4FRitM.gif

Reusing one of the built-in content types as a base for the T4 Toolbox classification types would be ideal. Unfortunately, the list of predefined classification types doesn't seem to include the HTML/ASP.NET editor items the T4 Toolbox tries to mimic. Keep in mind that we could only use the built-in content type definitions that are guaranteed to be available with the minimum set of Visual Studio features installed, even when Web Developer Tools are not installed. I haven't found such content types at the time, which is why the colors are hard-coded today.
Both this approach and the .pkgdef-based one I described above will just work when Visual Studio theme is changed. They will also work with the theme editor and can be exported/imported correctly.

I've started active work on this (forked). My approach isn't pkgdef, but, to integrate detecting current theme and available themes from the registry (Light, Dark, Blue, HighContrast defaults) and supply customization, and have a "Syntax" page in Tools > Options > T4Toolbox.
The one question on my mind is caching initial registry hits, rather than each iteration over the buffer calling through TemplateClassificationTaggerProvider.cs to ClassificationFormatDefinitions.cs ... except that the way this is done is specific for the buffer's call stack and methods VS calls to get information. (Learning.)

Small Note:
Checked out VS 2013 Color Editor. Changed the values for Tools > Options > Environment > Fonts & Colors variables (Attribute Name/Val, Code Block, Delimiter, Directive), saved as both .vssettings and .pkgdef format.

.vssettings has representative XML nodes.
.pkgdef does not have individual nodes, but, I believe the values would be stored in the "Environment" key (unknown binary format).
.pkgdef format is embedded in %APPDATALOCAL%\Microsoft\Visual Studio\{version}\Extensions\{key}\Microsoft.VisualStudio.PkgDef.dll

Correct me if I'm wrong, but, distributing a full export and trying to load it could override existing environment customizations (at least temporarily while opening a .tt file for editing).
Research: What's A PkgDef? And Why?
When editing values directly in Tools > Options > Environment > Fonts & Colors, versus editing and saving a VS 2013 Custom Color Theme, changes could happen in different places. (What if you don't have the Color Theme editor installed, and you modify things in the typical pages?) It's a registry setting and / or stored in a different User Preferences folder. (Note: Have not worked out how all of this completely works and comes together, but, the above link is enough to investigate and fully document the effects of changes one vs. the other.)

The nice thing about defining theme colors in a .pkgdef file is that Visual Studio automatically takes care of detecting and applying the theme colors. I think that early attempts to support this in PowerShell Tools also relied on code-based approach, however, it was later replaced to use the .pkgdef-based approach. It feels that implementing support for Dark theme using code-based approach requires a lot more work and produce a less-reliable solution because of so many possible scenarios where theme colors are involved.
@AndreSayreMSFT, @adamdriscoll, I hate to bug you with this, but could you point us in the right direction? I think we know how to get a .pkgdef file with theme colors exported using the Visual Studio 2013 Color Theme Editor, but we don't understand how to extract the binary data into T4Toolbox-specific theme keys, similar to how the PoshTools colors are organized.

This might be a stretch of an ask, but, any possibility of having the VS 2013 Color Editor released on Microsoft on GitHub?
Specifically: Microsoft.VisualStudio.PkgDef

I think that's a good suggestion to post on the gallery page of the VS Color Theme Editor. In the meantime, with a nudge in the right direction from @AndreSayreMSFT, I think I may have figured out how to produce the .pkgdef theme file for T4Toolbox. Here is what I've done:

Open Color Theme Editor in Visual Studio 2013

Create a copy of the Dark theme
Edit the copy of the Dark theme and switch to the Show All Elements view
Search for Text Template
Change the T4 Toolbox colors (both background and foreground) to use the exact color values of the respective HTML elements in the Dark theme
Export the theme to a file called T4Toolbox.Dark.vstheme

Open the T4Toolbox.Dark.vstheme file in Notepad

Search for Text Template
Remove all Color elements except for those with Text Template in their name
Place them in a new Category element with Name="T4Toolbox" and a new GUID
Here is the file I ended up with.

<Themes>
  <Theme Name="T4Toolbox.Dark" GUID="{02f39cd3-e77d-4d98-b333-354f4c9eee3a}">
    <Category Name="T4Toolbox" GUID="{8fb347e9-e52e-4949-9806-fe95b0e8929c}">
      <Color Name="Text Template Attribute Name">
        <Foreground Type="CT_RAW" Source="FF9CDCFE" />
      </Color>
      <Color Name="Text Template Attribute Value">
        <Foreground Type="CT_RAW" Source="FFC8C8C8" />
      </Color>
      <Color Name="Text Template Code Block">
        <Background Type="CT_RAW" Source="FF505050" />
      </Color>
      <Color Name="Text Template Delimiter">
        <Background Type="CT_RAW" Source="FFFFFFB3" />
        <Foreground Type="CT_RAW" Source="FF000000" />
      </Color>
      <Color Name="Text Template Directive Name">
        <Foreground Type="CT_RAW" Source="FF569CD6" />
      </Color>
    </Category>
  </Theme>
</Themes>

Back in the Visual Studio 2013 Color Theme Editor

Import the T4Toolbox.Dark.vstheme
Ignore the NullReferenceException message
Edit the newly-imported theme
Export the theme to a file called T4Toolbox.Dark.pkgdef
Here is the file I ended up with.

[$RootKey$\Themes\{02f39cd3-e77d-4d98-b333-354f4c9eee3a}]
@="T4Toolbox.Dark"
"Name"="T4Toolbox.Dark"

[$RootKey$\Themes\{02f39cd3-e77d-4d98-b333-354f4c9eee3a}\T4Toolbox]
"Data"=hex:da,00,00,00,0b,00,00,00,01,00,00,00,e9,47,b3,8f,2e,e5,49,49,98,06,fe,95,b0,e8,92,9c,05,00,00,00,1c,00,00,00,54,65,78,74,20,54,65,6d,70,6c,61,74,65,20,41,74,74,72,69,62,75,74,65,20,4e,61,6d,65,00,01,9c,dc,fe,ff,1d,00,00,00,54,65,78,74,20,54,65,6d,70,6c,61,74,65,20,41,74,74,72,69,62,75,74,65,20,56,61,6c,75,65,00,01,c8,c8,c8,ff,18,00,00,00,54,65,78,74,20,54,65,6d,70,6c,61,74,65,20,43,6f,64,65,20,42,6c,6f,63,6b,01,50,50,50,ff,00,17,00,00,00,54,65,78,74,20,54,65,6d,70,6c,61,74,65,20,44,65,6c,69,6d,69,74,65,72,01,ff,ff,b3,ff,01,00,00,00,ff,1c,00,00,00,54,65,78,74,20,54,65,6d,70,6c,61,74,65,20,44,69,72,65,63,74,69,76,65,20,4e,61,6d,65,00,01,56,9c,d6,ff

This looks very similar to the PowerShellToolsColors.pkgdef, with notable differences. In the `T4Toolbox.Dark.pkgdef:

The [$RootKey$\Themes\{02f39cd3-e77d-4d98-b333-354f4c9eee3a}] defines a custom theme called T4Toolbox.Dark. I believe it should be removed.
The [$RootKey$\Themes\{02f39cd3-e77d-4d98-b333-354f4c9eee3a}\T4Toolbox] key contains a GUID of the custom new theme, instead of one of the built-in themes. I believe it should be replaced with the  {1ded0138-47ce-435e-84ef-9ec1f439b749} representing the Dark theme.
Here is the resulting file.

[$RootKey$\Themes\{1ded0138-47ce-435e-84ef-9ec1f439b749}\T4Toolbox]
"Data"=hex:da,00,00,00,0b,00,00,00,01,00,00,00,e9,47,b3,8f,2e,e5,49,49,98,06,fe,95,b0,e8,92,9c,05,00,00,00,1c,00,00,00,54,65,78,74,20,54,65,6d,70,6c,61,74,65,20,41,74,74,72,69,62,75,74,65,20,4e,61,6d,65,00,01,9c,dc,fe,ff,1d,00,00,00,54,65,78,74,20,54,65,6d,70,6c,61,74,65,20,41,74,74,72,69,62,75,74,65,20,56,61,6c,75,65,00,01,c8,c8,c8,ff,18,00,00,00,54,65,78,74,20,54,65,6d,70,6c,61,74,65,20,43,6f,64,65,20,42,6c,6f,63,6b,01,50,50,50,ff,00,17,00,00,00,54,65,78,74,20,54,65,6d,70,6c,61,74,65,20,44,65,6c,69,6d,69,74,65,72,01,ff,ff,b3,ff,01,00,00,00,ff,1c,00,00,00,54,65,78,74,20,54,65,6d,70,6c,61,74,65,20,44,69,72,65,63,74,69,76,65,20,4e,61,6d,65,00,01,56,9c,d6,ff

Now we need to figure out how to integrate it with the T4Toolbox VSIX package.

I submitted a new connect issue to report the NullReferenceException problem during import in the Color Theme Editor. Please take moment to up-vote it.

Reproduced & up-voted on MS Connect.
Date: Fri, 17 Jul 2015 19:33:21 -0700
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [T4Toolbox] Dark Theme (#14)
I submitted a new connect issue to report the NullReferenceException problem during import in the Color Theme Editor. Please take moment to up-vote it.
—
Reply to this email directly or view it on GitHub.

Thanks, @MudaKaizen :ice_cream:

I'll look into how poshtools integrates .pkgdef and see if I can't come up with a suggested implementation path.

Research Notes:
Commit History: PowerShellToolsColors.pkgdef commit history
The referenced PowerShellToolsColors.pkgdef file is in the dev branch, poshtools-dev\PowerShellTools\PowerShellTools.csproj:
<Content Include="PowerShellToolsColors.pkgdef">
    <CopyToOutputDirectory>Always</CopyToOutputDirectory>
    <IncludeInVSIX>true</IncludeInVSIX>
</Content>

poshtools-dev\PowerShellTools\Classification\ClassificationType.cs: The foreground colors specified in this file are the defaults if not overridden. For Dark theme and High Contrast, see PowerShellToolsColors.pkgdef
poshtools-dev\PowerShellTools\PowerShellToolsPackage.cs:
// This attribute tells the PkgDef creation utility (CreatePkgDef.exe) that this class is a package.
CreatePkgDef Utility

Takes a .dll file for a Visual Studio extension as a parameter and creates a .pkgdef file to accompany the .dll. The .pkgdef file contains all the information that would otherwise be written to the system registry when the extension is installed.
... Usage ...
Remarks
Extension deployment by using .pkgdef files replaces the registry requirements of earlier versions of Visual Studio.
The .pkgdef files must be installed in one of the following locations: %localappdata%\Microsoft\Visual Studio\12.0\Extensions\ or %vsinstalldir%\Common7\IDE\Extensions. If the installation folder is %localappdata%\Microsoft\Visual Studio\12.0\Extensions, the extension will be recognized by Visual Studio, but will be disabled by default. The user can enable the extension by using Extensions and Updates. If the installation folder is %vsinstalldir%\Common7\IDE\Extensions, the extension is enabled by default.

===== USAGE =====
C:\REPO\T4Toolbox-master\T4Toolbox-master\src\T4Toolbox.vsix\bin\Debug>"%VSSDK140Install%\VisualStudioIntegration\Tools\Bin\CreatePkgDef.exe" /out=test.out /assembly T4Toolbox.VisualStudio.dll /verbose
Visual Studio (R) PkgDef Creation Utility.
Copyright (c) Microsoft Corporation. All rights reserved.

CreatePkgDef : warning : The Assembly specified at 'T4Toolbox.VisualStudio.dll' cannot be loaded because an alternate copy with the same identity exists in the Assembly probing path at 'C:\REPO\T4Toolbox-master\T4Toolbox-master\src\T4Toolbox.vsix\bin\Debug\T4Toolbox.VisualStudio.dll'. The Assembly at 'C:\REPO\T4Toolb
ox-master\T4Toolbox-master\src\T4Toolbox.vsix\bin\Debug\T4Toolbox.VisualStudio.dll' will be loaded instead.

The T4Toolbox.VisualStudio.Editor.csproj contains the relevant references similar to poshtools.
poshtools-dev\PowerShellTools\RegistrationAttributes.cs:FontAndColorsRegistrationAttribute
However, when I run the same command against PowerShellTools.12.0.dll  -- no references to Fonts, Colors, Themes or the top-level Fonts & Colors Registration GUID, nor those stored in the .pkgdef.
Not sure how it's being referenced by the project or VS.
Code-wise, most everything is in order, between IClassificationTypeRegistryService and ClassificationTypeRegistry, except for different implementation.
Maybe it's just a matter of providing the pkgdef file as a resource, and the FontsAndColors RegistrationAttribute (which is declared in namespace Microsoft.VisualStudio.Shell)?
/ End Thoughts
ToDo: Simple copy-over build & test.

Copying the RegistrationAttributes.cs file and PowerShellToolsColors.pkgdef to either T4Toolbox.csproj or T4Toolbox.VisualStudio.csproj has no effect. (Simple test failed -- there's a bit more to it.)

That's right, the T4Toolbox.VisualStudio.pkgdef file is automatically generated by Visual Studio when building the T4Toolbox.vsix project from the registration attributes applied to the T4ToolboxPackage.
The generated file is included in the extension.vsixmanifest file inside of the T4Toolbox VSIX package with a well-known asset type.
<Asset Type="Microsoft.VisualStudio.VsPackage" Path="T4Toolbox.VisualStudio.pkgdef" />

You can see it by opening the .vsix file as a Zip archive. I typically use 7zip, but you can also use Windows Explorer after changing the file extension from .vsix to .zip.
The Microsoft.VisualStudio.VsPackage asset type instructs Visual Studio to import the .pkgdef file during installation of the extension. You can see the actual imported settings using registry editor. The $RootKey$ token from the .pkgdef file is mapped to a "config" registry key, such as HKEY_CURRENT_USER\SOFTWARE\Microsoft\VisualStudio\14.0_Config by default and HKEY_CURRENT_USER\SOFTWARE\Microsoft\VisualStudio\14.0Exp_Config for the experimental instance of Visual Studio.
I think that for the dark theme to work, the T4Toolbox.Dark.pkgdef  file simply needs to be included in the T4Toolbox VSIX package and declared in the extension.vsixmanifest with the Microsoft.VisualStudio.VsPackage asset type. The first part can be accomplished by including the file in the T4Toolbox.VisualStudio.Editor project with the <IncludeInVSIX/> metadata property set to true, similar to what you found for PoshTools.
<Content Include="T4Toolbox.Dark.pkgdef">
    <CopyToOutputDirectory>Always</CopyToOutputDirectory>
    <IncludeInVSIX>true</IncludeInVSIX>
</Content>

I'm not sure if this will also take care of creating an <Asset/> definition in the generated extension.vsixmanifest. If not, we can explicitly add it to the source.extension.vsixmanifest.
To validate the changes after building a .vsix file locally and installing it, I would first use the registry editor to find the expected data under the HKEY_CURRENT_USER\SOFTWARE\Microsoft\VisualStudio\14.0_Config\Themes\{1ded0138-47ce-435e-84ef-9ec1f439b749}\T4Toolbox registry key. If the settings are there, it means that the T4Toolbox.Dark.pkgdef was added to the VSIX package and imported correctly. Once that is established, I'd try switching to the dark theme in Visual Studio options and verify that colors defined in the .pkgdef file were applied to T4 elements in a .tt file. If they aren't, it would mean that the contents of the .pkgdef file are wrong.

Thanks for the help. Testing & working through it now. (I'm a n00b @ this -- extending Vs.) My default theme is "Dark" -- thus, I see it right away (registry or not, my Experimental instance launches Dark). One possible future Note: switching back and forth (between Themes), I believe, requires subscribing to a notification from Visual Studio, or at least I saw this somewhere in some documentation (not fully tested; maybe it just works in VS 2015).

Great news. :+1: I'm looking forward to the pull request.
Why do you think detection of theme switching is necessary? Do you see the default T4 Toolbox colors when you switch from Dark to Blue or Light theme in your experimental instance of Visual Studio?

Just got an update on the NullReferenceException bug. The bad news is that it is still happening in the newly released Visual Studio 2015 version of the Color Theme Editor. The good news is that they are promising to release a "different tool" that should work for editing extension color themes. In the meantime, it's nice that we don't have to go to Visual Studio 2013 to edit the .pkgdef files anymore.


Add Tab always creates PowerShell session

I like to use Windows Terminal to access WSL. And it is useful to have multiple tabs.
But every time I hit + to add a tab from WSL terminal session, it spawns a PowerShell tab not another WSL session

Open the settings and change your defaultProfile.

Open the settings and change your defaultProfile.


Refresh listpage

I fixed #13 this issue.

Thank you for all this commits. I gone merge this night lately.


@conda-forge-admin,please add bot automerge

@conda-forge-admin,please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/aws-c-cal-feedstock#4.


Warn Redhat needs selinux::disabled instead of can't find ./mysql/plugin.frm

I note #305 has been closed and that RedHat platforms need selinux::disabled
Per https://github.com/afklm/jira/issues/71 - there is no catch of this  - instead errors exhibit symptoms that MySQL "can't find file".

Look in /var/log/audit/audit.log, if the auditd is running. You'll see the errors there.
In the very short term, selinux::permissive is enough to allow mysql to start, and to get logs of errors for fixing the issue.. But turning off SELinux is much like the pupular directions set up a "mysqldump --tab" directories with 777 permissions: it workd, but it's a gross security problem.
The appropriate changes to set up MySQL repository directories with the right SELinux permissions  are documented at https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/Managing_Confined_Services/sect-Managing_Confined_Services-MySQL-Configuration_Examples.html. I don't have time right now to submit a patch, but that's where to start.


CSHARP-766 LocalDate bug fix

For certain dates, the LocalDate ctor computes the wrong date from the given timestamp (days since epoch centered in 2^31). Added these scenarios to the existing unit tests and replaced the implementation with a port from http://howardhinnant.github.io/date_algorithms.html#civil_from_days

Your comment disappeared somehow @jorgebay so writing here:
I didn't name that one exactly like that but added a comment explaining that particular computation.
Also added names and some comments to this method's code.


top-academy.ru

Hello!
I am asking you to add an educational institution top-academy.ru to the JetBrains list.
top-academy.ru offers a long-term (> 1 year) course related to IT (Java, JavaScript, SQL and others)

the university official website URL, if it is different from the domain you are submitting

https://msk.top-academy.ru/

a URL of a page on the official website where a long-term (>1 year) IT related course is offered by the university

https://msk.top-academy.ru/programmer

a URL of a page or some other proof (.pdf or a screenshot are OK) showing that the university recognizes the domain which you are submitting as an official email domain for the enrolled students

https://drive.google.com/file/d/1k9Qze81-ennPWu5Sofu66J7MXA9y1Za9

We merge pull requests manually and check the information which you have provided us with before merging it. Thus, if you wish to make the verification process easier for us and therefore much quicker, please mention the following in your comment to the request:

the university official website URL, if it is different from the domain you are submitting
a URL of a page on the official website where a long-term (>1 year) IT related course is offered by the university
a URL of a page or some other proof (.pdf or a screenshot are OK) showing that the university recognizes the domain which you are submitting as an official email domain for the enrolled students.

@sproshchaev I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host t.top-academy not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


cmd/trace: always opening browser, not printing profile

Go version
go version go1.22.2 linux/amd64
Output of go env in your module/workspace:
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/my-user/.cache/go-build'
GOENV='/home/my-user/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/my-user/.local/share/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/my-user/.local/share/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/lib/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/lib/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.22.2'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/tmp/proj/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build1974410770=/tmp/go-build -gno-record-gcc-switches'

What did you do?
#!/usr/bin/env bash

set -o errexit -o pipefail -o nounset

# create a trivial module that supports 1.21.0+
go mod init m
go mod edit -go=1.21.0

cat <<'EOF' > lib.go
package lib

func Add(x int, y int) int {
	return x+y
}
EOF

cat <<'EOF' > lib_test.go
package lib

import (
	"testing"
)

func TestAdd(t *testing.T) {
	if Add(1,2) != 3 {
		t.Fatal("forgot how to add")
	}
}
EOF

# generate a trace using go1.21.0 ...
go1.21.0 test -trace=1_21_trace.out ./...

# and go1.21.0
go1.22.0 test -trace=1_22_trace.out ./...

What did you see happen?
When running go tool trace with the trace generated by go1.21.0 with -pprof a profile is printed to stdout:
$ go1.21.0 tool trace -pprof=net 1_21_trace.out | wc -c
93
$ go1.22.0 tool trace -pprof=net 1_21_trace.out | wc -c
90

This is expected
doing the same with the profile from go1.22.0 opens the browser:
$ go1.22.0 tool trace -pprof=net 1_22_trace.out | wc -c
2024/04/11 14:49:17 Preparing trace for viewer...
2024/04/11 14:49:17 Splitting trace for viewer...
2024/04/11 14:49:17 Opening browser. Trace viewer is listening on http://<IP_ADDRESS>:40941

This is unexpected
What did you expect to see?
Per the docs:
$ go1.22.0 tool trace -h
Usage of 'go tool trace':
Given a trace file produced by 'go test':
	go test -trace=trace.out pkg

Open a web browser displaying trace:
	go tool trace [flags] [pkg.test] trace.out

Generate a pprof-like profile from the trace:
    go tool trace -pprof=TYPE [pkg.test] trace.out

When I pass the -pprof flag I expect a profile to be generated

I see for v2 tracing pprofFlag is passed to the v2 main here but from what I can see the new main doesn't use this flag at all? Is it just that this functionality hasn't been implemented for v2?

@golang/runtime

Oops! This is an embarrassing oversight. Yeah, all the underlying code was ported, but the command-line flags got lost.

It gets worse -- turns out for a long time the -pprof flags would produce profiles that accidentally filter out every goroutine. I sent https://go.dev/cl/578356 to fix this for at least the new traces.

Thanks for the quick fix!


Update Field quotes interpretation + help text

The Field quotes help text is currently the following:

[ ] Can the parser really not deal with quoted and unquoted columns and/or mixed use within a column? This is very common behaviour in CSV writers.
[ ] The newline and carriage returns should probably not have the parenthesis, as the character is not visible.
[ ] Bug: Clicking any of the options does not populate the field (in contrast with Multi-value Delimiter, which does work)
[ ] Why not use a dropdown to set this field?
[ ] Why not set this field to " by default for csv files?

I uploaded this file: https://github.com/tdwg/camtrap-dp/blob/1.0/example/deployments.csv

It has a mixture of quoted and unquoted values across columns (all are unquoted, except for habitat and deploymentComments)
It has a mixture of quoted and unquoted values within the habitat and deploymentComments column (only values with , are quoted)
I set fieldQuotes to "

This publishes fine, so it seems the help text is to strict.

Bug: Clicking any of the options does not populate the field (in contrast with Multi-value Delimiter, which does work)

I don't see that in any test IPT

Why not use a dropdown to set this field? This also avoids users setting double characters.

Dropdown would restrict choice to those three. I think we should just leave it as is

If not dropdown, than perhaps the field should be restricted to a single character?

And indeed, I cannot replicate the issue with "Clicking any of the options". Seems to work fine now

If not dropdown, than perhaps the field should be restricted to a single character?

Don't want to add additional validation there. I think we're fine, the field will be set automatically most of the time anyway


Any plans on supporting python2?

I haven't looked into the code closely enough to see how easy it would be to port to python2, but I'm curious why you require python3?

+1 on this. I'm using this in a Python project and the Python 3 dependency creates alot of awkwardness.

I'd like to take a stab at converting the codebase to Python 2.7. What specific Python3 features do you use so I can see if this is feasible?

Looking through the code base I actually don't see any Python 3 features actually being used. Does one of the libraries selective search depends on have Python 3 dependencies?

FYI I've forked selective_search.py and back ported it to Python 2.7; I've also gotten it running on Mac OS X. The fork:
https://github.com/BradNeuberg/selective_search_py
I can submit this upstream if @belltailjp is interested.


Error: table device had 10 columns but 11 values were supplied

Describe the bug
I just made a fresh install of this tool and no matter what command I run I get this error:
error: table device had 10 columns but 11 values were supplied

I tried the suggested fix in this issue but it didn't help.
Every time I run a command I'm promoted to go through the 2FA main authentication  process. Is this normal?
To Reproduce
Steps to reproduce the behaviour:

Make a fresh install of dcli
Run i.e. dcli read dl://SOME-ID/field (or any other command).
For me this produces the following error:

error: table device had 10 columns but 11 values were supplied

Expected behavior
To be able to retrieve my secrets using the cli.
Screenshots

Environment (please complete the following information):

MacOS
Version: 15.1 (24B83)

Manually deleting the database is what helped in the end. Figured it out thanks to this comment.

Hey, glad you found the solution, thanks for sharing!


Removed the cookies from the remote node rules.

The rest of the ovs sdn rules had removed them in other patches.  This catches the other cases we hadn't yet changed.

LGTM

LGTM after ravi's comments.


add key to chart.

Resolves issue with title not reactively updating when chart changes.
Attempted multiple resolutions to resolve.

Using a watcher could update the title in chartOptions, but the chart would not update to show the new title.

Bug link from the vuechartjs page is https://github.com/apertureless/vue-chartjs/issues/1031

This Resolves #523 by binding a key to the statsUsageChart.

Please check the following

[x] Do the tests still pass? (see Run the Tests)
[x] Is the code formatted properly? (see Linting (Formatting))
For New Features:

[ ] Have tests been added to cover any new features or fixes?
[ ] Has the documentation been updated accordingly?

Please describe additional details for testing this change

@seriouslysean @itsalaidbacklife package version changed.


Suggestion: Mark all functions that represent deprecated paypal api resources as deprecated in godoc comment.

A comment string`that looks something like this so they are clearly marked in godoc
// Deprecated: This API resource is deprecated by PayPal.

Just to make godoc clearer like this https://pkg.go.dev/github.com/plutov/paypal/v4#Resource

Hi is there something I can contribute to ?

@sbshah97 yes please review the cpde and add the annotations.


SUGGESTION: Increase opacity of the text box of main page

The text box over the carousel of the main page has very little opacity, making its text difficult to read and comprehend. The opacity should be increased for better readability and visibility.
Under GSSOC'24, I would like to work on this issue and make improvements to the website's UI.

I am looking to fix this bug if @Suchitra-Sahoo allow me to fix this particular bug

Hi !! Using my css knowledge would like to fix this issue kindly assign it to me ..


Bug in HypreParMatrixFromBlocks

Hi, all!
I prepared an example to reproduce a bug in HypreParMatrixFromBlocks, to be more precise, it occurs inside Hypre lib.
For me, it fails with mpirun -n NP  reproduce_hypre_from_blocks_bug.exe for NP > 1 both in MFEM 4.3 and MFEM 4.5.2 with the following message:

I discovered that error occurs in hypre_DataExchangeList function in HYPRE lib, because
         hypre_MPI_Irecv(response_ptrs[i], max_response_total_bytes,                          hypre_MPI_BYTE, contact_proc_list[i],                          response_tag, comm, &response_requests[i]);
is called with rank contact_proc_list[i] equal to N of MPI ranks, while maximum rank is N-1. But I have no idea why it happens :)
reproduce_bug.zip

Duplicate of #3893


Add new flag to store timestamps as UTC time

Azure DocumentDB stores data in JSON format.  Since JSON doesn't have a defined datetime format, Microsoft converts the Timestamp to an ISO 8601 string.  To use these strings in a range comparison operations (less than, greater than, between,  etc...), it's important that all Timestamps be represented in the same timezone.  This flag allows the user to force Timestamp to use UTC time so they can safely be used in ranger operations.

In terms of a backwards-compatible implementation this looks like the way to go.
It'd be nice to support a couple more options in the future, e.g. seconds-since-epoch or perhaps the custom composite datetime/epoch option described second here. Maybe worth considering for the next major version of this sink.
Thanks for the PR!

:+1: looks good.
That article looks good @nblumhardt - I'll be honest I haven't kept up to date with DocumentDb and it's capabilities.


chore: revert "feat: add support for PSC"

Reverts GoogleCloudPlatform/alloydb-go-connector#513

Will address the dependency updates in a separate PR. That's what's causing the govulncheck to fail.


Make groupBy trim size configurable at Broker

Currently, the groupBy trim size for groupByDataTableReducer is determined as Math.max(limit * 5, DEFAULT_MIN_NUM_GROUPS)
DEFAULT_MIN_NUM_GROUPS is hardcoded to 5000 and it's not configurable.

This PR makes it configurable so that users can control the accuracy of their groupBy queries.

Codecov Report

Merging #11958 (fee5a7c) into master (f14700a) will decrease coverage by 62.93%.
Report is 287 commits behind head on master.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #11958       +/-   ##
=============================================
- Coverage     62.92%    0.00%   -62.93%
=============================================
  Files          2318     2309        -9
  Lines        124328   125338     +1010
  Branches      18980    19396      +416
=============================================
- Hits          78234        0    -78234
- Misses        40539   125338    +84799
+ Partials       5555        0     -5555

Flag
Coverage Δ

integration
0.00% <0.00%> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <0.00%> (ø)

java-11
0.00% <0.00%> (-62.91%)
:arrow_down:

java-17
?

java-20
?

java-21
0.00% <0.00%> (?)

skip-bytebuffers-false
0.00% <0.00%> (?)

temurin
0.00% <0.00%> (-62.93%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...e/pinot/core/query/reduce/BrokerReduceService.java
0.00% <ø> (-84.00%)
:arrow_down:

...not/core/query/reduce/GroupByDataTableReducer.java
0.00% <ø> (-67.24%)
:arrow_down:

...inot/core/query/reduce/StreamingReduceService.java
0.00% <ø> (-26.93%)
:arrow_down:

...che/pinot/core/query/reduce/BaseReduceService.java
0.00% <0.00%> (-82.36%)
:arrow_down:

...va/org/apache/pinot/spi/utils/CommonConstants.java
0.00% <0.00%> (-21.12%)
:arrow_down:

...not/core/query/reduce/DataTableReducerContext.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 2097 files with indirect coverage changes
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Can you help add this new config into the Pinot documentation?

@Jackie-Jiang  Added the new config to documentation - https://docs.pinot.apache.org/users/user-guide-query/query-syntax/grouping-algorithm

@vvivekiyer Thanks for adding the documentation! Seems we still have some configs not able to be overridden by query option, including this new added one. Do you want to help contribute the query option override for them?

@Jackie-Jiang sure, I'll create a PR to add queryOptions for the following configs:

pinot.server.query.executor.groupby.trim.threshold
pinot.broker.min.group.trim.size
pinot.server.query.executor.num.groups.limit

Query option override PR - https://github.com/apache/pinot/pull/11984
cc: @Jackie-Jiang


[WIP] Use arm neon instructions to optimize tcopy operation

This optimization can improve performance of tcopy operation nearly twice. PTAL.

LGTM, thanks.


Just a question.

So, ModEngine2 stores it's mods and directory in a totally separate location from Elden Ring (for example, on my Desktop). I have a question.
By clicking on launchmod_eldenring.bat I launch the game WITH my mods (as intended).
My question is, if I launch the game through Steam, will I launch the game WITHOUT Mods? Or do I have to clean out the mods folder on my desktop before I launch the game?
Basicly... can I use Steam to launch an unmodded game, close it, then launch a modded game using launchmod_eldenring.bat... or do I have to be much more careful and always delete everything in my mod folder and do cleanup?

Hi,

My question is, if I launch the game through Steam, will I launch the game WITHOUT Mods. [...]
Basicly... can I use Steam to launch an unmodded game, close it, then launch a modded game using launchmod_eldenring.bat... [...]

That's correct, yes. Mod Engine doesn't replace any core game files, instead it just provides a launcher that wraps around the game. This keeps launching via Steam and launching via the Mod Engine launcher completely separate.

That's amazing! SO I can launch on steam with a clean game! Could you please include that on the main page? Maybe I'm just dumb but I only realized that AFTER I stared at how the mod works XD


add the database as a dependency for the app

this will ensure the database is launched when running the app directly

What does this fix?

This directly fixes make shell, which relies on automatically loading services, as apposed to make serve, which manually launches all the services

As far as I can see, it doesn't fix it for me. I can provide more information if that helps diagnose? Or we could chat?

(It looks like it brought up the other containers correctly, but didn't write to their dbs:
# Mysql2::Error:
#   Unknown database 'govwifi_admin_test'

ah, ok I'll prepare a change specific for that.
The serve and test commands both populate the database at launch time. Will prepare a fix.
While this PR doesn't fix that issue, it's still best practice to associate an app with its dependent services


Webhook unable to mutate Secret when using external Vault with Vault-namespaces

Describe the bug:
Our organization uses Vault Enterprise, and our team was assigned a Vault namespace.
We used the helm chart to deploy the Vault webhook to our K8S cluster, and we are able to mutate Pods and grab values from our Vault instance in our datacenter.  As an example we are able to set the Pod's environment variable with this value from Vault:
vault:kv/data/parent/child/gc#SOME_VAR
The key to making this work was to set the VAULT_NAMESPACE environment variable in the POD:
kind: Deployment
...
  template:
    metadata:
      annotations:
        vault.security.banzaicloud.io/vault-addr: "https://external-vault.com:443"
...
        env:
        - name: VAULT_NAMESPACE
          value: Foo/Bar
        - name: SOME_VAR
          value: vault:kv/data/parent/child/gc#SOME_VAR

We're trying to mutate a K8S secret to read the same value
apiVersion: v1
kind: Secret
metadata:
  name: remote-secret
  annotations:
    vault.security.banzaicloud.io/vault-addr: "https://external-vault.com:443"
    vault.security.banzaicloud.io/vault-role: "default"
    vault.security.banzaicloud.io/vault-skip-verify: "true"
    vault.security.banzaicloud.io/vault-path: "kubernetes"
type: Opaque
data:
  # value below is vault:kv/data/parent/child/gc#SOME_VAR base64 encoded
  vaultdata: dmF1bHQ6a3YvZGF0YS9wYXJlbnQvY2hpbGQvZ2MjU09NRV9WQVIK

I tried to use this secret in a Deployment
kind: Deployment
...
  template:
    metadata:
      annotations:
        vault.security.banzaicloud.io/vault-addr: "https://external-vault.com:443"
        vault.security.banzaicloud.io/vault-role: "default"
        vault.security.banzaicloud.io/vault-path: "kubernetes"
...
      env:
        - name: VAULT_NAMESPACE
          value: Foo/Bar
        - name: DEBUG
          value: "true"
        - name: FROM_SECRET
          valueFrom:
            secretKeyRef:
              name: remote-secret
              key: vaultdata

However, we get the following error from the Pod
$ kubectl logs pod-12345
time="2020-03-11T19:39:42Z" level=info msg="Received new Vault token"
time="2020-03-11T19:39:42Z" level=info msg="Initial Vault token arrived"
time="2020-03-11T19:39:42Z" level=info msg="Renewed Vault Token"
time="2020-03-11T19:39:42Z" level=fatal msg="key not found: SOME_VAR\n" app=vault-env

Expected behaviour:
The secret from the external Vault instance from that particular namespace should be fetched.
Steps to reproduce the bug:
See above
Additional context:
Environment details:

Kubernetes version (e.g. v1.10.2): 1.14
Cloud-provider/provisioner (e.g. AKS, GKE, EKS, PKE etc): EKS
bank-vaults version (e.g. 0.4.17): banzaicloud/vault-secrets-webhook 0.9.0 image
Install method (e.g. helm or static manifests): helm
Logs from the misbehaving component (and any other relevant logs):
Resource definition (possibly in YAML format) that caused the issue, without sensitive data:

/kind bug

You can annotate either the secret (inplace) or pod. Based on the snippet, you don’t need the annotations (annotate only the deployment). The error is slightly unrelated, as the secret is not available on that path.

Ok, I removed the annotation from the Secret and only put them in the Deployment/Pod, but I still get the same error.  As I said at the beginning, I am able to get the same secret from the same path as an Environment Variable from the first Deployment/Pod.

Nevermind, got it to work.  The base64 encoder I used added an extra newline character /n


Can i use it for spreading my mining exe?

Sir...can i download this.for my silent miner...exe file..what is it for? And how it works please tell me

It's a builder for a downloader, spreading wise it won't really matter, except in the case the downloader has less Windows Defender detections than the miner. Since then you could use the downloader to first add the exclusions before the miner gets installed.


CopilotChat: Replace "SK" with "SemanticKernel" and add App Service Plan allowable values.

Motivation and Context
Remove most occurrences of "SK" from CopilotChat deployment
Description

Renamed most occurrences of "SK" to either "SemanticKernel" or "SemKer" throughout CopilotChat
Updated App Plan SKUs with a list of allowed values.

Still doing some validation - hold merge until I've finished.

This change is missing:
Package URI from https://skaasdeploy.blob.core.windows.net/api/skaas.zip to be https://semantic-kernel-deploy.blob.core.windows.net/api/Semantic-Kernel.zip

This change is missing:
Package URI from https://skaasdeploy.blob.core.windows.net/api/skaas.zip to be https://semantic-kernel-deploy.blob.core.windows.net/api/Semantic-Kernel.zip

We'll need to standup another blob service and populate it. I wanted to not block these changes on that move. I'll look at that next.


Add disable width cast API arg

For https://github.com/rdaly525/coreir/pull/898

Glad this API is getting use and "working" :)


ARROW-11101: [Rust] rewrite pre-commit hook

Currently,  the client side git pre-commit hook checks and runs cargo fmt with stable version, but the CI check may fail in nightly version occasionally even if the code has been formatted with stable.
It seems that, this problem can be resolved by: running cargo +nighty fmt before  cargo +stable fmt. Thus pre-commit.sh should be updated in this way.
In this PR:

only check staged *.rs files and exit if no changes
cargo clippy is moved before cargo fmt
run cargo +nighty fmt before  cargo +stable fmt
show more concise tip messages

Codecov Report

Merging #9072 (552bb06) into master (cc0ee5e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9072   +/-   ##
=======================================
  Coverage   82.55%   82.55%
=======================================
  Files         203      203
  Lines       50043    50043
=======================================
+ Hits        41313    41315    +2
+ Misses       8730     8728    -2

Impacted Files
Coverage Δ

rust/parquet/src/arrow/schema.rs
90.93% <0.00%> (+0.31%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc0ee5e...552bb06. Read the comment docs.

Codecov Report

Merging #9072 (552bb06) into master (cc0ee5e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9072   +/-   ##
=======================================
  Coverage   82.55%   82.55%
=======================================
  Files         203      203
  Lines       50043    50043
=======================================
+ Hits        41313    41315    +2
+ Misses       8730     8728    -2

Impacted Files
Coverage Δ

rust/parquet/src/arrow/schema.rs
90.93% <0.00%> (+0.31%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc0ee5e...552bb06. Read the comment docs.


add tooltip to loadout pane

trivial enhancement to add the tooltip from the main pane to the loadout pane. Thanks for the great software!

Thanks!


Insert rise TypeError: S is not a function

Hello.
I have collection and simple schema
var Schemas = {};
SimpleSchema.debug = true;
Weight = new Mongo.Collection("weight");
Schemas.UserWeight = new SimpleSchema({
    createdBy: {
        type: String
    },
    weight: {
        type: String
    },
    createdAt: {
        type: Date
    }
});
Weight.attachSchema(Schemas.UserWeight);

and I have an insert
 Weight.insert({
                weight: weightVar,
                createdAt: new Date(),
                createdBy: measureOwner
            }, function(error, result){
                console.log(error.invalidKeys);
            });

and insert raize an error TypeError: S is not a function in file aldeed_simple-schema.js:2618.

It is on client side. I see it on browser's console in debug mode. Is it possible to conflict with another plugin?

Are you using pkgs that enable requirejs? That might cause this.

There is list of my packages:
accounts-password       1.1.0  Password support for accounts
accounts-ui             1.1.5  Simple templates to add login widgets to an app
aldeed:collection2      2.3.2  Automatic validation of insert and update operations on the client and server.
autopublish             1.0.3  Publish the entire database to all clients
email                   1.0.6  Send email messages
gadicohen:famous-views  0.1.32  Blaze Views for Famous; doing Famous Meteor-style
insecure                1.0.3  Allow all database writes by default
iron:router             1.0.7  Routing specifically designed for Meteor
jquery                  1.11.3_2  Manipulate the DOM using CSS selectors
meteor-platform         1.2.2  Include a standard set of Meteor packages in your app
mizzao:bootstrap-3      3.3.1_1  HTML, CSS, and JS framework for developing responsive, mobile first projects ...
mrt:moment              2.8.1  Moment.js, a JavaScript date library for dates, packaged for Meteor. See http:/...
raix:famono             0.9.27  Library bundler supports use of libraries like Famous, via git/bower and requi...

Yeah, raix:famono is the culprit as that adds requirejs support. It's really an issue with the simple-schema package, though. It should be a little smarter about making sure window.S is defined. I created an issue to track here: https://github.com/aldeed/meteor-simple-schema/issues/317


bugfix: exanding '~' before attemtping to create a user spec path

Pull Request Test Coverage Report for Build 899389623

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.008%) to 90.635%

Totals

Change from base Build 899364581:
0.008%

Covered Lines:
1113

Relevant Lines:
1228

💛  - Coveralls


Fix Docker image issues regarding UID/GIDs

Hope this fix can be release asap :)

This is done actually, forgot to close 😉

Wondering actually what fixes have been done? Any documentation to refer?
Because I use the latest docker image, still having the same permission issue with different uid/gid.

We should update the README.md to include the flags to forward uid/gid.
See https://github.com/cdr/code-server/blob/89d78a592161ee6d6e6a12c9ee9fe1c564fc16e4/ci/release-image/Dockerfile
fixuid will adjust all files in the container to whatever UID/GID the image was ran with so there should be no issues as long as you are running it with the right uid/gid but I'd imagine many users are just using the default which is uid 1000.

See https://github.com/cdr/code-server/issues/1425


Allday event display in week-view

Is there a way to define, when react-big-calendar shows up an event in the "allday" cell above the timeline in week-view? For my purpose it is a bit confusing, that allday implicitly means from [date] - 00:00:00 to [date+1 day] - 00:00:00 .
For my purpose, it would be nice to have also events shown in the "allday" cell above when start ist 00:00:00 and end is 23:59:00 of the same day.
I know there is the showMultiDayTimes property, but this is just a boolean. It would be nice if I could dynamically define this property based on the event. Then i could use a allDay flag in each event to either show it in the allday cell or not.

take a look https://github.com/jquense/react-big-calendar/issues/2021


Install updated centos-release-scl (conditionally)

Currently, some Google images (and possibly others) are using the centos-release-SCL package to install this repository. It has recently been updated to centos-release-scl and the repository name has changed.

LGTM


Error: Failed to download resource "openjdk@11--patch"

3teedeMacBook-Pro:~ 3tee$ brew install jenkins
Updating Homebrew...
Warning: You are using macOS 10.12.
We (and Apple) do not provide support for this old version.
You will encounter build failures with some formulae.
Please create pull requests instead of asking for help on Homebrew's GitHub,
Twitter or any other official channels. You are responsible for resolving
any issues you experience while you are running this
old version.
==> Downloading https://mirrors.ustc.edu.cn/homebrew-bottles/bottles/autoconf-2.
Already downloaded: /Users/3tee/Library/Caches/Homebrew/downloads/f601e9d801a5ceb7e536b720e8e57d74e3bae6fb99f0e0c163c1f78b4b92e404--autoconf-2.69.sierra.bottle.4.tar.gz
==> Downloading https://raw.githubusercontent.com/Homebrew/formula-patches/2087f
curl: (35) Server aborted the SSL handshake
Error: Failed to download resource "openjdk@11--patch"
Download failed: https://raw.githubusercontent.com/Homebrew/formula-patches/2087f9d0/openjdk%4011/xcode12.diff

Sorry, but this issue tracker is for bugs in brew, and this doesn't look like one. Also:

Warning: You are using macOS 10.12.
We (and Apple) do not provide support for this old version.
You will encounter build failures with some formulae.
Please create pull requests instead of asking for help on Homebrew's GitHub,
Twitter or any other official channels. You are responsible for resolving
any issues you experience while you are running this
old version.

Sorry, but this issue tracker is for bugs in brew, and this doesn't look like one. Also:

Warning: You are using macOS 10.12.
We (and Apple) do not provide support for this old version.
You will encounter build failures with some formulae.
Please create pull requests instead of asking for help on Homebrew's GitHub,
Twitter or any other official channels. You are responsible for resolving
any issues you experience while you are running this
old version.


chore: Various improvements to COUNT queries

Add an integration tests that uses an invalid collection name (i.e. __invalid__).

Splitting into individual PRs.


Prefer yaml_pipeline in error messages

Starting in https://github.com/apache/beam/pull/29916 we've preferred yaml_pipeline to pipeline_spec (and we do so in our docs), this updates the error to be more explicit
Part of #30500

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @polber @robertwb


gobject-introspection wants to use darwin host otool instead of our stdenv one

It then fails on machines without command-line tools or Xcode installed.

Yep, I think I've bumped into the same thing trying to install nixpkgs.pass.
xcode-select: note: no developer tools were found at '/Applications/Xcode.app', requesting install. Choose an option in the dialog to download the command line developer tools.
ERROR: can't resolve libraries to shared libraries: gobject-2.0, glib-2.0
Makefile:3429: recipe for target 'GLib-2.0.gir' failed
make[2]: *** [GLib-2.0.gir] Error 1
make[2]: Leaving directory '/private/var/folders/5g/3kx3mc191y93shpp91bg7jyh0000gn/T/nix-build-gobject-introspection-1.46.0.drv-0/gobject-introspection-1.46.0'
Makefile:2720: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/private/var/folders/5g/3kx3mc191y93shpp91bg7jyh0000gn/T/nix-build-gobject-introspection-1.46.0.drv-0/gobject-introspection-1.46.0'
Makefile:1499: recipe for target 'all' failed
make: *** [all] Error 2
builder for ‘/nix/store/w904wb32rvfhq08y1x1azz67328nb36f-gobject-introspection-1.46.0.drv’ failed with exit code 2
cannot build derivation ‘/nix/store/a7ib57rywq7ksgcqnfd1xkn6ibflfypw-atk-2.18.0.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/gjrgylvwd30ljyfwflzxyd4a9k0ykqdw-gdk-pixbuf-2.32.3.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/zb1360afrvc16ccvf0a6nlgpixs54z1y-pango-1.38.1.drv’: 1 dependencies couldn't be built
building path(s) ‘/nix/store/r8n2rcwv0fysnc1jzs5v6xsvngpnhmvr-password-store-1.6.5.tar.xz’
cannot build derivation ‘/nix/store/c7c9yiiklp0rlgymk2vkh84yxvjcf866-gtk+-2.24.29.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/ak3bf232r7scbfq8m61whyf0lvm5swwr-pinentry-0.9.6.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/i1madbkmv202rzrsb5qha7yw2aqm3qrf-gnupg-2.0.29.drv’: 1 dependencies couldn't be built
killing process 46716
cannot build derivation ‘/nix/store/5msn2c2cb21zmja8b1nbv3wlw6pi2i5r-password-store-1.6.5.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/5msn2c2cb21zmja8b1nbv3wlw6pi2i5r-password-store-1.6.5.drv’ failed

This is nothing but a punt but is it something to do with the hardcoded:
src = "/usr/bin/otool";

on line 13 of pkgs/os-specific/darwin/otool/default.nix?

Package marked broken in 1c49f8fe33b5079bdc1371ba5d2c8dc206a8ad2a.

I hit a couple packages which depended on the now-broken-on-darwin gobject-introspection, and tried my hand at seeing what was up.
I hit a few dead ends, but eventually discovered that the nixpkgs-installed otool itself looks to be to blame:
[nix-shell:~/Code/Nix/nixpkgs/gobject-introspection-1.46.0]$ otool -L `which otool`
/nix/store/hcndf7g6b47acpvmpnxjm55nizss2lcz-otool/bin/otool:
	/usr/lib/libxcselect.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1213.0.0)

Just followed up, and it looks like this is all just because our current otool package is just a symlink to /usr/bin/otool. In light of that, can we unmark gobject-introspection as broken and instead make an issue to fix the issue in otool (figure out how to compile from source or something)?

The real otool package is cctool. That otool thing looks ancient and should probably be removed.

Ah, thanks @copumpkin. #14134 should be a fix.


use ssh to fetch from github

@vjt #1 was accidental merged. sorry - did you mean something like that?

yes that's better


pre_add_dockerfile plugin can get N-V-R from LABELs (#96)

Looking at code, shlex takes care of quotes, right? So the key is not "key", instead is key.
Otherwise LGTM, very nice job!

Yes, that's the reason for using shlex.
I've added one more testcase (test_adddockerfile_nvr_from_labels2) and I'm merging it myself.


Fix the AdMediaView size warning in the example app

Fixes #71

This only fixes it on small devices. Size should be dynamic