Enable clang+bazel as part of the TFLM github CI.

We patch some of the TF workspace and BUILD files to reduce the number of downloads as part of a bazel build.
We can revisit this decision if the maintenance overhead from this patching becomes too high.
Also, there may be an opportunity to further reduce the downloads, but this change has made a decision to leave the TfLite build files unchanged and incur the cost of the additional downloads that are needed for TfLite but not for TfLite Micro.
Fixes #46465
Fixes http://b/177672856

0a66fd0 (#46467) is the only commit that is part of the current PR.
The first commit: 4dadd12 (#46438) is part of #46438.
And the third commit 335cf39 (#46467) is only needed until an internal change is reviewed.

0a66fd0 (#46467) is the only commit that is part of the current PR.
The first commit: 4dadd12 (#46438) is part of #46438.
And the third commit 335cf39 (#46467) is only needed until an internal change is reviewed.

Let's discuss this more on Tuesday.
The change isn't the cleanest and certainly a compromise.
I have stripped down the .bzl files in the top-level tensorflow directory to avoid downloading dependencies that are not needed for TFLM.
I'm making the trade-off that the benefits of a faster CI (and clearer understanding of what is needed for TFLM) are worth the potential maintenance overhead from having a different version of these files for the purposes of the TFLM github CI.

Let's discuss this more on Tuesday.
The change isn't the cleanest and certainly a compromise.
I have stripped down the .bzl files in the top-level tensorflow directory to avoid downloading dependencies that are not needed for TFLM.
I'm making the trade-off that the benefits of a faster CI (and clearer understanding of what is needed for TFLM) are worth the potential maintenance overhead from having a different version of these files for the purposes of the TFLM github CI.


S|J: Add type safety to cms-lib module

Typesafety should be added wherever possible. A few suggestions where type safety should be added:

method parameters
method return values
if there's no return value for method (it's void), add void as the return to make it more specific
test files
object literals
if you need OCC types, take a look at #301's PR
if working with CMS components, as a generic type use <T extends Component>, where Component is an interface from projects/core/src/occ-models/occ.models.ts

The goal is to have a completely type safety code.

fixes: GH-436


nheko: mark as insecure

The package is no longer maintained and includes potential security
vulnerabilities (a use-after-free and several crashes) that are known
and not fixed in the version present in nixpkgs. They don't look too bad
judging from the trigger vectors mentioned in the changelog, but with
the project going unmaintained one of them becoming a security
vulnerability would likely not be noticed.
Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: nheko
Partial log (click to expand)
~/.config/nixpkgs/config.nix, like so:

     {
       permittedInsecurePackages = [
         "nheko-0.5.5"
       ];
     }

No attempt on x86_64-linux (full log)
The following builds were skipped because they don't evaluate on x86_64-linux: nheko
Partial log (click to expand)
~/.config/nixpkgs/config.nix, like so:

     {
       permittedInsecurePackages = [
         "nheko-0.5.5"
       ];
     }

backported in 14bb2f42bf7a74bd3ef3a17f7039d9e88e3ada4b.
@Ekleog in most cases there's no need to open a separate PR for backporting, just mention in your PR against master that it needs to be backported.  We prefer to backport using git cherry-pick -x to retain a reference to the original commit for easier tracking of changes.

Got it :) originally the PR on unstable completely dropped nheko, actually, and then I noticed someone else had updated it (so it was at the latest version and only needed a knownVulnerabilities)… sorry for having forgotten to close this one :)


tel_id in photoelectrons object is index rather than id?

Looking at a few events, I think that the telescope id in the Photolectrons object defined below is just the index rather than the telescope id itself. That is, it starts at zero and goes to n_tel - 1.
https://github.com/cta-observatory/pyeventio/blob/79228db01120acd49f4f34718ac99a4268ea3a3e/src/eventio/iact/objects.py#L299
This definition is different to the definition in the TelescopeEvent object which provides the actual id:
https://github.com/cta-observatory/pyeventio/blob/79228db01120acd49f4f34718ac99a4268ea3a3e/src/eventio/simtel/objects.py#L716-L723
Not a big deal, but if I am right and the fix is just replacing one definition with the other, it's probably worth it to fix (I can do it).

Looking at a few events, I think that the telescope id in the Photolectrons object defined below is just the index rather than the telescope id itself. That is, it starts at zero and goes to n_tel - 1.

This is a known issue in sim telarray, I will dig up some emails from Konrad, but the gist is, the object is correctly defined here in terms of doing the I/O of the eventio object, but simtel fills something "wrong".
I.e. the header struct defines this to be the telescope_id, which is why we parse it as such, but in case of simtel, it's actually not the same "telescope_id" as used everywhere else.
See e.g.:
https://github.com/cta-observatory/ctapipe/blob/3dc94da64dc1e96ed9316a612c8a6c67ada32af0/src/ctapipe/io/simteleventsource.py#L816-L820
and this issue / PR pair in ctapipe:
https://github.com/cta-observatory/ctapipe/pull/1338
https://github.com/cta-observatory/ctapipe/issues/1337
I'll leave this open here, so when we do eventio 2.0, we can include the fix here


Check for version 3.7 of Python

Resolves #89

Ah need to remove those checks

Not sure how to remove the CI checks. @PeterJCLaw are you able to do that please?

onit


Update messages.po - change "Back" translation to "Retour"

Thanks for this, but there is actually already a PR open to do this :) #6778


Feat/new list item

Hey, i added my new page to create new list-items for each category. Please Review :)

This looks really great, Phil! Congratulations on this great work. 🥳
I must confess that I don't fully understand all the code, so I would recommend a second review.
My comments:

you use px for margin and padding in many cases. Did you purposely choose not to use responsive units?
To me the amount of code for a single PR seems to be quite a lot. Maybe cut your stories a bit smaller in the future to make the workflow faster for everyone?

One more thing that probably concerns QA more: even if the button is grayed out, I can make empty entries.

@kai-franke about your comments:

(example link) i learned that you shouldn't use rem or em for margin or padding
yeah i noticed that. Thanks :)

Thanks for the last issue :) I didn't checked that


Integrate Zimagi Specification Architecture into main docs

See https://docs.google.com/document/d/1EwROwRnqkb2yuq3vYdRrUp5Gqp-IE95XBlQGUn4fITY/edit?ts=601b1806#

This remains to be done.  Will revisit in another documentation effort.  These docs are likely to change in structure.


⚠ Bofrost.fr has degraded performance

In 65ea596, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1696 ms

Resolved: Bofrost.fr performance has improved in dd880fc after 10 minutes.


Add: Raw data filtering - Crop Filter

@tomas-pluskal It seems that you have already added the raw data filters to MSDK which means that it is only the implementation in MZmine 3 which is missing. Is this correct?

Seems like that's correct.

That's a nice surprise :-) I will let you do the implementation in MZmine 3 when you have time.


Include pulsar-client-admin-api in the shaded version of pulsar-client-admin

In the following PR:
https://github.com/apache/pulsar/pull/9246
The API of the pulsar-client-admin was separated into another module.  However, the api module was not added to be included in the shaded version of pulsar-client-admin.  This creates dependency issues such as
java.lang.NoSuchMethodError: org.apache.pulsar.client.admin.PulsarAdminException.<init>(Lorg/apache/pulsar/shade/javax/ws/rs/ClientErrorException;)V

@freeznet Can you review this? I think this is related to one task you are working on.


GDScriptNativeClass: Allow getting static function as callable

partially fixes https://github.com/godotengine/godot/issues/89350

Thanks!


support cloud-init network-config

This adds basic support for a cloud-init network-config file.
network-config can be used for advanced network configuration, such as VLANs, which can't be configured using the default dhcpcd.
The provided default results in the same config as without this change, dhcp for eth0 (plus it won't have any effect because of the bug described below).
To make this work, a few additional steps are needed:

cloud-init creates the file /etc/network/interfaces.d/50-cloud-init.cfg. The intent is that ifup etc. should pick this up. Unfortunately they won't, because according to the man page, files in include folder must match the regex ^[a-zA-Z0-9_-]+$. - so it has to be renamed, or /etc/network/interfaces has to be updated
By default, dhcpcd tries to manage all network interfaces, so there will be a conflict when ifup attempts to configure the same interfaces (it will probably do nothing). The workaround is to disable dhcpcd to manage all interfaces the old-fashioned way.

Add the following to user-data to make this work:
runcmd:
  - 'mv /etc/network/interfaces.d/50-cloud-init.cfg /etc/network/interfaces.d/50-cloud-init'
  - 'systemctl disable dhcpcd'

power_state:
  mode: reboot

I know this is not very elegant yet. Disabling dhcpcd by default would get rid of one of the extra steps above, but then there would still be the bug which results in the "wrong" filename.
Let me know if you have any ideas on how to improve this 😄

Yes I saw that sample in the flash repo - that seems to be the official way in Raspbian now, at least as long as dhcpcd is used.
It seems that most distros are replacing the old ifupdown and /etc/network/interfaces scripts with new fancy stuff (such as dhcpcd, systemd-networkd or Ubuntu's netplan). While these work fine for a desktop, where 99% of users will just use DHCP, they make it a lot harder to manually configure things IMHO.
For example I couldn't find a way to configure VLANs with the default dhcpcd in Raspbian, while that's easy to accomplish using /etc/network/interfaces.
Cloud-Init's network-config will also not work with dhcpcd (it could work with netplan but I don't think that's supported in Debian). But nevertheless cloud-init will always create the 50-cloud-init.cfg file unless there is explicit config that tells it not to do that. Right now it just doesn't have any effect because of the source-folder bug.
So if we fix that source-folder bug, I think we also need to include a minimal network-config file with the content
config: disabled

to prevent cloud-init from creating the 50-cloud-init.cfg.
Then the users could decide whether they want to use network-config (and disable dhcpcd) or just use the default (which is probably fine for the majority).
Disabling dhcpcd by default would also work, with the network-config I included it will do DHCP on eth0, just that it's now done by ifup.
One more issue that I found is that /etc/resolv.conf is now managed by systemd-resolved, which also doesn't play nice with ifupdown - so any resolvers in network-config will not end up there. Still trying to figure out how to fix that...
Basically it's all a big mess... I just want my good old /etc/network/interfaces back 😄

I disabled dhcpcd and systemd-resolved in the chroot-script, installed resolvconv (which works with the ifup script to manage DNS) and added a fix for /etc/network/interfaces.
Now everything works out of the box. The default config will just use DHCP on eth0, so no change from the users perspective.
Custom network-config can be supplied if needed. I tested with the following network-config to setup a VLAN interface, static IP and DNS:
version: 1
config:
  - type: physical
    name: eth0
  - type: vlan
    name: eth0.80
    vlan_link: eth0
    vlan_id: 80
    subnets:
      - type: static
        address: <IP_ADDRESS>/24
        gateway: <IP_ADDRESS>
  - type: nameserver
    address:
      - <IP_ADDRESS>
    search:
      - home.m-koetter.de

If custom NTP servers are needed, this can be done in user-data for example:
ntp:
  enabled: True
  servers: ["<IP_ADDRESS>"]

runcmd:
  - "systemctl restart ntp"

Not sure whether these tweaks could be done in os-rootfs - only the Pi image supports cloud-init, right?

About to jump in and start doing a lot more cloud-init, this looks like a good fix!

Any update when it is planned to add PR #247 to Hypriot? I'd also appreciate having support for VLAN interfaces via the network-config file.

@michaelkoetter wow thank you, spend some time with the same issues, that helped me a lot! It would be also a nice PR to https://github.com/DieterReuter/image-builder-rpi64 I used this for my rpi k8s cluster and had the same issues.

Ok, YOLO, let's merge this.

When will be the next version of hypriot be released so we can test this?
PS: The circleci pipeline is currently failing, so I can't download the image from there

@Legion2 I kicked off a build today, Circle is green again. I‘ll draft a release later this week.

@StefanScherer It seems that since merging this PR the configuration of a static ip address on eth0 through user-data file does not work anymore (as I've reported in #359).
I'm not familiar with network-config, so by looking at the code of the PR I wondered:

As I still see user-data being used, and network-config added after, is network-config currently forcing dhcp on eth0 through this line: https://github.com/hypriot/image-builder-rpi/blob/4b5348a95ccee1e3c924d9c5c371bc8e075070f4/builder/files/boot/network-config#L6?
Does this PR introduce a new way of setting a static ip through a network-config? I may have missed some documentation updates but I did search.

@rbartoli https://cloudinit.readthedocs.io/en/latest/topics/network-config-format-v2.html
network:
  version: 2
  ethernets:
    eth0:
      dhcp4: false
      dhcp6: false
      addresses: [<IP_ADDRESS>/24]
      gateway4: <IP_ADDRESS>
      nameservers:
        search: [foo.local, bar.local]
        addresses: [<IP_ADDRESS>]

This should give kind of what you expect.

This PR also breaks adding dns servers via dhcpcd with
static domain_name_servers=<IP_ADDRESS> <IP_ADDRESS> <IP_ADDRESS>

in /etc/dhcpcd.conf.
I have tried adding nameservers with the network-config but that is not updating /etc/resolv.conf.


New rule: require-await

What version of this package are you using?
Latest
What problem do you want to solve?
Spending time debugging missing awaits on async function calls
What do you think is the correct solution to this problem?
Enable the require-await rule.
Are you willing to submit a pull request to implement this change?
If it's needed, sure.

Agree, similar to #1322, would be good to do some house keeping / hardening / updating of the async / await / Promise rules

I'm not sure how I feel about the #1322, but I'm definitely against the require-await rule.
As I understand, the following would break because of the unimplemented abstract async method in the super class.
class SuperClass {
  async doStuff () {
    await this.abstractMethod()
  }

  async abstractMethod() {
    throw new Error('Not implemented')
  }
}

class ExtendedClass extends SuperClass {
   async abstractMethod() {
     // await some async code here
   }
}

@bnb so you mean forgetting to add await when calling a function that's async, or do you mean creating an async function that it self doesn't contain any async code?
As far as I understand the issue description, you want to lint for the first type, but the require-await rule does as far as I understand protect against the latter.

The "warn if missing await on async function" rule have been discussed here on the ESLint issue tracker: https://github.com/eslint/eslint/issues/9787

@bnb do you mean forgetting to add await when calling a function that's async, or do you mean creating an async function that it self doesn't contain any async code?

You're correct, I want the former. My bad if I misunderstood the require-await rule.

And yeah, seems that's impossible so closing 👍🏻


Update web to latest master commit

The current dev commit has an issue where it doesn’t show the number of candies due to the change in the API several days ago.
This moves the the web submodule forward by 27 commits.

This isn't latest commit.. there are more than 25 commits for get latest


Update development/build.md with detailed build & test directions

I updated the build documentation with what I learned from the dev community as a newbie recently, for the other future newbies.

Build failure on 0.13.SNAPSHOT
Problem on druid-s3-extensions

I referred the build guides of other projects, like:

Spark
Kafka
Hadoop

Hi @dongjinleekr, have you had a chance to look at @jihoonson's comments?

@gianm Sorry, I have been busy working on other issues. May I apply @jihoonson's comments by this weekend?


Newly created wallet account display bug

On the wallet page, when a new account is created under a particular wallet, or when account mixer is setup, the newly created accounts do not display on the UI until the application is restarted.
The expected behavior is to have the accounts display immediately they are created.

From my tests, it seems reloading the page by navigating to another page and navigating back to the wallet page displays the created account. I don't think the app needs to be restarted to reproduce the bug. Also, the issue also occurs for created wallets.


Use top-sort and a DAG to express deps and parallelism

@mpolden what do you think?

Well, this isn't quite right, as the deploy used in the allMatch may deploy things it shouldn't, yet. Convergence and deployment would need to be split. That wouldn't be a bad thing, anyway, though.

SystemApplications .all() should just return the list sorted, then we also wont have to check if application has converged multiple times (once for itself, and once for any application that "depends" on it).

Depends on whether you view the applications as batched (a list of lists is fine) or as a more general dependency graph (a DAG is required).
If you want to avoid redundant HTTP traffic, a proper top-sort would do that :)
I think I should write some util-code :p

LGTM. Will this merge into the other PR? Exciting. 🙂


fix typo in website's linting section

Summary

This fixes a typo in the Linting section from the website

Test Plan

Old sentence:
Reviewing: We offer an interactive CLI command to make this process even easier. It allows you to go through each diagnostic and perform actions on them such inserting a suppression comment or applying a specific fix.
New sentence:
Reviewing: We offer an interactive CLI command to make this process even easier. It allows you to go through each diagnostic and perform actions on them such as inserting a suppression comment or applying a specific fix.

Thanks! ✨


Ruby: Smoke tests should use standard google cloud env variables for cloud APIs

What
Currently the Ruby rake smoke test task attempts to use the environment variable SMOKE_TEST_PROJECT to determine the project to use when running smoke tests. For non-cloud APIs, that's a fine default, but if we know it's a cloud API, we should use GCLOUD_TEST_PROJECT || {API}_TEST_PROJECT.
Why
Consistency with existing APIs in google-cloud-ruby.

{API}_TEST_PROJECT is now accepted. Reclassify as enhancement to support GCLOUD_TEST_PROJECT.

No longer relevant given the customizations available in https://github.com/googleapis/gapic-generator-ruby.


Add "History Tasks" tag to the website

It is quite useful to add "history" tag to index.html.
Currently: Upstream Failure, Failed Tasks, Running Tasks,..., Done Tasks.
A LOT and A LOT records are displayed in "Done Tasks".
"History Tasks" is used for display the done tasks finished a week ago.
I know that it is configurable to set how long does a done task be displayed in the website.
But sometimes it is quite useful to check the history tasks.

I mean, if all the tasks in the dependency graph is done. all its tasks will be put to "History Task".

I would wait with implementing this until #1086 is merged :)

closing this issue.

[x] It has been inactive for +4 months.
[ ] It's not about luigi core, so not as many users are affected about this.
[ ] The change seems quite big, it's unlikely to be sporadically picked up.
[x] The owner haven't responded or disappeared.
[ ] I don't understand what this issue is about.
[ ] There exists a reasonable workaround for this.
[ ] We need to check if this hasn't been fixed by now (for old issues).
[ ] This is kind of by design and not a bug.
[ ] Resolving this would probably add a lot of complexity.

Every open issue adds some clutter, and we try to make the issues fewer and make it easier for new collaborators to find. Currently we try to close any issue that meets the first checkbox + one other.
Feel free to reopen this issue at any point if you have the intent to continue to work this. :)


Integrating the usage of the new reconciler.Event object.

Integrating the usage of the new reconciler.Event object.

/assign @mattmoor


Allow defining the destination field in configuration

I am trying to use this package to provide GitHub release pre-commit hook for selene just like StyLua.
The problem: selene release packages the binary selene and that conflicts with the top level folder selene in the repo. So, the error is:
IsADirectoryError: [Errno 21] Is a directory: '<local-path>/selene/selene'

This does not happen when using the CLI command because it allows specifying destination.
Reproduction steps

Clone amitds1997/selene
Run pip wheel . directly or in a virtualenv

Possible resolution

Allow passing destination in pyproject configuration (source).
Pass destination to download_asset call.

Sorry, I totally lost track of this and noticed it when looking at selene myself! Rather than making the download destination configurable, I'm instead using the build directory. That should achieve the same goal of avoiding conflicting file names.


Custom Resource Naming

Description

Custom Resource Naming added for Nic Name and Disk Name ( 1 os disk and 2 data disks)
Added respective columns in the Input.csv

Az version: 10.0.1

#sign-off


PSTL work (#85)

OPS Build status updates of commit ac99bd5:
:clock10: Preparing: average preparing time is 46 sec(s)

OPS Build status updates of commit ac99bd5:
:clock10: Incremental building: average incremental building time is 25 sec(s)

OPS Build status updates of commit ac99bd5:
:warning: Validation status: warnings

File
Status
Preview URL
Details

dynamics-gp/installation/ProfServicesToolsLibrary.md
:warning:Warning
View
Details

dynamics-gp/installation/ProfServicesToolsLibrary.md

Line 23: [Warning] Invalid file link:(~/installation/media/b2ab6ec2dd6025f7327e9004dd0eb287.png).
Line 36: [Warning] Invalid file link:(~/installation/media/b2ab6ec2dd6025f7327e9004dd0eb287.png).
Line 46: [Warning] Invalid file link:(~/installation/media/b2ab6ec2dd6025f7327e9004dd0eb287.png).
Line 138: [Warning] Invalid file link:(~/installation/media/e98c1352cd449d7aa876197e6c740aea.jpg).
Line 257: [Warning] Invalid file link:(~/installation/media/bbad3af62fb8663718fecbb98e2d0590.jpg).
Line 274: [Warning] Invalid file link:(~/installation/media/cac0db5c96fd8c6606fcd355bed3d6ca.jpg).
Line 298: [Warning] Invalid file link:(~/installation/media/d8e78bce04f58707d273878c6c62e0b5.jpg).
Line 387: [Warning] Invalid file link:(~/installation/media/a88f4caf017aa370984bf14c95b51684.jpg).
Line 406: [Warning] Invalid file link:(~/installation/media/a16ea972059cd90148e294a3201e64ec.jpg).
Line 476: [Warning] Invalid file link:(~/installation/media/bc17fd7f416e464646166ee5e0818aab.jpg).
Line 492: [Warning] Invalid file link:(~/installation/media/1f929a3c36ad3144684ead12e67491c2.jpg).
Line 515: [Warning] Invalid file link:(~/installation/media/c54c9c7d6757d91e394323e5e096590a.jpg).
Line 595: [Warning] Invalid file link:(~/installation/media/4876f57348d9d6bdc8258615e008aa21.jpg).
Line 748: [Warning] Invalid file link:(~/installation/media/51043b306addcd813fc1de1071a5ce51.jpg).
Line 770: [Warning] Invalid file link:(~/installation/media/57f8b2ae7d26b178176adfc7e8cf1d70.jpg).
Line 872: [Warning] Invalid file link:(~/installation/media/7dfc3dfe73a52902fe9a88f3dc4d8d05.jpg).
Line 927: [Warning] Invalid file link:(~/installation/media/6e87b8ff4a476026db4102542602b0d7.jpg).
Line 956: [Warning] Invalid file link:(~/installation/media/b46f5819dbd446008227ace25469d45a.jpg).
Line 987: [Warning] Invalid file link:(~/installation/media/dab50933fff5188b269046bb2537650a.jpg).
Line 999: [Warning] Invalid file link:(~/installation/media/e9ee2a1d4204acac692f5431d54349d6.jpg).
Line 1023: [Warning] Invalid file link:(~/installation/media/b1d2cb4dc84cd4830ad1b4a082785974.jpg).
Line 1047: [Warning] Invalid file link:(~/installation/media/8ac1cd7a0995b1655083fd883416a512.jpg).
Line 1070: [Warning] Invalid file link:(~/installation/media/6346596ff60bc29163e079652ac6dc27.jpg).
Line 1243: [Warning] Invalid file link:(~/installation/media/57dfd93b57a510254fd8750a7761a96c.jpg).
Line 1306: [Warning] Invalid file link:(~/installation/media/b64a60fc657a7ff60a52e834b610c85c.jpg).
Line 1373: [Warning] Invalid file link:(~/installation/media/0cd4ee5bc05eca0373eb73ed79a5f7e4.jpg).
Line 1424: [Warning] Invalid file link:(~/installation/media/c1191b26fd8c4b16fbd42dc3cfd908fd.jpg).
Line 1455: [Warning] Invalid file link:(~/installation/media/5a4c5a9e7c53c8d89a0f5fd2cdb19771.jpg).
Line 1505: [Warning] Invalid file link:(~/installation/media/c14af4a366e6717fcfb00e3387148407.jpg).
Line 1583: [Warning] Invalid file link:(~/installation/media/e98c1352cd449d7aa876197e6c740aea.jpg).
Line 1615: [Warning] Invalid file link:(~/installation/media/f6cd48c209fdd7cacf54e6965ea45cab.jpg).
Line 1645: [Warning] Invalid file link:(~/installation/media/14d96c71a001e5f12450c7f34eca1f74.jpg).
Line 1673: [Warning] Invalid file link:(~/installation/media/0e6852a93880e5b59c05b21cc5ee6cac.jpg).
Line 1731: [Warning] Invalid file link:(~/installation/media/522477c75245b10318d8f5a971306177.jpg).
Line 1852: [Warning] Invalid file link:(~/installation/media/577c501cb87929fc73ecf070d08df050.jpg).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[KYLIN-4972] Don't allow segment merge when use dict.global.SegmentAp…

…pendTrieDictBuilder to build bitmap measure.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
[ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
[ ] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If this change need a document change, I will prepare another pr against the document branch
[ ] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

Codecov Report

Merging #1634 (b6e5552) into master (3e12b6d) will decrease coverage by 0.18%.
The diff coverage is 2.22%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 715aa6e...b6e5552. Read the comment docs.

Pull Request Test Coverage Report for Build 7071

0 of 21 (0.0%)  changed or added relevant lines in 2 files are covered.
16 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.01%) to 28.082%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core-cube/src/main/java/org/apache/kylin/cube/model/CubeDesc.java
0
7
0.0%

server-base/src/main/java/org/apache/kylin/rest/service/CubeService.java
0
14
0.0%

Files with Coverage Reduction
New Missed Lines
%

core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java
1
81.08%

server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java
1
47.62%

core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/MetricsSystem.java
5
66.67%

core-cube/src/main/java/org/apache/kylin/cube/model/CubeDesc.java
9
62.13%

Totals

Change from base Build 7067:
-0.01%

Covered Lines:
26709

Relevant Lines:
95111

💛  - Coveralls

In which case will "cube segment merge will lead to incorrect bitmap merge", could you please provided a example?

Not a issue


Real Time Updates Using Subscriptions not working in Prisma 1.8

When implementing real time updates using subscriptions, the following error is thrown when using subscribeToMore(...) on a prop that has been wrapped with the graphql container much like it is laid out in this resource: https://www.howtographql.com/react-apollo/8-subscriptions/
The subscription request throws the following error:
Unhandled GraphQL subscription error TypeError: this.subscriptionClient.request is not a function
Upon inspecting the flow of the request, I am able to verify that the request is sent through the hybrid link used in the apollo client and what is parsed by the split function is the following :
{"kind":"Document","definitions":[{"kind":"OperationDefinition","operation":"subscription","variableDefinitions":[],"directives":[],"selectionSet":{"kind":"SelectionSet","selections":[{"kind":"Field","alias":null,"name":{"kind":"Name","value":"Agent"},"arguments":[],"directives":[],"selectionSet":{"kind":"SelectionSet","selections":[{"kind":"Field","alias":null,"name":{"kind":"Name","value":"mutation"},"arguments":[],"directives":[],"selectionSet":null},{"kind":"Field","alias":null,"name":{"kind":"Name","value":"node"},"arguments":[],"directives":[],"selectionSet":{"kind":"SelectionSet","selections":[{"kind":"Field","alias":null,"name":{"kind":"Name","value":"id"},"arguments":[],"directives":[],"selectionSet":null},{"kind":"Field","alias":null,"name":{"kind":"Name","value":"name"},"arguments":[],"directives":[],"selectionSet":null},{"kind":"Field","alias":null,"name":{"kind":"Name","value":"status"},"arguments":[],"directives":[],"selectionSet":null},{"kind":"Field","name":{"kind":"Name","value":"__typename"}}]}},{"kind":"Field","name":{"kind":"Name","value":"__typename"}}]}}]}}],"loc":{"start":0,"end":185,"source":{"body":"\n \n subscription{\n Agent{\n mutation\n node {\n id\n name\n status\n }\n }\n }\n\n ","name":"GraphQL"}}}
Also the Web Socket created returns the following when console logged:
{"subscriptionClient":{"connectionParams":{"authToken":"AUTH_TOKEN"},"url":"ws://localhost:4466","subscriptions":{},"maxId":0,"subscriptionTimeout":5000,"waitingSubscriptions":{},"unsentMessagesQueue":[],"reconnect":true,"reconnectSubscriptions":{},"reconnecting":false,"reconnectionAttempts":null,"backoff":{"ms":100,"max":10000,"factor":2,"jitter":0.5,"attempts":0},"eventEmitter":{"_events":{},"_eventsCount":0},"client":{}}}
Can someone help troubleshoot?

Thanks for opening this report, @dsoraluz-carecloud!
From your description it sounds like this might be a bug in Apollo Client.
Can you share a small code base that show cases this issue, so we can start looking closer into this problem? 🙂

Yes, here is a snippet that should help with the debugging...
Note: The client application is built in React.
Apollo Client set up:
import { ApolloLink, ApolloClient, InMemoryCache, split } from 'apollo-client-preset';
import { WebSocketLink } from 'apollo-link-ws'
import { getMainDefinition } from 'apollo-utilities'
import { createHttpLink } from 'apollo-link-http';
import { setContext } from 'apollo-link-context';
import fetch from 'isomorphic-fetch';

const httpLink = createHttpLink({
  uri: 'http://localhost:4000',
  fetch,
});

const authLink = setContext((_, { headers }) => {
  const token = localStorage.getItem('token');
  return {
    headers: {
      ...headers,
      authorization: token ? `Bearer ${token}` : null,
    },
  };
});

const httpLinkWithAuthToken = authLink.concat(httpLink);

const wsLink = new WebSocketLink({
  uri: `ws://localhost:4466`,
  options: {
    reconnect: true,
    connectionParams: {
      authToken: localStorage.getItem('token'),
    }
  }
})

const link = split(
  ({ query }) => {
    const { kind, operation } = getMainDefinition(query)
    return kind === 'OperationDefinition' && operation === 'subscription'
  },
  wsLink,
  httpLinkWithAuthToken,
)

const client = new ApolloClient({
  link,
  cache: new InMemoryCache(),
});

export default client;

Then Apollo Client is then imported to the component in the root index file of the application:
// Absolute Imports
import React from 'react';
import { render } from 'react-dom';
import { Provider } from 'react-redux';
import { ApolloProvider } from 'react-apollo';
// Relative Imports
import Store from './store';
import ApolloClient from './graphql/ApolloClient';
import MainRouter from './MainRouterComponent';

render(
.
.
.
      <ApolloProvider client={ApolloClient}>
        <Provider store={Store}>
          <MainRouter />
        </Provider>
      </ApolloProvider>
.
.
.
  document.getElementById('root'),
);

This makes the Apollo Client available to application from the root level.
The subscription is then being invoked in a component like so:
class LoginContainer extends Component {
.
.
.
loginUser = async e => {
    try {
     // Handle login, authenticate user, and save token and load initial data
      this.loadInitialData();
    } catch (error) {
     // Handle error if any
    }
  };
};
.
.
.
loadInitialData = async _ => {
    try {
      const {
        fetchInitialData,
      } = this.props;
      // Fetch initial data and parse response.
     // Attempt subscription request
     this.subscribeToAgents(fetchInitialData);
    } catch (error) {
      // Handle error if any
    }
  };

subscribeToAgents = fetchInitialData => {
    fetchInitialData.subscribeToMore({
      document: gql`
    subscription{
        Agent{
            mutation
            node {
                id
                name
                status
            }
        }
    }
`,
      updateQuery: (previous, { subscriptionData }) => {
        // Do something with response data
      },
    });
  };
.
.
.
const enhancer = compose(
  withRouter,
  withApollo,
  connect(mapStateToProps, mapDispatchToProps),
  graphql(FetchInitialData, {
    name: 'fetchInitialData',
    options: ({ contentStore: { start, end } }) => ({ variables: { start, end } }),
  }),
);

export default enhancer(LoginContainer);

FetchInitialData is a query that looks like the following:
const FetchInitialData = gql`
    query fetchInitialData($start: DateTime!, $end: DateTime!) {
        fetchInitialData(start: $start, end: $end)
    }
`;

Somethings I have been able to inspect:
The request is sent through the hybrid link used in the apollo client and what is parsed by the split function is the following :
{"kind":"Document","definitions":[{"kind":"OperationDefinition","operation":"subscription","variableDefinitions":[],"directives":[],"selectionSet":{"kind":"SelectionSet","selections":[{"kind":"Field","alias":null,"name":{"kind":"Name","value":"Agent"},"arguments":[],"directives":[],"selectionSet":{"kind":"SelectionSet","selections":[{"kind":"Field","alias":null,"name":{"kind":"Name","value":"mutation"},"arguments":[],"directives":[],"selectionSet":null},{"kind":"Field","alias":null,"name":{"kind":"Name","value":"node"},"arguments":[],"directives":[],"selectionSet":{"kind":"SelectionSet","selections":[{"kind":"Field","alias":null,"name":{"kind":"Name","value":"id"},"arguments":[],"directives":[],"selectionSet":null},{"kind":"Field","alias":null,"name":{"kind":"Name","value":"name"},"arguments":[],"directives":[],"selectionSet":null},{"kind":"Field","alias":null,"name":{"kind":"Name","value":"status"},"arguments":[],"directives":[],"selectionSet":null},{"kind":"Field","name":{"kind":"Name","value":"__typename"}}]}},{"kind":"Field","name":{"kind":"Name","value":"__typename"}}]}}]}}],"loc":{"start":0,"end":185,"source":{"body":"\n \n subscription{\n Agent{\n mutation\n node {\n id\n name\n status\n }\n }\n }\n\n ","name":"GraphQL"}}}

Also the Web Socket created returns the following when console logged:
{"subscriptionClient":{"connectionParams":{"authToken":"AUTH_TOKEN"},"url":"ws://localhost:4466","subscriptions":{},"maxId":0,"subscriptionTimeout":5000,"waitingSubscriptions":{},"unsentMessagesQueue":[],"reconnect":true,"reconnectSubscriptions":{},"reconnecting":false,"reconnectionAttempts":null,"backoff":{"ms":100,"max":10000,"factor":2,"jitter":0.5,"attempts":0},"eventEmitter":{"_events":{},"_eventsCount":0},"client":{}}}

My apologies if the above is any eyesore but I feel it includes all of the  info that you need to understand the case. I hope this sends you in the right direction.

Hey @dsoraluz-carecloud, can you prepare a small project in form of a GitHub repository including an instruction of steps to follow to end up with the error message?

@marktani Yes, I will prepare that now.


Add FAQ entry about login

Document solution to #1448

@jarhill0 is commit https://github.com/praw-dev/praw/pull/1450/commits/63215ac53673c810154899bd61ff4bebe3047584 better?

Ah, no, I don't want the whole traceback. Just the exception text:
"Redirect: Redirect to /r/subreddit/login/ (You may be trying to perform a non-read-only action via a read-only instance.)"

@jarhill0 sorry for the late ping but do you think it can be merged now?


Fixes for the upgraded travis containers

Travis has upgraded their build container, so we will soon get them in our builds. This PR adds support for those new containers (newer chrome version, now 60 next will be 62), this way we support the current container and the updated one. Also locked selenium-standalone on the 3.4 version because I had issues with the newer ones.
See: https://blog.travis-ci.com/2017-12-12-new-trusty-images-q4-launch

Nice! :-D


feat: merged kafka i18n messages into a single file

Closes #757

@wtrocki this is a new PR based on #993 .


401 error on mal auto tracking

Steps to reproduce
track/auto track, wait and it may happen
Expected behavior
tracking works
Actual behavior
tracking stopped working, a 401 error message appeared at the bottom
Crash logs
No response
Neko version
<IP_ADDRESS>
Android version
I beleive android version 9 api 28
Device
kindle fire hd 10 2021
Other details
I was able to fix this by going to tracking, logging out of mal, and logging back in.
so potentially solutions to the problem are as follows

in a potential 401/other temporary errors, the program could track/remember what was not tracked (in cases where the manga is already being tracked by an external service) and queue up 'update these chapter' features

when it recognizes a 401 error has happened, a prompt to relog in front and center would be nice, possibly buttons to take me to the page and re log in. seeing as logging out and logging in fixed this, it would be nice to be told this in a blatant way rather than a small box at the bottom that goes away not telling me its an access problem.

a potential once over 'check my manga and my tracking' pass, like the check for new manga one, that looks at all the manga you have, checks if it can be auto tracked and applies it, and checks the current read chapter and applies it to the best of its ability to tracked places.

I don't know why this happened, or if this is normal, searching 401 doesn't seem to pick anything up so it's a potentially unique to me issue.
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to the newest version Latest.
[X] I have filled out all of the requested information in this form.

this 100% normal, the new screen just now actually shows the error up and center.  It wasn't noticeable before unless you happened to open a tracker and sheet and realized mal was not matching correctly

Yeah. MAL throws 401 at me all the time. Re-login helps.

2.11.6 should fix this issue


Problem with openhabian distibution of your library

I have installed openhenhab 2.1 on Raspberry with HomeKit addon. I have read your solution to the problem with a thermostat here https://github.com/beowulfe/HAP-Java/commit/9ba46a5b0363a1f954b039e678b1b911cac74650, but I do not understand how to update the file on my Raspberry . Help me please.

Hi consult with developer of openhabian release and he told me that the distribution is not using the latest version of your library. https://github.com/openhab/openhabian/issues/175. His recommendation is to update the version, but I do not really understand where to do it. As I understand it, nap-java is installed with HoteKit addon for openhab. I have the version 2.1.0 installed. Tell me what to do?

Я понял свои дальнейшие шаги. Очень признателен за вашу помощь.

I think you misunderstood something.
@beowulfe when were you planning to release a nev version of the HAP-Java?

Yeah, I suppose I should at least update with the newest version of this dependency. I was hoping to just package it up with the new accessory types, but the blocker there is... taking longer than expected :)
I'll try to push an update this weekend.

Hi guys, When do you plan to release a new version?

@beowulfe and @ThomDietrich
Sorry to bump this thread. I'm having similar no response using using a thermostat group.
Has there been an update to this issue?


Wallet crashes when clicking in the notification

Wallet crashes when clicking in the notification with this message

Pass 1
wallet.zip

checked

checked


Documentation for website

Please have a look at the added file of documentation for your website.

Great work, Thanks for the Documentation, happy Contributing :)


Frame Overlap Issues in Navigator 1.0 with Firefox

I seem to have found a graphics issue on a Windows 7 machine with Firefox 38.0.5, where frames overlap in ways that obscure or make it difficult to navigate options. I'm unclear if these are 'as intended' and thus my issue is really a feature request, but it doesn't seem like optimal graphics implementation.
First, the right-side prevalent taxon list is obscured by a blank box that seems to exist for the 'hover text' you get when you place your cursor over a collection, and can even continue past this box to sit partly behind the time-scale at the bottom. Although you can partly see the obscured prevalent taxa in this lower portion of the prevalent taxa menu, you can't access them, or scroll down the prevalent taxon menu. Here's an example, where you can see the '%' of a prevalent taxon peaking out behind the black bar of 'geologic time':

I imagine the lower bound for the prevalent taxon list needs to be cut higher? I'm not certain why the blank hovertext box has to exist if no hovertext for a collection is being called, so if it was removed, there'd be more room for accessing the prevalent taxa.
Also, and I realize this gets into feature request territory, but it would be nice to navigate downwards through the prevalent taxa past the first few most prevalent taxa.
This is probably an old issue, but a similar frame overlap occurs on the right-side of the main Navigator menu if you select too many filters, making it difficult to remove filters at the top of the filter bar.

Perhaps shift the filters slightly rightwards if enough filters are added that the filter menu reaches the bottom of the main menu?

Agreed that point 3(?)/last one that this is not elegant, but we do not intend to account for all user decisions (like the example shown, which does not actually filter anything below "Plantae").
Note that the number of filters that "fit" is a function of screen size, which varies wildly. It is not worth adding complexity to the code that will capture only a very few situations. And then....Is it better to arbitrary restrict filter number, or allow for multiple filters, inelegantly displayed?

That's fair. All of the above issues I raise are ultimately about aesthetics, except maybe for the practical inability to access/view beyond the first five prevalent taxa on the right-hand menu.
After all, I am documenting these issues without knowing the context of whether they were intentional design decisions or not. That's a typical QA scenario. If these aesthetic issues are working 'as intended', then okay.

I think it's a mix of intentional and bugs. There are definitely differences in rendering behaviors of browser brands and OS implementations. Sometimes code tweaks can fix them, sometimes they can't.
It would be great if you forked Navigator and identified these fixes and submitted pull requests! ;)


Data Vault ITR use case

Apologies if this is a duplicate...
The ITR team have produced a schematic showing what data and calculations should be visible to which user roles.  From the We need to determine how this schematic can be constructed as a set of rules for a Data Vault containing LSEG and Urgentem Data.

@joriscram
@LeylaJavadova
@caldeirav
@HeatherAck
@toki8

Looking at the use-case:

C1 credential will be based on membership to ITR Developer group, but code for N1 will be accessible for anyone who has repository access.
Likely we use schema-level access to drive data access in the pipeline itself for transformed data, so the access is consistent across the whole pipeline for the group of developers. U1 does nor drive this (it is the execution context for U1 which should allow access to T1).
The access to the a separate distribution schema for end result can allow the data provider to ensure that specific derived results + potentially limited (attribute-level) access to source data is possible.

Sounds to me like you agree with the general contours of the idea, and it's now up to us to prove we can partition functionalities so that developers have the full access they need, users get the access their tools need, and the open source community can see transparently both the lower-level source and the higher-level source, without having access to the data (except where granted specifically as publicly viewable data).

@MichaelTiemannOSC as discussed could we have a table list of data elements showing by column what belongs to black box / grey box / crystal box. We will use this for POC the access rights management layer with Trino settings.

Please see https://github.com/os-climate/ITR/blob/develop-project-vault/examples/vault_demo_n0.ipynb

If we want to support a unit-aware ITR tool that uses the Data Vault, we must resolve https://github.com/os-climate/os_c_data_commons/issues/51

@MichaelTiemannOSC Looking at the demo notebook at https://github.com/os-climate/ITR/blob/develop-project-vault/examples/vault_demo_n0.ipynb I have a couple of questions:

Can you confirm what is defined as fundamental company data i.e. is it the entire content of company_data.fundamental_data table except company and company_id?

In step 5, you are trying to pass a list of company IDs to the Data Vault to get back a sum without exposing granular data. But the vault_warehouse you are using to get probability-adjusted temperature scores has been created on engine_dev - therefore in essence the process is able to access every bit of fundamental data with DEV access. Similarly vault_company_data used to get portfolio alignment temperature score based on corp fundamental data such as emissions or other weights is actually build on engine_dev. Do we have a problem with the use-case then?

Also in Step 4, the temperature_scores table does not seem to contain fundamental data, what are we trying to show in terms of data not being accessible here?

In this use case, fundamental company data is defined as the financial factors over time.  Names and IDs of companies are treated as identifiers and not secret.  Sectorization and regionalization could go either way (I thnk).
As for Step 5: we are using USER3 and engine_user to do the work, so it won't have engine_dev permissions when we actually implement the rules that Erik has recently enabled.  engine_dev is responsible for creating quant- and user-accessible data.  engine_quant is responsible for creating user-accessible data.

So I'm splitting up the notebook, and sure enough it doesn't break apart easily because this code:
vault_warehouse = DataVaultWarehouse(engine_dev, vault_company_data, vault_production_bm, vault_EI_bm)
is not something that can be executed as TRINO_USER2.  The SQL database is persistent, which means that each user can get their own access to it.  But now I have to figure out how to pickle/unpickle this object that is created by TRINO_USER1 and used by TRINO_USER3.  Is pickling the right way to solve this problem?

The way I envisioned this would work is more by having each step / notebook generate intermediate tables and defining access rights necessary for the next level of data processing / notebook. Which means for example initial notebook producing all the necessary computation / weightage by Corporate Id for the next layer to process without access to fundamental data. Can this work?
Also another thought is we should have conventions in our doc for the pipeline notebooks - which should include at least, in the header, having the list of input data sources (schema / table names on Trino) and output data (schema / table names in Trino) with a description of access required / granted. It would make the process a lot easier for someone contributing downstream to the pipeline (and also for access configuration).

I really like the thought about the header.  What would be really cool is if the textual header could be interpreted by a tool to produce a graphical diagram that shows the data and relationships and perhaps allows one to select a persona and see what direct or derived data is accessible (or not).
As for the separation issue: I just need to separate the actions of initialization (which requires the engine_dev) from use (which can construct a useable instance from an already-initialized system).

I the latest checkin on the develop-project-vault branch has the three users now operating in their separate notebooks.  We are ready to turn on enforcement at the Trino layer to validate the data access management mechanisms.

The first use-case we want to implement will be based on the new ITR data pipeline. To be developed once the access rights capabilities are available on cluster 2, as per above issue.

Use case was demonstrated and access rights were resolved on Trino .

Use case was demonstrated and access rights were resolved on Trino .


[5.5][Sema] Suppress concurrency related diagnostics for invalid AST nodes

Explanation:

Expressions that failed type-check can't be correctly analyzed by
effects checker due to missing type and overload choice information,
so it's possible for it to produce incorrect diagnostics.

Scope: Subscript with a single argument represented by type name.

Resolves: rdar://76475495

Risk: Very low

Testing: Regression tests added to the suite

Resolves: rdar://76475495
(cherry picked from commit 0e9c33e47fa8eb80bf784a19b6787f6b4a4cf0ab)

@swift-ci please test

@swift-ci please test Windows platform


WFLY-18031 Upgrade to Hibernate 6.2.3.final release to address TCK failures (HHH-16541)

https://issues.redhat.com/browse/WFLY-18031

Thanks @scottmarlow and @jamezp


Restore support for empty lists

I'd like a test to make sure we don't create empty volume claim template lists

Oh, I agree, but we don't have any tests for generated helm charts so far, so there is no good place to put those tests. This is really blocked by https://trello.com/c/42gyM3NL/120-create-fissile-tests-for-helm-charts

Oh poop.


Parser: allow keyword as named argument inside macros

If you have code like this:
macro foo
  span class: "hello" do
  end
end

the parser complains because it thinks class will start a class and doesn't find a matching end (it also finds the do and there's a matching end for that). However the compiler could tell that it's not a class because colon comes next, and that's a named argument.
This PR fixes that.

I think that specs the following specs might be needed:

external named arguments named after keyword can appear in def.

named tuples with keyword names can be created and used with doble splats.

Maybe they already exists in the codebase and I am missing if this is a limitation in call-site only.

@bcardiff Maybe! Can you provide code snippets for these?
This PR basically makes class: or any keyword followed by : not to be considred an openning keyword (like class ... end, def ... end, so maybe the other things you are asking are already solved by this PR or unrelated to this PR.

I branched at https://github.com/bcardiff/crystal/tree/keyword-specs , single commit for now: https://github.com/bcardiff/crystal/commit/f1176057f5f68cfdd5b9f579989f3a5323f45b67
I attempted to implement these specs and refactor the lists of keywords that was already present. Yet they didn't match 100%.
I added a couple next if that are the minimal required to make the spec pass.
Probably is unreasonable to think that all keywords can be used as named argument directly: for example call #{kw}: 1 with kw = select | struct | enum | end has parsing issues as shown in the named_args_spec.cr addition. But why class is fine but not struct 🤔   for example.

Should we merge this for 1.0?

I guess we can incorporate the changes by @bcardiff and leave for the future the addition of a couple of the failing keywords.


core: Remove embedded core node option

This PR removes the embedded core node functionality from the repository as users opt to run bridge nodes with remote celestia-core connections rather than embedded at the moment.
We can reintroduce this functionality if there is a compelling use case later in the future, but for now, it is unnecessary.
Resolves first TODO in #565

@renaynay, seems like this PR introduces a new flakey test, unless the test is failing constantly locally for you

@Wondertan test works for me locally but other tests break with race locally for me (RetrieveBlockData)

@renaynay, there was core related failed test before you didn't fixed my comments

test w/ race or just unit test? Was it ctx deadline exceeded?

You can look at the history of CI. There was a strange issue with core saying the height 2 is the initial height, not 1


SIL: let SingleValueInstruction only inherit from a single SILNode.

I had a feature in mind which would have increased our instruction size. To not feel so bad about it, I tried to reduce the instruction size on another end. So I came up with this change. At the end I decided to not implement the feature, but I thought this change is a good thing, anyway.
Letting SingleValueInstruction only inherit from a single SILNode removes the ambiguity when casting from a SingleValueInstruction to SILNode, which makes the code simpler. E.g. the "isRepresentativeSILNode" logic is not needed anymore.
Also, it reduces the size of the most used instruction class - SingleValueInstruction - by one word.
Conceptually, SILInstruction is still a SILNode. But implementation-wise SILNode is not a base class of SILInstruction anymore.
Only the two sub-classes of SILInstruction - SingleValueInstruction and NonSingleValueInstruction - inherit from SILNode. SingleValueInstruction's SILNode is embedded into a ValueBase and its relative offset in the class is the same as in NonSingleValueInstruction (see SILNodeOffsetChecker).
This makes it possible to cast from a SILInstruction to a SILNode without knowing which SILInstruction sub-class it is.
Casting to SILNode cannot be done implicitly, but only with an LLVM cast or with SILInstruction::asSILNode(). But this is a rare case anyway.
Only the last commit of this PR does the actual SILNode change. All previous commits contain small cleanups, which are required for the change, but are good for their own.

@swift-ci test

@swift-ci test

Build failed
Swift Test OS X Platform
Git Sha - 5220ca24b23624cf5394664bedde0b0be94f72b8

Build failed
Swift Test OS X Platform
Git Sha - 5220ca24b23624cf5394664bedde0b0be94f72b8

@swift-ci smoke test

@swift-ci smoke test

@atrick the size of SingleValueInstruction is still 10 words (2 for the inst-list node, 1 for the parent, 3 for ValueBase and 4 for the debug location). Though, I believe we could get the debug location down to 3 words, or even less.

@atrick the size of SingleValueInstruction is still 10 words (2 for the inst-list node, 1 for the parent, 3 for ValueBase and 4 for the debug location). Though, I believe we could get the debug location down to 3 words, or even less.

@eeckstein oh well, ideally the debug location would be encoded in one word and the first operand could reside in the same cache line.

@eeckstein oh well, ideally the debug location would be encoded in one word and the first operand could reside in the same cache line.


Paginate Gallery page

Going to the Gallery page should, by default, go to the most recent winner's page. However, there should be links to go to the past HOTH winners.
A few things about each new page

each new page corresponds to a previous HOTH
if there are no images of the winners specifically for a HOTH, we will not display a photo carousel at the top

[ ] Create YAML file structure that represents gallery page data
[ ] Create page query in gatsby-node.js
[ ] Update GalleryPage component to use data passed in via pageContext

remove Gallery page from static page folder and build via createPages API


Candles

candle.png, orange_candle.png, and white_candle.png appear to be done. We still need the other colours and check that you have the lit textures for each one. @autumnblazey


Setup isolation verification to happen based on workflow

@RyanHedges  and I had the following conversation in slack around this.
Ryan Hedges
Why does the isolate_post_checkout run on both rr and integrate? It seems like if it runs with rr, we can trust that integrate doesn’t need to run the hook again (test, build etc). For example, I rr, then someone makes changes to main, I then can’t integrate, so I pull then rr again, before running integrate.  Nothing has changed in the code between rr and integrate. Is this to handle a different workflow?
I see that there are configurations that could change this behavior which might work for my use case, but I’m curious about the purpose/benefit of having both default to true.
3 replies
Drew
Yeah, you might be right that this could be optimized a bit. I think you still need it in integrate when you do a gps int -f  because you haven’t had to rr it before.
So maybe we could do something like if you have it enabled for rr and you are doing a non-forced int then don’t run it as part of int. Then in the int -f case we could run it. Note there are probably further checks we could do to optimize it in the int -f use case but not sure the complexity is worth it nor the confusion around behavior people would experience.
Drew
I think this is all true as long as int doesn’t allow you to integrate a patch if upstream has changed since it was last requested review.
New
Ryan Hedges
Totally. I think the question I’d ask is “what is the git-ps default workflow?” Depending on that, I’d want the setting to reflect it and then you can configure the settings if you want to break from that workflow.
I’d suggest it’s run the hook on rr , don’t run on int , while keeping the prevention of integrating if changes exist upstream. I suggest this because I don’t want anyone looking at my stuff unless it’s really ready to go.

We manually configured some projects with the following to get the above behavior.
[request_review]
verify_isolation = true

[integrate]
verify_isolation = false


Cookie security

The securityheaders.com scanner showed up an issue on the web UI with duplicated cookies while one header line indicates the cookie shall not be secure and not only http:
Set-Cookie PHPSESSID=c6c503116e427e287e2438f00d877ebc; path=/
Set-Cookie PHPSESSID=c6c503116e427e287e2438f00d877ebc; path=/; secure; HttpOnly

I believe the duplicated cookie shall be avoided in order to ensure correct browser behavior.

@jpawlowski two questions, which page scanned and which version tested?

I scanned the OPNsense web ui login page.
I am using the current version 18.7.7.

@AdSchellevis probably the ini flag session.use_cookies must be set to 0 to prevent it from being sent. See this post:
https://stackoverflow.com/questions/8643956/prevent-php-session-start-to-send-a-cookie
The only thing is that I cannot tell you if this breaks session handling entirely. It is very likely safe to be set inside a script but not globally.

@fabianfrz no, you can't do that, without session cookies you have to parse the session id in your requests (which you better avoid).
Odd thing is, I do seem to get the headers twice too, but mine always seem to be correct, normally this should adjust the session headers:
https://github.com/opnsense/core/blob/866ff2ba9252e4c3e830c6ff66edf0d2128b4f5e/src/etc/inc/authgui.inc#L68-L75

@AdSchellevis probably due to https://github.com/opnsense/core/blob/866ff2ba9252e4c3e830c6ff66edf0d2128b4f5e/src/etc/inc/authgui.inc#L174


⚠ Samsung has degraded performance

In 98f009f, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 3088 ms

Resolved: Samsung performance has improved in 6ef1ce6.


Project Item bullets don't align correctly

The project item bullets are not aligned correctly
Tested on chrome, edge and firefox so not browser specific
e.g. https://docs.iota.org/docs/client-libraries/0.1/getting-started/quickstart

Fixed https://github.com/iotaledger/iota-css-theme/commit/eb961560f18c9183529d20288d2b63f63efb1d5d


Simplify gen-cert.sh

No need to run all those commands; openssl can do it with a single one :)
The CN should probably be the $(hostname --fqdn) or localhost though...
I also switched from 2048 bits to 4096 bits; I don't think there's a good reason nowadays to use smaller keys.

Thanks for the input.
Since this project is a one-way push mirror to gitlab's https://gitlab.cern.ch/webservices/cern-search/cern-search-rest-api, I've co-authored your changes:  See https://github.com/inveniosoftware-contrib/citadel-search/commit/53de0ae11e9149fc09bdf4058b0d335e8a6df123
Will close this now.


Record test coverage on fsspec package [ENG-196]

In order to gauge the effectiveness of our test suite, we should not
only measure coverage on our own code, but rather on the abstract
base classes for the file system and file implementations as well.
This commit adds the necessary parameters to the pytest invocation
in CI, which then ends up in the CodeCov reports.

Merging this PR since the Codecov API token changed (due to the migration of the repo), hence it does not have any recorded history for the main branch.
We will perform any steps to improve coverage in a subsequent PR.


Document startPathOrState variable

http://router5.github.io/docs/navigation.html

Invoking the .start([startPathOrState ,] done) function will:
Navigate to the default route if the current URL does not match an existing route, or if the matched route cannot be activated
Start listening to popstate events (triggered by back and forward buttons, and a manual change in the URL bar)
Enable navigation

What does startPathOrState change in this description?

Raise here


Add swizziling using transform dialect

It connects the swizzling algorithm in the upstream LLVM with IREE using transform dialect.
See the LLVM upstream implementation: https://github.com/llvm/llvm-project/pull/79164

I don't see any IREE specific logics. Shouldn't we add the transform op upstream and use it in IREE? Do we plan to upstream them later?

Yeah good point. @harsh-nod and @erman-gurses  can we add this upstream?

Can you not just run the pass directly? https://mlir.llvm.org/docs/Dialects/Transform/#transformapply_registered_pass-transformapplyregisteredpassop

Yeah good point. @harsh-nod and @erman-gurses can we add this upstream?

@MaheshRavishankar @hanhanW @Groverkss, I will look for a way how to do that.

Two PRs are landed to LLVM upstream regarding this PR.
https://github.com/llvm/llvm-project/pull/81550
https://github.com/llvm/llvm-project/pull/81791


Because React v16 remove React.PropTypes, react-swf does't work well

When i update react v16, i see this
The deprecations introduced in 15.x have been removed from the core package.
React.createClass is now available as create-react-class, React.PropTypes as prop-types,
React.DOM as react-dom-factories, react-addons-test-utils as react-dom/test-utils,
and shallow renderer as react-test-renderer/shallow. See 15.5.0 and 15.6.0 blog posts for
instructions on migrating code and automated codemods.

So it not work as below:
var PropTypes = React.PropTypes;
ReactSWFCompat.propTypes = {
  container: PropTypes.element.isRequired
};

Plz update PropTypes that depends on 'prop-types'

Thank you, haven't been hands on with v16 yet but I will look into this.

I've published a new version 1.0.7 which should resolve the issue.

It's work. Thanks for the work on this!


New plugin stdeb

Hi,
i’ve wrote a new pybuilder plugin, with this plugin it's now possible to build debian packages of you pybuilder based project.
the stdeb plugin (use_plugin("python.stdeb”)) provides a new task called make_deb and some new properties:
deb_package_maintainer, path_final_build, path_to_source_tarball
you can overwrite the default values in your build.py
To use the plugin you need an debian based operating system (tested on debian 8 and ubuntu 15.04) with the following packages installed:

dpkg-dev
python-setuptools, python-all, debhelper

We can’t resolv this requirements with pybuilder tools, because we can’t check for installed os packages. i've used assert_can_executeto check for the most but not every packages provides executables
If you like to discuss the opportunity to check for os packages i will create an enhancement issue for that - i have some ideas.
i’ve checked the debian package of pybuilder with lintian and all issues are project related and can be solved:
- W: python-pybuilder: new-package-should-close-itp-bug  # no changelog
- E: python-pybuilder: no-copyright-file
- W: python-pybuilder: description-synopsis-starts-with-article
- W: python-pybuilder: extended-description-line-too-long
- W: python-pybuilder: extended-description-line-too-long
- W: python-pybuilder: extended-description-line-too-long
- W: python-pybuilder: binary-without-manpage usr/bin/pyb
- W: python-pybuilder: binary-without-manpage usr/bin/pyb_

if you like i can provode a verbose version of this output.
looking forward to your feedback

Thanks Marcel. I kinda forgot about merging, sorry for that.

Thanks Marcel. I kinda forgot about merging, sorry for that.

np, thanks for merging!


Pricing page is showing the columns twice

As you can see the pricing page is not showing well the content.

Tested on latest Chrome and Firefox on macOS

ahaha, so sorry, that's clearly a bug. it's already being fixed :D
thanks for reporting it!
On Mon, Oct 7, 2019 at 5:28 PM Marcin Sydor<EMAIL_ADDRESS>wrote:

As you can see the pricing page is not showing well the content.
[image: image]
https://user-images.githubusercontent.com/13141089/66324894-3c366800-e91e-11e9-81a4-862f30ae9d2c.png
Tested on latest Chrome and Firefox on macOS
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/datocms/website/issues/27?email_source=notifications&email_token=AAAMS5JSH7DHF2CBRQK55F3QNNIQFA5CNFSM4I6GE5CKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HQDGUVA,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAMS5JWBDINGY6NBZRHTWDQNNIQFANCNFSM4I6GE5CA
.


Add more payment methods.

Actually we are  working on adding more payment methods. Which method are you missing?


grpc: use service full name as authority in the async client

Signed-off-by: Kuat Yessenov<EMAIL_ADDRESS>Use service full name instead of the upstream cluster name for gRPC async calls.
gRPC services are valid host names but the upstream cluster names are not (see https://developers.google.com/protocol-buffers/docs/reference/proto3-spec).
Risk Level: Low | Medium | High
Testing: unit regression tests
Fixes #3297

@mattklein123 is there any reason not to do this? I recall some earlier discussion on cluster names and host/authority, but not the details.

@kyessenov why can't you just set the cluster name to whatever you need it to be?

Cluster names are auto-generated, and it's difficult to move them over from using | characters.

OK, how about adding a field upstream_host to common HTTP options, that will set the host/authority for side calls only? For the regular data path, there are already a lot of options to set/update the host header.

At present Clusternames can be non dns compliant. This means it is easy to get into situations where a non-dns compliant string is placed in the authority header creating bad http2 frame. This is what we saw with istio.
At the api level this not stats name (which has no dns restrictions). Service name is already directionally correct.
From a usage standpoint it would be good for the call to fail on the client side instead of sending invalid http2.

I think it will be confusing to use different semantics for sidecalls vs regular data plane here. What's the motivation for this @kyessenov ? I think it should just be an override of whatever is already configured.

The motivation is that istio configures one cluster for both control plane side calls and data plane pass through. If we define an override in that cluster, then the regular data path calls are also going to be affected, while the intention is to apply the override only when the host header is not set (e.g. side calls). We could change the field to be override_host_if_not_set but that effectively makes it applicable to side calls only.

I'm not enthusiastic about this still, it seems a hack for Istio. Can't Istio duplicate the cluster for control/data plane if it wants different behaviors?

Bringing in @rshriram who feels strongly about this topic.

override_host_if_not_set is OK actually. As long as it's consistent behavior and doesn't depend on magic user understanding of how Envoy is using the cluster.

At the api level this not stats name (which has no dns restrictions). Service name is already directionally correct.

@mandarjog service names just fits the specs of the strings, but almost always semantically incorrect. (You would never have a mixer run on a FQDN istio.mixer.v1.Mixer, right?)

I agree with the overall assessment that this change is not a good idea and that some type of option override for host is the way to go. I will let you all bikeshed the details of the option and where it should live. ;)

closing this in favor of API-driven setting. we went with hard-coded authority in the filter as a workaround.


data "aws_lambda_invocation" "invoke_codebuild_job" The aft-lambda-layer-codebuild-invocations function is endlessly looping and doesn't actually create a layer

Terraform Version & Prov:
AFT Version:
1.3.4
Terraform Version & Provider Versions
Please provide the outputs of terraform version and terraform providers from within your AFT environment
terraform version
0.15

terraform providers
3.74.2

Bug Description
The aft-lambda-layer-codebuild-invocations function is endlessly looping and doesn't actually create a layer. codebuild is triggered repeatedly. Both the codebuild job and lambda complete successfully but the terraform data block never completed. Resulting in a retry loop.
The zip is also successfully packaged and uploaded to s3.
To Reproduce
Steps to reproduce the behavior:
multiple terraform applys and destroys
Try different provider and terraform version
Tried 1.3.3 and 1.3.4 versions of aft.
Expected behavior
Lambda layer to be created from codebuild job.
Related Logs
Additional context
New CT environment

Issue caused by networking - lambda and codebuild endlessly loop - suggest improved logic to handle failures

Thank you for confirming this was a proxy configuration issue @aandsco, I'll make a backlog with the team to see how we can improve the experience here.

I'm experiencing the same issue running Terraform from Github Actions. Could you share some insight in what the root cause was?


JP - Improves extra MD files settings

This PR brings the ability to set up extra markdown files, changing the filename in the destination:
micrositeExtratMdFiles := Map(file("README.md") -> "index.md", file("CONTRIBUTING.md") -> "contributing.md")

Please, @rafaparadela have a look when you have a chance. Thanks!

LGM


[WIP] Deprecate bluemix-go and clean-up code.

Fixes: #496, #609.
Note: The changes are done, a quick round of testing across all sub-commands is in-progress.
get:

[x]  cloud-connections List the existing cloud connections in the account
[x]  events            Get Powervs events
[x]  per-availability  List regions that support PER
[x]  ports             Get PowerVS network ports

delete:

[x]  port        Delete PowerVS network port

create:

[x]   port        Create PowerVS network port

purge:

[x] images      Purge the powervs images
[x] keys        Delete PowerVS ssh key/keys
[x] networks    Purge the powervs networks
[x] vms         Purge the powervs vms
[x] volumes     Purge the powervs volumes

dhcpserver

[x]  create      Create DHCP Server
[x] delete      Delete DHCP Server
[x]  get         Get DHCP Server
[x]  list        Get PowerVS DHCP servers

image

[x] import      Import the image into PowerVS instances
[x] info        Provide info about the image
[x] qcow2ova    Convert the qcow2 image to ova format
[x] sync        Sync images between IBM COS buckets
[x] upload      Upload the image to the IBM COS

What wasn't tested:
Testing in the test environment - https://test.cloud.ibm.com/login

cc: @Karthik-K-N.

@kishen-v it will be great if you can divide this PR into two, one for deprecating and another for cleanup..

Working on splitting the PR smaller changes.
/hold

@kishen-v can you please rebase this PR?

/hold cancel

@kishen-v lets fix the remaining comments and merge the code


Convert "Popover" and "Tooltip" components to Typescript

Part of #219

What kind of change does this PR introduce?
js -> ts convertation

Does this PR introduce a breaking change?
no

Thank you, @ewgenius. 😊
I'll look at it later today.


docs: Minor README.md updates

The repository's github actions publishes the charm on the edge channel.
A postgresql-k8s charm can be deployed and related to the finos-waltz-k8s charm, having an external database is not mandatory.

The failures are unrelated to this PR.


Clickable records in SObject Trigger Setting related lists

Previously the only links to related Trigger Actions under an SObject Trigger Setting were "Edit" and "Del". There was no quick way to open a TA for read (useful when you want to clone one). By replacing dev names by labels, we make the related TA clickable.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

Hello @TrangOul  - can you please confirm that you have signed Google's CLA?
https://github.com/mitchspano/apex-trigger-actions-framework/blob/main/docs/contributing.md

Hey @mitchspano, I've just signed it.


"usb/usb_host.h: No such file or directory" for ESP32S2 USB MSC example (IDFGH-7172)

Environment

Development Kit:      [none]
Module or chip used:  [ESP32S2]
IDF version (run git describe --tags to find it):
v4.4-367-gc29343eb94
Build System:         [idf.py]
Compiler version
xtensa-esp32-elf-gcc (crosstool-NG esp-2021r2-patch3) 8.4.0
Operating System:     [Linux]
Using an IDE?: [No]
Power Supply:         [external 3.3V]

Problem Description
I am trying to work with the msc USB driver on an ESP32S2 powered custom board. I have seen that the example has made its way into the release/v4.4 branch and I wanted to try it. Unfortunately the example on the release/v4.4 does not compile, failing with the following error:
/home/maldus/Source/esp-idf-v4.4/examples/peripherals/usb/host/msc/components/msc/src/msc_host.c:18:10: fatal error: usb/usb_host.h: No such file or directory
 #include "usb/usb_host.h"
          ^~~~~~~~~~~~~~~~
compilation terminated.
[11/21] Performing build step for 'bootloader'
[1/1] cd /home/maldus/Source/esp-idf-v4.4/examples/peripherals/usb/host/msc/build/bootloader/esp-idf/esptool_py && /home/maldus/.espressif/python_env/idf5.0_py3.9_env/bin/python /home/maldus/Source/esp-idf-master/components/partition_table/check_sizes.py --offset 0x8000 bootloader 0x1000 /home/maldus/Source/esp-idf-v4.4/examples/peripherals/usb/host/msc/build/bootloader/bootloader.bin
Bootloader binary size 0x6350 bytes. 0xcb0 bytes (11%) free.
ninja: build stopped: subcommand failed.
ninja failed with exit code 1

The usb/usb_host.h header file is actually present in the clone repository. Interestingly the same example works if the branch master is used.
Expected Behavior
A successful compilation
Actual Behavior
The compilation error above
Steps to reproduce

clone and install ESP-IDF release/v4.4
try to compile the example under examples/peripherals/usb/host/msc

Code to reproduce this issue
Debug Logs
Other items if possible

Hello @Maldus512 ,
From the log you shared it is not clear whether you are compiling for correct target? Have you run idf.py set-target esp32s2 ?

Hello @Maldus512 , From the log you shared it is not clear whether you are compiling for correct target. Have you run idf.py set-target esp32s2 ?

This is quite embarassing. Indeed I had not set esp32-s2 as the target, it now works as expected. Thank you for the assistance!

It is still valuable feedback :) we have quite a few issues like this, the error message should be more indicative.


Making the use_async a bit more ergonomic

I really like this project, especially the use_async hook.
However, evaluating the state when rendering feels a bit verbose. It feels to me as if this could be improved a bit, using an enum.
If you are interested, I would try to come up with a PR, as basis for further refining it. Trying to keep the default API intact.

Right now evaluating the state looks a bit like this:
#[function_component(EvalView)]
pub fn eval_view(props: &EvalViewProps) -> Html {
    match &props.eval {
        UseAsyncState { loading: true, .. } => {
            html!("Loading...")
        }
        UseAsyncState {
            error: Some(err), ..
        } => {
            html!(format!("Failed: {err}"))
        }
        UseAsyncState {
            data: Some(result), ..
        } => {
            html!(
                <ResultView result={result.clone()}/>
            )
        }
        _ => html!(""),
    }
}

Which isn't optimal IMHO. I think this could be changed into something like:
#[function_component(EvalView)]
pub fn eval_view(props: &EvalViewProps) -> Html {
    match &props.eval {
        UseAsyncState::Loading => {
            html!("Loading...")
        }
        UseAsyncState::Err(err) => {
            html!(format!("Failed: {err}"))
        }
        UseAsyncState::Ok(result) => {
            html!(
                <ResultView result={result.clone()}/>
            )
        }
    }
}

Which feels a bit more natural to me. I am not sure in which case one would have all three values together. Maybe I don't understand the idea having having both data and error at the same time.

I went ahead, trying to create an example of what I had in mind, something like:
#[derive(PartialEq, Eq)]
pub enum UseAsyncState<T, E> {
    /// Operation has not been started yet
    Pending,
    /// Operation is running
    Loading,
    /// Operation is complete
    Ready(Result<T, E>),
}

While updating the code I think I ran into what you had in mind with "caching", when updating the example.
When the state changes to "loading" again, the old data is still available. So data can be shown, while loading new.
I personally am not a fan of this, as it shows stale data. Maybe the solution could be to create a second version of use_async, which doesn't have this have this behavior. And maybe one implementation can be built on the other.


[BEAM-2703] Fix min_timestamp used for KafkaIO watermark.

Use correct -ve infinity timestamp in KafkaIO as suggested in description of BEAM-2703.
+R: @davorbonaci.

R: @chamikaramj

Coverage increased (+0.01%) to 69.972% when pulling 8ed07054f78aa25f64e303ec5f13ffa6ae7e701c on rangadi:fix_min_timestamp into d261d6bde1a9fe128c7a5c56936c88caca7ca9eb on apache:master.

LGTM.
Thanks. Merging.


Collapse element with text

Describe the feature you'd like
Something like this - a collapse block with text + caret to open (alternatively button):
https://www.w3schools.com/bootstrap/bootstrap_collapse.asp
Describe the benefits this feature would bring to BookStack users
In case of complicated paragraph structure, some paragraphs could be marked as this special collapse element and automatically close - e.g. tip on how to do something - without cluttering the main content.
Additional context
https://www.w3schools.com/bootstrap/bootstrap_collapse.asp

Hi,
See ==> https://github.com/BookStackApp/BookStack/issues/887

Thanks @nekromoff for your request, This is already requested under #78, Please thumbs-up the original, top comment there to show support.
Since this is effectively a duplicate I will close this.


callbacks be unbound unexpectedly.

Bug
Given two riot tags listen same event and mounted like below.
<div>
  <sample-a />
  <sample-b />
</div>

// A.tag
this.riotxChange('event', () => {
  // callback for A
});

// B.tag
this.riotxChange('event', () => {
  // callback for B
});

The problem is that the callback for B is unbound unexpectedly when tag A is unmounted. This is because the two tags(A and B) share the context of _riotx_change_handlers.

👍


Subscriptions: Admin list should be searchable and filterable

Currently it is not possible for our customer support to find subscriptions based on customers or subscription ids.
With 2k+ subscriptions this is very annoying if you want to cancel one subscription.
It should be possible to filter and search in the administration for specific subscriptions.
Also it would be nice to filter for subscription tags: https://github.com/mollie/Shopware6/issues/390.

@boxblinkracer This would be very nice for our customer support with the new detail view in the administration.
Right now it is not really possible to find a subscription...
Maybe also a link from the customer directly to the subscription detail page would improve working speed in the admin?

implemented with 4.2.0


Expanded wwwImage feature to toolbar ?

hi @initialxy
according to this
https://github.com/initialxy/cordova-plugin-themeablebrowser/blob/master/RELEASENOTES.md
0.2.11 version seem can use "Expanded wwwImage feature to toolbar"
well...
If I have not misunderstood
if it mean can use the outside domain http address to define the pic
for example...
backButton: {
        image: 'http://www.littlebau.com/phonegap/images/back.png',
    },

but I tried...not work

Two things:

The property name is wwwImage. image is reserved for loading from native resource bundle.

The URL for wwwImage is expected to be a relative path under the www directory of your application (where you'd place images for your HTML5 application), not a URL that reaches out to the world wide web. This is for performance, security and reliability reasons. eg. Your image could be placed under <project dir>/www/images/toolbar.png and you'd configure it as
backButton: {
wwwImage: 'images/toolbar.png',
}

hi @initialxy
got it !!!
I will try for it
well...
just want to ask...can you give me some sample png (if you have some...) in order to help me add these to www folder ? XD

This project contains some sample images that I use during development. See here. All of these are x2 density.


Fix Stanford Core NLP - Update Docker file

The url for the stanford-corenlp-full-2018-10-05 has changed.
@See https://github.com/microsoft/rat-sql/issues/54

Fix Stanford Core NLP - Update Docker file
The url for the stanford-corenlp-full-2018-10-05 has changed.
Right now if you hit the current url you will get:
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">
<title>Redirecting...</title>

Redirecting...

You should be redirected automatically to target URL: https://downloads.cs.stanford.edu/nlp/software/stanford-corenlp-full-2018-10-05.zip.  If not click the link.


Multiple instances of the same selector

Hi,
first of all thank you for that simple plugin! I'm just having an issue where I have multiple instances of sticky element inside the same parent container.
I have enable the parentClass options, thus that container has repeat as much sticky element as for parentClass.
Any options allow only one Class for the whole sticky elements?

Could you provide a Codepen?

Sure, I compiled here on jsFiddle:
code
as you can see the parent of the sticky should only have the parent's class once as the sticky elements are the same. But here it repeats many times.

@psntr Is your intention that the Stickybits items stick to each other or stop before the next one starts?

Sorry late reply. The behaviour on the jsFiddle is right. That's what I expect it to do. But what I want to avoid is to have the ".js-stickybit-parent" to be repeated that many times. This class should appears only once. If you inspect the section element (parent of the sticky's elements) you will see that the class appears many times.

Okay, thanks for clarifying. Stickybits is expecting something like this:

 This is sticky

  Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum

...

I see that makes pretty sense. And it seems to work that way too.
Thank you @yowainwright !


Respect user settings of CRAN repos in use

The rdebugger.updateRPackage command runs the following command in the terminal:
/usr/local/bin/R --vanilla --silent -e "install.packages('https://github.com/ManuelHentschel/VSCode-R-Debugger/releases/download/v0.4.2/vscDebugger_0.4.2.tgz', repos=NULL)" -e "install.packages('jsonlite', repos='http://cran.r-project.org')" -e "install.packages('R6', repos='http://cran.r-project.org')"

This does not respect user settings of CRAN mirror.
I guess we could run an R script in which if repos option is customized then we should respect that option.
This could be useful if user is working in a network with limitations.

I'm not really familiar with the available options here, but I'll be happy to merge, if you find a safer/more efficient way to install the package(s) :)

getOption("repos")$CRAN

The following should work:
repos <- getOption("repos")
if (is.null(cran) || identical(repos, c(CRAN = "@CRAN@"))) {
  repos <- c(CRAN = "https://cloud.r-project.org/")
}

install.packages(c("jsonlite", "R6"), repos = repos)
install.packages('https://github.com/ManuelHentschel/VSCode-R-Debugger/releases/download/v0.4.2/vscDebugger_0.4.2.tgz', repos = NULL)

If the repos is not set, then the default value is "@CRAN@".


[BUG] Radar can be opened in ambulance

Describe the bug
Radar can be opened in ambulance car. Even if you don't have police job.
To Reproduce
Sit down to ambulance car and try to open radar.

That is intended behavior, the radar is usable in any emergency vehicle, if you would like to restrict it to only certain vehicles for your server you're welcome to do so yourself.


[BUG]: First Time Loading the App Users Get Connection Not Configured Error

When Opening the app on a mobile device for the first time Users receive the error message:
"connection not configured for this data source"
This error is resolved when closing and re-opening the app and does not re-occur.
Steps to reproduce the behavior:

Open the app on a mobile device for the fist time.

Error:
connection not configured for this data source
All connection and data sources are configured and working fine except for the very first load of the app. We should not get an error the first time we open it.
Only able to reproduce this one time for each user. Have seen it on tablets, android phones, and IPhones.

Hi @MDRooks ,
It is expected that the app will produce this error until you have connected to your own SharePoint lists.
You will need to remove and add your own SharePoint connections to the app. Then you need to save and publish the app for its changes to take effect. If you had done the publishing, it does take a refresh for the published version to appear.

@mr-dang-msft thanks for the response!
I've updated the  all of the SharePoint connections to all point to the SharePoint site on my tenant and refreshed them (just in case). I've also republished the app multiple times since then, but am still seeing the same error with new users.
It seems as if the first time users are logging in the app is loading up faster than the connection is completed setting up and giving an error because it never re-occurs after the first time they open the app. (Also only occurs on mobile devices).

Same problem, trying to deploy in the org now and not getting past testing with a small number of users

@MDRooks ,
Do users receive the error each time you republish a new version?

@mr-dang-msft No, this only occurs the first time our users open the app and then never re-occurs.

@mr-dang-msft We've shared the app using 'everyone in the organisation', should that make a difference?  Also, the users we were testing with are refreshing the app, clearing the cache and even signing in / out of PA all to no avail.  Our SP site is a team site set to public as per the guide and all the connectors are pointing at it.  We're doing more testing later, will update.

Can you submit a support ticket on this topic and gather a session id in the instance that the issue happens?
Session Id: aka.ms/pa/sessionid
Support ticket: aka.ms/ppac

@mr-dang-msft thanks Brian, that's been raised as support ticket<PHONE_NUMBER>04069

I have a ticket raised as well. Was able to reproduce the error while on a call with support.
Ticket: #19197244

Unfortunately Microsoft was not able to help with this issue. However, I was able to solve it myself through trial/error.
I removed the O365 Outlook and Office365UserProfile connections in the app and then re-added them. For some reason this resolved the issue and users no longer are receiving the error the first time they open the app in mobile.
I've sent the fix to Microsoft and hopefully they can provide some more insight as to why this would resolve the error and why it occurred in the first place.
Thanks so much for the quick response and looking into this for me @mr-dang-msft!


Use reimport_append api for importing embedded gltf images

Use reimport_append api for importing embedded gltf images
Allows gltf documents to import their embedded images using the new reimport_append api.
Modifies ResourceLoader::_reimport_file to use p_custom_options to override existing user-set params in a .import file, rather than ignoring them.
Pass in gen_params from GLTFDocument and use it to store the md5 of the extracted image data, so that it is not necessary to re-extract a texture unless it changes.
Uses reimport_append api by @reduz from #72455

Thanks!


cleanup some functions from menu and into helpers

Codecov Report

Merging #390 into experimental will decrease coverage by 0.1%.
The diff coverage is 38.88%.

@@               Coverage Diff                @@
##           experimental     #390      +/-   ##
================================================
- Coverage         74.88%   74.77%   -0.11%
================================================
  Files                24       24
  Lines              1469     1475       +6
================================================
+ Hits               1100     1103       +3
- Misses              369      372       +3

Impacted Files
Coverage Δ

vent/menu.py
22.6% <22.22%> (-0.51%)
:arrow_down:

vent/helpers/meta.py
63.41% <55.55%> (-0.97%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dad7917...7eb1895. Read the comment docs.


Cloud App Security has been renamed Defender for Cloud Apps.

Cloud App Security has been renamed Defender for Cloud Apps.
I'm responsible for Defender for Cloud Apps documentation. Feel free to be in contact with me if you have questions about the rebrand.
Thanks,
David
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 518eed75-714d-1b0b-a7d3-6cce474ecb46
Version Independent ID: 30a72b04-8b59-6377-ff1a-192acdda6108
Content: azure.mgmt.securityinsight.models.MicrosoftSecurityIncidentCreationAlertRuleCommonProperties class
Content Source: preview/docs-ref-autogen/azure-mgmt-securityinsight/azure.mgmt.securityinsight.models.MicrosoftSecurityIncidentCreationAlertRuleCommonProperties.yml
GitHub Login: @VSC-Service-Account

Dup of #22571


Suggestion for .NET 6 - Support Host.CreateDefaultBuilder()

I'm suggesting this for .NET 6 as it is probably a breaking change for .NET 5.0 isolated process functions.
Please use/recommend Host.CreateDefaultBuilder(args) similar to how ASP.NET Core and Console apps work.
This would provide automatic support for populating IConfiguration using the same default providers (appsettings.json, cmd line, env vars, user secrets, etc)
It also provides automatic validation of any registered services on the ServiceProvider (when env is Development).
If the defaults need to be overridden or removed, the call to ConfigureFunctionsWorkerDefaults() should be able to handle that (e.g. override set the Environment based on AZURE_FUNCTIONS_ENVIRONMENT).
This would also allow the removal of the local.settings.json file for .NET isolated process function apps.
Example of ideal Program.cs
using Microsoft.Extensions.Hosting;

namespace Contoso.Functions
{
    public class Program
    {
        public static void Main(string[] args)
        {
            CreateHostBuilder(args).Build().Run();
        }

        public static IHostBuilder CreateHostBuilder(string[] args) =>
            Host.CreateDefaultBuilder(args)
                .ConfigureFunctionsWorkerDefaults()
                .ConfigureAppConfiguration((hostBuilderContext, configurationBuilders) =>
                {
                    // Register non-default configuration providers
                })
                .ConfigureServices(services =>
                {
                    // Register services
                });
    }
}

@rgylesbedford want to make sure I'm not missing what you're trying to convey, but this would be a simple template change. The code you've shared above should work with the worker packages as-is, today. This would also not completely eliminate the dependency on local.settings.json as that applies to host level configuration as well.
Did you have a problem when you tried to use the code you've shared?


Add Pidgin translations For KYA lessons, healthtips and Quiz

WHAT DOES THIS PR DO?

[ ] Add pidgin translations to health tips, KYA Lessons and Quiz

WHAT ISSUES ARE RELATED TO THIS PR?

Jira cards

MOB-297[https://airqoteam.atlassian.net/browse/MOB-297]

HOW DO I TEST OUT THIS PR?

[ ] Device Registry: Link to Device Registry README

WHICH ENDPOINTS SHOULD BE READY FOR TESTING?:

[ ] {{baseUrl}}/api/v2/devices/kya/lessons?language=pcm
[ ] https://airqo-engineering.postman.co/workspace/internal~7a8e9fad-2d13-4d27-af27-f1f4e9a114bf/request/12513372-5bc53ea7-1039-4142-a091-1653c483b1f7?action=share&creator=22968104&ctx=documentation&active-environment=22968104-cb313b62-2638-4b79-82bd-07c0ec067a26

Summary by CodeRabbit

New Features

Introduced translations for tips, lessons, and quizzes in the "pcm" language, enhancing accessibility for "pcm" language speakers.

Thanks @BenjaminSsempala for sharing this. A quick one, what does "pcm" stand for?

@Baalmart "pcm" is the international Language code for Pidgin English.