sqlfluff: init at 0.6.0a2

Motivation for this change
SQLFluff is a dialect-flexible and configurable SQL linter. Designed with ELT applications in mind, SQLFluff also works with jinja templating and dbt. SQLFluff will auto-fix most linting errors, allowing you to focus your time on what matters.
https://www.sqlfluff.com/
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 125290 run on x86_64-linux 1

1 package built:

sqlfluff


Ensure SQL Nuget package reference is always updating to latest

This PR addresses #20353.
When a user uses Create Azure Function with SQL binding the addSqlNugetReferenceToProjectFile function happens before the creation of the cs file (via the createFunction API) call which generates the templates and subsequently updates the .csproj (AF project file) back to the latest released version on the azure functions side.
Instead, I made sure we do this at the end after the azure function project is created and therefore executed after to ensure we always use the latest SQL Bindings NuGet package.
Subsequent change was needed for Add SQL binding as well so that it can also have the same change.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

6 of 6 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 41.66%

Totals

Change from base Build<PHONE_NUMBER>:
0.002%

Covered Lines:
27869

Relevant Lines:
62320

💛  - Coveralls

Could there be a scenario where a user with an existing project with an older sql extension reference does not want to update to the latest version when adding a new Function?

This is possible. But I believe that having users on newer versions ensures that they do not run into known issues of older sql bindings NuGet references.

Follow up issue: https://github.com/microsoft/azuredatastudio/issues/20399


Official xgboost4j-spark API for Python and R

Just to double-check, is there an existed official xgboost4j-spark API that is still active and stable and can be used in Python (PySpark) and R environments? I know that there are two PRs https://github.com/dmlc/xgboost/pull/4656 and https://github.com/dmlc/xgboost/pull/5658 introduced how to make XGBoost support PySpark. I also noticed that https://github.com/dmlc/xgboost/pull/8020 initialize the integration on PySpark, which is still in draft. So in my understanding, the answer to my question is NO for both environments, and the publish time won't be in the near future (e.g. 3 months). Please correct me if I am wrong. Thanks.

PySpark integration is still work in progress. You should watch #8020 for an initial version.


adding filtering by date and config parsing

allows to delete only releases older than x days
tries to parse ~/.pypirc for credentials if no username is given

Thank you will review now.


Brandom/aoai snippet refs

@mrbullwinkle
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Healthcheck can be used on windows 2012 and 2016

Windows 2012 uses an external mapped port for the healthcheck, but windows 2016 (like linux) uses an internal port. This PR adds a flag (useExternalPort) which can be specified when compiling the healthcheck to use either the internal or external mapped port.
Building the healthcheck with the external port check will continue to be compatible with the declarative healthcheck on windows2012R2
Signed-off-by: Sunjay Bhatia<EMAIL_ADDRESS>

@mdelillo is there a reason why ldflags is used instead of buildflags ?

@jvshahid by buildflags, do you mean something like // build +windows? If that's the case, we need ldflags because we want to build two different binaries on windows.

@mdelillo you can define your own custom buildflags

@jvshahid We don't have a preference either way, would you like us to resubmit this using buildflags?

I prefer buildflags, @ematpl thoughts ?

Yeah, I think buildflags would make the behavior more apparent simply from the code structure if named appropriately. It seems a little too magical that main.go has an unexported package-level variable that's false unless set to "true" during the compilation process, and that the behavior should apply only for windows2012R2 builds.

do not forget to change the buildflags used in https://github.com/cloudfoundry/healthcheck/blob/5cbaa8b8fd1912906588075e51e1498f12b7249d/cmd/healthcheck/helpers_windows_test.go and https://github.com/cloudfoundry/healthcheck/blob/5cbaa8b8fd1912906588075e51e1498f12b7249d/cmd/healthcheck/helpers_test.go

@jvshahid We've updated the PR to use buildflags

Thanks, @aminjam ! Prioritizing for the Diego team to pull in. I also see that https://github.com/cloudfoundry/diego-release/pull/325 has been updated to use the new build tag, so looks like we're good to go there too.
Best,
Eric


Frequency

Do the checklist before filing the issue:

[x] Do you have Node.js and all the relevant dev-dependencies installed?
[ ] Is this a bug fix?
[x] Is this an enhancement?
[x] Is this a feature request?

NOTE: Provide a clear and concise description of the feature that needs to be added! Or if its a bug, then provide the necessary steps to reproduce it along with screenshots.

Give your answer below:

[Function: M.frequency()] needs to be added!
For more info:
Find the frequency of a number or string in an array & substring in a string!
Usage:
// number or string in an array
console.log(M.frequency([1, 2, 3, 1, 2, 4, 5, 1], 1));                             /* 3 */
console.log(M.frequency(['a', 'y', 'a', 'b', 'c', 'z', 'i'], 'a'));                /* 2 */
console.log(M.frequency(['hello', 'world', 'lorem', 'ipsum', 'hello'], 'world'));  /* 1 */
console.log(M.frequency(['hello', 5, 'lorem', 7, 'ipsum', 'hello'], 'world'));     /* 0 */

//substring in a string
console.log(M.frequency('banana', 'ana'));      /* 2 */
console.log(M.frequency('banana', 'an'));       /* 2 */
console.log(M.frequency('banana', 'a'));        /* 3 */

NOTE: For any other arguments include appropriate TypeErrors!

Category: Mathematical Utilities

Assign me, please.

@thisisabdus you're assigned!

Thank you!


Fix NPE for IN clause on constant STRING dictionary

Fixes #11929

Codecov Report

Merging #11930 (8bee7bd) into master (03a9ec7) will decrease coverage by 26.80%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #11930       +/-   ##
=============================================
- Coverage     61.42%   34.63%   -26.80%
+ Complexity     1141      939      -202
=============================================
  Files          2378     2302       -76
  Lines        128845   125117     -3728
  Branches      19924    19369      -555
=============================================
- Hits          79144    43335    -35809
- Misses        43983    78738    +34755
+ Partials       5718     3044     -2674

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <0.00%> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <0.00%> (ø)

java-11
?

java-21
34.63% <0.00%> (-26.66%)
:arrow_down:

skip-bytebuffers-false
34.63% <0.00%> (-26.78%)
:arrow_down:

skip-bytebuffers-true
?

temurin
34.63% <0.00%> (-26.80%)
:arrow_down:

unittests
46.43% <0.00%> (-14.99%)
:arrow_down:

unittests1
46.43% <0.00%> (-0.22%)
:arrow_down:

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...t/index/readers/ConstantValueStringDictionary.java
0.00% <0.00%> (-26.09%)
:arrow_down:

... and 851 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


sdk unhandled exception on request timeout

The following unhandled exception is raised when a request timeout occurs (and all retires are done):
UnboundLocalError: local variable 'response' referenced before assignment
This happens on this line on rest_session.py file

Thank you for your feedback, Ozgur! That line has been fixed in the newest release 0.80.0.


VSTest task should fail, if zero tests were run

Right now, if the VSTest task fails to discover any tests, it will still report success. It's hard to spot those problems when the build shows green.
It would be great to get an option to:
[X] Fail when no tests have been run.
Thanks,
--Neno

This is in our backlog. We currently don't have any tentative timelines to share.
Thanks for sharing the feedback.


Support for mpc-qt

Hey,
I haven't personally looked into how much extra work it'd be to add support for mpc-qt. But, it'd be nice to have. Essentially, it is a crossplatform remake of mpc-hc using qt5 and libmpv.
You can find it on GitHub here: https://github.com/cmdrkotori/mpc-qt

Context: Implementing and maintaining support for a media player can be a major commitment, as there can often be changes required to the media player to support the relevant API features, and once that support is implemented it needs to be maintained through multiple versions of the media player software. It is not unusual for breaking changes to be implemented in media players without notice, so it needs people who are using the software regularly and keeping up with the betas for the media player to keep things working.

Also, if I may, the fact that there is no indication of stability nor a release candidate makes even more awkward to provide a completely external Syncplay support for this software. Having a stable tagged release could allow us to work with it and at least attempt to support it from our side. Given the current situation, I agree that involving the developer might be the best shot for adding it in Syncplay.

I am closing this issue for now in line with the above discussion, but if anyone wants to volunteer to work on this (ideally the mpc-qt developer) then I am happy to re-open it.


Issue

I get this error on a intel chip but when running on arm there is no error:
Uncaught Exception:
Error: spawn Unknown system error -86
at ChildProcess.spawn (node:internal/child_process:413:11)
at spawn (node:child_process:783:9)
at /Applications/Carelog.app/Contents/Resources/app.asar/.webpack/main/index.js:2:231338
at e._getFfmpegPath (/Applications/Carelog.app/Contents/Resources/app.asar/.webpack/main/index.js:2:211918)
at e._spawnFfmpeg (/Applications/Carelog.app/Contents/Resources/app.asar/.webpack/main/index.js:2:231097)
at e.availableFormats.e.getAvailableFormats (/Applications/Carelog.app/Contents/Resources/app.asar/.webpack/main/index.js:2:215589)
at /Applications/Carelog.app/Contents/Resources/app.asar/.webpack/main/index.js:2:216005
at r (/Applications/Carelog.app/Contents/Resources/app.asar/.webpack/main/index.js:2:250908)
at Immediate. (/Applications/Carelog.app/Contents/Resources/app.asar/.webpack/main/index.js:2:249921)
at process.processImmediate (node:internal/timers:476:21)

The error you're encountering, spawn Unknown system error -86, is indicative of a binary incompatibility issue on your Intel-based machine when using a binary compiled for a different architecture, such as ARM. Specifically, the issue is occurring when a child process is spawned to run ffmpeg, suggesting that the ffmpeg binary being used is not compatible with your current architecture.
What happens is that the binaries I download are for x86_64 so, go into the node_modules folder, look for this library and replace it with your binaries.

Sounds good. Thank you I will give it a try.


Maven release broken

I assume this is known, but figured an issue for tracking would be useful. :)
https://github.com/bufbuild/protoc-gen-validate/actions/runs/10252222879/job/28362117161
Thanks!

We've ironed out issues with the build and the 1.1.0 release is now available on Maven Central. Sorry for the delay!


[Feature] Add FCAF3D on ScanNet, S3DIS and SUN RGB-D

Motivation
Close #1219. Add FCAF3DNeckWithHead, MinkSingleStage3DDetector and RotatedIoU3DLoss. For all 3 datasets the original authors' checkpoints show exactly the same metrics. Benchmark can be added in the next PR.
Modification
Add FCAF3DNeckWithHead, MinkSingleStage3DDetector and RotatedIoU3DLoss.
BC-breaking (Optional)
Fix DepthInstance3DBoxes.overlaps. BC-breaking part is merged in #1548. No.

The BC-breaking part of the PR is separated to #1548.
Also build problem AssertionError: MMCV==1.5.2 is used but incompatible. Please install mmcv>=1.3.8, <=1.5.0. is probably not caused by this PR.
And one more thing, the minimal version of mmcv-full should be increased to 1.5.2.

The BC-breaking part of the PR is separated to #1548.
Also build problem AssertionError: MMCV==1.5.2 is used but incompatible. Please install mmcv>=1.3.8, <=1.5.0. is probably not caused by this PR.
And one more thing, the minimal version of mmcv-full should be increased to 1.5.2.

Hi @filaPro , thanks for your contribution! We have fixed the compatibility problem in #1537 . You can merge the latest dev and resolve conflicts to pass the CI test.

Will think, how to skip MinkowskiEngine in the failed test and add test for RotatedIoU3DLoss.

Removed DepthInstance3DBoxes.overlaps due to #1556.

Almost ready to merge. Just need to fix the minor comments.


[UI] Performance test result count not updating upon test completion

Current Behavior
When a performance test completes, the test result count for that performance profile should increase, too.
Screenshots/Logs

Environment

Browser:  Safari
Host OS: Mac
Meshery Server Version: stable-v0.5.71
Meshery Client Version: stable-v0.5.71
Platform: Kubernetes

Contributor Guides and Resources

🎨 Wireframes and designs for Meshery UI in Figma
🖥 Contributing to Meshery UI
🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

Hi @manav1403 👋🏽
Did you find time to look into this one?

I am looking into it.

@manav1403 @bariqhibat do we have a subscription for performance test results?


Error loading component in HA2023.9.0

Since HomeAssistant 2023.9.0 this component is not working anymore and generates an error in the HA log: "cannot import name 'Defaults' from 'pymodbus.constants'".
As a temporary workaround I commented out lines 16-19 in this file https://github.com/ArekKubacki/Hoymiles-Plant-DTU-Pro/blob/main/custom_components/hoymiles_dtu/sensor.py, and now it seems working again. Can this lines safely being ignored or need it to be something else?
Thank you in advance,

I came here to report the same issue. I was hoping it would be fixed by the next update, however 2023.9.1 dropped a short while ago and the issue still exists afterwards.
Will try the workaround by @hencou, would like to know the same if his workaround is problematic for the long term? I'll be happy to provide any log files if needed.

I came here to report the same issue. I was hoping it would be fixed by the next update, however 2023.9.1 dropped a short while ago and the issue still exists afterwards.
Will try the workaround by @hencou, would like to know the same if his workaround is problematic for the long term? I'll be happy to provide any log files if needed.

The new version will be available on Monday at the latest.

New Release on GitHub is available now!


Add Microsoft.Bicep 0.4.412

Recent release of bicep was not supported by winget yet.
I added the manifest to include bicep release 0.4.412, see pull request #21191

Awesome


Calc and File field requires type

In kintone.d.ts, The type property is optional for most field types.
https://github.com/kintone/dts-gen/blob/353ac959a38844f23e4f8fc0f928c9d0263fbd42/kintone.d.ts#L261
However, only Calc and File are requires type.
https://github.com/kintone/dts-gen/blob/353ac959a38844f23e4f8fc0f928c9d0263fbd42/kintone.d.ts#L289
https://github.com/kintone/dts-gen/blob/353ac959a38844f23e4f8fc0f928c9d0263fbd42/kintone.d.ts#L372
Is there a reason for this?

We've merged dts-gen into js-sdk, so this issue has been transferred.

@koba04
The issue has been auto-closed, will you be able to handle it?
This one was auto-closed as well.
https://github.com/kintone/js-sdk/issues/448

@the-red I've re-opened this! You can avoid that the bot closes an issue by putting a comment into the issue.

not stale

@the-red
Thank you! I reopened.

Not stale

Not stale... 😭

@the-red
We have reopened this issue & #448 .
However, we have not decided on the plan nor the schedule for these issues yet.
Issues that have an "open" state may look to be under development. We think that this situation is undesirable.
To avoid occurring perception gaps between maintainer and contributor,  we will decide and announce the policy for states of issues in the future.
Until we decide, we will keep these issues "open" . Please note that they can be "close" even though they are under consideration depends on the policy we will decide.


Cleanup and publish SCDF start.spring.io experience

As a developer, I'd like to cleanup and publish SCDF's start.spring.io experience and host it in PWS.

This issue was moved to spring-cloud/spring-cloud-stream-app-starters#85


FOSS version

Could you add third flavor with zxing?
like this https://github.com/T8RIN/quickie-foss

Hi and thanks for reaching out!
This library is tightly coupled to ML Kit. Adding support for zxing would require fundamental changes. I am sorry if this library does not comply with your FOSS requirements. I think there are already a lot of zxing based libraries out there you could check out.

But my fork is implementing zxing, that was not so hard, i can try to add foss flavor and PR, but you can do it too

Thing i like, that using this approach both foss and non foss versions have same ui

I don't say that it is not possible, but it requires a lot of changes and adds complexity and additonal testing. I choose ML Kit over zxing because it's superior scanning capabilities.
If this library does not meet your FOSS requirements, feels free to create your own fork or use the code as a guidance to create this functionality as part of you app.

I know, I already did that🐸

I like mlkit too, but it can't be published on f-droid then, so i have separate versions

I am sorry that ML Kit does not comply with F-Droids FOSS requirements. But this is actually a known issue for all libraries that rely on ML Kit. The readme of quickie points out the usage of ML Kit in the first sentence.


Bundler misinterprets Windows path as a url

When trying to use the CLI on Windows, it misunderstands the file path as a URL, failing with a confusing error message.
I think the issue is here https://github.com/timreichen/Bundler/blob/a76c440a38c3e582ccd46d0e806573434b21631d/_util.ts#L9-L16

C:\Users\dan\Desktop>deno run -A --unstable https://raw.githubusercontent.com/timreichen/Bundler/restructure/cli.ts bundle ./test.html
file not found: c:\Users\dan\Desktop\test.html
error: Uncaught (in promise) TypeError: scheme 'c' not supported
return await fetch(input)
^
at Object.opSync (deno:core/01_core.js:170:12)
at opFetch (deno:ext/fetch/26_fetch.js:71:17)
at mainFetch (deno:ext/fetch/26_fetch.js:221:61)
at deno:ext/fetch/26_fetch.js:458:11
at new Promise ()
at fetch (deno:ext/fetch/26_fetch.js:425:20)
at HTMLPlugin.readSource (https://raw.githubusercontent.com/timreichen/Bundler/restructure/plugins/file/text_file.ts:16:22)
at HTMLPlugin.createSource (https://raw.githubusercontent.com/timreichen/Bundler/restructure/plugins/plugin.ts:139:31)
at HTMLPlugin.createAsset (https://raw.githubusercontent.com/timreichen/Bundler/restructure/plugins/html/html_plugin.ts:36:31)
at Bundler.createAsset (https://raw.githubusercontent.com/timreichen/Bundler/restructure/bundler.ts:60:36)

I can also confirm this works correctly when invoked as either of:
deno run -A https://raw.githubusercontent.com/timreichen/Bundler/restructure/cli.ts bundle "file://C:\Users\dan\Desktop\test.html"
deno run -A https://raw.githubusercontent.com/timreichen/Bundler/restructure/cli.ts bundle "\\.\C:\Users\dan\Desktop\test.html"

I added an extra check for filepaths and status checks for windows. Can you check if it works now as expected on the main branch?

No dice. Did you check in your changes? The isURL function still returns true for Windows file paths, leading to the same improper fetch call.

https://github.com/timreichen/Bundler/pull/61 might fix the problem. But there are not tests atm that run cli.ts with args and flags. cli.ts needs a cli_test.ts file with cli tests to catch these kind of bugs.


Optimise masking for streaming (code from Samsung AI Center Cambridge)

What does this PR do?
This PR does two things:

divides by 10x 50x the time taken to generate masks for streaming training. The optimization is done by turning the loop over timesteps into a loop over chunk.s
Create unit tests for all the masking functions of the transformer. We had none, which is ... no gud.

I WOULD ADVISE A REVIEWER TO RETRAIN THE MODEL for a few epochs EVEN THOUGH I ADDED TESTS

@asumagic, could you please proceed with the review? It would be great to include it in the upcoming release

I ran recipe tests (including full-inference ones) and everything works fine. Thank you @TParcollet, @Adel-Moumen, and @lucadellalib .


clients/horizonclient: document request structs

It will be good for the request structs to have a bit more detail. Eg. What fields are mandatory.

closed in #1226


Use bycolumn on remainder

PULL REQUEST
Purpose and Content
This applies the same bycolumn transformation to the remainder tendency, and also adds a few extra components to the profile. As a side-effect, it means that we now apply horizontal and vertical operations separately (which we will need for limiters in any case).
 It involves rearranging terms, so may give slight numerical differences.
Linked Issues
(Provide references to any link issues. Use closes #issuenum to automatically close an open issue)

Fixes #
Closes #

PR Checklist

[ ] This PR has a corresponding issue OR is linked to an SDI.
[ ] I have followed CliMA's codebase contribution and style guidelines OR N/A.
[ ] I have followed CliMA's documentation policy.
[ ] I have checked all issues and PRs and I certify that this PR does not duplicate an open PR.
[ ] I linted my code on my local machine prior to submission OR N/A.
[ ] Unit tests are included OR N/A.
[ ] Code used in an integration test OR N/A.
[ ] All tests ran successfully on my local machine OR N/A.
[ ] All classes, modules, and function contain docstrings OR N/A.
[ ] Documentation has been added/updated OR N/A.

@simonbyrne I'll go ahead and rebase this branch

bors r+

bors r+


make with DJavaModular=ON fails

when 'Generating preprocessor_kernelpca_modular.class' there is an error:
shogun-develop/examples/undocumented/java_modular/preprocessor_kernelpca_modular.java:19: error: cannot find symbol
KernelPCA preprocessor = new KernelPCA(kernel);
^
symbol:   class KernelPCA
location: class preprocessor_kernelpca_modular
/home/entalent/shogun-develop/examples/undocumented/java_modular/preprocessor_kernelpca_modular.java:19: error: cannot find symbol
KernelPCA preprocessor = new KernelPCA(kernel);
^
symbol:   class KernelPCA
location: class preprocessor_kernelpca_modular
2 errors
make[2]: *** [examples/undocumented/java_modular/preprocessor_kernelpca_modular.class] Error 1
make[1]: *** [examples/undocumented/java_modular/CMakeFiles/build_java_examples.dir/all] Error 2
make: *** [all] Error 2

@entalent could you share the following details:

which version of shogun you are using
which version is the JDK you are having on your system

The version info printed by Version::print_version function is v4.2.0_2016-8-15_21:39262656
I'm using Oracle JDK 8u101 on Ubuntu 14.04, the output of "java -version" isjava version "1.8.0_101"
Java(TM) SE Runtime Environment (build 1.8.0_101-b13)
Java HotSpot(TM) 64-Bit Server VM (build 25.101-b13, mixed mode)

mmm based on the version you are using the git repo...? is it the develop branch?
it's just weird because with the very same properties (jdk, ubuntu etc.) the java modular interface builds and tests successfully, see:
https://travis-ci.org/shogun-toolbox/shogun/jobs/152507031

@entalent could you maybe provide the full cmake output please?

This is likely to be an eigen3 caused problem (i.e. KernelPCA is guarded)
Can we have some more output?


[Fix #7831] Fix a false positive for Style/HashEachMethods

Fixes #7831.
This PR fix a false positive for Style/HashEachMethods when there is no receiver for keys and values.
The following is an examples.
values.each { |k, v| do_something(k, v) }
keys.each { |k, v| do_something(k, v) }

False negatives occur in cases such as object that inherit Hash, but that is perhaps a corner case.
I think it is more worthwhile to resolve the false positives with common naming of values.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Good change!


Added imageUrl and imageScale to GeoJsonDataSource for points

Added a default imageUrl and imageScale that can be overridden by feature.properties image-url and image-scale for points

Thank you so much for the pull request @rob-64! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!
The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

:x: Missing CONTRIBUTORS.md entry.

Please add yourself to the contributors file!

:x: Missing CLA.

Please send in a Contributor License Agreement (CLA) and comment back here to let us know to check this!
Maintainers, here's how to check for a submitted CLA.

:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.


support alternate base json module

Hi
This is more a request than an issue. Was wondering if gjson (and also sjson and pretty) can support another base json module like https://github.com/segmentio/encoding

Hi,
The segmenio/encoding/json library looks to be a replacement to the built-in encoding/json, which rely on the Go marshal/unmarshal patterns. Gjson and sjson take on different approaches to working with json.
I'm not seeing how gjson could benefit from supporting the other library.

I have noticed at least one place where encoding/json is used in gjson:
https://github.com/tidwall/gjson/blob/master/gjson.go#L1818
I was hoping for a performance bump by using the segmentio version.
Feel free to close this issue if you don't see any benefit of this change. Thanks.

The use of the stdlib json package is a fallback for a not-so-often code path. I don’t expect changing the dependency will effect much performance.


Expanded input event examples

This PR adds some detail to the input event examples to make them a bit more useful at a glance.

Coming back to this: I think this is actually a net loss for a number of reasons:

If we add new fields to input events they won't be automatically picked up in examples
This is largely just rearranging data that is already there / rephrasing variable names. It doesn't feel like a major increase in legibility. Ex:

Before:

After:

Breaking events up into multiple log lines makes it harder to tell what values correspond to each event
It adds more code to tests, when our goal is to make them as minimal as possible.

I feel strongly enough about this that I'm closing the issue, but feel free to continue the discussion. I'll reopen if anyone pushes back with compelling counter arguments.


continue on PermissionError

I've seen PermissionError raised here under python 3.6.1 when calling os.fork() multiple times after initialization. I do not reseed for random.randint() in the child processes so this is nicely reproducible in these circumstances.
File \"/app/foo/bar.py\", line X, in baz",
      "    with Xvfb(width=1920, height=1080):",
      "  File \"/usr/local/lib/python3.6/dist-packages/xvfbwrapper.py\", line 57, in __enter__",
      "    self.start()",
      "  File \"/usr/local/lib/python3.6/dist-packages/xvfbwrapper.py\", line 64, in start",
      "    self.new_display = self._get_next_unused_display()",
      "  File \"/usr/local/lib/python3.6/dist-packages/xvfbwrapper.py\", line 123, in _get_next_unused_display",
      "    self._lock_display_file = open(tempfile_path.format(rand), 'w')",
      "PermissionError: [Errno 13] Permission denied: '/tmp/.X1050355074-lock'",
      ""

If you want to accept this PR I can clean up the change to setup.py.
Thanks for a great module 🥇

this is failing on Travis on Python 2.7 with:
"NameError: global name 'PermissionError' is not defined"

this is failing on Travis on Python 2.7 with:
"NameError: global name 'PermissionError' is not defined"

true. PermissionError is py3 fun. I'll look at refactoring.

im also not sure why you'd get permission denied when writing to /tmp. any ideas?

One process might not have permission if another wrote that file.

sounds good.  it needs to support both py2.7 and py3.  I can merge this once you refactor to support 2.7

Hmm, this seems like it could be unsafe - what if all of /tmp raises PermissionError? Now you've got an infinite loop.
I think we'd need to better understand why os.fork() would prevent your process from writing to tempfile.gettempdir()

closing this for now... will revisit if someone runs into similar.

Hi, not too sure if this repo is still maintained, but I am getting this same error. What is the solution here?


linux build no method to compile and link src for vscode

Does this issue occur when all extensions are disabled?: Yes/No yes

VS Code Version: latest git pull
yarn and npm cannot resolve solution log file is verbose no method- OS Version: Debian Bulleye
Steps to Reproduce:

1.git clone http,,,,/microsoft/vscode.git forked repo
2 git add --all
git commit --all -m up
git pull
cp /dev/null yarn.lock
yarn &> yarn.log
npm install &> npm.log
no method to compile code scripts are not present for pre-compile test

npm.log
yarn.log

please update the build doc
npm_sh.log

@Tyriar, do you own the build steps for Linux? If so, could you please take a look at this? Thanks!

The error you hit was libsecret-1 wasn't present:
Package libsecret-1 was not found in the pkg-config search path.
Perhaps you should add the directory containing `libsecret-1.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libsecret-1' found
gyp: Call to 'pkg-config --cflags libsecret-1' returned exit status 1 while in binding.gyp. while trying to load binding.gyp

This is called out in the dependencies:
https://github.com/microsoft/vscode/wiki/How-to-Contribute#prerequisites
You shouldn't need to use sudo, if you needed to there's probably some issue with file permissions in your environment.

thank you


Added support for systemd service

Hi Virender,
I wanted to deploy this on Centos 7 which uses systemd, so I've written some code and created this pull request. I use chef/sugar gem to easily determine if systemd is used or upstart and then use the template based on that.

@rmul Thank you for the PR! Could you please look into travis failures?

I see I've probably forgotten to include the gem in the gemfile (https://github.com/sethvargo/chefspec/issues/336). Will look into that

Build passes now ;-)

@rmul LGTM, thank you for fixing the Gemfile. But chefspec is failing for me. Any idea about this error.
    Errno::ENOENT:
        No such file or directory @ rb_sysopen - /proc/1/comm
      Shared Example Group: "consul" called from ./spec/unit/recipes/default_spec.rb:96
      # /Users/vkhatri/.rvm/gems/ruby-2.2.1/gems/chef-sugar-3.2.0/lib/chef/sugar/init.rb:28:in `read'
      # /Users/vkhatri/.rvm/gems/ruby-2.2.1/gems/chef-sugar-3.2.0/lib/chef/sugar/init.rb:28:in `systemd?'
      # /Users/vkhatri/.rvm/gems/ruby-2.2.1/gems/chef-sugar-3.2.0/lib/chef/sugar/init.rb:52:in `systemd?'
      # /var/folders/4g/vkwwhwrn56n4x7p_q3h349v00000gn/T/d20160106-8727-1nh5fae/cookbooks/consul-ng/recipes/config.rb:45:in `block (2 levels) in from_file'

Strange that travis is passing, but it is failing on my local environment. I will give it a try before i merge the PR.

@rmul  Seems like it has to do with mac as there is no /proc/1/comm. I will wait for you thoughts on it.

looks like chef-sugar is not suitable for mac (can reproduce on the mac of a colleague). I'll see if I can change to not using this gem..

@rmul I am glad to hear that! I will also give it a try.

done and chefspec (on my windows machine) no longer complains

@rmul Thanks for fixing the PR :+1:
I will publish new version once i have HWRP examples documented.


Fix minted token's association with master account

Issue/Task Number: T271
Overview
Fixes "client:invalid_parameter" error when trying to create a minted token with /admin/api/minted_token.create. Fixes #177.
Depends on #179 otherwise the test with enable_client_auth: false is not possible.
Changes

Fix  /minted_token.create's account association to the master account

Implementation Details
This bug follows #151 that the client authentication (using API ID and API key) in AdminAPI can now be optional. This means conn.assigns.account assigned during ClientAuthPlug may not always be available, but /minted_token.create still relies on it.
Since we have no use case for minted token in non-master accounts, it's best to fix it to master account until we have a solid reason not to.
Usage
Requesting /minted_token.create with valid parameters should now be successful.
Impact
Deploy as usual.

I'm going to rethink this one a bit. I coupled the solutions for testing :enable_client_auth and the /minted_token.create bug which should be independent from each other.

The changes for this one remains the same actually. Just added typespecs in.


Wine updates

simple updates, built wine-unstable and wine-stable, both ran fine with some apps from portableapps.com. didn't have time to test all combinations of wine+winetricks though. also no games were tested (yet).

@GrahamcOfBorg build winePackages

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: winePackages
Partial log (click to expand)
Cannot nix-instantiate `winePackages' because:
error: while evaluating 'callPackageWith' at /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/lib/customisation.nix:113:35, called from /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/pkgs/top-level/wine-packages.nix:4:13:
while evaluating 'makeOverridable' at /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/lib/customisation.nix:72:24, called from /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/lib/customisation.nix:117:8:
while evaluating anonymous function at /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/pkgs/misc/emulators/wine/default.nix:9:1, called from /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/lib/customisation.nix:74:12:
while evaluating 'wine-build' at /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/pkgs/misc/emulators/wine/default.nix:47:25, called from /var/lib/gc-of-borg/nix-test-rs-31/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-31/pkgs/misc/emulators/wine/default.nix:66:3:
callPackage_i686 not supported on system 'aarch64-linux'

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: winetricks
Partial log (click to expand)
error: while evaluating the attribute 'pathAdd' of the derivation 'winetricks-20180513' at /var/lib/gc-of-borg/nix-test-rs-27/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-27/pkgs/stdenv/generic/make-derivation.nix:170:11:
while evaluating 'concatMapStringsSep' at /var/lib/gc-of-borg/nix-test-rs-27/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-27/lib/strings.nix:64:33, called from /var/lib/gc-of-borg/nix-test-rs-27/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-27/pkgs/misc/emulators/wine/winetricks.nix:12:13:
while evaluating anonymous function at /var/lib/gc-of-borg/nix-test-rs-27/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-27/pkgs/misc/emulators/wine/winetricks.nix:12:49, called from undefined position:
while evaluating the attribute 'full' at /var/lib/gc-of-borg/nix-test-rs-27/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-27/pkgs/top-level/wine-packages.nix:30:3:
while evaluating 'callPackageWith' at /var/lib/gc-of-borg/nix-test-rs-27/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-27/lib/customisation.nix:113:35, called from /var/lib/gc-of-borg/nix-test-rs-27/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-27/pkgs/top-level/wine-packages.nix:4:13:
while evaluating 'makeOverridable' at /var/lib/gc-of-borg/nix-test-rs-27/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-27/lib/customisation.nix:72:24, called from /var/lib/gc-of-borg/nix-test-rs-27/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-27/lib/customisation.nix:117:8:
while evaluating anonymous function at /var/lib/gc-of-borg/nix-test-rs-27/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-27/pkgs/misc/emulators/wine/default.nix:9:1, called from /var/lib/gc-of-borg/nix-test-rs-27/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-27/lib/customisation.nix:74:12:
while evaluating 'wine-build' at /var/lib/gc-of-borg/nix-test-rs-27/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-27/pkgs/misc/emulators/wine/default.nix:47:25, called from /var/lib/gc-of-borg/nix-test-rs-27/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-27/pkgs/misc/emulators/wine/default.nix:66:3:
callPackage_i686 not supported on system 'aarch64-linux'

Failure on x86_64-linux (full log)
Attempted: winetricks
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/p943f2yjqcylin5yb0lic18x950b3pbs-zenity-2.32.1
shrinking /nix/store/p943f2yjqcylin5yb0lic18x950b3pbs-zenity-2.32.1/bin/zenity
gzipping man pages under /nix/store/p943f2yjqcylin5yb0lic18x950b3pbs-zenity-2.32.1/share/man/
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/p943f2yjqcylin5yb0lic18x950b3pbs-zenity-2.32.1/bin
patching script interpreter paths in /nix/store/p943f2yjqcylin5yb0lic18x950b3pbs-zenity-2.32.1
checking for references to /build in /nix/store/p943f2yjqcylin5yb0lic18x950b3pbs-zenity-2.32.1...
cannot build derivation '/nix/store/zpxm1wc5w1yilqvvmyk7bqc367c55rv0-winetricks-20180513.drv': 1 dependencies couldn't be built
error: build of '/nix/store/zpxm1wc5w1yilqvvmyk7bqc367c55rv0-winetricks-20180513.drv' failed

Failure on x86_64-linux (full log)
Attempted: winePackages
Partial log (click to expand)
  -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0
building of '/nix/store/pmk1f2bpl7jj539rp2lyzc55i7s9yiir-wine-3.0.1.drv' timed out after 4000 seconds
gcc -c -o testlist.o testlist.c -I. -I../../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe \
  -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers \
  -Wshift-overflow=2 -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wvla \
  -Wwrite-strings -Wpointer-arith -Wlogical-op -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer \
  -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0
building of '/nix/store/hgkg0ifb382llphnl8c1550h3ldgib89-wine-3.9-staging.drv' timed out after 4000 seconds
building of '/nix/store/66xd3v8sp0m31fynjvfnbbyvbqrdsbid-wine-3.9.drv' timed out after 4000 seconds
error: build of '/nix/store/66xd3v8sp0m31fynjvfnbbyvbqrdsbid-wine-3.9.drv', '/nix/store/9q2r2rp0gib456s85vrlfn43v47rkk7r-wine-3.0.1.drv', '/nix/store/ha22srg4wkk4k093qmnpmh0fbhz519f6-wine-3.0.1.drv', '/nix/store/hgkg0ifb382llphnl8c1550h3ldgib89-wine-3.9-staging.drv', '/nix/store/pmk1f2bpl7jj539rp2lyzc55i7s9yiir-wine-3.0.1.drv' failed

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: winePackages
Partial log (click to expand)
Cannot nix-instantiate `winePackages' because:
error: while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:113:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/wine-packages.nix:4:13:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:72:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:117:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/misc/emulators/wine/default.nix:9:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:74:12:
while evaluating 'wine-build' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/misc/emulators/wine/default.nix:47:25, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/misc/emulators/wine/default.nix:66:3:
callPackage_i686 not supported on system 'x86_64-darwin'

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: winetricks
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


Map proxy - caching needed!

Without that caching, each time I access the map proxy element, it is recreated and that causes me real pain sinceI have some status saved in my viewModels.
Scenario:
I have DynamicArray of Models retreived from api. That dynamic array I have mapped to DynamicArray of ViewModels that have some "status" Dynamic and this status is lost when I access the ViewModel another time :(

Unfortunately, caching would introduce more problems than it would fix so this will not be implemented.
You should aim for map/filter/reduce functions to be pure functional - they should not change state of the object and should produce same result on each run.

Well I currently solved this by proxying this thru separate ArrayBond that inserts/updates/deletes "mapped" objects to "proxy" array.


[Feature] : Create a Node.js based backend for the website

A backend is very essential for a website to perform it's functionalities smoothly. So I propose to build a Express.js server , Node.js based. The html files will be converted to EJS files for dynamic responses from the Express server.
I would like to work on this under GSSoC/24

@khushi-joshi-05 check need this?

@sunny0625 I wanted to do this


[QUESTION] I implemented multiple layers for partial updates (in GL mode) using SKSurface, am I doing it correctly?

Thank your such as awesome project @mattleibow !
Question: I have scoured the internet for answers on how to effectively implement a way to only partially update the drawing by basically creating multiple layers but have only found clues here and there. I am building my own UI in WinForms by drawing it using SkiaSharp + the SKGLControl control. Everything is working really well but I can't help feel there should be an effective way of not redrawing every "UI widget" from scratch every time. So I have tried coming up with a concept of having multipe layers that I can draw into and then composite in a final scene.
From what I've found the SKSurface seems to be the ideal candidate. So what I do is I create a SKSurface for each layer, draw into the canvas of each surface and then draw all my layers (SKSurfaces) on top of each other in the SKGLControl PaintSurface event. I started by creating a raster surface (I think) and it worked right away but I am under the impression that I won't use the GPU in that case? So I tried following this sample: https://docs.microsoft.com/en-us/dotnet/api/skiasharp.skcanvas?view=skiasharp-2.80.2 to create a GL surface. This did not work when I did var context = GRContext.Create(GRBackend.OpenGL) to create my GL context (only blank screen) but once I tried passing in the GLContext from the SKGLControl everything started working!
This is how I am doing it currently, would you experts and especially @mattleibow say this is a correct way of implementing layers and still have everything GPU accelerated? Any pitfalls? Sample code below:
public partial class Form1 : Form
    {
        public Form1()
        {
            InitializeComponent();
            skglControl1.PaintSurface += SkglControl1_PaintSurface;
        }

        private SKSurface _layer1;
        private SKSurface _layer2;

        private void SkglControl1_PaintSurface(object sender, SKPaintGLSurfaceEventArgs e)
        {
            DrawTextInLayer(e.Surface, "Root layer", 0, 50);

            // Create the layer only the first time
            if (_layer1 == null && _layer2 == null)
            {
                // Note: Creating a new context using GRContext.Create(GRBackend.OpenGL) does not seem to work,
                // I have to use the same one from the skGlControl i'm currently using
                _layer1 = SKSurface.Create(e.Surface.Context, true, new SKImageInfo(256, 256));
                _layer2 = SKSurface.Create(e.Surface.Context, true, new SKImageInfo(256, 256));

                // Draw these only once
                DrawTextInLayer(_layer1, "Layer 1", 0, 100);
                DrawTextInLayer(_layer2, "Layer 2", 0, 150);
            }

            // Draw the layers onto the main canvas
            e.Surface.Canvas.DrawSurface(_layer1, 0, 0);
            e.Surface.Canvas.DrawSurface(_layer2, 0, 0);
        }

        private void DrawTextInLayer(SKSurface layer, string text, float x, float y)
        {
            var redBrush = new SKPaint
            {
                Color = SKColors.Red
            };

            layer.Canvas.DrawText(text, x, y, redBrush);
        }
    }

Many thanks for this project!

How is this going for you? I'm about to try implement something similar

Here is a different approach using SKPicture objects:
https://stackoverflow.com/questions/64737621/c-sharp-skiasharp-opentk-winform-how-to-draw-from-a-background-thread


Broken link from GCP Marketplace email

Broken link from GCP Marketplace email
Relevant URLs
https://docs.influxdata.com/influxdb/v2.6/introduction/getting-started/
From email:

To get started with your solution:

View the getting started documentation for InfluxDB:

InfluxDB Documentation.   <- bad link here

What products and version are you using?
2.6.1 (the latest in Google Cloud Platform Marketplace)
Looks like the url contains an extraneous "/introduction/"

Thanks for reporting @eriknolte. The fix for this is currently deploying.


Update to MAPL 2.34.1, ESMA_cmake 3.24.0

This PR updates GEOSldas to use MAPL 2.34.1. The impetus for this is the that we discovered a bug in how MAPL handled 4D variables in restarts when WRITE_RESTART_BY_OSERVER: YES was set. Now in GEOSgcm this is automatically set when Open MPI is the MPI stack (which is true for GNU at NCCS). I'm not sure if the LDAS uses that setting (@weiyuan-jiang might know).
I also don't know if the LDAS has any 4D variables in its restarts, but it is possible if there are 2 ungridded dims in a variable (since I assume 🤷🏼 that the LDAS is mainly 2d variables discounting ungridded dims).
Also, this will bring in MAPL 2.34.0 changes as well. Per the release notes, I don't think anything in 2.34 directly affects the LDAS, so I'll mark this as zero-diff, but @biljanaorescanin will of course test.
Also also, I'm updating ESMA_cmake to 3.24.0. Per the changelog, this is very minor.

Thanks, @mathomp4, for keeping us current.  I am running the tests now, @biljanaorescanin is away.
I don't think we have variables with 2 ungridded dims, and I don't expect any of the changes will impact the LDAS.
With any luck, we'll know for sure by the end of the day.


shfmt: 3.2.2 -> 3.2.4

https://github.com/mvdan/sh/releases/tag/v3.2.4

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 115449 at 3c986e82 run on aarch64-linux 1

1 package marked as broken and skipped:

zoxide

2 packages built:

bat-extras.prettybat
shfmt


add examples + refactor jss stringify from css2jss into cli

I don't need the jss to be stringified when i use it inside my app. I actually need the jss, so i hope this kind of refactoring is cool with you :-)

I like the changes, just a view small things and we can merge it.

https://github.com/jsstyles/jss-cli/pull/3#discussion_r39318869
https://github.com/jsstyles/jss-cli/pull/3#discussion_r39318993


Testing mentionbot #3

is it working?

y'all can ignore these mentions, sorry about that! :)

all done!


UI server section is gone

No clue how this happened.
I also tried with a fresh container and new volume mapping to an empty folder (no existing db) same result.

The cause was the update from 4.0 to 5.1, confirmed here: https://github.com/ngoduykhanh/wireguard-ui/issues/395
The workaround suggested https://github.com/ngoduykhanh/wireguard-ui/issues/405#issuecomment-1695050887 allowed me to login again, but caused the above:

no server settings
no global settings
no user settings

To fix, the suggested workaround requires an additional line, in your docker mapped volume /db/users/admin.json like this:
{
        "username": "admin",
        "password": "admin",
        "admin": true
}

By adding "admin": true, the missing pages are back.
Please inform the users of the breaking changes!!

nice, thank u!

And this problem seems to only occur during docker-compose installation


From example Screen Share not working in iOS for some devices

Hello all, we are using,
react-native: 0.66.4
react-native-agora: 3.7.1
We have implemented screen sharing with this
await RTCEngine.startScreenCapture({
captureAudio: true,
captureVideo: true,
videoParams: {
bitrate: 500,
frameRate: 15,
width: MyConstants.windowWidth,
height: MyConstants.windowHeight,
contentHint: VideoContentHint.Details,
},
});
And it's working perfect for android but for ios some devices (iPhone XR (OS 14.0.1), iPhone12) it's not working even i have tested demo sdk project in sdk example also it gives (CaptureInBackground = 6) error code in local video state change event after click on start broadcast popup button and failed to capture screen even app is in foreground state please help!

iOS replaykit Prompt error ？

No error is prompting

Here is the logas for your reference

replaykit process is not started from video , you can xcode debug replaykit, need to make sure


Make semicolons optional

Please make semicolons optional :)

@dearfrankg Unfortunately there is no way to achieve something like this. The snippets should include semicolons or not.

@xabikos thanks for the update.  I guess forking is the only answer.

@dearfrankg based on my understanding yes.

I noticed that the extension vscode-exports-autocomplete adds or removes semicolons based on eslint semicolon config setting.

@pcjmfranken vscode-exports-autocomplete is a full extension not just code snippets. You can execute regular JavaScript code. Code snippets is much simpler and you don't have this option. For example
"reactClassComponent": {
    "prefix": "rcc",
    "body": "import React, { Component } from 'react';\n\nclass ${1:componentName} extends Component {\n\trender() {\n\t\treturn (\n\t\t\t<div>\n\t\t\t\t$0\n\t\t\t</div>\n\t\t);\n\t}\n}\n\nexport default ${1:componentName};",
    "description": "Creates a React component class with ES6 module system"
  },

this snippets creates the react class component. So we can't have this control. The only option to do this is to completely remove the semicolons from here. But then there will be some other people who like them.

Wouldn't this be possible using an extension setting?


I tried to download a user, and the script crashed with an error dump that filled the terminal.

I downloaded the newest version a few minutes ago, and tried to download an instagram.
It worked, and then it printed this:
Downloading:   0%|                                                                                | 0/464 [00:00<?, ?it/s]'{u\'alt_media_url\': u\'https://scontent-ord1-1.cdninstagram.com/t50.2886-16/13477837_506697689519627_1722745634_n.mp4\',\n u\'can_delete_comments\': False,\n u\'can_view_comments\': True,\n u\'caption\': {u\'created_time\': u\'1466362113\',\n              u\'from\': {u\'full_name\': u\'Wright\',\n                        u\'id\': u\'143862950\',\n                        u\'profile_picture\': u\'https://scontent-ord1-1.cdninstagram.com/t51.2885-19/1889238_802261243224897_1527459696_a.jpg\',\n                        u\'username\': u\'hotwrightnow\'},\n              u\'id\': u\'17849420611083698\',\n              u\'text\': u"I\'m
And contiuned on for 30 more lines, the rest is here: http://pastebin.com/VKAAXCBz
What exactly happened?

Thanks. I've identified the root cause of the problem. The exception is:
[Errno 17] File exists
which occurs when the save directory is being created but it already exists. This issue manifests because there is a race condition where multiple threads are simultaneously detecting the save directory as not existing and then try to create it. The first thread that creates it is successful however the rest fail because it already exists.
This also explains the previous error from issue #3  KeyError: 'url'. When the File Exists error happens, the script never reaches the proceeding lines and never sets the url property. As a result, the exception handler fails when it tries to print the url property.
Please pull the latest update and let me know if you still experience this issue.


[Wallet] Disable app restart when geth error encountered

Description
Disable app restart when geth error encountered
Tested
I've simulated geth error and it asked once to switch to Forno.
Related issues

Fixes #https://github.com/celo-org/celo-monorepo/issues/5984

Backwards compatibility
Yes

Is this on top of switching to forno by default? So if I understood correctly, the new behaviour on geth error is instead of restarting the app, to open a modal that asks the user if they want to switch to data saver mode, right?

Is this on top of switching to forno by default? So if I understood correctly, the new behaviour on geth error is instead of restarting the app, to open a modal that asks the user if they want to switch to data saver mode, right?

What's the plan with this change?
Note that we now have forno enabled by default for new users. I still think this change is a good idea so that existing users don't get into crash loops related to geth connectivity.

What's the plan with this change?
Note that we now have forno enabled by default for new users. I still think this change is a good idea so that existing users don't get into crash loops related to geth connectivity.


fix spelling and grammer errors

Old text wasn't removed so now things are duplicated.

It is also really hard to see exactly what changes have been made to text :)

I've re-created this PR at #278 with stuff correctly changed. :) Thanks.


[1241] Prevent users from banning themselves

Resolves #1241

add restriction in UsersController#ban
remove ban button by modifying UsersHelper#make_ban_btn
add specs

:shipit:


Generate serdeable records from JSON schema

Feature description
The inverse issue, should be implemented with SourceGen module

Oracle Database 23ai has an option to generate json-schema documents from JSON Relational Duality Views. Please refer to https://docs.oracle.com/en/database/oracle/oracle-database/23/jsnvu/using-json-relational-duality-views.html#GUID-76BA5085-3F19-4A7C-BCA5-24CDE088FA69

Came here to create this issue. It would be a great feature. Maybe use can be made of jsonschema2pojo.


Investigate possible FUNMAN integration

This issue is to determine:

[ ] what does FUNMAN take as input?
[ ] what does FUNMAN create as output?
[ ] produce a set of example usages or point to them (e.g. from Sift's examples)
[ ] assess FUNMAN run time under various conditions
[ ] ideate on how FUNMAN should be integrated into the Terarium stack

@fivegrant I added some detail to this issue

For reference--this seems to be their latest demo notebook: https://github.com/ml4ai/funman/blob/hackathon/notebooks/funman_api_example.ipynb


Is there any benefit to use immutable for mithriljs?

I know there are benefits to use immutable for reactjs: easy undo-redo and high performance.
Are these benefits still applicable for mithriljs?
This may be related with how the diff of mithriljs works, I think.
Thanks in advance

If you're dealing with a lot of one-way binding, you might. Mithril doesn't
care about your data model. As long as your virtual nodes are still POJOs,
you're good.
On Tue, Jan 12, 2016, 20:35 whatifif<EMAIL_ADDRESS>wrote:

I know there are benefits to use immutable for reactjs: easy undo-redo and
high performance
Are these benefits still applicable for mithriljs?
This may be related with how the diff of mithriljs works, I think
Thanks in advance
—
Reply to this email directly or view it on GitHub
https://github.com/lhorie/mithril.js/issues/930.


Resizing Husky Model in Gazebo

Hi,
Describe the the feature you would like
Is it possible to resize the husky model in gazebo (i.e. possibly via husky.urdf.xacro)? Naively setting the scale param within the <mesh filename="package://husky_description/meshes/base_link.dae" scale="0.1 0.1 0.1" /> does not work. Thanks!

The size of the Husky model is intended to accurately reflect the physical Husky robot (which only comes in one size).
Can I ask why you want to resize the model?

Hi @civerachb-cpr,
Awesome idea. This will work well. Thanks!

 Glad to hear the Jackal will suit your needs.


Add code

This repository currently only contains a licence - maybe add some code?

Very funny—I've just published v0.1 in fact. If you'd like to follow any future progress, feel free to give this repository a star! :star2:


warning: comparing floating point with == or != is unsafe [-Wfloat-equal]

When using BOOST_CHECK_CLOSE I'm getting the following warning:
boost/test/tools/floating_point_comparison.hpp:182:13: warning: comparing floating point with == or != is unsafe [-Wfloat-equal]
    if( (f1 == static_cast<FPT>(0)) ||
         ~~ ^  ~~~~~~~~~~~~~~~~~~~

Is there a way to silence this without me deactivating the warning completely?

Hi,
Thanks for the report, I've made a fix in the branch topic/GH-241-floating-point-strict-comparison-warning.

Works! :)

Merged to master


Use the currently logged-in resource if available

When displaying the new confirmation form, if the user is already logged-in and is still in the confirmation time window, why not keeping the resource instead of resetting it to a blank one ?
I've ran the test suite before and after and I didn't break anything.
But I don't know devise enough to know how to add a good test for that.
Maybe we should decide if this is a good idea, then figure out how to properly test this.

I am closing this because I don't have any evidence of why this would be a good idea so why change? :)


Problem concatenating different image sizes

Hi,
I want to merge multiple images in different sizes and aspect ratios. I know that I have to add padding to them to be able to merge them. The problem is that if I merge them i get the following error:
ValueError: Encountered pad(force_original_aspect_ratio='decrease', out_h=1600, out_w=1600, x=0, y=0) <11c569d3bf48> with multiple outgoing edges with same upstream label None; a split filter is probably required
This is the code which I am using:
def create_slide_show(timeline):
    FPS = 30
    inputs = []
    PAD_OPTIONS = {
        "out_w": 1600, "out_h": 1600,
        "x": 0, "y": 0,
        "force_original_aspect_ratio": "decrease"
    }
    for slide in timeline:
        temp_img = ffmpeg.input(
            slide, t=1, framerate=FPS, loop=1)
        temp_img = temp_img.video.filter_("pad", **PAD_OPTIONS)
        inputs.append(temp_img)
    ffmpeg.concat(*inputs).output("test_script.mp4").run()

Is there a mistake done by me?

Before you run(), you can do compile() and run the command line to see what fails. I did that with your code and checked the error from the actual ffmpeg program against the ffmpeg documentation. The pad filter does not have force_original_aspect_ratio and out_w, out_h can be used on the right of = only. Use w, h and drop force_original_aspect_ratio.

Thank you for your fast replay :)
Yes, you are right, I misunderstood the documentation, sorry.
But I still get the same error with the following options:
 PAD_OPTIONS = {
        "w": 1600, "h": 1600,
        "x": 0, "y": 0,
    }

Did I falsely understand your explanation and documentation again?
I also tried to compile the ffmpeg command but I just get the error if I use compile like this:
print(ffmpeg.concat(*inputs).output("test_script.mp4").compile())


Added clean monitor table for smaller screens

I added a different and more clean table style for smaller mobile screens.
Because on some devices it looked pretty compressed, see Example 1.
You can see the new table style in Example 2. It will only appear on a screen width smaller than 550px.
Example 1:

Example 2:

This should be done now or are there any suggestions?

This should be done now or are there any suggestions?

Overall is great. The row spacing in Details.vue maybe too big?

Alright, i'll work on that tomorrow!

Okay, i've reduced the row spacing while not making it look too compressed.
I also centered the badge, cause also the margin-top still applied on the Details page before.

Just as an experiment, how do you feel about making the pill full width and making the title bold?

I really like the idea making the title bolt.
I think making the badge full width looks a bit "overwhelming", so i got another idea, how about this?

@Ponkhy Nice! I'm ok with that too.

@chakflying Alright, I added the commit a17c14e and also made the title bolt.
If you have a better approach on the change feel free to correct it!

Dimmed the color of border line, if it is ok, I will merge to master branch.

@louislam For the dark mode i totaly agree!
Unfortunately it looks too dark on the light mode.
Are you adjusting it for the light one or should i?

@louislam For the dark mode i totaly agree!
Unfortunately it looks too dark on the light mode.
Are you adjusting it for the light one or should i?

That is unexpected. I thought I added inside .dark....

Just recheck, it is ok in my side. Strange.

Ohh i'm sorry it's my false, i didn't read and pull properly.
Yes we're good now, looks perfect!


Authorization Header not found in OAuth2 getOAuthAccessToken

I run into problem in connection from passport-oauth2 to django-oauth-toolkit. When authorization is granted, getOAuthAccessToken prepare the request without authorization header including clientId and clientSecret as defined in section 4.1.3 of rfc6749. The value of the authorization header is "unicode: Bearer undefined" instead. Any hints or suggestion. Thanks.

The Fitbit API is an example of a service that requires Basic Auth.
https://dev.fitbit.com/docs/oauth2/#access-token-request
There's currently no way to add custom headers when calling getOAuthAccessToken?

Have a look to https://github.com/thegameofcode/passport-fitbit-oauth2/blob/master/lib/oauth2.js
I make my integration work by creating my strategy like this :
new OAuth2Strategy({
authorizationURL:  ...,
tokenURL: ..,
clientID: ,
clientSecret: ,
callbackURL: ...,
customHeaders : {  Authorization:  'Basic '+ new Buffer( + ':' +  ).toString('base64') }
}

Is anyone planning on resolving this issue? This prevents passport from working with the Dex OIDC provider. If not I could take a look at it.


Update Pi-hole to release 2021.12.1

Update Pi-hole to release 2021.12.1
https://github.com/pi-hole/docker-pi-hole/releases/tag/2021.12
https://github.com/pi-hole/docker-pi-hole/releases/tag/2021.12.1
Signed-off-by: Roddie Hasan<EMAIL_ADDRESS>

Do not merge until December 32nd. 👍
(I just can't win with this stuff - rebasing again to fix the commit version)

Of course I can't fix the branch name, but the rest is fixed.

Third time will be a charm.


Transaction events not shown

Events are not getting shown on the transaction page.
Example: https://explorer.hiro.so/txid/0x183afb503463bf3e3357d446f0c06096eb0f1c5d8b6677c7c5706f0575b41f81?chain=mainnet

I can't reproduce it:

Seems to be working again.


doc(Tactic): expand ring and ring_nf docstrings

Copy some explanations from other comments into the actual ring_nf docstring. Add details to ring docstring.

Looks good to me.
maintainer merge

bors merge


Can this application be set to a fixed position, it will return to the bottom left corner each time it is turned on?

Can this application be set to a fixed position, it will return to the bottom left corner each time it is turned on? #

Duplicate of #196 ; will be fixed soon


npm README for botbuilder-dialogs-adaptive is very out of date

Versions
What package version of the SDK are you using: 4.9.3-preview
What nodejs version are you using: n/a
What browser version are you using: n/a
What os are you using: n/a
Describe the bug
The description of botbuilder-dialogs-adaptive 4.9.3-preview on npm discusses how to create and run waterfall dialogs, when it should describe how to create and run adaptive dialogs with the dialog manager.
To Reproduce
Steps to reproduce the behavior:

Open botbuilder-dialogs-adaptive 4.9.3-preview on npm.
Error: read the description and notice that there is no information about adaptive dialogs.

Expected behavior
The package description should be accurate and describe how to use classes in the package.
Additional context
Users are excited about this new feature (When will this be available for nodejs? #1859). It's embarrassing to point them to npm right now.
[bug]

@vishwacsena , could you please take this? anything we can leverage?

Reviewed by the SDK team. Closing as Not Needed.

@mrivera-ms The https://www.npmjs.com/package/botbuilder-dialogs-adaptive page still talks about waterfall dialogs, even though the package has the adaptive dialog bits in it. Even just a minimal but relevant description of what is actually in the package would be both helpful and expected.


Readme documentation

Updated the Readme documentation of the CDTDatastore.

Created sophisticated documentation formatting.
Removed the cloudant CDTDatastore documentation and added the reference link for it.
Included Table to organise the information.
Updated the content information.
Included link to the other Theraforge repositories.

This PR seems to be opened in an error and was intended to be against https://github.com/HippocratesTech/CDTDatastore
@SpurtiB please leave a comment if you intended to open it against Cloudant and clarify why do you think it should be considered.


Create Notification Page for Refugee (Main Page)

Show list of all donations matching refugee need setup within the defined search range (distance) --> Allow to open each item in seperate page to read details
Show list of individuals with matching requirements (helper provides child care, refugee needs it) --> Allow to send "ping request" to initialize a direct message communication
Show list of people requesting a direct messaging communication based on matching helper/refugee relations


Added a new rpc command for exporting stealth addresses

With this you will be able to export a stealth address
by a given address or a label.

Description
See issue/feature #662
How Has This Been Tested?

compiled and tested on ubuntu 16.04 LTS
Types of changes

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.

:+1:
A tip is that you can write the following: closes #662 in a commit message or in your PR description and the the issue will be closed when this PR is merged.

@Max-Meldrum and I was already confused, why it doesn’t close the ticket automatically :D Well, now I know why it doesn’t. Thanks for pointing out!


Fix notification popup display

Close #407

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.82%. Comparing base (a51321d) to head (d9f2733).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #427   +/-   ##
=======================================
  Coverage   53.82%   53.82%
=======================================
  Files         168      168
  Lines        3727     3727
=======================================
  Hits         2006     2006
  Misses       1721     1721

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Changing the Assignee of IAO; clears the group notification of Ministry Members

Describe the bug in current situation
When the request is moved from open to CFR.
The system generated the intended notification; but when the IAO changes the assignment; it clears the group notification of members.
Link bug to the User Story
Impact of this bug
In this kind of scenario; the ministry members will miss the notification.
Chance of Occurring (high/medium/low/very low)
Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?
Steps to Reproduce
Steps to reproduce the behavior:

Create a new request and move to CFR state
In the ministry login; you can see the notifications. Now change the assignment of IAO.
This clears the ministry specific assignments.

Actual/ observed behaviour/ results
Expected behaviour
A clear and concise description of what you expected to happen. Use the gherking language.
Screenshots/ Visual Reference/ Source
If applicable, add screenshots to help explain your problem. You an use screengrab.

Closing as duplicate.


Multiple locations: Final tweaks to French translation of LoP

After consulting with Marie, we need to make just a few tweaks to our French translation of LoP -- Life of Program -- in a few locations
Program page results table
Vie du programme --> La vie du programme

IPTT landing page
Remove brackets but keep the parentheses so that it says: La vie du programme (LoP) seulement

IPTT filter panel
Remove brackets but keep the parentheses so that it says: La vie du programme (LoP) seulement

@jennyhavah What about in the IPTT header.  Should I make that "La vie du program"?

Good catch @sanjuroj. Yes, as Marie requested consistent use of the article, let's change it to:
La vie du programme <-- think you have a typo in your comment.

All updates were made.


✨ Introduce kubestellar-list-mid-dynamic

Summary
This PR adds a demo/utility command that lists or watches the objects of a given kind in the mailbox workspaces.
  Can we make something that is super simple here?  simply "kubestellar-monitor-resources" would be great.

I do not love the name either.
I put "mid" in the name suggesting "middle" because it is specifically looking in a middle type of place, between the WECs and the WDSes. The objects of interest also appear in the WECs, and in the WDSes in the 1:1 case. So I thought it important that the name be specific to the fact that it is looking in the middle.
This command is ambidextrous: it can produce a one-shot listing, and it can do on-going monitoring. I expect that for your new quickstarts the one-shot listing will be the more interesting case. There is some precedent for taking the "on-going" part as a modulation of "list": kubectl get can get a list of objects, and takes an optional command line flag that turns it into an on-going watch.

The force-push to 1004e8dab fixes import ordering and the editing oversight called out in review above.

/lgtm

Let's talk this through, while this command works, it will be lost in obscurity if it is not renamed.

I am open to renaming. I mentioned some of my concerns above. The "dynamic" part is descriptive for Kubernetes experts but is perhaps not something that needs to be in the name. Following are some suggestions.

kubestellar-list-middle-objects
kubestellar-list-objects-in-middle
kubestellar-list-full-objects

how about 'kubestellar-list-objects-pending-sync'

Remember that an object subject to downsync has state flowing in two directions: the desired state flows from core to WEC, and the reported state flows from WEC to core.
A mailbox space holds both objects subject to downsync and objects subject to upsync.
These objects appear there regardless of whether any propagation remains to be done, so "pending" is not quite on-point.

An object in a mailbox space may already have been synced.  Yes, qualifying with "pending sync" and "to sync" have the same issue: they imply that the list will only have objects that have not yet been synced.

How about even simpler, kubestellar-list-syncing-object ?

sold

The force-push to 25d8d279c is a rebase plus the agreed renaming plus adding documentation.

/lgtm

/approve


icon renders error ,likes “square”

[ ] Review the documentation: https://github.com/oblador/react-native-vector-icons
[ ] Search for existing issues (including closed issues): https://github.com/oblador/react-native-vector-icons/issues

Environment
with the phone "HuaWei Honor 7c"

Description
icon renders “square” with huawei phone，other phone,like Xiaomi, renders nice!

Reproducible Demo
Let us know how to reproduce the issue. Include a code sample, share a project, or share an app that reproduces the issue using https://snack.expo.io/. Please follow the guidelines for providing a MCVE: https://stackoverflow.com/help/mcve

Hey, did you read the Troubleshooting section?

I have the same issue - only on Android. I've tried removing node_modules and generated android folders, re-linking. Sometimes I can get it back to work, but I'm not sure what and how that happens. It's not something tracked in git because I don't see changed files. But whenever it works again, I remove node_modules & generated build files and install it again the problem re-occurs.

Actually the troubleshooting section did help, if I copy the fonts manually using cp -R node_modules/react-native-vector-icons/Fonts/* android/app/src/main/assets/fonts/ and afterwards force commit them git add -f android/app/src/main/assets/fonts/ it keeps working.

Thanks for reply! I found it works after retry several times. ButI am still confusedthe reason which cause that situation.
原始邮件
发件人:Wouter De<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>发送时间:2018年10月4日(周四) 19:08
主题:Re: [oblador/react-native-vector-icons] icon renders error ,likes “square” (#854)
Actually the troubleshooting section did help, if I copy the fonts manually using cp -R node_modules/react-native-vector-icons/Fonts/* android/app/src/main/assets/fonts/ and afterwards force commit them git add -f android/app/src/main/assets/fonts/ it keeps working.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Updating MeshMate

This PR updates the profile of Anand Kumar Singh position as MeshMate.

How about Anant?


[6.0][Sema/ClangImporter] Improvements to witness matching

Cherry-pick of https://github.com/apple/swift/pull/72277

Explanation:

Improves handling of requirement-to-witness matching for ObjC members by stripping concurrency annotations only when absolutely necessary.

Scope: Witness matching.

Main Branch PRs: https://github.com/apple/swift/pull/72277

Risk: Low

Reviewed By: @hborla

Testing: Added test-cases to the test suite.

@swift-ci please test

@swift-ci please test Windows platform


Cannot install on Laravel 10

rzakhanov/translation v1.0.0 requires laravel/framework ^8.0 -> found laravel/framework[v8.0.0, ..., v8.83.27] but it conflicts with your root composer.json require (^10.0).

Not responded from author


Setup CI/CD

02-11-2022: Research / academic account for free hosting setup 1h
03-11-2022: Heroku and repo setup 2h


TAB key rebind request

Greetings! Can you, please, add a feature to rebind TAB key functionality, since I (and some others, I guess) constantly use TAB in my gameplay?
THX a lot for the great job anyways! ;)

I'll see what I can do short-term.

TYVM! Keep your project on - it IS really helpful


Create a catalogue view for APIs

Create a simple list of available API backends
User story: As Minh (API consumer), I want to find Apinf hosted APIs.
Definition of done:

[ ] HTML Mockup
[ ]  Create template with embedded with datatable using actual database collection

Still to be decided: Where will be this Catalogue view presented?
What I did

Fixed branching issue with local and current branch.

Kept the time estimate at 13 hours. Id say realistical time estimate right now is 10-11 hours.
This depends on how easily I can get data from the database.

Done. Added task #95 to hook into the navigation


Improve templates getting started experience

Currently after downloading the mdl-templates.zip archive there is no clear next step guiding developers into using the template(s). This could be fixed by, for instance, adding a README inside the archive describing the content of the archive and next steps.

@nicolasgarnier I think this is something we would start to flesh out as part of http://www.getmdl.io/started/index.html#whats-next and we could then link to this from inside mdl-templates.zip and mdl.zip.
Do you want to take a stab at writing a few paragraphs that would tackle this? I think you've got a good handle on what we're missing here.

@nicolasgarnier do you think you'll have a chance to take a look at this this week? We're trying to get 1.0.3 out the door soon :)

Hey sure, sorry for missing this was upgraded to P0  :smiley: I'll get to it.

Hey @addyosmani, @surma,
While reviewing this a few things came up that felt confusing. Please let me know what you think for each:

There is a bower.json and a package.json in the template zip file. This was a bit confusing because then I was looking for a build step of some kind especially since the package.json contained a lot of devDependencies that includes Gulp. What about removing the package.json and bower.json file? or do they have any use?

On the documentation's templates page there are 5 "Downloads" link, one for each templates:

The issue is that because of that I was expecting the zip file to contain only the files for the one template that I'm trying to download so there is an expectation/result mismatch here. Two ways to fix this:

Generate 5 different zip files containing only the content for one template (this is the more user friendly IMO)
Remove the 5 downloads link and create a small intro text with only one download link at the top. The zip file would still contain the 5 templates inside but then that would fix the expectations/result mismatch.

Let me know!

Good catch on the expectation mismatch. Our original intention was that we would only give you the template zip for the template you were trying to grab. Unfortunately, our build process doesn't support this yet but we could update it to be more granular in this regard.
Perhaps in the short term, dropping the download links and just having a single one at the top would improve matching expectations here.
bower.json/package.json: IIRC these are leftover from the way our build process generates build assets. We create a bundle that we then tag and publish to npm, however we're not excluding these build files when creating our zips. We could do this.

Unfortunately, our build process doesn't support this yet but we could update it to be more granular in this regard.

Personally, I think we should not provide downloads for each template individually. MDL is our library/product, not the templates. Deleting the ones you don’t want isn’t too much to ask, is it? Feel free to correct me here :)

Perhaps in the short term, dropping the download links and just having a single one at the top would improve matching expectations here.

:+1:

bower.json/package.json: IIRC these are leftover from the way our build process generates build assets. We create a bundle that we then tag and publish to npm, however we're not excluding these build files when creating our zips. We could do this.

We are actually actively adding both bower.json and package.json and I feel like we had a reason to do so but I don’t remember. I’m definitely in favor of removing these files if they are not needed (anymore).

Depending on how long we have until 1.0.3 I can try to generate the 5 zips. :D (or not if you actually prefer only one link)
More things that I plan on changing please let me know if you think otherwise:

Add a README inside the ZIP ile(s) giving a short description of the template and next steps if the user want to customize.
Currently material.min.css and material.min.js are included in the zip. Since the CDN hosted libs are our recommended option I'll switch to referencing the CDN hosted version directly (FYI the android template does that already for the JS but the version in the link does not get updated) and stop including the libs file's inside the zip.
Currently a custom material.min.css is also included inside each templates' folder, this was to customize the color accents. We won't need this since I can refer to a color specific CDN hosted CSS.

WDYT? This will make the zip file a LOT simpler by removing a lot of files and show developers how to use the CDN hosted libs.

Also the zip has an assets folder which contains all the documentation's CSS and images. I guess it's here by mistake. Shall I remove it or was there a good reason it's here? :)

I like your plan. I don’t have a strong opinion on 1 vs 5 ZIPs. I gave my personal 2¢ already.
The assets were added because the ZIP contains templates/index.html as a listing of all the templates, which needs the assets. If we agree to remove that, assets can go as well.
I give you full decision making power (and thereby responsibility) on this matter @nicolasgarnier :stuck_out_tongue:

I'd say keep one zip. It isn't a big deal to move to 5, only makes more variables to mess up at some point.
Remove templates/index.html and make the templates zip just that, the templates using the CDN copies. Keep it as light as possible.
What kind of information would a README contain here? It seems like low-hanging fruit to describe next steps for example templates.

I have something for the 5 zips which shouldn't require us to maintain 5 variables (it uses the folder name which is already used when generating the template documentation page anyways) so I'll send that for review soon :)
Yes the README was just going to give some pointers about what folder contains what files for which template although now that we've removed most files from the zip and that there are 5 separate zips it feels almost superfluous...

I didn't mean variable so literally. I just meant it as, 5 possible variations to get reports about vs reports on a singular zip. Overall though, they are pretty basic so it doesn't matter much either way. Just felt one is enough.
The README is very much not-needed imo. If developers don't understand what to do with the templates then they shouldn't be using them at all. They are not built to let just anyone throw a site up and be good, they are just example work.

Yup lets not include READMEs anymore. I can't really think of anything to put in there which is a sign they are not needed. The zips are so small now anyways (just the index.html, the css and - sometimes -an images folder...) as you said, web developers should know what to do at this point :D
I was initially thinking to add a README because the templates archive contained a lot more files, the index.html for all the templates, the generated libs. Also I thought there might have been a build step since there was a package.json file etc... but in fact it's just a static website made of 2 files :)


Rate limited After an Hour of Use Troubleshooting One File.

Type: Bug
I've read the other open issues and in one, lramos15 said that hitting the limit would put you in the top 0.1% of users and it's not possible to hit the rate limit after an average number of requests. I've been using Copilot for about an hour and haven't made many requests; more than 10, less than 50. Now it says to wait 12 hours.
Is there really a limit this low? If so, it's better to just use the OpenAI site, right?
Extension version: 0.22.4
VS Code version: Code 1.95.3 (f1a4fb101478ce6ec82fe9627c43efbf9e98c813, 2024-11-13T14:50:04.152Z)
OS version: Windows_NT x64 10.0.22631
Modes:

System Info

Item
Value

CPUs
13th Gen Intel(R) Core(TM) i7-13650HX (20 x 2803)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabledwebnn: disabled_off

Load (avg)
undefined

Memory (System)
15.63GB (2.07GB free)

Process Argv
--crash-reporter-id d0368cf9-a231-4732-a032-7cd969abd4ea

Screen Reader
no

VM
0%

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805cf:30301675
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
vscaac:30438847
c4g48928:30535728
azure-dev_surveyone:30548225
vscrpc:30673769
a9j8j154:30646983
962ge761:30959799
pythonnoceb:30805159
asynctok:30898717
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
dvdeprecation:31068756
dwnewjupyter:31046869
nativerepl1:31139838
pythonrstrctxt:31112756
cf971741:31144450
iacca1:31171482
notype1cf:31157160
5fd0e150:31155592
dwcopilot:31170013
stablechunks:31184530

If you're using O1 it has a smaller 10 request rate limit https://docs.github.com/en/copilot/using-github-copilot/asking-github-copilot-questions-in-github#ai-models-for-copilot-chat


Issue Updating Screen Events

Hi, im using Schematica 1.9 and whenever I try to load up a schematic it crashes. The only mods I have are schematica and LunatrisCore.
The Crash:
http://paste.ee/p/ebvlA

Nvm I just needed to update (im so stupid)


KA-423 Add /link-to/ endpoint to robots.txt

You are right.
I'm sorry for my previous lazy attempt and not checking the commit afterward.


Negate wo reason

I got all successful tests when running the API measure evaluator with 2015, 2016 and 2017 bundles


Dependabot encountered an unknown error

Is there an existing issue for this?

[X] I have searched the existing issues

Package ecosystem
Bundler
Package manager version
No response
Language version
Ruby '>= 3.0', '< 4'
Manifest location and content before the Dependabot update
/flame_app_generator.gemspec
dependabot.yml content
version: 2
updates:
  - package-ecosystem: bundler
    directory: /
    schedule:
      interval: weekly
    groups:
      bundler:
        patterns:
          - 'bundler'
          - 'bundler-*'
      toys:
        patterns:
          - 'toys'
          - 'toys-*'
          - '*_toys'
      rubocop:
        patterns:
          - 'rubocop'
          - 'rubocop-*'
      simplecov:
        patterns:
          - 'simplecov'
          - 'simplecov-*'

  - package-ecosystem: npm
    directory: /
    schedule:
      interval: weekly
    groups:
      remark:
        patterns:
          - 'remark'
          - 'remark-*'

Updated dependency
No response
What you expected to see, versus what you actually saw
Running Dependabot.
Native package manager behavior
OK.
Images of the diff or a link to the PR, issue, or logs
updater | /home/dependabot/bundler/lib/dependabot/bundler/file_updater/ruby_requirement_setter.rb:77:in `eval': (eval at /home/dependabot/bundler/lib/dependabot/bundler/file_updater/ruby_requirement_setter.rb:77):1: syntax error, unexpected ',', expecting end-of-input (SyntaxError)
'>= 3.0', '< 4'

https://github.com/AlexWayfer/flame_app_generator/actions/runs/10604867879/job/29392453827
logs_27725288555.zip
Smallest manifest that reproduces the issue
No response

And another example: https://github.com/AlexWayfer/flame_generate_toys/network/updates/875674393


Inc sample update

Existing Sample Changes
Description
Updated readme to fix errors and adhere to the standard template
Fixes Issue# https://jira.devtools.intel.com/browse/ONSAM-1874
External Dependencies
List any external dependencies created as a result of this change.
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ X] Implement fixes for ONSAM Jiras

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[X ] Command Line
[ ] oneapi-cli
[ ] Visual Studio
[ ] Eclipse IDE
[ ] VSCode
[ ] When compiling the compliler flag "-Wall -Wformat-security -Werror=format-security" was used

Updated here: https://github.com/oneapi-src/oneAPI-samples/blob/development/AI-and-Analytics/Getting-Started-Samples/INC-Quantization-Sample-for-PyTorch/README.MD
Will merge in the 2024.2 release.


deps: update time crate version.

The time crate version used in rbpf has a security issue (though the use of it in this library is secure). Update the time crate version to make the audits of the crates which depend on rbpf succeed.

CI was failing because of #77 with recent versions of the toolchain, so I pushed a fix on master, and went ahead and rebased/force-pushed your branch on top of that.

Thanks! A new version would be nice at some point, but there is no real hurry about that. :-) I was examining libcontainer dependencies.

https://crates.io/crates/rbpf/0.2.0 freshly released.


GDScript: Fix await type inference

This PR fixes await x expression type inference. Now the following code works:
func test() -> int:
    await get_tree().create_timer(2.0).timeout
    return 42

func _ready() -> void:
    var x := await test() # <-- int
    print(x)

Can you please rebase and force-push to retrigger the CI again? Just in case some tests need updating after https://github.com/godotengine/godot/pull/72608.

Thanks!


std::vector: reserve() vs resize()

There are many places in the code where the size of vector is supposedly set before writing into the elements in a loop. The code uses reserve() for that. However reserve() changes capacity and not the size. As a result further attempts to access vector elements fail when compiling in debug mode (assertion failures).
I can imagine that when compiling in release mode (no bounds checks) and not using size() for vectors the code may accidentally work as needed.
Here are few examples:

StaffObjsCursor::initialize_clefs_keys_times;
PartsEngraver::create_group_engravers;
ColumnsBuilder::determine_staves_vertical_position.
etc.

Just search the code for "reserve". At most places where "reserve" isn't followed by "assign" the function "resize" must be used instead (alternatively reserve + push_back instead of operator[]).
Furthermore at places where "assign" is called after "reserve" the "reserve" is superfluous since "assign" knows the size and can reserve capacity itself.

Many thanks for spotting this.
I used resize() to avoid reallocations as elements are inserted, followed by assign() to initialize the vector when filling the vector will not be done by push_back(). Unfortunately, as you spotted, in some cases I forgot the assign() part! And I didn't realize that reserve() is superfluous when followed by assign(), thanks.
I will review the code and try to fix this. In any case, for this or other issues, PRs are always welcome! ;-)


Exception if not specifying full path

In 3.0.2:
Haven't been able to test iOS yet, but this code works:
var path = "syncstore.db";
path = Path.Combine(MobileServiceClient.DefaultDatabasePath, path);
//setup our local sqlite store and intialize our table
var store = new MobileServiceSQLiteStore(path);

This code fails:
var path = "syncstore.db";

//setup our local sqlite store and intialize our table
var store = new MobileServiceSQLiteStore(path);

Browsing through the code it makes no sense unless for some reason the android part isn't being called due to something weird. Not sure.
You can test this in: https://github.com/jamesmontemagno/app-coffeecups

v3.0.3 is released. Close this.
https://github.com/Azure/azure-mobile-apps-net-client/releases/tag/3.0.3


Bug:  404 Error on Canceling GitHub Login for Build Resume Feature

Hello @ashutosh-rath02,
Your project was amazing bro, I followed you on social platforms
Here is the Issue -
The "Build Resume" feature on the website. When users click on "Build Resume," they are redirected to the GitHub login page. However, if the login process is canceled, it results in a 404 error page.
Screenshot -
To help illustrate the issue, I have attached a screenshot for your reference.-
https://github.com/ashutosh-rath02/git-re/assets/145179532/ea4d5c62-3a48-42a7-8f49-646ec61cd83b
Could you please assign this task to me? i want to fix this issue
I look forward to your response.

Go ahead @Aniket-2504 , all the best

@Aniket-2504 updates?

I'm working on the issue but need a bit more time to resolve some challenges. I'll update you soon.

Hi @ashutosh-rath02,
If the author is unable to resolve this issue, please feel free to assign it to me. I've already resolved this issue locally and would be happy to help out.
https://github.com/ashutosh-rath02/git-re/assets/65452005/380e666a-4bd0-43df-a2a0-38d23d1bcaf3

Just give me few hours I'll also working on the issue

Hello @dhairyathedev you can proceed with the issue bro

Hey @ashutosh-rath02, you can assign this issue to me.

Hello @Aniket-2504! Your issue #148 has been closed. Thank you for your contribution!