Asking for the speed of the code

Thank you for your great work! I noticed that when I used your method to create a conda environment, I encountered the following warnings. 2024-12-20 15:50:27.895895: I tensorflow/core/platform/cpu_feature_guard.cc:193] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX2 AVX512F AVX512_VNNI FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
2024-12-20 15:50:28.008986: I tensorflow/core/util/util.cc:169] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable TF_ENABLE_ONEDNN_OPTS=0.
2024-12-20 15:50:28.039376: E tensorflow/stream_executor/cuda/cuda_blas.cc:2981] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered
2024-12-20 15:50:28.683316: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer.so.7'; dlerror: libnvinfer.so.7: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: :/home/fank/.mujoco/mujoco210/bin:/home/fank/.mujoco/mujoco200/bin:/home/fank/.mujoco/mjpro150/bin:/usr/lib/nvidia:/usr/local/nvidia/lib64:/home/fank/.mujoco/mujoco210/bin:/home/fank/.mujoco/mujoco200/bin:/home/fank/.mujoco/mjpro150/bin:/usr/lib/nvidia:/usr/local/nvidia/lib64
2024-12-20 15:50:28.683422: W tensorflow/stream_executor/platform/default/dso_loader.cc:64] Could not load dynamic library 'libnvinfer_plugin.so.7'; dlerror: libnvinfer_plugin.so.7: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: :/home/fank/.mujoco/mujoco210/bin:/home/fank/.mujoco/mujoco200/bin:/home/fank/.mujoco/mjpro150/bin:/usr/lib/nvidia:/usr/local/nvidia/lib64:/home/fank/.mujoco/mujoco210/bin:/home/fank/.mujoco/mujoco200/bin:/home/fank/.mujoco/mjpro150/bin:/usr/lib/nvidia:/usr/local/nvidia/lib64
2024-12-20 15:50:28.683430: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Cannot dlopen some TensorRT libraries. If you would like to use Nvidia GPU with TensorRT, please make sure the missing libraries mentioned above are installed properly. Does this warning impact the performance of the code in terms of acceleration? Additionally, I would like to know how to speed up the training process. I tested the code on my computer using the default settings, and it took 6 seconds to train one epoch. Are there any methods to further accelerate the training process? Furthermore, I am curious about the number of epochs required for each environment to achieve convergence. Thank you!

I'm not sure whether you're using a GPU from the error message, but I think you can check it by inspecting whether PyTorch tensors are on your GPU. For downstream evaluation, we used 10000 epochs for state-based MuJoCo, 2000 epochs for pixel-based Quadruped, and 3000 epochs for pixel-based Humanoid.

Thanks a lot! I am also wondering whether your code can run state-based Quadruped or Humanoid.

While the current code doesn't support state-based Quadruped/Humanoid, I believe it can be implemented relatively straightforwardly as in state-based Ant/HalfCheetah.

Thanks! I am also wondering how many times you will spend when running 20000 epochs for dmc quadruped or dmc humanoid(pixel-based)
?

I suspect it'd take quite a long time (3-6 days) to do 20000 epochs on pixel-based Quadruped/Humanoid with the default hyperparameters.


Strike through support extension

Adds strike through support, still needs a functional test (couldn't get test to work saying their was no parser for the Document type)

This would be awesome

Especially considering that https://github.com/uafrica/commonmark-ext is severely outdated and doesn't seem to be well maintained.

FWIW, you could probably just port some of the existing https://github.com/uafrica/commonmark-ext tests into this PR. I would, but I don't want to duplicate the effort with this PR.

I haven't looked closely at that package or its tests, but if they seem comprehensive enough then I like  @markcarver's suggestion of porting them.

FYI having some solid tests is the only thing preventing me from merging this right now :wink:

@colinodell sounds good, let me see what I can do in the next couple of days

@tankerkiller125 would you be able to finish this?

@glensc Unfortunately I don't think i currently have the time to complete the test so that this can be merged.

@tankerkiller125 no problem, I can try porting these myself:

https://github.com/thephpleague/commonmark-extras/pull/13#issuecomment-377495197

just did not want to do duplicate work and also did not want you to be left out if I just took over without asking first.

added commits top of this branch:

https://github.com/thephpleague/commonmark-extras/pull/18

you can close this PR.


Minor fixes in sprites.py

@chimosky Please Review.

@Saumya-Mishra9129 looks good. When this gets merged, please ping me so I can fix the same in AmazonasTortuga and TortugaMexico. I am not sure of other repos which use TurtleArt.
This is one of the problems when a same module gets diverged smile . (alternatively, you may create a PR too)

@srevinsaju Ping

Thank @Saumya-Mishra9129 :smile:


Stop dumping test artifacts in chisel3/

I'm looking at you, TopOfDiamond, UsesMuchUsedModule, and DummyModule. We have a standard convention for test directories (currently dumped in /tmp as per TesterDriver.execute(...), though it wouldn't necessarily be a bad idea to change this to something like build/).
Practically this makes git status a lot more messy as you have random test artifacts in the untracked files section.
Some refactoring of TesterDriver.scala to have incrementally more defined tester Drivers (for example, a basic one with just destination directory, one on top with the Verilator compilation, and one on top of that with the BasicTester stuff, etc) might be a good solution here.

We definitely need to stop using /tmp as well. I agree with switching to build/ or something, and we should consider deleting successful tests (although expecting the user to be able to nuke build/ doesn't seem to unreasonable

Perhaps have a new test clear the results / artifacts of the previous test? The random string of numbers after the test name (like LastAssignTester1352679602163862897) isn't helpful at all.
There's definitely an argument for keeping artifacts indefinitely, though I don't think that's how most testing systems work. But if you really wanted to keep all test results, at least make the numbers meaningful, like a seconds-resolution timestamp.

Clearing the previous results seems reasonable. If we do it this way, we can just drop the random string of numbers, those are generated by Java when you make a temp directory. Alternatively we could do timestamps, I could go either way.

I'm all for cleaning these up but cleaning the results as a test starts isn't going to work because scalatest runs things in parallel.
Seems like a good first step would push these things into a directory, test_run_dir is what chisel_testers uses, the entire directory can be wiped easily then

Tests could run in their own directory (like build/LastAssignTester/) which can be wiped independently of other tests. Though there's still the problem is multiple tests (or even the same test with different parameters) under the same Spec, which might cause a collision. So it might just have to be don't wipe anything and timestamp things. Or provide an API to disambiguate different specs / tests, which would be more ideal but also cumbersome. Maybe ScalaTest has something to better automate this?

Multiple tests stomping on each other may be the cause of this report by @shunshou here Verilator backend breaks for multiple tests


Making ghcid more usable by external tools

So, ghcid seems to be the only interactive tool that actually works reasonably with new-build I'm trying to get it working with vim and neomake (I don't have neovim available, so sadly the existing nvim plugin doesn't quite work). I'd like to propose some minor tweaks that make ghcid slightly more friendly to tooling. I'm already implementing this stuff, so this issue is more to discuss behaviour preferences to get the finished work merged back into ghcid (because I don't wanna keep porting it forward indefinitely).
Desirable changes when reading ghcid output in tools:

Disable ANSI colouring
Don't linewrap
Sentinel output to indicate the end of error/warning list

My personal changes to the design would be as follows (but I'm open to ensuring the default behaviour doesn't change and putting all the above changes behind flags, if you prefer to preserve the current behaviour at all cost):

Auto-detect when ghcid is talking to an ANSI terminal.
Disable ANSI colouring when not talking to a terminal (unless a new flag forces colouring on).
Disable the linewrapping/error truncation when not talking to a terminal (unless an explicit width/height are passed in on the command line).
Output a sentinel at the end of output when height is not limited. (This is the change I'm most torn about, it might be nicer to just never output a sentinel unless explicitly instructed by a flag...)

While this changes some of the default behaviour of ghcid, it shouldn't affect most usecases, as I think in most cases people use it attached to a terminal anyway. But, as I said, I'm open to preserving the current behaviour as-is and hiding all my changes between flags if that's preferred.

After playing around a bit with it, I think a lot of the terminal code is rather deeply intertwined with the other ghcid code so that making these changes becomes rather invasive.
A hacky, but much simpler approach might be to not change any of default behaviours at all and just add the ability to inhibit doing output at all. Because then the desired effect can be achieved by simply running ghcid with -o /dev/stdout, which already logs all messages without any wrapping  or ANSI colour noise.

That would still necessitate adding a flag to output some sentinel line to distinguish when error reports end, but that should be fairly easy. Which would reduce any changes to one flag to write such a sentinel line and another flag to inhibit the standard output, which should also be fairly trivial.

Happy to make changes. I guess the first question is how you interact with it - I expected that for downstream tooling the -o output mode would be easiest - that's what the VS Code plugin uses. With respect to that:

It doesn't do line breaking, so no issues there - basically it assumes an infinitely sized canvas.
It doesn't add coloring, so again, all good there.
It writes the file atomically - specifically to another location and then renames at the end. That way you can just watch the file, and you get atomicity in the consumer without a sentinel.

How does that change what you still require?

@ndmitchell Ok, after diving into the source more, the more I realise making the ghcid executable support what I want seems kinda pointless, as it involves optionally disabling like 90% of the code. Currently I'm just using the ghcid inspiration to write the tool I need using the ghcid library.
The only change I'd like to see is that, currently, startGhci uses shell from the process library to start ghci, which rather breaks things on my system, as ghci is actually aliased to a specific .ghci files, etc.. So I would like to propose a change that uses proc to run ghci, ensuring it runs the actual executable, not any shell aliases/scripts.
Since that'd be a breaking change that changes a lot about how startGhci works, I understand if you wanna keep it as-is, but at the very least I'd like to add an alternative/variation (not quite sure how it should be named) of startGhci that uses proc. I can make a PR for that if it's ok with you (and feel free to chime in with any naming suggestions).

The fact it uses shell is not an accident - many companies have custom ghci.bat or ghci.sh files that set up their environment to work with ghci, so it is critical. How about adding:
startGhciProcess :: CreateProcess -> (Stream -> String -> IO ()) -> IO (Ghci, [Load])

Then you can specify exactly what you want and the existing startGhci can just forward on to that new function?

I was thinking of something like startGhciProc :: String -> [String] -> (Stream -> String -> IO ()) -> IO (Ghci, [Load]) as alternative variation of startGhci and then forwarding them both to your suggestion. Or, alternatively just have all 3 variations to cover all bases.

I suggest startGhciProc should take a FilePath for the current directory, for symmetry with startGhci, which should really have been called startGhciShell (but probably too late now?).

I renamed startGhci to startGhciShell (keeping a deprecated startGhci alias) and added startGhciProc. I didn't expose the underlying CreateProcess -> (Stream -> String -> IO ()) -> IO (Ghci, [Load]) since some of the CreateProcess fields get overridden, so that seems inelegant, although I'm ok with exposing that function too.
Personally I'm ok with nuking the startGhci, but I'm generally more gung-ho about backwards compat breaking changes, so I kept it around for now. (See #142)

@ndmitchell Ping?

Delayed pong! Merged now!
Is there anything else to be done in this issue or are all the problems now solved?

Works for me, cheers.


fix-expat-x64

"Fixes [[expat] Build error on x64-windows #35878]

@microsoft-github-policy-service agree [company="default"]
@microsoft-github-policy-service agree
@microsoft-github-policy-service agree company="Microsoft"

@microsoft-github-policy-service agree
@microsoft-github-policy-service agree company="your company"

"Fixes Also [icu] Build error #22976 depend on expat

"Fixes [[expat] Build error on x64-windows #35878]

I don't think so. The issue reports an error at determining the compiler. This is far away from see this macro.

Fix also [icu] Build error #22976 depend on this port

I don't think so. Port icu doesn't depend on port pcre. And that issue doesn't point to expat.

I agree with @dg0yt , this doesn't seem like it'll fix anything about that. Has this change been submitted upstream?
Feel free to mark 'ready for review' if upstream has had 30 days to consider the change with an explanation as to how it actually achieves fixing the indicated issues.

Closing this in favor of https://github.com/microsoft/vcpkg/pull/39505 ; if upstream accepts your changes please feel to reopen with a pointer to where they accepted it.


Can this suppot dbt version 1.2.0?

Hi, currently my dbt is running using version 1.2.0. Is it possible to run this without any issue?

Hello, @JimmyPoh88. Thanks for asking. dbt 1.2.* is currently supported by fal, I will add this information to the README, since it seems we forgot.
Cheers!
PD: integration tests for 1.2: https://github.com/fal-ai/fal/actions/runs/2972497791


Allow array file uploads to be validated also by 'uploaded'. Fixes #3018

Description
Currently, all validation checks of FileRules allows validating array file uploads, except for uploaded. This PR adds that functionality. The documentation had already said that all file validation rules check for both single and multiple file uploads.
Fixes #3018
Checklist:

[x] Securely signed commits
[x] Component(s) with PHPdocs
[x] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

Thanks :)


Added getters and setters using lombok for accessing data models in DAO

Added getters and setters using lombok for accessing data models in wherehows-dao.

Coverage remained the same at 0.0% when pulling 7823ba219ff2d2b0fe13b34ab6bec420c82359b8 on ShridharSattur:master into 04f61e13f1af338396dd426ea272630d49c5ca28 on linkedin:master.


Reducing the number of paths of remote-change event

Description:
Reducing the number of paths of remote-change events.
Changes to the document are propagated to peers as remote-change events.
When inserting nested objects, there is a problem that the path becomes excessively large.
For example, inserting a nested object into one field will create paths for remote-change like this:
clientA inserts nested object.
doc.update((root) => {
  root.projects = [{
    id: 'id7fb51ad',
    _timestamp:<PHONE_NUMBER>095,
    _time:834.9000000357628,
    visible:true,
    lock:false,
    selected:false,
    layers":[{
    ...
  }]
});

Currently clientB receives remote-change event.
{
  type: 'remote-change'
  value: {
    paths: [
      '$.projects',
      '$.projects.0',
      '$.projects.0.id',
      '$.projects.0._timestamp',
      '$.projects.0._time',
      '$.projects.0.visible',
      '$.projects.0.lock',
      '$.projects.0.selected',
      '$.projects.0.layers',
      '$.projects.0.layers.0',
      ...
    ]
  }
}

We can reduce paths by leaving only the top-level path when the nested object changes.
{
  type: 'remote-change'
  value: {
    paths: ['$.projects']
  }
}

Why:
Excessive accumulation of paths can lead to unnecessary resource usage.

✋ May I try this out? I have experienced this nuisance when creating a yorkie example on my own.

@hunkim98 Sure. 👍

This was solved by #691.


Selecting new catalog template does not update docker-compose.yml and original service will be started

V0.47.0
Steps to Reproduce:

Open up a catalog template
Use dropdown to select a different catalog template

Result: Old service will be started as the docker-compose.yml is not updated
Expected result: Newly selected service to be started. If expanding preview section, the new template should be shown.

Verified with v0.49.1, UI v0.71.0


Add an action for federating for octo-sts tokens

An example of it working with gh CLI:

An example failure:

Fixes: https://github.com/chainguard-dev/octo-sts/issues/5

I made the repo public here, so you can see the trust policies, but when it was run above it was private: https://github.com/mattmoor/test-bed

https://github.com/apps/octosts


fix: reconnectConfig should not be deleted

The ReconnectConfig must not be deleted. This ensures that the connection is re-established even after a connection is lost, for example by switching flight mode on and off again. This pull request fixes the error in Issue #18

Hey @aabegg, Thanks for this contribution.
I'll verify this and will push a version out in next 24hrs.


Enable virtualtext in currentLabelOnly

Background
I believe looks cooler than border style.

I reorganized the style configuration to make it more customizable. Can you try the #28 with the following settings?
let g:signature_help_config = {
      \ contentsStyle: "currentLabel",
      \ viewStyle: "virtual",
      \ }

Merged the fix. Please use the settings above.


Not getting data while calling  function client.on('data',.... )

Hello,
I am not getting data coming from server in following code.
But I get the data in TcpSocket.js in _onData  prototype.
 client.on('data', function(data) {
        console.log('Received finally: ' + data);
      client.destroy();// kill client after server's response
      });

So main issue is from TcpSocket.js, I am not getting returning value in my screen.js after connecting to server. Please help me..  I m new to react native and javascript.

same issue


Documenter builds are failing

Documenter builds are failing with the following error:
ERROR: LoadError: MethodError: no method matching wait_for_ready(::Nothing)
I'm unsure what this means or what is causing it

I wonder if the builds are failing because WGLMakie can't find a screen to print to.
The function is referenced in WGLMakie here: https://github.com/MakieOrg/Makie.jl/blob/7d8699742dea80dc417f984473b36ee8535d9a35/WGLMakie/src/display.jl#L208
It comes from the Bonito.jl package, where I think it is defined here: https://github.com/SimonDanisch/Bonito.jl/blob/e2cf265d158e16cd6d97dff9f09488f32777794f/src/session.jl#L21

Would using CairoMakie potentially solve this since the output is rendered as images (and doesn't require a WebGL browser)?

I'm pretty certain now that this is the issue. See here: https://github.com/orgs/community/discussions/60273
I think the WGLMakie.activate!() is what triggers this. I think switching to CairoMakie should fix this - am happy to try it if you'd like.

This was the problem, and it is now fixed! Thanks!


Grid/Flex: Add Accessibility section to inform users about things to take note of if they're using order property

🙋 Documentation Request
Can we add following text to Grid and Flex documentations. There is a link to order property's MDN page in the documentation but surfacing the accessibility concerns in react-spectrum documentation will be helpful.
Accessibility
Using the order property will create a disconnect between the visual presentation of content and DOM order. This will adversely affect users experiencing low vision navigating with the aid of assistive technology such as a screen reader. So, the key is to always begin with a DOM order that reflects the correct or intended reading order, and then to ensure that visual presentations  also convey that order.

I think this is covered by the official HTML docs about display grid/flex and we won't have these components in s2 anymore. So I'm going to close this.


Custom Header

I need to implement a checkbox in the header.
Please send me to code example of a custom header.

Which header, the lane header? If that is what you are looking for, check out this example of using a custom lane template: https://github.com/rcdexta/react-trello/blob/master/stories/CustomLaneStyling.story.js


pinentry: fix darwin-aarch64 build

Motivation for this change
qt does not support darwin-aarch64 yet.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 133669 at d5d5bed9 run on aarch64-linux 1

5 packages skipped due to time constraints:

pinentry
pinentry-curses
pinentry-emacs
pinentry-gnome
pinentry-gtk2

7 packages built successfully:

blackbox
nixos-install-tools
passExtensions.pass-tomb
pinentry-qt
python38Packages.trezor_agent
trezor_agent (python39Packages.trezor_agent)
tomb

2 suggestions:

warning: missing-patch-comment
Consider adding a comment explaining the purpose of this patch on the line preceeding.
Near pkgs/tools/security/pinentry/default.nix:64:5:
   |
64 |     (fetchpatch {
   |     ^

warning: missing-patch-comment
Consider adding a comment explaining the purpose of this patch on the line preceeding.
Near pkgs/tools/security/pinentry/default.nix:62:5:
   |
62 |     ./autoconf-ar.patch
   |     ^


TCP k8s headless service support

What this PR does / why we need it:
Adds support for k8s TCP headless services. Also enables discovery of and routing to headless HTTP/HTTP2 services.
Which issue this PR fixes: fixes https://github.com/istio/pilot/issues/964
Special notes for your reviewer:
Additional work needed for other protocols (HTTP/gRPC etc). Currently HTTP/HTTP2 requests are routed / load balanced based on their host headers. If this behavior needs to be modified, it can be addressed in follow-on PRs.
Release note:

@ijsnellf: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
5bb74ab2fee59a3a7a4fde5af489db31b9b1c946
link
/test pilot-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

this tackles just TCP right? Lets get this PR passing and ship it. Do gRPC in another PR unless its an easy fix.

@ijsnellf: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-e2e-smoketest.sh
901152de3a91fd2b351c142f6c698dfb2d69d833
link
/test pilot-e2e-smoketest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ijsnellf: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-e2e-smoketest.sh
07d3f1bb76dc2da9334fcc9c1079b405646a9c68
link
/test pilot-e2e-smoketest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@ijsnellf: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
a02ea5e33388a1c53cb3a823206209ba4202081f
link
/test pilot-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: I added explicit checks for TCP wildcard listener duplicates and made TCP listener ordering deterministic. Since TCP listener ordering is deterministic, TCP/HTTP wildcard listener conflicts should be de-dupped by listeners.normalize(), but that will be done silently (no warning messages).


ion-range dualknobs bug

Ionic version:  (check one with "x")
[ ] 1.x
[ x] 2.x
I'm submitting a ...  (check one with "x")
[x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
The bug appear when i assign dualknobs ion-range to a form. I've tried with template driven form and model driven and have the same problem
Steps to reproduce:
http://plnkr.co/edit/AkYp4Jjd14nJrT2qp3K2?p=preview
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
Your system information:

 ordova CLI: 6.5.0
Ionic Framework Version: 2.3.0
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.2.2
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 10
Node Version: v6.9.1
Xcode version: Not installed

Hello, thanks for opening an issue with us, we will look into this.

Hi friend ... I had the same problem. Try it this way .. I'm sure it will work.  i used latest version
try with this in the .html :
<ion-range dualKnobs="true" [(ngModel)]="knobValues" min="21" max="72" step="3" snaps="true">
and try with this in the .ts
knobValues: any = {
upper:100,
lower:50
}
It should work now.

@jgw96 Can't reproduce with current form controls.


Require root key for GraphQL endpoint

We are  not sure how keys and the network queries will interact.
To not do more work than is necessary (#453), we'll require a root key to use the GraphQL endpoint for now, since it'll have access to all data.

[ ] Add root key check
[ ] Update documentation about GraphQL endpoint.

Is this still relevant @moretea?

Obsolete as key auth has been replaced by auth plugins (mostly OIDC in the wild).


F1000 Bugfixes

Fix icon size
Fix affiliation @BeastyBlacksmith
Fix icons are broken links in the text

Feel free to add here, so that we can fix that when the reviews are in!

first report: https://f1000research.com/articles/13-1429/v1#referee-response-345505

What a lovely report. Lots of good points in there

Also is it meant to be aspirational (e.g., all RSEs should have these) or does it represent the current state of RSEs (e.g., most RSEs already have these competencies)?

I think this is a confusion we had at different phases and indeed we are probably not consistent (let's check the tables again, for example). I think that we have converged to "RSEs should have these", but we arrive on these points partially based on the what RSEs already have.

Section 5.3 (Project team structures) - there is a gap here: "The single RSE on a team of not-RSEs who does not have a central RSE team connection." These do exist (sadly).

Probably a nice forward-reference to the institutions paper(s)?
I really like the following suggestions for more text:

funding methods (but how do we make it fit the teaching aspects?)
RSEs being integrated into existing teams and having to fight that team's culture

How do we proceed with the editing/revision?


Freeze because of "started 10 jobs in one tick. newJob=HaulToContainer"

I've encountered a bug with Achtung where a pawn tries to haul resources to an unfinished building and for some reason stacks the hauling attempts until the game freezes (or produces a stackoverflow errror with another player).
Hugs Lib log (This is from before the game freezes, obviously I can't upload the log after that)
Savegame that freezes after a few seconds when you undraft the pawns: Community's Cave Test.zip

Good report! I’ve had the 10 jobs error before but my game never crashed because of that. I’ll look into it.

Please verify that the latest version fixes your problem.

Seems to be fixed, thanks 👍


[FEATURE REQUEST] Logarithmic Graphing Checkbox on Balance Over Time Report

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
When looking at multiple accounts and including large assets or debts, the smaller stuff gets smashed together.
Describe the solution you'd like
A logarithmic graph would help spread the smaller balances out a bit. By making it a checkbox on the report, it can be turned on or off as desired.
Describe alternatives you've considered
The only real alternative is to not have the big accounts included when looking at an overall picture.
Additional context
Attached is a screenshot illustrating the issue. The top line is my monthly Zestimate for my house, the bottom is my mortgage balance.

@nconantj This may be an interesting addition, are you suggesting that we just add a log base 10 of for each data point in each of the graphs?
My only concern is that all those smaller graphs would scale down with it. IE (all those smaller graphs would become so small that they're practically zero).
My understanding may be off here. Lmk what I can do to help as I do agree the big gap is a little offputting.

In a nutshell, yes, and it would be very simple if done based on milliunits.
This would actually have the effect of spreading out the smaller values as well. Under the hood, you're plotting y = log(x) while the user would see 10^y due to the labeling.
For negative values, you would negate the log of the absolute value and plot that result.
For 0, you would just plot 0.
For all other values you would plot the log of the value.
The only issue that might arise is the handling of 1 milliunit, since log(1) = 0. The best way would probably be to make y=log(x) + 1 and label as 10^(y-1).
You would also take into account the number of decimals in the currency and maybe start ticks where the currency hits its whole unit, y = d + 1.

+feature

We use Trello to track Feature Requests so that users can vote on what they'd like to see next. This is crucial for us since there are so many requests and so little time amongst those of us who work on the Toolkit.
Your feature request has been added here and will need to be manually sorted.
This issue can now be closed.


WIP: empty commit

jenkins, test this on java 11 please

jenkins, test this with java 11 please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/10900/
Test PASSed.


Add CRP6-DAPHNE PDS GDML geometry

@tomjunk
Simply adding a new GDML file for PDS on VD coldbox cathode and membrane.
Ready for merge =)

trigger build with dune/dunecore@117

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

:heavy_check_mark: CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

:x: CI build for DUNE Failed at phase build DUNE on slf7 for c14:prof -- details available through the CI dashboard
:rotating_light: For more details about the failed phase, check the build DUNE phase logs
parent CI build details are available through the CI dashboard

:x: CI build for DUNE Failed at phase build DUNE on slf7 for e26:prof -- details available through the CI dashboard
:rotating_light: For more details about the failed phase, check the build DUNE phase logs
parent CI build details are available through the CI dashboard


Tested jail.go completely and tested distribution.go/DivvyingTips

get those tests to pass @CJPotter10 and I'll merge it in


FIX #42 - Downscaling Loki wipes its configuration

Issue

See #42
Solution

Now we are no longer checking the event type, we are only checking if we have loki_endpoints provided by the Provider side of the relation
Context

Testing Instructions

Deploy grafana-agent
Deploy 3 loki units
Relate both charms juju add-relation grafana-agent loki
Down scale Loki juju scale-application loki 2
Verify that loki section in grafana-agent config file is NOT empty: juju ssh --container agent agent/0 cat /etc/agent/agent.yaml

Release Notes

Tests currently failing. Waiting to do a final review until it passes again.


Upgrade polyfill-library to 3.111.0

🤞

@JakeChampion Is there something that I can do to release this onto the cdn ? 🤔 (It seems that is still the 3.110.1 in production)

I've started the process to release this to production now 👍


Cascade changes to virtual fields such as "in_use".

Coverage remained the same at 92.775% when pulling 1d2740c3967f67792c81ff2c9d3c2ea24e1db217 on RickCarlino:cascade_changes into 0cc6211fde26a84f1f20b128c99b9d524a79fa10 on FarmBot:staging.


Cast getitem indices to int (avoid passing numpy scalar types)

Codecov Report

Merging #190 (4d8f85a) into main (0060a1f) will not change coverage.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   94.49%   94.49%
=======================================
  Files          19       19
  Lines        2018     2018
=======================================
  Hits         1907     1907
  Misses        111      111

Impacted Files
Coverage Δ

src/dask_awkward/lib/core.py
90.53% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Twitter kit 3.2.0 invalid opcode ba

With the new version 3.2.0 of the SDK, when trying to run the app I got a build exception:
Error:com.android.builder.dexing.DexArchiveBuilderException: Failed to process C:\Users\Home.gradle\caches\transforms-1\files-1.1\twitter-core-3.2.0.aar\f96c52d742e7c2e0879b20510433354b\jars\classes.jar
Error:com.android.builder.dexing.DexArchiveBuilderException: Error while dexing com/twitter/sdk/android/core/internal/oauth/OAuthService.class
Error:com.android.dx.cf.code.SimException: invalid opcode ba (invokedynamic requires --min-sdk-version >= 26)
With the previous version (3.1.1) it is running fine.
I don't know if it is related to the new support of Java 8...

Same issue here, any help?

Same issue. Just uning 3.1.1 for now

Same issue for me as well

Same issue for me as well

If you haven't moved to Java 8 I would recommend sticking with v3.1.1


⚠ Bofrost.lu has degraded performance

In 42cdb4c, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1807 ms

Resolved: Bofrost.lu performance has improved in 8bd1e00 after 19 minutes.


More detailed SubmitTransactionResponse

SubmitTransactionResponse made more detailed based on Horizon API.
Struct conversion between stellar_base and stellar_sdk packages going to be useful when someone trying to use both crates together.
I've also bumped up the version number.
Can I ask for a cargo publish ? I would like to use this version in my library. And cargo not letting me to publish if I'm linking in from github. Thanks for the to do list now I can see what should have be do next :)
Update:
I tried to do almost all of the todo list functions but with every route I tries I hit a wall. I guess without changing the types the functions can't be done. I hope we can decide how to progress further, will re export or copy stellar_base types (unfortunatelly rarely maintained crate), or what would be the most optimal way.

Hi @palinko91 , thank you so much for putting the time to update this package, sorry for the delay, I will look into it and give you my thoughts. Thanks again for contributing.

I published the new version of the package.


Changing the system theme resets the Docusaurus theme to the default

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Prerequisites

[X] I'm using the latest version of Docusaurus.
[ ] I have tried the npm run clear or yarn clear command.
[ ] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[X] I have tried creating a repro with https://new.docusaurus.io.
[ ] I have read the console error message carefully (if applicable).

Description
When the system colour theme changes (the prefers-color-scheme media query changes, that is), a Docusaurus site with respectPrefersColorScheme off sets the theme back to the default, regardless of the system theme or the current site theme as set by the user.
Reproducible demo
https://codesandbox.io/p/sandbox/github/facebook/docusaurus/tree/main/examples/classic
Steps to reproduce
A fresh installation of Docusaurus should work, or the codesandbox.io link above.

Put the system in light mode (steps vary based on OS; in essence, make sure the media query prefers-color-scheme: light is true)
Click the theme change button to set the Docusaurus site to dark mode
Put the system into dark mode (prefers-color-scheme: dark is true)

Expected behavior
Given that respectPrefersColorScheme is off, I'd expect the theme not to change when the system colour scheme changes.
Actual behavior
The theme is reset to the default – light mode in the case of the repro link.
Your environment

Public source code: See the repro link above
Public site URL: In addition to the repro, I first discovered this issue when using docs.cypress.io
Docusaurus version used: 2.4.0
Environment name and version (e.g. Chrome 89, Node.js 16.4): Firefox 112.0.2
Operating system and version (e.g. Ubuntu 20.04.2 LTS): macOS 13.3.1

Self-service

[ ] I'd be willing to fix this bug myself.

From initial debugging - Irrespective of respectPrefersColorScheme value, every time the system theme is changed, the localstorage value is deleted and so default value(light theme) is set.
May I work on this ?

On further deep dive in the codebase, this proves to be a conscious and expected behavior.
It seems to have been agreed by the team that the OS triggered theme changes overrides the user choice - mentioned by @Josh-Cena
More on  https://github.com/facebook/docusaurus/pull/7200

The problem is that there exists a user action here (setting the mode to dark), so I'd expect it to persist. It's the exact opposite situation as in #7199 (where the button is disabled but respectPrefersColorScheme is on)

The problem is that there exists a user action here (setting the mode to dark), so I'd expect it to persist.
https://github.com/facebook/docusaurus/pull/7200#discussion_r855219429 - this thread here seemed to have agreed on with prioritizing the OS triggered color even when user action is setting to dark mode and also about persist option being unused.
What am I missing here ?

As per what I understand from code, whenever there is a system color mode is changed, window.matchMedia onchange is triggered and the setColorMode(null); resets to default mode which is light.

I think there's scope for improving the behaviour, even if it was intended. To me it doesn't make sense that changing the system theme at all should always put a site into light mode.

Mmm, I think the key is respectPrefersColorScheme is off here, so regardless we shouldn't do anything about system changes. I don't really know though—it's been a while since I've handled this and my memory is all a bit blurry.


Typo

Describe the erratum
X in eq. 11.3 should be calligraphic font?
Version and Location
Please provide:

8 December 2021
p. 250

Proposed correction
X in eq. 11.3

->

x \in X \cap \matcal{F} -> x \in \mathcal{X} \cap \mathcal{F}
Screenshots
If applicable, add screenshots to help explain the problem.

This is correct as written; we are looking for the best point observed (that is, in x) that is also feasible.


Customizing Buttons

In the InserToolbar file, there is this comment:
Note the flow of control. The button actions invoke theshowPluggable[Link/Image/Table]Toolbarmethod /// in theselectedWebView. These in turn invoke the MarkupDelegate's show[Link/Image/Table]Toolbarmethod.
I can't find any of those methods that you mention. Have those been changed to popover methods?

Yes, the comment is out of date with the code. s/Toolbar/Popover/


Ping on release to sync wait_timeout behind MaxSclae

Because Maxscale for example splits read and write queries to differemt cluster member, there are several connection from MaxScale to the DB server.
Each connections has its own timeout (wait_timeout) to be disconnected.
Example:

wait_timeout 50 seconds
1 write query
70 seconds read queries (write connection behind MaxScale never used, closed after 50s)
1 write query fail: "Conenction lost"

Better problem discriptin (wait_timeout is 10 seconds):

getCon
1 write (query 'insert')
1 long time read query (query 'select sleep(20)') tresults in timeouts: read=0, write>10 closed
... read (select) works
... write (insert) fails: 'Connection Lost'


Serialization attributes documentation bug

https://github.com/JamesNK/Newtonsoft.Json/blob/master/Doc/SerializationAttributes.aml#L52
I think
"Placing the JsonPropertyAttribute overrides this behavior"
should read
"Placing the JsonObjectAttribute overrides this behavior"

Good catch. Fixed


add rgb666 support

Thank you for helping out with embedded-graphics development! Please:

[x] Check that you've added passing tests and documentation
[x] Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, etc) if your changes affect the public API
[x] Run rustfmt on the project
[x] Run just build (Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.

PR description
Adds Rgb666 support.

@jamwaffles ping? Also question, does it make any sense to create something like RawU18 for this?

p.s. please rebase from master - the CI should start passing after #619 was merged.

p.s. please rebase from master - the CI should start passing after #619 was merged.

Seems there one more issue still in the CI for MSRV?

I'm also unclear how to handle ToBytesfor RawU18 since padding is necessary for any kind of endianness swap logic to work.
Right now I do LE MCU to BE display this way:
        let mut iter = colors.into_iter().flat_map(|c| {
            let s = c.into_storage(); // bit-packed 18bits
                                      // we need to un-pack and pad with 2 bits each into 3 bytes of 6bit info
            let red = ((s & 0x3F) as u8) << 2;
            let green = (((s >> 6) & 0x3F) as u8) << 2;
            let blue = (((s >> 12) & 0x3F) as u8) << 2;
            [red, green, blue]
        });

This should be good to go, the RawU18 representation is a bit funky tho when it comes to the endianness conversions, but then again it never really makes sense.

Could you please update the PR with a display that uses rgb666? Right now this looks like "yet another random color format". (I read your use case on matrix but IMO it would make sense to include it in the OP.)

Right now I do LE MCU to BE display this way:

Because Rgb666 implements RgbColor you should be able to call c.r(), c.g() and c.b() to clean that code up a bit, FWIW.

This is released in e-g-core 0.3.3. e-g itself should pick the changes up with a cargo update.


Cannot use custom midi

there is a processing error when I use my own 2k collection of MIDI. I tried changing the format from .mid to .midi, still give "�]q" as an output. MIDI dataset was generated from wave2midi2wave method from Magenta

I have met the same question, have someone solved it?


Preview/Avail comps with power must use perf/W

Nvidia's available Orin submission with power has better perf/W than the preview system, but the optimal efficiency is at a different power point. We don't want to have to make a less optimal power submission just to meet the preview criteria, and we think this is logical in principle, since power submissions are optimized for efficiency, not absolute performance.
(The non-power submission will also demonstrate that the system has better absolute perf than the corresponding preview submission.)

Inference WG has no objection to the proposed changes.


python3Packages.sievelib: 1.1.1 -> 1.2.1

Motivation for this change
Update to latest upstream release 1.2.1
Change log: https://github.com/tonioo/sievelib/releases/tag/1.2.1
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 145329 run on x86_64-linux 1

2 packages built:

python38Packages.sievelib
python39Packages.sievelib

Result of nixpkgs-review pr 145329 run on x86_64-linux 1

2 packages built:

python38Packages.sievelib
python39Packages.sievelib


Make wishlist updates persist

As a [role]
I need [functionality]
So that [benefit]
Details & Assumptions:

...

Acceptance Criteria:
Given [some initial state]
When [some event]
Then [some measurable outcome]

This is probably a big task, will probably need to separate it into several issues.

Hey team! Please add your planning poker estimate with ZenHub @Fivetoes @jiuliwei @XinyuC97 @yx2512 @ZX-WANG


Cannot run Greeter demo plugin

I followed the installation instructions. I have Fedora 28 and gcc 8.2.1. I installed TensorFlow (v.1.12) and Bazel. Below is the output of 'bazel run //greeter_tensorboard -- --logdir=/tmp/greeter_demo" command:
INFO: Analysed target //greeter_tensorboard:greeter_tensorboard (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
ERROR: /home//.cache/bazel/bazel/82fdb0e5296cafe943f036e454b1602b/external/com_google_protobuf/BUILD:70:1: C++ compilation of rule '@com_google_protobuf//:protobuf_lite' failed (Exit 1) gcc failed: error executing command /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -B/usr/bin -B/usr/bin -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG ... (remaining 43 argument(s) skipped)
Use --sandbox_debug to see verbose messages from the sandbox
gcc: error trying to exec 'cc1plus': execvp: No such file or directory
Target //greeter_tensorboard:greeter_tensorboard failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 0.339s, Critical Path: 0.07s, Remote (0.00% of the time): [queue: 0.00%, setup: 0.00%, process: 0.00%]
INFO: 0 processes.
 I am new to Fedora (I used Ubuntu before). It turned out, I had gcc preinstalled via Chef on my work machine but C++ compiler was not installed. So I ran:
dnf install gcc-c++
and everything worked after that.


missing step of "set contract"

It seems that the step of "cleos set contract yield ..." is missing in the readme.md, if I'm not mistaken. Between "newaccount" and "set account permission".

Thank you. Problem fixed in commit 8e840c9cbd2a6e4c08ab28e1f1ac15e3ed47f8ae.


Lysozyme example update

Submission Checklist

[ ] Have you installed and run this change against pre-commit? (pre-commit install)
[ ] Are all tests passing? (make tests)
[ ] Have you written unit tests to cover this change?
[ ] Is unit test coverage still above 80%?
[ ] Have you updated all applicable documentation?
[ ] Have you followed the guidelines in our Contributing document?

/gcbrun

/gcbrun

I have manually tested with these changes.


ci: speedup (#1)

Resolves #131.
This PR splits the one big CI job into 4 smaller ones (build, format, tests, coverage) so they can run in parallel. Furthermore, it uses the Swatinem/rust-cache action to cache rust artifacts. The whole CI now takes about 8 minutes.

Codecov Report

Merging #155 (3c5e5ca) into main (e060a34) will decrease coverage by 0.48%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
- Coverage   70.34%   69.86%   -0.48%
==========================================
  Files          35       35
  Lines        1905     1918      +13
==========================================
  Hits         1340     1340
- Misses        565      578      +13

Impacted Files
Coverage Δ

...ic/transaction/objects/internal_invoke_function.rs
55.55% <0.00%> (-9.26%)
:arrow_down:

...rc/core/syscalls/business_logic_syscall_handler.rs
50.69% <0.00%> (-0.94%)
:arrow_down:

.../business_logic/execution/execution_entry_point.rs
79.46% <0.00%> (-0.54%)
:arrow_down:

src/core/syscalls/syscall_handler.rs
78.88% <0.00%> (-0.39%)
:arrow_down:

src/business_logic/transaction/state_objects.rs
0.00% <0.00%> (ø)

src/business_logic/state/contract_storage_state.rs
92.85% <0.00%> (ø)

src/starknet_runner/runner.rs
70.96% <0.00%> (+0.96%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Go to definition via file link is broken if working directory is not the file directory

Given two Markdown files in the same directory, marksman 1.0.0-dbad138, and helix 22.12 (a4de86e7)
~/Documents/NOTES.md
# Notes

This is a bunch of notes

~/Documents/PEOPLE.md
# People

This is a bunch of people that are referenced in [[Notes]]

If your working directory is ~/Documents, the file link works as expected
If your working directory is ~, the file link does not work as expected

Thanks for raising this @lukepighetti! I think what you're seeing is this https://github.com/artempyanykh/marksman/pull/110
TL;DR: helix used to report bogus workspace folders which caused large file tree scans, which is not cool. The fix makes workspace detection a bit more conservative, but this is better than the previous behavior.
Does your ~/Documents folder has a .marksman.toml or is under version control?

There is no .marksman.toml file and it's not under version control

@lukepighetti does adding a .marksman.toml file help?

Yes

Ok, glad to hear that!


Change License to MIT?

Would it be possible to change the license for external (non-Federal Employee) contributions to an MIT (or other open source license)?
I've recently encountered an issue where @LLNL isn't able to allow me to contribute as part of my work due to the CC0 provisions around "waiving copyright", which it can't / won't do.
MIT is the license used in, at least, https://github.com/deptofdefense/anet which the lab is more amenable to contributing to.

Any thoughts about this idea?

Alternate suggestion from internal, would I be able to contribute code that was itself covered by an MIT license? Perhaps with some sort of addendum in the license like: "Contributions from @IanLee1521 aka<EMAIL_ADDRESS>are contributed under an MIT license" ?

It's possible to dual-license projects or to use mixed-license code. I think the issue is really more that that defeats (some of) the purpose of using CC0 for the project, which is to give downstream users a completely and unambiguously clear copyright and attribution situation. Even one exception means that, suddenly, downstream users are technically obligated to maintain attribution for that exception, and to factor in that a bit of the code is copyrighted in any further legal or operational decisions they make. There is a practical value to having the code be 100.0% CC0-dedicated.
I also promise we're not ignoring your plight. My suggestion is that we take this up with @AlvandSalehi this week.

Understood. It also doesn't do anything for any of the other USG CC0 projects out there either, and it would be pretty unlikely in my mind that all would be willing (or able) to dual-license.

Since I've currently found a path to contributing through DOE / LLNL, I'm going to go ahead and close this as no longer needed.


cell types needed for Models migration

The following cell types are needed for the Model migration that are not in the KG.
The names don't have to match these exactly, I can do a mapping if there is an entry in Interlex/Scicrunch for the same cell type but with a slightly different name.

Golgi cell
L2/3 pyramidal cell
L5 tufted pyramidal cell
cerebellar granule cell
cholinergic interneuron
fast spiking interneuron
hippocampus CA1 pyramidal cell
medium spiny neuron
medium spiny neuron (D1 type)
medium spiny neuron (D2 type)

Thanks for the request, @apdavison. For cell types, we struggle a little bit with finding the correct ontology IDs because they tend to be more specific than what is colloquially used. Could you please have a look at the list below and see if this will cover want you need.

requested cell type
existing controlled term
suggested name
InterLex
comment

Golgi cell

cerebellum Golgi cell
http://uri.interlex.org/base/ilx_0101966

L2/3 pyramidal cell

neocortex layer 2/3 pyramidal neuron
http://uri.interlex.org/base/ilx_0107387

L5 tufted pyramidal cell

neocortex layer 5 tufted pyramidal neuron
http://uri.interlex.org/ilx_0738209

cerebellar granule cell

cerebellum granule neuron
http://uri.interlex.org/ilx_0101967

cholinergic interneuron

neostriatum cholinergic interneuron
http://uri.interlex.org/ilx_0107403
will this cover all your use cases?

fast spiking interneuron

can't find this in InterLex; I know that most of them are PV+ (GABAergic) interneurons, but not all, right? If not, we should add this term

hippocampus CA1 pyramidal cell

hippocampus CA1 pyramidal neuron
http://uri.interlex.org/base/ilx_0105031

medium spiny neuron

striatum medium spiny neuron
http://uri.interlex.org/ilx_0784362
will this cover all your use cases?

medium spiny neuron (D1 type)
neostriatum direct pathway spiny neuron

http://uri.interlex.org/ilx_0107404
we had a similar request here: #94; will this cover all your use cases?

medium spiny neuron (D2 type)
neostriatum indirect pathway spiny neuron

http://uri.interlex.org/ilx_0107405
we had a similar request here: #94; will this cover all your use cases?

@tgbugs and @lzehl, happy to get your thoughts on this too.

Many thanks @UlrikeS91. I think all of your proposals are good.
"neostriatum cholinergic interneuron" is probably ok for the Models we have, but it would be good to add the more general term as well, as I believe cholinergic interneurons are also found in the cerebral cortex, hippocampus, and nucleus accumbens, as well as the striatum.
"fast spiking interneuron" is a widely used term, so I agree we should add it. It seems all such neurons are parvalbumin-positive, but not all parvalbumin-positive interneurons are fast-spiking (e.g. https://www.ncbi.nlm.nih.gov/pmc/articles/PMC3602937/)


Speech Access Token not Refreshing

In SpeechManager.cs, you're getting the initial access token from the server and using that for the runtime of the application. Even though the Authentication class is re-authenticating in the background, the new access token is never being used in SpeechManager.cs (only the first token recieved).

Hi there, this project only received limited testing so it's very likely that the code has some errors like this given that long running tests are more involved. The other reason is that I quickly moved away from this project since I worked with our internal Cognitive Services team to make sure that Unity would be supported.
Instead of using my code, I would invite you to look at the C# .NET SDK in Cognitive Services Speech since it includes compatible plugins and it's officially supported. I hope this helps.
SDK: https://docs.microsoft.com/en-us/azure/cognitive-services/speech-service/speech-sdk
Unity Quickstart: https://github.com/Azure-Samples/cognitive-services-speech-sdk/tree/master/quickstart/csharp/unity/from-microphone


1.16.5 game crash

Not sure if there is an incompatibility with another mod, or if the mod itself is broken. Crashes when spawning into the world, works fine when Dungeons gear mod is removed.
Dungeons gear version 1.16.5-1.8.2 and dungeons libraries mod version 1.16.5-1.0.6
Tested with Forge loader v36.2.39 and v36.2.41
Console crash log
https://paste.atlauncher.com/view/f7437ddf-716e-4e55-8cff-8da54342546d

1.16.5 is no longer supported.


Translate button size is not matching with other tabs on courses page.

Description
Translate button is over size with respect to other tabs on courses page.
Steps to Reproduce
Open website.
Click on courses tab.
See the size of tabs in nav bar.
Expected Behavior
All the tabs should have same size.
Actual Behavior
No response
Screenshots

Additional Information
No response
What browser are you seeing the problem on?

[ ] Firefox
[X] Chrome
[ ] Safari
[ ] Microsoft Edge

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

for now we don't require this and we will look for this later.
and this is the final warning
don't create multiple issues one by one.


A question about normalize_compute_shape

what is the meaning of normalize_compute_shape? what is the difference between compute_shape and not normalize_compute_shape?

normalize_compute_shape is used when operators have inputs or attributes that would otherwise go out of bounds (usually negative, meaning iterate backwards in onnx). You can see an example in the slice operator.

normalize_compute_shape is used when operators have inputs or attributes that would otherwise go out of bounds (usually negative, meaning iterate backwards in onnx). You can see an example in the slice operator.


Approach for extension test

The idea behind the refactoring #323 was to separate internal tests from extension tests. We have at the moment not so many tests. This makes it easy to refactor. Sorry that I did not wrote my idea done for discussion and started immediatly.
Test definitions
The internal tests are tests which use only parts of the extension (like only the kitmanager or the kit scan part). This test are only unit tests for components. This componets may can interact with filesystem, cmake, or other parts.
The extension test are tests in the user view. I would like to use them to check if the complete extension is working correct. All components work correct together. The first one which I have written are more trivial ones no-kits-present.test.ts.
Extension test
My focus is at the moment on the extension tests. I hope we get soon the open pull requests merged.
Test management
I like the approach with CTest in the smoke branch to manage the different test environments.
The batch files make it hard to see which test environment failed.
Test framework technologies
I would avoid to use a new test description language (the yaml-files). The idea of my refactoring was needed to make it possible for testing #290. In this case I need to stub some vscode function.
Its is very easy with the typescript test frameworks (mocha, chi and sinon).
You can see it in the  Kits test ->GUI tests
Structure of tests
The structure in the smoke branch follows the same idea like my refactored extenstion_tests subfolders.
The folder is always structured in:

extension_tests

<name_group_of_tests>

project_folder
test

The project_folder contains a valid or broken CMake project with source files.
The test folder contains the related tests.
Test result verification
I like to use the extension like the users. In this case I need run function of the extension by the test script. The test expectation can be checked against

a executeable which provides a output
cmake generated cache files or message
outputs provided by the extension itself (vscode messages/warning)

I hop you like the plan und hop to get some feedback.
@Randshot I would like to test, the commands you added first by an extension test. The tests on CMakeDriver level would mean we need to write the test twice, because CMake 3.5 and CMake 3.7 work different in the extension.

@KoeMai What do you mean by commands? Which PRs of mine are you talking about?

Sorry, I was wrong you have added settings. The settings are used by the commands. The testing of the settings should work as well.

I pushed my first draft for configure and build test to  feature/add_build_tests (only the build test is active).

The reason I went with the yaml files was to abstract away a lot of the boilerplate with writing the test setup/teardown, making it trivial to add more tests.
@Randshot, what do you think?

TBH, I don't have any idea what yaml files you are talking about :/
My priorities for testing would be easy integration and (modular) extensibility.

We're referring to the test stuff I threw together on the feature/smoke branch.

I will look at it a bit closer after dinner.

@KoeMai What is you reasoning for not using yaml files?
I like the idea of reducing boilerplate as much as possible.

I would like to reduce the complexity of the tests too. In the same way I do not want to loose the flexibility of a testing framework.
I try to find test method's for

manipulate environment variables
forward environment variable to cmake
settings from settings.json
catch error notification like in the ninja bug.
I do not know how I can check them without individual test helpers.

Both ways have their benefits. I like the test scenario views of yaml but I see the same possibilies in a test framework. In both ways I can write helpers. In the one way I have to write them to have access in the scenario and in the other one only if I see the reuseability or to make it more readable.

I guess it's a matter of just eliminating duplication. I chose YAML so that the only thing in those test directories were the steps to run the test (no setup/teardown). I abstracted the setup/teardown into a test runner class you can see in the smoke directory.
Have you looked at writing a test runner class? You might get away with putting all the setup/teardown logic and your helper methods in the single class and keep the individual test directories down in size to just concerning themselves with running the exact test for their own directory.

@KoeMai I have taken a look at your add_build_tests branch and you left a comment asking how to get the path to the executable or the output of the executable.
I don't know the best approach for this, but one that came to my mind is by using custom targets to run the executable. The executable itself would have to write it's output to some file, or we somehow catch the output when CMake runs the custom target.

@KoeMai I have a working CMakeLists.txt file here:
cmake_minimum_required(VERSION 3.0.0)
project(TestBuildProcess VERSION 0.1.0)

add_executable(TestBuildProcess main.cpp)

add_custom_command(
    TARGET TestBuildProcess
    POST_BUILD
    COMMAND $<TARGET_FILE:TestBuildProcess> > output.txt
    WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
    COMMENT "Running in ${CMAKE_CURRENT_BINARY_DIR}"
)

add_definitions(-D_CMAKE_VERSION="${CMAKE_MAJOR_VERSION}.${CMAKE_MINOR_VERSION}")

The output.txt file will be in the build directory.

@vector-of-bool @KoeMai I have a working example for getting the output of a built project executable.
You can find it in the feature/get_output_example branch.

Yes I saw it. What do you think about one of this approachs?

https://www.npmjs.com/package/mocha-shared
https://www.npmjs.com/package/mocha-bdd-extend
Both combines our ideas and keep the tests lean and flexible.

I did some refactoring without the packages from above.
@Randshot I merged your branch into feature/add_build_tests

@KoeMai If I remember right, I pushed some changes to my branch that fixes the appveyor problems.
I didn't manage to fix the travis problems though.

@KoeMai, mocha-shared and mocha-bdd-extend look like what I was hoping for. Nice.
Also, it looks like you're having trouble with driver startup on your branch. My tslint branch did some cleanup of driver startup that might affect what you are doing. The driver startup needs a bit of refinement, as it's very easy to accidentally have driver startup depend on itself.

@KoeMai It seems like appveyor doesn't select a kit and travis just skips both tests.

@KoeMai I think I have fixed the issues with appveyor.
You can find the fix in the appveyor_init_debug branch.
The only problem is, that the test checks for CMake version 3.9, which doesn't always fit the CMake version appveyor uses.

doesn't always

Meaning the CMake version differs between AppVeyor machines? :fearful:
Kit scanning for VS prior to 2017 seems a bit more flakey than I'd like.

Oh you are right, thanks for your help.
At the moment I see this tests as a draft. So it works only on a subset for cmake and compilers + build system.
@vector-of-bool did you took a look at the tests? At the moment I use non of the tool packages,  but I think the style is very clear. Should we try to convert it more in to shared blocks?

I've looked it over a bit. It looks alright, and will be better once we get some of the boilerplate down.
I'd like to say that cmake.stop should not stop the driver process, as I feel it will be a nightmare to debug in the future. I'd go the route of having CTest just start a new VSCode instance for each of the main tests, just to be sure we have a completely clean state, which just stopping the driver won't actually achieve.

Now I have a working draft and travis and appveyor (most parts) are happy.
Next steps:

[ ] Task 1: Extract helper classes from test file into separate helper files.
[ ] Task 2: Make all test available for Linux/MacOs and Windows (see Q1, Q2)
[ ] Task 3: Repair and make pending events available on all plattforms.

For the next steps we need to define some environment settings for travis and appveyor

[ ] Q1. What are our default compilers? CLang? Linux and MacOS.
[ ] Q2. What is our default build system? Linux MacOS and Windows (The older VS versions fail because no build system is prevered)
Q3. Do we want to use this code base or do we want to refactor it to a other style or do we want to use the smoke branch?

I would create a pull request out of the feature/add_build_tests branch if task 1 is finished.

For Q1, I'd like to expand the test matrix as wide as possible. That means running Travis tests against both GCC and Clang for both Linux and macOS. May even multiple versions of each compiler.
For Q2, I'm not sure what you mean? You mean the CMake Generator? Again, I'd like to have a matrix for each backend that the extension supports.
For Q3, I don't feel strongly that my feature/smoke branch be used. If we can get what we need from Mocha, I'll be happy to use that. I'd like to start off a fresh new VSCode instance for each of the big smoke tests, though, just to make sure everything is clean when we start. I was using CTest for this, but it can be anything that can just launch a bunch of processes.
@ytimenkov was doing work in his own fork to make the backend system much more modular and testable. It may be worth looking to adopting aspects of his approach in the future.

I've updated #190 with what I was thinking about and what I've managed to do.
If you like the idea I think it should be possible to drag in my changes firstly putting them under existing functionality (e.g. implement CMakeServerClientDriver in terms of new components), and then gradually remove these wrappers.

Another thought about build matrix and a set of compilers:
After VS code implemented support for task discovery I thought that it might be good if this mechanism was (re)used for building with CMake.
Cons:

No ability to show progress bar during the build, but user will see nice colored output in the terminal.
Hooks? But their absence can be mitigated by watching files for changes.

Pros:

Ability to control and customize build process, including error parsers.
Specify as pre-launch task in debugger.
Similar template can be replicated for multiple tasks and/or more complex scenarios.

This way most interesting cases are:

Makefiles/Ninja on Linux mac with gcc/clang.
Multi-configuration generators like Visual Studio.
Weird generator+compiler combination like ninja + Visual Studio.

What I think is of interest is different versions of CMake itself and VSCode. Something like < 3.7.2, latest released, latest nightly + similar for Code - latest released, latest insiders. However I'm not sure if backward compatibility is needed for VS Code (e.g. pre-multiroot).

I would like to build different levels of testing. At the moment I focus on the testing of the possible user interaction. I think on this level of tests we do not need to test many compilers and cmake versions, the should only check essential cases or issues from the users. The other test I would do it like @ytimenkov  says, more inside the extension by unit testing and integration test. The help us more on development.

I'm open to getting a good baseline as the first step. We can expand the test matrix at a later time.
@ytimenkov, I've looked into using the task-runner as a way to execute the CMake builds, with mixed findings. Last time I looked, it didn't support what I was hoping for. It may be better now (I looked several months ago).
I'd like to switch to the task-runner if possible, if only for using the integrated terminal for nicer output. Here's a wild possibility:

Wrap the CMake build with a script that communicates back to the extension? I'm hesitant to use regex to do error matching since each compiler does something wildly different and sometimes errors are split over multiple lines.

Weird generator+compiler combination like ninja + Visual Studio.

Actually, the reason I've struggled with Visual Studio generators is that I exclusively use the Ninja generator with MSVC :D
As for bringing in your changes: I'd like to phase out the current backend/two-phase init process. I just want to get our testing in order. If it would be simpler to pull in your changes while we add the tests, I'm good with that.

Ok, out of the discussion, I think we should create a new dashboard project with cards for the tasks of this issue (testing issues). This allows that different person could work on it.
I most tests could be done by mocha based test inside of one vscode instance. By reloading the cmaketools class. With this approach we could test the different cmake versions and compiler version. This approach does not support to test the binding of commands, because there is a reload of the extension needed.
For vscode version tests we need for each version a new test runner. For setting them up we could the smoke branch ctest part or by extension of the run_extensions_test.bat. But I see this more on the long term.

[ ] In add_build_test branch I would add additional an example how change settings inside a test. I think it will the cmake install path switch.

I think the main part of this issue is done, could we close it?

I say yes


chore: Update v2 to main

Using a separate branch to resolve the merge conflicts, but other than that this is a straightforward update of the v2 branch up to the latest main branch.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.60%. Comparing base (b15b566) to head (0cc32c7).
Report is 1 commits behind head on v2.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #1374      +/-   ##
==========================================
- Coverage   68.66%   68.60%   -0.06%
==========================================
  Files         188      188
  Lines       18075    18029      -46
==========================================
- Hits        12411    12369      -42
+ Misses       4979     4978       -1
+ Partials      685      682       -3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


CIV-5561 Hide service request tab for judge

Before creating a pull request make sure that:

[x] commit messages are meaningful and follow good commit message guidelines
[x] README and other documentation has been updated / added (if needed)
[x] tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-5561
Change description
Hide service request tab for judge user role
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No


Documentation: working with record links

Description
I'm not sure if this is an issue shared across all SurrealDB SDKs right now due to how the underlying RPC works, but I'm currently trying to create new records using db.Create and passing an array of model IDs as strings inside my interface. However, it doesn't appear that these relations are getting saved in the database, despite the other fields in my interface being stored. My table is schemafull and configured to have the specific column be of type set<record>.
Is working with relations not currently supported, or is just currently missing from the docs? If you should be able to create relations via string arrays, happy to open a bug report instead.
Is there an existing issue for this?

[X] I have searched the existing issues

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Golang SDK does not support bulk creation such as array but it is planned to have.

Hey @ElecTwix! Thanks for the quick response – to clarify, I'm not trying to create records in bulk, just store an array of record links as a column on one of my tables. My example repo is a bit complex ATM, and I'd need to carve out time to create an MVP.
That said, the general steps I'd follow to reproduce are:

Using either SurrealQL or a GUI like Surrealist (what I used), create a schemafull table (e.g. "table1") that has a column of type set<record>
Create another table (e.g. "table2") that stores some data for the new column to reference
Using the SDK, attempt to create a new table row that references the test table:

db.Create("table1", map[string]interface{}{
  "links": []string{"table2:1234"}
}

This is effectively the approach I'm trying, except the query passes but links would still be [] in the database.

Hey @ElecTwix,
Sorry for the delay – just got around to looking at this. I did a bit more digging and it looks like it's a bug with SurrealDB and schemafull tables. If I make my table schemaless it works as expected, despite the record links being stored as an array of strings. I can still use the dot notation to reference nested fields when selecting like you can with record links. Going to close this, as I'm tracking it on the main repo now. Thanks for all the help!


Will this benchmark support guided anchor?

❓ Questions and Help
@fmassa  will this benchmark support guided anchor in the future?

There are currently no plans to support Guided Anchor in maskrcnn_benchmark, but contributions are welcome!

Thanks! @fmassa @zimenglan-sysu-512
Shall I close this issue or keep it ?


Use @Publish on classes annotated also with @Transactional

Right now ServiceRegisterPostProcessor cannot find @Publish annotation on a class because it is already a proxy – a wrapper providing transactions.

Resolved as of version 1.2.3


RayChew

Hi, I hope I am doing this correctly! (: And I've updated my solution to store and work on data internally, and for it to work for all similar data files. Thank you for pointing these out!

Looks fine, but a bit too much code replication. E.g. you might have used an vector<> vec[2] and set vec[loc].push_back(value) if loc == 1 or loc == 2


default for no defined style

If no style is defined we get the warning message
Package citation-style-language Warning: Style name not specified.

which is okay. But it is more user-friendly if it could use a default style, apa or whatever:
    Package citation-style-language Warning: Style name not specified.
    Will use default style apa ...

The problem is that the warning will be an error when running citeproc-lua
[...]
Database file #1: biblatex-examples.bib
.../scripts/citation-style-language/citeproc-latex-core.lua:218: attempt to concatenate a nil value (local 'style_name')
[...]

If no style is defined we get the warning message
Package citation-style-language Warning: Style name not specified.

which is okay. But it is more user-friendly if it could use a default style, apa or whatever:
    Package citation-style-language Warning: Style name not specified.
    Will use default style apa ...

Thanks for your feedback and it makes sense.

The problem is that the warning will be an error when running citeproc-lua
[...]
Database file #1: biblatex-examples.bib
.../scripts/citation-style-language/citeproc-latex-core.lua:218: attempt to concatenate a nil value (local 'style_name')
[...]

Fixed in 7db1514.


Investigate GPU Offloading

Although algorithm (static) class templates should not care about where computation is performed (CPU or GPU), I think there are a few design choices that motivate parameterizing the algorithm itself instead of the matrix class. However, there are still reasons for parameterizing the matrix class, one of which is because polymorphic data containers (kokkos for example) do the same thing, and such data types should be able to plug into distributed-memory algorithms without any pain.
Think about the pros and cons here.
Three policy classes for offloading (just gemm for now) include:

NoOffload (default)
OffloadKeepDataResident (keep data on GPU as much as possible. Any communication of data on GPU is not a problem, but remember that it still must pass through PCI bus, exploit pinned memory via buffer allocated at the beginning of the program that is used repeatedly).
OffloadTranserData (make not attempt to keep data resident on GPUs. Offload for each gemm invocation. Mainly a sanity-check policy class)

Don't forget to Incorporate into validate class templates as well.
Modify all test.cpp files to initially allocate memory on device.
Modify all Makefiles to use nvcc compiler and corresponding flags. Note that anything compiled with nvcc must be separate from anything compiled with MPI
Update blas directory to allow cuBlas headers.
Update bench/ files to include Offload policy class
Replace any syrk or trmm calls with gemm? Will that interfere with algorithm-specific policies (via non-orthogonal policy classes)?

GPU offloading and algorithm parameterization should be kept separate. GPU Offloading should work with either of CuBLAS's trmm, syrk, or gemm routines, and policy classes parameterizing an algorithm should neither know nor care if the computation is being offloaded. Of course, the user will be aware and thus choose his parametrization carefully.

GPU offloading and algorithm parameterization should be kept separate. GPU Offloading should work with either of CuBLAS's trmm, syrk, or gemm routines, and policy classes parameterizing an algorithm should neither know nor care if the computation is being offloaded. Of course, the user will be aware and thus choose his parametrization carefully.

This idea is good. I think we can get away with the entire library, besides the blas and lapack directories, not knowing about GPU offloading. I don't think the matrix class needs to know anything about GPU offloading. If we make the user specify this somewhere else, then all that really needs to be changed is which CuBLAS routine is called at the very bottom layer.
Remember that we want to keep data resident on the GPU as much as possible. Is there anything wrong with our current code in that regard? I think we could do this without having to parameterize anything on being GPU resident or not (might be needed for testing, but not later for production).

No, the matrix class template does definitely need to be parameterized as discussed way above. However, that does not mean that the class that uses the Cuda-specific methods can't be compiled separately using nvcc. That shouldn't be an issue. The default should be no-offloading.

Places where offloading could be tricky:

[ ]   serialize
[ ]   Does the Offload type parameter of matrix class template force non-orthogonal policies? For example, I'm concerned that Offload will be related to the methods in Structure class, as it includes things like copy and allocate methods. I don't want to parameterize these structure classes because that also will force many changes to serialize.
[ ]   distribute
[ ]   Should the lapack routines force a transfer from device to host? I don't think so. Even though they might not be faster, I don't want to incur that overhead
[ ]    blas::engine
[ ]    lapack::engine
[ ]    Pre-compiling blas::engine and lapack::engine calls, is this necessary? We should be calling binaries anyways.
[ ]    util::residual_local
[ ]    ``
[ ]    ``
[ ]    ``
[ ]    ``


[low priority feature request] It would be fine to open two or more configs in separate windows

Well,
subject say almost all ;-)

Please select the first icon on the toolbar "New Window".


Allow the activity text color to be set separately from the activity indicator color

For example, I would like to have a orange activity indicator that displays well on white background, but use a black text since orange text is not as readable on that white background. Right now, the text color is always the same color as the activity indicator.
This change allows the text color to be set separately when using the presenter ActivityData. For backwards compatibility, if color has been set but textColor has not, color will continue to be used for the text color. I default textColor does exist, but will only be used if neither color nor textColor are set (and the default is white, same as the old color default).

@ninjaprox Should I worry about these CI warnings? The code I added all follows the style of the existing files I believe.

@barnaclejive: No worries, I'm running it as experiment so we can ignore them for now. Thanks for your  PR btw. 👍


chore: recompile Cairo1 feature contracts with current compiler tag

This change is

Codecov Report
Attention: Patch coverage is 30.00000% with 70 lines in your changes are missing coverage. Please review.

Project coverage is 76.55%. Comparing base (938d287) to head (05b3ac1).
Report is 10 commits behind head on dori/verify-cairo0-compiler-deps.

Files
Patch %
Lines

crates/blockifier/src/test_utils/cairo_compile.rs
0.00%
46 Missing :warning:

crates/blockifier/src/test_utils/contracts.rs
55.55%
24 Missing :warning:

Additional details and impacted files
@@                         Coverage Diff                          @@
##           dori/verify-cairo0-compiler-deps    #1878      +/-   ##
====================================================================
- Coverage                             77.09%   76.55%   -0.54%
====================================================================
  Files                                    60       61       +1
  Lines                                  8657     8752      +95
  Branches                               8657     8752      +95
====================================================================
+ Hits                                   6674     6700      +26
- Misses                                 1541     1610      +69
  Partials                                442      442

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add page on staged releases

https://github.com/resin-io-playground/staged-releases

Closed by #1242


[ark] create service

What this PR does / why we need it: it create an ark service, it could be used to collect prometheus metrics
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ X] DCO signed
[ X] Chart Version bumped
[X ] Variables are documented in the README.md

/assign @sameersbn

@gianrubio perharps using "metrics.enabled: true" is a better option? I see a lot of chart that are using that kind of convention.

/assign @davidkarlsen

@davidkarlsen please review it


fix: add hostname to URLs generated in email

Since this email is triggered during upload, the resulting domain sent
to users is broken, as it's using uploads.pypi.org which this domain
doesn't support.
Signed-off-by: Mike Fiedler<EMAIL_ADDRESS>

Keep in mind: We're in code freeze for now, so unless this is urgent, we may not merge it until we're out of code freeze.


Update release workflow to add OTA image.

Updates the release workflow to copy the OTA image file to release assets.

It's actually the lfs.img not the filesystem image that we need for OTA.
The OTA updater for the ESP8266 can only replace the LFS. This is pretty convenient actually for updating the application code. I think I can make that change quickly.

Lol oops, not sure what I was thinking... thanks for fixing!


Some imported OCW sites get invalid short_id values

Steps to Reproduce
Run manage.py import_ocw_course_sites --bucket  ocw-to-hugo-output-qa --filter 18-443-statistics-for-applications --create_backend to import the following sites:
18-443-statistics-for-applications-fall-2003
18-443-statistics-for-applications-fall-2006
18-443-statistics-for-applications-spring-2015
Expected Behavior
The sites are imported along and github repos created
Actual Behavior
The github repos are not created, because the short_id values have parentheses:
18.650-(formerly-18.443)-spring-2015

Why are we favoring the old course number instead of the current one?
18-443-statistics-for-applications-spring-2015

Actual Behavior
The github repos are not created, because the short_id values have parentheses:
18.650-(formerly-18.443)-spring-2015

The short_id is derived from the json's primary_course_number field, which in this case is: 18.650 (formerly 18.443)
The url/name 18-443-statistics-for-applications-spring-2015 is coming from json file's S3 filepath.
https://ocw-studio-rc.odl.mit.edu/admin/websites/website/6c859e25-7833-441d-a47c-8572e4e7cc14/change/


Install via npm option?

Any plans to add option to install this package purely via npm and not bower?

Hey @hisham I am very sorry for the delay. Currently I don't have much available time to work in this module.
I'll try tu publish it in the npm registry as soon as possible.
Out of curiosity, how would you be managing this module with NPM?

There's someone who actually already forked this and already made this npm compatible - see https://github.com/rxfork/ngOrderObjectBy/tree/npm. So perhaps all that needs to be done is merge that fork.

I published it on npm.


AlpineJS x-transition directive

The plugin replaces, within the project, the x-transition attribute with x-transition="true".
The correct syntax accepts only "x-transition", without the value true.
Reference to AlpineJS documentation:
https://alpinejs.dev/directives/transition.
I recommend removing this directive.

Thanks for raising this issue @Blabbone. I just released v1.1.1, and fixed an issue related to this behaviour.
A value is always needed for now within the control to be able to use the clear-icon. I will add this info to the docs. The true is displayed only within the control. But in the actual attribute, the true is not added. Any other value will be in sync.
Let me know if v1.1.1 works for. you. Cheers!

Just released v1.2.0 that fixes this issue fully - https://github.com/TechAkayy/frameworks-lite-for-pinegrow/releases/tag/v1.2.0

Directives input box now includes both a clear icon and a delete icon. Previously, truthy directives were displayed as true in the control, but not anymore. It will always be in sync with the actual attribute key-value pairs. This also fixes https://github.com/TechAkayy/frameworks-lite-for-pinegrow/issues/2.

Please re-open if you still face any issues.


Support turbo.jsonc (or turbo.json5)

Which project is this feature idea for?
Turborepo
Describe the feature you'd like to request
Turbo uses a jsonc parser (https://github.com/vercel/turbo/pull/1472) to support comments in the config file, but IDEs/editors might warn about comments not being allowed in JSON. Changing the extension will tell them that an alternative JSON syntax is being used.
Describe the solution you'd like
If there is no turbo.json file, turbo will look for a turbo.jsonc file and use that.
Describe alternatives you've considered
Changing IDE settings, removing comments or living with the warnings are all acceptable workarounds, but it would be nice to have this feature.

We don't support the file being called turbo.jsonc, but we do parse the file as jsonc. So you should be able t add comments and things will work.

@cjpearson understood. We're tracking that over in https://github.com/vercel/turbo/issues/3793!