using my local codellama 34 intruct get Open API Key Errror

fresh install of h2oGPT. Using local LLM. Loaded 7 pdfs in MyDocs Collection 4608 chunks. Tried several prompt types. Same error.
error 1 validation error for OpenAI __root__ Did not find openai_api_key, please add an environment variable OPENAI_API_KEYwhich contains it, or passopenai_api_key as a named parameter. (type=value_error)
I m not using openai. this is a local LLM. I ran the Nov version of the installer with no issues.

Hi, do you have a more complete stack trace, so I can see the origin?
If you are using latest windows installer, I'm not sure what would cause this.  When testing it I had no issues.

I tried various things to repro, like unset the key myself or add os.environ.pop('OPENAI_API_KEY', None) early in the python code, but nothing fails for me with GGUF model.

I also tried inference_server as vLLM with that env popped out, and still no issue for document QA or direct LLM.

Not sure why but it is no longer producing the error. I clicked on a model in the list and once finally downloaded it ran without issue. then I used one of my local models i downloaded again after the folder mishap and it loaded without error. I then downloaded another one and tried that after a reboot and it worked also without error.
I assume that the api key error may only happen at first install if one has not used a model on the list first or maybe it only happens on a clean install.
There are a few warnings and issues listed in the terminal but they do not prevent it from running.
issues.txt

Ok if you see again, please run the full debug mode to get stack trace to see where it was coming from.  I'll close for now.

@pseudotensor I think I've replicated it acciedentally: [https://logpaste.com/rbrxhMtH](full stack).

evaluate_nochat exception: 1 validation error for OpenAI
__root__
  Did not find openai_api_key, please add an environment variable `OPENAI_API_KEY` which contains it, or pass `openai_api_key` as a named parameter. (type=value_error): ('', '', '', True, 'p
lain', "{   'PreInput': None,\n    'PreInstruct': None,\n    'PreResponse': None,\n    'botstr': None,\n    'can_handle_system_prompt': False,\n    'chat_sep': '',\n    'chat_turn_sep': '',\
n    'generates_leading_space': False,\n    'humanstr': None,\n    'promptA': None,\n    'promptB': None,\n    'system_prompt': '',\n    'terminate_response': []}", 0.1, 0.75, 40, 0, 1, 1024
, 0, False, 600, 1.07, 1, False, True, '', '', 'UserData', True, 'Query', ['Collection'], 10, True, 512, 'Relevant', ['All'], [], [], [], [], 'Pay attention and remember the information belo
w, which will help to answer the question or imperative after the context ends.', 'According to only the information in the document sources provided within the context above, write an insig
htful and well-structured response to: ', 'In order to write a concise single-paragraph or bulleted list summary, pay attention to the following text.', 'Using only the information in the do
cument sources above, write a condensed and concise summary of key results (preferably as bullet points).', 'Answer this question with vibrant details in order for some NLP embedding model t
o use that answer as better query than original question: ', 'You are an expert document question-answer language model named GPT-4 Turbo created by OpenAI.  You will get a tip of $200 when
you answer correctly the questions and only use the document context given.  I may lose my job if your answers are inaccurate or do a poor job of using the documents in the context.', ['DocT
R', 'Caption', 'ASR'], ['PyPDF'], ['Unstructured'], '.[]', 10, 'auto', [], '', False, '[]', '[]', 'reverse_ucurve_sort', 512, -1.0, -1.0, 'split_or_merge', '\n\n', 0, 'auto', False, False, '
None', 'None', [], 1.0, {'model': 'model', 'tokenizer': 'tokenizer', 'device': 'cuda', 'base_model': '/media/mike/Elements/LLModels/models/models--TheBloke--Nous-Hermes-13B-GPTQ', 'tokenizer
_base_model': '', 'lora_weights': '[None/Remove]', 'inference_server': '[None/Remove]', 'prompt_type': 'plain', 'prompt_dict': {'promptA': None, 'promptB': None, 'PreInstruct': None, 'PreInp
ut': None, 'PreResponse': None, 'terminate_response': [], 'chat_sep': '', 'chat_turn_sep': '', 'humanstr': None, 'botstr': None, 'generates_leading_space': False, 'system_prompt': '', 'can_h
andle_system_prompt': False}, 'visible_models': 0, 'h2ogpt_key': None}, {'MyData': [None, 'd2a76a4d-57c3-4c82-a057-8b267c091f22', 'mike']}, {'langchain_modes': ['UserData', 'MyData', 'LLM',
'Disabled'], 'langchain_mode_paths': {'UserData': None}, 'langchain_mode_types': {'UserData': 'shared', 'github h2oGPT': 'shared', 'DriverlessAI docs': 'shared', 'wiki': 'shared', 'wiki_full
': '', 'MyData': 'personal', 'LLM': 'either', 'Disabled': 'either'}}, {'headers': '', 'host': 'localhost:7860', 'username': 'mike', 'connection': 'Upgrade', 'pragma': 'no-cache', 'cache-cont
rol': 'no-cache', 'upgrade': 'websocket', 'origin': 'http://localhost:7860', 'sec-websocket-version': '13', 'user-agent': 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gec
ko) Chrome/<IP_ADDRESS> Safari/537.36', 'accept-encoding': 'gzip, deflate, br', 'accept-language': 'en-AU,en-GB;q=0.9,en-US;q=0.8,en;q=0.7', 'cookie': 'username-localhost-8888=REDACTED:username-localhost-8888|188:REDACTED; _xsrf=REDACTED', 'sec-gpc': '1', 'sec-websock
et-key': 'REDACTED', 'sec-websocket-extensions': 'permessage-deflate; client_max_window_bits', 'host2': '<IP_ADDRESS>'}, {}, [['hello', ''], ['hi', '']])
Traceback (most recent call last):
  File "/home/mike/miniconda3/envs/h2oGPT/lib/python3.10/site-packages/gradio/queueing.py", line 407, in call_prediction
    output = await route_utils.call_process_api(
  File "/home/mike/miniconda3/envs/h2oGPT/lib/python3.10/site-packages/gradio/route_utils.py", line 226, in call_process_api
    output = await app.get_blocks().process_api(
  File "/home/mike/miniconda3/envs/h2oGPT/lib/python3.10/site-packages/gradio/blocks.py", line 1550, in process_api
    result = await self.call_function(
  File "/home/mike/miniconda3/envs/h2oGPT/lib/python3.10/site-packages/gradio/blocks.py", line 1199, in call_function
    prediction = await utils.async_iteration(iterator)
  File "/home/mike/miniconda3/envs/h2oGPT/lib/python3.10/site-packages/gradio/utils.py", line 519, in async_iteration
    return await iterator.__anext__()
  File "/home/mike/miniconda3/envs/h2oGPT/lib/python3.10/site-packages/gradio/utils.py", line 512, in __anext__
    return await anyio.to_thread.run_sync(
  File "/home/mike/miniconda3/envs/h2oGPT/lib/python3.10/site-packages/anyio/to_thread.py", line 33, in run_sync
    return await get_asynclib().run_sync_in_worker_thread(
  File "/home/mike/miniconda3/envs/h2oGPT/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 877, in run_sync_in_worker_thread
    return await future
  File "/home/mike/miniconda3/envs/h2oGPT/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 807, in run
    result = context.run(func, *args)
  File "/home/mike/miniconda3/envs/h2oGPT/lib/python3.10/site-packages/gradio/utils.py", line 495, in run_sync_iterator_async
    return next(iterator)
  File "/home/mike/miniconda3/envs/h2oGPT/lib/python3.10/site-packages/gradio/utils.py", line 649, in gen_wrapper
    yield from f(*args, **kwargs)
  File "/home/mike/source/repos/h2ogpt/src/gradio_runner.py", line 4397, in bot
    for res in get_response(fun1, history, chatbot_role1, speaker1, tts_language1, roles_state1,
  File "/home/mike/source/repos/h2ogpt/src/gradio_runner.py", line 4293, in get_response
    for output_fun in fun1():
  File "/home/mike/source/repos/h2ogpt/src/gen.py", line 3702, in evaluate
    for r in run_qa_db(
  File "/home/mike/source/repos/h2ogpt/src/gpt_langchain.py", line 5104, in _run_qa_db
    get_chain(**sim_kwargs)
  File "/home/mike/source/repos/h2ogpt/src/gpt_langchain.py", line 6040, in get_chain
    toolkit = VectorStoreToolkit(vectorstore_info=vectorstore_info)
  File "/home/mike/miniconda3/envs/h2oGPT/lib/python3.10/site-packages/pydantic/v1/main.py", line 339, in __init__
    values, fields_set, validation_error = validate_model(__pydantic_self__.__class__, data)
  File "/home/mike/miniconda3/envs/h2oGPT/lib/python3.10/site-packages/pydantic/v1/main.py", line 1066, in validate_model
    value = field.get_default()
  File "/home/mike/miniconda3/envs/h2oGPT/lib/python3.10/site-packages/pydantic/v1/fields.py", line 439, in get_default
    return smart_deepcopy(self.default) if self.default_factory is None else self.default_factory()
  File "/home/mike/miniconda3/envs/h2oGPT/lib/python3.10/site-packages/langchain/agents/agent_toolkits/vectorstore/toolkit.py", line 34, in <lambda>
    llm: BaseLanguageModel = Field(default_factory=lambda: OpenAI(temperature=0))
  File "/home/mike/miniconda3/envs/h2oGPT/lib/python3.10/site-packages/langchain_core/load/serializable.py", line 107, in __init__
    super().__init__(**kwargs)
  File "/home/mike/miniconda3/envs/h2oGPT/lib/python3.10/site-packages/pydantic/v1/main.py", line 341, in __init__
    raise validation_error
pydantic.v1.error_wrappers.ValidationError: 1 validation error for OpenAI
__root__
  Did not find openai_api_key, please add an environment variable `OPENAI_API_KEY` which contains it, or pass `openai_api_key` as a named parameter. (type=value_error)

This implies you chose the "collection" agent.  This is a bug in langchain.  I'll file issue for them, thanks.


Remove old build containers before trying to bing up new ones

The docker-compose-buildkite plugin had an error in older versions where
it would leave containers hanging around which then took up ports needed
on new builds. Every day somebody seems to push up an old build
accidentally, so instead I'm clearing out existing containers every
time there is a new build.

Thanks for the PR @gerrywastaken, and sorry you hit the bug with the old version.
This plugin is designed to be safely run in parallel on the same machine (multiple agents per machine), and can't assume you're not running other Docker containers too.
I think this change just indiscriminately kills all docker containers on the host?

Oh wow! @toolmantim I didn't mean to create this as a PR. I think I must muscle memoried the hub pull request alias and accidentally created this. This was just actually a temporary fix on our fork (we currently only have one agent) which I'll later revert. It's not something that I wanted merged into the main repo. Sorry about the confusion and I'll look into how I automatically created this. 😆

Heh! All good @gerrywastaken. I've done that myself too 😁


Explicit CommonMark support (with documented deviations)

Gitea version (or commit ref): Any
Git version: N/A
Operating system: Any
Database (use [x]):

[x] Any

Can you reproduce the bug at https://try.gitea.io:

[x] Not relevant

Log gist: N/A

To support interoperability with other software (e.g. text editors), Gitea should explicitly support the CommonMark standard, and document any deviations from/extensions to the standard.
Depends on:

https://github.com/russross/blackfriday/issues/114

So far from what I can tell the deviations from CommonMark are basically the same ones the Github has. Notably, table support, automatic link detection without the <> @mentions support #ticketid support. Honestly, no service supports CommonMark to the exact spec. The CommonMark spec is extremely limiting in scope and some things have been made standard by Github or other services and everyone agrees that its the way its done even though its not in the spec. Tables is an excellent example of something that is not in the spec but everyone has agreed on a standard for.

GFM is a strict superset of CommonMark.

https://github.github.com/gfm (see green highlighted topics for extensions)
https://githubengineering.com/a-formal-spec-for-github-markdown

try this on gitea and on github:
* a
  * b
    * c

on github the indentation of c will be 2
on gitea the indentation of c will be 1 (same as b)

this is only one issue, but for me the most annoying  one

#### GitLab, Gitea
This has two trailing spaces..
And so there's a newline/br here.

But here
there's no trailing space so there's no newline; just a space (' ')

#### GitHub
This lacks two trailing spaces
But GitHub still makes a newline/br

GitLab, Gitea
This has two trailing spaces..
And so there's a newline/br
GitHub
This lacks two trailing spaces
But GitHub still makes a newline/br

Please reopen if still not fixed


Ignore node_modules/.bin by default

I'm not sure there's a good reason that node_modules/.bin should be packaged along with the rest of the app. Besides, it breaks if you use NPM 3 and --prune (for why, see https://github.com/maxogden/electron-packager/issues/180#issuecomment-152897559).
This should fix #149 and #180.

If there aren't any further comments/objections, I'll merge this within a few days.

No objection from me. I’ve been bit by this today, so it’s good to see a solution is really close.


license-file key in Cargo manifest is not read for path dependencies in a workspace

Describe the bug
Path dependencies that specify a license-file get the generic MIT license text.
To Reproduce
Run cargo about with Artichoke as of this PR: https://github.com/artichoke/artichoke/pull/1420.
Expected behavior
Path dependencies in the current workspace use the given license file.
Screenshots
If applicable, add screenshots to help explain your problem.

It looks like cargo doesn't like it when both license and license-key are specified.
I think what I'd really like is for path dependencies to check the workspace root for the license file.


Mekanism 1.7.10

[20:33:13] [Thread-10/ERROR] [Mekanism/Mekanism]: An error occured while connecting to URL 'https://dl.dropbox.com/u/90411166/Mod Versions/Mekanism.txt.'
Shows up in the logs while starting the server. I reckon you can easily replace the URL :)

what version of mek are you using?

Dropbox has had some strange instability issues over the past few months, and I'm pretty sure they're gonna be discontinuing their public links service fairly soon. I'm gonna move to directly host the donators and news files from my website fairly soon, that should fix the issues.


Update grep

Add search more than one pattern using grep

Try to cancel pull request on youtube-dl but made a mistake by deleting youtube-dl.


Automatically stage all form changes that are not pristine

This PR:

add an effect that will stage all dirty form changes when the tasklist changes pages
fix the Money widget to prevent it from having a NaN value
initializes the project form_change to null so that its status is initially "Not" started
makes the tasklist sections expanded by default when they contain an "attention required" status

There's a failing e2e test, but otherwise looks good to go. Looks like the error is in the contacts part of the test

There's a failing e2e test, but otherwise looks good to go. Looks like the error is in the contacts part of the test

@matthieu-foucault Is this the same issue as: https://github.com/bcgov/cas-cif/issues/684 ?

There's a failing e2e test, but otherwise looks good to go. Looks like the error is in the contacts part of the test

@matthieu-foucault Is this the same issue as: #684 ?

@Sepehr-Sobhani  it looks like it yes, the e2e test passed after rebasing. I added some extra assertions in the test between adding each secondary contact, it might fix it.


Fix the build on Windows using mingw

static link to mingw libraries (to avoid path issues)
adjust the path conventions (drive letter) to be able to use existing bash scripts on Windows
add an install target to be able to build outside the source folder (and keep using existing bash scripts)

To fix the "[linux/macos]_build_and_test" checks that fail, use PR#53 (since it is not directly related to mingw, i have chosen to write an other PR for that)

@philippefoubert As a small request, can you please fix the style check errors? You can run cpplint tool on your end like: cpplint --filter=-build/include_subdir,-runtime/reference --recursive .


Cybersecurity: 2.3 IP address v/s MAC address

Description
List out differences between IP address and MAC address.
Note:

If interested, mention in which format you want to contribute: Documentation or Video
Please avoid copy/paste, BE YOURSELF
Try to explain with Diagrams
Changes should be made inside the Cyber_Security/ directory & Cyber_Security branch.
Task will be assigned on first come first serve
Check it out Contribution Guidelines

I would like to work on this

I would like to work on this

for doc

I would like to work on this

for doc

Okay!
Go with it!


Log more/all activity of ApiListeners

Reporter
Bastiaan Udo
Is your feature request related to a problem? Please describe.
Request from Jeri Tjalsma as PO of ibis4oma
Describe the solution you'd like
At the moment, the ApiListener does not seem to log much. Expand logging in case something goes wrong. Currently it's very hard to determine why requests get denied somewhere in the chain.
We've seen Accept header being unacceptable (405) without any logging
We've seen method being unauthorized (403) without any logging.
We've seen endpoint not being authorized (401) without any logging.
We've seen wrong password used (401), only error logged, not userId
We would like info logging of all requests: endpoint, method, userId, timestamp and duration.
We would like error logging of all failing requests: endpoint, method, userId, timestamp and duration. Possible with reason of failing.
Describe alternatives you've considered
We thought it best resolved in the IAF
Additional context
I spoke to Ali, he said this functionality was already conferred over within the IAF core team, but not yet planned.

Higher than 4XX is a warning might be a good default

Higher than 4XX is a warning might be a good default


Bug fix: If extension doesn't have a version, don't parse version

View a preview at https://prompt.ws/r/Azure/azure-cli/5989
This is an experimental preview for @microsoft users.


Provide Health endpoint

🆕🐥 First Timers Only
This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
👾 Description of the issue
The service is based on Eclipse Microprofile that provides an health api. A simple endpoint for health checks should be added to the service.
📋 Step by Step
To solve this issue and contribute a fix you should check the following step-by-step list. A more detailed documentation of the workflow can be found here.

[ ] Claim this issue: Comment below.
[ ]  Fork the repository in github by simply clicking the 'fork' button.
[ ]  Check out the forked repository
[ ]  Create a feature branch for the issue. We do not have any naming definition for branches.
[ ]  Commit your changes.
[ ]  Start a Pull Request.
[ ]  Done 👍 Ask in comments for a review :)
[ ]  If the reviewer find some missing peaces or a problem he will start a discussion with you and describe the next steps how the problem can be solved.
[ ]  You did it 🎉 We will merge the fix in the master branch.
[ ]  Thanks, thanks, thanks for being part of this project as an open source contributor ❤

🎉 Contribute to Hacktoberfest
Solve this issue as part of the Hacktoberfest event and get a change to receive cool goodies like a T-Shirt. 🎽
🤔❓ Questions
If you have any questions just ask us directly in this issue by adding a comment. You can join our community chat at Slack. Next to this you can find a general manual about open source contributions here.

Hi @hendrikebbers, can i work on this issue?


Any guidance on how to create a coherence image

Hello,
I am trying to run the program but I dont have a coherence image.
Could you provide guidance on how to create a it as you mentioned by "isce" repo?

Unfortunately creating the coherence images isn’t straightforward. Assuming that you want to use Sentinel 1 data, you can download it and process the data using the InSAR Scientific Computing Environment (ISCE). You can find more information on that here: https://github.com/isce-framework/isce2/blob/main/contrib/stack/topsStack/README.md (see section 4.4 "stack of correlation" - correlation is the same as coherence).
For a general introduction to ISCE, see the main repo here: https://github.com/isce-framework/isce2/tree/main.

From: Deniz Can ELCI @.>
Sent: Thursday, December 14, 2023 6:59:09 AM
To: olliestephenson/dpm-rnn-public @.>
Cc: Subscribed @.***>
Subject: [olliestephenson/dpm-rnn-public] Any guidance on how to create a coherence image (Issue #3)
Hello,
I am trying to run the program but I dont have a coherence image.
Could you provide guidance on how to create a it as you mentioned by "isce" repo?
—
Reply to this email directly, view it on GitHubhttps://github.com/olliestephenson/dpm-rnn-public/issues/3, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHEEFZAZPQP4DCICHQF2ONLYJICI3AVCNFSM6AAAAABATXEFFKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2DAMZXHA3DQMA.
You are receiving this because you are subscribed to this thread.Message ID: @.***>


Not load anywhere

Option Not load anywhere

Hi,
I'm sorry you are having issues. I haven't worked on this project in a few years now and its here only  to support a few projects I worked on several years ago. If you look at the read me you will notice that it says
UPDATE:
I recommend you use https://docs.djangoproject.com/en/dev/ref/contrib/admin/actions/

Which I think it actually the right way to solve customizing the django admin.
Hope that helps!

Ok but actions not works without select a object of list.


Consistent use of inst() naming across framework

We've historically been using inst() as a short name for instance() starting with the widely used Injector class some time in 3.x. Since then, more classes have been introduced in 4.x with the long form of instance(), making APIs inconsistent.

ThemeResourceLoader
ModuleLoader
ConfigLoader
ClassLoader

While this should all be unnecessary through proper injector use and the new app object. that's unlikely to be fully realised in 4.x - so we should avoid API inconsistencies in this release.
The consensus from a Slack conversation on #core-committers is that we should stick with inst().
@channel for static access to singleton objects, do we want to continue with the pattern `Injector::inst()`switch to `Injector::instance()`? We’ll be looking to reduce the amount that it’s necessary to use it but it will probably still be hanging around a bit in SS4

:+1: for inst() - 5
:-1: for instance() - 3

unclecheese [9:27 AM]
So, one more API change, more upgrade pain.. what's the benefit?

tractorcow [9:28 AM]
we also have `::singleton()`

[9:29]
Does your change cover this?

sminnee [9:41 AM]
@tractorcow it’s your change, not mine :wink:

[9:41]
my recommendation is that we leave it as `inst()` you were recommending that we change it to instance.

[9:42]
@unclecheese in fairness, by the time SS4 goes stable I’m expecting it’d be `App::inst()->getInjector()` anyway. We might then have `Injector::inst()` as a deprecated fallback, though

unclecheese [9:43 AM]
yeah, i got caught up on the internal thread.. makes sense

sminnee [9:43 AM]
and having `Injector::instance()` as a deprecated fallback would make no sense whatsoever

unclecheese [9:43 AM]
Given that, my vote is for inst()

sminnee [9:43 AM]
so you’d have `App::instance()` and `Injector::inst()` if we changed.

[9:44]
Unless we deleted `Injector::inst()` altogether and force the use of `App::inst()->getInjector()`

unclecheese [9:45 AM]
So it's basically an API change for something that will be deprecated, or at least discouraged

[9:45]
I don't see the point in that

sminnee [9:45 AM]
More or less, yep.

tractorcow [9:45 AM]
Removing things in 4.0 is fine :smile:

[9:46]
how would config look?

[9:46]
We have Config class (handles nesting) and ConfigCollectionInterface (collection at each nesting level) (edited)

tractorcow [10:02 AM]
`App::inst()->getConfig()->nest()`
`App::inst()->getConfig()->get('Class', 'property')`

sminnee [10:08 AM]
I would expect that `nest()` would shift to the application object, but we’d need to validate what the use-case of nesting actually is

[10:08]
My understanding was that it was pervasive things like test-execution (edited)

unclecheese [10:16 AM]
it's mostly for testing

dhensby
[8:54 PM]
> by the time SS4 goes stable I’m expecting it’d be `App::inst()->getInjector()` anyway. We might then have `Injector::inst()` as a deprecated fallback, though

Note that in 4.0, Config::inst() returns an object that isn't of the same type as the parent class.

Fixed with https://github.com/silverstripe/silverstripe-framework/issues/6934


Derive default package dir from library dir

This commit will ease with packaging on mutli-arch envionments such as Debian. The multi-arch specific path now needs to be injected only once via -DSimpleITK_INSTALL_LIBRARY_DIR=$(MULTIARCH_PATH) in the packaging build script.

Great! Thank you.
We have a separate "staging" repository run by Kitware. This branch with be first merged into next, to be tested on the nightly dashboard, then it will be merged into master.

Topic was merged into master:
https://github.com/SimpleITK/SimpleITK/commit/cc77e3c946cea44dae79d6f052120266a6bf2f0a


Adding HrNet as pose estimator ?

Is it possible to add HrNet hrnet or posenet posenet into the tracking module ??

@timtensor I replace pose module by Hrnet and simple-baseline, you can refer this https://github.com/lxy5513/cvToolBox

Thank you !


WebRTC SDP handshake connection transient?

Version:
@libp2p/webrtc 4.1.3

Subsystem:
WebRTC

Severity:
Medium
Description:
I continue my investigation from #2646 and found that there is a bunch of connection and disconnection events that goes through the protocol handler due to the temporary WebRTC SDP handshake connection.
https://github.com/libp2p/js-libp2p/blob/944935f8dbcc1083e4cb4a02b49a0aab3083d3d9/packages/transport-webrtc/src/private-to-private/initiate-connection.ts#L57
When shouldCloseConnection is true, I would want to handle this connection as transient since it might close very soon after open.
Doing a
connection.transient = true

line after the dial does not however fix the problem completely since we still have the problem that all transient and non-transient connection close events go through the protocol handler, which is another issue #2369

Going through some of the testing for transient connections this line
https://github.com/libp2p/js-libp2p/blob/fd4aea3efea861aa11b4b25b69c5ac8842208ab5/packages/libp2p/test/registrar/registrar.spec.ts#L224
does not seem to have an effect of the outcome of the test.
If we would want to know whether a closing connection is transient or not the "peer:disconnect" info also needs to emit this
https://github.com/libp2p/js-libp2p/blob/fd4aea3efea861aa11b4b25b69c5ac8842208ab5/packages/libp2p/src/connection-manager/index.ts#L474


SharedTree: API discussion

GH issue for discussing possible refinements of the SharedTree API.

Parent/Path Access
Would be nice to be able to get the parent field from an EditableTree node, and to get parent node from a field (undefined if a detached field)
API control via schema metadata
Allow setting primary fields and primitive nodes via metadata in the schema instead of inferring it from the lack of other fields/values.
In the future this could also be extended to also an optional factory function for an alternative type which could get instantiated instead of editable tree nodes and put in the tree if accessed using the unwrapping API.


Duplication issue if this mod is paired with the Traveler's Backpack (FABRIC)

Steps to reproduce:

Install both this mod and Traveler's Backpack.
Try to transform a backpack into a basic one using Shears in a crafting terminal.
The original backpack will remain in the terminal's crafting grid, a normal one, with identical content, will be crafted.

Expected behavior:
The original backpack should be consumed, as using any other crafting table, or equivalent block/item/entity.
Actual behavior:
The original backpack is kept inside the crafting grid, while a basic one is crafted.

Duplicate of #142


Adopt sysroot for Linux OSS CI pipeline

We ran into a situation were it is possible for agents to roll back gcc toolchain which can affect our build if native modules were cached on agents with higher ABI versions. We can reuse the sysroots from product build to avoid any future regressions.
https://github.com/microsoft/vscode/blob/c72bcdaa99d91323bfd29e2ea1df2dba5636a908/build/azure-pipelines/linux/product-build-linux.yml#L118

https://github.com/microsoft/vscode/pull/212895 addresses this but there is a stopper, we need github-distro-mixin-password in the OSS pipeline to avoid rate limits when downloading the sysroots from github releases. I believe we didn't want to setup secrets for this pipeline, any alternatives ? /cc @lszomoru @joaomoreno


GitHub to Jira POC

Our team is participating in a POC experiment to evaluate the ability to sync issues from our GitHub project to New Relic's new Jira instance. The intention is for developers to continue their work in GitHub, but have the important information synced on issues between both platforms to give product managers and other users of Jira the ability to reference the issues from GitHub.
Tasks

[x] Mimic the conversation from an existing ticket on the newrelic-ruby-agent repo on the GitHub Jira Sandbox, going between my personal and New Relic GitHub accounts. Evaluate the differences/missing content (if anything) and share workflow notes with the team

[x] Completed on bug
[x] Completed on feature-request
[x] Completed on story

[ ] Create story.md issue template to represent Story issue type in Jira
[ ] Change feature issue template to feature-request
[ ] Update existing tickets labeled feature into either story or feature-request based on their scope
[ ] Sync issues from this repository into the new Jira instance

Put on hold based on formatting and issue status transition issues waiting on assistance from Workato.

Issue syncing complete as of 9/12/2022! 🎉

@angelatan2 - I wanted to let you know that the "Work has been completed" comment was printed twice on this issue.


Access Violation: Sql2o assigns object to field of wrong type without warning; crashes JVM

My PostgreSQL DB table has a field called "committed_at of type "DATE", which I map to a POJO with a field called committedAt of type "LocalDate". I forgot to add the custom converter for this, but I was expecting a warning about not being able to assign the field. Instead, it silently assigned the "java.sql.Date" object to a field of type "java.time.LocalDate", meaning attempts to call methods on it will crash the JVM.
Here is my mostly self-contained example:
public class Main {
    public static class Crime {
        public LocalDate committedAt;
        public Double latitude;
        public Double longitude;
        public String location;
        public String type;
    }

    public static void main(String[] args) {
        PGSimpleDataSource d = new PGSimpleDataSource();
        d.setUser("postgres");
        d.setPassword("password");
        d.setServerName("localhost");
        d.setPortNumber(5432);
        d.setDatabaseName("crime_db");

        Sql2o sql2o = new Sql2o(d);

        String sql = "SELECT committed_at committedAt, coordinates[0] latitude, coordinates[1] longitude, location, type FROM crimes";
        try(Connection con = sql2o.open()) {
            Crime crime = con.createQuery(sql).executeAndFetchFirst(Crime.class);
            LocalDate date = crime.committedAt;
            System.out.println(date.getClass().getName());
            System.out.println(date.getYear());
        }
    }
}

This outputs:
Java.sql.Date
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  EXCEPTION_ACCESS_VIOLATION (0xc0000005) at pc=0x00000000638331f3, pid=15832, tid=0x00000000000004b4
#
# JRE version: Java(TM) SE Runtime Environment (8.0_131-b11) (build 1.8.0_131-b11)
# Java VM: Java HotSpot(TM) 64-Bit Server VM (25.131-b11 mixed mode windows-amd64 compressed oops)
# Problematic frame:
# V  [jvm.dll+0x2031f3]

(The rest of the error is omitted)
Relevant build.gradle stuff:
    compile "org.postgresql:postgresql:42.1.1"
    compile "org.sql2o:sql2o:1.6.0-RC3"

Edit: This seems like it might be related to issue #206

This looks to be related to the change to the setter functionality to use sun.misc.Unsafe commit. Have you tried to use version 1.5.4 or Jodas Localdate with your existing version?

It sounds very possible that it was caused by the use of Unsafe. I don't have any interest in using Joda's version of LocalDate, and that isn't really the issue - the issue is that this crashed the JVM instead of throwing a runtime error when it attempted to map a field to an unknown type.

@DanStout did you find any solution?
I created PR https://github.com/aaberg/sql2o/pull/352 that should fix this problem.


globalFooter takes GitHostingService type name instead of name

When you set following sbt setting:
micrositeGitHostingService := Other("OtherSite")

global footer will display: View on Other("OtherSite") instead of View on OtherSite due to lack of .gitHostingService.name here:
https://github.com/47deg/sbt-microsites/blob/9d56a23cf8d9a83a12c1c9da01260a55fc38d29d/src/main/scala/microsites/layouts/Layout.scala#L228
I'll try to fix it in my spare time and submit PR. If there is anyone that can do it faster than me, please don't hesitate.
Best regards,
Karol

Ah, that would be great Karol. If you need help tackling it please ask around here, thanks!

Closed by https://github.com/47deg/sbt-microsites/pull/300


⚠ GitHub has degraded performance

In 07d5752, GitHub (https://www.githubstatus.com/api/v2/status.json) experienced degraded performance:

HTTP code: 200
Response time: 210 ms

Resolved: GitHub performance has improved in 6a78648 after 43 minutes.


I don't have MCP or attached logo

I am on Windows with the latest desktop version, I have enabled developer mode and I am in Europe

Can you share your %APPDATA%\Claude\claude_desktop_config.json? (In case this doesn't make sense, I'm referring to step 2 in the Windows quickstart guide here: https://modelcontextprotocol.io/quickstart#installation)

The docs are a bit confusing, you should add the individual MCP servers under the mcpServers key in the JSON like so.
{
  "mcpServers": {
    "filesystem": {
      "command": "npx",
      "args": [
        ...
      ]
    },
    "memory": {
      "command": "npx",
      "args": [...]
    }
  }
}

Thank you, it works! Now, how do I integrate Github?

You should use the github config that you had before, instead of the filesystem and memory configs that I have. You can add it as another key after filesystem and memory, though those configs won't work exactly as I have written since I omitted the args key for brevity.

OK Thanks, it's super cool for your help. But well... it's not working. I entered the key correctly but when I ask Claude, for example to create an issue, it won't do it

I've got almost the exact same situation. I have two servers configured:
{
  "mcpServers": {
    "sqlite": {
      "command": "uvx",
      "args": ["mcp-server-sqlite", "--db-path", "/Users/glen/src/experiments/claude-local-sqlite"]
    },
    "brave_search": {
      "command": "npx",
      "args": ["@modelcontextprotocol/server-brave-search"],
      "env": {
        "BRAVE_API_KEY": "<redacted>"
      }
    }
  }
}

My debug log looks fine:

Settings looks fine:

But no 🔌 icon in the chat window:

And a flat refusal to do anything with the connections:

Update: just tried on my windows machine, and got the exact same result. Is it possible this is geoblocked in Australia?

Same issue here, there is no 🔌, I do have the filesystem server running but I get a message in Claude Desktop of it failing to attach to the MCP server.

To add more context based on when geelen said, I am from New Zealand and running on Windows so could be georestrictions, or it could be some device setup.
Having issues running MCPInspector as well so debugging is a bit difficult

Update on my end, I switched over to a MacBook as there seemed to be some issues with running this on Windows see: https://github.com/modelcontextprotocol/inspector/issues/76
For the filesystem server it is now working as well as the Github server. The region locked theory is wrong, it's just device configuration/OS support.
For the SQLite and Brave Search the issues #37 #42 may be helpful for the others in this thread as there seems to be some issues with pathing sometimes.

You're quite right. I had a typo in the path to my DB! That was crashing things, even stopping me from adding other tools.

I'm also experiencing issues with the filesystem server on Windows. Here's my configuration:
{
  "mcpServers": {
    "filesystem": {
      "command": "npx",
      "args": [
        "-y",
        "@modelcontextprotocol/server-filesystem",
        "C:\\Users\\Username\\Desktop"
      ]
    }
  }
}

Same behavior on Windows 11 and Mac OS. Claude desktop 0.71.1 version on both devices.

I'm also experiencing issues with the filesystem server on Windows. Here's my configuration:
{
  "mcpServers": {
    "filesystem": {
      "command": "npx",
      "args": [
        "-y",
        "@modelcontextprotocol/server-filesystem",
        "C:\\Users\\Username\\Desktop"
      ]
    }
  }
}

The same problem with me. My configuration :
{
    "mcpServers": {
        "filesystem": {
            "command": "npx",
            "args": [
                "-y",
                "@modelcontextprotocol/server-filesystem",
                "A:\\Desktop\\"
            ]
        }
    }
}

Experiencing similar issues on Mac OS using Claude Desktop 0.71.1.

Same issue, log file attached:

@mckaywrigley what does your config file look like?
code ~/Library/Application\ Support/Claude/claude_desktop_config.json

@thenameless7741 Just to check, are you on an Intel Mac? /usr/local/Homebrew isn't searched as part of the path right now, but that's something we could fix.

Sorry folks, and thanks for your patience! For npx calls in particular, we believe there's an issue with how Claude Desktop is launching subprocesses on Windows, which https://github.com/modelcontextprotocol/typescript-sdk/pull/68 (once integrated) should hopefully fix. 🤞

@oscarcalvo As @jspahrsummers mentioned, you have to use node directly, like this
{
	"mcpServers" : {
		"filesystem": {
			"command": "node",
			"args": [
			"C:\\Program<EMAIL_ADDRESS>
			"C:\\"
			]
		}
	}
}

@rkaradas You are right, thanks

Any ways to access mcp-server inside WSL?
I've tried this but no luck:
"command": "wsl",
            "args":
            [
                "bash",
                "-ic",
                "node /home/timur/dev/personal/mcp/mcp-server-jina/build/index.js"
            ],

"command": "node",
            "args":
            [
                "\\wsl.localhost\\Ubuntu-22\\home\\timur\\dev\\personal\\mcp\\mcp-server-jina\\build\\index.js"
            ],

@oscarcalvo As @jspahrsummers mentioned, you have to use node directly, like this
{
	"mcpServers" : {
		"filesystem": {
			"command": "node",
			"args": [
			"C:\\Program<EMAIL_ADDRESS>
			"C:\\"
			]
		}
	}
}

THANKS YOU !!!!!!!

@oscarcalvo As @jspahrsummers mentioned, you have to use node directly, like this
{
	"mcpServers" : {
		"filesystem": {
			"command": "node",
			"args": [
			"C:\\Program<EMAIL_ADDRESS>
			"C:\\"
			]
		}
	}
}

This workaround does not work for me? Still getting "Could not attach to MCP server filesystem". I'm on an m2 mac.

@amirrezapanahi Can you share the error showing up in the logs? See here for more details on how to access: https://modelcontextprotocol.io/docs/tools/debugging#viewing-logs

im trying the example on the website and getting this error on windows,
2024-11-26T21:18:48.459Z [error] Could not start MCP server sqlite: Error: spawn uvx ENOENT
at ChildProcess._handle.onexit (node:internal/child_process:286:19)
at onErrorNT (node:internal/child_process:484:16)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
errno: -4058,
code: 'ENOENT',
syscall: 'spawn uvx',
path: 'uvx',
spawnargs: [Array]

i wonder if it would be useful for this GUI button to perform the following command, rather than read from the only single mcp.log :
tail -n 20 -f ~/Library/Logs/Claude/mcp*.log

#64
This fixed all issues I was having. npx appears to have issues with MCPs.

UVX packages work well also (e.g. fetch & github ones)

Thanks for this (was diagnosing and found this thread). Confirmed working - this also works for the Inspector tool.

this solved it for me

@mar0der I don't think this will work as this is not valid json.  You need double slashes for escaping.

@oscarcalvo As @jspahrsummers mentioned, you have to use node directly, like this
{
	"mcpServers" : {
		"filesystem": {
			"command": "node",
			"args": [
			"C:\\Program<EMAIL_ADDRESS>
			"C:\\"
			]
		}
	}
}

If you're like me and the above solution doesn't work as is, try running the following command:

npm root -g

to find out where the node modules are installed in your system, and replace

C:\Program Files\nodejs\node_modules

above with the output of the command.

@deepseven  thanks！！！
This solution worked for me on Windows. Here's my working configuration:
{
  "mcpServers": {
    "filesystem": {
      "command": "node",
      "args": [
<EMAIL_ADDRESS>        "C:\\"
      ]
    }
  }
}

Hi all, I'm on Windows and have tried the fixe noted above (i.e., using node directly) but Claude Desktop is still not attaching to the MCP server. The log files have said "Attempting to connect to MCP server filesystem..." and then "Connected to MCP server filesystem!". The config file I am using is in the image. Any ideas?

You need to have the index.js referenced<EMAIL_ADDRESS>in the first arg.
Also - if you're not already try using the Inspector tool - it's quicker and easier to diagnose issues.

Thanks for the help. Here is what worked for me:
Windows MCP Server Connection Fix
Issue: MCP servers not properly attaching in Claude Desktop on Windows despite showing as "connected" in logs.
Root cause: Using npx to run servers can cause attachment issues on Windows.
Solution:

Install server package locally:

npm install @modelcontextprotocol/server-memory

Hello I am trying to install MCP in my mac. However the require json file is not in my folder
~/Library/Application\ Support/Claude/
These are the files I can see in my computer
Cache				GPUCache			Shared Dictionary		config.json
Code Cache			IndexedDB			SharedStorage			sentry
Cookies				Local Storage			TransportSecurity		sqlite_mcp_server.db
Cookies-journal			Network Persistent State	Trust Tokens			window-state.json
Crashpad			Preferences			Trust Tokens-journal
DawnGraphiteCache		Service Worker			WebStorage
DawnWebGPUCache			Session Storage			blob_storage
I tried modifying config.json but then the app would stop working.

Have you tried to nano that dir with the config file?
Pro tip: copy the readme of the dir into claude and describe your problem and should be able to help you! I did this earlier today on macOS and got it working!

Hi Marc,
I created the file but it is still not working. When I relaunch the app still do not recognize that the file is there.
￼

On Nov 29, 2024, at 9:27 PM, Marc @.***> wrote:
Have you tried to nano that dir with the config file?
Pro tip: copy the readme of the dir into claude and describe your problem and should be able to help you! I did this earlier today on macOS and got it working!
—
Reply to this email directly, view it on GitHub https://github.com/modelcontextprotocol/servers/issues/40#issuecomment-2508793911, or unsubscribe https://github.com/notifications/unsubscribe-auth/BG7EK4A6JUJ3H7LWFEI2LIT2DEPBDAVCNFSM6AAAAABSO4TCKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBYG44TGOJRGE.
You are receiving this because you commented.

Hello all
On windows 11 > latest Claude Desktop app
trying to make the Brave search work
have the brave api key.
anyone has found a solution?

Says it's installed but Doesn't show up on the GUI, and I get errors and cant search locally or on the web!

Help anyone?

@fabiendostie having the same error im on windows 10

Update: just tried on my windows machine, and got the exact same result. Is it possible this is geoblocked in Australia?

I am in USA (Texas), same exact issue. And MCP Inspector works (even github). Not errors anywhere. MCP's show up under developer tab, but Claude Desktop does not use them.

this is potentially an issue with nvm as stated in this thread: https://github.com/modelcontextprotocol/servers/issues/64
i had the same issue on mac but got it to work by just explicitly stating the node version and pointing directly to the downloaded index.js file for the specific server you want to connect to.
    "mcpServers": {
        "sqlite": {
            "command": "uvx",
            "args": ["mcp-server-sqlite", "--db-path", "/Users/natefikru/test.db"]
        },
        "puppeteer": {
            "command": "/Users/natefikru/.nvm/versions/node/v22.4.0/bin/node",
            "args": ["/Users/natefikru/Documents/servers/src/puppeteer/dist/index.js"]
        },
        "brave-search": {
            "command": "/Users/natefikru/.nvm/versions/node/v22.4.0/bin/node",
            "args": ["/Users/natefikru/Documents/servers/src/brave-search/dist/index.js"],
            "env": {
              "BRAVE_API_KEY": "xxx"
            }
        },
        "github": {
            "command": "/Users/natefikru/.nvm/versions/node/v22.4.0/bin/node",
            "args": ["/Users/natefikru/Documents/servers/src/github/dist/index.js"],
            "env": {
              "GITHUB_PERSONAL_ACCESS_TOKEN": "xxx"
            }
        }
    }
}

@natefikru just tried this method on Windows 10 unfortunately it didn't work (for the "xxx" I used my real keys just changed it for this btw)
might try to run a virtual MacOS to see if I can get it to work

Fixing MCP Server Connection Issues in Claude Desktop
Installation Steps
1. Install Required Packages
npm install -g @modelcontextprotocol/server-filesystem
npm install -g @modelcontextprotocol/server-memory
npm install -g @modelcontextprotocol/server-brave-search
npm install -g @modelcontextprotocol/server-github

2. Update Configuration
Replace content in claude_desktop_config.json:
{
  "mcpServers": {
    "filesystem": {
      "command": "node",
      "args": [
<EMAIL_ADDRESS>        "c:/"
      ]
    },
    "memory": {
      "command": "node",
      "args": [
<EMAIL_ADDRESS>      ]
    },
    "git": {
      "command": "uvx",
      "args": [
        "mcp-server-git",
        "--repository",
        "C:/Users/YOUR_USERNAME/Projects/NodeJs/super_ai_agents"
      ]
    },
    "brave-search": {
      "command": "node",
      "args": [
<EMAIL_ADDRESS>      ],
      "env": {
        "BRAVE_API_KEY": "YOUR_BRAVE_API_KEY"
      }
    },
    "github": {
      "command": "node",
      "args": [
<EMAIL_ADDRESS>      ],
      "env": {
        "GITHUB_PERSONAL_ACCESS_TOKEN": "YOUR_GITHUB_TOKEN"
      }
    }
  }
}

Note: Replace YOUR_USERNAME, YOUR_BRAVE_API_KEY, and YOUR_GITHUB_TOKEN with your actual values.
3. Test Server Connections
Run these commands individually to verify each server:
node<EMAIL_ADDRESS>c:/
node<EMAIL_ADDRESS>node<EMAIL_ADDRESS>node<EMAIL_ADDRESS>
4. Final Steps

Restart your PC
Launch Claude Desktop application
Check connection logs

Success Indicators
Look for these messages in the logs:
[info] Connected to MCP server memory!
[info] Connected to MCP server git!
[info] Connected to MCP server filesystem!
[info] Connected to MCP server brave-search!
[info] Connected to MCP server github!

Important Notes

Use forward slashes (/) in paths
Replace placeholders with your actual values
Install all servers globally using npm
Restart PC after configuration changes

Let me list the typical prompts/queries that would trigger each MCP to verify they're working properly:

Brave-Search MCP

"Give me the latest AI news"
"Search for recent developments in quantum computing"
"Find articles about climate change from last month"

Brave Local Search MCP

"Find pizza restaurants near Central Park"
"Show me coffee shops in Bangkok"
"List dentists in London"

GitHub MCP

"List my GitHub repositories"
"Create a new repository named test-project"
"Show me the contents of file README.md from repository X"

Filesystem MCP

"List files in directory C:/Users/myname/Projects"
"Read the content of config.json"
"Create a new directory named test"

Git MCP

"Show git status for repository X"
"Show recent commit history"
"Add and commit these changes"

Memory MCP

"Create a new entity named 'Project A'"
"Search for nodes containing 'AI'"
"Show me all relations in the graph"

Would you like me to demonstrate any specific MCP with a test query?

How I enabled the MCP Brave Search. In Windows, really pay attention to the absolute path
Following steps by @Chatmala , i make a few adjustment below:

OS: Windows 10
CMD: Using Windows Command Prompt (have problem with PowerShell)
for below guide, please change all the YOUR_USERNAME into your own login name path

Steps:

open windows command prompt (I'm not using Power Shell) and run command below:npm install -g @modelcontextprotocol/server-brave-search

by default it will install in the folder under your login. in my case as below:

<EMAIL_ADDRESS>

try running command below to test that it able to execute:

node<EMAIL_ADDRESS>

the output will display something like below, just one line of notification. ctrl-c to kill it:

Locating the  claude_desktop_config.json
if you open the setting in Claude Desktop, you can find where does the file claude_desktop_config.json is referred/created in your folder:

Update the claude_desktop_config.json . Mine as below:

note: As you can see, I also have setup using sqlite3 and it able to run. It requires Python 3.10 and above. Please let me know if requires the steps on this, but basically really pay attention to the absolute path!

folder: C:\Users\YOUR_USERNAME\AppData\Roaming\Claude\claude_desktop_config.json

{
  "mcpServers": {
	"sqlite": {
	  "command": "C:\\Users\\YOUR_USERNAME\\AppData\\Local\\Microsoft\\WinGet\\Links\\uvx",
	  "args": [
		"mcp-server-sqlite",
		"--db-path",
		"E:\\dev\\claude\\mcp\\test.db"
	  ]
	},
	"brave-search": {
	  "command": "node",
	  "args": [
<EMAIL_ADDRESS>	  ],
	  "env": {
		"BRAVE_API_KEY": "BRAVE-API-KEY"
	  }
	}
  }
}

Close the Claude Desktop. Make sure the one on the taskbar also closed. Click to open it again.

You can notice under the "Attach from MCP" icon, some of the services appear. For me I have 8 registered.

you can start prompting to test the power of MCP! Kudos Anthrop\c!

@ymdarum Your solution works as well when using nvm for windows. Good Catch Man! You nailed it!

@ymdarum it worked!

@ymdarum thanks man, this worked for me as well

thank you soooooooomuch for this! it worked for me too
On Sun, Dec 1, 2024 at 3:38 PM Angelo Alexander @.***>
wrote:

@ymdarum https://github.com/ymdarum thanks man, this worked for me as
well
—
Reply to this email directly, view it on GitHub
https://github.com/modelcontextprotocol/servers/issues/40#issuecomment-2510241940,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM22A2N3JGAILBLC27PQL7T2DNXUVAVCNFSM6AAAAABSO4TCKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJQGI2DCOJUGA
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
. | Fabien Dostie
.///Direction Technique / Network Admin / Post-Production Specialist
.//Coloriste Resolve / Compositing / Online Editing / AR - VR
./DIT / DMT / Technicien Scene Video (AQTIS 514 - IATSE 56)
C:<PHONE_NUMBER> W: fabiendostie.com lefab.biz

Actually there is similar problem with python based MCP servers . When I try to run it with uvx it fails but when I run it with python command it works fine. I think the MCP servers should be ran in more ancient way using python or npm rather than uvx or npx.

Also why in the world is there no linux app of Claude . While more than 90% of development is done on Linux .

🎉this works for me :
{
  "mcpServers": {
    "git": {
      "command": "python3.11",
      "args": [
        "-m",
        "mcp_server_git",
        "--repository",
        "C:\\Users\\heman\\Desktop\\test_mcp_git"
      ]
    },
    "memory": {
      "command": "node",
      "args": [
<EMAIL_ADDRESS>      ]
    },
    "filesystem": {
      "command": "node",
      "args": [
<EMAIL_ADDRESS>        "C:\\Users\\heman\\Desktop",
        "C:\\Users\\heman\\Desktop\\test_mcp_git"
      ]
    },
    "github": {
      "command": "node",
      "args": [
<EMAIL_ADDRESS>      ],
      "env": {
        "GITHUB_PERSONAL_ACCESS_TOKEN": "my-token"
      }
    }
  }
}

Faced the same issue in Mac because my node is setup using node version manager asdf in my case. All I did was Find the npx installation path with which npx. Copy the path to my configuration below e.g: /Users/<me>/.asdf/shims/npx. And it worked for me.
{
  "mcpServers": {
    "github": {
      "command": "/Users/<me>/.asdf/shims/npx",
      "args": [
        "-y",
        "@modelcontextprotocol/server-github"
      ],
      "env": {
        "GITHUB_PERSONAL_ACCESS_TOKEN": ""
      }
    }
  }
}

i am on a windows pc and my servers for filesystem, brave, etc work fine
but the one for gdrive isn't able to authorize
this is my config file:
"gdrive": {
  "command": "node",
  "args": [
<EMAIL_ADDRESS>    ]
}

}
would appreciate any guidance on how to get the gdrive mcp to work, please. thx!

{ 	"mcpServers": { 	  "filesystem": { 		"command": "cmd", 		"args": [ 		  "/c",  		  "set NODE_DEBUG=* && npx -y @modelcontextprotocol/server-filesystem", 		  "c:\\users\\<youraccountname>\\claude-server" 		] 	  } 	}   }

enjoy it~

Hey folks, there's a new version of Claude Desktop that should resolve issues launching npx on Windows. Please update to v0.7.5 and give it another shot! (If you have any issues auto-updating, you can always download the latest from https://claude.ai/download.)
Thanks for your patience!

@jspahrsummers thanks for the update. BTW I want to work at anthropic, please consider my profile for any related position.

Fixing MCP Server Connection Issues in Claude Desktop
Installation Steps
1. Install Required Packages
npm install -g @modelcontextprotocol/server-filesystem
npm install -g @modelcontextprotocol/server-memory
npm install -g @modelcontextprotocol/server-brave-search
npm install -g @modelcontextprotocol/server-github

2. Update Configuration
Replace content in claude_desktop_config.json:
{
  "mcpServers": {
    "filesystem": {
      "command": "node",
      "args": [
<EMAIL_ADDRESS>        "c:/"
      ]
    },
    "memory": {
      "command": "node",
      "args": [
<EMAIL_ADDRESS>      ]
    },
    "git": {
      "command": "uvx",
      "args": [
        "mcp-server-git",
        "--repository",
        "C:/Users/YOUR_USERNAME/Projects/NodeJs/super_ai_agents"
      ]
    },
    "brave-search": {
      "command": "node",
      "args": [
<EMAIL_ADDRESS>      ],
      "env": {
        "BRAVE_API_KEY": "YOUR_BRAVE_API_KEY"
      }
    },
    "github": {
      "command": "node",
      "args": [
<EMAIL_ADDRESS>      ],
      "env": {
        "GITHUB_PERSONAL_ACCESS_TOKEN": "YOUR_GITHUB_TOKEN"
      }
    }
  }
}

Note: Replace YOUR_USERNAME, YOUR_BRAVE_API_KEY, and YOUR_GITHUB_TOKEN with your actual values.

This worked for me almost. I just had to replace my local /node_modules/@modelcontextprotocol location. It wasn't the same place as this because I have NVM installed and it was off the NVM directory.
BUT NOW IT WORKS!!!!!!!~ THANK YOU EVERYONE

OMG, just as I got it fixed there is a new version of Claude desktop. Lets go back to the original *config.json and see if it works without the explicit location notation.

yeah, at least for me, the new update has fixed my connection issue

I'm also experiencing issues with the filesystem server on Windows. Here's my configuration:
{
  "mcpServers": {
    "filesystem": {
      "command": "npx",
      "args": [
        "-y",
        "@modelcontextprotocol/server-filesystem",
        "C:\\Users\\Username\\Desktop"
      ]
    }
  }
}

The same problem with me. My configuration :
{
    "mcpServers": {
        "filesystem": {
            "command": "npx",
            "args": [
                "-y",
                "@modelcontextprotocol/server-filesystem",
                "A:\\Desktop\\"
            ]
        }
    }
}

Same problem on my Win 11. Sad!

I'm also experiencing issues with the filesystem server on Windows. Here's my configuration:
{
  "mcpServers": {
    "filesystem": {
      "command": "npx",
      "args": [
        "-y",
        "@modelcontextprotocol/server-filesystem",
        "C:\\Users\\Username\\Desktop"
      ]
    }
  }
}

The same problem with me. My configuration :
{
    "mcpServers": {
        "filesystem": {
            "command": "npx",
            "args": [
                "-y",
                "@modelcontextprotocol/server-filesystem",
                "A:\\Desktop\\"
            ]
        }
    }
}

Same problem on my Win 11. Sad!

Did you get ANY of the other MCP servers to connect to ClaudeDesktop? Meaning, do you see the tool icon element in the lower right corner of the prompt box area. Are you able to execute any MCP specific actions?

Sorry folks, and thanks for your patience! For npx calls in particular, we believe there's an issue with how Claude Desktop is launching subprocesses on Windows, which modelcontextprotocol/typescript-sdk#68 (once integrated) should hopefully fix. 🤞
As a workaround, you should be able to npm install -g the MCP servers you care about, and use node to invoke them directly (instead of npx).

Hi there - is there tutorial on this/ I'm running into the same issue "Error in MCP connection to server github: Error spawn npx ENOENT". I'm a newbie, hoping to configure MCP on Claude AI to explore the features, any help would be appreciated!!

If you are on Windows and comfortable running a PowerShell script, try this for node based servers: https://llmindset.co.uk/resources/mcp-installer/ .

Hi there - thanks for the help! I ran a PowerShell Script and installed
Nodejs but still running into issues - Claude fails to connect to servers,
I'm trying to install the filesystem.
Here's my code and error msg I'm seeing. I'm also not seeing the Tools icon
.... any idea what could have gone wrong?
[image: image.png]
[image: image.png]
On Sun, Dec 29, 2024 at 11:53 PM evalstate @.***> wrote:

If you are on Windows and comfortable running a PowerShell script, try
this for node based servers:
https://llmindset.co.uk/resources/mcp-installer/ .
—
Reply to this email directly, view it on GitHub
https://github.com/modelcontextprotocol/servers/issues/40#issuecomment-2565136004,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXHY7K7MOMYLOPJCLEWJJXT2ID3VXAVCNFSM6AAAAABSO4TCKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRVGEZTMMBQGQ
.
You are receiving this because you commented.Message ID:
@.***>

If you are on Windows and comfortable running a PowerShell script, try this for node based servers: https://llmindset.co.uk/resources/mcp-installer/ .

Hi there - thanks for the help! I ran a PowerShell Script and installed
Nodejs but still running into issues - Claude fails to connect to servers,
I'm trying to install the filesystem.
Here's my code and error msg I'm seeing. I'm also not seeing the Tools icon
.... any idea what could have gone wrong?

Remove the "-y" argument.

Sorry -- just wanted to add...
If you ran the powershell script (and server-filesystem wasn't already there) then it should look something like:
...

    "server-filesystem": {
      "command": "node",
      "args": [
        "C:\\Program<EMAIL_ADDRESS>      ]
    }

...

To add those folders you would end up with a config like:
{
  "mcpServers": {
    "server-filesystem": {
      "command": "node",
      "args": [
        "C:\\Program<EMAIL_ADDRESS>        "/Users/meizh/Desktop",
        "/Users/meizh/Documents"
      ]
    }
  }
}

Thank you!! still.... not sure what's causing it.... see screenshot. I followed your code

Since it's the only server you have configured, here's what I'd do (i've just tested this from scratch).

Rename your claude_desktop_config.json file to claude_desktop_config.old
Open PowerShell, and download the script from earlier to a folder
Run Set-ExecutionPolicy Bypass -Scope Process in powershell
Run  .\mcp-install.ps1 @modelcontextprotocol/server-filesystem
Edit your claude_desktop_config.json folder and add the folders you want to use (don't forget to add a comma after the first argument).
Start Claude and enjoy.

If that still doesn't work, paste the content of the Logs folder in here.

Hm... may I doing something wrong?

Since it's the only server you have configured, here's what I'd do (i've just tested this from scratch).

Rename your claude_desktop_config.json file to claude_desktop_config.old
Open PowerShell, and download the script from earlier to a folder
Run Set-ExecutionPolicy Bypass -Scope Process in powershell
Run  .\mcp-install.ps1 @modelcontextprotocol/server-filesystem
Edit your claude_desktop_config.json folder and add the folders you want to use (don't forget to add a comma after the first argument).
Start Claude and enjoy.

If that still doesn't work, paste the content of the Logs folder in here.

Sure, I wouldn't run that from system32.
From there I would:

cd ~ -> (takes you to home folder)
curl https://llmindset.co.uk/scripts/mcp-install.ps1 > mcp-install.ps1 -> (downloads and save the install script to your home folder)
.\mcp-install.ps1 @modelcontextprotocol/server-filesystem -> (installs the server)

Once that's done, you can then edit the claude_desktop_config file to add the folders you want to use.

Edit bump

Sure, I wouldn't run that from system32.
From there I would:

cd ~ -> (takes you to home folder)
curl -o mcp-install.ps1 https://llmindset.co.uk/scripts/mcp-install.ps1 -> (downloads and save the install script to your home folder)
.\mcp-install.ps1 @modelcontextprotocol/server-filesystem -> (installs the server)

Once that's done, you can then edit the claude_desktop_config file to add the folders you want to use.
[EDITED - I messed up the curl command, sorry]

Thank you for your relentless efforts trying to help :))))...btw Happy 2025~~~
I tried what you've recommended, still no luck, here's the code, not sure i've done something wrong, apprecaite any insight you might have :)
Before I ran the Pwershell Script, I made sure i'm running from system64 tho it says system32 - reason why it's saying system32 is because "On bit64 Windows The folder C:\Windows\System32\ actually holds 64-bit system files - according to ChatGPT".....
I also made sure that the "claude_desktop_config.json" has been renamed to "claude_desktop_config.old".
Here comes the screenshots.....

At this point, a new "claude_desktop_config.json" file has been created in folder C:\Users\meizh\AppData\Roaming\Claude
I opened the json file and saw this script.

I opened Claude to see this error msg

Then I overrode the json script to below... saved and relaunched Claude...

Saw this error msg.... "Could not attach to MCP server server-filesystem"

Side question - it's been a hell of a workaround trying to add one MCP to Claude, is it going to be the same for all other MCP's? I'm also looking to add the Brave Search one....

OK - looks like its nearly there. Go in to settings, developer and click here to open the logs folder.

In there you should find a file called mcp-server-filesystem.log. Show us the contents of that.
For what it's worth, I got my server-filesystem to fail by specifying an invalid path on startup.
Side question:- once this issue is solved, you should be all set :)

OK - looks like its nearly there. Go in to settings, developer and click here to open the logs folder.
In there you should find a file called mcp-server-filesystem.log. Show us the contents of that.
For what it's worth, I got my server-filesystem to fail by specifying an invalid path on startup.
Side question:- once this issue is solved, you should be all set :)

Exciting!!
here's what i have

OK - so the error message makes it look like Claude is reading a claude_desktop_config.json which still has a "-y" in the args section of the Config file... so perhaps there is more than one config file.
Can you re-check what is in the claude_desktop_config.json file by opening it from here:

That will open an explorer window with the file highlighted. Right-click and lets have a look what's in that one.

OK - so the error message makes it look like Claude is reading a claude_desktop_config.json which still has a "-y" in the args section of the Config file... so perhaps there is more than one config file.
Can you re-check what is in the claude_desktop_config.json file by opening it from here:

That will open an explorer window with the file highlighted. Right-click, open in notepad or vscode and lets have a look what's in that specific one.

Sure thing.
I clicked on "Edit Config" and was redicted to C:\Users\meizh\AppData\Roaming\Claude
I then opened "claude_desktop_config.json"
this is what i have (pretty sure i took the -y out):

🤔.
OK. Can you go back to the logs folder, delete all the files in there, restart Claude Desktop and then see what's there? Perhaps we are looking at a stale log file with the old config in.
Claude is still giving the error message, right?
:)

🤔.
OK. Can you go back to the logs folder, delete all the files in there, restart Claude Desktop and then see what's there? Perhaps we are looking at a stale log file with the old config in.
Claude is still giving the error message, right?
:)

Yep - still the same error.
okay - i deleted all files in "logs" folder and relaunched Claude same error

However now in the logs folder I only see 2 files?

Is there any content in either of them?

Is there any content in either of them?

yep

Cool. So we know that Node.js is installed and running.
The error message in the log file is saying it can't find the server-filesystem MCP Server code (which is odd because npm should have downloaded it earlier).
Let's check 2 things before going further:
Go back to powershell and run the following:
node --version
Should return v22.12.0
Then run: npm root -g
This will show us the download directory - it should come back c:\program files\nodejs\node_modules. I'm wondering if you are on a virtual desktop environment?

I'm not on a virtual machine but here's the result......


Optimize slow bottleneck tests of TestDaemonIPv6FixedCIDR

This covers TestDaemonIPv6FixedCIDR and TestDaemonIPv6FixedCIDRAndMac
Tests results:
PASS: docker_cli_daemon_test.go:338: DockerDaemonSuite.TestDaemonIPv6FixedCIDR	1.514s
PASS: docker_cli_daemon_test.go:380: DockerDaemonSuite.TestDaemonIPv6FixedCIDRAndMac	1.384s
OK: 2 passed

Related issue #19425
Signed-off-by: Wen Cheng Ma<EMAIL_ADDRESS>

@tiborvass  PTAL

Couple of minor nits.
LGTM. Also nice catch on this speedup!

@cpuguy83  already addressed your comments, very helpful, thanks

LGTM. Thanks!


[BUG] test_func_wrapper - test_add is unprocessable

In a container, with pytest-benchmark installed, python 3.10.13
pytest test_func_wrapper.py
================================= test session starts =================================
platform linux -- Python 3.10.13, pytest-7.4.3, pluggy-1.3.0
benchmark: 4.0.0 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
rootdir: /usr/src/swarm_cloud/tests
plugins: benchmark-4.0.0, time-machine-2.13.0, anyio-3.7.1
collected 17 items

test_func_wrapper.py .FF..FFFFFFFFFFFF                                          [100%]

====================================== FAILURES =======================================
______________________________________ test_add _______________________________________

func_api_wrapper = <swarms_cloud.func_api_wrapper.SwarmCloud object at 0x7fa99d45a3b0>

    def test_add(func_api_wrapper):
        @func_api_wrapper.add("/test", method="get")
        def test_endpoint():
            return {"message": "test"}

        client = TestClient(func_api_wrapper.app)
        response = client.get("/test")
>       assert response.status_code == 200
E       assert 422 == 200
E        +  where 422 = <Response [422 Unprocessable Entity]>.status_code

test_func_wrapper.py:37: AssertionError

This error is occurring because the response to the request failed with error 422,  not 200 (success).
The response code 422 says the endpoint is up, the request is properly formatted, but the server doesn't know what to do with it (https://httpwg.org/specs/rfc9110.html#status.422)
"15.5.21. 422 Unprocessable Content
The 422 (Unprocessable Content) status code indicates that the server understands the content type of the request content (hence a 415 (Unsupported Media Type) status code is inappropriate), and the syntax of the request content is correct, but it was unable to process the contained instructions."
That suggest to me, that this test, as written, is incomplete, because the request content isn't processable by the endpoint.
Either delete this test, or make sure the content is processable.

test_add_post is failing in the same way:
____________________________________ test_add_post ____________________________________

func_api_wrapper = <swarms_cloud.func_api_wrapper.SwarmCloud object at 0x7fa99c94a6e0>

    def test_add_post(func_api_wrapper):
        @func_api_wrapper.add("/test_post", method="post")
        def test_post_endpoint():
            return {"message": "test_post"}

        client = TestClient(func_api_wrapper.app)
        response = client.post("/test_post")
>       assert response.status_code == 200
E       assert 422 == 200
E        +  where 422 = <Response [422 Unprocessable Entity]>.status_code

test_func_wrapper.py:70: AssertionError


[B11] Alchemical Metallurgy Missing Title

Title for the requirements of Alchemical Metallurgy 3/5 is missing,

that is currently still A work in prgress


usecases

still not sure we need pub/sub here... what are the usecases?
for now this is used to send emails, right? as long as there is no other usecase, we can send emails here directly...

Yep I'm just using it to send email notifications. The only advantage for me was that with 1 publish it would send to all subscribers so it's a bit easier to manage in case we have multiple people that needs this kind of information (for now it's only me for testing and Juliane that are subscribed)

yeah, in the end this should be a setting in our user table, so you would just get all user with a specific key set from ES and send the email to them...

Should I updated this to work with sendemail and start building a user table that we can then also use for our passwordless authentication via email?
I can also implement the passwordless flow if you're decided to go for this

Should I update this to work with sendemail then and start building a user table that we can use for our passwordless authentication via email?

yes

I can also implement the passwordless flow if you're decided to go for this

not yet

Alright I made the switch to use sendmail instead.
You can see the PR here

Closing this now, PR has been approved and merged a while ago, just forgot to close the issue.


Error: couldn't create connection to LSP server

Describe the bug
When I open the SPM project through VScode, a message indicating that the LSP cannot be connected is displayed.
Log:
[Error - 下午8:50:46] SourceKit Language Server client: couldn't create connection to server.
Launching server using command /usr/bin/sourcekit-lsp failed. Error: spawn /usr/bin/sourcekit-lsp ENOENT

Expected behavior
A clear and concise description of what you expected to happen.
Environment

OS:  Ubuntu 20.04

Swift version: swift-5.7.3-RELEASE

Visual Studio Code version: 1.76.0

vscode-swift version: v1.1.0

Additional context
Add any other context about the problem here.

This appears to be related to how you installed Swift. Can you give us some info about how you installed swift and the folder structure of your swift installation. Eg where is your sourcekit-lsp executable in relation to your swift exe.

This appears to be related to how you installed Swift. Can you give us some info about how you installed swift and the folder structure of your swift installation. Eg where is your sourcekit-lsp executable in relation to your swift exe.

sourcekit-lsp is from swift 5.7.3 release, this only seems to occur when Remote SSH is done on M1, everything is fine on Intel

Everything worked fine after I reinstalled VSCode-Universal (old version: Apple Silicon)


Compare changes very slowly!

Gitea version (or commit ref): 1.4.1
Git version: 2.1
Operating system:
Database (use [x]):

[ ] PostgreSQL
[ x] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[x ] Not relevant

Log gist:

Description
When create new pull request,  compare two branches very slowly, result to nginx timeout (┬＿┬).
How can i do some optimization?
Screenshots

I'm using gitea over two weeks running on a t2.small instance. I'm using docker image version 1.4.0 with postgres 9.6 and Git 2.15.0 and nginx as inversed proxy and I'm impress of the performance all is very quickly (I've migrated from gitlab)
here's my docker-compose.yml
version: "3"

networks:
  gitea_app:
    external: false

services:
  gitea_app:
    image: gitea/gitea:1.4.0
    environment:
      - SSH_DOMAIN=yourdomain.com
      - ROOT_URL=https://git.yourdomain.com
      - USER_UID=1000
      - USER_GID=1000
      - RUN_MODE=prod
      - DB_TYPE=postgres
      - DB_HOST=gitea_postgres
      - DB_NAME=gitea
      - DB_USER=gitea
      - DB_PASSWD=gitea
    restart: always
    networks:
      - gitea_app
    volumes:
      - ./gitea_app_data:/data
    ports:
      - "3000:3000"
      - "22:22"
    depends_on:
      - gitea_postgres
  gitea_postgres:
    image: postgres:9.6
    restart: always
    environment:
      - POSTGRES_USER=gitea
      - POSTGRES_PASSWORD=gitea
      - POSTGRES_DB=gitea
    networks:
      - gitea_app
    volumes:
      - ./gitea_postgres_data:/var/lib/postgresql/data
  gitea_web:
    image: nginx:alpine
    restart: always
    volumes:
      - ./gitea_web_data:/etc/nginx/conf.d
      - ./gitea_web_data/cache:/cache
    ports:
      - "80:80"
      - "443:443"
    networks:
      - gitea_app
    depends_on:
      - gitea_app

the only optimization I did was add some cache for static resources on nginx, but nothing more

@misterpoesy need more details.

In my case is a little slow too, repo is very big, an solution is add gauge/loading image for feedback to user. It's possible?
If yes, is good add too in apply merge pull request, what is very slow too e no exixsts feedback to user, only the loading in the browser title.

My browser freezes up when comparing too many commits(200+) for PR. Is it related to this issue?
Can we hide all the code changes?

@webjoel Thanks a lot. Issue #601 is my problem.

#601

My repo size is: 1,8 GB.

@webjoel oof looks like a job for https://rtyley.github.io/bfg-repo-cleaner/


libcrhomiumcontent and read/write files

Hi,
I'm trying to modify webrtc part and I need to know if webrtc is able to read/write files.
thank you for your help
Angelo

Thanks for reaching out!
Because we treat our issues list as the team's backlog, we close issues that are questions since they don't represent a task needing to be completed. For most questions about Electron there are a lot of options.
Check out the Electron community. There are also a bunch of helpful people at this community forum that should be willing to point you in the right direction.


[Communication - SMS] Deploy test resources failing in nightly runs

Communication - SMS nightly test runs are failing with:

Error message:
VERBOSE: Running registered exit actions
VERBOSE: Logging out of service principal 'd34b39f7-c9a4-48a9-8b8c-e44479f88286'
VERBOSE: Performing the operation "New-TestResources.ps1" on target "d34b39f7-c9a4-48a9-8b8c-e44479f88286".
Retry : Exception calling "Invoke" with "0" argument(s): "The running command stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop: Creating the resource group 'rg-communication-t431e0f3c23c943bd' would exceed the quota of '980'. The current resource group count is '980', please delete some groups before creating a new one.
StatusCode: 409
ReasonPhrase: Conflict
OperationID : 1c6f54f3-15ff-4c69-957a-b46983313a75"
At D:\a_work\1\s\eng\common\TestResources\New-TestResources.ps1:560 char:22
$resourceGroup = Retry {
~~~~~~~
CategoryInfo          : NotSpecified: (:) [Write-Error], MethodInvocationException
FullyQualifiedErrorId : ActionPreferenceStopException,Retry
##[error]PowerShell exited with code '1'.

For more details check here:

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1791582&view=results

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'EngSys:0.23994598,Communication:0.20076162,ARM:0.085217275'


chore(release): 2.35.0

See CHANGELOG

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 751d397fa49ad8889ef936aa2ca56c8438de1fc8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Use std sync primitives instead of parking_lot

Greetings!
Since 1.62 rust start to use sync primitives based on futex (unstead of pthreads) in */Linux systems and it become equal (or faster in some cases) by speed with parking_lot.
We can save "poison" behaviour from parking_lot by this:
    use std::sync::{PoisonError, RwLockReadGuard, RwLockWriteGuard};

    pub(crate) struct RwLock<T>(std::sync::RwLock<T>);

    impl<T> RwLock<T> {
        #[inline]
        pub(crate) fn new(t: T) -> Self {
            Self(std::sync::RwLock::new(t))
        }

        #[inline]
        pub(crate) fn read(&self) -> RwLockReadGuard<T> {
            self.0.read().unwrap_or_else(PoisonError::into_inner)
        }

        #[inline]
        pub(crate) fn write(&self) -> RwLockWriteGuard<T> {
            self.0.write().unwrap_or_else(PoisonError::into_inner)
        }
    }

But the problem is that minimal rust version in yours crates is 1.56.1 and if someone use older compiler version speed will degradate.
In some crates I can add parking_lot as optional:
diff --git a/metrics-exporter-prometheus/Cargo.toml b/metrics-exporter-prometheus/Cargo.toml
index e24aaf2..e6160ea 100644
--- a/metrics-exporter-prometheus/Cargo.toml
+++ b/metrics-exporter-prometheus/Cargo.toml
@@ -17,7 +17,7 @@ categories = ["development-tools::debugging"]
 keywords = ["metrics", "telemetry", "prometheus"]

 [features]
-default = ["http-listener", "push-gateway"]
+default = ["http-listener", "push-gateway", "parking_lot"]
 async-runtime = ["tokio", "hyper"]
 http-listener = ["async-runtime", "hyper/server", "ipnet"]
 push-gateway = ["async-runtime", "hyper/client", "tracing"]
@@ -25,7 +25,7 @@ push-gateway = ["async-runtime", "hyper/client", "tracing"]
 [dependencies]
 metrics = { version = "^0.20", path = "../metrics" }
 metrics-util = { version = "^0.14", path = "../metrics-util", default-features = false, features = ["recency", "registry", "summary"] }
-parking_lot = { version = "0.12", default-features = false }
+parking_lot = { version = "0.12", optional = true, default-features = false }
 thiserror = { version = "1", default-features = false }
 quanta = { version = "0.10.0", default-features = false }
 indexmap = { version = "1", default-features = false }
diff --git a/metrics-exporter-prometheus/src/builder.rs b/metrics-exporter-prometheus/src/builder.rs
index 2e5bd6c..2db688a 100644
--- a/metrics-exporter-prometheus/src/builder.rs
+++ b/metrics-exporter-prometheus/src/builder.rs
@@ -31,7 +31,6 @@ use hyper::{
 use indexmap::IndexMap;
 #[cfg(feature = "http-listener")]
 use ipnet::IpNet;
-use parking_lot::RwLock;
 use quanta::Clock;
 #[cfg(any(feature = "http-listener", feature = "push-gateway"))]
 use tokio::runtime;
@@ -48,6 +47,7 @@ use crate::common::Matcher;
 use crate::distribution::DistributionBuilder;
 use crate::recorder::{Inner, PrometheusRecorder};
 use crate::registry::AtomicStorage;
+use crate::sync::RwLock;
 use crate::{common::BuildError, PrometheusHandle};

 #[cfg(any(feature = "http-listener", feature = "push-gateway"))]
@@ -480,7 +480,7 @@ impl PrometheusBuilder {
                                     let body = body
                                         .map_err(|_| ())
                                         .map(|mut b| b.copy_to_bytes(b.remaining()))
-                                        .map(|b| (&b[..]).to_vec())
+                                        .map(|b| (b[..]).to_vec())
                                         .and_then(|s| String::from_utf8(s).map_err(|_| ()))
                                         .unwrap_or_else(|_| {
                                             String::from("<failed to read response body>")
diff --git a/metrics-exporter-prometheus/src/lib.rs b/metrics-exporter-prometheus/src/lib.rs
index 399d942..e19dcd9 100644
--- a/metrics-exporter-prometheus/src/lib.rs
+++ b/metrics-exporter-prometheus/src/lib.rs
@@ -113,5 +113,6 @@ pub mod formatting;
 mod recorder;

 mod registry;
+mod sync;

 pub use self::recorder::{PrometheusHandle, PrometheusRecorder};
diff --git a/metrics-exporter-prometheus/src/recorder.rs b/metrics-exporter-prometheus/src/recorder.rs
index 6d746df..223969b 100644
--- a/metrics-exporter-prometheus/src/recorder.rs
+++ b/metrics-exporter-prometheus/src/recorder.rs
@@ -5,7 +5,6 @@ use std::sync::Arc;
 use indexmap::IndexMap;
 use metrics::{Counter, Gauge, Histogram, Key, KeyName, Recorder, SharedString, Unit};
 use metrics_util::registry::{Recency, Registry};
-use parking_lot::RwLock;
 use quanta::Instant;

 use crate::common::Snapshot;
@@ -14,6 +13,7 @@ use crate::formatting::{
     key_to_parts, sanitize_metric_name, write_help_line, write_metric_line, write_type_line,
 };
 use crate::registry::GenerationalAtomicStorage;
+use crate::sync::RwLock;

 pub(crate) struct Inner {
     pub registry: Registry<Key, GenerationalAtomicStorage>,
diff --git a/metrics-exporter-prometheus/src/sync.rs b/metrics-exporter-prometheus/src/sync.rs
index e69de29..dfb3b8d 100644
--- a/metrics-exporter-prometheus/src/sync.rs
+++ b/metrics-exporter-prometheus/src/sync.rs
@@ -0,0 +1,29 @@
+#[cfg(feature = "parking_lot")]
+pub(crate) use parking_lot::RwLock;
+
+#[cfg(not(feature = "parking_lot"))]
+mod std_mutex {
+    use std::sync::{PoisonError, RwLockReadGuard, RwLockWriteGuard};
+
+    pub(crate) struct RwLock<T>(std::sync::RwLock<T>);
+
+    impl<T> RwLock<T> {
+        #[inline]
+        pub(crate) fn new(t: T) -> Self {
+            Self(std::sync::RwLock::new(t))
+        }
+
+        #[inline]
+        pub(crate) fn read(&self) -> RwLockReadGuard<T> {
+            self.0.read().unwrap_or_else(PoisonError::into_inner)
+        }
+
+        #[inline]
+        pub(crate) fn write(&self) -> RwLockWriteGuard<T> {
+            self.0.write().unwrap_or_else(PoisonError::into_inner)
+        }
+    }
+}
+
+#[cfg(not(feature = "parking_lot"))]
+pub(crate) use std_mutex::*;

But in some crates it already optional hidden by different flag, like in metrics-util:
recency = ["parking_lot", "registry", "quanta"]

and I can't make usage of std sync primitive by flag and save old behaviour.
I see only 3 ways:

remove parking_lot deps;
use std sync primitives by default and make usage of parking_lot optional;
doesn't bore at all and continue to use parking_lot;

But I want to remove extra deps and option 3 isn't acceptable personally for me =)
Any thoughts on this case?

@BratSinot I'd be OK with removing the parking_lot dependency entirely. I mostly only ever used it because I disliked the additional result handling introduced by handling poisoned lock errors... but it's probably worth just adding a wrapper like you suggested (or something else) and using the stdlib version to reduce the number of dependencies, especially given the idea of pushing towards 1.0.


feat: os independent venv activation on code-style action

Closes #400
Could you give it a try to this branch @Andy-Grigg?

Hey @Andy-Grigg - I gave it a try here: https://github.com/ansys/openapi-common/pull/483/commits/c7ae94d0e09a583490c1be7526f07c7e44613137
Looks like it's working properly now so I will merge this as soon as it gets approved and I will do a patch release right after. This should solve your issues.

I'm not sure to understand why these changes are needed after what was performed in #400.
Since the steps use shell: bash, shouldn't that do the trick for all OS ?
From what I see with @Andy-Grigg CI this information is not leveraged in the custom code-style workflow. Might give a try to the main version of ansys/actions ?


Why using restyle e4e latent instead of hyperstyle latent when running domain adaptation?

Hi, first of all, thank you very much for this awesome project!
I have a question about the domain adaptation task.
If my understanding is correct, you load the nets from restyle e4e in the scripts/run_domain_adaptation.py script.
This model is then used to get the latent image, from which you will generate the final image after domain adaptation.
My question is the following: after running some tests, the latent from Hyperstyle seems to be more faithful to the original image than the latent from restyle e4e, so why do you use the latent from restyle and not the Hyperstyle one?
Is there a reason to prefer the latent from restyle e4e for the domain adaptation task?
Thank you for your answer.

By HyperStyle's latent, I assume you mean the latent that you get from the WEncoder?

@yuval-alaluf by HyperStyle's latent, I mean the second object that is returned by your call to the run_inversion() function.
If I am not mistaken, this function returns 4 values, the fourth (codes) corresponding to the latent from WEncoder that is used to initialize the latent object in the forward() function of your Hyperstyle net; while the second value (result_latent) is the latent generated by Hyperstyle after the weights of the generator have been updated by the hypernetwork.
So I mean the latter, the latent that is retrieved by the inversion task (the latent representation of the image given by your inference script).

The tuple here may be a bit confusing:
y_hat, latent, weights_deltas, codes

In the end, latent and codes is the same thing. HyperStyle doesn't alter the latent code itself and only alters the weights of the generator. Therefore, HyperStyle's latents are just the WEncoder latents. That is, HyperStyle uses the same latent as the WEncoder in order to achieve its final reconstructions.
Therefore, to answer your question regarding why we chose to use the ReStyle-e4e latents instead of the WEncoder latents, it is simply because we found that it leads to slightly more accurate transformations. This is because ReStyle-e4e achieves better reconstructions compared to the vanilla WEncoder.

I understand now, thank you for your time and answer!


Open public discussion on rebasing minting to QAP

eta: 2022-12-31
As QAP begins to substantially outpace raw byte power, it will be necessary to assess and pass a FIP to rebase minting to QAP. To support this we will open a FIP discussion and release a report on our research.

initial analysis from @kkarrancsu : https://hackmd.io/dkDM1UVYT7aAsWkb1uegJg?view


problem including third party css

I have tried doing require('css-loader!./assets/css/bootstrap.css') in main.js.
The bootstrap is there in the app.js (output of webpack), but styles do not get applied to any components.
any help? I must be missing something.

I thought it's due to ordering, so I did a separate entry for vendors and require bootstrap inside vendors.js.
But it's still not working, again, I can see bootstrap inside vendors.js

Basically this template is not configured to import CSS outside of .vue component.
You can edit config to add your custom loader
      {
        test: /\.css$/,
        loaders: ['style', 'css']
      },

Someone is working on this apparently :) https://github.com/vuejs-templates/webpack/pull/81

thanks @Grafikart, your pr works perfectly


add arch dependency: hyprwayland-scanner

it's not yet in the repos, though.

But literally few lines below it is the line to clone latest git... I's bit confusing.

I've added it to instructions already


Eliminate some of the more esoteric pylint suppressions for tests

Progress toward #261 on grpc_tests package starting by the most dangerous suppressions. PR contains actual bugfixes.

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[microbenchmarks] No significant performance differences

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[trickle] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

[microbenchmarks] No significant performance differences

[microbenchmarks] No significant performance differences

[microbenchmarks] No significant performance differences

[microbenchmarks] No significant performance differences

[microbenchmarks] No significant performance differences

Test failures: All known C#, Obj-C infra, interop failures and flakes

****************************************************************

libgrpc.so

     VM SIZE                                            FILE SIZE
 ++++++++++++++ GROWING                              ++++++++++++++

 -------------- SHRINKING                            --------------
  -0.2% -1.13Ki [None]                               -2.92Ki  -0.0%
      -0.2% -1.04Ki [Unmapped]                           -2.89Ki  -0.0%
      -3.3%     -40 [None]                                     0  [ = ]
      [DEL]     -24 grpc_handshaker_trace                      0  [ = ]
     -25.0%      -8 fail_handshaker_vtable                    -8 -25.0%
     -25.0%      -8 security_handshaker_vtable                -8 -25.0%
     -25.0%      -8 http_connect_handshaker_vtable            -8 -25.0%
 -24.7%    -560 src/core/lib/channel/handshaker.cc      -560 -24.7%
     -67.2%    -415 call_next_handshaker_locked             -415 -67.2%
     -38.6%     -83 grpc_handshake_manager_add               -83 -38.6%
      [DEL]     -48 _GLOBAL__sub_I_handshaker.cc             -48  [DEL]
      [DEL]      -8 grpc_handshaker_name                      -8  [DEL]
      -4.9%      -6 [Unmapped]                                -6  -4.9%
  -8.0%    -326 src/core/lib/channel/channel_args.cc    -326  -8.0%
      [DEL]    -316 grpc_channel_args_string                -316  [DEL]
      -5.4%     -10 [Unmapped]                               -10  -5.4%

  -0.1% -1.99Ki TOTAL                                -3.78Ki  -0.0%

****************************************************************

libgrpc++.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]     +40  +0.0%

  [ = ]       0 TOTAL      +40  +0.0%

PTAL

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

[microbenchmarks] No significant performance differences


Configuring default_user and default_pass in rabbitmq.config  is insecure

rabbitmq.config template file contains default_user and default_pass which are plain text, it is going to  be a security risk.
{default_user, <<"<%= node['rabbitmq']['default_user'] %>">>},
{default_pass, <<"<%= node['rabbitmq']['default_pass'] %>">>}
In my opinion, we should remove the two configuration items.

@wenchma Do you still need a fix for this?

@cmluciano yes, I still need a fix, these two attributes should be only stored in rabbitmq db, not exposed in the conf file.

@wenchma Does #237 work for you?

@cmluciano and @wenchma seriously it's a clever fix. works for me ;)

Fix provided by #237 closing now due to inactivity


Console commands

Adds option to execute commands and message after server start ( i don't think Sleep method i used is good right way to do that )
Commands: "help" - displays availiable commands, "quit" and "shutdown" - shutting down server.

@CrosRoad95, your console class and logic is still part of MtaServer.Server, this is not how that project was designed. Server does not necessarily have a console at all, therefore having that functionality doesn't make sense. Instead, move everything you have there to MtaServer.Console, which is actually a console instance of the MTA server, and thus where it belongs :)

I'll close this for now, if you feel like picking it up again just let me know.


Replace Ava by Vitest

Motivation: #175

Reduce the time of the tests by half.
No need to copy fixtures folder to dist folder.
Watch mode and coverage.

Would this allow to build in watch mode, too?

Would this allow to build in watch mode, too?

Yes, but it need a small modification for the chmod, I'll do that tomorrow.

I think this should have been discussed in an issue first.

Using ts-node could probably have achieved the same thing in a few lines of code without rewriting everything.

My concern with switching test runner is that most test runners do too much, which means a lot of bugs. I personally saw this when Jest became popular. It solved a lot of real use-cases true, but it also caused a lot of annoyance by being super buggy. I generally prefer simplicity. However, this is not my repo, so I'm not the one you have to convince.


kubelet: Move KillContainer to container runtime.

Rename KillContainerID(string) with KillContainer(string).
Delete the old KillContainer(*kubecontainer.Container).

@vmarmol @dchen1107 @bakins

LGTM

LGTM. Thanks!


Backport "HBASE-28642 Hide old PR comments when posting new (#5967)" to branch-3

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
shelldocs
0m  0s

Shelldocs was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ branch-3 Compile Tests _

+0 :ok:
mvndep
0m  7s

Maven dependency ordering for branch

+1 :green_heart:
spotless
0m 41s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  5s

Maven dependency ordering for patch

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
shellcheck
0m  0s

No new issues.

+1 :green_heart:
spotless
0m 40s

patch has no errors when running spotless:check.