Support more types of values in the generator

Currently supported:

[x] plain objects
[x] futures
[x] class variants of the above two

Currently unsupported type:

[ ] Streams
[ ] legacy object types (StateNotifier/ChangeNotifier)

It'd be nice to support:
@riverpod
Stream<T> example(ExampleRef ref) { ...
}

@riverpod
class Example
  Stream<T> example(ExampleRef ref) { ...
  }
}

And for the sake of migration, we could also support:
@riverpod
Counter counter(CounterRef) => Counter();

class Counter extends StateNotifier/ChangeNotifier {
...
}

I've been using StateNotifier a lot, may I ask if it's marked as legacy, what its replacement will be with the riverpod codegen?

It's annotating @riverpod on a class with a build method

I noticed that annotating:
@riverpod
Stream<Foo>  getFooStream(..)

Results in code generation where the Stream type (Foo) gets lost and replaced with Stream<dynamic>
Or am I doing it wrong?

That's unlikely. You're likely doing something else that causes this, but haven't included the revelant about what's going on
For example maybe "Foo" is a generated class.

I am generating some classes for firestore odm. I'll see if I can create a reporoducible example.

I have not yet created a standalone example, but if it helps,  the Stream class is being generated from my model by the firestore ODM generator:
@riverpod
Stream<EventQuerySnapshot> currentEvents(CurrentEventsRef ref, {DateTime? dateTime,
            List<EventCategory> categoryFilter = const [] }) {
    var db = ref.watch(databaseProvider);
    return db.getCurrentEventStream(date: dateTime, categoryFilter:categoryFilter );
}

In the above, EventQuerySnapshot is generated via @firestoreSerializable annotation on my Event  class.
So this has something to do with the order in which annotations are processed by build runner?

Ah yes, you can't do that unfortunately.

I'll see if generated types can be supported. It probably should be doable with a reasonable amount of work.
Although the true fix would be static metaprogramming.

This isn't a show stopper for me, so If you prefer to wait for static metaprogramming that's cool ;-)

@rrousselGit When you add support for stream providers with code gen, can you maybe also add a flag to the annotation that treats the return types of the annotated functions like any other class? So for example
@Riverpod(rawTypes: true)
Stream<String> eventStream(EventStreamRef ref) => ...;

would generate a Provider<Stream<String>> and not a StreamProvider<String>. The same would hold for futures.
I have found myself needing that because I want to provide a stream of events, so a StreamProvider holding the newest event doesn't make sense. Also the same event could be triggered twice, which would prevent an update if StreamProvider would be used.

I don't think I'll add support for the "old" StateNotifier/ChangeNotifier types.
You should use the @riverpod class syntax anyway
It does make the migration a bit more painful, but long term it's better I think. Otherwise people likely would keep using StateNotifier/CHangeNotifier with the generator when they should use the class syntax
But support for @riverpod Stream<T> fn() & a class variant is coming

But support for @riverpod Stream<T> fn() & a class variant is coming

Any eta for this? We're starting a new client project so keen to know, thanks!

It’s already available on the 2.3.0 release in pub. Thanks @rrousselGit !

oh sweet! note to self; check pub.dev first.... ;-0

@arnab  It can't be, why don't I know about it? I'm just using version 2.3. And there is no mention of this in the documentation. Can you show where you found out about this?

@Pingear see the 2.3.0 release notes: https://github.com/rrousselGit/riverpod/blob/master/packages/riverpod/CHANGELOG.md
If you are using that version, just add @riverpod like it shows there. I’m using it already (but it’s not an open source app, so can’t link here).

@arnab As far as I understand, now the code generation can be considered complete, since it covers all the types of providers necessary for work. It's strange that no one has announced this)
So this is really cool!!

@rrousselGit I am trying to create provider to get GoRouter instance, which is extending ChangeNotifier. From the lint warning, I understood that I am doing something wrong. But I didn't understood what is the correct approach. Please help me out.
Lint warning: The riverpod_generator package does not support ChangeNotifier

The lint is only here to tell you that the GoRouter won't be disposed and that changes won't be listened.
If you don't care, you can ignore the lint here

@rrousselGit As ChangeNotifier was mentioned as Legacy, may I know its alternative in flutter? As many third party packages i am using are still extending with ChangeNotifier.

I will offer a more official way to silence the lint in scenarios where this is voluntary.
It's landing very soon.


Broken Github links

The two links in this sentence point to resources on GitHub that don't appear to exist. I've tried searching GitHub for them and cannot find them so either the links are bad or they no longer exist.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d1b75396-5714-d2f5-8b9f-2a0a32dbce8c
Version Independent ID: ec183ab1-43d9-0a58-8caf-8a3541f49528
Content: Cross-domain images in SharePoint provider-hosted add-ins
Content Source: docs/solution-guidance/cross-domain-images-in-sharepoint-provider-hosted-add-ins.md
Product: sharepoint
GitHub Login: @VesaJuvonen
Microsoft Alias: vesaj

thx @stev3reed for submitting this issue. We have updated the doc with the fixed links.


Editor has visual issues on Firefox

As seen in the above image icons in the default and in the matchers are misaligned.
Also, if there is a scroll in the key list then after scrolling the revealed keys have a white background.

Can be closed...


using continuous integration system

@briannakcalkins , @jenajordan , @trogers4,
We now have a fully working continuous integration system! (Big thanks to @ValentineHerr  , @jess-shue, and @rudeboybert!)
We'll still probably want to do some cleanup to make the process smoother/ easier to understand. It's now time to put this to routine use. The instructions for pushing your newly collected data so that it gets checked are here: https://github.com/SCBI-ForestGEO/SCBImortality/blob/main/Protocols/FastField Download forms.md.
We also have an update on census progress: 34% complete. You're making great progress!

Test results are here: https://github.com/SCBI-ForestGEO/SCBImortality/tree/main/testthat. They're not super user-friendly yet, but hopefully functional.
@ValentineHerr and @rudeboybert , we'll want to have some system for tracking the issues that have been caught and fixed, hopefully before our awesome, fast field team starts fixing them!

My immediate solution would be to append the reports to ongoing files that don't get deleted when the issues are fixed.
I'll start working in this now.
Let me know if there is a specific place where would want these files to be, otherwise I'll create a new folder in the reports folder.

OK, now this folder, will be the one where the reports don't gets erased when the issues are solved. So at the end of the census, we can compare the "clean data" with these files.

that's great; thanks!

Teagan, Bri, & I will be at the plot tomorrow - I'll get my 1st attempt at pushing the data.


PMPI: Record times and sizes of sent/received messages

Original issue: https://charm.cs.illinois.edu/redmine/issues/256

Opening this so that the work is visible, both to external users and for internal workload balancing.

Original author: Osman Sarood
Original date: 2013-07-29 21:13:06

I spent sometime understanding the trace-projections code and then added the capability of logging messages along with the msg size and source PEs. The MPI_Main now also shows the message size and source of the message.

Original author: Yanhua Sun
Original date: 2013-07-30 00:02:06

I checked and found that only MPI_Send MPI_Recv is handled.
However, there are more functions about messaging, MPI_ISend, MPI_Irecv
MPI_SSend, .. also MPI_Broadcast, MPI_Reduce, MPI_Gather. MPI_Alltoall.

Original author: Osman Sarood
Original date: 2013-07-30 00:25:52

Yes, it is only done for Send/Recv. I will add the collectives too.

Original author: Osman Sarood
Original date: 2013-07-31 22:01:41

Here is the list of changes I am planning to make:

MPI_Recv: Currently I am adding the '1 5 0...' row in the trace for a message. I think we should only add it for the MPI_Send. For MPI_Recv we only record the msg size and the src rank in the following BEGIN_PROCESSING block.

I will replicate similar behavior for MPI_Isend/MPI_ssend and MPI_Irecv.

MPI_Reduce: record the message send for each process to the root by putting appropriate '1 5 0..' entries. Once the reduction is complete we just record the msg size which is the length of one reduction message (?). What should be the source of this message on the root PE (and other ranks as well)?

MPI_AllReduce: similar to MPI_Reduce but we should have a bunch of sends for each rank for distributing the result which would be reflected in the BEGIN_PROCESSING for each rank after the reduction is complete (that includes msg size and src rank).

MPI_Bcast: These are simply 'n' message sends and receives and should be treated as MPI_Send/MPI_Recvs. We just need to distinguish the root from everyone else.

Original author: Osman Sarood
Original date: 2014-01-24 17:58:24

In order to tack collectives, we need to keep track of all the messages sent by MPI. The underlying MPI implementation might be using hypercube or some other technique for the bcast/multicast. Ideally we should hack what messaging pattern is adopted and record messages as it is.
However, a simpler but imperfect way could be that we just identify the root and the members of communicator (to which the message is being broadcasted) and add a message entry for them. We should also report the message size with it. We need to find out a way of how to access the members of a MPI communicator. I can think of a few ways that requires communication and hence are useless i.e. we might not want to do communication just for logging events. We need to keep in mind that such a mechanism that is just assuming a hypercube or any other technique for the bcast will NOT show the real picture and might have limited utility as it might be showing the incorrect information.
The correct way of going about it is to get the actual pattern in which communication is done for collective and accordingly insert entries into PMPI projections. To do that, we need to figure out a way of detecting the communication pattern for a particular MPI installation.

Original date: 2015-02-11 06:20:20

Passing open Projections Features with non-existent or departed assignees to Ronak for triage and re-assignment.


#1196 ios scenario numbers

Fixes #1196
Checklist

[ ] Documented
[ ] Unit tested

Codecov Report

Merging #1287 into master will decrease coverage by 0.00%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master    #1287      +/-   ##
============================================
- Coverage     79.76%   79.75%   -0.01%
  Complexity      724      724
============================================
  Files           235      235
  Lines          4483     4486       +3
  Branches        768      769       +1
============================================
+ Hits           3576     3578       +2
- Misses          509      510       +1
  Partials        398      398


Getting errors when trying to load code to Nano chip

I am using the ELEGOO NANO (ATmega328P & CH340 chip - I installed the latest drivers on it)
I tried to add the 2.4 GHz Band Scanner & Jammer With NRF24L01 code to the nano via Arduino and I am getting multiple errors.
Errors
——————
C:\Users\Gram\Desktop\Inventions\NRF Wifi Jam\RF_Box\RF_Box.ino:1:32: error: stray '#' in program
#include <SPI.h>
^
C:\Users\Gram\Desktop\Inventions\NRF Wifi Jam\RF_Box\RF_Box.ino:1:1: error: expected unqualified-id before '<' token
#include <SPI.h>
^
In file included from C:\Users\Gram\Desktop\Inventions\NRF Wifi Jam\RF_Box\RF_Box.ino:3:0:
C:\Users\Gram\AppData\Local\Arduino15\packages\arduino\hardware\avr\1.8.5\libraries\Wire\src/Wire.h:86:8: error: 'TwoWire' does not name a type; did you mean 'TwoWire_h'?
extern TwoWire Wire;
^~~~~~~
TwoWire_h
In file included from C:\Users\Gram\Documents\Arduino\libraries\Adafruit_GFX_Library/Adafruit_GFX.h:12:0,
from C:\Users\Gram\Desktop\Inventions\NRF Wifi Jam\RF_Box\RF_Box.ino:4:
C:\Users\Gram\Documents\Arduino\libraries\Adafruit_BusIO/Adafruit_I2CDevice.h:10:36: error: 'TwoWire' has not been declared
Adafruit_I2CDevice(uint8_t addr, TwoWire *theWire = &Wire);
^~~~~~~
C:\Users\Gram\Documents\Arduino\libraries\Adafruit_BusIO/Adafruit_I2CDevice.h:30:3: error: 'TwoWire' does not name a type; did you mean 'TwoWire_h'?
TwoWire *_wire;
^~~~~~~
TwoWire_h
C:\Users\Gram\Documents\Arduino\libraries\Adafruit_BusIO/Adafruit_I2CDevice.h:10:56: error: 'Wire' was not declared in this scope
Adafruit_I2CDevice(uint8_t addr, TwoWire *theWire = &Wire);
^~~~
In file included from C:\Users\Gram\Desktop\Inventions\NRF Wifi Jam\RF_Box\RF_Box.ino:5:0:
C:\Users\Gram\Documents\Arduino\libraries\Adafruit_SSD1306/Adafruit_SSD1306.h:132:42: error: 'TwoWire' has not been declared
Adafruit_SSD1306(uint8_t w, uint8_t h, TwoWire *twi = &Wire,
^~~~~~~
C:\Users\Gram\Documents\Arduino\libraries\Adafruit_SSD1306/Adafruit_SSD1306.h:175:3: error: 'TwoWire' does not name a type; did you mean 'TwoWire_h'?
TwoWire *wire;   ///< Initialized during construction when using I2C. See
^~~~~~~
TwoWire_h
C:\Users\Gram\Documents\Arduino\libraries\Adafruit_SSD1306/Adafruit_SSD1306.h:132:58: error: 'Wire' was not declared in this scope
Adafruit_SSD1306(uint8_t w, uint8_t h, TwoWire *twi = &Wire,
^~~~
C:\Users\Gram\Desktop\Inventions\NRF Wifi Jam\RF_Box\RF_Box.ino:23:55: error: 'Wire' was not declared in this scope
Adafruit_SSD1306 display = Adafruit_SSD1306(128, 32, &Wire);
^~~~
C:\Users\Gram\Desktop\Inventions\NRF Wifi Jam\RF_Box\RF_Box.ino:23:55: note: suggested alternative: 'line'
Adafruit_SSD1306 display = Adafruit_SSD1306(128, 32, &Wire);
^~~~
line
C:\Users\Gram\Desktop\Inventions\NRF Wifi Jam\RF_Box\RF_Box.ino:270:1: error: expected unqualified-id before '<' token

^
exit status 1
Compilation error: stray '#' in program

Hi as I respond to your email it seems like this is a problem with your Arduino library directory. I suggest that you reinstall your library and update your Arduino IDE.
Also the Display you currently using is not suitable for this project.
The required library for this project:

Adafruit_SSD1306
Adafruit_GFX

In this part of repository I explain how to install them from Arduino IDE.

Yes, both will do the job.

Can I hire you for 1 hour to share screens and help me complete this project?  Would have to  be after I get the proper display in 1-3 days.

If you need help I will be here.

of course, if you don't have the ch340 driver installed, follow the instruction or simply search for it on google.

I got the new screen.  Then when I tried to load the RF_Box Arduino file (after installing libraries), I get error below.  Please help fix it.
C:\Users\Gram\Desktop\Inventions\NRF Wifi Jam\RF_Box\RF_Box.ino:1:32: error: stray '#' in program
#include <SPI.h>
^
C:\Users\Gram\Desktop\Inventions\NRF Wifi Jam\RF_Box\RF_Box.ino:1:1: error: expected unqualified-id before '<' token
#include <SPI.h>
^
In file included from C:\Users\Gram\Desktop\Inventions\NRF Wifi Jam\RF_Box\RF_Box.ino:3:0:
C:\Users\Gram\AppData\Local\Arduino15\packages\arduino\hardware\avr\1.8.5\libraries\Wire\src/Wire.h:86:8: error: 'TwoWire' does not name a type; did you mean 'TwoWire_h'?
extern TwoWire Wire;
^~~~~~~
TwoWire_h
In file included from c:\Users\Gram\Documents\Arduino\libraries\Adafruit_GFX_Library/Adafruit_GFX.h:12:0,
from C:\Users\Gram\Desktop\Inventions\NRF Wifi Jam\RF_Box\RF_Box.ino:4:
c:\Users\Gram\Documents\Arduino\libraries\Adafruit_BusIO/Adafruit_I2CDevice.h:10:36: error: 'TwoWire' has not been declared
Adafruit_I2CDevice(uint8_t addr, TwoWire *theWire = &Wire);
^~~~~~~
c:\Users\Gram\Documents\Arduino\libraries\Adafruit_BusIO/Adafruit_I2CDevice.h:30:3: error: 'TwoWire' does not name a type; did you mean 'TwoWire_h'?
TwoWire *_wire;
^~~~~~~
TwoWire_h
c:\Users\Gram\Documents\Arduino\libraries\Adafruit_BusIO/Adafruit_I2CDevice.h:10:56: error: 'Wire' was not declared in this scope
Adafruit_I2CDevice(uint8_t addr, TwoWire *theWire = &Wire);
^~~~
In file included from C:\Users\Gram\Desktop\Inventions\NRF Wifi Jam\RF_Box\RF_Box.ino:5:0:
c:\Users\Gram\Documents\Arduino\libraries\Adafruit_SSD1306/Adafruit_SSD1306.h:132:42: error: 'TwoWire' has not been declared
Adafruit_SSD1306(uint8_t w, uint8_t h, TwoWire *twi = &Wire,
^~~~~~~
c:\Users\Gram\Documents\Arduino\libraries\Adafruit_SSD1306/Adafruit_SSD1306.h:175:3: error: 'TwoWire' does not name a type; did you mean 'TwoWire_h'?
TwoWire *wire;   ///< Initialized during construction when using I2C. See
^~~~~~~
TwoWire_h
c:\Users\Gram\Documents\Arduino\libraries\Adafruit_SSD1306/Adafruit_SSD1306.h:132:58: error: 'Wire' was not declared in this scope
Adafruit_SSD1306(uint8_t w, uint8_t h, TwoWire *twi = &Wire,
^~~~
C:\Users\Gram\Desktop\Inventions\NRF Wifi Jam\RF_Box\RF_Box.ino:23:55: error: 'Wire' was not declared in this scope
Adafruit_SSD1306 display = Adafruit_SSD1306(128, 32, &Wire);
^~~~
C:\Users\Gram\Desktop\Inventions\NRF Wifi Jam\RF_Box\RF_Box.ino:23:55: note: suggested alternative: 'line'
Adafruit_SSD1306 display = Adafruit_SSD1306(128, 32, &Wire);
^~~~
line
C:\Users\Gram\Desktop\Inventions\NRF Wifi Jam\RF_Box\RF_Box.ino:270:1: error: expected unqualified-id before '<' token

^
exit status 1
Compilation error: stray '#' in program

I Installed version 1.8.12 of Arduino and it said download complete, but the device did not automatically start working as you said.

Connections

Hi Mark. the new display is fine and for code/schematic everything in the related repository is could be trusted to work with.
as I test these codes with no problem it might be a problem with your Arduino libraries which are installed before.
I recommend that clear your Arduino library folder and install the needed one again or simply use another computer.
because codes are fine and the issue is in your software. As far as I know.


Back button with custom ng click wont listen to setDefaultBackTransition

i have the following
<ion-nav-bar class="bar-stable" ng-controller="MainController">
        <ion-nav-back-button native-back class="button-clear ion-chevron-left" ng-click="mainGoBack()"> Back</ion-nav-back-button>
    </ion-nav-bar>

$ionicNativeTransitionsProvider.setDefaultTransition({
        type: 'slide',
        direction: 'left'
    });

    $ionicNativeTransitionsProvider.setDefaultBackTransition({
        type: 'slide',
        direction: 'right'
    });

Clicking on the back button will still animate to the left and not right

Yes that is correct. Why do you have a custom ng-click on the ion-nav-back-button directive?
What the project does is that it overwrite the $rootScope.$ionicGoBack function: https://github.com/shprink/ionic-native-transitions/blob/develop/lib/run.js#L23
When no ng-click is defined the ion-nav-back-button directive adds it with $rootScope.$ionicGoBack call that is why it work if you do not have ng-click defined.

Ionic tabs have there own history, for my use case I need the history to flow from one tab to another.  So I am using my own back function.
How can i add the animation to my function?
—
Sent from Mailbox
On Thu, Oct 29, 2015 at 12:49 AM, Julien Renaux<EMAIL_ADDRESS>wrote:

Yes that is correct. Why do you have a custom ng-click on the ion-nav-back-button directive?
What the project does is that it overwrite the $rootScope.$ionicGoBack function: https://github.com/shprink/ionic-native-transitions/blob/develop/lib/run.js#L23
When no ng-click is defined the ion-nav-back-button directive adds it with $rootScope.$ionicGoBack call that is why it work if you do not have ng-click defined.
Reply to this email directly or view it on GitHub:
https://github.com/shprink/ionic-native-transitions/issues/19#issuecomment-152075267

Can I just add this?
$ionicNativeTransitions.transition('back');
—
Sent from Mailbox
On Thu, Oct 29, 2015 at 12:49 AM, Julien Renaux<EMAIL_ADDRESS>wrote:

Yes that is correct. Why do you have a custom ng-click on the ion-nav-back-button directive?
What the project does is that it overwrite the $rootScope.$ionicGoBack function: https://github.com/shprink/ionic-native-transitions/blob/develop/lib/run.js#L23
When no ng-click is defined the ion-nav-back-button directive adds it with $rootScope.$ionicGoBack call that is why it work if you do not have ng-click defined.
Reply to this email directly or view it on GitHub:
https://github.com/shprink/ionic-native-transitions/issues/19#issuecomment-152075267

Try that and let me know ;)

$ionicNativeTransitions.unregisterToStateChangeStartEvent();
$ionicNativeTransitions.transition('back');

That works thanks.
Is there any way to control the animation for the header?  Seems like its fading in and out.

For tabs I suggest to disable animations but you could also try fixedPixelsTop and fixedPixelsBottom options.
$ionicNativeTransitionsProvider.setDefaultOptions({
        duration: 400, // in milliseconds (ms), default 400,
        slowdownfactor: 4, // overlap views (higher number is more) or no overlap (1), default 4
        iosdelay: -1, // ms to wait for the iOS webview to update before animation kicks in, default -1
        androiddelay: -1, // same as above but for Android, default -1
        winphonedelay: -1, // same as above but for Windows Phone, default -1,
        fixedPixelsTop: 0, // the number of pixels of your fixed header, default 0 (iOS and Android)
        fixedPixelsBottom: 0 // the number of pixels of your fixed footer (f.i. a tab bar), default 0 (iOS and Android)
        triggerTransitionEvent: '$ionicView.afterEnter' // internal ionic-native-transitions option
    });


Connection loss during query while running model_cloudsql.py

Hi team,
When  I try to run the code in bookself\model_cloudsql.py in a window VM, it shows the error as below:
CR.CR_SERVER_LOST, "Lost connection to MySQL server during query")

sqlalchemy.exc.OperationalError: (pymysql.err.OperationalError) (2013, 'Lost connection to MySQL server during query') (Background on this error at: http://sqlalche.me/e/e3q8)
I have already set up the config.py and app.yaml as tutorial instructed.
How can I solve this issue and complete the task with my PostgreSQL?
Best regards,
Ka Wing

this means you are not connected to the sql server database
Kind Regards,

On 6/02/2019, at 14:38, Ka Wing Kwok<EMAIL_ADDRESS>wrote:
Hi team,
When I try to run the code in bookself\model_cloudsql.py in a window VM, it shows the error as below:
CR.CR_SERVER_LOST, "Lost connection to MySQL server during query")
sqlalchemy.exc.OperationalError: (pymysql.err.OperationalError) (2013, 'Lost connection to MySQL server during query') (Background on this error at: http://sqlalche.me/e/e3q8)
I have already set up the config.py and app.yaml as tutorial instructed.
How can I solve this issue and complete the task with my PostgreSQL?
Best regards,
Ka Wing
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks for the reply. However, I have login the goolge PostgreSQL and it shows the following when I run the code:
2019/02/06 19:13:22 Listening on <IP_ADDRESS>:3306 for delta-basis-214516:asia-east2:ppoagentbot
2019/02/06 19:13:22 Ready for new connections
2019/02/06 19:15:43 New connection for "delta-basis-214516:asia-east2:ppoagentbot"
2019/02/06 19:21:06 Instance delta-basis-214516:asia-east2:ppoagentbot closed connection
It seems that the code connected the server before and the server closed the connection when the code is not completed.
Do you have any idea what will be the reason and how to fix it?
The flag of the SQL are as below:
character_set_server : utf8
ft_max_word_len : 252
ft_query_expansion_limit  : 1000
group_concat_max_len  :<PHONE_NUMBER>4
innodb_lock_wait_timeout  :<PHONE_NUMBER>
interactive_timeout  : 31536000
lock_wait_timeout : 31536000
max_allowed_packet  :<PHONE_NUMBER>
max_heap_table_size  : 67108864
net_read_timeout  :<PHONE_NUMBER>
net_write_timeout :<PHONE_NUMBER>
tmp_table_size : 67108864
wait_timeout : 31536000
Many thanks,
Ka Wing

Please give the path of the code you're using and the URL of the web page with the instructions you're following. I'm not clear on your using a Windows VM. Is that a Compute Engine VM, something local on your own machine, or something else? Is the problem with the app when deployed to GCP (and if so, to which GCP product) or when following the 'running locally' instructions.
Thanks.

Closing due to lack of needed detail.


Crash Occurs When Using Android Overview on Large Text Files

Expected Behavior
Clicking the Android Overview button while viewing a large text file opens Overview.
Actual Behavior
Clicking the Android Overview button while viewing a large text file crashes the app.
How to Reproduce

Launch OpenPad 1.5.1 on Android 8.1.0
Tap Folder icon to choose a File
Tap Open External File Explorer
Navigate and Select an existing TXT file that is between 350 and 500kb
Tap the Android Overview button

Device: Pixel 2 XL
OS: Android 8.1.0
App Version: 1.5.1

Recording of the Bug

Posted on Utopian.io -  Rewarding Open Source Contributors

Thank you for telling me.
A total of four devices appear to be free from problems as a result of the test.
However, as your device produces errors, I will review this part.


feat: the (covariant) long exact sequence of Ext

Given a short exact short complex S in an abelian category C and A : C, we construct a long exact sequence
LargeExact A S.X₁ n₀ ⟶ LargeExact A S.X₂ n₀ ⟶ LargeExact A S.X₃ n₀ → LargeExact A S.X₁ n₁ ⟶ ... when n₀ + 1 = n₁.

[ ] depends on: #13963
[x] depends on: #13599
[x] depends on: #13876
[x] depends on: #13875
[x] depends on: #13742
[x] depends on: #13675
[x] depends on: #13757

This PR is refactored as #14515.


add telegram bot

As part of the tasks that would allow user should be able to send alerts via
 multiple methods

failing tests to be resolved


Changed background, cards and skill icons.

added radical gradient to the background, made shadows on hovering of project and blog cards and made skills boxes move up when cursor moves onto them.
Signed off by<EMAIL_ADDRESS>

Thanks @Rakshit-gen I'll make sure to check this in the next couple of days


Changes to support Windows

subprocess.Popen() has platform specific arguments. Added a platform check before calling a Windows compatible version of the call.
Replaced a manual path join with a os.path.join call (and removed unnecessary /)
Added encoding='utf-8', errors='ignore' parameters to the file.open call to resolve issues where some files contained un-parseable characters.

I've done basic testing to confirm that it works correctly on Windows and macOS.

Thanks for the PR!
Looks good to me overall- I tested with that changed import line (see comment in site_packages.py and it all still works on MacOS.
Another request- I seem to have overlooked the PyYAML requirement in setup.py under the install_requires part; are you able to fix that up on my behalf?

Great feedback!

Fixed the PyYAML requirement (and bumped it to 3.13 to resolve an install issue I saw on 3.12).
I've added the new import statement (from codecs import open).

One minor note from testing with 2.7 and 3.7 – with 2.7 the license summary looks like:
# 2.7
Apache-2.0
        u'python-dateutil' by u'Gustavo Niemeyer<EMAIL_ADDRESS>(u'https://dateutil.readthedocs.io')
        u'requests' by u'Kenneth Reitz<EMAIL_ADDRESS>(u'http://python-requests.org')

# 3.7
Apache-2.0
        'python-dateutil' by 'Gustavo Niemeyer<EMAIL_ADDRESS>('https://dateutil.readthedocs.io')
        'requests' by 'Kenneth Reitz<EMAIL_ADDRESS>('http://python-requests.org')

Great feedback!

Fixed the PyYAML requirement (and bumped it to 3.13 to resolve an install issue I saw on 3.12).
I've added the new import statement (from codecs import open).

One minor note from testing with 2.7 and 3.7 – with 2.7 the license summary looks like:
# 2.7
Apache-2.0
        u'python-dateutil' by u'Gustavo Niemeyer<EMAIL_ADDRESS>(u'https://dateutil.readthedocs.io')
        u'requests' by u'Kenneth Reitz<EMAIL_ADDRESS>(u'http://python-requests.org')

# 3.7
Apache-2.0
        'python-dateutil' by 'Gustavo Niemeyer<EMAIL_ADDRESS>('https://dateutil.readthedocs.io')
        'requests' by 'Kenneth Reitz<EMAIL_ADDRESS>('http://python-requests.org')

Hmm- It's really just the user-facing summary with the main output being the generated licenses I guess.
I don't mind if you don't mind!

I don't mind if you don't mind!

I don't mind!

I've also tested it on MAC OS and it womm 👍
Thanks for the update!


Added CC136.2 and added parts to CC136.1

@shiffman Needs the Repo when added and web editor id if it's different from part 1

Now in #1165, sorry I messed this up @blinkityblank!


Environment settings plugin

I feel like envSettingsPlugin should have more documentation, like it depends on Arguments resource which is only added if you use the Cubos(int argc, char** argv)  constructor, but not sure how to "word" this.
In rest, I think it looks OK, but I'm all ears for suggestions.

Yeah, you can specify something along the lines of 'Using this plugin requires that the Arguments resource has been added. For this to happen, the command line arguments argc and argv from the main function should be provided to Cubos'.

LGTM!


iOS 13.3 Issues

(Is anyone still using this?)
Updated to iOS 13.3 and the sockets seem to not stay connected - frequent disconnects and reconnects.  Fortunately it handles it fairly gracefully, but curious as to why it keeps dropping connections.

NM, issue appears to be on my end.


codemod to newer React API

I used jscodeshift -t transforms/React-PropTypes-to-prop-types.js ../react-native-calendar-select to codemod this

Coverage remained the same at 90.404% when pulling 37d6a3b6ea4651bf2a278dc483666c7f84b68bcc on fever324:master into acd6b0b7a7b1e58185d6a912b0e9441838a1fbe5 on Tinysymphony:master.


LUN-58: Add sharing option for results

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword LUN.

Tested on android. In the designs the share button should also be displayed on the Ergebnis-Übersicht screen.

You are right, completely forgot it while working on it, added it.

Is there any logic btw when the icon is left and when the icon is right of text for buttons?

I don't know which if there is one.


Google calendar invite attachments fail

Google calendar invites give MIME type: text/plain, then uses utf-8.
On line 213:
-        with open( filepath, 'a' if part['type'] == 'text' else 'ab' ) as file:
+        with open( filepath, 'a' if part['type'] == 'text' else 'ab', encoding='utf8' ) as file:

would make everything utf-8 output, or check to see if utf-8:
        try:
            with open( filepath, 'a' if part['type'] == 'text' else 'ab' ) as file:
                file.write( part['content'] )
        except UnicodeEncodeError:
            with open( filepath, 'a' if part['type'] == 'text' else 'ab', encoding='utf8' ) as file:
                file.write( part['content'] )

I'm not a good programmer, but hey.

Thanks a bunch! I'll try it out with my archive later today.

Took me a bit more than a day, but I got around to it eventually, haha. Thanks again!


pr-d/pt is processed as topic/dt in PDF

I have a theory
this line
https://github.com/dita-ot/dita-ot/blob/2d584f67e3f9ba0def6ef8d1b2c1a09c7e959ba1/src/main/plugins/org.dita.pdf2/xsl/fo/pr-domain.xsl#L285
needs a priority because otherwise this line
https://github.com/dita-ot/dita-ot/blob/2d584f67e3f9ba0def6ef8d1b2c1a09c7e959ba1/src/main/plugins/org.dita.pdf2/xsl/fo/tables.xsl#L98
always wins and pr-d/pt is never rendered properly
do you see any flaws in that logic?
I may create a pull request for this later

I mean if that's how priorities work in the first place 😅

hmm... I guess changing the import order is what's necessary if we can rely on this email exchange https://www.oxygenxml.com/archives/xsl-list/200501/msg01318.html

Adding the FOP label - this is an issue with import precedence in FOP, the custom code for <dt> in FOP overrides both the <dt> and <pt> processing from the org.dita.pdf plugin


Broken help

Hi,
I found that somewhere around version 55.10 full help (h h) stopped working
and seems -diff is also not available for a longer time
is it possible to consider support for some helpful functions on linux in the future ?

preserving some file metadata like in tar ?
(file owner, timestamp, symlink, ...)

thanks
Ratay

Help is reworked to become more similar to debian package (short version)
For symlink etc yes,I can. But a lot of work is needed.

Update
I am looking for tar-like metadata

good to know
with metadata and symlink support it would be really great full-featured backup tool
(but without it something important will always be missing)
thanks for the great work

If you have any suggestions (even on help) please write.
Currently in development there is Windows dd-images (even of C:)

My programming skills on linux are read-only :((
So from what I read:
You read file attributes via stat(...)
In addition to the currently processed one, there are also other important ones: st_uid, st_gid, S_ISLNK, ... (https://linux.die.net/man/2/stat)
You write the attributes via chmod(...)
Similarly you can use chown(...) (https://linux.die.net/man/3/chown)
As for the symbolic links:
read: https://man7.org/linux/man-pages/man2/readlink.2.html
creation: https://man7.org/linux/man-pages/man2/symlink.2.html
Full help:
If you drop seppuku() from void Jidac::usage() it might work

stat relies on a BIG structure (actually, two) with a LOT of data inside
Storing something that big requires (to maintain backward compatibility) a lot of work
Doable, in fact, but big (much bigger than -windate)
Restoring is hard too (a lot of strange things)
Remember: zpaqfranz does not work "only" on Linux, but on Mac, BSD and Solaris and vSphere and NASes too. This file-system specific functions are a pain in the ass
Full help: without seppuku() you can get a LOT of help when inserting wrong parameters (even two or 3 times)
I'll restore (much easier)

Please check this one (and do not forget a review on sourceforge, please :)
56_2d.zip

I understand
It is annoying that the original author outlined the work with attributes, but did not leave space in the structures for their future completion.
Owner and group are really basic attributes without which a full backup of any unix-like system is not complete.
It's a pity.
But I believe that when you finish working on your current modifications, you will find some free time and space in "franz_block" to implement them. :)
Also, symlink support should not be so complicated - I don't think there is any need to change the structures.
The full help seems to work now (useful for example to compare changes between versions)
thanks

It's a situation that I "feel" very little, and that's why I've never done it.
I work as a system administrator: all files are ... mine.
Mahoney has worked to achieve a very compact system, with very little wasted space
That's why the different structures between windows and linux
I am, on the other hand, much less interested in getting small files, also because I work with terabytes

I also work as a system administrator.
And all files belong to ... someone :))
And as always, I found a workaround:
getfacl -R -P * > aclbackup.txt setfacl --restore=aclbackup.txt find /root -type l -print0 | tar --null --files-from - -cvf linkbackup.tar
BTW
I tried the ESX version (ver. 5.5) and ended up like this:
`zpaqfranz v55.15q-experimental-ESX archiver,  (Sep 19 2022)
franz:DEBUG very verbose (-debug)
21026: check_if_password of zp.zpaq
zp.zpaq:
0 versions, 0 files, 0 fragments, 0 blocks, 0 bytes (0.00 B)
Default sort
Updating zp.zpaq at offset 0 + 0
Adding 551 (551.00 B) in 1 files (0 dirs), 1 threads
20006: converting to localtime 2022-11-29 09:42:20
@ 2022-11-29 09:42:20
Real write
39481: g_cdatasize  0
39482: g_htsize     0
39431 writeJidacheader -1
23013: zpaqfranz error: St9bad_alloc
0.047 seconds (00:00:00)  (with errors)
33026: call xcommand on errorcode==2
Entering xcommand()
i_command   ||
i_parameter |Out of memory|
Exit because empty i_command
`

Esx runs on a Centos 32 bit of about 15 years ago (!) does not allocate happlily RAM to anything else than VM
On esx I use the r (robocopy/rsync) in  a ghetto script and sum to make hashes
A to store logs into a permanent datastore
I find 0 documentation (offical from vmware) for custom made exes
If you have any please le me know

I also use ghetto - I thought I would supplement it with zpaq.
Then why are you publishing the version for ESX when it doesn't work?

Well it works for me, or better for my job
Everything from zpaq to zpaqfran are my very own 'pieces' of work
I need this, I implement
I do NOT need? I don't, unless someone else ask
I do not need a zpaq compression into esxi: little free CPU, slow non cached filesystem,therefore no developing
Instead I need a sector based windows imager and a ransom-resilient nix
PS on Esxi 6.5 it compress (small) files,at least on mine servers


Update OWNERS

Issue #, if available:
N/A
Description of changes:

Added danbudris and kevinsalerno

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


Feature Request: Scroll preview pane

Hi is it possible to scroll the preview?
Actually literally as I was writing the above sentence I noticed that mouse wheel scroll works on the preview pane.
So is there a key binding to do that as well? I like ctrl-u and ctrl-d to scroll up and down.
Thanks!

Take a look at https://github.com/ibhagwan/fzf-lua#default-options, the default keybinds are shift-up|down, you can modify these under keymap.builtin and keymap.fzf (depends which previewer you’re using, the neovim bulltin buffer or fzf native terminal previewer.

@ibhagwan related question: is it possible to automatically make the preview window cover the set of lines in which the result is found?
I'm seeing that if I live grep for test, say, which is found several times in the same file, the previewer will just show the top however many lines of the file, instead of like showing the bit which contains each instance of test. Is that the expected behavior? Feel like I have something set up wrong.

I'm seeing that if I live grep for test, say, which is found several times in the same file, the previewer will just show the top however many lines of the file

It should cover the matched lines, you probably changed the cmd or rg_opts and you're missing --column --line-number arguments so the rg results are missing the line/column info, add these back to your cmd and you'll be fine.

Just noticed your edit, you're in the right direction, add the above to your cmd arg.

Ah yep! Thank you!

Closing, feel free to reopen if you need more help.


Missing Caveat

Description
[Enter feedback here]
The documentation does not mention the fact that wildcards do not work for URLs like "app-1.*.domain.com"
Page URL
https://learn.microsoft.com/en-us/aspnet/core/security/cors?view=aspnetcore-8.0
Content source URL
https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/security/cors.md
Document ID
d3f332c4-4c60-039e-0e1e-bc6b11831f87
Article author
@tdykstra

See SetIsOriginAllowedToAllowWildcardSubdomains and Set the allowed origins


rados: implement rados pool snapshot functionality

Implemented following rados API components:

rados_ioctx_snap_create
rados_ioctx_snap_get_name
rados_ioctx_snap_get_stamp
rados_ioctx_snap_list
rados_ioctx_snap_lookup
rados_ioctx_snap_remove
rados_ioctx_snap_rollback
rados_ioctx_snap_set_read

Signed-off-by: Mudit Agarwal<EMAIL_ADDRESS>Fixes: #269
Checklist

[ ] Added tests for features and functional changes
[ ] Public functions and types are documented
[ ] Standard formatting is applied to Go code

@nixpanic @phlogistonjohn PTAL

I guess let's discuss it before I make further changes so that we all are on same page.
Currently snapshot object is like this:  (similar to rbd snapshot)
type Snapshot struct {
    ioctx *IOContext
    name  string
}

Suggestion from @nixpanic is to make it like this:
type Snapshot struct {
    ioctx *IOContext
    name  string
    SnapID snapID
}

Should we go ahead with this?
If yes, should we get the ID and fill it during create snapshot itself?
If we do that, we can make following functions of Snapshot type because all of these use ID
rados_ioctx_snap_get_name
rados_ioctx_snap_get_stamp
rados_ioctx_snap_set_read

We can as well write GetName() and GetID() methods for Snapshot type.

I guess let's discuss it before I make further changes so that we all are on same page.
Currently snapshot object is like this: (similar to rbd snapshot)
type Snapshot struct {
    ioctx *IOContext
    name  string
}

Suggestion from @nixpanic is to make it like this:
type Snapshot struct {
    ioctx *IOContext
    name  string
    SnapID snapID
}

Should we go ahead with this?
If yes, should we get the ID and fill it during create snapshot itself?
If we do that, we can make following functions of Snapshot type because all of these use ID
rados_ioctx_snap_get_name
rados_ioctx_snap_get_stamp
rados_ioctx_snap_set_read

We can as well write GetName() and GetID() methods for Snapshot type.

As I note in my review above I don't either are appropriate. The SnapID type itself is fine. However there probably shouldn't be an extra level of indirection in go-ceph just to "smuggle" the snapshot name string around. It will be far simplier to make these methods on ioctx that take the appropriate arguments.

Yeah, I was mimicking rbd snapshot pattern here which I also didn't like much.
So, lets not have a Snapshot object and base all functions on icotx.
Will send the PR with the changes.

@nixpanic @phlogistonjohn PTAL, completely changed from last time.

Looks good to me. I'd prefer to have names start woth Snap though, that matches more what librados offers, and automatically sorts the functions together in the documentation.

We can do that but else where in the code we have followed the pattern to put verb in front.

Regarding the naming: I don't have strong opinions on this. I usually prefer names in more typical order for english prose "PostMesage" "GetBlock" rather than the "backwards" noun-verb style. However, because the iocontext type has a lot of methods and we're wrapping code with the noun-verb style I'm willing to give here, but I won't argue strongly either way for this particular case.

What you've got looks good to me. However, I checked the coverage report and there's a bunch of missing coverage for the cases where validate() returns an error. I don't need you to fix this to merge but I would like it get added. So we can either do it in a follow up PR or here. I'm going to leave this as a comment to hear back from you on what approach you'd prefer.

Updated test cases for validate() in the same PR, PTAL.

@nixpanic PTAL


Hydrorivers search

Changes:

GeoGenerator.java, GeoGeneratorTest.java: Updated GeoGenerator to also include a string Id field to stay consistent with the SimpleSearcher.Result class
SimpleGeoSearcher.java: Bridge searcher class for GeoSearch
GeoSearcherTest.java: Tests the bridge class
GeoSearchExplorationTest.java: This file was renamed from GeoSearcherTest.java to GeoSearchExplorationTest.java. It comprises of the tests I added before from the Lucene Geo API exploration
GeoIndexerTestBase.java: Updated the indexer base to also include a string Id field

Codecov Report

Merging #1781 (805f2a9) into master (e9189fe) will increase coverage by 0.07%.
The diff coverage is 77.77%.

@@             Coverage Diff              @@
##             master    #1781      +/-   ##
============================================
+ Coverage     57.64%   57.72%   +0.07%
- Complexity     1038     1042       +4
============================================
  Files           174      175       +1
  Lines          9844     9871      +27
  Branches       1353     1358       +5
============================================
+ Hits           5675     5698      +23
  Misses         3692     3692
- Partials        477      481       +4

Impacted Files
Coverage Δ

...ain/java/io/anserini/search/SimpleGeoSearcher.java
76.00% <76.00%> (ø)

...java/io/anserini/index/generator/GeoGenerator.java
59.09% <100.00%> (+1.94%)
:arrow_up:

...c/main/java/io/anserini/search/SimpleSearcher.java
63.98% <0.00%> (+0.76%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9189fe...805f2a9. Read the comment docs.

So to be more concrete, my suggestion is to expose a bunch of builder methods from the Python end, e.g., createQueryTypeX, createQueryTypeY, etc. These create the appropriate Lucene Query object, so then the bridge method just needs a simple search method.
Thoughts about this alternative design?

So to be more concrete, my suggestion is to expose a bunch of builder methods from the Python end, e.g., createQueryTypeX, createQueryTypeY, etc. These create the appropriate Lucene Query object, so then the bridge method just needs a simple search method.
Thoughts about this alternative design?

This alternative design sounds good to me. To confirm my understanding, we'd call something like LatLonShape.newGeometryQuery()(or any of the Query constructors here) to construct the query on the Python end?

Yup!


H7 RM0433: Rename SAI [AB] CR bit 19 to NOMCK and remove MCKEN

Other H7 parts are unchanged. Improve description of NOMCK/NODIV bit
See previous PR #347. Fixes #618

What do you think of leaving the nodiv field in for these parts too, at the same offset to the nomck field? That way drivers/HAL can keep doing the same thing but users can call it by the RM name if they prefer. Maybe it's just more confusing in the end, I don't know how much the HAL really cares about this bit.

The default value of nodiv is the typical use case, whilst setting it is a less common use case (I think). However the HAL does write to it a couple of times, so having nodiv at that offset for all parts would be a nice solution

Thanks for the suggestion, the RM0433 parts now have both NODIV and NOMCK at the same offset


Forge?

Any plans on making this work with Forge WebUi?

Hi @T9es  is Good question about will I let this extension support "forge webui"?
in my view, I not used forge webui a lot seem  like using forge only 1~3 times and not a lot of time...
so I will let it support forge?
of course if have time to check the forge extension docs or something need change...and easy to update it might be soon update :D

https://github.com/lllyasviel/stable-diffusion-webui-forge/issues/64#issuecomment-1945960297

I just searched Forge modules it seems a lot of things different... and you
said is_xl issue. Yeah I checking this issue how fix it and it seems need
detect using A1111 or forge.

support forge task

why forge can't use issue list

[ ] Export checkpoint file?
[ ] Export lora files?
[ ] Read the checkpoint file and output the image? (It is possible but it is exported from automatic1111)
[ ] Read lora files and output images?

e53c506a1a12f1f0d5fdd6b5bdf3bd5697b77a61 Right now half support forge webui read the checkpoint/lora not sure have any bug? just a little test about it on forge can work perfectly... like in readme.md said only can read TensorRT, export function need wait have more time to figure it out

Development log:

At present, I know that forge seems to just annotate some seemingly useless parts. If this is the case (this is speculation), then it may need to be rewritten to make the TensorRT export function executable on Forge, and I have been thinking about it for a while. It feels like it would be better to develop the Stable Diffusion webui extension based on Forge’s optimized repo. 😞

Development log:

Thank you for waiting for several weeks. This Forge export function problem is beyond the scope of my work. This is not a unilateral problem. If the forge repo author does not release instructions for about other docs uses or alternatives(Annotating code), you need to wait for other people who know Forge It's possible that people working on this support the export feature, or more progress will be made while waiting for others to pull the request.

this issue won't close and no one know this repo so just keep it until someone found it :shipit:


Add a new and optional measurement type called "RAW" which outputs every dat apoint of a run.

Raw datapoint output is quite useful and important for two reasons:
 1) Allows the user to do more thorough statistical analysis on the complete set of the data.

 2) Using timestamps that are logged with raw data points, it becomes much easier to investigate and correlate latency outliers at the backend service.

@busbey Can you please take a look at this? (or feel free to reassign if necessary). Thanks.

I am not sure that we want to hold all of the measurements in memory for the entire run.  For small runs it won't be an issue but for large runs (where having the details is probably more interesting IMHO) we are going to exhaust memory pretty quick.
Can we change the writing of the raw metrics to the file to be delegated to a background thread and the measure(int) method just puts the RawDataPoint onto a queue that thread is reading from.  The exportMeasurements() will then interrupt the background thread so it flushes and closes the raw file.
This may also be a good use case for using the TwoInOneMeasurement where one of the other measurements does the statistical measurement and this implementation focuses on just doing the output of the raw data points.

@allanbank, thanks so much for taking a look at this. Regarding your last comment of holding measurements in memory vs flushing in the background, I've thought about that too, and I did some calculation on this before i decided to go with the current way of implementation.
The calculation is: each RawDataPoint is about 20 bytes (including Java object overhead), and for a 10-million to 20-million operation run, it's going to take about 200MB to 400MB of RAM, which is typically less than most test machines would have nowadays. In the last few days, I was able to consistently perform 20-million operation runs on a small 1 core Virtual Machine with 2.5 GB of memory without any problem. Btw, each of my 20-million op run would take about a day to finish with the backend service I am testing against. I think, if I want to try, I can probably do a 100-million operation run on my small VM just fine too.
Yes, for very super-long runs, probably with Billions of operations per run, my current implementation would not work for them if they are run on a small VM like the one I had. When that happens, the user can either provision a larger client machine (e.g., a GCP VM n1-standard-8 with 30GB of RAM would work fine here), or split the super-long run into multiple not-so-super long runs.
Therefore at this point I am leaning towards simplicity. The asynchronous background flushing design would add a level of complexity to the code and make it a bit harder to maintain and debug down the road. I don't see a strong need to do that right now, however, if in the future we see a need from users or issues reported by users when they use this Raw measurement type, I'd be happy to implement the background flush as you described here.
By the way, I've already documented all the memory calculation and the resource requirements in the workload_template file as part of this pull request.
-Stanley

Hey @allanbank, I am wondering what your thoughts are regarding this PR? As commented above, I am leaning towards simplicity at this point, and I'd prefer to add complexity only when necessary. However, if you feel strongly otherwise, please let me know. Thanks!

I am OK leaving it the way it is. Two things.

We might want to take a guess at sizing the measurements list based on the expected operations count.  Doubling the list is OK when it is small but as operation counts grow I would be surprised if there are not any pauses in the client to resize the array and copy the objects over. The other option is to change the list to a LinkedList and recalculate the memory usage.

I had mentioned this before but to make it more concrete: How do you feel about switching from computing the percentile statistics in OneMeasurementRaw and instead let the OneMeasurementHdrHistogram do that work? There has been a lot of work that went in to HdrHistogram and I would prefer this not be an either/or situation. e.g., in OneMeasurement constructOneMeasurement(String name).
case RAW:
return new TwoInOneMeasurement(name,
new OneMeasurementHdrHistogram("Hdr"+name, _props),
new OneMeasurementRaw("Raw"+name, _props));

Then in OneMeasurementRaw.exportMeasurements(MeasurementsExporter) remove everything after the
if (outputStream != System.out) {
  outputStream.close();
}

Eventually, it will be nice to generalize this to allow users to select any or all types of measurements to be applied but that can be another pull request.

Good point regarding the issue with ArrayList. I am leaning towards using a LinkedList based solution ( which is your suggestion as well). It's more robust and simpler than trying to guess an initial capacity here, because doing the guess work would need to make this class parse various operations properties such as total ops count, proportions for each ops type, matching the op name to measurement name, etc, etc, which is quite flaky and hard to maintain down the road.

With the LinkedList approach, the extra space needed is a forward and backward reference which is 16 bytes total, plus the list entry object (12 bytes). So it comes down to about 50 bytes per data point. A 5-million operation run would then take about 250MB, and  a 10-million run takes 500MB, so on, so forth. This still seems reasonable to me. I will update the doc to reflect this.

Regarding combining HdrHistogram with Raw, I agree it can be very useful. Meanwhile, I'd like to retain the ability to use Raw directly and separately. So I am suggesting that we add a new measurement type called "HdrHistogram+Raw", and for this type, we'd initialize a TwoInOneMeasurement() object with these two measurement classes as you outlined above. This way, for people who only cares about RAW measurement, they can just use measurementtype="Raw", and for people who wants both histogram and RAW, they can use the "HdrHistogram+Raw" type.

Let me know what you think about my suggestions above, once green lighted, I will go ahead and do the necessary code changes as documented here.
Thanks so much for all your comments so far!

@allanbank I've made the code changes that incorporate your latest feedback. (see commit 8bfadae) Please take a look. Thanks.

@cmccoy This looks ready to merge to me.  It is probably going to conflict with #469. I know @stfeng is eager to get this merged so I am happy to do the post-#469 merge.

@allanbank - many thanks for your code review and comments, in addition to that, highly appreciate your efforts in handling the merge conflicts!


Fix for #132: Fix a race condition in consumer.Kinesis

As described in #132 this fixes the map access race condition when storing/reading offsets.
@mahdi-hdi Please check if this is working for you.

Coverage remained the same at 65.447% when pulling 64c2a6870e5a6213a15c6d61a6749bb611ca7e8c on fix/132_kinesis_race into 9186cab925912c972c7d702ee9268764555b8723 on master.

It looks good to me, tnx.


Korean recipes

Haven't spell/grammar checked yet. I'll do that a bit later then let you know.

Sounds good, merge when ready


Useful life factor

This seems like an unintuitive and not particularly useful field. Probably best handled in the TERM LITE standard prioritization function.

Blocked by #12

Removed as #12 was also removed.


Not buildable with current nightly compiler

RustyHermit is currently not buildable with the latest version of the nightly compiler. PR rust-lang/rust#74842 will fix this issue.

PR is merged.


same-cell-type "specific" interactions?

In the Figure 3 of the Efremova paper, there appears some DC1-DC1 interactions.
I am having a very hard time to figure how you can compute a cell type A - cell type A  "specific" interactions by permutations. I would guess that each time you compute the mean value (of either the ligand or the receptor) within the DC1 population it will be exactly the same. There is no "permutation" test possible within the same cell cluster, no?
As stated in the abstract: "[statistics predicts] enriched cellular interactions between two cell types ".
I feel like I am missing something here...

Hi,
CellphoneDB also looks at self-interactions.
CellphoneDB permutes the cell to cluster assignment for all the cells, therefore it can estimate a p-value for all clusters/celltypes.  If both L and R are highly specific to the same cell type, the p-value for the self-interaction will be significant.
Best,
Luz

Ah OK, I see, you always perform permutations between at least two clusters, but both L and R can be enriched in one of the two. Makes sense. Thank's!


Autocompletion not properly working when navigator is enabled

I am using lazy.nvim
this is my plugins.nvim file https://pastebin.com/kLG0wtaw
whenever i enable navigator.lua the autocompletion(I use nvim-cmp btw) behaves abnormally , the complete snippet doesnt get printed
when navigator is disabled , in the following scenario

after pressing enter it would print the complete template

like this
but when i enable navigator, pressing enter on the same scenario would print only the word 'map'

kinda like this
what can i do about it now
i have disabled guihua with autocmd as mentioned here, but that does not make any difference
Help me out please

Seems something with the LSP config.
go

cpp

I suspect the lsp is not running. what is result of :LspInfo ?
Also, you can setup lsp yourself to make sure it works in your scenario/project structure.
I do not use c++ in daily based. the default ccls setup
    ccls = {
      on_attach = on_attach,
      init_options = {
        compilationDatabaseDirectory = 'build',
        root_dir = [[ util.root_pattern("compile_commands.json", "compile_flags.txt", "CMakeLists.txt", "Makefile", ".git") or util.path.dirname ]],
        index = { threads = 2 },
        clang = { excludeArgs = { '-frounding-math' } },
      },
      flags = { allow_incremental_sync = true },
    },

You can override the settings.

@ray-x I dont think its issue with lsp
lsp seems to be running as usual
I ran :Lspinfo
when navigator is disabled

and when its enabled

I think it might be some issue with nvim-cmp or luasnip most probably
could you check once ?
also, how can I override the settings ?

Is the issue happening because navigator is trying to use ccls but my lsp configuration is only done with clangd ?

I disabled ccls , but it still seems to be not working

In readme.md check the tsserver/gopls section
You can either set lsp.enable = false to skip lsp setup and you can use your own setup (check https://github.com/ray-x/navigator.lua/#integrate-with-mason-williambomanmasonnvim), or put your own config in ccls or clangd to replace what navigator has:
  {
   lsp = {
    enable = true,  -- skip lsp setup, and only use treesitter in navigator.
    tsserver = {
      filetypes = {'typescript'} -- disable javascript etc,
      -- set to {} to disable the lspclient for all filetypes
    },
    gopls = {   -- gopls setting
      on_attach = function(client, bufnr)  -- on_attach for gopls
        -- your special on attach here
        -- e.g. disable gopls format because a known issue https://github.com/golang/go/issues/45732
        print("i am a hook, I will disable document format")
        client.resolved_capabilities.document_formatting = false
      end,
      settings = {
        gopls = {gofumpt = false} -- disable gofumpt etc,
      }
    }
  }
}

I disabled lsp completely and its still not working
I think the issue is with luasnip
I think enabling navigator is creating some issues with luasnip actually
Could you check/do something about that ?

TBH, I am using luasnip, navigator and cmp on a daily basics.
Also there is a sample config in the playground folder and you can try those out.
playground/init_packer.lua

that init_packer.lua does not contain any config for c++
what should i change in it to make it work with c++
sorry to annoy , i am sorta beginner in these things
and is there any chance that using lsp with mason would make things work ?
or could you provide any config for c++ with cmp, luasnip and navigator which sorta works and doesnt have the quirk i have been facing ?

I used your setup and ran tests under ubuntu with ccls. It works fine for me

I no longer use c++ and clangd is too heavy for me to install and test. But I do not see anything wrong with ccls.

Also I pushed a update to playground/init.lua so it supports cmp as well
https://github.com/ray-x/navigator.lua/blob/master/playground/init.lua
navigator.lua/playground/cpp❯ nvim -u ../init.lua  main.cpp

works fine for me:

The issue is not that autocompletion is not working ,  autocompletion is working.
Here is the issue.
When navigator is disabled -

and when navigator is enabled -

it does not write the template part
and this things keeps happening even with minimum config with nvim cmp and with both clangd and ccls
everything else works fine, just this thing keeps happening when navigator is enabled, i have tested with many other plugins , i think navigator is the reason why it might be happening
can we do anything about this ?

I tested with the init.lua you posted in the commit, i think it has the same issue actually

Would you try latest the version? It should be fixed for cpp with ccls. I did not try clangd.

Yeah it is now working with latest version.
Clangd is working too.
Thanks you very much.
That was a big help.


retcodes: Understand succesful retries (#1951)

Prior to this commit, the return codes from luigi didn't honor the case when a task once failed but then succeeded again in a following retry. This will both make the execution summary and return code correct. This fixes #1932.

When cherry-picking the commit, git added changes around the original commit that wasn't part of the initial parent. master branch now has the smallest required changes for the patch to work instead of cherry-picking more to resolve dependencies.


VPAT-483 Fixed focus order if time component is present

 VPAT-465 | Date/Time picker | All browsers | Grid of dates cannot be focused


chore:Add speakerdetailsviewmodel test

Fixes #1043
Checklist:

[x] I have checked for PMD and check-style issues
[x] I have read the Contribution & Best practices Guide and my PR follows them.
[ ] My branch is up-to-date with the Upstream development branch.

Changes: Implemented tests for SpeakerDetailsViewModel

@Masquerade0097 Please use squash and commit to merge

@iamareebjamal OK.


Cannot init canvas with defined height and width

 $scope.$on('canvas:created', function () {
    $scope.fabric = new Fabric({
      canvasWidth: 800,
      canvasOriginalWidth: 800
    });
  });

Creates canvas with 300 width and 300 height.
The following works, nevertheless:
  $scope.$on('canvas:created', function () {
    $scope.fabric = new Fabric();
    $scope.fabric.setCanvasSize(800, 400);
  });

+1 I also had the same issue!

+2 I also had the same issue!

I wonder what is the way for you guys to implement Fabric.js into your Angular project. So far I am just inserting all the hrefs into the index page and directly use Fabric.js like this, var canvas = new fabric.Canvas(...);
This way I could use Fabric but I cannot integrate any Angular Material stuff into the canvas element. Really hope this repo can get updated.


Text rounding param

Remind to add in text rounding param circa #1070. Make it optional via style/font params.

PR merged to put this into v2.x, but still need it for v3


New Version Release

It has been a while since we merged in the new feature for rate limiting by method #66 #67
Just checking in to see if we could get this new version released, my use case would really appreciate this feature for a cleaner implementation. Thanks @abersheeran

of course, thank you!


White space issue reported on Brave and Edge browsers on W11

I am not able to reproduce this, can someone show me repro steps 0_0


$filter support for appliedConditionalAccessPolicy

There are some properties (e.g. appDisplayName) in the signIn resource type documentation page (https://learn.microsoft.com/en-us/graph/api/resources/signin?view=graph-rest-1.0) which explicitly state they support $filter. There is no indication about it for appliedConditionalAccessPolicy, despite not being explicitly stated does it support the $filter query parameter? If not, does that mean that only properties that explicitly state they support $filter support that query parameter?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 61cf8069-b779-ea2a-c02a-c8efd2e18019
Version Independent ID: 9a912f06-6ffd-d5c9-de30-66c8fff1d578
Content: signIn resource type - Microsoft Graph v1.0
Content Source: api-reference/v1.0/resources/signin.md
Product: identity-and-access-reports
Technology: microsoft-graph
GitHub Login: @besiler
Microsoft Alias: MSGraphDocsVteam

Only the id was confirmed to support $filter and the documentation was updated accordingly. Closing this issue.


Don't include windows keyboard shortcuts in outputs when using Mac

When I ask for keyboard shortcuts inside Visual Studio code because its not my normal editor, I get windows keyboard shortcuts. I agree that mac confused the world by not following the existing keyboard layout and making their own is a nightmare, however, there should be some logic possibly even in the system message prompt that notices what operating system the user is using and outputs instructions using OS specific keyboard shortcuts/menus. Even if I tell Visual studio code GitHub copilot chat that I am using mac, I still get windows specific commands
Steps to Reproduce:

Open GitHub Visual Studio Code GitHub Copilot Chat (VS code exclusive) on Mac
Ask for a keyboard shortcut in VS Code

Examples for macOS, still showing Windows first:

digitarald: What's the keyboard shortcut for opening the command palette?
GitHub Copilot: The keyboard shortcut for opening the command palette in Visual Studio Code is Ctrl+Shift+P on Windows and Linux, and Cmd+Shift+P on macOS.

For me, this happens when copilot suggests keyboard shortcuts as part of any answer.


Ignore labels when centering

Is there a way to ignore edge labels when aligning a diagram (ie. only take into account nodes)?
In the following example, I'd like the nodes of the first diagram to line up with the nodes of the second one:
#align(center)[#diagram(
  node((0, 0), $1$),
  node((0, 1), $2$),
  edge((0, 0),(0, 1),"->","this is a very long label"),
)]
#align(center)[#diagram(
  node((0, 0), $1$),
  node((0, 1), $2$),
  edge((0, 0),(0, 1),"->"),
)]

(sorry if this isn't the place to ask this btw!)

I agree I think this would be a better default.
Fletcher actually does this by default — only nodes affect the diagram's grid layout (which you can see this with debug: 1). However, the cetz canvas that hosts the diagram sets the bounding box to the entire content. Once we find out how to either 1) manually set the cetz canvas' bounding box, or 2) make labels not affect the bounds, this can be done.
If I

Associated cetz issue: https://github.com/cetz-package/cetz/issues/619


Changing database ID does not work

Describe the issue
Changing Database ID to a new one does not work. Notero still tries to sync using the old Notion Database ID.
To Reproduce
Steps to reproduce the behavior:

Create/copy Notion database.
Paste new Database ID into Notero preferences.
Sync any enabled collection.
See changes in the old Notion database.

Expected behavior
Changes synced to a new Notion database.
Screenshots
N/A
Additional context
N/A

Hi @dkamaitis, thanks for reporting this issue!
I see what's happening here. When a Zotero item has been synced to Notion, a link to the Notion page is saved in Zotero so that any future updates to the item will update the same page in Notion instead of creating a new page. Unfortunately, there's currently no logic to check that the page is still in the database specified by the database ID in the Notero preferences.
I'd like to implement a proper fix for this, but in the meantime, here are some workarounds I can think of:

Delete the "Notion" links attached to synced Zotero items and then sync again.
Delete the pages in the old Notion database and then sync again. You have to permanently delete the pages in order for this to work—i.e. you have to delete the pages from the Trash.

I think the easiest way to do this is to bulk delete the pages from a table view of your database, and then navigate to the "In current page" view of the Trash to find the pages to permanently delete.
See this Notion documentation for more details.

Hi @dvanoni, thanks for the detailed explanation - very much appreciate your work on Notero.


HTTPS Support

Describe your question
How can I setup https support for javalin? like letsencrypt

Take a look at the example also linked in Javalin's documentation...
Instead of JKS files you may also use PKCS#12 keystores which can be generated via OpenSSL, but there are enough resources on the internet on how to do that.

Why should I use PKCS#12?


(docs) Reference to install protractor as global and run webdriver-manager update

#sweet

Coverage remained the same at 97.27% when pulling ac7306646aceabb63dbb42694fe5852f596d4df5 on yagoferrer:yago/protractor-global into 892c04db283b159b3a51d59228da38af6750dab7 on Zizzamia:master.


Fix an ASTDumper crash on opened existentials.

More importantly, specify the precondition in ArchetypeType
getAssocType() and getName().
Drive by bug fix. It doesn't merit a test, but I'll add one if someone
insists and tells me where it should go.

@swift-ci smoke test.


Fix JSDoc for createClock

This improves the generated .d.ts so that createClock may be called without arguments.
Purpose (TL;DR) - mandatory
Improve .d.ts types for createClock() so that it's possible to call it from TypeScript without arguments.

The currently generated .d.ts uses JSDoc, which incorrectly specified the two arguments for createClock() as mandatory.

Authors: IMHO, generating .d.ts from JSDoc should be considered a very temporary approach. Is there a reason why this was introduced and put in favour of DefnitelyTyped? Now when importing the library it's harder to use than before, since the generated typings are not at all mature. The very first call I made was to createClock(), and I was confused by it requiring two parameters...
I'd love to help, but I noticed that there would be quite a lot of work to fix all the function types etc. To get this working by only improving the JSDoc is going to be harder than any other solution I think. Actually I don't know in which shape DefinitelyTyped is for this repo, but I'm not sure it's a step in the right direction to go from a community managed DefinitelyTyped repo to an auto-generated one that suffers from poor JSDoc conversion.
In my book, of course the best way would be to rewrite Sinon in TypeScript. Are contributions for that of interest?
The second best is probably to add the d.ts files to source control and manually improve them within this repository.
The third best is to rely on DefinitelyTyped.
The worst, IMHO, is the current approach...

Perhaps it can also be noted that the suggest approach for still using DefinitelyTyped does not work perfectly either. If modifying paths in tsconfig.json, my code compiles OK, and clicking on symbols from the library takes me to the DT repo. However, the IDE (Webstorm 2020) still links to the d.ts file in the source repo and refuses to understand that the code does compile.
This may be an IDE issue of course, but it still highlights that this library became much harder to use than before. I ended up downgrading to ^6.0.1. :(

Thanks for the PR! As to your comments, I'll leave that for now (as I'm in a hurry).

Is there a reason why this was introduced and put in favour of DefnitelyTyped?

Of course. If you are interested in the background you can find most of the reasoning in the discussion here: https://github.com/sinonjs/fake-timers/issues/220#issuecomment-430596244

go from a community managed DefinitelyTyped repo to an auto-generated one that suffers from poor JSDoc conversion.

We go from an external repo that is usually out of sync (I have contributed to the DT types several times when stuff I need at work is missing from DT) to one managed by the community. The main point for us is documenting the types used using JSDoc. The generated TypeScript definitions are a bonus.

In my book, of course the best way would be to rewrite Sinon in TypeScript. Are contributions for that of interest?

Not at all, but not from bad will 😄  You need maintainers willing to keep it up to date in Typescript - of which there are none. It was hard enough getting contributors before TS was a thing. We have no interest in Babel, bundlers and source maps getting in our way when debugging - I think we all have enough battle scars from the last decade of fighting various generations of such machinery 😸

This is related to ☝ : #386


Issue with counter

I am on Waypoint: Size your Images and the counter in the upper right hand corner says 78. Is that counter supposed to correspond to the number of exercise you are on? If so, then something isn't right because when I finish an exercise, it never moves. It just stopped at 78.

Hi @orismanager. If this is the counter are you talking about:

I believe it shows how many credits you got for completing the challenges, not the number of the exercise.

Cristian,
Thanks for the quick response. That makes me feel better to be certain.
Could you answer one more question? Someone asked me if I was on the production or beta site.
How would I know the difference and does it matter?
I guess that qualifies as 3 questions technically.
Thanks Again,
Tom
Sent from my iPad

On Aug 13, 2015, at 02:21, Cristian V. Nica<EMAIL_ADDRESS>wrote:
Hi @orismanager. If this is the counter are you talking about:
I believe it shows how many credits you got for completing the challenges, not the number of the exercise.
—
Reply to this email directly or view it on GitHub.

There is the main website www.freecodecamp.com (i believe this is called production), where everything should be functional and stable, and where we are advised to learn coding..
..and a beta website beta.freecodecamp.com which means something like:
The beta site is a testing site, not complete, and certainly not replacing the previous site. During this beta phase, we are working hard to polish everything - the content, the navigation, the layout, and more. We are listening to feedback closely, trying to improve the site as quickly as possible.

@orismanager Hope that answers your question.
Happy Coding!


error Command failed with exit code 1.

I have just updated to WAHA Plus to make sure it was an issue with the version, so I'm using the latest version as at today.
I'm using WAHA Plus with Docker.
Yesterday all of my sessions have stopped working.
Whenever I try to stop a session, I get the following error
whatsapp-http-api-plus  | [Nest] 34  - 09/01/2023, 8:02:36 AM     LOG [SessionManager] Stopping 7e6f6f2d-dc03-476f-b34a-1825962630c9 session...
whatsapp-http-api-plus  | [Nest] 34  - 09/01/2023, 8:02:36 AM     LOG [SessionManager] "7e6f6f2d-dc03-476f-b34a-1825962630c9" has been stopped.
whatsapp-http-api-plus  | node:events:492
whatsapp-http-api-plus  |       throw er; // Unhandled 'error' event
whatsapp-http-api-plus  |       ^
whatsapp-http-api-plus  |
whatsapp-http-api-plus  | Error: WebSocket was closed before the connection was established
whatsapp-http-api-plus  |     at WebSocket.close (/app/node_modules/ws/lib/websocket.js:285:7)
whatsapp-http-api-plus  |     at WebSocketClient.close (/app/node_modules/@adiwajshing/baileys/lib/Socket/Client/web-socket-client.js:53:21)
whatsapp-http-api-plus  |     at WhatsappSessionNoWebPlus.stop (/app/dist/core/session.noweb.core.js:131:22)
whatsapp-http-api-plus  |     at SessionManagerPlus.stop (/app/dist/plus/manager.plus.js:138:23)
whatsapp-http-api-plus  |     at SessionsController.stop (/app/dist/api/sessions.controller.js:32:28)
whatsapp-http-api-plus  |     at /app/node_modules/@nestjs/core/router/router-execution-context.js:38:29
whatsapp-http-api-plus  |     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
whatsapp-http-api-plus  |     at async /app/node_modules/@nestjs/core/router/router-execution-context.js:46:28
whatsapp-http-api-plus  |     at async /app/node_modules/@nestjs/core/router/router-proxy.js:9:17
whatsapp-http-api-plus  | Emitted 'error' event on WebSocketClient instance at:
whatsapp-http-api-plus  |     at WebSocket.<anonymous> (/app/node_modules/@adiwajshing/baileys/lib/Socket/Client/web-socket-client.js:46:100)
whatsapp-http-api-plus  |     at WebSocket.emit (node:events:514:28)
whatsapp-http-api-plus  |     at WebSocket.emit (node:domain:489:12)
whatsapp-http-api-plus  |     at emitErrorAndClose (/app/node_modules/ws/lib/websocket.js:1008:13)
whatsapp-http-api-plus  |     at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
whatsapp-http-api-plus  |
whatsapp-http-api-plus  | Node.js v20.5.1
whatsapp-http-api-plus  | error Command failed with exit code 1.
whatsapp-http-api-plus  | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
whatsapp-http-api-plus exited with code 0

Hi! Have you tried to logout from a session and scan QR again?

@allburov Sorry I didn't make myself clear at first, the server crash when I try to call http://<IP_ADDRESS>:3000/api/sessions/stop

Got it, could you try to use POST /api/sessions/logout instead? It by passes some checks and logout session immediately.
The flow would be

/logout
Restart container
Start session, scan QR
Send logs here if it didn't help!

@allburov I managed to reproduce the bug.

start the container
send the command to start a session (do not scan the qr code)
send a command to stop the session
the container will crash with

whatsapp-http-api-plus  | node:events:492
whatsapp-http-api-plus  |       throw er; // Unhandled 'error' event
whatsapp-http-api-plus  |       ^
whatsapp-http-api-plus  |
whatsapp-http-api-plus  | Error: WebSocket was closed before the connection was established
whatsapp-http-api-plus  |     at WebSocket.close (/app/node_modules/ws/lib/websocket.js:285:7)
whatsapp-http-api-plus  |     at WebSocketClient.close (/app/node_modules/@adiwajshing/baileys/lib/Socket/Client/web-socket-client.js:53:21)
whatsapp-http-api-plus  |     at WhatsappSessionNoWebPlus.stop (/app/dist/core/session.noweb.core.js:131:22)
whatsapp-http-api-plus  |     at SessionManagerPlus.stop (/app/dist/plus/manager.plus.js:138:23)
whatsapp-http-api-plus  |     at SessionsController.stop (/app/dist/api/sessions.controller.js:32:28)
whatsapp-http-api-plus  |     at /app/node_modules/@nestjs/core/router/router-execution-context.js:38:29
whatsapp-http-api-plus  |     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
whatsapp-http-api-plus  |     at async /app/node_modules/@nestjs/core/router/router-execution-context.js:46:28
whatsapp-http-api-plus  |     at async /app/node_modules/@nestjs/core/router/router-proxy.js:9:17
whatsapp-http-api-plus  | Emitted 'error' event on WebSocketClient instance at:
whatsapp-http-api-plus  |     at WebSocket.<anonymous> (/app/node_modules/@adiwajshing/baileys/lib/Socket/Client/web-socket-client.js:46:100)
whatsapp-http-api-plus  |     at WebSocket.emit (node:events:514:28)
whatsapp-http-api-plus  |     at WebSocket.emit (node:domain:489:12)
whatsapp-http-api-plus  |     at emitErrorAndClose (/app/node_modules/ws/lib/websocket.js:1008:13)
whatsapp-http-api-plus  |     at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
whatsapp-http-api-plus  |
whatsapp-http-api-plus  | Node.js v20.5.1
whatsapp-http-api-plus  |
whatsapp-http-api-plus  | error Command failed with exit code 1.
whatsapp-http-api-plus  | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
whatsapp-http-api-plus exited with code 1

Got it, thank you for the detailed steps, we'll look at this!

Weird, this what happened with my session when I stop it before scanning QR code
[Nest] 54081  - 09/03/2023, 5:50:17 PM     LOG [SessionManager] Stopping default session...
[Nest] 54081  - 09/03/2023, 5:50:17 PM     LOG [SessionManager] "default" has been stopped.

Thanks for looking into this I have uploaded another fresh container and it seems to be working as expected, on the other server I had this issue, there were about 40 sessions, it could be a corrupted file or something, if it happens again, I'll let you know.
Thanks


Could not resolve "remix" (following developer blog tutorial)

I was following the developer blog tutorial: https://remix.run/docs/en/v1/tutorials/blog
I ran the setup npx create-remix --template remix-run/indie-stack blog-tutorial.
It then recommends adding this code:
import { json, useLoaderData } from "remix";

But an error is thrown:
Could not resolve "remix"

I noticed this recent commit: https://github.com/remix-run/indie-stack/commit/399001c32fe62dfa50d7610c79d1eef7bbcaa113
So I tried the same change:
import { json } from "@remix-run/node";
import { useLoaderData } from "@remix-run/react";

And it worked as expected.
This might only require updating the tutorial since it uses this template? I couldn't find any other documentation related to using @remix-run/react and @remix-run/node over remix?

We're in the middle of making this change and haven't updated the docs yet, so I've fixed this here so remix as a package still works. Thanks!


Catch up with DevRel issues on GitHub

I'm checking every issue, even the closed ones (they could have been closed being incomplete or by mistake).
The list is here, then sort by newest.
I'm starting by the newest to get to the oldest.

I reached #244, it seems that the next one is #242

up to #228

up until #124 #123 #122 #121 that are all related to #17
Spent 2 hours on this today so a lot of housekeeping. Somehow it feels more complex than newer issues, I guess that they got more accurate with more practice. I hope this won't get worse.

up to #95

up to #66

happy to say that it's done, everything was read through and sorted if needed.


Bindings for types mentioned in whitelisted function's signature are not generated

The transitive nature of whitelisting means that bindings for these types should be generated.
Testcase incoming...

$ ./target/debug/bindgen ./linux_bindings.h --whitelist-function dl_iterate_phdr

Input:
struct dl_phdr_info {
    int x;
}

int dl_iterate_phdr(struct dl_phdr_info *);

Output:
/* automatically generated by rust-bindgen */

extern "C" {
    pub fn dl_iterate_phdr(arg1: *mut dl_phdr_info) -> ::std::os::raw::c_int;
}

Note the lack of a definition for dl_phdr_info, despite it being in the signature of the whitelisted dl_iterate_phdr function.


Workflow graphic

The current graphic is an MS Paint placeholder that served for a good couple of years so it is with some sadness that I propose retiring it. Big thanks to Michael for the new graphic.

Looks good! The older image looks a bit squashed in the docs for me, though. Should this be fixed as well?

Looks good! The older image looks a bit squashed in the docs for me, though. Will this be fixed as well?

It's looking unsquashed for me.

Could we "retire" raster graphics in favor of vector graphics, and use an SVG here instead?

Addressed by this commit

Could we "retire" raster graphics in favor of vector graphics, and use an SVG here instead?

Addressed by this commit

Lovely! Thanks!


Generalize trap intrinsic and allow aarch64

These are just some small changes that begin to enable building Foundation on 64-bit arm linux.

@swift-ci please test

I guess our CI is still in bad shape from the Swift 3 transition...

Thanks for checking anyway, It's helpful for me because it wouldn't have gotten that far if I had broken it. :)

looks pretty reasonable to me, I wonder if we should just reduce the trap for all platforms down to the builtin trap.

I don't remember where it was mentioned, but from what I understand, the existing dependence on clang meant that relying on _builtin_trap did not introduce any extra dependencies.  It's clearly more portable, so it seems like a good idea to me.


Avoid accidental dynamic concurrency

Hopefully this will resolve https://github.com/istio/istio/issues/22845
Previously, we were setting concurrency from proxy config if it was set.
By default this was set to "2".
https://github.com/istio/istio/pull/21162 caused a regression switching
it to read from the CPU requests instead. This is the minimal fix to
undo that. Further improvements in master will be done, tracked in
https://github.com/istio/istio/issues/23470

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-security-k8s-tests_istio

update-ref-docs-dry-run_istio
8ac6271f8683b466d728eb66603879bbce99b46c
link
/test update-ref-docs-dry-run_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-security-k8s-tests_istio

update-ref-docs-dry-run_istio
8ac6271f8683b466d728eb66603879bbce99b46c
link
/test update-ref-docs-dry-run_istio

gencheck_istio
8ac6271f8683b466d728eb66603879bbce99b46c
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
e6e1cf19f70b1d2ad1b6501dbef870a344c10e12
link
/test integ-security-k8s-tests_istio

update-ref-docs-dry-run_istio
8ac6271f8683b466d728eb66603879bbce99b46c
link
/test update-ref-docs-dry-run_istio

gencheck_istio
8ac6271f8683b466d728eb66603879bbce99b46c
link
/test gencheck_istio

unit-tests_istio
8ac6271f8683b466d728eb66603879bbce99b46c
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

In response to a cherrypick label: #23472 failed to apply on top of branch "release-1.6":
error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	manifests/charts/istio-control/istio-discovery/files/gen-istio.yaml
M	pkg/kube/inject/testdata/inject/traffic-annotations.yaml
M	pkg/kube/inject/testdata/inject/traffic-annotations.yaml.injected
Falling back to patching base and 3-way merge...
Auto-merging pkg/kube/inject/testdata/inject/traffic-annotations.yaml.injected
CONFLICT (content): Merge conflict in pkg/kube/inject/testdata/inject/traffic-annotations.yaml.injected
Auto-merging pkg/kube/inject/testdata/inject/traffic-annotations.yaml
Auto-merging manifests/charts/istio-control/istio-discovery/files/gen-istio.yaml
Patch failed at 0001 Avoid accidental dynamic concurrency

@richardwxn can you send a manual cherry-pick to 1.6 for this?
Thanks.


[GSK-1560] Docs of integration on Hugging Face Spaces

Description

Related Issue

Type of Change

[ ] 📚 Examples / docs / tutorials / dependencies update
[ ] 🔧 Bug fix (non-breaking change which fixes an issue)
[ ] 🥂 Improvement (non-breaking change which improves an existing feature)
[ ] 🚀 New feature (non-breaking change which adds functionality)
[ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🔐 Security fix

Checklist

[ ] I've read the CODE_OF_CONDUCT.md document.
[ ] I've read the CONTRIBUTING.md guide.
[ ] I've updated the code style using make codestyle.
[ ] I've written tests for all new methods and classes that I created.
[ ] I've written the docstring in Google format for all the methods and classes that I used.

There are still some screenshots missing in the integrations page, but this is a great starting point. Feel free to make more changes @Inokinoki

Done. The doc can be also previewed locally using pdm watch-doc under python-client dir.


Support for Multiple oAuth Provider Logins

Ability to create a account and then Post-Account creation, add additional oAuth providers that you can login with.

[ ] LinkedIn
[ ] Facebook
[ ] Google
[ ] Twitter
[ ] Office365

[ ] Do not support Auto-mapping of email address from oAuth Provider with email address in DS User Account: as a security mitigation risk.  If a user wants to log in with a 2nd oAuth provider they have to add that provider once they are logged in with their original provider or the core DS authentication.  If they try to log in with a second provider that the user has not explicitly added, the user will be taken to the new account creation page.

As a genreal rule: "we cannot trust that the 'valid'/'confirmed email address from a oauth provider has not been compromised in the provider".  The user must always explicitly add their additional login providers.

[ ] Support for a Admin interface that allows admins to configure which providers are allowed.

Moved to auth ms


upload: add before-remove function

upload: add before-remove function. It can support a function returns a boolean or Promise.
#8399 requests this feature.
Please make sure these boxes are checked before submitting your PR, thank you!

[x] Make sure you follow Element's contributing guide (中文 | English | Español).
[x] Make sure you are merging your commits to dev branch.
[x] Add some descriptions and refer relative issues for you PR.

@Leopoldthecoder Both Chinese and English document is update. But I was not able to translate it to Spanish. So I just Keep it for others folks.

Thanks for contributing.


chore: empty commit for test

:construction: :construction_worker_man: :building_construction:

/ok-to-test-managed sha=4d7c44a provider=azure

/approve


Do not trigger builds on push events

I think we should keep running the CI on main unless we have a policy that prevents merging out-of-date branches to main.

That is true, these libraries probably should require the branch to be up to date. With policy-bot this will work quite well as we can automate more of it.