Output contains output and errors

Change output

Failure state logs to ERROR
output is displayed
displays state as StateClass:StateName (was StateName)
This changed the use of super in finished. Also added finished in the Fail state.

Unsure:

Do we want to remove the input from the Complete line? it is very verbose.
Didn't test retry

Before
floe examples/hello-world.asl '{"foo": 1}' examples/hello-world.asl '{"foo": 2}' examples/hello-world.asl '{"foo": 99}'

 INFO -- : checking 3 workflows...
 INFO -- : Running state: [FirstState] with input [{"foo"=>1}]...
DEBUG -- : Running docker run --detach -e foo\=1 ...
 INFO -- : Running state: [FirstState] with input [{"foo"=>1}]...Complete - next state: [ChoiceState] output: []
 INFO -- : Running state: [FirstState] with input [{"foo"=>2}]...
DEBUG -- : Running docker run --detach -e foo\=2 ...
 INFO -- : Running state: [FirstState] with input [{"foo"=>2}]...Complete - next state: [ChoiceState] output: []
 INFO -- : Running state: [FirstState] with input [{"foo"=>99}]...
DEBUG -- : Running docker run --detach -e foo\=99 ...
 INFO -- : Running state: [FirstState] with input [{"foo"=>99}]...Complete - next state: [ChoiceState] output: []
 INFO -- : Running state: [ChoiceState] with input [{"foo"=>1}]...
 INFO -- : Running state: [ChoiceState] with input [{"foo"=>1}]...Complete - next state: [FirstMatchState] output: [{"foo"=>1}]
 INFO -- : Running state: [FirstMatchState] with input [{"foo"=>1}]...
DEBUG -- : Running docker run --detach -e foo\=1 ...
 INFO -- : Running state: [FirstMatchState] with input [{"foo"=>1}]...Complete - next state: [PassState] output: []
 INFO -- : Running state: [ChoiceState] with input [{"foo"=>2}]...
 INFO -- : Running state: [ChoiceState] with input [{"foo"=>2}]...Complete - next state: [SecondMatchState] output: [{"foo"=>2}]
 INFO -- : Running state: [SecondMatchState] with input [{"foo"=>2}]...
DEBUG -- : Running docker run --detach -e foo\=2 ...
 INFO -- : Running state: [SecondMatchState] with input [{"foo"=>2}]...Complete - next state: [NextState] output: []
 INFO -- : Running state: [ChoiceState] with input [{"foo"=>99}]...
 INFO -- : Running state: [ChoiceState] with input [{"foo"=>99}]...Complete - next state: [FailState] output: [{"foo"=>99}]
 INFO -- : Running state: [FailState] with input [{"foo"=>99}]...
 INFO -- : Running state: [FailState] with input [{"foo"=>99}]...Complete - next state: [] output: [{"Error"=>"FailStateError", "Cause"=>"No Matches!"}]
 INFO -- : Running state: [PassState] with input [{"foo"=>1}]...
 INFO -- : Running state: [PassState] with input [{"foo"=>1}]...Complete - next state: [WaitState] output: [{"foo"=>1, "result"=>{"foo"=>"bar", "bar"=>"baz"}}]
 INFO -- : Running state: [WaitState] with input [{"foo"=>1, "result"=>{"foo"=>"bar", "bar"=>"baz"}}]...
 INFO -- : Running state: [NextState] with input [{"foo"=>2}]...
DEBUG -- : Running docker run --detach -e foo\=2 ...
 INFO -- : Running state: [NextState] with input [{"foo"=>2}]...Complete - next state: [] output: []
 INFO -- : Running state: [WaitState] with input [{"foo"=>1, "result"=>{"foo"=>"bar", "bar"=>"baz"}}]...Complete - next state: [NextState] output: [{"foo"=>1, "result"=>{"foo"=>"bar", "bar"=>"baz"}}]
 INFO -- : Running state: [NextState] with input [{"foo"=>1, "result"=>{"foo"=>"bar", "bar"=>"baz"}}]...
DEBUG -- : Running docker run --detach -e foo\=1 ...
 INFO -- : Running state: [NextState] with input [{"foo"=>1, "result"=>{"foo"=>"bar", "bar"=>"baz"}}]...Complete - next state: [] output: []
 INFO -- : checking 3 workflows...Complete - 3 ready

After
  INFO -- : checking 3 workflows...
  INFO -- : Running state: [Task:FirstState] with input [{"foo"=>1}]...
 DEBUG -- : Running docker run --detach -e foo\=1 -e _CREDENTIALS\=/run/secrets -v /Users/kbrock/src/gems/floe/tmp/20240329-82828-c6n4hk:/run/secrets:z --name floe-hello-world-c9a39580 docker.io/kbrock/hello-world:latest
  INFO -- : Running state: [Task:FirstState] with input [{"foo"=>1}]...Complete - next state [ChoiceState] output: [{"foo"=>1}]
  INFO -- : Running state: [Choice:ChoiceState] with input [{"foo"=>1}]...
  INFO -- : Running state: [Choice:ChoiceState] with input [{"foo"=>1}]...Complete - next state [FirstMatchState] output: [{"foo"=>1}]
  INFO -- : Running state: [Task:FirstMatchState] with input [{"foo"=>1}]...
 DEBUG -- : Running docker run --detach -e foo\=1 --name floe-hello-world-e30409b3 docker.io/kbrock/hello-world:latest
  INFO -- : Running state: [Task:FirstMatchState] with input [{"foo"=>1}]...Complete - next state [PassState] output: [{"foo"=>1}]
  INFO -- : Running state: [Pass:PassState] with input [{"foo"=>1}]...
  INFO -- : Running state: [Pass:PassState] with input [{"foo"=>1}]...Complete - next state [WaitState] output: [{"foo"=>1, "result"=>{"foo"=>"bar", "bar"=>"baz"}}]
  INFO -- : Running state: [Wait:WaitState] with input [{"foo"=>1, "result"=>{"foo"=>"bar", "bar"=>"baz"}}]...
  INFO -- : Running state: [Task:FirstState] with input [{"foo"=>2}]...
 DEBUG -- : Running docker run --detach -e foo\=2 -e _CREDENTIALS\=/run/secrets -v /Users/kbrock/src/gems/floe/tmp/20240329-82828-dkm9b4:/run/secrets:z --name floe-hello-world-cf3d39a2 docker.io/kbrock/hello-world:latest
  INFO -- : Running state: [Task:FirstState] with input [{"foo"=>2}]...Complete - next state [ChoiceState] output: [{"foo"=>2}]
  INFO -- : Running state: [Choice:ChoiceState] with input [{"foo"=>2}]...
  INFO -- : Running state: [Choice:ChoiceState] with input [{"foo"=>2}]...Complete - next state [SecondMatchState] output: [{"foo"=>2}]
  INFO -- : Running state: [Task:SecondMatchState] with input [{"foo"=>2}]...
 DEBUG -- : Running docker run --detach -e foo\=2 --name floe-hello-world-816c29f0 docker.io/kbrock/hello-world:latest
  INFO -- : Running state: [Task:SecondMatchState] with input [{"foo"=>2}]...Complete - next state [NextState] output: [{"foo"=>2}]
  INFO -- : Running state: [Task:NextState] with input [{"foo"=>2}]...
 DEBUG -- : Running docker run --detach -e foo\=2 --name floe-hello-world-93f8c5f8 docker.io/kbrock/hello-world:latest
  INFO -- : Running state: [Task:NextState] with input [{"foo"=>2}]...Complete workflow - output: [{"foo"=>2}]
  INFO -- : Running state: [Task:FirstState] with input [{"foo"=>99}]...
 DEBUG -- : Running docker run --detach -e foo\=99 -e _CREDENTIALS\=/run/secrets -v /Users/kbrock/src/gems/floe/tmp/20240329-82828-q6xhhv:/run/secrets:z --name floe-hello-world-54fdb316 docker.io/kbrock/hello-world:latest
  INFO -- : Running state: [Task:FirstState] with input [{"foo"=>99}]...Complete - next state [ChoiceState] output: [{"foo"=>99}]
  INFO -- : Running state: [Choice:ChoiceState] with input [{"foo"=>99}]...
  INFO -- : Running state: [Choice:ChoiceState] with input [{"foo"=>99}]...Complete - next state [FailState] output: [{"foo"=>99}]
  INFO -- : Running state: [Fail:FailState] with input [{"foo"=>99}]...
 ERROR -- : Running state: [Fail:FailState] with input [{"foo"=>99}]...Complete workflow - output: [{"Error"=>"FailStateError", "Cause"=>"No Matches!"}]
  INFO -- : Running state: [Wait:WaitState] with input [{"foo"=>1, "result"=>{"foo"=>"bar", "bar"=>"baz"}}]...Complete - next state [NextState] output: [{"foo"=>1, "result"=>{"foo"=>"bar", "bar"=>"baz"}}]
  INFO -- : Running state: [Task:NextState] with input [{"foo"=>1, "result"=>{"foo"=>"bar", "bar"=>"baz"}}]...
 DEBUG -- : Running docker run --detach -e foo\=1 -e result\=\{\"foo\"\=\>\"bar\",\ \"bar\"\=\>\"baz\"\} --name floe-hello-world-3a1d9475 docker.io/kbrock/hello-world:latest
  INFO -- : Running state: [Task:NextState] with input [{"foo"=>1, "result"=>{"foo"=>"bar", "bar"=>"baz"}}]...Complete workflow - output: [{"foo"=>1, "result"=>{"foo"=>"bar", "bar"=>"baz"}}]
  INFO -- : checking 3 workflows...Complete - 3 ready

update

public_send
Completed - next state [END] => Completed workflow -

update:

rebase, resolve conflicts

I'll let @agrare review the rest.  I see there's a fundamental change here where start/super/code is switched with finish/code/super, and I'm not sure if that can have any side effects.

update:

introduce long_name for the state's name but including the class

update:

fixed task log output (had added it but didn't do next state properly)

Another PR: I need to get the amazon runner up locally and really kick the tires around the various input, result, output paths and values.
Not convinced that we are consistent around this and they don't need to be tweaked. (e.g. is the output path based upon the input after input_path or the input before the input_path)


Hi, I want to re-implement the result on ImageNet. Where can I get the hyperparameters, ie. batch_size.

Our train_imagenet.py is based on the one released by Gluon-CV, where the training scripts (hyper-params) can be found at https://gluon-cv.mxnet.io/model_zoo/classification.html .


supporting iOS 7

I need to support iOS 7. I have Alamofire in my podspec file since it's an internal library for a separate I'm building. When I run pod lib lint, I get the following error:
The platform of the target `Pods` (iOS 7.0) is not compatible with `Alamofire (1.1.4)` which has a minimum requirement of iOS 8.0 - OS X 10.9.

When I try add the library to a regular Podfile of a project that supports iOS 7, I get the same error. Any know the issue?

You cannot use Swift frameworks with iOS 7 projects. You need to import the Alamofire.swift file directly into your project. The directions are all detailed in the README.


Error running test:all on macOS Mojave

Command (to run all test)
ceedling test:all
Error
xcrun: error: invalid active developer path (/Library/Developer/CommandLineTools), missing xcrun at: /Library/Developer/CommandLineTools/usr/bin/xcrun
ERROR: Shell command failed.

Solution
Update Xcode Command-line Tools using:
xcode-select --install

I'm not sure what you are proposing here? Is it that the documentation is not clear enough that a compiler is necessary to use ceedling?

When you upgrade from High Sierra to Mojave, you need to reinstall the xcode command line tools. Just sharing the solution for macOS users who recently upgraded to Mojave.


Fix typo from environemnt -> environment

Fix typo from environemnt -> environment
danger/lib/danger/ci_source/bitrise.rb:24:25: "environemnt" is a misspelling of "environment"

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.
You can find it at CHANGELOG.md.

          1 Warning

:warning:
Tests were not updated

  Generated by :no_entry_sign: Danger

Thanks!

Welcome @orta! 🤩


Make valueChanges a ReplaySubject(1)?

What's your idea?
We should decide whether the valueChanges observables should be backed by plain Subjects (as-is) or by a ReplaySubject(1).
In the Forms API, it is backed by a Subject, but arguably the initial synchronization from the URL might justify treating it differently in ngqp.

I really want to say we should do this because otherwise something reactive like
this.items$ = this.paramGroup.valueChanges.pipe(switchMap(…));

combined with the async pipe won't work with the initial sync. I think the benefit of supporting this outweighs the deviation from the Forms API.

OK, maybe it's not as decisive quite yet. The deviation doesn't bother me as much as the semantics of the word "valueChanges". Perhaps having value$ as a separate observable backed by the ReplaySubject(1) would be more appropriate?

This can be achieved using
this.items$ = this.paramGroup.valueChanges.pipe(startWith(this.paramGroup.value), switchMap(…));

It's not super pretty, but let's keep it like this for now.

See https://github.com/angular/angular/issues/15282

This does not work (at least not with angular 9.1). stackblitz

Just in case someone else stumbles upon this thread... The correct work-around is:
this.items$ = defer(() => this.paramGroup.valueChanges.pipe(startWith(this.paramGroup.value), switchMap(…)));


Error when converting a circuit with a Symbol parameter to QASM

Description of the issue
When converting this circuit to QASM, I get this error TypeError: unsupported format string passed to Mod.__format__
How to reproduce the issue
import cirq
from sympy import Symbol
import numpy as np
from cirq.circuits.qasm_output import QasmUGate

p1 = Symbol("p1")

qr = [cirq.NamedQubit("q" + str(i)) for i in range(6)]

circuit = cirq.Circuit()

circuit.append(
    QasmUGate(5.887184334931191 / np.pi, 0.07157463504881167 / np.pi, p1 / np.pi)(qr[5])
)

circuit.append(cirq.measure(qr))

circuit = cirq.resolve_parameters(
    circuit,
    {
        "p1": 2.3864521352475245,
    },
    recursive=True,
)

circuit.to_qasm() # TypeError: unsupported format string passed to Mod.__format__

put long logs in details blocks like this

Cirq version
You can get the cirq version by printing cirq.__version__. From the command line:
1.1.0

I think this is actually a new feature, since it has never been supported by the qasm converter.  Leaving it for cirq cync triage.

Yes, symbolic parameters have never been supported in QasmUGate. Still, we should at least make it clear by adding type annotations.
Related: #5985.

From Cirq sync: duplicate of https://github.com/quantumlib/Cirq/issues/5985.


remove dependency on yara

yara is currently used as a pattern matching engine to find code sequences here:
https://github.com/mandiant/GoReSym/blob/f2009bd92819df2f69d74c4a32f1300be284a4fa/objfile/scanner.go
however, yara is written in C and has to be linked to this Go project. the compilation, build, and distribution is tricky; see #23 #24 and #27 for issues influenced by this complexity.
the patterns that are passed to yara are pretty simple - they could be trivially converted to binary regular expressions since there's no use of yara's condition logic.
the Go regexp module doesn't support binary regexes; however, the https://github.com/rsc/binaryregexp module does, and its easy to use. we should consider migrating from yara to binaryregexp to keep GoReSym pure-Go and therefore easier to build and distribute.
here's an example test demonstrating the translation from a yara pattern to a binaryregexp:
package main

import (
	"testing"

	"rsc.io/binaryregexp"
)

func TestBinaryRegex(t *testing.T) {
	t.Run("basic non-UTF-8 data", func(t *testing.T) {
		r := binaryregexp.MustCompile(`\xfd\xe3`)

		if !r.MatchString("\xfd\xe2") {
			t.Errorf("failed to match non-UTF-8 data")
		}
	})

	// x64firstmoduledata
	// $sig = { 48 8D 0? ?? ?? ?? ?? EB ?? 48 8? 8? ?? 02 00 00 66 0F 1F 44 00 00 }
	t.Run("x64firstmoduledata", func(t *testing.T) {
		r := binaryregexp.MustCompile(`\x48\x8D[\x00-\x0F]....\xEB.\x48[\x80-\x8F][\x80-\x8F].\x02\x00\x00\x66\x0F\x1F\x44\x00\x00`)

		// 0x000000000044D80A: 48 8D 0D 8F DA 26 00                    lea     rcx, runtime_firstmoduledata
		// 0x000000000044D811: EB 0D                                   jmp     short loc_44D820
		// 0x000000000044D813: 48 8B 89 30 02 00 00                    mov     rcx, [rcx+230h]
		// 0x000000000044D81A: 66 0F 1F 44 00 00                       nop     word ptr [rax+rax+00h]    <- always seems to be present
		if !r.Match([]byte{0x48, 0x8D, 0x0D, 0x8F, 0xDA, 0x26, 0x00, 0xEB, 0x0D, 0x48, 0x8B, 0x89, 0x30, 0x02, 0x00, 0x00, 0x66, 0x0F, 0x1F, 0x44, 0x00, 0x00}) {
			t.Errorf("failed to match data verbatim")
		}

		// extra bytes at start
		if !r.Match([]byte{0xFF, 0xFF, 0x48, 0x8D, 0x0D, 0x8F, 0xDA, 0x26, 0x00, 0xEB, 0x0D, 0x48, 0x8B, 0x89, 0x30, 0x02, 0x00, 0x00, 0x66, 0x0F, 0x1F, 0x44, 0x00, 0x00}) {
			t.Errorf("failed to match data with prefix bytes")
		}

		// extra bytes at end
		if !r.Match([]byte{0x48, 0x8D, 0x0D, 0x8F, 0xDA, 0x26, 0x00, 0xEB, 0x0D, 0x48, 0x8B, 0x89, 0x30, 0x02, 0x00, 0x00, 0x66, 0x0F, 0x1F, 0x44, 0x00, 0x00, 0xFF, 0xFF}) {
			t.Errorf("failed to match data with postfix bytes")
		}

		// first byte doesn't match
		if r.Match([]byte{0xFF, 0x8D, 0x0D, 0x8F, 0xDA, 0x26, 0x00, 0xEB, 0x0D, 0x48, 0x8B, 0x89, 0x30, 0x02, 0x00, 0x00, 0x66, 0x0F, 0x1F, 0x44, 0x00, 0x00}) {
			t.Errorf("unexpected match")
		}

		// byte 2 range is different
		if !r.Match([]byte{0x48, 0x8D, 0x00, 0x8F, 0xDA, 0x26, 0x00, 0xEB, 0x0D, 0x48, 0x8B, 0x89, 0x30, 0x02, 0x00, 0x00, 0x66, 0x0F, 0x1F, 0x44, 0x00, 0x00}) {
			t.Errorf("failed to match data variant 1")
		}
		// byte 2 range is different
		if !r.Match([]byte{0x48, 0x8D, 0x0F, 0x8F, 0xDA, 0x26, 0x00, 0xEB, 0x0D, 0x48, 0x8B, 0x89, 0x30, 0x02, 0x00, 0x00, 0x66, 0x0F, 0x1F, 0x44, 0x00, 0x00}) {
			t.Errorf("failed to match data variant 2")
		}
	})
}

Running tool: /usr/local/go/bin/go test -timeout 30s -run ^TestBinaryRegex$ github.com/mandiant/GoReSym

ok  	github.com/mandiant/GoReSym	0.002s

if you'd like me to open a PR with these changes I'd be happy to do so.

I completely agree with you here, I'd thought the cgo process would be more transparent. I originally introduced the dependency out of necessity for an efficient signature scanner. I had hand rolled my own and testing showed it was orders of magnitude slower than yara, hence the switch.
We have a few interesting constraints, such as nibble level byte signatures being used, and also I believe skip ranges (which could be converted as two or more sub regexes matching within a range). If these constraints can be obeyed I would be in complete support of this!

Sorry I didn't fully review your suggested alternative (it's late here). That logic seems perfectly sound to me 😁
If you'd like to open a PR I would review more carefully soon and be very appreciative!


Set missing display name property to Auth Initiation Data

Fixes the issue of not having the display name property in the auth initiation data during api based autehntication.
Related issue: https://github.com/wso2/product-is/issues/20219

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/9028226363

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/9028226363
Status: success


Dynamic prompts

Issue: #36
This change adds support for inquirer's hierarchical prompts. For an example, see here: https://github.com/SBoudrias/Inquirer.js/blob/master/examples/hierarchical.js

wow, that really was pretty easy to implement 👍

Yeah, I was pretty happy with how easily that went too. Let me know if you need any other changes.

Hello. Any update on when this PR might be merged? Let me know if I can help with anything

@filipemir are you on twitter? if so, what's your account? I like to give a shout out to contributors when I release a new version of plop. :-)

Thanks, @amwmedia. I am not on twitter but thanks for asking :)

@amwmedia any chance of adding docs for dynamic prompts?

@jjwinskill we don't currently document inquirer features in the plop documentation. We simply say that inquirer prompts are used and point people to where to find the corresponding docs.
I wouldn't be opposed to having a short blurb about this and linking over to where to find the detailed docs. Any thoughts on where that blurb should live?

I was thinking it would make sense actually outside of node-plop. Specifically, if this is an available feature then I think it makes sense to include a simple "how to use" blurb right above dynamic actions in the plop repository here

@jjwinskill care to take a stab at what that might look like and submit a PR?


Undefined action "type" property when bundling with webpack

When I bundle my app using webpack, for production, with this plugin defined:
new webpack.DefinePlugin({         'process.env': {NODE_ENV: JSON.stringify('production')}  })
I get the following error:
Actions may not have an undefined "type" property. Have you misspelled a constant?
Everything works great when I'm running in development mode.  Anyone else run into this issue or have an idea what I may be doing wrong? Thanks for any suggestions...

I'd be happy to hear why you believe this issue is caused by (or related to) redux-api-middleware, but until then i'm closing this issue.
As to resolving your issue, i suggest you look into what JS library usually throws this error, and on what file it does so.


.opts-slash. converts to .opts-dash.

I have the following URL in my DNS setting:
youtu.be.opts-slash.qxPCUvE7wBE.redirect.center
This redirects me to
http://youtu.be.opts-dash.qxpcuve7wbe/
instead of
http://youtu.be/qxpcuve7wbe/
like it should be.

@timhaettich were you able to solve it? Please check what you have on your dns, I tried to simulate here and didn't work. If possible, send me the cname that's redirecting to youtube.


asv find reads only first character from arguments

On win64, python 2.7 (anaconda), latest asv master.
asv find 7ed0b26d..9687145e binary_ops.frame_multi_and_st.time_frame_multi_and_st

· Error running C:\Program Files (x86)\Git\cmd\git.exe log --quiet --first-parent --format=format:%H 7

The problem seems to be here - I'm guessing the arguments are expected to be wrapped in some kind of sequence?  Locally at least, removing the [0] fixed the problem.
in find.py
    return cls.run(
        conf, args.range[0], args.bench[0],
        invert=args.invert, show_stderr=args.show_stderr,
        machine=args.machine
    )

That looks like a bug left over from argument parsing refactoring.
Fix in gh-325


Ensure that we join all the cgroups

Cgroups patch ported to fedora 1.10.2
Signed-off-by: Mrunal Patel<EMAIL_ADDRESS>

LGTM I'll apply this to the upcoming 1.10.2

LGTM

@mrunalp could you tell me which commit upstream includes this patch (or the original patch you reworked for this)?

@runcom https://github.com/opencontainers/runc/pull/491

Thanks a lot, I'll use it as a reference

No problem :)
Sent from my iPhone

On Mar 10, 2016, at 3:41 PM, Antonio Murdaca<EMAIL_ADDRESS>wrote:
Thanks a lot, I'll use it as a reference
—
Reply to this email directly or view it on GitHub.


Docs: Add deprecation notice for @ionic-native/contacts

I'm submitting a ...  (check one with "x")
[X] Request to refactor the official docs.
The situation
over a week ago there was a deprecation notice added to Cordova-plugin-contacts. These guys even shutdown the issue tracker....
More Info
See the README.md under the following link for the deprecation info:
https://github.com/apache/cordova-plugin-contacts
My Request
I'd suggest to add a deprecation notice to the official ionic docs under this link:
http://ionicframework.com/docs/native/contacts/
Also see
https://github.com/ionic-team/ionic-native/issues/2153

Hello! Thank you for opening an issue with us!
The documentation for any of the Ionic Native stuff is generated based on documentation comments in the code for the various plugins. Thus it is not really part of the Ionic Framework code. I suggest creating this request in the Ionic Native repo: https://github.com/ionic-team/ionic-native
Thank you for using Ionic

@kensodemann Well, as you can see in the issue I've created an issue in the native repo too. But since the ionic-team obviously ignores issues in any repos other than the main ionic repo, I've added it to this repo, where issues usually aren't ignored.


Question: How do you zoom in charter?

I literally can't figure it out

you can't

Figured it out, its control + mouse wheel. would be helpful if something told you that, instead of me having to look into the source code

its control + mouse wheel

MacOS users are crying in assistance features

zooming in on most stuff is control + mouse wheel so i would've thought so


TorbJörn: Turret Health

Created by: DpsDoomMain
In Overwatch One Torbjörn’s turret had 250 hp now it has 225 can probably fix the same way you fixed Ashe

Created by: MaxwellJung
I thought it was 250, but i'll double check that number.

Created by: MaxwellJung
Please make sure your issue is correct before submitting one. OW1 torbjorn turret had 250 hp

moved from ow1_emulator_backup#647

Created by: DpsDoomMain
Don’t know just guessing


Menu items are not showing up

menu can toggle in/out
but menu items are not showing up. only blank lines are showing.
although, i just run the app i didn't modify the content.

Sorry about that, give it a try now with the recent commits

do you mean branch v2 ?

Neither master or v2 branches don't contain the issue, however I was referring specifically the master branch - this commit fixed your issue.


Sub handler

A user should be able to subscribe to a topic and have a callback called when such messages are received.

Must satisfy #71


Change Factory postfix using ethers-v5

I'm using typechain alongside with ethers-v5 and hardhat.
I have a contract named Genesis and the name of the generated factory results in Genesis__factory. This is weird, since I noticed in your ethers-v5 README that you use the POSTFIX Factory.
Is it be possible to change this to use Factory as a postfix instead?

Postfix is not configurable at the moment. We needed to pick something unique to not collide with contracts named like GenesisFactory :/

Are you planning on changing that? Can we create PR on this repo?

@cmitjans-at-wiris I think it's a good addition. If you're willing to create a PR I am gonna merge it.


where clause now works with range argument

This behavior is same as ActiveRecord.
We support endless range here, but doesn't support beginless range which will be introduced in Ruby 2.7.
That's because Rails 6 supports endless range only.
https://edgeguides.rubyonrails.org/6_0_release_notes.html#active-record-notable-changes

Looks good 👍
Could you try to fix compatibility test using this as reference?

@syguer I did!

Thanks!


Update Composer dependencies (2024-02-08-00-10)

Visual regression test passed!
View the visual regression test report


First-party support for local dev-mode observability

Often times even locally you need access to traces, metrics, logs, or at least have the ability to preview the telemetry you may be implementing without pushing to prod.
We already do this with our own HyperDX workflow, and it seems like it's been brought up a few times in our HN launch as well for being useful for other people's workflows.

https://news.ycombinator.com/item?id=37564644
https://news.ycombinator.com/item?id=37561281

We should figure out what requirements should be part of making HyperDX local-friendly, a few things on the top of my mind:

Optimize for resource footprint over scalability (we can tune the memory usage of the otel collector, maybe remove the miner or spin it up on-demand, etc)
Auth-less flow, so users can just spin up a container and start sending telemetry to the Otel ports directly without any additional auth/key/team setup.

Kicking off this issue to collect any other requirements and stub out additional tickets along the way.

You guys also need a single docker image that I can simply use in our docker compose file. Something similar jaeger/all-in-one

This would make me so happy 😁
On top of other suggestions so far, some ideas:

Log ingestion from file, works in docker compose via volume mounts. Syslog or other protocols could work the same way here, but always having file based log ingest as a fallback would be nice
Ability to check in saved views, and load them on boot. Enables sharing common development views amongst all team members. Bonus points for an easy export flow, but I don’t mind if it’s a simple “copy/paste this json/yaml/etc” flow either
The container supports attaching (preferably one) persistent volumes to keep some historical local development history. Would also want omitting this to have it persist nothing. Would also want to have a simple limit on the data stored, and just evict events at the tail to make room for new events. It can be nice to see yesterdays data after I stopped for the day, but go ahead and clobber it as I record new events today.  Personally, don’t really need a log rotation or anything fancy for the local development case.

Just adding my 👍 on this, ref Discord.
We have a wonderful "clone & 1-command to spin everything up" dev env, but HyperDX requires some manual configuration.

The auth less flow in OP would cover this for us. We may want to seed them via ENV vars, but not critical.
A simplified Docker Compose setup would be nice (ref @pksunkara), to avoid a) a full clone of repo, or manually copying docker-compose.yml + .env + ./docker (maybe only partially needed?)

I'd also recommend making the use-case of excellent local logging in dev mode a featured use-case on the docs site.
Awesome project, btw, I'm loving what I see so far! 👏


feat(tutorial): complete step 3

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

@kellychurchill added the changes!


partial log

streaming logs from cube orange to companion with:
[General]
ReportStats=false
MavlinkDialect=ardupilotmega
RetryTimeout=10
DebugLogLevel=info
Log=/log/flight
LogMode = while-armed

I get a log for each flight, however some are seemingly randomly cut short. I have checked kernal logs for hardware disconnect and that is not the issue.
I see this error:
lseek failed (Bad file descriptor)
Restarting log...
BinLog not started

but does not seem to match up with the shortened logs. I've read somewhere this is to do with trying to write to a closed file?
mavlink_router.zip

i have also checked there is no failsafes or other events from the SD log.
any help in going about debugging this?

unsure if this build error has anything to do with it?
  CXX      src/mavlink-router/binlog.o
In file included from /mavlink-router/src/mavlink-router/binlog.cpp:26:0:
/mavlink-router/src/mavlink-router/binlog.cpp: In member function 'void BinLog::_logging_data_process(mavlink_remote_log_data_block_t*)':
/mavlink-router/src/common/log.h:57:63: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'ssize_t {aka int}' [-Wformat=]
 #define log_error(...) Log::log(Log::Level::ERROR, __VA_ARGS__)
                                                               ^
/mavlink-router/src/mavlink-router/binlog.cpp:209:9: note: in expansion of macro 'log_error'
         log_error("Log partial write %ld", r);
         ^
  CXX      src/common/conf_file.o
  CXX      src/mavlink-router/endpoint.o
/mavlink-router/src/mavlink-router/endpoint.cpp: In member function 'virtual void Endpoint::print_statistics()':
/mavlink-router/src/mavlink-router/endpoint.cpp:392:88: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'uint64_t {aka long long unsigned int}' [-Wformat=]
            (_stat.read.crc_error * 100) / read_total, _stat.read.crc_error_bytes / 1000);
                                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
/mavlink-router/src/mavlink-router/endpoint.cpp:395:94: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'uint64_t {aka long long unsigned int}' [-Wformat=]
     printf("\n\t\tHandled: %u %luKBytes", _stat.read.handled, _stat.read.handled_bytes / 1000);
                                                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
/mavlink-router/src/mavlink-router/endpoint.cpp:399:84: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'uint64_t {aka long long unsigned int}' [-Wformat=]
     printf("\n\t\tTotal: %u %luKBytes", _stat.write.total, _stat.write.bytes / 1000);
                                                            ~~~~~~~~~~~~~~~~~~~~~~~~^
  CXX      src/common/log.o
  CXX      src/mavlink-router/logendpoint.o
In file included from /mavlink-router/src/mavlink-router/logendpoint.cpp:38:0:
/mavlink-router/src/mavlink-router/logendpoint.cpp: In member function 'void LogEndpoint::_delete_old_logs()':
/mavlink-router/src/common/log.h:53:63: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'uint64_t {aka long long unsigned int}' [-Wformat=]
 #define log_debug(...) Log::log(Log::Level::DEBUG, __VA_ARGS__)
                                                               ^
/mavlink-router/src/mavlink-router/logendpoint.cpp:127:5: note: in expansion of macro 'log_debug'
     log_debug("[Log Deletion]  Total free space: %lumb. Min free space: %lumb",
     ^
  CXX      src/mavlink-router/main.o

unsure if this build error has anything to do with it?
  CXX      src/mavlink-router/binlog.o
In file included from /mavlink-router/src/mavlink-router/binlog.cpp:26:0:
/mavlink-router/src/mavlink-router/binlog.cpp: In member function 'void BinLog::_logging_data_process(mavlink_remote_log_data_block_t*)':
/mavlink-router/src/common/log.h:57:63: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'ssize_t {aka int}' [-Wformat=]
 #define log_error(...) Log::log(Log::Level::ERROR, __VA_ARGS__)
                                                               ^
/mavlink-router/src/mavlink-router/binlog.cpp:209:9: note: in expansion of macro 'log_error'
         log_error("Log partial write %ld", r);
         ^
  CXX      src/common/conf_file.o
  CXX      src/mavlink-router/endpoint.o
/mavlink-router/src/mavlink-router/endpoint.cpp: In member function 'virtual void Endpoint::print_statistics()':
/mavlink-router/src/mavlink-router/endpoint.cpp:392:88: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'uint64_t {aka long long unsigned int}' [-Wformat=]
            (_stat.read.crc_error * 100) / read_total, _stat.read.crc_error_bytes / 1000);
                                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
/mavlink-router/src/mavlink-router/endpoint.cpp:395:94: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'uint64_t {aka long long unsigned int}' [-Wformat=]
     printf("\n\t\tHandled: %u %luKBytes", _stat.read.handled, _stat.read.handled_bytes / 1000);
                                                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
/mavlink-router/src/mavlink-router/endpoint.cpp:399:84: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'uint64_t {aka long long unsigned int}' [-Wformat=]
     printf("\n\t\tTotal: %u %luKBytes", _stat.write.total, _stat.write.bytes / 1000);
                                                            ~~~~~~~~~~~~~~~~~~~~~~~~^
  CXX      src/common/log.o
  CXX      src/mavlink-router/logendpoint.o
In file included from /mavlink-router/src/mavlink-router/logendpoint.cpp:38:0:
/mavlink-router/src/mavlink-router/logendpoint.cpp: In member function 'void LogEndpoint::_delete_old_logs()':
/mavlink-router/src/common/log.h:53:63: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'uint64_t {aka long long unsigned int}' [-Wformat=]
 #define log_debug(...) Log::log(Log::Level::DEBUG, __VA_ARGS__)
                                                               ^
/mavlink-router/src/mavlink-router/logendpoint.cpp:127:5: note: in expansion of macro 'log_debug'
     log_debug("[Log Deletion]  Total free space: %lumb. Min free space: %lumb",
     ^
  CXX      src/mavlink-router/main.o

https://github.com/mavlink-router/mavlink-router/issues/239
https://github.com/mavlink-router/mavlink-router/issues/155
similar issues i beleive

@lucasdemarchi @peterbarker any help/ideas on how I can go about debugging this?

@Dan-Moss bisect the problem by using MAVProxy's dataflash_logging module - that will tell you if the problem really is with mavlink-router.
The error hints that it is.  Check the dmesg output to make sure you're not getting errors on your filesystem.
Failing that - time to look at the mavlink-router code, tracing all places where that file descriptor is used (and perhaps inserting some debug at each point to see if something is being crossed when it shouldn't be).

hi @peterbarker , here is a debug output snapshot of a log file that was saved as 0 bytes, but as you can see data is there.
normally successful files are read only, but the erroneous one was read and write still at 0 byte. maybe linked or 2 issues at play. see my post a couple of comments up for other people with a similar issue.
mavlink_router_0_byte
a partial log, from the bottom up. not sure where it started/stopped.
partial_log.zip
in regards to the dmesg :
[   55.966745] uart-pl011 3f201000.serial: no DMA platform data i see this and dont understand if it enough to know if relevent, but the FCU is still connected and getting data.
and uart-pl011 3f201000.serial: cts_event_workaround enabled on boot, but nothing showing a disconnect or error.

On Tue, 30 Mar 2021, Dan wrote:

hi @peterbarker it seems that this is only occurring on flight controllers
IN standby mode, can you think why this might be the cause of the issue?

Ah.  Pretty sure mavlink-router can handle two different protocols;
ArduPilot's logging-over-mavlink and PX4 Firmware's logging-over-mavlink.
ArduPilot doesn't have a "standby" mode - so I think you must be refering
to PX4 Firmware.
While I've implemented the client-side of ArduPilot's protocol several
times, I've not implemented PX4 Firwmare's - and I'm the author of neither
in mavlink-router :-)  I'm also not a PX4 developer and have very limited
knowledge of that codebase.
Sorry...

we are using ArduCopter. Standby mode was in from https://github.com/ArduPilot/ardupilot/pull/12441
unsure what impact this may have...

On Wed, 31 Mar 2021, Dan wrote:

we are using ArduCopter. Standby mode was in from ArduPilot/ardupilot#12441

Ah.  We never should have attached the word "mode" to that functionality
:-)

unsure what impact this may have...

It probably shouldn't have any.

lseek failed (Bad file descriptor)
Restarting log...
BinLog not started

Humn... so here what seems to be happening is that some other component is enabling logging. Then we are receiving a packet before trying to start . This can be seen by the file descriptor being invalid (EBADFD) and then stop() failing with "Binlog not started".
On a hindsight those message should be made much clearer. And we should handle the case logging had already started when mavlink-router got up.
Questions: do you have other components possibly starting/stopping the logging? Do you have mavlink-routerd being restarted automatically when if exits/fails?  This second case I'm thinking if mavlink-router was somehow failing, then restarted and upon restart the flight stack logging was already going on. The fact that we don't serialize the "last seqno acked" to recover, probably means we would lose a portion of the log until we resync.  I fixed a bug today #263  regarding  mavlink-routerd exiting when we got a TCP disconnection - do you have TCP connections going on?

do you have other components possibly starting/stopping the logging? Do you have mavlink-routerd being restarted automatically when if exits/fails?

No, only started once at boot time and not restarted

do you have TCP connections going on?

fcu <> companion is serial, then value="tcp://<IP_ADDRESS>:5760"/ for mavlink router

Ok. Can you check if master branch improves that?  Previously if we had a problem in a TCP endpoint we would stop mavlink-router

yes, will check and report back 👍 thanks

hi @lucasdemarchi since the change i now sometimes get:
Open UART [4] /dev/ttyAMA0 *
UART [4] speed = 921600
Open TCP [5] <IP_ADDRESS>:5760 *
TCP connection [7] accepted
poll error for fd 7
BinLog not started
TCP Connection [7] closed

@lucasdemarchi any insights into my last post?

went through a recent set of logs, pairing up the ones that were cut short. no errors on STD out, gets piped to the file in the screenshot shown
the one in question just stops logging to the companion computer after 5s
fine compared to the other FCU

On Tue, 1 Jun 2021, Dan wrote:

went through a recent set of logs, pairing up the ones that were cut short. no errors on STD out, gets piped to the file in the screenshot shown
the one in question just stops logging to the companion computer after 5s
fine compared to the other FCU
image

Attaching strace to the process and waiting for a failure might be your
best way forward here.


[OPIK-50] Add cli.py

Details
Adds cli.py to support commands
opik server install
opik server upgrade
In case there are any extra arguments passed, opik cli ignores them and just passes to opik-installer.
If opik-installer is not installed, it's being installed when any of these commands is called.
Testing
Tested manually, opik server install should trigger corresponding opik-server install command from opik-installer package. Similarly for opik server upgrade.
Documentation
Almost no documentation is added except the most basic one about what commands do.
opik-installer has a lot of options, but opik knows nothing about them. We should probably add a separate documentation about these options somewhere in web-docs.

@AndreiCautisanu please test

At @alexkuzmik's request, I went ahead and made some changes to this PR to integrate the opik-installer package to the SDK (as a dependency) in such a way as to acheive the following goals:

Keep a single parent click.Context (instead of subprocessing or invoking a second top-level instance of click)
Prevent the heavy ansible dependencies from being installed by pip until invoking a command that requires it.

To accomplish this I:

Added the dynamic installation of the heavy dependencies to opik-installer as a Click decorator.
Ensured that we can still guarantee a minimum version of the ansible-playbill (and by proxy ansible) packages
Adjusted the debug_set function to work properly when opik-server is not the root context, by traversing the each context generation.
Changed how the Opik SDK's cli.py adds the server sub-group so that it simply uses the imported group from opik-installer
Added some logic to cli.py to ensure that both -v and -h can be called on the root command (opik -v & opik -h) in the same way as in the server subcommand.

LGTM
@jverre you can take a look

Tested on Mac: issue with Docker Daemon start after starting Docker Desktop - cannot confirm whether this is fault of installer or not fully clean machine after uninstalling Docker Desktop to test. Summary: after uninstalling Docker and running installer, the Docker Desktop instance that is started with the Open Docker Desktop task throws an error or does not start at all, causing the Wait for Docker daemon to start task to fail due to a timeout. If Docker Desktop is already installed on the system or if it's restarted during installation - everything works fine. Other than this, all ok
Tested on Linux: all ok


Not able to see Collectibles image (On-chain )

It works in lightening but does not works in supported and Onchain wallet

Working fine


PurePerms migration doesn't work for user.json files

PurePerms mistakenly saved the config as YML with a .json extension:
https://github.com/poggit-orphanage/PurePerms/blob/16e796ca96eb58dd3aa0a6edea0be2ca14688478/src/_64FF00/PurePerms/DataProviders/JsonProvider.php#L86
But the migrator goes by the file extension by using DETECT:
https://github.com/IvanCraft623/RankSystem/blob/2ffa5f865daad7e4aa5874242bece7f87dc31103/src/IvanCraft623/RankSystem/migrator/PurePerms.php#L90
Which will of course cause a JSON syntax error exception:
[18:57:59.734] [Server thread/CRITICAL]: pocketmine\utils\ConfigLoadException: "Failed to parse config D:\Himbeer\PMMP\plugin_data\PurePerms\players\himbeersaftlp.json: Syntax error" (EXCEPTION) in "pmsrc/src/utils/ConfigLoadException" at line 29

This is what the himbeersaftlp.json file contains:
---
userName: HimbeersaftLP
group: Owner
permissions: []
worlds: []
time: -1
expTime: -1
...

Also I'd prefer it if the data wasn't migrated without asking first.

PurePerms mistakenly saved the config as YML with a .json extension

@Vecnavium Did that mess in PurePerms :(

Also I'd prefer it if the data wasn't migrated without asking first.

You can set auto-migrator to false in config.yml


Feat/add sitemap

Added API to return sitemap urls

@sheralim012 Should this also include links for surveys and polls too?

@dannyparsons yes, updated PR.

@sheralim012 Please update this to include Quizzes as well once merged.


New issue but used to work ?

Hi Sergio,
All wordked shortly but suddenly got a new error
Would you be able to see what's wrong?
Many tnx
2021-09-26 19:22:50.164 Airco: (Airco) ----> '_plugin' '<plugin.PanasonicCZTACG1Plugin object at 0xffff842e6d90>'
2021-09-26 19:22:50.164 Airco: (Airco) ----> 'api_version' '1.12.0'
2021-09-26 19:22:50.164 Airco: (Airco) ----> 'json' '<module 'json' from '/usr/lib/python3.8/json/init.py'>'
2021-09-26 19:22:50.164 Airco: (Airco) ----> 'requests' '<module 'requests' from '/usr/local/lib/python3.8/dist-packages/requests/init.py'>'
2021-09-26 19:22:50.164 Airco: (Airco) ----> 'token' 'None'
2021-09-26 19:22:50.163 Error: Airco: (Airco) 'onHeartbeat' failed 'KeyError'.
2021-09-26 19:22:50.163 Error: Airco: (Airco) ----> Line 253 in '/config/plugins/domoticz_panasonic_CZ-TACG1/plugin.py'
2021-09-26 19:22:50.163 Error: Airco: (Airco) ----> Line 174 in '/config/plugins/domoticz_panasonic_CZ-TACG1/plugin.py'
2021-09-26 19:22:50.163 Error: Airco: (Airco) ----> Line 320 in '/config/plugins/domoticz_panasonic_CZ-TACG1/plugin.py'
2021-09-26 19:22:50.163 Error: Airco: (Airco) ----> Line 276 in '/config/plugins/domoticz_panasonic_CZ-TACG1/plugin.py'

Hi MikeZMssl,
You need to update the plugin with the last version.
Panasonic has updated their api version and the version '1.12.0' doesn't work anymore.
Sérgio

yeah it works now.
thanks again!


More dynamic Option Sets

e.g. to select software in method section, to select math area, ...

Added dynamic option sets for:

Software
Input / Output Data
Environment (Software + Exp. Devices)
Mathematical Area

For input/output 'free autocomplete' could be useful?
Other dynamic option sets?

dynamic option set for parameters

Also for Hardware, Exp Device and avail Software, dependencies, compiler should be added


How to get a Bootstrap  with altFormat?

When I add data-alt-input and data-alt-format to an <input> to get human-friendly date output, the <input> becomes hidden. Instead, a generic HTML <input> gets appended to DOM right after my original <input>. Is there a way to add bootstrap class of form-control to it, so that it conforms with Bootstrap CSS? Thanks

https://chmln.github.io/flatpickr/#options
See altInputClass


Finalize feature specification

Finalize the wiki pages containing the features specification and the corresponding requirements.
Provide a link to your milestones and make sure that all of them contain links to your features on the wiki.
Some ideas on how to improve existing requirements documentation and overall process structure:
Make sure that all stories (GitHub issues) are linked to Milestones and it is clear which commit(s) solve them
Enrich requirements with more details, examples and usage scenarios

[x] Make sure that the user stories are up to date
[x] Link all user stories to issues, if there is no link, provide an explanation
[x] Add small demo videos where possible

@Druner good work with this issue! 💯 ✅

Closing issue.


Feature/saleor 3824

I want to merge this change because we want shop admins to filter overpaid payments
Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-3824 Handle overpaid Orders


⚠ ClamAV has degraded performance

In 1ba9cd7, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 71 ms

Resolved: ClamAV performance has improved in 4711d11.


Add object support in ToggleGen

I have finalised object support in Toggles. Now it's time to add object support in ToggleGen.

Added Object and ObjectSupportedType in ToggleGen package.
Executed ToggleGen script to generate new object properties.
Updated demo app to demonstrate object observable functionality.

Nice catch @albertodebortoli, updated


Update README.md

What type of PR is this? (check all applicable)

[ ] 🚀 Added Name
[ ] ✨ Feature
[ ] ✅ Joined Community
[ ] 🌟 ed the repo
[ ] 🐛 Grammatical Error
[ ] 📝 Documentation Update
[ ] 🚩 Other

Description
Add Link of GitHub Profile

Added [Norman Vicente] to Minimalistic


[Feature] Loading indicator when adding large file

Is your feature request related to a problem? Please describe.
Currently when adding large files nothing happens at the beginning. After a while file appears in surge. That happens because secure hashing takes some time depending on the machine surge is run on.
Describe the solution you'd like
Raise a message when hashing starts, raise a message when hashing ended.
Possible text
Surge makes your file now ready for sharing. To make the process as safe as possible we're now creating a hash of the full file that makes it impossible to tamper with it. You can close this modal. We will inform you when everything is done and your file is ready for seeding.

Just add a new item to the "file transfers list" and add a rotating icon at the start of the line, just so we know stuff is happening,
Had the same "problem" today and I was left wondering if anything is even happening.

Implemented async hashing job in next release


Move to a new home

change path of container image in quay.io
Signed-off-by: Yuji Ito<EMAIL_ADDRESS>

use github actions for release workflow


questions abt lecture 11

how to apply the contents in lecture 11? When do we know to use map or thenDoThis? (coz there is no codecrunch exercise on  that so I not sure how to write code abt it)

@loberyyq, don’t get confused by the way the function is named. The thenDoThis method is actually just a map (which means feel free to name it as map). Recall that map are most commonly found in Functor, where a Functor<T> will take in a Function<T,R> in the map method and output a Functor<R>. Can you see that the Async<T> is exactly that Functor<T>?
Now if you study how Async<T> is written, you will notice it is not just any Functor because of its creation spawns a new thread MyThread internally. It also follows that thenDoThis is not just a normal map, because it will spawn a new thread in a newly created Async<R> to apply Function<T,R> only after whatever that Async<T> had been computing in MyThread is done (because of this.join()). Therefore it is better to call this method thenDoThis rather than map, because it waits for the Supplier of this.thread to finish before creating a new Async to compute Function<T,R>.

I think we only use thenDoThis when the question asks you to execute two parts of the code simultaneously, implying asynchronous programming. If not such need, we just use map.


When I add count field and add sqlExpr it gives me error "TypeError: Cannot read property 'length' of undefined"

I have a Type like below
const CashExpense = new GraphQLObjectType({
  description: 'Cash Expense Items',
  name: 'CashExpense',
  fields: () => ({
    ExpenseItem: {
      type: new GraphQLList(Expense),
      description: 'List of cash expense items.',
    },
    Count: {
      type: GraphQLInt,
      description: 'Count of Cash Expense Items',
      sqlExpr: table => `(SELECT count(*) FROM XXX WHERE EXPENSE_SOURCE = 'CASH')`
    }
  })
})
export default CashExpense

which used below Type
const Expense = new GraphQLObjectType({
  description: 'Expense information',
  name: 'Expense',
  sqlTable: 'XXX',
  uniqueKey: 'ID',
  fields: () => ({
    ExpenseId: {
      type: GraphQLFloat,
      description: 'Unique identifier of a specific expense item.',
      sqlColumn: 'D'
    },
    PersonId: {
      type: GraphQLFloat,
      description: 'Person identifier of the individual on the corporate card.',
      sqlColumn: 'PERSON_ID'
    },
.....

And my queryroot is like below
....
cashItems: {
      type: CashExpense,
      resolve: (parent, args, context, resolveInfo) => {
        // joinMonster with handle batching all the data fetching for the users and it's children. Determines everything it needs to from the "resolveInfo", which includes the parsed GraphQL query AST and your schema definition
        return joinMonster(resolveInfo, context, sql => dbCall(sql, knex, context))
      }
    },
....

And my GraphQL query is as below
{
  cashItems {
    Count
    ExpenseItem {
      ExpenseId
      PersonId
...
    }
  }
}

I get below error in console. Also it does not print anything when I start in debug mode.
{ TypeError: Cannot read property 'length' of undefined
    at pruneDuplicateSqlDeps (/node_modules/join-monster/dist/queryASTToSqlAST.js:317:24)
    at Object.queryASTToSqlAST (/node_modules/join-monster/dist/queryASTToSqlAST.js:37:3)
    at /node_modules/join-monster/dist/index.js:9:29
    at Generator.next (<anonymous>)
    at step (/node_modules/join-monster/dist/index.js:84:191)
    at /node_modules/join-monster/dist/index.js:84:437
    at /node_modules/join-monster/dist/index.js:84:99
    at joinMonster (/node_modules/join-monster/dist/index.js:19:17)
    at resolve (/schema/QueryRoot.js:34:16)
    at resolveOrError (/node_modules/graphql/execution/execute.js:454:12)
    at resolveField (/node_modules/graphql/execution/execute.js:445:16)
    at /node_modules/graphql/execution/execute.js:252:18
    at Array.reduce (native)
    at executeFields (/node_modules/graphql/execution/execute.js:249:42)
    at executeOperation (/node_modules/graphql/execution/execute.js:190:10)
    at /node_modules/graphql/execution/execute.js:116:13
  message: 'Cannot read property \'length\' of undefined',
  locations: [ { line: 15, column: 3 } ],
  path: [ 'cashItems' ] }

@praseedasathaye Which version on join-monster are you on? I've added some additional validations recently. Make sure you're on join-monster v1.0.1 and try again. If joinMonster is called in a resolver on a field that is a CashExpense type, then you must add sqlTable to the CashExpense type. Please make sure that is defined.

I took the latest "join-monster": "^v1.0.1-beta.1"
And also added below (sqltable and uniquekey) to CashExpense
const CashExpense = new GraphQLObjectType({
  description: 'Cash Expense Items',
  sqlTable: 'XXX',
  uniqueKey: 'EXPENSE_ID',
  name: 'CashExpense',
  fields: () => ({
    Count: {
      type: GraphQLInt,
      description: 'Count of Cash Expense Items',
      sqlExpr: table => `(SELECT count(*) FROM XXX WHERE EXPENSE_SOURCE = 'CASH')`
    },
    ExpenseItem: {
      type: new GraphQLListExpense),
      description: 'List of cash expense items.',
    }
  })
})

Now it gives me this error. I dont have any join condition between the tables here. The query is a separate query to get count.
{ AssertionError: If an Object type maps to a SQL table and has a child which is another Object type that also maps to a SQL table, you must define "sqlJoin", "sqlBatch", or "junctionTable" on that field to tell joinMonster how to fetch it. Check the "ExpenseItem" field on the "CashExpense" type.
    at getGraphQLType (/node_modules/join-monster/dist/queryASTToSqlAST.js:95:28)
    at handleSelections (/node_modules/join-monster/dist/queryASTToSqlAST.js:218:9)
    at handleTable (/node_modules/join-monster/dist/queryASTToSqlAST.js:208:5)
    at getGraphQLType (/node_modules/join-monster/dist/queryASTToSqlAST.js:97:5)
    at Object.queryASTToSqlAST (/node_modules/join-monster/dist/queryASTToSqlAST.js:35:3)
    at /node_modules/join-monster/dist/index.js:9:29
    at Generator.next (<anonymous>)
    at step (/node_modules/join-monster/dist/index.js:85:191)
    at /node_modules/join-monster/dist/index.js:85:437
    at /node_modules/join-monster/dist/index.js:85:99
    at joinMonster (/node_modules/join-monster/dist/index.js:19:17)
    at resolve (/schema/QueryRoot.js:34:16)
    at resolveOrError (/node_modules/graphql/execution/execute.js:454:12)
    at resolveField (/node_modules/graphql/execution/execute.js:445:16)
    at /node_modules/graphql/execution/execute.js:252:18
    at Array.reduce (native)

@praseedasathaye The Count field is not the problem here, that looks fine. The error is regarding the ExpenseItem field. This field required either a join or batch condition.

ExpenseItem is just a list of type Expense and does not have any join or batch.
ExpenseItem: {
      type: new GraphQLList(Expense),
      description: 'List of cash expense items.',
    }

The Expense type also has sqlTable set. Therefore Join Monster is expecting to fetch data for it in a SQL table, and it must do so by JOINing or beginning another batch request . If the Expense is not supposed to come from a SQL table, you must remove the sqlTable property.

But the ExpenseItem Type is just collection of Expense Type. There is no join or batch required here.  Expense has the required join for the table to get data. Do I need to resolve ExpenseItem using join-monster just like you do in QueryRoot (see below)? Below you have list or collection of Sponsor Type. Similarly I have list of Expense Type but this one is not at QueryRoot level but inside the Type ExpenseItem.
My use case is get the count of Expenses along with the list of Expenses. For this I am wrapping the Expense Type with the CashExpense Type which gives the count in a separate query and gets list from the Expense Type.
sponsors: {
      type: new GraphQLList(Sponsor),
      resolve: (parent, args, context, resolveInfo) => {
        // use the callback version this time
        return joinMonster(resolveInfo, context, (sql, done) => {
          knex.raw(sql)
          .then(data => done(null, data))
          .catch(done)
        }, options)
      }
    }

Do I need to resolve ExpenseItem using join-monster just like you do in QueryRoot?

No.

Expense has the required join for the table to get data.

This is not the case. sqlJoin is never defined on a type. It is defined on a field. You may have defined sqlJoin on another field which had the type Expense, but this is only for that particular field. Joins cannot be defined once per type because the join condition can be different between any two types. This is what you must do:
const CashExpense = new GraphQLObjectType({
  description: 'Cash Expense Items',
  sqlTable: 'XXX',
  uniqueKey: 'EXPENSE_ID',
  name: 'CashExpense',
  fields: () => ({
    Count: {
      type: GraphQLInt,
      description: 'Count of Cash Expense Items',
      sqlExpr: table => `(SELECT count(*) FROM XXX WHERE EXPENSE_SOURCE = 'CASH')`
    },
    ExpenseItem: {
      type: new GraphQLList(Expense),
      description: 'List of cash expense items.',
      sqlJoin: (table1, table2) => //define the join condition here
    }
  })
})

The sqlJoin will probably be exactly the same as when you did the join on a single Expense type. But keep in mind that join monster cannot assume the joins between any two types will be the same.

May be I confused you. Sorry about that. There is no join condition required for the field ExpenseItem in CashExpense Type. ExpenseItem field is just a collection of Expense Type.
Should I remove the sqlTable and UniqueKey in that case as there is no join required for any fields in CashExpense.

And when I removed the sqlTable and uniqueKey from ExpenseItem it gave me this error.
      "message": "Must call joinMonster in a resolver on a field where the type is decorated with \"sqlTable\".",

const CashExpense = new GraphQLObjectType({
  description: 'Cash Expense Items',
  name: 'CashExpense',
  fields: () => ({
    Count: {
      type: GraphQLInt,
      description: 'Count of Cash Expense Items',
      sqlExpr: table => `(SELECT count(*) FROM EXM_EXPENSES WHERE EXPENSE_SOURCE = 'CASH')`
    },
    ExpenseItem: {
      type: new GraphQLList(Expense),
      description: 'List of cash expense items.'
    }
  })
})

export default CashExpense

Oh now I see. Then ExpenseItem is not really related to the parent CashExpense? In that case, does it even make sense to put a list of ExpenseItems inside the CashExpense? Why not make it a separate field?
{
  cashItems {
    Count
  }
  expenseItems {
    ExpenseId
    PersonId
    #...
  }
}

If you do so, you'll need to put sqlTable and uniqueKey back on that type and write a resolver on that field that call joinMonster again, just as the Sponsor type does in the example.

I will try this. This should work for me.

Tried adding the count to the Connection and it gives me an error. Also it does not print the arguments in the below block which is passed in the graphql query
onst connectionConfig = { nodeType: Expense }
if (PAGINATE === 'offset') {
  connectionConfig.connectionFields = {
    Count: {
      type: GraphQLInt,
      description: 'Count of Cash Expense Items',
      sqlExpr: table => `(SELECT count(*) FROM EXM_EXPENSES WHERE EXPENSE_SOURCE = 'CASH')`,
      resolve: async (parent, args, context, resolveInfo) => {
          console.log("print in the connection: " + args.expenseSource)
          return joinMonster(resolveInfo, context, sql => dbCall(sql, knex, context), options)
        }
    }
  }
}
const { connectionType: ExpenseConnection } = connectionDefinitions(connectionConfig)

export { Expense, ExpenseConnection }

Error that I get is.
{ AssertionError: Must call joinMonster in a resolver on a field where the type is decorated with "sqlTable".
    at Object.queryASTToSqlAST (node_modules/join-monster/dist/queryASTToSqlAST.js:37:20)
    at node_modules/join-monster/dist/index.js:9:29
    at Generator.next (<anonymous>)
    at step (node_modules/join-monster/dist/index.js:85:191)
    at node_modules/join-monster/dist/index.js:85:437
    at node_modules/join-monster/dist/index.js:85:99
    at joinMonster (node_modules/join-monster/dist/index.js:19:17)
    at schema/Expense.js:167:18
    at Generator.next (<anonymous>)
    at step (schema/Expense.js:50:191)
    at schema/Expense.js:50:437
    at schema/Expense.js:50:99
    at resolve (schema/Expense.js:165:7)
    at resolveOrError (node_modules/graphql/execution/execute.js:454:12)
    at resolveField (node_modules/graphql/execution/execute.js:445:16)
    at node_modules/graphql/execution/execute.js:252:18
  message: 'Must call joinMonster in a resolver on a field where the type is decorated with "sqlTable".',
  locations: [ { line: 17, column: 5 } ],
  path: [ 'items', 'Count' ] }


CTCSS/DCS swapped: RX is TX, TX is RX

Like the title says. R_CTCS controls the transmitted CTCSS code, and T_CTCS controls the CTCSS code that opens RX squelch. It's backwards from how it should be. Same for DCS.
Repro steps:

Key in any frequency for CTCSS, e.g. 123.0 Hz in R_CTCS.
Notice that the "CT" symbol does not appear, and that squelch is broken by any station without a CTCSS tone.
Do the same for T_CTCS.
"CT" symbol appears, and squelch is broken only by stations with matching CTCS tone.
Similar for DCS.

Seems to be fixed now.


feat(benchmarking): timer decorator

Goal
Adds a timer decorator function. Can use currying to time any async function call n number of times.
Reference
Documentation here:

Link to docs

Issues:

https://getpocket.atlassian.net/browse/INFRA-311

Implementation Decisions

I suppose using function composition?

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


how to add icon to tree

i tried
computed: {
myCustomStyles() {
return {
icon:"folder",
but it doesn't work  , I'm using material design icons ,
also i tried path of image
computed: {
myCustomStyles() {
return {
icon:"assets/images/folder.png",
it doesn't work also

Hi,
if you want to change the 'folder' icon, you need to use the key selectIcon
for example:
myCustomStyles() {
  return {
    selectIcon: {
      class: 'folder_icon',
      active: {
        class: 'folder_icon_active',
      }
    },
  };
}

I have a question related to this. I am using material design icons in my proyect. Whenever I need a folder icon, I just specify it giving folder to icon type
I tried what you said previously and it worked, but I want to use these icons from materia design, could you explain me if this is possible by using this package?
In case it won't be possible, which icons are ready to be used within this package?

Hi, the "icons" i use are defined here
If you want to use other icons, you can overwrite the class and the style like this:
selectIcon: {
  class: 'folder_icon',
  style: {
    color: '#007AD5'
  },
  active: {
    class: 'folder_icon_active',
    style: {
      color: '#2ECC71'
    }
  }
},

Hi, I have a question, I need to change the Icons individually, for each node, this is possible? thanks!!


Reopening Atom forgets read-only status

Good morning!
I have a suggestion. When I open Atom at the beginning of the day, it opens the last set of files I was looking at. However, they are no longer marked read-only. This could lead to some significant accidents. I would love to see this package returns files' read-only status to what it was when I closed Atom. Unfortunately, I don't know if this is trivial or near impossible.
Thank you for your time!

Thanks for the suggestion!
I added it to v0.1.6. Let me know if there are any problems.

It works perfectly, thank you so much!

I've actually ran in to some issues of files opening read-only when they should. As in they were closed and I double-clicked the file name to open it in a tab, and it was set to read-only. I don't think it was set to read-only when I last closed the tab for that file. I haven't been able to recreate the situation reliably, if I do I'll post back here. I could be derping, but just wanted to make you aware in case there is an issue.

Yeah the package kept the start-up settings. I'll publish a fix momentarily.


Important cookietemple template update 2.1.1 released!

A new release of the corresponding template in cookietemple has just been released. This automated pull-request attempts to apply the relevant updates to this Project.
Please make sure to merge this pull-request as soon as possible. Once complete, make a new minor release of your Project.
For more information on the actual changes, read the latest cookietemple release notes.

Sync does not work


fix: Fix extracting moving image metadata

During the migration to safer commandline execution the command for ffprobe was not updated.
This fixes ingesting moving images.

Ah, sorry! Thank you!

I guess this has no tests.


AMBARI-25472. Disable autocomplete on login screen

What changes were proposed in this pull request?
Disable autocomplete on login screen for all browsers icnluding chrome
Please review Ambari Contributing Guide before opening a pull request.

retest this please

retest this please


Like Query is not working

My spark application flow:-
HbaseRead---> Query------------------------------------------------------>dataset1
HbaseRead---> Query(CustomUDF+like(%K02028C%) filter)--->dataset2
join on both dataset1 and dataset2 ----> Action
issue
i had applied like filter on hbase rowkey but i am getting not related data in customUDF.

@weiqingy
?

@AtulKumVerma It's difficult to catch what you are explaining. Can you elaborate a bit more on what you have done, what you have tried, what didn't work and what is the error you are getting. In case of error, please attach logs.

UDF
public class CustomUdf implements UDF1<String, String>{
@Override
public String call(String arg) throws Exception {

	System.out.println("===> :: "+arg);
	return arg0;
}

As we know that the filter on data is directly push back into RegionServer.
so i have an spark application on which i have read data from two data source. First one from CSV and Another from HBase and apply like filter query on hbase and again applying join query on both the dataset which is getting from CSV and HBase datasource. after joining of dataset i am getting right data.
But the problem is after reading data from HBase i had applied a query in which i wrote a Custom UDF and applied like filter in where clause. I found some data from hbase which is not like (K08048) in custom UDF.
select rowkey,customUDF(rowKey) from temp where rowKey like '%K08048%'
@prefer above scenerio
if i remove join and simply make action on dataset of HBase then it is working fine if i used join on both dataset then i got some kind of rowkey which is not like my where clause so i got exception because its voilet my bussiness logic.


Word Vectors and Sentence Vectors

Ok. I got it how to use a pre-trained model. But I was looking for how do I get the word vectors and also the doctovec property of Bert ?

Ok. I got it how to use a pre-trained model. But I was looking for how do I get the word vectors and also the doctovec property of Bert ?

The output is in shape (Batch-size, Max-length, Hidden_model). say you have a sentence with real length N, normally we use output[0, 0, :] as the embedding for your input sequence, while outputs[0, 1:N+1, :] are the embeddings for your input tokens.

@muhammadfahid51 - for the "doctovec" property of BERT one usually simply takes the BERT output corresponding to the [CLS] token (see the examples). This however only makes sense when you fine-tune your BERT layer on the task of interest. As an alternative you could freeze the BERT weights, and feed the BERT token representations in a followup model. I'm not aware of any outstanding benefits of the later approach however.


fedora rawhide failed on iot-raw-image test

rpm-ostree status failed with error:
rpm-ostreed.service - rpm-ostree System Management Daemon
         Loaded: loaded (/usr/lib/systemd/system/rpm-ostreed.service; static)
        Drop-In: /usr/lib/systemd/system/service.d
                 └─10-timeout-abort.conf
         Active: failed (Result: exit-code) since Fri 2023-11-03 04:35:57 UTC; 14ms ago
           Docs: man:rpm-ostree(1)
        Process: 1955 ExecStart=rpm-ostree start-daemon (code=exited, status=1/FAILURE)
       Main PID: 1955 (code=exited, status=1/FAILURE)
         Status: "error: Couldn't start daemon: Error setting up sysroot: Opening sysroot repo: opening repo: Reloading remotes: Multiple specifications found for remote "fedora-iot""
            CPU: 25ms

Fixed redhat-release.


Update clap to version 4

Thanks for the PR!
Unfortunately, this requires a major version bump as clap is a public dependency of this crate and since clap would raise the MSRV to 1.60. But I guess that's fine.
Can you update the readme and the github actions to bump the MSRV to 1.60? And also, please use 4 spaces instead of tab to indent your changes (style CI is red).
I will review and test properly at a later time.

Can you update the readme and the github actions to bump the MSRV to 1.60? And also, please use 4 spaces instead of tab to indent your changes (style CI is red).

@LukasKalbertodt done

Wow, that was fast!
Please remove your "format code" commit. That's a ton of unrelated diff that doesn't really belong in this PR and should be done separately.
I will only review in the coming days, when I have a proper setup to test this.

@LukasKalbertodt Oh yeah that's annoying. I replaced the tabs with sed instead of rustfmt.

Released as v0.6.0


Unknown projection stere

Hello!
I try to use EPSG:3995 projection (http://epsg.io/3995).
But Proj4Leaflet throws error: 'Uncaught unknown projection stere'.

Hi!
It sounds like this is rather an issue with Proj4js than Proj4Leaflet.
Proj4Leaflet is more or less a wrapper around Proj4js that adapts its functionality for Leaflet, the actual projection code and handling of projection parameters is done by Proj4js.
A quick look at the projections supported by Proj4js does include stere - might it be that you're using an old version of Proj4js? (For example, the one currently included in Proj4Leaflet is quite old, AFAIK).

Thanks, you are right)


Windows 11 Pro 10.0.22621.3880 RDP Wrapp not correctly check win version and not supported

RDP Wrapper not correctly checks the version Win11 and not supported
a you help me ?

Duplicate of https://github.com/stascorp/rdpwrap/issues/2833.


Unexpected replacement characters

Expected behavior
Page content is returned as utf-8 string w/o replacement characters (wiki).
Actual behavior
The replacement characters have appeared in random places of HTML code.
Steps to reproduce the behavior

Open NodeJS console
Run the code:

var phantom = require("phantom");
function run(opts) {
    phantom.create(opts).then(function(proc) {
        proc.createPage().then(function(page) {
            page.open("http://varlamov.ru/1960870.html").then(function() {
                page.property('content').then(function (html) {
                    console.log(html.indexOf('\ufffd'));
                });
            });
        });
    });
}

run();
run();
run();
run(['--output-encoding=utf8']);
run(['--output-encoding=utf8']);
run(['--output-encoding=utf8']);

See different numbers not dependent from options
Open view-source:http://varlamov.ru/1960870.html in browser and see no replacement characters

Environment

OS: Ubuntu 14.04
Node version (node -v): v6.2.2, v6.4.0
package version: 2.1.21

Hmm looks like a legit bug. I'll see if I can reproduce it tonight. I don't think I'll have a fix soon.

I am not sure what is going on here. I have been testing this locally. But the filesize of the content is so big that it looks like it is taking forever. I stopped after the fourth attempt. Here is the output
> node bug.js                                                                                29m 17s 135ms
181150
181150
181150
181150

It was taking a very long time but I couldn't reproduce it because locally it did what it was expected.

The problem in characters. Their position doesn't matter, just open page source and you will not find '�' symbol. If you save the page content to a file require('fs').writeFile('/tmp/test.html', html) you will find this character there.

I was able to reproduce this. But sadly, I don't have a fix. Have you been able to debug any further?

Have you tried setting the encoding to utf8 in PhantomJS?

@amir20 sorry for late answer, no I haven't able. @elias-winberg I didn't find out how to do it using this repo, but I just tried to pass this setting to open method call like this:
...
page.open("http://varlamov.ru/1960870.html", {encoding: 'utf8'}).then(function() {
                page.property('content').then(function (html) {
...

...and fter third attempt the character is not disappeared (either with ```--output-encoding=utf8`` flag or without one).

@amir20 the easiest way to reproduce the bug is, to make a site where the url contains fx æøå chars and then see what you get u can use this http://tandbørsten.dk/ the problem with æ ø å and the rest of the characters is that they are url encoded.

I replaced linerstream with split. I'd like to use split2 but it doesn't work. I wonder if this will fix it. Releasing a version now.

The solution works great. Thanks!


Unity il2cpp build fix

Fixing unity il2cpp / AOT issue https://github.com/nats-io/nats.net.v2/issues/306#issuecomment-2209483081
cc @jasper-d (sorry for the tag, it'd be great if you can comment or the inner function move. I assumed it was used to save sequential local allocation)
cc @galvesribeiro

@mtmk LGTM
Sorry, I am currently a bit slow to respond.
I believe the only reason to use a local function was that it has only one call site.
NB: This function exists only to be able to outline it, since it will be called infrequently.

@mtmk LGTM
Sorry, I am currently a bit slow to respond.
I believe the only reason to use a local function was that it has only one call site.
NB: This function exists only to be able to outline it, since it will be called infrequently.

Thank you for the response @jasper-d good to hear from you. unfortunately there's been a little confusion on my part. this PR actually did not fix the ip2cpp issue. The fix is in a new PR #548 if you have a few more minutes please feel free to have a look at that one.


PIXI.VideoResource is not a constructor

I'm trying to create a new VideoResource like this
const video = document.querySelector("video");
const videoResource = new PIXI.VideoResource(video);

but I'm getting this error:
Uncaught TypeError: PIXI.VideoResource is not a constructor
According to the docs it should exist so I'm not sure what I'm doing wrong.

pixi.js version: 5.3.7

Please refer to the specific documentation for this version:
https://pixijs.download/v5.3.7/docs/PIXI.resources.html
What you're looking for is PIXI.resources.VideoResource, we have removed this namespace in v6/dev (the documentation you linked).

Please refer to the specific documentation for this version:
https://pixijs.download/v5.3.7/docs/PIXI.resources.html
What you're looking for is PIXI.resources.VideoResource, we have removed this namespace in v6/dev (the documentation you linked).


Restores screenshot tests in foryou

Fixes regression from #1088

Looks like the png files needed a refresh, but I don't see the difference


FrSky Telemetry Not Recognizing S-PORT

I've tried setting up the FrSky telemetry using a Craft & Theory Pixhawk cable per documentation. The C&T cable is connected to the S PORT of the X6R and the other end daisy-chained into a FrSky LiPo Voltage sensor then to TELEM2 of the Pixhawk (eBay 2.4.6 version).
I've tried it with both stable and dev versions of 1.6.5, 1.7.0, and 1.7.3. frsky_telemetry status in the Mavlink console says: ERROR [frsky_telemetry] running: DTYPE . As I'm made to understand, it should auto sense SPORT. I've tried swapping the Rx and Tx pins and also connecting TELEM2 directly into Rx S PORT to no avail. I tried 1.8.0 stable and it doesn't even recognize the frsky_telemetry status command.
All of the above setup changes were per @bkueng recommended diagnostic step. Apparently, the only way to force it to switch from DTYPE to SPORT is a change in the source code?
Please advise or recommend resolution.
Thanks.

This seem to be related to this: https://github.com/PX4/Firmware/issues/9240

From the Slack thread:
I told @bkueng
Hopefully this could be resolved. Otherwise, I've got $40 worth of useless cables, unless I switch to ArduPilot?
@bkueng Trying with ArduPilot is actually a good idea. Then we know if it's a software or hardware issue.
Me: Yes, it works in ArduPilot. I loaded Mission Planner 1.3.56 and ArduPlane V3.8.5. I only had the GPS connected and it immediately discovered the coordinates. So to confirm, it's not a hardware issue. By the way, ArduPilot uses the SERIAL 4/5 port instead of TELEM2. The SERIAL4_PROTOCOL param is changed from 5 to 10.

I recently made some improvements for frsky telemetry. You can now (by flashing master) specify the mode via frsky_telemetry start -m sport.

@bkueng I'm not a coder or anything so could you please give me a step-by-step on how to do this? Is this something that has to be put in the SD card? Let me know.
Thanks.

@hamishwillee My apologies. I'm just seeing this now. I didn't mention it here but I believe I did originally in the Slack forum where this started and @bkueng requested I open an issue. I'm not a coder/programmer. I'm simply a hobbyist/user with what I still consider a "newbie status" so everything you mentioned just went over my head. If you or someone can provide me the file to put in the etc\extras.txt, that I'm capable of.
Many thanks.

@rollysing I'm not a programmer either. Unfortunately, once you're talking about things that require more than just download and set a parameter, then you need to be willing to read docs and try stuff.
I guess we should step back.

What flight controller hardware are you using?

@bkueng When will there be firmware that can be downloaded from QGC that has this  - next release?

@hamishwillee I've tried it in Pixhawk 1 mRobotics and generic eBay ones v3.4.6 and v3.4.8.

The fact is that if you want to do this you will almost certainly need to build firmware. This will be non-trivial. Are you willing to try that?

@bkueng When will there be firmware that can be downloaded from QGC that has this - next release?

Yes next release. But you can also flash master via QGC if you select 'Advanced'

@bkueng So in the next release, this will be supported natively without having to do the frsky_telemetry start -m sport step as you mentioned earlier as long as the steps to setup are followed according to the FrSky Telemetry PX4 Docs?
Thanks.

@bkueng So in the next release, this will be supported natively without having to do the frsky_telemetry start -m sport step as you mentioned earlier as long as the steps to setup are followed according to the FrSky Telemetry PX4 Docs?

Yes, but this is already the case with the current release. I'm not sure what the problem is with your setup.

My mRobotics Pixhawk 1 came in today and tried to setup per docs and your recommendation. No joy! Please look at the setup and let me know what I'm missing.

I even tried this but no luck:

All I get is RSSI and RxBat (which is even wrong.)

I appreciate any assistance.
Thanks.

I even tried this but no luck:

Unfortunately frsky_telemetry is disabled on the v2 build target (Pixhawk), due to Flash limitations.
Did you flash it yourself via QGC? If the bootloader is new enough, it should automatically select the v3 target which includes frsky_telemetry. If not, you would have to upgrade the bootloader which is a more complex procedure.

Ok. I think someone needs to update the docs to let folks know it's not supported in Pixhawks that can only load v2 and/or 1MB limit.
Thanks for all the responses.

@bkueng During the firmware upgrade, it shows this. I'm presuming that means the bootloader is Version: 4? So it needs to be higher than that?

Just wanted to update before closing this. Phillip with mRobotics went above and beyond product customer service and updated the bootloader of the mRo Pixhawk to version 5. This now allowed QGC to recognize and upgrade using the Developer version of px4fmu-v3_default.px4. I can confirm that the Q X7 was able to discover all available sensors and data transmitted in real time.
@bkueng Thank you very much for all the guidance and directions.

Great! Good to see it works now.

Ok. I think someone needs to update the docs to let folks know it's not supported in Pixhawks that can only load v2 and/or 1MB limit.

It's a reasonable request, but given that such a lot disabled in fmu_v2, hard to to. For many drivers we do have a comment that users should check that the module is present in firmware.

This is something that you have to change in the Taranis, or the display script that you use. It is not part of the PX4 Firmware.

hi，everyone
I have had similar problems recently and I'm glad to see this post and comments.
But i still have a question,
X12s was able to discover all available sensors and data transmitted in real time.
but the YAAPU LUA scripts did not works,
I would like to ask if any of the supported scripts are recommended?
or what should i do?
Thanks a lot
Here are my setup:
Frsky horus X12S
Pixhawk4 with PX4 1.8.0
X8Rreceiver

Hi
Someone would have add support for PX4 to the YAAPU script, as it is specifically designed for ArduPilot.
I know that LuaPilot works with PX4 and you find instructions here: https://docs.px4.io/en/peripherals/frsky_telemetry.html#taranis---luapilot-setup.

嗨，
我最近遇到过类似的问题，我很高兴看到这篇文章和评论。
但我还有一个问题，
X12s能够发现所有可用的传感器和实时传输的数据。
但是YAAPU LUA脚本不起作用，
我想问一下是否建议使用任何支持的脚本？
或者我该怎么办？
非常感谢
这是我的设置：
Frsky horus X12S
Pixhawk4与PX4 1.8.0
X8Rreceiver

px4 don't support yaapu lua scripts。

@zhaoxiaowei1013

px4 don't support yaapu lua scripts。
It can but you need to use a Teensy 3.2 with Eric Stockenstrom’s firmware. Read the developments. I have a Jumper T16 (works like Horus X10/X12) and it works very well.

Good luck.

@zhaoxiaowei1013

px4 don't support yaapu lua scripts。
It can but you need to use a Teensy 3.2 with Eric Stockenstrom’s firmware. Read the developments. I have a Jumper T16 (works like Horus X10/X12) and it works very well.

Good luck.
I am devloping  PX4 firmware to support yaapu lua scripts ，and  thank your suggest。

@zhaoxiaowei1013 Is it your intention to write the code so it connect directly to the SPort of FrSky Rx without needing a Teensy or Telemetry Cable  and natively work?


Correlation plots are basically unreadable

The labels are too large to match the rows/columns they are attached to. One approach to consider is breaking it into chunks using black lines, and identifying the clusters, such as a/tCompCor, cosine basis, motion parameters. Then there could be enough room to help identify the order of the handful of gross signals (GS, CSF, WM) and summary confounds (FD, DVARS).

Oh, meant to link to a full-size report: http://datasets.datalad.org/labs/poldrack/ds003_fmriprep/sub-01.html
I'm guessing we were mostly looking at the dummy reports produced on Circle with a small TR count?

Closed via #2252


Accessibility consultant: add areas of expertise

@greatislander is this referring to what areas they can help with, like booking service providers? if so, close?


The cursor resets to the start of the line

VSCode Version: August 2020 (1.49.1)
OS Version: Windows 10

Info about this bug (or) error:
When I am writing my code it skips to the start of the line. It did not happen before and started happening after the update
I have Auto save feature on and I thought that was the reason but when I saved manually the same thing repeats (it goes back to the start of the line). I did try restarting the vs code and even my system but none of them worked. Any help I can get will be greatly appreciated. Thank you

Does this issue occur when all extensions are disabled?: Yes

I would like to know does this error occurs when you write code in a specific programming language or for all languages?

It did while I was writing JavaScript code (React) as per other languages it didn't happen (other languages :- C, python)

Do you have format on save enabled?
Any other settings that could cause this? The easiest unset all settings is with the Settings JSON editor.

Thank you @aeschli  it was formatting the document whenever it was getting autosaved, I had no idea how to revert this back and so I uninstalled and reinstalled vs code and its fine now
But can you please explain how to disable the format on save

There's a setting "editor.formatOnSave"

thank you


not supporting windows ?

I cannot install ffcv on windows server...
anyone ?

#93 has been merged. You can already use it by cloning directly.


(maint) Fix some typos in the releasing doc

Waiting for CLA signature by @lucywyman
@lucywyman - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/
Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html


Recorded video using MediaStreamRecorder freezes on the first frame but working when WhammyRecorder is used.

I am currently trying to implement a screen sharing with recording. The user could either share screen and record it or receive a screen share and also record it. When I am the screen sharer and the recorder. I could successfully record and play the recorded video. But when I record a remote screen sharer. Every time I download it. The file size is normal. But When I play the video. It freezes on the first frame and does not continue playing.
This is using the MediaStreamRecorder recorderType. But when I changed it to WhammyRecorder. It could be played. What are the scenarios where in the video is succesfully recorded in WhammyRecorder but not on MediaStreamRecorder? And what causes for the recorded video on MediaStreamRecorder to not play and pause on the first frame?

Encountered the same problem. I also used the MediaStreamRecorder and the file downloaded for the recording of the remote screen share cannot play (stuck at the first frame). @muaz-khan May we get insights about this?

I also encountered the same problem. First, I thought that the stream was broken. But when the stream was local, the recorded video was working.
WhammyRecorder produced heavier file compared to MediaStreamRecorder.

I have encountered with the same issue. One additional thing to note is, this only hapens for remote video only streams. When the stream has a audio and a video track the MediaStreamRecorder outputs a playable file.
As a workarround I capture a local audio track (mute it) and add to the stream to get a proper recording output and it works.


Move Travis CI and Doxygen scripts

The purpose of this PR is to move both .travis and doxygen directories in the scripts one, to keep all scripts related data in one place, plus removing some old and unused Doxygen related scripts, including also the related Travis job based on the update_dox.sh build script (which at some point wasn't triggered anymore, see #164).

For now travis is kept like it is, only dox changes are kept.
A backup branch is kept at jpcima/moved-scripts.bak


Windows: using edge as workbench.externalBrowser opens default browser too

Type: Bug
My default browser is Firefox.
I have workbench.externalBrowser set to edge
After running npm run dev on any web project and clicking the localhost link to open the website I would expect vscode to open the website in Edge only.
What actually happens is that VsCode open the website in both Firefox and Edge
It does this will all extensions disabled.
It's very annoying.
It's a Vite React project I'm using, and in addition to opening browser tabs in both Edge and Firefox, VsCode is only actually establishing a browser link to the Firefox tab. So any compilation errors from Vite go to the Firefox console but not the Edge console. So despite having set workbench.externalBrowser to edge, the Edge browser tab that gets opened isn't even usable.
I see the same behaviour whether I run npm run dev in either the embedded cmd or Powershell terminals.
I also created a new create-react-app using the instructions from here, and then manually added an Edge launch profile as described in that guide. This also had no effect and clicking the localhost link in the enbedded terminal just ignored the workbench.externalBrowser setting and opened the website in Firefox.
VS Code version: Code 1.94.0 (d78a74bcdfad14d5d3b1b782f87255d802b57511, 2024-10-02T13:08:12.626Z)
OS version: Windows_NT x64 10.0.22631
Modes:

System Info

Item
Value

CPUs
13th Gen Intel(R) Core(TM) i7-13700H (20 x 2918)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabledwebnn: disabled_off

Load (avg)
undefined

Memory (System)
31.68GB (17.86GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

I can reproduce, and it seems due to launching edge writing to std-error here, which makes us fallback to the default browser:
https://github.com/microsoft/vscode/blob/dc265add0b37d88dcf955ef83c8d483e35af242c/src/vs/platform/native/electron-main/nativeHostMainService.ts#L543-L546
The error logged is:
[main 2024-10-06T13:28:29.919Z] Error openening external URL 'https://github.com/microsoft/vscode/issues' using browser 'edge': #< CLIXML

We are using a 3rd party library for opening: https://github.com/sindresorhus/open
If someone has ideas, marking for help wanted.

Device: Microsoft Windows 11
Vscode version:1.94.0
I find an odd phenomenon: when I set workbench.externalBrowser in my setting.json file with any value like 'chrome' or 'edge' my vscode can't open any external url anymore and when i  leave it with space then it can open url correctly using my default brower. Why does this happen?

Grabbed the system command thats executed by the "open" library to open the external browser and ran the same in a cmd instance, the stack is clean and I dont see any error, stderr doesnt seem to be expected here.
https://github.com/sindresorhus/open/issues/348
opened an issue in their repo.

I think I have a similar issue, but not exactly the same.
Version Information
Version: 1.94.0 (user setup)
Commit: d78a74bcdfad14d5d3b1b782f87255d802b57511
Date: 2024-10-02T13:08:12.626Z
Electron: 30.5.1
ElectronBuildId: 10262041
Chromium: 124.0.6367.243
Node.js: 20.16.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22631
Behaviour without "workbench.externalBrowser": "chrome"

Behaviour with "workbench.externalBrowser": "chrome"

That document should get you setup running VS Code out of sources and test your changes.

Hello @bpasero! I just wanted to follow-up with you - I have made a PR with some changes that seem to work on my end.
If you have the opportunity, can you check to see if these changes are valid?
Thank you!

Sorry, I did not yet get back to your PR, while investigating what happens.
The full message output from PowerShell.exe is:
#< CLIXML

<Objs Version="<IP_ADDRESS>" xmlns="http://schemas.microsoft.com/powershell/2004/04"><Obj S="progress" RefId="0"><TN RefId="0"><T>System.Management.Automation.PSCustomObject</T><T>System.Object</T></TN><MS><I64 N="Sour
ceId">1</I64><PR N="Record"><AV>Preparing modules for first use.</AV><AI>0</AI><Nil /><PI>-1</PI><PC>-1</PC><T>Completed</T><SR>-1</SR><SD> </SD></PR></MS></Obj></Objs>

Maybe a low risk fix is to just detect this case 🤔

dear sir, thank you very much for so much concern. Actually, there is a lot to tell you people the team of Microsoft Google One especially get up and Apple that I had been in pain since the last 45 years that my billions of crypto is in risk I was working with petroleum starting from 2007 to 2013 then I move to group of countries here in Pakistan in 2019. My wife is a doctor and she just started her carrier and she got Covid in 2019 I was in out of my town actually is like 45 Hours Dr. from my village, which is my hometown. The thing is by bike after spending like 1516 years at very top level with two marketing companies in Pakistan I decided that I should go back to my home because my my wife was in a very critical position then I took my three kids and my wife and I came back and I quit my job I belong to a very royal family. I did my bachelors from university of Cambridge Singapore. Then I did my masters in business information technology from Lahore Pakistan one of the top institutions thing is to tell you that when I move from Covid Faisalabad to my hometown, there was no Internet facility at that time and buy two laptops my personal laptops then my my computer my my devices my iPhone X I was out of Internet. They just got paid for almost one year. It was a very difficult scenario for me. That was a very difficult period for me after my wife got Covid then my cricket got Covid.  I couldn’t even go to ATM to take my cash for longer time and then the statement of Pakistan and then my bank account for free without any reason I think there was a information floated by you, people Microsoft, and whatever that I was holding a lot of stocks in your stock change and actually with Microsoft office, I was holding my personal office in that I was having billions of dollars at that time then when I started taking prescription subscription of the app from Microsoft store Microsoft store and then I move to Apple technology before that I was holding technology. A lot of things got mixed and what I think is that Microsoft was thinking that I am the owner of the company actually you people were thinking that I am the owner of and I am the owner of LaGuardia because I was my Internet for totally safe and things were totally safe and I was working at the very top position but at the same time I was I was I was holding my private Microsoft OneDrive since long. It’s been almost 16 years that I am I am owning almost more than 100 apps subscription app. You can check my record, but the thing is when you contacted me. I decided that you people offered me somebody. Nobody was in front of me actually I think the guys from Google I am or Apple Microsoft contacting me that your stock where are you? Are you dead? I felt into Covid since then they asked me that you are holding a lot of money. What are your plans? I asked that I am thinking that I will bring a huge amount of money and Pakistan it rest for me. I am planning will either take it to UAE Singapore or whatever I was planning but at the same time somebody offered me that why don’t you take the crypto I was actually almost 0 knowledge of having crypto knowledge but actually I am masters MBN tech technology. I just studied 23 days. Please give me my money wallet you transferred my money interest wallet the billions of dollars so I took three days almost and I was having at the time iPhone X of storage 512 GB the thing is that I was already having 2 to 300 GB of storage in my iPhone and then when the transaction started my phone just stuck by the Apple logo after three days and it was a shock that it was happening. It was happening very first time with me that I thought that this huge amount of money is gone when I have repaired my phone through local market because Pakistan at that time there not a lot of facilities then when I got repaired my phone since that day took a lot almost 4 1/2 years that that bloody trust and financing nobody is just giving the test to my pain my family pain that I am requesting you all where is my money? I am holding. I gave you a lot of proof every document saying to people that this bloody acid belongs to me. A lot of emails and a lot of portfolios have been created at the thing is that my data passes went to 3000 GB I don’t have any device with which is of 3000 GB. I am holding a lot of subscription subscription like I am holding 2000 GB from Apple 2000 GB from the dropbox and 2000 GB from TeraBox. Everybody is packed.  Nobody is listening where the bloody that stock is where is my money? why don’t you give my money back please the thing is I’m giving you the proves for the reason that that money belongs to me. Please give it to me that’s it.
Sent from Yahoo Mail for iPhone
On Friday, October 11, 2024, 3:19 PM, Benjamin Pasero @.***> wrote:
Sorry, I did not yet get back to your PR, while investigating what happens.
The full message output from PowerShell.exe is:
#< CLIXML
System.Management.Automation.PSCustomObjectSystem.Object1Preparing modules for first use.0-1-1Completed-1
Maybe a low risk fix is to just detect this case 🤔
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Pushing https://github.com/microsoft/vscode/commit/bb19ce3f00302e797376767188a3933a95666170 as a quick workaround for Windows.

I am leaving this with my workaround for now as it fixes the reported issue. The only downside is that now when you mis-configure this setting, we have no fallback. I am willing to revisit this if more people report this as being annoying.


Added missing hyphen

Added missing hyphen for server/client-side and removed one on the ending of 'ajax'

Merged. Thanks!