Fixing an issue when the droppedFiles array is empty

I'm using both Sortable and react-dropzone in the web interface, and made the whole body a dropzone like below:

However, when I drag and drop sortable widgets only within the UI, but not dragging files from somewhere else, it will still invoke react-dropzone's onDrop method, and generated an error:
Uncaught TypeError: Cannot set property 'preview' of undefined

Since there are no files, it should stop proceeding and return immediately if the droppedFiles array is empty.

That's awesome! Thanks!
Could you please also add tests for it?

I just added a simple test. You can do the verification again. Thanks.

I'll close this one in favor of #156. Thanks for the contribution!


[plot3d] Add a special item for the top group of the scene

This PR changes the way to handle the top-level group of the SceneWidget so that applied transforms are taken into account in the axes.
Before applying a transform at the top level had no visible effect, while now it is visible in the value of the axes.

LGTM


[Enhancement] Method makes literal string comparisons passing the literal as an argument [GrpcClientHandler]

Search before asking

[X] I had searched in the issues and found no similar issues.

Enhancement Request

located at:
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/admin/handler/GrpcClientHandler.java line 188,191,194
analysis and explanation:
This line is in the form of String str = str.equals("someOtherString");
A NullPointerException may occur if the String variable str is null. If instead the code was restructured to String str = "someOtherString".equals(str);that is, call equals() on the string literal, passing the variable as an argument, then this exception could never happen as both equals() check for null.
Describe the solution you'd like
Adjust the code to String str = "someOtherString".equals(str).
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

I like to work on this issue.


Testing: Add listeners to DropwizardAppRule

This PR adds the ability for tests using DropwizardAppRule to hook the Application lifecycle.  It additionally includes a convenience method to add Managed objects to the lifecycle.
@ClassRule
public static final DropwizardAppRule<TestConfiguration> RULE =
    new DropwizardAppRule<TestConfiguration>(MyApp.class, resourceFilePath("my-app-config.yaml"))
            .manage(new MyTestManagedObject());

There are many cases where tests need to add Managed objects to the application lifecycle and execute code in the application onRun method.  For example, many of our services use an ActiveMQ bundle which handles connections to a remote ActiveMQ server.  When testing these services we want to standup a local broker and override the config to use this local broker.  The changes in this PR are what make that possible.

LGTM. Thanks!

A good amount of issue #789 is resolved via this merge


Dockerfile needs overhaul

So, with the move from multiprocess to multithread we should and need to update the Dockerfile accordingly.
My suggestion is that we run the AGTserver in its own Docker, since it is likely that the AGTs will run on a separate unit.
Also, I propose to put the Feeder in a Docker image of its own ( debatable but I don't care).

Currently trying to get redis and the feeder to communicate over a unix socket db. The idea is to create/mount a volume separate from the feeder and the redis state storage server. However, I don't get permission to bind to the unix socket.
See , docker-compose-bb.yml.
The file redis.conf points to /var/tmp/vissv2/redisDb.sock . So , trying to create a volume using Busybox image with that exakt path. ...However, still gets permission denied.

Managed to solve the socket permission problem. Look in docker-compose-bb.yml. It seems that you need a clean directory which in my case I used: /var/docker/ in the busybox. This was then also reflected in the redis.conf file(which is a bit sad since we are not able to reuse the dirs already provided there). However, redis is no listening on a unix socket mounted in a different container based on the busybox image.

@petervolvowinz , I hope you will push an overhaul according to your comments.
The Docker files, and related README have been moved to a separate docker directory.

Well, the feeder cannot run by its own. It needs to be in the same docker compose since we are using unix sockets.

I have a working version of docker compose without the AGT server. Will try to push this master. The Dockerfile and docker compose should reside in the project root. There is no multiprocess support , since there are no sources that support this on master anymore. For this we should refer to the multi-process branch.

Great!
There is no need to support multi-process as I see it. That branch is not kept up to date with what goes in on the master branch.

this is done.


RFC: D3D9 client merge into main

Suggest to review & discuss proposed merge of D3D9Client into Orbiter main. Full history of d3d9client has been merged, and CMake intergrated with main build. Potential points of contention:

API backward compatibility
Increased size of build
Documentation/includes placement

All credit of course goes to @jarmonik & other D3D9 contributors (I only helped to integrate it into Orbiter repo) - however, I think kicking off discussion on this early would be beneficial

I tested the d3d9client branch and the only problem I saw is issue #145

I tested the d3d9client branch and the issues #157 and #145 are fixed.

Is it still the intention to merge D3D9 into Orbiter's main branch? Does this still need more testing after the merge conflicts are resolved?

Lets get this moving shall we?
As proposed here I'd like to propose that we merge this into a fork that will include enhancements over the Orbiter core.

Martin, I see that you improved a lot the D3D9client CMakefiles.txt,
Thanks a lot for that
I still do not understand this line
set(ORBITER_SOURCE_SDK_INCLUDE_DIR "${CMAKE_BINARY_DIR}/Orbitersdk/include" "${CMAKE_SOURCE_DIR}/Orbitersdk/include")
I do not see why d3d9client needs to search for "${CMAKE_BINARY_DIR}/Orbitersdk/include" ?
binary dir instead of source dir ?
I suggest to change to set(ORBITER_SOURCE_SDK_INCLUDE_DIR "${CMAKE_SOURCE_DIR}/Orbitersdk/include")
for me it causes build to fail when it is not a clean rebuild all

@spacex15 you are right, it is a bit strange that both the source and binary directories are included. I don't think the line was written by me, so I am not sure what the idea here was. The build directory version of Orbitersdk/include may have been added to include dynamically generated header files.
Even stranger, there is also an "IncludeDir" which points to the source Orbitersdk/include, but is used as an output target for dynamically generated header files, which seems very unclean.
I'll try to figure out the intent here and see if I can come up with an alternative solution.

@spacex15 : does this latest commit work better for you?

Yes it works for me
minor problem still persistent
It builds everytime the following D3d9client DLLs
DrawOrbits,TerrainToolbox,DX9ExtMFD,GenericCamera
even if nothing waas touched


Provide portable version for Linux

Please provide a portable version (application bundle) for Linux that can be run without the need to install anything first on the machine, for example an AppImage.
Providing an AppImage would have, among others, these advantages:

Applications packaged as an AppImage can run on many distributions (including Ubuntu, Fedora, openSUSE, CentOS, elementaryOS, Linux Mint, and others)
One app = one file = super simple for users: just download one AppImage file, make it executable, and run
No unpacking or installation necessary
No root needed
No system libraries changed
Works out of the box, no installation of runtimes needed
Optional desktop integration with appimaged
Optional binary delta updates, e.g., for continuous builds (only download the binary diff) using AppImageUpdate
Can optionally GPG2-sign your AppImages (inside the file)
Works on Live ISOs
Can use the same AppImages when dual-booting multiple distributions

Here is an overview of projects that are already distributing upstream-provided, official AppImages.
This would address the Linux part of https://github.com/warner/magic-wormhole/issues/173.

Although this could be possible, it would again, be a HUGE file as most of what it uses are not available by default on live images etc.
This is related to #208 , which I'm already working through, I can take a look at this next :)

Is there a good comparison of AppImage, snapcraft and flatpak? They all sound very similar to me and I'd like to understand the pros and cons of each approach.

@meejah  http://lmgtfy.com/?q=AppImage%2C+snapcraft+and+flatpak

Okay, so which of those results is the "good" one...? ;)

In my experience, AppImage tends to be the simplest system for distributing portable applications (it's probably also the easiest to understand for less experienced Linux users). It also works quite well with systems where you don't have root access, and works on very old distributions if the AppImage is compiled on an old enough base system.
From what I've seen, Flatpak and Snap seem to focus on more robust (but more complex) application distribution; they require some sort of runtime to be installed, and aren't as easy to get started with (for end-users downloading your application).

Why not just build a small package like youtube-dl does?

@djmattyg007 this would certainly be possible but not give you all of the advantages stated in my original post.

I really like to see such a project getting more publicity lately, it actually deserves it. You're making an essential problem of using a computer, exchanging files, become really simple (heck, I could exchange the code via telephone, that is like how some of the most used remote support tools do it), but also really secure. Great to see such a project evolve over time. I'll certainly use it from time to time in the future, now that I know about it.
The AppImage team and its users (greetings to @Calinou) would like to help you with the process, you're not alone. @probonopd probably just intended to get you interested and wanted to make sure that you're willing to build and later maintain the AppImage, because both is really important. The process is rather simple, we've documented it to some extent on this page. We're interested in providing a more complete documentation on this, so getting experience is another reason we're interested to help with packaging Python apps.
As a passionate Python user, I'm aware of packaging Python apps to AppImages is not as easy as it should and could. But it's certainly doable and, even better, can be automated pretty easily, and in my experience most flexible (that is, version agnostic) recipes (that's what AppImage build scripts are called) work forever, with just minor maintenance required from time to time.
I think it's time to write something like stdeb for AppImages...

@probonopd When I download youtube-dl from this page:
https://rg3.github.io/youtube-dl/download.html
I get a binary that has all of these advantages:

An application packaged as a python executable script that can run on many distributions (including Ubuntu, Fedora, openSUSE, CentOS, elementaryOS, Linux Mint, and others)
One app = one file = super simple for users: just download one python executable script file, make it executable, and run
No unpacking or installation necessary
No root needed
No system libraries changed
Works out of the box, only need python installed (which almost all Linux distributions have pre-installed)
No desktop integration necessary as it (like wormhole) is a command-line application
The python executable script is usually small enough that delta updates are unnecessary
Can optionally GPG2-sign your python executable script, this isn't magic
Works on Live ISOs (python is more likely to be installed than anything to manage AppImages)
Can use the same python executable script file when dual-booting multiple distributions

Here is an overview of a basic collection of scripts to create a distributable python executable script used by youtube-dl.
Following this approach would address the Linux part of #173, without needing anything other than python.

@djmattyg007 indeed such a script would be good to have.

My point is that for a command-line application, using any sort of containerised application image format is complete overkill.

As long as the command-line application does not need any Python modules and such.

@djmattyg007 you cannot compare youtube-dl with wormhole and claim both work like the same. Let me explain this below.
First of all, youtube-dl has no install_requires declared in its setup.py. This means that it can run off a basic Python installation, and doesn't use anything but the standard library. wormhole on the other hand does have a bunch of requirements. It won't run with just a basic standard library, it requires several modules of which some depend on compiled binaries. Some dependencies have themselves dependencies which require other libraries that need to be installed on the system or bundled with wormhole.
Thus, the following claims are just wrong:

Works out of the box, only need python installed (which almost all Linux distributions have pre-installed)
No unpacking or installation necessary
No system libraries changed
The python executable script is usually small enough that delta updates are unnecessary
Works on Live ISOs (python is more likely to be installed than anything to manage AppImages)
Can use the same python executable script file when dual-booting multiple distributions

As you can see, there's more to do than just creating a Python egg and ship that. There's tons of dependencies that, for a portable application bundle, need to be distributed, too. Thus, the UX of a Python egg in comparison to an application bundle is way worse.

I've had success doing this sort of thing with pyinstaller which can also target Mac OS.

So has anyone tried it with PyInstaller yet?

For Linux, this option just opened up:
https://github.com/Intoli/exodus

@srk I don't see how that'd work for any Python related packaging, as you can't bundle any "auxiliary files" such as Python code files. Please elaborate.

Ah, not the extra files. Suggestion withdrawn.

Just a little update, we have made making AppImages for Python apps a lot simpler last year by developing linuxdeploy and linuxdeploy-plugin-qt. Example projects are appimagelint and appimagecraft.

No fault to Warner, the package ecosystem for Python is just a mess and I finally gave up. I'm using croc instead, which was inspired by wormhole, but as it is written in Golang it compiles down to a single static binary with few dependencies. Runs cross-platform.
https://github.com/schollz/croc

related:
Suggestion: would Nuitka (nuitka.net) provide useful standalone binaries? #255


Delete minischeme-history

Moved to https://conservatory.scheme.org/minischeme/ which is a more logical place for it.

I think you're right. It belongs with other issues of Scheme implementation history

Yes, I originally put it in the surveys since there was no other obvious place to put it. Now there's the Conservatory.

(each relevant Scheme implementation deserves one, I think)

That's a good idea. Chez even has a retrospective paper written about it. Gambit had a workshop on its 30th anniversary, but I don't know if a one-paper summary has been published.


DeepReadonly: Type 'unknown' is not assignable to type 'Readonly'

type Test1 = {
	abc: unknown
}

const val: Test1 = { abc: '' }
const val2: DeepReadonly<Test1> = val

Gives the error:
error TS2322: Type 'Test1' is not assignable to type '{ readonly abc: Readonly<unknown>; }'.
  Types of property 'abc' are incompatible.
    Type 'unknown' is not assignable to type 'Readonly<unknown>'.

This lets it translate the type cleanly across

I don't think this is a valid solution -- unknown is not a primitive type, same as any isn't. And while my concern initially was only about the naming / meaning of the "primitive type" phrase, it looks like the tests stopped working :)

yeah once I saw the tests failing I started to have a deeper look locally. Ill unmark the pr as a draft once I have a solution which passes in the tests

I don't have any ideas right now on how to match unknown in a complex interface.
For now I have updated this to include an property of type unknown in the test cases, to show which types have problems, and I shall return if I can find anything on how to match unknown


Add compatibility with grid mean predictor

plus additional cleanups

Thanks for the PR @KonstantinWilleke!
I looks good, and I just have one comment regarding the hub dataloader: Honestly, the more I think about it, the more I realize the hub dataloaders are unnecessary. However, if you want to use it and keep them it's fine with me. But let's avoid giving time-wise promises (e.g. dates, etc.) because we do not really know when the hub interface will become functional.

I'd still like to keep it, especially because we promised it in our proposal. But I agree that we should leave out the date and not make specific promises!


what is the package for using =require slate/a11y.js

I'm just wondering what package is used for the importing of JS in the theme.js as I'd like to use it elsewhere but couldn't figure out what package makes it work
thanks!

@yangkennyk In the public docs, there is a note about this https://shopify.github.io/slate/js-examples/

In the theme.js file, you must import the Section specific JavaScript with the // =require helper, more information here, as it will contain your constructor.

@yangkennyk the package is gulp-include


Subresource integrity example

R: @addyosmani @ebidel @gauntface @PaulKinlan etc.
CC: @mikewest
Quick sample showing off the use of subresource integrity to allow one CSS file to load and block another.

Sample reviewed and LGTM. @mikewest would be great to get your sign-off before we land this.

friendly ping @mikewest as we'll need to land this before Thursday for M45 posts going out :)

Lgtm

LGTM too, sorry for the delay!
On Tue 21 Jul 2015 at 16:14 Eric Bidelman<EMAIL_ADDRESS>wrote:

Lgtm
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleChrome/samples/pull/162#issuecomment-123327184.

Thanks for the review, all!


Mouse back buttons, middle mouse scrolling

OS: Arch Linux (kernel 4.4.4)
Issue Descriptions: pressing mouse buttons 4/5 do not go back/forward. Holding middle mouse button and moving the mouse does not scroll.
Steps to Reproduce: press mouse buttons 4/5, hold middle mouse button.

The mouse button 4 and 5 issue is fixed in master.  The mouse button 5 is an electron thing and something I can't fix.


python310Packages.macfsevents: 0.8.1 -> 0.8.4

Description of changes

Things done
Changelog: https://github.com/malthe/macfsevents/blob/0.8.4/CHANGES.rst

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 233700 run on x86_64-linux 1


OpenJDK local disk check not working on AIX

WARNING: Your build output directory is not on a local disk.
This will severely degrade build performance!
It is recommended that you create an output directory on a local disk,
and run the configure script again from that directory.

@sxa555 informs me that the check uses df -l which isn't a valid flag on AIX

The simplest way to resolve this may be to modify the PATH to include /usr/sysv/bin before /usr/bin as that has a version of df that supports the -l option. A less drastic approach would be to set DF='/usr/sysv/bin/df" to force configure to use that

hmm okay, fancy submitting a PR to auto export that env var if we are on AIX?

Hmm /usr/sysv/bin/df isn't quite working the same. Unless you specify the exact mount point as a directory (i.e. normally . or $PWD won't work as they're deeper down the file system) it doesn't give the expected result ... Still investigating

https://bugs.openjdk.java.net/browse/JDK-8189619 raised to fix this upstream

@sxa555  - The patch has landed upstream - can this now be closed or does that patch need to be backported.

We are waiting for this to be backported to 8 and 9. Not sure if any progress has been made with that yet.

@sxa555 Is this still important?

this bug has been fixed upstream


changed signature of add and mul for int and float to accept varargs

— because it was inferred so from examples, and also matches with the existing definition of binary boolean operations (and and or)
I propose either this alternative or the one in another pull request.

@eyihluyc I don't think it will compile like this. You also have to change the implementation of atoms, not only the declaration.

@yegor256 Yes, I probably should have submitted this as an issue.


Support colons in scp paths

While fixing the #2064 bug, I tried to simplify both code and tests, fix the TODOs...
I created small commits so that it's not too hard to review.
@docker/machine-maintainers Can you take a look please.

LGTM
This is important in making windows a first-class platform.

I'll need some time to review.  We're pretty far into the weeds for 0.5.0, so maybe we can tag it for release in 0.5.1.

I'm ok with that

LGTM -- please squash the commits before we merge.  Thanks!

Thank you @ehazlett! I think @nathanleclaire wanted to take a look after the 0.5.0 release. Unless we change plan, I'll leave the commits as is until then.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "2064-support-colons-in-scp-paths" git@github.com:dgageot/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

squashed and merged! Thanks @ehazlett and @dmp42 for the feedback

It's probably fine but, I did want to at least take this for a spin before merging.

Sorry @nathanleclaire, I merged since I had 2 LGTMs. Feel free to give your feedback


Add CI test for Win ffmpeg 4.4

Use ffmpeg binary from ~https://github.com/BtbN/FFmpeg-Builds/releases~ pyav-ffmpeg.

Hm. using third-party binary builds has bitten us in the backside in the past. I'm wondering if we should just use our own builds from pyav-ffmpeg if we cannot rely on conda anymore?

Yeah, we could just do that too. It does seem that something is wrong with the Windows conda builds.
FWIW the repo used is linked off the [ffmpeg.org webpage](http://ffmpeg.org/download.html#build-windows),

Updated to use the pyav-ffmpeg binary

Looks good to me, can you squash your commits please?


Safari + TypeScript branch: No GrainPlayer Audio

It appears that no audio is emitted when using a GrainPlayer in Safari.
Example with annoying looped sound

Seems like probably an autoplay issue. The context is still 'suspended'.
Try initiating the sound with a user interaction. lmk if that fixes it.

@tambien I've updated the fiddle to require an interaction and added a regular Player as well. The Player works but GrainPlayer doesn't.
Might be related to https://github.com/Tonejs/Tone.js/issues/570?

I've actually updated the example to remove the loops so you can hear if something is triggered or not. What's strange is that:

Press "start player"
Sound starts
Press "start grain player"
sound starts

but if reloading

Press "start grain player"
No sound

Still seems like a autoplay issue to me. If i log the state of the console after starting the GrainPlayer it still says 'suspended' in Safari: https://jsfiddle.net/yotammann/75ugyLom/
The relevant difference between Player and GrainPlayer in this situation is that GrainPlayer does not create and start AudioBufferSourceNode on start like Player does on click (which would satisfy the autoplay starting the context). Instead GrainPlayer starts a clock and in the clock's callback function it creates and starts the underlying AudioBufferSourceNodes.
The surest way to fix this issue is to explicitly call Tone.start and wait for the promise to resolve before trying to start or schedule anything.

You're right, here's what happens with Tone.start in the callback.
I was incorrectly assuming that if Player automatically started the context, then GrainPlayer would do the same.
I wonder if having some sort of developer feedback via the console would be helpful in situations where start is called on a 'suspended' context would be helpful?
Regardless, closing this. Sorry for the noise.


X and Y flip on multi-tile stamps

I'm just starting out with both LDtk and DragonRuby, so this bridge came in handy. I have a LDtk level with 16x16 tiles, some tiles form a bigger tile e.g. 32x32 -- 4 tiles in a 2x2 stamp. I got the bridge to work with my sample level, and found a few stamps were showing up wrong due to being x and/or y flipped:

I don't quite know what to do with the info yet, but the tile's "f" field tracks the flip with 0=none, 1=x , 2=y, 3=both).

Thanks for using my bridge.
In LDtk, do you use different grid sizes on the layers?
Indeed, the support of the possibilities of LDtk is only partial on LDtkBridge. I only added what I used. I never used different grid size in same LDtk project...
So currently, LDtk doesn't support multiple grid size, but I can dive back into the code and into the json of LDtk to try and add it.
In the meantime, a very practical option of LDtk is the export of each layer of each level as an independent png file that you can then use directly as a classic image in DragonRuby (big performance gain because you display a single image per layer instead greatly

Oops, I misunderstood your issue...
I'll take a look at the rotations

What version of LDtk are you using ?

I just added the flip field f in layer_data
normally you should now have access to this value by you_layer.layer_data[tile_index][:f]
Could you do a test?

Works here

If you want, I can add the flip_vertically and the flip_horizontally fields with boolean value in each data tile to be DR friendly ?

I downloaded the newer version, added the flip assignments to my code, and all looks good. Thanks for the quick reply!


Images.java:37-38: Keep implementing the rest of the...

The puzzle 83-f448d301 from #83 has to be resolved:
https://github.com/amihaiemil/docker-java-api/blob/bc8e27a93cff11821587f082de9b238e0a506af6/src/main/java/com/amihaiemil/docker/Images.java#L37-L38
The puzzle was created by Mihai A on 07-May-18.
Estimate: 30 minutes,
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@amihaiemil/z please, pay attention to this issue

@0pdd/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

Job #98 is now in scope, role is DEV

The job #98 assigned to @llorllale/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this

@0crat waiting on review/merge of #106

@0crat waiting on review/merge of #106 (here)

@llorllale The impediment for #98 was registered successfully by @llorllale/z

The puzzle 83-f448d301 has disappeared from the source code, that's why I closed this issue. //cc @amihaiemil

Order was finished: +30 point(s) just awarded to @llorllale/z

The job #98 is now out of scope


Translation incomplete

tried to switch to our hindi translation, and it seems some things are not in the translation file?

@TouchstoneTheDev
mainly the transfer, teleport bridge, onchain identity, migrate, settings, and then in navbar its learn

So i guess i should translate it entirely no loanwords !?

would you say those loanwords are integrated well and are understandable in your language? Another thing to consider is whether it conveys the same meaning or loanword is necessary.

Have you conducted any peer review just asking for remarks*

nothing that I know of sir

Assign me this Issue

assigned, you can translate words you think are worth to be translated, words that are needed to convey the exact meaning can stay as loanwords


Allow pattern matching over the route combinators

The API may looks close to:
val e = EndpointX {
  case Get / "a" / int(id) => service(id)
}

:eyes:

Seems that we probably don't need this anymore: we've moved to slighlty different path - heavily using combinators API.  Close this for now.


GT assignment and AO counts are inconsistent

Erik,
The GT value sometimes is non-zero (i.e., references an alternative allele) although there are no AO counts (meaning that no alternative alleles were observed in the bam files!).  How can you call an alternative allele without observing any instances of it in the data? This seems impossible...
The call I'm making is:
freebayes
--region chr:0-200000
--fasta-reference ref.fa
--pooled-continuous
--haplotype-length 0
--min-base-quality 30
--min-mapping-quality 20
--min-alternate-fraction 0
--min-coverage 100
--min-alternate-count 1
--ploidy 1
--dont-left-align-indels
--bam-list list-of-bam-files.txt
--vcf output.vcf
In many output lines I double-checked, the GT value references an alternative allele while the AO value reports no counts for that allele for at least one sample.  I've pulled the genotype information for two examples from my output data. The format for both is: GT:DP:RO:QR:AO:QA:GL.
REF: GCC, ALT: CG,TGG,CGA,CGC
4:20:20:706:0,0,0,0:0,0,0,0:0,-10,-10,-10,-10 (GT is CGC; AO for CGC is 0)
REF T, ALT C
1:4:4:138:0:0:0,-10 (GT is C, AO for C is 0)

@ksprout  The --haplotype 0 --pooled-continuous is referred to as "naive variant calling: simply annotate observation counts" in the manual. I wonder if the GT field is meaningless in that mode?

That's true that the GT field doesn't have a clear meaning in this case. However, as the genotype likelihood (GL) is also reported, it would be logical for the GT field to point to the genotype with the maximum likelihood (or possibly the maximum read depth, depending on how things are actually implemented with these flags).

@tseemann Perhaps the --pooled-continuous flag is at fault here. Interesting. I'll check if I can get a test case.
@ksprout Would you please send me this example. I don't understand how AO is 0 and an alternate allele was considered. That shouldn't be possible.
What version of freebayes are you using? The current versions should produce the GL max in the output considering only the alleles that would be in the maximum a posteriori estimate of the mutual genotyping across all samples. Perhaps the --pooled-continuous use here is something I haven't considered.
Also, I would be extremely careful about --dont-left-align-indels. That's there for debugging and testing of the (default) left realignment.

Hi,
I also found a inconsistency:
0/1:29:0:0:29:1065:-96.2172,-8.72987,0 (GT:DP:RO:QR:AO:QA:GL)
It definitely should be GT=1/1
I was using version:  v0.9.16-1-gf46d24f-dirty and running "freebayes-parallel <(cat regions.txt) 32 -f hg19.fasta  dir1/.bam dir2/.bam" with default settings.
Best,
André

Not quite the same but I posted a similar issue (with example) that came up from a vcf called using bcbio's  joint freebayes pipeline. There is only one AO value for multiallelic sites when the header says number=A.
samtools/bcftools#290
##FORMAT=<ID=AO,Number=A,Type=Integer,Description="Alternate allele observation count">
1       10177   .       AC      ACCC,ACC        1       PASS  ....  2|2:2:3:73:0:0   ./.:0:1:0:0:0  ./.:1:1:6:0:0

Similar issue. Look around that row, you may find other variants with the same AO strings.
Generally sum(number_of_ALT) == number_of_AO, though in some cases even this is not true...

Hi @ekg ,
I have variant data processed by someone else (I got it from NIH). However, I see a lot of inconsistencies and I don't know how these results should be interpreted based on AO and allele calls themselves:
##CHROM	POS	    ID	  REF	 ALT	FORMAT			S1				S2
6       51586771    .       GC      AC	GT:AO:DP:GQ:QA:QR:RO    1/1:41,0:41:99:1312,0:0:0       0/1:18,0:36:0:559,0:644:18
6       109767930   .       GC      TC	GT:AO:DP:GQ:QA:QR:RO	0/1:0,38:96:99:0,1262:2002:58   0/1:0,56:102:99:0,1824:1560:45
1       12837634    .       T       A 	GT:AO:DP:GQ:QA:QR:RO	0/1:24,0:53:99:675,0:945:29     1/1:49,0:49:99:1550,0:0:0
2       171822466   .       CGA     TGA	GT:AO:DP:GQ:QA:QR:RO	1/1:180,16:201:0:5294,57:0:0    1/1:158,11:177:99:4463,42:24:1

From this post https://github.com/ekg/freebayes/issues/459 you say: "AO is the number of alternate observations, with one record per alternate allele". It is clear here that ALL these calls are SNPs and only one alternate allele is available. Nevertheless, AO has two numbers/records. Any guidance on how these cases should be processed? I have way too many other calls that look like this.
Cheers!


Upgrade to v16

version: v15.1.0
The Angular v16 will be released soon, so the lib is going to be upgraded to v16.0.0 which based on Angular 16

Some props of components can add required validation rules


Add filebeat Chart

Thank you for contributing to kubernetes/charts. Before you submit this PR we'd like to
make sure you are aware of our technical requirements and best practices:

https://github.com/kubernetes/charts/blob/master/CONTRIBUTING.md#technical-requirements
https://github.com/kubernetes/helm/tree/master/docs/chart_best_practices

For a quick overview across what we will look at reviewing your PR, please read
our review guidelines:

https://github.com/kubernetes/charts/blob/master/REVIEW_GUIDELINES.md

Following our best practices right from the start will accelerate the review process and
help get your PR merged quicker.
When updates to your PR are requested, please add new commits and do not squash the
history. This will make it easier to identify new changes. The PR will be squashed
anyways when it is merged. Thanks.

Filebeat now supports docker and kubernetes autodiscovery https://www.elastic.co/guide/en/beats/filebeat/current/configuration-autodiscover.html#_kubernetes

Thanks @unguiculus I will get those updated soon.

/ok-to-test

@rendhalver do you think you will have some time to finish this chart up?  If not I can likely take over.

@sstarcher Sorry I missed your comments till now. I have been way too busy.
Thanks for continuing this in your new PR.

@rendhalver does it make sense to close this out if you are good with #4133

That does make sense.
I will close this out.


Add support for CLI plugins

I can imagine other tools would want to:

Add extensions;
Add settings.

Closing this as I don’t see any simple way to add support for these things.
Note that the completer can manipulate what files are processed.


fix(webhook): provide acknowledgment for webhooks with unsupported event types

Type of Change

[x] Bugfix
[ ] New feature
[x] Enhancement
[ ] Refactoring
[ ] Dependency updates
[ ] Documentation
[ ] CI/CD

Description
The change allows acknowledgment of event types which aren't configured and allows the webhooks to pass through instead of sending an error to the connector.

Additional Changes

[ ] This PR modifies the API contract
[ ] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?
compiler guided

Checklist

[x] I formatted the code cargo +nightly fmt --all
[x] I addressed lints thrown by cargo clippy
[x] I reviewed submitted code
[ ] I added unit tests for my changes where possible
[ ] I added a CHANGELOG entry if applicable

Hey @sai-harsha-vardhan, though it seems risky it is the only way we can solve certain issues that we are facing with webhooks that we receive on the hosted environments. But following are some of my insights about the issues that you have raised.

Instead of deserializing the entire response, deserialize only event type enum

I agree that performing a lightweight deserialization is the best bet to avoid other issue in the webhook body to affect me, but its only possible if the webhook integration wasn't done properly and tested thoroughly, and I trust that most of the structs that are defined for response body parsing are accurate to the documentation and tested thoroughly. If otherwise we need to test this flow and other auxiliary flows which depend on webhooks, the problem of not parsing the webhook will be least of our worries in that case.

We can rely on WebhookEventTypeNotFound and EventNotSupported webhook event given by connector, in both these cases we can safely ignore the event and give acknowledgement to the connector

Thanks for the insight, I'll also add EventNotSupported in the error handling logic that is implemented in the PR.

It seems that the use case of EventNotSupported is already handled in the lookup_webhook_event, so this won't be a issue it seems

@NishantJoshi00
Should we add any metrics to recognize genuine deserialization errors in case of ConnectorError::WebhookEventTypeNotFound, or how are we going to identify if all the webhooks start failing due to deserialization, and we continue to send acknowledgments? This makes it seem like we are consuming webhooks and updating status, but in reality, we are just ignoring them!

Sure, that makes sense, I'll add a log line and a metric for this!


Converting struct with time.Time fields generate invalid converter

Describe the bug
When generating a converter between two struct with time.Time fields, the generated converter doesn't compile.
To Reproduce
Here is the code to generate the issue
//go:generate go run github.com/jmattheis/goverter/cmd/goverter github.com/jmattheis/goverter/example/simple
package simple

import "time"

// goverter:converter
type Converter interface {
	Convert(source []Input) []Output
}

type Input struct {
	Name     string
	Birthday time.Time
	Age      int
}

type Output struct {
	Name     string
	Birthday time.Time
	Age      int
}

Expected behavior
Since the source and destination types are both time.Time, I would expect a simple assignment to be done in the converter, but instead, I have a timeLocationToTimeLocation and timeTimeToTimeTime methods generated and trying to play with private fields of the time type.

I was able to bypass the issue by registering a custom converter
// goverter:converter
// goverter:extend TimeToTime
type Converter interface {
  ...
}

func TimeToTime(t time.Time) time.Time {
	return t
}

But could it be possible to give an error instead of generating invalid code? Generated code cannot play with private fields anyway because the converter is not in the same package so is there cases where this kind of generated code would work?

Yeah, an error would be useful. Currently goverter treats the time.Time struct like every other struct. It tries to map exported fields and ignores private fields.

Seems to me like it also tries to map private fields? Here is the generated converter for time.Time
func (c *ConverterImpl) timeTimeToTimeTime(source time.Time) time.Time {
	var timeTime time.Time
	timeTime.wall = source.wall
	timeTime.ext = source.ext
	var pTimeLocation *time.Location
	if source.loc != nil {
		timeLocation := c.timeLocationToTimeLocation(*source.loc)
		pTimeLocation = &timeLocation
	}
	timeTime.loc = pTimeLocation
	return timeTime
}

We can see it tries to access .wall, .ext and .loc which are all private fields. Am I missing something?

goverter will now fail, if there are unexported fields:
https://github.com/jmattheis/goverter/blob/0b2e20a09b20ff4a9a35612b7795c44aaab71cf2/scenario/3_struct_unexported.yml#L20-L55

It works great. Thanks!


Allow Float FPS

Hi,
I want to record 1 frame every 30s... at present I use 1fps and then the other utility to remove X frames after each frame to thin the data (I have other issues with this I will document).
Could you allow 0.1 fps or change the units to frames per minute?
thanks - Crispin

This feature was implemented with a discrete step system (frames per second, frames per minute and frames per hour).


catkin_make OAFD_Monocular

i got problem with the catkin_make and catkin build
the orb_slam3_wrapper is on catkin_build but the OAFD_Monocular package on catkin_make
when i run slam.launch in order to do slam, i got problem it says that my orb_slam3_wrapper is missing. how do i fix this?

i mean how do coorperate with catkin_make and catkin build types because for wrapper i use catkin build but the OAFD_monocular packge i need to use catkin_make. so what i do is i create a new workstation becasue i need to use catkin_make, but catkin build is on another workstation because orb_slam3_wrapper is used catkin build in order to build the package, how do fix this?

For issues with environment variables for multiple ROS workspaces, you can refer to the answer here. If set up correctly, it is possible to successfully include multiple workspaces without conflicts: https://github.com/geturin/OAFD_Monocular/issues/3#issuecomment-1938607606

http://wiki.ros.org/catkin/Tutorials/workspace_overlaying
fixed!, thank you so much sir for assist me. i never know about overlaying workspaces. thank you so much


NIFI-13468 Add standalone RecordPath function recordOf

Summary
Add new standalone function recordOf to Record Path DSL.
See issue NIFI-13468 for details, especially regarding the difference to the existing mapOf.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[x] Apache NiFi Jira issue created

Pull Request Tracking

[x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[x] Pull Request based on current revision of the main branch
[x] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[x] Build completed using mvn clean install -P contrib-check

[x] JDK 21

Licensing

[x] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[x] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[x] Documentation formatting appears as expected in rendered files

I would love to hear your thoughts on this @pvillard31, as you were the one to introduce mapOf some months ago.

@EndzeitBegins It is effectively a non starter to merge new things into the 2.x/main line that are intentionally restrained to also go back into the 1.x line.  We moved on for a lot of good reasons and the entire point is to leverage the language benefits of Java 21 and newer.
As-is given the above this PR should not proceed.
To be clear I'm not commenting on the idea itself - hopefully others can review/engage on that but the PR for this capability should target the 2.x line and benefits that come with that.  I don't recommend backporting at all but that is not a hard rule.

Thank you for the fast feedback @joewitt.
It makes sense to avoid outdated language features targeting the 2.x branch. I'll adjust the PR accordingly.
If that's what we strive for, which seems desirable, we might need to watch out for that more on PR reviews though.
However I'm wondering, what are the reasons why you're against backports for the 1.x line while 2.x isn't stable yet?

use latest language features/better code - thanks.
Watch on PRs. - I assure you there are several of us that are.  But there are a lot of contributors and it is massive codebase.  We miss stuff.
I am not against it.  I simply have been for quite some time not recommending it. As long as people keep adding features and improvements to 1.x more than they focus on getting 2.0 done then it gets harder and harder to get 2.x done.  What you focus on and wish to happen will happen.  What you wait for....may not.  Bottom line I am in the hearts and minds business.  I recommend and encourage folks focus on the go forward solution.  The 1.x line is great but it is already experiencing atrophy.  I strongly believe our best way to help/support/grow the community is to look forward.  This is just my view - you'll be an impressive amount of opinions on such a topic.

Thank you for addressing my questions @joewitt. I always appreciate getting to know the perspective and especially reasoning of others on topics.
I adjusted the PR accordingly. It mostly affected the tests though.
I would appreciate a review (not necessarily by you, of course).

Rebased onto latest commit on main and refactored tests based on changes introduced in NIFI-12852 / #9198 affecting the same file.
I'd appreciate a review.

Thank you for the review and taking on the merge process @pvillard31. 🙂


Accepting removal API and increasing upgrade timeout period

What this PR does / why we need it:
Which issue(s) this PR fixes (optional)
Closes #
Special notes for your reviewer:

Test logs here:
https://jenkins.pwx.dev.purestorage.com/job/Torpedo/view/Torpedo NextPX/job/tp-ocp-upgrade/

New PR is here
https://github.com/portworx/torpedo/pull/1535


Tests: Backend testing improvements

Some tests that need to be merged into main.


un

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

Hello Automation,
Not sure how I managed to open this but it's some kind of keyboard error. Thanks for the submision guide!
Thanks for closing.


Recovery data loss fix

Codecov Report

Merging #160 into master will decrease coverage by 0.17%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
- Coverage   73.16%   72.99%   -0.18%
==========================================
  Files         106      108       +2
  Lines       16647    16864     +217
==========================================
+ Hits        12180    12310     +130
- Misses       3537     3608      +71
- Partials      930      946      +16

Impacted Files
Coverage Δ

utils/metrics.go
65.47% <ø> (ø)
:arrow_up:

memstore/backfill_manager.go
42.57% <0%> (-2.69%)
:arrow_down:

memstore/recovery.go
73.7% <100%> (ø)
:arrow_up:

memstore/redo_log_manager.go
75.72% <100%> (+1.45%)
:arrow_up:

diskstore/local_diskstore.go
59.5% <100%> (+0.16%)
:arrow_up:

memstore/archiving.go
87.82% <100%> (+0.16%)
:arrow_up:

memstore/ingestion.go
81.04% <60%> (-0.51%)
:arrow_down:

subscriber/common/message/message_decoder.go
76% <0%> (-14.48%)
:arrow_down:

subscriber/common/message/message_parser.go
53.93% <0%> (-13.29%)
:arrow_down:

subscriber/common/rules/job_config.go
70.86% <0%> (-2.48%)
:arrow_down:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05ff3aa...e417ebd. Read the comment docs.


[DDW-419] Optimized wallet data polling

This PR optimizes wallet data polling so that only active wallet's transactions and addresses are polled.
This PR also increases the maximum number of wallets limit from 30 to 100.

Testing Checklist

Slack QA thread
[ ] Test adding and using 100 wallets

Review Checklist
Basics

[ ] PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
[ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
[ ] PR has a good description that summarizes all changes
[ ] PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:

[ ] In English
[ ] In Japanese

[ ] CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
[ ] Automated tests: All acceptance and unit tests are passing (yarn test)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
[ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
[ ] There are no flow errors or warnings (yarn flow:test)
[ ] There are no lint errors or warnings (yarn lint)
[ ] There are no prettier errors or warnings (yarn prettier:check)
[ ] There are no missing translations (running yarn manage:translations produces no changes)
[ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
[ ] Japanese text changes are proofread and approved (Junko Oda)
[ ] UI changes look good in all themes (Alexander Rukin)
[ ] Storybook works and no stories are broken (yarn storybook)
[ ] In case of dependency changes yarn.lock file is updated

Code Quality

[ ] Important parts of the code are properly commented and documented
[ ] Code is properly typed with flow
[ ] React components are split-up enough to avoid unnecessary re-renderings
[ ] Any code that only works in main process is neatly separated from components

Testing

[ ] New feature/change is covered by acceptance tests
[ ] New feature/change is manually tested and approved by QA team
[ ] All existing acceptance tests are still up-to-date
[ ] New feature/change is covered by Daedalus Testing scenario
[ ] All existing Daedalus Testing scenarios are still up-to-date

After Review

[ ] Merge the PR
[ ] Delete the source branch
[ ] Move the ticket to done column on the YouTrack board
[ ] Update Slack QA thread by marking it with a green checkmark

@alan-mcnicholas @darko-mijic any news on this one? Is this worth merging?

@alan-mcnicholas @darko-mijic any news on this one? Is this worth merging?

I have only checked it on a Windows VM with 100 wallets, performance as you would expect was not fantastic but I did not see any loss of connection in the UI. I did not perform a full test however, just the syncing. I am not sure if it adds much value at present; it you want to include it in a flight release let me know and I can try and prioritise testing this on all three platforms. :)

We still haven't decided about releasing this. However, we need to check if there are any negative side-effects of this optimized polling. It would mean a lot if you could help us test this. You don't need to test with 100 wallets. We are interested in seeing how changing active wallet (basically navigating through the sidebar) works. When switching wallets pay attention to:

"Receive" screen (check how long it takes for the addresses to be shown after you switch wallets)
"Summary" / "Transactions" screen (check how long it takes for the transactions to be shown after you switch wallets)
I would suggest testing with 10 to 20 wallets and having some tx history in these wallets.

I would expect you to see at least a half a second delay (in average) before addresses/transactions are shown once you switch wallets - especially when you are viewing that wallet for the first time during one session.
cc @darko-mijic @mioriohk

Here's a summary of my findings on build 14744 (Tested on Linux with 100 wallets):

The syncing of 100 wallets is ~ 60% after 7 hours.
When switching between wallets, sometimes there is a little delay to show the addresses in "receive". It does not happen all the time, and if the addresses were loaded before, no delay is observed. Here is a recording. Also tested this on Mac with 15 wallets and go no delay loading addresses and transactions.
I think this is probably known, but more than 100 wallets can be added if performed by API. Here is a screenshot.

Here's a summary of my findings on build 14744 (Tested on Linux with 100 wallets):

The syncing of 100 wallets is ~ 60% after 7 hours.

This is expected and not something we can improve on our side.

When switching between wallets, sometimes there is a little delay to show the addresses in "receive". It does not happen all the time, and if the addresses were loaded before, no delay is observed. Here is a recording. Also tested this on Mac with 15 wallets and got no delay loading addresses and transactions.

This should be improved by at least adding a loading spinner on the "Receive" screen. That will already be much better UX and is virtually no effort.
cc @darko-mijic

I think this is probably known, but more than 100 wallets can be added if performed by API. Here is a screenshot.

We are only imposing 100 wallets limit in the UI. You can still add as many wallets as you want using Daedalus API calls or using direct cardano-wallet API requests.

My findings on build 14744 on Windows.
Didn't see any delay when going to "Receive" or "Summary"/"Transaction" screens.
My findings on build 14744 on Mac.
100 wallets been syncing for more than 12 hours now. Currently averaging around 95%. Performance of Mac is affected. Still waiting for the wallets to fully sync up

On a low spec Windows 10 VM (dual core, 4GB RAM) I am not noticing any highly visible lag when switching between wallets or loading addresses\transactions. This is on a Daedalus instance with 30 fully synced wallets (some with TX history) and an instance with 100 wallets (not fully synced).


Loggers should be declared non-static

Loggers are declared as private static final. This can have impact when having the library deployed on "shared" classpaths.
It is prefereable to have them non-static.
If we care about serialization (which I don't assume) Loggers could be changed to be also transient.
For reference see:

http://slf4j.org/faq.html#declared_static
https://cwiki.apache.org/confluence/display/COMMONS/Logging+StaticLog

OpenHAB follows such a policy:

https://www.openhab.org/docs/developer/guidelines.html#f-logging

ok if HAL follows that I am ok with it but in 20 years I have never run into an issue with a static final logger.   IntelliJ kept recommending this change on all classes as its their best practice for loggers to be static.  Same with SonarCube. cc @janossch since he and I both just made this change.

It can be an issue when using dynmaic class loading such as it is done within an OSGi framework (and only if one updates JARs at runtime).
BTW I already prepared a PR, but waiting for #325 to be merged.

Thanks @ViToni !

@melloware I touched several Logger fields with my commits, but I've not changed any of them to static (yet). On the other hand if I would seen one I would have changed it to static without even thinking ... so your intuition is quite good 😄
@ViToni as far as i understand this is an edge case where shared ClassLoader is used.. right? What could go wrong? You see mixed log lines from the server application and you can't correlate which application logged which entry, or what? Please don't get me wrong I'm just curious.

@janossch Things can get complicated. In the most simple scenario one just looses memory since static references are bound to classes and not objects. In the worst case one can get ClasCastExceptions.
If one has a simple application which is started and shutdown, it's not an issue. If one has a dynmic environment such as application server or OSGi and also uses live updates this can very easily lead to issues.
It boils down to how class loading and garbage collection work in Java.
So these would be the topics if you are interested to go deeper.

@ViToni why Logger is the only static reference which could cause such a mess? Based on what you decribed so far I would not use static at all.
Are there any blogs or other sources where I can read about this more deeper?

@janossch Because Logger is a dependency for this project (which could be updated as runtime) and Loggers are common to be used as static fields ( which might be totally depending on your application)
IMO the JLS is a good start: https://docs.oracle.com/javase/specs/jls/se8/html/jls-4.html#jls-4.3.4

PR submitted

@ViToni see my PR its failing all over because loggers are used in static context and must be static?  And they were previously static all we did was mark them final?


DS-2542 for DSpace 5.x

This PR fixed DS-2542 for DSpace 5.x with fixed xoai.jar

I believe this date parsing bug was resolved in DSpace 5.2 by #918
Currently, DS-2542 appears "fixed" to me on the 5.x branch (now that we updated XOAI to 3.2.10 in #1142 ).  However, I'd appreciate if someone else could verify this to ensure I'm not overlooking another OAI date-related issue.  https://jira.duraspace.org/browse/DS-2542

Update: Part of this PR was included in #948.  However, the fix to DateUntilFilter is not yet in the codebase.  I've created a new PR based on this one: #1146
Closing this old PR as it's unmergeable (as part of this fix is already in our codebase).


tidy banner text

:vomiting_face:

and now it's boring and looks off balance. let's not churn on things like this at this time?

:tada:

Still don't want to change this


@alloy=> Some more minor QA

Closes https://github.com/artsy/force/issues/759
Closes https://github.com/artsy/force/issues/754
Closes https://github.com/artsy/force/issues/750
Here's the mailcheck hint:

Sweet 👍
Only thing I don’t understand, looking at that screenshot, is the suggestion also doesn’t have a TLD. What gives?

That's just https://github.com/mailcheck/mailcheck , I am not super familiar with it but it matches what we use on the existing Sign-up/Log-in stuff.
I can investigate it further but I am not sure. This does make the embedded signup consistent with the modal however.

Actually, let me rephrase my last comment!
What I meant: I agree that the current Mailcheck seems a bit less than ideal (for instance it fixes 'gnail.com', but still lets some invalid ones through). If we want to improve/revamp the behavior of it, I believe that's beyond the scope of this relatively simple QA PR, and can be issued and dealt with separately.
Sorry for the misunderstanding!

If we want to improve/revamp the behavior of it, I believe that's beyond the scope of this relatively simple QA PR.

Agreed 👍
Filed a new ticket https://github.com/artsy/force/issues/771


Cookie refreshes/expires everytime cookie Login

So first, I would login into my "bot" account for the cookieLogin. I use https://glitch.com as a hosting site. Then I would get my ROBLOSECURITY cookie, and put it in my code. Doesn't work. No errors. Bad cookie. Then, I would try another solution where I would go into Incognito mode, copy the cookie, and leave the window. Doesn't work. Bad cookie. Lastly, I would stay logged in my account while I put in the code, then it LOGS out of my account, and new cookie is refreshed.
Noblox.js is impossible to use when I even can't log in the account with cookieLogin.

Oh and I went into the API Discord Server but all of them agreed to me, that cookieLogin won't really work.


manually replace i18n placeholders in login form

I just added a manual replacement of the i18n placeholders.

Thanks!


WFLY-17875 Channels added by ancient Infinispan schema can fail if no stack was defined

https://issues.redhat.com/browse/WFLY-17875
Verified by @emmartins

Thanks @pferraro and @emmartins


Introducing system_file_list to copy files to the system

This p/r is to introduce system_file_list which helps to copy files from wso2-module/files/system/ to preferred system path using following format:
wso2::system_file_list:
file: <file-to-be-copied>
target_path: /usr/local/bin

Ex:
wso2::system_file_list:
file: wso2mb-default-init.sh
target_path: /usr/local/bin

Merged. Thanks!


Report access event error for hdfs -cp command

hdfs dfs -cp /src/1 /src/5
18/06/07 15:27:33 ERROR client.SmartDFSClient: Cannot report file access event to SmartServer: /src/1 , for: Failed on local exception: com.google.protobuf.InvalidProtocolBufferException: Protocol message end-group tag did not match expected tag.; Host Details : local host is: "ubuntu/<IP_ADDRESS>"; destination host is: "ubuntu":7045;  , report mechanism will be disabled now in this instance.

Thanks @littlezhou . Problem solved after changing port to 7042.
Issue closed.


Branch Compare Java API

This PR adds the following changes to support proper branch compare mechanism:

SHA-1 _hash has been added to all documents. It's a unique key to the actual semantic content of a document. It will be used by revision compare to filter out false positive changed revisions. The time required to compute the value for this field is ~1ms depending on the size of the document.
^ character has been added to RevisionIndex.read(String, RevisionIndexRead) method to support reading revisions and content from the base of a branch (basically this is the state before the branch fork point). For example to read the original version of a SNOMED CT concept from a branch, you can execute
GET /snowowl/snomed-ct/v2/MAIN/MyAwesomeBranch^/concepts/123456789.
RepositoryRequests.branching().prepareCompare() has been added as the new primary branch compare API (replacing the old review API, which is still available, but will be deprecated in favor of the new one). The difference between the two APIs, that the new compare API returns the identifiers of the new/changed/deleted components, and it does not try limit them to some sort of container ID. This will work properly in case of non-SNOMED CT terminologies as well. Also it fetches only the identifiers (using the latest partial doc. loading improvements), so it's faster than fetching all fields.

Thanks @apeteri for the review! Merging to develop.


FetchMultipleAsync

Any plans for that? I think that would be great as that's the most IO intensive with multiple results and thus longer running queries
Thanks!!

We take pull requests

I'm also interested in this + I'm willing to work on a PR for this. @schotime I've dug through the code from what I see, IDatabase.FetchMultiple(Type[] types, object cb, Sql sql) seems to be the method called eventually, if I make an async version of that I could implement the rest of the FetchMultiple methods on top of it, is that about right?

Please check out this changes if you are ok with them I can add more tests and submit the PR


Dmceachernmsft/CSSTitleChanges

What
Added CSS to allow for changes to the title area.
Why
Fixes gap between title page headers to be correct.

https://skype.visualstudio.com/SPOOL/_workitems/edit/2665421
How Tested
Visual inspection

Just noticed that there is no gap after the bottom button on feedback page.
I realize it's unrelated to your PR, mind adding a fix for this too?


Poor quality during crop

When I take a picture, the image have a good quality, but when I try to use it in Crop, it becomes completely blurry.
Here are two screenshots of the image in the camera and during the Crop:

This is on emulator (Pixel 4 API 30) but I have the same issue on my physical device (OnePlus 9 Pro).
You can find my code here

on the demo example/lib/main.dart:
  Future<void> _openImage() async {
    final pickedFile =
        await ImagePicker().pickImage(source: ImageSource.gallery);
    final file = File(pickedFile?.path);
    final sample = await ImageCrop.sampleImage(
      file: file,
      preferredSize: context.size?.longestSide.ceil(),
    );

    _sample?.delete();
    _file?.delete();

    setState(() {
      _sample = sample;
      _file = file;
    });
  }

replace to
  Future<void> _openImage() async {
    final pickedFile =
        await ImagePicker().pickImage(source: ImageSource.gallery);
    final file = File(pickedFile?.path);
    // final sample = await ImageCrop.sampleImage(
    //   file: file,
    //   preferredSize: context.size?.longestSide.ceil(),
    // );
    //
    // _sample?.delete();
    _file?.delete();

    setState(() {
      _sample = file; // direct use origin file
      _file = file;
    });
  }

I had the same issue on android, the cropped image were twice smaller than the preferredSize value.
this PR fixed it #75

Check this https://www.youtube.com/watch?v=1aRwxnX5nms


chore: docs update

What was added?

Added to Contributing guide
Added getting-started
Added issue and pull request templates
Started a style guide doc

/lgtm


 element doesn't inherit the text-align property in IE8/IE9

If  text-align is set on a parent element of  <th> (such as  <table>) , then  <th>  does not inherit this property in IE8/IE9.

An elegant description of the problem
HTML WG discussion
My simple text-align demo: Compare this page in Gecko or Webkit and IE8/IE9.

I would recommend something like: th {text-align:inherit\0/;}
The attribute hack is for IE8/IE9 only. Borrowed from http://paulirish.com/2009/browser-specific-css-hacks/

Doesn't look like browser bug can be normalized cleanly. I don't want to include that property-value hack, and using text-align: inherit doesn't have the same effect in all browsers. Thanks for letting me know about this bug. I'm going to close it for now.


Sessions Error

For some reason, selecting the logout button trys to make a GET request to /users/sign_out which is not a valid link. I believe this is error is occurring due to style changes for the devise views, or another unknown issue with milia.

Should be fixed with 5281b95d0d79967d12710779a90b6f6f56a8d394


Integration Test - Release - 2019/08/01 14:27:29

Auto create for integration test. AnotherAuthorUpdatedArticleFlow

@lamebrain : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Re-implement BinaryTransactionMessage#toString:

Include serviceId, transactionId, payload (as byte array),
and author. The signature is omitted, as the other fields of
messages (class, tags).
The output now looks like that (consistent with RawTransaction):
BinaryTransactionMessage{
  author=93afa1b0406faff182608b04e63e10cf0237b33215de16de68c151c7ab32958c,
  serviceId=127,
  transactionId=1,
  payload=[8, 1, 18, 32, -83, -87, 62, 57, -72, -99, 126, -106, -45, 62, -44, -17, 14, -26, 10, -127, -49, -124, 84, -107, 90, 125, -94, 34, 106, -8, 33, 0, -92, -84, 110, -84]
}

Also, check the class and tag of tx messages.
Overview

See: #893
Definition of Done

[ ] There are no TODOs left in the code
[ ] Change is covered by automated tests
[ ] The coding guidelines are followed
[ ] Public API has Javadoc
[ ] Method preconditions are checked and documented in the Javadoc of the method
[ ] Changelog is updated if needed (in case of notable or breaking changes)
[ ] The continuous integration build passes

Coverage increased (+0.07%) to 86.374% when pulling 3b434218edc94885a77a6708e11b3fb6cdac9da0 on dmitry-timofeev:to-string-for-message into 8e80ff0eff31f2c4cff587272a4dab042715c908 on exonum:master.


Harvesting screen. Add the required balance message

@OlegMakarenko
Message is now "To harvest, the account needs a vested balance of at least 10000 XYM"
I guess this is invalid because there is no vesting in Symbol.
Maybe we should change to same message as on desktop wallet or just remove "vested"?
"The account needs to hold at least 10000 XYMs to start delegated harvesting."

@Peersyst could we update this message?

@Peersyst could we update this message?


show variable type on hover

This feature request asks for adding the UI for this debug protocol extension: https://github.com/Microsoft/vscode-debugadapter-node/issues/32
If the optional 'type' attribute is available for a variable, the type should be shown when hovering over the name part of a variable.

Hi everyone. I was wondering if there would be a way to have this functionnality (i.e Having the type definition on mouse over ) but not in debug. For example, I am writting a function which has parameters with some types. But when I want to see the type definition (which comes from other files) of a variable (like parameters), I can't see it.. I just see the type name, not its definition.
Thank you for your answer...

@TitaneBoy VS Code already supports what you are asking for. In the following screenshot I am hovering over the logger.setup method and the hover shows the method parameters:

But this informations is only available if you are using a language extension that supports this (in my example it is coming from VS Code's built-in TypeScript extension).

Well...I know that we can have the function definition...I think I didn't ask the right question..
Suppose I have this instruction:
interface ITypeInterface {
   firstVariable: string;
   secondVariable: number;
   thirdVariable: {id: number; description: string};
}

let myVariable: ITypeInterface = undefined;

If I want to see the definition of "ITypeInterface " with the mouse over on the "ITypeInterface" name, how can I do ? If the ITypeInterface is defined somewhere else in another file, I had to "Crl + Click" on the type name to get its definition. But by doing that, I will switch my file view and my context at the same time. Is there a way to see the type definition (and not only the name) by mousing over the type name ?
Thank you

Just to be sure: I'm using typescript language in my context and let's assume that import of the First_file.ts is done correctly in the "Second_File.ts"

Showing the full type definition on hover doesn't make a lot of sense because the hover size is fairly limited. You would only be able to see the first couple of lines in the hover.
But try to use the "Peek Definition" action (alt-F12): it shows the full type definition without swithcing files:

@weinand : Perfect...This is what I was looking for...Thank you again for your fast answer and your great support...:-)


Change API endpoint from /api/beta to /api/v1

For now, simply make v1 a duplicate of beta and deprecate the beta path.  We should plan on maintaining beta for a few years before removing it.

This should be fixed by pull request https://github.com/PecanProject/bety/pull/527.

@gsrohde can this be closed?

@gsrohde please deploy and close


Fix some typos in custom_post_processing.rs

Objective

Fix some typos in the custom_post_processing.rs example

Spurious CI failure; retrying. Thanks for the fixes :)


SAF-788 Android

Filter out (0,0) locations on Android from being saved to Realm.
Once this is merged, I'll cherry-pick it to gps-release-1.2.0

Closing this. The same PR has been made against gps-release-1.2.0 branch
https://github.com/Path-Check/covid-safe-paths/pull/1242


newlist() not implemented

http://www.byond.com/docs/ref/#/proc/newlist

Added in 2527e14f7b5cc4f21f07e828547afe2b9e1c9320.


Use module-level fixtures for sql tests

Summary
Switch to using module-level fixtures for sql tests. There were a few tests in here that made significant modifications to nodes, which I left on the non-module-level fixtures, as resetting them was not easy.
Test Plan

[ ] PR has an associated issue
[ ] make check passes
[ ] make test shows 100% unit test coverage

Deployment Plan

Thanks for working on this... I know how hard it is to reset the nodes sometimes so don't try too hard. From time to time I cut some corners in order to just move the PR ahead.
Looks like you still getting some errors:
FAILED tests/api/sql_test.py::test_sql_with_filters_orderby_no_access - RuntimeError: Caught handled exception, but response already started.
FAILED tests/api/sql_test.py::test_union_all - KeyError: 'sql'
FAILED tests/api/sql_test.py::test_multiple_joins_to_same_node - KeyError: 'sql'
FAILED tests/api/sql_test.py::test_cross_join_unnest - KeyError: 'sql'
FAILED tests/api/sql_test.py::test_lateral_view_explode - KeyError: 'sql'
FAILED tests/api/sql_test.py::test_get_sql_for_metrics_failures - assert <HTTPStatus.FORBIDDEN: 403> == 200

@agorajek I think I figured out a fix for those tests -- it was just that the override function for validate_access wasn't being unset, which meant that after test_sql_with_filters_orderby_no_access runs, the rest of the tests would fail due to being denied access to nodes.
However... I think I'm seeing a bigger issue which is that this change isn't having a huge effect on how long these tests take to run.

@shangyian yes the validate_access is a common issue I had to deal with either through a reset or through putting these tests to a separate file.

@agorajek this is finally ready 😄


[Feature] support multiple drivers application gateway rule management

Is your feature request related to a problem? Please describe.
In the Kubernetes ecosystem, there are two most widely used application north-south traffic (gateway) management APIs, namely Ingress and Gateway API.
The Ingress mainly covers the HTTP protocol, and the Kubernetes SIG currently drives the latter in order to implement a standard API for more protocol traffic management.
KubeVela is an application delivery platform. Its advantage is that it can integrate APIs of similar requirements downward and is compatible with different implementations; it provides users with a unified management process and experience upwards.
Describe the solution you'd like
In this topic, a set of gateway management functions compatible with multiple load balancers can be developed based on Ingress and Gateway API, so that users do not need to change the traffic management policy configuration when deploying applications in different environments with different gateway implementations.

Based on the Ingress API needs to support the Nginx, Istio, Traefik, Aliyun CLB etc.
Based on the Gateway API needs to support the Istio, Traefik, Kong etc.

Additional context
The Traefik addon is an example.
Refer to https://github.com/kubernetes-sigs/gateway-api/pull/1131

@barnettZQG, I am really interested in this project, If you permit I would like to draft a proposal for the issue to participate in ASoC 2022.

@barnettZQG, Sir I am really interested in this issue and if you permit, I would like to draft a proposal for the issue to participate in ASoC 2022. I have sent you a message on CNCF Slack as well to introduce myself properly. Also, as the last date of proposal submission is approaching, I would be grateful if you can answer at the earliest.


NvimTreeFindFile equivalent for file-browser

Hello,
Is there a similar feature to |:NvimTreeFindFile|?
I was looking for some way to open the file browser using the current buf name as the path, or something similar. Tried checking the docs and issues but no luck. Thanks!

Using :Telescope file_browser path=%:p:h will open the file browser in the path of the current buffer. Does that match what you're looking for?

Somewhat, yes, but the file path of the current buffer is not highlighted. Thanks tho, this will do for now. Closing issue.

Is it select_buffer = true you are after?

Good call, :Telescope file_browser path=%:p:h select_buffer=true should do.


Polymer passing object='0' and target='null' to event handler on-keyup

I ported stagehand's polymer web sample to 0.17-0-dev-interop-reverse. The event handler for reverseText is called, but object = 0 and target = null.  Here's the [gist] (https://gist.github.com/ErikGrimes/c18ebe9b4236f4dd6cb4).

Actually, this is working as intended it looks like. The issue is the 3rd argument (target) is not supported at all. However the way we invoke this function today using smoke we use the adjust: true option. This adds nulls for any extra arguments. The detail of 0 seems to be consistent with any key listeners on input fields. If you want the character code you need to read event.charCode.
We are currently working on migrating to the reflectable package, and will no longer be adjusting arguments like this (which is error prone anyways). You would get a runtime warning that a method with 3 expected arguments was called with only 2.


Roms not found for custom integrations.

I have followed the documents posted here to add a custom rom integration.
I'm using the USA rom from the recommended no intro collection.
Traceback (most recent call last):
  File "trainModel.py", line 42, in <module>
    main()
  File "trainModel.py", line 31, in main
    env = retro.make(game='Contra-Nes', use_restricted_actions=retro.Actions.DISCRETE)
  File "/Users/daniel/.pyenv/versions/3.6.5/lib/python3.6/site-packages/retro/__init__.py", line 49, in make
    retro.data.get_romfile_path(game, inttype)
  File "/Users/daniel/.pyenv/versions/3.6.5/lib/python3.6/site-packages/retro/data/__init__.py", line 288, in get_romfile_path
    raise FileNotFoundError("No romfiles found for game: %s" % game)
FileNotFoundError: No romfiles found for game: Contra-Nes

Archive manifest:
customIntegration.py
data.json
level1.state
metadata.json
rom.sha (used shamus on macOS to get this.  I have a sneaking suspicion this is the issue.)
scenario.json
trainModel.py
Archive.zip
System information

MacOS 10.15.7 / Ubuntu 20.04
3.6.5 / 3.7
0.8.0

Can you call it something besides Contra-Nes and try again? It may be conflicting with this existing experimental integration: https://github.com/openai/retro/tree/master/retro/data/experimental/Contra-Nes

Closing due to lack of activity.


Action 'Copy Tag' added to menu but not registered

Similar to https://github.com/Vector35/binaryninja-api/issues/2267


unparallelize, remove controller testing gem

I rule and have completed some work on Case Manager that's ready for review!
Remove parallelization until we get that sorted out in #992 , remove rails-controller-testing gem
It relates to the following issue #s:

Fixes #991

Codecov Report

Merging #993 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #993   +/-   ##
=======================================
  Coverage   97.66%   97.66%
=======================================
  Files          40       40
  Lines         858      858
=======================================
  Hits          838      838
  Misses         20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3301f4...eb82c70. Read the comment docs.


Ampersand insertion interacts badly with math mode

If you type "$\&$", stackedit inserts new "amp;" characters with every keystroke.

This is a blocker for me.
If you have multiple occurences of "&" in the document, stackedit replaces all of those with & and does it repeatedly over and over, so that you end up with "&amp;amp;"

This prevents the use of many table-like environments in math mode, like array, eqnarray, tabular, booktabs, etc.  The workaround from @eekboom doesn't work for this purpose.


[gitignore] Update gitignore

Update gitignore to ignore the following files:

data files for applications
log files

Signed-off-by: Parichay Kapoor<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #1579. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/.


SSH hardening

In issue was mentioned that the SSH daemon for the debugging is using obsolete settings.

Disable weak MAC algorithms
Disable weak ciphers and modes

I would like to suggest that the SSH Add-on is set to more strict settings in regard of algorithms, ciphers and allowed modes.

I have those in the Community Version of the add-on, nevertheless, I do offer an option to fall back to older / the default set of ciphers and algorithms. The main reasoning for this is, is that most clients on mobile devices do not support the actual secure/newer algorithms.
Nevertheless, I've disabled the weak ones by default.


[SPARK-25058][SQL] Use Block.isEmpty/nonEmpty to check whether the code is empty or not.

What changes were proposed in this pull request?
We should use Block.isEmpty/nonEmpty instead of comparing with empty string to check whether the code is empty or not.
[error] [warn] /.../sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala:278: org.apache.spark.sql.catalyst.expressions.codegen.Block and String are unrelated: they will most likely always compare unequal
[error] [warn]       if (ev.code != "" && required.contains(attributes(i))) {
[error] [warn]
[error] [warn] /.../sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala:323: org.apache.spark.sql.catalyst.expressions.codegen.Block and String are unrelated: they will most likely never compare equal
[error] [warn]          |  ${buildVars.filter(_.code == "").map(v => s"${v.isNull} = true;").mkString("\n")}
[error] [warn]

How was this patch tested?
Existing tests.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1954/
Test PASSed.

Merged build finished. Test PASSed.

Test build #94437 has started for PR 22041 at commit fa7e1b1.

cc @viirya @cloud-fan @gatorsmile

LGTM

LGTM

Test build #94437 has finished for PR 22041 at commit fa7e1b1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94437/
Test PASSed.

Thanks! merging to master.


Implement functionality to change the battery level for the low-battery message

User story

As a user
I want to be able to edit the battery level for the low-battery level in the vehicle properties context
So that I can test the popup of a low-battery message for different car manufacturers with different low battery level requirements.

With this user story, the implementation of the functionality to change the battery level for the low-battery message is to be implemented. The button has been designed with user story #141 .
Acceptance criteria

In the vehicle properties context area, it is possible to change the battery level for the low-battery level message.

Code is peer-reviewed
Feature is merged into development branch
Documentation is updated
Bill of Materials is updated

DoD general criteria

Feature has been fully implemented
Feature has been merged into the mainline
All acceptance criteria were met
Product owner approved features
All tests are passing
Developers agreed to release

Has already been implemented in with #141


unable to send multipart request

hi,
please help me out to fix this issue.
this is my multipart request
*************(exclude)
--myboundary
Content-Type: application/vnd.aconex.mail.v2+xml

Administration
false
asdf
Test Create Mail 0015
1879048522
0
1879048288

--myboundary--
**********(exclude)
complete request is
*************(exclude)
Scenario: create mail
* path  projectID, 'mail'
* header Content-Type = 'multipart/mixed'
* header boundary = 'myboundary'
* request =
"""
--myboundary
Content-Type: application/vnd.aconex.mail.v2+xml

Administration
false
asdf
Test Create Mail 0015
1879048522
0
1879048288

--myboundary--
"""
}
* request = requestData
* method POST
*************(exclude)
throwing run time error Exception in thread "main" cucumber.runtime.CucumberException: Error parsing feature file /Users/skumar/Documents/automation/api/src/test/java/mail/mails.feature
at cucumber.runtime.FeatureBuilder.parse(FeatureBuilder.java:133)
at cucumber.runtime.model.CucumberFeature.loadFromFeaturePath(CucumberFeature.java:104)
at cucumber.runtime.model.CucumberFeature.load(CucumberFeature.java:54)
at cucumber.runtime.model.CucumberFeature.load(CucumberFeature.java:34)
at cucumber.runtime.RuntimeOptions.cucumberFeatures(RuntimeOptions.java:239)
at cucumber.runtime.Runtime.run(Runtime.java:111)
at cucumber.api.cli.Main.run(Main.java:36)
at cucumber.api.cli.Main.main(Main.java:18)
Caused by: gherkin.lexer.LexingError: Lexing error on line 62: '}
* request = requestData
* method POST
* print status
* print response
%FEATURE_END%'. See http://wiki.github.com/cucumber/gherkin/lexingerror for more information.
at gherkin.lexer.En.scan(En.java:872)
at gherkin.lexer.I18nLexer.scan(I18nLexer.java:36)
at gherkin.parser.Parser.parse(Parser.java:62)
at cucumber.runtime.FeatureBuilder.parse(FeatureBuilder.java:131)
... 7 more

you don't need to form the request body by hand, please refer the docs: https://github.com/intuit/karate#multipart-entity
also see this example: https://github.com/intuit/karate/blob/master/karate-demo/src/test/java/demo/upload/upload.feature#L48
your mistake is * request does not have a = sign in the syntax.
if you still face issues, try stack overflow or follow the process here: https://github.com/intuit/karate/wiki/How-to-Submit-an-Issue


Missing Challenges

Challenge Name

Issue Description
Open Map and go to the Basic Algorithm Scripting.
Api and Microservices Project first challenge is also missing
Browser Information

Browser Name, Version:  55.0.2883.87 m
Operating System: Windows 10
Mobile, Desktop, or Tablet: Desktop

Screenshot

@RoniqueRicketts Thanks for reporting!
Looking at the source for the links, there's no content in the second expanded p.challenge-title > a > span and empty links without content are not rendered.

I guess this problem is caused by some faulty data used to generate this link. I'll continue the search in the seed for this challenge and see if something is out of place.

[CLOSED]
Duplicate issues:
#12919
#12842

Thanks everyone. We've now fixed this on staging.


[MadNLPMOI] Set nln_nnzj explicitly

This PR fixes the error coming from the assertion introduced in  https://github.com/JuliaSmoothOptimizers/NLPModels.jl/pull/468

Closing as this issue has been resolved in the new NLPModels.jl release.


Vcheck on predicted viral bins

I got a single Concatenated predicted viral bin from RF model  in resultsdir/vamb_bins. Do I input this single file in checkV? How would checkV know which contigs belong to the same bin (or does that now matter at this stage?)
Thank you
Barbara

Hi Barbara
The output produced by the workflow concatenates the contigs of a bin into one sequence that can be evaluated with CheckV directly - so yes you input that single file with checkV to evaluate the quality of the predicted viral bin :-)
Best,
Joachim

Hello Guowei
Like with bacterial MAGs, the sequential order of the contigs in a viral bin/viral MAG is not known. Unless you find a reference genome to guide how to put the genome/contigs puzzle together, even though mosaicism in viruses may hinder this effort. The contigs are, by choice, not connected by gaps like "XXX" or some other accepted DNA character in fasta-files as it might mess up the viral evaluation machinery of CheckV.
Best,
Joachim

No activity on this one, closing it.


Configure caching

Get the back-end DRF caching working

This is required for #22, so I will look into this as well.

Can you clarify the scope of this issue? I'm not clear on what is meant by caching.

@sloria, this was a thing you requested and @samanehsan implemented, so I'll let you to chat about it.

I originally requested looking into API rate limiting.

In order for API rate limiting to work, we need to configure the cache settings: http://www.django-rest-framework.org/api-guide/throttling/#setting-up-the-cache. The default local memory caching backend is not recommended for production, so I used memcached instead.

Rolling this into the rate limiting issue.


Issue reporter window stays black

Version: 1.54.0-insider
Commit: afd102cbd2e17305a510701d7fd963ec2528e4ea
Date: 2021-02-08T05:13:33.147Z
Electron: 11.2.2
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 5.8.0-41-generic

Open Help: Report Issue
Issue report stays empty

Looks like have an extension that has no publisher. Not clear yet how I got this.

Duplicate of https://github.com/microsoft/vscode/issues/118480


Keep extra details about age-1 survey sensitivity in appendix

I'm thinking that we should keep the age-1 index appendix (just like was done last year) given that there is continued interest in that run and is often referred to when thinking about management advice and/or supplementary information about potential recent recruitments.  Others agree?

Yes I agree. It's also easier technically to keep it as-is

Yes I agree. It's also easier technically to keep it as-is

Yes, the SRG didn't explicitly ask for it, but wanted the NUTS results if only base model and this one could be run with NUTS, so on balance it sounds like they would want the appendix like last year. The first few figures may need a bit of updating/work, the rest should be fairly automatic.

Yes, the SRG didn't explicitly ask for it, but wanted the NUTS results if only base model and this one could be run with NUTS, so on balance it sounds like they would want the appendix like last year. The first few figures may need a bit of updating/work, the rest should be fairly automatic.

this is done, of course text edits or whatever welcome when reading through but I think this can be closed now...


Navigation sound: delay and repeated itself after starting game

1/ When switch to next game icon, the "game selected" sound is more delay than in P8 using sound extension, I tried P9 sound extension but the sound delay is the same so i think this is maybe P9 sound issue?
2/ In both P8 and P9, when using "Game selected" sound, start a game, the "game selected" sound is incorrectly played as "Game starting" sound while there is no "game starting" sound set in Sound extension

I changed Audio format to “Direct sound” and it fixed the Audio delay issue. Meanwhile “Waveout” and “WASAPI” both have delay sound issue


pbxplore.assign is overwritten

Following #80, the function pbxplore.assign overwrite the module pbxplore.assign in pbxplore.__init__.py. A solution would be to rename the module assignment.
cc @HubLot

Indeed, I did not realize this bug when doing the modularization.
I will submit a PR

Fix in #84


Notification support

Should be nice if we can get a notification.
If you are open for a pull request, i can try to implement in the near future.

My browser (Edge) is set to ask for notification permission, but I wasn't prompted to allow it when selecting the bell icon. However when I used site settings to allow the notification permission, I started receiving notifications. I was already using HTTPS for Mailpit.

@Fydon It seems Edge was having a race issue between running that request (for notifications) and closing the modal. I have pushed a fix for this which will be included in the next release (in the next few days). Thanks for reporting.

@Fydon The fix has been included in v1.12.2.


v3/master: build issue - autoconf

the autoconf build instructions seem to be having a bug or the version is incompatible with current autotools version.
autoconf version:
autoconf (GNU Autoconf) 2.69
configure
./configure: line 2127: syntax error near unexpected token `-Wall'
./configure: line 2127: `AM_INIT_AUTOMAKE(-Wall -Werror foreign subdir-objects)'

autoconf
configure.ac:42: error: possibly undefined macro: AM_INIT_AUTOMAKE
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
configure.ac:47: error: possibly undefined macro: AM_PROG_AR
configure.ac:81: error: possibly undefined macro: AM_CONDITIONAL
configure.ac:348: error: possibly undefined macro: AC_CONFIG_FILES
configure.ac:357: error: possibly undefined macro: AM_COND_IF

Hi @fabianfrz,
Make sure that you also have the automake installed. Where did you got the build instructions from?

I used the common automake commands since the repository does not contain build instructions. As an Arch Linux user I do have a very new autotools version. It sometimes has compatibillity issues with old autotools files.

Hi @fabianfrz,
Indeed we don't have specific instructions/recipes for every distro, however we provide a generic instructions here:

https://github.com/SpiderLabs/ModSecurity/tree/v3/master#unix-linux-macos-freebsd-

You should be fine with ArchLinux, that is what I use on the daily bases.


Importing images has the wrong route in production builds

Reporting a bug?
When you import an image (and probably other file assets, as well), ex: import imgSrc from '../img.png';, the file is placed in a /static folder. This works perfectly fine in a local dev server.
But when you run react-static build, the path received from the import is missing the /static prefix, and your image reference is broken in the built site!
Digging through the react-static source, I think I've traced the problem to this file: https://github.com/react-static/react-static/blob/dbf750c/packages/react-static/src/static/webpack/rules/fileLoader.js
See how it passes different configuration to the loader depending on the "stage"? According to some console logging, this configuration is actually called twice during the build process - once for a stage of "node" and once for "prod".
I'd love to send a PR with a fix, but unfortunately, this is where I'm stuck. I don't know why it's doing this or if it's supposed to be solving another problem. In fact, I don't even know what "stages" are - the possible values appear to be "dev", "node", and "prod", which doesn't really make sense to me - when would Webpack not run in Node? It wouldn't exactly work in the browser, right?
I did manage to find a workaround, though - create a plugin at node.api.js:
export default () => ({
  webpack: (config, {stage}) => {
    if (stage === 'node') {
      const fileRule = config.module.rules[0].oneOf.find((x) => x.loader === 'url-loader');
      fileRule.options.name = 'static/[name].[hash:8].[ext]';
    }
    return config;
  },
});

This is probably extremely brittle, and I don't know if it has any other detrimental side effects.
Environment
Run and copy the result of:
npx envinfo --system --npmPackages react* --binaries --npmGlobalPackages react* --browsers
here:
  System:
    OS: macOS Mojave 10.14.6
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
    Memory: 106.03 MB / 16.00 GB
    Shell: 5.3 - /bin/zsh
  Binaries:
    Node: 10.15.3 - ~/.nvm/versions/node/v10.15.3/bin/node
    npm: 6.9.0 - ~/.nvm/versions/node/v10.15.3/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Browsers:
    Chrome: 77.0.3865.90
    Firefox Developer Edition: 70.0
    Safari: 13.0.2
  npmPackages:
    react: ^16.9.0 => 16.10.2
    react-dom: ^16.9.0 => 16.10.2
    react-static: ^7.2.0 => 7.2.2
    react-static-plugin-reach-router: ^7.2.0 => 7.2.2
    react-static-plugin-sitemap: ^7.2.0 => 7.2.2
    react-static-plugin-source-filesystem: ^7.2.0 => 7.2.2

of course include any other package versions here if relevant.
Steps to Reproduce the problem
Base your steps off of any freshly installed react-static template!

Start from the "basic" template
Add an image into the "src" dir, ex. src/img.png.
In pages/about.js, import that image and render it:

import React from 'react';
import imgSrc from '../img.png';

export default () => {
  return (

React Static is a progressive static site generator for React.

  );
};

Run npm run build and then npm run serve to see a built version of the site
Navigate to the "About" page on the site
The image you included is missing, because the src is something like /62faa5fe0f4d6c46784c1eb0e08b0ed6.png and the image is in dist/static/img.62faa5fe.png
If you navigate to the same page, you'll see the image appear, with the correct src.

Expected Behavior
The image's src should match up to where Webpack actually placed the image.
Reproducible Demo
Here's a repo with the code-based steps in "Steps to Reproduce the Problem" already done: https://github.com/dallonf/react-static-img-repro

I am having a similar issue. It seems a package updated under the hood where some /template file paths are not respecting the assetPath key.

I am having a similar issue. It seems a package updated under the hood where some /template file paths are not respecting the assetPath key.

There's actually a separate issue related to assetsPath specifically, I've got a PR out to resolve that: https://github.com/react-static/react-static/pull/1329

I had the same issue, but after digging through the documentation I decided to go with the following solution
node.api.js
export default pluginOptions => ({
    webpack: (webpackConfig, state) => {
        webpackConfig.module.rules = [{
            oneOf: [
                state.defaultLoaders.jsLoader,
                state.defaultLoaders.jsLoaderExt,
                state.defaultLoaders.cssLoader,
                {
                    loader: 'url-loader',
                    test: /\.(jpg|png)$/,
                    query: {
                        limit: 100,
                        name: 'static/[name].[hash:8].[ext]',
                    },
                },
                state.defaultLoaders.fileLoader,
            ]
        }]

        return webpackConfig
    }
})

For what it is worth, in this file
node_modules/react-static/lib/static/webpack/rules/fileLoader.js
if I change this:
options: {
    limit: 10000,
} // Don't generate extra files during node build

to:
options: {
    limit: 10000,
    name: 'static/[name].[hash:8].[ext]',
} // Don't generate extra files during node build

The image paths are now correct in the dist folder.  Perhaps the bug could be lanced by doing what is counter to this comment // Don't generate extra files during node build ?

same issue