HBASE-25737 Backport HBASE-24305 to branch-2.3

Signed-off-by: Duo Zhang<EMAIL_ADDRESS>Signed-off-by: stack<EMAIL_ADDRESS>

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 38s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 49s
branch-2.3 passed

+1 :green_heart:
compile
5m  0s
branch-2.3 passed

+1 :green_heart:
checkstyle
2m 17s
branch-2.3 passed

+1 :green_heart:
spotbugs
4m  5s
branch-2.3 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 34s
the patch passed

+1 :green_heart:
compile
4m 56s
the patch passed

+1 :green_heart:
javac
4m 56s
the patch passed

+1 :green_heart:
checkstyle
0m 22s
hbase-common: The patch generated 0 new + 0 unchanged - 25 fixed = 0 total (was 25)

+1 :green_heart:
checkstyle
0m 35s
The patch passed checkstyle in hbase-client

+1 :green_heart:
checkstyle
1m 18s
hbase-server: The patch generated 0 new + 275 unchanged - 3 fixed = 275 total (was 278)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m 33s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
4m 27s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

60m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3128

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux c790f2770e3a 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 96773913ce

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
86 (vs. ulimit of 12500)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 33s
branch-2.3 passed

+1 :green_heart:
compile
1m 45s
branch-2.3 passed

+1 :green_heart:
shadedjars
5m  1s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 24s
branch-2.3 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 22s
the patch passed

+1 :green_heart:
compile
1m 43s
the patch passed

+1 :green_heart:
javac
1m 43s
the patch passed

+1 :green_heart:
shadedjars
5m  5s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 23s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 24s
hbase-common in the patch passed.

+1 :green_heart:
unit
2m 16s
hbase-client in the patch passed.

-1 :x:
unit
138m  7s
hbase-server in the patch failed.

168m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3128

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 1e101445ef8a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 96773913ce

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/1/testReport/

Max. process+thread count
4359 (vs. ulimit of 12500)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 20s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  8s
branch-2.3 passed

+1 :green_heart:
compile
2m  0s
branch-2.3 passed

+1 :green_heart:
shadedjars
5m 50s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 18s
hbase-common in branch-2.3 failed.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 58s
the patch passed

+1 :green_heart:
compile
2m  0s
the patch passed

+1 :green_heart:
javac
2m  0s
the patch passed

+1 :green_heart:
shadedjars
5m 50s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 18s
hbase-common in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 49s
hbase-common in the patch passed.

+1 :green_heart:
unit
2m 28s
hbase-client in the patch passed.

+1 :green_heart:
unit
135m 51s
hbase-server in the patch passed.

171m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3128

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 033e5cfc4fdc 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 96773913ce

Default Java
AdoptOpenJDK-11.0.10+9

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/1/testReport/

Max. process+thread count
3676 (vs. ulimit of 12500)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 14s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 49s
branch-2.3 passed

+1 :green_heart:
compile
5m  0s
branch-2.3 passed

+1 :green_heart:
checkstyle
2m 17s
branch-2.3 passed

+1 :green_heart:
spotbugs
3m 56s
branch-2.3 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 38s
the patch passed

+1 :green_heart:
compile
4m 56s
the patch passed

+1 :green_heart:
javac
4m 56s
the patch passed

+1 :green_heart:
checkstyle
0m 22s
hbase-common: The patch generated 0 new + 0 unchanged - 25 fixed = 0 total (was 25)

+1 :green_heart:
checkstyle
0m 35s
The patch passed checkstyle in hbase-client

+1 :green_heart:
checkstyle
1m 15s
hbase-server: The patch generated 0 new + 275 unchanged - 3 fixed = 275 total (was 278)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m 34s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
4m 27s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

59m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3128

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 7cfff59d4a81 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 96773913ce

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
86 (vs. ulimit of 12500)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 32s
branch-2.3 passed

+1 :green_heart:
compile
1m 43s
branch-2.3 passed

+1 :green_heart:
shadedjars
5m  1s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 25s
branch-2.3 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 22s
the patch passed

+1 :green_heart:
compile
1m 45s
the patch passed

+1 :green_heart:
javac
1m 45s
the patch passed

+1 :green_heart:
shadedjars
5m  5s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 20s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 32s
hbase-common in the patch passed.

+1 :green_heart:
unit
2m 15s
hbase-client in the patch passed.

+1 :green_heart:
unit
136m 33s
hbase-server in the patch passed.

167m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3128

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6da422772418 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 96773913ce

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/2/testReport/

Max. process+thread count
3938 (vs. ulimit of 12500)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 32s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 54s
branch-2.3 passed

+1 :green_heart:
compile
2m 37s
branch-2.3 passed

+1 :green_heart:
shadedjars
8m 11s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 21s
hbase-common in branch-2.3 failed.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 30s
the patch passed

+1 :green_heart:
compile
2m 33s
the patch passed

+1 :green_heart:
javac
2m 33s
the patch passed

+1 :green_heart:
shadedjars
8m  8s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 20s
hbase-common in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
2m 17s
hbase-common in the patch passed.

+1 :green_heart:
unit
2m 35s
hbase-client in the patch passed.

+1 :green_heart:
unit
138m 41s
hbase-server in the patch passed.

186m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3128

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d302f52c7748 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 96773913ce

Default Java
AdoptOpenJDK-11.0.10+9

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/2/testReport/

Max. process+thread count
3585 (vs. ulimit of 12500)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3128/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


[Bug]: LlamaIndex Not Returning similarity_top_k Chunks with Azure Cognitive Search

Bug Description
When using LlamaIndex with Azure Cognitive Search, setting similarity_top_k=20 and max_search_results=20 doesn't retrieve the expected 20 chunks. Instead, fewer chunks (e.g., 7-8) are returned.
Version
0.11.13
Steps to Reproduce

Initialize AzureAISearchVectorStore with max_search_results=20.
Set similarity_top_k=20 in the retriever configuration.
Execute a query using the LlamaIndex query engine.
Observe that fewer than 20 chunks are returned.

Relevant Logs/Tracbacks
No response

@dosu
I'm already doing exactly as suggested by setting similarity_top_k=20 in my configuration, as mentioned in my original report. I've verified that similarity_top_k and max_search_results are set correctly. Additionally, I have confirmed that there are enough nodes available in my index (84 nodes in total), so availability isn't the issue.
It seems that despite these settings, the retrieval process still returns fewer chunks than expected. Could you please check if there's any other internal constraint that might be causing this?

@dosu
I've implemented all the recommendations you provided:

Verified Field Names: Confirmed that all field names in my code match those in my Azure Cognitive Search index.
Checked for Constraints: Ensured that there are no additional constraints like filters, node_ids, or doc_ids affecting the retrieval.
Configured Retriever: Set similarity_top_k=20 when creating the query engine.

Despite these changes, I'm still not receiving the expected number of chunks; the issue remains unresolved

Increasing efSearch from 500 to 1000 worked, and I’m now able to retrieve the expected number of chunks.


Version Validator Module

Add New Module call VersionCheck to validate the version and give you the status of what's the state of validation.
I've documented it and you can read more in the comments.
Also added test

See my inline comments. Besides those, things looks fine to me.

Looking forward to use this 💪🏼 Left a few comments, hope you can use some of it


Fix rangePlugin selection problems

When selecting an end date older than the start date (and vice versa), the rangePlugin does not sort the dates and it leads to various selection problems afterwards.
You can test one of the problem in the example page. Select a date range, then click on the first input and select a date greater than the second one. The first date wont change making it hard to select the proper range.
IMHO the focused input must be set to the selected date and the other input has to select a valid date.
Might also fix #1276

@chmln Why is this still not merged ? It does fix #1379 and probably #1276

Could we please get this merged...?

@chmln Thank-you very much for merging!
I don't want to push my luck but do you have any ETA for publishing a new release to NPM?


windows k8's monitoring, no data. 1.21.0 alpha

Description
Tried 1.21 alpha. Pods start and run, and we can see the nodes in inventory but they are not sending back any data.
Steps to Reproduce
Run 1.21.0 alpha for windows
Expected Behavior
Data in new relic console
Relevant Logs / Console output
nrwindows.log
Pod output is attached.
Your Environment
Rancher provisioned cluster running kube 1.17.5. We have newrelic in place and working on the linux nodes, and ksm is running there.
Additional context
We used the existing service account, namespace and ksm as the liux version that already exists.

Hello @jayntguru !
Many thanks for reaching out! Are the Linux nodes reporting correctly? Also, could you share the Windows version?

Yes, we're long time users of the Linux integration, and in that same cluster we're getting data from the linux nodes.
Windows hosts are -
Major    : 10
Minor    : 0
Release  : 1809
Build    : 17763
Revision : 1339

Hi @jayntguru !
I am sorry for the late reply! We are currently testing the latest changes on the integration for Windows nodes. We will give you an update as soon as possible.

No update on this yet. We have not forgotten about this issue.

Hi @jayntguru,
We released a new Kubernetes version for Windows (v2.2.0). You could try to update to that version and see if it solves the issue. Unfortunately, we no longer offer support for Kubernetes on Windows.
However, we have provided build instructions in case someone wants to build the image themselves.


[WIP] EventMesh Dashboard: Configuration

Motivation
The dashboard page displays the current configuration of EventMesh.

The license check did not pass, please check if the license was added, or the format is not accurate?

The license check did not pass, please check if the license was added, or the format is not accurate?

Yes I will add the missing licenses later.


Trouble reproducing XLSR-53 numbers on CommonVoice

Hi,
I have issue reproducing the XLSR-53 numbers reported in the paper (https://arxiv.org/abs/2006.13979) on CommonVoice. I am getting an average PER of 9.85 over 10 languages, while the paper report an average PER of 7.6 (Table 1). I am using the latest version of fairseq, and I tried both 1-hour and 10-hour wav2vec2 finetuning configurations. I am wondering if someone could give me some tips on tuning it to the reported numbers?
Thanks in advance!!

@jefflai108 Hi,I have a question about XLSR-53 pretraining model. I cannot reproduce the results of the table. Does the CER results in the table contain the separator '|'. In other words, whether the delimiter ‘|’ is calculated when counting the CER. The results in the table seem to calculate the separator ‘|’. Have you encountered similar problems？ Thank you in advance for your reply.


Users/davidegiacometti/terminal plugin

Summary of the Pull Request
What is this about:
What is include in the PR:
How does someone test / validate:
Quality Checklist

[ ] Linked issue: #xxx
[ ] Communication: I've discussed this with core contributors in the issue.
[ ] Tests: Added/updated and all pass
[x] Installer: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Docs: Added/ updated
[ ] Binaries: Any new files are added to WXS / YML

[ ] No new binaries
[ ] YML for signing for new binaries
[ ] WXS for installer for new binaries

Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.

What's this PR for? This branch seems already merged and deleted.
cc: @davidegiacometti / @crutkas

@Sylwester2703 Terminal plugin is merged and released, what is this about?

Looks like spam to me.
New account/other issue just with the empty template on another repo.


Horrible performance

Hi! I ran the vdom benchmark, and I have to state that the performance is horrible. Any plans to fix this shortly? Else, a very great concept. But there are so many vdom libraries out there that have better performance.

which vdom libraries did you compare that made you think the performance of react-lite is horrible?

Well. It's well known that React itself say it's slow at many points.
Upcoming v. 15 RC1 have some major performance improvements where they now stopped using innerHTML and uses createElement. See latest release notes.
jsbm and some other React devs - incluced spicyj - stated earlier that the way React is handling children is slow and they have been looking into alternative solutions.
If you compare React-lite with other - incomplete libs - on vdom benchmark, or run the uibench. You will quickly notice who is the looser. Many factors here ofc. But if you had introduced a proper algorithm that handle children - as found in Kivi, Cito etc. Your performance would be way better.
Another performance gain is to handle text nodes as pure strings. Diffing / operation on a text node is slow. textContent and nodeValue is faster. I know React was discussing this.
As a start, React now did some major changes in upcoming release regarding to get rid of spans and replace with comment nodes for SSR - wich you aren't supporting.
But this again had impact on the render() functionality, example render into null that was introduced in React 0.12. Now this is improved so the render performance is better in React.
Such things I was thinking of when I posted this issue ;)

I got you , and I also had saw this post : https://facebook.github.io/react/blog/2016/03/07/react-v15-rc1.html
In next versio of react-lite, rendering null will use comment nodes too.
The source code of react-lite is very simple and clear, it's easy to read and improve for everyone, pull request is welcome.
Thanks for feedback and discussing ;)

You are welcome :) And I have to mention there is one things I can't understand. If you diff one vnode with text where the other doesn't have text. E.g.
nodeA - text: 'Foo'
nodeB
Normaly I would expected 'Foo' to be unset, but nodeB get a undefined as it text :)

Does react do it like that?
With react-lite, nodeA has only a child which it is a text node, and nodeB has no children, so that if nodeA and nodeB have the same type and key, the children of nodeA would be removed.

I haven't checked, but it very obvious that this is the correct method. All other major libs does it like that far as I know. And I prefer that nothing is visible if I diff to no text rather then undefined. In my world that make no sense. Yes, of you can diff a empty string....
As I wrote earlier, React have plans to change it structure regarding this.
But for me the logic is if nodeA have 4 children and nodeB have 2 children, is that my result will be a new node with 2 children.
Not a new node with 2 children and 2 undefined :)
You actually do something like this already when you diffing two trees. Remove the tree if one of them are null / undefined.  And if equal root, you are diffing.
Look into some of the various diffing algorithms.
https://github.com/localvoid/kivi/blob/master/src/vnode/vnode.js#L986.

Yes. React does this it seems. Take a look into DOMChildrenOperations and processUpdates. There you find ReactMultiChildUpdateTypes.REMOVE_NODE

@Lucifier129 so no plans to improve performance?
Even virtual-dom who actually are using a 1:1 copy of react diff algo is 80% faster then react-lite

Need other people help to improve performance, now I have no idea how to do it.

@Lucifier129  Okay. Let's start then.
Phase 1 - drop from 280 down to 200 in vdom bench

Get rid of hasOwnProperty in major places. React doesnt support IE8 anymore.
For Own give a deoptimization in Chrome and some other browsers now. Use Object.keys and a normal for iteration loop.
use Chrome profile to find and remove all DEOPTS
Get rid of your double use of Prototype in Component. *Updater merge into Component protoype
Use for-loops where you can. Avoid caching length property. Gives better results in Chrome
Avoid reduntant code. So remove bloat. Many places where you have redundant code.

Phase 2 - drop from 200 down to 100 in vdom bench

Stop calling functions withing functions. E.g removeNode. Use it as it is without renaming it to a noop. This can be done if you have a separate function you call from the destroy() functions. Renaming it to noop, and all other stuff is expensive and should be avoided. Take a look at the Kivi library for examples.

Create a separate function for removing async children, and call this function from the removeNode() function. Just make sure you don't delete the children. Examples for this you can find in the vidom library and Kivi library.

Don't do more logic then React does. Example in createElement. You are calling extend() twice. Not needed. See what React does and you can reduce this down to 1.
There are other places as well where this can be done.

Add suport for reordering.

Children. This isn't 100% React compat, React uses a more effective method for dealing with children, sorting, reoerdering and removing them. Try to adopt it, and the new smart algorithms that come with React 0.14.

Create a new function you name moveNode(). This method uses appendChild or insertTo. More or less like Reacts insertAt. You will need it for phase 3.
Try to use this insertAt / movenode() in the same places as React does.

Cleanup the code. Remove duplication. Simplify where you can to get a smaller code base.

Phase 3
Coming soon

Phase 4 - Finale
coming soon


Local only access for the gen2 miniserver

According to the documentation, I need to enter the loxonecloud address for my gen2 miniserver. However, I am not allowing my miniserver to be externally accessible. Is this a hard requirement and therefore an all-local integration not possible?If so, can you tell me where this restriction comes from so that I can try to find an alternative approach myself?
I can access the server using things like http://local-ip/data/LoxAPP3.json 1. Also, simply going to http://local-ip gives me the web ui for the server. I am also ok with self signed certificates or even using http only as long as I do not need to open up the miniserver externally.
Thanks a lot for providing this binding in the first place!
If I do follow the documentation, I am getting the following error message in home assistant:
2021-08-06 15:12:31 ERROR (MainThread) [custom_components.loxone.api] Could not connect to Loxone! Status code 409.
2021-08-06 15:12:31 ERROR (MainThread) [custom_components.loxone.miniserver] Error connecting to loxone miniserver #2 Code (False)

This makes sense, since my loxone server is not exposed and known to the loxone dns server.

According to the official API documentation, accessing the Gen2 miniserver should also be possible without cloud access. See https://www.loxone.com/dede/wp-content/uploads/sites/2/2021/06/1201_Communicating-with-the-Miniserver.pdf on page 12:

How can I connect locally with TLS?
As long as your Miniserver is capable of TLS and is using our CloudDNS-Certificate, you can. You
need to create a hostname just like if you would connect from the internet, but use your
Miniservers local IP and port. E.g. “192-168-1-47.{snr}.dyndns.loxonecloud.com:443”

If the Miniserver is using a custom certificate, connecting with it via it’s local IP will result in
certificate verification errors.

When I open the URL in the form of https://local-ip.serialnumber.dyndns.loxonecloud.com (with dashes instead of dots for the ip), I can reach the server just fine. Source: https://github.com/Loxone/lxcommunicator
Using the same IP and port 443 for PyLoxone, I am getting the following error message in the home assistant log:
2021-08-06 15:04:33 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry PyLoxone for loxone
Traceback (most recent call last):
File "/usr/lib/python3.8/site-packages/h11/_state.py", line 249, in _fire_event_triggered_transitions
new_state = EVENT_TRIGGERED_TRANSITIONS[role][state][event_type]
KeyError: <class 'h11._events.ConnectionClosed'>
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/lib/python3.8/site-packages/homeassistant/config_entries.py", line 293, in async_setup
result = await component.async_setup_entry(hass, self) # type: ignore
File "/config/custom_components/loxone/__init__.py", line 132, in async_setup_entry
if not await miniserver.async_setup():
File "/config/custom_components/loxone/miniserver.py", line 101, in async_setup
request_code = await self.lox_config.getJson()
File "/config/custom_components/loxone/api.py", line 60, in getJson
api_resp = await requests.get(url_api,
File "/config/.local/lib/python3.8/site-packages/requests_async/api.py", line 11, in get
return await request("get", url, params=params, **kwargs)
File "/config/.local/lib/python3.8/site-packages/requests_async/api.py", line 6, in request
return await session.request(method=method, url=url, **kwargs)
File "/config/.local/lib/python3.8/site-packages/requests_async/sessions.py", line 79, in request
resp = await self.send(prep, **send_kwargs)
File "/config/.local/lib/python3.8/site-packages/requests_async/sessions.py", line 136, in send
r = await adapter.send(request, **kwargs)
File "/config/.local/lib/python3.8/site-packages/requests_async/adapters.py", line 48, in send
response = await self.pool.request(
File "/config/.local/lib/python3.8/site-packages/http3/interfaces.py", line 49, in request
return await self.send(request, verify=verify, cert=cert, timeout=timeout)
File "/config/.local/lib/python3.8/site-packages/http3/dispatch/connection_pool.py", line 130, in send
raise exc
File "/config/.local/lib/python3.8/site-packages/http3/dispatch/connection_pool.py", line 120, in send
response = await connection.send(
File "/config/.local/lib/python3.8/site-packages/http3/dispatch/connection.py", line 59, in send
response = await self.h11_connection.send(request, timeout=timeout)
File "/config/.local/lib/python3.8/site-packages/http3/dispatch/http11.py", line 58, in send
http_version, status_code, headers = await self._receive_response(timeout)
File "/config/.local/lib/python3.8/site-packages/http3/dispatch/http11.py", line 130, in _receive_response
event = await self._receive_event(timeout)
File "/config/.local/lib/python3.8/site-packages/http3/dispatch/http11.py", line 161, in _receive_event
event = self.h11_state.next_event()
File "/usr/lib/python3.8/site-packages/h11/_connection.py", line 443, in next_event
exc._reraise_as_remote_protocol_error()
File "/usr/lib/python3.8/site-packages/h11/_util.py", line 76, in _reraise_as_remote_protocol_error
raise self
File "/usr/lib/python3.8/site-packages/h11/_connection.py", line 427, in next_event
self._process_event(self.their_role, event)
File "/usr/lib/python3.8/site-packages/h11/_connection.py", line 242, in _process_event
self._cstate.process_event(role, type(event), server_switch_event)
File "/usr/lib/python3.8/site-packages/h11/_state.py", line 238, in process_event
self._fire_event_triggered_transitions(role, event_type)
File "/usr/lib/python3.8/site-packages/h11/_state.py", line 251, in _fire_event_triggered_transitions
raise LocalProtocolError(
h11._util.RemoteProtocolError: can't handle event type ConnectionClosed when role=SERVER and state=SEND_RESPONSE

@davosian Now I am back. By the way are you german? If so we can speak german.
For me it is hard to test it because I have a gen1 which is not capable to access via the external cloud loxone dns service. What I know is that it is working with external access enabled (remote connect)

I already had some users which are using the gen2 but all with remote connect enabled. Can you try it only for test purpose with the remote connect?
You have to enter the Miniserver ip without https://

Hey @JoDehli, welcome back :)
I have tried a few things in the meantime. Unfortunately, I did not get it to work yet, but I have learned a few things along the way. Here is what I tried:
For testing, I enabled Remote Connect and made sure to allow for Loxone Config to configure the server remotely. In order to make this work, you have to register your Miniserver with Loxone which I did.

Testing with Home Assistant
First attempt
I then tried to connect through homeassistant with the following configuration (I double-checked the password):

After a home assistant restart, I find the following error in the log:

Second attempt
When I switch the port to 443, I get a different 500 error:

Testing with Pyloxone-api
I then discovered your second project Pyloxone-api so I used this to debug the issue further:
# running in `poetry shell`
pytest ./tests/test_online.py --host=MYLOCALIP --username=MYUSER --password=MYPASSWORD

This was giving me a successful (local) connection, so I went on to use the remote connection instead:
# running in `poetry shell`
pytest ./tests/test_online.py --host=dns.loxonecloud.com/MYSERIALNR --username=MYUSER --password=MYPASSWORD --use-tls

This results in the test failing with a 500 error (like the home assistant integration):
        # Handle errors. An http error getting any of the required data is
        # probably fatal, so log it and raise it for handling elsewhere. Other errors
        # are (hopefully) unlikely, but are not handled here, so will be raised
        # normally.
        except httpx.RequestError as exc:
            _LOGGER.error(
                f'An error "{exc}" occurred while requesting {exc.request.url!r}.'
            )
            raise LoxoneRequestError(exc) from None
        except LoxoneHTTPStatusError as exc:
            _LOGGER.error(exc)
>           raise LoxoneHTTPStatusError(exc) from None
E           pyloxone_api.exceptions.LoxoneHTTPStatusError: Code 500. Miniserver response was <Answer cmd="getip" IP="" Code="500" />

pyloxone_api/api.py:183: LoxoneHTTPStatusError
----------------------------------------------------- Captured log call -----------------------------------------------------
ERROR    pyloxone_api.api:api.py:182 Code 500. Miniserver response was <Answer cmd="getip" IP="" Code="500" />
================================================== short test summary info ==================================================
FAILED tests/test_online.py::test_online - pyloxone_api.exceptions.LoxoneHTTPStatusError: Code 500. Miniserver response wa...
===================================================== 1 failed in 0.31s =====================================================

I then tried variants of the test command without --use-tls and with different ports using --port=80 and --port=443 but I always ended up with 500 error messages.
Testing with LxCommunicator
At this point, I was wondering whether my remote access was the problem, so I decided to test the "official" node.js code sample from the LxCommunicator v1.0.1 project: I cloned the repository, changed the connection parameters inside the ./test/index.js file to use my cloud DNS credentials and then ran the test:
$ npm test

><EMAIL_ADDRESS>test /home/myuser/lxcommunicator
> node ./test/index.js

{ token:
   'SOMETOKEN=',
  key:
   'SOMEKEY',
  validUntil: 402914356,
  tokenRights: 1668,
  unsecurePass: false,
  username: 'MYUSER',
  msPermission: 1668,
  timeouts:
   { '1668':
      Timeout {
        _called: false,
        _idleTimeout: 86400000,
        _idlePrev: [TimersList],
        _idleNext: [TimersList],
        _idleStart: 3399,
        _onTimeout: [Function: bound _keepAliveFired],
        _timerArgs: undefined,
        _repeat: null,
        _destroyed: false,
        [Symbol(unrefed)]: false,
        [Symbol(asyncId)]: 109,
        [Symbol(triggerId)]: 108 } } }
Successfully executed 'dev/sps/enablebinstatusupdate' with code 200 and value 1
17ab174e-0162-545f-ffff9f8aab4cf11a -> 7
17ab174e-0172-5471-ffff9f8aab4cf11a -> 381
17ab174e-0172-5474-ffff9f8aab4cf11a -> 1242
17ab174e-020e-5739-ffff9f8aab4cf11a -> 1
17ab174e-020e-5735-ffff9f8aab4cf11a -> 1
17ab174e-0173-2587-ffffacc9ae31a9ea -> 0
17ab174e-0191-54af-ffff9f8aab4cf11a -> 0
17ab174e-0191-54b8-ffff9f8aab4cf11a -><PHONE_NUMBER>00

As you can see, this test was successful in that I was able to connect and also retrieved actual sensor data.
My conclusion out of this is, that there probably is something not right using remote access in your current implementation - at least related to my particular setup. Let me know how I can help to debug this further. And yes, we can have a conversation "auf Deutsch", no problem ;) I simply stuck to English in case someone else stumbles across this issue (or in case other contributors would like to jump in).

Btw, I also tried adding the Loxone test server from https://github.com/Loxone/lxcommunicator/blob/dc70d793407bcab2edeecd0c3550acda2f536d24/test/index.js#L64 to home assistant, but I am getting the same Error connecting to loxone miniserver #1 in Home Assistant. I am not sure though whether it is a Gen1 or a Gen2 and adding it remotely is enabled in the first place.
Also, my own Miniserver is still in a testing mode and I could provide you with access to help you with debugging.

The Testserver is a gen1 and remote access will not function.
The loxone-api project is also from a pyloxone user and me. Well he did most of the work based of my pyloxone implementation.
The goal is to use the loxone-api in future releases of pyloxone. Maybe you can wait if we merged them together. I do not know when we do that because I want to make sure that it is working correctly.
And as I already mentioned I can not test it because I have no gen2 for testing.
If you want you can give me access to your test system. I could try to implement it for both systems (pyloxone and pyloxone-api) for remote access enabled if it is no so much work.

@JoDehli I will gladly give you access if this helps debugging the issue. I have now set up a user for this that I will pass on to you. Kindly let me know how I can contact you to exchange the details.
Regarding the two projects: I am mainly interested in the home assistant integration but I thought that it might be easier to debug with the test case you have for the loxone-api project. Whatever makes the most sense to you.
Maybe it also helps to understand how Loxone is handling the authentication by checking their project at https://github.com/Loxone/lxcommunicator? Just an idea...

@davosian  I have made a discord server. https://discord.gg/ZTbDjxw8 there you can write me a private message.

I am watching this topic with interest so staying in English really helps me :-)

Hi @JoDehli , the same error here... any update on that? Thanks for your work

I have now gen2 so I can not test it. Sorry. You must use the local access for now.

@JunoGregoire why do you want a external access from you homeassistant? For security it makes no sense I think? Is your homeassistant not in the same network as you loxone?

@JoDehli I don't really want external access, that's the point. But it appears like I have to allow external access to my Miniserver to be able to use HA and Loxone gen 1 Miniserver together. Is there no option to make them talk to each other over LAN?

I have a gen1 with external access disabled. I have chosen a different port than 80. Then I entered the IP in the configuration from the pyloxone with that port. No need to external access.

Of course I disabled external access in the loxone. Maybe you have there a manual external access defined. Did you checked that..

I followed the directions above which specify to use Loxone Cloud.

Hi, I am a little bit confused. So currently, I don't need to know how, but whether is there a way to connect HA to Loxone miniserver gen2 totally locally. Because I can not risk not working integration with internet black out. At the moment, it seems to me that communication flows over Loxone cloud? Or Loxone cloud just provides local ip of Loxone miniserver? Than I would just set static ips for local network and should be good. I would really like to have HA and also Loxone server disconnected from the internet. Just considering these two systems to use, so thanks for quick answer.

Sorry I can not implement it because I have no gen2. I can not help you with this problem.

I have a gen 2 mini server but I am also having issues.
If I enter the dyndns.loxonecloud.com IP I can not start the integration.
2022-10-19 21:51:17.538 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry PyLoxone for loxone
File "/config/custom_components/loxone/__init__.py", line 156, in async_setup_entry
File "/config/custom_components/loxone/miniserver.py", line 118, in async_setup
File "/config/custom_components/loxone/api.py", line 121, in getJson

If I enter my local IP (port 80) I can start the integration but I am not receiving any sensor values and can not send any command to the miniserver
Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/websockets/legacy/protocol.py", line 956, in transfer_data
    await asyncio.shield(self._put_message_waiter)
asyncio.exceptions.CancelledError

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/config/custom_components/loxone/miniserver.py", line 167, in listen_loxone_send
    await self.api.send_websocket_command(device_uuid, value)
  File "/config/custom_components/loxone/api.py", line 387, in send_websocket_command
    await self._ws.send(command)
  File "/usr/local/lib/python3.10/site-packages/websockets/legacy/protocol.py", line 620, in send
    await self.ensure_open()
  File "/usr/local/lib/python3.10/site-packages/websockets/legacy/protocol.py", line 921, in ensure_open
    raise self.connection_closed_exc()
websockets.exceptions.ConnectionClosedError: sent 1011 (unexpected error) keepalive ping timeout; no close frame received

Anyone who got a gen 2 server working locally?

Used remote connection as test but I am still receiving this error
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/websockets/legacy/protocol.py", line 956, in transfer_data
await asyncio.shield(self._put_message_waiter)
asyncio.exceptions.CancelledError
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/config/custom_components/loxone/miniserver.py", line 167, in listen_loxone_send
await self.api.send_websocket_command(device_uuid, value)
File "/config/custom_components/loxone/api.py", line 387, in send_websocket_command
await self._ws.send(command)
File "/usr/local/lib/python3.10/site-packages/websockets/legacy/protocol.py", line 620, in send
await self.ensure_open()
File "/usr/local/lib/python3.10/site-packages/websockets/legacy/protocol.py", line 921, in ensure_open
raise self.connection_closed_exc()
websockets.exceptions.ConnectionClosedError: sent 1011 (unexpected error) keepalive ping timeout; no close frame received

Disabling remote access in loxone miniserver seems to have make it work. /happydance !!

Currently working on another project directly using the API from this repo and I get the following code at https://github.com/JoDehli/PyLoxone/blob/master/custom_components/loxone/api.py#L477
websockets.exceptions.ConnectionClosedOK: received 1000 (OK) normally closed; then sent 1000 (OK) normally closed.
Any ideas what could cause this?

No. When did it happen on start or after a certain time?

Right away.

Are there any updates on this?
I get the same error message as brechtvhb also don‘t get any updated sensor values.
I don‘t want to disable remote access on the miniserver.

I am using the pyloxone beta from https://github.com/JoDehli/PyLoxone_beta/releases with a gen2 miniserver and remote access disabled. This setup is working fine also delivering sensor values. However, when I enable remote access, I am also not getting any updates (at least last time I checked on release 0.0.8 a few months ago).

Currently working on another project directly using the API from this repo and I get the following code at https://github.com/JoDehli/PyLoxone/blob/master/custom_components/loxone/api.py#L477 websockets.exceptions.ConnectionClosedOK: received 1000 (OK) normally closed; then sent 1000 (OK) normally closed.
Any ideas what could cause this?

Getting the same error. Worked all fine an hour ago. Then made some changes (added new Virtual Inputs), now getting this received 1000 (OK) normally closed; then sent 1000 (OK) normally closed error.

What is the conclusion on this?
Can a gen 2 miniserver directly communicate over LAN without having internet access?
I have remote access on, but nevertheless, Loxone <> HA communication should always be over LAN only.
Did anybody have a working setup for this?
Thanks!

@davosian

I am using the pyloxone beta from https://github.com/JoDehli/PyLoxone_beta/releases with a gen2 miniserver and remote access disabled.

But with remote access disabled you can't use the Loxone dns, can you?
I definitely was able to run MS (gen2) with LoxoneDNS and PyLoxone connecting to it. Unfortunately, I have broken the setup (due to some infrastructure upgrade) and now, with newer HA (:stable) and latest PyLoxone I'm not able to connect to MS remote access allowed through their cloud; ATM I don't want any open ports into my how network.


Using slow pure-python SequenceMatcher. Install python-Levenshtein to remove this warning

I had a look at the troubleshooting section

[x] Yes
[ ] No

Describe the bug
Not a bug, but a warning about this missing module. I poked around a bit but couldn't figure out why it wasn't loading the module (I see that it's included in the ./src/libs directory...)
To Reproduce
Steps to reproduce the behavior:

type cf
observe this error in Alfred's console:

[09:29:16.091] STDERR: ChatFred[Script Filter] /Users/luke/Sync/Settings/Alfred/Alfred.alfredpreferences/workflows/user.workflow.C171B2ED-8F91-4D00-987A-343A3EA0C7FC/src/libs/thefuzz/fuzz.py:11: UserWarning: Using slow pure-python SequenceMatcher. Install python-Levenshtein to remove this warning
  warnings.warn('Using slow pure-python SequenceMatcher. Install python-Levenshtein to remove this warning')

I'm on macOS 13.2.1, Alfred 5.0.6, ChatFred 1.3.0 directly installed (not from Gallery).

Hey @luckman212!
Thanks for pointing this out. I have seen the warning too and already tried to fix it.

"Solved" in: v1.3.1


KinematicBody2D move() pushes too far outside of collider

Operating system or device - Godot version:
Arch Linux x86_64, Godot 2.1.3
Issue description:

When running move() in a way that would move a kinematicbody2d into a tilemap (which I assume uses a staticbody2d), the move will move you out of the collider too far, causing you to float a short distance (less than 0.05 units for shorter moves) outside of the collider, rather than moving directly onto its surface. This causes jitteryness when handling gravity and wall collisions, and can even cause things like accidental jump boosts when hugging walls, if working on a small scale (in this case, 512x512 window size running at 0.125x scale)
Steps to reproduce:
Place a square with a staticbody2d and any collider with a flat surface (square works nicely).
Create a kinematicbody2d with a collider (square works nicely).
Put into _fixed_update() code to run move() that causes it to run into the collider head-on.

Link to minimal example project:

game.zip
Controls: w/d + space, or left+right+up
In this, a high jump can be achieved by uncommenting the move() in the collision check for res://scripts/player.gd, and then hugging the walls as you jump

Not sure if is a bug because by default is always pushing it 0.08 from the hit points.
In this example project you can get a better floor movement with a collision margin of 0.05 and a better wall hit effect with 0.04.

@eon-s Oh shit, I completely missed that. Would be nice though if we could move right on top of it, but yeah that works. Thanks, I'll close the bug.


fix(Workshop):now resenv images will be shown

@eKatchko
Now you see pre-build Research Environment Images also for workshop vms
Try to fulfill the following points before the Pull Request is merged:

[ ] Give a meaningfull description for the PR
[ ] The PR is reviewed by one of the team members.
[ ] If a linting PR exists, it must be merged before this PR is allowed to be merged.
[ ] It must be checked if anything in the Readme must be adjusted (development-, production-, setup).
[ ] It must be checked if any section in the wiki (https://cloud.denbi.de/wiki/) should be adjusted.
[ ] If the PR is merged in the master then a release should be be made.
[ ] The PR is responsive on smaller screens.
[ ] If the requirements.txt have changed, check if the patches still work
[ ] If the new code is readable, if not it should be well commented
[ ] In case the code is not well commented: An respectice commenting issue with tag "important" is opened.
[ ] If a squash of commits is required, it has been performed or will be performed at final merge
[ ] Finally a second team member checks if all requirements met

For releases only:

[ ] If the review of this PR is approved and the PR is followed by a release then the .env file
in the cloud-portal repo should also be updated.

Updated PR - filter now included refactored image detail - so getting images is now done in imagedetailcomponent


Role lock edge cases

Created by: MaxwellJung
Sometimes the game thinks a hero from the previous round is still getting played on the next round even though no one is picking that hero.
Happens occasionally after round transition.

moved from ow1_emulator_backup#680

Created by: MaxwellJung
Might have been fixed as of v0.8.7, but not sure

mentioned in merge request ow1_emulator_backup!344

Created by: MaxwellJung
Bug reappeared since v0.8.3

mentioned in commit 8b98004650975029032066924588405ad058080d

mentioned in commit d8d33dff81250b2b1102078bc62beb51acf90a99


Feature - Create more detailed error responses when submitting batch jobs

What type of PR is this?
This PR adds functionality to JobSubmitResponse when an error has occured. Previously the only thing returned was the error. The changes made in this PR allow the code to do 2 things:

Build a collection of errors, if mulitple jobs error for the same return, these changes will return them at the same time to the user. Rather than them having to reattempt submissions over and over again with 1 fix each time.
Return more detailed errors to the user by utilizing the JobSubmitResponse Struct

Which issue(s) this PR fixes:
Fixed #1748
┆Issue is synchronized with this Jira Task by Unito

Armada Before though armadactl

Armada After through armadactl

Submitted a bad sleep yaml job containing two jobs, both have invalid podSpecs as the requested and limit resources both contain "memory: 0"

This changes in this PR were merged into master a couple weeks ago, via a separate PR - closing this.


tbi: Adds @sap-ux/ui5-application-writer

https://github.com/SAP/open-ux-tools/issues/1689

Please move the changes of the cap-config to a separate PR since you change the API. It makes it easier to review its impact.

I dont think the API has changed actually. I have overloaded the existing function.

Please move the changes of the cap-config to a separate PR since you change the API. It makes it easier to review its impact.

I dont think the API has changed actually. I have overloaded the existing function.

You are correct, the existing calls won't break. Still, you have enhanced a module that is used in multiple places, so in the spirit of atomic changes and better review-ability, extract it.


Upgrade dependencies and enable Dependabot

We currently spend time upgrading and maintaining out dependency tree. We want to automate this.

[ ] Upgrade all dependencies yarn upgrade-interactive --latest  is a good tool for this.
[ ] Fix any breaking issues until the current dependencies are up to date.
[ ] Enable Dependabot.

As explained here, I'd rather not use automated deps updates as in my experience it's doing more harm than good. Especially because it doesn't understand nx and migrations we will be left with a broken monorepo at some point because Nx migrations have not been run.
https://github.com/kin-labs/kinetic/pull/306#issuecomment-1168682529
Instead, I am happy to take on maintenance of updates until further notice


Generalize ViewNumber type (#1375)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add onTap to Notification Widget

This PR adds functionality to set an onTap Function to be called when the user taps anywhere on the notification Material Widget.
New Parameters Added to ElegantNotification widget:

onTap Optional Parameter to set a Function to call when the notification is tapped.
dismissOnTap a boolean Flag to define wheater the notification should be dismissed when tapped (set to true by default).

Other Considerations:

A notification can have an onTap, an action and a closeButton each with their corresponding Function call.
added two new entries to the example app.

@koukibadr Have you considered allowing users to use actions + onTap?
There's a use case where tapping the notification, for example, navigates to a particular route, while using an action performs a quick response. This PR allows for both to be used.

The latest published version contains onTap and closeOnTap attributes where:

onTap a callback invoked when the user press the widget
closeOnTap boolean indicate whether the notification get closed on pressing it or not


No numeric datatypes possible in data_template

Home Assistant release (hass --version): 0.35.2
Python release (python3 --version): 3.4.2
Component/platform: Service calls
Description of problem:
If I have a service_call with a data_template it is not possible to pass any other datatypes that str to the service as data. All values will be converted to str. No matter if they're a template o not.
For example if I call the pilight.send service with normal service data:
    service: pilight.send
    data:
      "off": 1
      protocol: elro_800_switch
      unitcode: 0
      systemcode: 8

The following data will be sent to the service:
{'off': 1, 'protocol': ['elro_800_switch'], 'unitcode': 0, 'systemcode': 8}

If I use the data_template:
    service: pilight.send
    data_template:
      "off": 1
      protocol: elro_800_switch
      unitcode: 0
      systemcode: 8

I get
{'off': '1', 'protocol': ['elro_800_switch'], 'unitcode': '0', 'systemcode': '8'}

Which gets rejected by the pilight daemon because of the sringified values with a ERROR: elro_800_switch: insufficient number of arguments.
What I originally wanted to achieve is, to select the unitcode depending on the event_data of the trigger (see example config snippet). So i the end I also need to be able to keep a "templated" value (something like {{ trigger.event.data.unitcode }} as an int.
Expected:
At least the datatype of literals (untemplated values) should be left alone.
Problem-relevant configuration.yaml entries and steps to reproduce:
- alias: off again timer
  trigger:
    platform: event
    event_type: pilight_received
    event_data:
      protocol: elro_800_switch
      systemcode: 8
  action:
    - delay: 00:05:00
    - service: pilight.send
      data_template:
        "off": 1
        protocol: elro_800_switch
        unitcode: "{{ trigger.event.data.unitcode }}"
        systemcode: 8

Have you tried using a filter in the template to get a float or int for the values that need to be numeric?

Yes. I tried. Not even the untemlplated calues are converted to a string.

Closed by accident


Error trying to 'upload' data to server

I did a 'download', then turnaround and immediately try an 'upload'.  I receive the error:
Could not extract Language Type from filename
on this file:
journal/structures/Basic Web Content - <IP_ADDRESS>.xml
How's the best way to work around this?

Best way to work around this would be me writing better code...
Just pushed a fix. Update the DDM Tool and you should be good to go! Please let me know it it's working or the error still persists.

Hey...seems to work just fine.  No more error message.  But, I'm too dim to know what I'm doing yet (a very very noob).
By the way, sorry to ask...you don't have to answer...but what is the best way to jump start a theme development.  I've ready all the blogs and training and have created some 'dummy themes', but I'm really trying to find the best way to start (even pay someone to do it for me).  Do you know any good freelancers?

Well I work with @monator, we're a full time Liferay consultancy and partner. But, getting started with theming shouldn't be that hard.
Hit me on Skype: emil.oberg, Google Chat: emil.oberg gmail.com or email me at: emil.oberg  monator.com and I'll we'll see if I can point you in the right direction.
Btw, if you're looking at theme development, you probably want to take a look at this small development tool to help you with that: https://github.com/emiloberg/Liferay-Instant-Deploy-Theme-Changes-Gulp-Script

Emil,
Got that running just fine.  (Instant theme deploy).  However, LiveReload isn’t working.  I have the safari plugin.  I see the livereload in the  script.  I see it “connected” (that is to say, when i don’t have the gulp running it says ‘can’t connect’ and when it is running it does not error….but….there is no “live reload” as I always need to refresh to see any change (even simple color changes).  The Gulp script does copy the modified files to the destination just fine when I hit ‘save’…but that’s it….which in itself is a great time saver.
By the way, I spent some money on LiveReload for Mac https://itunes.apple.com/us/app/livereload/id482898991?mt=12 https://itunes.apple.com/us/app/livereload/id482898991?mt=12  , but I haven’t really gotten that to work either….haven’t really tried…
I’d love to chat a bit more about how to get started…and even talk to you about consulting work.
We are a ‘start-up’ company….presently working on round 1 funding.   In the middle of re-writing from scratch our software from CakePHP to Liferay. (I’m not a Cake person either….but I do have 15 years PHP experience).  I inherited the CakePHP CMS and after careful evaluations…decided to move to Liferay.
Couple of things concern me about Liferay

speed (or lack thereof)
memory footprint (it’s huge…do I need 16GB?  48GB?….when our Cake program runs in 512MB?)

I’m running the platform on Ubuntu 14.04 on Microsoft Azure at http://teams.execuvite.com http://teams.execuvite.com/ I have done some tuning on the Java Garbage collecting, cached all the javascript and themes, and removed some servlet filters (per the Liferay tuning blog).  But, it’s still dog slow.  Could be Azure…I found an interesting article comparing AWS, Azure, Google Compute.
Although I don’t have any real interest to code portlets and services and hooks myself, I am very concerned that the company we’re talking to to do the coding will use the proper approach and methods for Liferay.
(e.g…should I just be doing everything with DDL and Web Content and Display templates?).  I gotta support 1,000,000 users eventually…
Any thoughts?
Thanks for listening!
Regards,
James Barwick, CTO
Execuvite Pte Ltd

On 8 Jul 2015, at 8:30 pm, Emil Öberg<EMAIL_ADDRESS>wrote:
Well I work with @monator https://github.com/monator, we're a full time Liferay consultancy and partner. But, getting started with theming shouldn't be that hard.
Hit me on Skype: emil.oberg, Google Chat: emil.oberg gmail.com or email me at: emil.oberg monator.com and I'll we'll see if I can point you in the right direction.
Btw, if you're looking at theme development, you probably want to take a look at this small development tool to help you with that: https://github.com/emiloberg/Liferay-Instant-Deploy-Theme-Changes-Gulp-Script https://github.com/emiloberg/Liferay-Instant-Deploy-Theme-Changes-Gulp-Script
—
Reply to this email directly or view it on GitHub https://github.com/emiloberg/liferay-ddmtool/issues/8#issuecomment-119558800.

As for the LiveReload stuff not working as it should, it's kinda hard to debug without being in front of the computer, but have you tried the Safari or Firefox extension? Are those working? Can we rule out Chrome being the problem?
As Liferay goes, what you've to realize is that Liferay is an enterprise portal. CakePHP is a PHP Framework. A better comparison would be products from like Oracle WebSphere, SAP, etc. Just check the Gartner Magic Quadrant, we're looking at IBM, Oracle, Microsoft, SAP, IBM and Liferay.
So in short, to answer your questions: Yeah, you're gonna need powerful machines, no doubt about it. And yeah, you can get Liferay blazing fast no doubt about it. However, as this is an enterprise portal platform, it's a little more than just changing an apache setting which you might be used to. I'm trying to keep away from doing sysop things so I'm not really the person to ask on how to do it, but that it can be done - that I know. There's a lot of big Liferay installations. Your 1 000 000 won't be breaking any records.
As for DDL/WebContent/ADT/etc goes. Can't really answer that, I've no idea what you want to achieve, but generally I'd say that those things combined are powerful for displaying data.

Reason for me to be working with Liferay is because I 1) Like working with large scale IT systems, and, 2) Like working with a tool which enables me to do really rapid development and deployment.

Although I don’t have any real interest to code portlets and services and hooks myself, I am very concerned that the company we’re talking to to do the coding will use the proper approach and methods for Liferay.
(e.g…should I just be doing everything with DDL and Web Content and Display templates?).  I gotta support 1,000,000 users eventually…

This is an excellent question - I am a big fan of DDL/WebContent Templates/ADT/FreeMarker because it lets me get stuff done real fast, etc. But it is NOT a replacement for real enterprise web development, it doesn't replace Java or the need for high-scale transactional secure highly available backends (and other "-ilities"). But for my use cases it works great because it scales enough for me and it ultimately IS backed by a "high scale transactional secure highly available backend" i.e. Liferay :)
Anecdotally, I can tell you that we have customers and public-facing sites that use it for more than prototyping, and have set up development environments and source code management and continuous deployment environments for it (using tools like what @monator provides, which BTW, is really cool) so they're not "copying and pasting into a text editor" all the time when coding their apps. But it's not for everyone.
I also agree 100% with Emil as far as performance. There is also tooling like Liferay Connected Services or APM tools that can help tuning beyond the easy stuff. Liferay by default requires 2GB of memory, but most production sites require more. Certain things (at least in 6.2) tend to impact memory requirements more than others, for example deploying 100 plugins needs more memory than deploying 1 plugin that does 100 things. Something you can't tune for without knowing exactly what your production characteristics are for.
[Full Disclosure: I work for Liferay and am it's open source community manager]


WIP: Add Unit tests for ProductConverter and Bug Fixes

Adds unit tests for the ProductConverter class.
In addition some yet unreported errors are fixed:

The converter can now process ProductFile properties even if the filename and the propertyname are not identical
Possible NullReferenceExceptions when comparing Products with empty identity properties are prevented now
Fixed NullReferenceExeptions when dealing with empty properties of type IList
Converter does not call the RecipeManagement if now recipes are to be safed
Converter can now handle removed ProductPartLinks in the backwards conversion
Converter can handle ProductPartLinks with empty product properties

I spotted a few things. One more question: Why did you override Equals in the dummies.

In order to simplify the asserts in the tests. Especially the conversion of products would have been tedious to test, as it includes checking all the array properties for value equality in the objects they contain.


fix frezon intoxication

About the PR

Frezon huffing was developed with the slightly bugged metabolism system in mind, before the fix. After it was fixed, frezon provides extremely low ecstasy even on max tank output, 304kpa. I fix it so Frezon now provides standard intoxication just as before. The damage was also adjusted to be similar to the previous cancer it gave.
Why / Balance

bug
Media

Intoxication after a proper 7s huff at 10kpa and 40 kelvin, at which most frezon is made. It is very similar to the past effects.

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

Thank you for your contribution.


fix(types): optimize type to use Dep

Signed-off-by: liuxing<EMAIL_ADDRESS>

Thanks for the PR, but the code in question is kept like that intentionally because the Dep type abstraction doesn't help in that context.


examples/sotest/elf: enable and run sotest/elf simultaneously

Summary
examples/sotest/elf: enable and run sotest/elf simultaneously
Impact
N/A
Testing
Vela

[Experimental Bot, please feedback here]
No, this PR does not meet the NuttX Requirements.
Missing Information:

Summary:

Lacks a clear explanation of why the change is necessary. What problem does enabling and running sotest/elf simultaneously solve?
Does not describe how the change works. What modifications were made to the code to achieve this simultaneous execution?

Impact:

While stating "N/A" might be accurate for some sections, it's crucial to address all impact points. For instance:

Impact on build: Even if the build process itself doesn't change, are there new build dependencies introduced by enabling sotest/elf?
Impact on hardware:  Does running these tests concurrently have any implications for specific hardware configurations?

Testing:

"Vela" is not sufficient testing information. Please provide:

Build Host(s): Specify the operating system, CPU architecture, and compiler used for building the code.
Target(s):  Detail the specific architecture and board configuration where the tests were run (e.g., "sim:qemu-rv32").
Testing logs: Include relevant snippets from the testing logs, both before and after the change, to demonstrate the issue and its resolution.

Recommendation:
Expand the PR description to address the missing information. Provide a clear and concise explanation of the change's purpose, its implementation details, and its potential impact on various aspects of the NuttX ecosystem.  Ensure you include specific details about your testing environment and relevant log excerpts.

build errors..


Can't make docker login to work from within container

I don't know if this is the expected behavior, but if I run docker login from a container from docker image, it tries the following and fails:
$ docker run -ti --rm docker:dind ash
# docker login
Login with your Docker ID to push and pull images from Docker Hub. If you don't have a Docker ID, head over to https://hub.docker.com to create one.
Username: me
Password:
error during connect: Post http://docker:2375/v1.40/auth: dial tcp: lookup docker on <IP_ADDRESS>:53: no such host

As you can see, it tries (unsuccessfully) to connect to host docker and fails. Why? Is it expected?

If you want to using docker:dind, you should using
(MoeLove) ➜  ~ docker run --rm -d --privileged docker:dind
b2e24dbb2f5188f34d6cd751bb26ced922cb6277084773207924449f2ebfbba0
(MoeLove) ➜  ~ docker exec -it $(docker ps -ql) sh
/ # docker login
Login with your Docker ID to push and pull images from Docker Hub. If you don't have a Docker ID, head over to https://hub.docker.com to create one.
Username: taobeier
Password:
WARNING! Your password will be stored unencrypted in /root/.docker/config.json.
Configure a credential helper to remove this warning. See
https://docs.docker.com/engine/reference/commandline/login/#credentials-store

Login Succeeded

As you can see, it tries (unsuccessfully) to connect to host docker and fails. Why?

We will set the DOCKER_HOST env.  So docker CLI will connect to tcp://docker:2375
(MoeLove) ➜  ~ docker run --rm -it docker:dind sh
/ # env |grep DOCKER_HOST
DOCKER_HOST=tcp://docker:2375

Thanks!


ntr:  oscillating nucleus related

inviable elongated mononucleate vegetative cell with oscillating nucleus
(the nucleus oscillates at its normal location)
maybe this should replace:
inviable elongated mononucleate vegetative cell with mislocalized nucleus
note to self:
NES-Alp4C also induced oscillatory movements of normal-sized nuclei in 72% of the cells (n = 65) (Fig. 5C)
(and others)

elongated vegetative cell with oscillating nucleus FYPO:0005002
I wouldn't assume or infer that the nucleus in "inviable elongated mononucleate vegetative cell with mislocalized nucleus" is moving. Especially in an inviable cell, the nucleus could be just staying put in the wrong place. So I'm inclined to leave the two terms separate, and not change the existing annotation.
(note to self: older existing term is FYPO:0002337; newer is FYPO:0004950)

yeah makes sense

edit file: e3d1b713aa95d645445e05c97850f44e29b33b5c
release: 9d851f2dcd57ad8363ea4df4506fc965481b8033


Question add view between items

I have a grid layout with 2 columns and 4 items (total 4), I added a custom view in the index 2, the question is, it is possible that the custom view can stay in the middle of the 4 columns but with full width?
Purpose: the custom view is to have a ADS in the middle.

Legend:
= =
__
= =

=    1- item column
__    1 - ads view
PS The question is more related the UI possible logic, the code for add the custom view is there already, but shows like a column and not a full with column like the goal.

related to the last comment I add this Image as reference:

thanks.

For mobile, the goal image is good. For tablet, it's going to be more similar what you have know, but the ad is centered vertically with the cards in the row.

Solved by have 2 item templates.


Location of the input image in the generated video

Hi, is there a way to control the location of the input image in the generated video? e.g. if it is possible to always make it the first frame? I tried to look at the code and it seems that the input image is replicated 16 times and concatenated along the channel dimension of the noise, and it seems that there is no way to control it. I am wondering if this is the correct understanding. Thank you!

Hi. You understanding is correct. We are studying how to add more controllability.


Poor RemoteApp performance

Description
When connecting to either a Windows 7 or Windows 10 VM, RemoteApp performance is slow and can create a number of graphical artifacts/issues within the application window after resizing.  Also when making application fullscreen it will not want to leave fullscreen at all despite restoring and resizing by grabbing the edge of the application window. I've tried a number of different connection settings, however performance had not significantly improved.
On the other hand, not using RemoteApp works perfectly and I encounter zero issues when using that on it's on.
To Reproduce

Connect to the Windows VM  /app:'outlook'
Resize a window
Move a window
Snap a window to either side of the desktop, or make full screen

Expected behavior
Application windows should move about freely, without graphical issues, and with reasonable performance.
Screenshots
Blurred personal data

** Application details

Version of FreeRDP
freerdp-git 2.0.0.rc4.r659.g4a6b843f1-2

Command line used
xfreerdp /u:user /p:pass /app:'outlook' /cert-ignore /v:<IP_ADDRESS> /bpp:16 /network:modem /compression -themes -wallpaper /clipboard /audio-mode:1 /auto-reconnect -glyph-cache -offscreen-cache /rfx -menu-anims -bitmap-cache

OS version connecting to
Windows 7 / Windows 10

**Desktop **

OS: Arch Linux
Browser N/A
Version N/A

Likely related to #5479 and #5343

@matty-r thx for the references.
Does it work with a more recent build from master?

@matty-r thx for the references.
Does it work with a more recent build from master?

I tried earlier to get a nightly installed, but wasn't able to get it work sorry. I'll try from Master in a few hours and report back.
Thanks

@matty-r also, it is always recommended to add /gfx (or /gfx:avc444 if compiled with h264 support) to utilize modern graphics pipeline (usually less glitches and bandwidth usage ;))

also, you´re using kde/plasma with a single monitor setup? (rails is quite picky regarding window managers and their positioning behaviour)

@matty-r also, it is always recommended to add /gfx (or /gfx:avc444 if compiled with h264 support) to utilize modern graphics pipeline (usually less glitches and bandwidth usage ;))

Ok, will do. Still got to get around to doing that tonight.

also, you´re using kde/plasma with a single monitor setup? (rails is quite picky regarding window managers and their positioning behaviour)

Kinda.. it's a laptop with an external monitor - however the laptop monitor is disabled. With that said, I'm experiencing the same issues on my desktop which is a single monitor setup.

also, you´re using kde/plasma with a single monitor setup? (rails is quite picky regarding window managers and their positioning behaviour)

@akallabeth I was able to build from Master (as below), wasn't 100% sure on the build flags to use. Performance wasn't noticeably better, and maximizing to full screen would result in sporadic behaviour: I noticed that when going to fullscreen and then restoring back down, as soon as it lost focus to another window it would go to fullscreen again.
This is FreeRDP version 2.0.0-dev5 (40463bb2f)
Build configuration: BUILD_TESTING=OFF BUILTIN_CHANNELS=ON HAVE_AIO_H=1 HAVE_EXECINFO_H=1 HAVE_FCNTL_H=1 HAVE_INTTYPES_H=1 HAVE_JOURNALD_H=TRUE HAVE_MATH_C99_LONG_DOUBLE=1 HAVE_POLL_H=1 HAVE_PTHREAD_MUTEX_TIMEDLOCK=ON HAVE_PTHREAD_MUTEX_TIMEDLOCK_LIB=1 HAVE_PTHREAD_MUTEX_TIMEDLOCK_SYMBOL= HAVE_SYSLOG_H=1 HAVE_SYS_EVENTFD_H=1 HAVE_SYS_FILIO_H= HAVE_SYS_MODEM_H= HAVE_SYS_SELECT_H=1 HAVE_SYS_SOCKIO_H= HAVE_SYS_STRTIO_H= HAVE_SYS_TIMERFD_H=1 HAVE_TM_GMTOFF=1 HAVE_UNISTD_H=1 HAVE_XI_TOUCH_CLASS=1 WITH_ALSA=ON WITH_CAIRO=OFF WITH_CCACHE=ON WITH_CHANNELS=ON WITH_CLANG_FORMAT=ON WITH_CLIENT=ON WITH_CLIENT_AVAILABLE=1 WITH_CLIENT_CHANNELS=ON WITH_CLIENT_CHANNELS_AVAILABLE=1 WITH_CLIENT_COMMON=ON WITH_CLIENT_INTERFACE=OFF WITH_CUPS=ON WITH_DEBUG_ALL=OFF WITH_DEBUG_CAPABILITIES=OFF WITH_DEBUG_CERTIFICATE=OFF WITH_DEBUG_CHANNELS=OFF WITH_DEBUG_CLIPRDR=OFF WITH_DEBUG_DVC=OFF WITH_DEBUG_KBD=OFF WITH_DEBUG_LICENSE=OFF WITH_DEBUG_MUTEX=OFF WITH_DEBUG_NEGO=OFF WITH_DEBUG_NLA=OFF WITH_DEBUG_NTLM=OFF WITH_DEBUG_RAIL=OFF WITH_DEBUG_RDP=OFF WITH_DEBUG_RDPDR=OFF WITH_DEBUG_RDPEI=OFF WITH_DEBUG_RDPGFX=OFF WITH_DEBUG_REDIR=OFF WITH_DEBUG_RFX=OFF WITH_DEBUG_RINGBUFFER=OFF WITH_DEBUG_SCARD=OFF WITH_DEBUG_SND=OFF WITH_DEBUG_SVC=OFF WITH_DEBUG_SYMBOLS=OFF WITH_DEBUG_THREADS=OFF WITH_DEBUG_TIMEZONE=OFF WITH_DEBUG_TRANSPORT=OFF WITH_DEBUG_TSG=OFF WITH_DEBUG_TSMF=OFF WITH_DEBUG_WND=OFF WITH_DEBUG_X11=OFF WITH_DEBUG_X11_CLIPRDR=OFF WITH_DEBUG_X11_LOCAL_MOVESIZE=OFF WITH_DEBUG_XV=OFF WITH_DSP_EXPERIMENTAL=OFF WITH_DSP_FFMPEG=ON WITH_EVENTFD_READ_WRITE=1 WITH_FAAC=ON WITH_FAAD2=ON WITH_FFMPEG=TRUE WITH_FFMPEG=TRUE WITH_GFX_H264=ON WITH_GPROF=OFF WITH_GSM=ON WITH_GSSAPI=OFF WITH_GSTREAMER_0_10=OFF WITH_GSTREAMER_1_0=ON WITH_ICU=OFF WITH_IPP=OFF WITH_JPEG=OFF WITH_LAME=OFF WITH_LIBRARY_VERSIONING=ON WITH_LIBSYSTEMD=ON WITH_MACAUDIO=OFF WITH_MACAUDIO=OFF WITH_MACAUDIO_AVAILABLE=0 WITH_MANPAGES=ON WITH_MBEDTLS=OFF WITH_OPENH264=TRUE WITH_OPENH264=TRUE WITH_OPENH264_LOADING=OFF WITH_OPENSLES=OFF WITH_OPENSSL=ON WITH_OSS=ON WITH_PCSC=OFF WITH_PROFILER=OFF WITH_PULSE=ON WITH_SAMPLE=OFF WITH_SANITIZE_ADDRESS=OFF WITH_SANITIZE_ADDRESS_AVAILABLE=1 WITH_SANITIZE_MEMORY=OFF WITH_SANITIZE_MEMORY_AVAILABLE=1 WITH_SANITIZE_THREAD=OFF WITH_SANITIZE_THREAD_AVAILABLE=1 WITH_SERVER=OFF WITH_SERVER_INTERFACE=ON WITH_SMARTCARD_INSPECT=OFF WITH_SOXR=OFF WITH_SSE2=ON WITH_SWSCALE=OFF WITH_THIRD_PARTY=OFF WITH_VALGRIND_MEMCHECK=OFF WITH_VALGRIND_MEMCHECK_AVAILABLE=1 WITH_WAYLAND=ON WITH_WINPR_TOOLS=ON WITH_X11=ON WITH_X264=OFF WITH_XCURSOR=ON WITH_XEXT=ON WITH_XFIXES=ON WITH_XI=ON WITH_XINERAMA=ON WITH_XKBFILE=ON WITH_XRANDR=ON WITH_XRENDER=ON WITH_XSHM=ON WITH_XV=ON WITH_ZLIB=ON
Build type:          Release
CFLAGS:               -fPIC -Wall -Wno-unused-result -Wno-unused-but-set-variable -Wno-deprecated-declarations -fvisibility=hidden -Wimplicit-function-declaration -Wredundant-decls -DWINPR_DLL
Compiler:            GNU, 9.2.0

@akallabeth I built from the nightly "amd64,buster,pkg-deb #718" on Ubuntu Mate and I had the same, if not worse experience than before.

Debian built package on ubuntu? Sorry, I just don't understand what you mean :/
As for 'worse' could you describe that? Easier to fix if we know what to look for ;)
Most rail issues are caused by local interaction with the window manager creating unwanted feedback loops, so some details on that might also help.

@matty-r what do you mean with 'I built from the nightly "amd64,buster,pkg-deb #718" '?
Debian built package on ubuntu? Sorry, I just don't understand what you mean :/
As for 'worse' could you describe that? Easier to fix if we know what to look for ;)
Most rail issues are caused by local interaction with the window manager creating unwanted feedback loops, so some details on that might also help.

 What debug commands can I run that would be useful for you?

@matty-r ok, then better use https://github.com/FreeRDP/FreeRDP/wiki/PreBuilds and the correct distro name
As for commands, just run your session (with /log-level:debug, 2>&1 |tee log.txt the output and record the session with a screen recorder so that the stuff that is wrong can be seen and we have a corresponding log.

@matty-r ok, then better use https://github.com/FreeRDP/FreeRDP/wiki/PreBuilds and the correct distro name
As for commands, just run your session (with /log-level:debug, 2>&1 |tee log.txt the output and record the session with a screen recorder so that the stuff that is wrong can be seen and we have a corresponding log.

Sweet, I'll get that for you tonight then.

@akallabeth
Log file and screen capture below:
log.txt
Screen Capture

@matty-r might I ask for your command line? Looks like you still do not use /rfx /gfx and with the old win xp age protocol that remains slowness is expected ;)

@matty-r might I ask for your command line? Looks like you still do not use /rfx /gfx and with the old win xp age protocol that remains slowness is expected ;)

Sorry, I forgot to include that. I saw this same behavior even with Windows 10.
 xfreerdp /u:matt /p:password /app:'outlook' /cert-ignore /v:<IP_ADDRESS> /gfx:avc444 /log-level:debug 2>&1 |tee log.txt
I also compiled with (Maybe there is something else I should add):
cmake -GNinja -DCHANNEL_URBDRC=ON -DWITH_DSP_FFMPEG=ON -DWITH_CUPS=ON -DWITH_PULSE=ON -DWITH_FAAC=ON -DWITH_FAAD2=ON -DWITH_GSM=ON .

@matty-r ok, so we are talking about a coordinate mapping issue here (windows do not match contents offsets correctly, mouse clicks are strangely off, ...) right?

@akallabeth Sounds about right - it all turns into a mess after going fullscreen. My resolution on that display is 3440 x 1440.

i also have the same problem as this, with the debian os remote apps autocad on windows 8


ionic cordova:run android throws an error "Failure [INSTALL_FAILED_VERSION_DOWNGRADE]"

I am unable to perform ionic cordova:run android on a brand new project when using the new v3 cli
My system set up is as follows:
Cordova CLI: 6.4.0
Ionic Framework Version: 2.2.0
Ionic CLI Version: 3.0.0-beta.4
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Windows 10
Node Version: v7.5.0
Xcode version: Not installed

And the steps to reproduce are as simple as so:

C:\git> ionic start blank my-new-project --v2
C:\git> cd my-new-project
C:\git\my-new-project> ionic cordova:platform add android
C:\git\my-new-project> ionic cordova:run android

The output I recieve is:

Running app-scripts build: --address <IP_ADDRESS> --port 8100 --p 8100 --livereload-port 35729 --r 35729 --iscordovaserve --nobrowser
[05:56:34]  build dev started ...
[05:56:34]  clean started ...
[05:56:34]  clean finished in less than 1 ms
[05:56:34]  copy started ...
[05:56:34]  transpile started ...
[05:56:39]  transpile finished in 4.71 s
[05:56:39]  preprocess started ...
[05:56:39]  preprocess finished in less than 1 ms
[05:56:39]  webpack started ...
[05:56:39]  copy finished in 5.08 s
[05:56:50]  webpack finished in 10.54 s
[05:56:50]  sass started ...
[05:56:51]  sass finished in 1.04 s
[05:56:51]  postprocess started ...
[05:56:51]  postprocess finished in less than 1 ms
[05:56:51]  lint started ...
[05:56:51]  build dev finished in 16.35 s
✔ Starting build - done!
| Executing cordova command: cordova run android [05:56:57]  lint finished in 6.17 s
| Executing cordova command: cordova run android [ERROR] An error occurred while running the above command (exit code 1):

        Note: Some input files use or override a deprecated API.
        Note: Recompile with -Xlint:deprecation for details.
        Note: C:\git\my-new-project\platforms\android\src\org\apache\cordova\splashscreen\SplashScreen.java uses or overrides a deprecated API.
        Note: Recompile with -Xlint:deprecation for details.
        Error: Failed to install apk to device:
        [  1%] /data/local/tmp/android-debug.apk
        [  2%] /data/local/tmp/android-debug.apk
        ...
        [ 98%] /data/local/tmp/android-debug.apk
        [100%] /data/local/tmp/android-debug.apk
                pkg: /data/local/tmp/android-debug.apk
        Failure [INSTALL_FAILED_VERSION_DOWNGRADE]

        You're trying to install apk with a lower versionCode that is already installed.
        Either uninstall an app or increment the versionCode.

Even if i try and run ionic cordova:build android and install the apk on my device it won't install giving a message "X App not installed"

Can you try running cordova build android directly and provide the output?

spawn EACCES


OpenHarmony support

I am developing an OpenHarmony application by JavaScript language which used your library, will your library support OpenHarmony platform by JavaScript language?If so, I want to contribute to the OpenHarmony build of this library.Expecte for your reply!

Hi @Mr-zhao-dy, I apologize, but currently, we do not have any plans to support OpenHarmony.


The dash char - can not be displayed correctly in Wiki title.

Gitea: 1.16-dev
Demo: https://try.gitea.io/wxiaoguang/test/wiki/2022-01-17-test
The title I inputed was 2022-01-17 test, but on the page, it only shows:

I guess this mechanism was used for spaces between words, like "this is a title" <=> "this-is-a-title", but it is a dirty hack and doesn't work for the cases where a dash is required.

Dup of

https://github.com/go-gitea/gitea/issues/18300

Dup of

https://github.com/go-gitea/gitea/issues/7570


ARROW-11260: [C++][Dataset] Don't require dictionaries when specifying explicit partition schema

The API here is a little different than before, but this allows you to give a partition schema with dictionary fields, without having to fill in the dictionaries themselves. I opted to do this as part of the factory to avoid having to let partitionings be 'half constructed', and because the factory has the necessary logic already. As a bonus, this also lets you now check the inferred and actual types against each other.
I also fixed a bug when using non-int32 dictionary indices: a cast was missing.

I tried updating ds.partitioning() to give a PartitioningFactory when a schema (but not dictionaries) is given, but that breaks things (e.g. writers expecting ds.partitioning() to give a Partitioning still)…how about a separate flag?

What you currently pushed here breaks other tests?
Maybe we could also check if the schema has any dictionary type?

What you currently pushed here breaks other tests?

Yup, I realized that right after I pushed.

Maybe we could also check if the schema has any dictionary type?

We could; we'd have to do that recursively, right? In case of a nested dictionary. (…though is that handled anyways?) It also doesn't help the fact that we need a Partitioning, not a PartitioningFactory, when we want to write data, so the auto-detection might be a little too magical…

We could; we'd have to do that recursively, right? In case of a nested dictionary. (…though is that handled anyways?)

I don't think we can parse nested types from the file paths?
In that case, we wouldn't need to check it recursively.
From a user point of view, having to specify dictionaries="infer" feels superfluous, as it is clear that's needed (but to be clear, this PR is already a nice improvement compared to the current situation! ;))

It also doesn't help the fact that we need a Partitioning, not a PartitioningFactory, when we want to write data, so the auto-detection might be a little too magical…

Hmm, yes, that complicates things. When writing, you don't need to specify the dictionaries. But indeed you still need the actual Partitioning and not the factory. So returning the factory if the schemas has a dictionary type and no dictionaries are passed, would then fail when writing ..
The current API mixing both for reading/writing and the full object / the factory makes it a bit complex ..

We could also split out read_partitioning and write_partitioning functions, perhaps, or add a similar flag, and accept the API break.

I think the current PR (with the dictionary="infer") is already a clear, strict improvement over the situation in master, so that's fine for me.
(having to split in a reading/writing partitioning object is also not very nice)

+1, merging


scaling issues due to prolog tagging api

We got into scaling issue with the tagging in prolog script
I understand the prolog is ran at every step and when many nodes are involved the job fails with timeouts
we need to find another place to do the tagging and I understand that the comment is job related but some other tags can be done only once when the instances are created, either because of the min value in the configuration or created by slurm
I am looking at places where this could be done.
maybe it can be done at the headnode instead in the PrologSlurmctld https://slurm.schedmd.com/prolog_epilog.html

some comment on this topic from slurm support team
Considering the nature of this command in that it needs to run in parallel but async from the other prologs/epilogs. I think a SPANK plugin would fit better than a PREP plugin and avoid the need to write any non-trivial code.
For instance, this is a popular plugin to use lua with SPANK:

https://github.com/stanford-rc/slurm-spank-lua

I think the slurm_spank_init_post_opt() is likely the function to call the tagging command.

looking more closely I notice the loop in the prolog script. the prolog script runs on every compute node and at every step execution and

RPC calls to the headnode (with scontrol) is discouraged
tagging all nodes from every node is making the problem exponential (n ^ 2)

I think we can still keep this in the prolog, find own instance ID with curl and make the node tag itself with a single call. there will be only n calls to the tagging API
not perfect like async tagging but much better anyway I think

I changed the prolog script to PrologSlurmctld and any job larger than 30 nodes crashes
Then I tried this approach inside the prolog.sh
host=$(curl http://<IP_ADDRESS>/latest/meta-data/instance-id)
aws ec2 create-tags --region $cfn_region --resources ${host} --tags Key=aws-parallelcluster-username,Value=${SLURM_JOB_USER} Key=aws-parallelcluster-jobid,Value=${SLURM_JOBID} Key=aws-parallelcluster-partition,Value=${SLURM_JOB_PARTITION}

This works for 40 nodes, will test with larger jobs too. But could not find a way to transport the comments yet


Topic tagging filtering

Linked delivery tickets

#17

Topic tags can now be filtered
See
https://data.youthfuturesfoundation.org/topics/


Version 0.3.1

Description

Update error codes

          2 Warnings

:warning:
The Pull Request summary does not contain the commit message convention

:warning:
The Pull Request title does not follow the convention [ACCSEC-0000] PR Title text

  Generated by :no_entry_sign: Danger

          2 Warnings

:warning:
The Pull Request summary does not contain the commit message convention

:warning:
The Pull Request title does not follow the convention [ACCSEC-0000] PR Title text

  Generated by :no_entry_sign: Danger

          2 Warnings

:warning:
The Pull Request summary does not contain the commit message convention

:warning:
The Pull Request title does not follow the convention [ACCSEC-0000] PR Title text

  Generated by :no_entry_sign: Danger

          2 Warnings

:warning:
The Pull Request summary does not contain the commit message convention

:warning:
The Pull Request title does not follow the convention [ACCSEC-0000] PR Title text

  Generated by :no_entry_sign: Danger

          2 Warnings

:warning:
The Pull Request summary does not contain the commit message convention

:warning:
The Pull Request title does not follow the convention [ACCSEC-0000] PR Title text

  Generated by :no_entry_sign: Danger

          3 Warnings

:warning:
Big PR

:warning:
The Pull Request summary does not contain the commit message convention

:warning:
The Pull Request title does not follow the convention [ACCSEC-0000] PR Title text

  Generated by :no_entry_sign: Danger

          3 Warnings

:warning:
Big PR

:warning:
The Pull Request summary does not contain the commit message convention

:warning:
The Pull Request title does not follow the convention [ACCSEC-0000] PR Title text

  Generated by :no_entry_sign: Danger


Extensions Viewlet Search box now has a little inner padding around the text

Issue Type: Bug
Compared to input boxes in other viewlets, the search box in the extensions viewlets looks slightly different with a little padding of a different color inside the box.
VS Code version: Code - Insiders 1.27.0-insider (ffa660576d3a8da3f6cf9b94cbfb879632688ebd, 2018-08-15T05:19:24.200Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2112)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
15.93GB (7.27GB free)

Process Argv
C:\Users\stbatt\AppData\Local\Programs\Microsoft VS Code Insiders\Code - Insiders.exe

Screen Reader
no

VM
0%

This appears to be because the Material Theme Lighter Higher Contrast sets the background color to a transparent color (rgba(0,0,0,0.2)), if that is changed to rgb(250,250,250), the look is the same but without the border. This seems like incorrect behavior of the renderer, as the type of color shouldn't affect what gets colored.

Actually, looks like the transparency is showing up differently on the different backgrounds. If you increase the alpha, it starts to look like this:

I'll look in to making the transparency affect both equally


show Debug Level

// Show debug level
void RemoteDebug::showDebugLevel(boolean show) {
_showProfiler = show;
}
--> _showDebugLevel

Hi
Sorry for the delay.
Thanks for you to see this bug.
I Fix it in 1.0.0 version
Regards.
Joao


CUDA: Alignment mismatch between emulated and native vector types causes hard to debug errors

It seems that CUDA's ::float2 has an alignment of 8, while hipSYCL's emulated_vector, which is used on the host, has an alignment of 4. Obviously that's not good, and causes some very weird looking and hard to debug problems - see below. I'll mostly just dump the repro case here as I think it's quite self-explanatory:
#include <CL/sycl.hpp>

namespace sycl = cl::sycl;

namespace foosycl {

struct emulated_float2 { float x; float y; };

// Fix:
// struct alignas(8) emulated_float2 { float x; float y; };
//
// #ifdef SYCL_DEVICE_ONLY
// static_assert(alignof(emulated_float2) == alignof(::float2));
// #endif

struct float2 {
  HIPSYCL_UNIVERSAL_TARGET
  float2(const float& x, const float& y) { data.x = x; data.y = y; }
  HIPSYCL_UNIVERSAL_TARGET float& x() { return data.x; }
  HIPSYCL_UNIVERSAL_TARGET float x() const { return data.x; }
  HIPSYCL_UNIVERSAL_TARGET float& y() { return data.y; }
  HIPSYCL_UNIVERSAL_TARGET float y() const { return data.y; }

#ifdef SYCL_DEVICE_ONLY
  ::float2 data;
#else
  emulated_float2 data;
#endif
};

}

int main(int argc, char* argv[]) {
    sycl::queue queue;

    //using float2_t = sycl::float2;
    using float2_t = foosycl::float2;

    float2_t vec = {42.f, 1337.f};

    printf("vec on host: %f,%f\n", vec.x(), vec.y());

    queue.submit([&](sycl::handler& cgh) {
        cgh.single_task<class buggy>([=, a = 9.f]() {
            printf("a in buggy kernel: %f\n", a);
            printf("vec in buggy kernel: %f,%f\n", vec.x(), vec.y());
        });
    });

    queue.submit([&](sycl::handler& cgh) {
        cgh.single_task<class worky>([=]() {
            printf("vec in worky kernel: %f,%f\n", vec.x(), vec.y());

            printf("sizeof(::float2) = %lu\n", sizeof(::float2));
            printf("sizeof(emulated_float2) = %lu\n", sizeof(foosycl::emulated_float2));
            printf("alignof(::float2) = %lu\n", alignof(::float2));
            printf("alignof(emulated_float2) = %lu\n", alignof(foosycl::emulated_float2));
        });

    queue.wait_and_throw();

    return EXIT_FAILURE;
}

I'm using foosycl::float2 and foosycl::emulated_float2 here, but these are just the result of reducing about 5000 lines of hipSYCL headers down to their essence. You can switch float2_t to sycl::float2 to see that this error is reproducible with the original type as well.
As suggested in the code, a potential fix could be to set the alignment explicitly (this may need adjustment per backend), and to assert that the alignments (as well as the size) match during device compilation.

Ah, I should probably give you the output as well ;-)
vec on host: 42.000000,1337.000000
a in buggy kernel: 9.000000
vec in buggy kernel: 1337.000000,0.000000
vec in worky kernel: 42.000000,1337.000000
sizeof(::float2) = 8
sizeof(emulated_float2) = 8
alignof(::float2) = 8
alignof(emulated_float2) = 4

Ah, the vec class, the most ridiculously complex class in all of the SYCL interface :)
I think is fallout from the recent changes that we had to make to have both CPU and CUDA/HIP backends available simultaneously. Previously, there was only one backend active at any given time, so this sort of issue never occured.
As a hotfix, I think we should just alignas the emulated_vector here: https://github.com/illuhad/hipSYCL/blob/5216d091cf92a3ef4cc119805f484b5c9720be7f/include/hipSYCL/sycl/libkernel/detail/vec.hpp#L81
In the long term, we should probably refactor the vec class somewhat to better account for the multi-backend architecture that we now effectively have. Additionally, that class was written in C++14 and could probably be simplified in a lot of places using C++17 - so it definitely needs some love anyway.