[Ansible] Updated the kubernetes addons

This PR contains the following changes for the Ansible deployment:

Updated the kubernetes addons
Added node-problem-detector addon

Please let me know if there is anything I can improve in the PR.

This change is

Review status: 0 of 21 files reviewed at latest revision, 8 unresolved discussions, some commit checks failed.

ansible/roles/kubernetes-addons/templates/cluster-logging/es-controller.yaml.j2, line 44 at r1 (raw file):

      - name: es-persistent-storage
        emptyDir: {}
      securityContext:

The securityContext should go back. It is the latest change that allows selinux to be in enforcing mode on all nodes.

ansible/roles/kubernetes-addons/templates/cluster-logging/fluentd-es-ds.yaml.j2, line 45 at r1 (raw file):

        hostPath:
          path: /var/lib/docker/containers
      securityContext:

The securityContext should go back. It is the latest change that allows selinux to be in enforcing mode on all nodes.

ansible/roles/kubernetes-addons/templates/cluster-logging/kibana-controller.yaml.j2, line 38 at r1 (raw file):

          name: ui
          protocol: TCP
      securityContext:

The securityContext should go back. It is the latest change that allows selinux to be in enforcing mode on all nodes.

ansible/roles/kubernetes-addons/templates/cluster-monitoring/heapster-controller.yaml.j2, line 109 at r1 (raw file):

            - --container=eventer
            - --poll-period=300000
      securityContext:

The securityContext should go back. It is the latest change that allows selinux to be in enforcing mode on all nodes.

ansible/roles/kubernetes-addons/templates/cluster-monitoring/influxdb-grafana-controller.yaml.j2, line 74 at r1 (raw file):

      - name: grafana-persistent-storage
        emptyDir: {}
      securityContext:

The securityContext should go back. It is the latest change that allows selinux to be in enforcing mode on all nodes.>

ansible/roles/kubernetes-addons/templates/dns/skydns-rc.yaml.j2, line 130 at r1 (raw file):

        emptyDir: {}
      dnsPolicy: Default  # Don't use cluster DNS.
      securityContext:

The securityContext should go back. It is the latest change that allows selinux to be in enforcing mode on all nodes.

ansible/roles/kubernetes-addons/templates/kube-dash/kube-dash-rc.yaml.j2, line 40 at r1 (raw file):

            hostPath:
              path: "/etc/ssl/certs"
    securityContext:

The securityContext should go back. It is the latest change that allows selinux to be in enforcing mode on all nodes.

ansible/roles/kubernetes-addons/templates/kube-ui/dashboard-controller.yaml.j2, line 42 at r1 (raw file):

          initialDelaySeconds: 30
          timeoutSeconds: 30
    securityContext:

The securityContext should go back. It is the latest change that allows selinux to be in enforcing mode on all nodes.

Comments from Reviewable

@jasonbrooks can you check the updated addons with atomic as well? This should not work with selinux on or am I something missing here? Thanks

I added the securityContext back to all addons.

Review status: 0 of 20 files reviewed at latest revision, 8 unresolved discussions.

ansible/roles/kubernetes-addons/templates/cluster-logging/es-controller.yaml.j2, line 44 at r1 (raw file):
Previously, ingvagabund (Jan Chaloupka) wrote…
The securityContext should go back. It is the latest change that allows selinux to be in enforcing mode on all nodes.

Done.

ansible/roles/kubernetes-addons/templates/cluster-logging/fluentd-es-ds.yaml.j2, line 45 at r1 (raw file):
Previously, ingvagabund (Jan Chaloupka) wrote…
The securityContext should go back. It is the latest change that allows selinux to be in enforcing mode on all nodes.

Done.

ansible/roles/kubernetes-addons/templates/cluster-logging/kibana-controller.yaml.j2, line 38 at r1 (raw file):
Previously, ingvagabund (Jan Chaloupka) wrote…
The securityContext should go back. It is the latest change that allows selinux to be in enforcing mode on all nodes.

Done.

ansible/roles/kubernetes-addons/templates/cluster-monitoring/heapster-controller.yaml.j2, line 109 at r1 (raw file):
Previously, ingvagabund (Jan Chaloupka) wrote…
The securityContext should go back. It is the latest change that allows selinux to be in enforcing mode on all nodes.

Done.

ansible/roles/kubernetes-addons/templates/cluster-monitoring/influxdb-grafana-controller.yaml.j2, line 74 at r1 (raw file):
Previously, ingvagabund (Jan Chaloupka) wrote…
The securityContext should go back. It is the latest change that allows selinux to be in enforcing mode on all nodes.>

Done.

ansible/roles/kubernetes-addons/templates/dns/skydns-rc.yaml.j2, line 130 at r1 (raw file):
Previously, ingvagabund (Jan Chaloupka) wrote…
The securityContext should go back. It is the latest change that allows selinux to be in enforcing mode on all nodes.

Done.

ansible/roles/kubernetes-addons/templates/kube-dash/kube-dash-rc.yaml.j2, line 40 at r1 (raw file):
Previously, ingvagabund (Jan Chaloupka) wrote…
The securityContext should go back. It is the latest change that allows selinux to be in enforcing mode on all nodes.

Done.

ansible/roles/kubernetes-addons/templates/kube-ui/dashboard-controller.yaml.j2, line 42 at r1 (raw file):
Previously, ingvagabund (Jan Chaloupka) wrote…
The securityContext should go back. It is the latest change that allows selinux to be in enforcing mode on all nodes.

Done.

Comments from Reviewable

@redhat-k8s-bot test please

TASK [kubernetes-addons : MONITORING | Install heapster template] **************
changed: [<IP_ADDRESS>] => (item=grafana-service.yaml)
failed: [<IP_ADDRESS>] (item=heapster-controller.yaml) => {"failed": true, "item": "heapster-controller.yaml", "msg": "AnsibleUndefinedVariable: 'metrics_cpu' is undefined"}
changed: [<IP_ADDRESS>] => (item=heapster-service.yaml)
changed: [<IP_ADDRESS>] => (item=influxdb-grafana-controller.yaml)
changed: [<IP_ADDRESS>] => (item=influxdb-service.yaml)

Not sure if metrics_cpu is the only variable that is not defined.

I forgot to add the memory and cpu calculations from the original template to the default/main.yml. Added now.

@redhat-k8s-bot test please

Sorry about the new failure, it is fixed.
I used my custom config for testing and forget it was still there.

@redhat-k8s-bot test please

I rebased on latest master. The securityContext has been fixed too.
Is there anything else that needs to be changed?

@redhat-k8s-bot test please

The fail is not related to my changes.
fatal: [<IP_ADDRESS>]: FAILED! => {"changed": false, "failed": true, "module_stderr": "Shared connection to <IP_ADDRESS> closed.\r\n", "module_stdout": "Traceback (most recent call last):\r\n  File \"/tmp/ansible_bda1M3/ansible_module_dnf.py\", line 436, in <module>\r\n    main()\r\n  File \"/tmp/ansible_bda1M3/ansible_module_dnf.py\", line 430, in main\r\n    ensure(module, base, params['state'], params['name'])\r\n  File \"/tmp/ansible_bda1M3/ansible_module_dnf.py\", line 381, in ensure\r\n    base.download_packages(base.transaction.install_set)\r\n  File \"/usr/lib/python2.7/site-packages/dnf/base.py\", line 880, in download_packages\r\n    raise dnf.exceptions.DownloadError(errors.irrecoverable)\r\ndnf.exceptions.DownloadError: Curl error (52): Server returned nothing (no headers, no data) for https://mirrors.fedoraproject.org/metalink?repo=fedora-24&arch=x86_64 [Empty reply from server]\r\n", "msg": "MODULE FAILURE"}

Yeah, fedora repos are making a trouble. Re-running again. Both RHEL and CentOS are fine with the change.
I don't see any reason why this could not be merged.

Please note that I only did a rebase again with the latest push.

@redhat-k8s-bot test please

Reviewed 10 of 21 files at r1, 1 of 10 files at r2, 1 of 1 files at r3, 9 of 9 files at r4, 1 of 1 files at r5.
Review status: all files reviewed at latest revision, 11 unresolved discussions, some commit checks failed.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

Comments from Reviewable

@ingvagabund can you try writing /approve.  It should get approved/merged

/approve

@grodrigues3 thanks for that


What should new contributors work on?

Hi @Dovizu. I saw your post on Reddit r/webdev.
What particular areas or features are you looking for new contributors to work on? Would you recommend taking existing tasks from the project's issues or looking for new things to add?
How would you recommend familiarizing one's self with the existing code base and the existing code structure? What are some places to look at for commonly used/referenced parts of the code?
Thanks in advance!

Additionally, is there any particular discussion area (like an IRC channel or a mailing list), or should discussions take place on Github issues?

Hello mingp:
I recommend improving on existing features for now and then discuss together what we should add. I have some goals for the project that I'd like to share with all contributors. That leads to another task: writing the wiki/documentation.
The codebase currently is simple and structured, most of the functionalities of the site are properly abstracted away using popular gems (Pundit for authorization policies, Devise for authentication, etc.), and I follow a fairy strict REST way of using models (both AR and non-AR). I'd look into app/ folder and route to understand the big picture.
I'm new to running open source projects as well so if you have experience in this field, feel free to suggest what we should do as well.
Currently, the to-do looks like this:

Gather interested contributors and set up a chat group
Discuss how we'd build and contribute, long term goals
Set up documentation and sprints

As of now I'm doing number one, could you help me with that?


Reverting temporary shuttering changes and MA changes

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please


Russound RIO error message / stops working until HA restart

Home Assistant release (hass --version):
0.51.2 in Synology Docker from home-assistant/home-assistant:0.51.2
Component/platform:
Russound RIO
Description of problem:
Error messages in log show up, then all interaction with cards are non-functional until HA restart
Problem-relevant configuration.yaml entries and steps to reproduce:
media_player:
  - platform: russound_rio
    host: <IP_ADDRESS>
    name: Russound

Additional info:
Log entries:
2017-08-15 07:51:06 ERROR (MainThread) [russound] Unhandled exception in IO loop
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/russound_rio/rio.py", line 166, in _ioloop
    response = net_future.result()
  File "/usr/local/lib/python3.6/asyncio/futures.py", line 245, in result
    raise self._exception
  File "/usr/local/lib/python3.6/asyncio/tasks.py", line 182, in _step
    result = coro.throw(exc)
  File "/usr/local/lib/python3.6/asyncio/streams.py", line 482, in readline
    line = yield from self.readuntil(sep)
  File "/usr/local/lib/python3.6/asyncio/streams.py", line 575, in readuntil
    yield from self._wait_for_data('readuntil')
  File "/usr/local/lib/python3.6/asyncio/streams.py", line 458, in _wait_for_data
    yield from self._waiter
  File "/usr/local/lib/python3.6/asyncio/futures.py", line 332, in __iter__
    yield self  # This tells Task to wait for completion.
  File "/usr/local/lib/python3.6/asyncio/tasks.py", line 250, in _wakeup
    future.result()
  File "/usr/local/lib/python3.6/asyncio/futures.py", line 245, in result
    raise self._exception

and then later in the log
2017-08-18 04:26:41 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/asyncio/tasks.py", line 180, in _step
    result = coro.send(None)
  File "/usr/local/lib/python3.6/site-packages/russound_rio/rio.py", line 261, in close
    yield from self._ioloop_future
  File "/usr/local/lib/python3.6/asyncio/futures.py", line 334, in __iter__
    return self.result()  # May raise too.
  File "/usr/local/lib/python3.6/asyncio/futures.py", line 245, in result
    raise self._exception
  File "/usr/local/lib/python3.6/asyncio/tasks.py", line 180, in _step
    result = coro.send(None)
  File "/usr/local/lib/python3.6/site-packages/russound_rio/rio.py", line 166, in _ioloop
    response = net_future.result()
  File "/usr/local/lib/python3.6/asyncio/futures.py", line 245, in result
    raise self._exception
  File "/usr/local/lib/python3.6/asyncio/tasks.py", line 182, in _step
    result = coro.throw(exc)
  File "/usr/local/lib/python3.6/asyncio/streams.py", line 482, in readline
    line = yield from self.readuntil(sep)
  File "/usr/local/lib/python3.6/asyncio/streams.py", line 575, in readuntil
    yield from self._wait_for_data('readuntil')
  File "/usr/local/lib/python3.6/asyncio/streams.py", line 458, in _wait_for_data
    yield from self._waiter
  File "/usr/local/lib/python3.6/asyncio/futures.py", line 332, in __iter__
    yield self  # This tells Task to wait for completion.
  File "/usr/local/lib/python3.6/asyncio/tasks.py", line 250, in _wakeup
    future.result()
  File "/usr/local/lib/python3.6/asyncio/futures.py", line 245, in result
    raise self._exception
ConnectionResetError: [Errno 104] Connection reset by peer

This broke for me in 56.1 too but is working again now in 0.57.1


n-upload before-upload file parameter object not reactive

TuSimple/naive-ui version (版本)
2.15.4
Vue version (Vue 版本)
3.1.4
Browser and its version (浏览器及其版本)
chrome
System and its version (系统及其版本)
win 10
Node version (Node 版本)
Reappearance link (重现链接)
https://codesandbox.io/s/green-rain-fvnfm
Reappearance steps (重现步骤)
try to use the percentage from the file param in before-upload event from n-upload
Expected results (期望的结果)
the percentage is updated when uploading
Actual results (实际的结果)
the percentage is not updated when uploading
Remarks (补充说明)
change event works

This is the expected behavior. If you need to controlled the percentage, you need to use controlled mode.


 Please review.

Comparison is base (834c3fb) 80.92% compared to head (276ca42) 80.93%.

:exclamation: Current head 276ca42 differs from pull request most recent head bab9588. Consider uploading reports for the commit bab9588 to get more accurate results

Files
Patch %
Lines

crates/wasmi/src/engine/regmach/executor/instrs.rs
50.00%
1 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #806   +/-   ##
=======================================
  Coverage   80.92%   80.93%
=======================================
  Files         274      274
  Lines       25364    25366    +2
=======================================
+ Hits        20527    20529    +2
  Misses       4837     4837

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Convert solace object classes to be Plugins

In order to support customisable provisioning of various solace objects, we need to port over the existing items to the new pluggable architecture.

SolaceACLProfile
SolaceBridge ( perhaps? )

All Done


[REFACTOR] Hoverable Component

Details

Fixed Issues

$
PROPOSAL:
Tests

[ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[ ] I linked the correct issue in the ### Fixed Issues section above
[ ] I wrote clear testing steps that cover the changes made in this PR

[ ] I added steps for local testing in the Tests section
[ ] I added steps for the expected offline behavior in the Offline steps section
[ ] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[ ] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] I verified that if a function's arguments changed that all usages have also been updated correctly
[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

TODO:

[ ] Debate if we need both onHover* and onMouse* components
[ ] Check if issue with hover state in Pressable is fixed
[ ] Add missing comments
[ ] Check if we can in any way streamline the scrolling behaviour

Check if issue with hover state in Pressable is fixed

There is no feature that would solve the issue, so we will stick to current Hoverable solution

According to discussion held on Slack, we decided to refactor rest of the functionality after the upgrade to new arch.

Hi @mountiny, I think Melvin did not mention anyone - is it due to the fact that no actual GH issue is linked (just Slack discussion)? Thanks for help! 👍

@cubuspl42 Can you please give this one a good test on various platforms? thanks!

Left some comments

Thank you for thorough review! ❤
If you could look at the implemented changes related to your comments 👍

Hi @cubuspl42 👋
Let me know if we are ready to move forward 👍

Looks pretty good, just had a few questions. The main thing is I don't understand why we need to do hijackRef and useImperativeRef instead of forwardRef

Let me know if I answered that here

Looks pretty good, just had a few questions. The main thing is I don't understand why we need to do hijackRef and useImperativeRef instead of forwardRef

Thanks for the review 👍 Let me know if I answered your question here

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.7-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.7-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

We reverted this PR because it caused this blocker #32379

Acknowledged, thanks. We'll start working on a follow-up.

Hi folks! Thanks for reverting the PR 👍
In the PR thread, I posted a quick explanation of what is the issue and what are possible ways to overcome it. Feel free to join the discussion - link to the comment


annotorious-OSD in vue 3

I am trying to use annotorious-osd combination in a vue 3 app. It works to some extent but with some strange limitations. I can successfully import both OSD and annotorious-osd, then create annotorious instance, passing OSD object as a parameter. Adding annotations via anno.loadAnnotations() or by drawing them by hand is also possible, but then there are the problems.

Any annotations that can be added programmatically via loadAnnotations() method are impossible to interact with, clicking on the selection box doesn't do anything
Annotations added manually are clickable, draggable and resizable but I can't draw more than one at a time, and if I delete it later it is impossible to draw new one unless I reload the page.

I realize that it is probably more of a vue-related problem rather than annotorious-osd one, but nevertheless if anyone can offer some advice I would be very grateful to hear it. Below is full code of  my vue 3 component.
<template>

</template>

As to 2nd problem, probably you need to hold SHIFT key while clicking and dragging the mouse to create a new annotation. I tried to use annotorious-osd in environment similar to yours, but it worked without problems.
https://annotorious.github.io/getting-started/osd-plugin/


rsync: Explictly specify DESTDIR

@ioraff
Requesting that DESTDIR be explicitly stated when building
make DESTDIR="$1" install

I believe this is the standard for this repo and also makes it more compitable with other kiss-like package managers

Echoing what I said in https://github.com/kiss-community/repo/pull/49 -- there is no particular style requirement and this is 100% up to the discretion of any given maintainer. I do not care either way, and so long as kiss supports an implicit DESTDIR we will allow packages which use it.


MSID: 93755 Version: 2 DOI: 10.1101/2<IP_ADDRESS>2268

MSID: 93755
Version: 2
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>2268
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=93755
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>2268

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/93755v2
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>2268
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/93755/v2/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c9) has a publication-type='other'. Is that correct?
warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c11) has a publication-type='other'. Is that correct?
warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c13) has a publication-type='other'. Is that correct?
warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c15) has a publication-type='other'. Is that correct?
warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c16) has a publication-type='other'. Is that correct?
warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c17) has a publication-type='other'. Is that correct?
warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c22) has a publication-type='other'. Is that correct?
warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c26) has a publication-type='other'. Is that correct?
warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c48) has a publication-type='other'. Is that correct?
warn: [title-upper-case] Content of  element is entirely in upper case: Is that correct? 'DECOMPOSITION OF CHANGE IN GENDER DIVERSITY'
warn: [title-upper-case] Content of  element is entirely in upper case: Is that correct? 'GENDER DIVERSITY OF HIRES OVER TIME'


Add option to specify watermark count

Related to #24
Introduces the ability to directly specify the number of watermarks to be generated through a new count option.

Adds a count?: number property to the Options interface in src/types/index.ts, allowing users to specify the desired number of watermarks.
Modifies the ElementWay class in src/core/element.ts to accept an optional count parameter in the render method. This parameter determines the total number of watermarks to generate, overriding the default behavior based on container dimensions.
Updates documentation in README-CN.md and README.md to include the new count option, providing users with guidance on how to use it to control the number of watermarks generated.

For more details, open the Copilot Workspace session.

close #24

Close #24


[help] - custom devices - Eurotronics Spirit Z - HomeAssistant

Hi,
I use hass.io and downloaded the zwave2mqtt addon and modified it (rebuilt on NUC) to symlink the devices.js into the config file so that i am able to customize the devices.
But unfortunately home assistant does not recognize them as climate devices.
Here is my custom devices.js
/* eslint-disable quotes */

// Place here repeated patterns
var FAN_DIMMER = {
  type: 'fan',
  object_id: 'dimmer',
  values: ['38-1-0'],
  discovery_payload: {
    command_topic: "38-1-0",
    speed_command_topic: "38-1-0",
    speed_state_topic: "38-1-0",
    state_topic: "38-1-0",
    speeds: ["off", "low", "medium", "high"],
    payload_low_speed: 24,
    payload_medium_speed: 50,
    payload_high_speed: 99,
    payload_off: 0,
    payload_on: 255,
    state_value_template: "{% if (value_json.value | int) == 0 %} 0 {% else %} 255 {% endif %}",
    speed_value_template: "{% if (value_json.value | int) == 0 %}  0  {% elif (value_json.value | int) <= 32 %}  24  {% elif (value_json.value | int) <= 66 %} 50 {% elif (value_json.value | int) <= 99 %} 99 {% endif %}"
  }
}

var CLIMATE_SPIRITZ = {
  type: 'climate',
  object_id: 'thermostat',
  values: ['64-1-0', '49-1-1', '67-1-1', '67-1-7', '67-1-11'],
  mode_map: {
      'off': 'Off',
      'heat': 'Heat (Default)',
      'heat_eco': 'Heat Eco',
      'heat_power': 'Heat Power'
  },
  setpoint_topic: { "Heat (Default)": '67-1-1', "Heat Eco": '67-1-11', "Heat Power": '67-1-7' },
  default_setpoint: '67-1-1',
  discovery_payload: {
      min_temp: 15,
      max_temp: 30,
      modes: ['off', 'heat', 'heat_eco', 'heat_power'],
      mode_state_topic: '64-1-0',
      mode_command_topic: true,
      current_temperature_topic: '49-1-1',
      current_temperature_template: '{{ value_json.value }}',
      temperature_state_template: '{{ value_json.value }}',
      temperature_command_topic: true
  }
}

module.exports = {
  '411-1-1': [
    { // Heatit Thermostat TF 021 (ThermoFloor AS)
      type: 'climate',
      object_id: 'thermostat',
      values: ['64-1-0', '49-1-1', '67-1-1', '67-1-2'],
      mode_map: { 'off': 'Off', 'heat': 'Heat (Default)', 'cool': 'Cool' },
      setpoint_topic: { "Heat (Default)": '67-1-1', "Cool": '67-1-2' },
      default_setpoint: '67-1-1',
      discovery_payload: {
        min_temp: 15,
        max_temp: 30,
        modes: ['off', 'heat', 'cool'],
        mode_state_topic: '64-1-0',
        mode_command_topic: true,
        current_temperature_topic: '49-1-1',
        current_temperature_template: '{{ value_json.value }}',
        temperature_state_template: '{{ value_json.value }}',
        temperature_command_topic: true
      }
    }
  ],
  '148-1-3': [CLIMATE_SPIRITZ],
  '148-2-3': [CLIMATE_SPIRITZ],
  '148-3-3': [CLIMATE_SPIRITZ],
  '99-12340-18756': [FAN_DIMMER], // GE 1724 Dimmer
  '99-12593-18756': [FAN_DIMMER] // GE 1724 Dimmer
}

I used your thermostat config file and modified it so it should work with the spirit-z ones.
I got the manufacturer ids from here:
https://github.com/OpenZWave/open-zwave/blob/master/config/manufacturer_specific.xml#L515
Hope you could help me.
Thanks in advance

I was trying the same thing this weekend, after a few iterations ended up with something like this (see my temporary fork for the full code):
'328-1-3': [
{ // EUROtronic Spirit
type: 'climate',
object_id: 'thermostat',
values: ['64-1-0', '49-1-1', '67-1-1', '67-1-11'],
mode_map: { 'off': 'Off', 'heat': 'Heat', 'auto': 'Heat Eco' },
setpoint_topic: { "Heat": '67-1-1', "Heat Eco": '67-1-11' },
default_setpoint: '67-1-1',
discovery_payload: {
min_temp: 11,
max_temp: 25,
modes: ['off', 'heat', 'auto'],
mode_state_topic: '64-1-0',
mode_command_topic: true,
current_temperature_topic: '49-1-1',
current_temperature_template: '{{ value_json.value }}',
temperature_state_template: '{{ value_json.value }}',
temperature_command_topic: true
}
}
],
Note that you need to translate de manufacturer code from HEX in "manufacturer_specific.xml" to DEC in this file, otherwise your device will never be recognized.
The MQTT implementation of HASS is somewhat limited:

The mode map can only contain these or a subset of these values: [“auto”, “off”, “cool”, “heat”, “dry”, “fan_only”], so not all options of the spirit device translate to a HASS MQTT HVAC device.
HASS always posts one of these mope map values as command in the command topic. You need to do some translation in HASS of Node-red to circumvent this (until HASS implements a more complete MQTT HVAC solution).

For now I ended up with a manual config of all my spiritz in HASS like this:

platform: mqtt
name: "Thermostaat Badkamer"
unique_id: "thermostaat_badkamer"
qos: 0
modes:

heat
'off'
mode_state_topic: "zwave2mqtt/badkamer/thermostaat/64/1/0"
mode_state_template: >
{% set values = {'Off':'off','Heat':'heat'} %}
{{ values[value_json.value] if value_json.value in values.keys() else 'failed' }}
mode_command_topic: "nodered/badkamer/thermostaat/mode/set"
current_temperature_template: "{{ value_json.value }}"
current_temperature_topic: "zwave2mqtt/badkamer/thermostaat/49/1/1"
min_temp: 11
max_temp: 25
temp_step: 0.5
temperature_state_topic: "zwave2mqtt/badkamer/thermostaat/67/1/1"
temperature_state_template: "{{ value_json.value }}"
temperature_command_topic: "zwave2mqtt/badkamer/thermostaat/67/1/1/set"

Note that you need to translate de manufacturer code from HEX in "manufacturer_specific.xml" to DEC in this file, otherwise your device will never be recognized.

This should be in the Readme.
Will try again later that day if it is working
Thanks @arjenhiemstra

Actually I’m on vacation, will answer to all questions/issues next week. Please feel free to open a PR if you have supported new devices or even for docs improents. Thanks
Daniel

On 3 Sep 2019, at 11:34, Martin Treml<EMAIL_ADDRESS>wrote:
Note that you need to translate de manufacturer code from HEX in "manufacturer_specific.xml" to DEC in this file, otherwise your device will never be recognized.
This should be in the Readme.
Will try again later that day if it is working
Thanks @arjenhiemstra
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.

@Munsio  You find the full device Id in the ui when you add a value to gateway values table
@arjenhiemstra Thanks for your solution, It is not easy to map thermostats in hass that is why a "manual" editing is needed, I think hass should make this easier

FYI
@arjenhiemstra - it seems that through the latest update in home assistant it is not needed anymore to use the custom properties on the thermostat - everything gets detected and works automatically as long as the thermostat is defined in the device.js


Convert packetIO buffer to an interface

Description
PacketIO buffer interface will allow to use custom buffer for rtp/rtcp streams

@Sean-Der I removed the metadata from buffer and set stdlib interfaces were possible, to understand the changes please also review https://github.com/pion/srtp/pull/126


oroOccupancyMaxActiveBlocksPerMultiprocessor returns hipErrorInvalidDeviceFunction always

Hi, the API oroOccupancyMaxActiveBlocksPerMultiprocessor always fails. I tried the "main" branch and also "release/hip6.0_cuda12.2" with RX7900XTX and RTX4090 but it always failed.
This can be reproduced by just adding this to "SimpleDemo".
			int numBlocks = 0;
			oroError_t error = oroOccupancyMaxActiveBlocksPerMultiprocessor( &numBlocks, function, 128, 0 );
			printf( "occupancy api %d %d\n", error, numBlocks ); // shows occupancy api 98 0

can anyone help?

The function is correctly bound to HIP  ( hipOccupancyMaxActiveBlocksPerMultiprocessor ) so I don't think the bug is related to Orochi.
I confirm I'm reproducing the same error code: hipErrorInvalidDeviceFunction (98).

@RichardGe
Thank you for checking but I found out the reason.
Orochi API have to use hipModuleOccupancyMaxActiveBlocksPerMultiprocessor/cuOccupancyMaxActiveBlocksPerMultiprocessor instead of hipOccupancyMaxActiveBlocksPerMultiprocessor / cudaOccupancyMaxActiveBlocksPerMultiprocessor since orochi uses runtime compilation. There is a difference in the pointer treatment between driver API and runtime API.

I think there are some more incorrect bindings e.g. oroFuncGetAttributes()

I confirmed the behavior with HIP SDK6.1 and https://github.com/ROCm/rocm-examples.git (92786e2 - Add source format linting to the GitHub workflows (#140)) and https://github.com/NVIDIA/cuda-samples

Some clarification here:
The selection of these two functions depends on where the function pointer,  which is used as one of the params, is coming from.
For example, in CUDA case:
If the function pointer is originally from something like cuModuleGetFunction() , the rest should be bound to "cu" instead of "cuda" and we cannot mix them.
Note:  In CUDA, runtime API functions start with "cuda" and driver API functions start with "cu"
The same applies to HIP.

Hi @AtsushiYoshimura0302  we investigated with @KaoCC ,
in SimpleDemo,  the function is taken from  oroModuleGetFunction , so you need to use  oroModuleOccupancyMaxActiveBlocksPerMultiprocessor instead of oroOccupancyMaxActiveBlocksPerMultiprocessor.
I tested, it worked.
So, I think we can close this ticket.

ah, thanks you for finding it out.


Text facet fetch

Linkeddata dropboxes contained a fixed set of max 20 values. With this change values are dynamically fetched while typing.

@FrankyHollywood I had a look into the existing code and it looks like the functionality that we needed is already there. There is no change needed in the Dropdown component.
Instead currently there is a small issue in CreateDirectoryButton.js#L64
If you change the value of clearTextOnSelection from false to true, like below, the autocomplete works as expected. You can also change the delay time using debounce parameter (by default it's 300ms)
      const linkedDataSelector = () => {
        if (!entityType) {
            return [];
        }
        const property = {className: entityType};

        return (
            <LinkedDataDropdown
                property={property}
                clearTextOnSelection
                onChange={onLinkedEntitySelected}
                debounce={400}
            />
        );
    };
    ```
Could you revert your changes and add a change to CreateDirectoryButton instead?


[BUG] the first task checkWorkerGroup error then others task cant execute in task queen

[BUG] the first task checkWorkerGroup error then others task cant execute in task queen,and then cycle execute first task then and then

I‘m sorry , I can't understand what you said!  you can desc issue in chinese, then  translate it to english by using baidu or google!  thanks!

在任务队列中，如果第一个任务在流程组中定义了实现任务的流程组，但又在流程组中找不到执行任务的主机，此时所有任务都会被第一个任务阻塞在队列中。

If worker group has been defined previously，but no worker is found in the worker group that could execute the task, should the worker working group be changed?

如果先前定义了实现任务的工作组，在执行时发现没有worker在这个任务的工作组中，那应该改worker工作组吧？

Duplicate of #352, has been resolved in version 1.1.0


Allow arbitrary nesting in test reports

Fixes #31053
Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

@bot-gradle test this

I've triggered the following builds:

Pull Request Feedback (Trigger) (Check)

Build Scan

The following builds have passed:

Pull Request Feedback (Trigger) (Check)

Build Scan

Getting in touch server builder (fixing) source code to process exchange rate and new tax reforms for Asia/Pacific and africa

WARN: Based on labels, this pull request addresses notable issue but no changes to release note found.


Use IPv6 by default

This will listen to IPv6 by default, as well as create dual-stack sockets by default.
Linux Kernels, which have IPv6 removed / disabled won't be able to start the py-kms server anymore, without explicitly changing the listen_addr as well as the dual-parameter.
Closes #71
Remaining steps

[ ] Test on real IPv6-hardware (both bare+Docker)

Pending testing, asked requester on #71 to test.

I tested this with ghcr.io/py-kms-organization/py-kms:latest@sha256:3b8cb6871cbfc5ae9a76909d53f0d659af28fbe5abb3b9d075c1b33c95813804 in my K8s cluster and it works on IPv6 without having to manually override the IP env var 👍 (Can't say if IPv4 still works, as that is not used in my setup)

Let's go beta!


[FEA] Benchmark cuDF branch that uses global memory for regular expressions

Is your feature request related to a problem? Please describe.
We want to benchmark the performance of https://github.com/rapidsai/cudf/pull/10094 to see if this is performant enough to use by default so that we can safely enable regular expressions on the GPU by default
Describe the solution you'd like
See above
Describe alternatives you've considered
None
Additional context
None

I ran some benchmarks against a parquet file with 20,400,000 strings using the following query:
SELECT count(*) FROM item100 where i_item_desc RLIKE '\\.[ ]?([A-Z][aeiou][^aeiou])|([A-Z]([^aeiou][aeiou]))'

First, I ran the query with a new Spark shell each time to get the cost of the first time running the query.
All times are in milliseconds.
Baseline results
6432
6316
6462
6380
6277

cuDF branch using global memory
34747
34852
34705
34725
34735

I also ran the query multiple times within the same Spark shell.
Baseline results
6277
4980
4867
4893
4806

cuDF branch using global memory
34735
33342
33288
33278
33338

Conclusion: The global memory performance is ~5-7x slower than the baseline for this particular scenario.

5 to 7x slower is not good. At those speeds I suspect that the CPU might be beating us.

5 to 7x slower is not good. At those speeds I suspect that the CPU might be beating us.

Yes, if we fall back to CPU for RLike then the query takes ~10 seconds for the first run and ~8 seconds for subsequent runs.

@andygrove can you retest with the asnyc allocator enabled ( https://github.com/NVIDIA/spark-rapids/pull/4606 ) ?

can you retest with the asnyc allocator enabled?

To be clear, we're interested in the performance of the original regex kernels, not the new version using global memory, when used in conjunction with the async allocator.  Since the async allocator operates at the driver level, it can "steal" unused memory in the pool for kernel launches.  That should prevent the CUDA OOM errors due to insufficient reserved memory when using the original regex kernels.

I ran the query five times with the async allocator branch and the default cuDF. The times look good, about the same as the previous baseline results.
6132
4773
4671
4769
4655

Closing this because we ran all the benchmarks we needed


Mixed precision training with tf.keras 2.0

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):
TensorFlow version (use command below): 2.0.0
Python version: 3.5
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: 10.0
GPU model and memory: V100

Describe the current behavior
I am trying to incorporate mixed-precision training in my tf.keras models. After going through the instructions on the NVIDIA docs, I used the following code snippet (full code is provided in the end):
opt = tf.keras.optimizers.Adam()
opt = tf.train.experimental.enable_mixed_precision_graph_rewrite(opt)
model.compile(loss=loss, optimizer=opt)
model.fit(...)

I do not see any speed up after mixed precision is enabled. I tried out tf.keras.mixed_precision.experimental.LossScaleOptimizer(opt, "dynamic"). Still there is no significant improvement to note. On the other hand, I tried to experiment with tf.keras.mixed_precision.experimental.set_policy('mixed_float16') but I am kind of confused about how to appropriately use it. I am trying to train the following model on the FashionMNIST dataset:
tf.keras.mixed_precision.experimental.set_policy('mixed_float16')
model = Sequential([
            Input((28,28,1)),
            Conv2D(32, (3, 3), activation='relu'),
            MaxPooling2D((2,2)),
            Conv2D(64, (3, 3), activation='relu'),
            MaxPooling2D((2,2)),
            Conv2D(64, (3, 3), activation='relu'),
            GlobalAveragePooling2D(),
            Dense(64, activation='relu'),
            Dense(10, activation='softmax')
])
model.compile(optimizer='adam',
              loss='sparse_categorical_crossentropy',
              metrics=['accuracy'])

But when I call model.fit(x_train, y_train, validation_data=(x_test, y_test), epochs=10, batch_size=128), I get the following:
/usr/local/lib/python3.5/dist-packages/tensorflow_core/python/framework/op_def_library.py in _apply_op_helper(self, op_type_name, name, **keywords)
    561                   "%s type %s of argument '%s'." %
    562                   (prefix, dtypes.as_dtype(attrs[input_arg.type_attr]).name,
--> 563                    inferred_from[input_arg.type_attr]))
    564
    565           types = [values.dtype]

TypeError: Input 'y' of 'Mul' Op has type float32 that does not match type float16 of argument 'x'.

The entire error trace is there in the attached notebook. The second experiment in this line I did was with policy = tf.keras.mixed_precision.experimental.Policy('mixed_float16'). In that, I just set the dtype of the penultimate dense layer (of the above-mentioned model) to policy. The works fine but throws this warning:
WARNING:tensorflow:Layer dense_1 is casting an input tensor from dtype float16 to the layer's dtype of float32, which is new behavior in TensorFlow 2.  The layer has dtype float32 because it's dtype defaults to floatx.

If you intended to run this layer in float32, you can safely ignore this warning. If in doubt, this warning is likely only an issue if you are porting a TensorFlow 1.X model to TensorFlow 2.

To change all layers to have dtype float16 by default, call `tf.keras.backend.set_floatx('float16')`. To change just this layer, pass dtype='float16' to the layer constructor. If you are the author of this layer, you can disable autocasting by passing autocast=False to the base Layer constructor.

Any recommended way of using these policies along with simple and more complex models?
Describe the expected behavior
Code to reproduce the issue
Mixed Precision Training in tf.keras 2.0.zip

I had the same problem with float16 training. Please refer to this issue for an explanation on why the TypeError is thrown. Apparently, it will be fixed in TF2.1 and is already fixed in the current tf-nightly-gpu.
#33484

@verrannt thank you very much :)

@sayakpaul ,
Looks like the issue is fixed in tf-nightly-gpu, can you confirm the same and close the issue ?Thanks!

@oanush I can definitely check that out but there were some other issues I mentioned which I believe need some more attention. For example, the speedup not happening when using tf.keras.mixed_precision.experimental.LossScaleOptimizer(opt, "dynamic"). So, I would wait for a few days to get some pointers on that.

When using tf.keras.mixed_precision.experimental.set_policy('mixed_float16'), the last layer (softmax layer) must currently be set to have dtype=tf.float32 and it will work:
Dense(10, activation='softmax', dtype=tf.float32)

However, you are not seeing speed-up because of a few reasons:

The model is too small (only 60554 params), so other overheads (casting, padding) have greater impact that speeding up the layers
Many shapes in the model are not fully efficient on Tensor Cores. Conv filters/channels are multiples of 8, so that's good. But the input/output sizes are not in multiples of 8 (I see 26, 13 etc), and this requires padding in the software. This is much less significant on larger models.

For some "non-official" examples demonstrating speed-up on some real-world models, check out:
https://github.com/NVAITC/pycon-sg19-tensorflow-tutorial
P.S. I am using TensorFlow 2.0 stable

@tlkh thanks much for your pointers. I experimented today with ResNet50V2 as well but could not observe any significant improvements. You can find the notebook here.
Also, did you check out experiments with tf.train.experimental.enable_mixed_precision_graph_rewrite(opt) and tf.keras.mixed_precision.experimental.LossScaleOptimizer(opt, "dynamic") (notebooks 1 - MP in tf.keras 2.0.ipynb and 2 - MP in tf.keras 2.0.ipynb respectively)? They include a larger model.

2 - MP in tf.keras 2.0.ipynb

Your training is CPU bottlenecked due to the data augmentation.  Just adding use_multiprocessing=True and workers=8 to the fit function cuts each epoch from 30+s to 20+s on my workstation (20 core Xeon processor). Using tf.data (in particular the prefetch function) would likely yield much better results.
In any case, I don't think you're using the mixed precision API correctly. tf.keras.mixed_precision.experimental.LossScaleOptimizer does not activate mixed precision on its own. You need to call tf.config.optimizer.set_experimental_options({"auto_mixed_precision": True}). Note that this is set on a per-session basis, so you need to call tf.keras.backend.clear_session to remove that setting. The same goes for when using enable_mixed_precision_graph_rewrite, it is a per-session config. You can't enable it half-way in a notebook for the same model (like in your first notebook!).
GPU utilisation is oddly low (<20%) and I'm actually not quite sure why actually.
The model is still "too small". The model's convolution layers only have 32 filters each. As a rule of thumb, Conv layers under 256 filters are likely to be memory, not compute bottlenecked.

Here are my results for mixed precision vs FP32 (V100) after some modifications:

Modifications: 256 filters per conv layer; 40 workers; batch_size 320; enabled XLA compiler
FP32: 74.54s for first 3 epochs
mixed precision: 59.97s for first 3 epochs

For what it's worth, smaller models aren't currently a good showcase for mixed precision. I typically work with larger transformer models, and mixed precision is really a godsend for those!

@tlkh thank you for providing the information. I could not find this on the documentations I had studied. Moving forward, I will consider these and will report back accordingly.

Thank you @sayakpaul for filing this issue, and @tlkh for the responses! As mentioned, TF2.1 will fix the TypeError, but you can pass dtype=tf.float32 to make it work in 2.0.
However, even in 2.1, it is recommended to do softmax in float32 for numeric stability. @tlkh fix of passing dtype=tf.float32 will cause the softmax to be done in float32, solving the issue. For slightly better performance, you can also just do the softmax in float32 while keeping the Dense layer in mixed_float16, by splitting the Dense layer from the activation as follows:
model = Sequential([
            ... # All the previous layers
            Dense(10),
            Activation('softmax', dtype='float32')
])

I am trying to find a way to automatically do Softmax in float32, but as of 2.1, you still must explicitly pass dtype='float32'.
Also, you can safely ignore the warning you received:
WARNING:tensorflow:Layer dense_1 is casting an input tensor from dtype float16 to the layer's dtype of float32, which is new behavior in TensorFlow 2.  The layer has dtype float32 because it's dtype defaults to floatx.

If you intended to run this layer in float32, you can safely ignore this warning. If in doubt, this warning is likely only an issue if you are porting a TensorFlow 1.X model to TensorFlow 2.

To change all layers to have dtype float16 by default, call `tf.keras.backend.set_floatx('float16')`. To change just this layer, pass dtype='float16' to the layer constructor. If you are the author of this layer, you can disable autocasting by passing autocast=False to the base Layer constructor.

In this particular case, the warning is a bug and should not appear. This has been fixed in the nightlies and TF 2.1, and does not appear with tf-nightly-gpu.
I will have a better tutorial for using mixed precision in the future. For now, I recommend using the following: https://www.tensorflow.org/api_docs/python/tf/keras/mixed_precision/experimental/Policy

Thank you very much for passing this along @reedwm. I think the notebooks @tlkh shared are quite nice and definitely provide good insights. I am also working on more experiments to make it easier for the community to try mixed-precision training in tf.keras 2.0.

@tlkh I experimented with your codes today but on a different dataset. Mixed Precision indeed showed it's magic and that too big time. I have pushed the files here. The GPU utility has significantly increased as I am now using utilities from tf.data. I did not see any stark difference in the memory footprint though (you can check those information here).
I am going to experiment with the other methods now and will share the results here. On a side note, if you see the performance of ResNet got worse on the dataset I used, it can be for a number of reasons, though.
Note that the repository is not complete yet. I am going to add all the acknowledgments, README a bit later.

When using the Policy method, the loss is also scaled. I'm not sure why the tf.config + LossScaleOptimizer would not be working when the Policy method does.
I'm currently a bit tied up with work, but I'll take a close look at this when I have some time.

Sure. Thanks, @tlkh :)

@sayakpaul, in the Jupyter notebook where you have the LossScaleOptimizer, you have the line
tf.keras.mixed_precision.experimental.LossScaleOptimizer(opt,
                                                       "dynamic")

The issue is LossScaleOptimizer does not modify the passed in optimizer, but instead returns a new optimizer that performs loss scaling. Try setting opt to the LossScaleOptimizer instead:
opt = tf.keras.mixed_precision.experimental.LossScaleOptimizer(opt,
                                                               "dynamic")

I think fixing this will cause tf.config + LossScaleOptimizer to work just as well as the Policy. In the future, I'll try to raise an error or warning if this issue occurs.
Also note currently I cannot run the Jupyter notebooks as I do not have the X_train.npy and y_train.npy datasets.

@reedwm extremely sorry about that silly mistake. I have updated the notebooks accordingly but still, the loss increases along with the accuracy.
Note that I intentionally did not pass the .npy files. You would need to run the Data_gathering_and_prep.ipynb notebook to generate them.

Also, for the LossScaleOptimizer notebook, try passing learning_rate=1e-4 to the Adam optimizer:
opt = Adam(learning_rate=1e-4)

This is already done in the Policy notebook. After doing this, the loss decreased for me instead of increasing.

Sure, thanks much @reedwm


Reddit downloads don't work when you use shortlinks

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting that a supported site is broken
[X] I've verified that I'm running yt-dlp version 2023.03.04 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and I'm willing to share it if required

Region
Ireland
Provide a description that is worded well enough to be understood
Reddit's shortlinks (at redd.it) probably don't need special-casing, as they issue a normal HTTP 301 redirect response, but the page to which they redirect is not a page that yt-dlp knows how to cope with. In a browser, Reddit loads the page and then (I think) uses history.pushState() to update the URL to the normal one that yt-dlp expects.
Since the page initially loaded does contain the video, I imagine that it would be a relatively minor tweak to yt-dlp to support these URLs.
(Te example video provided is safe for work, by the way.)
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['https://redd.it/124pp33', '-vU']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>[392389b7d] (zip)
[debug] Python 3.8.10 (CPython x86_64 64bit) - Linux-5.4.0-144-generic-x86_64-with-glibc2.29 (OpenSSL 1.1.1f  31 Mar 2020, glibc 2.31)
[debug] exe versions: ffmpeg 4.2.7, ffprobe 4.2.7
[debug] Optional libraries: Crypto-broken 2.6.1, certifi-2019.11.28, secretstorage-2.3.1, sqlite3-2.6.0
[debug] Proxy map: {}
[debug] Loaded 1786 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Available version<EMAIL_ADDRESS>Current version<EMAIL_ADDRESS>Current Build Hash: 91cad9f121c1f6f0a81b747415c46ecba0ff331ed38cc6433040b4ac7b6e15ca
yt-dlp is up to date<EMAIL_ADDRESS>[generic] Extracting URL: https://redd.it/124pp33
[generic] 124pp33: Downloading webpage
[redirect] Following redirect to https://www.reddit.com/comments/124pp33
[generic] Extracting URL: https://www.reddit.com/comments/124pp33
[generic] 124pp33: Downloading webpage
WARNING: [generic] Falling back on generic information extractor
[generic] 124pp33: Extracting information
[debug] Looking for embeds
ERROR: Unsupported URL: https://www.reddit.com/comments/124pp33
Traceback (most recent call last):
  File "/usr/local/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 1518, in wrapper
    return func(self, *args, **kwargs)
  File "/usr/local/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 1594, in __extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/common.py", line 694, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/generic.py", line 2510, in _real_extract
    raise UnsupportedError(url)
yt_dlp.utils.UnsupportedError: Unsupported URL: https://www.reddit.com/comments/124pp33

since https://redd.it/124pp33 redirects to https://www.reddit.com/comments/124pp33, I think this is all we need to do:
diff --git a/yt_dlp/extractor/reddit.py b/yt_dlp/extractor/reddit.py
index 9dba3eca8..4aa935ac2 100644
--- a/yt_dlp/extractor/reddit.py
+++ b/yt_dlp/extractor/reddit.py
@@ -14,7 +14,7 @@

 class RedditIE(InfoExtractor):
-    _VALID_URL = r'https?://(?P<subdomain>[^/]+\.)?reddit(?:media)?\.com/(?P<slug>(?:r|user)/[^/]+/comments/(?P<id>[^/?#&]+))'
+    _VALID_URL = r'https?://(?P<subdomain>[^/]+\.)?reddit(?:media)?\.com/(?P<slug>(?:(?:r|user)/[^/]+/)?comments/(?P<id>[^/?#&]+))'
     _TESTS = [{
         'url': 'https://www.reddit.com/r/videos/comments/6rrwyj/that_small_heart_attack/',
         'info_dict': {

$ yt-dlp -F "https://redd.it/124pp33"
[generic] Extracting URL: https://redd.it/124pp33
[generic] 124pp33: Downloading webpage
[redirect] Following redirect to https://www.reddit.com/comments/124pp33
[Reddit] Extracting URL: https://www.reddit.com/comments/124pp33
[Reddit] 124pp33: Downloading JSON metadata
[Reddit] 124pp33: Downloading m3u8 information
[Reddit] 124pp33: Downloading MPD manifest
[info] Available formats for antsenjc2jqa1:
ID                  EXT RESOLUTION FPS │   FILESIZE  TBR PROTO │ VCODEC       VBR ACODEC      ABR ASR MORE INFO
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
hls-2-audio_0       mp4 audio only     │                 m3u8  │ audio only       unknown             audio 0
hls-3-audio_0       mp4 audio only     │                 m3u8  │ audio only       unknown             audio 0
dash-audio_0_130140 m4a audio only     │ ~276.55KiB 130k https │ audio only       mp4a.40.2  130k 48k DASH audio, m4a_dash
dash-video_254485   mp4 122x220     30 │ ~540.78KiB 254k https │ avc1.4D401E 254k video only          DASH video, mp4_dash
dash-video_612003   mp4 132x240     30 │ ~  1.27MiB 612k https │ avc1.4D401E 612k video only          DASH video, mp4_dash
hls-354             mp4 158x288        │ ~752.25KiB 354k m3u8  │ avc1.42c01e 354k video only
hls-450             mp4 158x288        │ ~956.25KiB 450k m3u8  │ avc1.42c01e 450k video only
hls-560             mp4 176x320        │ ~  1.16MiB 560k m3u8  │ avc1.42c01e 560k video only
hls-656             mp4 176x320        │ ~  1.36MiB 656k m3u8  │ avc1.42c01e 656k video only
fallback            mp4 198x360        │ ~  1.66MiB 800k https │ h264        800k video only          DASH video, mp4_dash
dash-video_816954   mp4 198x360     30 │ ~  1.70MiB 817k https │ avc1.4D401E 817k video only          DASH video, mp4_dash


🚀 Feature: Add a --version CLI option

PR Checklist

[x] Addresses an existing open issue: fixes #704
[x] That issue was marked as status: accepting prs
[ ] Steps in CONTRIBUTING.md were taken

Overview

Thanks for getting started! I don't think this is ready for review yet, so switching it to draft. Feel free to mark it as ready whenever you feel up for it. 🙂

Oh, and based on the code changes (e.g. spaces instead of tabs) I suspect https://www.joshuakgoldberg.com/blog/contributing-to-a-create-typescript-app-repository might be useful for you. Filed #982 to track adding a link to the docs. Cheers!

👋 @HarshitVashisht11 just checking in, is this something you still have time and interest for? No worries if not - I just don't want to leave it pending too long.


Retrieve an active fault including error message

It would be great if the integration could retrieve an active fault including error message via the API. The app can display this. Perhaps it is therefore also possible to make this message accessible in Home Assistant. You could then be notified via automation if there is an active fault.

Thank you for the suggestion. I will look into this.


Chat: Best-Of N effect

Add a Chat Effect to the Chat Application, where the user can invoke an assistant completion on a "Best-of" mode.
In this mode, the assistant will generate N (2..10) completions, which will be shown to the user on a modal popup dialog. When all of them are done, they become active and scrollable. At this point either the user can select one of them to append to the conversation that started it all, or can use a "Judge" function specifying the criteria.
Requirements:

Initiation

[x] initiate from the "Retry" or "Restart from here" menu options
[x] also initiate as a special "Mode" for the Chat

[ ] at the ChatApp (or Message List?) termination, activate a "mode" that will display the chat and send it the instructions as initialState (which won't change anytime, and if it doesn't it's a new operation)
[ ] Alternatives are generated from: Chat up to that point, submitted N times in parallel
[ ] Judging happens by applying: [judge prompt, pre-judging instruction* with the "-1"-message inside, options(1..N), post-judging instruction]

[ ] *: are the pre/post judging instructions generated as well?

Rendering

[ ] Alternatives: 'warning' to show the in-progress status, and neutral/success at the end
[ ] Alternatives: inside render using  over the in-progress text, to benefit from auto-everything
[ ] Judge: make it clear that the user needs to specify the "success criteria/what to look for"
[ ] While judging, the display of the N collapses, and one unified display comes out from it

[ ] At the end add the message to the originating source, possibly via a onSuccess/onFail/onCancel callback strategy

Duplicate of #470


[CONTROLLER/RECORDER] reduces prometheus target id pool

This PR is for:

Server

reduces prometheus target id pool
Checklist

[ ] Added unit test.

Backport to branches

main

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.zhengya seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


add public_name stanza

This is necessary for genie to rely on ocaml-bindgen as a dependency.

Accidentally merged more commits into my fork's main so closing and reopening the one liner cherrypicked onto a new branch.


On Click of 5th item or some time 6th or 7th item click don't work in suggestion box and instead click on back textfields available under the suggestion box

On Click of 5th item or some time 6th or 7th item click don't work in suggestion box and instead click on back textfields available under the suggestion box

Observe now if dropdown position is center or below the screen its doest not allow to click on any item

I am using the dropdown inside a dialog

@ArslanKhan99 can you share a screen recording or something, so, I have exact reference of what you are talking about. Thanks

Surprisingly Its working today. I changed nothing making video and its working now.

Attaching video occurred again.
https://github.com/rohanjariwala03/drop_down_search_field/assets/62021808/47657cf7-7cd0-49dc-92dd-2ff0074d8216

instead if clicking on option in suggestion box clicked on back fields

@ArslanKhan99 this issue will be fixed soon. Thanks for reporting.

@ArslanKhan99  it should be fix now. You need to use new version of this package. and pass ignoreAccessibleNavigation: true.
If issue persist, then please open this Issue again.

@rohanjariwala03 Problem still exists in 1.0.4, because fix made in PR #30, was reverted in #31
There is problem with catching clicks by field under the suggestions, and also with scrolling lists of suggestion.


Non-alphabetic characters are not allowed in protocol names.

When I use ddu-ui I got an error.
ddu-ff:/.../.nfnl.fnl is not trusted, refusing to compile.
I think there are other cases involving non-alphabetic letters.
related issue

https://github.com/Olical/nfnl/issues/3

Thanks for reporting, what happens if you go into the .nfnl.fnl file it's talking about and execute :trust inside Neovim? Does the error go away?

Also are you getting this error when you write a Fennel file or just by browsing things?

No problem in normal coding.
In this case, the error occurs in the preview view using fuzzy finder.
Thank you.

Sorry, should've done this ages ago, just had a LOT going on. I've widened my ignore rule so now I ignore this pattern ^[%w-]:/ which includes the fugitive paths I originally cared about as well as these ddu-ui ones.
I worry that it'll break support for things like ftp protocols that some people might be using, but maybe I can use an allowlist for the ones that are valid.
I still don't know why this is an issue, you should only see this error if you try to write a file, so I presume something in this plugin is writing a temp file somewhere which is triggering nfnl when it shouldn't. But I can't be sure, so let's use a broad fix for now and move on.
And if you no longer use nfnl so it's a non-issue, no problem! At least this will hopefully be fixed for others in the future.

Thank you so much.  I love this plugin.
Shouldn't the regular expression here be set like ^[%w-]+:/?
https://github.com/Olical/nfnl/blob/a7b08d2e828338b45ba69f6a3797e80f755efe9a/fnl/nfnl/callback.fnl#L35

You are 1000% correct, fixing now. Thanks!
On Fri, 22 Mar 2024, 14:11 Tak, @.***> wrote:

Thank you so much. I love this plugin.
Shouldn't the regular expression here be set like ^[%w-]+:/?
https://github.com/Olical/nfnl/blob/a7b08d2e828338b45ba69f6a3797e80f755efe9a/fnl/nfnl/callback.fnl#L35
—
Reply to this email directly, view it on GitHub
https://github.com/Olical/nfnl/issues/35#issuecomment-2015193219, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACM6XJDJXXO535EPCU7LWLYZQ32RAVCNFSM6AAAAABEAHANB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJVGE4TGMRRHE
.
You are receiving this because you were assigned.Message ID:
@.***>

Fixed! Should've written a test for it, will do that now.

If you're happy, please feel free to close this 😄 I've extracted the logic and tested it now too.

It worked perfectly! Thank you!!!


WIP: split mock server

@GongDDEX
Please split mockStore and mockApi logic from the production code to reduce bundle js size.

mock development server
Let's use json-server to resolve the case of the development of mock data.

Please don't use react eject, we can use react-app-rewired and customize-cra to solve this request.


Fails to set brightness

The text of that error and env info:
% sw_vers
ProductName:            macOS
ProductVersion:         14.6.1
BuildVersion:           23G93
% brightness 0.5
brightness: failed to set brightness of display 0x1 (error -536870201)

Same error here

Same here too

Same here

saaaamsie

Please stop.


Tap on notification by text and by index on iOS

Nice blogpost:

<EMAIL_ADDRESS>


Fix time-series filtering

Description
Fixes #202 (and #201 😃 )
Type of change
It is a Bug Fix for the reading part, it does not include breaking changes on the algorithm or the writing of the files.
Now TimestampType and DateType are pre-processed on QueryFilterUtils to return a Millisecond representation that can be filtered properly by the index.
Checklist:
Here is the list of things you should do before submitting this pull request:

[x] New feature / bug fix has been committed following the Contribution guide.
[x] Add comments to the code (make it easier for the community!).
[x] Change the documentation.
[x] Add tests.
[x] Your branch is updated to the main branch (dependent changes have been merged).

How Has This Been Tested? (Optional)
I've added a test on src/test/scala/io/qbeast/spark/index/query called TimeSeriesQueryTest. In this class, I've tested four different ways of creating an index on a Date / Timestamp column. Each one were failing differently, and should fail if executed with previous commits.
Test Configuration:
TBD.

To have a fixed version for 0.3.x for compatibility with Spark 3.2.x, the commits of this PR should be merged into a new 0.3.5 version release, and updated accordingly.

Hello @alexeiakimov ! Could you review this quick fix? Thank you 🙌

Fixed #202 and #201


camel-quarkus-avro: Remove ObjectSubstitution when/if quarkus serialization has been fixed

We may be able to remove the AvroSchemaSubstitution class when #9446 is fixed.

It's won't fix on quarkus side. So the ObjectSubstitution work around remains. Closing then.


Keep Menu Items open

How can i keep all the menu items always open?

Hey @abhinav011085
You can keep all the menu items always opened by making the display:block and maybe disabling any javascript function linked with it that is making it disappear
Hope this helps your issue
And please paste a code related to your issue or mention in which file you are experiencing this


Export submodules instead of all components in the root

Current Behavior
We are building shared-code projects with tsdx, and we only have one doubt, concern we can't get an answer. How to export subfolders for packages published with TSDX.
Let's use my previous example for the question. In the entry point  of our project, we export those two components in the root.
And because of that, when you want to use them we have to import the components from the root of our library (usage example):
import { Thing, SimpleStyledH1Application } from "tsdx-styled-components"

We would like to know how to configure our entry point(s) so we can import our components from subfolders like
import { Thing } from "tsdx-styled-components/things"
import { SimpleStyledH1Application } from "tsdx-styled-components/styled"
import { CoreComponent } from "tsdx-styled-components"

Expected behavior/Suggested solution(s)
To have a guide/notes on how to add subfolders to the libraries we create, so it's easy (not only for me but for anyone using TSDX) how to create libraries with subfolders.
Additional context

I tried to change our rollup configuration following this thread but was not working and not sure if is the right/easier path to get it done.
There is a rollup plugin for that purpose, so something like that with the instructions on how to add in in our tsdx.config.js would be great.

Your environment
Example project:
https://github.com/robertovg/tsdx-styled-components/
https://github.com/robertovg/next-ts-styled-components-tsdx-host

Any updates on thishere?

Would also love to know more about this. Have tried changing the entry and name parameters in the build command, but it's all still exported as index.js

+1

I wanted to achieve the same thing ang I think I got it working with tsdx, rollup config override based on the linked stackoverflow threads and some extra bash scripts.
The submodule is only in the esm though, so this still is not ideal.
In our case moving towards monorepo with multiple separate packages will probably work better.
You can check out the PR here: https://github.com/VirtusLab/formts/pull/83


Update Cats to 0.9.0 [do not merge]

Just setting up for the 0.9.0 release.

Current coverage is 91.66% (diff: 100%)

Merging #35 into master will not change coverage

@@             master        #35   diff @@
==========================================
  Files             6          6
  Lines           144        144
  Methods         144        144
  Messages          0          0
  Branches          0          0
==========================================
  Hits            132        132
  Misses           12         12
  Partials          0          0

Powered by Codecov. Last update 84286cb...9390856


fix: add ability to save result of logic function on train score step

:tada: This PR is included in version 0.172.2 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Heaven Official's Blessing fails to Download

Describe the bug
While Downloading "Heaven Official's Blessing" you just run into an error:
[2024-01-14 21:25:55] DEBUG  crunchy_cli (1) cli input: Cli { verbosity: Some(Verbosity { verbose: true, quiet: false }), lang: None, experimental_fixes: true, login_method: LoginMethod { credentials: None, etp_rt: Some("xxx"), anonymous: false }, proxy: None, user_agent: None, speed_limit: None, command: Archive(Archive { audio: [de_DE, ja_JP, en_US], subtitle: [de_DE, en_US], output: "./Crunchyroll/{series_name}#{series_id}/Season {season_number}/{series_name} - S{season_number}E{episode_number} - {audio}.mkv", output_specials: None, resolution: Resolution { width:<PHONE_NUMBER>3709551615, height:<PHONE_NUMBER>3709551615 }, merge: Audio, ffmpeg_preset: None, ffmpeg_threads: None, default_subtitle: None, include_fonts: false, skip_existing: true, skip_specials: false, yes: true, threads: 4, urls: ["https://www.crunchyroll.com/series/G79H23XX8/heaven-officials-blessing"] }) }
[2024-01-14 21:25:55] INFO  crunchy_cli (1) Logging in
[2024-01-14 21:25:56] INFO  crunchy_cli (1) Logged in
[2024-01-14 21:25:56] DEBUG  crunchy_cli (1) Created context
[2024-01-14 21:25:56] DEBUG  crunchy_cli (1) Created ctrl-c handler
[2024-01-14 21:25:56] INFO  crunchy_cli (1) Parsing url 1
[2024-01-14 21:25:56] DEBUG  crunchy_cli::utils::parse (1) Url may contain filters
[2024-01-14 21:25:56] DEBUG  crunchy_cli::utils::parse (1) Url find: UrlFilter { inner: [InnerUrlFilter { from_episode: None, to_episode: None, from_season: None, to_season: None }] }
[2024-01-14 21:25:56] DEBUG  crunchy_cli::utils::parse (1) Detected maybe old url
[2024-01-14 21:25:56] DEBUG  crunchy_cli::utils::parse (1) Url type: Series("G79H23XX8")
[2024-01-14 21:25:57] INFO  crunchy_cli (1) Parsed url 1
[2024-01-14 21:25:57] INFO  crunchy_cli (1) Fetching series details
[2024-01-14 21:25:57] WARN  crunchy_cli::archive::filter (1) Series Heaven Official's Blessing is not available with de-DE audio
[2024-01-14 21:25:59] WARN  crunchy_cli::archive::filter (1) Season 2 is only available with en-US audio until episode 8 (The Green-Clothed Ghost Qi Rong)
[2024-01-14 21:26:00] WARN  crunchy_cli::archive::filter (1) Season 2 is only available with ja-JP audio until episode 11 (Untitled)
thread 'main' panicked at /project/crunchy-cli-core/src/archive/filter.rs:402:18:
called `Option::unwrap()` on a `None` value
stack backtrace:
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
[2024-01-14 21:26:00] INFO  crunchy_cli (1)

To Reproduce
Steps / command to reproduce the behavior:
crunchy-cli -v --experimental-fixes --etp-rt xxx archive --skip-existing --yes -m audio -a de-DE -a ja-JP -a en-US -s de-DE -s en-US -o './Crunchyroll/{series_name}#{series_id}/Season {season_number}/{series_name} - S{season_number}E{episode_number} - {audio}.mkv' https://www.crunchyroll.com/series/G79H23XX8/heaven-officials-blessing

Expected behavior
The command should not fail.
Client (please complete the following information):

OS: Linux
Version: 3.2.4

Removing the --experimental-fixes fixes the crash, although the cli gets confused by something and doesn't download all episodes then

If you add -a zh-CN it works. But it tells you that it is not available in de-DE and zh-CN and just downloads ja-JP and en-US.

If you add -a zh-CN it works. But it tells you that it is not available in de-DE and zh-CN and just downloads ja-JP and en-US.
EDIT: Season 2 is adding ja-JP twice ?
::      Episode: S02E10
::      Audio: ja-JP, ja-JP
::      Subtitles: de-DE, en-US
::      Resolution: 1920x1080
::      FPS: 23.97
:: Downloading video #1      1.15 GiB  17.03 MiB/s [##############################################################] 100%
:: Downloading ja-JP audio  19.47 MiB   1.17 MiB/s [##############################################################] 100%
:: Downloading ja-JP audio  19.47 MiB   1.19 MiB/s [##############################################################] 100%
:: Downloading subtitles    de-DE, de-DE, en-US, en-US
:: Generating output file   [#####################################################################################] 100%

Does this still happen? I am unable to reproduce it

Scheint tatsächlich gefixt. Muss also an Crunchyroll gelegen haben.


DP should convey its S1U IP to CP on start up

Instead of user providing S1U IP of DP in the CP commandline arguments, the DP can send a message to CP with this information. This will reduce the number of things to know upfront for CP.

/cc @ajamshed @vishal-sangale what do you thing

Yes. This may work. Probably after init_s11() is called?

FYI - In Sx this is part of the association establishment.  If you feel there is more data missing on startup you can look at the TS 29.244 spec for association establishment - it is what 3GPP thinks they need between DP and CP on startup


Let user specify start time in config file for reproducible tests.

This PR allows tester to add a start time in the config file as seconds after 1970. When start time is present, the compliance tester always uses that start time instead of using 12 minutes before the present.  This feature enables reproducible test results.

Hi, I thanks for your feedback on this PR. I have changed so that end time can be a floating point value or can be an actual time.  I also added range and resolution too.

:+1: Thanks!


Change create/1 to open/1 with an option to clarify usage

Right now it's not clear that Depo.create/1 creates and opens a database. Especially when there is a different function calledopen, it seems like you need to call create and then open.
Test for errors when opening databases with bad paths.

Resolved in [51ca56d75846f956803d763e7f44c849838219cd] and [a99d69b1f85c62d8e116b31f496f73dffd75cab5], released in version 1.1.2.


External library import in utils - nuxt build bug or misuse?

Environment
On stackblitz:

Operating System: Linux
Node Version:     v18.18.0
Nuxt Version:     3.11.1
CLI Version:      3.11.0
Nitro Version:    2.9.4
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      devtools
Runtime Modules:  -
Build Modules:    -

On dev machine:

Operating System: Linux
Node Version:     v20.11.1
Nuxt Version:     3.11.1
CLI Version:      3.11.0
Nitro Version:    2.9.4
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      devtools
Runtime Modules:  -
Build Modules:    -

Reproduction
https://stackblitz.com/edit/github-qytiun?file=utils%2Fimport.ts
Describe the bug
I create a helper function in the utils folder. I use an external javascript package.
Code is working fine in dev environment, but when I generate the build and start it, there is an issue on server side, the library is not imported: "bigDecimal.add is not a function"
When I enforce the component to be client side only, build is OK, but I cannot use SSR for it.
Is it not the right way to import an external library and use custom functions based on it or a nuxt build issue (missing the import for the server side running code?).
Additional context
This bug is not linked to the new nuxt version. It was already there before v3.11.
I have read carefully the documentation here and did not found what I was doing wrong:
https://nuxt.com/docs/guide/directory-structure/utils
Logs
No response

Thanks a lot for your reply! Do you have any details that I can give to the lib maintainers on how to properly package it?

@danielroe Can you please guide us how to update the package so it can be used in Nuxt without transpile? Ran into the same issue with https://github.com/featurevisor/featurevisor/issues/269


Refactored netci.groovy. Closes #50. Closes #119.

Fixes #119.
Simplified trigger regexes; refactored dailyRegex to script-wide constant.
Closes #50.
Refactored style checks into a helper closure and call it once to produce each config.
Refactored build task generation to minimize duplication of code.

Hi @dilijev, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Doug Ilijev). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@dotnet-bot test ci please

@dotnet-bot test ci please

@dotnet-bot test ci please

@dotnet-bot test ci please

Looks like the refactor was a success. Rebased to a single commit on top of master.

@dotnet-bot test ci please


Fix typo v3 changelog

Congrats v3 release 🎉
This is a pull request to fix typo in changelog
ref: https://sphinx-revealjs.readthedocs.io/en/latest/directives/#directive-revealjs-section

Thank you for feedback!


Refactor submission entity

Refactor the submission, currently a component of competition run, to be a standalone entity

Not necessary anymore; changes in write logic should fix the issue we wanted to solve with this.


Obtain state from backend at the start of authorization flow

Issue
https://github.com/wso2/choreo/issues/11
Dependent PR
https://github.com/wso2/choreo/pull/195
Checklist

[ ] Unit tests
[x] Documentation
[ ] Updated release note

@tharinduwijewardane

Shall we document the implemented auth flow somewhere?
If we are not writing unit tests let's create a Github issue for tracking.

@tharinduwijewardane

Shall we document the implemented auth flow somewhere?
If we are not writing unit tests let's create a Github issue for tracking.

Added to checklist at https://github.com/wso2/choreo/issues/11
Will create separate issues upon closing the above


re2 is also on github, can it change to the github address?

Google can not be accessed in China. Can the re2 change to github address? The github address is https://github.com/google/re2 . I think they are the same.

See #21 , code added.

Thanks, I solved this differently (conditionally) in v1.7.5.


Fix benchmark reporting with subtitles of result key

I have to merge this reporting changes for me to test a proper benchmark reporting. Unfortunately GitHub Actions doesn't allow me to run this action without merging.

/run-benchmark-refresh

/run-benchmark

/run-benchmark


feat(GCS+gRPC): implement ListObjects()

Fixes #4197

This change is

Ping, in case folks missed this one.


Display the API backends catalog in base template

Related to #67, create a catalog route to display API catalog table in the API consumer template.
Definition of done:

[x] Connect table to the API backends collection.
[x] Add route to display table template within our base template.
[ ] Add the catalog link to navigation.

@brylie isn't this already done by @elnzv?
Take a look of ApiBackends in the navigation of /admin.
Am I misunderstanding something?

Created created /catalogue to which calls the template already created by @elnzv.
Waiting for the task # to finish in order to have a sidebar where to implement the link.

Changed estimation from 8 hours to 2.


Illogical sentence

Pretty sure I choose the name danger-yarn which I think this interpreted to be a case of you must have "danger-plugin" in your name.

Your generator must be inside a folder named danger-plugin-danger-yarn

I get it now, it checks if your folder is the same as the one as the name of your project ( so you can do upgrades) 👍


  For a ban in one chat

lol what? i am not real sog


Panoramic images do not show up on Safari

Issue is on Safari 6.0.1
The image shows up on the right. However, when clicking on the image, the presentation box comes up but the image fails to load.

Also happens on Safari Version 7.1.2 (95<IP_ADDRESS>)

First, WebGL is not turned on, by default, for Safari 6.
http://onvert.com/guides/enable-webgl-safari/
Open the Safari menu and select Preferences.
Then, click the Advanced tab in the Preferences window.
Then, at the bottom of the window, check the Show Develop menu in menu bar checkbox.
Then, open the Develop menu in the menu bar and select Enable WebGL.

It would be nice to detect when WebGL is not present and let the user know.

There is still an error preventing the image from appearing:
"THREE.WebGLRenderer: elementindex as unsigned integer not supported"

Just viewed a panoramic image in a Nunaliit atlas with Safari v. 11.1.2 (116<IP_ADDRESS>). Pan Image worked as expected. I believe this can be closed now.


add a restart command to the daemon protocol

refactor the flutter run --resident run option into a separate file (lib/src/run.dart)
move some tracing specific code into lib/src/commands/trace.dart
have the daemon app.start command use the --resident mode
ship all stdout from the running app over the daemon connection as app.log events
fix https://github.com/flutter/flutter/issues/4247

ping @jason-simmons / @abarth / @yjbanov / @Hixie for review. It's a big PR but totally important to making progress on the edit/refresh work :)

LGTM, but I don't feel very confident in my review.

It would be great if we only had the "resident" way of starting apps. Then if a command needs to quit it could simply close the connection and (optionally) shut down the app. There's some code duplication happening between flutter run --resident, flutter run --no-resident and flutter drive modes. Consequently, we have differences in functionality between these commands. For example, flutter drive does not pull down logs from the app.
Sketch:
AppInstance app = await AppInstance.start(startupOptions);
app.stdout; // returns Stream<List<int>>
app.stderr; // returns Stream<List<int>>
app.close(); // closes app
app.disconnect(); // closes connection
app.restart(); // restarts the app
app.observatory; // returns Observatory object
app.device; // returns Device object

However, LGTM, since this PR does improve things.

The logic for flutter run --no-resident is copied into the --resident mode. I'll add a TODO: to remove that; we can still support --no-resident with the code for resident.
The sketch above looks great. That would be a nice, high-level way to manipulate a running app.


Could not able to save the captured image to gallery using flutter_inappwebview

Are you sure

Yes I search same issue but I doesn't get any possible way to do along with this plugin


[HUDI-760]Remove Rolling Stat management from Hudi Writer

What is the purpose of the pull request
This pull request cleaned some rolling stat metadata's abandoned operation, when commit
and clean up related operations in unit tests
Brief change log

Remove Rolling Stat management from Hudi Writer

Verify this pull request
This pull request is already covered by existing tests, such as

TestHoodieClientOnCopyOnWriteStorage.java
TestHoodieMergeOnReadTable.java

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Codecov Report

Merging #1739 into master will decrease coverage by 0.25%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master    #1739      +/-   ##
============================================
- Coverage     18.14%   17.89%   -0.26%
+ Complexity      859      844      -15
============================================
  Files           352      352
  Lines         15414    15388      -26
  Branches       1526     1523       -3
============================================
- Hits           2797     2753      -44
- Misses        12259    12281      +22
+ Partials        358      354       -4

Impacted Files
Coverage Δ
Complexity Δ

.../table/action/commit/BaseCommitActionExecutor.java
47.27% <0.00%> (+1.25%)
14.00 <0.00> (ø)

.../apache/hudi/client/AbstractHoodieWriteClient.java
51.80% <100.00%> (-1.03%)
12.00 <1.00> (-1.00)

...e/hudi/common/model/HoodieRollingStatMetadata.java
0.00% <0.00%> (-46.16%)
0.00% <0.00%> (-7.00%)

...rg/apache/hudi/common/model/HoodieRollingStat.java
0.00% <0.00%> (-42.86%)
0.00% <0.00%> (-6.00%)

...i/common/table/timeline/HoodieDefaultTimeline.java
50.76% <0.00%> (-1.54%)
27.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 043eb56...a9e3ec3. Read the comment docs.

@baobaoyeye : can you fix the commit message (may be same as desc). I will merge once we you are done.

@nsivabalan fixed

@baobaoyeye : can you fix the commit message (may be same as desc). I will merge once we you are done.

fixed，thanks

@n3nash can you take a quick second pass here? and we can merge?

@baobaoyeye : Thanks a lot for contributing this PR. I have few minor suggestions in cleaning up the code further. Can you please address then and let us know. We will merge it then.
Good suggestion, fixed


Replicator: Precompute queries

The replicator creates some queries dynamically (example). These queries should be precomputed.

One small implementation note: currently, a single session.query() in the replicator will not always translate to a single prepared statement. A dynamic query will usually depend on some finite set of parameters (e.g. a column name), therefore instead of a single prepared statement we should probably keep a map of type parameters -> prepared statement. The map can be either initialized at the start of the replicator or its entries can be initialized lazily, whichever is easier.


Repo issue access for Tomislav

@jpitts @ligi please give @tomislavmamic access to manage issues
#45

invited him to the org - not yet sure in which teams to put him - Librarians?

@ligi I don't know how the Teams are defined. Whatever gives issue queue management.


Could not locate valid Java executable.

Working on getting started and I received a message from VSC that I needed Java.
So I installed it from here first and restarted
https://www.java.com/en/download/mac_download.jsp
and I received another message that it was still not installed so I installed a previous version from here
https://support.apple.com/kb/DL1572?locale=en_US
I'm still getting this message when I start VSC:

Could not locate valid Java executable. To configure Java manually, use the as3mxml.java.path setting.

Java 8 is the minimum version required. With that in mind, your second Apple link that installs Java 6 definitely will not work.
Open up Terminal and try running this command:
java -version

What happens?

It returns:
java version "1.6.0_65"
Java(TM) SE Runtime Environment (build 1.6.0_65-b14-468)
Java HotSpot(TM) 64-Bit Server VM (build 20.65-b04-468, mixed mode)
So should I go to the first link (version 8) and reinstall?

It should be possible for multiple versions of Java to be installed side by side. I'm not on Mac these days, but I seem to recall that there's a way to tell your system to use 1.8 or newer by default, even if an older version is also installed.
If you can't figure that out, then there are a couple of different ways to tell VSCode which version of Java to use.

VSCode checks the PATH and JAVA_HOME environment variables. You don't need to modify both, but one or the other should do the trick:

Update your PATH environment variable to Java's bin folder.
Set the JAVA_HOME environment variable to the root folder of your Java installation.

In VSCode's settings, set as3mxml.java.path to the absolute path of the java executable.

The versions of Java should be installed here, by the way: /Library/Java/JavaVirtualMachines/

In that directory I only see 1.6.0.jdk. Does it have to be the JDK or will JRE work?
When I run /usr/libexec/java_home -V I get this:

Matching Java Virtual Machines (2):
1.6.0_65-b14-468, x86_64:	"Java SE 6"	/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home
1.6.0_65-b14-468, i386:	"Java SE 6"	/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home

The error has gone away since installing the JDK from here Thanks

Does it have to be the JDK or will JRE work?

JRE is fine.

The error has gone away since installing the JDK from here Thanks

Great!

By the way, you may want to switch to OpenJDK, considering Oracle's recent license changes to their commercial version.
https://openjdk.java.net/install/


Add a Codacy badge to README.md

@nunogit, why did you close this one again? Should I consider this suggestion as withdrawn?


Binary protections

User story

As a user
I want / need to view the binary protections emba found for me

Acceptance criteria

5 pie charts need to be displayed in the dashboard.

Definition of done

Code review from peers has been completed and passed

Code is fully implemented and commented
Adheres to coding guidelines
Commits are not squashed
Code is checked into the repository

Unit tests for backend have been written and are passing
Manual performance tests on the browser are passing
No critical bugs are open

Subtask for #90

Closed on 7.7.2021


Fuzzing: Initial set up

This PR adds the initial set up for fuzzing of the source-controller.
It is currently work in progress that is being shared to allow for any feedback, comments or suggestions that anyone should have along the way. The files in this pull request will be modified.
There are 5 fuzzers available at this moment, and these are all built in the Dockerfile. They can be run when building the image, or they can be run in a Docker shell.
The 5 fuzzers are:
1: FuzzRandomGitFiles
Creates a git repository with pseudo-random files and dirs and instructs the git controller to reconcile.
2: FuzzGitResourceObject
Creates a GitRepository object with pseudo-random values and instructs the git controller to reconcile.
3: FuzzHelmchartController
Creates pseudo-random helm charts and instructs the controller to reconcile.
4: FuzzStorageArchive
Tests the storage archive util api.
5: FuzzStorageCopy
Tests the storage copy util api.
To run the fuzzers without a docker shell:
git clone https://github.com/AdamKorcz/source-controller --branch=fuzz1
cd source-controller/fuzzing
# Now uncomment either of the fuzzers in the bottom of the Dockerfile
sudo docker build . --tag flux-fuzzing-image

The fuzzers will now build and the selected fuzzer will run.
To run the fuzzers in a docker shell:
git clone https://github.com/AdamKorcz/source-controller --branch=fuzz1
cd source-controller/fuzzing
sudo docker build . --tag flux-fuzzing-image
sudo docker run -it flux-fuzzing-image
cd controllers
/fuzzers/$FUZZER_NAME

The fuzzer will now run.

Superseded by #572


asset_management test case hasn't been moved to new chaincode interface

fabric/examples/chaincode/go/asset_management/asset_management.go should implement Init and Invoke methods

move "init" code from Run into Init method
rename Run to Invoke

will also create an issue to move asset_management from examples/... to another directory (probably chaincode) so we could have caught this sooner.

issue #1039 created for moving asset_management_test.go to chaincode/ folder

Fixed via PR #1050