Large amounts of files missing

I've installed iCloud control panel in a Windows 7 VM and kicked off a download of all files and to separate them into folders by year.
I've set icloud_photos_downloader to download using --folder-structure={:%Y} so that it also downloads to different folders based on the year.
I would expect to see both folders identical contents. Instead I see a large amounts missing files, on both sides: https://i.imgur.com/VZDRoQp.png

I've cleaned everything out and re-run the downloads to test again... It's more complete as in ti's only missing a handful of files this time around, but it's still not got them all. Oddly, it has downloaded some that the iCloud downloader hasn't:
https://i.imgur.com/eWBUTPk.png
https://i.imgur.com/CnEVppt.png

Hi, sorry I didn't respond to this issue earlier. I've made a few changes to the code so that it now uses the "fingerprint" if a filename was missing. That might solve some of the missing files.
But yes this is something I do need to check. I think I will use the Photos app to download all of my photos to my Mac, and then compare the results with the script.

Hi,
I've spent months and months on this issue, not just with this tool but others (including iCloud for windows).
The issue is due to duplicates that get stored in iCloud. I have 43,000 photos and after exporting using iCloud, Photos for Mac or this tool I end up short of 3,000.
This photos downloader python script allowed me to identify the issue and I made a lot of changes to it to test.
I believe the duplicates happen mostly because the device does not get confirmation the photo uploaded and therefore does it again so duplicates appear in iCloud.
But the issue really is a problem when exporting, because tools store the same duplicate photo on the local filesystem in the same folder and obviously cannot have the same filename.
I modified the code to actually add a random number at the end if the file already exists. I now have a much better photo count between this and iCloud.
Obviously we do not care about duplicates, but I would be more comfortable comparing these photos manually than assuming its a duplicate because the filename is the same.
My modified code only works on a single run, if the script ends or exits you need to delete all the photos and start again but I did it to troubleshoot the issue.
Not sure how this can be done for an enhancement - my only suggestion could be to have a new parameter "allow-duplicates" and add the current photo number to the end of each filename?

https://github.com/ndbroadbent/icloud_photos_downloader/pull/160 uses size in addition to names when comparing assets (and created duplicates with different names). Should solve the problem of duplicate names (in most/many cases).

Could you please recheck if this issue is still valid with the current version (and changes for the handling of duplicates)? @boredazfcuk @realtek2017

I don't actually run the Windows iCloud control panel to run a comparison any more. I'll need to build a VM and install it to test. Struggling for time at the minute due to work commitments, hopefully I'll be able to look at it later in the week.
I think I'm still seeing issues with duplicates in my Docker container however. I have a function that creates a list of files on the server using the --only-print-filenames option. It then checks if each file exists on disk and if it does, deletes the entry from the list. At the end of the function, if there are still lines left in the list, my script knows there are files that need to be downloaded and moves to the download phase. This prevents it from attempting to download files every single time it runs. I did this to help combat the Apple API throttling issue.
This is the function in question:
https://github.com/boredazfcuk/docker-icloudpd/blob/f5475afa2006079041e37f73ad06c3161f6eeacc/sync-icloud.sh#L272
Looking at the logs for the three Apple IDs that I sync, it seems that it's only detecting duplicate .MOV files. I have noticed the log has entries for some pictures that have a notification about being de-duplicated... Maybe the de-dupe code only applies to HEIC/JPEG/PNG files?

@boredazfcuk de-dup works on all files types. One caveat though: if you choose to set exif dates for images, then file size will be different and subsequent runs may identify existing file as a duplicate. Example:

you have only one file abc.jpg in your collection with the size 1024bytes without exif
first run: downloaded abc.jpg 1024bytes; updated its exif and now size on disk is 1100bytes.
second run: tools checks that file abc.jpg exists, but its size is different (1100bytes) than in iCloud (1024bytes), so tool downloads same file again with name abc-1024.jpg and changes its exif; size of the abc-1024.jpg on disk is 1100bytes now too.
third run: abc.jpg exists, so tool checks abc-1024.jpg, which exists, to the tool considers as existing and passes to the next (existing in the case of this example)

Maybe the issue I see is unrelated to de-dupe then... but I find that the script always detects certain files need downloading. This is the log output from my container: https://pastebin.com/QB1zy4Z9
As you can see, it detects the same 10 files requiring download, even though they already exist on the disk.
I've just logged on to iCloud.com and can see that these 10 files are actually ten "live photos" that are in the photo stream... I only have 10 live photos too, so I can't imagine that's just a coincidence.

So I've built a Win10 VM this morning, installed iCloud Control Panel and synchronised my photo stream. It downloaded 839 images.
I then created new icloudpd container, kicked off a download, and it's downloaded 838 images.
For reference, my phone's "recents" album also shows a file count of 838.
I've created two file lists and used WinMerge to compare the differences in the file lists. This is my conclusion on the file list comparison:
iCloudPD downloads HEIC whereas iCloudCP downloads JPEG files. A quick search/replace meant that there were only 13 lines with differences.
10 of those differences were photos taken in my Telegram app (which prefixes files with camphoto_ and has a habit of duplicating file names). These 10 file were successfully de-duped. They were showing as camphoto_(1).jpg camphoto_(2).jpg etc in my Photo Stream, but as camphoto_*-<file_size>.jpg... All good.
That left 4 other differences. The first was a file that iCloudPD had downloaded as:
IMG_1231-2545351.HEIC
IMG_1231.HEIC

However, only a single file IMG_1231.JPEG exists in iCloudCP,
I've attempted to open the IMG_1231.HEIC file and it is appears corrupt. Possibly, the file has failed to download correctly (my first download run did crash midway), so the second run has then de-duped the file, rather than overwrite the corrupt file.
The final two differences were two files that existed in my Photo Stream that iCloudPD just doesn't detect:
IMG_0924.JPG
IMG_0925.JPG

Bizarrely, neither of these files can be seen when looking at my photos using icloud.com, they cannot be seen on my iPhone either. They are not in 'recently deleted' and I don't use named albums (apart from the automatically created WhatsApp album). Both of these pictures are non-photos (possibly taken when I was fumbling my phone out of my pocket or something) so I presume they were deleted long ago, but are still somehow stuck in the system.

This is far more accurate than what I was originally finding when I opened this ticket. I think the de-dupe feature is what has (more or less) corrected the disparity.

Thanks for your detailed analysis! Its really weird with these two files... But from how I read your post you think the program behaves correctly now?
Do you have any more details regrading the crashed download?

The bizarre thing is that the files now appear in my Photos app. They absolutely, definitely weren't were not there to begin with. They are two additional pictures from a "shoot" which had 5 pictures. I now have 7 pictures in that "shoot"
I didn't note the error unfortunately. I was running a dev version of my container, in which I'd inadvertently removed some Python dependencies. I moved from specifying all the Python dependencies in my Dockerfile to installing them using the requirements.txt file from icloud_photos_downloader. This meant I was no longer installing:
certifi pytz tzlocal six chardet idna urllib3 future keyrings.alt==1.0 keyring==8.0

I readded these, rebuilt my container, and it hasn't crashed in any of the other tests I've done tonight..

I've attempted to open the IMG_1231.HEIC file and it is appears corrupt. Possibly, the file has failed to download correctly (my first download run did crash midway), so the second run has then de-duped the file, rather than overwrite the corrupt file.

@boredazfcuk icloudpd 1.6.1+ downloads file to temp one (.part suffix) and then renames to final destination only once downloading completes successfully. I cannot come up to the scenario when file will appear corrupted as a result of program termination.

I didn't note the error unfortunately. I was running a dev version of my container, in which I'd inadvertently removed some Python dependencies. I moved from specifying all the Python dependencies in my Dockerfile to installing them using the requirements.txt file from icloud_photos_downloader. This meant I was no longer installing:
certifi pytz tzlocal six chardet idna urllib3 future keyrings.alt==1.0 keyring==8.0

I readded these, rebuilt my container, and it hasn't crashed in any of the other tests I've done tonight..

Dockerfile in icloudpd builds container from python image. I found at least one case (albumNameEnc error, I haven't followed up yet) when alpine-based image was not behaving, while python-based one worked. See if that python-based fat image will be better for troubleshooting functionality of icloudpd itself.

@boredazfcuk icloudpd 1.6.1+ downloads file to temp one (.part suffix) and then renames to final destination only once downloading completes successfully. I cannot come up to the scenario when file will appear corrupted as a result of program termination.

I deleted the corrupt file, re-ran the script, and the copy it downloaded in the 2nd run was fine. I'll just put it down to a transient issue.

Dockerfile in icloudpd builds container from python image. I found at least one case (albumNameEnc error, I haven't followed up yet) when alpine-based image was not behaving, while python-based one worked. See if that python-based fat image will be better for troubleshooting functionality of icloudpd itself.

Odd, I've not experienced any issues with the Alpine images I've been maintaining (since 3.10). My container notifies me of downloads, deleted files & non-zero exit codes, plus I have three Apple IDs that I sync. So I'm fairly certain that if it were to have an error, it wouldn't be missed and I'd pick up on it fairly quickly...
Someone did raise the albumNameEnc error against my container (https://github.com/boredazfcuk/docker-icloudpd/issues/21), and I was seeing the issue myself for a short while, so I just created a diff from the patch and built my Dockerfile with that until the PR was merged. The albumNameEnc patch has been working for me since early September.

Based on the discussion, original issue (missing files) has been resolved with 1.6.1 version of the icloudpd. Closing.


0.1.1 bug: printf doesnt handle u2 .. u7

This tiny program fails:
const io = @import("std").io;

pub fn main() -> %void {
  var x : u3 = 1;
  %%io.stdout.printf("{}\n", x);
}

with quite confusing error:
O:\zig0.1.1>zig build-exe b.zig
O:\zig0.1.1\lib\zig\std\fmt\index.zig:322:11: error: expected type 'u3', found 'u8'
        a /= base;
          ^
O:\zig0.1.1\lib\zig\std\fmt\index.zig:282:33: note: called from here
        return formatIntUnsigned(value, base, uppercase, width, context, output);
                                ^
O:\zig0.1.1\lib\zig\std\fmt\index.zig:180:29: note: called from here
            return formatInt(value, 10, false, 0, context, output);
                            ^
O:\zig0.1.1\lib\zig\std\fmt\index.zig:61:37: note: called from here
                    if (!formatValue(args[next_arg], context, output))
                                    ^
O:\zig0.1.1\lib\zig\std\io.zig:154:23: note: called from here
        _ = fmt.format(&context, printOutput, format, args);
                      ^
O:\zig0.1.1\lib\zig\std\io.zig:144:27: note: called from here
        %return self.print(format, args);
                          ^
O:\zig0.1.1\b.zig:5:21: note: called from here
  %%io.stdout.printf("{}\n", x);

In addition, when I change x variable type to i2 ... i7, compiler errors still keeps talking about unsigneds.
Types like u8, u16, i8 etc work as expected.

Why is the error confusing, it even gives you a stack trace? You can look at the source yourself since this is user level code....
fn formatIntUnsigned(value: var, base: u8, uppercase: bool, width: usize,     context: var, output: fn(@typeOf(context), []const u8)->bool) -> bool
So base is defined as a u8. As the error message states, you can't divide a u3 by a u8. How would you fix this?


Rule without initial condition raises problem with generate_network()

Hello everyone,
I found a weird problem when calling the generate_network(). I declared a non-reversible rule, but I didn't set an initial condition for the LHS (meaning the rule could never execute). Then, I called generate_network() and the error was:
---------------------------------------------------------------------------
BngInterfaceError                         Traceback (most recent call last)
<ipython-input-5-a23f3307d273> in <module>
      1 set_path('bng', '/shared/D1/opt/git-repositories/bionetgen.RuleWorld/bng2/')
----> 2 generate_network(model)
      3 generate_equations(model)
      4 sim_result = ScipyOdeSimulator(model, linspace(0, 40, 100)).run()

/usr/local/lib/python3.6/dist-packages/pysb/bng.py in generate_network(model, cleanup, append_stdout, verbose, **kwargs)
    669         bngfile.action('generate_network', overwrite=True,
    670                        verbose=bng_action_debug, **kwargs)
--> 671         bngfile.execute()
    672
    673         output = bngfile.read_netfile()

/usr/local/lib/python3.6/dist-packages/pysb/bng.py in execute(self, reload_netfile, skip_file_actions)
    484         if p.returncode or captured_error_lines:
    485             raise BngInterfaceError('\n'.join(captured_error_lines) + "\n" +
--> 486                                     p_err.rstrip())
    487
    488     def action(self, action, **kwargs):

BngInterfaceError:
ABORT: writeFile() was asked to write the network, but no reactions were found.
Did you remember to call generate_network() before writing network output?

  at line 28

The generate_network() works as expected when I make reversible the reaction (because I declared an initial amount for the RHS).
I don't know if there's a way to make more informative the error message. At least, I didn't forget to call generate_network()...
Best regards

Hi @glucksfall. The error message that you're seeing is actually coming from BNG, not PySB. So it's not the same generate_network() method. As I think you've figured out, the problem you're having is because you don't have any Initials (seed species in BNG language) defined, so BNG isn't generating any reactions. When it tries to output the network to file (which PySB will then read in), there's nothing there so it throws the error message you're seeing. I understand that the error message is a bit confusing because not calling generate_network() is not the problem. I've modified the error message in the BNG code to read:
"writeFile() was asked to write the network, but no reactions were found.\n"                   ."Did you remember to call generate_network() or to define seed species before writing network output?\n";
(You can see the change here: https://github.com/RuleWorld/bionetgen/commit/926cee296b7550617a8bdeda410bd2d247c1fa30)
It may take some time for the next BNG release to come out with that change but at least you know what the issue is now. Thanks for raising it with us, it helps a lot to know what issues users are running into. If you have any questions, just let me know. --Leonard


License ?

Just wanted to clarify under what license is this project released under ?

Hi, we have added a Apache 2.0 license file to the repo.


Feature request: Resize while uploading

Awesome work so far! just installed and works like a charm =)
May it be possible (or is it already available?) that images will be resized during upload to a ratio like 1024x768?
Main purpose is that in many forums it is only allowed to embed photos with a max. size of 1024x768
Thanks for the support

Lychee scales big photos down so they fit into 1920x1080 (when ImageMagick is installed). You can change the values in the code, but I can't provide any help for customization.
It's not planned to generate more sizes on upload, sorry.


Measuring invocation latency

Hi!
I've been trying to execute simple functions with nightcore. To that end, I followed the installation instructions, and I modified the example of a function to even a simpler one:
int faas_func_call(void* worker_handle, const char* input, size_t input_length) {
    struct worker_context* context = (struct worker_context*)worker_handle;
    context->append_output_fn(context->caller_context, input, input_length);
    return 0;
}

[
    { "funcName": "Foo", "funcId": 1, "minWorkers": 1, "maxWorkers": 1 }
]

When deploying the controller and engine on one server, and using curl to send POST requests from another server, I measure latencies around ~100ms. The TCP/IP RTT between both machines is ~12us. When I increase the size of input JSON, the RTT quickly increases to over a second for an invocation on a 1 kB message. On the same cluster of machines, we've been able to deploy OpenWhisk and execute functions with a 1 kB payload with a latency of around ~100ms.
Is there are any other way to invoke nightcore functions that don't involve such high latencies? Is there a potential problem in our deployment that might cause such high latencies? Is there documentation on optimizing deployments?

Could you try adding "--v=1" to the command lines of gateway, engine, and launcher, which enables verbose logging?
Verbose logging might provide some information into which contributes to 100ms latency.

@zhipeng-jia Thanks for a swift reply!
I noticed that the default run_stack.sh script already had the verbose logging enabled. After disabling it, the latency dropped to ~60ms. Please find attached the logs for 100 executions with verbose logging (again, latency ~100ms).
engine.log
Foo_worker_0.stderr.log
gateway.log
launcher_foo.log

Thanks for the log. It provides some useful information.
Looks like the problem is here:
I0523 14:00:55.934223 IO-0/EL  http_connection.cpp:283] HttpConnection[0]: Parse new HTTP header: Expect = 100-continue
I0523 14:00:56.935250 IO-0/EL  http_connection.cpp:254] HttpConnection[0]: Start parsing URL: /function/Foo

These two lines have a duration of 1 second. The first line is the moment of parsing the last HTTP header, while the second line is the moment that the full HTTP request is received (see https://github.com/ut-osa/nightcore/blob/asplos-release/src/gateway/http_connection.cpp#L254). When the full request is received, the gateway then sends the function call to engine.
I am not sure what causes here to consume 1 second.  I am also not familiar with curl's C APIs, but I do not see obvious problems from the client code that you show.

After searching around, I guess the "Expect: 100-continue" (https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Expect) may cause the problem. I do not implement the required logic for handling expect header, i.e. sending response before receiving HTTP body.
Here is what I found how to disable it for libcurl: https://stackoverflow.com/questions/49670008/how-to-disable-expect-100-continue-in-libcurl

@zhipeng-jia Thanks for your help! Now it seems to work. We get ~150 us for 1 kB messages and 20ms for 5 MB messages.
I'm closing the issue as this has been resolved.

Good to know!

@zhipeng-jia Hi! I have one more question - I'm trying to measure the speedups achieved by integrating nighcore. I want to dispatch between 8 and 32 functions to the same instance.
Besides changing the JSON configuration file with the minimal and maximal number of workers, is there anything else that I should pay attention to? I'm going to run C/C++ functions.

If you're going to measure under a fixed concurrency, setting both max_worker and min_worker to the desired concurrency will work.

@zhipeng-jia Thanks so much! And just to verify: are the POST requests the only way of invoking nightcore functions externally? I'm asking because we have to transmit some floating-point numbers, and maybe there's a way of skipping float->string->float serializations.

I have also implemented gRPC transport, but needs more setup and not tested extensively.
If it does not cause real problems, I'd suggest use HTTP POST.


Adjust awaiting execution status check

What it solves
Resolves #3280
How this PR fixes it
The status checking logic was fixed to compare it against both AWAITING_EXECUTION AND PENDING_FAILED.
How to test it

Create a transaction on a 2/? threshold Safe
Observe that the action button is 'Confirm', not 'Execute'

Screenshots

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
6 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.003%) to 32.417%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/routes/safe/components/Transactions/TxList/TxCollapsedActions.tsx
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/routes/safe/components/Transactions/TxList/TxExpandedActions.tsx
6
4.17%

Totals

Change from base Build<PHONE_NUMBER>:
-0.003%

Covered Lines:
3113

Relevant Lines:
8554

💛  - Coveralls

@francovenica in #3259, did you test failing txns?

I'm struggling to understand the semantics now.

I've updated the logic and it should work as intended now.

@DiogoSoaress before sending this to QA, I'd like you to test it.
The following cases:

Tx is awaiting execution and no local status is set
Tx is pending confirmations
Tx is failed (PENDING_FAILED) and can be re-executed
Tx has all confirmations and has a local status PENDING (it should be ignored)

The cases seem all consistent now

When rejecting the execution in Metamask, the copy should still be "Needs execution".

When rejecting the execution in Metamask, the copy should still be "Needs execution".

For future reference: we discussed this in a call and it was tackled in another PR so as to not polute this one.

When rejecting the execution in Metamask, the copy should still be "Needs execution".

This issue got its own PR -> https://github.com/gnosis/safe-react/pull/3287

The confirm button is fine now:


Confusing messages if wrong version of Lean vscode extension used.

If I open a Lean 4 project in vscode and forget to deactivate the lean 3 extension. The output window pops open with a message Watchdog error: Cannot read LSP request: Invalid header field: .... I've also observed panics in some cases.
This is happening because the Lean 4 server is receiving Lean 3 language server messages.
I think that the user experience could be greatly improved by having both the vscode lean 3 extension and lean 4 be aware of the other protocol and send a friendly message to the user saying that they are using the wrong extension.

It is actually completely supported to have both extensions installed and activated at the same time.  I have both installed and it automatically picks the right one depending on the project.  Can you give some more info on how to reproduce this bug?


Backported hotfixes done for prod issues

core/src/main/java/org/gflogger/GFLoggerBuilder.java: Fluent interface changes have broken xml confihguration, reverted it.
core/src/main/java/org/gflogger/appender/DailyRollingFileAppender.java: File.renameTo failed to move file in some cases. Paths.move solved the issue
slf4j-adapter/src/main/java/org/gflogger/slf4j/Slf4jLoggerImpl.java adjust pattern didn't work if user wanted to log error as object for some reason

Could you please split pull request into several:

formatting, typos etc
valuable change like using Files.move
I don't see Slf4JLoggingStrategy in this pull request

TA


ACA-Py Admin API requiring JSON data for credential preview on issue and store when cred_ex_id is already given.

Issue
Using the issue and store operations on the ACA-Py admin API, one would expect that the credential preview or any other credential data is not needed to pass to the operation. This is because the protocol has already been established by the send-offer, and the credential can then be referenced with the credential exchange id (cred_ex_id).  The issue operation requires a full credential_preview including attributes. This is unnecessary. The store operation requires the cred_exl_id in the JSON body, even though that id is already sent as part of the URL.
Steps to Reproduce
Scenario: Issue a credential with the Holder beginning with a proposal
    Given "2" agents
      | name  | role   |
      | Acme  | issuer |
      | Bob   | holder |
    And "Acme" and "Bob" have an existing connection
    When "Bob" proposes a credential to "Acme"
    And "Acme" offers a credential
    And "Bob" requests the credential
    And "Acme" issues the credential <- uses "issue" operation
    And "Bob" acknowledges the credential issue <- uses "store" operation
    Then "Bob" has the credential issued

Outcome
Operation is successful but data not needed.
When debugging a test because of a problem, having that JSON data as part of the call just adds one more variable to the possible issues for debugging. Removing the JSON would make debugging easier.
Implementation would also be easier not having to construct that JSON body.
Expected Outcome
Operations successful without any JSON body, and just the cred_ex_id on the URL.
Workaround
Pass in the JSON data as the API expects.
Test Cases Affected
T001-API10-RFC0036, T002-API10-RFC0036, T003-API10-RFC0036, T004-API10-RFC0036
Severity
Low
Business Priority
Medium

@swcurran Added this issue, but I don't have the privileges to add a bug or enhancement tags.

I can take this.

Thanks @sklump. I think the it should be possible to pass the data on this, just not required.  Is that how you see it?

No: the credential values are necessarily what was on offer or else a bait-and-switch is possible from a shady issuer.

Since we now (correctly) insist on putting them in the offer, we should have removed them at that time from the issue. Clear?

I'm going to post to the community about.  The scenario I worry about is if/when we support other than Indy credentials that we'll need the data back.

Sure, at that time we can add it in as an option.

I expect that will be in about half a world war, and by then we will not be on v1.0 of the protocol.

https://github.com/hyperledger/aries-cloudagent-python/pull/596


Execute does not setup properly setup hot reloading

The method startup with the following signature
  Execute(string configFile, string outputFileName, WebpackDevServerOptions devServerOptions)
Does not supply the correct arguments to  webpack-dev-server to enable hot reloading.  Other methods invoke GetWebpackArguments to properly append the Hot Reload arguments

Ok probably the documentation is not clear enough regarding this. When you use the UseWebpack extension method and pass as an argument a configuration file then it's up to you to set up the hot reloading in that configuration file. You need to supply the dev server option, that should be the same as in the external configuration file, to that method in order the middleware to inject the correct script tag into the html file. Is it more clear now?
Here you can see an example configuration file that has hot reloading enabled.
Please let me know if this helps you.

I think we can make this better. Since the we can read the config we can bypass a lot of steps for the end user.

I agree and tried to read and parse a webpack config file but it's relatively hard as there are too many combinations. My idea is to provide transparency to the user for webpack configuration in order to have an easy beginning but after a certain point and especially for complex and advance scenario an external configuration file is required I think.

I didn't know that would work because I think the documentation says the "hot" property isn't vaild? I'm new to this and probably just wrong, for some reason I didn't think you could specify "hot inline" through a config.

Wow looking back I see how tot do it correctly. Sorry about that I just have a bad config.


Adjust XHR::send string to match recording length.

For RUN-1964 (https://linear.app/replay/issue/RUN-1964/force-xhrsend-string-to-match-lengths-by-recordreplaying-value)
Bucket issue RUN-1350

Landing because last revision passed all tests, and the changes are just to adjust header position, which is trivial. (famous last words)


Update Versions

This branch is a simple version bump of the following components:

Ruby:        3.1.2 -> 3.1.4
Rails:       <IP_ADDRESS> -> 7.0.8
Rails Admin: 3.1.1 -> 3.1.2
Node:        18.12.0 -> 18.19.0
Postgres:    12.9 -> 14.10
Yarn:        1.22.17 -> 1.22.19

Additionally, redis 7.2.3 has been added to the .tool-versions file, so asdf will install and use the version specified in this file.
There is also an entry in the .gitignore, as I tend to use database clusters local to the project in development, to keep projects together as one.  If this is something you're open to in this project more globally, let me know and I'll submit a PR that allows users to do this, otherwise feel free to remove that change.

Thanks @CodingMomentum , changes LGTM 💯

If this is something you're open to in this project more globally, let me know and I'll submit a PR that allows users to do this

Definitely open to this if it doesn't interfere with a setup that doesn't use a local db file


Update calling "prompt the user to choose"

FYI, we just added support for an allowMultiple boolean for "prompt the user to choose": https://wicg.github.io/local-font-access/#ref-for-dfn-prompt-the-user-to-choose
https://wicg.github.io/local-font-access/#ref-for-dfn-prompt-the-user-to-choose could be updated to take advantage.

@miketaylr I think you intended the first link to be to another spec or algorithm - can you point me in the right direction?

Oh, probably https://w3c.github.io/permissions/#dfn-prompt-the-user-to-choose

Oh, probably https://w3c.github.io/permissions/#dfn-prompt-the-user-to-choose

Whoops - sorry for the bad links. That's the one.


Send query parameters in addition to path in middlewares

Codecov Report

Merging #9 (cad7bc9) into master (f790686) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master        #9   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines           52        58    +6
  Branches         7         9    +2
=========================================
+ Hits            52        58    +6

Impacted Files
Coverage Δ

packages/core/src/index.ts
100.00% <100.00%> (ø)

packages/express/src/index.ts
100.00% <100.00%> (ø)

packages/next/src/index.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f790686...cad7bc9. Read the comment docs.


Long accordion titles wrapping on a second line are not left justified

Long accordion titles wrapping on a second line are not left justified
Detailed description

Describe in detail the issue you're having.
When accordion title doesn't fit on one line, it is centered instead of being left justified

Is this issue related to a specific component?
Accordion

What did you expect to happen? What happened instead? What would you like to see changed?
Expecting all titles to be left justified

What browser are you working in?
Chrome

What version of the Carbon Design System are you using?
carbon-components 9.46.1
carbon-components-react 6.46.3

What offering/product do you work on? Any pressing ship or release dates we should be aware of?
IBM Cloud console

Steps to reproduce the issue

Create accordion with longer item titles
Resize window until title doesn't fit and wraps on a second line

Additional information

cc @IBM/carbon-designers what's the intended spec here for text truncation in an accordion title?

Text should definitely be left aligned.
In that example I would expect the row's height to increase so the second line of text isn't cropped. I'm not sure if that's part of the question though.

Can the left alignment be fixed soon? We're going to production on Nov 19th.


Are there plans to provide pre-built OpenH264 binaries for Arm64 / aarch64 Linux?

There's already support for Arm64 + Neon and aarch64 binary releases for Android & iOS, the Mozilla folks have built aarch64 for Windows 10 on Arm. Are there plans to offer Linux aarch64 binaries?
If not are there specific blockers that need to be addressed to enable the generation of aarch64 Linux binaries?

could you suggest the desired building instructions to get this binary? thx

I believe the build flags all exist and if you build on an Arm64 platform it will generate the appropriate binary. This should be possible by adding an Arm64 build to the TravisCI job using their Alpha feature that provides multi-architecture builds for open source projects - see: Building on Multiple CPU Architectures

@sijchen I had no problem building the project on an Graviton2 instance simply by running make after installing the required dependencies on Ubuntu 16.04 Xenial and a shared-object like you release for x86 was created.  I assume it would also build on newer versions of Ubuntu, but haven't tried.
All the unit tests also passed along with binary comparisons on Adobe_PDF_sample_a_1024x768_50Frms and BA_MW_D.264. The binary comparison on Zhling_1280x720.264 seems to be failing.

I have a keen interest in the outcome of this effort. I can help with testing the binaries.

@sijchen Any updates from your debug of the unit test failure mentioned above?

This issue has been resolved and Arm64 Linux binaries are now available as of the v2.1.1 release - see: https://github.com/cisco/openh264/releases/tag/v2.1.1


feat(ktableview): add bulk actions feature [KHCP-13106]

Summary
Jira: https://konghq.atlassian.net/browse/KHCP-13106
Adds bulk actions functionality in KTableView:

new bulkActions reserved header for enabling bulk actions column
new rowBulkAction prop
new bulk-action-items slot
new bulk-actions-select emitted event

The functionality looks good. I just have a couple of questions:
It seems we can bulk select across different pages, but I’m not sure if this is best practice. (I’m okay with it if it’s a widely used pattern.) Personally, I tend to only select what I can see to avoid unnecessary mistakes.
Additionally, how does this work with cursor pagination, where we (FE) might not store the previous or next page data?

The functionality looks good. I just have a couple of questions:
It seems we can bulk select across different pages, but I’m not sure if this is best practice. (I’m okay with it if it’s a widely used pattern.) Personally, I tend to only select what I can see to avoid unnecessary mistakes.
Additionally, how does this work with cursor pagination, where we (FE) might not store the previous or next page data?

We had a long discussion about this in our team (unfortunately it was on an unrecorded call so I can't link you back to it) and decided that it bulk actions should work with pagination as it seems to be a common practice many services follow (Gmail and DataDog were among the few we reviewed).
As to how this works with cursor pagination - KTableView actually doesn't know any other data other than what's provided in data prop so how it works under the hood is it stores all selected rows in a separate ref. When user navigates through pagination pages, it checks whether any of the objects provided through data prop are in the selected items array. You can test that behaviour in the sandbox: https://deploy-preview-2365--kongponents-sandbox.netlify.app/#/table-view (go to the table at the very bottom).


Add fall detection example

Why this change?
Add fall detection example
What does this PR include?
Fall detection example with associated human keypoints detector and pose estimator
User API changes
None
New dependencies included
None

Add description of query output, i.e the json file

Add readme

Move files other than main.py to a subfolder

We can add docs for example in new PR


Issue compiling bootstrap gradient mixins

I call Bootstrap 3x gradient mixins in my LESS such as:
#gradient > .striped(#ddd);
or:
#gradient > .radial( darken(@mv-lightGrey, 18%), @mv-lightGrey);
These will cause CLESSC to fail with:
loading-bar.less: Line 95, Column 6 Parse Error: Found "#gradient > .striped(#ddd)" when expecting variable, mixin or declaration.

I've fixed the bug. It should work now.

Confirmed, now compiles perfectly.


Create Pull Request Template

Docs Build status updates of commit e448eec:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.github/PULL_REQUEST_TEMPLATE.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit d1d33d2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.github/PULL_REQUEST_TEMPLATE.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit a08aa17:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.github/PULL_REQUEST_TEMPLATE.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit c8ab0c5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.github/PULL_REQUEST_TEMPLATE.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 2e3388f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.github/PULL_REQUEST_TEMPLATE.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit ca40f6c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.github/PULL_REQUEST_TEMPLATE.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 2df2e04:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.github/PULL_REQUEST_TEMPLATE.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@michael-hawker Thanks for the looking into the PR and providing feedback. I have updated the PR now. Let me know what you think 🙂

Docs Build status updates of commit f147be5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.github/PULL_REQUEST_TEMPLATE.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thanks Michael! looks good now.

Docs Build status updates of commit 8fbceaf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.github/PULL_REQUEST_TEMPLATE.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Feature request: descriptors as ascii strings

Any possibility to get the string descriptors in ascii text like lsusb -v does:
...
  iManufacturer           1 FTDI
  iProduct                2 FT232R USB UART
  iSerial                 3 A2001nh5
  bNumConfigurations      1
...

From what I can understand from this thread lsusb is using libusb_get_string_descriptor_ascii

Could someone share an example? Easily with controlTransfer is a bit of a understatement as it requires 5 arguments, which are not exactly intuitively named.

( I see you did add this convenience function getStringDescriptor in: https://github.com/tessel/node-usb/commit/7f6939fd42c19e91a4e4864202942e74d3568038 )


Run error:surfelwarp/common/algorithm_types.h:85

hello，I encountered a Error after running /surfelwarp_app /path/to/config
wya@wya:~/project/SW/surfelwarp/build/apps/surfelwarp_app$ ./surfelwarp_app /path/to/config
Error: 	/home/wya/project/SW/surfelwarp/common/algorithm_types.h:85

algorithm_types.h:85:cudaSafeCall(cudaMalloc((void**)(&m_device_num_selected),sizeof(int)));
My computer graphics card is GTX1070 , I used the cuda10.0 and cilantro, so I set the cuda_arch=61 as follows:
I have modified the CMakeLists:
# Cuda
find_package(CUDA 10 REQUIRED)
include_directories(${CUDA_INCLUDE_DIRS})
set(CUDA_NVCC_FLAGS "${CUDA_NVCC_FLAGS} -arch=sm_61")
set(CUDA_NVCC_FLAGS "${CUDA_NVCC_FLAGS} -gencode=arch=compute_61,code=sm_61")
set(CUDA_NVCC_FLAGS "${CUDA_NVCC_FLAGS} -gencode=arch=compute_61,code=compute_61")

# Point cloud library and a series / cilantro

set(cilantro_DIR "../../cilantro/install_static")
find_package(cilantro REQUIRED)
include_directories(${cilantro_INCLUDE_DIRS})
add_definitions(-DWITH_CILANTRO)

This is my cmake information:
-- The C compiler identification is GNU 6.5.0
-- The CXX compiler identification is GNU 6.5.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc - works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ - works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Found CUDA: /usr/local/cuda (found suitable version "10.0", minimum required is "10")
-- Found OpenMP_C: -fopenmp (found version "4.5")
-- Found OpenMP_CXX: -fopenmp (found version "4.5")
-- Found OpenMP: TRUE (found version "4.5")
-- Found Boost: /usr/include (found version "1.58.0") found components: system filesystem
-- Configuring done
-- Generating done
-- Build files have been written to: /home/wya/project/SW/surfelwarp/cmake-build-debug

Have you encountered this problem?

I would recommend you try a simple program with cudaMalloc and cudaSafeCall, using exactly the cuda setup you mentioned to see if the environment is setup correctly.

My solution:I used ubuntu16.04 before, and its adapted GTX1070 GPU driver is 390, but cuda10.0 needs 410 or more, So I switched to ubuntu18.04, and it can run with its adapted GPU driver 450.


image: always set filename for bootc raw pipeline

In BIB, we intend to export multiple images from the same pipeline and this is the expected filename for the raw images.  Set it so that it's always disk.raw even when we're building a qcow2 or other image type.

The comment (and commit message) is a bit wrong.  We're not exporting from the same pipeline but from the same manifest.  It's probably fine though.


validate sitenames, validate config during init, fixes #86

The Problem:
#86 OP we currently accept site names allowing any/all characters. This doesn't work out so well for domain names, and attempting to start a site whose sitename contains invalid characters for a domain will result in the site failing to start.
The Fix:
This PR introduces validation of the site name value. Site names will now be validated as hostnames per RFC 1123. If the working directory name does not validate, it will not be suggested to the user. If the user supplies an invalid site name during "ddev config", they will be re-prompted for the site name.
This also introduces a Validate() method for config that runs during App.Init(), which will validate hostname, docroot, and apptype. If any of these values are invalid, an error will be returned to the user instructing them to resolve the invalid configuration.
The Test:
The case in OP should no longer be reproducible:

mkdir invalid-drud-site?
cd invalid-drud-site?
ddev config, there should be no suggested site name
Provide a sitename with invalid characters. You should be prompted to re-enter the sitename.
ddev start. it should not fail

You can also test config validation on start by manually setting values in config.yaml and running "ddev start:

Entering a sitename with invalid characters and running "ddev start" should result in an error saying the sitename is invalid.
Entering a non-existent docroot path should result in an error saying the docroot path does not exist.
Entering an invalid apptype should result in an error saying the apptype is invalid.

Automation Overview:

Introduced a test for the new config Validate() method.
Related Issue Link(s):
#86
Release/Deployment notes:

I see merit in Brad's comment about validation instead of substitution. Perhaps there is a better middle ground and we can use this as an opportunity to help guide an end-user. If someone tries to use ☃ as a valid UTF-8 character, we simply warn the user "We enforce site names to be alphanumeric with dashes. We detected your input to include non-supported characters. Would you like us to automatically convert them?" Or we can be a little more heavy handed "We automatically converted 'my-☃-site' to 'my--site'". That way we're not roadblocking the user but making them aware of what happened.

Given that config can be manually written I think it does make sense to perform validation on start. I could also see how stripping the sitename could be unexpected to the user, and realistically it's a simple correction to make, and we want them to make it so that the written configuration is valid. I'll move forward on the validation approach as suggested.

@tannerjfco I know you're moving onto the pre/post hook feature #183, but this would probably be a  good WIP item to close out.

So tempted to hit the big green merge button! :)


Update Acknowledgements process/automations

Currently, Acknowledgements driven by departments or schools are done in a manual way using Salesforce/Marketing Cloud that is inconsistently timed and rests upon an automated thank you process that is driven by our site/Authorize gift transaction. The end user is now sometimes seeing 3 emails from CU thanking them for a donation. We would like to create an automated experience that is timely and can be customized (to a point) with deparmental/school specific content to support the desire of those groups to provide a more personalized thank you after a donation is made.

@ktheiler is this a duplicate? https://github.com/CUCentralAdvancement/eComm/issues/21

there's also this issue https://github.com/CUCentralAdvancement/eComm/issues/6


Panic from fetch.rs for a certain track and file format

The following track spotify:track:4NYe98w8kYWN2BMhiUIuzq  with 320 bitrate (FileFormat::OGG_VORBIS_320 -- FileId("4310bb8d969082b6c2f64fb59de5d1871086a536")), leads to a panic from fetch.rs.
There seems to be some issue with the assert!(new_index < self.shared.chunk_count); check for this particular track.
FWIW - changing the < to <= avoids this panic - but I haven't looked into detail behind the reasoning for the assertion - Any ideas?
Added a few debug print statements, namely:
diff --git a/audio/src/fetch.rs b/audio/src/fetch.rs
index e5e461a..468aead 100644
--- a/audio/src/fetch.rs
+++ b/audio/src/fetch.rs
@@ -278,6 +278,7 @@ impl Future for AudioFileFetch {
                 Ok(Async::Ready(Some(offset))) => {
                     progress = true;
                     let index = offset as usize / CHUNK_SIZE;
+                    info!("Requesting seek_rx index {} for offest {}" , index, offset);
                     self.download(index);
                 }
                 Ok(Async::NotReady) => (),
@@ -309,6 +310,8 @@ impl Future for AudioFileFetch {
                     }

                     let new_index = (self.index + 1) % self.shared.chunk_count;
+                    info!("Requesting data_rx index {}",new_index);

INFO:librespot_playback::player: Loading track "Sito To" with Spotify URI "spotify:track:4NYe98w8kYWN2BMhiUIuzq"
INFO:librespot_playback::player: File :: Some(FileId("4310bb8d969082b6c2f64fb59de5d1871086a536"))
INFO:librespot_audio::fetch: Requesting seek_rx index 0 for offest 144
INFO:librespot_audio::fetch: Requesting data_rx index 1
INFO:librespot_audio::fetch: Requesting seek_rx index 0 for offest 167
INFO:librespot_audio::lewton_decoder: absgp: 0
INFO:librespot_audio::fetch: Requesting seek_rx index 0 for offest 167
INFO:librespot_audio::fetch: Requesting seek_rx index 0 for offest 167
INFO:librespot_audio::fetch: Requesting seek_rx index 74 for offest 9699328
thread 'main' panicked at 'assertion failed: new_index < self.shared.chunk_count', audio/src/fetch.rs:232:9

On further investigation, this happens because Seek is attempting to get a block past the EOF.
This seems to occur specifically for this track and format because it's size () is a multiple of CHUNK_SIZE.
INFO:librespot_playback::player: Loading track "Dodole" with Spotify URI "spotify:track:1RLJijwCvgIbvUuVgWuhVF"
INFO:librespot_playback::player: File :: Some(FileId("bfd9e9ea7f13faf0e1f03531859c2af83683300a")) :: Position 0
INFO:librespot_audio::fetch: AudioFileOpen::len 9499100[u64] 72.472[chunks] => 73[chunks]
INFO:librespot_playback::player: Track "Dodole" loaded
INFO:librespot_playback::player: Loading track "Sito To" with Spotify URI "spotify:track:4NYe98w8kYWN2BMhiUIuzq"
INFO:librespot_playback::player: File :: Some(FileId("4310bb8d969082b6c2f64fb59de5d1871086a536")) :: Position 0
INFO:librespot_audio::fetch: AudioFileOpen::len 9699328[u64] 74.000[chunks] => 74[chunks]
WARN:librespot_audio::fetch: Panictime: 0
WARN:librespot_audio::fetch: Trying to seek past EOF

I added a check to ensure this doesn't happen  - but am unsure if that is the right place to do it.
diff --git a/audio/src/fetch.rs b/audio/src/fetch.rs
index e5e461a..0cce8f5 100644
--- a/audio/src/fetch.rs
+++ b/audio/src/fetch.rs
@@ -64,6 +64,13 @@ impl AudioFileOpenStreaming {
         write_file.set_len(size as u64).unwrap();
         write_file.seek(SeekFrom::Start(0)).unwrap();

+        info!("AudioFileOpen::len {}[u64] {:.3}[chunks] => {}[chunks]",
+                size as u64,
+                size as f64 / CHUNK_SIZE as f64,
+                chunk_count);
+        if chunk_count <= size/CHUNK_SIZE {
+            warn!("Panictime: {}", size % CHUNK_SIZE);
+        }
         let read_file = write_file.reopen().unwrap();

         let data_rx = self.data_rx.take().unwrap();
@@ -348,11 +355,16 @@ impl Read for AudioFileStreaming {
 impl Seek for AudioFileStreaming {
     fn seek(&mut self, pos: SeekFrom) -> io::Result<u64> {
         self.position = try!(self.read_file.seek(pos));
+        // Do not seek past EOF
+        if (self.position as usize % CHUNK_SIZE) != 0  {
+            // Notify the fetch thread to get the correct block
+            // This can fail if fetch thread has completed, in which case the
+            // block is ready. Just ignore the error.
+            let _ = self.seek.unbounded_send(self.position);
+        } else {
+            warn!("Trying to seek past EOF");
+        }

-        // Notify the fetch thread to get the correct block
-        // This can fail if fetch thread has completed, in which case the
-        // block is ready. Just ignore the error.
-        let _ = self.seek.unbounded_send(self.position);
         Ok(self.position)
     }
 }


add option to pass explicitly path to GraphViz executable (useful in Windows 7)

I am running Windows 7 64-bit. I installed graphviz-2.36.msi from
http://www.graphviz.org/Download_windows.php but I install most programs to
c:\app rather than c:\Program Files, and I get this message (see below). One
problem is that there is no SOFTWARE\ATT registry key anymore. (perhaps related
to https://code.google.com/p/pydot/issues/detail?id=65)
I think the bigger problem is that this discovery mechanism is a cat-and-mouse
game with whatever the graphviz folks do.
===> Could you please add a function so that end-users can just set the
graphviz path manually through whatever mechanism they see fit?
For now I'm just monkeypatching the pydot module:
def force_find_graphviz(graphviz_root):
   binpath = os.path.join(graphviz_root, 'bin')
   programs = 'dot twopi neato circo fdp sfdp'
   def helper():
     for prg in programs.split():
       if os.path.exists(os.path.join(binpath, prg)):
         yield ((prg, os.path.join(binpath, prg)))
       elif os.path.exists(os.path.join(binpath, prg+'.exe')):
         yield ((prg, os.path.join(binpath, prg+'.exe')))
   progdict = dict(helper())
   return lambda: progdict

pydot.find_graphviz = force_find_graphviz('c:/app/util/graphviz/2.36')

C:\tmp\blockdiag>python
Python 2.7.5 |Anaconda 1.9.1 (64-bit)| (default, May 31 2013, 10:45:37) [MSC v.1
500 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import pydot
Couldn't import dot_parser, loading of dot files will not be possible.
>>> graph = pydot.Dot(graph_type='graph')
>>> graph.write_png('test.png')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "c:\app\python\anaconda\1.6.0\lib\site-packages\pydot.py", line 1602, in
<lambda>
    lambda path, f=frmt, prog=self.prog : self.write(path, format=f, prog=prog))

  File "c:\app\python\anaconda\1.6.0\lib\site-packages\pydot.py", line 1696, in
write
    dot_fd.write(self.create(prog, format))
  File "c:\app\python\anaconda\1.6.0\lib\site-packages\pydot.py", line 1724, in
create
    self.progs = find_graphviz()
  File "c:\app\python\anaconda\1.6.0\lib\site-packages\pydot.py", line 409, in f
ind_graphviz
    "SOFTWARE\ATT\Graphviz", 0, win32con.KEY_QUERY_VALUE )
pywintypes.error: (2, 'RegOpenKeyEx', 'The system cannot find the file specified
.')
>>>

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 28 Mar 2014 at 7:30

This saves my day! Thanks : )

Saved my day too!!

I'm running Windows 10 with Python 2.7 on the Anaconda Prompt.
I have replaced the "def find_graphviz():" function with your code above.
But when I run Import Pydot, I receive the following error:
File "C:\Users...\AppData\Local\Continuum\Anaconda2\lib\site-packages\pydot.py", line 432
return None
^
IndentationError: unindent does not match any outer indentation level
This is how I have the function currently defined in pydot.py:
###########################################################
def find_graphviz():
if os.sys.platform == 'win32':
    if os.environ.has_key('PROGRAMFILES'):
        #Change to your path
        path =  "C:\Program Files\Graphviz2.30\\bin"

    else:

        #Just in case, try the default...
        path = r"C:\Program Files\Graphviz2.30\bin"

    progs = __find_executables(path)

    if progs is not None :

        #print "Used default install location"

        return progs

    return None

#############################################3
Please let me know how to alleviate this error.
Thank you,
Ben

The OP suggests that the user be able to pass the path of GraphViz. The standard approach to this problem is to add GraphViz to the path. Hardcoding its path is not a solution #109. Nonetheless, adding an argument graphviz_path to write and its write_* siblings is flexible, and can accommodate also selecting a GraphViz executable from within Python code, in any OS, without modifying the $PATH.
Thanks for the suggestion, this should also provide an alternative for #109, #102, #65 for users that prefer to not change the path.

Addressed by f3abbd537ed8adfeb2c5562f6c62403094111aa8, which allows passing the path to the desired GraphViz executable as the prog argument of method pydot.Dot.write_* (for example, write_pdf('filename.pdf', prog='C:\\some\\path\\dot.exe'). It remains to test this on Windows.
The mentioned change also implements properly $PATH searching, by using os.environ['PATH'] and the env argument of subprocess.
Relevant discussion and issues:
http://stackoverflow.com/a/5659249/1959808
http://bugs.python.org/issue8557

I found a manual solution:
sudo apt-get install graphviz
graph.write('test.dot')
dot -Tps test.dot -o outfile.ps
You can the files here: https://github.com/jecs89/LearningEveryDay/tree/master/GP

Please see https://github.com/erocarrera/pydot/issues/126#issuecomment-347301268


ir: Consistently append implicit template parameters when not using Rust unions.

Fixes #1429.

 Warning

These commits modify unsafe code. Please review it carefully!

@bors-servo r+

:pushpin: Commit 3f70aae has been approved by emilio

:hourglass: Testing commit 3f70aae033f4a2e4c0efddff5af807436a40609e with merge 1bca933502499aa9d8797f5c547be5efff995732...

@bors-servo r+

Fixed the tests for compilers that aren't >c++11 by default.

:pushpin: Commit d479cad has been approved by emilio

:hourglass: Testing commit d479cad74ea8ec956cee1773dd7d9ae3c177408f with merge 921d2787a4407a8281a58cef4fc2792e3ad04c5a...

:broken_heart: Test failed - status-travis

@bors-servo r+

:pushpin: Commit b2083d5 has been approved by emilio

:hourglass: Testing commit b2083d5b4b070c4d5696c589245c291e40c7554f with merge 5de943ca7bf6c155f7bae1d91f1e3b1d91e8d901...

:sunny: Test successful - status-travis
Approved by: emilio
Pushing 5de943ca7bf6c155f7bae1d91f1e3b1d91e8d901 to master...


support for roblox-ts modules

roblox-ts has their own way of linking files together through their runtime library. However, this can be an issue if you want to bundle all into one file. Ideally, a solution would parse the TS.import statement and TS.getModule statements inside of the import statement and resolve them to their actual paths for darklua to use.

Hello! Could Roblox-typescript generate different file paths? I'm wondering if I want to introduce logic into darklua that seems very specific. I think it'd be wise to avoid having an implicit dependency to Roblox-typescript.
I'm not familiar with Roblox-typescript, but it already does some code-generation so it could just generate valid Luau paths?

It doesn't support the ability to do that yet, I did make a patch for it but it's pretty much useless since if you want to use other people's packages via npm, some of them upload the code with the TS.import already done. View an example here: https://www.npmjs.com/package/@flamework/core?activeTab=code
I understand this feature is specific to roblox-ts, but possibly a plugin system for darklua would be better.


Proposal for Grid component

Dear developer of this project, I have a suggestion about naming the Grid component and its functionality. Problem: at the moment, the Grid component can be used as a wrapper or container and as a string. At the moment, this is regulated by the transmission of props, it may result in such a result that we will have a Grid -> wrapper in which there will be a large number of rows that are also called by the Grid component. It turns out the nesting of the same component with different functionality. I think this greatly spoils the look of the code and its readability. Solution: Split this component so that the wrapper and the string itself are different components. To implement the principle of sole responsibility.

Hello @Azyabat 👋🏽, thank you very much for your attention to the project.
This proposal needs more attention, so I suggest waiting and listening to the opinions of other participants, if this proposal is in demand, then we can fix it.


heroku fails

as far as i know heroku doesn't support this app in their platform  but the3gzone.herokuapp.com is still active and points yout repo. any idea to make one like this or anyother free platform for deployment?.

heroku doesnot support peer to peer apps now
if u want to use cloud torrent u can use my app
https://goo.gl/4WUFCv
On Thursday, February 8, 2018, SuriyaRaj<EMAIL_ADDRESS>wrote:

as far as i know heroku doesn't support this app in their platform but
the3gzone.herokuapp.com is still active and points yout repo. any idea to
make one like this or anyother free platform for deployment?.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/asapach/peerflix-server/issues/132, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AVSGro2Pf7Nyd2H6aM2OUD6XwwzKKKGoks5tSf7OgaJpZM4R9St5
.

hi thanks for letting me know that you have a private. but i wanted to setup my very own torrent leecher for my followers.

Currently, heroku can deploy this project easily, and performance is good too!
For one-click in-browser deploy, you could try: https://www.heroku.com/deploy/?template=https://github.com/maple3142/peerflix-server
It is based on my fork of this project: https://github.com/maple3142/peerflix-server

Currently, heroku can deploy this project easily, and performance is good too!
For one-click in-browser deploy, you could try: https://www.heroku.com/deploy/?template=https://github.com/maple3142/peerflix-server
It is based on my fork of this project: https://github.com/maple3142/peerflix-server

can we deploy this now?? i mean its banned by heroku or not? any workaround??

Watch out my comment at #188, p2p is forbidden in Heroku. You might end with your account suspended.

Watch out my comment at #188, p2p is forbidden in Heroku. You might end with your account suspended.


Make foaas fully conform to the REST spec to make Roy Fielding proud

See title

If you're not going to supply specifics, see service :P

This is the most helpful issue description I've ever seen. Like, what else do I need but to see the title?


MEXC - Fix balances methods

This probably also fixes all other methods that require authentication

Looks like merging the previous PR created a merge conflict with this PR. @v36u, do you mind taking a look?


Hyundai: add missing FW for IONIQ_5

Description [IONIQ 5 would not fingerprint so added additional firmware information. Additionally, added additional ECUs for ABS and EPS with firmware versions]
Verification [Added branch to comma three to verify care would fingerprint successfully.]

From dongle id 5608f42aaece1463

We actually already support your car and its FW versions in release. Thanks for the PR, since it brought a bug in our tests to my attention! https://github.com/commaai/openpilot/pull/27606


Show Wrong IOT Hub  Connection String for Azure China

Show Wrong IOT Hub Connection String for Azure China
I use azure cli with azure china, and find the function of showing iot hub connection string is not work right for azure china. It show the global endpoint,
Command:
az cloud set -n AzureChinaCloud
az login
az iot hub show-connection-string --name testtot
{
"connectionString": "HostName=testtot.azure-devices.net;SharedAccessKeyName=iothubowner;SharedAccessKey=xxxx"
}
The host name should be testtot.azure-devices.cn, not azure-devices.net.

Environment summary
PS C:\Users\kevin> az -v
azure-cli (2.0.21)
acr (2.0.15)
acs (2.0.19)
appservice (0.1.20)
backup (1.0.3)
batch (3.1.7)
batchai (0.1.3)
billing (0.1.6)
cdn (0.0.10)
cloud (2.0.10)
cognitiveservices (0.1.9)
command-modules-nspkg (2.0.1)
component (2.0.8)
configure (2.0.12)
consumption (0.1.6)
container (0.1.13)
core (2.0.21)
cosmosdb (0.1.15)
dla (0.0.15)
dls (0.0.18)
eventgrid (0.1.5)
extension (0.0.6)
feedback (2.0.6)
find (0.2.7)
interactive (0.3.11)
iot (0.1.14)
keyvault (2.0.14)
lab (0.0.13)
monitor (0.0.12)
network (2.0.18)
nspkg (3.0.1)
profile (2.0.15)
rdbms (0.0.9)
redis (0.2.10)
reservations (0.1.0)
resource (2.0.18)
role (2.0.14)
servicefabric (0.0.6)
sql (2.0.15)
storage (2.0.19)
vm (2.0.18)
Python location 'C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\python.exe'

Similar to Azure Government. A bug.

Created item to fix for Oct this year https://msazure.visualstudio.com/One/_workitems/edit/4979240


Support server.address for traced incoming HTTP requests

Problem Statement
Hey.
Currently request host (domain) is not sent to Sentry. For apps that use subdomains or multi-tenancy apps, this is needed to differentiate between requests that look alike but are actually different endpoints (based on the host).
Solution Brainstorm
It seems that Sentry supports sending this as part of transaction data: https://develop.sentry.dev/sdk/telemetry/traces/span-data-conventions/#http

Are you talking about your own transactions or instrumented http requests?


Please help to add CI support for riscv64

Hi,
Currently riscv64 is supported by zstd-jni pr #282 .
It's tested locally, but not regularly on github. I tried to modify the ci script to enable the CI support for riscv64, but seems I don't have the right to do so.
Can someone help to do it?
Thanks!
(Seems it's simple to enable it? I'm not sure, I did not modify this script before.)
diff --git a/.github/workflows/ci-qemu-cross.yml b/.github/workflows/ci-qemu-cross.yml
index e8df8fa..7c962f2 100644
--- a/.github/workflows/ci-qemu-cross.yml
+++ b/.github/workflows/ci-qemu-cross.yml
@@ -5,7 +5,8 @@ jobs:
         strategy:
             matrix:
                 include: [
-                    { platform: s390x }
+                    { platform: s390x },
+                    { platform: riscv64 },
                 ]
         runs-on: ubuntu-latest
         steps:

I am not sure it's going to be so easy. I will try it

Thanks Luben.
Seem it's because when I generated my github access token, I did include the workflow.
I can also try it later.

I have created the https://github.com/luben/zstd-jni/pull/285.
( The reason I could not create the pr is because of wrong access token, sorry for the inconvenience. )


Content block by block timeline additions (dev)

Added three timeline elements to block by block story.

Nice job figuring this out! This looks great. Let's get this to dev, give our EH partners a chance to look at it, and then we can also plan to merge changes into prod.


RPi connection failure - FirmwareError

I can not connect with OPC-N2 sensor, which reports under the Alphasense software firmware version: "FirmwareVer=OPC-017b...............................BD".
During initialization with command:
alpha = opc.OPCN2(spi)
I get
FirmwareError: Cannot determine correct firmware for this OPC:
Additionally in the official manual I found different wiring for the molex 6w plug for OPC-N2 (attached).

Yup. You're correct. These are pinouts from a breakout board I had designed for the board. I'm very sorry about this. I will change it in the docs immediately.

Sorry i don't get what is wrong with the wiring? I got the same error with
SCK-CLK
SDO-MISO
SDI-MOSI
/SS-CE0
Is this the right one ?

Can you give me a bit more information? What firmware version is your opc?

OPC 1.0.5591.26628
I looked it up in the document it came with and it says firmware can be found when it is first connected to the software and this is what is shown. "0.5591" is the version?

oh sorry Firmware version=17
Found USB-ISS versioin 6
USBISS SerialNo=00021780
Device interface=USBISS
Device info String=OPC-N2 FirmwareVer=OPC
Device type set to OPC_N2
Firmware version=17

Ok okay! It should work then. How are you powering it?
On Fri, Mar 18, 2016 at 6:53 PM louisanb<EMAIL_ADDRESS>wrote:

oh sorry Firmware version=17
Found USB-ISS versioin 6
USBISS SerialNo=00021780
Device interface=USBISS
Device info String=OPC-N2 FirmwareVer=OPC
Device type set to OPC_N2
Firmware version=17
—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
https://github.com/dhhagan/py-opc/issues/14#issuecomment-198571366

--
Regards,
David H Hagan
PhD Student | Atmospheric Chemistry & Physics
Department of Civil & Environmental Engineering
Massachusetts Institute of Technology
Cambridge, MA 02139
P:<PHONE_NUMBER> | E<EMAIL_ADDRESS>| W. https://davidhagan.me

A battery pack with 4 AA 1.5V i measured the output volts out of the battery pack which is 5.6V

Is it powering both the pi and the opc?
On Fri, Mar 18, 2016 at 6:58 PM louisanb<EMAIL_ADDRESS>wrote:

A battery pack with 4 AA 1.5V i measured the output volts out of the
battery pack which is 5.6V
—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
https://github.com/dhhagan/py-opc/issues/14#issuecomment-198572146

--
Regards,
David H Hagan
PhD Student | Atmospheric Chemistry & Physics
Department of Civil & Environmental Engineering
Massachusetts Institute of Technology
Cambridge, MA 02139
P:<PHONE_NUMBER> | E<EMAIL_ADDRESS>| W. https://davidhagan.me

Can you attach a picture or diagram?
On Fri, Mar 18, 2016 at 6:59 PM David Hagan<EMAIL_ADDRESS>wrote:

Is it powering both the pi and the opc?
On Fri, Mar 18, 2016 at 6:58 PM louisanb<EMAIL_ADDRESS>wrote:

A battery pack with 4 AA 1.5V i measured the output volts out of the
battery pack which is 5.6V
—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
https://github.com/dhhagan/py-opc/issues/14#issuecomment-198572146

--
Regards,
David H Hagan
PhD Student | Atmospheric Chemistry & Physics
Department of Civil & Environmental Engineering
Massachusetts Institute of Technology
Cambridge, MA 02139
P:<PHONE_NUMBER> | E<EMAIL_ADDRESS>| W. https://davidhagan.me

--
Regards,
David H Hagan
PhD Student | Atmospheric Chemistry & Physics
Department of Civil & Environmental Engineering
Massachusetts Institute of Technology
Cambridge, MA 02139
P:<PHONE_NUMBER> | E<EMAIL_ADDRESS>| W. https://davidhagan.me

No just the opc. i am using the wall power cable thing came with the pi for powering the pi alone right now

Ahh okay..there may be some grounding issues but probably not. Do you know
if the batteries supply enough current? It needs at least 260 mA
On Fri, Mar 18, 2016 at 7:01 PM louisanb<EMAIL_ADDRESS>wrote:

No just the opc. i am using the wall power cable thing came with the pi
for powering the pi alone right now
—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
https://github.com/dhhagan/py-opc/issues/14#issuecomment-198572441

--
Regards,
David H Hagan
PhD Student | Atmospheric Chemistry & Physics
Department of Civil & Environmental Engineering
Massachusetts Institute of Technology
Cambridge, MA 02139
P:<PHONE_NUMBER> | E<EMAIL_ADDRESS>| W. https://davidhagan.me

Otherwise I would try verifying the connections are good?
On Fri, Mar 18, 2016 at 7:02 PM David Hagan<EMAIL_ADDRESS>wrote:

Ahh okay..there may be some grounding issues but probably not. Do you know
if the batteries supply enough current? It needs at least 260 mA
On Fri, Mar 18, 2016 at 7:01 PM louisanb<EMAIL_ADDRESS>wrote:

No just the opc. i am using the wall power cable thing came with the pi
for powering the pi alone right now
—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
https://github.com/dhhagan/py-opc/issues/14#issuecomment-198572441

--
Regards,
David H Hagan
PhD Student | Atmospheric Chemistry & Physics
Department of Civil & Environmental Engineering
Massachusetts Institute of Technology
Cambridge, MA 02139
P:<PHONE_NUMBER> | E<EMAIL_ADDRESS>| W. https://davidhagan.me

--
Regards,
David H Hagan
PhD Student | Atmospheric Chemistry & Physics
Department of Civil & Environmental Engineering
Massachusetts Institute of Technology
Cambridge, MA 02139
P:<PHONE_NUMBER> | E<EMAIL_ADDRESS>| W. https://davidhagan.me

oh i see! it might be the connections which seems solid but it maybe causing the problem here. The ground issues thing is a good call too i will check that.
About the Current I m using regular Energizer battery http://www.amazon.com/Energizer-Max-Alkaline-Battery-24-Count/dp/B004U429AQ/ref=sr_1_1_s_it?s=hpc&ie=UTF8&qid=1458342479&sr=1-1&keywords=energizer+batteries
I assume it is fine the fun will be turned on when i connect the batter pack (it takes about a minute for the fun to be turned on which i assume is an indicator it is being powers properly)and that is how i know the connection is good ( at least the power ones and i assume others should be good too but i will try to find a way to check)

I am checking the current now!

Hey @louisanb did you solve your issues with the OPC?

Oh sorry i did not see this. Thank you very much for asking! I just got the perfect wire and crimp that i bought to eliminate bad connections concern today. It still has the same error. I am still trying to solve the problem and i am going to do some troubleshooting on the grounding issue you mentions before.  besides that i noticed i have to only connect the power and GND pin to power it up first then connect other pins on Rpi to at least turn OPC on. If i just connect all the pins all at once the OPC won't be turned on. Also when the power source is off the and all connection remain the same, the voltage between SCK-SDI is 2.75v
SCK-SDI=2.75 SCK-SDO=.41 SCK-SS=.37 SCK-Vcc=1.89 SCK-GND=.77
SDI-SDO=2.3 SDI-SS=2.3 SDI-Vcc=.86 SDI-GND=1.98
SDO-SS=.034 SDO-Vcc=1.48 SDO-GND=.36
SS-Vcc=1.51 SS-GND=.39
Vcc-GND=1.13
vs power on: Number in () is the measurement collected once in while which i think is measurement errors
SCK-SDI= 3.3v SCK-SDO=0 SCK-SS=0 SCK-Vcc=2.77 (5.5) SCK-GND=1.18 (0)
SDI-SDO=3.29 SDI-SS=3.29 SDI-Vcc=2.17 (0) SDI-GND=3.3 (1.18 4.5)
SDO-SS=.0 SDO-Vcc=5.5 SDO-GND=0
SS-Vcc=2.76 SS-GND=0
Vcc-GND=5.5

sorry forgot to attack the pictures

Awesome. Any chance you could tell me which color wires are where on the OPC?

Oh yea
Vcc-Red
SCK-Brown
SDO-Green
SDI-Yellow (connects to purple wire on Rpi)
SS-Blue
GND-Black

Okay. I can't see the connection to the OPC which is the most likely error. Can you label which colors are plugged into pins 1-6 on the OPC?

1-Vcc-Red (1 being bottom left of OPC as shown in the picture below
2-SCK-Brown
3-SDO-Green
4-SDI-Yellow (connects to purple wire on Rpi)
5-SS-Blue
6-GND-Black

For Rpi to read the firmware of OPC, does OPC need to be powered? Also please discard the first picture set i accidently switched the blue pin/wire with the purple one when i took the picture

Hmm. The wiring is definitely fine. I assume it's a connection? Otherwise I'm not sure. Have you enabled SPI on the RPi through rapsi-config?

Yea i did enable it. I did not do much on Rpi codewise besides debugging or trying to make the code/OPC to work. The only thing i did was enable SPI and download the code/library from your github and tried to run it and make it work with OPC. I did not check the SPI alone after enable it like the way in one of the pictures below.

@louisanb Interesting. I'm not exactly sure what's going on then aside from it being a bad connection. If you still are powering them separately, I would try using a central PSU.

Thank you very much! I will definitely try the PSU, i feel like it is the cause.

Hey @louisanb any update on this?

Hi David:
I don't work there anymore and thank you very much for checking!
louis

From: David H Hagan<EMAIL_ADDRESS>Sent: Thursday, November 17, 2016 7:41:12 AM
To: dhhagan/py-opc
Cc: louis an; Mention
Subject: Re: [dhhagan/py-opc] RPi connection failure - FirmwareError (#14)
Hey @louisanbhttps://github.com/louisanb any update on this?

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/dhhagan/py-opc/issues/14#issuecomment-261263678, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIRYjJPtr-cJQs4mSEMF-MA6t72B5ECBks5q_GeIgaJpZM4G-bS5.


Extract protocols crate

Module aries-vcx/src/protocols/ should be a separate crate completely unaware of existence of ledger, wallet or particular credential types. Instead, these particular implementations should be injectable.

Important step toward enabling this has been done by George's modularization PR https://github.com/hyperledger/aries-vcx/pull/648 which is essentially shielding off state machine code from particular implementations - for example function _create_credential in protocols/issuance/issuer/states/state_machine.rs calls anoncreds.issuer_create_credential(...), but the anoncreds object is just BaseAnonCreds trait interface.

It's worth of note that with current approach, the state machines are still aware of anoncreds implementation details, as the interfaces require passing quite specific information like tails_dir or rev_reg_id. So the current state machines are currently not generic enough to support different type of credentials, like LD or BBS, but I think that's fine for now.

Turns out to be duplicate of https://github.com/hyperledger/aries-vcx/issues/113


formulas not working

How to implement formulas functions for ng2-handsontable, because when I set the formulas = true still not working.

Yes, the same issue. Any update on this?


[dashboard]Some problems about creating and updating fileshare

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

What happened:
Create fileshare with a name has 128 characters failed while creating a file share with a name has 4 characters(other parameters the same) succeed. As below:

What you expected to happen:

Create fileshare successfully.
Display correctly, the size and status are not covered by name.
How to reproduce it (as minimally and precisely as possible):
Create a fileshare with the name has 128 characters, other parameters use the default value.

What happened:
When I tried to update fileshare, and set the new name to be an empty string,  I can click 'ok' but nothing changed.
What you expected to happen:
I cannot click 'ok'.
How to reproduce it (as minimally and precisely as possible):

Choose a fileshare which status is available.
Choose 'More' > 'Modify' and set the name to be empty.
Click ok.

What happened:
I tried to create a fileshare, which size is more than pool size, it created successfully, but its status is error.
What you expected to happen:
Create failed.
How to reproduce it (as minimally and precisely as possible):
Create a fileshare which size is more than the pool size.
What happened:
I tried to update the description of fileshare, but the description is not updated as expected. As below:

What you expected to happen:
The description is updated.
How to reproduce it (as minimally and precisely as possible):
Choose a fileshare which status is available and modify it's description to any string.
Anything else we need to know?:
N/A
Environment:

Hotpot(release/branch) version: development branch
OS (e.g. from /etc/os-release): Ubuntu 16.04.2 LTS
Kernel (e.g. uname -a): Linux ubuntu 4.4.0-62-generic
Install tools: manually
Others:  dash-board: development branch

Do we have any limitation on the fileshare name? please ensure this test is covered in our test case list

@sfzeng It is working fine with latest code. Please verify.

Already tested it.


Replicated samples in divergence functions

getStepwiseDivergence:
I think it was not optimal to expect user to subset data so that there were no replicated samples. Now user gets warning if there are replicated timepoints, and the average is calculated.

Unit tests are still needed.


Migrate to v2 android embedding

Hey @arashgm
As our project is using Flutter 2.8. We have some plugins which still uses v1 android embedding and needs to be migrated to v2. This PR contains the migration code.

Can you also remove jCenter and replace it with mavenCentral while you're at it?

@ueman sure I will do that. Thanks


Custom validation errors isn't rendered inline with the data field

Breaking the required invariant yields the following

But a custom validation message pointing at the data field, will just list it at the top of the form, but not inline with the field:

https://github.com/Altinn/app-frontend-react/issues/555


bug: infinite-scroll not work well，loadData cann‘t fire again

html：
<ion-infinite-scroll threshold="50px" id="infinite-scroll" (ionInfinite)="loadData($event)">

ts：
loadData(event){
setTimeout(() =>{
this.list = this.list.concat(this.users.slice(0,20))
event.target.complete();
},500)
}

"@angular/cli": "8.3.2",
"@ionic/angular": "^4.7.4",

Had the same problem, I also don't know how to solve, when returning from other pages infiniteScroll is no work, when I leave the list page, I set up this. InfiniteScroll. Disabled = false; But it doesn't work, right

Had the same problem, I also don't know how to solve, when returning from other pages infiniteScroll is no work, when I leave the list page, I set up this. InfiniteScroll. Disabled = false; But it doesn't work, right

Same here.
Steps to reproduce

Go to page with <ion-infinite-scroll>: ionInfinite is triggered
Navigate to other page, then come back to page with <ion-infinite-scroll>
ionInfinite is not triggered anymore

Info
Ionic CLI                     : 5.2.8 (/usr/local/lib/node_modules/ionic)
Ionic Framework               : @ionic/angular 4.9.0
@angular-devkit/build-angular : 0.803.3
@angular-devkit/schematics    : 8.3.3
@angular/cli                  : 8.3.3
@ionic/angular-toolkit        : 2.0.0

I'm facing the same issue with Ionic 4.10.0

Thanks for the issue. Is this still an issue with the latest version of Ionic Framework? If so, please provide a repo with the code required to reproduce this issue.

@tomavanc Can you please provide this as a full repo? Code snippets are usually not enough to reproduce issues like these.


bug(MatCheckbox): fails to toggle when the binding is updated in the click handler.

Reproduction
https://stackblitz.com/edit/angular-l69cmq?file=src%2Fapp%2Fapp.component.ts

Bind a MatCheckbox to a property on a component class.
Set the property value to true in a click handler on the checkbox.
Click the checkbox.

Expected Behavior
The input handles the click event first and toggles the checkbox value. The property value is already true when the parent's click handler is executed.
Actual Behavior
The click hander sets the property to true, and the form control toggles the checkbox before the input handle's the click event. The checkbox is toggled twice and remains false with one click.
Environment

Angular: 9.1.1
CDK/Material: 9.2.0
Browser(s): Chrome 80.0.3987.163
Operating System (e.g. Windows, macOS, Ubuntu): macOS Catalina

Given the comment at the top of _onInputClick (checkbox.ts line 399), I would guess that the parent is handling the label's click event and the label is triggering the input's click event. Therefore, the input handles the click event after the parent.
This may be expected based on the implementation or get fixed as result of the MDC migration. This issue is useful for my tracking open or closed.
Workarounds

Cancel the event in the click handler.
Perform side effects as a reaction to the checkbox value change using the change event or getters and setters.

@TrevorKarjanis, I think this is because _onInputClick  happens before the browser update the checkbox to its new value.
Needs to add a setTimeout when updating the variable this._checked.

@jennynju is correct, though rather than a setTimeout I would just do event.stopPropagation(); event.preventDefault()

@jennynju @mmalerba That's definitely a simpler explanation. I think I didn't expect the binding to update the checkbox before it handled the click event. I am canceling the event, so thank you for the feedback.


Fix documentation of s3-uri

Fixes https://github.com/kubernetes-incubator/kube-aws/issues/1214

@c-knowles LGTM. Thank you so much for your effort of maintaining the documentation ☺


File Rename

A rename of a file in the leftside file browser should
do a rename of that file in all appearances of this name
in all pages of the currend project.
Right now it seems it dosn't do it.
So so get inconsistencies i.e. if you rename your name.css
in newname.css.

Yes. I will take a look at this.


bower.json missing

Hopscotch has been registered with bower, but there is no bower.json file detailing version, js files, css files etc
This means that automated bower injection using the grunt task bower-install fails:
grunt bower-install

hopscotch was not injected in your file.

This issue should be resolved by #142 . Please re-open if this is still an issue.


Wording is inaccurate

Heading states:
Example configuration for the user tunnel
First sentence after the heading states:
After you've configured the virtual network gateway and installed the client certificate in the local machine store on the Windows 10 client, configure a client device tunnel by using the following examples:

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 69495659-b738-98e6-48a5-e8884fc5604d
Version Independent ID: 08bc7902-2c0d-59ae-021a-510ad170bc44
Content: Configure an Always-On VPN user tunnel - Azure VPN Gateway
Content Source: articles/vpn-gateway/vpn-gateway-howto-always-on-user-tunnel.md
Service: vpn-gateway
GitHub Login: @cherylmc
Microsoft Alias: cherylmc

Hello @idunbar46
Thank you for your feedback! We will review and update as appropriate.

Hello @idunbar46 Thank you for your feedback, I have made a PR to address this issue and it is currently under doc authors review. We will now proceed to close this issue out please tag me in your response if you have any additional questions. Thank you!


Fixing twitch help.

Since we're already parsing the file name to remove prefix when we generate the list of options we don't need to do it again.
#hacktoberfest

@jessemillar (hopefully this will notify you??)

@xuther It did!

@xuther Since I'm lame and don't have unit tests, does this properly return !sfx help, trigger normal sound effects, and trigger effects with aliases? I already turned off my computer for the night so I can't check myself (#mobile).

Tested locally. Works great. Thanks!


Connect to power bi dataset

Is it possible to use this tool to compare power bi datasets that are made in PBI (Not analysis services)? If so, what should I put as workspace in source/target?
Is it possible to use BISMNormalizer or any other tool to get diff on power bi data models? I see newest Tabular Editor has partial support for .pbit, but no diff....

https://powerbi.microsoft.com/en-us/blog/power-bi-open-platform-connectivity-with-xmla-endpoints-public-preview/


[GLUTEN-1874][CH] Fixes nullable mismatch in union

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
Fixes: #1874
main changes
add a new field output_schema in RelRoot
This field will not affect velox
add a nullable projections after parsing root node in CH
new implementation for finding the non-nullable columns
This has the largest changes, since we remove all the required_columns in many functions
fixed some bugs about pushing down filter in merge tree
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
unit tests
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

There is a fix about json_tupe in #2008, wait for it be merged

@zzcclp @rui-mo @liuneng1994 Please take a review on this pr

@zhouyuan @rui-mo @zzcclp please help to review this

@jinchengchenghh @rui-mo Do you have any more questions?

There are some conflicts need to be resolved.


Remove references to species.endangered

Stop reading and writing the endangered column on the species table, in
preparation for dropping it.
The species API payloads still have endangered fields, but they are now
calculated from the conservation category.

Current dependencies on/for this PR:

main

PR #1255

PR #1256

PR #1257

PR #1258   👈

This comment was auto-generated by Graphite.


IFU note:

The buffer size need to be * n % 4K = 0 always. With n is any interger.
Every time write the size need to be same, except for last block.

Done


feat: audiobooks + chapters

I've just fixed some bugs in shows and episodes.
Also, there are logic for two more parts of Spotify docs.
P.S Tests needed for all projects. See #40

Codecov Report

Merging #41 (2ddf79b) into main (d1db70e) will decrease coverage by 0.78%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main     #41      +/-   ##
========================================
- Coverage   9.66%   8.88%   -0.78%
========================================
  Files         38      42       +4
  Lines       5134    5584     +450
  Branches      16      16
========================================
  Hits         496     496
- Misses      4638    5088     +450

Impacted Files
Coverage Δ

src/api/audiobook/audiobook.endpoints.ts
0.00% <0.00%> (ø)

src/api/audiobook/audiobook.types.ts
0.00% <0.00%> (ø)

src/api/chapter/chapter.endpoints.ts
0.00% <0.00%> (ø)

src/api/chapter/chapter.types.ts
0.00% <0.00%> (ø)

src/api/episode/episode.types.ts
0.00% <0.00%> (ø)

src/api/general.types.ts
0.00% <0.00%> (ø)

src/api/show/show.types.ts
0.00% <0.00%> (ø)


[Bug]: Sign in to GitHub modal fails to login with correct credentials after trying incorrect ones

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

Describe the bug and reproduction steps

Press sign in with GitHub
Enter incorrect credentials -> modal reopens with error message
Enter correct credentials -> modal closes without signing in

OpenHands Installation
Docker command in README
OpenHands Version
0.14.3
Operating System
None
Logs, Errors, Screenshots, and Additional Context
No response

This doesn't seem to be the case anymore. Locally if you type incorrect token, the modal closes and an error gets thrown. Upon clicking Connect to Github again, and giving correct token it connects.
We've also changed the SaaS as well so that doesn't even get used and it's automatic. Closing.


Questions about baseline experiments

Thanks for your excellent work!
I am confused about how to compare tava and neuralbody?
Training dataset in the tava is different from original neuralbody. And dataset used in the neuralbody should be consecutive frames, because of the time-varing latent embedding.
So, in your paper, Is the training dataset of neuralbody be the same as the original one or the tava one?

Hi we used the TAVA data split for neural body for fair comparison.
The per-frame latent code in neural body is disabled because it is not applicable to novel-pose synthesis (given a new pose there is no per-frame latent code that match with it)


feat: adding connection params grpc and cli query

…cli and test

Description

Rename query Params to ClientParams to avoid naming collisions
Adding ConnectionParams grpc and cli query
Adding missing top level wiring for client query UpgradedConsensusState

closes: #2069

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

Note this undos the changes from #2573 in order to avoid naming collisions. We can keep consistent naming of Params but this requires the removal of the this code and for the query servers to be bound to their respective keepers here.
This would also result in the removal of modules/core/keeper/grpc_query.go
Thoughts?

Codecov Report

Merging #2745 (da959a8) into main (3b2ab6a) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2745      +/-   ##
==========================================
- Coverage   78.74%   78.73%   -0.02%
==========================================
  Files         178      178
  Lines       12313    12324      +11
==========================================
+ Hits         9696     9703       +7
- Misses       2190     2194       +4
  Partials      427      427

Impacted Files
Coverage Δ

modules/core/keeper/grpc_query.go
0.00% <0.00%> (ø)

modules/core/02-client/keeper/grpc_query.go
68.20% <100.00%> (ø)

modules/core/03-connection/keeper/grpc_query.go
90.83% <100.00%> (+0.51%)
:arrow_up:

@crodriguezvega very good question, in the current state of #2697 we will just be looking at the first line of the commit message, so a single entry. It is possible to configure it it to treat every line as an entry, I think this is an excellent use case. Non conventional commits are filtered out, so I believe it should just look at the lines that have the type: message.

I'm happy to pick out the fix as a separate PR if needs @crodriguezvega
Otherwise I'll add two changelogs for this PR. Let me know what you think? I do think it would be good to backport this to v6

Looks great, since we do now support multiple changelog entries, can we include those in PR description before merge ❤

Does it look good to you? Should they be added as the squashed commit msg?
I've also manually added the changelogs here, as I had to remove an old one too!

Does it look good to you? Should they be added as the squashed commit msg? I've also manually added the changelogs here, as I had to remove an old one too!

@damiannolan looks good! You can put the two lines in as the description in the squashed pit, so you can have
PR name
Additional Description
imp(core/03-connection): Adding `ConnectionParams` grpc query and CLI to 03-connection.
fix(modules/core/keeper): Fix request wiring for `UpgradedConsensusState` in core query server.

One thing to keep in mind is that this message imp(core/03-connection): Adding ConnectionParams grpc query and CLI to 03-connection. will render as Adding ConnectionParams grpc query and CLI to 03-connection.. i.e. not include core/03-connection in the message. You may have intended to do imp: (core/03-connection) Adding ConnectionParams grpc query and CLI to 03-connection. if the goal is to include core/03-connection in the changelog entry.


PerLevelStatsMultiplier Does Nothing

Where should I put PerLevelStatsMultiplier settings so that they work with ark-server-tools?
I have values like this declared in each of the following files, but leveling up delivers perfectly ordinary stat gains, as if my settings are absent from all files.
Files:

~/ARK/ShooterGame/Saved/Config/LinuxServer/GameUserSettings.ini
~/ARK/ShooterGame/Saved/Config/LinuxServer/Game.ini
~/ARK/ShooterGame/Config/LinuxServer/LinuxGame.ini
~/ARK/ShooterGame/Config/DefaultGame.ini

The values are exactly the same (copy-pasted) in each of the 4 files. Where are these settings supposed to go?
Data:
[/Script/ShooterGame.ShooterGameMode]
PerLevelStatsMultiplier_Player[0]=1.25
PerLevelStatsMultiplier_Player[1]=1.25
PerLevelStatsMultiplier_Player[3]=1.0
PerLevelStatsMultiplier_Player[4]=1.15
PerLevelStatsMultiplier_Player[5]=1.15
PerLevelStatsMultiplier_Player[7]=2.0
PerLevelStatsMultiplier_Player[8]=1.8
PerLevelStatsMultiplier_Player[9]=1.8

Stop the server edit ~/ARK/ShooterGame/Saved/Config/LinuxServer/Game.ini to have those values and you should be good to go .

Is it possible to do this using an instance based config? I have tried various things to no avail so far. It seems to me game.ini settings in the normal instance configs do not work, but instead it only works for gus.ini settings.