Feature request: allele depths in FORMAT

Hi,
We have some tools that expect to see allele depths in FORMAT column (ie A,C,G,T or AU,CU,GU,TU) and TIR/TAR for indels. Would be great if there was a way to get these in the vcf output.
Thanks,
Rowan

@rowanhowellGE ,
Can you expand on a bit what your request is? We do report allele depths under AD field and frequency under VAF field.

They are described under allelic depth here https://support.illumina.com/help/variantstudio/Content/Vault/Informatics/Sequencing_Analysis/VS/swSEQ_mVS_SomaticVCFs.htm . Basically just count for each allele in tumour sample.

@rowanhowellGE ,
Unfortunately, adding this feature requires a lot of code change including supporting non-standard bases. One workaround could be to use some other software that can give you allele summary for the tumor sample that you can use with the DeepSomatic output. I have a note internally to work on this but I can't tell you when it can be prioritized. I will close this issue.


improver CLI help: fewer references to cube

As a third-party developer, I want IMPROVER CLI documentation to be more NetCDF-general rather than Iris-specific, so that I can easily understand the commands.
It is fine to refer to cubes inside the source code, but users of the utilities may not know (or need to know) what they are. In the CLI help, it would be good to be more aligned with general terminology.
Acceptance criteria:

In the improver- commands in the bin directory, rephrase mentions of 'cube' to files or diagnostics or phenomena as appropriate
Update CLI acceptance tests

Completed.


fix(api): removes unnecessary port from doc store api calls (BOAS-460)

Describe your changes

removes unnecessary port declaration

Issue ticket number and link
Type of change 🧩

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Other (please explain in the description section above)

Checklist before requesting a review

[ ] I have performed a self-review of my own code
[ ] I have double checked this work does not include any hardcoded secrets or passwords
[ ] I have made corresponding changes to the documentation
[ ] I have provided details on how I have tested my code
[ ] I have referenced the ticket number above
[ ] I have provided a description of the ticket
[ ] I have included unit tests to cover any testable code changes

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


JedisConnectionException on Transaction.exec() but commands still being executed

I'm creating a transaction object and adding a few commands to it. There are around 5 hmset commands being added, with the map size being at 500k mappings per hmset.
I'm also resetting the timeout using
jedis.getClient().setTimeout(500000);
When I execute the scripts, I'm seeing very peculiar behavior, all the commands added to the transaction object get executed properly and the data is also present in the cache.
However it also throws a timeout exception exception
redis.clients.jedis.exceptions.JedisConnectionException: java.net.SocketTimeoutException: Read timed out
Here's the stack trace of the exception I'm seeing
redis.clients.jedis.exceptions.JedisConnectionException: java.net.SocketTimeoutException: Read timed out
at redis.clients.jedis.Protocol.process(Protocol.java:144) ~[jedis-2.5.1.jar:na]
at redis.clients.jedis.Protocol.read(Protocol.java:200) ~[jedis-2.5.1.jar:na]
at redis.clients.jedis.Connection.readProtocolWithCheckingBroken(Connection.java:285) ~[jedis-2.5.1.jar:na]
at redis.clients.jedis.Connection.getAll(Connection.java:255) ~[jedis-2.5.1.jar:na]
at redis.clients.jedis.Transaction.exec(Transaction.java:36) ~[jedis-2.5.1.jar:na]
There is no timeout on redis side. get config timeout returns "0".
Could you let me know why this is happening?

Redis side timeout is for dropping idle connection, so it doesn't matter for you.
Jedis stores commands count which Jedis doesn't read response from Redis yet.
It's just for pipeline, and transaction is actually with pipelined.
We have observed some case that commands count is not accuracy, which makes getAll() tries to read more responses than Redis actually responded, finally leading timeout.
Most cases of these are not discarding invalid Jedis instance, which threw JedisConnectionException, so you may want to check it.
There's unknown reason about commands count inaccuracy, so we decided to change count variable to actual queue length, but it's planned to next major release, 3.0.0.
https://github.com/xetorthio/jedis/pull/511
Hope this helps.
One more, sharing your codes help us finding actual issue. Thanks!

Thank You HeartSaVior.
I was able to resolve it. pubsub was unsubscribed in one thread and released the jedis on different thread causing a deadlock waiting for response from redis. This happened 2/10 times. In those 2 times, the timeout became 0 waiting infinitely. As you mentioned, in 3.0.0 we might have a resolution as per your explanation.
Thanks
Arvind

Here's the code.
        JedisPool jedisPool = RedisJedisPool.getPool(hostName, port);
        try {
            jedis = jedisPool.getResource();
            //setting this to a high enough number, so that timeouts dont happen on large hashmaps
            jedis.getClient().setTimeout(50000);
            int count = 0;
            List<Object> result = null;
            Boolean cacheTimeStampLess = false;
            do {
                String cacheTimeStamp = jedis.get("{" + advId + "}_ts");
                /* If no element in cache or we are adding newer value update data */
                if (cacheTimeStamp == null || Integer.parseInt(cacheTimeStamp) < timeStamp ) {
                    jedis.watch(advId, "{" + advId + "}" + "_ts");
                    Transaction t = jedis.multi();
                    t.del(advId);
                    t.hmset(hashToBidValue)
                    t.set("{" + advId + "}" + "_ts", timeStamp.toString());
                    /* t.exec will return null incase of failed check */
                    result = t.exec();
                    cacheTimeStampLess = true;
                }
                count++;
            } while (result == null && count <= 3 && cacheTimeStampLess);
        } catch (JedisConnectionException e) {
            if (jedis != null) {
                jedisPool.returnBrokenResource(jedis);
                jedis = null;
            }
            logger.error("Exception in update data using Jedis Pool in LRECache: {}", e);
            processSuccessful = false;
        } finally {
            if (jedis != null) {
                jedisPool.returnResource(jedis);
                jedis.getClient().setTimeout(Protocol.DEFAULT_TIMEOUT);
            }
        }

@arvindnr I seem to be having the same problem, but how do I unsubscribe and have a clean exit, if the subscriber thread is blocking?
Here is my code:
public void init(){
    JedisPoolConfig poolConfig = new JedisPoolConfig();
    JedisPool jedisPool = new JedisPool(poolConfig, redisPath, 6379, 0);
    setupSubscriber();
}

public void setupSubscriber()
{
	try{
		subscriberJedis = jedisPool.getResource();
		subscriber = new JedisSubscriber();

		new Thread(new Runnable(){
			@Override
			public void run() {
				try{
					subscriberJedis.subscribe(subscriber, CHANNEL_NAME);
				}
				catch(Exception e){
					log("Subscribe failed. " + e.getMessage());
				}
			}
		}).start();
	}
	catch(Exception e)
	{
		e.printStackTrace();
	}
}

public void publishMessage(final String channel, final String message)
{
	new Thread(new Runnable(){
		@Override
		public void run() {
			try{
				Jedis jedis = jedisPool.getResource();
				jedis.publish(channel, message);
				jedis.close();
			}
			catch(JedisConnectionException e){
				e.printStackTrace();
			}
			catch (Exception e) {
				log("Publish failed. " + e.getMessage());
			}
		}
	}).start();
}

public void close()
{
	try{
		subscriber.unsubscribe();
		subscriberJedis.close();
		jedisPool.destroy();
	}
	catch(JedisConnectionException e)
	{
		e.printStackTrace();
	}
	catch(Exception e)
	{
		e.printStackTrace();
	}
}

My application freezes after calling subscriberJedis.close();
I am using Jedis 2.7.2.
And I never used Maven before, so when I built the jar file, I had to skip the tests cause they always failed.


[DO NOT MERGE] Auto PR to update dependencies of istio

This PR will be merged automatically once checks are successful.
none

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-cluster_wide-auth.sh
cc8a1ed2461acb3d2d6c90eb36564151516f8b3e
link
/test e2e-cluster_wide-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Has anyone used pytorch pretrained weight for training?

I used caffe vgg16 weight to train the network first and got an map around 0.75 on voc. But when I changed to use pytorch vgg16 weight, I only got an map around 0.7. I did change the image channel format from 'bgr' to 'rgb' according to README of this project, but it still didn't work well. So I wonder if it is because of the pretrained weight I used for training, since it's mentioned in README that caffe pretrained weight performs better than pytorch pretrained weight?

But an map gap of 0.05 is, well, I think different pretrained weight shouldn't make such a big difference. So I really want someone who have also used pytorch resnet pretrained weight to share your training results. Thanks!

I think I forgot about the normalize step... Sorry for that.


Auto updated datetime

Thanks for the contribution! I haven't been checking new features of typst for quite a long time.


set certificate in unit secret instead of app

Description
An exception is triggered when trying to create an application secret on a non-leader unit. This PR adds the Juju secret to the unit instead of the app.
Checklist

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have made corresponding changes to the documentation.
[x] I have added tests that validate the behaviour of the software.
[x] I validated that new and existing unit tests pass locally with my changes.
[x] Any dependent changes have been merged and published in downstream modules.
[x] I have bumped the version of any required library.

This is related to #57 :)

I have been thinking of scenarios where this change can cause any issues, but it looks good to me.
Can we merge this @ghislainbourgeois ?

I agree, we already validated that the certificate is for a CSR this unit requested. Merging.


[BUG] Unix.Packed.Coinminer-6856324-0 FOUND

Describe the bug
After clamav scan, in the log I can see:
/usr/local/bin/autok3s: Unix.Packed.Coinminer-6856324-0 FOUND

What's the autok3s version? You can do autok3s version and get the version reply.

@zhengr
What's the autok3s version and which binary package?
autok3s_darwin_amd64, autok3s_darwin_arm64, autok3s_linux_amd64, autok3s_linux_arm, or autok3s_linux_arm64, ....

I reproduced:
autok3s_linux_amd64 v0.4.9
clamscan autok3s_linux_amd64

Output：
Loading:     8s, ETA:   0s [========================>]    8.62M/8.62M sigs
Compiling:   2s, ETA:   0s [========================>]       41/41 tasks

/Users/yanliu/Downloads/autok3s_linux_amd64: Unix.Packed.Coinminer-6856324-0 FOUND

----------- SCAN SUMMARY -----------
Known viruses: 8619000
Engine version: 0.105.0
Scanned directories: 0
Scanned files: 1
Infected files: 1
Data scanned: 26.36 MB
Data read: 24.75 MB (ratio 1.06:1)
Time: 10.571 sec (0 m 10 s)
Start Date: 2022:06:21 08:20:21
End Date:   2022:06:21 08:20:32

@zhengr

This issue will be fixed in v0.5.1, if you want to use it earlier, try v0.5.1-rc2
This issue is caused by Upx compression

Thanks for quick fix.


minor bug fixed in application path table

Click here if you want to create code_sniffer's auto-correct Pull Request

See the documentation if you want to get more information about auto-correct.
Document


tests under rubinius-1.1.1/1.2.0

As discussed on ruby.cmd.line, includes the 12 errors connected with argument_inspector and 3 other issues.
https://gist.github.com/728503
Run under 64-bit Linux - Ubuntu 10.10 if that helps. Again the issue with argument_inspector is that rubinius does not support set_trace_func so the twelve tests that end up using scrape_with_eval return errors.
As a substitute, you can scrape method parameters with method#parameters but this works only under mri 1.9 and the current stable rubinius. I don't know of any substitute for scraping the default values of parameters.

I'm closing this as boson 0.5 will be smaller. If it still doesn't work on rbx, then we can address in a separate issue ;)

https://gist.github.com/1673645
I really need to do some more testing but I'll try to post my branch this evening. This has been kind of fun.. Learned a ton on this one.
In addition to rbx 1.2.4 the test also passes on 1.8.7, latest ree, 1.9.2, 1.9.3 and even jruby-head but it wags its finger at something I'm doing.
Can't compile 1.9.1 for some reason but probably shouldn't bother. 1.8.6? no chance..


Update docs

Needs wb for Python 3

is that compatible with Python 2?

Yes, it should be.

thanks


D3 multi touch

Hi all,
I'm not sure, whether it's a bug, a feature or probably I simply used the d3 method  incorrectly. My goal was to move two rectangles independently from each other by touching and moving each rect-UI-element at an iPad. However, with d3.svg.touches I was not able to allocate the respective touch event to each one of the rectangles.
Here is what I did and found out.
First, I appended two rectangles to an svg with ids rect1 and rect2, respectively:
var rect1 = chart.append("rect")
.attr("id", "rect1");
var rect2 = chart.append("rect")
.attr("id", "rect2");
Second, in the event handler on "touchmove" I asked for the touch events using
var touches = d3.svg.touches(rect1);
and
var touches = d3.svg.touches(rect2);
respectively.
However, all returned touch events were assigned to object rect2, independent from chosen container and where I touched the screen.
Therefore, I checked the implementation of d3.svg.touches() and found the function "d3.event.touches". This function returned the correct touch events with correct assignments to rect1 and rect2.
Thus, I used it in my code, but still am wondering, what I did wrong with d3.svg.touches.
Can somebody help me here?
Thanks a lot!
Anja

Please use the d3-js group for support questions. Also, see the touches example in the repo:
https://github.com/mbostock/d3/tree/master/examples/touch/touch.html


Update vsphere_vm_clone.rb

Adding windows support

@ezrapagel 4 months later any sign of life ?

I've been helping out with some of the reviews but I've got no way of testing this request.
I can see that the request to add files to the gemspec were never addressed. #137 looks promising but again, no ability for me to test.

Closing as it was incorporated into #137. Thanks for giving us the leg up on this code.


having two ANPs with the same priority must be well-defined

It's unacceptable to say that the behavior when you have two ANPs with the same priority is completely undefined.
We can say that it's undefined which order they are applied in, but it must be the case that it is guaranteed that both are applied, and that two policies with priority: N are both applied in between policies with priority: N+1 and policies with priority: N-1.

Hrm Is there any use cases for having two distinctly separate rules at the same priority? i.e could we allow a single ANP to have multiple Subject/Rule mapping  and then actually say "Users are not allowed to create two ANPs at the same priority"
Or is the problem more so that there's no mechanism for us to actually stop users from creating two ANPs at the same priority?

Hrm Is there any use cases for having two distinctly separate rules at the same priority? i.e could we allow a single ANP to have multiple Subject/Rule mapping and then actually say "Users are not allowed to create two ANPs at the same priority"

yea I can't think of any use case for why I want two ANPs at same prio unless I actually have 100+ ingress and egress rules I want at same priority, so you now need two ANPs at same prio but then again since we have precedence within the single ANP it doesn't make sense because you don't now have a way to compare the two ANPs

Or is the problem more so that there's no mechanism for us to actually stop users from creating two ANPs at the same priority?

I think its this really. If we can perhaps have a CEL expression to ensure priority field is unique across the crds maybe that is something we want to explore?

btw I know this might not be accessible to all because its a slack link, but I wanted to put this here for posterity that I tried to add this validation a few months ago: https://redhat-internal.slack.com/archives/CB48XQ4KZ/p1691419876288429?thread_ts=1691419205.773149&cid=CB48XQ4KZ but couldn't

and we error out

oh, you can't do that. Customers will complain. We tried it with a few things in openshift-sdn (like "you can't have more than one EgressNetworkPolicy object per Namespace and if you do, neither of them works") and that led to us having to figure out a better way to do it in ovn-k EgressFirewall ("an EgressFirewall object must be named 'default'")

Or is the problem more so that there's no mechanism for us to actually stop users from creating two ANPs at the same priority?

This. We can't prevent it from happening, so it doesn't matter if there's a good use case for it or not. It needs clear semantics.
And I think there are good use cases for "two people create ANPs without coordination between them". Iif there is any scenario where it makes sense to include an ANP as part of a helm chart, third-party OLM operator, etc, to ensure some default set of permissions around a component, then you have to assume that eventually two components will ship ANPs with the same priority.

why not sort lexicographical , first priority number, second name

We don't want people to depend on any specific behavior; if there is any situation where someone needs to depend on the relative ordering of two policies with the same priority, then that means that we have failed and priority was not a good API and we need something else.
(eg, there was discussion in the KEP about having a combined Action and Priority, so like first all the "VeryHighPriorityDeny" rules from all policies take effect, then all the "HighPriorityAllow" rules from all policies, then "MediumPriorityDeny", then "LowPriorityAllow", then "VeryLowPriorityDeny". Or vice versa. Nobody could agree on whether the highest priority should be "allow" or "deny". But anyway, that approach would avoid the "conflicting ANPs" problem because any two rules with the same priority would also have the same action and so could be evaluated in either order.)

And I think there are good use cases for "two people create ANPs without coordination between them". Iif there is any scenario where it makes sense to include an ANP as part of a helm chart, third-party OLM operator, etc, to ensure some default set of permissions around a component, then you have to assume that eventually two components will ship ANPs with the same priority.

ok I found a use case for this :D (someone actually asked me this and that's how I found a use case for this); its useful to create two ANPs at same priority currently because we offer no support for tenancy currently, example I have:
tenant: coke and tenant: pepsi labels on coke(nsC,D) and pepsi (nsA,B) tenants. I want to simply express "allow to myself and deny to others". Today we'd need to do two different ANPs for this since subject is pretty much pinned here without tenancy and we have no isSame,notSame peers as well:
ANP1:
  subject:
     namespaces:
        tenant: coke
  peer:
    ingress:
        - allow
          namespaces:
             tenant: coke

ANP2:
  subject:
     namespaces:
        tenant: pepsi
  peer:
    ingress:
        - allow
          namespaces:
             tenant: pepsi

finally the default deny BANP:
  subject:
     namespaces: {}
  peer:
    ingress:
        - deny
          namespaces: {}

now if I have a 100 tenants, I can very easily just create that ANP at same prio they don't overlap at all..

and we error out

oh, you can't do that. Customers will complain. We tried it with a few things in openshift-sdn (like "you can't have more than one EgressNetworkPolicy object per Namespace and if you do, neither of them works") and that led to us having to figure out a better way to do it in ovn-k EgressFirewall ("an EgressFirewall object must be named 'default'")

ah good to know! glad we spoke before we GA-ed this :D I am considering removing this in OVNK and just supporting multiple ANPs at same prio but being very careful around wordings in docs like keep them non-overlapping for best results etc.

It's unacceptable to say that the behavior when you have two ANPs with the same priority is completely undefined.

Why can't we say that this is implementation-specific? AFAIK, here are some current, real vendor implementations:

Error out (yes, customers might complain, but why isn't that the vendor's issue, why is it this SIG's responsibility?).
Have further precedence logic that is documented.
Have further precedence logic that is not documented.

I haven't seen a good argument in this discussion that pertains to API consistency only in this thread. There are plenty of edge cases and undocumented behavior in K8s netpol beyond this issue, is there more context that I'm not getting as to why this issue must must be consistent across vendors? Or do we just need more explicit documentation as to the different ways vendors will handle this problem?

Why can't we say that this is implementation-specific? AFAIK, here are some current, real vendor implementations:

Those are vendor implementations of vendor APIs. And if users want to use those vendor APIs, they already can! They don't need anything from us.
Having a standard k8s API is only beneficial to users if it's standard.

There are plenty of edge cases and undocumented behavior in K8s netpol beyond this issue

I am trying to get rid of as many as possible of them in ANP. (This is one of the big reasons we don't yet have cluster ingress policy; because it's really unclear how to do that in a way that doesn't end up full of implementation-specific behavior.)

I want to reinforce what Dan says, API must define the semantics, not only the fields ...

On the call, we identified quite significant differences between the "natural" implementations for each vendor but we did agree on a lot.  I think we were moving towards agreement that:

Having multiple policies at the same priority is inevitable (can't prevent it in the API therefore it will happen and users would complain if we blocked it anyway).
If the policies do not "overlap" at runtime, there is no problem, we can all enforce the policies and the semantics are intuitive.
We can all make sure that one of the rules from the overlapping policies is applied at runtime (so no undefined behaviour in the C language sense of "may crash, or send packets to the moon").
Overlap depends on the policy and the workloads in the cluster so it's a highly dynamic thing and it cannot be calculated from the policies alone (so we can't try to enforce non-overlap).

The different dataplanes break ties in very different ways that "make sense" for their implementations.

Calico's internal prioritisation includes the policy name to break ties so it breaks ties at the policy level.
(IIUC) Cilium's approach is to group all individual rules by priority and then to prefer deny rules at a given priority.
Antrea allows policies at same priority but I didn't quite catch if there was a tie-breaker or if it was non-deterministic.
OVN errors out right now but may be changing.  Has limits on number of priority levels they can use for this.

My 2p: we should at least document the things that we can agree on.  I suspect that agreeing on a single tie breaker may be very hard given all our constraints.  It may be worth documenting that some vendors prioritise on rules and some prioritise policies.
FWIW, from experience with calico users, overlapping policies is not a common source of issues; worst case, there's an obvious self-directed fix: just use priorities and you can get the behaviour you want.

Can we keep this as simple as denies should win over allows? That seems intuitive to me. A deny-rule, from a security perspective, is more important than an allow. Any other precedence rules after this are unnecessary, right? Even in the case of a broad-deny (for example, a simple deny-all for a specific selector) and a very specific allow (for example, an allow with a specific port and protocol) the deny should win. Are there any other cases? To the extent that a deny and allow are disjoint the allow-rule can still allow traffic.

I'm currently thinking the rule should be: "Every ANP should have a unique priority value. If two (or more) ANPs have the same priority value, and match the same connection, then only one of them will be applied to the connection. (It is implementation-defined which one.)"

This works.


[VARIABLE_REQUEST] Player movement speed

I suggest adding a variable that will return the player's movement speed (any movement, be it running, falling, flying, riding, etc.).
You can also add a second similar variable that will display only the player's horizontal movement speed (the most objective indicator of a player's speed).
Movement speed can be measured in blocks per second ("BPS").
If the player is at rest, the variable will return zero ("0.00").
If the player starts moving (or something starts moving or pushing him away), the variable will start returning a value greater than zero.
I have seen a similar parameter in the "KronHUD" mod that got stuck on 1.20.1.
Sorry for no screenshots :]

so 2 variables, one for all directions and one for only the X and Z axis?

yup

Done, I've published 3.5.1 both on GitHub and Modrinth but CurseForge... is being CurseForge... And is having issues with the upload (It's been happening for the past 7 releases, so much that I held back some versions and not uploaded them to CurseForge because I don't want to deal with this) , I've contacted support but don't expect this to be resolved soon because I think they're also kinda tired of this one mod with only 200 downloads somehow breaking their software with every release... I bet they look at this GitHub and watch every PR to prepare their servers for another release of Hudder...
If you have any issues feel free to reply, if you are pleased with the change please click the "Close issue" button below. Also if you use CurseForge I advise you switch to Modrinth to make the experience of developers like me so much smoother, this is not the only issue I faced with CurseForge and it won't be the last, Modrinth is not perfect but it has never took 2 weeks to approve an update, it never just said "Woopsie, we failed to upload the file ig that's your issue now."

Oh, that's good
I think your mod has a lot of potential thanks to this approach to config settings.
As for the CurseForge, I hardly use it. I hope these problems will be resolved soon.
I haven't tested the new feature yet, as I had problems launching it on 1.20.4 (it turns out that I was running the mod version 3.0.0 before).
If I don't figure it out myself, I'll create a new issue


SSL Configuration stuck - Route 53 domain

Before opening, please confirm:

[X] I have checked the custom domains troubleshooting guide.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
dpm5giteybegs
Region
eu-west-2
Step
SSL Configuration
Status
SSL configuration
Issue or question
Im trying to set up another domain for my app. I have my domain hosted in Route53 in the same account and i can see that both the CNAMEs are configured perfectly.
Yet the domain registration is still stuck on SSL Configuration
Error message
No response
Additional information
No response

Hi @omri-shilton 👋 , I observed that you have been able to successfully connect a custom domain to your Amplify app dpm5giteybegs. Are you still running into this issue?

Observed similar, but temporary, behavior given the following environment:
Before opening, please confirm:

[x]  I have checked the custom domains troubleshooting guide.

[x]  I have read the guide for submitting bug reports.

[x]  I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
dy6ewpr2d09ta
Region
us-east-1
Step
SSL Configuration
Status
SSL configuration
Issue or question
Custom domain registration for Amplify app. Amplify app created 2023-08-15 @ 12:51:46 (EST). Once application was in running state, a custom domain (xptech.help) was registered via Route53 with "Domain registration successful" sent at 2023-08-15 13:31:39. Amplify Domain management process fired after verifying DNS records were had "INSYNC" status. SSL Configuration step creates CNAME record within Route53 instantly upon step initiation, but appears to hang until ~14:05 (~30min) which could lead to erronous ticket creation. Followed troubleshooting steps to verify name servers matched in meantime and typed out most of this comment checking back and forth.
TLDR - Suggest UX improvement of message to user during "SSL Verification" indicating process could take ~30min/1hr/2hr for recently created Route53 domains if not a fluke/recurring issue.
Appreciate the team, really simple workflows and overall great experience!

Hi @XPGeek 👋 , thanks for reaching out and for sharing detailed feedback on the domain activation process with Amplify Hosting for newly created domains with Route53. I'll relay this feedback to the team internally on improving the console experience.


support to set cpu model with more detail

fix #727

This change is

@jellonek PTAL

@jellonek    done, PTAL


Jeff Frasca sign OpenTF manifesto as individual

I'm an SRE and goland progammer, and I've been using terraform for many years now.  It's an integral part of my workflow for managing cloud infrastructure, particularly AWS.  I've introduced it to multiple companies professionally, and I use it for maintaining personal infrastructure.
I was incredibly dismayed by Hashicorp adopting the BSL, and I was trying to figure out who to reach out to about a possible fork.  Thank you for organizing this and making a big public stand.  I will be using OpenTF for future upgrades to my tooling both personally and professionally, and I hope to be able to contribute to ongoing development efforts.

Thanks for your support!


all: Use Go 1.16 in publish_artifacts and install_golang jobs in Circle

Might be nice to update the go.mod as well so everything is in sync?

@leighmcculloch @paulbellamy any idea why there's a difference in go.mod when I update it to contain go 1.16?
diff --git a/go.mod b/go.mod
index 5869a7f62..e8968f811 100644
--- a/go.mod
+++ b/go.mod
@@ -30,7 +30,6 @@ require (
 	github.com/inconshreveable/mousetrap v1.0.0 // indirect
 	github.com/jarcoal/httpmock v0.0.0-20161210151336-4442edb3db31
 	github.com/jmoiron/sqlx v1.2.0
-	github.com/k0kubun/colorstring v0.0.0-20150214042306-9440f1994b88 // indirect
 	github.com/klauspost/compress v0.0.0-20161106143436-e3b7981a12dd // indirect
 	github.com/klauspost/cpuid v0.0.0-20160302075316-09cded8978dc // indirect
 	github.com/klauspost/crc32 v0.0.0-20161016154125-cb6bfca970f6 // indirect

I don't know why it is being removed, but if you run go mod why -m <module> it should show you what import is pulling it in, and it might be that the import was captured in a transient dependencies module file and there was a bug and it wasn't supposed to be here. My only concern would be if our dependencies are changing, if go.list is also changing.
go.mod stability is only guaranteed for a single Go release. You can remove check_code_1_15 too because of that.

Oh wait, go.list is changing. 🤔
https://github.com/stellar/go/pull/3446/files#diff-c5cdb981e916e8188a50107f8f2465b9b4aabf3984b86c48eadde294c5915d68R59-R60

go.mod stability is only guaranteed for a single Go release. You can remove check_code_1_15 too because of that.

That was it, I realized that I got 1.15 or 1.16 failure depending what I've changed. I removed check_code_1_15 job.

Regarding the dependency disappearing, this is the go mod why when running on Go 1.15:

Thanks for explanations, makes sense!

Root readme needs updating

OK, to sum it up in https://github.com/stellar/go/pull/3446/commits/d0e81c6d4ebcb56d0d0498a034dd71f2b303d1ae I update go.mod Go version to 1.15 and removed all references to specific Golang version in all .md files, instead I added a note about supporting two latest versions.


Guam updates 4/2

Set active phase to 16+

[{"key":"guam","type":"vaccination","value":{"content":{"activePhase":"16_and_older","phases":[{"id":"1a","qualifications":[{"question":"c19.eligibility.question/healthcare_worker"},{"question":"c19.eligibility.question/long_term_care_resident.are"},{"question":"c19.eligibility.question/age.are"},{"question":"c19.eligibility.question/essential_worker.1b"},{"question":"c19.eligibility.question/essential_worker.are_you_an_essential"},{"question":"c19.eligibility.question/healthcare_worker.are"}]},{"id":"1b","qualifications":[{"question":"c19.eligibility.question/healthcare_worker"},{"question":"c19.eligibility.question/long_term_care_resident"},{"question":"c19.eligibility.question/essential_worker.1b"},{"question":"c19.eligibility.question/age.75_up"}]},{"id":"1c","qualifications":[{"question":"c19.eligibility.question/healthcare_worker"},{"question":"c19.eligibility.question/long_term_care_resident"},{"question":"c19.eligibility.question/essential_worker"},{"question":"c19.eligibility.question/health"},{"question":"c19.eligibility.question/age.65_up"}]},{"id":"16_and_older","label":"16 and older","qualifications":[{"question":"c19.eligibility.question/age.16_up","moreInfoText":"c19.eligibility.moreinfo/age.16_up.gu.16_and_older"}]}],"noPhaseLabel":true}}},{"key":"guam","type":"strings","value":{"content":{"c19.eligibility.moreinfo/age.16_up.gu.16_and_older":{"en-us":"Minors may only receive the Pfizer-BioNTech COVID-19 vaccine as the Moderna and Johnson & Johnson/Janssen (J&J/Janssen) vaccines are not recommended for individuals below the age of 18. Minors must be accompanied by a parent or legal guardian and provide government-issued identification to validate age.\n\nUpon arrival at vaccination events, individuals 60 years and older may be sent to the front of the line."}}}}]


Fix resolving of literal paths in configuration. (issue #428 )

Resolve paths in config e.g. with $HOME or ~:
CHAT_CACHE_PATH=$HOME/.cache/shell_gpt/chat_cache
CACHE_PATH=$HOME/.cache/shell_gpt/cache
ROLE_STORAGE_PATH=$HOME/.config/shell_gpt/roles
``

or

CHAT_CACHE_PATH=~/.cache/shell_gpt/chat_cache
CACHE_PATH=~/.cache/shell_gpt/cache
ROLE_STORAGE_PATH=~/.config/shell_gpt/roles

issue: #428

Closing this PR due to its age and inactivity.  Please feel free to open a new pull request with updates.


Adding Linux build to Travis CI

Checklist

[x] I checked the Contributing Guidelines before creating this request.
[ ] New extensions are written in Swift 4.
[ ] New extensions support iOS 8.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+.
[ ] I have added tests for new extensions, and they passed.
[ ] All extensions have a clear comments explaining their functionality, all parameters and return type in English.
[ ] All extensions are declared as public.
[ ] I have added a changelog entry describing my changes.

          1 Warning

:warning:
This pull request is marked as Work in Progress. DO NOT MERGE!

          4 Messages

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

:book:
iOS: Executed 534 tests, with 0 failures (0 unexpected) in 10.746 (11.896) seconds

:book:
tvOS: Executed 500 tests, with 0 failures (0 unexpected) in 1.828 (2.208) seconds

:book:
macOS: Executed 364 tests, with 0 failures (0 unexpected) in 0.778 (1.013) seconds

  Generated by :no_entry_sign: Danger

@LucianoPAlmeida While the project is compiling with no problem on Linux, tests are another story 😄, I think we need to spend more time on this

@guykogus I think we can do this 👍

Guys, we are facing some segfaults on some date extensions because of some issues on core-libs-foundation.
See SR-10147 and SR-9101
We should probably stale this for while or disable those extensions on Linux for now.
cc @omaralbeik

          1 Warning

:warning:
The source files have been modified. Please consider adding a CHANGELOG entry if necessary.

          4 Messages

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

:book:
iOS: Executed 534 tests, with 0 failures (0 unexpected) in 11.468 (13.185) seconds

:book:
tvOS: Executed 509 tests, with 0 failures (0 unexpected) in 1.827 (2.252) seconds

:book:
macOS: Executed 376 tests, with 0 failures (0 unexpected) in 0.812 (1.104) seconds

SwiftLint found issues
Warnings

File
Line
Reason

StringExtensionsTests.swift
275
Lines should not have trailing whitespace. (trailing_whitespace)

XCTestManifests.swift
9
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
20
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
86
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
98
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
107
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
116
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
131
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
146
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
155
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
168
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
183
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
16
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
25
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
34
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
44
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
64
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
78
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
88
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
110
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
122
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
134
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
150
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
172
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
187
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
196
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
212
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
235
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
252
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
262
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
354
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
363
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
388
Collection literals should not have trailing commas. (trailing_comma)

Errors

File
Line
Reason

XCTestManifests.swift
8
Variable name should only contain alphanumeric characters: '__allTests__CalendarExtensionTests' (identifier_name)

XCTestManifests.swift
17
Variable name should only contain alphanumeric characters: '__allTests__DataExtensionsTests' (identifier_name)

XCTestManifests.swift
28
Variable name should only contain alphanumeric characters: '__allTests__DateExtensionsTests' (identifier_name)

XCTestManifests.swift
94
Variable name should only contain alphanumeric characters: '__allTests__FileManagerExtensionsTests' (identifier_name)

XCTestManifests.swift
106
Variable name should only contain alphanumeric characters: '__allTests__LocaleExtensionsTests' (identifier_name)

XCTestManifests.swift
115
Variable name should only contain alphanumeric characters: '__allTests__NSAttributedStringExtensionsTests' (identifier_name)

XCTestManifests.swift
124
Variable name should only contain alphanumeric characters: '__allTests__NSPredicateExtensionsTests' (identifier_name)

XCTestManifests.swift
139
Variable name should only contain alphanumeric characters: '__allTests__URLExtensionsTests' (identifier_name)

XCTestManifests.swift
154
Variable name should only contain alphanumeric characters: '__allTests__URLRequestExtensionsTests' (identifier_name)

XCTestManifests.swift
163
Variable name should only contain alphanumeric characters: '__allTests__UserDefaultsExtensionsTests' (identifier_name)

XCTestManifests.swift
172
Function name should start with a lowercase character: '__allTests()' (identifier_name)

XCTestManifests.swift
8
Variable name should only contain alphanumeric characters: '__allTests__ArrayExtensionsTests' (identifier_name)

XCTestManifests.swift
24
Variable name should only contain alphanumeric characters: '__allTests__BidirectionalCollectionExtensionsTests' (identifier_name)

XCTestManifests.swift
33
Variable name should only contain alphanumeric characters: '__allTests__BinaryFloatingPointExtensionsTests' (identifier_name)

XCTestManifests.swift
42
Variable name should only contain alphanumeric characters: '__allTests__BoolExtensionsTests' (identifier_name)

XCTestManifests.swift
52
Variable name should only contain alphanumeric characters: '__allTests__CharacterExtensionsTests' (identifier_name)

XCTestManifests.swift
72
Variable name should only contain alphanumeric characters: '__allTests__CollectionExtensionsTests' (identifier_name)

XCTestManifests.swift
86
Variable name should only contain alphanumeric characters: '__allTests__ComparableExtensionsTests' (identifier_name)

XCTestManifests.swift
96
Variable name should only contain alphanumeric characters: '__allTests__DictionaryExtensionsTests' (identifier_name)

XCTestManifests.swift
118
Variable name should only contain alphanumeric characters: '__allTests__DoubleExtensionsTests' (identifier_name)

XCTestManifests.swift
130
Variable name should only contain alphanumeric characters: '__allTests__FloatExtensionsTests' (identifier_name)

XCTestManifests.swift
142
Variable name should only contain alphanumeric characters: '__allTests__FloatingPointExtensionsTests' (identifier_name)

XCTestManifests.swift
158
Variable name should only contain alphanumeric characters: '__allTests__IntExtensionsTests' (identifier_name)

XCTestManifests.swift
180
Variable name should only contain alphanumeric characters: '__allTests__OptionalExtensionsTests' (identifier_name)

XCTestManifests.swift
195
Variable name should only contain alphanumeric characters: '__allTests__RandomAccessCollectionExtensionsTests' (identifier_name)

XCTestManifests.swift
204
Variable name should only contain alphanumeric characters: '__allTests__RangeReplaceableCollectionTests' (identifier_name)

XCTestManifests.swift
220
Variable name should only contain alphanumeric characters: '__allTests__SequenceExtensionsTests' (identifier_name)

XCTestManifests.swift
243
Variable name should only contain alphanumeric characters: '__allTests__SignedIntegerExtensionsTests' (identifier_name)

XCTestManifests.swift
260
Variable name should only contain alphanumeric characters: '__allTests__SignedNumericExtensionsTests' (identifier_name)

XCTestManifests.swift
270
Variable name should only contain alphanumeric characters: '__allTests__StringExtensionsTests' (identifier_name)

XCTestManifests.swift
362
Variable name should only contain alphanumeric characters: '__allTests__StringProtocolExtensionsTests' (identifier_name)

XCTestManifests.swift
367
Function name should start with a lowercase character: '__allTests()' (identifier_name)

  Generated by :no_entry_sign: Danger

          1 Warning

:warning:
The source files have been modified. Please consider adding a CHANGELOG entry if necessary.

          4 Messages

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

:book:
iOS: Executed 534 tests, with 0 failures (0 unexpected) in 11.172 (12.515) seconds

:book:
tvOS: Executed 509 tests, with 0 failures (0 unexpected) in 2.418 (3.048) seconds

:book:
macOS: Executed 376 tests, with 0 failures (0 unexpected) in 0.815 (1.079) seconds

SwiftLint found issues
Warnings

File
Line
Reason

DateExtensionsTests.swift
673
Lines should not have trailing whitespace. (trailing_whitespace)

XCTestManifests.swift
9
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
20
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
86
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
98
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
107
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
116
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
131
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
146
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
155
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
168
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
183
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
16
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
25
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
34
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
44
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
64
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
78
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
88
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
110
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
122
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
134
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
150
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
172
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
187
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
196
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
212
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
235
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
252
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
262
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
354
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
363
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
388
Collection literals should not have trailing commas. (trailing_comma)

Errors

File
Line
Reason

XCTestManifests.swift
8
Variable name should only contain alphanumeric characters: '__allTests__CalendarExtensionTests' (identifier_name)

XCTestManifests.swift
17
Variable name should only contain alphanumeric characters: '__allTests__DataExtensionsTests' (identifier_name)

XCTestManifests.swift
28
Variable name should only contain alphanumeric characters: '__allTests__DateExtensionsTests' (identifier_name)

XCTestManifests.swift
94
Variable name should only contain alphanumeric characters: '__allTests__FileManagerExtensionsTests' (identifier_name)

XCTestManifests.swift
106
Variable name should only contain alphanumeric characters: '__allTests__LocaleExtensionsTests' (identifier_name)

XCTestManifests.swift
115
Variable name should only contain alphanumeric characters: '__allTests__NSAttributedStringExtensionsTests' (identifier_name)

XCTestManifests.swift
124
Variable name should only contain alphanumeric characters: '__allTests__NSPredicateExtensionsTests' (identifier_name)

XCTestManifests.swift
139
Variable name should only contain alphanumeric characters: '__allTests__URLExtensionsTests' (identifier_name)

XCTestManifests.swift
154
Variable name should only contain alphanumeric characters: '__allTests__URLRequestExtensionsTests' (identifier_name)

XCTestManifests.swift
163
Variable name should only contain alphanumeric characters: '__allTests__UserDefaultsExtensionsTests' (identifier_name)

XCTestManifests.swift
172
Function name should start with a lowercase character: '__allTests()' (identifier_name)

XCTestManifests.swift
8
Variable name should only contain alphanumeric characters: '__allTests__ArrayExtensionsTests' (identifier_name)

XCTestManifests.swift
24
Variable name should only contain alphanumeric characters: '__allTests__BidirectionalCollectionExtensionsTests' (identifier_name)

XCTestManifests.swift
33
Variable name should only contain alphanumeric characters: '__allTests__BinaryFloatingPointExtensionsTests' (identifier_name)

XCTestManifests.swift
42
Variable name should only contain alphanumeric characters: '__allTests__BoolExtensionsTests' (identifier_name)

XCTestManifests.swift
52
Variable name should only contain alphanumeric characters: '__allTests__CharacterExtensionsTests' (identifier_name)

XCTestManifests.swift
72
Variable name should only contain alphanumeric characters: '__allTests__CollectionExtensionsTests' (identifier_name)

XCTestManifests.swift
86
Variable name should only contain alphanumeric characters: '__allTests__ComparableExtensionsTests' (identifier_name)

XCTestManifests.swift
96
Variable name should only contain alphanumeric characters: '__allTests__DictionaryExtensionsTests' (identifier_name)

XCTestManifests.swift
118
Variable name should only contain alphanumeric characters: '__allTests__DoubleExtensionsTests' (identifier_name)

XCTestManifests.swift
130
Variable name should only contain alphanumeric characters: '__allTests__FloatExtensionsTests' (identifier_name)

XCTestManifests.swift
142
Variable name should only contain alphanumeric characters: '__allTests__FloatingPointExtensionsTests' (identifier_name)

XCTestManifests.swift
158
Variable name should only contain alphanumeric characters: '__allTests__IntExtensionsTests' (identifier_name)

XCTestManifests.swift
180
Variable name should only contain alphanumeric characters: '__allTests__OptionalExtensionsTests' (identifier_name)

XCTestManifests.swift
195
Variable name should only contain alphanumeric characters: '__allTests__RandomAccessCollectionExtensionsTests' (identifier_name)

XCTestManifests.swift
204
Variable name should only contain alphanumeric characters: '__allTests__RangeReplaceableCollectionTests' (identifier_name)

XCTestManifests.swift
220
Variable name should only contain alphanumeric characters: '__allTests__SequenceExtensionsTests' (identifier_name)

XCTestManifests.swift
243
Variable name should only contain alphanumeric characters: '__allTests__SignedIntegerExtensionsTests' (identifier_name)

XCTestManifests.swift
260
Variable name should only contain alphanumeric characters: '__allTests__SignedNumericExtensionsTests' (identifier_name)

XCTestManifests.swift
270
Variable name should only contain alphanumeric characters: '__allTests__StringExtensionsTests' (identifier_name)

XCTestManifests.swift
362
Variable name should only contain alphanumeric characters: '__allTests__StringProtocolExtensionsTests' (identifier_name)

XCTestManifests.swift
367
Function name should start with a lowercase character: '__allTests()' (identifier_name)

  Generated by :no_entry_sign: Danger

          1 Warning

:warning:
The source files have been modified. Please consider adding a CHANGELOG entry if necessary.

          4 Messages

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

:book:
iOS: Executed 534 tests, with 0 failures (0 unexpected) in 10.884 (12.282) seconds

:book:
tvOS: Executed 509 tests, with 0 failures (0 unexpected) in 1.950 (2.452) seconds

:book:
macOS: Executed 376 tests, with 0 failures (0 unexpected) in 0.917 (1.185) seconds

SwiftLint found issues
Warnings

File
Line
Reason

XCTestManifests.swift
9
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
20
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
86
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
98
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
107
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
116
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
131
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
146
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
155
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
168
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
183
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
16
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
25
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
34
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
44
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
64
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
78
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
88
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
110
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
122
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
134
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
150
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
172
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
187
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
196
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
212
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
235
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
252
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
262
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
354
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
363
Collection literals should not have trailing commas. (trailing_comma)

XCTestManifests.swift
388
Collection literals should not have trailing commas. (trailing_comma)

Errors

File
Line
Reason

XCTestManifests.swift
8
Variable name should only contain alphanumeric characters: '__allTests__CalendarExtensionTests' (identifier_name)

XCTestManifests.swift
17
Variable name should only contain alphanumeric characters: '__allTests__DataExtensionsTests' (identifier_name)

XCTestManifests.swift
28
Variable name should only contain alphanumeric characters: '__allTests__DateExtensionsTests' (identifier_name)

XCTestManifests.swift
94
Variable name should only contain alphanumeric characters: '__allTests__FileManagerExtensionsTests' (identifier_name)

XCTestManifests.swift
106
Variable name should only contain alphanumeric characters: '__allTests__LocaleExtensionsTests' (identifier_name)

XCTestManifests.swift
115
Variable name should only contain alphanumeric characters: '__allTests__NSAttributedStringExtensionsTests' (identifier_name)

XCTestManifests.swift
124
Variable name should only contain alphanumeric characters: '__allTests__NSPredicateExtensionsTests' (identifier_name)

XCTestManifests.swift
139
Variable name should only contain alphanumeric characters: '__allTests__URLExtensionsTests' (identifier_name)

XCTestManifests.swift
154
Variable name should only contain alphanumeric characters: '__allTests__URLRequestExtensionsTests' (identifier_name)

XCTestManifests.swift
163
Variable name should only contain alphanumeric characters: '__allTests__UserDefaultsExtensionsTests' (identifier_name)

XCTestManifests.swift
172
Function name should start with a lowercase character: '__allTests()' (identifier_name)

XCTestManifests.swift
8
Variable name should only contain alphanumeric characters: '__allTests__ArrayExtensionsTests' (identifier_name)

XCTestManifests.swift
24
Variable name should only contain alphanumeric characters: '__allTests__BidirectionalCollectionExtensionsTests' (identifier_name)

XCTestManifests.swift
33
Variable name should only contain alphanumeric characters: '__allTests__BinaryFloatingPointExtensionsTests' (identifier_name)

XCTestManifests.swift
42
Variable name should only contain alphanumeric characters: '__allTests__BoolExtensionsTests' (identifier_name)

XCTestManifests.swift
52
Variable name should only contain alphanumeric characters: '__allTests__CharacterExtensionsTests' (identifier_name)

XCTestManifests.swift
72
Variable name should only contain alphanumeric characters: '__allTests__CollectionExtensionsTests' (identifier_name)

XCTestManifests.swift
86
Variable name should only contain alphanumeric characters: '__allTests__ComparableExtensionsTests' (identifier_name)

XCTestManifests.swift
96
Variable name should only contain alphanumeric characters: '__allTests__DictionaryExtensionsTests' (identifier_name)

XCTestManifests.swift
118
Variable name should only contain alphanumeric characters: '__allTests__DoubleExtensionsTests' (identifier_name)

XCTestManifests.swift
130
Variable name should only contain alphanumeric characters: '__allTests__FloatExtensionsTests' (identifier_name)

XCTestManifests.swift
142
Variable name should only contain alphanumeric characters: '__allTests__FloatingPointExtensionsTests' (identifier_name)

XCTestManifests.swift
158
Variable name should only contain alphanumeric characters: '__allTests__IntExtensionsTests' (identifier_name)

XCTestManifests.swift
180
Variable name should only contain alphanumeric characters: '__allTests__OptionalExtensionsTests' (identifier_name)

XCTestManifests.swift
195
Variable name should only contain alphanumeric characters: '__allTests__RandomAccessCollectionExtensionsTests' (identifier_name)

XCTestManifests.swift
204
Variable name should only contain alphanumeric characters: '__allTests__RangeReplaceableCollectionTests' (identifier_name)

XCTestManifests.swift
220
Variable name should only contain alphanumeric characters: '__allTests__SequenceExtensionsTests' (identifier_name)

XCTestManifests.swift
243
Variable name should only contain alphanumeric characters: '__allTests__SignedIntegerExtensionsTests' (identifier_name)

XCTestManifests.swift
260
Variable name should only contain alphanumeric characters: '__allTests__SignedNumericExtensionsTests' (identifier_name)

XCTestManifests.swift
270
Variable name should only contain alphanumeric characters: '__allTests__StringExtensionsTests' (identifier_name)

XCTestManifests.swift
362
Variable name should only contain alphanumeric characters: '__allTests__StringProtocolExtensionsTests' (identifier_name)

XCTestManifests.swift
367
Function name should start with a lowercase character: '__allTests()' (identifier_name)

  Generated by :no_entry_sign: Danger

          1 Warning

:warning:
The source files have been modified. Please consider adding a CHANGELOG entry if necessary.

          4 Messages

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

:book:
iOS: Executed 534 tests, with 0 failures (0 unexpected) in 10.586 (12.026) seconds

:book:
tvOS: Executed 509 tests, with 0 failures (0 unexpected) in 2.175 (2.756) seconds

:book:
macOS: Executed 376 tests, with 0 failures (0 unexpected) in 0.939 (1.175) seconds

  Generated by :no_entry_sign: Danger

Thank you @LucianoPAlmeida for taking care of this, awesome work!


Transloco - Testing with Spectator

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior
transloco-root.module.ts
import { NgModule } from '@angular/core';
import {
  TRANSLOCO_CONFIG,
  TRANSLOCO_LOADER,
  translocoConfig,
  TranslocoModule,
} from '@ngneat/transloco';

import { TranslocoService } from '@core/services';
import { environment } from '@env/environment';

@NgModule({
  exports: [TranslocoModule],
  providers: [
    {
      provide: TRANSLOCO_CONFIG,
      useValue: translocoConfig({
        availableLangs: ['en'],
        defaultLang: 'en',
        reRenderOnLangChange: true,
        prodMode: environment.production,
      }),
    },
    { provide: TRANSLOCO_LOADER, useClass: TranslocoService },
  ],
})
export class TranslocoRootModule {}

transloco-root.ts
import { TranslocoConfig, TranslocoTestingModule } from '@ngneat/transloco';

export function getTranslocoModule(config: Partial<TranslocoConfig> = {}) {
  return TranslocoTestingModule.withLangs(
    {},
    {
      availableLangs: ['en', 'es'],
      defaultLang: 'en',
      ...config,
    },
  );
}

My Test File
describe('SignInFormComponent', () => {
  let spectator: Spectator<SignInFormComponent>;
  const createComponent = createComponentFactory({
    component: SignInFormComponent,
    mocks: [SignInService],
    imports: [
      ......
      getTranslocoModule(),
      .......
    ],
  });

  beforeEach(() => (spectator = createComponent()));

  it('should create', () => {
    expect(spectator).toBeTruthy();
  });
});

Getting:
Unexpected value 'TranslocoTestingModule' imported by the module 'DynamicTestModule'. Please add an @NgModule annotation.

OR
Error: Importing TranslocoModule which does not have a ɵmod property

Expected behavior
It should pass the test

Minimal reproduction of the problem with instructions
For bug reports please provide the STEPS TO REPRODUCE and if possible a MINIMAL DEMO of the problem, for that you could use our stackblitz example
What is the motivation / use case for changing the behavior?

Environment
    "@angular/animations": "~9.1.9",
    "@angular/cdk": "^9.2.4",
    "@angular/common": "~9.1.9",
    "@angular/compiler": "~9.1.9",
    "@angular/core": "~9.1.9",
    "@angular/forms": "~9.1.9",
    "@angular/material": "^9.2.4",
    "@angular/platform-browser": "~9.1.9",
    "@angular/platform-browser-dynamic": "~9.1.9",
    "@angular/router": "~9.1.9",
    "@angular/service-worker": "~9.1.9",
    "@ngneat/transloco": "^2.17.2",
    "@ngxs/router-plugin": "^3.6.2",
    "@ngxs/store": "^3.6.2",
    "file-saver": "^2.0.2",
    "ftp-deploy": "^2.3.7",
    "moment": "^2.26.0",
    "ng-inline-svg": "^10.1.0",
    "normalize.css": "^8.0.1",
    "rfdc": "^1.1.4",
    "rxjs": "~6.5.4",
    "tslib": "^1.10.0",
    "zone.js": "~0.10.2"

Angular version: 9.1.9

Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:
- Node version: v14.4.0
- Platform:  Mac

Others:

https://www.loom.com/share/689a8b951f1143ffa1b84b721ca84c90

I was having the same issue and wiped out my node_modules folder, ran npm i again and it worked after that. Thinking it may have been an issue with ngcc step the first time I installed it. Hopefully that fixes it for you as well.

@Kamieniu Any update on the reproduction? did you try what @micahwood suggested? 🙂

@Kamieniu I'm closing this for now. Please feel free to reopen if this still occurs.
If you do reopen, please provide a reproduction 🙂

I can confirm that reinstalling node modules works. Running ngcc might be OK too.

I had the same problem. I reinstalled node_modules with npm ci and it helped.


Add to Nuget Packages

Hi,
I use this library in from .net projects like asp.net mvc by visual studio, so I can't use this in vs.
Please add this project release in Nuget.org for Nuget package users.
Thank a lot


android thorium doesn't support image pasting.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like, including relevant patches or source
A clear and concise description of what you want to happen.
Additional Notes
Add any other context or screenshots about the feature request here.

@Summit-ridge Please clarify what you mean by "image pasting".
Then I can try to reproduce on Android ARM32 version.


Polygon & Circle onTap both not working

Hi,
I'm using google map, but when I onTap on Polygon or Circle, both are not working
thank you

Idk

Hi @andywuwork
Can you please provide your flutter doctor -v, your flutter run --verbose and a minimal complete reproducible code sample.
Thank you

doctor-v.txt
run--verbose.txt
test-code.txt
thank you for your help

Hi @andywuwork
Looks like you have not enabled your Circle, Polygon to consume tap events.
        Circle(
            circleId: CircleId(circleIdVal),
            center: point,
            radius: radius,
            consumeTapEvents: true, // This need to be true, to allow this circle to be clickable.
            fillColor: Colors.redAccent.withOpacity(0.5),
            strokeWidth: 3,
            strokeColor: Colors.redAccent,
            onTap: () {
              print('Circle click');
            }
        )

Use the consumeTapEvents of your Circle and Polygon to enable them to handle the onTap event.
Closing this as invalid Flutter issue. If you disagree please write a comment bellow and I will reopen it.

Hi,
It's working, thank you.
Could I ask why use flag to controll onTap event?

Hi @andywuwork
I have no idea, but I. know that this just follow the implementation of the original Android Google Maps API. You can follow the link below to read more about it.
https://developers.google.com/android/reference/com/google/android/gms/maps/model/Circle#setClickable(boolean)

Hi,
thank you very much


#1270: Feign load balancer respects Ribbon.IsSecure as false for securable service

Related to issue #1270  Feign load balancer respects Ribbon.IsSecure being set to false even when a discovered service has a secure port enabled in addition to a non-secure port enabled.

Current coverage is 73.12% (diff: 57.14%)

Merging #1275 into master will decrease coverage by 0.04%

@@             master      #1275   diff @@
==========================================
  Files           184        184
  Lines          5519       5525     +6
  Methods           0          0
  Messages          0          0
  Branches        846        850     +4
==========================================
+ Hits           4038       4040     +2
- Misses         1170       1173     +3
- Partials        311        312     +1

Powered by Codecov. Last update cb44cd2...1931545

So I copied FeignLoadBalancerTest over to s-c-n-eureka-client and modified testInsecureUriFromInsecureClientConfigToOptionallySecureServer to use the EurekaServerIntrospector without your changes and it passed. If DiscoveryEnabledNIWSServerList sets isSecure correctly on DiscoveryEnabledServer this should work. I'd like to see either a test that fails or a project that reproduces the problem.

@spencergibb Are you having that EurekaServerIntrospector indicate that its secure port is enabled? If so, the test should fail without this pull request.
This fails from s-c-n-eureka-client on the master branch:
@Test
@SneakyThrows
public void testInsecureUriFromInsecureClientConfigToOptionallySecureServer() {
    ServerIntrospector eurekaIntrospector = Mockito.mock(EurekaServerIntrospector.class);
    when(eurekaIntrospector.isSecure(Mockito.any(Server.class))).thenReturn(true);

    when(this.config.get(IsSecure, false)).thenReturn(false);
    this.feignLoadBalancer = new FeignLoadBalancer(this.lb, this.config, eurekaIntrospector);
    Server server = new Server("foo", 7777);
    URI uri = this.feignLoadBalancer.reconstructURIWithServer(server, new URI("http://foo/"));
    assertThat(uri, is(new URI("http://foo:7777/")));
}

The scenario is having a service with both a secure port enabled and an insecure port enabled. Then, having a FeignClient with ribbon.IsSecure=false, wanting to use the service's insecure port. So, ribbon.IsSecure will cause the server list to be populated with "service:80". But later on, only because the service offers a secure port, and regardless of IsSecure=false and nonSecurePortEnabled=true, the URL becomes "https://service:80"

But ribbon.IsSecure=false is used in DiscoveryEnabledNIWSServerList. This is what I'm trying to reconcile. If that is not working we need to fix that.

DiscoveryEnabledNIWSServerList works as I'd expect. ribbon.IsSecure=false will cause it to add "service:insecurePort" to the server list and ribbon.IsSecure=true will cause it to add "service:securePort" to the server list.
Personally, I wish both ports were carried along with the Server so that I could dynamically set @FeignClient("${dynamicProtocol}:/myservice") and only have ribbon.IsSecure override the URI protocol and port if I didn't explicitly specify a protocol. But that's a separate discussion and I wanted to take baby steps.
Anyway, the URI rewrite logic that comes later in the FeignLoadBalancer will overwrite the URI with https if ribbon.IsSecure=true. So, if DiscoveryEnabledNIWSServerList is only going to provide one port when both secure and non-secure are available, it is correctly providing a port that reflects ribbon.IsSecure.

Ok, so if ribbon.IsSecure=false works in DiscoveryEnabledNIWSServerList why would it be different when it gets to FeignLoadBalancer?

Because when support for ServerIntrospector was added to FeignLoadBalancer last September, the following code appeared, which overwrites the protocol with https either when ribbon.IsSecure=true or when the discovered server makes a secure port available:
    if (!"https".equals(scheme) && (this.serverIntrospector.isSecure(server)
            || this.clientConfig.get(CommonClientConfigKey.IsSecure, false))) {

ServerIntrospector.isSecure is used in other places as well. This would make the use inconsistent. Marking for discussion.

Can you provide a project that reproduces the problem?

This demo project reproduces the problem:
https://github.com/rhutzel/bug-demo-spring-secured-feign

Thanks for the demo project. That helped me understand the case where it was happening. I decided to do things a bit differently. If ribbon.IsSecure is set, that value will be used, otherwise, the ServerIntrospector will be called. All three places that have similar functionality all use the same code now.
Closing in favor of 43adc84dfdfc33f3be0268e09b193afc82f9bf9a.

@rhutzel will you try with snapshots when they are available? This is in master and cherry picked to 1.1.x.

@spencergibb Of course. I like the approach that you took. Thank you for being so responsive.

And thanks to you @rhutzel for being patient with me as I was trying to understand. I did run your sample with the fix, though I broke the 1.1.x build.

@spencergibb Verified against spring-cloud-netflix:1.1.6.BUILD-SNAPSHOT  It resolves the issue in my sample project. Also, with your new logic, the client still responds to ribbon.IsSecure: true as expected.


TC_06_Downpayment_Mismatch

Quote Downpayment = $250
Web Service Downpayment = $350
Expected outcome
Do not activate quote, return error
Actual outcome
Activated Quote, Returned Credit File PDF warning
Versions
App: <IP_ADDRESS>5-stable

Chrome: 58.0.3029.110
Platform: Windows (7)
Steps to reproduce

I'm sorry but I don't understand. Can you explain?

Closing because of lack of activity


Does this support animation?

Hi @tj1122 👋 Started working on this, I guess it can be available soon

Now yes :) Demo
npm i react-native-eva-icons@latest


tutorial: instantsearch.js + Bootstrap markup

actually this cannot fit as a tutorial, it needs to be easier to do so (boostrap renderers)


Modifier -> SwiftUI -> Drag and drop: draggable(_:preview:)

Doc: https://developer.apple.com/documentation/swiftui/view/draggable(_:preview:)

[ ] Swift implementation
[ ] Elixir implementation

all draggable modifiers are in #230 . rejecting


Please fix SetAdParameters.java to use IDs instead of resource names...

https://github.com/googleads/google-ads-java/blob/master/google-ads-examples/src/main/java/com/google/ads/googleads/examples/campaignmanagement/SetAdParameters.java uses a resourcename as parameter. Google Ads typically focus on IDs instead, so please modify the code example to use (customerId, adGroupId, criterionId) instead.

This example uses IDs, not resource names, as params.


Fix/a11y misc

Summary | Résumé
The changes include some minor accessibility fixes:

Fixes Verify "pages" not updating the HEAD title
Fixes Verify "pages" not focussing the page header on load
Fixes lost focus when going from Verify to ReVerify
Fixes Form Builder Share dropdown sub menu to be activate-able by keyboard when a form has no title

Test the Verify page changes:

start VoiceOver (or similar)
navigating to the Sign In page, Sign In
when the Verify "page" loads, the header should be focussed and announced, the page title updated as well
click the "Send a new code" link
when the Re-Send code "page" loads, the header should be focussed and announced, the page title updated as well
click the "re-send code" button
when the Verify "page" loads, the header should be focussed and announced, the page title updated as well

Test the Share dropdown sub menu:

navigate to Form-builder, Design a form
using the keyboard tab to the Share menu in the header and key enter
the sub menu should open, key enter again
the Form title field should be focussed
(bonus: do the above running VoiceOver and when the sub menu is focussed the "Activate to move.." text should be announced alongside the visible text)

PR looks good -- just need to fix-up the hover state.

PR looks good -- just need to fix-up the hover state.

Good find. I updated the hover state of the "link" to match the rest of the text and not look so out of place

@thiessenp-cds
Wondering if the useFocusIt
Should return a callback instead of the useEffect
If we return a callback whatever component is using it could manage the dependancy array higher up --- which gets us back proper linting to avoid messing up the dependancy array.  Thoughts?
const setFocus = useCallback(() => {

    const el = elRef.current;
    if (el) {
      // Add a tabindex if one doesn't exist on the element. This is needed to focus an element,
      // unless it is a form control like an input or button
      if (addTabindIndex && !el.getAttribute("tabIndex")) {
        el.setAttribute("tabIndex", "-1");
      }

      // Give the DOM a little time to update
      setTimeout(() => {
        el?.focus();
      }, 40);
    }
  }, [elRef, addTabindIndex]);

  return setFocus;

@thiessenp-cds
Wondering if the useFocusIt
Should return a callback instead of the useEffect
If we return a callback whatever component is using it could manage the dependancy array higher up --- which gets us back proper linting to avoid messing up the dependancy array. Thoughts?
const setFocus = useCallback(() => {

    const el = elRef.current;
    if (el) {
      // Add a tabindex if one doesn't exist on the element. This is needed to focus an element,
      // unless it is a form control like an input or button
      if (addTabindIndex && !el.getAttribute("tabIndex")) {
        el.setAttribute("tabIndex", "-1");
      }

      // Give the DOM a little time to update
      setTimeout(() => {
        el?.focus();
      }, 40);
    }
  }, [elRef, addTabindIndex]);

  return setFocus;

I originally stayed away from useCallback because I didn't think it would "respect" the React lifecycle of when the component was fully mounted.  From testing it looks like useCallback does and also removes the need for dependencies, it simply calls the function when the component is mounted. Exactly what I was trying to do with useEffect. This way also removes the need to assign a ref to a var and then pass it to the hook. A little cleaner :)

Sorry Pete I mis-read the original code I thought useFocusIt was happening via a user interaction.
How about making a new component like this.
export const FocusHeading = ({ as, className, children }) => {

      const inputReference = useRef(null);

       useEffect(() => {
        inputReference.current.focus();
        }, []);

	const As = as || 'h2';
	return <As className={className}>{children}</As>;
};

your text

Sorry Pete I mis-read the original code I thought useFocusIt was happening via a user interaction.
How about making a new component something like:
export const FocusHeading = ({ as, className, children }) => {

      const inputReference = useRef(null);

       useEffect(() => {
        inputReference.current.focus();
        }, []);

	const As = as || 'h2';
	return <As ref={inputReference} className={className}>{children}</As>;
};

<FocusHeading as="h2">your text</FocusHeading>

Decided to go back to the useEffect way. I really like the idea of this util being a component. But I couldn't get this to work because of the lifecycle - component created outside/after/before :) the useEffect or maybe the useEffect applies to the container..


Javascript output not displaying

Hi,
Is it expected not to get d3.js scripts embedded in my html display in the custom visual on PowerBI?
More precisely, I have an html file with a javascript which dynamically produces a scatter plot. I would like to visualize it on PowerBI. This works fine on any browser but I cannot make it work on PowerBI for some reason. The pure html part is correctly displayed on PowerBI but the interactive visual produced with d3.js does not work.
Any insight here?

Hi there - including a <script> tag that references an external JS file is not permitted by Power BI, unfortunately.
Please find a list of currently known limitations documented over at html-content.com.
If you want to try and work with D3, without specifically coding a custom visual then perhaps you can try the D3.js visual, also on AppSource.

Hi there - including a <script> tag that references an external JS file is not permitted by Power BI, unfortunately.
Please find a list of currently known limitations documented over at html-content.com.
If you want to try and work with D3, without specifically coding a custom visual then perhaps you can try the D3.js visual, also on AppSource.


gRPC https service requires declare service port as "https"

Bug description
gRPC server serving traffic in https, client verifies it using shared trusted CA. This setup with Istio requires declaring service port as "https-xxx" rather than "grpc", otherwise it does not work.
The reason is because, I believe

HTTPS we setup tcp proxy to pass through bytes.
'gRPC' is treated as http and using HCM. Envoy trying to proxy the TCP connection and does not work.

Solution

Don't do anything. Add documentation to istio.io, (it's not obvious from istio.io and seems requiring more Istio specific knowledge to figure this out)
This is a random idea. We can add a tls inspector in oubound client listener and dispatch request to tcp proxy filter chain if it's already tls.
Not sure how this works with under new better networking / http, tcp inspector. Would this problem no longer exists? @silentdai to confirm.

Affected product area (please put an X in all that apply)
[ ] Configuration Infrastructure
[ X] Docs
[ ] Installation
[ X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[X ] User Experience
[ ] Developer Infrastructure
Expected behavior
Steps to reproduce the bug
Version (include the output of istioctl version --remote and kubectl version)
How was Istio installed?
Environment where bug was observed (cloud vendor, OS, etc)
Additionally, please consider attaching a cluster state archive by attaching
the dump file to this issue.

I don't understand the end-2-end flow a grpc protocol. The bottom line is inbound listener, outbound cluster should act consistently in terms of alpn and auth filters.
Need to explore how istio can add value if user specify protocol name "grpc"

Related: https://github.com/istio/istio/issues/14909 which was closed, perhaps prematurely.

To throw in some question:

Is this being worked on?
Why does the istio grpc protocol even exist if it's not working or how should we use this type of protocol?

Re-opening because the policy bot closed it after I triaged it.  My triage should be considered activity from an Istio team member.

/reopen

same for http2


Size Mismatch Error using GPT large

Hi, I am trying to use BioGPT large to finetune my dataset and I have replaced the --arch transformer_lm_prompt_biogpt_large in the train.sh file.  But I am still getting the mismatch error. I believe this is due to the wring size of vocab but I don't know where to change it as I was not able to find the right file for it.

The problem is with the file, check it

The problem is with the file, check it

The problem is with the file, check it

Yeah, I checked my preprocessing bash file and I did not include large bpecodes and dict.txt for preprocessing data. I made the changes. though that error is resolved I am getting somewhat of a similar error. Do I need to make more changes to use a large BioGPT?

Please find the attached preprocess and train bash file and can you please tell me if I am doing something wrong or need to modify anything else??
Archive 3.zip

It says cannot load the model parameters from the checkpoint. Isn't my model downloaded successfully?


Screen shots disabled by app policy

Find everything else in #774

This is being discussed in #9

This is not a bug.

I think the purpose of this issue is, to allow sharing exceptions/errors with the developers/github. Maybe a better alternative would be to allow to directly create an issue on github with attached details, or to at least allow copying a stack trace in the shown error screen in #774.

Yes, @Morl99 is right: please enable a good opportunity to create issues directly from the app if it fails. I do not know much about Android development but probably something like a general exception handler is possible? If it could start a dialogue with the user to create an issue and include the stack trace this could probably help.

This issue is already discussed in #516
As further noted here, the dev team is currently discussing the way forward with the screenshot protection. Updates on that matter will be provided in #516.


Tetsuya Yamamoto: Watch esearchadvisors.com

Tetsuya Yamamoto requests the watch of the watch_keyword esearchadvisors.com. See the Metasmoke search here and the Stack Exchange search here.

Coverage remained the same at 63.155% when pulling 3b1e416e5ab021bc5f64e0781645a4dd2c2ac90f on auto-blacklist-1512452409.3216383 into 6d459557e1d53a65deb3a407a57466d706393b61 on master.

!!/approve


feat: add peer scoring

WIP. Still needs testing.

It doesn't seem to be helping, according to metrics. I'll drop this one for now.


Is there a way to show and hide status bar with custom or default layout?

Hi. I've tried a few way but it haven't successfully. I wanna display/hide status bar with custom or default overlay with the same animation as layout. How can I achieve it?

I faced similar issue. What I did was create a subclass of INSPhotosViewController then create a field say shouldHideStatusBar as Bool and override prefersStatusBarHidden and return shouldHideStatusBar.
Then in your customer overlay view, in setHidden(_ hidden: Bool, animated: Bool) listen to hidden and set shouldHideStatusBar accordingly. Finally call setNeedsStatusBarAppearanceUpdate() in your subclass.


feat(lang): Added Indonesian Language

Thank you for contributing!
Please add test code.
See https://github.com/codeigniter4/shield/pull/235#issuecomment-1153050805

Thank you for contributing!
Please add test code. See #235 (comment)

Already added

Awaiting tests...


Add missing powermock dependencies

CLosing this PR since this change was already merged as part of another PR #1821


fix delete crash on tail/passthrough

fixes #623
To merge after #625

Coverage remained the same at ?% when pulling dbd190fb05790f86a14cfabf16d90c7f023fc384 on fix_tail_del into 4d0c369b530f7b5bbea68454ffdaf4238b939a93 on master.