PropType is defined but prop is never used - when prop is used via a decorator.

Hi. I'm using Flow, ESLint (with this plugin), Redux & React Pure Lifecycle (to connect lifecycle methods to functional components).
Here's an example of the code
type Props = {|
  +propA: boolean
  +propB: () => Dispatch, // [eslint] 'propB' PropType is defined but prop is never used (react/no-unused-prop-types)
|}

const ComponentA = ({ propA }: Props) => (
  <ComponentB myProp={propA}>
      {...}
  </ComponentB>
)

const methods = {
  componentDidMount({ propB }: Props) {
    startSocket()
  },
}

const decoratedSplash = lifecycle(methods)(ComponentA)

So propB is being used via the lifecycle decorator, but the plugin isn't picking up its usage.
I understand this is a fringe case, but I was hoping someone had a workaround that would pacify the error without simply ignoring it.
Thanks in advance.

In that case, the type is incorrect. propB doesn’t belong in the types for the inner piece - the decorator should be adding the propType itself.


0.17.0 regression: Make native env rendering explicit/opt-in

Describe the bug
See the discussion in https://github.com/fishtown-analytics/dbt/pull/2608 for more information.
dbt v0.17.0 adds a native env renderer for Jinja. This has the great benefit of coercing stringy values like "True" or "False" to boolean values like True and False. It's a subtle distinction, and the benefit is that you can use dbt's jinja context to do really clever things in configuration files, eg:
models:
  my_package:
    optional:
       enabled: "{{ env_var('DBT_OPTIONAL_MODELS_ENABLED") }}

In this example, the env_var function returns a string, but with the native environment, dbt coerces the string to a boolean value. This is necessary because the enabled config requires a boolean value as a configuration.
The drawbacks of this approach are equally subtle, but there are many:

numeric strings can be errantly converted into integers, losing information (eg. "00" --> 0)
confusingly, this behavior is inconsistent with the current implementation for obscure reasons ("01" --> "01")*
values like the empty string ('') are evaluated to None without special handling
quotes in quoted strings are stripped as a part of literal evaluation (eg. "'abc'" --> "abc")
the literal evaluation lib that dbt uses will coerce "container" types (eg. "[1,2,3]" --> [1,2,3] as a list instead of a string)

01 is not a valid Python literal, so a literal evaluation of the string raises a SyntaxError and dbt returns the source string instead

So, this feature is powerful and compelling (which is why we added it in the first place!) but it frequently results in unexpected behavior if you don't know the gritty details about how dbt's native env rendering works under the hood. That's the exact opposite of our design goals as we march towards a 1.0 release of dbt, so we unfortunately need to take some action to revert the native env changes introduced in 0.17.0 and gate them behind a syntax which makes their use explicit.
This is going to be a breaking change to a breaking change, so we'll need to take care to communicate out why we're changing this and how users will need to adjust their code.
Example code that should work once this issue is addressed:
models:
  my_package:
    optional:
       enabled: "{{ env_var('DBT_OPTIONAL_MODELS_ENABLED") | as_bool }}

The path forwards:
Add a NativeMarker as described in this comment (https://github.com/fishtown-analytics/dbt/pull/2608#issuecomment-654438650) which can be accessed using an as_native. Default to not calling literal_eval on strings unless the as_native marker is provided.
The as_native filter is good and useful in many cases, but we should also add some sugary filters that are more explicit. as_native isn't super descriptive, and we should take care to make sure that this behavior is well defined and well documented. I propose:

<expression> | as_text: same behavior as 0.17.0 (and more or less a no-op in dbt > 0.17.0)
<expression> | as_bool: coerce the string to a boolean value. Fail if the input cannot be represented as a bool
<expression> | as_number: coerce the string to a number value. Fail if the input cannot be represented as a number (or, do we want as_int / as_float here instead?)
<expression> | as_native: coerce the string into its native representation according to ast.literal_eval. That could be a set/list/tuple/dict/etc, and it's on the user to make sure that their values inside the container are evaluated correctly. From my understanding, there isn't really a good way to make sure dbt does the right thing there 100% of the time, which is kind of the crux of this issue!

This might require the addition of some additional Marker classes, but I think there will be a ton of benefit to coupling type inference and validation in the same jinja filter.
Next steps

Drew to write something up since functionality churn like this is a little unusual and is blocking our dbt patch/bugfix release
We need to determine the version number for the release that includes this change. 0.17.1 and we add warning labels to 0.17.0? Or 0.18.0 and we acknowledge the breaking change as such? TBD
Drew to write up lots of docs and some sort of discourse post outlining the whats and the whys

Resolved by #2618!


Update to core version 0.88.0

(y)

:+1:

Shouldn't we also add "Add support for comparing string columns to other string columns in queries." to our changelog? That was included in core 0.88.0.

No, I still need to expose it in the binding.

Right, thanks.

Looks like https://github.com/realm/realm-core/pull/639 was never reflected in core's release notes, but it was included in 0.87.5. We should add something like "Fixed issue where querying for non-null relationships would return incomplete results.".


The method for providing platform translations has changed in Home Assistant Core

The method for providing platform translations has changed in Home Assistant Core, and this integration needs to be updated.
Details can be found in https://developers.home-assistant.io/blog/2024/03/05/platform_entity_translations_deprecation

Thanks for the info. I will look into it


CM-116 endpoints agregar/quitar vacas al lote, CRUD lote

Refer to this link for build results (access rights to CI server needed):
http://utils.brazilsouth.cloudapp.azure.com:8080/job/ci/job/continuous-integration-bovine/37/

Refer to this link for build results (access rights to CI server needed):
http://utils.brazilsouth.cloudapp.azure.com:8080/job/ci/job/continuous-integration-bovine/38/

Refer to this link for build results (access rights to CI server needed):
http://utils.brazilsouth.cloudapp.azure.com:8080/job/ci/job/continuous-integration-bovine/39/

Refer to this link for build results (access rights to CI server needed):
http://utils.brazilsouth.cloudapp.azure.com:8080/job/ci/job/continuous-integration-bovine/40/

Refer to this link for build results (access rights to CI server needed):
http://utils.brazilsouth.cloudapp.azure.com:8080/job/ci/job/continuous-integration-bovine/41/


Fix issue with scrolling method callback

Fixes an issue with the scrollToComponentOfType:... method, where the callback would sometimes be called before the scrolling occured in cases where the component was already visible.
@spotify/objc-dev

Current coverage is 93.04% (diff: 66.66%)

Merging #183 into master will increase coverage by 0.01%

@@             master       #183   diff @@
==========================================
  Files            63         63
  Lines          4547       4542     -5
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           4230       4226     -4
+ Misses          317        316     -1
  Partials          0          0

Powered by Codecov. Last update 5bc7928...36c0dee

@krris fixed 😄


Blend shape glitch after programmatically changing values

Godot version
3.3.stable
System information
Windows 10, GLES3, RTX 2070
Issue description
Programmatically changed blend shape values on duplicated meshes glitch on camera move
func _ready():
	$LightSwitch/LightSwitch.set("blend_shapes/SwitchOff", 1)

Steps to reproduce
Create new inherited scene off an imported mesh
Drop the inherited scene as node in the main scene
Duplicate that node as many times as needed
Change one of those nodes shape keys inside GDscript on ready or something
This is hard to catch because it only glitches on specific positions/angles
Glitch video:
https://user-images.githubusercontent.com/106078/129967429-7704c99d-b0b0-4ab1-af01-68e199a1620c.mp4
Minimal reproduction project
BlendShapeBug.zip

see https://github.com/godotengine/godot-proposals/issues/2465
This will happen every time MeshInstances that share the same underlying mesh resource are in view, as blend shapes are calculated on the underlying mesh resource.


Add Vagrant definitions

Add a Vagrant file to create a CoreOS base Docker swarm cluster.

Currently we only created a simple VM using Vagrant to run Ansible.


Revisit metamodel for v2024.1 Release

[ ] check annotations
[ ] introduce structured datatypes
[ ] introduce fields
[ ] double check if LionCore and LionCore Builtins should be version-dependant or not
[ ] remove BuiltIns.JSON

@enikao do you think I am forgetting anything?

[ ]  remove BuiltIns.JSON

Added, thank you

Annotations seems to respect the specifications as defined here


current build is failing?

Hey Austin! Thanks for sharing this. I'm just playing around, as I'm very new to backend development. What's wrong with the current build and what should I be looking into to fix it? Thanks!

Hey! Sorry, I just saw this...not used to getting issues. What do you mean when you say "What's wrong with the current build"? When I go to jobsort.tech, it seems like it is working fine.


How to calculate the transaction fee.

I am building dApp running on Juno Chain using @cosmjs/cosmwasm-stargate.
I want to send the whole JUNO tokens from my wallet to the other.
But when I inputted the amount as the balance of my wallet, I got the error "insufficient funds".
I think it is related to the transaction fee.
So I would like to get the amount, calculated by subtracting the transaction fee from the balance.
Any comment will be helpful for me.

Bank send transactions have a relatively stable gas usage. I get simulation results of like 71507. So it you use a gas limit of 100_000 you should be safe. Now take a gas price as configued in Keplr, let's say 0.0025 µJUNO/gas. Then you do
import { calculateFee } from "@cosmjs/stargate";

const fee = calculateFee(100_000, "0.0025ujuno");
console.log(fee) // { amount: [ { amount: '250', denom: 'ujuno' } ], gas: '100000' }

If you now subtract this fee.amount from the balance and use this fee, your account should be cleared.


Update 05-jupyter-ecosystem.md

Data with several attributes per row would not be considered "two-dimensional" (much less "two-dimenstional") in machine learning. Tabular seems a better word.

Thanks for the contribution @PeterDrake :smile:


Partition index in map_twix.py

Hi
Regarding this line:
https://github.com/pehses/twixtools/blob/3cb702203e7a276df9ffe859502beb8e017795b4/twixtools/map_twix.py#L585
I noticed that in commit 6b83f6b56c5a1cc78a77cfca7773a4a5c8012ae4, the partition index was modified from -5 to -6. However, in the subsequent commit d83eb94b14919dc2d2be570bf6424311a4a2ce65 related to the implementation of PMU, it was changed back to -5.
Is this due to an inconsistency in the index between baselines? If so, we need to address this and check for the baseline, as my reconstruction routine breaks with the current state of twixtools.
Best,
Ali

Hi Ali,
I looked into it, and it looks to me that -6 was actually correct. The '-5' would more or less deactivate this check which may have helped with the issue you encountered. However, I think that the root cause lies somewhere else.
It seems that the function list_indices() did not properly handle ranges - it's also possible that there was a change of behaviour from past python versions. Can you try the last commit from the fix_range_issue branch and see if you still encounter this issue?
Btw, baselines shouldn't matter here. The shape of the data object is defined in map_twix. I originally choose this "inverted" order (compared to matlab) by accounting for the memory order (row-major as in C, not column-major as in Fortran/matlab). This has a few performance implications, e.g. ffts for oversampling reduction are faster when applied to the last (Col) dimension. However, in the end these performance issues can also be solved differently, so it's a bit of a relict. I was already thinking about making the array order more flexible and maybe even definable by the user (all the empty dims are sometimes a bit annoying, too), but I did not find time to do so.
Best,
Philipp

Hi Philipp,
Thanks for quickly looking into and patching this issue. I can confirm that the fix_range_issue branch has resolved the problem.
BTW, I am quite happy with the current indexing style. :)
Best,
Ali

Great, i will then merge the changes to the main branch.

Resolved with PR #28.

Resolved with PR https://github.com/pehses/twixtools/pull/28.


Update testdata to work with latest keycloak image

Not sure when it last worked but when I tried running tests today I ran into several issues.
This is the minimal set of changes I needed to make to get tests up and running (and passing) again on my machine.

What happens, when you run the tests using the docker-compose file?
There also is a Makefile for that

I can sure try!
Where can I find that stuff? :)

The Makefile and the docker-compose.yml both reside in the root of the project.
You could just try to run

make start-keycloak

(after some seconds wait for startup)

make test

It feels like I am missing something or am misunderstanding you.
This is what the tree of this project looks like for me:
❯ tree .
.
├── gocloaksession.go
├── go.mod
├── go.sum
├── LICENSE
├── README.md
├── session.go
├── session_test.go
└── testdata
    └── gocloak-realm.json

1 directory, 9 files

Are you referring to the files over in the gocloak project?

Oh i'm sorry, i thought this is the gocloak repository itself.
But this is a good reminder, that we should also add such a makefile here.

Merged the change, thank you!

thanks for clarification :) happy to help!
P.S.: I am building an additional NewAdminSession function for internal needs (see also my comment here ). Would you be interested in that as a contribution?


Broken image links in "README.md"

The image link for the Requests pattern  and the Backbone.Events  are both returning Not Found errors.

Thanks – I'll fix those soon

:+1:

PRs welcome :)

SVGs are here:
Archive.zip

thanks

:+1:


📖 Add logo and badges in README

Ⅰ. Describe what this PR does
add logo and badges in README.md
Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews

/lgtm
/approve


Main is broken

The last pylinalg release broke pygfx main :)
❯ .venv/Scripts/python .\examples\feature_demo\look_at.py
QWindowsWindow::setDarkBorderToWindow: Unable to set dark window border.
Traceback (most recent call last):
  File "C:\Users\kvang\dev\pygfx\examples\feature_demo\look_at.py", line 55, in <module>
    disp.show(group)
  File "c:\users\kvang\dev\pygfx\pygfx\utils\show.py", line 192, in show
    self.camera.show_object(object, up=up, scale=1.4)
  File "c:\users\kvang\dev\pygfx\pygfx\cameras\_perspective.py", line 379, in show_object
    view_dir = la.quaternion_rotate((0, 0, -1), rotation)
AttributeError: module 'pylinalg' has no attribute 'quaternion_rotate'

See https://github.com/pygfx/pylinalg/pull/53
Replacing every call to la.quaternion_rotate with la.vector_apply_quaternion fixes the problem.

Yes, This goes back to the vector_apply_quaternion PR where we decided to nuke quaternion_rotate in favor of vector_apply_quaternion 😅

Fixed in #488


Add line breaks in notes

Is it possible to add line breaks in notes? I tried two options:
notes "Line 1\nLine 2"
notes "Line 1<br />Line 2"

But none of them worked.

Your first method is working fine for me:
notes "Line 1 \n Line 2"

have you checked if the notes are successfully generated in the json doc?

Yes, the json is generated like this:
"notes": "Line 1 \n Line 2",

But at Swagger UI, the line breaks aren't displayed.

I'm unable to reproduce it. Tried both your methods and both are working..
Can you provide more details on how it's setup?

Could share which version of Swagger UI you tested?
I'm using 2.2.6 and noticed that line breaks aren't enabled. So I had to add this:
marked.setOptions({breaks: true});

before loading Swagger UI.
After all this issue isn't related to this gem, so I will close the issue.


Case insensitive matches

Hello!
Firstly, thank you for working on this!  It's coming in very handy.
I have a question of sorts.
I know that per RFC rules, querystrings are case sensitive.
However, in specific use cases, it would be useful to configure the enhancer params matching to be case insensitive.
In my particular case, I'm in the process of migrating from pascal case to lower case and wanted the params to match both cases.
If you're open to the idea, I would be happy to submit a PR.

I would probably just specify stringToValue: s => s.toLowerCase() for every parameter; would that solve the problem? Or is the problem that you consider it too cumbersome to repeat that line for every parameter?

Oh wait, I am talking about values; you are talking about parameter names; sorry. :)
In that case, perhaps that would be a valid request indeed.

Yeah 😄
I meant case insensitive query string keys. So that param p matched both P and p in the url.
Cool! As soon as I an hour or so I'll submit a PR 👍


If the onboardingContentViewController view is modified

OnboardingViewController* onboardViewController = [OnboardingViewController onboardWithBackgroundImage:nil contents:@[firstPage,secondPage,thirdPage,fourthPage,fifthPage]];
onboardViewController.view.backgroundColor = self.styleSheet.gradientColor;
// its because view did load will be called when the view is accessed by another class
// These settings will be ignored below
onboardViewController.shouldBlurBackground = YES;
onboardViewController.swipingEnabled = NO;
onboardViewController.fadePageControlOnLastPage = YES;

What version are you using?

Using Onboard (2.3.0) might I suggest moving the code into viewWillAppear ?

Moving to viewWillAppear is not really the appropriate time to do what is done in viewDidLoad. The standard pattern is to create things in init, customize them and add them in viewDidLoad, and update anything that should be updated when the view is about to be shown in viewWillAppear. Simply moving the setting of the background color to after setting those values would solve the problem and not require changes to the framework.

Yeah I would leave that as a note in the framework docs because I spent about and hour trying to see if the problem was on my end, it was pretty unexpected

Done, thanks!


🚀 Feature: Improve Kafka plugin UI for better lag visualisation for many partitions.

🔖 Feature description
The kafka plugin is great to visualise the lag across partitions and topics but very limited for a large number of partitions. The current table view does not allow an overall view. Having a view summing up the lag would be very beneficial.
Here is the page of the plugin: https://github.com/backstage/backstage/tree/master/plugins/kafka
🎤 Context
The context is when there are a lot of (100+) partitions. However, a very visual display would also be helpful for less partitions.
✌ Possible Implementation
Some kind of (bar?) chart maybe. It would allow to see at a glance the lag across the partititons
👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

Alright, ideas are likely welcome here. If you make a PR with a suggestion it'd be appreciated. 🙏


speed up ads push scoping test

Improves perf of AdsPushScoping test. Tested this 100 times in my local with out flakes. If updates come in 100ms, we can safely assume if an update does not come in 100ms, it will never come (unexpected cases).

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Flaking in https://prow.istio.io/view/gs/istio-prow/logs/unit-tests_istio_postsubmit/1498389800879656960

Ah. Let us see if this flakes more often - I will try another thing


Rstat2M raises a truncnorm error

An indexing exception is encountered when calling Rstat2M with default grid_size and sample_size. The error arises from truncnorm, and may be distribution dependent. Notably, the exception is not raised in the mirror image function Mstat2R.
The solution is to make sure grid_size and sample_size are integers, not floats. In the code you'll note that Mstat2R uses grid_size=1000, whereas in Rstat2M uses grid_size=1e3. The best solution would be to manually alter the code so that this exception is never encountered. Alternatively, the user must be sure to specify values for these keywords.
Presumably this wasn't a problem when the code was published, but it is now (at least for me).

Is it okay that you submit a PR to fix it and I can review and approve the change?

Sure! I haven't actually ever done that, but I'll figure it out. Wasn't
sure if you were still monitoring this at all, mainly left that as a
friendly note for other users.
Hope you're doing well!
Alex

Alex Teachey
NSF Graduate Research Fellow
Department of Astronomy
Columbia University
alexteachey.com
On Tue, Mar 10, 2020 at 6:07 PM chenjj2<EMAIL_ADDRESS>wrote:

Is it okay that you submit a PR to fix it and I can review and approve the
change?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/chenjj2/forecaster/issues/6?email_source=notifications&email_token=AB43Y4BPJNAUOUJDGQVS3QTRG222JA5CNFSM4LFH7R2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEONLHDI#issuecomment-597341069,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB43Y4EHDR4PFYEP4G6U6ULRG222JANCNFSM4LFH7R2A
.

I still got email notices but I am not actively monitoring this repo. But if its blocking your research and you can submit a fix that is well tested, I have no reason not to merge it for you. I am doing very well and hope you are doing well as well! Take care!


Import only scss/sass files

I'm trying to make modules and store all module's related stuff in the same directory (styles, images, js).
* imports all of them, so we need to check file extension before import.

I just ran into this also. You can add the extension to the @import string:
@import "foo/**/*.scss"

@mwmitchell Thanks.

@mwmitchell I tried you solution. Unfortunately this import mask completely skip directories parsing and negate my previous PL which allows to ignore directories with underscore at the beginning ("partial" directory I want to ignore).
We can use more complex regex, but I think in this case @import directive will be too complicated.


Add custom labels to k8s interpreter

What type of PR is it?
to run interpreter on eks fargate, add custom labels to k8s interpreter
here is eks with fargate doc
How should this be tested?
add zeppelin.k8s.interpreter.customLabels to zeppelin-site.xml and deploy on eks
Screenshots (if appropriate)
custom label k1:v1 is attached

What prevents you from including your own labels in your Jinja template?

In order to deploy with different settings to n k8s clusters, different zeppelin-site.xml files are mounted and used for each cluster.
If Jinja template also needs to be created for each cluster, it seems better to manage it at once in zeppelin-site.xml because the number of management points increases.

I am against the MR, because today it is about labels, tomorrow in annotations and the day after tomorrow about additional initContainers. Please adjust your Jinja2 template. This can be mounted wonderfully into the pod using ConfigMap.

Templating is very powerfull, you can use jinja conditionnal tags to have some labels for a particular interpreter etc...

I am against the MR, because today it is about labels, tomorrow in annotations and the day after tomorrow about additional initContainers. Please adjust your Jinja2 template. This can be mounted wonderfully into the pod using ConfigMap.

@Reamer
I think your opinion is more correct.
It would be better to mount the Jinja2 template.
@ebuildy
Unless adding all the k8s options to the Jinja2 template, it would be better to leave it alone.
i'm gonna close this pr.


Fix diagnose

Debug issue: https://github.com/submariner-io/shipyard/issues/607

2021-07-22T14:08:57.9131887Z [submariner-operator]$ [cluster2] timeout 6m bash -c deploy_weave_cni
2021-07-22T14:08:57.9132641Z [cluster2] Applying weave network...
2021-07-22T14:08:57.9134150Z [cluster2] error: unable to read URL "https://cloud.weave.works/k8s/net?k8s-version=v&env.IPALLOC_RANGE=", server reported 400 Bad Request, status code=400

Seems like some variables aren't getting set here?

Seems like some variables aren't getting set here?

yeah I just made some changes in my shipyard image
forgot to export the variables

It seems like it's not hanging at the docker inspect line here:
2021-07-22T14:30:35.8945499Z [submariner-operator]$ [cluster1] kind_fixup_config
2021-07-22T14:30:35.8946280Z [submariner-operator]$ [cluster1] kind_fixup_config
2021-07-22T14:30:35.8947609Z [submariner-operator]$ [cluster1] docker inspect -f {{range .NetworkSettings.Networks}}{{.IPAddress}}{{end}} cluster1-control-plane
2021-07-22T14:30:35.8948502Z [cluster1] master_ip=<IP_ADDRESS>

Are the other commits here intentional? If not, it would be interesting to update the branches such that your debug commit is the only one in the PR.

I used the same PR that was pushed by @sridhargaddam yesterday gh pr checkout 1507.
I can try to start from scratch.
The problem is starts here
kubectl apply -f https://cloud.weave.works/k8s/net?k8s-version=v1.20.2&env.IPALLOC_RANGE=<IP_ADDRESS>/16

specifically during the deployment of the weave-net daemonset

@dfarrell07 I update the kind version to support k8s 1.20

Done testing


[BUG] error retrieveing history svc attempts in home page

looks to be fixed

This is due to nginx rate limiting due to unnecessary requests to User Service to get the name of the collaborator

Fixed in https://github.com/CS3219-AY2425S1/cs3219-ay2425s1-project-g05/commit/30f31d14a161dd4a9b0e75feb7e31f2edc4a861a


Custom eloquent builders won't work with where & orWhere since 2.1.0

Larastan Version: 2.1.2
--level used: 6
Pull request with failing test: -

Related PR: https://github.com/nunomaduro/larastan/pull/1144
where: https://github.com/nunomaduro/larastan/blob/master/stubs/EloquentBuilder.stub#L222
orWhere: https://github.com/nunomaduro/larastan/blob/master/stubs/EloquentBuilder.stub#L233
Description
Hey!
Since version 2.1.0 we encountered an issue with where and orWhere when custom eloquent builder is as first parameter.
Parameter #1 $column of method Illuminate\Database\Eloquent\Builder<App\Models\User>::where() expects
  array<int|string, mixed>|(Closure(Illuminate\Database\Eloquent\Builder<App\Models\User>): void)|Illuminate\Database\Query\Expression|string,
  Closure(App\Models\Builders\UserBuilder): App\Models\Builders\UserBuilder given.

Laravel code where the issue was found
class User extends Model
{
    /**
     * @return UserBuilder<\App\Models\User>
     */
    public static function query(): UserBuilder
    {
        return parent::query();
    }

    /**
     * @param \Illuminate\Database\Query\Builder $query
     * @return UserBuilder<\App\Models\User>
     */
    public function newEloquentBuilder($query): UserBuilder
    {
        return new UserBuilder($query);
    }
}

/**
 * @template TModelClass of \App\Models\User
 * @extends Builder<TModelClass>
 */
class UserBuilder extends Builder
{
	//
}

class TestController
{
    public function __invoke()
    {
        User::query()
            ->where(fn (UserBuilder $query) => $query
                ->where('email'<EMAIL_ADDRESS>                ->orWhere('username', 'some-test')
            )
            ->get();
    }
}

Hi,
Can you test if it works when you change the static<TModelClass> to just static here?

@canvural Hey,
slightly different error:
Parameter #1 $column of method Illuminate\Database\Eloquent\Builder<App\Models\User>::where() expects array<int|string,
mixed>|(Closure(App\Models\Builders\UserBuilder<App\Models\User>): void)|Illuminate\Database\Query\Expression|string,
Closure(App\Models\Builders\UserBuilder): App\Models\Builders\UserBuilder given.

Can confirm. I'm also getting lots of errors due to custom query builders even though the annotations are set correctly.

@fragkp and @mabdullahsari, can you test dev-master and check if it's fixed for you? Thanks.

@canvural
I identified 3 errors:

$this->hasOne(CompanyGoal::class)->where(fn (CompanyGoalBuilder $query) ...);

PHPStan Error:
Parameter #1 $column of method Illuminate\Database\Eloquent\Relations\HasOne<App\Models\CompanyGoal>::where() expects array<int|string, mixed>|(Closure(Illuminate\Database\Eloquent\Relations\HasOne<App\Models\CompanyGoal>): void)|(Closure(Illuminate\Database\Eloquent\Relations\HasOne<App\Models\CompanyGoal>): Illuminate\Database\Eloquent\Relations\HasOne<App\Models\CompanyGoal>)|Illuminate\Database\Query\Expression|string, Closure(App\Models\Builders\CompanyGoalBuilder): App\Models\Builders\CompanyGoalBuilder given.

$this->where(fn (CompanyGoalBuilder $query) => $query->whereNotNull('column'));

whereDate and other where* methods also not recognized.
PHPStan Error:
Parameter #1 $column of method Illuminate\Database\Eloquent\Builder<TModelClass of App\Models\CompanyGoal>::where() expects array<int|string, mixed>|(Closure(App\Models\Builders\CompanyGoalBuilder<TModelClass of App\Models\CompanyGoal>): void)|(Closure(App\Models\Builders\CompanyGoalBuilder<TModelClass of App\Models\CompanyGoal>): App\Models\Builders\CompanyGoalBuilder<TModelClass of App\Models\CompanyGoal>)|Illuminate\Database\Query\Expression|string, Closure(App\Models\Builders\CompanyGoalBuilder): App\Models\Builders\CompanyGoalBuilder<App\Models\CompanyGoal> given.

User::query()->first()->load([
	'employee' => fn (HasOne $query) => $query
		->where(fn (EmployeeBuilder $query) => $query
			->where('email'<EMAIL_ADDRESS>		)
]);

PHPStan Error:
Parameter #1 $column of method Illuminate\Database\Eloquent\Relations\HasOne<Illuminate\Database\Eloquent\Model>::where() expects array<int|string, mixed>|(Closure(Illuminate\Database\Eloquent\Relations\HasOne): void)|(Closure(Illuminate\Database\Eloquent\Relations\HasOne): Illuminate\Database\Eloquent\Relations\HasOne)|Illuminate\Database\Query\Expression|string, Closure(App\Models\Builders\EmployeeBuilder): App\Models\Builders\EmployeeBuilder given.

Hi @fragkp
All your errors are valid, but currently not possible to fix because PHPStan does not support a way to do it.
#1144 and #1178 fixed issues about this code:
User::query()->where(function (Builder $query) {
    // Now PHPStan knows here the `$query` is `Builder<User>`
});

but broke your example hasOne(CompanyGoal::class)->where(fn (CompanyGoalBuilder $query) ...);
Since custom builders are less common than normal usage, I decided to keep these changes. And until PHPStan provides a way to fix this for us (issue here if you want to follow), your only choices are to ignore these errors or not to typehint the builder. Hope you understand.


Support different Camel catalog versions

Please describe the feature that you want to propose
Currently, Kaoto uses a predefined upstream Camel catalog version. The goal for this issue is to support different Camel catalog versions.
Here's a rough plan for doing so:

[ ] Update the Kaoto catalog index.json file https://github.com/KaotoIO/kaoto/pull/1111 (https://github.com/KaotoIO/kaoto/issues/5)
[ ] Divide the current maven catalog plugin into different submodules

we should move away from using kaoto-next.

where did you see it? I saw the title of the previous GH issue and renamed it.


parser: use drop guards to track nesting level

Not for all operations the nesting level was incremented when needed and/or the un-incremented nesting level was used in subfunction calls. Binary operators such as * did not properly increment the nesting level.
This PR changes Level in such a way that it can be used to keep track of the nesting level when used in a loop. It is now impossible to accidentally refer to an old nesting level value.
Resolves https://issues.oss-fuzz.com/issues/385256115.
Resolves https://github.com/rinja-rs/rinja/issues/30.

Thanks!


Feature Request: Add persistence through SQLite and/or Postgres support

Issue: Currently RSS feed items are remembered by storing them in RAM, issues may arise when the application crashes due to OOM or some unforeseen program exceptions or logic errors that cause it to restart, causing the end user to miss RSS Feeds on the next program startup
Suggestion: Add a persistence layer like SQLite and/or Postgres to keep track of RSS feeds instead of purely storing them in volatile memory

FeedCord was made to be a turn key application with no persistence - a set it and forget kind of ordeal.
However, as I personally use it and some users mentioned, I do intend on integrating two things:

A web UI extension to test/manage URLs
A database for persistence

So yes future plans do include this request. With work changes and relocating, I am on a pause of development for my libraries for at least another month or so unfortunately.

hello Qolors, understand the simplicity perspective, but missing feed items during a restart may be a huge deal breaker for people.
The app may restart for various reasons as noted in initial post, another cause of app restart would be when updating the settings in the appsettings.json file to add feeds or update feed url or maybe even updating the pull frequency, all this requires an app restart, and if the feed updates while the app is restarting it would cause people to miss feed items during that period.


Code formatting (#29)

Solves #29

Codecov Report

Merging #30 (e6562d0) into master (85d145f) will decrease coverage by 0.03%.
The diff coverage is 55.13%.

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   53.20%   53.16%   -0.04%
==========================================
  Files          39       39
  Lines        1453     1454       +1
==========================================
  Hits          773      773
- Misses        680      681       +1

Impacted Files
Coverage Δ

src/pyskindose/__init__.py
100.00% <ø> (ø)

...ndose/plotting/create_layout_for_dose_map_plots.py
71.42% <ø> (ø)

...yskindose/plotting/create_plot_and_save_to_file.py
55.55% <ø> (ø)

...rc/pyskindose/plotting/create_ploty_ijk_indices.py
2.43% <ø> (ø)

src/pyskindose/plotting/get_camera_view.py
66.66% <0.00%> (ø)

src/pyskindose/plotting/get_visual_offset.py
50.00% <ø> (ø)

src/pyskindose/plotting/plot_settings.py
28.57% <0.00%> (ø)

src/pyskindose/rdsr_parser.py
8.06% <0.00%> (ø)

src/pyskindose/settings_normalization.py
20.45% <0.00%> (ø)

tests/manual_tests/base_dev_settings.py
100.00% <ø> (ø)

... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85d145f...e6562d0. Read the comment docs.


Limit max value of light sensor

Problem: Max value of illuminance in Lux is 3.576 Mlx. But SmartThings limits its range to 100,000. MaxMeasuredValue attribute is not effect in this case.
Measure: Change the value to 100,000.

How about changing below logic, too ?
lightsensor.py
def set_state(self):
        if Utils.toIlluminance(self.measured_value) >= 50000:
            self.labelStatePicture.setPixmap(Utils.get_icon_img(
                Utils.get_icon_path('lightsensor_high.png'), 70, 70))
        elif 10000 <= Utils.toIlluminance(self.measured_value) < 50000:
            self.labelStatePicture.setPixmap(Utils.get_icon_img(
                Utils.get_icon_path('lightsensor_medium.png'), 70, 70))
        else:
            self.labelStatePicture.setPixmap(Utils.get_icon_img(
                Utils.get_icon_path('lightsensor_low.png'), 70, 70))

According to https://en.wikipedia.org/wiki/Lux, 320–500 is typical office lighting
I agree that current condition is quite coarse tuning. Do you have any idea?

According to https://en.wikipedia.org/wiki/Lux, 320–500 is typical office lighting I agree that current condition is quite coarse tuning. Do you have any idea?

No, but, your new commit looks good to me. :)


Add captions in send_audio, voice and file

Sorry for reopening the third time. Now it's one squashed commit.

Thanks!


Drop dummy gsx nodes from both domu.cfg and dom0.dts

There is no need to keep dummy gsx nodes as we already have
required support in the IPMMU driver for handling master devices
that are tied to multiple cache IPMMUs.
This request is related to
https://github.com/xen-troops/xen/pull/72

Not needed anymore. Use https://github.com/xen-troops/meta-xt-prod-devel/pull/8 instead.

Not needed anymore. Use xen-troops/meta-xt-prod-devel#8 instead.


Widen pillow dependency requirement

This fixes an issue where colab complains that the kernel has to be restarted after pip-installing Pixeltable.

This change is


ENH: add normalize keyword to equals_exact() to normalize input geometries (Rebased #1231)

This PR is rebase of the work of @tfardet https://github.com/shapely/shapely/pull/1231
@tfardet - I don't want to take credit for your work, please feel free to pull this into your PR if you wish to do so.
I've rebased on main, solved the conflicts and removed the duplicated documentation (full doc in predicates.equals_exact, only title in base.equals_exact) and made some other cosmetic changes.

It's good that you reminded me about this: it's been so long I completely forgot about it.
I'm not sure why you opened a new PR rather than ping the existing one, though, as I don't think this will make things any faster.
I'm also not really sure why you rewrote things the way you did, especially with respect to the manual file: wouldn't it be better to have the detailed explanation straight where someone reading the docs will most probably find it first? (I'm not even sure the predicate docstring is rendered in the docs).
So I updated my old PR because I feel it would be clearer for people that way.

Hi @tfardet,

It's good that you reminded me about this: it's been so long I completely forgot about it.
I'm not sure why you opened a new PR rather than ping the existing one

Sorry, just wanted to help with the rebase and such (I think that you would need to rebase and squash eventually)

I'm also not really sure why you rewrote things the way you did, especially with respect to the manual file: wouldn't it be better to have the detailed explanation straight where someone reading the docs will most probably find it first?

I think it's better not to duplicate the documentation 3 times (top level function in predicates.py, object copy in base.py and manual.rst, that's pretty much the same text, and updating this in the future would be a hassale) .

(I'm not even sure the predicate docstring is rendered in the docs)

As with all the new top-level functions, their docs are auto generated from the docstrings, please see for example:
https://shapely.readthedocs.io/en/stable/reference/shapely.equals_exact.html#shapely.equals_exact
I opened an issue to consolidate the documentation for other functions as well, so I don't think we need to further duplicate the docs: https://github.com/shapely/shapely/issues/1688
Put away the documentation, is there anything else you wanted to discuss with respect to my version of your PR ?

Sorry, just wanted to help with the rebase and such (I think that you would need to rebase and squash eventually)

Thanks, since the PR hasn't even be reviewed once yet, I was not really worrying about that part yet ;)

I opened an issue to consolidate the documentation for other functions as well, so I don't think we need to further duplicate the docs: #1688

Very good! I'll go drop a line and put a :+1: there

Put away the documentation, is there anything else you wanted to discuss with respect to my version of your PR ?

Well, my changes to Shapely are rather limited so apart from adapting the code to 2.0 I don't think there is much to discuss besides documentation ^^

As with all the new top-level functions, their docs are auto generated from the docstrings, please see for example: https://shapely.readthedocs.io/en/stable/reference/shapely.equals_exact.html#shapely.equals_exact

Forgot to reply to that: this does not show up when I search the documentation (the link works, but it's not easily findable ATM).
So I'd say it's important for the detailed dosctring to be in manual.rst until #1688 is fixed.

Forgot to reply to that: this does not show up when I search the documentation (the link works, but it's not easily findable ATM). So I'd say it's important for the detailed dosctring to be in manual.rst until #1688 is fixed.

What do you mean? it's available from the predicates link on the left hand side panel in the main documentation: https://shapely.readthedocs.io/

I don't think there is much to discuss besides documentation

OK, You might want to compare the documentation of the function in predicates , I made some additions and consolidate the documentation, so you might want to copy some of this to your PR. 👍
I'm going to close this PR for now. I think that if you rebase and squash your PR it's more likely that it would get reviewed again and merged.

Ah right, I guess these are my old Shapely 1.X habits: I found the old doc hard to navigate and would always use the manual page so I missed the new API pages.

I'm going to close this PR for now. I think that if you rebase and squash your PR it's more likely that it would get reviewed again and merged.

OK, will do, we'll see...


Cannot run dockerized Drill in detached mode

Describe the bug
I am trying to run Drill in docker on my local machine in detached mode. The container keeps exiting about ~12 seconds after running the command specified in the documentation (https://drill.apache.org/docs/running-drill-on-docker/#running-the-drill-docker-container-in-detached-mode)
To Reproduce
docker run --name drill-detached \
    -p 8047:8047 \
    -p 31010:31010 \
    --detach apache/drill:1.21.0

Expected behavior
The container continues to run in the background.
Error detail, log output or screenshots
The container exits after roughly 12 seconds with the following output. Note the %.

Drill version
1.21.0
Additional context
N/A

Here's a relevant discussion from the Drill mailing list. Also consider a single-node Drill cluster (with a ZooKeeper) using the distributed mode Docker Compose scripts here.
Subject:
Re: Running drill in background in embedded mode
From:
James Turton<EMAIL_ADDRESS>Date:
2022/07/19, 07:28
To:
<EMAIL_ADDRESS>Prabhakar Bhosale<EMAIL_ADDRESS>Well if we're playing with hacks... 😄
nohup drill-embedded -f <(sleep infinity) > /dev/null
That needs a shell smart enough to do process substitution and avoids what I guess was busy wait loop in sqlline's input reader that you ran into.
Back to being boring and responsible: are you sure you want to run Drill this way? It would be a lot more natural to launch a standalone Drillbit with drillbit.sh, having started a ZooKeeper somewhere beforehand.
On 2022/07/19 05:30, Prabhakar Bhosale wrote:

Hi Luoc,
When I run the drill in embedded mode as foreground process, the %CPU does
not go beyond 1%.  for java process. Please let me know if you need any
additional information. thx
Regards
Prabhakar
On Tue, Jul 19, 2022 at 6:57 AM luoc<EMAIL_ADDRESS>wrote:

Hi,
What is the cost of the CPU if you are running in a front process?

On Jul 18, 2022, at 14:51, Prabhakar Bhosale<EMAIL_ADDRESS>wrote:
Hi Team,
I am trying to run drill in embedded mode as background process with
below
command
nohup sh drill-embedded >/dev/null 2>&1 &
My observation is that it takes too much CPU. After starting drill by
above
command the output of top command against java process shows %CPU
anything
between 150 to 175%.
So any recommended way to run drill in embedded mode in background?
thanks
REgards
Prabhakar


Remove client state

Reading 'Lightweight Django' chapter 4 'Building a REST API'
It suggest removing 'django.contrib.sessions.middleware.SessionMiddleware' as ' the server will not maintain any client state'
Sounds reasonable don't you think?
As 'django.contrib.sessions.middleware.SessionMiddleware' is removed, also middleware and apps dependant on this needs to be removed:
django.contrib.auth.middleware.AuthenticationMiddleware,
django.contrib.auth.middleware.SessionAuthenticationMiddleware, and
django.contrib.messages.middleware.MessageMiddleware

And django.contrib.admin, django.contrib.sessions, django.contrib.messages apps

Just stumbled on this cookie cutter project. It looks great.
Would there be separate settings for admin functionality? Not sure how this would be best structured for clarity.
My highlight from the same book...
"If that’s the case, you can preserve the admin and simply have two sets of settings for the project: one for the API and one for the admin. The admin settings would restore the session and messages apps along with the authentication middleware. You would also need another set of root URLs that include the admin URLs. With these configurations, some servers would serve the admin part of the site and others would serve the API. Given that in a larger application these will likely have very different scaling needs and concerns, this serves as a clean approach to achieving Django admin access."

I can add the admin (and thus session, etc) to local settings? My doubt is that local and production vary to much, so "it works on my computer" doesn't mean anything....
Maybe make a 'backoffice' settings or something, and add the admin to that?

I like the idea of a separate settings that extends the existing settings and adds admin and session-based middleware, etc. to it. The name "backoffice" is pretty good, was going to suggest "admin" but that would probably end up being a conflict. Maybe "administration"?

@agconti Do you have a preferred opinion?

I have added a "Backoffice' settings added.

@spoetnik thanks for your enthusiasm and contribution!
I'm going to close this issue based on this project's core values:

The idea behind this project is to have the slimmest possible boilerplate while maximizing developer productivity from the get-go. [This] isn't something that I think the project should support out of the box because it's a specific use case. While many will find it useful, many others won't have a need for it.
If this is something that you'd like to maintain yourself -- I encourage you to fork the project!

Removing session storage as you've outlined adds additional complexity to settings configuration. While some users, like yourself, will want to remove session storage so that there's no chance they violate RESTful guidelines. Most users will be content to just not use session storage or would like the option to violate RESTful guidelines with session storage when they think its best for their project.
You seem very passionate about this so please fork the project and customize it your own liking!


Update Region listing format for load-balancer-health-event-logs-preview.md

Changed region availability listing format

@mbender-ms
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Fixed in another PR.
https://github.com/MicrosoftDocs/azure-docs-pr/pull/276891
#Please-Close


adding footer to projects/other site pages

Signed-off-by: vsoch<EMAIL_ADDRESS>

Some more improvements added!

custom images for projects since the org one doesn't capture the correct logo (and instructions in README for adding)
cleaned up spacing of image relative to text (no overlap)
prompt in the top

yay! Let's merge and I'll ping Rob.


Machine mac-27 lost connection from external iPhone device.

Machine mac-27 lost connection from external iPhone device.

The external connection has been restored by rebooting machine mac-27.


CUDA error: Unknown error during inference

This is likely caused my an incorrect cuda version (e.g. nvidia-smi reports gpu driver 11.7, the container uses 11.3).
Hotfix:
# get inside container
docker exec -it stable-diffusion bash
# upgrade pytorch-cuda package
conda install pytorch torchvision cudatoolkit=11.6 -c pytorch -c conda-forge
# exit container
ctrl + D
# restart container
docker restart stable-diffusion

I haven't encountered this. Is it still an issue?

I encountered this on a 2070super card, I'll verify that once again but I think this is still an issue that's kind of hard to fix, unless we let the user choose their own pytorch+cuda package.

What are the full repro instructions? I get a 2080ti next week and can test this


[v4] Can navbar add justified menu

Like the Framework7's toolbar

Duplicate of #17026 or #17631.


Mongodb backend can't handle collections with alot of documents

I encountered a bug where querying all documents from collections with lots of documents.
I identified that the problem was how mongodb_filte.py handled filtering. Currently filtering
is done using multiple aggregate queries to mongodb using document ID's that matched
previous filters, this can lead to a situation where a database contains lots of documents
the hard limit of 16 megabyte queries is exceeded and mongodb cannot process the filter. My
changes make it so that instead of multiple filters and queries a single filter is generated
based on the request made and that is passed to mongodb. This way the 16 megabyte query
size limit should never be triggered, and mongodb can process the filter internally.

To reproduce this bug you would need a mongodb containing documents, which IDs size alone when combined
into a single filter would amount to larger than a 16 megabyte query. This happens due to generating the filter based
on IDs received from previous queries.


UI refactorings & enhancements

This PR:

Leverages NumericTextBox where TextBox were used, reducing code duplication

no visual change, just switch to an already existing code
ensures control on whether a decimal or negative number is accepted on NumericTextBox (all usages in SBE relying on positive integer value, this helps prevent bad value entry)

Introduces a TimeSpanControl to replace blocks of 5 TextBoxes to enter days, hours, minutes, seconds, milliseconds that were duplicated throughout the code

As per issue #373, for all messages custom properties display (on queues, subscription, listener, for active, deadletter, transfer deadletter), switch to a PropertyGrid.

this PropertyGrid, when it detects a multiline string value, provides a multiline editor
copying values is then possible, either in the property grid, or in the editor itself

As per issue #478, harmonizes "long" date time formats to have short month and 24h format

:white_check_mark: Build ServiceBusExplorer 5.1.0-ui-controls.7.build.744 completed (commit https://github.com/paolosalvatori/ServiceBusExplorer/commit/147333e985 by @Greybird)

:x: Build ServiceBusExplorer 5.1.0-ui-controls.8.build.745 failed (commit https://github.com/paolosalvatori/ServiceBusExplorer/commit/6b4e6ed298 by @Greybird)

:x: Build ServiceBusExplorer 5.1.0-ui-controls.8.build.746 failed (commit https://github.com/paolosalvatori/ServiceBusExplorer/commit/83e98d3cce by @Greybird)

:white_check_mark: Build ServiceBusExplorer 5.1.0-ui-controls.8.build.747 completed (commit https://github.com/paolosalvatori/ServiceBusExplorer/commit/dd484dff0b by @Greybird)

:white_check_mark: Build ServiceBusExplorer 5.1.0-ui-controls.9.build.752 completed (commit https://github.com/paolosalvatori/ServiceBusExplorer/commit/1f8b6c67a2 by @Greybird)

:white_check_mark: Build ServiceBusExplorer 5.1.0-ui-controls.9.build.752 completed (commit https://github.com/paolosalvatori/ServiceBusExplorer/commit/1f8b6c67a2 by @Greybird)

Just fixed it and tested that the roundtrip format (o) is actually working for the filter (will be the same for all cultures).
Also took the opportunity to fix the reopening of the filter form where the operator was incorrectly read due to a case difference.
(does not conclude the discussion on the format above however)

Just fixed it and tested that the roundtrip format (o) is actually working for the filter (will be the same for all cultures).
Also took the opportunity to fix the reopening of the filter form where the operator was incorrectly read due to a case difference.
(does not conclude the discussion on the format above however)

Impressive work, thanks @Greybird. 👍

Impressive work, thanks @Greybird. 👍

@ErikMogensen @SeanFeldman can you please approve this PR? @Greybird can you please include a screenshot of the TimeSpanControl that you used to replace the 5 TextBoxes?

@ErikMogensen @SeanFeldman can you please approve this PR? @Greybird can you please include a screenshot of the TimeSpanControl that you used to replace the 5 TextBoxes?


Tools

Hi mafaca,
thank you for UtinyRipper.
In Issue #131 you mentioned Asset Studio by Perfare. Are they other great tools on GitHub regarding Unity?

Hi. As I know there are only 2 projects on github that are alive: Perfare's AssetStudio and mine UtinyRipper.  However there are some project without source code not on github: Unity Assets Bundle Extractor, Unity Ex.
Every project has its own special features so it is useful to has all of them if you closely work with unity projects.
If you have spare money you can find on internet paid tool that combine functionality of all above's plus has pretty good unique features but I don't recommend to do it until you 100% sure you need those unique features.


[Rest Server] Update host list env variable

Update host list env variable, convert PAI_TASK_ROLE_$i_HOST_LIST to
PAI_TASK_ROLE_$name_HOST_LIST
Add PAI_TASK_ROLE_LIST

| taskRole.name                | String, required           | Name for the task role, need to be unique with other roles |

It seems your current implementation assumes "name" must not contain space. what is our assumption to the format of name? perhaps a regex to check the name when job submission. and clarify the format requirement here?

Refers to: job-tutorial/README.md:102 in cebfbb1. [](commit_id = cebfbb13f1965589c5851f2848fed6306f28c61d, deletion_comment = False)

hdfs dfs -touchz $HDFS_LAUNCHER_PREFIX/$PAI_USERNAME/$PAI_JOB_NAME/tmp/$APP_ID-$PAI_TASK_ROLE_NO-$PAI_TASK_INDEX-$PAI_CURRENT_CONTAINER_IP-$PAI_CURRENT_CONTAINER_PORT || exit 1

this has been removed, right?

Refers to: rest-server/src/templates/dockerContainerScript.mustache:59 in cebfbb1. [](commit_id = cebfbb13f1965589c5851f2848fed6306f28c61d, deletion_comment = False)

export PAI_TASK_ROLE_NO={{{ idx }}}

this has been removed. right?

Refers to: rest-server/src/templates/dockerContainerScript.mustache:51 in cebfbb1. [](commit_id = cebfbb13f1965589c5851f2848fed6306f28c61d, deletion_comment = False)

Do we need to remove PAI_TASK_ROLE_NO from code? I have already removed it in the document.

yes, please remove it from code.

In reply to: 364913937 [](ancestors = 364913937)

removed


Propogate changed pico_cmake_set_default values to the compilation

Currently, if you pass -DPICO_FLASH_SIZE_BYTES="(2 * 1024 * 1024)" to CMake, that modified flash size is only used in CMake (when generating the linker script) and doesn't propogate through to the compilation. To set it for the compilation you need to add a separate target_compile_definitions(my_exe INTERFACE PICO_FLASH_SIZE_BYTES=${PICO_FLASH_SIZE_BYTES}) to your CMakeLists.txt file.
This PR changes this behaviour, so pico_cmake_set_default values that have been overridden (eg with -DPICO_... or set(PICO_...) will propogate through to the compilation. If the default value isn't modified then the behaviour is not changed, and you can still use target_compile_definitions to set the values for compilation only.
Adds a PICO_BOARD_CMAKE_OVERRIDES common scope variable, to contain any pico_cmake_set_default CMake variables which have been overwritten. This is populated when reading the board header, and then read when compiling pico_base_headers.
Also add pico_cmake_set_default PICO_RP2350_A2_SUPPORTED = 1 to board headers to enable/disable the E10 abs-block fix, and modify check_board_header.py to support this. This allows specifying -DPICO_RP2350_A2_SUPPORTED=0 to CMake to prevent the creation of an abs_block, for example this could be used when you are not planning on dragging & dropping your UF2 into partition tables.

@will-v-pi can you be a bit more precise in the comment above "if you compile with... is only used in the CMake" doesn't make any sense (to me)... perhaps you mean "if you pass -Dxxx to CMake"

So my limited CMake knowledge means that I don't fully understand all of this, but it seems to me like there are now a couple of  settings (PICO_FLASH_SIZE_BYTES and PICO_RP2350_A2_SUPPORTED) which have to be set to the same value in both the "cmake world" (via pico_cmake_set_default) and also the "compiler world" (via #define). Is there any way we could come up with some generic mechanism, rather than needing e.g.
// pico_cmake_set_default PICO_FLASH_SIZE_BYTES = (4 * 1024 * 1024)
#ifndef PICO_FLASH_SIZE_BYTES
#define PICO_FLASH_SIZE_BYTES (4 * 1024 * 1024)
#endif

// pico_cmake_set_default PICO_RP2350_A2_SUPPORTED = 1
#ifndef PICO_RP2350_A2_SUPPORTED
#define PICO_RP2350_A2_SUPPORTED 1
#endif

in the header-file for every board that uses the RP2350? Or is this already the "best" way of handling this? (I guess my concern is how badly would "things go wrong" if the "cmake world" sees a different value to the "compiler world"?)

@will-v-pi I just cloned this branch and tried running tools/check_all_board_headers.sh locally, and it seems that you somehow missed out adding the
// pico_cmake_set_default PICO_RP2350_A2_SUPPORTED = 1

line to the hellbender_0001.h and pico2_w.h header files!
Also, here's a small tweak to the tools/check_board_header.py (feel free to include it or ignore it as you see fit) :
diff --git a/tools/check_board_header.py b/tools/check_board_header.py
index 3849e14..c259c81 100755
--- a/tools/check_board_header.py
+++ b/tools/check_board_header.py
@@ -29,6 +29,11 @@ chip_interfaces = {
     'RP2350B': "src/rp2350/rp2350b_interface_pins.json",
 }

+compulsory_cmake_settings = set(['PICO_PLATFORM'])
+compulsory_cmake_default_settings = set(['PICO_FLASH_SIZE_BYTES'])
+matching_cmake_default_settings = set(['PICO_FLASH_SIZE_BYTES', 'PICO_RP2350_A2_SUPPORTED'])
+compulsory_defines = set(['PICO_FLASH_SIZE_BYTES'])
+
 DefineType = namedtuple("DefineType", ["name", "value", "resolved_value", "lineno"])

 def list_to_string_with(lst, joiner):
@@ -230,7 +235,13 @@ with open(board_header) as header_fh:
             if name in cmake_settings:
                 raise Exception("{}:{}  Multiple values for pico_cmake_set {} ({} and {})".format(board_header, lineno, name, cmake_settings[name].value, value))
             else:
-               cmake_settings[name] = DefineType(name, value, None, lineno)
+                if value:
+                    try:
+                        # most cmake settings are integer values
+                        value = int(value, 0)
+                    except ValueError:
+                        pass
+                cmake_settings[name] = DefineType(name, value, None, lineno)
             continue

         # look for "// pico_cmake_set_default BLAH_BLAH=42"
@@ -246,7 +257,13 @@ with open(board_header) as header_fh:
             if name in cmake_default_settings:
                 raise Exception("{}:{}  Multiple values for pico_cmake_set_default {} ({} and {})".format(board_header, lineno, name, cmake_default_settings[name].value, value))
             else:
-               cmake_default_settings[name] = DefineType(name, value, None, lineno)
+                if value:
+                    try:
+                        # most cmake settings are integer values
+                        value = int(value, 0)
+                    except ValueError:
+                        pass
+                cmake_default_settings[name] = DefineType(name, value, None, lineno)
             continue

         # look for "#else"
@@ -362,8 +379,9 @@ if board_header_basename == "none.h":
     chip = 'RP2040'
     other_chip = 'RP2350'
 else:
-    if 'PICO_PLATFORM' not in cmake_settings:
-        raise Exception("{} is missing a pico_cmake_set {} comment".format(board_header, 'PICO_PLATFORM'))
+    for setting in compulsory_cmake_settings:
+        if setting not in cmake_settings:
+            raise Exception("{} is missing a pico_cmake_set {} comment".format(board_header, setting))
     if cmake_settings['PICO_PLATFORM'].value == "rp2040":
         chip = 'RP2040'
         other_chip = 'RP2350'
@@ -375,19 +393,25 @@ else:
             chip = 'RP2350B'
         if not board_header.endswith("amethyst_fpga.h"):
             if 'PICO_RP2350_A2_SUPPORTED' not in cmake_default_settings:
-                raise Exception("{} uses chip {} but is missing a pico_cmake_set_default {}".format(board_header, chip, 'PICO_RP2350_A2_SUPPORTED'))
+                raise Exception("{} uses chip {} but is missing a pico_cmake_set_default {} comment".format(board_header, chip, 'PICO_RP2350_A2_SUPPORTED'))
             if 'PICO_RP2350_A2_SUPPORTED' not in defines:
                 raise Exception("{} uses chip {} but is missing a #define {}".format(board_header, chip, 'PICO_RP2350_A2_SUPPORTED'))
-            if int(cmake_default_settings['PICO_RP2350_A2_SUPPORTED'].value) != defines['PICO_RP2350_A2_SUPPORTED'].resolved_value:
-                raise Exception("{} has mismatched pico_cmake_set_default and #define values for {}".format(board_header, 'PICO_RP2350_A2_SUPPORTED'))
             if defines['PICO_RP2350_A2_SUPPORTED'].resolved_value != 1:
                 raise Exception("{} sets #define {} {} (should be 1)".format(board_header, chip, 'PICO_RP2350_A2_SUPPORTED', defines['PICO_RP2350_A2_SUPPORTED'].resolved_value))
-    if 'PICO_FLASH_SIZE_BYTES' not in cmake_default_settings:
-        raise Exception("{} is missing a pico_cmake_set_default {} comment".format(board_header, 'PICO_FLASH_SIZE_BYTES'))
-    if 'PICO_FLASH_SIZE_BYTES' not in defines:
-        raise Exception("{} is missing a #define {}".format(board_header, 'PICO_FLASH_SIZE_BYTES'))
-    if cmake_default_settings['PICO_FLASH_SIZE_BYTES'].value != defines['PICO_FLASH_SIZE_BYTES'].resolved_value:
-        raise Exception("{} has mismatched pico_cmake_set_default and #define values for {}".format(board_header, 'PICO_FLASH_SIZE_BYTES'))
+    for setting in compulsory_cmake_default_settings:
+        if setting not in cmake_default_settings:
+            raise Exception("{} is missing a pico_cmake_set_default {} comment".format(board_header, setting))
+    for setting in matching_cmake_default_settings:
+        if setting in cmake_default_settings and setting not in defines:
+            raise Exception("{} has pico_cmake_set_default {} but is missing a matching #define".format(board_header, setting))
+        elif setting in defines and setting not in cmake_default_settings:
+            raise Exception("{} has #define {} but is missing a matching pico_cmake_set_default comment".format(board_header, setting))
+        elif setting in defines and setting in cmake_default_settings:
+            if cmake_default_settings[setting].value != defines[setting].resolved_value:
+                raise Exception("{} has mismatched pico_cmake_set_default and #define values for {}".format(board_header, setting))
+    for setting in compulsory_defines:
+        if setting not in defines:
+            raise Exception("{} is missing a #define {}".format(board_header, setting))

 if chip is None:
     raise Exception("Couldn't determine chip for {}".format(board_header))

@will-v-pi can you be a bit more precise in the comment above "if you compile with... is only used in the CMake" doesn't make any sense (to me)... perhaps you mean "if you pass -Dxxx to CMake"

Yes, that's what I meant - I've updated the comment

So my limited CMake knowledge means that I don't fully understand all of this, but it seems to me like there are now a couple of settings (PICO_FLASH_SIZE_BYTES and PICO_RP2350_A2_SUPPORTED) which have to be set to the same value in both the "cmake world" (via pico_cmake_set_default) and also the "compiler world" (via #define). Is there any way we could come up with some generic mechanism, rather than needing e.g.
// pico_cmake_set_default PICO_FLASH_SIZE_BYTES = (4 * 1024 * 1024)
#ifndef PICO_FLASH_SIZE_BYTES
#define PICO_FLASH_SIZE_BYTES (4 * 1024 * 1024)
#endif

// pico_cmake_set_default PICO_RP2350_A2_SUPPORTED = 1
#ifndef PICO_RP2350_A2_SUPPORTED
#define PICO_RP2350_A2_SUPPORTED 1
#endif

in the header-file for every board that uses the RP2350? Or is this already the "best" way of handling this? (I guess my concern is how badly would "things go wrong" if the "cmake world" sees a different value to the "compiler world"?)

Personally, I think this is the "best" way of handling things - everything that directly affects the compilation is in normal pre-processor #defines, and then the things that affect the CMake configuration are in comments. The board checking scripts are available to check they match up, but even if the don't match it won't cause any major problems.
It would be fine for the "CMake World" to see a different value to the "compiler world" - for example for PICO_FLASH_SIZE_BYTES it just means that the linker script will have one flash size, and functions using the flash size (eg flash_range_erase) will assert values are in range based on a different size. This could mean that when linking my code it only uses 2MB of flash, but when erasing I can erase all 4MB of the flash, which could be a valid use case.

It would be fine for the "CMake World" to see a different value to the "compiler world"

Brilliant, thanks for reassuring my paranoid little brain :brain: :joy:


Playlog tests: Add missing tests

Add missing tests for playlog: load, play, reset the player engine, set up a new player engine, load and play the same track and reset; load, play, reset the player engine, set up a new player engine, load and play another track and reset
⚠ We can only run all player tests in all PRs again after this set of PRs are merged and we fix known existing flakiness.

This pull request enhances the PlayLogTests in Tests/PlayerTests/Playlog/PlayLogTests.swift by adding two new test functions. These tests cover scenarios involving loading, playing, resetting the player engine, and verifying play log events.
New test functions added:

test_load_and_play_and_resetPlayerEngine_and_setUpANewPlayerEngine_and_load_and_play_another_track_and_reset: This test covers the scenario of loading and playing a track, resetting the player engine, setting up a new player engine, loading and playing another track, and then resetting again. It verifies that the play log events are correctly recorded for both tracks.
test_load_and_play_and_resetPlayerEngine_and_setUpANewPlayerEngine_and_load_and_play_same_track_and_reset: This test covers the scenario of loading and playing a track, resetting the player engine, setting up a new player engine, loading and playing the same track again, and then resetting. It verifies that the play log events are correctly recorded for both instances of the same track.

Would this remove flakiness completely or reduce it? Just wondering if we need to run it a bunch of times to verify how less of a flaky it is 😅
GJ!

Still flaky unfortunately, I'm currently working on how to make them less flaky, and testing many many times locally.

Would this remove flakiness completely or reduce it? Just wondering if we need to run it a bunch of times to verify how less of a flaky it is 😅
GJ!

This is only adding new tests, so it can't be affecting the flakiness of previous tests in any way.
But they are not run in PR tests yet, so the flakiness is not affecting anyone.

This tests are ok, but I wonder if they are really testing different things.
PlayerEngine does not care if the MediaProduct is the same or a different one, so both tests from that point of view are testing exactly the same code.
Maybe the second test case was meant as a way to test the .repeatOne playback method? But that is a client implementation, it has nothing to do with the Player SDK in itself.

Original was for the repeat since it exists in android, for ios it has less value. I guess for us is more to make sure the items get changed. If we would break that, many other tests would fail as well of course.


After use start and build, not supported ie11

Environment
Environment:
OS: win7
Node: 10.15.3
npm: 6.11.3
Packages: (wanted => installed)
"react": "^16.8.6",
"react-app-polyfill": "^1.0.3",
"react-dev-utils": "^9.0.1",
"react-dom": "^16.8.6",
"react-polyfill": "0.0.2",
"react-redux": "^7.1.1",
"react-router": "^5.0.1",
"react-router-dom": "^5.0.1",
"url-loader": "1.1.2",
"webpack": "4.29.6",
"webpack-dev-server": "3.2.1",
"webpack-manifest-plugin": "2.0.4",
"workbox-webpack-plugin": "4.2.0"
"browserslist": {
"production": [
">0.2%",
"not dead",
"not op_mini all",
"not ie <= 11"
],
"development": [
"last 1 chrome version",
"last 1 firefox version",
"last 1 safari version",
"not ie <= 11"
]
},
"babel": {
"presets": [
"react-app"
]
}
package.zip

Looks like your browserslist is explicitly excluding ie 11. This is what you've configured for development: https://browserl.ist/?q=last+1+chrome+version%2C+last+1+firefox+version%2C+last+1+safari+version%2C+not+ie+<%3D+11

Looks like your browserslist is explicitly excluding ie 11. This is what you've configured for development: https://browserl.ist/?q=last+1+chrome+version%2C+last+1+firefox+version%2C+last+1+safari+version%2C+not+ie+<%3D+11

I changed the browserslist  configuration, but it still doesn't work in ie11

Looks like your browserslist is explicitly excluding ie 11. This is what you've configured for development: https://browserl.ist/?q=last+1+chrome+version%2C+last+1+firefox+version%2C+last+1+safari+version%2C+not+ie+<%3D+11

thank you very much.


Beetroot soup, mushroom stew & rabbit stew do not stack to 16

Minecraft version
1.21
Farmer's Delight version
2.1.7
Fabric Loader version
0.16.4
Fabric API version
0.102.0+1.21
Description
When picking up beetroot soups, mushroom stews or rabbit stews, they do not stack to 16 like they do in previous versions of farmer's delight.
Steps to reproduce
No response
Mod list
Fabric API, Farmer's Delight
Logs
No response
Minimal instance

[X] I have tested this on a minimal instance

Performance and shader mods

[ ] I am using performance or shader mods

Hi, i think we forgot to implement this previously. Ill go in and get this fixed later today.

Will this fix be backported to 1.20.1 by any chance?

Will this fix be backported to 1.20.1 by any chance?

? I thought it worked there, weird.

Am very sorry, I just checked again, and ye it works. I have a lot of instances Im trying to set up / fix and I misread some version numbers and got confused, my bad.


Pack and Upload a Solution Error

PAH Version: 1.8.1
PAC Version: 1.17.5+gcbb58e8
When I try to use the Function “Pack and Upload a Solution”, I become the current Error Message.

But when I use “Pack Solution” and Manually Upload, then it works.

Hi @mlnc21 thanks for reporting. I'll check this.

Hi @megel,
Thanks for the Response.
The size is 8310 KB.

Found this related to your reported error:
https://github.com/axios/axios/issues/4888#issuecomment-1206848584
I'll add this to the upload parameters:
await axios.post(url, data,{
                headers: headers,
                maxBodyLength: 104857600, //100mb
                maxContentLength: 104857600 //100mb
})

Vielen Dank, Herr Megel  :-)
Beste Grüße aus Bautzen ;)

Gern geschehen Martin! Der fix ist in v1.8.2 ... bitte testen.


Drop Boise Area VMWare User Group

Seems dead (not much activity since 2011.)
https://communities.vmware.com/community/archive/general/us-west/boise/content
https://www.facebook.com/Boise-Idaho-Vmware-User-Group-159464447437478/

We won't drop it yet. According to Facebook they had a meeting later in 2017.


CMake torqueConfig.h.in fix

A few parts of the engine check for TORQUECONFIG_H

Looks like this needs another #endif tacked onto the end to make it work, otherwise we get a mismatched pair.
Also, do we need to remove the pragma once? I remember seeing something somewhere(may have been Hal in the irc) talk about how having both the ifdef and the pragma can help cover more cases to improve compile times.


Release 0.4 never published to crates.io

I know this is duplicated from #30, but GitHub doesn't do a good job advertising new conversations in closed issues.
@seiflotfy, @florianjacob, @LukasKalbertodt  it'd be really appreciate it if any one of you could run cargo publish, it looks like the three of you are authors of this crate and you all should be able to do it.
I'm looking to this library to replace an old bloom filter implementation and the import/export feature added in 0.4 would be super useful for my use case.
Thanks a lot for writing this piece of code :pray:

Note: only owners of the package can release on crates.io, not necessarily the authors. The only owner is currently @seiflotfy.

I'll transfer ownership to you in a bit
On Mon, Sep 16, 2019, 12:23 Lukas Kalbertodt<EMAIL_ADDRESS>wrote:

Note: only owners of the package can release on crates.io, not
necessarily the authors. The only owner is currently @seiflotfy
https://github.com/seiflotfy.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/seiflotfy/rust-cuckoofilter/issues/34?email_source=notifications&email_token=AAA4YTL5I3Y3CXBDRSDHX3TQJ5NCVA5CNFSM4IW5BCU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6YWN4A#issuecomment-531719920,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAA4YTPFECTF63P3UPMQV53QJ5NCVANCNFSM4IW5BCUQ
.

@seiflotfy I haven't received an owner invite by now, just FYI.
I'm not sure if I'm the right one to maintain this crate, but of course you can add me for now so that I can do some management stuff (like releasing a new version). I can still find a new maintainer afterwards. I'm glad to help out since you are currently lacking the time or motivation to maintain this (absolutely nothing wrong with that!) :)
Another possibility would be the "Rust Bus": https://users.rust-lang.org/t/bus-factor-1-for-crates/17046
A small organization for exactly these situations: keeping a crate alive when the original owner cannot put work into it, mostly because life.
So just add me or someone of the Rust Bus as owner and we'll take care of the crate :)

Just pinging if there is any progress on this. Since its been half a year since last update

@seiflotfy just pining here as well. I would very much appreciate to keep the project alive,  before it is  forked or work is duplicated.

On it

@LukasKalbertodt you should have access now

@seiflotfy Thanks a ton, I did receive the GitHub and crates.io invite. I saw you already published 0.4.0.
I also saw that the repo was moved to axiomhq, which appears to be where you work. So what are your future plan for maintaining this crate? Do you want to actively maintain now? Or should I take the main role of maintainership (though I would probably delegate to someone else, but I'll see). In that case, the association with axiomhq is a bit strange though. But yeah, just tell me what your plans are! :)

I am the co-founder of axiomhq but I have a couple of rust developers here
who don't mind getting involved. They are reading into cuckoofilters. But
this is open-source so whoever is working on ti gets to maintain it.
On Mon, Jul 13, 2020 at 11:32 AM Lukas Kalbertodt<EMAIL_ADDRESS>wrote:

@seiflotfy https://github.com/seiflotfy Thanks a ton, I did receive the
GitHub and crates.io invite. I saw you already published 0.4.0.
I also saw that the repo was moved to axiomhq, which appears to be where
you work. So what are your future plan for maintaining this crate? Do you
want to actively maintain now? Or should I take the main role of
maintainership (though I would probably delegate to someone else, but I'll
see). In that case, the association with axiomhq is a bit strange though.
But yeah, just tell me what your plans are! :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/axiomhq/rust-cuckoofilter/issues/34#issuecomment-657443140,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA4YTK2QXKLZMTSHCVD7RTR3LIDTANCNFSM4IW5BCUQ
.

Ok, good to know. So I will assume that you all will be the main maintainers and I will just step in as a last backup if required. Great to see you back!

And since 0.4.0 was released, this can be closed.

@LukasKalbertodt you are also a maintainer and feel free


Update sbt-scoverage to 1.9.0

Updates org.scoverage:sbt-scoverage from 1.8.2 to 1.9.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scoverage", artifactId = "sbt-scoverage" } ]

labels: sbt-plugin-update, semver-minor

It would be helpful to me in the Scala community build if this were merged, to help us test the sbt 1.6 milestones.


[Snyk] Security upgrade pillow from 9.0.1 to 10.0.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `pip` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

requirements.txt

⚠ Warning
pikepdf 5.0.0 requires Pillow, which is not installed.

Vulnerabilities that will be fixed
By pinning:

Severity
Priority Score (*)
Issue
Upgrade
Breaking Change
Exploit Maturity

865/1000  Why? Currently trending on Twitter, Mature exploit, Recently disclosed, Has a fix available, CVSS 7.3
Heap-based Buffer Overflow SNYK-PYTHON-PILLOW-5918878
pillow:  9.0.1 -> 10.0.1
No
Mature

(*) Note that the real score may have changed since the PR was raised.
Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Codecov Report

Merging #363 (fcea6cf) into main (210886f) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   90.38%   90.37%   -0.01%
==========================================
  Files         336      336
  Lines       11932    11932
  Branches      847      847
==========================================
- Hits        10785    10784       -1
  Misses       1013     1013
- Partials      134      135       +1

see 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Sand Color shading want to disable DynamicTress for cactus

its not a really big deal since im making the texture myself
somehow block under cactus for sand(rooty sand block ) have different shading color
already tinker the BDcraft texture, removing all other mods that have connected texture, reading other topic that have similar problem.
as you stated https://github.com/ferreusveritas/DynamicTrees/issues/188
""I have not yet done this for the rooty sand block since I haven't yet decided if it's worth it""
is there a way i disable only cactus dynamic trees, cause i really hate the colour
https://i.imgur.com/SyW9Qqk.png

Set vanillaCactusWorldGen to false in the config file to disable the generation of Dynamic Cactus.


Support all rules_swift rules

rules_swift Rules:

[x] swift_library
[x] swift_binary
[x] swift_test
[x] #93
[x] #90
[ ] #91
[ ] #92

While we don't have the "best" support swift_proto_library and swift_grpc_library, we technically support them. I feel this is finished.


fly reports unknown authority

x509: certificate signed by unknown authority
is the targeted Concourse running? better go catch it lol
Is the response when I target my concourse server.  I have the full TLS certificate chain in my atc config.   When using an older version of fly it works but using the latest 1.13.0 it still fails.
I can use the --insecure flag on fly but it does not make sense why it would fail if I have the full certificate chain.
Thanks,
Andrew Edgar

@andrew-edgar thanks for reporting this. It might be related to https://github.com/concourse/concourse/issues/2133

hi @andrew-edgar , could you try visit CI in browser in this case so we can confirm it is duplicated to #2133 ?

Hey @andrew-edgar,
I'm closing this issue for now, feel free to let us know if you face this issue again!
Thx!!


feat(android): Tunnel lifecycle implementation

Fixes #1970

Implemented TunnelService and added dummy routes.
Updated service lifecycle and implemented foreground notification.
Updated TunnelManager to observe events and propagate them to its listeners.

@pratikvelani Ah, I found an issue after merging. It seems that TunnelSession.disconnect is not called after Sign out is pressed. This I believe might cause a memory leak since the old Session is never dropped. Should I open an issue for this or is it more of a quick fix?

@jamilbk It should be a quick fix, I will include it on my next PR.


Fix bug with debug info

The list didn't have min and max set and only clipped to a correct value meaning the scroll didn't work correctly at the extrema (v could go up or down beyond the bounds).

Argh - thanks for the fix!


Send Funds Decimal Point Glitching

Subject of the issue
Send funds is glitchy
Your environment

1.3.0+371/2274528f
Android 11

Decimal place jumps around
https://user-images.githubusercontent.com/111296437/219493276-839e008e-72ba-4d07-807d-2e516ba40e7e.mp4

Fixed in 1.3.2


[MINOR] Typos

Pull request checklist
fixed a couple of typos

[x] Documentation content
[ ] Documentation page organization

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Replace the TritonGEN Barrier operation with something from upstream MLIR

The TritonGEN BarrierOp is quite generic, so it would be good to use a solution that exists upstream in the LLVM MLIR project. Unfortunately it can't be directly replaced with gpu.barrier since gpu.barrier lacks the ability to specify the address space where changes should be observable (RFC about that).

Update: I've got a POC branch at #2449 and I've locally verified it works. It would be good to get approval if this is a direction we want to take.

Should be closed when PR's merged


Why there is a final relu in the 1_F network

Why is there a relu layer after the fc2 layer in the 1_F neural network?
Traditionally, there is no relu layer after final fully connected layer.

Yes, you are right. It's not necessary. It's kind of strange to add that relu layer :joy:
I add that relu layer just because of my target y (landmark positions) are all positive.


Assign a DEP to a mailbox in hybrid environment

Could you please provide instructions to assign a DEP to a mailbox in a hybrid environment where directory sync means that mailbox attributes are managed from on-prem?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a585eca1-dad6-3afd-43ce-8c4b11102dd3
Version Independent ID: a1d708a7-774f-0c23-b428-28919ef5d46a
Content: Controlling your data in Office 365 using Customer Key
Content Source: microsoft-365/compliance/controlling-your-data-using-customer-key.md
Service: o365-seccomp
GitHub Login: @KCCross
Microsoft Alias: krowley

@IdahoR  - Thank you for submitting feedback.
I will get this issue over to the Microsoft 365 writing team for investigation.
Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

@IdahoR - Thank you for your message, Please note DEP is only applicable on Office365 online. You can't manage them from on-prem.
You can your feedback using the user voice channel.
@mypil FYI please.

@IdahoR - Thank you for engaging with the community here for the docs.
I know the product teams are always looking for user feedback on how to make Microsoft 365 better. They keep a close tab on user feedback and it would be awesome if you could add your voice in
User Voice.
You might find others have made a similar request that you can add to, or you can open a new one. Let us know here if you do so we can up-vote your request.
Thank you for your contribution to make the docs better! Much appreciated!


Flutter: Fix packages to specific versions

https://github.com/flet-dev/flet/issues/434

It's not recommended to commit package's pubspec.lock: https://dart.dev/guides/libraries/private-files#pubspeclock


Enable log forwarding from Azure SDK.

Addresses https://github.com/Azure/azure-sdk-for-net/issues/20085

/azp run net - servicebus - tests


Cache data on leader elected and use in in subsequent reads.

We should add tests for the cache.

Added test cases.

Create a new PR that is based on master


Update observedGeneration on resource change

Is your feature request related to a problem? Please describe.
We use spotify/kubernetes-deploy to deliver our applications into Kubernetes and it does not know anything about Certificate resources so it can't determine whether they were successfully deployed.
kubernetes-deploy can use custom annotations to add that functionality but kubernetes-deploy uses the ObservedGeneration status message to determine whether a resources has been updated.
Describe the solution you'd like
Update the ObservedGeneration status message when the resources changes.
Additional context
https://github.com/Shopify/kubernetes-deploy#deploying-custom-resources
/kind feature

Thanks for the issue 😄
Looking into how the 'generation' field on CRDs work in newer versions of Kubernetes, it seems they should be automatically incremented whenever a change to the resource is made: https://github.com/kubernetes/kubernetes/pull/69059
We don't currently use the status/spec separation on our CRD, in order to better support old clusters, meaning the generation field should be incremented whenever any changes are made to the resource.
What version of Kubernetes have you been running/testing this on? 😄

@munnerz I believe the issue is status.observedGeneration, not metadata.generation.

@munnerz Are are on kubernetes v1.12.3 and cert-manager v0.4.1.
We need to upgrade both.
And yes the issue is with status.observedGeneration not metadata.generation.

Hm, interesting.
So we don't currently have an observedGeneration field at all, as it's not something that we've required internally.
It seems like your own controller(s) utilising this and using it to reason about the progress that cert-manager has made may be a bit too low-level. Is there a specific 'event' or 'edge' that you are specifically interested in? i.e. are you trying to detect when a certificate has been issued/is 'ready'?
We now expose the Ready status condition and make good use of it, as a means to know when a Certificate exists and is up to date (or if it has expired, etc.). Would that suffice in this case?
I'd rather provide higher level, useful constructs as part of our API spec, rather than exposing the inner-workings of cert-manager's implementation as part of the CRD.

I did notice you are providing the Ready status messages and was going to make use of those to tell kubernetes-deploy what to look for for it's pass/fail detection.
Shopify/kubernetes-deploy uses status.ObservedGeneration and metadata.generation to detect when a resource has changed.
I am not sure how they implement that but maybe we can adjust it when only generation exists.
I will investigate that end and get back to you.
Thanks for the help so far.

kubernetes-deploy compares metadta.generstion with status.ObservedGeneration across the board as the way to determine whether a resource is up to date.
It uses that as part of it's deployment process to check pass/fail conditions on a deploy so we can determine whether the deploy was successful.
We are trying to use that functionality to make sure a certificate has been issued before we declare a deployment successful.
Does that explain our use case enough?
I am happy to provide further details if needed.
How much work would it be to include status.Observedgeneration in cert-manager?

That makes a lot of sense 😄

kubernetes-deploy compares metadta.generstion with status.ObservedGeneration across the board as the way to determine whether a resource is up to date.

This seems like strange decision - not all Kubernetes resources have a status.observedGeneration field, surely meaning that kubernetes-deploy runs into this problem even with core Kubernetes resource types? (e.g. Services, ConfigMaps, Secrets).

How much work would it be to include status.Observedgeneration in cert-manager?

I think it'd definitely be non-trivial. To do so would require us to define 'observed', and I am not too sure how we could do that given the long-lived nature of Certificate resources (i.e. we re-observe resources at renewal time, despite the resource itself having not changed).
I'd be reluctant for us to add an additional status field that isn't used internally by CM, as it could mislead users into thinking that cert-manager has "finished" processing a Certificate resource, despite us not really having the concept of 'finishing'.
This may be something for us to consider/refactor, so that it is possible to define this more strictly, but that is a much larger design change.

Thanks for the feedback @munnerz.
I will take it up with the maintainers of kubernetes-deploy and find out how we can proceed.

I opened an issue on kubernetes-deploy and got a response.
https://github.com/Shopify/kubernetes-deploy/issues/472

This seems like strange decision - not all Kubernetes resources have a status.observedGeneration field, surely meaning that kubernetes-deploy runs into this problem even with core Kubernetes resource types? (e.g. Services, ConfigMaps, Secrets).

Kubernetes-deploy handles core resources in more specific, case-by-case, manners. For custom resources, since we don't have any a priori knowledge of what a given CR will look like, we needed to provide some generic mechanism for assessing its state.
The main issue we were running into was that we needed a way to know whether a given CR spec and status were aligned. That is, is the status a reflection of the current spec, or is it stale and we need to wait for the controller to process any new changes. Without this, we would immediately observe the status of a CR and make a decision on that, irrespective of what the controller was about to do. In essence, we would always be one step behind.

I think it'd definitely be non-trivial. To do so would require us to define 'observed', and I am not too sure how we could do that given the long-lived nature of Certificate resources (i.e. we re-observe resources at renewal time, despite the resource itself having not changed)

We adopt the same strategy with our CR controllers as well (re-observation). This doesn't preclude the use of observedGeneration, since the status can certainly change due to external factors. The main point is that we know the controller's status is a reflection of the current spec generation and so can be considered an accurate reflection of the current state of the resource.

I don't think this is something we have a clear path to implementing in our own codebase.
We currently provide a 'signal' on the readiness of a certificate through the status.conditions[name="Ready"] field. Quite a number of other k8s resources also include a 'Ready' status condition, which could be used similarly.
I don't think we will implemented observedGeneration (at least not at this time), as whilst we do have the notion of 'readiness', we don't have the ability to say "this certificates matches generation X". User interaction (i.e. deleting a Secret resource) would raise the question of "what should the observed generation be", and I think having easy-to-understand concepts as opposed to simply machine-readable concepts should be the priority (i.e. a boolean 'readiness' vs 'which version of the spec have we observed at some point in the past'). The guarantees for a Ready field are much better defined than observedGeneration, in our case.
I am fairly sure there's been some wider discussion on this in Kubernetes (i.e. tracking when a resource is 'complete'), and it is antithetical to the loosely coupled, asynchronous and eventually consistent model of k8s. I'd need to dig out these links though 🙈

I am fairly sure there's been some wider discussion on this in Kubernetes (i.e. tracking when a resource is 'complete'), and it is antithetical to the loosely coupled, asynchronous and eventually consistent model of k8s. I'd need to dig out these links though

I don't believe that observedGeneration indicates any kind of finality of the state of the resource, nor is that the intention of the field. For example, many core resources implement observedGeneration, e.g. Deployments, ReplicaSets, PodDisruptionBudgets etc. For all these resources, the status can change multiple times for a given observedGeneration.
In essence, observedGeneration isn't about declaring a terminal point in a resource's lifecycle, but merely serves as a marker that the observed status is reflective of the current specification of a resource at a given point in time.
Consider the case of a Deployment spec. Let's say the image to pull is pointing to a non-existent resource. If we update the Deployment to now point to a new image, we no longer care about the (now out-of-date) failing status; we want to wait until the controller has processed the resource according to the updated spec and, only then, reinterpret the Status (which, of course, may still be failing).
In sum, I think you're thinking about observedGeneration as representing some static and final quality of the underlying resource, but I argue this is erroneous. It merely serves as a notice about when to consider the status of an object relevant to its current specification.

@munnerz Does that explanation from @timothysmith0609 change your opinion on the plausibility of implementing this?

@munnerz We would be willing to contribute an implementation of this if you would be willing to provide some guidance and agree in principle to merge it. Any thoughts?

ref https://github.com/jetstack/cert-manager/pull/3545#discussion_r565232466 this feature would also be useful here
Also ref https://github.com/jetstack/cert-manager/issues/3585
In both these instances, we are discussing adding observedGeneration to each status condition rather than one overarching status.observedGeneration field.
/reopen

ref https://github.com/jetstack/cert-manager/pull/3545#discussion_r565232466 this feature would also be useful here
Also ref https://github.com/jetstack/cert-manager/issues/3585
In both these instances, we are discussing adding observedGeneration to each status condition rather than one overarching status.observedGeneration field.
/reopen

/remove-lifecycle rotten
/area api

/remove-lifecycle rotten
/area api

/priority important-soon

/priority important-soon

/assign

/assign

/milestone v1.3
While #3613 would fix this particular issue, it should be extended to all of our resources' conditions


Add my data into file

I know this repo has been excluded from hacktoberfest, but I'd still love to contribute 😛

Thanks a lot for contributing @officialpiyush
Congrats 🎉, your PR got merged. To be eligible for the swags from ClueLess. Follow this steps.
Note that this repo is excluded from Hacktoberfest but this PR is still eligible for ClueLess Swags.

Star this repository. ⭐

SignIn / SignUp in [ClueLess Website](https://www.clueless.tech/) .

Go to profile section from the top right hand corner.

Comment your profile URL under this comment tagging the person who merged your PR.

That’s it. Follow the leaderboard !
And don’t forget to share your achievement with your friends.

@Rajdip019 here is my profile https://www.clueless.tech/profile/admin/116836714120940476348